Custom table provider factories

Which issue does this PR close?
Closes #3310.
Rationale for this change
I would like to allow users to register custom table types at runtime.
What changes are included in this PR?

A new concept of a TableProviderFactory
A new FileType::Custom(String) to allow the parser to pass information about these tables
A HashMap of TableProviderFactorys on the SessionContext to allow them to be registered programmatically but used dynamically

Are there any user-facing changes?
They can now register custom tables.

@andygrove @alamb @houqp This was a quick and dirty implementation, but I thought I would throw it out there to collect your thoughts on it. If something like this is deemed acceptable and merged, we'd extend Ballista to use it as well, then either:

make a fork of Ballista with delta-rs included
make our own server that depends on Ballista as a library but also depends on delta-rs and has it's own void main()
Add a plugin architecture to Ballista to allow it to load delta-rs dynamically as an .so file

I think this looks like a great start. Thanks @avantgardnerio

Oh, also related to https://github.com/apache/arrow-datafusion/issues/2025

I guess I should mention @matthewmturner since I linked that ticket.

@avantgardnerio This is very cool. Unfortunately I haven't been able to work on datafusion lately but I could definitely see integrating this into datafusion tui again when I start again.

@ianmcook I should probably start CCing you on these PRs as well.

Codecov Report

Merging #3311 (8371753) into master (3d37016) will decrease coverage by 0.22%.
The diff coverage is 70.37%.

@@            Coverage Diff             @@
##           master    #3311      +/-   ##
==========================================
- Coverage   85.74%   85.51%   -0.23%
==========================================
  Files         294      294
  Lines       53770    54065     +295
==========================================
+ Hits        46104    46236     +132
- Misses       7666     7829     +163

Impacted Files
Coverage Δ

datafusion/core/src/datasource/datasource.rs
100.00% <ø> (ø)

datafusion/core/tests/sql/timestamp.rs
99.65% <ø> (-0.01%)
:arrow_down:

datafusion/expr/src/logical_plan/plan.rs
78.05% <ø> (-0.17%)
:arrow_down:

datafusion/proto/src/lib.rs
93.52% <ø> (ø)

datafusion/proto/src/logical_plan.rs
17.84% <0.00%> (+0.49%)
:arrow_up:

datafusion/core/tests/sql/create_drop.rs
91.59% <76.00%> (-4.15%)
:arrow_down:

datafusion/core/src/execution/context.rs
78.46% <79.59%> (+0.22%)
:arrow_up:

datafusion/sql/src/parser.rs
83.52% <100.00%> (-0.45%)
:arrow_down:

datafusion/sql/src/planner.rs
80.67% <100.00%> (+0.05%)
:arrow_up:

datafusion/physical-expr/src/crypto_expressions.rs
56.11% <0.00%> (-6.39%)
:arrow_down:

... and 26 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Thanks @avantgardnerio


[bash 11 05] sample 49, C# has wrong website name

The web page that opens when the sample runs has the wrong displayname 'NLP With Dispatch Sample'

not reproducible


mavlink: use 'buttons' field of MANUAL_CONTROL message as mode switches

This will allow mode switching from RC connected via telemetry. Not tested yet.

Cool, looking forward to the test!

Ah, sorry, forgot to write :) Testing was successful, not so good as Futaba (signal losses sometimes, a bit increased latency), but more than usable. Tested with 868MHz HM-TRP, with short antennas at 500m distance.

I've applied this in master, thanks!


Review log verbosity produced by file download from manifest

From @matthewspeir:

A verbosity setting to hide warning/retry or other unnecessary messages would be great. Let me decide how much info I want to see or hide the details and put them in a log file.
Basically I just want to know if it succeeded in downloading a file (and sometimes I don’t even care to see that.)

usage: hca [-h] [--version] [--log-level {DEBUG,INFO,WARNING,CRITICAL,ERROR}]
           {help,upload,dss}

In practice it looks like
``hca --log-level INFO dss ...`

Notes 4/8/19 : 9:20 AM
Complete
Tested --log-level {DEBUG,INFO,WARNING} commands to see if they operate correctly.
--log-level works as expected, setting level to INFO prints out only bundle information as requested.


Termination part in testsuite is always failing in all applications

All requests in Termination part fail with test error, as dummyUri is not set. This is due to the previous request in PreTermination: Clearing collection data : pm.environment.clear();
The Termination requests all call for: URI = pm.environment.get("dummyUri");
I don't really see a purpose for the termination requests, why check ping.openbackhaul.com 4 times? Please either remove the requests or fix the Pre-request scripts.
This is for all applications.

Clearing has been pushed to PostTermination part


dask dataframe - collect list example

Good discussion here about how to implement collect list with dask dataframe https://github.com/dask/dask/issues/2706
I would like to create an example in here: https://docs.dask.org/en/latest/dataframe-groupby.html#aggregate (https://github.com/dask/dask/blob/master/docs/source/dataframe-groupby.rst#aggregate)

That sounds great, thanks!


Contributing section in the README

A contributing section in the README would be nice. I made a short draft for you:

Contributing
Start a postgres Docker container for testing using:
docker run --rm -e POSTGRES_PASSWORD=postgres POSTGRES_DB=github_actions postgres

Then, you can run tests in another window using:
virtualenv env
source env/bin/activate
pip install '.[test]'
python manage.py test

Before you contribute, make sure you lint your code:
pip install '.[lint]'
flake8 --exclude .git,pycache,docs/conf.py,build,dist,env

After your code is done, feel free to open a PR.

Thanks for the suggestion, we will take a look at it!


rtorrent: 0.9.4 -> 0.9.6

Perhaps better to use http://rtorrent.net/downloads/ as upstream source?

@rycee, if anything github would be a more reliable source if there is any reason to change it.
@ebzzry Just a heads up that someone is probably going to complain about this being broken even though it isn't.  After 0.9.4+ the entire configuration syntax was overhauled so will break all existing configs.  The information is in the docs and the github wiki are both partially or completely outdated so I have an example config that I use: https://github.com/codyopel/dotfiles/blob/master/rtorrent.rc

@rycee, @codyopel what upstream source should we use?
@codyopel Yes, but this is something that we should expect, even though it is a bit unfortunate. Maybe he should have changed the version number to 0.10.0, to indicate a non-backward compatible change.

@rycee, @codyopel I used http://rtorrent.net/downloads as the upstream source, for now.

Thats fine, I typically use github's release tarballs just because github rarely has downtime and is more reliable in that sense.
And yeah the config changes are unavoidable.

Both rtorrent.net or github are fine with me. Unfortunately the downloads are not identical, the tarball on rtorrent.net seems to be generated by make dist or something similar while the github one is the typical "raw repo" style.
Had they been the same I suppose the most prudent thing would have been to include both in the fetchurl call.

Please squash commits.

@jagajaga squashed.


The 'remove' functionality under "Alexa" lists does not seem to work but the 'add' functionality does

When attempting to remove an item from my todo list using 'Remove Item' under 'Alexa Lists', it does not appear to do anything, I have double checked the item ID to make sure it's correct but it does not seem to work. Adding items on the other hand, does work. There doesn't appear to be any errors in the debug.

Maybe it's related to this
https://www.theverge.com/2024/5/31/24168681/amazon-alexa-third-party-shopping-list-integration-going-away

It is possible to edit a list item to mark it complete, however.
Incidentally, it is no longer possible to delete completed items either from the desktop of using the app.


v1.8 backports 2020-10-19 p2

v1.8 backports 2020-10-19

#13630 -- contrib: match commit subject exactly when searching for upstream commit (@tklauser)

Once this PR is merged, you can update the PR labels via:
$ for pr in 13630; do contrib/backporting/set-labels.py $pr done 1.8; done

Not master, meant for v1.8


Implement GET /user/activities

Adds Gitlab.activities, valid for admin auth tokens only: https://docs.gitlab.com/ee/api/users.html#get-user-activities-admin-only

Codeclimate is failing with /usr/local/lib/ruby/site_ruby/2.4.0/rubygems/core_ext/kernel_require.rb:122:in require': cannot load such file -- rubocop-performance`

Thank you 🖤


[patch] add declaration form fields

https://github.com/edenlabllc/ehealth.api/issues/1962

Coverage increased (+11.4%) to 90.825% when pulling ed9471c85cb89d05aa265be313bca5369276f2c4 on declaration_form_fields#1962 into 5139babb862479a2ef331c546d42dfdd1eee9dbe on master.


Proposed major revisions to Laradock

Hi everyone,
Currently, Laradock has one very large docker-compose.yml file and one large env-example file.
With the demand of more containers and features from users, maintaining, extending and simply using these files will become increasingly difficult. (https://github.com/laradock/laradock/issues/1053) So, I did a major reworking of Laradock by splitting the docker-compose.yml and env-example into smaller files, one of each for each Docker image. Then, I wrote a Bash script to manage these docker-compose.yml and env example files and provide a number of handy commands for using Laradock and docker-compose.
Goals of this revision:

Improve modularity and extensibility of the system
Improve user experience for power users and novice alike with a CLI tool.

Commands:

laradock build -- Generate the .env file and run docker-compose build.
laradock dockercompose -- Execute docker-compose with the given arguments
laradock down -- Stop and remove containers and networks, optionally volumes and images as well.
laradock help -- Shows help for the CLI.
laradock init -- Initializes Laradock into existing projects.
laradock install -- Install local copy of specific modules into your project.
laradock linkcli -- Creates a link to this CLI.
laradock logs -- View output from containers.
laradock tty -- Execute docker-compose exec -it <container> bash.
laradock up -- Create and start containers.

Features

Generates two files .laradock.example and .laradock.env.

.laradock.example is for project specific customizations
.laradock.env is for sensitive information, such as usernames, passwords, keys, etc.

Only include Docker containers and variables that are needed for your project.
Automatically, dependency inclusion for docker-compose.yml's and .env's.
At build time, using .laradock.example and .laradock.env, .env is generated automatically.
Variable substitution within the .env files similarly to within the docker-compose.yml files, including default values.
Just-in-time creation of the .env for all laradock (up|down|tty|logs|dockercompose) commands if .env output is detected as changed.
Install local copy of modules into your projects, enable customization of site configs, dockerfiles, etc without editing the originals.
Generate single docker-compose.yml output for systems that can't run laradock or projects that don't want to depend on laradock in production.
Add Node image and container.

Changes

docker-compose.yml versions upgraded to 2.2, adds support for default value for variables.
All images will be named laradock/<image>:local.<tag>
Image build paths specified in .env file.
All modules, grouped into modules directory.
Missing variables, for hardcoded ports and values in docker-compose.yml's, added to .env's.
Add common, LOG_PATH and USERCONFIG_PATH variables.

Remaining Tasks

Add commands and facilities to register and unregister commands and modules "plugins".
Add update and versioning commands.
Performance improvements, and fix bugs. Reduce startup times.
Update documentations

Additional commands and debugging:

See ENABLE_PRIVATE_VARIABLES=true laradock help
VERBOSE (between 0 "silent" and 7 "verbose")

Still a work in progress.
But you can check it out here, at https://github.com/vwchu/laradock.
Could use any feedback or contributions.
Updated: 2017.07.25 (NEW in bold).

@laradock/admins Hello guys, hope you all doing well.
Please check this interesting feature whenever you have some free time. Would love to get your opinions and feedbacks.

@vwchu @Mahmoudz Not related to this, but while we're at it, can we update certbot to use certbot and not letsencrypt?
Also, it would be great if we could -

Somehow copy paste the certs to right place(probably to a .ssh folder in application).
Add some default configuration for ssl in apache/nginx containers so that ssl could work out of box.

We can also discuss here https://github.com/laradock/cli/issues/1 maybe I can write CLI tool using Golang which supports Windows, Linux and MacOS.

@vwchu Hello, will this tool be helpful for your implementation of the CLI?
Orbit is made by @gulien maybe he can share with us an intro about it here.

Hi @vwchu!
Looks like you did some nice works here 😃
Orbit might indeed helps you a lot in your job!
Its first functionality is its ability to generate files from templates using values provided by one or more YAML files and one or more .env files. In your project, you rely a lot on .env files to setup your docker-compose.yml files.  Orbit might handle for you the generation of those .env files using valus provided by a .env file and a laradock.yml file. The first would contain sensible data (secrets for example) and environments related data. The last would contain cross-environments data (users of modules, ports and so on).
Also, an interesting functionality of Orbit is to let you define commands in a YAML file.
From the documentation:

commands:
  - use: "my_first_command"
    run:
      - command [args]
      - command [args]
      - ...
  - use: "my_second_command"
    run:
      - command [args]
      - command [args]
      - ...

the use attribute is the name of your Orbit command.
the run attribute is the stack of external commands to run.
an external command is a binary which is available in your $PATH.

We could imagine the following:
Project structure
.
├── config
     └── orbit # folder which contains sub Orbit configuration files
├── modules
     └── a_module
          └── .env.blueprint # a .env template
├── orbit.yml # the main Orbit configuration file
├── .env # the main .env file
└── laradock.yml # the cross-environments data

modules/a_module/.env.blueprint
A_USER={{ Values.Laradock.a_module.a_user }}
A_SECRET={{ .EnvFiles.Laradock.A_SECRET }}
A_PORT={{ Values.Laradock.a_module.a_port }}

.env
A_SECRET=my_awesome_secret

laradock.yml
a_module:
    a_user: my_awesome_user
    a_port: my_awesome_port

config/orbit/orbit-generate.yml
commands:
  - use: "generate-a-module"
    run:
      - orbit generate -t=modules/a_module/.env.blueprint -o=modules/a_module/.env -v=Laradock,laradock.yml -e=Laradock,.env

orbit.yml
commands:
  - use: "generate"
    run:
      - orbit run generate-a-module -c=config/orbit/orbit-generate.yml
      - ...

So, when running orbit run generate at the root of the project, Orbit will generate the .env file of  a_module 👍 ! Of course, this is a basic example. As Orbit uses the Go package text/templateunder the hood as a template engine, you have at your disposal a interesting amount of logic for your templates.
Also, you wrote a lot of nice scripts, which are unfortunately not cross-platform. We could imagine having a "Laradock image" which contains those scripts. See here how I handled calling scripts from a container with Orbit.
Last but not least, you should take a look at the kickoff-docker-php to have a real example on how I used Orbit to run my stack.
If you need help, let me know 😄 ! I'll be glad to help!

Hi @Mahmoudz @gulien, I'll definitely have a look at Orbit. Looks promising for a rewrite into Go. Something that I have been considering, but I just have been too busy lately and am not too familiar with Go.

@vwchu Your project structure inspired me for the first v2.0.0 stable release of my project! 😄
You have now a complete example at your disposal. 😉

I am very interested in discussion around a restructure of Laradock.
Using it in dev, the changes I have had to make to laradock's various configs are numerous and hard to find. The only way I can really know what I've changed is manual file diffs and git history. I'm just talking simple things like php memory allocation, installing libssh2, adding a shared volume or three etc
I'm also working toward using laradock in production, so the configuration management becomes even more difficult; most prod config need to inherit from dev, but some things need to extend it, some things need to be removed.
I am hoping there might be a better way! @vwchu do you think your changes would help resolve the above concerns?
As a docker newb Laradock currently feels simple and easy to understand — really just a bunch of fine-tuned standard docker configs — so I'm nervous about introducing "proprietary" stuff to it. I'm probably asking for the impossible — powerful but simple to understand :)

Hi @jeff-h, sorry for the delay response. Haven't been able to devote much time to this project lately.
My original proposal was to restructure the project was rooted the following concerns and goals:

I only want the modules that I use
Similarly, I only want to deal with the configuration for the modules use
Modules should be independent from each other and dependencies between them should be explicit and versioned.
Module implementation should be libraries (immutable / blank box to users)
Configurations are separate from implementations and centralized. Managed by the users with a generated scaffolding provided.

Originally, I used a shell script to prototype this, but it was too slow. Thinking currently about a solution using a mix between Docker hub, a package manager, Docker in Docker, and maybe multi stage Docker builds.
Another effort has been to make a Go-based CLI laradock/cli but not sure about its progress and status.
Unfortunately I don't have the time currently to experiment. Maybe in the holiday or new year. But it would be probably be from scratch with modules ported over eventually if it works.
-- VC

Interesting development. Was looking into easier ways to setup Laradock for development as well as production. Tips on what do do and not do for production specifically. I would prefer to work with one docker-compose.yml file and have it all work on development and production using a secure enough setup and a different SSL Certificate for both local and productions setups. Then I bumped into this thread. I agree it would be easier to have a modular approach so you do not have to wade through a large .env and docker-compose.yml file. Would also be awesome to be able to grab modules using a command like tool. Perhaps a bit like Laravel and its packages. But I see this setup is tough and might not come to fruition any time soon. Will keep track of this thread while I keep on learning to tweak my  Laradock setup with Nginx, MariaDB, Redis, PHP FPM, Horizon.


Filter only undefined values.

This PR implements #11421.

Acceptance: 👍
I'll fix the conflict.

Travis passed, merging 💃


take it or leave it

I needed to clean some stuff up for my own use, but I figured id PR so you can keep the changes if you want.
I added basic support for timecodes, fixed typos, and made small tweaks to things that I didn't like.
The commits are going to be trash and non functional because I used this repo to share code between my home PC and the laptop I use to write code while pretending to pay attention in class, so only the last commit is good.
Also I might make a fully fledged WLED library with support for the other protocols like JSON API, so hopefuly you don't mind if I copy and paste some useful bits from this.

@paulwrath1223 nice

the only thing i dislike is the unwraps in the lib but i'll fix that and merge

my bad i skimmed it, no unwraps i cared about, merged.
@paulwrath1223 i used it to drive
https://www.youtube.com/watch?v=0l2mkmrPq7s
but my controller code is trash so let me know what you build, will be interesting


Remove instanceof use when generating JSON manifest from chart

This is an issue on at least version 2.3.44 and earlier of cdk8s. The actual issue experienced was that, when using aws-cdk-lib/aws-eks.Cluster.addCdk8sChart, the resulting CDK template had an empty Manifest in the custom resource. This occurred after we abstracted out some common low-level CDK8s classes to a library in our monorepo, to make it easier to use the patterns across multiple CDK apps that needed to deploy CDK8s charts to EKS clusters.
I eventually tracked the issue down to the chartToKube function's use of instanceof: https://github.com/cdk8s-team/cdk8s-core/blob/379953a0928c3cb47392dbabefcde9811de5d571/src/app.ts#L289-L294
When classes in a monorepo have been abstracted out to a lib like this, such that both the lib and the app using it have cdk8s as a dependency, instanceof fails to correctly identify the class hierarcy as matching when objects are passed between the two. This is the same issue as experienced in constructs in https://github.com/aws/constructs/pull/955 As a result, instanceof returns false, and the function thinks there are no resources that need jsonifying.

Thanks for reporting this @dancmeyers. Looking into it 👍

For what it's worth, I managed to get this working by doing the following:

Create a package.json in the root cdk directory, that has as dependencies aws-cdk-lib, cdk8s, cdk8s-plus-21, and constructs. Run npm install to create the package-lock.json and node_modules directories.
Remove those libs from the dependencies of every Node app, be that a CDK lib in cdk/common or a CDK app in cdk/<something_else>, and set them as peerDependencies (with the expected >= instead of a specific version) instead.
Delete the node_modules and package-lock.json, then re-run npm install, in all of the cdk/common subdirectories, then do the same in each CDK app directory.

There is then only one copy of cdk8s etc in the package hierarchy, the one at the root cdk directory. Nothing else pulls in an alternative version (I had to remove a few other dev-only dependencies like cdk8s-cli to make that work), so everything plays nice and I don't get empty manifests. It is a bit of a faff though, and it would be great if it could Just Work (tm) in the same way that constructs does as long as the same version is installed in the imported lib and the main app.

This is also an issue with the instanceof call in app.ts on line 106. https://github.com/cdk8s-team/cdk8s-core/blob/2.x/src/app.ts#L106

That's useful to know, given that a load of our other systems are being moved to pnpm (so we can build them using Bazel), and I was going to try and migrate our CDK too so that we had consistency...


save wip

Description
A description of the PR, should include a decent explanation as to why this change was needed and a decent explanation as to what this change does
Review Instructions
Describe if this ticket needs review and if so, how one may go about it in qa and/or staging environments.
For example, a ticket based on Security Hub, Snyk, or Dependabot may not need review since those services
will generate new warnings if the issue has not been resolved properly. On the other hand, an infrastructure
ticket that results in visible changes to the end-user will definitely require review.
Many tickets will likely be between these two extremes, so some judgement may be required.
Issue
A link to a github issue or SEAB- ticket (using that as a prefix)
Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!

[ ] Check that your code compiles by running npm run build
[ ] Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
[ ] If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
[ ] Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
[ ] If displaying markdown, use the markdown-wrapper component, which does extra sanitization
[ ] Do not use cookies, although this may change in the future
[ ] Run npm audit and ensure you are not introducing new vulnerabilities
[ ] Do due diligence on new 3rd party libraries, checking for CVEs
[ ] Don't allow user-uploaded images to be served from the Dockstore domain
[ ] If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.
[ ] Check whether this PR disables tests. If it legitimately needs to disable a test, create a new ticket to re-enable it in a specific milestone.

WIP, unreliable since I probably have the Observable and subscribe wrong, but gets the general idea across

FYI @mvdbeek before cleaning up (changing the example name from foo.zip and looking at accessibility) are there any other planemo commands that you would like us to highlight on the Galaxy launch-with page?

This is a great start, thank you! There's potentially planemo test workflow.ga that could be mentioned for running any included tests, but I guess that wouldn't really fit into Launch tab.


How to get the angular frequencies of .wav file?

I am trying to get the angular frequencies of .wav file but I think I am doing it wrong. May I know how to fix it?
import numpy as np
from scipy import signal
from scipy.io.wavfile import read
** load the audio signal
sampling_rate, data = read('audio.wav')
print(f'sample rate is ', sampling_rate)
** get length of the audio signal
length = data.shape[0] / sampling_rate
time = np.linspace(0, length, data.shape[0])
** I am having an issue here. May I know what I have done wrong here
freq = np.linspace(time, 5, data.shape[0])
print(f'time shape {time.shape} , data shape {data[:,0].shape}, freq shape {freq.shape}')

Hi @IshkMagar, thanks for stopping by. What is your issue? Can you follow the template and provide a minimal working example reproducing the bug?
Please note that if there is no bug, we don't have the bandwidth to answer user questions and I would ask you to either use the mailing list or other forums like StackOverflow.

@tupui, This is the error I am getting
MemoryError
Traceback (most recent call last)
~\AppData\Local\Temp/ipykernel_18124/1475926947.py in
1 # I am having an issue here. May I know what I have done wrong here
----> 2 freq = np.linspace(time, 5, data.shape[0])
3
4 print(f'time shape {time.shape} , data shape {data[:,0].shape}, freq shape {freq.shape}')
<array_function internals> in linspace(*args, **kwargs)
~\AppData\Local\Programs\Python\Python39\lib\site-packages\numpy\core\function_base.py in linspace(start, stop, num, endpoint, retstep, dtype, axis)
151                 y *= step
152             else:
--> 153                 y = y * step
154     else:
155         # sequences with 0 items or 1 item with endpoint=True (i.e. div <= 0)
MemoryError: Unable to allocate 877. GiB for an array with shape (343067, 343067) and data type float64

I think the error is pretty self explanatory. You are trying to allocate a huge array and you don't have this much RAM. Check the arguments when you are creating the array:
np.linspace(time, 5, data.shape[0])

With that being said, it seems there is no issue related to SciPy, hence I will close it for now. Still, if you can show there is indeed a bug, I would gladly reopen 😃. Thanks again for the report.

fft_spectrum = np.fft.rfft(data[:,0])
freq = np.fft.rfftfreq(data[:,0].size, 1/sampling_rate)
pgram = signal.lombscargle(time, data[:,0], freq, normalize=True)
I am getting error here. I don't know it is bug or not.
ZeroDivisionError                         Traceback (most recent call last)
~\AppData\Local\Temp/ipykernel_4696/1439696588.py in
12 print(data[:,0])
13 print(freqs)
---> 14 pgram = signal.lombscargle(time, data[:,0], freq, normalize=True)
15 #plt.plot(freq, pgram)
~\AppData\Local\Programs\Python\Python39\lib\site-packages\scipy\signal\spectral.py in lombscargle(x, y, freqs, precenter, normalize)
148         pgram = _lombscargle(x, y - y.mean(), freqs)
149     else:
--> 150         pgram = _lombscargle(x, y, freqs)
151
152     if normalize:
ZeroDivisionError: ()


Can't iterate through chars in a string

Recent versions of Flow are printing type errors when iterating through a string: https://flow.org/try/#1N4Igxg9gdgZglgcxALlAIwIZoKYBsD6uEEAztvhgE6UYCe+JADpdhgCYowa5kA0I2KAFcAtiRQAXSkOz9sADwxgJ+NPTbYuQ3BMnTZA+Y2yU4IwRO4A6SFBIrGVDGM7c+IFkolXpUCWewUEAwhCQgRDH8wEH4hMnwROHlsNnw4KHwwSLAAC3wANyo4LFxscWQuHgMNZmwsiRSAWglaY1cq-hIAa2wJXNpG4Vxcdvdu3v7B0RxKUYMhKDBSqmbWwIq3eagoOrKSKgH0wtMMPznY7d2SfcoBiEZ-aG5G3Ix085AF-ZhsRoRehqUEiNMgSQHlSruBZxJrMcJwMhzAC+-EgGiCtnsAAJ7JQsQBeLEAHRAOTwRBJAG4iVAaTAIHiABSYiRY154iAwHFSACUWOANKxQrZ0BIEFKViICEZuJ51KgSJpdIZWOZotZ7IAkmx5Fj0tzKHyBVBhSK7OLsJKINLcQBtLU6gC6cppSJiIHyJhIcGgQXyAAYrAAmIOBgCMICRQA
I could iterate using a classic indexed for loop, but I'm a little confused about why Flow doesn't let you use for-of or for-in with a string. My understanding is that this is kosher in JavaScript, but I may be wrong.

It looks like for-of was working before Flow v0.200

This is intentional to avoid footguns like new Set(someStr). If you want to do this anyways, you can use for (const s of new String(someStr)) {...}

Fair enough, thanks for the quick response!

Yes, this change was made to make it so primitive values were no longer subtypes of interface {} (see new  https://flow.org/en/docs/lang/type-hierarchy/). This caused more issues than it was worth.


Error in order report form

There is an error going on in the radix console:

There was no check for allowing only 'POST' requests for the forms, which further allowed parsing the JSON body which is null.

Not sure why it was doing GET requests, but looks good to me 👍

I see some unnecessary code duplication. What about extracting the validation block into a "validateFormRequest.ts" file / method ?

This is in prod already but waiting for code optimisation to close it

Done

Looks good! :)

Closing this went live with https://github.com/equinor/energyvision/discussions/1227


ActiveRel doesn't have before/after_destroy callbacks

Hello. I tried to use after_destroy method when delete relationship. But this method not fire. How i can use after_destroy callback on relationship. Thank you.
#ActiveRel model
class SomeRelation
  include Neo4j::ActiveRel

  from_class :FromModel
  to_class :ToModel
  type 'some_relation'

  after_create ->(obj) { log }
  after_update ->(obj) { log }
  after_destroy ->(obj) { log }
end

#Using in controller
@fromModel.someRelation.delete(@toModel)

Sorry for not responding sooner!
I'd suggest not using delete but rather destroy like active_rel_object.destroy.  If you call delete on an association you're basically creating a query which will execute a Cypher query with a DELETE clause which will bypass the models
Closing because I think everything is OK, but please let me know if there's still a problem


High CPU usage

I noticed that while thundersvm is running, it usually keeps a cpu core at 100%. Why is this?
Is there any busy waiting for the GPU? Calculations that cannot be done directly in the GPU? Data transfer?
Thanks!

ThunderSVM (GPU) also needs the CPU for training data parsing and GPU task scheduling, so the scenario you have seen is normal.


Restarting the findneighbour4 server is slow when large numbers of samples are present

Restarting the findneighbour4 server is slow when large numbers of samples are present.
This is due to repopulation of the catwalk component from the database.
We need to identify ways to reduce this.

Options:

add an option not to stop catwalk to the fn4_shutdown script.  This is the easiest and best option if catwalk does not need to be shutdown (if for example there is not update to catwalk needed)
rapidly load catwalk over http from some kind of sequence backup file, allowing faster access than using a distant database.  Timings need to be worked on.  Experiments done by @dvolk suggest that there's little different in loading samples one at a time vs. en masse over a rest API; an experimental endpoint to allow bulk loading wasn't implemented because it didn't improve load speeds.
generate fasta files suitable for catwalk bulk loading.  Note, such files have to be on the machine running catwalk.  In benchmarks with covid data, loading one sample took about 0.007 seconds.  Therefore, reloading catwalk with 1m samples would take about 2h
use catwalk's own mechanisms to store data and restart.  At present, such data is stored in the same directory as the catwalk client (not desirable) and there is a risk of mis-synchronisation with the contents of fn4 with this option.

Other options:
build a periodic dump into catwalk cf. https://nim-lang.org/docs/marshal.html but this will block the server and is probably undesirable.
These options are not mutually exclusive.
Of these options:
1 should be implemented
4 should probably not be implemented because of the risk of loading data not in the fn4 database silently
EIther 2 or 3 would be satisfactory, but will still leave a multi-hour load time
It would be possible to make the fn4 server restart rapidly for READING data (which doesn't need catwalk) and later for inserting data.  However, this would need careful implementation.

Option 1 implemented.
fn4_shutdown.sh now has a new optional argument --leave_catwalk_running
If invoked with this option, fn4_shutdown.sh will not shutdown catwalk.
When the server is subsequently restarted by fn4_startup.sh, no new catwalk instance will be started, and the existing one used.

Underlying problem remains, which is slow loading of information from database for very large numbers of samples

After merge of PR #124, restarting takes 30 mins per million samples.
This could probably be accelerated if multifasta files were generates (which catwalk reads very fast) as opposed to loading reference compressed sequence data.  However, we will consider this closed for now.


url path for custom lexer

Hi there 👍🏻
I find dpaste interesting, cause it provides an API to upload stuff from the command line.
I am puzzled, why you would default to the Python lexer, as I think this prevents adoption.
(I know it is defaulting to whatever you used last, and this is not really going to help. I work with a lot of newbies, and for them its a an extra step, that may confuse them.)
May I suggest to have something like dpaste.org/plain to differentiate via a link?

Hello there 👋,

I am puzzled, why you would default to the Python lexer, as I think this prevents adoption.

Because it has been that way since 2009- on a serious note dpaste is used primarily by python/django dev's hence the default being Python.
https://paste.mozilla.org/ for example, 2nd largest public installation uses JavaScript as the default

May I suggest to have something like dpaste.org/plain to differentiate via a link?

Actually might be better if there is text.dpaste.org defaulting to Plain Text, it will use the same database as the primary dpaste.org instance. (That way text.dpaste.org/abcd will show the exact same content as dpaste.org/abcd)
Let me know what you think 🙂

Yeah, I actually suggested this at first, and then edited it cause I thought its a stupid idea for some reason 😄

👍🏼 https://text.dpaste.org

Thanks a lot
Did you think, how this is optimally exposed to the user?
Maybe on the homepage directly?

And I just noticed, the drop down menu on that subdomain has none of the other syntaxhighlighter now.
The coding highlighters are all gone.

Now its broken completely.

Sorry, the configuration was gone; https://status.darrennathanael.com/incidents/n79sdqq5pp2n
I'll re-configure it today

And I just noticed, the drop down menu on that subdomain has none of the other syntaxhighlighter now.
The coding highlighters are all gone.

I've fix this issue as well, https://text.dpaste.org/

Thanks a ton, solved.

Sorry, it doesnt work with the API:
curl -F 'format=url' -F 'content=<-' https://text.dpaste.org/api/

Invalid lexer choice "Plain Code" given. Valid lexer values are: _text, _markdown, _rst, _code, applescript, arduino, bash, bat, c, clojure, cmake, coffee-script,common-lisp, console, cpp, cpp-objdump, csharp, css, cuda, d, dart, delphi, diff, django, docker, elixir, erlang, go, handlebars, haskell, html, html+django, ini, ipythonconsole, irc, java, js, json, jsx, kotlin, less, lua, make, matlab, nginx, numpy, objective-c, perl, php, postgresql, python, rb, rst, rust, sass, scss, sol, sql, swift, tex, typoscript, vim, xml, xslt, yaml⏎

resolved.

Do you know, why this aligns on the left now?
Should I open a new issue?
https://dpaste.org/JP32d

Better open a new issue :-)


Vault initialized using ACMESharp before IsAcmeSharpModuleInstalled method runs

In MainForm.MainForm_Shown VaultManager is instantiated before the PowershellManager.IsAcmeSharpModuleInstalled runs. The VaultManager constructor initializes the vault with a call to the ACMESharp script Initialize-ACMEVault. This will cause an issue if ACMESharp isn't installed. IsAcmeSharpModuleInstalled should be called before the vault is initialized. The problem with that is that PowershellManager is a member of VaultManager. You could call IsAcmeSharpModuleInstalled in the VaultManager constructor but you wouldn't be able to pop up a message box explaining that ACMESharp is missing.

Currently undecided if we should just bundle our own ACMESharp distro.

Might not be a bad idea. That way you'd be able to guarantee the right ACMESharp version is installed. I guess one downside is having to manage how you bundle the distro.

I haven't investigated it yet but also I don't know what conflict handling we'd need to account for if we have our version of the module and the user also has the ACMESharp module installed. There is a clear argument for using ACMESharp directly rather than the Powershell commands but that does mean re-implementing a lot of stuff that's in the ps command-level code (or a lot of re-org for ACMESharp)

ACMESharp module loading step removed, we now load our own bundle of ACMESharp instead of the PowershellGallery version.


[1.5.0] #59 java.lang.IllegalStateException: The current thread must have a looper!

Environment
App Version: 1.5.9
Device: MI PAD 2
Android Version: 5.1
Description
#59 java.lang.IllegalStateException: The current thread must have a looper!
java.lang.IllegalStateException: The current thread must have a looper!
at com.x1unix.avi.MovieDetailsActivity.setProgressVisibility (MovieDetailsActivity.java:195)
at com.x1unix.avi.MovieDetailsActivity.applyMovieData (MovieDetailsActivity.java:260)
at com.x1unix.avi.MovieDetailsActivity.access$300 (MovieDetailsActivity.java:32)
at com.x1unix.avi.MovieDetailsActivity$1.run (MovieDetailsActivity.java:82)
at java.lang.Thread.run (Thread.java:818)

Possible solution:
new Handler(Looper.getMainLooper()).post(new Runnable() {
    @Override
    public void run() {
        primaryProgressBar.setVisibility(View.GONE);
    }
});

Source

Possibly fixed at https://github.com/odin3/Avi/commit/3dc0d63cd29519dd25b37455bd2b4a33a36c8928


glab: 1.23.0 -> 1.24.1

Updating glab version to v1.24.1 https://gitlab.com/gitlab-org/cli/-/releases/v1.24.1
Description of changes
Hi all - bumped the glab version up to v1.24.1. The release page is here with a changelog: https://gitlab.com/gitlab-org/cli/-/releases/v1.24.1/

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Don't have the permission to approve and run the tests, will review after tests

The "1 workflow awaiting approval" only appears when you target wrong branch before, it is a "no channel PR" action that will simply fail. It is fine to simply ignore it as long as you are targeting the correct branch now.
Can you change the commit message to glab: 1.23.0 -> 1.24.1? Also ofborg says there is hash mismatch, how did you get those hashes?
trying https://gitlab.com/api/v4/projects/gitlab-org%2Fcli/repository/archive.tar.gz?sha=v1.24.1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 15.7M    0 15.7M    0     0  11.2M      0 --:--:--  0:00:01 --:--:-- 11.2M
unpacking source archive /build/archive.tar.gz?sha=v1.24.1
error: hash mismatch in fixed-output derivation '/nix/store/wgmf1mfhj46mf5r1clyvn3f01d383jkd-source.drv':
         specified: sha256-3JQveAaqQXcUSDvVMjv83p7OrdftMxVPencDi0Fr3ZU=
            got:    sha256-CUchYPMBTINkMJg8TC8rKMVkrcj/Gy+ZxV7jbtMFvpg=

Thanks @bobby285271 ! It should be updated now 😄

Oh didn't know that trick and I didn't really watch the branch either


No License

Thanks for creating this great repo and the blog post to go with it!
Could you provide a license to clarify that you do want to allow people to use your code? The MIT License is a common one for people who intend for code to be freely available.

Thanks, @jdsandifer4 .  As you said I've added an MIT license.


Install codecov and simplecov & remove codeclimate

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@2620dee). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #18   +/-   ##
=========================================
  Coverage          ?   99.37%
=========================================
  Files             ?       11
  Lines             ?      319
  Branches          ?        0
=========================================
  Hits              ?      317
  Misses            ?        2
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2620dee...0c51993. Read the comment docs.


CASMPET-5977 - csm_rbd_tool and cubs_tool documentation

Description
Usage docs for csm_rbd_tool and cubs_tool.

Checklist Before Merging

[ ] If I added any command snippets, the steps they belong to follow the prompt conventions (see example).
[ ] If I added a new directory, I also updated .github/CODEOWNERS with the corresponding team in Cray-HPE.
[ ] My commits or Pull-Request Title contain my JIRA information, or I do not have a JIRA.

/backport main


[FM-6960] Removal of unsupported OS from postgresql

https://github.com/puppetlabs/ci-job-configs/pull/4560


Request for new algorithm mode support

Description

Type: Enhancement\Feature Request
Priority: Blocker

Enhancement\Feature Request
OS
OPTEE_OS
Enhancement\Feature Request
We are integrate mbedTLS into OPTEE_OS(secure OS), but there are some algorithms not supported by mbedTLS:
Do not support algorithm or mode:

DSA: include SHA1, SHA224 and SHA256 mode.
Cipher(AES) CTS and XTS mode
CBC_MAC: include AES_CBC_MAC_NOPAD, AES_CBC_MAC_PKCS5, DES_CBC_MAC_PKCS5, DES3_CBC_MAC_NOPAD and DES3_CBC_MAC_PKCS5 mode.

Need enhance:

CCM: Need more interface: starts, update, finish for integrate.

After discuss with linaro, they think the CBC_MAC,  Cipher(AES) CTS and XTS mode can be replaced by the third party crypto library. But there is no around way for DSA, so the DSA must be support in mbedTLS.
Thanks,
Edison

ARM Internal Ref: IOTSSL-2083

CBC-AES does not have good security characteristics[1] nor do many of the other modes supported. The watermarking issue with CBC-AES is especially problematic, allowing the modification of "secured" programs (e.g. firmware). CTR-AES has acceptable security, but different use cases. Please consider devoting time to supporting XTS-AES specifically:

According to SP 800-38E, "In the absence of authentication or access control, XTS-AES provides more protection than the other approved confidentiality-only modes against unauthorized manipulation of the encrypted data."[2]

XTS-AES PR has been raised in https://github.com/ARMmbed/mbedtls/pull/1602

AES-CBC-MAC is essentially supported, because It's AES_CBC, and the last AES block( 16 bytes) is the MAC

What I mean is, you can write in your code a wrapper, that will call our AES CBC encryption with the cipher API, and you copy the last block of the ciphertext to your MAC

Revisiting this in 2023:

DSA: include SHA1, SHA224 and SHA256 mode.

In 2023, I think I can confidently state that Mbed TLS will never implement DSA.

Cipher(AES) CTS and XTS mode

XTS is implemented. CTS isn't, please raise a new issue for CTS if it's still relevant.

CBC_MAC: include AES_CBC_MAC_NOPAD, AES_CBC_MAC_PKCS5,
DES_CBC_MAC_PKCS5, DES3_CBC_MAC_NOPAD and DES3_CBC_MAC_PKCS5 mode.

We do not implement CBC-MAC and do not intend to implement it. It's a strange mode that has a major gotcha: it's only secure if all inputs for a given key have the same size. We prefer to avoid implementing cryptographic primitives with a high risk of misuse. If you really need it, you can build it on top of AES-CBC.

CCM: Need more interface: starts, update, finish for integrate.

This is available since Mbed TLS 3.1.

Everything that was requested here is either available, or not something we intend to add, apart from CTS. If you still want CTS, please open another issue. For the rest, I am closing this issue as partly completed and partly unplanned.


Split out testing of dockstore-client, switch to jacoco

splits out integration tests in dockstore-client to be built under its own variable (skipClientITs)
should probably rename skipITs later
switching out cobertura for jacoco because cobertura seems to be dead
big coverage shift appears to be due to cobertura giving up on some of our classes like WorkflowResource (possibly Java 8 related)
new reports module based on https://github.com/jacoco/jacoco/wiki/MavenMultiModule

Coverage decreased (-2.7%) to 63.366% when pulling b3201af4f9bb5403907cb93fba57917e058a374b on feature/split_build_test into 6bf8ff28dd24c06636a2549615e466a17d8bd3e3 on develop.

@agduncan94  Will do, I'll probably have one more go at this to simplify things before updating the primer.


Better error handling in dataset_module_factory

cc @cakiki who reported it on slack (private link)
This PR updates how errors are handled in dataset_module_factory when the  dataset_info cannot be accessed:

Use multiple except ... as e instead of using isinstance(e, ...)
Always raise DatasetNotFoundError with from e so that the initial error is explicitly logged in the stacktrace.
Differentiate RepoNotFoundError / GatedRepoError / RevisionNotFoundError cases

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Test should be fixed by https://github.com/huggingface/datasets/pull/6959/commits/ef8f7cee79ffb070d9b5190f21128fc523b3d3ee (tested locally). Let's see what CI says :crossed_fingers:


Support more gnu API test auto generation.

Add all float related API support excepts fp16.
Add all API support excepts segment load, vget and vset.
Refactor the post_gen by extracting functions.

Signed-off-by: Pan Li<EMAIL_ADDRESS>

@eopXD Kindly remind for review (as well as #220), thanks in advance.

@eopXD Kindly remind for review (as well as https://github.com/riscv-non-isa/rvv-intrinsic-doc/pull/220).


Freeze layout of some internal standard library protocols

Freeze layout of some internal protocols to reduce memory use.
Resolves rdar://65642583

@swift-ci please benchmark

@swift-ci please benchmark

Performance (x86_64): -O

Regression
OLD
NEW
DELTA
RATIO

Dictionary4
155.2
203.0
+30.8%
0.76x (?)

Dictionary4OfObjects
190.222
229.625
+20.7%
0.83x

Data.init.Sequence.64kB.Count
2.0
2.269
+13.4%
0.88x (?)

ObjectiveCBridgeStubToNSStringRef
86.941
96.04
+10.5%
0.91x (?)

Improvement
OLD
NEW
DELTA
RATIO

FlattenListFlatMap
3542.0
2780.0
-21.5%
1.27x (?)

LuhnAlgoLazy
210.375
166.333
-20.9%
1.26x (?)

DropLastSequence
336.0
308.0
-8.3%
1.09x (?)

Diffing.Similar
379.25
348.333
-8.2%
1.09x (?)

DropLastSequenceLazy
335.667
308.333
-8.1%
1.09x (?)

Code size: -O
Performance (x86_64): -Osize

Regression
OLD
NEW
DELTA
RATIO

Data.init.Sequence.64kB.Count.RE.I
19.442
29.538
+51.9%
0.66x

Data.init.Sequence.64kB.Count.RE
19.542
29.545
+51.2%
0.66x (?)

Data.init.Sequence.64kB.Count
29.444
43.727
+48.5%
0.67x

Data.init.Sequence.64kB.Count.I
29.457
43.727
+48.4%
0.67x

Data.append.Sequence.64kB.Count.I
29.864
44.133
+47.8%
0.68x

Data.append.Sequence.64kB.Count
29.895
44.167
+47.7%
0.68x (?)

Data.append.Sequence.64kB.Count.RE
20.64
29.941
+45.1%
0.69x

Data.init.Sequence.2049B.Count.I
52.72
76.286
+44.7%
0.69x

Data.init.Sequence.2047B.Count.I
52.65
76.158
+44.6%
0.69x

Data.append.Sequence.64kB.Count.RE.I
20.756
29.949
+44.3%
0.69x

Data.init.Sequence.809B.Count.I
50.571
68.095
+34.7%
0.74x (?)

Data.init.Sequence.809B.Count
50.6
68.095
+34.6%
0.74x

Data.init.Sequence.513B.Count.I
61.818
77.933
+26.1%
0.79x (?)

Data.append.Sequence.809B.Count.I
63.864
80.412
+25.9%
0.79x (?)

Data.init.Sequence.809B.Count.RE.I
44.679
56.1
+25.6%
0.80x (?)

Data.append.Sequence.809B.Count
64.048
80.316
+25.4%
0.80x (?)

Data.init.Sequence.809B.Count.RE
44.909
56.286
+25.3%
0.80x (?)

DictionaryKeysContainsCocoa
14.345
17.902
+24.8%
0.80x (?)

Data.init.Sequence.511B.Count.I
62.0
77.15
+24.4%
0.80x (?)

DataAppendSequence
5785.0
6936.364
+19.9%
0.83x (?)

Data.append.Sequence.809B.Count.RE
57.7
68.667
+19.0%
0.84x (?)

Data.append.Sequence.809B.Count.RE.I
57.75
68.714
+19.0%
0.84x (?)

Improvement
OLD
NEW
DELTA
RATIO

Dictionary4
253.0
158.778
-37.2%
1.59x

FlattenListFlatMap
3721.0
2500.0
-32.8%
1.49x (?)

FlattenListLoop
1386.0
1020.5
-26.4%
1.36x (?)

Dictionary4OfObjects
238.857
199.444
-16.5%
1.20x (?)

Code size: -Osize
Performance (x86_64): -Onone

Improvement
OLD
NEW
DELTA
RATIO

CharacterLiteralsLarge
472.0
418.2
-11.4%
1.13x

Code size: -swiftlibs

How to read the data
The tables contain differences in performance which are larger than 8% and
differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac mini
  Model Identifier: Macmini8,1
  Processor Name: 6-Core Intel Core i7
  Processor Speed: 3.2 GHz
  Number of Processors: 1
  Total Number of Cores: 6
  L2 Cache (per Core): 256 KB
  L3 Cache: 12 MB
  Memory: 32 GB


feat: add char-based API

Hi Tatsunori,
It's been a while since I have worked on this. I prepared this code more than a year ago, but never got around to submitting it properly.
This API introduces newtypes around u8s for working with these code points.
Thanks for this crate! :)
Closes https://github.com/tats-u/rust-oem-cp/issues/10

@mkroening Do we have to improve build.rs?
I don't think we continue to expose the raw tables & hashmaps IMHO anymore. (#12)
You can hide them from users if you want to.

Our main dishes are (*DECODING_TABLE_CP_MAP).getand(*ENCODING_TABLE_CP_MAP).get`.
The use of an individual code page is jsut a bonus.

Our main dishes are (*DECODING_TABLE_CP_MAP).get and (*ENCODING_TABLE_CP_MAP).get.

Okay, we can make them private in favor of this API or what did you have in mind?

The StringExt should be activated only by those who want to use individual code pages.

What do you mean? A user can choose not to use StringExt. Or do you want to feature-gate it?


Build failing since sphinx-rtd-theme can't be found

I believe a recent PR introduced an error which is preventing the theme from being loaded.
https://readthedocs.org/projects/jupyterhub/builds/5713289/
I think that perhaps this line should be sphinx_rtd_theme.
cc/ @ericholscher

Thanks @ericholscher for the quick PR merge.
Confirming that all is building well again with conda https://readthedocs.org/projects/jupyterhub/builds/5713442/  👍 :tada: :cake:


Csri implementation

There are many codes copied from Csr files.
For starting rows, the parameter only comes from cuda executor.
It uses a parameter to set the number (nwarps).
cuda_config is available in cuda, so I need to set the warp_size in the core/matrix/csri.hpp.
Is there a better way to handle nwarps and warp_size?

I thought we had decided that CSRI is an implementation detail, only for the GPU kernel, not a new format?

Oh, I misunderstand it.

Maybe we should leave it for now? @gflegar what do you think?

I think it would be a nice improvement if we merged the CSR format with the CSRI format, and have the "classical" strategy (which does normal CSR), "CSR-I" and "MP-CSR". Then, we run the benchmarks, analyse the performance to see if we can determine when each of the strategies wins (we known from the CSR-I paper that this can be done at least for the classical CSR and CSR-I, just have to see if MP-CSR can be added to the analysis), and add an "automatic" strategy, which selects the best format depending on the properties of the matrix.

CMake issues in the build system, related to #86. We merged a fix in #118, but you'll have to update the branch to have the necessary changes.

CSR segfaults on the CI system: https://gitlab.com/ginkgo-project/ginkgo-public-ci/pipelines/29937229

@yhmtsai if I got it correctly, we are no longer interfacing to cuSPARSE for CSR SpMV. Instead we have 3 different kernels (classical, CSR-I, MP) and an additional strategy that chooses the best one.
However, in some cases cuSPARSE CSR might be faster, and we don't want to lose the ability to use it.
Could you add another strategy (say we call it "cusparse") that just calls the cuSPARSE SpMV?

@gflegar Sure, I recover the implementation in cusparse strategy.
It also can use advanced spmv.


Online/offline detection for ObservationUploader

With this change the ObservationUploader will put itself to sleep when the device is offline, and wake up when it's back online. Added a couple of tests as well.
Also updated the Jest config to make silent the default so that you don't see log lines (you can override by running yarn jest --silent=false).

This fixes #426


[Task]  add push module dao unit test

Description
Adding unit tests to the push module's dao layer code
Task List
No response

@yuluo-yx  Hi I can contribute

@yuluo-yx Hi I can contribute

assign, pls go ahead. 👍

@yuluo-yx  check PR plz

@yuluo-yx  pls check https://github.com/apache/hertzbeat/pull/2614


Bad formatting

The lack of spaces in https://github.com/svenvs/trywebworkers/blob/main/docs/prime/nonworker/index.html#L27 doesn't look good!

Lol I just see this now 🤣 indeed was just messing around


assetFileNames does not affect style

Describe the bug
This issue has fixed in<EMAIL_ADDRESS>but it reproduce in<EMAIL_ADDRESS>expect to output assets/index.css after building, but assets/style.css is created, the config is below:
{
    build: {
      cssCodeSplit: false,
      rollupOptions: {
        output: {
          manualChunks: undefined,
          assetFileNames: 'assets/[name][extname]',
          entryFileNames: 'assets/[name].js',
          format: 'iife'
        }
      }
    }
}

Reproduction
https://github.com/vitejs/vite/issues/4597
System Info
System:
    OS: macOS Mojave 10.14.6
    CPU: (8) x64 Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz
    Memory: 507.38 MB / 16.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 12.18.1 - ~/workspace/github/emsdk/node/12.18.1_64bit/bin/node
    Yarn: 1.22.10 - ~/.nvm/versions/node/v14.15.1/bin/yarn
    npm: 6.14.5 - ~/workspace/github/emsdk/node/12.18.1_64bit/bin/npm
  Browsers:
    Chrome: 104.0.5112.101
    Firefox: 95.0.2
    Safari: 14.1.2

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

related: #4863
related code:
https://github.com/vitejs/vite/blob/d04784b124e645b006e8064bb6bc589387fad977/packages/vite/src/node/plugins/css.ts#L649


Unable to build workerd on Ubuntu 22.04.1

Expected outcome
workerd should build fine using bazel.
Current outcome
When I try to compile workerd, it fails with the following error message:
jonas@jonas-asus:~/repos/clones/cloudflare/workerd$ bazel build -c opt //src/workerd/server:workerd
INFO: Analyzed target //src/workerd/server:workerd (0 packages loaded, 0 targets configured).
INFO: Found 1 target...
ERROR: /home/jonas/.cache/bazel/_bazel_jonas/c86f39fb6ae3f61b12a0ae374033648e/external/capnp-cpp/src/kj/BUILD.bazel:5:11: Compiling src/kj/source-location.c++ failed: undeclared inclusion(s) in rule '@capnp-cpp//src/kj:kj':
this rule is missing dependency declarations for the following files included by 'src/kj/source-location.c++':
  '/usr/lib/llvm-14/include/c++/v1/initializer_list'
  '/usr/lib/llvm-14/include/c++/v1/__config'
  '/usr/lib/llvm-14/include/c++/v1/__config_site'
  '/usr/lib/llvm-14/include/c++/v1/cstddef'
  '/usr/lib/llvm-14/include/c++/v1/version'
  '/usr/lib/llvm-14/include/c++/v1/__nullptr'
  '/usr/lib/llvm-14/include/c++/v1/stddef.h'
  '/usr/lib/llvm-14/include/c++/v1/cstring'
  '/usr/lib/llvm-14/include/c++/v1/string.h'
Target //src/workerd/server:workerd failed to build
INFO: Elapsed time: 1.298s, Critical Path: 0.52s
INFO: 18 processes: 17 internal, 1 linux-sandbox.
FAILED: Build did NOT complete successfully

Tries
I have tried the following:

Install clang-14 using apt
Install libc++-dev using apt
Install libc++abi-dev using apt

OS info
jonas@jonas-asus:~/repos/clones/cloudflare/workerd$ cat /etc/os-release
PRETTY_NAME="Ubuntu 22.04.1 LTS"
NAME="Ubuntu"
VERSION_ID="22.04"
VERSION="22.04.1 LTS (Jammy Jellyfish)"
VERSION_CODENAME=jammy
ID=ubuntu
ID_LIKE=debian
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
UBUNTU_CODENAME=jammy

This is some sort of bazel bug where it gets confused about built-in headers. Can you try adding this flag to bazel build:
--action_env=CXX=$(which clang++)
This tells Bazel the full path to clang, which seems to help it understand better where to expect built-in includes to live.

Hmm I'm also a little confused as the GitHub Action I defined in #8 uses Ubuntu 22.04 and the build managed to succeed there?

This is some sort of bazel bug where it gets confused about built-in headers. Can you try adding this flag to bazel build:
--action_env=CXX=$(which clang++)
This tells Bazel the full path to clang, which seems to help it understand better where to expect built-in includes to live.

Wasn't me that opened this issue but I was having the same (or similar) issue on Ubuntu 22.04 and this doesn't help:
erisa@Tuturu:~/workerd$ bazel build -c opt //src/workerd/server:workerd --action_env=CXX=$(which clang++)
Starting local Bazel server and connecting to it...
INFO: Analyzed target //src/workerd/server:workerd (199 packages loaded, 16161 targets configured).
INFO: Found 1 target...
ERROR: /home/erisa/.cache/bazel/_bazel_erisa/75b9d3e535bdb9de178afa4e37c61de2/external/capnp-cpp/src/kj/BUILD.bazel:5:11: Compiling src/kj/list.c++ failed: undeclared inclusion(s) in rule '@capnp-cpp//src/kj:kj':
this rule is missing dependency declarations for the following files included by 'src/kj/list.c++':
  '/usr/lib/llvm-14/include/c++/v1/initializer_list'
  '/usr/lib/llvm-14/include/c++/v1/stddef.h'
  '/usr/lib/llvm-14/include/c++/v1/__config'
  '/usr/lib/llvm-14/include/c++/v1/__config_site'
  '/usr/lib/llvm-14/include/c++/v1/__nullptr'
  '/usr/lib/llvm-14/include/c++/v1/cstring'
  '/usr/lib/llvm-14/include/c++/v1/string.h'
  '/usr/lib/llvm-14/include/c++/v1/cstddef'
  '/usr/lib/llvm-14/include/c++/v1/version'
ERROR: /home/erisa/.cache/bazel/_bazel_erisa/75b9d3e535bdb9de178afa4e37c61de2/external/capnp-cpp/src/kj/BUILD.bazel:5:11: Compiling src/kj/string-tree.c++ failed: undeclared inclusion(s) in rule '@capnp-cpp//src/kj:kj':
this rule is missing dependency declarations for the following files included by 'src/kj/string-tree.c++':
  '/usr/lib/llvm-14/include/c++/v1/initializer_list'
  '/usr/lib/llvm-14/include/c++/v1/__config'
  '/usr/lib/llvm-14/include/c++/v1/__config_site'
  '/usr/lib/llvm-14/include/c++/v1/cstddef'
  '/usr/lib/llvm-14/include/c++/v1/version'
  '/usr/lib/llvm-14/include/c++/v1/__nullptr'
  '/usr/lib/llvm-14/include/c++/v1/stddef.h'
  '/usr/lib/llvm-14/include/c++/v1/cstring'
  '/usr/lib/llvm-14/include/c++/v1/string.h'
Target //src/workerd/server:workerd failed to build
INFO: Elapsed time: 4.912s, Critical Path: 0.82s
INFO: 35 processes: 32 internal, 2 linux-sandbox, 1 local.
FAILED: Build did NOT complete successfully

Though clang++ is a binary that exists, and the files it's referring to in the error also appear to exist, which is the confusing part.
I also tried installing libc++abi-dev (Which wasn't installed) alongside the other deps (Which were installed) as noted in https://github.com/cloudflare/workerd/pull/8#discussion_r975867719, but that doesn't seem to have made a difference.
The C++ file(s) that it cites in the error seem to change across runs, likely just whichever ones it gets to first.

This is some sort of bazel bug where it gets confused about built-in headers. Can you try adding this flag to bazel build:
--action_env=CXX=$(which clang++)
This tells Bazel the full path to clang, which seems to help it understand better where to expect built-in includes to live.

I have just tried this, but to no avail. I have added the output below. Could this be an LLVM 14 version issue?
jonas@jonas-asus:~/repos/clones/cloudflare/workerd$ bazel build --action_env=CXX=$(which clang++) -c opt //src/workerd/server:workerd
INFO: Analyzed target //src/workerd/server:workerd (0 packages loaded, 0 targets configured).
INFO: Found 1 target...
ERROR: /home/jonas/.cache/bazel/_bazel_jonas/c86f39fb6ae3f61b12a0ae374033648e/external/capnp-cpp/src/kj/BUILD.bazel:5:11: Compiling src/kj/memory.c++ failed: undeclared inclusion(s) in rule '@capnp-cpp//src/kj:kj':
this rule is missing dependency declarations for the following files included by 'src/kj/memory.c++':
  '/usr/lib/llvm-14/include/c++/v1/initializer_list'
  '/usr/lib/llvm-14/include/c++/v1/stddef.h'
  '/usr/lib/llvm-14/include/c++/v1/__config'
  '/usr/lib/llvm-14/include/c++/v1/__config_site'
  '/usr/lib/llvm-14/include/c++/v1/__nullptr'
  '/usr/lib/llvm-14/include/c++/v1/cstring'
  '/usr/lib/llvm-14/include/c++/v1/string.h'
  '/usr/lib/llvm-14/include/c++/v1/cstddef'
  '/usr/lib/llvm-14/include/c++/v1/version'
Target //src/workerd/server:workerd failed to build
INFO: Elapsed time: 0.873s, Critical Path: 0.33s
INFO: 18 processes: 18 internal.
FAILED: Build did NOT complete successfully

Showing the versions of the libraries:
jonas@jonas-asus:~/repos/clones/cloudflare/workerd$ apt-cache show libllvm14
Package: libllvm14
Architecture: amd64
Version: 1:14.0.0-1ubuntu1
Multi-Arch: same
Priority: optional
Section: libs
Source: llvm-toolchain-14
Origin: Ubuntu
Maintainer: Ubuntu Developers<EMAIL_ADDRESS>Original-Maintainer: LLVM Packaging Team<EMAIL_ADDRESS>Bugs: https://bugs.launchpad.net/ubuntu/+filebug
Installed-Size: 106918
Depends: libc6 (>= 2.34), libedit2 (>= 2.11-20080614-0), libffi8 (>= 3.4), libgcc-s1 (>= 3.3), libstdc++6 (>= 12), libtinfo6 (>= 6), libxml2 (>= 2.7.4), zlib1g (>= 1:1.2.0)
Filename: pool/main/l/llvm-toolchain-14/libllvm14_14.0.0-1ubuntu1_amd64.deb
Size: 24009152
MD5sum: e4b3510371f248e57c1c6e44fcefcb36
SHA1: cc9fffefcc76c4af648a9634868926e8052388a4
SHA256: f22411c833909b3e4fdfd2f182974302d70c114a799499def6f005c7a2d07854
SHA512: 00b890240a896200e098dbb22d1329e7a54b0552729e0ed38afedfcfbc7f541925798f5891c8125abc393fcee038b01968884c80455d293e3010b2fce13b869e
Homepage: https://www.llvm.org/
Description-en: Modular compiler and toolchain technologies, runtime library
 LLVM is a collection of libraries and tools that make it easy to build
 compilers, optimizers, just-in-time code generators, and many other
 compiler-related programs.
 .
 This package contains the LLVM runtime library.
Description-md5: a8854f4edf76a8c14ce34dc209bd1d11
Task: postgresql-server

jonas@jonas-asus:~/repos/clones/cloudflare/workerd$ apt-cache show clang
Package: clang
Architecture: amd64
Version: 1:14.0-55~exp2
Priority: optional
Section: universe/devel
Source: llvm-defaults (0.55~exp2)
Origin: Ubuntu
Maintainer: Ubuntu Developers<EMAIL_ADDRESS>Original-Maintainer: LLVM Packaging Team<EMAIL_ADDRESS>Bugs: https://bugs.launchpad.net/ubuntu/+filebug
Installed-Size: 25
Depends: clang-14 (>= 14~)
Breaks: clang-3.2, clang-3.3, clang-3.4 (<< 1:3.4.2-7~exp1), clang-3.5 (<< 1:3.5~+rc1-3~exp1)
Replaces: clang (<< 3.2-1~exp2), clang-3.2, clang-3.3, clang-3.4 (<< 1:3.4.2-7~exp1), clang-3.5 (<< 1:3.5~+rc1-3~exp1)
Filename: pool/universe/l/llvm-defaults/clang_14.0-55~exp2_amd64.deb
Size: 3558
MD5sum: 9012efb7d550940265a49a8b3b986b1d
SHA1: a27e72f7f3e0d3ba8a84cf9e5612849ef11a46d9
SHA256: 4b4c7dee18823b5a1348d5496806810cb8fd40289377003adee6511c44339466
SHA512: 0d7b949d9bf5ebf7c3b3eb5eb5a542e1e88fc65106297ee34ebce055e950f71f06c3470e494fbf3b5c2128771b3c1cc33dead514bde19bb9aaf35b51162bcb13
Description-en: C, C++ and Objective-C compiler (LLVM based), clang binary
 Clang project is a C, C++, Objective C and Objective C++ front-end
 for the LLVM compiler. Its goal is to offer a replacement to the GNU Compiler
 Collection (GCC).
 .
 Clang implements all of the ISO C++ 1998, 11 and 14 standards and also
 provides most of the support of C++17.
 .
 This is a dependency package providing the default clang compiler.
Description-md5: 2916bca3b5e11836b745c64f4b346b34

jonas@jonas-asus:~/repos/clones/cloudflare/workerd$ apt-cache show libc++-dev
Package: libc++-dev
Architecture: amd64
Version: 1:14.0-55~exp2
Multi-Arch: same
Priority: extra
Section: universe/libdevel
Source: llvm-defaults (0.55~exp2)
Origin: Ubuntu
Maintainer: Ubuntu Developers<EMAIL_ADDRESS>Original-Maintainer: LLVM Packaging Team<EMAIL_ADDRESS>Bugs: https://bugs.launchpad.net/ubuntu/+filebug
Installed-Size: 16
Depends: libc++-14-dev (>= 14~)
Filename: pool/universe/l/llvm-defaults/libc++-dev_14.0-55~exp2_amd64.deb
Size: 3184
MD5sum: 9c88d7342fd54ae327505a12791fee2f
SHA1: caf79f60ec7fc5d0bff56c9bb25372a0eb07e90b
SHA256: 2de8b8c689056325b4691b6ead1aa112666edf71b65f0ded69f471bf2f7c2d34
SHA512: 48c310b9dd9009e8772c44944a2d23211094c9b87c051428d5cd318e236a9edf440b00b6904de05be556b12de683e726e2c96905ff7744a681e677339f180784
Description-en: LLVM C++ Standard library (development files)
 libc++ is another implementation of the C++ standard library
 .
 Features and Goals
 .
   * Correctness as defined by the C++ standards.
   * Fast execution.
   * Minimal memory use.
   * Fast compile times.
   * ABI compatibility with gcc's libstdc++ for some low-level features such
     as exception objects, rtti and memory allocation.
   * Extensive unit tests.
 This is a dependency package providing the default LLVM C++ Standard library
 development files.
Description-md5: d6ddd828f191a901b236b63f6c33ebd7

jonas@jonas-asus:~/repos/clones/cloudflare/workerd$ apt-cache show libc++abi-dev
Package: libc++abi-dev
Architecture: amd64
Version: 1:14.0-55~exp2
Multi-Arch: same
Priority: extra
Section: universe/libdevel
Source: llvm-defaults (0.55~exp2)
Origin: Ubuntu
Maintainer: Ubuntu Developers<EMAIL_ADDRESS>Original-Maintainer: LLVM Packaging Team<EMAIL_ADDRESS>Bugs: https://bugs.launchpad.net/ubuntu/+filebug
Installed-Size: 19
Depends: libc++abi-14-dev (>= 14~)
Filename: pool/universe/l/llvm-defaults/libc++abi-dev_14.0-55~exp2_amd64.deb
Size: 3320
MD5sum: 311dc971342d2015e555428b4887d125
SHA1: d47b21f3dbc8c4064919209b2810412d3297dc62
SHA256: 8a327d997c55ac16b8ae44a33de26319f7f8810bf1cc2dae28b6304e61865506
SHA512: e9409c516d4f2c7533e49f141d0fe8119cbbeb2a32b32b9d7cc714aaf5319f052faf7ca39581d0637d2dd044a1e4d3ccee5c14c3208f27f74fd59bbff1633e22
Description-en: LLVM low level support for a standard C++ library (development files)
 libc++abi is another implementation of low level support for a standard C++
 library.
 .
 Features and Goals
 .
   * Correctness as defined by the C++ standards.
   * Provide a portable sublayer to ease the porting of libc++
 This is the development package providing low level support to
 LLVM C++ Standard library.
Description-md5: 170a0b79ec2e8808672bcd34549e6625

I recall running into similar things, IIRC the answer in https://stackoverflow.com/questions/53527134/bazel-missing-dependency-declarations-for-stddef-h-and-others-ubuntu-18-04 helped, i.e. try running bazel clean --expunge and see if bazel build -c opt //src/workerd/server:workerd then works.

I recall running into similar things, IIRC the answer in https://stackoverflow.com/questions/53527134/bazel-missing-dependency-declarations-for-stddef-h-and-others-ubuntu-18-04 helped, i.e. try running bazel clean --expunge and see if bazel build -c opt //src/workerd/server:workerd then works.

Thanks for this! Running the clean fixed it for me. It's now building.

OK, so what's the best way for us to help people avoid this going forward? Some README note or is there more we can do?

@kentonv I have created PR #59 which adds this little step to the documentation. It should resolve most of the cases of this specific issue.

This has been merged with PR #59. Thank all!


Added roman and alphanumeric list feature

Closes https://github.com/accordproject/template-playground/issues/10

Added roman and alphanumeric list feature
Author Checklist

[ ] Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
[ ] Vital features and changes captured in unit and/or integration tests
[ ] Commits messages follow AP format
[ ] Extend the documentation, if necessary
[ ] Merging to main from fork:branchname

I have only added the Roman list feature as of now. Any suggestion for an alphanumeric list @dselman

hey @sanketshevkar @DianaLease can you guys review this pr and give me a feedback ?

Can you please add a unit test / screenshot / screen-recording whichever you feel that can help us verify the changes you've made? Thanks.

Can you please add a unit test / screenshot / screen-recording whichever you feel that can help us verify the changes you've made? Thanks.

Have one confusion that in the issue @dselman mentioned the markdown should have roman and alphanumeric
list ... here what does markdown mean like there are multiple markdown packages I can see in the repo ... so which one should have that feature ?


A test for the FetchInvalidMethodException exception must be created

With the aim to provide wider coverage of the current test suite, the FetchTests class should be extended by creating a new FetchInvalidMethodShouldThrowException test case that ensures that an assertion of the type FetchInvalidMethodException is thrown when passing an invalid HTTP method to the GlobalFetch.Fetch function.

Solved in #6


Add Boiler Plate for the app

Fixes #17

Created Components and Containers for different sections of the app

Added Documentation for the app
└───src
├───App.js
├───index.js
├───assets
│   └───images
└───mlh-prep.png
├───components
│   ├───MainNavbar
│   ├───SecNavbar
├───containers
│   ├───Footer
│   ├───Header
│   ├───Hotels
│   ├───Main
│   ├───RandomQuote
│   └───WeatherAPI

quick quesiton before merging, was this the intended outcome of the pr?

quick quesiton before merging, was this the intended outcome of the pr?

This is intended as we wanted to create a Boiler plate for the app
__
  Summary: :question: I have a question

But now other fellows have also worked on this PR

This PR contains the fixes for issues:
Issue #17 completed by @nawed2611 @XooTB.
Issue #16 completed by @jyotsnad246 @Suven-p.
Issue #3 completed by @gopivaibhav @vanichitkara.
Issue #9 completed by @aakankshabhende @deepanshug4.
Issue #10 completed by @nawed2611 @kartikmehta8.
Issue #18 completed by @juhiechandra @hello-fri-end @XooTB.
[Issue #11] (https://github.com/MLH-Fellowship/prep-project-22.AUG.PREP.1/issues/11) to some extent. Worked upon by @JooZef315 @chaytanyasinha.


Segfault when compiling Go

Please use the following bug reporting template to help produce actionable and reproducible issues. Please try to ensure that the reproduction is minimal so that the team can go through more bugs!

A brief description

Compiling this program segfaults: https://play.golang.org/p/jpxpcTMV6-
Ref: https://github.com/golang/go/issues/18705

Expected results

It should list the errors preventing the program from compiling.

Actual results (with terminal output if applicable)

[signal SIGSEGV: segmentation violation code=0x80 addr=0x48 pc=0x657d6c]
                                                                                lgoroutine 1 [running]:
runtime.throw(0x8f3377, 0x5)
        /usr/local/go/src/runtime/panic.go:566 +0x95 fp=0xc42103a610 sp=0xc42103a5f0
runtime.sigpanic()
        /usr/local/go/src/runtime/sigpanic_unix.go:27 +0x288 fp=0xc42103a668 sp=0xc42103a610
cmd/compile/internal/gc.typecheckdef(0xc4209d55f0, 0x0)
        /usr/local/go/src/cmd/compile/internal/gc/typecheck.go:3712 +0x77c fp=0xc42103a7a8 sp=0xc42103a668
cmd/compile/internal/gc.typecheck1(0xc4209d55f0, 0x6, 0x4)
        /usr/local/go/src/cmd/compile/internal/gc/typecheck.go:266 +0xd3e0 fp=0xc42103b6b8 sp=0xc42103a7a8
cmd/compile/internal/gc.typecheck(0xc4209d55f0, 0x6, 0x0)
        /usr/local/go/src/cmd/compile/internal/gc/typecheck.go:188 +0x654 fp=0xc42103b7e0 sp=0xc42103b6b8
cmd/compile/internal/gc.typecheck1(0xc42065aab0, 0x4, 0x7f6cd27f8610)                                                                                %
        /usr/local/go/src/cmd/compile/internal/gc/typecheck.go:476 +0x7e45 fp=0xc42103c6f0 sp=0xc42103b7e0
cmd/compile/internal/gc.typecheck(0xc42065aab0, 0x4, 0x8)
/usr/local/go/src/cmd/compile/internal/gc/typecheck.go:188 +0x654 fp=0xc420fcc818 sp=0xc420fcc6f0
cmd/compile/internal/gc.structfield(0xc42064abd0, 0x1)
        /usr/local/go/src/cmd/compile/internal/gc/dcl.go:750 +0x2ca fp=0xc420fcc880 sp=0xc420fcc818
cmd/compile/internal/gc.tofunargs(0xc420628648, 0x1, 0x1, 0xc4200dc702, 0xc420fb78b0)
        /usr/local/go/src/cmd/compile/internal/gc/dcl.go:845 +0xc3 fp=0xc420fcc900 sp=0xc420fcc880
cmd/compile/internal/gc.functype0(0xc420fb7810, 0x0, 0xc420628648, 0x1, 0x1, 0xc420628650, 0x1, 0x1)
        /usr/local/go/src/cmd/compile/internal/gc/dcl.go:1039 +0x1a5 fp=0xc420fcc990 sp=0xc420fcc900
cmd/compile/internal/gc.functype(0x0, 0xc420628648, 0x1, 0x1, 0xc420628650, 0x1, 0x1, 0xc42064a900)
        /usr/local/go/src/cmd/compile/internal/gc/dcl.go:1024 +0x89 fp=0xc420fcc9e8 sp=0xc420fcc990
cmd/compile/internal/gc.typecheck1(0xc42064ad80, 0x4, 0xc420fa8c01)
        /usr/local/go/src/cmd/compile/internal/gc/typecheck.go:466 +0xc8c8 fp=0xc420fcd8f8 sp=0xc420fcc9e8
cmd/compile/internal/gc.typecheck(0xc42064ad80, 0x4, 0xc42064a900)
        /usr/local/go/src/cmd/compile/internal/gc/typecheck.go:188 +0x654 fp=0xc420fcda20 sp=0xc420fcd8f8
cmd/compile/internal/gc.typecheckdef(0xc42064aea0, 0x0)
        /usr/local/go/src/cmd/compile/internal/gc/typecheck.go:3669 +0x65e fp=0xc420fcdb60 sp=0xc420fcda20
cmd/compile/internal/gc.typecheck1(0xc42064aea0, 0x22, 0xc4207b2ac8)
        /usr/local/go/src/cmd/compile/internal/gc/typecheck.go:266 +0xd3e0 fp=0xc420fcea70 sp=0xc420fcdb60
cmd/compile/internal/gc.typecheck(0xc42064aea0, 0x22, 0x0)
        /usr/local/go/src/cmd/compile/internal/gc/typecheck.go:188 +0x654 fp=0xc420fceb98 sp=0xc420fcea70
cmd/compile/internal/gc.typecheckfunc(0xc42064ae10)
        /usr/local/go/src/cmd/compile/internal/gc/typecheck.go:3368 +0x40 fp=0xc420fcebd0 sp=0xc420fceb98
cmd/compile/internal/gc.typecheck1(0xc42064ae10, 0x1, 0xc42064a990)
        /usr/local/go/src/cmd/compile/internal/gc/typecheck.go:2076 +0x643e fp=0xc420fcfae0 sp=0xc420fcebd0
/usr/local/go/src/cmd/compile/internal/gc/typecheck.go:188 +0x654 fp=0xc420fcfc08 sp=0xc420fcfae0
cmd/compile/internal/gc.Main()
        /usr/local/go/src/cmd/compile/internal/gc/main.go:367 +0x15e8 fp=0xc420fcfe50 sp=0xc420fcfc08
cmd/compile/internal/amd64.Main()
        /usr/local/go/src/cmd/compile/internal/amd64/galign.go:93 +0x2fa fp=0xc420fcfe88 sp=0xc420fcfe50
main.main()
        /usr/local/go/src/cmd/compile/main.go:33 +0x2a3 fp=0xc420fcff18 sp=0xc420fcfe88
runtime.main()
        /usr/local/go/src/runtime/proc.go:183 +0x1f4 fp=0xc420fcff70 sp=0xc420fcff18
runtime.goexit()
        /usr/local/go/src/runtime/asm_amd64.s:2086 +0x1 fp=0xc420fcff78 sp=0xc420fcff70

Your Windows build number

15007

Steps / All commands required to reproduce the error from a brand new installation

Install golang 1.7.3, set your $GOPATH env variable to ~/go
mkdir -p ~/go/errdemo && cd ~/go/errdemo
Paste this content (https://play.golang.org/p/jpxpcTMV6-) into a main.go file
Run go install

Strace of the failing command

Since xclip doesn't work on Bash for Windows, I'm not able to copy/paste that here.

Required packages and commands to install

Golang 1.7.3
See our contributing instructions for assistance.

strace -f ... 2> golang.strace

Thanks for reporting the issue!  Looking through the strace the only thing of interest was go setting up a signal handler for SIGSEGV.  After running the handler it looks like it jumped to some error logging code so it may not be that interesting.  We'll try to repro this locally and see if there's anything interesting when comparing against native Linux.

I just tried this locally on a recent internal build and it seems to work.  However, the default version of go on Xenial seems to be a bit newer at 1.7.3.  Can you double check to see if you see the same thing on go 1.7.4 or if I missed a step:
root@test:~/go/errdemo# export GOPATH=~/go
root@test:~/go/errdemo# export GOBIN=~/go/bin
root@test:~/go/errdemo# go install
_/root/go/errdemo
./main.go:4: undefined: notDefined
root@test:~/go/errdemo# go version
go version go1.7.4 linux/amd64
root@test:~/go/errdemo#

Confirmed still happening for me on 1.7.4.

Great, thanks.  It looks like this might be resolved in recent internal builds since I couldn't hit it locally.  Can you please double check the steps above look right?

Yup, the steps look fine. Hopefully it's fixed! +1

Thanks, I'm going to mark this fix inbound and please let us know if this is not fixed in the next 1-2 insider builds.

Confirmed it's fixed in 15019. Thank you!

Great to hear thanks for the confirming!


Support cmake --install build

Binja api cmake has a built-in macro for this, so you can use that instead of providing your own.

Oh, nice. Didn't know we had that macro. Thanks!


Android/iOS leave notifications until channel is read

Summary
This PR improves Android push notifications by:

Opening the app does not clear the push notifications
If multiple notifications only the notification that was selected gets cleared when opening the app the rest remain in the notification center
If there is a notification for a channel in the notification center, using the app to switch to that channel removes the notification from the device
Notifications get cleared when the channel is read in desktop/browser

See #2292 for more details on iOS
Ticket Link
https://mattermost.atlassian.net/browse/MM-12542

Build Apps for PR label detected. Will generate the app if build succeeds (checks pass and no conflicts with base branch).

Android build App: https://releases.mattermost.com/mattermost-mobile-pr/PR-2321/PR-2321.apk
iOS build App: itms-services://?action=download-manifest&url=https://releases.mattermost.com/mattermost-mobile-pr/PR-2321/PR-2321.plist

@grundleborg  Is fine, I just needed the Android part of things ;)

To clarify expected behaviour based on your bullet points above ^
2: What if you have multiple notifications from a channel. Tapping one of them to go to the channel should clear all the push notifications from that channel, correct?
4: Does this mean it get's cleared by channel? So reading a channel on desktop clears only the push notifications from that channel, leaving the others?

@esethna
2: Yes
4: Yes

Build Apps for PR label detected. Will generate the app if build succeeds (checks pass and no conflicts with base branch).

Android build App: https://releases.mattermost.com/mattermost-mobile-pr/PR-2321/PR-2321.apk
iOS build App: itms-services://?action=download-manifest&url=https://releases.mattermost.com/mattermost-mobile-pr/PR-2321/PR-2321.plist

Tested 4 points above - all are working
Tested with multiple channel types
Tested Replying from notification
Also ensured that replying form notification with correctly remove notification badge from the channel
Tested  On Android 7 and Android 8

Build Apps for PR label detected. Will generate the app if build succeeds (checks pass and no conflicts with base branch).

Android build App: https://releases.mattermost.com/mattermost-mobile-pr/PR-2321/PR-2321.apk
iOS build App: itms-services://?action=download-manifest&url=https://releases.mattermost.com/mattermost-mobile-pr/PR-2321/PR-2321.plist

Retested Android as outlined above
Also tested iOS for the same behavior
@enahum  this looks good to me.

Awesome @DHaussermann thanks for te-testing, let’s wait for @hmhealey approval and we can merge ;)


Put closure behind a private classloader?

It seems that closure-compiler copies guava symbols which can lead to problems when newer versions of guava are required. Notably selenium suffers from this, see #3164.
The big hammer solution could be to put closure-compiler behind it's own class loader. However, I'm unsure whether we can do this without requiring an sbt plugin for the sbt plugin.

actually I already stumbled upo that.
and I think it's way better to use shading than private classloaders.
I used scala-js and a new version of closure (long ago) (we dropped it in favor of angular2 as of know, until we have a path forward for sjs).
Here is how it could work:
https://github.com/envisia/sbt-closure/blob/master/build.sbt#L51
Instead of doing everything in one build, this can be also made in a seperate project (which will make stuff easier, publishLocal, etc..)
The good thing is, is that you can use a namespace which would never ever lead to any problems. And you do not need to deal with any shady class loading problems.

Thanks for the suggestion. It might be an easier path forward, indeed.

This issue potentially breaks any plugin that relies on a new version of guava, like sbt-source-format. I worked around this by using a custom classloader: https://github.com/swoval/sbt-source-format/commit/8b285d22935e140dd18c777b5dda8e8c8394a6e8. While the workaround isn't that bad, it was quite a pain to figure it out since I don't know much about the sbt plugin ClassLoaders. I'm guessing that most other plugin authors would run into trouble debugging this as well.

I guess #3516 would solve this?


Adaptive Card as part of Dialog and Receive Response - WebEx Teams

I am trying to use Adaptive Cards in Dialog and use fallback text for the non-supported WebEx Teams clients so that users can respond in the text format as well.
something like this, if the client supports card user will see a proper card and will be able to hit the submit button which sends attachmentActions to the webhook with an object. My test card is simple it has one drop down with 3 options and one submit button.
If client doesn't support AdaptiveCards, the user can respond in text and we continue the dialog with a text response.
    daily_transport_card_dialog.ask({
        text: 'Are you taking Cab Today?',
        attachments: async (template, vars) => {
            return createCabCard(vars.emp_name)
        }
    }, async (response, convo, bot) => {
            if (typeof response === 'object'){
                myobj = JSON.stringify(response);
                await bot.say(`Got your response:${myobj}`);
            }
            else
            console.log(`Got response in text :${response}`);
        },  'wants_transport');

The problem is 2 fold.

when user hit submits on card in response to ask in dialog, it is not captured in the response object in sample code above like regular text.

It seems, continueDialog function in prompts.ts file has condition which is stopping it form processing any non-message events.
    public async continueDialog(dc: DialogContext): Promise<DialogTurnResult> {
        // Don't do anything for non-message activities
        if (dc.context.activity.type !== ActivityTypes.Message ) {
            return Dialog.EndOfTurn;
        }

When we send a card using ask in the dialog and user respond to the card first, bot doesn't fire controller.on('attachmentActions') event until that dialog is completed. if user responds in the card bot doesn't see the controller.on('attachmentActions').
User has to respond with text first and complete dialog and after that when user hits the submit button on card it is received on the bot in controller.on('attachmentActions').

if controller.on works, maybe somehow I can hanle response in controller.on and complete my convo from controller.on when user respond with card submit.
Any alternative or fix to this?

The mechanism to include the card submission in a dialog is to use a middleware to change the activity type from Event to Message as it is being processed.
However, there is not currently a way to access the additional payload present in this event inside the ask handler function.  This will change when #1801 is merged.


Fix Regex pattern for subroutines to account for interfaces (fix #26)

Codecov Report

Merging #30 (6a96f0f) into main (b228635) will increase coverage by 0.20%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   90.92%   91.13%   +0.20%
==========================================
  Files          85       76       -9
  Lines       14309    13379     -930
==========================================
- Hits        13011    12193     -818
+ Misses       1298     1186     -112

Flag
Coverage Δ

lint_rules
?

loki
91.13% <ø> (-0.04%)
:arrow_down:

transformations
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

loki/frontend/regex.py
95.93% <ø> (-0.60%)
:arrow_down:

loki/build/workqueue.py
66.19% <0.00%> (-0.47%)
:arrow_down:

loki/visitors/visitor.py
79.62% <0.00%> (-0.38%)
:arrow_down:

loki/lint/rules.py
96.61% <0.00%> (-0.32%)
:arrow_down:

loki/transform/fortran_max_transform.py
97.05% <0.00%> (-0.30%)
:arrow_down:

loki/frontend/ofp.py
97.23% <0.00%> (-0.09%)
:arrow_down:

loki/frontend/source.py
96.83% <0.00%> (-0.02%)
:arrow_down:

loki/visitors/find.py
99.03% <0.00%> (-0.01%)
:arrow_down:

loki/backend/fgen.py
96.84% <0.00%> (-0.01%)
:arrow_down:

... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Editing stream descriptions seems to jump you to the end of the description frequently

Try opening the stream settings UI as an administrator, and editing the stream description.  The content-editable area will highlight, you can type things at the end, but if you try typing things not at the end, the character appears but your cursor gets jumped to the end.
Also, the escape key no longer works in that widget; the cause may be the same.

@zulipbot claim


Add a way to return the result of a job back into the scope

I think that a good way that don't interfere with the asynchronous computation is using a Future, like the one implented in eventual.
(Because what I understand is to find a way to get the return value of the closure executed in the execute method)


Authentication token

In past applications that use a JavaScript front-end that requires authentication I have used an access token that is passed to every API endpoint that checks its valid before returning the data. Does this terminal plugin automatically pass the token when stored to every command in the RPC file (except for the login command?)

yes

@jcubic In the RPC demo if you type exit you leave the login prompt and just get the initial prompt.
If you were to create a login command (when the user types login or requests another command) could you then call the login again? As from what I am seeing it just says [AUTH] Access denied (no token). So is the plugin listening for a command called 'login' to prevent that error when no token exists?

Also noticed a bug, if you enter the password exit, it then exists the current login prompt and then asks for a login again but uses the asterisk when typing:

Fixed in last commit to devel.

What about this: https://github.com/jcubic/jquery.terminal/issues/216#issuecomment-164161838 is this correct that the plugin overrides the auth error if the command typed is login?

It just call login as normal auth method with token as first argument, I should probably remove login from command list.

@jcubic If you have login option set to true for an interpreter is that all commands typed just return [AUTH] Access denied (no token) (regardless whether they exist in the RPC or not) if you are not authenticated. Shouldn't the plugin pass the command to the server regardless and let the server decide if it requires authentication rather than the authentication being set client side?

If you're not authenticated you can't type commands and now when I removed exit from login and password you should never see [AUTH] Access denied (no token), it should only happen if you remove token from localStorage by hand.

@jcubic Ah okies so that prevents you from seeing it. I've noticed that you have put the fix in the devel branch but not the master. And the master (at the time of writing) is 12 commits ahead and 165 commits behind, meaning things have been added to both... are you planning on merging these?

I wanted to have fixed Android issue for 0.9 version, but I think I just merge and release the 0.9 version without that fix.

I've merge the branches.


fix: Exit 1 with empty string if no match

Resolve an issue where grep returned 0 (with a \n as the output), even when the regex doesn't match.
Fixes #900

@nfischer
The failure is on those other two test cases on line 39 and 48; seems to be returning both the original error, and the new one, even with that explicit return.
     38:   t.truthy(shell.error());
   39:   t.is(result.stderr, 'grep: no such file or directory: /asdfasdf');
   40:   t.is(result.code, 2);

  Difference:

  - `grep: no such file or directory: /asdfasdf␊
  - grep: `
  + `grep: no such file or directory: /asdfasdf```

@wyardley can you add "Fixes #900" to the PR description?

@nfischer Ok, how's that look. I added another test case for the specific case where there are two files, one which dne and the other of which doesn't match.

Codecov Report

Merging #901 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #901      +/-   ##
==========================================
+ Coverage   97.31%   97.31%   +<.01%
==========================================
  Files          34       34
  Lines        1266     1268       +2
==========================================
+ Hits         1232     1234       +2
  Misses         34       34

Impacted Files
Coverage Δ

src/grep.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bd22e7...5a73ff0. Read the comment docs.

@nfischer applied your suggestions and squashed

Hi. This fix is still not available on the latest release v0.8.4. What is its status? Was there an issue with its packaging? This fix is really needed, as the current grep implementation is broken - I would argue it's a fixing change rather than a breaking one, as anyone relying on exit code 1 to detect the absence of matches is currently broken. Thanks.

I think this landed after v0.8.3 went out. v0.8.4 was a small patch release for a specific bug, which is why this didn't make it in that release either.
I've updated the milestone field to clarify this is expected to be part of v0.9.0. I haven't had time to figure out what needs to make it in that release and what should be punted to the next release.

@nfischer Thanks for the quick reply. Any idea when v0.9.0 might be released? It's been over 2 years now since this fix, so I'll have to use another script in the mean time.


Another hot fix

Change Summary
[Briefly summarise the changes that you made. Just high-level stuff]

error on user register because emails not working as expected

Change Form
Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.

[ ] The pull request title has an issue number
[ ] The change works by "Smoke testing" or quick testing
[ ] The change has tests
[ ] The change has documentation

Other Information
[Is there anything in particular in the review that I should be aware of?]

i think i fixed it


Scroll element into view if it's currently not visible

In my app, I'd like to ensure that the focused input element is visible after a window resize (due to Android virtual keyboard being shown).
I can't use scrollToElement() since it places the target element in the top-left corner (or center) of the viewport.  I need a variant of this function that does the following:

If element is already visible, don't do anything
If element is above view port, place it at the top of the viewport
If element is below view port, place it at the bottom of the viewport
If element is to the left/right of view port, place at the left/right side of view port

Nice!
if(pos.left != this.x || pos.y != this.y)
should be
if(pos.left != this.x || pos.top != this.y)

This is great, and would be a very useful addition!


“cargo install trunk” failing due to rayon-core

PS D:\Documents\Rust\hello_www> cargo install trunk
    Updating crates.io index
  Installing trunk v0.16.0
   Compiling proc-macro2 v1.0.44
// Long list of compiling
   Compiling heck v0.4.0
   Compiling rayon-core v1.9.3
   Compiling rustls v0.20.6
// Rest of the compiling
   Compiling bzip2-sys v0.1.11+1.0.8
error: failed to run custom build command for `rayon-core v1.9.3`

Caused by:
  could not execute process `C:\Users\dev\AppData\Local\Temp\cargo-installHK7ErK\release\build\rayon-core-9f2d274496fcf687\build-script-build` (never executed)

Caused by:
  The process cannot access the file because it is being used by another process. (os error 32)
warning: build failed, waiting for other jobs to finish...
error: failed to compile `trunk v0.16.0`, intermediate artifacts can be found at `C:\Users\dev\AppData\Local\Temp\cargo-installHK7ErK`

I've tried multiple times; each time generates a different file path.
I've also reinstalled Rust and tried immediately after restarting the PC. Using Windows 11.
Anyone have any ideas of how to get this to work?
Thank you.

Anti-virus issue. Bitdefender Endpoint is deleting the file.


Add user to the list of Kubestronauts

@huats 👋
I guess this PR is what's needed to add myself to the Kubestronaut list or is there anything else i need to do here (or any other repo)?
Thanks!

Hello ! Sorry for the late reply but I am travelling to India for KubeCon India..
I am usually taking the info for each new Kubestronauts on a weekly basis (usually on Friday) and create one single PR to add them. So I will close this PR to stick with it. You should expect an email from me really really soon about that... (if not by tomorrow contact me !)

Hello ! Sorry for the late reply but I am travelling to India for KubeCon India..
I am usually taking the info for each new Kubestronauts on a weekly basis (usually on Friday) and create one single PR to add them. So I will close this PR to stick with it. You should expect an email from me really really soon about that... (if not by tomorrow contact me !)

Oh, nice! No problems, have a fantastic time at KubeCon India! 🥳 Safe travels and enjoy the event!


✨ expose metrics port in operator deployment

What this PR does / why we need it:
Exposes metrics port in operator deployment
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #490

/retest