Non-issue: Works great on non-retina screen

I just want to let you know that I've tested this on a Mid 2011 iMac and It looks great, you may want to remove the warning from your readme ;)

Oh fantastic news. Can you post a screenshot? Would be interested in seeing how the border is drawn and whether it is crisp or a fuzzy line.
There is one obvious bug that I just realised that I will add to the readme. There is is no disabled state or hidden state! Oops.

There you go

Sorry about this, as you are my only link to a non-retina screen I'm going to ask! Could you select just the control (without popover) and post a really big image so I can see how the border looks. I zoomed in on that image and it looks uneven which is not good.

Hmmm... doesn't seem to have rendered quite right actually, the bottom line seems thinner...

The problem was a fairly typical one: drawing in Cocoa works with infinitely thin lines. When you stroke a path, Cocoa draws to both sides of that infinitely thin line. So to actually fill an on-screen pixel, the stroke path needs to be offset by half-a-pixel. See the pull-request #5 for a solution. Feel free to edit it as you see fit.

@DarkDust correct!

Fixed in pull request 2419a6e546d2ecb4ae9126a5968b697413e10241


VTK Support

Synopsis: Add new VTK conversion methods to project elements.
Please consider this branch experimental in its current state. I want to get a pull request going to discuss whether these features are appropriate to have in the omf package.
The Visualization Toolkit (VTK) is a cross-platform, open-source library for data processing and visualization built on C++ and wrapped for use in Python. VTK provides a framework for scalable visualizations and powers many open source visualization software platforms like ParaView.  I believe that adding VTK support to omf will enable geoscientists to directly pair the Open Mining Format with their VTK powered processing or visualization routines/software and provide a set of functionality that will work out of the box.
I initially began writing these conversion methods for the PVGeo repository to build an OMF project file reader for ParaView. After working a bit with the OMF package and file format, I began to realize I needed a means to directly convert the project elements to VTK data objects to use in some of my other processing routines outside of ParaView. Rather than importing an external package to call various conversions methods for each element’s type, I thought it’d be best to allow each element to convert itself within omf directly. Thus providing stable conversion methods for each ProjectElement and a place to start for using omf in VTK processing routines without the need for static file conversions.
New Features:
For every subclass of the ProjectElement (or ProjectElementGeometry when appropriate), I have added a method called toVTK() which will convert the element to a VTK data object that corresponds to its features/topology. This allows for users to iterate over a Project’s elements list and directly convert that element to a VTK data object like the example below:
Example:
>>> import omf

>>> # Read the test file in the repo's assets
>>> reader = omf.OMFReader('test_file.omf')
>>> project = reader.get_project()

>>> # Iterate over the elements and add converted VTK object to dictionary:
>>> data = dict()
>>> for e in project.elements:
>>>     data[e.name] = e.toVTK()

Now we have a dictionary of VTK data objects to use in VTK processing/visualization routines:
>>> data
{u'Basement': (vtkCommonDataModelPython.vtkUnstructuredGrid)0x10726e598,
 u'Block Model': (vtkCommonDataModelPython.vtkRectilinearGrid)0x10726e738,
 u'Cover': (vtkCommonDataModelPython.vtkUnstructuredGrid)0x10726e3f8,
 u'Dacite': (vtkCommonDataModelPython.vtkUnstructuredGrid)0x10726e530,
 u'Early Diorite': (vtkCommonDataModelPython.vtkUnstructuredGrid)0x10726e600,
 u'Intermineral diorite': (vtkCommonDataModelPython.vtkUnstructuredGrid)0x10726e668,
 u'Topography': (vtkCommonDataModelPython.vtkUnstructuredGrid)0x10726e4c8,
 u'collar': (vtkCommonDataModelPython.vtkPolyData)0x10726e258,
 u'wolfpass_WP_assay': (vtkCommonDataModelPython.vtkPolyData)0x10726e6d0}

Directly convert/check a single element:
>>> el = project.elements[-1] # the `Block Model` element
>>> el.name
Block Model
>>> grid = el.toVTK()
>>> grid
(vtkCommonDataModelPython.vtkRectilinearGrid)0x10726e870
>>> assert(grid.GetNumberOfCells() == el.geometry.num_cells)
>>> assert(grid.GetNumberOfPoints() == el.geometry.num_nodes)

Concerns
I realize that a goal of omf is likely to remain a lightweight tool and provide a simple API so that users can integrate the Open Mining Format with their python powered processing software. In my experience, VTK can be cumbersome to install on non-Unix operating systems and thus it might make omf less lightweight out of the box. For this reason, I have kept all vtk imports internally within the toVTK() methods to ensure that the package can be used entirely without VTK in the active environment.
I imagine that omf was built with the idea that functionality to use the ProjectElements would be implemented in external libraries, but I am making a proposition that VTK is widely used enough that a standard means of generating VTK data objects should be included with the OMF package.
Progress:

[ ] Line Set

[x] Generate vtkPloyData with CELL data attributes
[ ] If subtype is a borehole: make cylinders instead of lines.

[ ] Point Set

[x] Generate vtkPloyData with POINT data attributes
[ ] Handle textures

[ ] Surface

[x] Generate vtkUnstructuredGrid for SurfaceGeometry
[ ] SurfaceGridGeometry:

[ ] vtkStructuredGrid if axis are not default XYZ cartesian
[ ] vtkRectilinearGrid if axis is aligned with Cartesian system

[x] Add POINT data attributes
[ ] Handle textures

[x] Volume

[x] VolumeGridGeometry

[x] vtkStructuredGrid if axis are not default XYZ cartesian
[x] vtkRectilinearGrid if axis is aligned with Cartesian system

[x] Add CELL data attributes

PVGeo
I also want to include here what this enables me to build in the PVGeo package. By providing these methods to generate VTK data objects for each element type, I have created a reader for ParaView that will directly read an OMF project file, allow a user to select the elements they want to load, then have these elements directly rendered by ParaView:
EXAMPLE SCENE
What this looks like within ParaView:

Hey @banesullivan - Thank you for the contribution! Really exciting to see some interest. I haven't reviewed the code yet since it's still a work in progress, but OMF/VTK interoperability seems quite useful.
My only concerns are somewhat parallel to yours. Keeping OMF lightweight is a goal, so I appreciate that you are including VTK as non-required functionality that only "turns on" if VTK is available. However, more than that, this sets a precedent for other external data types. Where do we draw the line for what's widely used enough to warrant inclusion? My preference would be to create a standard way to build libraries to interface with OMF. For example make a cookiecutter repo that simplifies filling in toOMF/fromOMF for a certain data type. Then you can pip install omf-vtk (for example) and have all the OMF interoperability you need for that external data type. I don't think it would be a problem to host these OMF plugin libraries on the GMSGDataExchange github and give them the same first-class treatment as the base OMF library.
Anyway - I'd be curious what opinions other people may have about including VTK here.
And regardless, I'm so happy to see a contribution! I'll do what I can to help get VTK/OMF interop out into the world.

Hi @fwkoch, thanks for checking this out!
I think you make an excellent point and I agree it would be a difficult line to draw for what external libraries should be in the base OMF package. So, I now think these VTK features will be best suited in their own interface package for which I would be happy to lead development and host here on GMSGDataExchange.
I do not have any experience with making cookiecutters but they seem like an excellent approach for building interfaces. Perhaps we could lay the groundwork for a cookiecutter in near future?
Once there's an OMF-VTK interface, building the PVGeo / ParaView project readers/writers will be a breeze so I'm excited to move this forward!


V1 UUID constructor

Closes #5

Very good suggestions @alejandrohdezma, I'll push a commit applying them :heart:


SS_List interface map method not implemented consistently

According to the PHP doc the function map on classes that implement the SS_List interface should return an array.
However, DataList returns an SS_Map and ArrayList returns an array.
This leads to inconsistencies in how ArrayLists and DataLists should be handled when turning them into a map.
Should we be returning an SS_Map or an array (as documented)

PHPDoc:
	/**
	 * Returns a map of a key field to a value field of all the items in the
	 * list.
	 *
	 * @param  string $keyfield
	 * @param  string $titlefield
	 * @return array
	 */
	public function map($keyfield = 'ID', $titlefield = 'Title');

IMHO, map() should return a SS_Map consistently. Map then has a toArray() but this would be a 4.0 / master change.

Yeah, I've noticed this as well, but it would be hard to change without breaking a lot of workarounds.

Possible patches that are posted due to this inconsistency:
#3778
#3767
I think there is a lot of "work around" code or unessacery code in the FormFields because of this inconsistency. Everyone is having to code very defensively. It needs to be made consistent, but whichever way we choose will cause a pain to someone, the important thing is we make a decision so it's consistent.
We probably should use SS_Map because we have it, but I'm not certain of it's advantage over an array in this circumstance.

@hafriedlander any thoughts?

duplicate of #1593


[Feature] Prevent losing everything with one click

Prevent losing everything with one click
I get frustrated when filling out a huge form and accidentally press a button and lose everything without warning.
Solution I would like
On the "Actions" menu, "Load Data" and "Reset" button should have a simple confirmation dialog.
Alternative solution
It may not be necessary to have a full dialog, just a second confirmation click would be enough.

Closing this issue as Reactive Resume has been bumped up to v2.


do not log sensitive information

currently, upon importing an account, the mnemonic phrase is logged to the console. This can easily leak secrets, i.e. when a dev pastes logs on public gists.
`` ```
[InAppWebViewController] (android) WebView ID<PHONE_NUMBER>5168228202184392248510317116620774 calling "EncointerJsService" using [{path: uid=14;account.recover, data: {pubKey: YYYYYYYYYYYYYYYYYYYYYYYYYYYYY, mnemonic: ******************************************, rawSeed: , encoded: ######################################################, encoding: {content: [pkcs8, sr25519], type: [scrypt, xsalsa20-poly1305], version: 3}, address: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX, meta: {}}}]
[log] [DEBUG] JSApi ==> : [JavaScripHandler/callback]: [{path: uid=14;account.recover, data: {pubKey: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX, mnemonic: *****************************************************, rawSeed: , encoded: ##########################################################, encoding: {content: [pkcs8, sr25519], type: [scrypt, xsalsa20-poly1305], version: 3}, address: XXXXXXXXXXXXXXXXXXXXXXXXXXXXX, meta: {}}}]

We should not log this

Hmm, this is actually not 100% straightforward, this would mean that we either:

Stop logging all messages we receive from JS
Try to catch logging messages from JS that contain sensitive information.

Additionally, we should double-check all dart logging if they unnecessarily log secrets

filtering might be the quickfix. and better than leaving it as is


RC test for molecule-shapes 1.2.0-rc.1

@ariel-phet, molecule-shapes/1.2.0-rc.1 is ready for RC testing. Document issues in https://github.com/phetsims/molecule-shapes/issues and link to this issue.
Assigning to @ariel-phet for prioritization.

General RC Test

What to Test

Click every single button.
Test all possible forms of input.

Test all mouse/trackpad inputs.
Test all touchscreen inputs.

If there is sound, make sure it works.
Make sure you can't lose anything.
Play with the sim normally.
Try to break the sim.
Test all query parameters on all platforms. (See QA Book for a list of query parameters.)
Download HTML on Chrome and iOS.
Make sure the iFrame version of the simulation is working as intended on all platforms.
Make sure the XHTML version of the simulation is working as intended on all platforms.
Complete the test matrix.
Don't forget to make sure the sim works with Legends of Learning.
Check this LoL spreadsheet and notify AR if it not there.
If this is rc.1 please do a memory test.

Focus and Special Instructions
[Provide further instructions here. If you have any further tests you want done or specific platforms you want tested, list them here. Any behaviors you want QA to pay special attention to should be listed here.]

Issues to Verify

[ ] Non-WebGL screenshot reversed

These issues should have the "status:fixed-pending-testing" label. Check these issues off and close them if they are fixed. Otherwise, post a comment in the issue saying that it wasn't fixed.

Link(s)

Simulation
iFrame
XHTML
Test Matrix
Legends of Learning Harness

FAQs for QA Members

There are multiple tests in this issue... Which test should I do first?
Test in order! Test the first thing first, the second thing second, and so on.

How should I format my issue?

We typically assign the developer who opened the issue in the QA repository.

My question isn't in here... What should I do?
You should:

Consult the QA Book.
Google it.
Ask Katie.
Ask a developer.
Google it again.
Cry.

Main issue for creating this release: https://github.com/phetsims/molecule-shapes/issues/150

@KatieWoe #277 and #278 should come first, but this sim we also want to republish before March, should be straightforward as just being republished off master.

moving to high priority in the queue

Memory Test Results
Start: 61.0
1: 73.3
2: 76.3
3: 77.3
4: 78.2
5: 78.9
6: 79.8
7: 80.4
8: 80.8
9: 81.1
10: 81.6

QA is done. Since the app came out and that was the stated date for dropping iOS 9 (and 10 I believe) those two platforms were only tested for performance.

This release branch had patches related to https://github.com/phetsims/chipper/issues/720 and https://github.com/phetsims/brand/issues/34 applied since the last RC. This sim should have another RC done, if only to test the brand-related changes briefly.

Thanks for testing, I should have rc.2 momentarily.


"USER is not a valid network type" in calico with mesos

hi,when i follow this link
https://github.com/projectcalico/calico-containers/blob/master/docs/mesos/UsageGuideDockerContainerizer.md
the marathon give me {"message":"Invalid JSON","details":[{"path":"/container/docker/network","errors":["USER is not a valid network type"]}]}
the marathon version is Name        : marathon
Version     : 1.1.2
Release     : 1.0.488.el7
Architecture: x86_64
Install Date: Tue 02 Aug 2016 03:04:27 PM CST
Group       : default
Size        : 74485386
License     : Apache-2.0
Signature   : RSA/SHA1, Fri 29 Jul 2016 09:55:06 PM CST, Key ID df7d54cbe56151bf
Source RPM  : marathon-1.1.2-1.0.488.el7.src.rpm
Build Date  : Fri 29 Jul 2016 09:53:40 PM CST
Build Host  : ip-172-27-31-77.ec2.internal
Relocations : /
Packager    : Mesosphere Package Builder<EMAIL_ADDRESS>Vendor      : Mesosphere, Inc.
URL         : https://github.com/mesosphere/marathon
Summary     : Cluster-wide init and control system for services running on Apache Mesos
Description :
Cluster-wide init and control system for services running on Apache Mesos

One for @djosborne?

Whoops! The instructions you followed are for Marathon v1.2.0+. That version of Marathon now supports the "USER" type for networks.
If you're on <1.2.0, you can still specify a network type. this older version of that doc shows how.
I'll update this issue to make sure we explain that in our master docs, as it is easy for users to hit this.

@evilabandon If this doesn't fix your original issue please reopen!


Fix wrong environment config key

For me env config only worked with environment key (config as json). I guess environmentVariables is the key for VS Code.

Hi, thanks. Reason is, I did not want to break backwards compatibility in VSCode. But I got confused with the different naming. Here is the correct Interface for .httpyac.js https://github.com/AnWeber/httpyac/blob/main/src/models/environmentConfig.ts#L27


Add govuk_env_sync doc

Context:

For the migration to AWS, a new data synchronisation and backup mechanism, govuk_env_sync, was introduced.
The new docs are added and linked from the doc of the former data sync mechanism.

Testing:

The altered pages render correctly in my local environment.

solo: @schmie

Will not re-request review as only squashed in last force-push.


Why not just set content transparent while hideModalContentWhileAnimating?

I saw that hideModalContentWhileAnimating hide content view after closing animation end by rendering an empty View.But that may effect the lifecycle of children.
Why not just set {opacity: 0} instead?

Mainly because if I recall correctly opacity: 0 was still rendering the component tree (if I recall correctly), so it wouldn't have solved the performance issues.
Don't know if now RN has changed that behaviour though...

Yes, setting the opacity to 0 doesn't unmount the component.

Mainly because if I recall correctly opacity: 0 was still rendering the component tree (if I recall correctly), so it wouldn't have solved the performance issues.
Don't know if now RN has changed that behaviour though...

That's right.
And as I know hideModalContentWhileAnimating is made for fixing the problem that using useNativeDriver might lead to some nasty flashes.
Workaround for the flashes when useNativeDriver={true} #116
In this case, I thought if using opacity: 0 brings fewer side effects and be more friendly to existing projects.

In this case, I thought if using opacity: 0 brings fewer side effects and be more friendly to existing projects.

You could try it by manually setting the content opacity to 0 when you set isVisible to false and back to 1 when you set isVisible to true... That said, I have no idea what kind of benefit you might have with that. Let me know!


Please update Cryptopp to 7.0.0

A new version with multiple important fixes are out more than a month. Please update vcpkg so we can get the latest.

This would (I would imagine) also have the beneficial side-effect of picking up a commit that modifies the cryptopp include directories from ${INSTALL_LOCATION}/include/cryptopp to ${INSTALL_LOCATION}/include/.
This would mean that includes of the form #include <cryptopp/sha3.h> would now work (whereas at the moment, an include of <sha3.h> is needed. Given that all of the sample code on the cryptopp website uses the <cryptopp/sha3.h> form, making this change would mean that using cryptocpp with vcpkg would now give an environment that matches the one used in the Cryptopp samples.

@cempayzin , the package has been updated to the version 8.0.0 on the master. Please take a look.
Thanks.


iterations vs random provider

I was able to start a compute using a RandomProvider with Max Iterations = 1. Hit index out of range exception.

The exception was actually a result of max iterations being greater than min iterations


SQLite change column

I am trying to modify an existing column in a SQLite database (e.g.  set the "Auto Increment" flag). The database contains no data. Anyway the "Auto Increment", "Not Null" options are all grayed out. In addition I am not able to define a new key.

Unfortunately, mentioned features are not supported by SQLite
https://www.sqlitetutorial.net/sqlite-alter-table/


cannot kekulize the scaffold after MurckoDecompose

Hi,
I try extracting the scaffold of a molecule (whose smiles string is 'Cc1c2cc(Br)ccc2nc-[n+]1=O'), but find that the output mol object unkekulized and hence cannot be drawn. Besides, applying AllChem.MolFromSmiles() to the output scaffold's smiles string also triggers an error about being unkekulized (but with different unkekulized atoms):

Btw, the output scaffold's smiles string is 'O=[n+]1[c-]nc2ccccc2c1', and can be visualized via https://pubchem.ncbi.nlm.nih.gov/ as shown below:

May I ask whether the error (i.e., being unkekulized) means that the output scaffold is chemically invalid? If not, how to visualize it via rdkit?
Thank you!

The issue template asks you a series of questions that make it easier for us to help.
The fact that you've either deleted those or only answered a subset of them makes it more difficult for us to help, so I'm closing this issue.
Please feel free to edit the issue description to include the requested informatio and reopen the issue and then we'll try to help.


Update PROD Environment: Data Migration (State Content)

Update PROD Environment: Data Migration (State Content)

Data Migration from Stage env


add detection and toggles for v1 cronjobs

Cronjobs did not GA till Kube 1.21. This adds detection for that version and if so applies the cronjobs to do the periodic refreshes. If not: they are skipped to allow full reconcilation of the other components.
It is the expectation if this is not available: the operator of the cluster must provide a replacement in the form of a out of band beta cronjob until the appropriate version can be reached.

/retest

Environment capabilities surface should be kept as small as possible. We want to enforce predictability and have as much control as possible over the supported combinations.
This is not an optional environment capability, this is a core Resource tied to a HCP(kube version). Each HCP version must enforce what version of the resources it wants.
Same thinking for https://github.com/openshift/hypershift/pull/647
/hold

sorry, I didn't realise is the management cluster dictating this here! let's stay with the minimum required for now.  If we ever need something fancier we could discover the available apigroup and manipulate with unstructures.
v1beta1 for both pdb and cronjobs seems to die by 1.25 which should be enough for the minimum required to be bumped
https://kubernetes.io/blog/2021/07/14/upcoming-changes-in-kubernetes-1-22/
closing in favour of https://github.com/openshift/hypershift/pull/657
/close


don't lock markdown version and bring CI deps install script in sync with setup.py

This markdown version lock could cause versioning conflict for downstream (e.g. if requirements are compiled and resolved by pip-compile). Wondering If there's a reason to lock this version
Seems someone pushed 1.2.0 to PYPI and it cause some dependency conflict.

Can one of the admins verify this patch?

I am inclined to reject the changes in install_pip_packages.sh file.
First, that file is for our continuous integration system, and end users should not be using/depending on it.
Second, in our CI I would like all our dependencies to be tightly controlled.
For example, your changes will cause numpy to be upgraded to 1.13, which causes a lot of test failures due to a bug in the new numpy version. Without a version lock on numpy version, our CI will start breaking and debugging such issues would be very difficult.
For the changes to setup.py, I think that is a tensorboard dependency.
Please send a pull request with this change to our brand new tensorboard repository for discussion.

OK. I don't think lock versions are a great thing to do especially it's not in sync with the actual setup.py which breaks the parity between CI and end user. @gunan

Thanks for your input, however we will favor reproducibility in our CI to help us with debugging. setup.py is designed to be more flexible to enable a wider variety of user environments, but our CI has to be reproducible so that we can clearly pinpoint any issues in our build history.


[type: refactor] refactor cache plugin

// Describe your PR here; eg. Fixes #issueNo

Make sure that:

[ ] You have read the contribution guidelines.
[ ] You submit test cases (unit or integration tests) that back your changes.
[ ] Your local test passed mvn clean install -Dmaven.javadoc.skip=true.

Codecov Report

Merging #3135 (a1b6055) into master (a4a3bdc) will decrease coverage by 0.24%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #3135      +/-   ##
============================================
- Coverage     58.63%   58.38%   -0.25%
+ Complexity     4478     4447      -31
============================================
  Files           706      706
  Lines         20217    20215       -2
  Branches       1855     1853       -2
============================================
- Hits          11854    11803      -51
- Misses         7318     7364      +46
- Partials       1045     1048       +3

Impacted Files
Coverage Δ

...shenyu/plugin/cache/base/handler/CacheHandler.java
54.16% <ø> (-4.17%)
:arrow_down:

...g/apache/shenyu/plugin/cache/redis/RedisCache.java
41.17% <ø> (ø)

...e/shenyu/plugin/cache/base/config/CacheConfig.java
50.00% <100.00%> (ø)

...che/shenyu/plugin/cache/base/utils/CacheUtils.java
28.57% <100.00%> (+6.34%)
:arrow_up:

...enyu/plugin/cache/redis/RedisConfigProperties.java
42.00% <100.00%> (ø)

...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java
68.75% <0.00%> (-31.25%)
:arrow_down:

...yu/sync/data/http/refresh/AbstractDataRefresh.java
70.00% <0.00%> (-13.34%)
:arrow_down:

...henyu/plugin/grpc/resolver/ShenyuNameResolver.java
56.38% <0.00%> (-7.45%)
:arrow_down:

.../apache/shenyu/admin/model/dto/BatchCommonDTO.java
50.00% <0.00%> (-7.15%)
:arrow_down:

...apache/shenyu/admin/model/dto/AuthPathWarpDTO.java
57.14% <0.00%> (-7.15%)
:arrow_down:

... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4a3bdc...a1b6055. Read the comment docs.


HADOOP-18561. Update commons-net to 3.9.0 (#5214)

Addresses CVE-2021-37533, which only relates to FTP.
Applications not using the ftp:// filesystem, which, as anyone who has used it will know is very minimal and so rarely used, is not a critical part of the project.
Furthermore, the FTP-related issue is at worst information leakage if someone connects to a malicious server.
This is a due diligence PR rather than an emergency fix.
Contributed by Steve Loughran
Description of PR
branch 3.3.5 pr of #5214
For code changes:

[X] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[X] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 50s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-3.3.5 Compile Tests _

+0 :ok:
mvndep
4m 49s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
34m 58s

branch-3.3.5 passed

+1 :green_heart:
compile
18m 35s

branch-3.3.5 passed

+1 :green_heart:
mvnsite
20m 56s

branch-3.3.5 passed

+1 :green_heart:
javadoc
6m 51s

branch-3.3.5 passed

+1 :green_heart:
shadedclient
31m  5s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 26s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
24m 35s

the patch passed

+1 :green_heart:
compile
18m  3s

the patch passed

-1 :x:
javac
18m  3s
/results-compile-javac-root.txt
root generated 3 new + 1863 unchanged - 0 fixed = 1866 total (was 1863)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
20m 35s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
javadoc
6m 45s

the patch passed

+1 :green_heart:
shadedclient
31m 26s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
756m 12s
/patch-unit-root.txt
root in the patch passed.

+1 :green_heart:
asflicense
1m 25s

The patch does not generate ASF License warnings.

966m 38s

Reason
Tests

Failed junit tests
hadoop.yarn.service.TestYarnNativeServices

hadoop.yarn.server.resourcemanager.reservation.TestCapacityOverTimePolicy

hadoop.yarn.server.resourcemanager.recovery.TestFSRMStateStore

hadoop.yarn.server.nodemanager.containermanager.logaggregation.TestLogAggregationService

hadoop.hdfs.TestErasureCodingPolicyWithSnapshotWithRandomECPolicy

hadoop.hdfs.server.namenode.snapshot.TestSnapshotBlocksMap

hadoop.hdfs.TestFileLengthOnClusterRestart

hadoop.hdfs.TestErasureCodingPolicyWithSnapshot

hadoop.hdfs.TestLeaseRecovery2

hadoop.hdfs.server.namenode.snapshot.TestSnapshotDeletion

hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate

hadoop.hdfs.server.namenode.snapshot.TestSnapshot

hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5228/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5228

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs

uname
Linux c5ca494709c6 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.3.5 /<PHONE_NUMBER>84d1171178d13a2b145e7a40980003

Default Java
Private Build-1.8.0_352-8u352-ga-1~18.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5228/2/testReport/

Max. process+thread count
2155 (vs. ulimit of 5500)

modules
C: hadoop-project . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5228/2/console

versions
git=2.17.1 maven=3.6.0 shellcheck=0.4.6

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

all test failures bar two in yarn are test timeouts. the yarn two go nowhere near commons-net

 org.apache.hadoop.yarn.service.TestYarnNativeServices.testAMFailureValidity
 Error Details
Message missing required fields: container_id

org.apache.hadoop.thirdparty.protobuf.UninitializedMessageException: Message missing required fields: container_id
	at org.apache.hadoop.thirdparty.protobuf.AbstractMessage$Builder.newUninitializedMessageException(AbstractMessage.java:477)
	at org.apache.hadoop.yarn.proto.YarnServiceProtos$SignalContainerRequestProto$Builder.build(YarnServiceProtos.java:41521)
	at org.apache.hadoop.yarn.api.protocolrecords.impl.pb.SignalContainerRequestPBImpl.mergeLocalToProto(SignalContainerRequestPBImpl.java:83)
	at org.apache.hadoop.yarn.api.protocolrecords.impl.pb.SignalContainerRequestPBImpl.getProto(SignalContainerRequestPBImpl.java:63)
	at org.apache.hadoop.yarn.api.impl.pb.client.ApplicationClientProtocolPBClientImpl.signalToContainer(ApplicationClientProtocolPBClientImpl.java:622)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:433)
	at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeMethod(RetryInvocationHandler.java:166)
	at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invoke(RetryInvocationHandler.java:158)
	at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeOnce(RetryInvocationHandler.java:96)
	at org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:362)
	at com.sun.proxy.$Proxy99.signalToContainer(Unknown Source)
	at org.apache.hadoop.yarn.client.api.impl.YarnClientImpl.signalToContainer(YarnClientImpl.java:1027)
	at org.apache.hadoop.yarn.service.TestYarnNativeServices.testAMFailureValidity(TestYarnNativeServices.java:980)

 org.apache.hadoop.yarn.server.resourcemanager.reservation.TestCapacityOverTimePolicy.testAllocation[Duration 90,000,000, height 0.25, numSubmission 1, periodic 86400000)]
 Stack Trace
junit.framework.AssertionFailedError
	at junit.framework.Assert.fail(Assert.java:55)
	at junit.framework.Assert.fail(Assert.java:64)
	at junit.framework.TestCase.fail(TestCase.java:230)
	at org.apache.hadoop.yarn.server.resourcemanager.reservation.BaseSharingPolicyTest.runTest(BaseSharingPolicyTest.java:146)
	at org.apache.hadoop.yarn.server.resourcemanager.reservation.TestCapacityOverTimePolicy.testAllocation(TestCapacityOverTimePolicy.java:136)
	at sun.reflect.GeneratedMethodAccessor27.invoke(Unknown Source)

2022-12-18 23:17:03,227 INFO  [main] recovery.RMStateStore (RMStateStore.java:transition(591)) - Storing reservation allocation.reservation_2606473794749035376_5181363377075313936
2022-12-18 23:17:03,227 INFO  [main] recovery.RMStateStore (MemoryRMStateStore.java:storeReservationState(258)) - Storing reservationallocation for reservation_2606473794749035376_5181363377075313936 for plan dedicated
2022-12-18 23:17:03,227 INFO  [main] reservation.InMemoryPlan (InMemoryPlan.java:addReservation(373)) - Successfully added reservation: reservation_2606473794749035376_5181363377075313936 to plan.
In-memory Plan: Parent Queue: dedicated Total Capacity: <memory:1024000, vCores:1000> Step: 1000reservation_2606473794749035376_5181363377075313936 user:u1 startTime: 0 endTime: 86400000 Periodiciy: 86400000 alloc:
[Period: 86400000
0: <memory:256000, vCores:250>
 1023216: <memory:0, vCores:0>
 83823216: <memory:256000, vCores:250>
 86400000: <memory:0, vCores:0>
<PHONE_NUMBER>854775807: null
 ]

+1, merging


TN-136 Weekly site summary email

https://jira.movember.com/browse/TN-136

added overdue_stats_by_org() reporting function, which gets a list of (anonymous) overdue questionnaires, stored by days overdue and sorted by org
added generate_overdue_table_html() reporting function, which generates an html table of overdue questionnaire stats

separate from overdue_stats_by_org(), because (in the email summaries) the table is generated on a per-user basis, but we only ever want to pull the master list of stats once
only shows orgs the given user has access to (that user's orgs, and any child orgs of those orgs)
if top_org is provided, also only shows orgs that are within the top_org's org tree
takes a cutoff_days param, which dictates the split of columns

e.g. cutoff_days=[7,14,21] will result in columns of '1-7 Days', '8-14 Days', & '15-21 Days' (with the data split correctly between them)

includes per-org total column, and overall totals row

added new celery task, to generate a site summary email

takes top_org and cutoff_days params (per the table generation function above)
only sends emails to Staff that belong to the given org (or any child orgs)
pulls table html from reporting function, pulls other email content from LR

added table styling to default EmailMessage styling, tightened up restricted tag check
added SiteSummaryEmail_ATMA AppTextModelAdapter
added unit tests

@achen2401 if you have some time, could you take a quick look at the styling changes I made in portal.models.message, for the default table styling in emails? What I have works as a proof of concept, but you may have some ideas of ways to make those tables look better. Thanks!


Please update windows branch

I hope to use LevelDB in my C# project, and will make a port to C#, could you update windows branch to latest master please?
Thank you very much.

Not currently an official platform, but there's a ton of requests for official Windows support. Leaving #363 open to track this feature request.


unpack_strategy: add support for Cargo crates

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[ ] Have you successfully run brew tests with your changes locally?
[ ] Have you successfully run brew man locally and committed any changes?

This allows for URLs like https://static.crates.io/crates/oakc/oakc-0.6.1.crate to be used in formulae
Tested with https://github.com/Homebrew/homebrew-core/pull/66697 with tar -xzvf step removed

Review period will end on 2020-12-14 at 01:48:24 UTC.

Thank you! 😃

This should be a subclass of Tar.

Is this worth adding even? It will be used for a single (new) formula which could easily use a GitHub URL if the author actually tagged the releases.

@reitermarkus I was tempted to add it but then I asked myself the same question 🤷
It doesn't really hurt but it isn't super-useful too... Makes that one formula a bit nicer and anticipates more crazy cases like that one. Honestly, I can't guess whether that was an outlier or there is a world out there in which not tagging releases on Github is some sort of awkward principle 🙃

FWIW I didn't even bother to try to ask upstream to retroactively tag their releases because it is highly unlikely that'll happen.

There's a chance they'll start tagging releases if we ask but it's not likely to happen if we don't ask.

True, it is worth trying.

At the same time, it would be good to ask them to remove Cargo.lock from .gitignore and commit it

Good catch! (I don't know why so many people fight lockfiles, it is really easy to get them right. The rule of thumb is - they absolutely should be committed. 🤔 )

they absolutely should be committed

Unless you are writing a library.

they absolutely should be committed

Unless you are writing a library.

Depends on your programming language choice. I'm not sure how cargo handles that but npm, for example, won't let you publish your lockfile so there is no harm in committing it. (In case you're writing an app there is shrinkwrap that could and absolutely should be published but sadly it never really took off.)

Woah, I just realized there is no such thing as cargoignore (or inverted, allowlist approach)!
cargo simply packs together the whole source dir and uploads the resulting tarball to crates.io. Having in mind that Rust dependency trees tend to be pretty big those unused tests, examples, and readme gifs could create significant cumulative bandwidth cost 😮

Always commit your lockfile, just exclude it from publishing in case of creating a library.

But then you won't be testing whether your library works without a lockfile on CI, at least not without a workaround.

Review period ended.

Is this worth adding even? It will be used for a single (new) formula which could easily use a GitHub URL if the author actually tagged the releases.

Even if this won't be used much in homebrew-core, I think it can still be useful for third-party taps.

In general we tend not to add code like this if the primary use-case is third-party taps.

Okay, we can revisit this if .crate usage becomes more common

Thanks for understanding @SeekingMeaning ❤

Always commit your lockfile, just exclude it from publishing in case of creating a library.

But then you won't be testing whether your library works without a lockfile on CI, at least not without a workaround.

@reitermarkus You brought an interesting point and got me thinking for a while. This is definitely the wrong medium for this conversation but email isn't really much better due to its private nature and I hope someone can make sense of this weird contradiction. (Feel free to suggest a better way! :upside_down_face: )
On one side you have the possibility of testing without the lockfile which is closer to real-life conditions but also makes your CI runs irreproducible and nondeterministic, and on another side, you have testing with lockfie but what's the point of testing a library under artificial/tailored conditions? :thinking:
To make it more interesting I'm pasting a snippet from React's CI setup:
https://github.com/facebook/react/blob/50393dc3a0c59cfefd349d31992256efd6f8c261/.circleci/config.yml#L62-L63

This is definitely the wrong medium for this conversation but email isn't really much better due to its private nature [...] (Feel free to suggest a better way! 🙃 )

Perhaps https://github.com/Homebrew/discussions ?

This is definitely the wrong medium for this conversation but email isn't really much better due to its private nature [...] (Feel free to suggest a better way! 🙃 )

Perhaps https://github.com/Homebrew/discussions ?

That's why I love public discussions! Thank you!


breadcrumbs dataview note should support dataviewjs

dataviewjs can do advanced manipulation. If dataview query is supported, dvjs should be supported as well.

I don't think there is a simple way to do this...
The Dataview API doesn't even expose a way to run regular WHERE queries, so a full dvjs snippet is probably less likely. I'm constrained by what the API can do, you see?

Isn't it possible to just directly execute that dataviewjs block as js code? Or will it not pick up the dv api calls then

I don't think it will recognise what dv is.
I guess it depends what context the code is executed in? But the console doesn't recognise dv, for example, so it won't work on a global scope

I don't know if this works. I can write normal js code in dvjs codeblock. Can I call a breadcrumb API in the dvjs codeblock to update the breadcrumbs? Then I can use both dvjs and breadcrumbs.
But for sure the dvjs file must be able to run in background.

@HananoshikaYomaru I don't know if you've seen this message yet, but I've exposed an API you can use in dvjs blocks: https://discordapp.com/channels/686053708261228577/855181471643861002/942003316123119646

@HananoshikaYomaru I think you'd be able to set a variable called dv to getAPI() to ensure the javascript would recognize it. At least that's how it works in other languages, I've never done this in Javascript.

Note, there's a Dataview API method called executeJS that looks promising. I need to see if it's a superset (can execute regular dv queries as well), or if I need a way to specify. Also, what shape does it return?


Provide a way to clear / reset the log

A few people have asked, so it's probably about time :smile: I'm thinking a mapping like <prefix>lR,  so it requires a shift key to avoid accidental invocations. The pneumonic is log Reset, thoughts?

Agree. Also auto scroll to the bottom when evaluating something would be an awesome option to have

<prefix>lR will now delete the log buffer! If you have it open and you reset it you'll need to reopen it though, thoughts? Maybe I need two mappings, lr is a soft reset that deletes the lines but keeps the windows open and lR (the current one) which is a hard reset that completely rebuilds the buffer to fix any state issues.

Okay, there you go, <prefix>lr is a soft reset that leaves the windows intact and <prefix>lR is a hard reset that uses bwipeout! to completely destroy it. It's the nuclear option but might be good in some cases.

autocmd User ConjureEval if expand("%:t") =~ "^conjure-log-" | exec "normal G" | endif

Also, I'm working on #131 which adds custom events that Conjure dispatches when certain things happen. That includes when evals occur, you can use that with a buffer name check to execute a normal command (such as G) when you eval in the log buffer. @tami5
This has the added benefit of letting you map these action autocmds to whatever behavior you want :smile:
This is on develop, I'll smoke test it for a few days at work before publishing all of these commits. It'd be great if some people could try out these features and let me know if they work okay for you :blush:
Enjoy!

Anyone else had a chance to try the log resetting or autocmds? I'd love to hear if it works on your setup.
It's been working for me, I even used the mapping in anger at work this week!

@Olical I testing and for now, it's working well on my setup. Thanks! Conjure is awesome!

Released in v4.10.0!


[NEW FEATURE] create initial client

Create an initial version for Dpubsub. The first version must be able to:

Establish the client structure and its configurations;

Publish packages (initially without the header flag);

Receive the packets (initially without the header flags);

I removed the option to receive messages, as the client only communicates with the broker. The most correct option would be to manipulate PUBLISH packets originating from the broker

Initial implementation carried out in commit: 044de5846a04aad5d0c3fdd8cc5d58caa104b8c6


Drop is_ prefix in predicate methods?

In PR #11, the question was raised whether Crystal had a preference for including prefixes in predicate methods (e.g., is_pangram?) or drop them like in Ruby. The coding style section of the Crystal docs is pretty short at this point, so I didn't see any style preference for predicate methods. I did find the following commit from a recent PR that was merged to the core language that would suggest they also prefer to drop the is_ prefix too:
Various cleanups #2668
Would you like me to go through the existing exercises and drop any prefixes on predicate methods (e.g., is_leap)?

I'd agree! If it's something that's a best practice in Ruby, it most likely is also in Crystal. By all means change the predicte methods, if you have time!


postage: replaced by pgmanage-10.0.2

postage is no longer maintained and has been replaced by the identical pgmanage.
I replaced pkgs.postage with pkgs.pgmanage and renamed the corrersponding NixOS module.
When a user enables the deprecated services.postage.enable option the following error will be raised:
Failed assertions:
- services.postage is deprecated in favor of pgmanage. They have the same options so just substitute postage for pgmanage.

A new test  tests.pgmanage has been added which builds successfully.
Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Could you add an entry to the 18.03 release-notes for this.

It may also be worthy of an entry in aliases.nix for retro-compatibility.

Done.


ambiguous use of localizedPrice

product.localizedPrice gives "ambiguous use of" error when pod using with https://github.com/bizz84/SwiftyStoreKit
SwifterSwift Environment

SwifterSwift version: 5.2.0
Xcode version: 11.3.1
macOS version running Xcode:
Swift version: 4.2
Platform(s) running SwifterSwift: iOS

We actually had a discussion about dealing with these kinds of issues in https://github.com/SwifterSwift/SwifterSwift/issues/645. Can you try implement the suggested specific imports in https://nshipster.com/import/ and let us know if it works?
Thanks

Closing, Thanks @canaksoy @guykogus :)


How to add captcha for unfoldadmin?

Is there an easy way to integrate captcha such as 'django-simple-captcha'、‘django-multi-captcha-admin’ into unfold?
or, is there a native captcha implement comes with unfold?

@intp1 django-multi-captcha-admin should work with unfold without explicit integration, recaptcha2 and recaptcha might work, but for simple captcha there might need some work for input only.


Terra popup with hookshot

Summary
Uplift terra-popup to consume terra-hookshot, introduce targetAttachment for finer control, alter resize logic to only dismiss on width change, expose prop to control of attachment fallback, and introduce dynamic sizing behavior.
Address: #913  #797
Thanks for contributing to Terra.
@cerner/terra
The time to rejoice has come! We are now able to hookshot!

Deployment:
https://terra-core-deployed-pr-912.herokuapp.com/static/#/site/popup

Removing UX label, as no visual changes were implemented.

Functional verification completed. Hookshot examples and popups display and function as expected.
SInce Hookshot functionality is specific to popups and menus, let's add some explanatory text and links back to those components.


what is a change event on all components?

https://stackoverflow.com/questions/38227838/what-is-change-event-in-angular-2

https://github.com/angular/angular/issues/13997

Don's call your output using standard dom event names, e.g. change


Add json-ld support

Blocked on sophia's support https://github.com/pchampin/sophia_rs/issues/16

Json-ld parsing and serializing support added to rdf_dynsyn. Should instantiate with appropriate loaders in solid context.


Serve control plane endpoints with trusted certs

What this PR does / why we need it:
The main goal of this PR is to serve the following shoot cluster endpoints with generally trusted certificates:

Alertmanager
Grafana for users & operators
Prometheus
Kibana

Gardener operators are required to deploy a secret to the garden namespace of each seed cluster which contains a wildcard certificate for the corresponding ingress domain of the seed (seed.spec.dns.ingressDomain). Furthermore, these secrets must be labeled with gardener.cloud/role: controlplane-cert.
Since multiple domain hierarchies underneath the seed ingress domain are not supported to be served by an upper level wildcard cert, it was also necessary to change the hostnames for the above mentioned endpoints.

Alertmanager: au-<shoot-technical-id>.<seed-ingress-domain>
Grafana for users & operators: gu-<shoot-technical-id>.<seed-ingress-domain>, go-<shoot-technical-id>.<seed-ingress-domain>
Prometheus: p-<shoot-technical-id>.<seed-ingress-domain>
Kibana: k-<shoot-technical-id>.<seed-ingress-domain>

Previous hostnames are still enabled until depending components (e.g. Gardener Dashboard) have migrated to the new ones. /cc @gardener/dashboard-maintainers
Which issue(s) this PR fixes:
Fixes #1482
Special notes for your reviewer:
Different use-cases have been tested with this PR:

Creation of new shoot cluster
Reconcile existing shoot cluster, verify new hostnames and certificates
Reconcile existing shoot cluster w/ and w/o wildcard certificate

/cc @wyb1
Release note:

Operators can now add generally trusted certificates which are used by shoots' control plane components like `AlertManager`, `Grafana`, `Prometheus`, `Kibana`. Please have a look at https://github.com/gardener/gardener/tree/master/docs/usage/ for more information.

Ingress hostnames of several the monitoring and logging components of shoot clusters have been changed: AlertManager - `au-<shoot-technical-id>.<seed-ingress-domain>`, Grafana - `gu-<shoot-technical-id>.<seed-ingress-domain>`, `go-<shoot-technical-id>.<seed-ingress-domain>`, Prometheus - `p-<shoot-technical-id>.<seed-ingress-domain>`, Kibana - `k-<shoot-technical-id>.<seed-ingress-domain>`. Previous hostnames are still active but will be removed in the future.

What about the kube-apiserver endpoint? 😊

What about the kube-apiserver endpoint? 😊

As once discussed, we can't really migrate the API servers' hostnames since it would invalidate already issued Kubeconfigs. We can either offer an additional hostname with a valid cert or only use new hostnames for new clusters. This should be discussed and done in a separate PR.


License requirement for Inactive Mailboxes?

Please clarify the license requirement for ”Inactive Mailboxes”. The article gives you the inpression as long as you are licensed for Retention Policies hold you are fine.
However, the Modern Work Comparison PDF (https://aka.ms/M365EnterprisePlans) show that ”Inactive Mailboxes” is not available for Microsoft 365 F5 Compliance (which has Retention Policies and Litigation Hold).

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: ae6b1290-00ae-8f23-1b41-5ca692e6d1c4
Version Independent ID: ab2acdbd-a620-86de-8544-e655aa386b0a
Content: Learn about inactive mailboxes - Microsoft Purview (compliance)
Content Source: microsoft-365/compliance/inactive-mailboxes-in-office-365.md
Service: o365-seccomp
GitHub Login: @cabailey
Microsoft Alias: cabailey

@JonesMikael  I'm not following how this article gives you the impression as long as you are licensed for retention policies you are fine - I couldn't find the word "license" anywhere on this page and because of the complications of licensing and how often they can change with new options, we have removed these references to ensure we don't inadvertently provide out of date information. Instead, this page and others for data lifecycle management show a link at the top of the page to the authoritative licensing information. If the licensing info you need isn't there, please leave a GitHub Issue on that page for the relevant team.


Getting StackOverflow exception while generating API docs

/cc @tpetricek
No idea what's causing this

ICFP deadline this Firday :tired_face: ... flagging & will look after that!

shit. now I'm getting this everywhere ;-(

@matthid @7sharp9 @dsyme did anything changed in RegisterAndPrepareToImportReferencedDll recently in FCS?

Not sure, quite a few stack overflows occur from FCS on retrieving symbols or tooltips in certain places. Analysis i the compilers prettyprint modules always cause it for instance.  Can you identify which symbol or tooltips etc that causes it?

nope. no idea how, but it's happening on 3 different projects using FSharp.Formatting

I can repro this, it seems to be related to the FSharp.Core nuget package. I got this error on a project as soon as I used the FSharp.Core nuget package instead of the regular FSharp.Core distribution.

I noticed the following as well:

If you remove FSharp.Core.dll from the output directory (where FSharp.Formatting searches for references), it works
If you add --noframework to otherFlags of MetadataFormat.Generate we get a different error (sigdata missing)
I think --noframework, removing the dll or pointing to the correct packages/FSharp.Core/*/ would also work (not tested)

Can somebody verify this?
Maybe we should set Private to false for FSharp.Core (via paket)? Related: https://github.com/fsprojects/Paket/issues/566

I just noticed there is an even simpler fix (paket already supports this, really awesome!):
Just use
nuget FSharp.Core copy_local: false

instead of
nuget FSharp.Core

in paket.dependencies

but then it doesn't work on PCs which don't have F# installed, right?

Correct. I assumed people building this library have it installed. For users it doesn't really matter.
But I don't think the underlying issue is fixed anytime soon as FSharp.Core.dll seems to be designed in a way that it is assumed to live near a optdata and sigdata file. But there is none when we copy it...
The underlaying issue looks like we mixup wrong optdata, sigdata and FSharp.Core.dll (see my longer comment for details).
It would certainly be nice to have any comment on this from FCS experts ...

since the optdata and sigdata is inside the package, we should let Paket or FSharp.Formatting handle this.

Yeah I tried that by using the --noframework options and hooking in the correct path, but it didn't work (see above stacktrace). What did work was copying optdata and sigdata. But this all looks really weird to me (I can't understand why the copying option works but --noframework doesn't).
So if you want to go down that road somebody should do some analysis why all of the above things happen, including the stack-overflow (again only some F# compiler (service) expert can answer this). Otherwise we might run into even more issues like this in the future. I would be very interested in why this happens because I had issues with optdata and sigdata files in the past as well...

@forki What do you think of https://github.com/matthid/FSharp.Formatting/commit/22ffb8ec3c743ceaf069893a46a7521667c6fc9d this should fix this issue as well.

yes. solving things in FSharp.Formatting sounds perfect!

But I don't know what the implications are when no F# is installed (which you noted previously). Where does FSharp.Compiler.Service find a FSharp.Core (does it even find one?). I think you always need to have F# installed to make anything work with regards to FSharp.Formatting.

I think you always need to have F# installed to make anything work with regards to FSharp.Formatting.

I hope that's not true.


ic-indicator only selects first element

It seems that although ic-indicator accepts any CSS selector, it only uses the first one it finds. Not sure if this was intentional or not. I ran into a scenario where I had a spinner element that was the sibling element to my swapped in set of data. I was trying to use multiple indicators (using a class CSS selector) in combination with ic-use-transition to try to get my data element to be hidden when the request was in flight and the spinner was being shown. If there's a clearer way to do that, I'd love to know.

Can you give me a rough outline of your HTML?  We should be able to work something out.


[8.x] Fix JSON column based HasOneOrMany load() method

Currently we can use a nested JSON key as a column of the HasMany relationship. In my case:
class Message extends Model
{
    public function notifications(): HasMany
    {
        return $this->hasMany(DatabaseNotification::class, 'data->message_id');
    }
}

I do nothing else, but on the database channel, I save the ID of the passed message model into the data payload of the DatabaseNotification model.
So we can say – I don't know if it's intentional, I was quite suprised btw – JSON keys are supported in HasMany/HasOne relationships by Laravel. I know it's not the suggested way of using it, but in some cases it can be handy.

However, there is a bug, when I try to use load/loadMissing on the relationships with a JSON key.
$message->notifications // work as expected

$message->load('notifications') // loads an empty collection

$message->loadMissing('notifications') // loads an empty collection

As it turned out, because of the "wrong" extraction of the foreign key the loaded relationship value gets an empty key "", this is what I fixed in the PR.
Normally this is not a BC.

I don't want to explicitly support these types of relations at this time.


Version 2.3.2 Cannot user scan with order

Hi, i'm trying to use ordering with elasticsearchTemplate scan mode but it doesn't seem i can?
any solution / suggestion? i'm on version 2.3.2

Hi @icecold21 , Indeed It's seems to be an issue.
Can you send to me a short code snippet to describe your case.
I will fix it quickly.
Thanks.
Julien.

Ho @icecold21 , I'm sorry by sort is not available at scan method on ES 2.x
Scan is deprecated and replaced by search-scroll.
I'm sorry but there are no quick solution to fix this issue with this version.


DropMongoMigrationStrategy actual vs documented behaviour.

Hello,
Regarding DropMongoMigrationStrategy docs says that this strategy will drop the database:
Drop

This will simply just drop your existing Hangfire.Mongo database and update the schema version.
No fuzz and ready to start from scratch. It is the perfect strategy if you e.g. enque all your jobs at startup.

But if we look at the code, it looks like that this strategy has never droped the entire database, but hangfire collections only.
Could you please clarify the behaviour of this strategy? Is it required to have a separate mongo database for hangfire.mongo? Are the any plans on changing the behaviour of this strategy in future releases (e.g. it will drop the entire database including hangfire collections and other collection persisted in the db)?
Best regards,
Vladimir

@Vladimir-Frolov,
I dont recall exactly why we opted for dropping the collections only. probably a combination of.

It might not be a hangfire specific database, so users might unintentionally drop their application database.
Dropping the database might require admin rights. I dont recall.
The time the migration runs. We are already connected to the database. dropping it entirely would require use to re-connect to the database.
Its not needed as dropping all collections gives the same end result.

We don't plan to change the current supported strategies. We have hopefully created a design where users of the lib can write their own strategies if needed.
It is not required to have a separate database.
I will update the documentation to describe this better. Thanks for the feedback!
I hope this helps!
Thanks!

@gottscj
Yes, it really helps.
Thanks for quick response!
Best regards,
Vladimir


Update product scope and user stories

LGTM! Aligns with what we have discussed earlier. Thanks @limrik!


Feature-Request : Highlighting for fixed-type and nullable type attributes

Part of the MSON spec but not yet supported by this plugin.
https://apiblueprint.org/documentation/mson/specification.html#353-type-attribute

@CameronLonsdale We would very much appreciate it if you could make a PR.

Added in https://github.com/apiaryio/api-blueprint-sublime-plugin/commit/cd4b76c3e46fa7e9e3f29a12f44dcc97ab9ac258


From Scott on Gitter

openaps alias add loop '! bash -c "openaps preflight && openaps gather && openaps get-settings >/dev/null && openaps enact; openaps upload"' works, but openaps alias add loop '! bash -c "openaps preflight && openaps gather && openaps get-settings >/dev/null && openaps enact ; openaps upload"' doesn't. difference is the space before the ;
Line 144

I see you already fixed it in dev.

Yeah, I have a habit of fixing things in that repo locally and not pushing. Will have to be better about that now. :-)

This weekend I went through I combined meal-assist-setup.sh and the main setup.sh… very proud of myself.  I go to your site to submit it and I see you already did it!
:)  It was a good exercise!
From: Scott Leibrand<EMAIL_ADDRESS>Sent: Monday, January 4, 2016 3:27 AM
To: scottleibrand/openaps-sh<EMAIL_ADDRESS>Cc: Toby Canning<EMAIL_ADDRESS>Subject: Re: [openaps-sh] From Scott on Gitter (#2)
Yeah, I have a habit of fixing things in that repo locally and not pushing. Will have to be better about that now. :-)
—
Reply to this email directly or view it on GitHub https://github.com/scottleibrand/openaps-sh/issues/2#issuecomment-168620419 .  https://github.com/notifications/beacon/ADSK0DhklP6KjcmBK--2y2CssSyaf8_Yks5pWjJGgaJpZM4G9kc7.gif


Migration to Godot 4.0

Hey, I did a bunch of grunt work migrating the plugin to Godot 4.0. I managed to get it running but some of the tests fail. I've run out of time to finish it so I thought I'd throw it up as a draft PR for someone else to pick up.
Cheers!

Sounds awesome! I was planning to create a 4.0 branch of GLoot and this seems like a great first step.
Thanks for the input!


Fix immutable frozen set bug in defs.bzl

When adding tags to a native cc_library rule that is created through a macro we
were not properly considering the case where the tags came from a different
file and therefore were frozen. This caused an error.
This change was originally submitted by @oquenchil as
https://github.com/bazelbuild/rules_cc/commit/cfe68f6bc79dea602f2f6a767797f94a5904997f

Hi Marcel,
can you review and merge this? It's a small, uncontroversial change blocking the adaption of rules_proto in some cases. Thanks in advance!
//cc @KeithMoyer

Hey,
Apologies for the loooong delay; most of the people were out of office for Christmas break.


install elan on windows

I have created a workflow running on Windows.
see: https://github.com/lean-ja/lean-by-example/blob/edc6f5e9d023b0f4c4beb26474e1b678b8e9ba5e/.github/workflows/ci.yml#L29
Almost always building on Windows is not necessary, but I sometimes need this. (For example, when trying to provide an environment which reproduce a lean bug on Windows machine...)

I think there should be a conditional branch that detects the runner OS and installs elan in a different way if it is Windows. How do you think?

It would be possible to use conditional logic to achieve this, however, I think it would require rewriting most of the scripts that power most of the functionality of lean-action for a Windows environment since they are written in Bash.
I know some GitHub actions support multiple runner operating systems by writing the action in TypeScript instead of having shell scripts and then using shell scripts for specific OS-specific components, e.g., setup-PHP. There are other advantages to using TypeScript instead of the current lean-action architecture so this could be a worthwhile refactor in the future.

Thank you for the tip here @joneugster!
I have a PR open to add support for Windows runners. We can use the existing scripts with a slight modification to the call site because of a known issue with GitHub custom actions (link to issue).
Windows runner support should be available in the next week or two with the next release of lean-action.


Added the topic of Decentralized Finance (deFi) and some resources

Added the topic of Decentralized Finance (deFi) and some resources to learn the same for beginners

Thanks for the PR.  It has been merged.
I will be glad if you can leave a star on this repository.


Integration Test - Release - 2022/04/12 15:03:12

Auto create for integration test. IssueCommandFlow

#pri1

#pri2

#pri3

#assign NonAllowedUser

#reassign PRMergerTest2

The following users don't have valid GitHub IDs, or are not collaborators on this repo: nonalloweduser

#unassign PRMergerTest1

#unassign NonAllowedUser


[innernet] Update to v1.3.1

Still needs testing

@Eeems made it! :)

@plan5 does this include the new bash completions?

@plan5 does this include the new bash completions?

Ah yes, it does. Should they go to /opt/usr/share/bash-completion/completions/ ?

Ah yes, it does. Should they go to /opt/usr/share/bash-completion/completions/ ?
Edit: There are also completions for elvish, fish, zsh (and powershell), so they need a place, too (except powershell).

I'm not really sure. @LinusCDE I think you've poke around with bash completions, where are our standard locations?

I think the directory mentioned by @plan5 is right (/opt/usr/share/bash-completion/completions/). I think I've added the completions for _opkg there as well, but am not sure whether this is the best way of "extending" bash-completions which provides a lot of helper functions and infra structure found in /opt/usr/share/bash-completions.
I have the draft for opkg completions as a seperate toltec-completions package in #277 . Didn't get to finalize it yet. Any input there is welcome as well and the package should already work for the most common use cases.

Just made #277 read for review. Once that is in, we will also have the bash-completions package to enable innernet completions to work.
You could probably make the package makedepend on that package then. But I don't think that this is a requirement.

Add bash completions

I'll try to look into it next week. If anyone wants to do it before then, you're welcome :)

@plan5 will you be able to add the bash completions anytime soon? I'd be willing to merge without them if you intend to add them as a separate package.

@plan5 will you be able to add the bash completions anytime soon? I'd be willing to merge without them if you intend to add them as a separate package.

Unfortunately I'm not able to work on this right now, hopefully things will slow down again a bit next month. So feel free to merge. I also didn't find time to wrap my head around the right way to provide completions yet
m)


Init/update/remove C# execution options API

Move the above into its own PR as a stand-alone from #60. Test to see if it works in the current setup from main with the Core API

Closed with #70


Adding libraries to aurelia SPA template errors

I'm having great difficulty adding several libraries to an app built using the Aurelia SPA template.  Something as simple as adding the numeral library fails with:
ERROR in ./ClientApp/app/components/counter/counter.ts
(1,9): error TS2305: Module '"numeral"' has no exported member 'numeral'.
this is after doing the following:

running npm install for the typings and the library which results in the following in the package.json file:

'''
"dependencies": {
"@types/numeral": "0.0.22",
"numeral": "^2.0.6"
}
'''

updating the boot.ts file with the following:
'''
aurelia.use.standardConfiguration()
.plugin(PLATFORM.moduleName("numeral"));
'''

adding the following to counter.ts
'''
import {numeral} from "numeral"

export class Counter {
public currentCount = 0;
public incrementCounter() {
    this.currentCount++;
}

}
'''
Some libraries such as aurelia-validation or aurelia-bootstrap-datetimepicker work fine using the same process, while others such as aurelia-api or aurelia-value-converters fail with similar errors or the infamous ModuleID "..." not found error.
As I'm just learning the intricacies of webpack and aurelia, it's highly likely that these are errors on my part..., but after much searching and numerous email exchanges with other aurelia developers, who say "I did the same thing you did, but using one of the Aurelia skeletons (not these skeletons) and it just worked...", I'm stumped.
Regards,
Rob

Is there some additional info I could add to get a little help here?

So, I'm a little bit closer to understanding what the issue is here.  It has to do with the way entry element is configured in the different webpack skeletons.  Many of the popular aurelia plugins want you "add the plugin to the corebundles.aurelia section of your webpack config".   Now it appears that the webpack.config.js produced by these skeletons produces something like this:
entry: { 'app': 'aurelia-bootstrapper' },

whereas the people providing these integration instructions expect that it looks something like this:
  const coreBundles = {
  bootstrap: [
    'aurelia-bootstrapper-webpack',
    'aurelia-polyfills',
    'aurelia-pal',
    'aurelia-pal-browser',
    'regenerator-runtime',
    'bluebird'
  ],

  aurelia: [
    'aurelia-bootstrapper-webpack',
    'aurelia-binding',
    'aurelia-dependency-injection',
    'aurelia-event-aggregator',
    'aurelia-framework',
    'aurelia-history',
    'aurelia-history-browser',
    'aurelia-loader',
    'aurelia-loader-webpack',
    'aurelia-logging',
    'aurelia-logging-console',
    'aurelia-metadata',
    'aurelia-pal',
    'aurelia-pal-browser',
    'aurelia-path',
    'aurelia-polyfills',
    'aurelia-route-recognizer',
    'aurelia-router',
    'aurelia-task-queue',
    'aurelia-templating',
    'aurelia-templating-binding',
    'aurelia-templating-router',
    'aurelia-templating-resources',
    'aurelia-api',
    'aurelia-authentication',
    'aurelia-testing'
  ]
}

const baseConfig = {
  entry: {
    //'app': [/* this is filled by the aurelia-webpack-plugin */],
    'aurelia-bootstrap': coreBundles.bootstrap,
    'aurelia': coreBundles.aurelia.filter(pkg => coreBundles.bootstrap.indexOf(pkg) === -1),

    'common': [
        "./src/resources/global/less/base/base.less",
        "./src/resources/global/less/layout/layout.less",
       ],
    // 'homepage' : './src/application/homepage/homepage'
    /*'about': './src/application/about/about.less',*/

  },

Now, I'm not exactly sure what the ramifications are of changing things to the latter way.  If anyone could provide some guidance or point me to some guidance as to how this should be done, I'd be grateful.
Thanks,
Rob

We're no longer enhancing the Vue template (for info, please see https://github.com/aspnet/Announcements/issues/289).
Please feel free to continue any discussion about adding packages here though! I'm just marking it as closed because it's no longer an active work item in this repo.

Ah, just read your linked anouncements, not just Vue....
Sad,  I think my question was just about how to resolve the issue with how
do we reconcile the two different versions of webpack configs.
Rob
On Thu, Feb 8, 2018 at 9:55 AM, Rob Scott<EMAIL_ADDRESS>wrote:

Hey Steve,
The question wasn't about Vue it was about Aurelia.
Rob
On Thu, Feb 8, 2018 at 4:25 AM, Steve Sanderson<EMAIL_ADDRESS>wrote:

We're no longer enhancing the Vue template (for info, please see
aspnet/Announcements#289
https://github.com/aspnet/Announcements/issues/289).
Please feel free to continue any discussion about adding packages here
though! I'm just marking it as closed because it's no longer an active work
item in this repo.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/aspnet/JavaScriptServices/issues/1406#issuecomment-364051638,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABxNKnNNOXtU-F8P8a9zEZ5N1oE35o7Uks5tSr19gaJpZM4QzznG
.


Build periodically fails with error: The compiler is unable to type-check this expression in reasonable time

It happens in the source:
/Pods/Macaw/Source/model/draw/ColorMatrix.swift:60:17: The compiler is unable to type-check this expression in reasonable time; try breaking up the expression into distinct sub-expressions.
Enabling source editing and adding type to expression fixes the problem. New code look as follows:
let a: (Int) -> Double = { i in
m1[i] + c * m2[i] + s * m3[i]
}
Added type (Int) -> Double here. It would be great to have it out of box.

@Alexeichua
Updating pod file like this
pod "Macaw", "0.9.7"
solved my issue


If simulation fails on startup, eg there's no internet, throw error but don't block the view from rendering

Currently it doesn't render anything if I cut network, but will start working again when network is back

 Currently it doesn't render anything if I cut network, but will start working again when network is back

hmm, I need to take a look what could cause that. Thank you for noticing


restrictToRoles hook: More complex determination of "owner".

Problem:
In many cases, the determination of an "owner" relationship between a user and a record can not be just pinned down by checking on a foreign key on the user model (e.g. everything depending on n:m relations).
Suggestion:
Introduce something like an resolveOwner field, which references a function that returns a Promise that either gets resolved (permission granted) or rejected (permission denied).
I'd gladly send a PR if you're interested, but I just wanted to check if there's already some (established) way of achieving that kind of behavior and, more importantly, how you guys think about this kind of approach.
restrictToRoles({
	roles: ['admin', 'super-admin'],
	fieldName: 'permissions',
	idField: 'id',
	resolveOwner: (hook) => {
		// check whatever
	),
	owner: true
})

I agree. I've created an issue for you to pass a callback to do whatever you want (#210) however in the mean time you can also just write your own hook to do any custom resolving.

We actually came up with a better solution. You can simply wrap any existing hooks in your own, like so:
import { hooks } from 'feathers-authentication';

exports.hashPassword = function(options) {
  // Add any custom options

  function(hook) {
    return new Promise((resolve, reject) => {
      if (myCondition !== true) {
        return resolve(hook);
      }

      // call the original hook
      hooks.hashPassword(options)(hook)
        .then(hook => {
          // do something custom
          resolve(hook);
        })
        .catch(error => {
          // do any custom error handling
          error.message = 'my custom message';
          reject(error);
        });
    });
  });
}

This provides the ultimate flexibility and doesn't require a change to the core hooks.


Fix mob pull issue

About the PR

Once again allows creatures that inherit from simplemob(hamster, slime, spider, etc) to pull items.
Why / Balance

fix issue https://github.com/space-wizards/space-station-14/issues/22465
Technical details

Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

None
Changelog
:cl:

fix: Mobs can now pull things

I feel like this really shouldnt be on simplemob. Entities should just add this as needed because every mob being able to drag can be highly problematic.

Wasn't the point to stop them pulling and breaking / stealing things?

I feel like this really shouldnt be on simplemob. Entities should just add this as needed because every mob being able to drag can be highly problematic.

Well, this is how it was before the PR that nerfed mothroaches.

Wasn't the point to stop them pulling and breaking / stealing things?

Only mothroaches. But for some reason the author of that PR forbade all creatures that inherit from simplemob from doing this. I added a line of code that saves his changes but again allows everyone else to drag things along.

Looks good in regards to what the original concept of the PR was. I would clarify the changelog entry a bit, and end it with a "."
Now the question is, do you want to call it a day and leave it like this, which would be fair. Or consider emogarbage's suggestion, which I will admit is probably a better idea in the long run.

I believe that for my first PR, what I have now will be enough. I spent 4 hours on this, perhaps Emo’s proposal needs to be implemented separately from this PR.

I also think there needs to be a discussion about which existing mobs should retain the ability to pull things, which should be added this ability, and which should be removed.

So?

This would certainly nice to have back.

Wasn't the point to stop them pulling and breaking / stealing things?

Only mothroaches. But for some reason the author of that PR forbade all creatures that inherit from simplemob from doing this. I added a line of code that saves his changes but again allows everyone else to drag things along.

Mothroaches are a symptom of the problem, hamsters or whatever billion simplemobs there are being able to do it is still an issue.

What was the original issue with moth roaches being able to pull things anyways?

Updates?

What was the original issue with mothroaches being able to pull things anyways?

Mobs that can go under doors pulling things.

Mobs that can go under doors pulling things.

I thought items don't slide under doors even when pulled
Mobs can pull items through plastic flaps though

People asking for updates when the original request is still pending.

Oh okay. Well. @EmoGarbage404, Do you have a rough list of mobs or groups of mobs that should be allowed to pull?


TO: RETURN should add newline for cacheurl_(.*).config

RETURN adds a newline for header rewrite, the same should work for cacheurl config files.

RETURN has become a convention to insert newlines into remap config files -- header rewrite is probably the best example for this.


ExplanationDashboard multi-class switch

Is it possible to switch class displayed in dashboard ? Currently first class is displayed.
Below is two classes scenario "Leaving" and "Staying" like this sample notebook Default is "Leaving". I want to switch it to "Staying".

@koabuta this is a known requested feature that I believe @zhb000 is assigned to add for binary classification case


XWALK-2697

Support for client-side SSL certificate for Android
Bug=XWALK-2697

Please squash all into one commit.

Test case is also needed for this feature. Thanks a lot for you patch. @ZhengXinCN

Does anyone have any idea to do a unit test without a server requests Client Cert?

@wuhengzhi  I added a simple test case that connects to this URL https://egov.privasphere.com/. I actually don't own this server, so not sure if this is a good idea. However, we need proper SSL certificates on this test server where we attempt to connect to and this one looks fine.
I am uncertain if the test was executed during "Testing patch series" and if it passed?

Please move the test case from XWalkCoreInternalTest to XWalkCoreTest, since the related function was overridden from XWalkResourceClient instead of XWalkResourceClientInternal.
Please enrich the commit log, e.g some code was ported from upstream; Add title for commit log: [Android] Support for client side SSL certificate.
For test, please install XWalkCoreShell.apk, then execute ./build/android/test_runner.py instrumentation --release --test-apk=XWalkCoreTest

@ZhengXinCN From http://developer.android.com/reference/android/webkit/WebViewClient.html#onReceivedClientCertRequest(android.webkit.WebView, android.webkit.ClientCertRequest), we can see onReceivedClientCertRequest has only two paramters.
I think we should supply the similar API to user. e.g. For XWalkCoreInternal, onReceivedClientCertRequest(XWalkViewInternal view,  ClientCertRequestHandlerInternal handler).
For XWalkCoreShell, onReceivedClientCertRequest(XWalkView view,  ClientCertRequestHandler handler).
This PR will also resolve XWALK-3667.

@wuhengzhi OK, adapted as requested, can you please review once more?

I will review it today, thanks.

Please add BUG=XWALK-2697, XWALK-3667 in comment.

@wuhengzhi Thanks, I will fix them later on, and another question, do you have any code style formatter setting file for Eclipse of this?

Sorry, I have no format file.

@wuhengzhi can you please review once more? when you have time. thanks

In the comment, wrer is were?

+1000

Thanks @ZhengXinCN, did you run test case by ./build/android/test_runner.py instrumentation --release --test-apk=XWalkCoreTest.
@axinging @lincsoon Please help to review, thanks.

@wuhengzhi yes, I did run the test after I changed API, and my test case went pass. and I just test again seems no problem:
W    0.077s Main  org.xwalk.core.xwview.test.OnCreateWindowRequestedTest#testOnCreateWindowRequested has no annotations. Assuming "SmallTest".
W    0.212s Main  Creating 1 test runners.
W    0.213s bfe8  Creating shard 0 for device 4790f03ef70fbfe8.
W    2.115s bfe8  Unable to enable java asserts for 4790f03ef70fbfe8, non rooted device
W    4.880s Main  Running tests with 1 test runners.
W  194.828s bfe8  Will retry test org.xwalk.core.xwview.test.ShouldOverrideUrlLoadingTest#testCalledOnJavaScriptLocationDelayedReplaceRedirect, try #1.
W  469.244s bfe8  Test size not found in annotations for test 'org.xwalk.core.xwview.test.OnCreateWindowRequestedTest#testOnCreateWindowRequested', using 1 minute for timeout.
C  477.678s Main  ********************************************************************************
C  477.678s Main  Summary
C  477.678s Main  ********************************************************************************
C  477.679s Main  [==========] 124 tests ran.
C  477.679s Main  [  PASSED  ] 124 tests.
C  477.679s Main  ********************************************************************************

I will give LGTM.  Thanks for Zhengxin's contribution.
Please help to add one line in the new API  XWalkResourceClientInternal.onReceivedClientCertRequest's comments:

@since 6.0

Why expose ClientCertRequestHandlerInternal to external? I couldn't see the need to extend ClientCertRequestHandler or any interface to handle a ClientCertRequestHandler object.

LGTM except the matter I mentioned above. Thanks for @ZhengXinCN 's contribution too!

public void onReceivedClientCertRequest(XWalkView view,  ClientCertRequest handler) will be overriden bu user, so ClientCertRequestHandler need to expose to external. Please look at http://developer.android.com/reference/android/webkit/WebViewClient.html#onReceivedClientCertRequest(android.webkit.WebView, android.webkit.ClientCertRequest).

ClientCertRequest or ClientCertRequestHandler?

Oh, ClientCertRequestHandlerInternal is the internal implementation, need not to expose to external.

seems I should expose android.webkit.ClientCertRequest.

I think it's okay to add the interface org.xwalk.core.ClientCertRequest. Just remove ClientCertRequestHandler from reflection generator if you don't want the developers to use it directly.

@lincsoon
if I removed "ClientCertRequestHandlerInternal" from generator, the generated class "XWalkResourceClientBridge.java" will failed to build (it wants [classname]Bridge).
User needs to override "onReceivedClientCertRequest" from "XWalkResourceClient" to handle client SSL request. Any idea to have a handler pass out without reflection generator?

Sorry, I didn't noticed that ClientCertRequest is an interface. Then you can keep ClientCertRequestHandler in the reflection generator.
But one more thing, you need put ClientCertRequest in the java docs so that the developer can know it. Please check the target xwalk_core_library_documentation in xwalk_core_library_android.gypi and add ClientCertRequest to the variable api_files. Then file the description of ClientCertRequestInternal just like XWalkJavascriptResultInternal, except the version is since 6.0.

ClientCertRequestInternal could be declared as abstract class, please take https://github.com/wuhengzhi/crosswalk/commit/fc8e7f249e1884b0b21a7ee913dfe80fe0fe1079 for a reference.

Yes, you can change ClientCertRequestInternal to abstract class like XWalkDownloadListener, or keep current implementation like XWalkJavascriptResult. Because we don't have special provisions here, both styles are okay.

@lincsoon I added it.
@wuhengzhi I prefer to use interface.


[mx2onnx] Feature Request - Support for all modes of L2Normalization

Currently, I see that there is support only for 'channel' mode in L2Normalization for MXNet to ONNX Conversion.  (Reference)
Is it possible to add conversion support for all the modes of L2Normalization listed here ?

I met same problem... Is it possible to add conversion support for all modes of L2Normalization?

I met same, 2020.8 now still nobody fix this.....

cc @josephevans @ChaiBapchya

I met the same,2020.11 this problem is not fixed！！！


[Cloudflare] Custom record TTL

Custom record TTL annotation should be noted by Cloudflare provider
TTL min value is 120 everything below will take the default TTL which is 1 (automatic which means 300)

@ideahitme I removed the part and added some context in the Cloudflare tutorial.
I checked external-dns again and it seems like the error is already logged and I think it's pretty understandable that you have to change the TTL at least to 120 or higher.

/lgtm


How to connect to remote URL which requires authentication

Hi,
First of all thanks for such a great library for downloading.
I have been using this library and came across a scenario where i need to connect to remote URL which requires authentication but it seems there is no documentation that addresses my issue. Do i need to send username and pass in request headers?

Since you can specify the downloader you would like to use, as per this, (https://github.com/tonyofrancis/Fetch#downloaders).
You could just add the authentication credentials to okhttp. I found a good question on stackoverflow for this. (https://github.com/tonyofrancis/Fetch#downloaders)


Safari Support

Any interest in adding support for safari? I have chrome but safari much better at battery on mac.

I am sorry, but I have no energy to support safari.

@tilfin how are you on energy today?

This might be possible now with Safari Web Extensions: https://developer.apple.com/documentation/safariservices/safari_web_extensions

Hey @tvb @jessebye,
I've ported this plugin to Safari and the extension is published in the Mac Store. More info here https://github.com/rmatec/aws-account-switcher-safari-extension

BAM! Very nice @rmatec I've installed the extension and will give it a try 👍🏻


feat: ui dropdown and select, ref #4312 and #4417

Try out this version of Leather — Extension build, Test report

This PR creates working components for the shared DropdownMenu and Select, both use shared components from an elevated list folder. It is hard to know if this implementation will work for all use cases, but I think it is a good start until we implement them and make adjustments as-needed with those issues. I only created the simple list item here, but it should be pretty flexible to reuse/customize for other item designs. Also, I ended up having to install the primitives bc the themed Select doesn't expose the ItemText or ItemIndicator to customize.

Going to merge this bc won't be seen yet anywhere and my Storybook branch is based off this one. It will be easier to make more changes there if needed so I can work with the components in stories.


The gui interface don't work as expected

What?
The gui interface introduced at #39 don't work as expected. The gui don't respond to user interaction (button clicked).
OS

Windows 10

I think we can close this issue now. 😎


raidboss: improve o2s triggers

@Jaehyuk-Lee You've done the work so I'll commit it, but in the future I think it is better to add translations after something has been committed rather than translating PRs that are still in progress.  I think it makes it harder to change the English strings (which haven't been reviewed yet and maybe people want different wordings).

okay 😃


python311Packages.pdfminer-six: 20221105 -> 20231228

Diff: https://github.com/pdfminer/pdfminer.six/compare/20221105...20231228
Changelog: https://github.com/pdfminer/pdfminer.six/releases/tag/20231228
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 277440 at 85219bcd run on x86_64-linux 1

1 package marked as broken and skipped:

python310Packages.unstructured-inference

32 packages built successfully:

diffoscope
diffoscope.man
invoice2data
ocrmypdf (python311Packages.ocrmypdf)
paperless-ngx
pdfminer (python311Packages.pdfminer-six)
python310Packages.camelot
python310Packages.extractcode
python310Packages.fpdf2
python310Packages.layoutparser
python310Packages.ocrmypdf
python310Packages.pdfminer-six
python310Packages.pdfplumber
python310Packages.pdfx
python310Packages.py-pdf-parser
python310Packages.scancode-toolkit
python310Packages.typecode
python310Packages.unstructured
python310Packages.weboob
python311Packages.camelot
python311Packages.extractcode
python311Packages.fpdf2
python311Packages.layoutparser
python311Packages.pdfplumber
python311Packages.pdfx
python311Packages.py-pdf-parser
python311Packages.scancode-toolkit
python311Packages.typecode
python311Packages.unstructured
python311Packages.weboob
setzer
visidata


Added retry functionality to the API request.

Hi Frank
Thanks for the package!
I added a small retry part (and dit minor formatting) to the request session in case there are large amounts of requests (as in my case). GIE sends a ConnectionAborted and the retry catches that.

nice! thanks for the work!


Non-Ascii characters stripped from attachment names (1st char only)

I use UTF-8 encoding for sending mails. If I add a file with the name "Řeřicha.txt" the Ř character is stripped.
Swift produces:
--=swift_v4_12456688804a3f66105fa38=
Content-Type: text/plain; name="=?utf-8?Q?e=C5=99icha=2Etxt?="
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename*=utf-8''e%C5%99icha.txt
How can I fix this?
Original creation date: 2009-06-22T11:10:56Z
Original reporter: Merijn
Original ticket: http://swiftmailer.lighthouseapp.com/projects/21527/tickets/97

I can't believe this bug is still open. It has been 2 years and you've created many new releases. This one is so easy to fix and it causes major problems for users with non-latin characters in their language.
Please fix it.


Unable to change menu orientation to left hand side

Is there a setting or option to customize where the menu is rendered? I would like it rendered on the left hand side as a collapsable menu, what customizations are necessary here?

@mikewronski Nothing like that exists currently. That would involve a significant change to the CSS (and maybe HTML) for the header. I think that's outside the scope of this extension at the moment. There is at least one similar theme that does have a sidebar navigation here. Maybe that will work for you?


formatOptions is not applied on base image

When uploading image files, the formatOptions are only applied to "imageSizes" and not to the base image.
import { S3UploadCollectionConfig } from 'payload-s3-upload';

const TextImages: S3UploadCollectionConfig = {
	slug: 'texts_images',
	labels: { singular: 'Texte - image', plural: 'Textes - images' },
	access: {
		read: () => true,
	},
	admin: {
		group: 'Fichiers',
		disableDuplicate: true,
	},
	upload: {
		staticURL: '/texts/images',
		disableLocalStorage: true,
		s3: {
			bucket: 'lepitre-public',
			prefix: 'texts/images',
			commandInput: {
				ACL: 'public-read',
			},
		},
		imageSizes: [
			{
				name: 'thumbnail',
				width: 200,
				height: undefined,
				formatOptions: {
					format: 'webp',
					options: {
						quality: 70,
					},
				},
			},
		],
		formatOptions: {
			format: 'webp',
			options: {
				quality: 70,
			},
		},
		adminThumbnail: 'thumbnail',
		mimeTypes: ['image/*'],
	},
	hooks: {
		afterRead: [
			async ({ doc }) => {
				doc.url = `https://sos-ch-gva-2.exo.io/lepitre-public/texts/images/${doc.filename}`;

				Object.keys(doc.sizes).forEach(
					(k) =>
						(doc.sizes[
							k
						].url = `https://sos-ch-gva-2.exo.io/lepitre-public/texts/images/${doc.sizes[k].filename}`)
				);
			},
		],
	},
};

export default TextImages;

Not quite correct:
Payload does adjust the base image a bit.
https://github.com/payloadcms/payload/blob/0d8d7f358d390184f6f888d77858b4a145e94214/src/uploads/generateFileData.ts#L88-L105
Moreover, you can pass formatOptions for each size, which could lead to a mimeType change of the size image. Therefore, it is not recommended to use the mime type of the original:
https://github.com/jeanbmar/payload-s3-upload/blob/3e0417cfd871bfe00d742ae3cd79997efe17c261/src/buildUploadHook.ts#L30-L34
The result is not included in req.payloadUploadSizes, it contains only the separate sizes.
https://github.com/payloadcms/payload/blob/0d8d7f358d390184f6f888d77858b4a145e94214/src/uploads/generateFileData.ts#L156
Maybe the data object could give a general idea about the content contained in the edited file.
https://github.com/jeanbmar/payload-s3-upload/blob/3e0417cfd871bfe00d742ae3cd79997efe17c261/src/buildUploadHook.ts#L11-L14

I was talking about the cloud storage plugin of Payload, sorry if it was misleading.
The problem I see is that the fileBuffer created at https://github.com/payloadcms/payload/blob/0d8d7f358d390184f6f888d77858b4a145e94214/src/uploads/generateFileData.ts#L115 isn't attached to the object that is returned later.
As a result plugins can't access the transformed image buffer. It's a bug from Payload imo, I see no reason not to pass the transformed buffer to the plugin chain.
For sure we don't want to duplicate the image transformation logic in a s3 storage plugin.

I'm wrong Payload does pass the transformed image buffer downstream.

I think payload does not expose the result file buffer directly, it is included in someway, but not correctly referenced.
Line 33 ignores the mime type of the created file size completely
I think req.files?.file ?? req.file contains the original file. And the transformed is included in data.files.
But if data is just the upload config, then req.files should be type of array. If req contains this result object:
{ data: newData, files: filesToSave }
I'm not quite sure what payload is exactly giving to the plugins. I'm just trying to give an initial idea of what could be the cause.


Swiper becomes empty when only has one swipe item

Which OS ?
iOS
Version
Which versions are you using:

react-native-swiper v1.5.6
react-native v0.49

Expected behaviour
A single item is rendered
Actual behaviour
Swiper is blank
How to reproduce it>

    <Swiper
      horizontal={false}
      loop={false}
      showsPagination={false}>

      <CardProfession
        style={{margin: "5%"}}
        onChangeSelection={(id) => {
          this.setState({profession:id})
        }}
        onContinue={()=>{
          this._initializeResume()
        }}
      />

    </Swiper>

If there's only one item in the swiper as above, the swiper is blank after rendering. I have tried to debug with element inspector and there's only an empty ScrollView. if I add a {null} after CardProfession, it will be rendered only after a click on the screen

Found a solution: https://github.com/react-community/react-navigation/issues/1572


adding lb #104

Description
adding lb support
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #104
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[x] Created/updated tests
[x] Unit tests passing

Codecov Report

Merging #114 (5698905) into main (787551d) will decrease coverage by 0.02%.
The diff coverage is 45.65%.

@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
- Coverage   45.98%   45.97%   -0.02%
==========================================
  Files          50       52       +2
  Lines        2464     2556      +92
==========================================
+ Hits         1133     1175      +42
- Misses       1323     1371      +48
- Partials        8       10       +2

Impacted Files
Coverage Δ

internal/scanners/lb/lb.go
0.00% <0.00%> (ø)

internal/scanners/vwan/vwan.go
0.00% <ø> (ø)

internal/scanners/lb/rules.go
80.76% <80.76%> (ø)