SHT4X sensor driver

Hello,
I am relatively new contributor, and I am looking to add support for the SHT4X temperature and humidity sensor. I have a branch that is a work in progress here: https://github.com/linguini1/nuttx/tree/sht41-sensor
I have been able to accomplish most of the driver by looking at the SHT21 and SHT3X drivers made before, which are similar. Most of the i2c logic I have already tested previously on another platform, but I would like to now test on a NuttX build to make sure that all parts of the driver work correctly.
I am struggling to register the driver properly. I have found where the SHT3X was registered on an ESP32 board on the code base, as well as this article: https://www.embeddedrelated.com/showarticle/1668.php
I have tried adding the registration logic to the rp2040_common_bringup() but receive a linker error that my sht4x_register function cannot be found, despite the inclusion of the correct headers.
This also leads me to another question; is there a way to dynamically load these drivers, or must the drivers always be started in the board initialization logic by pre-configuring which sensor drivers to include?

Hi @linguini1!
First of all: the code looks beautiful, understandable and nicely commented, thanks for this.
Also thank you for your motivation and welcome to the NuttX community!
I know that your fork is work-in-progress, but I tried to figure out what is wrong to help you.
During this "review" I have noticed a few things that you are probably not aware of...
These are just suggestions, but they may improve the usability of this driver. :)
1.) Temperature range:
The sensor is capable of measuring temperatures between -40 C and +125 C with a resolution of 0.01 C and an accuracy of 0.1 C (SHT45).
Your choice to store the results in an int16_t represented as mC or mF limits the theoretical measurement range to: -32.768 C ... +32.767 C in Celsius mode and to -35.98 C ... 0.43 C in Fahrenheit mode. This means that in Fahrenheit mode this driver will barely be able to measure any temperature above the freezing point of water (which is fairly suboptimal for many users).
2.) sht4x_calc_temp():
There are massive integer overflows/underflows for huge ranges of valid input values (input values: raw measurement data points). This is related to 1.), see above.
3.) Humidity range:
The sensor is capable of measuring relative humidity between 0 and 100 with a resolution of 0.01 %RH and an accuracy of 1 %RH (SHT45).
You store the result of the measurement with a resolution of 1% RH, therefore you lose two digits precision.
Hint: The accuracy of the sensor is 1%, so losing two digits from the resolution is not necessarily a problem, it depends on the use case.
4.) sht4x_calc_hum():
hum is an unsigned integer (uint16_t), therefore it can never be < 0. Those values, that are supposed to be < 0 will be mapped to 100 instead of 0 because of an integer overflow/underflow. So your clamped output will look like [ ..., 100, 100, 100, 0, 0, 1, 1, ..., 99, 99, 100, 100, 100, 100 ...] instead of [ ..., 0, 0, 0, 0, 1, 1, ..., 99, 99, 100, 100, 100, 100 ...] (note the wrongly mapped values below zero).
5.) sht4x_register():
This may (or may not) answer your original question, I didn't verify, just looked at your code briefly. You declare the function in include/nuttx/sensors/sht4x.h, but you do not define it anywhere, or at least I haven't found it in the fork you've linked. There is a function named sht21_register() though (defined in drivers/sensors/sht4x.c), I guess it's a typo or copy-paste error.
If this was the problem, feel free to close this issue.
Greetings,
David
p.s.: The second question (dynamically loading drivers) is not answered by this post, so feel free to comment, thank you!

Thank you for the kind words and great suggestions @davidgnx!
1), 2), 3) You're correct, I didn't consider the integer precisions. I was porting this from another system where I had previously used floats, but wanted integers to be easier for less powerful hardware. Lots of good considerations that I will take into account, thank you!

You're very correct, that was not intended. Thanks for the catch!

It seems I did forget to rename the register function... never develop late at night I guess!

I will keep this issue open just a little longer to see if there is any information about dynamically registering drivers, if that's alright. Thanks for your help!

Nice work @linguini1 !!!
Suggestion: run the checkpatch to catch the coding style issues:
$ ./tools/checkpatch.sh -f drivers/sensors/sht4x.c

You can find about our Coding style here: https://nuttx.apache.org/docs/latest/contributing/coding_style.html
If you decide to create a blog post talking about your first experience creating a driver for NuttX, please share it on our Reddit: https://www.reddit.com/r/nuttx/

Oh yes, I'm sure my work so far violates all the style rules. Saving my formatting until the end. I will be sure to make a post!


Add readstat and pyreadstat

Description of changes
This adds the readstat and pyreadstat packages allowing users to read SAS, SPSS and Stata data files from within Python.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1213

@SuperSandro2000 Thanks for the feedback.  I've gone ahead and made the changes.


Replace Travis with GitHub Actions

PR to remove Travis: https://github.com/bbc/RadioVisDemo/pull/21

Resolved in 503183d3f2b2eb3211128c8436e4746746af95b3.


Listen to only to one person in one specific groupchat

Hello. Simple question. I'm new to JS and the docs are pretty confusing to me. Sorry if I'm asking for spoonfeeding

nevermind, i figured it out, but i have a problem... #874


Add testcase for checking that loading a random kernel module works in a container

Connects to #1

LGTM - Merged!


Added one negative test for misuse of only keyword; added 2 example files for string constraints.

removed the string test logic so I'll close this one and create a new pull request.


Sized Box from number instead of double

Change target of Size[d]BoxExtension from double to num to include also integers.
Also need to cast this while creating the Widget to this as double.
This is currently not possible:  15.heightBox

@PAException
Thanks for suggestions.
I will add it, in next release

@PAException
Please check with latest version.

@PAException
Please check with latest version.

If it's possible?

Yes, now its works with double as well as num.
Just use latest version.

Yes, it is no possible, thanks!

@PAException lets me know if any issues, otherwise closing this issue.


refactor: strpos call converted to str_starts_with

Q
A

Is bugfix?
❌

New feature?
❌

Breaks BC?
❌

Can't use it: https://github.com/yiisoft/network-utilities/blob/master/composer.json#L21


Another small refactoring

Purpose
so lazy...
Related Information

[ ] Design document: ...
[ ] Bench PR: ...

Testing

[ ] This change is a trivial rework or code cleanup without any test coverage.
[ ] This change is already covered by existing tests.
[ ] This PR adds tests that were used to verify all changes.
[ ] There are tests in an external testing repository: ...

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

140 of 143 (97.9%)  changed or added relevant lines in 21 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.3%) to 99.737%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

include/yaclib/async/detail/future_impl.hpp
34
37
91.89%

Totals

Change from base Build<PHONE_NUMBER>:
-0.3%

Covered Lines:
1137

Relevant Lines:
1140

💛  - Coveralls


reduce image and pdf size

we should try to reduce PDF size by trimming the size of images (this would also help with load times online).
This should be doable regularly using some github action

For example

https://github.com/emareg/compressPDF
https://github.com/amaurypm/reducePDF
https://github.com/petems/image-resizer-gh-action

Since this repo is open and we can use  Imgbot, it is a friendly robot that optimizes your images and saves you time. Optimized images mean smaller file sizes without sacrificing quality. https://github.com/marketplace/imgbot/plan/MLP_kgDNGw8#pricing-and-setup

Yeah that looks good and looks like it would be free in open source repo

Installed that plugin now 👌

annoyingly - the plugin does not seem to work.


New Design with createComponent extension point

Signed-off-by: Owais Kazi<EMAIL_ADDRESS>Description
Part of https://github.com/opensearch-project/OpenSearch/issues/2981
Also, resolves https://github.com/opensearch-project/opensearch-sdk/issues/6
Note: Build will fail as this PR has dependency on https://github.com/opensearch-project/OpenSearch/pull/3265.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

WIth adding API support for createComponent, can you add unit tests ?

Abstracted into APIs. Will add tests together as a part of https://github.com/opensearch-project/opensearch-sdk/issues/25

Thanks for taking care of the comments. Looks like CI is failing, like due to change not merged to feature/extensions branch on OpenSearch?

Yes. Build will fail as this PR has dependency on https://github.com/opensearch-project/OpenSearch/pull/3265.


add wipeOutWorkspace in testJobTemplate

Issue: https://github.com/adoptium/aqa-tests/issues/4075

@llxia - re: your question at https://github.com/adoptium/aqa-tests/issues/4075#issuecomment-1288981919 - the issue is referring to AQA_Test_Pipeline, not Jenkinsfilebase or openjdk_tests code.


[NDTensors] [ENHANCEMENT] Add fallbacks for when LAPACK SVD fails

Description
Add fallbacks for when LAPACK SVD fails. For example, if the "divide_and_conquer" (LAPACK's gesdd) algorithm fails, it falls back to "qr_iteration" (LAPACK's gesvd), and if that fails it falls back to "recursive" (ITensor's custom SVD that recursively performs eigendcompositions to get U and QRs to get V).

Codecov Report

Merging #885 (152ad00) into main (274b19f) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #885      +/-   ##
==========================================
- Coverage   75.87%   75.86%   -0.02%
==========================================
  Files          75       75
  Lines        7984     7984
==========================================
- Hits         6058     6057       -1
- Misses       1926     1927       +1

Impacted Files
Coverage Δ

src/decomp.jl
91.37% <0.00%> (-0.44%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6d4254...152ad00. Read the comment docs.


New package request

Hi,
Thank you very much for your very useful work.
In your packages, can you also include CSS Image Sprites, preferably in SVG?
Here is an example that has done this https://github.com/webdesigniran/IranianBankLogos
(they are in low resolution PNG and does not include all banks and are not up-to-date with the recent changes.)
Best,

Thanks. It's a good idea and I'll add it to the library very soon. Thanks :)


CE labels always zero?

Hi!
I was looking through the training code and found this a bit strange: https://github.com/DI4IR/SIGIR2021/blob/main/src/training/data_reader.py#L41
Labels are initialized to 0 but are never changed during training. Shouldn't they be 1 for positive pairs and 0 for negative pairs?
Thanks!

Hi @alexandres, thanks for asking.
The training input is a triplet in the form of query, relevant, non_relevant, so two scores are produced (one for the query-relevant and one for the query-non_relevant). The label indicates the position of the relevant document, which is always 0 since the relevant document comes always first.
Let me know if I can help more.


Release notes linked in Insider build goes to VS Code

Issue Type: Bug
Ran Check For Updates on 1.5.1 insider build.
When the notification dialog popped up, I clicked "Release Notes"

The page that is presented appears to be the September 2016 notes for VS Code

Azure Data Studio version: azuredatastudio 1.5.1-insider (6d7d485a3840daf2da335b0cf527f98373ce29e6, 2019-03-19T07:23:34.608Z)
OS version: Windows_NT x64 10.0.17763

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz (12 x 2208)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
31.82GB (17.28GB free)

Process Argv

Screen Reader
no

VM
0%

I was able to repro this.

Edited this since it repros in Stable. Will work on changing this.


How do I generate the newest iTunes metadata with Fastlane?

Hello guys. Sorry for asking here, but I have asked in a couple of places (the iOS Developers slack group, Reddit), and never receive any answers to this question.
I created an app a few months ago for iOS 10 and submitted it to iTunes. This was before WWDC, so the new metadata requirements did not exist.
What command do I have to run to make Fastlane generate the newest required metadata files for my project?

Hey @AndyIbanez, thanks for submitting this issue. You can use the following command
fastlane deliver download_metadata

Warning: This will overwrite your local metadata with whatever you have on iTunes Connect

Thanks @KrauseFx, I will give it a go now.


builder: bind mount qemu-aarch64-static when building

This change allows building of ARMv8 images without having to embed the QEMU binary in the image itself

Can you add a changelog entry please

SGTM


iPhone cannot open uncover application and apps will not download or delete

Describe the bug
A clear and concise description of what the bug is and what you expected to happen.
My iphone is a Xs and is jailbroken on a 12.4 jailbreak on the 3.7.0.b1 version of uncover. About 2 weeks ago my device ran out of battery, but when I recharged it the uncover application was not able to open and said that the certificate was revoked. I deleted the profile off my phone and thought that I could just use cydia impactor to get uncover to work that way. This was not the case because it registered that the profile was still on my phone. I tried deleting the uncover application, but the application will not go away. This is the case with all apps. I cannot delete, install, or update apps on my phone.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Screenshots
If applicable, add screenshots to help explain your problem.
Device (please complete the following information):

iOS Version: 12.4
iOS Device: Xs
unc0ver Version: 3.7.0.b1

Place an "x" between the brackets if true:

[ ] this is a bug others will be able to reproduce
[ ] this issue is present with all tweaks uninstalled(except for default packages) or disabled
[ ] this issue is present after a rootfs restore
[ ] this issue is present on the latest version of unc0ver

Logs
If applicable, add logs or error messages here.

First make sure you are using the updated version of impactor. Next , you should be using unc0ver Version: 3.7.0.b2. Its the best version for A12 devices.  OK now you need to turn on impactor and click the xcode tab at the top right.  Select revoke certificate.  It should go through its thing and say 1 certificate deleted or something to that effect.  Next do a hard reset on your phone. (volume up, vulome down, hold power button till you see the screen go black, then release.) At this point you should either, Not see the profile in the profiles section, or you should have the ability to delete it or the app.  Next, Load unc0ver Version: 3.7.0.b2 with impactor and you should be golden.

I just tried it, but it didn’t really do anything. Impactor said that 1 certificate was revoked, so I did a hard reset. I tried to delete the uncover app by pressing the delete button, but nothing changed.

I’ve also noticed that my messages have been buggy. I opened the message app and all I got was a white screen. So I have to fix this by hard resetting. It just keeps happening every so often.

At this point.  Have you tried adding unc0ver through impactor without trying to delete the old one first?

Lets see if just trying to add unc0ver Version: 3.7.0.b2 through impactor will work first.  The randomness almost sounds like a battery that's at its end.

Just tried it and it says that there is already a certificate for it.

Delete the old certificate or use a different apple ID for impactor.

That’s the thing, I’ve already “deleted” the certificate. I went into my settings when I first found the issue and deleted the certificate, but impactor still registers it as being there.

Use a differant apple id to sign impactor

I've tried using different a different apple id, but it always says "application already installed as incompatible team"

open settings, general, and scroll down to profiles and device management. What do you see?   a screenshot would be awesome.

So. I have an issue similar but different. I have the uncover JB running v 3.0.7b1 on iPhone 10xr 12.4
Yesterday I my Uncover app stopped working. I deleted it without deleting the profile and tried to reinstall it but now it’s dessert and one open and I don’t see any profiles to delete. What can I do do I just have to restore my phone and lose my ability to jailbreak.?

Sorry uncover 3.7.0 b3 is my version

impactor is still not working.  you will need to redownload uncover from a website. once you jailbreak, use reprovision and you wont have to deal with this problem anymore.


Regarding tool

Hi bro how are you this my advice for you. Your repo Devil-s-Call and so on... Was not originally created by you...You have stolen the script from speedx/TBomb and used in your script by mentioning as if you were the author of script.If you copy some ones script give credits ok good bye

Hi bro how are you this my advice for you. Your repo Devil-s-Call and so on... Was not originally created by you...You have stolen the script from speedx/TBomb and used in your script by mentioning as if you were the author of script.If you copy some ones script give credits ok good bye

OK bro I accept you advice
But I am not a programmer, I am just beginner and I am doing this for my time-pass in this quarantine.
I didn't steal scripts, I just took the method of sms generation(algorithm), most of the sms bomber like speedX, TBomb, bombitup app are using same method.
In github most of the people are just copying other scripts, copying is not a wrong thing.
Infact I don't know about python, when I start to see others scripts I understand learn python.
The best way to learn any programming language is reading others scripts and checking how it's works
Anyway thanks for your advice bro ✌


Codemirror version

I think markdown-editor is not working with current versions of Codemirror. I tested with 3.11 and 3.16 and the editor is totally broken, is there any plan to update to a more recent version of Codemirror ?
Thanks

Wow I've been terrible at maintaining this and replying to issues. I've bumped the codemirror version all the way to latest now and fixed the various api change issues that were breaking it.
In other news, at some point I am planning on completely swapping out codemirror for a completely different editor which is much less quirky with various bits of markdown syntax


how using scroll and range query work together

Please use the following questions as a guideline to help me answer
your issue/question without further inquiry. Thank you.
Which version of Elastic are you using?
[ ] elastic.v6 (for Elasticsearch 6.x)
Please describe the expected behavior
i want to using scroll api to query data from es in batches, the es query handle include range query also，
but result.Hits.TotalHits value is eq to value which query  not include range query.
my query logic like as described above.
Please describe the actual behavior
tmStampQuery := elastic.NewRangeQuery("timestamp")
tmStampQuery.Gte(*beginTime)
tmStampQuery.Lt(*endTime)
   //just is range query

filterQury := elastic.NewBoolQuery().Filter(tmStampQuery)  //is bool query include range

includeField := []string{"locate"}
excludeField := []string{}

fieldVal := &elastic.FetchSourceContext{}
fieldVal.SetFetchSource(true)
fieldVal.Include(includeField...)
fieldVal.Exclude(excludeField...)

result, err := esClient.Scroll().  //use scroll to query
	Index(indexName).
	Type(typeName).
	Query(filterQury ).
	SearchSource(elastic.NewSearchSource().FetchSourceContext(fieldVal)).
	Size(10000).
	Do(context.Background()) {

}
Any steps to reproduce the behavior?

my query body json like this
GET /test_index/_search
{
"query": {
"bool": {
"filter": [
{
"range": {
"timestamp": {
"gte": "2019-11-01T00:00:00.0778218+08:00",
"time_zone": "+08:00",
"lte": "2019-11-01T07:48:50.1132008+08:00"
}
}
}
]
}
},
"_source": {
"include": [
"locate",
"timestamp"
]
}
}

If you're using SearchSource, you must specify all parameters like Query with it as well. In other words: If you're using SearchSource, you specify the whole body with it.

Could you give some example for this. if  i  not use searchsource, the scroll and rangeq can work together, the scroll result is value which is ranged by queried by condition?

In your case, you simply need to put the Query(...) into the search source, not mix both Query and SearchSource.
Here are a lot of examples of how to setup search source.

ye,i try do like this:
includeField := []string{"locate","timestamp"}
excludeField := []string{}
fieldVal := &elastic.FetchSourceContext{}
fieldVal.SetFetchSource(true)
fieldVal.Include(includeField...).Exclude(excludeField...)

tmStampQuery := elastic.NewRangeQuery("timestamp").Gte(beginTime).Lt(endTime).TimeZone("+08:00")
rangeQuery:= elastic.NewBoolQuery().Filter(tmStampQuery)

result, err := esClient.Scroll().
	Index(*indexName).
	Type(*typeName).
	SearchSource(elastic.NewSearchSource().Query(rangeQuery).FetchSourceContext(fieldVal)).
	Size(size).
	Do(context.Background()){}

this solution is valid, thanks for your help.


Update pinned requirements?

Howdy,
Can you update your requirements similar to what theblackturtle did in their fork? https://github.com/theblackturtle/whatportis
Pip installing whatportis with other packages in an environment will tend to install the 0.8 version (as Pip tries to satisfy the older requirements specified in the whatportis setup.py).
Thanks.

Hi,
I don't understand what you mean by saying "update your requirements similar to what theblackturtle did". I just checked the setup.py of his fork and he uses >= instead of ==. This is not a good practice, so I will not do it.
Plus you say installing whatportis with other packages in an environment, again this is not a good practice. I recommend you to install your Python packages in virtual environments, so you will avoid the kind of conflicts you're talking about.


App crashes when you do back to library from settings

Steps to reproduce
Open app ,
Press update
Go to settings/downloads/more/sources/updates/sources search
Press back button
Crash
https://github.com/user-attachments/assets/12864ab9-d159-4345-8afe-66331d49f5a8
Expected behavior
Go back to back
Actual behavior
Crashes
Crash logs
mihon_crash_logs.txt

Mihon version
0.16.5
Android version
14
Device
Redmi note 13 pro (12gb MediaTek g99 ultra)
Other details
Did ask around in the discord Support and they recommended me to post a issue report on github
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version 0.16.5.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

Same Crash when I tried the latest Mihon Beta app (on the recommendation of discord support staff)

This seems like a OS level crash. Can you check if there are android updates and what not?

This seems like a OS level crash. Can you check if there are android updates and what not?

There aren't any android or OS official updates for my device at the moment .

Closing in favor of #1278


Continuous Order Number

For accounting reasons we need a continuous order number for each sale, that we can use in invoices.
We'll still keep the UUID for each order (since it's useful for linking to the order when handling anonymous orders), but introduce and incrementing field as well.

Should only be set when the payment goes through

Allow searching by this order number as well.

Fixed in #86

While going through the code I noticed this can still happen.
E.g. when a transaction is failing, the invoice number is increased anyways.
https://github.com/netlify/gocommerce/blob/master/api/payments.go#L159-L177
	invoiceNumber, err := models.NextInvoiceNumber(tx, order.InstanceID)
	if err != nil {
		tx.Rollback()
		return internalServerError("We failed to generate a valid invoice ID, please try again later: %v", err)
	}

	tr := models.NewTransaction(order)
	processorID, err := charge(params.Amount, params.Currency, order, invoiceNumber)
	tr.ProcessorID = processorID
	tr.InvoiceNumber = invoiceNumber

	if err != nil {
		tr.FailureCode = strconv.FormatInt(http.StatusInternalServerError, 10)
		tr.FailureDescription = err.Error()
		tr.Status = models.FailedState
		tx.Create(tr)
		tx.Commit()
		return internalServerError("There was an error charging your card: %v", err).WithInternalError(err)
	}

The error case should rollback the invoice id. And the transaction should probably not get one if failed.

Fixed by #182


How do I setup superset on google app engine

Make sure these boxes are checked before submitting your issue - thank you!

[ X] I have checked the superset logs for python stacktraces and included it here as text if any
[ ] I have reproduced the issue with at least the latest released version of superset
[ ] I have checked the issue tracker for the same issue and I haven't found one similar

Superset version
Any
Expected results
Setup app engine on google engine
Actual results
Steps to reproduce

can you please open it up. It's still a real quetion.

@jeffrey-d-lipkowitz I had the same wish... And I ended up creating a guide on how to deploy Superset to App Engine.
https://medium.com/@feroult/serverless-superset-on-google-cloud-87d3cf324845


doc: update AV.Push.send API doc

Related ticket: https://leanticket.cn/t/leancloud/4430

Codecov Report

Merging #467 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #467   +/-   ##
=======================================
  Coverage   66.56%   66.56%
=======================================
  Files          32       32
  Lines        2728     2728
=======================================
  Hits         1816     1816
  Misses        912      912

Impacted Files
Coverage Δ

src/push.js
29.41% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcc42aa...8dc27b1. Read the comment docs.

https://url.leanapp.cn/pushData

Edge 下不能正确跳转： https://leancloud.cn/docs/push_guide.html#æ¶ˆæ¯å†…å®¹_Data


add support for "export * as"

foo.ts:
export const a = 1
export const b = 2

bar.ts:
// error!
export * as foo from './foo'

// ok
import * as foo1 from './foo'
export const foo = foo1

duplicate of #4813


serverMiddleware not being triggered by asyncData when SSR

Version
v2.10.0
Reproduction link
https://github.com/colwilson/bug-report-nuxt-ssr-1
Steps to reproduce

nuxt.config.js

  serverMiddleware: [{
    path: '/api',
    handler: '@/serverMiddleware/api'
  }],

serverMiddleware/api.js

export default function (req, res, next) {
  console.log(req.path)
  const data = {
    data: 'data'
  }
  res.setHeader("Content-Type", "application/json")
  res.end(JSON.stringify(data))
  next()
}

pages/index.vue

<template>
  <div class="index">
    index
  </div>
</template>

<script>
export default {
  name: 'index',
  async asyncData({ params, env, $axios }) {
    console.log("client?", process.client)
    const url = '/api'
    try {
      const response = await $axios.get(url);
      const data = response.data
      return {
        data
      };
    } catch (error) {
      console.log(error.message);
    }
  }
}
</script>

What is expected ?
On loading the page for first time or hitting F5 the url path should appear in the console.
What is actually happening?
console displays "Request failed with status code 503 "
Additional comments?
I can't believe I can be the only one seeing this so I assume my code is incorrect, but I have tried for a day to get it to work without success.

This bug report is available on Nuxt community (#c10025)

Updated your example a little: https://codesandbox.io/s/bug-report-nuxt-ssr-1-6uqzp
Works fine on server side but not on the client side because you did not define your axios base URL. On client side, it still tries to access localhost:3000 as shown below.
Not a Nuxt bug -> closing here.


Fix TextBox panic due to selection going off-bounds on data string

@futurepaul let me know if this is the right fix and in the right place.

[x] Should we replace all usages of s.len() with s.chars().count()? No!

What's the bug here? It might be worth including a test case.
In any case, we don't want to use chars().count(), which will return the number of unicode scalars in the string; we should be representing selections as utf-8 byte indexes.
It should be an invariant that the selection always describes a valid range in the string, and we should be validating that when the selection is changed.

Added a test that panics without the fix.
I am not sure if I am fixing it in the right place. Alternatively, we can check if selection is out of bounds in the update method.
It would be nice to have some kind of integration test setup. I would like to simulate sending events to the widget. Currently, I couldn't find a way.

Ah cool I understand what was happening now. My personal feeling is that update is the right place to handle this, but i'd be curious for @raphlinus's opinion. I also think the logic should be pretty simple; if the text changes externally we should reset the selection state, moving the cursor to the end of the text. We could maybe special-case if the cursor is currently at 0, and keep it there; but if the selection state is any more complicated then we can end up with a weird selection that we probably don't want.
I agree that we will want some better ways to test at some point.

I don't think we currently have a way of knowing if data was mutated externally or internally. So in update we won't know if data has changed outside the widget.

Right, that makes sense, and this seems like a good solution for now. Thanks!


CassandraSchemaManager.java has hard coded port to initialize the client

CassandraSchemaManager.java line#671 method: initiateClient(). This is causing connection refused. Should this code use the port passed in, rather than hard coding ?
if (host == null || !StringUtils.isNumeric(port) || port.isEmpty())
{
log.error("Host or port should not be null, Port should be numeric.");
throw new IllegalArgumentException("Host or port should not be null, Port should be numeric.");
}
TSocket socket = new TSocket(host, Integer.parseInt("9160"));

@amolc24
We have fixed the code and pushed it to the trunk. You can build the code from trunk for changes to be effective.
-Karthik

Thanks Karthik. Any idea when would that fix be available on maven repository?

@amolc24
The fix will be available with the next release, which is scheduled on 11th of September.
-Karthik

@amolc24
In order to create schema using kundera-cassandra DSClient , you will need to specify the thrift (rpc_port) port over which it can connect with Cassandra :
You can do the same by setting :
  Map<String, Object> puPropertiesObj = new HashMap<String, Object>();
  puPropertiesObj.put(CassandraConstants.THRIFT_PORT, "9160");
  emf = Persistence.createEntityManagerFactory("ds_pu",puPropertiesObj);

If you do not specify this property while creating schema then default port 9160 will be picked as its thrift port in case DSClient and "kudera.port" property's value for Casssandra's  core client. Please find the test case below for your reference:
https://github.com/impetus-opensource/Kundera/blob/2503ad37db60abe195973d6c418ba186e702e74d/src/kundera-cassandra/cassandra-ds-driver/src/test/java/com/impetus/client/cassandra/crud/compositeType/association/CassandraUserOTMTest.java
Chhavi


Kivy with Python 3 and Twisted 16.1.1 fails

[INFO   ] [Kivy        ] v1.9.2-dev0
[INFO   ] [Python      ] v3.5.1 (default, Mar  3 2016, 09:29:07)
[GCC 5.3.0]
[INFO   ] [Factory     ] 193 symbols loaded
[INFO   ] [Image       ] Providers: img_tex, img_dds, img_gif, img_sdl2, img_pil (img_ffpyplayer ignored)
[INFO   ] [Text        ] Provider: sdl2
 Traceback (most recent call last):
   File "hiqontrol/main.py", line 32, in <module>
     install_twisted_reactor()
   File "/usr/lib/python3.5/site-packages/kivy/support.py", line 175, in install_twisted_reactor
     from twisted.internet import _threadedselect
 ImportError: cannot import name '_threadedselect'

There have been some discussions about that on https://stackoverflow.com/questions/33180667/contributing-to-unmaintained-reactor-in-twisted-or-maintain-separate-implementat
But _threadedselect seem to have been removed from Twisted 16 when running Python 3. Python 2 seem to be fine (for now).

The stackoverflow link is my question. I gave up on using _threadedselect (editing it was trivial, really), but not because the reactor didn't work, rather the protocol I was building round (AMP) wasn't ported yet.
https://twistedmatrix.com/trac/ticket/6833 indicates that that is no longer the case since Dec 2015, and https://twistedmatrix.com/trac/ticket/8205 seems to indicate that _threadedselect is on its way as well. Overall the twisted team has been progressing at a good clip, really.
For a new project starting today (and looking at twisted+kivy with AMP) I would use python3. No idea about other protocols. However my project is already python2 and I can't really justify switching until I have some free weeks to hunt for everything which needs conversion (project deals with strings extensively, so that won't be fun).

I have also ran into this problem. Any workaround available? I am not averse to using asyncio if its possible.

The issue should be fixed with the latest development version of Kivy and Twisted.


Add typescript declarations

Add typescript declarations, close #4

@jrgarciadev any update on this? can we merge these typings to the project.

hi @soniabhishek I'm working on it

Any update on this?


Accept custom autocomplete_url if provided

Q
A

Bug fix?
yes

New feature?
no

Tickets
N/A

License
MIT

I noticed that passing autocomplete_url has no impact - the data-symfony--ux-autocomplete--autocomplete-url-value attribute always leads to the ux_entity_autocomplete path based on the autocompleter alias.
Setting the alias via #[AsEntityAutocompleteField(alias: 'alias')] fixes the consequence of the problem, but the root cause is that the autocomplete_url option appears to be ignored by ParentEntityAutocompleteType::buildForm().
This PR fixes it.

I'd like to ignore the failing check, I highly doubt it's caused by my proposed change.

Correction, #[AsEntityAutocompleteField(alias: 'alias')] doesn't actually fix the problem, it just makes the autocompleter fail silently - well, it doesn't fail per se, but the autocompleter can return incorrect results, if you're using a custom autocompleter. It's likely that it's a thing for another bug report or PR, but let's bring it up here to talk about:
I'm using a custom Form Type:

#[AsEntityAutocompleteField]
class SiteAutocompleterType extends AbstractType
{
    public function __construct(private readonly UrlGeneratorInterface $urlGenerator)
    {
    }

    public function configureOptions(OptionsResolver $resolver)
    {
        $resolver->setDefaults([
            'class' => Site::class,
            // I thought I would not have to provide the URL here, but when #[AsEntityAutocompleteField] has no alias, it's using the form type alias as a default, which leads to an incorrect URL in the end.
            'autocomplete_url' => $this->urlGenerator->generate('ux_entity_autocomplete', ['alias' => 'site']),
            'choice_label' => fn (Site $site) => $site.' '.($site->getParent() ?: 'Root').' / '.$site->getOrganisation(),
        ]);
    }

    public function getParent(): string
    {
        return ParentEntityAutocompleteType::class;
    }
}

And with it, I'm using a custom autocompleter:
#[AutoconfigureTag(name: 'ux.entity_autocompleter', attributes: ['alias' => 'site'])]
class SiteAutocompleter implements EntityAutocompleterInterface
{
    public function __construct(
        private readonly SiteRepository $siteRepository,
        private readonly OrganisationService $organisationService,
    ) {
        // Void
    }

    public function getEntityClass(): string
    {
        return Site::class;
    }

    /** @param SiteRepository $repository */
    public function createFilteredQueryBuilder(EntityRepository $repository, string $query): QueryBuilder
    {
        $iqb = $this->siteRepository->getOrganisationAwareInteractiveQueryBuilder()
            ->searchFor($query)
        ;

        return $iqb->build();
    }

    /** @param Site $entity */
    public function getLabel(object $entity): string
    {
        return (string) $entity;
    }

    /** @param Site $entity */
    public function getValue(object $entity): string
    {
        return $entity->getId();
    }

    public function isGranted(Security $security): bool
    {
        // Redundant, because the organisation is guaranteed to be readable if it is set as active
        return $security->isGranted(OrganisationVoter::READ, $this->organisationService->getActiveOrganisation());
    }
}

This creates an endpoint /autocomplete/site, which works as expected. However, when the #[AsEntityAutocompleteField] has the alias value, it takes precedence, and the query builder defined in SiteAutocompleterType is used, instead of my SiteAutocompleter class.
Does this sound like a bug, or am I using it wrong. It's experimental, so let's experiment!
Also, to add more complexity to this comment, I don't think the EntityAutocompleterInterface approach is flexible enough. In public function createFilteredQueryBuilder(EntityRepository $repository, string $query): QueryBuilder, the $query itself is not sufficient data input - for example, if I had a nested structure of Site entities, and wanted to only search among child entities of a particular site, having name matching the $query - how would I pass on the ID of the parent site?
I'm not a big fan of the Autocompleter URL magic the way it is done now. Adding a completely custom controller action that serves a key/value json result is almost simpler than, or as simple as adding a dedicated magical autocomplete result loader, but the custom autocompleter action has significantly more flexibility.
This feat being experimental, if my vote has any weight at all, I would call the magical autoloader feature unnecessary. Either way, I love the direction of all of the Symfony UX initiative.

Hi @janklan!
Thanks for bringing up this situation :). So, if I understand it correctly, your (initial) goal is pretty simple: create an autocomplete, but one that uses your custom SiteAutocompleter instead of the "built-in" one. And, the problem is that, even when you correctly create SiteAutocompleter, the "built-in" system (the one powered by the #[AsEntityAutocompleteField]) takes precedence. Is that correct?
If so, is the solution as simple as:
A) removing #[AsEntityAutocompleteField] from your code
B) skipping the check (and error) for this attribute if the autocomplete_url is provided https://github.com/symfony/ux/blob/8e84d49a92b70f99001b8817cd3129a6215175f6/src/Autocomplete/src/Form/ParentEntityAutocompleteType.php#L38-L40
If I remember correctly, the purpose of the #[AsEntityAutocompleteField] is to (1) help generate the URL (since it uses the alias) and (2) to effectively create a service tagged with ux.entity_autocompleter with an alias matching what's on the attribute. So, if you're creating a custom autocompleter, the attribute should not be needed at all.
If I'm correct, then you just need a small tweak to the PR to get (B) working. Then, the documentation needs some help in the "custom autocompleter" section to explain that, if you're using with a form, you should remove that attribute and generate the autocomplete_url manually. That section was originally written with the use-case of creating an autocomplete endpoint without the form system. But what you're trying to do is valid.

If my vote has any weight at all, I would call the magical autoloader feature unnecessary. Either way, I love the direction of all of the Symfony UX initiative.

For most use-cases, the magic auto-complete endpoint works great. What's nice is that, if it doesn't work for you, no problem! You could override the autocomplete_url entirely to point to your custom route/controller. As long as you return the same JSON structure, then it will work. To put it another way: the autocomplete component is 2 parts: (A) a "frontend" component, including the JS but logic to handle the form data transformations on submit and (B) a "backend" autocomplete endpoint. You can pick and choose what you want. But, it's possible that this alternate mode of using the component could be better-documented.
Cheers!

your (initial) goal is pretty simple: create an autocomplete, but one that uses your custom SiteAutocompleter instead of the "built-in" one.

Close, but not quite: my goal was to create an autocompleter that returns only entities that belong to a certain $organisation, and also match the $query value. In my single-db-multi-tenant application, this happens everywhere, every time. Simple, really. But not really!
I'll try to explain. I created a gist with the related files, I'll be using it below.
For context, I don't pass Doctrine Entities to my forms to avoid broken states and accidental DB updates when something flushes the manager while the entity is half-correct. Instead, I create a DTO, I modify that DTO in a form. When the DTO is guaranteed to be valid (passes validation once the form is submitted etc), I call a static builder method on the Entity's class. This builder method accepts the DTO, and uses the DTO to build the acutal entity. That way I don't need any setters, my Entities are always correct, and thing are neatly under control. Updating works similarly, however the Create and Update DTO often have different properties, and I often use different DTOs for different mutations of the same entity.
The tiny bit of code overhead is negligible comparing to the benefits.
Anyway, my SiteCreateDto carries the Organisation that will own the Site once created. The Organisation is not part of the form itself - I don't want the user to change it, so the controller passes the Organisation object extracted from the current context when when it's creating the form and its DTO.
The SiteCreateType is listening for FormEvents::PRE_SET_DATA, waiting for the DTO to tell the form which Organisation are we working with. This works great when the Autocompleter loads all options eagerly, but falls apart when the async loading comes in the picture:

/autcomplete/whatever-the-alias-is has no direct access to anything else than the $query value.
The magic in the API endpoint is reconstructing the query builder for the autocompleter field identified by its alias.
The magic happens in a separate request, which is unaware of the context the Form lives in, so has no access to the DTO and/or Organisation

This morning I tried to experiment with filter_query to limit the Organisations, expecting it to fail due to the absence of the DTO, but I didn't even get that far, the filter_query seems to be ignored entirely.
I tried to set the query_builder instead of the filter_query, but that didn't work (I didn't dig into why)
I tried to add the organisation as an option of SiteAutocompleterType, but then when I passed the Organisation to the field, it didn't work.
Either way, I think it's all doomed anyway: The $organisation is derived from the current context when the form field is generated, and when the autocompleter request is made, that context is lost and the autocompleter magic has no way to reconstsruct it, so I call all this futile.
My takeaway from all this is the docs should be updated to say "If you need to restrict your search result on any other variable than $query, you go and write your own endpoint.

And, the problem is that, even when you correctly create SiteAutocompleter, the "built-in" system (the one powered by the #[AsEntityAutocompleteField]) takes precedence. Is that correct?

Yeah, that was one of the confusing momen - there are two auto-generated routes, which both of them do something else: one of them is the real built-in autocompleter result finder, and the other one is the one custom one. They are both tagged the same way, so one overwrites the other.

If so, is the solution as simple as:
A) removing #[AsEntityAutocompleteField] from your code B) skipping the check (and error) for this attribute if the autocomplete_url is provided
https://github.com/symfony/ux/blob/8e84d49a92b70f99001b8817cd3129a6215175f6/src/Autocomplete/src/Form/ParentEntityAutocompleteType.php#L38-L40
If I remember correctly, the purpose of the #[AsEntityAutocompleteField] is to (1) help generate the URL (since it uses the alias) and (2) to effectively create a service tagged with ux.entity_autocompleter with an alias matching what's on the attribute. So, if you're creating a custom autocompleter, the attribute should not be needed at all.

100% right mate - it's just not clear that using #[AsEntityAutocompleteField(alias: 'foo')] and #[AutoconfigureTag(name: 'ux.entity_autocompleter', attributes: ['alias' => 'foo'])] class SiteAutocompleter implements EntityAutocompleterInterface are mutually exclusive.

If I'm correct, then you just need a small tweak to the PR to get (B) working. Then, the documentation needs some help in the "custom autocompleter" section to explain that, if you're using with a form, you should remove that attribute and generate the autocomplete_url manually. That section was originally written with the use-case of creating an autocomplete endpoint without the form system. But what you're trying to do is valid.

I agree with the docs update being a valid solution to all of the things I wrote above!

If my vote has any weight at all, I would call the magical autoloader feature unnecessary. Either way, I love the direction of all of the Symfony UX initiative.

For most use-cases, the magic auto-complete endpoint works great. What's nice is that, if it doesn't work for you, no problem! You could override the autocomplete_url entirely to point to your custom route/controller. As long as you return the same JSON structure, then it will work. To put it another way: the autocomplete component is 2 parts: (A) a "frontend" component, including the JS but logic to handle the form data transformations on submit and (B) a "backend" autocomplete endpoint. You can pick and choose what you want. But, it's possible that this alternate mode of using the component could be better-documented.

Yeah point taken, although I'm wondering how common would be the use case where asynchronous autocompleter can work with just the $query value. The way I see it, you'd only need an async autocompleter if you had a ton of data in your table. If you have a ton of data, chances are you need some additional conditions applied to find the correct autocompleter result set.

Anyway, all this discussion is a bit off-topic to the actual PR contents, which in fact fixes an error preventing me from providing a custom autocompleter URL to the standard autocompleter, which is how I landed here anyway.
I'll try to find some tome to push a PR to the docs, but that's going to be another time, another PR.
What do you think of the change I'm proposing?

Either way, I think it's all doomed anyway: The $organisation is derived from the current context when the form field is generated, and when the autocompleter request is made, that context is lost and the autocompleter magic has no way to reconstsruct it, so I call all this futile.

Absolutely - that is indeed the issue. #391 discusses that same general issue.

My takeaway from all this is the docs should be updated to say "If you need to restrict your search result on any other variable than $query, you go and write your own endpoint.

Yes, or we can fix #391. It is not a particularly easy issue - I do have an idea. But if it fails, then absolutely we should document how to simply workaround this by writing your own endpoint, which is not a super difficult thing to do (if you know that you need to do it and have some basic docs).

100% right mate - it's just not clear that using #[AsEntityAutocompleteField(alias: 'foo')] and #[AutoconfigureTag(name: 'ux.entity_autocompleter', attributes: ['alias' => 'foo'])] class SiteAutocompleter implements EntityAutocompleterInterface are mutually exclusive.

Indeed they are mutually exclusive. Using AsEntityAutocompleteField causes that services to be tagged with ENTITY_AUTOCOMPLETE_FIELD_TAG (i.e. ux.entity_autocomplete_field). And THAT, then triggers a new service to be added for you that has the ux.entity_autocompleter tag, using the alis from the AsEntityAutocompleteField attribute: https://github.com/symfony/ux/blob/72cacda29ddd08e088c96aad480fe83bd0749af2/src/Autocomplete/src/DependencyInjection/AutocompleteFormTypePass.php#L40-L55
So, yes, we should update the docs to explain that if you're creating your own EntityAutocompleterInterface, then don't use the AsEntityAutocompleteField at all. Also, can't remember if I mentioned it. the docs should show #[AutoconfigureTag] instead of services.yaml config (that it shows currently): the attribute is much nicer ;)

In conclusion, all this PR needs, I believe, is:
A) In ParentEntityAutocompleteType, the throw new \LogicException(sprintf('The %s class must have a #[AsEntityAutocompleteField] attribute above its class.', \get_class($formType))); should NOT be thrown if autocomplete_url is provided. Otherwise, you'll STILL need to use the AsEntityAutocompleteField attribute.
B) Having a quick update to the docs would be great, but not strictly required.
Thanks!

I'm also running into this issue (trying to provide a custom autocomplete_url) and the additional change suggested by @weaverryan above works for me 👍
@janklan Do you still need support for this feature or shall I open a new PR with the change in it?

I'm also running into this issue (trying to provide a custom autocomplete_url) and the additional change suggested by @weaverryan above works for me 👍
@janklan Do you still need support for this feature or shall I open a new PR with the change in it?

Done, thanks for the ping

Thanks Jan!

I'll try to explain. I created a gist with the related files, I'll be using it below.

Thanks, @janklan for sharing these.  By any chance do you have a repo on github that is a complete working version showing this concept?  I'd like to step through the debugger to understand it better before attempting to integrate it into my own code.  Thx.

I'll try to explain. I created a gist with the related files, I'll be using it below.

Thanks, @janklan for sharing these. By any chance do you have a repo on github that is a complete working version showing this concept? I'd like to step through the debugger to understand it better before attempting to integrate it into my own code. Thx.

Yeah, check out https://github.com/janklan/symfony-ux-playground/tree/dto
By the way, I've been happily using my DTO approach in a few massive applications for 2+ years now. Here is what I'm learning:
Upsides:

All validation assertions are in the DTO classes
My entities never enter any sort of invalid state, so I don't have to worry about flushing or not flushing
I have no setters at all, only getters for things I want to expose
Any entity mutation happens by passing a DTO to a dedicated updater method of that entity
My entities contain insulated logic that concerns their inner state, acting as actual data entities, not just DTOs. Don't confuse it with ActiveRecord. I'm not doing that.
I've got a helper service that's capable of validating and persisting the DTOs on their own -> I don't rely on Form to validate my data, and creating my data fixtures for functional tests is a bliss

Downsides:

Boilerplate code. There are a lot of classes and methods involved - usually 3/4+. The entity, the CreateDto, the UpdateDto and a trait shared by the DTO holding the properties shared by the two DTOs. Mind you this downside is heavily outweighed by all the upsides above
Sometimes, I have a DTO to update a single value. I twitch adding a setter for that case, but then I'd lose all the benefits above and introduce inconsistent behaviour
Nesting DTOs isn't as simple as it sounds regarding the dependency of related entities and handling validation errors. I currently don't support this. Having gone 2 years without it, I'm not convinced it's a real-world problem.

Ultimately, I can't understand why using DTO to modify entities isn't the preferred way of doing things. It's so much more robust.


Wider view / bigger videos

Thank you, first of all, for creating this. I stumbled upon it at the perfect time and use it every second day now.
I'm using the site on desktop and I'm quite new to all these exercises so I heavily rely on the videos for each exercise. Unfortunately the page is quite small for me so the details in the videos are hard to figure out sometimes. It would be great if the videos were resizable or the whole UI was just wider.
I'm on a 32" 4k monitor with 150% UI scaling. This is what the UI looks like on my monitor:

Funding

You can sponsor this specific effort via a Polar.sh pledge below
We receive the pledge once the issue is completed & verified

@Dimension4 hi, we can let's you click on the video and it'll fullscreen. Is it ok?

yeah that would be great!

Hey, that could work yeah. However keep in mind, from a usability point of view, I want to interact as little as possible with the site during my workout (mainly because I'm sweaty and don't want to handle the peripherals). So opening and closing every video might not be ideal.
If another solution is too much effort though, I'll gladly take the click-to-fullscreen solution. Thanks for looking into this.

We could also additionally to the fullscreen make the videos responsive so that they are bigger on desktops by default

Thanks a lot! Saw the changes today in my workout, great work.


Refinement of Geometry Processing in Region Controller

This PR introduces a refinement in the geometry processing logic within the regionController.js file. The new logic avoids unnecessary union operations when there is only one geometry, thereby potentially improving performance.
Closes: #119

@CodeAI-Agent review

@CodiumAI-Agent /review


fix: fix query to calculate quota used by feature

Technically the model class will never not have a type, so we can remove the tap here.
The tap was resetting the query, causing it to lose the "where slug = ?" and return the wrong feature.

fixed, thanks bro


WIP: using SEPP from bioconda

I try to use the new bioconda SEPP package instead of doing patching, configuring and installing in the build script here.

I don't know how to test if the package building works as expected. conda build recipe in ci/ gives a lengthy error message ending in conda_build.exceptions.DependencyNeedsBuildingError: Unsatisfiable dependencies for platform linux-64: {'qiime2=2019.1', 'q2-types=2019.1'}
How can I test this locally @nbokulich ? I figure Travis is not testing the package building :-/

Hey there @sjanssen2 --- package building is done by busywork once master has been updated. If you want to test locally, you can look to this script for inspiration. You will need qiime2 and the framework. You can get those by using the staging channel (qiime2-staging/label/r2019.4). Otherwise, if you just want busywork to do it for you, we can merge this once the 2019.4 release goes out (the repo freeze should be done by the end of next week).


Add support for devices for testcafe config

Proposed changes

Adds a Devices list to testcafe suites.
Jobs will be created for a test suite per defined device X defined platform version.
e.g.
suites:
  - name: iOS Test
    browserName: "safari"
    src:
      - "*/*.test.js" # test files glob
    devices:
      - name: iPhone 12 Simulator
        platformName: iOS
        platformVersions:
          - "14.3"
          - "13.4"
      - name: iPad Pro (9.7-inch) Simulator
        platformName: iOS
        platformVersions:
          - "14.3"

Will yield 3 jobs:

iPhone 12 + iOS 13.4
iPhone 12 + iOS 14.3
iPad Pro + IOS 14.3

Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Checklist

[x] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments

Hm. I think this won't properly collect all the results.
See return r.collectResults(r.Project.Artifacts.Download, results, len(r.Project.Suites)), which was you can see waits for results up to length of len(r.Project.Suites), but you actually end up multiplying them. So you probably need to keep track of how many jobs you created. Check out the espresso implementation as a reference 💡

Hm. I think this won't properly collect all the results.
See return r.collectResults(r.Project.Artifacts.Download, results, len(r.Project.Suites)), which waits for results up to the length of len(r.Project.Suites), but you actually end up multiplying the suites, so you need to wait for more than amount of suites. You probably need to keep track of how many jobs you created. Check out the espresso implementation as a reference 💡

@alexplischke I added a fix for this issue.

Codecov Report

Merging #275 (36c5b24) into master (ba81073) will decrease coverage by 0.15%.
The diff coverage is 12.50%.

@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
- Coverage   34.37%   34.22%   -0.16%
==========================================
  Files          34       34
  Lines        2298     2326      +28
==========================================
+ Hits          790      796       +6
- Misses       1367     1389      +22
  Partials      141      141

Impacted Files
Coverage Δ

internal/testcafe/config.go
15.09% <ø> (ø)

internal/saucecloud/testcafe.go
12.50% <12.50%> (+5.68%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba81073...36c5b24. Read the comment docs.


warning Circular dependency detected

In my exemple I have a model Folder and a model Customer.
A Customer has a Folder, but the Folder has a Customer too, because when I get a Folder from my API, I want to have the cuncerned Customer within.
The warning is :
Circular dependency detected:
models\folder.model.ts -> models\customer.model.ts -> models\folder.model.ts
What is the best way to solve it?

The circular dependency warning comes from Angular (CLI), not from our package.
You can solve it by adding interfaces/class inheritence, so that the circular dependency disappears. You will find a lot of help for this using Google!


Fix wrong mutation of virt sc storage class meta

We weren't performing the changes on the pointer, and thus name/annotations are not applied.

/ok-to-test

@akalenyu Can you please test the changes and confirm they work as intended,
Install kubevirt, Install ODF
Then
oc get storageclass
oc get storageclass ocs-storagecluster-ceph-rbd -o yaml
oc get storageclass ocs-storagecluster-ceph-rbd-virtualization -o yaml

/cherry-pick release-4.14

@akalenyu if this is not merged today then we have to move this to the next release. Can we finish it quickly? cc @iamniting

Yes, sure, would I use the CI here to spin up a cluster? or do I get an existing cluster and deploy my build on it?

@akalenyu if this is not merged today then we have to move this to the next release. Can we finish it quickly? cc @iamniting

Yes, sure, would I use the CI here to spin up a cluster? or do I get an existing cluster and deploy my build on it?

I don't think we have a cluster, you need to respin @malayparida2000 @iamniting Do you guys have a cluster

@agarwal-mudit I do have a cluster but currently I am outside. But I think the changes apeear to be good enough. I will request @iamniting to review the unit test changes and approve it today if it's urgent enough.

@agarwal-mudit I do have a cluster but currently I am outside. But I think the changes apeear to be good enough. I will request @iamniting to review the unit test changes and approve it today if it's urgent enough.

I think I figured it out, I have a cluster, where I can edit the CSV and inject my own ocs-operator image. Sounds good?

@agarwal-mudit I do have a cluster but currently I am outside. But I think the changes apeear to be good enough. I will request @iamniting to review the unit test changes and approve it today if it's urgent enough.

I think I figured it out, I have a cluster, where I can edit the CSV and inject my own ocs-operator image. Sounds good?

Yes that sounds good.

[cloud-user@ocp-psi-executor eof-registry-import]$ oc get deploy -n openshift-storage ocs-operator -o yaml | grep image:
        image: quay.io/akalenyu/ocs-operator:latest
# Delete existing storage classes
[cloud-user@ocp-psi-executor eof-registry-import]$ oc get storageclass ocs-storagecluster-ceph-rbd -o yaml
allowVolumeExpansion: true
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  annotations:
    description: Provides RWO Filesystem volumes, and RWO and RWX Block volumes
  creationTimestamp: "2023-10-17T13:35:59Z"
  name: ocs-storagecluster-ceph-rbd
  resourceVersion: "3325649"
  uid: 6d3bd962-1b1e-4d88-99ff-f58d3784acda
parameters:
  clusterID: openshift-storage
  csi.storage.k8s.io/controller-expand-secret-name: rook-csi-rbd-provisioner
  csi.storage.k8s.io/controller-expand-secret-namespace: openshift-storage
  csi.storage.k8s.io/fstype: ext4
  csi.storage.k8s.io/node-stage-secret-name: rook-csi-rbd-node
  csi.storage.k8s.io/node-stage-secret-namespace: openshift-storage
  csi.storage.k8s.io/provisioner-secret-name: rook-csi-rbd-provisioner
  csi.storage.k8s.io/provisioner-secret-namespace: openshift-storage
  imageFeatures: layering,deep-flatten,exclusive-lock,object-map,fast-diff
  imageFormat: "2"
  pool: ocs-storagecluster-cephblockpool
provisioner: openshift-storage.rbd.csi.ceph.com
reclaimPolicy: Delete
volumeBindingMode: Immediate
[cloud-user@ocp-psi-executor eof-registry-import]$ oc get storageclass ocs-storagecluster-ceph-rbd-virtualization -o yaml
allowVolumeExpansion: true
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  annotations:
    description: Provides RWO and RWX Block volumes suitable for Virtual Machine disks
    storageclass.kubevirt.io/is-default-virt-class: "true"
  creationTimestamp: "2023-10-17T13:35:59Z"
  name: ocs-storagecluster-ceph-rbd-virtualization
  resourceVersion: "3325650"
  uid: 5d724954-5d49-4db6-aa35-d6f5a5ee2eaf
parameters:
  clusterID: openshift-storage
  csi.storage.k8s.io/controller-expand-secret-name: rook-csi-rbd-provisioner
  csi.storage.k8s.io/controller-expand-secret-namespace: openshift-storage
  csi.storage.k8s.io/fstype: ext4
  csi.storage.k8s.io/node-stage-secret-name: rook-csi-rbd-node
  csi.storage.k8s.io/node-stage-secret-namespace: openshift-storage
  csi.storage.k8s.io/provisioner-secret-name: rook-csi-rbd-provisioner
  csi.storage.k8s.io/provisioner-secret-namespace: openshift-storage
  imageFeatures: layering,deep-flatten,exclusive-lock,object-map,fast-diff
  imageFormat: "2"
  mapOptions: krbd:rxbounce
  mounter: rbd
  pool: ocs-storagecluster-cephblockpool
provisioner: openshift-storage.rbd.csi.ceph.com
reclaimPolicy: Delete
volumeBindingMode: Immediate

Looks clean, @agarwal-mudit can be approved & merged

@akalenyu Can you pls add the bug in the description box and get the acks?


Adding path for temporary FDF files

Main idea is to enable the configuration of the path for the temporary FDF files that are created when filling a form.
At the moment files are created on the current working directory, which is not always a suitable location and can cause problems. Specially when you run your NodeJS application using process managers such as pm2, forever, etc.

@anperez is this an issue because of file permissions?

Exactly! file permissions issue :)

For those who've been using the fillFormWithFlatten method directly to override shouldFlatten they will be required to add an additional parameter otherwise the callback will be undefined.
Maybe wrapping this custom path functionality into another method like fillForm?
But this also brings up the question of multiple methods for specific options.
Considering a rethink of this method so an options parameter can be provided with defaulted values for shouldFlatten and tempFDFPath and any other values that may be needed.
Thoughts?

At the moment, and not to break the previous use of fillFormWithFlatten, I've just added a new method fillFormWithOptions to include all options (temp path + shouldFlatten).


Bug when with Windows desk top theme High Contrast mode enabled

As in title, the client seems failing to refresh the screen with high contrast mode enabled. Window tab is reacting (like full screen, collapse, close) Clicks are accepted in the window body but the screen is not refreshing. You can collapse then expand the window to be refreshed.
OS: Windows 8.1 Pro build 9600

Hey, I was having the same issue. I just figured it today. To get it to work you just need to right click the desktop app and click run with graphics processor, there should be two options. The default and high performance mode. Run it in high performance mode and it should work.


Launch json program doc fix

This checkin makes tweaks to the docs/default value/template value for 'program' to hopefully make it really clear what one should use, and that you can't just leave it at some weird thing with '<' characters in it.
This resolves #1668.

Here is a link to the new md file: https://github.com/gregg-miskelly/omnisharp-vscode/blob/LaunchJsonProgramDocFix/debugger-launchjson.md#program


[spike] Research additional instrumentations points within App Router

Problem
App Router applications lack some observability that existed in legacy Next.js apps.  In legacy applications we instrumented all getServerSideProps, middleware and api calls.  The recommendations in App router is to encapsulate all fetching data into reusable functions within app/lib.  From their [getting started](/app/lib: Contains functions used in your application, such as reusable utility functions and data fetching functions.)

/app/lib: Contains functions used in your application, such as reusable utility functions and data fetching functions.

The goal of this research spike is to see if there are any common interfaces that can be instrumented to get insight here.  The answer may be no, and that since it's recommended to use fetch, which we create external http spans for, that will be enough.

Not adding any additional instrumentation points at this time


Add highlights for mini.pick and mini.statusline

Hello, this is a very nice theme, thank you!.
I have added highlights to mini.pick and mini.statusline to be a bit more consistent with the theme.
The only big problem I see in this change is the visibility of the selected item in the dark theme. I also tested it with linking MiniPickMatchCurrent with PmenuSel which makes it better, but it is inconsistent with the theme, so I am not sure what highlight it should have.

Awesome! Will change the selection to the one I think would work better and merge the request.
Thanks a lot!

What do you think of this changes?

Made currently selected more clear linking to Visual
Made marked bold
Made matched strings match search
Preview highlights the line where the match is found
Cleaner title and search box text (just bold)

Maybe this dont work so well with the dark theme, but I will tackle the darke theme later since I will change some groups around...

The light theme looks really good with those changes. But yeah, the dark theme needs some changes. It might be worth it to add to the palette something like ui_selection so you can set them differently individually for light and dark, and the highlight is reusable with other pickers like Telescope or Fzf-lua.

I will merge this changes to the develop branch in case you are interested in using them. This will be accompanied with some minor changes in the colors and some groups

Closing in favor orf version to be released by the end of week. Included the work discussed here and added as co-author of commit. Thanks! and sorry for the late response and lack of traction on this PR, life got on the way.


WoT lookup box modifies my search

I wanted to look for Kalmac. I made a mistake and wrote kalmac (lower-cased K). So, I tried to type it right Kalmac. But cutecoin turns it to kalmac. So I can never find Kalmac, since it always searchs kalmac.
Well, if I type cgeek, I can then type Kalmac. But that's a bit tricky!

You're right, it was a tricky one !
Bug fixed in dfee264b75b23effc23f161f7bedeac7656d5594

I wonder if we should release a 0.7.6 for the last few bugs or if we wait for 0.8.

Sure we will release a 0.7.x with bugfixes, but we can wait to have a certain amount of bugs... As you see fit...


Bug: Travis runs linting but npm test doesn't

This creates a situation where you can confirm that tests pass locally, only to have them fail on CI. A better design is for npm test to also run linting, and Travis would just run npm test.
If we want to skip linting, we can have a bare mocha command for that.

@sibelius That's the plan: Three jobs actually: one for linting, one for testing-only and one that runs first two tests together.

This was fixed today.


Improve calculating navigation selection from Url

The algorithm that’s calculating selection from Url was not handling well situations when plugin paths are forming by adding on 2nd level navigation - everywhere else that’s done on 3rd level.
Reworked it, so now it ranks all known paths against the Url and one with deepest match wins. This insures that we will match the selection regardless how plugin authors decide to build their Url structure.
Signed-off-by: Milan Klanjsek<EMAIL_ADDRESS>

Works well in my testing


import: Ensure proper encoding for AWS credentials

From the forum:

One gotcha with specifying AWS credentials as query parameters is that they often contain non-URL-safe characters that need to be URL-encoded. In Go, you could use url.QueryEscape; in JavaScript, you could use encodeURIComponent.

h/t @benesch

Called out in docs now: https://www.cockroachlabs.com/docs/stable/import.html#import-file-urls.


Display more items in the list

currently the list shows a few items and scrolls as you move up down. it wraps around. would be nicer if it showed all choices, or at least more. need to look into the options for this.

done


Request: Offline/Cached Environment Variables

I've been thinking it would be nice for the CLI to be able to cache environment variables.
The use case I'm thinking of here is CLI usage without internet or during a Railway outage. I know this presents a certain security risk but if you're already logged in to the CLI and someone gains physical access to your machine it's already game over. (Could also make offline access/caching opt-in only)
Example:
railway login && railway link -> link to a project
railway run pnpm dev -> runs as expected, pulling context from environment variables set in the project
oh great heavens internet pooped
railway run pnpm dev -> runs as expected, pulling context from last known environment variables set in the project

oh great heavens!

I have to wonder, how would caching work? I'm assuming that there would need to be a timestamp saved in the local cache and some kind of extra endpoint for checkinggetting the environment variables from apiv2


Fix "new cop generator" rake task

The RuboCop::Cop::Generator.initialize API was changed in https://github.com/rubocop-hq/rubocop/commit/488c6dee600f4b23326fa862a66e8e16783 which was released with RuboCop v0.56.0.

Before submitting the PR make sure the following are checked:

[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[ ] Added tests.
[ ] Added an entry to the changelog if the new code introduces user-observable changes.
[x] The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

Oh, I just realised we’d need to bump the dependency on Rubocop also…

Oh, I just realised we’d need to bump the dependency on Rubocop also…

Only for development :)

Only for development :)

That is true. But one version requirement in the gemspec and another in the Gemfile, won’t that be confusing at some point?

I think it will be. As we plan to make RuboCop upgrades very painless soon maybe it will make sense to just require whatever the latest RuboCop was around the time of the release?

But one version requirement in the gemspec and another in the Gemfile, won’t that be confusing at some point?

Yeah, I'd think so. We should definitely be careful not to release this way and I don't think there's an automated process to catch that class of mistake yet.

Done: I’m bumping the RuboCop requirement to >= 0.56.0 in the gemspec.


*** Recursion limit exceeded *** Flow error

I am using FlowJS with RamdaJS. I do have the following flow error
*** Recursion limit exceeded ***

    import * as R from "ramda";

This got fixed after I removed ramdajs import from a file that had this error.

This got fixed after I removed ramdajs import from a file that had this error.


require('knex') ...

Environment
Knex version: 0.20.11
Database + version:
OS: mac
Select applicable template from below.
If issue is about oracledb support, tag @ atiertant. For MSSql tag @ smorey2.
Rest of dialects don't need tags.
If issue is about TypeScript definitions, tag @ lorefnon.
Bug

Explain what kind of behaviour you are getting and how you think it should do
require('knex')

error:

Error message

Reduced test code, for example in https://npm.runkit.com/knex or if it needs real
database connection to MySQL or PostgreSQL, then single file example which initializes
needed data and demonstrates the problem.

Feature discussion / request

Explain what is your use case

Explain what kind of feature would support this

Give some API proposal, how the feature should work

Missing / erroneus documentation
Send issue to documentation repo, or fix it and send PR https://github.com/knex/documentation
Questions about how to use knex
GitHub issues are for knex development. Please send questions how to use knex to
Stack Overflow or ask about it in gitter chat.

Which Node version are you using?

Which Node version are you using?

v12.16.1
I change the version of knex => 0.14.3 is ok

Which Node version are you using?

Today because of this reason to deal with for a long time, just can not pass, do not know why

Which Node version are you using?

Upload the complete error information

v12.16.1
Are you sure about this? Error that you are seeing indicates that you are running version of Node that does not support destructuring. I'll try to fix it in 0.20 branch, but 12.6.1 should support this just fine. Are you sure that the electron application that you are building is still executed with Node 12?

But I switched knex to version 0.14.x, and the local node and other packages ran unchanged

v12.16.1
Are you sure about this? Error that you are seeing indicates that you are running version of Node that does not support destructuring. I'll try to fix it in 0.20 branch, but 12.6.1 should support this just fine. Are you sure that the electron application that you are building is still executed with Node 12?

But I switched knex to version 0.14.x, and the local node and other packages ran unchanged

Closing until reproduction code is provided. Please provide all the steps how to get this error to happen.


Feature Request: Minimal version / styling

Hey! Thanks for creating such an awesome utility. I was wondering if it would be possible to do 2 things:
1 - Allow aliasing for Stock Names. For example, pulling back 'CB3.PA' works great, but the stock name is stupidly long (at the source) - it would be great if I could have an alias for that.
2 - Allow a minimal version / selection of individual fields - for example, just return the price, or the change, by addition of switches or similar.
Thanks!

@symph0nic thanks for using terminal-stocks and providing the suggestions to improve it further.
Alias would be a nice addition to terminal-stocks and it will make it much easier to use. I will try to add support for alias soon.
Field selection can also be done will add it soon.

I think your idea of the field selection is fine, the important thing is that I want the option to get the unformatted output printed in the console, not exported to a file, so that I can  easily parse it and use in my application.
If you want to improve the export even more, I would suggest something like:
terminal-stocks -t <ticker> --format "%name: %price,%percentageChage,%dayChange,%weekChage"
The tokens will be replaced with the right value, and the user can take some freedom in formatting it.


added password generator to js projects (issue #512)

please review and merge this pull request

mention the issue number

mentioned (issue #512 )

kindly merge this pull request now Thank You


fasta analyzer bot running the language2 tests

We should add running the language2 tests to the fasta analyzer bot.

done


Output TZ field from msg.x value

I need to do timezone conversions based on a value that will be passed to the node in a msg.x field.
Data being converted from is all in UTC and the users timezone string (i.e. Australia/Melbourne) from an SQL query will determine the timezone it will convert to.  If I manually set in Output TZ it converts correctly but I need it to be dynamic.
I've tried entering the field as msg.payload.timezone which contains the timezone string but just get the following error as the data is parsed as entered rather than the actual message content.
How do I do what I need to?

Moment: Output Timezone Invalid, reset to UTC - see http://momentjs.com/timezone/docs/#/data-loading/

Sorry, been a while since I looked at the code. Make take me a bit to get to looking as I'm rather tied up with COVID related issues right now.

Understandable.  We're all in the same boat.
I've had a brief look and I probably could do a pull and change on it but JS is far from my forte so if someone else versed in JS could have a look it would probably be much smoother.

Good, if rather delayed, news.
From v4 of this node, due to be released imminently, both the input and the output timezones can be set from the input msg.
msg.inTz and msg.outTz are the two properties to use.


how to set board_id

We use GitHub issues only to discuss PX4 bugs and new features. For
questions about using PX4 or related components, please use PX4 Discuss.
how to set board_id in the file[Firmware/boards/px4/fmu-v5]
Thanks!

The ID can be changed here. https://github.com/PX4/Firmware/blob/a7fbaefd837b2947545d79b6ace42b1d2114ac52/boards/px4/fmu-v5/nuttx-config/nsh/defconfig#L47-L52


Configure Azure Pipelines

This pipeline configuration builds the application and produces a build for the Release configuration.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: rajeev-cogn sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


ECS with EC2 autoscaling cannot use DIND but dockerd daemon starts successfully after enabling  privileged = true

Description
I cannot mount /var/run/docker.sock on the task container although defining mountPoints and volume in the module.
container_definitions
          mountPoints = [
            {
              readOnly = null,
              containerPath = "/var/run/docker.sock",
              sourceVolume = "docker_sock"
            }
          ]

And in services on the same level as container definitions:
      volume = [{

        name      = "docker_sock"
        host = {
          sourcePath = "/var/run/docker.sock"
        }
      }]

If your request is for a new feature, please use the Feature request template.

[x] ✋ I have searched the open/closed issues and my issue is not listed.

Versions

Module version [Required]: version=5.2.1

Reproduction Code [Required]

Steps to reproduce the behaviour:
When providing the above mentioned arguments to the resource, the volume is not mounted and container fails with the following error:
Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?.
Expected behaviour
As I can start the dockerd by calling the binary from entrypoint -> command but there is no other space to execute other commands
Actual behavior
Container is not able to run DIND
Terminal Output Screenshot(s)
Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?.
Additional context

I found the issue. It looks like you have defined a different naming convention for the default definition of Docker from mountPoints to mount_points. But the rest of the arguments like containerPath, sourceVolume and f.e. readOnly you allowed the default naming convention that can be seen in the outputs.
For example the following block solved the issue:
          mount_points = [ # You can observe that it is different from the output
            {
              containerPath = "/var/run/docker.sock"
              sourceVolume = "docker-socket"
              readOnly = false
            }
          ]

After applying the update, the output looks like the following:
          "mountPoints" = tolist([
            {
              "containerPath" = "/var/run/docker.sock"
              "readOnly" = false
              "sourceVolume" = "docker-socket"
            },
          ])

This is a bit confusing to be honest. But looking at your module I can see that you are using a dynamic
This is a visual illustration of what I mean.
The ongoing issues is related to using a non root user inside the container.
On my local pc, I am using the exact same image and forging start with the created user.
Dockerfile:
RUN groupadd "runner" && useradd -g "runner" --shell /bin/bash "runner" \
    && mkdir -p "/home/runner" \
    && chown -R "runner":"runner" "/home/runner"
RUN usermod -aG docker "runner"

WORKDIR /home/runner
USER runner

From my terminal (local pc) I can run the docker version command with user runner:
❯ docker run --user runner -ti -v /var/run/docker.sock:/var/run/docker.sock github-runner-entrypoint:0.8 /bin/bash
runner@62514eaea867:~$ /usr/bin/docker version --format '{{.Server.APIVersion}}'
1.41
runner@62514eaea867:~$

From ECS task, I get an error that I the user does not have sufficient privileges:
terraform:
User declaration under container_definitions:
 user = "runner"
Command-line parameters:
          entrypoint = ["/bin/bash", "-c"]
          command = ["/bin/mount && /bin/docker run debian:latest /bin/ls"]

If I disable the  user = "runner" I can successfully run the docker command.
Please can you see anything wrong on my side here or am I missing some extra parameter please ?

the variables used by the container definition can be found here https://github.com/terraform-aws-modules/terraform-aws-ecs/blob/master/modules/container-definition/variables.tf
Terraform currently does not have a resource for ECS container definition https://github.com/hashicorp/terraform-provider-aws/issues/17988
The ECS API simply takes in a JSON payload for the container definition, and this module tries to support that through a psuedo-Terraform way. Its standard convention that the Terraform arguments are written in snake-case, but the ECS container definition API is camelCase. As always, look at the variable definitions to provide the correct form

Thanks a lot @bryantbiggs for the reply and the documentation link.


create own themes

create own themes
directory structure for own themes
ajax for getting the template.tpl

Hi there and nice to see @cdmedia back on track!
(As I'm not javascript-savvy enough, I'd rather try it with words.)
It would be nice to have theme support. A variable in config.js named theme = '' (default empty) could be set to the name of a directory in the newly created directory theme.
The structure of a theme would be a css directory and a file template.tpl. For example the default theme would be a directory css with poole.min.css and style.css in it and a file called template.tpl which includes the things we need for a own template. I'm unclear of how much we can put out of the index.html to the template, the css part in the <head> element? ...
In the config.js the variable would allow a corresponding ajax to get the themes/THEME/template.tpl and var tpl would get the individual themes content.
This would definitively allow more flexibility.
thanks

Resolved in v2.0. https://github.com/chrisdiana/cms.js-themes


HARP-8498: Refactor object construction in TileGeometryCreator.

Substitude getObjectConstructor by buildObject. Return the created object
instead of the constructor. It's simpler and more flexible, since buildObject
can do more than just choosing a constructor.
Also refactor TileCreationTest to remove all copy-pasta.Frankly the test is useless
and I'd rather remove it completely.
Signed-off-by: Andres Mandado<EMAIL_ADDRESS>Thank you for contributing to harp.gl!
Before requesting a pull request, please remember to check the following documents:

contribution guidelines
coding style

If you are adding new functionality we would highly appreciate if you can describe what is the capability you are adding and even better if you can add some examples. Please also remember to add tests for it.
CI Check
Our bots will check whether your PR can be directly integrated into the mainline. We have some internal integration tests running on the background, our bots will inform you of the next steps and someone from our team will take a look and help if needed!
And please do not forget to sign-off your commit! You can read more about DCO here. But, in short, you just need to use git commit -s or append --signoff when you are committing to the repo.
Happy contributing!

Codecov Report

Merging #1435 into master will increase coverage by 0.15%.
The diff coverage is 83.33%.

@@            Coverage Diff            @@
##           master   #1435      +/-   ##
=========================================
+ Coverage   55.75%   55.9%   +0.15%
=========================================
  Files         270     270
  Lines       24163   24230      +67
  Branches     5398    5419      +21
=========================================
+ Hits        13471   13546      +75
+ Misses      10692   10684       -8

Impacted Files
Coverage Δ

...e/harp-mapview/lib/geometry/TileGeometryCreator.ts
40.3% <75%> (-0.1%)
:arrow_down:

@here/harp-mapview/lib/DecodedTileHelpers.ts
57.18% <84.61%> (+0.13%)
:arrow_up:

...here/harp-mapview/lib/text/TextElementsRenderer.ts
66.42% <0%> (ø)
:arrow_up:

...here/harp-text-canvas/lib/rendering/FontCatalog.ts
75.78% <0%> (+0.78%)
:arrow_up:

...arp-text-canvas/lib/rendering/GlyphTextureCache.ts
64.82% <0%> (+1%)
:arrow_up:

@here/harp-mapview/lib/text/Placement.ts
90.94% <0%> (+2.17%)
:arrow_up:

@here/harp-text-canvas/lib/rendering/TextStyle.ts
83.33% <0%> (+3.57%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0827ea...f1c08ca. Read the comment docs.

@harpgl-bot retest this please