Caching breaks import/named.

I first posted at xojs/xo/issues/335 but was told this would need to be addressed from the implementation of this rule.  Pasted from the other bug:
Create test1.js:
export const value = 'test1';

Create test2.js:
import {value} from './test1';

console.log(value);

Run xo, it correctly does not report any errors. Now rename the export in test1.js:
export const value2 = 'test1';

Run xo again, it fails to report any errors. Run touch test2.js && xo, you will see the correct error:
  test2.js:1:9
  ✖  1:9  value not found in ./test1  import/named

  1 error

AFAIK there is no way to fix this without changes in ESLint proper. ESLint (appropriately, per its goals) assumes that if a file is not changed, it is as correct/wrong as it was last time you scanned it.
I haven't dug into the ESLint API in ages but I assume there is still no way to do this and it would require some substantial cooperation upstream to fix permanently.
Closing as #wontfix for now because it is not possible. Would love to hear from anyone who knows I'm wrong or is willing to do the PR work with ESLint to make it possible.

@benmosher right but the issue seems to be that the dependency map in this plugin is caching too aggressively?

I don't think so, I think it's that

a imports from b
b is changed and no longer exports what a imports
a lints as no errors until it is changed and ESLint re-lints it

There is an internal cache of dependencies but it checks file modification timestamps and/or only lasts 30s or so, IIRC.


Refine home page link & bg

Background: Allow resizing background image to bigger size, save high-res screens
Background: Adjust the interpolation algorithm for event button scaling (sadly, maui does not support RenderOptions)
Article list: Change text color and pointer on mouse hover (ugly code due to maui)
Social media: Apply white background to QR Code, for there is a transparent-bg qrcode.
Social media: China region workarounds. Chinese launcher uses links(that is, multiple link) field rather than single url. Popup windows need to be refactored one day.
Social media: The "QQ Group" link want's a key parameter, make it happy.

What do you mean exactly when you say there is a transparent background qr code?

What do you mean exactly when you say there is a transparent background qr code?

Hello~ thank you for submitting a really nice enhancement pull request for Collapse!
We will review this and merge the code as soon as we're able to.
Though as a note, as we already finalized the draft for 1.71.x stable release that is going to be released in this week, we cannot merge and push this as release quite so soon as we have to make sure that the code in the PR is a-ok and do general testing on it.

Should be good enough but let me do some tests before we could merge the PR

I think it should be good enough!
Have some conflict issues need to be fixed after it's being merged.
Closing and merge this PR for now. Thank you very much for the contribution! 😃


mkay

Coverage decreased (-0.2%) to 81.864% when pulling e3bdd8e54ae77d733b7bac509e63f070865ed5c3 on StefanBranch into 9379b34eed7998222010822bab668ad4534d22fd on master.

Coverage decreased (-0.2%) to 81.864% when pulling e3bdd8e54ae77d733b7bac509e63f070865ed5c3 on StefanBranch into 9379b34eed7998222010822bab668ad4534d22fd on master.

Coverage decreased (-0.2%) to 81.418% when pulling 53701531cf075a665f605fb9f5d3586325deaf10 on StefanBranch into 858c935591e34a1881d54dae6ee064442cb15d0b on master.

Coverage decreased (-0.09%) to 81.568% when pulling 421ccd767625fdad45a5304d7997e8b80dd646ef on StefanBranch into 858c935591e34a1881d54dae6ee064442cb15d0b on master.

Coverage decreased (-0.08%) to 81.574% when pulling ad6bd4fafef64dfc6cfc49ff3c35fe25114934dc on StefanBranch into 858c935591e34a1881d54dae6ee064442cb15d0b on master.


Added support for the 'log1p' op and its VJP.

@rxwei I decided to break down PRs that add support for new ops, but please let me know if you'd prefer I add them as a single PR.

Added a test similar to #144.

Which one's next?

I just updated this one so you can go ahead and test.

I'll be out for about ~15-30' but will come back and update the next one after this is merged.

#151 and #152 are also independent and can be tested and merged in the meantime.

All tests passed. Thank you!

#151 and #152 are also independent and can be tested and merged in the meantime.

Those two actually need pulling from master and had some comments. Let me know when they are ready!


wasi-filesystem spec: remove locks (defer to 0.2.1)

Done in https://github.com/bytecodealliance/wasmtime/pull/7355


[3.x] Update CSGMesh's documentation to explain how vertex normals are used

3.x version of #48245.

Thanks!


[Module Proposal]: Virtual Machine Scale Set (tf)

Check for previous/existing GitHub issues/module proposals

[X] I have checked for previous/existing GitHub issues/module proposals

Terraform or Bicep?
Terraform
Resource or Pattern Module?
Resource Module
Module Name
terraform-avm-pattern-vmss
Module Details
Create a Terraform pattern for VMSS Flex deployment.  We are currently researching how VMSS is being used by the field.  This may result in multiple patterns.
Do you want to be the owner of this module?
Yes
Module Owner's GitHub Username
terrymandin

Hey @terrymandin,
Thanks for the submission.
Can you explain why you feel this would be a pattern module and not a resource module?

See the Module Classification Definitions for more info

Look forward to hearing from you
Jack

@terrymandin pls update and let us know if you want to be the owner for this Resource Module.
By doing that you'd confirm you agree to the below:
• https://azure.github.io/Azure-Verified-Modules/specs/shared/team-definitions/
• https://azure.github.io/Azure-Verified-Modules/specs/shared/
• https://azure.github.io/Azure-Verified-Modules/help-support/module-support/
BTW, this module should include both Linux & Windows

Hey guys, sorry for the late response.  I have to check my notifications as I wasn't alerted to your questions.
Regar

Hey @terrymandin,
Thanks for the submission.
Can you explain why you feel this would be a pattern module and not a resource module?

See the Module Classification Definitions for more info

Look forward to hearing from you
Jack

I have changed my mind and agree that this should be a Resource module.  The PG has suggested follow-on pattern modules.  e.g. Behind a load balancer, with an app gateway, blue/green testing, etc., but I can create new applications for those.

@terrymandin pls update and let us know if you want to be the owner for this Resource Module. By doing that you'd confirm you agree to the below: • https://azure.github.io/Azure-Verified-Modules/specs/shared/team-definitions/ • https://azure.github.io/Azure-Verified-Modules/specs/shared/ • https://azure.github.io/Azure-Verified-Modules/help-support/module-support/ BTW, this module should include both Linux & Windows

I will be an owner.  I have reached out to René Hézser and Marcel Keller as possible co-owners.

Please let me know when this is approved and I will create the repo from the template.

Marcel Keller and René Hézser have agreed to co-author this AVM.

@terrymandin  - Could you please let us know their GitHub alias so that we can assign the module to them?

@PankajMeshramCSA, here are two of them:
Terry Mandin: terrymandin
Marcel Keller: marcelkmfst
René is on holidays this week.  I'll get his to you next week.
Can I get started by creating the repo from the template?

Thanks @terrymandin,  I have sorted out the assignment. Yes you can start by creating the repo from the template.

Thanks @PankajMeshramCSA, René just sent me his GitHub id: ReneHezser

@terrymandin  - Thanks, I have added him and as discussed the module name is -  terraform-azurerm-avm-res-compute-virtualmachinescaleset

@PankajMeshramCSA, after further analysis it appears that building a "reference" AVM on top of azurerm_orchestrated_virtual_machine_scale_set would just be a "wrapper".  The code example that the PG provided is actually better described as a "pattern" module to setup VMSS with a load balancer.  For this reason we will switch over to building a "pattern" AVM, with our first "pattern" AVM setting up VMSS with a load balancer.  More details to follow ...

New "pattern" module will be named: "terraform-azurerm-avm-ptn-virtualmachinescalesetloadbalancer".

@PmeshramPM , I brought up a number of questions regarding the VMSS AVM with Sapna and she suggested I reach out to you:

How do I find customer architectures to base my VMSS AVM patterns on?  Currently, Jerry Steele has mentioned a few: 1) VMSS with a Load Balancer, 2) VMSS with an App Gateway, and 3) blue/green architectures.  If I build these, how do I validate them with real customer scenarios
To be more specific, it seems that when building AVM modules we should be pruning down, defaulting or hard coding certain variables to align with best practices.  How do I find the right balance with VMSS.  I will be reaching out to Marcel and René, but am also looking for your input.
Could you send me a link to the old Terraform repository.  I'd like to review it to see if there are any VMSS architectures I can review there.
One of the first customer's we are considering for the VMSS AVM modules is SAP.  They have already built architectures based on VMSS using Availability Sets for databases.  Interested in your thoughts here as you have experience with SAP.  I also want to get Jerry Steele's (VMSS PM) recommendations as I believe there are nuances related to databases using VMSS.  Interestingly, the Oracle database best practice is to use VMSS on Availability Sets.

If you are interested, you can see my initial commits on the VMSS Load Balancer AVM here.   I am now trying to get the code to adhere to the AVM requirements and also determine which parameters are needed.

@terrymandin  - Please see my responses
[#1] - This is where you would need to speak with assigned contacts with some of the big customers who may have common requirements for VMSS patterns. We can take it offline, happy to help you here. We can go back to these customers for validation.
[#2] - I would say in terms of balance, lets start with like a V1 version, validate that with customers and then work on V2 and so on.
[#3] - https://github.com/Azure/terraform-azure-modules - This is the link to TFVM repot but it does not have VMSS module.
[#4] - The best practice for SAP is VMSS with AZs. Here is the link to the architecture - https://learn.microsoft.com/en-us/azure/sap/workloads/virtual-machine-scale-set-sap-deployment-guide?tabs=scaleset-cli  - I think we already have this one in the code. Let me check and get back to you on this one.

@terrymandin  -Two more points

on the pattern module name, the convention is "avm-ptn-" - I have updated that in the description of this GH issue. Please pay attention to the repo name which would be terraform--avm-ptn-
On the SAP point, we do have VMSS flex with AZs in the SAP automation repo.

@PmeshramPM , thank you for you replies!
[1] Thank you for your offer to help finding customers.  I will setup time for us to discuss
[2] The VMSS PM presented a great option to me for the variables.  He recommended I use the same variables as az vmss create -h.  I will do this.
[3] -
[4] -
Regarding the naming, as patterns can contain multiple services, it seems that the naming standard is looser.  For example, in the specifications it gives an example of avm-ptn-apptiervmss.  I believe that avm-ptn-vmss is too general in nature, as there will be other VMSS patterns as well.  For example, the next one we are planning is a VMSS App Gateway pattern.  If I have already used avm-ptn-vmss for the load balancer, what do I name the VMSS App Gateway pattern?
Regarding SAP, perhaps it could be one of the first consumer's of the VMSS patterns?

Had a chat with @terrymandin and he is building VMSS Flex with lb pattern , updated the issue description and details based on that

This pattern AVM has been deprioritized by the CSU Compute PM (Michiel van Shaik).  He has asked that we keep the request, but that we focus on other resource AVMs now.

This pattern module was initially created as LB/VMSS architectures were quite common in the architecture center.  It was also recommended by the VMSS PM.
After speaking with the Compute CSU PM we have decided to wait to see the usage of the VMSS resource AVM (currently in PR stage) before continuing on this module.

Reached out to @terrymandin offline to confirm the plans for this going forward, he or I will update accordingly

@terrymandin, @mbilalamjad, the AVM issue triage team is reviewing issues tagged as long-term. As part of this effort, we'd like to ask you to please provide any updates on this issue. Thank you!


Refactor into separate files

Moves from monolithic file to submodule-based code. Hopefully much easier for others to read.

coverage: 97.059% (+0.04%) from 97.021%
when pulling 69acf7de505b6b112ea8e9d72f4a7119744db2ac on refactor
into 095f1f3021ec8c8dfd8dcb123a51a260dfa61109 on main.


⚠ Bofrost.be has degraded performance

In 59ed37f, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1755 ms

Resolved: Bofrost.be performance has improved in 536e5c4 after 6 minutes.


[Manual PR] Review request for Microsoft.ContainerRegistry to add version stable/2022-12-01

ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo.  If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[x] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[x] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[x] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

          }

Can common Error type be used here?

Refers to: specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/stable/2022-12-01/containerregistry.json:486 in 89325df. [](commit_id = 89325df34f0d006c569a6a2abfcb806bae84e2db, deletion_comment = False)

Approved. However, this is a breaking change. Please work with breaking change reviewers to get this signed off -<EMAIL_ADDRESS>

The Breaking Changes all appear to be benign, so I've marked the PR Approved-BreakingChanges.

@AntonioVT can you take a look at the Swagger Avocado CI failure? It's the only blocker for merging the PR now.


How could I save fitted model and reload in in another script ?

Hi,
I am new to autogluon, and I find the basic usage in the page which shows how could I train a yolov3 model. After the training is done, I need to save the trained best model, and use the saved model for prediction in the future tasks. I have found no explicit save/reload example in the docs, would you please tell me how could I save and reuse the best trained model ?

@Jerryzcn and @zhreshold , can you please respond to this issue?

@zhanghang1989 @chongruo
By checking the existing detector implementation, I found there's no implemented save and load function, do you guys have discussion about this before?
@CoinCheung The easiest solution for you is to use pickle to dump and load the detector object. We will update once we have concrete solution for serialization and de-serialization.

It was discussed before, but I don't think action was taken to implement it: #183.
I think this should be high priority to enable ease of use for users.

Sorry that I am not familiar with object detection code.
detector.model.save_parameters('net.params') should save the mxnet model params.

Thanks for replying !!!  if this problem is solved, please add a few lines to the doc so that we could figure this out faster.


Cleanup NetBeans license header for module hibernate

Review and cleanup the license header in hibernate
Oracle donated NetBeans to the Apache Software Foundation.
Your task now is to replace the old license header that has Oracle (and/or Sun Microsystems
and/or NetBeans) in it with the standard Apache Software Foundation license header.
For an empty file that supports headers you must add the Apache license header.
Note that you have to use the proper license header for Java, .properties or HTML files.
Look at the nearby files for templates and copy-paste the license header.
When done commit the changes with a commit message that starts with first line
"[NETBEANS-54] Module Review " and a message body describing your review.
See a longer explanation about what we are doing here: https://cwiki.apache.org/confluence/display/NETBEANS/List+of+Modules+to+Review
Please announce in a comment when you have started work.
Files that need to be looked at in hibernate:
hibernate/src/org/netbeans/modules/hibernate/hqleditor/HQLEditorController.java
hibernate/src/org/netbeans/modules/hibernate/hqleditor/ui/Bundle.properties
hibernate/src/org/netbeans/modules/hibernate/refactoring/HibernateRefactoringUtil.java
hibernate/src/org/netbeans/modules/hibernate/resources/HibernateRevengTemplate.xml
hibernate/src/org/netbeans/modules/hibernate/resources/HibernateUtil.javax
hibernate/src/org/netbeans/modules/hibernate/resources/hibernate-configuration-3.0.dtd
hibernate/src/org/netbeans/modules/hibernate/resources/hibernate-mapping-3.0.dtd
hibernate/src/org/netbeans/modules/hibernate/resources/hibernate-reverse-engineering-3.0.dtd
hibernate/test/unit/src/org/netbeans/modules/hibernate/completion/resources/Person.hbm.xml
hibernate/test/unit/src/org/netbeans/modules/hibernate/completion/resources/hibernate.cfg.xml
hibernate/test/unit/src/org/netbeans/modules/hibernate/hyperlink/resources/Person.hbm.xml
hibernate/test/unit/src/org/netbeans/modules/hibernate/hyperlink/resources/hibernate.cfg.xml

Already have PR in apache.


Update Readme

What type of PR is this?

/kind documentation
What this PR does / why we need it:
Update readme newline from CR LF to LF
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

/lgtm
/approve


Parsing a UDT with a field not present in a struct results in a BadCqlType error

Hello,
I've been using this driver for a few months in production but I have a little problem:
Some of our services need to read data from scylla but their cql schema is not up-to-date, so when a field is added to an UDT, any column containing this UDT would no longer be readable using this driver.
The cause behind this is this piece of code:
 if fields_iter.next().is_some() {
    return Err(FromCqlValError::BadCqlType);
}

That is why we're using our own version of scylla-macros, but I think it would be better letting the user choose if they want to allow this kind of behavior.
I think there could be two solutions:

The easiest would be just to duplicate this derive macro with a different name with the check disabled and a different name.

Pros:

Easier

Cons:

Duplicate Code
Less user-friendly

Add a #[scylla(non_exhaustive)] derive macro attribute at the struct level for FromUserType.

Pros:

Easier to use
Cleaner code

Cons:

A little bit harder to implement

What do you think of these two approaches ?
Do you think it would be worth adding them to this crate ?

Ref: #962

The PR with new deserialization macros has been merged (https://github.com/scylladb/scylla-rust-driver/pull/1024), but the new deserialization API they generate implementation for is not yet available in the driver. For tracking it, see https://github.com/scylladb/scylla-rust-driver/issues/462.


Wandb pytorch lightning integration bug

I am trying to tune hyper-params across 2 GPUs so I installed ray_lightning.  Yet, I am running into the following error with wandb.
wandb: Network error (ReadTimeout), entering retry loop. See wandb/debug-internal.log for full traceback.
Any ideas?  Thanks

@griff4692 do you have a longer stack trace? And also do you mind sharing your code? Is the wandb error coming from the Tune side or the Pytorch Lightning side?

Hi!
Thanks - I actually solved it by just removing wandb for distributed training.  Yet I am now confused with how to set
resources_per_trial={
  'cpu': 4,
  'gpu': 2
}

I have 2 RTX 3090s and 64 CPUs.
I am passing
pl.Trainer(...gpus=2)

However I am getting the following error from pytorch_lightning
    self.accelerator_connector = AcceleratorConnector(
  File "/home/griffin/cl/lib/python3.8/site-packages/pytorch_lightning/trainer/connectors/accelerator_connector.py", line 119, in __init__
    self.parallel_device_ids = device_parser.parse_gpu_ids(self.gpus)
  File "/home/griffin/cl/lib/python3.8/site-packages/pytorch_lightning/utilities/device_parser.py", line 81, in parse_gpu_ids
    gpus = _sanitize_gpu_ids(gpus)
  File "/home/griffin/cl/lib/python3.8/site-packages/pytorch_lightning/utilities/device_parser.py", line 142, in _sanitize_gpu_ids
    raise MisconfigurationException(
pytorch_lightning.utilities.exceptions.MisconfigurationException: You requested GPUs: [0, 1]
 But your machine only has: [0]

Oddly enough, this only happens when I use the raylightning plugin.  Not sure what's going on

To follow up [0, 1] are both visible

Great, glad you were able to resolve the wandb issue @griff4692! I am going to close this issue, but I created a new one for your GPU error.


[Event Modification] codeunit 6500 "Item Tracking Management" OnBeforeInsertReservEntryForPurchLine

Hello,
Is it possible to add an axtra variable to an existing event:
OnBeforeInsertReservEntryForPurchLine(ReservEntry, PurchaseLine, ItemLedgEntryBuf);

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


pull request for e2e test at 12/08/2016 17:26:04

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Proof of concept microcontroller embasy support

Base embassy rust code ported to run on chosen micro controller.

I'm marking this as done, as we've gotten rust to run using embassy on actual hardware.


taskactor test timeout exception

Sometimes there are timeout in the task actor test.

Is it duplicated with #299 ?

Yes, will close this


Adding bcrypt() to helpers

bcrypt() is a function used in Laravel for hashing purposes, typically for passwords, and is not included in Lumen by default and is simply an alias for app('hash')->make(). I ran into this problem when integrating Laratrust into my Lumen project.

Thank you!


Version catalogs

Removed the buildSrc module in favour of version catalogs.
Summary of changes:

Created the libs catalog: gradle/libs.versions.toml.
Migrated all build files.
Purged buildSrc.
Made when exhaustive (See KT-47709).

@raamcosta Changes for main :)

Once again thank you for doing these @imashnake0 !
Let me know if you’re interested in contributing with more stuff. I’d be glad to help you in any way, like some general overview of the code 🙂

Once again thank you for doing these @imashnake0 !
Let me know if you’re interested in contributing with more stuff. I’d be glad to help you in any way, like some general overview of the code :slightly_smiling_face:

Thank you! I'd love to work on some core features and will keep in touch in the coming weeks.


Incorrect labels

Incorrect: https://yadi.sk/i/aqGR39mIF8_lVg, correct: Click to pause timer
Incorrect: https://yadi.sk/i/hvHeWmTm4geIsw, correct: Click to start timer
Originally posted by @Develop-FM in https://github.com/CrawlerCode/redmine-time-tracking/discussions/1#discussioncomment-6985368

Issue fixed in version v1.11.2


Support for Two Factor authentication

Is there any possiblity to add support for Two Factor authentication, with customizable two factor providers?

Since we use ASP.NET IdentityFramework, you can extend it to support 2FA. It's in our plan but may not be implemented in a very short future.


SummaryChain output cutoff

Hey guys,
Happy to use this great tool to leverage LLM. Currently I'm trying to use it to summarize articles, and it's working very well most of the time.
Sometimes the output will be cut off due to OpenAI's issue like this, but in it's official WebUI I can type "continue" to let it finish, so do we have a way to address this in Langchain?
{'output_text': '\n• Mayakovsky was a Soviet poet and playwright.\n• His most famous poem is “Clouds in Trousers”.\n• He was a Futurist poet and committed suicide at age 37.\n• His poetry reflects his pride and fragility.\n• He had a complicated love triangle with a married woman.\n• Maxim Gorky wrote the poem “Trousers of Clouds” in 1924.\n• The poem speaks of the power of love, art, system, and religion.\n• It encourages people}

Have you tried increasing max_tokens?
https://github.com/hwchase17/langchain/blob/88bebb4caa66c51ab431a76abd3aab3b1cede530/langchain/llms/openai.py#L66

@batmanscode  wow thanks, it worked.

@batmanscode  wow thanks, it worked.

Glad it worked! There's a default maximum set which gets applied if you don't specify


The marker isn't drawed

I followed the example, and the marker isn't displayed in the map.

The plugin assumes you already have the marker drawn in the map. So, please be sure you can place markers in your map first.
Nevertheless, I will be pushing a few dependencies upgrades to the example project, it may help you.
Regards,

I followed the example in the repo:
subscription =
        _latLngStream.getLatLngInterpolation().listen((LatLngDelta delta) {
      LatLng from = delta.from;
      print("To: -> ${from.toJson()}");
      LatLng to = delta.to;
      print("From: -> ${to.toJson()}");
      double angle = delta.rotation;
      print("Angle: -> $angle");
      //Update the animated marker
      setState(() {
        Marker sourceMarker = Marker(
          markerId: sourceId,
          rotation: delta.rotation,
          position: LatLng(
            delta.from.latitude,
            delta.from.longitude,
          ),
        );
        _markers[sourceId] = sourceMarker;
      });

      if (polygon.isNotEmpty) {
        //Pop the last position
        _latLngStream.addLatLng(polygon.removeLast());
      }
    });

But the marker is never displayed. Later, I tried the the location plugin, and it neither worked, then I left my code as before to use this plugin, and the marker was displayed again.

I will be publishing a new update with a clearer example and the animation of multiple markers at the same time. Be aware.
Thank you for the feedback.

I followed the example in the repo:
subscription =
        _latLngStream.getLatLngInterpolation().listen((LatLngDelta delta) {
      LatLng from = delta.from;
      print("To: -> ${from.toJson()}");
      LatLng to = delta.to;
      print("From: -> ${to.toJson()}");
      double angle = delta.rotation;
      print("Angle: -> $angle");
      //Update the animated marker
      setState(() {
        Marker sourceMarker = Marker(
          markerId: sourceId,
          rotation: delta.rotation,
          position: LatLng(
            delta.from.latitude,
            delta.from.longitude,
          ),
        );
        _markers[sourceId] = sourceMarker;
      });

      if (polygon.isNotEmpty) {
        //Pop the last position
        _latLngStream.addLatLng(polygon.removeLast());
      }
    });

But the marker is never displayed. Later, I tried the the location plugin, and it neither worked, then I left my code as before to use this plugin, and the marker was displayed again.

Can you try the new update to the plugin.

I don't need this plugin in my project.  I apologize.


Week 41: Understanding Akka Dispatchers

Please provide your feedback by posting a comment against this issue.

Hi! Thanks for the interesting read! Just one question. You wrote:
"You will notice that all 100 started at almost same time. If you run this with default configuration 24(parallelism-factor*parallelism-min) tasks will be processed in parallel."
Wouldn't this 24 come from parallelism-factor*number_of_cores? At least that's how you explained it earlier in the article:
"The number 24 comes from multiplication of number of cores on your machine with parallelism-factor. My machine has 8 cores and default value of parallelism-factor is 3 so we got 24 threads (8x3).
(...)
Let's suppose my machine had only one core then according to the calculation mentioned above I could have got 1x3 i.e. 3 threads but instead we will get 8 threads because that's the minimum number of threads default-dispatcher can have."

@wojtasskorcz yes you are right. I typed it wrong. I have fixed it. Thanks.

@shekhargulati Great post. It's easy to understand

Great post, thanks!


Push notifications (mobile)

I was just thinking, it might be nice for us to host an APNS/GCM server that mobile apps can connect to and receive push notifications for (i.e. For notifications about comments, likes, etc on the users' conduit posts).
Push notifications are part of nearly every mobile app, so I think this would be a good addition to make it "real world". Thoughts?

Also, now that parse is dead, what is the most common way to host a push noti server?

We use this to test / debug push notifications and it includes sample setup using PHP -> http://apns-gcm.bryantan.info
I'm not familiar with the node packages but should be able to do the same using package for node.
Another alternative is we can configure Firebase notifications or Ionic.io and there API can be used to send push notifications.
would this even be possible due to push noti certs? i.e. can we create a public cert that everyone could use? - I think if we do the code signing using Fastlane tools, https://github.com/fastlane/fastlane/tree/master/pem and have a readonly apple account, anyone can sign the app, test push notifications using the readonly apple account to download the needed certs.
Code signing certs will be hosted on github repo and the readonly apple account will be used to download the certs while generating a build,etc. I've done this setup for private repos i.e CI setup for mobile apps but need to lookup on public repo setup (not sure on security)

@EricSimons I would like to suggest to implement FCM notification for mobile apps.

@EricSimons
At Blend we use Amazon SNS for push notifications which works really well, but the infra setup required there might be a bit overkill for Realworld. I think OneSignal could be a good choice, it's free and there are SDK's available for Ionic/Cordova and React Native.


New testing framework

In the integration-tests, all tests are done in a single docker container, not running containers. The trick is running a process and the servers are bind to different ports of the localhost.
This is because of these two reasons:

Running a container inside container isn't recommended way of using Docker
Starting a Docker image of kvs-server was very heavy and it took unreasonable time to complete a test with large cluster

Recently, I found the second one was due to my mistake that I didn't minimize the docker image. The docker image with a Rust tool-set and others is like 2GB but when they are reduced by docker-slim, it is 20MB. Loading a 2GB image to starting a container took maybe a few seconds.
If we run each kvs-server in separate container, we can use pumba to emulate network failure. Chaos testing can also be done.
However, downside of the change could be coverage test is broken because chances are profraw files are dumped to separate container  filesystems and we can't collect them.

However, downside of the change could be coverage test is broken because chances are profraw files are dumped to separate container filesystems and we can't collect them.

It seems the profraw files are dumped under the directory that test program exists. (currently integrate-tests/cov) If so, all the profraw files will be dumped inside a tester container or host.


strong name

I managed to include the nuget package sqlite-net-pcl in my project. I signed the project and now VS complaints that sqlite-net.dll does not have a strong name. What can I do?

+1
I'm planning to fork this and strong-name sign it. Then I'll send a pull request and see if @praeclarum takes it.

Since this project seems to take a dependency on SQLitePCL.raw, this issue cannot be fixed until ericsink/SQLitePCL.raw#53 is fixed.

Linked issue on SQLitePCL.raw seems to be fixed, is it possible to fix the current issue?

So... That's a no?

No longer working on thee project would NOT know. Tanks fpr the effort though I am sure someone will profit.

@Chakotay if you closed this issue because you personally don't need it any more, would you mind reactivating it for the sake of the rest of us who are still following it?

I need to look into this - I've never signed assemblies before.

Hi any update on this strong signing.  Visual Studio 2017 Nuget seems to now require it for updated package install.  Now getting this:
Error		must be strong signed in order to be marked as a prerequisite.

@peterxme  This issue is about strong name signing. AFAIK nuget has no plans to require strong-name signing assemblies that are included in packages and can't imagine they ever would since that would be a massively breaking change to many people.
Can you share the exact error message you're seeing? The one you provided has grammatical errors and doesn't make sense (e.g. "strong signed" isn't a thing).

Can you provide the full error, including project name? Preferably the entire line from the output window or your build log. This error message makes no sense to me. "Prerequisite" isn't an msbuild, nuget, or reference term at all as far as I've ever heard. Seeing what project is producing this, and preferably what target is producing this, will help narrow down which component is producing this.

@AArnott All is needed i to add an snk file in the csproj / project properties.
This should not break anything for anyone.
It is not an issue to have a snk on nuget and people use in projects without, so it wont break anything for them.
But it is not possible to have a snk and use nugets, that dont have a snk.
yes, this is a part of MSBUILD:

I'm sorry I'm struggling to understand what you're saying, @generik0. Strong name signing is orthogonal to nuget packages. It's an assembly thing. Putting an .snk file in a nuget doesn't solve anything.
Starting to strong-name sign an assembly is a binary breaking change in that it changes your assembly name so folks would need to recompile in order to use the newer assembly.
When an assembly is strong-name signed, it will fail at runtime on the desktop .NET Framework if it references non-strong-name signed assemblies. But a strong-name signed assembly can be referenced by anyone without a problem.
Contrast this with a non-strong-name signed assembly, which cannot be referenced by strong-name signed assemblies.

HI @AArnott
I think we agree. Yes "It's an assembly thing".  "Putting an .snk" in trhe csproj does solve everything
Do you see the "sign the assemby" tick in the streenshot?

@AArnott is it possible to have an extra csproj next to the other csprojs that build a strong named version?

@generik0 To be clear, this isn't my repo. I'm advocating for signing the assembly like you.
Publishing two packages (one signed, the other not) is not a good idea generally because you'll end up with other packages depending on either of the two on nuget.org, and then an app that wants both of these other packages will end up with major issues when the same sqlite-net library is brought in by two packages.
IMO, the best way forward is to start strong-name signing it with the next "major" version.

Any update on this? Thanks.

Any update on this @praeclarum

We just ran into this issue today and unfortunately it looks like it's a show stopper for anyone trying to use this package with an app that's strong name signed. Hopefully you are able to complete this issue, and it should not be a major effort. Thanks for all the effort in supporting this package.


Symbol kind needs to use location before falling back to flags

Fixes #22366

Can you also add a test

tests/cases/fourslash/completionOfInterfaceAndVar.ts is the test? Do you need another one.

Did not see that one. sorry about that.


Endpoint /tasks returns 404 when serving locust under non-root path

Describe the bug
Our server hosts several applications, so I'm hosting locust service under the <hostname>/locust URL. Locust looks good at first, but the /tasks request are all failing at the background with a 404 response.
Expected behavior
Page loads without error. Backend calls respects the base path.
Actual behavior
/tasks requests are going to wrong path. Requests are sent to <hostname>/tasks, but they should go to <hostname>/locust/tasks. If I manually navigate to <hostname>/locust/tasks, then it works fine, but locust frontend sends the requests to wrong path.

Steps to reproduce

Environment

OS: Docker
Python version:
Locust version: 2.8.5
Locust command line that you ran:
Locust file contents (anonymized if necessary):

Hi! Do you need more information on this issue?

I think this is related to #2030
The leading ./ in all links looks weird to me. If you can, then try removing it and see if it helps.
Doing that may cause issues for k8s users (as mentioned there), but I think it is not really the right solution.

Closing this as duplicate to keep the conversation in one place


How to visualize the predicted results of your model on scannet?

Thanks for your great work. How to visualize the predicted results of your model on scannet?

I will update the steps in README later. Before that, you could refer to ./tools/vis_scannet.py.

Thank you for your excellent research.
Could you provide how to visualize the predicted results of your model on S3DIS and scannet?
Thank you


[ENH] Update CI/CD workflows to work within community contributors' PRs

Some of our actions require extra secrets to be set in order to work (e.g. Kubernetes tests and cloud providers). Due to this, in the scenario where a new contributor forks the repo, any changes to the future PR will not fail the mentioned test, blocking some pipelines and the reviewing process.
Task

Review current test structure to avoid such scenario

Success criteria

The contributor should be able to open a PR to Quansight/qhub.git@main from a fork, and the tests should all run, without requiring extra configurations.

This was fixed in #1563


REPLAY-1478 SR - add capability to record Steppers

What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report

Merging #1360 (f1c4fdb) into feature/session-replay (ec2568c) will increase coverage by 0.12%.
The diff coverage is 98.00%.

@@                    Coverage Diff                     @@
##           feature/session-replay    #1360      +/-   ##
==========================================================
+ Coverage                   83.34%   83.46%   +0.12%
==========================================================
  Files                         385      387       +2
  Lines                       13367    13517     +150
  Branches                     2165     2179      +14
==========================================================
+ Hits                        11140    11281     +141
- Misses                       1555     1563       +8
- Partials                      672      673       +1

Impacted Files
Coverage Δ

...ernal/recorder/mapper/MaskAllNumberPickerMapper.kt
85.71% <85.71%> (ø)

...lay/internal/recorder/mapper/NumberPickerMapper.kt
98.46% <98.46%> (ø)

...adog/android/sessionreplay/SessionReplayPrivacy.kt
100.00% <100.00%> (ø)

... and 15 files with indirect coverage changes


Create bazel-contrib/rules_cuda

There are bazel rules for compiling CUDA code in various places:

TensorFlow toolchain with CUDA and ROCm support: https://github.com/tensorflow/tensorflow/tree/master/third_party/gpus/crosstool
NVIDIA's Isaak SDK has a cleaned up and improved version of the above: https://developer.nvidia.com/isaac-sdk
TFRT rules_cuda repository patching bazel's cc_toolchain to add 'cuda' feature: https://github.com/tensorflow/runtime/tree/master/third_party/rules_cuda
@cloudhan's rules_cuda repository with contributions from @ryanleary: https://github.com/cloudhan/rules_cuda
https://github.com/dropbox/dbx_build_tools/blob/fe5c9e668a9e6951970c0595089742d8a0247b8c/build_tools/cc/BUILD.drtev3
https://github.com/BalderOdinson/rules_cuda
There are also some closed-source CUDA rules by NVIDIA and Uber.

I'm opening this issue to gauge interest in adding rules_cuda to bazel-contrib (see also https://github.com/bazelbuild/bazel/issues/6578) as a collaborative effort of the owners of the above repositories. Likely we would also need some design input from bazel rule experts.
https://bazelbuild.slack.com/ seems to be the appropriate place to discuss this. I've start a thread there and will report back here.

FYI. Here is information on how to add a repo under bazel-contrib.
Hosting Policy

As an example, the last ruleset we added just put the answers to the policy doc in the issue: https://github.com/bazel-contrib/SIG-rules-authors/issues/51

Must use an open-source license, preferably Apache-2.0.

Will be MIT as basing on existing repo that is licensed under MIT.

Must have wide applicability in the community.

CUDA is one of the most popular languages for programming NVidia GPUs. It is widely used in the AI / ML and HPC communities and is already in use in projects built by bazel (e.g. tensorflow, NVidia Isaac)

Must have a clear point of contact who answers questions from the SIG.

I can be the POC as I already attend the meetings.

Must be “production quality”:
clear README or other documentation outlining the goal of these rules, how to use them etc.
generated API documentation
include examples of use
tests that are running continuously

We're starting from the existing repository at https://github.com/cloudhan/rules_cuda which provides these.
https://github.com/cloudhan/rules_cuda_examples has some more complex examples of use and these examples could be migrated into this repo.

Must reply to issues/PRs in 2-3 weeks (exact service level agreement TBD)
Must have more than one person who is committed to review/approve PRs
We recommend encoding this as a CODEOWNERS file.

@jsharpe @chsigg @cloudhan and @ryanleary will be the intial code owners.
Will make a CODEOWNERS to add to the repo once its migrated.

Must publish semver releases.
Optional: follow the same release pattern as the rules-template does.

Will follow that release pattern.

Must work with LTS Bazel version

Does work with the current LTS releases. @fmeum has offered assistance in getting bzlmod support in place.
Note that there are some identified limitations with the Nvidia nvcc compiler that would benefit from having some undocumented flags flipped i.e. --experimental_use_hermetic_linux_sandbox.

At the Bazel Rules SIG meeting on 2022-11-01, approved the inclusion of rules_cuda under bazel-contrib.


refactor(transaction): error handling

Fixes #325

[ ] Tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[x] Appropriate docs were updated (if necessary)

/cc @eric4545

@callmehiphop @crwilcox just checking in on where this one is :)

Seems like CI is choking since merging #400 into master. Waiting on #441 to resolve said issues.


Delete connection refused device info from netDB

Description
The Edge Orchestrator deletes the offline device info from netDB if RTT fails twice in a row.
This PR sets the RTT value to a negative when RTT first fails, and deletes device information if RTT fails consecutively.
Fixes #109
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Set up a connection between devices.
Check logs after keeping a device offline

2020/07/20 06:28:58 helper.go:99: [http://<IP_ADDRESS>:56002/api/v1/ping] reqeust get failed !!, err = Get "http://<IP_ADDRESS>:56002/api/v1/ping": dial tcp <IP_ADDRESS>:56002: connect: connection refused
2020/07/20 06:28:58 roundtriptime.go:84: Get "http://<IP_ADDRESS>:56002/api/v1/ping": dial tcp <IP_ADDRESS>:56002: connect: connection refused
2020/07/20 06:29:03 helper.go:99: [http://<IP_ADDRESS>:56002/api/v1/ping] reqeust get failed !!, err = Get "http://<IP_ADDRESS>:56002/api/v1/ping": dial tcp <IP_ADDRESS>:56002: connect: connection refused
2020/07/20 06:29:03 roundtriptime.go:84: Get "http://<IP_ADDRESS>:56002/api/v1/ping": dial tcp <IP_ADDRESS>:56002: connect: connection refused
2020/07/20 06:29:03 roundtriptime.go:65: resourceutil Delete edge-orchestration-f323e2a4-624b-4eb7-8da2-a6b9b2813415

Test Configuration:

Firmware version: Ubuntu 16.04
Hardware: x86-64
Edge Orchestration Release: Baobab

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

@suresh-lc Even if the devices lost their connection, they try to look for neighbors
periodically via Advertisement() or deviceDetectionRoutine() of the discovery mangager.
I've tested the scenario with 2 devices on ubuntu and on RPi and it works well.


Chatter Free users cannot upload files

Hello,
Once FileExplorer is installed, our users with the Chatter Free license receive an error when uploading/attaching a file in Chatter.
From the AfterUpdate trigger:
caused by: System.QueryException: Insufficient permissions: secure query included inaccessible field
Class.qsyd_FE.qsyd_ContentDocumentTriggerHandler.afterUpdate: line 59, column 1
Class.qsyd_FE.TriggerHandler.run: line 56, column 1
Trigger.qsyd_FE.ContentDocumentTrigger: line 14, column 1
Since these users cannot be assigned permission sets, can they be excluded altogether from the Trigger?
Thanks!
Justin K.

Same issue here

We have the same issue but with Partner Experience users... File section is not working anymore at all for them.

We have the same issue but with Partner Experience users... File section is not working anymore at all for them.

Update: The newest version of Lightning File Explorer seems to solve the problem. The update did the trick.

Hey @justinkkirkland and @derroman ,
In the latest release you have the ability to bypass the trigger logic based on login in this method -
Feel free to include a list of profiles to exclude such as the Chatter Free/Plus Profiles etc.
ta
Paul


Test plugin creation

Does the developer documentation still applies? And does the resulting component work if the documentation is followed?

Tested, managed to get a working cluster.


Add integer choices support

Add cast option
Add make dev command to create development environment
Add requirements.dev.pip (for development environment)
Add new classifiers to setup.py
Add Python 3 unicode compatibility
Fix Tox fu**** WARNING:test command found but not installed in testenv
Improve README

:+1:


Password exposed in command line on Mac

On Mac, the use of the security utility to add a generic password to the Keychain insecurely passes the password on the command line, allowing any other process on the system to observe the password. To make it more secure, pass the password on STDIN to security or use the Keychain API directly.

I should add: another benefit of using the Keychain API is that in the event that the Keychain is locked, the user can more easily see which app is requesting to unlock the Keychain, instead of just the security utility.

:memo: using Keychain API may be worrying developers...
ref: https://github.com/99designs/keyring/issues/56

@szuecs This seems like it should be a priority issue to address, yet it's been over a year since reported without a maintainer commenting on the issue. Is there some reason the Zalando team considers password leakage to not be a problem, for a library which is supposed to be enabling the secure storing of credentials?

@intel352 There are from my side a few considerations:

attack vector is minor (list local processes required and if you have that access you can likely do something else to get the password)
I don’t have a Mac since almost 10y
there are Open pull requests that seem to be stale by contributors and good suggestions, that I can’t test nor develop without Mac: https://github.com/zalando/go-keyring/pull/26#discussion_r307974237

If that’s too complicated you can also try a tty based write to the console to not leak the cli params.
I am happy to review pull requests for the project.

@szuecs as you don't have a mac, what about pulling in another lib that is geared at osx, such as https://github.com/keybase/go-keychain ?

@intel352 from my side it’s fair enough if you would do. @mikkeloscar or I can test Linux.

Note that go-keychain requires cgo.


:sparkles: Add ToggleSwitch component & Giant Arrow logic

With the introduction of the Giant Arrow many clashers might want to use a combination of zaps and quakes, in conjunction with the Giant Arrow, to take down important structures of an enemy base.
This MR adds the optional functionality for calculating zapquakes in conjunction with the Giant Arrow.
This functionality is off by default.
Features

Level Input for queen's Giant Arrow
toggle-switch for enabling and disabling the use of the Giant Arrow
adjust zapquake calculation to include the Giant Arrow

Additional information

With the December 2023 update Clash of Clans introduced Hero Equipment.
One of the Archer Queen's Equipment pieces is the Giant Arrow.
When activated the Giant Arrow flies in a straight path across the base and damages everything along its path.
The Giant Arrow can be especially useful for removing or damaging key defenses. While the Giant Arrow does quite a lot of damage on its own many buildings will need additional zaps and/or quakes to be taken down.
https://clashofclans.fandom.com/wiki/Giant_Arrow
Comments
I don't have any prior experience with React or Tailwind so some solutions might be suboptimal.
The Toggle Switch is fine, but could be designed in a nicer way.
There might be a more intuitive / overall better solution for turning on and off the Giant Arrow functionality.

Hello, thank you for your MR ! It is much appreciated.
I haven't been on my computer for a couple of months due to personal reasons, but I will take time to review your contribution as soon as I can.
Thank you


Console Error on change value on picker

A SemanticsNode with action "increase" needs to be annotated with either both "value" and "decreasedValue" or neither
'package:flutter/src/semantics/semantics.dart':
Failed assertion: line 1885 pos 7: '!_canPerformAction(SemanticsAction.decrease) || (_value == '') == (_decreasedValue == '')'
List<String> _genders = <String>['', 'Uomo', 'Donna'];
RaisedButton(
              child: Text('Picker Show Modal'),
              onPressed: () {
                showPickerModal(context);
              },
            ),
showPickerModal(BuildContext context) {
      new Picker(
        adapter: PickerDataAdapter<String>(pickerdata: _genders),
        changeToFirst: true,
        hideHeader: false,
        onConfirm: (Picker picker, List value) {
          print(value.toString());
          print(picker.adapter.text);
        }
      ).showModal(this.context); //_scaffoldKey.currentState);
    }

same issue


Hash newtypes that only hash one type of data should have a From impl

For example, all these:
        /// A hash of a public key.
        pub struct PubkeyHash(hash160::Hash);
        /// A hash of Bitcoin Script bytecode.
        pub struct ScriptHash(hash160::Hash);
        /// SegWit version of a public key hash.
        pub struct WPubkeyHash(hash160::Hash);
        /// SegWit version of a Bitcoin Script bytecode hash.
        pub struct WScriptHash(sha256::Hash);

should have implementations using From for the types they are supposed to has. So you can use pk.into() to provide a WPubkeyHash, f.e..

Should also work for references and, in case of script support &Script, ScriptBuf and &ScriptBuf.

Ah yes, nice. Thanks.

Turns out this issue was totally bogus, not the fault of the original author at all but in fact an epic win for those of use who are anal about code layout, if the From impls had have been near the type definitions it would have been immediately clear what was implemented. #1914 now moves the hash type defitintions around, this is in line with the recent pushes to remove "container" modules (util, hash_types).

Well, I hope this shows that opening issues based on reading the code instead of generated documentation is not great...

I think it's an argument for #1880.


SAK-38320 add scope to matrix table

Sorry if I missed it: where in the changed code does the "td"s get changed to "th"s (as mentioned in SAK-38320)?

tds are not changed to th in this PR

The description in the JIRA references changing tds to ths. I thought that was the purpose of the ticket.

I believe scope was the real intent


Provide a way to configure AAD_INSTANCE_DISCOVERY_ENDPT

Core Library
MSAL.js v2 (@azure/msal-browser)
Wrapper Library
Not Applicable
Public or Confidential Client?
Public
Description
Right now, the default endpoint is https://login.microsoftonline.com/common/discovery/instance?api-version=1.1&authorization_endpoint=
It works perfectly for public cloud customers.
But it might cause issues for non-public cloud customers as they want to block all the .com website.
Can we provide a way to customize this value when creating the MSAL instance?
Source
Internal (Microsoft)

Hi @tnorling , I understand that we can provide the metadata. But I feel provide a way to config the endpoint is more flexiable. What's your opinion?

We intentionally do not expose a way to provide an arbitrary endpoint for security reasons. Providing the metadata statically is the recommended practice if you need to support environments where the discovery endpoint is not available.


Performance Profiling task can not be removed from task list

Please answer these questions before submitting your issue.

Why do you submit this issue?
[ ] Question or discussion
[ *] Bug
[ ] Requirement
[ ] Feature or performance improvement

Question

What do you want to know?
Performance Profiling task can not be removed from task list

Bug

Which version of SkyWalking, OS and JRE?
skywalking 8.1.0

Which company or project?

What happened?
If possible, provide a way to reproduce the error. e.g. demo application, component version.
add new task in Performance Profiling task list ,then find no way to delete it like below picture

Requirement or improvement

how can I remove useless tasks in task list.

Why keep submitting things? I have replied in the previous one.


Major issue!

Hello, today i was trying out your library, when i encountered this error:
Uncaught TypeError: Cannot read property 'addEventListener' of null
    at C:\Users\ilink\source\repos\BotBuilder\Frontend\node_modules\bootstrap-validate\dist\bootstrap-validate.js:1
    at Array.forEach (<anonymous>)
    at t.exports (C:\Users\ilink\source\repos\BotBuilder\Frontend\node_modules\bootstrap-validate\dist\bootstrap-validate.js:1)
    at buildInstructionArgs (instructions.js:30)
    at getInstructionTypes (addinstruction.html:71)
    at addinstruction.html:12

This confuses me because i've already created the element with javascript, and it has been given an ID.
For some context i'm also using electron.js.
If anyone has had this issue and have fixed it, please tell me!
Thanks in advanced,
iLinked

Hey there,
the package should only work in the rendering context. Can't think of another reason why it shouldn't work in electron.


Apply CC-BY-SA 4.0 license to the FINOS InnerSource Special Interest Group InnerSource repository

Description
This pull request adds and updates the following files to apply the CC-BY-SA 4.0 license to the FINOS InnerSource Special Interest Group InnerSource repository.
Note : The initial PR review should me made by @copiesofcopies before merging into the InnerSource repo.

Add file LICENSE-CC-BY-SA-4.0 with LICENSE-CC-BY-SA-4.0 license text.
Update LICENCE.spdx to reflect licenses that have been applied to the InnerSource repository.
Update README.md to reflect LICENSE-CC-BY-SA-4.0 and APACHE 2.0 licenses.
Remove Daniela Zheleva (@daniela-g-zheleva-db)  from README.md as InnerSource SIG co-lead.

LICENCE.spdx Update
The following is the updated LICENCE.spdx content.
{
    "SPDXVersion": "SPDX-2.0",
    "DataLicense": "CC0-1.0",
    "Creator": "FINOS, The Fintech Open Source Foundation",
    "PackageName": "InnerSource Special Interest Group",
    "PackageOriginator": "FINOS, The Fintech Open Source Foundation",
    "PackageHomePage": "https://github.com/finos/innersource",
    "PackageLicenseDeclared": ["CC-BY-SA-4.0", "Apache-2.0"]
}

Note: The format of LICENCE.spdx was changed to non json as part of https://github.com/finos/InnerSource/pull/39#discussion_r735666760
SPDXVersion: SPDX-2.2
DataLicense: CC0-1.0
Creator: FINOS, The Fintech Open Source Foundation
PackageName: InnerSource Special Interest Group
PackageOriginator: FINOS, The Fintech Open Source Foundation
PackageHomePage: https://github.com/finos/innersource
PackageLicenseDeclared: CC-BY-SA-4.0 AND Apache-2.0

Probably should use the standard REUSE formatting for the licenses: https://reuse.software/tutorial/

And worth adding an issue to aim to add the Reuse helper tool (https://reuse.software/tutorial/#step-3) as a GitHub action (if possible) to automatically check compliance on commits.

And worth adding an issue to aim to add the Reuse helper tool (https://reuse.software/tutorial/#step-3) as a GitHub action (if possible) to automatically check compliance on commits.

Hi @godds - Feel free to add this feature to the issue suggested to @vmbrasseur above 👍🏻
https://github.com/finos/InnerSource/issues/new?assignees=&labels=&template=Feature_request.md


example f_min.py DIRECT error

Hi,
seems like i have a similar problem with the DIRECT library. Running RoBO on a virtual x64 ubuntu machine using python3.4 within a venv. Any ideas what I can do? example_blr.py runs...
...
INFO:robo.solver.bayesian_optimization:Maximize acquisition function...
Call-back cb_fcn_in_direct__user__routines failed.
Traceback (most recent call last):
File "example_fmin.py", line 22, in
results = bayesian_optimization(objective_function, lower, upper, num_iterations=50)
File "/home/student/Documents/venv/RoBo/lib/python3.4/site-packages/RoBO-0.2.1-py3.4.egg/robo/fmin/bayesian_optimization.py", line 133, in bayesian_optimization
File "/home/student/Documents/venv/RoBo/lib/python3.4/site-packages/RoBO-0.2.1-py3.4.egg/robo/solver/bayesian_optimization.py", line 167, in run
File "/home/student/Documents/venv/RoBo/lib/python3.4/site-packages/RoBO-0.2.1-py3.4.egg/robo/solver/bayesian_optimization.py", line 245, in choose_next
File "/home/student/Documents/venv/RoBo/lib/python3.4/site-packages/RoBO-0.2.1-py3.4.egg/robo/maximizers/direct.py", line 69, in maximize
File "/home/student/Documents/venv/RoBo/lib/python3.4/site-packages/DIRECT/init.py", line 202, in solve
cdata
ValueError: data type must provide an itemsize
Thanks,
Stephan

Hi, the problem is that by default we suppress DIRECTs output to unclutter RoBOs console output. It seems that this leads to problems on some OS systems. I changed RoBOs default verbosity level such that it prints DIRECTs output.

Hi,
thanks for the tip. It didn't resolve the error though... Must be an issue on my machine.


The model did not return a valid JSON object

The problem with using the LLAMA-2-7B-FP16 model, can someone help solve it?Thanks~~

Hi,
This is a known issue tends to arise with smaller models, also mentioned in #27
We are currently running some experiments to see which small model provides decent performance #41 .
-V

你好
这是一个已知问题，较小的模型往往会出现，#27 中也提到我们目前正在进行一些实验，看看哪个小模型提供了不错的性能 #41 .一旦有希望的结果，将在该线程中发布更新。 -V
Is there no suitable way to solve it at present？This can not return a valid JSON object, is it because the JSON format is not correct or other reasons？I hope to be able to use the local small model to achieve this function, currently still doing some code changes, hope to get your more detailed answers and analysis to have new ideas, thank you ~


Add Keyman input engine guide, update credits, and small rewording

Added Keyman input engine guide for Windows, MacOS, Android, iOS (and iPadOS. ijo li sama), and web browser[1].
Add references to Keyman section in Windows, MacOS, Android, iOS, and Web input method sections[2]. + Incremented number of methods/engines available in each platform's input method guide.
Added list of suggested Keyman keyboard layouts.
Added credits for Keyman layouts to ijo pona.
Added credits for nasin sitelen Wakalito and its font to ijo pona.
Added credit for Fairfax HD in the Fonts section.
Fixed small spelling mistake in recommended fonts section.

I'd add Linux instructions, taso nasin iBUs en nasin Fcitx li ike tawa nasin Sway mi. mi wile ala Xorg e ilo mi.
I tried to word the references to the Keyman section to work in the context each section uses. Every platform's input method wording and introduction feels different! I'd like this guide to be more readable, but that belongs in a different pull request.

pona tawa sina a • niko o!


Script didn't work until I added New-PSDrive declaration

FYI, I was getting errors any time the Set-Location cmdlet tried to change to the CMSite provider location because a PSDrive for that provider had never been established.  I added the missing New-PSDrive logic at the appropriate location in the main script and everything is good now.

Hmm, I've never run into that issue, but I think i have heard of it. Did you ever open the Console with the user that was running the script?
Regardless, is the command you ran something like this:
new-psdrive -Name $SiteCode -PSProvider "AdminUI.PS.Provider\CMSite" -Root "$ENV:ComputerName" -Description "SCCM Site"
Please let me know and I will add it to the script.   I probably just installed the console to get the PS modules and then went straight to testing your scripts.
I'm not running the script on my site server, so my code is slightly different from yours, but yes that's the basic idea.

Awesome! That is exactly what I needed. Thank you!

This is a super impressive solution.  I had done some similar automation for just one or two apps in my org a while ago, but the way you've generalized this and started a community repo for these "recipes" is fantastic.  Do you have a blog about this solution I can point people to, or is this GitHub page the best thing to share?

Thank you, that means a lot! I took inspiration from the autopkg project for Mac https://github.com/autopkg/autopkg and kinda ran with it. I have not blogged about it yet (I plan to do that when I get some time someday), however, I did present on it at the latest AZ Systems Management User Group meeting here: https://miketerrill.net/2019/05/14/azsmug-presents-intune-rbac-graph-autopilot-and-more/ besides that, the github is the best place to point people for sure, and I have a link to my presentation slides here: https://github.com/asjimene/miscellaneous-tools/tree/master/AZSMUG-5-2019
If you have any suggestions, feel free to let me know!

Not sure if you're aware, but PatchMyPC (which is a great product, and we use it at my company) is working on doing something very similar to this, but they're charging extra for it.  Not to mention their first draft effort is creating packages, not applications.    Thanks for sharing!

I did not know about that! I have heard about PatchMyPC and they seem like a great product, would probably simplify my job quite a bit lol. That is very interesting indeed! You are welcome, I have gotten so much knowledge an tools from the community, I figured I could give back as well!

They hope to have the applications based deployments out by MMS Jazz Edition. I currently use them for patching, but have this run every morning for my apps.
I've created some extra recipes I need to submit up-channel.
--
Andrew

From: Andrew Jimenez<EMAIL_ADDRESS>Sent: Thursday, May 30, 2019 1:37 PM
To: asjimene/SCCM-Application-Packager
Cc: Subscribed
Subject: Re: [asjimene/SCCM-Application-Packager] Script didn't work until I added New-PSDrive declaration (#5)
I did not know about that! I have heard about PatchMyPC and they seem like a great product, would probably simplify my job quite a bit lol. That is very interesting indeed! You are welcome, I have gotten so much knowledge an tools from the community, I figured I could give back as well!

You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/asjimene/SCCM-Application-Packager/issues/5?email_source=notifications&email_token=AINLL5GJ3ZMIBCDNRCQ2RHTPYANIJA5CNFSM4HRGAGK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWTE2EQ#issuecomment-497437970, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AINLL5EHNTYYKIQ7DEOSBKTPYANIJANCNFSM4HRGAGKQ.


chore(Distribution/SchwartzSpace): remove unused have

Let's see if bors puts this before or after #11606...


Pagination is being shown over the map sometimes

STR

Do a query wich gives you no data
Go back to the map
Change the query to one which gives you some data
The pagination will be shown.

Those STR worked for me, but I've also found the following, which also make the pagination appear over the map:
STR

Create a map from a dataset (I used populated places from data library)
Apply an AOI analysis
Open the table preview
Go back to the map
Change analysis parameters (radius, for example)
Run analysis

current result
pagination appears over the map as soon as the analysis is finished
expected result
pagination should only appear over the table preview
cc/ @arianaescobar

This should be already fixed, could you check it please?

yes, it's fixed. closing


Mention ProjectSettings won't be affected by convert_text_resources_to_binary

See https://github.com/godotengine/godot/pull/90999#issuecomment-2082097234
Fixes https://github.com/godotengine/godot/issues/90981

Thanks!


Update to JS API 4.2

;-)

or 4.3

Closed at https://github.com/Esri/geodev-hackerlabs/commit/351613525519c52201e70a3ba830ba9b43afa831


Initialize the failure file

Closes: https://github.com/GoogleCloudPlatform/google-cloud-php/issues/1298

Yeah, I'm okay with that


Add a canonical URL meta tag

This is built from the base_path of the content item which means it strips out any query parameters or fragments.
Trello Card

Would this be for every page? I don't know a huge amount about govuk_publishing_components so I may be wrong but off the top of my head pages like https://www.gov.uk/foreign-travel-advice/thailand/safety-and-security have different path to base_path (basically any with a prefix base_path)

@kevindew Yeah, I think it should be for every page. I did have a think about whether to use base_path or take the request page. I stuck with base_path as I think that's actually a better definition of the canonical URL, in the case of foreign travel advice I think you could argue that it makes sense for /foreign-travel-advice/thailand to be the canonical URL for /foreign-travel-advice/thailand/safety-and-security but of course we have a problem when the canonical URL ends up being /government. Do you think it would be better to use the request path?

Might be worth talking to a content designer about this?  Mainstream guides have a bunch of parts with the same base path but different slugs.  Some are more coherent as a single entity than others.  I'd recommend Jon Sanger

@kevindew In terms of query strings, we've decided that content where the user can filter shouldn't be index and that's covered in https://trello.com/c/PHjO8hP2/139-noindex-pagination-from-external-search-2. Smart answers uses paths not query strings to indicate content so that shouldn't be a problem.
I'm more in favour of using the request path now as the canonical URL, but it's true that applying this to all pages there are inevitably cases where either option doesn't work and could cause harm. We could have logic in the component that understands how to build the canonical URL of different document types, but that does feel better suited in the individual frontend apps.
Based on this and our earlier discussion on Slack @bevanloon and @tijmenb what do you think?

(For context, @kevindew, my initial idea was to have a blacklist of query parameters we know that we want to remove from the request URL to build a canonical URL (i.e. utm_) and then leave the rest untouched, meaning we get a slight improvement on the situation now and we can add to that blacklist as we see fit.)

okey doke, cool re query strings.
If we use request path it feels like it's sufficiently dumb it might not provide much value to me. As it stands google uses sitemap to work out what it thinks is the canonical path so I can't imagine it's getting caught mistaking analytics parameters often and then that means if we have instances of rendering same content on multiple pages they'll be flagged as having different canonical paths.
Sorry Tom, I know I'm getting more caught up in the value of the task than the implementation which isn't particularly helpful.

I'm away today but let's chat tomorrow how this would work. If it's an optional thing it might be better to implement per-app anyway, it's more explicit. I'm not sure apps would know whether or not to add the tag currently.


New release for OpenSSL 3.x compatibility

Seeing failures in gems that have this as a dependency because of the OpenSSL 3.x compatibility issue that has already been fixed in main.  Can we get a new release so that these other gems can pull in this fix?

hi @mwrock anything I can do to help here? I maintain a few gems including httpi that have a dependency on this. Happy to help with some chores like pushing new rubygems releases - if you are open to it

There is also another related issue w/ openSSL3. Proposed a PR here - https://github.com/WinRb/rubyntlm/pull/63
Would love for a new release with both the fixes if possible 🙏🏾

Hi. I am helping out with this gem now. I've been trying to clear out a few cobwebs and will attempt to cut a release today.

Released v0.6.4 with a few fixes including openssl3 related ones. I've confirmed this addresses issues we were seeing in the httpi test suite, e.g. https://github.com/savonrb/httpi/issues/243
closing as resolved, thanks for your patience everyone.


Update libs

general update of npm libs
geoserver stable rotation

@chrismayer :pray:

Just saw this issue https://github.com/meggsimum/geoserver-node-client/issues/128

I fear yes...by stating that we support GeoServer 2.23 we have a breaking change in the library since GeoServer apparently changed the API (see #128). So I'd suggest to either split this PR and seperate the update of npm dependecies so we can easily postpone the GeoServer version rotation. Or you leave the PR as it is and we wait for the merge until GeoServer 2.22 has reached its end of life.
What do you think @hblitza ?

DOCS_HOME.md needs also an update, if we stick to GeoServer version rotation in here.

@hblitza since I created a PR (#130) to fix #128 we could do the GeoServer rotation in here and merge this once #130 is merged and you updated the DOCS_HOME.md.

@chrismayer please check

Thanks for this @hblitza , I am going to merge now.


Recent nightly rustfmt broke compatibility with stable rustfmt

Hi, I hope this is the right channel to discuss an issue I'm having with rustfmt nightly. In my team, we format our code with cargo +nightly fmt, as we use some nightly-only features. Our CI doesn't have the nightly toolchain installed, but this hasn't caused us any issue (so far) since the format produced by nightly rustfmt has been backwards-compatible with stable.
However, this stopped working on Monday. nightly-2022-05-20 formats the code in a way stable rustfmt rejects. Here is an example of change in the formatting which is only compatible with nightly rustfmt:
         repo_conn.run(move |conn| {
             let is_live = matches!(bot_kind, ClientBotUserKind::Live);
-            let rows = client_bot_role::table
-                .select((client_bot_role::name, client_bot_role::approval_needed))
-                .filter(
-                    client_bot_role::is_live.eq(is_live).and(
+            let rows =
+                client_bot_role::table
+                    .select((client_bot_role::name, client_bot_role::approval_needed))
+                    .filter(client_bot_role::is_live.eq(is_live).and(
                         client_bot_role::client_id
                             .is_null()
                             .or(client_bot_role::client_id.eq(client_id.uuid())),
-                    ),
-                )
-                .load::<(String, bool)>(conn)?;
+                    ))
+                    .load::<(String, bool)>(conn)?;

This happens even without any unstable rustfmt flag.
How can I check what precisely changed in Monday's nightly, so I could track down the change which created this issue?

Thank you for reaching out. Could I ask you for two things:

Please provide a direct, minimal repro (not just a git diff or --check output)
Please clarify which versions you are using, both stable and nightlies (you mentioned Monday, but then a nightly version that's a month+ old)

Hey @fbecart you might consider checking the 1.5.0  CHANGELOG If none of those options work, you might need to use git-bisect to pinpoint the commit.
When you have a moment could you also update the description with any configuration options you might be using since you mention that you're using some nightly-only features and it would be good to know which ones.

Please provide a direct, minimal repro (not just a git diff or --check output)

I'd also like to see this. diffs are great, but I've found having pre and post formatting snippets to be a little easier to work with. Considering that you mention an issue between nightly/stable it would be nice to see:

the original input snippet
how stable rustfmt formats the snippet
how nightly rustfmt formats the snippet

you might consider checking the 1.5.0 CHANGELOG If none of those options work, you might need to use git-bisect to pinpoint the commit.

Let's just start with the snippets :wink: We can investigate on our end but there's a good amount of complexity trying to map commits in our repo to nightly versions given the release process and I'm not sure how readily map-able that'll be for end users.

Thanks for the fast answer.
I bisected the nightlies. The first nightly which has the issue is nightly-2022-06-15 (nightly-2022-06-14 is fine).
stable/nightly-2022-06-14:
impl NotificationRepository {
    fn set_status_changed(
        &self,
        repo_tx_conn: &RepoTxConn,
        rid: &RoutableId,
        changed_at: NaiveDateTime,
    ) -> NukeResult<Option<NotificationStatus>> {
        repo_tx_conn.run(move |conn| {
            let res = diesel::update(client_notification::table)
                .filter(
                    client_notification::routable_id.eq(DieselRoutableId(rid.clone())).and(
                        client_notification::changed_at
                            .lt(changed_at)
                            .or(client_notification::changed_at.is_null()),
                    ),
                )
                .set(client_notification::changed_at.eq(changed_at))
                .returning((
                    client_notification::id,
                    client_notification::changed_at,
                    client_notification::polled_at,
                    client_notification::notified_at,
                ))
                .get_result::<(Uuid, Option<NaiveDateTime>, Option<NaiveDateTime>, Option<NaiveDateTime>)>(conn)
                .optional()?;

            match res {
                Some(row) => {
                    let client_id = client_contract::table
                        .inner_join(client_notification::table)
                        .filter(client_notification::id.eq(row.0))
                        .select(client_contract::client_id)
                        .get_result::<Uuid>(conn)?;

                    Ok(Some(NotificationStatus {
                        client_id: client_id.into(),
                        changed_at: row.1,
                        polled_at: row.2,
                        notified_at: row.3,
                    }))
                }
                None => Ok(None),
            }
        })
    }
}

nightly-2022-06-15:
impl NotificationRepository {
    fn set_status_changed(
        &self,
        repo_tx_conn: &RepoTxConn,
        rid: &RoutableId,
        changed_at: NaiveDateTime,
    ) -> NukeResult<Option<NotificationStatus>> {
        repo_tx_conn.run(move |conn| {
            let res =
                diesel::update(client_notification::table)
                    .filter(client_notification::routable_id.eq(DieselRoutableId(rid.clone())).and(
                        client_notification::changed_at
                            .lt(changed_at)
                            .or(client_notification::changed_at.is_null()),
                    ))
                    .set(client_notification::changed_at.eq(changed_at))
                    .returning((
                        client_notification::id,
                        client_notification::changed_at,
                        client_notification::polled_at,
                        client_notification::notified_at,
                    ))
                    .get_result::<(Uuid, Option<NaiveDateTime>, Option<NaiveDateTime>, Option<NaiveDateTime>)>(conn)
                    .optional()?;

            match res {
                Some(row) => {
                    let client_id = client_contract::table
                        .inner_join(client_notification::table)
                        .filter(client_notification::id.eq(row.0))
                        .select(client_contract::client_id)
                        .get_result::<Uuid>(conn)?;

                    Ok(Some(NotificationStatus {
                        client_id: client_id.into(),
                        changed_at: row.1,
                        polled_at: row.2,
                        notified_at: row.3,
                    }))
                }
                None => Ok(None),
            }
        })
    }
}

Diff:
         changed_at: NaiveDateTime,
     ) -> NukeResult<Option<NotificationStatus>> {
         repo_tx_conn.run(move |conn| {
-            let res = diesel::update(client_notification::table)
-                .filter(
-                    client_notification::routable_id.eq(DieselRoutableId(rid.clone())).and(
+            let res =
+                diesel::update(client_notification::table)
+                    .filter(client_notification::routable_id.eq(DieselRoutableId(rid.clone())).and(
                         client_notification::changed_at
                             .lt(changed_at)
                             .or(client_notification::changed_at.is_null()),
[...]
-                    ),
-                )
-                .set(client_notification::changed_at.eq(changed_at))
-                .returning((
-                    client_notification::id,
-                    client_notification::changed_at,
-                    client_notification::polled_at,
-                    client_notification::notified_at,
-                ))
-                .get_result::<(Uuid, Option<NaiveDateTime>, Option<NaiveDateTime>, Option<NaiveDateTime>)>(conn)
-                .optional()?;
+                    ))
+                    .set(client_notification::changed_at.eq(changed_at))
+                    .returning((
+                        client_notification::id,
+                        client_notification::changed_at,
+                        client_notification::polled_at,
+                        client_notification::notified_at,
+                    ))
+                    .get_result::<(Uuid, Option<NaiveDateTime>, Option<NaiveDateTime>, Option<NaiveDateTime>)>(conn)
+                    .optional()?;

             match res {
                 Some(row) => {

Thanks, but we're still lacking clarity here. You mentioned experiencing this without using any unstable options, but you also mentioned that you were using options which has to be the case; rustfmt defaults would not emit any of the snippets you've shared regardless of version.
Please share your configuration file or enumerate the options and values if you are setting them from the command line

@calebcartwright Sorry, I forgot about this part: there is one option necessary to reproduce the issue: --config max_width=140

No worries, able to reproduce now, much appreciated!
@ytmimi - this is indeed stability breaking which is bad enough on nightly but even more so if it were to hit stable. nothing definitive comes to mind for me as a root cause, though I worry it could be the introduction of memoization on expressions. If you get a chance to look today that'd be great, if not I'll try to get to it tonight, but it's one we need to prioritize.

Your hunch regarding the memoization seems to be correct. I created issue_5399.rs with the contents from the stable/nightly-2022-06-14 code snippet.
 Was just about to open up a PR with the following change in format_expr:
    // Memoizing method calls lead to cases where rustfmt's stability guarantees are violated.
    // See https://github.com/rust-lang/rustfmt/issues/5399
    if matches!(expr.kind, ast::ExprKind::MethodCall(..)) {
        return format_expr_inner(expr, expr_type, context, shape);
    }

We can certainly revert the offending commit if you think that's a better fix

I think given the hour the earliest possible nightly this could land in would be 06-24 but I'll drop a note hear confirming with the first nightly that actually contains this

I confirm the issue is fixed in the latest nightly. Thanks for your quick reaction :+1:


Return 400 - Bad request for a POST to /api/email/download/ without payload

This enhancement ensures that an AttributeError is not raised, and a 500 response returned to the user when no payload is POSTed to the /api/email/download/ endpoint. A 400 - Bad Request response is returned instead. This response will only be raised for a valid client-id.

Okay great! I will do that and create a pr. Also sad that I didn't run the tests to take care of the changes I had made and make sure nothing had broken. I will be sure to do this next time.

Sounds great. Looking forward to the new PR :)


fix(console): minor UI issues

Which Problems Are Solved

The console has some dialog UI issues reported in #7404

There's some horizontal scrolling in dialogs due to field errors width overflow. In dialogs like Twilio or add flow the x-scroll show always.

New Factor MFA title has no styles applied

How the Problems Are Solved

A new style for field wrappers inside mat-dialog-component to form-field scss that sets width to auto.
This PR fix a missing MFA mat-dialog-title to apply styles to New Factor title
Issues with secret generators had been already fixed in #8141
Issues with padding for Twilio and Actions were fixed by @peintnermax

Additional Changes
Additional Context

Closes #7404

Thank you @peintnermax


text 875 in transifex = how to continue a line

URL
https://www.openstreetmap.org/node/337531716
How to reproduce the issue?

Right click on a node where 2 or more ways begin (for example the node in the URL above)
Move the mouse on the icon "Continue"
Read the text = this text is the text number 875 in transifex

Screenshot(s) or anything else?
The current text is "Several lines can be continued here. Add one to the selection to continue."
If I do what it is written (and when I say "I", I think 99% of users of ID), I do that :

I left click on one line (the one I want to continue),
I right click on the node
and nothing else : the icon "Continue" is grey, impossible to continue the line.

To be clear, here I do what it is written in the "help - Keyboard Shortcuts" at the right bottom of the screen, in the part "Selection" :

"click left or touch it or space = select one element" (it is what I want to do),
"SHIFT + click left = select several elements" (it is not what I want to do).

So I think that everybody doest what I describe above. And it doesn't work.
One year ago, the text 875 was "Several lines can be continued here. To choose a line, press the Shift key and click on it to select it."
Quite better but not perfect : better because the text talks about the SHIFT key, not perfect because if I do exactly what it is written, it will not work either.
In fact, the good process is =

I left click on one line (the one I want to continue) to select it (like it is written in the help section) -> first step that everybody knows. In this first step, the SHIFT key is useless.
THEN I click NOW on the SHIFT key + a right click on the node -> the icon "Continue" is visible : this step, I think, very, very few people know it
then I click on this icon "Continue" to continue the line ; this step is obvious, no need to talk about it.

So I think it is VERY important to put back the information about the SHIT key in the text 875 (and to add that the SHIFT key have to be used on the node, not on the line).
For your information, in the french translation I just added this information even if there is nothing in the original text in english.
So for me and all french people, this issue is solved (I mean, the day when you will transfer the translation of transifex into ID, maybe never if nobody do it).
So this issue is for all people who don't use french.
Best regards
Which iD Editor versions do you see the issue on?
No response
Which browsers are you seeing this problem on?
No response

This is still a bug in 2024.  The Several lines" message is not actionable because no indication is given as to how to do that.

Here’s the message in question:
https://github.com/openstreetmap/iD/blob/aaa144191c5eea5d0155b262d89f88c924672431/data/core.yaml#L76

A better message could be:
multiple: Several lines can be continued here. Add one to the selection (with the SHIFT key) to continue.


Patroni list all timescaleDB servers but I have no leaders

Hello,
I try to launch the single-node chart in my kubernetes cluster. But I have a big problem : I have a timeout on try to connecting to the server using AWS NLB for the leader service.
I try to connect to servers and launch patronictl list. I have the list of all my timescaleDB servers, but none of them is leader and the cluster is uninitialized :
+ Cluster: timescaledb-single (uninitialized) +---------+----+-----------+
|        Member        |      Host     | Role |  State  | TL | Lag in MB |
+----------------------+---------------+------+---------+----+-----------+
| timescaledb-single-0 | <IP_ADDRESS> |      | running |  1 |         0 |
| timescaledb-single-1 | <IP_ADDRESS> |      | running |  1 |         0 |
| timescaledb-single-2 |  <IP_ADDRESS> |      | running |  1 |         0 |
+----------------------+---------------+------+---------+----+-----------+

Is it normal ?
This is my value.yml passed to the chart :
replicaCount: 3
loadBalancer:
  annotations:
    service.beta.kubernetes.io/aws-load-balancer-type: "nlb"
    service.beta.kubernetes.io/aws-load-balancer-internal: "true"
persistentVolumes:
  data:
    size: 10Gi
secretNames:
  credentials: credentials
  certificate: certificate
  # pgbackrest: pgbackrest
patroni:
  postgresql:
    pg_hba:
    - local     all             all                                   peer
    - hostssl   all             all                <IP_ADDRESS>/32       md5
    - hostssl   all             all                ::1/128            md5
    - hostssl   replication     standby            all                md5
    - hostssl   all             all                all                md5
    - host      all             all                all                md5

After research, If I see patroni logs with service patroni status in pods, I have this error :
[FAIL] Patroni configuration file /etc/patroni/postgres.yml does not exist. ... failed!

What do the logs of the containers say?
kubectl logs pod/timescaledb-single-0 -c timescaledb
kubectl logs pod/timescaledb-single-1 -c timescaledb
kubectl logs pod/timescaledb-single-2 -c timescaledb

service patroni status

That will not work within a pod, Patroni is running as pid 1, there is no notion of services inside the container.
The command you use would be useful on a VM deployment, but not inside a container.

After clean recreate deployment, I can connect to the master server.
Ok, I understand for Patroni part.
This is the log for my pods :

pod/timescaledb-single-0 :

2020-06-24 07:28:14 UTC [32202]: [5ef3008e.7dca-1] [unknown]@[unknown],app=[unknown] [00000] LOG:  connection received: host=[local]
2020-06-24 07:28:14 UTC [32202]: [5ef3008e.7dca-2] postgres@postgres,app=[unknown] [00000] LOG:  connection authorized: user=postgres database=postgres
2020-06-24 07:28:14 UTC [32202]: [5ef3008e.7dca-3] postgres@postgres,app=pg_isready [00000] LOG:  disconnection: session time: 0:00:00.002 user=postgres database=postgres host=[local]
2020-06-24 07:28:14 UTC [32203]: [5ef3008e.7dcb-1] [unknown]@[unknown],app=[unknown] [00000] LOG:  connection received: host=<IP_ADDRESS> port=8051
2020-06-24 07:28:14 UTC [32203]: [5ef3008e.7dcb-2] [unknown]@[unknown],app=[unknown] [08P01] LOG:  incomplete startup packet
2020-06-24 07:28:15 UTC [32204]: [5ef3008f.7dcc-1] [unknown]@[unknown],app=[unknown] [00000] LOG:  connection received: host=<IP_ADDRESS> port=33543
2020-06-24 07:28:15 UTC [32204]: [5ef3008f.7dcc-2] [unknown]@[unknown],app=[unknown] [08P01] LOG:  incomplete startup packet
2020-06-24 07:28:15 UTC [32205]: [5ef3008f.7dcd-1] [unknown]@[unknown],app=[unknown] [00000] LOG:  connection received: host=<IP_ADDRESS> port=59116
2020-06-24 07:28:15 UTC [32205]: [5ef3008f.7dcd-2] [unknown]@[unknown],app=[unknown] [08P01] LOG:  incomplete startup packet
2020-06-24 07:28:15 UTC [32206]: [5ef3008f.7dce-1] [unknown]@[unknown],app=[unknown] [00000] LOG:  connection received: host=<IP_ADDRESS> port=17906
2020-06-24 07:28:15 UTC [32206]: [5ef3008f.7dce-2] [unknown]@[unknown],app=[unknown] [08P01] LOG:  incomplete startup packet
2020-06-24 07:28:15 UTC [32207]: [5ef3008f.7dcf-1] [unknown]@[unknown],app=[unknown] [00000] LOG:  connection received: host=<IP_ADDRESS> port=27819
2020-06-24 07:28:15 UTC [32207]: [5ef3008f.7dcf-2] [unknown]@[unknown],app=[unknown] [08P01] LOG:  incomplete startup packet
2020-06-24 07:28:15 UTC [32208]: [5ef3008f.7dd0-1] [unknown]@[unknown],app=[unknown] [00000] LOG:  connection received: host=<IP_ADDRESS> port=32921
2020-06-24 07:28:15 UTC [32208]: [5ef3008f.7dd0-2] [unknown]@[unknown],app=[unknown] [08P01] LOG:  incomplete startup packet
2020-06-24 07:28:15 UTC [32209]: [5ef3008f.7dd1-1] [unknown]@[unknown],app=[unknown] [00000] LOG:  connection received: host=<IP_ADDRESS> port=49244
2020-06-24 07:28:15 UTC [32209]: [5ef3008f.7dd1-2] [unknown]@[unknown],app=[unknown] [08P01] LOG:  incomplete startup packet

pod/timescaledb-single-1 :

2020-06-24 07:25:45 UTC [16644]: [5ef2fff9.4104-2] postgres@postgres,app=[unknown] [00000] LOG:  connection authorized: user=postgres database=postgres
2020-06-24 07:25:45 UTC [16644]: [5ef2fff9.4104-3] postgres@postgres,app=pg_isready [00000] LOG:  disconnection: session time: 0:00:00.004 user=postgres database=postgres host=[local]
2020-06-24 07:26:15 UTC [16652]: [5ef30017.410c-1] [unknown]@[unknown],app=[unknown] [00000] LOG:  connection received: host=[local]
2020-06-24 07:26:15 UTC [16652]: [5ef30017.410c-2] postgres@postgres,app=[unknown] [00000] LOG:  connection authorized: user=postgres database=postgres
2020-06-24 07:26:15 UTC [16652]: [5ef30017.410c-3] postgres@postgres,app=pg_isready [00000] LOG:  disconnection: session time: 0:00:00.001 user=postgres database=postgres host=[local]
2020-06-24 07:26:45 UTC [16661]: [5ef30035.4115-1] [unknown]@[unknown],app=[unknown] [00000] LOG:  connection received: host=[local]
2020-06-24 07:26:45 UTC [16661]: [5ef30035.4115-2] postgres@postgres,app=[unknown] [00000] LOG:  connection authorized: user=postgres database=postgres
2020-06-24 07:26:45 UTC [16661]: [5ef30035.4115-3] postgres@postgres,app=pg_isready [00000] LOG:  disconnection: session time: 0:00:00.003 user=postgres database=postgres host=[local]
2020-06-24 07:27:15 UTC [16668]: [5ef30053.411c-1] [unknown]@[unknown],app=[unknown] [00000] LOG:  connection received: host=[local]
2020-06-24 07:27:15 UTC [16668]: [5ef30053.411c-2] postgres@postgres,app=[unknown] [00000] LOG:  connection authorized: user=postgres database=postgres
2020-06-24 07:27:15 UTC [16668]: [5ef30053.411c-3] postgres@postgres,app=pg_isready [00000] LOG:  disconnection: session time: 0:00:00.002 user=postgres database=postgres host=[local]
2020-06-24 07:27:45 UTC [16675]: [5ef30071.4123-1] [unknown]@[unknown],app=[unknown] [00000] LOG:  connection received: host=[local]
2020-06-24 07:27:45 UTC [16675]: [5ef30071.4123-2] postgres@postgres,app=[unknown] [00000] LOG:  connection authorized: user=postgres database=postgres
2020-06-24 07:27:45 UTC [16675]: [5ef30071.4123-3] postgres@postgres,app=pg_isready [00000] LOG:  disconnection: session time: 0:00:00.003 user=postgres database=postgres host=[local]

pod/timescaledb-single-2 :

2020-06-24 07:28:30 UTC [16815]: [5ef3009e.41af-1] [unknown]@[unknown],app=[unknown] [00000] LOG:  connection received: host=[local]
2020-06-24 07:28:30 UTC [16815]: [5ef3009e.41af-2] postgres@postgres,app=[unknown] [00000] LOG:  connection authorized: user=postgres database=postgres
2020-06-24 07:28:30 UTC [16815]: [5ef3009e.41af-3] postgres@postgres,app=pg_isready [00000] LOG:  disconnection: session time: 0:00:00.002 user=postgres database=postgres host=[local]
2020-06-24 07:29:00 UTC [16822]: [5ef300bc.41b6-1] [unknown]@[unknown],app=[unknown] [00000] LOG:  connection received: host=[local]
2020-06-24 07:29:00 UTC [16822]: [5ef300bc.41b6-2] postgres@postgres,app=[unknown] [00000] LOG:  connection authorized: user=postgres database=postgres
2020-06-24 07:29:00 UTC [16822]: [5ef300bc.41b6-3] postgres@postgres,app=pg_isready [00000] LOG:  disconnection: session time: 0:00:00.005 user=postgres database=postgres host=[local]
2020-06-24 07:29:30 UTC [16829]: [5ef300da.41bd-1] [unknown]@[unknown],app=[unknown] [00000] LOG:  connection received: host=[local]
2020-06-24 07:29:30 UTC [16829]: [5ef300da.41bd-2] postgres@postgres,app=[unknown] [00000] LOG:  connection authorized: user=postgres database=postgres
2020-06-24 07:29:30 UTC [16829]: [5ef300da.41bd-3] postgres@postgres,app=pg_isready [00000] LOG:  disconnection: session time: 0:00:00.003 user=postgres database=postgres host=[local]
2020-06-24 07:30:00 UTC [16836]: [5ef300f8.41c4-1] [unknown]@[unknown],app=[unknown] [00000] LOG:  connection received: host=[local]
2020-06-24 07:30:00 UTC [16836]: [5ef300f8.41c4-2] postgres@postgres,app=[unknown] [00000] LOG:  connection authorized: user=postgres database=postgres
2020-06-24 07:30:00 UTC [16836]: [5ef300f8.41c4-3] postgres@postgres,app=pg_isready [00000] LOG:  disconnection: session time: 0:00:00.005 user=postgres database=postgres host=[local]

That looks good, those connection attempts are pg_isready and are most likely the readinessProbe of kubernetes

Thanks 😄 I continue test this chart.
I close the issue