Add Rate Limits to batch request itself

Description:
Add Rate Limits to batch request itself
Related issue(s):
Fixes #1880
Notes for reviewer:

Checklist

[ ] Documented (Code comments, README, etc.)
[ ] Tested (unit, integration, etc.)

Codecov Report
Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e35b96a) 78.10% compared to head (a6e8810) 78.03%.

:exclamation: Current head a6e8810 differs from pull request most recent head 14cb0a3. Consider uploading reports for the commit 14cb0a3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1882      +/-   ##
==========================================
- Coverage   78.10%   78.03%   -0.07%
==========================================
  Files          39       39
  Lines        3060     3064       +4
  Branches      616      617       +1
==========================================
+ Hits         2390     2391       +1
- Misses        479      482       +3
  Partials      191      191

Files
Coverage Δ

...s/server/src/koaJsonRpc/lib/methodConfiguration.ts
100.00% <ø> (ø)

packages/server/src/koaJsonRpc/index.ts
69.01% <60.00%> (-5.63%)
:arrow_down:

... and 3 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


IC-1096 Add SU contact details to referral

What does this pull request do?
Adds service user's mobile and email to the referral when fetching the service user from the Community API. It currently doesn't display it anywhere.
Extracts Delius Service User serialization function into own class, as it was getting quite complicated in there.
What is the intent behind these changes?
So we can store the SU details on a referral and play it back to the Service Provider.

We shouldn't be doing this, sorry! We should be fetching them on the receive side so they're up to date...


Investigate requiresio

It looks that for public repo in organizations requiresio is for free - check this out:
https://requires.io/github/DataMedSci/beprof/requirements/?branch=master
It it works correctly, badge has to be added again

Looks good. I'll add it and commit straight to master.

OK

Done in d931d10ab31bc742c816ad68dcb96033027532fe


Query string only contains a single url

擋掉然後回應：「這是單純的網址，不是轉傳訊息，請從網址擷取出相關的文字資訊。」

#50 should be addressing URLs, but somehow it does not work.

Should be done for nkw


Equal cells aren't equal after Cell.fromBoc

I create some cells and want to compare them.
It works if we use constructors like this:
const cell = new Cell().withData("0101");
const cell2 = new Cell().withData("0101");
console.log(cell.equals(cell2)); // true

But it doesn't work if we use Cell.fromBoc:
const cell = new Cell().withData("0101");
const cellboc = Cell.fromBoc(cell.toBoc())[0];
console.log(cell.equals(cellboc)); // false, but expected true

The problem is that the comparison fails on bits.equals, because cellboc has only 8 bits (cellboc.bits.length), while the first cell has 1023.

Fixed in 12.2.8


Update .NET Framework to .NET 9.0 (#16)

The upgrade was done using .NET Upgrade Assistant. The build and tests ran without errors.

Fixed in #17


Having trouble getting the right tokens using the Lexer

Hey!
I'm straggling with the lexer in a try to get the tokens of a phrase like:
parent.child.name = "foo"
When my "filed" token is as follows:
const field = createToken({ name: 'field', pattern: /"|parent|child|name|id"/ } as ITokenConfig);

I'm getting back:
["child", ".", "parent", ".", "name", " ", "=", " ", """, """]
But expecting to get:
["child", ".", "parent", ".", "name", " ", "=", " ", ""foo""]
In case I'll change the field token to be:
const field = createToken({ name: 'field', pattern: /"parent|child|name|id"/ } as ITokenConfig);

I'll get the value string but will lose the "parent" field
["child", ".", ".", "name", " ", "=", " ", ""foo""]
Not sure what am I doing wrong
I created a runnable stackblitz
Would really appreciate help,
I'm working with chevrotain on another project and didn't face that issue before,
The given tokens order looks ok,
sorry for opening an issue I couldn't find any lead of resolving it..

I suspect to have quotes inside the field regExp:
/"|parent|child|name|id"/
https://regexper.com/#%2F"|parent|child|name|id"%2F

Thanks! :))


integrate lektor-atom plugin for CC technical blog.

Fixes #75
Description

add lektor-atom plugin. Using it, we can easily create multiple feeds.
add [blog] feed for CC technical blog content/blog.
Add absolute url in project config to remove E feed.xml (RuntimeError: To use absolute URLs you need to configure the URL in the project config.) error.
The feed for blog will be at creativecommons.github.io/feed.xml.

Other information

I also added the check_file() function in blog-post.html to ensure that we have created an author before publishing a blog post.
The select type of author field in blog-post.ini was querying the now absent /authors. Changed the type to string.

Checklist:

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the master branch of the repository.
[x] My commit messages follow best practices.
[ ] I added tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Add RSS feeds to Slack. We can easily subscribe to the feed in Slack.


Build fix for Chromium

Some platforms use different version of libusb. For instance, Chromium compiles
libusb by itself. So hard coding of libuse version (i.e. <libusb-1.0/libusb.h>) causes
compile failure.

@ktossell could you review?
I want to use libuvc in chromium but compile failed.

Any project that includes libuvc.h will need to have libusb-1.0 added to its include path. But the references to libusb types in libuvc.h are pointers to structs which we can forward declare. I'll plan to follow this PR with a change that drops the downstream dependency on libusb.h


[Fix] Composer text and icon not aligned center vertically for native app

Details

iOS issue looks identical to this issue https://github.com/Expensify/App/issues/1500 , the proposed solution https://github.com/Expensify/App/pull/1557 isn't the right fix
iOS issue is related to paddingVertical which on iOS doesn't reset to zero both padding , check this https://github.com/facebook/react-native/issues/21720 , using paddingTop and paddingBottm instead of paddingVertical will fix issue
Android issue is a regression of this PR https://github.com/Expensify/App/pull/9031 this commit https://github.com/Expensify/App/commit/1f66c3ad2ca0eed6334280b4482b69aeabc7dc85 , Setting paddingVertical: 6 add 2px extra to top

Fixed Issues

$ https://github.com/Expensify/App/issues/10202
$ https://github.com/Expensify/App/issues/10202#issuecomment-1307930393
Tests

Open any chat
Enter 1 line of text, and select/highlight the text

Check that the composer input vertical padding is equally centered
Check that the send icon has consistent padding and is centered

Enter 2 lines of text, and select/highlight the text

Check that the composer input vertical padding is equally centered
Check that the send icon has consistent padding and is bottom aligned

Enter 3+ lines of text, and select/highlight the text

Check that the composer input vertical padding is equally centered
Check that the send icon has consistent padding and is bottom aligned

[x] Verify that no errors appear in the JS console

QA Steps

Run the above tests!
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots

Web

1 line

2 lines

3 lines

Mobile Web - Chrome

1 line

2 lines

3 lines

Mobile Web - Safari

1 line

2 lines

3 lines

Desktop

1 line

2 lines

3 lines

iOS

1 line

2 lines

3 lines

Android

1 line

2 lines

3 lines

Looking good, but it be good to show the padding in the screenshots, and maybe some with multiple lines of text.

@Julesssss Updated

Screen Recording

Desktop & Web
https://user-images.githubusercontent.com/85645967/201530432-fc996163-16e7-4164-8ed3-889784d76960.mov
Native Android & iOS
https://user-images.githubusercontent.com/85645967/201531044-a8a047b9-6271-4a28-938f-526021ff2086.mov
mWeb Android & iOS
https://user-images.githubusercontent.com/85645967/201531057-60d752e8-3525-4bb0-af07-99c3878aafeb.mov

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

@trjExpensify here are the comments I have suggested we add to help avoid regressions here. Shall we also figure out the Test rails case now?
I'm thinking something like:

Open any chat
Check that the composer input height is consistent on all platforms
Check that the composer input padding is centered on all platforms
Check that the above is true for inputs with 1 line of text
Check that the above is true for inputs with 2 lines of text
Check that the above is true for inputs with 3+ line of text

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Jules, for the regression test, they look largely good but I think we use "verify" instead of "check" as that's how they are all generally written and followed by Applause.
I think we add it to the Compose Box - Text Input existing test case, I've created an issue here.

🚀 Deployed to staging by @Julesssss in version: 1.2.28-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by @Julesssss in version: 1.2.28-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @roryabraham in version: 1.2.28-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


K8s cluster admin credentials plaintext in database

ISSUE TYPE

Security

COMPONENT NAME
DB

CLOUDSTACK VERSION
Tested on at least 4.16.1, but expecting versions since the introduction of K8s support to be affected

CONFIGURATION
N/A
OS / ENVIRONMENT
N/A
SUMMARY
The k8s cluster admin credentials are stored plaintext in the database. This is a security risk.
STEPS TO REPRODUCE
- Create cluster in UI or API
- In sql `select * from kubernetes_cluster_details where name='password';`

EXPECTED RESULTS
Expected credentials to be encrypted just like we do with other components.

ACTUAL RESULTS
+----+------------+----------+----------------------------+---------+
| id | cluster_id | name     | value                      | display |
+----+------------+----------+----------------------------+---------+
|  2 |          1 | password | jlm9koisse5h3n9h7vhg1e3at1 |       0 |
+----+------------+----------+----------------------------+---------+

cc @rahulbcn27 may be a good community issue to fix; likely requires a @Encrypt on the DB VO class field/volumn related to the schema column


Input label opacity

Hello, I want ask, why default opacity for Input label is only
0.26 it look not good, is too light
here is preview from react-toolbox website

and for compare from google material doc

original is darker and looks better.

Yeah, according to the specification it should be 38% #000000 on light backgrounds and 50% #FFFFFF on dark backgrounds.

Hey, I want to work on this.
How can we find out that its light background or dark background ?
Or we should change only this for light backgrounds ?
--input-text-label-color: color(var(--color-text) a(26%));

to
--input-text-label-color: color(var(--color-text) a(38%));

I think we have to review all colors in the project...
According to the Material Design Spec the bottom line should be Color: 42% black and the text should be Color: 54% black for normal inputs, and the text should be Color: 38% black for disabled inputs.
We're using --color-text which is --palette-grey-900, also known as rgb(33, 33, 33), which is not black, so yeah, everything in the input looks lighter than it should...


Aave Swapper: Limit Orders

Changelog
Add method to do a limit swap order.
Add method to cancel a limit swap order.
Refactor code to DRY swap functionality.
Update README to add information on limit orders.
Add natspec.
Tests
Sample ERC20 to ERC20 swap with 18 decimals:  https://explorer.cow.fi/address/0x75a37623F8308eDaA2C21D8B51B91393A9E4033a
https://etherscan.io/tx/0x2186f0cabbbf1930b436783eca69328bfa5a7453c1c7d9a6ed9d7818b3ad9729
Sample ERC20 to ERC20 swap with 6 decimals:
https://explorer.cow.fi/address/0x141764c308997ec2a3AFE2cBAA1307610b126c01
https://etherscan.io/tx/0x135a6218866f050634bf52e699b93a9374c12cba19d2de104aa8296e86d0ce51

Could you also update to the latest master or update the libs

@brotherlymite updated!


Can I edit my past messages?

I am not a good typist.
Would I use able to edit my typos with kaiwa?

According to the README, yes https://github.com/digicoop/kaiwa#message-correction

Oh, right in front of my eyes!
I missed it somehow.
Thanks for the heads up


dependencies versions

Hey
I am trying to reproduce the contents of the paper.
Can you let me know the versions of these libraries ?
Pytorch, torch-geometric, torch-scatter, torch-sparse, torch-cluster, torch-spline-conv

Hi,
Actually, the dependencies are very flexible. You can install the most recent PyTorch 2.0 based on your Cuda version. The PyG that includes torch-geometric, torch-scatter, torch-sparse, and so on must be consistent with the Pytorch and Cuda versions.
Below are the settings I used mostly for this repo
python 3.7.15
torch   1.13.1+cu117
torch-cluster            1.6.1+pt113cu117
torch-geometric          2.3.0
torch-scatter            2.1.1+pt113cu117
torch-sparse             0.6.16+pt113cu117
Thanks,
Haojie

Thanks for the quick response. That worked for me.
Can you also guide me on how to use the code for making predictions on some other point cloud data? I am generating point clouds from the gazebo and want to use the network for getting possible grasps as a ground truth for some RL tasks.
Thanks,
Anurag


ScrollTop is not working when tab is changed from left to right in MdTabGroup

Bug
Follow-up to the issue #4989
I wrote a code that saves the scroll position of the current tab body's div and when we return to that tab it sets the scroll position to the stored value. By logging in the console I find the values stored and retrieved to be correct. But:
When I select a tab that is to the right of the currently active tab, the scroll position can not be set. But the same code sets the scroll position of the div if I select a tab that is towards the left of the currently active tab.
What is the expected behavior?
The scroll position should be set irrespective of the positions of the tab. The code should either work for all cases or none.
What is the current behavior?
When I select a tab that is to the right of the currently active tab, the scroll position can not be set. But the same code sets the scroll position of the div if I select a tab that is towards the left of the currently active tab.
What are the steps to reproduce?
Plnkr: http://plnkr.co/edit/MeQj4zUAQ9qHiFgm7f0J?p=preview
Go to the second tab. Scroll down to some position. Go to tab 3. Come back to Tab 2. The scroll position should be saved. Repeat the same but go to Tab 1 instead of Tab 3. The scroll position resets to zero.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
The same issue is produced in Chrome and Firefox.
Is there anything else we should know?
Calling the function from selectChange does not even save the scroll position correctly. That's why I put that function in focusChange. I have three functions in the original code: one that saves the scroll position, one that selects the content to show after the tab switches and one that sets the scroll position to the saved value. And I want to call the three functions sequentially by calling them from selectChange instead of focusChange. And the saved scroll position is correct in every case.

First of all I need to point out Id are unique, so you should not use them multiple times in the same page. Some browser support multiple id like firefox, IE.

@raghukul01 But at a time only one div is present with that id. So, is that still a problem?


add CI for test/release

we should push the mutating webhook images to docker every release and add automatic tests/lint on PR creation.

closed by #27.


Examples

Codecov Report

Merging #135 (4bfd87d) into main (f12591d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #135   +/-   ##
=======================================
  Coverage   32.41%   32.41%
=======================================
  Files          60       60
  Lines        2184     2184
=======================================
  Hits          708      708
  Misses       1476     1476

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f12591d...4bfd87d. Read the comment docs.

Hi @ndamond, I just took a quick look - thanks for your efforts, looks quite complete to me already! Looking forward to merging this PR once ready.
A few important things before I can start the review process:

Example notebooks should be self-contained - please do not use separate download/helper scripts; if you need additional functionality exposed in steinbock or have questions regarding how to do certain tasks, please let me know
Please do not store data (panel.csv) in this repository - all necessary data should be created by the respective notebook; for example, for the panel file, you could automatically create it from MCD metadata using steinbock's panel preprocessing/download it from its source (Zenodo?) and edit it as needed (e.g. for segmentation) using pandas
As this is the steinbock repository, the notebooks should exemplify the use of steinbock whenever possible; for example. for deepcell-based segmentation, please use steinbock functionality instead of re-implementing segmentation using the deepcell API; similarly, for all I/O (e.g. for reading panel files, writing intensities/regionprops/neighbors, ...), please use steinbock.io
Example notebooks should be as simple/short as possible - essentially, they should only consist of documentation + some simple steinbock calls; e.g. is the creation of the images.csv file really needed?
The only difference between steinbock_preprocessing.ipynb and steinbock_preprocessing_IF.ipynb I see is the starting point (i.e., MCD/TXT files vs TIFF files) - could the two notebooks be merged?
Please make use of jupytext to keep the Jupyter notebooks and associated Python scripts in sync - this greatly simplifies code review, as I can directly suggest changes in the code

The only difference between steinbock_preprocessing.ipynb and steinbock_preprocessing_IF.ipynb I see is the starting point (i.e., MCD/TXT files vs TIFF files) - could the two notebooks be merged?

As discussed offline, there are quite a few differences that all relate to preprocessing/data extraction. We therefore decided to split up the notebooks as follows:

preprocessing_{modality}.ipynb
segmentation_{approach}.ipynb
measurement.ipynb (including optional data export steps)

Hi Jonas, thanks for looking into this. Following up on our offline discussion, here is a quick update on the points you raised above https://github.com/BodenmillerGroup/steinbock/pull/135#issuecomment-1220583844.

The download script is now included in the preprocessing_imc notebook (https://github.com/BodenmillerGroup/steinbock/pull/135/commits/b880f0e4395d8ed5020e4c0dabe494509812b394).
As we discussed, I would need some functions to be exposed to get rid of the helpers.py file (#139, #140, #141).

The panel file is now downloaded from https://zenodo.org/record/6642699 (https://github.com/BodenmillerGroup/steinbock/pull/135/commits/b880f0e4395d8ed5020e4c0dabe494509812b394).
I also added code to create a panel with imc.create_panel_from_mcd_files() (https://github.com/BodenmillerGroup/steinbock/pull/135/commits/3a1316979778d5c2c41590f02340fbef79567dab).

About using steinbock functions:

Reading panel: done with io.read_panel() (https://github.com/BodenmillerGroup/steinbock/pull/135/commits/fb591297db1967ed6337f86f7e80352c4be182de).
DeepCell segmentation: done, reverted to deepcell.try_segment_objects for cell segmentation (https://github.com/BodenmillerGroup/steinbock/pull/135/commits/0be903061df8aba498c7160a4b1a779212b137a2). Will do the same for segmentation stack generation after the function is factored out (#139).
Writing intensities/regionprops/neighbors: that was already implemented (except for some quick fix for the IF notebook but that is not relevant anymore, point 5 below).

As we discussed, exporting image metadata as images.csv will be done using a steinbock function (#140).

As you mentioned above we have decided to split up the notebooks (done in https://github.com/BodenmillerGroup/steinbock/pull/135/commits/cd184b81b71ed885b8301040aff70c6c8855aba3). I've added number prefixes so that users know in which order to run them. We can decide later on what is exactly needed in the 01_preprocessing_if.ipynb notebook

jupytext - done (https://github.com/BodenmillerGroup/steinbock/pull/135/commits/0ca7b9a282832bdcfcfe2b6c762a875c71a72422).

As discussed, I just exposed the required functionality:

steinbock.segmentation.deepcell.create_segmentation_stack
steinbock.preprocessing.imc.create_image_info
the list_... functions in steinbock.preprocessing.imc now take an optional unzip_dir argument; for example, to unzip MCD files to a temporary directory (the temporary directory will be deleted upon exiting the with context):

with TemporaryDirectory() as temp_dir:
    mcd_files = imc.list_mcd_files(mcd_dir, unzip_dir=temp_dir)
    # do stuff while temp_dir and files in temp_dir still exist
# temp_dir does not exist anymore

To install the development version of the steinbock Python package directly from this PR:
pip install git+https://github.com/BodenmillerGroup/steinbock.git@refs/pull/135/head

Alternatively, you can also install steinbock from your local copy of this repository:
pip install /path/to/steinbock

Here, /path/to/steinbock is the path to the directory containing the setup.cfg file.

Hi Jonas, thanks for the updates, here is a summary of the last modifications :
'1. I included the newly exposed functions (https://github.com/BodenmillerGroup/steinbock/pull/135/commits/f5603981d6cbcce48c77be70248f9f7fcca4ccab, https://github.com/BodenmillerGroup/steinbock/pull/135/commits/4597e16460271eb0c7576b7ff889565acb077b73, https://github.com/BodenmillerGroup/steinbock/pull/135/commits/bb818a8d678c7c6a17f00bde6580cac0e90fa59e) and removed the helpers.py file (https://github.com/BodenmillerGroup/steinbock/pull/135/commits/8802eafaa1f386ef0687442269c35a54c7096880).
'3. Segmentation stacks are now generated with deepcell.create_segmentation_stack() (https://github.com/BodenmillerGroup/steinbock/pull/135/commits/bb818a8d678c7c6a17f00bde6580cac0e90fa59e).
'4. Image metadata are now extracted with imc.create_image_info() (https://github.com/BodenmillerGroup/steinbock/pull/135/commits/4597e16460271eb0c7576b7ff889565acb077b73).
Regarding zip extraction, using the with/imc.list_... approach is not really convenient as the unzipped mcd/txt files are needed for different things that are spread over several cells (create the panel, adjust it, convert to tiff). So I'm currently using imc._extract_zips(path=raw_dir, suffix=".mcd", dest=raw_dir), not sure that is the intended usage.

 Will create a new, clean branch & MR


Embed thumbnail using mutagen for mp3 files, fix lyrics issue #5635

IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Purpose: Fixes issue #5635
Examples:

yt-dlp --audio-format mp3  --extract-audio --embed-subs --convert-subs lrc --embed-thumbnail https://youtu.be/TU2g0bTNTCc?si=TO_NrOr2zlFsZSjJ
yt-dlp --audio-format m4a  --extract-audio --embed-subs --convert-subs lrc https://youtu.be/TU2g0bTNTCc?si=TO_NrOr2zlFsZSjJ

Description:

added lyrics support for mp3, m4a, flac and opus
for mp3 using ffmpeg to embed thumbnail with lyrics was not working, so used mutagen instead

Fixes issue #5635
Template

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[x] Fix or improvement to an extractor (Make sure to add/update tests)
[ ] New extractor (Piracy websites will not be accepted)
[ ] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

@pukkandan If user selects multiple subtitles should we raise error
I'm unable to add lyrics data for multiple languages in audio file. it just gets overwritten
for now I'm throwing a warning if there is more than 1 subtitle selected and continuing with the first one (for audio only, video logics were not changed)
what to do?

for now I'm throwing a warning if there is more than 1 subtitle selected and continuing with the first one (for audio only, video logics were not changed)

That makes sense. Just make sure the other subs (that were not embedded) don't get deleted

So do that

Okay
I will still throw a warning with something like "Even though multiple subs are being Embed, most players are able to display one of them"

@pukkandan I think this pr can be merged
Please have a look

@Grub4K i pushed all the changes that you asked above

Do i need to update docs in this same pr?

What would you add into the docs?

there isn't much but the --embed-subs usage needs to be updated

all mentioning that for music --convert-subs lrc is mandatory

            'Available for video (mp4, webm and mkv) and audio when using  --convert-subtitles lrc'))

convert-subttiles lrc seemed like we were talking about both video and audio. so it repharsed it
I have updated both option.py and readme.md

@Grub4K sorry if this was an unnecessary mention
I just wanted to make sure you saw this

The impl had a lot of subtile bugs.

'data' need not always be available; read from file
Don't use filename to detect ext; take from infodict
Don't abort if some subs are not lrc; embed what we can and warn for rest
Language can be passed for mp3
mutagen may not be installed; proper error should be issued

The whole run function is a mess anyway, so I decided to rewrite it completely.

Note to self: Thumbnail and subtitle parts should be merged separately

And what about the unsynced lyrics? I think that the author of the original issue has proposed a pretty good solution https://github.com/yt-dlp/yt-dlp/issues/5635#issuecomment-1327879883.

The current implementation is incorrect.

Why is that? I'm already using it to download my songs. And it works... Synchronised...

Can you point me to some docs or implementations to read? That will really help

And what about the unsynced lyrics?

Can you please provide me with a test case where we get unsynced lyrics from yt so that I can do some testing

Maybe it works in some players, but it's certainly not a standard behavior.

MP3. See section 4.9 (Synchronised lyrics/text). Synchronized lyrics format described in this section is not compatible with LRC. So there is no way of embedding synced lyrics in MP3 without converting them to SYLT format. There is also an USLT tag for unsynced lyrics.
OGG/OPUS/FLAC. All of these formats use Vorbis Comments, which are very limited. But de facto standard for storing unsynced lyrics is LYRICS field.
M4A/MP4. These formats use QuickTime tags. There is a lyrics tag (see "QuickTime UserData Tags" section). There is no description for this tag, but it would be logical to assume that it's  mostly used for the unsynced lyrics.

So I think the best way of storing synchronized lyrics for any audio file format is to simply use an LRC format. That is, writing .lrc file right next to the audio file (as I described earlier, song.flac and song.lrc). This is supported by wast majority of music players. But we'll probably have to add a new argument (e.g. --write-lyrics), because it's not an embedding.

Can you please provide me with a test case where we get unsynced lyrics from yt so that I can do some testing

I can't, because there are no extractors that return unsynced lyrics. We need to add support in FFmpegEmbedSubtitlePP at first.

Maybe it works in some players, but it's certainly not a standard behavior.

I will check these later. It would be good if any maintainer would confirm that implementation is too wrong to be accepted as a solution

We need to add support in FFmpegEmbedSubtitlePP at first.

Is there any point to solve problems that don't exist? Is there any open pr that will bring such changes?

Is there any point to solve problems that don't exist? Is there any open pr that will bring such changes?

There are services that return lyrics as plain text (without timestamps). And currently there is no way of embedding such lyrics. So it's pretty much an existing problem. If you don't want to solve it in this PR, that's fine, we can work on it later.

If you don't want to solve it in this PR, that's fine, we can work on it later.

Unsynced lyrics part should be handled later but I would like to address the synchronised lyrics in this pr.
I will definitely look at those links you provided(travelling rn)

So I think the best way of storing synchronized lyrics for any audio file format is to simply use an LRC. That is, writing .lrc file right next to the audio file (as I described earlier, song.flac and song.lrc).

Users can already do that with --write-subtitles instead of --embed-subtitles.

There are services that return lyrics as plain text (without timestamps). And currently there is no way of embedding such lyrics. So it's pretty much an existing problem. If you don't want to solve it in this PR, that's fine, we can work on it later.

We don't even have a field yet for extracting such lyrics. You'd have to first make a https://github.com/yt-dlp/yt-dlp/labels/site-enhancement request for such a site so we can discuss and add such a field. Any discussion of embedding is pointless till we have extractor support first.
The proposal for --convert-subs txt is also reasonable (there is also a similar feature request for srt->txt), but again, embedding it will have to be discussed after such a converter is written. That is beyond the scope of this PR.

In this PR, all we need to look into is what the correct way to embed synced lyrics is. https://cweiske.de/tagebuch/embedded-lyrics.htm has a ton of useful information
Our mp3 implementation does in fact appear to be incorrect, but easy enough to fix. Ref: https://stackoverflow.com/a/61166697/12907559.
For the other formats, given the lack of a formal method for embedding synced lyrics, it is reasonable to just dump the lrc in lyrics field imo. After all, the user is passing --convert-subs lrc and atleast some players seem to support lrc in these fields. In worst case, unsupported players think the timestamp are part of the unsynced lyric, which isn't a big deal. In the future, if the user passes --convert-subs txt instead, we could embed unsynced lyrics instead in the same field.

Our mp3 implementation does in fact appear to be incorrect, but easy enough to fix. Ref: https://stackoverflow.com/a/61166697/12907559. This will need to be fixed before merge.

this StackOverflow implementation worked. i don't why it didn't work 2-3 months ago when I tried.
multiple subs problem still remains. multiple subs can be embedded but player do not detect it.
hex view(those japanese subs are there):

player:

note:

multiple subs problem still remains.

only in mp3

with pure honesty, i dont know how to code this part
it is working but... please tell be how to do this

@bashonly @Grub4K I'd like a second opinion on https://github.com/yt-dlp/yt-dlp/pull/8869/commits/3f30a6b78ed331f843c8a6b6420371476a36b479
Would an LRC(data).subtitles be useful as opposed to [l for l in parse_lrc(data) if isinstance(l, Subtitle)]

Hi we are a team from University of Michigan's software engineering course and we are willing to work on this issue for our course project. Could we be assigned to this task?

@JerryZhouSirui this PR is in progress, please choose a different issue to work on

@JerryZhouSirui I would recommend Multi-Threaded downloading and processing
you should discuss this on the Discord server for cooler issue to implement, I guess


Bugfix/publishing

:tada: This PR is included in version 1.2.1 :tada:
The release is available on:

v1.2.1
GitHub release

Your semantic-release bot :package::rocket:


ORC-1744: Add ubuntu-24.04 to GitHub Action

What changes were proposed in this pull request?
This PR aims to add ubuntu-24.04 to GitHub Action.
Why are the changes needed?
Ubuntu 24.04 is available as Beta.

https://github.com/actions/runner-images/issues/9848

We can use it to improve the test coverage.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.

CI passed. Since this is only an addition to the test coverage, let me merge this.


add default scrollEnabled props

add default scrollEnabled props
Platforms affected
iOS and Android
What does this PR do?
Fix PR #390 and issue #392
What testing has been done on this change?
Test PR #390 without scrollEnable set manually
Tested features checklist

[x] Default setup (example)
[x] Carousels with and without momentum enabled (prop enableMomentum)
[x] Vertical carousels (prop vertical)
[x] Slide alignment (prop activeSlideAlignment)
[x] Autoplay (prop autoplay)
[x] Loop mode (prop loop)
[x] ScrollView/FlatList carousels (prop useScrollView)
[x] Callback methods
[x] ParallaxImage component
[x] Pagination component
[x] Layouts and custom interpolations

These changes do fix #392 in my case :)

Thanks a lot @JakeRawr! This seems to do the trick ;-)
I'm merging and releasing right away...


Preserve line and column numbers

Replace all text with spaces, preserving line numbers and columns.

Any thoughts on this?

Some of this needs ruby 2.3. .ruby-version has 2.4.1 in it, but the README says 2.2.2+. I can remove anything incompatible with Ruby 2.3 if you like.


Fix release

I noticed #826 broke the release build, because it actually started to use some debug-specific resources which should actually have never been there.
Removed them and replaced the placeholder using the tools namespace.

It is odd. Instrumentation tests succeed if you already logged in with the app before running tests.
Not sure how it could work before. Not sure why it stopped working now either 🤔

I just noticed: #826 also broke integration tests by accessing Account in Drawer.
Could introduce Mockito into the testing suite to mock the Account, or mock the server to create one... Not sure which one we'd prefer. Any ideas?

Ups, probably my bad to merge it. But actually I am pretty sure that it was done with integration test when I checked that branch. Anyway, I think it can be better if I revert merge @akaita , what do you think?

So that we can solve integration test issues on that branch.

If you log into the app once, an account will be saved into Android's AccountManager and instrumentation tests will run ok. They also run ok for me, and then they failed in CI.
The thing is that CI runs in a clean emulator every time, so it never has put any credentials in the app, so there is nothing in AccountManager.
It took me a while to realise 😅 .
I think your idea is good. Revert and fix in that branch will be definitely best 👍

Since, merge is reverted, can we close this PR @akaita ?

Yes, thanks.
I'll try to replicate the reverted PR and think about the best way to fix the instrumentation test for it.


Fix checkpointing under torch.compile

Closes #24, closes #18

@mtanneau can you please try your workflow using this branch? Seems to work on my end but I'd like to verify before merging.

Running local checks now.


v3 set up instructions and how to generate docs

We should definitely get this sorted!
@alvinsight aka 'the doc master'  you cool to have a stab at this today?

Yep :)


Held mouse buttons aren't updated when the cursor is outside of the window (SDL)

To reproduce:
(0. use windowed mode)

hold any mouse button
leave the game window

The mouse button state should be updated, but isn't until the cursor returns to the window. This can be seen in the visual tests already.

This is another case where it's not going to be something we can fix locally without bypassing SDL for input handling. We're not doing anything special around this code that could result in this behaving this way.


Dp/staging

This PR exists only so Vercel will make a staging build. The code contains hardcoded dependencies on staging URLs.

PR-Codex overview
This PR introduces support for OTP (One-Time Password) authentication in the account-kit library, enhancing the existing email and OAuth authentication methods. It updates various types, interfaces, and components to accommodate the new OTP functionality.
Detailed summary

Added otp type to Session and AuthParams.
Introduced emailMode option in authentication types for magicLink and otp.
Updated assertNever function to include better error messages.
Modified components to handle OTP, including LoadingOtp, CompletingOtp, and OTPInput.
Added new event handling for OTP authentication in SessionManager.
Updated UI components to support OTP flows, including error handling and input management.
Enhanced documentation for OTP-related methods and parameters.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

#1211  👈 (View in Graphite)
main

How to use the Graphite Merge Queue
Add the label graphite-merge-queue to this PR to add it to the merge queue.
You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.


Chat reference feature is not screen reader friendly

Tested with @jooyoungseo

Use a screen reader and tab to the Used 1 reference button. It says it's a button but doesn't indicate that it's expandable / collapsed and should.
Click the button. The aria label says "list item 1 of 1" but should instead say the file name.

I do hear the correct thing when I go to the list item when on mac.


Not able to copy a file from ansible node to destination node

Hi i am running ansible playbook from rundeck.. In my ansible playbook there is command to copy a file from anisble node to dest node.. In play book i gave like this

name: copy file to the server
copy: src=/root/{{ filename }}/ dest=/opt/
register: status

This thing works when i run ansible in command prompt.. But when i run through Rundeck it is showing error like it is not able to find the file.. During project creation i selected (Ansible File Copier) and gave arguments in a job in a correct format.. Output which i get in rundeck logs is

[copy file to the server] **********************************************
failed: [<IP_ADDRESS>] => {"failed": true}
msg: could not find src=/root/test
FATAL: all hosts have already failed -- aborting
Please help me what i am doing wrong

You are doing nothing wrong. :) This is an open feature request, see #10.


Add missing parameters to L.Util.indexOf docstring

I'd guess that users should refer to the linked docs, but LGTM


feat(rightmenu): Add Datasets to + Menu and Hide Databases when one has been connected

SUMMARY
We are adding some extra logic to RightMenu so it checks for what databases the user has connected before displaying options in the dropdown.
Plus menu logic:

Connect database: shows for users who can create databases, until their first non examples db is connected
Create dataset: shows for users who can create a dataset as soon as at least one non examples db is connected
[no change] Connect Google Sheet: shows for users who can create databases, always
[no change] Upload CSV, columnar, Excel: shows for users who can create databases all the time (tooltip when no csv uploads enabled, active when csv uploads enabled). For users who can upload but can't connect db, only shows once uploads are enabled on at least one db.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:

After:

TESTING INSTRUCTIONS

Login into the app
Connect a database that is not example and check the logic form above
Remove all connected databases and check the logic from above
Clicking on the connect database menu should open the Connect Database modal
Clicking on the create dataset menu should open the Create Dataset modal

ADDITIONAL INFORMATION

[X] Has associated issue: https://github.com/apache/superset/issues/21569
[ ] Required feature flags:
[X] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

/testenv up

/testenv up

LGTM!

/testenv up

/testenv up

Test the alpha and gamma role in local env and verified alpha user can see create dataset in + menu when 1 non-example db is added.

/testenv up FEATURE_SCHEDULED_QUERIES = TRUE


AmazonS3Util.DeleteS3BucketWithObjects issue

Expected Behavior

The method above is expected to delete all the objects of a bucket and then deletes the bucket.

Current Behavior

Fails with : The bucket you tried to delete is not empty.
The remote server returned an error: (409) Conflict
Possible Solution

Steps to Reproduce (for bugs)

Try to delete a bucket with objects using the method above
Context

Your Environment

AWSSDK.Core version used: AWSSDK.Core.3.3.14
Service assembly and version used: AWSSDK.S<IP_ADDRESS>.1
Operating System and version: Windows 7 64 bits
Visual Studio version: 2013
Targeted .NET platform: 4.5

.NET Core Info

.NET Core version used for development:
.NET Core version installed in the environment where application runs:
Output of dotnet --info:
Contents of project.json/project.csproj:

After you run the code do you see any objects left in the bucket?

Yes

We have passing tests that exercise this API.  From this report, we can't tell what's different.  What type of objects are still in the bucket? Is it possible for you to provide a minimal stanadalone repro?  If this is intermittent, can you provide a detailed log?

Ok here is a sample to reproduce the problem:
var client = new AmazonS3Client(key, pass, config);
var bucketName = "mybucket";
await client.PutBucketAsync(bucketName, CancellationToken.None);
var k1 = Guid.NewGuid().ToString();
var r = new PutObjectRequest();
 r.FilePath = @"C:\Users\me\Desktop\randomtextfile.txt";
 r.BucketName = bucketName;
r.Key = k1;
await S3.Ard.PutObjectAsync(r);
 await AmazonS3Util.DeleteS3BucketWithObjectsAsync(client, bucketName.Value);

Result
Amazon.S3.AmazonS3Exception : The bucket you tried to delete is not empty.
  ----> Amazon.Runtime.Internal.HttpErrorResponseException : The remote server returned an error: (409) Conflict.
  ----> System.Net.WebException : The remote server returned an error: (409) Conflict.

Full log :
errorlog.txt

I've tried that code and it works for me.  I did have to change "S3.Ard" to "client".  Can you send the contents of the S3.Ard.PutObjectAsync method?  Is it possible that you're missing an await somewhere in that method?

Also, there may be configuration of "mybucket" (or whatever the bucket you're using is called) that's affecting this.  When you run you should make sure there's a new bucket each time you test by adding DateTime.Now.ToFileTime() or something similar to the end of the bucket name.  If you run with a new bucket do you still see this problem?

Closing due to inactivity.


With nmea0183 source the server stops outputting messages after a while

As reported by @bobmor99 the server stops outputting messages after about an hour of processing for example gpsd input.

The reason is that nmea0183-signalk is a Transformer that transforms lines of nmea0183 to signalk tree messages and on the side EventEmitter that emits delta messages.
The server provider glue code uses just the delta events and does not handle the the transformation result in any way and it is buffered internally until the backpressure stops nmea0183-signalk Parser.


fix: do not reset txn if tab doesn't change

Details

avoid txn in Onyx get reset after IOU confirmation page refresh
Fixed Issues

$ https://github.com/Expensify/App/issues/40936
PROPOSAL:  https://github.com/Expensify/App/issues/40936#issuecomment-2138147750
Tests

Go to the app
Tap fab -- submit expense - scan
Upload an image using camera
Select a user
Enter description and save it
Refresh the page

Result: On refreshing scan submit expense confirmation page all details must not be disappeared

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to the app
Tap fab -- submit expense - scan
Upload an image using camera
Select a user
Enter description and save it
Refresh the page

Result: On refreshing scan submit expense confirmation page all details must not be disappeared

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

https://github.com/Expensify/App/assets/165644294/53c7afad-6914-435e-836e-199db3e29490

iOS: Native

iOS: mWeb Safari

https://github.com/Expensify/App/assets/165644294/cb000d48-dd5f-41b1-b5d1-ff933a09c66f

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/165644294/b9d2d925-b12d-43e6-b25c-c908766d4c96

MacOS: Desktop

@dominictb This fails if I refresh the page before processing to the submit expense flow
https://github.com/Expensify/App/assets/16493223/d7df8937-2ec8-4cb1-aede-0b4857b51b15

Now I can't get this to work at all 😅 Can you please investigate it

@dominictb

Go to report A
Open FAB > Submit expense
Select a different user than the one on report A

After refresh this side effect will reset the money request https://github.com/Expensify/App/blob/bdb978990df4a8e173b9790a2fa75c2a0f1d6be3/src/pages/iou/request/IOURequestStartPage.tsx#L94-L100
https://github.com/Expensify/App/assets/16493223/43acf5ca-ec21-4843-a69c-a8f27e041cbb

@dominictb

This leads to a problem that the IOURequestStartPage is not unmounted yet (stay in un-focused mode), i.e, in here, route.params.reportID will be the old reportID (not the newest one from the participant selection step) while transaction.reportID is a latest reportID value -> Causing the IOU.initMoneyRequest to run and reset the whole transaction again

How will the side effect run if we won't re-render the screen?

@dominictb I noticed that the report id does not always change when a participant is selected. Can you investigate this and see if we can keep the same report id? (only the ones in the "Recent" section causes the change)
https://github.com/Expensify/App/assets/16493223/932cbb85-b6b6-4648-8e85-86d5e19f1c0e

@dominictb The current implemented solution is adding more complexity to the flow. I think we should either:

Push forward with the changes that come after setting transaction.reportID (e.g. replace useEffect with useFocusEffect, etc.)
Get rid the second useEffect that's causing the reinit, see what problem it's fixing and fix it in another way

Bug: After selecting a participant and going back the money request is reset
https://github.com/Expensify/App/assets/16493223/9293894d-c887-4921-8c09-7ed6a8c9af06

@dominictb Setting the transaction report id on participant selection is the right approach. Setting the report id only after refresh is a workaround. When going back can we use the transaction report id instead of the previous uri param report id?

I'm afraid this is getting more complex than initially evaluated. Do you think we should close the PR and get back to the issue to construct a more solid proposal that covers the new found case

@dominictb The money request should not reset on going back to the start page. All the rest behaviour should be kept as is


support Pydantic v2

Currently Pydantic version is pinned to v1.
https://github.com/SupImDos/pydantic-argparse/blob/c07199879040f9cfd26f13b2cfbeb8105a3c830f/pyproject.toml#L23
Is is possible to loose this restriction to support Pydantic v2?

I really want pydantic 2 support.

I took a look at this briefly; pydantic 2 comes with quite a few breaking changes. so it will require some work beyond loosening the restriction. I considered putting up a PR but realized it was a bit of a rabbit hole. I like this library; but it is currently keeping my team from upgrading to pydantic 2

If you feel like it, you could have a go with something I made: https://pypi.org/project/clipstick/

@SupImDos  -- thanks for your work on pydantic-argparse, it looks excellent.
Can you provide any update as to whether you are intending to add support for pydantic v2 in the near future?

hey, just want to say that I really like the project. As other said it would be great to have pydantic v2 support.
I have been working in the past in having compatibility for pydantic v1 and v2 in one library. It is not trivial.
Since pydantic-argparse seems quite new and pydantic v2 is getting really mature, it might be a good idea to just drop support for v1 and move to v2.
Just a proposition ofc.
Best

Thanks @samsja. I've spoken to some people recently and am coming to the same conclusions. Is the library that you mentioned working on public? I would be interested in having a look if so :grin:

the library I was referring to was https://github.com/docarray/docarray


[websocket-nio]Close connection for invalid UTF-8 payload data

The connection must be dropped/closed with error code 1007 if the payload is not a valid UTF-8 encoded data

@nethraravindran Can you resolve the merge conflicts please?

@pushkarnk  Resolved the conflicts :)


Try mapping to schema

using example https://raw.githubusercontent.com/nomad-coe/electronic-parsers/develop/tests/data/vasp/AgAc_relax/vasprun.xml.relax

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
15

Relevant Lines:
15

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
15

Relevant Lines:
15

💛  - Coveralls


[stable/prometheus-rabbitmq-exporter] fix values

Fix values.yaml file
annotation to annotations

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:

/check-cla

/check-cla

/assign @sameersbn

/ok-to-test

/lgtm

/lgtm


Execution failed for task ':app:mergeDexRelease'.

Hi There,
I am experiencing this issue, you guys have any ideas about this one?
`* What went wrong:
Execution failed for task ':app:mergeDexRelease'.

A failure occurred while executing com.android.build.gradle.internal.tasks.Workers$ActionFacade
com.android.builder.dexing.DexArchiveMergerException: Error while merging dex archives:
Type org.reactnative.maskedview.BuildConfig is defined multiple times<EMAIL_ADDRESS><EMAIL_ADDRESS>Learn how to resolve the issue at https://developer.android.com/studio/build/dependencies#duplicate_classes.

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/6.1.1/userguide/command_line_interface.html#sec:command_line_warnings`

same issue

I am also having same issue

I too

add this line to gradle.properties
org.gradle.daemon=true
org.gradle.jvmargs=-Xmx2048m

Same here

Resolved:
I have two packages @react-native-masked-view/masked-view (from previous developer) and @react-native-community/masked-view.
Just remove @react-native-masked-view/masked-view package and try build.

@Navipro70 thank you so much <3

Resolved:
I have two packages @react-native-masked-view/masked-view (from previous developer) and @react-native-community/masked-view.
Just remove @react-native-masked-view/masked-view package and try build.
@FonDorn close this one please

Works, thx 👍

Closing as the issue seems to be resolved, thanks!

Resolved: I have two packages @react-native-masked-view/masked-view (from previous developer) and @react-native-community/masked-view. Just remove @react-native-masked-view/masked-view package and try build.
@FonDorn close this one please

You saved my day man!!!

Resolved: I have two packages @react-native-masked-view/masked-view (from previous developer) and @react-native-community/masked-view. Just remove @react-native-masked-view/masked-view package and try build.
@FonDorn close this one please

our savior :D

Great save my Day

@Navipro70 hey this is not working for me.

What went wrong:
Execution failed for task ':app:mergeDexRelease'.

A failure occurred while executing com.android.build.gradle.internal.tasks.Workers$ActionFacade
i'm facing this issue when i make a release build in react native.

@Navipro70 hey this is not working for me.

What went wrong:
Execution failed for task ':app:mergeDexRelease'.

A failure occurred while executing com.android.build.gradle.internal.tasks.Workers$ActionFacade
i'm facing this issue when i make a release build in react native.

please help


World size

Hi,
is there a way to create a world that is bigger then the actual window ?
If yes, is there any limitation?
Thanks

do you mean the bounds of the world or or just the function ofxBox2d.createBounds() ?

Yes, ofxBox2d.createBounds(x,y,w,h) is what I was looking for.
Thanks.


Dashboard base functionality

Dashboard base functionality

Display transaction list on dashboard home
Display an information card for the community

Looks good. It can be merged.


Improve the speed of the aggregation dataview

Improve the performance of the aggregation dataview.
Instead of using a CTE (WITH) for filtered_source, which is only used in
one place to calculate ranks, inject it as a subquery.
This way the planner has a chance to ignore uneeded columns as well as
to parallelize the exectution of the window function (WindowAgg in the
query plan).
That is the part that takes most of the time of the query.
The improvement is about 30-40% in speed on PG10 with 4 cores. With PG9.5 it is slightly better, but by a tiny 1%, depending on the underlying table and specific request.

I need to have a deeper look into the exact query sent to Postgres to see if more improvements are possible, but I'd switch the summary query to look something like the one in the formula widget which handles floats faster (at uses aux functions).

If you have a recommended datasets that uses dataviews I'll test it in my main machine tomorrow and see if I can come up with any other improvements once I see the query and the plan, but the change in the PR is good and could be merged right meow.

I'd go for deploying this and creating specific tickets for the dataviews and widgets that we can still optimize instead.

This was released as part of 5.3.1.
Testing with local machine:

Postgresql: 11devel
Dataset: yellow_1m (1 million rows from one of the NY Taxi datasets).
Widget covering most of the points.
Timings before this change (warn DB):

1072.165
1015.840
1079.679
1052.620
1046.132
1017.587

Timings after this change (warn DB):

741.660
755.639
758.388
710.836
757.422
713.109

All in all, great improvement.


Review 6

Overview
We are going to review the Landing and Budget page.
Review Branch
review-6
Files to review
File 1: Landing
File 2: Budget
Checklists
Architecture
Design
JS
React
Due date
10/21/24
For more information
The review process is documented at: http://courses.ics.hawaii.edu/ics414f24/morea/review/reading-idpm-review.html

File 1:  Styles could be abstracted into a CSS or SCSS file for better readability and maintainability..
File 2: Consistent usage of inline styles but separating these into CSS files would improve maintainability.

File 1: open a React fragment with <> at the beginning, but it is not properly closed at the end

File 1: Agree with darius, most of the style should be held in a separate file to be used repeatedly on other pages
File 2: Create new role types and access restrictions for those roles

File 1: Move styles to CSS file to make code more readable
File 2: Add comments, explain how schema works

File 2: add missing data.

File 1: Make text expandable for a cleaner look
File 2: Organize data by adding comments on the different sections the data belongs to.


Method to check whether a Fabric model was set up already

Description & Motivation
Currently, if you pass a model to Fabric.setup() that has already been wrapped/set up, you get an error. This is currently expected, because there are several reasons and edge cases where this would be invalid usage. However, the only way to check whether a model is set up already is with an instance check on a protected class:
already_set_up = isinstance(model, _FabricModel)

There are valid use case where such a check comes up. For example:
You build a trainer that has a fit method with the following implementation.
model, optimizer = fabric.setup(model, optimizer)
for epoch in range(epochs):
    self.train(model, optimizer)
    self.validate(model)

This trainer has a validate() method that can either be called separately, or internally within the fit loop. Hence, the validate() method needs to check whether the model was already set up.
Pitch
Introduce Fabric.is_setup(), or function is_setup().
assert not is_setup(model)
model = fabric.setup(model)
assert is_setup(model)

Alternatives
There are two alternatives:
Alternative 1
Make the Fabric.setup() a no-op when a model is passed in that was already set up. However, there are problematic edge cases, that break the contract with the strategies. For example, when setup is called with a model that is already set up, but an optimizer that is not set up yet:
model = setup(model)
model = setup(model, optimizer)  # what should happen?

OR
If a model is set up twice but with different optimizers
model, optimizer1 = setup(model, optimizer1)
model, optimizer2 = setup(model, optimizer2)

Alternative 2
The example I gave with the shared validation loop could also be re-written like this:
def train(model, optimizer):
    ...

def validate(model):
    model = fabric.setup(model)
    return self._validate(model)

def _validate(model):
    # this assumes the passed in model is already set up

def fit(model):
    model, optimizer = fabric.setup(model, optimizer)
    for epoch in range(epochs):
        self.train(model, optimizer)
        self._validate(model)  # call _validate(), not validate()

Additional context
cc @borda @tchaton @justusschock @awaelchli @carmocca @pietrolesci

Would a property work too?
Do we need separate is_*_setup functions for the different components that can be set-up?

A property wouldn't work. You wouldn't be able to check model.is_setup() if model is an nn.Module (and therefore not set up). It would either have to be a function
def is_setup(module) -> bool:
    return isinstance(module, _FabricModule)

or a (static) method on the Fabric object:
def is_setup(self, module) -> bool:
    return isinstance(_FabricModule)

Is this open can I take this up ? Also amazing work with fabric 📦

Thank you @Atharva-Phatak! Happy to let you take this. We need to decide whether to make this a function or a method. What are your thoughts? Also @justusschock @carmocca I would make it a function.
On another note, I'm generally not so pleased about the name of "setup". We use it as an action/verb, but it is backwards because in English, the verb is actually spelled "set up", and "setup" is the noun. This makes it awkward when using Fabric.setup, but is even more cringe when we have something like is_setup as a function name 😅

A function would be much better since it would be independent of the fabric class. For the name, may I suggest the name check_state ?

I agree with choosing a function. I wouldn't go with changing the "setup" name. It's widely used in software projects, including this one. It's familiar even if it's not the most natural English name to read

I also agree with this being a function. Similar to @carmocca , I'd keep the setup terminology.
@Atharva-Phatak with state usually we mean something different as this isn't really about the internal state but more whether a specific function call has already happened.
Also it should be something with is_X so that returning a bool actually makes sense.

Hi there, my two cents: lightning.fabric.is_wrapped.
I think that a module-level function (like in torch.is_tensor) would be great and I think that is_wrapped is a pretty explanatory name for it since we are wrapping nn.Modules in Fabric (also, wrapping in "fabric" has also a nice physical sound to it :)).
def is_wrapped(module: Union[nn.Module, _FabricModule) -> bool:
    ...

I think this is a good alternative too. I like it.

@awaelchli Sounds good. I will get cracking on this.

@awaelchli Should I also include this check in the Fabric class in the train or validate function ? or let the user check it?

There isn't really much to do in the fabric class. It is primarily for the user. Maybe we have some internal places where it can be used, but at the end of the day it's just an instance check disguised as a function  :))


Please add BasicAuth env variable support

Thank you for the project!
I think it will be important to add BasicAuth env variable. Yes, it's possible to setup it via the mounted config file, but BasicAuth is a mandatory thing because the web proxy can be accessed by anyone on the web, which can be easily abused and is very dangerous.
BasicAuth description: https://tinyproxy.github.io/#BasicAuth

Yeah, that's a good idea. Changes seem good. I'll test it a bit later and merge after that.

Thanks for the contribution!
I also added support for secrets-files.


Invalid autoloader

Hi,
after cloning your repo at the first composer install i have this error and i can't continue to install this app.
Please check this:
> Illuminate\Foundation\ComposerScripts::postAutoloadDump
PHP Warning:  Uncaught ErrorException: require(/var/www/html/MotionGym/vendor/composer/../../App/Http/Helpers.php): failed to open stream: No such file or directory in /var/www/html/MotionGym/vendor/composer/autoload_real.php:69
Stack trace:
#0 /var/www/html/MotionGym/vendor/composer/autoload_real.php(69): Composer\Util\ErrorHandler::handle(2, 'require(/var/ww...', '/var/www/html/M...', 69, Array)
#1 /var/www/html/MotionGym/vendor/composer/autoload_real.php(69): require()
#2 /var/www/html/MotionGym/vendor/composer/autoload_real.php(59): composerRequire22976e1edcdfa6a30f7e0bae6c8df695('307a8353bcbdf62...', '/var/www/html/M...')
#3 /var/www/html/MotionGym/vendor/autoload.php(7): ComposerAutoloaderInit22976e1edcdfa6a30f7e0bae6c8df695::getLoader()
#4 /var/www/html/MotionGym/vendor/laravel/framework/src/Illuminate/Foundation/ComposerScripts.php(43): require_once('/var/www/html/M...')
#5 phar:///usr/local/bin/composer/src/Composer/EventDispatcher/EventDispatcher.php(305): Illuminate\Foundation\ComposerScripts::postAutoloadDump(O in /var/www/html/MotionGym/vendor/composer/autoload_real.php on line 69

Hey Alex, I've been looking at the problem you reported, I've found a possible cause which is line 45 @compose.json, anyway.
I would recommend following the development environment installation guide if you want to test the platform.


I found a broken link

looks like the support dump link is broken.
https://docs.docker.com/ee/ucp/admin/monitor-and-troubleshoot/troubleshoot-with-logs/#get-a-support-dump

It should point to something like this https://docs.docker.com/datacenter/ucp/2.2/guides/get-support/, thanks reporting @wannaknowmo

@joaofnfernandes could you triage please?

Fix broken link #6852


Added initial navigation menus and some service logic

Added initial navigation menus and some service logic

Merged menus-nav branch into development