Setting  MIME type before picking data

@samsymons @jgritman @ScottPetit @jotaemepereira  Is it possible to display a list of data in the picker view which matches our preferable MIME-type. i.e) We need to fetch only .mov means we need to display .mov files alone in the list. If this feature is available it will be very very useful. Could you please help me with this? Thanks in advance

@Elamuruga So as you've described isn't exactly possible using Apples APIs.  I pushed up a new branch https://github.com/helpscout/HSAttachmentPicker/tree/feature/customizing-document-image-types that adds public access to what is passed to the UIImagePickerViewController and PHPickerConfiguration.  You could set
picker.mediaTypes = [(NSString*)kUTTypeMovie] on iOS 13 and picker.pickerFilters = [PHPickerFilter.videosFilter] on iOS 14 to only show video types.  I'll see about getting a PR open from that branch.

@Elamuruga So as you've described isn't exactly possible using Apples APIs. I pushed up a new branch https://github.com/helpscout/HSAttachmentPicker/tree/feature/customizing-document-image-types that adds public access to what is passed to the UIImagePickerViewController and PHPickerConfiguration. You could set
picker.mediaTypes = [(NSString*)kUTTypeMovie] on iOS 13 and picker.pickerFilters = [PHPickerFilter.videosFilter] on iOS 14 to only show video types. I'll see about getting a PR open from that branch.

@ScottPetit Thank you a lot for your immediate response. The same approach we can follow to filter image, audio, camera for image and camera to take video, etc.. know? Could you please help me with this? If it is please verify this branch and merge this to in master it will be very useful. Thanks in advance

@Elamuruga no this doesn't apply to camera capture and I'm not sure that's possible with the API that's currently being used.  If so feel free to open a PR to address it.


Add scan and scanM enumeratees

This was an oversight—it's a totally reasonable thing to have, but I've somehow not needed it myself until last night, when I was updating @tixxit's delimited library to the latest iteratee.io version and realized it would make things a lot easier.
I've also bumped some versions and will probably publish a new release tonight or tomorrow.

Ah - delightful!

One thing: I feel like scan should only need Applicative but this felt like the most straightforward implementation and I haven't had time to try out alternatives. I'll probably just publish this as is and open an issue so we don't forget to investigate later.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@cb5f7cd). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #198   +/-   ##
=========================================
  Coverage          ?   97.55%
=========================================
  Files             ?       28
  Lines             ?      900
  Branches          ?       57
=========================================
  Hits              ?      878
  Misses            ?       22
  Partials          ?        0

Impacted Files
Coverage Δ

core/src/main/scala/io/iteratee/Enumeratee.scala
100% <100%> (ø)

core/src/main/scala/io/iteratee/Enumerator.scala
100% <100%> (ø)

.../src/main/scala/io/iteratee/EnumerateeModule.scala
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb5f7cd...afdd878. Read the comment docs.


Provide API to declaratively customize AboutCard

Hey, I just made a Pull Request!
While working on #15069, I made changes to AboutCard to make it possible to customize the AboutCard in YAML. Before we can provide a declarative YAML API, we need to expose a declarative TypeScript API. This PR brings the declarative TypeScript API changes while work on #15069 continues.
Changes
AboutCard

I wanted to make it as easy as possible to add, remove or change information on the AboutCard. I broke up the card into 3 customizable areas: primaryButtons, secondaryButtons & fields. Each of these areas can be customized with their respective properties in their props. Each has defaults. Each default is exported to allow importing them when necessary.
I'm not sure what is the best way to allow people to add buttons and fields. I'm not exporting primaryButtons, secondaryButtons and fields arrays, so people have to manually write them out like this.
import {
  EntityDescriptionAboutField,
  EntityDomainAboutField,
  EntityEditMetadataButton,
  EntityLifecycleAboutField,
  EntityLocationTargetsAboutField,
  EntityOwnerAboutField,
  EntityParentComponentAboutField,
  EntityRefreshButton,
  EntitySystemAboutField,
  EntityTagsAboutField,
  EntityTypeAboutField,
  EntityViewInSourceButton,
  EntityViewInTechDocsButton,
  AboutCard
} from '@backstage/plugin-catalog'

<AboutCard
  primaryButtons={
   [<EntityViewInSourceButton />, <EntityViewInTechDocsButton /> /* add your buttons here */]
  }
  secondaryButtons={
   [<EntityRefreshButton />, <EntityEditMetadataButton /> /* add your buttons here */]
  }
  fields={[
     <EntityDescriptionAboutField />,
     <EntityOwnerAboutField />,
     <EntityDomainAboutField />,
     <EntitySystemAboutField />,
     <EntityParentComponentAboutField />,
     <EntityTypeAboutField />,
     <EntityLifecycleAboutField />,
     <EntityTagsAboutField />,
     <EntityLocationTargetsAboutField />
     /* add your fields here */
   ]
  }
/>

Adding custom primary buttons
import { IconLinkVertical } from '@backstage/core-components';
import { EmojiPeople } from '@material-ui/icons'

<AboutCard
  primaryButtons={
   [
     <EntityViewInSourceButton />,
     <EntityViewInTechDocsButton />,
     <IconLinkVertical
       label="Hello World"
       icon={EmojiPeople}
   ]
  }
/>

Adding custom secondary button
import { IconLinkVertical } from '@backstage/core-components';
import { IconButton } from '@material-ui/core';
import { EmojiPeople } from '@material-ui/icons'

<AboutCard
  secondaryButtons={
   [
     <EntityRefreshButton />,
     <EntityEditMetadataButton />,
     <IconButton aria-label="Hello World" title="Hello world!!!">
       <EmojiPeople />
     </IconButton>
   ]
  }
/>

Adding a custom field
import {
  EntityDescriptionAboutField,
  EntityDomainAboutField,
  EntityLifecycleAboutField,
  EntityLocationTargetsAboutField,
  EntityOwnerAboutField,
  EntityParentComponentAboutField,
  EntitySystemAboutField,
  EntityTagsAboutField,
  EntityTypeAboutField,
  AboutCard
from '@backstage/plugin-catalog'
import {
  AboutField
} from '@backstage/plugin-catalog-react';

<AboutCard
  fields={
     <EntityDescriptionAboutField />,
     <EntityOwnerAboutField />,
     <EntityDomainAboutField />,
     <EntitySystemAboutField />,
     <EntityParentComponentAboutField />,
     <EntityTypeAboutField />,
     <EntityLifecycleAboutField />,
     <EntityTagsAboutField />,
     <EntityLocationTargetsAboutField />
     <AboutField label="Urgency" value="Not specified" gridSizes={{ xs: 12, sm: 6, lg: 4 }} />
  }
/>

Entity Ref related changes
While breaking up the AboutContent component, I noticed @freben's TODO . Making the change made my code clear so I made the change

Changed getEntityRelationships to return a string and removed @freben's TODO
Modified humanizeEntityRef to accept a string, to make it easier when working with a mix of strings or compoundRefs
Allowed stringifyEntityRef to accept a string, in which case it just returns the string

Questions

Are we comfortable with import {primaryButtons, secondaryButtons, fields} from "@backstage/plugin-catalog"? How do we want people to work with defaults?

TODO

[ ] Restore HeaderIconLinkRow links property so it accepts either links or children
[ ]

:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[ ] All your commits have a Signed-off-by line in the message. (more info)

Related PRs

Previous attempt at similar problem - https://github.com/backstage/backstage/pull/14544
https://github.com/backstage/backstage/issues/6175
RFC that impacts this https://github.com/backstage/backstage/pull/11819


Is the underlying tree data structure exposed?

I have a need to identify whether or not the target node of a dragged node is currently a child of the dragged node (either directly or somewhere further down the line). Presumably there is already some data structure under the hood representing the tree, so it would be great if I could do a lookup to get straight to the target node and easily identify all the children. Is that data structure exposed at all or is there any function I can call that would help? Love the plugin, thanks a lot!

All of this data should be exposed in the nodes you supply yourself. Every node has a parentId referring to the parent node. Flowy Vue itself doesn't offer any utilities for this.


Troubles debugging a XAML issue

Hello
I'm running into a crash
Exception thrown at 0x00007FF8D2BC07AC (KernelBase.dll) in CredentialUIBroker.exe: WinRT originate error - 0x80004005 : 'Cannot locate resource from 'ms-appx:///Microsoft.UI.Xaml/Themes/21h1_themeresources.xaml'.'.
'CredentialUIBroker.exe' (Win32): Loaded 'C:\Windows\System32\bcrypt.dll'. Symbols loaded.
Exception thrown at 0x00007FF8D2BC07AC in CredentialUIBroker.exe: Microsoft C++ exception: winrt::hresult_error at memory location 0x000000C94097F0F0.

 	KernelBase.dll!RaiseException()	Unknown
 	Microsoft.UI.Xaml.dll!_CxxThrowException(void * pExceptionObject, const _s__ThrowInfo * pThrowInfo) Line 75	C++
 	Microsoft.UI.Xaml.dll!winrt::throw_hresult(const winrt::hresult result) Line 4892	C++
>	[Inline Frame] Microsoft.UI.Xaml.dll!winrt::check_hresult(const winrt::hresult) Line 4962	C++
 	Microsoft.UI.Xaml.dll!winrt::impl::consume_Windows_UI_Xaml_IResourceDictionary<XamlControlsResources>::Source(const winrt::Windows::Foundation::Uri & value) Line 2209	C++
 	Microsoft.UI.Xaml.dll!XamlControlsResources::UpdateSource() Line 136	C++
 	[Inline Frame] Microsoft.UI.Xaml.dll!XamlControlsResources::{ctor}() Line 31	C++
 	Microsoft.UI.Xaml.dll!winrt::impl::heap_implements<XamlControlsResources>::heap_implements<XamlControlsResources>()	C++
 	[Inline Frame] Microsoft.UI.Xaml.dll!winrt::make() Line 7703	C++
 	[Inline Frame] Microsoft.UI.Xaml.dll!winrt::Microsoft::UI::Xaml::Controls::factory_implementation::XamlControlsResourcesT<winrt::Microsoft::UI::Xaml::Controls::XamlControlsResourcesFactory,XamlControlsResources>::ActivateInstance() Line 42	C++
 	Microsoft.UI.Xaml.dll!winrt::impl::produce<winrt::Microsoft::UI::Xaml::Controls::XamlControlsResourcesFactory,winrt::Windows::Foundation::IActivationFactory>::ActivateInstance(void * * instance) Line 6300	C++
 	Windows.UI.XamlHost.dll!winrt::Windows::Foundation::IActivationFactory::ActivateInstance<struct winrt::Microsoft::UI::Xaml::Controls::XamlControlsResources>(void)	Unknown
 	Windows.UI.XamlHost.dll!<lambda_1f68f4413181401bb9e1178e14cf0745>::<lambda_invoker_cdecl>(struct winrt::Windows::Foundation::IActivationFactory const &)	Unknown
 	Windows.UI.XamlHost.dll!winrt::impl::factory_cache_entry<struct winrt::Microsoft::UI::Xaml::Controls::XamlControlsResources,struct winrt::Windows::Foundation::IActivationFactory>::call<struct winrt::Microsoft::UI::Xaml::Controls::XamlControlsResources (*)(struct winrt::Windows::Foundation::IActivationFactory const &)>(struct winrt::Microsoft::UI::Xaml::Controls::XamlControlsResources (*&&)(struct winrt::Windows::Foundation::IActivationFactory const &))	Unknown
 	Windows.UI.XamlHost.dll!winrt::Microsoft::UI::Xaml::Controls::XamlControlsResources::XamlControlsResources(void)	Unknown
 	Windows.UI.XamlHost.dll!XAMLHostWindowImpl::_SetupApplicationResources(void)	Unknown
 	Windows.UI.XamlHost.dll!XAMLHostWindowImpl::_InitializeXamlContent(void)	Unknown
 	Windows.UI.XamlHost.dll!XAMLHostWindowImpl::_CreateHostWindow(void)	Unknown
 	Windows.UI.XamlHost.dll!XAMLHostWindowImpl::_Show(void)	Unknown
 	Windows.UI.XamlHost.dll!<lambda>(void)()	Unknown
 	Windows.UI.XamlHost.dll!ASTAThreadHost::ASTAThreadHostStartThreadProc(unsigned long)	Unknown
 	Windows.UI.XamlHost.dll!ASTAThreadHost::s_ASTAThreadHostStartThreadProc()	Unknown
 	SHCore.dll!_WrapperThreadProc()	Unknown
 	kernel32.dll!BaseThreadInitThunk()	Unknown
 	ntdll.dll!RtlUserThreadStart()	Unknown

When I try to debug this i get the following error message:
You need to find base.h to view the source for the current call stack frame

Source Link Error:
git-credential-manager-core.exe: Could not obtain credentials. Process failed with exit code -532462766.
ERROR: The request failed with code 404 : "Not Found". Treating 404 as authentication failure. Some services return 404 instead of 401 for authentication failures.

Source Link URL: https://raw.githubusercontent.com/microsoft/microsoft-ui-xaml/7ac3c8dfe2f6269d963d4cf44a4f666ea0a58d12/BuildOutput/Intermediates/x64/Microsoft.UI.Xaml/obj/Generated Files/winrt/base.h

Apparently this BuildOutput is no longer online?
Can I find the right source version some ware else?
And before you ask how I produce this crash, its CredentialUIBroker.exe running under sandboxie's supervision on windows 11 on 10 it works fine.
So I have to understand what's causing the crash and find a fix without being able to change anything but sandboxie itself, fun!
It is quite strange that being sandboxed makes the process fail to locate resource, the issue is present even without most sbie isolation mechanisms being engaged, only COM virtualization is enough to break it, and I cant test without that as than the calling process talks to the real system and starts a un sandboxed CredentialUIBroker.exe
Any help/advice would be greatly appreciated.

@StephenLPeters @ojhad @asklar Please consider assigning meaningful labels and/or a specific title to this issue.

@DavidXanatos base.h is a generated file from C++/WinRT and that is why it is not showing up in the GitHub repo and why the debugger cannot locate it. However, I don't think it would help debugging this issue very much anyway since that file mostly contains simple helper functions that are used by C++/WinRT. In this case 'check_hresult' is converting an error HRESULT to an exception. The real issue is what you see in the exception: 'Cannot locate resource from 'ms-appx:///Microsoft.UI.Xaml/Themes/21h1_themeresources.xaml'.'
How is this program consuming Microsoft.UI.Xaml? Is it coming from the framework work package or is it included in the app itself? You can check this by looking at the path to Microsoft.UI.Xaml.dll and seeing if it is inside the app package or if it is in the dedicated "Microsoft.UI.Xaml" framework package path (e.g. something like C:\Program Files\WindowsApps\Microsoft.UI.Xaml.2.7...).
If it is coming from the framework package path, make sure that the app's appxmanifest as a packagedependency on Microsoft.UI.Xaml.

hmmm... well as this file is the CredentialUIBroker.exe its located in c:\Windows\System32\ and those has no app package of its own,
it is loading this one: 'C:\Windows\SystemApps\Microsoft.UI.Xaml.CBS_8wekyb3d8bbwe\Microsoft.UI.Xaml.dll'

In that case it should be loading the resources from the resources.pri that is next to M.U.X.dll in that directory. It seems like that resources.pri file is not getting loaded for some reason.

Thanks for the help, I solved the issue, for the time being its working fine :)


Update auth, dynamodb, s3, sqs to 2.17.142

Updates

software.amazon.awssdk:auth
software.amazon.awssdk:dynamodb
software.amazon.awssdk:s3
software.amazon.awssdk:sqs

from 2.17.66 to 2.17.142.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #852.


Rename 'samples' to 'integrations'

Fixes #1682
To avoid potential confusion, we rename this folder. These are not good samples for users to refer to as an example of how to build .NET Aspire applications. There's non-standard stuff in these projects to support development within this repo.
Also add a README.md file in that folder to direct people to the sample repo.
If this change is merged, developers of this repo will need to re-select their startup project.
Microsoft Reviewers: Open in CodeFlow

What was the consensus here from the conversations we had this week? I thought we were going to keep samples as is but stop using it as a playground for trying things out. I've actually put up another PR which adds a src/Playgrounds folder for some Cosmos experimentation I'm doing.
#1697

Note, I don't have a strong opinion on integration vs playgrounds. I just want to make sure that we were moving the samples/eshoplite sample (which is more sample-like rather than a more focused driver project).

eShopLite, dapr and orleans are all going to need code that's specific to this repo, which should not be copy/pasted into user projects.
The differences will be in the app hosts. In the projects being moved here, they'll:

Suppress the default dashboard.
Register this repo's dashboard project as a resource.

As mentioned on Teams, we'll need the app model ordering changes to respect both the workload executable, and also the project resource, so that this mechanism works, allowing us to test with real integration test suites, with only a few modifications to make them work.

I think I'd rather use the term "test" somewhere in this name. "TestProjects" or "TestApps". If you really want to use "Integration", I could be OK with "IntegrationTestApps", but I think just "integrations" isn't descriptive enough.

My 2c: I like simply renaming it to "integrations" or "playground". I think using "test" just isn't correct in this case as we have actual tests in the "tests" directory.

I like playground

The thinking is that we would never write automated tests against these projects? CI would make sure they build, but we wouldn't ensure they don't break in other ways? And if we wanted an automated test, we would either move or duplicate the project into tests\testproject?

Thats right @eerhardt

Renamed integrations to playground and fixed merge conflicts.


Forge 1.13.2 Is Out (Link in Desc.)

I can't seem to find my old issue report so I've created a new one.
Forge 1.13.2 has been released, so could you please add a block for it? Thank you! :)
Link: https://files.minecraftforge.net/maven/net/minecraftforge/forge/index_1.13.2.html

First, you are on the wrong repository! You should report to DoNotSpamPls/eZProtector.
Thanks for the heads-up anyway, I'll be sure to add this when I can.

Ah whoops. Sorry. I know you've seen it now, so I'm not sure if I should post it at correct location. I will just in case.
https://github.com/DoNotSpamPls/eZProtector/issues/37
Thank you!


suggest collectionTypes/singleTypes can set a async/await function

Because I have a lot of data, I want to classify and query the data, but there are also a lot of classifications. I need to take the classifications from the database and mark the ID of each classification respectively. Therefore, I think I need a async/await function here.
{
  resolve: "gatsby-source-strapi",
  options: {
    apiURL: "http://localhost:1337",
    collectionTypes: async () => {
      reurn await myFetchFunc()  // fetching data
    },
    queryLimit: 1000,
  }
}

Thanks for your interest in this project. This plugin is moving into the Gatsby User Collective and this repo will be archived. Please open an issue in that repository, submit a PR if you'd like to see this implemented, or join us on Discord if you have questions!


fixed name for scrollingDivs for func showModal

for modal container correct name of scrollingDivs is "modal_container"
old code didn't scoll panel, and thus didn't display content

Thanks for the fix.  I'll rebuild the build files soon.


Line 211: [Warning] Invalid file link:(~/concepts/messaging-extensions/search-extensions#Authentication).

msteams-platform/concepts/task-modules/task-modules-bots.md

Line 13: [Warning] Invalid file link:(~/concepts/cards/cards-actions#invoke).
Line 13: [Warning] Invalid file link:(~/concepts/cards/cards-actions#adaptive-card-actions).
Line 14: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-overview#task-module-deep-link-syntax).
Line 14: [Warning] Invalid file link:(~/concepts/cards/cards-actions#openurl).
Line 14: [Warning] Invalid file link:(~/concepts/cards/cards-actions#adaptive-card-actions).
Line 18: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-overview#the-taskinfo-object).
Line 24: [Warning] Invalid file link:(~/concepts/cards/cards-actions#invoke).
Line 26: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-overview#the-taskinfo-object).
Line 48: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-tabs#example-submitting-the-result-of-a-task-module).

msteams-platform/concepts/task-modules/task-modules-overview.md

Line 15: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-tabs).
Line 16: [Warning] Invalid file link:(~/concepts/cards/cards).
Line 16: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-bots).
Line 27: [Warning] Invalid file link:(~/resources/schema/manifest-schema#icons).
Line 28: [Warning] Invalid file link:(~/resources/schema/manifest-schema#name).
Line 30: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-tabs#example-submitting-the-result-of-a-task-module).
Line 42: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-bots#invoking-a-task-module-via-taskfetch).
Line 42: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-bots#the-flexibility-of-task-submit).
Line 42: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-bots#the-flexibility-of-task-submit).
Line 54: [Warning] Invalid file link:(~/resources/schema/manifest-schema#validdomains).
Line 206: [Warning] Invalid file link:(~/resources/schema/manifest-schema#id).
Line 206: [Warning] Invalid file link:(~/resources/schema/manifest-schema#validdomains).

msteams-platform/concepts/task-modules/task-modules-tabs.md

Line 29: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-overview#the-taskinfo-object).
Line 31: [Warning] Invalid file link:(~/concepts/task-modules/(#task-module-invocation-errors)).
Line 32: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-overview#adaptive-card-or-adaptive-card-bot-card-attachment).
Line 36: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-overview#task-module-sample).
Line 78: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-bots#payload-of-task-fetch-and-task-submit-messages).
Line 78: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-bots#payload-of-task-fetch-and-task-submit-messages).

msteams-platform/concepts/messaging-extensions/messaging-extensions-common.md

Line 5: [Warning] Invalid file link:(~/get-started/code#microsoft-teams-extensions-for-the-bot-builder-sdk).
Line 5: [Warning] Invalid file link:(~/get-started/code#microsoft-teams-extensions-for-the-bot-builder-sdk).
Line 11: [Warning] Invalid file link:(~/concepts/bots/bots-create).
Line 11: [Warning] Invalid file link:(~/concepts/bots/bots-create).
Line 17: [Warning] Invalid file link:(~/resources/schema/manifest-schema#composeextensions).
Line 17: [Warning] Invalid file link:(~/resources/schema/manifest-schema#composeextensions).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

resolves #405

@billbliss Have you had a chance to look at this (and/or do you want to?)

Line 13: [Warning] Invalid file link:(~/concepts/cards/cards-actions#adaptive-card-actions).
Line 14: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-overview#task-module-deep-link-syntax).
Line 14: [Warning] Invalid file link:(~/concepts/cards/cards-actions#openurl).
Line 14: [Warning] Invalid file link:(~/concepts/cards/cards-actions#adaptive-card-actions).
Line 18: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-overview#the-taskinfo-object).
Line 24: [Warning] Invalid file link:(~/concepts/cards/cards-actions#invoke).
Line 26: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-overview#the-taskinfo-object).
Line 48: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-tabs#example-submitting-the-result-of-a-task-module).

msteams-platform/concepts/task-modules/task-modules-overview.md

Line 15: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-tabs).
Line 16: [Warning] Invalid file link:(~/concepts/cards/cards).
Line 16: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-bots).
Line 27: [Warning] Invalid file link:(~/resources/schema/manifest-schema#icons).
Line 28: [Warning] Invalid file link:(~/resources/schema/manifest-schema#name).
Line 30: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-tabs#example-submitting-the-result-of-a-task-module).
Line 42: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-bots#invoking-a-task-module-via-taskfetch).
Line 42: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-bots#the-flexibility-of-task-submit).
Line 42: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-bots#the-flexibility-of-task-submit).
Line 54: [Warning] Invalid file link:(~/resources/schema/manifest-schema#validdomains).
Line 206: [Warning] Invalid file link:(~/resources/schema/manifest-schema#id).
Line 206: [Warning] Invalid file link:(~/resources/schema/manifest-schema#validdomains).

msteams-platform/concepts/task-modules/task-modules-tabs.md

Line 29: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-overview#the-taskinfo-object).
Line 31: [Warning] Invalid file link:(~/concepts/task-modules/(#task-module-invocation-errors)).
Line 32: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-overview#adaptive-card-or-adaptive-card-bot-card-attachment).
Line 36: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-overview#task-module-sample).
Line 78: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-bots#payload-of-task-fetch-and-task-submit-messages).
Line 78: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-bots#payload-of-task-fetch-and-task-submit-messages).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Line 14: [Warning] Invalid file link:(~/concepts/cards/cards-action.mds#adaptive-card-actions).

msteams-platform/concepts/task-modules/task-modules-overview.md

Line 15: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-tabs).
Line 16: [Warning] Invalid file link:(~/concepts/cards/cards).
Line 16: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-bots).
Line 27: [Warning] Invalid file link:(~/resources/schema/manifest-schema#icons).
Line 28: [Warning] Invalid file link:(~/resources/schema/manifest-schema#name).
Line 30: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-tabs#example-submitting-the-result-of-a-task-module).
Line 42: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-bots#invoking-a-task-module-via-taskfetch).
Line 42: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-bots#the-flexibility-of-task-submit).
Line 42: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-bots#the-flexibility-of-task-submit).
Line 54: [Warning] Invalid file link:(~/resources/schema/manifest-schema#validdomains).
Line 206: [Warning] Invalid file link:(~/resources/schema/manifest-schema#id).
Line 206: [Warning] Invalid file link:(~/resources/schema/manifest-schema#validdomains).

msteams-platform/concepts/task-modules/task-modules-tabs.md

Line 29: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-overview#the-taskinfo-object).
Line 31: [Warning] Invalid file link:(~/concepts/task-modules/(#task-module-invocation-errors)).
Line 32: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-overview#adaptive-card-or-adaptive-card-bot-card-attachment).
Line 36: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-overview#task-module-sample).
Line 78: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-bots#payload-of-task-fetch-and-task-submit-messages).
Line 78: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-bots#payload-of-task-fetch-and-task-submit-messages).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Line 14: [Warning] Invalid file link:(~/concepts/cards/cards-action.mds#adaptive-card-actions).

msteams-platform/concepts/task-modules/task-modules-overview.md

Line 16: [Warning] Invalid file link:(~/concepts/cards/cards).
Line 42: [Warning] Illegal link: [in the detailed discussion on task/submit](~/concepts/task-modules/task-modules-bots.md#the-flexibility-of-task-submit) -- missing bookmark. The file concepts/task-modules/task-modules-bots.md doesn't contain a bookmark named the-flexibility-of-task-submit.
Line 42: [Warning] Illegal link: [here](~/concepts/task-modules/task-modules-bots.md#the-flexibility-of-task-submit) -- missing bookmark. The file concepts/task-modules/task-modules-bots.md doesn't contain a bookmark named the-flexibility-of-task-submit.

msteams-platform/concepts/task-modules/task-modules-tabs.md

Line 29: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-overview#the-taskinfo-object).
Line 31: [Warning] Invalid file link:(~/concepts/task-modules/(#task-module-invocation-errors)).
Line 32: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-overview#adaptive-card-or-adaptive-card-bot-card-attachment).
Line 36: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-overview#task-module-sample).
Line 78: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-bots#payload-of-task-fetch-and-task-submit-messages).
Line 78: [Warning] Invalid file link:(~/concepts/task-modules/task-modules-bots#payload-of-task-fetch-and-task-submit-messages).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Line 14: [Warning] Invalid file link:(~/concepts/cards/cards-action.mds#adaptive-card-actions).

msteams-platform/concepts/task-modules/task-modules-overview.md

Line 16: [Warning] Invalid file link:(~/concepts/cards/cards).
Line 42: [Warning] Illegal link: [in the detailed discussion on task/submit](~/concepts/task-modules/task-modules-bots.md#the-flexibility-of-task-submit) -- missing bookmark. The file concepts/task-modules/task-modules-bots.md doesn't contain a bookmark named the-flexibility-of-task-submit.
Line 42: [Warning] Illegal link: [here](~/concepts/task-modules/task-modules-bots.md#the-flexibility-of-task-submit) -- missing bookmark. The file concepts/task-modules/task-modules-bots.md doesn't contain a bookmark named the-flexibility-of-task-submit.

msteams-platform/concepts/task-modules/task-modules-tabs.md

Line 31: [Warning] Invalid file link:(~/concepts/task-modules/(#task-module-invocation-errors)).
Line 36: [Warning] Illegal link: [the task module sample](~\concepts\task-modules\task-modules-overview.md#task-module-sample) -- missing bookmark. The file concepts/task-modules/task-modules-overview.md doesn't contain a bookmark named task-module-sample.
Line 78: [Warning] Illegal link: [the schema you receive for task/fetch and task/submit messages](~/concepts/task-modules/task-modules-bots.md#payload-of-task-fetch-and-task-submit-messages) -- missing bookmark. The file concepts/task-modules/task-modules-bots.md doesn't contain a bookmark named payload-of-task-fetch-and-task-submit-messages.
Line 78: [Warning] Illegal link: [when Adaptive cards are used with bots](~/concepts/task-modules/task-modules-bots.md#payload-of-task-fetch-and-task-submit-messages) -- missing bookmark. The file concepts/task-modules/task-modules-bots.md doesn't contain a bookmark named payload-of-task-fetch-and-task-submit-messages.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

 The file concepts/task-modules/task-modules-overview.md doesn't contain a bookmark named task-module-sample.
Line 78: [Warning] Illegal link: [when Adaptive cards are used with bots](~/concepts/task-modules/task-modules-bots.md#payload-of-task-fetch-and-task-submit-messages) -- missing bookmark. The file concepts/task-modules/task-modules-bots.md doesn't contain a bookmark named payload-of-task-fetch-and-task-submit-messages.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit cd8fb57:
:clock10: Preparing: average preparing time is 46 sec(s)

OPS Build status updates of commit cd8fb57:
:clock10: Incremental building: average incremental building time is 20 sec(s)

OPS Build status updates of commit cd8fb57:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/messaging-extensions/create-extensions.md
:white_check_mark:Succeeded

msteams-platform/concepts/task-modules/task-modules-bots.md
:white_check_mark:Succeeded

msteams-platform/concepts/task-modules/task-modules-overview.md
:white_check_mark:Succeeded

msteams-platform/concepts/task-modules/task-modules-tabs.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Remove unused table operation type enum

Remove unused enum created to represent a table operation type that's sent from the server.

LGTM, yet you still have two warnings. I don't think it's urgent because it will be used soon...

thanks, agreed that's why I only handled this warning


Update ip4s-core, ip4s-test-kit to 3.0.1

Updates

com.comcast:ip4s-core
com.comcast:ip4s-test-kit

from 3.0.0-RC2 to 3.0.1.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Files still referring to the old version number
The following files still refer to the old version number (3.0.0-RC2).
You might want to review and update them manually.
website/src/hugo/content/changelog.md

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.comcast" } ]

labels: library-update, semver-pre-release, old-version-remains

I thought steward would rebase this one.


Cached expensive values so they don't need to be computed on every mo…

This update caches the lense width/height, image width/height, and .magnify position, which are all expensive to calculate and only change when the page is resized (it updates them on resize).
This update also detaches all old event handlers before attaching new ones.
These changes dramatically improve performance on FireFox and Internet Explorer.

Thanks for this, I'll test and merge when time permits...

@beaulm I have merged your changes related to caching the dimensions. Thanks.


unroll_steps and maximum number of tokens per sequence

As written in the readme that the model uses fixed size of 20 tokens.
Does it mean if I have a sequence of 100 token, the model is going to divide it to 5 training samples ?
If yes, is not that will make the algorithm loose information, if the tokens in this sequence depend on each other to provide a correct meaning ?

Yes, it splits into 5 different batches.  The LSTM states are carried over from batch to batch, but back propagation is only performed with the batch.

In this case, if our sequence "sentence" length is on average 1024 tokens.
Do we have to make the unroll_steps much bigger than 20 because the back propagation is only performed with the batch, or since the LSTM states are carried we don't have to change it ?

If you want to train long contexts, then yes you will see some benefits if you increase unroll steps.  You will also need to decrease the batch size accordingly (the total number of tokens in a batch is equal to batch_size * unroll_steps).  Each line in your input file is treated independently, so when preparing your data make each line one long 1024 token length context.


Improve logging, file operations and Widevine CDM detection

This pull request takes improvements from https://github.com/emilsvennesson/script.module.inputstreamhelper/pull/240 that are ready to be merged:

allow logging on different levels
wrap file operations in kodiutils.py
rework Widevine CDM detection functionality
various spelling and log messages corrections

Why do you use those magic constants with the log function? I very much prefer the real python logging interface where you can just use _LOGGER.debug() etc (like I did in viervijfzes), I'm clearly missing the point here :)

To make sure add-on reviewers don't notice that we are logging to a forbidden level. Silently breaking add-on rules to set a precedent.

Nice and honest :)

I think hardlink should rather be in utils instead of kodiutils. Other than that, looks good to me.

Okay, I moved the hardlink.

Thank, I will rebase #240

BTW I am not so fond of moving hardlink out of kodiutils as we want kodiutils to become a body of work that can be reused by other projects, and the hardlink functionality, while not related directly to kodi is something we think may be useful for other add-on projects as well. It is not inputstreamhelper specific.
But that said, we will fix this when kodiutils has become a separate module that is reused by different projects.

Okay.

Until now, kodiutils was a place to abstract kodi specific functions. hardlink is in no way related to kodi (neither directly nor indirectly). If I would search for a function creating hardlinks, with copy as fallback, I wouldn't look for it in a project called "kodiutils".

I agree with @horstle. IMO kodiutils should only contain functions for kodi. Another example is caching. These functions are useful, but don't belong in kodiutils.

@michaelarnauts That is a strange thing to say when we discussed moving routing in the future kodiutils project. Same for the proxy-handling code.
The general idea was to have one body of work to assist writing add-ons,. If we go and fragment kodiutils now between every add-on using it, there's no point in sharing one codebase.
Caching may be something different as this may be harder to abstract. It may be very close to how a VOD provider stores it metadata.

The general idea was to have one body of work to assist writing add-ons.

Potayo, potahto. Can't we just name this future project addonutils and only group functions that are used by two or more add-ons?

@mediaminister That's the general idea. We postponed this for a few reasons:

Once shared it will be hard to impossible to redesign an interface (so we need versioned libs, and/or synchronised releases)
Some of the interfaces may benefit from a different interface (e.g. show_listing)
For the stubs there may be conflicting use-cases (and maybe the stubs ought to go elsewhere anyway)


DhanuKBEBCChanges

KB - How do i submit EBC Request Changes..

The word docs mentioned in the article aren't included as attachments.
https://github.com/CenturyLinkCloud/PublicKB#attachments


[Issue58] Fixing More Bad GitHub Actions Configuration

My deploy step was indented under my release step which broke GitHub actions some more. This PR fixes that. Changes include:

fixing indentation
adding needs options to deploy job so that it will only run after the release job completes

:tada: This PR is included in version 1.1.7 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


fix: support slice, array type arguments/replies

When checking whether a type was exported or a primitive, we did
not previously consider complex types, like slices or arrays.
Now, Unpack() recursively inspects those.

There may be some edge cases. I have not yet considered how maps or other multi-type not-named constructs (if any exist?) should work here... GetTypeInfo should probably have Packages []string instead of string.


Add eBPF connection tracking, without dependencies on kernel headers

This PR implements connection tracking using eBPF instead parsing /proc. To do not depend on python instead of using iovisor/bcc we use https://github.com/kinvolk/gobpf-elf-loader.

We are making the official one on scope, don't need this anymore


Add check for team.expensify.com emails for default workspace rooms

Details

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/227011
Tests

Same as QA steps EXCEPT make sure to locally override checks for canUsePolicyRooms to false and canUseAllBetas to false
PR Review Checklist

Contributor (PR Author) Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] Any functional components have the displayName property
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] Any functional components have the displayName property
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

QA Steps

[ ] Verify that no errors appear in the JS console

On OldDot, From a team.expensify.com account (guides account), create a COLLECT and CONTROL policy

Invite a second account to the policies (that is not an @expensify.com account) and make them policy admins

Log into the second account in NewDot AND the guides account and ensure you see the default workspace rooms (#announce, #admins) for both the COLLECT and CONTROL policy

Repeat the steps from 1-4 except without a team.expensify.com account OR an account on all betas and ensure that you DO NOT see default workspace rooms

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Did you test after turning all the betas off?

Did you test after turning all the betas off?

Yup, overrode checks for canUsePolicyRooms and canUseAllBetas.  I tested on main with these as well and checked that the opposite case worked as well.  This might actually have to end up being No QA unless we get team.expensify.com emails in time

Same as QA steps EXCEPT make sure to locally override checks for canUsePolicyRooms to false and canUseAllBetas to false

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@thienlnam @Gonals @alex-mechler Can we run this PR with Expensifail.com account to QA?
If not, Can you validate this internally

🚀 Deployed to staging by @Gonals in version: 1.1.99-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

@thienlnam @Gonals @alex-mechler Can we run this PR with Expensifail.com account to QA?
If not, Can you validate this internally

This won't work with an expensifail.com account, we'll do the QA for this internally

I created a new account and added a new collect policy for this user
This is what my NewDot looks like before adding a team.expensify.com email

In OldDot, I added a @team.expensify.com email address to the policy as an auditor
This is what my NewDot looks like after:


Fix typo "suger" -> "sugar"

Love the tool. Noticed a little typo in the docs. Thanks!

Thanks @mokagio


Nice message from lperson

I rule and have completed some work on Case Manager that's ready for review!
This pull request makes the following changes:

I added a nice message to welcome_message_helper.rb

It relates to the following issue #s:

Bumps #884

For reviewer:

Adjust the title to explain what it does for the notification email to the listserv.
Tag this PR:

feature if it contains a feature, fix, or similar. This is anything that contains a user-facing fix in some way, such as frontend changes, alterations to backend behavior, or bug fixes.
dependencies if it contains library upgrades or similar. This is anything that upgrades any dependency, such as a Gemfile update or npm package upgrade.

If it contains neither, no need to tag this PR.

Codecov Report

Merging #2362 (bcea5d5) into main (5403f04) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2362   +/-   ##
=======================================
  Coverage   96.24%   96.24%
=======================================
  Files          79       79
  Lines        1651     1651
=======================================
  Hits         1589     1589
  Misses         62       62

Impacted Files
Coverage Δ

app/helpers/welcome_message_helper.rb
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e3fb3c...bcea5d5. Read the comment docs.

welcome aboard @lperson !


Add Kibana version dependency in the readme

Currently there is no way to know which version of Kibana is needed for this. It will be great to add the version at the Readme.

+1
Would not work for kibana 4.2.x

It requires the development version of kibana, currently 6.0.0-alpha1 from master

There's a compatibility chart in there now, as of bfc649f


[WFLY-17365] Failed deployment is not removed from Undertow ServletContainer's deployments map

https://issues.redhat.com/browse/WFLY-17365

Hello, aogburn. I'm waiting for one of the admins to verify this patch with /ok-to-test in a comment.

/ok-to-test

Please move this line to startContext() method.

Done.

Thanks @aogburn


Feature/eng 135 function deploy

This patch actually touches deploy, publish, and build to round out better path handling.  Some minor refactors and prettier went a little crazy,

closing in favor of https://github.com/txlabs/blockless-cli/pull/35


Sweep: create a fib.py file

sweep: the file should have a fib(n) function that returns the nth fibonacci number.

💎 Sweep Pro: I'm using GPT-4. You have unlimited GPT-4 tickets. (tracking ID: None)

[!TIP]
I can email you when I complete this pull request if you set up your email here!

Actions (click)

[ ] ↻ Restart Sweep

I am currently looking into this ticket! I will update the progress of the ticket in this comment. I am currently searching through your code, looking for relevant snippets.

Step 1: 🔎 Searching
I'm searching for relevant snippets in your repository. If this is your first time using Sweep, I'm indexing your repository. You can monitor the progress using the progress dashboard

🎉 Latest improvements to Sweep:

New dashboard launched for real-time tracking of Sweep issues, covering all stages from search to coding.
Integration of OpenAI's latest Assistant API for more efficient and reliable code planning and editing, improving speed by 3x.
Use the GitHub issues extension for creating Sweep issues directly from your editor.

💡 To recreate the pull request edit the issue title or description.
Something wrong? Let us know.


Fixes #12

Parse the incoming URL, keeping just the pathname.
Continued to refactor index.ts, pulled out core
serving logic into serve.ts, which allows testing
a few more of the edge cases.

Codecov Report
Attention: Patch coverage is 95.74468% with 6 lines in your changes missing coverage. Please review.

Project coverage is 97.83%. Comparing base (f74454f) to head (862dbdb).

Files with missing lines
Patch %
Lines

src/index.ts
90.90%
3 Missing :warning:

src/serve.ts
97.19%
2 Missing and 1 partial :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   96.15%   97.83%   +1.68%
==========================================
  Files           9       11       +2
  Lines         780      831      +51
  Branches       77       81       +4
==========================================
+ Hits          750      813      +63
+ Misses         28       17      -11
+ Partials        2        1       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add integration icon to HomeAssistant 'brands' repo

Would it be possible to add an icon for this integration in to the following repo:
https://github.com/home-assistant/brands
The below file meets the requirements to be accepted (256px, PNG, interlaced, transparent bg)

Many thanks in advance

Thanks for bringing this to my attention. I've created my own version (own paranoia sorry) and the code review can be found at https://github.com/home-assistant/brands/pull/3472

This has now been merged into the brands repo, so this should be available soon. So I'll close this issue as it's solved from my end.


LFS-1197: Empty "Is a type of" displayed for terms from certain vocabularies

Tested
DEV:

LFS-1197 PR:


Cannot find the libgs file during runtime in serverless environment (AWS Lambda)

Is it possible to use ghostscript4js and ghostscript in a serverless environment as AWS Lambda (and Layers)?
I tried to install both ghostscript4js and ghostscript from a Dockerfile to be uploaded in a AWS Layer (Lambda).
FROM lambci/lambda-base-2:build

# Replace shell with bash so we can source files
RUN rm /bin/sh && ln -s /bin/bash /bin/sh

ENV GS_TAG=gs952
ENV GS_VERSION=9.52
ENV NVM_VERSION=0.38.0
ENV NVM_DIR /usr/local/nvm
ENV NODE_VERSION 12.13.0

RUN yum install -y wget

# Install Ghostscript
RUN mkdir /usr/local/src/ghostscript && \
  cd /usr/local/src/ghostscript && \
  wget -qO - https://github.com/ArtifexSoftware/ghostpdl-downloads/releases/download/$GS_TAG/ghostscript-$GS_VERSION.tar.gz | tar -zxf - && \
  cd ghostscript-$GS_VERSION && \
  ./configure --without-luratech && \
  make so

# Copy Ghostscript to be used by Ghostscript4JS
RUN mkdir -p /opt/ghostscript/bin
RUN mv /usr/local/src/ghostscript/ghostscript-$GS_VERSION/sobin/* /opt/ghostscript/bin

# Install nvm
RUN mkdir /usr/local/nvm && \
  wget -qO- https://raw.githubusercontent.com/nvm-sh/nvm/v$NVM_VERSION/install.sh | bash

# Install node and npm
RUN source $NVM_DIR/nvm.sh && \
  nvm install $NODE_VERSION && \
  nvm alias default $NODE_VERSION && \
  nvm use default

ENV NODE_PATH $NVM_DIR/v$NODE_VERSION/lib/node_modules
ENV PATH $NVM_DIR/versions/node/v$NODE_VERSION/bin:$PATH

# Install Ghostscript4JS
RUN mkdir /opt/nodejs && \
  cd /opt/nodejs && \
  npm init -y && \
  npm install node-gyp && \
  npm install ghostscript4js --GS4JS_HOME="/opt/ghostscript/bin"

# Create the ZIP file
RUN cd /opt && zip -r /tmp/gs.zip ghostscript nodejs

But when the AWS Lambda is called, I got this error:
Error: libgs.so.9: cannot open shared object file: No such file or directory
    at Object.Module._extensions..node (internal/modules/cjs/loader.js:1057:18)
    at Module.load (internal/modules/cjs/loader.js:863:32)
    at Function.Module._load (internal/modules/cjs/loader.js:708:14)
    at Module.require (internal/modules/cjs/loader.js:887:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at bindings (/opt/nodejs/node_modules/bindings/bindings.js:112:48)
    at Object.<anonymous> (/opt/nodejs/node_modules/ghostscript4js/lib/ghostscript4js.js:25:31)
    at Module._compile (internal/modules/cjs/loader.js:999:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
    at Module.load (internal/modules/cjs/loader.js:863:32)

Where should be the libgs file during the runtime?
In the GS4JS_HOME folder or is it copied in another folder during ghostscript4js'installation?

Hi @kaldebert,
it search the library libgs.so in the folder you set using the evn variable GS4JS_HOME. When the module is loaded it needs to load the shared library libgs.so otherwise you get the error you reported, An idea could be to copy the library in the folder of your project and the try to install it.
Es.
The folder for your project is my-project and you copy the content of the folder /usr/local/src/ghostscript/ghostscript-$GS_VERSION/sobin/* to my-project/gs
The you can install using the following command:
 npm install ghostscript4js --GS4JS_HOME=../../../gs
I hope that this help you.

This issue is connected to https://github.com/NickNaso/ghostscript4js/issues/61


lets add this to awesome-fp-js

I know this isn't js specific, but the examples are written in js.
What do you think @hemanth?

Yeah, why not? :)

done

:+1:


Context menu: hide/don't show tooltips while a context menu is visible

Don't show (or hide if already shown) hover tooltip when displaying a context menu. This is currently very annoying.
To be solved in egui?

egui fix in https://github.com/emilk/egui/pull/4138

nice one


Updated account restrictions endpoints

@fboucquez @rg911

I know that we are close to the deadline, but due to this change we might want to reconsider to apply metadata's suggestions from @rg911 to achieve better consistency.
One of the reasons for not having separated metadata was due to the account restrictions endpoint structure:

Also, I don't see metadata as a single entity that works by its own. Taking into consideration similar features that depend on others (restrictions, multisig), we are creating endpoints under each main independent concept (e.g. /account/<:id>/restrictons, /account//multisig).

I know that we are close to the deadline, but due to this change we might want to reconsider applying metadata's suggestions from @rg911 to achieve consistency between endpoints.
One of the reasons for not having separated metadata was due to the account restrictions endpoint structure:

Also, I don't see metadata as a single entity that works by its own. Taking into consideration similar features that depend on others (restrictions, multisig), we are creating endpoints under each main independent concept (e.g. /account/<:id>/restrictons, /account//multisig).

i don't really understand the suggestend endpoints here, maybe a list of endpoints + example result would help
but those are my concerns from what i think i understand: i don't see the benefits of this, what does metadata have to do with mosaic restrictions?
also, returning all the metadata given an accountId seems to me like it would be fetching a lot of data from the database and most of it would probably be useless to the client (i think fetching metadata by resource makes more sense than by accountId)
the only thing that makes sense to me, organizationally, is to have the endpoints such as /metadata/{type}/{other_params_conditional_to_type}/, which does not really reduce the number of endpoints

@Vektrat Sorry for not being too specific, I was referring to this:

the only thing that makes sense to me, organizationally, is to have the endpoints such as /metadata/{type}/{other_params_conditional_to_type}/, which does not really reduce the number of endpoints


Add rpc-gas-cap to CLI options

PR description
This PR introduces the CLi optionrpc-gas-cap which allows users to limit the amount of gas used by the  RPC methods eth_call and eth_getEstimateGas.
Fixed Issue(s)

Fixes #6042

as well as trace_call, trace_callMany, and graphQL org.hyperledger.besu.ethereum.api.graphql.internal.pojoadapter.BlockAdapterBase#executeCall

Closing this PR in favor of #6156


Understand how the library works through flowcharts

Basic Public Channel Flow
All Diagrams

Hey @gallegogt, this is really helpful and should be included in the docs. Want to work on this together?

Hi @JakeSCahill, It would be great, I think that as more people contribute knowledge the documentation will be more complete.

Could you maybe add me as a contributor to your draw.io file?
We can discuss thing on Discord and make a plan to integrate it 😄

Could you maybe add me as a contributor to your draw.io file?
We can discuss on Discord and make a plan to integrate it 😄

Just to keep everyone up to date on this.
We are working on getting some example flowcharts for the following messaging workflows:

Announcing the channel (a simplified version of this one)
Publishing masked payloads
Changing the author's signature keys

We've designed some icons for each message type and we're working with our graphic designer to IOTAify the flowcharts at the moment.
If anyone has any other suggestions related to these flowcharts or future ones, please add them here 😄
As soon as we have an example, I'll share it here.

Hey everyone,
What do you think of this style? The icons will be used throughout the docs to help you recognize message types.

Could we also access these graphics for GitHub Repos/articles? It would be nice! :)

The PNGs will be on the documentation repository, do you mean the source SVGs?

Yes, I mean the single boxes - so that we also can create some flows :)

Yeah of course. I'll check in with the designer

Single boxes are available here 😄  @huhn511 https://github.com/iotaledger/documentation/tree/develop/channels/1.0/images


Add onAlwaysForSpot event

Current coverage is 97.54%

Merging #11 into master will decrease coverage by -0.77% as of 30e080e

@@            master     #11   diff @@
======================================
  Files            4       4
  Stmts          119     122     +3
  Branches        21      21
  Methods          0       0
======================================
+ Hit            117     119     +2
  Partial          1       1
- Missed           1       2     +1

Review entire Coverage Diff as of 30e080e

Powered by Codecov. Updated on successful CI builds.


Feature Request: Add used options to output

I would find it very useful if the used options were recorded in the header of the output file.
Something along the lines of:
//------------------------------------------------------------------------------
// <auto-generated>
//     This code was generated using  OData2Poco System.
//     Service Url: https://my.service.url/$metadata
//     MetaData Version: 4.0
//     Generated On: 2021-02-23T20:21:31
//     parameters: -f PocoFileName -a key req max -b
// </auto-generated>
//------------------------------------------------------------------------------
//

Also when using a local file with -r the "Service Url" part of this header is blank - it would be nice if that also contained the value of the -r parameter.

Thanks for feedback. I'll add the feature to the plan of the next release.

A new package v3.5.0 is released and support the feature of adding used options to output and fix the filename.

It's solved and the issue can be closed.


feat: added gitmoji support

Implemented gitmoji support with convert-gitmoji, closes #19

Thanks for working on this 😻 I've added two issues in convert-gitmoji repo for improvements: https://github.com/Intevel/convert-gitmoji/issues

Fixed the mentioned Issues @pi0 ❤

Thanks!! Last thing, do you mind bumping convert-gitmoji to 0.1.0? So that if any later fixes, I don't need to rerelease changelogen (0.1.x are in the range)

Thanks!! Last thing, do you mind bumping convert-gitmoji to 0.1.0? So that if any later fixes, I don't need to rerelease changelogen (0.1.x are in the range) (also please update lockfile. ci is failing)

Done! ❤ @pi0

Thanks!! Last thing, do you mind bumping convert-gitmoji to 0.1.0? So that if any later fixes, I don't need to rerelease changelogen (0.1.x are in the range) (also please update lockfile. ci is failing)

Done @pi0 ❤


First Tab don't hide others tabs

You can reproduce it with your sample page "Tabs with an assigned id.":
https://openam.github.io/bootstrap-responsive-tabs/
Steps:

Click Tab 3. Then Tab 1 Hide and Tab 3 is Show.
Click Tab 1. Then Tab 1 is Show, but Tab 3 is steel on Show mode.

If you can do the same for example tab 2. Reload the site to restart the behavior:
Steps:

Click Tab 3. Then Tab 2 Hide and Tab 3 is Show.
Click Tab 2. Then Tab 2 is Show and Tab 3 is Hide.

That happens too with "Tabs without an assigned id." but with Tab two because is the active tab.

I think i found the problem:
is about active li
I remove  from my code, and doesn't happend the problem. But if i make this then all tabs are hide by default.

Sorry I didn't see that there is an open issue about it:


First character of command can be lower or upper case

Since shellbot is commonly used from diverse devices, it has to adapt to various situations. Feedback from users is that mobile devices puts first character in chat box as upper case, where the same from laptops/desktops puts first character in lower case. Since most commands are in lower case today, it is creating some friction when typing a command in 1:1 space.
The solution is to put the first token submitted to the shell to lower case, so that the right command is ran whatever device is used.

Update works well on DE script.
Commands are now understable with upper and lower case, thanks!

Thanks @Guillain for the feedback. The same will be done for names of lists, so keep posted


[Access Request] report 1322 "Standard Purchase - Order"

🕮 Describe the request
Could you please change the access scope of the following variables to protected?
protected var
    RespCenter: Record "Responsibility Center"; // Name to be changed to ResponsibilityCenter with making it protected
    BuyFromContact: Record Contact;
    PayToContact: Record Contact;
    TotalSubTotal: Decimal;
    TotalAmount: Decimal;
    TotalInvoiceDiscountAmount: Decimal;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 11581.


Required validation for blank, invalid, multiple-function-variable-query-sections

validation is required for blank , invalid and multiple-function-variable-query-sections
blank-function-variable-query yaml
apiVersion: "recommender.com/v1"
kind: "Autotune"
metadata:
 name: "blank-function-variable-query"
spec:
  sla:
    objective_function: "transaction_response_time"
    sla_class: "response_time"
    direction: "minimize"
    function_variables:
    - name: "transaction_response_time"
      query: " "
      datasource: "prometheus"
      value_type: "double"
  mode: "show"
  selector:
    matchLabel: "app.kubernetes.io/name"
    matchLabelValue: "petclinic-deployment"
    matchRoute: ""
    matchURI: ""
    matchService: "https"

invalid-function-variable-query yaml
apiVersion: "recommender.com/v1"
kind: "Autotune"
metadata:
 name: "invalid-function-variable-query"
spec:
  sla:
    objective_function: "transaction_response_time"
    sla_class: "response_time"
    direction: "minimize"
    function_variables:
    - name: "transaction_response_time"
      query: "applimer_mean_seconds"
      datasource: "prometheus"
      value_type: "double"
  mode: "show"
  selector:
    matchLabel: "app.kubernetes.io/name"
    matchLabelValue: "petclinic-deployment"
    matchRoute: ""
    matchURI: ""
    matchService: "https"

multiple-function-variable-query-sections yaml
apiVersion: "recommender.com/v1"
kind: "Autotune"
metadata:
 name: "multiple-function-variable-query-sections"
spec:
  sla:
    objective_function: "transaction_response_time"
    sla_class: "response_time"
    direction: "minimize"
    function_variables:
    - name: "transaction_response_time"
      query: "application_org_acme_microprofile_metrics_PrimeNumberChecker_checksTimer_mean_seconds"
      query: "application_org_acme_microprofile_metrics_PrimeNumberChecker_checksTimer_mean_seconds"
      datasource: "prometheus"
      value_type: "double"
  mode: "show"
  selector:
    matchLabel: "app.kubernetes.io/name"
    matchLabelValue: "petclinic-deployment"
    matchRoute: ""
    matchURI: ""
    matchService: "https"

@rbadagandi - Have the tests been run for this, do they pass now? Can you please add the docker image against which this was tested

I tried running the tests for --testsuite=app_autotune_yaml_tests  and the 5/9 test cases fail.
How should I proceed with the next steps to fix the issue?
Failed cases are :
   	  blank-function-variable-query
   	  invalid-function-variable-query
   	  numerical-function-variable-query
   	  valid-function-variable-query
   	  invalid-direction-for-sloclass


chore/all: Remove archived examples

Remove the following archived example applications:

editable-comments-web
email_app
non-editable-comments-web
safe_webrtc_example

These examples will be available in the archived-examples branch

Thanks for the pull request, and welcome! The MaidSafe team is excited to review your changes, and you should hear from @krishnaIndia (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see CONTRIBUTOR.md for more information.


[BUG] Unable to start ZEP with limited DB access rights (under non-root user)

Unable to start ZEP using dedicated Postgres database user with limited access rights (for example, in case of Google Cloud SQL).
Main issues is: ZEP is unconditionally trying to create/update pgvector extension at startup:

when this is not needed because it is already up-to-date
when there are no rights to do that (extensions must be installed by PG DB admin ONLY and not the target applications)

Expected behavior
ZEP can try to create/update an extension if really wants but this should be a warning and not the fatal error. The best way is to check that there is extension already installed.
Logs
time="2023-10-16T11:45:00Z" level=warning msg=".env file not found or unable to load. This warning can be ignored if Zep is run using docker compose with env_file defined or you are passing ENV variables."
time="2023-10-16T11:45:00Z" level=info msg="Starting Zep server version 0.15.1-e950fff (2023-10-13T00:38:11+0000)"
time="2023-10-16T11:45:00Z" level=info msg="Log level set to: info"
time="2023-10-16T11:45:01Z" level=info msg="error enabling pgvector extension: error updating pgvector extension: ERROR: must be owner of extension vector (SQLSTATE=42501)"
time="2023-10-16T11:45:01Z" level=fatal msg="Failed to connect to database: error updating pgvector extension: ERROR: must be owner of extension vector (SQLSTATE=42501)\n"

Environment (please complete the following information):

Zep version: 0.15.1-e950fff (2023-10-13T00:38:11+0000)
Deployment using helm chart to Google Cloud Kubernetes targeting Google Cloud Postgres version POSTGRES_12_16.R20230830.01_01
extensions installed:

[
  {
    "oid": 14038,
    "extname": "plpgsql",
    "extowner": 10,
    "extnamespace": 11,
    "extrelocatable": false,
    "extversion": "1.0",
    "extconfig": null,
    "extcondition": null
  },
  {
    "oid": 80380,
    "extname": "vector",
    "extowner": 16416,
    "extnamespace": 2200,
    "extrelocatable": true,
    "extversion": "0.5.0",
    "extconfig": null,
    "extcondition": null
  }
]

Additional context
Previous version (0.12.4) was working fine in this environment.

Fixed in #231. Will be deployed shortly.


TOC Ranges Fix for Release 2.1

The main fix for this pull request:
This fix is all in toc.js with some select mirador.css changes, see the function extractV21RangeTrees and the toc-caret click event handler.
This fixes #939, #680 and #527 and an issue not yet brought up:  what happens when a range is within more than one range?  Right now, the within property in mirador doesn't support that.  The ranges[] property does.  The V2 algorithm would just ignore it, the V21 algorithm will support it and place it correctly.
Extras included with this pull request:
This code also has the fix for #375.  For a demo on how I have placed the image manipulation tools in with the other hud controls, visit this page
***anything with the word bbAnno in it can be stricken from the pull request, it is specific to making it work for my application.
This code also supports Non-IIIF images (that is, images not fed via a tiling service or from a IIIF server).  For this code, see the .fail() function in imageView.js (line 954)
This code supports default images for "Image Not Found" and "Image Not Resolved" situations.  See manifest.js, iiif.js, utils.js.  The images used for these are hard linked, feel free to replace them or ignore this code entirely.

Coverage decreased (-5.4%) to 35.367% when pulling b397d5e4a55373eb8abe89dfa2a153e5dbb24cea on thehabes:master into 76a35e7c179f31fdc4aad822c9a61b3f20348e3c on IIIF:release2.1.

Coverage decreased (-5.4%) to 35.367% when pulling b397d5e4a55373eb8abe89dfa2a153e5dbb24cea on thehabes:master into 76a35e7c179f31fdc4aad822c9a61b3f20348e3c on IIIF:release2.1.


Type script

Converting codebase to TypeScript

[X] adding configurations

[X] decaffeinate

[X] js-to-ts

[X] linting for JS, TS, Coffee

[X] Use Github actions instead of Travis and Appveyor. See the running actions here: https://github.com/aminya/atom-julia-client/actions

[ ] Compiling each ts file one by one to replace the corresponding lib file
- Using import/exports instead of requiring if possible
- Adding type definitions
- other ts fixes
- tslint
- Using atom-select-list-ts instead of space-pen-views using the similar that was made for atom-indent-detective
- Using etch-ts instead of etch
- Optimizing code wherever possible
- Using TypeAssembly if worth it

[ ] connection\process\basic.ts
[ ] connection\process\boot.ts
[ ] connection\process\cycler.ts
[ ] connection\process\remote.ts
[ ] connection\process\server.ts
[ ] connection\process\tcp.ts
[ ] connection\client.ts
[ ] connection\ipc.ts
[ ] connection\local.ts
[ ] connection\messages.ts
[ ] connection\terminal.ts
[x] misc\blocks.ts
[ ] misc\cells.ts
[x] misc\colors.ts
[ ] misc\paths.ts
[x] misc\scopes.ts
[ ] misc\weave.ts
[ ] misc\words.ts
[ ] package\commands.ts
[ ] package\config.ts
[ ] package\menu.ts
[ ] package\settings.ts
[ ] package\toolbar.ts
[ ] runtime\completions.ts
[ ] runtime\console.ts
[ ] runtime\datatip.ts
[ ] runtime\debugger.ts
[ ] runtime\debuginfo.ts
[ ] runtime\evaluation.ts
[ ] runtime\formatter.ts
[ ] runtime\frontend.ts
[ ] runtime\goto.ts
[ ] runtime\linter.ts
[ ] runtime\modules.ts
[ ] runtime\outline.ts
[ ] runtime\packages.ts
[ ] runtime\plots.ts
[ ] runtime\profiler.ts
[ ] runtime\urihandler.ts
[ ] runtime\workspace.ts
[ ] ui\cellhighlighter.ts
[ ] ui\docs.ts
[ ] ui\focusutils.ts
[ ] ui\highlighter.ts
[ ] ui\layout.ts
[ ] ui\notifications.ts
[ ] ui\progress.ts
[ ] ui\selector.ts
[ ] ui\views.ts
[ ] connection.ts
[ ] julia-client.ts
[ ] misc.ts
[ ] runtime.ts
[ ] ui.ts

[ ] Merging ink and repeating the process for the ink

How to review?

Use commits history instead of going through the files (I keep compilation separate from editing)
https://github.com/JunoLab/atom-julia-client/pull/704/commits

Skip reviewing map files (js.map) and declaration files (d.ts) at first. Ask me to remove them if they are distracting.

Note: Source code is in lib_src and the compiled JS is kept in lib
Note: d.ts/map files are auto-generated (they are necessary).

The node-js bundled with atom is a little old, and so its ESLint version doesn't recognize @typescript-eslint plugin. I am trying to install my custom ESLint version, but I can't. I might remove online linting for TypeScript.

I use Github actions instead of Travis and Appveyor.
For some reason you can only see the running actions here:
https://github.com/aminya/atom-julia-client/actions

This is closed in favor of https://github.com/JunoLab/atom-julia-client/pull/705.
It distills this PR into smaller ones.


Fix unexpected (CMake) behavior with PICO_BOARD variable.

Changing PICO_BOARD value from "pico_w" to "pico" did not unset PICO_CYW43_SUPPORTED variable. Which could lead CYW43 driver included in builds for "pico".  (See issue https://github.com/raspberrypi/pico-sdk/issues/1046)
Instructions: (please delete)

please do not submit against master, use develop instead
please make sure there is an associated issue for your PR, and reference it via "Fixes #num" in the description
please enter a detailed description

please do not submit against master, use develop instead

Does this actually work as expected; I would think you need FORCE on the set commands

I'm not really familiar with CMake so not sure if this is "correct" way to fix the issue.  But it definitely fixed the issue I was having...

I updated the fix to have the PICO_CYW43_SUPPORTED not be a cache variable


[PE-D] Duplicate doctors

Expect to not be able to add doctors with the same name, age, address and email address, but able to without any warning or errors.

Labels: severity.Medium type.FunctionalityBug
original: ailing35/ped#7

If the patient has a son then the phone and email will be the same, so there will not be any point in changing to a less strict equality.


Empty custom tags are not compiled into riot.tag('[..]');

Source:
<parent-tag>
  <child-tag />
</parent-tag>

<child-tag>

Foo

</child-tag>

Compiles into:
riot.tag('parent-tag', '<child-tag ></child-tag>', function(opts) {

});

riot.tag('child-tag', '
Foo
', function(opts) {

});

Leaving a custom tag empty:
<parent-tag>
  <child-tag />
</parent-tag>

<child-tag>
</child-tag>

Doesn't create a riot.tag() for child-tag:
riot.tag('parent-tag', '<child-tag ></child-tag>', function(opts) {

});

<child-tag>
</child-tag>

It isn't such a big problem, but it was unexpected behavior to me. Also, if you're developing and creating all the elements first (which will be empty) and then create a relationship between them (giving them contents), the workflow will fail if you have a riot watcher and live reloader enabled.

The above fix will be part of today's release. Thanks!


Show participant roles when new participant added

Is your feature request related to a problem? Please describe.
When new participant is added to the incident in slack he gets no information about other participants roles, he needs to run /dispatch-list-participants in order to see that info
Describe the solution you'd like
Get /dispatch-list-participants  in welcoming message for new participants.
Describe alternatives you've considered
Triggering /dispatch-list-participants manually

The welcome ephemeral message includes contact information for the reporter and incident commander. We could consider including the liaison and scribe ones in the message if those have been assigned when the participant joins the incident.
The main reason why I don't think it would be a good idea to trigger the /dispatch-list-participants command when a new participant joins the incident conversation is that if the incident has lots of participants the ephemeral message that the /dispatch-list-participant command sends could end up being very long, requiring the participant to scroll up a lot to see the welcome ephemeral.


Orientation Doesn't work anymore

the example "Basic Example with Circle Tree with TopDown Orientation.html" : doesn't work
same for "Basic Example with TopDown Orientation.html"
error message :

pls help me i want to to a vertical tree

Try download a library from NPM... check here https://github.com/deltoss/d3-mitch-tree/issues/135
I use this function :
.setOrientation('topToBottom')


can't using left/right gesture

when i set offset:IDOffset.horizontal(1),
i can't use gesture to swipe back
can you help me
thanks

@programmerElephant more details please. Share your code

@Dn-a  i have the same issue. how to use gesture to swipe back when offset is 1 and leftChild is opened
  @override   Widget build(BuildContext context) {     return InnerDrawer(       offset: IDOffset.only(left: 1),       leftChild: Container(         alignment: Alignment.center,         child: Text("data"),       ),       scaffold: Scaffold(         body: Container(           alignment: Alignment.center,           child: Text("body"),         ),       ),     );   }

@akashicrecorder
InnerDrawer(key: _innerDrawerKey,...);

  final GlobalKey<InnerDrawerState> _innerDrawerKey = GlobalKey<InnerDrawerState>();

You have three possibilities
_innerDrawerKey.currentState.open(
        direction: InnerDrawerDirection.end  // optional
       );

    _innerDrawerKey.currentState.close();

    _innerDrawerKey.currentState.toggle();


OAuth 2.0 Authentication

What feature do you want to propose?
Client applications should authenticate against the Karman API using OAuth 2.0, more specifically one of the following flows:

The Authorization Code Flow with PKCE (public clients)
The Authorization Code Flow (private clients)
Resource Owner Password Flow (only for trusted client ids)

The OAuth server should be able to integrate with other OAuth/OIDC providers in a way that administrators can configure their preferred login provider. From a client perspective Karman should handle this transparently so the client does not need to know what provider will be used for signing in.
By default the Karman API should implement the OAuth protocol by authenticating against a local user database.
How do users access the feature?
Users click some kind of Login button which takes them to a login page or - if configured - an external identity provider. After they successfully authenticate they get a token which they can use to authenticate with the Karman API.
Describe alternatives you've considered

Simple Password Authentication: This would be a good temporary solution. However from a security and administration standpoint this complicates things. If have centralized identity management in mind from an early point in time I expect the implementation to be a lot simpler down the road.
API keys: This would also be a good workaround. However API keys usually fail to differentiate the user using an application and the application itself. Additionally OAuth is a standardized protocol which simplifies the implementation (at least on the client side)
Other OAuth flows: Other OAuth flows are either not applicable or are considered insecure (e.g. Implicit Grant). If the necessity arises they could be easily implemented as well.

Implementation Considerations
The Karman API would need to support two OAuth endpoints:

/authorize which would redirect the user to the login of the OAuth provider.
/token which would issue the actual token.
Both endpoints might proxy to another OAuth server if configured. If we want to support multiple OAuth backends we could implement a connection parameter to select the correct one.

The tokens should probably be JWTs, but that should only be relevant to the backend.

On further consideration, a full OAuth API might not be reasonable for an early release. Instead we should probably just use token-based authentication but push back the OAuth part.
A possible implementation could look like this:

We provide an endpoint for authentication. This could be modeled after the OAuth /token endpoint, e.g. /api/auth/token.
We implement the Resource Owner Password Flow and a Token Exchange Mechanism to support SSO scenarios.
We do not implement an /authorize endpoint. This is not part of the API but should be outsourced to an Authorization Server, which we don't want to implement right now.

Full OAuth support might come in the future but for now this ticket is concerned with token authentication.


Use AWS KMS instead of GPG

Since kaws specifically targets AWS, we should use AWS Key Management Service for handling the encryption of private data. GPG is workable, but has several properties that are less than ideal. Using KMS would facilitate using autoscaling group for the k8s cluster, because the instances can be assigned IAM instance profiles for decrypting data, meaning the TLS private keys can be stored encrypted in etcd and the manual provisioning steps currently in Terraform can be removed.

This was finished as part of the work for v0.2.0.


Add partitioning on app_access_logs

Any plans to add partitioning to the Athena Log Parser? Perhaps the Lambda Log Parser could create a new partition on each invocation, thus limiting the need to scan all ELB logs? I'm worried the query is going to start getting really slow in the future.

Thanks for sharing your feedback. This was included to the solution roadmap and we'll post an update to this thread once we have more information.
In the meantime, I suggest reading the references I mentioned on Issue#92

Hello @jmonson We have addressed this issue in V2.3.3 released recently


Ignore enter keydown events that are part of composition

Fixes the text area as #446 for non-latin letters

Thanks for fixing this issue for non-latin letters


Should ApplicationName be unique or generic?

In a situation where you have an autoscaling setup of your application, should the ApplicationName be shared by all instances or unique per instance?
How does pyroscope handle aggregation of multiple samples coming from different application instances independent from eachother?

Closing just saw the docs mention:
    // you can provide static tags via a map:
    Tags:            map[string]string{"hostname": os.Getenv("HOSTNAME")},


Can't define X as a connection point in webservices

The following HELM string is valid
PEPTIDE1{A.X.G.C.T.C.F.D.W.C}|BLOB1{BEAD}$PEPTIDE1,BLOB1,A:?-?:?$$$V2.0
However if I substitute X for A in the connection
PEPTIDE1{A.X.G.C.T.C.F.D.W.C}|BLOB1{BEAD}$PEPTIDE1,BLOB1,X:?-?:?$$$V2.0
The webservices says the HELM is invalid. This is incorrect, the HELM string is fine.
The webeditor can handle this string, and displays correctly.

On http://webeditor.openhelm.org/hwe/examples/App.htm,
PEPTIDE1{A.X.G}$$$V2.0
So, we still have the refresh issue.

I am confused. I thought both these pages used the same webservice components:
(http://<IP_ADDRESS>/WebService/FirstPage.html)[http://<IP_ADDRESS>/HELM2MonomerService/hwe/examples/App.htm
but PEPTIDE1{A.X.G}$$$V2.0
is valid according to the webeditor validation button (which I thought called the webservices)
but not valid according to the webservices page. Are they using different components?
Help.

Sorry, I always get confused with "X" as the notation for one single amino acid in peptides.
The toolkit currently has an issue on recognizing "X" during validation of the connection section.
PEPTIDE1{A..G.C.T.C.F.D.W.C}|BLOB1{BEAD}$PEPTIDE1,BLOB1,:?-?:?$$$V2.0 is valid and
PEPTIDE1{A.*.G.C.T.C.F.D.W.C}|BLOB1{BEAD}$PEPTIDE1,BLOB1,2:?-?:?$$$V2.0 as well.
Should work with X in the same way.
BTW: PEPTIDE1{A.X.G}$$$V2.0 is not valid because of a missing $-symbol.

Retested - fixed.


Remove borders between menu items

Is it possible to remove borders between menu lines and just have padding between them? thanks and a question is when are you releasing new updates for semantic ui?
`

 Menu

gfhfhfh
fhgh

      Products

ghhfg
ghgh
ghh

      Support

gh
gh
th

Sign In

`

Hi @jackttcoms, sorry for the delay, add a .borderless class to your menu. SUI releases aren’t on a schedule, please see a list of releases to get a rough idea on when to expect another one.


Relays don't work

I connected a relay to a bunch of collectors and a condenser mk2, and tried duping dark matter.  However, no EMC transferred through the relays into the condenser.  So in essence, the relays are non-functional.

I won't be able to look into this for a week at least, as I'm in the process of moving

I plan on looking into this today (3/15) if possible, and tomorrow otherwise - I don't really have any experience with using relays so this is going to be fun

This has yet again been delayed more, I can't test anything because downloading assets during running the client & even building the jar just is not working anymore because my internet speeds (hotspot) are so bad. I'm getting my internet installed tomorrow, so we'll see then.

Alright, sounds good.  Wish you the best.  We got ours upgraded just yesterday to fiber from regular copper.

I'm looking into it here, and I have to be honest
I have no clue what these are even supposed to do, as far as I can see they never did anything in ProjectEX either
I'm bordering on just tossing them out, or making them essentially an extension of ProjectE's relays, but faster or more efficient, or something of that nature

As i know Relay gives bonus EMC for collectors. welp u can still use projectEX alpha version they work in there.

Fixed via #23
1.16
1.15