[NIFI-10612] Initial check in of isJson code.

Summary
NIFI-10612
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[x] Apache NiFi Jira issue created

Pull Request Tracking

[x] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[x] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[x] Pull Request based on current revision of the main branch
[x] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[x] Build completed using mvn clean install -P contrib-check

[x] JDK 8
[ ] JDK 11
[ ] JDK 17

Licensing

[x] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[x] Documentation formatting appears as expected in rendered files

@exceptionfactory Done

Good job on your first commit @dan-s1. Thanks for the improvement.

@MikeThomsen Thank you!


SIGSEGV: segmentation violation

blu@minopia:~/github/repos $ ./gomerge_list.sh
No open pull requests found for configured repositories.
+----+-------+--------------------------------+---------------------------------------+----------------------+
| PR | STATE |             TITLE              |              REPOSITORY               |       CREATED        |
+----+-------+--------------------------------+---------------------------------------+----------------------+
| #2 | open  | Update                         | xxx/xxx | 2021-03-10T05:47:18Z |
|    |       | xxx    |                                       |                      |
|    |       | xxx           |                                       |                      |
+----+-------+--------------------------------+---------------------------------------+----------------------+
? Select which Pull Requests you would like to merge. 2 | xxx                                                   2022/09/26 01:11:18 Could not merge PR #2, skipping: PUT https://api.github.com/repos/xxx/xxx/pulls/2/merge: 404 Not Found []
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x2c8f28]

goroutine 1 [running]:
github.com/cian911/go-merge/pkg/gitclient.MergePullRequest(0x4000166500, {0x4fbe70, 0x40000b0000}, {0x40000b1330, 0xb}, {0x40004d0a22, 0x19}, 0x2, {0x0, 0x0}, ...)
        /home/runner/work/gomerge/gomerge/pkg/gitclient/client.go:50 +0x198
github.com/cian911/go-merge/pkg/cli/list.NewCommand.func1(0x4000152c80, {0x40000a2a00, 0x0, 0x5})
        /home/runner/work/gomerge/gomerge/pkg/cli/list/list.go:94 +0xa00
github.com/spf13/cobra.(*Command).execute(0x4000152c80, {0x40000a29b0, 0x5, 0x5})
        /home/runner/go/pkg/mod/github.com/spf13/cobra@v1.5.0/command.go:876 +0x66c
github.com/spf13/cobra.(*Command).ExecuteC(0x4000152a00)
        /home/runner/go/pkg/mod/github.com/spf13/cobra@v1.5.0/command.go:990 +0x424
github.com/spf13/cobra.(*Command).Execute(...)
        /home/runner/go/pkg/mod/github.com/spf13/cobra@v1.5.0/command.go:918
github.com/spf13/cobra.(*Command).ExecuteContext(...)
        /home/runner/go/pkg/mod/github.com/spf13/cobra@v1.5.0/command.go:911
main.main()
        /home/runner/work/gomerge/gomerge/cmd/gomerge/main.go:22 +0x168

Hi @Bluscream, thanks so much for the report. Just to ask what might be the obvious for clarity:

Are you running the same script you have above as you have documented in https://github.com/Cian911/gomerge/issues/55?

Are you merging or approving the selected PRs?

When exactly does the segfault occur, it looks to be after you've selected and choose to merge/approve the selected repos, is that correct?

Do you have access to all access to all configured repos? Are any archived?

Are you running the same script you have above as you have documented in [Tutorial] How to use this on all your repos #55?

Yes

Are you merging or approving the selected PRs?

I want to merge first, and then close all remaining unmergables

When exactly does the segfault occur, it looks to be after you've selected and choose to merge/approve the selected repos, is that correct?

Correct

Do you have access to all access to all configured repos? Are any archived?

Some are archived and atleast one in there is DMCA'ed, and to some i might not have push permissions

Some are archived and atleast one in there is DMCA'ed, and to some i might not have push permissions

Are you trying to merge PRs from any of these?

what i also found out was that even the github web frontend doesn't like batch-merging. When i merge two PRs too close together (within a one or two seconds from eachother, it errors out and i have to reload the second PR and try merging it again) so maybe a sleep inbetween merges would be useful

Yes I've encountered this before, though in this case the fact the PR is un-mergable for a brief time I catch this as an error already so this I don't think is the source of the segfault. This happens because after one PR is merged, others in the repo will likely need to be rebased (depending on the files changed), I think I might have mentioned something like this before in a previous issue you created ;) https://github.com/Cian911/gomerge/issues/40#issuecomment-1165696763
Also thanks for the response, I will try and replicate the issue myself first and If I run into any issues I'll reach out to you for more info. And thanks again for the issue! Love the fact you're actively and regularly using gomerge and you're getting value out of it.

they might be under all the other repos, and picking them out everytime i regenerate is not really a viable option. can't it just skip erroring operations as it's supposed to?

Yes it should, the reason I ask is I don't think I've tested against either scenario, I have a suspicion the problem is here, but I will test to see ;)
Do you think you could link me to the DMCA'd repo you mentioned?

Do you think you could link me to the DMCA'd repo you mentioned?

https://github.com/Bluscream/DayZ-Private
451 {"message": "Repository access blocked", "block": {"reason": "dmca", "created_at": "2014-05-30T19:18:22Z", "html_url": "https://github.com/github/dmca/blob/master/2014/2014-05-30-Bec.md"}}

@Bluscream I think I may have found the source of the issue in the close operation. I wasn't handling the proceeding step after an error occurred correctly. I also added a delay flag too. You can checkout the PR here: https://github.com/Cian911/gomerge/pull/57
Do you think you can checkout my branch to test against your use case for me? Instructions to build and run from source are all in the project Makefile.

Hi @Bluscream I've merged the PR above as I'd like to get a new release out with this fix, In the meantime I will leave this open for you if you want to let me know if you encounter this issue again, but I think it should be solved. Thanks!

Oh yes, sorry for the delay. I was planning to do it next time i'm on my PC but that next time never happend. Will keep you posted

Gona close this for now - If it crops up again I can re-open this issue. Thanks again!


ShareGPT Chrome Extension Generating errors

Hi, ShareGPT extension is not working on latest version of chrome. I get an error saying it is being blocked by Client. Any steps I can take to troubleshoot?

Yes.

BTW--By random chance I just tried to disable the following extensions in Chrome:
Free VPN for Chrome - VPN Proxy VeePN
Loom – Screen Recorder & Screen Capture
Google Docs Offline
And it works now.  Thanks for responding in any case. Hope this helps others.


es7 bind syntax

Hey man!
Thanks for an awesome repo. Was wondering if this is currently supported?
class Hello extends React.Component {
  constructor(props) {
    super(props)
  }

  hello() {
    return "hello, " + this.props.name;
  }

  render() {
    <div>{::hello()}</div>
  }
}

Basically, that ::hello() is the same as hello().bind(this).

While testing, it seems like no. I get a red highlighting on the second :.
Would love to see this working neverthless.
So :+1: !

NO~
Any reference of this new spec?

I could not find a spec, sorry!
But there is a lot of discussion around this: http://blog.jeremyfairbank.com/javascript/javascript-es7-function-bind-syntax/
And some examples showing how to use.

https://github.com/tc39/tc39-notes/blob/master/es6/2015-03/mar-25.md#6vi-function-bind-and-private-fields-redux-kevin-smith
https://github.com/zenparsing/es-function-bind
http://babeljs.io/docs/plugins/transform-function-bind/

Awesome! Thanks a lot @othree !

You're the best!


Advisory Group photos default to github

In the last update, Eka Grguric's github profile photo is appearing on the LCAG page, and not the photo that she supplied  ( librarycarpentry.github.io/files/advisory/grguric.jpg). Does anyone know how to change this?

Hi @libcce, I don't seem to have permission to push changes yet! Happy to make the change myself if I get permission.

@egrguric your pic should be fine now! @maneesha can possibly look into your privileges.

This looks good now - thanks @libcce!

Thanks all - can we close this issue?


Investigate MDF to MCAP converter

There is no obviously general conversion method as MCAP is dependent on the Robot Operating System. Specialized converters may work but this require some cooperation with an end-user. There is no end-user available. This investigation show no general solution.


Error when installing

Why am I getting these errors?
`Install-Package : NU1108: Cycle detected.
ConTabs.tdwright -> ConTabs.tdwright (>= 1.2.0).
At line:1 char:1
Install-Package ConTabs.tdwright -Version 1.2.0
CategoryInfo          : NotSpecified: (:) [Install-Package], Exception
FullyQualifiedErrorId : NuGetCmdletUnhandledException,NuGet.PackageManagement.PowerShellCmdlets.InstallPackageCommand
Install-Package : Package restore failed. Rolling back package changes for 'ConTabs'.
At line:1 char:1
Install-Package ConTabs.tdwright -Version 1.2.0
CategoryInfo          : NotSpecified: (:) [Install-Package], Exception
FullyQualifiedErrorId : NuGetCmdletUnhandledException,NuGet.PackageManagement.PowerShellCmdlets.InstallPackageCommand`

Seems like an issue with Nuget or VS, here's some help.

Thank you but that didn't help. I fixed it by going to ConTabsDemo-DotNetCore, there was an error there and I simply removed the dependency then installed the package again and voila!


The old token is not expire in GenerateChangePhoneNumberTokenAsync method?

I'm facing this issue,
GenerateChangePhoneNumberTokenAsync(user, PhoneNumber)-This method is for generate the Confirmation Code
ChangePhoneNumberAsync(user, PhoneNumber, code);-This method is for Confirmation Code
Scenario:
1.Sending Verification Code(First Verification is Code sent to mobile)
2.Again Clicking Resend the Verification Code(Second Code is sent to Mobile)
3.If I give the first verification code its gets accepted...
How to Expire the old code?

TOTP codes are based on time, not on usage. It'll roll over on its own without invalidating. You could write your own provider that implements one shot tokens by implementing IUserTwoFactorTokenProvider.cs

It'll be nice if option is there to give the time span as parameter
just like we have in Email Confirmation Tokens but for PhoneNumberToken its by default 3 minutes I guess ?
so would it be possible to make it a parameter ?
_userManager.UserTokenProvider = _userManager.GetDataProtectionProvider("EmailConfirmationToken", TimeSpan.FromDays(7));


Add guest_info column to the Vms table.

https://issues.redhat.com/browse/RHCLOUD-10836

Is there a JIRA ticket we can tie to this? That way we can keep track of all the commits for this, since I assume the next step is going to be adding it to topo-api etc.

Yes. Just added the JIRA link to the description.
Also, given this is a GEM, a new version will have to be released before it's available to the dependent code. I'm not sure of the procedure for doing that in this environment.

Is there a JIRA ticket we can tie to this? That way we can keep track of all the commits for this, since I assume the next step is going to be adding it to topo-api etc.

Yes. Just added the JIRA link to the description.
Also, given this is a GEM, a new version will have to be released before it's available to the dependent code. I'm not sure of the procedure for doing that in this environment.

@roliveri no problem, I'll release it after merging this.

@roliveri no problem, I'll release it after merging this.

@roliveri no problem, I'll release it after merging this.

@lindgrenj6  Thanks. Once done, let me know the new GEM version and I'll update the dependent PRs.

@roliveri no problem, I'll release it after merging this.

@lindgrenj6  Thanks. Once done, let me know the new GEM version and I'll update the dependent PRs.


Crashes after updating Python

I've set up this package a week or so ago and it created a cached directory with pyvenv.cfg with version = 3.7.7.
I have later updated python to 3.8.3 through brew and then this package started crashing on this line:
https://github.com/sublimelsp/LSP-pyls/blob/2909522a310dbb665acead21a988eb68469b4074/plugin.py#L74
with a stderr:
Traceback (most recent call last):
  File "/Users/me/Library/Application Support/Sublime Text/Cache/LSP-pyls/bin/pip", line 8, in <module>
    from pip._internal import main
ModuleNotFoundError: No module named 'pip'

Deleting the Cache/LSP-pyls directory helped as that recreated the virtual environment using latest Python.
I would probably suggest catching errors in needs_update_or_installation and return True in such a case so that the cache is recreated and handles such issues automatically.

Also this can be one line for less indentation and more readability:
https://github.com/sublimelsp/LSP-pyls/blob/2909522a310dbb665acead21a988eb68469b4074/plugin.py#L69-L70

BTW. I have updated to 3.8.3


Test prometheus client for migration

Do not merge!
To deploy to test cluster run oc process -f resources/services/prom-migration-client-template.yaml | oc create -f -. Make sure config is pointed to correct env.
cc: @PhilipGough

Closing since the migration has completed


is there a way to set the name of lcov.info files

I'd like to run nyc & mocha on several different sets of files then run a unified report across all of them to show coverage.
eg.
nyc --reporter=lcov --lcov-name=model-lcov.info mocha test/model/**/*.test.js
nyc --reporter=lcov --lcov-name=controller-lcov.info mocha test/controller/**/*.test.js
nyc --reporter=lcov --lcov-name=view-lcov.info mocha test/view/**/*.test.js
nyc mocha report --reporter=text-summary

Looking for something similar to --lcov-name (or way to accomplish same).

@skarfacegc if you do this:
nyc npm run t1 npm run t2 npm run t3
where:
  "scripts": {
     "t1": "mocha test/model/**/*.test.js ",
     "t2": "mocha test/controller/**/*.test.js",
     "t3": " mocha test/view/**/*.test.js"
  }
}```

`nyc` will output the combination of all tests runs to the `.nyc_output` folder, and you will be able to print a combined report.

So there's no way to run multiple instances of nyc (if I want to parallelize my build for example) and generate a report that's an aggregate of multiple runs?
Yes, I'd need to deal with cleaning out the old between runs, but build systems are generally pretty good at that.  I see that the lcovonly  reporter takes a filename option, but I can't figure out how to set it through nyc.

@skarfacegc have you been able to generate the lcov report in a different directory? Istanbul has an option --dir custom-coverage-dir, for example --dir coverage/api

Oh, never mind, there's --report-dir


Plain html links  reloads the app

Hi!
I created a blog platform. User creates documents inside wysiwyg editor (tinymce).
Very often inside the article users adds links to other articles Link
The problem is that the  tags reloads the whole app :(
How can I handle it the force  to behave like a ?
Thanks for help in advance,

You need to use nuxt-link not a

@awronski you may want to take a look at this: https://github.com/nuxt/nuxtjs.org/blob/master/components/HtmlParser.vue
Mostly on addListeners method.


feat: [feat-secure-workspace-egress] GALI-933 and GALI-934 add UI changes for egress store request submission

Issue #, if available: GALI-933 and GALI-934
Description of changes:

Add UI component to show egress store objects
Add data egress store
Add data egress controller

[x] Have you successfully deployed to an AWS account with your changes?
[ ] Have you written new tests for your core changes, as applicable?
[x] Have you successfully tested with your changes locally?
[ ] If new dependencies have been added, have they been pinned to specific versions? A: No dependencies are added.
[ ] Is this change also required on the AWS Solution version?
[ ] Have you updated openapi.yaml if you made updates to API definition (including add, delete or update parameter and request data schema)? A: Only place holder are added in this PR and the APIs are not implemented yet. The openapi.yaml will be update when the APIs are implemented.
[ ] If you had to run manual tests, have you considered automating those tests by adding them to end-to-end tests? A: The tests will be added when data egress store and APIs are implemented. No tests added in this PR.

AS review ticket id:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Attaching screenshots for UI changes

The unit testing is failing because of the lint issue. And I am putting some places holders in this commit and it should go away after I finish the backend functionality and then I can go back and finish the full UI functionality and the unit test should pass.


Change node accepts only one "Example message" for JSONata

Current Behavior
Create a change node with two rules, setting "msg.test1" and "msg.test2" to JSONata values "1" and "2" (just for demo purposes).
Go in to the "Test" tab for the first and set the "Example message" to:
{
    "payload": "test1"
}

Go into the second and set it similarly, but using test2. Go back to the first one and have a look - the example message has 'magically' changed to be what's in the second rule.
Expected Behavior
I expect to be able to put different "Example message" code in each rule on a change node. I'm progressively building up a complex message, so want separate rules, each with their own "Example message". Obviously it works fine if you have two change nodes.
I'm guessing that you're storing the "Example message" with the whole change node, so moving it to the rule might be a breaking change you don't want to deal with. If this is the case, it might be better to move the "Example message" to a tab at the node level (with Properties / Description / Appearance). And then duplicate it on the rule with the title "Node's example message", while still allowing it to be edited. This should make it clear there's only one for the whole node and what you see on the rule is there for convenience (because otherwise it would be a pain toggling back-and-forth until you get your JSONata doing what you want).
Steps To Reproduce
See above. Although I've pasted the change node below, an export does not include the "Sample message", so you would need to type that part in. It would also be very useful for the "Example message" to be included in an export and ctl-C as I use this a fair bit and copy messages around without realising it will lose the test data.
Example flow
[
    {
        "id": "4fa5dfd99196cfa2",
        "type": "change",
        "z": "e05a6d6980afb4f7",
        "name": "",
        "rules": [
            {
                "t": "set",
                "p": "test1",
                "pt": "msg",
                "to": "1",
                "tot": "jsonata"
            },
            {
                "t": "set",
                "p": "test2",
                "pt": "msg",
                "to": "2",
                "tot": "jsonata"
            }
        ],
        "action": "",
        "property": "",
        "from": "",
        "to": "",
        "reg": false,
        "x": 380,
        "y": 320,
        "wires": [
            []
        ]
    }
]

Environment

Node-RED version: v3.0.0
Node.js version: v14.16.0
npm version: 6.14.11
Platform/OS: Docker/Ubuntu
Browser: Chrome

The 'test data' does not get persisted with the node. It gets cached in the browser by the editor and is wiped when you reload the editor.
So it wouldn't be possible to store lots of different test messages with the node itself.
We can certainly look at updating the caching so that when a node has multiple JSONata expressions, it caches per-field, rather than per-node. But there isn't any intention to persist the test data with the node itself.

Ah, it hadn't occurred to me that it would be cached rather than stored with the flow. In that case there's probably no point in going to the effort, because it would be confusing when it disappeared.
For some of my more complicated JSONata nodes, ideally I would like to have multiple test inputs. This speaks to a unit test capability for nodes that could be automated. Is anything like this on the radar? For example, a "test" node that can be wired to another node with similar functionality to "inject", but the message is not passed out from the node under test. Or (somewhat similar to debugging custom nodes) from a "function" node you can call "RED.nodes.cloneNode('node-id')" and then feed it a message and test the output(s).


nasdaq

Closing this issue. NASDAQ is already available in https://tvdb.brianthe.dev under the America screener.


fixing chest table's transmission to chest content's table when opening Chest presenter

fixes #10
For an obscure reason, #defaultLayout was rebuilding the chest content table with an empty item list, which is why the list would appear empty when a chest presenter opened.
I remove the selection of the first chest in #initializePresenters because it is already done in #connectPresenters

Unrelated test failures


Disabling HTML messages rendering.

Disabling HTML messages to be rendered.  Resolves #604

@reyesrico can we add a unit test for this?

Unit test added to the framework.


ISPN-1887 Fixed buggy withCacheManager method and simplify it

https://issues.jboss.org/browse/ISPN-1887
Previous withCacheManager() was buggy and would leave cache managed open in the even of an exception. This fix improves on the pattern suggested and fixes this issue.
5.1.x branch: t_1887_5

integrated.


Mentorship Program - Add License

Add License to Repository
Relates to: https://github.com/nodejs/community-committee/issues/559

Addressed by: #184


Feature/guided workflow

Ticket: https://selectquote.atlassian.net/browse/AZT-2046
This PR creates a Feature that allows us to create Guided Workflows. Per Chris Nemeth, many projects need the ability to have guided workflows. Asking each squad to build this themselves every time isn't ideal.
This Guided Workflow feature composes a bunch of previously built shared code solutions together. The FE developer consuming this new feature shouldn't have to write much, if any custom code. The consumer feeds the component an array of configuration objects, and they receive a styles, fully functional Guided Workflow.
Since this is a pretty large feature, I wanted to make sure it was well documented. I attached a README.md file that contains a series of tutorial videos to show how to configure the GuidedWorkflow for your projects needed, as well as some of the logic under the hood.
The story in Storybook is rather basic, but honestly, you can probably copy/pasta the code for it, change the config objects around to your needs, and 🚢  it.

I spent some time trying to get the new Storybook controls working but the args kept causing SQForm errors so I excluded them.

The first project that will use this shared component is the CCA Checklist on Senior.

Great work on this, @SeanGroff !


Swipe to mapView sometimes causes wrong index ?

Hi there,
I'm having a issue working with your pod.
I got those 3 view controllers embed in a custom UITabBarController, child of SwipeableTabBarController :

As you can see, my second controller contains a MKMapView.
Here's the problem: when my app opens, if I start scrolling quickly after the first view appears, the tab bar won't move at all when scrolled. I can only change tab by tapping the tab bar items. However when tapping the second tab then the first one again, my app will crash with : "Attempted to read an unowned reference but the object was already deallocated".
Showing this :

I found that setting self.selectedIndex = 0 in the TabBarController viewDidLoad method fixes the issue. But when doing this, the scroll seems disabled until I first tap on a tab bar item. After this it works fine.
I only saw that bug when adding a MKMapView though.
Thanks!

Can you try doing selectedViewController = viewControllers?.first instead? It's a strange issue, the ViewController content shouldn't affect others ability to swipe.

Doesn't change anything sorry, the crash occurs in SwipeAnimation.swift line 73.
Can you check this out?

Sure, is there any chance you reproduce the bug on a repo and upload it to GitHub? Just so we test on the same code.

You can find it at : https://github.com/MorganBerger/TrySwipeTabBarPod
Try spamming small swipes at launch, the bug should occur.
I run it on iPhone SE with iOS 11.3.1

@MorganBerger I just tried it out. This is a super strange bug. If you add selectedViewController = viewControllers?.first on viewDidLoad it will work if you use the app regularly. But if you spam small swipes at launch the swiping doesn't work. I'll look at it further.

@MorganBerger I just pushed v2.0 and I believe this issue should not happen anymore. Not sure if you still use the library. Otherwise, I'll close this issue.

You can close the issue. Thanks !


Records should use combined cell

I think the Set column can be removed and combined with the hero cell.  We can make the record value column link to the match instead?

We can make it like dotabuff does. 😲

I'd like to retain the ability to sort by date set (so you can see the latest records set).


Refactor the read line function

Re-implement readLine() function
The pocketlang's input() function and cli's input reading both calls the read_line() function defined in cli/repl.c which is something I wrote for temporary. that can only read at a maximum of 1024 characters and not safe. Which needs to be refactored with reading each character one by one and write it to a buffer till we reach a new line or an EOF.
Refer #78 for ByteBuffer implementation details.
How to implement.

Create another function with the name readLine (and don't refactor the read_line function because it's used by the VM's IO callbacks, and refactoring it is for the future). That'll take a byte buffer and read the chars into that buffer. (here is an un tested code)

static void readLine(ByteBuffer* buff) {
  do {
    char c = fgetc(stdin);
    if (c == EOF || c == '\n') break;

    byteBufferWrite(buff, (uint8_t)c);
  } while (true);

  byteBufferWrite(buff, '\0');
}

Don't forget to write the comments documenting the function.

What it does at above the function's declaration.
How it does inside the function, at required places (But here we don't need any).

Create a buffer to store the line that'll be read from stdin.

+ // A buffer to store a line read from stdin.
+  ByteBuffer line;
+  byteBufferInit(&line);

   // A buffer to store lines read from stdin.
   ByteBuffer lines;
   byteBufferInit(&lines);

Remove the read_line() call and change it to readLine(&line)

Change all the line with (const char*)line.data

Change all the free((void*)line); with byteBufferClear(&line);

Finally
Unit tests for REPL haven't implemented yet, so you have to run some tests by yourself to make sure everything works fine, before making the PR. (ex:)
>>> def hello()
...     print('hello world')
... end
>>>
>>> hello()
hello world
>>>

CC @xSavitar

Will take a look at this shortly. Thanks!

Fixed by #83


Auto PR to update dependencies of istio - update to non crashing mixer

This PR will be merged automatically once checks are successful.

woot

Closing this as we have a new PR that includes also pilot changes.


Provided JSON Schema is invalid

What is the issue?
The provided JSON schema is invalid as per 2020-12 draft (validating it with ajv-cli with --spec=draft2020 enabled).
The oneOf clause is meant to be for array of schemas as opposed to validating against array of values. enum is better suited for this purpose.
❯ npx ajv compile -s pricing.schema.json --spec=draft2020
schema pricing.schema.json is invalid
error: schema is invalid: data/$defs/plan/properties/interval/oneOf/0 must be object,boolean

This should be the modified schema (providing the fix here as I couldn't find a pricing.schema.json file in the repository itself to patch):
{
  "$schema": "https://json-schema.org/draft/2020-12/schema",
  "$id": "https://www.tier.run/docs/pricing.schema.json",
  "title": "Pricing Model",
  "description": "A pricing.json model definition used by tier",
  "type": "object",
  "additionalProperties": false,
  "properties": {
    "plans": {
      "description": "The collection of all defined plans",
      "type": "object",
      "propertyNames": { "pattern": "^plan:[a-z0-9:]+@[a-z0-9]+$" },
      "patternProperties": { "": { "$ref": "#/$defs/plan" } }
    }
  },
  "$defs": {
    "plan": {
      "type": "object",
      "properties": {
        "title": { "type": "string" },
        "currency": { "type": "string" },
        "interval": {
          "type": "string",
          "enum": ["@daily", "@weekly", "@monthly", "@yearly"]
        },
        "features": {
          "type": "object",
          "propertyNames": { "pattern": "^feature:.*$" },
          "patternProperties": { "": { "$ref": "#/$defs/feature" } }
        }
      },
      "additionalProperties": false
    },
    "feature": {
      "type": "object",
      "properties": {
        "title": { "type": "string" },
        "mode": { "type": "string", "enum": ["graduated", "volume"] },
        "aggregate": { "type": "string", "enum": ["sum", "max", "recent", "perpetual"] },
        "base": { "type": "number" },
        "tiers": {
          "type": "array",
          "items": { "$ref": "#/$defs/tier" }
        }
      },
      "additionalProperties": false
    },
    "tier": {
      "type": "object",
      "properties": {
        "upto": { "type": "number" },
        "price": { "type": "number" },
        "base": { "type": "number" }
      },
      "additionalProperties": false
    }
  }
}

The schema validates correctly:
❯ npx ajv compile -s pricing.schema.json --spec=draft2020
schema pricing.schema.json is valid

EDIT: Added aggregate property to feature.

^ Added missing aggregate property to feature. Also, title is not mentioned in the pricing.json Feature Objects documentation. Is it part of config (docs missing for it) or added into the schema definition by oversight? Not sure what to make of it, so left it as is in the definition.


Issue #8 fix: Add purpose: Organisation fighting for rights and freedom

Looks good 👍
Hope you enjoy your journey with OpenGenus 🎉


hover划过行，除了改变背景色，还要改变边框的颜色

你好，当hover的时候除了改变背景色，还要同时修改边框颜色

The new version has solved this problem.
Please use version 2.0

The new version has solved this problem.
Please use version 2.0


A question about searching associations not a bug

Hi, I'm just getting my head around pg_search and I have a question regarding associations.
Given the following simple setup
class Book < ActiveRecord::Base
  has_many :reviews
end

class Review < ActiveRecord::Base
  belongs_to :book
end

There is no joining table in this scenario. Just two tables: books and reviews.
If I wanted to grab all reviews and their associated book. I could do something like
Review.joins(:book).select('reviews.*', 'books.*')

This should return a list of repeated book names with their review.
I assumed I would be able to do something like:
class Review < ActiveRecord::Base
  belongs_to :book

  pg_search_scope :search,
    against: {comment: 'A'},
    associated_against: {
       book: {name: 'B'}
    },
    using: { tsearch: { dictionary: 'english' } }
end

Review.joins(:book).select('reviews.*', 'books.*')
  .search('Harry Potter and the Deathly Hallows is a page turner.')

Is that possible? Or have i missed something?

Scopes from pg_search are chainable, just like any other scope, so I think the general answer to your question is yes.
It would be more conventional to do this, I would think:
Review.search('Harry Potter and the Deathly Hallows is a page turner.').includes(:book)

And you'd get Review records where you could call Review#book to retrieve the book.
e.g. (a rough sketch)
reviews = Review.search('Harry Potter and the Deathly Hallows is a page turner.').includes(:book)

review = reviews.first

review # => <#Review text="I think that Harry Potter and the Deathly Hallows is a real page turner, don't you agree?">

review.book #=> <#Book title="Harry Potter and the Deathly Hallows">


notice event not working

bot.on('notice', (channel, msgid, message) => {
	console.log('notice');
});

Is not working, i don't get a notice for any action (unban etc.).
node.js version 7.0.0
tmi.js version 1.1.2

That type of information comes from the PubSub system: Docs | Discuss

huh, Why is the notice event then in the docs?
https://docs.tmijs.org/v1.1.2/Events.html#notice
I would like to get the notice events, the pubsub provides only mod actions, whispers and bits afaik.

Sorry, I must be unclear as to what "unban" case you're referring to. You only receive an unban_success notice if it's the tmi.js client that unbanned the user. Other users unbanning other users only comes from the PubSub system.

Ahhh okay, perfect! Now it makes sense for me. Thank you.


Strengthen username to email address fix #4676

We try to avoid "Merge" commits by doing rebasing, and it appears there is a conflict here.
Is there a way to get test coverage for this change?

Hi @fossbalaji, thanks for checking out Zulip! This doesn't quite solve the issue; I'd recommend giving the issue description another read, and then force pushing your updated version onto this PR.

Hi ,
I have added check for names as per the description. Kindly check and update if anything else has to be done

@fossbalaji Can you clean up your commits?  It's an important part of our process to rebase commits so that they are atomic and to avoid merge commits.

@showell  What exactly do i need to do? . I am not much familier with git rebasing.  How do i clean up this?

Please read the following:

https://zulip.readthedocs.io/en/latest/git/overview.html
https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request

They'll take a while to read, but I would take your time and learn them, as rebasing is a really critical skill to have on open source projects.  After reading them, you can ask for more help on chat.

I cleaned up my commits . Could you check now?

@fossbalaji I don't think it worked.  Look at how many commits are in the PR now.

I just rebased and pushed . So only one commit should appear in PR or what?

I'm not sure what you did, but if you look at your commits relative to master, you'll see there are lots of extra commits.  You'll want to do an interactive rebase and maybe squash your commits.
Have you read the docs that I pointed you to?

I have read and followed the same. I have no idea how come others commit merged into mine @showell ?

I would ask for help on chat, or do more research on interactive rebases.

@showell . Done i guess. Now only 8 commits. all are mine.

I think you need to squash them further.  Each commit should be an "atomic" operation, and commits should never say "merge" in them.  Please read the docs and maybe look at other commits in the repo to see how this works.


Bug: "Uncaught TypeError: Cannot read property '_aData' of undefined" when using row reference after removing other row

Here's the steps to reproduce: http://jsbin.com/daziyuvocu/2/edit?html,css,js,output
Basically I'm using DataTables with the deferRender option for scalability. I want to support thousands of rows so disabling deferRender is not an option. The table will constantly mutate so I need to be able to reference all rows at all time and remove/update/insert etc. The option deferRender naturally makes row-selector referencing useless (AFAIK), but no problem, I just save the reference returned by the add() call.
The problem is that a remove() corrupts the existing row references, so an data() call will return Uncaught TypeError: Cannot read property '_aData' of undefined. I assume this is a bug since the documentation doesn't mention anything about it. Workarounds welcome.

Very interesting - thank you for the clear and concise test case!
You are correct that the issue is with the remove changing the row indexes. Because row2 has saved a row index, and it doesn't know that the row has been removed, its held index is now wrong!
I'm currently looking at implementing a new why of handling ids in DataTables which might be quite useful for such a use case (assuming each row has a unique identifier), but that is a work in progress.
Until then, you can use row-selector, but you can't have it using any of the DOM interfaces. So for example you have have it using a function: http://jsbin.com/jugipohaho/1/edit?js,output .
That is currently the best workaround I can think of  - let me think some more on it.

Thank you for the quick reply.

I'm currently looking at implementing a new why of handling ids in DataTables which might be quite useful for such a use case (assuming each row has a unique identifier), but that is a work in progress.

Yes, this is exactly it. I was supprised this was not currently possible.
The only problem with this workaround is that be easiest way for me to implement it (without rewriting all of my code to use function refencing instead) is to "fix" all existing references I have after a remove. This taking linear time O(n) is okay, but if I have to do it with the function solution for ever reference I have it will take O(n^2) time which is unacceptable (1000000 calls for 1000 rows). Is it somehow possible to iterate through all rows and save the row reference directly in the callback? Can I use the "idx" argument for this?

Yes, all existing references would either need to be refreshed, of you would just get the reference at the point of need.
Given that you would have multiple instances referring to different indexes, there isn't a way to update them all, since they are independent.
One possibility is to have DataTables not delete items from its internal data array and instead make it a sparse array. The other option is to use an object rather than an array and use the row id as the parameter key. The latter is probably the better option as I might be able to implement it alongside the existing implementation.

This is my O(n) workaround for now. I simply used the row index, all_rows is my own external index:
// Repairs all row references, this is done by iterating through all rows with
// a row selector and generating a new row reference from the numeric index.
// This is a workaround for https://github.com/DataTables/DataTables/issues/566
var reapirRowReferences = function() {
    dtable.rows(function(idx, data, node) {
        all_rows[data.cls][data.id] = dtable.row(idx);
        return false;
    });
};

I've just committed the ability to set the id source (rowId) and two methods to read it (rows().ids() and row().id()). This is in the nightly now.
To use, you would store the row id as a reference and then use that as the selector.
Where than currently falls down is that the id selector will not work with deferred rendering. I think I can address than and also speed row selection by id by adding a mapping table (and the expense of a bit more memory for the map). I hope that have that in for 1.10.8.

Latest update - I've added a commit that allows the id selectors to work even on rows that do not yet have their DOM elements created. The implementation is a simple lookup object, so it is very fast. A few more details in the commit if you are interested.
Will be included in the 1.10.8 release which will be within the next few weeks.

Nice work. I will probably try it when I get back to table UI work.

This is again an issue 1.10.12 ;)

@DerDu - Please link to a test case showing the issue.


add --dbt support for --columns

--columns are used as the TDiffVars.include_columns when present

@dlawin Would this allow diffing only selected columns?

@dlawin Would this allow diffing only selected columns?

@sklinov yes exactly, this is analogous to using include_columns in dbt meta


Can you write an API that calculates whether the two GPS line segments exist

Can you write an API that calculates whether the two GPS line segments exist.
If the point exist, return the intersection point of GPS, otherwise return NULL

Hello, we tried to solve the issue.
This is what we did:
Create a new file src/getIntersectionPoint.ts with a function to calculate the intersection point of two GPS line segments. Also, update src/index.ts to export the new function.
You can review changes in this commit: https://github.com/mark-addams001881/manuelbieh-geolib-312/commit/32c435e71f39d98bc76b1dd5cd971c91c12a6025.

[!CAUTION]
Disclaimer: The concept of solution was created by AI and you should never copy paste this code before you check the correctness of generated code. Solution might not be complete, you should use this code as an inspiration only.

Latta AI seeks to solve problems in open source projects as part of its mission to support developers around the world. Learn more about our mission at https://latta.ai/ourmission . If you no longer want Latta AI to attempt solving issues on your repository, you can block this account.

Thank you for solving my problem!


fix: skip semicolon parsing

close: #25

Strictly speaking, this issue is actually not because empty-safe problem, it's because we didn't handle a unnamed SgNode properly like ;, [, ')', these useless punctuations are not meaningful for out analyzing in compile phase.
So I made a more general approach isUselessPunc as the filter method to exclude them when we're processing some SgNode's children().

Strictly speaking, this issue is actually not because empty-safe problem, it's because we didn't handle a unnamed SgNode properly like ;, [, ')', these useless punctuations are not meaningful for out analyzing in compile phase.
So I made a more general approach isUselessPunc as the filter method to exclude them when we're processing some SgNode's children().

I get it👍🏻


chore: update all BS references to 3.3.7

This commit updates all references of BS 3.0 from
3.3.* to 3.3.7 - as 3.3.7 was introduced in #783 PR
but no references in content have been updated.
Someone should look into demo application and quickly check how it renders under 3.3.7 (I've done this, but I haven't used the project in production, so have no experience with default design).
Thanks!

Current coverage is 90.39% (diff: 100%)

Merging #935 into development will not change coverage

@@           development       #935   diff @@
=============================================
  Files               26         26
  Lines              781        781
  Methods            142        142
  Messages             0          0
  Branches           115        115
=============================================
  Hits               706        706
  Misses              75         75
  Partials             0          0

Powered by Codecov. Last update b5c8448...0959fce

Thank you so much!


Move load and tap to _load and _tap, and make them protected collections

On second thought, it might be off putting to to have the two default collections have weird names. Maybe sit on this for a bit.


Fix some bugs in TypeCoercion rule

Which issue does this PR close?

Part of https://github.com/apache/arrow-datafusion/issues/3390
Rationale for this change

This PR fixes a number of bugs that I discovered when running a popular SQL benchmark. It does not fix all of them.
What changes are included in this PR?

Fix schema bug that affected queries with more than 2 inputs (union, intersect, etc)
Add type coercion for BETWEEN
Add workaround for a bug with + INTERVAL
Add coercion support for Date32 and Date64

Are there any user-facing changes?

No

Codecov Report

Merging #3407 (4e12037) into master (3987117) will increase coverage by 0.00%.
The diff coverage is 98.27%.

@@           Coverage Diff           @@
##           master    #3407   +/-   ##
=======================================
  Coverage   85.51%   85.51%
=======================================
  Files         296      296
  Lines       54303    54348   +45
=======================================
+ Hits        46436    46478   +42
- Misses       7867     7870    +3

Impacted Files
Coverage Δ

datafusion/core/tests/sql/predicates.rs
100.00% <ø> (ø)

datafusion/optimizer/src/type_coercion.rs
98.33% <97.22%> (-0.64%)
:arrow_down:

datafusion/optimizer/tests/integration-test.rs
88.88% <100.00%> (+4.88%)
:arrow_up:

datafusion/expr/src/expr_schema.rs
62.27% <0.00%> (-0.60%)
:arrow_down:

datafusion/core/src/physical_plan/metrics/value.rs
86.93% <0.00%> (-0.51%)
:arrow_down:

datafusion/expr/src/logical_plan/plan.rs
77.35% <0.00%> (-0.17%)
:arrow_down:

datafusion/expr/src/binary_rule.rs
84.78% <0.00%> (+0.28%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

I will review tomorrow, please hold it

I will review tomorrow, please hold it

@liukun4515  do you still want us to hold this PR for your review?

I'd prefer that we get these bug fixes merged to unblock some other items. Arrow is still following the "Commit-Then-Review" (C-T-R) policy:
A policy governing code changes which permits developers to make changes at will, with the possibility of being retroactively [vetoed](http://www.apache.org/foundation/glossary.html#Veto)

In other words, we can continue with the review after merge, and revert the PR if it proves to be problematic.

I agree -- let's merge this PR and we can either revert it or address comments in a follow on PR if/when provided by @liukun4515
Thanks all!


Fix Safari issue with no titles for history item

Description
Some Safari entries have no title. If this is the case, and they have
the same URL and datetime, then we can't sort them. Python doesn't allow
comparing strings and None.
This uses the solution here:
https://stackoverflow.com/questions/60695318/sort-a-list-of-tuples-with-none-values-in-python3
It does not affect the output. If the datetime were to ever be None,
this could cause an issue, potentially.
The diff is large because of running black/fixing flake8 issues so the pre-commit hooks pass.
Fixes: https://github.com/browser-history/browser-history/issues/272
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] I have read the contribution guidelines and followed it as far as possible.
[x] I have performed a self-review of my own code (if applicable)
[x] I have commented my code, particularly in hard-to-understand areas (if applicable)
[x] I have made corresponding changes to the documentation (if applicable)
[x] My changes generate no new warnings
[x] I have enabled the pre-commit hook and it's not detecting any issue.
[x] Any dependent and pending changes have been merged and published

Could you rebase the PR on the base branch? I've pushed a commit that might fix the failing CI

Could you add a test case that has None values which was causing the failure?
I can add it in a few days if you don't have the time/bandwidth for it

hmm, looked at the tests a bit, don't think I will be able to add in the coming week or so at least, unfortunately
the offending URLs, for your perusal:
https://github.com/login/oauth/authorize?client_id=<REDACTED>&scope=user:email,read:org&state=<REDACTED>
https://integralads.okta.com/enduser/callback?code=<REDACTED>&state=<REDACTED>
https://github.com/sessions/two-factor/app
https://github.com/riley-martine/vim-theme-work
https://github.com/sessions/two-factor
https://www.google.com/search?client=safari&rls=en&q=bash+declare+-A&ie=UTF-8&oe=UTF-8
https://stackoverflow.com/questions/47231003/declare-array-in-bash-script-errors-out-bad-array-subscript?lastactivity
http://www.erhanbirol.com/othersites/linux-e.com/data/declare.simple.bash.array.example.txt
https://www.google.com/search?client=safari&rls=en&q=github+use+ssh+instead+of+http&ie=UTF-8&oe=UTF-8
https://github.com/sessions/two-factor/webauthn

The stackoverflow link seems replicable; with 0.4.0 of browser-history, I can open safari, visit it, close safari, run browser-history -b Safari with the following added to line 290 of generic.py, and get new entries:
                    for x in output_object.histories:
                        if x[2] is None:
                            print(x[1])


A11y_Azure Tools Storage Explorer_Disk_DiskInfoTable_Screen reader: Voice over is not announcing table rows information when user navigates with Ctrl + Option + Arrow keys.

Preflight Checklist

[X] I have installed the latest version of Storage Explorer.
[X] I have checked existing resources, including the troubleshooting guide and the release notes.
[X] I have searched for similar issues.

Storage Explorer Version
1.32.1(96)
Regression From
NO
Architecture
x64
Storage Explorer Build Number
20231114.10
Platform
macOS
OS Version
MAC Version 13.6.1
Bug Description
GitHub Tags:
#A11yMAS;#A11yTCS;#MAC;#DesktopApp;#A11ySev2;#BM_AzureToolsStorageExplorer_MAC_Dec2023;#Azure Tools Storage Explorer;#FTP;#Voiceover;#WCAG1.3.1;#Info and Relationship;#Element:Table;
Environment Details:
Application: Microsoft Azure Storage Explore
version: 1.32.1 (96)
Screen Reader: Voice Over
Steps to Reproduce

Launch Storage Explorer
Tab Navigate to "Open Connect dialog" pane and Sign in to Azure.
Tab Navigate to "Manage Accounts" pane and Select the subscriptions you will use. Once selected, click on "Apply" button.
Tab Navigate to "Disks" of the selected subscription.
Tab Navigate to "A11ytest" and click on it.
Tab Navigate to Table under the tool bar.
Turn on Voice over and Observe that Voice over is not announcing table rows information when user navigates with Ctrl + Option + Arrow keys.

Actual Experience
Voice over is not announcing table rows information when user navigates with Ctrl + Option + Arrow keys.
Expected Experience
Voice over should be announcing table rows information when user navigates with Ctrl + Option + Arrow keys.
Additional Context
User Impact:
Screen reader users will face difficulty if Voice over is not announcing table rows information when user navigates with Ctrl + Option + Arrow keys.
Attachment:

This is fixed in the new react managed disks explorer that has been merged.
https://github.com/microsoft/AzureStorageExplorer/assets/111301956/c533fccc-e15e-482b-baf4-6e654c59d2e2

@richardMSFT Can you please let us know in which version this bug is fixed, so that i can verify and close it.

Hi @keerthiduvvuri. The fix has been merged, but a build with it hasn't been made yet.

Verified the issue in below environment:
Azure Tools Storage Explorer(Version: 1.33.0-dev (96))
Issue is fixed. Hence Closing the bug. Please find added attachment for reference.

#Closed;


Add metadata attributes to Codelists

Fixes #166
This adds attributes, optional elements and so-on to Codes and Codelists.

#13 is a different way to try and add this sort of information.

All of the changes in here look to already be in dev (they were required for Codelist validation work).
As such, am closing.


CO-1187: Latest hive doesn't honor syncset-pause annotation

/assign @staebler
/cc @dgoodwin

/lgtm

Is there a way to stop this burning CI resources until the issue is resolved?

Is there a way to stop this burning CI resources until the issue is resolved?

/hold

/hold cancel
Verify tests have been fixed.


SHP Module: Notify users if motion detectors are triggered while user is away.

Overview
Part of GH-2
Use Case Information

Use Case Name: Notify users if motion detectors are triggered while user is away.
Level: User-level
Brief Description: System shall send notification to users if any motion detectors are triggered while the user is away
Preconditions: Users must be set to away.
Triggering Event: Motion detector trigger
Main Flow: User is away. Motion detector is triggered. Send notification to user.
Extension: User isn't away. Motion detector is triggered. Notification is not sent.
Postcondition: Notification sent to away users on motion detector trigger.

Fixed


fix(build): update webpack jsx paths

SUMMARY
Update webpack jsx paths to support windows builds/dev server
closes https://github.com/apache/superset/issues/10997
Adapted from : https://github.com/apache/superset/pull/13744
TESTING INSTRUCTIONS
npm run dev-server in windows

@asadUllah58 I think you might be affected by that issue.


Pipeline fails if Node gets Preempted

Hello, I am currently working with an AML Pipeline that uses a Low-Priority VM Compute Cluster.
The error I am receiving is
AzureMLCompute job failed. PreemptionError: Nodes of this job got pre-empted. Check if the run has failed or restarted. Reason: Received pre-emption warning signal
On the docs it says that a "A preempted job is restarted, not resumed." but in my experience thus far, a preempted job is not restarted at all, it will just fail the pipeline. There doesn't seem to be a configuration setting that controls this on the AmlCompute class or the provisioning_configuration  function.
Versions
python==3.8.5
azureml-core==1.16.0

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2602bce8-83ed-cb02-ad23-943e3a955a43
Version Independent ID: f117372d-7e39-b79b-282f-aded9be4003c
Content: Create compute clusters - Azure Machine Learning
Content Source: articles/machine-learning/how-to-create-attach-compute-cluster.md
Service: machine-learning
Sub-service: core
GitHub Login: @sdgilley
Microsoft Alias: sgilley

Thanks for the feedback! We are currently investigating and will update you shortly.

@seanytak Hi Sean, thanks for your feedback again. I will combine the two threads( this one and the one you opened in Compute document) and the author will update the document for ore clarification and details. Thanks.
We will now proceed to close this thread. If there are further questions regarding this matter, please respond here and @YutongTie-MSFT and we will gladly continue the discussion.


essang, crenulated

This pull request was generated by the 'mq' tool

/trunk merge

/trunk merge

/trunk merge


Compatibility with Latest ARM Architectures

Has the library been tested or updated to work with the latest ARM architectures and devices? It would be beneficial to have information on compatibility and performance with newer hardware

Currently under development for the latest ARM architecture.


Generate hyperlinks for library note [XYZ] to the corresponding library_note doc-string.

See https://leanprover-community.github.io/mathlib4_docs/Mathlib/LinearAlgebra/Basis.html#Basis.constr for an example.
There we would like in "See library note [bundled maps over different rings]." for "bundled maps over different rings" to hyperlink to the doc-comment in Mathlib.GroupTheory.GroupAction.Defs, and moreover for the library_note in that file to actually be rendered on the documentation page! (It should come just above VAddCommClass.)

https://github.com/leanprover/vscode-lean4/issues/286 is the corresponding open issue for making library notes clickable in VSCode.


Stamina needs balancing

Hey there!
My pet never sleeps...ever. Why? It is eating automatically.

Eating food is adding so much stamina, sleeping is obsolete.
Some foods/ drinks are having a way more better value to price rating, so i am buying everytime the same. (see below screenshot)

suggestion:

Decrease the stamina on food and let VPet fall asleep when stamina is empty. Alternative getting sick?
Higher penaltiy on the "preference" food stat or other balancing tactics

I am using only original activities and food/ drinks.

In the current version, sleeping is a free source of physical strength and thirst.
This allows players to let their VPets sleep when they leave, thereby avoiding illness caused by prolonged lack of feeding when they return.
Using sleep can also prevent the VPets from moving around on the screen, which is another way to avoid disturbing work besides turning off the movement
In addition, the VPet actually sleeps by itself occasionally

The official food should all have the same cost-effectiveness, and there is a formula to calculate the cost-effectiveness of all official food. Only event food will have better cost-effectiveness, such as Zongzi, Christmas candy canes, etc
In previous versions, eating too much of the same food would lead to a sense of boredom and thus reduce effectiveness. Until recently, a recent update has been made to prevent boredom when eating tasty food
I can try to make the effectiveness have a minimum deduction value in the next version to avoid always eating one type of food

Coincidentally, there is a mod author who is making a sleep-related mod, maybe you can look forward to that mod

To make the pet more realistic, I suppose that sleep should be necessary rather than optional.
A pet that doesn't need rest and works all day makes me feel weird.

Perhaps a new attribute can be added, called sleepiness value, which determines work efficiency. Some drinks such as coffee can reduce this value. However, this may be a relatively large change. I will add it to the roadmap

Just try "Sleep" in steam workshop


not able to display the value

Hi i am using ng2-select component. It is amazing component . It is working great frm my create screen but not displaying value in update screen. any help
?

sorted by setting active date from script


express.json() causes my code to hang and never return

I'm trying to access the json encoded body of my incoming requests — I'm trying to use express.json() as it's presented in the docs, but when I add that middleware function it causes my code to hang. I saw this stackoverflow post mentioning something similar — but I'm calling the json function in my code unlike in this user's post.
Is there anything I can do? Is this a known bug?
Here's my code:
...
import express, {Request, Response, Application, json} from 'express';
...
const app:Application = express();
...
app.use(json());

/**
* I'm making a proxy server, this middleware forwards the incoming request to a new url
* /
app.use(rateLimiter, (req:Request, res:Response) => {
    // This successfully prints the body object as a json object, but it never returns a response
    // Removing app.use(json()) makes it work again.
    console.log(req.body);
    req.pipe(request(newUrl)).pipe(res);
});

//Start the proxy server
const server = app.listen(port, host, () => {
    console.log(`Server Running on 👉 ${host}:${port}`);
});

// Signal Handlers
process.on('SIGINT', () => server.close());
process.on('SIGTERM', () => server.close());

Unfortunately this is a limitation to Node.js: you can only read the request once. So either express.json can read it or your req.pipe can pipe it, not both.

Hi @aceamarco no problem! So in Node.js, the request object is a readable stream (https://nodejs.org/dist/latest-v18.x/docs/api/stream.html#readable-streams). Once the data is consumed from the stream, it is gone from the stream and cannot be consumed a second time. For further information and perhaps a better explanation would probably be best to ask on https://github.com/nodejs/help


nfldb stopped updating

My scores stopped updating around half-time on Sunday of week 2. All the late games have no scores and none of the games (except for Thursday's game) show as 'finished'.
I tried running  nfldb-update directly from a shell script but nothing changed:
STARTING NFLDB UPDATE AT 2016-09-19 18:16:56.970000
Connecting to nfldb... done.
Setting timezone to UTC... done.
Locking write access to tables... done.
Updating season phase, year and week... done.
Bulk inserting data for 7 games...
Sending batch of data to database.
Sending batch of data to database.
Traceback (most recent call last):
File "nfldb-update", line 39, in
nfldb.update.run(**vars(args))
File "C:\Python27\lib\site-packages\nfldb\update.py", line 535, in run
doit()
File "C:\Python27\lib\site-packages\nfldb\update.py", line 525, in doit
update_games(db, batch_size=batch_size)
File "C:\Python27\lib\site-packages\nfldb\update.py", line 397, in update_games
bulk_insert_game_data(cursor, scheduled, batch_size=batch_size)
File "C:\Python27\lib\site-packages\nfldb\update.py", line 221, in bulk_insert_game_data
do()
File "C:\Python27\lib\site-packages\nfldb\update.py", line 188, in do
nfldb.db._big_insert(cursor, table, bulk[table])
File "C:\Python27\lib\site-packages\nfldb\db.py", line 356, in _big_insert
% (table, insert_fields, values))
File "C:\Python27\lib\site-packages\psycopg2\extras.py", line 223, in execute
return super(RealDictCursor, self).execute(query, vars)
psycopg2.IntegrityError: insert or update on table "play" violates foreign key constraint "play_pos_team_fkey"
DETAIL:  Key (pos_team)=(JAX) is not present in table "team".

Looks like this is already being addressed in #194


Fixed math library link fail

It failed when i tried to cmake .; make due to math library linking issues

Thanks @hunar1997! That's a pretty bad miss from me, but I have finally added a simple pipeline for this repo so we should track build errors sooner


Change locale

I'm trying to show a list of countries with phone numbers in some locale but can't do this. Library get country name in system locale.  It is possible to change it?

Can you give an example of what the output is now and what it should be?

For example my device locale is German and it turns out that when I get the list of countries, they are in German locale, although in the application I need to show the list in English. I'm using getAllSupportedRegions()

Right, i just want to better understand what the german locale vs english looks like for the country names.

Okay, here's a better example:
Ukraine is "Україна" but should be Ukraine

That's odd as that looks like ukranian not german..
I think you just need to do the translation yourself, but I would assume if a person has their phone set in german they'd be comfortable seeing the countries in german too.
The limitation is from the PhoneNumberKit and libphonenumber packages - we can't specify the locale there, they just take the current device locale too.

Okay, thanks for the explanation.


🔧 Update template

This pull request merges the current state of the template used here into this project so that it is up to date.

:tada: This PR is included in version 2.0.7-develop.2 :tada:
The release is available on:

v2.0.7-develop.2
GitHub release
Docker container (sebbo2002/ble2mqtt:2.0.7-develop.2)
v2.0.7-develop.2

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.7 :tada:
The release is available on:

v2.0.7
GitHub release
Docker container (sebbo2002/ble2mqtt:2.0.7)
v2.0.7

Your semantic-release bot :package::rocket:


Drain nodes before kubadm upgrade and uncordon afterwards

Why is this PR needed?
This implements a basic drain and uncordon before/after running kubeadm upgrade. To achieve that we also have to add a new helper function kubernetes.UncordonNode().
Fixes https://github.com/SUSE/avant-garde/issues/1842
What does this PR do?
Implements drain and uncordon during kubeadm upgrade.
Anything else a reviewer needs to know?
None
Info for QA
This is info for QA so that they can validate this. This is mandatory if this PR fixes a bug.
If this is a new feature, a good description in "What does this PR do" may be enough.
Related info
None
Status BEFORE applying the patch
No drain or uncordon on upgrade.
Status AFTER applying the patch
Check if the nodes get drained when doing an upgrade.
Docs
We could add some troubleshooting to help users if the upgrade fails and the node is still cordon'ed.
Merge restrictions
(Please do not edit this)
We are in v4-maintenance phase, so we will restrict what can be merged to prevent unexpected surprises:
What can be merged (merge criteria):
    2 approvals:
        1 developer: code is fine
        1 QA: QA is fine
    there is a PR for updating documentation (or a statement that this is not needed)

I think in general this change is ok. But specifically for the v4 to v5 upgrade the node drain might come too late at this point in time.
This code is only executed after the node was upgrade from SLE15 SP1 to SP2, which is something that happens outside of skuba (and quite some time before calling any skuba commands). At least when taking the upgrade instruction from SUSE/avant-garde#1769 into account.

Totally agree, before doing the migration on the node, it needs to be drained, but that is going to have to be a manual step for the customers.
I am currently testing this with @mssola and we can confirm that the drain comes during skuba node upgrade at the correct time.
But after that the upgrade process is failing with this error:
Performing node master01 (<IP_ADDRESS>) upgrade, please wait...
I0728 11:31:02.101934     631 states.go:35] === applying state skuba-update-timer.disable ===
I0728 11:31:02.272137     631 ssh.go:183] running command: "systemctl disable --now skuba-update.timer"
Unable to apply node upgrade: failed to apply state skuba-update-timer.disable: Process exited with status 1
I0728 11:31:02.486664     631 ssh.go:206] Failed to disable unit: The name org.freedesktop.PolicyKit1 was not provided by any .service files

So we cannot confirm that the node is being uncordoned after the process.
If anyone has seen this error and can guide us it would be awesome.

After running skuba node upgrade apply on the master node (there is only one in this scenario) it failed with this error
I0729 13:47:39.508831   31009 states.go:35] === applying state kubernetes.enable-services ===
I0729 13:47:39.734901   31009 ssh.go:183] running command: "sudo sh -c 'systemctl enable crio kubelet'"
I0729 13:47:40.070836   31009 ssh.go:206] Created symlink /etc/systemd/system/multi-user.target.wants/crio.service → /usr/lib/systemd/system/crio.service.
I0729 13:47:40.100795   31009 ssh.go:206] Created symlink /etc/systemd/system/multi-user.target.wants/kubelet.service → /usr/lib/systemd/system/kubelet.service.
I0729 13:47:41.037570   31009 states.go:40] === state kubernetes.enable-services applied successfully ===
I0729 13:47:41.037587   31009 states.go:35] === applying state skuba-update.start.no-block ===
I0729 13:47:41.304070   31009 ssh.go:183] running command: "sudo sh -c 'systemctl start --no-block skuba-update'"
I0729 13:47:42.066056   31009 states.go:40] === state skuba-update.start.no-block applied successfully ===
I0729 13:47:42.066072   31009 states.go:35] === applying state skuba-update-timer.enable ===
I0729 13:47:42.271791   31009 ssh.go:183] running command: "sudo sh -c 'systemctl enable --now skuba-update.timer'"
I0729 13:47:42.607096   31009 ssh.go:206] Created symlink /etc/systemd/system/timers.target.wants/skuba-update.timer → /usr/lib/systemd/system/skuba-update.timer.
I0729 13:47:43.882897   31009 states.go:40] === state skuba-update-timer.enable applied successfully ===
Unable to apply node upgrade: unable to patch daemonset with kured unlocking annotation: Patch https://<IP_ADDRESS>:6443/apis/apps/v1/namespaces/kube-system/daemonsets/kured: EOF

Could not get status of the cluster for a couple of minutes
$ skuba cluster status
** This is an UNTAGGED version and NOT intended for production usage. **
E0729 13:48:33.635938   31703 status.go:43] unable to get cluster status: could not retrieve node list: an error on the server ("") has prevented the request from succeeding (get nodes)

After I got the status but the uncordon part never got to run
$ skuba cluster status
** This is an UNTAGGED version and NOT intended for production usage. **
NAME       STATUS                     ROLE     OS-IMAGE                              KERNEL-VERSION      KUBELET-VERSION   CONTAINER-RUNTIME   HAS-UPDATES   HAS-DISRUPTIVE-UPDATES   CAASP-RELEASE-VERSION
master01   Ready,SchedulingDisabled   master   SUSE Linux Enterprise Server 15 SP2   5.3.18-22-default   v1.18.6           cri-o://1.18.2      no            no                       4.2.2

I manually uncordon it
kubectl --kubeconfig admin.conf uncordon master01
node/master01 uncordoned

Apparently it is all normal
skuba cluster status
** This is an UNTAGGED version and NOT intended for production usage. **
NAME       STATUS   ROLE     OS-IMAGE                              KERNEL-VERSION      KUBELET-VERSION   CONTAINER-RUNTIME   HAS-UPDATES   HAS-DISRUPTIVE-UPDATES   CAASP-RELEASE-VERSION
master01   Ready    master   SUSE Linux Enterprise Server 15 SP2   5.3.18-22-default   v1.18.6           cri-o://1.18.2      no            no                       4.2.2
worker01   Ready    <none>   SUSE Linux Enterprise Server 15 SP2   5.3.18-22-default   v1.17.9           cri-o://1.16.1      no            no                       4.2.2
worker02   Ready    <none>   SUSE Linux Enterprise Server 15 SP2   5.3.18-22-default   v1.17.9           cri-o://1.16.1      no            no                       4.2.2

Both workers were updated without issues, both were drained and then uncordoned to be ready again.
$ skuba cluster status
** This is an UNTAGGED version and NOT intended for production usage. **
NAME       STATUS   ROLE     OS-IMAGE                              KERNEL-VERSION      KUBELET-VERSION   CONTAINER-RUNTIME   HAS-UPDATES   HAS-DISRUPTIVE-UPDATES   CAASP-RELEASE-VERSION
master01   Ready    master   SUSE Linux Enterprise Server 15 SP2   5.3.18-22-default   v1.18.6           cri-o://1.18.2      no            no                       4.2.2
worker01   Ready    <none>   SUSE Linux Enterprise Server 15 SP2   5.3.18-22-default   v1.18.6           cri-o://1.18.2      no            no                       5
worker02   Ready    <none>   SUSE Linux Enterprise Server 15 SP2   5.3.18-22-default   v1.18.6           cri-o://1.18.2      no            no                       5

I'd say the issue I have was because of only one master in the cluster.

Thanks for the detailed test and explanations @chentex! :pray:

what happens if the node-draining times out? This is most likely to happen if there are hundreds of customer-application pods running on that node doing all sorts of stuff. If that happens, maybe try to identify which pods stuck in terminating and try to delete them by force. Then re-try draining that specific node.

what happens if the node-draining times out? This is most likely to happen if there are hundreds of customer-application pods running on that node doing all sorts of stuff. If that happens, maybe try to identify which pods stuck in terminating and try to delete them by force. Then re-try draining that specific node.

As far as I know we still have a maximum of 150 pods/node. Did you encounter something like this in OpenShift? Would increasing the timeout to, let’s say, 10 minutes be “okay”? I can imagine that we drain the node and then run a crictl rmp -fa but usually I would expect that draining works somehow. In any case thanks for the concerns @drpaneas 🤗

As far as I know we still have a maximum of 150 pods/node. Did you encounter something like this in OpenShift? Would increasing the timeout to, let’s say, 10 minutes be “okay”? I can imagine that we drain the node and then run a crictl rmp -fa but usually I would expect that draining works somehow. In any case thanks for the concerns @drpaneas 🤗

Yes, I have seen this happening. It's not common, but it is still something you should consider it might happen :( I don't think increasing the timeout would help here. The crictl workaround should work though ;)

try to drain the node
if it timeouts do the crictl workaround
then try to drain the node again (it should work now)

I am not sure how you can reproduce this scenario though. @chentex one idea: maybe try running a pod that is using a volume mount on the host or something that interacts with the disk (e.g. take btrfs snapshots) so a simple smooth deletion won't suffice in this case.
Anyway, this is more of food for thought for another follow-up PR I guess.
Cheers @saschagrunert 🤗

That’s interesting, thanks for the insights @drpaneas. 😊 I think having some sort of failure recovery (crictl rmp) could be also done on a second execution of skuba upgrade. Then we check that the node is already drained and if workloads are still running we try to remove them.
One issue I see is the general idempotence of skuba invocations… I have to think more about this. 🤔

backpòrt https://github.com/SUSE/skuba/pull/1298/commits


Add documentation related to proxy support for APIMCLI

Description:
The following task was reported by Naduni
Can you please add the APIM CLI proxy support related details to the APIM 2.6.0 docs space?
I have already added them to the 3.2.0 docs via [1]. We need to add the same details and please mention this is available from APIM CLI 2.0.10 release onwards.
We can add them to the "Before you begin" section in [2], in the "Getting Started" sections in [3] and [4] and "Preparing Environments" section in [5]. Since the content is duplicated in all these pages, we have to add the details in all the pages.
[1] https://github.com/wso2/docs-apim/pull/2089
[2] https://docs.wso2.com/display/AM260/Initializing+projects+using+the+CLI+Tool
[3] https://docs.wso2.com/display/AM260/Migrating+the+APIs+to+a+Different+Environment
[4] https://docs.wso2.com/display/AM260/Migrating+the+APIs+and+Applications+to+a+Different+Environment
[5] https://docs.wso2.com/display/AM260/Building+CICD+Pipeline

This information has been added in the following pages as requested.
[2] https://docs.wso2.com/display/AM260/Initializing+projects+using+the+CLI+Tool
[3] https://docs.wso2.com/display/AM260/Migrating+the+APIs+to+a+Different+Environment
[4] https://docs.wso2.com/display/AM260/Migrating+the+APIs+and+Applications+to+a+Different+Environment
[5] https://docs.wso2.com/display/AM260/Building+CICD+Pipeline


PoissonRecon repo not found

Installing PoissonRecon (9.011)
[!] Error installing PoissonRecon
[!] /usr/bin/git clone git@github.com:StandardCyborg/PoissonRecon.git /var/folders/wx/r0s7cmv54ys7r22ch2ft4r4h0000gn/T/d20220819-74502-ojohs --template= --single-branch --depth 1 --branch xcodeproj
Cloning into '/var/folders/wx/r0s7cmv54ys7r22ch2ft4r4h0000gn/T/d20220819-74502-ojohs'...
ERROR: Repository not found.
fatal: Could not read from remote repository.

I changed the repo for this one mkazhdan/PoissonRecon, last version, but then some classes are missing like MeshingOperation.h

@XkRecarens thank you for the report! We’re using a fork of that library wherein we added those classes.
Just made it public, can you try again? Our changes are on the branch xcodeproj


base changes for issue #338

For issue https://github.com/zaquestion/lab/issues/338
main changes

use of sha instead of ref/branchName https://docs.gitlab.com/ee/api/pipelines.html#list-project-pipelines is more correct with detached pipelines ( via only: merge_requests )
use sha of upstream (not local)

additionally

add GetBranch and remove/replace BranchPushed
cmd parse args unification

use parseArgsRemoteString
add parseArgsRemoteRef (helper)

@zaquestion help with review - hope you will like this

@lukmdo this looks good, I originally implemented the ci jobs stuff as sha and switched away since I ran into issues retrieving the latest pipelines on reruns or something like that. I think the issues I hit were things like generally not seeing the jobs/pipelines you'd expect if you were viewing the CI on the MR or in the UI.
That said, your implementation looks stronger than what I originally crapped out, so I'm inclined to bring this in and see how it goes.

Oh now I see, and remember that we already discussed a lot of this in https://github.com/zaquestion/lab/issues/338


Getting SocketException: Connection reset with OHttp3 Client

Problem:
I am using OkHttp3 Client in Quarkus project, but I am getting the following error in production:
java.net.SocketException: Connection reset at java.net.SocketInputStream.read(SocketInputStream.java:186) ~[?:?] at java.net.SocketInputStream.read(SocketInputStream.java:140)
Details
My project is a type of middle layer that is calling the Backend APIs as a client, parses the response, and sends it back to the Front end. But sometimes, it throws the above exception when calling downstream APIs. In the case of a GET request, it retries two times, gets same exception and in third retry, a successful response is returned. But in POST request, it does not retries because of idempotency and fails in the first occurrence only.
Code:
public class CustomOkHttpClient extends HttpClient {
    private OkHttpClient client;
	public Response callDownstream(HttpRequest clientRequest){
	Response clientResponse = null;
        try {
            Call call = client.newCall(clientRequest);
            clientResponse = call.execute();
            return parseClientResponse(clientResponse, responseClass);
        } catch (final Exception exception) {
            logger.error("Exception occurred");
            throw exception;
        } finally {
            if (null!=clientResponse) {
                clientResponse.close();
            }
        }
     }
  }

Dependencies used:
com.squareup.okhttp3:

okhttp-urlconnection: 5.0.0-alpha.2

logging-interceptor: 4.9.3

mockwebserver: 4.9.0

Ways tried

Used finally block to close the connection.
Increased readTimeOut value of http client, but same error is happenning.

Request by Team

What approach can I do further?
Is this possible that the connection gets closed due to idle time period because no traffic is present during that time, and when after some long time, when request hit is made, it gets failed.

Use an application interceptor and implement your custom retry logic.
https://square.github.io/okhttp/features/interceptors/#choosing-between-application-and-network-interceptors
Generally we can't avoid network errors, and follow GET/POST rules for whether we can safely retry. But you can implement knowing whether POSTs are safe in your case. There are lots of blog posts discussing this topic.
For HTTP/2 you can set a ping interval https://square.github.io/okhttp/4.x/okhttp/okhttp3/-ok-http-client/-builder/ping-interval/


encapsulate multipart uploading APIs as one interface

The new adding file is to encapsulate the multipart uploading APIs(such as,Initiate Multipart Upload(),Multipart Upload(),Complete Multipart Upload()) as one interface called upload_large_file() now.

The new adding file is to encapsulate the multipart uploading APIs(such as,Initiate Multipart Upload(),Multipart Upload(),Complete Multipart Upload()) as one interface called upload_client now.
The file file_chunk.py contains some file operations like seek,read, which supports uploading file in upload_client.
Some error exceptions and http response code constant were added in the error.py and constant.py.

The new adding file is to encapsulate the multipart uploading APIs(such as,Initiate Multipart Upload(),Multipart Upload(),Complete Multipart Upload()) as one interface called upload_client now.
The file file_chunk.py contains some file operations like seek,read, which supports uploading file in upload_client.
Some error exceptions and http response code constant were added in the error.py and constant.py.
date:20170801,2208

The new adding file is to encapsulate the multipart uploading APIs(such as,Initiate Multipart Upload(),Multipart Upload(),Complete Multipart Upload()) as one interface called upload_client now.
The file file_chunk.py contains some file operations like seek,read, which supports uploading file in upload_client.
Some error exceptions and http response code constant were added in the error.py and constant.py.
date:20170801,2208

The new adding file is to encapsulate the multipart uploading APIs(such as,Initiate Multipart Upload(),Multipart Upload(),Complete Multipart Upload()) as one interface called upload_client now.
The file file_chunk.py contains some file operations like seek,read, which supports uploading file in upload_client.
Some error exceptions and http response code constant were added in the error.py and constant.py.
date:20170802, 0032

The new adding file is to encapsulate the multipart uploading APIs(such as,Initiate Multipart Upload(),Multipart Upload(),Complete Multipart Upload()) as one interface called upload_client now.
The file file_chunk.py contains some file operations like seek,read, which supports uploading file in upload_client.
Some error exceptions and http response code constant were added in the error.py and constant.py.
date:20170802, 1338

The new adding file is to encapsulate the multipart uploading APIs(such as,Initiate Multipart Upload(),Multipart Upload(),Complete Multipart Upload()) as one interface called upload_client now.
The file file_chunk.py contains some file operations like seek,read, which supports uploading file in upload_client.
Some error exceptions and http response code constant were added in the error.py and constant.py.
Test file for client were created.
date:20170802, 1828

The new adding file is to encapsulate the multipart uploading APIs(such as,Initiate Multipart Upload(),Multipart Upload(),Complete Multipart Upload()) as one interface called upload_client now.
The file file_chunk.py contains some file operations like seek,read, which supports uploading file in upload_client.
Some error exceptions and http response code constant were added in the error.py and constant.py.
Test file for client were created.
date:20170803, 1959

The new adding file is to encapsulate the multipart uploading APIs(such as,Initiate Multipart Upload(),Multipart Upload(),Complete Multipart Upload()) as one interface called upload_client now.
The file file_chunk.py contains some file operations like seek,read, which supports uploading file in upload_client.
Some error exceptions and http response code constant were added in the error.py and constant.py.
Test file for client were created.
date:20170804, 2225

Using iterator to read file or stream, adding callback function.

Code base has been changed, rebase your code before go further.

Using iterator to read file or stream, adding callback function.
2018,2320

Why closed.


[Example] Add docstring for test optimizer and test score

Description
add docstring for test_optimzer.cpp and test_score.cpp
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[x] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes
Comments
@leleamol

@mxnet-label-bot add [pr-awaiting-merge]


Fix shader for GLES2 high and medium.

I really like this plugin, thanks !
It really makes everything less uncanny.

Oh geez, thank you! :)


Migration Between Codis

Hi There,
I have Codis that has data and working with the old version 3.0.3.
I want to install the new version and Migrate the data from the old to the new one.
Can you please assist me on how to achieve it and what is the best way to perform it.

Hi @Roycohen,
I'm not sure if the dashboard of codis3.1 is compatible to the proxy of version 3.0.3.
If necessary, I'll try to find the answer and give you a solution.
Thanks~

Hi @spinlock,
Thanks!.
Waiting to hear your thoughts how is the best way to do that.

Hi @spinlock,
I've installed a new Codis without migrating.
If you still want to give a solution here it would be great so others can benefit from this question.
If not, you can close this one.
Thanks!

@Roycohen
Sorry, I almost forgot this issue.
I think you can upgrade your cluster from Codis3.0 to Codis3.1 with the following instructions.
Step 1: codis-fe

Kill codis-fe3.0.
Run codis-fe3.1 with command codis-fe --assets-dir=PATH_TO_CODIS3.1/assets --zookeeper=<IP_ADDRESS>:2181 --listen=<IP_ADDRESS>:8080. The newest codis-fe can find all your products from zookeeper or etcd automatically.
Don't worry if the main panel of FE is empty, since the API of dashboard has changed.

 Please don't kill it with signal -9, or dashboard won't release the lock of zookeeper/etcd before exit.
Run codis-dashboard3.1 with your old configuration. The newest codis-dashboard can works well with codis-proxy3.0.

Step 3: codis-proxy
After finish the first two operations, you can kill all your old proxies and replace them with new ones (can be deployed with command codis-proxy -c PATH_TO_PROXY3.0_CONFIG.toml --zookeeper=<IP_ADDRESS>:2181). The newest codis-proxy can also work well with old configuration. Please note that the 2nd argument --zookeeper=xxx will help codis-proxy to find the dashboard to finish the registration.
Step4: codis-server
It's not necessary to upgrade this component. But if you really want to do so, you can:

Add the new codis-server instance as slave into your cluster
After the master-slave replication, promote the slaves to masters and then remove the old instance.

@Roycohen Thank you very much!


Removed reference of Common from TestHostProvider

Removed reference of Microsoft.TestPlatform.Common project from Microsoft.TestPlatform.TestHostProvider.
Removed argument messageLogger from ExitCallBack as it is no more required.

@harshjain2,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


iOS - removeMarker at tangram-es 0.5.1 version

Hi I'm using tangram and this is awesome.
but one problem is happened.
I used tangram-es 0.5.0 version before. but when I update tangram-es 0.5.1 by cocoa pods,
I cannot find removemarker method.
in 0.5.0 version, there were 'markerremove(TGMapMarkerId)'
and This Version, Android have 'markerremove(Marker)'.
I want to know about this 'marker remove' method in 0.5.1 version in iOS
Thank you for reading my issue :)

Hi @seubseub thanks for the nice words! You can remove a marker from the map by simply settings its map to nil:
marker.map = nil;

@karimnaaji  Thank you for replying! I'll try it :)
Thank you!


Refactor how we render tests to include dbt unit tests and also data tests

Extracted from the comment by @dwreeves :
https://github.com/astronomer/astronomer-cosmos/pull/1377#pullrequestreview-2496632682

A thought as I read this, for another day though:
dbt 1.8+ has a new concept called unit tests, which it differentiates from data tests (formerly just "tests"). dbt's preferred way of running things is: unit tests -> build model -> data tests.
For the TestBehavior.BUILD, we comport with how dbt wants to run things 👍 because the order of operations is resolved automatically by dbt build.

We don't currently handle dbt unit tests for TestBehavior.AFTER_ALL and TestBehavior.AFTER_EACH though. 🤔 A natural way to do this would be to have AFTER_ALL also mean "before all" when it comes to unit tests, and similarly AFTER_EACH means "before each" for unit tests.

Alternatively, these could be decoupled; i.e. "before each, unit test" and "after all, data test," similarly "before all, unit test" and "after each, data test." But for TestBehavior.BUILD, decoupling gets weird. 🤷

No actionable item here other than, potentially, to mention in the docs that TestBehavior.BUILD is currently the only way to run dbt unit tests using Cosmos's automatic graph parsing. Just thinking out loud about the future.

Just to mention DBT actually recommends running unit tests as part of cicd and not part of the airflow job.
"dbt Labs strongly recommends only running unit tests in development or CI environments. Since the inputs of the unit tests are static, there's no need to use additional compute cycles running them in production. Use them in development for a test-driven approach and CI to ensure changes don't break them.
"
https://docs.getdbt.com/docs/build/unit-tests
In fact we may want to disable them by default?


chore(ci): use latest docker images

Legacy images with the prefix “circleci/” were deprecated in 2021.
https://circleci.com/blog/announcing-our-next-generation-convenience-images-smaller-faster-more-deterministic/

:tada: This PR is included in version 1.8.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fix fix dangling

@m-holger It is the calls to resolve that may trigger xref reconstruction.

I'm done tweaking.

This fixes the problem of an referenced object that is not in xref table being masked by a newly created object.
There is another (non?)-problem of a unreferenced object that is not in the xref table being omitted when the setPreserveUnreferencedObjects option is selected.

There is another (non?)-problem of a unreferenced object that is not in the xref table being omitted when the setPreserveUnreferencedObjects option is selected.

I don't care about that.

This fixes the problem of an referenced object that is not in xref table being masked by a newly created object.

That's the only way I could think of reproducing the problem, but I'm not completely convinced that it couldn't happen another way. Anyway, the previous logic was incorrect since just adding unresolved objects to the object cache will never trigger xref reconstruction. Only resolve can do that.

I'm going to go ahead and merge this. If you feel strongly about a different implementation, feel free to do another PR, but at this point, the major improvement of making this much more efficient by not requiring a full traversal is in, and the long-standing (but probably unimportant) issue of this not playing properly with xref reconstruction is also fixed.
Unreferenced objects that are not in the xref table are normal and can happen when objects are reused. Trying to detect them for a non-broken file would be incorrect. The fact that they show up with a broken file is probably undesirable, except when a file is broken, you really never know why. By far the biggest reason I've seen is that people modify the contents of an object without updating the xref table.

Thanks for finding this issue and drawing my attention to it and for providing the essential logic of the fix. I consider this to be primarily your contribution. I spent under 10 minutes tweaking to move the retry logic to the resolve call.


Refactor Suppressions.kt

I recommend to review this PR commit by commit.
The first commit refactors Suppression.kt to make it a bit easier. The idea of suppression is to look on the reported element if it has a Suppression with a matching name (what is a matching name can be discussed later, I didn't touch that part at all) or any of it's parents.
The new implementation creates a Sequence with all the annotations that the element and all it's parents have. And then check if any of them matches. And, because Sequence is lazy, as soon as we find one we don't need to continue to traverse the parents so this shouldn't create any performance issue.
With that idea I think that Suppresson.kt is easier to read now. I know that it's not really easy now wither but PSI doesn't help.

Warnings

:warning:
It looks like this PR contains functional changes without a corresponding test.

  Generated by :no_entry_sign: dangerJS against 1147be474d59ec80b2bc1fcb71d22342ca408ade


Fix vfio examples due to packet cluster api port

Description:
Issue: https://github.com/networkservicemesh/integration-k8s-packet/issues/295
Main changes:

n3-xlarge has other interface names (eno4 -> ens6f3)
Packet cluster API uses containerd instead of docker as a container runtime. containerd hasn't default limits. We need to set it manually using ulimit(required for SRIOV tests)

Signed-off-by: Artem Glazychev<EMAIL_ADDRESS>

@edwarnicke Feel free to add comments, we'll resolve them in separate PR.
Merging.


Fix ConfigMerger, so that it doesn't lose default value.

Fix for this issue.

Thank you, there was a merge conflict so I manually reapplied the change here:
https://github.com/gluck/il-repack/commit/e9b29626ff1846fbb2500d79a7ddf5a03b3b4be5


feat: add ruff-format option

Fixes #29
Tasks

[ ] add ruff_format CLI option
[ ] add tests

I am unsure how to hand over an argument in self._post_transforms.append(self._run_ruff)
So Iopted for two methods.

Now I have introduced quite a lot of duplication in the tests. What do you suggest? Go for more parametrization?
ruff_fix and ruff_format should tested both individually and in combination, I guess?

Now I have introduced quite a lot of duplication in the tests. What do you suggest? Go for more parametrization?

Not a lot of duplication really and having thing spelled out explicitly is never a bad idea :)

What do you think?

What do you think?

I have allowed myself to fix the test issue :)
Apart from that it looks good!

Thanks a lot!


npms.io search doesn't work

Duplicate of https://github.com/npms-io/npms-api/issues/69#issuecomment-328943304


[IMPROVE] Made NewsCarousel stylings consistent

I made stylings consistent in the news carousel section of the website. I made the width of each news card consistent, made the height of every card consistent and also did some minor stylings to improve overall UI.

This PR fixes the following issue:- https://github.com/RocketChat/RC4Community/issues/205

This PR fixes the following issue:- https://github.com/RocketChat/RC4Community/issues/205

Hey @muneeb-i-khan thanks for your PR and @itsmanojthapa awesome catch there!
After your changes, this is the behaviour....it's not completely responsive yet, please consider fixing this @muneeb-i-khan!

Just a tip to keep in mind, please add supporting screenshots/gifs of the before and after changes and explain what you've done in a bit more detail...thank you!😄


Abbreviated long options are properly parsed

When an abbreviated form of a long options is passed as argv, the value of it wasn't properly extracted.
A unit test was added to reproduce the issue and the code to fix it.
Fixes #5
Describe the change
This PR is intended to fix this situation: If you have a required --environment=string flag defined and your argv is --env=staging, the parsing process considers --env as a valid --environment=string but the staging value is not properly set to the option.
Why are we doing this?
When an abbreviated form of a long options is passed as argv, the value of it wasn't properly extracted.
Use this UT as a way to reproduce the issue:
  it "parses long option abbreviated and defined with =" do
    params, = parse(%w[--fo=bar], option(:foo, long: "--foo=string"))

    expect(params[:foo]).to eq("bar")
  end

Requirements

[X] Tests written & passing locally?
[X] Code style checked?
[X] Rebased with master branch?
[ ] Documentation updated?
[ ] Changelog updated?

Thank you ❤


Save event_n_channel which just contains s1_n_channels fields

What does the code in this PR do / what does it improve?
Can you briefly describe how it works?
Can you give a minimal working example (or illustrate with a figure)?
Please include the following if applicable:

[ ] Update the docstring(s)
[ ] Update the documentation
[ ] Tests to check the (new) code is working as desired.
[ ] Does it solve one of the open issues on github?

coverage: 93.695% (+0.03%) from 93.669% when pulling 667c5912e545e40614022e07af1fd2e023961c85 on event_n_channels into 3b8d13e59be9366b71c68503e9a95216d8846de7 on master.


Draw polygons instead of line segments

Use addPolygon() instead of lineTo() to draw linestrings and polygons.
Has better performance for large number of points and simplifies code.
https://github.com/greensopinion/flutter-vector-map-tiles/issues/10#issuecomment-997445131

implemented in https://github.com/greensopinion/dart-vector-tile-renderer/commit/548c0ccc8f1583d24cab358b069ee1af134a03c7


Add console-server

provide helm setting esServiceType to switch between ClusterIP and NodePort
this change is not 100% needed,
however for GKE clusters, you cannot create ingress for ClusterIP service..
to make it easy for customers I added
console-server service
// Please comment on service name, as it will be referred in docs
Also provided helm setting esServiceType that will change service into clusterIP
I am using esServiceType for other services too, grafana-server, prometheus-server,  es-monitor-api
I did that because, to make life easy in smoke-test I just have to create ingress for these services
connect to https://github.com/lightbend/es-backend/issues/270

@dbrinegar @srikanthops is this ready to merge? Can we merge it and close the associated issue?

I approved this one 7 days ago

Please merge it @srikanthops

@srikanthops is there some reason you aren't merging this PR?  I'm going to cut a release shortly...


Update section 'Create a Plone theme python package'

Fixes:

configure.zcml generated by mr.bob is not sufficient to use the package without problems and needs to be adjusted (765df04)
less files need to be renamed for successful resource compilation (44b25b4)

Improves:

Update outdated text and fix some issues

@cdw9 @MrTango can you please review and merge this?

Hi sorry, I didn't see it before. Im now in the middle of refacoring the same part. When I'm done with it I'll merge what is left.

I'll close this, because it's outdated after my refactoring of the training.


Error seed

Class 'Initbiz\CumulusCore\Repositories\PlanRepository' not found

Yes, sorry about the problem. We're currently working on a new demo app of our plugins. Once it's done, the plugin will be updated and working. All of the other Cumulus related plugins are fully supported and working, though.