[SA-18217] Update README with helm install instructions

Update README with helm instructions

Why not to extend the README.org file?

I have to say apart from the 2 README issue, these docs look really nice :+1:

I have to say apart from the 2 README issue, these docs look really nice +1

I agree, very nice!


add account number to external credentials file

loading the account number externally for placing orders would be useful

Account number is now available in the credentials.json file
https://github.com/veritacodex/TastyTrade.Api.Client/commit/fb8643eaa398e1c0e2c1ac570715acf638f7a30e


PutObject (Multipart): add support for parallel upload of parts in mu…

Fix for: #482 and adds a test case with a pseudo progress bar.

@harshavardhana Ok will fix this up and resubmit...the original Appveyor problem was with using cheggaaa/pb inside the tests. What is the best way to deal with that error?


[SuperEditor] Inserting a newline when cursor is at the end of a node causes text attributions to be copied

When pressing enter and the cursor is at the end of a ParagraphNode, the new node will contain a 0 length long AttributedText with attributions from the end of the previous node.
Instead, I expect the new node to not contain any previous text attributions on a 0 length text.
Cause:
When insertBlockLevelNewline is called after pressing enter, it will execute a SplitParagraphRequest (even when the cursor is placed at the end of the node.
The SplitParagraphCommand then splits the text and places the endText in the new node (which is length 0 but the attributions got copied over).
Instead, when the length if the end text is 0 we shouldn't copy over any attributions. This case is properly handled in SplitListItemCommand.

WRT the statement "I expect the new node to not contain any previous text attributions on a 0 length text" - I don't think that's the expectation that most people have in most situations. Typically, users are writing headers and paragraphs. When starting a new paragraph, a user expects bold, italics, strikethrough, and underline to continue. Essentially any stylistic attribution is expected to continue.
Also, I'm unclear as to the specific problem this ticket is meant to describe. This ticket simultaneously mentions block nodes, paragraph nodes, and list item nodes. The associated PR makes a minor modification to just one scenario. So which problem, exactly, is being capture here?
As for the solution, I just recently addressed this for paragraphs. Please use https://github.com/superlistapp/super_editor/pull/1297 as a guide to analyze the root problem.

The issue I tried to solve is fixed with #1297, which is that the LinkAttribution got carried over.
My assumption was that no attributions should be carried over, because this is the way SplitListItemCommand works. Hence my reference to it and my 'fix' to mirror that behavior.


Interfaces for clients, to make it easier to fake in unit tests?

@pengwynn, I'm curious what your thoughts are on using interfaces for the clients, to make it easier to fake them in unit tests? Currently I have an interface in my service code that proxies to the clients, so I can fake that in my tests. And I can live with that, but I wonder: if the clients themselves had interfaces, would that make life easier for others?

@half-ogre it's an interesting idea. I'd want to play with it on a couple of API domains.
My long-term dream to make testing easier is a Golang version of VCR which makes Octokit.rb testing replayable and refreshable from the actual server.


Changes for final doc review

@HeidiSteen @dereklegenzoff Please merge. This fixes:

Azure Function Core Tools - removed from package.json so SWA doesn't go over max zip file size
Changed bulk insert to work on lower Node.js version - original writting worked on 15 but Functions doesn't work on 15.


Fetch version from GitHub API

Motivation
https://app.clickup.com/t/r3293k
Implementation Notes
I used tag_name for the version identifier. I also re-enabled the commented out API version tests, they seem to work.
 I have no clue why they won't pass.
Locally they work fine.
test ps::agent::version::tests::test_should_check_for_new_version ... ok
test ps::agent::version::tests::test_get_latest_version ... ok


add --caption to send-file

$ npx mudslide@latest send-file me /tmp/file.txt --caption "here is the file"
make send-file the same as send-image and allow --caption option

/cib

Hi @lightaffaire
I've also added the --caption option to the send-file command, thanks for the feedback.


Strip proxy release binary

It's a simple/safe change - the proxy image is huge (300M - bigger than the ubuntu base)

We still need to update the sha in istio/istio once the proxy build is ready.

@costinm it should already be done now with https://github.com/istio/istio/pull/5482

It doesn't make sense - you can build a docker image with debug symbols for your own debugging.
That doesn't mean regular users need this. Just replace the envoy in the docker container with your custom build.
The real problem is that core dump seems to be broken - and we should fix that, which will give you all
the info you need.
Please revert the release version with stripped binary - I can change the build to generate a custom version of proxy with debug symbols if  we find more crashes and core dumps can't be fixed - but vast majority of users don't need this.

Please revert back to stripped - #5745 will take care of providing detailed stack trace ( core can be used against an unstripped binary ). We will need to provide a download link for an unstripped binary for devs who need to debug core dumps - but this can be done separately.


Cannot find remote ref

This is happening here: https://github.com/styled-components/styled-components-website/pull/158

/cc @hugomd this is on your branch, maybe related?

@mxstbr I haven’t seen this before, I’ll take a look and try to replicate 👍

@mxstbr Should I do something? Did I break this?

No, that's on stage-ci.

From what I can tell it's failing on this line:
log.info(`> Fetching ${ref}...`);
await git.fetch('origin', ref);

It could be an underlying git issue (unlikely), an issue with simple-git or we're grabbing the wrong ref and other git information, maybe?
I've attempted to replicate locally with this code, but I don't have any issues:
const git = require('simple-git/promise')();

(async () => {
  await git.clone('https://github.com/styled-components/styled-components-website.git', './style-comp', ['--depth=1', '--branch=add/alogliadocs']);
  await git.cwd('./styled-components');
  await git.fetch('origin', 'add/alogliadocs');
})();

@mxstbr It'd be super helpful if you could grab the payload sent to the webhook and paste it in here 🙏

put up a fix for this in https://github.com/zpnk/stage-ci/issues/38

Thanks for the PR @paulirish ! 🙏


Update Tuva Claims Demo Tutorial

Here's how the quickstart tutorial should work:

Clone tuva_claims_demo from Github
Configure the dbt project to run in your environment
Import the_tuva_project package
Run dbt build.  Describe how this loads a synthetic claims dataset into your data warehouse from S3 and builds the entire Tuva Project
Setup and run tuva_analytics

@tuvaforrest need you to update the functionality to load full dataset from s3.

@thutuva and @cocozuloaga - i know we need forrest to do NDC as well.  but currently tuva_claims_demo only works on 50 patient sample.  we need the larger sample for dbt partnership demos.
@tuvaforrest how long would this take (just talking loading from s3)?  maybe if it's not too bad we can do this before NDC?

@aneiderhiser test

@aneiderhiser @tuvaforrest S3 seed logic was added with PR https://github.com/tuva-health/tuva_claims_demo/pull/17.


xml:lang errors in Ace and Epub Checker

I can't get both Ace and Epub Checker to agree on where the xlm:lang tag should be put in epub 2 in the OPF file. Ace wants it in OPF in "package" but that's only for epub 3, so it throws an error in Epub Checker. Any advice? Many thanks in advance.

Could you please post your comment in this existing issue, thank you: https://github.com/daisy/ace/issues/376


Token download link

Point users to web based token download when .agtoken is not found.
Closes #3
Validation
Remove your ~/.agtoken.  Try using agio.  Make sure that the error messages help you get a token.

Bump @japplefield This is now (finally) passing CI.


not being catch by google( + code contribution )

Hello,
first of all, my problem was to search on google in a custom interval, which yours code just do for a defined period of time. So I changed your code for searching in custom period of time:
initialize google.timeSpan as:

//for custom date: pass object in the format
// {from: "mm/dd/yyyy",
// to:"mm/dd/yyyy"
// }
google.timeSpan = {
from: "07/16/2017",
to: "07/18/2017"
}

here is my code, in google.js, over the line 40:

if (google.timeSpan) {
if(typeof google.timeSpan == 'object'){
var min = google.timeSpan.from
var max = google.timeSpan.to
var it_= "&tbs="+querystring.escape('cdr:1,cd_min:'+min + ',cd_max:'+max + '&tbm=')
// tbs=cdr:1,cd_min:7/11/2017,cd_max:7/18/2017&tbm=
URL = URL.indexOf('tbs=qdr:') >= 0 ?
URL.replace(/tbs=qdr:[snhdwmy]\d*/, it_ )
: URL.concat(it_)
}
else{
URL = URL.indexOf('tbs=qdr:') >= 0 ? URL.replace(/tbs=qdr:[snhdwmy]\d*/, 'tbs=qdr:' + google.timeSpan) : URL.concat('&tbs=qdr:', google.timeSpan)
}

But now for my help request:
it's simples, it's not with the code. I make my request to Google and I try to wait at least 3-5 or more min for each request but soon or later google catch me and block my requests.
I looked on internet but there are a bunch of things, I think you guys can at least give directions or links for read, good practices and stuffes,  anything helps.
Thanks

Ok, Just read the read me


WIP: Rewrite

This rewrite will bring the following:

A new frontend commenting UI
The ability to share with external users without formal review
View comments in the admin
Headless support

TODO:

[x] Add new models
[x] Remove old models with data migrations to new models
[x] Add new commenting API
[x] Add new commenting frontend (https://github.com/wagtail/wagtail-review-ui)
[x] Add share modal
[x] Add comments viewer in editor
[x] Make review URL configurable (for headless sites)
[ ] Custom ReviewRequest classes (using MTI instead of swappable models)
[ ] Review response emails

Test coverage at 96% now :tada:


[LSP] - allow lineLength argument on server initialization

Related to https://github.com/emacs-lsp/lsp-dart/issues/53#issuecomment-673637634
Currently, the VSCode DartCode extension has an option for specifying the dart.lineLength to use when formatting the document.
Is there any way to setup the LSP server to when the client request textDocument/formatting the server use the provided lineLength?

c/c @DanTup

@ericdallo in recent builds (that include https://github.com/dart-lang/sdk/commit/ba459f96cfe020e8d6b01f527959e5e1bb900508), this is supported using the dart.lineLength workspace setting:
https://github.com/dart-lang/sdk/blob/master/pkg/analysis_server/tool/lsp_spec/README.md#client-workspace-configuration
It's not provided at initialisation, as that means the server must be restarted if the value changes. By using config, it can be modified by the user and take effect immediately.
Let me know if this doesn't work for you. Thanks!

@DanTup sorry, I didn't notice that addition, this will certainly fix the issue, I'll implement that support on lsp-dart, thank you!

@DanTup We got this issue on lsp-dart, and after some debugging I could not find why formatting is not working on lsp-dart, could you confirm if is everything ok from the server side?
This is the log from lsp-mode with the LSP requests/responses:
[Trace - 03:06:07 PM] Received request 'workspace/configuration - (1).
Params: {
  "items": [
    {
      "section": "dart"
    }
  ]
}

[Trace - 03:06:07 PM] Sending response 'workspace/configuration - (1)'. Processing request took 0ms
Params: {
  "jsonrpc": "2.0",
  "id": 1,
  "result": [
    {
      "enableSdkFormatter": true,
      "lineLength": 200
    }
  ]
}

But the code is still formatted using 80 caracters.
I'm using this branch for lsp-dart. Am I missing something?

The request/response above look correct. Just to clarify - are you saying it works correctly from within VS Code when using previewLsp, just not for emacs?
If so, are you able to capture a full log (everything from initialisation, to the bad format response) for me to review? Thanks!

Yes, for VScode works.
Sample code:
lsp-dart-bug.zip
LMK if there is some bug with lsp-dart or lsp-mode

@ericdallo can you confirm which version of the Dart SDK you're using for testing? This setting was included in v2.10.0 of the Dart SDK, but I don't think that's what's used for this log, as it doesn't include the server info which is also included in that version. I think upgrading to the latest SDK may resolve the issue.

Sure @DanTup, sorry for the delay.
It works using flutter beta channel, dart 2.10.0.
Thank you @DanTup!


Edge cases  are inconsistant for rev and fwd fmin and fmax

Description
d fmin(x,y) / d x is undefined if x == y, so fwd returns NaN. But in the limits if we are approaching the point x == y from either side we get either 0 or 1, one of which is pragmetically returned by rev implemetation. Similar for fmax.
I think same handling of edge cases should be used in both implementations. Which one should we use?
Example
var a = 1;
var b = 1;
var c = fmin(a, b);
c.grad(); // a.adj() == 1; b.adj() == 0

fvar d = {1,1};
fvar e = {1,1};
fvar f = fmin(d, e); //f.d() == NaN

Expected Output
Same handling of edge cases for fwd and rev.
Current Version:
v3.3.0

Given this https://www.wolframalpha.com/input/?i=derivative+min(x%2Cy)

it should be how rev does it.

Closed via #2063


Change 'var' to 'const' in the Sidebar. Add type to the divStyle

4th case. Change 'var' to 'const' in the Sidebar component. Add type to the divStyle

I forgot to put the divStyle variable out of the SidebarComponent scope. I am going to change it...

It has been moved the divStyle element out of Sidebar component. Issue can be closed

I think there are some errors after the last change. To solve them, the chage should be like this:
const divStyle = (props: React.CSSProperties) => ({
width: (props.isVisible) ? '250px' : '0px'
});
export const SidebarComponent = (props: Props) => {
return (

Basic side bar, first steps

 );
}

Ok, thanks @ebarriosara


[NewFeature] add hf config solution

PR types

New features
PR changes

Models
Description

add huggingface config solution

fix by your comments.


FPS measurement

Hi, I was wondering how you measured the speed of your model. Your paper says SEA-RAFT(S) processes 1080p frames at 21 fps on a 3090. However, when I run the model on a 3090TI, I only reach 5.5 fps.
I use the following code and PyTorch 2.4.1 to measure the speed:
import numpy as np
import torch
import sys
from argparse import Namespace

sys.path.append("core")
from raft import RAFT

@torch.no_grad()
def main():
    searaft_s = Namespace(
        dim=128,
        radius=4,
        block_dims=[64, 128, 256],
        initial_dim=64,
        pretrain="resnet18",
        iters=4,
        num_blocks=2,
    )

    model = RAFT(searaft_s).cuda()
    model.eval()

    img1 = torch.rand((1, 3, 1080, 1920)).cuda()
    img2 = torch.rand((1, 3, 1080, 1920)).cuda()

    times = []

    warmup_it = 10
    measure_it = 100

    for _ in range(measure_it + warmup_it):
        start = torch.cuda.Event(enable_timing=True)
        end = torch.cuda.Event(enable_timing=True)

        start.record()
        _ = model(img1, img2, test_mode=True)
        end.record()

        torch.cuda.synchronize()

        times.append(start.elapsed_time(end))

    times = times[warmup_it:]

    mean = np.mean(times).item()
    std = np.std(times).item()

    print(f"Time: {mean:0.1f}ms Std: {std:0.1f}ms")
    print(f"FPS: {1000 / mean:0.1f}")

if __name__ == "__main__":
    main()

We do 1080p images with "downsample-upsample" strategy, which means you do inference in 2x downsampled resolution. We use "downsample-upsample" for the test split on spring and achieve SoTA on the leaderboard.


Running other tasks from a task

Context
As a user, I would like to declare a task that calls other orbit task. Since the orbit.yml is templated, this makes it hard to call orbit again with the same calling parameters.
Example: orbit is run using orbit run -p Tasks,tasks.yml -f ../shared-orbit.yml <task_name>
In order to call other tasks from a given task, I would have to copy/paste that line which is far from ideal since it implies the task as knowledge of how it gets called.
Proposal
Add a tasks entry to refer to other tasks in the current file.
In order to remove confusion, either tasks or run should be provided, not both, otherwise order of command execution would be unknown.
tasks:
{{ range $app := .Orbit.Tasks }}
  - use: {{ $app }}
    tasks:
    - {{ $app }}:render
    - {{ $app }}:upload
  - use: {{ $app }}:render
    run:
     - echo "{{$app }}: render step"
  - use: {{ $app }}:upload
    run:
     - echo "{{ $app }}: upload step"
{{ end }}

Now, with a tasks.yml with the following content
- foo
- bar

Running orbit run -p Tasks,tasks.yml foo bar should print
foo: render step
foo: upload step
bar: render step
bar: upload step

Your Environment

Version used (orbit version): 3.0.1

Thanks for writing this app, it has been super useful so far 👍

Hi @j-vizcaino!
With the following orbit.yml file:
tasks:
{{ range $app := .Orbit.Tasks }}
  - use: {{ $app }}
    run:
    - orbit run {{ $app }}:render
    - orbit run {{ $app }}:upload
  - use: {{ $app }}:render
    run:
     - echo "{{$app }}: render step"
  - use: {{ $app }}:upload
    run:
     - echo "{{ $app }}: upload step"
{{ end }}

And the payload file orbit-payload.yml:
payload:
  - key: Tasks
  - value: tasks.yml

You could run orbit run foo bar which should give you the expected behaviour.
Still, being able to call others tasks within the same context could make sense. I'll consider it for the next 3.1.0 release 😃

Thanks for quick answer! That's right, the example you provided works and will unblock me for the time being.
Though, this example makes the following assumptions:

orbit is in your PATH
orbit run was run without any other argument

Running those in the same context would allow for proper composition of tasks and consistency of, say debug flag.

Indeed, it feels a bit hacky 😄 but what I like is the use of text/template possibilities to handle such case.
That's said, it could be nice to be able to have an orbit.yml file like this:
tasks:

  - use: myTask
     run:
       - {{ run('subtask1', 'subtask2') }}
       - cmd
       - cmd


MAINTAINERS: add a separate area for blackmagicprobe runner

Add an area for Black Magic Probe and myself as maintainer. It's just a runner file and does not get much traffic, but I have the hardware to test this and use it regularly so I may as well get PRs for this from the bot.

Appreciate you taking this on @fabiobaltieri , but isn't this the same as someone creating an area for one specific driver, which we've pushed back on in other cases?

Almost certainly, you tell me, I'm not particularly vocal about this but the last few of these got thrown my way anyway because few people use this, figures this would make it happen automatically and not after weeks of no response.

@MaureenHelm what's the verdict? yay or nay? I'm not too emotionally attached to either option, just want this PR off my queue, happy to close it :-)

@MaureenHelm what's the verdict? yay or nay? I'm not too emotionally attached to either option, just want this PR off my queue, happy to close it :-)

I'd rather see one west runners area and treat it like a driver class.

I'd rather see one west runners area and treat it like a driver class.

Sounds good, let's reevaluate down the road then.


improve the Kubeflow Notebooks Docker image

Currently, we provide docker images (elyra/kf-notebook) for using Elyra with Kubeflow Notebooks, you can find the Dockerfile here.
We can improve this Dockerfile in the following ways:

Stop using a requirements.txt approach, just explicitly use pip install (makes it more clear)
Don't switch root when installing python packages (as this makes the files not owned by the jovyan user)
Update the base FROM image to: public.ecr.aws/j1r0q0g6/notebooks/notebook-servers/jupyter:v1.3.0
Explicitly install the kfp package (We could also just let Elyra's requirements do this)
I don't think yarn is strictly needed (is this a dependency of Elyra)?

Applying the above changes would give us the following Dockerfile:
FROM public.ecr.aws/j1r0q0g6/notebooks/notebook-servers/jupyter:v1.3.0

# install - kfp + elyra
RUN python3 -m pip install --no-cache-dir --use-deprecated legacy-resolver \
    kfp==1.7.2 \
    elyra==3.0.1

# build JupyterLab plugins
RUN jupyter lab build

Thanks for the feedback @thesuperzapper, would you like to provide a pull request with these updates?

@lresende done!
See PR: https://github.com/elyra-ai/elyra/pull/2114

Shouldn't the Dockerfile include some reference to the source code in the repository? For example, if I wanted to make changes to the elyra distribution and test it in my stack, I would also need to update the Dockerfile which is making development tedious. I'd love to see closer integration to the source rather than installing directly from PyPI.

I guess a couple of the other Dockerfile have it, but this one does not.

@lresende I think we should have a "prod" one which installs from PyPi, and a "dev" one which compiles by building from the local repo.

@lresende I think we should have a "prod" one that installs from PyPi, and a "dev" one that compiles by building from the local repo.
(Most users will want a container image with exactly what they would get from pip for production, and will never need to use the "dev" one)

Completely agree, hereis how we implemented for the elyra-image but I guess we could go one step deeper and use your local clone as the source instead of using a master clone/checkout.

@marcjimz Do you want to create a new issue to enhance the way we build our docker images using local source when building dev.

@lresende will do. I gave this a shot this afternoon but could use a pointer or two, was running into permission issues.

https://github.com/elyra-ai/elyra/issues/2116


chore(master): release 1.1.8

:robot: I have created a release beep boop
1.1.8 (2023-06-24)
Miscellaneous

deps: update dependency wayofdev/cs-fixer-config to v1.2.17 (f34fa56)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/wayofdev/laravel-symfony-serializer/releases/tag/v1.1.8 :sunflower:


Sitemap is generated in the current directory, rather than using $MWK

Line https://github.com/a3n/miki/blob/master/makefile#L145 has a bug, I think it should be:
tree -H $(MWK) -T "$(MWK) sitemap" $(MWK) > $@

to ensure that tree is run on the $MWK directory :+1:

I'm not seeing that behavior, after a few test runs. I'll keep looking.
What's the output of
echo $MWK
on your system?
Are you using Gnu Make?
$ make --version
GNU Make 4.1
...
Here's my test:
aaron@tesla ~/MyMiki %
rm sitemap.html
aaron@tesla ~/MyMiki %
cd
aaron@tesla ~ %
pwd
/home/aaron
aaron@tesla ~ %
mwk
Generate sitemap.

tree -H /home/aaron/MyMiki -T "/home/aaron/MyMiki sitemap" >
/home/aaron/MyMiki/sitemap.html
Notice in the expanded makefile output, the result is redirected to
/home/aaron/MyMiki, which is the directory where my example wiki is.
I also tested this on my actual personal wiki and got the
expected behavior.
Did you update your clone from the remote, or did you manually copy
lines into your existing makefile (total guess).
On my system:
$ grep -i site makefile
SITE := $(MWK)/sitemap.html
HTML := $(RHTML) $(MHTML) $(CATA) $(SITE)
Generate sitemap
sitemap: $(SITE)
$(SITE):
    # Generate sitemap.

    tree -H $(MWK) -T "$(MWK) sitemap" > $@

If I just run the tree command on the command line, without the
redirection (and remove the parens around the two instances of MWK),
then the sitemap is printed in the terminal.
The line in the makefile is redirected to $@, which is $(SITE), which is
defined in the first line in the grep output above as /sitemap.hmtl. It's hard to see how the output could go anywhere
except where it's supposed to.
On Tue, 14 Mar 2017 22:22 -0700, Patrick Yates<EMAIL_ADDRESS>wrote:

Line https://github.com/a3n/miki/blob/master/makefile#L145 has a bug,
I think it should be:

tree -H $(MWK) -T "$(MWK) sitemap" $(MWK) > $@
to ensure that tree is run on the $MWK directory 👍

— You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub[1], or mute the
thread[2].

--
Aaron
Links:

https://github.com/a3n/miki/issues/1
https://github.com/notifications/unsubscribe-auth/AD7FdlUnRvw7H6rQSmdNhA6DVcbwkM5Dks5rl3WVgaJpZM4Mdftk

Sorry, I think I didn't explain my problem clearly in the first post. The sitemap.html is generated fine in the $MWK directory, that is not a problem.
The problem is that tree generates the directory tree for the current working directory, which is wherever the mwk command is run from. Instead I think that the tree should be generated for the $MWK directory.

Ah, you are correct in the report and the fix.
Fixed and pushed, thanks very much.
On Tue, 14 Mar 2017 23:12 -0700, Patrick Yates<EMAIL_ADDRESS>wrote:

Sorry, I think I didn't explain my problem clearly in the first post.
The sitemap.html is generated fine in the $MWK directory, that is not
a problem.
The problem is that tree generates the directory tree for the current
working directory, which is wherever the mwk command is run from.
Instead I think that the tree should be generated for the $MWK
directory.
— You are receiving this because you were assigned. Reply to this
email directly, view it on GitHub[1], or mute the thread[2].

--
Aaron
Links:

https://github.com/a3n/miki/issues/1#issuecomment-286650427
https://github.com/notifications/unsubscribe-auth/AD7FdrpccgAro891oPW33yTNXayPcUeKks5rl4EygaJpZM4Mdftk

Closing issue as fixed.


Bug Report: valid addProduct messages land up in putback

Expected Behavior
addProduct messages should land up in database
Current Behavior
Specific messages landed up in putback
{
  "product_id":"product_nhycw30pft"
  "time_per_unit_in_seconds":1
}

{
  "Putback":{
    "FirstTsMs":1651847341588
    "LastTsMs":1651847642539
    "Amount":314
    "Reason":"Other"
  }
}

Relevant log output
No response
Steps to Reproduce
?
Context (Environment)
Venice customer
Possible Solution
No response
Version
v0.9.x
Anything else?
No response

Tracking logging for this in #1069

@JeremyTheocharis This was released in 0.9.3, has the release been deployed at Venice, and was there any observed misbehaving traffic afterwards ?

@JeremyTheocharis Where you able to observe this behaviour, after 0.9.3 ?


tf.py_function InternalError in distributed mode

Please make sure that this is a bug. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:bug_template
System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Linux Ubuntu 16.04.6 LTS
TensorFlow installed from (source or binary):
pip
TensorFlow version (use command below):
1.13.1
Python version:
3.6.7

Describe the current behavior
I'm testing tensorflow distributed on the same machine. I opened two separate shells and created a cluster using:
import tensorflow as tf
cluster = tf.train.ClusterSpec({"local": ["localhost:2222", "localhost:2223"]})
server = tf.train.Server(cluster, job_name="local", task_index=0)

on shell 0 and
import tensorflow as tf
cluster = tf.train.ClusterSpec({"local": ["localhost:2222", "localhost:2223"]})
server = tf.train.Server(cluster, job_name="local", task_index=1)

on shell 1.
On shell 1 I ran:
import tensorflow as tf
import numpy as np

def add(a, b):
    return a + b

NUM = 1000
ones = np.ones((NUM))

graph = tf.Graph()
with graph.as_default():
    va = tf.Variable(ones)
    vb = tf.Variable(ones)
    with tf.device("job:local/task:1"):
        inputs = [va, vb]
        out = tf.py_function(add, inputs, tf.float64)

    with tf.Session("grpc://localhost:2223", graph=graph) as sess:
        sess.run(tf.global_variables_initializer())
        print(sess.run([va, vb]))
        print(sess.run([out]))

which returns the error:

InternalError (see above for traceback): expected the py_func to return a Tensor backed by memory in /job:local/replica:0/task:1/device:CPU:0, but is actually in /job:localhost/replica:0/task:0/device:CPU:0. This is a bug.

while this does not happen if I replace tf.py_function in the code above with tf.py_func.
Describe the expected behavior
Code should run successfully like when using tf.py_func and should print the arrays:

[array([1., 1., 1., 1., ..., 1., 1., 1., 1.]), array([1., 1., 1., 1., ..., 1., 1., 1., 1.])]
[array([2., 2., 2., 2., ..., 2., 2., 2., 2.])]

I believe this has been fixed in nightly.
Can you try?

Hi @alextp,
I confirm this issue has been fixed on 1.14.1-dev20190325. Thanks!


Ignore return code of coverage script

As suggested in https://github.com/PyO3/pyo3/issues/439#issuecomment-498853201, a failure in the coverage script should not cause the whole build to
fail.
#439

Thank you!


display:box;

Hello,
thank you for your work. Can you pleas chack display: box; it isn't works for me, example with flexbox.

Thanks for reporting! It is now fixed in v2.1.


Uncharger does not neutralize azide

from rdkit import Chem
from rdkit.Chem.MolStandardize import rdMolStandardize
uncharger = rdMolStandardize.Uncharger()
m = Chem.MolFromSmiles('[N-]=[N+]=[N-]')
p=uncharger.uncharge(m)
[09:15:16] Running Uncharger
Chem.MolToSmiles(p)
'[N-]=[N+]=[N-]'

I expected N=[N+]=[N-] as a uncharged product.
Rdkit version 2019.03.4 on Linux (from conda)
By the way IHMO logs from normal works of uncharger should by disable by default.

I understand the request and agree that this is something worth thinking about.
To explain the current behavior: the uncharger does not modify anions that are directly bonded to cations (or vice versa).


How to restrict years range in date picker?

I would like to know if it is possible to have the years above the current one not shown. For example, if we are in 2017, I do not want it to show 2018 onwards. Thanks in advance.

You can't do that at the moment.
But you could set and endDate and hide all disabled days via css:
https://github.com/fengyuanchen/datepicker/blob/master/README.md#enddate


How can I exclude a specific genre from the randon anime request?  Several hentais are returned, I don't want that in my application

--------------^ Click "Preview" for a nicer view!
We primarily use GitHub as an issue tracker; for usage and support questions, please check out these resources below. Thanks! 😁.

Discord:
Have a look at the readme for more information on how to get support:
https://github.com/jikan-me/jikan-rest/blob/master/README.md
Container usage for self hosters: https://github.com/jikan-me/jikan-rest/blob/master/container_usage.md

I think you messed up the issue body a bit but reading your title, you can add the sfw flag to remove any adult entries.
e.g https://api.jikan.moe/v4/random/anime?sfw

Thank you!


Sends user warning if QnA is unconfigured; if unconfigured, doesn't c…

Fixes #1578
Proposed Changes

Previously when user started QnABot in sample 11.qnamaker without setting up QnA KB, bot would simply respond "Oops. Something went wrong" without any clear explanation, when the user started the bot and sent a message to bot
Now bot will check if a QnA KB is configured properly with the bot, and will message the user to provide missing credentials, if needed. Provides link to qnamaker.ai if KB needs to be created.

This is done in the onMessage handler
If QnA is not configured, then bot will not call QnAMaker.getAnswers()

@stevengum I...honestly have forgotten where I saved the 1st branch with these changes (whoops!)
Anyways, made sure to not call QnAMaker if it's not config'd, as you requested for changes


[Help]

Hello,
I want to build a Chat bot in a custom React application (public web site).
I have a few questions:

Is it possible to fully customize the web chat UI?
Is it possible to change the code of the chatbot in our application?
Is it possible to change the code of the web chat in order to call our APIs that will receive a prompt and generate a response?
Is it possible to change the Html and CSS?

If this is possible, can you provide links to documentation on how to do this?
Thanks

Hey @miguelisidoro! To answer your questions:

Yes, it is possible to customize the UI via style props or by targeting the CSS classes directly
This depends on what you're trying to do, but you can currently customize the bot with the available props to a great extent
You can definitely call your own APIs, there are live examples provided (which I'll link below)
Similar to point 1, yes!

The answer to all the above can be found at this documentation: https://react-chatbotify.tjtanjin.com. I also recommend trying out the playground and live examples on the website. Specifically for calling your own APIs or using LLMs, you can refer to the following examples:

https://react-chatbotify.tjtanjin.com/docs/examples/real_time_stream
https://react-chatbotify.tjtanjin.com/docs/examples/llm_conversation
https://react-chatbotify.tjtanjin.com/docs/examples/smart_conversation

Hi @tjtanjin ,
Thanks for the fast reply!
Can you send me the example where to build a minimable chat bot that opens when the user clicks on the call to action?
Thanks

Hi @tjtanjin ,
Thanks for the fast reply!
Can you send me the example where to build a minimable chat bot that opens when the user clicks on the call to action?
Thanks

If you look at the live examples, they all contain theme: {embedded: true} within the options prop. This is because the examples are embedded. If you want the chatbot to be minimized initially, you can simply set embedded to false or remove it entirely (defaults to false). You'll end up with the mini chatbot on the bottom right of the screen which you can see on the documentation website itself.
You can also remove the "Powered By React ChatBotify" text by modifying the text attribute within footer. The available options can be found here: https://react-chatbotify.tjtanjin.com/docs/api/bot_options

Hello @tjtanjin ,
Thanks once again for the fast reply, I will take a look at the links you sent!
Thanks

Hello @tjtanjin ,
Thanks once again for the fast reply, I will take a look at the links you sent!
Thanks

No problem, I'll close this issue for now but feel free to re-open it or reach out on discord if you need further assistance 😊

Hello @tjtanjin,
I am having some trouble testing one of your demos.
The error is the following:

The problem is that I don't have the index folder inside dist in the node_modules folder.

I tried using npm and pnpm and both give error. The commands I ran were:
npm install react-chatbotify
pnpm install react-chatbotify
Thanks

Can you share a little bit more of what you're using and how your project is setup? E.g. React version, CRA/vite?

Hello @tjtanjin,
The relevant of my packages.json:
"dependencies": {
"@remix-run/express": "^2.8.1",
"@remix-run/node": "^2.8.1",
"@remix-run/react": "^2.8.1",
"algoliasearch": "^4.20.0",
"compression": "^1.7.4",
"embla-carousel-autoplay": "^7.0.5",
"embla-carousel-class-names": "^7.0.5",
"embla-carousel-react": "^7.0.5",
"helmet": "^7.1.0",
"isbot": "^3.7.1",
"pnpm": "^9.5.0",
"react": "^18.2.0",
"react-chatbotify": "^1.7.0",
"react-dom": "^18.2.0",
"remix": "^2.8.1",
"remix-utils": "^7.6.0"
},
"devDependencies": {
"@mdx-js/rollup": "^3.0.1",
"@remix-run/dev": "^2.8.1",
"@remix-run/eslint-config": "^2.8.1",
"@remix-run/serve": "^2.8.1",
"@types/react": "^18.2.39",
"@types/react-dom": "^18.2.17",
"autoprefixer": "^10.4.16",
"concurrently": "^8.2.2",
"dotenv": "^16.3.1",
"eslint": "^8.54.0",
"postcss": "^8.4.31",
"remark-frontmatter": "^5.0.0",
"remark-mdx-frontmatter": "^4.0.0",
"tailwindcss": "^3.3.5",
"typescript": "^5.1.6",
"vite": "^5.1.5",
"vite-tsconfig-paths": "^4.3.1"
},
"engines": {
"node": ">=20"
}
Thanks

@miguelisidoro Could you provide in as much detail as possible the share the step-by-step instructions for reproducing this error?

Hello @tjtanjin,
We have a React based solution that uses Remix  and Vite. The node modules we are using are the ones included in packages.json. To reproduce the error we run npm run dev.
React component that is throwing the error has the following source code:
import { useRef } from 'react';
import ChatBot from 'react-chatbotify';
import type { CockyComponent } from '~/models/cocky,nodel';
import { setLayoutSwitch } from '~/utils/component-settings';
import { getLocaleFromPath } from '~/utils/locale';
const Bot = (props: BotComponent) => {
const refParent = useRef<HTMLDivElement | null>(null);
const settings = props.settings;
const layout = setLayoutSwitch('Bot', settings?.layout);
const locale = getLocaleFromPath(location.pathname);
let translate: { [key: string]: string };
switch (locale) {
case 'pt':
translate = {
newchat: 'Nova conversa'
};
break;
case 'es':
translate = {
newchat: 'Nueva conversación'
};
break;
default:
translate = {
newchat: 'New chat'
};
}
const BotChatBot = () => {
async function fetchData() {
try {
const response = await fetch('https://jsonplaceholder.typicode.com/todos/1')
const data = await response.json();
return data.title;
} catch (error) {
return 'Oh no I dont know what to say!';
}
}
let count = 0;
const flow={
start: {
message: 'Hey! I call an API!',
path: 'loop'
},
loop: {
message: async (params) => {
const result = await fetchData();
return result;
},
path: 'loop',
}
}
return (
<ChatBot options={{theme: {embedded: false}, chatHistory: {storageKey: 'example_smart_conversation'}}} flow={flow}/>
);
};
return (

);
};
Thanks
Thanks

Let's continue the discussion here


Vendoring update prior to 1.6 release

Mostly needed for summaries without quantiles. (There are a few that have useless quantiles right now.)
@stuartnelson3

Hmm, do you see what has broken Travis? I can't spot it in the logs.

Yeah I couldn't spot anything either

curl -s https://s3.amazonaws.com/archive.travis-ci.org/jobs/220912966/log.txt | grep -v level=info

...
time="2017-04-11T11:01:48Z" level=warning msg="Series quarantined." fingerprint=2ee1bef294b33c11 metric=test{n1="v3"} reason="size of series file for fingerprint 2ee1bef294b33c11 is 49, which is not a multiple of the chunk length 1041" source="storage.go:1880"
time="2017-04-11T11:01:59Z" level=warning msg="Storage has entered rushed mode." chunksToPersist=6 memoryChunks=852 source="storage.go:1842" urgencyScore=1
FAIL    github.com/prometheus/prometheus/storage/local  52.934s
...

I couldn't find a real test error message either.

Rerunning…

Tadaa!

:+1:


Added option to enable/disable exception tagging

I don't really like it's part of the interface. I believe this should be implementation specific.
Also, it should really be configurable, so a user should be able to provide i.e. Throwable => Set[Tag].


RabbitMQ HTTP Triggers ignore provided TLS Configuration

Report
When configuring a RabbitMQ Trigger with tls=enable and ca=x509cert in the assoicated TriggerAuthentication the provided CA certificate is ignored when the Trigger is in http mode.
This forces the use of unsafeSSL to connect to a TLS only RabbitMQ cluster.
Expected Behavior
Supplied TLS paramters (including CA only) shuold be used for both the HTTP and AMQP connection modes.
Actual Behavior
Trigger fails to active and Events on the ScalledObject and logs from Keda show tls: failed to verify certificate
Steps to Reproduce the Problem
apiVersion: v1
data:
  amqpUri: X==
  httpUri: X==
  tls: ZW5hYmxl
kind: Secret
metadata:
  name: abbitmq-user
  namespace: app
type: opaque

apiVersion: v1
kind: Secret
metadata:
  name: intermediate-ca
  namespace: app
type: kubernetes.io/tls
data:
  ca.crt: PEM Encoded Cluster CA Cert
  tls.crt: PEM Encoded Intermediate CA Cert
  tls.key: PEM Encoded Private

apiVersion: keda.sh/v1alpha1
kind: TriggerAuthentication
metadata:
  name: rabbitmq
  namespace: app
spec:
  secretTargetRef:
    - parameter: host
      name: rabbitmq-user
      key: httpUri
    - parameter: tls
      name: rabbitmq-user
      key: tls
    - parameter: ca
      name: app-intermediate-ca
      key: "ca.crt"

apiVersion: keda.sh/v1alpha1
kind: ScaledObject
metadata:
  name: app-component
spec:
  scaleTargetRef:
    name: app-component
  minReplicaCount: 0
  maxReplicaCount: 8
  fallback:
    failureThreshold: 3
    replicas: 2
  triggers:
  - type: rabbitmq
    metadata:
      protocol: http
      queueName: xxxx
      mode: QueueLength
      value: "20"
      vhostName: "xxxx"
    authenticationRef:
      name: rabbitmq
  - type: rabbitmq
    metadata:
      protocol: http
      queueName: xxxx
      mode: MessageRate
      value: "100"
      vhostName: "xxxx"
    authenticationRef:
      name: rabbitmq

Logs from KEDA operator
2024-04-09T04:25:32Z    ERROR   scale_handler   error getting scale decision    {"scaledObject.Namespace": "xxxx", "scaledObject.Name": "xxxx", "scaler": "rabbitMQScaler", "error": "error inspecting rabbitMQ: Get \"https://user:password@rabbitmq.rabbitmq.svc:15671/api/queues/xxxx/xxxx\": tls: failed to verify certificate: x509: certificate signed by unknown authority"}
github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).getScalerState
        /workspace/pkg/scaling/scale_handler.go:764
github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandl

KEDA Version
2.13.1
Kubernetes Version
1.29
Platform
Other
Scaler Details
RabbitMQ
Anything else?
No response

I've checked the code and you're totally right, the cert data is parsed but the HTTP client doesn't use it at all. Are you willing to open a PR fixing it?

Probably we should add here some logic like the logic we execute on other scalers, for example metrics api:
https://github.com/kedacore/keda/blob/e7ff90a7269373b0735716d6a6540a6cabbbbca0/pkg/scalers/metrics_api_scaler.go#L105-L113


Mage_Core_Exception: ResultUrl authentification failure

Magento version: 1938
Plugin version: latest
Description
We are seeing periodic cases of below in our logs. Maybe an exception but saw it now several times. Our ResultUrl is empty and setup with adyen support.
So I am uncertain what is the cause of this authentification failure
Mage_Core_Exception: ResultUrl authentification failure in app/Mage.php:595
Stack trace:
#0 app/code/community/Adyen/Payment/Model/ValidateResultUrl.php(72): Mage::throwException('ResultUrl authe...')
#1 app/code/community/Adyen/Payment/controllers/ProcessController.php(591): Adyen_Payment_Model_ValidateResultUrl->validateResponse(Array)
#2 app/code/community/Adyen/Payment/controllers/ProcessController.php(280): Adyen_Payment_ProcessController->validateResultUrl(Array)
#3 app/code/core/Mage/Core/Controller/Varien/Action.php(418): Adyen_Payment_ProcessController->successAction()
#4 app/code/core/Mage/Core/Controller/Varien/Router/Standard.php(254): Mage_Core_Controller_Varien_Action->dispatch('success')
#5 app/code/core/Mage/Core/Controller/Varien/Front.php(172): Mage_Core_Controller_Varien_Router_Standard->match(Object(Mage_Core_Controller_Request_Http))
#6 app/code/core/Mage/Core/Model/App.php(365): Mage_Core_Controller_Varien_Front->dispatch()
#7 app/Mage.php(683): Mage_Core_Model_App->run(Array)

Hi @seansan,
This could have many reasons.  Most common are wrong result url defined in the skin or the url is being hit in the browser without any parameters causing this error.
Regards,
Rik
Adyen


Repeat of past migrations

What steps will reproduce the problem?
I have some migrations before v2.0.10

Versions names are without namespaces.
What is the expected result?
When I added the new config for migrationNamespaces I see that my past migrations were not executed.

My configuration:
'controllerMap' => [
        'migrate' => [
            'class' => 'yii\console\controllers\MigrateController',
            'migrationNamespaces' => [
                'console\migrations',
                'usolutions\sms\migrations',
                //'lajax\translatemanager\migrations', // wait for namespace in module
            ],
            'migrationPath' => null, // allows to disable not namespaced migration completely
        ],
    ],

Migrations table:

Additional info

Q
A

Yii version
2.0.10

PHP version
5.6

Operating system
Linux

This is expected behavior. If migration has been applied without namespace in the past - it should remain to be without namespace.
You should manually adjust migration history to contain namespaced names if you wish o refactor migrations to namespace
.
This can be done using migrate mark command:

mark all migrations down
change config to use namespaces
add namespaces to migration source codes
mark all migrations up

OK, I understand
But, it turns out all of these actions are to be done by all the team members on the local machines. And then still have it all to do on servers.
Okay, it's not a problem if there are couple dozen migrations. But if there are hundreds or thousands - it will be a very long process, which can lead to errors.
Why can not we verify the version of migration without namespaces and with it?

@klimov-paul, for what reason are namespaces so important for migrations? Arent the base names not unique in 99,99% of the time. Or are we already takings migrations into account without the m000000_000000 formatting?

Namespaces are not mandatory: you can use both namespaced and non namespaced mogrations at the same time.
No one forces you to deal with those migrations, which are already in the history.
But if you want to drop non-namespaced migrations completely you'll have to deal with history records at all project copies - that is true.

@klimov-paul could you tell how I can create migration with namespaces in the extension?
vagrant@genesix:/app$ ./yii migrate/create NewMigrationWithNamespace -p=@usolutions/sms/migrations
Yii Migration Tool (based on Yii v2.0.10)

Create new migration '/app/vendor/U-Solutions/us-sms-module/migrations/m161104_095707_NewMigrationWithNamespace.php'? (yes|no) [no]:

If you wish to continue usage of non namespaced migrations you should NOT disable migrationPath in your config. However, in this case you should separate folders for namespaced and non-namespaced migrations, e.g. if migration namespace is app\migrations migration path should NOT refer to @app/migrations directory.

could you tell how I can create migration with namespaces in the extension?

You should specify full qualified class name as it is done in unit test:
https://github.com/yiisoft/yii2/blob/master/tests/framework/console/controllers/MigrateControllerTestTrait.php#L347-L356

You should specify full qualified class name as it is done in unit test:

thanks, but I can't figure out how to set a namespace
'migrate' => [
            // 'class' => 'yii\console\controllers\MigrateController',
            'class' => 'console\controllers\MigrateController',
            'migrationNamespaces' => [
                'usolutions\sms\migrations',
                'console\migrations',
            ],
            'migrationPath' => null, // allows to disable not namespaced migration completely
        ],

if my extension's namespace has array index 0 then all is fine
vagrant@genesix:/app$ ./yii migrate/create NewMigrationWithNamspace
Yii Migration Tool (based on Yii v2.0.10)

Create new migration '/app/vendor/U-Solutions/us-sms-module/migrations/M161104103223NewMigrationWithNamspace.php'? (yes|no) [no]:y

How can I set namespace if it has for example 1-st array index in the config?
'migrate' => [
            // 'class' => 'yii\console\controllers\MigrateController',
            'class' => 'console\controllers\MigrateController',
            'migrationNamespaces' => [
                'console\migrations',
                'usolutions\sms\migrations',
            ],
            'migrationPath' => null, // allows to disable not namespaced migration completely
        ],

I try:
vagrant@genesix:/app$ ./yii migrate/create usolutions\sms\migrations\NewMigrationWithNamspace
Yii Migration Tool (based on Yii v2.0.10)

Create new migration '/app/console/migrations/M161104105157UsolutionssmsmigrationsNewMigrationWithNamspace.php'? (yes|no) [no]:

or
vagrant@genesix:/app$ ./yii migrate/create NewMigrationWithNamspace -p=@usolutions/sms/migrations
Yii Migration Tool (based on Yii v2.0.10)

Create new migration '/app/vendor/U-Solutions/us-sms-module/migrations/m161104_104408_NewMigrationWithNamspace.php'? (yes|no) [no]:

or
vagrant@genesix:/app$ ./yii migrate/create usolutions\sms\migrations\NewMigrationWithNamspace -p=@usolutions/sms/migrations
Yii Migration Tool (based on Yii v2.0.10)

Create new migration '/app/vendor/U-Solutions/us-sms-module/migrations/m161104_104630_usolutionssmsmigrationsNewMigrationWithNamspace.php'? (yes|no) [no]:

and I get a file without namespaces or wrong folder (console\migrations)

You should proprly escape backslash (\) symbol for migration name parameter.
https://github.com/yiisoft/yii2/blob/master/framework/console/controllers/BaseMigrateController.php#L536-L542

Ohh! thanks a lot


Use updated distribution endpoint

This PR includes changes to use the updated distribution endpoint for filters in the subsetting tab. The updated endpoint is designed for performance, which is a requirement for subsetting.
One UX compromise is that we cannot do semantic zoom in this context. The front end must always provide range and binning info.
This depends on https://github.com/VEuPathDB/web-components/pull/165 for mouse selection in histograms to work correctly.

Note, I plan to merge several commits into one, so that we can easily revert to using the histogram and barplot plugins, if needed.

I'm not sure how you plan to do the latter, but sounds good.  I will review
now.
On Thu, Jul 15, 2021 at 4:00 PM Dave Falke @.***> wrote:

Note, I plan to merge several commits into one, so that we can easily
revert to using the histogram and barplot plugins, if needed.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/VEuPathDB/web-eda/pull/230#issuecomment-880766799,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACLLH5N74FAGMZJTCX4MM3TX3Z2RANCNFSM5ANXLOFQ
.

I think this is ready

Thanks, Bob. All good points. I will address as soon as I can.
On Thu, Jul 15, 2021 at 1:59 PM bobular @.***> wrote:

@.**** commented on this pull request.
HistogramFilter:
At the moment the year/month/week/day menu is showing up for non-date
variables. It would be nice to replace the "(month)" shown in the label
of BinWidthControl's SliderWidget with the dropdown menu. A bit of a fiddle
but maybe worth it?
Default slider range for date vars could be 1-60?
22,567 (100%) of 22,567 Participant have data for this variable seems to
have disappeared for HistogramFilter
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/VEuPathDB/web-eda/pull/230#pullrequestreview-707669849,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACZEU3DPRT47X54PUWTSRLTX4OYZANCNFSM5ANXLOFQ
.

I pushed commits to address these suggestions. See also the relevant commit in https://github.com/VEuPathDB/web-components/pull/165.

I’ll play with making them mandatory. I’m not sure they’ll be populated for
categorical number and date vars, so might require even more factoring.
On Thu, Jul 15, 2021 at 4:33 PM bobular @.***> wrote:

@.**** commented on this pull request.
In src/lib/core/components/filter/HistogramFilter.tsx
https://github.com/VEuPathDB/web-eda/pull/230#discussion_r670786290:

   independentAxisRange:

     variable.displayRangeMin != null && variable.displayRangeMax != null

     ? { min: variable.displayRangeMin, max: variable.displayRangeMax }

     : undefined,

     ? {

         min: variable.displayRangeMin + 'T00:00:00',

         max: variable.displayRangeMax + 'T00:00:00',

       }

     : {

         min: variable.rangeMin! + 'T00:00:00',

If variable.rangeMin is missing, 'T00:00:00' is likely to be an invalid
date for the back end.
See previous comment above.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/VEuPathDB/web-eda/pull/230#pullrequestreview-707794795,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACZEUZDDOS2ZLLEXZILFUDTX5A2FANCNFSM5ANXLOFQ
.

Here's a categorical number var from GEMS1 that does have rangeMin/Max, so
hopefully happy days (but not more than 7)!
{
"63": {
"id": "EUPATH_0010238",
"parentId": "EUPATH_0010016",
"providerLabel": "["F4A_DRH_DAYS"]",
"displayName": "Diarrheal episode duration",
"definition": "Assessed at enrollment for cases",
"vocabulary": [
"1",
"2",
"3",
"4",
"5",
"6",
"7"
],
"displayType": "default",
"displayOrder": 1,
"type": "number",
"dataShape": "categorical",
"units": "",
"precision": 0,
"rangeMin": 1,
"rangeMax": 7,
"binWidth": 0.3,
"distinctValuesCount": 7,
"isTemporal": false,
"isFeatured": false,
"isMergeKey": false,
"isMultiValued": false
}
}
On Thu, Jul 15, 2021 at 9:37 PM Dave Falke @.***> wrote:

I’ll play with making them mandatory. I’m not sure they’ll be populated for
categorical number and date vars, so might require even more factoring.
On Thu, Jul 15, 2021 at 4:33 PM bobular @.***> wrote:

@.**** commented on this pull request.
In src/lib/core/components/filter/HistogramFilter.tsx
https://github.com/VEuPathDB/web-eda/pull/230#discussion_r670786290:

independentAxisRange:
variable.displayRangeMin != null && variable.displayRangeMax != null

? { min: variable.displayRangeMin, max: variable.displayRangeMax }
: undefined,

? {
min: variable.displayRangeMin + 'T00:00:00',
max: variable.displayRangeMax + 'T00:00:00',
}
: {
min: variable.rangeMin! + 'T00:00:00',

If variable.rangeMin is missing, 'T00:00:00' is likely to be an invalid
date for the back end.
See previous comment above.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<
https://github.com/VEuPathDB/web-eda/pull/230#pullrequestreview-707794795
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AACZEUZDDOS2ZLLEXZILFUDTX5A2FANCNFSM5ANXLOFQ
.

—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/VEuPathDB/web-eda/pull/230#issuecomment-880996619,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACLLH3CDHRRLZ3FDZLMJSDTX5BG3ANCNFSM5ANXLOFQ
.

Shoot, I forgot to squash my commits! Hopefully we wont have to revert anything!

If we need to revert, I can just revert individual commits. It shouldn't be too bad, since they are colocated in this PR.

I also directly pushed this commit: https://github.com/VEuPathDB/web-eda/commit/9f4a72796d2594fbbc23232a4d0dd131fabf9063


[runtime] DemiBuffer Abstraction

This PR introduces the DemiBuffer abstraction.  The intent is to replace the Buffer enumeration (along with its DataBuffer and DpdkBuffer subtypes) with this new abstraction.
The motivation behind this is that the existing DataBuffer differed greatly from DpdkBuffer in its capabilities, making it difficult to present a uniform Buffer interface.   In particular, the DataBuffer implementation precluded adding some desired functionality to Buffer that is either already present in DPDK or is easy to add to DpdkBuffer.  Things like splitting buffers without copying any of the data, chaining buffers together to represent a packet, and queueing buffers using internal linkage fields (to avoid allocations).
More explanation of the DemiBuffer type is provided in the demibuffer.rs file comments.
Note that this PR just defines the new DemiBuffer type, it doesn't replace the current use of Buffer/DataBuffer/DpdkBuffer in the rest of the codebase.  That will be coming in a future PR.

@BrianZill please rename you commits to match the style:
[module-name] <Enhancement | Feature | Bug Fix | Workd Around>: <Small Comment Title>


nginx: add listen option

Issue description
I have a server that has multiple IPs. The HTTP/S server should be able to listen only on a specific IP. (Other ip must also be able to listen 80 or 443).
In a "normal" configuration I will add:
listen 195.154.xxx.xxx:80;
listen 195.154.xxx.xxx:443;

In the "modules/services/web-servers/nginx/default.nix" file ( https://github.com/NixOS/nixpkgs/blob/02129a8788423cb0b3dd4248c1ae342866d0d7ad/nixos/modules/services/web-servers/nginx/default.nix#L129 ) there is a section with a variable "listenString". This variable is not "overloadable" via the configuration.
Can we add a listen option that takes a list of ip to listen to? Example:
services.nginx.virtualHosts.<name>.listen = [ "192.xxx.xxx.xxx:80", "192.xxx.xxx.xxx:443 ..."]
Nginx doc : http://nginx.org/en/docs/http/ngx_http_core_module.html#listen

Because of .forceSSL the address and port have to be different variables. Something like this maybe could do it:
services.nginx.virtualHosts.<name>.listen = [
  { address = "192.xxx.xxx.xxx"; port = 80; }
  { address = "192.xxx.xxx.xxx"; port = 443; }
];

Ok, It's not so trivial. What should forceSSL do when there are multiple addresses and ports?

Fixed by #27403

Thanks


Is baseUri a URI or URL?

Jsoup.parse() defines baseUri as The URL where the HTML was retrieved from, to resolve relative links against.
Problem is, a file's URL and URI are not necessarily identical (URI parsing rules are more stringent). So, is this parameter really a URI? Or is it a URL?
If it's the former, I would replace URL by URI in the Javadoc.
If it's the latter, I would rename the parameter to baseUrl.
Or better yet, add a method that actually takes a URL or URI instead of a String.

@jhy No response?

Sorry, don't know what happened to my text. It's effectively interchangable
in this implementation. Haven't seen issues from it other than this one.
On Thu, Apr 2, 2015 at 7:39 PM, Gili Tzabari<EMAIL_ADDRESS>wrote:

@jhy https://github.com/jhy No response?
—
Reply to this email directly or view it on GitHub
https://github.com/jhy/jsoup/issues/453#issuecomment-89129962.


Android System Bar

Hi! Is there any way to make the system bar showing up when compiling with Android SDK 21 or higher! Thank you very much!

Hi, I think you should address this question into openfl forums instead.
Have you tried setting fullscreen to false on your project.xml?

Hi, I still did not know this email, I'm not familiar to GitHub :). Thanks
for your reply and your awesome extensions. These help me to save many times
However it's not a big issues :) I will try to set fullscreen mode to false
in my project.xml.
Anyway, thank you very much!
2016-06-01 21:31 GMT+07:00 Federico Bricker<EMAIL_ADDRESS>
Closed #23
https://github.com/SempaiGames/extension-googleplaygames/issues/23.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/SempaiGames/extension-googleplaygames/issues/23#event-678499400,
or mute the thread
https://github.com/notifications/unsubscribe/AR46C3G8BqNgh8eM0oh7jek0NDqV21u_ks5qHZfTgaJpZM4ITihZ
.


build: update build to use netlify deploy actions

Signed-off-by: Matt Hippely<EMAIL_ADDRESS>PR Type
What kind of change does this PR introduce?
Use an actionfrom the workplace to publish netlify previews and surfave the preview link to PR comments.

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[x] CI related changes
[ ] Documentation content changes
[ ] clarity.design website / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?
netlify will timeout intermitently during preview deploys.

Issue Number: N/A
What is the new behavior?
Preview deploy's that time out will be ignored and not cause a PR build to fail.

Not ready to merge yet, the NETLIFY_AUTH_TOKEN doesn't seem to be availaibe when opening a PR from my fork even though there is one for both repos on github. 🤔


can we get notification for the tasks creation ?

Hi @kevgliss  @mvilanova
I have created incidents for that Im getting slack notifiactions, later I have created tasks and attached to the incident which I have created earlier, I dont see any event notification for the tasks creation and attachment .
can you please let me know is this feature already available,  If not can you please add in your to-do list, it will be helpful for us, whenever new task get attached to the incident, in the parent incident slack group a task message has to be pop-up to notify people.

It looks like we weren't notifying for tasks created via the UI. Please see #3590 for the fix.

I'll also point out some caveats around these notifications:

Only triggered on state change (Open, Resolved)
Send as an ephemeral message to the assignee (not the whole channel)


tests: loading performance

garak should be fast until we're doing generation, probing, detection.
this means class instantiation should also be quick, and so loading has to be lazy
add a unit test that loads plugins and flags those loading "slowly"
slowly - 600ms?
performance is predicated on the test machine
if there are chunky imports that slow things down, then the test should fail, we want to know about this, we want to load lazier & let users move fast - garak should not be annoying to use

add speed test for the --list_generators / probes / detectors commands also


bump the devnet version to support 0.11 changes

The first step for this is available as PR #563  that bumps Devnet to the first available alpha version.
Probably makes sense to keep this issue open until the next official release is available and utilized.


Link on npmjs.com points to keystore-idb

Not sure if this is intentional or not

It is not! Assigning to @dholms to fix. Thanks!

@dholms I'll do this one, I'm doing the next release anyways.


Firebase is not defined in index.js

Everything has gone pretty smoothly, however I have some trouble displaying the Firebase data on the webpage.

This is the result I get, the Firebase reference works fine in app.js and pot.js.
My guess would be an issue with index.js.
app.zip

I've solved the issue by linking the newest angularfire version and using the new way to initialize firebase:
var config = {
apiKey: "",
authDomain: "arduino-cloud-implementatie.firebaseapp.com",
databaseURL: "https://arduino-cloud-implementatie.firebaseio.com",
storageBucket: "arduino-cloud-implementatie.appspot.com",
messagingSenderId: ""
};
firebase.initializeApp(config);
var firebaseRef = firebase.database().ref();
instead of
var firebaseRef = new Firebase(
// Replace this fictional URL with your own
"https://burning-limbo-6666.firebaseio.com/colors"
);
// create an AngularFire ref to the data
var sync = $firebase(firebaseRef);

Hi @Yentis. So this is resolved?

@Yentis would you like to make a pull request to update the code so others can benefit from your change?


Start 2FA process on an authenticated user

Hello,
Do you know if there is the posibility to start the 2FA process for the user that is already logged in?
Imagine that I'm in an SAP Gui application and I have two buttons, approve & reject, if user press approve I want to raise only the 2FA for the current user, previously that user was authenticated with OAUTH 2 agains azure aad.
Thanks & regards

Hi @JoseMunozHerrera
This issue looks like 2F Authentication for SAP Gui.  Not sure I understand correctly. if you are looking for SAP connectivity for Azure services. Please let us know.
Regards,
Vikas


Update living-documentation.md

Summary

Details

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue).
[ ] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

[ ] I've added tests for my code.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

@baic989 Hi! Thanks for working to improve Cucumber's documentation.
The efforts are currently focused on getting The Next Documentation Site up, and changes (and preview!) of those things go in a separate repository: https://github.com/cucumber/docs.cucumber.io/#cucumber-documentation
I hope you get a chance to check that out!
So, that's why changes to this repository's documentation will not be merged.


MSTest project failes to autogenerate assembly redirect

Description
MSTest project fails to autogenrate assembly redirect for certain included nuget packages
Steps to reproduce
Make sure to enable autogenerate
		<AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
		<GenerateBindingRedirectsOutputType>true</GenerateBindingRedirectsOutputType>

Add 2 nugets that have dependencies to each other that require assembly redirect, we use one from our internal nuget feed. Create a test using those refernces And you will get a file not found exception and the version of the dll is not the right one (it will try to use older version from one of the nugets). Check the .config in output folder and you can see there is no redirect for yoru assembly.
Expected behavior

Redirect present in .config
Program executes as expected

Actual behavior

Crashes with file not found IO exception (Using wrong assembly)

Environment
Windows 10 Enterprise 2004
Full framework 4.7
MSTest 2.1.2
MS Test runner (Works from resharper test runner)

Found problem, we used 15.9 of SDK upgraded to 16.8 and now it works!


allow markdown on index page, markdown=1 for article description

Generalization of #241 by @wooorm

Much better than my solution!

The test failure (edit link for the renamed file) is necessary, FWIW. It would go away if merged.

Closing this because @benbalter's suggestion is simpler.


Prep site for June election

https://github.com/OpenMaine/maineballot/wiki/Updating-Maine-Ballot-for-an-upcoming-election

[ ] Update the date in the elections.yml file in the _data folder to the next election date. On the homepage, change the text from the last election was to the next election is and change to the next election date.

[ ] If there are no statewide questions yet, put text in that section indicating "There aren't currently any statewide ballot questions on the [election month] ballot."

[ ] Archive local elections page using these instructions.

[ ] Check the Secretary of State's office for statewide ballot questions for the upcoming election.

[ ] If there aren't any yet, check Ballotpedia to see if they know of any upcoming questions.


buildOnTarget sidesteps TMPDIR setting for nix-daemon due to upstream issue

As noted in NixOS/nix#7154, colmena uses nix-store --realise for its builds when buildOnTarget = true.
This currently sidesteps TMPDIR settings for nix-daemon like these:
{
  systemd.services.nix-daemon.environment.TMPDIR = "/nix/tmp";
}

This is rather painful when forced to build a Linux kernel even on moderately sized machines.
As said this is an upstream issue really, however it would be really nice to have some sort of workaround in colmena for this (an extra flag maybe, I don't know), as I expect the upstream change to have BC implications and therefore take a while to discuss (not to mention the backlog).
I don't have a good workaround for this, my current solution is to set privilegeEscalationCommand = [], thereby disabling the sudo part for the build, however that's a manual step on every single deployment that requires a large build (i.e. custom Linux kernel).

I just realised, while thinking about a suitable implementation, that sudo is compatible with env in regards to syntax of environment variable passing, so I can just shove the TMPDIR= into the privilegeEscalationCommand, which solves the issue suitably well IMHO.


isValidNumber failing ?

Hi.
Im trying to use this package in a project but phoneUtil.isValidNumber(phoneNr); gives me TypeError: a.getCountryCodeOrDefault is not a function.
So for testing i tried it out in npm browser test site (link below) and it gave me the same error: https://tonicdev.com/npm/google-libphonenumber
Heres the copy paste code to test:

require("google-libphonenumber")
// Require `PhoneNumberFormat`.
var PNF = require('google-libphonenumber').PhoneNumberFormat;

// Get an instance of `PhoneNumberUtil`.
var phoneUtil = require('google-libphonenumber').PhoneNumberUtil.getInstance();

// Parse number with country code.
var phoneNumber = phoneUtil.parse('202-456-1414', 'US');

// Print number in the international format.
console.log(phoneUtil.format(phoneNumber, PNF.INTERNATIONAL));
// => +1<PHONE_NUMBER>

var phoneNr = {
 "country_code": 41,
 "national_number": 446681800
};
phoneUtil.isValidNumber(phoneNr);
The phoneUtil.format works but not phoneUtil.isValidNumber. I might be doing something wrong but i cant figure out what.
Do you guys get isValidNumber working?

Any second eye on this would be greatly appreciated. Maybe @ruimarinho if you got some time over?
Best regards,
kumpanen

I'm having a similar problem with isPossiblePhoneNumber:
var PhoneNumber = require('google-libphonenumber').PhoneNumberUtil.getInstance();
PhoneNumber.isPossibleNumber('5195665977');
TypeError: a.getNationalNumber is not a function
    at i18n.phonenumbers.PhoneNumberUtil.getNationalSignificantNumber (/Users/jamsea/git/HomeCareAPI/node_modules/google-libphonenumber/dist/libphonenumber.js:3886:18)
    at i18n.phonenumbers.PhoneNumberUtil.isPossibleNumberWithReason (/Users/jamsea/git/HomeCareAPI/node_modules/google-libphonenumber/dist/libphonenumber.js:4110:16)
    at i18n.phonenumbers.PhoneNumberUtil.isPossibleNumber (/Users/jamsea/git/HomeCareAPI/node_modules/google-libphonenumber/dist/libphonenumber.js:4100:15)
    at repl:1:35
    at REPLServer.defaultEval (repl.js:164:27)
    at bound (domain.js:250:14)
    at REPLServer.runBound [as eval] (domain.js:263:12)
    at REPLServer.<anonymous> (repl.js:393:12)
    at emitOne (events.js:82:20)
    at REPLServer.emit (events.js:169:7)

Going to try to downgrade the npm package, let me know if you ever found a workaround @kumpanen

@jamsea This function expects a PhoneNumber object, which you can get by using the following code:
var PhoneNumber = require('google-libphonenumber').PhoneNumberUtil.getInstance();
var number = PhoneNumber.parse('5195665977', 'US');
PhoneNumber.isPossibleNumber(number);

@kumpanen The following should work for you:
phoneUtil.isValidNumber(phoneNumber);

Like above, isValidNumber expects a PhoneNumber object, which you create with parse.

Yes you are right, i was missing the parse! The error message "TypeError: a.getCountryCodeOrDefault is not a function." led me completly wrong in my head.. Thanks alot @artlogic!

Sorry for the delay, getting back from vacation backlog ;) thanks for the help @artlogic!. Indeed, both methods expect an instance of i18n.phonenumbers.PhoneNumber which is a message in the Protocol Buffer format and usually obtained via parse or parseAndKeepRawInput.


Refactor workflow cbioportal_export

Suggested changes

[ ] All class names should use CapWords convention.

[ ] Method cbioportalExportStepPart.iterate_over_biomedsheets should be broken up to follow single-responsibility principle:

iterate_over_biomedsheets(): Responsible for yielding biomedsheets contents
cbioportalCnaFilesStepPart._get_input_file_gistic(): Responsible for input files for action 'gistic'
cbioportalCnaFilesStepPart._get_input_file_log2(): Responsible for input files for action 'log2'
cbioportalCnaFilesStepPart._get_input_file_segments(): Responsible for input files for action 'segments'
cbioportalZscoresStepPart._get_input_file_zscores_input(): Responsible for input files for action 'zscores_input'

Alternatively, iterate_over_biomedsheets could be run once in the workflow constructor, the information could be stored in a dictionary for instance. Examples from VariantExportWorkflow._build_ngs_library_to_kit(): code

[ ] In cbioportalExportStepPart.iterate_over_biomedsheets, both {mapper} and {tools} should be extracted from config instead of being hardcoded.
[ ] Targeted CNV vs. WGS CNV relation should be made explicit. Currently, it is  defined by tool listed in config. The step will mangle or omit CNV results if there is WES & WGS data in the project.

        if self.config["path_copy_number_step"]:
            if self.config["cnv_tool"] in ["cnvetti_on_target_postprocess", "copywriter"]:
                self.register_sub_workflow(
                    "somatic_targeted_seq_cnv_calling",
                    workdir=self.config["path_copy_number_step"],
                    sub_workflow_name="copy_number_step",
                )
            else:
                self.register_sub_workflow(
                    "somatic_wgs_cnv_calling",
                    workdir=self.config["path_copy_number_step"],
                    sub_workflow_name="copy_number_step",
                )

[ ] Snakemake file should be modified so all rules get their output and input from python part.
[ ] All rules in Snakemake should have a log file associated.
[ ] Merge rules with similar outputs (e.g., cbioportal_export_CNA_log2 and cbioportal_export_CNA_calls.
[ ] Consider merging rules that are simple shell calls (simple post/preprocessing?) - e.g.: cbioportal_export_concatenate_maf.

@ericblanc20  and @messersc, for future references - this issue.

Extracted from #156 :
Based on commit c46917387b3552c08113b6fab9e88e88c18c6ebf

[ ] Update cbioportal_export default config.
[ ] Fix wrapper snappy_wrappers/wrappers/cbioportal/case_lists/wrapper.py..
[ ] Fix wrapper snappy_wrappers/wrappers/cbioportal/meta_files/wrapper.py.
[ ] Fix wrapper snappy_wrappers/wrappers/vcf2maf/vcf2maf/wrapper.py.


[DO NOT MERGE] Pr 23587

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Seed Job

Run Python 3.10 PostCommit

Run Dataflow Python ValidatesContainer

Run Python Dataflow ValidatesContainer

Run Python_PVR_Flink PreCommit

stop reviewer notifications


Chrome desktop notifications trigger powertoys Run

Environment
Microsoft Windows [Version 10.0.18363.836]
PowerToys version: 0.18
PowerToy module for which you are reporting the bug (if applicable): Powertoys Run

Steps to reproduce
Clicking on desktop notifications from chrome triggers Run.
Checked on Chrome 81 and 83.
Simple repro: go to https://web-push-book.gauntface.com/demos/notification-examples/ enable notifications and click "Example notification". Then click on the notification.
Expected behavior
Clicking chrome notifications should not trigger Run action
Actual behavior
Run pops up

I'm not subscrived to this.

It doesn't trigger for me 🤷🏻♂

I can't reproduce this anymore, possibly since windows 2020 may update was installed.
Microsoft Windows [Version 10.0.19041.329]

Tested on 0.27.1, and Windows 20H2, can't repro.


Streaming MODMS-44

@adamdickmeiss While the parser works well and pass tests, there are failures when I try to use it in the upsertClusterRecords. If you have some hints regarding composing it withe the rest of the code -- it would be appreciated.

I'll do one real test with the client and a mio records to verify that performance hasn't gone down. Other than that it looks good.


Codeberg integration

Is there an existing issue or pull request for this?

[X] I have searched the existing issues and pull requests

Feature description
It would be nice to support https://codeberg.org alongside of GitHub, GitLab and Bitbucket.
Desired solution
Support Codeberg.
Example implementation: #663
Alternatives considered
None.
Additional context
No response

done in #680


history compatibility issue

An issue very much like #475 occurs with updates to react-router 4
    "react-redux": "^5.0.3",
    "react-router": "^4.0.0",
    "react-router-redux": "4.0.7",
    "redux": "^3.6.0",

As a workaround, I rolled back to 3.0.2, and the issue
    "react-redux": "^4.4.5",
    "react-router": "^3.0.2",
    "react-router-redux": "4.0.8",
    "redux": "^3.6.0",

TypeError: Cannot read property 'pathname' of undefined
    at new Router (Router.js:30)
    at ReactCompositeComponent.js:295
    at measureLifeCyclePerf (ReactCompositeComponent.js:75)
    at ReactCompositeComponentWrapper._constructComponentWithoutOwner (ReactCompositeComponent.js:294)
    at ReactCompositeComponentWrapper._constructComponent (ReactCompositeComponent.js:280)
    at ReactCompositeComponentWrapper.mountComponent (ReactCompositeComponent.js:188)
    at Object.mountComponent (ReactReconciler.js:46)
    at ReactDOMComponent.mountChildren (ReactMultiChild.js:238)
    at ReactDOMComponent._createInitialChildren (ReactDOMComponent.js:697)
    at ReactDOMComponent.mountComponent (ReactDOMComponent.js:516)

import createHistory from 'history/lib/createBrowserHistory';
// ...
const browserHistory = createHistory();
// ...
const RouterApp = props => (
  <Provider {...props} store={store()}>
    <Router
      history={browserHistory}
      routes={routes}
    />
  </Provider>
);

This library doesn't support React Router or history 4.0. Please see the top of the README.


[Translation] "Volume" should be translated to "体积" in zh-CN

This is a fixed bug in base repository. The translation here
https://github.com/nventive/calculator/blob/06db7b853f77ded48b1cfa47cbabe63b11c44cc4/src/Calculator.Shared/Resources/zh-CN/Resources.resw#L1110
should be changed to 体积 in base repo.

I also added some other changes in this resource file which i think it should update. Refer PR => #206


Modal over modal scroll problem

Opening a modal over another modal works excellent. But closing the closest returning to the modal behind messes up the page scrolling.
See video. Google .webm media can be played in VLC.
scroll_problem.zip

Sorry, not supported by this plugin.
See: https://github.com/twbs/bootstrap/issues/15837
From bootstrap docs:

Multiple open modals not supported
Be sure not to open a modal while another is still visible. Showing more than one modal at a time requires custom code.

I believe there are other bootstrap plugins that will let you do this.

I was afraid of that but Google was not my friend. If you are available for hiring let me know. One work around could be to simply automatically close an existing modal upon starting a new.

This has stacking: http://jschr.github.io/bootstrap-modal/

Thanks, this is very helpful as it saves me a lot of time. :)


Issue222/nvidia unit test

Checklist
This checklist is used to make sure that common guidelines for a pull request are followed.

[X] I have read the contribution guidelines.
[X] Title of the pull request is clear and informative.
[X] If applicable, the code is properly documented.
[X] The code builds without any errors.
[X] All unit and integration tests pass.

Description
Fixes #222 with a unit test for the nvidia GPU and driver. Does not fix #234 which is a separate issue.
Related Issues and PRs
#222 is the issue resolved.

@KanishkT123 There seems a lot of commits for adding one unit test. Can you please rebase to make it look nicer?

Moved this to #236 because it was easier than actually doing the rebase (Git found conflicts with every single file because of a weird whitespace issue)


update the install with python 3.11 and test

update
https://github.com/mamba-org/mamba
https://mamba.readthedocs.io/en/latest/index.html
this works for arm64 anaconda fails with core dump

https://www.python.org/downloads/release/python-3110/
sudo apt install libssl-dev libncurses5-dev libsqlite3-dev libreadline-dev libtk8.6 libgdm-dev libdb4o-cil-dev libpcap-dev
./configure twice with optimizes flags
sudo make altinstall -j 3

have python condaforge and mamba install
https://github.com/conda-forge/miniforge#mambaforge
run sh for install
https://mamba.readthedocs.io/en/latest/installation.html
use conda to install mamba
conda install mamba -n base -c conda-forge


Efficiently and correctly Extract Page Index statistics into ArrayRefs

Is your feature request related to a problem or challenge?
Related to https://github.com/apache/datafusion/issues/10453
There are at least two types of statistics stored in Parquet files

ColumnChunk level statistics (a min/max/null_count per column per row group): RowGroupMetadata --> ColumnChunkMetaData --> Option<&Statistics>
"Page Index" statistics (stored per page, may be more than one page per column per row group): ColumnChunkMetaData --> read_columns_indexes --> Vec<Index>

As part of  https://github.com/apache/datafusion/issues/10453 we have pulled conversion of the ColumnChunk level statistics into StatisticsConverter and https://github.com/apache/datafusion/pull/10802 prunes the row groups using this API
It would be good to apply the same treatment to the statistics in the page index
Describe the solution you'd like

Add a clear API to efficiently extract page statistics outside of DataFusion
Ensure that API is well tested
Ensure the API is fast

Describe alternatives you've considered

Move / refactor the code to extract ArrayRef from Index in page_filter (source link) to StatisticsConverter (source)
Update the tests in arrow_statistics  (source) to also verify that the page statistics are correct (I believe the page min/maxes should be the same as the row group min/maxes)
Update the parquet code prune_pages_in_one_row_group (source) to use the new StatisticsExtractor code
Update the benchmark (source) for extracting page statistics and use that to ensure the statistics extraction code is reasonably performant

Additional context
No response

@alamb
I was briefly looking at this, trying to understand whats needed here (since I'm very unfamiliar here).
Do we already have a helper fn at place to write a parquet file with Page Index statistics? While I was "prototyping" I tried to get the metadata.column_index() by using the existing make_test_file_rg - but it seems page index stats are not written (None)?
I'll keep on looking - but perhaps you have a quick pointer here, where to look?

Thanks @marvinlanhenke 🙏
To write the relevant structues into Parquet, the statistics_enable field needs to be Page
To read them back, the reader needs to be configured with with_page_index I think
Also I have a proposed change to the Statistics code in https://github.com/apache/datafusion/pull/10802
If that gets merged, then the API for extracting the mins from data pages might look like
        // get relevant index statistics somehow
        let data_page_statatistics: Vec<&Statistics> = todo!();
        let converter = StatisticsConverter::try_new(
            column_name,
            reader.schema(),
            reader.parquet_schema(),
        );
        // get mins from the ColumnIndex
        let mins = converter.column_index_mins(data_page_statatistics).unwrap();

The proposed Api looks nice 👌Until the merge I can use the time to explore and prototype. Thanks for the pointers

@alamb
...while prototyping I ran into an "issue" or some questions, perhaps you can help here.
Since we could have more than one page per column per row-group, I implemented the e.g. min statistics as an Iterator to yield the global minimum across all pages. First of all does this even make sense here?
impl<'a, I> Iterator for MinInt64PageStatsIterator<'a, I>
where
    I: Iterator<Item = Option<&'a Index>>,
{
    type Item = Option<i64>;
    fn next(&mut self) -> Option<Self::Item> {
        let next = self.iter.next();
        next.flatten().map(|index| match index {
            Index::INT64(native_idx) => native_idx
                .indexes
                .iter()
                .flat_map(|page_idx| page_idx.min)
                .min(),
            _ => None,
        })
    }

    fn size_hint(&self) -> (usize, Option<usize>) {
        self.iter.size_hint()
    }
}

If it does make sense to "coalesce" into a global page minimum, I'll run into trouble later on when I create those iterators for f32, f64 since the trait Ord is not implemented. We could workaround this by using reduce(f32::min) - but I want to check if I'm on the right track at all - or perhaps I should coalesce the page minimum into a global?

@alamb
...just to confirm my current understanding.
Since we can have more than one page per column per row group, I can get multiple statistics. Or put differently one ArrayRef per Page.
For example if we have a column A with row_group R1 and Pages P1 & P2, I would retrieve statistics for P1 & P2?

A.R1.P1 {min: Some(2), max: Some(5), ...}
A.R1.P2 {min: Some(1), max: Some(4), ...}

Thus, instead of extracting a single Result<ArrayRef> in the StatisticsExtractor we should return a Result<Vec<ArrayRef>>?
I think we have to do this, in order to use the new API within prune_pages_in_one_row_group which creates an Vec when pruning against the predicate here?

@alamb
I'm currently thinking about how to integrate StatisticsConverter with the existing code prune_pages_in_one_row_group.
This is what I originally had in mind for the converter method:
    pub fn column_index_mins(&self, metadata: &ParquetMetaData) -> Result<ArrayRef> {
        let data_type = self.arrow_field.data_type();

        let Some(parquet_column_index) = metadata.column_index() else {
            return Ok(self.make_null_array(data_type, metadata.row_groups()));
        };

        let Some(parquet_index) = self.parquet_index else {
            return Ok(self.make_null_array(data_type, metadata.row_groups()));
        };

        let row_group_page_indices = parquet_column_index
            .into_iter()
            .map(|x| x.get(parquet_index));
        min_page_statistics(Some(data_type), row_group_page_indices)
    }

So we would simply create an iterator for all row groups column indices, match the index and apply the stats_func. Which works - all tests are passing.
However, the API, or the integration with prune_pages_in_one_row_group feels kind of strange:

a lot of work the StatisticConverter does is already done here
we already iterate over each row_group individually, extracting a single Option<&Index> here and passing it into prune_pages_per_one_row_group

Now, my API has to change. I'm wondering how specific it should be?
If we pass &Index as a parameter, I can match the index and extract the statistic as done here. However, I'm not sure this is the way to go. We'd simply move the get_min_max_values_for_page_index method, and basically have no need for the StatisticConverter?
Maybe I'm missing something, but I think it would help to maybe outline the scope of the refactor you had in mind.

Thank you @marvinlanhenke -- excellent analysis.

a lot of work the StatisticConverter does is already done here

Yes. It is my eventual goal for all of the code to convert Index to ArrayRef in page_filter.rs is gone and page_filter.rs only calls StatisticsConverter.
To avoid a massive PR, however, I think it makes sense to add new code to StatisticsConverter for extracting page values, and then when it is complete enough switch page_filter.rs to use StatisticsConverter

we already iterate over each row_group individually, extracting a single Option<&Index> here and passing it into prune_pages_per_one_row_group

Indeed that is how it works today (one row group at a time). I eventually hope/plan to apply the same treatment to data page filtering as I did to row group filtering in https://github.com/apache/datafusion/pull/10802 (that is, make a single call to PruningPredicate::prune for the all the remaining row groups.

Now, my API has to change. I'm wondering how specific it should be? If we pass &Index as a parameter, I can match the index and extract the statistic as done here. However, I'm not sure this is the way to go. We'd simply move the get_min_max_values_for_page_index method, and basically have no need for the StatisticConverter?

let me play around with some options and get back to you

@marvinlanhenke  -- I whipped up something (actually I had been playing with it yesterday) https://github.com/apache/datafusion/pull/10843

Thank you so much - I quickly skimmed the draft you uploaded (will take a closer look tomorrow). However, the main question should be answered, for now we are iterating over each row group one by one using a row group index.
I also agree about the scope for now, however can see the overall picture where this is going somewhat clearer now, so thanks for explaining that.
I'll try to incorporate your suggestions and upload a draft myself, so we have something more concrete to reason about.

Follow on work tracked in https://github.com/apache/datafusion/issues/10922


Jav 107 configurable loading mode

@wujimin

Changes Unknown when pulling 318634250ac08ec59eeff401359d1cd6159f6fbd on JAV-107_configurable_loading_mode into ** on master**.

Coverage decreased (-0.08%) to 82.025% when pulling d420d557804906b74bfa899877fc3edf0217c14e on JAV-107_configurable_loading_mode into 24e09f2c00ae2b04750d33092041f9f86b94aa3a on master.


LIBS-264

Pull Request Test Coverage Report for Build 62

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 16.667%

Totals

Change from base Build 10:
0.0%

Covered Lines:
7

Relevant Lines:
42

💛  - Coveralls


As one element to make two different animation style one?

Hi! Faced with the problem of implementation of the toggle:
http://codepen.io/maxrazon/pen/rLRVOJ

In this case the animations will be different on each click, depending of the current state of the navbar.
You should call anime directly instead of storing the animations in variables.
Also use anime.remove() before animating an already animated element to prevent overlap in animations.
I fixed your example here: http://codepen.io/juliangarnier/pen/xOZQbN

Thank you very much!


fix local variables undefined error

Remove  start . Only one place use that variable. I do not think we need a separate variable
ret is used in two place :

Wrap with MBEDTLS_SSL_RENEGOTIATION
Wrap with MBEDTLS_SSL_RENEGOTIATION and defined(MBEDTLS_SSL_PROTO_TLS1) || defined(MBEDTLS_SSL_PROTO_TLS1_1) || defined(MBEDTLS_SSL_PROTO_TLS1_2)

Add MBEDTLS_SSL_RENEGOTIATION and defined(MBEDTLS_SSL_PROTO_TLS1) || defined(MBEDTLS_SSL_PROTO_TLS1_1) || defined(MBEDTLS_SSL_PROTO_TLS1_2)  condition to fix ret issue

Unclear about the removal of one guard.
Specifically, it's not clear if it's not other ticket-related code using start that requires a guard by MBEDTLS_SSL_SESSION_TICKETS, rather than removing that guard for the declaration of start.
Can you take a look at how the use of session tickets is guarded in TLS 1.3? I don't see a reason a priori not to reuse MBEDTLS_SSL_SESSION_TICKETS.

Done. I remove start that might be better choice.


owncloud sql storage driver support for cache

Is your feature request related to a problem? Please describe.
For the oC 10 to oCIS migration Stage 6 we need to share ALL state with each other. Currently the database is already used by both oC10 and the oCIS owncloud sql storage driver. But if you use Redis or Memchached with oC10, it will not be used by oCIS at the moment.
Describe the solution you'd like
The oCIS owncloud sql storage driver also uses Redis or Memcached when available.
Additional context
Add any other context or screenshots about the feature request here.

@pmaier1 @micbar is that relevant for GA?

I'd need to understand the consequences here to make a decision. Afaik Redis stores transactional file locks and sessions. What are the implications of doing / not doing it?

I'd need to understand the consequences here to make a decision. Afaik Redis stores transactional file locks and sessions. What are the implications of doing / not doing it?

@butonic can you answer that?

@wkloucek @pmaier
IMO this is nothing before beta.

I am running the owncloudsql driver on my personal instance. in parallel. while it is single node it works. I don't need a cache. I just need it working until i migrated to another backend. Something that I think is relevant and sufficient for all small oc10 instances out there.

closing because currently not a focus item


VS Code stops responding to any keystroke after switching windows user and switching back

Type: Bug

Create a text file with any filename and open it. (You must name and save it. A new file named "untitled" won't reproduce the bug.)
Switch to another windows user. Do some random mouse clicks (must) before switching back.
Back to the original windows user. Then type in the text file. No characters appear in the file. VS Code does not respond to your typing.

More details:

My problem is 100% reproducible, not intermittently.
Switching to another app and back doesn't fix the problem.
When my problem occurs, VS Code doesn't accept any keyboard input, including letters, directions, backspaces, spaces, or returns.
You don't need a fast computer to trigger any race condition.
--disable-features=CalculateNativeWinOcclusion can't fix my problem.
When just returning from another Windows user or app, VS Code can respond to the mouse but not the keyboard. But after any keystrokes, VS Code doesn't even respond to the mouse anymore. The difference is that this kind of unresponsiveness to the mouse can be fixed by switching applications and then returning.
(Update 20220803) This issue won't reproduce with DevTools window open. You must keep DevTools closed to reproduce it.
(Update 20220803) This is not reproduceable on the web version of VS Code.

My problem is 100% reproducible, not intermittently.
Switching to another app and back doesn't fix the problem.
When my problem occurs, VS Code doesn't accept any keyboard input, including letters, directions, backspaces, spaces, or returns.
You don't need a fast computer to trigger any race condition.
--disable-features=CalculateNativeWinOcclusion can't fix my problem.

Does this still happen with latest insiders https://code.visualstudio.com/insiders/ ?

Does this still happen with latest insiders https://code.visualstudio.com/insiders/ ?

Yes. Still happens. Not fixed.

Unable to repro with the steps provided on Windows 11 Build 22621, closing as not actionable.


Provide silence backup and restore functionality in amtool cli tool

Since amtool is setup for querying and managing silences it would be great if you could perhaps dump the json output to a file and load it back into the api.
This would be useful when attempting to migrate existing silences to another instance or in the event of disaster recovery.

I think it should be reasonably easy to just dump the json received from the api and do some slight munging to re-apply it.


Some translation fixes for de-DE.lang

I fixed some errors and a few (possibly subjective) issues with phrasing.
Sorry about the trailing newline. It's GitHub's fault.

I tried to remove the newline, but it's readded automatically. I'll discard that other commit.

Ok. I'll try to merge the commits now.

That fixed (almost) everything. Requesting a merge now 👍


Multi Threading

When commands are executed the bot stutter, I have yet to test out if the bot can play on two servers at the same time too. I am guessing it won't work flawlessly and am guessing everything runs on the same thread. To prevent this issue then I would need something like multi threading having the playing music for each server on a different thread than the command handler.

Troubleshooting / optimization Guide from discordjs could solve this. Especially the highWaterMark could solve this need to do some testing.
https://v12.discordjs.guide/voice/optimisation-and-troubleshooting.html

HighWaterMark cannot be used due to the npm package currently in use, would need to either edit it, implement my own way to play music or find another package, as this is a minor issue for now it will be seen as low priority.


Update DBT docs

docs.open-metadata.org/sdk/python/ingestion/dbt#parsing-the-dbt-files
we are pointing to an old module

@OnkarVO7 can you double check and close it out

@harshach  checking this


In semi-transparent themes , tilerendering Colors the Tile area and Lines area , differently from the atom-editor.

In transparent themes , tile rendering applies colors differently. Observable in my theme :

If it is not a bug , what would be recommended way for theme developers to theme those tiles ?

Hey @v3ss0n! Would you mind updating this issue with the recent conversation we had on Slack?
Not sure if that actually solved your problem, but it would be nice to include the gist of it here for posterity.
Thank you! :pray:

I am still trying to make it so , color looks uniform between tiles and background.
So far , Setting transparent is only way working properly .