iOS crash

Hello, Team Flutter!.
I have a task to hide content in a trey, I chose a radical method, I do the following
override func applicationWillResignActive(_ application: UIApplication) {
        self.window.isHidden = true
    }

    override func applicationDidBecomeActive(_ application: UIApplication) {
        self.window.isHidden = false
    }

this code work, but if the textFormField is on the screen or appears, the application crashes, if tap on textFormField(keyboardShow) =>
019-01-03 23:01:14.433808+0300 Runner[30531:8999397] *** Assertion failure in -[FlutterTextInputPlugin showTextInput], ../../flutter/shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm:703
2019-01-03 23:01:14.556435+0300 Runner[30531:8999397]
*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'The application must have a key window since the keyboard client must be part of the responder chain to function'
*** First throw call stack:
(
	0   CoreFoundation                      0x000000010d16b1bb __exceptionPreprocess + 331
	1   libobjc.A.dylib                     0x000000010c709735 objc_exception_throw + 48
	2   CoreFoundation                      0x000000010d16af42 +[NSException raise:format:arguments:] + 98
	3   Foundation                          0x000000010c10c877 -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:] + 194
	4   Flutter                             0x000000010a924dec -[FlutterTextInputPlugin showTextInput] + 298
	5   Flutter                             0x000000010a924bda -[FlutterTextInputPlugin handleMethodCall:result:] + 149
	6   Flutter                             0x000000010a9137fa __45-[FlutterMethodChannel setMethodCallHandler:]_block_invoke + 115
	7   Flutter                             0x000000010a92fdc8 _ZNK5shell21PlatformMessageRouter21HandlePlatformMessageEN3fml6RefPtrIN5blink15PlatformMessageEEE + 166
	8   Flutter                             0x000000010a9337b8 _ZN5shell15PlatformViewIOS21HandlePlatformMessageEN3fml6RefPtrIN5blink15PlatformMessageEEE + 38
	9   Flutter                             0x000000010a983d7d _ZNSt3__110__function6__funcIZN5shell5Shell29OnEngineHandlePlatformMessageEN3fml6RefPtrIN5blink15PlatformMessageEEEE4$_26NS_9allocatorIS9_EEFvvEEclEv + 57
	10  Flutter                             0x000000010a93f13e _ZN3fml15MessageLoopImpl15RunExpiredTasksEv + 522
	11  Flutter                             0x000000010a9424bc _ZN3fml17MessageLoopDarwin11OnTimerFireEP16__CFRunLoopTimerPS0_ + 26
	12  CoreFoundation                      0x000000010d0d0f34 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 20
	13  CoreFoundation                      0x000000010d0d0b32 __CFRunLoopDoTimer + 1026
	14  CoreFoundation                      0x000000010d0d039a __CFRunLoopDoTimers + 266
	15  CoreFoundation                      0x000000010d0caa1c __CFRunLoopRun + 2252
	16  CoreFoundation                      0x000000010d0c9e11 CFRunLoopRunSpecific + 625
	17  GraphicsServices                    0x000000011196d1dd GSEventRunModal + 62
	18  UIKitCore                           0x0000000116c5b81d UIApplicationMain + 140
	19  Runner                              0x000000010a613314 main + 68
	20  libdyld.dylib                       0x0000000110bd9575 start + 1
	21  ???                                 0x0000000000000001 0x0 + 1
)
libc++abi.dylib: terminating with uncaught exception of type NSException
(lldb)

flutter doctor -v
[✓] Flutter (Channel master, v1.1.6-pre.11, on Mac OS X 10.14.2 18C54, locale ru-RU)
    • Flutter version 1.1.6-pre.11 at /Users/alexfix/Flutter/flutter
    • Framework revision 53727866e6 (15 hours ago), 2019-01-03 12:05:53 +0700
    • Engine revision 844c3274e6
    • Dart version 2.1.1 (build 2.1.1-dev.0.1 88e6fe0f67)

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/alexfix/Library/Android/sdk
    • Android NDK at /Users/alexfix/Library/Android/sdk/ndk-bundle
    • Platform android-28, build-tools 28.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)
    • All Android licenses accepted.

[✓] iOS toolchain - develop for iOS devices (Xcode 10.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.1, Build version 10B61
    • ios-deploy 2.0.0
    • CocoaPods version 1.5.3

[✓] Android Studio (version 3.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 31.3.1
    • Dart plugin version 181.5656
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)

Are you adding Flutter to an existing project?

Are you adding Flutter to an existing iOS project?

No, this is a new project created with plugin 'flutter' in Android Studio with Swift / Kotlin support.

Can you create a minimal sample project which can reproduce this problem?
@1AlexFix1

Can you create a minimal sample project which can reproduce this problem?
@1AlexFix1

it is reproduced quite easily. Create a new project with this code.
main.dart
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        body: Center(
          child: TextFormField(),
        ),
      ),
    );
  }
}

AppDelegate.swift
import UIKit
import Flutter

@UIApplicationMain
@objc class AppDelegate: FlutterAppDelegate {
  override func application(
    _ application: UIApplication,
    didFinishLaunchingWithOptions launchOptions: [UIApplicationLaunchOptionsKey: Any]?
  ) -> Bool {
    GeneratedPluginRegistrant.register(with: self)
    return super.application(application, didFinishLaunchingWithOptions: launchOptions)
  }

  override func applicationWillResignActive(_ application: UIApplication) {
          self.window.isHidden = true
      }

      override func applicationDidBecomeActive(_ application: UIApplication) {
          self.window.isHidden = false
      }

}

run app
go in tray (app status = paused)
return app
tap on textFormField => app crash

Fail to reproduce this issue:

[✓] Flutter (Channel master, v1.1.6-pre.25, on Mac OS X 10.14.3 18D32a, locale
en-CN)
• Flutter version 1.1.6-pre.25 at
/Users/kylewong/Codes/Flutter/alibaba-flutter/flutter
• Framework revision caf6027d81 (3 hours ago), 2019-01-04 05:38:28 -0500
• Engine revision 83239e141b
• Dart version 2.1.1 (build 2.1.1-dev.0.1 ec86471ccc)
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
• Android SDK at /Users/kylewong/Library/Android/sdk
• Android NDK at /Users/kylewong/Library/Android/sdk/ndk-bundle
• Platform android-28, build-tools 28.0.3
• Java binary at: /Applications/Android
Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build
1.8.0_152-release-1136-b06)
• All Android licenses accepted.
[!] iOS toolchain - develop for iOS devices (Xcode 10.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 10.1, Build version 10B61
✗ Verify that all connected devices have been paired with this computer in
Xcode.
If all devices have been paired, libimobiledevice and ideviceinstaller may
require updating.
To update with Brew, run:
brew update
brew uninstall --ignore-dependencies libimobiledevice
brew uninstall --ignore-dependencies usbmuxd
brew install --HEAD usbmuxd
brew unlink usbmuxd
brew link usbmuxd
brew install --HEAD libimobiledevice
brew install ideviceinstaller
• ios-deploy 1.9.4
! CocoaPods out of date (1.5.0 is recommended).
CocoaPods is used to retrieve the iOS platform side's plugin code that
responds to your plugin usage on the Dart side.
Without resolving iOS dependencies with CocoaPods, plugins will not work
on iOS.
For more info, see https://flutter.io/platform-plugins
To upgrade:
brew upgrade cocoapods
pod setup
[✓] Android Studio (version 3.2)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 31.3.1
• Dart plugin version 181.5656
• Java version OpenJDK Runtime Environment (build
1.8.0_152-release-1136-b06)
@1AlexFix1

I reinstalled the sdk flutter, took the project from the flutter folder / example /hello word added code to the object with
#include "AppDelegate.h"
#include "GeneratedPluginRegistrant.h"

@implementation AppDelegate

- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions {
  [GeneratedPluginRegistrant registerWithRegistry:self];
  // Override point for customization after application launch.
  return [super application:application didFinishLaunchingWithOptions:launchOptions];
}

- (void)applicationWillResignActive:(UIApplication *)application {
    self.window.hidden = YES;
}

- (void)applicationDidBecomeActive:(UIApplication *)application {
    self.window.hidden = NO;
}

@end

main.dart change to
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
	@override
	Widget build(BuildContext context) {
		return MaterialApp(
			home: Scaffold(
				body: Center(
					child: TextFormField(),
				),
			),
		);
	}

the effect is the same, the application falls

@1AlexFix1
Reproduced, thanks, I'll have a look at it soon.

@1AlexFix1
It's your custom code causing the crash.
- (void)applicationWillResignActive:(UIApplication *)application{
    [self.window resignKeyWindow];
    self.window.hidden = true;
}

- (void)applicationDidBecomeActive:(UIApplication *)application{
    [self.window makeKeyAndVisible];
    self.window.hidden = false;
}

This works fine.
Closing the issue.

@1AlexFix1
It's your custom code causing the crash.
- (void)applicationWillResignActive:(UIApplication *)application{
    [self.window resignKeyWindow];
    self.window.hidden = true;
}

- (void)applicationDidBecomeActive:(UIApplication *)application{
    [self.window makeKeyAndVisible];
    self.window.hidden = false;
}

This works fine.
Closing the issue.

thanks

Mine is doing the same thing with this code (swift) is there something I need to change - I was given this code by another user which knows swift...
`
override func applicationWillResignActive(_ application: UIApplication) {
self.window.isHidden = true
}
override func applicationDidBecomeActive(_ application: UIApplication) {
self.window.isHidden = false
}
`

+1 had the same issue after updating flutter version

@kangwang1988  can you please provide reason why @1AlexFix1 code is not working? I have same issu using swift. Thank you!

@digibum
As this issue is too old, I would recommend you to file a new issue, including a reproducible demo.
Thx

To fix this issue, use
self.window.endEditing(true)  before hiding the window. This way keyboard will close before text field gets hidden, and there won't be any crash.


mock-code: add 'ignore_paths' argument

fixes #44
The ignore_files parameter of the mock-code fixture allows ignoring
files only based on their filename, but not based on their path in the
the run directory
This does not cover the use case when a code creates a subfolder
structure and one would like to ignore all files in certain subfolders.

@greschd Not sure whether you noticed the review request (if yes, no problem - it's not urgent)

Yep, just didn't get around to it yet :)


feat: Allow toggling autoclose

Summary

Adds a command to allow toggling autoclose on the fly.
Also gives autoclose the ability to close multiple buffers, to the point where we reach the open buffer threshold or exhaust closeable buffers. This is necessitated by the ability
to toggle autoclose.

Note
Please review #2 before this PR.

Since I rebased your other pr on top of main those 2 commits got rehashed. Just delete them and force push to get rid of conflicts.
Could you also update the README.md to mention the new toggle_autoclose command?

Looks great! @al-ce do you wanna take a look? I think it touches some of your code.

Looks great! @al-ce do you wanna take a look? I think it touches some of your code.

Great PR! I tested it real quick for the sake of an extra eye, works well and I can't find any issues on a quick test. Don't know that I have anything more constructive to add so I'll just comment from a user perspective. The pin commands work as I would expect as when autoclosing is toggled off and then are toggled back on. I very much like the feature to prevent visible windows from being auto closed.
I don't want this to hold up the  deployment but maybe in a future commit you could explain in the README why a user might want to customize the close_command. I can think of some creative use cases but maybe not what was intended for allowing this new option. Thanks for the new features @ditsuke !

Do you wanna rebase anyhting? Otherwise, I'll just merge it as is

Do you wanna rebase anyhting? Otherwise, I'll just merge it as is

I think this is a good commit history to keep as is in main since it shows the new features, modules, and config files added gradually (vs my PR which would've had a few too many bug fix commits to want to navigate through).

Squashed down to 4 commits. Thanks for approving @axkirillov @al-ce :rocket:


Bug/3840 --forbid-only doesn't recognize it.only when before crashes

Requirements

Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions.

Description of the Change
--forbid-only doesn't recognize it.only when before crashes.
Alternate Designs

Why should this be in core?
This is an attempt to solve the above-mentioned bug.

Benefits
This is an attempt to solve the above-mentioned bug.

Possible Drawbacks
None

Applicable issues
Fixes #3840

Is this a breaking change (major release)? No
Is it an enhancement (minor release)? No
Is it a bug fix, or does it not impact production code (patch release)? Yes

Coverage increased (+0.02%) to 92.411% when pulling 4bb47ce753a153278ac54a0eaace634e14734ee2 on rpgeeganage:bug/3840 into 9ea45e7557a193c4b69816085397a6655fb5bc06 on mochajs:master.

https://github.com/mochajs/mocha/issues/3840#issuecomment-474921006
Taking above comment into account I have doubts.
We have a parsing/definition phase and a runtime phase. describe.only() plus --forbid-only throws an error during the parsing phase (lib\interfaces\common.js). This PR with it.only() plus --forbid-only throws an error during the runtime phase.
IMO it makes sense to throw an error early during the parsing phase, without execution any test.
@boneskull thoughts?
The documentation states:

--forbid-only causes Mocha to fail when an exclusive ("only'd") test or suite is encountered, and it will abort further test execution.

The docu confirms the runtime solution, since some tests do run before an error is thrown.


refactor: move to yarn workspaces

This is the same PR as https://github.com/leolabs/you-need-a-parser/pull/646, just in the fork.

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.01 :tada:

Comparison is base (89a4907) 91.09% compared to head (0956f0a) 91.10%.

:exclamation: Current head 0956f0a differs from pull request most recent head 6793a75. Consider uploading reports for the commit 6793a75 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #1      +/-   ##
==========================================
+ Coverage   91.09%   91.10%   +0.01%
==========================================
  Files          25       25
  Lines         865      866       +1
  Branches      234      234
==========================================
+ Hits          788      789       +1
  Misses         70       70
  Partials        7        7

Impacted Files
Coverage Δ

packages/ynap-parsers/src/bank2ynab/bank2ynab.ts
68.96% <ø> (ø)

...ackages/ynap-parsers/src/util/read-encoded-file.ts
94.44% <100.00%> (+0.32%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Feat appwrite adapter bradley

☕ Reasoning

🧢 Checklist

[ ] Documentation
[ ] Tests
[ ] Ready to be merged

🎫 Affected issues

📌 Resources

Security guidelines
Contributing guidelines
Code of conduct
Contributing to Open Source

Thanks, @PineappleIOnic really appreciated


override default logger

This allows to use the same logger used by the containing application. An example is switchboard using winston to log to file (and to kinesis in the future).
PanDomainNode.setLogger(winston.log.bind(winston))

@chrisfinch

:+1:


Merge google -> main

f6e99a7db Synchronize submodules with LLVM at llvm/llvm-project@67cfefebbbbb
670ab16a1 Integrate LLVM at llvm/llvm-project@67cfefebbbbb
b1f26057e Integrate LLVM at llvm/llvm-project@632ebc4ab437
562961230 Integrate LLVM at llvm/llvm-project@0277a24f4bba
5c16671a6 Merge pull request #5757 from ScottTodd:main-to-google

I'm inclined to uhhh... ignore the permission bit changes on these files:

@GMNGeoffrey any idea why that happened / if we care?

I'm inclined to uhhh... ignore the permission bit changes on these files:

@GMNGeoffrey any idea why that happened / if we care?

Ugh this again.  I never managed to figure out what it was exactly. I guess it's fine if people want to execute our png files...


Run Onboard Camera on Jetson

Hey Alex,
thanks for your great github.
But unfortuantely the command for running the onboard camera on the jetson tx2 does not longer work.
Could you update it?
Would be awesome, thanks!
Gustav

Nevermind. it was due to my GSTREAM unable opencv build.
Fixed it!


Add dist folder to release zip

the readme states that the dist folder is included. But then it refers to the gh-pages branch or the npm upload, where this is the case.
It would be more convenient for non npm users to just offer a link to the github release zip which includes this folder and its minified libs.

You can download the gh-branch as a ZIP using this URL: https://github.com/audiolabs/trackswitch.js/archive/gh-pages.zip
Should we link to it/mention it somewhere?

I have added a link to the ZIP on https://audiolabs.github.io/trackswitch.js/

I would have prefered just the zipped dist folder. But this is already helpful for beginners. Thanks!


Undo operation creates unremovable bonds on the canvas (clear canvas doesn't help)

Steps to Reproduce

Go to Macro - Flex mode <---Important!
Load from HELM using paste from clipboard: RNA1{P}|RNA2{R(C)}$RNA2,RNA1,2:pair-1:pair$$$V2.0

Press Undo button

Actual behavior
Unremovable bonds appears on the canvas (clear canvas doesn't help)

Expected behavior
Canvas is clear

Versions

Ketcher Version 2.28.0-rc.2 Build at 2024-12-10; 18:40:08
Indigo Version 1.27.0-rc.1.0-g8d656a341-wasm32-wasm-clang-19.0.0
Chrome Version 131.0.6778.140 (Official Build) (64-bit)
Win10

Issue found while testing - https://github.com/epam/ketcher/issues/5712

Verified.

Versions

Ketcher Version 2.28.0-rc.1 Build at 2024-12-03; 17:04:52
Indigo Version 1.27.0-rc.1.0-g8d656a341-wasm32-wasm-clang-19.0.0
Chrome Version 131.0.6778.109 (Official Build) (64-bit)
Win10


Tell rn to set up on main queue to suppress warning

This would suppress the following warning.

Module RCTGoogleAnalyticsBridge requires main queue setup since it overrides constantsToExport but doesn't implement requiresMainQueueSetup. In a future release React Native will default to initializing all native modules on a background thread unless explicitly opted-out of.

ref: https://github.com/wix/react-native-navigation/issues/1982

@cbrevik
Hi, are you kind enough to check this?

Thanks for the PR! I've not been able to do any Open Source for quite some time, so sorry for being slow at merging this.


revisions to issue templates (and formalization of process for soliciting bugs and feature requests)

This PR adds issue templates to guide users where and how to submit feedback on the napari hub.
One goal is to try to reserve "Issues" for engineering-ready work (or at least for committed work even if there is iteration and alignment needed on the details of the work).
Questions
This PR adds a prompt when to submit questions to the discussion forum.
Bugs
Bugs should be submitted as Github issues. ~This adds a template for bug reports.~
Features
Feature requests should be submitted to our "Discussions" forum. From there, we can discuss with other users and stakeholders, dig in to understand the underlying problems and motivations, our team can explore solutions which may be different from the requested feature, and once we are confident that "there's a there there", we can build out user stories and designs to drive implementation.
This PR adds a prompt when to submit feature requests to the discussion forum.
User Stories
Once we have identified new features that we want to build, our team will create User Stories to guide design and engineering work.
This PR adds a template for user stories.

The PR description said this PR adds a template for bug reports, but I didn't see it.

Woops, you're right, @justinelarsen ... the repo already had a template


bug with incorrect calculation with TestNumericUtility::GetNumberOfCharsForInt

Incorrect calculation for number of characters required to store converted signed integers.

Fixed under commit:
https://github.com/cppocl/cppocl/commit/6030faf636e7cd9c57d14b489e80a8ea9c3d0ac5


[BUG] When route change Layout re-render

Describe the bug
I want to use <SubMenu> in my CustomSider component, but when I click on SubMenu items, the route changes, resulting in SubMenu dropdown closing but I don't want it to close.
This problem can be solved if the layout is not re-rendered in every route change.
Expected behavior
The Layout is not re-render in every route change.
Desktop:

OS: MacOS 11.2.3
Browser: Chrome 96.0.4664.93

Hey @salihozdemir ,
We've released<EMAIL_ADDRESS>Could you approve this fix?

Hey @salihozdemir , We've released<EMAIL_ADDRESS>Could you approve this fix?

Hi @omeraplak.
It seems that 'nextjs-router' has the same problem.


Random curl failures when installing on GitHub Actions

A couple days ago, I upgraded from the legacy CLI to the new CLI.
I've noticed that the actions are failing fairly frequently (for example, in a series of actions that downloads the CLI 12 times, 2 failures) due to a curl error when downloading platformsh:
Run curl -fsSL https://raw.githubusercontent.com/platformsh/cli/main/installer.sh | bash
  curl -fsSL https://raw.githubusercontent.com/platformsh/cli/main/installer.sh | bash
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
  env:
    PLATFORMSH_SITE_ID: ***
    GIT_LFS_SKIP_SMUDGE: 1
    COMPOSER_PROCESS_TIMEOUT: 0
    COMPOSER_NO_INTERACTION: 1
    COMPOSER_NO_AUDIT: 1
    BRANCH_NAME: prototype
    PLATFORMSH_DRUSH_ALIAS: @site-aliases.SITE.BRANCH
+--------------------------------------------------+
|                                                  |
|           Platform.sh CLI Installer              |
|                                                  |
+--------------------------------------------------+

Checking environment
  [*] Your kernel (linux) is supported
  [*] Your architecture (amd64) is supported
  [*] Using raw install method
  [*] cURL is installed
curl: (22) The requested URL returned error: 403
Error: Process completed with exit code 1.

Here's the step in the GitHub action, copied from the platformsh docs:
    - name: "Install platform CLI."
      shell: bash
      run: curl -fsSL https://raw.githubusercontent.com/platformsh/cli/main/installer.sh | bash

I can't remember getting such a failure with the legacy CLI, and if I did, I didn't get one every test run like I'm getting now.
Any ideas about how to debug this would be much appreciated.

@ptmkenny it's quite possible that you're running into GitHub's rate limit. Is it possible to use the following in your GitHub action?
        env:
          GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"

This will inject the GitHub token paired with your CI runner in the environment and in turn, the installer will use it for downloading the CLI and circumvent the GitHub API rate limit.
You can see how the token is used here
https://github.com/platformsh/cli/blob/17e7009992c300bf563f9256c1203115694959b1/installer.sh#L381-L389
Then, this is called to get the latest version
https://github.com/platformsh/cli/blob/17e7009992c300bf563f9256c1203115694959b1/installer.sh#L181
and to get the artifacts
https://github.com/platformsh/cli/blob/17e7009992c300bf563f9256c1203115694959b1/installer.sh#L399

Thanks that makes sense.  I didn't realize the installer needed auth , so I'll try running it with the token then. I won't be able to test for a couple days but I'll confirm when I get the chance.

Maybe we should consider hosting the binaries elsewhere to avoid this issue, like for the legacy CLI.

I'm a fan of hosting on github, and releases can be accessed without a token, but there is a strict limit if you don't have a token going. However, you can use https://nightly.link/ to get around this. DDEV does it so people can access without those kind of issues, and it works for github-attached zipballs as well.

We could also host it on Platform.sh 🙂

Yes, of course. that introduces build/push complexity, but definitely solves this class of problem.

@akalipetis Thanks, I did manage to get this working with an environment variable.  But, because I set up the build environment inside an action instead of inside the workflow directly, I have to pass the environment variable as an input to the action; accessing secrets directly within an action is not supported.  So switching from the legacy CLI to the new one added ~20 lines of code to my workflow passing the token around.
It would be great if the current version warned the user when the installer was called without GITHUB_TOKEN that you might actually want to provide such a token.


Extension to natural images?

First, really interesting work -- I happened to chance upon this repo, as Github recommended it.
For computer vision e.g., ColorMNIST have you considered natural images? Is there a bottleneck in terms of memory or compute, that required an MNIST variant? (Or is it just more difficult to find an obvious bias in natural images?)
The text gender bias is really interesting. Will have take a closer read before asking questions though!

Hi Alvin,
Glad you like the work!
We do show experiments with natural images (see the skin cancer dataset) on a VGG network where we increase predictive accuracy by penalizing the importance of bright patches pasted on the skin. In the paper this is described in sec 4.1
In table S1 we also show memory and computation requirements of a CDEP network vs a vanilla network (roughly twice as much memory requirements).
Complementary to the natural image dataset, the ColorMNIST allows us to precisely measure how effective CDEP and compared methods are since we know exactly what the bias is (as we induced it ourselves).
Hope this clears it up :)
Best, Laura


Call SaveMetadata REST API endpoint

Background
Exchange data between the agent and the server
Feature
Call the SaveMetadata REST API endpoint of the Atum server and provide it with data
Depends on #37
Depends on #38
Depends on #58

This item depends on:

AbsaOSS/atum-service#37
AbsaOSS/atum-service#38
AbsaOSS/atum-service#58
By Dependent Issues.

This item depends on:

AbsaOSS/atum-service#37
AbsaOSS/atum-service#38
AbsaOSS/atum-service#58
By Dependent Issues.


Method to Add predefined rights

In order to be able to configure reaccess little by little (module by module)

:+1:


ActiveRecord::JDBCError: Invalid column name 'id'

I'm working with a legacy windows sql server 2000 database using the jdbcmssql adapter
My model looks like:
class Student < ActiveRecord::Base
self.table_name = "tblSTUDENTS"
self.primary_key = 'StudentKey'
alias_attribute "id", "StudentKey"
end
When I do Student.first or Student.all everything seems to work fine but when I do:
Student.first(10)
Student.limit(10)
I get the following error:
ActiveRecord::JDBCError: Invalid column name 'id'.: SELECT TOP 10   [tblSTUDENTS].* FROM [tblSTUDENTS]  WHERE [tblSTUDENTS].id NOT IN (SELECT TOP 0 [tblSTUDENTS].id FROM [tblSTUDENTS]  ORDER BY [tblSTUDENTS].StudentKey) ORDER BY [tblSTUDENTS].StudentKey
I'm going to use a view to work around this but in the meantime am I missing something? I'd be glad to dig into the code if someone would give me a starting point.
Thanks
gregors

It's probably a bug in the code or not fully implemented.
See https://github.com/jruby/activerecord-jdbc-adapter/blob/master/lib/arjdbc/mssql/limit_helpers.rb#L27-49 for where the code probably goes wrong.

Yes, it's a bug where we try to guess the primary key with:
primary_key = order[/(\w*id\w*)/i] || "id"

but your key don't contain "id"

https://github.com/gregors/activerecord-jdbc-adapter branch limit_with_alt_primary_key  -- I forked the code and created a branch with a failing test - then I made the test pass without making any previous tests fai (well the view.sys test fails - but that fails before I touch any code, I'm assuming it fails on sql server 2000)l. But looking around I noticed that my new logic could caused some problems with what sql was being produced in some of the other tests. It's not producing invalid sql but sql where theORDER BY ships.id was being changed to ORDER BY ships.name. I dunno how to address this yet, it seems like the real solution is being able to grab the actual self.primary_key mapping value from the table itself.
Since we do know the table name perhaps we can get the model using something like...
table_name = 'badlyNamedLegacyTable'
model = ActiveRecord::Base.descendants.select{|model| model.table_name == table_name}.first
model.primary_key
I haven't tried this yet, and I dunno if I have access to the ActiveRecord methods where this code lives, but I'll try it out. Any other ideas I could try would be appreciated.


Only export required SwiftSyntax targets

Also, use SPMSwiftSyntax:: namespace to avoid potential name conflict issues.

@swift-ci Please test

https://github.com/apple/swift-syntax/pull/2618 failed because it's adding another dependency _SwiftSyntaxCShim to SwiftCompilerPluginMessageHandling target, but _SwiftSyntaxCShim is not listed here.
Instead of adding _SwiftSyntaxCShim to the export list, remove unnecessary items from the list because it's not needed at all.

@swift-ci Please test macOS

@swift-ci Please test Windows

https://github.com/apple/swift-syntax/pull/2620
@swift-ci Please test

@swift-ci Please test


OOPS : HYBRID INHERITANCE

@Saviour1001 @smv1999
PLEASE GO THROUGH THIS IDEA ONCE AND ASSIGN IT TO ME UNDER THE DCP21 LABEL, IT WILL BE A GREAT CONTRIBUTION TO YOUR OOPS FOLDER.
DESCRIPTION :
I want to add code for Hybrid Inheritance in C++.

Good to go!


PR3 - MD + Other

ok

done!

and the quotations around matrix?

I'm getting off rn. I'll be back tmr morning to merge this PR, and then I'll take a look at the CSS/JS PR

and the quotations around matrix?

isn't it like the same before and after?


Witness presence check not tested

This condition appears untested. I've been doing some experiments which didn't perform the check and the tests did not fail.

Another missing test: check that decoding an otherwise-valid transaction encoded with non-minimal VarInt fails.

it looks like this needs to be re-factored also. L1090 means the empty test in the condition you mentioned won't ever be empty here.

You're confusing it with witness flag, that one is correct.

You're confusing it with witness flag, that one is correct. (I meant the code is, didn't verify the tests.)

L1088 and L1095 do the same thing.  I'm not saying it's incorrect, just that it looks like it decodes twice which is not needed?
I read over BIP-141 that is mentioned in the comments, but it doesn't look like this BIP describes the TX serialization, or am I missing it?  Is there a different BIP that describes the serialization/de-serialization of a general transaction?

They don't, the cursor is already moved in the second call. Note that consensus_decode takes T: Read.
From quick look it looks like the BIP doesn't explicitly say that wtxid serialization is the same as P2P serialization but nevertheless it is.

I would like to solve this issue, But I couldn't find any test for consensus_decode_from_finite_reader can anyone please help me regarding this

You should dig into the call chain starting an encode::deserialize(). Note the Decodable trait is unusual in that both methods have default implementations that call each other, this just means that an implementor must implement at least one of them.

I think you shouldn't worry about that. Just add a test that passes in an invalid transaction with the mentioned errors. Somewhere in the tests modules you'll find a list of valid and invalid hexes.

I'm facing an issue. I've attempted to identify hexes that might cause failures, but none of them triggered the required error. Then
I tried using a hex from segwit_transaction() test and removed the witness with the following code:
let mut tx_without_witness = realtx;
tx_without_witness.input.iter_mut().for_each(|input| input.witness.clear());

After this modification, I serialized tx_without_witness and then attempted to deserialize it, hoping that it would produce the required error. This approach also failed to yield the desired outcome.
If anyone has insights or suggestions on how to properly serialize the transaction for testing purposes, your help would be greatly appreciated.

It's because the library serializes correctly. You have to produce invalid serialization manually.

You might also be able to modify one of the fuzztests to trigger on a specific error, and then it'll find a test case for you.

I managed to find it by chance (failing the roundtrip test) when working on #2184
0000fd000001021921212121212121212121f8b372b0239cc1dff600000000004f4f4f4f4f4f4f4f000000000000000000000000000000333732343133380d000000000000000000000000000000ff000000000009000dff000000000000000800000000000000000d

So in fact it is tested by the fuzzer. However, an explicit test would still be great because it's faster to run and much easier to understand what went wrong.


[DO NOT MERGE]Added 2021-05-01-preview ManagedInstanceOperation API

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[X] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
ARM Manifest is not yet updated, and with the current pace of MS trains, I guess it should be ready in about 2 months (september or october 2021)

When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
September or october 2021.

If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[X] No, no need to refresh for updates in this PR

Contribution checklist:

[X] I commit to follow the Breaking Change Policy of "no breaking changes"
[X] I have reviewed the documentation for the workflow.
[X] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[X] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
[X] Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
Adding a new service

[X] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

@krivi37 It is important to follow the second item in ARM API review checklist for efficient review.
Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
Please create a new PR and make sure the first commit is just a copy of the previous api version in a new api version folder.


Add streaming response to openai agent

Description
This PR is an initial stab at adding stream_chat and astream_chat to our agents.
Since agents can involve multiple steps, the idea here is to turn the streaming endpoints into generators of generators (i.e. a generator for each response).
This way, users can easily stream every step, or only the last step (as shown in the notebook)
NOTE: this is based on the new LLM refactor
Type of Change

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

How Has This Been Tested?

[x] Added new notebook (that tests end-to-end)
[x] I stared at the code and made sure it makes sense

TODO

[ ] confirm the best home for the StreamingChatResponse class
[ ] confirm this works for various backend usecases

Closing this to re-open another with cherry picked changes, in order to avoid messy history and rebasing


Shadow remains after window move with keys

If a window is moved using keybindings (e.g. Meta+Right), the shadow remains on old place.

It looks like something isn't being damaged enough but this would not be the responsibility of the decoration plugin, it should be fixed in whatever plugin you have configured to use i.e. Meta+Right. By default, it would be grid plugin. However it might not happen with other decoration plugins because they do not render shadows. Are you using the shadow plugin to render shadows or pixdecor with 'rounded corners' option?

I do not use shadow plugin. Here are the settings:
[core]
plugins = alpha autostart command expo fast-switcher grid move oswitch place resize switcher vswitch
 window-rules wm-actions scale scale-title-filter foreign-toplevel kbdd pixdecor

[pixdecor]
always_decorate = none
animate = false
bg_color = \#1C1F21FF
bg_text_color = \#B3B3B3FF
border_size = 1
csd_titlebar_height = 32
effect_color = \#E01C24FF
effect_type = none
enable_shade = true
fg_color = \#31363BFF
fg_text_color = \#FFFFFFFF
icons_path = /home/alex/.config/wayfire/icons/window-%s.png
ignore_views = none
maximized_borders = true
maximized_shadows = false
overlay_engine = rounded_corners
rounded_corner_radius = 8
shade_duration = 1000ms sigmoid
shade_modifier = <ctrl> <super>
shade_toggle =
shadow_color = \#00000040
shadow_radius = 0
title_font = Noto Sans, 16
title_text_align = 1
titlebar = true

[grid]
duration = 300ms circle
restore = <super> KEY_DOWN | <super> KEY_KP0
slot_b = <super> KEY_KP2
slot_bl = <super> KEY_KP1
slot_br = <super> KEY_KP3
slot_c = <super> KEY_UP | <super> KEY_KP5
slot_l = <super> KEY_LEFT | <super> KEY_KP4
slot_r = <super> KEY_RIGHT | <super> KEY_KP6
slot_t = <super> KEY_KP8
slot_tl = <super> KEY_KP7
slot_tr = <super> KEY_KP9
type = none

In your config, you have shadow_radius = 0, which means there are no shadows. Also in your screenshot, the window appears as if maybe it was wobbling or some other transform that make the lines not parallel to the edges of the shot. I am not able to reproduce this problem, so I feel like I'm missing something.

I used a phone, because an attempt to make a screenshot erases the artifact

Actually, when I set shadow_radius to a non-zero value, I can reproduce the problem. I'll look into it.

I think it was late when I tested with different shadow size, and set it to zero late night, and today just copied a part of config without recheking again. sorry. The shadow must be greater than zero. This is how I found it is shadow, not a border.

Yes, the patch helps. The issue has gone with the patch applied. Thanks

I was able to fix the problem in pixdecor, thanks for the report. This issue should close automatically when track-wlroots-0.18 is merged, so it will work without the wayfire/grid patch.


[Bug] Series selection via URL appears to be broken

Describe the Bug
https://testing-viewer.canceridc.dev/v3/viewer/?StudyInstanceUIDs=1.2.840.1136<IP_ADDRESS>7670372562599702205432127692146974562&SeriesInstanceUID=1.2.840.1136<IP_ADDRESS>263399928421039572326605504649736531
I do not know if this is specific to our fork, or an upstream issue. Could this be related to https://github.com/OHIF/Viewers/pull/4328?
Steps to Reproduce
https://testing-viewer.canceridc.dev/v3/viewer/?StudyInstanceUIDs=1.2.840.1136<IP_ADDRESS>7670372562599702205432127692146974562&SeriesInstanceUID=1.2.840.1136<IP_ADDRESS>263399928421039572326605504649736531
The current behavior
https://testing-viewer.canceridc.dev/v3/viewer/?StudyInstanceUIDs=1.2.840.1136<IP_ADDRESS>7670372562599702205432127692146974562&SeriesInstanceUID=1.2.840.1136<IP_ADDRESS>263399928421039572326605504649736531
The expected behavior
https://testing-viewer.canceridc.dev/v3/viewer/?StudyInstanceUIDs=1.2.840.1136<IP_ADDRESS>7670372562599702205432127692146974562&SeriesInstanceUID=1.2.840.1136<IP_ADDRESS>263399928421039572326605504649736531
OS
macOS
Node version
n/a
Browser
Chrome

Download
https://www.mediafire.com/file/zch0v8rj7200mbm/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Resolved upstream by https://github.com/OHIF/Viewers/pull/4346


created separate file for teamwork and updated tokenmetadatafields

Updated pull request for Teamwork
Old PR - https://github.com/amp-labs/connectors/pull/454
Note
Created a separate file for teamwork and also updated the TokenMetadataFields.
The base URL requires a sitename value specific to your account:

For US-hosted customers: https://{yourSiteName}.teamwork.com
For EU-hosted customers: https://{yourSiteName}.eu.teamwork.com

The sitename is captured as the workspace value, which can be obtained from the token response.
Testing
TOKEN RESPONSE
SCRIPT:

POSTMAN:

Teamwork
POST
URL: http://localhost:4444/projects.json

GET
URL: http://localhost:4444/projects.json

PUT
URL: http://localhost:4444/projects/1167133.json

DELETE
URL: http://localhost:4444/projects/1144362.json

Spaces
POST
URL: http://localhost:4444/spaces/api/v1/companies.json

GET
URL: http://localhost:4444/spaces/api/v1/companies.json?pageSize=2

PUT
URL: http://localhost:4444/spaces/api/v1/companies/1390424.json

DELETE
URL: http://localhost:4444/spaces/api/v1/companies/1390424.json

Desk
POST
URL: http://localhost:4444/desk/api/v2/customers.json

GET
URL: http://localhost:4444/desk/api/v2/customers.json

PUT
URL: http://localhost:4444/desk/api/v2/customers/707692.json

DELETE
URL: http://localhost:4444/desk/api/v2/customers/707692.json

closes #441

Updated PR -https://github.com/amp-labs/connectors/pull/702


MenuButton: StopPropagation on button click

Is there a way to trigger 'stopPropagation' on the 'MenuButton'?
Scenario:
I have React-Menu implemented within an Accordion component.
Currently, When the  is clicked, this triggers the Accordion click handler as well.
Solution sought:
When the React-Menu  component is clicked, I want to trigger ev.stopPropagation() to stop the event from propagating up the DOM hierarchy.
Thank you,

I think the easiest way is to attach an onClick handler to menu button and call stopPropagation from there:
<Menu menuButton={<MenuButton onClick={e => e.stopPropagation()}>Menu</MenuButton>}>
  <MenuItem>Cut</MenuItem>
  <MenuItem>Copy</MenuItem>
  <MenuItem>Paste</MenuItem>
</Menu>

Resolved as per szhsin's reply.


Need: Key Management

[x] Paste a key

[x] Generate a key

[x] Generate a key and put in Secure Enclave - while I can do this, the EC25519 key that I get back as the public key comes with x/y parameters that need to be converted into the 32-byte sequence, to debug this it might be easier to generate a key without Secure Enclave, and debug that until we have something that works (the RFC describes this process: https://tools.ietf.org/html/rfc8032#section-5.1.6)

[x] Save key

[x] Load from File, could use iCloud Drive.

[x] Store the type in the Key, this is only for UI purposes, the library should be able to handle this.   And it is so that we can render things like "This is a key of this type".   See code in SwiftTermApp/UIs/STFilePicker.swift

~Passphrases should go in the keychain~

Done


Fix: Fixed Application Segment Drift and Microtenant missing attribute

Provide a general summary of your changes in the title above. You should
remove this overview, any sections and any section descriptions you
don't need below before submitting. There isn't a strict requirement to
use this template if you can structure your description and still cover
these points.
Description
Describe your changes in detail through motivation and context. Why is
this change required? What problem does it solve? If it fixes an open
issue, link to the issue using GitHub's closing issues keywords1.
Has your change been tested?
Explain how the change has been tested and what you ran to confirm your
change affects other parts of the code. Automated tests are generally
expected and changes without tests should explain why they aren't
required.
Screenshots (if appropriate):
Types of changes
What sort of change does your code introduce/modify?

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] This change is using publicly documented and stable APIs.

Codecov Report
Attention: Patch coverage is 66.07143% with 19 lines in your changes missing coverage. Please review.

Project coverage is 74.07%. Comparing base (53450f4) to head (ae2817c).

Files
Patch %
Lines

zpa/resource_zpa_microtenant_controller.go
0.00%
8 Missing :warning:

zpa/data_source_zpa_microtenant_controller.go
78.12%
7 Missing :warning:

zpa/resource_zpa_service_edge_group.go
55.55%
3 Missing and 1 partial :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #479      +/-   ##
==========================================
- Coverage   76.12%   74.07%   -2.05%
==========================================
  Files          92       92
  Lines       16818    16857      +39
==========================================
- Hits        12802    12487     -315
- Misses       3156     3548     +392
+ Partials      860      822      -38

Files
Coverage Δ

zpa/resource_zpa_application_segment.go
27.00% <100.00%> (-42.40%)
:arrow_down:

zpa/resource_zpa_service_edge_group.go
72.22% <55.55%> (+0.14%)
:arrow_up:

zpa/data_source_zpa_microtenant_controller.go
72.63% <78.12%> (+0.89%)
:arrow_up:

zpa/resource_zpa_microtenant_controller.go
6.73% <0.00%> (-0.14%)
:arrow_down:

... and 6 files with indirect coverage changes


Update lock files and downgrade minimum arbitrary

Recently we added a use of Arbitrary for [u8; 64] (schnorr sig). I hit a build failure locally and discovered that

arbitrary 1.0.0 does not implement Arbitrary for 64 byte array
We use arbitrary = 1 in the bitcoin manifest
We have arbitrary 1.3.2 in the Cargo-minimal.lock file

Fix this all up by doing:

Use 1.0.1 in the bitcoin manifest because that is a hard minimum version required to build
Downgrade the Cargo-minimal.lock file to use arbitrary v1.0.1
Upgrade the Cargo-recent.lock file while we are at it for good measure.

Ref: #3397

Was there a special case you were testing that pulled in arbitrary 1.0.0? Asking cause i added the use case that broke it so I can add it to the list of checks i do before opening a PR

It was after I ran cargo clean on master I think, I don't often run that command I was working on something else unrelated. Then I went digging to see why there was a build failure on master and why CI hadn't caught it. To find v1.0.1 I just went through the arbitrary docs manually version at a time till I found when they added it.

No stress man, this was an easy thing to miss. Could have easily done it myself.

Nice, great catch!
@shinghim in future CI will catch this because @tcharding kindly updated the Cargo-minimal.lock. (This is the purpose of these lockfiles but we've been a bit lazy about actually adding minimal versions to it, because there isn't good tooling for obtaining minimal-version lockfiles from the versions in the .toml.)

Also thanks for updating the recent lockfile. I guess from CI's passing that the new versions are compatible with our MSRV. I will test it locally but it may be several hours because there are a whole bunch of "please merge!"

It was after I ran cargo clean on master I think, I don't often run that command I was working on something else unrelated.

Would this be caught earlier if "cargo clean" is part of the CI pipeline?

Also thanks for updating the recent lockfile.

Agree, although this could've be a separate commit since it seems unrelated to the need for updating the minimal file to fix Arbitrary.

Would this be caught earlier if "cargo clean" is part of the CI pipeline?

No. CI uses the fixed lockfiles and will always pull in the version of arbitrary specified there (which was inconsistent with that specified in Cargo.toml).

Merge please.


Adopt cdo-local-uuid

This PR adds cdo-local-uuid to the code base, letting the case.jsonld generated example file be regenerated with noise from random UUIDs eliminated.

One side-effect I included was refreshing the Poetry lockfile.


Xiaomi router 3g Openwrt V19 problem. Upload very low.

Hello, I have xiaomi router 3g, I installed OpenWrt v18 and everything perfect, perfect speed, perfect management (although improvable) etc ...
The problem comes when upgrading to v19 and v19.0.1, the router's upload speed low by half (wired 600mbs v18) v19 300mbs upload speed .... it looks like a bug and it happens to many people , is there any solution to this? Is it possible to improve the router driver and improve the upload and full management of v19? thanks.

I would say this is not LuCI related please open a Ticket in https://bugs.openwrt.org/

For WiFi related issues on that specific device http://github.com/openwrt/mt76 would be the place to go.


Image can't be displayed completely --- version  1.4.0

Like below,on ios device.

When image is loading, i click it and show a modal and the image will like that.

Got the same issue yesterday. This issue is most likely caused by RNFB library that is doing the image downloading and caching.  @wcandillon I think this might be related to https://github.com/wkh237/react-native-fetch-blob/issues/368. @StanLee12 are you able to reproduce this issue consistently? If so it might be worth trying out the timeout config in the fetch https://github.com/wcandillon/react-native-img-cache/blob/master/src/index.tsx#L104

@antondomratchev  Yes, i can reproduce this issue every time.
Thanks for your answer  :-)， i will try that

I've the same issue :/ ! Do you have any idea?

same issue here...

This also happens when using react-native-fetch-blob without this library. When I restart the app the images are already cached. So I can not figure out what exactly is wrong since it is only displayed wrong the first time...

This is an duplicate of https://github.com/wcandillon/react-native-img-cache/issues/61

@wcandillon  I don't want to add expo to my project. Is there a non-expo version of this library with the fix for this problem?

@sriraman Have you tried https://github.com/DylanVann/react-native-fast-image ?

any updated?


[ Bug ] The slider edit menu does not close after saving

You can still save your changes, but the menu is not closed.
You need to click "Cancel" to close it.

I don't have this problem, it works to me

I tried again and it works now !
I can't replicate it.
I think I had multiple workflows and other programs opened, at the time.
I will reopen, if it happens again.


feat: add cache flag

Resolves #156
CAC by default handles --no-cache flag!

Landed in https://github.com/jspm/jspm/pull/165.


latest version

... is not here but there
https://github.com/milahu/nixpkgs/tree/qt6-631-debug-qtwebengine/pkgs/development/python-modules/nix-build-profiler/src

done. commits moved to this repo


Feature Request : Add duplicate button

Hello
I suggest the following feature :
For the views: conditional layers, combos, macros and behaviors, add a button duplicate.
When we click on it, a popup window opens, just like when we create a new element, but with fields already filled in with the information of the element we want to duplicate.
We can save a lot of time and avoid repetitive manual actions on the part of the user.
Best Regards

Hi, thanks for sharing!
It's an interesting idea, but one thing that makes me pause is the fact that all of these features have at least one element that must be unique between them (the node name, and in the case of behavior types, the devicetree reference and label properties) and other elements that should be unique to make it useful.
Do you have some example use-cases of how you'd duplicate a node and make it sufficiently unique to be useful? On thing I'd imagine is perhaps conditional layers where a number of the if-layers values are common but it's easier to just delete some irrelevant layers from the duplicated node instead of adding everything.

The button will not really duplicate the node but a open the creation node popup with elements already pre-filled so nothing will be created until the user has clicked on "create".
For example,
You want to create a behavior "mod-morph" to override the behavior of left shift when you press a key.
If you want to create another behavior with the same mods and with bindings slightly different, actually you will have to fill all the information again.
The idea is to be able to click on a icon duplicate and it will open the Edit behavior popup, it will consider that  mod-morph has already been selected, and it will fill all fields with values of the behavior we want to duplicate.
With same bindings, same mods and same keep-mods.

Each view seems to have its own workflow, so I guess it will not be an easy feature.
But it could be really a time saving feature when you create a lot of similar macro and behavior.

Yeah, not unreasonable. I think I can start with the behavior version, see how well it works out, and decide if/how best to implement it across other features.
Thanks!

Thank you

Alright this worked out really nicely: because of the initial behavior type selection I already have an easy way to handle these transient behavior records in the editing dialog, so adding the clone button only required a handful of newlines in one file.

I need to go back and add validation to the input fields for node name/label/bind to stop people from sticking with the default new_behavior values but that concern is separate from this one already.

... and now I've added it to combos, macros, and conditional layers.
I'm going to consider this done for now, but there are some improvements that could be made. The patterns for browsing and editing have evolved throughout development as new features and requirements were added. At some point I'll be making some refactors to get everything using the same components for managing things like node names and properties and will likely take that opportunity to get some consistency in the new/clone dialog and workflow as well.
Let me know how you like the new feature!

That was fast !
This feature is really useful and works really well !
It doesn't prevent from using the features, but it's true that new/clone dialogs lack a little consistency between workflows.
Thank you very much for your work !
For me I consider this feature request as done, if it's ok for you, you can close it.


Pin numpy version to 1.x

When I was trying to run test/xrt examples, I started to get an error:
A module that was compiled using NumPy 1.x cannot be run in
NumPy 2.0.0 as it may crash. To support both 1.x and 2.x
versions of NumPy, modules must be compiled with NumPy 2.0.
Some module may need to rebuild instead e.g. with 'pybind11>=2.12'.

If you are a user of the module, the easiest solution will be to
downgrade to 'numpy<2' or try to upgrade the affected module.
We expect that some modules will need time to support NumPy 2.

Traceback (most recent call last):  File "/scratch/ehunhoff/mlir-air/test/xrt/03_mul_L1L2_1x1/run.py", line 17, in <module>
    from bfloat16 import bfloat16
AttributeError: _ARRAY_API not found
ImportError: numpy.core.multiarray failed to import

Following the advice in the error message, I pinned the numpy version to 1.x

@fifield Do you want me to create an issue or something so we remember to check in the future? Or should I just merge this in?

@fifield Do you want me to create an issue or something so we remember to check in the future? Or should I just merge this in?

just merge this in


Add flex to docker for building bpf module on recent amazon linux2

Flex is needed for building bpf module on recent amazon linux images.
https://github.com/falcosecurity/falco/issues/1558
What type of PR is this?

Uncomment one (or more) /kind <> lines:
/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:
/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:
The bpf module fails to build on recent amazon linux2 versions with docker (k8s) deploys.
Which issue(s) this PR fixes:
https://github.com/falcosecurity/falco/issues/1558

Fixes #1558
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign leogr after the PR has been reviewed.
You can assign the PR to them by writing /assign @leogr in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

docker/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/assign @leogr

LGTM label has been added.  Git tree hash: 151d00e663a34aa782fab9bc78eb6471827bedaf

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

docker/OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/milestone 0.28.0

/cc @leodido

New changes are detected. LGTM label has been removed.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign leogr after the PR has been reviewed.
You can assign the PR to them by writing /assign @leogr in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

docker/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign leogr after the PR has been reviewed.
You can assign the PR to them by writing /assign @leogr in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

docker/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

d679c77 Add bison for module bpf building

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

d679c77 Add bison for module bpf building
915e4dd Merge branch 'add-flex-to-docker' of github.com:schans/falco into add-flex-to-docker

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@schans: Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

d679c77 Add bison for module bpf building
915e4dd Merge branch 'add-flex-to-docker' of github.com:schans/falco into add-flex-to-docker
4e5bdbe Merge branch 'add-flex-to-docker' of github.com:schans/falco into add-flex-to-docker

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Hi @leodido ,
I have added bison, squashed the commits and added the sign off. Hopefully we're good to go ;-)

LGTM label has been added.  Git tree hash: 9f97b2d2201ad6c0ea8e970c58b36ad95ef29f17

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

docker/OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Looks like we are really close to merging ;-) Anything I can do to help to push this over the line?

Looks like we are really close to merging ;-) Anything I can do to help to push this over the line?

You did already a lot! :)
Now we have just to wait for another maintainer who will double-check and approve eventually. I'm confident that will happen within the 0.28.0 time window. :+1:
Thank you again

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leodido, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

docker/OWNERS [leodido,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


nixos/fish: fix completion generation for non-derivation packages

Description of changes
This fixes #176848. Tests not added because I don't think there's a way to reliably get a non-derivation store path on Hydra.
Extracting the name from the path this way (didn't find anything useful in lib or builtins) should be fine but there might be a reason it's a bad idea that I don't see.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

I imported the modified module into my configuration.nix and it seems to have fixed my issue.

PR fixed my setup as well. Thanks!

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1930

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/966

Can we get this merged?

@ofborg build nixosTests.fish


zap-cli import list does not list imported context

I was able to import a context successfully, but context list shows as empty
zap-cli context import bodgeIt-Context.context
[INFO]            Imported context from bodgeIt-Context.context
zap-cli context list
[INFO]            Available contexts: []

Same exact problem here . . my ajax-spider is shutting down immediately after launching and I can only assume that this is because the context is never loaded
Anyone ?

I have also experienced the same issue:

I exported a context which was working in the GUI
I then successfully imported the same context using zap-cli
When I try to apply the context in, for example, a Spider run, it can't find the context
Running zap-cli context list gives:
[INFO] Available contexts: []

Has anyone had a chance to look into this yet?

I have the same problem here.. I did exactly the same as @MatthewGG , the context doesn't appear

I am facing the same issue

I am facing same issue too. Is anyone able to help ?


Implement scaffold generator

[x] I have searched the issues of this repo and believe that this is not a duplicate.

Feature Request

Scaffolds an entire resource, from model and migration to controller, along with a full test suite.
To be clarified.

Requires:

#45
#46
probably some other implementation yet unknown in detail


Calibre returns an error if I try to open a book which title is too long

I have to disable this plugin before Calibre lets me view the book.
calibre, version 7.20.0
ERROR: Unhandled exception: <b>ServerError</b>:Child "activity" fails because child "state" fails because "state" length must be less than or equal to 128 characters long

calibre 7.20  embedded-python: True
Windows-10-10.0.26100-SP0 Windows ('64bit', 'WindowsPE')
('Windows', '10', '10.0.26100')
Python 3.11.5
Windows: ('10', '10.0.26100', 'SP0', 'Multiprocessor Free')
Interface language: None
EXE path: C:\Program Files\Calibre2\calibre.exe
Successfully initialized third party plugins: Calibre RPC (1, 0, 0) && FanFicFare (4, 39, 0) && KoboTouchExtended (3, 7, 0)
Traceback (most recent call last):
  File "calibre\gui2\actions\view.py", line 324, in view_triggered
  File "calibre\gui2\actions\view.py", line 401, in _view_books
  File "calibre_plugins.calibre_rpc.hooks", line 19, in _view_calibre_books
  File "calibre_plugins.calibre_rpc.rpc", line 44, in update
  File "calibre_plugins.calibre_rpc.pypresence.presence", line 32, in update
  File "asyncio\base_events.py", line 653, in run_until_complete
  File "calibre_plugins.calibre_rpc.pypresence.baseclient", line 86, in read_output
calibre_plugins.calibre_rpc.pypresence.exceptions.ServerError: Child "activity" fails because child "state" fails because "state" length must be less than or equal to 128 characters long

will be fixed when i get time tomorrow, thanks for reporting

fix is in new release https://github.com/die/calibre-rpc/releases/latest


Dying with utility belt makes it unable to pickup items after respawning

When pressing e to pickup an item it give this error
[Error  : Unity Log] IndexOutOfRangeException: Index was outside the bounds of the array.
Stack trace:
(wrapper dynamic-method) GameNetcodeStuff.PlayerControllerB.DMD<GameNetcodeStuff.PlayerControllerB::FirstEmptyItemSlot>(GameNetcodeStuff.PlayerControllerB)
(wrapper dynamic-method) GameNetcodeStuff.PlayerControllerB.DMD<GameNetcodeStuff.PlayerControllerB::SetHoverTipAndCurrentInteractTrigger>(GameNetcodeStuff.PlayerControllerB)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition.Trampoline<GameNetcodeStuff.PlayerControllerB::SetHoverTipAndCurrentInteractTrigger>?1318786928(GameNetcodeStuff.PlayerControllerB)
LethalThings.PouchyBelt.PlayerControllerB_SetHoverTipAndCurrentInteractTrigger (On.GameNetcodeStuff.PlayerControllerB+orig_SetHoverTipAndCurrentInteractTrigger orig, GameNetcodeStuff.PlayerControllerB self) (at O:/github/LethalThings/LethalThings/MonoBehaviours/PouchyBelt.cs:81)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition.Hook<GameNetcodeStuff.PlayerControllerB::SetHoverTipAndCurrentInteractTrigger>?88467856(GameNetcodeStuff.PlayerControllerB)
(wrapper dynamic-method) GameNetcodeStuff.PlayerControllerB.DMD<GameNetcodeStuff.PlayerControllerB::LateUpdate>(GameNetcodeStuff.PlayerControllerB)
[Error  : Unity Log] IndexOutOfRangeException: Index was outside the bounds of the array.
Stack trace:
(wrapper dynamic-method) GameNetcodeStuff.PlayerControllerB.DMD<GameNetcodeStuff.PlayerControllerB::FirstEmptyItemSlot>(GameNetcodeStuff.PlayerControllerB)
(wrapper dynamic-method) GameNetcodeStuff.PlayerControllerB.DMD<GameNetcodeStuff.PlayerControllerB::SetHoverTipAndCurrentInteractTrigger>(GameNetcodeStuff.PlayerControllerB)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition.Trampoline<GameNetcodeStuff.PlayerControllerB::SetHoverTipAndCurrentInteractTrigger>?1318786928(GameNetcodeStuff.PlayerControllerB)
LethalThings.PouchyBelt.PlayerControllerB_SetHoverTipAndCurrentInteractTrigger (On.GameNetcodeStuff.PlayerControllerB+orig_SetHoverTipAndCurrentInteractTrigger orig, GameNetcodeStuff.PlayerControllerB self) (at O:/github/LethalThings/LethalThings/MonoBehaviours/PouchyBelt.cs:81)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition.Hook<GameNetcodeStuff.PlayerControllerB::SetHoverTipAndCurrentInteractTrigger>?88467856(GameNetcodeStuff.PlayerControllerB)
(wrapper dynamic-method) GameNetcodeStuff.PlayerControllerB.DMD<GameNetcodeStuff.PlayerControllerB::LateUpdate>(GameNetcodeStuff.PlayerControllerB)
[Error  : Unity Log] IndexOutOfRangeException: Index was outside the bounds of the array.
Stack trace:
(wrapper dynamic-method) GameNetcodeStuff.PlayerControllerB.DMD<GameNetcodeStuff.PlayerControllerB::FirstEmptyItemSlot>(GameNetcodeStuff.PlayerControllerB)
(wrapper dynamic-method) GameNetcodeStuff.PlayerControllerB.DMD<GameNetcodeStuff.PlayerControllerB::SetHoverTipAndCurrentInteractTrigger>(GameNetcodeStuff.PlayerControllerB)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition.Trampoline<GameNetcodeStuff.PlayerControllerB::SetHoverTipAndCurrentInteractTrigger>?1318786928(GameNetcodeStuff.PlayerControllerB)
LethalThings.PouchyBelt.PlayerControllerB_SetHoverTipAndCurrentInteractTrigger (On.GameNetcodeStuff.PlayerControllerB+orig_SetHoverTipAndCurrentInteractTrigger orig, GameNetcodeStuff.PlayerControllerB self) (at O:/github/LethalThings/LethalThings/MonoBehaviours/PouchyBelt.cs:81)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition.Hook<GameNetcodeStuff.PlayerControllerB::SetHoverTipAndCurrentInteractTrigger>?88467856(GameNetcodeStuff.PlayerControllerB)
(wrapper dynamic-method) GameNetcodeStuff.PlayerControllerB.DMD<GameNetcodeStuff.PlayerControllerB::LateUpdate>(GameNetcodeStuff.PlayerControllerB)

Can be worked around by scrolling to change item selected


cp does not overwrite files by default

In POSIX cp would just overwrite a file by default, without requiring the -f option.  This quite surprised me.  Was this done to make the cp behaviour a bit saver? In that case, would it be possible to mention this in the docs?

I agree, this is something that probably should be documented. I think it would be even better to add the -n option and make -f the default (and simply keep it there for legacy reasons).

This is now fixed in ShellJS v0.6. Thanks for reporting this, @lvanengelen :+1:


using get_config does not work with fzf-lua.register_ui_select

Hi @stevearc,
I recently started using fzf-lua shortly before you refactored this plugin to use register_ui_select exclusively. Since adding in the configuration to use require('fzf-lua').register_ui_select(...) which is now recommended, when trying to setup a custom handler via dressing using get_config = function (d) if d.kind == '...' then ... end I find that the ui.select function is completely overtaken by fzf-lua. So whatever the custom behaviour of my get_config for select in dressing. Once fzf-lua is present with it's registration function it completely takes over.
This might be by design on your part to allow users of that plugin defer entirely to it, but for me one of the key advantages of dressing is that I can route how different things are handled. I'm wondering if it's possible to still have dressing in charge overall but only deferring to fzf-lua if I haven't set some other custom handler.
I'm not sure if maybe this will require some sort of work on both sides though since perhaps (haven't checked) the fzf-lua implementation just directly overrides vim.ui.select but my thinking re. a solution would be a way to check if the value of vim.ui.select ~= dressing_override_fn in which case it stores the old overrider i.e. fzf-lua's one and tries to handle it but if there is not custom handler then it uses that as the fallback.
This might be nowhere near a good solution just some guesstimations based on not having looked at either implementation in detail.

I've undeprecated the fzf_lua config. Previously I think there was no way to pass in the config options to their implementation of ui.select, but now there is so we can gracefully call into it


testsuite: Improve sysroot and fullmir handling

Note that previously, we only set -Zmiri-start-fn when rustc_test_suite().is_none(). That didn't seem right though?

That didn't seem right though?

yea, the new code is better. Not sure what happened there


Issue with k8s.io/docs/tasks/access-application-cluster/ingress-minikube/

At  step - > Create an Ingress resource
kubectl apply -f https://k8s.io/examples/service/networking/example-ingress.yaml
I am getting following error
unable to recognize "https://k8s.io/examples/service/networking/example-ingress.yaml": no matches for kind "Ingress" in version "networking.k8s.io/v1"

/kind support
https://kubernetes.io/blog/2021/07/14/upcoming-changes-in-kubernetes-1-22/ might be relevant. Essentially, the key thing is to make sure that the version of the documentation you're reading is for the version of Kubernetes that you're running.

Th issue  is that the steps are not working in KATACODA leave alone on local env. For replication of issue please follow the steps mentioned on the webpage below on the page itself.
https://kubernetes.io/docs/tasks/access-application-cluster/ingress-minikube/

/remove-kind support
Thanks for clarifying.
This Katacoda environment is out of date. We should update it.
/kind bug
/triage accepted

/retitle Unable to follow Ingress with NGINX task in Katacoda

/triage duplicate
First reported in #27493

Fixed by #29616
/close


listen later layout

With the changes to the maui api, the listen later page was broken. This pr fixes the layout.

@migueBarrera rad! are you able to post some screenshots too with PRs?


flutter devices wrongly reports iPhone 5 simulator as unsupported

It's the default simulator for many XCode installs.  We technically support it just fine since it's x86. :)
The only reason we don't support iPhone 5 the physical device is that we don't currently distribute an ARMv7 (32-bit) binary since Apple devices have been 64-bit-only for every iOS device since iPhone 5.
https://github.com/flutter/flutter/issues/2089

Related patch #7857 for future ref.

Tested on head. Seems to have been resolved.


Simplify expressions with NOT clause

Which issue does this PR close?
Closes #2957
Rationale for this change
negate a Not clause
For BinaryExpr, use the negator of op instead.
not ( A > B) ===> (A <= B)
For BoolExpr, not (A and B) ===> (not A) or (not B)
not (A or B) ===> (not A) and (not B)
not (not A) ===> A
For NullExpr, not (A is not null) ===> A is null
not (A is null) ===> A is not null
For InList, not (A not in (..)) ===> A in (..)
not (A in (..)) ===> A not in (..)
For Between, not (A between B and C) ===> (A not between B and C)
not (A not between B and C) ===> (A between B and C)
For others, use Not clause
What changes are included in this PR?
Add rules to simplify not clause in datafusion/optimizer/src/simplify_expressions.rs

Refine the code according to the comments.

Codecov Report

Merging #2958 (4f2c41e) into master (117df4d) will increase coverage by 0.23%.
The diff coverage is 94.14%.

:exclamation: Current head 4f2c41e differs from pull request most recent head 9d57e89. Consider uploading reports for the commit 9d57e89 to get more accurate results

@@            Coverage Diff             @@
##           master    #2958      +/-   ##
==========================================
+ Coverage   85.42%   85.65%   +0.23%
==========================================
  Files         275      279       +4
  Lines       49839    51076    +1237
==========================================
+ Hits        42575    43751    +1176
- Misses       7264     7325      +61

Impacted Files
Coverage Δ

...tafusion/core/src/physical_plan/file_format/mod.rs
97.36% <ø> (ø)

datafusion/core/tests/sql/joins.rs
99.31% <ø> (ø)

datafusion/optimizer/src/test/mod.rs
94.23% <92.10%> (-5.77%)
:arrow_down:

...usion/optimizer/src/decorrelate_scalar_subquery.rs
92.72% <92.72%> (ø)

...tafusion/optimizer/src/decorrelate_where_exists.rs
93.42% <93.42%> (ø)

datafusion/expr/src/logical_plan/plan.rs
77.43% <93.75%> (+0.46%)
:arrow_up:

datafusion/optimizer/src/utils.rs
92.17% <93.75%> (+3.60%)
:arrow_up:

datafusion/core/tests/sql/mod.rs
98.26% <94.02%> (-0.56%)
:arrow_down:

datafusion/optimizer/src/decorrelate_where_in.rs
94.11% <94.11%> (ø)

datafusion/core/tests/sql/subqueries.rs
94.32% <94.32%> (ø)

... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

Thanks @AssHero  and @liukun4515 !


Internal Server Error

I have succesfully deployed the app and got it working in Chrome, however when I speak to the app I get 'Internal Server Error' as the response with "The server encountered an internal error and was unable to complete your request. Either the server is overloaded or there is an error in the application." below.
I'm really very new to all this so can someone point me in the right direction to get this fixed?
Thanks.

hey emily, I am receiving the same error, can you give me any tips? did you perhaps found this error message?
local variable 'response' referenced before assignment


[Doc Improvement][Link update - connectors for Microsoft 365 groups][3299383]

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/samples/integrating-web-apps.md
96
8
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/samples/integrating-web-apps.md
96
8
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/samples/integrating-web-apps.md
96
8
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.


Add span.tags

closed elastic/apm-agent-java#170

Codecov Report

Merging #172 into master will increase coverage by 0.01%.
The diff coverage is 83.33%.

@@             Coverage Diff              @@
##             master     #172      +/-   ##
============================================
+ Coverage     73.36%   73.37%   +0.01%
- Complexity     1001     1003       +2
============================================
  Files           108      109       +1
  Lines          3698     3711      +13
  Branches        337      337
============================================
+ Hits           2713     2723      +10
- Misses          820      824       +4
+ Partials        165      164       -1

Impacted Files
Coverage Δ
Complexity Δ

...ava/co/elastic/apm/web/SanitizingWebProcessor.java
90.47% <ø> (ø)
10 <0> (ø)
:arrow_down:

...rc/main/java/co/elastic/apm/web/BodyProcessor.java
69.23% <ø> (ø)
8 <0> (ø)
:arrow_down:

.../co/elastic/apm/impl/transaction/AbstractSpan.java
89.79% <ø> (ø)
20 <0> (ø)
:arrow_down:

...a/co/elastic/apm/impl/context/AbstractContext.java
100% <100%> (ø)
3 <3> (?)

...a/co/elastic/apm/impl/transaction/Transaction.java
79.48% <100%> (+1%)
24 <1> (ø)
:arrow_down:

...n/java/co/elastic/apm/impl/error/ErrorCapture.java
64% <100%> (ø)
10 <0> (ø)
:arrow_down:

...o/elastic/apm/impl/context/TransactionContext.java
100% <100%> (ø)
7 <2> (?)

...lastic/apm/report/serialize/DslJsonSerializer.java
84.61% <100%> (+0.05%)
103 <0> (ø)
:arrow_down:

.../java/co/elastic/apm/impl/context/SpanContext.java
100% <100%> (ø)
4 <2> (?)

.../elastic/apm/servlet/ServletTransactionHelper.java
84.33% <100%> (ø)
26 <0> (ø)
:arrow_down:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 446eaba...5b7c2aa. Read the comment docs.


Add docs for deploying with yaml

Right now in the README.md, it just has cli commands to deploy. I've added a yaml deployment file so docs should be added how to deploy with that
kubectl create -f deployment.yaml

No there's not a PR. The yaml file has been added to the GitHub repo


External transport discussion

Continuing from #1, we need to figure out the story for use case (2):

It needs to allow users to attach credentials to an HTTP object of their choosing.

The usage of this is external-only. This is the means by which users will make authenticated requests. We want to initially support urllib3, but we should be aware of anything that will cause issues with a requests implementation.
How oauth2client does this
oauth2client only supports httplib2. The way that it accomplishes this is by monkeypatching an existing httplib2.Http object's request method.

The user must construct the http object themselves (this gives them the opportunity to configure settings such as SSL and proxies).
oauth2client modifies the object in place and returns it. The original request method is only available as a closure (via http.request.func_closure[0].cell_contents, which is insanity).

How oauth2client's transport refactor did it.
In the transport refactor, I modified this behavior slightly. Instead of monkeypatching, it wrapped the http object using an AuthedHttp wrapper class that has a common interface with httplib2.Http.

The user still must construct the http object themselves.
oauth2client returns a AuthedHttp wrapper instance that uses the original http object under the covers. The original http object is not modified in any way.

What we could do
We could largely adopt the second method without much heartache, as long a we're still okay with the wrapper pattern:
import google.auth
from google.auth.transport.urllib3 import AuthedHttp
import urllib3

http = urllib3.PoolManager()
credentials, _ = google.auth.default()
authed_http = AuthedHttp(credentials, http)

Similarly with requests:
import google.auth
from google.auth.transport.requests import AuthedSession
import urllib3

session = requests.Session()
credentials, _ = google.auth.default()
authed_session = AuthedSession(credentials, session)

We could also have these items construct their own underlying object using sane defaults if none is specified:
# Creates a PoolManager behind the scenes
authed_http = AuthedHttp(credentials)
# Creates a Session behind the scenes.
authed_session = AuthedSession(credentials)

The only concern I have about this is the long import path (google.auth.transport.urllib3). I can't think of a good, clean way to do something like oauth2client's authorize and I'm not sure that I want to.
Thoughts? Concerns? Alternatives?

I like what you've constructed above.

I like what you've constructed above.

Yay!
Any thoughts on this:

The only concern I have about this is the long import path (google.auth.transport.urllib3). I can't think of a good, clean way to do something like oauth2client's authorize and I'm not sure that I want to.

Long import paths don't bother me. You can make transport the thing that people import.

You can make transport the thing that people import.

How so? Import all the submodules?

Yes.

@jonparrott Is this the expected pattern for people to follow when they need to attach a custom http object to a google.auth.default() request? I'm trying to sort out how to run google-auth through a proxy; using a proxy is a pretty common use case, so if this is the right way to do it, some documentation pointers would be very helpful here:
https://google-auth.readthedocs.io/en/latest/user-guide.html

If you're using a proxy and the requests transport you can just set the standard HTTP_PROXY and HTTPS_PROXY environment variables.


Has freshmaker been retired from Fedora?

@qixiang
Hi Qixiang:
I can not find the higher fedora release than fedora30 for freshmaker in fedora koji.
And I find that freshmaker has been retired from Fedora in fedora dist-git.
The newest tag of Freshmaker in github is v0.1.2 which was released on 21 May 2018, but the code is still updated in github.
So, I want to know:
1, How can I install freshmake on fedora31 or higer fedora release?
2, Has freshmaker been retired from Fedora? If yes, what service or software is uesd to replace freshmaker?

Hi @Cav4ever:

1, How can I install freshmake on fedora31 or higer fedora release?
2, Has freshmaker been retired from Fedora? If yes, what service or software is uesd to replace freshmaker?

We retired Freshamaker in Fedora a while ago because the plan of using Freshmaker in Fedora has been changed, so we don't do packaging for it anymore. Freshmaker was never used by Fedora infra at all, so I think there is no service for replacing Freshmaker, but there could be some services that are responsible for rebuilding particular artifacts, I'm not sure about this.
You can still find the latest code of Freshmaker on github, and run it in container, however it's designed to work with several Red Hat internal services, so I doubt it can work for your purpose.

@qixiang
Hi Qixiang:
Thank you for your quick reply.

so I think there is no service for replacing Freshmaker, but there could be some services that are responsible for rebuilding particular artifacts, I'm not sure about this.

I need the functions from freshmaker on fedora31 or higer release.
So, I wonder what service or software can complete the work of freshmaker.
But, I cannot find any useful information by lookup "freshmaker" or "freshmaker fedora31" by google.
Would you please give me some information about where can I find "what service or software can complete the work of freshmaker"?

Hi @Cav4ever ,
It depends what functionality you're looking for, the main functionality Freshmaker provides is rebuilding container images when there are some updates for rpms in container images. Take Fedora infrastructure as an example, the rpms updates are shipped via bodhi (https://bodhi.fedoraproject.org), with updates info from bodhi, you can try to figure out which container images are impacted by the updates and then rebuild the container images via koji (https://koji.fedoraproject.org/koji/). Freshmaker automates a similar workflow along with several other services.

@qixiang
Hi Qixiang:
The situation I want to use freshmaker is in MBS(Module Build Service).
Freshmaker SOP describes the application of freshmaker in MBS.
So, what service or software can complete the work of freshmaker for MBS?

The situation I want to use freshmaker is in MBS(Module Build Service).
Freshmaker SOP describes the application of freshmaker in MBS.
So, what service or software can complete the work of freshmaker for MBS?

Ah, Freshmaker dropped the feature of rebuilding modules a long time ago, it only supports rebuilding container images and operator bundles now, I'm not sure whether there is any tool or service exist for rebuilding modules.

@qixiang
Hi Qixiang:
Would you please give me some information about where can I find "what service or software can complete the work of freshmaker for MBS"?
Maybe some other committers' or maintainers' Email adderess I can ask for assist.
Any suggestion is appreciated.

@Cav4ever sorry, I don't know if there is any service/software exists for this purpose, so I have no suggestion on this.

@Cav4ever sorry, I don't know if there is any service/software exists for this purpose, so I have no suggestion on this.

Thank you for your quick reply and kind help.

@Cav4ever btw, I believe you already know that MBS is a service for building modules (but not for rebuilding modules for rpm updates), in case you don't know this, you can check:

https://pagure.io/fm-orchestrator/
https://docs.fedoraproject.org/en-US/modularity/

@qixiang
Yes, I know that MBS is a service for building modules.
And from Freshmaker SOP, I know freshmaker can trigger rebuilds for MBS.

Module Builds
When a spec file changes on a particular dist-git branch, trigger rebuilds of all modules that declare dependencies on that rpm branch.
Freshmaker deals with this by watching the bus for dist-git fedmsg messages. When it sees a change on a branch, it looks up the list of modules that depend on that branch, and requests rebuilds of them in the MBS.

So, I am trying to find "what service or software can complete the work of freshmaker for MBS on fedora31 or higer release".


raidboss: additional p12s p1 triggers

Adds triggers for:

Clones north/south during Paradeigma 1
Clone line cleaves (e.g. inside east/outside west) during Paradeigma 2
Glaukopis tank cleaves/swap
Parthenos line cleave (during Superchain IIB)

Hi, sorry for making you fix conflicts, but I wanted to get in the tether/tower engravement patch first.  Would you mind rebasing on top of that?

Hi, sorry for making you fix conflicts, but I wanted to get in the tether/tower engravement patch first. Would you mind rebasing on top of that?

Done & all good.  It finally gave me an excuse to figure out why i've had problems with rebasing in the past (local version in VS2022 needed force-push enabled), so at least that's fixed 😄

Done & all good. It finally gave me an excuse to figure out why i've had problems with rebasing in the past (local version in VS2022 needed force-push enabled), so at least that's fixed 😄

You could also choose to git merge instead of git rebase and that would avoid needing to force push, for what it's worth.


Abandonware

Project has been abandoned by the owner.

Anybody aware of good alternatives? This solved a problem & sad to see it abandoned.

@kc22033 I had to include a new version of our API that implements JSON API in Laravel 5.3. As I saw this project deprecated I decided to use an implementation of JSON API that is framework agnostic: https://github.com/neomerx/json-api

@kc22033 I had to include a new version of our API that implements JSON API in Laravel 5.3. As I saw this project deprecated I decided to use an implementation of JSON API that is framework agnostic: https://github.com/neomerx/json-api

Thanks @Luisetelo . Did you have any issues transitioning over? There seems to be a reference implementation in Laravel here https://github.com/InactiveProjects/limoncello-collins/ but it may be out of date.

Hi @60days, as you probably know, you need two operations, encoding and decoding to send and receive requests in JSON API format. That library offers you an encoder, but you need to create your own decoder which can be big issue (it has some, but are very simple). Futher reading here. That is for me the main drawback.

Not abandoned... just saying.

@nilportugues It has been half a year.

@mpash this project is being used i production by companies and are happy with it. So please, stop bitching.
If you found a bug, provide an issue and a PR fixing it. Or at least data to reproduce the bug.


paramiko.PasswordRequiredException: Private key file is encrypted

unable to run the attack -- the private key is not encrypted.

Having the exact same issue. tried -l <username_i_can_ssh_with>, and still get that error.


Rename private properties with names matching library classes

Sometimes these private properties appear in import quick fix

maybe they could be renamed to _dataFrame even? That would further hint that they're not supposed to appear and maybe make them appear even further down the list

I wouldn't go as far because it seems like a bug on IDEA side to suggest private properties anyway, and lowercase properties do not appear when DataFrame is typed

I wouldn't go as far because it seems like a bug on IDEA side to suggest private properties anyway, and lowercase properties do not appear when DataFrame is typed

true, but I think a lot of users will create variables named df or dataFrame, which will now mix with these private ones.


can't run webserver

bash-3.2$ v run install_publisher.v develop
==================
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
...
==================
(Use `v -cg` to print the entire error message)

builder error:
==================
C error. This should never happen.

If you were not working with C interop, please raise an issue on GitHub:

https://github.com/vlang/v/issues/new/choose

You can also use #help on Discord: https://discord.gg/vlang

@despiegk  this is not valid any more no ?