[BUG] Migration documentation leads to misfunctioning migrations

Describe the bug
Example for iterative migration will lead to migration being not applied to any document.
To Reproduce
class Tag(BaseModel):
    color: str
    name: str

class OldNote(Document):
    name: str
    tag: Tag

    class Settings:
        name = "notes"

class Note(Document):
    title: str
    tag: Tag

    class Settings:
        name = "notes"

makes an impression that if there is a model called Car, the name should be 'cars' (it is like this in Django for example). Instead, if no other name was specified, the actual collection for Car is 'Car', the same name as the model name. This leads to a situation, where migration creates a new collection named cars and so iterative migration iterates over a new empty collection, resulting in nothing happening. This is very confusing for new users, as they see no output and don't know if migration ran at all.
Besides, as it's probable that the user will rename the model to some versions of it, like NewCar and OldCar, it's beneficial to mention that the name argument is then crucial to point to the existing collection.
Expected behavior
I would prefer migrations not to create new collections implicitly at all. If that is not possible, update the documentation to remove ambiguity.

Hi! Thank you for the catch! It should be mentioned in the doc. I'll think about if the collection should be or should not be created at this case.


⚠ Adacta-fintech.com has degraded performance

In 1c98793, Adacta-fintech.com (https://www.adacta-fintech.com) experienced degraded performance:

HTTP code: 500
Response time: 1765 ms

Resolved: Adacta-fintech.com performance has improved in 908ab17.


Sni/less todo clean up

fixes #33

Coverage remained the same at 86.296% when pulling ab8b181d62d43e6d0c17da06f2b01e6b0340796f on sni/less-todo-clean-up into a497fa627ee91464f312cf63280578785b1a112d on master.


[feature] Batch-collect

When an app needs to send many events, it'd be desirable to have some way of batching them, instead of having to make a POST request for each.
I'm thinking of either modifying POST /api/collect to also accept an array of pageview and event payloads, or creating a new POST /api/collect/batch endpoint.
It could impose limits, like Google Analytics does: https://developers.google.com/analytics/devguides/collection/protocol/v1/devguide#batch
What do you think?

The problem is we don't know if a user will return or will trigger any events. So if we wait for a batch to send, we could lose that data.


No payment options - Prestashop Mollie module

Expected behavior
Show payment method
Actual behavior
No payment options are shown, Mollie does not appear. After upgrading from Prestashop 8.0.5 to Prestashop 8.1.2
Steps to reproduce the behavior
After the order steps during the checkout no payment options shows up
<img width="1450" alt="Schermafbeelding 2023-12-12 om 08 25 49"
Environment

PrestaShop version: 8.1.2
Mollie module version: 6.0.4
PHP version: 8.1.25

See printscreens. How can I fix it?

Hi there @Carindesign,
Most likely the issue is related to the upgrade, something could have been corrupted.
Could you please try to reset the Mollie module to see if the issue is fixed?
Keep in mind that all of the module data will be set to default states.
I will be waiting for your update!
Best Regards,
Invertus Support team.

@justelis22
Thank you for your answer.
I have also reset de Mollie module.
Best regards

Hi @justelis22,
I have send you an email.
Best regards,

Hi @justelis22
Do you have seen the email?
Best regards

Hi there @Carindesign,
We have not received an email from you. Could you please retry sending the information?
Waiting for your update!
Best Regards,
Invertus Support team.

Hi @justelis22
I have sent a new email from the email address<EMAIL_ADDRESS>Best regards,

@Carindesign,
I have not received an email from that address, but wrote you an email to<EMAIL_ADDRESS>Best Regards,
Invertus Support team.


Github Action / CI Setup for backend service

Description

Add a workflow to build backend service code / publish docker image to docker hub, under tractusx org.
Add path filter to trigger build only in case of changes in backend-service directory and sub directory.

Related to eclipse-tractusx/sig-release#314

Not needed anymore, backend-service docker image will be used locally.


Bundle Identity creation in a single eth call

Seems travis is breaking on testworld with an unrelated problem not introduced by this pull request

@vlopes11 I believe the error is valid, looks like the test case is trying to add a key that was possible added before as part of the createIdentity call (since we bundle all together).
Since we are adding every key as part of a new identity creation this test is hard to trigger. You could potentially remove the p2p key from the list of keys that are passed in the account and see if you can trigger this test. Otherwise, maybe revoke the key and assert that the error instead of being p2p key missing is key revoked or alike,

@vlopes11 any update on this ?

closing this. Fixed this in #1460

closing this. Fixed this in #1460


Run build_registry_docs as part of SDK build

https://github.com/pulumi/pulumi-snowflake/issues/752 revealed that we weren't running registry docs build on pull requests.
This addresses that issue. Index docs will now be built on pull requests in CI.

I would implement this via the Makefile:
-build_sdks: build_nodejs build_python build_dotnet build_go build_java build_registry_docs
+-build_sdks: build_nodejs build_python build_dotnet build_go build_java

-tfgen: install_plugins upstream tfgen_no_deps
+tfgen: install_plugins upstream tfgen_no_deps build_registry_docs\

It feels like generating docs is more in the make tfgen category (with the schema) then as an SDK artifact.

Unfortunately @iwahbe's suggestion won't work - make registry_docs depends on make tfgen (having the provider binary, with edit rules).

It doesn't look like we're doing anything with the result of the build
That's right, it's a plain "is this still valid" check

If we're just trying to assert that the files are up to date
Not quite - my approach was perhaps a bit simplistic - I want to run this as a separate check that would fail if there were docs changes incompatible with docs replaces that have a hard fail baked into them.

It sounds like two things should happen here:

Perhaps run this as part of prerequisites so we don't run it four times 😅
show the dependency on make tfgen in the Makefile.

Unfortunately @iwahbe's suggestion won't work - make registry_docs depends on make tfgen (having the provider binary, with edit rules).

This works for me (tested in random from a cleaned repo):
 Makefile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Makefile b/Makefile
index 455c4723..225d1d7a 100644
--- a/Makefile
+++ b/Makefile
@@ -31,7 +31,7 @@ development: install_plugins provider build_sdks install_sdks

 build: install_plugins provider build_sdks install_sdks

-build_sdks: build_nodejs build_python build_dotnet build_go build_java build_registry_docs
+build_sdks: build_nodejs build_python build_dotnet build_go build_java

 install_go_sdk:

@@ -99,7 +99,7 @@ build_python: upstream
 		../venv/bin/python -m build .

 # Run the bridge's registry-docs command to generated the content of the installation docs/ folder at provider repo root
-build_registry_docs:
+build_registry_docs: upstream tfgen_build_only
 	$(WORKING_DIR)/bin/$(TFGEN) registry-docs --out $(WORKING_DIR)/docs

 clean:
@@ -155,7 +155,7 @@ test_provider:
 	@echo ""
 	cd provider && go test -v -short ./... -parallel $(TESTPARALLELISM)

-tfgen: install_plugins upstream tfgen_no_deps
+tfgen: install_plugins upstream tfgen_no_deps build_registry_docs

 tfgen_no_deps: export PULUMI_HOME := $(WORKING_DIR)/.pulumi
 tfgen_no_deps: export PATH := $(WORKING_DIR)/.pulumi/bin:$(PATH)

It incurs minimal overhead of make tfgen (only the actual docs generation is a new target) and builds correctly from a clean repo.

I'd been holding off on this due to https://github.com/pulumi/ci-mgmt/pull/1151 - with those changes, we have build_registry_docs as a separate Make target dependent on make schema(tfgen) and we can run it as-is in the prerequisites workflow.


Get-DbaMaxMemory examples updated

Type of Change

[ ] Bug fix (non-breaking change, fixes #)
[ ] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] Nunit test is included
[X] Documentation
[ ] Build system

Purpose
Better examples

I'll merge and fix conflict 👍  Thank you both.


fix: Prevent update doc title from partial if not present

fixes #2243

Oh that's a good catch! Let's add a test case for this and then it's ready to land 👍

Do you have a suggestion of test file to add this or i can create a new one for this case?


Sending a formatted link to client

I have tried:
1. session.send('[display text] (http://ww.bing.com)')
2. session.send('[display text (http://ww.bing.com)]')
3. session.send('(display text) [http://ww.bing.com]')

What is the correct way to send formatted links?

[display](http://link)
http://docs.botframework.com/connector/message-content/#navtitle
NOTE: Some channels (like SMS) don't support named links, and so it will render as
display http://link

Does this work without bot-connector? I am using BotBuilder for Node.

No, if you are binding directly to an environment then it is up to you to figure out how to render in that environment.
The connector acts as layer to isolate you from having to do that, and it does that by translating from markdown to the target environment.
Skype doesn't support markdown, but it does support `bolditalic and quotedtext strikethrough"

Skype doesn't support markdown, but it does support bolditalic and quotedtext strikethrough

So currently there is no way to send a formatted link via SkypeBot?
Also, could you point me in the direction of where it is documented how to render in the skype environment, specifically (other than the formatted link) I am also trying to send Images to client without the shaded image and link source text on the bottom left corner.

skype currently will add better support in the near future.

Facebook also doesn't support named links, as I have found today.


Summary tab scss + bug fix

They way I set up grace-period deduction caused it to render weird on the marker's summary tab. This was because all the containers were being rendered in the grace-period deduction page.
Improved general visual aspects on summary tab as well.

@DecathectZero you may have missed that there is still some work to be done on this pull request.


Remove version: FreePascal.FreePascalCompiler version 3.2.0

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://sourceforge.net/projects/freepascal/files/Win32/3.2.0/fpc-3.2.0.i386-win32.cross.x86_64-win64.exe/download
OK
(Automated message - build 923)

Close with reason: Package still available.;


Layouting Functionality in the keip canvas

The layout feature is a feature intended to allow automatic switching from vertical to  horizontal graphs and the other way around by pressing either the vertical or horizontal layout buttons.
The reason this was implemented was to allow for users to be more free in the way they wanted to created their EIP flow diagrams for example if they wanted a vertically aligned graph instead of a horizontally aligned graph.

Changes

added functionality to the renderHandles function to switch the handles based on the orientation of the graph and type of node (source, sink, pass thru)
Created new css styles for top/bottom handles
Created a LayoutType definiton and added a layout field to the appStore. Also created corresponding useGetLayout() function in the store file.
Created an updateLayout function within AppActions interface that utilizes the updateFlowLayout in the new layouting directory. Also deleted the nodeLayouting file and refactored the code in LLMclient in the assistant dir to utilize the new updateFlowLayout method.
Added two new buttons in the flowCanvas to implement the horizontal/vertical orientation switching.

Can we add some description to the PR? Just a short summary of the feature that was added, why it was added, and the changes made to enable the new functionality should be good. I'll create a PR template to encourage as guidance for future PRs.

Merging this. Thank you!


StorageFolder status after DeleteAsync()

Please document if the StorageFolder can still be used after DeleteAsync() call.
Please add an example to reset an existing folder by deleting and recreating it.

Détails du document
⚠ Ne pas modifier cette section. C’est obligatoire pour docs.microsoft.com ➟ Liaison des problèmes GitHub.

ID: 04061719-8b57-32dd-ee2a-92d303d0fd94
Version Independent ID: 6a1c5dbc-4ec0-a1f3-f62f-4b4de8bd4b28
Content: StorageFolder.DeleteAsync Method (Windows.Storage) - UWP app developer
Content Source: https://cpubwin.visualstudio.com/DefaultCollection/windows-uwp/_git/winrt-api-build?path=%2fwinrt-api-build%2fwindows.storage.storagefolder.yml&version=GBlive&_a=contents
Service: unspecified
Product: windows
GitHub Login: @wdg-dev-content
Microsoft Alias: wdg-dev-content

Thanks for submitting your feedback and I apologize for the delayed response. I see that updates have not been made since the creation of this Issue so I went ahead and created an internal work item for new content. The timeline for this may vary, so I will go ahead and close this and circle back when the remark or the code snippet have been added.
Though the Issue will be marked as Closed, I will monitor any replies that come afterwards so treat this like an open Issue. Many thanks!


meme-maker: Add version 0.1

This PR adds meme-maker to extras

[ X] I have read the Contributing Guide.

The project looks quite new, it doesn't fit criteria for Extras bucket in terms

Reasonably well-known and widely used (e.g. if it's a GitHub project, it should have at least 100 stars and/or 50 forks)

The project looks quite new, it doesn't fit criteria for Extras bucket in terms

Reasonably well-known and widely used (e.g. if it's a GitHub project, it should have at least 100 stars and/or 50 forks)

Perfectly understandable. I can always re-apply when I get this a bit more known. Thank you.

Closing this for now.
Feel free to can come back at a later time when the Extras bucket requirements will be met (it's more preferable to open package request first).


add jknet with different versions (MaxPool and Concat), controlled by…

… param link-type

@YeWR Please give the results of JKNet on Cora, Citeseer, and Pubmed dataset.

Cora: 81.2
Citeseer: 68.7
Pubmed: 75.6


Add support for disallowing overriding query properties

Ability to lock query properties so they cannot be set in the query request. For example, an app might set different properties in queryProfiles, but end-users of the API can pass overrides. There should be support for disallowing overriding properties. For example ranking.model or input(query).

I believe that you can do this with
<query-profile id="default">
    <field name="ranking.model" overridable="false">my-ranking-model</field>
</query-profile>

https://docs.vespa.ai/en/query-profiles.html#overrides


Add rashiyadhruv information

Thanks a lot for the session

@rashiyadhruv you have added the data in the wrong format. Change the format according to README.


Build doesn't pass because of a /

Describe the bug
The build isn't working because it can find /src/assets/img/icon-lightbulb.svg.
Cf. screenshot part and also the Netlify tag on the main page of the project indicate that build doesn't pass.
From what I saw, it's coming from your commit of last week: https://github.com/TylerMRoderick/fernfolio-11ty-template/commit/2e8d9287420310c3e2808d38188e9d395ccd7d10#diff-01e14f9177ecbd47a5a24c41c36e833459ea3c2d765dab88f60dd22fb5d0cbc2
You added a / in path (I don't understand why, but maybe you know) and build doesn't found the asset since.
It works if you remove the slash.
To Reproduce
Steps to reproduce the behavior from fresh install:

npm i
npm start

Expected behavior
This beauty.

Screenshots

Desktop (please complete the following information):

OS: MacOS
Browser: Firefox
Version: 116.0.1 (64 bits)
Node: v20.5.0

Additional context
Your theme is awesome, congrats for the nice work you did. ☺

Thank you for the issue, oversight on my side to not catch this quicker.
It looks like @kpost added a fix that works great so I just merged that in. Big thank you to him!
Closing issue as resolved.


Python's async IO or threads to make sure API requests aren't blocking

Currently, the SDK doesn't consider using Python's async IO or threads to make sure API requests aren't blocking. This could be okay for the time being but going forward, I think it will make the SDK a lot faster if we can do these asynchronously.

Closing the issue as this repo is no longer maintained.


Consider to associate "browser storage" with profile

Testing #158809
some UI state is not kept in settings but in browser storage.
For example whether the default action in the editor's drop down menu is "Debug" or "Run".

It would be great if that state would be loaded from a profile, so that an empty profile would always start from a clean state.

@jrieken Does this belongs to your area?

Yeah, I merged @weinand PRs for this ;-) This specific features works with workspace storage: https://github.com/microsoft/vscode/blob/eed1b6ac4907e125fa9188e7a3253bc94cf7aac1/src/vs/platform/actions/browser/menuEntryActionViewItem.ts#L353. I assume profiles are only about global storage, right?

I assume profiles are only about global storage, right?

Yes


Create language filter

When I'm presenting an application built with ChatterBot, having this filter enabled will make it so that the chat bot cannot return a response with a swear in it :)
That's what I get for using Twitter as a source of training data :dizzy_face:
WIP status:

[ ] Resolve issue with random response and base query

Priority for filters?

[ ] Resolve issue with response data containing results that we want to ignore

How can I use this swear words filter?

Hi Thomas, it currently can't be used because I never finished these
changes. I've been meaning to work on it but I've been busy creating and
updating other parts of ChatterBot.

These kinds of filters are ridiculous, just let the thing grow as it should, if it says something inappropriate oh well.

 Instead of creating a filter for foul language, I'm going to introduce a more generic change that will allow a list of words to be provided such that the chat bot will not choose a response there the text includes one of those words. It will be up to developers using ChatterBot to choose what those words should be.


docs: add warning from #721

Information from https://github.com/davidkpiano/xstate/issues/721#issuecomment-540954522, I think this is worth calling out in the docs because I was really surprised at this behavior but according to @Andarist it's part of the SCML spec.

Let's resolve this holistically with better dev-time errors/warnings.


Crashing on Windows 10 for iOS

And Git tells that not a single modification has been done

Same

How are you building iOS apps on Windows? It's not supported by React Native?

So you are meaning that I need to have a Mac in order to update a string indicating a version number in some file ;) ?

No, but in case you haven't noticed, this package is prefixed with react-native-, so one would assume it would follow the platform support of the react-native package. If you want to "update a string in some file", you can write your own script ;)
I would like to look into this, but before I start spending my free time doing it, it would be nice to have some more info, like the question I asked.

In case you haven't noticed,  I'm not the only one that wants to increase their app version for Android AND iOS at the same time when coding in Windows before using a Mac and building it instantly after pulling the code.
Coding in Windows, building Android on Windows and building iOS on a rented Mac.

I noticed and that's why I asked the question.
Anyway, thanks for providing some info about your setup. Now I can see how you're using the tool and how Windows users might be using RN with two machines. It makes sense to support Windows right away and I'll look into it.

Thanks for your attention to this issue. I'm seeing no reason why this may fail on Windows, maybe the pbxproj parser ?

The pbxproj parser should be pretty cross platform. Actually added it to start supporting Linux and move away from Apple's agvtool. But there are some shell commands executed with node that might be causing the issue. There's actually a open PR #44 to deal with Git tag updating not working on Windows. There might be more commands causing the issue.

Hi there!
As @VinceBT has already mentioned, it is pretty common for a react-native app developer to have two build machines. Personally, I use Windows 10 notebook to build Android app version and Macbook to build for iOS. I would use the same version number for both platforms and I would like to have an opportunity to bump version on any of the notebooks.
What is interesting: I have 2 react-native apps in a single repository, each of them targeting 2 versions: iOS and Android. For one of the apps, react-native-version fails with the undefined error message mentioned above. For the other one, it updates both android build.gradle and iOS Info.plist/pbxproj just fine.
I'm willing to contribute, so I'm going to have a closer look at this issue today.

Looks like it's a pbxproj-dom issue in my case.
Exception is thrown here:
const xcode = Xcode.open(path.join(projectFolder, "project.pbxproj"));
Xcode.js:
Xcode.open = function (path) {
var xcode = new Xcode();
xcode.document = pbx.parse(parser.parse(fs.readFileSync(path).toString()));
xcode.path = path;
return xcode;
};
parser.parse throws this:
SyntaxError: Expected """, "\'", "\"", "\n", or [^\"] but "\" found.
at peg$buildStructuredError (C:\Users\cvv\Projects\react-native-version\node_modules\pbxproj-dom\parser.js:318:12)
at Object.peg$parse [as parse] (C:\Users\cvv\Projects\react-native-version\node_modules\pbxproj-dom\parser.js:921:11)
at Function.Xcode.open (C:\Users\cvv\Projects\react-native-version\node_modules\pbxproj-dom\xcode.js:16:43)
at C:\Users\cvv\Projects\react-native-version\index.js:241:25
at new Promise ()
at Object.version (C:\Users\cvv\Projects\react-native-version\index.js:170:9)
at Object. (C:\Users\cvv\Projects\react-native-version\cli.js:50:5)
at Module._compile (module.js:632:14)
at Object.Module._extensions..js (module.js:646:10)
at Module.load (module.js:554:32)
I'm going to double-check pbxproj structure.
It would be great if react-native-version could just pass the error to the console instead of vague "[RNV] undefined" message

@cvvspb Thanks for looking into it.
For the case of 2 RN projects in one repo. Could you provide a sample tree view to see how the repo is structured and also the method how you execute RNV?

@stovmascript, the repo structure is very simple:
/RootFolder/
/RootFolder/Project1 (react-native app 1)
/RootFolder/Project1/js/....
/RootFolder/Project1/android/....
/RootFolder/Project1/ios/....
/RootFolder/Project1/package.json
....
/RootFolder/Project2 (react-native app 2)
/RootFolder/Project2/js/....
/RootFolder/Project2/android/....
/RootFolder/Project2/ios/....
/RootFolder/Project2/package.json
...
/RootFolder/Backend (Project3 - node.js app)
...
I executed RNV in each of the projects separately.
As I've mentioned earlier, the problem was in project.pbxproj file - it got corrupted after some "react-native link" commands. XCode didn't notice invalid entries but pbxproj-dom did throw an exception while parsing.
I've fixed project.pbxproj file and now it works OK!

@cvvspb Ok. Yeah, I admit error forwarding needs some work (#15).

There is one more thing: there is an issue with git tags if someone uses the same approach as I do (two or more separate apps in a single repo with different versions).
Basic setup doesn't allow this, 'cause if the version of, say, app 1 is 0.5.0 and version of app 2 is 0.4.5 and you want to bump app 2 to 0.5.0 git wouldn't allow to have 2 tags like "v0.5.0"
I had to prefix tags with project name to solve the issue, like: "Project1-v0.5.0", "Project2-v0.5.0"
I could write a little how-to if required.

@VinceBT @cvvspb Hey guys, can you update and test the new version of RNV (2.5.0)? It contains the aforementioned PR #44, which fixes the Git tag issue on Windows. I just started looking into this issue and testing on Windows and everything seems to be working:

Tested on the same fixture I run tests on.

Having almost the same error than before.
Its is not saying [RNV] undefined anymore now.
$ npm version major
v2.0.0

><EMAIL_ADDRESS>postversion C:\Users\AdminUser\RandomProject
> react-native-version --never-amend

[RNV] Versioning Android...
[RNV] Android updated
[RNV] Versioning iOS...

  Usage: cli [options] [projectPath]

  Version your React Native app in a `npm version` fashion.

  Options:

    -V, --version                output the version number
    -a, --amend                  Amend the previous commit. Also updates the latest Git tag to point to the amended commit. This is done automatically when react-native-version is run from the "version" or "postversion" npm script. Use "--never-amend" if you never want to amend.
    --skip-tag                   For use with "--amend", if you don't want to update Git tags. Use this option if you have git-tag-version set to false in your npm config or you use "--no-git-tag-version" during npm-version.
    -A, --never-amend            Never amend the previous commit.
    -b, --increment-build        Only increment build number.
    -B, --never-increment-build  Never increment build number.
    -d, --android [path]         Path to your "android/app/build.gradle" file. (default: android/app/build.gradle)
    -i, --ios [path]             Path to your "ios/" folder. (default: ios)
    -L, --legacy                 Version iOS using agvtool (macOS only). Requires Xcode Command Line Tools.
    -q, --quiet                  Be quiet, only report errors.
    -r, --reset-build            Reset build number back to "1" (iOS only). Unlike Android's "versionCode", iOS doesn't require you to bump the "CFBundleVersion", as long as "CFBundleShortVersionString" changes. To make it consistent across platforms, react-native-version bumps both by default. You can use this option if you prefer to keep the build number value at "1" after every version change. If you then need to push another build under the same version, you can use "-bt ios" to increment.
    -s, --set-build <number>     Set a build number. WARNING: Watch out when setting high values. This option follows Android's app versioning specifics - the value has to be an integer and cannot be greater than<PHONE_NUMBER>. You cannot decrement this value after publishing to Google Play! More info at: https://developer.android.com/studio/publish/versioning.html#appversioning
    -t, --target <platforms>     Only version specified platforms, eg. "--target android,ios".
    -h, --help                   output usage information
[RNV] Done, with errors.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>postversion: `react-native-version --never-amend`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postversion script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      C:\Users\AdminUser\AppData\Roaming\npm-cache\_logs\2018-04-23T15_03_26_167Z-debug.log

@VinceBT I tried to set up my project like yours, but I'm still not able to reproduce the problem.

Could you provide a sample project?

I just tried again on a brand new RN project and again, no problems. There must be something specific that's throwing off the pbxproj parser...

In my case I was removing tvos/watch builds from my project and it turned out I somehow still have:
INFOPLIST_FILE = "MyApp-tvOS/Info.plist";

in ios/MyApp.xcodeproj/project.pbxproj while MyApp-tvOS/Info.plist file was already deleted.
I figured that little fix here index.js#L399
log({ ...{ style: 'red', text: String(err) }, ...err });

should print all unexpected errors.

@suside That would make sense becase the project.pbxproj is used to build a list of Info.plist files which are then read, but there's no error handling in case the file doesn't exist.

@VinceBT @cvvspb Hey guys, check out the new version (2.5.2) that's out now on npm. It should now print a meaningful error message in the console.
Feel free to reopen, if a Windows related issue still persists.

After your commit, I finally get the error but I guess it would make more sense to print the full stacktrace.
I replaced err.toString() by err.stack in https://github.com/stovmascript/react-native-version/blob/d6729d6efe621f7ebb144197ea8582fc9d166e97/index.js#L400
Here is what I've got
[RNV] Versioning iOS...
[RNV] SyntaxError: Expected "\"", "\\'", "\\\"", "\\n", or [^\\"] but "\\" found.
    at peg$buildStructuredError (C:\Users\AdminUser\RandomProject\node_modules\pbxproj-dom\parser.js:318:12)
    at Object.peg$parse [as parse] (C:\Users\AdminUser\RandomProject\node_modules\pbxproj-dom\parser.js:921:11)
    at Function.Xcode.open (C:\Users\AdminUser\RandomProject\node_modules\pbxproj-dom\xcode.js:16:43)
    at C:\Users\AdminUser\RandomProject\node_modules\react-native-version\index.js:266:25
    at new Promise (<anonymous>)
    at Object.version (C:\Users\AdminUser\RandomProject\node_modules\react-native-version\index.js:175:9)
    at Object.<anonymous> (C:\Users\AdminUser\RandomProject\node_modules\react-native-version\cli.js:56:5)
    at Module._compile (module.js:662:30)
    at Object.Module._extensions..js (module.js:673:10)
    at Module.load (module.js:575:32)

Since the parser doesn't give the line he thinks there is a problem on, I cannot give a look but I've used kin to verify if my pbxproj was correct and it said it was.

Found fix in https://github.com/stovmascript/react-native-version/issues/52#issuecomment-393343784


[PF-1289] Make deployment sub-dirs under rendered

Moves files like test-user-account.json from rendered to rendered/broad. This makes it easier to run tests against different deployments. Before this PR:
render-config.sh
run test against Broad (`-Pserver=broad-dev -Ptestconfig=broad`)
render-verily-config.sh   (from a different repo)
run test against Verily (`-Pserver=verily-devel -Ptestconfig=verily`)

I had to run render-config.sh to switch files like test-user-account.json from Broad to Verily.
After this PR:
run test against Broad (`-Pserver=broad-dev -Ptestconfig=broad`)
run test against Verily (`-Pserver=verily-devel -Ptestconfig=verily`)

Tested: Ran a test using Broad and Verily testconfigs, without running render-config.sh.

Friendly ping for Zach


[SPARK-29380][ML] RFormula avoid repeated 'first' jobs to get vector size

What changes were proposed in this pull request?
get the first row lazily, and reuse it for each vector column.
Why are the changes needed?
avoid unnecssary first jobs
Does this PR introduce any user-facing change?
no
How was this patch tested?
existing testsuites & local tests in repl

Test build #111886 has started for PR 26052 at commit f5cab35.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16867/
Test PASSed.

Test build #111886 has finished for PR 26052 at commit f5cab35.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111886/
Test PASSed.

Merged to master


LEGO Pirates of the Caribbean (Europe)

Game Name (and version if necessary)
LEGO Pirates of the Caribbean
Hardware Specs (If necessary)
No response
Operating System
Windows 11
Game State
git version 5255fac . Playable no sound or fmvs
Screenshots
youtube video
Additional information
No response

it is not


Disabling stack destructors causes stack deletion with likely service outage and data loss

Affects versions 0.28.0 through 0.46.1.

Introduced in 0.28.0 in #46
Fixed in 0.46.2 via #85

bug
After setting var.stack_destructor_enabled: true, simply setting var.stack_destructor_enabled: false will cause the resources provisioned by the stack to be destroyed (terraform destroy).
explanation
The spacelift_stack_destructor resource is a special resource which, when deleted, will delete all resources in the stack:
https://github.com/spacelift-io/terraform-provider-spacelift/blob/6b9411707f6243ffa956e06bdaa1659820250c35/spacelift/resource_stack_destructor.go#L78-L104
Because of this, var.stack_destructor_enabled should not toggle the creation or destruction of this resource, since toggling it from true to false with the intention of disabling the stack destructor functionality will result in all of the resources in the stack being deleted. Instead, this resource should always created (when var.enabled is true), with var.stack_destructor_enabled toggling its deactivated attribute, which allows for the stack destructor functionality to be disabled.
references

https://github.com/spacelift-io/terraform-provider-spacelift/pull/260
https://registry.terraform.io/providers/spacelift-io/spacelift/latest/docs/resources/stack_destructor
#85

closed via #85


Documentation suggestion for Lite

I ran Structurizr Lite using Docker compose. I share my docker-compose.yaml here in case anyone else finds it useful.
version: '3'
services:
  structurizr:
    container_name: system-architecture-structurizr
    image: structurizr/lite
    ports:
      - "8080:8080"
    volumes:
      - "./src:/usr/local/structurizr:rw"

Thanks, I've added this to the docs.


study material for web cp and cyb security added

Study material for web development, competitive coding, and cybersecurity added.

Hey @arnav-dev-git, good work champ 😁
But there is some misunderstanding. What I asked was for list of links and courses in proper order so that when someone comes to the site understands what he/she needs to learn in sequence. You will be highly appreciated if you make the list in text file.


SocketManager: Add open_auto_path to select path automatically

Fixes #140.

I already created

#142

but we need a more fundamental solution as discussed in #140.
This PR adds feature: ServerEngine::SocketManager::Server.open_auto_path.
This selects path automatically.
Especially on Windows, it is hard to search an available port for path, so we should use this feature.
(The current generate_path logic sometimes chooses an unavailable port. For example, it does not consider the excluded port range.)
This fix keeps backward compatibility.

Though quite late now, I'm starting to think this may be better...
https://github.com/treasure-data/serverengine/blob/6c23c4ad2dec08635b4e77609088ff069c604959/lib/serverengine/socket_manager.rb#L91-L93
def self.open(path = nil)
  return new(path) unless path.nil?
  if ServerEngine.windows?
    new(0)
  else
    new(self.generate_path)
  end
end

What do you think? If so, I will fix.

Thanks!

Thanks for your review!


envoy: Bump golang version

This also includes other go package upgrade as well.

/test-backport-1.15

/test-backport-1.15


Updating link to new docs URL in README

Description
The link to the examples page in the Arsenal docs was broken in the README. This change updates the link to the new URL.
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Manually tested. The updated link was visited in a rendered version of the Markdown, and went to the correct page.

Whoops, thanks for the fix @attacus!


Add a section for Service Provider Manage Gateway

https://forums.veeam.com/powershell-f26/get-service-provider-default-gateway-information-t83730.html


First version of russian glossary

In the discussion of issue #162 there was a lot of positive feedback about creating glossary. This is the first version of it with all terms I've found yet.
I'm not sure whether it should be separate file per language or one file for everything in the root folder - that needs to be discussed.

This is awesome @brain-geek.  Is it possible for you to squash some of these commits?
Do you think this is strictly useful for translators or would this be something a reader might want to peruse?  If the latter, we should figure out a place to link to this from the website.

@doomspork That's very good question. Actually, readers of translated versions may be interested in what are original terms used. But that is not a major use case, as those experienced people will be reading original english version anyway.
So, I don't think why would we link it on the site.
I'll squash last commits.

Sounds good @brain-geek :+1:

@pragmaticivan and @pjhampton, any thoughts?

This LGTM :+1:. Can we change this PR to reflect that it is the Russian Glossary in the title?

Thinking about this a little more, I want to offer some suggestions and see what everyone thinks.
First thing, do we need this under source control?  If not, this might be better in the Wiki.  There we can setup individual glossaries for each language.
If we do need it under source control, should we be maintaining one large glossary for all languages or individual files per language?  (eg glossary.md -> /glossary/ru.md)

Once it will be always one page, maybe we can "create an example" of how it would fit there first.

First thing, do we need this under source control?
As for me, that makes sense under version control due to the fact that better term translations pop up - and this leads to glossary change.

Some terms (like 'pattern matching') changed their russian translation 3-4 times before getting to current state.

If we do need it under source control, should we be maintaining one large glossary for all languages or individual files per language?
That's a good question and I don't know an answer to it. My suggestion is to start with global file and see how it goes.

Can we change this PR to reflect that it is the Russian Glossary in the title?

Done

Is it possible for you to squash some of these commits?

Done

@brain-geek sounds good.  We'll start with this glossary and go from there.
Thanks again!


Make EVP_PKEY_CTX initialization more precise

There is a vagueness around how the provider data (algorithm name and
property query string) is initialized in the presence of an engine.
This change modifies this slightly so that the algorithm name for use
with providers is never set if the initilization was given an engine.
This makes it easier for other functions to simply check ctx->algorithm
to see if the context is meant to be used for strictly legacy stuff or
not.
Additionally, we change EVP_PKEY_CTX_new_provided() to take a library
context alongside the algorithm name and property query string.

Please review again

CIs are happy too

Merged.
60653e5b25242555446f8acf0abd5ab9ff83010c Make EVP_PKEY_CTX initialization more precise
3ee348b0dc5cd904fc2c022e6543f478c3d78732 Change EVP_PKEY_CTX_new_provided() to take a library context too.


cam_cal assumes a directory structure when finding hcm file

In logfile you set self.run from the "run" entry in the log file.
But this is the location of the raw data, and quite often the raw data will be on a different path in the filesystem whereas the .hcm file is more likely to be where the .red, .log files are.
For example, I often reduce data with the run entry /astronas1/vsd/.....

I've added os.path.basename around the run entry to remove all the extra path. Hopefully that'll fix what you're talking about?

yep - that will do it!


fix of || to OR

At this moment haye in adonis replace '||' and i cant use OR expression, so i changed '||' to OR

Im sorry, was misunderstanding with documentation


What am I doing wrong?

I am receiving the error "You caught an error! etc. " When I insert a new quote block, the authors don't show up. I have cleared metdata cache and re-scanned.
I have the following in one file:
:::One Person:::

> Quote A is a very very short quote.

> Quote B is another quote, not too long, not too short...but something in between.

:::Another Person:::

> Quote C is longer. Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui official

#quote

and in another, this:
```localquote
id V6h57
author One Person
refresh 1s

@fncll Hi! You need to use ordered/unordered lists (start every quote with - or 1....) to enter your quotes. In your list you using >

Also, remember that empty line breaking quote line, so you need write quotes like by line

As example you can use first demo gif in README.
If you still have questions, I'm listen

@fncll I noticed that you used refresh instead of reload

Here is what I have now, but still no luck with display and authors are not showing up when I try the Add Quote Block command (I did watch the gif, but it goes by very quickly).
```localquote
id V6h57
author One Person
reload 1s

and
:::One Person:::

- Quote A is a very very short quote.
- Quote B is another quote, not too long, not too short...but something in between.

:::Another Person:::

- Quote C is longer. This is written as one long line. Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui official

#quote

@fncll first author's quote must be on the next line, so you need to do like this
:::One Person:::
- Quote A is a very very short quote.
- Quote B is another quote, not too long, not too short...but something in between.

:::Another Person:::
- Quote C is longer. This is written as one long line. Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui official

#quote

You can check wiki for more detailed explain

Got it. Thank you for your patience!


Fetch is not defined with adapter-static and firebase

Describe the bug
We were using adapter-static. After we added firebase functions, there is an error when running npm run build:static. The error says: ReferenceError: fetch is not defined
Logs
Running 'npm run build:static':

><EMAIL_ADDRESS>build:static /workspace/source
> ADAPTER=@sveltejs/adapter-static OPTIONS={} npm run build

><EMAIL_ADDRESS>build /workspace/source
> svelte-kit build

vite v2.1.4 building for production...
transforming...

warn - Tailwind is not purging unused styles because no template paths have been provided.
warn - If you have manually configured PurgeCSS outside of Tailwind or are deliberately not removing unused styles, set `purge: false` in your Tailwind config file to silence this warning.
warn - https://tailwindcss.com/docs/controlling-file-size/#removing-unused-css
✓ 39 modules transformed.
rendering chunks...
.svelte/output/client/_app/manifest.json                            0.93kb
.svelte/output/client/_app/assets/start-8802ea92.css                3171.54kb / brotli: skipped (large chunk)
.svelte/output/client/_app/pages/sign-up.svelte-65215b67.js         0.52kb / brotli: 0.31kb
.svelte/output/client/_app/assets/pages/index.svelte-51f6bb49.css   0.75kb / brotli: 0.25kb
.svelte/output/client/_app/chunks/vendor-1abd9cb6.js                5.23kb / brotli: 2.04kb
.svelte/output/client/_app/start-f2c65d4b.js                        15.77kb / brotli: 5.36kb
.svelte/output/client/_app/pages/index.svelte-98bfbc41.js           233.63kb / brotli: 59.28kb
vite v2.1.4 building SSR bundle for production...
transforming...
✓ 37 modules transformed.
rendering chunks...
.svelte/output/server/app.js   15998.12kb

Run npm start to try your app locally.

> Using @sveltejs/adapter-static
> fetch is not defined
ReferenceError: fetch is not defined
    at file:///workspace/source/.svelte/output/server/app.js:4280:31
    at ModuleJob.run (internal/modules/esm/module_job.js:152:23)
    at async Loader.import (internal/modules/esm/loader.js:166:24)
    at async prerender (file:///workspace/source/node_modules/@sveltejs/kit/dist/chunks/index6.js:513:14)
    at async AdapterUtils.prerender (file:///workspace/source/node_modules/@sveltejs/kit/dist/chunks/index6.js:745:4)
    at async adapt (/workspace/source/node_modules/@sveltejs/adapter-static/index.js:10:4)
    at async adapt (file:///workspace/source/node_modules/@sveltejs/kit/dist/chunks/index6.js:767:2)
    at async file:///workspace/source/node_modules/@sveltejs/kit/dist/cli.js:633:5

To Reproduce
npm run build:static
Expected behavior
Static files are generated
Information about your SvelteKit Installation:

Diagnostics

The output of npx envinfo --system --npmPackages svelte,@sveltejs/kit,vite --binaries --browsers
npx: installed 1 in 1.831s
System:
OS: Linux 5.11 CentOS Stream 8
CPU: (4) x64 Intel(R) Core(TM) i5-4570 CPU @ 3.20GHz
Memory: 803.47 MB / 15.63 GB
Container: Yes
Shell: 4.4.19 - /bin/bash
Binaries:
Node: 14.15.4 - ~/.nvm/versions/node/v14.15.4/bin/node
npm: 6.14.10 - ~/.nvm/versions/node/v14.15.4/bin/npm
npmPackages:
@sveltejs/kit: next => 1.0.0-next.71
svelte: ^3.29.0 => 3.36.0
vite: ^2.1.0 => 2.1.4

Your browser
None

Your adapter (e.g. Node, static, Vercel, Begin, etc...)
static

Severity
Blocking firebase integration
Note: the more honest and specific you are here the more we will take you seriously.
Additional context
Some versions:
adapter-static: 1.0.0-next.4
firebase/app: 0.6.18
firebase/functions: 0.6.5
file /workspace/source/.svelte/output/server/app.js has around line 4280:
registerFunctions(firebase$1, fetch.bind(self));

Is this still happening?

Different message, still cannot use static-adapter with firebase. I tried with:
@sveltejs/adapter-static: 1.0.0-next.9
@sveltejs/kit: 1.0.0-next.107
npm run build (static-adapter):
Directory import '/src/node_modules/firebase/app' is not supported resolving ES modules imported from /src/.svelte-kit/output/server/
app.js
Did you mean to import firebase/app/dist/index.cjs.js?
Error [ERR_UNSUPPORTED_DIR_IMPORT]: Directory import '/src/node_modules/firebase/app' is not supported resolving ES modules imported fr
om /src/.svelte-kit/output/server/app.js
Did you mean to import firebase/app/dist/index.cjs.js?
    at finalizeResolution (internal/modules/esm/resolve.js:272:17)
    at moduleResolve (internal/modules/esm/resolve.js:699:10)
    at Loader.defaultResolve [as _resolve] (internal/modules/esm/resolve.js:810:11)
    at Loader.resolve (internal/modules/esm/loader.js:86:40)
    at Loader.getModuleJob (internal/modules/esm/loader.js:230:28)
    at ModuleWrap.<anonymous> (internal/modules/esm/module_job.js:56:40)
    at link (internal/modules/esm/module_job.js:55:36)

Hi,
Found a workaround after following some pointers from here and here. It combines onMount with dynamic importing

i found other workaround
first install whatwg-fetch.
npm i --save whatwg-fetch
create a file ./define-self.js with this content
var global =
  (typeof globalThis !== "undefined" && globalThis) ||
  (typeof self !== "undefined" && self) ||
  (typeof global !== "undefined" && global);

if (!global?.self) {
  global.self = global;
}

add this script to your index.svelte or  _layout.svelte
<script context="module">
  import "./define-self";
  import "whatwg-fetch";
</script>


[Test] Fix 'clang-target-clang-irgen.swift' test to build correctly against newer SDKs

Resolves rdar://138880276

@swift-ci smoke test

@swift-ci smoke test Linux platform


DirectInbox Feed not coming through

Instagram seems to have implemented a new feature. They now prompt you before you begin a conversation with a person. Thus the inbox feed does not gather conversations that you haven't approved yet. How do we gather unapproved conversations and approve them?

You have to use the ig.feed.directPending() feed. From there you can approve each thread using the direct-thread repository.

@Thrillseeker419 did you got the answer?

I tried npm uninstall instagram-private-api, then npm install instagram-private-api to update my npm package. I examined the files to realize that they still did not include the updated FeedFactory file.  (i tried installing in a completely new folder and it still didn't contain the updated FeedFactory) yielding, again, the error:  Property 'directPending' does not exist on type 'FeedFactory'. So I downloaded the ZIP and replace the dist folder of my npm installed package with the src folder of the ZIP and I am getting a different error: TypeError: ig.feed.directPending is not a function
My code: I literally copied your direct inbox example. I got that to work. i tried to simply change directInbox() to directPending(). (I think i am having installation issues)

The version 1.15 isn't yet on npm so you could either wait until it's available or build it yourself (just clone the repo, compile it using the tsconfig and copy the *.json files to the /dist directory)

I found the tsconfig inside the download. How do i compile it using that file?

tsc -p tsconfig.build.json in the project-root

Here is my tsconfig:
{
"compilerOptions": {
"lib": ["es7"],
"declaration": true,
"esModuleInterop": true,
"module": "commonjs",
"moduleResolution": "node",
"noImplicitAny": false,
"removeComments": true,
"noLib": false,
"allowSyntheticDefaultImports": true,
"emitDecoratorMetadata": true,
"experimentalDecorators": true,
"target": "ES2017",
"sourceMap": true,
"outDir": "./dist",
"baseUrl": "./",
"allowJs": false,
"resolveJsonModule": true,
"noUnusedLocals": true
}
}
and here is my tsconfig.build.json:
{
"extends": "./tsconfig.json",
"files": [
"pendingInbox.ts"
//,"importer.ts"
],
"include": ["src/**/*.ts"],
"exclude": [
"node_modules",
"tests"
]
}
here is my directory layout:

I am still getting errors?
node_modules/instagram-private-api/src/core/feed.ts:55:22 - error TS2351: Cannot use 'new' with an expression whose type lacks a call or construct signature.
55   protected chance = new Chance();
~~~~~~~~~~~~
node_modules/instagram-private-api/src/core/feed.ts:4:1
4 import * as Chance from 'chance';
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Type originates at this import. A namespace-style import cannot be called or constructed, and will cause a failure at runtime. Consider using a default import or import require here instead.
node_modules/instagram-private-api/src/core/request.ts:135:38 - error TS2349: Cannot invoke an expression whose type lacks a call signature. Type '{ default: RequestAPI<RequestPromise, RequestPromiseOptions, RequiredUriUrl>; defaults(options: RequestPromiseOptions): RequestAPI<RequestPromise, RequestPromiseOptions, RequiredUriUrl>; defaults(options: Options): DefaultUriUrlRequestApi<...>; ... 11 more ...; debug: boolean; }' has no compatible call signatures.
135       return await retry(async () => request(options), this.attemptOptions);
~~~~~~~~~~~~~~~~
node_modules/instagram-private-api/src/core/request.ts:5:1
5 import * as request from 'request-promise';
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Type originates at this import. A namespace-style import cannot be called or constructed, and will cause a failure at runtime. Consider using a default import or import require here instead.
node_modules/instagram-private-api/src/core/state.ts:106:20 - error TS2351: Cannot use 'new' with an expression whose type lacks a call or construct signature.
106     const chance = new Chance(this.deviceId);
~~~~~~~~~~~~~~~~~~~~~~~~~
node_modules/instagram-private-api/src/core/state.ts:3:1
3 import * as Chance from 'chance';
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Type originates at this import. A namespace-style import cannot be called or constructed, and will cause a failure at runtime. Consider using a default import or import require here instead.
node_modules/instagram-private-api/src/core/state.ts:112:20 - error TS2351: Cannot use 'new' with an expression whose type lacks a call or construct signature.
112     const chance = new Chance(${this.deviceId}${Math.round(Date.now() / 10800000)});
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
node_modules/instagram-private-api/src/core/state.ts:3:1
3 import * as Chance from 'chance';
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Type originates at this import. A namespace-style import cannot be called or constructed, and will cause a failure at runtime. Consider using a default import or import require here instead.
node_modules/instagram-private-api/src/core/state.ts:168:45 - error TS2339: Property 'fromCallback' does not exist on type 'typeof Bluebird'.
168     this.cookieJar['_jar'] = await Bluebird.fromCallback(cb => CookieJar.deserialize(cookies, this.cookieStore, cb));
~~~~~~~~~~~~
node_modules/instagram-private-api/src/core/state.ts:172:21 - error TS2339: Property 'fromCallback' does not exist on type 'typeof Bluebird'.
172     return Bluebird.fromCallback(cb => this.cookieJar['_jar'].serialize(cb));
~~~~~~~~~~~~
node_modules/instagram-private-api/src/core/state.ts:176:20 - error TS2351: Cannot use 'new' with an expression whose type lacks a call or construct signature.
176     const chance = new Chance(seed);
~~~~~~~~~~~~~~~~
node_modules/instagram-private-api/src/core/state.ts:3:1
3 import * as Chance from 'chance';
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Type originates at this import. A namespace-style import cannot be called or constructed, and will cause a failure at runtime. Consider using a default import or import require here instead.
node_modules/instagram-private-api/src/core/state.ts:190:12 - error TS2351: Cannot use 'new' with an expression whose type lacks a call or construct signature.
190     return new Chance(${seed}${this.deviceId}${Math.round(Date.now() / lifetime)}).guid();
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
node_modules/instagram-private-api/src/core/state.ts:3:1
3 import * as Chance from 'chance';
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Type originates at this import. A namespace-style import cannot be called or constructed, and will cause a failure at runtime. Consider using a default import or import require here instead.
node_modules/instagram-private-api/src/entities/direct-thread.entity.ts:11:29 - error TS2349: Cannot invoke an expression whose type lacks a call signature. Type '{ default: (options?: Options) => RegExp; }' has no compatible call signatures.
11     const urls = text.match(urlRegex({ strict: false }));
~~~~~~~~~~~~~~~~~~~~~~~~~~~
node_modules/instagram-private-api/src/entities/direct-thread.entity.ts:1:1
1 import * as urlRegex from 'url-regex';
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Type originates at this import. A namespace-style import cannot be called or constructed, and will cause a failure at runtime. Consider using a default import or import require here instead.
node_modules/instagram-private-api/src/entities/direct-thread.entity.ts:52:5 - error TS2322: Type 'StatusResponse' is not assignable to type 'string'.
52     return await this.client.directThread.mute(this.threadId);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
node_modules/instagram-private-api/src/entities/direct-thread.entity.ts:56:5 - error TS2322: Type 'StatusResponse' is not assignable to type 'string'.
56     return await this.client.directThread.unmute(this.threadId);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
node_modules/instagram-private-api/src/entities/direct-thread.entity.ts:60:5 - error TS2322: Type 'StatusResponse' is not assignable to type 'string'.
60     return await this.client.directThread.hide(this.threadId);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
node_modules/instagram-private-api/src/entities/direct-thread.entity.ts:64:5 - error TS2322: Type 'StatusResponse' is not assignable to type 'string'.
64     return await this.client.directThread.leave(this.threadId);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
node_modules/instagram-private-api/src/entities/media.entity.ts:7:12 - error TS2349: Cannot invoke an expression whose type lacks a call signature. Type '{ default: RequestAPI<RequestPromise, RequestPromiseOptions, RequiredUriUrl>; defaults(options: RequestPromiseOptions): RequestAPI<RequestPromise, RequestPromiseOptions, RequiredUriUrl>; defaults(options: Options): DefaultUriUrlRequestApi<...>; ... 11 more ...; debug: boolean; }' has no compatible call signatures.
7     return request({
~~~~~~~~~
8       url: 'https://api.instagram.com/oembed/',
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
...
12       },
~~~~~~~~
13     });
~~~~~~
node_modules/instagram-private-api/src/entities/media.entity.ts:1:1
1 import * as request from 'request-promise';
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Type originates at this import. A namespace-style import cannot be called or constructed, and will cause a failure at runtime. Consider using a default import or import require here instead.
node_modules/instagram-private-api/src/repositories/live.repository.ts:7:3 - error TS2724: Module '"../../../../../../../Development/Instagram/v9/node_modules/instagram-private-api/src/responses"' has no exported member 'LiveEndBroadcastResponseRootObject'. Did you mean 'LiveStartBroadcastResponseRootObject'?
7   LiveEndBroadcastResponseRootObject,
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
node_modules/instagram-private-api/src/repositories/live.repository.ts:13:3 - error TS2724: Module '"../../../../../../../Development/Instagram/v9/node_modules/instagram-private-api/src/responses"' has no exported member 'LiveShowQuestionResponseRootObject'. Did you mean 'LiveGetQuestionsResponseRootObject'?
13   LiveShowQuestionResponseRootObject,
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
node_modules/instagram-private-api/src/repositories/live.repository.ts:14:3 - error TS2724: Module '"../../../../../../../Development/Instagram/v9/node_modules/instagram-private-api/src/responses"' has no exported member 'LiveHideQuestionResponseRootObject'. Did you mean 'LiveGetQuestionsResponseRootObject'?
14   LiveHideQuestionResponseRootObject,
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
node_modules/instagram-private-api/src/repositories/live.repository.ts:16:3 - error TS2724: Module '"../../../../../../../Development/Instagram/v9/node_modules/instagram-private-api/src/responses"' has no exported member 'LiveWaveResponseRootObject'. Did you mean 'LiveLikeResponseRootObject'?
16   LiveWaveResponseRootObject,
~~~~~~~~~~~~~~~~~~~~~~~~~~
pendingInbox.ts:16:13 - error TS6133: 'pendinginboxFeed' is declared but its value is never read.
16                                               var pendinginboxFeed = ig.feed.directPending();
~~~~~~~~~~~~~~~~
pendingInbox.ts:22:13 - error TS2403: Subsequent variable declarations must have the same type.  Variable 'pendinginboxFeed' must be of type 'DirectPendingInboxFeed', but here has type 'DirectInboxFeed'.
22                                               var pendinginboxFeed = ig.feed.directInbox();
~~~~~~~~~~~~~~~~
pendingInbox.ts:16:13
16                                                   var pendinginboxFeed = ig.feed.directPending();
~~~~~~~~~~~~~~~~
'pendinginboxFeed' was also declared here.
pendingInbox.ts:22:13 - error TS6133: 'pendinginboxFeed' is declared but its value is never read.
22                                               var pendinginboxFeed = ig.feed.directInbox();
~~~~~~~~~~~~~~~~
Found 21 errors.

Too many questions for one issue.
Feel free to open a new issue with feature usage example request.


[REQ] Hide Microphone/Camera Icon UI over your head

Acknowledgement of preliminary instructions

[X] I have read and acknowledged the preliminary instructions.

What idea do you have?
Is it possible to hide or move the microphone icon that stays over our avatar head in game?

Enable the "V4 + New UI" escape menu style.


Move changelog section to readme

Changelog section from my point of view should be moved to its own changelog.md file.

Good point; it is getting a tad large!


Having trouble building the iCESugar example

I'm having some trouble trying to build the iCESugar example. From the setups/examples folder, I run the command:
BOARD=iCESugar DESIGN=MinimalBoot VERBOSE=1 make iCESugar
But GHDL complains:
make \
  BITSTREAM=neorv32_iCESugar_MinimalBoot.bit \
  run
make[1]: Entering directory '/home/jeremy/Desktop/neorv32/setups/examples'
make -C ../osflow/iCESugar/ \
  BOARD_SRC=../../examples/neorv32_iCESugar_BoardTop_MinimalBoot.vhd \
  TOP=neorv32_iCESugar_BoardTop_MinimalBoot \
  ID=MinimalBoot \
  clean neorv32_iCESugar_MinimalBoot.bit
make[2]: Entering directory '/home/jeremy/Desktop/neorv32/setups/osflow/iCESugar'
rm -f *.{asc,bit,cf,dfu,history,json,o} *-report.txt
ghdl -a --std=08 --work=iCE40 ../devices/ice40/sb_ice40_components.vhd
ghdl -a --std=08 --work=neorv32 ../../../rtl/core/neorv32_package.vhd ../../../rtl/core/neorv32_application_image.vhd  ../devices/ice40/neorv32_imem.ice40up_spram.vhd ../devices/ice40/neorv32_dmem.ice40up_spram.vhd ../../../rtl/core/neorv32_bootloader_image.vhd ../../../rtl/core/neorv32_boot_rom.vhd ../../../rtl/core/neorv32_bus_keeper.vhd ../../../rtl/core/neorv32_busswitch.vhd ../../../rtl/core/neorv32_cfs.vhd ../../../rtl/core/neorv32_cpu.vhd ../../../rtl/core/neorv32_cpu_alu.vhd ../../../rtl/core/neorv32_cpu_bus.vhd ../../../rtl/core/neorv32_cpu_control.vhd ../../../rtl/core/neorv32_cpu_cp_fpu.vhd ../../../rtl/core/neorv32_cpu_cp_muldiv.vhd ../../../rtl/core/neorv32_cpu_cp_shifter.vhd ../../../rtl/core/neorv32_cpu_decompressor.vhd ../../../rtl/core/neorv32_cpu_regfile.vhd ../../../rtl/core/neorv32_debug_dm.vhd ../../../rtl/core/neorv32_debug_dtm.vhd ../../../rtl/core/neorv32_fifo.vhd ../../../rtl/core/neorv32_gpio.vhd ../../../rtl/core/neorv32_icache.vhd ../../../rtl/core/neorv32_mtime.vhd ../../../rtl/core/neorv32_neoled.vhd ../../../rtl/core/neorv32_pwm.vhd ../../../rtl/core/neorv32_slink.vhd ../../../rtl/core/neorv32_spi.vhd ../../../rtl/core/neorv32_sysinfo.vhd ../../../rtl/core/neorv32_top.vhd ../../../rtl/core/neorv32_trng.vhd ../../../rtl/core/neorv32_twi.vhd ../../../rtl/core/neorv32_uart.vhd ../../../rtl/core/neorv32_wdt.vhd ../../../rtl/core/neorv32_wishbone.vhd
ghdl -a --std=08 --work=work  ../../examples/neorv32_iCESugar_BoardTop_MinimalBoot.vhd
../../examples/neorv32_iCESugar_BoardTop_MinimalBoot.vhd:134:29:error: unit "neorv32_processortop_minimalboot" not found in library "work"
  neorv32_inst: entity work.neorv32_ProcessorTop_MinimalBoot
                            ^
make[2]: *** [../synthesis.mk:8: work-obj08.cf] Error 1
make[2]: Leaving directory '/home/jeremy/Desktop/neorv32/setups/osflow/iCESugar'
make[1]: *** [Makefile:16: run] Error 2
make[1]: Leaving directory '/home/jeremy/Desktop/neorv32/setups/examples'
make: *** [Makefile:35: iCESugar] Error 2

If I run BOARD=iCESugar DESIGN=MinimalBoot VERBOSE=1 make, then all that happens is that my iCESugar folder is moved from the osflow folder to the examples folder:
make -C ../osflow/iCESugar/ \
  BOARD_SRC=../../examples/neorv32_iCESugar_BoardTop_MinimalBoot.vhd \
  TOP=neorv32_iCESugar_BoardTop_MinimalBoot \
  ID=MinimalBoot \
  clean
make[1]: Entering directory '/home/jeremy/Desktop/neorv32/setups/osflow/iCESugar'
rm -f *.{asc,bit,cf,dfu,history,json,o} *-report.txt
make[1]: Leaving directory '/home/jeremy/Desktop/neorv32/setups/osflow/iCESugar'
mv ../osflow/iCESugar/ ./

Finally, if I run BOARD=iCESugar VERBOSE=1 make MinimalBoot (which I am thinking is the correct one), I get the following error:
make \
  DESIGN=MinimalBoot \
  DESIGN_SRC=../../../rtl/templates/processor/neorv32_ProcessorTop_MinimalBoot.vhd \
  iCESugar
make[1]: Entering directory '/home/jeremy/Desktop/neorv32/setups/examples'
make \
  BITSTREAM=neorv32_iCESugar_MinimalBoot.bit \
  run
make[2]: Entering directory '/home/jeremy/Desktop/neorv32/setups/examples'
make -C ../osflow/iCESugar/ \
  BOARD_SRC=../../examples/neorv32_iCESugar_BoardTop_MinimalBoot.vhd \
  TOP=neorv32_iCESugar_BoardTop_MinimalBoot \
  ID=MinimalBoot \
  clean neorv32_iCESugar_MinimalBoot.bit
make[3]: Entering directory '/home/jeremy/Desktop/neorv32/setups/osflow/iCESugar'
rm -f *.{asc,bit,cf,dfu,history,json,o} *-report.txt
yosys  \
  -p \
  "ghdl --std=08 --no-formal neorv32_iCESugar_BoardTop_MinimalBoot; \
  synth_ice40 \
  -top neorv32_iCESugar_BoardTop_MinimalBoot \
  -dsp \
  -json neorv32_iCESugar_MinimalBoot.json"  2>&1 | tee yosys-report.txt

 /----------------------------------------------------------------------------\
 |                                                                            |
 |  yosys -- Yosys Open SYnthesis Suite                                       |
 |                                                                            |
 |  Copyright (C) 2012 - 2020  Claire Xenia Wolf<EMAIL_ADDRESS>       |
 |                                                                            |
 |  Permission to use, copy, modify, and/or distribute this software for any  |
 |  purpose with or without fee is hereby granted, provided that the above    |
 |  copyright notice and this permission notice appear in all copies.         |
 |                                                                            |
 |  THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES  |
 |  WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF          |
 |  MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR   |
 |  ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES    |
 |  WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN     |
 |  ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF   |
 |  OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.            |
 |                                                                            |
 \----------------------------------------------------------------------------/

 Yosys 0.9+4081 (open-tool-forge build) (git sha1 862e84eb, gcc 9.3.0-17ubuntu1~20.04 -Os)

-- Running command `ghdl --std=08 --no-formal neorv32_iCESugar_BoardTop_MinimalBoot;   synth_ice40   -top neorv32_iCESugar_BoardTop_MinimalBoot   -dsp   -json neorv32_iCESugar_MinimalBoot.json' --

1. Executing GHDL.
warning: ieee library directory '/__w/1/s/_packages/build_linux_x86_64/fpga-toolchain/lib/ghdl/ieee/v08/' not found
error: cannot find "std" library
ERROR: vhdl import failed.
nextpnr-ice40 \
  --up5k --package sg48 --ignore-loops --timing-allow-fail \
  --pcf iCESugar.pcf \
  --json neorv32_iCESugar_MinimalBoot.json \
  --asc neorv32_iCESugar_MinimalBoot.asc 2>&1 | tee nextpnr-report.txt
ERROR: Failed to open JSON file 'neorv32_iCESugar_MinimalBoot.json'.
0 warnings, 1 error
icepack neorv32_iCESugar_MinimalBoot.asc neorv32_iCESugar_MinimalBoot.bit
Error: Failed to open input file.
make[3]: *** [../PnR_Bit.mk:9: neorv32_iCESugar_MinimalBoot.bit] Error 1
make[3]: Leaving directory '/home/jeremy/Desktop/neorv32/setups/osflow/iCESugar'
make[2]: *** [Makefile:16: run] Error 2
make[2]: Leaving directory '/home/jeremy/Desktop/neorv32/setups/examples'
make[1]: *** [Makefile:35: iCESugar] Error 2
make[1]: Leaving directory '/home/jeremy/Desktop/neorv32/setups/examples'
make: *** [Makefile:51: MinimalBoot] Error 2

Though I believe this last one might be due to an issue with my toolchain install? I have just downloaded the toolchain from here: https://github.com/YosysHQ/fpga-toolchain (version nightly-20210703), extracted it to /opt/fpga-toolchain and added it to my path.
If someone could point me in the right direction, it would be much appreciated.

Ok, fixed the issue with the last one (see https://github.com/YosysHQ/fpga-toolchain#using-ghdl), but am now seeing an error which is not related to the toolchain:
make \
  DESIGN=MinimalBoot \
  DESIGN_SRC=../../../rtl/templates/processor/neorv32_ProcessorTop_MinimalBoot.vhd \
  iCESugar
make[1]: Entering directory '/home/jeremy/Desktop/neorv32/setups/examples'
make \
  BITSTREAM=neorv32_iCESugar_MinimalBoot.bit \
  run
make[2]: Entering directory '/home/jeremy/Desktop/neorv32/setups/examples'
make -C ../osflow/iCESugar/ \
  BOARD_SRC=../../examples/neorv32_iCESugar_BoardTop_MinimalBoot.vhd \
  TOP=neorv32_iCESugar_BoardTop_MinimalBoot \
  ID=MinimalBoot \
  clean neorv32_iCESugar_MinimalBoot.bit
make[3]: Entering directory '/home/jeremy/Desktop/neorv32/setups/osflow/iCESugar'
rm -f *.{asc,bit,cf,dfu,history,json,o} *-report.txt
yosys  \
  -p \
  "ghdl --std=08 --no-formal neorv32_iCESugar_BoardTop_MinimalBoot; \
  synth_ice40 \
  -top neorv32_iCESugar_BoardTop_MinimalBoot \
  -dsp \
  -json neorv32_iCESugar_MinimalBoot.json"  2>&1 | tee yosys-report.txt

 /----------------------------------------------------------------------------\
 |                                                                            |
 |  yosys -- Yosys Open SYnthesis Suite                                       |
 |                                                                            |
 |  Copyright (C) 2012 - 2020  Claire Xenia Wolf<EMAIL_ADDRESS>       |
 |                                                                            |
 |  Permission to use, copy, modify, and/or distribute this software for any  |
 |  purpose with or without fee is hereby granted, provided that the above    |
 |  copyright notice and this permission notice appear in all copies.         |
 |                                                                            |
 |  THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES  |
 |  WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF          |
 |  MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR   |
 |  ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES    |
 |  WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN     |
 |  ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF   |
 |  OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.            |
 |                                                                            |
 \----------------------------------------------------------------------------/

 Yosys 0.9+4081 (open-tool-forge build) (git sha1 862e84eb, gcc 9.3.0-17ubuntu1~20.04 -Os)

-- Running command `ghdl --std=08 --no-formal neorv32_iCESugar_BoardTop_MinimalBoot;   synth_ice40   -top neorv32_iCESugar_BoardTop_MinimalBoot   -dsp   -json neorv32_iCESugar_MinimalBoot.json' --

1. Executing GHDL.
error: cannot find entity or configuration neorv32_icesugar_boardtop_minimalboot
ERROR: vhdl import failed.
nextpnr-ice40 \
  --up5k --package sg48 --ignore-loops --timing-allow-fail \
  --pcf iCESugar.pcf \
  --json neorv32_iCESugar_MinimalBoot.json \
  --asc neorv32_iCESugar_MinimalBoot.asc 2>&1 | tee nextpnr-report.txt
ERROR: Failed to open JSON file 'neorv32_iCESugar_MinimalBoot.json'.
0 warnings, 1 error
icepack neorv32_iCESugar_MinimalBoot.asc neorv32_iCESugar_MinimalBoot.bit
Error: Failed to open input file.
make[3]: *** [../PnR_Bit.mk:9: neorv32_iCESugar_MinimalBoot.bit] Error 1
make[3]: Leaving directory '/home/jeremy/Desktop/neorv32/setups/osflow/iCESugar'
make[2]: *** [Makefile:16: run] Error 2
make[2]: Leaving directory '/home/jeremy/Desktop/neorv32/setups/examples'
make[1]: *** [Makefile:35: iCESugar] Error 2
make[1]: Leaving directory '/home/jeremy/Desktop/neorv32/setups/examples'
make: *** [Makefile:51: MinimalBoot] Error 2

This might be just a path issue... I will check that.
Maybe @umarcor can directly spot the problem :wink:

@jeremyherbert try make -C setups/examples/ BOARD=iCESugar MinimalBoot or:
cd setups/examples/
make BOARD=iCESugar MinimalBoot

@jeremyherbert, first off, I apologise for the undocumented state of these makefiles, and for my previous so short answer. Your issue was related to the toolchain, indeed, and you fixed it properly. BTW, the Fomu toolchain is based on fpga-toolchain, so you will get the same issue. Now, the issue is the make target you are using. You got it correct in the last try before fixing the GHDL_PREFIX issue: make BOARD=iCESugar MinimalBoot.
Find a more detailed explanation about the makefiles in #96.

Thanks for your help! I tried to run your make commands, but I still received the same error as above:
...
1. Executing GHDL.
error: cannot find entity or configuration neorv32_icesugar_boardtop_minimalboot
ERROR: vhdl import failed.
...

However, with a bit of poking around, it seems that some stale .cf files built with the wrong make commands were still in the build directory, and they were causing the GHDL build to break. Once I removed these files everything works great!


Create game 'fuj1n'

Created a snake game

Your pull request seems good, but must be checked by a human maintainer for the following reason(s):

The bot does not support marking the week2 challenge yet

Please be patient until a maintainer has time to look over your contribution.
This is an automated response, beep boop.
if you think there is a mistake, contact a maintainer

fb0493584f436d08c174c73e3ecf735a6984caf3

This request's code has changed since approval. Re-Judging contents...
Your pull request seems good, but must be checked by a human maintainer for the following reason(s):

The bot does not support marking the week2 challenge yet

Please be patient until a maintainer has time to look over your contribution.
This is an automated response, beep boop.
if you think there is a mistake, contact a maintainer

95ffa1e7b119bb1362bbc57d15f3adb7c8e43ba8


Is it a bug with tf.cond?

Greetings,
I have a code that uses tf.conds as follows:
import tensorflow as tf
def func():
	aa = 0
	def abc():
		aa = [0]
		return tf.convert_to_tensor(True, dtype=bool)
	def ghi():
		b = aa[0]
		return tf.convert_to_tensor(False, dtype=bool)
	return a = tf.cond(tf.convert_to_tensor(True, dtype=bool), abc(), ghi())
a = func()

I suppose function ghi() should not be run (as it should runs func abc()). But somehow the code there is still running, resulting in an error of 'int' object is not subscriptable (from b = aa[0]).
Is it a bug? If not, could you explain more about this?
Thx.

Closed after some investigation. While tf.cond is great, it is indeed a bit counterintuitive!


⚠ Bofrost.fr has degraded performance

In 61ab9a0, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1058 ms

Resolved: Bofrost.fr performance has improved in 498e5fa after 6 minutes.


Introduce ABAP Language Version (ALV) to .abapgit.xml

fixes issue #6334

Code is part of the solution and looks good to me. However, I don't think we should add this as is. Every newly created repo will get diffs when used in older abapGit versions (not sure what happens if you try to pull).
We should mark the feature to be experimental so we can merge without impacting the community.
IF zcl_abapgit_persist_factory=>get_settings( )->read( )->get_experimental_features( ) = abap_true.
...
ENDIF.

I will surround the affected coding parts with the mentioned if statement and update the PR.

One step back: I have decided to not touch the current logic in .abapgit.xml handling, so that surrounding with experimental feature is not required, since there is no defaulting while object creation.

looks like these changes are included in #6346

This PR can be closed since the PR #6346 contains of those changes


WARN [runner] The linter 'maligned' is deprecated

Full message from golangci-lint v1.39.0:
WARN [runner] The linter 'maligned' is deprecated (since v1.38.0) due to: The repository of the linter has been archived by the owner.  Replaced by govet 'fieldalignment'.

Relevant line in the config file:
https://github.com/atc0005/go-ci/blob/a2916784c82b2bf06cd872fdb80b4e1c227957cd/.golangci.yml#L31

Relevant:

https://github.com/golangci/golangci-lint/pull/1765

https://github.com/golangci/golangci-lint/pull/1765#issuecomment-802223182