After Popup, system failed to redirect back to original url

Please follow the issue template below. Failure to do so will result in a delay in answering your question.
Library

[x ]<EMAIL_ADDRESS>or<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>
Description
After the popup dialog for SSO login, the application get the account information (based on console log), but just sit there and fail to redirect to original url.
We user MsalGuard for each route and MsalInterceptor as well.
Am I missing something here?
    MsalModule.forRoot({
        auth: {
            clientId: 'xxxxxx',
            authority: 'https://login.microsoftonline.com/xxxxxx/',
            validateAuthority: true,
            navigateToLoginRequestUrl: false
        },
    },
        {
            popUp: !isIE,
            consentScopes: [
                'api://........', "openid", "profile"
            ],
            unprotectedResources: ["https://www.microsoft.com/en-us/"],
            protectedResourceMap: [
                ['http://localhost:5000/', ['api://......']]
            ],
            extraQueryParameters: {}
        })

@svpoon Can you please clarify: is the popup not being closed? Please include a screenshot that describes the behavior you are describing.

The popup is closed and I see the account information on my console log. But the application is not redirected back  and sit there doing nothing.

@svpoon If you are calling loginPopup directly, MSAL will not redirect the user automatically. Your application will need to handle what happens when the login process has completed. This can be done by subscribing to the msal:loginSuccess event, or by using the promise returned by loginPopup.
Please see how this is done an Angular sample here.

We do not call loginPopup. this plug-in handles all these automatically. But not sure we misses any of the setup. It will not redirect back to original url after entering userid/password.

@svpoon Can you clarify: are you trying to navigate to a route that is protected by the MSAL guard? Please provide screenshots or a video demonstrating the behavior you are describing.

All routes are protected by MSAL guard.
There is no manual redirect or call loginPopup.
I just followed the setup for MSAL plugin.
After I entered UserId/Password and the Miscrosoft dialog closed. The application is not redirecting automatically based on route on URL and sit there, doing nothing.

@svpoon Which page is the user on when loginPopup is triggered, and how does the user arrive at that page? And which page would you like the user to be redirected?

It is just the main page of my web site, like http://localhost/myApp.  Once user entered their credential and click OK. It should display what is in the web page (there are some API calls to get some data).
This is a very simple and straightforward scenario.

@svpoon Can you please provide the code you refer to below that you used to redirect once you get a successful login?

I can subscribe to msal:loginSuccess event to manually redirect once I got success login.
I can also press PF5 to reload the page and it will redirect silently as well.

Closing due to inactivity, please let us know if this is still an issue, thanks!


is it open source project ? what is the source repository?

Type: Question

is it open source project ? what is the source repository?

@chenx319 Thank you for the question. This repository is not open-source, this repository is for issues only. Thank you!


How to resolve Error: dlopen("") : Library not loaded Referenced () in nodejs

Hi.. i am trying to build node module using NAPI . i am using node-gyp for creating .node file
on MacOS i ran into issue
Error:

    dlopen(path-to-.node-file, 1): Library not loaded: libraryname.so Referenced from: path-to-.node-file.node

When i am running example in node_module directory then it is not throwing any error .code is running fine inside node_module.
ProjectDir/node_module/modulename/example.js -> code is running
ProjectDir/example.js -> it is showing me above error .
Structure of my module
moduefile.cc
lib.so
lib.h
binding.gyp file
binding.gyp for MacOS
['OS=="mac"',{
      'targets':[
        {
          "target_name": "target name",
          "sources":["./modulefile.cc"],
          "libraries":["<(module_root_dir)/lib.so"],
          "ldflags": ["-Wl,-rpath,'$$ORIGIN'"],
          "cflags_cc": ["-fexceptions","-fPIC","-Wno-unknown-pragmas"]
        }
      ]
    }]

So , i tried to resolve above issue made some changes in binding.gyp

    ['OS=="mac"',{
      'targets':[
        {
          "target_name": "target name",
          "sources":["./modulefile.cc"],
          "copies":[{
          "destination":"<(module_root_dir)/build/Release",
          "files":["<(module_root_dir)/lib.so"]
          }],
          "include_dirs":["<(module_root_dir)/"],
          "link_settings": {
            "libraries": [
              "-Wl,-rpath,<(module_root_dir)/lib.so"
            ],
          },
          "ldflags": ["-Wl,-rpath,'$$ORIGIN'"],
          "cflags_cc": ["-fexceptions","-fPIC","-Wno-unknown-pragmas"]
        }
      ]
    }]

It resolves above issue but throws new error while calling function of module.now i am getting error in both inside node_moduel and project root
ProjectDir/node_module/modulename/example.js -> Throwing Error
ProjectDir/example.js -> Throwing Error
Error
dyld: lazy symbol binding failed: Symbol not found: _function-name-in-lib.so-file Referenced from: targetname.node Expected in: flat namespace

From above error it seems modulefile.cc file is not able to call functions from lib.so file after i made some changes in binding.gyp.
it is strange that earlier javascript was running fine inside node_module folder but throwing error while trying to running same javascript in project root directory
Question :

How can i resolve above error ?

Check man ld, particularly the section on macos's two-level namespace. Judicious use of -flat_namespace can sometimes fix it.

@bnoordhuis  Thank you for replying . i have tried to add -flat_namespace
"ldflags": ["-Wl,-rpath,-flat_namespace,'$$ORIGIN'"],

but didn't worked for me .
i tried to run following command to check linked library with .node file .
otool -L filename.node
Output :
	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 902.1.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1281.100.1)

I think there should be name of  lib.so file but not sure about the same .

I think you're almost there. Try -Wl,-rpath,<(module_root_dir) and link with @rpath/lib.dylib.

Jumping into this issue without intent to hijack it: Based on the above, I added this into node-oracledb's existing binding.gyp
	"link_settings": {
            "libraries": [
	    	    "-Wl,-rpath,$$HOME/lib"
            ],
          },

and that seems (in limited testing) seems to have solved the same problem for node-oracledb.  Our install instructions suggest putting the (unchangeable) Oracle Client libraries in ~/lib so maybe this change will be acceptable.

@bnoordhuis  and @cjbj  Thank you for replying ,so issue was when i was requiring module .js file into the project root .module file working directory changes from module folder to project root directory due to this module was not able to find .dylib . so i just added process.chdir(__dirname) and it worked for me. but there is any way i can link path with lib.dylib as it is already done with /use/lib/libc++.1.dylib .
path-to-lib/lib.dylib(compatibility version 0.0.0, current version 0.0.0)
       /usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 902.1.0)

@shivam201312 I'll close this because it sounds like you've found a working solution? If not, let me know.

i'm having the same problem, and i can't solve it.
My project structure:
hello.cc
hello.js
libmy.dylib
libmy.h
binding.gyp
package.json

My binding.gyp:
{
  'targets':[
          {
            "target_name": "hello",
            "sources":["hello.cc"],
            "copies":[{
                    "destination":"<(module_root_dir)/build/Release",
                    "files":["<(module_root_dir)/libmy.dylib"]
            }],
            "include_dirs": [
                    "<!(node -e \"require('nan')\")",
                    "<(module_root_dir)/"
            ],
            "link_settings": {
              "libraries": [
                "-Wl,-rpath,<(module_root_dir)/libmy.dylib"
              ],
            },
            "ldflags": ["-Wl,-rpath,-flat_namespace,'$$ORIGIN'"],
            "cflags_cc": ["-fexceptions","-fPIC","-Wno-unknown-pragmas"]
          }
        ]
}

Here is my otool -L build/Release/hello.node result:
build/Release/hello.node:
        /usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 905.6.0)
        /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1292.100.5)

When i run node-gyp rebuild and then node ./ I get this error:
dyld: lazy symbol binding failed: Symbol not found: __Z5hellov
  Referenced from: /Users/me/Desktop/node-addon-examples/1_hello_world/nan/build/Release/hello.node
  Expected in: flat namespace

dyld: Symbol not found: __Z5hellov
  Referenced from: /Users/me/Desktop/node-addon-examples/1_hello_world/nan/build/Release/hello.node
  Expected in: flat namespace

zsh: abort      node ./


x-go-custom-tag not working when reusing a definition with $ref

Problem statement
Like shown in below specs (i.e. Swagger specification section), I'm trying to reuse the privacy_options definition, but when I do this, the generated go code doesn't have custom struct tag (below is the generated code)
type Privacy struct {

	// mobile number
	MobileNumber PrivacyOptions `json:"mobile_number,omitempty"`

	// name
	Name PrivacyOptions `json:"name,omitempty"`
}

As a workaround, I need to duplicate the definitions to make the custom tag work (like in below snippet), which I'm trying to avoid. Could you please suggest if there is a way to have reusability and also have the custom tags work? Please let me know if you are not able to reproduce the issue.
  privacy:
    title: Privacy settings
    type: object
    x-go-custom-tag: 'firestore:"privacy_setting"'
    properties:
      name:
        x-go-custom-tag: 'firestore:"name"'
        type: integer
        enum:
          - 1
          - 2
          - 3
      mobile_number:
        x-go-custom-tag: 'firestore:"mobile_number"'
        type: integer
        enum:
          - 1
          - 2
          - 3

With this workaround, the code generated is as I'm expecting (see below)
type Privacy struct {

	// mobile number
	// Enum: [1 2 3]
	MobileNumber int64 `json:"mobile_number,omitempty" firestore:"mobile_number"`

	// name
	// Enum: [1 2 3]
	Name int64 `json:"name,omitempty" firestore:"name"`
}

Swagger specification
swagger: "2.0"
info:
  title: ""
  version: "0.0.1"
schemes:
  - http

paths:
  /api/userprofile:
    post:
      summary: "posts the user profile details into db"
      parameters:
        - in: body
          name: profiles
          schema:
            type: array
            items:
              $ref: "#/definitions/profile"
      responses:
        200:
          description: "returns the posted user or users"
          schema:
            type: array
            items:
              $ref: "#/definitions/profile"

definitions:
  profile:
    title: profile
    type: object
    properties:
      profile_id:
        description: unique identification of user profile
        type: string
        x-go-custom-tag: 'firestore:"profile_id"'
      privacy_setting:
        $ref: "#/definitions/privacy"

  # nested definitions
  privacy:
    title: Privacy settings
    type: object
    x-go-custom-tag: 'firestore:"privacy_setting"'
    properties:
      name:
        x-go-custom-tag: 'firestore:"name"'
        $ref: "#/definitions/privacy_options"
      mobile_number:
        x-go-custom-tag: 'firestore:"mobile_number"'
        $ref: "#/definitions/privacy_options"
  privacy_options:
    type: integer
    enum:
      - 1
      - 2
      - 3

Steps to reproduce

save the above specs to swagger.yml
create empty gen folder
run below swagger command

swagger generate server \
	--target=./gen \
	--spec=./swagger.yml \
	--exclude-main \
	--name=myapp

Environment
swagger version: dev
go version: 1.14.2
OS: macOS Mojave v 10.14.6

$ref siblings are always ignored as per JSON schema semantics.
Therefore, there is no way to support this construct:
 properties:
      name:
        x-go-custom-tag: 'firestore:"name"'
        $ref: "#/definitions/privacy_options"
      mobile_number:
        x-go-custom-tag: 'firestore:"mobile_number"'
        $ref: "#/definitions/privacy_options

You have properly identified the way to go ("the workaround").
Unfortunately, goswagger doesn't support yet the following (which would be legit json schema):
allOf:
- $ref: ...
- x-go-custom-tag: xxx

@fredbi surely you mean:
allOf:
  - $ref: ...
x-go-custom-tag: xxx

It would be nice to be able to force the insertion of an allOf even for nested (not embedded) structs.


Add an option to specify .yamllint config file location

It would be great if there was a way to specify yamllint -c ${HOME}/.yamllint configuration file location. The way yamllint works is that it expects to find .yamllint file in current directory, otherwise it just uses default configuration, unless -c /path/to/yamllint is specified.

Try this:
let g:syntastic_yaml_yamllint_args = '-c ' . shellescape($HOME . '/.yamllint')

@lcd047 awesome! Thanks.


Keyboard commands break zapping/commenting

Pressing Enter when trying to submit a zap amount or comment breaks the player. Possibly due to keyboard controls not being mapped properly for those forms.

turns out this is an outstanding bug, unrelated to the recent keyboard PR. By default, forms are submitted whenever enter is pressed, so we need to stop that default behavior.
https://stackoverflow.com/questions/43750335/react-prevent-form-submission-when-enter-is-pressed-inside-input
https://github.com/wavlake/wavman/pull/41

Resolved by #41


add_bytes and add_string

Python 3.7
py-ipfs-http-client ... last version
I have a problem with adding images in base64 format. The content is not added as a whole. Is there any limit to the size of the string or byte array?
Original to be added:

What was added (as an example, not exactly the same image):

Thanks for the report! Which version of go-ipfs are you using? There were some known issues with some recent versions regarding this.
Please run the following commands and report their results for this:

ipfs version (go-ipfs version)
python3 -c 'import ipfshttpclient; print(ipfshttpclient.__version__)' (py-ipfs-http-client version)

Will help you after this if I can!

I'm also experiencing similar behavior when trying to add a string or json object larger than 4096 characters via ipfshttpclient
i'm using:
Python 3.7
go-ipfs 0.4.22
ipfshttpclient 0.4.12
i also tried downgrading go-ipfs to earlier versions, but the behaviour was the same, string get truncated at 4096 characters
Here is a bit of code to reproduce the behaviour:
`
import ipfshttpclient

api = ipfshttpclient.connect(’/ip4/<IP_ADDRESS>/tcp/5001/http’)

length = 4097 # up to 4096 should work

original_string = ‘’.join([‘a’ for _ in range(length)])
multihash = api.add_str(original_string)

retrieved_string = api.cat(cid=multihash)

retrieved_string = retrieved_string.decode() # In python3, the retrieved string is a bytes object, so need to decode it back into a string

print(original_string)
print(retrieved_string)
assert original_string == retrieved_string

`

Just saw there is another open issue regarding this same problem:
https://github.com/ipfs/py-ipfs-http-client/issues/190
it mentions setting chunk_size when connecting to the ipfs node
client = ipfshttpclient.connect('/ip4/<IP_ADDRESS>/tcp/5001/http"', chunk_size=4096, session=True)
I have tried it and setting chunk_size to a larger number does work.
But would this cause any side effects if I set it to a very large number?

Found the problem and created a pull request:
https://github.com/ipfs/py-ipfs-http-client/pull/194


Changed hand logic and dice detection

The current implementation of sending packets wasn't great because it relied on capturing the opening and closing of the dice packet to function correctly. I suspect you took this approach because ext.Send(out.THROW_DICE, dice.Id) was not working as expected.
The underlying issue is that Habbo expects raw bytes, not an integer. This issue can be resolved by converting the integer to a string, then converting that string to a byte array. The corrected code is as follows:
ext.Send(out.THROW_DICE, []byte(strconv.Itoa(dice.Id)))

I have also revised how you evaluate your hand using a piece of code made years ago by @b7c which I converted to Go as part of my own project, thought I'd share :)

Hi Edaurd,
Thank you for your pull request. I’ve already addressed the issues you mentioned in a new version, though I haven’t pushed those changes yet. I appreciate some of the improvements you’ve made and will be incorporating them as well. Additionally, I’ll be sure to include your name in the code as a token of appreciation for your contributions.


VoCo-LLaMA checkpoints

Hello, Thank you for your work! I think it has a great novelty.
I have some questions about checkpoint!
Are there no checkpoints for VoCo-LLaMA?
I only have 1 GPU(L40), and just want to check inference or evaluation. But I cannot find voco-llama checkpoints in this repository.
if there is plan to upload the checkpoints, when would you upload them?
Thank you

Hi,
Thank you for your interest in our work! We'll have the final model weights available soon.
We're in the process of cleaning the inference code. We'll be open sourcing the relevant checkpoints soon after this is done.
Best Regards.


[BUG] TypeError if model contains Conv1D layer

Describe the bug
Running layered_view() on a model that contains a Conv1D layer results in a TypeError.
Minimal Code To Reproduce
from tensorflow import keras
from tensorflow.keras import layers
import visualkeras

x_in = keras.Input(shape=(28, 1))
x = layers.Conv1D(16, 3, activation='relu')(x_in)
x_out = layers.Dense(32)(x)
x_out = layers.Dense(1)(x)
model = keras.Model(x_in, x_out)

visualkeras.layered_view(model, to_file='data/conv1d.png')

Expected behavior
Image is generated and contains the Conv1D layer.
Screenshots
Traceback (most recent call last):
  File "experiments/visualkeras_experiments/visualize.py", line 14, in <module>
    visualkeras.layered_view(encoder, to_file='data/conv1d.png')
  File "/path/to/visualkeras/layered.py", line 100, in layered_view
    z = min(max(z), max_z)
TypeError: 'int' object is not iterable

Environment (please complete the following information):

OS: Ubuntu 18.04.5
Python 3.8.2
Module Version: 0.0.2 (commit 402cec8)

@torazem Thanks for raising this issue. It should be fixed now. Please reinstall visualkeras from the git main branch and let me know if you encounter any problems.

It works now, thank you! :sparkles:


pull request for e2e test at 01/01/2017 21:56:11

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Go/SDK Jobs Example - JobEvent Data fails to parse

Expected Behavior
'== APP - job-service == Starting droid: R2-D2'
'== APP - job-service == Executing maintenance job: Oil Change'
'== APP - job-service == Starting droid: C-3PO'
'== APP - job-service == Executing maintenance job: Memory Wipe'

Actual Behavior
== APP - job-service == Job scheduled:  R2-D2
== APP - job-service == Job scheduled:  C-3PO
== APP - job-service == 2024/10/06 15:43:19 job:{name:"C-3PO" due_time:"15s" data:{value:"{\"droid\":\"C-3PO\",\"Task\":\"Memory Wipe\"}"}}
== APP - job-scheduler == Get job response:  {"droid":"C-3PO","Task":"Memory Wipe"}
== APP - job-service == Job scheduled:  BB-8
== APP - job-service == 2024/10/06 15:43:19 job:{name:"BB-8" due_time:"30s" data:{value:"{\"droid\":\"BB-8\",\"Task\":\"Internal Gyroscope Check\"}"}}
== APP - job-scheduler == Get job response:  {"droid":"BB-8","Task":"Internal Gyroscope Check"}
== APP - job-scheduler == Job deleted:  BB-8
Exited App successfully
ERRO[0021] unexpected status code returned from app while processing triggered job R2-D2. status code returned: 2  app_id=job-service instance=Nordrassil.local scope=dapr.runtime.scheduler type=log ver=1.14.4
ERRO[0031] unexpected status code returned from app while processing triggered job C-3PO. status code returned: 2  app_id=job-service instance=Nordrassil.local scope=dapr.runtime.scheduler type=log ver=1.14.4

Steps to Reproduce the Problem
Run the existing example with:
[quickstarts] dapr build-info
CLI:
        Version: 1.14.1
        Git Commit:
        Git Version:
Runtime:
        Version: 1.14.4
        Git Commit: 583960dc90120616124b60ad2b7820fc0b3edf44
        Git Version: 583960d

Analysis
It would appear that API has changed and now the common.JobEvent contains the actual Job payload as opposed to expected common.Job (job spec).
Fix jobs/go/sdk/job-service/job-service.go:
// Handler that handles job events
func handleJob(ctx context.Context, job *common.JobEvent) error {
	var jobPayload JobData
	if err := json.Unmarshal(job.Data, &jobPayload); err != nil {
		return fmt.Errorf("failed to unmarshal payload: %v", err)
	}

	fmt.Println("Starting droid:", jobPayload.Droid)
	fmt.Println("Executing maintenance job:", jobPayload.Task)

	return nil
}

After the fix we see the expected output:
== APP - job-service == Job scheduled:  R2-D2
== APP - job-service == Job scheduled:  C-3PO
== APP - job-service == 2024/10/06 15:51:38 job:{name:"C-3PO"  due_time:"15s"  data:{value:"{\"droid\":\"C-3PO\",\"Task\":\"Memory Wipe\"}"}}
== APP - job-scheduler == Get job response:  {"droid":"C-3PO","Task":"Memory Wipe"}
== APP - job-service == Job scheduled:  BB-8
== APP - job-service == 2024/10/06 15:51:38 job:{name:"BB-8"  due_time:"30s"  data:{value:"{\"droid\":\"BB-8\",\"Task\":\"Internal Gyroscope Check\"}"}}
== APP - job-scheduler == Get job response:  {"droid":"BB-8","Task":"Internal Gyroscope Check"}
== APP - job-scheduler == Job deleted:  BB-8
Exited App successfully
== APP - job-service == Starting droid: R2-D2
== APP - job-service == Executing maintenance job: Oil Change
== APP - job-service == Starting droid: C-3PO
== APP - job-service == Executing maintenance job: Memory Wipe

Closing, fixed by @cicoyle in #1097


Peer Review!!

Structure:

Your read me isn't finsihed yet
You are missing the r scripts in the scripts folder
You are missing LLM usage!
Your literature has irrelavant lit. Same with models in the outputs folder
There is a folder called .DStore, do you need it for something?
"number-sections: true" in the YAML file I think is for the table fo contents but you might have forgotten to write toc:true
git hub link and doi missing!

Content:

Great topic and I loved how you included social movements like BLM to motivate reader

there seem to be formatting issues in the second paragraph towards the end where there is dashed lines.

Methodology for the original paper gives users the chance to compare methodologies: good job!

I would cite the original paper in the references and cross-reference to that instead of just putting the link in the middle

What are the improper variables?

I liked how you gave an instance of why some of the variables need to be properly cleaned in your explanation of variables
-" If we do not control for age, then we will mistakenly conclude that black officers have a higher chance of getting the award"

It seems like your results (which I assume currently is your data section since it has your result graphs) and the discussion section where you analyse the results seems to be put into one. I don't necessarily mind because it means while we have the reader's attention we give them a reason for why the results turn out the way they have but the common structure is to have the result section where you show the graphs and tables to be completely unbiased so showing trends is alright but I don't know if outright stating the conclusion is okay or not. (This is from the first and second paragraph of the data section)

Everything else seems to be under construction so I won't comment too much on it, but it looks like its going pretty well!

Also in the data section you are missing citations of r and the other packages you have used.

Check your reference page!

Cool topic! Good luck!

Thank you!

The formatting and structure are the parts we haven't done yet. I agree with your comment on the data/results section being put into one, definitely need to find a better way to structure it.

Thank you for your peer review.
To the point "What are the improper variables?", we have already omitted all improper variables. We will consider including the reason why we removed the improper variables.


Relations and bigints

Moved following issue here: https://github.com/tgriesser/bookshelf/issues/1100
My guess: The bigint is causing problems, but I don´t see how it could be, as the correct queries are being sent.

@Chris-Satchell could you provide some minimal test case to reproduce this happening with plain knex without bookshelf?

Problem solved in https://github.com/tgriesser/bookshelf/issues/1100


Feature/apvs 1043/add time and remove cost field from train expense on advance claims

We now display the departure time (travel time) value rather than cost.
We now display the text 'Receipt to be uploaded after visit' instead of 'Receipt required' in the case of advance train expenses.
Confirmed that Chris is happy with this.
Checklist

[ ] Unit tests
[ ] Code coverage checked
[x] Coding standards
[ ] Error Handling
[ ] Security/performance considered?
[ ] Deployment changes considered?
[ ] README updated

After chatting are realising these are approved by Chris already initial comments can be ignored and merging now


chore(deps): update deps

Oh... so react native has that many things when you are updating?? Didn't know that!
Let me do the proper changes!


Fix command field PodExecOptions

Change the command field to an array of strings.

This change is happening on versioned resources. However, the resources are not yet exposed by the client commands and are not being used yet. @smarterclayton PTAL

LGTM.  @bgrant0607 - the initial implementation of the new endpoint params was broken, this corrects it.  No consumers should be affected

Ok. As long as you're touching this, please clarify the description text. Command is an argv array? Does it execute in a shell?

@bgrant0607 - thx. Updated description.

LGTM

(Temp assigning Brian until Travis says it's OK—will merge then.)

Travis green; merging.


242 3.25 application canceled state refactoring

This PR contains some refactorings/preparations for actual userstory, in order to keep the PR at a (more) reasonable size

add status_notification_sent-flag to application letters, which keeps track whether an email about the latest status change of their application has been sent to the applicants
introduce an additional application letter state: canceled, but dont show it as a radio button etc
some smaller refactorings where needed

Changes Unknown when pulling 3830602c8624cc506fc07d3b4af9a34d3ca53277 on 242_3.25_ApplicationCanceledStateRefactoring into ** on dev**.

Changes Unknown when pulling 9eac1a990ef4cadc5dc3a1562a39162d172e03d2 on 242_3.25_ApplicationCanceledStateRefactoring into ** on dev**.

Travis outputs a DEPRECATION WARNING. Maybe this is the cause for the strange message from coveralls. Did you add this assertion?
DEPRECATION WARNING: The assertion was not run because of an invalid css selector. unexpected '"event[hidden]"' after '[' (called from block (3 levels) in <top (required)> at /home/travis/build/hpi-swt2/workshop-portal/spec/views/events/new.html.erb_spec.rb:17) DEPRECATION WARNING: The assertion was not run because of an invalid css selector. unexpected '"event[published]"' after '[' (called from block (3 levels) in <top (required)> at /home/travis/build/hpi-swt2/workshop-portal/spec/views/events/new.html.erb_spec.rb:18)

Mhh, you didn't change this file, strange.

@Baschdl This warning is older, I got it two on my PR and there @coveralls worked

Yes, PR #455 introduced it

Coverage remained the same at 100.0% when pulling 24aab0bb0d3b287c53dc89f1d3d70f14fd0aea0f on 242_3.25_ApplicationCanceledStateRefactoring into 4223b9bcb7083aaa960a73f8956b8b4d77c8bd76 on dev.

Coverage remained the same at 100.0% when pulling 6ea12525f673399fda3047bc66d28e7aa4da152a on 242_3.25_ApplicationCanceledStateRefactoring into 4223b9bcb7083aaa960a73f8956b8b4d77c8bd76 on dev.

Coverage decreased (-0.3%) to 99.677% when pulling f870716ced4c5cb657e1cfcd3c9d018927b97258 on 242_3.25_ApplicationCanceledStateRefactoring into 4223b9bcb7083aaa960a73f8956b8b4d77c8bd76 on dev.

Coverage decreased (-0.3%) to 99.677% when pulling fb2c0054a1083e56b9609d561372c8d299720192 on 242_3.25_ApplicationCanceledStateRefactoring into 4223b9bcb7083aaa960a73f8956b8b4d77c8bd76 on dev.

We do have tests especially for the function you talk about, and introduced some more. They will directly point you to the wrong code, the only difference is that they test validations for the status, and not directly call the helper :)

Coverage decreased (-0.3%) to 99.677% when pulling b2222f6c25cb94265555dcce692b84a4e03af063 on 242_3.25_ApplicationCanceledStateRefactoring into af512a05569e5e9e09afb75921b24590e3c2b3d2 on dev.

Coverage remained the same at 100.0% when pulling 5cace87cdacf1c2fd0d449aaf1241bedd0775136 on 242_3.25_ApplicationCanceledStateRefactoring into af512a05569e5e9e09afb75921b24590e3c2b3d2 on dev.


HTML only component strangeness with bindable attribute order

I seeing oddness when binding two things to an HTML only component in certain cases. I'm not exactly sure what's going on here, but I suspect some kind of race. (or misunderstanding on my part)
Here is sample code that will reproduce the problem. I tried to simplify as much as I could.
poclist.html
<template>
  <require from="./poc.html"></require>

    <poc edit-mode.bind="editMode" list.bind="types"></poc>

</template>

poclist.ts
export class PocList {
    editMode = false;
    types = ["One", "Two", "Three"];
}

poc.html
<template bindable="editMode" bindable="list">

      ${editMode}

      ${t}

</template>

That sample code results in an empty table, which I don't expect. However, and this is the strange part, if I change the template tag such that the list bindable is before editMode as below, the list binding works. Note that in both cases, editMode is correctly bound.
This works!
<template bindable="list" bindable="editMode">

This doesn't work!
<template bindable="editMode" bindable="list">

Please let me know if you need any more information, or if I'm misunderstanding something.
Thanks!

There is probably some issue with how the dom apis are handling multiple instances of the same element.
That said, we clearly need to provide better documentation on html only components. The correct way to do this would be to have one bindable attribute. The value of that attribute would be a comma-separated list of names:
<template bindable="editMode, list">

Ahah! That works perfectly.
Thanks for the clarification!

I tried to find out the right syntax for bindable=, and it took me a while to find this. The docs do need a bit more info, at least to have the above example by @EisenbergEffect

@nym It is documented here. Here is how I found this information:

Go to http://aurelia.io;
Click Guides;
Click the magnifier icon in the top right to open search.
Type "html only".
Click the first result.

Do you think there is a way to improve this?

Ah, I missed that. I believe the solution would be to reference it in http://aurelia.io/docs/binding/basics#introduction
as well as probably
http://aurelia.io/docs/templating/html-behaviors-introduction#creating-bindable-properties-on-an-html-behavior
I had not been searching for "html only" but instead "bindable".


Bills that are deleted or made private are not always removed from the search index

This can be easily fixed by shelling into the server and rebuilding the index (6-8 minute operation), but it would be great if we didn't have to do this.
The update_index command from Haystack includes a --delete option that will remove items from the index that are no longer in the database, however last time I tried to use it, the command failed. Might be worth investing the time (1-2 hours, I'd venture) to debug and patch this.
Alternatively, we could rebuild the index at some interval, say very early every morning, when it's unlikely users are on the site.

Update: I thought Haystack had removed the option to delete items in the search index if they are no longer in the database, but it's just been renamed to --remove! I think the work here is to update the indexing commands in the hourly_processing DAG to use the --remove option.

Done and deployed!


Update murmurhash2.rs

What is the point of this PR?

Closing. If you have trouble compiling this crate, you probably just need to update rust.

you have reason, works fine after rustup update thx a lot


Remove Django 1.11 deprecation warnings

Deprecation warnings are a code smell. It'd be good to get rid of them. Additionally, it would make a future Django 2.0 upgrade that much easier.
How to turn the warnings into errors (the easiest way of finding them):
Add this to SigmaPi/SigmaPi/urls.py:
import warnings
warnings.simplefilter('error', DeprecationWarning)

Resolved #68


Cleanup PV claim ref. during restore and not delete

Current code cleans up the PV claim ref. if metro DR is in use, at the time of deleting VRG on a cluster.
If the PVC is not deleted as part of the workload cleanup then due to the PV claim ref. being cleaned, the PVC reports its state as "Lost".
This is observed due to changes made as part of commit cf63370e3fd8025f1a55d64cc6880a3941b958fc which started supporting failover in cases where PVCs are not deleted.
The fix is to not perform the PV claim ref. cleanup on delete and instead continue to cleanup the PV claim ref. when the PV is restored to the cluster as part of validatePVExistence.
In validatePVExistence if the pvExists and matches the to be restored PV, and is Bound, it is ignored. If not, it is cleaned up subsequently by updateExistingPVForSync for metro DR cases. updateExistingPVForSync will ensure a recreated PVC will bind back to the PV, and pvExists would ensure that an already Bound PV is left as is.
Fixes: #652
Signed-off-by: Shyamsundar Ranganathan<EMAIL_ADDRESS>

e2e tested RDR with STS deployments and failover/relocate actions

If the PVC is not deleted as part of the workload cleanup then due to the PV claim ref. being cleaned, the PVC reports its state as "Lost".

(Future) I think the VRG should take responsibility (from ACM or other custom operators like Crunchy) to own and delete all PVCs that it protects.  That will simplify things. In the case of MetroDR, we retain the PV as it is today. IOW, we should never leave PVCs behind even in the case of STS.


RedirectTrailingSlash undefined (type *atreugo.Atreugo has no field or method RedirectTrailingSlash)

RedirectTrailingSlash undefined (type *atreugo.Atreugo has no field or method RedirectTrailingSlash)
import "github.com/savsgio/atreugo/v8"

server := atreugo.New(atreugoConfig)
server. RedirectTrailingSlash(false)

$ go build
$ server.RedirectTrailingSlash undefined (type *atreugo.Atreugo has no field or method RedirectTrailingSlash)

atreugo version is:

github.com/savsgio/atreugo v5.4.0+incompatible
github.com/savsgio/atreugo/v8 v8.2.1

Which version are you using?
Remove github.com/savsgio/atreugo v5.4.0+incompatible from your go.mod

v8.2.1
when I delete it, the next time I 'go get' it's added again

Make sure that you have the correct import import "github.com/savsgio/atreugo/v8" in all go files

Yeah, I'm sure.

Remove go.sum and exec go get
Could you share your code?

sorry, I cannot share my code. Removed go.sum, cleared up go.mod, go get and the same thing... I use go 1.13 if it is make sense.

Ooohh! forgive me. I've remembered that the version 8.2.1 doesn't have server.RedirectTrailingSlash(false), now it's just in master brach.
But don't worry.
I will release the version `9.0.0 soon!

ok, I'll wait 9.0.0

I've just released v9.0.0


Set timeout in configuration file

See https://github.com/solid/community-server/pull/278#pullrequestreview-522955071

Agreed that a --timeout command line option is nicer than the current env var, but I don't think this would make a difference to the default behaviour. I think the current behaviour on Travis is due to https://github.com/solid/community-server/pull/278/files#diff-75f636d6110cfd85820e36dd51f11ee57b99de6ccff526bf4e24f4ff53316715R11 which makes it use v0.1.1 instead of latest master.
I'll merge this, tag a new version, and use that in https://github.com/solid/community-server/pull/278


Expose Node callbacks for adding and removing children

Helps godotengine/godot-proposals#724.
Helps godotengine/godot-proposals#2544.

I've found out that the engine already has such mechanism through virtual add_child_notify, remove_child_notify, and even move_child_notify (currently used only on C++ level for Control nodes such as GraphEdit).
With this, you don't have to:

get_tree().connect("node_added", self, "_on_node_added") and filter nodes with get_parent() checks.
Poll the children being added and removed from current one manually in _process().

This way, there's no need to introduce signals such as node_added/child_added, and instead use existing callbacks.
I don't know the performance impact behind get_script_instance() checks yet, but perhaps they're negligible enough for this feature to be implemented. The _process callback checks this every frame in contrast, so I think there's nothing to worry about performance-wise.
Usage
extends Node2D

func add_child_notify(child):
    # Request redraw whenever the child is "changed" is some way.
	child.connect("something_changed", self, "update")

func remove_child_notify(child):
	child.disconnect("something_changed", self, "update")

This is mostly useful for implementing general-purpose, adaptable classes to handle the API written by other developers, or when better encapsulation is desired (parent manages/controls children, and not vice versa, where get_parent() usage is typically discouraged).

I made this for 3.2 currently, 4.0 needs a separate PR due to removal of multilevel calls, but only if the idea behind godotengine/godot-proposals#724 is approved of course.
Test project:
expose_node_callbacks_add_remove.zip

Oh well perhaps I'm simply over-engineering this, because it's possible to "override" add_child etc via script:
func add_child(child: Node, legible:bool = false) -> void:
	.add_child(child, legible)
	print("New child added: " + str(child))

func remove_child(child: Node):
	.remove_child(child)
	print("Existing child removed: " + str(child))

But as you see, this:

Requires specifying the exact signature used in parent class (including default values), else you'll end up with:

Call the parent method explicitly, else it would shadow the method.

Not intuitive at all, the existence of this PR is a clear example for this, and likely feature requests such as #11260. 😛

Also, I'm not sure whether that's only GDScript's feature, or even a bug as a feature, due to things like #42968 (I've completely forgot about this behavior even after working on this, duh 😕).
Anyways, that's what C++ part of the engine provides, that's how I've discovered this in fact, so perhaps these can also be exposed to scripting, for consistency.

it's possible to "override" add_child etc via script:

Interesting, didn't know these were available to override.  That'll be a great work around.
Tested this build and it doesn't work for all nodes.  Not 100% of how the virtual definitions work here, but these methods seem to exist for Node specific CPP implementations.  Things like Control appear to have their own handling of it.  I may of missed something, but it didn't appear as though add_child_notify() was able to be overridden in Controls.
https://github.com/godotengine/godot/blob/5b993651bbe80e4b928ea87c20ff686da1f2723a/scene/gui/control.cpp#L438-L447
When looking at this, I was thinking it might be easiest to make a new signal and add it as the last line in these functions:
https://github.com/godotengine/godot/blob/5b993651bbe80e4b928ea87c20ff686da1f2723a/scene/main/node.cpp#L1165-L1182
Something like:
	/* Notify */
	//recognize children created in this node constructor
	p_child->data.parent_owned = data.in_constructor;
	add_child_notify(p_child);
	emit_signal("node_added", p_child);
}

This would also avoid the if branching you're concerned about.

Tested this build and it doesn't work for all nodes. Not 100% of how the virtual definitions work here, but these methods seem to exist for Node specific CPP implementations. Things like Control appear to have their own handling of it. I may of missed something, but it didn't appear as though add_child_notify() was able to be overridden in Controls.

Control::add/remove_child_notify was not calling base method (unlike other usage of this method in the engine), fixed now. Technically that can be considered an existing bug in the engine, but also I think that this could be avoided by calling those script callbacks directly in _add_child_nocheck and remove_child where these are actually called. Both approaches work, it's just that the first one allowed to catch an existing limitation as reported by you. 🙂

When looking at this, I was thinking it might be easiest to make a new signal and add it as the last line in these functions:

The reason why I went for approach with exposing callbacks is the previous rejection/concern of the idea that node_added/removed signals per node could potentially negatively impact performance for a use case which is not that common, again referring to #11260.

could potentially negatively impact performance

Not sure what you mean, is this speculative, or are you referring to a use case that you measured?

Control::add/remove_child_notify was not calling base method (unlike other usage of this method in the engine), fixed now.

Tested, appears to be working now.

could potentially negatively impact performance

Not sure what you mean, is this speculative, or are you referring to a use case that you measured?

I haven't tried to implement per-node node_added/node_removed signals, so I cannot tell what performance impact would this have, again it might be negligible since signals like tree_entered are also emitted, and according to reduz, signal handling should be efficient by design, so I don't know really.
I'll amend the PR description to say it only helps your proposal then.

My main use case with this PR would be getting notified of children added when a scene is istantiated, so that each node in the istanced scene receives all the relevant notification for all of their children, top to bottom.
Is this use case covered?

@samdze if I understand correctly, then yes, add_child_notify(child) would be called in any case, both while instancing and adding nodes at run-time manually with add_child(node), and NOTIFICATION_READY (onready) would be called after all add_child_notify(child) callbacks has been called.
If what you ask for is getting notification to scene root, the closest thing you can use is NOTIFICATION_INSTANCED, but this is likely not what you ask.

We just merged a PR which solves the two related proposals with new signals: #57541.
That being said we discussed this PR in a PR review meeting too and it seems still relevant to expose the existing Node _notify callbacks to the scripting API. This should be redone for master using the new GDVIRTUAL macro which makes defining and using virtual methods more efficient and user-friendly.

Thanks, this PR would be nice to implement, but it's possible to workaround it, especially with #57541. If someone feels motivated enough, feel free to build upon this PR, as I don't currently use master branch.

Superseded by #62661.


Fix for view's anti-aliasing issue

Anti-aliasing issue at form of gvr-keyboardview demo should be fixed.
GVRKeyboardS.O. will be fixed by other PR.
Use GVRViewSceneObject#setTextureBufferSize(int size) to ajust according to your application
layout to fix the anti-aliasing issue. The default buffer size should cover almost all issues.
GearVRf-DCO-1.0-Signed-off-by: Ragner Magalhaes<EMAIL_ADDRESS>

Looks good and works as expected. Planning to merge on Thursday.


Port to Safari

There exists a converter, but I haven't had time to try

It would be great to have a port for Safari.

Just tried it to build it for Safari and this is where I got to.
Install the extension in your Chrome browser.
Figure out the path to the extension on your filesystem.
Then run (NOTE: make sure that you escape any whitespaces in the path below):
xcrun safari-web-extension-converter --project-location \
~/dev/remarkable2/safari-repub2 $HOME/Library/ApplicationSupport/Google/Chrome/Profile\ 1/Extensions/blkjpagbjaekkpojgcgdapmikoaolpbl/4.1.0_0

Xcode opened & I built the project for macOS, which installed the extension to Safari.
I had to enable it in Safari's Extensions.
But when I tried to use the extension, I'd get just this showing up on the icon:

And it would be just stuck there.
I thought that it might be down to the particular site I was on, so I tried it on a few others. But they all behaved the same as above. Stuck at 25%.
When you run the browser extension in Chrome, the very first step is that it prompts you to allow it to upload to reMarkable cloud. But in Safari, nothing like that happened. The steps listed above are exactly what happened.
Hope this provides some context and inspiration for you to port it to macOS.
Thanks for your work 🙏


Compiling JS for older browsers

Is this a bug report?
No
I wanted to repurpose an old iPad running iOS 9 for a simple web app that will always be running. I figured I wanted to give it a try using create-react-app.
I was using const, let and default values in function arguments causing Safari on iOS 9 to fail parsing of the JS.
The only way I could make this work (without making my code ugly) was doing the following:

npm run eject
npm i babel-preset-env
Add "iOS 9" to browserslist.development and browserslist.development in package.json

Is there a way to do this without having to eject? Actually re-using the same browserslist as came with create-react-app makes it feel like this should work out of the box, but for me it did not seem to.
I read this ticket #3776 but even though it is seemingly merged, it is not actually doing anything.

Please complete the issue template in full so we can assist.

Oh, but the template said that if the answer was 'no' I didn't have to follow the script.
Anyway, I just tried again and after resetting back to before I ejected, installed the package and set the browserslist, it worked. I think it might have been because my resetting cleared some sort of cache. So issue resolved. Sorry for taking up space.

Sorry about that @Ralle. You're correct. I mis-read the original post.
Glad you got it sorted!


Add footnote support

Closes #191

So do we think we should have this first, as it's better than nothing, or should we first find out how we should have our footnotes, before starting? I am thinking the latter, as we don't want users to start using a service and then changing it suddenly. Pluss we might get compatibility issues if we migrate to another footnote solution.

Here is a screenshot of how it can look like with floating footnotes (from Game Programming Patterns):

I agree that we should decide on what kind of footnotes we want first, since different types of footnotes might be used in different not-particularly-compatible ways.

I like those footnotes too. I am thinking it should be a toggling thing, that you toggle them on and off. One issue we might have to resolve is that we have a menu on the left that can be toggled to be shown and not, and will then have footnotes on the right that can be toggled to be shown and not. Not sure how the flow there will work, but I guess we can just try and see for ourselves.


[Sim] Get inner product MatMul working

#6 adds in test for X(i,j) = B(i,k)*C(k,j) for X, B, and C are all CSF/DCSR
Need to add in randomized tests for other formats

Need sparse accumulator working for other dataflows


D3 map and topojson files of 2014 parliamentary constituencies

Thanks for providing a great resource! I was interested in contributing a d3 map and some simplified topojson files derived from the shapefiles back to your repo. Maybe someone could use it :-) This is my first ever PR so apologies for any newbie mistakes in advance.

@mukhtyar Saw it today :( Sorry about that.
Can we do some reorganizing?
You have added a file
parliamentary-constituencies/india_state_2014_simplified.topojson
This needs to go into states folder right?

No problem! It was a fun exercise. Sure we can do some reorganizing. Should I move the states file into a new States folder, update the code and resubmit the pull request?


Check problem type after reading from file

Need to set has_int and has_qc when appropriate.
Somewhat related: not sure if has_qc should be true if only the objective is quadratic (QP, MIQP).
Both CPXlpopt() and CPXqpopt() accept the model, but I haven't checked if they actually do the same thing or maybe use a different method (possibly different defaults).

Cool, thanks.
It'd be interesting to see if CPLEX treats the two differently or not: my hope would be that it would be smart enough to apply the best defaults regardless of which opt function is called, but who knows.


Load data from last wordpress

Hello, the application can not retrieve the data from the new version of wordpress with JSON-API plugin,
Do you have a Solution Please?

Hi
It was better to say that you could'nt get app to work cause i updated my test wordpress installation and JSON-API plugin and the old app is still working :D
please explain what did you do? and provide your wordpress address so i can check if you have the right configuration

Thanks;
my adress isi www.misapi.unaux.com/api/

the api is allright. what's wrong with your app? do you get error? if yes send me the logcat please

Sorry, I dont have any error in my Code

I have just this error at the opening project file in Android Studio

update the projects gradle version and compile it


Update sbt-scalafmt to 2.4.0

Updates org.scalameta:sbt-scalafmt from 2.3.4 to 2.4.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "sbt-scalafmt" } ]

labels: sbt-plugin-update, semver-minor

Codecov Report

Merging #108 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #108   +/-   ##
=======================================
  Coverage   37.80%   37.80%
=======================================
  Files           3        3
  Lines          82       82
=======================================
  Hits           31       31
  Misses         51       51

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a37bbf1...9372512. Read the comment docs.


URLs have changed; cannot download episodes when rights expired

It seems like URLs have changed, and I wonder if that causes some problems.
This is the problem I'm struggling with:
$ nrk-tv-downloader.sh -n -d -u https://tv.nrk.no/serie/kaptein-sabeltann/sesong/1/episode/19/
Program "Kaptein Sabeltann - Kongen på havet 1:26"
 - Tv program is not available:  program rights has expired

There may be several problems, one is that the URL seemingly has changed. One is that it first tries to download episode 1, when it was supposed to get episode 19. The last is that it gives up because the rights for episode 1 has expired. I don't know which is actually the root cause here.

Did you get it working @kjetilk?
Just comment, and ill open the issue if it still doesn't work.

Actually, I don't know, since I'm not aware of a series right now that has partially expired. I'll comment again if I find something.


Framework.dart problem

Hi guys, this is my problem, really that problem appear today, help!
/C:/src/flutter/packages/flutter/lib/src/widgets/framework.dart:4623:15: Error: Named parameter 'Element' is required and can't have a default value.
required  Element = super.value,
^^^^^^^
/C:/src/flutter/packages/flutter/lib/src/widgets/framework.dart:4623:25: Error: Expected identifier, but got 'super'.
required  Element = super.value,
^^^^^
/C:/src/flutter/packages/flutter/lib/src/widgets/framework.dart:4452:7: Error: No named parameter with the name 'value'.
value: this,
^^^^^
/C:/src/flutter/packages/flutter/lib/src/widgets/framework.dart:4621:3: Context: Found this candidate, but the arguments don't match.
_ElementDiagnosticableTreeNode({
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/C:/src/flutter/packages/flutter/lib/src/widgets/framework.dart:4621:3: Error: The superclass, 'DiagnosticableTreeNode', has no unnamed constructor that takes no arguments.
_ElementDiagnosticableTreeNode({
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/C:/src/flutter/packages/flutter/lib/src/widgets/framework.dart:4633:10: Error: The getter 'element' isn't defined for the class '_ElementDiagnosticableTreeNode'.

'_ElementDiagnosticableTreeNode' is from 'package:flutter/src/widgets/framework.dart' ('/C:/src/flutter/packages/flutter/lib/src/widgets/framework.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named 'element'.
if (!element.debugIsDefunct) {
^^^^^^^
/C:/src/flutter/packages/flutter/lib/src/widgets/framework.dart:4634:35: Error: The getter 'element' isn't defined for the class '_ElementDiagnosticableTreeNode'.
'_ElementDiagnosticableTreeNode' is from 'package:flutter/src/widgets/framework.dart' ('/C:/src/flutter/packages/flutter/lib/src/widgets/framework.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named 'element'.
json['widgetRuntimeType'] = element.widget.runtimeType.toString();
^^^^^^^
/C:/src/flutter/packages/flutter/lib/src/widgets/framework.dart:5197:7: Error: No named parameter with the name 'value'.
value: this,
^^^^^
/C:/src/flutter/packages/flutter/lib/src/widgets/framework.dart:4621:3: Context: Found this candidate, but the arguments don't match.
_ElementDiagnosticableTreeNode({
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

FAILURE: Build failed with an exception.

Where:
Script 'C:\src\flutter\packages\flutter_tools\gradle\flutter.gradle' line: 1159

What went wrong:
Execution failed for task ':app:compileFlutterBuildDebug'.

Process 'command 'C:\src\flutter\bin\flutter.bat'' finished with non-zero exit value 1

Try:

Run with --stacktrace option to get the stack trace.
Run with --info or --debug option to get more log output.
Run with --scan to get full insights.

Get more help at https://help.gradle.org

BUILD FAILED in 1m 47s
Exception: Gradle task assembleDebug failed with exit code 1

You already fix the problem? I have the same problem and I don't find any solution

It is necessary to reinstall Gradle.
It helped me.

complete guide please i also didnt solve this issue?

Hi OpenKode! Can you give a brief explanation of how to do that? Thanks!

i too i have the same error i dont know haw to fix it please help


bug fix: exec of DEL cmd caused JSON decode error

When plugin is executed with a DEL command, it does not
print result to stdout unless there is an error. Therefore
it stdout bytes should not be passed to json.Unmarshal.

@squaremo PTAL

Good spot; LGTM by eye, and testing manually.


Pyloxone Startup - argument of type 'NoneType' is not iterable

Which Model do you use from loxone? Miniserver? Gen1 or Gen2?
Gen2
Which software version does your loxone use?
<IP_ADDRESS>
How did you install HomeAssistant? Over Hassio or manual install?
HASSIO
Which Version do you use of HomeAssistant?

Home Assistant 2023.3.3
Supervisor 2023.03.1
Operating System 9.5
Frontend 20230309.0 - latest
PyLoxone 0.5.0b3
Describe the bug
Pyloxone isn't starting.
I don't know when exactly this error has started, as I've updated pyloxone and HomeAssistant recently.
I've tried to reinstall&reconfigure the integration, but nothing seems to work.
I've also tried to reconfigure the settings with dns.loxonecloud.com/ with HTTP&HTTPS.
Normally it is working just with the internal IP:80

Paste the error log with the following settings:
2023-03-13 10:12:16.124 DEBUG (MainThread) [custom_components.loxone] Error while loading token...
2023-03-13 10:12:16.124 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry PyLoxone for loxone
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 383, in async_setup
    result = await component.async_setup_entry(hass, self)
  File "/config/custom_components/loxone/__init__.py", line 264, in async_setup_entry
    if "_token" in token:
TypeError: argument of type 'NoneType' is not iterable

@coreGreenberet if you have issues please do not use the beta version. Go back to the newest stable version.

I've just tried it again with 0.4.3. It just did start correctly again.
I thought the beta version is here for tests. And if there is an issue we should report it, so that the problems won't happen in the stable release

@coreGreenberet how did you downgrade? If you downgraded with hacs do it again. I always need to do it twice in a row to really downgrade.  If you do it only once it is still the beta.

@coreGreenberet do you still have the problem?

No after the downgrade it was working fine again. I also just had to install it once.

@coreGreenberet normally if you upgrade to a bets version from the newest stable version this  error should not be there. The token file has changed and in the newest stable I support both. And on the beta branch only the new format.


Registry.listCredentials() returns an inner object

We currently return a RegistryListCredentialsResultInner object.

fixed

we'll just need to remember to either
a) reapply the patch after regenerating with a new Swagger,
b) or address the underying issue in Swagger if that's where it is
c) or address this issue in code generator, if that's where it is
d) or introduce a layer of indirection - a wrapper for it


merge from arlac77/npm-package-template

package.json

chore(package<EMAIL_ADDRESS>chore(scripts): cover@#overwrite c8 -x 'tests/**/*.mjs' --temp-directory build/tmp ava && c8 report -r lcov -o build/coverage --temp-directory build/tmp
chore(package): set $.ava.require='esm' as in template
chore(package): set $.ava.files='tests/*-test.mjs' as in template
chore(package): set $.ava.extensions='mjs' as in template

.travis.yml

chore(travis): add [object Object],[object Object],[object Object] (jobs.include[])
chore(travis): add 12.11.1 (jobs.include[].node_js)
chore(travis): add -npm (cache)
chore(travis): add  (script)

Coverage remained the same at 98.4% when pulling e169208b028ba1857b6e0dd8b973f59cde81e38f on npm-template-sync/1 into 7edd516aa885e16e9130c147fa8dd6f3098e3316 on master.

:tada: This PR is included in version 2.1.10 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Error Running Lightning Pose App

I am trying to install Lightning Pose app following this guide on a desktop with Ubuntu 22.04. So, I made sure to run the 'pip install fiftyone-db-ubuntu2204' line.
The error I am encountering can be seen down below:

In this image, after launching the app, I upgraded Lightning Pose to the newest version and running the app failed with the error message being 'ImportError: cannot import name 'optimize_smoothing_params' from 'eks.core.'
The same issue also occurred when I tried to run it without updating the application.
Another note, a couple weeks ago I was able to successfully set up and run the Lightning Pose app on another desktop with Ubuntu 22.04. However, recently it has not been working. I was wondering what the cause of that could possibly be.
Thank you for your time.

Hi @jonathanlee3, thanks for raising this issue. This error came from us updating the ensemble-kalman-smoother package on PyPI to version 2.0.0, but we haven't yet updated the app to be compatible with this change. For now you can just downgrade the EKS package by running (from your Pose app conda environment) pip install ensemble-kalman-smoother==1.1.0. Please try this and let me know if that clears up the issue!

Hi @jonathanlee3, thanks for raising this issue. This error came from us updating the ensemble-kalman-smoother package on PyPI to version 2.0.0, but we haven't yet updated the app to be compatible with this change. For now you can just downgrade the EKS package by running (from your Pose app conda environment) pip install ensemble-kalman-smoother==1.1.0. Please try this and let me know if that clears up the issue!

Hello @themattinthehatt,
Sorry for getting back to you so late!
After running the line 'pip install ensemble-kalman-smoother==1.1.0' the Lightning Pose app seems to be working perfectly!
Thank you so much for the help.


Improve test coverage for ServiceIOGroupTest and BatchServerTest:

Improve test coverage for ServiceIOGroupTest:

ServiceIOGroupTest.read_signal_exception

ServiceIOGroupTest.write_control_exception

ServiceIOGroupTest.save_control

ServiceIOGroupTest.restore_control

Relates to #2016  [bug report/feature request/story] from github issues

Pull request successfully merged into dev branch.


Sync fail

I've already added Github account, but sync fail and return unknown error. Can anyone help me how to sync to Github. Many thanks

@seokju-na can you help me?

I have the same issue.

Tried cloning an existing repo and giving broader permissions to the oath2 token. Now I get

I also have this issue. I'm on version 1.0.0-beta2 - installed the dmg for MacOS 10.15 Catalina. I've logged in via Oath2 token. I can add the remote repo url successfully, but when I add a note into this new repo, commit, I get the sync fail error.


Improve model of heap memory management

The current default model for malloc simply assumes that it generates a fresh result every time it is called.
This is inconvenient for comparative analysis, because if the two programs have an "identical" call to malloc, we currently assume each call gives a different result.  This causes false positives where we think the programs differ because of this different result value or, more subtly, because the memories differ after writes through those pointers.
What to do?  We certainly shouldn't assume malloc's result is determined by its arguments, as it is stateful.  In the real world, malloc's result is determined by its arguments and a bunch of allocator state stored in memory.  So it would be technically accurate to say malloc's result is determined by its arguments and the current state of memory, but this doesn't really work for CBAT because we aren't modeling all that allocator state in memory.  Indeed, if the model of malloc doesn't also change memory, this model would result in two consecutive calls to malloc returning the same results.
In principle we could build an accurate model of libc's state in memory and dutifully track the ways malloc changes it.  But that's very time consuming (and would need to be redone for each libc implementation) and also probably extremely inefficient for analysis.
So, how about this:  Model malloc with a pair of uninterpreted functions: malloc_result_model, which is like malloc but with an extra integer parameter representing the current allocator state, and malloc_state_update, which takes the same arguments and models the change to the heap state when malloc is called.
The high level idea is for malloc_result_model's extra allocator state parameter to be different at each call to malloc within one program, but the same between the two programs in comparative analysis.  Of course, we don't actually have a way to "match up" calls to malloc in the two programs, but perhaps it's good enough to just assume that the heap state is the same at the start of the two functions being analyzed.  The function malloc_state_update returns the new allocator state value for the next call to malloc.
I think would be an improvement to our current model.  We still keep the idea that each consecutive call to malloc returns a different result (because the state parameter changes), but in a way that is deterministic enough so that we can get the same results in comparative analysis.  I can, however, see two potential issues, which maybe we can ignore for now:

This model pretends that the allocator state is totally separate from memory.  But of course this allocator state parameter is a model for a whole bunch of data that malloc relies on, which is stored at various different places in memory.  Writes to memory don't change the allocator state in our model, but might in the real world.  This is a potential source of false NEGATIVES.

This model allows the allocator state to change after each call to malloc, but doesn't require the allocator state to be a fresh unique result every time.  This is a potential source of false positives, where malloc in this model can return the same value more often than is really the case.  On the other hand, if we somehow added the assumption that each change to the allocator state results in a truly unique result, that would also be wrong, and in a way that can cause false negatives.

To see if I'm understanding this correctly, I'm going to write an example. Please correct me if I'm wrong anywhere. Say we have two programs that are identical and look like this:
void* foo(size_t size) {
  int* ptr = malloc(sizeof(int));
  *ptr = 1;
  free(ptr);

  return malloc(size);
}

I will refer to the first malloc as malloc1 and the second malloc as malloc2. At the start of the analysis, we have the postcondition and the allocator state called allocator_state. When WP reachs the malloc2 in the modified binary, two things change:

We replace all locations of RAX in the postcondition with malloc_result_model(RDI, allocator_state).
We keep track of our new allocator state which is represented as malloc_state_update(RDI, allocator_state) and add the following constraint, malloc_state_update(RDI, allocator_state) != allocator_state.

Now, we reach malloc1 in the modified binary. The changes in this case will be:

Replace RAX with malloc_result_model(RDI, malloc_state_update(RDI, allocator_state))
Update our state to malloc_state_update(malloc_state_update(RDI, allocator_state)) and add the constraints:

malloc_state_update(malloc_state_update(RDI, allocator_state)) != malloc_state_update(RDI, allocator_state)
malloc_state_update(malloc_state_update(RDI, allocator_state)) != allocator_state

Now, we visit malloc2 in the original binary. This is the part where my understanding is starting to get iffy.

Do we revert back to the original allocator_state?
How do we guarantee that malloc_state_update(RDI_orig, allocator_state) and malloc_state_update(RDI_mod, allocator_state) return the same new state?

Other questions I have are:

Would we want to have this spec for a single binary analysis?
Would this new spec simply replace our current spec, or would we have this as an extra option?
What happens when we visit a free() in the binary?

I think the easiest way to explain this is to say we're going to make up a new register, ALO, which holds the allocator state.  And ALO is going to get updated at memory management calls just the same way we update RAX to account for their return value.
So, for example, you said:

When WP reachs the malloc2 in the modified binary, two things change:

We replace all locations of RAX in the postcondition with malloc_result_model(RDI, allocator_state).
We keep track of our new allocator state which is represented as malloc_state_update(RDI, allocator_state) and add the following constraint, malloc_state_update(RDI, allocator_state) != allocator_state.

This is right, and the way we "keep track of our new allocator state" is to do what you did for RAX: replace all locations of ALO in the postcondition with malloc_state_update(RDI, ALO).  I'm not sure we actually need to add the constrain ALO != malloc_state_update(RDI,ALO) - I think I would try it without that first.
So then when we reach malloc1 in the modified binary, we update RAX and ALO again in the same way.  I'm a little shaky with what's going on with RDI here, but for some values RDI and RDI', this will mean we replace ALO with malloc_state_update(RDI', (malloc_state_update(RDI, ALO)).
You asked about how we relate the two programs.  The idea here is we have init_ALO_orig and init_ALO_mod just like for any other register, and we assume these are equal, and also that init_ALO_orig = ALO_orig0 and init_ALO_mod = ALO_mod0 (or whatever the names end up being).
So, when we look at RAX after malloc1 in the two programs, one will be something like malloc_result_model(RDI_orig0, ALO_orig0) and the other something like malloc_result_model(RDI_mod0, ALO_mod0).  But Z3 will be able to work out that these arguments are equal and therefore the results are equal, because of our standard assumptions about registers.
If that doesn't make sense, let's meet up and work through it in more detail - it will help to work some examples out looking at what precondition we're generating with the current model.
To answer your other questions:

Would we want to have this spec for a single binary analysis?

I think it would work fine single program analysis (though I'm not sure it has many benefits over the current model for that case). Probably we can use it to keep things uniform.

Would this new spec simply replace our current spec, or would we have this as an extra option?

My instinct is to add it as an option, but I could be talked out of that if it's going to be a real pain to check whether the option is turned on in many places in the code.

What happens when we visit a free() in the binary?

We should treat free (and basically all libc memory management funtions) the same way.  So free will get an extra argument in the model for the allocator state, and we'll have another uninterpreted function free_state_update to model how it changes the state.  This model isn't detailed enough to capture the idea that free returns a specific pointer to the allocator state (but we could look into ways to capture some of that detail in the future).


Provision dev environment in separate AWS account

In order to have a safe space for doing potentially disruptive development work, we want our development environment to exist in a separate AWS account.
Acceptance Criteria

[ ] WHEN we push a change to the cf-deploy-cf repo THEN we see the change roll out to a live dev environment in a dedicated AWS account for dev environments

@mxplusb last said on May 23rd:

Made progress on deploying the infrastructure, need to go through and test it a bit more.

@brittag this should go on the private board because it concerns how we manage our environments, having it in the open is not worth the potential security risk.


SSL error accessing docker webui

Hi there,
First off, thanks for wrapping up this great docker image! Has been working great till the latest version.
When I try to access the webui on my local network (running on unraid) I get the following SSL error:
"SSL_ERROR_RX_RECORD_TOO_LONG"
Any ideas?

Hello,
I have never run into this error before, and from quick google search it seems this error is unique to firefox due to misconfigured ssl certificate they suggest doing forced reload. Ctrl+Shift+r or Shift+reload button.
They offer more suggestions in https://support.mozilla.org/en-US/questions/1222739

Hmm weird - it wasn't working in either firefox or edge earlier but all seems to be working now without having changed anything...
Will mark this as closed & thanks again for the awesome docker image!


cmd/vendor/.../pprof/internal/binutils: TestMachoFiles fails

https://build.golang.org/log/1cbedd8b8b11d1baadcbfabcf8d8809ece5ab307
New failures caused by cl/101736
Trybot run didn't detect this early.

Sigh. I suggest reverting, opening an issue upstream, and then we can re-vendor again when it's fixed. IIRC the darwin trybots are down, we can't afford having the all the 3 darwin builders down too.

Strange. I can't reproduce the test failure on my mac.

Filed upstream: https://github.com/google/pprof/issues/342


Sonic '06 PKG Reading/Writing

Added reading and writing support for the PKG format.

Thanks! Yeah that's happened because of a tab character that somehow got introduced in a file that has spaces elsewhere. Not a big deal though.


Funky graph on mobile website

Hey there!
Noticed the graph makes the page render funky on mobile, so figured I’d report it. Thanks for the awesome blog post btw!
Screenshot

Interesting! I'll look into that.
Thanks for letting me know.

Looks like this bug and #98 are the same error -- I'm setting the width of the graph's SVG object but not the viewbox. If I want this to act like the graph above it I need to set the SVG attributes in the same way, to the same values. This wasn't something I broke when I switched to four-up mini timeline graphs. It was broken before that, too.


Fixes during Henri-2021 that need to get migrated to main

Running list of everything we had to adjust that needs to make it into the main repo:

[ ] Switch river geom fetch to using nhdplustools as the source (see https://github.com/USGS-VIZLAB/vizstorm-GIF/commit/4bd309a21050592e931473800d69e8dff9a86cb2#diff-1aa42baff6599120ec10682d10f92b046bacb4237e17359cba55397949618b0b)
[ ] Implement the sp stencil bug issue mentioned in #237 (see https://github.com/USGS-VIZLAB/vizstorm-GIF/blob/Henri-2021/1_fetch/src/fetch_precip_nc.R#L24)
[ ] Add the remake_file = getOption() solution since this pipeline was built before the switch to the getters.yml approach. Although, might be able to set the option for the whole pipeline instead of adding this in a bunch of places (see https://github.com/USGS-VIZLAB/vizstorm-GIF/commit/7ac3ed7c236cc7bddb492834abf0647bb2494073#diff-1965d7a54599d150f5f6e5609f4db440418fee35d77dcdb3e3e1460a4dcf18be)
[ ] Strip out the dim() attribute before binding columns (see https://github.com/USGS-VIZLAB/vizstorm-GIF/commit/a007951bcfcf1bc815f1708986a640e08c93b4fe)
[ ] Add timestep names back to the precip rasters (see https://github.com/USGS-VIZLAB/vizstorm-GIF/commit/1330bc67b1cfc61144dc8057f52f16430c17903e)
[ ] Include the par(mai = c(0,0,0,0)) for the precip plot function bc we discovered that the setting was somehow getting changed during Sally (see https://github.com/USGS-VIZLAB/vizstorm-GIF/commit/bbec9f1887da2865394761831cda8bdb90442209)
[ ] Edit the mustache template for the outro gif tasks to use timeline_fun_a and not datetime_fun_a. We never made that switch there after we implemented the new time visual solution (see ???)
[ ] Add note to viz_config.yml about how to look up stn code (see https://github.com/USGS-VIZLAB/vizstorm-GIF/blob/Sally-2020/viz_config.yml#L4)

Look at the final files in the Henri-2021 branch that go with the commits above in case there were additional commits that improved those. Just included those to help orient you to the needed changes.

wow, that's a lot of buggy-stuff. Nice work tracking it all down.

@collnell still rockin' it, despite this old, buggy repo 😭

[ ] gage_river_geometry needs to be revisited, was not plotting correctly on Henri-2021

@collnell I think all of that except gage_river_geometry was fixed in #241?

Closing this issue. After working in Ida, I believe the challenges with gage_river_geometry for Henri could have been addressed by a force rebuild.


README.md in cmd/scheduler is out of date

The Scheduler readme is quite out of date and should be updated. The last section is possibly redundant and can be removed.

Fixed by #593


[Feature]: Add support for WASM file format in assets in theme app extensions

What area(s) will this request affect?
App, Extension, Function
What type of change do you want to see?
New feature
Overview
Please add .wasm to the allow list of file type extensions in theme app extensions.
Motivation
Due to https://github.com/Shopify/function-examples/discussions/329, I had to port my Shopify Functions to Rust.
However, my app customers heavily requested to be able to use it on the storefront as well.
Initially, I wanted to reuse my Rust code in the form of a .wasm binary in my theme app extensions (which is, in theory, the main use case of WebAssembly).
However, because theme app extensions only allow specific files to be included assets, this is impossible, so I currently have 2 separate implementations of my logic: one in Rust, and another in TypeScript.
This leads to duplicate effort when building apps on top of Shopify's latest APIs.

how would you use it in the frontend?

how would you use it in the frontend?

@blanklob
Great question.
The goal is client-side calculations of discounts.
My app provides various logic conditions for when discounts should apply, and I'd prefer to have 1 single implementation that can be used in multiple places.

You can already do this, by just hosting your WASM elsewhere. I'd be quite careful whilst doing this. WASM can be compressed very well (normally up to 50%), but you'd still be looking at sticking a ~50kb file in the storefront. The better approach is sadly to re-write the logic in Javascript, IMO. There are other big issues as well.
With Discount Kit, we run the WASM as an endpoint which can then be called from the storefront. We are working on a significantly better approach which I can share in future.

@bkspace Thanks for your response.
I'll probably stick with having a separate TS implementation, which gets built into the theme app extension. That way, I don't have to host it on my server.

Ah, sorry, I missed the reference to the other issue. @nickwesselman is there anything to update about performance improvements? I wonder if this is just going to be a temporary issue anyway, and if JS will be sufficiently performant soon, then this will become a non-issue.

👋  Hi @thosakwe!
Thanks for this suggestion. We've implemented WASM file support for theme app extension assets. This change should be available in the next minor release. 🎉
(I saw you commented on the change itself, but am commenting here as well for visibility).


FX_Intraday / Daily not working, right?

Hello kids,
I had an invalid API call for both FX intraday and daily.. I could pull the rate but no luck with this one
data, meta_data = cc.get_currency_exchange_intraday(from_symbol='EUR',to_symbol='USD', outputsize='compact')
Just to be sure I didn't fuck up I went to the docs and tried the demo, same error
https://www.alphavantage.co/query?function=FX_INTRADAY&from_symbol=EUR&to_symbol=USD&interval=5min&apikey=demo
Thanks baby

Hi Matog666,
It looks like there is an issue with the endpoint at the moment, I'll put in a ticket!

The issue has been resolved. Closing.


support for data files

The possiblity of data files that can be used by a program
Probably something that should be given thought to as to how to create a general solution.

Is this same as the request for the filesystem? We have a repo https://github.com/microsoft/pxt-filesystem, If not, please add complete details.

Can you please add additional information for this issue so it is actionable?

This is copied from slack: Jonny suggested to be able to add data files in the project (e.g. Text file) and we would automatically pre-populate the filesystem with those files when flashing the device.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Abhijith Chatra<EMAIL_ADDRESS>Sent: Wednesday, November 9, 2016 6:41:18 PM
To: Microsoft/pxt
Subject: Re: [Microsoft/pxt] support for data files (#708)
Can you please add additional information for this issue so it is actionable?

You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt%2Fissues%2F708%23issuecomment-259587475&data=01|01|jhalleux%40microsoft.com|b5c6eb850d4e42dc64b008d409130daa|72f988bf86f141af91ab2d7cd011db47|1&sdata=gVj0AB9FKYXHJyH19705QYNDneW9RIflVGwbgaZYpYY%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD-4Ka9PefHZXWonOK0sxwwsvqmbd5bQks5q8oROgaJpZM4KrGya&data=01|01|jhalleux%40microsoft.com|b5c6eb850d4e42dc64b008d409130daa|72f988bf86f141af91ab2d7cd011db47|1&sdata=dl6pC1k2g63Mb%2Bxl3JjQZoIOqaDGbxx%2B0GlgC0XsO04%3D&reserved=0.

I will review pxt-filesystem and come with some use cases to make actionable and at MS option, create the use case/issue in pxt-filesystem so this issue can be closed.
Pelikan can close if he believes that pxt-filesystem should be used.

Please move this issue to Microsoft/pxt-filesystem.


Changes scope from ruby to rails and adds js.rails scope for some snippets

This PR duplicates the work done here https://github.com/matthewrobertson/ERB-Sublime-Snippets/pull/29
It also adds js.rails scope to er, pe, cli, if, end, else, elsif, unless.

@matthewrobertson
Any chance to merge this PR soon?


WIP: Add check that "Directory name in GFonts repo structure must match NameID 1"

This pull request addresses the problems described at issue #2302

@felipesanches this resolves a P0 issue so would be great to get this merged soon :)

@felipesanches this resolves a P0 issue so would be great to get this merged soon :)

I will give it a second try tomorrow.

@felipesanches ping

I'm back working on it. I'm making some changes and I will ask for a new review from @m4rc1e.

I think this is good now. It addresses all concerns brought up by @m4rc1e

I think this is good enough for merging. Please open a new issue if you see any problem, @m4rc1e


[ENH] Cache found compilers

Feature Request
Cache found compilers while having an open VSCode session
Needed changes

Add cache for found compiler and debugger path
If cache is present use this instead of researching the tools in the PATH

Currently not possible.


AlephOne and Marathon scenarios

Motivation for this change
The Marathon Trilogy is a science fiction first-person shooter video game series from Bungie, originally released for Mac OS - https://en.wikipedia.org/wiki/Marathon_Trilogy.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build alephone-marathon


Sentence completion

Added fillers to complete the sentence. Kindly review!

@OOberoi The sentence seems correct to me before your changes and not after. Can you provide a few more details as to the purpose of this change?

Hey Arthur, I read the description for "Missing property values" couple more times. Even though, you could pass it as is, however, I would word it as the following with minor changes. That being said, I wholeheartedly and respectfully would leave it at your discretion.
"In the previous example, we removed the "TrackingNumber" property from the order object. Because of how indexing works in Cosmos DB, queries that reference the missing property somewhere else, than in the projection, it could return unexpected results. For example:


MapDeserializer doesn't support borrowed strings

Hi,
I was trying to deserialize a struct from a impl Iterator<Item = (&str, &str)> but as I try to deserialize my map i encounter this error:
invalid type: string "val", expected a borrowed string

This is the code:
use serde::{de, Deserialize};

#[derive(Deserialize, Debug)]
struct MyStruct<'a> {
    borrowed: &'a str,
}

fn main() {
    let map = [("key", "value"), ("borrowed", "val")];

    let deserializer =
        de::value::MapDeserializer::<'_, _, de::value::Error>::new(map.into_iter());

    let deserialized = MyStruct::deserialize(deserializer).unwrap();
}

Investigation
I investigated on the issue and the problem is that IntoDeserializer for an &'a str only supports unbounded lifetimes and only uses StrDeserializer instead of BorrowedStrDeserializer
The code that calls .into_deserializer(): https://github.com/serde-rs/serde/blob/1aebdc2760a7772c0fdc44329acb3409fc42395e/serde/src/de/value.rs#L1225
Code that implements IntoDeserializer only for unbounded &str:
https://github.com/serde-rs/serde/blob/1aebdc2760a7772c0fdc44329acb3409fc42395e/serde/src/de/value.rs#L407-L416
Temporary solution
The temporary solution is to map the iterator around a newtype that implements IntoDeserializer for bounded &str:
struct BorrowedStr<'a>(&'a str);

impl<'de, 'a: 'de, E: de::Error> IntoDeserializer<'de, E> for BorrowedStr<'a> {
    type Deserializer = BorrowedStrDeserializer<'de, E>;

    fn into_deserializer(self) -> Self::Deserializer {
        BorrowedStrDeserializer::new(self.0)
    }
}

fn main() {
    let map = vec![("key", "value")];

    let deserializer = MapDeserializer::new(
        map.into_iter()
            .map(|(key, value)| (BorrowedStr(key), BorrowedStr(value))),
    );

}

What would be a good solution for adding support for borrowed types to map deserializers to serde?

I think #2498 may be the missing piece here.


This documentation page is not helpful

It does not say what running this command will do - what metrics will be collected?
When enabling at the server level, how do we actually configure what performance counters, etc. are collected?
How does this module get run?  Does it launch a new process?  If so what is this process called
Does installing this require a server reboot?
If we want to collect SQL Server Performance Counters, how do we do that using this PowerShell?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 36e5b161-ef9e-41a7-8eff-14202a9556f6
Version Independent ID: 90a657f8-a6c5-def6-1f4b-fd3081da1493
Content: Azure Application Insights Agent - getting started - Azure Monitor
Content Source: articles/azure-monitor/app/status-monitor-v2-get-started.md
Service: azure-monitor
Sub-service: application-insights
GitHub Login: @TimothyMothra
Microsoft Alias: tilee

@Cloudmersive Thank you for the feedback!  We are investigating this and will get back to you shortly.

#assign:lgayhardt to take care of updates to the docs.

Awesome, thank you!

For product questions we ask that you ask your questions here in Microsoft Q&A: https://docs.microsoft.com/answers/topics/azure-monitor.html. Once you question has been answered if you would like to see the answer covered in the docs please open a new issue and link to the thread of the answer.

#please-close


Wrong scroll position on field focus with height resize

Hi @Diokuz,
We have section with fields and scroll. Last item in this section textarea. once user type more than 1 line of text in this textarea, height of textarea and whole section increased. Scroll also increased but stay at the middle on section, so user should remove focus and scroll bottom.
Maybe plugin have something that will help us scroll to the bottom of the section when we change height of textarea? I didn't find it in settings.
Thanks

Good testcase!
No, there is no 'textarea'-option.
There is a default browser-behaviour:

I suppose you use some js-code to make textarea bigger? If so, you need to set scrollTop value of scroller html-node equal to scrollHeight, or just big enough (9999 for example) after the textarea height has changed.
Baron did not set scroll position at all (that is the philosophy of baron), it just paint some things, like custom scrollbar.

Does the problem disappear after disabling baron? It should stay. I mean, it is not a baron-problem, I suppose.

thanks, found solution - scroll via js once height changed


Add Repository Pattern to GoodToCode.Shared.Ddd namespace

Prototyping has shown a need to share IRepository with concrete microservices and Azure Functions depending on an application service.

Completed in PR 2


is embedding features suitable for gbdt model?

A word embedding, for example, 200 dim, is this a good features for gbdt model?

You can definitely use that, but whether it will be better than using a sparse representation of your text features will depend on the problem.
Also for this kinds of open ended questions I'd suggest using the project's forum, the issue tracker should really be used to report code bugs or other technical issues related to the codebase.


Add Linkin Park - Given Up by Linkin Park

Song Name
Linkin Park - Given Up
Artist Name
Linkin Park
Source
Youtube
Youtube Link
0xyxtzD54rM
Direct File Link
No response
Song ID
814267
Start Offset [ms]
0
Extra
Created from Auto Nong.
Created for level: 110849063
Downloaded: No

accept


support oneof values

It looks like oneof is not supported. The JSON doesn't seem to be marshalled onto the oneof structure correctly. The oneof is ofcourse defined as interface field using the is_ type.
Maybe there's a custom unmarshal function required, or a different work arround (sending the oneof type and value as seperate json?

No you found a missing feature. Well done :)

I am on holiday, but I'll be back next week.

I'm working on a solution.

sorry about the code quality. I would really appreciate a pull request, but
I would also totally understand if you find that the code is to horrible to
edit. good luck
On Nov 13, 2015 5:32 PM, "Geert-Johan Riemer"<EMAIL_ADDRESS>wrote:

I'm working on a solution.
—
Reply to this email directly or view it on GitHub
https://github.com/gogo/letmegrpc/issues/10#issuecomment-156464607.

Not at all. It will require some kind of workarround because json can't be directly marshalled onto protobuf onof fields.

proto3 supports json as one of its serialization formats and proto3 has oneof, so we should check how the jsonpb package serializes oneof fields.
It is some of the hackiest code I have written in a while.  Also one of my first projects with a significant amount of javascript.  Luckily the user doesn't have to write the code so we are also using letmgerpc for about 4 guis at the moment.  oneof would be a great additional feature.

Any status update on this @GeertJohan ? Anything I can help with?

@awalterschulze gogoproto /letmegrpc are both great and I'm really enjoying them.
Hey, I happened to hit this very bug in my project, and came to this bug report.
Is there any progress for this? it would be great if this can be resolved soon. Thanks!

There is no progress on this, but a contribution would be more than welcome.

I don't know, why don't just use jsonpb for Unmarshal it?
I just try replace err := json.Unmarshal([]byte(jsonString), msg)
into err := jsonpb.UnmarshalString(jsonString, msg)
and it just work fine (in my usecase)

I think a lot of this was made just before jsonpb became popular.
Does everything else keep on working?


Add undo functionality for transformer application

This PR adds the ability to use the CODAP undo button to delete tables that have just been created by a transformer application. At present, this is the only undoable functionality.
Design decisions
If the user takes certain actions that are hard to undo/redo (like creating/deleting tables), CODAP clear it's undo/redo stack and start over (the undo/redo buttons will be grayed out). CODAP informs us of this so we can also clear the plugins internal undo/redo stack that we're tracking.
Since all our undo functionality involves deleting tables, the user will only ever be able to undo one transformer application before CODAP clears its undo functionality. This PR implements the following hack to get around that: if CODAP tells us to clear the undo stack but we still have undoable actions left, instead of clearing the undo stack we call notifyUndoableActionPerformed() once for every remaining action in the plugin's undo stack. This tells CODAP to put the plugin back in the undo stack and lets the user perform more "undo"s of transformer application.
However, this could result in undesirable behavior. Suppose we have the following stack of events:
<oldest event>
Transformers: Apply build column transformation to create table "A"
CODAP: rename attribute in "A"
CODAP: move attribute in "A"
CODAP: add case to "A"
CODAP: add case to "A"
Transformers: Apply copy transformation to "A"
<newest event>

With the current functionality, if the user presses undo once, the copy of "A" will be deleted. If they press undo again, "A" will be deleted. This might be shocking, since the user probably expects to undo adding the case to "A".
I think this is a decision we have to make regarding the risk of having more powerful behavior at the of confusing edge cases. I'd be curious to hear your thoughts.
Troubles with redo
It looks like we won't be able to have redo without some hefty CODAP changes. Here's why:
Suppose we tell CODAP an undoable action has been performed when someone hits "apply transformer" to create a table. Then, if the user presses undo in CODAP, CODAP will inform us and we can delete the table.
Ideally, the redo button should now be enabled, and if the user hits "redo" CODAP will inform us and we can re-create the deleted table. The issue is, CODAP treats deleting a table as an undo-clearing action. Since our undo functionality relies on deleting a table, the undo/redo stack is cleared and the user can't hit redo to recreate the table. This means even though our architecture could support undo/redo of transformation application, the user won't be able to use them since CODAP keeps clearing the undo/redo stack.
What else should be undoable
Are there any other plugin-related actions that should be undoable? We already get undo for free in an expression editor from codemirror.

Yep, I definitely see what you mean with edge cases. I think this is something we should demo for sk and see what he thinks--it certainly is powerful to have any level of undo.
As for other features using undo, I'm not sure. I don't think we need to be able to undo creation of a saved transformation (you can just delete it, + with the editing functionality there won't be much need).
Maybe this should apply to the textbox output of Average / Dot Product? Seems like any output we generate should be retractable if possible.

Yep, text boxes were an oversight and I'm adding them in now. One issue however: if the user hits undo after applying a transformer that creates a text box, then we delete the text box. However, CODAP treats deleting that text box as an action, so the user can then hit undo again to get the text box back. I'm not really sure what the desired behavior in this situation is. Maybe we should add a CODAP endpoint to clear the undo stack so that we can avoid this situation?

Also, I'm starting to find more situations that make the extended undo  mechanism described in the original PR description undesirable. Here's an example:

Make the microdata table
Apply the copy transformer to it
Change one of the cases in the original table and watch it change in the copy
Hit undo, expecting the change you made to the original table to be undone. Instead, the copied table gets deleted.

I talked with Jonathan and we decided on only having one level of undo to avoid confusing behavior. Additionally, the plugin doesn't need to handle undo/redo for text boxes since once a CODAP bug is fixed CODAP will handle those automatically.


Add a pure Swift implementation

The usage is slightly different to start out, but the rest should be pretty much a drop in replacement. You can use it like this:
let obfuscatedKey = "5"._8._9.a.d._4.b._0._0.c._3._9

This is great, thanks! Can you also add something to the readme detailing the differences in syntax?

Ok. I updated the README with a Swift Usage section. Let me know if you want me to expand on what I added.

Fantastic, thanks!


FOLLOW UP:  Order-of-Execution for Work Items in Iteration

Contact Dev, let them know you are their contact person for questions
Check in with them, on an a periodic as needed basis throughout the sprint
Assure that this functionality is demoed and meets specifications in the original UX design.
Establish and publish the impact and rules of engagement for the order of execution in relationship to the Iterations filter and how it impacts the list and cards view.

GitHub:
Dev
Display Work Item in a Board View

Scoped to list views only - more IxD and Visual Design needed on board views before follow-up.
For this story, UX to verify:

Drag and drop interactions and visuals are as specified for work item list views
If the user crosses views (iteration to backlog for example), changes made to the order of execution are saved and reflected across these views.

Looking at prod-preview - the drag and drop is reordering items, but does not follow visual design specs and acts a bit wonky for drop spots.  The reordering is not being save when I switch views.  Will log some bugs and then close this story out and track as overall review and bug tracking from here.

Discussed with development team and this is resolved for now - we will be looking at order of execution again post-summit.


Text Sets: Quote

Summary
Update the Quote Text Sets
User-facing changes
Text/Sizing changes
Testing Instructions
Verify that the Quote text set matches figma

Partial for #4903

This one has Crystal Lamberty