[BUG] Can't delete entries from bad files anymore

Describe the bug
Can't delete entries from bad files anymore.
To Reproduce
Steps to reproduce the behavior:

Mark a bad file
Click Delete selected rows
Confirm deletion
Webui refreshes but bad file entry is still

Expected behavior
Removing the Bad entry.
Desktop (please complete the following information):

OS: Latest docker on Debian
checkrr Version: [v3.2.1]

Additional context
Neither checkrr.log or the docker.log throw any error i could provide.
Docker Compose
  checkrr:
    container_name: checkrr
    image: aetaric/checkrr:latest
    volumes:
      - ${DOCKERCONFDIR}/checkrr/checkrr.yaml:/etc/checkrr.yaml
      - ${DOCKERCONFDIR}/checkrr/checkrr.db:/checkrr.db
      - ${DOCKERCONFDIR}/checkrr/checkrr.log:/checkrr.log
      - ${DOCKERDATADIR}:/data
    ports:
      - 8585:8585
    restart: on-failure
    logging: *default-logging

https://img.amoklauf.ch/gOjE3/sUheyuBa96.gif/raw
Here a gif of the bug visually.

As an FYI, this issue was triaged on discord and I already have a rough idea why it's happening. I plan to look into a fix this weekend. It will be patched in 3.2.2 once that's out.


feat(headless): provide more details for request preprocessor

https://coveord.atlassian.net/browse/KIT-1883
Discuss: https://discuss.coveo.com/t/atomic-atomic-search-box-instant-results-how-to-filter-content/8197
What the solution would look like:
<script type="module">
  async function main() {
    await customElements.whenDefined('atomic-search-interface');
    const searchInterface = document.querySelector('atomic-search-interface');
    await searchInterface.initialize({
      accessToken: '...',
      organizationId: '...',
      preprocessRequest: (request, clientOrigin, metadata) => {
        if (metadata?.method === 'search' && metadata?.origin === 'instantResults') {
          // do something...
        }
        return request;
      }
    });

    searchInterface.executeFirstSearch();
  }

  main();
</script>

This could have many use cases for more advanced users.

Added some tests! Re-requesting review only for those 😄


mui-datatables customizing number format

Hi, I am trying to customize number format in mui-datatable by adding '%' to percentages (e.g. 0.025->2.5% OR 2.5->2.5%) and adding commas in numbers (e.g. 1000000 -> 1,000,000).
Is there any built-in options we can use when defining columns? Something like <Format type='percent' precision={2}/>
Thanks for helping!

The way to do this currently would be to use the customBodyRender columns option. It allows you to mutate the data to display however you wish, e.g.:
const columns = [
  {
    name: 'Percents',
    options: {
      customBodyRender: value =>
{value}%

    }
]

What about adding commas in numbers? (e.g. 1000000 -> 1,000,000)

Go ahead! You'll have to write a function that performs the transformation, but I'm sure there are a ton of examples about how to do this online.


changie: 1.12.0 -> 1.13.0

Diff: https://github.com/miniscruff/changie/compare/v1.12.0...v1.13.0
Changelog: https://github.com/miniscruff/changie/blob/v1.13.0/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 250273 run on x86_64-linux 1

1 package built:

changie


attachments for knowledgebase item

Should be relatively easy:

Switch Attachment class to abstract class https://docs.djangoproject.com/en/2.1/ref/models/options/#abstract
Create new FollowUpAttachment with FollowUp as foreign key
Create new KBIAttachment with KBItem as foreign key
Adjust attachment_path accordingly - it should be method of the Attachment class

Any thoughts?

Good suggestion! I like it.

merged in #731


Add ability push to main bump version after release [WIP]

Description
I've changed the script for creating bump PR after the release to push the code directly to main branch.
The problem is that we need to add our service user to the next setting in the Branch protection rules:

Also we need to generate his personal access token and put it in secrets
Notice

[x] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
I have not referenced individuals, products or companies in any commits, directly or indirectly.
I have not added data or restricted code in any commits, directly or indirectly.

Hey @l0uden - thanks for this! Could you remind me what the next steps are and who needs to be involved?
I assume you need to reach out to Leon to allow the service user to bypass these protections. Anything else?

Hey @l0uden - thanks for this! Could you remind me what the next steps are and who needs to be involved?
I assume you need to reach out to Leon to allow the service user to bypass these protections. Anything else?

Hey @huong-li-nguyen

First I'll wait @maxschulz-COL, so he can share personal access token for the service user, because it connected to his phone. If this user will have ability to merge to main without extra permissions so that's it.
If it doesn't I'll ask Leon about adding this user to the setting in the description (I can't do it manually)
If second step is not possible for any reason, I'll ask Leon whether we can use my or anyone else account for this purpose.

did you test this?

Yes, I've tested it in the vizro-qa repo. With the same settings and user.

should we do this after every PR, not just the release?

I don't think that every merge to main should increase dev version. For example this PR do nothing to vizro library to increase even the dev version.
Looking for changes in the specific folders also will not work, because we need to create changelog for every PR (but maybe there's a way to exclude changelog folder from scan somehow).

This looks great, thank you for figuring it all out! Just a minor tweak to the commit message would be nice.
Re @maxschulz-COL's idea of bumping on every push to main: we should not do this, since the same functionality already exists: each "build" of main is labelled by a git commit hash. It's already possible to pip install a specific commit directly. So effectively all we'd be doing is introducing some mapping from .devN to git commit, but this would also introduce lots of noise in the commit history, and we should aim to keep main commit history reasonably clean.

I agree, but I was not referring to the ability to install a specific git commit, but rather to the ability to allow us/user to know precisely what version they actually have (if they install a different intermediate build).
I fully agree that this keep main unclean, and there is better solutions to it https://github.com/ofek/hatch-vcs. In fact I have tried the latter one back when I set this all up, but there was a known issue (that I think I documented in one of the PRs)
The above suggestion is essentially trying to emulate this.

I agree, but I was not referring to the ability to install a specific git commit, but rather to the ability to allow us/user to know precisely what version they actually have (if they install a different intermediate build).
I fully agree that this keep main unclean, and there is better solutions to it https://github.com/ofek/hatch-vcs. In fact I have tried the latter one back when I set this all up, but there was a known issue (that I think I documented in one of the PRs)
The above suggestion is essentially trying to emulate this.

Ah ok, that makes more sense. Overall I think this is too low value compared to the noise introduced in main, since nthe number of users who install intermediate builds is very low (we should continue with our frequent releases to ensure this remains the case, and also feel free to bump the dev version manually whenever we like if we want to supply users with a particular unreleased version).


Update driverentry-for-kmdf-drivers.md

added a missing declaration for SERIAL_FIRMWARE_DATA

Thanks @spellvaishnav!


403 error following tutorial

[Enter feedback here]
When following this tutorial, I always get this 403 error, despite entering the correct connection string:

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 4b610110-f417-3565-bbd6-35e90a567a2d
Version Independent ID: 53b5d6ae-54ef-c45d-19f1-cd2ebd7e1bd6
Content: Tutorial - Create a serverless notification app using Azure Web PubSub service and Azure Functions
Content Source: articles/azure-web-pubsub/tutorial-serverless-notification.md
Service: azure-web-pubsub
GitHub Login: @JialinXin
Microsoft Alias: jixin

@rubenberna
Thanks for your feedback! We will investigate and update as appropriate.

@Naveenommi-MSFT , I found the issue. The Web Pub Sub is in a subscription where the public network access is disabled. If I try the same steps in a Web PubSub from a different subscription with less restrictions it works.
Thanks

hi, i am facing a similar issue and mine is not because of public network access disabled. i am trying to use ClientSecretCredential for connecting to my webpubsub for socketio resource and i am seeing the same behavior as mentioned above. 403 while connecting. then i tried switching from ClientSecretCrendential to a connectionstring approach and it started WORKING.
i looked at the jwts returned by both approaches from the negotiate call and i see a difference.
when i use connectionString, i am seeing a new claim in my token named userId which i am not seeing when i was using ClientSecretCredential. i would like to use ClientSecretCredential . so can you help me understand the different behaviors in  both approaches?
Thanks
Azeet


font weights are not rendered properly on iOS 13.3

Hi!  when running our app in iPhoneX simulator - iOS version 13.5 everything works good.
In iPhone X  simulator with version iOS 13.3, all text with fontWeight 300 (and other weights which are not "normal") do not render properly - see photos attached. (you can see that letter spacing is not even) The fonts we are using is "Helvetica neue".
this is how we define the fonts in the pubspec.yml file:
- family: Halvetica
  fonts:
    - asset: fonts/Helvetica45Light.ttf
    - asset: fonts/Helvetica25UltraLight.ttf
      weight: 100
    - asset: fonts/Helvetica35Thin.ttf
      weight: 300
    - asset: fonts/Helvetica55Roman.ttf
      weight: 500
    - asset: fonts/Helvetica65Medium.ttf
      weight: 600
    - asset: fonts/Helvetica85Heavy.ttf
      weight: 700

This is how the font family is set:
var baseTextStyle = TextStyle(fontFamily: "Halvetica", color: AppColors.black);
I have a config where I create a custom theme:
class AppTheme {
 static ThemeData of(context) {
   var theme = Theme.of(context);
   return theme.copyWith(...); // Here I override the default theme
 }
}

output from flutter doctor:
[✓] Flutter (Channel stable, v1.17.3, on Mac OS X 10.15.4 19E266, locale en-IL)
    • Flutter version 1.17.3 at /Users/XXX/Desktop/Dev/tools/flutter
    • Framework revision b041144f83 (3 weeks ago), 2020-06-04 09:26:11 -0700
    • Engine revision ee76268252
    • Dart version 2.8.4

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/XXX/Library/Android/sdk
    • Platform android-29, build-tools 29.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.8.4

[✓] Android Studio (version 3.5)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 43.0.1
    • Dart plugin version 191.8593
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[✓] IntelliJ IDEA Community Edition (version 2019.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 43.0.3
    • Dart plugin version 193.6015.53

[✓] VS Code (version 1.45.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.12.0

[✓] Connected device (3 available)
    • sdk gphone x86 arm • emulator-5554                        • android-x86 • Android 10 (API 29) (emulator)
    • iPhone 8           • 1EAA0FC8-F445-4D6C-9030-E6E9BB21924B • ios         • com.apple.CoreSimulator.SimRuntime.iOS-13-3 (simulator)
    • iPhone x           • 8E1A08DD-905F-4BD2-9BAE-01702A4007C4 • ios         • com.apple.CoreSimulator.SimRuntime.iOS-13-5 (simulator)

• No issues found!

Hi @tsahnar
I'm not sure if the issue is referred to ios ignoring fontWeight or these fonts specifically;
does this code sample represent the issue you are describing?
Thank you

@iapicca thanks for you response
The issue you referenced in your comment is not really like the issue we encounter.
I tried the code sample you sent- with the Google font it worked fine. When I tried the Helvetica font it does not render properly on both w100 and w300. only in "normal"... see attached images.

Could this be just the font we are using is not working properly?

Hi @tsahnar
Running on iOS 13.3 simulator, using Helvita has no issues

complete code sample
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Material App',
      theme: ThemeData(fontFamily: 'Helvetica'),
      home: Home(),
    );
  }
}

class Home extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('Material App Bar'),
      ),
      body: Center(
        child: Container(
          child: Text(
            'Hello World',
            style: TextStyle(fontWeight: FontWeight.w100, fontSize: 49),
          ),
        ),
      ),
      floatingActionButton: FloatingActionButton(
        child: Icon(Icons.add),
        onPressed: () {},
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel master, 1.24.0-2.0.pre.111, on Mac OS X 10.15.7 19H2
    darwin-x64, locale en-GB)
    • Flutter version 1.24.0-2.0.pre.111 at
      /Users/tahatesser/Code/flutter_master
    • Framework revision fe189baf34 (11 hours ago), 2020-10-21 22:25:53 -0400
    • Engine revision f459a86610
    • Dart version 2.11.0 (build 2.11.0-242.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/tahatesser/Code/sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_HOME = /Users/tahatesser/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.1, Build version 12A7403
    • CocoaPods version 1.10.0.rc.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.50.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.15.1

[✓] Connected device (5 available)
    • Taha’s iPhone (mobile) • 00008020-001059882212002E            • ios
      • iOS 14.1
    • iPhone 12 (mobile)     • 722C6A4C-3FCA-4FC6-9D30-9702A0E784B8 • ios
      • com.apple.CoreSimulator.SimRuntime.iOS-14-1 (simulator)
    • macOS (desktop)        • macos                                • darwin-x64
      • Mac OS X 10.15.7 19H2 darwin-x64
    • Web Server (web)       • web-server                           •
      web-javascript • Flutter Tools
    • Chrome (web)           • chrome                               •
      web-javascript • Google Chrome 86.0.4240.80

• No issues found!

I cannot reproduce this issue on the latest master channel.
Can you please upgrade to the latest  dev and try again
flutter channel master
flutter upgrade --force
flutter doctor -v

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


Fixed Peek Definition typo

Peek To Definition  -> Peek Definition
Fixes #1511

@ClydeDz : Thanks for your contribution! The author, @gewarren, has been notified to review your proposed change.


Asura no chapters found

Source information
Asura Scans
Source language
English
Steps to reproduce
Just open any manga
Expected behavior
Show chapters
Actual behavior
doesn't
Mihon/Tachiyomi version
<IP_ADDRESS>
Android version
Android 14
Other details
It had a 502 shortly before.
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version 0.15.3.
[X] I have updated all installed extensions.
[X] I have tried the troubleshooting guide.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

I literally did and the chaps are there

Yes but after the site fix it broke the plugin

I just cleared cookies+webview and restarted and problem remains

I just cleared cookies+webview and restarted and problem remains

Yeah, I update the extension and do those and nothing work :(

Is the extension fixed as my webview is working not the extension

Is the extension fixed as my webview is working not the extension

Did you update your extension?

My version is 1.4.58

My asura is working now, thx 😊

My version is 1.4.58

That's an old old version, come to Keiyoushi Discord repo-support channel for help with this

I have also a version of 1.4.37

1.4.37

It was working fine couple a minute ago now it showing obsolete extension and no chapter founds

It was working fine couple a minute ago now it showing obsolete extension and no chapter founds

As mentioned @Divyam-Naudiyal , come to the Keiyoushi Discord repo-support channel for help. Makes it easier to communicate

Can share the link for discord


increase timeouts, reduce work overhead

This test most probably was only marked timecritical for valgrind.
Relaxed the timings a bit, un-greylist.

http://jenkins01.arangodb.biz:8080/view/Windows/job/arangodb-ANY-windows-matrix/780/ green in these testruns.

@dothebart : Please also remove the "timecritical" name part from the test file.

why? it still is. and I don't really see a way to solve this. We may split this file into a non-timecritical and a timecritical part, but thats about it.

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/7704/

testrun green.

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/7891/

test green except for unrelated errors.


Group chats does not work anymore

When a member is added he cant see it. Only occurs when added to group AFTER creation.


Use Arduino CLI for CI

This PR:

Replaces PlatformIO with the Arduino IDE CLI
No longer lints the code (not supported by Arduino IDE CLI)
Updates all examples to use TTN_FP_EU868 for freqPlan
Verify all examples for the Leonardo board
Verify all tests for the Leonard board

Closes #150

@johanstokking this one is good to go. Please verify the CI results, squash and merge. I'll then add support for the sparkfun boards to test the Node branch. Once that is done we can merge that branch as well.


HAL_ADC_Start_DMA gets too slow if temp. channel is used

Describe the set-up

Custom board, using STM32H503CBTx
arm-none-eabi-gcc (Arch Repository) 13.2.0

Describe the bug (skip if none)
HAL_ADC_Start_DMA get's really slow when internal temp sensor is used on channel that is not strictly related to temperature.
How to reproduce the bug (skip if none)
Setup round-robin setup for ADC channels, which at 10kHz does one of the following:

Chann0 is read by DMA for multiple values
Internal temp. is read once

In step 1), usage of HAL_ADC_Start_DMA function is really slow.
The problem disappears if internal temp. channel is not used at all.
Additional context
Based on reading of the source code, the problematic place is this:
https://github.com/STMicroelectronics/stm32h5xx_hal_driver/blob/main/Src/stm32h5xx_hal_adc.c#L3519
ADC_Enable will execute the "sensor stabilization delay", which takes a considerable amount of time. (Relative to it being run in 10kHz loop) This seems as waste of time given that the channel being started is NOT the internal temperature channel

Hello @koniarik,
The ADC has been configured to perform two tasks in a 10KHz loop. Firstly, it reads channel 0 using DMA for multiple reads, and secondly, it reads the temperature sensor. This means that the same ADC is being utilized for multiple tasks and is reconfigured each time.
An issue arises when the temperature sensor channel remains active, causing a delay in the stabilization process of the temperature sensor. This delay further causes the ADC to wait when it needs to read channel 0.
To optimize the process, my recommendation would be to disable the temperature sensor when it is not in use. This will prevent any unnecessary delays and ensure that time is not wasted.
Thank you again for your contribution.
With regards,

How? And frankly, is it trully the best idea?
My thouhts:

The thing is that the this behavior is not exactly clear from the API nor the documentation in adc.c file  (and something I would prefer to be warned about)
Suddenly it's not clear to me what is the intended usage of the peripheral... what is the proper way to use it? or what is the proper way to disable just the temperature sensor?
Can I do the disable any other way than disabling entire peripheral and enabling again?

I tried to apply the fix but it does not work
I don't have time to investigate this now, as based on my reading of the code it should've worked, I will answer here once I have time for deeper investigation :)

Hello,
Can you please find the time to test the proposed solution?
I appreciate your honesty and look forward to hearing back from you once you have had the time to conduct a more thorough investigation. In the meantime, please let me know if there is anything I can do to assist you.
Regards,
Rania

Sorry for the way!
Turns out that fix suggested by @ARIOSTM works, there was failure on my side in evaluation.
The proposed fix indeed gets rid of the waiting when different channel is used. It's just that even the wait for temperature channel only switch only, the system is too unresponsive and triggers our internal warnings. But I don't blame that on the HAL, as that is just a property of the temp. sensor.
Thanks!

Hello @koniarik,
Thank you for your feedback, If the solution has resolved your problem, so allow me to close the issue.
We're delighted to hear from you once more.
Regards,
Rania


Fix auto-close when tag mistmatched

When trying to auto-close a tag in the middle of a file where there is a tag mismatch, the context was invalid and the auto-completion failed.
This PR adds the mismatched tag case to the supported recovery exceptions.

Actually, I think is better to remove completely the SUPPORTED_RECOVERY_EXCEPTIONS and the context.is_invalid field, since we really want to try to recover the context when any type of exception is raised. And also, even if the XML is invalid or broken, we need to safely parse as much information as we can, so all contexts should be considered "valid".


⚠ Bofrost.es has degraded performance

In ce872e4, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1451 ms

Resolved: Bofrost.es performance has improved in ae5c277 after 9 minutes.


feat(Webhooks): Improve interactive and status types

The recent changes to the interactive reply message types made it harder to work with IMO.
Also the WebhookStatus was missing the errors property.

Since I'm only using the types of this lib I missed that adding the missing errors property breaks the unit tests because the mock/example webhook message for the unit tests then complains about the missing property.
I created another PR to fix this:
https://github.com/MarcosNicolau/whatsapp-business-sdk/pull/48


Default min filter

Why is MIP Linear Linear a texture's default min filter?

I get much nicer (crispier) results using Linear, which I always switch to.

Mipmaps are usual and should for minification provide smother results you can read more about them here https://graphics.ethz.ch/teaching/former/vc_master_06/Downloads/Mipmaps_1.pdf.

Thanks! Interesting stuff.


iOS connects to a call, but emits and receives no audio

Please include following information for better support
I have 'Voice over IP' enabled and my iOS app connects to a voice call, however I cannot hear anything or emit any sounds to the other side. I have microphone usage 'allowed'. The apple 'call view' does not appear, should it? The call is registered under Twilio as 'In Progress'. It just seems that the audio is disabled.
What version of React Native are you running?
0.47.1
What version of react-native-twilio-programmable-voice are you running?
2.8.0
What device are you using? (e.g iOS9 simulator, Android 6 device)?
iPhone 6
Is your app running in foreground, background or not running?
foreground
Is there any relevant message in the log?
If using iOS, which pod version are you using?
1.3.1
Step to reproduce
Connect to a Twilio address.
Advanced:
Have you tried adding break point in native handlers and see the logs printed?
can share a project with issue?
Did you try to reinstall the pods completely?
The more context you provide around this issue the faster the community can help you.

Hey @Catpants did you get this issue solved. If so, what steps did you follow to solve this?


Main Calendar: Show sunrise/sunset in calendar

It could be useful to show sunrise/sunset in a calendar, e.g. this is how it's currently done in my Apple Calendar:

We need to research couple of topics before doing this:

[ ] how location specific is this data (is it per entire California or per city, what is the granularity, would times be different for SF and Mountain View?)
[ ] is there any public database for this data we can use?
[ ] can it be calcualted?
[ ] does it change year to year or it's always the same and just depends on coordinates

Umbrella #22, #23

It can be calculated, yes.
http://www.stevemorse.org/jcal/sunrise.html
https://gist.github.com/Tafkas/4742250

And also http://www.esrl.noaa.gov/gmd/grad/solcalc/, thanks @Me4ta then we need to write a tool that calculates it.


How to use the signature generator for dydx exchange ?

I installed the signature generator for dydx exchange, but I don't how to use it.

just see readme

package main
import "fmt"
func main() {
const MOCK_PRIVATE_KEY = "58c7d5a90b1776bde86ebac077e053ed85b0f7164f53b080304a531947f46e3"
param := OrderSignParam{
	NetworkId:  NETWORK_ID_ROPSTEN,
	Market:     "ETH-USD",
	Side:       "BUY",
	PositionId: 12345,
	HumanSize:  "145.0005",
	HumanPrice: "350.00067",
	LimitFee:   "0.125",
	ClientId:   "This is an ID that the client came up with to describe this order",
	Expiration: "2020-09-17T04:15:55.028Z",
}
sign, err := OrderSign(MOCK_PRIVATE_KEY, param)
// 00cecbe513ecdbf782cd02b2a5efb03e58d5f63d15f2b840e9bc0029af04e8dd0090b822b16f50b2120e4ea9852b340f7936ff6069d02acca02f2ed03029ace5
fmt.Println("sign,err", sign, err)

}
OderSign is unknown

I have an issue with importing the signature generator library. Can you help?

you need :
import "github.com/yanue/starkex"


dependecy tree incorrect when related to relocate artifact

This issue is related to the relocate artifacts.
The content of build.gradle is below:
plugins {
    id 'java-library'
}

repositories {
    mavenCentral()
}

dependencies {
    compile group: 'org.hibernate', name: 'hibernate-validator', version: '6.0.14.Final'
}

After run gradle dependencies --configuration compileClasspath
output:
compileClasspath - Compile classpath for source set 'main'.
\--- org.hibernate:hibernate-validator:6.0.14.Final
     \--- org.hibernate.validator:hibernate-validator:6.0.14.Final
          +--- javax.validation:validation-api:2.0.1.Final
          +--- org.jboss.logging:jboss-logging:3.3.2.Final
          \--- com.fasterxml:classmate:1.3.4

That is confused it's seem like that org.hibernate:hibernate-validator:6.0.14.Final has dependency org.hibernate.validator:hibernate-validator:6.0.14.Final
Expected Behavior

compileClasspath - Compile classpath for source set 'main'.
\--- org.hibernate.validator:hibernate-validator:6.0.14.Final
    +--- javax.validation:validation-api:2.0.1.Final
    +--- org.jboss.logging:jboss-logging:3.3.2.Final
    \--- com.fasterxml:classmate:1.3.4

Context

I am developing a gradle-plugin like gradle dependencies and reference its implement.Is there any way to kown this is a relocate artifact so I can ignore it or do something else.
Your Environment

jdk8
gradle 6.2.2
windows 10

+1

This is a consequence of the current implementation for Maven relocation in Gradle. The relocated dependency is added as a dependency of the original one.
Given the priorities of the team, it is quite unlikely this will change.


10undefinedundefined

How interesting! I’ll have a look to see what’s going on here.

Fixed in #54


Are there any plans to release config files for HTC++?

Thanks for open-sourcing the code! I'd want to replicate the results in table 2 of the paper, with Swin-B (HTC++) reaching 56.4 bbox AP. Are there any plans to release the config files for this experiment? Thanks!!

same hope!

Yep, I am looking forward for it too!

Hi, @impiga
Could you please release the cpkt and config for HTC-Swin?


feat(examples): Remove Trusted Sync

Description
The trusted-sync binary is an extremely lightweight implementation of a consensus node that offloads payload validation to a "trusted" rpc. Effectively, it's used to verify that the derivation pipeline (in the kona-derive crate) is producing valid payload attributes over the abstracted RPC providers - L1 provider, beacon client, L2 provider (for validating payload attributes).
An effort is in the works to create a fully-featured L2 consensus client in https://github.com/paradigmxyz/op-rs. This will also provide backwards-compatible support with trusted-sync to run in "trusted" validation mode.
The output of this ticket is to remove the trusted sync example from kona, as well as any accompanying jobs, tests, or other references. Notably, the trusted sync docker image github action workflow will need to be sunset in favor of a docker image with https://github.com/paradigmxyz/op-rs. (Note here to @refcell - replace trusted-sync in kubernetes - maybe even remove and just run reth + hera + op-reth?).

Closed by https://github.com/anton-rs/kona/pull/621


Allow --only-label cli

Description

I want to start multiple independant portainer instances on one entrypoint
Each portainer instance have to manage only one part of the swarm cluster, based on service and container labels
I want the opposite of the --hide-label, like a --only-label
This allow multiple teams to manage theirs services/containers independently
Thanx for reading

Hi, we're already tracking this feature in this issue: https://github.com/portainer/portainer/issues/359
Feel free to comment here.


Mention Minikube in the Kubectl configuration doc

The Minikube installation (https://kubernetes.io/docs/getting-started-guides/minikube/) has a per-requisite of Installing and Setting up kubectl. So it's natural for users to follow all of the 'prereqs' steps as mentioned in the instructions, however the verification of Kubectl (i.e. $ kubectl cluster-info) as explained under 'Configuring kubectl/Making sure you're ready' won't produce an expected output unless Minikube was installed in user's system. The new users may not have any idea of why it's not working.
This PR changes add a reference of Minikube along with kube-up.sh. This will convey message to first time users of the Minikube that they should make sure Minikube is installed before running this step (i.e. $ kubectl cluster-info)
fixes #2863

This change is

@mikedanese Hi Mike, I was not up-to-date with master :( and the content of the file I made changes was moved to a new file. Fixing this with git, as you can notice, created multiple commits. Please let me know if that doesn't sound good? In that case, I guess the best alternative for me is to close the PR request here and address changes with new PR. Thanks!

This needs to be one commit.

@mikedanese thanks Mike, that will be great!

@mikedanese made changes per your suggestion but added new commits :-). A k8s newbie question - what's a recommended way to update changes for reviewer(s) comments? Per some official git blog recommended way is to create new commit (i.e. leave the original commit as such and create new one every time you make changes), some folks prefer use of --amend and some prefer reset? I guess all are valid and it can be a personal preference but if there is a best practice, would love to know it.  Thanks!!


React hook example

Thanks for this lib!
Just for the record, we use this small react hook, maybe useful for others as well.
(We use TypeScript, so we had to cast the tailwind config and this lib as any. If you have time please consider adding types support to the roadmap.)
import { useCallback, useEffect, useState } from "react";

const breakpointHelper: any = require("breakpoint-helper").default;
const tailwindConfig: any = require("../../../tailwind.config.js");

const instance = breakpointHelper(tailwindConfig.theme.screens);

const { listenAll } = instance;

export const useBreakpoint = () => {
  const [match, setMatch] = useState<string>();

  const callback = useCallback((bps: string[]) => {
    setMatch(bps[0]);
  }, []);

  useEffect(() => {
    const listener = listenAll(callback, { immediate: true });

    return () => listener.off();
  }, [callback]);

  return match;
};

Thanks for the suggestions!
We don't use SSR, it's a Laravel Mix project, so only client-side React.
Also in the Tailwind docs:

Note that this will transitively pull in a lot of our build-time dependencies, resulting in bigger bundle client-side size. To avoid this, we recommend using a tool like babel-plugin-preval to generate a static version of your configuration at build-time

I tried to setup babel-plugin-preval but I had no success in the Laravel Mix & TypeScript & React world. Then I realized we only use our custom colors and breakpoints defined in our config file, so it's enough to import that, which results smaller bundle size.

Hi @merobal
Long time... I have rewritten the lib in Typescript. If you have a chance to check it out it would be great to know if it works well for you, it is my first time a publishing something on npm using Typescript.
I also added an simple example on usage with react. Will close this issue now. I you have any problems feel free to open a new issue.

I tested it now, and got this error message:
import breakpointHelper from "breakpoint-helper"; =>
File /node_modules/breakpoint-helper/dist/breakpoint-helper.d.ts' is not a module.ts(2306)

Hey @merobal, thank you for your feedback, I released a fix. Please let me know if it works for you.

It works now!


transfer dsl

Playing with more of a dsl style for transfers to give a simple idea of what's possible, but maybe overkill for the kata base code. What do you think?
(Could also do something like transfer(amountOf(1)).from(sender).to(receiver) but it requires an extra inner class to do it nicely, which seems like too much boilerplate for little extra readability.)

We chatted about this right? I love the DSL but for the audience it's probably overkill. Closing the PR

Agreed 👍


[1020] prevent computacenter support users seeing users who have not seen the privacy notice

Context
Trello card #1020 - there's a loophole by which the personally identifying contact details of users could be shown to third parties before they have seen the privacy notice, if those third parties are the Computacenter users who have been given access to the support UI.
Changes proposed in this pull request

add .safe_to_show_to(user) scope to User
add privacy_notice_required:  argument to existing scopes on ResponsibleBody which reference the users table
update all relevant support controller methods to use those scopes and arguments as appropriate
update relevant support feature specs to test the new restrictions
as the support/users_controller uses @user to refer to the user who is the target of an action (show / edit / etc), and we also need to refer to the currently signed-in user (which is set as @user in the application_controller.identify_user! method), make the identify_user! method also set @current_user and use that as an argument to the scopes.

NOTE that this last conflict needs dealing with properly, as it can lead to a confusing user experience if you visit the support/user_controller - so a separate PR will be raised later to remove the conflict fully.
Guidance to review

Fair enough, let's go with the built solution then.

Fair enough, let's go with the built solution then.

So... am I ok to merge this as-is?

:shipit:


Replace FindBugs with SpotBugs maven plugin

Findbugs is deprecated. This is an initial commit to attempt to switch to
spotbugs
Fixes #10406

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6712/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6713/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6716/
Test FAILed.

Tests in error:
alluxio.client.cli.fs.JobServiceFaultToleranceShellTest.distributedMv(alluxio.client.cli.fs.JobServiceFaultToleranceShellTest)
  Run 1: JobServiceFaultToleranceShellTest.before:52 » IO java.lang.RuntimeException: a...
  Run 2: JobServiceFaultToleranceShellTest.before:52 » IO java.lang.RuntimeException: a...

Flaked tests:
alluxio.client.cli.fs.command.PersistCommandTest.persistOnRenameDirectory(alluxio.client.cli.fs.command.PersistCommandTest)
  Run 1: PersistCommandTest.persistOnRenameDirectory:105->AbstractFileSystemShellTest.checkFilePersisted:306
  Run 2: PASS

alluxio.server.ft.journal.MultiMasterJournalTest.testTtl(alluxio.server.ft.journal.MultiMasterJournalTest)
  Run 1: MultiMasterJournalTest.before:53 » IO java.lang.RuntimeException: alluxio.exce...
  Run 2: PASS

jenkins, test this please

I think before merging this PR we should re-evaluate the exclusions/inclusions within the build/findbugs/findbugs-exclude.xml

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6723/
Test FAILed.

@ZacBlanco could we remove all the bug code and see what the output looks like? so we can decide which bug code to keep?

jenkins, test this pleaseeeee

jenkins, test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6733/
Test PASSed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6809/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6813/
Test FAILed.

@gpang @yuzhu FYI
So I found while running this PR that we have a ton of locations that findbugs complains about with the error code REC_CATCH_EXCEPTION
The short explanation is that there's are many places throughout our codebase where we do something like
try {
  // Code that might throw IOException, NPE, NumberFormatException...
} catch (Exception e) { // This exception literally catches everything
 // Generic exception handler
}

Spotbugs' explanation of this is essentially there is rarely a time when it is desirable to catch/handle all exceptions, regardless of class. Most often you'll at least want to handle RuntimeException separately from Exception because they are different classes of errors.
Across the project we do a pretty poor job (according to Spotbugs) of exception handling as there are probably 30+ locations where there is simply catch (Exception e). I tried to fix a lot of them, but I'm worried that I don't have enough context on how this could affect the reliability of the program, such as introducing crashes due to not catching the proper exception class. Nor do I properly know how the different classes of exceptions should be handled in all the different cases I encountered.
What I'm going to do is revert any changes related to REC_CATCH_EXCEPTION and file a ticket that can be addressed in a separate PR to deal with our poor exception handling.

@ZacBlanco That sounds like a good plan. Let's get the simpler fixes/changes in first, and address the bigger issues separately. Thanks!

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6836/
Test FAILed.

Created https://github.com/Alluxio/alluxio/issues/10459 to track the debt for exception handling.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6844/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6846/
Test PASSed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6847/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6848/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6868/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6871/
Test PASSed.

alluxio-bot, merge this please


❓ Reusable Tooltip with Arrow: How to pass arrow ref?

Hi Guys,
Thanks for floating-ui!
I am trying to understand how to pass arrow ref from TooltipContent to useTooltip hook into middleware: [arrow({ element: arrowRef })].
https://codesandbox.io/s/xenodochial-grass-js3bo9?file=/src/App.tsx
I put arrow DIV element in TooltipContent, but not sure how to pass ref.
export const TooltipContent = forwardRef<HTMLDivElement, React.HTMLProps<HTMLDivElement>>((props, propRef) => {
    const state = useTooltipState();

    const ref = useMemo(() => mergeRefs([state.floating, propRef]), [state.floating, propRef]);

    return (
        <FloatingPortal>
            {state.open && (

                    {props.children}

    // <---------- My arrow

            )}
        </FloatingPortal>
    );
});

Could you please help me with that?
Or may be you already have such example based on reusable tooltip?

@atomiks thank you so much for quick and clear response!
I am completely forget to return arrowRef from hook.
return {
    // ...
    arrowRef,  <------- lost this one
}


Detach behavior by class name

Detaching named behavior is easy and covered in docs here.
But if no name given, we have to loop through behaviors() configurational array and compare classes until they match. It's not a big problem, but I think it will be better if framework have support of detaching by class name.

If you have plan to detach a behavior, you have to named it :D

What if it's inside some extension? And detaches there? Force user to name it?

Such feature does not make sense. Behaviors are attached or detached as an objects, not a classes.
Same component may have several behaviors of the same class attached.


Replace vertex node with custom widget / image

Is there any plan to do?
I was trying to modify library by myself, but the problem that it's so sticked architecturally to the vertex. So I need to change all dependencies across almost all files

@muknta
I also need pictures, but it may take some time before I can start construction.

Maybe you can refer to this: https://github.com/graph-cn/flutter_graph_view/blob/main/example/lib/demos/custom_shape_demo/execution_plan/plan_node_shape.dart
class CustomNodeShape extends VertexShape {
   // ... You can use paint in the render method to do anything
}

    Options()
        ..vertexShape = CustomNodeShape()

https://graph-cn.github.io/flutter_graph_view/
Displaying cases under the ExecutePlan tab

@CorvusYe thanks for you suggestions! I will try to make this way


file disappear when naming a file '/'

Description
file disappear when naming a file '/'
Versions and device

Android 9
Camera Roll v1.0.6
HUAWEI MATE 10

Steps to Reproduce

Click to open a picture
Click "Rename" and rename with '/'
Picture disappear

Actual behaviour
Picture disappear
Expected behaviour
Show rename fails, and forbid this behavior

also, there is no warming about duplicated file named, so if new filename is the same as old filename, the old file will be overwritten.


⚠ TiendaEnLinea has degraded performance

In 2b6a07e, TiendaEnLinea (https://www.fahorro.com/) experienced degraded performance:

HTTP code: 200
Response time: 7249 ms

Resolved: TiendaEnLinea performance has improved in 0872f32.


[bug] ?/ causes error

Looks like a duplicate of #727

Thanks for raising! If you could :+1: the linked issue (#727) that would help us prioritise stuff a bit more.


get_split_value_histogram XGBoost equivalent in LightGBM

I want histogram/values of all the splits happening in a particular feature. Just like get_split_value_histogram in XGBoost. Is there any way to get it currently?
I am aware of plot_tree and create_tree_digraph methods. But those are for visualizations

I think this could be achieved by tree models.
You can use dump_model: https://lightgbm.readthedocs.io/en/latest/Python-API.html#lightgbm.Booster.dump_model, to get the model content. And then get your statistics from the model.
@StrikerRUS do you think this function is needed? maybe we can implement one in python-package.

@guolinke I haven't here about such function. It seems to be a useful feature, I'll take a look.


Compiling JAX from inside a Dockerfile fails

I was able to compile JAX interactively on a terminal. Now I am trying to install it from within the Dockerfile using the following commands.
RUN git clone https://github.com/google/jax.git /jax
WORKDIR "/jax"
RUN python build/build.py --enable_cuda
RUN pip install -e build
RUN pip install -e .
However, I run into the following error. It appears to be due to some interaction between docker and python subprocess.
######## STDOUT ########
Target //build:install_xla_in_source_tree up-to-date:
bazel-bin/build/install_xla_in_source_tree
INFO: Elapsed time: 518.641s, Critical Path: 151.85s
INFO: 5040 processes: 5040 local.
INFO: Build completed successfully, 6979 total actions
INFO: Running command line: bazel-bin/build/install_xla_in_source_tree /jax/build
INFO: Build completed successfully, 6979 total actions
WARNING: Waiting for server process to terminate (waited 5 seconds, waiting at most 60)
WARNING: Waiting for server process to terminate (waited 10 seconds, waiting at most 60)
WARNING: Waiting for server process to terminate (waited 30 seconds, waiting at most 60)
INFO: Waited 60 seconds for server process (pid=24) to terminate.
WARNING: Waiting for server process to terminate (waited 5 seconds, waiting at most 10)
WARNING: Waiting for server process to terminate (waited 10 seconds, waiting at most 10)
INFO: Waited 10 seconds for server process (pid=24) to terminate.
FATAL: Attempted to kill stale server process (pid=24) using SIGKILL, but it did not die in a timely fashion.
bazel-0.24.1-linux-x86_64 [########################################] 100%
Bazel binary path: ./bazel-0.24.1-linux-x86_64
Python binary path: /opt/conda/bin/python
MKL-DNN enabled: yes
-march=native: no
CUDA enabled: yes
Building XLA and installing it in the jaxlib source tree...
Traceback (most recent call last):
File "build/build.py", line 342, in
main()
File "build/build.py", line 338, in main
shell([bazel_path, "shutdown"])
File "build/build.py", line 50, in shell
output = subprocess.check_output(cmd)
File "/opt/conda/lib/python3.6/subprocess.py", line 356, in check_output
**kwargs).stdout
File "/opt/conda/lib/python3.6/subprocess.py", line 438, in run
output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['./bazel-0.24.1-linux-x86_64', 'shutdown']' returned non-zero exit status 36.
The command '/bin/sh -c python build/build.py --enable_cuda' returned a non-zero code: 1
###################################

I wonder if it would be helpful to look at the Dockerfile we use for building all the wheels on Cloud machines. At the very least, that one works!

Were you able to get your Docker file to work?
Since our Docker builds are currently working, I think it's possible that this bug you're seeing is not in JAX's scope. What do you think?

I used a work around for now i.e. compiling interactively and then doing a docker commit. I did not try modifying the Dockerfile itself. I looked at your build scripts and may be the trick is to use "ENTRYPOINT" and point it to a shell script where the compilation actually happens. For now please go ahead and close the bug as I don't believe its in JAX's scope.

Hi, I ran into the same issue and noticed that the reason is because docker hides the PID from the host by default, Bazel is unable to terminate the session, as can be seen from the line
FATAL: Attempted to kill stale server process (pid=24) using SIGKILL ...

Therefore, in order to build JAX inside docker. We need to expose the PID with the option --pid=host.

@ArmageddonKnight this really help me to deal with the problem:
https://github.com/google/dopamine/issues/158#issue-761104113
thx a lot!!!


Existing Cache files leads to permanent DataLoader hang

🐛 Bug
I'm currently using litdata completely locally where I first convert the dataset using 'optimize' and use StreamingDataset to stream the records from a local directory to train my model. I want to train multiple models (using the same dataset) in parallel but it seems that the cache files created from the previous runs ends up blocking the StreamingDataset of the future runs (probably due to locking?) It took me quite a while to figure out that the freeze was due to the cache files.
My workaround for now is to create a new caching directory for each run following the documentation using the 'Dir' class from resolver.py  which was a bit confusing at first because 'Dir' takes arguments 'url' and 'path' which makes it seem like it only works when you have data in the cloud (url.) It would have made more sense it the arguments were like 'path' (either url or local directory) and 'cache_dir' (the directory to store cache)
The question I had was: why does it have to cache data when all the data is already available locally?
It would be great if StreamingDataset directly took an argument like cache_dir.
Thanks.

Hey @lilavocado. This library is made to work for cloud data first. I haven't faced this issue before.
Could you provide a simple reproducible script ?

Hi, I have experienced a similar problem when using a StreamingDataLoader on two concurrent studios with multiple workers on the lightning platform. After a while, the multiprocessed dataloader would just stop iterating batches without throwing an error, and GPU utilization would drop to 0 on one or a few GPUs. It looks to me like the /cache/ folder is shared for the multiple runs and is the root of the issue (maybe hash collisions?).
Simply exposing a cache_dir argument to StreamingDataset could be a convenient fix.

Hi @lilavocado, @emileclastres,
We’ve added support for passing the cache_dir parameter in the Streaming dataset.
Feel free to try it out and share your feedback!
You can use it directly from the main branch, and this feature will be officially included in the upcoming release.
Thank you! 😊


Move view index files to .recovery when db is deleted

Overview
Before change, the view index files were renamed in place if the corresponding database was deleted and "enable_database_recovery" configuration item is set to true. This allows view index files to be re-used if database is recovered.
However, these deleted view files are spread widely and  may become orphans. This makes disk management difficult.
In order to help better manage disk, the change is to implement automatic movement of index files into centralized place when main database is deleted.

Testing recommendations
make check apps=couch tests=nuke_dir_test_
======================== EUnit ========================
Nuke directory tests
  enable_database_recovery = false, context = delete
    couch_file_tests:499: make_rename_dir_test_case...ok
    couch_file_tests:500: make_rename_dir_test_case...ok
    couch_file_tests:501: make_rename_dir_test_case...ok
    [done in 0.009 s]
  enable_database_recovery = false, context = compaction
    couch_file_tests:499: make_rename_dir_test_case...ok
    couch_file_tests:500: make_rename_dir_test_case...ok
    couch_file_tests:501: make_rename_dir_test_case...ok
    [done in 0.009 s]
  enable_database_recovery = true, context = delete
    couch_file_tests:499: make_rename_dir_test_case...ok
    couch_file_tests:500: make_rename_dir_test_case...ok
    couch_file_tests:501: make_rename_dir_test_case...ok
    [done in 0.009 s]
  enable_database_recovery = true, context = compaction
    couch_file_tests:499: make_rename_dir_test_case...ok
    couch_file_tests:500: make_rename_dir_test_case...ok
    couch_file_tests:501: make_rename_dir_test_case...ok
    [done in 0.009 s]
  delete_after_rename = true
    couch_file_tests:517: make_delete_dir_test_case...ok
    couch_file_tests:518: make_delete_dir_test_case...ok
    couch_file_tests:519: make_delete_dir_test_case...ok
    couch_file_tests:520: make_delete_dir_test_case...ok
    [done in 0.012 s]
  delete_after_rename = false
    couch_file_tests:517: make_delete_dir_test_case...ok
    couch_file_tests:518: make_delete_dir_test_case...ok
    couch_file_tests:519: make_delete_dir_test_case...ok
    couch_file_tests:520: make_delete_dir_test_case...ok
    [done in 0.012 s]
  [done in 0.473 s]
=======================================================
  All 20 tests passed.

GitHub issue number
This PR will be the number

Related Pull Requests

Checklist

[X] Code is written and works correctly;
[X] Changes are covered by tests;
[ ] Documentation reflects the changes;

@eiri Thanks again for your comments. I have addressed them except for item3 "run some kind of perf test". For item2 "the final path for the recovery indexes", you can see some test result below.
make check apps=couch tests=deleted_filename_test_. Would you please take a further look?
======================== EUnit ========================
couch_file:758: should_create_proper_deleted_filename (/srv/data/dbname.couch)...ok
couch_file:758: should_create_proper_deleted_filename (/srv/data/.dbname_design/mrview/3133e28517e89a3e11435dd5ac4ad85a.view)...ok
couch_file:758: should_create_proper_deleted_filename (/srv/data/shards/00000000-1fffffff/dbname.1458336317.couch)...ok
couch_file:758: should_create_proper_deleted_filename (/srv/data/.shards/00000000-1fffffff/dbname.1458336317_design)...ok
couch_file:758: should_create_proper_deleted_filename (/srv/data/.shards/00000000-1fffffff/dbname.1458336317_design/mrview/3133e28517e89a3e11435dd5ac4ad85a.view)...ok
couch_file:758: should_create_proper_deleted_filename (/srv/data/.recovery/shards/00000000-1fffffff/dbname.1499329402_design)...ok
couch_file:758: should_create_proper_deleted_filename (/srv/data/.recovery/shards/00000000-1fffffff/dbname.1499329402_design/mrview/8fabddcb28f501d6764afd7def3bd352.view)...ok
couch_file:758: should_create_proper_deleted_filename (/srv/data/db.name.couch)...ok
couch_file:758: should_create_proper_deleted_filename (/srv/data/.db.name_design/mrview/3133e28517e89a3e11435dd5ac4ad85a.view)...ok
couch_file:758: should_create_proper_deleted_filename (/srv/data/shards/00000000-1fffffff/db.name.1458336317.couch)...ok
couch_file:758: should_create_proper_deleted_filename (/srv/data/.shards/00000000-1fffffff/db.name.1458336317_design)...ok
couch_file:758: should_create_proper_deleted_filename (/srv/data/.shards/00000000-1fffffff/db.name.1458336317_design/mrview/3133e28517e89a3e11435dd5ac4ad85a.view)...ok
couch_file:758: should_create_proper_deleted_filename (/srv/data/.recovery/shards/00000000-1fffffff/db.name.1499329402_design)...ok
couch_file:758: should_create_proper_deleted_filename (/srv/data/.recovery/shards/00000000-1fffffff/db.name.1499329402_design/mrview/8fabddcb28f501d6764afd7def3bd352.view)...ok
couch_file:758: should_create_proper_deleted_filename (/srv/data/user/dbname.couch)...ok
couch_file:758: should_create_proper_deleted_filename (/srv/data/.user/dbname_design/mrview/3133e28517e89a3e11435dd5ac4ad85a.view)...ok
couch_file:758: should_create_proper_deleted_filename (/srv/data/shards/00000000-1fffffff/user/dbname.1458336317.couch)...ok
couch_file:758: should_create_proper_deleted_filename (/srv/data/.shards/00000000-1fffffff/user/dbname.1458336317_design)...ok
couch_file:758: should_create_proper_deleted_filename (/srv/data/.shards/00000000-1fffffff/user/dbname.1458336317_design/mrview/3133e28517e89a3e11435dd5ac4ad85a.view)...ok
couch_file:758: should_create_proper_deleted_filename (/srv/data/.recovery/shards/00000000-1fffffff/user/dbname.1499329402_design)...ok
couch_file:758: should_create_proper_deleted_filename (/srv/data/.recovery/shards/00000000-1fffffff/user/dbname.1499329402_design/mrview/8fabddcb28f501d6764afd7def3bd352.view)...ok
=======================================================
  All 21 tests passed.

@davisp Hi Paul, thanks for your review and comments. I addressed most of comments. For other comments, I leave some response. Would you please check? Thanks again

@davisp Hi Paul, I removed dbname directory between .recovery and shards in new commit. Would you please take another look? Thanks

Thanks @davisp for your review. I have changed name and could you please take yet another look when getting time? Thanks again.

+1

Please do not merge this to master until after the 2.1 branch is created. This should happen in the next 7 days.

You may merge this one when ready. Thanks for waiting! :)

According to the discussion with @jiangphcn, I tried to run some test cases to compare the performance difference between two designs(the current design and the new design in this PR). From the test result, I can see there are some perf improvement with new design. There is a report with all test details under: https://github.com/cloudant/couchdb/blob/index-delete-new-design-testreport/test_report/index_delete_comparision_report.ipynb

Go ahead and merge this when ready @jiangphcn .

Thanks @wohali for your reminder and patience. There is some suggestion from Ops expert about not moving view index to /srv/view_index/.recovery directory. Otherwise, it will use more inode and there is risky that there is no atime to set for some mounted driver. I have to hold on merge this PR and will come back later. Thanks again.

@jiangphcn it's been a month. If we're still not sure what to do here, could we close this PR and open a new PR in the future instead, when you're ready? Thanks.

yes, let me close this PR @wohali

@wohali It looks that I don't have permission to close this PR. Can you help close this PR? Thanks

thanks @davisp for closing this PR.


Emoji localization foundation

Add a way to crowdsource emoji localization.
I will add instructions and tools to make it easy to localize emojis, where each emoji will get a unique localization key based on its unicode identifier. There will also be a SwiftUI preview to let us easily inspect that emojis are properly localized.
You will then be able to submit localizations as PRs, at which I will create a new issue with all the supported locales as checkboxes.

This is introduced in KeyboardKit 6.7 and will have to be a community effort.
If you want localized emojis, you can submit localizations as PRs.


Improve thor generate to create test files

As of right now running thor generate  will create a RESTful route in /rest/api/<end point>, and model in /models/<end point>, as well as adding to /rest/api.rb module.
Tests should also be automatically generated creating the following:

A JSON fixture /spec/fixtures/<underscored_name>.

Should only be one instance of an object, see /spec/models/news_spec.rb for an example.

A model test /spec/models/<underscored_name>.

This should test for creation from JSON or JSON array, depending on the API response.
Should also test to get the data associated from the response.

A RESTful test in rest_spec.rb /spec/rest/rest_spec.rb.

Should test the newly created route client.<our_new_route> returns the correct data model.

Closing in preparation of archival and move to GitLab.


Tests for PRGAViaPhaseGradient

This PR adds explicit testing for the PRGAViaPhaseGradient bloq, which can also be useful as a reference on its usage. It solves issue #840.

For the future it would be good to have a specific rotation-by-phasegrad

This is encapsulated in QvrPhaseGradient ?

I don't think so.  It is very close to what one would need for rotation by phase gradient given quantum data. The documentation for QvrPhaseGradient indicates just phasing. Control is never listed which you would need. Also an additional multiplication step by gamma seems specific to the reference in the documentation.  QvrPhaseGradient looks like a specific example of something that I would imagine a rotation by phasegradient.

I am mistaken.  In https://arxiv.org/pdf/2007.07391.pdf Appendix A there is an improvement over the naive controlled addition which would be double the complexity.  The improvement enables control with only clifford gates and thus b_grad - 2 Toffoli.

@Vicara12 can you merge this?


Reloading weapons fails and causes error

When trying to reload a weapon, or drag and drop ammo onto a weapon, receive the following error in console:

When clicking the reload button on the weapon, the proper number of rounds is deducted from the rounds item stack, but it is not reflected on the ammo of the weapon
Before reload:

After reload:

Note to self for later: this should be solved by removing a .data on line 138. Will PR it when I get a chance

This was fixed during the big data model migration and will be in the next release.


ref+vault fails with "no value found for key"

I'm having problems getting vault ref to work properly.
$ vault kv get -field=secretContent "v1/prod/kv/foo"
<redacted>

$ echo "foo: ref+vault://v1/prod/kv/foo#/secretContent" | ./main eval -f -
expand vault://v1/prod/kv/observability/metrics-query-service-sandbox#/secretContent: no value found for key secretContent

@sirianni Hey! Neither vault kv get nor ref urls should contain v1/ in the key.
$ echo $VAULT_ADDR
http://<IP_ADDRESS>:8200

$ vault secrets enable -version=1 -path prod/kv kv

$ vault write prod/kv/foo secretContent=CONTENT
Success! Data written to: prod/kv/foo

$ vault read -field secretContent prod/kv/foo
CONTENT

$ vault kv get -field secretContent prod/kv/foo
CONTENT

$ echo 'secret: ref+vault://prod/kv/foo#/secretContent' | vals eval -f -
secret: CONTENT

Thanks @mumoshu !  The v1 is our company's own naming scheme for vault.
$ vault kv list "/v1/prod/kv/"
Keys
----
<redacted>

@sirianni Thanks! I'm still unable to reproduce your issue.
$ vault secrets enable -version=1 -path v1/prod/kv kv
Success! Enabled the kv secrets engine at: v1/prod/kv/
$ vault write v1/prod/kv/foo secretContent=CONTENT
Success! Data written to: v1/prod/kv/foo
$ vault read -field secretContent v1/prod/kv/foo
CONTENT
$ vault kv get -field secretContent v1/prod/kv/foo
CONTENT
$ echo 'secret: ref+vault://v1/prod/kv/foo#/secretContent' | vals eval -f -
secret: CONTENT
$ vault kv list "/v1/prod/kv/"
Keys
----
foo

Would you mind sharing the exact steps to reproduce your issue? There may be slight difference in how we mount the kv backend?

I've root caused the issue to our Vault installation using the "version 2" KV engine.
You can see here in the Vault CLI that for v2 KV stores, the string data is inserted into the path between the "mount point" and the "key path".  Unfortunately it does not seem that the Vault golang SDK does this automatically.
I was able to work around the issue by manually inserting data into the path.  In our Vault setup, the secrets store is (confusingly) mounted at v1/prod/kv
foo: ref+vault://v1/prod/kv/data/foo#/secretContent

https://github.com/BetterCloud/vault-java-driver/issues/114 has a good summary of the issue.

@sirianni Ah! That's good to know. Thank you so much for tracking it down to the root.
Maybe we'd better document a few examples with which vault read and vault kv get operations map to which ref URL at least?
I've also read the issue you've shared. Do you think we can somehow auto-detect the version of the kv backend requested and automatically inject the data/ into the path depending on the version?

Do you think we can somehow auto-detect the version of the kv backend requested and automatically inject the data/ into the path depending on the version?

Yes, I think this is what the vault CLI does

We're hit with the same issue - migrating from v1 to v2 means we had to change all vals references and manually add data/ to the path.  I've created a PR https://github.com/variantdev/vals/pull/33 using vault CLI helper methods as @sirianni pointed out.


feat(slides): add slides controller

Short description of what this resolves:
Slides can't be programatically changed, which would be nice.
Changes proposed in this pull request:

Add a slider controller

Ionic Version: 2.x

@DomiR
why not this?
    ngAfterViewInit() {
        this.slider = this.ionicApp.getComponent('my-slider');
    }

    nextProgramatically() {
        this.slider.next();
    }

Thanks for the PR! We'll take a look at this as part of beta.5. :smile:

@DomiR Thanks for the PR, however, with ng2's @ViewChild we can get a reference to the slider and interact with it then. I've updated our tests to show an example: https://github.com/driftyco/ionic/commit/2295bd9264f3ba8f2ffce7e07fcde1d3fd1ac03a We'll also work on improving the docs, thanks


WIP: Lots of changes

This is a WIP PR which does many things:

Makes the SkipList API usable with no_std by requiring a Guard to be passed in where needed (#4).
Adds lower_bound and upper_bound functions (#5).
Significant performance improvements for lookups (3x faster on ARM).

Since a lot of changes were made to the code, I put the new code in base1.rs.

Rename Entry::{next, get_next} to Entry::{move_next, next}

Both options look fine to me. 👍

Remove SkipMap::pop_back
Remove Entry::{prev, get_prev}
Remove DoubleEndedIterator from Iter

The main change is that I am removing backward iteration since it represents a hidden O(log(n)) cost on every step. This means that iterating backwards is O(n log(n)), which may not be obvious to a user.

That sounds like a harsh price to pay. I think simply stating in the documentation that going forwards is fast and going backwards is slow will be enough. That's just a fundamental property of crossbeam-skiplist.
LevelDB similarly allows iterating forwards and backwards and mentions the caveat in its documentation.

OK, I have everything implemented except SkipSet. Since there's a quite a few changes, a look-over would be nice. In particular:

I ported SkipMap to use the new SkipList. New methods on SkipMap: lower_bound (replaces seek), upper_bound, range.
I added base::RefIter and base::RefRange which returned RefEntry instead of Entry. These are used by the SkipMap iterators.
All iterator types (Iter, RefIter, Range, RefRange) except IntoIter are now bi-directional.
I have added back methods for backwards iterator (SkipList::pop_back, Entry::prev, etc).

And SkipSet is done now. Everything is ready for merging! (finally)

Quick question: Are we also going to add fences to SkipMap and SkipSet for linearizability?

I would prefer leaving it as it is. I still feel that linearizability is not worth the added cost & complexity.

I would prefer leaving it as it is. I still feel that linearizability is not worth the added cost & complexity.

If the skip list is linearizable, that is arguably less complexity for the user to think about. And for us, the implementors, the lack of linearizability in base.rs means we have to be extra careful and ask ourselves twice whether it is safe to use anything other than SeqCst every time we do. It's sometimes a risky gamble, but hopefully we got everything right. That's more complexity than if we just went with SeqCst everywhere.
But if by complexity you meant the added fences to the SkipMap and SkipSet methods before/after forwarding calls to base.rs, then it should be relatively simple. Or am I missing something?
It is true that adding an option for linearizability increases the amount of code and maybe the API surface, however. And yes, having both relaxed and linearizable versions of the skip list is more complex than having just one version. We're on the same page on that one.
Furthermore, if we don't make SkipMap and SkipSet linearizable, then how does one get linearizability themselves? In addition to linearizability not being the default, now it's also difficult/error-prone to achieve at all. This is a non-starter for me.
My disagreement on this issue is twofold:

Linearizability should not be a luxury, it should at the very least be an option.
Moreover, it should not be just an extra option, it should be the default.

I think this philosophy (correctness by default, performance by request) has countless examples in Rust and in other languages:

ConcurrentSkipListMap in Java is fully seqcst. There isn't even an option for more relaxed operations.
slice::sort is the stable sort. The faster and unstable sort is sort_unstable.
slice::get is the safe access method. The faster and unsafe version is slice::get_unchecked.
compare_and_set and compare_exchange are strong variants. The faster and weaker one is compare_exchange_weak.
In C++, all operations on std::atomic are seqcst by default. If Rust had default arguments, they would be, too.
It is impossible to break the safety of safe Rust. If you need to go faster, just write unsafe { ... }.
You can get shared mutability with Cell, RefCell, Mutex, RwLock. Too slow? - No problem, use unsafe.
Other synchronization primitives like Mutex and channels are sequentially consistent, too.

So the philosophy is always that safety/consistency/correctness is the default, and performance is an option. I'd argue that the great advance of Rust is that it offers performance despite safety, not safety despite performance. And if we ever really have to choose just one between the two, safety trumps performance. (Of course, there's some nuance around things like arithmetic overflow in release mode, but those are very minor deviations, and don't really break safety.)
Note that this sometimes even applies to C++, an unsafe language which usually goes the other way around and prefers to sacrifice safety over performance. In C++, seqcst operations in std::atomic are the default. Also, it chooses to offer only the equivalent of Arc, and Rc is not even an option!
Going back to our skip lists, I'd say we have to have sequentially consistent skiplists, one way or another. This is not to say that faster and more relaxed operations shouldn't be offered - just not as the only nor the default option. Relaxed operations could be exposed through base::SkipList, or weak::SkipMap, or SkipMap::<operation>_weak, or something like that.
I think we've had similar discussions before. Do you think that despite the precedent stemming from the examples I've listed, we still shouldn't have linearizable skiplist-based maps and sets? If so, why? (Yes, there's a performance cost, but we're still being faster than Java!).
Finally, here's my go-to example illustrating what goes wrong when you omit linearizability. Consider the following:
let q = ConcurrentQueue::new(2); // the capacity is 2
crossbeam::scope(|s| {
    for _ in 0..2 {
        s.spawn(|| {
            for _ in 0..10_000 {
                q.push(());
                assert_eq!(q.try_pop(), Some(()));
            }
        });
    }
});

The assert will break if you implement this concurrent queue (one of the most popular!). This could lead to really subtle bugs and the real problem is difficult to understand, let alone foresee. And that's just a really simple queue...

In the end, I'm only going to be using base::SkipList myself, so I don't really care. If you feel strongly about it then let's just add this as an option.
Regarding how we can implement this option, here is what I propose:
trait Linearizable {
    fn seq_cst_fence();
}
struct Relaxed;
impl Linearizable for Relaxed {
    fn seq_cst_fence() {}
}
struct SeqCst;
impl Linearizable for SeqCst {
    fn seq_cst_fence() { fence(SeqCst); }
}

struct SkipMap<K, V, L: Linearizable = SeqCst> { ... }

Ok, so I want to give this PR a thumbs up now, and revisit the linearizability issue later. Since we're in disagreement, I wonder what the general public thinks about it. But let's figure this out later.
Feel free to merge!

Can you open an issue to track the linearizability issue?


getPhoneContacts method signature doesn't include a parameter for filter options

The method signature is:
getPhoneContacts(): Promise<PhoneContactsResult>
However baseConnector.js sends an argument containing filter options to getPhoneContacts method.
The expectation is to add an argument with a proper type for the filter options.
I'm using scv-connector-base version 70b82e0e9eb3c925c3ccf6f53cc98f1ed0c2b6eb.

The filter is being sent from Salesforce when you use the latest release Summer 21' and if you do a contact search after clicking "add caller". For example,


Fix CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF warnings

Does any other open PR do the same thing?

No
What issue is this PR fixing?
https://github.com/react-community/react-native-maps/issues/2153
How did you test this PR?

Building the project with the build warning CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF turned on.

LGTM @alvelig 🐽


My TableTools are not working

My TableTools are not working it is giving me this error on console                                                       Uncaught TypeError: Cannot read property 'aDataSort' of undefined   in jquuery.datatables.min.,js file
I have included  these two files

and my jquery is
$('#datatable_examplesss').dataTable( {
"dom": 'T<"clear">lfrtip',
"tableTools": {
"sSwfPath": "/swf/copy_csv_xls_pdf.swf"
}
} );
but it does not showing me anything on table plz help me

Please give a link to a test case showing the issue.

I dont know where i can put it online.
Here is my code
I have included  these two files

and my jquery is
$('#datatable_examplesss').dataTable( {
"dom": 'T<"clear">lfrtip',
"tableTools": {
"sSwfPath": "/swf/copy_csv_xls_pdf.swf"
}
} );

Using jsfiddle or codepen would be fine for a test case thanks.


Change "Mark as unread" indicator to Green

Isn't this cute?

We can distinguish between new notifications and threads marked as unread.

Green: only threads marked as unread
Blue: real notifications (and maybe the above)

The gradient comes straight from GH's buttons.

Nice! This will help notifications-preview-github in distinguishing whether to open the dropdown on hover or not! :cool: :pray:

All these nifty features are amazing! I just discovered this "Mark as unread" button - was thinking that it was a Github feature. But then, on my phone I couldn't see the conversation I'd marked as 'unread', that's when I realized it was refined which was to praise 😄 ! Awesome feature.
Although I did observe that the green indicator gets erased by the notifications-preview-github addon, perhaps due to a race condition. The indicator appears for a moment, and then the other addon removes it.


XIVAlex not opening with FFXIV. Anyone having the same issue?

Whenever I open FFXIV, XIVAlex won't open either. It is currently installed. I already uninstalled and installed again but still no workaround.
Anyone else with the same issue? Or if anyone knows how to fix it, please let me know here, I can't figure it out. Thank you.

I'm having the same issue as well - XIVAlexander loading at all with my game.

same here

also having the same issue launching the game with xivquicklauncher. xivalexander seems to not load with the game but can be injected post game launch using the run once

Okay guys after a lot of testing it turned out that XIV was opening but not showing in taskbar, I mentioned it in #663, closing this for now.


Removing last red module from the diagram

Making changes to RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelDigisClustersFromSoA.cc to remove the third module of the modules diagram. The blue module was changed, but the file related to the red module still exists. Please let me know if it is fine.

Just made the change. Is it better now?

looks good


No error pops up after deleting the connected database in Portal

Build Version: 20190831.14
OS: All
Repro Steps:

New a scrapbook --> Connect a database --> Run any commands.
Open the special account in Azure Portal --> Click "Data Explorer" --> Delete the connected database.
Back to VS Code--> Refresh the Cosmos DB Explorer --> Make sure the connected database disappears.
Click "Execute All" again in the open scrapbook --> Check the result.

Expect:
Pop up an error to prompt the users to select a new database to connect

Actual:
Execute well but display empty result.

More Info:

Execute well but display empty result on Mac after deleting the connected database in Cosmos DB Explorer.
Need to connect a new data after deleting the connected database in Cosmos DB Explorer on Windows.

Going to close this as won't-fix. Mongo doesn't seem to throw an error in this case, so we're at least consistent. In a sense, there are no collections names so an empty array is accurate 🤷♂ In addition, it's not worth an extra check against the database just to throw an error from our side


⚠ Bofrost.de has degraded performance

In 73e2161, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1716 ms

Resolved: Bofrost.de performance has improved in 300def5 after 6 minutes.


Update cookie methods in conf.py

app.add_stylesheet() and app.add_javascript() were renamed in version 1.8 and obsoleted in version 4

I gave Py3.9 a try, based on guesswork

To fix errors in 3.9, import gcd from math, not fractions anymore. See docs:

@randomir, for the gcd update I think that commit use to networkx>2.5: https://github.com/networkx/networkx/commit/b007158f3bfbcf77c52e4b39a81061914788ddf9
We currently have a requirement networkx==2.0

@JoelPasvolsky, oops, I only looked at the last line. You're right, it should be sufficient to update networkx. Not sure why we have it pinned to 2.0 (pretty old version).

We also use ancient dimod and old penaltymodels... We should probably update those as well.


agentserver for agent-portal/gptstore

Agent-portal provides different features to its users . We'd better to maintain in a new api server.
We will have two kinds of agents by default:

https://github.com/kubeagi/arcadia/issues/553
https://github.com/kubeagi/arcadia/issues/554

Will reuse our apiserver code as much as possible.
Currently langchaingo provides two kinds of agent implementations:

MRKL Agent

MRKL https://arxiv.org/pdf/2205.00445.pdf
langchaingo https://github.com/tmc/langchaingo/blob/main/agents/mrkl.go
blog: https://cobusgreyling.medium.com/create-a-mrkl-autonomous-agent-using-langchain-openai-serpapi-39664a514459

Conversational Agent

langchaingo https://github.com/tmc/langchaingo/blob/main/agents/conversational.go

whether we need a separate apiserver for GPTs, we can decide later when we have more experience.


Min 3rd

I edited some minor comment printing errors and changed a bit of the code to meet the PEP standard(There are still some warnings).
Please review and merge!

Reviewed and am happy to commit


Update README.md

The taskbanner.png image in the top is visible now.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

Hi @ericsciple ,
Thanks for the merge. Looking forward to contribute more in the future.
Regards.
Pramil


CRITICAL: Issue regarding exiting "Preset 0"

It appears the ATK-DP100's firmware has a bug where it will automatically enable the output when switching from preset 0 to another preset. This will be the case whenever the device is first powered on as it will always start in preset 0.
This concerns the observed behavior when using UseGroup API of the ATK-DP100 DLL.
This means the user MUST BE VERY CAUTIOUS of what each preset is configured to.
For instance, if preset 9 is set to say 25V and the DP100 is currently in preset 0. It will automatically enable the output during this call to UseGroup. This behavior does not happen during transitions from presets other than 0, in fact the opposite is true (the output will turn off, which is a much safer practice).
There are of course a ways we can handle this at the application layer to either warn the user or perhaps change the application logic to simply load the value into the UI's setpoints, but not call UseGroup until the output is turned on by the user.
Currently the application logic will set the output off due to logic that follows the UseGroup call, but this will likely not take effect until at least 1ms later due to USB timing.

A test build is being evaluated and is available on fw-preset-workarounds this branch may be refactored/rebased, but is available for those that may be interested.


Feature request: option to skip unoccupied tags for cycle-tags

See https://gitlab.com/akumar-xyz/river-shifttags/-/issues/2 for this feature in a similar utility.

Thanks for the request!
Can you check out #2?  I hope I got it right, let me know otherwise.

Implemented.


some tests

Overview
additional tests for Boto3Cache

/do-e2e-tests

Codecov Report

Merging #353 into master will increase coverage by 1.44%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #353      +/-   ##
==========================================
+ Coverage    68.2%   69.65%   +1.44%
==========================================
  Files          30       30
  Lines        2692     2692
  Branches      457      457
==========================================
+ Hits         1836     1875      +39
+ Misses        764      723      -41
- Partials       92       94       +2

Impacted Files
Coverage Δ

taskcat/_cli.py
77.52% <100%> (ø)
:arrow_up:

taskcat/_cfn/template.py
76% <0%> (-3%)
:arrow_down:

taskcat/_lambda_build.py
85.24% <0%> (-1.64%)
:arrow_down:

taskcat/_client_factory.py
97.29% <0%> (+38.73%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c48e4ed...2df524d. Read the comment docs.

/do-e2e-tests


Fast interpolation

Some proof-of-concept work on faster linear interpolation.
NB. This is targeting the "decoupler" branch, which is a temporary branch for testing out a bunch of extensions, hacks, etc. The ones which turn out to be useful will be polished up and applied to master as usual.

The temporary decoupler branch has been around for over 2 years. It has 18 unmerged commits. I have no idea of their value, but I do know that any value is diminishing over time.
Proposal: The decoupler branch to be removed from github.com/SciTools/iris when we tidy up all of our maintenance branches upon Iris 2.0 release. @SciTools/iris-devs

I agree :+1:


[UX] status bar information

There's quite a bit of confusion about what this status bar is supposed to tell us

I therefore want to open this issue to discuss what it is, isn't, should be, shouldn't be and strange behaviours I've observed.
Background
I first mentioned not understanding this status bar here https://github.com/ngdenterprise/neo3-visual-tracker/issues/124#issue-1164023091 and then recently (2 months after the first post and having forgotten that I wrote about it) again here https://github.com/ngdenterprise/neo3-visual-tracker/issues/129#issuecomment-1140758269. I'm having a discussion with the user robliou in #124 and felt it was time to split it off in its own issue
What is its purpose?
Just from its visual presence I cannot understand what it is telling me, which from a UX perspective is a problem. Let's take this status as an example

Neo: Not connected

To figure out what connected in this case means and why I need to be connected I had to look at the source code. It turns out it says something about the "connection status" (more on this later) of the BlockchainMonitor class. This class, which if my scan is right, polls a chain on an interval for its block height and caches blocks that have transactions internally for quick access elsewhere in the code base. It obtains this information via RPC calls to the chain.
So "connection status" refers to the RPC connection of the BlockchainMonitor class? Yes and No. The status changes (or is supposed to, see the observations section below) depending on if the block count of the chain can be requested via RPC. RPC is not a long lasting connection, just short get/posts requests, which adds to the confusion of what "connected to" means in the screenshot above.
What I think it is; if the "system" can successfully monitor a chain.
Should it exist?
Why should I care if some internal process can cache information? I just want to know that it failed to obtain the latest information when I open a tab/window that actually uses the information this monitor tries to obtain/cache (e.g. the block explorer). Until that time I don't care.
I tend to think that this status bar shouldn't exist at all. If it is decided that it should exist, then please let's change what the text says to something like Chain monitor [Online]: monitoring <chain name>
Observations
Let's assume the status bar should exist

It does not show up at all for MainNet or TestNet yet is actively running in the background and functioning properly as we can see in the debug console on the left and by the blocks that have been fetched in the block explorer tab in the right window

So it only starts to show if we start a local chain. If we do so and then kill the terminal (which stops the chain), then the status bar keeps saying "connected to".

I know the status is normally updated on an interval, but this one never updates (unless we start a new chain)

@devhawk would love to get your view on this


Cannot find version that satisfies the requirement tensorflow-addons

Rasa version:
Trying to install 1.10.8
Python version:
$ python --version
Python 3.7.6

Operating system (windows, osx, ...):
Windows 10
Issue:
pip install rasa fails with missing tensorflow-addons version. Similar to #6081, #6139, and #5722, except I'm not using Python 3.8.
Also tried using Python 3.7.6 64bit, same issue.
Error (including full traceback):
$ pip install rasa
Collecting rasa
  Using cached rasa-1.10.8-py3-none-any.whl (511 kB)
Collecting slackclient<3.0.0,>=2.0.0
  Using cached slackclient-2.7.3-py2.py3-none-any.whl (71 kB)
Collecting numpy<2.0,>=1.16
  Using cached numpy-1.19.1-cp37-cp37m-win32.whl (10.9 MB)
Collecting scikit-learn<0.23,>=0.22
  Using cached scikit_learn-0.22.2.post1-cp37-cp37m-win32.whl (5.7 MB)
Collecting tensorflow_hub<0.9,>=0.7
  Using cached tensorflow_hub-0.8.0-py2.py3-none-any.whl (101 kB)
Collecting kafka-python<2.0,>=1.4
  Using cached kafka_python-1.4.7-py2.py3-none-any.whl (266 kB)
Collecting tensorflow-probability<0.10,>=0.7
  Using cached tensorflow_probability-0.9.0-py2.py3-none-any.whl (3.2 MB)
Collecting webexteamssdk<1.4.0,>=1.1.1
  Using cached webexteamssdk-1.3.tar.gz (56 kB)
Collecting boto3<2.0,>=1.12
  Using cached boto3-1.14.27-py2.py3-none-any.whl (128 kB)
Collecting PyJWT<1.8,>=1.7
  Using cached PyJWT-1.7.1-py2.py3-none-any.whl (18 kB)
Collecting colorhash<1.1.0,>=1.0.2
  Using cached colorhash-1.0.2-py2.py3-none-any.whl (6.0 kB)
Collecting matplotlib<3.3,>=3.1
  Downloading matplotlib-3.2.2-cp37-cp37m-win32.whl (9.0 MB)
     |████████████████████████████████| 9.0 MB 104 kB/s
Collecting rasa-sdk<2.0.0,>=1.10.0
  Using cached rasa_sdk-1.10.2-py3-none-any.whl (38 kB)
Collecting apscheduler<3.7,>=3.6
  Using cached APScheduler-3.6.3-py2.py3-none-any.whl (58 kB)
Collecting requests<3.0,>=2.23
  Using cached requests-2.24.0-py2.py3-none-any.whl (61 kB)
Collecting ujson<3.0,>=1.35
  Using cached ujson-2.0.3.tar.gz (7.1 MB)
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Installing backend dependencies ... done
    Preparing wheel metadata ... done
Collecting packaging<21.0,>=20.0
  Using cached packaging-20.4-py2.py3-none-any.whl (37 kB)
Collecting psycopg2-binary<2.9.0,>=2.8.2
  Using cached psycopg2_binary-2.8.5-cp37-cp37m-win32.whl (984 kB)
Collecting python-dateutil<2.9,>=2.8
  Using cached python_dateutil-2.8.1-py2.py3-none-any.whl (227 kB)
Collecting questionary<1.6.0,>=1.5.1
  Using cached questionary-1.5.2-py3-none-any.whl (26 kB)
Collecting regex<2020.7,>=2020.6
  Using cached regex-2020.6.8-cp37-cp37m-win32.whl (252 kB)
Collecting redis<4.0,>=3.4
  Using cached redis-3.5.3-py2.py3-none-any.whl (72 kB)
Collecting SQLAlchemy<1.4.0,>=1.3.3
  Using cached SQLAlchemy-1.3.18-cp37-cp37m-win32.whl (1.2 MB)
Requirement already satisfied: setuptools>=41.0.0 in c:\users\jmnsf\.pyenv\pyenv-win\versions\3.7.6\lib\site-packages (from rasa) (41.2.0)
Collecting sanic-jwt<1.5.0,>=1.3.2
  Using cached sanic-jwt-1.4.1.tar.gz (19 kB)
Collecting attrs<19.4,>=19.3
  Using cached attrs-19.3.0-py2.py3-none-any.whl (39 kB)
Collecting pytz<2020.0,>=2019.1
  Using cached pytz-2019.3-py2.py3-none-any.whl (509 kB)
Collecting aiohttp<3.7,>=3.6
  Downloading aiohttp-3.6.2-cp37-cp37m-win32.whl (624 kB)
     |████████████████████████████████| 624 kB 1.7 MB/s
Collecting fbmessenger<6.1.0,>=6.0.0
  Using cached fbmessenger-6.0.0-py2.py3-none-any.whl (11 kB)
Collecting python-telegram-bot<13.0,>=11.1
  Using cached python_telegram_bot-12.8-py2.py3-none-any.whl (375 kB)
Collecting tqdm<4.46,>=4.31
  Using cached tqdm-4.45.0-py2.py3-none-any.whl (60 kB)
Collecting prompt-toolkit<3.0,>=2.0
  Using cached prompt_toolkit-2.0.10-py3-none-any.whl (340 kB)
Collecting networkx<2.5.0,>=2.4.0
  Using cached networkx-2.4-py3-none-any.whl (1.6 MB)
Collecting pydot<1.5,>=1.4
  Using cached pydot-1.4.1-py2.py3-none-any.whl (19 kB)
Collecting mattermostwrapper<2.3,>=2.2
  Using cached mattermostwrapper-2.2.tar.gz (2.5 kB)
Collecting scipy<2.0.0,>=1.4.1
  Using cached scipy-1.5.2-cp37-cp37m-win32.whl (28.2 MB)
Collecting pika<1.2.0,>=1.1.0
  Using cached pika-1.1.0-py2.py3-none-any.whl (148 kB)
ERROR: Could not find a version that satisfies the requirement tensorflow-addons<0.8.0,>=0.7.1 (from rasa) (from versions: none)
ERROR: No matching distribution found for tensorflow-addons<0.8.0,>=0.7.1 (from rasa)

Command or request that led to error:
$ pip install rasa

Opening and closing since I eventually found the solution but this could be useful for other users: the issue was I had the 32bit version of python installed, this was fixed by using 64bit instead.


fix word spelling

What kind of change does this PR introduce?
Typescript -> TypeScript

Did you add tests for your changes?

Does this PR introduce a breaking change?

What needs to be documented once your changes are merged?

Thanks


Update to RN 0.49

@keybase/react-hackers tested on ios sim, ios device, android sim, seems fine to me

@keybase/react-hackers bump