Destructing of argument that type is union type is not valid

Is it bug ? Or normal behavior ?
interface IFish {
    swim: string;
}

class Fish {
    readonly type = "FISH";

    constructor(public payload: IFish) { };
}

interface IBird {
    fly: string;
}

class Bird {
    readonly type = "BIRD";

    constructor(public payload: IBird) { };
}

class Some {
    readonly type = "SOME";

    constructor(public payload: null) { };
}

type Actions = Fish | Bird | Some;

// valid
const reducer = (action: Actions) => {
    switch (action.type) {
        case "BIRD":
            return { [action.payload.fly]: action.payload.fly };
        case "FISH":
            return { [action.payload.swim]: action.payload.swim };
        default:
            return "";
    }
}

// not valid
const reducer1 = ({ type, payload }: Actions) => {
    switch (type) {
        case "BIRD":
            return { [payload.fly]: payload.fly };
        case "FISH":
            return { [payload.swim]: payload.swim };
        default:
            return "";
    }
}

@MartinJohns is correct.


On archlinux systems, thumbnails cannot be displayed in the file manager

Describe the bug

To Reproduce
Steps to reproduce the behavior:
1 open coredumpctl
2 Use the file manager to open the folder with the step file
Expected behavior
generate thumbnails correctly
System Information:

OS: archlinux
GPU and GPU driver: intel arc a750

F3D Information
Paste the content of f3d --version: 2.1.0
Additional context
A memory dump occurs while generating thumbnails

It's working perfectly on my archlinux, with pcmanfm, which file manager or desktop environnement are you using ?
Are you using the package from pacman ?

After I use pcmanfm, thumbnails are displayed normally. I used Nautilus before

From https://f3d.app/doc/user/LIMITATIONS_AND_TROUBLESHOOTING.html
Some file managers (eg: Nautilus) are using sandboxing for thumbnails, which the F3D standard binary release does not support as it needs access to the Xorg server to render anything. In that case, you want to use the headless version of F3D that rely on EGL instead of Xorg, available in the [releases page](https://github.com/f3d-app/f3d/releases). If you use the portable archive, make sure to extract it somewhere the sandboxing system has access to, eg: Nautilus uses bwrap and gives it access to /usr but not to /opt.

In short, you need to use the EGL binary release to be able to get thumbnails with nautilus.

Please note F3D now support headless and non-headless in a single version, you can try the last nightly for that: https://github.com/f3d-app/f3d/releases/tag/nightly


Plot throughput

Proposal

It would be nice if Vegeta would support plotting of the throughput by HTTP code instead of just latencies.
Maybe vegeta plot -throughput. Or even two plots in the same HTML file, like the screenshot below.
Background

This would be interesting to show how a system behaves under overload. A low latency is not necessarily good if no successes are going through. It's nice to see what errors codes are returned at what time.
Workarounds

You can use the report tool to get an average success metric. Or you can use https://github.com/tsenart/vegeta#usage-real-time-analysis to get some kind of real time usage.

As an example, here is how Artillery plots a report:
.
Vegeta performs so much better though, so I would love to use it instead. :) Thanks for the great tool.

Vegeta maintains a fairly constant request rate, and hence, throughput, so I'm not sure what this would show you.

Hi, thanks for the answer. What I meant is that you could show how many responses where a 200 vs a 504 or 503 at each point in time, for example. I found that to be very helpful for analysis of what is happening.


Make oauth tokens automatically renew

Currently, the user has to renew their oauth tokens every couple of weeks. This can be jarring and would be better to streamline this ease of use by making it such that the token auto-renews.
https://dev.twitch.tv/docs/authentication/refresh-tokens/
This would require also saving the refresh token in addition to the current access token.

The downside to this is that we would need to have code as well as a client secret, which could be fine, but the issue is that the current auth method is missing a client secret (source code is visible so this won't happen) or a code (need said secret) or the refresh token (need a code).
You could probably use twitchtokengenerator, but you'll also be using their client id/secret (apparently?), which is fine but you'll be in a group sharing that same token which may be less than ideal.


github_runner_matrix: deploy new x86_64 runner when required

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[ ] Have you successfully run brew typecheck with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

Closes #18356.

I'll get to this late next week (or in the first half of the week following that).


[MIPS] Fix CALL16 reloc at 0x290 not against global symbol

When I compiled test model for MIPS platform I faced the following error during export_library (linkage):
mips-linux-gnu/bin/ld: /tmp/tmptd3u21a0/lib.o: CALL16 reloc at 0x290 not against global symbol
Issue details:
TVM generated model has non-global $xxx_compute_ functions. For example: $fused_nn_contrib_conv2d_NCHWc_add_compute_, $fused_nn_global_avg_pool2d_compute_, etc.
These functions are not marked as .globl in model assembly.
At the same time the functions are not marked as static too (llvm::Function::Create uses PrivateLinkage but not InternalLinkage).
It confuses MIPS codegen and in the assembly it calls $xxx_compute_ functions using the approach which is used for global prototype functions call (call16 approach).
MIPS has different approaches to call static and global prototype functions:

global function prototypes called using call16(my_fn) + .reloc R_MIPS_JALR + jalr
static functions called using simple jal my_fn

The issue is not visible on x86 / ARM because their assembly uses “call my_fn” / “bl my_fn” to call functions/subroutines regardless of their type.
This PR solves the issue by using InternalLinkage when $xxx_compute_ functions are created. It makes them static (STB_LOCAL in the case of ELF).
LLVM Linkage Types

Thanks @apivovarov !


Fix: pool-coordinator chart format,  default service name, max body size .etc

Validate pool-coordinator chart to ensure it is installable.
Add default pool coordinator related service name "pool-coordinator-etcd", "pool-coordinator-apiserver", and ports to yurthub default options.
Add '--max-txn-ops=1000' to pool-coordinator etcd container command.
Add default transfer body size between yurthub and etcd to '100M'

After this pr is merged, I'll test both 'leader' and 'follower' mode at the same time, in my dev environment, with many edge nodes.
And I will add all Resources (not only endpoints and endpointslices) , as pool-scope resources, like pods, some CRDs, to test terformance optimization.


Improved resilience of adapter-cache-memory-ttl tests

when CI is slow, these tests can erroneously fail
we should prefer to use sinon.useFakeTimers over awaiting a Promise with a timeout for better resilience against slow machines

Closing as this was becoming a dead end


Add support for AWS SSO PermissionSet - CustomerManagedPolicyReferences

*Issue # N/A
*Description of changes:
This PR fixes following error message from cfn-lint:

E3002 Invalid Property Resources/ReadOnlyPermissionSet/Properties/CustomerManagedPolicyReferences

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kddejong please kindly take a look on this.


Update/open source

@ToniRV @marcusabate , what was the purpose of 7ffafe2 . Is there a story for it?

Hi @ruffsl, I think that the idea was simply to wrap DBoW2 library into a more modern cmake alias DBoW2::DBoW2 not much more than that?
Is it giving you issues?

I think it might be. Unless I revert that commit, I'm seeing some build failures with missing headers:

> [builder 18/20] RUN --mount=type=cache,target=/root/.ccache     . /opt/overlay_ws/install/setup.sh &&     colcon build       --symlink-install       --mixin release ccache       --cmake-args         --no-warn-unused-cli         -DCMAKE_CXX_FLAGS="          -w":
#34 0.772 [connext_cmake_module] Warning: The location at which Connext was found when the workspace was built [[/opt/rti.com/rti_connext_dds-5.3.1]] does not point to a valid directory, and the NDDSHOME environment variable has not been set. Support for Connext will not be available.
#34 1.402 Starting >>> kimera_vio
#34 163.5 --- stderr: kimera_vio
#34 163.5 Cloning into 'googletest-src'...
#34 163.5 Note: switching to 'v1.10.x'.
#34 163.5
#34 163.5 You are in 'detached HEAD' state. You can look around, make experimental
#34 163.5 changes and commit them, and you can discard any commits you make in this
#34 163.5 state without impacting any branches by switching back to a branch.
#34 163.5
#34 163.5 If you want to create a new branch to retain commits you create, you may
#34 163.5 do so (now or later) by using -c with the switch command. Example:
#34 163.5
#34 163.5   git switch -c <new-branch-name>
#34 163.5
#34 163.5 Or undo this operation with:
#34 163.5
#34 163.5   git switch -
#34 163.5
#34 163.5 Turn off this advice by setting config variable advice.detachedHead to false
#34 163.5
#34 163.5 HEAD is now at 703bd9ca Googletest export
#34 163.5 In file included from /opt/kimera_ws/src/MIT-SPARK/Kimera-VIO/tests/testLoopClosureDetector.cpp:29:
#34 163.5 /opt/kimera_ws/src/MIT-SPARK/Kimera-VIO/include/kimera-vio/loopclosure/LoopClosureDetector.h:28:10: fatal error: DBoW2/DBoW2.h: No such file or directory
#34 163.5    28 | #include <DBoW2/DBoW2.h>
#34 163.5       |          ^~~~~~~~~~~~~~~
#34 163.5 compilation terminated.
#34 163.5 make[2]: *** [CMakeFiles/testKimeraVIO.dir/build.make:219: CMakeFiles/testKimeraVIO.dir/tests/testLoopClosureDetector.cpp.o] Error 1
#34 163.5 make[2]: *** Waiting for unfinished jobs....
#34 163.5 In file included from /opt/kimera_ws/src/MIT-SPARK/Kimera-VIO/include/kimera-vio/pipeline/Pipeline.h:32,
#34 163.5                  from /opt/kimera_ws/src/MIT-SPARK/Kimera-VIO/examples/KimeraVIO.cpp:27:
#34 163.5 /opt/kimera_ws/src/MIT-SPARK/Kimera-VIO/include/kimera-vio/loopclosure/LoopClosureDetector.h:28:10: fatal error: DBoW2/DBoW2.h: No such file or directory
#34 163.5    28 | #include <DBoW2/DBoW2.h>
#34 163.5       |          ^~~~~~~~~~~~~~~
#34 163.5 compilation terminated.
#34 163.5 make[2]: *** [CMakeFiles/stereoVIOEuroc.dir/build.make:63: CMakeFiles/stereoVIOEuroc.dir/examples/KimeraVIO.cpp.o] Error 1
#34 163.5 make[1]: *** [CMakeFiles/Makefile2:1273: CMakeFiles/stereoVIOEuroc.dir/all] Error 2
#34 163.5 make[1]: *** Waiting for unfinished jobs....
#34 163.5 In file included from /opt/kimera_ws/src/MIT-SPARK/Kimera-VIO/include/kimera-vio/pipeline/Pipeline.h:32,
#34 163.5                  from /opt/kimera_ws/src/MIT-SPARK/Kimera-VIO/tests/testPipeline.cpp:10:
#34 163.5 /opt/kimera_ws/src/MIT-SPARK/Kimera-VIO/include/kimera-vio/loopclosure/LoopClosureDetector.h:28:10: fatal error: DBoW2/DBoW2.h: No such file or directory
#34 163.5    28 | #include <DBoW2/DBoW2.h>
#34 163.5       |          ^~~~~~~~~~~~~~~
#34 163.5 compilation terminated.
#34 163.5 make[2]: *** [CMakeFiles/testKimeraVIO.dir/build.make:76: CMakeFiles/testKimeraVIO.dir/tests/testPipeline.cpp.o] Error 1
#34 163.5 make[1]: *** [CMakeFiles/Makefile2:787: CMakeFiles/testKimeraVIO.dir/all] Error 2
#34 163.5 make: *** [Makefile:141: all] Error 2
#34 163.5 ---
#34 163.5 Failed   <<< kimera_vio	[ Exited with code 2 ]
#34 163.5 [Processing: kimera_vio]
#34 163.5 [Processing: kimera_vio]
#34 163.5 [Processing: kimera_vio]
#34 163.5 [Processing: kimera_vio]
#34 163.5 [Processing: kimera_vio]
#34 163.5
#34 163.5 Summary: 0 packages finished [2min 42s]
#34 163.5   1 package failed: kimera_vio
#34 163.5   1 package had stderr output: kimera_v

Looks like the change assumes users install DBoW2 headers globally onto there entire system :bomb:


Github hyperlink Text Color not Consistent

Fix text color of github hyperlink to match the other nav bar links.

James created a new class to specifically target this hyperlink to be color white.


net/url: invalid percent encodings rejected by go1.19 are now accepted

What version of Go are you using (go version)?

$ go version

go version devel go1.20-831c6509cc Mon Nov 21 15:23:39 2022 +0000 darwin/arm64

Does this issue reproduce with the latest release?
No, this behavior is new in master
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="arm64"
GOBIN=""
GOCACHE="/Users/liggitt/Library/Caches/go-build"
GOENV="/Users/liggitt/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="arm64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/liggitt/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/liggitt/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/Users/liggitt/git/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/Users/liggitt/git/go/pkg/tool/darwin_arm64"
GOVCS=""
GOVERSION="devel go1.20-831c6509cc Mon Nov 21 15:23:39 2022 +0000"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/dev/null"
GOWORK=""
CGO_CFLAGS="-O2 -g"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-O2 -g"
CGO_FFLAGS="-O2 -g"
CGO_LDFLAGS="-O2 -g"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/37/ns7gt60104scfm9fvg02p1jh00kjgb/T/go-build1773376802=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
Use url.Parse to check for invalid %-encoding sequences.
package main

import (
        "fmt"
        "net/url"
)

func main() {
        fmt.Println(url.Parse("invalid%"))
}

What did you expect to see?
An error, matching existing go releases.
What did you see instead?
No error.
Details
This change is due to https://github.com/golang/go/issues/56732 / https://go-review.git.corp.google.com/c/go/+/450375, which intentionally relaxes validation requirements for percent-decoding of URLs.
This means that systems using url.Parse() to ensure URLs are well-formed now accept malformed %-encoding sequences. This is already showing up as unit test failures in other projects testing against the golang dev branch, e.g. https://github.com/kubernetes/kubernetes/issues/113948, and required relaxing existing go unit tests in https://go-review.git.corp.google.com/c/go/+/450375 to accept previously rejected data.
Hoisting my question from https://github.com/golang/go/issues/56732#issuecomment-1320945282:

Doesn't loosening of URI validation risk propagating invalid %-encodings to other systems that will choke on the invalid URIs (like, for example, something built with go1.19)? This seems opposite to the rationale used to justify tightening of ParseIP logic in go1.17 (https://github.com/golang/go/issues/30999).

If the implications of relaxing this are considered, and go1.20 decides to proceed relaxing this parsing to accept URIs as valid which go1.19 rejected as invalid, my follow-up questions are about how to roll out this change in a controlled way:

For go1.20 users that want to keep validating things strictly to disallow invalid %-encodings, how should they change their code?
For systems currently building with go1.19 that will need to update to build with go1.20 and want to preserve existing runtime behavior with minimally invasive code changes, how can they accomplish that?

cc @dgryski @ianlancetaylor as authors of the prompting issue and CL
cc @aojea @dims for implications on cross-version Kubernetes compatibility
cc @rsc for intersection with runtime compatibility behavior discussed in https://github.com/golang/go/discussions/55090

cc @neild @golang/security

Non corp gerrit URL: https://go-review.googlesource.com/c/go/+/450375

Non corp gerrit URL: https://go-review.googlesource.com/c/go/+/450375

sorry, fixed in the description

This change doesn't seem urgent. Should we roll it back and take our time figuring out the correct behavior in 1.21?

It also broke wide variety of Google's tests.

This change doesn't seem urgent. Should we roll it back and take our time figuring out the correct behavior in 1.21?

That would be my inclination, since it's not clear the cross-version and downstream implications of relaxing validation here were considered, and the standard change this was intended to improve interoperability with is not a recent one.


Add rule for recetox_aplcms_compute_clusters to scale memory according to the input.

The tool currently has no config (so I assume 4GB by default?) and crashes when being given about 1GB of input data.
So I assume a rule like this would make sense?
  toolshed.g2.bx.psu.edu/repos/recetox/recetox_aplcms_compute_clusters/recetox_aplcms_compute_clusters/.*:
    mem: 4
    rules:
    - id: rcx_aplcms_clusters_large_input
      if: input_size >= 0.8
      mem: 8

Is it also possible to stack these rules, so to provide even more memory if the input is even bigger?

Sure have a look at https://github.com/usegalaxy-eu/infrastructure-playbook/blob/master/files/galaxy/tpv/tools.yml#L345


chore: use more specific version range for rxjs peer dependency

I might be wrong here, but to me the version range reads a little better/less ambiguous with a caret for each number. Trying to detangle a user having issues with mixed rxjs versions, and this one was reported as installing 6.x, so maybe this would help.

Thanks!
In case its relevant for your debugging: according to the semver calculator ^6.5 || 7 should include everything in the 7.x range as well, but guess package managers may interpret it differently.


Highlight current section of sidebar when scrolling

What feature would you like to have?
The sidebar I've designed contains a list of headings.
When you scroll past the heading, the sidebar highlight should change to show the current heading.
What problem will be solved by having the feature?
Makes it clear where you are, both on the page (with the sticky heading in content area), and on the sidebar (with hightlight).
Do you want to help making the feature?
We need to have a sidebar component first, before we can start work on this issue.
I'm designing the sidebar and the highlight in the sidebar, but @Belco90 needs to make the code changes to make the feature functional. 😄

Labeling this status:blocked as we need to have a static sidebar first.


Fix test warnings in NumPy 1.15

Chainer counterpart for https://github.com/cupy/cupy/pull/1755

Jenkins, test this please.

LGTM, waiting for CI finish.

Jenkins CI test (for commit ae290c968acc27d256f8edbebc150ff3b8362286, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

Jenkins, test this please.

Jenkins CI test (for commit ae290c968acc27d256f8edbebc150ff3b8362286, target branch master) succeeded!


Zeppelin-540: Notebook versioning control (git commit) from frontend notebook menu

What is this PR for?
This PR improves the front-end experience to use git versioning on notebooks.
Any community feedback is welcome.
What type of PR is it?
Improvement
Todos

[x] - front-end and back-end changes
[ ] - error propagation to front-end
[ ] - tests

Is there a relevant Jira issue?
ZEPPELIN-540
How should this be tested?

Uncomment GitNotebookRepo as a storage in /conf/zeppelin-site.xml
Start Zeppelin
Make changes to some notebook
Use git menu to commit
To check whether successfully committed, do git log in /notebooks folder

Screenshots (if appropriate)

Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

@khalidhuseynov Thanks for the contribution. I think the approach make sense, but the implementation need to be more generalized. We must not assume that user will use git notebook repo.
How about add one more interface to NotebookRepo?
public void checkpoint(String noteId, String checkPointName);

and let all notebookrepo implement this interface. This method can be invoked with proposed GUI.
Each different notebook storage implementation can implement checkpoint() for their own purpose. GitNotebookRepo use this method for making commit, for example.
What do you think?

@Leemoonsoo yes that makes it more flexible and makes sense, I'll address it soon.

guys you have some communication channel, I enjoyed the project and want to help

@maaark11 Thanks for the interest : )
Mailing list here http://zeppelin.incubator.apache.org/community.html are official communication channel. You can subscribe and post message to the mailing list for any question, suggestion, feedback, discussion, etc.

tests were added, ready for review

@Leemoonsoo yes exactly! I was going to change git related things, but also wanted to hear community on UI feedback.  Thanks for the feedback, will be addressed!

The code and screenshot has been updated. Currently the icon for version control was changed from git to file-code icon. However that's subject to change depending on the feedback. Other possible icons could be anchor, fork or any other suggested by community.

Thanks for addressing comment.
It's great improvement.
LGTM

Merge if there're no more discussions


performance very slow and error com.orientechnologies.orient.enterprise.channel.binary.OTokenSecurityException: missing session and token

Error executing request
com.orientechnologies.orient.enterprise.channel.binary.OTokenSecurityException: missing session and token
Storage URL="plocal:C:/IntelliSURF/bin/orientdb-community-2.2.0/databases/isc"
at com.orientechnologies.orient.server.network.protocol.binary.ONetworkProtocolBinary.solveSession(ONetworkProtocolBinary.java:268)
at com.orientechnologies.orient.server.network.protocol.binary.ONetworkProtocolBinary.onBeforeRequest(ONetworkProtocolBinary.java:215)
at com.orientechnologies.orient.server.network.protocol.binary.ONetworkProtocolBinary.execute(ONetworkProtocolBinary.java:173)
at com.orientechnologies.common.thread.OSoftThread.run(OSoftThread.java:77)
Error executing request

hi  @robfrank,
Are you running in distributed or stendalone server ?
Regards

Hi,
We are running as standalone.
Sent from my iPhone

On 4 Aug 2016, at 17:24, tglman<EMAIL_ADDRESS>wrote:
hi @robfrank,
Are you running in distributed or stendalone server ?
Regards
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Hi @kumarkshiva,
This message is due to some invalid session usually when you reboot the server, it has been fixed already in the hotfix 2.2.5, anyway we suggest to update to the last hotfix.
Regards

hi @kumarkshiva,
This kind of stack are printed in 2.0.0 when the server is reasterd, because the sessions are not there anymore, this is already fixed in 2.2.5, and an additional fix (also in distributed) is coming in 2.2.7, so can you upgrade to the next hotfix ?
Regards

hi @kumarkshiva,
Did you have chance to check the last hotfix ? is it solved for you?

hi,
most of this problem where fixed in  2.2.9 and 2.2.10, closing this.
Bye


.NET Core

Hi,
Are there any plans to support .NET Core and building the project with VS2017?
Thanks,
Gevik.

Yes, it's something I'm planning on doing once .NET Core 2.0 comes around.

Thank you :) Let me know if I can be of any help.

Hi,
Is there any update about it? I'm also thinking to work on this, if you're not already working on it.
Thanks,

This won’t be done by supporting .NET Core, it will be done by supporting .NET Standard 2.0 potentially in MicroLite 8


Should HTTPRequest's interceptResolution be public?

https://github.com/puppeteer/puppeteer/blob/07febca04b391893cfc872250e4391da142d4fe2/src/common/HTTPRequest.ts#L208
api.md makes it sound like it should be public, and I'd like to be able to use it so I can decide whether to act on a request or not, based on its resolution.

Fixed in #7813


Test running npm update to fix node-fetch vulnerability

No longer needed as this branch/PR was created to test the effects of updating all the packages using npm update.
Changes to main can be found here


Unable to run example project

After install from git (https://github.com/ngrx/platform), npm install, npm update, ng s --open. Node version 6.11.2
But full of errors like:

npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed
ERROR in H:/Data/GitHub/ngrx_platform/example-app/app/auth/auth.module.ts (7,31): Cannot find module '@ngrx/effects'
ERROR in H:/Data/GitHub/ngrx_platform/example-app/app/app.module.ts (11,45): Cannot find module '@ngrx/router-store'.
ERROR in H:/Data/GitHub/ngrx_platform/example-app/app/app.module.ts (12,37): Cannot find module '@ngrx/store-devtools'

But if I got package from github, run npm install and ng s --open, example application should run without errors, or not?
There is problem find any present (for Angular 4 (not Angular 2)) functional example project with ngrx/store.

This issue should be moved to the ngrx/platform repo as it directly relates to that repo. In order to run the example app you will need to run npm run example:start or yarn example:start if you install with yarn.

Ok, npm run example:start - helper - after installing yarn. Example project wanted some authorization. But I need functional ngrx/store example project for studying ngrx/store, not any various complication. On gitub page are informations about contributors, backers, sponosrs - but not about basic informations - this looks that everything will by problematic. Sorry I'm not so sweet as other - i know, a will have to find another solutions.

Just use 'test' as username. Password is empty


owncloud-client: 2.3.2 -> 2.3.3

Motivation for this change
Updated upstream version
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Applied to master (9fc87cc376427ab5a13ebb779452175c426f9f53) and cherry-picked to release-17.09 (c05c38296c15df4de46bc575c0f7348721986a76). Thanks!


owl_parse does not reload modified ontologies

owl_parse uses rdf_load internally.
For local files, the modified(-Modified) should be specified.
For remote files it might be possible as well to GET the modification time of the OWL file using HTTP protocol.
Modification time should also be included in the owl_file_loaded predicate (or remove this predicate, since rdf keeps track of loaded ontologies already!)

owl_parse is no more


[BUG]  Connectkit modal stuck on loading wallets from walletConnect on mobile

Describe the bug
Connect kit modal stuck on loading wallets from walletConnect. It seems like pagination is not working correctly and additional walletConnect modal is shown after exit.
To reproduce

Use chrome on mobile (used iphone 11 chrome)
Navigate to try it out demo
click on connect, click on other wallets

Expected behavior
All wallets from walletConnect are loaded and paginated, or walletConnect modal is shown after clicking on other wallets button
Screenshots
https://github.com/family/connectkit/assets/29612247/3502b95b-0a0e-4a1d-a802-a33677b4c719
Additional context
I have to click outside of the modal after bg gets a little big darker or on close button to see walletConnect modal.

Fixed in https://github.com/family/connectkit/commit/c77dc936ae35834a6c9a0628c4bd26cdff676197, will be pushed to npm soon 👍


Problems sorting images in job

Problems sorting images in job
As the question, I want the image order to be 1.jpg,2.jpg, 3.jpg when labelling in job ... , how should I achieve this?

Rename them as 01.jpg, 02.jpg, 03.jpg, ... Number of leading zeros depends on total count of files
Use predefined sorting method when create a task (manifest.jsonl must be provided within a list of files when creating a task)


Update documentation

Update docs to use NetworkManager and nmcli instead of wicked
Also remove mentions of AMI:s in releases since those are dropped in #1619
Signed-off-by: Fredrik Lönnegren<EMAIL_ADDRESS>

@juadk @ldevulder - do we have tests for such cloud-config scenarios ?


#14739 disable proceed if any page is not loaded

Disable Proceed button if any page is not loaded

This is definitely not correct. Task may be saved in PG wizards too. There are too many different workflows linked to this function.


Reuse Blake2b State

When doing Fouque Tibouchi hashing to G1 for bls12-381, the internal state for blake2b can be reused. The form it is being hashed as is blake2b(msg || G1_<specific tag>), so the state at blake2b(msg || G1_) can be reused. The relevant code is in https://github.com/Project-Arda/bgls/blob/hashing/curves/bls12_381.go.
This may require switching blake2b libraries, since the current library being used for blake2b doesn't support copying the state (to my knowledge).

I couldn't find an existing blake2b library which supported copying the state, so I added a clone method to a fork of the official golang crypto repository. https://github.com/ValarDragon/crypto/tree/master/blake2b
I also raised an issue for this here: https://github.com/golang/go/issues/24548
Regardless on the status of that issue, this repository should probably use the ValarDragon/crypto fork, since go has a long release cycle. (If the issue is resolved, then this should switch over to go's library once it updates)

I switched hash.go in branch hashing to using my fork. The library should switch over to whatever ends up being done in x/go/crypto once its resolved. (Relevant issue)

x/go/crypto merged the relevant change in this commit: https://github.com/golang/crypto/commit/12892e8c234f4fe6f6803f052061de9057903bb2, so this repository will switch to using that.


Warning in derived fields example

I get the following warning when running the examples in the 'derived fields' section of the docs:
>>> ds['stars']['VelMag']
/home/txwx36/.venv/scida/lib64/python3.11/site-packages/dask/array/core.py:3469: UserWarning: Passing an object to dask.array.from_array which is already a Dask collection. This can lead to unexpected behavior.

This issue is related to pint. For xarray they discussed the same issue of pint interplay with dask: https://github.com/xarray-contrib/pint-xarray/issues/116 and https://github.com/pydata/xarray/issues/5559. Short-term, I will add this warning to the FAQ and/or suppress error. Long-term, need to check how xarray fixed this in this PR: https://github.com/pydata/xarray/pull/5571

I adjusted the example to not produce this warning in #122


Provide official Docker image

I have been using this image for a while but it has several issues:

It's outdated
It's not tagged properly so I can't know the version
Is only available for AMD64 arch
Is huge ~150 MB

I have fixed all these issues for me but I don't have time to maintain the fork. Maybe you can configure a GitHub action for doing it automatically. Example of GitHub actions => https://github.com/ngosang/urbackup-exporter
Dockerfile
FROM golang:1.17.0-alpine3.14 AS builder

RUN apk --no-cache add git

ARG VERSION
RUN go get github.com/DRuggeri/alertmanager_gotify_bridge@$VERSION

FROM alpine:3.14
COPY --from=builder /go/bin/alertmanager_gotify_bridge /usr/bin/alertmanager_gotify_bridge

ENTRYPOINT ["/usr/bin/alertmanager_gotify_bridge"]

# docker build -t alertmanager_gotify_bridge:v0.5.2-custom --build-arg VERSION=v0.5.2 .

docker-compose
  alertmanager_gotify_bridge:
    image: alertmanager_gotify_bridge:v0.5.2-custom
    container_name: alertmanager_gotify_bridge
    environment:
      - GOTIFY_TOKEN=xxxxxxx
      - GOTIFY_ENDPOINT=http://gotify:80/message
    ports:
      - 8080:8080
    restart: unless-stopped

@ndragon798  maybe is interested in helping.

PR in #14
thanks to @ngosang for the inspiration :beers:

You bet! With the latest release, this should get pushed to the Docker registry now that y'all have helped!


Support more than two list types

I needed the functionality to be able to have more than two list types, this PR enables that whilst maintaining backwards compatibility with the previous two parameters, type_UL and type_OL.
Because the code needs to be transpiled it's actually kind of a pain to use a forked version of the lib. Hoping I can make this PR acceptable for merging, let me know thoughts or anything you'd like to see changed!

Thanks! That's nice that you found a way to keep backward compatibility. However, I prefer that we push a "major" (actually minor) version and have a simpler API. As long as slate itself is not released as stable, I think we should not fear to break backward compatibility, as long as it is reflected in the package versions.

Deployed in 0.7.0

Great! I'll give this a try, thanks so much 😄


Remove internal paths from test dependencies

Fixes microsoft/types-publisher#517

Now that DT is a pnpm monorepo, getTestDependencies is no more. Closing.


Fix remove datev2 signature of microsecond

Proposed changes
Issue Number: close #xxx
for sql
select microsecond(d) from dates; -- d is Date type

before:
ERROR 1105 (HY000): errCode = 2, detailMessage = [INTERNAL_ERROR]Function microsecond get failed, expr is VectorizedFnCall[microsecond](arguments=d,return=Nullable(Int32)) and return type is Nullable(Int32).

now: cast argument to Date and get result 0
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall


Cannot access heroku apps

I'm using python 3.4 and here's my code:
https://github.com/retphern/hoaxbot_data_test/blob/master/lightning_scatter.py
But when i run the code, i got error like this:

Lightning initialized
Problem connecting to server at https://lightning-viz-veda.herokuapp.com
status code: 401
Traceback (most recent call last):
File "lightning_scatter.py", line 7, in
lgn = Lightning(host='https://lightning-viz-veda.herokuapp.com')
File "/home/veda/Dev/hoaxbot_data_test/venv/lib/python3.4/site-packages/lightning/main.py", line 28, in init
raise ValueError("Could not access server")
ValueError: Could not access server

But i can access the apps through web fine.

I found that this problem happen when using auth, when i delete the auth var from heroku its working fine.


"undefined" as both title and message for all Toasts created

<head lang="en">
    <link href="node_modules/bootstrap/dist/css/bootstrap.min.css" rel="stylesheet">
    <link href="node_modules/bootstrap-icons/font/bootstrap-icons.css" rel="stylesheet">
    <link rel="stylesheet" href="node_modules/bootstrap-toaster/css/bootstrap-toaster.min.css" />
    <link rel="stylesheet" href="./style.css">

    <script src="node_modules/jquery/dist/jquery.min.js" type="application/javascript"></script>
    <script src="node_modules/bootstrap/dist/js/bootstrap.min.js" type="application/javascript"></script>
    <script src="node_modules/socket.io-client/dist/socket.io.min.js" type="application/javascript"></script>
</head>
<body>
    ...
    <script src="node_modules/bootstrap-toaster/js/bootstrap-toaster.min.js"></script>
    <script> window.onload = function() {
          Toast.create("Wow, that was easy!", "Just like that, this toast will appear on the page", TOAST_STATUS.SUCCESS, 5000);}
    </script>
</body>

I won't have my computer that I develop on with me for a while, so I can't be a great help, but what versions of Bootstrap and Bootstrap Toaster do you have installed?
Make sure to use 5.x if you are running Bootstrap 5, and if you're using Bootstrap 4, use 4.x.

Latest for both. Here is my package.json:
{
  "dependencies": {
    "bootstrap": "^5.0.2",
    "bootstrap-toaster": "^5.1.0-rc1",
    "jquery": "^3.6.0",
    "resumablejs": "^1.1.0",
    "socket.io-client": "^4.1.3"
  }
}

Changed bootstrap-toaster to an older version in my package.json, and reinstalled dependencies. Everything works now!
"bootstrap-toaster": "^5.0.0"

Glad you got it working! Yeah I’ve made a lot of changes in 5.1.0 so I haven’t officially released it yet


invoice: replace bech32 and bs58check packages

Fixes #217

Codecov Report
Base: 92.95% // Head: 92.93% // Decreases project coverage by -0.02% :warning:

Coverage data is based on head (d40175c) compared to base (f9a2f99).
Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head d40175c differs from pull request most recent head 6bf993d. Consider uploading reports for the commit 6bf993d to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #294      +/-   ##
==========================================
- Coverage   92.95%   92.93%   -0.02%
==========================================
  Files         232      232
  Lines        6245     6244       -1
  Branches      724      724
==========================================
- Hits         5805     5803       -2
  Misses        300      300
- Partials      140      141       +1

Impacted Files
Coverage Δ

packages/invoice/lib/decoder.ts
96.19% <100.00%> (ø)

packages/invoice/lib/encoder.ts
97.59% <100.00%> (ø)

packages/invoice/lib/invoice.ts
88.73% <100.00%> (-1.55%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Maestral is uploading the "selective sync conflict" folders back into Dropbox

Describe the bug
After #446 I am rebuilding the index.
Maestral is now uploading the "selective sync conflict" folders back to Dropbox.
To Reproduce
Have a "selective sync conflict" folder and rebuild the index
Expected behaviour
It should not upload it to Dropbox since the folder is already on Dropbox (I just forgot to select it in the preferences)

I have removed ~/.local/share/maestral and reinstalled maestral.
I re-selected the ex Dropbox folder, chose to merge, and made absolutely sure to select the exact same folders there are already there :)
Maestral is now like "2021-09-02 00:47:15 sync DEBUG: Equal content hashes for "[...]": no conflict" 8)

Maestral is now uploading the "selective sync conflict" folders back to Dropbox.

That is expected behaviour currently. It assumes that the local folder is different one from the folder on Dropbox servers, since you excluded the remote folder with selective sync, and that any similarities in name are only coincidental. The "selective sync conflicts" are therefore uploaded.

Maestral is now uploading the "selective sync conflict" folders back to Dropbox.

That is expected behaviour currently. It assumes that the local folder is different from the folder on Dropbox servers, since you excluded the remote folder with selective sync, and that any similarities in name are only coincidental. The "selective sync conflicts" are therefore uploaded.

Can we have that, if you select "Merge", it will auto-select the folders in local that are also in remote in the following screen?
So you don't forget anything :)

Can we have that, if you select "Merge", it will auto-select the folders in local that are also in remote in the following screen?

This would certainly be convenient, the difficulty would likely be in the implementation.
At the moment, all files and folders are selected for syncing by default, which is really easy to do. If we would automatically select folders which are present locally and uncheck folders which are only present remotely in the selective sync page of the setup dialog, this would require getting a full list of all remote folders (and files) first. At the moment, folders are loaded on-demand, when they are expanded in the GUI. Loading all remote items in advance could potentially be very slow, especially for users with > 100,000 items in their Dropbox.
A potential way around this would be to perform the check for top-level folders only (which are more commonly excluded from syncing). Do you think this would already be useful by itself? Otherwise, I'll need to think about possible solutions but don't have any immediate ideas.

Dunno, I also uncheck top-level folders that must stay on remote and not sync on local. But maybe someone else unchecks subfolders or sub-sub-folders.
Maybe, if it's not possible to fetch the all the remote folder list, a warning that tells the user to select all the folders he already has in local.
Or an option to choose between fetching all the remote folders and select automatically, or let the user select them (with a warning that fetching all the remote list could take a long time)


How to make the height adaptive to the content instead of specifying the Extent

How to make the height adaptive to the content instead of specifying the Extent

Hi @itMcdull,
You can use Extent.proportional:
DraggableSheet(
    // Set the minimum and initial extent (the visible height of the sheet) to 50% of the content height.
    minExtent: const Extent.proportional(0.5),
    initialExtent: const Extent.proportional(0.5),
    ...,
);

@fujidaiti What needs to be done to have a dynamically growing sheet? E.g. the sheet contains a Column with a Stateful widget as first element, let's say a Text box which may have either 2 or 3 lines. The second element of the column is a button.
Initially the sheet is rendered with 2 lines of text with maxExtent and initialExtent of Èxtent.proportional(1), so the button is perfectly aligned with the bottom of the screen.
After a few seconds the text box widget updates the state and has now 3 lines of text. But that leads to the situation that all content below the text box is pushed down, so the button is clipped by the bottom screen edge (absolut extent stays the same but proportional extent is now something like 0.9...)
I would rather have the sheet growing upwards, keeping the button completely visible, means the proportional extent should stay at 1 (absolute extent would increase by the height of the text line height).
Here's a minimal example of the situation:
DraggableSheet(
  controller: sheetController,
  minExtent: Extent.pixels(100.0),
  child: SheetContentScaffold(
    appBar: SomeHeaderWidget(),
    body: Padding(
      padding: EdgeInsets.symmetric(horizontal: 24),
      child: Column(
        mainAxisSize: MainAxisSize.min,
        children: [
          SizedBox(height: 12),
          SomeStatefulTextBox(),
          SizedBox(height: 12),
          SomeActionButton(),
        ],
      ),
    ),
  ),
);

Hi @codeOfJannik,
Thank you for reporting the bug. I've transferred it to issue #226, as it is not related to this issue.
Please follow #226 for any upcoming updates.


getting-started/jwk: fix json-web-key-generator version

I have not found an ideal way of handling this so that we don't need to update this page when there is a new version of JWKS but I find handy to be able to copy/paste what is in the documentation so I propose to update this page.


Pulseaudio (sound) in Firefox

Hey,
I am a real fan of your docker releases. U create exactly what I need :) but I am still not good enough to create my own stuf.
Do you think, it is possible to add sound in your Firefox too?
I found the following interesting links but its to hard for me to do it by myself.
docker-pulseaudio-example
tor-browser with uplseaudio
that would be great

Thanks for your suggestion!  I will look at it  to see what can be done.

Fixed in version 1.3.0!
See https://github.com/jlesage/docker-firefox#sound-support


Support source_relative for go_package option

--go_out supports a paths flag that takes an option called source_relative which prevents the go_package option from being mapped to a directory. This is important with Go Modules since there's no GOPATH. See https://github.com/golang/protobuf#packages-and-input-paths

Righto, this is fixed in #126 (just merged today).


Cross post MP blog on Micro releases

As discussed in the architecture call yesterday [1] I've created a blog post [2] explaining micro releases of MP specifications. Can this be posted also in the MP blog, please?
[1] https://docs.google.com/document/d/1uAKRymdAL5Wj1KADzrYKZzSnAFsq74lBfj8lxKQnI6I/edit#heading=h.60vspycf6uhr
[2] https://xstefank.io/2019/10/09/minor-patch-releases-in-microprofile/

@xstefank Martin,
Perfect opportunity for you to become the newest MP wordpress contributor.
click Call to Action: Become a MicroProfile Author
Of course, while at it, you are MOST welcomed to make the current guidelines better, efficient, clearer by submitting PRs against it as you see fit. :) Super fun!

@aeiras thanks for the pointers. I've created #210. Should I close this issue? Can I also ask where I can find bigger MP logo images, please?

@xstefank, using above follow up let me reply by sections:
I've created #210. fantastic!
Should I close this issue? **yes, this issue is no informative :) **
Can I also ask where I can find bigger MP logo images, please? **if you mean MP logos, go to the MP drive: MP drive choose DESIGN folder
If incorrect, please clarify. cheers

Found everything I needed :) Thanks @aeiras!


Higllight search result in the location/s and/or positioning the cursor on the searched text

Describe the feature you'd like
After performing any search, the results are shown at the top of the page.
However, by clicking on the result (for example, a page), you go to the specific content, but it's necessary to use the browser search to view the exact query (word/s).
I suggest improving the search feature by positioning the cursor on the exact searched text and highlighting it after clicking on a search result.
Describe the benefits this would bring to existing BookStack users
The user can Immediately view the searched text.
Can the goal of this request already be achieved via other means?
Yes, by using the browser search, but it's a waste of time, it's not convenient, and it should be a function of the app anyway.
Have you searched for an existing open/closed issue?

[X] I have searched for existing issues, and none cover my fundamental request

How long have you been using BookStack?
Under 3 months
Additional context
No response

Thanks for the request @nicfab but I feel this is already covered by #4263 so I'm going to therefore close this off.


Create chat group

Added a dialog that will create a new chat group and add it to the Group chat view
You currently must use the Quickblox user ids seperated by commas (i.e. (80001,90001,10001) to add users until we implement the contacts sheet selection

+1


alternative blending algorithms

very cool project. it inspired me to experiment with different blending algorithms. i created something similar in p5.js, have a look here.
in one version i just calculate a coefficient (1 / distance)^power for each point at each pixel and the resulting color is a sum of point_color * normalize(point_coeff). normalize prevents the sum of coefficients from being greater than 1.
in the second version the resulting color is something like a sum of point_color * normalize(sum_of_coeffs - point_coeff). you can drag points, pick a color by clicking anywhere (the output is in the console) and add a new point by double-clicking.
one-over:

subtract:

i tried to model the transitions in geogebra but they don't behave exactly like i expected them to: https://www.geogebra.org/3d/wws3s4yh

You version is gorgeous and the geogebra visualization is super interesting!
I'll try some variations on the blending method and the color space some day. It seems I'll have to abandon the WebGL implementation and its triangles-based blending at some point...

thanks! here's a cool effect i managed to recreate (-ish). i think this was the one-over version, it creates these sharp edges when you move the slider to the right and the distance between two source points is small.

also made me think of this https://meshgradient.com/

WOW! it's so cool. do you have any idea how it works? i can't find anything about their algorithm but i saw that photoshop has a similar tool.

no idea unfortunately. the shadertoy link is que cool


Bug: undefined parameters number in project tokens/

Run:
cd tokens/
truffle test
Detect errors

Contract: ERC1155Rarible
mint and transfer by minter, token create by Factory:
Error: Invalid number of parameters for "undefined". Got 1 expected 3!
at Context. (test/erc-1155/ERC1155Rarible.test.js:29:39)
at runMicrotasks ()
at processTicksAndRejections (internal/process/task_queues.js:97:5)

Contract: ERC721Rarible
mint and transfer by minter, and token created by ERC721Factory :
Error: Invalid number of parameters for "undefined". Got 1 expected 3!
at Context. (test/erc-721/Rarible.test.js:36:38)
at runMicrotasks ()
at processTicksAndRejections (internal/process/task_queues.js:97:5)

https://github.com/rarible/protocol-contracts/pull/50/commits/eb4bf500a9053d56ceb3c0a30ba6cea4169a838f
DONE

Close, because done


Jumpscale 9 installation scripts should all have proper error handling

Each statement needs to be validated for its success.

what does this mean?
what do we want

We should check that we always die on errors and we don't have a falsely successful installation

Just checked with @maxux . Developer/js_builder_base9.sh uses catcherror function "relatively new" that sets trap on ERR to log/exit


Segmentation issue from the PDF parsing (missing space)

In the bibliographical reference part of this PLOS PDF, pdf2xml and pdfalto miss the space between DOI and PMID, which result in an unfortunate DOI concatenated with PMID.
Raw sequence as input for GROBID via pdf2xml and pdfalto is:
https: //doi.org/10.1128/JVI.02080-08PMID: 19439468

A cut and paste with Ubuntu's Document Viewer from the original PDF actually detects an end of line between the doi and PMID in the PDF stream.
malaria.pdf

@Aazhar could you have a look maybe to support that in pdfalo ?


[SPARK] fix custom environment variables facet

Problem
Custom environment facet behaviour is non-deterministic: it's present in some case and it's not available when working on delta tables in Spark (https://openlineage.slack.com/archives/C01CK9T7HKR/p1689155719105569). This is weird as the facet and delta format have nothin in common.
However they do, as  CustomEnvironmentFacetBuilder has been implemented to be triggered SparkListenerJobStart. We do have two types of start events: SparkListenerJobStart and SparkListenerSQLExecutionStart and Openlineage event is only sent for one of them. It seems as other event type got triggered with delta tables.
Solution

Prepare an integration test to verify facet is there.
Fix CustomEnvironmentFacetBuilder class.

Note: All schema changes require discussion. Please link the issue for context.

[ ] Your change modifies the core OpenLineage model
[ ] Your change modifies one or more OpenLineage facets

If you're contributing a new integration, please specify the scope of the integration and how/where it has been tested (e.g., Apache Spark integration supports S3 and GCS filesystem operations, tested with AWS EMR).
One-line summary:
Checklist

[ ] You've signed-off your work
[ ] Your pull request title follows our guidelines
[ ] Your changes are accompanied by tests (if relevant)
[ ] Your change contains a small diff and is self-contained
[ ] You've updated any relevant documentation (if relevant)
[ ] Your comment includes a one-liner for the changelog about the specific purpose of the change (if necessary)
[ ] You've versioned the core OpenLineage model or facets according to SchemaVer (if relevant)
[ ] You've added a header to source files (if relevant)

SPDX-License-Identifier: Apache-2.0
Copyright 2018-2023 contributors to the OpenLineage project

Codecov Report

Merging #1973 (6e9c30b) into main (bc1f525) will decrease coverage by 18.56%.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@              Coverage Diff              @@
##               main    #1973       +/-   ##
=============================================
- Coverage     81.68%   63.13%   -18.56%
  Complexity      109      109
=============================================
  Files            88       29       -59
  Lines          3681      415     -3266
  Branches         29       29
=============================================
- Hits           3007      262     -2745
+ Misses          638      117      -521
  Partials         36       36

see 59 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Running Containers with Swarm uses environment variables of the client machine, not the host node where the container is deployed

When we use Docker Swarm to deploy containers, it uses the environment variables from the machine that the client is run on, not the node to which it is being deployed.
Example:
A 3 node swarm cluster with manager on node1 and $DBNAME environment variable set
If this is run on a Dev PC:
> DOCKER_HOST=node1:4000 docker run image cmd db_name=$DBNAME
and the $DBNAME variable does not exist on the Dev PC, the $DBNAME variable is passed empty.
It would be great if the environment variables of the host node to which the container is being deployed is used instead.

highly important - is there a way to workaround?
this is related to:
https://github.com/docker/swarm/issues/1106

Closing due to lack of activity. Please reopen if you wish to continue discussing it.


Fix canvas image rendering for non-FF browsers

See: https://developer.mozilla.org/en-US/docs/Web/CSS/image-rendering

Fixed by 5a8dcb2fc715fc5f0bff1

Fixed by 5a8dcb2fc715fc5f0bff1


How to use it with *ngFor?

I have a list of images in my project which is been displaying with *ngFor, like this:
<div  *ngFor="let img of imgs">
       <img width="100%" [src]="img.url">
</div>

I've tried to include ng-simple-slideshow as shown below, but it displays an error:
<div *ngFor="let img of imgs">
    <slideshow [autoPlay]="false" [imageUrls]="img.url"></slideshow>
 </div>

The error:
URIError: Failed to decode param '/%'
    at decodeURIComponent (<anonymous>)
    at decode_param (\node_modules\express\lib\router\layer.js:172:12)
    at Layer.match (\node_modules\express\lib\router\layer.js:123:27)
    at matchLayer (\node_modules\express\lib\router\index.js:574:18)
    at next (\node_modules\express\lib\router\index.js:220:15)
    at expressInit (\node_modules\express\lib\middleware\init.js:40:5)
    at Layer.handle [as handle_request] (\node_modules\express\lib\router\layer.js:95:5)
    at trim_prefix (\node_modules\express\lib\router\index.js:317:13)
    at \node_modules\express\lib\router\index.js:284:7
    at Function.process_params (\node_modules\express\lib\router\index.js:335:12)
    at next (\node_modules\express\lib\router\index.js:275:10)
    at query (\node_modules\express\lib\middleware\query.js:45:5)
    at Layer.handle [as handle_request] (\node_modules\express\lib\router\layer.js:95:5)
    at trim_prefix (\node_modules\express\lib\router\index.js:317:13)
    at \node_modules\express\lib\router\index.js:284:7
    at Function.process_params (\node_modules\express\lib\router\index.js:335:12)

How can I implement ng-simple-slideshow in this case?

@atoyansk you just put the array of images as the imageUrls, using ngFor with a slideshow for each image is going to cause trouble for sure.


List out key features, esp. in comparison to similar tools

Features:

Public key based auth
No assumptions about directory structure (configure dockerfile path)
Rollout deployments in any namespace
Easy to fork and customise
Super easy to use and configure

You could add #27, Helm Apps, which falls into the same category... Ease of use.

Key features have been listed in https://github.com/hasura/gitkube/tree/master#features . Keeping this issue open for further addition of comparisons with other tools, etc


fix: types

Summary

Fix invalid type exports.　Those re-exports should have been done from v20221101, not v20220901.

@CodiumAI-Agent /review

PR Analysis

🎯 Main theme: Fixing type exports
📝 PR summary: This PR fixes invalid type exports in the TypeScript code. The types were previously exported from v20220901, but they should have been exported from v20221101.
📌 Type of PR: Bug fix
🧪 Relevant tests added: No
⏱ Estimated effort to review [1-5]: 1, because the changes are straightforward and involve only the correction of the version from which the types are exported.
🔒 Security concerns: No security concerns found

PR Feedback
💡 General suggestions: The PR is straightforward and fixes the issue as described. However, it would be beneficial to add tests to ensure the correct types are being exported.

 ✨ Usage guide:
Overview:
The review tool scans the PR code changes, and generates a PR review. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:
/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:
[pr_reviewer]
some_config1=...
some_config2=...

  Utilizing extra instructions
The review tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project.
Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize.
Examples for extra instructions:
[pr_reviewer] # /review #
extra_instructions="""
In the code feedback section, emphasize the following:
- Does the code logic cover relevant edge cases?
- Is the code logic clear and easy to understand?
- Is the code logic efficient?
...
"""

Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

  How to enable\disable automation

When you first install PR-Agent app, the default mode for the review tool is:

pr_commands = ["/review", ...]

meaning the review tool will run automatically on every PR, with the default configuration.
Edit this field to enable/disable the tool, or to change the used configurations

  About the 'Code feedback' section
The review tool provides several type of feedbacks, one of them is code suggestions.
If you are interested only in the code suggestions, it is recommended to use the improve feature instead, since it dedicated only to code suggestions, and usually gives better results.
Use the review tool if you want to get a more comprehensive feedback, which includes code suggestions as well.

  Auto-labels
The review tool can auto-generate two specific types of labels for a PR:

a possible security issue label, that detects possible security issues (enable_review_labels_security flag)
a Review effort [1-5]: x label, where x is the estimated effort to review the PR (enable_review_labels_effort flag)

  Extra sub-tools
The review tool provides a collection of possible feedbacks about a PR.
It is recommended to review the possible options, and choose the ones relevant for your use case.
Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example:
require_score_review, require_soc2_review, enable_review_labels_effort, and more.

  More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs 💎: Generate docstring for new components introduced in the PR.
/generate_labels 💎: Generate labels for the PR based on the PR's contents.
/analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the review usage page for a comprehensive guide on using this tool.

Persistent review updated to latest commit https://github.com/KEN-ALL/kenall-js/commit/415b97d587960f1e93ce8d40bad74ac7c49dc0cb


[query] Translate ConjoiningClauses to SQL

We're at the point of constructing a simple in-memory algebrized representation of a parsed query.
The next phase is to translate that into SQL for execution by SQLite.
In ClojureScript this was trivial, because we used Honeysql expressions directly in our algebrized form:
(defn cc->partial-subquery
  "Build part of a honeysql query map from a CC: the `:select`, `:from`, and
  `:where` parts.
  This allows for reuse both in top-level query generation and also for
  subqueries and NOT EXISTS clauses."
  [select cc]
  (merge
    {:select select
     :from (:from cc)}
    (when-not (empty? (:ctes cc))
      {:with (:ctes cc)})
    (when-not (empty? (:wheres cc))
      {:where (cons :and (:wheres cc))})))

Fixing this issue either requires addressing #273 or figuring out some ad hoc method, ideally better than concatenating contiguous strings.

This is next on my list.
The rough outline of steps I plan to take:

Define a type representing a (sub)query. Inner joins, wheres, and ON.
Implement a query builder abstraction.
Define a trait or three representing the transformation from a domain concept to (parameterized) SQL text.
Implement this trait for the Equals* types (a la ToSql) and SubQuery.
Build a subquery from a CC.
Write a subquery into a query builder on demand.

This is done.


Also fix hasing for gas_interface.py in GalactICs

Same change Inti made to in 2b632905775c67f04f369b8183a12b0b8dae30f9 for GalactICs interface.py to fix hashing in Python 3, now also in gas_interface.py.

oops, forgot about this, thanks!


Upload simple binning suite

Run farm_simple to produce results, compile results with make_list, and produce plots with render plots. Adjust config as needed
I'll need to update the code that I've written for consistency with the rest of ugali

Great, thanks @SidneyMau. @bechtol, you might be interested in this.

@SidneyMau I think that in your original proposal you were suggesting moving the simple binner code to ugali/simple from ugali/scratch/simple. (Note, the repository is also named ugali so most code is actually located in ugali/ugali.) The files that you committed would be located at top-level under simple  Was this your intension? Also, to maintain the history of the original simple binner files, it would be better to start with a git mv of ugali/scratch/simple to ugali/simple and then to overwrite the moved files with your new changes. This would serve a few purposes: 1) it would allow git to link the history of the simple files with the ones that Keith committed originally, 2) it would remove the vestigial ugali/scratch/simple directory. (Be careful to move your new files to a safe place before doing this so you don't delete them by accident.)

@kadrlica you're right, that was an oversight on my part. I'll try and redo the changes as suggested.

I could try to adapt compile_results_v3.py for newer searches, but I think it's fairly list specific, so that might warrant another .csv file to load in some known candidates. I never used it for any of the recent searches as it seemed to be redundant with some other parts of the search/association code. I figured we could leave it in the extra (or some other name) folder for now, and if we feel we need to for BLISS/MagLiteS/etc..., then I could adapt it for those purposes.

Sounds good to me.


Taking error in comand-> gem install releasy

#extconf failure: need zlib
D:\Windows\system32>gem install releasy
Temporarily enhancing PATH to include DevKit...
Building native extensions.  This could take a while...
ERROR:  Error installing releasy:
        ERROR: Failed to build gem native extension.

    D:/RailsInstaller/Ruby2.1.0/bin/ruby.exe extconf.rb
checking for socket() in -lsocket... no
checking for gethostbyname() in -lnsl... no
checking for atan() in -lm... yes
checking for inflate() in -lz... no
checking for inflate() in -lzlib... no
checking for inflate() in -lzlib1... no
checking for inflate() in -llibz... no
*** extconf.rb failed ***
Could not create Makefile due to some reason, probably lack of necessary
libraries and/or headers.  Check the mkmf.log file for more details.  You may
need configuration options.

Provided configuration options:
        --with-opt-dir
        --without-opt-dir
        --with-opt-include
        --without-opt-include=${opt-dir}/include
        --with-opt-lib
        --without-opt-lib=${opt-dir}/lib
        --with-make-prog
        --without-make-prog
        --srcdir=.
        --curdir
        --ruby=D:/RailsInstaller/Ruby2.1.0/bin/ruby
        --with-iconv-dir
        --without-iconv-dir
        --with-iconv-include
        --without-iconv-include=${iconv-dir}/include
        --with-iconv-lib
        --without-iconv-lib=${iconv-dir}/lib
        --with-zlib-dir
        --without-zlib-dir
        --with-zlib-include
        --without-zlib-include=${zlib-dir}/include
        --with-zlib-lib
        --without-zlib-lib=${zlib-dir}/lib
        --with-socketlib
        --without-socketlib
        --with-nsllib
        --without-nsllib
        --with-mlib
        --without-mlib
        --with-zlib
        --without-zlib
        --with-zliblib
        --without-zliblib
        --with-zlib1lib
        --without-zlib1lib
        --with-libzlib
        --without-libzlib
 extconf failure: need zlib

extconf failed, exit code 1

Gem files will remain installed in D:/RailsInstaller/Ruby2.1.0/lib/ruby/gems/2.1
.0/gems/libxml-ruby-2.8.0 for inspection.
Results logged to D:/RailsInstaller/Ruby2.1.0/lib/ruby/gems/2.1.0/extensions/x86
-mingw32/2.1.0/libxml-ruby-2.8.0/gem_make.out

D:\Windows\system32>

Please help me!

That looks a lot like a problem entirely separate to Releasy - that is a problem with libxml-ruby-2.8.0, so I would suggest you approach the devs in that project. I largely left Releasy to its own devices in the end days of Ruby 1.9.3, so it hasn't been fully tested with newer versions of Ruby...

ok, i understand : /, appreciated by the attention .


Design and Mock-ups

I will be working on some concept design for the web-site. Its gunna go for a solid clean simple look.

@afixoftrix what sketch tool will you be using?

@spences10 I will be using pen, paper, photoshop and gravit designer.

Here is the landing page prototype. The Red section is your generic landing page. We can brainstorm about the nature of graphics to be put there. The next section shows the user surrounding open facilities. There is an option to switch to individuals. The next part is the blue part. Thats completely open to suggestions. We can add more pannels. Will be working on the Dashboards next.
Color Scheme is also subject to change. If you want you can go to coolors and then create a palette of colors you will like. I will try and incorporate them into a prototype.


Error in density.default(phe[, i]) : 'x' contains missing values

Hi,
I am receiving the following error:

Error in density.default(phe[, i]) : 'x' contains missing values

There is no blank data, and all missing values are NA.
If anyone can help, it would be greatly appreciated.

Hi,
This bug seems to happen using old version of MVP, so please update your MVP and then have a try. if it still exist, please don't hesitate to contact us.
Best!

Hi,
I updated MVP and am still getting the same error

Sorry for that, if possible, would you please send your phenotype file to me with the email(ylilin@163.com)? I will dubug MVP with your file and update it.
Thanks!

Hi YinLiLin,
The problem was resolved after downloading a newer version of R.
Thanks for your help.


Display a time frame smaller than 24 hours

Is it possible to display a time frame in the time grid which is smaller than 24 hours?
For: e.q.: I want to display a time frame: from 08:00- 18:00 instead of 01:00 - 23:00 how it is by default

@Vukajlovic
You can specify the time range for the weekly view.
When creating a calendar instance, you can specify a range time as week.hourStart and week.hourEnd in the options.
const cal = new Calendar(el, {
    defaultView: 'week',
    scheduleView: true,
   ...
    week: {
        hourStart: 7,
        hourEnd: 19
    }
});

Thank you, it worked!


Use NextJS

Use NextJS instead of plain React
Advantage: can easily add API endpoints

For the purpose of this demo I don't think we're going to get opinionated about frameworks; happy for you to maintain a fork though. :)


fix: major bug fixes where extension is not working in linux and mac

:tada: This PR is included in version 1.4.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Missing classes detected while running R8

Building on new Flutter and dart I get R8 Build error.
Versions are here:
# build.gradle
dependencies {
    implementation "com.google.android.material:material:1.9.0"
    implementation platform('com.google.firebase:firebase-bom:32.3.1')
    implementation 'com.google.firebase:firebase-analytics-ktx'
    implementation 'com.android.support:multidex:2.0.1'
    implementation 'com.google.android.gms:play-services-auth:21.2.0'
}

# settings.gradle
plugins {
    id "dev.flutter.flutter-plugin-loader" version "1.0.0"
    id "com.android.application" version "8.1.1" apply false
    id "org.jetbrains.kotlin.android" version "1.9.10" apply false
    id "com.google.gms.google-services" version "4.4.2" apply false
    id "com.google.firebase.crashlytics" version "2.9.9" apply false
}

> flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, 3.24.3, on Microsoft Windows [Version 10.0.22631.3880], locale hr-HR)
[√] Windows Version (Installed version of Windows is version 10 or higher)
[√] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[√] Chrome - develop for the web
[!] Android Studio (version 2022.3)
    X Unable to find bundled Java version.
[√] Android Studio (version 2023.3)
[√] IntelliJ IDEA Ultimate Edition (version 2024.1)
[√] Connected device (2 available)
[√] Network resources

! Doctor found issues in 1 category.

Build error
> flutter build apk  --release --target-platform android-arm,android-arm64,android-x64 --split-per-abi

Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Font asset "CupertinoIcons.ttf" was tree-shaken, reducing it from 257628 to 1268 bytes (99.5% reduction). Tree-shaking can be disabled by providing the --no-tree-shake-icons flag when building your app.
Font asset "MaterialIcons-Regular.otf" was tree-shaken, reducing it from 1645184 to 7088 bytes (99.6% reduction). Tree-shaking can be disabled by providing the --no-tree-shake-icons flag when building your app.
ERROR: Missing classes detected while running R8. Please add the missing classes or apply additional keep rules that are generated in C:\********\build\app\outputs\mapping\release\missing_rules.txt.
ERROR: R8: Missing class com.google.android.gms.auth.api.credentials.Credential (referenced from: boolean com.shivam.otp_pin_field.OtpPinFieldPlugin$activityResultListener$1.onActivityResult(int, int, android.content.Intent))
Missing class com.google.android.gms.auth.api.credentials.CredentialsApi (referenced from: void com.shivam.otp_pin_field.OtpPinFieldPlugin.requestHint())
Missing class com.google.android.gms.auth.api.credentials.HintRequest$Builder (referenced from: void com.shivam.otp_pin_field.OtpPinFieldPlugin.requestHint())
Missing class com.google.android.gms.auth.api.credentials.HintRequest (referenced from: void com.shivam.otp_pin_field.OtpPinFieldPlugin.requestHint())

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:minifyReleaseWithR8'.
> A failure occurred while executing com.android.build.gradle.internal.tasks.R8Task$R8Runnable
   > Compilation failed to complete

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 45s
Running Gradle task 'assembleRelease'...                           45,7s
Gradle task assembleRelease failed with exit code 1

Hi @mzuzic-maidea ,
Thank you for reporting the issue!
The R8 build error you're encountering is due to some missing classes related to com.google.android.gms.auth.api.credentials in the OtpPinFieldPlugin. This issue likely stems from the ProGuard/R8 configuration that is stripping out required classes during the build process.
Potential Fixes:

Add ProGuard Keep Rules:
You may need to add the missing keep rules for the classes being stripped out. You can find those missing rules in the path mentioned in the error: C:\********\build\app\outputs\mapping\release\missing_rules.txt.
Try adding the following rules to your proguard-rules.pro file:
-keep class com.google.android.gms.auth.api.credentials.** { *; }
-keep class com.google.android.gms.auth.api.credentials.CredentialsApi { *; }
-keep class com.google.android.gms.auth.api.credentials.HintRequest$Builder { *; }
-keep class com.google.android.gms.auth.api.credentials.HintRequest { *; }

Update Google Play Services Auth Library:
Ensure that you are using the latest version of the play-services-auth library. Sometimes build issues can be caused by compatibility problems with older versions. Try updating your build.gradle to use the latest version:
implementation 'com.google.android.gms:play-services-auth:21.3.0'

Check Your Multidex Configuration:
You are using multidex. Make sure it's properly configured in your build.gradle file:
android {
    defaultConfig {
        multiDexEnabled true
    }
}

Run with Debug Options:
If the above steps don’t resolve the issue, you can try running the build with --stacktrace, --info, or --debug for more detailed logs to further investigate the issue.

Let me know if these steps help resolve the issue or if you need further assistance!
Best regards

Hi @mzuzic-maidea ,
We are closing this ticket as the "Missing classes detected while running R8" issue is not related directly to the otp_pin_field package itself but is due to missing ProGuard or R8 rules for the required Google Play services libraries in your project.
Reason for Closing:
This issue occurs because certain classes related to com.google.android.gms.auth.api.credentials (used for SMS hint requests) are being stripped during the minification process with R8. To resolve this, you need to include the correct ProGuard rules in your project configuration to retain these classes. You can add the following rules in your proguard-rules.pro file:
-keep class com.google.android.gms.auth.api.credentials.** { *; }

This will prevent R8 from stripping out the necessary classes and should resolve the issue in your project.
Since the problem stems from the project’s configuration and not from the package itself, we’ll be closing this issue. Feel free to reopen it if you encounter any package-related problems, and thank you for your understanding!
Best regards


Added test cases: division by zero

Added 6 new test cases with division by zero
@yegor256 please, take a look

@APotyomkin thanks!


Revert "jwt_authn: Add logic to refetch JWT on KID mismatch (#36458)"

Commit Message: Revert "jwt_authn: Add logic to refetch JWT on KID mismatch (#36458)"
Additional Description:
To resolve the frequent jwt flake. See https://github.com/envoyproxy/envoy/issues/37720.
It's merged recently and the implementation of that feature has obvious thread-safty problem and lifetime problem. So, reverted it.
Risk Level: low.
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

cc @adisuissa @tyxia

cc @arulthileeban


[BUG]: popular product , product , card these are some functionality is not working

Issue Report
Title
Bug : some functionality is not working related to product
Description
popular product , product , card these are some functionality is not working which needs to be fixed before implementing payment getway
Steps to Reproduce the Issue
To assist us in understanding and resolving the issue, please outline the steps you took that led to the problem:

Action 1: Debugging entire project
Action 2: Understanding changes to fix bug without changing the new code
Action 3: Fixing bug only without compromising new code

Expected Behavior
https://github.com/user-attachments/assets/73efcdfa-1171-450e-8dd8-67a0f4891fd9
Actual Behavior

@thakuratul2 @saurabhbakolia Sir, I would like to work on this this needs to be fixed before I implement payment gateway. I was waiting for this to be fixed as we discussed earlier but it seems no one is working on this so I've to fix this. payment gateway code is already written and saved in other folder once I fix this issue I'll integrate payment gateway in no time.


VS402362: No process template with type  was found

I have created a private template based on a current project in a different organisation but on trying to create a project using the template I get this error … any suggestions.

@Castle1979 It is possible to encounter an issue where the process template Ids differ in the source and target organizations. This may occur if you exported a project that belongs to a custom or inherited process in the source organization. To ensure proper mapping in the target organization, Azure DevOps Demo Generator requires the same process template to be used.


Feature request: Support non-HTML output

Summary
I'd like to output a set of non-HTML data, for example maybe JSON data that would be available to be used in client-side code. I see that there is a Client API (https://gridsome.org/docs/client-api#using-in-srcmainjs) and in theory I could use that, but I'm not sure it would cover all cases.
My main use case is that I'd like to create a JSON file that contains a list of all the pages on the site to see if I can build a Gridsome/Lunr demo. In theory I could do all the setup in main.js, but I'd like to use my own JS in static and point it to a local file supplying the JSON data, if that makes sense.
Basic example
Honestly not sure how it would work. ;)
Motivation
I do think it's a valid use case for a SSG to be able to generate non-HTML files in general, so I'd like to see Gridsome support this even if a solution via main.js would work.

You can try to use the api.afterBuild() hook to generate a JSON file with all pages. Take a look at how the @gridsome/plugin-sitemap plugin uses it to generate a sitemap from all rendered pages.

Query - what is the API format for that method? The docs don't say what arguments are passed to it.

Unfortunately this isn't quite enough. I can get a list of pages for my site, but I can't get access to the content generated. I mean I do see the path of the generated HTML, but if I want to get the rendered content from just the page, and not the layout, that doesn't seem to be available.
So for example, for Lunr to work I need to provide the page content in a JSON file.


update：error: 'kEmptyString' is not a member of 'google::protobuf::internal'

update：error: 'kEmptyString' is not a member of 'google::protobuf::internal'

难道是脚本里源PB的版本不对？

how to fix it many thanks


Add jacoco config to collect coverage metrics

@sshepel any idea why it's not pulling in opencv from maven here? I have no special settings.xml locally but I can build the code for windows. https://jenkins.konduit.ai/blue/organizations/jenkins/konduitai%2Fkonduit-serving/detail/PR-262/11/pipeline#step-110-log-720

Hm, let me check...


Quiet mode on all tabs

Playing a game sets quiet mode to true, but it doesn't propagate that information to all other open tabs. It should!
Also, maybe add a manual button/menu for quiet mode.

see https://github.com/lichess-org/lila/issues/13380

Test if replacing the quietMode field on the lichess object with a set/get property works.

Implemented in v2.1.14


Deploy latest version

Deploy latest POS version to get ready for Balancer

On hacknet also.

We'll consider this closed as it's not tied to anything.


Alternating table/datagrid row colors

Select one ...  (check one with "x")
[ ] bug
[ X] feature request
[ ] enhancement

Expected behavior
Rows in either Tables or Datagrids alternate in colors. Helps to differentiate the rows visually. I'd also like to see a slightly darker shade in table header to offset it from the rows. See screen mockup for alternating row colors look.
Environment details

Angular version: 2.0.X

Clarity version:

OS and version:

Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Thanks for the suggestion, @beaker1977. I will forward this to our UX team for consideration.

We won't be creating this feature. The row lines act as visual separators and are sufficient for the visibility of differentiating data.


strings that are invalid SQL variable names cause errors when passed to pyorient.ogm.Batch.setitem()

Currently (as of 4474709), passing variables containing characters such as hyphens (e.g., 'TX-1') to Batch.__setitem__() when adding nodes/edges to the batch will cause an SQL error during batch execution because the resulting variable names ('$TX-1' in this case) are invalid. At the least, it would be desirable for the method to raise an exception if such strings are passed to it. More sophisticated handling could ensure that all strings specified are encoded to valid SQL variable names.

Hi @lebedov,
In testing, I found that it is possible to have hyphens in variable names, so long as you either

Use them only as a return value
Don't use them (...which defeats their purpose).

While I like the idea of warning as early as possible (in setitem), I thought it more important to be as faithful as possible to what OrientDB allows, so I've made getitem raise an exception instead.
That is the default behaviour. Calling the classmethod Batch.use_name_cleaner() allows you to provide a function that will return a valid equivalent of the input string. When this is not None (a basic default is provided), these sanitised inputs will be used in the batch command, rather than raising an exception.


fix: incompatible component access issue for gt 2 queries

This commit resolves an issue where queries with different component access expressions were incorrectly identified as incompatible when used together in an event handler. The problem was rooted in the logic that combined the component access expressions: it failed to account for the scenario where multiple queries in a handler could be compatible individually but not when combined.
TODO

[ ] add more tests
[ ] clean up docs
[ ] possibly better naming to clarify whether BoolExpr or ComponentAccessExpr.

Thanks for finding this issue! As discussed on Discord, this PR doesn't quite fix the underlying issue. I've implemented a comprehensive fix in #35. Give that a review if you'd like.


Support servant-pagination

Hello!
Have you considered supporting servant-pagination?
From the Servant pagination recipe, one needs to manually write these 3 instances:
instance ToParamSchema (Ranges '["name"] Color) where
  toParamSchema _ = -- ?

instance ToParamSchema (ContentRange '["name"] Color) where
  toParamSchema _ = -- ?

instance ToParamSchema (AcceptRanges '["name"]) where
  toParamSchema _ = -- ?

and I am thinking that this library (or maybe a new library servant-openapi-pagination?) could provide support (default Generic instances? Or just default instance for basic types like Int, Text, etc.? I haven't thought about that in detail).

I have a same problem, working on it.
Actually you do not need Generic for defined types in this lib unless you want to derive openapi types. And seems like it will be quite hard to implement these Generics.
Actually, easier way is just to use mempty, but this is not very descriptive in spec and I didn't tested it yet. Trying to provide description for each header. Didn't have time to dive deeper.

So strange
instance ToParamSchema (Ranges fields resource) where
  toParamSchema :: Proxy (Ranges fields resource) -> Schema
  toParamSchema _ =
    mempty
      & ( O.description
            ?~ "Range: <field> [<value>][; offset <o>][; limit <l>][; order <asc|desc>]"
        )
      & (O.type_ ?~ O.OpenApiString)
      & ( O.example
            ?~ A.String "<field> [<value>][; offset <o>][; limit <l>][; order <asc|desc>]"
        )

As you can see, type_ and example is working, but not description
HI, @maksbotan! Hope you know what it can be :)

Maybe, this is because in servant-openapi3 description is redefined, not sure

I have a workaround, smth like this:
instance ToParamSchema (Ranges fields resource) where
  toParamSchema :: Proxy (Ranges fields resource) -> Schema
  toParamSchema _ =
    mempty
      & (O.type_ ?~ O.OpenApiArray)
      & ( O.example
            ?~ A.String "<field> [<value>][; offset <o>][; limit <l>][; order <asc|desc>]"
        )

instance
  {-# OVERLAPS #-}
  (KnownSymbol sym, HasOpenApi sub)
  => HasOpenApi (Header' mods sym (Ranges fields resource) :> sub)
  where
  toOpenApi :: Proxy (Header' mods sym (Ranges fields resource) :> sub) -> OpenApi
  toOpenApi _ =
    toOpenApi (Proxy :: Proxy sub)
      & addParam param
      & addDefaultResponse400 name
    where
      name = toText (symbolVal (Proxy :: Proxy sym))
      param =
        mempty
          & (O.name .~ name)
          & ( O.description
                ?~ "Indicates to the server what parts of the collection is requested"
            )
          & (O.in_ .~ O.ParamHeader)
          & (O.required ?~ False)
          & (O.schema ?~ O.Inline (toParamSchema @(Ranges fields resource) Proxy))

but I'm wondering, how can I not define whole parameter by my own, but use default lib implementation and modify it

here it is
-- | Request 'Header' for pagination.
type PaginationRequestHeader (fields :: [Symbol]) (resource :: Type) =
  Header'
    '[ Optional
     , Strict
     , Description "Indicates to the server what parts of the collection is requested"
     ]
    "Range"
    (Ranges fields resource)

instance ToParamSchema (Ranges fields resource) where
  toParamSchema :: Proxy (Ranges fields resource) -> Schema
  toParamSchema _ =
    mempty
      & (O.type_ ?~ O.OpenApiArray)
      & ( O.example
            ?~ A.String "<field> [<value>][; offset <o>][; limit <l>][; order <asc|desc>]"
        )

This way original version can get Header description (& description .~ transDesc (reflectDescription (Proxy :: Proxy mods))


Webui query time intervals not latest while refresh ?

why the webui query time intervals  are not latest, event if i refresh the page manually ? Is  there any specific consideration ?
seems like it recorded last chosen time intervals.

There is refresh button in the right top bottom.


ADD Request access links for catalog items

We can make our catalog items available upon request (i have already done this for python workbench items). We can add the link to the catalog item page in the portal to the workspace overview on our documentation page, so the users can request access directly.

This is a cool idea! However, I was not immediately sure how to implement it, because for some items listed in the workspace overview, we have multiple variants ('Python Workbench CLI', 'Python Workbench CUDA Desktop', etc). So which catalog item do we link to in the overview, exactly? Or would it be better to link to all catalog items on the specific page for each workspace type?
For now, I've added a simple tutorial on how to request access in #52


jira: split url handling for issues and projects

in #3200 there was a jira_url filter that was (supposed to be) "smart". Turns out there are many variations of findings with a jira issue or findings wanting to display a jira project url if they have no issue, but only on the edit screen, but not in the findings list, etc. etc.
so this PR splits out the jira_url filter into two seperate filters so it's clear what it does and will or will not display.
thanks @madchap for reporting.

I think this is good for now.  Agreed that it could probably be improved.  Added to my getting longer "I should look at this more" list.


python311Packages.python-technove: init at 1.2.2

Python library to interact with TechnoVE local device API
https://github.com/Moustachauve/pytechnove
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 287427 run on x86_64-linux 1

2 packages built:

python311Packages.python-technove
python311Packages.python-technove.dist

Result of nixpkgs-review pr 287427 run on x86_64-linux 1

4 packages built:

python311Packages.python-technove
python311Packages.python-technove.dist
python312Packages.python-technove
python312Packages.python-technove.dist


[HOPS-183-amend]  Unit test for ClientCache with new certificates

Make sure there is no duplicate PR for this issue

Please check if the PR fulfills these requirements

[ ] Tests for the changes have been added and passed (for bug fixes / features)
[x] HOPS JIRA issue has been opened for this PR
[x] All commits have been squashed down to a single commit
[x] The commit message has the following format: [HOPS-XXX] message

Post a link to the associated JIRA issue
https://hopshadoop.atlassian.net/browse/HOPS-183

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Unit test for https://github.com/hopshadoop/hops/pull/437

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No breaking changes

Other information:

Can one of the admins verify this patch?

Jenkins test this please.


Add copyright line to mkdocs.yml (#1725)

Purpose / why

Add lines to footer to facilitate linking to resources.

What changes were made?

Added copyright line to mkdocs.yml

Note

The dummy lines must be changed to something useful before pushing to production.

Verification

These two dummy lines should appear in the footer above the Made with Material for MkDocs line
Some info about contributing can go here!
Change this in the copyright line in mkdocs.yml

Interested Parties

*@Islandora/8-x-committers

Checklist

Pull-request reviewer should ensure the following

[x] Does this PR link to related issues?
[x] Does the proposed documentation align with the Islandora Documentation Style Guide?
[ ] Are the changes accurate, useful, free of typos, etc?
[ ] Does this PR update the last updated on date on the documentation page?

Person merging should ensure the following

[x] Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
[x] If pages are renamed or removed, have all internal links to those pages been fixed?
[x] If pages are added, have they been linked to or placed in the menu?
[ ] Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

Addresses https://github.com/Islandora/documentation/issues/1713

How about
This documentation is user-sourced! Suggestions and comments are welcome in our issue queue.

as a start? (ideally, there'd be a landing page for getting involved with documentation, but right now it's too spread out to work well)

I've put a PR in moments ago to create a page walking through how to create an issue: https://github.com/Islandora/documentation/pull/1727

Put a PR against your PR: https://github.com/Islandora/documentation/pull/1734

@highermath any chance this can go through soonish?


no need to distribute with test folder

As well known, there is no need to distribute the package with test folder, neither npm nor bower.
it increase the package size unnecessarily.

Thanks for advise! I remove test folder for package version.


fix scan should output all invisiable column

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.14 seconds
stream load tsv:          541 seconds loaded<PHONE_NUMBER>9 Bytes, about 131 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          97.9 seconds inserted 10000000 Rows, about 102K ops/s
storage size:<PHONE_NUMBER>0 Bytes

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.15 seconds
stream load tsv:          539 seconds loaded<PHONE_NUMBER>9 Bytes, about 132 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          98.9 seconds inserted 10000000 Rows, about 101K ops/s
storage size:<PHONE_NUMBER>3 Bytes


Start/stop controller when device attached/detached

Pls add this feature...

Why do you need this?
The controller can be started when the application is started.
The controller does nothing if you just detach your controller.

I recently swapped to XOutput from Steam/DS4Windows to solve my latency issues. I have a unique setup where I have a 15m HDMI cable from my Study to my living room TV. Using the PS4 controller in native bluetooth has always worked well at that distance (through a wall). BUT not all games have directinput/native PS4 controller support. For games that needed Xinput i would enable Steam/DS4windows but this made the latency horrible (at distance) so couldn't play on my TV. This is because Steam/DS4Windows enable extra features of the controller (vibration/trackpad/gryo) which require additional bluetooth data.
XOutput is working fantastic, thank you soo much for your work!
In games that support the PS4 controller natively, i prefer to leave it as "DirectInput" as typically you get the PS4 icons displayed (not Xbox). So a "Start/Stop" base on certain PS4 controller would help me as i have 7 and could have some setup for xinput and some setup for directinput. Or even better, "Start/Stop" based on which game i launch.
But i am already SUPER happy, and probably not worth the effort for 'unique' situations like mine :)

Can agree this would be a nice feature, I have xoutput set to auto start and if I unplug the controllers games still detect the controller as if its plugged in.

Why do you need this? The controller can be started when the application is started. The controller does nothing if you just detach your controller.

I also would like this function.
Now when I leave the program running and disconnect my controller all my games will still show controller buttons while using keyboard and mouse. the games are still seeing the virtual controller as connected and updates the user interface to controller scheme.
It would be nice for the virtual controller to auto start when the physical device is connected and auto stop when the physical device is disconnected.
Then all games will switch their profile rightly between controller mode and keyboard+mouse mode without having to go in your program and manually stop the virtual controller.

As much as I love this app I would also love to see this feature!
I explain my case: I use my normal 2 xinput compatible controllers for RetroArch. There are 2 spare Stadia controllers to play with friends, for which XOuput does the trick.
The problem is when I want to play alone as RetroArch assigns player 1 and player inputs to the Sadia controllers. Every time I have to edit the configuration to switch to my real xinput controllers :(.