PHP version requirment is 7.1 or 7.3?

As the web page
https://getcockpit.com/documentation/getting-started/requirements
said it was require PHP 7.1
But this github home page said it was require PHP 7.3
So..what is PHP version require?

Btw. I am running it on PHP 8 and haven't encountered any issues yet. There was just an issue with 2FA that was easy to fix: https://github.com/agentejo/2FA/issues/3

Btw. this is a duplicate of https://github.com/agentejo/cockpit/issues/1474


Certification test

Update instructions on certifying a node for HIVE.

Put it in the samples folder

*The cert program

Adding the wontfix label until HIVE is in at least an Alpha state where there are some emergent features to test other than basic math.


Licence

In the United States and other places it is illegal to use software without permission. Because no license is provided only you personally can give permission to use the software. I recommend an OSS license like MIT (Jut makes it so people can do whatever they want), GPL (Makes others abide by the license and open source their work), or BSD (different version of MIT but the software has to be listed as used). These descriptions are just my thoughts on the licenses and should not be taken as legal advice and I recommend reading the licenses in full

Hey there - thanks for pointing this out. The crate is published under CC0, but I've also added a license to the repo.
I'm honestly not familiar with the legal aspect of this (especially not in the US) but I essentially waive copyright as far as possible.


Bot not waiting for Prompts.text input and Prompts.choice

Bot info:
•	SDK Platform : Node.js
•	SDK Version : v3
•	Deployment Environment : Azure Bot service
•	3 Web app bot created in Azure ( dev, demo and prod)
Issue Description:
builder.Prompts.choice and builder.Prompts.text  is not waiting for user input ( It sometimes wait for the user input and sometimes doesn’t wait and goes back to the main function and treat it as a separate utterance and goes to Luis ) in the prod environment
We were facing the same issue in the demo environment , where we had followed these steps in solving the issue.
•	We moved all the packages from dev to demo environment
•	We moved all the code files again from dev to demo
•	We restarted the app service
We had followed the same steps in the prod environment but  we are not able to resolve the issue .
We tried the same prod code in the local in visual studio code and tested it with  bot Emulator and it works completely fine.
Behaviour Noticed:
We noticed that whenever the bot URL link is opened , the connectorsetup.js file,  which connects with the bot is getting refreshed multiple times in azure.
Code Example:
I am using this way to recognize the Luis in my code
builder.LuisRecognizer.recognize(session.message.text, '<model url>', function (err, intents, entities) {
    if (entities) {
        var entity = builder.EntityRecognizer.findEntity(entities, 'TYPE');
        // do something with entity...
    }
});

Things done from  my side
When i searched in git i got this solution in which they told to use on enable and solve the issue
Another example can be found here: #2670 (comment)
var recognizer = new builder.LuisRecognizer(LuisModelUrl)
    .onEnabled(function (context, callback) {
        // LUIS is only ON when there are no tasks pending(e.g. Prompt text)
        var enabled = context.dialogStack().length === 0;
        callback(null, enabled);
    });

But the problem here was my way of calling the Luis is different and i am not sure how we can use onenabled function is builder.LuisRecognizer.recognize

You say those prompts aren't waiting for user input. Can you explain what you mean by that? What specific behavior are you experiencing and what specific behavior are you expecting?
Also, the code you shared doesn't include any prompts. It's unclear what that LUIS code has to do with your prompts not waiting.
In any case, if your bot works when running locally but not when it's published then that indicates a state issue. Are you using in-memory state storage?

hi @v-kydela ,
Please find the CODE below. `function myIntentHandler(session, msg) {
session.sendTyping();
builder.LuisRecognizer.recognize(msg, LuisModelUrl,
function (err, intents, entities) {
if (err) {
console.log("LUI Error: "+ err);
session.send('Something went wrong. Type Hello to start over.');
}
    if(intents[0].intent!=null && intents[0].score > (process.env.INTENTSCORETHRLD)){

        switch (intents[0].intent) {
            case'None':
            session.beginDialog('None',{intent:intents[0].intent , entities:entities});
            break;
        default:
            session.beginDialog('defaultDialog',{"intent":intents[0].intent , "entities":entities});
            break;
        }
    }

});

}
bot.dialog('None',[
function (session,args) {
builder.Prompts.text(session, "I'm sorry, would you mind asking again differently? I can connect you with a live person if I still don't understand.");
},
function (session, results) {
    var resp= results.response;
    session.sendTyping();
    builder.LuisRecognizer.recognize(resp, LuisModelUrl, function (err, intents, entities) {
        if (intents) {
            var TopIntent = intents[0].intent;
            if( TopIntent!="None")
                {
                     session.endDialog();
                     myIntentHandler(session, session.message.text);
                }
                else if(TopIntent=="None"){

                    noneSecondResp(session);
                }
                session.endDialog();
        }
    });
}

]);`

If you could see above, whenever the None intent is recognized by the Luis , it goes to the None Dialog, where we have the Prompts.Text function which prompts for the user input and when the user replies it needs to go  to the function(session, results) function. This is what i am expecting .

But  what really happens in my code is that, it sometimes goes to the funciton(session.results) and sometimes the code treats it as a new utterance recognizes Luis and again go to the None dialog.

The same code works perfectly fine  when i test it in bot emulator locally. I am using an in-memory state storage


Loaded build files but no entrypoints were found.

❯ bygg --version
bygg 0.1.0

Byggfile.py
from bygg.action import Action, ActionContext

def hello(ctx: ActionContext):
    print("hello")

Action("hello", command=hello, is_entrypoint=True)

❯ bygg
Loaded build files but no entrypoints were found.
Type `bygg --help` for help.

Thank you for reporting. The support for not having a YAML settings file has fallen by the wayside because it's not part of my current use cases. But it is functionality that should be there, so I'll get it fixed!


Nudge trigger a policy in Jamf

How can I use Nudge to trigger a policy in Jamf Pro vs update OS through Apple. Can I use the actionButtonPath value to run a command line? Currently the value is /System/Library/PreferencePanes/Softwareupdate.prefpane

Check the wiki before asking, a lot of useful information there:
https://github.com/macadmins/nudge/wiki/osVersionRequirements#actionbuttonpath---type-string-default-value-nil


Fix errors in using the latest termdebug.vim

If you add a defcompile statement to the end of the latest termdebug.vim script, there are a few compilation errors.
This PR addresses a few of them.
I also noticed that the commit https://github.com/vim/vim/commit/ca48202b6f46cfb40a0d1d80033a2f3e8cb7b813 changed the
termdebug window layout.  I am used to having the GDB window and the client program window as horizontally split windows on
the left and the vertically split source window on the right.  This makes it easy to switch between the GDB window and the source
window.  After this commit, now all the windows are vertically split (with the GDB window on the left, the client program window
in the middle and the source window on the right).  This makes it difficult to switch between the GDB window and the source
window.  I don't know the reasoning for this change.

thanks for your trying to patch-up that!
i've forsee that, without enough varify and experienced author such big change not sure would cost how much pain to fix all.
--
shane.xb.qian

i meant the vim9 convert,
as for the layout https://github.com/vim/vim/pull/13474#issuecomment-1790687647 had explained it.

On Sat, Jun 8, 2024 at 9:18 AM Shane-XB-Qian @.***>
wrote:

i meant the vim9 convert,
as for the layout #13474 (comment)
https://github.com/vim/vim/pull/13474#issuecomment-1790687647 had
explained it.
What was the problem the layout change was trying to address?  The layout
was usable before
this change.  With this change now, it is difficult to switch between the
GDB window and the source
window (because there are other windows in the middle).  Also, the source
code window has
less than 80 characters leading to the wrapping of the source code.  This
change should be
reverted.

Regards,
Yegappan

it is difficult to switch between the GDB window and the source window (because there are other windows in the middle).

i do not know how or what was leading you to such result, since the layout change looked was about 'Var' and 'Asm' window;
maybe that vim9 convert? i did not upgrade this convert yet (which i forsee there would be some broken since changed too much), so maybe you can varify that convert more if it was ok to do so? i may more trust you did that.

or revert that vim9 convert for termdebug (and actually i recalled somewhere bram or someone expressed wanted to keep termdebug as legacy vim script before, not sure why now it convert to vim9).
after that, if you still found it was the auto-layout of Var and Asm make you face that problem, then i am ok you to revert that one too.

On Sat, Jun 8, 2024 at 9:33 AM Shane-XB-Qian @.***>
wrote:

it is difficult to switch between the GDB window and the source window
(because there are other windows in the middle).
i do not know how or what was leading you to such result, since the layout
change looked was about 'Var' and 'Asm' window;
maybe that vim9 convert? i did not upgrade this convert yet (which i
forsee there would be some broken since changed too much), so maybe you can
varify that convert more if it was ok to do so? i may more trust you did
that.
The change in window layout is not caused by the Vim9 script conversion.
This is caused by
the changes made in
https://github.com/vim/vim/commit/ca48202b6f46cfb40a0d1d80033a2f3e8cb7b813.

Regards,
Yegappan

what other window in the middle you were trying to say?
did you manually opened var/asm window?
if yes, you still also can move that window to bottom or somewhere by manually too.
// if say so, otherwise I did not know but wish you keep to review this vim9 convert of termdebug if not revert this vim9 convert.
--
shane.xb.qian

On Sat, Jun 8, 2024 at 11:08 AM Shane-XB-Qian @.***>
wrote:

what other window in the middle you were trying to say?
did you manually opened var/asm window?

No.  I am not using the var/asm windows.  I use the following
termdebug option to
set the window width:
let g:termdebug_config = {}
let g:termdebug_config['wide'] = 164
With the above setting, when I run the ":Termdebug ./vim" command from the
Vim src
directory, I used to get a window layout with two vertically split
windows.  The left window
is horizontally split into two windows with GDB in the top window and Vim
in the bottom
window.  The vertically split right window contains the source.
After this patch, now I get three vertically split windows.  GDB in the
leftmost window,
Vim in the middle window and the source in the rightmost window.

Yegappan

if yes, you still also can move that window to bottom or somewhere by

manually too.
// if say so, otherwise I did not know but wish you keep to review this
vim9 convert of termdebug if not revert this vim9 convert.

what other window in the middle you were trying to say?
did you manually opened var/asm window?

No.  I am not using the var/asm windows.  I use the following
termdebug option to
set the window width:
let g:termdebug_config = {}
let g:termdebug_config['wide'] = 164

then i do not know what happened to you, since the auto-layout is only about 'Var' and 'Asm' window,
if you did not manually open it (or enabled the option of auto, but i supposed you would not do so),
it should be not impact your other windows e.g source and gdb window.
// please check the code before https://github.com/vim/vim/pull/14903 that vim9 convert,
// or after that convert, but i did not upgrade or tried to use that yet.
--
shane.xb.qian

@yegappan Thanks for the changes, and sorry to have missed several spaces here and there. I like the introduction of StopCommand() and ContinueCommand(). I am planning to further exploit Vim9 import/export features to refactor the code and I will also try to use some funcrefs (example: switching funcref in a Init() function depending on the value of the variable way for example, but I identified several other places). My idea is to try to refactor the architecture in a more readable/easy-to-maintain/flexible way that shall easy e.g. the introduction of lldb(I read somewhere wish it) and perhaps DAP:s. Will I succeed? I dunno :)  I'll send a PR once done.

thanks! May be we need to find out what causes the layout switch again. I though this only happens in the ASM or variable window when this is opened ?

Christian asked twice in #13474 for screenshots to demonstrate what that PR should do. None were given. Now this discussion here involves a lot of confusion about which extra windows are displayed where with what options ... it would be much simpler if people could start including screenshots when discussing layout changes/issues. A picture paints a thousand words etc.

On Sat, Jun 8, 2024 at 9:08 PM Shane-XB-Qian @.***>
wrote:

what other window in the middle you were trying to say?
did you manually opened var/asm window?

No. I am not using the var/asm windows. I use the following
termdebug option to
set the window width:
let g:termdebug_config = {}
let g:termdebug_config['wide'] = 164

then i do not know what happened to you, since the auto-layout is only
about 'Var' and 'Asm' window,
if you did not manually open it (or enabled the option of auto, but i
supposed you would not do so),
it should be not impact your other windows e.g source and gdb window.
// please check the code before https://github.com/vim/vim/pull/14903
that vim9 convert,
// or after that convert, but i did not upgrade or tried to use that yet.

This turned out to be a bug in the term_start() function.  This function
doesn't clear the vertical
split command modifier correctly.  I have opened a PR to address this.
Regards,
Yegappan

@chrisbra could we keep the legacy version of termdebug, which like coloschema, e.g foo vs foo_256?
// untill there some confident vim9 version can replace with legacy version, or just keep two version for good,
// if so, whatever vim9 version what changes (#14978 etc) going to be but kept the legacy version stable,
// same like some people like classic native coloschema vs not their refactor ones.
--
shane.xb.qian


Allow to push images to other registries

WIP, do not merge.
Fix #613
This enables any v2 registry to be used to host images. Works well with Docker hub. Doesn't work on Quay.io, but I'm not sure they upgraded to v2.
Still needs:

[x] Documentation
[x] Integration tests with other registries (there's one for docker hub that I want to try on CI)

Release Note
Added support for pushing images to authenticated external docker registries (such as Docker Hub or Github Packages)

Removing WIP.
I've:

Added documentation on how to configure an external registry
Included examples about docker hub and github packages
Added integration tests for both (with credentials setup on Travis)
Added a new trait (pull-secret trait) for configuring automatically the pull secret for an integration, so that private external registries can be used without issues (Github packages is private for pull)


Possible Langchain integration?

Hey, kind man! Your model is just awesome, wondering if you have some plans for langchain integration? Current they're support blip-image-captioning for image capture, but your variant looks much more useful honestly! Great work!

Thanks for your suggestion.
It would be easy and I'll consider implement it recently.


Adding qzv fileapth type

Needed for the visualization type

Codecov Report

Merging #2159 into analysis-refactor will increase coverage by 9.69%.
The diff coverage is 100%.

@@                  Coverage Diff                  @@
##           analysis-refactor    #2159      +/-   ##
=====================================================
+ Coverage              81.47%   91.17%   +9.69%
=====================================================
  Files                     24      203     +179
  Lines                   2278    21324   +19046
=====================================================
+ Hits                    1856    19442   +17586
- Misses                   422     1882    +1460

Impacted Files
Coverage Δ

qiita_db/test/test_setup.py
97.95% <100%> (ø)

qiita_ware/commands.py
33.96% <0%> (-12.27%)
:arrow_down:

qiita_core/tests/test_configuration_manager.py
98.54% <0%> (-0.73%)
:arrow_down:

qiita_ware/ebi.py
90.84% <0%> (-0.23%)
:arrow_down:

...pet/handlers/artifact_handlers/process_handlers.py
100% <0%> (ø)

...iita_db/support_files/patches/python_patches/53.py
92.3% <0%> (ø)

qiita_db/handlers/tests/test_core.py
91.66% <0%> (ø)

...ta_pet/handlers/analysis_handlers/base_handlers.py
98.66% <0%> (ø)

qiita_pet/test/tornado_test_base.py
90.9% <0%> (ø)

...ta_pet/handlers/study_handlers/listing_handlers.py
90.07% <0%> (ø)

... and 173 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 080be0f...2258a62. Read the comment docs.


Notifications & Offers tab results

From https://github.com/kodadot/nft-gallery/pull/5442#pullrequestreview-1376274810

Tested on /snek/gallery/331660682-7, I can see 4 "offer" events in NotificationBox but only 2 row in Offers tab maybe remove expired?

Originally posted by @roiLeo in https://github.com/kodadot/nft-gallery/pull/5581#pullrequestreview-1378853325
Account address:
bXhWeVLtArWauM8UmbaVdDmXmo5uSDk6DAa2YxQ5zbt2sDcbW

I think this is what we've noticed with @exezbcz that in Offers tab we are not showing all offers?

i think i've filtered expired offers in notification. is it still there?

Yep, stil present
query notificationsByAccount {
  offers(where: { nft: { id_eq: "331660682-7" } }) {
    id
    caller
    expiration
    price
    status
  }
  stats: offersConnection(
    orderBy: id_ASC
    where: { nft: { id_eq: "331660682-7" } }
  ) {
    total: totalCount
  }
}

2 results while your query show 4 results

won't fix bsx


Does tabula-java support table recognition in images(e.g., png, jpg), not just pdf?

Sorry, I cannot find google group for tabulapdf, therefore I ask my question here. If there is a better place, please let me know.
Does tabula-java support table recognition in images(e.g., png, jpg), not just pdf? Also, is tabula-java commercial free?

Hi @johnny5550822,

Does tabula-java support table recognition in images(e.g., png, jpg), not just pdf?
It doesn't.

Also, is tabula-java commercial free?
Yes, it is released under the MIT license.


Remove True / False choice from Validation edit entryscreen

At the bottom of the Validation edit screen there is a Record valid True False choice. If the Validator selects true the changes are not tested.
This creates the risk that a Validator can cheat the system by entering ann invalid Alternative POB (i.e. not on the Gazetteer and select True. This puts the invalid record into the system and no match will ever be achieved on a POB search.
The default value of this choice is False. I propose that we simply hide the choice so that it cannot be used. This means that all alternative POBs will be tested and the loophole closed.
Once the alternative POB has been tested it is simply promulgated and accepted on the main screen.
I have just validated a whole piece without using this choice and I have had no problems doing it like that.
This change will increase our data integrity.
Geoff

I have been updating the Handbooks. The Transcribers and Proofreaders Handbook is online. I have now almost finished the Addendum for Validators. The new version takes into account Story #1384.
It involves hiding an entry on a form. No coding is required as the result will be the default setting. I need to remove the alternative ‘true’ setting which is creating a loophole that allows Validators to force incorrect data into the system. The process is not affected other than removing a short cut option.
Is it able to be done, please? I will have the new Handbook version available this week.
Geoff

It is useful for testing purposes, so will be hidden from all but SysAdmin and people in Technical.

@geoffj-FUG this is ready for testing on Test3 now.
Modified so that when editing a record during validation only users with role of system_administrator or technical will have the option to change the 'Record valid' flag (as this is useful for developers when testing etc). All other users will not be able to change the flag.
Foe them it will look like this:

@geoffj-FUG have you been able to test this?

Tested OK.
I thought I sent a message asking if it could be hidden entirely rather than greyed out. It seems to be missing.
There is an alternative to put a note “for system admin and technical  use only” next to it. That stops people reporting the greying out as a problem.
Geoff
From: PatReynolds @.>
Sent: Thursday, April 7, 2022 1:35 AM
To: FreeUKGen/FreeCENMigration @.>
Cc: geoffj-FUG @.>; Mention @.>
Subject: Re: [FreeUKGen/FreeCENMigration] Remove True / False choice from Validation edit entryscreen (Issue #1384)
@geoffj-FUG https://github.com/geoffj-FUG  have you been able to test this?
—
Reply to this email directly, view it on GitHub https://github.com/FreeUKGen/FreeCENMigration/issues/1384#issuecomment-1090412183 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AKCPIFMXMMB6GGWHBYAXGF3VDWVMBANCNFSM5PL5U65Q .
You are receiving this because you were mentioned.Message ID: @.***>

Ok thanks @geoffj-FUG I’ll take a look at that when I’m back next week

Ok @geoffj-FUG updated code has now been deployed to Test3. It should be entirely hidden from all users other than those with System-administrator or technical role.

Anne
Looks good.
This can go live.
Geoff
From: Anne Vandervord @.>
Sent: Tuesday, 12 April 2022 3:17 AM
To: FreeUKGen/FreeCENMigration @.>
Cc: geoffj-FUG @.>; Mention @.>
Subject: Re: [FreeUKGen/FreeCENMigration] Remove True / False choice from Validation edit entryscreen (Issue #1384)
Ok @geoffj-FUG https://github.com/geoffj-FUG  updated code has now been deployed to Test3. It should be entirely hidden from all users other than those with System-administrator or technical role.
—
Reply to this email directly, view it on GitHub https://github.com/FreeUKGen/FreeCENMigration/issues/1384#issuecomment-1095322027 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AKCPIFKGSW2CINJFWX7CTU3VERNCFANCNFSM5PL5U65Q .
You are receiving this because you were mentioned.  https://github.com/notifications/beacon/AKCPIFPL6UWTX3EPEN2TC6TVERNCFA5CNFSM5PL5U652YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOIFEUTKY.gif Message ID: @.*** @.***> >

@geoffj-FUG - deployed to production along with new Validators Handbook. I think this story can be closed now.

I have just run about 50 entries through it in production with no problems.
This story can now be closed.

Anne
This screen Works well.
I have been validating without using the option for a while now and so I am sure about the functionality.
I notice that it is greyed out. Is it possible to hide it completely? Otherwise people may start to report it as not working.
Geoff
From: Anne Vandervord @.>
Sent: Friday, 25 March 2022 6:52 PM
To: FreeUKGen/FreeCENMigration @.>
Cc: geoffj-FUG @.>; Mention @.>
Subject: Re: [FreeUKGen/FreeCENMigration] Remove True / False choice from Validation edit entryscreen (Issue #1384)
@geoffj-FUG https://github.com/geoffj-FUG  this is ready for testing on Test3 now.
Modified so that when editing a record during validation only users with role of system_administrator or technical will have the option to change the 'Record valid' flag (as this is useful for developers when testing etc). All other users will not be able to change the flag.
Foe them it will look like this:
https://camo.githubusercontent.com/b6c65fe30e65b6dff89b53a4a49b4b94e1877cfda32804d883306e867b360450/68747470733a2f2f696d616765732e7a656e68756275736572636f6e74656e742e636f6d2f3630303961656363643630343239636237303038653564332f63653733323564302d383666652d343636322d613563352d646637396136313337636337
—
Reply to this email directly, view it on GitHub https://github.com/FreeUKGen/FreeCENMigration/issues/1384#issuecomment-1078793521 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AKCPIFP3J7DOCR4K4IZDJX3VBV5EZANCNFSM5PL5U65Q .
You are receiving this because you were mentioned.  https://github.com/notifications/beacon/AKCPIFKSWRV3CONQCOXK4PLVBV5EZA5CNFSM5PL5U652YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOIBGRKMI.gif Message ID: @.*** @.***> >

@geoffj-FUG are you sure users will not want to see if the record is currently valid or not? We could add (for information only) next to 'Record Valid'  field name for all but system_administrator/technical users.

Anne
The true false was an extra keystroke and subject to abuse. In addition it didn't mean much to  the average validator.
Record valid simply means that it has been validated (the true/false column in the csv download during validation).
The override button has replaced this. It allows the validator to override the system when there is more than one item to look at and makes it very clear that the validator is making a decision.
Once a record is incorporated all flags are true. So it does not affect the user.
Geoff

@geoffj-FUG I am a bit mystified by this now. Looking back at the code for the form, the 'Record Valid' item should not be showing for anyone at all. It was removed when the Override Warnings button was provided (#1424). I have just tested on my local installation (which is running the current software version) and on Test3, neither have the 'Record Valid' item showing when editing a record with warnings. Are you still seeing it?

Anne,
If you download a csv file during validation the true/false flag downloads with it.
When the file is incorporated the count of false flags must me 0.
Once a file is Incorported the flag is not needed. To me it is transitory. It appears when we select the Validate Action and is no longer needed once a file is Incorporated. It is only part of the Validation process.
Geoff

Sorry @geoffj-FUG still a bit unsure what you want here.
Are you asking for the 'record_valid' column to be excluded from the 'Download File' output if the file has already been incorporated?
If not - would you please include some screenshots of the pages that you want changing.


How could I know I'm using origin webview or xwalk webview?

Great project which really to the point.I want to use crosswalk to support our application web pages.I have done all steps in README.However page event fire frequency keeps slow(touchmove listeners fires only when touch start).
Any suggestions?

We have to use CrosswalkWebView component instead of WebView.I'll glad to send a pr to complete the README guidance. @jordansexton
import CrosswalkWebView from 'react-native-webview-crosswalk'

...

<CrosswalkWebView
  source = {{ uri:'http://app.decobim.com' }}
  injectedJavaScript={`setTimeout(function(){window.postMessage("HHHHHHH")},2000)`}
  onMessage={ this.messageHandler }
/>


fix: Remove duplicate byte array allocation for CometDictionary

Which issue does this PR close?

Closes #225.
Rationale for this change

What changes are included in this PR?

How are these changes tested?

cc @sunchao @parthchandra

Also, FWIW, from memory profiling Comet while running TPC-DS, it appears that CometVector.getDecimal is a large (though not largest) contributor to memory allocation. This PR will not affect the memory usage, but should certainly speed things up a bit.

Merged. Thanks.


Rescue require 'fiber' LoadError

This was needed in Ruby 2.2 and JRuby tests.
Before contributing, please read our contributing guidelines and code of conduct.
Overview
Describe the changes present in the pull request
Submitter Checklist:

[ ] Include a link to the related GitHub issue, if applicable
[ ] Include a security review link, if applicable

Testing
The agent includes a suite of unit and functional tests which should be used to
verify your changes don't break existing functionality. These tests will run with
GitHub Actions when a pull request is made. More details on running the tests locally can be found
here for our unit tests,
and here for our functional tests.
For most contributions it is strongly recommended to add additional tests which
exercise your changes.
Reviewer Checklist

[ ] Perform code review
[ ] Add performance label
[ ] Perform appropriate level of performance testing
[ ] Confirm all checks passed
[ ] Add version label prior to acceptance

The failures will be resolved when we merged dev into this branch. Waiting on the customer's response to #2001 before making changes to the branch.


fix: inherit el with hoisted nodes inside keyed template fragment

fix #2080

Update: only call it when the stable fragment has key + do not traverse recursively.


Add method signature annotation for class example

Addresses the confusion created by the current React.Component subclass example and described in #1694
Could also create a type for state as well. If this isn’t desired and it’s preferred to keep the example with the inline type declaration for the props instance property, I can instead add a note after the example warning users that any exported component will require this kind of annotation.
When I was trying to figure this out in my own project, I had hoped that there would be a way to reference the inline props annotation in the constructor method signature, but couldn’t figure it out. If that’s possible in a nice way, I think changing this example to use that technique would be best.

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot import


how to assign a different gpu to each session in a process .

tensorflow c API：I want to create multiple sessions for different models in a process, how to assign a different gpu to each session.

Wrap your sessions in with commands like this:
with tf.device('/GPU:0'):
    .... (code for GPU:0) ....

with tf.device('/GPU:1'):
    .... (code for GPU:1) ....

@liupengkd
Looks like this issue is duplicate of # 33996 ?. Please, confirm.Thanks!

@liupengkd
@ravikyram
i have solved please check my file

@liupengkd
Please, let me know if we can close this issue since it looks to be fixed. Thanks!


Bump version to 0.0.21

#582  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @carolineechen and the rest of your teammates on  Graphite


fix: pasting outside of cells doing nothing

Previously pasting anything but cells into the notebook would do nothing. This way pasting other content uses the browser's default action.
Fixes #284
Fixes https://github.com/widgetti/solara/issues/671

Hi @krassowski ,
I guess these failures are unrelated. If not, let us know and we can take a look.
Cheers,
Maarten

@RRosio maybe you'd like to take a look. It's a small, almost trivial fix, we only needed to prevent default on cell pasting.


Improve kubernetes pods dashboard

What this PR does / why we need it:
Adds sent bytes for the Network I/O dashboard. This was missing from the dashboard.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

Integrated requested changes and rebased.


Add docs site PR, deploy, and merge steps to readme

@kerrishotts if it helps, I wrote the deploy steps for the Libraries API docs out here:
https://github.com/AdobeDocs/cc-libraries-api/tree/ash/sprint-1#deploying


Fix requires

fix require
rest_client

@raphink must it be require 'rest-client' ?
https://github.com/rest-client/rest-client


feat: dark mode in membership page

Title and Issue number

Title :  dark mode in membership page
Issue No. :#1214
Code Stack :
Close #1214

Description

dark mode feature in membership page
Video/Screenshots (mandatory)

https://github.com/user-attachments/assets/5ac71d4d-122a-4d8d-bac3-12c3270e74eb
Type of PR

[X] Feature enhancement

Checklist:

[X] I have performed a self-review of my code.
[X] I have commented my code, particularly in hard-to-understand areas.
[X] I have tested the changes thoroughly before submitting this pull request.
[X] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[X] I have gone through the  contributing.md file before contributing

Additional context:

##Are you contributing under any Open-source programme?

[X] I am contributing under GSSOC'24

@apu52 please review once and merge my pr

@apu52 can you please suggest me what changes you want as i have given same toggke for dark and light mide and in no particular pahe there is dark mode from where i could take reference

@ANKeshri please try to look at the UI of the main website at dark mode check the color schemes . You can take reference from that . Actually In the dark mode u have made it's simply black color UI so I wanted u to enhance it .

@apu52 made the dark mode according to theme (taken refernce from home page testionial)


ViewP and show tabs command

Add viewP and show tabs command.
closes #106, closes #84.

Ready for review, currently UI a bit lacking but I think it would be better to improve on the UI in another PR.


Validate RHEL8.7

Validate RHEL 8.7 on k3s to be added to support matrix

Validating using this version: v1.25.4+k3s1
AMI used : ami-0defbb5087b2b63c1
Test validated:

Fresh Installation and sonobuoy execution
Upgrade Traditional with workloads
Upgrade SUC k3s native with workloads
Upgrade via node replacement
Restart k3s service on all nodes, then deploy a new workload and make sure that it comes up and is accessible
Secret Encryption - basic validation
Pending: Cluster-reset (Perform on one of the server nodes after bringing two of them down)


Hyprland lags when moving cursor

Already reported ? *

[X] I have searched the existing open and closed issues.

Regression?
Yes
System Info and Version
 System/Version info
Hyprland, built from branch  at commit 0c7a7e2d569eeed9d6025f3eef4ea0690d90845d  (version: bump to 0.44.0).
Date: Sun Oct 6 11:04:13 2024
Tag: v0.44.0, commits: 5299
built against aquamarine 0.4.1

flags: (if any)

System Information:
System name: Linux
Node name: arch
Release: 6.11.2-arch1-1
Version: #1 SMP PREEMPT_DYNAMIC Fri, 04 Oct 2024 21:51:11 +0000

GPU information:
07:00.0 VGA compatible controller [0300]: NVIDIA Corporation AD104 [GeForce RTX 4070] [10de:2786] (rev a1) (prog-if 00 [VGA controller])
NVRM version: NVIDIA UNIX Open Kernel Module for x86_64  560.35.03  Release Build  (archlinux-builder@arch)

os-release: NAME="Arch Linux"
PRETTY_NAME="Arch Linux"
ID=arch
BUILD_ID=rolling
ANSI_COLOR="38;2;23;147;209"
HOME_URL="https://archlinux.org/"
DOCUMENTATION_URL="https://wiki.archlinux.org/"
SUPPORT_URL="https://bbs.archlinux.org/"
BUG_REPORT_URL="https://gitlab.archlinux.org/groups/archlinux/-/issues"
PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/"
LOGO=archlinux-logo

plugins:

Description
After updating to 0.44.0, Hyprland lags when I move my mouse; fps drops from 144 to ~50-60 fps. Can't repro on sway
How to reproduce

Launch Hyprland
Move mouse

Crash reports, logs, images, videos
No response

See the the wiki's section on hardware cursors on Nvidia: https://wiki.hyprland.org/Nvidia/#environment-variables
I saw the same behavior after upgrading and disabling hardware cursors fixed it.

ye thats an nvidia bug


Update README installation guide

If CICD is working, lets change the installation guide to point to PyPI

installation tested and updated


[docs] Migrate Autocomplete demos

Migrates Autocomplete demos to emotion. One of https://github.com/mui-org/material-ui/issues/16947
Preview: https://deploy-preview-26127--material-ui.netlify.app/components/autocomplete/

Actually, I like how unstyled components are using the CSS template string, and customization on the core component the JS Object syntax.


Adding interfaces for subscribing Tasks and HappeningHandlers to Topics.

Adding some other minor code fixes.

This change is

Reviewed 19 of 19 files at r1.
Review status: all files reviewed at latest revision, 33 unresolved discussions.

BaboonFramework/src/org/unc/lac/baboon/exceptions/NotSubscribableException.java, line 20 at r1 (raw file):

is not a Task or HappeningHandler

change by "is not subscribable" best
If another sbscribable is added, this string will be outdated

BaboonFramework/src/org/unc/lac/baboon/main/BaboonConfig.java, line 55 at r1 (raw file):

throws BadTopicsJsonFormat, NoTopicsJsonFileException

add to javadoc

BaboonFramework/src/org/unc/lac/baboon/main/BaboonConfig.java, line 73 at r1 (raw file):

throws NotSubscribableException

add to javadoc

BaboonFramework/src/org/unc/lac/baboon/task/HappeningHandlerObject.java, line 7 at r1 (raw file):

This class defines a HappeningHandlerObject as a pair of an object instance and a method

I can't understand this class' usage from this doc
Is this intended to be extended by the user? If so, make it abstract

BaboonFramework/src/org/unc/lac/baboon/task/TaskObject.java, line 7 at r1 (raw file):

This class defines a TaskObject as a pair of an object instance and a method

same as HappeningHandlerObject

BaboonFramework/src/org/unc/lac/baboon/utils/MethodDictionary.java, line 11 at r1 (raw file):

    private static HashMap<Pair<Object, String>, Method> methodDict = new HashMap<Pair<Object, String>, Method>();

    public static Method getMethod(Object object, String methodName) throws NoSuchMethodException, SecurityException {

add javadoc

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 35 at r1 (raw file):

ShouldNotFailTest

this doesn't express the test intention
use something like subscribingHappeningHandlerToTopicShouldGetRegisteredInConfig

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 51 at r1 (raw file):

assertTrue(happeningHandlerSubscriptionsMap.size() == 1);

use assertEquals(1, happeningHandlerSubscriptionsMap.size());

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 56 at r1 (raw file):

assertTrue

use assertEquals

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 80 at r1 (raw file):

ShouldNotFailTest

doesn't express test's intention

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 95 at r1 (raw file):

assertTrue

use assertEquals

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 100 at r1 (raw file):

assertTrue

use assertEquals

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 123 at r1 (raw file):

Then a {@link NotSubscribableException} exception should be thrown

You're testing 3 behaviours here, make 3 unit tests from this one

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 126 at r1 (raw file):

ShouldFailTest

shouldn't fail test. Test passes when this fails. Fix this name

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 141 at r1 (raw file):

assertTrue(true);

this is the same as nothing, no assertion should pass in the exact same way
catch exception and assert
assertEquals(NotSubscribableException.class, e.getClass());

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 147 at r1 (raw file):

assertTrue(true);

same here

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 153 at r1 (raw file):

assertTrue(true);

same here

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 168 at r1 (raw file):

ShouldFailTest

fix the name

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 183 at r1 (raw file):

assertTrue(true);

same as previous test

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 189 at r1 (raw file):

assertTrue(true);

same here

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 202 at r1 (raw file):

ShouldFailTest

fix name. Removing "Test" is enough

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 216 at r1 (raw file):

assertTrue(true);

same as previous test

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 234 at r1 (raw file):

ShouldNotFailTest

fix name

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 253 at r1 (raw file):

assertTrue

assertEquals

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 259 at r1 (raw file):

baboonConfig = new BaboonConfig();

why do you create a new BabonConfig object? is it not reusable?

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 270 at r1 (raw file):

assertTrue(true);

remove this

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 272 at r1 (raw file):

assertTrue

assertEquals

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 289 at r1 (raw file):

assertTrue(true);

remove this

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 291 at r1 (raw file):

assertTrue

assertEquals

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 309 at r1 (raw file):

assertTrue(true);

remove this

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 311 at r1 (raw file):

assertTrue

assertEquals

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 343 at r1 (raw file):

assertTrue(true);

catch exception and assert class

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 350 at r1 (raw file):

assertTrue(true);

same as above

Comments from Reviewable

Review status: 12 of 16 files reviewed at latest revision, 33 unresolved discussions.

BaboonFramework/src/org/unc/lac/baboon/exceptions/NotSubscribableException.java, line 20 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> > is not a Task or HappeningHandler
>
> change by "is not subscribable" best
> If another sbscribable is added, this string will be outdated

Done.

BaboonFramework/src/org/unc/lac/baboon/main/BaboonConfig.java, line 55 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> > throws BadTopicsJsonFormat, NoTopicsJsonFileException
>
> add to javadoc

I don't think it is completely necessary since java automatically incorporates the checked exceptions to javadoc, but let's decide which of this two conventions we will follow in the future:
http://www.javapractices.com/topic/TopicAction.do?Id=171
http://www.javapractices.com/topic/TopicAction.do?Id=44

BaboonFramework/src/org/unc/lac/baboon/task/HappeningHandlerObject.java, line 7 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> > This class defines a HappeningHandlerObject as a pair of an object instance and a method
>
> I can't understand this class' usage from this doc
>
> Is this intended to be extended by the user? If so, make it abstract

It was intended to be for internal use only, It's purpose was to giving HappeningHandlerObject an entity. Anyways I'll just delete this and stick to Pair only.

BaboonFramework/src/org/unc/lac/baboon/task/TaskObject.java, line 7 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> > This class defines a TaskObject as a pair of an object instance and a method
>
> same as HappeningHandlerObject

Same as above

BaboonFramework/src/org/unc/lac/baboon/utils/MethodDictionary.java, line 11 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> add javadoc

Done.

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 35 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> > ShouldNotFailTest
>
> this doesn't express the test intention
>
> use something like subscribingHappeningHandlerToTopicShouldGetRegisteredInConfig

Done.

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 51 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> > assertTrue(happeningHandlerSubscriptionsMap.size() == 1);
>
> use assertEquals(1, happeningHandlerSubscriptionsMap.size());

Done.

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 56 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> > assertTrue
>
> use assertEquals

Done.

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 80 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> > ShouldNotFailTest
>
> doesn't express test's intention

Done.

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 95 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> > assertTrue
>
> use assertEquals

Done.

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 100 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> > assertTrue
>
> use assertEquals

Done.

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 123 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> > Then a {@link NotSubscribableException} exception should be thrown
>
> You're testing 3 behaviours here, make 3 unit tests from this one

Done.

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 126 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> > ShouldFailTest
>
> shouldn't fail test. Test passes when this fails. Fix this name

Done.

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 141 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> > assertTrue(true);
>
> this is the same as nothing, no assertion should pass in the exact same way
>
> catch exception and assert
> assertEquals(NotSubscribableException.class, e.getClass());

Done.

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 147 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> > assertTrue(true);
>
> same here

Done.

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 153 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> > assertTrue(true);
>
> same here

Done.

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 168 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> > ShouldFailTest
>
> fix the name

Done.

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 183 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> > assertTrue(true);
>
> same as previous test

Done.

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 189 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> > assertTrue(true);
>
> same here

Done.

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 202 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> > ShouldFailTest
>
> fix name. Removing "Test" is enough

Done.

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 216 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> > assertTrue(true);
>
> same as previous test

Done.

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 234 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> > ShouldNotFailTest
>
> fix name

Done.

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 253 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> > assertTrue
>
> assertEquals

Done.

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 259 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> > baboonConfig = new BaboonConfig();
>
> why do you create a new BabonConfig object? is it not reusable?

Yes, but I wanted to clear config before testing other combinations because if I try to subscribe testMethod or happeningHandler method more than once then an exception is thrown

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 270 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> > assertTrue(true);
>
> remove this

Done.

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 272 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> > assertTrue
>
> assertEquals

Done.

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 289 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> > assertTrue(true);
>
> remove this

Done.

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 309 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> > assertTrue(true);
>
> remove this

Done.

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 311 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> > assertTrue
>
> assertEquals

Done.

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 343 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> > assertTrue(true);
>
> catch exception and assert class

Done.

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 350 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> > assertTrue(true);
>
> same as above

Done.

Comments from Reviewable

Review status: 12 of 16 files reviewed at latest revision, 31 unresolved discussions.

BaboonFramework/src/org/unc/lac/baboon/main/BaboonConfig.java, line 73 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> > throws NotSubscribableException
>
> add to javadoc

Same as above

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 291 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> > assertTrue
>
> assertEquals

Done.

Comments from Reviewable

Reviewed 6 of 7 files at r2.
Review status: all files reviewed at latest revision, 12 unresolved discussions.

BaboonFramework/src/org/unc/lac/baboon/main/BaboonConfig.java, line 55 at r1 (raw file):
Previously, juanjoarce7456 (Juan Jose Arce Giacobbe) wrote…
> I don't think it is completely necessary since java automatically incorporates the checked exceptions to javadoc, but let's decide which of this two conventions we will follow in the future:
> http://www.javapractices.com/topic/TopicAction.do?Id=171
> http://www.javapractices.com/topic/TopicAction.do?Id=44

you decide and we'll take that choice and use it. Either way, I'll resolve this discussion

BaboonFramework/src/org/unc/lac/baboon/main/BaboonConfig.java, line 35 at r2 (raw file):

Pair<Object, Method>

why did you delete AbstractTask? This way you're spreading Pair<Object,Method> for all the code.
AbstractTask can wrap this hiding implementation details

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 141 at r1 (raw file):
Previously, juanjoarce7456 (Juan Jose Arce Giacobbe) wrote…
> Done.

this is better but the catch should be for Exception. This way it's just redundant

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 147 at r1 (raw file):
Previously, juanjoarce7456 (Juan Jose Arce Giacobbe) wrote…
> Done.

same, catch Exception

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 153 at r1 (raw file):
Previously, juanjoarce7456 (Juan Jose Arce Giacobbe) wrote…
> Done.

same as above

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 183 at r1 (raw file):
Previously, juanjoarce7456 (Juan Jose Arce Giacobbe) wrote…
> Done.

same as above

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 189 at r1 (raw file):
Previously, juanjoarce7456 (Juan Jose Arce Giacobbe) wrote…
> Done.

same as above

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 216 at r1 (raw file):
Previously, juanjoarce7456 (Juan Jose Arce Giacobbe) wrote…
> Done.

same as above

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 343 at r1 (raw file):
Previously, juanjoarce7456 (Juan Jose Arce Giacobbe) wrote…
> Done.

same as above

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 350 at r1 (raw file):
Previously, juanjoarce7456 (Juan Jose Arce Giacobbe) wrote…
> Done.

same as above

BaboonFramework/src/org/unc/lac/baboon/task/HappeningHandlerObject.java, line 7 at r1 (raw file):
Previously, juanjoarce7456 (Juan Jose Arce Giacobbe) wrote…
> It was intended to be for internal use only, It's purpose was to giving HappeningHandlerObject an entity. Anyways I'll just delete this and stick to Pair only.

I'm ok with this class being here, I just want to understand its purpose. I'd rather have this class than using Pair
 all over the code

BaboonFramework/src/org/unc/lac/baboon/task/TaskObject.java, line 7 at r1 (raw file):
Previously, juanjoarce7456 (Juan Jose Arce Giacobbe) wrote…
> Same as above

same as HappenningHandlerObject

Comments from Reviewable

Review status: 14 of 19 files reviewed at latest revision, 11 unresolved discussions.

BaboonFramework/src/org/unc/lac/baboon/main/BaboonConfig.java, line 35 at r2 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> > Pair
>
>
> why did you delete AbstractTask? This way you're spreading Pair for all the code.
> AbstractTask can wrap this hiding implementation details

Done.

BaboonFramework/src/org/unc/lac/baboon/task/HappeningHandlerObject.java, line 7 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> I'm ok with this class being here, I just want to understand its purpose. I'd rather have this class than using Pair
>  all over the code

Done.

BaboonFramework/src/org/unc/lac/baboon/task/TaskObject.java, line 7 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> same as HappenningHandlerObject

Done.

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 141 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> this is better but the catch should be for Exception. This way it's just redundant

Done.

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 147 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> same, catch Exception

Done.

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 153 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> same as above

Done.

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 183 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> same as above

Done.

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 189 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> same as above

Done.

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 216 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> same as above

Done.

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 343 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> same as above

Done.

BaboonFramework/test/org/unc/lac/baboon/test/cases/TasksAndHappeningHandlersSubscriptionTest.java, line 350 at r1 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…
> same as above

Done.

Comments from Reviewable

Reviewed 5 of 5 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

BaboonFramework/src/org/unc/lac/baboon/main/BaboonConfig.java, line 100 at r3 (raw file):

if ((isHappeningHandler = method.isAnnotationPresent(HappeningHandler.class))

Quoted 7 lines of code…
>                     || method.isAnnotationPresent(Task.class)) {
>                 AbstractTask task = (isHappeningHandler) ? new HappeningHandlerObject(object, method)
>                         : new TaskObject(object, method);
>                 if (subscriptionsMap.putIfAbsent(task, topic) != null) {
>                     throw new NotSubscribableException(
>                             "This HappeningHandler or Task is already subscribed to a topic.");
>                 }

make this into two different if statements. That'll also allow you to make more specific exception messages
this way it's less readable

Comments from Reviewable

Review status: 18 of 19 files reviewed at latest revision, 1 unresolved discussion.

BaboonFramework/src/org/unc/lac/baboon/main/BaboonConfig.java, line 100 at r3 (raw file):
Previously, airabinovich (Ariel Iván Rabinovich) wrote…

if ((isHappeningHandler = method.isAnnotationPresent(HappeningHandler.class))
|| method.isAnnotationPresent(Task.class)) {
AbstractTask task = (isHappeningHandler) ? new HappeningHandlerObject(object, method)
: new TaskObject(object, method);
if (subscriptionsMap.putIfAbsent(task, topic) != null) {
throw new NotSubscribableException(
"This HappeningHandler or Task is already subscribed to a topic.");
}

make this into two different if statements. That'll also allow you to make more specific exception messages
this way it's less readable

Done.

Comments from Reviewable

Reviewed 1 of 1 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Fix python requirements for numpy

Issue #, if available:
python -m pip install -r requirements.txt
Pip raises error:
ERROR: No matching distribution found for numpy==1.23.1
Description of changes:
Fixed possible typo.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Hi! Thanks for your PR.
I believe the issue is that numpy 1.23.1 is only available for Python >=3.8.
Are you using Python 3.7? v1.21.3 is available for this version of Python.
I think instead of modifying the requirements, we should add a badge and/or explanation to the README explaining we require Python version 3.8 or higher (the pytest dependency requires v3.7 or higher btw).
Could you keep the requirements the same, but make changes to the README etc? It looks like shields.io is the standard for badges; we might need to make some changes to the top level folder to make these work https://github.com/badges/shields
No worries if you can't

You're right, I'm using python 3.7 and I overlooked recommendation to use 3.9 in readme.
From this point I think nothing ought to be done. Thank you for your time!


Research adding Clay to the site

Clay components are now available in React — would be great to use them on the site.
Since components are added on an as-needed basis, we'd need to first figure out which components are available and what we'd be replacing.

wontfix — using themeui for now


  Without this fix a healthcheck with an
unendeding cat command could cause the task queue to eventually fill and
only a reboot would resolve it.
Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=1636244

@runcom @mrunalp PTAL
I have no idea on this one.

@umohnani8 if you could PTAL too, I'd appreciate it.

LGTM, but would like a review from @mrunalp or @runcom  as well

If a task is both a background task and has no done channel, assume it

what is a background task? context.Background is set from context not containerd afaict :/ what's the situation leading to this also?

it a dead task and ignore it. Without this fix a healthcheck with an
unendeding cat command could cause the task queue to eventually fill and

did we increase the queue at some point? undead cat are still user commands which we don't need to ignore

only a reboot would resolve it.

Closing this in favor of #11


Build version is not the right one for 1.24.0

File: compose/install.md
Mine is the following:
$ docker-compose --version
docker-compose version 1.24.0, build 0aa59064

Hm, yes, I think that part is just to illustrate  (the important bit is the version number) We should probably replace that part of the output with something like [build number] to make clear that it might not match your actual output
@ulyssessouza wdyt?

@thaJeztah in that case, is there an official document that list every build number for every docker-compose version ? I didn't find such a file...

The build-number is the commit that the version was built from, so in this case https://github.com/docker/compose/commit/0aa59064 those "should" match the corresponding tag on github; https://github.com/docker/compose/releases
However, I do see there's an inconsistency where the tag/release on GitHub uses the merge commit (https://github.com/docker/compose/commit/d9fa8158c39f9f4b9d60865e7cf44909b57f5c31), but the build using the commit itself; https://github.com/docker/compose/compare/0aa59064...d9fa8158c39f9f4b9d60865e7cf44909b57f5c31
Possibly something that should be addressed in the release scripts 🤔
If the purpose is to verify the downloaded binary though, you can use the checksums that are listed on the releases page for each release; https://github.com/docker/compose/releases/tag/1.24.0

@thaJeztah thank you for this precision. Indeed, I need to verify the downloaded binary.

Also had a quick chat with the compose maintainers, and the inconsistent commit was a known issue, which is being worked on as part of a rewrite of the release-tooling. The checksums should still be the best approach to verify the downloads though.


Move to Docker Compose V2 before June 2023

Compose V1 (the docker-compose command) is deprecated and will no longer ship with Docker Desktop after June 2023. We need to move all our projects to Docker Compose V2 (the docker compose command).

I think this is done


Windows defender detected trojan

Hi! I have a problem! After running for 5 hours somehow my windows defender if if i close it, he runned and found trojan when esrgan pytourch ai was eunning and from there i couldn't use it anymore.
I have this error even after a clean copy and windows defender turned off completly
if len(img.shape) < 3:
[Python] AttributeError: 'NoneType' object has no attribute 'shape'
[Queue] Stop()
Any idea what to do?

Problem solved! Few images from batch was the problem,after i deleted these is working


fix: bump version to 0.7.2

Checklist

[X] Used a personal fork of the feedstock to propose changes

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Add controller Support (and a few other changes)

Once I started getting into it, I noticed some other things to change, in addition to my goal of adding controller support. I hope that's alright :)
Here's the changelog I made while making my edits:
Improve Gamepad Support

Pressing A functions like the mouse left click, in conjunction with cursor location. "Clicking" outside the window works the same for controller and mouse.
Pressing B closes the window, just like any other menu in-game.
Window scrolls correctly with right thumbstick, using scroll amount in config.

Fix scrolling inconsistency - Mouse wheel didn't scroll by the configured value
Combined Mouse Left click with the equivalent controller button, so future controller support is easily maintained.
Make up/down arrow sprites functional (I don't know how to animate them like in the other game menus.)

Looks like this got merged into #35.

Yeah, wasn't my intention. I've literally never worked with someone else using Git or GitHub, so I'm just stumbling through it a bit.

I actually did a bit of research earlier, and now I know that I should put each feature in its own branch, so that I can do separate pull requests.

If you're willing, please do break your one pull request into separate pull requests. It's easier to review, discuss, and merge them that way. It also means I can review a small pull request when I have a bit of spare time, instead of waiting until I have more time to look into a combined set of changes. :)
The easiest way to do that would be to branch from the current develop, cherry-pick each change into the right branch, and submit a pull request for each branch.


Install issue - Ubuntu 20.04

Be sure to read the FAQ before submitting a new issue.

General description of bug:

What happened: Install failed with:
The following packages have unmet dependencies:
fastfetch : Depends: libc6 (>= 2.35) but 2.31-0ubuntu9.16 is to be installed
E: Unable to correct problems, you have held broken packages.

What should happen: Install should proceed smoothly

Fastfetch version used: 2.18.1

Did it work in an older version: No

Where did you get the binary: GitHub release

Does this issue still occur in the latest dev build? Yes

What file did you download?

https://github.com/fastfetch-cli/fastfetch/releases/download/2.18.1/fastfetch-linux-aarch64.deb
From: Carter Li @.>
Sent: Thursday, July 11, 2024 9:32 AM
To: fastfetch-cli/fastfetch @.>
Cc: PaPaTheGMan @.>; Author @.>
Subject: Re: [fastfetch-cli/fastfetch] Install issue - Ubuntu 20.04 (Issue #1088)
What file did you download?

Reply to this email directly, view it on GitHubhttps://github.com/fastfetch-cli/fastfetch/issues/1088#issuecomment-2222952606, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANTUBLGVJIT3RWB3OYVHHUTZL2COFAVCNFSM6AAAAABKW7QT6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRSHE2TENRQGY.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>

The aarch64 version was built.on Ubuntu 22.04. You should download the arm64 version.

Sorry to be a pest, but can you give me a link?  I do not see 'arm64' in list of 2.18.1 assets.
You may also want to change the Installation instructions as they say:
"Debian / Ubuntu: Download fastfetch-linux-.deb from Github release page and double-click it (for Ubuntu 20.04 or newer and Debian 11 or newer)."
My system is: Ubuntu 20.04.6 LTS aarch64
Thanks.
From: Carter Li @.>
Sent: Thursday, July 11, 2024 12:21 PM
To: fastfetch-cli/fastfetch @.>
Cc: PaPaTheGMan @.>; Author @.>
Subject: Re: [fastfetch-cli/fastfetch] Install issue - Ubuntu 20.04 (Issue #1088)
The aarch64 version was built.on Ubuntu 22.04. You should download the arm64 version.

Reply to this email directly, view it on GitHubhttps://github.com/fastfetch-cli/fastfetch/issues/1088#issuecomment-2223354956, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANTUBLEHXNUBJUKIUFQYSPLZL2WE5AVCNFSM6AAAAABKW7QT6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRTGM2TIOJVGY.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>

I meant amd64. Sorry

That suggested that your server is not supported.

Bummer, any plans to support it?
It's Ubuntu 20.04.6 LTS on aarch64 architecture.
From: Carter Li @.>
Sent: Thursday, July 11, 2024 10:15 PM
To: fastfetch-cli/fastfetch @.>
Cc: PaPaTheGMan @.>; Author @.>
Subject: Re: [fastfetch-cli/fastfetch] Install issue - Ubuntu 20.04 (Issue #1088)
That suggested that your server is not supported.

Reply to this email directly, view it on GitHubhttps://github.com/fastfetch-cli/fastfetch/issues/1088#issuecomment-2224300722, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANTUBLBPEWEREVESWEEJSLLZL43ZLAVCNFSM6AAAAABKW7QT6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRUGMYDANZSGI.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>

It's ARM64.  Here's the output of a lscpu inquiry:
Architecture:                 aarch64
CPU op-mode(s):        32-bit, 64-bit
Byte Order:                    Little Endian
CPU(s):                            4
On-line CPU(s) list:    0-3
Thread(s) per core:    1
Core(s) per socket:    4
Socket(s):                       1
Vendor ID:                      ARM
Model:                              4
Model name:                 Cortex-A53
Stepping:                        r0p4
CPU max MHz:             1248.0000
CPU min MHz:              480.0000
BogoMIPS:                     48.00
Flags:                                fp asimd evtstrm aes pmull sha1 sha2 crc32 cpuid
lsb_release shows:
Distributor ID: Ubuntu
Description:     Ubuntu 20.04.6 LTS
Release:             20.04
Codename:       focal
I hope this helps.
From: Tanzmusikus @.>
Sent: Monday, July 15, 2024 4:15 AM
To: fastfetch-cli/fastfetch @.>
Cc: PaPaTheGMan @.>; Mention @.>
Subject: Re: [fastfetch-cli/fastfetch] Install issue - Ubuntu 20.04 (Issue #1088)
@PaPaTheGManhttps://github.com/PaPaTheGMan
Does your server hardware based on ARM64 (aarch64) ... or on AMD64 (x86-64) architecture?
I coudn't find Ubuntu Server 20.04.6https://old-releases.ubuntu.com/releases/20.04/ for ARM64, only 20.04.5https://cdimage.ubuntu.com/releases/20.04.5/release/.
For Ubuntu Server AMD64 (x86-64) there exists a version 20.04.6https://releases.ubuntu.com/20.04.6/.

Reply to this email directly, view it on GitHubhttps://github.com/fastfetch-cli/fastfetch/issues/1088#issuecomment-2227932493, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANTUBLCKLKZPK7OP7S7QLPDZMOAILAVCNFSM6AAAAABKW7QT6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRXHEZTENBZGM.
  No, I didn't build this image.  It's a stock image for the NanoPi-NEO2-Black board from Friendly Elec.  Web home - https://www.friendlyelec.comhttps://www.friendlyelec.com/.  Wiki for this board - https://wiki.friendlyelec.com/wiki/index.php/NanoPi_NEO2_Black
From: Carter Li @.>
Sent: Thursday, July 25, 2024 10:19 PM
To: fastfetch-cli/fastfetch @.>
Cc: PaPaTheGMan @.>; Mention @.>
Subject: Re: [fastfetch-cli/fastfetch] Install issue - Ubuntu 20.04 (Issue #1088)
You build it yourself

Reply to this email directly, view it on GitHubhttps://github.com/fastfetch-cli/fastfetch/issues/1088#issuecomment-2251839942, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANTUBLGU34NWXWMD7YZMZA3ZOGWYFAVCNFSM6AAAAABKW7QT6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJRHAZTSOJUGI.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

It appears this is fixed in 2.21.0


Update nft to use StorageNMap

Closes: #504

Codecov Report

Merging #562 (da96af6) into master (81511f1) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #562      +/-   ##
==========================================
+ Coverage   72.58%   72.60%   +0.01%
==========================================
  Files          76       76
  Lines        5425     5425
==========================================
+ Hits         3938     3939       +1
+ Misses       1487     1486       -1

Impacted Files
Coverage Δ

nft/src/lib.rs
84.61% <100.00%> (ø)

authority/src/mock.rs
74.46% <0.00%> (+2.12%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81511f1...da96af6. Read the comment docs.


option to convert signed extrinsic rune back to extrinsic rune

Given
const ext = SignedExtrinsicRune.fromHex(westend, submit.signedExtrinsic)

would be nice if I could do ext.as(ExtrinsicRune) so I could extract the call hash.
This also necessary in general if you want to validate what is actually being sent to the node.

Can be done with the following
  const signedExtrinsicRune = SignedExtrinsicRune
    .fromHex(westend, submit.signedExtrinsic)
  const signedExtrinsicBytes = await signedExtrinsicRune.run()
  const metadata = await westend.metadata.run()

  const extrinsic = $extrinsic(metadata).decode(signedExtrinsicBytes)
  console.log(extrinsic)

and would produce
{
  protocolVersion: 4,
  signature: {
    sender: { address: [Object] },
    sig: { type: 'Sr25519', value: [Uint8Array] },
    extra: {
      CheckMortality: [Object],
      CheckNonce: 10,
      ChargeTransactionPayment: 0n
    }
  },
  call: {
    type: 'Balances',
    value: { type: 'transfer', dest: [Object], value: 12345n }
  }
}

Shall we implement this as an extrinsic method on SignedExtrinsicRune?

indeed we can!
https://github.com/paritytech/capi/pull/952


DeprecationWarnings with Python >= 3.7

Replicate this with:

a python setup.py --cython install install,

or a pip install bitstream==2.6.0.dev0

(since version 2.5.4 won't pip install with python 3.9).
Basic example :
>>> from bitstream import *
>>> BitStream(b"AB")
<stdin>:1: DeprecationWarning: The binary mode of fromstring is deprecated, as it behaves surprisingly on unicode inputs. Use frombuffer instead
0100000101000010

or in the test suite :
$ python test.py
/home/boisgera/VOYAGER/SANDBOX/bitstream/test.py:39: YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details.
  mkdocs_pages = yaml.load(open("mkdocs.yml"))["pages"]
<doctest index.md[1]>:1: DeprecationWarning: The binary mode of fromstring is deprecated, as it behaves surprisingly on unicode inputs. Use frombuffer instead
  BitStream(b"Hello World!")
<doctest index.md[5]>:1: DeprecationWarning: tostring() is deprecated. Use tobytes() instead.
  stream.read(bytes, 5) # doctest: +BYTES
<doctest examples.md[30]>:4: DeprecationWarning: The binary mode of fromstring is deprecated, as it behaves surprisingly on unicode inputs. Use frombuffer instead
  stream.write(datum, type)
<doctest examples.md[53]>:1: DeprecationWarning: tostring() is deprecated. Use tobytes() instead.
  wave_bytes = stream.read(bytes)
<doctest types.md[110]>:1: DeprecationWarning: The binary mode of fromstring is deprecated, as it behaves surprisingly on unicode inputs. Use frombuffer instead
  stream = BitStream(b"ABCD")
<doctest types.md[117]>:1: DeprecationWarning: tostring() is deprecated. Use tobytes() instead.
  stream.read(bytes, 1) # doctest: +BYTES
<doctest snapshots.md[3]>:1: DeprecationWarning: The binary mode of fromstring is deprecated, as it behaves surprisingly on unicode inputs. Use frombuffer instead
  stream = BitStream(wave)
<doctest snapshots.md[1]>:3: DeprecationWarning: tostring() is deprecated. Use tobytes() instead.
  riff = stream.read(bytes, 4)
<doctest snapshots.md[1]>:4: DeprecationWarning: tostring() is deprecated. Use tobytes() instead.
  _ = stream.read(bytes, 4)
<doctest snapshots.md[1]>:5: DeprecationWarning: tostring() is deprecated. Use tobytes() instead.
  wave = stream.read(bytes, 4)
<doctest snapshots.md[6]>:6: DeprecationWarning: tostring() is deprecated. Use tobytes() instead.
  wave = stream.read(bytes, 4)
<doctest snapshots.md[18]>:1: DeprecationWarning: tostring() is deprecated. Use tobytes() instead.
  stream.read(bytes) # doctest: +BYTES
<doctest snapshots.md[19]>:7: DeprecationWarning: tostring() is deprecated. Use tobytes() instead.
  base = stream.read(bytes, 1)
<doctest API.md[4]>:1: DeprecationWarning: The binary mode of fromstring is deprecated, as it behaves surprisingly on unicode inputs. Use frombuffer instead
  stream = BitStream(b"Hello", bytes)
<doctest API.md[14]>:1: DeprecationWarning: tostring() is deprecated. Use tobytes() instead.
  stream.read(bytes, 2) # doctest: +BYTES

Should be ok now (9b6a1e70ff310ed688a736ff03cad55ba569e345)


Dockerfile for building and previewing docs locally.

Fully documented instructions for building the entire documentation (including API reference) without relying on any external tools like readthedocs.org.  Dockerfile to run the docs build in a container so that all dependencies are explicitly modeled.  This will give people a reliable way to preview any docs changes they make with negligible setup and without needing explanation from anybody who knows how it's supposed to work.  Also instructions for fast iterative documentation development.

LGTM thanks


Facebook Bussiness Login config_id added

I have added a config_id for the facebook login for the business type login

That I have used for internal uses and forgot to revert it back.
On Sat, 16 Sep 2023 at 1:51 PM, Nguyen Manh Cuong @.***>
wrote:

@.**** commented on this pull request.
why do you remove dist in gitignore?
—
Reply to this email directly, view it on GitHub
https://github.com/cuongdevjs/reactjs-social-login/pull/132#pullrequestreview-1629926147,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYZATBURCJVROYJVWZ4BIMDX2VOR5ANCNFSM6AAAAAA4XOMYLI
.
You are receiving this because you authored the thread.Message ID:
@.***>

please remove unnecessary changed files and follow the file format. There are some redundant commits, although I appreciate your contribution but this doesn't guarantee the code standard.

Once I remove the other commits rather than the config_id change hope it’s
good to go for the pull merge. What do you think? We need the solution.
On Sun, 17 Sep 2023 at 11:39 AM, Nguyen Manh Cuong @.***>
wrote:

Closed #132 https://github.com/cuongdevjs/reactjs-social-login/pull/132.
—
Reply to this email directly, view it on GitHub
https://github.com/cuongdevjs/reactjs-social-login/pull/132#event-10390838119,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYZATBWDXUEDHYWCJL6JKYLX22HYNANCNFSM6AAAAAA4XOMYLI
.
You are receiving this because you authored the thread.Message ID:
@.***
com>

yep, please create a new PR with only the necessary changed file, and make sure you follow the formatting code that currently it has. Thank you.

Okay, thank you! I will do that and please merge that request. Thanks again
On Sun, 17 Sep 2023 at 12:01 PM, Nguyen Manh Cuong @.***>
wrote:

yep, please create a new PR with only the necessary changed file, and make
sure you follow the formatting code that currently it has. Thank you.
—
Reply to this email directly, view it on GitHub
https://github.com/cuongdevjs/reactjs-social-login/pull/132#issuecomment-1722405652,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYZATBRQ2RPVYSL7ZNICNWLX22KLFANCNFSM6AAAAAA4XOMYLI
.
You are receiving this because you authored the thread.Message ID:
@.***>


[WIP] Issue-347 Extract trading UI Refracting

[WIP] Issue-347 Extract trading UI Refracting

Hi @yivo , I have strictly followed your steps. Redirect all request of trading UI to Private::MarketsController. Please let me know if we need move that code to JWT.
I have also added CORS to gemfile, since on local we have to handle these on different ports locally. But on production it may not be required.
Please find the trading UI code at the following repository:-
https://github.com/skyach/peatio-trading-ui
Please let me know if you still need improvements.
@yivo , One more question I had, how are you going to link there 2 apps in development environment. For linking, I think, we ned to define the linking url in YML, which devs can change according to the domains, as on local it will behave differently than production.
Also, for the failing test cases, we either need to remove them from here or we need to add them in the trading ui app.

Hello @dinesh-skyach
Can you please remove rack-cors? It is not required since we have this already implemented in grape APIs (check API_CORS_ORIGINS). I would like to see the final code without dev stuff and then if it would be needed I will assign someone.
About tests – I think we need to remove them since I am sure it will be more unpossible to move them to peatio-trading-ui.

Hi @yivo , I have removed the development stuff and comments. I also have removed the used tests related to the moved code.
You may face problems in linking configuration, please let me know, if I can be of help to anyone, as I am not sure how you are going to present both repos, since this is not a seemless integration as we do in case of gems generally as there is a gap between local and production.
On Tests, I did not mean to shift them as it is, but to write on the peation-trading-ui separately. But anyways, I have removed them from here.

Hi @yivo I have made the changes.
Please let me know if you still need improvements.

@dinesh-skyach Have you migrated images & locales? Can you get access tokens at test.bitgo.com and test deposits / withdraws / trading & admin?

@yivo I have migrated images and locales. I have tested the site via adding balance from backend but will test the site thoroughly via using access tokens from test.bitgo.com.

@dinesh-skyach Do you need any help with bitgo?

@yivo I have tested the site and everything is working accordingly.

@yivo I have already rebased both trading UI and PR?

Hi @yivo , as per today’s call, are we going to make this a gem instead of a separate application? Or we are keeping this as it is?
Please let me know if we need to change this.

@dinesh-skyach Hello. We are going to extract UI to Rails Engine but keep trading as separate Rails app.

So we are moving to the same direction.

@dinesh-skyach Hi!
I have run your https://github.com/skyach/peatio-trading-ui and rapidly took a look
Here is few drawback I found

[ ] BTC html etc

[ ] Buy USD for USD

[ ]  Looks like this button changes after click (compare with original peatio trading)

[ ] Dash image was lost and LTC looks badly

[ ] USD markets filter doesn't work.  I have already fixed this in https://github.com/rubykube/peatio/pull/472 take a look

Hi @yssavchuk, Thanks for your feedback. I have fixed all the above issues. Kindly have a look and let me know if you have any feedback.
@yssavchuk  Also one question for the second issue "Buy USD for USD" I didn't get this. As we are buying BTC from USD, So how can this be BUY USD.

@dinesh-skyach Can you please rebase? We have now changes.

Hi @yivo I have already rebased.

@dinesh-skyach In the second issue I mean that price shoul be in USD and amount is BTC

@dinesh-skyach @yssavchuk Also these labels were uppercased before.

@yivo @yssavchuk I have already fixed this in above commits.

@yivo I have made the changes.
Let me know if still improvements are required.

Hi @yivo, I have rebased the PR. Also there are some changes to be made in petio trading UI. I will do this tomorrow.

@yivo I have rebased the PR and Peatio Trading UI.

@dinesh-skyach @yivo This task becomes urgent, what is our ETA and challenges to get this merged?
Do you guys think we can turn this into a rails engine installable on target rails?

@mod It sound logical to have tests in UI repository but it is not possible right since Peatio specs use lot of stubbing for these specs:

@yivo we need all the trading tests to be made using faraday can you open an issue ?


Code refactor to support SM v2 + v3

This PR contains the code refactor for support zend-servicemanager v2 and v3.

Looks great! One other thing to consider is doing a v2/v3 compatibility test class based on the new Zend\ServiceManager\Test\CommonPluginManagerTrait, as detailed in zendframework/zend-servicemanager#93. All told, though: this looks good to go.

@weierophinney do you mean to create a test class like ZendTest\Tag\Cloud\Decorator\DecoratorPluginManagerCompatibility that acts like this class?

do you mean to create a test class like

Yes, exactly!

Since this adds the compatibility test, the v2 version references for zend-servicemanager should likely all be ^2.7.5 and the v3 references ^3.0.3. I can do that on merge, though; patch looks great!


Add optional properties for TappedNavigationTab

Some implementations of tappedNavigationTab will involve context screens without ids or slugs (example: navigating from inboxBids to inboxInquiries or vice versa)

:rocket: PR was released in v1.67.1 :rocket:


Interface Styles: Menu text loses its drop shadow when alpha is dropped below 255

Screenshots

Environment (please complete the following information):

OS: Windows 10
RuneLite version: 1.6.33-SNAPSHOT

This is now fixed as of client patch 981291173.22

This is now fixed as of client patch 981291173.22


Proposal for WindowTabData tests.

This is an attempt to start with unit testing the WindowTabData struct and it's commands.
With the idea that when a bug is fixed, such as https://github.com/lapce/lapce/issues/3275, we can add a test for it so it doesn't come back again.
This is a draft, because there are still some problems that I am not sure what the best approach will be for, or whether this is even the correct testing direction in the first place. For example, the WindowTabData requires the LapceDb to exist. But that reads from real configuration files, which makes the test badly reproducable. Same for LapceConfig which is loaded in WindowTabData::new.

so it doesn't come back again.

The issue never came back, it wasn't implemented in the first place.

whether this is even the correct testing direction in the first place.

I'd much prefer people focused on https://github.com/lapce/floem/issues/8 rather than unit testing Lapce, as that issue would realistically allow for automation testing in CI.

whether this is even the correct testing direction in the first place.

I'd much prefer people focused on lapce/floem#8 rather than unit testing Lapce, as that issue would realistically allow for automation testing in CI.

That sounds like a better idea indeed 😄 . I'll close this issue.

I want to see some testing like that in Lapce in future, but from the current code layout it's terrible to implement which is why I'm hoping for accessibility/automation stuff in Floem.

keeping it open for future


FIX: removing duplicate method _format_results

Issue #, if available:
Description of changes:
Basic PEP8 corrections,
Removing _format_results from Classifier and Detector since it is moved to mother class.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Requesting review from @zhanghang1989 since he primarily worked on these files

Job PR-301-1 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-301/1/index.html

@aptsunny Could you review the changes?

Job PR-301-2 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-301/2/index.html

@Innixma , @zhanghang1989 , @aptsunny should I change something here ?

@aptsunny Please look into this and review to minimize churn in future merge conflicts

@Innixma , @zhanghang1989 , @aptsunny should I change something here ?

Thanks for the fix!

Job PR-301-3 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-301/3/index.html

@Innixma , @zhanghang1989 , @aptsunny should I change something here ?

Thanks for the fix!

Does the PR look good to you? If so, could you approve the PR

Job PR-301-4 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-301/4/index.html

Merging, thanks again for your contribution!


Support vue-cli@5

vue-cli@5 is stable now and @nx-plus/vue should drop support of vue-cli@4 and switch to 5.

+1, would be nice because vue-cli depends on some older versions of autoprefixer which in the end depends on postcss 7 and I need postcss 8 to upgrade from Tailwind 2 to 3.

This would be fantastic,  have a couple of dependencies just waiting for vue-cli@5

Hi,
I've forked your fantastic repository and updated vue-cli to version 5. It looks like there's no more need to overwrite chalk colors at first glance. I've dropped custom cache directories as well. From a first impression it looks good enough, I didn't test it much tbh.
Please let me know if this looks good enough to open a PR discussion.
show diff
kind regards,
Sebastian

@basti1253 Thanks for looking into this! I looked through your changes and they make sense so go ahead and open a PR. There are a few more deps I think we need to update so we are more in line with vue-cli but we can address those in the PR you open.
I'd like to create a migrations script as well so users get their deps bumped automatically but if you're not familiar with those I can follow that up once we get your changes in

Hey guys, any updates on the PR?

+1

@basti1253 would help very much if you can find the time to prepare the PR, so @ZachJW34 can review and work on the migrations.

I have recently published<EMAIL_ADDRESS>which now uses vue-cli v5 (webpack 5). I haven't published any docs/migrations yet but if you're curious you can try it out! It requires v15 of Nx.
I'm going to be working over the next week to write some docs and migrations so stay tuned!

@ZachJW34 do you plan to update @nx-plus/nuxt as well?

@ZachJW34 any update on the docs/migrations?


Desktop/ Web- Production server is displayed even if the staging server is enabled

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Issue found when executing #10935
Action Performed:

Open app on web
Go to Settings -> Preference
Use staging server is toggled ON
Open dev tool
Go to Network tab.
Focus on app and send some message.

Expected Result:
Verify that the request in Fetch/XHR is of staging server https://staging.expensify.com/
Actual Result:
The request shows always production server
Workaround:
Unknown
Platform:

Where is this issue occurring?

Web
Desktop App

Version Number: 1.2.0-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/189965104-49b6c59b-2564-47e5-932d-280b22a3e69b.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
View all open jobs on GitHub

Hmm, I don't see how to enable the staging server on web. Is this an error in the issue description @kavimuru?

Hmm confused by this one, https://github.com/Expensify/App/pull/10690 and https://github.com/Expensify/App/pull/10935 are the same PR, and the former was reverted in https://github.com/Expensify/App/pull/10920
https://github.com/Expensify/App/pull/10935 should be included in <IP_ADDRESS>, but somehow it doesn't seem to be. Still looking.

This is a problem with our GH CD/CI  which we encountered already once before. Discussing in Slack here

This should be fixed now, waiting for Applause to finish testing https://github.com/Expensify/App/pull/10935 again.

It was checked off by Applause, closing https://github.com/Expensify/App/issues/10958#issuecomment-1248436384


stream_settings: Use tooltips.

Changed the stream settings UI so that the buttons use tooltips instead of titles.

Separated out of #20536

LGTM.

@timabbott reviewed by @sahil839 -- please take a look.

This looks good except for the potential bug noted above.

Merged with the small adjustment noted above, thanks @juliaBichler01!


Improve full-content view legibility

Full content view is very useful. Please improve it by enabling justifying of text, e. g. by adding the following directive:
text-align: justify

to this section:
item p {

in the the file assets/css/app.css.

I don't like the idea of using justified alignment for the default theme. Justified text on the web is generally hard to read. You might want to read the following webpages about the topic:
https://www.castlegateit.co.uk/2013/09/can-justified-text-be-justifed-for-the-web/
http://designforhackers.com/blog/never-justify-type-on-the-web/
But since people have different preferences, you can create a new theme, which includes the default miniflux theme and overwrites the text alignment stuff. Checkout the existing 3rd party themes at https://github.com/miniflux and feel free to send a pull request to include your new theme.


block height

which function of this library outputs the last block height?

This one I guess:
https://docs.binance.org/api-swagger/index.html#api-Node-getNodeInfo


Fix test failure in PR for edits to DepositBootstrap and DepositFormApp

Turns out the solution we were looking at for the search algorithm isn't going to work as we designed it, at least for the core module. I'm closing this and will reconnect with Guillaume in the New Year to look at solutions.


Add tracing hello world

I added a hello world with tracing example.
You can see the readme here: https://github.com/sduskis/cloud-bigtable-examples/tree/add_tracing_hello_world/java/tracing-hello-world

The comments were addressed.  PTAL.


Adding support for Gradient and other and improvements

Pull Request Description
This pull request addresses various issues and introduces several enhancements and features to improve the functionality of the project. Here's a summary of the changes:
Fixes

Corrected the minify option that was not functioning properly.
Addressed the issue with the horizontal/vertical line transformation and rotation calculation.
Added support for missing group parameters in AVG files.

Features

Added support for gradient (fixes #5).
Introduced a feature to split icons into smaller chunks in case of large icons.
Added a silent run flag for improved control.
Enhanced SVG parsing by parsing clip path child in a group to clip-path data and applying transform attributes to generated paths.
Flattened groups with no parameters in icons and improved import logic for both paths and groups.
Added support for inherited attributes to search over parent tags in case of missing.
Added support for both <use> and <defs> node in SVG files.
Introduced compose brush colour representation and added AVG gradient node and its dependencies.

Refactorings

Improved import logic for both path and group in icons.
Ensured type consistency by adding SvgElementNode and SvgChildNode for SVG parsing, and AvgElementNode and AvgChildNode for AVG parsing.
Renamed the name property to tagName in XML processing.
Created ComposeColor type to represent the Color class on Compose.

@coderabbitai review

@coderabbitai review files under directory svg-to-compose/src/commonMain/kotlin/dev/tonholo/s2c/domain

@coderabbitai summary

@coderabbitai resume


Renaming K6 env variables

According to documentation (https://k6.io/docs/using-k6/options), it should be K6_ {param}. I found this bug while trying to run some tests. Setting K6_ prefix worked perfectly.

Nice catch! Thanks!

There's a new version 2.0.2 with this fix!


lodash: signatures of the method _.random changed

https://lodash.com/docs#random
https://lodash.com/docs#_ (description of the chainable wrapper)

thanks mate!