Unable to access tenant qualified authentication endpoint when accessing Saas applications

Describe the issue:
Enable tenant-qualified URL configuration in the product.
[tenant_context]
enable_tenant_qualified_urls= true
enable_tenanted_sessions= true

When accessing the SaaS application with tenant qualified URL (eg: https://localhost:9443/t/jack.com/console/), its redirects to super tenant authentication endpoint which doesn't let sub-tenant users to log in.

Root Cause:
User Tenant (ut) is the actual hint when the user trying to access any Saas application[1].
For example, the Console application is on Super Tenant but sub-tenant users also can access it via https://localhost:9443/t/test.com/console
Currently, we are checking for "/o/" in the request URL which is not used at the moment. Instead of this, we need to refer "/t/"
[1] - https://github.com/wso2/carbon-identity-framework/blob/6fa4a90a688dd4c52f4e558f34bf1f9fcddc3599/components/authentication-framework/org.wso2.carbon.identity.application.authentication.framework/src/main/java/org/wso2/carbon/identity/application/authentication/framework/handler/request/impl/DefaultRequestCoordinator.java#L612

This can be closed cause itf fixed with UNIFICATION, Console URL should be tenant qualified to access.


Generated code uses Serialize and Deserialize macros without importing them.

The current implementation of serde support relies on the caller to somehow import Serialize and Deserialize. Why not change the code from:
serde::write_serde_attr(w, &self.customize, "derive(Serialize, Deserialize)");
to:
serde::write_serde_attr(w, &self.customize, "derive(::serde::Serialize, ::serde::Deserialize)");
The main downside I see with this would be cases where the caller was relying on the use statement to apply a macro other than ::serde::Serialize or ::serde::Deserialize.
Here are the places this would be needed:
https://github.com/stepancheg/rust-protobuf/search?q=write_serde_attr+derive(Serialize

This is probably the same issue as #526


corectrl: 1.3.1 -> 1.3.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/corectrl/versions.
meta.description for corectrl is: Control your computer hardware via application profiles
meta.homepage for corectrl is: https://gitlab.com/corectrl/corectrl/
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.3.2 with grep in /nix/store/hzmmfa54wylzv1rd3ficrxn4mnh6ib6n-corectrl-1.3.2
found 1.3.2 in filename of file in /nix/store/hzmmfa54wylzv1rd3ficrxn4mnh6ib6n-corectrl-1.3.2

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
corectrl

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/hzmmfa54wylzv1rd3ficrxn4mnh6ib6n-corectrl-1.3.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A corectrl https://github.com/r-ryantm/nixpkgs/archive/7bbfab44a355f236f0be63a2b3c06fc68731bcb4.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/hzmmfa54wylzv1rd3ficrxn4mnh6ib6n-corectrl-1.3.2
ls -la /nix/store/hzmmfa54wylzv1rd3ficrxn4mnh6ib6n-corectrl-1.3.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

corectrl

Maintainer pings

Result of nixpkgs-review pr 218202 run on aarch64-linux 1

1 package built:

corectrl

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/corectrl/versions.
meta.description for corectrl is: Control your computer hardware via application profiles
meta.homepage for corectrl is: https://gitlab.com/corectrl/corectrl/
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.3.3 with grep in /nix/store/xphjqx7y323bpnpa9n0j3xsg4kdfziyw-corectrl-1.3.3
found 1.3.3 in filename of file in /nix/store/xphjqx7y323bpnpa9n0j3xsg4kdfziyw-corectrl-1.3.3

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
corectrl

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/xphjqx7y323bpnpa9n0j3xsg4kdfziyw-corectrl-1.3.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A corectrl https://github.com/r-ryantm/nixpkgs/archive/4ff23a502177f7918fa40f36b095a4842936746e.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/xphjqx7y323bpnpa9n0j3xsg4kdfziyw-corectrl-1.3.3
ls -la /nix/store/xphjqx7y323bpnpa9n0j3xsg4kdfziyw-corectrl-1.3.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

corectrl

Maintainer pings

@ofborg eval


Cannot be opened because the developer cannot be verified

Hi guys, i'm trying to use pocketbase locally but i get this error:
"pocketbase” cannot be opened because the developer cannot be verified

Thanks for your help.

This helped me solve it. https://support.apple.com/en-us/HT202491#:~:text=In System Preferences%2C click Security,“Allow apps downloaded from.”


remove unsigned

which does not make sense with a VARCHAR.
See also https://community.contao.org/de/showthread.php?75077-Datenbankfelder-werden-bei-dieschittigs-contao-recaptcha-nicht-angelegt where I suspect this as cause

This needs to be changed as well:
https://github.com/DieSchittigs/recaptcha-bundle/blob/7eb5e86b64851b924c75532b38301a0821628261/src/Resources/contao/dca/tl_content.php#L11


Add prometheus metrics

std go metrics
remote endpoint response time
API response time
bundle creation time
find master time

Example metrics from /metrics

# HELP api_request_serve_time Time taken to serve HTTP request
# TYPE api_request_serve_time histogram
api_request_serve_time_bucket{method="POST",path="/system/health/v1/report/diagnostics/create",status="503",le="0.005"} 0
api_request_serve_time_bucket{method="POST",path="/system/health/v1/report/diagnostics/create",status="503",le="0.01"} 1
api_request_serve_time_bucket{method="POST",path="/system/health/v1/report/diagnostics/create",status="503",le="0.025"} 1
api_request_serve_time_bucket{method="POST",path="/system/health/v1/report/diagnostics/create",status="503",le="0.05"} 1
api_request_serve_time_bucket{method="POST",path="/system/health/v1/report/diagnostics/create",status="503",le="0.1"} 1
api_request_serve_time_bucket{method="POST",path="/system/health/v1/report/diagnostics/create",status="503",le="0.25"} 1
api_request_serve_time_bucket{method="POST",path="/system/health/v1/report/diagnostics/create",status="503",le="0.5"} 1
api_request_serve_time_bucket{method="POST",path="/system/health/v1/report/diagnostics/create",status="503",le="1"} 1
api_request_serve_time_bucket{method="POST",path="/system/health/v1/report/diagnostics/create",status="503",le="2.5"} 1
api_request_serve_time_bucket{method="POST",path="/system/health/v1/report/diagnostics/create",status="503",le="5"} 1
api_request_serve_time_bucket{method="POST",path="/system/health/v1/report/diagnostics/create",status="503",le="10"} 1
api_request_serve_time_bucket{method="POST",path="/system/health/v1/report/diagnostics/create",status="503",le="+Inf"} 1
api_request_serve_time_sum{method="POST",path="/system/health/v1/report/diagnostics/create",status="503"} 0.007534433
api_request_serve_time_count{method="POST",path="/system/health/v1/report/diagnostics/create",status="503"} 1
# HELP find_master_node_time Time taken find single master node
# TYPE find_master_node_time histogram
find_master_node_time_bucket{le="0.005"} 0
find_master_node_time_bucket{le="0.01"} 1
find_master_node_time_bucket{le="0.025"} 1
find_master_node_time_bucket{le="0.05"} 1
find_master_node_time_bucket{le="0.1"} 1
find_master_node_time_bucket{le="0.25"} 1
find_master_node_time_bucket{le="0.5"} 1
find_master_node_time_bucket{le="1"} 1
find_master_node_time_bucket{le="2.5"} 1
find_master_node_time_bucket{le="5"} 1
find_master_node_time_bucket{le="10"} 1
find_master_node_time_bucket{le="+Inf"} 1
find_master_node_time_sum 0.007047835
find_master_node_time_count 1
# HELP go_gc_duration_seconds A summary of the GC invocation durations.
# TYPE go_gc_duration_seconds summary
go_gc_duration_seconds{quantile="0"} 0
go_gc_duration_seconds{quantile="0.25"} 0
go_gc_duration_seconds{quantile="0.5"} 0
go_gc_duration_seconds{quantile="0.75"} 0
go_gc_duration_seconds{quantile="1"} 0
go_gc_duration_seconds_sum 0
go_gc_duration_seconds_count 0
# HELP go_goroutines Number of goroutines that currently exist.
# TYPE go_goroutines gauge
go_goroutines 6
# HELP go_info Information about the Go environment.
# TYPE go_info gauge
go_info{version="go1.12"} 1
# HELP go_memstats_alloc_bytes Number of bytes allocated and still in use.
# TYPE go_memstats_alloc_bytes gauge
go_memstats_alloc_bytes 1.082864e+06
# HELP go_memstats_alloc_bytes_total Total number of bytes allocated, even if freed.
# TYPE go_memstats_alloc_bytes_total counter
go_memstats_alloc_bytes_total 1.082864e+06
# HELP go_memstats_buck_hash_sys_bytes Number of bytes used by the profiling bucket hash table.
# TYPE go_memstats_buck_hash_sys_bytes gauge
go_memstats_buck_hash_sys_bytes 3058
# HELP go_memstats_frees_total Total number of frees.
# TYPE go_memstats_frees_total counter
go_memstats_frees_total 1119
# HELP go_memstats_gc_cpu_fraction The fraction of this program's available CPU time used by the GC since the program started.
# TYPE go_memstats_gc_cpu_fraction gauge
go_memstats_gc_cpu_fraction 0
# HELP go_memstats_gc_sys_bytes Number of bytes used for garbage collection system metadata.
# TYPE go_memstats_gc_sys_bytes gauge
go_memstats_gc_sys_bytes 2.240512e+06
# HELP go_memstats_heap_alloc_bytes Number of heap bytes allocated and still in use.
# TYPE go_memstats_heap_alloc_bytes gauge
go_memstats_heap_alloc_bytes 1.082864e+06
# HELP go_memstats_heap_idle_bytes Number of heap bytes waiting to be used.
# TYPE go_memstats_heap_idle_bytes gauge
go_memstats_heap_idle_bytes 6.4315392e+07
# HELP go_memstats_heap_inuse_bytes Number of heap bytes that are in use.
# TYPE go_memstats_heap_inuse_bytes gauge
go_memstats_heap_inuse_bytes 2.33472e+06
# HELP go_memstats_heap_objects Number of allocated objects.
# TYPE go_memstats_heap_objects gauge
go_memstats_heap_objects 6062
# HELP go_memstats_heap_released_bytes Number of heap bytes released to OS.
# TYPE go_memstats_heap_released_bytes gauge
go_memstats_heap_released_bytes 0
# HELP go_memstats_heap_sys_bytes Number of heap bytes obtained from system.
# TYPE go_memstats_heap_sys_bytes gauge
go_memstats_heap_sys_bytes 6.6650112e+07
# HELP go_memstats_last_gc_time_seconds Number of seconds since 1970 of last garbage collection.
# TYPE go_memstats_last_gc_time_seconds gauge
go_memstats_last_gc_time_seconds 0
# HELP go_memstats_lookups_total Total number of pointer lookups.
# TYPE go_memstats_lookups_total counter
go_memstats_lookups_total 0
# HELP go_memstats_mallocs_total Total number of mallocs.
# TYPE go_memstats_mallocs_total counter
go_memstats_mallocs_total 7181
# HELP go_memstats_mcache_inuse_bytes Number of bytes in use by mcache structures.
# TYPE go_memstats_mcache_inuse_bytes gauge
go_memstats_mcache_inuse_bytes 13888
# HELP go_memstats_mcache_sys_bytes Number of bytes used for mcache structures obtained from system.
# TYPE go_memstats_mcache_sys_bytes gauge
go_memstats_mcache_sys_bytes 16384
# HELP go_memstats_mspan_inuse_bytes Number of bytes in use by mspan structures.
# TYPE go_memstats_mspan_inuse_bytes gauge
go_memstats_mspan_inuse_bytes 31536
# HELP go_memstats_mspan_sys_bytes Number of bytes used for mspan structures obtained from system.
# TYPE go_memstats_mspan_sys_bytes gauge
go_memstats_mspan_sys_bytes 32768
# HELP go_memstats_next_gc_bytes Number of heap bytes when next garbage collection will take place.
# TYPE go_memstats_next_gc_bytes gauge
go_memstats_next_gc_bytes 4.473924e+06
# HELP go_memstats_other_sys_bytes Number of bytes used for other system allocations.
# TYPE go_memstats_other_sys_bytes gauge
go_memstats_other_sys_bytes 1.051662e+06
# HELP go_memstats_stack_inuse_bytes Number of bytes in use by the stack allocator.
# TYPE go_memstats_stack_inuse_bytes gauge
go_memstats_stack_inuse_bytes 458752
# HELP go_memstats_stack_sys_bytes Number of bytes obtained from system for stack allocator.
# TYPE go_memstats_stack_sys_bytes gauge
go_memstats_stack_sys_bytes 458752
# HELP go_memstats_sys_bytes Number of bytes obtained from system.
# TYPE go_memstats_sys_bytes gauge
go_memstats_sys_bytes 7.0453248e+07
# HELP go_threads Number of OS threads created.
# TYPE go_threads gauge
go_threads 8
# HELP process_cpu_seconds_total Total user and system CPU time spent in seconds.
# TYPE process_cpu_seconds_total counter
process_cpu_seconds_total 0
# HELP process_max_fds Maximum number of open file descriptors.
# TYPE process_max_fds gauge
process_max_fds 1024
# HELP process_open_fds Number of open file descriptors.
# TYPE process_open_fds gauge
process_open_fds 7
# HELP process_resident_memory_bytes Resident memory size in bytes.
# TYPE process_resident_memory_bytes gauge
process_resident_memory_bytes 1.2750848e+07
# HELP process_start_time_seconds Start time of the process since unix epoch in seconds.
# TYPE process_start_time_seconds gauge
process_start_time_seconds 1.55187561532e+09
# HELP process_virtual_memory_bytes Virtual memory size in bytes.
# TYPE process_virtual_memory_bytes gauge
process_virtual_memory_bytes 5.92433152e+08
# HELP process_virtual_memory_max_bytes Maximum amount of virtual memory available in bytes.
# TYPE process_virtual_memory_max_bytes gauge
process_virtual_memory_max_bytes -1
# HELP promhttp_metric_handler_requests_in_flight Current number of scrapes being served.
# TYPE promhttp_metric_handler_requests_in_flight gauge
promhttp_metric_handler_requests_in_flight 1
# HELP promhttp_metric_handler_requests_total Total number of scrapes by HTTP status code.
# TYPE promhttp_metric_handler_requests_total counter
promhttp_metric_handler_requests_total{code="200"} 0
promhttp_metric_handler_requests_total{code="500"} 0
promhttp_metric_handler_requests_total{code="503"} 0

:wave:  @mrnugget @drewvanstone @br-lewis Can you review, please?

Codecov Report

Merging #92 into master will increase coverage by 0.43%.
The diff coverage is 87.5%.

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
+ Coverage   61.68%   62.11%   +0.43%
==========================================
  Files          19       20       +1
  Lines        1913     1948      +35
==========================================
+ Hits         1180     1210      +30
- Misses        612      617       +5
  Partials      121      121

Impacted Files
Coverage Δ

dcos/tools_linux.go
0% <ø> (ø)
:arrow_up:

api/diagnostics.go
76.11% <100%> (+0.21%)
:arrow_up:

dcos/tools.go
69.86% <100%> (+3.19%)
:arrow_up:

api/router.go
64.9% <100%> (+0.34%)
:arrow_up:

fetcher/fetcher.go
73.91% <100%> (+1.18%)
:arrow_up:

api/metrics_middleware.go
72.22% <72.22%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7017163...b0abe4c. Read the comment docs.


ttl conversion

The first pass conversion is done, get the conversion merged into git in a reproducible way.

closed via 01bc1735ed1dfd04a066c14bb3006d155a3ebe7c and previous commits


[CI] Update ubuntu-latest to ubuntu-22

Currently, github actions workflows are issuing a warning that ubuntu-latest which is ubuntu-20 will be deprecated.

Pull Request Labeler: .github#L1
ubuntu-latest workflows will use ubuntu-22.04 soon. For more details, see https://github.com/actions/runner-images/issues/6399

We will need to update ubuntu-latest to ubuntu-22.04 across all projects that uses this image.

Contributor Guides and Handbook

🛠 Meshery Build & Release Strategy
📚 Instructions for contributing to documentation

Meshery documentation site and source

🎨 Wireframes and designs for Meshery UI in Figma
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

@StarTrooper08 Sure, this is a good first issue and easy task to work on.

Hey @acald-creator
I've gone through a few meshery projects
And here are my observations
A list of workflows using ubuntu latest and a few action yml files are using ubuntu 18v(mentioned below)
Checked the following directory of the below projects
.github/workflows

meshery/meshery
meshery/meshery.io
(label-commenter.yml uses ubuntu18.04)
meshery/meshery-operator
meshery/meshkit
meshery/meshery-istio
meshery/meshery-linkerd
meshery/scoop-bucket
(label-commenter.yml uses ubuntu-18.04)

And meshery/meshsync project GH workflow yml files are up-to-date with ubuntu-22.04
So do we have to make changes in GH workflows that are using ubuntu-18.04?

@StarTrooper08 Any of the workflows that currently uses ubuntu-latest (ubuntu-20.04) or lower such as ubuntu 18.04 will needs to be updated to ubuntu-22.04

Hey, @acald-creator I've made the required changes in meshery/meshery GitHub actions workflows. Can you please review it.
Now I'm working on Meshery.io repository, will link PR to this issue here as I complete my work

@acald-creator I've created PR for the following issue for meshery-istio project.
Can you please review it


Add support for auto_weight counter

When loading data with many values, it takes time to manually handle the weight counter if you alter that data during development. By adding this config value, the script will increase the value for you and the weight will depend on the choices ordering.

Thanks for your PR. I like your idea. I would even go further:

Drop auto_weight_choices altogether (*)
If there is a weight on the choice, use that weight
Else use the index of the item. (e.g. the third item with index 2 gets a weight of 2)

As per https://stackoverflow.com/a/522578/172132, this should work:
for idx, choice_details in enumerate(cf_details.get('choices', [])):
  choice = CustomFieldChoice.objects.create(
             field=custom_field,
             value=choice_details['value'],
             weight=choice_details.get('weight', idx))

Such a scenario would become possible:
selection_field_auto_weight:
   type: selection
   label: Choose between items
   required: false
   filterable: true
   weight: 30
   on_objects:
    - dcim.models.Device
   choices:
    - value: A
    - value: B
    - value: C
    - value: "D like deprecated"
      weight: 999
    - value: E

The resulting weights would be: A=0, B=1, C=2, E=4 and the "D like deprecated"=999
(*) it's also an alien option there, as Netbox itself does not have such an option.

Sounds good to me. I will tinker some and get back with a update later.

@cimnine I think i fixed the review comments you asked for. Please review it again.

Also, please rebase your changes onto the latest master, or merge the latest master into your branch.

@cimnine Fixed all current review comments. Please review again.

@Grokzen Could you rebase this one again as well? Thanks!


babel-root-slash-import breaks Meteor build

The latest version of meteor-react-hotloader introduces .babelrc support.  But the babel-root-slash-import plugin breaks the Meteor build process, I get an error like:
 Error: Cannot find module '/home/dragon/www/tmp/mantra-sample-blog-app/lib/collections'
     at require (/home/dragon/www/tmp/mantra-sample-blog-app/.meteor/local/build/programs/server/packages/modules-runtime.js:95:19)
     at meteorInstall.server.configs.initial_adds.js (server/configs/initial_adds.js:3:16)
     at fileEvaluate (/home/dragon/www/tmp/mantra-sample-blog-app/.meteor/local/build/programs/server/packages/modules-runtime.js:158:9)
     at require (/home/dragon/www/tmp/mantra-sample-blog-app/.meteor/local/build/programs/server/packages/modules-runtime.js:92:16)
     at /home/dragon/www/tmp/mantra-sample-blog-app/.meteor/local/build/programs/server/app/app.js:269:1
     at /home/dragon/www/tmp/mantra-sample-blog-app/.meteor/local/build/programs/server/boot.js:281:10
     at Array.forEach (native)
     at Function._.each._.forEach (/home/dragon/.meteor/packages/meteor-tool/.1.2.4-rc.2.17279bz++os.linux.x86_64+web.browser+web.cordova/mt-os.linux.x86_64/dev_bundle/server-lib/node_modules/underscore/underscore.js:79:11)
     at /home/dragon/www/tmp/mantra-sample-blog-app/.meteor/local/build/programs/server/boot.js:133:5

I guess because this is emulating Meteor's behaviour outside of Meteor but inside of Meteor it overrides / breaks it :)  Not sure if this has been an issue with webpack:webpack too?  But inevitably Meteor will support .babelrc in post-1.3 anyway.
Hope this is the right place for this issue (the repo has issues disabled, but this is mostly about using it inside of Meteor which isn't it's original use case).  Not sure how you'd want to best handle this case.

I'm facing similar issue several days ago. But it seems MDG disable .babelrc support in beta.12.
But the babel-root-slash-import works fine for webpack:webpack package. You can check my ongoing project: https://github.com/ops-class/test161-web-ui

Ah oops, actually, I guess it works in webpack:webpack because Meteor's not building it there :>  Yeah, official .babelrc was disabled but it will be back post-1.3 and then this will be an issue again with official Meteor.  In the meantime, react-meteor-hotloader now re-introduces some better integrated .babelrc support usable today in 1.3-rc.2 (with the intention of submitting as a PR back to core).

Sure, the webpack:webpack takes over the building process. So it's fine.
It's an issue when Meteor enables .babelrc again.

I think if it's the time for .babelrc in meteor, we can try to use this only when mantra running tests rather doing this in the .babelrc.

Now if you update to the latest stable version of meteor, this issue will come. Ref : https://forums.meteor.com/t/1-3-3-imports-breaking/24890

Guys, I just introduce a new version of babel-root-slash-import which works properly inside Meteor.
I've updated this repo.


Fix oversized non-emoji rgba glyphs

Fixes #423 on oversized glyphs.

In general before landing this patch there should be a defence mechanism against corruption due to oversized glyphs in the texture atlas system first.

In general before landing this patch there should be a defence mechanism against corruption due to oversized glyphs in the texture atlas system first.

I've done that now as an "assert", because it's guarded earlier, and if something is leaking through, then it's a bug that should be reported and fixed rather than silently ignored.
Oversized glyphs however should not be a problem now anyways (famous last words). :)


allow to use UNLICENSED as license

This PR is a draft to fix #22.
It is a bit conservative, "using extra arguments in create()", and do not add {"private": true} in package.json.

see #25


Remove useless instantiation in RDShaderFile::parse_versions_from_text

The shader_file variable is unused.
Tested with post_shader demo.

Thanks!


Logo Grid: fix layout and size issues

Fixes #954
Logo Grid now uses the following logic:
Default breakpoint (mobile)
Items take up full width
Small breakpoint
Items take up half width
Medium breakpoint on up

If there are one or two items, each item takes 1/2 the available width
If there are more than two items, each item takes up 1/3 of the available width

Hey @Shashika6, could you give this a look when you have a chance?

Sure @justintemps

@Shashika6 I fixed the failing tests and added some. Now I'd like you to add two more tests please:

One test should make sure that when then are less than three items, the items take up half the available space
The second should make sure than when there are three items are more, the items take up a third of the available space

Make sure to account for the grid gap when checking the available space.

Hey @justintemps I added a test which checks if the row has 3 items when there are 3 or more items. We cant use the grid gap cause there is.a padding right that gets added to the container so its not accurate. I followed another approach let me know what you think.
I will get back into this further when I have configured the endpoint to pass in data in which we can do additional tests passing in 3 or less grid item data.
I will be starting on the endpoint refactoring and test expansion today.

Hey @justintemps I refactored this to use grid hope its okay :), I also added proper tests that checks if the it width matches the item widths as expected as well.

Thanks @Shashika6 but I think you missed an important part of the spec here, which is that at the desktop breakpoint, when there are one or two items, they take up half the available width.

Will fix this up @justintemps

@justintemps I did the changes so that it satisfies
Medium breakpoint

If there are one or two items, each item takes 1/2 the available width

Thanks @Shashika6, now you need to add a test for what happens when there are one or two items at the desktop breakpoint.

Hey @Shashika6 I went ahead and added the test for when there are less than three items at the desktop breakpoint.


clang 10 on ppc64le fails

Need to update gcc to 8.3.0 to fix this
This fails with,
In file included from mytest.cxx:1:
In file included from /home/centos/miniconda3/conda-bld/clang_packages_1586363477171/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/bin/../lib/gcc/powerpc64le-conda_cos7-linux-gnu/8.2.0/../../../../powerpc64le-conda_cos7-linux-gnu/include/c++/8.2.0/iostream:39:
In file included from /home/centos/miniconda3/conda-bld/clang_packages_1586363477171/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/bin/../lib/gcc/powerpc64le-conda_cos7-linux-gnu/8.2.0/../../../../powerpc64le-conda_cos7-linux-gnu/include/c++/8.2.0/ostream:38:
In file included from /home/centos/miniconda3/conda-bld/clang_packages_1586363477171/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/bin/../lib/gcc/powerpc64le-conda_cos7-linux-gnu/8.2.0/../../../../powerpc64le-conda_cos7-linux-gnu/include/c++/8.2.0/ios:42:
In file included from /home/centos/miniconda3/conda-bld/clang_packages_1586363477171/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/bin/../lib/gcc/powerpc64le-conda_cos7-linux-gnu/8.2.0/../../../../powerpc64le-conda_cos7-linux-gnu/include/c++/8.2.0/bits/ios_base.h:41:
In file included from /home/centos/miniconda3/conda-bld/clang_packages_1586363477171/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/bin/../lib/gcc/powerpc64le-conda_cos7-linux-gnu/8.2.0/../../../../powerpc64le-conda_cos7-linux-gnu/include/c++/8.2.0/bits/locale_classes.h:40:
In file included from /home/centos/miniconda3/conda-bld/clang_packages_1586363477171/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/bin/../lib/gcc/powerpc64le-conda_cos7-linux-gnu/8.2.0/../../../../powerpc64le-conda_cos7-linux-gnu/include/c++/8.2.0/string:52:
In file included from /home/centos/miniconda3/conda-bld/clang_packages_1586363477171/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/bin/../lib/gcc/powerpc64le-conda_cos7-linux-gnu/8.2.0/../../../../powerpc64le-conda_cos7-linux-gnu/include/c++/8.2.0/bits/basic_string.h:6391:
In file included from /home/centos/miniconda3/conda-bld/clang_packages_1586363477171/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/bin/../lib/gcc/powerpc64le-conda_cos7-linux-gnu/8.2.0/../../../../powerpc64le-conda_cos7-linux-gnu/include/c++/8.2.0/ext/string_conversions.h:41:
In file included from /home/centos/miniconda3/conda-bld/clang_packages_1586363477171/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/bin/../lib/gcc/powerpc64le-conda_cos7-linux-gnu/8.2.0/../../../../powerpc64le-conda_cos7-linux-gnu/include/c++/8.2.0/cstdlib:77:
/home/centos/miniconda3/conda-bld/clang_packages_1586363477171/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/bin/../lib/gcc/powerpc64le-conda_cos7-linux-gnu/8.2.0/../../../../powerpc64le-conda_cos7-linux-gnu/include/c++/8.2.0/bits/std_abs.h:102:7: error: __float128 is not supported on this target
  abs(__float128 __x)
      ^
/home/centos/miniconda3/conda-bld/clang_packages_1586363477171/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/bin/../lib/gcc/powerpc64le-conda_cos7-linux-gnu/8.2.0/../../../../powerpc64le-conda_cos7-linux-gnu/include/c++/8.2.0/bits/std_abs.h:101:3: error: __float128 is not supported on this target
  __float128

Fixed with gcc 8.4.0


[moby] Use containerd for Windows container execution

Container will have Windows support in version 1.3.
This work stream is about moving moby off of Windows HCS and rely on containerd.
This is needed rather imminently for the upcoming Docker release.
This is primarily driven by John Howard, but requires review upstream: https://github.com/moby/moby/pull/38541

[x] Review 38541
[x] Get 38541 merged
[ ] CI/build (upstream)

Everything has been merged.
Docker Inc is working with John Howard (MSFT) on CI infra.


add Unique page name and id checker + tests

Coverage increased (+4.2%) to 29.772% when pulling a9a67e899daeceef19bcb01d2dec7ef9d97bf862 on CheckPageForUniqueName into 1438af6b47aa1db5f063d2213eb2de78764038fe on master.


Expose a public RSS Feed

It would be nice import links to feedly using RSS feed.

I'm not following. What's the relation to Slack?

Actually, none.
The idea is to have a URL for example http://digest.d3.do/feed and then use a rss feed aggregator (like feedly) to follow new links.

Oh, now I got it.
Sounds nice! Feel free to fork and implement. :shipit:

Oh damn! That is what I was afraid of! :-). But I will... Thanks

i want it.
Em seg, 25 de abr de 2016 às 12:29, Victor Gama<EMAIL_ADDRESS>escreveu:

Oh, now I got it.
Sounds nice! Feel free to fork and implement. [image: :shipit:]
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/d3estudio/d3-digest/issues/3#issuecomment-214395081

There's demand, @fbueno. 😛


Update Readme to show prefab/scene usage

What the top said. :)
This poor dev nearly missed out on your quality feature!
https://www.reddit.com/r/Unity3D/comments/12d1fu6/comment/jf4s7hc/?utm_source=share&utm_medium=web2x&context=3

Added to my to-do list. Thanks!


Update font-et-book to latest

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Closes #1339.

@vitorgalvao Is switching from svn to a Github archive okay in this case?


.truncate does not removes HTML as mentioned

example
truncate("foo bar baz", 5);
//=> '<span'

test would be
    it('should truncate by removing all HTML tags', function() {
      utils.truncate('foo bar baz', 5).should.equal('foo b');
    });

using https://github.com/ericnorris/striptags seems good way to go with

thanks for letting me know. want to do a pr?

Yea, maybe I can come to it tomorrow. Are you okey to go with striptags?

sure


⚠ Bofrost.at has degraded performance

In 4fdc9fc, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2429 ms

Resolved: Bofrost.at performance has improved in 6d87a4c after 6 minutes.


adding on_delete argument in model

Changed

adding on_delete argument in the model

Coverage remained the same at ?% when pulling cfa680da16b993f1e1a64773dd92fe9ad699abf4 on bmyanti:bug/adding_on_delete_argument_in_models into c9d5405fed7db2d79ec5c93c721a8fe42ea86958 on raphaelgyory:master.


It's impossible to generate a manifest for primary bundles only

Even if you filter by fastq as the file format, copy-forward makes it so that the manifest mentions analysis bundles, too, since they also reference the primary input fastq files.
Other than eliminating copy-forward, I don's see a way to implement this. When the Azul indexer encounters an analysis bundle, the copy-forwarded files are not easily distinguishable from the ones that are unique to the analysis bundle. We'd have to apply some serious domain knowledge about the make-up of those bundles to do that. That's obviously brittle and not desirable.
The analysis bundle references the input bundle and we could try to load the input bundle and subtract its manifest from that of the analysis bundle, essentially undoing copy-forward.
┆Issue Number: HCAB-409

Originally reported in https://github.com/HumanCellAtlas/data-browser/issues/498

Dedup is implemented and reduces the impact of this issue.

Obsolete DCP/1 issue.


Add invoker plugin

Adds autocomplete for the invoker gem
more details about the gem at
http://invoker.codemancers.com
and https://github.com/code-mancers/invoker

Not popular enough.


invalid user/password message when email not verified

When you register and your haven't yet verified your email through the link, if you try to connect, you get an error message that your user/pwd is invalid.
You should rather get a message saying you need to verify your email 1rst

This is the django auth internal behavior, can't be fixed except by rewriting django internals... see https://forum.djangoproject.com/t/error-message-for-inactive-users-that-try-to-login/20374/5


tests: move hana tests out of mandatory action

Currently the HANA tests are not stable inside the github action runner. To prevent them from blocking valid changes the tests are being moved to their own job.

Currently the repository has the Hana tests as mandatory. I can't adjust the settings to make it optional.

Currently the repository has the Hana tests as mandatory. I can't adjust the settings to make it optional.

i have added you to cap-js/admins


line spacing is different after rebuilding fonts from Glyphs sources

Hi there,
when rebuilding the FiraCode fonts [1] from their Glyphs source for the Debian package, their vertical line spacing is significantly different from the fonts bundled in the release. Please compare the two screenshots provided in the Debian bug report [2].
I don't know if line spacing is an export option in the Glyhps app of if it is calculated automatically from the sources, but it would probably help to provide a means to manipulate this value somehow.
Thanks,

Fabian

[1] https://github.com/tonsky/FiraCode
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=919721

Just genned the source with fontmake v.1.8.1 and diffed it against the latest tagged release, https://github.com/tonsky/FiraCode/releases/tag/1.206
The hhea metrics differ:
table               attrib              value_a             value_b
hhea                descent             -265                -200
hhea                ascent              935                 739

When I inspect the source, we can see no hhea metrics have been defined.

I'm guessing the tagged releases have been genned using glyphsapp which treats generating non specified hhea metrics differently to fontmake?
Adding the following hhea customParameters for each master should solve this,.
(
        {
        hheaAscender = 935;
    },
        {
        hheaDescender = "-265";
    },
        {
        hheaLineGap = 0;
    }
)

ufo2ft seems to use the metrics to the left of the "Alignment Zones" box if they aren't explicitly defined (ascender is ascender + typoLineGap, which is zero here).
The 1.206 release from https://github.com/tonsky/FiraCode/releases has the following metrics set in FiraCode-Regular.ttf:

hhea table

ascent: 935
descent: -265
lineGap: 0

OS/2 table

sTypoAscender: 935
sTypoDescender: -265
sTypoLineGap: 0
usWinAscent: 935
usWinDescent: 265

@m4rc1e this answer is correct. I suggest you upstream this.
Not sure if it's worth replicating this behavior in glyphsLib.

Not sure if it's worth replicating this behavior in glyphsLib.

Please do so, I found the different line spacings between both generated fonts (i.e. GlyphsApp and Fontmake) quite jarring.


isValidating from useSWRInfinite is an empty string after mutate()

Bug report
Description / Observed Behavior
isValidating from useSWRInfinite is an empty string ("") after mutate() is called for an errored request.
The sequence is:

useSWRInfinite...
isValidating is true (correct)
request fails with 500, isValidating is false (correct)
mutate() is called (the same is with mutate(undefined, false) and mutate(undefined, true)
isValidating becomes an empty string

Expected Behavior
isValidating should always be a boolean.
Repro Steps / Code Example
const { data, error, size, setSize, isValidating, mutate } = useSWRInfinite(
  getKeyWrapped,
  fetcher,
  swrOptions,
);

console.log('isValidating:', typeof isValidating, isValidating);
// ...
// mutate()
// ...
console.log('isValidating:', typeof isValidating, isValidating);

For a request that fails with status code 500, I am getting the following output:
isValidating: boolean true
isValidating: string
Additional Context
SWR version: 0.5.6

@maciej-lepb Could you provide a CodeSandbox project to  re-produce this?

@koba04 Seeing this as well, only happens on the first time that useSWR key switches from null to a string. Reproduction: https://codesandbox.io/s/fragrant-snow-pih92?file=/pages/index.js

It seems to be fixed with swr@beta: https://codesandbox.io/s/affectionate-margulis-52s8n.


分享到微信没有缩略图

I agree and want to create new issue

[x ] Yes, I was on Hexo Docs page, especially on Templates, Variables, Helpers and Troubleshooting.
[ x] Yes, I was on NexT Documentation Site.
[ x] And yes, I already searched for current issues and this is not help to me.

Expected behavior

我的博客中含有图片，我预期把他分享到朋友圈（使用QQ浏览器）之后，能够像人们常见的公众号文章出现缩略图，这样看起来要美观好多。

Actual behavior
没有缩略图，只有一个链接标志。
Steps to reproduce the behavior
Link to demo site with this issue: N/A
Link(s) to source code or any usefull link(s): N/A
NexT Information
NexT Version:

[ x] Master
[ ] Latest Release
[ ] Old version -

NexT Scheme:

[ ] All schemes
[ ] Muse
[ x] Mist
[ ] Pisces

Other Information

@myjeshurun can u explain in English?

Yes. When I share to wechat, I want to present my page with a thumbnail
image, like the first item in the picture; but what I get is the second one
without a thumbnail picture.
Thank you.
Blessings in Christ,
Jeshurun
我的仆人雅各，我所拣选的耶书崙哪，不要害怕！
Don’t be afraid, Jacob my servant; and you, Jeshurun, whom I have chosen.
On Tue, Aug 8, 2017 at 11:04 PM, Ivan.Nginx<EMAIL_ADDRESS>wrote:

@myjeshurun https://github.com/myjeshurun can u explain in English?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/iissnan/hexo-theme-next/issues/1802#issuecomment-321139536,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVdc3BrrxJzLI-5HBEGUVi58kHLbvUp2ks5sWSGygaJpZM4OunR7
.

@myjeshurun about what pictures u speak?

@starry-s exactly. Thx.
On Wed, Aug 16, 2017, 07:09 STARRY-S<EMAIL_ADDRESS>wrote:

@ivan-nginx https://github.com/ivan-nginx I think he means like this.
[image: test-image]
https://user-images.githubusercontent.com/21214244/29360619-586e7c18-82b6-11e7-98cc-39a24a2b1322.jpg
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/iissnan/hexo-theme-next/issues/1802#issuecomment-322737877,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVdc3BX0JcaYQEYCFJX8BhpfGvUrHmwDks5sYs3SgaJpZM4OunR7
.

@myjeshurun 缩略图是微信自己生成的，要求图片大于300px x 300px

是的，但即使我blog中有图片也不会出现缩略图，但简书jianshu.com 上的文章就会。
On 2017年9月4日周一 08:53 whyliam<EMAIL_ADDRESS>wrote:

@myjeshurun https://github.com/myjeshurun 缩略图是微信自己生成的，要求图片大于300px x
300px
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/iissnan/hexo-theme-next/issues/1802#issuecomment-326956137,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVdc3MTfNxFMqrvgthXxPGgeFmlIz7UGks5se_KugaJpZM4OunR7
.

@myjeshurun 简书，亚马逊这些八成是对 bot 抓取做了特殊优化了，要求一个静态页面做到相同效果似乎是很难的。
The website that is capable of generating thumbnails when linked by chatting app probably handle crawlers specifically by dynamically generating response based on user-agent, it doesn't seemed possible for Hexo to do the same.

OK. Now I understand. Thank you for your explanation.
On Thu, Sep 14, 2017, 16:33 Haocen<EMAIL_ADDRESS>wrote:

@myjeshurun https://github.com/myjeshurun 简书，亚马逊这些八成是对 bot
抓取做了特殊优化了，要求一个静态页面做到相同效果似乎是很难的。
The website that is capable of generating thumbnails when linked by
chatting app probably handle crawlers specifically by dynamically
generating response based on user-agent, it doesn't seemed possible for
Hexo to do the same.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/iissnan/hexo-theme-next/issues/1802#issuecomment-329600778,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVdc3PbmxpbyCmbmvpmOJSqkbD3JfDdmks5siY2LgaJpZM4OunR7
.

微信要求网站已经注册公众号且在页面上引入他们的 JSSDK 才能自定义缩略图。
It has been confirmed WeChat JSSDK has to be used in order to allow the crawler parse the content.
At the meantime your website has to be registered on WeChat public channels.

is there a way to use JSSDK on the hexo website?
Blessings in Christ,
Jeshurun
我的仆人雅各，我所拣选的耶书崙哪，不要害怕！
Don’t be afraid, Jacob my servant; and you, Jeshurun, whom I have chosen.
On Mon, Sep 18, 2017 at 1:51 PM, Haocen<EMAIL_ADDRESS>wrote:

微信要求网站已经注册公众号且在页面上引入他们的 JSSDK 才能自定义缩略图。
It has been confirmed WeChat JSSDK has to be used in order to allow the
crawler parse the content.
At the meantime your website has to be registered on WeChat public
channels.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/iissnan/hexo-theme-next/issues/1802#issuecomment-330303446,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVdc3FhcDPa2kIu4K-dqPPTExrFvPkGUks5sjq2RgaJpZM4OunR7
.

Obviously the answer is yes, but you have to research it yourself, if you have access to WeChat JSSDK and registered as public channel.
You're welcomed to make a PR once you figure out a solution.

@Haocen this issue may be closed?

微信要求网站已经注册公众号且在页面上引入他们的 JSSDK 才能自定义缩略图。

NexT is rebased into organization repo.
If you want new feature, fix, or support, create new in NexT v6.x repo (desirable in English).
There is instructions on English or Chinese how to update from v5.1.x to v 6.x
You also may read this for details.


closeThreshold not working as expected when direction="left"

When swiping from right to left, swipeAmount is negative.
https://github.com/emilkowalski/vaul/blob/40d3a69825df25e04ffe1e52c99c3461d785f31a/src/index.tsx#L578
Using absolute values may solve this problem.
if (Math.abs(swipeAmount) >= visibleDrawerHeight * closeThreshold) {

In addition, when the direction is horizontal, visibleDrawerWidth needs to be calculated instead of visibleDrawerHeight.

Merged #386


allow partials and views to be passed block elements

updated PR to allow views / partials to have blocks passed into them, adds the new constant view variable _block

Not sure I follow, how would this be used?

LGTM + docs! :100:


turbolinks behavior

When linking to other content in my book (e.g., HTML slides served by remarkJS) turbolinks causes a number of problems.  The trick is to turn off Turbolinks processing manually per link.  Lecture 1.  This might be something useful for the manual since it isn't obvious that all the links (even if they are sort of "external" to the book but internal to the website) are being accelerated like this.  Happy to push a change if it makes sense and I'm not thinking of this wrong.

Hey @gureckis - sorry for missing this one, it somehow didn't cross my feed.
I'm not sure that I totally understand the problem that Turbolinks is causing - is it specifically problems with links that point within the same domain but that aren't pointing to book content?
A PR with a description of the problem along with a workaround to the docs would be great!

oh sorry, turbo links makes the pages load quick by keeping the current page in place and swapping out the body (merging the head) with the current page.  it applies this to the domain level or at least within the book (I haven't tested to figure out which).  the merging the head thing means that if there is a link to a raw html page inside the jupyter book structure (e.g., inside your 'content' folder that additionally isn't part of the book formatting ^1) then turbo links tries to load that file into the "book" HTML body and merges the js/css headers.  as a result different javascript libraries start conflicting with one another and the page doesn't reliably load in all cases.  the fix was to turn off Turbolinks manually for this particular internal link.
[1] in my case it is remark.js slides but you can imagine anytime someone wanted to distribute HTML content with their book that is not formatted exactly like the book structure this could cause CSS or javascript conflicts.  it isn't a jupyterbook bug per-se, more like a thing authors might want to know in the "advanced" docs in case the implications of the Turbolinks dependence isn't clear.

That's a helpful explanation, thanks. Wanna make it a PR in the docs, maybe on the "advanced" page?

Closing as this should be superceded by beta.jupyterbook.org


Update documentation code snippets to use new subo docs feature

I wanna take this up. Can you please elaborate the task?

There are some additional complexities that haven't been solved yet here (where should tests files live, etc.) so we'll table this issue for now.


pip install does not work

Am I doing something wrong?
 $ pip install sistr_cmd
Collecting sistr_cmd
  Could not find a version that satisfies the requirement sistr_cmd (from versions: )
No matching distribution found for sistr_cmd

 $ pip install sistr-cmd
Collecting sistr-cmd
  Could not find a version that satisfies the requirement sistr-cmd (from versions: )
No matching distribution found for sistr-cmd

 $ pip install https://pypi.python.org/pypi/sistr-cmd
Collecting https://pypi.python.org/pypi/sistr-cmd
  Downloading sistr-cmd
  Cannot unpack file /tmp/pip-xN21Ox-unpack/sistr-cmd (downloaded from /tmp/pip-mMFxWk-build, content-type: text/html; charset=utf-8); cannot detect archive format
Cannot determine archive format of /tmp/pip-mMFxWk-build

It looks like the files I uploaded to PyPI were removed without notification. I wasn't able to find any info about it on the PyPI website or elsewhere on the web. I also can't re-upload the files I had uploaded. I get an error saying "This filename has previously been used, you should use a different version."
One workaround for now is to install from the github repo:
pip install<EMAIL_ADDRESS>
I'll make a new release and try again with PyPI.

Thanks @peterk87


docker 1.10 regression: does not respond to basic auth 401 challenge as it did for previous versions

I have a private docker registry listening at https://<IP_ADDRESS>:19301
The docker daemon is configured as follows:
/usr/bin/docker daemon -H fd:// --insecure-registry <IP_ADDRESS>:19301

It is also using an http proxy using this setting:
Environment="HTTP_PROXY=http://<IP_ADDRESS>:8888/"

1.9.1 docker client
docker pull <IP_ADDRESS>:19301/ubuntu

This completes as expected.

client makes a request to GET https://<IP_ADDRESS>:19301/v2/
server responds with 401
client makes a request to GET https://<IP_ADDRESS>:19301/v1/repositories/ubuntu/images
server responds with the various images and eventually pull completes as expected

1.10.1 docker client
While making no changes on the server/registry side, use a docker 1.10.1 client and daemon:
docker pull <IP_ADDRESS>:19301/ubuntu

This fails:

client makes a request to GET https://<IP_ADDRESS>:19301/v2/
server responds with 401
client makes a request to GET http://<IP_ADDRESS>:19301/v2/
server is not listening as HTTP on that port, it is listening as HTTPS so this request fails
the docker CLI prints this message:

osboxes@osboxes:~/dev/docker-test/docker1.10$ docker pull <IP_ADDRESS>:19301/ubuntu
Using default tag: latest
Error response from daemon: Get http://<IP_ADDRESS>:19301/v2/: EOF

Expected

maintain backward compatibility of client behaviour
do not downgrade from secure connection to insecure connection ( bad practice to perform this downgrade transparently and clearly does not make sense to attempt to use plain http on an already confirmed https port )
document any incompatible changes and any expected new server behaviour for registry/docker API implementors

If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
For more information about reporting issues, see CONTRIBUTING.md.
You don't have to include this information if this is a feature request
(This is an automated, informational response)

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

This may be related to #20097

I wanted to point out that if i do not use the --insecure-registry argument, and copy the CA certificate to the global or docker specific location instead, things work as expected with 1.10.2

and copy the CA certificate to the global or docker specific location instead,

Where were the certificates before?

Where were the certificates before?

I used --insecure-registry to avoid putting them anywhere on the host running docker daemon. Isn't that a valid use case of --insecure-registry? to bypass certificate trust problems?

Hm, looks like this PR may fix that situation on master; https://github.com/docker/docker/pull/20253

Confirming the comment above; #20253 fixes this behavior.
In the mean time, installing the certs and avoiding --insecure-registry can work around this. I try to encourage people not to use --insecure-registry, because aside from the terrible security implications, it also has poorly defined semantics, since it means the registry may be using either HTTP or HTTPS.

thx @aaronlehmann - Sonatype has published an article which discourages use of insecure-registry and provides alternative steps to generate a self-signed certificate.


I keep crashing.

Whenever I use the most recent upload, I crash. This has probably been said before, I just want to know if you are working on an updated version or a fixed version. Thanks.

yea, same :/

I don't remember exactly since this happened a while ago, but the issue has probably been fixed


Fix hyperlink URL to correct page for fallbacks

previous URL was pointing to a dead page (404)

Thanks for raising this PR but this link I believe is generated via payments-service
https://github.com/gocardless/payments-service/blob/master/docs/schema-2015-07-06/schemata/billing_request.yml#L61
I can raise a PR to resolve this

I have raised a PR here https://github.com/gocardless/payments-service/pull/41891/files

Closing as per @amprew's comment.


A long year modifier breaks error message

$ bookwyrm -a asd -y "aaaaaaaaaaaaaa1a"
error: unrecognised year modifier '; see --help

expected output:
$ bookwyrm -a asd -y "aaaaaaaaaaaaaa1a"
error: unrecognised year modifier 'aaaaaaaaaaaaaa'; see --help

A year modifier of >= 14 characters breaks the message for some reason.
Printing mod_str doesn't give the whole string.
Related code: https://github.com/Tmplt/bookwyrm/blob/master/src/item.cpp#L35-L77

No longer valid in b1e1d197e58e51f6e435bd46100007f3a9ca694f (v0.5.0). Now "malformed year" is simply printed.


Docs: link to flagging section from descriptions of -flag-

This should help with questions like
https://github.com/newsboat/newsboat/issues/2966#issuecomment-2564826796.

coverage: 61.019%. remained the same
when pulling 29b4c299f091be4d4e5d1fba016a153c0ae3001e on feature/doc-link-to-flagging-section-from-remote-apis-starring-paragraphs
into ad44602cea8d1831c5d675da193af586082caae1 on master.

Ah, thank you for spotting and fixing that! Happy new year to you too ^_^


Resetting the color palette

I know you said a soft terminal reset doesn't reset the palette, and a hard reset isn't ideal because it takes a long time, but I have an idea for another method you could try. According to the documentation, when entering or exiting Tektronix mode, the VT340 "sets the output map to the factory-default state, or the state specified in set-up", which sounds to me like a palette reset.
Essentially something like this:
printf "\e[?38h\e[?38l"

I've tried this on the VT240, and it seems to work there. It does also clear the screen, which isn't ideal, but it's definitely faster than a full RIS reset.

One other issue I noticed is that on the VT240 this sequence also disables DECAWM (auto wrap mode) which seems a bit weird. And it's not like it's resetting it to the state specified in setup - it's always turned off regardless. But maybe this is just a VT240 thing, and it's not that hard to reenable it anyway.

printf "\e[?38h\e[?38l"

Clears the screen but does not reset the color palette.
Auto wrap mode is not modified. That definitely sounds like a bug in the VT240 firmware; the Tektronix screens didn't have autowrap, if I recall correctly.

Clears the screen but does not reset the color palette.

Damn. I was convinced that was going to work. But maybe there are some benefits to that, because that suggests you can control the Tektronix colors by setting the palette beforehand (which doesn't work on the VT240).
Anyway thanks for testing. I don't have any other ideas, so feel free to close this.

Oh and this is also something for the errata document. The escape sequence for DECSTGLT is given as CSI Ps ) } while I believe it should be CSI Ps ) {. The code point values beneath the text are correct though.

Very interesting! I think they may not have documented it before because the behaviour seems kind of glitchy.
So, first switching to monochrome then back to colormap 1 does reset the palette to the factory defaults.  It does not recall the user's saved colormap from Color Set-Up, nor does there seem to be a way to tell it to switch to the user's preferred Color Map saved in Global Set-Up.
While it works, there are a couple glitches that make it less ideal.
First, switching to Colormap-2 produces reverse background colors that are much darker than in Colormap-1. Sending an inquiry for the color table report shows no difference in the RGB values. This glitch also occurs when I switch to Colormap-2 from the Global Set-Up menu instead of using the escape sequence. This is most obvious in the status line at the bottom which is always printed in reverse.
Second glitch is that random rectangles of old text gets splatted on the screen when switching colortables. It is not clear what causes text to be saved or how it gets picked to be drawn on the screen other than it appears to happen close to where the cursor is.
I think the safest bet, if attempting to use this sequence, would be to always clear the screen after sending DECSTGLT. Something like,
CSI=$'\e['
echo ${CSI}'0){'${CSI}'1){'${CSI}'2J'

I'm going to have to read up more on these color lookup tables as I'm not seeing any benefit of having a second one. If I change the colors while Colormap-1 is active then switch to Colormap-2, I find its colors have changed, too. Without a way to programmatically Recall a Saved Color Map, there seems little point in being able to select which one is active.

Oh and this is also something for the errata document. The escape sequence for DECSTGLT is given as CSI Ps ) } while I believe it should be CSI Ps ) {. The code point values beneath the text are correct though.

Yes, you are correct. } does not seem to do anything.

First, switching to Colormap-2 produces reverse background colors that are much darker than in Colormap-1.

This I think is intended to emulate the VT240. The VT240 had only 4 colors, and no support for the ANSI SGR color sequences. So the best you could do was switch the text color from green to red (color map 3 to 2) using the bold rendition attribute. To get one more color, there was a mode in the settings called "Mono+Color", which made the reverse rendition attribute map to color 1, typically blue (I'm not completely sure of the details, though, because I think the MAME emulator has got the color attributes hooked up incorrectly).
So in order to emulate this behavior on the VT340, I think you are supposed to select color map 2 (which should function the same way as the "Mono+Color" mode on the VT240). Only now the mappings are slightly different: normal rendition maps to 7, the bold rendition maps to 15, and the reverse rendition maps to 8. So if you wanted to get the same default colors as the VT240 you would setup the color map so that color 7 was green, color 15 was red, and color 8 was blue.

If you want to read more docs on the subject, there is some info in the DEC STD-070 manual in section <IP_ADDRESS>, Alternative Text Rendition Mapping. This is listed as page 5-112, which for me is page 367 in the PDF.
There in also some info in the VT330/340 Text Programming reference in Appendix C,  Bold and Negative-Image Character Attributes. This is listed as page 288, which for me is page 302 in the PDF (the new second edition you got recently).

Oh that's neat. I just checked in Firefox and the pages work correctly there. I was using Edge as my pdf viewer, because it used to be way better than the other browsers, but it's gone downhill since they switched to Chromium.

First, switching to Colormap-2 produces reverse background colors that are much darker than in Colormap-1.

So in order to emulate this behavior on the VT340, I think you are supposed to select color map 2 (which should function the same way as the "Mono+Color" mode on the VT240). Only now the mappings are slightly different: normal rendition maps to 7, the bold rendition maps to 15, and the reverse rendition maps to 8. So if you wanted to get the same default colors as the VT240 you would setup the color map so that color 7 was green, color 15 was red, and color 8 was blue.

I'm not following that last part with the colors since I don't know the VT240 at all, but I think that's okay.
Does this sound right?
In the VT340,  the second colormap is used to assign a specific colortable entry for the reverse highlight color.  In colormap 1, which is the normal case, reverse video colors the text background using the foreground text color (entry number 7 in the color map). Colormap 2 uses color number 8 instead.

Color Map 1
Color Map 2

Text Foreground
7
7

Text Background
0
0

Reverse Text Foreground
0
0

Reverse Text Background
7
8

Bold Text Foreground
15
15

Bold Text Background
0
0

Bold & Reverse Text Foreground
?0
?0

Bold & Reverse Text Background
?15
?8

(I need to double check the behaviour of text with both the Bold and Reverse attibutes).

In case it helps, these are screen caps showing the color tables on MAME's VT240 implementation. I'm not positive that MAME has got these mappings correct, though. In particular I wasn't expecting the normal text and bright text colors to have switched in color table 2.
But it does at least show that the reverse attribute is getting you access to another one of the color table entries. I was hoping there was a way to access that color without being reversed, though, otherwise I don't really see the point, but maybe I've misunderstood the purpose of this mapping.

Actually, now that I'm looking at all three of them together, I think I understand.
On monochrome devices, when the reverse attribute is applied, the background color is actually dimmer than it would have been when it was foreground. This is because the phosphor bleeds into the unlit portion of the display, so the letters would become unreadable if the background was too bright. If you look at a VT100, you'll see the same thing.
So that's why the monochrome colors have the normal rendition as light gray on black, but it's black on dark gray when reversed. Similarly the bright rendition is white on black, but black on light gray when reversed.
And color table 2 exactly matches the color positions of that monochrome mapping, it's just no longer a monochrome palette. This explains why it's called Mono+Color in the settings. It's a color palette, but it should still look reasonable on a monochrome monitor (whereas color table 1 probably wouldn't).

That is an good hypothesis. It makes sense to me more than anything else does and it correctly predicts the bright reverse color scheme. Here's the final chart and a Media Copy of the screens.

Color Map 1
Color Map 2

Text Foreground
7
7

Text Background
0
0

Reverse Text Foreground
0
0

Reverse Text Background
7
8

Bright Text Foreground
15
15

Bright Text Background
0
0

Bright & Reverse Text Foreground
0
0

Bright & Reverse Text Background
15
7

Interestingly, the VT340 remembers what text that was drawn in the previous colormap and does not change its color when switching between colormaps 1 and 2. So, you can show text with both colormaps 1 and 2 simultaneously. Sort of.
The VT340 only remembers one previous colormap. All previously drawn text gets assigned that colormap, no matter what colormap it was actually drawn with. So you can switch colormaps once, but any more won't work as expected.
I'm surprised that they implemented this feature as I'm not sure of the value of it. But, given that they did, I'm also surprised they didn't allow switching back and forth between colormaps 1 & 2. Without any increase in memory usage, DEC could have checked if the previous colormap is equal to the new colormap DECSTGLT is requesting. If so, then any previously existing text would have the "use previous colormap" attribute toggled. If not, then all existing text gets assigned the "use previous colormap" attribute.

Interestingly, the VT340 remembers what text that was drawn in the previous colormap and does not change its color when switching between colormaps 1 and 2. So, you can show text with both colormaps 1 and 2 simultaneously. Sort of.

I'm not sure I've correctly understood what you're saying, but my theory is as follows:

Each of the SGR attribute combinations has a foreground and background color index assigned to it, exactly as you've listed them in the table above.
When you write out some text with a given set of attributes, what is stored in the buffer is not the attributes, but the index values that are currently assigned to those attributes.
Changing from one color map to the other will change the attribute-index mapping, but can't affect the index values that have already been written to the buffer.
Changing the color palette itself should affect the text that has been written out, though, because now you're changing the actual color associated with a given index.

Example test case:
echo -e '\e[1){'                 # Select color map 1
echo -e '\e[7m COLOR 07 \e[m'    # This should use color 7 for the background
echo -e '\e[1;7m COLOR 15 \e[m'  # This should use color 15 for the background

echo -e '\e[2){'                 # Select color map 2
echo -e '\e[7m COLOR 08 \e[m'    # This should use color 8 for the background
echo -e '\e[1;7m COLOR 07 \e[m'  # This should use color 7 for the background

echo -e '\eP2$p7;2;100;0;0\e\\'  # Set color 7 to red
echo -e '\eP2$p8;2;0;100;0\e\\'  # Set color 8 to green
echo -e '\eP2$p15;2;0;0;100\e\\' # Set color 15 to blue

If my theory is correct, those 4 lines of text should be displayed in red, blue, green, and red again.
If that does work, an interesting follow-up would be to see what happens when you throw the monochrome color map into the mix. The chances are it's also just using index values 7 and 15, but it's possible it could actually be using 13 and 3 instead.

Background is red, blue, green, and then (perhaps my eyes are deceiving me) the last one looks reddish-orange.

What is the "attribute-index mapping"?

I just meant there's a mapping that says something like "reverse background" maps to index 7, and "bright reverse background" maps to index 15, like in the table you did above. This is the same concept as the DECATC mapping on the VT525.
But seeing your screenshot now, my hypothesis can't be completely correct, and I understand now what you meant when you said it only remembers one previous colormap. I was assuming that the pixels written out in the "COLOR 07" text would be stored in the graphics buffer with the value 7. So a palette change could update all index 7 pixels to another color, but you shouldn't have some being blue and others being red.
So I don't know now. I need to think about this some more. It's not that I particularly care about emulating this behavior exactly, but I'm curious to understand how it's actually producing the output you're seeing.


Add support for luacov config path

Closes #659
Adding support for a cli or config option coverage-config-file to allow setting the path the your luacov config file, in case it is not at .luacov in the project root.

LGTM!

@DorianGray If I may ask, what is the release cycle for this project and when could we expect this merged?

as soon as someone else takes a look. We're ready to make a release now...we were waiting on a fix from someone but they seem to have disappeared

we will do a release soon. Apologies for not merging - new baby 4 days ago, no time to test

Okay no problem! That sounds good. And congratulations on the new baby! 🎂

looks good. One question; if a config-file is provided and the Luacov option is not enabled, what should happen?

an error because your specifying an unused config file
automatically enable luacov
nothing, just execute without luacov

if a config-file is provided and the Luacov option is not enabled, what should happen?

I am of the mind that it should have no effect and just execute without luacov, and not just because it is the easiest implementation.
I think it makes sense from a workflow perspective to be able to have the path to your coverage config file configured but still run the framework without running coverage. Say you clone of a project without an adequate development environment (no Luacov installed), it's easier to just run without --coverage, or with --no-coverage, or remove coverage = true from the busted config file, than it is to remove the setting for coverage config file. That's my opinion at least.

@Tieske It looks like the github actions environment is not able to create files. Maybe there's still something I'm doing wrong. Do you have any suggestions?

@nicholaschiasson instead of in the local directory store it as a temp file?

am I right that the problem wasn't creating the files, but that LuaCov wasn't installed?

am I right that the problem wasn't creating the files, but that LuaCov wasn't installed?

That's right that was it :sweat_smile: Took me far too long to realize!

Thx @nicholaschiasson !


[Feature]The utils configuration files are centrally managed under common

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

Codecov Report

Merging #9706 (fe58825) into dev (48d526f) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #9706      +/-   ##
============================================
- Coverage     40.01%   40.00%   -0.02%
+ Complexity     4475     4472       -3
============================================
  Files           835      835
  Lines         33550    33550
  Branches       3710     3710
============================================
- Hits          13426    13422       -4
- Misses        18876    18881       +5
+ Partials       1248     1247       -1

Impacted Files
Coverage Δ

...org/apache/dolphinscheduler/remote/utils/Host.java
37.77% <0.00%> (-2.23%)
:arrow_down:

...dolphinscheduler/remote/future/ResponseFuture.java
81.96% <0.00%> (-1.64%)
:arrow_down:

...e/dolphinscheduler/remote/NettyRemotingClient.java
52.11% <0.00%> (-1.41%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48d526f...fe58825. Read the comment docs.


[FLINK-3103] Remove synchronization in FsStateBackend#FsCheckpointStateOutputStream#close()

Stephan made the following comment:
I would actually suggest to not use a lock in the close() methods either. In a single threaded use, there is really no need for these locks.

As some context: The class does not lock on all calls that can modify the state of the buffers (such as every write() call, for performance), so the locking removed in this PR becomes not effective anyways.
+1, will merge this...

Thank you for the fix!
This was merged, but not automatically closed. Could you close it manually?


cpubench1a v3 unfair to non AMD64 CPUs

v3 uses go 1.17 which comes with a new way of passing function arguments and results using registers instead of the stack. However, this optimization was only implemented for AMD64.
Consequence: the v3 results when comparing Intel/AMD and ARM CPUs are biased.
go 1.18 will extend the new ABI to other 64 bits architectures including Aarch64 (i.e. ARM) for all OS. This should fix the bias.


IConfigurationChangedEvent.tabFocusMode never resets to false

monaco-editor version: 0.17.0
Browser: Edge (Chromium) Version <IP_ADDRESS> (Official build) dev (64-bit)
OS: Windows 10
Steps or JS usage snippet reproducing the issue:

add handler for onDidChangeConfiguration
on editor surface, press Ctrl+M to toggle tab focus mode change
event is raised and IConfigurationChangedEvent.tabFocusMode will be true, as expected
on editor surface, press Ctrl+M again to toggle tab focus mode (back to false)
IConfigurationChangedEvent.tabFocusMode is still true

issue can be reproduced in the playground.
var editor = monaco.editor.create(document.getElementById("container"), {
	value: "function hello() {\n\talert('Hello world!');\n}",
	language: "javascript"
});

editor.onDidChangeConfiguration((e) => {
    alert("Tab focus mode is " + e.tabFocusMode);
});

The change event contains only booleans. The booleans indicate which properties have changed, so IConfigurationChangedEvent.tabFocusMode means:

true when tabFocusMode has changed from false->true or from true->false
false when tabFocusMode has remained unchanged false->false or true->true.


The shadows in gvr-shadows "jump"

I haven't seen this before but today I am. The shadows kind of "jump" every once in a while. Maybe I am just doing something wrong. I picked up the binaries from the 3.1 prerelease and build with those. Tested on Note5. @NolaDonato Could you please double-check?
video.zip

Confirmed as a bug. @NolaDonato and @deepakrawat22 are looking into it.

What I am seeing is that the entire scene appears to flicker to black periodically as the light moves around.

this can be closed now, right?

Yes. Fixed.


fix(export): Remove duplicate header entries when doing full export

Some old projects may have custom attributes named as common ones (images, categories, taxCategories, ...etc). This code will go through generated header and remove duplicate entries.

Coverage increased (+0.07%) to 88.151% when pulling db8915db4ce564b713d8bfdb67eb0b62edbb7342 on fix-duplicate-header-entries into cf1303d81c0d1df579253c3919ae2a5714deb71a on master.

what do you think about marking reserved fields like in https://github.com/sphereio/sphere-node-product-csv-sync/blob/master/data/template_sample.csv
in there the buitin flags _published and _hasStagedChanges start with an underscore

@junajan any update on this?

@stmeissner @hisabimbola - Last info I got about this issue was, that only old projects can have this issue because attribute names on a new project are restricted from using names as name, attributes, prices, .. and so on.
Not sure if the restriction is also for _published and _hasStagedChanges words.
What do you think I should do here? Should I remove attributes with those names or will we discard this PR?

your thoughts? @stmeissner

@junajan @hisabimbola Not sure who asked for it, i have no problem with discarding this

I will discard this PR because it is relevant only to old projects and should not appear on new projects anymore.


[Feat]:Add style.yml File for ISSUE_TEMPLATES

Is your feature request related to a problem? Please describe.
style.yml (Custom ISSUE_TEMPLATE):

The style.yml file, on the other hand, serves as a custom ISSUE_TEMPLATE for issues related to coding style, code formatting, and linting rules within your GitHub repository. This template helps contributors or users report code style-related concerns or seek guidance on adhering to the project's coding standards.
The contents of style.yml might include specific questions or prompts related to coding style, requesting users to provide examples of code snippets that need formatting adjustments or explanation. Additionally, you might include instructions on how to check code against the project's style guidelines and best practices.

Describe the solution you'd like.
Follow above Issue
Describe alternatives you've considered.
No response
Additional context.
No response
Show us the magic with screenshots
No response
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I want to work on this issue. (optional)
[X] I am a GSSoC'23 contributor

Hi @AnirudhPanda . Please Review on this Issue as soon as Possible. Thank You !


UML-2514 - Redirect to maintnenace service

Purpose
Host maintenance outside of ual infra
Fixes UML-2514
Approach

add a temporary redirect from /maintenance to the maintenance service for ual

Learning

https://docs.aws.amazon.com/elasticloadbalancing/latest/application/load-balancer-listeners.html#redirect-actions
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/lb_listener_rule

Checklist

[ ] I have performed a self-review of my own code
[ ] I have added relevant logging with appropriate levels to my code
[ ] New event_codes have been documented on the wiki page
[ ] I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
[ ] I have added tests to prove my work
[ ] I have added welsh translation tags and updated translation files
[ ] I have run an accessibility tool on any pages I have made changes to and fixed any issues found
[ ] I have notified the Interaction Designer of any content changes so that appropriate screenshots/flow diagram changes can be made
[ ] The product team have tested these changes

This proves the concept of switching to maintenance by redirecting to an externally hosted service


Can no longer remove Users from a Project

What kind of request is this (question/bug/enhancement/feature request):
bug
Steps to reproduce (least amount of steps as possible):
Setups local users
Create a project
Add users as a project member to the project and save.
Result:
Edit the project and you will notice the minus sign does not appear next any of the new users

Other details that may be helpful:
I've seen this on a rancher setup that uses LDAP for user when logged in via LDAP users too. This also appears to happen with rancher setup for 100% local users.
I've used chrome and firefox reproduce.
Environment information

Rancher version: 2.4.1
Installation option (single install/HA): HA via helm

Similar to #24934. UI Workaround right now is to navigate to the Project and select "Members"

@rancher-max that's only for local users, but if we use other Auth we can't do that. Just checked this with OpenLDAP.

Validated in master-2720-head (3c6eb2b74) and v2.4-2718-head (64cf5ecd0) using ui-index latest2 and latest-2.4, respectively

Minus button is present again when editing the project
Using the minus button works to remove those users from the project now as well

Reopening because there is no minus button when adding users on initial project creation and there should be.

Validated using ui-index latest2 and latest-2.4
This is working now for both edit projects and new projects. Validated the same as in the previous comment.


Popups are the same transparency as dashboard cards with transparent themes, which makes everything hard to read.

I fixed this with card_mod and a mod card to change the background color of each popup menu, but I have several dozen of these across several dashboards and it's getting crazy managing them all. Plus when you use a mod card, you can't edit cards in the GUI.
I've tried a lot of a workarounds. I have been editing the iOS theme for a couple hours and I've gotten nowhere. Apparently 'ha-card-background' sets the background color of all cards no matter what. There doesn't appear to be a way to differentiate between cards on the dash and popup menus.
I tried Popup Backdrop Filter in HACS, but it doesn't seem compatible. Also Frosted Cards. I have also been wondering if I could apply card_mod the dashboard cards and not the popup cards, but I haven't found a way to do this.
There are a lot of options here: the background could be blurred, or dimmed. Or the card itself could have its background blurred. Or we could find a way to differentiate between cards on the dash and cards in a popup without the need for card_mod CSS in every popup so their opacities could be set separately.
Any ideas?

Hi and thanks for your feedback. Can you tell me what is the theme you are using? I will take a look at that.

I tried a lot of them, but the main two are:
https://github.com/basnijholt/lovelace-ios-dark-mode-theme
https://github.com/orickcorreia/caule-themes-pack-1
Both available in HACs.

First, thanks for a really cool card!
Continuing on the above, the separator line also have an opacity which make it almost invisible on a lot of themes.
I've never made any card for HA and have no idea how the structure is, but there would probably be great if there in some way a lot of the hard coded css could be made into global variables for the bubble card so it would be easier to adjust for different themes.
The same is also for the margins of the horizontal-stack. The margins for me is a little bit off, leaving a gap on the right side of the screen. I've tried to fix this but it seems like the horizontal stack is regenerated and hence all the styling is overwritten.
Thanks again for great work!

@jondavidsson I agree and this is in my plans, for the gap this depend of the themes, I've added a margin variable to fix that:

@jondavidsson I agree and this is in my plans, for the gap this depend of the themes, I've added a margin variable to fix that:

Great to hear about your plans! Since my time is extremely limited (small children) I'll sit in the boat and wait for the updated releases 😀
Also, thanks for the pointers to the manual. I've missed that update 🤦🏻♂ 😆

There is now a lot more styling options directly available in the GUI editor in the v1.1.0 🥳
https://github.com/Clooos/Bubble-Card/releases/tag/v1.1.0


Missing python module for loading .pdf files. with memgpt load directory

Describe the bug
When loading directories with many common file types:
` File "/home/max/MemGPT/venv/lib/python3.11/site-packages/llama_index/readers/file/docs_reader.py", line 25, in load_data
raise ImportError(
ImportError: pypdf is required to read PDF files: pip install pypdf
works properly after pip install pypdf
`
Please describe your setup

[x] MemGPT version: 0.2.6
[x] How did you install memgpt? pip install pymemgpt
[x] Describe your setup

What's your OS: Windows 11 and Debian Linux
How are you running memgpt? Multiple cmd.exe, Powershell, Terminal

Hmm this is odd - pypdf should be inside the package: https://github.com/cpacker/MemGPT/blob/main/pyproject.toml#L50
@sarahwooders any idea why this might not be getting picked up? Or possible error during install?


#102 WIP: modified assertRevert test helper

Require statement messages are still not bubbling up though. Using pragma solidity 0.4.22. #102

I'm currently waiting on this answer, really.
https://ethereum.stackexchange.com/questions/30063/consuming-require-errors-in-web3-js-client
Even on Remix, while the error message surfaces with Javascript VM, it doesn't with Web3.


[3.x] Crash when reparenting some nodes and deleting former parent.

Godot version
30fe807fa9eeca2039b8c25ee7775b23c12ce3b4
System information
OS: Arch Linux, CPU: Ryzen 5, GUP: RX 480
Issue description
The issue seems to be caused by reparenting collision shapes and deleting the previous rigid body parent.
When, after reparenting, the collision shape is added to the tree and then deleted/removed from the tree, a crash or error happens.
The error is:
E 0:00:00.387   erase: Condition "p_I->data != this" is true. Returned: false
  <C++ Source>  ./core/list.h:150 @ erase()
  <Stack Trace> CollisionShapeReparentingCrash.gd:13 @ _ready()

I have done some debugging and it seems related to the owner being the former parent and being deleted. I added some print() statements to the MRP. Godot always crashes when I try to print the owner of the reparented child after it was deleted.
Steps to reproduce
Open the MRP in the editor and run the scene named CollisionShapeReparentingCrash.tscn
A crash will happen at the last print() statement.
Remove the print statement and you'll get an error. I was not able to reproduce it exactly as in my main project but there I get a crash instead.
The crash/error doesn't seem to show up if the rigid body is not a sub-scene or with other types of node.
Minimal reproduction project
collision_shape_reparenting_crash.zip

@Chaosus I think this should be for the  3.5 milestone. I haven't tested it on 4.0

So, I think I fixed it locally. I added some lines of code before this line. This is the code I added:
	for (List<Node*>::Element *E = data.owned.front(); E; E = E->next()) {
		E->get()->set_owner(nullptr);
	}
	if (data.owner) {
		data.owner->data.owned.erase(data.OW);
	}

Should I create a PR?

=================================================================
==35270==ERROR: AddressSanitizer: heap-use-after-free on address 0x619000133d90 at pc 0x000012682ae5 bp 0x7ffdcf595730 sp 0x7ffdcf595720
READ of size 8 at 0x619000133d90 thread T0
    #0 0x12682ae4 in Variant::Variant(Object const*) core/variant.cpp:2168
    #1 0x9433ce0 in MethodBind0RC<Node*>::call(Object*, Variant const**, int, Variant::CallError&) core/method_bind.gen.inc:593
    #2 0x121cd553 in ClassDB::get_property(Object*, StringName const&, Variant&) core/class_db.cpp:1046
    #3 0x1243a61c in Object::get(StringName const&, bool*) const core/object.cpp:499
    #4 0x12875e66 in Variant::get_named(StringName const&, bool*) const core/variant_op.cpp:1699
    #5 0x1eb2916 in GDScriptFunction::call(GDScriptInstance*, Variant const**, int, Variant::CallError&, GDScriptFunction::CallState*) modules/gdscript/gdscript_function.cpp:636
    #6 0x1cf3941 in GDScriptInstance::_ml_call_reversed(GDScript*, StringName const&, Variant const**, int) modules/gdscript/gdscript.cpp:1214
    #7 0x1cf3bf7 in GDScriptInstance::call_multilevel_reversed(StringName const&, Variant const**, int) modules/gdscript/gdscript.cpp:1220
    #8 0xca1e284 in Node::_notification(int) scene/main/node.cpp:146
    #9 0x1b9a52d in Node::_notificationv(int, bool) scene/main/node.h:45
    #10 0x1bc4bd5 in Spatial::_notificationv(int, bool) scene/3d/spatial.h:52
    #11 0x12448382 in Object::notification(int, bool) core/object.cpp:927
    #12 0xca1fd39 in Node::_propagate_ready() scene/main/node.cpp:179
    #13 0xca1f590 in Node::_propagate_ready() scene/main/node.cpp:171
    #14 0xca737ea in Node::_set_tree(SceneTree*) scene/main/node.cpp:2592
    #15 0xcb3b088 in SceneTree::init() scene/main/scene_tree.cpp:473
    #16 0x18ac1a9 in OS_X11::run() platform/x11/os_x11.cpp:3697
    #17 0x18150ae in main platform/x11/godot_x11.cpp:55
    #18 0x7fc8d6a2bfcf in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58
    #19 0x7fc8d6a2c07c in __libc_start_main_impl ../csu/libc-start.c:409
    #20 0x1814ccd in _start (/usr/bin/godots+0x1814ccd)

0x619000133d90 is located 16 bytes inside of 1056-byte region [0x619000133d80,0x6190001341a0)
freed by thread T0 here:
    #0 0x7fc8d79ae40f in __interceptor_free ../../../../src/libsanitizer/asan/asan_malloc_linux.cc:122
    #1 0x129dba7c in Memory::free_static(void*, bool) core/os/memory.cpp:168
    #2 0x19e7194 in void memdelete<Object>(Object*) core/os/memory.h:117
    #3 0x12447396 in Object::call(StringName const&, Variant const**, int, Variant::CallError&) core/object.cpp:891
    #4 0x126da088 in Variant::call_ptr(StringName const&, Variant const**, int, Variant*, Variant::CallError&) core/variant_call.cpp:1185
    #5 0x1ec4abf in GDScriptFunction::call(GDScriptInstance*, Variant const**, int, Variant::CallError&, GDScriptFunction::CallState*) modules/gdscript/gdscript_function.cpp:1046
    #6 0x1cf3941 in GDScriptInstance::_ml_call_reversed(GDScript*, StringName const&, Variant const**, int) modules/gdscript/gdscript.cpp:1214
    #7 0x1cf3bf7 in GDScriptInstance::call_multilevel_reversed(StringName const&, Variant const**, int) modules/gdscript/gdscript.cpp:1220
    #8 0xca1e284 in Node::_notification(int) scene/main/node.cpp:146
    #9 0x1b9a52d in Node::_notificationv(int, bool) scene/main/node.h:45
    #10 0x1bc4bd5 in Spatial::_notificationv(int, bool) scene/3d/spatial.h:52
    #11 0x12448382 in Object::notification(int, bool) core/object.cpp:927
    #12 0xca1fd39 in Node::_propagate_ready() scene/main/node.cpp:179
    #13 0xca1f590 in Node::_propagate_ready() scene/main/node.cpp:171
    #14 0xca737ea in Node::_set_tree(SceneTree*) scene/main/node.cpp:2592
    #15 0xcb3b088 in SceneTree::init() scene/main/scene_tree.cpp:473
    #16 0x18ac1a9 in OS_X11::run() platform/x11/os_x11.cpp:3697
    #17 0x18150ae in main platform/x11/godot_x11.cpp:55
    #18 0x7fc8d6a2bfcf in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58

previously allocated by thread T0 here:
    #0 0x7fc8d79ae808 in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cc:144
    #1 0x129daa39 in Memory::alloc_static(unsigned long, bool) core/os/memory.cpp:75
    #2 0x129da94a in operator new(unsigned long, char const*) core/os/memory.cpp:40
    #3 0xc980908 in Object* ClassDB::creator<RigidBody>() (/usr/bin/godots+0xc980908)
    #4 0x121c0377 in ClassDB::instance(StringName const&) core/class_db.cpp:520
    #5 0xf9dd411 in SceneState::instance(SceneState::GenEditState) const scene/resources/packed_scene.cpp:182
    #6 0xfa10c9e in PackedScene::instance(PackedScene::GenEditState) const scene/resources/packed_scene.cpp:1590
    #7 0xf9dc70c in SceneState::instance(SceneState::GenEditState) const scene/resources/packed_scene.cpp:163
    #8 0xfa10c9e in PackedScene::instance(PackedScene::GenEditState) const scene/resources/packed_scene.cpp:1590
    #9 0x19d397b in Main::start() main/main.cpp:2080
    #10 0x1814fde in main platform/x11/godot_x11.cpp:54
    #11 0x7fc8d6a2bfcf in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58

SUMMARY: AddressSanitizer: heap-use-after-free core/variant.cpp:2168 in Variant::Variant(Object const*)

I'll take a look ASAP.

Fixed by #59063.


[RFR] Display error message when the form doesn't validate

Fix #1513

You should use a warning type in the notification IMO.


Read in prescribed 3d silicate fields for calculation of pH

What changes does this PR introduce?
(Bug fix, feature, docs update, ...)
reads 3d silicate fields for calculation of pH
issue #619
What is the current behaviour?
(You can also link to an open issue here)
reads only surface silicate fields
What is the new behaviour
(if this is a feature change)?
Does this PR introduce a breaking change?
(What changes might users need to make in their application due to this PR?)
Other information:
There are several default settings in DIC that are a bit problematic. A detailed summary can be found in the attached document below
silica_3d_field_check.pdf
Suggested addition to tag-index
(To avoid unnecessary merge conflicts, please don't update tag-index. One of the admins will do that when merging your pull request.)

I have few preliminary comments:

It would be better to keep the default DIC_OPTIONS.h (from pkg/dic) unchanged. Switching CARBONCHEM_TOTALPHSCALE and CAR_DISS to "#define" also affects the TAF adjoint and OpenAD adjoint test (code_ad & code_oad) and this might be tricky to fix here. Also I don't think TAF has ever seen the CAR_DISS code before, so it's a bit adventurous.
It's not completely clear to me that the "best" test experiment (in term of the overhaul set of experiments) for this 3-D silicate setting is this tutorial_global_oce_biogeo (and not, e.g., a smaller set-up like so_box_biogeo). So for now I would suggest to focus to pkg/dic changes.
It might seems stupid, but it's a little bit safer to have the new 3-D silica variable to be different from the previous/old 2-D silica ; this would allow to catch easily missing update (e.g., the other AD experiment tutorial_dic_adoffline should not have been affected since it has its own DIC_OPTIONS.h but it's now broken). I like the "SilicaSurf" so may be "Silica3d" ?

2. It's not completely clear to me that the "best" test experiment (in term of the overhaul set of experiments) for this 3-D silicate setting is this tutorial_global_oce_biogeo (and not, e.g., a smaller set-up like so_box_biogeo). So for now I would suggest to focus to pkg/dic changes.

@jm-c We just need to address the verification example now unless you can find anything else that needs attention. I think so_box_biogeo sounds sensible, given that this is where the pH and pCO2 solvers are tested.

@seamanticscience I will take a look and try to move this new feature into so_box_biogeo experiment. Will let you know if I have problems.

Currently, the 2 TAF adjoint experiments that use pkg/dic (tut_dic_adjoffline & tut_global_oce_giogeo) are a bit broken: many recomputations warnings (including some major re-comp) and the cost-fct reported in grdchk is all zero.
Going to fix this.

The 2 TAF adjoint experiments that use pkg/dic are fixed  now.

After consulting @seamanticscience , we agree to postpone the addition of a test for 3-D silicate to a future PR (which might or not address some of issue #678 ). And for now, will keep the little 3-D silicate input file in experiment so_box_biogeo (still feasible to try it) and remove the large one in tutorial_global_oce_biogeo.

@seamanticscience From my side, I think this PR is ready to be merged. Will do it after you approve. Thanks.


Use case of trigger rule does not configure the parameters of the action with the correct values

In our test case of trigger rule, one action helloworld/greeting will be created with the default inputs name: Bernie and place: Vermont. However, the keys name and place have been added, but the values are not added. Here is the information of the action created, if I run the command:
./wskdeploy -m tests/usecases/triggerrule/manifest.yml -d tests/usecases/triggerrule/deployment.yml
{
"namespace": "whisk.system/helloworld",
"name": "greeting",
"version": "0.0.1",
"exec": {
"kind": "nodejs:6",
"code": "/**\n * Return a simple greeting message for someone.\n *\n * @param name A person's name.\n * @param place Where the person is from.\n */\nfunction main(params) {\n    var name = params.name || params.payload || 'stranger';\n    var place = params.place || 'somewhere';\n    return {payload:  'Hello, ' + name + ' from ' + place + '!'};\n}\n"
},
"annotations": [
{
"key": "exec",
"value": "nodejs:6"
}
],
"parameters": [
{
"key": "name",
"value": "string"
},
{
"key": "place",
"value": "string"
}
],
"limits": {
"timeout": 60000,
"memory": 256,
"logs": 10
},
"publish": false
}

@lzbj Please take a look at this issue.

Ok, I'll take a look once I finished current bugs fix.

@daisy-ycguo please verify and see if the value in a Deployment.yaml were correctly being applied over the action default values.

I think this issue is fixed. Below is what I found.
When I ran wskdeploy -i -p tests/usecases/triggerrule/, I saw below output message:
Packages:
Name: triggerrule
    bindings:

  * action: greeting
    bindings:
        - name : "Bernie"
        - place : "DC"
    annotations:

Triggers:
* trigger: locationUpdate
    bindings:
    annotations:

 Rules
* rule: myRule
    - trigger: locationUpdate
    - action: triggerrule/greeting

Do you really want to deploy this? (y/N):

Then I verified in OpenWhisk, trying wsk action get triggerrule/greeting, and I saw below message:
ok: got action triggerrule/greeting
{
    "namespace"<EMAIL_ADDRESS>    "name": "greeting",
    "version": "0.0.1",
    "exec": {
        "kind": "nodejs:6",
        "code": "/**\n * Return a simple greeting message for someone.\n *\n * @param name A person's name.\n * @param place Where the person is from.\n */\nfunction main(params) {\n    var name = params.name || params.payload || 'stranger';\n    var place = params.place || 'somewhere';\n    return {payload:  'Hello, ' + name + ' from ' + place + '!'};\n}\n"
    },
    "annotations": [
        {
            "key": "exec",
            "value": "nodejs:6"
        }
    ],
    "parameters": [
        {
            "key": "place",
            "value": "DC"
        },
        {
            "key": "name",
            "value": "Bernie"
        }
    ],
    "limits": {
        "timeout": 60000,
        "memory": 256,
        "logs": 10
    },
    "publish": false
}

So I think this issue is fixed. We can close it.

@daisy-ycguo verified that this use case is now fixed with the current codebase.