6.x - Refactor to fix performance

Abstract
This PR should fix performance issue with new 6.x, and restore it to 5.x speed

Remove getDerivatedStateFromProps

First of all we should have a look to React Internals:
// Invokes the update life-cycles and returns false if it shouldn't rerender.
function updateClassInstance(current, workInProgress, ctor, newProps, renderExpirationTime) {
  var instance = workInProgress.stateNode;

 //...................

  if (typeof getDerivedStateFromProps === 'function') {
    applyDerivedStateFromProps(workInProgress, ctor, getDerivedStateFromProps, newProps);
    newState = workInProgress.memoizedState;
  }

  var shouldUpdate = checkHasForceUpdateAfterProcessing() || checkShouldComponentUpdate(workInProgress, ctor, oldProps, newProps, oldState, newState, nextContext);

  /// ......

  return shouldUpdate;
}

so we can replace
static getDerivedStateFromProps (nextProps){
   doSomeCalculationAndMemoizeToFakeState(nextProps)
}

with
shouldComponentUpdate(nextProps) {
     let update false;
        if (nextProps !== this.props)  {
            update = doSomeCalculation(nextProps)
         }
        return update
      }

that for react-redux use case (calculate new mapStateToProps when ownProps may have changed),
is safe.

use static contestType propagation => no double wrapper

With this pr i have removed double wrapper for context propagation and i use only static class contextType.
Constraints :
Custom context can be assigned only on connect options
connect(mapState,mapDispat, { context:CustomContext })(Component)

tbh i think that context on props should be removed as it  is a duplication of connect options.
Anyway there are some alternative 💯
1)Just use a different ConnectedComponet for every context you need, like:
const MyConnectedComponentWithContext1= connect(mapState,mapDispat, { context:CustomContext1 })(Component)
const MyConnectedComponentWithContext2= connect(mapState,mapDispat, { context:CustomContext2 })(Component)

use read_context from ReactInternals to allow use context as props on

<ConnectedComponent context={CustomContext} />

you can activate it with unstable_enableReadContextFromProps = true  on connect options
const ConnectedComponent = connect(mapState,mapDisp, { unstable_enableReadContextFromProps:true })(Component)

I already use it successfully  on https://github.com/salvoravida/react-universal-hooks
for useClassContext (useContext for classes) here https://github.com/salvoravida/react-class-hooks/blob/master/src/core/useClassContext.js
Results for benchmark deeptree:
┌───────────────┬─────────┬──────────────┬───────────┬───────────┬──────────┬────────────────┐
│ Version       │ Avg FPS │ Render       │ Scripting │ Rendering │ Painting │ FPS Values     │
│               │         │ (Mount, Avg) │           │           │          │                │
├───────────────┼─────────┼──────────────┼───────────┼───────────┼──────────┼────────────────┤
│ 5.1.1         │ 29.72   │ 69.3, 0.0    │ 2926.76   │ 1231.81   │ 516.42   │ 29,30,31,31    │
├───────────────┼─────────┼──────────────┼───────────┼───────────┼──────────┼────────────────┤
│ 5.2.1         │ 59.36   │ 68.9, 1.0    │ 1487.73   │ 1902.74   │ 970.93   │ 60,59,60,60    │
├───────────────┼─────────┼──────────────┼───────────┼───────────┼──────────┼────────────────┤
│ 6.0.0         │ 28.04   │ 66.8, 2.1    │ 3065.45   │ 1200.56   │ 436.10   │ 27,29,28,29,29 │
├───────────────┼─────────┼──────────────┼───────────┼───────────┼──────────┼────────────────┤
│ 6.0.1-classes │ 26.00   │ 71.2, 1.5    │ 2989.46   │ 1135.38   │ 522.30   │ 26,26          │
├───────────────┼─────────┼──────────────┼───────────┼───────────┼──────────┼────────────────┤
│ 6.2.1         │ 59.36   │ 68.6, 1.0    │ 1429.56   │ 1906.84   │ 989.53   │ 60,59,60,60    │
├───────────────┼─────────┼──────────────┼───────────┼───────────┼──────────┼────────────────┤
│ 7.0.0.alpha-3 │ 59.68   │ 73.1, 1.1    │ 1606.08   │ 1863.47   │ 945.96   │ 60,59,60,60    │
└───────────────┴─────────┴──────────────┴───────────┴───────────┴──────────┴────────────────┘

Test Suites: 5 passed, 5 total

React peer version >16.6.0 (static contextType)

if you want to test this PR right now you can use Yarn alias npm
   "react-redux": "npm<EMAIL_ADDRESS>
Your feedback is highly appreciated .... :D

Some points  about customContext and React-Redux
99% You do NOT need customContext on React-Redux
In 99% of Apps you have One Store @ App Root.
If it is your case just use 6.x the SAME EXACT WAY you have already used 5.x
<Provider store={store}/>
 <App>
  <ConnectedComp />
</App>
</Provider >
//where
const ConnectedComp = connect(mapState,mapDisp)(Component);

In this case  you can think to 6.x as Exact 5.x with deprecated Warning removed (deprecated lyfecicles and legacyContext) on React 16 so it is React 17 Ready.
1% You May need customContext on React-Redux
In 1% of Apps you have to use Two or More Store on the same app.
If it is your case, in both 6.0.0 and 6.2.1 you can have this code
<Provider store={store} context={CustomContext1}/>
 <App>
      <Provider store={store2} context={CustomContext2}/>
          <ConnectedComponentWithContext1/>
          <ConnectedComponentWithContext2/>
       </Provider >
 </App>
</Provider >
//where
const ConnectedComponentWithContext1= connect(mapState,mapDispat, { context:CustomContext1 })(Component)
const ConnectedComponentWithContext2= connect(mapState,mapDispat, { context:CustomContext2 })(Component)

Also in 6.0.0 you can write an EQUIVALENT way that is no more supported (for performance issue) on 6.2.1
<Provider store={store} context={CustomContext1}/>
 <App>
      <Provider store={store} context={CustomContext2}/>
          <ConnectedComponent context={CustomContext1} />
          <ConnectedComponent context={CustomContext2}/>
       </Provider >
 </App>
</Provider >

//where
const ConnectedComponent= connect(mapState,mapDispat)(Component)

So tbh, i think that 2x performance is better than have 2 identical unuseful way to do the same (rare-case) thing.

Just now having a chance to look at this.
First: @salvoravida , thanks for filing the PR.  I do appreciate that you've taken time to work on this.
However, having said that: I'm not happy that you've apparently gone around and advertised this in multiple places (including Reddit!), without us having had a chance to evaluate and discuss it first.
As one of the largest libraries in the React ecosystem, we have to carefully consider the needs of our users.  That includes both what they need to do with the library, how we maintain it, and how we "advertise" changes.  In particular, we don't want people getting confused about what is and isn't available, and what's actually "official".
We haven't even seriously publicized the v7 alpha at this point, and I've deliberately published it as a personal scoped package ( @acemarke/react-redux ) rather than an actual react-redux version just to keep it clear that this isn't ready yet.  So, running around advertising a PR that you just filed, before we even have any idea whether it might be something we would consider, is not helpful.

I'll need time to sit down and actually dig into the specific changes you made here.  However, glancing over things, I immediately see at least three problems that make this PR unlikely to be accepted as-is:

Doing work that has side effects in shouldComponentUpdate is not correct.
Bumping the React peer dependency from 16.4 to 16.6 would require a corresponding major version bump for React-Redux.  That would mean this could not be a v6.2.0, it would have to be a v7.
Similarly, it looks like you've removed the ability to pass context as a prop to a component.  Whether you like that or not, it's part of our public API for v6.  Removing that is a breaking change, and would also force this to be a major version bump.

I'll need time to sit down and actually dig into the specific changes you made here. However, glancing over things, I immediately see at least three problems that make this PR unlikely to be accepted as-is:

Doing work that has side effects in shouldComponentUpdate is not correct.
Bumping the React peer dependency from 16.4 to 16.6 would require a corresponding major version bump for React-Redux.  That would mean this could not be a v6.2.0, it would have to be a v7.
Similarly, it looks like you've removed the ability to pass context as a prop to a component.  Whether you like that or not, it's part of our public API for v6.  Removing that is a breaking change, and would also force this to be a major version bump.

So, overall, this PR doesn't appear to fit within the constraints we have to deal with.
As an additional thought: given what we know about how state propagation works via context (v6) vs how direct subscriptions work, I could plausibly argue that that behavior change itself would justify a major version bump (and thus any use of direct subscriptions could only happen in a v7 rather than a v6.x).

I'm sorry but i do not agree at all:
The theorical problem is: shouldUpdate ? selectorAndMerge(s,a)!=selectorAndMerge(s,b)
thats are pure function executed sinc ,( with partial value memoization), and without request/enqueque any callback/future/events, so there are NO side effects. And it is a fact, not a my opinion.
Moreover the natural lifecycle where evaluate that problem is of course the lifecycle that has the same name!
It is a political cost/benefit decision.
Same as 2), but it could resolved via readContext Internal api, if it is needed

That said, i do some advs for getting real word tests on big apps to test real performance improvment,
as this problem affects many users, and this is the normal behaviour on open-source projects.
Regards.

Bluntly, I'm a maintainer, and it's my decision that matters here.
I previously asked whether bumping a peer dependency (and specifically React) would require a major version change, and was told in no uncertain terms that yes, it requires a semver major bump.
I agree that readContext() is a potential alternative solution in some ways.  Unfortunately, that was removed from React's public API.  In that PR, the React team said it was theoretically possible for folks to reach directly into the internals of the dispatcher to do that themselves, which is what it appears your PR does.  However, I'm definitely uncomfortable shipping code that solely depends on undocumented internals, however "well-known" that might be.  It's bad enough that batchedUpdates() is still considered "unstable", but at least there we have public comments from the React team that it's a widely used API, not actually likely to be changed or removed any time soon, and they specifically encouraged us to use it.

Yeah, __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED? I don't want to get fired :(

Thank you for the PR, but this isn't the direction we're going to go.

Thank you for the PR, but this isn't the direction we're going to go.

it's a pity, now all tests passes and is still 2.5x faster.
Regards


docker service: make storage driver optional

This is similar to https://github.com/NixOS/nixpkgs/pull/10100, but less complete.

Alternative fix in master (5f17aeb4035057deb1840372f5a0a33098ce1e82) and release 15.09 (ab0a464e4b04773d48f14cf4cbb934eca3ef465c).

Why did you make devicemapper default. Docker knows automatically which
Driver to select in some cased, for example if running on btrfs it will
select btrfs and devicemapper bad default anyway, overlayfs is bettet.
Please fix.
V ned., 4. okt. 2015 2:38 pop. je oseba Bjørn Forsman <
<EMAIL_ADDRESS>napisala:

Alternative fix in master (5f17aeb
https://github.com/NixOS/nixpkgs/commit/5f17aeb4035057deb1840372f5a0a33098ce1e82)
and release 15.09 (ab0a464
https://github.com/NixOS/nixpkgs/commit/ab0a464e4b04773d48f14cf4cbb934eca3ef465c
).
—
Reply to this email directly or view it on GitHub
https://github.com/NixOS/nixpkgs/pull/10217#issuecomment-145347568.

This essentially breaks all my deploynents where i'm using btrfs.
V ned., 4. okt. 2015 3:51 pop. je oseba Jaka Hudoklin <
<EMAIL_ADDRESS>napisala:

Why did you make devicemapper default. Docker knows automatically which
Driver to select in some cased, for example if running on btrfs it will
select btrfs and devicemapper bad default anyway, overlayfs is bettet.
Please fix.
V ned., 4. okt. 2015 2:38 pop. je oseba Bjørn Forsman <
<EMAIL_ADDRESS>napisala:

Alternative fix in master (5f17aeb
https://github.com/NixOS/nixpkgs/commit/5f17aeb4035057deb1840372f5a0a33098ce1e82)
and release 15.09 (ab0a464
https://github.com/NixOS/nixpkgs/commit/ab0a464e4b04773d48f14cf4cbb934eca3ef465c
).
—
Reply to this email directly or view it on GitHub
https://github.com/NixOS/nixpkgs/pull/10217#issuecomment-145347568.

@offlinehacker ah it chooses at runtime too? Didn't know. But shouldn't you be explicitly defining the storage driver instead of docker guessing it?

@offlinehacker: Then please make it optional again. I only made it fixed because it was discussed in PR https://github.com/NixOS/nixpkgs/pull/10100 and I was down-voted. (I also didn't know that docker had different defaults depending on context.)

Uhm, this makes me re-consider my first thoughts about reverting 9bfe92ecee3359576093cfb534adbec13dcbd580 and just focus on fixing the NixOS VM tests...

I don't know why we need this option. What's wrong with Driver automaticaly
choosen by docker. It chooses Driver by priority: aufs, btrfs, zfs,
devicemapper, overlay, vfs.
V ned., 4. okt. 2015 3:58 pop. je oseba Bjørn Forsman <
<EMAIL_ADDRESS>napisala:

Uhm, this makes me re-consider my first thoughts about reverting 9bfe92e
https://github.com/NixOS/nixpkgs/commit/9bfe92ecee3359576093cfb534adbec13dcbd580
and just focus on fixing the NixOS VM tests...
—
Reply to this email directly or view it on GitHub
https://github.com/NixOS/nixpkgs/pull/10217#issuecomment-145351838.


Upgrade it.unimi.dsi:fastutil

When upgrading it.unimi.dsi:fastutil from 8.5.12 to 8.5.13, there are failing tests in AggregateAttestationValidatorTest. Need to investigate what causes those failings and fix them and only then upgrade.
Captured while working on https://github.com/Consensys/teku/pull/8037

maybe due to this https://github.com/vigna/fastutil/commit/0f5313322a701e20a4268ec1bf6406addcf696cb ?

seems like we need to wait 8.5.14, which seems to be on the way

Good catch. Looks like it.


Fix: #185

Fixes #185: implement Image Insertion Functionality in Text Editor with Block-Level Display
This PR introduces functionality that allows users to insert images into their notes on the Add Notes screen. The inserted images are displayed as block-level elements, ensuring that they appear full-width and text begins on a new line after the image. This enhances the overall user experience by providing more flexibility in how users can structure their notes.
Why was it changed
Previously, users could not insert images in a proper block-level format, and there were issues with image sizing and placement. With this change, users can insert images that are 100px by 100px in size, improving note organization and making the note editor more user-friendly.
How was it changed

The addImageToEditor function was modified to insert an image as a block-level element with a fixed size of 100px by 100px.
The image is automatically inserted on a new line, and any text following the image begins on a new line as well.
Additional styling was added to ensure the image fits within the note’s container, providing a clean layout for images in notes.
Test cases were add to ensure that the images that are added are in the certain specifications

UI after changes
After the changes, the user can click the image icon in the toolbar, select an image, and have it inserted into the note as a block-level element, sized to 100px by 100px, and any text after the image starts on a new line. The image is fully visible, enhancing the user experience in note-taking.

Hi, something messed up with my commit and the PR request when it comes to committing my recent changes, so please look at my most recent commit for the changes that I made in regards to this. I apologize for this, as my previous PR wasn't closed and I didn't know and I accidentally committed it to the previous PR request.

@teamomiamigo You should be starting each new issue by creating a branch off the main branch. You are creating branches from your other unmerged branches, which is causing these problems. Please follow the standard process and start each sprint with a new branch off main.

@teamomiamigo , I've come across a few issues in your code and would like to point them out below.
issue 1:
You are working on the old version of the code. The new version of the code is available on the main branch. Before you start working on a new issue, it is best practice to pull the latest version of the code from the main branch.
Note: In the old version of the code, we were using 'react-native-pell-rich-editor,' but in the latest version, we are working with the 10Tap editor.
issue 2:
Even though you are working on the old version of the code, a few test cases are failing.


Docker fixes. Vault destination option vaultSuffix

Hi!

docker/Dockerfile-src

To build directly from repo (useful for fork)

docker/entrypoint

use lemur instead of manage.py
add reissue cron job
fix cron: file name must match username(was broken)

docker/src/lemur.conf.py

use str instead of repr because reps adds quotes
add more variables

docker/supervisor.conf

add env to cron too
use lemur instead of manage.py

lemur/plugins/lemur_vault_dest/plugin.py

add optional option vaultSuffix.
Path constructed: vaultMount/vaultPath[/vaultSuffix]
.
We published user cert to their location in vault and want path to be like: vaultMount/cname/<service_name>/certificate.
In the example vaultSuffix is <service_name>/certificate.

Coverage decreased (-0.02%) to 58.944% when pulling 462099d9061215be309b33d961339a36e5b0d1f6 on e11it:master into 4df64a87e5175331de0b17c34f97a3fcfcb5bfa9 on Netflix:master.

fix for #2921

Hi!
I think it will be better to allow to use variables in vaultPath and don't add new option vaultSuffix.
I will come back with new implementation.

Bug:
/opt/lemur/lemur/plugins/lemur_vault_dest/plugin.py
auth_key = self.get_option("tokenFile/vaultRole", options)

will return None due to slash.
Rename value to "tokenFileOrVaultRole.

@hosseinsh , hi!
It's ready to merge.

Hi @e11it, sorry this is taking for ever.
Due to the current COVID-19 situation, there might be longer delays with PR reviews. As much as I would love to move forward with reviews, I am running short on time.
Hope to be able to do some testing for this PR, before merging it. Hopefully sometime in the coming days.


⚠ Bofrost.be has degraded performance

In a4f4bb8, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2505 ms

Resolved: Bofrost.be performance has improved in 9ad86db.


Design for the Twitter posts (v1)

What should the posts look like? Which screenshots are we taking?

Design (v1):
Good morning. Here's your {time} air quality report:
In Leon County, the air quality is '{AQI category}'. {Message dependent on AQI}
Screenshot 1 - AirNow
Screenshot 2 - PurpleAir


When roll loot into the chat, add a button to Add to Actor

would be nice to have a button in the card to be able to add the loot to an actor

not doing it right now, not sure if its something we need


Develop new website sitemap per IA

💡 Description

v1 of this completed and presented to WG on 10/18


Chap05Rel0203

There's a point where it says Not bad. Not bad at all. The text actually displays on the iPhone in 13 lines, and the Android in 14 lines, but the technique seems sound. but in the images above all three devices show the text using 14 lines (so no 13 for iPhone), even when the texts themselves say 15 lines (iOS and Android).

Fixed in underlying files. Thanks!


Unable to install rkdb on windows 10

Hi, I tried to install rkdb in my windows 10 system. And found error as shown below. The same error has been reported for windows 7 before. I think I have made my R to run 64-bit already.
c:/Rtools/mingw_32/bin/gcc -shared -s -static-libgcc -o rkdb.dll tmp.def rkdb.o -Lw32 -le_static -lws2_32 -liphlpapi -LC:/PROGRA~1/R/R-35~1.3/bin/i386 -lR
C:/Rtools/mingw_32/bin/../lib/gcc/i686-w64-mingw32/4.9.3/../../../../i686-w64-mingw32/bin/ld.exe: cannot find -le_static
collect2.exe: error: ld returned 1 exit status
no DLL was created
ERROR: compilation failed for package 'rkdb'
My R versions are below and I use 3.5 Rtools:

version
platform       x86_64-w64-mingw32
arch           x86_64
os             mingw32
system         x86_64, mingw32
status
major          3
minor          5.3

Thank you so much for your help!

There is a closed issue which stated almost the identical problem.

There is a closed issue which stated almost the identical problem.

Thank you for your help. I noticed that issue. I think the main takeaway from that issue is rkdb shouldn't be run on 32-bit but 64-bit. I believe that I have already made sure everything is on the 64-bit, but the issue still arise. That's why I'm posting this issue.

c:/Rtools/mingw_32/bin/gcc -shared -s -static-libgcc -o rkdb.dll tmp.def rkdb.o -Lw32 -le_static -lws2_32 -liphlpapi -LC:/PROGRA1/R/R-351.3/bin/i386 -lR
C:/Rtools/mingw_32/bin/../lib/gcc/i686-w64-mingw32/4.9.3/../../../../i686-w64-mingw32/bin/ld.exe: cannot find -le_static

Those error message shows that the compiler that is a 32-bit version. And it's trying to link with some 32-bit libraries. So there are still some configurations still not set correctly (use 64-bit compiler).

How would we go about changing those configurations (to point to the mingw_64 directory presumably)? Thanks!

I don't use Windows and not that familiar with the details of the OS. I found this page from CRAN. Seems like you can rerun the installer to get the correct components to be used in R.

I don't use Windows and not that familiar with the details of the OS. I found this page from CRAN. Seems like you can rerun the installer to get the correct components to be used in R.

Hi Linwei,
Thank you for your help. I tried to configure R to use mingw_64 by setting
"Sys.setenv(BINPREF = "C:/Rtools/mingw_64/bin/")" and I got the following error
C:/Rtools/mingw_64/bin/gcc -shared -s -static-libgcc -o rkdb.dll tmp.def rkdb.o -Lw32 -le_static -lws2_32 -liphlpapi -LC:/PROGRA~1/R/R-35~1.3/bin/i386 -lR
C:/Rtools/mingw_64/bin/../lib/gcc/x86_64-w64-mingw32/4.9.3/../../../../x86_64-w64-mingw32/bin/ld.exe: cannot find -le_static
C:/Rtools/mingw_64/bin/../lib/gcc/x86_64-w64-mingw32/4.9.3/../../../../x86_64-w64-mingw32/bin/ld.exe: skipping incompatible C:/PROGRA~1/R/R-35~1.3/bin/i386/R.dll when searching for -lR
C:/Rtools/mingw_64/bin/../lib/gcc/x86_64-w64-mingw32/4.9.3/../../../../x86_64-w64-mingw32/bin/ld.exe: skipping incompatible C:/PROGRA~1/R/R-35~1.3/bin/i386/R.dll when searching for -lR
C:/Rtools/mingw_64/bin/../lib/gcc/x86_64-w64-mingw32/4.9.3/../../../../x86_64-w64-mingw32/bin/ld.exe: cannot find -lR
collect2.exe: error: ld returned 1 exit status
no DLL was created
ERROR: compilation failed for package 'rkdb'
It seems that R has found a way to link back to i386 in 32-bit gcc. This is weird. Also, if I tried to add other into environmental variable as refered in (https://www.r-bloggers.com/quirks-about-running-rcpp-on-windows-through-rstudio/), it shows that Rtools package cannot be found. This is weird.

I have solved this issue. I think the key problem is after configuring everything to 64-bit, R CMD INSTALL for a package with compiled code will fail if compilation fails for any of the installed sub-architectures. Need to use "--no-multiarch" here to override this. Thus we need to run with "devtools::install_github('kxsystems/rkdb', INSTALL_opts = c("--no-multiarch", "--no-test-load"))".


🐛 [firebase_ml_vision] Face detection from camera live feed stopped working on Android devices

Bug report
Describe the bug
We built a face verification feature, with the first step detecting face rectangles using firebase_ml_vision face detector, in January. Both the iOS and Android versions tested working correctly. We recently noticed the Android app stopped detecting faces for further processing. This is a regression bug certain library update broke the face detection. Then we tested the example app in this repo, the issue can be reproduced.
Steps to reproduce
Steps to reproduce the behavior:

The problem is only on Android, not on iOS
We were able to get face detection working on Android before and it regressed recently.
After some debugging and research, I can confirm that still images from the disk still works. Only the frames grabbed from the camera feed in YUV 420 result in no faces detected.
I tested your official example camera scanner, live face detection text/label/bar on Android does not work.
Devices tested: Pixel and Galaxy Tab S5e

Expected behavior
Faces in the camera feed would have rectangles.

Additional context
Add any other context about the problem here.

Flutter doctor
Run flutter doctor and paste the output below:
Click To Expand
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 1.22.0, on Mac OS X 10.15.7 19H2, locale en-US)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
[✓] Xcode - develop for iOS and macOS (Xcode 12.0.1)
[✓] Android Studio (version 4.0)
[!] IntelliJ IDEA Ultimate Edition (version 2020.2.2)
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
[✓] VS Code (version 1.48.2)
[✓] Connected device (1 available)

! Doctor found issues in 1 category.

Flutter dependencies
Run flutter pub deps -- --style=compact and paste the output below:
Click To Expand
Dart SDK 2.10.0
Flutter SDK 1.22.0
firebase_ml_vision_example 0.0.0

dependencies:
- camera 0.5.8+7 [flutter]
- cupertino_icons 0.1.3
- firebase_core 0.5.0 [firebase_core_platform_interface flutter quiver meta firebase_core_web]
- firebase_ml_vision 0.9.7 [flutter]
- flutter 0.0.0 [characters collection meta typed_data vector_math sky_engine]
- image_picker 0.6.7+11 [flutter flutter_plugin_android_lifecycle image_picker_platform_interface]

dev dependencies:
- e2e 0.6.3 [flutter flutter_driver flutter_test path]
- flutter_driver 0.0.0 [file json_rpc_2 meta path web_socket_channel vm_service_client webdriver flutter flutter_test fuchsia_remote_debug_protocol archive args async boolean_selector characters charcode clock collection convert crypto fake_async matcher platform process pub_semver source_span stack_trace stream_channel string_scanner sync_http term_glyph test_api typed_data vector_math]
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters charcode collection matcher meta source_span stream_channel string_scanner term_glyph typed_data]
- path 1.8.0-nullsafety.1
- path_provider 1.6.18 [flutter path_provider_platform_interface path_provider_macos path_provider_linux path_provider_windows]
- pedantic 1.10.0-nullsafety.1
- test 1.16.0-nullsafety.5 [analyzer async boolean_selector coverage http http_multi_server io js node_preamble package_config path pedantic pool shelf shelf_packages_handler shelf_static shelf_web_socket source_span stack_trace stream_channel typed_data web_socket_channel webkit_inspection_protocol yaml test_api test_core]

dependency overrides:
- firebase_core 0.5.0 [firebase_core_platform_interface flutter quiver meta firebase_core_web]

transitive dependencies:
- _fe_analyzer_shared 11.0.0 [meta]
- analyzer 0.40.4 [_fe_analyzer_shared args charcode cli_util collection convert crypto glob meta package_config path pub_semver source_span watcher yaml]
- archive 2.0.13 [crypto args path]
- args 1.6.0
- async 2.5.0-nullsafety.1 [collection]
- boolean_selector 2.1.0-nullsafety.1 [source_span string_scanner]
- characters 1.1.0-nullsafety.3
- charcode 1.2.0-nullsafety.1
- cli_util 0.2.0 [path]
- clock 1.1.0-nullsafety.1
- collection 1.15.0-nullsafety.3
- convert 2.1.1 [charcode typed_data]
- coverage 0.14.1 [args logging package_config path source_maps stack_trace vm_service]
- crypto 2.1.5 [collection convert typed_data]
- fake_async 1.2.0-nullsafety.1 [clock collection]
- ffi 0.1.3
- file 6.0.0-nullsafety.2 [meta path]
- firebase 7.3.0 [http http_parser js]
- firebase_core_platform_interface 2.0.0 [flutter meta plugin_platform_interface quiver]
- firebase_core_web 0.2.0 [firebase firebase_core_platform_interface flutter flutter_web_plugins meta js]
- flutter_plugin_android_lifecycle 1.0.11 [flutter]
- flutter_web_plugins 0.0.0 [flutter characters collection meta typed_data vector_math]
- fuchsia_remote_debug_protocol 0.0.0 [json_rpc_2 process web_socket_channel flutter_test flutter_driver archive args async boolean_selector charcode clock collection convert crypto fake_async file matcher meta path platform pub_semver source_span stack_trace stream_channel string_scanner sync_http term_glyph test_api typed_data vector_math vm_service_client webdriver]
- glob 1.2.0 [async collection node_io path pedantic string_scanner]
- http 0.12.2 [http_parser path pedantic]
- http_multi_server 2.2.0 [async]
- http_parser 3.1.4 [charcode collection source_span string_scanner typed_data]
- image_picker_platform_interface 1.1.1 [flutter meta http plugin_platform_interface]
- io 0.3.4 [charcode meta path string_scanner]
- js 0.6.3-nullsafety.1
- json_rpc_2 2.2.2 [stack_trace stream_channel]
- logging 0.11.4
- matcher 0.12.10-nullsafety.1 [stack_trace]
- meta 1.3.0-nullsafety.3
- mime 0.9.7
- node_interop 1.1.1 [js]
- node_io 1.1.1 [node_interop path]
- node_preamble 1.4.12
- package_config 1.9.3 [path charcode]
- path_provider_linux 0.0.1+2 [path xdg_directories path_provider_platform_interface flutter]
- path_provider_macos 0.0.4+4 [flutter]
- path_provider_platform_interface 1.0.3 [flutter meta platform plugin_platform_interface]
- path_provider_windows 0.0.4+1 [path_provider_platform_interface meta path flutter ffi win32]
- platform 3.0.0-nullsafety.2
- plugin_platform_interface 1.0.3 [meta]
- pool 1.5.0-nullsafety.1 [async stack_trace]
- process 4.0.0-nullsafety.2 [file path platform]
- pub_semver 1.4.4 [collection]
- quiver 2.1.3 [matcher meta]
- shelf 0.7.9 [async collection http_parser path stack_trace stream_channel]
- shelf_packages_handler 2.0.0 [path shelf shelf_static]
- shelf_static 0.2.8 [convert http_parser mime path shelf]
- shelf_web_socket 0.2.3 [shelf web_socket_channel stream_channel]
- sky_engine 0.0.99
- source_map_stack_trace 2.1.0-nullsafety.2 [path stack_trace source_maps]
- source_maps 0.10.10-nullsafety.1 [source_span]
- source_span 1.8.0-nullsafety.2 [charcode collection path term_glyph]
- stack_trace 1.10.0-nullsafety.1 [path]
- stream_channel 2.1.0-nullsafety.1 [async]
- string_scanner 1.1.0-nullsafety.1 [charcode source_span]
- sync_http 0.2.0
- term_glyph 1.2.0-nullsafety.1
- test_api 0.2.19-nullsafety.2 [async boolean_selector collection meta path source_span stack_trace stream_channel string_scanner term_glyph matcher]
- test_core 0.3.12-nullsafety.5 [analyzer async args boolean_selector collection coverage glob io meta package_config path pedantic pool source_map_stack_trace source_maps source_span stack_trace stream_channel vm_service yaml matcher test_api]
- typed_data 1.3.0-nullsafety.3 [collection]
- vector_math 2.1.0-nullsafety.3
- vm_service 5.2.0 [meta]
- vm_service_client 0.2.6+2 [async collection json_rpc_2 pub_semver source_span stack_trace stream_channel web_socket_channel]
- watcher 0.9.7+15 [async path pedantic]
- web_socket_channel 1.1.0 [async crypto stream_channel]
- webdriver 2.1.2 [archive matcher path stack_trace sync_http]
- webkit_inspection_protocol 0.7.3 [logging]
- win32 1.7.3 [ffi]
- xdg_directories 0.1.2 [meta path process]
- yaml 2.2.1 [charcode collection string_scanner source_span]

@pixnbit
Tried the official ml_vision example on Android 8.1.0 device on latest beta and the face detection worked properly.
3798.mp4.zip

flutter doctor -v
[✓] Flutter (Channel beta, 1.22.0, on Mac OS X 10.15.4 19E2269, locale en-IN)
    • Flutter version 1.22.0 at /Users/dhs/documents/Fluttersdk/flutter
    • Framework revision d408d302e2 (8 days ago), 2020-09-29 11:49:17 -0700
    • Engine revision 5babba6c4d
    • Dart version 2.10.0

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/dhs/Library/Android/sdk
    • Platform android-30, build-tools 30.0.0
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.0.1, Build version 12A7300
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 46.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.49.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.11.0

[✓] Connected device (3 available)
    • Darshan's iphone (mobile) • 21150b119064aecc249dfcfe05e259197461ce23 • ios
      • iOS 14.0
    • Web Server (web)          • web-server                               •
      web-javascript • Flutter Tools
    • Chrome (web)              • chrome                                   •
      web-javascript • Google Chrome 86.0.4240.75

• No issues found!

Can you provide video of the issue you are facing ?
Thanks.

Here are my test videos, both Android 9 and 10 are failing, iOS works.
Google Pixels (Two phones, Android 9 and 10), Samsung Galaxy Tab s5e Android 10
Samsung Galaxy Tab s5e Android 10.MP4.zip
Google Pixel Android 9.MP4.zip
This is with iPhone:
iPhone X.MP4.zip

Any update one this?

@pixnbit
Tried again on latest stable (1.22.1) using Samsung S10+ device and was able to detect faces properly.
3798.mp4.zip

flutter doctor -v
[✓] Flutter (Channel stable, 1.22.1, on Mac OS X 10.15.4 19E2269, locale en-IN)
    • Flutter version 1.22.1 at /Users/dhs/documents/Fluttersdk/flutter
    • Framework revision f30b7f4db9 (5 days ago), 2020-10-08 10:06:30 -0700
    • Engine revision 75bef9f6c8
    • Dart version 2.10.1

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/dhs/Library/Android/sdk
    • Platform android-30, build-tools 30.0.0
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.0.1, Build version 12A7300
    • CocoaPods version 1.9.3

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 46.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.49.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.11.0

[✓] Connected device (1 available)
    • iPhone SE (2nd generation) (mobile) • 6C85835D-FBFD-4AB3-8DE8-B4FAD35E5367
      • ios • com.apple.CoreSimulator.SimRuntime.iOS-14-0 (simulator)

• No issues found!

Hi, I am encountering the same problem for some Android devices, only barcode and face detection is not working.
I have tested with several phones and getting inconsistent results, as I have observed it is working better at lower versions of android.
Below is a testing comparison of both devices running on Android 10
Samsung S20 FE - detection not working

Samsung XCover4s - detection is ok

[√] Flutter (Channel stable, 1.22.2, on Microsoft Windows [Version 10.0.18363.1139], locale en-SG)
    • Flutter version 1.22.2 at C:\src\flutter
    • Framework revision 84f3d28555 (6 days ago), 2020-10-15 16:26:19 -0700
    • Engine revision b8752bbfff
    • Dart version 2.10.2

[√] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at C:\Android\android-sdk
    • Platform android-29, build-tools 29.0.2
    • ANDROID_HOME = C:\Android\android-sdk
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[!] Android Studio (version 4.1.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    X Flutter plugin not installed; this adds Flutter specific functionality.
    X Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] VS Code (version 1.50.1)
    • VS Code at C:\Users\Christine\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.15.1

[!] Connected device
    ! No devices available

! Doctor found issues in 2 categories

(I have flutter and dart plugins in Android studio but apparently it doesn't reflect)
Any ideas about this inconsistency?
Thanks.

Yes, it's very frustrating,

Hi, I am encountering the same problem for some Android devices, only barcode and face detection is not working.
I have tested with several phones and getting inconsistent results, as I have observed it is working better at lower versions of android.
Below is a testing comparison of both devices running on Android 10
Samsung S20 FE - detection not working

Samsung XCover4s - detection is ok

[√] Flutter (Channel stable, 1.22.2, on Microsoft Windows [Version 10.0.18363.1139], locale en-SG)
    • Flutter version 1.22.2 at C:\src\flutter
    • Framework revision 84f3d28555 (6 days ago), 2020-10-15 16:26:19 -0700
    • Engine revision b8752bbfff
    • Dart version 2.10.2

[√] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at C:\Android\android-sdk
    • Platform android-29, build-tools 29.0.2
    • ANDROID_HOME = C:\Android\android-sdk
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[!] Android Studio (version 4.1.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    X Flutter plugin not installed; this adds Flutter specific functionality.
    X Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] VS Code (version 1.50.1)
    • VS Code at C:\Users\Christine\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.15.1

[!] Connected device
    ! No devices available

! Doctor found issues in 2 categories

(I have flutter and dart plugins in Android studio but apparently it doesn't reflect)
Any ideas about this inconsistency?
Thanks.

I think we're seeing the same issue, I corrected my statement, it affects face/barcode/text detection, and YES, it's inconsistent some devices are fine. (My friend's Huawei phone was fine, on a simulator with webcam attached is also fine. Pixel phone, Samsung Galaxy tab do not work)

Since the devices on which I tried don't have any issues, but per OP, the issue seem to be happening on certain devices like Pixel and Samsung Galaxy tab. Hence keeping this issue open for further analysis.

Hi, I'm experiencing similar issue with Sony Xperia XZ2 (Android 10) Compact and Oppo A7 (Android 8), both cannot detect face whilst the text detection is still working (but inconsistent). Then I tried to change the camera resolution into ResolutionPreset.high and it's working (face is detected including landmark and contour) . This is no issue on Xperia XZ2 since it has SD845, but it feels lagging when it run on Oppo A7. Before migrating into firebase_core > 0.5.0 this is not an issue, but somehow I couldn't go back into 0.4.0

Hi, I'm experiencing similar issue with Sony Xperia XZ2 (Android 10) Compact and Oppo A7 (Android 8), both cannot detect face whilst the text detection is still working (but inconsistent). Then I tried to change the camera resolution into ResolutionPreset.high and it's working (face is detected including landmark and contour) . This is no issue on Xperia XZ2 since it has SD845, but it feels lagging when it run on Oppo A7. Before migrating into firebase_core > 0.5.0 this is not an issue, but somehow I couldn't go back into 0.4.0

Thank you so much for the workaround @zean00 , I tested with ResolutionPreset.high and the face recognition worked on my Samsung S20 FE and also on some device I tested such as One Plus 6. Though, not all devices can handle this performance.. :(
What could possibly be causing this?

No way!!! Yes, I can confirm after changing from  ResolutionPreset.medium to ResolutionPreset.high fixed my issue.
Please fix this Flutter fire team.

I am using a pixel 3xl and was experiencing lack of detection for all modes for CameraPreviewScanner. Upping the resolution to ResolutionPreset.high as stated above fixed my problem.


Feature

added a cool animation to the modal

👨💻 Changes proposed

✔ Check List (Check all the applicable boxes)

[ ] My code follows the code style of this project.
[ ] This PR does not contain plagiarized content.
[ ] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshots

No one asked for these changes, create an issue about it and how it will look like.
This PR will be closed without being merged


Citation data not displaying properly

Date is displaying as NaN/NaN/NaN

Fixed with this commit.

City of Albany keeps tweaking their Socrata endpoint, changing the URL (which I think happens when the dataset gets deleted and republished) and the field names. It's breaking the template for displaying citation data.

Fixed with this commit.


Support generate bootable AWS AMI image?

Just ask, I work with aws services, I find it very fast and convenient to use mkosi to generate image used to spin container.
Is there away to use same method for generate image that compatible to use to upload to aws ami and use to spin up aws ec2 instance?
I can think it will require bios/mbr instead of UEFI.
Basically I want to generate latest image of ubuntu 20.04 with some custom configs and packages and upload to ec2 ami to use for spinning up ec2 instance. (similar to packer)

You may fork this repository or use mkosi directly to build what you want.
Currently I have no plan to support AWS AMI on this repository because I don't use AWS.


Change reporting calls timings to ensure consistency

Added a sync.WaitGroup to the reporter module, which is used to ensure that the routine that reports the workflow end wg.Wait()-s before executing, allowing for all other reporting subroutines to record the progress correctly.
Note: I don't know if this can be unit-tested.

Why is sigrid bullying me tho


Users can import JSON schema code into Legend Studio

There is an option to import JSON schema code into Legend.

This issue is stale because it has been open for 30 days with no activity. Please remove stale label or add any comment to keep this open. Otherwise this will be closed in 5 days.

This issue was closed because it has been inactive for 35 days. Please re-open if this issue is still relevant.


Remove NavBarLink default text decoration

Is your feature request related to a problem? Please describe.
NavbarLink's shouldn't have default text-decoration set. The default inline text-decoration: none is not necessary by default and will mess up if there's a need to add hover effect on nav links.
It's impossible to overwrite it via mj-style or etc.

Here's a small example here : https://mjml.io/try-it-live/Bka3Ukm6m

Well, I'm trying to add hover effect via the <style> tag to do underline on hover. But because inlined css has more specificity than the <style> tag, none of the styles in the tag will work.
Example style tag
a { text-decoration: none}
a:hover { text-decoration: underline }

Both of which has less specificity than the inline css.
Is there a specific use case for adding the default text-decoration: none on mj-navbar-link?

It was the most common use-case when we used it.
You just have to use !important to bypass inline style as standard css https://mjml.io/try-it-live/B1PU8e7a7
But I would recommend the mj-attributes way instead of using mj-style for that

Both the methods you suggested does not solve the required outcome.
Can you create an example on try-it-live that will create a mj-navbar-link that have links that only underlines during hover?

https://mjml.io/try-it-live/HJit9x7T7

That's ugly, double !important. But it does the job. Thanks.


Update request: pkgs.ly 0.6.0 → 1.0.0

Package name: ly
Latest released version: 1.0.0
Current version on the unstable channel: 0.6.0
Current version on the stable/release channel: 0.6.0
[x] Checked the nixpkgs pull requests

Extra notes: It should be moved from applications.display-manager to services.displayManager because it is impossible to find it.
Notify maintainers

Note for maintainers: Please tag this issue in your PR.


(Fix): Drop (name) + (max)

:bug: Berlin (Blockchain) Waifus is always good default
:zap: use default name from D1
:label: minted
:zap: use optionally max from D1

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type

[x] Bugfix
[ ] Feature
[ ] Refactoring

Needs QA check

@kodadot/qa-guild please review

Context
Won't mint Berlin (Blockchain) Waifu
Screenshot 📸

[ ] My fix has changed UI

Copilot Summary

🤖[deprecated] Generated by Copilot at 0155f47
This pull request enhances the generative drop item feature by allowing custom names and max values for each item. It also removes some unused or redundant code from utils.ts and types.ts.

🤖[deprecated] Generated by Copilot at 0155f47

No more UNLOCKABLE_NAME, we set our own destiny
We add a max property to limit the scarcity
We make the Generative.vue more dynamic and clear
We create the drop items that will make them all fear

rolling it back? ok

rolling it back? ok

Wdym? @prury


Update README

[x] add links to navigate LICENSE
ex:- LICENSE
[ ] Add a contribution section.
[ ] Highlight keywords
[x] Check spelling Mistakes and fix them.
[ ] Add an NPM package link. here is the link [https://www.npmjs.com/package/vue3-analog-clock]
[ ] Add contribution section
ex: -

🌱 Contributors

Please replace the above code at the bottom of the readme file.

how did you do the circle with the profile picture?


Support HEALTHCHECK --start-period

Handle a --start-period argument when parsing HEALTHCHECK instructions.
This PR switches to the v1.2.2 release of the upstream github.com/fsouza/go-dockerclient package, and I'm not wedded to that, but we currently don't have a branch of https://github.com/openshift/go-dockerclient.git that includes the field that we could switch to instead.

LGTM

If Ben has completed his split, please sync to make sure he can bump and then we can try this again.

creating an openshift-4.0 branch of go-dockerclient, updating to v1.2.2 and including the carry patch here:
https://github.com/openshift/go-dockerclient/pull/1
after it merges you can bump to the openshift-4.0 branch of openshift/go-dockerclient.

https://github.com/openshift/go-dockerclient/pull/1 has merged, so you can redo this using the openshift-4.0 branch now.

Rebased.  glide updates other components, but those are not currently in this patch.  If it's preferred that we pull in the other updates, I can change it.

If it's preferred that we pull in the other updates, I can change it.

that's how it's normally done, personally i don't have a preference but i'm not sure who needs to sign off on this (not me).


Update literate documentation index

Description

Adding tooling for generate literate documentation automatically
Adding GH Action for compile an deploy GH Page
Remove previously hand-generated literate documentation and index

Type of change

Documentation update

Testing steps
N/A
Checklist

[ ] make before_commit passes
[ ] updated documentation wherever necessary
[ ] added or modified tests if necessary
[ ] updated schemas and validators in insights-data-schemas in case of input/output change

Codecov Report
Patch and project coverage have no change.

Comparison is base (bb67b64) 69.23% compared to head (5c61373) 69.23%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #385   +/-   ##
=======================================
  Coverage   69.23%   69.23%
=======================================
  Files          14       14
  Lines        1180     1180
=======================================
  Hits          817      817
  Misses        342      342
  Partials       21       21

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Real appointment data in planner

Pass appointment UUIDs from the booking service back to the planner; show an appointment summary for the right appointment in the planner.

This looks great

Mind if I rebase?

Not at all


[BUG] Format error tried to get it right

Describe the bug

Product Flavor

[ ] Managed (https://rxresu.me)
[ ] Self Hosted

To Reproduce

Go to 'create resume'
Choose the template 'Onyx'
Write a summary
See error

Expected behavior
The lines of summary breaks near the middle instead it should break at the extreme right
Screenshots

The summary breaks at the middle of the page as well as work experience

but shown in the resume template is as follows

Desktop (please complete the following information):

OS: Windows 11
Browser: Chrome
Version: NA

Additional context

Hello! I tried to reproduce this, but for me, it looks exactly like it should. See https://rxresu.me/tryallthethings/1085 (Demo data with Onyx template)
Could you please clear your browser cache and try again? Did you maybe add anything unusual (special characters, markdown formattig) in the markdown?

Hey it works good now. I checked this issue next day right after reporting the bug. I thought someone fixed it. Thank you


ci: update manual changelog location for .pkgmeta

I guess its expecting the resulting filepath for the changelog after packaging.

#57
#56  👈
working-trunk

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @juemrami and the rest of your teammates on  Graphite

Merge activity

May 22, 6:17 PM EDT: @juemrami started a stack merge that includes this pull request via Graphite.


close the capture cost more than 50 seconds

What did you do?
the capture is going close.
What did you expect to see?
close the capture should be finished very fast
What did you see instead?
close the compactor cost around 48 seconds

cdc.log
Versions of the cluster
Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):
(paste TiDB cluster version here)

Upstream TiKV version (execute tikv-server --version):
(paste TiKV version here)

TiCDC version (execute cdc version):
Release Version: v6.3.0-master
Git Commit Hash: 5fa97cdc28058573f32c89ac138eda2d866d8abe
Git Branch: scheduler-burst-add-by-batch
UTC Build Time: 2022-08-24 08:12:58
Go Version: go version go1.18 linux/amd64
Failpoint Build: false

/severity Moderate


[Contributing] How to help?

Hello! Is there a Roadmap or something for this project?
I would love to contribute, just discovered it and it is sooooo good :)

Thanks for asking! Contributing on this project is very casual. I can help put together instructions for running the project locally if you're having any issues. There is no roadmap at the moment. But feel free to propose features and we could make one. I'm also absolutely happy to accept pull requests. To increase the likelihood of the pr getting accepted we could discuss new features/ideas before you start writing code but if you have a PR ready to go then definitely share it 🎉.


[WIP] Fix for #85

This is not ready to merge.
To keep #85 clean, I will keep implementation-specific comments within this PR until it is ready & tested.

Comment moved from original issue:

Well, with some debugging I was able to trace the exception in my OP to divide by zero errors caused by the minetest dummy textures being 1x1 pixels.
Clamping these values to 1, I was able to push the client through the login process:

Which reveals that somehow I have totally borked all texture sending :) not even basic textures are loading properly.

Clearly I'm doing something totally wrong... though added logging to multiserver indicates I am sending the textures. 🤷♂ Strange indeed.

I found two problems with your code:

Media is announced during client initialisation, thus SafeServerName will always return the name of the default server
The count of media files (len(media[currentSrvname]), media.go:294) is not equal to the amount of files that are actually being announced (len(GetAllNames(currentSrvname)), media.go:295), this is probably the cause of the client crash

The count of media files (len(media[currentSrvname]), media.go:294) is not equal to the amount of files that are actually being announced (len(GetAllNames(currentSrvname)), media.go:295), this is probably the cause of the client crash

Yes! That was it. I no longer crash.
I have tried to get the PUSH to work but it is as you said: Minetest does not update the textures in-game with new media...
Reading the Minetest source now to figure out why this is going on. Maybe if it is a bug I can fix it... Though the option of prefixing all textures with the servername could be a backwards-compatible solution.

Yeah no success on the push. It seems to be a longstanding issue: https://forum.minetest.net/viewtopic.php?t=21932

the inability to push new media to the client on the fly

I have started down the path to approach 2: give each media item a unique name from the outset. This will require deep packet inspection of the NodeDefs... The []byte forming the bulk of this packet body is a serialized NodeDefManager, containing some # of serialized ContentFeatures, each of which contains serialized TileDefs containing references to the media by name.

It is nested 3 levels of serialization deep. Still. I think we should be able to wrap the []byte in a Reader, and skip until we get to the parts that need modifying, writing out to a Writer as we go? Something like that...

Yeah, minetest networking can really be a pain sometimes. I think skipping the irrelevant parts this way is a good idea.

Are you still working on this?

Not really.

Fixed in the successor project, see https://github.com/HimbeerserverDE/multiserver/issues/85#issuecomment-1817860579 for details.


SCMOD-15820: Added zypper refresh, update and clean

A little bit of repo tidy up too, corrected the project title, fixed the copyright to use correct custom mappings, added gitignore and updated readme to match other base image format.

CI Build Link:
http://sou-jenkins2.swinfra.net:8080/job/CAFapi/job/CAFapi~opensuse-dotnet-6-images~SCMOD-15820~CI

FYI The developer build failure of the last commit is a result of the ongoing DockerHub outage so I've went on ahead and merged this anyway.


README gif is out of date packages -> libraries

Describe the bug
The README.md for this products repository contains an animated gif in the Intellisense section that shows the JSON of the libman.json file. The gif shows, what I assume is, an older format of the file using a packages node, whereas the current version uses a libraries node. Could someone with gif making skills update the gif, to avoid confusion/misleading new adopters?
To Reproduce
Steps to reproduce the behavior:

Navigate to the rendered README.md for this repository
View the Intellisense section
Notice the JSON format used in the animated gif

Expected behavior
The gif should show accurate JSON format. It shows a packages node instead of the libraries node. Assuming packages was an older format.
Screenshots
Inaccurate annimated gif
Additional context
Strictly a documentation issue. Not a tool issue.

Looks great! Thanks @jimmylewis


Replace nom in bcfs with simple by-hand parser

A couple of length_values doesn't need nom. nom gets the job done and doesn't require a parser test, but it increases compile times by a second or two.

actually nom is pretty quick to compile and makes the code much easier to understand/bug free


Add support for criteria involving operations between fields

Currently, clover db only supports building criteria where you compare a field with a value, like the one in the following example:
db.Query("myCollection").Where(c.Field("myField").Eq(1))

Naturally, there are several contexts where one may need to express condition where you compare fields of the same document. For example you may want to select documents satisfying a condition such as myField1 > myField2.
This could be integrated inside clover in the following way:
db.Query("myCollection").Where(c.Field("myField1").Gt("$myField2"))

where the special syntax $myField2 tells clover to extract the value to use for comparison from the document field named myField2.
Suggestions and feedback about alternative ways to accomplish this are welcome :=)

Nice idea.
I think this syntax explains the intent better and also makes it easier to implement. (no need to check for special character)
db.Query("myCollection").Where(c.Field("myField1").Gt(c.Field("myField2"))

Yes, it is the best alternative :)


gitattributes: do not export tests [closes #1529]

Tests are not needed by composer.

Hi @TomasVotruba, thanks for this PR! Do you think you can exclude the features folder folder as well? That's the one with the huge file names because of the Behat features. Thank you!

@mvriel Sure. While we're at it, all these are not used by composer, so I'd exclude them as well:

/ansible
/docs
/features
/tests
.gitattributes
.gitignore
.scrutinizer.yml
.travis.yml
CHANGELOG.md
CONTRIBUTING.md
README.md
VERSION
Vagrantfile
behat.yml
box.json
build.xml
composer.json
composer.lock
package.xml
phpdoc.dist.xml
phpmd.xml.dist
phpunit.xml.dist
wercker.yml

IIRC is .gitattributes and .gitignore used by composer because composer does git clones when you prefer-source it; the VERSION file is required for the correct functioning of phpDocumentor; I also don't know how composer will react when the composer.json and lock file are excluded in this way

The rest does indeed look redundant for a composer installation

Sorry, I forgot to remove composer.* while copying.
.gitattributes and .gitignore can be left out with no problem. I'm using it in many repo, Doctrine too etc.
I've updated the list

Looks like a perfect list :+1:

It's up!

:+1:

This commit needs to be cherry-picked to the master branch as well because that is where the phpDocumentor 2.8.* release is (develop is phpDocumentor 3); I can do that tomorrow (I am in the midst of a refactoring that I'd rather not stash now :) )

:+1:

@mvriel Any update on this?  I'm having this problem on Win 8.1 x64 on a phpdoc 2.8.2 that I pulled today.  Thanks  :)

Apparently this task slipped my mind; I have just cherry-picked this to master and tagged 2.8.3


Razor editor compiles generic type constraints but throws errors

In a razor component, I can compile the following successfully, but the razor compiler generates superfluous errors:
@typeparam T where T : SomeBaseClass, new()
using a partial code-behind class doesn't work.
errors are
(1) : RZ1017 Unexpected literal following the 'typeparam' directive. Expected 'line break'.
(As many as T is used) : CS0246 The type or namespace name 'T' could not be found (are you missing a using directive or an assembly reference?)
T is set explicitly where the component is used.
.NET7, Visual Studio: 17.6.3, up-to-date as of 17th of June, 2023.
added git repo for reproducing:
https://github.com/cetinbas/GenericTypeConstraintError
As a workaround, I deleted the constraints from razor file but kept them in the code-behind. This way it throws no errors.

Duplicate of https://github.com/dotnet/razor/issues/8572


Allow for configuration of the default view context controller

In response to issues https://github.com/drapergem/draper/issues/249 and https://github.com/drapergem/draper/issues/573
Allow for configuration of the default view context controller. This is particularly useful for applications without an ApplicationController (ie engine-driven apps). A string is used rather than a constant so that the default_controller can be set anywhere in the initialization process

@nick-donald Sorry it took so long to get back to you. Thanks for the contribution. It looks like this has been a pain point for a while now. I was able to test this by adding a new initializer containing Draper::ViewContext.default_controller = 'BaseController'. Is that the process you were imagining? Before I merge this, I'd like to see a few more changes:

Update the Railtie's runner to use the new ViewContext.default_controller
Add tests
Add documentation to the README.

Would you be able to take a stab at these things?

@nick-donald I have continued your work in the following pull request:
https://github.com/drapergem/draper/pull/788
Thanks for your help!

sure 👍


add file /lib/domains/ua/com/lpml.txt to add a domain lpml.com.ua

@dchelyuk Pull request merged. Thank you!


Additional mapping and test fixes

@rmohr @stu-gott Can you please take a look  - In a make test run, the unmarshalling of disk/target fails. I just don't find out why.

I tweaked the test so it passes. I don't know why that works. It seems to me the correct name should have been "dev" like @fabiand had it originally. Device is only one of a very small handful of elements where the json key being used does not match the variable name we're tracking it (in v1/schema.go). Other keys that fall into this category are Interface->LinkState, and Devices->Ballooning.
Is the JSON unmarshaller paying attention to the struct tags in schema.go?

Thanks @stu-gott.
So the "problem" is that the unmarshalling is done on the virtwrap.DomainSpec instance which does not have the struct field tags for the json (un)marshaller - thus it falls back to the field names.
And because the virtwrap schema contains xml struct field tags only, the test should also be limited to this.
The json related tests should only be done for the apiv1 schema.
@rmohr thoughts?

It took a few trials, but now it shold be really an improvement.
Once the marshalling is better, it generates nice json/xml documents.
And on the other hand there are some additional test to test this marshalling.

LGTM


Motion detection Unifi g3 instant

Can't get Unifi g3 instant detection working not sure if missing any setting or not will post my config if someone can point me in proper direction to try and get working. Running newest version of camera.ui as well.
"platforms": [
        {
            "name": "Config",
            "port": 8581,
            "platform": "config"
        },
        {
            "name": "CameraUI",
            "debug": false,
            "mqtt": {
                "active": false
            },
            "http": {
                "active": true,
                "localhttp": false
            },
            "smtp": {
                "active": false
            },
            "ftp": {
                "active": false
            },
            "ssl": {
                "active": false
            },
            "cameras": [
                {
                    "name": "Front Door",
                    "manufacturer": "Ubiquiti",
                    "model": "G3 Instant",
                    "serialNumber": "001",
                    "motion": true,
                    "unbridge": true,
                    "hsv": true,
                    "prebuffering": false,
                    "prebufferLength": 4,
                    "videoConfig": {
                        "source": "-i rtsps://xxx.xxx.xxx.xxx:7441/wCtZGCMFfy?enableSrtp",
                        "audio": false
                    },
                    "videoanalysis": {
                        "active": true
                    }
                },
                {
                    "name": "Living Room",
                    "manufacturer": "Ubiquiti",
                    "model": "G3 Instant",
                    "serialNumber": "002",
                    "motion": true,
                    "unbridge": true,
                    "hsv": true,
                    "prebufferLength": 4,
                    "videoConfig": {
                        "source": "-i rtsps://xxx.xxx.xxx.xxx:7441/Pe6VTFPQDh?enableSrtp",
                        "forceMax": false,
                        "audio": false
                    },
                    "videoanalysis": {
                        "active": true
                    }
                }
            ],
            "platform": "CameraUI"
        }
    ]
}

@ctrlcmdshft
try following config
Note: I also enabled "debug" here in the config.json, because if it still doesn't work, the log with debug turned on would help me a lot
Could you please also post me a screenshot of the camera's own settings (e.g. resolution, bitrate, FPS etc)?
{
  "name": "CameraUI",
  "debug": true,
  "mqtt": {
    "active": false
  },
  "http": {
    "active": true,
    "localhttp": false
  },
  "smtp": {
    "active": false
  },
  "ftp": {
    "active": false
  },
  "ssl": {
    "active": false
  },
  "cameras": [
    {
      "name": "Front Door",
      "manufacturer": "Ubiquiti",
      "model": "G3 Instant",
      "serialNumber": "001",
      "motion": true,
      "unbridge": true,
      "hsv": true,
      "prebuffering": true,
      "prebufferLength": 4,
      "videoConfig": {
        "source": "-i rtsps://xxx.xxx.xxx.xxx:7441/wCtZGCMFfy?enableSrtp",
        "rtspTransport": "tcp",
        "vcodec": "copy",
        "acodec": "libfdk_aac",
        "audio": false
      },
      "videoanalysis": {
        "active": true
      }
    },
    {
      "name": "Living Room",
      "manufacturer": "Ubiquiti",
      "model": "G3 Instant",
      "serialNumber": "002",
      "motion": true,
      "unbridge": true,
      "hsv": true,
      "prebuffering": true,
      "prebufferLength": 4,
      "videoConfig": {
        "source": "-i rtsps://xxx.xxx.xxx.xxx:7441/Pe6VTFPQDh?enableSrtp",
        "rtspTransport": "tcp",
        "vcodec": "copy",
        "acodec": "libfdk_aac",
        "audio": false
      },
      "videoanalysis": {
        "active": true
      }
    }
  ],
  "platform": "CameraUI"
}

Which version of homebridge-camera-ui exactly? Because i pushed v5.0.8 a few minutes ago

5.0.8 trying your config now

If it does not work please post the log as well

Heres what shows when walking through camera sight
[1/16/2022, 1:07:08 AM] Homebridge v1.4.0-beta.4 (HAP v0.10.0-beta.7) (Homebridge C8A4) is running on port 53458.
[1/16/2022, 1:07:08 AM] [CameraUI] Setting up HTTP server for motion detection...
[1/16/2022, 1:07:08 AM] [CameraUI] Front Door: Setting up camera, please be patient...
[1/16/2022, 1:07:08 AM] [CameraUI] Front Door: Probe stream: /homebridge/node_modules/homebridge-camera-ui/node_modules/ffmpeg-for-homebridge/ffmpeg -i rtsps://<IP_ADDRESS>:7441/YyNwCtZGCMFfyyf5?enableSrtp
[1/16/2022, 1:07:08 AM] [CameraUI] Living Room: Setting up camera, please be patient...
[1/16/2022, 1:07:08 AM] [CameraUI] Living Room: Probe stream: /homebridge/node_modules/homebridge-camera-ui/node_modules/ffmpeg-for-homebridge/ffmpeg -i rtsps://<IP_ADDRESS>:7441/FPiPe6VTFPQDhskR?enableSrtp
[1/16/2022, 1:07:08 AM] [CameraUI] HTTP server for motion detection is listening on port 7272
[1/16/2022, 1:07:08 AM] [CameraUI] Front Door: {"probe":true,"timedout":false,"audio":["aac (LC)","16000 Hz","mono","fltp"],"video":["h264 (Main)","yuvj420p(pc","bt709","progressive)","1920x1080","30 tbr","90k tbn","60 tbc"]}
[1/16/2022, 1:07:08 AM] [CameraUI] Front Door: Incoming ping request for: rtsps://<IP_ADDRESS>:7441/YyNwCtZGCMFfyyf5?enableSrtp - Timeout: 1s
[1/16/2022, 1:07:08 AM] [CameraUI] Front Door: Pinging <IP_ADDRESS>:7441
[1/16/2022, 1:07:08 AM] [CameraUI] Front Door: Pinging <IP_ADDRESS>:7441 - successful
[1/16/2022, 1:07:08 AM] [CameraUI] Front Door: Start prebuffering...
[1/16/2022, 1:07:08 AM] [CameraUI] Front Door: Prebuffering command: /homebridge/node_modules/homebridge-camera-ui/node_modules/ffmpeg-for-homebridge/ffmpeg -hide_banner -loglevel error -fflags +genpts -rtsp_transport tcp -i rtsps://<IP_ADDRESS>:7441/YyNwCtZGCMFfyyf5?enableSrtp -vcodec copy -an -f tee -map 0:v? -map 0:a? [movflags=frag_keyframe+empty_moov+default_base_moof:f=mp4]tcp://<IP_ADDRESS>:37734|[f=mpegts]tcp://<IP_ADDRESS>:20087
[1/16/2022, 1:07:08 AM] [CameraUI] Living Room: {"probe":true,"timedout":false,"audio":["aac","16000 Hz","mono","fltp"],"video":["h264 (Main)","yuvj420p(pc","bt709","progressive)","1920x1080","30 tbr","90k tbn","60 tbc"]}
[1/16/2022, 1:07:08 AM] [CameraUI] Living Room: Incoming ping request for: rtsps://<IP_ADDRESS>:7441/FPiPe6VTFPQDhskR?enableSrtp - Timeout: 1s
[1/16/2022, 1:07:08 AM] [CameraUI] Living Room: Pinging <IP_ADDRESS>:7441
[1/16/2022, 1:07:08 AM] [CameraUI] Living Room: Pinging <IP_ADDRESS>:7441 - successful
[1/16/2022, 1:07:08 AM] [CameraUI] Living Room: Start prebuffering...
[1/16/2022, 1:07:08 AM] [CameraUI] Living Room: Prebuffering command: /homebridge/node_modules/homebridge-camera-ui/node_modules/ffmpeg-for-homebridge/ffmpeg -hide_banner -loglevel error -fflags +genpts -rtsp_transport tcp -i rtsps://<IP_ADDRESS>:7441/FPiPe6VTFPQDhskR?enableSrtp -vcodec copy -an -f tee -map 0:v? -map 0:a? [movflags=frag_keyframe+empty_moov+default_base_moof:f=mp4]tcp://<IP_ADDRESS>:30813|[f=mpegts]tcp://<IP_ADDRESS>:16247
[1/16/2022, 1:07:09 AM] [CameraUI] Front Door: Prebuffering scheduled for restart at 2AM: 53 minutes
[1/16/2022, 1:07:09 AM] [CameraUI] Front Door: Incoming ping request for: rtsps://<IP_ADDRESS>:7441/YyNwCtZGCMFfyyf5?enableSrtp - Timeout: 1s
[1/16/2022, 1:07:09 AM] [CameraUI] Front Door: Pinging <IP_ADDRESS>:7441
[1/16/2022, 1:07:09 AM] [CameraUI] Living Room: Prebuffering scheduled for restart at 2AM: 53 minutes
[1/16/2022, 1:07:09 AM] [CameraUI] Living Room: Incoming ping request for: rtsps://<IP_ADDRESS>:7441/FPiPe6VTFPQDhskR?enableSrtp - Timeout: 1s
[1/16/2022, 1:07:09 AM] [CameraUI] Living Room: Pinging <IP_ADDRESS>:7441
[1/16/2022, 1:07:09 AM] [CameraUI] Front Door: Pinging <IP_ADDRESS>:7441 - successful
[1/16/2022, 1:07:09 AM] [CameraUI] Front Door: Start videoanalysis...
[1/16/2022, 1:07:09 AM] [CameraUI] Front Door: Videoanalysis command: /homebridge/node_modules/homebridge-camera-ui/node_modules/ffmpeg-for-homebridge/ffmpeg -hide_banner -loglevel error -analyzeduration 0 -probesize 500000 -f mpegts -i tcp://<IP_ADDRESS>:25846 -an -vcodec pam -pix_fmt rgb24 -f image2pipe -vf fps=2,scale=640:360 pipe:1
[1/16/2022, 1:07:09 AM] [CameraUI] Front Door: Videoanalysis: Difference: 9 - Sensitivity: 5 - Zones: [{"name":"region0","difference":9,"percent":95,"polygon":[{"x":634,"y":4},{"x":634,"y":356},{"x":173,"y":356},{"x":147,"y":0}]}]
[1/16/2022, 1:07:09 AM] [CameraUI] Front Door: Videoanalysis scheduled for restart at 4AM: 173 minutes
[1/16/2022, 1:07:09 AM] [CameraUI] Living Room: Pinging <IP_ADDRESS>:7441 - successful
[1/16/2022, 1:07:09 AM] [CameraUI] Living Room: Start videoanalysis...
[1/16/2022, 1:07:09 AM] [CameraUI] Living Room: Videoanalysis command: /homebridge/node_modules/homebridge-camera-ui/node_modules/ffmpeg-for-homebridge/ffmpeg -hide_banner -loglevel error -analyzeduration 0 -probesize 500000 -f mpegts -i tcp://<IP_ADDRESS>:17372 -an -vcodec pam -pix_fmt rgb24 -f image2pipe -vf fps=2,scale=640:360 pipe:1
[1/16/2022, 1:07:09 AM] [CameraUI] Living Room: Videoanalysis: Difference: 9 - Sensitivity: 5 - Zones: [{"name":"region0","difference":9,"percent":95,"polygon":[{"x":634,"y":4},{"x":634,"y":356},{"x":243,"y":356},{"x":160,"y":0}]}]
[1/16/2022, 1:07:09 AM] [CameraUI] Living Room: Videoanalysis scheduled for restart at 4AM: 173 minutes
[1/16/2022, 1:07:09 AM] [CameraUI] Front Door: Configuring unbridged accessory...
[1/16/2022, 1:07:09 AM] [CameraUI] Front Door: Setting up accessory...
[1/16/2022, 1:07:09 AM] [CameraUI] Front Door: Adding motion sensor service
[1/16/2022, 1:07:09 AM] [CameraUI] Front Door: Initializing HomeKit Secure Video
[1/16/2022, 1:07:10 AM] [CameraUI] Living Room: Configuring unbridged accessory...
[1/16/2022, 1:07:10 AM] [CameraUI] Living Room: Setting up accessory...
[1/16/2022, 1:07:10 AM] [CameraUI] Living Room: Adding motion sensor service
[1/16/2022, 1:07:10 AM] [CameraUI] Living Room: Initializing HomeKit Secure Video
[1/16/2022, 1:07:10 AM] [CameraUI] camera.ui v5.0.8 is listening on port 8081 (http)
[1/16/2022, 1:07:10 AM] [CameraUI] Front Door: Videoanalysis finished launching
[1/16/2022, 1:07:10 AM] [CameraUI] Living Room: Videoanalysis finished launching
[1/16/2022, 1:07:10 AM] Front Door 8035 is running on port 42427.
[1/16/2022, 1:07:10 AM] Please add [Front Door 8035] manually in Home app. Setup Code: 031-45-154
[1/16/2022, 1:07:10 AM] Living Room CA62 is running on port 39383.
[1/16/2022, 1:07:10 AM] Please add [Living Room CA62] manually in Home app. Setup Code: 031-45-154
[1/16/2022, 1:07:52 AM] [CameraUI] Living Room: Snapshot requested: 1280 x 720
[1/16/2022, 1:07:52 AM] [CameraUI] Living Room: Snapshot command: /homebridge/node_modules/homebridge-camera-ui/node_modules/ffmpeg-for-homebridge/ffmpeg -hide_banner -loglevel error -analyzeduration 0 -probesize 1048288 -f mpegts -i tcp://<IP_ADDRESS>:37674 -frames:v 1 -f image2 -
[1/16/2022, 1:07:53 AM] [CameraUI] Living Room: Prebuffer request ended
[1/16/2022, 1:07:53 AM] [CameraUI] Living Room: Fetching snapshot took 0.519 seconds.
[1/16/2022, 1:07:53 AM] [CameraUI] Living Room: Sending snapshot: 1280x720
[1/16/2022, 1:07:53 AM] [CameraUI] Living Room: Resize command: /homebridge/node_modules/homebridge-camera-ui/node_modules/ffmpeg-for-homebridge/ffmpeg -i pipe: -frames:v 1 -filter:v scale='min(1280,iw)':'min(720,ih)':force_original_aspect_ratio=decrease -f image2 -
[1/16/2022, 1:07:57 AM] [CameraUI] Living Room: Start stream requested: 1280x720, 30 fps, 299 kbps
[1/16/2022, 1:07:57 AM] [CameraUI] Living Room: Incoming ping request for: rtsps://<IP_ADDRESS>:7441/FPiPe6VTFPQDhskR?enableSrtp - Timeout: 1s
[1/16/2022, 1:07:57 AM] [CameraUI] Living Room: Pinging <IP_ADDRESS>:7441
[1/16/2022, 1:07:57 AM] [CameraUI] Living Room: Pinging <IP_ADDRESS>:7441 - successful
[1/16/2022, 1:07:57 AM] [CameraUI] Living Room: Setting prebuffer stream as input
[1/16/2022, 1:07:57 AM] [CameraUI] Living Room: Starting video stream: native
[1/16/2022, 1:07:57 AM] [CameraUI] Living Room: Stream command: /homebridge/node_modules/homebridge-camera-ui/node_modules/ffmpeg-for-homebridge/ffmpeg -hide_banner -loglevel level -analyzeduration 0 -probesize 500000 -f mpegts -i tcp://<IP_ADDRESS>:19645 -an -sn -dn -vcodec copy -pix_fmt yuv420p -color_range mpeg -f rawvideo -payload_type 99 -ssrc 7098404 -f rtp -srtp_out_suite AES_CM_128_HMAC_SHA1_80 -srtp_out_params f+IS1LQATPVlTfyYFszfi3aGVmMuCB3B87tmAxee srtp://<IP_ADDRESS>:55197?rtcpport=55197&pkt_size=1318 -progress pipe:1
[1/16/2022, 1:07:58 AM] [CameraUI] Living Room: Getting the first frames took 0.768 seconds.
[1/16/2022, 1:08:02 AM] [CameraUI] Living Room: Stop stream requested
[1/16/2022, 1:08:02 AM] [CameraUI] Living Room: Stopped video stream.
[1/16/2022, 1:08:02 AM] [CameraUI] Living Room: Prebuffer request ended
[1/16/2022, 1:08:02 AM] [CameraUI] Living Room: FFmpeg exited with code: null and signal: SIGKILL (Expected)
[1/16/2022, 1:08:21 AM] [CameraUI] Living Room: Snapshot requested: 1280 x 720
[1/16/2022, 1:08:21 AM] [CameraUI] Living Room: Snapshot command: /homebridge/node_modules/homebridge-camera-ui/node_modules/ffmpeg-for-homebridge/ffmpeg -hide_banner -loglevel error -analyzeduration 0 -probesize 1117472 -f mpegts -i tcp://<IP_ADDRESS>:19888 -frames:v 1 -f image2 -
[1/16/2022, 1:08:22 AM] [CameraUI] Living Room: Prebuffer request ended
[1/16/2022, 1:08:22 AM] [CameraUI] Living Room: Fetching snapshot took 0.545 seconds.
[1/16/2022, 1:08:22 AM] [CameraUI] Living Room: Sending snapshot: 1280x720
[1/16/2022, 1:08:22 AM] [CameraUI] Living Room: Resize command: /homebridge/node_modules/homebridge-camera-ui/node_modules/ffmpeg-for-homebridge/ffmpeg -i pipe: -frames:v 1 -filter:v scale='min(1280,iw)':'min(720,ih)':force_original_aspect_ratio=decrease -f image2 -
[1/16/2022, 1:08:26 AM] [CameraUI] Front Door: Snapshot requested: 1280 x 720
[1/16/2022, 1:08:26 AM] [CameraUI] Front Door: Snapshot command: /homebridge/node_modules/homebridge-camera-ui/node_modules/ffmpeg-for-homebridge/ffmpeg -hide_banner -loglevel error -analyzeduration 0 -probesize 500000 -f mpegts -i tcp://<IP_ADDRESS>:18909 -frames:v 1 -f image2 -
[1/16/2022, 1:08:26 AM] [CameraUI] Front Door: Prebuffer request ended
[1/16/2022, 1:08:26 AM] [CameraUI] Front Door: Fetching snapshot took 0.458 seconds.
[1/16/2022, 1:08:26 AM] [CameraUI] Front Door: Sending snapshot: 1280x720
[1/16/2022, 1:08:26 AM] [CameraUI] Front Door: Resize command: /homebridge/node_modules/homebridge-camera-ui/node_modules/ffmpeg-for-homebridge/ffmpeg -i pipe: -frames:v 1 -filter:v scale='min(1280,iw)':'min(720,ih)':force_original_aspect_ratio=decrease -f image2 -
[1/16/2022, 1:08:27 AM] [CameraUI] Front Door: Start stream requested: 1280x720, 30 fps, 299 kbps
[1/16/2022, 1:08:27 AM] [CameraUI] Front Door: Incoming ping request for: rtsps://<IP_ADDRESS>:7441/YyNwCtZGCMFfyyf5?enableSrtp - Timeout: 1s
[1/16/2022, 1:08:27 AM] [CameraUI] Front Door: Pinging <IP_ADDRESS>:7441
[1/16/2022, 1:08:27 AM] [CameraUI] Front Door: Pinging <IP_ADDRESS>:7441 - successful
[1/16/2022, 1:08:27 AM] [CameraUI] Front Door: Setting prebuffer stream as input
[1/16/2022, 1:08:27 AM] [CameraUI] Front Door: Starting video stream: native
[1/16/2022, 1:08:27 AM] [CameraUI] Front Door: Stream command: /homebridge/node_modules/homebridge-camera-ui/node_modules/ffmpeg-for-homebridge/ffmpeg -hide_banner -loglevel level -analyzeduration 0 -probesize 521512 -f mpegts -i tcp://<IP_ADDRESS>:29409 -an -sn -dn -vcodec copy -pix_fmt yuv420p -color_range mpeg -f rawvideo -payload_type 99 -ssrc 9333336 -f rtp -srtp_out_suite AES_CM_128_HMAC_SHA1_80 -srtp_out_params d1Ibnp03P/OZPcamf4Hty5+rqN+57AgPRcrDCZfD srtp://<IP_ADDRESS>:63976?rtcpport=63976&pkt_size=1318 -progress pipe:1
[1/16/2022, 1:08:28 AM] [CameraUI] Front Door: Getting the first frames took 0.801 seconds.
[1/16/2022, 1:08:31 AM] [CameraUI] Front Door: Stop stream requested
[1/16/2022, 1:08:31 AM] [CameraUI] Front Door: Stopped video stream.
[1/16/2022, 1:08:31 AM] [CameraUI] Front Door: Prebuffer request ended
[1/16/2022, 1:08:31 AM] [CameraUI] Front Door: FFmpeg exited with code: null and signal: SIGKILL (Expected)
[1/16/2022, 1:08:41 AM] [CameraUI] Front Door: Snapshot requested: 1280 x 720
[1/16/2022, 1:08:41 AM] [CameraUI] Front Door: Snapshot command: /homebridge/node_modules/homebridge-camera-ui/node_modules/ffmpeg-for-homebridge/ffmpeg -hide_banner -loglevel error -analyzeduration 0 -probesize 743916 -f mpegts -i tcp://<IP_ADDRESS>:15896 -frames:v 1 -f image2 -
[1/16/2022, 1:08:43 AM] [CameraUI] Front Door: Prebuffer request ended
[1/16/2022, 1:08:43 AM] [CameraUI] Front Door: Fetching snapshot took 1.337 seconds.
[1/16/2022, 1:08:43 AM] [CameraUI] Front Door: Sending snapshot: 1280x720
[1/16/2022, 1:08:43 AM] [CameraUI] Front Door: Resize command: /homebridge/node_modules/homebridge-camera-ui/node_modules/ffmpeg-for-homebridge/ffmpeg -i pipe: -frames:v 1 -filter:v scale='min(1280,iw)':'min(720,ih)':force_original_aspect_ratio=decrease -f image2 -

@ctrlcmdshft
open camera.ui interface > login > settings > cameras > select camera > video analysis > set sensitivity to 90 and difference to 1

now this over and over with out walking through camera sight
[1/16/2022, 1:14:15 AM] [CameraUI] Front Door: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:16 AM] [CameraUI] Living Room: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:16 AM] [CameraUI] Front Door: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:16 AM] [CameraUI] Front Door: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:16 AM] [CameraUI] Living Room: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:16 AM] [CameraUI] Living Room: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:16 AM] [CameraUI] Front Door: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:17 AM] [CameraUI] Front Door: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:17 AM] [CameraUI] Front Door: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:17 AM] [CameraUI] Living Room: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:17 AM] [CameraUI] Front Door: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:17 AM] [CameraUI] Front Door: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:17 AM] [CameraUI] Front Door: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:17 AM] [CameraUI] Living Room: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:18 AM] [CameraUI] Living Room: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:18 AM] [CameraUI] Front Door: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:18 AM] [CameraUI] Living Room: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:18 AM] [CameraUI] Front Door: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:19 AM] [CameraUI] Front Door: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:19 AM] [CameraUI] Living Room: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:19 AM] [CameraUI] Front Door: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:20 AM] [CameraUI] Front Door: Dwell time resetted because new motion detected, resetting motion in 60s..

now this over and over with out walking through camera sight
[1/16/2022, 1:14:15 AM] [CameraUI] Front Door: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:16 AM] [CameraUI] Living Room: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:16 AM] [CameraUI] Front Door: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:16 AM] [CameraUI] Front Door: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:16 AM] [CameraUI] Living Room: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:16 AM] [CameraUI] Living Room: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:16 AM] [CameraUI] Front Door: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:17 AM] [CameraUI] Front Door: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:17 AM] [CameraUI] Front Door: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:17 AM] [CameraUI] Living Room: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:17 AM] [CameraUI] Front Door: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:17 AM] [CameraUI] Front Door: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:17 AM] [CameraUI] Front Door: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:17 AM] [CameraUI] Living Room: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:18 AM] [CameraUI] Living Room: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:18 AM] [CameraUI] Front Door: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:18 AM] [CameraUI] Living Room: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:18 AM] [CameraUI] Front Door: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:19 AM] [CameraUI] Front Door: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:19 AM] [CameraUI] Living Room: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:19 AM] [CameraUI] Front Door: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:14:20 AM] [CameraUI] Front Door: Dwell time resetted because new motion detected, resetting motion in 60s..

Ok sensitivity might be to high, set it to 50
and you need to wait for the dwell time to be resetted before new motion can be triggered
but before this messages, there must ve a „recording“ event? Somethink like „Motion ON“

after lowering still doing same message over and over

Lowered to 20 now this message
[1/16/2022, 1:20:24 AM] [CameraUI] GET /api/system/log 200 9.450 ms - 200000
[1/16/2022, 1:20:25 AM] [CameraUI] Living Room: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:20:26 AM] [CameraUI] Front Door: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:20:27 AM] [CameraUI] Living Room: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:20:27 AM] [CameraUI] VIDEOANALYSIS: New message: Motion: resetted - Reason: forceClose - Camera: Front Door
[1/16/2022, 1:20:28 AM] [CameraUI] Living Room: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:20:28 AM] [CameraUI] Living Room: Motion OFF - Motion handler timeout.
[1/16/2022, 1:20:28 AM] [CameraUI] Living Room: Closing recording process
[1/16/2022, 1:20:28 AM] [CameraUI] Living Room: FFMPEG socket closed during read for 8 bytes!
[1/16/2022, 1:20:28 AM] [CameraUI] Living Room: Recording completed (HSV)
[1/16/2022, 1:20:28 AM] [CameraUI] Living Room: Prebuffer request ended
[1/16/2022, 1:20:28 AM] [CameraUI] Living Room: FFmpeg recording process exited (expected)
[1/16/2022, 1:20:28 AM] [CameraUI] Living Room: New custom alert
[1/16/2022, 1:20:28 AM] [CameraUI] Living Room: Notifications not enabled, skip Webhook..
[1/16/2022, 1:20:28 AM] [CameraUI] Living Room: Notifications not enabled, skip Alexa..
[1/16/2022, 1:20:28 AM] [CameraUI] Living Room: Recording not enabled, skip recording..
[1/16/2022, 1:20:28 AM] [CameraUI] Living Room: Recording skipped. Notification skipped.
[1/16/2022, 1:20:29 AM] [CameraUI] VIDEOANALYSIS: New message: Motion: detected - Reason: pixelDifference - Camera: Front Door
[1/16/2022, 1:20:29 AM] [CameraUI] Front Door: Motion ON
[1/16/2022, 1:20:29 AM] [CameraUI] Front Door: Video fragments requested from HSV
[1/16/2022, 1:20:29 AM] [CameraUI] Front Door: Setting prebuffer stream as input
[1/16/2022, 1:20:29 AM] [CameraUI] Front Door: Prebuffer requested with a duration of -4s
[1/16/2022, 1:20:29 AM] [CameraUI] Front Door: Start recording...
[1/16/2022, 1:20:29 AM] [CameraUI] Front Door: Recording command: /homebridge/node_modules/homebridge-camera-ui/node_modules/ffmpeg-for-homebridge/ffmpeg -hide_banner -analyzeduration 0 -probesize 500000 -f mp4 -i tcp://<IP_ADDRESS>:31493 -f mp4 -vcodec copy -an -movflags frag_keyframe+empty_moov+default_base_moof -max_muxing_queue_size 1024 tcp://<IP_ADDRESS>:29791
[1/16/2022, 1:20:29 AM] [CameraUI] Front Door: Recording started
[1/16/2022, 1:20:33 AM] [CameraUI] Front Door: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:20:33 AM] [CameraUI] Living Room: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:20:34 AM] [CameraUI] Front Door: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:20:34 AM] [CameraUI] Living Room: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:20:34 AM] [CameraUI] Front Door: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:20:44 AM] [CameraUI] Front Door: Motion OFF - Motion handler timeout.
[1/16/2022, 1:20:46 AM] [CameraUI] Living Room: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:20:46 AM] [CameraUI] Front Door: Recording completed (HSV)
[1/16/2022, 1:20:46 AM] [CameraUI] Front Door: Closing recording process
[1/16/2022, 1:20:46 AM] [CameraUI] Front Door: Prebuffer request ended
[1/16/2022, 1:20:46 AM] [CameraUI] Front Door: FFmpeg recording process exited (expected)
[1/16/2022, 1:20:46 AM] [CameraUI] Front Door: New custom alert
[1/16/2022, 1:20:46 AM] [CameraUI] Front Door: Notifications not enabled, skip Webhook..
[1/16/2022, 1:20:46 AM] [CameraUI] Front Door: Notifications not enabled, skip Alexa..
[1/16/2022, 1:20:46 AM] [CameraUI] Front Door: Recording not enabled, skip recording..
[1/16/2022, 1:20:46 AM] [CameraUI] Front Door: Recording skipped. Notification skipped.
[1/16/2022, 1:20:46 AM] [CameraUI] Front Door: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:20:46 AM] [CameraUI] Living Room: Dwell time resetted because new motion detected, resetting motion in 60s..
[1/16/2022, 1:20:49 AM] [CameraUI] Front Door: Dwell time resetted because new motion detected, resetting motion in 60s..

ok very nice, motion is detected and recording also worked without errors
The messages with dwell time means it detects motion while dwell time is active
Videoanalysis has a dwell time of 60s until it can regonize a new movement
Dwell time means that after a motion sensor is tripped it will need a 90s period in which it detects no motion in order to "reset" back to its default detection mode. This prevents the sensor from sending out multiple alerts for the same motion.
Note: Apple sometimes needs some time to see the camera as HKSV capable. If you don't get HKSV messages (according to the log, motion is detected) try to reboot your hub and/or disable/enable "Stream & Record" in the Home app several times. This usually fixes the Apple Sync error

ok ill try that with the home app setting and also what should i keep/put sensitivity difference to the 90/1

And dont worry, the spam with dwell time in the log is only visible if debug is enabled (its for me to debug the system better)
i have sensitivity at 60 and difference at 5. But that might be too low/high for you, so you need to find out for yourself which settings is the best for your camera(s)

Thanks I see recording in home app. how do i get home app to alert me with a banner is that only available when not in the home

Thanks I see recording in home app. how do i get home app to alert me with a banner is that only available when not in the home

Check the notification settings in the home app for the camera
https://user-images.githubusercontent.com/34152761/149649972-d3388ce0-64ec-41b0-b481-bc4229e99c74.MOV
There you can also set conditions like time and/or location of you

I think we could solve everything :)? Then I close the issue

ok TY for the help


chore(devServer): get devServer config from this.dev

PR Details

get devServer config from this.dev instead of from this.conf.tools.devServer
builder.startDevServer 支持透传与构建无关的 dev server 配置 & 修复非 8080 端口热更新不生效问题

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My code follows the code style of this project.
[ ] I have updated changeset
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

👏🏻


Update README.adoc Micrometer tracing doc link

Upad Micrometer tracing doc link
The old one is not found anymore

Thank you!

@pivotal-cla This is an Obvious Fix

@zydmayday This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary.


Failed to resolve: me.relax:circleindicator:1.2.2

Failed to resolve: me.relax:circleindicator:1.2.2
Show in File
Show in Project Structure dialog
It looks like the source is no longer accessible here because if I navigate to circle.me, I receive this error.
"Services for this domain have been discontinued"

me.rel【e】x:circleindicator:1.2.2@aar


Remove permissions from library manifest

I had this issue today.
Could you please publish this new version into MavenCentral?
Thanks

You can remove this permission in der merged manifest:

Thanks 👍


Update README.md

Description
Replace this text with a summary of the changes in this PR. Include why the changes are needed and context about the changes. List required dependencies. If there is a Git issue for the change, please link to it.
Types of changes in this PR
Changes that affect the core Terraform module or submodules

[ ] Bug fix
[ ] New feature
[ ] Dependency update

Changes that don't affect the core Terraform module or submodules

[ ] Examples or tests (addition or updates of examples or tests)
[ ] Documentation update
[ ] CI-related update (pipeline, etc.)
[ ] Other

Release required?
Identify the type of release. For information about the changes in a semantic versioning release, see Release versioning.

[ ] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content
If a release is required, replace this text with information that users need to know about the release. Write the release notes to help users understand the changes, and include information about how to update from the previous version.
Your notes help the merger write the commit message for the PR that is published in the release notes for the module.
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

Use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author. The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).
Merge by using "Squash and merge".

@vburckhardt Do you still want to proceed with this change?

/run pipeline

/run pipeline

:tada: This PR is included in version 4.5.3 :tada:
The release is available on:

GitHub release
v4.5.3

Your semantic-release bot :package::rocket:


Refactor controllers

In this branch I did

refactor api controllers for authentication
update automobiles controller to display in reverse order and add :photo to permit

[[# STATUS: APPROVED :green_circle: :clap:
Hello @fithamlak,
Your milestone is complete!  There is nothing else to say other than... it's time to merge it :shipit:  a.
Congratulations! 🎉  Keep up the good work 🥂
HIGHLIGHTS:

[x]  Your PR is professional  😎
[x] Descriptive P.R 💯
[x] No linter errors

Now you can merge this branch and move on :1st_place_medal:
Happy Coding cheers 🥇 💯

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.]]


ts80007 is incorrect at times?

🔍 Search Terms
async/await conditional is-promise promise
✅ Viability Checklist

[X] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[X] This wouldn't change the runtime behavior of existing JavaScript code
[X] This could be implemented without emitting different JS based on the types of the expressions
[X] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[X] This isn't a request to add a new utility type: https://github.com/microsoft/TypeScript/wiki/No-New-Utility-Types
[X] This feature would agree with the rest of our Design Goals: https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals

⭐ Suggestion
For reference, isPromise(x) looks like:
(client as any).ensure = () => {
  if (client.isOpen) {
    return;
  }
  return client.connect();
}

const isPromise = (x: any) => {
  return x && typeof x.then === 'function' && typeof x.catch === 'function';
}

here is what I saw:

this is pretty handy code, IMO, more performant etc, big win, but at the same time we all like to avoid if/else where possible, in this case, I think TS shouldn't complain?
📃 Motivating Example
see above
💻 Use Cases

What do you want to use this for?  async/await optimizations
What shortcomings exist with current approaches?
What workarounds are you using in the meantime?

This one isn't a compile error though, is it?  I thought it was just a lightbulb in the IDE and you're free to ignore it.

Just write the return type of isPromise as x is Promise<any> if you want to make the types accurate enough for this suggestion diagnostic to follow