[AutoPR cognitiveservices/data-plane/LUIS/Authoring] [Cogsvcs] LUIS - add text to simple entity description

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/5216

(message created by the CI based on PR content)

Codecov Report

Merging #4375 into restapi_auto_cognitiveservices/data-plane/LUIS/Authoring will decrease coverage by <.01%.
The diff coverage is n/a.

@@                                     Coverage Diff                                      @@
##           restapi_auto_cognitiveservices/data-plane/LUIS/Authoring    #4375      +/-   ##
============================================================================================
- Coverage                                                     53.38%   53.37%   -0.01%
============================================================================================
  Files                                                         10462    10454       -8
  Lines                                                        219469   219461       -8
============================================================================================
- Hits                                                         117156   117148       -8
  Misses                                                       102313   102313

Impacted Files
Coverage Δ

...zure-mgmt-cognitiveservices/azure/mgmt/__init__.py

...on-face/azure/cognitiveservices/vision/__init__.py

...bsearch/azure/cognitiveservices/search/__init__.py

...suggest/azure/cognitiveservices/search/__init__.py

...-luis/azure/cognitiveservices/language/__init__.py

...ledge-qnamaker/azure/cognitiveservices/__init__.py

...arch-websearch/azure/cognitiveservices/__init__.py

azure-mgmt-advisor/azure/mgmt/__init__.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f68c120...d3c2ca9. Read the comment docs.

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/4389


Keep the filter column visible while scrolling through template cards

We want to be able to have our filter column persist while scrolling through the template cards. Today, if you scroll too far down the page you will have to scroll back up to view / select filters.

Marked as P1. Not a blocker for build
cc @gkulin @kristenwomack


Handle unknown download errors without segmentation fault

Two independent customers with the same MITM HTTP proxy product will suddenly terminate the TCP connection while downloading a file off PivNet for unknown reasons (perhaps it thinks there's a virus inside?).   This doesn't result in an ECONNRESET or any net.OpError, but some other error, and the old error handler didn't check for this, resulting in a segfault.
If you run the unit test in this PR against the old code, i.e.
operr, _ := err.(*net.OpError)
	if operr.Err.Error() == syscall.ECONNRESET.Error() {

The type assertion fails but we don't check this, and a segfault occurs.
worlock:go-pivnet stuartcharlton$ cd download
worlock:download stuartcharlton$
worlock:download stuartcharlton$  CGO_ENABLED=1 ginkgo \
>     -race \
>     -randomizeAllSpecs \
>     -randomizeSuites \
>     -slowSpecThreshold="40" .
Running Suite: Download Suite
=============================
Random Seed:<PHONE_NUMBER> - Will randomize all specs
Will run 17 of 17 specs

•••••••••••••panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x40 pc=0x9b4a2]

goroutine 40 [running]:
panic(0x46af80, 0xc4200100c0)
	/usr/local/Cellar/go/1.7.3/libexec/src/runtime/panic.go:500 +0x1ae
github.com/pivotal-cf/go-pivnet/download.Client.retryableRequest(0x699000, 0xc420389180, 0x699040, 0xc42042e100, 0x69ee00, 0xc420448680, 0x0, 0x0, 0xc42042aa20, 0x1d, ...)
	/Users/stuartcharlton/github/concourse/gopivnet-gopath/src/github.com/pivotal-cf/go-pivnet/download/downloader.go:164 +0x8c2
github.com/pivotal-cf/go-pivnet/download.Client.Get.func1(0x8, 0x506d78)
	/Users/stuartcharlton/github/concourse/gopivnet-gopath/src/github.com/pivotal-cf/go-pivnet/download/downloader.go:92 +0x174
github.com/pivotal-cf/go-pivnet/vendor/golang.org/x/sync/errgroup.(*Group).Go.func1(0xc42042c600, 0xc42042e300)
	/Users/stuartcharlton/github/concourse/gopivnet-gopath/src/github.com/pivotal-cf/go-pivnet/vendor/golang.org/x/sync/errgroup/errgroup.go:58 +0x69
created by github.com/pivotal-cf/go-pivnet/vendor/golang.org/x/sync/errgroup.(*Group).Go
	/Users/stuartcharlton/github/concourse/gopivnet-gopath/src/github.com/pivotal-cf/go-pivnet/vendor/golang.org/x/sync/errgroup/errgroup.go:66 +0x74

Ginkgo ran 1 suite in 1.440593194s
Test Suite Failed

This fix includes the test case and the simple fix to prevent this segfault.
Unfortunately it doesn't solve the larger problem of what to do with proxies that like to terminate connections for unknown reasons, which I think would require some kind of capped retries, but I'll experiment with that in a separate PR.

Presumably this is fixed in 88f6f3c87fb6515994919add18b88ba73559fe6d with the two client approach and the error I was getting triggering the segfault was timeout related.   I'm not seeing the segfault anymore so I'll close this.


Add Kerr and Kerr-Newman metric in Boyer-Lindquist coordinates to predefined metrics

🐞 Problem
symbolic/predefined/vacuum_solutions.py needs Kerr and Kerr-Newman Metrics. Implement them similar to already implemented Schwarzschild() in the same file.
💡 Possible solutions

[x] Kerr (c737c8b)
[ ] Kerr Newman

The metrics can be found be simple search on wikipedia. Also implementation can be found in utils/kerr_utils.py and utils/kerrnewman_utils.py
📋  Steps to solve the problem

Comment below about what you've started working on.
Add, commit, push your changes
Submit a pull request and add this in comments - Addresses #<put issue number here>
Ask for a review in comments section of pull request
Celebrate your contribution to this project 🎉

Can I take up this issue ?

Try this one.
Regards,
Ritwik

On 02-Feb-2020, at 3:08 PM, sagnik-chatterjee<EMAIL_ADDRESS>wrote:

Can I take up this issue ?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.

Hi I am interested in helping with this issue, but i am new to git and open source contribution. If its alright, could I take this issue? My background is in theoretical physics (GR), so I understand the symbolic/analytic side of the problem, but just wanted to learn and apply git and python codings. I am reading through the developer guide and the git intro at the moment, so I am hoping to deal with an actual issue ticket to apply my learning.

Sure @gimseng ! Take up the issue whenever you are comfortable. Ask us when you are stuck.
Also, kindly join our community Chatroom on Riot.
https://riot.im/app/#/room/%23einsteinpy:matrix.org

Thanks I will tackle this. If I understand it correctly, the Kerr one has been updated, so I just need to include the charge (Kerr-Newman) appropriately.

Yups. That’s correct
Regards,
Ritwik

On 10-Feb-2020, at 8:08 PM, Gim Seng<EMAIL_ADDRESS>wrote:

Thanks I will tackle this. If I understand it correctly, the Kerr one has been updated, so I just need to include the charge (Kerr-Newman) appropriately.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.

Thanks! I am almost done now, but have two questions:

I need a new constant "eps0" (electric constant or permittivity of free space). I defaulted it to "constants.eps0", could somehow help me to find where in the codes should I update/add this values?

I needed 'pi', do we do math.pi or its defined as constants.pi or something?

Sorry to ask trivial questions, since I am new to EinsteinPy, and I thought maybe I could use the opportunities to ask questions on this discussion area. Thanks !

Nvm, I figured them out, will do a pull request.

Closed via #427


Repo sync for protected CLA branch

The pull request is created from main637841700058914728 to main to fix git push error for protected CLA branch

@opbld17 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Absolute path file:// URLs broken on Windows

https://github.com/santhosh-tekuri/jsonschema/commit/6089779f465b91ba83f107f8a1dc48b05040e371 broke file:// URLs on Windows, where the path begins with something like C:/
e.g. for file://C:/foo.txt, url.Parse will place "C:" in the Host field, and "/foo.txt" in the Path field.

Never mind, I realised I was holding it wrong. Just need another '/' at the front (e.g. file:///C:/foo.txt)


[WIP] Add more tests

enhance integration tests to cal test coverage (spilt them into unit and integration in codecov report)
add basic IT test

Codecov Report

Merging #695 (90e9050) into develop (3a26d7a) will decrease coverage by 9.84%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop     #695      +/-   ##
=============================================
- Coverage      20.98%   11.13%   -9.85%
+ Complexity       326      137     -189
=============================================
  Files             97       97
  Lines           3746     3744       -2
  Branches         585      583       -2
=============================================
- Hits             786      417     -369
- Misses          2883     3265     +382
+ Partials          77       62      -15

Flag
Coverage Δ
Complexity Δ

integration
11.13% <ø> (?)
0.00 <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a26d7a...8a6e164. Read the comment docs.

Codecov Report

Merging #695 (b35ef5c) into develop (3a26d7a) will decrease coverage by 3.75%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop     #695      +/-   ##
=============================================
- Coverage      20.98%   17.22%   -3.76%
+ Complexity       326      234      -92
=============================================
  Files             97       97
  Lines           3746     3744       -2
  Branches         585      583       -2
=============================================
- Hits             786      645     -141
- Misses          2883     3021     +138
- Partials          77       78       +1

Flag
Coverage Δ
Complexity Δ

integration
17.22% <ø> (?)
0.00 <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a26d7a...b35ef5c. Read the comment docs.


Rare Crash in ATStorage.m line 148 -[ATStorage insertHit:mhOlt:]

We observe a rare crash in 2.0.9: http://crashes.to/s/d3db1315e5e
Crashed: NSOperationQueue 0x16886110 :: NSOperation 0x1839af10 (QOS: LEGACY)
EXC_BAD_ACCESS KERN_INVALID_ADDRESS 0x0000000000000000

CoreFoundation __CFBasicHashAddValue + 536
CoreData	 _sharedIMPL_setvfk_core + 130
ATStorage.m line 148 -[ATStorage insertHit:mhOlt:]
ATSender.m line 220 __38-[ATSender sendWithCompletionHandler:]_block_invoke

Hi,
Does this happen randomly while trying to send hits ?
Would you be able to send us a small project with the code that causes this crash ?
Regards

Sorry, no. It's so rare, we only observed it in production with a lot of users. If it's not easy to track down from the crash report and the source code, it's probably not worth spending too much time with it.

We will try to reproduce the bug and will let you know when we find the problem
Regards

Thanks. Here is another rare crash, no idea if these are related.
http://crashes.to/s/c1f5788aebc
Crashed: NSPersistentStoreCoordinator 0x13eac7e20
EXC_BAD_ACCESS KERN_INVALID_ADDRESS 0x0000000013ed0b58

libobjc.A.dylib objc_msgSend + 16
CoreData	-[NSManagedObjectContext save:] + 1164
ATStorage.m line 352 -[ATStorage delete:]
ATSender.m line 249 __38-[ATSender sendWithCompletionHandler:]_block_invoke

Here is another one:
http://crashes.to/s/7aec83fa5d2
Crashed: TrackerQueue :: NSOperation 0x154930750 (QOS: USER_INTERACTIVE)
0  CoreFoundation                 0x182c2fc90 __CFBasicHashDrain + 192
1  CoreData                       0x184a874e0 -[NSManagedObjectContext(_NSInternalChangeProcessing) _processRecentChanges:] + 2104
2  CoreData                       0x184a8612c -[NSManagedObjectContext save:] + 168
3 clientapp                   0x1002b7d04 -[ATStorage saveContext] (ATStorage.m:121)
4  clientapp                   0x1002b7f00 -[ATStorage insertHit:mhOlt:] (ATStorage.m:150)
5  clientapp                   0x1002b5320 -[ATSender sendWithCompletionHandler:] (ATSender.m:155)
6  clientapp                   0x10028eca8 -[ATBuilder main] (ATBuilder.m:393)
7  Foundation                     0x1834f6ed8 -[__NSOperationInternal _start:] +

Hi,
It looks that those crashes append when using the CoreData API
We worked on our CoreData implementation and believe 8ac4d43806ae28f3d980a4324ec0aaaba7e0d128 will solve your crash issue
Regards


How to specify config fields for file readers

I am using row file reader, as
task.reader.class=io.streamthoughts.kafka.connect.filepulse.reader.RowFileInputReader

It has configs like skip.headers, etc.
How do i specify these configs in properties file ?

Hi @akhileshacc, you can simply add skip.headers as it is in your properties file or json config.

Thanks 👍


ng add command throwing error when adding to a bare-bones project

TLDR this happens when you run the command:
Failed to find generated component file /auto-generated.component.css. Please contact the @nativescript/schematics author.
Environment
package.json
  "name": "sample-project-for-code-sharing",
  "version": "0.0.0",
  "scripts": {
    "ng": "ng",
    "start": "ng serve",
    "build": "ng build",
    "test": "ng test",
    "lint": "ng lint",
    "e2e": "ng e2e"
  },
  "private": true,
  "dependencies": {
    "@angular/animations": "~8.2.0",
    "@angular/common": "~8.2.0",
    "@angular/compiler": "~8.2.0",
    "@angular/core": "~8.2.0",
    "@angular/forms": "~8.2.0",
    "@angular/platform-browser": "~8.2.0",
    "@angular/platform-browser-dynamic": "~8.2.0",
    "@angular/router": "~8.2.0",
    "rxjs": "~6.5.2",
    "tslib": "^1.10.0",
    "zone.js": "~0.9.1"
  },
  "devDependencies": {
    "@angular-devkit/build-angular": "~0.802.1",
    "@angular/cli": "~8.2.1",
    "@angular/compiler-cli": "~8.2.0",
    "@angular/language-service": "~8.2.0",
    "@types/node": "~8.9.4",
    "@types/jasmine": "~3.3.8",
    "@types/jasminewd2": "~2.0.3",
    "codelyzer": "^5.0.0",
    "jasmine-core": "~3.4.0",
    "jasmine-spec-reporter": "~4.2.1",
    "karma": "~4.1.0",
    "karma-chrome-launcher": "~2.2.0",
    "karma-coverage-istanbul-reporter": "~2.0.1",
    "karma-jasmine": "~2.0.1",
    "karma-jasmine-html-reporter": "^1.4.0",
    "protractor": "~5.4.0",
    "ts-node": "~7.0.0",
    "tslint": "~5.15.0",
    "typescript": "~3.5.3"
  }
}

Describe the bug
 ng add @nativescript/schematics
Skipping installation: Package already installed
    Reading Project Settings
    Project settings:
    {
      "root": "",
      "sourceRoot": "src",
      "mainName": "main",
      "mainPath": "src/main.ts",
      "prefix": "one-space",
      "tsConfig": "tsconfig.app.json",
      "entryModuleClassName": "AppModule",
      "entryModuleImportPath": "./app/app.module",
      "entryModuleName": "App",
      "entryModulePath": "src/app/app.module.ts",
      "entryComponentClassName": "AppComponent",
      "entryComponentImportPath": "./app.component",
      "entryComponentName": "App",
      "entryComponentPath": "src/app/app.component.ts",
      "indexAppRootTag": "one-space-root"
    }
    Adding @nativescript/schematics to angular.json
    Adding {N} files
    Adding App_Resources
    Adding NativeScript specific exclusions to .gitignore
    Adding NativeScript run scripts to package.json
    Adding NativeScript Project ID to package.json
    Modifying web tsconfig
    Modifying tslint.json
    Adding Sample Shared Component
Failed to find generated component file /auto-generated.component.css. Please contact the @nativescript/schematics author.

To Reproduce
fork the project listed below then run:

npm i && ng add @nativescript/schematics

Expected behavior
Schematic would add what is needed and not throw an error.
Sample project
This is a base project spun up with ng new and it still does not work -- this is prior to running the ng add command. Feel free to fork it.
https://github.com/quincarter/code-sharing-sample
Additional context
Trying to spin up an initial code sharing project and getting that error above with the ng add @nativescript/schematics command.

The problem in existing projects is scss styles.
In your exisitng project change your styles from scss to css.
First in angular.json and then in your components.
Eventually add schematics normally with: ng add @nativescript/schematics
Though if you decide to use scss, you can create new project using;
ng new --collection=@nativescript/schematics your-app --shared --style=scss

@a-syde that's how I always create my projects, with --style=scss, but I still get the same error. Just tried again, creating a new project, on the latest versions of Schematics, Angular CLI and NativeScript.
@angular/cli: 8.3.0
nativescript: 6.0.3
@nativescript/schematics: 0.7.1

Yes this works when I change my default styles file to css instead of scss. I think this needs to be fixed.

I actually did just spin up a project with css and it worked. But i feel like this does not solve the issue if i want to use scss instead of css

I am trying to migrate an existing project (Issue #246) which is quite big so it's not practical to convert all the scss to css in order to add nativescript support. Any other way to get around this issue?

I see there is a fix in Ready for Test.  Thanks @Fatme
Curious when we can start using this for our existing scss projects.  I'm excited.  I've spent the last week generating, modifying and trashing ng + nativescript apps and I'm super stoked to start in on an existing project that I have in an Angular workspace built with scss stylesheets.

@vegaskev,
You can try it using the next version of @nativescript/schematics - ng add @nativescript/schematics@next.

@Fatme
I tried with you suggested above but ran into another issue (failing with error Invalid rule result: Instance of class Promise), please see below:
+<EMAIL_ADDRESS>updated 1 package in 20.235s Installed packages for tooling via npm.     Reading Project Settings     Project settings:     {       "root": "",       "sourceRoot": ".",       "mainName": "main",       "mainPath": "src/main.ts",       "prefix": "app",       "tsConfig": "src/tsconfig.app.json",       "entryModuleClassName": "AppModule",       "entryModuleImportPath": "./app/app.module",       "entryModuleName": "App",       "entryModulePath": "src/app/app.module.ts",       "entryComponentClassName": "AppComponent",       "entryComponentImportPath": "./app.component",       "entryComponentName": "App",       "entryComponentPath": "src/app/app.component.ts",       "indexAppRootTag": "app-root"     }     Adding @nativescript/schematics to angular.json     Adding {N} files     Adding App_Resources     Adding NativeScript specific exclusions to .gitignore     Adding NativeScript run scripts to package.json     Adding NativeScript Project ID to package.json     Modifying web tsconfig     Modifying tslint.json     Adding Sample Shared Component Invalid rule result: Instance of class Promise.
Any idea what could be the reason?

Hey @ShahnavazKazi,
We're not able to reproduce your issue.

@ShahnavazKazi
I am faced with the same problem,
Have you fix it?

I'm getting this as well, has anyone been able to fix it? or Have a pointer on where to start.?

@ShahnavazKazi @dudipsh @blankstar85 Did any of you guys ever figure this out?

@Ant-Pinto - No, we didn't pursue what we were looking with nativescript as we chose react-native and one of the main reasons was that Microsoft App Center supports react-native based apps.

I haven't had the time to pursue this anymore yet.

Any update on this issue? I am still facing in Angular 13 and Nativescript 8 combo


[Bug]: Test runner stalls if worker runs out of memory

Version
28.1.3
Steps to reproduce

Clone repo https://github.com/phawxby/jest-stall
npm install
npm run test

Expected behavior
Out of memory error triggers test failure
Actual behavior
Runner stalls waiting for worker test results to return indefinitely
Additional context
This appears to be cause of the stalling identified here.
https://github.com/facebook/jest/issues/11956#issuecomment-1166053551
This doesn't happen if only testing a single file, IE npm run test bad
Environment
System:
    OS: macOS 12.4
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
  Binaries:
    Node: 18.4.0 - ~/.nvm/versions/node/v18.4.0/bin/node
    Yarn: 1.22.10 - /usr/local/bin/yarn
    npm: 8.12.1 - ~/.nvm/versions/node/v18.4.0/bin/npm
  npmPackages:
    jest: ^28.1.3 => 28.1.3

#13054

https://github.com/facebook/jest/releases/tag/v29.0.0


Type checker can be made to consume all available memory

I discovered this by accident due to a typo in some more involved code, but  I believe I've boiled it down to a minimal repro case:
import Array exposing (Array)

fribble x y =
  Array.get y x
    |> Maybe.map (Array.set y x)
    |> Maybe.withDefault x

When I try to compile this code, elm-make hangs, and hitting ^C does not shutdown all elm-make processes, meaning memory usage grows rapidly until I or the OOM killer address the situation.

Looks like another instance of "infinite type construction not caught by the compiler", see https://github.com/elm-lang/elm-compiler/issues/1231 and other issues referenced there and referencing that one.

This still crashes the compiler in version 0.18.


Create branch for code used to generate v2.1.1 freeze 1 results

Waiting on https://github.com/broadinstitute/regional_missense_constraint/pull/223

Done using this command:
git checkout -b v2_freeze_1 e50b59180d0a778eb140fd9caae13d1fe5e9607a

Lily and I decided to create this branch using a previous commit on main, so I picked the last commit from June (when freeze 1 was generated)


Add more assignment tests in docker

The aim of this MR is to add more random assignment tests (4) in docker, as per discussed in #236

Also maybe good to note the docker workflow is a bit flaky, not sure why
Between these 2 runs there is no change

The GH API sometimes rejects requests with invalid user agents, my guess is the ADD fell back to the default HTTP headers which GitHub was unhappy with. @martinmladenov this way of cache invalidation is very strange, perhaps we should create an issue to improve it. Specifically, ADD supports Git repositories natively, mayhaps we can replace the cache-buster and clone with a singular repository ADD.

@Arraying Interesting, I didn't know that, thanks. I saw a stackoverflow post which stated that downloading commit info to break the cache is the best solution. Let's make a new issue.


fix catch2 error when using system catch2 on Fedora; add Fedora workflow

Actions are failing for some reason outside of this PR,
@christianparpart can you please merge it


MaxExpansionDepth

How to set MaxExpansionDepth for all dbcontext in ODatalizer?

Hi @VictorQualitas
We have released new version <IP_ADDRESS>.
You can set MaxExpansionDepth settings to ODatalizerEndpoint. in Startup
var ep = new ODatalizerEndpoint(
                            db: sample,
                            routeName: "Sample",
                            routePrefix: "sample") {
                                MaxExpansionDepth  = 5
                            };

if you use dynamic controller feature, you need override Get method and set EnableQuery settings :)
https://github.com/commerble/ODatalizer/blob/5e140c0c1a60deeefb14728be2a261fe3437d051/src/Sample.EFCore/Controllers/SampleController.cs#L23-L31


Question: Format and Paragraph submenu display format set by custom class itself

I am trying to create a div paragraph centered vertically and horisontally by setting a custom class to a < div> element via Format and/or Paragraph submenu. This works fine. But since the submenus list items seem to take the form/class of the customized element itself, I get a empty large area where I instead would like simple text/button name. See:

("Absatz" is the prior item, current item text/button text is not even shown). I tried both Paragraph and Format submenus. Any chance to get this behaviour changed - or have I made a mistake?

How did you set the options?

formats: ['p',
{
tag: 'div', // Tag name
name: 'Center div', // default: tag name
command: 'replace', // default: "replace"
class: '__se__format__replace_mb-center-text'
// Class names must always begin with "se__format(replace, range, free)_"
}

I tested it like this.
formats: [
        'p',
        {
            tag: 'div', // Tag name
            name: 'Center div', // default: tag name
            command: 'replace', // default: "replace"
            class: '__se__format__replace_mb-center-text' // Class names must always begin with "se__format(replace, range, free)_"
        }
    ],

Show me the css code of the "__se__format__replace_mb-center-text" class.

.mb-center-text {
display: flex;
justify-content: center;
align-items: center;
height: 50vh;
}

Due to the height(50vh) property of the 'div', the bottom buttons are pushed out and cannot be seen.
You can express by giving css separately in the ".sun-editor" and ".sun-editoor-editable" fields.
.sun-editor-editable .__se__format__replace_mb-center-text {
    justify-content: center;
    align-items: center;
    border: 3px solid green;
}

.sun-editor .__se__format__replace_mb-center-text {
    display: flex!important;
    justify-content: center;
    align-items: center;
    /** height: 50vh; **/
    border: 3px solid green;
}

Works great. Solves quite some of my problems - Thank you!


MudTable.Loading doesn't work in mobile view

Bug type
Component
Component name
MudTable
What happened?
When in mobile layout (Breakpoint.Xs), the Loading parameter of MudTable does nothing. This can be seen in the first example from the docs.
Desktop view:

Mobile view:

Expected behavior
A loading indicator is shown on both desktop and mobile layouts.
Unresolved question: Is the same type of loading indicator the best option on mobile? I suspect it will suffer from this problem more than the desktop version already does.
Reproduction link
https://try.mudblazor.com/snippet/mkGSEPFpwztAMmPp
Reproduction steps

Go to the first demo on https://mudblazor.com/components/table#default-table (or https://try.mudblazor.com/snippet/mkGSEPFpwztAMmPp).
Enable the "Show Loading" switch.
Resize your browser window so that the table switches to mobile layout.

Relevant log output
No response
Version (bug)
6.12.0
Version (working)
No response
What browsers are you seeing the problem on?
Firefox, Chrome
On what operating system are you experiencing the issue?
Windows
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I cannot give you a solution, but here is the cause: the Loading is not visible on mobile because when the table loads the data for the first time, it displays the Loading content in the table's header and that is hidden by default (by a CSS rule) for an XS table.

Experiencing the same issue. A workaround is to wrap the table in a div and use scoped css.
@media only screen and (max-width: 600px) {
    .table-wrapper ::deep.mud-table-head {
        display: contents;
    }

    .table-wrapper ::deep.mud-table-head .mud-table-row:first-child {
        display: none;
    }
}

Anyone able to work on a PR for this?

Same issue here.
Another workaround is use IBrowserViewportService to display a MudProgressLinear on mobile.


Device Authentication Asked Again After Configuration Change

Version: 0.2.2
Steps to Reproduce:

In Settings, check "Require device credentials"

Swipe the app off the overview screen, so you start from a clean slate

Restart the app from the home screen, and authenticate against the device

Rotate the screen

Expected Results: Nothing out of the ordinary
Actual Results: You have to authenticate again

Right now, you execute these lines for every onCreate() of MainActivity. Hence, on a configuration change, we have to re-authenticate, which IMHO is aggravating.
Some options for addressing this:

Only execute that code if savedInstanceState is null. This requires re-authentication after the task expires (~30 minutes or until manually removed from the overview screen).

Use onRetainNonConfigurationInstance, the Architecture Components' ViewModel stuff, or a retained fragment to retain your view model (entries data, a have-we-authenticated boolean, etc.) across configuration changes, retrieving it in onCreate() via getLastNonConfigurationInstance(), and only re-authenticate if we need to load the data again

Block configuration changes in the manifest via android:configChanges on the <activity> element. Personally, I don't recommend this option.

Say that this behavior is working as intended. :-)

This is definitely not intended.
I will look into it, thanks for your suggestions.

I used the savedInstanceState == null methode, which seems to work well for me.


add new reaction achievements

新規実績案7つを追加しました

Codecov Report

Merging #99 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
- Coverage   44.57%   44.55%   -0.03%
==========================================
  Files          36       36
  Lines        3883     3883
  Branches      755      755
==========================================
- Hits         1731     1730       -1
- Misses       1715     1716       +1
  Partials      437      437

Impacted Files
Coverage Δ

prime/index.js
17.37% <0%> (-0.61%)
:arrow_down:

mahjong/index.js
27.15% <0%> (+0.31%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9447d9...4b9965c. Read the comment docs.


export icon helper function so it can be used to create custom icons in overrides

Very simple change to export the icon helper function in the retail-react-app's icons component so that it can be used in overrides to generate Chakra Icons for custom .svgs (i.e. - ones that aren't already in the base list of icon .svg filenames).
Example usage:
import {icon} from '@salesforce/retail-react-app/app/components/icons'
import '../../assets/svg/flexible-clock.svg'
export const FlexibleClockIcon = icon('flexible-clock')
export * from '@salesforce/retail-react-app/app/components/icons'

Hi,
Just wondering if I need to do something to allow the Salesforce CLA check to succeed as that seems to be the only failing check on this PR?  I signed the CLA on 8/24/23 (but after this PR was created):

Also, I see this when I click on the "Details" link of the failing check:

Appreciate any guidance on this!
Thanks,
Chris


Codecov compat?

I checked the docs, tracker, and https://docs.codecov.com/docs/supported-report-formats docs, and still couldn’t tell if any of the supported output formats (is it currently just json?) are compatible with codecov.io, so thought I’d try asking here. Thanks!

That link doesn't work for me, but I searched for the supported formats, and it doesn't look like they support ours.
Yes, currently Slipcover only outputs text (intended for human use) and JSON (everything else).
Our JSON format is intended to be just about identical to coverage.py's...
It's not clear to me that that is supported, either, though.
I wonder if one of the formats they support is relatively close to ours...

Hi. I tried few days ago to upload json coverage to codecov. I got the following the error: "the report is not usuable". After a deeper look into the codecov code, I found the error. Codecov is infering the coverage type from few elements in the file. For json coverage file, the code is the following : https://github.com/codecov/worker/blob/861583604119da9c607b588055e4f175a784a103/services/report/languages/pycoverage.py#L22
This show_contexts flag was the missing element, by adding it in the coverage file, codecov is able to recognize my report and display the coverage correctly. The measure context feature coverage py is a not supported slipcover feature. I'm not using this feature (I didn't know about it actually).
My proposal, for now, would be to hardcode this flag to False to be able to upload report to codecov.

I raised this pr to fix the issue, can you please review? https://github.com/plasma-umass/slipcover/pull/49

Since #49 was merged and released, is this issue fixed and can it be closed? If so, worth mentioning in the release notes? (codecov.com compatibility is not currently mentioned anywhere on https://github.com/plasma-umass/slipcover/releases which it looks like is where notable changes are listed.)

Since #49 was merged and released, is this issue fixed and can it be closed? If so, worth mentioning in the release notes? (codecov.com compatibility is not currently mentioned anywhere on https://github.com/plasma-umass/slipcover/releases which it looks like is where notable changes are listed.)

Yes, indeed! Done.


Upgrade all dependencies

https://github.com/Aclify/aclify/issues/12

Codecov Report

Merging #13 into master will increase coverage by 0.84%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
+ Coverage   84.09%   84.93%   +0.84%
==========================================
  Files           8        8
  Lines         503      498       -5
  Branches      124      123       -1
==========================================
  Hits          423      423
+ Misses         60       56       -4
+ Partials       20       19       -1

Impacted Files
Coverage Δ

src/index.js
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eff7942...fcd7abb. Read the comment docs.


STM32G030 (and maybe other) DMA registers are incorrect

The current STM32G030 Channel registers are generated into something that looks like this:
// dma/ch.rs

#[doc = r"Register block"]
#[repr(C)]
pub struct CH {
    #[doc = "0x00 - DMA channel x configuration register"]
    pub cr: CR,
    #[doc = "0x04 - DMA channel x number of data register"]
    pub ndtr: NDTR,
    #[doc = "0x08 - DMA channel x peripheral address register"]
    pub par: PAR,
    #[doc = "0x0c - DMA channel x memory address register"]
    pub mar: MAR,
}

However there are actually 5 words there, there should be a reserved word at the end of each channel field:

The DMA register hints at this, but the comments don't match the generated code:
#[doc = r"Register block"]
#[repr(C)]
pub struct RegisterBlock {
    #[doc = "0x00 - low interrupt status register"]
    pub isr: ISR,
    #[doc = "0x04 - DMA interrupt flag clear register"]
    pub ifcr: IFCR,
    #[doc = "0x08..0x6c - Channel cluster: CCR?, CNDTR?, CPAR?, and CMAR? registers"]
    pub ch: [CH; 5],
}
impl RegisterBlock {
    #[doc = "0x08..0x1c - Channel cluster: CCR?, CNDTR?, CPAR?, and CMAR? registers"]
    #[inline(always)]
    pub fn ch1(&self) -> &CH {
        &self.ch[0]
    }
    #[doc = "0x1c..0x30 - Channel cluster: CCR?, CNDTR?, CPAR?, and CMAR? registers"]
    #[inline(always)]
    pub fn ch2(&self) -> &CH {
        &self.ch[1]
    }
    #[doc = "0x30..0x44 - Channel cluster: CCR?, CNDTR?, CPAR?, and CMAR? registers"]
    #[inline(always)]
    pub fn ch3(&self) -> &CH {
        &self.ch[2]
    }
    #[doc = "0x44..0x58 - Channel cluster: CCR?, CNDTR?, CPAR?, and CMAR? registers"]
    #[inline(always)]
    pub fn ch4(&self) -> &CH {
        &self.ch[3]
    }
    #[doc = "0x58..0x6c - Channel cluster: CCR?, CNDTR?, CPAR?, and CMAR? registers"]
    #[inline(always)]
    pub fn ch5(&self) -> &CH {
        &self.ch[4]
    }
}

(Each channel is shown to be 20 bytes in the hex, but the first snippet is only 16 bytes per channel).
I'm guessing this affects more than the STM32G030 specifically, but I can verify patching in the following definition manually makes DMA channels other than CH1 work for me:
#[doc = r"Register block"]
#[repr(C)]
pub struct CH {
    #[doc = "0x00 - DMA channel x configuration register"]
    pub cr: CR,
    #[doc = "0x04 - DMA channel x number of data register"]
    pub ndtr: NDTR,
    #[doc = "0x08 - DMA channel x peripheral address register"]
    pub par: PAR,
    #[doc = "0x0c - DMA channel x memory address register"]
    pub mar: MAR,
    pub _RESERVED: u32,
}

I have no idea how the stm32 PAC machinery works, so hopefully this report is useful for y'all :D

It is not an issue of generation.
There are incorrect addresses of registers in source SVD.
Need to _modify those addresses before collect to cluster.

You are right. Need to check svd2rust. Especially max_cluster_size

This should fix an issue
https://github.com/rust-embedded/svd2rust/pull/661


How should we handle page transitions?

Option 1: Navigate via the homepage every time
Option 2: Allow navigation by selecting a page from the header
Option 3: Create something like a menu bar, from which pages can be selected and navigated to.

The menu bar looks good.


Incorrect Oracle Linux versions in README.md files

The README.md files for 3 of the boxes refer to an incorrect or outdated Oracle Linux version:

OracleLinux/6/README.md states that the box is based on Oracle Linux 7, instead of Oracle Linux 6.
OracleDatabase/<IP_ADDRESS>/README.md and OracleDatabase/<IP_ADDRESS>/README.md state that the boxes are based on Oracle Linux 7.3. This is outdated. To be consistent with the other boxes, these READMEs should refer to Oracle Linux 7.

If you agree that these files should be updated as suggested, I'd be happy to submit a PR.

Please go ahead and submit a PR. thanks!


G9 supplier declaration

Adding additional G-Cloud 9 questions
Adding hint text about of environment, social and labour law
Hiding trade association questions if the supplier is established in the UK.

@cathrooney I noticed the new servicesHaveOrSupport.yml was all G-Cloud 8, with four lots and everything.  I've had a quick stab at bringing it up to date for G9, but take a look before we merge this as it probably needs more tweaks (and I wasn't sure if the lots are numbered at all this time round?)


Use IDE original launcher for the runIDE task

When debugging an IDE, it is necessary to make sure the IDE behaves exactly the same way as it does on user machines.
Right now, the runIde task uses that JavaExec and starts an IDE differently:

it uses an IDE .zip package which is different from os-specific packages
it does not use the bundled JBR when running it
it does not repeat the same logic of starting IDEs as done in the platform-native launchers (it always changes on the IDE side, the SDK tries to catch up)
started IDE does not have the right icon (a side-effect of the unsupported package being used)

It is possible to start an IDE from an official package too.

the same sandbox and properties can be used
all properties are easy to set via the vmoptions file
debugging is also possible by adding debug options to the vmoptions file (and clicking an attach debugger link in the IDE)
the compatible version of JBR is automatically there (there is no need to fetch yet another one via Gradle)

This change is huge, I understand that, but on the other hand, it can help to

simplify infrastructure (we use official releases only)
avoid too much complexity and support in the plugin SDK (no need to configure JavaExec, no need to fetch JBR, etc)
introduce fewer changes to the plugin run/debug environment
out of the box support for any third-party IntelliJ-based IDEs (e.g. by using product-info.json or via guessing based on known layout)

I have a proof of the concept if necessary

The 2.0 fully relies on the information provided with product-info.json file and uses bundled JBR, if available.


Cant input credentials

Last time i used mame-ao it worked fine and now it wont accept my credentials, it will always error out. Bad credentials try again. Hit enter to skip (You won't be able to download). i hate it, please help, i tried inputing it but to no avail. pls help

Hello @gdandsm64fan123
I just deleted my auth cookie file.
_TEMP\CACHE\archive.org-auth-cookie.txt

Started MAME-AO and entered my credentials. Seemed fine.
Can you double check your creds? Put them into a text file copy and paste to log into archive.org so you know they are good.
Cheers
Sam

im using a different computer than the one where i logged in on.


Add tags to Garden cards on search page

Entrypoints have tags associated with them. Gardens will have a compilation of these tags.

Add the tags to the Garden cards on the search page.
Style them to make them easy to read and sort through. (Like on MDF or Foundry but with Garden styling)
Add tag search functionality: when I click on a tag, I see other Gardens with that tag. (Like what we have on the MDF page)

Blocked until tags are added to Gardens on backend (which is planned as part of backend work)

no longer blocked


Cicd lambda

Added lambda to update task definition for ECS functions container.

CDK now outputs an update lambda name to be called by the github action to deploy the functions server.
Update lambda updates service with new task definition
Default image is now a dummy server
Fixed readme by removing section on environmental variables.

Update lambda requires a json payload to be sent with an image property and an environment property.
The image property contains a string for the image to be pulled from dockerhub.
The environment property contains an array of objects, each with a name and value property. These define the environmental variables to add to the task definition beyond the default ones. These overwrite any with the same name.
You can test this by manually running the lambda on your own cdk deployment.

Glad we finally got CI/CD integration working! Good work, Chris 🙂


Word swap from DRBC to BCDR

@doodlemania2 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

After consideration, going to leave as is for now.


0 Kb reports being generated for BizTalk

PAL is consistently generating 0 Kb report files for BizTalk. All the charts have been generated in the charts folder however the html report is 0 kb. I have reverted to an old version of PAL for my BizTalk blg files which does work correctly. Any chance of getting this fixed for the new version?

Can you send me the counter log? I’ll debug it. Upload it to http://bit.ly/PalUpload and let me know when it is uploaded.
Thank you,

From: Norman Gillis<EMAIL_ADDRESS>Sent: Tuesday, February 26, 2019 11:47:42 AM
To: clinthuffman/PAL
Cc: Subscribed
Subject: [clinthuffman/PAL] 0 Kb reports being generated for BizTalk (#39)
PAL is consistently generating 0 Kb report files for BizTalk. All the charts have been generated in the charts folder however the html report is 0 kb. I have reverted to an old version of PAL for my BizTalk blg files which does work correctly. Any chance of getting this fixed for the new version?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fclinthuffman%2FPAL%2Fissues%2F39&data=02|01||b7c8a69685634d2ecffc08d69c2346f4|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636868072653015265&sdata=8i5YGVxJnx53WXr2isuSOwzLYcJDGjf%2FEaL9TkUyp08%3D&reserved=0, or mute the threadhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAS48VOQ88DOv9iPxmuWwYfujwAwSQza9ks5vRY9egaJpZM4bS-Wj&data=02|01||b7c8a69685634d2ecffc08d69c2346f4|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636868072653025276&sdata=SNQzoLx1n7Pm9lPsXievGAwqDDLc7Fi2w5lJTuABfE0%3D&reserved=0.

Hello.
I have faced with similar issue: 0kb PAL report generated for old Win2008 / SQL2005 environment. I'm getting folder with graphs and empty HTML.  Is there any simple workaround?

If I remember correctly this issue arose when I was using PAL on a non-English operating system. It's also possible the perfmon counters are broken, (not uncommon on an old SQL Server) and you may try re-registering them. Check to see if your blg files actually contain some data, (are they just a few kb's in size or much bigger?) and open them in perfmon off the prod server somewhere secure. If there is data there you can do some manual analysis, unfortunately that's time intensive. There are some things that you can do to help yourself such as using Relog to export the counters, (cpu util, avail ram) you are interested in to csv. The csv can then be imported into excel where you can create nice tables.

I checked .blg file, it has correct data inside. Counters state and OS/SQL langs also are fine.
My collegue also gave advise to seek in config file for some misconfigurations. If no luck, then I'll try to parse blg with suggested ways.
Anyway, thank you for your time!


Hermit Demo menu links are not working on the Hugo website

Hello @Track3
I am one of the people who maintain the Hugo Themes repository and I noticed that links on the index page of the theme demo do not work.
As stated in the README of the Hugo Themes repository if a forward slash / is used in the beginning of a URL, it will point to the host root and Hugo will not generate the correct URL for the demo's assets because it is published in a subdirectory of the Hugo Themes website.
You need to remove the first forward slashes from line 68 and line 73 in exampleSite/config.toml for the menu links to work properly.
Please look into this issue and let me know.
Thank you.
cc: @digitalcraftsman

Thank you @onedrawingperday
I noticed that and have pushed a commit 3f6885ac2051d855b44709e7f2f0e6a1bcf73576, so menu url should be correct now.


Fixes #280 by allowing null ResourceEvent

Originally posted by @jguittard at https://github.com/zfcampus/zf-apigility-doctrine/pull/281

Coverage remained the same at 51.143% when pulling a63fafc6ebbd06fda5d35e1b8a0e04d2daa4be4a on jguittard:feature/resource-event into 61ee32e36f547dceff2f4587fceed6ce59dc9b9f on zfcampus:develop.

Originally posted by @coveralls at https://github.com/zfcampus/zf-apigility-doctrine/pull/281#issuecomment-256129453

@webimpress would you mind having a look and give me your feedbacks about that?

Originally posted by @jguittard at https://github.com/zfcampus/zf-apigility-doctrine/pull/281#issuecomment-256139369

@jguittard I have a couple concerns about this PR:

according to PHP docs:

Note that when using default arguments, any defaults should be on the right side of any non-default arguments

I've checked many Zend and Apigility packages and I haven't found any default values on left side.

it causes Strict Standard error on PHP 5.6 and Warning on PHP 7.0+ (it seems to be not a BC Break (?), but to avoid this error/warning folks have to update theirs code - if they overriding these methods or implements interface QueryCreateFilterInterface)
not entirely sure if this is needed - please see my https://github.com/zfcampus/zf-apigility-doctrine/issues/280#issuecomment-256191169
if yes then would be nice to have some tests
... and need to be changed everywhere - for example also in: ZFTestApigilityDb\Query\CreateFilter\ArtistCreateFilter

Originally posted by @michalbundyra at https://github.com/zfcampus/zf-apigility-doctrine/pull/281#issuecomment-256191474

Ping @jguittard

Originally posted by @michalbundyra at https://github.com/zfcampus/zf-apigility-doctrine/pull/281#issuecomment-281952057

As I noted in https://github.com/zfcampus/zf-apigility-doctrine/issues/280#issuecomment-283003993 this is also BC Break. I think we should try to find another solution to avoid BC Break.

Originally posted by @michalbundyra at https://github.com/zfcampus/zf-apigility-doctrine/pull/281#issuecomment-283007466


TS-4879: Checking con.fd == NO_FD while we get return from check_emergency_throttle()

Linux build failed! See https://ci.trafficserver.apache.org/job/Github-Linux/727/ for details.

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/831/ for details.

Linux build failed! See https://ci.trafficserver.apache.org/job/Github-Linux/729/ for details.

FreeBSD build failed! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/833/ for details.

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/834/ for details.

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/730/ for details.

Linux build failed! See https://ci.trafficserver.apache.org/job/Github-Linux/732/ for details.

updated per @jpeach 's comments

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/836/ for details.

@jpeach , There is a similar bug in NetAccept::do_blocking_accept() which belongs to ACCEPT side instead of CONNECT side. Should I combine them together in one commit or 2 commits respectively ?

@oknet I'd prefer 2 commits (better for bisecting).

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/839/ for details.

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/735/ for details.

Linux build failed! See https://ci.trafficserver.apache.org/job/Github-Linux/746/ for details.

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/851/ for details.

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/747/ for details.

@jpeach updated upon your comments. thanks.

@oknet nice!

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/852/ for details.

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/748/ for details.


Add "Keep Defending" to made with VRTK list

http://store.steampowered.com/app/527720/
Thanks!

Will be done in the super breaking PR


🚀 improve file-box module

There are some functions that should be improve to support more features.

[x] to_file
[x] FileBoxType  enum definition problems
[x] ready the name&mimetype from remote type
[x] to_file save the FileBox to the local position.
[x] from_base64 name params is required
[x] from_data_url can transfer data_url data to the FileBox type
[x] add unit test
[ ] from_buffer and from_stream have not encountered in our test.
[ ] to_buffer and to_stream have not encountered in our test.

Thanks for so carefully test.  Please go ahead to push the process of code review. @univerone


IDM: Users API Functionality

[x] Logout
[x] User Info
[x] User List
[x] Create User
[x] Create API Only User
[x] Create User SAML
[x] Delete User
[x] 2FA Status Session
[x] 2FA Enable
[x] 2FA Disable by User
[x] Update to API Only User
[x] Update Console Access Denied Flag
[x] Deactivate API Keys

Completed.


WIP Argsort improvement

The current code works for all np.argsort calls.  However the lowering is failing with array.argsort
with a weird error.
LoweringError: Failed in nopython mode pipeline (step: nopython mode backend)
cannot create weak reference to 'NoneType' object

Addresses https://github.com/numba/numba/issues/4636 and https://github.com/numba/numba/issues/4479

@EPronovost thanks for this PR. Did you manage to fix the issue with weak reference? If not, do you know of a test case that triggers it so I can take a look? Thanks.

@stuartarchibald I fixed the issue, and the current branch has working argsort for literal, None, and limited non-literal axis arguments.  However, the Numba version is much slower than numpy itself.  Would appreciate someone with more background taking a look for performance red flags.

@EPronovost great, thanks for fixing it! Was there anything specific test-wise you used to measure this performance difference?

@stuartarchibald not in unit tests.  This is based on timing it separately. There were a couple tests that timed out before I made the arrays smaller.

Marking as ready for review. Note to reviewer... check the performance!

I did a quick look at the performance. The worst case I came across is for:
@nb.njit
def do_argsort(a):
    return np.argsort(a, axis=0)

a = np.random.random(1000).reshape(10, 100)
do_argsort(a)

jit-code is about 9x slower.
For a = np.random.random(1000).reshape(10, 100), jit-code is 2x slower.
For 1D cases, the performance is pretty much the same and its anywhere from 1.3x to 1.7x slower.


Fix experimental occlusion culling

Fixes #1429
This was broken by a change in UE 5.1: the signature of PostRenderViewFamily_RenderThread method of ISceneViewExtension changed. Had that been all, our code would have failed to compile when we upgraded to UE 5.1, and we would have fixed it. But for some reason, Epic kept the old signature around, they just made it do nothing. It's marked with a deprecating macro:
UE_DEPRECATED(5.1, "Use PostRenderViewFamily_RenderThread with an RDG builder instead. RHI commands can be enqueued directly using GraphBuilder.RHICmdList or queued onto the graph.")
virtual void PostRenderViewFamily_RenderThread(FRHICommandListImmediate& RHICmdList, FSceneViewFamily& InViewFamily) {}

But apparently C++ compilers don't flag a warning when you override a deprecated method, which is really unfortunate. So we had no help from the compiler regarding the breaking change, and being an experimental feature we don't use it often enough to have noticed it ourselves.
Once I updated the signature, occlusion culling started working again, except when the tileset was selected in the Outliner. The problem here was that Unreal skips all occlusion checks for primitives selected in the Editor. Because the occlusion check was skipped, and because UCesiumBoundingVolumeComponent doesn't actually render anything (it's only used for occlusion checks), Unreal was deeming the primitive "not visible". This might be a change from previous UE versions? I'm not sure. In any case, our code then assumed this meant the primitive was frustum culled (which is what "not visible" usually means at this stage), and so the associated tile wasn't refined. End result: low detail or entirely missing tiles when the tileset was selected in the Outliner.
This PR fixes this second problem by using the same check that UE itself uses when deciding to skip the occlusion culling step: it checks if the primitive is selected in the Editor. If it is, it's treated as unoccluded.

Self merging this in order to include it in today's release. The changes are isolated to a code path that is only activated when an experimental flag is enabled, and that path is completely broken without these changes, so the risk here is minimal.


JavaScript syntax highlighting stop working in html files when enabling this plugin

Hello, 👋 just found out about this plugin last night, and am impressed how it works out of the box with JSX with little to no configuration files.  That said, something I noticed was that after I enable this plugin Javascript syntax highlighting inside of an .html file no longer works.  I put together a simple .gif explaining what is going on with my current Neovim setup.

In the above GIF notice how Javascript syntax highlighting works before enabling this plugin, but after enabling, Javascript highlighting in .html files does not work, but then works again after disabling / removing the plugin.
Please let me know if I need to link / add any more configuration files for aiding in troubleshooting this issue.  Also all of my current Vim / Neovim configuration files can be found here

@ipatch Thanks for your feedback, I will take a look.

@ipatch I used your dotfiles, but it cannot be reproduced. Can you provide the test HTML file you used?

@ipatch I found the root cause and fixed it in #49. You can update the plugin and verify it now.
BTW, if you use the vim-polyglot plugin, you should disable the jsx plugin in it. By setting let g:polyglot_disabled = ['jsx'] in your vimrc. The jsx plugin inside vim-polyglot is from mxw/jsx. and it will override this plugin.

Just merged. Thanks report and patches.


ESM entry points in package.json resolve to an empty file

Was just testing this out and was debugging why nothing was showing up on the screen, but without any errors and it looks like the ESM / module entry point in package.json ultimately leads to an empty file?

package.json defines a module field (and other fields) that point to a dist/index.js
dist/index.js references file /dist/esm/index.js
/dist/esm/index.js is an empty file 😢

Looking forward to giving this a try!  ✌

Somewhat related, but the formal standard to wrangling all these fields is the new export map spec.  Might be a nice way to clean all those up, since only main is a standard as far as NodeJS is concerned.

Thanks for the well documented issue 🙏.
PR #50 will solve this. I updated it following the Stencil docs.
I asked a question regarding es2015 and es2017 entries on the Slack channel.
Will merge and release as soon as cleared. Since we are cleaning these entry points, let's do everything correctly 😉.

Thanks for the quick reply and PR @peterpeterparker !

Alright, we should be good. I released the new version v7.3.0.
Can you check @thescientist13 and let me know if it is alright now?

Thanks, was able to make some progress!  But did encounter another issue.
So now that the module now resolves to a file, dist/custom-elements/index.js, this file references bare modules from the @stencil/core package, that will need to be available and resolvable on the user's system.  (unless this was not the intended output?)
import { HTMLElement, createEvent, h, proxyCustomElement } from '@stencil/core/internal/client';
export { setAssetPath, setPlatformOptions } from '@stencil/core/internal/client';

My "quick fix" recommendation for this is to make it explicit by moving @stencil/core out of devDependencies in your package.json and into dependencies so tools can correctly infer the runtime dependency graph of web-social-share, like for building up an import map.
OR
You could make it implicit as a peerDependency and have user's pre-install prior to consuming and document that in the README.
(My vote would be option 1)
Let me know if you have any questions / need more info.  I can open a new issue for this if you prefer.  👍

Thanks for double checking and for the feedback, that's not good, there should be no reference on Stencil.
I following exactly what's in the doc and starter kit, I will investigate further!
In what type of apps and how are you importing the component? Can you provide a sample or tell me a bit more so that I can reproduce the issue and share it too?
Thanks a lot for your help!

Sure, you can see a PR of my attempts here in my studio website repo, that I'm migrating to use WCs (with Lit).
import { css, html, LitElement, unsafeCSS, TemplateResult } from 'lit';
import { customElement } from 'lit/decorators.js';
import 'web-social-share';

@customElement('app-social-share')
export class SocialShareComponent extends LitElement {

  protected render(): TemplateResult {
    const share = {
      displayNames: true,
      config: [{
        facebook: {
          socialShareUrl: 'https://peterpeterparker.io'
        }
      }, {
        twitter: {
          socialShareUrl: 'https://peterpeterparker.io'
        }
      }]
    };

    return html`

Interact + Share

          <web-social-share show="true" share=${share}></web-social-share>

    `;
  }
}

Using my own project Greenwood to support modern ESM / build + bundle-less workflows for things like:

resolving node_modules
handling bare module specifiers
generating an import map
dev server
ESM in NodeJS

Similar tools in the space are Snowpack, Vite, and the Modern Web Suite.  The Lit docs give a good breakdown of some of the requirements / expectations for this kind of tooling, so that's what I am trying to support on my end as well.  😃

Thanks a lot for the details, will have a look / try tomorrow or next days.

I fixed the issue and published a new version as a breaking changes since I modified the custom element entry.
Let me know if it works out but, according my test, it should be alright. I was able to import and use the component in a lit starter kit.
Note: it contains some TODO, just limited my self to the bare minimum test ;)
import {LitElement, html, css} from 'lit';
import {customElement, property, query} from 'lit/decorators.js';

import 'web-social-share/dist/components/web-social-share';

@customElement('my-element')
export class MyElement extends LitElement {
  static override styles = css`
    :host {
      display: block;
    }
  `;

  @property({type: Boolean})
  open = false;

  @property({type: Object})
  share = {
    displayNames: true,
    config: [{
      facebook: {
        socialShareUrl: 'https://peterpeterparker.io'
      }
    }, {
      twitter: {
        socialShareUrl: 'https://peterpeterparker.io'
      }
    }]
  };

  @query('web-social-share')
  cmp!: HTMLWebSocialShareElement;

  override render() {
    return html`
      <button @click=${this._onClick}>
        Click
      </button>
      <web-social-share show=${this.open}>
        Facebook
        Twitter
      </web-social-share>
      <slot></slot>
    `;
  }

  private _onClick() {
    // TODO: init share object only once in a better way
    this.cmp.share = this.share;

    // TODO: add event listener on cmp event closed to reset open value
    this.open = !this.open;
  }

}

declare global {
  interface HTMLElementTagNameMap {
    'my-element': MyElement;
  }
}

Thanks, I really appreciate it!
It does looks like all the "ESM" fields in package.json got reverted back to pointing to an empty entry point file again though? (dist -> dist/esm).  😢
I think part of what is contributing to the confusion is that the usage is not super clear / obvious.  Without hints from a package.json, it's not clear how tools / users would know to use this new path from your snippet instead
import 'web-social-share/dist/components/web-social-share';

Which seems to differ from what I see in the stencil docs as recommended by this README, which implies a function call is required?

But i don't see that in your latest example?
Also, it looks like that file still references @stencil/core libs, did that starter kit include Stencil by chance?  Or did you install it?

TL;DR I think we are close, I think what is just needed is:

Updated package.json ESM fields to point to dist/components/web-social-share, ex: {
   "module": "./dist/components/web-social-share.js"
 }

Move @stencil/core to the dependency field in package.json (or make it a peerDependency and specify the range / version in the README as part of the npm install step)
Update README with import instructions

Then, when these fields point to the new entry point from your example, NodeJS and tools using those fields as hints should automatically find your entry point.  Then either of these variants should work 🙌
import 'web-social-share';

import { xxx } from 'web-social-share';

Thanks again, and sorry for all the trouble.  🥺

The entry points in the package.jsonare now defined as per Stencil documentation and reverted as requested by Stencil's build.
There are different way to consume the component, indeed you can use the loader
import { defineCustomElements } from '@web-social-share/dist/loader';
defineCustomElements();

Or import it:
import 'web-social-share`

or with the custom element
import 'web-social-share/dist/components/web-social-share';

Depends of the app and goals. In any case, it never needs Stencil as a dependency.
Therefore, I think we are close and nothing more need to be done.
As I said in my previous comment, using the last method I was able in a sample project to import and use successfully the lib in a lit element component (see my previous code).
Being said, if you can provide a sample repo that narrow the exact issue, happy to give it a try.
Likewise, PR for the README.md is welcomed.

Ah, so yeah, looks like these are known issues / open items with Stencil

https://github.com/ionic-team/stencil/issues/2826
https://github.com/ionic-team/stencil/issues/2512

If i have some time I will try and play around see if if there is a work around to make it work in its current state for ESM based workflows in NodeJS and submit some instructions for that, since as you say, each time you run your build, it will just keeping resolving back to that initial, empty, state.  😞

Cool! Keep me posted and thx for the help

Got it working (with a couple tweaks).  Left a comment in the Stencil issue, hopefully they will be able to resolve it.

Ah cool 👍
If your tweaks need applies to this component, send me a PR if you do not mind, that would be super.

Woops, realized I dropped the wrong link in my previous comment.  Here was my feedback to the Stencil team in that issue - https://github.com/ionic-team/stencil/issues/2826

As an interim solution / work around for anyone curious, I forked the library and changed its module field to point to ./dist/websocialshare/websocialshare.esm.js.  As I use import maps for local development, everything was fine, but for production bundling where I use Rollup, because that file imports another file that use variables in dynamic imports, I had to add the dynamic-import-vars plugin, then things worked.  🙌

So, yes, I am totally happy to open a PR, but I guess it is really is up to you because as we see here, everything gets "reset" when you release and run the Stencil CLI so not sure if that's something you would want to "maintain" as it were each time?  Plus would want to document the bit about dynamic import vars I suppose.
Let me know though if that all sounds good to you though, happy to upstream what I have here at least if it helps!

Thanks for all the details. Yes agree with you, maybe we should check a bit first to see if something is moving on the Stencil side before merging a new PR. Not against at all, as you said, if it needs to be maintained and needs some documentation, it is maybe worth to "wait a bit" to check if no proper solution comes from the compiler. Ultimately, if not, sure go on with the PR. Does that make sense? Agree with this plan?

Yeah, I am happy on staying in a holding pattern for now, no rush from my end.  I probably will swing back a little later on anyway to ask some questions on usage / styling now that I have things working, so will try and preserve your time and support for that!  🙏

Awesome, sounds like a good plan! Thank you

I was looking around the best alternative for Lit elements and wanted to try the lazy loading concept of Stencil. But I also see my index.js is pointing to an empty files only :(. Can we take this on priority please, I was doing POC for explaining stencil is best :p and now I can't explain lol.

Alright, so first let's reopen this 😉.
@thescientist13 can you provide your modifications as PR, it seems it can be interesting to some.
afterwards and in addition, should we add something in the README?

oh, what is that different entry point among these inside esm folder?

@peterpeterparker

can you provide your modifications as PR, it seems it can be interesting to some.
afterwards and in addition, should we add something in the README?

agree on both counts and will do.  Should be able to get that up a little later on tonight for review.

finally, it the solution is to point the entry in package.json to a different entry point, I think we can submit PRs to the Stencil sample repo and doc, might be useful if it is the effective solutions for everyone.

So I see two possible, equally viable options from the Stencil side

Fix it so the right build content actually makes it into the file currently assigned to ESM entry points (dist/esm/index.js)
It should point instead to ./dist/websocialshare/websocialshare.esm.js

I'm not really sure what the right fix is unfortunately, or rather what the intention was from the Stencil team.  I'm hoping to use the issue opened in their repo as the main driver of resolution though.  🤞
I myself actually arrived at the file i did by reverse engineering your live demo and seeing that you were using that file, so I tried it locally and it worked.  So mostly just trial and error, just to be forthcoming in that regard.  😅

@pranav-js
I believe the simplest solution given the current available artifact in npm, and what I would propose PR is:

Pointing ESM entry points in package.json to a new dist/ files for this package
ESM consumers would need to make sure their build process supported variables in dynamic imports

agree on both counts and will do. Should be able to get that up a little later on tonight for review.

@thescientist13 thanks in advance 🙏

So I see two possible, equally viable options from the Stencil side.

agree with both scenario 1. or 2., make sense 👍. I would say 1. is maybe the clean solution, 2. is the acceptable one, both good in any case. let's keep an eye open and see how it moves forward stencil's side (currently the maintainers are in xmas holidays)

cool, thanks guys, its working now 🤐. stencil needs to update the documentation to point to project_name/project_name.esm.js file or they should do it already. very stupid bug 😂

Wort to notice that npm run build throws such warning if another module entry is used:
[ WARN  ]  Package Json: package.json:6:3
           package.json "module" property is set to
           "dist/websocialshare/websocialshare.esm.js". It's recommended to set
           the "module" property to: ./dist/index.js

      L5:  "main": "dist/index.cjs.js",
      L6:  "module": "dist/websocialshare/websocialshare.esm.js",
      L7:  "es2015": "dist/esm/index.js",

In addition to what we discuss above about documenting Stencil, if the entry point should be modified in Stencil, the warning detection should be updated too.

I have just release @thescientist13  PR in v8.0.1. Thanks!

Guys just another help please, its not related to this, but little guidance.
I am having my tsx template in another .js file say
template-three.js has simple onClick which only alerts
import { h } from '@stencil/core';
export const template_three = () => {
  return <button onClick={() => alert()}>Template three here</button>;
};

when I try to call this method my importing in component tsx  like this
import { Component, Fragment, h, Host, State } from '@stencil/core';

@Component({
  tag: 'component-two',
  styleUrl: 'component-two.css',
  shadow: true,
})
export class ComponentTwo {
  @State() showComponentOne: any;
  method: any;
  template: string = '';

  constructor() {}

  componentWillRender() {
    this.fetchComp(2);
  }

  fetchComp(type) {
    let this_ = this;
    switch (type) {
      case 0:
        import('./template').then(module => {
          this.showComponentOne = module.template_one;
        });
        break;
      case 1:
        import('./template-two').then(module => {
          this.showComponentOne = module.template_two;
        });
        break;
      case 2:
        {
          import('./template-three').then(module => {
            this.showComponentOne = module.template_three.bind(this_);
          });
        }
        break;
      default:
        break;
    }
  }

  clicked() {
    alert();
  }

  methodHere() {}

  render() {
    let this_ = this;
    return this.showComponentOne ? this.showComponentOne.apply(this) :

;
  }
}

View renders, but event listners are not working, not even a simple alert :(
Can you tell me what I am doing wrong in stencil syntax. I can't keep templates in component only cause I have many UI's for same logic.

@peterpeterparker
Awesome, I will swap out my fork back to this package in a few and report back.

@pranav-js
This probably isn't the right issue for that question, and unfortunately I am not familiar with the Stencil ecosystem.  I would probably recommend posting something on StackOverflow or see if the Stencil project has Discussions enabled on its GitHub repo (or maybe has a Discord?).  (fwiw, I don't see you using h anywhere in your code, so maybe it's an issue with how you are creating your templates?)

@pranav-js give a try to the Stencil Slack Channel for your question, not sure what you are trying to achieve and it isn't related to this issue, thanks in advance and good luck.

@peterpeterparker can confirm that pointing back to upstream in my project now, everything is working.  💯

Awesome! Thanks again for the PR and feedback

@thescientist13 hahha, you found my lit comment too for same thing . I was trying lit and stencil together to see which is possible I like stencil but not able to separate out only template part in other file with events attached (view works). same thing in react works though. will have to put some StackOverflow question.


[Refactor] Shorten Taipy Templates path

Description
taipy\templates\scenario-management\{{cookiecutter.__root_folder_name}}\pages\scenario_page\data_node_management.py'
We could shorten:

scenario-management
__root_folder_name

and maybe other elements.
This will fix :https://github.com/Avaiga/taipy-enterprise/issues/446 https://github.com/Avaiga/taipy/issues/808
Acceptance Criteria

[ ] Ensure new code is unit tested, and check code coverage is at least 90%.
[ ] Propagate any change on the demos and run all of them to ensure there is no breaking change.
[ ] Ensure any change is well documented.

Code of Conduct

[X] I have checked the existing issues.
[ ] I am willing to work on this issue (optional)

We can add a warning on taipy doc.


Add Multilayer Perceptron (MLP) primitive for binary classification

Related to #121

I would like to work on this

@Hector-hedb12 Would you mind adding here the link to the corresponding section in the keras docs and summarize what the architecture will be?
Just to keep track of what each issue is

The architecture would be:
Dense (default: ReLU) layer ---> Dropout layer --> Dense (default: ReLU) layer ---> Dropout layer --> Dense (default: sigmoid) layer

You can find an example of this here in the MLP for binary classification section:
import numpy as np
from keras.models import Sequential
from keras.layers import Dense, Dropout

# Generate dummy data
x_train = np.random.random((1000, 20))
y_train = np.random.randint(2, size=(1000, 1))
x_test = np.random.random((100, 20))
y_test = np.random.randint(2, size=(100, 1))

model = Sequential()
model.add(Dense(64, input_dim=20, activation='relu'))
model.add(Dropout(0.5))
model.add(Dense(64, activation='relu'))
model.add(Dropout(0.5))
model.add(Dense(1, activation='sigmoid'))

model.compile(loss='binary_crossentropy',
              optimizer='rmsprop',
              metrics=['accuracy'])

model.fit(x_train, y_train,
          epochs=20,
          batch_size=128)
score = model.evaluate(x_test, y_test, batch_size=128)