External field improvements

This PR introduces new features to the External field. These features were spun out of work on the upcoming Contentful package (#325).
Features

A new mapRow API for External fields, to select which fields appear in the table
New filterFields (and initialFilters) APIs to enable the user to create filter forms using the Fields API
General UI and docs refinements

Demo
Please read the docs for examples

Closes #261

@monospaced backatchya. And no, the focus change was not intentional but suggest we pick it up in #327


drain_filter rename missing from migration guide

The migration guide for 0.10 to 0.11 does not cover that the drain_filter function on HashMap, among others, was renamed to extract_if.
There's a behaviour change so this is not a simple textual replacement.

This is due to an upstream breaking change in hashbrown, as I understand it. I don't think we should be putting serious energy into reporting on / collating changes for those crates, although if one is submitted I'd probably accept it.
Secondly, migration guide issues should be created at https://github.com/bevyengine/bevy-website.


Energy Absorption

Need to implement the 'how many points can blast back with if stored'

done - only doing if better than their own attack currently


Extend zod schema with prisma.schema comments

Problem
Since Prisma does not have such a reach check as Zod has - like min/max/length, email/URL, transform, etc. - we could add those extra Zod checks using Prisma comments ///
prisma.schema
model Post {
  id String @id @default(uuid()) /// @zod.uuid()

  /// @zod.max(255, { message: "The title must be shorter than 256 characters" })
  title String

  contents String /// @zod.max(10240)
}

zod schema output
export const PostModel = z.object({
	id: z.string().uuid(),
	title: z.string().max(255, { message: 'The title must be shorter than 256 characters' }),
	contents: z.string().max(10240),
})

Suggested solution
here's an example in a similar prisma2zod generator
Just a suggestions
Maybe you can optionally provide an npm package, that generates tRPC based on zod schema from another plugin(s).
Or maybe in generator configuration, we can add pre- and post-processors to be triggered during prisma.schema generation to do some extra stuff.

Hello @olehmelnyk
While this might be a nice addition, it's not going to be as simple. The case of zod-prisma generator is simple because only base models schemas are generated; like Post and User. Here it's different, full CRUD schemas get generated. So the expected solution should cover all possible paths deep down. Contributions are welcomed of course, so you can give it a try if you would like.
Could provide examples on the suggestions?
Like an example on zod-to-trpc and an example on the pre and post hooks. I want to understand what you have in mind. Maybe one of them can be done.
Thank you for using this generator :)

Sure.
prisma-to-trpc generator currently depends on prisma-to-zod generator.
Since your prisma-to-zod generator does not support extra zod-validations via comments, and another project has that functionality (zod-prisma) - I thought it would be nice if we can run our custom middlewares/hooks before and after prisma-to-trpc is generated.
Here's an example:

we update prisma.schema
we run prisma generate to create migrations
prisma-to-trpc generator (or maybe new one generator with pre- and post-middlewares) runs, so we could run custom code before and after trpc is generated.

Like:

generate zod.schema with extra validations from /// prisma comments (ex. zod-prisma)
generate tRPC handlers for the backend using zod.schema from the previous step (that's what this repo is responsible for)
how about generating tRPC handlers for the frontend as well?
I can imagine we could even generate front-end forms since we know the fields, their types, and validations - of course, this would not be ideal, but just a good start for prototyping - so those forms could be used in the client-side app and admin dashboard (probably will have to write a custom module for this, once I figure out how those generators works)
we can generate mocks for testing based on zod.schema (ex. zod-mocking)
generate DB seeds based on zod.schema and faker (ex. @anatine/zod-mock)
generate OpenAPI docs from zod.schema (ex. @anatine/zod-openapi)


Detect WAVE and FLAC

Hi, thanks for maintaining binwalk.
This PR adds RIFF WAV and FLAC format. It is based on the commits of PR #437 from the upstream.
Squashed three commits into one.

Thanks!


MQTT: Add mainsmeter and EV meter entities

Subject says it all.

I think most of the EV meter values are already in the current code. Exception being the totals and the total kwh counters.

https://github.com/serkri/SmartEVSE-3/blob/2aa41ba0c6da6102b4720d30ce1d5593412f27c1/SmartEVSE-3/src/evse.cpp#L2483
https://github.com/serkri/SmartEVSE-3/blob/2aa41ba0c6da6102b4720d30ce1d5593412f27c1/SmartEVSE-3/src/evse.cpp#L2484
These should actually be put under the if(EVMeter) conditional.
Also, I think the renaming of the existing EVMeter values is unnecessary.

I'm ok with either direction, I was just trying to create "feature parity" with your HACS component. Those totals are in there too....
The doubling of topics was an honest mistake, and the renaming of topics was intended to being consistency in the sensors - not a 'lighthearted change'
I'm not sure if your comments are intended the way I perceive them (rather negative), but I'm just a guy trying to help. Help on building out a feature that I thought is great and could be a great alternative to the hacs component.
Anyways, as with previous PRs happy to make adjustments but they won't be until after the weekend as I am away from my system.

@hmmbob I surely appreciate your contributions, dont want to discourage you, but wanting to encourage to uphold the quality of your earlier contributions!
Especially on API/interface issues I like to walk a straight line, because as our firmware grows it is so easy to get entangled in growing, non-orthogonal definitions.
As you state correctly, we already grew into that with the REST API, it keeps on growing on a weekly basis and cutting back to the essence would mean massive incompatibility with earlier versions.
So please keep up the good work, none of us is as smart as all of us!

As to kW, kWh and W, Wh I do not like showing numbers in higher accuracies than they are actually measured. Most of our kWh meters used are Class 1, which mean they are measuring with 1% accuracy. Showing values in W and Wh suggest accuracies of 1%% or more...
So I suggest staying with the rounding/accuracies of the REST API.

I think I did that, right? Got the code directly from the JSON generator down in the code.
If that's not the correct code, please drop a line on how it should be, happy to change. Did not change anything there functionally.

Yup my comment was meant as a comment to @arpiecodes who stated he likes W and Wh more than kW and kWh.
So,we're on the same side on this one 😁

I don't like publishing totals (e.g. Mains Current Total), because it seems to me that a broker should publish basic information and derived values can/should be computed and the subscribing client. The cost in our use case would be that in HA people should have to add a few lines to configuration.yaml to compute totals, which is less user friendly then having MQTT publish and HA discover automatically. Now I'm not an MQTT specialist, @arpiecodes what's your opinion on this?

I suppose it's OK to present calculated values for the sake of convenience. But it should be useful in such case. I suppose in the sense of load balancing etc, it's not really useful as that's done across phases. Then again, someone someday will probably have a use-case for it, I just can't think of one now.

As to kW, kWh and W, Wh I do not like showing numbers in higher accuracies than they are actually measured. Most of our kWh meters used are Class 1, which mean they are measuring with 1% accuracy. Showing values in W and Wh suggest accuracies of 1%% or more... So I suggest staying with the rounding/accuracies of the REST API.

Interesting take! For me, sending in values in certain precision would never indicate to me that device is capable of measurements of a certain precision. I suppose I take a different approach, namely to avoid floating point calculations to values at any cost inside computers/microcontrollers, as they simply suck at that. I also don' think these values are meant to be interpreted by humans directly, but always through a client like HA which is smart enough to do conversions on its own. Lastly, I like to also be able to retrieve from the device what you set; e.g. the MQTT set topics are all in Wh/W/smallest value (and the internals in EVSE also store the Modbus values in W/Wh etc) - so why convert something up/down into less precision and return back a completely different value?

"Interesting take!"
It's not my take, in physics it is the basic scientific approach on accuracy, precision and significance of numbers.... https://phys.libretexts.org/Bookshelves/College_Physics/Book%3A_College_Physics_1e_(OpenStax)/01%3A_The_Nature_of_Science_and_Physics/1.03%3A_Accuracy_Precision_and_Significant_Figures

(and the internals in EVSE also store the Modbus values in W/Wh etc) - so why convert something up/down into less precision and return back a completely different value?

I like this take. Of the value comes into the evse in W/Wh, we probably should stick with that.
So, you're saying the modbus values are W/Wh, or are they calculated?

"Interesting take!"
It's not my take, in physics it is the basic scientific approach on accuracy, precision and significance of numbers.... https://phys.libretexts.org/Bookshelves/College_Physics/Book%3A_College_Physics_1e_(OpenStax)/01%3A_The_Nature_of_Science_and_Physics/1.03%3A_Accuracy_Precision_and_Significant_Figures

This probably has a lot of meaning in the scientific world or if you come from a scientific background, but to me is completely irrelevant. I just like consistency and clear logic - and I don't think it's up to the EVSE to take sides here on what's the correct value (and actually changing it in the process - due to floating point imprecision).
There are meters that are more accurate than class 1. It is an assumption most meters are not. And we shouldn't assume is my opinion.

"This probably has a lot of meaning in the scientific world or if you come from a scientific background, but to me is completely irrelevant."
Yeah its not that measuring current, power and energy is physics 🤣

"This probably has a lot of meaning in the scientific world or if you come from a scientific background, but to me is completely irrelevant."
Yeah its not that measuring current, power and energy is physics 🤣

It may be physics, but what we're working on right now is engineering/software. ;)

You're absolutely right, let me sleep over this!

Ok guys you got me convinced, lets keep the power / energy stuff in W and Wh for the following reasons:
-MQTT doesn´t really handle floats, it handles it like strings
-we actually lose accuracy when converting to floating point
-my main problem is that from time to time I get large "spikes" in energy usage; I think it has to do with the "total_increasing" state class in HA, and when (by accuracy errors) a reading slightly LOWER then the previous reading occurs, the total yearly usage is added to the statistics; but I cannot attribute this exactly to this point, also I think since MQTT is broader then HA I shouldnt try to solve HA problems in the MQTT interface.
When overthinking this it occurred to me that we might make some "publish" statements (more) conditional, in the sense that we only publish topics when they deviate from the default value. E.g. the energy counters are set to 0 by default and only when a reading comes in they are updated, IMHO the 0 value should not be published to the MQTT server. It might be the cause of my statistics problem...

When overthinking this it occurred to me that we might need to make some "publish" statements (more) conditional, in the sense that we only publish topics when they deviate from the default value. E.g. the energy counters are set to 0 by default and only when a reading comes in they are updated, IMHO the 0 value should not be published to the MQTT server. It might be the cause of my statistics problem...

Agreed with this. I think we should have a centralised 'setter' function that is used for all supported measurement inside the code and pair it up with a 'getter' (at least for measurement consumption in the API and MQTT code). This way we also don't have to do the conversions in-situ whenever we access the vars, and we can make the MQTT publishing even faster/more optimised (only send values on-change, etc). The code already contains such getter/setter methods for other stuff, like menu settings and Modbus readings.

@hmmbob I think my recently opened pull request may conflict with yours. Sorry for that.

Vacation time, let me redo this work later (and solve the conflicts)


Error: [libs/sql-schema-describer/src/mssql.rs:338:30] called Result::unwrap() on an Err value: "Couldn't parse default value: create default dbo.GPS_INT AS 0   "

https://prisma-errors.netlify.app/report/14128

Here's another occurrence in<EMAIL_ADDRESS>https://prisma-errors.netlify.app/report/14244

Do we support CREATE DEFAULT Transact-SQL statements? look that we don't and it might the case that the introspection engine is not ignoring this create statement. Can it be @tomhoule @Jolg42 ? This we might be able to reproduce.

Some more occurrences:
https://github.com/prisma/prisma/issues/15704
https://github.com/prisma/prisma/issues/15675

We do support CREATE DEFAULT Transact-SQL statements. I'm not sure what's the problem here, but we could try a reproduction.
I could only find this with a as in the statement:
See https://github.com/search?q=org%3Aprisma+%2FCREATE+DEFAULT+.*+as%2F&type=code
We document that "Shared default values are not supported" in docs:
https://www.prisma.io/docs/concepts/database-connectors/sql-server#shared-default-values-are-not-supported
SQL Server docs
https://learn.microsoft.com/en-us/sql/t-sql/statements/create-default-transact-sql?view=sql-server-ver16

There's an introspection test with a CREATE DEFAULT in https://github.com/prisma/prisma-engines/pull/4147 — I can't reproduce the crash. I'll put that in the "I don't know" column.


Revoke should be type $item instead of $role

Item is the parent of role and permission.  Revoke can be used for both.

Duplicate of #7518


Git rid of the last remnants of the Cuda string_table

Signed-off-by: Larry Gritz<EMAIL_ADDRESS>

Seem ok?


FW-688 Jira issue transitioning CI

Conditions/notes for transitions:

Transition one: Dev In Progress -> Dev Done

is triggered on pull request or pull request review
requires build check to complete and pass
requires all PR reviews to be approved (or no reviews requested)
will check pull request title and commit messages for matching issue keys
checks that the issue key exists on Jira and status is Dev In Progress
comment will be added to issue(s) saying who reviewed the pull request
issue(s) transitioned to Dev Done

Transition two:  Dev Done -> QA To Do

is triggered on merge to master
requires issue(s) exist on Jira and status is Dev Done
checks all commit messages associated with merge for issue key
unassignes issue(s)
adds DEPLOYED-DEV label to issue(s)
adds comment to issue(s)

Transition three: QA Done -> QA To Do

is triggered on release matching "release-xx.xx.xx-RC" lower case rc works too
release must have the prerelease flag set with the checkbox near the bottom of the release form
checks all commit messages between the new release and the previous non RC release for issue keys
issue must exist on Jira and status must be QA Done and must have DEPLOYED-DEV label
adds DEPLOYED-PREPROD label and a comment to issue
transitions back to QA To Do

Transition four: QA Done -> Launched

is triggered on release matching "release-xx.xx.xx*"
release must NOT have the prerelease flag set with the checkbox near the bottom of the release form
checks all commit messages between the new release and the previous non RC release for issue keys
issue must exist on Jira and status must be QA Done and must have DEPLOYED-DEV label and the DEPLOYED-PREPROD label
transitions to Launched and unassigns the issue

Can one of the admins verify this patch?


[Feat] Add items to the cart

Description
There are no items in the shops and users are not able to add items to cart. I would like to implement add to cart functionality by placing some items in respective shops and also adding adding to cart feature.
Screenshots
No response
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I'm a GSSoC'24-Extd contributor
[X] I'm a Hacktoberfest'24 contributor
[X] I am willing to work on this issue (optional)

@Pallavi-Mukalla, the items are added by their shop owners only. I think you are not familiar with the project structure and how it works. Please read the README.md file for understanding and then raise an issue. I am closing the issue for now. Please raise another issue, which I am happy to assign to you, but make sure the issue is valid and addresses something important on our website. Otherwise, invalid issues will be closed. Thank you!


Session service provider

Hi,
I updated the SessionServiceProvider to reflect the recent Symfony session changes in http-foundation component + updated related unit test.
Thanks, Onno

It was fixed today in #266 by @igorw

Looks like I beat you to it. Thanks for the effort anyways ;-). I guess #265 can be closed as well.

Aargh, well it was a good experience anyhow, first time github. Did a fetch upstream and still saw the old code :-)


Grpc client hung during rpc request

What version of gRPC and what language are you using?
language : C++, version: 1.30.0
What operating system (Linux, Windows,...) and version?
Linux 4.19.81
What runtime / compiler are you using (e.g. python version or version of gcc)
Python 2.7.16, g++ (Debian 8.3.0-6) 8.3.0
What did you do?
When the client starts up,  2 threads are  started to  monitor the channel connectivity like below. ChannelReady thread is supposed to exit after 30 seconds  but it is hung. Any following  rpc  request will be hung.
`
testClient:: start(const std::string& uri)
{
gpr_log_verbosity_init();
gpr_set_log_verbosity(GPR_LOG_SEVERITY_DEBUG);
IsExitTh = false;
channel = grpc::CreateChannel(uri, grpc::InsecureChannelCredentials());
ChannelStateNotify = std::thread(&testClient::ChannelStateNotify Thread, this);
//This is a workaround to reconnect to server
std::thread(&testClient::ChannelReady, this, 30, true).detach();
}
void testClient::ChannelStateNotify ()
{
bool ok = false;
void *tag = NULL;
while (!IsExitTh)
{
    auto grpc_state = channel->GetState(true);
    if(channel.get()->WaitForStateChange(
                grpc_state, std::chrono::system_clock::now() + std::chrono::seconds(10)) == true)
    {
        std::cout <<" WaitForStateChange state changed";

    }
    else
    {
          std::cout << "WaitForStateChange timedout";
    }
}

std::cout << "Exit channel notification thread";

}
void testClient::ChannelReady(int timeout_seconds, bool checkStateChange) {
grpc_connectivity_state state  = channel->GetState(false);
while ((state != GRPC_CHANNEL_READY) && (timeout_seconds!= 0)) {
state = channel->GetState(true /* try_to_connect */);
if(checkStateChange)
{
(void)channel->WaitForStateChange(state, std::chrono::system_clock::now() + std::chrono::seconds(1));
}
else
{
sleep(1);
std::cout << "Channel is not Ready yet";
}
timeout_seconds--;
}
}
`
Please find below backtrace
Thread 59 (Thread 0x7f9ba926d700 (LWP 9468)):
#0  0x00007f9bc04f17ef in epoll_wait () from /lib/x86_64-linux-gnu/libc.so.6
#1  0x00007f9bc0fb2d67 in pollable_epoll(pollable*, long) () from libgrpc.so
#2  0x00007f9bc0fb3859 in pollset_work () from libgrpc.so
#3  0x00007f9bc0fbb0be in pollset_work () from libgrpc.so
#4  0x00007f9bc0fc25a0 in grpc_pollset_work(grpc_pollset*, grpc_pollset_worker**, long) () from libgrpc.so
#5  0x00007f9bc101ec90 in cq_next(grpc_completion_queue*, gpr_timespec, void*) () from libgrpc.so
#6  0x00007f9bc101f155 in grpc_completion_queue_next () from libgrpc.so
#7  0x00007f9bc24c0676 in grpc_impl::CompletionQueue::AsyncNextInternal(void**, bool*, gpr_timespec) () from libgrpc++.so
#8  0x00007f9bc24aeff7 in grpc_impl::CompletionQueue::Next(void**, bool*) () from libgrpc++.so
#9  0x00007f9bc24ae3b5 in grpc_impl::Channel::WaitForStateChangeImpl(grpc_connectivity_state, gpr_timespec) () from libgrpc++.so.1
#10 0x00007f9bc133538a in bool grpc::ChannelInterface::WaitForStateChange<std::chrono::time_point<std::chrono::_V2::system_clock, std::chrono::duration<long, std::ratio<1l,<PHONE_NUMBER>l> > > >(grpc_connectivity_state, std::chrono::time_point<std::chrono::_V2::system_clock, std::chrono::duration<long, std::ratio<1l,<PHONE_NUMBER>l> > >) ()
#11 0x00007f9bc1333410 in testClient::ChannelReady(int, bool) ()
What did you expect to see?
ChannelReady thread should have exited after 30 second
What did you see instead?
ChannelReady  thread if hug as  WaitForStateChange was hung at epoll_wait (). Any following rpc request done even as part of different thread will be hung like shown in the below back trace:
Thread 63 (Thread 0x7f9ba79e9700 (LWP 9737)):
#0  0x00007f9bc04f17ef in epoll_wait () from /lib/x86_64-linux-gnu/libc.so.6
#1  0x00007f9bc0fb2d67 in pollable_epoll(pollable*, long) () fromlibgrpc.so
#2  0x00007f9bc0fb3859 in pollset_work () from libgrpc.so
#3  0x00007f9bc0fbb0be in pollset_work () from libgrpc.so
#4  0x00007f9bc0fc25a0 in grpc_pollset_work(grpc_pollset*, grpc_pollset_worker**, long) () from libgrpc.so
#5  0x00007f9bc101f879 in cq_pluck(grpc_completion_queue*, void*, gpr_timespec, void*) () from libgrpc.so
#6  0x00007f9bc101faff in grpc_completion_queue_pluck () from libgrpc.so
#7  0x00007f9bc24c0a53 in grpc::CoreCodegen::grpc_completion_queue_pluck(grpc_completion_queue*, void*, gpr_timespec, void*) () from libgrpc++.so
#8  0x00007f9bc2943214 in grpc_impl::CompletionQueue::Pluck(grpc::internal::CompletionQueueTag*) () from libbase_services.so
#9  0x00007f9bc179cd34 in grpc::internal::BlockingUnaryCallImpl<Update , Update >::BlockingUnaryCallImpl(grpc::ChannelInterface*, grpc::internal::RpcMethod const&, grpc_impl::ClientContext*, Update t const&, Update ) () from
#10 0x00007f9bc179b11d in grpc::Status grpc::internal::BlockingUnaryCall<Update ,Update>(grpc::ChannelInterface, grpc::internal::RpcMethod const&, grpc_impl::ClientContext*, Update const&, Update*) ()

can I please  get help with how to solve above issue

Can you share your code as a gist maybe?

Can you share your code as a gist maybe?

Thanks for your response.  I have added the code in the issue log.

Please take a look at https://github.com/grpc/grpc/blob/62c1b4f0139cd28c8c17c2f6ffefc8d391e46354/test/cpp/end2end/end2end_test.cc#L1363
The test is pretty similar to the code that you've provided and works.
From your description of the code hanging at polling and also RPCs not finishing after the deadline seems to indicate that there is something wrong with the timing system. (I'm assuming that there's nothing wrong with the rest of the code.)
To debug this further, I would suggest enabling the polling tracer -
GRPC_TRACE=polling
GRPC_VERBOSITY=DEBUG

Note that polling is a debug mode tracer so your build would also need to have the debug option set.
The log at this line https://github.com/grpc/grpc/blob/62c1b4f0139cd28c8c17c2f6ffefc8d391e46354/src/core/lib/iomgr/ev_epollex_linux.cc#L1116 would help determine what the actual current time and deadline values are.

This bug is outdated now given that the epollex polling engine has now been deleted, but if it still persists on master, please feel free to create a new issue.


Store : Using select without subscribe

Hi
I'm pretty young to angular 2 and nrgx,
So i'm creating my own mean-stack and i think about using nrgx state.
I follow basic introduction setup with counter reducer and i got one problem.
I write same code than in tutorial and i've this error : "{type: {} is not assignable to type number}

I will need for each select subscribe to the value and attach it manually or there a a more convient way to doing this using (store.select) and (Obersable) ?
I prefer ask for using good practices at beginning
Thank's ! :)

async pipe in template

@fxck What did you think, the best way is to use async on template or subscribe (like in my code with counterWorking) ?

async pipe is almost always the better option, as it takes care of cleaning up(unsubscribing) for you

For our projects here (and/or teaching) we recommend using the async pipe in nearly every possible case, and only manually subscribing to an observable when no better solution can be found. This turns out to be not very often.
However, for the type error the original poster reported, the actual solution is to stop using the "string parameter" form of the select operator and instead use the function parameter style.
this.counter = store.select(state => state.counter);

Some people prefer the string form (I don't recommend it all myself). If you prefer the string form and also don't want type errors you need to cast the results of the select call.

Store#select is actually a generic function, so to fix the type error above and use the string form it would be called like this:
this.counter = store.select<number>('counter');

The typings for the string overload select will be improved in v3.0.0

@kylecordes

For our projects here (and/or teaching) we recommend using the async pipe in nearly every possible case

I'm interested in that solution but there's something I'm missing here :
So let say you have a userReducer with a default state :
{
  id: 1,
  name: 'Titi TOTO',
  username: 'Tito',
  age: 100,
  gender: 'male'
}

And you want to display them all. Will you use that async pipe on every display like that ?

{{ (user | async).id }}

{{ (user | async).name }}

{{ (user | async).username }}

{{ (user | async).age }}

{{ (user | async).gender }}

Of course, we might create a component and pass the user object with the async pipe to get rid of asynchrounous code. But in that case how would you do it ? Manually subscribe ? Async everywhere ? Anything else ?

Typically we handle the situation by creating an outer ("smart") component which obtains the data and observable form, then in that outer component we use the async pipe to pass the actual data to an inner ("view") component which would contain the snippet of template shown above. This is called variously the smart/view component pattern, as well as many other names. It is pervasive among redux/react users, and popular among complex observable state Angular users.
I realize this is a 46 minute answer to a three minute question, but you can see a whole bunch more I have to say about this in the following video of a talk I gave a couple months ago.
https://www.youtube.com/watch?v=eBLTz8QRg4Q

in angular 4 your can use:

{{ user.id }}

{{ user.name }}

{{ user.username }}

{{ user.age }}

{{ user.gender }}

@aitboudad With the shipped rc.3 it has to be:
*ngIf="user$|async ; let user"

The improvement you show above, is in master (a couple days ago, to much appreciation...) but hasn't shipped in an RC yet.

So, now with the option to use:
`

{{ user.id }}
{{ user.name }}
{{ user.username }}
{{ user.age }}
{{ user.gender }}
`
What would be the benefits to using that over the smart/view component pattern? Or visa versa?

@ksimonson10 you should always use smart/dumb components as much as possible. In few cases, you don't need a dumb component to display few values. This is where you should use ngIf.

@kylecordes  @aitboudad Speaking of using *ngIf="user$|async ; let user" or
, I tried using .share() operator but apparently it is not working. For example having this.counter$ = this.store.select('counter').share(); while doing multiple counter$ | async in the component.html this creates multiple subscriptions.
Correct me if I am wrong about the above, but is there a reason why it is creating multiple subscriptions even with the use of share() operator or publish().refCount() operators?

Please check this against NgRx v4, and if it’s still an issue, please reopen on https://github.com/ngrx/platform. Thanks!


add python-progressbar for focal

see https://packages.ubuntu.com/focal/python3-progressbar

@tfoote @jacobperron I added a new key python3-progressbar as you requested.
However that forces us to use different branches for our ROS package for kinetic/melodic (python-progressbar) and noetic (python3-progressbar) and not use the same source code version for all ROS distros anymore. Is this the recommended way or is there other best practices to avoid that?

You can use the new new conditional dependencies in package.xml format 3 to make your code dual compatible: https://www.ros.org/reps/rep-0149.html and ROS_PYTHON_VERSION
REP 151 lays out how to migrate to python 3: https://www.ros.org/reps/rep-0151.html#dependencies-and-package-xml

changed to generic key for ubuntu and added debian key.


Tiles are shown wrong with Flutter 3.10.0

Current bug behavior
When I run my simple Flame game with a tiled map. The tiles are shown wrong when I use Flutter 3.10.0
It looks like in this screenshot:

Expected behavior
It should look like this:

And it looks right in "Tiled" and if I downgrade Flutter to 3.7.12.
Steps to reproduce
I use this code for loading the map file and creating the TiledComponent:
@override
  Future<void> onLoad() async {
    final tiledComponent = await TiledComponent.load("map.tmx", Vector2.all(40));
    add(tiledComponent);
  }

And this is the map file:

1,1,1,1,
1,2,2,1,
1,1,1,1

More environment information

Flame version: 1.7.3
flame_tiled: 1.9.1
Platform affected: only tested on ios

Map file doesn't looks right, so here it is again:
<?xml version="1.0" encoding="UTF-8"?>
<map version="1.10" tiledversion="1.10.1" orientation="orthogonal" renderorder="right-down" width="4" height="3" tilewidth="40" tileheight="40" infinite="0" nextlayerid="2" nextobjectid="1">
 <tileset firstgid="1" name="tileset" tilewidth="40" tileheight="40" tilecount="2" columns="2">
  <image source="tileset.png" width="80" height="40"/>
 </tileset>
 <layer id="1" name="Tile Layer 1" width="4" height="3">
  <data encoding="csv">
1,1,1,1,
1,2,2,1,
1,1,1,1
</data>
 </layer>
</map>

Oh no, yet another impeller issue. :(
We'll have to write up some issues for the flutter issue tracker.

I think that this PR will solve this:
https://github.com/flutter/engine/pull/42293

@mrx27o have you tried if it works with Impeller now?

With Flutter version 3.10.4 it's not working. Is this a wrong version?

With Flutter version 3.10.4 it's not working. Is this a wrong version?

Maybe the fix isn't released yet then, or possibly that the fix didn't solve that problem.

@mrx27o have you tried this on the latest version of Flutter (and Flame)?

@spydon it looks better than before, but it's still glitchy. With Impeller there are horizontal and vertical lines betewen my tiles. Without Impeller it looks fine. I will add two screenshots. Current versions:
Flutter: 3.13.1
Flame: 1.8.2
Flame_Tiled: 1.13.0

@spydon I created a simple project to reproduce the problem. You can find it here:
https://github.com/mrx27o/flame_playground

This is most likely a bug on impeller's side, so it would be good to be able to reproduce this in pure flutter code and open an issue at Flutter.

Not sure if I am able to reproduce it. But if the problem occurs in all "tiled" apps with Impeller it should be quite critical.

Can you now check with the latest flutter version 3.19 @mrx27o
When I checked (your repo example) with new version on iOS - default impeller enabled.
And this is the output:

Yes thanks, it seems fixed indeed.


Have you considered using fibers for this project?

Take a look https://github.com/laverdet/node-fibers

No need to use fibers.  Everything about this project is synchronous.


user model: updated password change to properly encode data in db

:construction_worker: Purpose
Fixes bug with password change
:rocket: Changes
Previously when changing a password, we wouldn't properly encode it before storing it in the database.
:warning: Breaking Changes
None

Codecov Report

Merging #175 into V2 will not change coverage.
The diff coverage is 0%.

@@          Coverage Diff          @@
##              V2    #175   +/-   ##
=====================================
  Coverage   5.71%   5.71%
=====================================
  Files         35      35
  Lines       3308    3308
=====================================
  Hits         189     189
  Misses      3087    3087
  Partials      32      32

Impacted Files
Coverage Δ

models/user.go
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a4aff8...23a6edb. Read the comment docs.


[Feat]:  Add Github icon and navigation in the footer for all pages

What feature?
While looking for issues and coming to the github repo, I realised that there is not github icon or link available in the footer of any page. I would like to add this so that user doesn't need to separately visit github and look out for the repository
Show us the magic with screenshots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSoC'23 contributor
[X] I want to work on this issue

@Vaishnavi-Patil2211 Please assign this to me

I had solved this  issue
yesterday

@Vaishnavi-Patil2211 please assign this


Menu: Menu should close when a user tabs to next focusable element

What MDL Version are you using? (please be specific, e.g. major.minor.patch)
material-design-lite-1.2.1
What browser(s) is this bug affecting (including version)?
Any browser
What OS (and version) are you using?
OSX, 10.11.6
What are the steps to reproduce the bug? Can you create a plunker/codepen/jsfiddle which reproduces it?

Open the menus section of getmdl.io: https://getmdl.io/components/index.html#menus-section
Click on a menu botton to open the menu
Press tab to move to next focusable element

What is the expected behavior?
The menu should close
What is the actual behavior?
The menu is still open
One more:
After clicking on the button to open the menu, it is not possible to navigate the menu using keyboard.
When a user cliks on the menu button, the first menu item shuld gain focus.

Is this issue still open


Support for Lightning Testing Service

For using Lightning Testing Service projects need to expand the assigned buildpacks with Java, Chrome and chromedriver.
LTS has the dependency that it then still needs to reference the chromedriver binaries using env variables as described at the bottom of this readme.
  "buildpacks": [
    {
      "url": "https://github.com/wadewegner/salesforce-cli-buildpack#v3"
    },
    {
      "url": "https://github.com/wadewegner/salesforce-dx-buildpack#v4-dev"
    },
    {
      "url": "https://github.com/heroku/heroku-buildpack-jvm-common"
    }
    {
      "url": "https://github.com/heroku/heroku-buildpack-google-chrome"
    },
    {
      "url": "https://github.com/heroku/heroku-buildpack-chromedriver"
    }
  ]

Resolved by using specific LTS config file.
{
  "drivers": {
    "chrome": {
      "version": 2.33,
      "arch": "x64",
      "baseURL": "https://chromedriver.storage.googleapis.com"
    }
  },
  "webdriverio": {
    "desiredCapabilities": {
      "browserName": "chrome",
      "chromeOptions": {
        "binary": "/app/.apt/usr/bin/google-chrome",
        "args": ["--headless"]
      }
    }
  }
}


Add moderators/sponsor for Cambridge, UK

We now have names, whoop. Let's do this :)

Wohoooo 🎉🎉🎉


Incompatibility with certain builds of s2geometry

Solution to issue cannot be found in the documentation.

[X] I checked the documentation.

Issue
The s2geometry changed the way it's built between versions 0.9.0, which produced only libs2.so and version 0.10.0, which produces libs2.so, libs2.so.0, and libs2.so.0.10.0, where the former two are links to the latter. This newer scheme is the more standard one, but there is a problem with the way that we are pinning. Currently, new versions of pys2index are built against s2geometry >= 0.10.0, but the run pin does not include that lower bound. Consequently, new versions of pys2index that link against libs2.so.0 can end up in environments together with old versions of s2geometry that don't have that file.
As a short term solution, we should probably change the run pin here to pin_compatible. Longer term, it would be nice to split s2geometry into libs2(geometry) and s2geometry, where the former only has the library libs2.so.0 and libs2.so.0.10.0, and the latter all the includes plus an appropriate run_export.
Installed packages
-

Environment info
-

If we agree on this, we should probably also add a repodata patch to add the lower constraint for s2geometry to all pys2index builds for versions 0.1.3 and 0.1.4.

we should probably also add a repodata patch to add the lower constraint for s2geometry to all pys2index builds for versions 0.1.3 and 0.1.4.

That would certainly make things cleaner, although for this small package and no major version bump since it exists that is probably not very critical and recommend updating pys2index to the latest version may be enough. Unless there are many users who install other packages than pys2index that also depend on s2geometry?


Can't get full "market" information in mobile wallet

Can't get full "market" and "XVS" information in mobile Android wallet like trustwallet and Bitpie today, but it can get full information some days ago.
It's ok in firefox or chrome.

The negative APY should be RED, not GREEN.

Can't get these data if i don't connect the wallet.

Can't get these data if i don't connect the wallet.

Can't get these data if i don't connect the wallet.


CI: Add Hofer-Julian as code owner for .github/workflows/book.yml

Bilal merging PRs faster than I can refresh ⚡

Bilal merging PRs faster than I can refresh ⚡

Pure luck :P


[EntityHydrator] check property is Readable before get value.

Not compatible with PropertyAccess <2.5

fixed, getValue can throw an exception, so I moves it into try/catch block.


Mediaset support seems broken

I found out that with latest youtube-dl version (2019.11.28) Mediaset is not working anymore, I downgraded to version "2019.9.28" and after a couple of these lines it gives me the right link:
WARNING: Failed to download ISM manifest: HTTP Error 403: Forbidden

While with latest version it does not work:
youtube-dl "https://www.mediasetplay.mediaset.it/video/indaginiadaltaquota/laereo-perduto_F309625801000802"
[Mediaset] F309625801000802: Downloading JSON metadata
[Mediaset] F309625801000802: Downloading MPEG4 SD SMIL data
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl", line 10, in <module>
    sys.exit(main())
  File "/Library/Python/2.7/site-packages/youtube_dl/__init__.py", line 474, in main
    _real_main(argv)
  File "/Library/Python/2.7/site-packages/youtube_dl/__init__.py", line 464, in _real_main
    retcode = ydl.download(all_urls)
  File "/Library/Python/2.7/site-packages/youtube_dl/YoutubeDL.py", line 2018, in download
    url, force_generic_extractor=self.params.get('force_generic_extractor', False))
  File "/Library/Python/2.7/site-packages/youtube_dl/YoutubeDL.py", line 796, in extract_info
    ie_result = ie.extract(url)
  File "/Library/Python/2.7/site-packages/youtube_dl/extractor/common.py", line 530, in extract
    ie_result = self._real_extract(url)
  File "/Library/Python/2.7/site-packages/youtube_dl/extractor/mediaset.py", line 145, in _real_extract
    }), guid, 'Downloading %s %s SMIL data' % (f.split('+')[0], asset_type))
  File "/Library/Python/2.7/site-packages/youtube_dl/extractor/theplatform.py", line 59, in _extract_theplatform_smil
    transform_rtmp_url=lambda streamer, src: (streamer, 'mp4:' + src))
  File "/Library/Python/2.7/site-packages/youtube_dl/extractor/mediaset.py", line 126, in _parse_smil_formats
    return super()._parse_smil_formats(smil, smil_url, video_id, namespace, f4m_params, transform_rtmp_url)
TypeError: super() takes at least 1 argument (0 given)

maybe you can give a url example

Edited the first post for link example and a discovery that I've just made, downgrading to a previous version makes it work again.


Better way to declare rightTitle/onRight inside component

I'm currently following the example in Login.js and doing the following:
componentDidMount() {
    Actions.refresh({
      rightTitle: 'rightTitle',
      onRight: () => {
        this.searchDropdown.toggle();
      },
    });
}

However, this causes a rerender and also resets my refs.
<SearchDropdown ref={this.searchDropdown} />
This ref exists on the first render but is set to null on the second render (caused by Actions.refresh). Is there a better way to set up the navbar before the component is rendered?

It is wrong approach - declare rightTitle and onRight as static function for your component. You could access to your component ref via Actions.refs.SCENE_NAME  #2195

Ok, it would be useful if you also mentioned that this was a mistake in the example, not my mistake.
https://github.com/aksonov/react-native-router-flux/commit/e8c5a428bfe1de72036e71db7ec6d7b17475325f#diff-32afed19f718c82f2588a4adaa45100e

Yes, you are right

16 авг. 2017 г., в 21:14, Daniel van der Merwe<EMAIL_ADDRESS>написал(а):
Ok, it would be useful if you also mentioned that this was a mistake in the example, not my mistake.
e8c5a42#diff-32afed19f718c82f2588a4adaa45100e
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.


Reorganising Python.md so that headings match Cxx.md

This should make it easier for users of the site and the indexing will be almost identical for Cxx and Python.
I have reorganised and also moved some of the links about to more closely match Cxx.md.
Additionally I have added/removed headings to match Cxx.md.
Personally I think it will be easier to follow the same layout in Python as Cxx. I found it a bit confusing when the same named program appeared under a different heading. E.g. in the case of Display in Python, a lot of the programs moved to Cells and Sources to match the Cxx layout.
I validated by running FindMissingExamples.py and reformatting with ValidateMarkdown.py so I am confident everything is there.

I agree, Thanks!


Search icon not showing

Is there a reason why all the search icons are showing like squares.

as stated in the examples did you put <meta charset="utf-8"> in your html ?
<!doctype html> <!-- Important: must specify -->
<html>
<head>
  <meta charset="utf-8"> <!-- Important: rapi-doc uses utf8 charecters -->
  <script type="module" src="https://unpkg.com/rapidoc/dist/rapidoc-min.js"></script>
</head>
<body>
  <rapi-doc
    spec-url = "https://petstore.swagger.io/v2/swagger.json"
  > </rapi-doc>
</body>
</html>

I'm getting this from the examples hosted in rapidoc site itself, that's why I find it weird. Firefox and Chrome have the same issue.
Is this a font that's supposed to be installed in the system?
In chrome it's loading the font as Arial, but Firefox loads Open Sans and it's still not displaying.
https://mrin9.github.io/RapiDoc/examples/example1.html

can you visit any other site which shows unicode characters such as https://en.wikipedia.org/wiki/List_of_Unicode_characters#Arrows
this will isolate is the issue is due to OS/Browser or RapiDoc

Wikipedia page loads ok, but from looking at the styles, it's using a custom font. So that's probably why it's working. Here is a screenshot of how that looks:
In case it helps, I'm using windows 7 to test this.
In firefox where it loads Open Sans you can see all the font information, but it's still not loading for some reason, even using Open Sans. The second screenshot shows the information.

I missed your comment about the fonts from google, they appear to be downloading fine, which is weird.
Is there a way to change these icons?

Is there a way to change these icons?

these are the part of font, windows 7 may not be able to display all the utf-8 charset even if they are provided by the font.
But to answer your question yes you can change the font that works for you. As long as you can get that font to display the unicode chars
The example above shows how you can provide your own font and the place where to download it from

I am guessing this is a browser/os issue I wont be able to help much as I or any of the team members are able to recreate this issue on  our end.
But if you are able to crack it down, do let us know how ? may help someone else.
closing it


Sgrouard/sanity checks updated

Updated sanity check files
It includes the more granular cell categories, as well as the debugging of sanity check 3.

Thanks @SimonGrouard ! i have a few comments. Also, in the part where we do the train split - how are we sure that the test set wasn't used in the building of the siganture matrix, since we split randomly ?

We do a random split with a fixed random state of 42. The same random state is also used to create the train indices / test indices which we use to create the signature matrix.


Check reaper in main binary

The branch has a typo - sorry.
This removes the existing check reaper in favor of a check reaper that is integrated directly into the main Kuberhealthy binary.  Additionally, a bunch of context plumbing has been done so that all external check routines and now directly linked to the parent context created at program start.
The check reaper will start when checks start and stop when checks shutdown (which is normally based on master status).
Fixes #774 👍

This is testable with the kuberhealthy/kuberhealthy:reaper image right now.

This is testable with the kuberhealthy/kuberhealthy:reaper image right now.


Adding support of Electra for device in 11.3.1

Add Electra on device in 11.3.1 based on the code of svedm here: https://github.com/BishopFox/bfinject/issues/36

Can confirm this works, thank you.


Elevators give you permanent creative flight when disconnecting

When you disconnect while riding an elevator and then connect again after the elevator has finished moving, you will be standing in the air and actually have creative flight and full control of it.
You can stop flying like normal, but it doesn't fix the issue as the creative flight ability still stays.
When riding an elevator again without disconnecting, the issue is fixed.

I can confirm this on SF3 1.10, Direworl20 1.10 servers

Thank you for taking the time to create this issue, as we're no longer supporting versions below 1.12, I'm going to go ahead and close it but if this bug seems to continue over to newer versions, please do report it again so we can investigate the issue further.


Bad sample on wiki page

The sample presented on the wiki for "Mix random and sequential workloads (20% random and 80% sequential I/O)" results in an error:

ERROR: use -r to specify IO alignment when using mixed random/sequential IO (-rs)

Adding any kind of -r option results in:

ERROR: sequential IO (-s) conflicts with random IO (-r/-rs)

Is there a way to execute a mix of sequential and random workloads?

Sorry for the delay seeing this. That was a typo on the example - the -s8b should have been -r8b. I've fixed the text.


Select syntax node should ignore punctuation marks

Check for existing issues

[X] Completed

Describe the feature
For the code bellow (| denote cursor position):
{| let a = 10; }

Run editor::SelectLargerSyntaxNode first select the open bracket, run it again will select the whole block.
The same behavior is applied for other cases:
// only select the open bracket
|{ let a = 10; }

// only select the colon
{ "hello":| "world" }

// only select the semicolon
let a = 10;|

// only select the comma
let a = {
  key: value,|
};

IMO select just the punctuation marks is not very useful. In most cases we would want to select the larger node. The smart mode of expand_selection command in SublimeText works this way and I think Zed should do the same.
If applicable, add mockups / screenshots to help present your vision of the feature
No response

cc: @maxbrunsfeld


Email Attachments

In emailHandler.py:
Complete the attach_attachments function.

Notes:

Add "Add File" section to the Email Template HTML --> https://getbootstrap.com/docs/4.6/components/input-group/#custom-file-input
We don't want to store it as a blob and instead want to save it to the database and access it via the "server directory."


Feature: Open links in current tab

Is it possible to add configuration of whether a link is opened in a new tab or in the current one? Right now it always opens in a new tab. It would be good to be able to remain in the current tab.

Hi,
that new feature would help my project too.
Unfortunately, I don't see it mentioned in your roadmap of new things.
Would you mind to prioritize it ? Hope it does not require you too much effort.
Many thanks
Lorenzo

Hi there.
Apparently, draw.io now seems to have the option to have links open in new windows or not. Would it be possible to adapt to it?

In the meantime, if your grafana dashboard is in an iframe, you can rewrite the iframe's window.open function so that the flowcharting link loads in that iframe :
var iframe = $("#your_iframe_id");

function rewriteWindowOpen() {
  iframe[0].contentWindow.open = function(url, windowName, windowFeatures) {
   iframe.attr("src", url);
  }
})

iframe.on("load", rewriteWindowOpen);

If you don't embed your grafana in an iframe, I haven't tested it but you can probably add a Text dashboard, after enabling the (disable_sanitize_html)[https://community.grafana.com/t/disabling-sanitize-html-text-panel-issue-after-upgrade/15409] option in the config, and rewriting the window.open function from there.


sometimes idle detection works even if time entry is stopped?

There is an issue with the Idle Time monitor. Sometimes when I stop my task timer (say after 1 hour) and leave my desk, the idle time detection continues to operate. After 30mins or so when I come back and restart my timer, it reports that 30mins of idle time is detected (even though the timer was previously stopped) and asking if I want to add it or discard it. If I discard the time then the 30mins is knocked off my original 1 hour accumulated pushing it back to 30mins. On some days before I noticed what was happening, I worked all day with occassional breaks but my accumulated time was just a few hours as a result of the bug in the way that the Idle timer is operating.
windows_native_app/7.1.145

Cannot reproduce the issue. If the issue comes up again, let's ask user for a screenshot.


Rename project

Currently project name is similar to google's compile testing framework.
We  should choose another name to resolve this name collision.
This also includes the artifactIds and the base package.
Name could be Toolisticon CompileTimeTesting or CTT as an abbreviation
We should provide a sed call to fix imports for project which need to migrate.

Project will be renamed to CUTE as abbrevation for Compiletime Unit Testing


Improve Enum

Implement getValues() and is() methods.

Do you mean FixtureEnum::C()?
I think that A and B and NUMBER are just enought for our simple test case.

@damianopetrungaro Should I revert tests?

@bigfoot90 yup, it should be good.

@bigfoot90  take a look here too: https://github.com/damianopetrungaro/clean-architecture/pull/13#discussion_r185739034

Codacy is falling, but it's talking about tests, I can't fix this.

@bigfoot90 great squash.
Just for my preference (PR it's really ok)
feat: Add equals and getAllowed methods to Enum

<Explain here why you add those changes>

Fixed equals method. It's ready for merge now.

Thank you for your time and your patience @bigfoot90 !
Really appreciate your quick feedbacks 😄


Wron nodejs interpreter in ubuntu-22.04

Description
I have a WebAssembly code tested with nodejs in ubuntu-22.04 system in github actions. After some cosmetic and unrelated updates the same unittests started failing. Short investigation showed that the used nodejs interpreter is taken from "/usr/local/bin", while I expect it to be taken from the  "/usr/bin" and provided by the ubuntu repositories (installed with sudo apt install).
If the /usr/local/bin/node is expected to be there and not a sign of a security breach, then it shouldn't take priority over the official system one. Otherwise its environment interferes.
Platforms affected

[ ] Azure DevOps
[X] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 18.04
[ ] Ubuntu 20.04
[X] Ubuntu 22.04
[ ] macOS 11
[ ] macOS 12
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
https://github.com/commschamp/commsdsl/actions/runs/4214812766/jobs/7315518038#step:9:950
Is it regression?
yes, https://github.com/commschamp/commsdsl/actions/runs/4178844540
Expected behavior
The following cmake code is expected to find "/usr/bin/node", instead of "/usr/local/bin/node".
find_program (NODE_EXECUTABLE NAMES node nodejs REQUIRED)
message (STATUS "Found node: ${NODE_EXECUTABLE}")

Actual behavior
NODE_EXECUTABLE is set to "/usr/local/bin/node".
I had to pass -DCMAKE_IGNORE_PATH=/usr/local/bin to cmake to workaround the issue.
Repro steps

Install nodejs as part of the build preparation

    - name: Install Packages
      run: sudo apt install nodejs

In cmake configuration try to find "node" executable

find_program (NODE_EXECUTABLE NAMES node nodejs REQUIRED)
message (STATUS "Found node: ${NODE_EXECUTABLE}")

Hello! On runners /usr/local/bin comes first in $PATH and this is expected outcome as lots of software is being installed outside official apt repositories, if you want to use something what conflicts with the existing installation you should either cleanup the /usr/local/bin directory, or change the path priority.


Don't know how to use it

I'm relatively knew to computers and stuff, so all of the stuff is confusing to me.
So, could someone help me with it?

Me also please.  Anyone?

I cannot get this to work either. There is a significant lack of documentation - i.e. exactly what needs to go into each field...
Can you help Yoichiro ? Would love this product to work...
Jerry

OK managed to get a share connected Using:
Server - just the ip address e.g. <IP_ADDRESS>
Port - 445
User - just a simple user name
Password - for that user
Domain - nothing
Shared Resource Name - the actual windows or NAS box share name
Root Directory - nothing
But, when you have added a couple of shares - I want to add about 8 shares - and then switch between them, they never refresh the files/folders in the content pane.
Some problem here with performance...
Jerry


Bump authn-k8s client to v0.16.1

What does this PR do (include background context, if relevant)?
Bumps the version of conjur-authn-k8s-client to v0.16.1
What ticket does this PR close?
Partially resolves cyberark/conjur-authn-k8s-client#70

@sgnn7 ready for rereview.


Popup.isOpen is not documented

As title says, leaflet docs don't have Popup.isOpen documented.

This only affects the 1.0.0 docs, not the 0.7.x docs.
Thus, this is covered by #4203 / #3916.

Closed via #4203 / #3916


rootPrefix cannot have words like #client, #server in the rootPrefix option, this pull request should fix

This should now work through other changes.


Create python-app.yml

This is a standard github action. Seems to have a section for testing with Pytest and based on this: https://coderefinery.github.io/testing/continuous-integration/ seems like it should work? I don't really know what I'm doing here though. @JohnGiorgi lmk what you think

See my newest commit - I believe I addressed your suggestions

See my newest commit - I believe I addressed your suggestions

Cool, there's a couple of open suggestions still and one that I forgot to make about testing multiple versions of python. Also would rename the file ci.yml, will be cleaner if we write more workflows in the future

@JohnGiorgi I believe recent commits here facilitate testing of multiple versions of Python successfully. Lmk if we're good to merge.

@JohnGiorgi I believe recent commits here facilitate testing of multiple versions of Python successfully. Lmk if we're good to merge.

Looks good to me to merge! Thanks @Steven-Palayew.


Adding German language support

Ü

filename needs to be _index.de.md (not underscore before the language shortcode) I believe

alrighty, file name changed


Submission

I submitted my clock but now how do I get the confirmation that I am in the contest

For now there's not confirmation...
I think it will come at the end of contest.

Check the FAQs for more informations...

ughh..

Same here! How do I know they've received it?


GEN1 vs GEN1 VHD

[Enter feedback here]
Hello,
The guidance for preparing a VHD for Azure - could we add a link to this page for our customers to easily view
so the differences between GEN1 and GEN2 VHDs are called out.  For example, GEN2 VHDs do not support encryption in Azure currently.
https://docs.microsoft.com/en-us/azure/virtual-machines/generation-2#:~:text=Generation 1 vs. generation 2 capabilities  ,  ✔  3 more rows
Thank you

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1b9c0d7a-bbf5-eccc-f2ca-a825bf42c82f
Version Independent ID: 58aa93af-4030-1541-a14c-c66c683ccf7c
Content: Prepare a Windows VHD to upload to Azure - Azure Virtual Machines
Content Source: articles/virtual-machines/windows/prepare-for-upload-vhd-image.md
Service: virtual-machines-windows
GitHub Login: @glimoli
Microsoft Alias: genli

Link is already there


feat: add navigation visualizer to the react-navigation plugin

Why
The goal is to help developers debug their navigation state with an easy to understand representation.
How
I added a new tab in the react-navigation tool, based on what was already done in the two other tabs. The navigation state is retrieved from the plugin's store, recursively browsed to represent each stack, screen, and tab.
I temporarily renamed the package to be able to deploy it on our side.
What
The window goes as follows, showing two consecutive navigation states:

Identified next steps

The UI could be improved depending on what is identified as a need by other developers
A capture tool could be added to record the evolution of the navigation stack through a whole user journey in the app

that's amazing!
the pr has some changes to move the package to @bam.tech/react-navigation-visualizer-dev-plugin. would you like to take over the react navigation plugin from Theodo? i think we are open and welcome for people to maintain plugins.

Hey Kudo, thanks !
The idea was not initially to override the expo dev plugins react-navigation package, I just changed it temporarily in order to publish it while waiting to be merged here
But we sure can maintain the react-navigation plugin from bam.tech, if that is okay for you of course


use single point prompt  mask decoder slow than pytorch, how to solve this problem?

I have runned the experiment too. On a Macbooc Air M2 it takes the following times to extract image embedding with ViT-L (sam_vit_h_4b8939):

~36 seconds with pt weights
~42 seconds with onnx encoder extracted with samexporter.export_encoder
~ 39 seconds with onnx encoder quantized extracted with samexporter.export_encoder


[BUG] [UI] emoji dont work in markdown list

version 1.10.0 and current
preview: https://gitea.com/gitea/gitea.com/issues/8

This is something that should be done on the client side (like GitHub does). Adding it to markdown will probably create a lot of incompatibilities, and it's also a unnecessary burden for the server.
I'm sure there must be some cool js library add-on we could add for this. 😉

Agree, this is another example of why the library we use (emojify) isn't great compared to what Github and others have which allow this feature to work here (github).

Looks like Github uses this:
https://github.com/github/gemoji
And perhaps this is a somewhat similar go equivalent (or at least a place to start):
https://godoc.org/github.com/knq/emoji


Remove unused or unnecessary methods from osstringext

OsStr gained .len() and .is_empty() in Rust 1.6, so remove .len_() and .is_empty_()
Split's DoubleEndedIterator implementation is completely wrong and unused
(moves a cursor backward instead of splitting from the end)
Split's .size_hint() is slightly wrong and unused
(produces (0,None) instead of (0,Some(0)) when empty, and is O(n))

This change is

Awesome thanks! Sorry I was out of the loop for the past few weeks.


added a attractive signup page

too many folders on the main repository page.  please re-upload your file on #additional-assets or additional-material. Thx


Fixes #175 by removing hardcoded configuration for LibraryExporter.

cc @JunTaoLuo, @abpiskunov

Changes looks good, have you tried testing with the environment variable Configuration set to Release and Debug to see if all the tests pass?

Yes all tests pass with both configurations.

:shipit: after spacing comments

@JunTaoLuo have fixed the spacing issues in another PR  #178
(Did not want to create a commit just for the spacing issues)

:+1:


PIXI.ParticleContainer not drawing sprites beyond certain amount

Hi
I have created a codepen that will make it easier to understand my problem:
https://codepen.io/krnbatta/pen/JjoMRzb
I have a string which represents a maze grid map. I want to draw it using PIXI.js ('@' represents a black cell and '.' represents a white cell)
The string in the example represents the map with 512*512 cells.
So, what I did is I drew straight black lines on a white background and filled only black cells as per '@' in the map string.
I am using ParticleContainer to draw black cells for optimization purposes. The problem is all cells are not being drawn. Is this a bug?
Compare this to normal PIXI.Container where the whole map is being drawn properly: https://codepen.io/krnbatta/pen/PowEGbK

1 BaseTexture per 1 ParticleContainer

Tiles again?
Archive of tilemap-related thread from https://www.html5gamedevs.com/forum/15-pixijs/
Basically, secret of successful tilemap is :

high-level algo - its yours. You choose how to cull tilemap, when to refill, and whether you need chunks.
low-level representation: Container/Sprite , Graphics.beginTextureFill, pixi-tilemap plugin. All have their own limitations.

You chose ParticleContainer as low-level, its a good thing,, but its docs dont mention that it requires same BaseTexture on all sprites inside, I don't know why, we have to make a PR, we have this "issue" every month.

1 BaseTexture per 1 ParticleContainer.
And ParticleContaoner works only with Sprites.
Then PC has 1500 sprites limit by default.
https://pixijs.download/dev/docs/PIXI.ParticleContainer.html

Suppose I have 15000 sprites. What is better?
1.) 1 Particle Container with 15000 sprites
2.) 10 Particle Containers with 1500 sprites each

Hey
I drew the same thing with plain canvas. Seems like it is much faster. Why is it so?
Any explanation?
I modified the same codepen: https://codepen.io/krnbatta/pen/PowEGbK
So, to give you an overall picture: I want to visualise pathfinding algorithms. For showing each step, I have to fill certain rectangles, hide previous ones, show path lines. Just basic graphics like rectangles, circles and lines. Interactions like highlighting them on hover and click on nodes, etc. Do you think PIXI is well suited for this job? There will be too many objects or should I just resort to the canvas as there are no fancy sprites or images and only plain graphic objects of different colours.
I started off with PIXI.Graphics inside PIXI.Container.
But this seems to be slow as there can be 100,000 objects with hiding and showing them. So, I am thinking of/doing these things:

I found Sprites are faster than Graphics. So, I am trying to convert Graphics into texture and thus, sprites.
Furthermore, I am trying to keep a single texture for similar graphics objects to use ParticleContainer as it seems faster.

But I don't think this will improve the situation much.
Looking at how just the map is drawn so quickly just by canvas, I think I should stick to the canvas and use hacks(like tracing mouse position) for click and highlight events. What do you think?

10x1500 and 1x15000 ParticleContainer is the same thing, you can look inside the source code.
There are many ways to do this :)

many Graphics with same GraphicsGeometry
decrease quality of curves thgouthg GraphicsUtils, i dont remember where it is, its easy to find, i mentioned many times.

Looking at how just the map is drawn so quickly just by canvas, I think I should stick to the canvas and use hacks(like tracing mouse position) for click and highlight events. What do you think?

I made 60FPS tilemap with 32x32 size tiles back in 2012-2013.
The thing is, WebGL is difficult. There are many tricks and you have to do extra research if you want it to be significantly faster than canvas when you do tilemaps. It doen'st mean its slower, its just requires extra time to balance things.
As for 100.000 objects - you dont need that many. Good high-level algorithm will cull it down to 4000 with rare refill. Canvas2d is faster because, well, you dont store those objects and you do your culling. In PixiJS there's no culling, if you dont implement it - of course its much slower than culled canvas2d.

Did you even try to use https://github.com/pixijs/pixi-tilemap/ ?

Hi, was about to post a new issue but was wondering if this could be the cause of my problem.
I have made a CodePen that illustrates my problem.

1 BaseTexture per 1 ParticleContainer.
And ParticleContaoner works only with Sprites.

So I cannot have multiple textures in one ParticleContainer?


chore: misc updates and housekeeping

Commits on this PR are meant to do some cleanup, "nice to have" like changes.
@ojeytonwilliams Feel free to merge at any point though. Do not want to overdo it.

@raisedadead longer term is the plan to deploy Docker containers, even if we don't recommend using it in development?

longer term is the plan to deploy Docker containers, even if we don't recommend using it in development?

Yes, you are correct. And since that is deployment/packaging and most likely will not make into this repo itself

I just rebased in the change, so this can be rebased and merged once it's green.


Emsi.Api.Console add remaining commands 1/2

I have published my changes, you can move your Playground methods to Emsi.Api.Console.

As a reminder no need to log everything to output just something so we know that API call has actually worked.
You can still hard code Posts to the DataService.cs
No need to do options to pass ID(s) but if you want, below some reading.

https://github.com/dotnet/command-line-api/blob/main/docs/Syntax-Concepts-and-Parser.md
https://github.com/dotnet/command-line-api/blob/main/docs/Your-first-app-with-System-CommandLine.md
Note: We can always improve the functionality, no need to try to build the best solution but rather anything workable, once we have got more time and will we can work on the improvements 🤣.


CM-220: [WIP] automate test case OCP-65035 on gcp

@xingxingxia ^_^

/retitle CM-220: [WIP] automate test case OCP-65035 on gcp

PS: we need to consider using ginkgo filter test cases for this PR to be merged successfully. As our current e2e tests make use of an AWS CI cluster only and since we're planning to add new test cases for other cloud provider clusters, filtering / ensuring the test suites can be run separately would be required.

@xingxingxia BIG appreciate to you if you may review/comment this pr in time.

@geliu2016 appreciated a lot for the auto! Was on other work, now finished reveiw, please check comments, feel free to discuss whenever needed.

@geliu2016 could you help check the bottom job showing failure? Thanks.
ci/prow/e2e-operator https://github.com/openshift/cert-manager-operator/commit/97f73ae00f373824e90a465b0995a26b73699232 link

@xingxingxia @lunarwhite could you pls take a quick review? thx

Thanks for update. Due to EOD, today reviewed only part. Will continue review next workday.

Done review. Thanks!

@xingxingxia could you please take a view again? thx

/retest-required

@xingxingxia could you please take a quick review? thx

/label docs-approved
/label px-approved
Self-adding, as this PR does not introduce any user facing changes so no doc/px change.

/retest-required

@xingxingxia @swghosh could you please take a view? thanks

/lgtm

Done review with above 5 comments, thanks!

@xingxingxia could you please take aview? it passed succ in local.

Done review with three comments. Once they are updated and a pass log is gotten, I will add /lgtm.

Done review with three comments. Once they are updated and a pass log is gotten, I will add /lgtm.

@xingxingxia passed succ in my local after updated.
Ran 1 of 19 Specs in 179.903 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 18 Skipped

/label qe-approved
@geliu2016 please remove WIP from title.
Once ci/prow/e2e-operator new job passes, Developers can approve.

@swghosh pls take a view, thx, test passed succ in my local.

/assign @TrilokGeer
for final approval

/unhold
/assign @TrilokGeer
@geliu2016 pretty awesome updates now! Reviewed new updates since my last review https://github.com/openshift/cert-manager-operator/compare/5636ad7..dfb0eed , LGTM.
Please also tell your new test result (just wanting to ensure PASSED) in case of any glitch. Thx!

Found minor places that might need update. Please give me some time to finish review, thank you!
/hold

LGTM from my side after reviewing all updates on all comments of Swarup, Yuedong and me. Pretty good now! Given Yuedong will have a few more minor comments, wait for his input.

PR is in great shape, thank you for your contribution!
/lgtm

/assign @xingxingxia

LGTM from my side
/hold cancel
@geliu2016 once you show PASS test result, please @ our approver @TrilokGeer to /approve. Thanks!

test passed succ in my local. cc: @TrilokGeer

/lgtm
/approve


Remove trailing slash in backup endpoint

Test name
Status

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/850/commits/e9860fc3bd27fb0f8f7b0115f610fce1e8883b17
image: perconalab/percona-xtradb-cluster-operator:PR-850-e9860fc3

Test name
Status

scaling
passed

haproxy
passed

upgrade-haproxy
passed

recreate
passed

big-data
passed

scaling-proxysql
passed

init-deploy
passed

security-context
passed

restore-to-encrypted-cluster
passed

upgrade-proxysql
passed

limits
passed

monitoring-2-0
passed

demand-backup
passed

smart-update
passed

affinity
passed

one-pod
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

users
failed

upgrade-consistency
passed

pitr
passed

demand-backup-encrypted-with-tls
failed

tls-issue-self
passed

tls-issue-cert-manager
failed

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/850/commits/e9860fc3bd27fb0f8f7b0115f610fce1e8883b17
image: perconalab/percona-xtradb-cluster-operator:PR-850-e9860fc3

Test name
Status

scaling
passed

scaling-proxysql
passed

security-context
passed

upgrade-haproxy
passed

big-data
passed

haproxy
passed

init-deploy
passed

storage
passed

limits
passed

monitoring-2-0
passed

affinity
passed

one-pod
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

users
passed

upgrade-proxysql
passed

smart-update
passed

upgrade-consistency
passed

self-healing
passed

self-healing-advanced
passed

tls-issue-self
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
passed

operator-self-healing
passed

validation-hook
passed

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/850/commits/e9860fc3bd27fb0f8f7b0115f610fce1e8883b17
image: perconalab/percona-xtradb-cluster-operator:PR-850-e9860fc3


STAC/COG Storage Advice

Hi
I am just starting to look at using STAC and COGs for some of our raster and imagery datasets. We use AWS S3 for storing the data as a backup, however I think there is a better way to use the bucket and the folder hierarchy to work in tandem with a STAC. Listening to some of the presentations last week it seems lots of others are using AWS so wondered if someone could give me some advice or comment on the option below.
We have multiple different datasets refreshed at different times of year and have an archive of over 10 years to publish. We also need to potentially support multiple different projections.
I was thinking of this type of bucket structure

BucketName

Dataset_Name1

Release_Date1

ProjectionA

COGs

UniqueID1.tif
UniqueID2.tif

Thumbnails

UniqueID1.png
UniqueID2.png

ProjectionB

COGs

etc

Release_Date2

etc

Dataset_Name2

etc

initially I will be creating a static STAC but in time would probably like to generate one more dynamically as the biggest dataset I have has 250k tif files, so if there is better storage layout to make generating a STAC easier then if someone could give me ideas that would be great
Thanks

@TimJMartin
What does your STAC Item look like?  Are you including multiple projections within a single STAC Item, or are they different Items?  Likewise with release date, are those the same Items?
I think there is no one structure that works for everyone and really comes down to data access pattern. I like to think of hierarchy in terms of what users are interested in first, then drill down.  For instance in a lot of use cases users are primarily interested in a geographic area first, then by date.
On the other hand the hierarchy isn't super important if you are using a STAC API, as that abstracts the actual locations in the asset URLs.   But it's still a good to have a sensible organization.

Closing due to no acitivity.


More standardization enforcement

Right now I see prettier is added, but would also be a good idea to get eslint going too. Would help with consistency and limit any additional ambiguity around styling and preferences.

Good idea. I get it added.

Resolved with #2 merge


Fixed common spelling error "inbetween" used in README.md

Found and fixed common spelling error of the word 'inbetween' used in the README.md file, changed the misspelling to proper form 'in between'.

I am closing all PRs that are over a year old. Please reopen if you are still working on this.


RFC: Probe Attributes

Is your feature request related to a problem? Please describe.
There are two problems I'm trying to solve here:

Allow for setting config options individually for each probe. e.g. It can be expensive to find inlined instances of a function so we might want to only enable the probe_inline option for the one probe we know needs it.
Give control over currently hidden settings, e.g. making uprobes sleepable

Describe the solution you'd like
Introduce a mechanism to add attributes to a probe.
[probe_inline = true]
uprobe:myexe:funcA
{
  // attaches to all inlined instances of funcA
}

[probe_inline = false]
uprobe:myexe:funcB
{
  // only attaches to non inlined instances of funcB
}

uprobe:myexe:funcC
{
  // no attribute, so uses global config setting
}

[sleepable = true]
uprobe:myexe:funcD
{
  // a sleepable uprobe can read paged-out memory
}

There are loads of available options for perf_events: https://man7.org/linux/man-pages/man2/perf_event_open.2.html
[pid = 1234]
[cpu = 0]
[inherit = true]
hardware:cycles
{
}

Describe alternative solutions or features you've considered

We could introduce a new probe type for sleepable uprobes, e.g. sleepableuprobe:exe:func
We could introduce more colon-separated parameters in the probe definition to give access to perf event options, but this could quickly become unwieldy. Named attributes seem nicer to me.

Sounds reasonable to me. I also don't much care for the alternative solutions. For adding multiple configs, what about comma separated (feels more similar to the colon separated probe syntax) ?
[inherit = true, cpu = 0, pid = 1234]
hardware:cycles
{
}

Also, I think maybe we should not refer to them as 'configs' as that conflicts with our current bpftrace level config syntax and terminology. Maybe probe "traits", "properties", or "options".

High level makes sense to me.
How do we plan on thinking about probe args (colon separated) vs probe attributes? When do we pick one over the other when extending probes?

For adding multiple configs, what about comma separated (feels more similar to the colon separated probe syntax) ?

There's also the third option of using semicolons to match the config block.
[inherit = true][cpu = 0][pid = 1234]
hardware:cycles {}

[inherit = true, cpu = 0, pid = 1234]
hardware:cycles {}

[inherit = true; cpu = 0; pid = 1234]
hardware:cycles {}

I mainly lent towards the first option ([a][b][c]) because it's closest to C++'s and Rust's attribute syntaxes, but that's admittedly not a very strong argument. The other minor thing is that I think it looks better when split across multiple lines:
[inherit = true]
[cpu = 0]
[pid = 1234]
hardware:cycles {}

[inherit = true;
 cpu = 0;
 pid = 1234]
hardware:cycles {}

[inherit = true;
 cpu = 0;
 pid = 1234]
hardware:cycles {}

Also, I think maybe we should not refer to them as 'configs' as that conflicts with our current bpftrace level config syntax and terminology. Maybe probe "traits", "properties", or "options".

👍

How do we plan on thinking about probe args (colon separated) vs probe attributes? When do we pick one over the other when adding or extending probes?

I'd say that colon separated probe arguments should be used for required arguments and named attributes for optional things.
Going through our existing probes, there are a few which are breaking this rule currently:

kfunc[:module]:fn / kprobe[:module]:fn / usdt:binary_path[:probe_namespace]:probe_name. In all of these the middle optional argument is a kind of hierarchical namespace needed to understand the final argument, so I think they make sense in the probe definitions like this.
hardware:event_name[:count] / software:event_name[:count]. I think a "count" (sampling period) is required by perf, but bpftrace provides a default. The same is true for the pid and cpu arguments though and we don't expose them in the probe definition. I suppose count might be more likely to be adjusted by the user, but I wouldn't be against turning it into a named attribute instead.

I'd say that colon separated probe arguments should be used for required arguments and named attributes for optional things.

sgtm. Your analysis of existing rule breakers also make sense to me

There's also the third option of using semicolons to match the config block.

I like this option and even think it looks ok when they all have their own line.

Makes sense to me from a high-level perspective.
Also agree with @ajor's proposal of the distinction between probe parts (colon-separated) and probe attributes (the new syntax). I'd say that if it helps determine where to place the probe, it is a "probe part", otherwise it should be a probe attribute. As an example, kprobe's offset should remain a colon-separated (albeit optional) probe part rather than being converted to an attribute.

Also useful for per-probe warning suppression. We were discussing on IRC about emitting a warning for possibly uninitialized scratch variables

As an extension. Should attributes also be considered on maps? #2954 has map  up front. What if you could write:
#[format("%s %x -> %d", map.key.0, map.key.1, map.value)
let  @somemap :  [ str, int ] -> int

As an extension. Should attributes also be considered on maps?

@fbs I like this suggestion and I think I would prefer something like map attributes for specifying the map type and number of entries instead of overloading the assignment operator for the map itself e.g.
#[type = ArrayMap]
let global @y: int64;

Instead of:
let global @y: int64 = ArrayMap;

cc @JakeHillion for https://github.com/bpftrace/bpftrace/issues/2954

Attributes on maps seems like a great idea. Keeps lots of configuration options open for the future.


Add code comments documenting passing matcher results

Adds code comments to explain the reason for changes in https://github.com/facebook/jest/pull/2198 and outline potential use cases for custom integration.

thanks!


Budgets new ux popup

Describe the changes you have made in this PR
First part of the Budgets UX/UI improvements (related to the popup view)

On popup view of a page that has not have a budget set, there should be a link to do it instead of empty budget bar (right now). Clicking it leads to Edit Preferences modal.
An icon button of that opens Edit Preferences modal should be in the corner of site box.
Modal has updated copy
New disconnect button in Edit Preferences modal.
New design for the Progress Bar

Link this PR to an issue [optional]
Partially fixes https://github.com/getAlby/lightning-browser-extension/issues/2458
Type of change
(Remove other not matching type)

feat: New feature (non-breaking change which adds functionality)

Checklist

[x] Self-review of changed code
[x] Manual testing
[ ] Added automated tests where applicable
[ ] Update Docs & Guides
For UI-related changes
[ ] Darkmode
[ ] Responsive layout

Closing in favor of https://github.com/getAlby/lightning-browser-extension/pull/2617


With Jenkins Ver.2.x, when run commited Docker Image, it starts from SetupWizard.

docker run --name jenkins -d -p 8081:8080 -p 50001:50000 jenkinsci/jenkins:2.10
http://<IP_ADDRESS>:8081/ by browser, install plugins, create First Admin User, then logout.
docker commit jenkins jenkins_configured:2.10
docker stop jenkins
docker run -d -p 8081:8080 -p 50001:50000 jenkins_configured:2.10
http://<IP_ADDRESS>:8081/ by browser, "Getting Started" page was displayed. I expect to start from user login.

This is docker logs of jenkins_configured:2.10.

 An admin user has been created and a password generated.
Please use the following password to proceed to installation:
xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
This may also be found at: /var/jenkins_home/secrets/initialAdminPassword

Jun 25, 2016 6:23:40 AM hudson.model.UpdateSite updateData
INFO: Obtained the latest update center data file for UpdateSource default
Jun 25, 2016 6:23:41 AM hudson.model.DownloadService$Downloadable load
INFO: Obtained the updated data file for hudson.tasks.Maven.MavenInstaller
Jun 25, 2016 6:23:42 AM hudson.model.UpdateSite updateData
INFO: Obtained the latest update center data file for UpdateSource default
Jun 25, 2016 6:23:42 AM hudson.WebAppMain$3 run
INFO: Jenkins is fully up and running
Jun 25, 2016 6:23:43 AM hudson.model.DownloadService$Downloadable load
INFO: Obtained the updated data file for hudson.tools.JDKInstaller
Jun 25, 2016 6:23:43 AM hudson.model.AsyncPeriodicWork$1 run
INFO: Finished Download metadata. 5,986 ms
--> setting agent port for jnlp
--> setting agent port for jnlp... done

OS X 10.11.5, Docker version 1.11.1, build 5604cbe
Best Regards.

Jenkins persists all state to a volume declared in the Dockerfile. Writes to volumes are not persisted in images, which is what a commit creates.

Could this be solved by removing the declaration /var/jenkins_home as a volume?
This being said, mounting /var/jenkins_home as a volume should be strongly recommended for data persistence beyond the lifespan of a single container. The use of docker commit to persist data and configuration should be considered a Docker anti-pattern.

@dweomer Thank you. I got it.
@gotgenes I think removing the declaration /var/jenkins_home as a volume will solve this. This is a spec of Docker.

As @dweomer said, changes to the volume are not persisted, and commit is an anti-pattern


webapps does not exist or is not a directory

I am still having the same issue as mentioned below with version 7.0.75:
https://github.com/jsimone/webapp-runner/issues/40
The output is almost identical:
SEVERE: Exception fixing docBase for context []
java.io.IOException: Application base [{1}] for host [/nfs/agile_apps/integration/avery/apps/webapps/ansible/logs/next-catalogs/target/tomcat.10003/webapps] does not exist or is not a directory. deployOnStartUp and autoDeploy have been set to false to prevent deployment errors. Other errors may still occur.

I thought by adding --expanded-dirname in my parameters, according to this other issue would solve my problem:
https://github.com/jsimone/webapp-runner/issues/57
Unfortunately, this results in an exception because the --expanded-dir-name param is not understood:
Exception in thread "main" com.beust.jcommander.ParameterException: Unknown option: --expanded-dir-name
        at com.beust.jcommander.JCommander.parseValues(JCommander.java:723)
        at com.beust.jcommander.JCommander.parse(JCommander.java:275)
        at com.beust.jcommander.JCommander.parse(JCommander.java:258)
        at com.beust.jcommander.JCommander.<init>(JCommander.java:203)
        at webapp.runner.launch.Main.main(Main.java:72)

Are you having the problem with <IP_ADDRESS> or <IP_ADDRESS>? It's unlikely that I will backport it to 7.

Thanks for the quick reply. I didn't realize those parameters were only in the 8.* versions. We are a little bit stuck in the dark ages so we have so moving to 8 will be a bit of a leap for us for a few applications. If you know of any workaround to this, I would appreciate any suggestions.

Actually it looks like this should be in version <IP_ADDRESS>. And I don't think there is a version 7.0.75 o_O. Can you double check that?

Some other people in our group started with 7.0.40 and added an AJP connector. They also set the webapp-runner version to 7.0.75 when they set the tomcat_version to 7.0.75.

@kenhtanaka maybe they are building that version themselves? there isn't a 7.075 version of this library that I publish:
http://repo1.maven.org/maven2/com/github/jsimone/webapp-runner/

Yes, they made that version themselves. I see the history in our local git that 1d0b0d2 is the last commit by you (John Simone) and then they added on from there. I assume they forked your code to begin with.

@kenhtanaka ok, then I don't think backporting will help much.


dark mode logo service-mesh-interface fixed

Description
This PR fixes #1016
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

@joshboye can you please attach some screenshots of your updated change? That can help reviewer to review PR better! 😄

logo becomes light in dark mode -

In dark mode -

full view in dark and light mo

de-

Nice Work @joshboye 🙌, looks fine to me

@joshboye
Let's discuss this on the Websites call. Please add this as an agenda item in the meeting minutes if you would. :)

@joshboye Let's discuss this on the Websites call. Please add this as an agenda item in the meeting minutes if you would. :)

Sure!

@joshboye
Let's discuss this in websites call. Add this as agenda item in the meeting minutes if you would :)

Good work, @joshboye 👍