Shared datasets can't be opened in the Builder

STR:

Share a visualization V from user X to user Y.
Open the visualization with X with the Builder enabled.

The SQL api request seems wrong, as it doesn't contain the owner schema:
https://juanignaciosl-ded-01-1.carto-staging.com/api/v2/sql?sort_order=asc&rows_per_page=0&page=0&api_key=XXXX&q=SELECT+*+FROM+(SELECT+*+FROM+twitter_t3chfest_reduced)+__wrapped

Opening it with the editor works.
cc @xavijam @CartoDB/builder-backend

Still having those problems??? 😱

Wait, "old" visualizations should not work. New ones will do after several changes made by @javitonino. Correct me buddy If I'm wrong.

Not visualizations but datasets.
On Wed, Oct 5, 2016 at 9:35 AM, Javier Álvarez Medina <
<EMAIL_ADDRESS>wrote:

Wait, "old" visualizations should not work. New ones will do after several
changes made by @javitonino https://github.com/javitonino. Correct me
buddy If I'm wrong.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/CartoDB/cartodb/issues/10023#issuecomment-251603370,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA48aMR1npXS-FHPsev_YP4rKmcSmhrvks5qw1NQgaJpZM4KOf5j
.

--
Juan Ignacio Sánchez Lara
CARTO Backend Engineer
Twitter: @juanignaciosl https://twitter.com/juanignaciosl
CARTO http://www.carto.com — Predict Through Location
Live sessions to learn CARTO http://carto.com/webinars/

Looking at it

Sorry, I tested this in a server that had an old version.


Make process time check depend on initial benchmark

Description
A test in gt4py currently checks raw process time. This makes it check a non-dimensional measure compared to an initial benchmark, in order to eliminate failures based on processor clock rate.
Resolves https://github.com/GridTools/gt4py/issues/785.

bors try

Thanks for the PR, I like the idea of normalizing the runtime. I think the condition should be n times the single merge case, not n/2. (There is 1 merging in the benchmark vs n mergings in the actual performance test.) I also added a 1.5 factor to give the run some slack for e.g. variance. I verified that this test is suitable for detecting the issue fixed in #605.

bors try

@gronerl I initially had it as n *  as well, but realized that techincally the single_process_time variant also includes building up the IR from the factories, and could include validators, etc. That said, I think what you did is great and should give it even a little more slack so we don't get random failures :)


How to launch webcam demo with trained model ?

python tools/demo.py
--config experiments/siamrpn_r50_l234_dwxcorr/config.yaml
--snapshot experiments/siamrpn_r50_l234_dwxcorr/model.pth

How to modify the argument --snapshot when I use trained model to launch the webcam demo?
As when I trained the net with COCO dataset, there were ten checkpoint_e*.pth files in the snapshot folder.

All checkpoints can be used to launch webcam demo. However, you may need to select the best model, which can be done by testing them on VOT or other dataset.

python tools/demo.py
--config experiments/siamrpn_r50_l234_dwxcorr_8gpu/config.yaml
--snapshot experiments/siamrpn_r50_l234_dwxcorr_8gpu/snapshot/checkpoint_e2.pth

I use the script above and encounter problems below:

Traceback (most recent call last):
File "tools/demo.py", line 109, in
main()
File "tools/demo.py", line 69, in main
map_location=lambda storage, loc: storage.cpu()))
File "/home/wangdong/anaconda3/envs/pysot/lib/python3.7/site-packages/torch/nn/modules/module.py", line 719, in load_state_dict
self.class.name, "\n\t".join(error_msgs)))
RuntimeError: Error(s) in loading state_dict for ModelBuilder:
Missing key(s) in state_dict: "backbone.conv1.weight", "backbone.bn1.weight", "backbone.bn1.bias", "backbone.bn1.running_mean", "backbone.bn1.running_var", "backbone.layer1.0.conv1.weight", "backbone.layer1.0.bn1.weight", "backbone.layer1.0.bn1.bias",
......
Unexpected key(s) in state_dict: "epoch", "state_dict", "optimizer".

I got the same error, have you sovle this problem?

me too, have you solved this problem

I met this error too, I wish someone can solve it.

python tools/demo.py
--config experiments/siamrpn_r50_l234_dwxcorr_8gpu/config.yaml
--snapshot experiments/siamrpn_r50_l234_dwxcorr_8gpu/snapshot/checkpoint_e2.pth

I use the script above and encounter problems below:

Traceback (most recent call last):
File "tools/demo.py", line 109, in
main()
File "tools/demo.py", line 69, in main
map_location=lambda storage, loc: storage.cpu()))
File "/home/wangdong/anaconda3/envs/pysot/lib/python3.7/site-packages/torch/nn/modules/module.py", line 719, in load_state_dict
self.class.name, "\n\t".join(error_msgs)))
RuntimeError: Error(s) in loading state_dict for ModelBuilder:
Missing key(s) in state_dict: "backbone.conv1.weight", "backbone.bn1.weight", "backbone.bn1.bias", "backbone.bn1.running_mean", "backbone.bn1.running_var", "backbone.layer1.0.conv1.weight", "backbone.layer1.0.bn1.weight", "backbone.layer1.0.bn1.bias",
......
Unexpected key(s) in state_dict: "epoch", "state_dict", "optimizer".

It seems your weights was not properly loaded.

Since no further question is asked, I'm closing it for now.
Please reopen it or create a new issue if you have further question.


Is it possible to set Orientation ?

Hello,
I would like to use this component vertically, do you think it is possible ?

I will try to add it to the example repo during next week! @jchesne

@ptomasroos would you suggest to just use a transform and rotate the component?

Closed in https://github.com/ptomasroos/react-native-multi-slider/commit/ccf2fda4b4e72f0d7adb61ef69abc0d8b3446366


open jbrowse in a new tab so that it is easy to go back to coffeabase

fixed in 34a51fdf5de51e0bebd5bfd6e4adc3e7305e980d


Usage with @fastify/autoload possible?

Hey, thanks for the plugin! Do you think it is possible to use this in combination with the autoload plugin?
I used fastify generate server --esm --lang=ts --standardlint which essentially generate this file https://github.com/fastify/fastify-cli/blob/master/templates/app-ts-esm/src/app.ts

Hi @sbreiler !
Didn't try but I don't see any reasons, did you try and have an issue with it ?

Yeah, i tried several things. The indirect way of creating a fastify server through fastify-cli is strange enough on its own, also how would you rewrite the route registration shown here https://github.com/fastify/fastify-cli/blob/master/templates/app-ts-esm/src/routes/root.ts?
My attempt looks like this:
import { z } from 'zod';
import {FastifyInstance} from 'fastify'
import {createRoute} from '@http-wizard/core'

const getRoot = async (fastify: FastifyInstance) => createRoute(
    '/',
    {
      method: 'GET',
      schema: {
          response: {
              200: z.object({
                  root: z.boolean()
              })
          }
      },
    }
).handle((props) => {
    fastify.route({
        ...props,
        handler: () => ({root:true})
    })
})

export default getRoot

I'm a bit lost here and new to fastify. Maybe i gonne try to create a script which gets my routes and writes a defintion file for me (which could be automatically executed by some watcher).

Hi,
just letting you know, i moved onto another solution.
Thanks again

Hi,
just letting you know, i moved onto another solution.
Thanks again

Hey, guy. So what is your final solution?

Hi,
just letting you know, i moved onto another solution.
Thanks again

Would you share the solution you switched to?

Unfortunately I don't know anymore, I was in an experimental phase to test different frameworks as a whole. I'm currently trying remix.


Safari not support Lookbehind Regex

Clear and concise description of the problem
I use Vite to build my project, but it is not working in Safari, i reseach and find the issue was created from vite use lockbehind regrex, so i hope your's team fix the issue
Suggested solution
i find the branch forked from vite :  https://github.com/divriots/browser-vite
Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Vite itself isn't meant to be used in browsers, browser-vite is making the bridge possible so I think the fix should be done there instead. There's this gist that polyfills it though, which could be used in browser-vite.

Vite itself isn't meant to be used in browsers, browser-vite is making the bridge possible so I think the fix should be done there instead. There's this gist that polyfills it though, which could be used in browser-vite.

Thank's for your explanation.


LIBDRUM-601 Investigate community based theming capabilities

Implemented community specific Footer Content
https://issues.umd.edu/browse/LIBDRUM-601

Outdated.


Support for JsonPropertyName and other Attributes

I understand that Marten doesn't support the Json serialization attributes on properties except the [JsonIgnore] one. Here is the use case I'm struggling to finding a workaround though.
I use an external web api which provides the OpenAPI schema. For example, something like this.
In order to access the web api I use NSwag.CodeGeneration.CSharp nuget package or any other NSwag tools for generating the C# classes. I tried different settings, but NSwag always adds the JsonPropertyName attribute to every property to match the OpenAPI specification. I don't want to reimplement all those records manually and I would like to be able to store the object to Marten. It is stored correctly, but when I use LINQ to filter or sort by a property the C# property name and casing is used in the SQL which obviously is not matched to the Json. Would it be possible while generating the SQL instead of just using the property name to try to pull the [JsonPropertyName] attribute for that property and use it if it's specified? Here is an example of the code generated by NSwag. Please let me know, if there is any workaround available in the short-term, besides just manually creating the classes?
    ///
    /// This type is used by the taxIdentifier container that is returned in getOrder. The taxIdentifier container consists of taxpayer identification information for buyers from Italy, Spain, or Guatemala. It is currently only returned for orders occurring on the eBay Italy or eBay Spain marketplaces.

Note: Currently, the taxIdentifier container is only returned in getOrder and not in getOrders. So, if a seller wanted to view a buyer's tax information for a particular order returned in getOrders, that seller would need to use the orderId value for that particular order, and then run a getOrder call against that order ID.
    ///
    [System.CodeDom.Compiler.GeneratedCode("NJsonSchema", "<IP_ADDRESS> (NJsonSchema v<IP_ADDRESS> (Newtonsoft.Json v<IP_ADDRESS>))")]
    public partial record TaxIdentifier
    {
        [System.Text.Json.Serialization.JsonConstructor]
        public TaxIdentifier(string @issuingCountry, string @taxIdentifierType, string @taxpayerId)
        {
            this.TaxpayerId = @taxpayerId;
            this.TaxIdentifierType = @taxIdentifierType;
            this.IssuingCountry = @issuingCountry;
        }

        ///
        /// This value is the unique tax ID associated with the buyer. The type of tax identification is shown in the taxIdentifierType field.
        ///
        [System.Text.Json.Serialization.JsonPropertyName("taxpayerId")]
        [System.Text.Json.Serialization.JsonIgnore(Condition = System.Text.Json.Serialization.JsonIgnoreCondition.WhenWritingDefault)]
        public string TaxpayerId { get; init; }

        ///
        /// This enumeration value indicates the type of tax identification being used for the buyer. The different tax types are defined in the TaxIdentifierTypeEnum type. For implementation help, refer to eBay API documentation
        ///
        [System.Text.Json.Serialization.JsonPropertyName("taxIdentifierType")]
        [System.Text.Json.Serialization.JsonIgnore(Condition = System.Text.Json.Serialization.JsonIgnoreCondition.WhenWritingDefault)]
        public string TaxIdentifierType { get; init; }

        ///
        /// This two-letter code indicates the country that issued the buyer's tax ID. The country that the two-letter code represents can be found in the CountryCodeEnum type, or in the  ISO 3166 standard. For implementation help, refer to eBay API documentation
        ///
        [System.Text.Json.Serialization.JsonPropertyName("issuingCountry")]
        [System.Text.Json.Serialization.JsonIgnore(Condition = System.Text.Json.Serialization.JsonIgnoreCondition.WhenWritingDefault)]
        public string IssuingCountry { get; init; }

        private System.Collections.Generic.IDictionary<string, object> _additionalProperties;

        [System.Text.Json.Serialization.JsonExtensionData]
        public System.Collections.Generic.IDictionary<string, object> AdditionalProperties
        {
            get { return _additionalProperties ?? (_additionalProperties = new System.Collections.Generic.Dictionary<string, object>()); }
            set { _additionalProperties = value; }
        }
    }

Great! Thank you!


add_repeating_timer_us only being called once

The code below is the callback for a timer that is setup with:
add_repeating_timer_us(-16670, repeating_timer_callback, NULL, &timer);
When BAD is defined the callback only gets called once and does not repeat.  When BAD is not defined it functions correctly.
Does anyone else see similar results?  What could the issue be?
Thanks,
Offending Code
#define BAD

volatile uint8_t tick = 0;
volatile uint8_t rollover = 0;

bool repeating_timer_callback(struct repeating_timer *t) {

	rollover = 1;
	tick++;
#ifdef BAD
	// using this code this callback only gets called once
	if((tick % 10) > 5) {
#else
	// using this code this callback get called repeatedly
	if(tick > 5) {
#endif
		rollover++;
		tick=0;
	}
}

Complete files
test.cpp
#include <pico/stdlib.h>
#include <stdio.h>
#include <tusb.h>

const uint LED_PIN = PICO_DEFAULT_LED_PIN;
struct repeating_timer timer;

bool repeating_timer_callback(struct repeating_timer*);
void test(void);

int main(int argc, char *argv[]) {

	stdio_init_all();

	// Configure LED
	gpio_init(LED_PIN);
	gpio_set_dir(LED_PIN, GPIO_OUT);

#if 1
	// blink LED until USB connected for stdout
	while(!tud_cdc_connected()) {
		sleep_ms(100);
		gpio_put(LED_PIN, 1 - gpio_get(LED_PIN));
	}
	printf("USB is now connected\n");
        gpio_put(LED_PIN, 1);
#endif

	test();

	printf("end of main\n");
}

//#define BAD
volatile uint8_t tick = 0;
volatile uint8_t rollover = 0;

bool repeating_timer_callback(struct repeating_timer *t) {

	gpio_put(LED_PIN, 1 - gpio_get(LED_PIN));

	rollover = 1;
	tick++;
#ifdef BAD
	// using this code this callback only gets called once
	if((tick % 10) > 5) {
#else
	// using this code this callback gets called repeatedly
	if(tick > 5) {
#endif
		rollover++;
		tick=0;
	}
}

void test(void) {

	add_repeating_timer_us(-16670, repeating_timer_callback, NULL, &timer);

	while(1) {
		sleep_ms(1000);
		printf("1s\n");
	}

	printf("end of test\n");
}

CMakeLists.txt
cmake_minimum_required(VERSION 3.12)

# Pull in SDK (must be before project)
include(pico_sdk_import.cmake)

project(test C CXX ASM)
set(CMAKE_C_STANDARD 11)
set(CMAKE_CXX_STANDARD 17)

# Initialize the SDK
pico_sdk_init()

add_executable(test
	test.cpp
)

# Pull in basic dependencies
target_link_libraries(test pico_stdlib hardware_spi hardware_pwm)

# create map/bin/hex file etc.
pico_add_extra_outputs(test)

# Link to pico_stdlib (gpio, time, etc. functions)
target_link_libraries(${PROJECT_NAME}
    pico_stdlib
)

# Enable USB output, disable UART output
pico_enable_stdio_usb(${PROJECT_NAME} 1)
pico_enable_stdio_uart(${PROJECT_NAME} 0)

BTW, the build showed no warnings. Will need to look to see how to enable them

Ah, i didn't realize they were off by default
You can either use add_compile_options(-Wall) in your CMakeLists.txt or use the target specific target_compile_options


[HUDI-2270] Remove corrupted clean action

Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contributing.html before opening a pull request.

What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)

Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

might be a duplicate of #4016. Or do you want to keep it separate from the other patch. I am ok either ways. Can we please write some UTs if we plan to go ahead with the patch.

If #4016 can fix the exception, this patch is unnecessary.

sorry. I will let Danny continue the review on this. Check with danny on how to go about it.

@danny0405 : can you follow up on this PR. Is this still required even if we land 4016? If yes, can you review this. guess we might want to get it in for 0.10.1.

Close because #4016 solves the problem.


[FontLoader] Font does not render lineThrough correctly on Android.

The Asap font does not render TextDecoration.lineThrough correctly. This only happens on Android and when the font is loaded via the FontLoader. If the same file is downloaded and included in pubspec, it works as expected.

Steps to Reproduce

Reproducible demo:
import 'dart:typed_data';

import 'package:flutter/material.dart';
import 'package:flutter/services.dart';
import 'package:http/http.dart' as http;

Future<ByteData> fetchFont() async {
  final response = await http.get(
      'http://fonts.gstatic.com/s/asap/v11/KFOoCniXp96a-zwU4UROGzY.ttf');

  if (response.statusCode == 200) {
    return ByteData.view(response.bodyBytes.buffer);

  } else {
    // If that call was not successful, throw an error.
    throw Exception('Failed to load font');
  }
}

void main() {
  var fontLoader = FontLoader('Asap');
  fontLoader.addFont(fetchFont());
  fontLoader.load().then((_) {
    PaintingBinding.instance.handleSystemMessage({'type': 'fontsChange'});
  });

  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Custom Fonts',
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(title: Text('Custom Fonts')),
      body: Center(
        child: Text(
          'Asap should have a line through it here',
          style: TextStyle(fontFamily: 'Asap', decoration: TextDecoration.lineThrough),
        ),
      ),
    );
  }
}

Flutter doctor
[✓] Flutter (Channel master, v1.13.0, on Mac OS X 10.14.6 18G2022, locale en-US)
    • Flutter version 1.13.0 at --
    • Framework revision 09126abb22 (7 weeks ago), 2019-12-03 17:43:00 -0800
    • Engine revision<PHONE_NUMBER>
    • Dart version 2.7.0 (build 2.7.0-dev.2.1 a4d799c402)

Issue replicable on latest stable (1.20.4). Tested on Android device (8.1.0) by using Font Loader and by using it directly inside pubspec.yaml.

flutter doctor -v
[✓] Flutter (Channel stable, 1.20.4, on Mac OS X 10.15.4 19E2269, locale en-IN)
    • Flutter version 1.20.4 at /Users/dhs/documents/Fluttersdk/flutter
    • Framework revision fba99f6cf9 (4 days ago), 2020-09-14 15:32:52 -0700
    • Engine revision d1bc06f032
    • Dart version 2.9.2

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/dhs/Library/Android/sdk
    • Platform android-30, build-tools 30.0.0
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.9.3

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 46.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.46.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.11.0

[✓] Connected device (2 available)
    • SM A260G (mobile)                   • 5200763ebcfa861f
      • android-arm • Android 8.1.0 (API 27)
    • iPhone SE (2nd generation) (mobile) • 312977A7-2DB1-4737-AEBB-35FA6522A309
      • ios         • com.apple.CoreSimulator.SimRuntime.iOS-13-5 (simulator)

• No issues found!

I face the same issue in flutter 2.2.2 as well.

Can confirm it's still present

@jason-simmons Per your previous comments, this seems to be a case of a font declaring incorrect strikethrough positions in its metadata. You suggested one of:

Only calculate the strikethrough position if the font metadata reports a position of zero.
Never respect the fonts strikethrough position and always calculate the strikethrough position.

Do you have a suggestion for either? We could attempt this now in SkParagraph.

Verified this issue on latest versions and confirmed that the strikethrough is properly rendered through the text as shown below:

 stable, master flutter doctor -v
[!] Flutter (Channel stable, 3.10.5, on macOS 12.2.1 21D62 darwin-x64, locale
    en-GB)
    • Flutter version 3.10.5 on channel stable at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 796c8ef792 (2 days ago), 2023-06-13 15:51:02 -0700
    • Engine revision 45f6e00911
    • Dart version 3.0.5
    • DevTools version 2.23.1
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[!] Flutter (Channel master, 3.12.0-13.0.pre.40, on macOS 12.2.1 21D62
    darwin-x64, locale en-GB)
    • Flutter version 3.12.0-13.0.pre.40 on channel master at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ddb16b7d92 (10 hours ago), 2023-07-03 14:27:33 -0400
    • Engine revision 987b621eac
    • Dart version 3.1.0 (build 3.1.0-262.0.dev)
    • DevTools version 2.25.0
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/dhs/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for
      more details.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13C100
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] IntelliJ IDEA Ultimate Edition (version 2021.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 65.1.4
    • Dart plugin version 213.7228

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.29.0

[✓] Connected device (3 available)
    • Darshan's iphone (mobile) • 21150b119064aecc249dfcfe05e259197461ce23 • ios
      • iOS 15.3.1 19D52
    • macOS (desktop)           • macos                                    •
      darwin-x64     • macOS 12.2.1 21D62 darwin-x64
    • Chrome (web)              • chrome                                   •
      web-javascript • Google Chrome 109.0.5414.119

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

Closing this as not reproducible on latest version and probably fixed.


replaced yield & block_given? inside define_method (because it didn't work)

... with explicit block parameter since the former does not work
This fixes issue https://github.com/phatworx/devise_security_extension/issues/98

@nicops How about some testing to ensure this works as intended?


[Test] Negative test cases needed for default disks/tags feature

In addition to https://github.com/longhorn/longhorn-tests/pull/275 , we should have test cases to cover the wrong annotation and make sure node controller still work if the annotation is wrong.

Done


Hive - Topology driver

Points I tried to achieve:

Discovery, Topology interfaces not to know about multiaddr, the addressbook is used to fetch multiaddress in concrete implementations if needed
Extract business logic from Hive to rest of the system
Don't put specific logic into libp2p
Cover both known and connected peer added with/without connect

I decided to do on a bit of a handler heavy approach, as I tried to do it with subscription and channels, and this seems much more simple. Wanted to cover full connectivity simple case, we can expand if needed.
Also, unrelated to the hive,  I did a few renaming along the way, @acud I renamed GetterPutter per Janoses comment on your PR that came a bit late, and I was guilty for the name  GetterPutter, I think GetPutter is more Go idiomatic.
Questions:

Bootnode spec - how should they behave in retrospect to topology?
How do we handle connection on a node that is already in the middle of a handshake (connecting). Example, node 2 is connecting to node1, but node 1 does a connect to node 2 in the middle. Rifght now one handshake will break, is this ok?

TODO: tests if this approach is fine

Bootnode spec - how should they behave in retrospect to topology?

Bootnodes should not contribute to the topology.

How do we handle connection on a node that is already in the middle of a handshake (connecting). Example, node 2 is connecting to node1, but node 1 does a connect to node 2 in the middle. Rifght now one handshake will break, is this ok?

This should not be ok. We can treat this as the known issue if the handling is not trivial to add right now.

@janos , @acud One more questions about bootnodes. Can bootnodes connect to other nodes, or they are just being connected to. The reason for this question is that I would like to have an info about all connections if it's a bootnode or not, so I can decide weather to broadcast them or not.
One example, you can get connection from another node, and if it can be a bootnode, you are actually not sure weather to put it in the topology or not. Also, we have a problem here when we get the list of known nodes. We don't know for sure if those are bootnodes or not.

@janos I will live the connection problem as known issue for now and maybe try to tackle this one in separate PR as it might be broader issue then hive related stuff. Sounds good?

@janos , @acud One more questions about bootnodes. Can bootnodes connect to other nodes, or they are just being connected to. The reason for this question is that I would like to have an info about all connections if it's a bootnode or not, so I can decide weather to broadcast them or not.
One example, you can get connection from another node, and if it can be a bootnode, you are actually not sure weather to put it in the topology or not. Also, we have a problem here when we get the list of known nodes. We don't know for sure if those are bootnodes or not.

That is a good question. Bootnodes do not have to broadcasted as they do not contribute to the topology. But it is important for them to have updated peers in address book beside the ones that they connect to. In that sense, it would be good to have them connected to other nodes to exchange peers over hive. In that way current bootnodes are kept up to date but they fill the spot in kademlia (or at least they used to do that). I have no concrete answer right now, except that they should not contribute to the topology, but they should somehow receive info about peers that are not only directly connecting to them.

@janos I will live the connection problem as known issue for now and maybe try to tackle this one in separate PR as it might be broader issue then hive related stuff. Sounds good?

It sounds very good.

@janos , @acud One more questions about bootnodes. Can bootnodes connect to other nodes, or they are just being connected to. The reason for this question is that I would like to have an info about all connections if it's a bootnode or not, so I can decide weather to broadcast them or not.
One example, you can get connection from another node, and if it can be a bootnode, you are actually not sure weather to put it in the topology or not. Also, we have a problem here when we get the list of known nodes. We don't know for sure if those are bootnodes or not.

That is a good question. Bootnodes do not have to broadcasted as they do not contribute to the topology. But it is important for them to have updated peers in address book beside the ones that they connect to. In that sense, it would be good to have them connected to other nodes to exchange peers over hive. In that way current bootnodes are kept up to date but they fill the spot in kademlia (or at least they used to do that). I have no concrete answer right now, except that they should not contribute to the topology, but they should somehow receive info about peers that are not only directly connecting to them.

Hmmm, that's a very good input. I think I would then leave this for separate discussion and maybe even PR as well, cuz it might be an additionial thing to solve for bootnodes. I will think a bout it a bit more and let's discuss at some point.
I think one solution could be not to initialize the same toplogy driver on bootnodes. We don't need a full connectivity driver, but just initialize the one that broadcastes peers. That way, they would receive new nodes when nodes connect to them (they would need to know about them), and they would broadcast new peers to those nodes.
On the other way, then it is easy to now that node you are connecting is bootnode (just because you now :) ), and we can have a flag if it's a bootnode or not, and just not broadcast bootnodes. Does this sounds reasonable as a first solution at least?
Also this goes well with another point that broadcast and connection strategy might be different partss of the topology driver, but that's a different and imo not urget topic, some amount of copy paste of code is just fine :)

... Does this sounds reasonable as a first solution at least?

Yes, it sounds as a very nice solution. Thanks.

... Does this sounds reasonable as a first solution at least?

Yes, it sounds as a very nice solution. Thanks.

Thanks for the input! :) 🙏

Very nice. 👏 Comments are mostly for pedantic purposes.

All comments made sense to me. Fixed. Thanks!

@acud No problem! Thanks you guys for the reviews!


Error using multiple editors in one page.

I got error when using multiple editors in one page. The UI renders correctly but the commands don't work for the first editor.
My code is

$(document).ready(function () {

 UI1 = new SquireUI({replace: '#textarea1', height: 300});
 UI2 = new SquireUI({replace: '#textarea2', height: 300});

});

if I place UI2 before UI1, the UI 1 will work but the UI2 won't.

Sorry, I can't provide support for SquireUI. That's just a demo integration, and probably unsuitable for production use. If you don't want to integrate your own UI with Squire, you might want to look at something like https://github.com/HourlyNerd/angular-squire, which is an integration for Angular.


[Bug]: Getting TS error when importing with subpath import

Version
29.0.3
Steps to reproduce

Clone my Repo at https://github.com/shiftcode/ts-jest-issue/tree/esm-investigation-mts
Follow instruction in README

Expected behavior
I expect to see the two test cases run & pass successfully (commons/util.spec.mts & app/main.spec.mts) as seen by running test:tsc-and-jest in root of project.
Actual behavior
Only one test passes. The other one ( commons/util.spec.mts) will fail since compilation can't be completet.
Debug log
FAIL  src/main.spec.mts
● Test suite failed to run
src/main.spec.mts:3:33 - error TS2792: Cannot find module '@lab/commons/helpers'. Did you mean to set the 'moduleResolution' option to 'node', or to add aliases to the 'paths' option?

3 import {nodeMaxHeaderSize} from '@lab/commons/helpers'

Additional context
As suggested by the error message I tried to change the moduleResolution field in tsconfig which did not help. Also tried with moduleNameMapper in jest config.
Environment
System:
    OS: macOS 12.5.1
    CPU: (10) arm64 Apple M1 Max
  Binaries:
    Node: 16.17.0 - ~/.nvm/versions/node/v16.17.0/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 8.15.0 - ~/.nvm/versions/node/v16.17.0/bin/npm
  npmPackages:
    jest: ^29.2.1 => 29.2.1

Did you check the doc https://kulshekhar.github.io/ts-jest/docs/guides/esm-support#support-mts-extension ?

@ahnpnl yes I tried with the tsconfig options documented in the doc and also took into account the other things mentioned there

I may be having this same issue, although tbh, I thought my issue was ts-jest not properly parsing ESM modules. I'm not able to import multiformats package in my tests. I have no issues with the package imported in my project (although I'm using esbuild for the builds, so it's probably doing some magic there), but when trying to run the tests, all I get is cannot find module 'multiformats/cid'.
Seeing this issue, and given I'm importing only subpaths from multiformats package.. maybe I was wrong and the problem comes from this instead.
I did start with a jest.config.ts file like the one shown in the documentation stated above, and tried many things until my file looks something like this (note it does not work either... it's just for reference, to note I've been trying different things, all without success):
import type { JestConfigWithTsJest } from 'ts-jest'

const jestConfig: JestConfigWithTsJest = {
  // [...]
  extensionsToTreatAsEsm: ['.ts'],
  moduleNameMapper: {
    '^(\\.{1,2}/.*)\\.js$': '$1',
  },
  testEnvironment: 'node',
  transform: {
    // '^.+\\.[tj]sx?$' to process js/ts with `ts-jest`
    // '^.+\\.m?[tj]sx?$' to process js/ts/mjs/mts with `ts-jest`
    '^.+\\.m?[tj]sx?$': [
      'ts-jest',
      {
        useESM: true,
      },
    ],
    'node_modules/multiformats/.+\\.(j|t)sx?$': 'ts-jest'
  },
  transformIgnorePatterns: [
    '<rootDir>/node_modules/(?!multiformats/.*)'
  ],
}

export default jestConfig

My tsconfig.json file looks more or less the same than the documentation link above.

I've just now realized the package CID I was trying to import is exported from multiformat's index file, so I tried changing that, and I still have import errors... Maybe am getting a different issue (?) 🤔

@elboletaire Did you find a solution? I have the same error
Test suite failed to run

    Cannot find module '../../support/lib/toastIsDisplayed.js' from 'src/pages/desktop/contractPage.js'

    Require stack:
      src/pages/desktop/contractPage.js
      src/support/check/checkContainsText.js
      test/support/check/checkContainsText.spec.js

       8 | import DtApp from '../common/dtappPage.js';

@lacell75 TBH I did not find a solution. In my case, the package I was using changed something related to how the bundle was made, and downgrading such package (multiformats) to the previous version before those changes worked.
I spent an embarrassing amount of time with that issue and cannot spend more time on it. So I'm still not sure if it's a ts-jest issue or only happens to multiformats, sorry 😞

literally copy/pasted the example scripts/configs etc and all I get is:
TypeError: Cannot convert undefined or null to object
    at Function.keys (<anonymous>)
    at pathsToModuleNameMapper (/Users/dom/Projects/scripts/node_modules/ts-jest/dist/config/paths-to-module-name-mapper.js:28:39)
    at file:///Users/dom/Projects/scripts/jest.config.js:11:21
    at ModuleJob.run (node:internal/modules/esm/module_job:193:25)
    at async Promise.all (index 0)
    at async ESMLoader.import (node:internal/modules/esm/loader:530:24)
    at async importModuleDynamicallyWrapper (node:internal/vm/module:438:15)
    at async requireOrImportModule (/Users/dom/Projects/scripts/node_modules/jest-util/build/requireOrImportModule.js:55:32)
    at async readConfigFileAndSetRootDir (/Users/dom/Projects/scripts/node_modules/jest-config/build/readConfigFileAndSetRootDir.js:112:22)
    at async readInitialOptions (/Users/dom/Projects/scripts/node_modules/jest-config/build/index.js:396:13)

Even changed the relative imports there to point to ts-jest etc. Nothing seems to work


Fix tmp table location for the default file_format when custom_location is provided

resolves #360
Description
This PR addresses the fix for a bug related to the usage of custom_location for tmp table creation for the default table format in incremental materialization. It was decided to use the location set up in the profile instead of writing to the same location where the original table resides.
Checklist

[ ] I have signed the CLA
[X] I have run this code in development and it appears to resolve the stated issue
[X] This PR includes tests, or tests are not required/relevant for this PR
[X] I have updated the CHANGELOG.md and added information about my change to the "dbt-glue next" section.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Hi @moomindani ,
Could you please review it once you have a chance?
Thanks!

Thank you for your contribution.
To me, it makes sense to have tmp table location under custom_location path.
How about adding unique random prefix or suffix to the location in case table is temp table instead of ignoring custom_location?
Could you please add unit/integ test for that?

Hi @moomindani,
Here is an example of custom_location:
s3://s3_bucket/warehouse/my_table1

custom_location represents the location of the table where parquets files are stored. Making tmp tables share the same S3 location might lead to a risk of data overwriting. Ignoring custom_location for tmp table creation isn`t new approach for dbt-glue adapter. The iceberg incremental table uses the same strategy to avoid conflicts.
We already have an integration test for verifying the base incremental model. This must be already covered:
https://github.com/aws-samples/dbt-glue/blob/1b4d2f12695ebd4607a80342d3fa9ba8d1b4fcc1/tests/functional/adapter/test_basic.py#L148C9-L148C25
Let me know your thoughts!
Thanks!

I meant that we still need some fix to make the temp table location unique and dedicated, but I do not think just ignoring custom location is good idea.

We already have an integration test for verifying the base incremental model. This must be already covered:

The integ test has succeeded without this fix. We need a separate test case to verify that this fix solves the issue.

Hi @moomindani,
Sorry for asking these questions, but I just want to clarify your idea.

but I do not think just ignoring custom location is good idea.

Other options besides using profile location will require fully reconsidering usage of custom_location for table location. custom_location already includes dedicated folder where the data for the table of the model is stored. Example:
custom_location: s3://bucket/table_name/:
file1.parquet
file2.parquet
file3.parquet
If we want to use the same custom_location for temp table, how will it look like in the example above? Will it just create tmp folder inside custom_location like s3://bucket/table_name/table_name_tmp/*? Will it be valid to create tmp table inside existing table from the storage organization?

Fmm. I do not want to have temp table location inside the actual table location.
I was thinking to add suffix like s3://<custom_location>_tmp_abcdef/* but it's not very simple and I could not come up with simple solution to give temp table location. Please ignore that portion of my comments.
I think I can approve the PR after you add the integration test with iceberg.

Hi @moomindani,
I have added the commit with the integration test. Could you please run the integration test once again to make sure everything works?
Thanks!

Thanks. I triggered the integ test here: https://github.com/aws-samples/dbt-glue/actions/runs/8383702333

The integ test failed. Could you please take a look?
Of course, you can run the integ test in your environment by setting environment variables like following:
export DBT_AWS_ACCOUNT=123456789012
export DBT_S3_LOCATION=s3://<your-s3-location>
export DBT_GLUE_ROLE_ARN=arn:aws:iam::123456789012:role/GlueServiceRole
export DBT_GLUE_REGION=us-east-1

pytest tests/functional/

Hi @moomindani,
Sorry for asking you to run integration tests a third time, but I was able to run them on my personal account and everything must work now. Could you please run last time (fingers crossed) and merge the changes if everything is passed?
Thanks!

Reran: https://github.com/aws-samples/dbt-glue/actions/runs/8422396850

Nice, the integ test succeeded.
Could you also please try with iceberg table?
It seems that glue__location_clause has specific logic for iceberg, so I am wondering if this change still works for iceberg tables too.

Hi @moomindani,
My pull-request only brings the changes to "glue__create_tmp_table_as" function which is referenced only in the creation of the default table format. The default table format was covered in integration tests.

As to the iceberg, it continues to reference "glue__location_clause" and it has its own chain of function calls for tmp table creation which doesn`t intersect with my change.
I agree with you that it would be better to cover all table formats like iceberg with integration tests since we have only the default one available right now, but let`s address this in another pull-request.
Thanks!

Thanks for the explanation.
My point here is that this PR replaces glue__location_clause with adapter.get_location and glue__location_clause has iceberg specific block.
https://github.com/aws-samples/dbt-glue/blob/c0ece5ef63697387db1fc58219e4db62bef64e7f/dbt/include/glue/macros/adapters.sql#L9
I want to make sure that this PR does not hurt any iceberg related workload in advance although I expect there won't be any harm.
Please understand, this adapter is being used by many customers in their production, we need to focus the safest option to test required conditions.

That makes sense. Thanks for the explanation.

Thank you for your contribution! Now I have merged your PR.


[featureflag] productCatalogFailure flag raising 128 events

Bug Report
Which version of the demo you are using?
Main (a1cfe470c6c1e412865b351e473060b66674b2fb)
Symptom
When enabling the feature flag productCatalogFailure, the spans from productCatalog service are emitting 128 events.

What is the expected behavior?
The feature flag should be checked only once.
What is the actual behavior?
The feature flag is checked 127 times.
Reproduce
Could you provide the minimum required steps to resolve the issue you're seeing?

pull main
run make start
enable productCatalogFailurefeature flag
navigate to jaeger and check any span with error from the productCatalogService.

@beeme1mr would you be able to take a look at this?
I've quickly checked the productCatalogService and the implementation seems about right:
https://github.com/open-telemetry/opentelemetry-demo/blob/main/src/productcatalogservice/main.go#L253-L257
I couldn't find a place where we would set 127 span events in the productCatalogService, maybe I've missed something.
LMK if you want me to move this issue to the flagd repo.

It looks like a new OTel hook is registered globally for every request, which is very likely the root cause. Either it should be done once during initialization, or the hook should be set at the client level.
https://github.com/open-telemetry/opentelemetry-demo/blob/main/src/productcatalogservice/main.go#L303

Thank you @beeme1mr! 🤩


[Distributed] more restrictions on distributed funcs based on serialization findings

We always intended to ban inout
Varargs we can't support it seems, so ban them right away

Resolves rdar://85442872

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test


Itemized columns in function not working

Version
1.18.0
What happened?
When not using * (A_Star) and itemizing columns, functions fail to generate.
Relevant log output
sqlc generate failed.

# package db
query.sql:15:8: column "id" does not exist

Database schema
create table blog (
    id serial primary key,
    name text not null

);

create function test_select_blog(in p_id int)
    returns table (id int, name text) AS $$
BEGIN RETURN QUERY
    select id, name from blog where id = p_id;
END;
$$ language plpgsql;

SQL queries
-- name: TestFuncSelectBlog :many
select id, name from test_select_blog($1);

Configuration
No response
Playground URL
https://play.sqlc.dev/p/122897d98d937d01051777c6ab253ccb16e5c20d513c03c4e1049bf36349f4f5
What operating system are you using?
Linux
What database engines are you using?
PostgreSQL
What type of code are you generating?
Go

Is there any workaround for this? The best I can think of is to create a fake table that matches the composite table declaration and use setof <table name> instead, but this is far from ideal.

This is fixed in v1.23.0 by enabling the database-backed query analyzer. We added a test case for this issue so it won’t break in the future.
You can play around with the working example on the playground


Input component to money representation

Describe the problem feature solves
Actually not exist a input component to money representation or at least I didn't find it In the documentation of adminbro.
Can someone help me, please?

More ou less as that's it
https://github.com/jsillitoe/react-currency-input#readme


Provide up to date alternative scoped install

Hi @rgbkrk , appreciate for PR :) I've merged this change with 32374d8, amended commit message to follow our guidelines (https://github.com/ReactiveX/RxJS/blob/master/CONTRIBUTING.md#commit).
To allow some of automatic jobs such as creating changelist per release, we're currently having guidelines for commit messages for easier script automation. It'd be greatly appreciate to have further PR from you with those guidelines. Again, thanks for PR!

Yeah, my past PRs I've submitted following the guidelines. In the future I'll not submit these quick fix patches like this, instead filing an issue.

It's always welcome to have PR :)


Alexander branch

Commit Message Guidelines
Header
Blank Line
Body
Blank Line
Footer

The header should look like:
<type>(<scope>): <subject>

The body should have any necessary detailed info about the commit:
An example, references as to where this idea came from, etc.

The footer should have all the issues tagged:
Fixes #123, Fixes #456

So a commit should look like:
feat(users): Add new Yahoo authentication

Yahoo authentication idea proposed by @codydaig
Example implementation in file.js

Fixes #82

Types:

feat - Features, Enhancements, and overall Improvements
fix - Fixes, Bugs, HotFixs, etc...
doc - Changes to the Documentation and doesn't actually touch any code.

Scope:

The scope should be where the change took place.
Examples: users, core, config, articles

Subject:

The subject line should be clear and concise as to what is being accomplished in the commit.

General Rules:

No Line in the Commit message can be longer than 80 characters.

Reference: Angular Conventions

Hey @popeil97, please make your own repository to learn pull requesting. Now you're just causing extra work for volunteers here. Thanks.


Cluster-autoscaler: max node total count flag for CIDR

In some cases we cannot grow the cluster beyond a certain number of nodes. This PR adds a flag to pass this value + appropriate handling in scale up. The cluster won't be forcefully scaled down to meet the passed value.
cc: @piosz @fgrzadkowski

LGTM, just a nit


Spam clicking Shuffle enables a sound without showing it's active

If you spam click the shuffle button 10+ times quickly, it seems that some sounds are enabled (and playing) without the sound's tile displaying the sliderbar (displaying as active)

Ok, I see the problem, thanks.


Property getters can self reference, setting up an infinite loop.

Feature request.  TSC 1.7.5 allows you to create a property that returns a reference to the getter:
class Foobar {
	private _cyclic:string = 'test';

	public get cyclic():string {
		return this.cyclic;  // should be return this._cyclic;
	}

	constructor() {}
}

var f:Foobar = new Foobar();

console.log(f.cyclic);

It would be nice is TSC warned on questionable code like this.

It's possible it's not wrong (e.g. you have a return earlier in the codepath and intend to be recursive).


Some improvements that I need and feel useful to other people

Not sure if this will get any attention since the repo has not changed in 3 years.

Wow. Thank you @azzikid !


Properies evaluation broken after the introduction of PropertyBindingSupport

The evaluation of properties does not work after a76c7526960ecabb1a1ebafc18c211a361bcf998 "chore: replace custom properties binding implementation with PropertyBindingSupport from camel support".
Reproducible through building the Twitter itest and running the jar manually. Clearly the twitter credentials need to be set as documented in the itest README. The scenario succeeds before a76c7526960ecabb1a1ebafc18c211a361bcf998 and fails after a76c7526960ecabb1a1ebafc18c211a361bcf998.
Please assign to me.

@ppalaga done, please create a test against core too so we can isolate where the problem is

There is trailing period missing at https://github.com/apache/camel-quarkus/blob/daaf4d455aace992d5ef5cd727c9297c2686d4dd/extensions/core/runtime/src/main/java/org/apache/camel/quarkus/core/runtime/support/FastCamelContext.java#L377
Let me figure out how to test that.

should be part of the constant
On Mon, 12 Aug 2019 at 17:44, Peter Palaga<EMAIL_ADDRESS>wrote:

There is trailing period missing at
https://github.com/apache/camel-quarkus/blob/daaf4d455aace992d5ef5cd727c9297c2686d4dd/extensions/core/runtime/src/main/java/org/apache/camel/quarkus/core/runtime/support/FastCamelContext.java#L377
Let me figure out how to test that.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/apache/camel-quarkus/issues/129?email_source=notifications&email_token=AAOIJBJIWYF7AOZS65OSV5DQEGANPA5CNFSM4ILB2MLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4C6KLA#issuecomment-520480044,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOIJBL4LYPCO6I7Z5U3HP3QEGANPANCNFSM4ILB2MLA
.

--
Luca Burgazzoli

you can test it by setting:
camel.component.timer.resolve-property-placeholders = false

and test the value is properly propagated to the timer component (which is available in the core it)

you can test it by setting:
camel.component.timer.resolve-property-placeholders = false

Thanks for the tip! Did exactly that.


Use the new Security helper path

Hi, here is a PR that aims to fix my issue
Fix #284

It seems the config already renames this class.


Background color does not change

Description of the problem or steps to reproduce
About all color schemes have same blueish gray background. Either the maker just loves this color, or it is a bug. Also, I didn't find any specifier to change background color in own themes. Please help.
Specifications
Version: 1.4.0
Commit hash: af520cf
Compiled on January 26, 2018
Linux

@tuomassa
save test.micro file in ~/.config/micro/colorschemes and put in the below
# default colour Forground red background green
color-link default "#FF0000,#33FF33"

Open micro and ctrl e set colorscheme test
Micro editor should have a green background and the text should be red if it is not then there is something wrong.

Note that for accurate color display, you must set the MICRO_TRUECOLOR=1 environment variable and use a terminal emulator that supports truecolor rendering.

What is your $TERM environment variable (echo $TERM)? In order to support most colorschemes, your terminal must support 256 colors, indicated by the value xterm-256color if you are using the default Linux terminal.

I also am having issues with this.
Colors are not displaying with truecolor.
For me:

$TERM is set to screen-256color
$MICRO_TRUECOLOR is set to 1

imo, the value $MICRO_TRUECOLOR should be prioritized over the value of $TERM, instead of requiring them both.


Question: Extending Timber for Custom Post Types

A couple of questions about Timber and CPTs.

In the Extending Timber page, we see an example of TimberPost being extended to add custom functionality. I'm unclear how this works - how does the TimberPost object become a MySitePost object?

I'm trying to reduce the size of my controllers, and thus thinking about creating models that represent each of the custom post types I'll be using, which would lead to something like:

class PeopleCollection {

    public function get_posts($args = array()) {

        $default_args = array(
                'post_type' => 'person',
                'posts_per_page' => -1,
                'orderby' => 'menu_order',
                'order' => 'ASC',
                'post_status' => 'publish',
        );
        $args += $default_args;
        $team_members =  Timber::get_posts($args);
    }

}

which allows me to do this in the controller
$context['people'] = (new PeopleCollection)->get_posts();

Does this make any sense? It feels cleaner than adding all this to the controller, but maybe I'm overcomplicating things. If I'd extended TimberPost to create a class called MyPersonPost, how can I get the array to contain "MyPersonPost' objects instead of TimberPost objects?

The Timber::get_posts() function has a class argument so you should be able to use it like this:
class PeopleCollection {

    public static function get_posts($args = array()) {

        $default_args = array(
                'post_type' => 'person',
                'posts_per_page' => -1,
                'orderby' => 'menu_order',
                'order' => 'ASC',
                'post_status' => 'publish',
        );
        $args += $default_args;
        $team_members =  Timber::get_posts($args, 'MySitePost');
    }
}

$context['people'] = PeopleCollection::get_posts();

I'm going to close this as @IJMacD seems to have covered it. Let me know if it's still an issue and I will re-open.

@IJMacD Hi! How do you add 'MyPersonPost' class to timber?

You just need to load the class the same way you'd load any other PHP class or code.  As long as it's a subclass of TimberPost, passing it as an argument to Timber::get_posts should work.

@orest22 @chrisgherbert this can be accomplished as simply as...
/* functions.php */
require_once('lib/MyPersonPost.php');


add HOSTPWD

from Calvin Bell, 3 Oct 2023

NOT URGENT
Hi smanders,
I'm working on docker changes for MicroserviceController. Essentially from within a container, we need access to the pwd of the host machine to add a volume to a new container. (We can go into more detail if you want; just trying to keep it brief)
Here are the changes I'm considering making to CommonLibraries. I would love to hear your thoughts, mistakes I may have made, or alternative solutions.
https://isrhub.usurf.usu.edu/Vantage/CommonLibraries/commit/6f70312ddba12e0ce060c1b86acc5b76a6a001df

in case the commit referenced above ever disappears, the basics of the proposal was to add
# The pwd of the host machine
ARG HOSTPWD
ENV HOSTPWD=${HOSTPWD}

to .devcontainer/centos7-[bld|dev|run].dockerfile, just after timezone TZ
adding
HOSTPWD: ${HOSTPWD}

to .devcontainer/compose.bld.yml just after TZ: ${TZ}`
and adding
env="${env}\nHOSTPWD=$(pwd)"

to .devcontainer/denv.sh

what they were attempting to do with HOSTPWD was never fully explained
here's the pull that merged to SWAT:development https://isrhub.usurf.usu.edu/SWAT/SWATFramework/pull/484
and the code review for "DockerIntegration" https://isrhub.usurf.usu.edu/cbell/SWATFramework/pull/33
these lines https://isrhub.usurf.usu.edu/cbell/SWATFramework/blob/9926122629e4ce7fdbc4b111c5a756ec20fe78ca/SwatCore/MicroserviceController/MSContainer.cs#L51-L62 apparently do what they were going to attempt to use HOSTPWD to do, in some way...

closing as "wontfix"


Set position origin to the left top of an object.

Hi,
How am I able to change the position's origin of a body? And how can I change the position?
I tried to access body.position but unfortunately this doesn't change the rendering.

After a few hours of searching I found the http://brm.io/matter-js/docs/classes/Body.html#method_setPosition method.

Yeah to move the body use Body.setPosition or Body.translate. Changing body.position directly should move the origin (centre of mass).


Question about released model

Hello, Thank for your great work.
I have a question about the released models (e.g. checkpoint_best_legacy_500.pt,  checkpoint_best_100.pt).
Were these models finetuned with Librispeech 960h with labels? Or not?
Sorry for the basic question.
Best regards.

These are pretrained model.

Understood. Thank you for your quick response.


Vendor AppPlatform 2022-03-01-preview SDK

How I made this PR:

npm install autorest
clone python sdk folder https://github.com/Azure/azure-sdk-for-python and your swagger folder.
autorest {swagger-folder}\specification\appplatform\resource-manager\readme.md --multiapi --python --python-mode=update --python-sdks-folder={sdk-folder}\sdk --track2 --use=https://github.com/Sneezry/autorest.python.git#main [--use=@autorest/modelerfour@4.19.2](mailto:--use=<EMAIL_ADDRESS>--version=3.4.5
Copy the generated SDK files to CLI.

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

spring cloud

#closeit


Added Italian filters; improved Spanish filters

Note that if you intend for veganos to match in the Spanish regex (vegan(a|o|os)), you'd have to add veganos to the track parameters, since the Twitter API does whole word matching, not partial matches (hence why vegana doesn't get included in track("vegan")).

Good point. It doesn't make sense to match the plural "veganos" anyway in the context of those verbs. I've removed it from the filter. It's just a remnant of when I was considering finding ways to match tweets of couples posting "we want to become vegan" and suchlike. In actuality that kind of tweet is probably extremely rare. It could be added to a future version in any case.


dclics day flag doesnt return stats from games from same day

dclics --member-id $MEMBER_ID --platform xbox --mode control --period day --character-id $CHARACTER_ID --verbose
searching for last day, doesnt return results from the same day. Need to look into this a bit more.
It might be that bungie only updates the aggregate stats api we use once a day, in which case, the day flag might not be that useful (maybe be more accurate to call it yesterday).
Needs more research.
Opt {
    member_id: "4611686018429783292",
    platform: Xbox,
    period: Day,
    mode: Control,
    output: Default,
    character_id: Some(
        "2305843009264966985",
    ),
    verbose: true,
}
https://www.bungie.net/Platform/Destiny2/1/Account/4611686018429783292/Character/2305843009264966985/Stats/?modes=10&periodType=1&groups=1,2,3&daystart=2020%2D12%2D03T07%3A20%3A17%2E516173%2B00%3A00&dayend=2020%2D12%2D04T07%3A20%3A17%2E516217%2B00%3A00
---------Begin API response---------
{"Response":{"control":{}},"ErrorCode":1,"ThrottleSeconds":0,"ErrorStatus":"Success","Message":"Ok","MessageData":{}}
---------End API response---------

This is due to how the API works. dclics has been deprecated, and replaced with dcliah, which addresses this issue.


Fix/readonly select 520

Closes #842
Still to do:

[ ] replace enketo-tranformer version after https://github.com/enketo/enketo-transformer/pull/139 has been merged and published
[ ] a FF test is failing (but likely not related to this fix)

I believe this should have been in 6.0.3 to actually make use of the Transformer update. Perhaps rebase with the goal of releasing as 6.0.4 before releasing Express?

@MartijnR would you like to do that or should I or @eyelidlessness take over? Would love to close out the week with an Express release if we can!

If @eyelidlessness can do this that would be great. I won't be able to do it today I think (but next week would be). Thanks!

I'm on it!


feat: new label for tracking PRs that are not general.

@feanil as discussed.

Thanks for the pull request, @e0d!  Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.

Applied.

@e0d 🎉 Your pull request was merged!  Please take a moment  to answer a two question survey so we can improve your experience in the future.


Responsiveness issue

Problem:
The current implementation of the cards lacks responsiveness, resulting in inconsistent card display across various devices with different screen widths.
Expected Behavior:
The cards should adapt to the available screen width on various devices, including desktops, tablets, and mobile phones.
Current Behavior:
The cards do not respond to changes in screen width, causing them to appear overlapped on smaller screens.
Steps to Reproduce:

Open the application on a desktop with a large screen and observe the layout of the cards.
Resize the browser window to simulate a smaller screen width (e.g., tablet or mobile device).

I can try working on this. Can you assign it to me?

@anshu-ee-21, I don't think that this is the right issue, because most of the devlopers will be using this site from their desktop or laptop, but if you still think that you this is a valid issue and alredy started working on it then i can assign this issue to you!

The issue persists even in large screen sizes, in the markdown input text area.
Accessing the issue would be beneficial for better user experience.

I've begun looking into this problem to some extent.

great, you can fix this problem, @anshu-ee-21

@anshu-ee-21, what is the update?

Please assign this to me i have fixed this bug. I want to work on it under hacktoberfest 2023.

@hirentimbadiya, the bug has almost been fixed, just a small part is yet to be completed. I'll complete it by today.

@hirentimbadiya, the bug has been fixed too. Do I raise a PR now?

@hirentimbadiya, Do I raise a PR now?

@anshu-ee-21 yes raise the PR, we will review it.

@anshu-ee-21, please raise PR ASAP.


Set the default timeout to 600 seconds

Since you have llama.cpp the default timeout is 600 seconds, then we also set 600

Thank you!

I'm sorry, but I don't write in Go and I'm not ready to take on the task. I propose to divide the task into 2 parts. Part 1 - to correct the inconsistencies of values between llama.cpp and ollama. Part 2 - someone else will add a timeout option and pull the code into all parts of the code.

Hi @slavonnet thanks so much again for the PR. This should be resolved now with the change to a Go-based runner – but let me know if you're still seeing it and we can revisit.


Refactor to be more in line with SRP

Currently the package is defined in a single index.js file. Though it is a small package, it could be refactored to clean up the codebase and be more in line with single responsibility principles. For instance, there are some nested ternaries and an add method is defined within the function export.
I would be willing to take this on and submit a PR, if that's alright!

Sure, good idea, but I think the two open PRs should be merged first.
Would you be able to help review https://github.com/sindresorhus/pretty-ms/pull/25?

This can now be done if you're still interested @kolyaventuri :)

I'll take a stab at it!

@kolyaventuri Still interested?

@sindresorhus hi! Yes, absolutely. Apologies on never getting back to this :joy:

Bump :)


return null getExistingSlugs

the method getExistingSlugs this returns null or a string and not one collection,I changed the method for lists and worked up correctly.
sorry for my English
SlugService.php
protected function getExistingSlugs($slug, $attribute, array $config)
    {
        $includeTrashed = $config['includeTrashed'];

        $query = $this->model->newQuery()
            ->findSimilarSlugs($this->model, $attribute, $config, $slug);

        // use the model scope to find similar slugs
        if (method_exists($this->model, 'scopeWithUniqueSlugConstraints')) {
            $query->withUniqueSlugConstraints($this->model, $attribute, $config, $slug);
        }

        // include trashed models if required
        if ($includeTrashed && $this->usesSoftDeleting()) {
            $query->withTrashed();
        }
        // get the list of all matching slugs
        return $query->lists($attribute, $this->model->getKeyName()); //here
    }

Laravel's lists() method is an alias of pluck() so changing one for the other shouldn't make a difference.  Plus, lists() is deprecated since Laravel 5.2.

I have the same problem of getting a null from this method.
In this case $query is an instance of query builder and not a collection. For a collection 'lists' is an alias of 'pluck' but for a query builder its not hence returning null. Changing it to lists does work.

Hmm ... do you happen to be using Laravel 5.1?
In 5.2, \Illuminate\Database\Query\Builder::lists() is a (deprecated) alias for \Illuminate\Database\Query\Builder::pluck().  In 5.1, it appears that lists() has the correct functionality, whereas pluck() is a (deprecated) alias for value().
And, to make it worse, lists() is gone entirely in 5.3 and pluck() is what we should use.
So, I stand by my use of pluck in the package.  But if we want it to work with Laravel 5.1, I'll need to figure out a switch in that method.

Yes, i am using 5.1

Can you try dev-master? I just pushed a check for the Laravel/Lumen version so it will use lists() or pluck() where appropriate.

Your fix is working. On a different note, I Just realized theres no onUpdate config any more ?

No.  First, it was problematic, trying to figure out all the scenarios where onUpdate would and wouldn't apply.
Second, I think for the majority of users, onUpdate was left as false: if a slug is already set, then don't try and re-slug the model.  This makes sense: you don't want URLs, or other things based on slugs, etc. changing randomly in your app.
Third, if you really want to reslug your model, just do $model->slug = null before saving.

That in fact makes sense.
In a different method but seems like a similar version compatibility issue which might require L5.1 check
SlugService@getExistingSlugs
This function is returning a list of array in L5.1 if similar slugs exist in database. I am using route model binding if that helps.

the changes you made to getExistingSlugs recently is causing it to return array instead of collection in L5.1 which is causing an issue in makeSlugUnique method as you can't call $list->contains($slug) on an array hence resulting in the following error:

Call to a member function getKey() on string

Are you sure that's the issue? Because getExistingSlugs uses pluck, which returns a Collection in both 5.1 and 5.2 (and 5.3).
Can you paste some code that reproduces the issue?

Here's my model class
http://laravel.io/bin/6LKzV

Found the bug. Pushing a fix shortly.

Great. Thanks.


To make the output of repeated pythonizer runs the same, sort globals, imports, and initializations

To make the output of repeated pythonizer runs the same, sort globals, imports, and initializations in the generated code.

Fixed in v1.008


Added Ranu Mondal gif

Added a command which can be used to send the Mondal gif

very good and cringe GIF


Export / import measurements using a qr code

What you want:
This is probably quite the stretch goal.
QR code seems to have the highest possible data density at max 2953 chars
If we'd re-encode measurements back into the uint8list as bluetooth characteristic do, then we should be able to export a reasonable amount in a single qr code.
Why you want it:
Easily share data with other people, import screen should probably be able to override user id. This is not meant as a backup method, but could be used f.e. to share data of the past month with a physician or something. But then we'd probably need a desktop app and multi-user support too.

I toyed around with this a bit unsing low error correction and pseudorandom measurements in the usual bp ranges:

as you guessed non-binary formats are relatively unreasonable (I get about 30 full measurements in that char limit without additional compression)
Using a binary format with one byte per number and only sys,dia, and pul I got ~800 ones in there
For the fun of it I threw zstd on the data before generating the qr and was able to even get ~ 1100 measurements through (which is surprising since this data is practically random, it might actually improve with real data)
If ever neede we could still try a more compact binary format getting away with 7 bits per number by choosing a good offset based on the measurement type.

Looking at app size I only see 0.2MB from qr code creation and compression. If the app needed to bring its own scanning a test package I looked at (mobile_scanner) adds nearly 10 MB, so we would want to avoid that and rely on users sharing from scanner apps (might introduce a link overhead in the qrcode).


Allow clippy map-unwrap-or

map_or is harder too read than the .map().unwrap() versions.

Can you do it In Ruff too


Create a secret route

I added an isProtected key to the array of paths, which checks which path needs protection.
And then, I built in the route tag, a condition that checks if it's protected, then it doesn't go through, and if so, then it goes through.
Hope you liked it, this is my first open source contribution.

@NoamGaash can we close this pr?
@Haim-S your contribution is very appreciated even though it wasn't as requested because some misunderstanding. You are welcome to take another issue :)

@Haim-S @ArkadiK94 it's inactive for a couple of weeks now, I believe it can be closed.
@Haim-S please let us know if you want to reopen it, maybe there's a misunderstanding from our side,
thank you for participating openbus development efforts

Thank you for the opportunity to contribute to your open source, I would
really like to understand where I can contribute and what you would really
like, if there is a meeting on Discord then I would love to join and keep
me updated, thanks.
בתאריך שבת, 16 בדצמ׳ 2023 ב-11:52 מאת NoamGaash <
@.***>:

Closed #279 https://github.com/hasadna/open-bus-map-search/pull/279.
—
Reply to this email directly, view it on GitHub
https://github.com/hasadna/open-bus-map-search/pull/279#event-11265455089,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZBP3DEIHSEO4KHVZZJTPPDYJVVPXAVCNFSM6AAAAABAHLXRFSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGI3DKNBVGUYDQOI
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hi @Haim-S , thank you!
Feel free to join our discord channel and slack channel.
Also, consider making smaller pull requests - so the development cycle will be shorter. You don't have to solve entire issue in a single pull request - any improvement is a great thing.
how about solving this one?
https://github.com/hasadna/open-bus-map-search/issues/80


Build pixi not to show use the "require" methods?

I'm currently doing a project in typescript and it seems like using browserify to build it would be good for me, though when using browserify to require PIXI i get some errors, (it crashes and says it cannot require ./polyfills),
This seems to be because PIXI still got the require method calls in the build version. Is there a way to build PIXI to remove these? I did a simple search and replace to confirm my theory and it worked.
My current browserify build command is
browserify -t debowerify -p [tsify --target es5] index.ts > bundle.js

You shouldn't be requiring the built version with browserify. You should be requiring pixi with just require('pixi.js') which will resolve to our index.js file in the source.
The way browserify works is by wrapping your modules so that your require calls work, not by replacing them and removing them from source.

This is what i am doing, with the bower package the built file seems to be used. Though, with the npm package the behaviour you state seems to happen. Is this the intention? It might be that debowerify asks the bower.json where the entry point is and it seems to point to the bin/pixi.js.
But i guess everything is working as intended then?

Yeah the bower main file is the built file because including the file from bower means you just want the file, not the npm ecosystem version. If you want to use the npm eco system you should just use npm :)

Yes i believe i wanted the bower system but the npm system should work just fine, and while i'm at it, i was thinking of trying to take full advantage of this, requiring only the modules which i need, though i'm not sure how to do this. I found this old page https://www.npmjs.com/package/pixi, it's outdated but since it stated it was intended for browserify i thought it should work. Though, i cannot get it to work properly.
I've tried
var container = require("pixi.js/display/Container");
but it does not work, i guess it thinks pixi here is a subfolder in my project root. Is this possible or what should be my direction here? You seem to have some idea about browserify, i just started using it some days ago :)
Thanks for your answer tho!

The format is <module>[/file/path]. So:
require('pixi.js/src/core/display/Container');

Yes i know, i just stumbled upon that one, which gave me the idea, since i didn't see anything about this in the official pixi one.
The syntax you posted is working correctly and i'm really glad for your help :) :+1:

Thanks man, let me know if you need anything else.


[modify] db seeds cms contents chat

Coverage decreased (-0.002%) to 84.367% when pulling 455611a9f1d9f245ff746c023cf5d43090ee87a2 on feature/chatbot-seed into 210b7cf7f03502a86e4edbe6b1fdc469a725edd4 on master.


migrate to gradle

gradle migration
the project probably needs to be reimported into intellij
run using ./gradlew bootRun
build and test using ./gradlew build

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

We are currently not switching to gradle because of personal preference and since maven does the job just fine. However, if we change our minds in the future then we will look back to this. Thanks for your PR!


Add main entry point in package.json.

I was having trouble using this library with the syntax import 'angular-consent'; and webpack. Without being an expert in npm, it looks like adding a main entry in package.json fixes the problem. Was it on purpose that you did not make one in the first time?

@thiago-sylvain — Thank you, much appreciated! 🏆

Changes have been released as v2.2.0 👍


can this work with another service?

would be nice if it could.

I don't have any plans to support other services as I don't put my listings on other sites.  If someone else wanted to add support I would be happy to look at a pull request.


Create bundle/menu entries for jumpscale scripts

Use a bundling tool like pyinstall/py2app to create jumpscale installation on the filesystem with accessible menu items on the host operating system.
that's a two step process
1- bundling using pyinstaller (works on mac/linux)
2- using a suitable installer different ones for each platform like (innosetup, mojosetup) or something cross platform like (izpack, installbundler -free for opensource applications-)

➤ sabrinasadik commented:
@xmonader is this high prio or not?

➤ xmonader commented:
@sabrinasadik it was 2nd prio after the slides2html tool
@despiegk at which milestone is this expected to be delivered?
I got into many problems with pyinstaller to do the basic bundling for js_shell and I expect it to take some time to fully grasp/fix


feat(manage-merge-queue): do not allow ready for merge when PR is not core approved

:pencil: Description
Requires PRs to have the READY_FOR_MERGE label in order to be added to the merge queue

:tada: This PR is included in version 1.46.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


problem with doc commit: apache2 htaccess, avoid scriptname in URLs

@cebe , After I posted this issue i found doc is about basic template, but i don't know that how it probably works for basic and not for advanced template.
What steps will reproduce the problem?
with https://github.com/yiisoft/yii2/commit/144ccf03443cf18d92c202ad73ecf6c482e71760 commit and putting this lines in backend/web/.htaccess file
  RewriteEngine on
    # If a directory or a file exists, use the request directly
    RewriteCond %{REQUEST_FILENAME} !-f
    RewriteCond %{REQUEST_FILENAME} !-d
    # Otherwise forward the request to index.php
    RewriteRule . index.php

    # if $showScriptName is false in UrlManager, do not allow accessing URLs with script name
    RewriteRule ^index.php/ - [L,R=404]

and
        'urlManager' => [
            'enablePrettyUrl' => true,
            'showScriptName' => false,
			/*
            'rules' => [
            ],
			*/
        ],

What is the expected result?
commit says only for request with .index.php it throws not found.
What do you get instead?
not found for all requests with and without .index.php
i am not expert of rewrite topic but moving  RewriteRule ^index.php/ - [L,R=404] under RewriteEngine on seems work for me.
it seems RewriteRule ^index.php/ - [L,R=404] block even redirected page by RewriteRule . index.php
Additional info

Q
A

Yii version
2.0.13

PHP version
7.2.1

Operating system
centos 7

Same issue for me too. I have created a pull request because this rule utilises the [L] flag (i.e. last), which terminates rewriting after it is matched, which we want to do if incoming url begins with index.php/. We do not want to serve anything if this pattern matches, otherwise forward to the front controller for routing, if not requesting a valid file or directory on filesystem.


SoftwareSystems-SQLite-MemSafety is empty

Task set <tasks name="SoftwareSystems-SQLite-MemSafety"> is empty because it only has a coverage property, so it should not be part of the benchmark definitions.
@dbeyer how to proceed with this? Should every team update its own archives?

@lembergerth If you could do it and create a pull request that would be great!
Best,
Dirk


Additional Features

Hey Ian,
You asked me to file an issue asking for TODOs - do you have anything in mind?

@ianklatzco

i've added some more issues ^^
i think it would be cool if this were a full-featured client!

what precisely does that mean?

every endpoint has a corresponding python function (it might be possible to codegen this from the official bsky typescript)/

naively could grep out all the function names and then turn each of those into python

i think we could stand to think about the ergonomics of the python. right now, things are a tiny bit clunky because you get the response object back, which is ever so slightly unpoggers.

# for example,
    def resolveHandle(self,username): # aka getDid
        headers = {"Authorization": "Bearer " + self.ATP_AUTH_TOKEN}
        resp = requests.get(
            self.ATP_HOST + "/xrpc/com.atproto.identity.resolveHandle?handle={}".format(username),
            headers=headers
        )
        return resp

A cleaner API would look like something like:
class BskyResponse():
    # blah blah blah
    def __init__():
        self.response = None

def resolveHandle(self, username0:
    headers = #blahblahblah
    resp = requests.get(blahblahbla)
    rrrr = BskyResponse()
    rrrr.response = resp

It would also be cool if there were a decorator in front of each def that made it so we didn't need to put headers in every function manually.

I don't know if this fits what you're thinking, but @thearchduke was able to write a codegen script from the Lexicons in the ATProto repository to generate Ruby classes for each Lexicon. Something similar could probably work in Python

something like this? https://github.com/jbn/psychonaut/blob/main/psychonaut/lexicon/codegen.py

yeah! psychonaut's approach is super cool (codegen). i think it would be super cool / instructive / good learning to do that here too.


Add API examples.

A small jQuery app that can be used to test and play with the API.
On a web server looks like this: http://dashohoxha.fs.al/quran.com-frontend/api-examples/js/

Would be nice if this was decoupled from the fontend code. Maybe can live under the api.quran.com subdomain.

Usually it lives on the docs website (which can be on https://pages.github.com/).
In my project, it is on http://info.btranslator.org/api-examples-js/

Agree with @sabeurthabti about decoupling.

I agree too. You can create this project: https://github.com/quran/quran.github.io (the name of the project is quran.github.io), and place it there. Then it will be accessible from http://quran.github.io/api-examples/js/
This is a simple task that any beginner can do. But if you wish you can just create an empty project and give me access to it. I can give it a quick start, building something similar to: https://github.com/B-Translator/B-Translator.github.io Then every body (even a beginner) can try to improve its content and styles.
The webside http://quran.github.io/ will be like a homepage or information site for the projects related to https://github.com/quran/, and you need simple skills (HTML + CSS [+ JS +Jekyll]) to manage it, simple enough that any beginner can do.


Implement Sieve exercise

Tests are from the sieve.json file in xcommon
https://github.com/exercism/x-common/blob/master/sieve.json
Though I have re-ordered them to follow a path I thought better. Start
with no primes, then work up to the simplest results (1 and 2), then get
more complex.
In the config.json I've chosen to put this exercise before Allergies. I
picked this spot for two reasons:

It has some interesting iterator usage, which I thought step up after
doing iterator work in Anagrams, and the folding in Difference of
Squares.
I think Allergies comes too early. Or, maybe it just came too early
for me, as I found it baffling.

But I'm flexible on placement. Looking at the other tracks it doesn't
seem to have a consistent spot.

Test ordering seems good.

Ok. I've now implemented the real algorithm and learned something about the Sieve of Eratosthenes. First thing I learned -- if you have a function that checks if a number is prime, then you're doing it wrong.
I'm still on the fence about using a Sieve struct with a new function. Coming from Ruby that's my style, but it may not be idiomatic here.

Gonna think a bit about problem placement. Go and Ruby also have it relatively early. My initial instinct was to say "I think sieve might come too early", but I don't have a concrete reason for thinking that. I would say though that if allergies is too early, we could consider putting it later. Anyway, I'm not opposed to trying out sieve in this position and seeing what comes of it.
It would be great if we could get student feedback on problem ordering, but that is a separate discussion, one such as https://github.com/exercism/exercism.io/issues/1081

Oh, and regarding:

I'm still on the fence about using a Sieve struct with a new function. Coming from Ruby that's my style, but it may not be idiomatic here.

Ah, so you think it might just be better as a bare function primes_up_to or even an associated function Sieve::primes_up_to ? Possible. I have no strong opinion here so all seem acceptable.

Problem Placement
Maybe we should make an issue to review our problem ordering? I'd like to talk to @kytrinyx and other maintainers about this as well. My preference is to order the exercises in a way that teaches the language, but that's due to how I use exercism. Others do exercises in languages they already know, so their ordering needs are probably different.
API
I took a look at Primal, which seems to be the preferred prime crate for Rust. Based on its api, I think the Sieve::primes_up_to is more appropriate. I'll update the code.
Example
I'm never sure how good the example code needs to be. I do want it to be correct, and I also want it to be idiomatic (since I tend to use the example solutions as a reference for learning the language). I'm not sure what the correct idioms are here. The use of let seems right to me, though, so I'll get that change in.
Once everything is in and looks good, I'll squash all this down to a single commit.

My preference is to order the exercises in a way that teaches the language, but that's due to how I use exercism.

I think this is the ideal ordering. For people who already know the language, it doesn't hurt, and for people who don't it's incredibly helpful. For people who already know the language, they'll get whatever they get out of it, no matter what the ordering is.

I'm never sure how good the example code needs to be.

So far I've not cared too much about good code in the example; I think about it more as a thing that will test the test suite (just make sure that the test suite makes sense, and that it is solvable).

I say :+1: to this (one nit that you can fix, or not). I'll leave you to do the merge whenever you want, since you indicated you'd like to squash first.

My preference is to order the exercises in a way that teaches the language, but that's due to how I use exercism. Others do exercises in languages they already know, so their ordering needs are probably different.

I think the people who have the most different ordering needs may be those who don't know programming at all. One might reasonably say that this isn't too bad because the algorithm is laid out in the instuctions, but I think there's still a chance it will be a trying experience.
We can make a separate issue to review it. I think I had other things to say at some point but have forgotten them, so maybe some time will remind me of them. I don't currently feel like holding up this particular PR for it.

I'm never sure how good the example code needs to be.

My personal thought is that even though it doesn't necessarily need to use the best algorithm, it should at least be idiomatic for the target language, for whatever algorithm it does choose to use.
I do like how the while let cleaned up the code a lot.


Add the manager module

Will be supported below functions.

User creation.
-- Automatic add user's contact info.

Dialplan handle.
-- Need to support dialplan handle.

Done.


:=/= typo causes unexpected type conversion

Found this while attempting to do something else:
module body MutateVar is
    generic [R: Region]
    function mutate_int(var: &![Int32, R]): Unit is
        !var = 10; -- typo
        return nil;
    end;

    function main(): ExitCode is
        let x: Int32 := 5;
        printLn(x);

        mutate_int(&!x);
        printLn(x);

        return ExitSuccess();
    end;
end module body.

This unexpectedly compiles. The line !var = 10; has a typo, I meant to write :=.
The = is equality comparison, and the spec says both sides must be Bool. For this to compile, the integers on both sides must have been implicitly converted to Bool, which goes against the "no implicit type conversions anywhere" item on the antifeature list. So this seems like a bug.

EDIT wait no, what am I saying. The code should(?) compile. The bug is in the spec:

highlighted part, a and b can't just be boolean expressions.

Oh yeah the spec is wrong here.

Spec fixed here: https://github.com/austral/austral.github.io/pull/58

In the future, I should probably add a warning about non-function calls in a discarding expression, since those are clearly in error.


fix: resize not always working

The intersectObserver, used to determine if an element is visible, can contain multiple entries for the same target element. The last entry represents the last observed state, so we should use the last instead of the first for the visibility test.
See: https://github.com/spacetelescope/jdaviz/issues/2129

Nice, thanks!

meeseeksdev backport to master


Device Request - [Intelligent valve controller] - [PF-PM02D-TYZ]

Prerequisites:

Before requesting a device addition, please ensure there is not already a request for the device among the open issues.
Make sure your Homey is upgraded to firmware v5 or higher.
You need a physical example of the device

Device Name: MOES Intelligent valve controller
Device Model: PF-PM02D-TYZ /
Device Description: Water and gas valve
Link to device image: https://www.aliexpress.com/item/1005004275205561.html?spm=a2g0o.order_list.order_list_main.63.da991802uOnjKw
Device Interview:
I will provide when i can find the copy button... sorry have to figue out how first after i have started interview. Cant find any copy.
Additional Comments:
Shipped by MOES, here is also link to shop and manual.
https://drive.google.com/file/d/1nvfnlr1Xkk0rKPJpitycuw8FV-lCu_PB/view?spm=a2g0o.detail.1000023.7.9b72zeIazeIa6d&pli=1
https://www.aliexpress.com/item/1005004275205561.html?spm=a2g0o.order_list.order_list_main.63.da991802uOnjKw
How to interview a device:

Add the device as a generic Zigbee device in Homey
Navigate to https://developer.athom.com/tools/zigbee.
Interview the device, the button for this is to the right of the device in the list of Zigbee units.
Click the copy button/icon to capture the device information.
Paste the copied information above.

Note: To be able to add more devices to the Tuya Zigbee app, we rely on community members like you to provide interviews of the devices you want added. Thank you for your contribution!

Interview:
"ids": {
"modelId": "TS0601",
"manufacturerName": "_TZE200_d0ypnbvn"
},
"endpoints": {
"ieeeAddress": "a4:c1:38:1a:fa:f3:62:ef",
"networkAddress": 39740,
"modelId": "TS0601",
"manufacturerName": "_TZE200_d0ypnbvn",
"endpointDescriptors": [
{
"status": "SUCCESS",
"nwkAddrOfInterest": 39740,
"_reserved": 20,
"endpointId": 1,
"applicationProfileId": 260,
"applicationDeviceId": 81,
"applicationDeviceVersion": 0,
"_reserved1": 1,
"inputClusters": [
4,
5,
61184,
0
],
"outputClusters": [
25,
10
]
},
{
"status": "SUCCESS",
"nwkAddrOfInterest": 39740,
"_reserved": 10,
"endpointId": 242,
"applicationProfileId": 41440,
"applicationDeviceId": 97,
"applicationDeviceVersion": 0,
"_reserved1": 0,
"inputClusters": [],
"outputClusters": [
33
]
}
],
"deviceType": "router",
"receiveWhenIdle": true,
"capabilities": {
"alternatePANCoordinator": false,
"deviceType": true,
"powerSourceMains": true,
"receiveWhenIdle": true,
"security": false,
"allocateAddress": true
},
"extendedEndpointDescriptors": {
"1": {
"clusters": {
"groups": {
"attributes": [
{
"acl": [
"readable",
"reportable"
],
"id": 0,
"name": "nameSupport",
"value": {
"type": "Buffer",
"data": [
0
]
},
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
},
{
"acl": [
"readable",
"reportable"
],
"id": 65533,
"name": "clusterRevision",
"value": 2,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
}
]
},
"scenes": {
"attributes": [
{
"acl": [
"readable",
"reportable"
],
"id": 0,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
},
{
"acl": [
"readable",
"reportable"
],
"id": 1,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
},
{
"acl": [
"readable",
"reportable"
],
"id": 2,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
},
{
"acl": [
"readable",
"reportable"
],
"id": 3,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
},
{
"acl": [
"readable",
"reportable"
],
"id": 4,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
},
{
"acl": [
"readable",
"reportable"
],
"id": 65533,
"name": "clusterRevision",
"value": 2,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
}
]
},
"basic": {
"attributes": [
{
"acl": [
"readable",
"reportable"
],
"id": 0,
"name": "zclVersion",
"value": 3
},
{
"acl": [
"readable",
"reportable"
],
"id": 1,
"name": "appVersion",
"value": 70
},
{
"acl": [
"readable",
"reportable"
],
"id": 2,
"name": "stackVersion",
"value": 0
},
{
"acl": [
"readable",
"reportable"
],
"id": 3,
"name": "hwVersion",
"value": 1
},
{
"acl": [
"readable",
"reportable"
],
"id": 4,
"name": "manufacturerName",
"value": "_TZE200_d0ypnbvn"
},
{
"acl": [
"readable",
"reportable"
],
"id": 5,
"name": "modelId",
"value": "TS0601"
},
{
"acl": [
"readable",
"reportable"
],
"id": 6,
"name": "dateCode",
"value": ""
},
{
"acl": [
"readable",
"reportable"
],
"id": 7,
"name": "powerSource",
"value": "mains"
},
{
"acl": [
"readable",
"writable",
"reportable"
],
"id": 65502
},
{
"acl": [
"readable",
"reportable"
],
"id": 65533,
"name": "clusterRevision",
"value": 2
},
{
"acl": [
"readable",
"reportable"
],
"id": 65534,
"name": "attributeReportingStatus",
"value": "PENDING"
},
{
"acl": [
"readable",
"reportable"
],
"id": 65506
},
{
"acl": [
"readable",
"reportable"
],
"id": 65507
}
]
}
},
"bindings": {
"ota": {},
"time": {
"attributes": [
{
"acl": [
"readable"
],
"id": 65533,
"name": "clusterRevision",
"value": 1
}
]
}
}
},
"242": {
"clusters": {},
"bindings": {}
}
}
}

Thanks in advanced, you are doing an amazing job so far!