Failed to initialize GLAD

Describe the bug
When running video generation for nature scenes, it crashes with error "Failed to initialize GLAD" in opengl log. I have compiled opengl with no error, and also can run HelloWorld(single frame) using opengl_gt.
Steps to Reproduce
What version of the code were you using?
v1.11.2
What command did you run?
python -m infinigen.datagen.manage_jobs --output_folder outputs/video_smooth_nature --num_scenes 1 --pipeline_config monocular_video.gin local_128GB.gin cuda_terrain.gin opengl_gt.gin --configs high_quality_terrain --pipeline_overrides iterate_scene_tasks.cam_block_size=24

What are your FULL output logs?
crash_summaries:
outputs/video_smooth_nature/61e42671/logs/opengl_0_0_0001_0.err reason='Could not summarize cause, check outputs/video_smooth_nature/61e42671/logs/opengl_0_0_0001_0.err' node=None fatal=True

opengl_0_0_0025_0.err:
Failed to initialize GLAD

And there's nothing in opengl_0_0_0025_0.out

Fixed after adding display device


Signal "pressed" and "released" from TouchScreenButton seems not always working

Godot version:
3.0.6,  v3.1.dev.calinou.3f01f40
OS/device including version:

Windows 10 1709(HD 4000), Linux Mint Mate 19(HD 3000)
Issue description:

When I try click several times on the screen, TouchScreenButton not always send signal "pressed" and "released" when I realease button.
When I press Space key(alternative method to jump), Player always jump.
Steps to reproduce:

Set to true  Project Settings -> Input Devices -> Pointing -> emulate_touch_from_mouse
Run Scene/Game
Click fast several times(it is the most visible when click three times) to screen and see that some "pressed" signals are not recorded/send(print via Output) and Player still fall down.

Minimal reproduction project:

Color Changer.zip

#20081 should fix this

It is fixed now.


generate JS client from QA swagger spec

will meet with some subset of @ndushay, @SaravShah, @jgreben, @atz, and @jermnelson to intro swagger-codegen, and to try and generate a JavaScript client from https://lookup.ld4l.org/qa/apidoc/apidoc.json (which may involve some debugging, if swagger-codegen doesn't think that particular spec conforms to the OpenAPI spec).

issue was moved

Fixed by #241


Feature: Implemented Loader Component

Loader component implemented with styling and functionality in storybook.

@Peudey seriously this is great work. I have a couple of recommendations:

The inverted prop is for dark backgrounds. Could you make this text appear and loading icon to be white instead?
This is nitpicking... Can you make the default text a capital L "Loading"?

Just those 2 changes and I'll mark this as done!

@Peudey can you make the inverted border #333 instead of #c7c7c7? Adds more contrast to the spinning border.

@Peudey can you make the inverted border #333 instead of #c7c7c7? Adds more contrast to the spinning border.

@KevinThePepper Easy enough, just pushed that change!


New Sheet Stargate Coalition & Update Psi*run

Add new sheet for Stargate Coalition.
https://www.no-xice.com/projet/stargate-coalition/
Update sheet Psi*run.
Thanks.

The best option for image linking is to upload these images to Git under the sheet they are being used by. If you make another PR with the images included, I'll merge it, and then you can make a 2nd PR to link to the images directly on GitHub (you can link to the RAW version on GitHub, see the Official 5e sheet for examples). This way, you don't have to worry about a 3rd party randomly removing images your sheets rely on.


Add timeout to the linter

This should fix the broken build in the main branch.

It's probably something else. It's likely that it's something related to the new deps. I didn't want to spend too much time on this though.


Update this extension to support manifest 3 for google chrome new versions

New Issue Checklist (tick off like this: [x])

[x ] I checked existing issues (open and closed) for possible duplicates
[ ] I can reproduce the problem on the latest stable version (not nightly!)
[ ] If you have a problem with a specific website: adding the domain to your no-skip-urls-list does not solve the problem
[ ] The issue is not about adding entries to the default no-skip-urls-list

What is your browser?

[ ] Firefox
[x ] Chrome

What is your operating system?

[ ] Linux
[ ] Mac
[x ] Windows

Description (please include examples/screenshots where applicable)
Hi, Can you update this extension to support manifest 3 for chrome new versions?

No, it's not possible, they removed the API that is required. There is no alternative.


Limit several project settings

As seen in https://github.com/godotengine/godot/issues/21795 , we need to limit some project settings.
I will be adding more limited settings later this week, but I'm opening this PR early for reviewing of the values I'm using.
Fixes https://github.com/godotengine/godot/issues/21795

Looks fine so far.

Good, now I pushed the last batch of limited settings, please tell me if they're ok to squash for merging.

Does this PR fixes all ranges that need to be limited in the Project Setting? If so, I'd consider assigning 	#21795 to @Superwaitsum.

@gcardozo123 this PR fixes all ranges needed, but I think assigning only works on members of the organization, so I can't be assigned.

Looks all good to me, once squashed I'll merge.

@akien-mga Squashed and ready to merge

Thanks!


MonacoEditorReactComp not fires onTextChanged callback if you change code resource

I try to use @typefox/monaco-editor-react with multiple files, but only for first file callback onTextChanged fired.
Repro repo: https://github.com/lobotomoe/monaco-on-text-changed-issue
Steps for repro:

git clone
npm i
npm run dev

Try to type something and you will see in console that onTextChanged fired. Switch to second file. Try to type — nothing happens. Switch back to first file, try to type — callback fires.
See video demo:
https://github.com/TypeFox/monaco-languageclient/assets/24254622/db412849-45a4-475b-a38c-a141079c65a7

HI @lobotomoe thank you for reporting this and providing a re-producible example. We will investigate...

@lobotomoe the file changes are not provoking componentDidUpdate in MonacoEditorReact . The whole evaluation internally is based on UserConfig comparison which decides if the underlying wrapper/editor needs to be restart or just reconfigured.
But there is no simple trigger. Currently, you can create a ref to -MonacoEditorReactComp and then trigger the update directly on the underlying wrapper.
Maybe we should add a boolean property to the MonacoEditorProps, so they can easily trigger a re-evaluation of the status?

@kaisalmen Thanks for the answer! I'm not sure if it's worth bothering so much purely because of my case, but I don't mind if there's a flag 😀
Currently I'll try your approach with ref and manual trigger

@lobotomoe we want to transform the ClassComponent to a FunctionalComponent and when we will do it think about this use case.
Another possibility I forgot about is that onLoad() gives you the wrapper and when you have that you can do everything, see: https://github.com/TypeFox/monaco-languageclient/blob/main/packages/examples/src/python/client/reactPython.tsx#L44-L46

@lobotomoe #739 is merged, but not yet released. It will take some time because it will be a major version and there are other things that should be included as well.
I will take a look if we can build a unit test for this problem now...

@lobotomoe can you try the latest preview build<EMAIL_ADDRESS>?


Create my.txt

@2841liuhai I have to close this request without merging, because you requested to add a non-existent domain to this repository: Host my.gavlian.edu not found: 3(NXDOMAIN) Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for understanding!


Pics not visible > 768 breakpoint - issue 137

https://main--ororafresh--hlxsites.hlx.live/produce-packaging-solutions

Taken care via - https://github.com/hlxsites/ororafresh/pull/138
Please check & validate further - @paolomoz . Ty again.

@meejain , change looks good... I was going through the rest of the pages, it looks like we may be missing another image on this page:
https://pics-not-visible-issue-136v1--ororafresh--hlxsites.hlx.live/produce-packaging-automation
Franklin Site:

Live Site:

@mtilburgadobe  - Please check now - https://pics-not-visible-issue-136v1--ororafresh--hlxsites.hlx.live/produce-packaging-automation


If image fails to open we should show a visible error in the viewer

🐛 Bug

I think this is more of a "user experience" bug, rather than a technical problem. If you try to open an unsupported image type in napari & all plugins fail, I'd like to see a visible error message in the viewer.
Right now, the only places the error message is visible is the terminal napari was launched from (which we can't rely on users being able to see now we're bundling apps), and also in the plugin errors GUI (which takes three different clicks to open, assuming you know it exists and where to look for it).
To Reproduce
Steps to reproduce the behavior:

Open napari
Attempt to drag and drop an unsupported image type into napari, or using File > Open
Eg: Drag and drop the example file toxo.dv, if you don't have napari-dv or another plugin that handles deltavision files installed)
Observe the image failing to open, and there is no visible clue about why in either the napari viewer or integrated ipython console.

There is an error message printed in the terminal napari was launched from.
You can also find the error message buried in the plugins error GUI, but even if you know it's there it still takes three clicks to open - so not exactly low-effort.
Plugins > Plugin errors, then change the dropdown from "select a plugin" to "builtins".

Additional context

I know as a general rule we want to be anti-popup, which is a good thing. But I think image opening is important enough that we should have some visible way to tell users (1) something went wrong, and (2) you should try installing another plugin to fix it.

#794 was a proposal to handle this sort of thing in a general way (I.e. without having to specifically create a pop up for each error case).  Maybe people want to weigh in on that proposal again?

We now have an error message that shows up in the viewer when user tries to open an unsupported filetype:

So should this issue be closed?
That's not to say that this workflow cannot be improved, e.g. to eventually suggest plugins that can open the file as I think @tlambert03 has brought up in a different issue (or perhaps in the meantime link to hub with search prepopulated with the name fo the filetype or extension). I make a separate design issue for improving the experience.

yep, can close, thanks!


PowerShell class static method has inconsistent behavior when the .ps1 file is dot sourced into multiple Runspace's

Root cause
Here is the background information:

When running the same unchanged script file multiple times, the script file will not be re-parsed. Instead, the AST will be used.
When re-using the AST, we will reuse the same .NET type generated for a powershell class.
At compilation time, ScriptBlockMemberMethodWrapper.InitAtRuntime will be called to bound the static method of a powershell class to the [Runspace, SessionState] where the compilation is happening.

This causes a problem -- a static method of powershell class will always execute in the [Runspace, SessionState] where the script file that defines it lastly run.
Steps to reproduce

class.ps1 -- defines a powershell class Foo

class Foo
{
    static [string] GetName()
    {
        return (Get-Name)
    }
}

test.ps1
Dot source class.ps1, create function Get-Name and run [Foo]::GetName().
Then create a new runspace, define another Get-Name and dot source class.ps1 in that runspace.
Then run [Foo]::GetName() again.

. $PSScriptRoot\class.ps1

function Get-Name
{
    "Console Runspace"
}

[Foo]::GetName()

$ps = [powershell]::Create()
$ps.AddScript("function Get-Name { 'powershell instance Runspace' }").Invoke()
$ps.Commands.Clear()
$ps.AddScript(". $PSScriptRoot\class.ps1").Invoke()

[Foo]::GetName()

Then just run test.ps1 in powershell

.\test.ps1

Expected behavior

Since I'm running both [Foo]::GetName() in the default console runspace, I expect the same result.

Console Runspace
Console Runspace

Actual behavior
Console Runspace
powershell instance Runspace

Environment data

> $PSVersionTable
Name                           Value
----                           -----
PSVersion                      6.0.0-beta
PSEdition                      Core
CLRVersion
GitCommitId                    v6.0.0-beta.2-22-g7a51b446e5cc428efd634e8a8a38271156cc182b
OS                             Microsoft Windows 10.0.15063
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

I had a conversation with @BrucePay about this issue.
Currently both instance methods and static methods of a PowerShell class are bound to a [Runspace, SessionState] by default, and the execution of the methods will happen in that environment.
This makes PowerShell class not friendly to concurrent execution in PowerShell (via RunspacePool or multiple Runspaces), because if when calls to the methods are not in the bound [Runspace, SessionState], they will be sent there to run instead of running in the current Runspace.
Maybe a better semantics is:
When calling instance/static methods, if the current thread that makes the call has a default Runspace associated with it, then the methods runs in that Runspace; if the current thread doesn't have a default Runspace associated with it, then the bound [Runspace, SessionState] will be used to run the methods.

I think it's worth revisiting how we bind script blocks to session state.
In my mind, the current implementation is meant to simulate early binding primarily for script blocks in module scope. I'm not sure the current implementation is useful elsewhere.
I'd also like to avoid semantics that apply to class methods because the problem is broader than that. For example, invoking a script block in a background runspace doesn't always work like people expect.

While experimenting with this I found a related bug where the engine event mechanism used to marshal a script block back to the original runspace/session state doesn't work.  The result is running the script block on a different runspace/thread and corrupted state errors ("index out of range", "global scope cannot be removed", etc.).
https://github.com/PowerShell/PowerShell/issues/4003


Implement Debug for ErrorChainIter #169.

Could you update the changelog?

Done.

Thanks! I modified the commit message to close the associated issue.


Windows 2016 - Boot Bluescreen

Hello,
Working to make a Win 2016 server standard (desktop experience) instance on OS.  After uploading the vhd and creating an instance I get multiple BSOD like thi.s

After a couple of tries, Windows wants to be repaired.
I have a suspicion that it is related to some files that are not found during the New-WindowsCloudImage commandlet work.

The image created opened in virtual box quite nicely and did all the firstlogin, and login tasks and shutdown.  But after uploading the resulting vhd to OpenStack, it doesn't start well.

more info.
virtio-win-0.1.126
Mirantis 8.0 - openstack liberty.

If the target hardware differs from the hardware where you generated the image, you need to set in C:\Windows\Panther\unattend. xml,  in the generalize section, PersistDriversInstall to False.
Thanks,
Adrian Vladu

Moreover, please use the latest code and documentation, from the two currently opened PRs (63, 71). you can find there improved code and updated documentation. Thanks.

I just pulled the latest commit.  I get the following error importing the module winimagebuilder.psm1.
At D:\win2016\windows-openstack-imaging-tools\WinImageBuilder.psm1:1044 char:44

            $xmlParams.Add('productKey' = '$ProductKey');

As much as line 1044 looks good to me, if i comment it out (because I'm not using the product key at this time), I can import the module without powershell being angry.  I'm currently using powershell on windows 10. (v 5.1.14393.206)
Would line 1044 be better as this?
                $xmlParams.Add(@{'productKey' = '$ProductKey'});
Also..
Based on the options specified in the examples on the create-windows-clout-image.ps1.  I get an error New-WindowsCloudImage : A parameter cannot be found that matches parameter name 'PersistDriversInstall'.  If i remove that option, I then get New-WindowsCloudImage : A parameter cannot be found that matches parameter name 'ImageArchitecture'.   But there is no option for that in the New-WindowsCloudImage commandlet.
I seem to be way off base.
Any help would be appreciated.
Thanks in advance.

Hello,
the fixes will be soon merged: https://github.com/cloudbase/windows-openstack-imaging-tools/pull/74
Thanks, Adrian Vladu

I got them, and am trying them now.  I'll report findings.

Hello,
I have same problem for windows 2016.  i created windows 2016 image by using create-windows-online-cloud-image.ps1. When i imported my image to virt-manager and hpe hellion openstack, i encounter the same error.
However, i didn't have any problem for windows 2012.
Thanks.

I have created a windows 2016 core image and I did not get any boot errors on KVM. Can you give more details on the environment you are working with and the imaging tools logs?
Thank you,
Adrian Vladu

windows host: windows 2010
virtio: virtio-win-0.1.126.iso
OS iso: SW_DVD9_Win_Svr_STD_Core_and_DataCtr_Core_2016_64Bit_English_-2_MLF_X21-22843.ISO (download on microsoft partner site)
KVM: libvirt on  ubuntu 14.04
I attached imaging tools log for windows 2016 and windows 2012, and screenshot
windows2016_output.txt
windows2012_output.txt

@gulseren can you try this fix? http://ask.cloudbase.it/question/1227/nano-server-wont-boot/
Windows 10 /2016 requires two more cpu features in order to boot on KVM. By default, kvm does not expose those features.
Thanks,
Adrian Vladu

I also made a PR to support the new virtio drivers for 2016/win10: https://github.com/cloudbase/windows-openstack-imaging-tools/pull/77
Can you try with this PR?
Thanks,
Adrian Vladu

Still no luck.  Exact same results with the blue screen on boot.  I'm suspecting compatibility with win16 and ovirt or cloudbase init.
This is my command to make the image.
New-WindowsCloudImage -WimFilePath $wimFilePath -ImageName $image.ImageName     -VirtualDiskPath $virtualDiskPath -SizeBytes 30GB
-VirtualDiskFormat 'VHD' -DiskLayout 'BIOS' -VirtioISOPath $virtIOISOPath      -InstallUpdates:$false -PersistDriverInstall:$false
-AdministratorPassword 'Pa$$w0rd' -InstallMAASHooks:$false `
-PurgeUpdates:$true -DisableSwap:$true
I had very similar errors on the image creation as @gulseren.  Seems like that has to be the best clue as to what is going on.
I pulled #77 and tried it again, but the same errors cropped up on image creation.
Even though it completed the image (it usually does), and virtual box booted, and syspreped, the image behaves badly when uploaded.
This error happens on boot with windows.

It definitely looks like a hypervisor boot issue -- can you try with this command to spawn up an instance on KVM?
Centos7 version:
/usr/libexec/qemu-kvm --name test -m 2048  <path_to_qcow2> -vga std -k en-us -vnc :2  -machine pc-i440fx-rhel7.2.0,accel=kvm,usb=off -cpu host -realtime mlock=off -smp 4,sockets=4,cores=1,threads=1 -uuid 5812b596-a731-43a0-8aa7-f16cd91e1ae9 -smbios type=1
Ubuntu 14.04 version
qemu-system-x86_64 -m 2048  <path_to_qcow2> -vga std -k en-us -vnc :2  -machine pc,accel=kvm,usb=off -cpu host -realtime mlock=off -smp 4,sockets=4,cores=1,threads=1 -smbios type=1
If it doesn't work, can you provide the output of ps ax|grep kvm?
Thank you,
Adrian Vladu

Hello Adrian,
I tried this command and it is working.
qemu-system-x86_64 -m 2048 <path_to_qcow2> -vga std -k en-us -machine pc,accel=kvm,usb=off -cpu host -realtime mlock=off -smp 4,sockets=4,cores=1,threads=1 -smbios type=1
But, i still get boot error on HPE Hellion Openstack. How can i upload this image on HPE Hellion Openstack?
Thank you,

@gulseren, I think you need to check with the Helion OpenStack support in order to present the issues you are getting and if they support Server 2016.

Sorry I was distracted from this for a while.
My image runs on KVM.  But after I upload to openstack, it fails with this error again.

@nmcclenahan can you send a ps aux|grep kvm output from the nova compute node for further debugging? Thanks.

libvirt+ 10686 99.6  0.4 8837604 306312 ?      Sl   21:11  17:31 qemu-system-x86_64 -enable-kvm -name instance-0000084f -S -machine pc-i440fx-trusty,accel=kvm,usb=off -cpu Penryn,+dca,+pdcm,+xtpr,+tm2,+est,+vmx,+ds_cpl,+monitor,+dtes64,+pbe,+tm,+ht,+ss,+acpi,+ds,+vme -m 4000 -realtime mlock=off -smp 1,sockets=1,cores=1,threads=1 -uuid 2600b3d7-8e4e-4542-8fbe-b2737ae9a90a -smbios type=1,manufacturer=OpenStack Foundation,product=OpenStack Nova,version=12.0.0,serial=acd312e6-0faa-4158-a160-e92d703c58b9,uuid=2600b3d7-8e4e-4542-8fbe-b2737ae9a90a,family=Virtual Machine -no-user-config -nodefaults -chardev socket,id=charmonitor,path=/var/lib/libvirt/qemu/instance-0000084f.monitor,server,nowait -mon chardev=charmonitor,id=monitor,mode=control -rtc base=utc,driftfix=slew -global kvm-pit.lost_tick_policy=discard -no-hpet -no-shutdown -boot strict=on -device piix3-usb-uhci,id=usb,bus=pci.0,addr=0x1.0x2 -drive file=rbd:volumes/volume-82116c5a-5843-40fa-b163-49601a279709:id=compute:key=AQDcECRXBQOPKRAAmBCKO+xt85eI6qq92CTyrg==:auth_supported=cephx;none:mon_host=<IP_ADDRESS>:6789;<IP_ADDRESS>:6789;<IP_ADDRESS>:6789;<IP_ADDRESS>:6789;<IP_ADDRESS>:6789;<IP_ADDRESS>:6789,if=none,id=drive-virtio-disk0,format=raw,serial=82116c5a-5843-40fa-b163-49601a279709,cache=writeback -device virtio-blk-pci,scsi=off,bus=pci.0,addr=0x4,drive=drive-virtio-disk0,id=virtio-disk0,bootindex=1 -netdev tap,fd=27,id=hostnet0,vhost=on,vhostfd=43 -device virtio-net-pci,netdev=hostnet0,id=net0,mac=fa:16:3e:79:b8:f1,bus=pci.0,addr=0x3 -chardev file,id=charserial0,path=/var/lib/nova/instances/2600b3d7-8e4e-4542-8fbe-b2737ae9a90a/console.log -device isa-serial,chardev=charserial0,id=serial0 -chardev pty,id=charserial1 -device isa-serial,chardev=charserial1,id=serial1 -device usb-tablet,id=input0 -vnc <IP_ADDRESS>:15 -k en-us -device cirrus-vga,id=video0,bus=pci.0,addr=0x2 -device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x5 -msg timestamp=on

@nmcclenahan Please check https://ask.cloudbase.it/question/1125/problem-booting-from-the-windows-2012-r2-image/ and try to use another cpu model, like host-passthrough or make sure the required windows cpu flags are exposed by kvm.

we already have host-passthrough configured...
see nova.conf
[libvirt]
inject_partition=-2
inject_password=False
disk_cachemodes="network=writeback,block=none"
cpu_mode=host-model
libvirt_inject_password=True
virt_type=kvm
libvirt_inject_key=True
inject_key=False
block_migration_flag=VIR_MIGRATE_UNDEFINE_SOURCE,VIR_MIGRATE_PEER2PEER,VIR_MIGRATE_LIVE,VIR_MIGRATE_NON_SHARED_INC
live_migration_flag=VIR_MIGRATE_UNDEFINE_SOURCE,VIR_MIGRATE_PEER2PEER,VIR_MIGRATE_LIVE,VIR_MIGRATE_PERSIST_DEST
vif_driver=nova.virt.libvirt.vif.LibvirtGenericVIFDriver
images_rbd_pool=compute
images_type=rbd
rbd_secret_uuid=a5d0dd94-57c4-ae55-ffe0-7e3732a24455
rbd_user=compute

@nmcclenahan can you try with cpu_mode=host-passthrough ? the exposed penryn cpu flags are quite interesting. You can try also with an older virtio iso version, like https://fedorapeople.org/groups/virt/virtio-win/deprecated-isos/archives/virtio-win-0.1-52/ . Let me know if it fixes the issues you have.

I tried to make a Windows Server image 2016 with Windows Server 2012 everything works.

PS C:\Users\Administrator\Downloads\windows-openstack-imaging-tools\Examples> .\create-windows-cloud-image.ps1
WARNING: .\config.ini exists and it will be rewritten.
Image generation started at: 6/1/2017 11:06:38 AM
WARNING: The installed version of DISM is older than the Windows image
Copying: C:\Users\Administrator\Downloads\windows-openstack-imaging-tools\UnattendResources F:\UnattendResources
Downloading Cloudbase-Init...
Applying Windows image "D:\Sources\install.wim" in "F:\"

Deployment Image Servicing and Management tool
Version: 6.3.9600.17031

Applying image
[==========================100.0%==========================]
The operation completed successfully.
BFSVC: ServiceBootFiles MuiOnly:n Res:y Fonts:y BootMgrOvw:nBootStatOvw:n DbgTransports:y CreateSetupObj:n
BFSVC: Using source OS version a000038390000
BFSVC: Copying boot files CopyBootManager(Yes) F:\windows\boot\PCAT -> \\?\GLOBALROOT\Device\HarddiskVolume9\Boot
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\bg-BG\bootmgr.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\bootmgr for read because the file or path does not
 exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\bootvhd.dll for read because the file or path does
 not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\cs-CZ\bootmgr.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\cs-CZ\memtest.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\da-DK\bootmgr.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\da-DK\memtest.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\de-DE\bootmgr.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\de-DE\memtest.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\el-GR\bootmgr.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\el-GR\memtest.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\en-GB\bootmgr.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\en-US\bootmgr.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\en-US\memtest.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\es-ES\bootmgr.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\es-ES\memtest.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\es-MX\bootmgr.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\et-EE\bootmgr.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\fi-FI\bootmgr.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\fi-FI\memtest.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\fr-CA\bootmgr.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\fr-FR\bootmgr.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\fr-FR\memtest.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\hr-HR\bootmgr.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\hu-HU\bootmgr.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\hu-HU\memtest.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\it-IT\bootmgr.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\it-IT\memtest.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\ja-JP\bootmgr.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\ja-JP\memtest.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\ko-KR\bootmgr.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\ko-KR\memtest.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\lt-LT\bootmgr.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\lv-LV\bootmgr.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\memtest.exe for read because the file or path does
 not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\nb-NO\bootmgr.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\nb-NO\memtest.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\nl-NL\bootmgr.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\nl-NL\memtest.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\pl-PL\bootmgr.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\pl-PL\memtest.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\pt-BR\bootmgr.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\pt-BR\memtest.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\pt-PT\bootmgr.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\pt-PT\memtest.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\qps-ploc\bootmgr.exe.mui for read because the file
 or path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\qps-ploc\memtest.exe.mui for read because the file
 or path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\ro-RO\bootmgr.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\ru-RU\bootmgr.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\ru-RU\memtest.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\sk-SK\bootmgr.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\sl-SI\bootmgr.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\sr-Latn-CS\bootmgr.exe.mui for read because the fi
le or path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\sr-Latn-CS\memtest.exe.mui for read because the fi
le or path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\sr-Latn-RS\bootmgr.exe.mui for read because the fi
le or path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\sv-SE\bootmgr.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\sv-SE\memtest.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\tr-TR\bootmgr.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\tr-TR\memtest.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\uk-UA\bootmgr.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\zh-CN\bootmgr.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\zh-CN\memtest.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\zh-HK\bootmgr.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\zh-HK\memtest.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\zh-TW\bootmgr.exe.mui for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\zh-TW\memtest.exe.mui for read because the file or
 path does not exist
BFSVC: GetFileAttributes(\\?\GLOBALROOT\Device\HarddiskVolume9\Boot\BCD) failed: File not found.
BFSVC: GetFileAttributes(\\?\GLOBALROOT\Device\HarddiskVolume9\Boot\BCD.LOG) failed: File not found.
BFSVC: Copying font files from F:\windows\boot\Fonts to \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\Fonts...
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Copying resource files from F:\windows\boot\Resources to \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\Resources...
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\Resources\bootres.dll for read because the file or
 path does not exist
BFSVC: SetNamedSecurityInfo failed! Error code = 0x2
BFSVC: Unable to open file \\?\GLOBALROOT\Device\HarddiskVolume9\Boot\Resources\en-US\bootres.dll.mui for read because t
he file or path does not exist
BFSVC: Servicing debugger files
BFSVC: List of debugger files is empty
BFSVC: BfsInitializeBcdStore flags(0x0000021c) RetainElementData:n DelExistinObject:n
BFSVC: VolumePathName for F:\windows is F:\
BFSVC: Opening template from \Device\HarddiskVolume9\windows\System32\config\BCD-Template.
BFSVC: Opening store from \Device\HarddiskVolume9\boot\BCD
BFSVC: System BCD store does not exist, creating.
BFSVC: Creating General objects.
BFSVC: Creating Resume object.
BFSVC: Creating MemTest object.
BFSVC: Creating OsLoader object.
BFSVC: OsLoader identifier: {73794f71-46bb-11e7-80ba-942b4ee825a4}
BFSVC: Removing duplicate entries.
BFSVC: Create BOOTMGR object RetainBootDefault:n
BFSVC: Setting {default} to {73794f71-46bb-11e7-80ba-942b4ee825a4}
BFSVC: Cleaning up debugger settings.
Boot files successfully created.
WARNING: BCDEdit failed: bootmgr device locate
WARNING: BCDEdit failed: default device locate
WARNING: BCDEdit failed: default osdevice locate
Adding drivers from G:
Adding drivers from "G:\balloon\2k16\AMD64" to image "F:\"

Deployment Image Servicing and Management tool
Version: 6.3.9600.17031

Error: 50

To service this Windows image requires the latest version of the DISM. See http://go.microsoft.com/fwlink/?LinkId=293395
 to find the latest version of DISM,
and http://go.microsoft.com/fwlink/?LinkId=293394 to learn how to install the latest version of DISM from the ADK on you
r computer.

The DISM log file can be found at C:\windows\Logs\DISM\dism.log
Dism failed to add drivers from: G:\balloon\2k16\AMD64
Converting virtual disk image from C:\Users\Administrator\Downloads\Windows-2016.vhd to C:\Users\Administrator\Downloads
\Windows-2016.qcow2...

Also have error with blue screen

For me helped inserting this line to /etc/modprobe.d/kvm.conf
options kvm ignore_msrs=1

Marking it as resolved.


onWrite: drain source buffer on connection close

Commit Message:
fixes: #26994
If downstream connection is closed, drain source buffer.
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Probably needs a test.

Thanks for fixing it, but please add a regression test!

/wait-any

The fix looks reasonable to harden the codec - but I don't follow how it fixes the extension that closes the stream on the response?

The fix looks reasonable to harden the codec - but I don't follow how it fixes the extension that closes the stream on the response?

assertion failure happens in flushOutput. Assertion expects that after connection().write(*output_buffer_, false);, output_buffer_->length() is 0. If connection is closed, write returns early without draining the buffer and hence the assertion failure.
In the first commit of this PR, I did this draining in write to fix the issue. @soulxu then suggested alternative to return even earlier and skip flushOutput altogether if connection is closed. Hence, fixing the issue.

I think this is a useful fix. Please update the description and PR title.

done

Need senior maintainer +1 as well for codec code. Assigned to Yan.

@yanavlasov would you like to take a look at this? thanks!

@yanavlasov ping

@alyssawilk @yanavlasov ping

@yanavlasov PTAL

@vikaschoudhary16 wondering if this should have a changelog entry

Hmmmm, I have taken a look. Seems the bug is caused by that the filter chain still continue and try to send reply after the whole stream is closed.
Ideally, we should always stop the filter chain after call the resetStream but current implementation doesn't do that. The correct fix should be set the encoder_filter_chain_aborted_/decoder_filter_chain_aborted_ to true when the resetStream is called.
I have no 100% confidence to this conclusion but will give it a try first.

Hmmmm, I have taken a look. Seems the bug is caused by that the filter chain still continue and try to send reply after the whole stream is closed.
Ideally, we should always stop the filter chain after call the resetStream but current implementation doesn't do that. The correct fix should be set the encoder_filter_chain_aborted_/decoder_filter_chain_aborted_ to true when the resetStream is called.
I have no 100% confidence to this conclusion but will give it a try first.
A possible fix is pushed, see #31775 Although this patch also harmless, I am inclined to leave the flushOutput as that. It would be helpful to help us find other actual logic issues.

@wbpcode Yeah with your change execution is returning even earlier so should avoid the reported assertion failure.
As @kyessenov mentioned that this change will help hardening codec, I have updated the change logs and leave to the community to decide on including it or not.

This appears to currently be waiting for @yanavlasov , but hasn't heard a peep ever, in a month of being assigned. @alyssawilk ?

This PR can be closed in favor of #31775


perf (NormedSpace.OperatorNorm): remove timeout by explicitly writing rewrite sequence

We change a tactic combinator of rw calls into an explicit chain to remove a hearbeat bump.

!bench

!bench

I found the declarations that need to reducible to avoid simp[(X)]. This PR depends on those now.

!bench


D2Data and Quest data

Fetch skill data from https://github.com/blizzhackers/d2data and read game quest status from game memory

the quests seem to be wrong (in their order) and flags too.. I had a quick look with a new character and watched the progression of flags changing and some of them are wrong too, however the memory region part works well and the u16 changes as the quest progresses, I did not see the u16 change when talking to npc for final reward.
I think unknown2 was triggered on quest discover?
If I find more time to examine this after other things are done I can post a new issue.
This is all for the leveling bit, I was only testing this for completeness finding useful pointers, the pattern for this is
pattern = "83 c4 20 5f c3 8b 63 ae 58 5c 3f 2a 19 48 8b 05"
offset = (patternaddr + 0x10).readuint32()
baseaddr + patternoffset + 0xc + offset

type QuestStatus struct {
	StatusRewardGranted           bool
	StatusRewardPending           bool
	StatusQuestInitiated          bool
	StatusLeaveTown               bool
	StatusEnterFirstArea          bool
	StatusInProgress1             bool
	StatusInProgress2             bool
	StatusInProgress3             bool
	StatusInProgress4             bool
	StatusInProgress5             bool
	StatusInProgress6             bool
	StatusInProgress7             bool
	StatusUpdateQuestLogCompleted bool
	StatusPrimaryGoalCompleted    bool
	StatusUnknown1                bool
	StatusUnknown2                bool // StatusDiscovered ?
	StatusDiscovered              bool
	States                        []int
}

func DecomposeQuestFlags(questStatusU16 uint16) QuestStatus {
	status := QuestStatus{}

	for i := 0; i < 16; i++ {
		if questStatusU16&(1<<(15-i)) != 0 {
			status.States = append(status.States, i)
			switch i {
			case 0:
				status.StatusRewardGranted = true
			case 1:
				status.StatusRewardPending = true
			case 2:
				status.StatusQuestInitiated = true
			case 3:
				status.StatusLeaveTown = true
			case 4:
				status.StatusEnterFirstArea = true
			case 5:
				status.StatusInProgress1 = true
			case 6:
				status.StatusInProgress2 = true
			case 7:
				status.StatusInProgress3 = true
			case 8:
				status.StatusInProgress4 = true
			case 9:
				status.StatusInProgress5 = true
			case 10:
				status.StatusInProgress6 = true
			case 11:
				status.StatusInProgress7 = true
			case 12:
				status.StatusUpdateQuestLogCompleted = true
			case 13:
				status.StatusPrimaryGoalCompleted = true
			case 14:
				status.StatusUnknown1 = true
			case 15:
				status.StatusUnknown2 = true
			}
		}
	}

	return status
}


fix(openchallenges): expore Location.replaceState() to fix scrolling issue

Closes #2154
Description
Explore an alternative solution to #2189 that may be simpler.

Angular's Location service should be used when interacting with the browser's URL and not for routing. Thats why we want to use Location service.

Source
References

https://angular.io/api/common/Location#replaceState

@rrchai I was wondering whether there was a simpler solution to the scrolling issue. I may have found one (see above). It seems that the existing code relies on on page navigation to trigger new searches. A more performant approach aligned with this PR would be to trigger queries when the object this.query changes.

@tschaffter  Thanks for the initial exploration of replaceState(). The changes based on your codes will be tracked in #2273 .

See comment from Rong above. Closing this exploratory PR.


Strange warning: All files matched by "./app/*!(.module|_test).js" were excluded or matched by prior matchers

Environment Details
Karma 6.13.4
karma.conf.js:
module.exports = function(config) {
  config.set({

    basePath: './app',

    files: [
      'lib/angular/angular.js',
      'lib/angular-route/angular-route.js',
      'lib/angular-aria/angular-aria.js',
      'lib/angular-animate/angular-animate.js',
      'lib/angular-messages/angular-messages.js',
      'lib/angular-material/angular-material.js',
      '../node_modules/angular-mocks/angular-mocks.js',
      '../node_modules/angular-material/angular-material-mocks.js',
      '**/*.module.js',
      '*!(.module|_test).js',
      '!(lib)/**/*!(.module|_test).js',
      '**/*_test.js'
    ],

    autoWatch: true,

    frameworks: ['jasmine'],

    browsers: ['Chrome'],

    plugins: [
      'karma-chrome-launcher',
      'karma-firefox-launcher',
      'karma-jasmine'
    ]

  });
};

Expected behaviour

all the necessary modules are connected first
'**/*.module.js'- all the modules I created are connected
'*!(.module|_test).js' - loads everything in the ./app folder except for modules and tests, but not in subfolders
'!(lib)/**/*!(.module|_test).js' - all folders in the ./app folder except the lib folder, all the files inside these folders except modules and tests
'**/*_test.js' - all tests in child folders ./app

Actual behaviour
Throws two warnings:
14 01 2020 11:42:00.324:WARN [filelist]: All files matched
by "./app/*!(.module|_test).js" were excluded or matched by prior matchers.
14 01 2020 11:42:00.329:WARN [filelist]: All files matched
by "./app/**/*_test.js" were excluded or matched by prior matchers.

Although these files were not included before these expressions, I don’t understand why these warnings came from
Steps to reproduce the behaviour

karma start

You clearly know more about the matching than I do, but I would verify that files named _test.js really existed in ./app.  And I would look at the output of --logLevel=DEBUG


What are prerequisites to run this dll in newly installed os pc in win 7,8,10

What are prerequisites to run this dll in newly installed os pc in win 7,8,10
like c++ packs and compilers, framewords
so that it can run without visual studio
actually i have uninstalled vs and now i am getting error that cannot load dll

Try this: https://www.microsoft.com/en-us/download/details.aspx?id=30679

If that doesn't work, make sure try .NET 4. Let me know what did the trick.


Python project build after they are disabled in solution config manager

Describe the bug
For a large solution (mainly C/C++) distro is created from a batch file by calling: devenv solution_file.sln /Rebuild
Even though Python projects disabled in the solution configuration manager, they attempt to 'build' and fail with many errors (first being 'unable to load python tools').
Expected behavior
Python project is not included in the build once it is disabled in the solution configuration manager.
(Feedback from PTVS survey)

We would need more detailed repro steps and a sample code that demonstrates the problem for us to better understand and address this issue. We haven't received similar complaints from other users as of now. So for now, I will mark this issue as closed, and if others encounter a similar problem, we can revisit and gather additional information to investigate further.


Customize register-user endpoint, to make creation of user and settings simultaneous

We are starting by simply using the on_after_register hook, but this requires that first we create a valid user and then we associate it to a settings entry -> therefore we cannot make the FK required.
If we customize SQLModelUserDatabaseAsync.create, we could create the two DB objects at the same time.
Ref:

https://github.com/fractal-analytics-platform/fractal-server/issues/1739

We have at least two options:

Add attribute SQLModelUserDatabaseAsync.user_settings_model, and customize SQLModelUserDatabaseAsync.create so that it creates both the user and their settings.
Rewrite the POST /auth/register/ endpoint without using fastapi-users or SQLModelUserDatabaseAsync logics - or maybe by only using some of them.

A good attempt at this was #1789.
For the moment, we will keep the UserOAuth.user_settings_id foreign key optional, even though it will always be present in practice. In a later update, we'll try to fully integrate the user-register and oauth-related endpoints from fastapi-users into fractal-server.
We decided to postpone this task mostly due to several other ongoing updates - but this is ready for further work.
cc @ychiucco


merge remote

Codecov Report

Merging #89 into master will not change coverage.
The diff coverage is 77.95%.

@@           Coverage Diff           @@
##           master      #89   +/-   ##
=======================================
  Coverage   67.32%   67.32%
=======================================
  Files          18       18
  Lines        3936     3936
=======================================
  Hits         2650     2650
  Misses       1128     1128
  Partials      158      158

Impacted Files
Coverage Δ

server/service/util/versionrule.go
100% <ø> (ø)
:arrow_up:

server/service/util/heartbeat_util.go
33.33% <0%> (ø)
:arrow_up:

server/service/util/tag_util.go
63.63% <100%> (ø)
:arrow_up:

server/service/microservices.go
73.53% <100%> (ø)
:arrow_up:

server/service/rule.go
71.51% <100%> (ø)
:arrow_up:

server/service/services_dependency.go
67.6% <100%> (ø)
:arrow_up:

server/service/tag.go
73.91% <100%> (-0.49%)
:arrow_down:

server/service/governservice.go
65.53% <100%> (ø)
:arrow_up:

server/service/util/microservice_util.go
75.46% <100%> (ø)
:arrow_up:

server/service/util/util.go
100% <100%> (ø)
:arrow_up:

... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e5c4ad...3d23c64. Read the comment docs.

Coverage decreased (-0.05%) to 71.577% when pulling 3d23c64d2e7558a5faf680113f0f1636692597d8 on little-cui:master into 6e5c4ad949b0c69f85b5a9bce810d6bab07014d8 on ServiceComb:master.


Time granularity cannot be parsed to Enum value for some photos

For some of our users, fetching and parsing profile pictures and tagged photos, results in a parsing exception:
2015-04-10 13:51:26,085 [c-16] ERR c.s.f.v.w.c.f.FacebookGalleryPanel$FacebookPhotoModel Could not load images from facebook.
org.springframework.social.UncategorizedApiException: Error deserializing data from Facebook: Can not construct instance of org.springframework.social.facebook.api.Photo$TimeGranularity from String value 'day': value not one of declared Enum instance names: [YEAR, MONTH, DAY, HOUR, MIN, NONE]
 at [Source: java.io.StringReader@5a3774f4; line: 1, column: 26069] (through reference chain: java.util.ArrayList[6]->org.springframework.social.facebook.api.Photo["backdated_time_granularity"])

It seems that the field backdated_time_granularity sometimes contains lower case values such as day.

It seems that the code for deserializing this properly was there, but not being used. Not sure why. But I fixed it and it will be in the next snapshot build (building momentarily) and also in Spring Social Facebook 2.0.0.RELEASE (building soon--within next 24 hours, barring any surprises).


[server] Add request based store properties endpoint to server

[server] Add request based store properties endpoint to server

Add endpoint to server to allow DVC to retrieve store metadata, bypassing the store based metadata retrieval. More details in this document: link.
How was this PR tested?

Integration test located at endToEnd/TestServerStorePropertiesEndpoint.java
Does this PR introduce any user-facing changes?

[x] No. You can skip the rest of this section.
[ ] Yes. Make sure to explain your proposed changes and call out the behavior change.

No links to internal docs on the open source repo please.
@pthirun, @xunyin8, can we add a page to the open source wiki describing system stores?


perf(transformer): pre-calculate if unsupported patterns in RegExp transform

Similar to #5482. Calculate whether any unsupported RegExp patterns at start, to make checking if need to check for patterns cheaper (a single comparison operation, rather than 3 comparisons and ORs).

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#5483  👈
#5482
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on  Graphite

I am surprised this makes a measurable difference.
I think the lesson is that the most important thing for good performance in transformer is to bail out as fast as possible when there's nothing to be done - and to do as little work as possible to reach that decision to bail out.


'DbtYamlManager' object has no attribute 'yaml', No module named 'dbt_osmosis'

Hi there--thanks for the great tool!
I'm getting an AttributeError when running dbt-osmosis compose and dbt-osmosis run. See the stacktrace below. My dbt_project.yml is attached, as well.
> dbt-osmosis run -f acdw.dimensions.acdw__dimensions__item
INFO     🌊 Executing dbt-osmosis                                                                                main.py:78

INFO     📈 Searching project stucture for required updates and building action plan                                                                                osmosis.py:907
INFO     ...building project structure mapping in memory                                                                                osmosis.py:885
INFO     [('CREATE', '->', WindowsPath('C:/my_project_path/models/acdw/dimensions/schema/acdw__dimensions__item.yml'))]                                                                                osmosis.py:1027
INFO     👷 Executing action plan and conforming projecting schemas to defined structure                                                                                osmosis.py:977
INFO     🚧 Building schema file acdw__dimensions__item.yml                                                                                osmosis.py:983
Traceback (most recent call last):
  File "C:\Users\me\Anaconda3\envs\dbt\lib\runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\Users\me\Anaconda3\envs\dbt\lib\runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "C:\Users\me\Anaconda3\envs\dbt\Scripts\dbt-osmosis.exe\__main__.py", line 7, in <module>
  File "C:\Users\me\Anaconda3\envs\dbt\lib\site-packages\click\core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "C:\Users\me\Anaconda3\envs\dbt\lib\site-packages\click\core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "C:\Users\me\Anaconda3\envs\dbt\lib\site-packages\click\core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "C:\Users\me\Anaconda3\envs\dbt\lib\site-packages\click\core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "C:\Users\me\Anaconda3\envs\dbt\lib\site-packages\click\core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "C:\Users\me\Anaconda3\envs\dbt\lib\site-packages\dbt_osmosis\main.py", line 89, in run
    if runner.commit_project_restructure_to_disk():
  File "C:\Users\me\Anaconda3\envs\dbt\lib\site-packages\dbt_osmosis\core\osmosis.py", line 987, in commit_project_restructure_to_disk
    self.yaml.dump(structure.output, target)
AttributeError: 'DbtYamlManager' object has no attribute 'yaml'

Possibly relatedly, I'm not able to run dbt-osmosis workbench, either. Apparently, dbt_osmosis can't find itself.
> dbt-osmosis workbench
INFO     🌊 Executing dbt-osmosis                                                                                main.py:406
[...]
2022-10-06 17:41:59.975 Pandas backend loaded 1.4.2
2022-10-06 17:41:59.981 Numpy backend loaded 1.21.5
2022-10-06 17:41:59.982 Pyspark backend NOT loaded
2022-10-06 17:41:59.983 Python backend loaded
2022-10-06 17:42:01.020 Uncaught app exception
Traceback (most recent call last):
  File "C:\Users\me\Anaconda3\lib\site-packages\streamlit\runtime\scriptrunner\script_runner.py", line 562, in _run_script
    exec(code, module.__dict__)
  File "C:\Users\me\Anaconda3\envs\dbt\Lib\site-packages\dbt_osmosis\app.py", line 17, in <module>
    from dbt_osmosis.core.osmosis import DEFAULT_PROFILES_DIR, DbtProject
ModuleNotFoundError: No module named 'dbt_osmosis'

dbt_project.zip

@coryandrewtaylor
Thanks for the issue!
So the DbtYamlManager was using an old accessor so this has been corrected in 0.8.7
The workbench is another issue 🤔
You installed it with the extra I presume dbt-osmosis[workbench] ?
Let me know if it works after bumping the version

@z3z1ma Thanks for the super fast reply!
I've upgraded to v0.8.7 and installed the workbench extra. commit_project_restructure_to_disk is still erroring out, though now it's a TypeError:
Traceback (most recent call last):
  File "C:\Users\me\Anaconda3\lib\runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\Users\me\Anaconda3\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\Users\me\.local\bin\dbt-osmosis.exe\__main__.py", line 7, in <module>
  File "C:\Users\me\.local\pipx\venvs\dbt-osmosis\lib\site-packages\click\core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "C:\Users\me\.local\pipx\venvs\dbt-osmosis\lib\site-packages\click\core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "C:\Users\me\.local\pipx\venvs\dbt-osmosis\lib\site-packages\click\core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "C:\Users\me\.local\pipx\venvs\dbt-osmosis\lib\site-packages\click\core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "C:\Users\me\.local\pipx\venvs\dbt-osmosis\lib\site-packages\click\core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "C:\Users\me\.local\pipx\venvs\dbt-osmosis\lib\site-packages\dbt_osmosis\main.py", line 89, in run
    if runner.commit_project_restructure_to_disk():
  File "C:\Users\me\.local\pipx\venvs\dbt-osmosis\lib\site-packages\dbt_osmosis\core\osmosis.py", line 997, in commit_project_restructure_to_disk
    if "version" not in target_schema:
TypeError: argument of type 'NoneType' is not iterable

The full log is here: dbt_osmosis_run.log
I'm able to load the workbench now, though only in a conda environment; I get the same ModuleNotFoundError in a pipx venv. Local SQL compilation works just fine. However, when trying to test the compiled query, I get dbt.exceptions.InvalidConnectionException: Runtime Error: connection never acquired for thread (29328, 3368), have [(29328, 29948)]. The traceback and full logs are below.
Traceback (most recent call last):
  File "C:\Users\me\Anaconda3\envs\dbt\lib\site-packages\streamlit\runtime\scriptrunner\script_runner.py", line 558, in _run_script
    self._session_state.on_script_will_rerun(rerun_data.widget_states)
  File "C:\Users\me\Anaconda3\envs\dbt\lib\site-packages\streamlit\runtime\state\safe_session_state.py", line 73, in on_script_will_rerun
    self._state.on_script_will_rerun(latest_widget_states)
  File "C:\Users\me\Anaconda3\envs\dbt\lib\site-packages\streamlit\runtime\state\session_state.py", line 543, in on_script_will_rerun
    self._call_callbacks()
  File "C:\Users\me\Anaconda3\envs\dbt\lib\site-packages\streamlit\runtime\state\session_state.py", line 556, in _call_callbacks
    self._new_widget_state.call_callback(wid)
  File "C:\Users\me\Anaconda3\envs\dbt\lib\site-packages\streamlit\runtime\state\session_state.py", line 278, in call_callback
    callback(*args, **kwargs)
  File "C:\Users\me\Anaconda3\envs\dbt\Lib\site-packages\dbt_osmosis\app.py", line 205, in run_query
    result = ctx.execute_sql(f"select * from ({sql}) as __all_data limit {limit}")
  File "C:\Users\me\Anaconda3\envs\dbt\lib\site-packages\dbt_osmosis\core\osmosis.py", line 440, in execute_sql
    *self.adapter_execute(compiled_sql, fetch=True),
  File "C:\Users\me\Anaconda3\envs\dbt\lib\site-packages\dbt_osmosis\core\osmosis.py", line 422, in adapter_execute
    return self.adapter.execute(sql, auto_begin, fetch)
  File "C:\Users\me\Anaconda3\envs\dbt\lib\site-packages\dbt\adapters\base\impl.py", line 242, in execute
    return self.connections.execute(sql=sql, auto_begin=auto_begin, fetch=fetch)
  File "C:\Users\me\Anaconda3\envs\dbt\lib\site-packages\dbt\adapters\snowflake\connections.py", line 441, in execute
    _, cursor = self.add_query(sql, auto_begin)
  File "C:\Users\me\Anaconda3\envs\dbt\lib\site-packages\dbt\adapters\snowflake\connections.py", line 492, in add_query
    connection, cursor = super().add_query(
  File "C:\Users\me\Anaconda3\envs\dbt\lib\site-packages\dbt\adapters\sql\connections.py", line 55, in add_query
    connection = self.get_thread_connection()
  File "C:\Users\me\Anaconda3\envs\dbt\lib\site-packages\dbt\adapters\base\connections.py", line 91, in get_thread_connection
    raise dbt.exceptions.InvalidConnectionException(key, list(self.thread_connections))
dbt.exceptions.InvalidConnectionException: Runtime Error
  connection never acquired for thread (29328, 3368), have [(29328, 29948)]

dbt_osmosis_workbench.log
As a side note--it seems like you've caught a bug in Streamlit! See lines 14-168 in the log for that error.

@z3z1ma Doing a bit of debugging, the NoneType is not iterable error was coming from DbtYamlManager.yaml_handler reading an empty yaml file. Adding in a couple of lines to create a new dict in that case resolves the problem.
I've put in PR #18 with the fix.

Thanks @coryandrewtaylor for that fix!
Also super interesting on the connection piece. I think I know roote cause and can address that too. I have been working with connections in general as well as snowflake stuff and have my head wrapped around whats needed.

The last set of changes should have resolved connection issues. We can reopen another specific issue if it resurfaces.


Different colors for different brackets.

Hi, Is there a way to set different colors for matching brackets ( in a custom language ).
I am looking for something like the screenshot below :-

Is there a way to achieve these colors for different brackets ?
Also I would like to know if there is a way to find and throw an error for a bracket that hasn't been closed .

Hey, can I work on adding this feature?

Hey, can I work on adding this feature?

@alexdima  I found a vs-code extension that does something similar. Here is the extension - https://marketplace.visualstudio.com/items?itemName=CoenraadS.bracket-pair-colorizer
Here is their github link -https://github.com/CoenraadS/Bracket-Pair-Colorizer-2/tree/develop/src
Any idea/suggestions on how I can use some of the inputs from this code in tandem with Monaco's api to get it to work ?
@wrisov

@alexdima  I found a vs-code extension that does something similar. Here is the extension - https://marketplace.visualstudio.com/items?itemName=CoenraadS.bracket-pair-colorizer
Here is their github link -https://github.com/CoenraadS/Bracket-Pair-Colorizer-2/tree/develop/src
Any idea/suggestions on how I can use some of the inputs from this code in tandem with Monaco's api to get it to work ?
@wrisov

Very good feature idea ! Can't wait to use that one

That extension Bracket-Pair-Colorizer-2had been deprecated.

I have set
bracketPairColorization: {
  enabled: true
}

in editor.IStandaloneEditorConstructionOptions, but it doesn't work.

@Hfutsora, this has worked for me:
"bracketPairColorization.enabled": true

Is there a way to set a custom color for each level?

This is now built in.
Themes can change the colors.

Thank you @hediet! :slightly_smiling_face:
I am already using a theme where I set various colors (e.g., "editor.selectionHighlightBackground": "#ff00"), however, I don't know how refer to the different levels of brackets. Is there a list of names that includes these different levels of brackets?

This is documented in VS Code.


HBASE-27200 Clean up error-prone findings in hbase-archetypes

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 47s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 26s
master passed

+1 :green_heart:
compile
0m 23s
master passed

+1 :green_heart:
shadedjars
4m  2s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 27s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 11s
the patch passed

+1 :green_heart:
compile
0m 22s
the patch passed

+1 :green_heart:
javac
0m 22s
the patch passed

+1 :green_heart:
shadedjars
4m  1s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 20s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 56s
hbase-client-project in the patch passed.

+1 :green_heart:
unit
0m 46s
hbase-shaded-client-project in the patch passed.

19m 32s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4621/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4621

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux dea39b027e0a 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 01b45e285d

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4621/1/testReport/

Max. process+thread count
419 (vs. ulimit of 30000)

modules
C: hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: hbase-archetypes

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4621/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 24s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 12s
master passed

+1 :green_heart:
compile
0m 30s
master passed

+1 :green_heart:
shadedjars
4m  6s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 25s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  0s
the patch passed

+1 :green_heart:
compile
0m 30s
the patch passed

+1 :green_heart:
javac
0m 30s
the patch passed

+1 :green_heart:
shadedjars
4m 22s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 23s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 46s
hbase-client-project in the patch passed.

+1 :green_heart:
unit
0m 43s
hbase-shaded-client-project in the patch passed.

20m 56s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4621/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4621

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux e3ea6bc8313d 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 01b45e285d

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4621/1/testReport/

Max. process+thread count
423 (vs. ulimit of 30000)

modules
C: hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: hbase-archetypes

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4621/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 24s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 19s
master passed

+1 :green_heart:
compile
0m 30s
master passed

+1 :green_heart:
checkstyle
0m 12s
master passed

+1 :green_heart:
spotless
0m 41s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 35s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  9s
the patch passed

+1 :green_heart:
compile
0m 36s
the patch passed

+1 :green_heart:
javac
0m 15s
hbase-archetypes_hbase-client-project generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)

+1 :green_heart:
javac
0m 21s
hbase-archetypes_hbase-shaded-client-project generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)

+1 :green_heart:
checkstyle
0m 11s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 24s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotless
0m 39s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 44s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 14s
The patch does not generate ASF License warnings.

27m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4621/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4621

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 49851ca064db 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 01b45e285d

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
64 (vs. ulimit of 30000)

modules
C: hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: hbase-archetypes

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4621/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


support rspamd when configured

this PR adds rspamd as an optional service
RSPAMD_ENABLE can be set to enable the service
RSPAMD_WEB_PASSWORD can be be set to require a password when logging into the rspamd web dashboard
all configurations were taken from: https://anonaddy.com/self-hosting/
this resolves #93

i've reworked this PR to install and configure rspamd internally in the container
locally, i can confirm rspamd can be enabled/disabled and the web dashboard requires a password

@eleith Looks great thanks! In a follow-up I will update our test workflow and add a matrix to test against rspamd and opendkim/dmarc so we can check if services are up as expected.

Btw do we need to update the Generate DKIM private/public keypair in the README relative to Rspamd or is it ok to use opendkim-genkey for it?

Btw do we need to update the Generate DKIM private/public keypair section in the README relative to Rspamd or is it ok to use opendkim-genkey for it?

i was gonna leave it alone in an attempt to keep this PR from growing. but, with that said, this change isn't required (opendkim generated keys still would work) but it would be more aligned with the anonaddy's recommendation to do the following:
sudo rspamadm dkim_keygen -s 'default' -b 2048 -d example.com -k /var/lib/rspamd/dkim/example.com.default.key | sudo tee -a /var/lib/rspamd/dkim/example.com.default.pub

Btw do we need to update the Generate DKIM private/public keypair section in the README relative to Rspamd or is it ok to use opendkim-genkey for it?

i was gonna leave it alone in an attempt to keep this PR from growing. but, with that said, this change isn't required (opendkim generated keys still would work) but it would be more aligned with the anonaddy's recommendation to do the following:
sudo rspamadm dkim_keygen -s 'default' -b 2048 -d example.com -k /var/lib/rspamd/dkim/example.com.default.key | sudo tee -a /var/lib/rspamd/dkim/example.com.default.pub

Sure let's do that in a follow-up


Improve packaged Linux binary performance

This PR closes #1695 by adding Makefile support for -mtune and updates the .travis.yml and Dockerfile files to include tune=intel.

I think this should be titled something like "Improve packaged Linux binary performance" or something like that for when it hits the change log.

Otherwise this looks good.

@SeanTAllen I assume that this new title would seem more like a fix than an addition in the changelog.

Yes, I would consider this a fix as we degraded performance with the arch change and this should get some back.

Thanks for taking this one on @Theodus!

Note: I'm about to roll the line of this that adds tune=intel to the release packages (and hence the changelog entry) back, since in our 0.11.4 release candidate this didn't build on Travis.  See #1738:
Building ponyc packages for deployment...
threads.c
gcc -MMD -MP -march=x86-64 -mtune=intel -Werror -Wconversion -Wno-sign-conversion -Wextra -Wall -mcx16 -O3 -DNDEBUG -std=gnu11 -fexceptions -DPONY_VERSION=\"0.11.4-e91d517\" -DLLVM_VERSION=\"3.9.1\" -DPONY_COMPILER=\"gcc\" -DPONY_ARCH=\"x86-64\" -DBUILD_COMPILER=\""gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4"\" -DPONY_BUILD_CONFIG=\"release\" -D_FILE_OFFSET_BITS=64  -DPONY_NO_ASSERT -c -o build/release/obj/libponyrt/platform/threads.o src/libponyrt/platform/threads.c  -I src/common/ -I src/libponyrt/
src/libponyrt/platform/threads.c:1:0: error: bad value (intel) for -mtune= switch
 #ifdef __linux__
 ^
make: *** [build/release/obj/libponyrt/platform/threads.o] Error 1


Galois Keys for N=1024,2048

Why is it not possible to generate Galois keys for N=1024 and N=2048? Is there a theoretical limitation or is it not implemented in the library? If it's a theoretical limitation, can you point me to a paper which explains the limitation?
Thanks

Current SEAL implementation uses one prime for the noise control (ie., the so call special prime).
On the other hand, for small Ns (eg. 1024, 2048), we can not have many bits for the modulus already to make sure
the scheme is secure. As a result, SEAL do not generate Galois keys for such small Ns.
However, if you need Galois for such smaller parameter, you might need to implement the digit-decomposition version of Galois key which does not need the extra special prime. Check out the ancient SEAL


Link to examples of high quality pull requests in the pull request template

For example, #278 does a great job of providing a complete usage example, and our PR template can guide others to do the same!

@mfisher87 Hey, do you have specific opinions on how we can approach this? I Think for solving this we need to have some PR'S that follow rules form PR template and we'll then just have to link to those PR'S.

The hard part is finding those PRs :) I don't know that we'll find one "perfect PR" that ticks all the boxes easily, but maybe we can find PRs that exemplify specific things from the list? For example, we have this checklist item:

[ ] Populate a descriptive title. For example, instead of "Updated README.md", use a
title such as "Add testing details to the contributor section of the README".

Instead of ... such as "Add testing details ..., we could find a PR with a clear and concise title and use that as the example, and continue to find other PRs that have stellar examples of the other qualities we're looking for. What do you think?

Hey I will try to come up with a PR that follows this rubric!

That sounds great! Thanks for being willing to dive deep on this! :heart:

That sounds great! Thanks for being willing to dive deep on this! ❤

@mfisher87 Can we use the PR for backwards compatibility as an Ideal PR?

I think so! Based on this comment, which of our PR checklist items do you feel that PR sets a good example for?

I feel my PR has proper methodology, what I mean by that is that you will have to make changes to CHANGELOG before making a PR which I guess is something that people contributing for the first time might look over. Also I feel I could have done better with some of the titles of my commits but I think they are not too bad. These are some of things I can remember at this point in time.

That sounds reasonable! Would you be willing to open a PR to modify our PR template? I'm thinking maybe we could add the example PR links as sub-bullets of the checklist items?


a manual way to control internal mock stack

v12.4.0 has been released and contains a fix for the issue. Feel free to reopen the issue or to submit a new one if you meet any problems.


upgrade to questdb 7.4.0

Java library
https://mvnrepository.com/artifact/org.questdb/questdb
Docker image
https://hub.docker.com/r/questdb/questdb/tags

Thanks for the PR. But, dependabot is in charge of bumping dependencies. Please, read the PR template for this.


Create Pencil Sketch from Picture[GSSOC'23]

Describe the project you want to add with tech stack
Produce pencil sketch of a picture using OpenCV
Expected behavior

Will produce pencil sketch like picture from given image.

@MohitGupta121 @pranjay-poddar please assign this issue to me.


Specify timeout for downloading poco

The OS X packaging job has had connectivity issues the last few nights. This job is currently stuck trying to download poco with no timeout.
This job took 5 minutes to download it so I set the timeout at 10 minutes to avoid false positives, perhaps that is un-necessarily high.
 (I don't understand why this can't be merged automatically so that job uses a custom repos file with this branch)

I think the issue is that the version and md5 sum changed and the conflicts have not been resolved on your branch.
master:
  ExternalProject_Add(poco-1.7.7
    URL https://github.com/pocoproject/poco/archive/poco-1.7.7-release.tar.gz
    URL_MD5 247b97b545715dc38c8619e412fbcd96

external_project_timeout
ExternalProject_Add(poco-1.7.6
  URL https://github.com/pocoproject/poco/archive/poco-1.7.6-release.tar.gz
  URL_MD5 53dce82527f165f14af78689a8188891
  TIMEOUT 600

thank you @mikaelarguedas, my local branch was out of date.
rebased:


[New Port Request] AMReX

AMReX is a software framework containing all the functionality to write massively parallel, block-structured adaptive mesh refinement (AMR) applications. It can be found here: https://github.com/AMReX-Codes/amrex

If you wish to add this port in the future, you can reopen this issue, but we're closing it for now.


Add links to footer

Explore if needed created new page
Wait for page.

https://github.com/techy1999/BlogFrontend/pull/136


run tasks in parallel where possible

Many tasks depend on updating the same files, so these tasks should be run in serial for reliability and safety.
However, any two tasks that do not share any such files should be able to run concurrently.
This could be worth investigating:

https://www.npmjs.com/package/orchestrator

https://github.com/jamestalmage/gulp-lock/issues/1

The primary desire is to move away from an explicit task order, and just have an order computed based on task metadata. Performance / efficiency is a secondary concern.


Allow remote env files

For remote debugging, one needs remote env files.
This would some additional plumbing so that the remote env could be sourced by the remote interpreter at load time.

Unfortunately, at this point I don't see a way how this can be addressed. This plugin operates within IDEA process rather than "where code is run". And I don't know the IDEA platform enough even to say if it's possible at all or no. Please feel free to contribute the feature or advice on a way how this can be implemented with regards to IDEA plugin capabilities. But for now I'm going to close this issues it doesn't seem to be feasible to implement. Sorry for bringing bad news. :(


add check isMentionMe method

add check isMentionedMe method
[√] Feature

Checklist
Description
Does this PR introduce a breaking change?
[√] No

Oh， all failed

Sorry, need more test

Why is appveyor that  error ?
Error: listen EADDRINUSE <IP_ADDRESS>:10513
    at Server.setupListenHandle [as _listen2] (net.js:1335:14)
    at listenInCluster (net.js:1383:12)
    at doListen (net.js:1509:7)
    at process._tickCallback (internal/process/next_tick.js:63:19)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR!

This new method of Message class will be very useful, thank you very much for the contribution!


r.init() hang on cloned virtual machine

My RPA-Python application requires running multiple instances, (4-6), in parallel at a specified schedule.  I have coded and tested a master instance on a google cloud linux virtual machine and trigger with a cronjob and it works great.   My plan to run multiple instances is to spin up clones of the master instance vm a few minutes prior to needing them, let them run the script, and then delete the vm once run is completed.  This minimizes cost and also ensures that the script is always the latest version.
Unfortunately, when I clone a vm and run the script it hangs on the r.init() command.  There is no error, just hangs.  If I clone the master vm before I install RPA and PHP, and do those installs manually the clone works just like the master.  Not sure what is causing the hang, so not sure how to troubleshoot, so any help would be appreciated.
Also, happy to hear other suggestions of the best way to accomplish running multiple instances of the same script at the same time.

Hi @cohnhead66 sorry for my late reply! Just got to work on the GitHub issues!
If a VM works, by right cloning it should work. But I'm not familiar enough with VM to know why it doesn't.
My best guess is the VM and your vendor somehow stores some state such that installing directly works but cloning an an already installed VM doesn't.
My best guess on what could work may be to just factor in the few minutes of installation time and do those installation on all the instances. You can use some of the Python date time libraries to just sleep until it is the time to run the automation then it starts, so the running will be all in parallel.
Closing the issue for now but will look out for your reply!


SyntaxError: invalid syntax

Hi, my system using Ubuntu 16.04 LTS, and i'm getting this problem when i'm running this command > "python3 Vxscan.py -h"
can u guide me please how to solve this issue? Thanks.
Traceback (most recent call last):
File "Vxscan.py", line 31, in
from lib.common import start, bcolors
File "/home/xxx/vxscan/Vxscan/lib/common.py", line 13, in
from virustotal_python import Virustotal
File "/home/xxx/.local/lib/python3.5/site-packages/virustotal_python/init.py", line 1, in
from virustotal_python.virustotal import Virustotal
File "/home/xxx/.local/lib/python3.5/site-packages/virustotal_python/virustotal.py", line 27
print(f"Failed to import required modules: {err}")
^

Requires Python version 3.6 or higher


k_pipe_alloc_init() api is failing on qemu_x86

k_pipe_alloc_init() api is failing on qemu_x86. This api is getting validated with the test case in https://github.com/zephyrproject-rtos/zephyr/pull/9231.
Same test is passing in all supported architecture, including x86 based boards ( quark_se_c1000, arduino_101 and quark_d2000_crb).

Same test is passing in all supported architecture, including x86 based boards ( quark_se_c1000, arduino_101 and quark_d2000_crb)

None of those boards enable the MMU.

There are two issues with the test code.

First is the test_pipe_alloc() is running out of mem pool space when compiled for qemu_x86.
Second is at test_pipe_block_writer_wait(). Calling k_pipe_block_put() when the pipe has no enough space to take in all data will cause the subsequent k_pipe_get() to cause CPU fault inside _abort_timeout(). However, when simply using k_pipe_put(), there would not be any issues with get() afterwards even with full or partially full pipe when put() is called. So this needs further investigation.

Not an issue with API. The new tests being introduced are using more memory, but the PR never increases the mem_pool, and thus running out of memory.


Item pipes cause tps lag

Minecraft version & Mod Version:
1.12.2 latest released on 11/04/2018
Single player or Server:
Sp
Describe problem (what you were doing / what happened):
If you have a lot of item pipes they cause major tps and fps lag, diagnosed with lag goggles mod.
Crash log (if any):
No crash

https://minecraft.curseforge.com/projects/laggoggles/files/2536205

Finally found some time to check this out.  Looks like it uses a green/red system to identify lag, so things like hopper and my normal machines hit around 8 or 11 uS, and pipes can be around 25 uS.  There is one case where a corner is around 184
Some screenshots   https://imgur.com/a/4R64r4G

Oops looks like i tagged this in a commit for 1.15.8 but forgot to close it.  Still not perfect, may not be better than other pipes but its better than it was


gnumake: Allow guile extension language as an optional feature

Motivation for this change
Gmake has supported guile from 4.0 onwards. It allows one to extend make with custom functions.
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Do you know if pkg-config is used anything when building without guile support?
BTW, this isn't a mass rebuild, as we still default to 4.1. (I don't know why.)

@vcunat it is only used for guile. I have moved it to optional along with guile.

It's a bit of a laugh that the bot identified me as a reviewer, but the change looks good to me.
As far as defaulting to 4.2, I only know what was discussed in #15637.  Apparently it would be best to pull-request that change against staging, but staging doesn't include 4.2 yet.  I don't know the process around mass rebuilds.  Is it documented somewhere?

Staging does include gnumake42. It's currently less than a week behind master. Switching is easy, but first I'd like to estimate the likelihood of breaking random packages, though it will hopefully be low.

IIRC documentation says mass rebuilds should go through staging, but probably no other details.

@vcunat @nicknovitski Any idea how to proceed with this?

It seems like this shouldn't cause any rebuilds, so I guess the only question is whether this is a feature people care about ...

@joachifm an argument in favor might be that some distros carry it, and it is optional.


use argparse on the list-variable-source script and remove hardcoded directory

@m4rc1e We need to use argparse on bin/fontbakery-list-variable-source.py and pass the following hardcoded directory as a command line argument:
parent_dir = '/Users/marc/Documents/googlefonts/manual_font_cleaning/'

This looks similar to #1416

I actually stumbled upon this one when I was updating README.md with usage instructions and noticed that it even lacks argparse.

migrating to https://github.com/googlefonts/tools/issues/14


E   TypeError: open() got an unexpected keyword argument 'cache_options'

pyarrow/io-hdfs.pxi:383: TypeError

I think the issue is fsspec is passing a cache_options parameter down to PyArrow's HdfsFile here:
https://github.com/intake/filesystem_spec/blob/8b59dc8c2c035db5793102b9513c46e6a1bd4fb0/fsspec/implementations/hdfs.py#L173
which isn't supported (feel free to correct me if I'm wrong here).
Does poping off the cache_options keyword argument and raising if it's not None seem like a reasonable fix?
diff --git a/fsspec/implementations/hdfs.py b/fsspec/implementations/hdfs.py
index 06ec205..18602a0 100644
--- a/fsspec/implementations/hdfs.py
+++ b/fsspec/implementations/hdfs.py
@@ -170,6 +170,10 @@ class HDFSFile(object):
         self.path = path
         self.mode = mode
         self.block_size = block_size
+        if kwargs.get("cache_options") is None:
+            kwargs.pop("cache_options")
+        else:
+            raise NotImplementedError("cache_options is not implemented for HDFSFile")
         self.fh = fs.pahdfs.open(path, mode, block_size, **kwargs)
         if self.fh.readable():
             self.seek_size = self.size()

Sorry about that.
I think we’ll add cache_options as an unused argument to HDFSFile. May have to do that for others.
I can do that tomorrow and make another release soon (may wait a day or so for more bug reports).

On Nov 13, 2019, at 19:21, James Bourbeau<EMAIL_ADDRESS>wrote:

We're seeing failures over on Dask's CI HDFS tests (see https://travis-ci.org/dask/dask/jobs/611548312) where we're getting the following error: TypeError: open() got an unexpected keyword argument 'cache_options'
Full traceback:
I think the issue is we're passing a cache_options parameter down to PyArrow's HdfsFile here:
https://github.com/intake/filesystem_spec/blob/8b59dc8c2c035db5793102b9513c46e6a1bd4fb0/fsspec/implementations/hdfs.py#L173
which isn't supported (feel free to correct me if I'm wrong here).
Does raising if cache_options is not None seem like a reasonable fix?
diff --git a/fsspec/implementations/hdfs.py b/fsspec/implementations/hdfs.py
index 06ec205..18602a0 100644
--- a/fsspec/implementations/hdfs.py
+++ b/fsspec/implementations/hdfs.py
@@ -170,6 +170,10 @@ class HDFSFile(object):
self.path = path
self.mode = mode
self.block_size = block_size

   if kwargs.get("cache_options") is None:

       kwargs.pop("cache_options")

   else:

       raise NotImplementedError("cache_options is not implemented for HDFSFile")
   self.fh = fs.pahdfs.open(path, mode, block_size, **kwargs)
   if self.fh.readable():
       self.seek_size = self.size()

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Thanks @TomAugspurger!


Hi, How do I program so I can display results of glow in pangolin gui?

I want to use glow to calculate some results in shader program, then I want to display this results in pangolin. A naive approach is like this, with glow::GlTransformFeedback to get back results from GPU to CPU, then display in pangolin(from CPU to GPU), This consume the time to move data back and forth. So, how do I do so pangolin can display results from glow?

I'm not an Pangolin expert, but as far as I know is Pangolin also a "wrapper" around OpenGL calls; thus, you can maybe directly use the OpenGL handles (i.e., the integers / ids) to buffers, etc. to directly use the already allocated OpenGL resource on the GPU. All glow objects are derived from GlObject and therefore have the id() method to get the id of the corresponding OpenGL object.


add repack_awq_to_optimum_format function

Type of Change
to load awq model quantized by autoawq and inference by IPEX kernel.
Description
detail description
Expected Behavior & Potential Risk
the expected behavior that triggered by this PR
How has this PR been tested?
how to reproduce the test (including hardware information)
Dependency Change?
any library dependency introduced or removed

@XuehaoSun Could you please help check the CI failed issue, it seems not bring by this PR.


Problem running project with Eclipse

Running the project with eclipse leads to a freezing environment.

Seems to be solved with new Timer.

Finally solved with dynamic repaints.


Various stuff missing from lecture 11 (tangents, normals, binormals)

*Video link
*Diagram/picture(s) (electron path with vectors attached)

Lecture 12 is all messed up too

Thanks for pointing this out! Not sure what happened. I've restored the video link and will work on the demos.

Actually, all the lectures after 11 are missing the demos/graphs

It's a small thing, but in the same lecture section, the notes say that N(t) = T'(T)/|T'(t)|. It was noted in the videos that the capital "T" should be lowercase. This should probably be fixed because it is mildly confusing.


torch.linalg.vector_norm : Set ord default as specified in docs

The docs of this method specify:
<param name="ord">Order of norm. Default: 2</param>

Said default was however not actually implemented

@dotnet-policy-service agree company="Digitec Galaxus"

Failing test looks - at first glance - not to be related to the commited change.

this test also failed in #1376 , but it doesn't occur on my machine, a bit strange.

Maybe because you're not using Windows-NetCore? It only fails for that...

hmm... i've tried all the possible combinations, win+core+cpu, win+core+gpu, win+framework+cpu, win+framework+gpu
by the way it also failed on other platforms in #1376
perhaps it's related to the gpu or cuda version, and does not appear every time

by the way you might also edit REALEASENOTES.md for this

Sure. Just pushed the adapted releasenotes. I assumed the next release is going to be a patch, and classified the change as bug.

@MiWeiss -- thanks for the contribution. I'll take a look later today.

The next release will be a patch.
I'm waiting for some more engineering resources to start helping out with TorchSharp, and then I'll use a couple of bugs as concrete work items to help introduce them to the code base. If this is essential, we can always do a quick release before then.

Failing test looks - at first glance - not to be related to the commited change.

There are some CI/CD instabilities. The machines we use to build with are inexpensive and often have trouble with resourcing. I rerun jobs all the time, and things usually go better with no changes to the PRs.

The merged build is failing because of some error in package signing, which has nothing to do with the PR.