Task: Convert PactSwift dependencies into local modules

❕ Problem Statement
PactSwift depends on PactSwiftMockServer, PactSwiftToolbox and PactSwiftServer for non-Xcode projects (eg: Swift on Linux). These were are all created and are maintained by PactSwift maintainer. The separation of responsibility and concerns is the preferred approach, but that then requires maintaining multiple repos, releases are done separately, and pact_ffi.h needs to be duplicated in different repos to support compatibility. It can get pretty hectic at release stage. Along with that, any issues, feature requests, bugs raised might not be raised in the correct repo's board (eg. PactSwiftToolbox handles logging, but the issue might be raised on PactSwifts issue board).
💬 Task Description

Convert PactSwiftMockServer, PactSwifToolbox and PactSwiftServer into a local swift package (module) so all PactSwift related is in one repository.
Release scripts to include rebuilding pactffi fixed to a version.
GitHub Actions updated.
Need to leave some messaging in the deprecated dependencies (PactSwiftMockServer, PactSwiftToolbox and PactSwiftServer) that PactSwift users should upgrade to the version that doesn't use those deprecated dependencies anymore (eg. v1.0.0)

👩🔧 Technical Design Notes

Package.swift with // swift-tools-version:5.3
/PactSwift/PactSwiftMockServer
/PactSwift/PactSwiftServer
/PactSwift/PactSwiftToolbox

🤝 Relationships

Other Related Issues:

This will not be possible with current SPM implementation as per SE-0201:

The local package must be declared in the root package or in other local dependencies. This means, it is not possible to depend on a regular versioned dependency that declares a local package dependency.

There has been an attempt in bringing the packages into one repo on branch tree/tech/local-packages. The framework builds and tests fine for iOS, macOS using xcodebuild and even carthage build --no-skip-current but when pulled into a project where PactSwift framework would be used, SPM complains with:
invalidManifestFormat("'\PactSwiftMockServer' is not a valid path for path-based dependencies;
use relative or absolute path instead.",...

Putting this on hold for the time being.


times() expectation not working -- always passes

The times() expectation is being ignored. If the expectation is set to 0 and the method is called, it passes. If the expectation is set to 1 and the method is never called, it passes.
<?php

class TestCase extends PHPUnit_Framework_TestCase {

	/**
	 * Test Zero Times Assertion
	 */
	public function testZeroTimesAssertions() {

		$foo = Mockery::mock('foo');
		$foo->shouldReceive('bar')
		    ->times(0);

		$foo->bar();

	}

	/**
	 * Test One Times Assertion
	 */
	public function testOneTimesAssertions() {

		$foo = Mockery::mock('foo');
		$foo->shouldReceive('bar')
		    ->times(1);

	}

}

$ phpunit
PHPUnit 4.3.0 by Sebastian Bergmann.

..

Time: 66 ms, Memory: 3.50Mb

OK (2 tests, 0 assertions)

Hey there, are you using the PHPUnit test listener? If not you'll either need to use it, manually call Mockery::close() or use the new MockeryTestCase. The first two are detailed in the docs http://docs.mockery.io/en/latest/reference/phpunit_integration.html and the latter can be done by:
<?php

use Mockery\Adapter\Phpunit\MockeryTestCase;

class TestCase extends MockeryTestCase {
// your usual test code

Ah right, missed that bit!
This ticket is invalid then.

No problem!

@davedevelopment MockeryTestCase seems to be the only thing that works for me when I use PHPUnit's @runInSeparateProcess annotation. Neither Mockery::close() nor the listener seems to work for times(), once(), etc.

@kminh open an issue with a sample test and I'll see if I can take a look. I'd recommend using the MockeryTestCase or the equivalent trait anyway.


Line Separator Between Boards in v2.0

I think a nice addition to the new UI would be a line separator between boards.

yes, maybe if you even make them rounded instead, and deminish opacity a bit

Thanks. Actually, there is a line separator, but it's not visible enough. I'll reconsider this


[DOCS]

Description
I think in starting of the read-me, we have to know what is shorty, so, I want to keep shorty information first then the star, forks, etc. I also would like to add the contribution, and code_of_conduct files in the readme file and add screenshots after the introduction of shorty. It enhances the readme.
Screenshots

Additional information
No response

Can you please assign the issue to me under gssoc?

@iqrafirdose assigned


Clean way to shutdown

I have an app that needs to run as a separate thread as part of a larger project.  It's not serving traffic to the world, just single user in an already complex multiprocess app - this is just to provide an emulated ux.  It uses flask_socketIO.
I originally used socketIO.SocketIO.run(app...) which basically does a werkzeug run_simple.  However, that results in the werkzeug BaseWSGIServer being created for you and serve_forever() being called on it.  Fine, but socketIO.stop() uses deprecated environ mechanism for stopping the server.
To make this work more cleanly I instead create a werkzeug.ThreadedWSGIServer and set it's shutdown_signal True from inside the shutdown endpoint handler.  That works cleanly.  But it's not clear to me that this will continue to work / is supported.
It really does feel like there should be a way to shut the server down cleanly (ctrl-C / thread-term isn't it, I need to clean up a ton of stuff properly on exit).
I'm fine with not using run_simple - I get it hides some details and in particular doesn't allow access to the created WSGIServer which is what needs to be terminated.  Can we get a shutdown() method on BaseWSGIServer / more formally document the correct way to have the server's serve_forever() method exit.
To illustrate, this is roughly what i'm doing to start the server in the background and be able to quit it.  Yes, I know this isn't broadly applicable, shouldn't be used in production etc (my use case is local access only and needs threaded mode for structural reasons and it's really a web app so much as an emulation of hardware ux)
from werkzeug.serving import ThreadedWSGIServer
from flask_socketio import SocketIO  # type: ignore

def setup_websocket_connection():
    app = Flask("AppName")
    # ...
    # Create the wsgi server ourselves so we have
    # a handle to shut it down
    wsgi_server = ThreadedWSGIServer(
        host = '<IP_ADDRESS>',
        port = 5001,
        app = app)
    socketio = SocketIO(
        app,
        cors_allowed_origins = "*",
        async_mode = 'threading')
    web_socket = CustomClassWrapping(socketio)

    @app.route('/shutdown')
    def shutdown():
        # socketio.stop() defers to werkzeug via environs
        # which gives errors
        # web_socket.socketio.stop()
        wsgi_server.shutdown_signal = True
        return "Shutting down."

    # ... handlers ...

    def webserver():
        # The following just runs werkzeug.serving.run_simple
        # but that does not let us shut down cleanly
        # socketio.run(app = app,
        #              host = '<IP_ADDRESS>',
        #              port = 5001,
        #              use_reloader = False)
        wsgi_server.serve_forever()

    socketio.start_background_task(webserver)
    return web_socket

Seems like just adding a stop() method on BaseWSGIServer would do it, or documenting the shutdown_signal is supported.
I know I could also write my own WSGIServer class - but that seems like more than I should have to do, maybe I'm missing something.

Duplicate of #2208 , see https://github.com/pallets/werkzeug/pull/2208 for documented alternative.

I was sure I'd previously read those threads carefully.  I saw the solution with multiprocessing.Process - but I need werkzeug to be running in a thread not process, so there's no terminate() call that can be made.  To terminate a thread, you have to exit the method invoked by run() but that's infinite in the case of serve_forever() being called.
I had however missed that more or less what I was doing but calling wsgi_server.shutdown() instead was the right thing.  So in my case
from werkzeug.serving import ThreadedWSGIServer
from flask_socketio import SocketIO  # type: ignore

def setup_websocket_connection():
    app = Flask("AppName")
    # ...
    # Create the wsgi server ourselves so we have
    # a handle to shut it down
    wsgi_server = ThreadedWSGIServer(
        host = '<IP_ADDRESS>',
        port = 5001,
        app = app)
    socketio = SocketIO(
        app,
        cors_allowed_origins = "*",
        async_mode = 'threading')
    web_socket = CustomClassWrapping(socketio)

    @app.route('/shutdown')
    def shutdown():
        wsgi_server.shutdown()
        return "Shutting down."

    # ... handlers ...

    def webserver():
        wsgi_server.serve_forever()

    socketio.start_background_task(webserver)
    return web_socket

is the correct usage (this wasn't obvious to me first pass on the docs / thread FWIW).  Thanks for the encouragement to read again.

No, it's not, reread them again. There is no shutdown function anymore. Also read the first thread again, there is an example of threading and of multiprocessing. Pleas use Discord or Stack Overflow to ask further questions.


JAX version in Colab

Right now colab uses jax 0.1.69 and so it fails to import haiku.
I believe it would be better to add both jax and jaxlib as normal requirements, so when someone installs they get the correct versions of the dependencies.

Thanks for the report, we've avoided pinning jaxlib since afaik users should pick a specific distribution of this depending on their local setup (c.f. https://github.com/google/jax#installation).
I'm open to pinning a minimum version of jax, but  Currently at HEAD Haiku also relies on unreleased JAX. We need to track JAX commits relatively closely because we use some more niche features in JAX (e.g. we have a tracer for to_dot and a custom primitive for named_call) and both JAX and Haiku are synced to Alphabet's monorepo where libraries need to depend on each-other and build at HEAD.
I'm planning to do a new release this week (since we just flipped the default value of apply_rng in transform) and will chat with the JAX team to get their advice on how to make this dependency more explicit.

i see this is a work in progress but, just for your info, jax in colab has bumped to 0.1.72 and with dm-haiku-0.0.1 the minimal example on readthedocs currently throws a ValueError ...
ValueError: Apply must be called with an RNG as the second argument, the required signature is: apply(params, rng, *a, **k)
repro eg https://colab.research.google.com/drive/1ilWQduIWKfe1HxafUH6TZdGtzOkWbiav?usp=sharing

@matpalm I think this error has nothing to do with Jax, recently transform had a default argument changed making apply request and rng argument. To fix it just change the last line to this:
logits = forward.apply(params, rng, x)

oh yes! i must admit i didn't properly read that error message 🤦
i'll put a PR in and reference your solution, thanks!

This issue should be closed, yes?


Fix transaction bug introduced in 8f1f835

In 8f1f835 when attempting to refactor the transaction detection logic, I inverted the match (returning true if inside a transaction URL, not false if not inside a transaction URL) but forgot to invert the if statement to "OR" from "AND".
This commit fixes that, and adds some tests to ensure the mistake can't happen again.
Credit to @knewter who spotted this when I showed him my GOV.UK PR :(.
👍 for coding in the open, though!

Small consistency fix needed, the actual code change looks good.  Sorry I missed it during review.

@elliotcm Updated to include the consistency fix (currentUrl => currentPath).


ProgressController recalculatePercentage bug

AngularJS v1.4.5
angular-ui-bootstrap Version: 0.13.4
What to do:
See plnkr demo: http://plnkr.co/edit/zf2jb4?p=preview
Go inside the first textbox (100) and use Backspace to reduce it to 10.
The Problem:
The Bars are recalculated wrong.
The Origin:
First the watcher for "max" is proceeded for both bars.
Next the watcher for "value" is proceeded for only the first bar.
While calculating the totalPercantage the second bar has still the wrong percentage. See:
var totalPercentage = self.bars.reduce(function (total, bar) {
return total + bar.percent;
}, 0);
The Solution:
Recalculate the bar percentage:
var totalPercentage = self.bars.reduce(function (total, bar) {
bar.percent = +(100 * bar.value / bar.max).toFixed(2); //Bugfix
return total + bar.percent;
}, 0);

This sounds reasonable, although I'm a bit worried as to why the unit test does not capture this situation - can you file a PR with this fix?

There is also a problem with removing an item, because recalculatePercentage is still calculating with the removed one including.
I found a solution with recalculating after removing:
this.removeBar = function (bar) {
this.bars.splice(this.bars.indexOf(bar), 1);
this.bars.forEach(function (bar) {   //Bugfix
bar.recalculatePercentage();
});
};
I updated the Plunker: http://plnkr.co/edit/zf2jb4?p=preview


Adding ingress.cilium.io/tls-passthrough to any one ingress breaks all ingresses

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?

When using cilium ingress, adding ingress.cilium.io/tls-passthrough to any one ingress breaks it and all other ingresses in cluster. All ingresses fail with curl: (56) Recv failure: Connection was reset
The issue occurs, no matter if ingressController.loadbalancerMode is in shared or dedicated mode

Cilium Version
v1.15.1
Kernel Version
6.1.80-talos
Kubernetes Version
v1.29.2
Regression
This is a new addition in 1.15, the functionality was not present in previous versions
Sysdump
No response
Relevant log output
No response
Anything else?
No response
Cilium Users Document

[ ] Are you a user of Cilium? Please add yourself to the Users doc

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Can you provide the sysdump file?
Could you provide some steps to reproduce the issue or installation parameters?

Hi,
I'm facing the same strange issue. I've tested it with v1.15.1 and v1.15.2 and the issue is present in both.
When you set the annotation "ingress.cilium.io/tls-passthrough: enabled" on an ingress, only that ingress is working.
The rest of ingress routes, if they are plain text HTTP, they keep throwing error 502:

Attached is the cilium sysdump.
cilium-sysdump-20240314-204252.zip
Cilium is installed via Helm without kube-proxy and the ingress service is set as 'NodePort:
helm install
cilium
cilium/cilium
--version 1.15.2
--namespace kube-system
--set ipam.mode=kubernetes
--set kubeProxyReplacement=true
--set securityContext.capabilities.ciliumAgent="{CHOWN,KILL,NET_ADMIN,NET_RAW,IPC_LOCK,SYS_ADMIN,SYS_RESOURCE,DAC_OVERRIDE,FOWNER,SETGID,SETUID}"
--set securityContext.capabilities.cleanCiliumState="{NET_ADMIN,SYS_ADMIN,SYS_RESOURCE}"
--set cgroup.autoMount.enabled=false
--set cgroup.hostRoot=/sys/fs/cgroup
--set k8sServiceHost=localhost
--set k8sServicePort=7445
--set gatewayAPI.enabled=true
--set ingressController.enabled=true
--set ingressController.default=true
--set ingressController.loadbalancerMode=shared
--set nodePort.enabled=true
--set l7Proxy=true
--set envoy.enabled=true
--set hubble.relay.enabled=true
--set hubble.ui.enabled=true
--set prometheus.enabled=true
--set operator.prometheus.enabled=true
--set hubble.metrics.enabled="{dns,drop,tcp,flow,port-distribution,icmp,httpV2:exemplars=true;labelsContext=source_ip,source_namespace,source_workload,destination_ip,destination_namespace,destination_workload,traffic_direction}"

Additionally, when I define Ingress A with TLS/SSL via cert-manager pointing to service A, and add the "ingress.cilium.io/tls-passthrough: enabled" annotation on ingress B with service B, the ingress A forwards requests to same service B that is defined under the ingress B.
I think this is a bug in the ingress-controller

Thanks for opening the issue @nebula-it - and @dimidevops for providing the additional information via sysdump!
It looks like there are two issues with Ingress TLS Passthrough in combination with Shared Ingress. Both due to the fact that having different shared Ingresses (some with TLS Passthrough and some with HTTP(S)) leads to two separate Envoy Listeners - one that handles the TLS Passthrough case (implemented with Envoy TCPProxy network filter) and the other one responsible for HTTP(S) (implemented with Envoy HCM network filter)
Problem 1: Listener name clash
The two listeners have the same name listener - hence only one of them ends up in the configuration (in most of the cases the TLS Passthrough one which appears later in the configuration).
Shared CiliumEnvoyConfig (after translating the Ingresses) contains the two listeners with the same name listener (file ciliumenvoyconfigs-20240314-204252.yaml from the sysdump) whereas the applied config on Envoy only contains one listener with the name kube-system/cilium-ingress/listener (after prefixing the name with the k8s namespace and name of the CiliumEnvoyConfig)(e.g. file ./cilium-bugtool-cilium-drs7r-20240314-204252/cmd/envoy-config.json)
This is the cause for both mentioned issues by @dimidevops. In case the other non-TLS passthrough Ingress using HTTP (port 80) it fails because the filterchain of the existing listener doesn't handle non-TLS traffic- and in case the other non-TLS passthrough Ingress using HTTPS (port 443) - it uses the Passthrough (that even ends up on the wrong service)
Problem 2: TPROXY redirection to different listeners with same frontend service port
After solving the name clash, i would still expect an issue with TLS Passthrough and HTTPS using the same "frontend" port 443 on the Ingress Service that is handled by different Envoy listeners. The current implementation (based on TPROXY) wouldn't be able to conditionally (HTTPS or TLS Passthrough) forward traffic to one of these two Listeners.
This is also part of the reason why problem 1 results in the applied listener retrieving all the requests for all the shared Ingresses (even though resulting in the 502 or TLS passthrough to the wrong service).
To solve this, the two use-cases should be combined into one Envoy listener.

The issue occurs, no matter if ingressController.loadbalancerMode is in shared or dedicated mode

@nebula-it This should only occur in combination with Shared Ingress. Because a dedicated Ingress can either uses TLS passthrough or not. It would be nice to have a sysdump with dedicated mode. @dimidevops are you able to reproduce this one?

Hi,
In the previous cluster, I forgot to mention that I manually edited the k8s 'cilium-ingress' service to be as 'NodePort' instead of 'LoadBalancer'. This is because I was running a demo cluster on metal and didn't have any automatic LB services.
In this new cluster I've deployed metalLB to provide IP range pool for the default 'LoadBalancer' service that the cilium ingress creates.
To test everything I've deployed kubernetes-dashboard and created a simple ingress for it:

Service:

Ingress:

I can now access the dashboard and it works with the label 'ingress.cilium.io/tls-passthrough: enabled'

Attached is the sysdump till this point.
cilium-sysdump-20240318-182146.zip
Another application that I have deployed is the simple jmalloc/echo-server, with ingress defined as:

Service:

Ingress:

On port 80 I get the redirection to https with the correct domain that is defined above:

But on port 443 I get a connection reset:

Attached is the sysdump after this new ingress was deployed.
cilium-sysdump-20240318-183229.zip
Also, idk if it is possible to define the service for the shared ingress-controller via annotations or during helm install as 'NodePort' instead of the default 'LoadBalancer', because 'NodePort' is the most common type of service for on-prem clusters running on metal.
Let me know if you need more info

Hi,
The 2nd Ingress for the echo apps now works, I had some typos in my curl command.

It seems like when we use dedicated ingress per app, there is no mixing of traffic or errors inside the envoy proxy when using the 'tls-passthrough' annotation on the defined ingress. This is an okay case if we run on cloud and we can spin up LB automatically, but it's a nightmare if we use external LB and have to edit each ingress service and map the node ports.
Let me know if you need more info.

I've reverted to shared ingress using 'NodePort' and HAproxy as external LB in TCP mode.
The result is both ingresses serve the same service, which is the last defined service in the last defined ingress
Echo-a ingress:

Dashboard ingress:

I'm 100% sure now that the shared ingress-controller and envoy config is mixing things up and breaking the shared feature.
Attached is the sysdump
cilium-sysdump-20240318-191509.zip

Hi @mhofstetter will there be a release with fix soon or do you need more info from my end?
Thank you

Hey @dimidevops really appreciate you jumping in and providing the data. I had some things to take care at home and wasnt able to play with my k8s cluster.
I did try this from scratch last night with cilium v1.15.2 and I can confirm your findings, the issue only appears when using shared ingress, with dedicated ingress it works as expected.
Happy to help if any more data is required but I think @dimidevops got it all :)

Hey @dimidevops & @nebula-it
Thanks for verifying that it's working as expected with dedicated Ingresses. No more info required.
I opened the following draft PR that tries to address this issue: https://github.com/cilium/cilium/pull/31646


Specify FIP pool + subnet for a particular node pool

In certain cases we need to have a node pool that needs to have FIPs assigned (for our use case internal FIPs only).
Internal traffic should use FIP as an outgoing IP. They could random, no need to keep on node upgrade.
External traffic should still use router external IP.
This node pool could be shared with any other pods. Our deployment will have specific node selector for such nodes.
Would be great if this could be done automatically using kubernikus API.
cc @BugRoger @databus23

What is the actual requirement? You want to avoid NAT on the LB?

LB is incoming traffic, the request doesn't relate to it.
The requirement is already in the main message: we want internal outgoing traffic to have per-node FIP. Currently all outgoing traffic has router external IP.


Use NVD API key from environment

When doing mvn release:perform, NVD download is very slow with 8s between downloads instead of 2s without an API key, but running mvn -DnvdApiKey=... release:perform does not seem to provide the API key. Setting it in the environment before running mvn release:perform with this config should work.

it doesn't work with release because Maven forks the JVM during release procedure, it worked fine for the workflows


not working

bro its been a hour that i build and it still not get done..

yuh thats defo not normal could you send me both log files? (components/roseui/roselog.log & rosecompile.log)

you prob forgot to disable your anti virus

@sxzk1


Update dependency community.crypto to v2.16.2

This PR contains the following updates:

Package
Type
Update
Change

community.crypto
galaxy-collection
minor
2.10.0 -> 2.16.2

Release Notes

ansible-collections/community.crypto (community.crypto)
v2.16.2
Compare Source
=======
Release Summary
Bugfix release.
Bugfixes

acme_* modules - directly react on bad return data for account creation/retrieval/updating requests https://github.com/ansible-collections/community.crypto/pull/6822).
acme_* modules - fix improved error reporting in case of socket errors, bad status lines, and unknown connection errors https://github.com/ansible-collections/community.crypto/pull/6844).
acme_* modules - increase number of retries from 5 to 10 to increase stability with unstable ACME endpoints https://github.com/ansible-collections/community.crypto/pull/6855).
acme_* modules - make account registration handling more flexible to accept 404 instead of 400 send by DigiCert's ACME endpoint when an account does not exist https://github.com/ansible-collections/community.crypto/pull/6811).

v2.16.1
Compare Source
=======
Release Summary
Bugfix release.
Bugfixes

acme_* modules - also retry requests in case of socket errors, bad status lines, and unknown connection errors; improve error messages in these cases https://github.com/ansible-collections/community.crypto/issues/6800).

v2.16.0
Compare Source
=======
Release Summary
Bugfix release.
Minor Changes

luks_devices - add new options keyslot, new_keyslot, and remove_keyslot to allow adding/removing keys to/from specific keyslots (https://github.com/ansible-collections/community.crypto/pull/664).

Bugfixes

openssl_pkcs12 - modify autodetect to not detect pyOpenSSL >= 23.3.0, which removed PKCS#12 support (https://github.com/ansible-collections/community.crypto/pull/666).

v2.15.1
Compare Source
=======
Release Summary
Bugfix release.
Bugfixes

acme_* modules - correctly handle error documents without type (https://github.com/ansible-collections/community.crypto/issues/651, https://github.com/ansible-collections/community.crypto/pull/652).

v2.15.0
Compare Source
=======
Release Summary
Bugfix and feature release.
Minor Changes

openssh_keypair - fail when comment cannot be updated (https://github.com/ansible-collections/community.crypto/pull/646).

Deprecated Features

get_certificate - the default false of the asn1_base64 option is deprecated and will change to true in community.crypto 3.0.0 (https://github.com/ansible-collections/community.crypto/pull/600).

Bugfixes

openssh_cert, openssh_keypair - the modules ignored return codes of ssh and ssh-keygen in some cases (https://github.com/ansible-collections/community.crypto/issues/645, https://github.com/ansible-collections/community.crypto/pull/646).
openssh_keypair - fix comment updating for OpenSSH before 6.5 (https://github.com/ansible-collections/community.crypto/pull/646).

New Plugins
Filter

- gpg_fingerprint - Retrieve a GPG fingerprint from a GPG public or private key

Lookup

gpg_fingerprint - Retrieve a GPG fingerprint from a GPG public or private key file

v2.14.1
Compare Source
=======
Release Summary
Bugfix and maintenance release with updated documentation.
From this version on, community.crypto is using the new Ansible semantic markup <https://docs.ansible.com/ansible/devel/dev_guide/developing_modules_documenting.html#semantic-markup-within-module-documentation>__
in its documentation. If you look at documentation with the ansible-doc CLI tool
from ansible-core before 2.15, please note that it does not render the markup
correctly. You should be still able to read it in most cases, but you need
ansible-core 2.15 or later to see it as it is intended. Alternatively you can
look at the devel docsite <https://docs.ansible.com/ansible/devel/collections/community/crypto/>__
for the rendered HTML version of the documentation of the latest release.
Bugfixes

Fix PEM detection/identification to also accept random other lines before the line starting with -----BEGIN (https://github.com/ansible-collections/community.crypto/issues/627, https://github.com/ansible-collections/community.crypto/pull/628).

Known Issues

Ansible markup will show up in raw form on ansible-doc text output for ansible-core before 2.15. If you have trouble deciphering the documentation markup, please upgrade to ansible-core 2.15 (or newer), or read the HTML documentation on https://docs.ansible.com/ansible/devel/collections/community/crypto/.

v2.14.0
Compare Source
=======
Release Summary
Feature release.
Minor Changes

acme_certificate - allow to use no challenge by providing no challenge for the challenge option. This is needed for ACME servers where validation is done without challenges (https://github.com/ansible-collections/community.crypto/issues/613, https://github.com/ansible-collections/community.crypto/pull/615).
acme_certificate - validate and wait for challenges in parallel instead handling them one after another (https://github.com/ansible-collections/community.crypto/pull/617).
x509_certificate_info - added support for certificates in DER format when using path parameter (https://github.com/ansible-collections/community.crypto/issues/603).

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Deprecated by https://github.com/Alfresco/alfresco-ansible-deployment/pull/755


API ID and Hash risk

is it risky to use API ID and HASH of a telegram account? if it is then which one is at risk  the one I used API & HASH from or the one I logged in this bot. previously one of my account got banned I don't know why but I was using API & HASH from.

There have been no such cases in my memory, if you don't want to, you can not use


Hide DNP val/ref

I tried to tinker around and look through old issues but I can't seem to find this feature.
I'd like to have an option to hide text(s) only of components which are not going to be mounted, because of variants/DNP. It's already fine as it is, but I think it would be clearer to not even have unneccessary values on the board.
Maybe it can be done more easily by hiding them directly from KiCad (temporarily)?
For my use case, only values can be hidden, but maybe also hiding references can be useful to someone?
Also, the possibility to differentiate the colors of SMD/THT could be useful to many I believe. I don't know if that's feasible.
Sorry if these are already been asked, and thanks for all your work.

Well, I planned to leave References visible, which are physically on the board even if they are DNP, so I agree with you on that. Values, on the other hand, are not.
Even if the DNP components are never highlighted when hovering over the component list, the Value of DNP components on the board can be misleading.
I believe a switch to hide Values which are not actually on the board due to DNP/variants would be useful.

I think it's not values that should be hidden but all of fabrication layer for footprints that are dnp.
Problem is with current architecture it's very unlikely to be implemented because graphics are processed before dnp components are determined.
Maybe in v3 or when/if the data format changes.

That's a bummer, I'll wait patiently.
What about the different color for SMD and THT?

There are already 6 different colors that pads can be rendered and not a lot of color space left to differentiate stuff in 2 themes and 3 highlight modes. I suggest you use the checkbox and mark when checked features to highlight whichever components you want.

I see, well it's not a big deal anyway, just a suggestion. I was more interested in the hidden Value for DNPs. Thanks.
For anyone interested, as a workaround I'm using a priority field so as to sort THT components last.


LinearProgress component's progress bar color is not alterable through props

Doesn't seem like I can alter the progress bar's color through the style prop or any other prop on LinearProgress, am I missing something?

you're not missing anything.  a quick read through the source code a few days ago showed me it's hardcoded to the primary1Color var.
i agree this should be a prop available on circular and linear progress bars as well as the refresh indicator

Fixed this issue for LinearProgress and RefreshIndicator components in pull request #2206.
The CircularProgress component actually already had a color prop :+1:

The fix for this has been merged into master.

I think it should be possible to change the root color too (currently it is hard coded to primary3Color).

Nevermind, I just realized I can override the root style already.


Unable to add/edit Users in the policy under Authorizations tab in Edit Collection

Describe the bug
It is not possible to add or update users while trying to add any policy under the authorizations tab in the Edit Collection section. Upon clicking the Edit policy button, there is no place for adding users.
To Reproduce
Steps to reproduce the behavior:

Click on the edit button on the collection home page
click on the authorizations tab
Click on the edit policy button available next to any policy
No option for adding/updating users to the policy
Please see below video walkthrough for above steps
https://youtu.be/Ui-7hNQSgLY

Expected behavior
List of Epeople/groups added in the policy should appear and provision for updating the list.
Related work
Link to any related tickets or PRs here.

Can confirm this is an issue. The workaround for now is to simply create a new policy & delete the old one.  Currently, existing policies cannot be fully edited.
Scheduling this tentatively for 7.1 as I don't believe there's time to get this into 7.0.

Thanks Tim. These bugs are identified while preparing user manual for 7.0. Have updated the manual based on available functionality.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Tim Donohue @.>
Sent: Monday, June 28, 2021 9:25:56 PM
To: DSpace/dspace-angular @.>
Cc: DSquare Technologies @.>; Author @.>
Subject: Re: [DSpace/dspace-angular] Unable to add/edit Users in the policy under Authorizations tab in Edit Collection (#1259)
Can confirm this is an issue. The workaround for now is to simply create a new policy & delete the old one. Currently, existing policies cannot be fully edited.
Scheduling this tentatively for 7.1 as I don't believe there's time to get this into 7.0.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/DSpace/dspace-angular/issues/1259#issuecomment-869803331, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABQHNKQRWGORZ5AF64CDHF3TVCLQZANCNFSM47MI65JQ.

Hi Tim,
Identical issue is with the community also. Updating Issue title from Collection to the Collection & Community.

Closing, this bug has been fixed.  I'm not sure when/where it was fixed, but is no longer reproducible in 7.5


Updated First Program with new examples and tips

Description
I added:

A quick introduction to what the console is, and a reference to a to-be-created tutorial for how to use the console
A warning about "using namespace std"
A note on order of operations under the mathematical operators
A note on how semicolon errors can be sometimes get the exact line wrong
Error messages and images for MSVC
A new Potential Error for having " inside of a string
A minisection for using std::cout; vs using namespace std; (could probably come later?)

I changed:

Wording in multiple places to have clearer grammar and more consistent diction
Clarifications that I felt were left pretty vague for a beginner, and emphasis on certain warnings
Suggesting using std::cout; instead of using namespace std;

Type of Change

[ ] ✨ New feature (non-breaking change which adds functionality)
[ ] 🛠 Bug fix (non-breaking change which fixes an issue)
[ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🧹 Code refactor
[ ] ✅ Build configuration change
[x] 📝 Documentation
[ ] 🇺🇸 Translation
[ ] 🗑 Chore

Thank you for submitting the PR. It significantly improved the lesson!


Temporarily sidestep pyobjc issue

https://travis-ci.org/PhilipTrauner/cmus-osx/jobs/315389105

1 minute too late 😉 ➡ 650fee6

https://devguide.python.org/#branchstatus Python 2.6 went EOL in 2013 and 3.3 went EOL earlier this year.  Supporting 4 versions of Python is probably sufficient.


Single feedback topic

This PR was successfully deployed to production by CircleCI build 522 at 2018-09-03 14:17 BST.


Custom RequestTransform function not work

Describe the bug
Now, I use yarp to be gateway service in Dapr runtime.
And I need to forward most of the requests to the sider-car of gateway service.
By custom RequestTransform to rewrite url path, but it not work.
sample code repo：
https://github.com/geffzhang/TyeAndYarp/blob/master/ReverseProxy/DaprTransformProvider.cs
Thanks for help.

sorry , it's my mistake, the url I test lost service name.


Typescript definitions for intellisense

Hi, am raising this as an "issue" but please feel free to close if wrong forum for enquiry.
Am used to pulling in the typescript community stub definitions whenever I use a popular library so that I have immediate access to autocomplete etc within Editor / IDE - eg  Angular.  Although, 100s of typescript definitions now exist covering every popular library I tend to regularly use in JS, I have noticed that Ramda is conspicuously absent. For instance, lodash and siblings have such defs.  More info here
Please can anyone tell me if I have missed something etc, or best alternatives. Will ask on gitter now too.

IIRC @donnut was working on typescript annotation for ramda but that was a while ago. maybe he could answer?

@buzzdecafe  - thanks for reply.  As per gitter conversation, have discovered that git repo at donnut/typescript-ramda is currently still active (up to version 0.18 at least).

@arcseldon While Ramda still doesn't have its own .d.ts, with TS 2.0 you can now get these types installed and referenced with just npm install --save @types/ramda (ref).

On the topic of a .d.ts built in to the main repo, would there be interest in this? What would considerations there look like?
Context: I'm in the Angular boat as well, so having a need for Ramda TS definitions, I started trying to integrate the existing commits across the network.

Adding to @tycho01's comment, I'm also using ramda on a daily basis (and will for the foreseeable future 😉) in TypeScript and Angular 2 context and I'd be happy to help maintaining the *.d.ts if they land in the main repository too.

If there's enough interest, and people willing to commit to keeping such up-to-date, I would have no problem seeing these in the repo.  I don't know how much of a commitment that it.  I have yet to give either Typescript or Flow a serious test.

I'd tried replying earlier, but it seems that hadn't gotten through.
I imagine keeping up to date with Ramda releases in itself shouldn't so much be a bottleneck. Some of the typings can be annoying at the moment (-> there not being a great way to handle currying until hopefully variadic kind support as mentioned by @blakeembrey in the linked thread), but for the most part I imagine the typings would require updates largely for edits actually affecting the API surface.
That said, TS inference isn't perfect yet, meaning in certain cases the user may still want to manually annotate types (unfortunate for map on tuples / heterogeneous objects, looking forward to progress there). But such are the woes of TypeScript users.

Could this be considered resolved with the typings at types/npm-ramda?

@tycho01 This issue is to bundle typings, as opposed to having them externally.

@andy-ms: we'd discussed that in here, but ended up deciding against it for the time being.

Semi-related, the quest to improve typings for Ramda has pushed me to try and further flesh out the TypeScript features for type-level programming, see my PRs here.
I think there's nice synergy between type inference and fp libs like Ramda -- writing typings with good inference is tough enough that it helps a lot to be able to just hook into existing typed functions, while on the other hand, it's especially in the functional paradigm that static typing adds value.
So it's still WIP, but I hope this could both help draw more people toward Ramda, as well as, given some luck on these PRs, help TS gain some extra ground to fans of e.g. PureScript / Elm.


Better translation logic and handling

Internationalization takes a lot of efforts, repeated code and extra files. There is a need to separate this logic and files to make it more readable, understandable and clean/clear.

Fixed in https://github.com/maddevsio/comedian/commit/0a26aee3db247642ef3f2fc69a35044a7adb464a


Parcel absolute path import issue

🐛 Bug Report
Parcel build tool supports absolute path style import import A from '/components/A.
To make Jest able to parse this import style, I added this to jest.config.js
{
  moduleNameMapper: {
    '^/(.*)$': '<rootDir>/src/$1',
    '^~/(.*)$': '<rootDir>/$1',
  },
}

Everything is fine until I jest.mock a module in absolute path style
jest.mock('/components/A')

Error occurs when the test is run:
Test suite failed to run

    Configuration error:

    Could not locate module /Users/user/Documents/playground/parcel-jest-demo/src/util.js mapped as:
    /Users/user/Documents/playground/parcel-jest-demo/src/Users/user/Documents/playground/parcel-jest-demo/src/util.js.

    Please check your configuration for these entries:
    {
      "moduleNameMapper": {
        "/^\/(.*)$/": "/Users/user/Documents/playground/parcel-jest-demo/src/$1"
      },
      "resolver": null
    }

Error is thrown in test when the module '/components/A' is imported in source code.
To Reproduce

config jest.config.js as above
create a test for a component which import A from '/A'
jest.mock('/A') in the test
Run the test

Expected behavior
Should not throw error.
Link to repl or repo (highly encouraged)
https://github.com/chauchakching/parcel-jest-demo
Run npx envinfo --preset jest
System:
    OS: macOS 10.14.5
    CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
  Binaries:
    Node: 8.16.0 - ~/.nvm/versions/node/v8.16.0/bin/node
    Yarn: 1.16.0 - /usr/local/bin/yarn
    npm: 6.4.1 - ~/.nvm/versions/node/v8.16.0/bin/npm
  npmPackages:
    jest: ^24.8.0 => 24.8.0

Confirmed, seems to be a regression introduced in v24


README is "wrong"

You say "are you getting one of the two following errors" and then show three. Which one is the error?

True, I ended up adding a third example, rendering that 'two' obsolete. Fixed in https://github.com/danielhenrymantilla/fix_hidden_lifetime_bug.rs/commit/345a91bbb9904be0e8ccc36c129d22030f555652


Adds PR template per contributing guidelines

What:

[ ] Bug Fix
[ ] New Feature
[x] Docs

Description:
The CONTRIBUTING.md file links to the PR template that isn't there. This adds the one used from PEST and I added a docs line as well.

One thing about this PR template is that it shows tasks as "undone". There might be a better way to do that but before I reinvent what is there in Pest I'll let it be for now.


pull request for e2e test at 11/16/2016 10:15:07

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

Details

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Ad 60702 add cdn to allowed list

@ilyaMiropolsky : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Debug logs should trace a 302/301 when pulling an image

Just got done debugging some image pull problems. It'd be helpful if when pulling images redirects are noted in the logs

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

Why not. Sounds like valid debug info.

@LK4D4 , @thaJeztah - is this still ongoing ?
I want to give it a try.

I don't think anyone is working on it, but also must add that this is the only request, and only time I've seen it requested, so it may depend on the amount of code to maintain if it will be accepted

Let's close this one in favor of https://github.com/moby/moby/issues/6927


Add TypeScript typings

This PR adds typings for the TypeScript language, so that users will have a fully typed experience.

@marvinhagemeister Thanks for the PR.
To make sure we don't break the definitions, is there a way for us to do an integrity check on our test suite? (I'm not a TypeScript guy, hence the question)

@caiogondim That'd be easy to add via a simple .ts file containing examples for fast-memoize. This file is then compiled by the typescript compiler and will fail automatically if there is an error.

@marvinhagemeister Would you mind adding that, so we make sure to always deliver a correct type definition?

@marvinhagemeister, @caiogondim just a heads up that the type definitions are invalid in TypeScript 2.8.3

Hi George.
Could you make a PR with a fix for it?
I'm not a TypeScript user.

Hey @caiogondim I opened #67 which adds typings and a sanity test

Closing that in favor of #67


dotnet 9.0 ios map not showing

VERSIONS

Maui.GoogleMaps - 6.0.1
.NET SDK - 9.0

IDE
Visual Studio Code (Mac)
PLATFORMS

[ ] Android
[x] iOS

ACTUAL BEHAVIOR
The shell of the map is  being loaded but the map it self not showing or not visible. (Custom objects are visible, like circle or pin)

On android works fine.
Am I missing something? I'm using the same api key for ios and android too.
In the sample the two platforms are using the same key too.

Have u tried on dotnet 8? If it doesn’t work there then the issue is with the key. Try putting my key instead of yours.

With you key its working,  do you have any hint how to create this type of key?

Just follow closely any guide out there in the internet


Bugfix: Logon resolve method should return session_token

Ref #615

@carolyncole Ah, thank you for telling me that. I will close the PR. I saw a comment:
# @return [String] the session token generated by the Mediaflux API
I thought the method was supposed to return the token but had been broken and no one noticed.


Add Support for the TRX Test Output Format

The TRX test output format is popular in the .NET space and is backed by Microsoft. The following similar project supports TRX format:
https://github.com/dorny/test-reporter

Yes, there are a few test output formats that could be incorporated into this action.

@RehanSaeed please give this a try:
uses: EnricoMi/publish-unit-test-result-action/composite@branch-add-trx
with:
    trx_files: "**/*.trx"

This is available as EnricoMi/publish-unit-test-result-action@v2, currently beta.


[Snyk] Upgrade org.mapstruct:mapstruct from 1.4.1.Final to 1.6.0

Snyk has created this PR to upgrade org.mapstruct:mapstruct from 1.4.1.Final to 1.6.0.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 14 versions ahead of your current version.

The recommended version was released on 2 months ago.

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:

🧐 View latest project report
📜 Customise PR templates
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.


Space CLI isn't functional. Remove that from the docs completely

Running npm install -g space-cli installs an incorrect npm package. Let's completely remove the concept of space-cli.
Referring to issue on fixing docs #28

Fixed in #38


Use getrandom rather than getentropy on Linux for random_get.

getentropy is limited to 256 bytes, so switch to getrandom.

LGTM! Matches rust-random which we already use in CraneStation/wasi-common :-)


Add code coverage for networking package as well

/assign @tcnghia mattmmoor

Map of Kansas counties is ready 💯


Create the Gradle versions of the quick-start repos

This will be helpful for people using gradle to directly close and set up their IDEs.

High level Steps:
Simply add the necessary gradle file(s) to the root folder(same level as POM.xml). That's it
Let me explain the steps below, if it helps-

Fork the hello-world git repo https://github.com/authorjapps/zerocode-hello-world.git. That means, once you forked, you get this linked to your GitHub account.
Then clone this to your local disk and import/setup at your IDE(e.g. IntelliJ or Eclipse)
For sanity(optional step), do mvn clean install -DskipTests at the root folder(same level as POM)
Now add the necessary gradle file(s) to achieve the same as the above step what the POM does. That means, in the gradle file, add the necessary dependencies. You should/needto add exactly the same dependencies as of the POM.xml.
Then compile/build/run using gradle commands. It should work
That's it. Job done. (No source code change is needed)
Raise a PR against us and we will approve and merge to master.

Hi ,
I have completed the task . Could have a quick look and see this is what is required.

PR approved n merged. Thanks @umangsingh123 👍


Incompatible with Sophisticated backpacks

Causes the auto pickup and pickup upgrades of sophisticated backpacks to make items only stack to 2
on 1.16.5

I haven't looked into this, but I'm unlikely to do any updates for 1.16.5.

Please re-open if this is still an issue that needs looking at.


Package.makeJar deletes folder recursively

steps
Call Package.makeJar with jar set to an existing folder.
Exhibited in a plugin (sbt/sbt-assembly#216), but can probably also be exhibited by setting the a path for packageBin, ... which is a directory.
problem
Here's the relevant code:
  def makeJar(sources: Seq[(File, String)], jar: File, manifest: Manifest, log: Logger): Unit = {
    log.info("Packaging " + jar.getAbsolutePath + " ...")
    IO.delete(jar)
    log.debug(sourcesDebugString(sources))
    IO.jar(sources, jar, manifest)
    log.info("Done packaging.")
  }

The code assumes that jar is a file and deletes it. If however jar is a folder, it will get recursively deleted.
expectation
My expectation is that any code which is tasked with writing out a regular file should overwrite existing regular files but not a folder. Hence, makeJar should error out when jar is anything but a regular file (or non-existing).
notes

Can be easily changed by adding a guard there (if (jar.isFile() || !jar.exists())).
There are potentially other occurrences of the same problem.

Thanks for the detailed report. Do you mind sending in a PR?, otherwise I'll fix it myself.

I can send a PR, if you tell me for which branch :smile:

https://github.com/sbt/sbt/tree/0.13.14 please


Auto find ips

Modified photon driver to search for tenant/project/VM IDs from photon given the target URL (photon controller IP). The plugin doesn't need any more config except the target URL.
Testing is in progress but I'd like comments on the approach.

@luomiao can you please review?

Ping for a review.

vmdk_plugin/drivers/photon/.photon_driver.go.swp
Remove the temporary file?

This seems adds a big loop in order to get the project and VM IDs. Is there a reason to do so?

Basically go thru all tenants and figure the tenant, project and VM IDs for
the VM. I'm not making the assumption that there is a only a single project
in the photon controller config. User only needs to give the target URL.
On Feb 24, 2017 1:00 PM, "luomiao"<EMAIL_ADDRESS>wrote:

This seems adds a big loop in order to get the project and VM IDs. Is
there a reason to do so?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/vmware/docker-volume-vsphere/pull/920#issuecomment-282223828,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APHseODAZAg1CZ1LiDqTf6KyjOTwzg_cks5rfocOgaJpZM4MC7Ry
.

But it seems this is only for getting the project ID and VM ID for the local node?
Do you think it's possible that we can get this information from the node instead of checking with the Photon endpoint?
For example, if Photon created some file including the project/VM ID and stored it on this VM, then there is not need to talk to remote Photon endpoint and go through this expensive loop to get this local information. We can check with Photon team to verify if there is already some file on the VM. And if it's not there, maybe we can check if they can add this feature.
Using a multi-level loop in order to achieve some local information seems not very efficient.

Yes, in fact this PR changes the assumption that there is a file on the
node that had this information. And yes this code is definitely not optimal
but it's more or less temporary till the meta data service of photon is
available. I'd love to have a whoami() type API from photon. But after
discussion with the photon team this was the approach advised given the
existing APIs
On Feb 24, 2017 1:28 PM, "luomiao"<EMAIL_ADDRESS>wrote:

But it seems this is only for getting the project ID and VM ID for the
local node?
Do you think it's possible that we can get this information from the node
instead of checking with the Photon endpoint?
For example, if Photon created some file including the project/VM ID and
stored it on this VM, then there is not need to talk to remote Photon
endpoint and go through this expensive loop to get this local information.
We can check with Photon team to verify if there is already some file on
the VM. And if it's not there, maybe we can check if they can add this
feature.
Using a multi-level loop in order to achieve some local information seems
not very efficient.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/vmware/docker-volume-vsphere/pull/920#issuecomment-282228048,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APHseJKFsTbsMKCoQ_Dnq1F0mYDCINjKks5rfo2KgaJpZM4MC7Ry
.

@govint Are you still working on this PR? Can we close and post when it is ready?

Currently I'm prioritizing the docker issue (mem. corruption and plugin crash). I need to address @luomiao comments for this PR.

@govint Can you close the PRs which you do not want to be reviewed/merged yet ? It's confusing to have them , I keep wasting time on checking if they need review.
You can always reopen when you are ready.

Closing for now, will reopen once Photon supports the mgd. plugin.


iOS 5.1 SDK Seems to Break Scalars

"No visible interface for 'NSNumber' declares the selector int32_tValue"
Here's the generated code that's throwing that error:

- (int32_t)idValue {
	NSNumber *result = [self id];
	return [result int32_tValue];
}

- (void)setIdValue:(int32_t)value_ {
	[self setId:[NSNumber numberWithInt32_t:value_]];
}

How does one update the templates? I just installed mogenerator today and I'm trying to compile a project for the first time. I'm getting errors in what appears to be the Generated models. Does that mean I have up to date templates? I did install with homebrew if that matters.


Ignore sequential duplicate history entries

Previously when the same command had been issued several times in a row,
users would have to press the up arrow an equal number of times to get
past it in the history. Some users found this tiresome.
This commit changes the Readline filter to filter out sequential
duplicate history entires in addition to blank ones.
This fixes #68.
This PR also includes the changes from #251 but will be rebased on master before merging.

Left a bunch of minor comments, but overall this looks great. Thanks, Calle!

Thanks for reviewing @georgebrock! Do you want to look it through one last time before I merge?

Looks good to me!

Great! I'm squashing and merging.


RUNTIME ERROR: Field does not exist: groups

$jsonnet -J vendor -m manifests example.jsonnet
RUNTIME ERROR: Field does not exist: groups          vendor/kube-prometheus/prometheus/prometheus.libsonnet:67:19-43 object <anonymous>         During manifestation

@Icedroid We're running into this when we copy and paste the configuration in the documentation, it seems to be when specifying rules: {} and if it's empty this error shows.
Example generating the error:
      prometheus+:: {
        names: 'k8s',
        replicas: 1,
        rules: {},
      },

Example fix (remove empty rules):
      prometheus+:: {
        names: 'k8s',
        replicas: 1,
      },


Where is the automatic breadcrumb ?

Where can we enable automatic breadcrumb like this in swift?
https://github.com/getsentry/sentry-swift/blob/master/docs/advanced.rst
SentryClient.shared?.enableAutomaticBreadcrumbTracking()

We're still working on this feature. Are you using Android, or a Java server-side framework?

Thanks for response.
Im using Android. Do you have a deadline already ?

No timeline yet, but we're actively working on improving Android. I made a new ticket #347 if you want to follow it or if you have any advice on implementation.


Persisting macros to new xlsm results in Workbook_Open method not working

After the changes made for issue #606 i am now able to put the macros onto the newly written workbook, but any code in the ThisWorkbook excel object (which holds all methods relating to Workbook-wide code like Workbook_Open to do operations when you open the workbook, or Workbook_SheetChange to detect changes to any sheet in the workbook) no longer works.
From what I'm seeing, the newly-written xlsm file has a ThisWorkbook and a ThisWorkbook1, and it doesn't allow for the globals to work from ThisWorkbook, and I don't want to force end users to go into the code and move things over. I also can't delete ThisWorkbook1 from Excel's Visual Basic editor.
To show this, try doing the following:

make a new xlsm file called "buttonTest.xslm" and copy the following code into the ThisWorkbook object in the xlsm file.

Private Sub Workbook_Open()
Dim t As Range
Dim btn As Button
Set t = ActiveSheet.Range("A1:A2")
Set btn = ActiveWorkbook.ActiveSheet.Buttons.Add(t.Left, t.Top, t.Width, t.Height)
With btn
.Caption = "Testing"
.Name = "TestButton"
End With
End Sub

put the following code into a js file to run with Node.

var XLSX = require('xlsx')
var ws_name = "connect";
var wb = XLSX.readFile("buttonTest.xlsm", {bookVBA:true}); //reads in the file as a workbook
var ws = XLSX.utils.aoa_to_sheet([["Test", "123"]]); //array of array input, worksheet output
wb.SheetNames.push(ws_name); //add a sheet with the given sheetname
wb.Sheets[ws_name] = ws; //assign the worksheet to the sheet with given name
XLSX.writeFile(wb, "newpage.xlsm", {bookType:"xlsm"}); //write out the workbook with the given name and workbook type

run the js file and open the created xlsm file, "newpage.xlsm".

You'll see that there's a new sheet (as desired) but that the button that was supposed to be created on workbook startup doesn't show up and that there's a new object called ThisWorkbook1.

Also, by my local testing, it doesn't make a ThisWorkbook1 object if there is no code in the ThisWorkbook object.

Thanks for looking into this!  The fix is very easy this time :)
The worksheets and workbook have a properties tag that maps the VBA code names to the sheet names.
If you can tinker with the source, there are two changes:

in the function write_wb_xml, add a codeName:

-	o[o.length] = (writextag('workbookPr', null, {date1904:safe1904(wb)}));
+	o[o.length] = (writextag('workbookPr', null, {date1904:safe1904(wb), codeName:"ThisWorkbook"}));

If you make just this change, you will see the ThisWorkbook1 stuff is resolved.

in the function write_ws_xml, add a sheetPr tag with a codeName:

+       o[o.length] = (writextag('sheetPr', null, {'codeName': escapexml(wb.SheetNames[idx])}));

GitHub doesn't allow uploading XLSM files :( so you will have to download and rename to XLSM to verify:
Using XLSX 0.9.7 from NPM: broken.xlsx
Using the patches from the previous comment: fixed.xlsx
Please verify that the fixed file works.  We will push the change in the next release, hopefully tomorrow.

It works! But it seems like Excel doesn't like it. See attached for the dialog boxes that pop up after making the changes you suggested with the code i used at the start of this post.

Hmm what version of Excel are you using? I just checked the attached "fixed.xlsm" file against Excel 2016 and Excel 2007, both accept the macro and show the testing button:

@SheetJSDev I'm using 2013. the button still shows up appropriately, but those dialog boxes show up on first time opening the newly made workbook

@johnothetree I still can't reproduce in Excel 2013 :/

download https://github.com/SheetJS/js-xlsx/files/883177/fixed.xlsx
open a command prompt window and run:

cd Downloads
move fixed.xlsx fixed.xlsm

open fixed.xlsm

I see a message in the top bar:

I click enable editing and see the macro security warning:

After clicking enable content I see the macro worked:

For completeness, I included a complete demo in a gist: https://gist.github.com/SheetJSDev/decd392746c23195696efab1c80d66a2
Just download it and follow the README instructions.  On my computer the generated file works in Excel 2013 without the warnings you showed.

huh. yeah the gist works fine. maybe i put something in the wrong spot? whatever, looks to work fine! thanks for the help! i'll work with the official release when it's out!

@SheetJSDev , I am trying your solution, in the second change

in the function write_ws_xml, add a sheetPr tag with a codeName:

  o[o.length] = (writextag('sheetPr', null, {'codeName': escapexml(wb.SheetNames[idx])}));

what line in the write_ws_xml function should I add the tag?

@MiriamHershowitz no need.  https://docs.sheetjs.com/#vba-and-macros Workbook code name wb.Workbook.WBProps.CodeName, Worksheet code name wb.Workbook.Sheets[idx].CodeName

Workbook code name wb.Workbook.WBProps.CodeName, Worksheet code name wb.Workbook.Sheets[idx].CodeName

Do I have to set the code name?

Yes you do
On Wed, Nov 3, 2021 at 04:00 MiriamHershowitz @.***>
wrote:

Workbook code name wb.Workbook.WBProps.CodeName, Worksheet code name
wb.Workbook.Sheets[idx].CodeName
Do I have to set the code name?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/SheetJS/sheetjs/issues/615#issuecomment-958757666,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVQWQIEMKZ2WNWCZGFTOFQDUKD24NANCNFSM4DF2OLAQ
.

Yes you do
…
On Wed, Nov 3, 2021 at 04:00 MiriamHershowitz @.***> wrote: Workbook code name wb.Workbook.WBProps.CodeName, Worksheet code name wb.Workbook.Sheets[idx].CodeName Do I have to set the code name? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#615 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVQWQIEMKZ2WNWCZGFTOFQDUKD24NANCNFSM4DF2OLAQ .

I tried to set the CodeName but still can't see the macro buttons, I saw that the Workbook and Worksheet code name are automatically set, do I have to change it from the default value? and if so, what value?

Please share a sample file (you may need to rename to .xlsx to attach to the GH issue)

Please share a sample file (you may need to rename to .xlsx to attach to the GH issue)
I am trying to read the file MacroBook.xlsm and write it to MacroBook1.xlsm

`let workbook = XLSX.readFile(__dirname + '/xlsm/MacroBook.xlsm', { bookVBA: true });
XLSX.writeFile(workbook, __dirname + '/xlsm/MacroBook1.xlsm', { bookType: 'xlsm' });`
but after wrting I cant see the button MacroBook.xlsm has
MacroBook.xlsx
Thank U for trying to help...


Express should be a peer dependency of kangojs

Package Information

Name: kangojs
Version (as installed from npm): all

Describe the bug
Express should be a peer dependency.
KangoJS is suppose to mainly be a convenience wrapper around Express, it shouldn't bring it's own Express dependency but instead use the one in the project already.
Expected behaviour

Express should be a peer dependency.
Installation docs should be updated to reflect this

fixed in<EMAIL_ADDRESS>release


[Feature][Connector-file] file source plugin shard transfer and breakpoint resume transfer

Search before asking

[X] I had searched in the feature and found no similar feature requirement.

Description
Connector-file binary file type support shard transfer and breakpoint resume transfer
Usage Scenario
No response
Related issues
No response
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

help

Does binary file support breakpoint resume? If there are many files, can they be re extracted from the last failed file after failure? How to use it in offline mode?

Does binary file support breakpoint resume? If there are many files, can they be re extracted from the last failed file after failure? How to use it in offline mode?

Theoretically it is supported. If you have any questions, please create an issue


Turbolinks 5 compatibility

Adds support for Turbolinks 5 (7769f2c)

Fixes #15
checks if Turbolinks exists. If so, execute function on 'turbolinks:load'

otherwise, execute function on document load

Removes commented-out code from coffeescript (3dde3e1)

Works great for Turbolinks 5, but I can't get the sample app working if I force Turbolinks to an older version or remove it entirely.
Turbolinks 2.5.3

Add gem 'turbolinks', '2.5.3' to your Gemfile
bundle install
Restart server

Turbolinks is actually defined in 2.5.3, but the turbolinks:load event is not.
No Turbolinks

Remove turbolinks from your Gemfile
Remove //= require turbolinks from application.js
bundle install
Restart server

The error below causes the script to fail:

Uncaught ReferenceError: Turbolinks is not defined


release: v1.0.0a3

Signed-off-by: Mihai Bivol<EMAIL_ADDRESS>

@mihaibivol please update RELEASE-NOTES and CHANGES too. Also check that all authors are specified in AUTHORS file (kwalitee check authors v1.0.0a2..).

There is a past example: https://github.com/inveniosoftware/invenio-logging/commit/ea0ab764542e8658b160a5d56f7041df3657d11e


istioctl example: Modify the example display format of 'istioctl x version -h' and 'istioctl profile -h'

Please provide a description of this PR:
After executing istioctl x version -h and istioctl profile-h, the following information is displayed. You can see that the example printed in example has a problem with indentation. This pr modifiers it
➜  istio git:(master) ✗ istioctl x version -h
Prints out build version information

Usage:
  istioctl experimental version [flags]

Examples:
# Retrieve version information directly from the control plane, using token security
# (This is the usual way to get the control plane version with an out-of-cluster control plane.)
istioctl x version --xds-address istio.cloudprovider.example.com:15012

# Retrieve version information via Kubernetes config, using token security
# (This is the usual way to get the control plane version with an in-cluster control plane.)
istioctl x version

# Retrieve version information directly from the control plane, using RSA certificate security
# (Certificates must be obtained before this step.  The --cert-dir flag lets istioctl bypass the Kubernetes API server.)
istioctl x version --xds-address istio.example.com:15012 --cert-dir ~/.istio-certs

# Retrieve version information via XDS from specific control plane in multi-control plane in-cluster configuration
# (Select a specific control plane in an in-cluster canary Istio configuration.)
istioctl x version --xds-label istio.io/rev=default

Flags:
      --authority string     XDS Subject Alternative Name (for example istiod.istio-system.svc)
      --cert-dir string      XDS Endpoint certificate directory
  -h, --help                 help for version
      --insecure             Skip server certificate and domain verification. (NOT SECURE!)
  -o, --output string        One of 'yaml' or 'json'.
      --plaintext            Use plain-text HTTP/2 when connecting to server (no TLS).
      --remote               Use --remote=false to suppress control plane check
  -r, --revision string      Control plane revision
  -s, --short                Use --short=false to generate full version information
      --timeout duration     The duration to wait before failing (default 30s)
      --xds-address string   XDS Endpoint
      --xds-label string     Istiod pod label selector
      --xds-port int         Istiod pod port (default 15012)

Global Flags:
      --context string          The name of the kubeconfig context to use
  -i, --istioNamespace string   Istio system namespace (default "istio-system")
  -c, --kubeconfig string       Kubernetes configuration file
  -n, --namespace string        Config namespace
      --vklog Level             number for the log level verbosity. Like -v flag. ex: --vklog=9
➜  istio git:(master) ✗ istioctl profile -h
The profile command lists, dumps or diffs Istio configuration profiles.

Usage:
  istioctl profile [command]

Examples:
istioctl profile list
istioctl install --set profile=demo  # Use a profile from the list

Available Commands:
  diff        Diffs two Istio configuration profiles
  dump        Dumps an Istio configuration profile
  list        Lists available Istio configuration profiles

Flags:
      --dry-run   Console/log output only, make no changes.
  -h, --help      help for profile

Global Flags:
      --context string      The name of the kubeconfig context to use
  -c, --kubeconfig string   Kubernetes configuration file
      --vklog Level         number for the log level verbosity. Like -v flag. ex: --vklog=9

Use "istioctl profile [command] --help" for more information about a command.

Hi @Fish-pro. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Fish-pro: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
95c5852de9132e3f7572ecf2e6a73427aff88937
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes

/test release-notes


The security token included in the request is invalid.

My action:
      - uses: kazimanzurrashid/aws-lambda-update-action@v1
        with:
          zip-file: ./bundle.zip
          lambda-name: telegram-personal-bot
          AWS_REGION: ap-east-1
          AWS_ACCESS_KEY_ID: ${{ secrets.LAMBDA_KEY_ID }}
          AWS_SECRET_ACCESS_KEY: ${{ secrets.LAMBDA_ACCESS_KEY }}

Related discussion:

https://stackoverflow.com/a/47098678
https://github.com/99designs/aws-vault/issues/339#issuecomment-614713233

This is a common error when the aws credential does not has the required permission, in this case it is lambda:UpdateFunctionCode

In that case I suggest you make sure you have entered correct values in the repo secret section from the settings:


minimal query (URL) to show list of fatal production errors

this is all in sentry, work to clean up errors there should be more specific


statistics update on data page

as a user, i would like to have a visibility into the total volume in the network over the last 24h timeframe.
24h total volume = sum of all pools 24h volume.
BNT price = indication of the current bnt price in usd.
https://www.figma.com/file/3yED7o7TgoLwoEjV2EkRLL/Bancor-V2?node-id=1072%3A0

also, we would like to include the percentage of locked bnt from circulating supply.
locked bnt percentage = (total locked bnt) / (total bnt supply). normalize this value into percentage.
example:
locked bnt = 42105473.915841584158416
circulating supply bnt = 87868811.011974018147889204
locked bnt = 42105473.915841584158416/87868811.011974018147889204 = 0.47918565678 => 47.91%

I have added volume 24h and reactivated the swap 24h count.
@Velua to take over for part two

@Velua please see if the required data exist for this % locked.

Locked BNT as part of protection? Or are we talking about staked BNT liquidity?

bnt in pool.

@pingustar I've recently added the percentages in https://github.com/bancorprotocol/webapp/commit/53290721b2812d2e44a6476a51c4d2a69d1d3659
You'll find stakedBntSupplyPercent?: number on ViewRelay now.

seems that now staging shows half the value for total liquidity.
staging:

production:

@pingustar new commit c03956c03c8effdd4ecc366ed978dbb3e03bd298

staging issue comes along when cherry picking 5329072 and c03956c
on hold until fixed.

@ashachaf
@H34D and @pingustar are looking into this now

added to staging @ashachaf


Implement AttributedString UTF8 and UTF16 views

This adds a new UTF-8 and UTF-16 view to AttributedString, vending APIs similar to the underlying BigString's UTF-8 and UTF-16 view

@swift-ci please test

@swift-ci please test


Fixed google connection name processing

Name is now an object in the Google+ API that contains name.givenName (first name) and name.familyName (last name). Adjusting the method so it doesn't throw an exception when creating a user into the datastore.

+1

+1


absl FATAL flags parsing error

After I built the docker image, I found it failed to run. Error messages as below. I need help to fix it.
/opt/conda/lib/python3.7/site-packages/absl/flags/_validators.py:206: UserWarning: Flag --preset has a non-None default value; therefore, mark_flag_as_required will pass even if flag is not specified in the command line!

'command line!' % flag_name)

FATAL Flags parsing error:

flag --fasta_paths=None: Flag --fasta_paths must have a value other than None.

flag --output_dir=None: Flag --output_dir must have a value other than None.

flag --model_names=None: Flag --model_names must have a value other than None.

flag --data_dir=None: Flag --data_dir must have a value other than None.

flag --uniref90_database_path=None: Flag --uniref90_database_path must have a value other than None.

flag --mgnify_database_path=None: Flag --mgnify_database_path must have a value other than None.

flag --pdb70_database_path=None: Flag --pdb70_database_path must have a value other than None.

flag --template_mmcif_dir=None: Flag --template_mmcif_dir must have a value other than None.

flag --max_template_date=None: Flag --max_template_date must have a value other than None.

flag --obsolete_pdbs_path=None: Flag --obsolete_pdbs_path must have a value other than None.

Pass --helpshort or --helpfull to see help on flags.

Hi, could you share what command you ran before that error appeared? It looks as though no flags were provided to the script. We have some examples in the Running AlphaFold section that might be helpful if you haven’t seen them yet. You might also find the AlphaFold Colab to be a convenient way to run AlphaFold if you are OK with running a slightly simplified version.

I'll close this for now. If you think you did provide commands and still got this error then feel free to reopen with a description of how you ran AlphaFold.


Build System Support for Aarch64 #498

Added Vagrant support for the latest three versions of Ubuntu

Added a Vagrantfile

Added provisioning scripts for each version of Ubuntu

[RFC] Build System Support for Aarch64 #498

Question for @rianquinn and @connojd : I tested that Bareflank builds successfully in Ubunutu VMs for 16.04, 16.10, and 17.04. @cpavlina brought up a good point that we might want to just provide one ubuntu VM for vagrant so that we don't have to maintain all three. What are your  thoughts? Provide the option to build in different ubuntun ditros? Or just keep it to one version of Ubuntu?

Also, to use the provided Vagrant file, you can do the following:
vagrant up    # defaults to 17.10
vagrant ssh -c "cmake .. && make -j2"

Or you can pick a particular version of Ubuntu:
vagrant up ubuntu16_10   # picks the 16.10 VM
vagrant ssh ubuntu16_10 -c "cmake .. && make -j2"

I like the idea of having all of the versions we support so that it is easy to show instructions, but also provide scripts testing building. Couple of questions:

Is there a way to use a different hypervisor other than VirtualBox?
Does 6.10 need an update of cmake? We only need 3.6

Yes, you can use other hypervisors as the so-called "provider" for vagrant. I know that VMWare fusion is supported, and I sort-of got vagrant working with KVM at some point

I believe that Ubuntu 16.10 comes with cmake 3.5.2

Ok, for now, lets just support 17.04, and 17.10 moving forward. If VMWare Fusion is supported, we should leverage this to do our functional tests on the Mac Mini server we have in-house.
The only other comment I have is put all of the apt-get install commands onto a single line as it is faster.

Ok, I removed the provisioners and configs for Ubuntu 16.04 and 16.10, but I do not have VMWare Fusion, so I can't test out changes for that. It should already support VMWare, and you can add settings the same way as there are some currently for VirtualBox

LGTM. Once the tests are done I will merge.


[Feature request] SublimeTail support

Summary
It would be nice, if you add SublimeTail support.
Expected behavior
Highlight SublimeTail logs.
Actual behavior
If tab with Tail was opened for me, Ctrl+Shift+P → LogHighlight: Highlight Error/Warning → Enter → Tail log not highlight for me, I get message in status bar:
Unknown name for current view

Steps to reproduce
I install SublimeTail → I open log file → Tail: Tail File In New View → Tail tab open for me.

I change log file → I see changes in Tail tab. If I try highlight log in Tail tab, I get actual behavior.
Not helped
My User\Log Highlight.sublime-settings file:
{
    "log_ext": [ ".log", "Tail" ],
}

But I still get actual behavior.
Thanks.

Hi, Kristina
The reason of "Unknown ..." is that "Tail: chol..." is unsaved. Try to do again after saving. But it can be not good solution. What is "Sublime Tail"?

@poucotm, SublimeTail is package for working with logs. See Tail (Unix). If I have big log, I can see only last log changes. Example of work:

Try to do again after saving.

If I save file, SublimeTail not will work. It would be nice, if Log-Highlight will be highlight unsaved files too.
Thanks.

Hi, Kristina.
I've updated Log-Highlight to support unsaved file like 'Sublime Tail'.
But you also have to add some codes in Sublime Tail. Or request it.
In order to search base directories (to use links),  "absolute file path" is needed.
It is impossible to get a path from a unsaved file. But for 'Sublime Tail' you can set the file path as a setting of view. Add the codes like the following :
In "Tail/packages/tail/commands/tail_file_in_new_view.py"
...
sublime_view = self.view.window().new_file()
tail_view = get_tail_view(sublime_view=sublime_view, create=True)
tail_view.add_source(get_tail_source(filepath=filename))
tail_view.start()
sublime_view.settings().set('filepath', filename)

@poucotm, I add
sublime_view.settings().set('filepath', filename)

in last line of Tail/packages/tail/commands/tail_file_in_new_view.py, but I get same error.

You have to click a link in 'Summary View' for first time or change view once to use links.

I'm sorry, where I can find Summary View?
Thanks.

Did you check the version of Log Highlight?
It also has to be updated as 0.6.5.
When you run Log Highlight, Summary View will be displayed bottom of the window as default.

@poucotm, may you write step-by-step, what I need to make to have expected behavior? I can not understand, how I can get expected behavior.
Thanks.

add the codes

open the log and run "Tail: File In New View"

run "Log Highlight" for tailed Log

The first View before log updated

When the log contents changed, you can see updated in tailed log view

Thank you very much!

Hi, Kristinita
I've changed workaround for ST3 bug in v0.8.0. You can use links in Tail view directly without Summary View.


lwm2m : Add visibility into observer notification success/fail

Some applications use the Observer Notification mechanism to send a data payload.
If an observer notification is triggered by an update, timeout due to max period, or manual trigger, there is no feedback to the application that this has occurred or whether the notification was received and acknowledged by the server.
Currently there is a retry mechanism for notifications, but there is no timeout handling.
There is no visibility into this activity from an application point of view

Add a message_timeout_cb for notifications
Add external notification callback which is called when a notification is sent, acknowledged or timed out.

To add to lwm2m_engine.h :
`/* External Notification Type definition */
typedef enum
{
ENT_send=1,
ENT_ack,
ENT_timeout,
}ext_notify_type_t;
/* Function Prototype definition for external notification function */
typedef void (*ext_notify_t)(struct lwm2m_obj_path * path, uint8_t *token, uint8_t tkl, void *msg, ext_notify_type_t ent);
/* New Function to assign the function pointer for external notification */
void lwm2m_engine_set_ext_notify_fn(ext_notify_t fnPtr);`

To add to lwm2m_engine.h :
`/* External Notification Type definition */
typedef enum
{
ENT_send=1,
ENT_ack,
ENT_timeout,
}ext_notify_type_t;
/* Function Prototype definition for external notification function */
typedef void (*ext_notify_t)(struct lwm2m_obj_path * path, uint8_t *token, uint8_t tkl, void *msg, ext_notify_type_t ent);
/* New Function to assign the function pointer for external notification */
void lwm2m_engine_set_ext_notify_fn(ext_notify_t fnPtr);`

Sending the lwm2m obj path, token and msg pointer allows the user to track the notification process:
send includes all 3
ack sends only the token (which can be referenced to the send)
timeout sends only the msg pointer (which can be referenced to the send)

Sending the lwm2m obj path, token and msg pointer allows the user to track the notification process:
send includes all 3
ack sends only the token (which can be referenced to the send)
timeout sends only the msg pointer (which can be referenced to the send)

I think the simplest thing to do for notification ack timeout is to get msg->message_timeout_cb (in lwm2m_engine.c) to call engine_trigger_update (in lwm2m_rd_client.c). The subsequent failure of engine_trigger_update will then trigger retries.
This would simplify the Offline state for #32610

I created a draft Pull Request for this here : https://github.com/zephyrproject-rtos/zephyr/pull/36364
@rlubos When a first-time contributor submits a pull request to a public repository, a maintainer with write access must approve any workflow runs. Can you do this please?


Review visibility of public interfaces

Motivation
Some of the public interfaces inside this repository should not be public by default (e.g.: IDesignModeClient, etc.) as they are only used by components implemented by us that aren't meant to be replaceable by third party components.
In order to avoid exposing unneeded interfaces and make it convenient for us to mutate them without having to worry about breaking compatibility, we should review which public interfaces should remain public and which ones can be made internal.

Taking note of this in a design doc, this needs huge refactoring of the extensibility model, and dependency model to have any impact.


CFE: mismatch in how we treat -0 after constant-update

When enabling constant-update-2018, the following code:
const int x = 0;

const List<int> l = const [
  1,
  -x,
];

main() => print(l);

used to compile cleanly, but with the flag produces a compile time error:
bad_const.dart:5:3:
Error: Expected constant '-0.0' to be of type 'int', but was of type 'double'.
  -x,
  ^
bad_const.dart:8:17:
Info: While analyzing:
main() => print(l);
                ^
bad_const.dart:3:21:
Error: Constant expression depends on itself.
const List<int> l = const [
                    ^
bad_const.dart:3:17:
Info: While analyzing:
const List<int> l = const [
                ^
Error: Compilation failed.
Finished with a exit code: 1

@fishythefish can you take a first look - this unfortunately breaks existing code.

In particular, the issue here is that the Dart type of -0.0 should be int according to our rules.


Adding a new mic icon in voice command

Usually the text start voice command won't seem cool. Instead I can use these logo to make it more concise and clear and clean.

Here I can integrate this type of logo

program name?

#257 includes this issue


Can trl be combined with gym environment？

Unless the environments are text based I don't think so. Any specific environment you had in mind?


Rules are not being applied by most test functions

runWithReport(), runWithReturn(), runWithHTMLReturn(), and runWithHTMLReturn2() do not apply any rules - they don't pass rules through to the underlying run() fn:
def runWithReturn(notebook, executable=None, rules=None):
    name = run(notebook)

def runWithReport(notebook, executable=None, rules=None, collect_only=False):
    _ = run(notebook, filename=py_file)

def runWithHTMLReturn(notebook, executable=None, rules=None):
    name = run(notebook)

def runWithHTMLReturn2(notebook, executable=None, rules=None):
    ret_tmp = run(notebook)

Was closed by #124, github


Remove Geoapify

No longer needed, as we will use BigQuery lookups
Add some error messages when the Segment API key is missing

This was requested by EdgeCaser (PM): https://trello.com/c/2P4wHK9C/42-shift-country-lookup-to-google-apis

superceded by ga changes


[CI] Streamline project's CI

What it does

See this related proposal (#148)
What this PR does:

enhance our GH workflow to generate Blueprint packages for our supported operating systems and run our test suite on them.
only run Jenkins CI when merging on master or when we have reasonable suspicion(1) that the PR is related to Jenkins configuration changes. This will let us detect Jenkins update issues without having to merge to master first.

technically the CI step still runs, but it will successfully exit almost immediately for most PRs. The when condition is used in Jenkinsfile to inhibit running the Build and Sign and Upload pipelines stages.

This will save a lot of CI time and insure Jenkins executor are available when we really need them: when we merge to master and want new packages generated, signed and uploaded.
(1) Currently, a heuristic is used: when the word "jenkins" (case does not matter) appears in the PR title or PR branch name, we assume that the PR is related to Jenkins and so it's valuable to run Jenkins CI on it, like before this PR.
Note: a slight change in the Jenkins multi-branch pipeline configuration (from server web UI) was necessary for this to work. So far, we had one pipeline branch configured, triggered by either a merge to master or a PR branch change. In order for the PR's git branch name to be programmatically visible from  theJenkinsfile, it was necessary to split these into 2 separate pipelines branch configuration, each one "watching" for a single thing (master branch, PR-related branch).
Ref: https://issues.jenkins.io/browse/JENKINS-7554
How to test

This could be a bit tricky to fully test before merging. In theory one could create several PRs, based on this PR branch, testing all permutations of having jenkins or not in the PR branch name and PR title.
A simpler way :

look at the Jenkins CI step of this PR and confirm that it fully runs (both branch name and PR title contain jenkins, so that's what's expected)

Jenkins log

I created a test PR based on this PR's branch. The branch name and the PR title are jenkins-free. Verify that the Jenkins CI step was "streamlined" - it reports success but the log shows that it immediately bailed, e.g. Stage "Create Linux Installer" skipped due to when conditional

PR: #149
Jenkins log . Look-for Stage "Build" skipped due to when conditional, Stage "Create Linux Installer" skipped due to when conditional and so on.

also confirm that the GH actions run, and pass, and now include running our test suite.

Review checklist

[x] as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

as a reviewer, I agree to behave in accordance with the review guidelines

@thegecko Since you're the one who introduced the Jenkins CI step in the project, I'd like to get your approval for this change, or at least your sign-off on the general idea of it.

@thegecko I will go ahead and merge this PR. If you have feedback later, I'll work with you.

I will to do a follow-up: contrary to what I was expecting, Jenkins was "streamlines" when I merged, which is not what we want!


Do not overwrite refresh token with null

Prevent overwriting the refreshToken with null when no refresh token is returned in fetchAuthToken method
Fixes https://github.com/google/google-auth-library-php/issues/130

A cleaner solution would be to change updateToken to not merge in a null refresh_token, i.e.:
    public function updateToken(array $config)
    {
        // ** I removed "refresh_token" from here
        $opts = array_merge([
            'extensionParams' => [],
            'access_token' => null,
            'id_token' => null,
            'expires' => null,
            'expires_in' => null,
            'expires_at' => null,
            'issued_at' => null,
        ], $config);

        $this->setExpiresAt($opts['expires']);
        $this->setExpiresAt($opts['expires_at']);
        $this->setExpiresIn($opts['expires_in']);
        // By default, the token is issued at `Time.now` when `expiresIn` is set,
        // but this can be used to supply a more precise time.
        if (!is_null($opts['issued_at'])) {
            $this->setIssuedAt($opts['issued_at']);
        }

        $this->setAccessToken($opts['access_token']);
        $this->setIdToken($opts['id_token']);
        // ** I added this conditional here!
        if (isset($opts['refresh_token'])) {
            $this->setRefreshToken($opts['refresh_token']);
        }
    }

I had something very similar at first as well. I decided against doing it this way because it means that updateToken cannot set the refresh token to null under any circumstances, so someone calling updateToken manually would also need to call setRefreshToken separately.
If you think this isn't an issue, then I definitely agree that your proposed solution is cleaner.
Separately, it seems as though the 'expires' setting is doing no work at all - it is always overwritten by 'expires_at'. Perhaps I can remove this at the same time?

Just use array_has_key instead of isset and a caller will be able to set the refresh token to null.
Yes, we should definitely remove expires. This won't break BC since it's already being overwritten.

PTAL

Thank you for working on this, it looks great!

No worries :-)


Update UG export command

Codecov Report

Merging #250 (abdfc93) into master (97ec9f9) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #250   +/-   ##
=========================================
  Coverage     45.63%   45.63%
  Complexity      495      495
=========================================
  Files           129      129
  Lines          2474     2474
  Branches        293      293
=========================================
  Hits           1129     1129
  Misses         1256     1256
  Partials         89       89

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97ec9f9...abdfc93. Read the comment docs.


SignalXY sometimes not rendered on high density data

Issue:
SignalXY does sometimes not render on high density data when only partial data should be rendered due to X axis limits.

When changing the X axis limits just slightly (e.g. by panning) the signal renders fine:

The interpolation of the PointBefore results in a infinite Y value which eventually results in a overflow exception (which is handled by ScottPlot):
System.OverflowException: Overflow error.
   at System.Drawing.Graphics.CheckErrorStatus(Int32 status)
   at System.Drawing.Graphics.DrawLines(Pen pen, PointF[] points)
   at ScottPlot.Plottable.SignalPlotXYGeneric`2.Render(PlotDimensions dims, Bitmap bmp, Boolean lowQuality)
   at ScottPlot.Plot.RenderPlottables(Bitmap bmp, Boolean lowQuality, Double scaleFactor)

Reproducing:
double[] ys = new double[10000];
double[] xs = ys.Select(x => double.PositiveInfinity).ToArray();
double r = 0.0;
for (int i = 0; i < ys.Length; i++)
{
    r += 0.005;
    xs[i] = r;
    ys[i] = Math.Sin(r);
}
var signalXY = WpfPlot.Plot.AddSignalXY(xs, ys);
WpfPlot.Plot.AxisAutoY();
WpfPlot.Plot.XAxis.Dims.SetAxis(min: r - 10.0, r);
WpfPlot.Plot.Validate(deep: true);
WpfPlot.Refresh();

System Details

ScottPlot Version: 4.1.41
Operating System: Windows 10
Application Type: WPF
.NET Version: .NET 6.0

Hi @bernhardbreuss,
Thanks for the detailed report. Your example helped to quickly reproduce the problem and find a solution. #1806

Hi @bernhardbreuss, thank you for reporting this! @StendProg did a fantastic job fixing this in #1806 which I'm merging now.
I will release a new package on NuGet within the next few days which will contain this fix 👍


fix(Dashboard): Check validity of control item

SUMMARY
It fixes an unexpected error with invalid control items.
BEFORE

AFTER

TESTING INSTRUCTIONS

Open the deck.gl Demo Dashboard
Make sure it loads

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

🏷 2021.44


docs(split): update event demo

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (fce7b64) 61.07% compared to head (5cf46d1) 61.07%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5601   +/-   ##
=======================================
  Coverage   61.07%   61.07%
=======================================
  Files        1107     1107
  Lines       23619    23619
  Branches     6187     6187
=======================================
  Hits        14426    14426
  Misses       7598     7598
  Partials     1595     1595

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix bug cannot mount xfs PV

Add the xfsprogs back to longhorn-manger image so that longhorn-csi-plugin can run mkfs.xfs to mount the xfs PV
longhorn/longhorn#7140

@PhanLe1010 See if we need to backport this.

Luckily that we don't need to backport since the change https://github.com/longhorn/longhorn-manager/pull/2299 was no backported


readme: AtScript no longer exists

Rename "AtScript" to "TypeScript", as the AtScript name is now retired. All AtScript functionality is being moved to TypeScript.
Signed-off-by: David Li<EMAIL_ADDRESS>

I would call these Angular extensions ;-)

That is what the functionality is being used for at the moment, but it looks like most of the extensions are going to be merged into TypeScript, opening them up for use in other places.

I updated this.