feat: 🎸 add num_rows_per_page in /rows and /search responses

also rename num_total_rows in num_rows_total
BREAKING CHANGE: 🧨 field num_total_rows in /rows and /search has been renamed num_rows_total
fixes #1687

Codecov Report
Patch coverage: 85.71% and project coverage change: -3.96% :warning:

Comparison is base (839dd7d) 90.44% compared to head (0f42e05) 86.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1688      +/-   ##
==========================================
- Coverage   90.44%   86.48%   -3.96%
==========================================
  Files         207       87     -120
  Lines       12805     2997    -9808
==========================================
- Hits        11581     2592    -8989
+ Misses       1224      405     -819

Flag
Coverage Δ

jobs_cache_maintenance
99.44% <ø> (ø)

jobs_mongodb_migration
85.15% <ø> (ø)

libs_libcommon
?

services_admin
87.41% <ø> (ø)

services_api
88.30% <ø> (ø)

services_rows
?

services_search
78.76% <85.71%> (ø)

services_worker
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

services/search/src/search/routes/search.py
54.47% <75.00%> (ø)

services/search/tests/routes/test_search.py
100.00% <100.00%> (ø)

... and 120 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Proposal: test to prevent bad constraints.txt files from being merged into master

Here's something I've been thinking about.  There seems to be a constant danger of merging a modified constraints.txt file into master.  I propose we create a test that prevents this from happening:

check in a file, constraints.txt.default that is a constraints.txt file that points to all of the master branches -- that is, what the constraints.txt file's contents in master should always be
add a unit test that checks whether constraints.txt.default's contents are identical to constraint.txt's, and fail if not

Pro: would prevent check-ins of erroneous constraint.txt files to master
Con: would cause a general test failure whenever constraint.txt is modified
Opinions?  @david4096 @andrewjesaitis

I think this is a great idea. I guess the alternative would be to add constraints.txt to .gitignore. I guess it depends on which tests you want to fail when submitting a pair of PR's to schemas and server.
If we unit test constraints.txt, I think the flow would be like:

Push PR to schemas - schemas test PASS
Push PR to server with constraints.txt pointing to schemas PR branch - server tests FAIL (because of constraints file differs)
Schemas PR merged
Update server PR with constraints.txt pointing at schemas@master - server tests PASS

With the .gitignore:

Push PR to schemas - schemas test PASS
Push PR to server; modified constraints.txt not pushed - server tests FAIL (because of missing dependency)
Schemas PR merged - server tests PASS

Problems with the .gitignore is that

Can't easily push working demos that rely on modified constraints.txt
Not sure how you kick Travis CI to rerun tests when a schemas PR is merged

I vote constraints.txt unit test.

I think the approach sounds reasonable. Instead of a .default file, could git be used to check if the file changed? 'git diff' maybe

Fixed in #1568

Parallel PRs in
schemas: https://github.com/ga4gh/schemas/pull/817
client: https://github.com/ga4gh/ga4gh-client/pull/62


ch.netzwerg:paleo-core:0.10.2 and nl.jworks.markdown_to_asciidoc:markdown_to_asciidoc:1.0 not foud

Swagger2Markup version: 1.3
Problem description: maven install, no found class

Some of the dependencies are not available in Maven Central.
Did you add JCenter as described in the user guide? http://swagger2markup.github.io/swagger2markup/1.3.1/#_release_2

@RobWin the must be define setting mirror for maven conf.   why not move the jar to maven central?

Because the two other projects are not my projects.

I added jcenter:
<repositories>
    <repository>
        <snapshots>
            <enabled>false</enabled>
        </snapshots>
        <id>jcenter-releases</id>
        <name>jcenter</name>
        <url>http://jcenter.bintray.com</url>
    </repository>
</repositories>

but I get this error:
[WARNING] The POM for nl.jworks.markdown_to_asciidoc:markdown_to_asciidoc:jar:1.0 is missing, no dependency information available
[WARNING] The POM for ch.netzwerg:paleo-core:jar:0.11.0 is missing, no dependency information available
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 3.126 s
[INFO] Finished at: 2019-07-09T15:45:26+02:00
[INFO] Final Memory: 26M/228M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project open-provider: Could not resolve dependencies for project com.logate.openprovider:open-provider:war:2.1.2: The following artifacts could not be resolved: nl.jworks.markdown_to_asciidoc:markdown_to_asciidoc:jar:1.0, ch.netzwerg:paleo-core:jar:0.11.0: Failure to find nl.jworks.markdown_to_asciidoc:markdown_to_asciidoc:jar:1.0 in https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced

This worked, after two days of frustration:
    <repositories>
        <repository>
            <id>spring-libs-milestone</id>
            <url>https://repo.spring.io/libs-milestone</url>
            <snapshots>
                <enabled>false</enabled>
            </snapshots>
        </repository>
        <!-- jhipster-needle-maven-repository -->
    </repositories>

    <pluginRepositories>
        <pluginRepository>
            <id>spring-plugins-release</id>
            <url>https://repo.spring.io/plugins-release</url>
            <snapshots>
                <enabled>false</enabled>
            </snapshots>
        </pluginRepository>
    </pluginRepositories>

Very strange. Thanks for checking it.

Finally, this worked, after two days of frustration:
    <repositories>
        <repository>
            <id>spring-libs-milestone</id>
            <url>https://repo.spring.io/libs-milestone</url>
            <snapshots>
                <enabled>false</enabled>
            </snapshots>
        </repository>
        <!-- jhipster-needle-maven-repository -->
    </repositories>

    <pluginRepositories>
        <pluginRepository>
            <id>spring-plugins-release</id>
            <url>https://repo.spring.io/plugins-release</url>
            <snapshots>
                <enabled>false</enabled>
            </snapshots>
        </pluginRepository>
    </pluginRepositories>

These two swagger2markup plugins were constantly being unresolved and swagger2markup couldn't have worked:
markdown_to_asciidoc
paleo-core
Analyzing Maven Repository, these two problematic swagger2markup plugins were actually indexed by Spring Plugins Repository repository.
The suggested JCenter repository seemed outdated and did not work for me!

thank you, this helped me!!!

Finally, this worked, after two days of frustration:
    <repositories>
        <repository>
            <id>spring-libs-milestone</id>
            <url>https://repo.spring.io/libs-milestone</url>
            <snapshots>
                <enabled>false</enabled>
            </snapshots>
        </repository>
        <!-- jhipster-needle-maven-repository -->
    </repositories>

    <pluginRepositories>
        <pluginRepository>
            <id>spring-plugins-release</id>
            <url>https://repo.spring.io/plugins-release</url>
            <snapshots>
                <enabled>false</enabled>
            </snapshots>
        </pluginRepository>
    </pluginRepositories>

These two swagger2markup plugins were constantly being unresolved and swagger2markup couldn't have worked:
markdown_to_asciidoc
paleo-core
Analyzing Maven Repository, these two problematic swagger2markup plugins were actually indexed by Spring Plugins Repository repository.
The suggested JCenter repository seemed outdated and did not work for me!

Above answer is very useful for me, thanks very much.

Finally, this worked, after two days of frustration:
    <repositories>
        <repository>
            <id>spring-libs-milestone</id>
            <url>https://repo.spring.io/libs-milestone</url>
            <snapshots>
                <enabled>false</enabled>
            </snapshots>
        </repository>
        <!-- jhipster-needle-maven-repository -->
    </repositories>

    <pluginRepositories>
        <pluginRepository>
            <id>spring-plugins-release</id>
            <url>https://repo.spring.io/plugins-release</url>
            <snapshots>
                <enabled>false</enabled>
            </snapshots>
        </pluginRepository>
    </pluginRepositories>

These two swagger2markup plugins were constantly being unresolved and swagger2markup couldn't have worked:
markdown_to_asciidoc
paleo-core
Analyzing Maven Repository, these two problematic swagger2markup plugins were actually indexed by Spring Plugins Repository repository.
The suggested JCenter repository seemed outdated and did not work for me!

Thank you!!!

Finally, this worked, after two days of frustration:
    <repositories>
        <repository>
            <id>spring-libs-milestone</id>
            <url>https://repo.spring.io/libs-milestone</url>
            <snapshots>
                <enabled>false</enabled>
            </snapshots>
        </repository>
        <!-- jhipster-needle-maven-repository -->
    </repositories>

    <pluginRepositories>
        <pluginRepository>
            <id>spring-plugins-release</id>
            <url>https://repo.spring.io/plugins-release</url>
            <snapshots>
                <enabled>false</enabled>
            </snapshots>
        </pluginRepository>
    </pluginRepositories>

These two swagger2markup plugins were constantly being unresolved and swagger2markup couldn't have worked:
markdown_to_asciidoc
paleo-core
Analyzing Maven Repository, these two problematic swagger2markup plugins were actually indexed by Spring Plugins Repository repository.
The suggested JCenter repository seemed outdated and did not work for me!

Helped a lot, thank you very much!

How did it work out?

@zhouyun885 Those 2 dependencies no longer exists also in spring repository, so now the use of this plugin with the current version is not working.
cc @RobWin

Hit the same issue. Adding the Jcenter repo as suggested in https://github.com/Swagger2Markup/swagger2markup-maven-plugin/issues/37 can compile while Jcenter is not update to date.
Any suggestion? @RobWin

@zhouyun885 @xieus I used repositories and pluginRepositories blocks from here and it helped https://github.com/Swagger2Markup/spring-swagger2markup-demo/blob/master/pom.xml#L33-L63


[Feature Request] Support External Enums which are imported.

Current version: LDtkToUnity v3.1.3
The imported enums has different data path from the built-in enums of LDtk.
Could we also support external Enums?
external Enums allow us maintian the full Enums list in an external file and import/refresh from that file, which is more feasible for a serious project.

Yep, it's something to be added. I'm keeping note of it :)

After looking into this, LDtk references the external enum, but still loads it into the project json. So it's retroactively always been supported 😅


Addition of Global Lightning Probability Module Based on USAF Algorithm

Adding the lightning algorithm that MIT LL has added developed based on current USAF documentation of their operational algorithm used in house. There will be a companion PR going up shortly for acceptance tests accompany this.
I spent a fair amount of time making sure the code style and all the other checks passed, so that should make this a bit easier to review. Open to any suggestions on if things should be reformatted.  We added the logic of the code to the existing lightning.py file as we thought it made sense, but have a separate CLI call for invoking the algorithm 'lightning_multivariate_probability'.
Let me know if you have any comments/concerns.
Acceptance test data PR: https://github.com/metoppv/improver_test_data/pull/44
Testing:

[X] Ran tests and they passed OK
[X] Added new tests for the new feature(s)

CLA

[X] If a new developer, signed up to CLA

This would be a great addition to IMPROVER, and very interesting to see what diagnostic schemes are in use elsewhere.
At the Australian Bureau of Meteorology we have an alternative algorithm that makes use of the instantaneous cloud physics thunder parameter (Bright et al. 2005) along with accumulated precipitation, although we are in the process of developing improved formulations using additional convective parameters and we may also implement this eventually in the IMPROVER framework. As such, I would request we may be more careful in naming the Python modules or functions/classes here to make them a little less generic, e.g. class LightningMultivariateProbability_USAF2024 or similar

Thanks @ivorblockley. We'll try to have a conversation within the Met Office regarding the naming convention issue that you raise here, just to try to come up with a recommendation, as this could potentially impact other algorithms already within the IMPROVER codebase.

I am open to changing the name of the module to whatever we decide is best going forward. To be honest, our working name for this internally was to call it LightningProbability_USAF (without the year), but  after reviewing the other names we decided to change the name as no other ones were named specific to any one agency.  Whatever we decide as a group is best, we are happy to go with.

Thank you @gavinevans  for the thorough review and helping me walk through the process of my first IMPROVER PR.  I think I've learned from this experience and hopefully subsequent ones will be smoother, as I'll be aware of the common issues raised during this one (e..g, comprehensive unit tests, checksums, documentation, etc).
I've 'resolved' all the conversations mostly so that I could track which ones I've addressed. Feel free to review them and make sure I've adequately addressed all the comments/concerns and let me know if you have any other suggestions.

Ok, I think we've addressed all the comments and concerns! I've updated the unit tests for metadata, created acceptance tests that are not idealized that, ensured the validity time was at the end of the period bounds, and made the additional minor changes.
Further, we did make a few minor changes to the algorithm (e.g., we changed the sign on CIN), as conventionally CIN is given as <=0 whereas the regression equations used assumed it was >=0.  We realized we were doing a pre-processing step on our CIN values to reverse the convention, but we've moved this reversal directly into the algorithm so that any users can pass in CIN cubes as they are standardly defined.

Thanks for all the updates @timbonin 👍 . I've added one query to the associated test data PR: https://github.com/metoppv/improver_test_data/pull/44, but otherwise this PR looks fine to me now.

Thanks for all the updates @timbonin 👍 . I've added one query to the associated test data PR: metoppv/improver_test_data#44, but otherwise this PR looks fine to me now.

I've just addressed the other query on the acceptance test data, so I think we should be good to go.  I'll double check with you one more time.

Thanks @timbonin for addressing all my feedback.


Socketio endpoints

Hi - wondered if you thought it would be useful to include socket endpoints?

Hello,
I think this is a bit out of scope for this cookiecutter, websockets on REST APIs are pretty rare IMHO and it would better fit on more generic flask template

Understood, thanks for the response.


Question: Any advantage in binning coords into H3 when HexagonLayer takes coords anyway?

Curious about whether/how deck.gl will integrate with H3.
https://uber.github.io/deck.gl/#/documentation/api-reference/layers/hexagon-layer
Reading the documentation and seeing it uses the d3 hexbin function.

Sorry to open this discussion again.
Is there any way to integrate h3 to HexagonLayer right now?
I tried to do it myself using the getHexagonAggregator, and calling the h3 functions:
    return new HexagonLayer({
      id: "poc-hexagon",
      data: h3Impressions,
      hexagonAggregator: this.getHexagonAggregator,

And
  getHexagonAggregator({ data }, viewport) {
    const result = {
      hexagons: data.map(({ id, impressionsCount }, index) => {
        const center = h3.h3ToGeo(id);
        const lngLat = [center[1], center[0]];
        return {
          centroid: lngLat,
          index,
          points: Array(impressionsCount).fill({
            coordinates: lngLat,
            screenCoord: viewport.projectFlat(lngLat)
          })
        };
      })
    };

    console.log(result);
    return result;
  }

I could get the hexagons geopoints, but how can I get the radius? I could use the h3.h3ToGeoBoundary(id) to the the vertices, but I don't know how to transform it in deckGl radius.
Thanks.

I just had to implement this. The solution @xiaoji and I came up with is a PolygonLayer but you implement getPolygon: d => h3ToGeoBoundary(d.hexId).map(([lat, lng]) => [lng, lat]).


I can't use WebSocketClient.send send message as (eg:client.emit("command", message);)

I believe you have this confused with Socket.io. Could you check this?

hey @iokane,
do you still have an issue here?
Greetings
marci4

No feedback by issue creater and also unclear issue.
Closing
Greetings
marci4


shell_module/sample.shell.shell_module.usb fails for thingy53_nrf5340_cpuapp_ns

Describe the bug
Build  samples/subsys/shell/shell_module/sample.shell.shell_module.usb for thingy53_nrf5340_cpuapp_ns fails.
To Reproduce
twister -c -p thingy53_nrf5340_cpuapp_ns -s samples/subsys/shell/shell_module/sample.shell.shell_module.usb
fails with:
[ 94%] Linking C executable zephyr_pre0.elf
/home/krch/zephyr-sdk-0.13.2/arm-zephyr-eabi/bin/../lib/gcc/arm-zephyr-eabi/10.3.0/../../../../arm-zephyr-eabi/bin/ld.bfd: drivers/hwinfo/libdrivers__hwinfo.a(hwinfo_nrf.c.obj): in function `soc_secure_read_deviceid':
/home/krch/vork/zephyr/soc/arm/nordic_nrf/common/./soc_secure.h:37: undefined reference to `soc_secure_mem_read'

Environment (please complete the following information):

Commit SHA: e4aed1cfbd0760ec0af524d1b5796ba0ef38b61b

@nordic-krch Is it not fixed by https://github.com/zephyrproject-rtos/zephyr/pull/44405/commits/11228d5d0e9da05bf7ccb20391f278af64dd3bb2 ?

@jfischer-no seems that it not fixed the issue with that board.

This is no longer failing on main:
$ scripts/twister -c -p thingy53_nrf5340_cpuapp_ns -s samples/subsys/shell/shell_module/sample.shell.shell_module.usb
ZEPHYR_BASE unset, using "/home/carles/src/zephyr/zephyr"
INFO    - Zephyr version: v3.1.0-rc3-14-gbb255bc97512
INFO    - JOBS: 4
INFO    - Using 'zephyr' toolchain.
INFO    - Building initial testsuite list...
INFO    - Writing JSON report /home/carles/src/zephyr/zephyr/twister-out/testplan.json
INFO    - Using 'zephyr' toolchain.
INFO    - 1 test scenarios (1 configurations) selected, 0 configurations discarded due to filters.
INFO    - Adding tasks to the queue...
INFO    - Added initial list of jobs to queue
INFO    - Total complete:    1/   1  100%  skipped:    0, failed:    0
INFO    - 1 of 1 test configurations passed (100.00%), 0 failed, 0 skipped with 0 warnings in 62.03 seconds
INFO    - In total 0 test cases were executed, 1 skipped on 1 out of total 456 platforms (0.22%)
INFO    - 0 test configurations executed on platforms, 1 test configurations were only built.
INFO    - Saving reports...
INFO    - Writing JSON report /home/carles/src/zephyr/zephyr/twister-out/twister.json
INFO    - Using 'zephyr' toolchain.
INFO    - Writing xunit report /home/carles/src/zephyr/zephyr/twister-out/twister.xml...
INFO    - Writing xunit report /home/carles/src/zephyr/zephyr/twister-out/twister_report.xml...
INFO    - Run completed


Border.symmetric seems wrong. Horizontal = top/bottom?

I really don't understand this. Shouldn't vertical = top/bottom and horizontal = left/right? Why is the opposite?

Source:
https://github.com/flutter/flutter/blob/f5ddece56e0e9d21d3b3f2d46d96330cb7bd789b/packages/flutter/lib/src/painting/box_border.dart#LL340C5-L340C5
Could anyone help me understand if this is intended and why?
EdgeInsets work fine, every other symmetrical Flutter usage seems fine, but Border.symmetric doesn't make sense to me.
This was implemented/updated by @tvolkert about 3 years ago.

Yep, this is intended (and was changed in https://github.com/flutter/flutter/issues/61470)
It's because the lines on the top and bottom are horizontal lines -- and the lines on the left and right are vertical lines.
Per https://en.wikipedia.org/wiki/Vertical_and_horizontal:

a direction or plane passing by a given point is said to be vertical if it contains the local gravity direction at that point. Conversely, a direction or plane is said to be horizontal (or leveled) if it is perpendicular to the vertical direction.

wow, it was hard for me to understand. I guess it makes some sense! Thanks, lol
I saw the original issue but never saw the reason, so I couldn't sleep thinking about this. Thanks!


Deploy to App Service step in quickstart fails with roleAssignments unauthorised

Tutorial Step Deploy to App Service, using a container registry I have already used to deploy another web app, under a subscription where I have the Contributor role. The deployment fails with the message:
The client<EMAIL_ADDRESS>with object id 'aaaaaaaa-bbbb-cccc-1111-99999999' does not have authorization to perform action 'Microsoft.Authorization/roleAssignments/write' over scope '/subscriptions/fffffff-bbbb-cccc-1111-99999999/resourceGroups/bm-dash-rg/providers/Microsoft.ContainerRegistry/registries/bmdashboardcr/providers/Microsoft.Authorization/roleAssignments/ccccccccc-bbbb-cccc-1111-99999999' or the scope is invalid. If access was recently granted, please refresh your credentials.

I tried a few options (using an existing resource group, creating a new one), to no avail.
I am underwhelmed by the Azure tutorials, overall. I cannot seem to get anything to lesson completion even trying to follow step by step the instructions and minimally depart from it.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bd52d297-e2d9-9a51-3ed6-05c33f521672
Version Independent ID: b9f21bef-4944-fbc1-c39c-7c2a0c939ce3
Content: Quickstart: Run a custom container on App Service - Azure App Service
Content Source: articles/app-service/quickstart-custom-container.md
Service: app-service
GitHub Login: @msangapu-msft
Microsoft Alias: msangapu

jmp75,  Thanks for the feedback! We are currently investigating and will update you shortly.

jmp75, Apologies you experienced this issue with the doc tutorials and any frustrating experience.  As I understand you have Contributor Role access on your subscription. As for as the Contributor -Grants full access to manage all resources, but does not allow you to assign roles in Azure RBAC, manage assignments in Azure Blueprints, or share image galleries. See, this doc.
If your requirement fits, you could get yourself - a custom role with roleAssignments/write permission and assign this role to the application or work with your subscription owner to get owner permissions.

jmp75, We will now close this thread since it's not doc specific feedback. If you have any questions, please let me know. Thanks for taking time to share your feedback.


chore(tests): introduce toxiproxy to integration tests

This PR introduces ToxiProxy to Docker Compose file for use in integration tests.
ToxiProxy can be used to simulate failures in a network.
The proxy can be controlled from tests by using the SDK for .Net
using (var connection = new Connection(true)) //this will ensure all proxies & toxics are reset on dispose.
{
  var client = connection.Client();
  var proxy = client.FindProxy("speckle_test_speckle-server");

  // do stuff with the proxy by adding toxics: e.g. latency, returning error status codes, or dropping the connection. In this example, causing a timeout.
  var timeoutProxy = new TimeoutToxic();
  timeoutProxy.Attributes.Timeout = 100;
  timeoutProxy.Toxicity = 1.0;
  proxy.Add(timeoutProxy);

  // then apply the changes
  proxy.Update();

  //now run your tests and experience timeout problems connecting to speckle server
}

Closing this because we're not going to get around to this in the foreseeable future.
We'll pick this back up once we have some bandwidth! 🙌🏼


eliminating the need for linked CSS

The Use Case: I'm challenged to reduce the number of server requests by eliminating linked CSS tags. However, I love the built-in SCSS preprocessor and importing multiple SCSS snippets into one SCSS file. I would like to keep using SCSS, but the final output CSS file from the SCSS preprocessor is placed in the _site folder. Also, includes do not work with css (or js) extension files.
To eliminate linked files, I currently have to manually copy and paste the processed CSS into an html file in the _includes folder. I would prefer Jekyll do this for me.

I would like to see a property in the config.yml file that can specify the scss -> css output file folder.

sass:
  sass_dir: _sass
  css_dir: _includes
  style: compressed

I would like Jekyll to be able to include css and js files if they are stored in the _includes folder. So instead of this,

<link rel="stylesheet" href="/assets/css/main.css">

... we can have this,
{% include main.css %}

Hello @greatgraphicdesign
First of all, you have opened the ticket in the wrong repository. The real repository is at github.com/jekyll/jekyll.
Nevertheless regarding your feature-request, I would like to inform you about the technical roadblocks involved in your suggestion before you open a ticket at the main repo.

The sass config applies only to the preprocesser that we call [sass | scss]-converter. It cannot tell Jekyll where to output the generated .css file.
Jekyll does stuff in distinct phases. *It first reads all files on disk, then converts the contents into desired outputs and finally writes all the files onto disk. You may visually gauge this by building you site with the --verbose / -V CLI flag.
The _includes directory is accessed during the conversion phase, that is, before Jekyll writes files into the _site. So, even if we found a way to drop your CSS file into _includes, it's not going to be fruitful.

Ultimately, the *.scss source file you have in your theme / assets directory is a Jekyll::Page object that resides in the list site.pages. Fortunately, there's even a built-in scssify / sassify Liquid filters that you can use in your templates.
So, assuming your source stylesheet is at path assets/css/styles.scss, then theoretically, the following should work without any configuration changes:
<style>
  {% for item in site.pages %}
  {% if item.path == 'assets/css/styles.scss' %}
  {{ item.content | scssify }}
  {% endif %}
  {% endfor %}
</style>

Hi @ashmaroli! Thanks so much for your detailed reply, and my apologies for posting in the wrong repository. That liquid filter will work great! I'm very glad to have a solution.


Update SlideExpandableListView.java

solve a bug in SlideExpandableListView,java file in the function enableExpandOnItemClick().when add headerView or footerView SlideExpandableListView will crash

Not accepted, solution is much easier, see https://github.com/tjerkw/Android-SlideExpandableListView/commit/0355484f2e62fc0fd939349a70684ae6369f4fc1

You are right ,this would be a much better way !


Gap Survey: FC and Terra

TBD.

I've largely conducted this survey and created a central doc. While I encourage other's to look for content as they go, I don't want to dedicate an additional spike toward this. Closing as invalid.


Added Peak Annotations sheets to the build a submission page output and made fixes to bugs relating to pandas behavior WRT empty cells

Summary Change Description

See affected issue(s).
Affected Issues/Pull Requests

Partially addresses #829
Merges into PR #1017
Next PR: #1027

Review Notes

See comments in-line.
Checklist

This pull request will be merged once the following requirements are met.  The
author and/or reviewers should uncheck any unmet requirements:

Review requirements

Minimum approvals: 1
No changes requested
All blocking issues resolved by reviewers
Specific reviewers: @add_username_here

Review period: 2 days

Associated issue/pull request requirements:

[x] All requirements in affected issues marked "resolved" are satisfied
[x] All required pull requests are merged (or none)

Basic requirements

[x] All linters pass
[x] All tests pass
[x] All conflicts resolved

Overhead requirements

[x] New/changed method tests implemented/updated (or no change)
[ ] Updated Unreleased section of changelog.md (or no change)
[x] Migrations created & committed (or no change)

Merged via #1076


NavigationItem not displayed in contentcontroller when using storyboard

My project uses the storyboard to create screens, along with NavigationControllers. Everything works fine except the NavigationItem is not displayed in the ContentController....I think I might be missing something really obvious, or do the NavigationControllers get stomped on in the SideBar constructor?
What i'm trying to do is recreate your example where you have a contentcontroller with a navigationbar that slides across to make way for the menucontroller, but I cannot figure out where/how to add the navigationitem to the contentcontroller. If I add it to the rootcontroller the the navigationbar does not move when the menu sldies across

hmmm I think what might be happening is that your sample is built for xamarin.forms?

There are multiple samples. Only one of them uses Xamarin.Forms.

okay thanks, I think I was expecting the functionality to be slightly different, where the menu worked more like a tabbarcontroller, and each contentcontroller could have it's own navigationcontroller. In you example the


Error after command "make install"

just cloning the repository
$ git clone https://github.com/tarampampam/laravel-roadrunner-in-docker.git
then I enter the command
$ make install
I get the following error
In JsonFile.php line 178:

  file_put_contents(./composer.lock): Failed to open stream: Permission denied

...

ERROR: 1
make: *** [Makefile:17: install] Ошибка 1

then I enter the command
$ composer i
and run again
$ make install
and i get this problem
In StreamHandler.php line 146:

  The stream or file "/app/storage/logs/laravel.log" could not be opened in append mode: Failed to open stream: Permission denied
  The exception occurred while attempting to log: The stream or file "/app/storage/logs/laravel.log" could not be opened in append mode: Failed to open stream: Permission denied
  The exception occurred while attempting to log: The /app/bootstrap/cache directory must be present and writable.
  Context: {"exception":{}}
  Context: {"exception":{}}

i am using Fedora 37

after command make init i have that problem

but i get this
$ make up
...

    Navigate your browser to ⇒ http://<IP_ADDRESS>:8080 or https://<IP_ADDRESS>:8443

and I followed the link, and the page is unavailable. Maybe I have not configured something. Maybe it is necessary to create an env file? I'm new to docker...

Could you try again with a fresh installation? I can't reproduce the described error on my side:
$ git clone https://github.com/tarampampam/laravel-roadrunner-in-docker.git
Cloning into 'laravel-roadrunner-in-docker'...
remote: Enumerating objects: 949, done.
remote: Counting objects: 100% (492/492), done.
remote: Compressing objects: 100% (284/284), done.
remote: Total 949 (delta 445), reused 233 (delta 207), pack-reused 457
Receiving objects: 100% (949/949), 279.80 KiB | 1.50 MiB/s, done.
Resolving deltas: 100% (532/532), done.

$ cd laravel-roadrunner-in-docker/

$ make install
docker-compose run --rm --user "1000:1000" --no-deps app composer install --ansi --prefer-dist
[+] Running 4/0
...
  - Installing spiral/roadrunner-worker (v2.3.0): Extracting archive
  - Installing spiral/roadrunner-http (v2.2.0): Extracting archive
  - Installing nyholm/psr7 (1.5.1): Extracting archive
  - Installing spiral/roadrunner-laravel (v5.9.0): Extracting archive
62 package suggestions were added by new dependencies, use `composer suggest` to see details.
Generating optimized autoload files
> Illuminate\Foundation\ComposerScripts::postAutoloadDump
> @php artisan package:discover --ansi

$ make install
docker-compose run --rm --user "1000:1000" --no-deps app composer install --ansi --prefer-dist
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Nothing to install, update or remove
Generating optimized autoload files
> Illuminate\Foundation\ComposerScripts::postAutoloadDump
> @php artisan package:discover --ansi

   INFO  Discovering packages.

  fruitcake/laravel-cors ...................................................................................................................... DONE
  laravel/sail ................................................................................................................................ DONE
  laravel/sanctum ............................................................................................................................. DONE
  laravel/tinker .............................................................................................................................. DONE
  nesbot/carbon ............................................................................................................................... DONE
  nunomaduro/collision ........................................................................................................................ DONE
  nunomaduro/termwind ......................................................................................................................... DONE
  spatie/laravel-ignition ..................................................................................................................... DONE
  spiral/roadrunner-laravel ................................................................................................................... DONE

$ make init
...
docker-compose run --rm --user "1000:1000" app php ./artisan migrate --force --seed
  2019_08_19_000000_create_failed_jobs_table ............................................................................................. 14ms DONE
  2019_12_14_000001_create_personal_access_tokens_table .................................................................................. 17ms DONE

   INFO  Seeding database.

docker-compose run --rm --user "1000:1000" --no-deps app php ./artisan storage:link

   INFO  The [public/storage] link has been connected to [storagepublic].

I sincerely apologize. this is my local problem. Apparently I installed docker incorrectly.
Solved the problem like this:

Deleted dokker and docker-compose
Installed dokker and docker-compose again
And this answer on stackoverflow helped me

That helped me at Fedora 37
Docker version 20.10.21, build baeda1f
docker-compose version 1.29.2, build unknown


Please make .apk for fire tv / amazon android devices that uses USB connection

Thank you for creating scrcpy it works great in a Android to PC/OSX/Linux situation.
If possible please make an Android -> Android port as well Android - > Fire TV ( Amazon Android OS ) port. So far there is no functioning Android -> USB -> Android port of this ( as with the mention OSes ).
All fire TV have the same kind of connection most computer do for the USB stick. Thus should work correctly. However Fire TV /Amazon Android OS has a different video-mode in comparison to regular computers.
If this could be a .apk that works the same way with PC/OSX/Linux it would be perfect. In the past I would scrcpy Android -> PC -> HDMI for my parents as they do not have any high-speed connection for their display. They have a new Fire TV OS display and it prevents their computer ( HP ) from connecting via HDMI. The HP has a different frequency or maybe the Fire TV is blocking it ?
I enjoy using scrcpy and recommend it to all of family, friends. classmates, co-workers, and strangers when I can. It would be awesome if I could connect this Android -> Android or Android -> Fire TV/Stick OS /Amazon Android devices
Thank you for reading and considering making this a .apk release as it is impossible to install xapk in a normal fashion on Fire TV as there is no official .Xapk installer for Fire TV.
This is about plugging in via USB as with the computer but this being a fire tv / Amazon Android OS.

https://github.com/qaisbayabani/SCRCPY-C-Sharp-Client is a solution

However Fire TV /Amazon Android OS has a different video-mode in comparison to regular computers.

What do you mean?

They have a new Fire TV OS display and it prevents their computer ( HP ) from connecting via HDMI.

Are you using an HDMI hub or splitter?


Suggestion: Using active fork of sweetalert

Just noticed that sweetalert is not maintained anymore: https://github.com/limonte/sweetalert2. Don't know if it's worth doing, nor a priority just thought I'd point out the original sweetalert hasn't merged a PR since 2014.

I think both are maintained https://github.com/t4t5/sweetalert and  https://github.com/limonte/sweetalert2

I'd like to keep using /t4t5/sweetalert and upgrade to v2.

Hmm, if I have time I will make a fork. But now I did this for sweetalert2 https://github.com/alex-shamshurin/sweetalert2-react


[codemod] Add codemod parser flag (#29059)

[ x] I have followed (at least) the PR section of the contributing guide.

Fix for #29059. Adds that ability to pass jscodeshift parser options to codemod. Is important for users using flowtype who are doing migrations to v5.0.

@siriwatknp thanks so much!  Where do I check to see if the code release went out?

@siriwatknp thanks so much! Where do I check to see if the code release went out/did it go out?

You can check it here (the next release is likely 5.0.7). https://github.com/mui-org/material-ui/releases


Switch to newer setup-gcloud action

There's a warning from the Build BuildAgent VM image step:

Thank you for using setup-gcloud Action. GoogleCloudPlatform/github-actions/setup-gcloud has been deprecated, please switch to google-github-actions/setup-gcloud.

Done in f22d852129ec9c6dad9c6f73d70e79fd9f7952a4.


Typo in first paragraph

"mapped into 5-second tumbling windows" - the diagram shows a 10-second window

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7481e5ce-9b20-2edb-4d3c-d73858d1dde8
Version Independent ID: ff6f279d-6469-012a-1e4b-88b6f1830b8e
Content: Tumbling Window (Azure Stream Analytics) - Stream Analytics Query
Content Source: stream-analytics-docs/tumbling-window-azure-stream-analytics.md
Service: stream-analytics
GitHub Login: @mamccrea
Microsoft Alias: mamccrea

Thanks for pointing that out @toastermagic. I've fixed the typo.

#please-close


Update Plugins after initial render

Greetings,
I started using this module, and so far so good. Can say documentation can be better tho.
I am facing an issue, using the diff check plugin. I want to change the "original value markdown" later, but there is no way that I can update a specific plugin after the MDXEditor has been initialised.
Changing configs and re-rendering of component doesnt do the trick.

What you describe should work. Some plugins, including the diff-source one actually accept updates on their config.
It would be great if you accompany your bug reports with actual reproductions of what you're doing, as the issue template strongly recommends. In the meantime, I'm closing this.

What you describe should work. Some plugins, including the diff-source one actually accept updates on their config.
It would be great if you accompany your bug reports with actual reproductions of what you're doing, as the issue template strongly recommends. In the meantime, I'm closing this.

        diffSourcePlugin({
          viewMode: 'rich-text',
          diffMarkdown: props.originalValue,
          codeMirrorExtensions: [basicDark],
        }),

This function is passed to plugins array on MDXEditor, and no, it does not update the diffMarkdown value when originalValue inside props is changing.


npm link of Gulpfile (as a module) will not find tasks and error.

Hi.
I've written a gulp setup (https://github.com/Industrial/id-project) for all my projects but as the number of projects using this setup grew it became more generic and instead of copying over behaviour from project to project I opted to make the setup (id-project) more generic and support configuration.
At first I used git to pull in changes from id-project into e.g. ProjectA and ProjectB. This turned out to be a messy thing and a lot of bookkeeping and working with git instead of coding.
Right now, I've implemented id-project as a NPM module so all I have to do is npm install --save-dev id-project gulp coffee-script and the gulpfile.coffee looks like (require "id-project")() and I'm done. I can make changes to id-project and just update with npm when I want those changes in another project.
The problem I'm having is that when I am developing new features or fixing bugs on id-project, I can't use npm link to test these changes in another project before releasing id-project. Gulp tells me Task 'default' is not in your gulpfile.
There seems to be a difference between using the npm install id-project version and npm link version.
Meanwhile I'm releasing a lot of unneeded versions on npm that I would like to do without.
Any help would be appreciated.

@tkellen Any idea what happened to this issue? I'm running into the same problem, and I don't see a fix... Thanks!

We have a gulpfile requiring another gulpfile as part of a library. To reproduce:
git clone git@github.com:mozilla/marketplace-gulp
git clone git@github.com:mozilla/fireplace
cd marketplace-gulp && npm link && cd ../
cd fireplace && npm install && make install && npm link marketplace-gulp
make serve

gulp will then fail to find tasks. When debugging the Gulp object in the local gulpfile, it seems the tasks are registered to the Gulp object. But it can't find the default task.

For what it's worth, I solved it by doing this:
http://stackoverflow.com/questions/28972330/task-is-not-in-your-gulpfile-when-using-npm-link

That's worth a lot, thanks @jfbibeau!

Thanks for the solution!
I've since built my own project automation module, though; https://github.com/Industrial/id-builder


Consider alternative to postcss-normalize? It's really expensive (slow) to run (contains cpu profile dump)

My yarn start was taking an excruciating amount of time to start up (36 seconds)
I ran a profiler and was surprised to see that the part that was taking the longest was postcss
Here's the CPU profile dump
CPU-20190828T230439.cpuprofile.zip
~11s of that was /node_modules/postcss-browser-comments/index.cjs.js

It looks like postcss-browser-comments is a dependency of postcss-normalize (added in https://github.com/facebook/create-react-app/pull/5810).
I used react app rewired to remove postcssNormalize(), from the list of plugins provided to postcss and reduced startup time to 26s.
That's one expensive css reset
The contents of my mod if anyone needs to do this in the meantime (using react-app-rewired)
  const oneOfRules = config.module.rules.find(x => x.oneOf).oneOf;
  const postcssLoaders = oneOfRules
    .map(
      rule =>
        rule.use &&
        rule.use.find(x => x.loader && x.loader.includes('postcss-loader')),
    )
    .filter(x => x !== undefined);
  postcssLoaders.forEach(postcssLoader => {
    // copied from https://github.com/facebook/create-react-app/blob/cbaed7f9fff2fc570f4f206aa057253bd4f74c9e/packages/react-scripts/config/webpack.config.js#L110-L116
    postcssLoader.options.plugins = () => [
      require('postcss-flexbugs-fixes'),
      require('postcss-preset-env')({
        autoprefixer: {
          flexbox: 'no-2009',
        },
        stage: 3,
      }),
    ];
  });

I've also tried this:
  postcssLoaders.forEach(postcssLoader => {
    const originalPlugins = postcssLoader.options.plugins;
    postcssLoader.options.plugins = () =>
      originalPlugins().filter(x => x.postcssPlugin !== 'postcss-normalize');
  });

but this was equally slow (back to 36s)

Still important

Still important

@mrmckeb could I trouble you to take a look and maybe triage?
IMO this is a rather insidious performance bug in that users might not notice it when their app is just half a dozen files, and by the time its grown big enough to feel frustrating, they probably wouldn't suspect that the fault is with an innocuous looking normalize plugin that CRA bundled in and think "big apps are just slow" or "probably slow because of typescript"; that was my thought process that led me to just twiddle my thumbs for months waiting for 30+s builds until I realized normalize was hogging 10 seconds of my time every build.
yarn installing a css reset and importing it into index.js can be done in half a minute and imo shouldn't be part of CRA if it's stealing so much dev time every rebuild (I wonder how many dev-hours it's taken up since April)
Happy to share a zip of my repo to any maintainers who don't believe postcss-normalize is adding 10s to build. It's by not an especially large project either (71 typescript files, 8 js files)

Can you confirm if this is still an issue @cheapsteak? I see https://github.com/csstools/postcss-normalize/issues/42 which references version 7.0.1 which was also the version we were using at the time you originally posted this issue.

@ianschmitz confirmed to no longer be an issue in 3.3.0-next.62 using postcss-normalize 8.0.1! Thank you for looking in 🙏


[Feature Request] Spent Time in avatar (name)

As title. Like the ingame hour counter, but how long you've been in one avatar.

possibly duplicate of https://github.com/vrcx-team/VRCX/issues/635


how to return an autoincrementing numeric value, celll content

     {
          cells: ["sAh", "sAf"],
          content: "N. rows",
          pushCol: true,
        },
        {
          cells: "sA1:A-0",
          content: "", // here i need to add my function which returns i++ 0:n
          pushCol: true,
        },

Sorry, it's been a while since I've done all of this, but you can use a function to return content.  Have at look at the following example: https://www.pauljones.co.nz/github/buttons-html5-styles/examples/page_style.html
function dynamicContentFunction(cellId, col, row, smartRow) {
    return 'Cell: ' + cellId + ' Col: ' + col + ' Row: ' + row + ' Smart Row: ' + smartRow;
};

...{
      cells: ['sC1:D14','sC18:D-0'],
      content: dynamicContentFunction,    // Content inserted by a function
      pushCol: true
  },


chore(deps): upgrade runtime dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-runtime-dependencies-2.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 2984

Questions ?
Please refer to the Backport tool documentation


Fix tapering of zero/empty operators

Tapering logic would detect an empty/zero operator, log a warning and return the original operator unchanged. When running code with symmetry reduction in Qiskit Nature this ended up failing in VQE if one or more of the auxilary operators was zero. The set that ended up getting passed in would tapered non-zero operators and any zero operators were the originals which now were bigger, in terms of num_qubits, that the tapered operators. Given the number of qubits mismatched VQE raised an error.
This alters the code to so that a zero operator of the correct tapered size is returned from taper and not the original as before.

@ikkoham - since I cannot add you as a reviewer...

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 82.492%

Totals

Change from base Build<PHONE_NUMBER>:
0.01%

Covered Lines:
49643

Relevant Lines:
60179

💛  - Coveralls


Autorebuild not working with Blazor 0.8.0

Repro steps:

Install the Blazor VSIX
Create a new standalone Blazor app
Ctrl-F5 to run it
Change the heading text in Index.cshtml (or some other visible change)
Refresh the browser

Expected result: Change to home page is visible after refreshing the browser
Actual result: Home page looks the same

Closing as this is external.


[NoQA] fix links for Expensify Help site

Details
This PR fixes the links for the new Expensify Help (where the back button is not working as expected here).
Fixed Issues
N/A
Tests

(you need ruby and bundler installed to do this, more info here)

Run:
cd docs
bundle install
bundle exec jekyll serve

Navigate to http://localhost:4000/articles/request-money/SmartScan and click on the Back button, it should redirect to the hub page (upper level)

Click on the Home button and verify it redirects you to the Homepage (currently it's an empty page) instead of the "Coming soon" page.

Why can't this be QA'd?

Why can't this be QA'd?

Ah the site is still in an "alpha" version and we're going to still do more changes, but this fix is required for us to internally begin to upload content. So I think it won't make sense to use QA since we're going to be testing the site internally until we have more content :)

Merging it

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

I don't necessarily agree. As long as one of the QA testers can jump into the site and click the links I think its fine to have it go through the QA process since its not being cherry-picked.

🚀 Deployed to production by @luacmartins in version: 1.1.85-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


[Feature Request] Override default scrolling

Whenever one lands on the bottom or the top of a window, neovim will scroll the window automatically, this however, is with the default scrolling mechanism, which really irritates when being used to the glorious scrolling neoscroll provides.
Could this be overriden with this plugin? I tried checking the neovim documentation and it seems they only expose a "WindowScrolled" event, which isn't every useful for this sadly.
TLDR: override mechanism for the default scrolling neovim does when the cursor is moving "out" of a window.

Apologies for the late reply. Not sure I fully understand the behaviour you are describing. Could you provide more details?

To be honest I am confused myself, I assume this was some weird interaction that is now fixed?
Either way sorry for the useless issue, closing.
Cheers.


fix: Launcher script detection

Use the nodejs toolchain to detect the exec platform.
Fixes #977
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Properties of change

[ ] Breaking change (this change will cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Test plan
How has this been tested?

[ ] Covered by existing tests cases
[ ] New test cases added
[x] Local testing

Discussing this change in https://github.com/aspect-build/rules_js/issues/977#issuecomment-1497628582


Fix double spacing in "cascade persist missing" exception message

This is an absolute minor style improvement that concerns wrong double spacing on string concatenation.

@martin-georgiev thanks, LGTM! :+1:


new FunctionDefinition incompatible with azure

Using the new FunctionDefinition returns this on azure's gpt-4-turbo
  "error": {
    "message": "1 validation error for Request\nbody -> tools\n  extra fields not permitted (type=value_error.extra)",
    "type": "invalid_request_error",
    "param": null,
    "code": null
  }

Looking at the converted JSON (I used ObjectMapper().writeValueAsString so I am not sure if it's accurate)
{
    "type": "function",
    "function": {
      "name": "wolframAlpha",
      "description": "Computes mathematical expressions using WolframAlpha",
      "parameters": {
        "$schema": "http://json-schema.org/draft-04/schema#",
        "title": "Wolfram Alpha Function",
        "type": "object",
        "additionalProperties": false,
        "properties": {
          "input": {
            "type": "string"
          }
        }
      }
    }
  }

seems like azure doesn't support the "$schema", "title", "aditionalProperties" fields as I can't find these in any documentation
another limitation with the new FunctionDefinition is that it doesn't allow parameterless functions, the parameters field is optional and can be omitted

Omitting parameters defines a function with an empty parameter list.

Okay, I'll see later

I don't have an Azure API key. It would be great if you could provide one for me to test. Currently, I can only streamline the response schema


Waypoint not rendering custom child node

Hi i've been using https://github.com/dzhurley/preact-waypoint  - minimal preact version of https://github.com/brigade/react-waypoint
i just noticed that,
preact-waypoint "fails" to render the child component inside
it always renders
<Waypoint></Waypoint>

even if i put
<Waypoint>
content
</Waypoint>

react-waypoint is effectively able to query the viewport by reading the
<Waypoint>
content
</Waypoint>

and thus handle the onEnter & onLeave events

Hi @ThekhoN, thanks for the PR!
I hadn't actually considered the child component case for my port, I had just been using it as an invisible marker to help with infiniscroll loading in Preact. I've updated preact-waypoint to render children if they exist, if you bump to 1.0.7 it should be fixed.


Ctrl generalize

Just creating a PR so that I can comment directly on GitHub.

Quick first remark: before merging with ProjectQ, you will need to remove all the unnecessary added files and folders like:

.idea
err.txt

Also, you need to modify the tests, at least for projectq/meta/_control.py and some test projectq/setups/decompositions/_controlstate_test.py


Throw clearer errors on marketplace.list method

We need to create script error types for the following errors when calling list:

[ ] If the caller does not have the lister role, throw an error
[ ] If the caller does not own the token at the specified asset contract address, throw an error
[ ] If the quantity is 0, throw an error
[ ] If the quantity is > the tokens per buy, throw an error

As of right now most of these errors just throw a failed to estimate gas error which is useless to the caller and makes it impossible to demystify what's throwing the error.

Expectations:

Create the market.test.ts test file
Create a test for each of the error cases above
Create strict error types for each of the errors listed on the ticket
Test that each of the error cases above throw the correct error

#97


Didn't find a registered implementation for 'tcp' with type URL: 'envoy.extensions.filters.network.tcp_proxy.v3.TcpProxy'

Dear Envoy Community,
We try to use Envoy in conjunction with Istio.
Our goal is to route specific traffic via an additional proxy.
We setup the following Envoy object (see below) in Istio but receive the following error:
_warning	envoy config external/envoy/source/extensions/config_subscription/grpc/delta_subscription_state.cc:269
delta config for type.googleapis.com/envoy.config.listener.v3.Listener rejected:
Error adding/updating listener(s) virtualOutbound:
Didn't find a registered implementation for 'tcp' with type URL:
'envoy.extensions.filters.network.tcp_proxy.v3.TcpProxy'_

Any help / guidance what we do wrong is appreciated - thanks in advance
Here our config:
metadata:
  name: traffic-routing
  namespace: envoy-config
spec:
  configPatches:
  - applyTo: LISTENER_FILTER
    match:
      listener:
        portNumber: 15001
    patch:
      operation: INSERT_FIRST
      value:
        name: tcp
        typed_config:
          "@type": type.googleapis.com/envoy.extensions.filters.network.tcp_proxy.v3.TcpProxy
          stat_prefix: TCPProxy
          cluster: externalProxyCluster
  - applyTo: CLUSTER
    match:
      context: ANY
    patch:
      operation: ADD
      value:
        name: externalProxyCluster
        load_assignment:
          cluster_name: proxyCluster
          endpoints:
          - lb_endpoints:
            - endpoint:
                address:
                  socket_address:
                    address: IP.address
                    port_value: portNumber

Sorry any chance you can provide the Envoy config rather than the istio config?  Envoy logs would hopefully have the envoy yaml

Hi @alyssawilk
Thanks for the quick reply. We were actually able to solve the issue.
Seems that the "applyTo: LISTENER_FILTER" was wrong; we are now using "applyTo: NETWORK_FILTER" instead.
However we were not able to solve your initial problem to route specific traffic to an additional proxy outside of our cluster.  Reason: the object "envoy.filters.network.tcp_proxy" seems only to allow one 'cluser' (destination).
Will close this ticket an open a new one.


Make path-style "as-needed" parameters not warn for strings with dots or brackets

Hi,
Thank you for this great plugin.
Configuration:
"lodash/path-style": ["error", "as-needed"]
consider the following code:
const obj = {
    a: {
        "b.c": {
            d: 3
        }
    }
};

_.get(obj, ['a', 'b.c', 'd']); // -> 3

The rule will mark it as error and suggest to use a string for paths, but
_.get(obj, 'a.b.c.d');
Is not equivalent code and will not work.
My suggestion is that "as-needed" configuration will not warn if the strings in the array contain dots or square brackets.

After thinking it though, I found that this code can be written in string form:
_.get(obj, 'a["b.c"].d');
So the error message for _.get(obj, ['a', 'b.c', 'd']); is correct.
However I found another issue:
When using this rule with --fix on this code it will transform the code to:
_.get(obj, 'a[b.c].d'); (note the missing quotes around b.c).

Related bug with the --fix option:
With options [2, "as-needed"], this rule suggests the following diff:
- lodashGet(obj, ['E', `foo_${a}_${b}`])
+lodashGet(obj, `E${`foo_${a}_${b}`}`)

This is, of course, incorrect (there is no . between E and the first template string) - but furthermore, imo template strings should really be considered as variables and this suggestion shouldn't be made in the first place.


Add minimum PHP version to composer.json

What version of PHP are you using to build the site?  I'd like to add that to the composer.json requirements so future contributors know which features they can/can't use when contributing.

I've been building the site from my most out-of-date computer, but I've added a minimum version of PHP 7 for now.

Thanks!
On Thu, Oct 19, 2017, 22:31 Philip Sharp<EMAIL_ADDRESS>wrote:

I've been building the site from my most out-of-date computer, but I've
added a minimum version of PHP 7 for now.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/philipsharp/afieldguidetoelephpants/issues/72#issuecomment-338089171,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMVMkVT8Gv2VpQwrzAKxmSaXHMSEst0ks5suAX5gaJpZM4P4g7X
.


Integrate lmdeploy pipeline api

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
Checklist
Before PR:

[ ] Pre-commit or other linting tools are used to fix the potential lint issues.
[ ] Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
[ ] The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
[ ] The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

[ ] If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
[ ] CLA has been signed and all committers have signed the CLA in this PR.

It was found that the accuracy degraded compared to the engine integration.
I am debugging it and will let you know once it is ready

use newest lmdeploy code with opencompass main and this pr to do evaluation (batch_size = 1):
main code: https://github.com/InternLM/lmdeploy/actions/runs/11251926631
pr code: https://github.com/InternLM/lmdeploy/actions/runs/11252037673
there scores are different.
use vimdiff to compass predictions. Is that expected? @lvhan028

@zhulinJulia24 in main branch, BOS token is missed when tokenizing the message. https://github.com/open-compass/opencompass/blob/d2ab51abbd628b3b2c260c403ffc069c4d0a43ee/opencompass/models/turbomind_with_tf_above_v4_33.py#L178
In this PR, BOS token is added.
That's the reason


Questions about the mAP of DOTA in paper

Which schedule is adopted?(It seems 12 epochs if trained for 30k iterations with batch8)
Are multi-scale training and random rotation used as data augment for results marked as belowing?

12 epochs in my impression.
yep, we have reported it in the paper.


(nomacs)/.portable - use github release page instead of outdated nomacs website

nomacs/nomacs.portable: the previously used page to check for new releases doesn't seem to be updated by the software maintainers any more, directly use the GitHub release page instead.
verified it actually get's the correct version by manually running the iwr & regex - link match in powershell.

:x: Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

:x: Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

:white_check_mark: Package verification completed without issues. PR is now pending human review

:white_check_mark: Package verification completed without issues. PR is now pending human review


ERROR Timeout communicating with IPFS daemon on   rad daemon-radicle --debug

system details

radicle version 0.0.4
amd64/darwin installed via brew
suddenly stopped working
no errors posted on rad daemon-ipfs --debug
testing api and made several sequential calls to rad project init when failure occured.

terminal output
rad project init
Could not connect to the Radicle daemon, most likely it is not running. Please see the documentation for how to start it

rad daemon-radicle --debug
ERROR Timeout communicating with IPFS daemon machine-id=... api-path=name/publish

ref https://github.com/radicle-dev/radicle/issues/587

Deleted my machines.json file  and I ran  rad daemon-radicle --debug
ERROR   Could not create IPFS machine message=Timeout communicating with IPFS daemon api-path=name/publish

Removing and reinstalling. results in the same problem.  Maybe restart some services its calling to communicate?


Make HasAborts public again

See #325

That's so odd, I'd expect Kyo's tests to be failing. It seems the compiler somehow leaks the type as public since it's used in RunDsl, which I think should fail compilation.


Navigating to error line number in Rider from Godot editor debugger console is off-by-one.

Fix https://github.com/JetBrains/godot-support/issues/61

It would be nice to amend the commit message to be more explicit about what the commit does (i.e. in English and not just with a URL), e.g.:
Fix off by one error navigating to line number in Rider

Fixes https://github.com/JetBrains/godot-support/issues/61

This makes the commit message useful when not viewing it on GitHub.

It would be nice to amend the commit message to be more explicit about what the commit does (i.e. in English and not just with a URL), e.g.:
Fix off by one error navigating to line number in Rider

Fixes https://github.com/JetBrains/godot-support/issues/61

This makes the commit message useful when not viewing it on GitHub.

It would be nice to amend the commit message to be more explicit about what the commit does (i.e. in English and not just with a URL), e.g.:
Fix off by one error navigating to line number in Rider

Fixes https://github.com/JetBrains/godot-support/issues/61

This makes the commit message useful when not viewing it on GitHub.

done

It would be nice to amend the commit message to be more explicit about what the commit does (i.e. in English and not just with a URL), e.g.:
Fix off by one error navigating to line number in Rider

Fixes https://github.com/JetBrains/godot-support/issues/61

This makes the commit message useful when not viewing it on GitHub.

done

Thanks!

Thanks!

Cherry-picked for 3.2.4.


problem with shuffle when unpack is set to true

Currently randomization.repeat module shuffles the output of unpackArray when it probably should be the reverse. Changing 998-1002 to:
if (unpack) {
return unpackArray(out);
} else {
return shuffle(out);
}
fixes the error.
As of now it returns an error saying "Array.slice" is not a function because it is trying to slice an object (the output of unpackArray)

this is now fixed in 5.0. just needed to remove the redundant shuffle on the return statement.


Support for 'h' suffix.

A lot of my existing nasm code is using hex numbers in the format with the trailing 'h' (e.g. "0100h" instead of "0x100").
I don't know if this project is actively maintained, but it would be nice to have support for that alternate number format. I don't want to go through the whole forking process to be able to submit a pull request, but I did put together this little mod to add that in which seems to work fine as a potential starting place (I only bothered with SASM.COM, I'm sure doing this in the C version is fairly trivial):

diff --git a/sasm.asm b/sasm.asm
index 1e57006..9766700 100644
--- a/sasm.asm
+++ b/sasm.asm
@@ -833,11 +833,32 @@ Expect:

 ; Get number from Token to AX
 GetTokenNumber:
+               xor dl, dl                                      ; assume no "h" suffix
         cmp word [UToken], '0X'
         je .Hex
-        ; Decimal number
+
+               ; check if it has h suffix though (e.g. "0100h")
         xor ax, ax
         mov bx, UToken
+
+               mov al, [TokenLen]                      ; read length of token
+               add bx, ax                                      ; move past end of token
+               dec bx                                          ; back to point at last char
+               mov al, [bx]                            ; fetch last char of token
+
+               cmp al, 'H'                                     ; has "h" suffix?
+               jne .decimal                            ; if not, treat as decimal
+
+               ; hex number with 'h' suffix
+               inc dl                                          ; don't skip 2 chars for "0x" below
+        mov cl, [TokenLen]                     ; decrement len to process
+               dec cl                                          ; take off the 'h'
+               jmp short .Hex2
+
+.decimal:
+        ; Decimal number
+        mov bx, UToken
+               xor al, al
         xor ch, ch
 .Dec:
         mov cl, [bx]
@@ -858,11 +879,17 @@ GetTokenNumber:
 .Hex:
         mov cl, [TokenLen]
         sub cl, 2
+.Hex2:
         cmp cl, 4
         ja .Error
-        xor ax, ax
+
         mov bx, UToken
+               test dl, dl
+               jnz .noskip0x
         add bx, 2
+.noskip0x:
+
+        xor ax, ax
 .HexCvt:
         shl ax, 1
         shl ax, 1

Proper intel syntax hex literals (0xnnnnH) are a good idea to support! Never really liked the syntax, so I just always used 0xnnnn as allowed by nasm.
To be honest, I haven't touched the code in a number of years, but the code is maintained in the sense that I've so far responded to every issue :)
Your way seems fine, but just to jog my memory of how things work, I've done it slightly differently and added a test: https://github.com/mras0/sasm/tree/HexSuffix
If that works for you, I'll merge it into master

Cool, I like how you did it and it does assemble my test cases just as well as my version. If I had any nitpicky at all which I really don't, it would be around needing to push/pop si which I was trying to avoid needing to use the stack for speed, but as a result you end up fetching a lot less instructions than I did so I'm sure it's a win.
I may have been being a little overly cautious in mine; I wasn't certain if I could do the "fancy" addressing modes ("cmp byte [bx+si-1]") on an 8086/80286. I don't have an 8086 but I did test your patch on a real 286 and it's fine, plus I see there's a few other similar uses of those modes already in the program so this is absolutely probably a better way to get a pointer to the last char.
Not being fully familiar with the program I also wasn't 100% sure if it was okay to corrupt the dl register in that subroutine (that I used to signal it was the 'h' form so as not to skip two chars for the "0x"). Your version doesn't need to do that though so doesn't really matter anymore. It's great for the original author to do it because even if you don't 100% remember everything you'll probably have a better idea of stuff like that than I would just due to knowing your own coding style, at least from when I've looked at old projects of mine that's how it seemed.
I'll admit I don't fully understand the part in lines 867-873, I thought this was to deal with leading zeroes somehow, but I can't tell any difference any behavior from my version that was missing that part, maybe it's just an optimization for the number "0h" / "00h":
.HexSuffix:
        dec cl
        cmp byte [bx], '0'
        jne .HexCheckLen
        inc bx
        dec cl
        jnz .HexCheckLen
        ret

Your C version is much cleaner than the lazy hack I made for that after the OP as well. So overall looks great to me.

BTW I also noticed that sasm doesn't support the "jle" and "jge" instructions. These are just synonyms for the existing "jng" and "jnl" mnemonics so are really easy to just add to the table:
 ▶ git diff sasm.asm sasm.c
diff --git a/sasm.asm b/sasm.asm
index 0ff60e9..91a920e 100644
--- a/sasm.asm
+++ b/sasm.asm
@@ -3456,8 +3456,12 @@ DispatchList:
     dw InstJCC
     db 'JL',0,0,0,0, CC_L
     dw InstJCC
+    db 'JGE',0,0,0,  CC_NL
+    dw InstJCC
     db 'JNL',0,0,0,  CC_NL
     dw InstJCC
+    db 'JLE',0,0,0,  CC_NG
+    dw InstJCC
     db 'JNG',0,0,0,  CC_NG
     dw InstJCC
     db 'JG',0,0,0,0, CC_G
diff --git a/sasm.c b/sasm.c
index b73deb2..4d6dad6 100644
--- a/sasm.c
+++ b/sasm.c
@@ -1919,8 +1919,10 @@ static const struct {
     { "JPE"    , &InstJcc         , JPE  },
     { "JPO"    , &InstJcc         , JPO  },
     { "JL"     , &InstJcc         , JL   },
+    { "JGE"    , &InstJcc         , JNL  },
     { "JNL"    , &InstJcc         , JNL  },
     { "JNG"    , &InstJcc         , JNG  },
+    { "JLE"    , &InstJcc         , JNG  },
     { "JG"     , &InstJcc         , JG   },
     };

I was going to add support for "xlat" as well, but upon starting I noticed that sasm does already implement it as "xlatb", and documentation seems to indicate that's actually correct, so even though I've always seen it written just "xlat" in every assembler and debugger I've used before, I'm unsure whether or not it'd be appropriate to just add "xlat" as a synonym to "xlatb" as well.
From what I understand apparently Intel intended you to give some bogus argument to the "xlat" form for "documentation" that's then completely ignored and bx used instead, maybe something like "xlat [table]".  Another source says it allows for an segment override, so I guess something like "xlat [es:bx]", which at least could be potentially useful although I'm not sure if that's true.
However, I'm guessing as to Intel's intended syntax as I can't find any actual complete examples, and I can't get any of these forms to work in nasm, only plain "xlat" with no argument as I've usually seen, which actually appears incorrect from the documentation, so, lol....

Cool, I like how you did it and it does assemble my test cases just as well as my version. If I had any nitpicky at all which I really don't, it would be around needing to push/pop si which I was trying to avoid needing to use the stack for speed, but as a result you end up fetching a lot less instructions than I did so I'm sure it's a win.
I may have been being a little overly cautious in mine; I wasn't certain if I could do the "fancy" addressing modes ("cmp byte [bx+si-1]") on an 8086/80286. I don't have an 8086 but I did test your patch on a real 286 and it's fine, plus I see there's a few other similar uses of those modes already in the program so this is absolutely probably a better way to get a pointer to the last char.

To be honest, I didn't profile it, and your version was fine as well, just took the opportunity to reorganize the code a bit (after spending a bit of time remembering how it works..). In general I wrote the assembler incrementally with ease of implementation in mind rather than speed. The linear scan of the DispatchList is not great for speed (it should really be a hash table).
You can't use fancy addressing modes, but bx+si is one of the non-fancy ones :) (I find this page a pretty convenient reference: http://ref.x86asm.net/coder.html#modrm_byte_16)

Not being fully familiar with the program I also wasn't 100% sure if it was okay to corrupt the dl register in that subroutine (that I used to signal it was the 'h' form so as not to skip two chars for the "0x"). Your version doesn't need to do that though so doesn't really matter anymore. It's great for the original author to do it because even if you don't 100% remember everything you'll probably have a better idea of stuff like that than I would just due to knowing your own coding style, at least from when I've looked at old projects of mine that's how it seemed.

Using DX should be fine there, but I rely on the tests to keep me honest - I'd forgotten I needed to preserve SI, but luckily that was caught.

I'll admit I don't fully understand the part in lines 867-873, I thought this was to deal with leading zeroes somehow, but I can't tell any difference any behavior from my version that was missing that part, maybe it's just an optimization for the number "0h" / "00h":
.HexSuffix:
        dec cl
        cmp byte [bx], '0'
        jne .HexCheckLen
        inc bx
        dec cl
        jnz .HexCheckLen
        ret

Your C version is much cleaner than the lazy hack I made for that after the OP as well. So overall looks great to me.

It is skipping a (single) leading '0' (and handling '0H' directly). If not there the length check (at .HexCheckLen) will fail for '0abcdH' (cl would be 5).

BTW I also noticed that sasm doesn't support the "jle" and "jge" instructions. These are just synonyms for the existing "jng" and "jnl" mnemonics so are really easy to just add to the table:
 ▶ git diff sasm.asm sasm.c
diff --git a/sasm.asm b/sasm.asm
index 0ff60e9..91a920e 100644
--- a/sasm.asm
+++ b/sasm.asm
@@ -3456,8 +3456,12 @@ DispatchList:
     dw InstJCC
     db 'JL',0,0,0,0, CC_L
     dw InstJCC
+    db 'JGE',0,0,0,  CC_NL
+    dw InstJCC
     db 'JNL',0,0,0,  CC_NL
     dw InstJCC
+    db 'JLE',0,0,0,  CC_NG
+    dw InstJCC
     db 'JNG',0,0,0,  CC_NG
     dw InstJCC
     db 'JG',0,0,0,0, CC_G
diff --git a/sasm.c b/sasm.c
index b73deb2..4d6dad6 100644
--- a/sasm.c
+++ b/sasm.c
@@ -1919,8 +1919,10 @@ static const struct {
     { "JPE"    , &InstJcc         , JPE  },
     { "JPO"    , &InstJcc         , JPO  },
     { "JL"     , &InstJcc         , JL   },
+    { "JGE"    , &InstJcc         , JNL  },
     { "JNL"    , &InstJcc         , JNL  },
     { "JNG"    , &InstJcc         , JNG  },
+    { "JLE"    , &InstJcc         , JNG  },
     { "JG"     , &InstJcc         , JG   },
     };

I've added these (and xlat).

I was going to add support for "xlat" as well, but upon starting I noticed that sasm does already implement it as "xlatb", and documentation seems to indicate that's actually correct, so even though I've always seen it written just "xlat" in every assembler and debugger I've used before, I'm unsure whether or not it'd be appropriate to just add "xlat" as a synonym to "xlatb" as well.

I originally added it as xlatb since that's what nasm disassembles it to, but I agree that "xlat" is more natural.

From what I understand apparently Intel intended you to give some bogus argument to the "xlat" form for "documentation" that's then completely ignored and bx used instead, maybe something like "xlat [table]".  Another source says it allows for an segment override, so I guess something like "xlat [es:bx]", which at least could be potentially useful although I'm not sure if that's true.
However, I'm guessing as to Intel's intended syntax as I can't find any actual complete examples, and I can't get any of these forms to work in nasm, only plain "xlat" with no argument as I've usually seen, which actually appears incorrect from the documentation, so, lol....

Yeah, I think xlat allows for segment override. The reason I like nasm syntax is that it isn't clunky, so I don't like a "dummy" argument that always has to be some for of [(seg:)bx]. The nasm way would be es xlat (https://www.nasm.us/xdoc/2.16.03rc1/html/nasmdoc3.html#section-3.1), but that isn't supported (yet). As a workaround you can use:
        db 0x26 ; ES segment override for..
        xlat

If you search for "xlat" on this page, NASM apparently just treats xlat as a synonym for xlatb with no argument expected or possible. I've NEVER seen the form "xlat [some label that presumably is also loaded into bx but ain't nobody checking]", so, maybe other people thought it was a dumb idea too and didn't implement it.
I actually kind of like "es xlat". I don't have a use for it right now, but I'll have to try that (or it's db-bodged form).
Nice reference, x86 is such a nonorthogonal mess that whenever I do 8086 assembly there always ends up being a case at some point where I'm just trying different things to see if they assemble and then going, "oh well that's unfortunate, now I have to spill......am I sure there's not some other form that's faster?". The only CPU I've worked with where every supposed "general purpose" register has a caveat of "but you must use it when doing this instruction and oh you can't with that one".


Cosmos DB remove 404 response on databaseAccounts GET

Removing documented 404 responses on database account "GET" so that generated SDKs throw exception on this response. This is required to fix a scenario in the CLI where methods are continuing with a NoneType object
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.

adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

/azp run automation - sdk

Can one of the admins verify this patch?

@shurd pls fix the model validation error

/azp run automation - sdk

@ruowan This change causes the SDK to throw an exception when the resource is not found, which is the expected behavior. We previously had this behavior, but mistakenly added 404 as an "ok" response. Right now, SDK users will just get "null" if the resource does not exist. This can cause problems if users (such as the CLI) were expected an exception.

Ok. I put Approved-BreakingChange. Is the PR ready to merge?

Yes, thanks

@Juliehzl for awareness


[VS] Participants list can be distracting when guests are frequently joining/leaving

I use this for a classroom setting. When I start the session I get a message about logging in (to GitHub), then I get a message about the session starting and option to make it read only. Every time somebody connects I get another message.
This is really distracting. I want to click the share button and it just be done (maybe a toast after it is running or something). While teaching class it is distracting to see the "connected", "dropped" and "reconnected" messages as students go on and offline. I want the ability to disable all this.
Additionally the participants are shown as bubbles in the menu area. As more students join these bubbles start taking up way more space. I don't personally care about who is connected in the class as much as I care about how many. It would be nice to just have a bubble (maybe in the existing icon that is already shown) that shows me a count and/or allows me to see the participants at that point. It would also avoid the distraction of the bubbles coming and going as students connect and disconnect.

@CoolDadTx Thanks for reaching out! This is very useful feedback, and is something we're actually working on right now. We're tracking this issue via #1069, so I'm going to close it as a dupe.
That said, since you mentioned that you're using Live Share for a classroom setting, I'd love to chat further with you about your broader feedback. If you'd be interested to sync, feel free to ping me directly at<EMAIL_ADDRESS>Thanks!

@CoolDadTx Actually, I'm going to re-activate this issue, and re-purpose it to be specific to your feedback about the participants list in VS. #1069 captures the general issue about notification noise, but we'll use this issue to discuss optimizing the VS participants list to be less distracting in a classroom setting.

Looks good to me.

I’m going to close this issue for now since we haven’t heard significant interest in this change, and folks can workaround it by simply collapsing the Live Share tool window. Please let us know if this is something that folks would still like to see us invest in, and we can reassess if it fits in our roadmap. Thanks!


Multiline comments cause error in parsing

This parses ok:
;; foo
 ;; bar

this doesn't:
;; foo
;; bar

The only difference is that in the first example, there's a space before the first semicolon on the 2nd line. Without that whitespace, the parser errors with Err(ParserErrorWithContext { context: [], row: 1, col: 2, error: UnexpectedCharacter(';') })
I looked at the unit tests and they don't cover this, the comment tests all have whitespace.
Here's a tiny reproducer:
extern crate edn_format;

fn main() {
    println!("{:?}", edn_format::parse_str(";; abc\n;; def \n\n ced"));
}

Taking a look now

@skyrod-vactai This should be fixed now in 3.2.3. Let me know if you run into anything else + what you are using the library for (genuinely curious)

I'm developing a simple programming language (closely related to Joy). Its source code (and data, it's homoiconic) is a subset of edn (vectors, boolean, string, numbers, symbols, and one reader tag for base64 encoded bytes). I'm using your lib as the reader/writer. Thanks for making the lib and being so responsive to my bug report. I'm about to upgrade and try out the fix.

Fixed! Thanks!

@skyrod-vactai As far as i am aware you are my only user, so if you have any issues/questions or just want a rubber duck feel free to message me on whatever platform


refactoring "info" and its links

This PR addresses part of the "deep link to the framework" problems. It:

moves the framework "info" to a separate file
adds another info.yaml / .json to the models in "common" and changes refereces from model schemas to this local version

Both steps are complementary; if also going with the separate version in the model we might consider this for e.g. ontologyTerm, too (already a separate file in the framework).

Thanks @costero-e; please check with @jrambla, or we do a merging session :-)


[Solid] Solid example is not working

Prerequisites

[X] I have written a descriptive issue title
[X] I have searched existing issues to ensure the bug has not already been reported

Fastify version
3.27.4
Plugin version
No response
Node.js version
16.14.0
Operating system
Linux
Operating system version (i.e. 20.04, 11.3, 10)
PopOS 21.10
Description
Hello,
I want to use fastify vite for a solid js application. But I don't know why but it seems fastify-vite is incompatible with solid-app-router. As I see maybe there is an invalid configuration who display this error :
❯ pnpm dev

><EMAIL_ADDRESS>dev /home/quentin/Documents/dev/fastify-solid
> ts-node-dev --no-notify --respawn --transpile-only ./src/app.ts

[INFO] 08:33:43 ts-node-dev ver. 1.1.8 (using ts-node ver. 9.1.1, typescript ver. 4.6.3)
8:33:44 AM [vite] Error when evaluating SSR module @app/client.jsx:
file:///home/quentin/Documents/dev/fastify-solid/node_modules/.pnpm/solid-app-router@0.3.2_solid-js@1.3.13/node_modules/solid-app-router/dist/index.js:1
import { isServer, template, createComponent as createComponent$1, mergeProps, spread, insert, effect, setAttribute } from 'solid-js/web';
                                                                                ^^^^^^
SyntaxError: The requested module 'solid-js/web' does not provide an export named 'effect'
    at ModuleJob._instantiate (node:internal/modules/esm/module_job:127:21)
    at ModuleJob.run (node:internal/modules/esm/module_job:191:5)
    at async Promise.all (index 0)
    at ESMLoader.import (node:internal/modules/esm/loader:337:24)
    at importModuleDynamicallyWrapper (node:internal/vm/module:437:15)
    at nodeImport (/home/quentin/Documents/dev/fastify-solid/node_modules/.pnpm/vite@2.8.6/node_modules/vite/dist/node/chunks/dep-9c153816.js:56262:21)
    at eval (@app/client.jsx:14:31)
    at instantiateModule (/home/quentin/Documents/dev/fastify-solid/node_modules/.pnpm/vite@2.8.6/node_modules/vite/dist/node/chunks/dep-9c153816.js:56193:9)
8:33:44 AM [vite] Error when evaluating SSR module<EMAIL_ADDRESS>file:///home/quentin/Documents/dev/fastify-solid/node_modules/.pnpm/solid-app-router@0.3.2_solid-js@1.3.13/node_modules/solid-app-router/dist/index.js:1
import { isServer, template, createComponent as createComponent$1, mergeProps, spread, insert, effect, setAttribute } from 'solid-js/web';
                                                                                ^^^^^^
SyntaxError: The requested module 'solid-js/web' does not provide an export named 'effect'
    at ModuleJob._instantiate (node:internal/modules/esm/module_job:127:21)
    at ModuleJob.run (node:internal/modules/esm/module_job:191:5)
    at async Promise.all (index 0)
    at ESMLoader.import (node:internal/modules/esm/loader:337:24)
    at importModuleDynamicallyWrapper (node:internal/vm/module:437:15)
    at nodeImport (/home/quentin/Documents/dev/fastify-solid/node_modules/.pnpm/vite@2.8.6/node_modules/vite/dist/node/chunks/dep-9c153816.js:56262:21)
    at eval (@app/client.jsx:14:31)
    at instantiateModule (/home/quentin/Documents/dev/fastify-solid/node_modules/.pnpm/vite@2.8.6/node_modules/vite/dist/node/chunks/dep-9c153816.js:56193:9)
file:///home/quentin/Documents/dev/fastify-solid/node_modules/.pnpm/solid-app-router@0.3.2_solid-js@1.3.13/node_modules/solid-app-router/dist/index.js:1
import { isServer, template, createComponent as createComponent$1, mergeProps, spread, insert, effect, setAttribute } from 'solid-js/web';
                                                                                ^^^^^^
SyntaxError: The requested module 'solid-js/web' does not provide an export named 'effect'
    at ModuleJob._instantiate (node:internal/modules/esm/module_job:127:21)
    at ModuleJob.run (node:internal/modules/esm/module_job:191:5)
    at async Promise.all (index 0)
    at ESMLoader.import (node:internal/modules/esm/loader:337:24)
    at importModuleDynamicallyWrapper (node:internal/vm/module:437:15)
    at nodeImport (/home/quentin/Documents/dev/fastify-solid/node_modules/.pnpm/vite@2.8.6/node_modules/vite/dist/node/chunks/dep-9c153816.js:56262:21)
    at eval (@app/client.jsx:14:31)
    at instantiateModule (/home/quentin/Documents/dev/fastify-solid/node_modules/.pnpm/vite@2.8.6/node_modules/vite/dist/node/chunks/dep-9c153816.js:56193:9)
[ERROR] 08:33:44 SyntaxError: The requested module 'solid-js/web' does not provide an export named 'effect'

I see an issue who have the same error : https://github.com/solidjs/solid-app-router/issues/80
Steps to Reproduce
I give a reproduction repository : https://github.com/qlaffont-flexper/fastify-solid-vite-example
Expected Behavior
No response

Thanks @qlaffont-flexper — the Solid adapter is still quite new and experimental, so this should be useful debugging it.

Yes, no problem logically you have everything to debug it. Tell me if I can help by any way. ^^

SyntaxError: The requested module 'solid-js/web' does not provide an export named 'effect'

I have ran into this same exact issue myself. For now I have deprecated the Solid example until I'm able to debug it.
Will update this issue when there are news in that front.

This appears to be a bug with solid. solid-app-router is importing effect from solid-js/web, but that module indeed only has two export statements and neither include effect:
export { ErrorBoundary, For, Index, Match, Show, Suspense, SuspenseList, Switch, createComponent, mergeProps } from 'solid-js';
// ...
export { Assets, Dynamic, HydrationScript, NoHydration, Portal, escape, generateHydrationScript, getHydrationKey, isServer, pipeToNodeWritable, pipeToWritable, renderToStream, renderToString, renderToStringAsync, resolveSSRNode, spread, ssr, ssrAttribute, ssrClassList, ssrHydrationKey, ssrSpread, ssrStyle };

Reported at: https://github.com/solidjs/solid/issues/1040

I ran into that — I've traced it down to the plugin missing the ssr setting. See the new working example.

Oh, interesting, you're getting that with that new example — so weird. It works for me but I'll check again.

I'm unable to reproduce, the example boots and runs fine for me.


Update connect-cisco.md

Update to add supported Cisco ASA event list

@sarah-yo : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@sarah-yo Hi Sarah,
We are currently revamping and refactoring the documentation of the data connectors altogether (and all together). I will include this important information in the new documentation, but as the current document will shortly be deprecated, you should close this PR.
Thanks for your contribution!
Yechiel

@yelevin thanks for the update and thank you for putting this in the new documentation, quite a few customers have asked for this info!