Fix setState regression

I have noticed the following regression after upgrade to enzyme 3.4.4.

TypeError: ReactWrapper::setState() expects a function as its second argument

I think that we are closer to how React behaves this way: https://github.com/facebook/react/blob/5031ebf6beddf88cac15f4d2c9e91f8dbb91d59d/packages/react-reconciler/src/ReactFiberClassComponent.js#L77-L92

Well, my fix is probably wrong, but at least you get the idea. This is fine with React, I don't think that enzyme should throw.
this.setState({}, null);
this.setState({}, undefined);

enzyme is a test framework - its job is to catch bugs

How is it a bug if it's working in production?

Do you have a legitimate use case for passing a falsy non-function to either setState or setProps?

I believe I have, the callback parameter is optional in my case, it can be undefined:
https://github.com/mui-org/material-ui/blob/a29c7f1a7ee885b70159856212206e99b8e86e56/packages/material-ui/src/ButtonBase/TouchRipple.js#L248

If you pass undefined with the current code, it will not throw - the default argument will replace it.

It's a bug because it's unintentional - that something happens to work doesn't make it not a bug.
If you're passing "not a callback", and "not nothing", where a callback is expected, you made a mistake, plain and simple.

If you pass undefined with the current code, it will not throw

If you pass undefined with the current, it will throw.

Ah, you're right, I added that to setState (but not setProps).
That stricter check, however, has already caught a bug in someone's code - see #1769. I think that in this case the benefits outweigh the deviation from React in production. (Separately, I'm going to try to pursue adding the same strict check in react itself in v17)

I do see, however, that because of recent changes, the wrapper's setState will be called in your component code because we stub the instance's setState. That does seem like something we could fix, in the ShallowWrapper constructor - which would allow your code to work - but it would prevent people from being able to catch bugs like in #1769.

Separately, I'm going to try to pursue adding the same strict check in react itself in v17

@ljharb My main purpose with this pull request was to illustrate the change of behavior. I have already patched the Material-UI code to always have a callback function. Personally, I would stick to React behavior as much as possible. But I can understand you have a different vision. Do what you think is best.

Per the discussion; I'm going to address this by leaving the wrapper methods strict, but by making the shallow setState stub match React. This way, your code won't error, but people directly calling the methods on the wrapper will get the desired error.

leaving the wrapper methods strict, but by making the shallow setState stub match React.

@ljharb I haven't checked the implementation, but the behavior description sounds great :)!


Add anonymous permission

If there is no sensitive information in a repository, users may want to make the repo public and allow access without an access token. ANONYMOUS could be added as a new permission in addition to OWNER, MEMBMER and GUEST.

May I look into this issue? 😄


Add third party billing support

Extrinsics
Getters

https://github.com/threefoldtech/tfchain_client_js/commit/08b47643fe04e02c47e55afc1a132086a0ca27aa

As explained in the two comments below all the functions above have been verified.
https://github.com/threefoldtech/tfchain/issues/445#issuecomment-1403963829
https://github.com/threefoldtech/tfchain/issues/562#issuecomment-1403925274


Send page feedback using gtag

Closes #974

/cc @aijamalnk
/kind bug

@chalin: GitHub didn't allow me to request PR reviews from the following users: aijamalnk.
Note that only falcosecurity members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Closes #974

/cc @aijamalnk
/kind bug

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: chalin
Once this PR has been reviewed and has the lgtm label, please assign leogr for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: chalin, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Love the repository, but quick issue.

I see there is a Medium integration in the src/section/Articles/
How does this piece of code work exactly, and where does it have a place to pull from a specific user's Medium feed?
I can't see how it is integrated with the Markdown exactly.
It is not put in the example so is it useable?
Thank you for anyone who could answer this question!

Hey 👋  Yes, you can definitely use it! All you have to do is to provide a URL to your Medium profile in the settings.json file. This profile URL will be used to fetch the articles (see here).
You can then just add the Articles section to your page and define Medium as a source (as in the example here).
Hope this helps 🙂


VLS-128 velodyne driver added

velodyne_vls folder is added to support Velodyne VLS-128 sensor for ROS.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @lianglia-apollo ,
The reason why we created a separate 'velodyne_vls' folder is that I don't know who manages 'velodyne' folder. I didn't want to make any changes or combine with someone else's work. Would it be okay if we keep 'velodyne_vls' folder under my responsibility and keep updating for our upcoming products?


Design documentation for the NonAdminBackup Status and Conditions

Two proposals for updating and keeping in sync NonAdminBackup Status and Condition fields.
The Status also consists of Velero Backup Name within NAB object.

Just needs update on which approach we are going ahead with.


Ability to change default horizontal line color

Hi there! I'd like to be able to change the color of the default horizontal lines. Is there any way to achieve it? Thanks so much! The API on the project is second to none!

Hi there, there is a gridData field inside the LineChartData,
you can customize the grid lines in your way.


Merge designSpaceDocument

Hello,
This MR import the whole history of https://github.com/LettError/designSpaceDocument (master branch only) into fontTools, as per

https://github.com/LettError/designSpaceDocument/issues/28
https://github.com/fonttools/fonttools/issues/911

I have a few questions:

Is the new module name OK? (fonttools.designSpaceDocument)
Where should I move the documentation? It is in README.md and scripting.md. Maybe in Doc/source/designSpaceDocument/ and translated to reStructuredText? I don't know Sphinx and I don't know how documentation is handled in this project or in Python in general, so I will gladly take any advice or links to relevant documentation/best practices!
Should I move the doctests and test designspace files to the Tests/designSpaceDocument folder?
Should I turn the doctests into unittest.TestCases?
Should I delete the UFO-specifics parts, as suggested in https://github.com/LettError/designSpaceDocument/issues/28#issue-274587260?
What else is there to do in this MR?

Thanks in advance!
@LettError @anthrotype

thanks Jany!
about the module name: I'm fine with either keeping the original name fontTools.designSpaceDocument, or change to something like fontTools.designspaceLib (for consistency with ttLib, varLib), or even a compressed dsLib. I also wouldn't mind  fontTools.designspace.
About the documentation: yes, ideally we would have it converted to reStructuredText and built with Sphinx. I'm also not very familiar with this stuff honestly. What we have in Doc/ folder right now is simply pulling the docstrings (most of which are not properly formatted). I know pandoc can covert between markdown and restructuredtext. Maybe for know that would be enough.
about the tests: since we have all our other tests in a separate folder, we should do the same for this new sub-package. And yes, ideally we should port doctests to unittest (I personally prefer pytest-style tests, which is also our test runner, but I'm ok with both). We can leave some doctests to document the API and ensure examples actually run.
and finally, we should delete the ufoProcessor.py module. Let's make this ufo-agnostic, at least until we have a working fontTools.ufoLib.

designSpaceLib sgtm.

Since we tend to write "designspace" and not "design space", I would prefer designspaceLib.

Thanks everyone for the feedback! I have a new question now that I've started working on this:
designspaceLib actually imports mutatorMath. What should I do with this dependency? I could add it to requirements.txt/setup.py, but I have read about a "dependency hell", so that's why I'm asking :)
The dependency is only required by the check() and checkDefault() methods, which are not called automatically when just using the DesignSpaceDocument class, so maybe I could move the import into those methods and do NOT declare mutatorMath as a mandatory dependency of fonttools. However the existing tests that I'm going to migrate are calling those functions and thus need mutatorMath.
What should I do?

checkDefault() is used when no source is designated as the neutral and we need to find one to be able to move on. Maybe this could move to ufoProcessor which already has a mutatorMath dependency. And that was going to be split off anyway;

designspaceLib actually imports mutatorMath

It sholdn't need to do that, aside from the ufoProcessor.py which we are getting rid of.
Let's reimplement those function here and not require mutatorMath.
MutatorMath shuld require fontTools, not the other way around.

OK thanks!

MutatorMath shuld require fontTools, not the other way around.
Not sure I agree with that.

@LettError what I meant by that is that fontTools is a lower-level library, and mutatorMath something that may (or may not) build on top of fontTools. I didn't mean it has to :)

MutatorMath only depends on standard modules. FontTools on the other hand..
Anyway, I understand your question and I'll prepare a separate ufoProcessor thing. Note if checkDefault moves out of DesignSpaceDocument it might be necessary to throw a meaningful exception if there is no origin defined in the sources. Or maybe declare the origin explicitly so we don't have to rely on the copyInfo flag.

I'll try to review this soon.

Same question for dependency on defcon: it's only used by the function getFonts(), so I can either remove that function and the fontClass parameters/attributes, or keep everything but delay the import of defcon to when someone actually calls getFonts().

how important is to keep that getFonts function in?
I would prefer to avoid adding any UFO related dependency

@belluzj for the travis test failure you have to merge origin/master or rebase on it, because Travis CI now ships a new osx image with an updated homebrew, so when we do brew install python3 we now get python3.6 (previously it was 3.5). The .travis.yml needs to be updated like so
https://github.com/fonttools/fonttools/commit/b0bf3ce4f5cb82e22fa13ecf975d3bd258cd9afa

It does not look like a very important function, just a convenience helper.
The mutatorMath-dependent function actually looks much more complex and useful and the existing tests depend on it, so I'm considering leaving it here, and stripping away the mutatorMath part. I'll push some code soon.

Link to view only my changes to the original designSpaceDocument: https://github.com/fonttools/fonttools/pull/1110/files/44727fe32a475632edfa8b213419bbf178da99c0..4e8818278b9c2547315b013b993c0b9c07dca743


Resolve json Unmarshal error when API returns an int instead of a string

This resolves https://github.com/sashabaranov/go-openai/issues/244 .
In the case of an invalid API key, the APIError.Code is a string pointer, but APIError.Code can be an integer for other API errors, such as when the API quota has been exceeded.
By changing the APIError.Code type to json.RawMessage, we can delay parsing the value until we need it (in most cases, we probably don't need it, since the struct also contains a StatusCode and error message, in which case APIError.Code can be ignored).
I've updated the invalid API Key test to parse the string "invalid_api_key" as it did before, using a new method, APIError.CodeAsStringPtr(), but I was unable to think of a good test for the quota error that returns an integer. Despite that, I still provided a method to decode the APIError.Code as an int if anyone needs it (APIError.CodeAsInt())

@young-steveo thank you for the PR! A couple of suggestions:

Should we make the Code field private?
What if we substitute CodeAsStringPtr and CodeAsInt with a single method Code() (any, error)? That would enable users to use idiomatic Go type switches to figure out the type, e.g.

code, err := apiErr.Code()
if err != nil {
	// ... handle the error ...
}
switch v := code.(type) {
case int:
	// ... handle integer code
case string:
	// ... handle string code
}

Maybe we can go even further and ignore the error here, so apiErr.Code() would just return nil in case Unmarshal fails.

@sashabaranov Unfortunately, thejson package requires tagged fields to be exported, so changing it from Code to code prevents thejson package from unmarshalling the data (the json package uses reflect to inspect struct fields, and reflect doesn't allow access to unexported fields).
What I can do as a workaround is maybe change the field to a single letter, like C, and the end user can use Code() (any, error) as a convenience, even though they technically have access to the json.RawMessage via C.
I'll work that up for this PR and see how it looks.

@young-steveo That's right, I've completely forgotten about making fields public for json!
We may utilize custom json unmarshalling with UnmarshalJSON here. Here are a couple of possible implementations: https://go.dev/play/p/IOuvLovvnUV What do you think?

@sashabaranov  For some reason, I never thought about implementing UnmarshalJSON. I like that approach! I'll open a separate PR with that solution; if you merge that one, we can close this one, or vice-versa.

Opened a new PR https://github.com/sashabaranov/go-openai/pull/248. Left this one open for now until you decide which is the better implementation.
BTW, love this project.


Add matplotlib image support

Currently, deepforge supports using matplotlib for generating 2D plots. It would be great if this could be extended to support displaying images as well (particularly useful for image classification problems!).

Job feedback is currently encoded in the stdout for a job, decoded by the server, and then the project is updated to contain the actual corresponding objects. As matplotlib supports custom backends, we have a custom backend defined for use within deepforge which prints a JSON representation of the graph when using it for plotting.
To add support for images, we would need to:

save the image to the filesystem (add to the custom matplotlib backend)
upload the image to the deepforge server (using the blob client and retrieving the hash)

This should already be done here as long as the matplotlib backend saves the image to metadata/ as a png and then prints the cmd to stdout.
An example can be found in deepforge v1 where this was performed by a deepforge global in lua: https://github.com/deepforge-dev/deepforge/blob/v1.x/src/plugins/GenerateJob/templates/deepforge.ejs#L80-L81

encode an image update message in the stdout which passes the image info and the hash

This should already be handled by the link from the previous point

ensure that the image update message is decoded properly by deepforge and the corresponding image node is created.

This should work out of the box but there may have been changes since v1 that may require some modifications (namely here)

Now that #1329 is merged, Incremental support to Image trace with updated meta-model can be provided.

Steps for Image Support is quite different for plotly than https://github.com/deepforge-dev/deepforge/issues/1218#issuecomment-476719938.

Custom Matplotlib Backend Should be updated to get Image Information(The best strategy now is the JSON Dump a numpy Matrix although this could be changed to support any other form of encoding).
Update The MetaModel such that node Image is contained within the SubGraph.
So, the image information will now be available upon plots creation.
Update the ExecuteJob.Metadata.js to create Image Nodes upon getting the information.
Update PlotlyDescExtractor.js to get the plotly JSON from the image Node.
Update ExecutionIndexControl.js to send updates regarding Images to the Widget.


License and sync with tailwind

Hi,
Nice project.
Just wondering what's the licence of windicss, and how the sync with tailwindcss is supposed to evolve.
Thxs.

I've found my answers, sorry.


Support of Dart 2.0.0

Are you going to upgrade to Dart 2.0.0 support?

Sure! I think the changes will be minimal so it shouldn't take too long.

Actually I guess this is more complicated than I had previously thought. Dart 2.0.0 has greatly changed the way noSuchMethod works. Previously we could abuse it to allow for varargs, for example getAll
we could do any of the following:
r.getAll('moe', {'index': 'first_name'})
r.getAll('moe', 'larry, {'index': 'first_name'})
r.getAll('moe', 'larry, 'curly', {'index': 'first_name'})
Only the first example matched the method signature, the next two would be invoked through noSuchMethod. It seems that with dart 2.0, we can no longer do this.
I could still update the driver, but when writing with dart 2.0 you would not be able to follow the API, you'd have to rely on the args method a great deal in order to make the every method match it's signature:
r.getAll(r.args(['moe', 'larry, 'curly']), {'index': 'first_name'})
r.branch(hour > 12, 'Good morning', r.args([hour < 17, 'Good afternoon', 'Good evening']))
I think this really hurts readability, but I am open to suggestions and discussion.

Could you make a branch with 2.0 version?

@billysometimes, Thank you for the branch.
I try to connect and get "Server dropped connection with message: Wrong password" everytime.
I tested it with default server configuration. If I use 1.24.3 sdk I haven't connection problems.
What am I doing wrong?

I found that new PBDKF package working wrong. I update old package and make PR here

LMK if you need any help rolling this... Without Dart 2 support, I can't update package:angel_rethink, so I'm more than willing to send a PR.

Ping

Sorry about the delay. @pafik13 submitted a PR to fix the PBKDF2 package, but they haven't published a new package to pub (https://pub.dartlang.org/packages/pbkdf2).
I have updated the dart-2.0 branch to pull the package from github, so you could change your dependencies to:
  rethinkdb_driver:
    git:
      url: git://github.com/billysometimes/rethinkdb.git
      ref: dart-2.0

but quite honestly I don't know if we should publish a 2.0 compatible package until we figure out what a Rethinkdb Query with varargs should look like in a language that does not have varargs.
I'd also like to find out why the more up-to-date package:password_hash PBKDF2 utils seem incompatible with this driver.
And lastly I'm not certain it's worth updating a driver for a dead database written in a mostly dead language.

I see what you mean about them not having uploaded a new PBKDF2
package... I’ll try to email them.
Dart is far from dead - if anything, it’s more alive than ever.
If you are ever looking for another maintainer, or just contributions
in general, I’m more than happy to do it. I guess it being “worth it” is a
value judgment. To me, updating it is worth it, so whatever assistance you
need, I’ll provide.
On Sat, Nov 10, 2018 at 6:51 PM billy<EMAIL_ADDRESS>wrote:

Sorry about the delay. @pafik13 https://github.com/pafik13 submitted a
PR to fix the PBKDF2 package, but they haven't published a new package to
pub (https://pub.dartlang.org/packages/pbkdf2).
I have updated the dart-2.0 branch to pull the package from github, so you
could change your dependencies to:
rethinkdb_driver:
git:
url: git://github.com/billysometimes/rethinkdb.git
ref: dart-2.0
but quite honestly I don't know if we should publish a 2.0 compatible
package until we figure out what a Rethinkdb Query with varargs should look
like in a language that does not have varargs.
I'd also like to find out why the more up-to-date package:password_hash
PBKDF2 utils seem incompatible with this driver.
And lastly I'm not certain it's worth updating a driver for a dead
database written in a mostly dead language.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/billysometimes/rethinkdb/issues/63#issuecomment-437631203,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJiKPF98ahg8gbS8M8Ef1W2-ZSOssq3Tks5ut2adgaJpZM4WcvAW
.

flutter+rethink may be a great combo

Hello, I really liked the driver idea and would like to help in your migration to Dart 2.1, to be possible, I would like to start an immigration with you, I wanted to see this driver running on the aqueduct and on Flutter itself.

@rullyalves Angel framework has top-notch support for RethinkDB - that’s why I want to update this library.

Hi @billysometimes! I implemented some of the fixes in the varargs. Please check them. I'll try to implement the rest.

There are still some calls to dart:mirrors that prevent the use of the library on Flutter.

Thanks @billysometimes! I now have push access. @katutz Stay tuned, within the next few days, I'll work with you to land these changes and update this library for Dart 2.

Anyone here knows if using the #foo directive would impact some type of minification on dart2js or in other dart environment?
@override dynamic noSuchMethod(Invocation invocation) {   return invocation.memberName == #foo       ? Function.apply(           baz, invocation.positionalArguments, invocation.namedArguments)       : super.noSuchMethod(invocation); }
If no, we could simplify the code that I commited.

I added a pull request about the ClosureMirror removal. It is useful to make the driver works with Flutter. There is another mirror use, InstanceMirror, which can be removed with the lasts varargs fix, that still needs to be implemented.

Any updates about my last PR, @billysometimes and @thosakwe?


Tokio Runtime & Lua API Calls

I am trying to access Scylla in my API, which necessarily requires Tokio.  While #[tokio::main] can be added just fine on the library (and Scylla can be accessed fine from the main function when the library loads), it cannot be accessed in subsequent calls from any functions which are invoked from the Lua runtime. I have tested filters, actions, and functions for this.
Trying to call Tokio functions from the haproxy lua runtime throws this error,
thread '<unnamed>' panicked at 'there is no reactor running, must be called from the context of a Tokio 1.x runtime',
And trying to create or otherwise block_on with Tokio in an haproxy lua runtime throws this error,
panicked at 'OS can't spawn worker thread: Resource temporarily unavailable (os error 11)'
It's entirely possible I just don't know what I'm doing, but is there any way to make calls in a Tokio runtime when called by the haproxy?

You can force enter to Tokio runtime in a Lua module, for example:
static RT: Lazy<tokio::runtime::Runtime> = Lazy::new(|| {
    std::thread::spawn::<_, ()>(|| RT.block_on(futures::future::pending()));
    tokio::runtime::Builder::new_current_thread()
        .enable_all()
        .build()
        .unwrap()
});

static GUARD: Lazy<tokio::runtime::EnterGuard> = Lazy::new(|| RT.enter());

#[mlua::lua_module]
fn my_module(lua: &Lua) -> Result<Table> {
    let _guard = &*GUARD;
   ... code ...
}

panicked at 'OS can't spawn worker thread: Resource temporarily unavailable (os error 11)'

You probably need to enable insecure-fork-wanted option in HAProxy

Brilliant @ insecure-fork-wanted. I am now able to run Scylla commands within a Runtime block_on, as if it were a normal binary.


No file found: debug/samples.pkl

when I try to run the train.sh. I got the following error:
Traceback (most recent call last):
File "train.py", line 276, in
main(args)
File "train.py", line 146, in main
dataset_train = build_pretraining_dataset(args)
File "/home/PycharmProjects/Year_2021/iColoriT-main/datasets.py", line 171, in build_pretraining_dataset
return ImageFolder(args.data_path, transform=transform)
File "/home/PycharmProjects/Year_2021/iColoriT-main/dataset_folder.py", line 248, in init
super(ImageFolder, self).init(root, loader, IMG_EXTENSIONS if is_valid_file is None else None,
File "/home/PycharmProjects/Year_2021/iColoriT-main/dataset_folder.py", line 123, in init
with open('debug/samples.pkl', 'rb') as f:
Could you tell me what is the meaning and function of this debug/samples.pkl?
For my own training dataset,how to create the corresponding samples.pkl?
Many thanks for your kind help!

Hi, thanks you for your interest in our work, and thank you for your comment.
The point you mentioned was regarding the function in which DatasetFolder initially explores all the files, and we were caching it manually. We realized that this approach was incorrect when sharing the code. Therefore, we have made the following modification accordingly.
https://github.com/pmh9960/iColoriT/blob/8a02415aea6f6cc144650b47f38e58476f4e2a0f/dataset_folder.py#L121-L124
Any PRs are welcome!
Best,


Badges are broken.

@AbsentSemicolon Can you fix please?

The build status is not yet fixed.

Turns out that API access was not granted in Test-Always-Included's organization settings.  I wonder how that got changed ...


DynamicForm - controls are shown with error messages even if the values are assigned

Category
[ ] Enhancement
[x] Bug
[ ] Question
Version
Please specify what version of the library you are using: [3.15.0-beta.5500687]
Expected
For a column which is a 'Required' one, it should allow to enter a value. After focus is lost, if user doesn't enter any value, then it should show the error message as "You can't leave this blank".
Observed Behavior
On load of the form, the error message 'You can't leave this blank' is shown for all the columns which are set as 'Required'. This is confusing for the already existing list item which has got values.
Steps to Reproduce
Create a list, create few columns with data type 'Single line of Text', mark them as Required while creating. Use Dynamic form to create a list item, observe the columns having error message when the form loads for the first time. The behavior is the same for the existing list item (Editing list item).

Thanks!

I am seeing this issue as well, but only when editing/opening an existing item, tested in both a web part and form customizer. When creating a new item it is working correctly for me.

I am seeing this issue as well, but only when editing/opening an existing item, tested in both a web part and form customizer. When creating a new item it is working correctly for me.

@sallaadithya @Fantasticles I have resolved this issue, will be creating a new PR soon.
//Nishkalank Bezawada

Hello @sallaadithya & @Fantasticles,
I have created a new PR for fixing this issue, with the below solution.
Solution
In DynamicField component, the errorText is set at getRequiredErrorText method based on the property changedValue as below,
  private getRequiredErrorText = (): string => {
    const {
      changedValue
    } = this.state;
    return (changedValue === undefined || changedValue === '' || changedValue === null || this.isEmptyArray(changedValue)) && this.props.required ? strings.DynamicFormRequiredErrorMessage : null;
  }

This changedValue state is set in the constructor as below,
    this.state = {
      changedValue: props.fieldType === 'Thumbnail' ? props.fieldDefaultValue : null
    };

Resulting in having the changedValue always set to null as per above condition.
So, by setting the state as below, the issue will be resolved.
constructor(props: IDynamicFieldProps) {
    super(props);
    sp.setup({
      spfxContext: { pageContext: this.props.context.pageContext }
    });
    this.state = {
      changedValue: props.fieldDefaultValue !== undefined || props.fieldDefaultValue !== '' || props.fieldDefaultValue !== null || !this.isEmptyArray(props.fieldDefaultValue) ? props.fieldDefaultValue : null
    };
  }

Thanks,
Nishkalank Bezawada

Hi @NishkalankBezawada, @joaojmendes,
Thanks for fixing the issue, resolved the issue on EDIT form. However, for a new item, error messages appear by default. They should appear only after the focus is out off the control.

New release just published, closing


Add mssql ci test

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@17592d9). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1410   +/-   ##
=========================================
  Coverage          ?   57.56%
=========================================
  Files             ?       44
  Lines             ?     7966
  Branches          ?        0
=========================================
  Hits              ?     4586
  Misses            ?     2818
  Partials          ?      562

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17592d9...30c7730. Read the comment docs.


Update autorest.csharp to 3.0.0-beta.20221012.1

API change check
API changes are not detected in this pull request.


Manual semantic commit enablement not working

From @denkristoffer https://github.com/singapore/renovate/issues/473#issuecomment-323784995

We haven't actually switched to using semantic commits ourselves yet, I was hoping to take the first step by using it with renovate 🙂 The latest PR from renovate is called "Update dependency to v0.0.6" – that's from 12 hours ago even though I added "semanticCommits": true more than two weeks ago.

@rarkins This is probably due to https://github.com/singapore/renovate/issues/720#issuecomment-324216492 as well, don't you think? I'm sorry about that 🙁

Yes, you're probably right. I'll close this but please reopen if you don't see it behaving as expected.


Tidy the Gradle build files

Tidies up the Gradle build files, using some of the newer syntax from Gradle Kotlin DSL, a review of some of the module dependencies, and removing some of the things added with the introduction of the composite build that I'm now aware are not required (though the composite build remains).
Less code = Less bugs (hopefully!)

Nice work!

Looks like an issue pulling a dependency on AppVeyor causing a build failure. Travis and one of the AppVeyor builds ran OK.

Thanks for the clean up, please rebase the PR and I will gladly merge this!

Rebased, and made a couple more minor tweaks.

Build failure on AppVeyor due to a network timeout.


navbar is not responsive  in the mobile screen

pls, assign this issue to me under  the hacktoberfest.

@Abhishekvermaa Have you made any progress?

Yes I did the part of navbar responsiveness but there is some problem which I'm facing that whenever I trying to do navbar responsive background color change to white.
Can you help me out in this ??

@AdarshRawat1 i would like to work on this issue

@AdarshRawat1 pls assign this to me.


Update readme with install issues

@RocketChat/core

Closes #335
Closes #216

@alexbrazier I had to run this the other day on Fedora and because of it found the dependencies needed there.  So I added them here.

@geekgonecrazy Great, thanks! Hopefully we can eventually build up a full list so that people can get it working on every system.


macOS Installation - missing live555 package

Hi guys!
I've installed all missing dependencies via Homebrew or MacPorts but whenever I'm trying to install videoP2Proxy I'm having the following error:
Command:
./autogen.sh --with-p2plibpath=/opt/local/lib
Output:
processing .
Running aclocal  ...
Running autoheader...
Running automake --foreign  ...
Running autoconf ...

Alternatively, you may set the environment variables LIVE555_CFLAGS
and LIVE555_LIBS to avoid the need to call pkg-config.
See the pkg-config man page for more details.

I've installed live555 via MacPorts and as well compile it from scratch on my own.
Please help!

./autogen.sh --with-p2plibpath=./lib/MAC --enable-live555=no


Auto-formatting brings inconsistent result when Expand braces is True

Format Selection command brings different results for same code when Expand braces is True.
Editor settings: #1738.

Ctrl + K, Ctrl + F

Ctrl + K, Ctrl + F

Ctrl + K, Ctrl + F

Ctrl + K, Ctrl + F

Ctrl + K, Ctrl + F

https://github.com/Microsoft/RTVS/commit/468732e509cab0e9ff2a8d509e9afc2059d2174d


pc.download_files()

We have pc.upload_files() for uploading files. I think we should also have pc.download_files() for downloading files. I don't know of a clean way to create a download link in pynecone. We should have one. #795

Nice suggestion we will start looking in  on how to implement this feature!

@jq6l43d1
An interesting finding is to use api route provided here.
import starlette
...
async def file_download(filename: str):
    return "<to your file path>"
...
app = pc.State(State)
app.api.add_api_route("/download/{filename}", file_download, response_class=starlette.responses.FileResponse)
app.compile()
...

By doing this, you can assess localhost:8000 to get the file. You can use pc.redirect to access the download link. However, this method can be tedious and impractical due to different ports used (3000 for main program and 8000 for api server).
Hope this can be helpful for your current issues :)

Actually these two are the same rendered by FastAPI in this scenario. But the method you provided can be more flexible to different file types or even return buffer. Below is my current use case.
@app.api.get("/download/{filename}")
async def file_download(filename: str, background_tasks: BackgroundTasks):
    buffer = BytesIO()

    local_filename = "zipfiles/" + filename + ".zip"

    # Open a zipfile and write into to the buffer
    with open(local_filename, "rb") as zip_file:
        buffer.write(zip_file.read())
    buffer.seek(0)

    background_tasks.add_task(buffer.close)
    background_tasks.add_task(os.remove, path=local_filename)
    headers = {
        "Content-Disposition": f'attachment; filename="{filename}.zip"'
    }
    return Response(buffer.getvalue(), headers=headers, media_type="application/zip")

Thanks for sharing your method!

Does this feature need frontend?
I have implemented backend on https://github.com/TaiJuWu/pynecone/tree/download
Example code:
app = pc.App(state=State)
app.add_page(index)
app.add_download_file("/test1", "/Users/tai-juwu/ws/pynecone/download/test.JPG")
app.add_download_file("/test2", "/Users/tai-juwu/ws/pynecone/download/test.pdf")
app.add_download_file("/test3", "/Users/tai-juwu/ws/pynecone/download/test.mp4")
app.compile()

I meet some problem is I try to call app.add_download page in app.compile but it failed.

@TaiJuWu  No frontend is needed. You can left index page blank and just implment the backend service.
The ony difference here is that the ip address should be accessed with port 8000. You can modify the port within pconfig.py.
Back to your example code, the default pc.App has no method called add_download_file. If you would like to add a new route, you can try app.api.add_route(...). One advantage of using api.add_route is that you don't have to specify the route one by one like you did in your example code. You can directly use a dump name and send into the function like below:
import starlette  # Already installed with Pynecone!
...
async def file_download(filename: str):
    return "<your true file path>"
...
app = pc.State(State)
app.api.add_api_route("/download/{filename}", file_download, response_class=starlette.responses.FileResponse)
app.compile()
...

Hope this helps 💪

Solved by #1797


Collectorist should prune missing collectors

When/if a collector fails, after N attempts, Collectorist should prune until the collector shows back up and reregisters.

We should probably also lose the deregister workflow, if we can run multiple replicas behind a service, and solely work with idle pruning for unreachable.

I just noticed a case where it seems that shutting down one instance while firing up a new one leaves the new one unregistered, not receiving any events. Or maybe it was a case of collectorist restart.

Ok, here's a thought … why don't we list all the collectors explicitly in the collectorist config? That would drop a lot of complexity.


Allow multi-level grouping factors if needed

The model currently only supports single-level groupings, but it is possible to reference multiple single-level groupings for an analysis.  We need to determine whether there is a need for multi-level grouping factors.  If there is a need, the model should be updated to accommodate them.  Multi- vs single-level groupings may have an impact on the ability to "interleave" results in a display - e.g., in a SOC/PT display.
Assumption (to test): any analysis will only generate results for the lowest level/last grouping factor referenced from the analysis.  If you need results at intermediate grouping levels (e.g. at the SOC level in a SOC/PT display), you have to define a separate analysis where SOC is the lowest level grouping.  If this assumption holds true, multi-level groupings will not be needed because results can be interleaved in a display based on grouping factor ids.

Close this one as unnecessary.


[DOCFIX] add instruction to modify masters file

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20291/
Test PASSed.

Merged build finished. Test PASSed.

@yuzhu Please cherry-pick to branch-1.8


Update description.md

headlines added

Hi @Sandebir please remember to sign the Salesforce CLA, otherwise we need to publish your contributions as our own.


No error when using isolated in a module-no-init-var-decl

Description:
The grammar for module-no-init-var-decl is
module-no-init-var-decl := metadata [final] type-descriptor variable-name ;
Steps to reproduce:
So the following should result in an error.
isolated int[] val;

Affected Versions:
Current master

INVALID[isolated] int[] val;

Parsed as above. But, syntax tree seems to have no diagnostics.


Infra - intermittent error in cmake generate saying `OPENTELEMETRY_CPP_INCLUDE_DIRS variable is missing.

In ValidateLive Win2019_x86_with_unit_test_winHttp during the cmake generate generate step:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3692773&view=logs&j=bde6d2cb-0847-54f8-b066-ca83e951fc62&t=2353e707-e04d-5ce8-7bb7-cffc3818dc3e
It seems to only error on Win2019 legs.
2024-04-12T19:09:16.7281372Z CMake Error at build/vcpkg_installed/x86-windows-static/share/absl/abslConfig.cmake:16 (message):
2024-04-12T19:09:16.7282434Z   File or directory D:/a/_work/1/s/build/vcpkg_installed/include referenced
2024-04-12T19:09:16.7283203Z   by variable OPENTELEMETRY_CPP_INCLUDE_DIRS does not exist !
2024-04-12T19:09:16.7283990Z Call Stack (most recent call first):
2024-04-12T19:09:16.7284750Z   build/vcpkg_installed/x86-windows-static/share/opentelemetry-cpp/opentelemetry-cpp-config.cmake:87 (set_and_check)
2024-04-12T19:09:16.7285649Z   build/_deps/vcpkg-src/scripts/buildsystems/vcpkg.cmake:859 (_find_package)
2024-04-12T19:09:16.7286454Z   sdk/core/azure-core-tracing-opentelemetry/CMakeLists.txt:39 (find_package)

This should have been fixed with https://github.com/Azure/azure-sdk-for-cpp/pull/5523. Can you please confirm that you are seeing this error after the 5523 pull request was committed?

For live tests, the cmake version is still old (3.29.1), and the legs are failing (on main), even after #5523 was merged:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3693096&view=logs&j=bde6d2cb-0847-54f8-b066-ca83e951fc62&t=2353e707-e04d-5ce8-7bb7-cffc3818dc3e

Looks like the pipelines are green now (checked core, identity, keyvault):
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3697479&view=results
Closing as fixed, by https://github.com/Azure/azure-sdk-for-cpp/pull/5528


apis_relations: fix RootObject import and remove TempEntityClass import

The RootObject resides in apis_core.apis_metainfo and should be imported
from there. The TempEntityClass is not used in this class at all.

Agreed.


DOID mirror looks like it's missing a couple of diseases

civic-client issue genome/civic-client#291 refers to a couple of diseases that aren't showing up in the dropdown. I'm assuming these are missing from the local DOID mirror.
hemorrhagic thrombocythemia [DOID: 2224]
chronic myeloproliferative disease [DOID: 2226]

@kkrysiak So, I have been using what I believe to be the cancer specific disease ontology dump (latest version here: https://github.com/DiseaseOntology/HumanDiseaseOntology/blob/master/src/ontology/subsets/DO_cancer_slim.obo). Neither of these diseases seems to be in it. Both do appear to be in the full DOID file (https://github.com/DiseaseOntology/HumanDiseaseOntology/blob/master/src/ontology/doid.obo) which is much larger and more complete.
Should I be using the full disease ontology rather than the cancer specific subset?

@acoffman Yeah, some of their cancer sections need to be reworked which I actually created a github issue for them about. I doubt that is going to be super fast, it's a pretty complicated reworking that I proposed. Some diseases we now refer to as cancers were not categorized that way not that long ago but clonality analysis (among other things) has changed the game. I'm not sure how many diseases would fall under such an umbrella. Remember, pulling in the rest of disease ontology may result in a repeated synonyms issue which we had kind of punted on since it wasn't a direct problem in the cancer subset (yet).
I think we should discuss this in the group meeting today.

It's also interesting to me that Chronic Myeloproliferative Disease is not in the cancer subset. This is kind of a concern since the current relationship scheme has this DOID is_a Myeloma which is_a Bone Marrow Cancer which is_a Hematologic Cancer, etc. It should definitely be in their cancer list.

The final decision was to leave it as only the cancer subset.
Let Disease Ontology know where the obvious cancer entry is missing in their output file that you are using. https://github.com/DiseaseOntology/HumanDiseaseOntology/issues

@kkrysiak I've opened DiseaseOntology/HumanDiseaseOntology#116 to inquire about the inclusion of these diseases.

@acoffman this is great. If I see any others, I will add them there.

Some other missing diseases - moving these here from https://github.com/genome/civic-server/issues/124 so I could close the duplicate issue.

I think where we left this was that, for now, we'd just parse the full file and take the cancer subset ourselves. Obviously though, if the Disease Ontology folks are interested in maintaining a file containing the cancer subset themselves - we can just use that!

Okay lets do our own thing for now because our need is short term.  But we should also keep them in the loop as we really benefit from their hard work. :)

Disease Ontology posted an update to the issue @acoffman opened on their repo so the handful of requested diseases will be live Friday, Feb 19th.
Although they have closed the issue they mention it in an outstanding list of to dos so maybe they will create one down the road: https://github.com/DiseaseOntology/HumanDiseaseOntology/issues/125

Here is another one we are missing:
DOID:5485 synovial sarcoma

I have imported the full cancer subset of the disease ontology into civic and verified that all the mentioned entries are present!

Sweet!  Thanks @acoffman this will be awesome for new entries.


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/60284

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/82631

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/83291

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/88065

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/93876

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/120194


sourcegit: init at 8.30.1

Description of changes
Closes https://github.com/NixOS/nixpkgs/issues/303855
Related: https://github.com/sourcegit-scm/sourcegit/issues/71
This PR adds 1 package: sourcegit
The app is mostly usable on Linux, however I don't know how good it is on Darwin
There's a patch that makes the platform specific logic for finding git on MacOS the same as on Linux (a.k.a. search the PATH)

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/need-help-packaging-a-net-project-sourcegit/43339/2

I just tried to test if all those runtimeDeps are really necessary, and it seems to run fine without libXi, libXext, libXrandr and glew. My testing was more rough than thorough, so I can't promise that removing these runtimeDeps really doesn't change anything, but I thought it could be of interest.

I just tried to test if all those runtimeDeps are really necessary, and it seems to run fine without libXi, libXext, libXrandr and glew. My testing was more rough than thorough, so I can't promise that removing these runtimeDeps really doesn't change anything, but I thought it could be of interest.

Yeah, looks like this works for me too. (I just copied this list from another derivation using AvaloniaUI)

libXi is definitely necessary, right-click-menus don't work without it. But I haven't figured out what libXext and libXrandr do here yet.

Tried to update to the latest version (8.26) however it looks like something broke in a commit that bumps used the AvaloniaUI version (https://github.com/sourcegit-scm/sourcegit/commit/ef0cf7657183a1ddf20387bcd262be7f52e89b8c) (Part of 8.22->8.23 changes)

Seems like https://github.com/NixOS/nixpkgs/pull/340493 fixed the Avalonia issue
Also, the latest version of the app no longer uses the version of Avalonia that had the issue, so it doesn't really matter anyway.

I actually tried to create my own version of this package, but using their provided AppImage instead, and that worked really well without any real issues. Maybe that would be a better approach, at least for Linux? Granted, it would be more difficult to make it work on Darwin.

I actually tried to create my own version of this package, but using their provided AppImage instead, and that worked really well without any real issues. Maybe that would be a better approach, at least for Linux? Granted, it would be more difficult to make it work on Darwin.

You may use the AppImage version, if you want to, however, if possible, we should package things from source.
Is there something that does not work for you with the source based package?

I actually tried to create my own version of this package, but using their provided AppImage instead, and that worked really well without any real issues. Maybe that would be a better approach, at least for Linux? Granted, it would be more difficult to make it work on Darwin.

You may use the AppImage version, if you want to, however, if possible, we should package things from source. Is there something that does not work for you with the source based package?

My main consideration was whether wrapping the AppImage or building from source would be the most effective in terms of maintenance and usability, but ultimately it might be better to build directly from source to be compatible with more platforms. I will admit however, I have not tried this since the 8.8 init, for which I only recall the issues with right-click menus

Is the only thing missing here the formatting of the deps.nix or why does it not continue?
Please go to the Nixpkgs root directory, run `nix-shell`, then:
nixfmt 'pkgs/by-name/so/sourcegit/deps.nix'

deps.nix

I don't think there was a decision made yet about whether or not we should keep generated file formatted, so this is not a blocker.
I am still waiting for someone to review/merge this PR.
I can send this again into the review requests Matrix channel.

Probably the nix code has to be formatted manually until the generator can generate valid nix code.
FYI: @fpletz

Probably the nix code has to be formatted manually until the generator can generate valid nix code.

I don't think we've come to a conclusion about formatting generated nix files.
Even if the CI doesn't pass it can be merged.

Thanks for the PR! Just a note here: I tested this on Darwin. SourceGit builds fine and starts without problems. However, it does not show the differences introduced by current changes or when selecting two different commits (it just says NO CHANGES OR ONLY EOL CHANGES).
It seems that is an upstream problem of version 8.30.1, since I got the same behavior with the upstream release from their GitHub page. The current upstream release (8.41) shows the diffs correctly. So it might be worth bumping the version used in this PR (in the hope that it's just a simple version bump).

I tested the version bump to 8.41 in a personal fork, went without hiccups. Diff view is now working fine on Darwin 🙂.

FYI: I bumped the version in my fork of this PR to 8.44 and disabled automatic update detection (which is a new option in 8.44). Also, I added the creation of a proper Darwin application bundle.
@TomaSajt: Feel free to integrate those changes if you want to (the changes are fairly minimal). If not that's also fine, then I'll create a corresponding PR once this PR is accepted.

FYI: I bumped the version in my fork of this PR to 8.44 and disabled automatic update detection (which is a new option in 8.44). Also, I added the creation of a proper Darwin application bundle.
@TomaSajt: Feel free to integrate those changes if you want to (the changes are fairly minimal). If not that's also fine, then I'll create a corresponding PR once this PR is accepted.

Thanks for your work! :) I'll update my PR


what am i doing wrong?

Challenge Truncate a string has an issue.
User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:
function truncateString(str, num) {
  var newStr = '';

  if (num <= 3) {
    newStr = str.slice(0, num) + '...';
  } else if (str.length > num) {
    newStr = str.slice(0, num - 3) + '...';
  } else {
    return str;
  }

  return newStr;
}

truncateString("Absolutely Longer", 2);

Hi @ar94952
Thanks for reporting this issue.
Here are some next steps that you should follow before we can help you with your query:

Check these troubleshooting steps first.
Please use the Chat Rooms or try looking through our forum for help with a specific challenge and any coding assistance.

IMPORTANT:
Please NOTE that this tracker is for reporting bugs and enhancements to freeCodeCamp's code base only.
Happy Coding!


Linux : Force frame to front in clientUI.forceFocus()

Without frame.toFront() the forceFocus() method focuses the window, but it remains hidden behind other windows (on Arch linux / Manjaro & Ubuntu 18) which doesn't necessarily match what I think forceFocus() should do.
For Linux, I believe clientUI.forceFocus() implementation details should match the use case of forcing focus. I used as reference : https://stackoverflow.com/questions/641172/how-to-focus-a-jframe , but believe setVisible(true) is not necessary in this case.
Let me know if this change in forceFocus() on linux matches the intended usecase!

Indeed the expected behavior is it brings the window to front. Though I don't have a linux machine to test this.

This did not work on my Linux Mint 20.3 system

Adding:
case Linux:
				frame.setVisible(true);
				frame.toFront();
				frame.requestFocus();

				break;

to forceFocus() solves the issue of the window not being brought to the front. frame.setVisible(true); does seem to be necessary, at least in Mint 21.3.


dist files (1.0.5) are not updated

I note Salvattore available in dist (v1.0.5 https://raw.github.com/rnmp/salvattore/master/dist/salvattore.min.js and https://raw.github.com/rnmp/salvattore/master/dist/salvattore.js) has a bug in appendElements (next_element_column_index is undefined).
This bug is fixed in src (right name is nextElementColumnIndex).
I think is needed run Grunt and update dist files.

I just regenerated the dist files, assume it is fixed with 302f35a4eedb26056ab189edf3a74adde3aea626 otherwise open an issue again. Thanks a lot.


ICEndpoint>>loggedIn and ICEndpoint>>isLoggedIn redundant?

If I understand the command in Slack correctly the getter for a boolean variable should be named in the form is{instancevariable}. Is it then necessary to have an other getter?

In SWA we learned, that we should use another method to access boolean members (named "is{NameOfMember}") in addition to its (auto generated) getter
This is to add more semantics to the code when accessing these members (of cause you could just use the generated getter, but it wouldnt sound as nice)


Check method names to exclude from Metrics/BlockLength

Metrics/BlockLength:
  Exclude: []
  ExcludedMethods:
    - "draw"      # rails routes
    - "concern"   # rails routes
    - "scope"     # rails routes
    - "namespace" # rake/routes
    - "task"      # rake
    - "define"    # factory_girl
    - "factory"   # factory_girl
    - "trait"     # factory_girl
    - "describe"  # rspec
    - "context"   # rspec
    - "it"        # rspec

    - "create_table"        # rails migration
    - "shared_examples_for" # rspec
    - "shared_context"      # rspec
    - "with_them" # rspec-parameterize
    - "guard"     # Guardfile
    - "source"    # Gemfile


KafkaChannel Configuration option on a per object base

Problem
We currently have a global configuration for one dedicated Apache Kafka cluster:
https://github.com/knative-sandbox/eventing-kafka/blob/main/config/channel/consolidated/configmaps/kafka-config.yaml#L24
this forces all KafkaChannel objects to be connected against a single kafka cluster.
This does not fly well, when offering "Knative Kafka" as a service, where customers have desire for individual Kafka cluster usage, on a per channel bases.
The global default is a convenient setting for on prem, but not for more cloud-centric cases
Proposal
Adding the following fields to the KafkaChannel spec

bootstrapServers
authSecretName (assumes that the actual secret is living in the namespace of the KafkaChannel object)

Persona:
Which persona is this feature for?
Exit Criteria
A measurable (binary) test that would indicate that the problem has been resolved.
Time Estimate (optional):
How many developer-days do you think this may take to resolve?
Additional context (optional)
Add any other context about the feature request here.

+1
Why these are missing in the first place:

Being able to use the generic Channel
Preventing app developers to change "admin"ish things like the bootstrap server and auth that's defined per cluster

Although I understand these usecases, it would be really nice to have the ability to pass these in the spec.
Something logic like:

If available in the spec, use them
If not, fallback to the configmap

In managed service case, we wouldn't like the fallback actually. So, maybe also a way to enable/disable fallback too (probably in the configmap) ?

How about this similar to KafkaSink:
spec:
   bootstrapServers:
      - my-cluster-kafka-bootstrap.kafka:9092
   auth:
     secret:
       ref:
         name: my_secret

It's a bit more verbose, but it will give us more flexibility in the future regarding "auth(n|z)".

Being able to use the generic Channel

IMO a weak part of the API, only interesting on the surface

In managed service case, we wouldn't like the fallback actually. So, maybe also a way to enable/disable fallback too (probably in the configmap) ?

I'd expect someone would set it up WITHOUT any default, on cases like that - hence the fallback would fail, due to no bootstrap present. Log will tell the devs.
No need to configure this too

You would still be limited to a single "configuration" of the Kafka "clients" (i.e. SASL, TLS, etc in Sarama.Config) - is that an acceptable assumption (i.e. all Kafka instances are similar and use the same set of Kafka Root Certs, etc..) or should there also be a field pointing to the ConfigMap (in which case the brokers and Secret name/namespace can just stay in the ConfigMap)? We are also watching the ConfigMap / Secret for changes and reacting to them in controller - would have to consider impacts there (watching multiple/all such instances, etc.)
I thought the intent was to use the "scope" (namespaced) annotation to allow distinct ConfigMap / Secret per-namespace ?  (not that the we support that fully today or anything ; ). This allows for a middle-ground where each Kafka instance is specified once without requiring every Topic in the Kafka instance to replicate it.  I have't thought through that solution completely so maybe there are blockers/difficulties?  Has that annotation based approach been scrapped, or are the two supposed to co-exist?
The intent is valid/good (multi-tenant separate Kafka instance support) and in general this approach is ok as long as there is fallback to current usage for those who don't want to have to specify the brokers every time (because they will always only have a single instance).

You would still be limited to a single "configuration" of the Kafka "clients" (i.e. SASL, TLS, etc in Sarama.Config) - is that an acceptable assumption (i.e. all Kafka instances are similar and use the same set of Kafka Root Certs, etc..) or should there also be a field pointing to the ConfigMap (in which case the brokers and Secret name/namespace can just stay in the ConfigMap)? We are also watching the ConfigMap / Secret for changes and reacting to them in controller - would have to consider impacts there (watching multiple/all such instances, etc.)

See https://github.com/knative-sandbox/eventing-kafka/issues/1005#issuecomment-982469704, auth and bootstrap servers would be for each KafkaChannel instance.

I thought the intent was to use the "scope" (namespaced) annotation to allow distinct ConfigMap / Secret per-namespace ? (not that the we support that fully today or anything ; ). This allows for a middle-ground where each Kafka instance is specified once without requiring every Topic in the Kafka instance to replicate it. I have't thought through that solution completely so maybe there are blockers/difficulties? Has that annotation based approach been scrapped, or are the two supposed to co-exist?

This might not work in all cases.

The intent is valid/good (multi-tenant separate Kafka instance support) and in general this approach is ok as long as there is fallback to current usage for those who don't want to have to specify the brokers every time (because they will always only have a single instance).

Agree!

I don't like the idea to add auth to channel object. Instead, better approach would be to create additional CR KafkaAuthentication (or even one more KafkaAutgenticationBinding).
As @aliok mentioned, adding auth breaks option to use default channel, and creep administrative information into developer scoped type.
Putting auth in separate type allows us to keep those important functions. It also, allows to have centralized authentication model, that can be fine tuned in various ways - matching by ref, by namespace, by prefix. It's also less verbose, as you don't need to type auth in every object (sometimes hundreds of times).

+1 on the bootstrap server field
not sure here:
    secret:
      ref:
        name: my_secret
        # not 100% sure about this
        namespace: foo

I'd kick that.
Instead, let's start w/ Duck typing a spec.config, like we have on the BROKER (do we care about generic ChannelAPI?)
E.g:
...
spec:
  config:
    apiVersion: v1
    kind: ConfigMap
    name: matze-kafka-channel-config
    namespace: mwessend-dev
...

The referenced config map would follow the schema of the auth parts:
apiVersion: v1
kind: ConfigMap
metadata:
  name: matze-kafka-channel-config
  namespace: mwessend-dev
data:
  auth.secret.ref.name: kafka-sasl-secret

That follows the same syntax as in: https://knative.dev/docs/eventing/broker/kafka-broker/#security
Custom Kafka Config CRDs
In a later version, we can create those, and make the spec.config understand those too

Instead, let's start w/ Duck typing a spec.config, like we have on the BROKER (do we care about generic ChannelAPI?)

That's also an option. What I offered is consistent with KafkaSink, what you offered is consistent with KafkaBroker.
I don't have a strong opinion but, to me, every KafkaChannel implementation will need a bootstrapServer info and also auth secret info. I prefer having more and more strongly typed API fields for these, but I am fine with both.

I'd recommend following KafkaSink instead of KafkaBroker because the ConfigMap is an external object and its lifecycle management is something that becomes easily complicated and I don't see a reason for it when you can have proper spec fields.
In addition, with a ConfigMap, we also lose the ability to do validation at the webhook level.

The sink approach is also easier to migrate over to a actual type
On Thu 10. Feb 2022 at 18:27, Pierangelo Di Pilato @.***>
wrote:

I'd recommend following KafkaSink instead of KafkaBroker because the
ConfigMap is an external object and its lifecycle management is something
that becomes easily complicated and I don't see a reason for it when you
can have proper spec fields.
In addition, with a ConfigMap, we also lose the ability to do validation
at the webhook level.
—
Reply to this email directly, view it on GitHub
https://github.com/knative-sandbox/eventing-kafka/issues/1005#issuecomment-1035203802,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABGPTSMRE2VNM6CRA4ELCDU2PYPHANCNFSM5JBDSFNA
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Sent from Gmail Mobile

Ok, then you agree to this one?
apiVersion: messaging.knative.dev/v1beta1
kind: KafkaChannel
metadata:
  name: kafka-channel
spec:
  bootstrapServers:
    - my-cluster-kafka-bootstrap.kafka:9093
  auth:
    secret:
      ref:
        name: my_secret
        # not 100% sure about this
        namespace: foo
  config:
      ref:
        name: my-config
        namespace: bar

IMO this looks good, except for the config fallback. Dont like that

IMO this looks good, except for the config fallback. Dont like that

I think we need the fallback because we need to be backwards compatible and we need to support the scenarios that the broker and auth info is not in the spec.

BTW, one implication of having these in spec is that we won't be able to cache the Sarama client and the admin client anymore.
@travis-minke-sap We don't cache them in the components at eventing-kafka-broker and we didn't see anything problematic. cc @pierDipi

I think the config ref could be part of a separate discussion.
I'm imagining this high-level logic:

if there is bootstrapServers and/or auth use them, otherwise fall back to the same behavior as before by reading the global configmap

We won't be able to cache the Sarama client and the admin client anymore.

This is a good point but I don't think we do this even today because sarama is buggy on long-running connections, do we?

We need to read the configmap referenced in the spec in every reconciliation cycle.

That's the reason, I'd separate the 2 discussions, bootstrapServers/auth from the config.

Hey - sorry for not responding earlier - been wrapping up some internal work...
The Distributed KafkaChannel (receiver and dispatcher deployments) is currently watching a Secret (kafka-cluster), specified via environment variables, in order to dynamically re-create the Sarama clients when the SASL config changes.  This is done to support automatic rotation of client passwords / tokens.
Both KafkaChannel implementations dynamically create new Sarama admin clients for every Topic creation / deletion.
If the Secret is specified in the KafkaChannel spec, then this would require control-plane -> data-plane communication from the Controller to the Receiver / Dispatchers to let them know to start using a different Secret.  This could be a control-protocol type communication (in-place), or the Controller updating environment variables on the respective Deployments in order to force a rollout restart.
The main problem for the Distributed KafkaChannel though, is that there is only a single "Receiver" Deployment for the entire cluster.  This instance services ALL KafkaChannels and couldn't be tied to a specific auth/config in a single KafkaChannel.  Not sure how we'd address this without tackling multi-tenant namespacing.
I don't want the run-time architectural needs of the Distributed KafkaChannel to prevent you from moving forward with this more granular configuration, but we will need to present a coherent documented description of what level of configuration is supported by which components.  Or have a plan to ensure all the components can support the new structure?

That's the reason, I'd separate the 2 discussions, bootstrapServers/auth from the config.

Ok, let's leave the config reference discussion here.

Thanks for detailed comments @travis-minke-sap

I don't want the run-time architectural needs of the Distributed KafkaChannel to prevent you from moving forward with this more granular configuration, but we will need to present a coherent documented description of what level of configuration is supported by which components. Or have a plan to ensure all the components can support the new structure?

We can add a validation in distributed channel webhook to reject channel resources that use the proposed fields and we can create a good documentation about the implementation differences around the fields.
Would this be an option?

Quick note:
There's another usecase: cluster admins don't want the developers to specify bootstrapServer and secret in the spec as they want to manage it themselves. So, we need something additional to enforce this.

/remove-lifecycle stale
/triage accepted


add histogram 'parade' ?

The changes in that PR were to make an exercise on connectors.
But it also makes a change on something I may have not understood: what does happen if there is more than 1024 points on the intensity in collect.comp ? It seems to me that rgb counts are mixed up. Would that be correct ?
I've also scaled a bit differently the output levels.
EDIT. Of course the UI input should be better with some check boxes (or combo box).

yes, correct. this will overflow at some point. i mean.. as will the 32-bit per channel ints, albeit a whole lot later. i suppose splitting the buffers is the cleaner approach, maybe even with array connectors. but did you observe a difference between the approaches? did you run -d perf to see if it's more expensive? my guess is that more memory traffic might mean more cost.
as to ui: i suppose at some point we'd need a separate widget for the histogram (much like the thumbnail widget https://github.com/hanatos/vkdt/blob/master/src/gui/widget_thumbnail.hh ). for preferences like these we'll also likely need a config file in the future.

did you run -d perf to see if it's more expensive?
A lot more expensive...
For hist collect,
with your code: between 13 and 18 msec
with this code: between 54 and 65 msec.

okay thanks for checking.. not willing to pay so much for a histogram. closing this now, let's do ui improvements/parameters in a histogram widget separately.


[FEATURE] the wasmCloud host should support a --nats-creds-file argument

Affected project(s)

[ ] documentation
[ ] examples
[X] wasmCloud host
[ ] wasmCloud CLI (wash)
[ ] wasmCloud dashboard UI (washboard)
[ ] capability providers
[ ] provider bindgen
[ ] control interface client
[ ] other / not sure

Is your feature request related to a problem? Please describe.
The wasmCloud host currently only allows you to pass in nats credentials using two distinct arguments: --nats-jwt and --nats-seed. NATS credentials commonly are provided as a single file known as a creds file that combines both the JWT and the seed key in a single file
Describe the solution you'd like
We should add a --nats-creds-file argument that is mutually exclusive with the --nats-jwt and --nats-seed arguments that allows you to use a single NATS creds file.
Describe alternatives you've considered
No response
Additional context
No response

This is a great first issue! Thanks for filing & labeling @protochron.

Worth noting that the implementer should mark this as a flag that conflicts with the jwt & seed arguments, which we have precedent for in the CLI

I would love to work on this issue ! can i pick this up ?

I believe this was addressed sufficiently in https://github.com/wasmCloud/wasmCloud/pull/2880, thoughts?


Use the correct chartmuseum url

:star: PR built and available in a preview environment carlossg-croc-hunter-jenkinsx-serverless-pr-47 here

/approve


Angular: enhanced workspace to be SEO ready

Since this new Angular/ workspace is ready for static site deployment, we can proceed to enhance it for SEO ready. Hence, let's do  this.
This patch enhances Angular/ workspace to be SEO ready.

Looks good for me. You have to con!

Thanks.


MALWARE IN CODE

motherfucker placed clipboard changer in the code fucktards scamming for few bucks

line and file name?


incorrect cattle config url environment variable

Hi,
Tested with Rancher 1.1.3.  It seems prometheus-rancher-exporter is expecting the environment variable CATTLE_CONFIG_URL while Rancher populate the env variable CATTLE_URL instead
See doc available here http://docs.rancher.com/rancher/v1.0/en/rancher-services/service-accounts/

Good spot, thanks for reporting. I've not used 1.1.3 yet. Open to a pull-request if you fancy, if not i'll try get a fix up this weekend.

Hi fixed in PR #7
Can you update the Rancher catalog entry to use it?
Thx

@olivierba I've merged and pushed the updated container as version '05'.
I've updated the catalog too, any chance you could give a test? i'm on the road right now without access to an instance.
Just needs the catalog: https://github.com/Rucknar/community-catalog.git adding into rancher to test. If that looks good, i'll submit a merge request to the community repo.

Hi,
I'll give it a shot before the end of the week

arf, there's a bug in the function checking if env vars are present. Forgot to rename it there. Fixing...

fixed in PR#8
tested in https://github.com/olivierba/community-catalog with rancher 1.1.13 now works ok


tests:ipc_service: Add ipc_service test of deregistered endpoint

This adds an additional test to the ipc_service test suite whereby the
test attempts to deregister the endpoint from the ipc_service instance
and then send a message to that endpoint - this should fail with
-ENOENT.
Signed-off-by: Jackson Cooper-Driver<EMAIL_ADDRESS>

@jacksonc-xlnx can you rebase?


convert Mixture Density Networks example to V3

Hi Keras team,
I've converted this https://keras.io/examples/keras_recipes/approximating_non_function_mappings/ example to Keras V3 and JAX backend.
The example had dependency on tensorflow_probability so it will run only TensorFlow and JAX backends 🤷 .

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.70%. Comparing base (a05ac12) to head (05d5ff6).

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #19733       +/-   ##
===========================================
- Coverage   78.53%   66.70%   -11.83%
===========================================
  Files         498      498
  Lines       45753    45753
  Branches     8455     8455
===========================================
- Hits        35933    30521     -5412
- Misses       8086    13587     +5501
+ Partials     1734     1645       -89

Flag
Coverage Δ

keras
66.63% <ø> (-11.76%)
:arrow_down:

keras-jax
?

keras-numpy
56.30% <ø> (-0.01%)
:arrow_down:

keras-tensorflow
?

keras-torch
62.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Thanks for the PR -- please create the PR at https://github.com/keras-team/keras-io/pulls instead.


Please apply to this job in Upwork and let us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

Lol melvinbot is confused here 😆
Starting QA 🚀

WOW that's a lot of deploy blockers.

Currently testing these CPs in all environments:

[ ] https://github.com/Expensify/App/pull/6441
[ ] https://github.com/Expensify/App/pull/6433
[ ] https://github.com/Expensify/App/pull/6417
[ ] https://github.com/Expensify/App/pull/6319

Regression is almost finished! Summary of what we have found so far:

https://github.com/Expensify/App/pull/4133 - Is failing because of https://github.com/Expensify/App/issues/6422 and https://github.com/Expensify/App/issues/6426
https://github.com/Expensify/App/pull/6293 - Was failing because of https://github.com/Expensify/App/issues/6414 (Being retested https://github.com/Expensify/App/pull/6433)
https://github.com/Expensify/App/pull/6319 was failing because of https://github.com/Expensify/App/issues/6439 (being retested atm)

Comments:

https://github.com/Expensify/App/pull/6362#issuecomment-977325575

List of issues found so far:

https://github.com/Expensify/App/issues/6416
https://github.com/Expensify/App/issues/6438
https://github.com/Expensify/App/issues/6439
https://github.com/Expensify/App/issues/6428
https://github.com/Expensify/App/issues/6427
https://github.com/Expensify/App/issues/6426
https://github.com/Expensify/App/issues/6424
https://github.com/Expensify/App/issues/6422
https://github.com/Expensify/App/issues/6416
https://github.com/Expensify/App/issues/6415
https://github.com/Expensify/App/issues/6414

CPs being tested at the moment https://github.com/Expensify/App/issues/6399#issuecomment-977303703.
Thanks!

Checked off the Deploy blockers that have been fixed and retested. Only deploy blockers left to fix and retest are

https://github.com/Expensify/App/issues/6424
https://github.com/Expensify/App/issues/6426
https://github.com/Expensify/App/issues/6457

Testing this CP atm:

[ ] https://github.com/Expensify/App/pull/6459 (Fixes https://github.com/Expensify/App/issues/6424)

We found a issue when executing https://github.com/Expensify/App/pull/6319 on iOS https://github.com/Expensify/App/issues/6475 (tagged @luacmartins on PR so he can give it a look)

Fix for https://github.com/Expensify/App/issues/6475 is up - https://github.com/Expensify/App/issues/6475

Checking off https://github.com/Expensify/App/pull/6479#issuecomment-98004609! It was a pass 🎉

@yuwenmemon @tgolen I'm going to check off https://github.com/Expensify/App/pull/6365, looks like it shouldn't block our deploy here.

:shipit:


Correctly add XCB components if no components are requested

This commit fixes the FindXCB.cmake module for the case no components
are requested. The previous version assigned XCB_FIND_COMPONENTS
list to an empty variable name.
I was lucky enough to catch the bug in a corner case where both
XCB_COMPONENTS and XCB_FIND_COMPONENTS were empty and set()
command failed, but note this awesome CMake language supports more annoying
corner cases like XCB_COMPONENTS empty and XCB_FIND_COMPONENTS
with two elements, which results in the following set() invocation:
set(${XCB_FIND_COMPONENTS[0]} ${XCB_FIND_COMPONENTS[1]})

So always beware of CMake secret charms...

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

Merged in e0d97826d784337a8ba9c9f7ce2c6638aecad45b on the 2.4.x branch


Instructions for running espresso test are invalid

packages/android_alarm_manager_plus/README.md says:

To run the test, run from the example/android folder:
./gradlew app:connectedAndroidTest -Ptarget=`pwd`/../lib/main_espresso.dart

However, there is no gradlew file in the repository.
I'm a novice - I would be very interested to see the espresso tests in action.
Thanks!
Noam

Hello, can I get this bug assigned to me and fix it?
Thank You.

@ManVTish you can surely write a pull request, I would be very interested to see it in action. Of course, you'll need a maintainer to get it merged.

@ManVTish please go ahead and send a PR.

Thank you @mhadaily @noamraph , I'm already into it. Thanks again.

Hello, @mhadaily @noamraph
Just wanted to share updates till now. I was able to reach till testing on mobile device, got error as below:
`> Task :app:connectedDebugAndroidTest
Starting 1 tests on Redmi 8A - 10
io.flutter.plugins.androidalarmmanager.BackgroundExecutionTest > startBackgroundIsolate[Redmi 8A - 10] FAILED
java.lang.AssertionError: Activity never becomes requested state "[CREATED, DESTROYED, RESUMED, STARTED]" (last lifecycle transition = "PRE_ON_CREATE")
at androidx.test.core.app.ActivityScenario.waitForActivityToBecomeAnyOf(ActivityScenario.java:338)

Task :app:connectedDebugAndroidTest FAILED

FAILURE: Build failed with an exception.
`
Also a report is generated in index.html file:

Thank You.

Go ahead it’s yours
On Sun, 27 Mar 2022 at 10:09, Manish Roy @.***> wrote:

Hello Sir, can I get this bug assigned to me so that I can fix it?
Thank You.
@mhadaily https://github.com/mhadaily
—
Reply to this email directly, view it on GitHub
https://github.com/fluttercommunity/plus_plugins/issues/786#issuecomment-1079877435,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKDTC35NK5RMESTYNNQF73VCAJSDANCNFSM5QVGIZAA
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
*Best regards, *
Majid Hajian
www.majidhajian.com
Oslo, Norway
http://www.linkedin.com/in/mhadaily/ http://twitter.com/mhadaily


Vanilla Bootstrap

Theme submission
Before submitting a theme please make sure you've read the README.md. It describes in detail what information are needed and which requirements have to be fulfilled for the submission. The check list below can help you.
Link to my theme repository: https://github.com/zwbetz-gh/vanilla-bootstrap-hugo-theme
Live demo: https://vanilla-bootstrap-hugo-theme.netlify.com/
I made sure that...

[x] the repository contains a good README.md describing my theme
[x] an open source license has been added to LICENSE.md
[x] all metadata have been added to theme.toml
[x] screenshots have been added in the images/ folder with the required dimensions
[x] in case I'm using a customized demo via the exampleSite folder that

[x] https://example.com is set as base url in exampleSite/config.{toml, yaml, json} to avoid the abuse of unused domains
[x] the site's content is as neutral as possible (contains no ads etc.) and reflects the features of my theme

[x] I tested my theme against the gohugoio/HugoBasicExample

[x] I've checked the developer tools' console in my browser for error messages

[x] in case my theme is using Hugo Pipes features like toCSS and PostCSS that I have committed the /resources directory with all generated assets, for my theme to work in the basic version of Hugo

Feel free to ask questions. We're glad to help.

Hello @zwbetz-gh,
thank you for sharing this theme with the Hugo community. Your theme looks fine except one minor issue:
The links for tags don't work as expected if the website (like the Hugo theme site) is hosted in a subdirectory. Currently, the urls point to example.com/tags/XXX instead of example.com/subdir/tags/XXX.
This is because absURL will make urls starting with a / relative to www.example.com (by design), regardless of the specified baseurl. The issue should be fixed if you remove the leading slash url the url here.
Happy new year by the way :fireworks:

Your theme should appear soon on Hugo's theme site. Next, I'll promote your theme on Hugo's official Twitter account.

@digitalcraftsman Thanks for adding the theme. Just wanted to note that the current demo does not have my latest commits. (The tags are still pointing to the wrong URL, unfortunately).


Fix to filter all relation fields on keepRelationFields: 'false'

solving the issue https://github.com/valentinpalkovic/prisma-json-schema-generator/pull/1322#issuecomment-1836985240

@valentinpalkovic please take a look for this quick fix


Add support for custom dependencies in tools

BaseTool should have a dependencies property that can be used to add custom dependencies to tools. This is useful for tools like SqlClient.

@vasinov In the case of SqlClient, we cannot install dependencies on tool instantiation because it requires a SqlDriver to create the tool. And the SqlDriver will throw an error if the necessary dependencies are not already installed i.e. psycopg2.


A page explaining what fair badge means

We need a page that explains what the fair badge means and how to interpret it. This page should be hyperlinked from every FAIR badge in the README file.

For now, badges are hyperlinked to https://fair-software.eu/ (e.g. https://github.com/fair-software/badge-test). Later we could make a report page. We can even send the state as arguments in the url, something like
https://fair-software.eu/state?rep&lic&reg (but not &cit&che)
After the jump, the page shows repositoy, license, and registrt as collapsed sections because the user already complies; section citation and checklist are expanded with explanation of what to do about it.

Or, ?compliance=10010

👍 That would indeed be nice to have. Right now I always forget which dots my repos got and which one they are still missing :D

Note, I've started work on this here https://github.com/fair-software/report. Still needs CSS to have the same visual identity as fair-software.nl, and prose to go along with it.

Note, I've started work on this here https://github.com/fair-software/report. Still needs CSS to have the same visual identity as fair-software.nl, and prose to go along with it.


Add Files.

README(Japanese),Japanese Games TergetList.json,TergetList.json adding.

Thanks for your contribution.


[Impeller] FadeTransition not working when pushing a route

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce

Run my code sample (below) with Impeller. (I ran on my iPhone 13 Pro with flutter run and saw this message go by: "Using the Impeller rendering backend.") It's the same code sample I gave for https://github.com/flutter/flutter/issues/130167. Notice in particular the FadeTransition.
Press the "Press" button.

Expected results
The background fades from black to blue.
Actual results
The background cuts suddenly from black to blue, without fading.
Code sample
Code sample
import 'dart:ui';

import 'package:flutter/material.dart';

void main() => runApp(const App());

class App extends StatelessWidget {
  const App({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Center(
        child: Builder(
          builder: (context) => ElevatedButton(
            onPressed: () {
              Navigator.of(context).push(PageRouteBuilder(
                pageBuilder: (
                  BuildContext context,
                  Animation<double> animation,
                  Animation<double> secondaryAnimation,
                ) => PhysicalModel(
                  color: Colors.blue,
                  child: Container()),
                transitionsBuilder: (
                  BuildContext context,
                  Animation<double> animation,
                  Animation<double> secondaryAnimation,
                  Widget child,
                ) => FadeTransition(
                  opacity: animation.drive(CurveTween(curve: Curves.ease)),
                  child: child)));
            },
            child: const Text('Press')))));
  }
}

Logs
No errors expected or observed, given that I used a Flutter version with the fix for https://github.com/flutter/flutter/issues/130167.
Flutter Doctor output
Doctor output
$ flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel main, 3.13.0-5.0.pre.29, on macOS 13.4.1 22F82 darwin-x64,
    locale en-US)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.3)
[✓] VS Code (version 1.80.1)
[✓] Connected device (3 available)
    ! Error: Chris’s Apple Watch needs to connect to determine its availability.
      Check the connection between the device and its companion iPhone, and the
      connection between the iPhone and Xcode. Both devices may also need to be
      restarted and unlocked. (code 1)
[✓] Network resources

• No issues found!

I found 9dbd6e6139134965bc21d1541859293393805195 as a commit where:

the crash in https://github.com/flutter/flutter/issues/130167 was not yet introduced, and
the fade happened as expected.

I haven't bisected to find the last such commit, though. Would that be helpful?

Reproducible using the code sample provided above.
https://github.com/flutter/flutter/assets/88313112/e82fb639-b0d1-4ef4-b9c0-c03fb8e19972

I haven't bisected to find the last such commit, though. Would that be helpful?

Hi @chrisbobbe, yes that would be very helpful.

flutter doctor -v
[✓] Flutter (Channel master, 3.13.0-6.0.pre.30, on macOS 13.4.1 22F770820d darwin-arm64, locale en-GB)
    • Flutter version 3.13.0-6.0.pre.30 on channel master at /Users/nexus/dev/sdks/flutters
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 33d174d797 (6 hours ago), 2023-07-18 22:36:21 -0400
    • Engine revision 39d60be72f
    • Dart version 3.1.0 (build 3.1.0-324.0.dev)
    • DevTools version 2.25.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/222.4459.24.2221.10121639/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode-14.3.0.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/222.4459.24.2221.10121639/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] IntelliJ IDEA Ultimate Edition (version 2023.1.3)
    • IntelliJ at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/IDEA-U/ch-0/231.9161.38/IntelliJ IDEA.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] IntelliJ IDEA Ultimate Edition (version 2023.1.4)
    • IntelliJ at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/IDEA-U/ch-0/231.9225.16/IntelliJ IDEA.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.80.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.68.0

[✓] Connected device (3 available)
    • Nexus (mobile)  • 00008020-001875E83A38002E • ios            • iOS 16.5.1 20F75
    • macOS (desktop) • macos                     • darwin-arm64   • macOS 13.4.1 22F770820d darwin-arm64
    • Chrome (web)    • chrome                    • web-javascript • Google Chrome 114.0.5735.198

[✓] Network resources
    • All expected network resources are available.

• No issues found!

This issue started with https://github.com/flutter/engine/commit/1419bdd04fc91992a7f5d7ce7c262d773b0e24b2
@bdero


fontWeight

I think we have a clash between Css.fontWeight (meaning "font-weight") and then the fontWeight helper that provides values

Should we fixed now after removing the subclasses :+1:


Copy repair merge

Thank you for your contribution! Twitter has decided to stop supporting Gizzard as an open source project. Sorry that your pull requests was not reviewed earlier.
We're now formally archiving this project but please feel free to fork and resurrect.


Redirect to newly created entry

I have a form to create an entry. Is is possible to redirect to the saved entry upon successfully saving it?

It should be, using the sprig.redirect template variable. On success, the saved entry ID will be available in the template as id.
{% if success is defined and success %}
    {% do sprig.redirect('/entry/' ~ id) %}
{% endif %}

Thanks! Works!


sometimes motion code can't be sent to repl with error message when quitting nvim

Thanks for this nice plugin and I have been using it for about a week and met an issue occasionly.
Sometimes the code selected by motion can not be sent to repl with the following error messages,
but no error reported if everything works good. I am gussing it is something related to buffer operation with nvim,
any tips? I am using nvim 0.8.3 stable and almost latest iron master.
Thank you!

...m/site/pack/packer/start/iron.nvim/lua/iron/lowlevel.lua:73: Invalid buffer id: 6
stack traceback:
^I[C]: in function 'nvim_buf_delete'
^I...m/site/pack/packer/start/iron.nvim/lua/iron/lowlevel.lua:73: in function <...m/site/pack/packer/start/iron.nvim/lua/iron/lowlevel.lua:67>

Iron version:

commit aa7aecc4410d475a62efff54896bd021501338f0 (grafted, HEAD -> master, origin/master, origin/HEAD)
Author: milanglacier<EMAIL_ADDRESS>Date:   Sun Mar 19 17:32:35 2023 -0400

    Feat: add `aichat` repl support. (#324)

It seems that it is a conflict in the shortcuts and send file works. I am closing this issue and reopen if it cann't be resolved.


local - creating a local cluster without docker running leaves the install in a bad state

1st attempt (docker is not running):
go run -ldflags=${LDFLAGS} . local
2022/11/18 15:47:44 kubefirst started
Logging at: /Users/pagottoo/kubeshop/github/kubefirst/logs/log_1668797264.log
LOG: 2022/11/18 15:47:44.441312 /Users/pagottoo/kubeshop/github/kubefirst/pkg/helpers.go:331: Using config file: /Users/pagottoo/.kubefirst
Init actions: 6 expected tasks ...

Download dependencies         ... done! [3 in 4.061s]
Create SSH keys               ... done! [1 in 4.092s]
Clone and Detokenize (GitOps) ... done! [1 in 8.432s]
- init is done!
[######################..............................................] [8s]
Process Parameters            ... done! [1 in 8.663s]
Init actions: 7 expected tasks ...

Setup gitops on github        ...  0.0% [............................] [0 in 236.082ms]
Send Telemetry                ... 50.0% [##############..............] [1 in 5.436027s]
Setup gitops on github        ...  0.0% [............................] [0 in 5.436169s]
Setup base cluster            ...  0.0% [............................] [0 in 5.436163s]
Install apps to cluster       ...  0.0% [............................] [0 in 5.436172s]
Error: error creating k3d cluster
exit status 1

LOG: 2022/11/18 15:47:59.694554 /Users/pagottoo/kubeshop/github/kubefirst/cmd/local/local.go:101: Installing Github version of Kubefirst
LOG: 2022/11/18 15:47:59.694793 /Users/pagottoo/kubeshop/github/kubefirst/internal/k3d/create.go:16: Create K3d cluster for local install
LOG: 2022/11/18 15:47:59.901232 /Users/pagottoo/kubeshop/github/kubefirst/pkg/shell.go:22: Error executing command: exit status 1
LOG: 2022/11/18 15:47:59.901324 /Users/pagottoo/kubeshop/github/kubefirst/pkg/shell.go:24: Command Execution: /Users/pagottoo/.k1/tools/k3d
LOG: 2022/11/18 15:47:59.901348 /Users/pagottoo/kubeshop/github/kubefirst/pkg/shell.go:25: OUT: INFO[0000] Prep: Network
INFO[0000] Deleting cluster 'kubefirst'

LOG: 2022/11/18 15:47:59.901381 /Users/pagottoo/kubeshop/github/kubefirst/pkg/shell.go:26: ERR: ERRO[0000] Failed to get nodes for cluster 'kubefirst': docker failed to get containers with labels 'map[k3d.cluster:kubefirst]': failed to list containers: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
ERRO[0000] Failed Cluster Preparation: Failed Network Preparation: failed to create cluster network: failed to check for duplicate docker networks: docker failed to list networks: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
ERRO[0000] Failed to create cluster >>> Rolling Back
ERRO[0000] Failed to get nodes for cluster 'kubefirst': docker failed to get containers with labels 'map[k3d.cluster:kubefirst]': failed to list containers: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
ERRO[0000] failed to get cluster: No nodes found for given cluster
FATA[0000] Cluster creation FAILED, also FAILED to rollback changes!

LOG: 2022/11/18 15:47:59.901407 /Users/pagottoo/kubeshop/github/kubefirst/internal/k3d/create.go:31: error creating k3d cluster

2nd attempt (docker running):
go run -ldflags=${LDFLAGS} . local
2022/11/18 15:48:38 kubefirst started
Logging at: /Users/pagottoo/kubeshop/github/kubefirst/logs/log_1668797318.log
LOG: 2022/11/18 15:48:38.474349 /Users/pagottoo/kubeshop/github/kubefirst/pkg/helpers.go:331: Using config file: /Users/pagottoo/.kubefirst
Error: folder: /Users/pagottoo/.k1 has files that can be left overs from a previous installation, please use kubefirst clean command to be ready for a new installation
exit status 1

2022/11/18 15:48:38 kubefirst started
Logging at: /Users/pagottoo/kubeshop/github/kubefirst/logs/log_1668797318.log
LOG: 2022/11/18 15:48:38.474349 /Users/pagottoo/kubeshop/github/kubefirst/pkg/helpers.go:331: Using config file: /Users/pagottoo/.kubefirst
Error: folder: /Users/pagottoo/.k1 has files that can be left overs from a previous installation, please use kubefirst clean command to be ready for a new installation
exit status 1

Is expected that the installer could continue the previous install, or should inform on the first attempt that docker is not running.

on top of that, we could check if docker is running in the first validation steps.

A check has been implemented to determine whether or not Docker is running before executing k3d/local commands.
https://github.com/kubefirst/kubefirst/blob/main/cmd/k3d/create.go#L726


Ticket #348

Changed ":hover" to "div:hover" on #toast-container

Linking: https://github.com/CodeSeven/toastr/issues/348