huowang

I encountered a problem when I converted edits files from XML to binary using the HDFS oev command
Usually this conversion operation will not be a problem, but my XML culture contains an OP_TRUNCATE operation node, in this case, the error is reported, the specific error is as follows. (sorry, I can only take a screenshot because the company environment does not allow copying code, the name of the file is not NameNode's default name because I backed up the edits file for testing).

The contents of the XML file are as follows

I found the error-reporting code and found that the blockFromXml method passed the entire data node instead of the subordinate BLOCK node. I think this was the reason. So I modified the code and recompiled it. Then I installed a single node Hadoop cluster and tested the HDFS oev command conversion file successfully. This is my first time to submit a patch. My English is not particularly good, I am not sure. Should the modified code be submitted in this way?
I hope I can contribute to the community.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
65
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1080
trunk passed

+1
compile
63
trunk passed

+1
checkstyle
48
trunk passed

+1
mvnsite
66
trunk passed

+1
shadedclient
780
branch has no errors when building and testing our client artifacts.

+1
javadoc
47
trunk passed

0
spotbugs
171
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
168
trunk passed

_ Patch Compile Tests _

+1
mvninstall
60
the patch passed

+1
compile
54
the patch passed

+1
javac
54
the patch passed

-0
checkstyle
42
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 327 unchanged - 0 fixed = 328 total (was 327)

+1
mvnsite
61
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
719
patch has no errors when building and testing our client artifacts.

+1
javadoc
48
the patch passed

+1
findbugs
168
the patch passed

_ Other Tests _

-1
unit
6230
hadoop-hdfs in the patch failed.

+1
asflicense
36
The patch does not generate ASF License warnings.

9794

Reason
Tests

Failed junit tests
hadoop.hdfs.TestDFSStripedOutputStream

hadoop.hdfs.server.namenode.TestNameNodeMXBean

hadoop.hdfs.server.diskbalancer.TestDiskBalancer

hadoop.hdfs.TestDFSStripedInputStream

hadoop.hdfs.web.TestWebHdfsTimeouts

hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.TestDFSStripedOutputStreamWithFailure

hadoop.hdfs.server.namenode.TestFSImage

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1021

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux b89a37b2e035 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / be80334

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/1/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/1/testReport/

Max. process+thread count
3962 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Can I describe how to reproduce bugs and test modified patches?
1 TRUNCATE operations are performed on any file in hdfs, such as Hadoop fs-truncate-w 100 /test.txt,
2 Use the HDFS oev command to parse the edits file generated by the first step from binary format to XML format, such as HDFS oev -i edits -o edits.xml
3 Then reverse serialization of the file from XML to binary based on the results of the second step, such as HDFS oev-i edits.xml-o edits.binary-p binary
4 This bug will appear, and I also submitted the report HDFS-14604 on jira.
5 I fixed the bug in the code I submitted this time, compiled this version of the code and then decompressed it in Linux. Using the oev command provided by this version directly, the operation described in the third step can be successfully executed.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
61
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
1
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1044
trunk passed

+1
compile
59
trunk passed

+1
checkstyle
43
trunk passed

+1
mvnsite
61
trunk passed

+1
shadedclient
703
branch has no errors when building and testing our client artifacts.

+1
javadoc
49
trunk passed

0
spotbugs
157
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
154
trunk passed

_ Patch Compile Tests _

+1
mvninstall
61
the patch passed

+1
compile
58
the patch passed

+1
javac
58
the patch passed

-0
checkstyle
40
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 327 unchanged - 0 fixed = 328 total (was 327)

+1
mvnsite
65
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
718
patch has no errors when building and testing our client artifacts.

+1
javadoc
45
the patch passed

+1
findbugs
169
the patch passed

_ Other Tests _

-1
unit
6865
hadoop-hdfs in the patch failed.

+1
asflicense
31
The patch does not generate ASF License warnings.

10294

Reason
Tests

Failed junit tests
hadoop.hdfs.tools.TestDFSAdminWithHA

hadoop.hdfs.TestFileCreation

hadoop.hdfs.web.TestWebHdfsTimeouts

hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerWithStripedBlocks

hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.tools.TestECAdmin

hadoop.hdfs.TestInjectionForSimulatedStorage

Subsystem
Report/Notes

Docker
Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1021

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux f00c45f69dcd 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 4e66cb9

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/2/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/2/testReport/

Max. process+thread count
3886 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
93
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1090
trunk passed

+1
compile
60
trunk passed

+1
checkstyle
42
trunk passed

+1
mvnsite
60
trunk passed

+1
shadedclient
716
branch has no errors when building and testing our client artifacts.

+1
javadoc
47
trunk passed

0
spotbugs
166
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
165
trunk passed

_ Patch Compile Tests _

+1
mvninstall
63
the patch passed

+1
compile
54
the patch passed

+1
javac
54
the patch passed

-0
checkstyle
44
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 327 unchanged - 0 fixed = 328 total (was 327)

+1
mvnsite
77
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
733
patch has no errors when building and testing our client artifacts.

+1
javadoc
46
the patch passed

+1
findbugs
158
the patch passed

_ Other Tests _

-1
unit
6590
hadoop-hdfs in the patch failed.

-1
asflicense
32
The patch generated 3 ASF License warnings.

10131

Reason
Tests

Failed junit tests
hadoop.hdfs.TestLeaseRecovery

hadoop.hdfs.TestRead

hadoop.hdfs.TestMaintenanceState

hadoop.hdfs.server.blockmanagement.TestHostFileManager

hadoop.hdfs.server.blockmanagement.TestPendingReconstruction

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1021

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux a118eca0d4c5 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / c0a0c35

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/3/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/3/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/3/testReport/

asflicense
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/3/artifact/out/patch-asflicense-problems.txt

Max. process+thread count
4693 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/3/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Hi, thanks for the contribution, please follow the How to Contribute wiki https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute#HowToContribute-CreatingaGitHubpullrequest
Specifically, file a ticket at Apache Hadoop JIRA, and prepend your git commit message with the JIRA id.

ok
I'd love to, but I've been a little busy lately. I'll be out in a few days.
<EMAIL_ADDRESS>From: Wei-Chiu Chuang
Date: 2019-07-26 23:57
To: apache/hadoop
CC: 苍井空的裸替; Author
Subject: Re: [apache/hadoop] huowang (#1021)
Hi, thanks for the contribution, please follow the How to Contribute wiki https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute#HowToContribute-CreatingaGitHubpullrequest
Specifically, file a ticket at Apache Hadoop JIRA, and prepend your git commit message with the JIRA id.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
78
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1223
trunk passed

+1
compile
70
trunk passed

+1
checkstyle
51
trunk passed

+1
mvnsite
74
trunk passed

+1
shadedclient
903
branch has no errors when building and testing our client artifacts.

+1
javadoc
57
trunk passed

0
spotbugs
191
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
189
trunk passed

_ Patch Compile Tests _

+1
mvninstall
72
the patch passed

-1
compile
18
hadoop-hdfs in the patch failed.

-1
javac
18
hadoop-hdfs in the patch failed.

-0
checkstyle
45
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 327 unchanged - 0 fixed = 328 total (was 327)

+1
mvnsite
71
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
824
patch has no errors when building and testing our client artifacts.

+1
javadoc
51
the patch passed

+1
findbugs
189
the patch passed

_ Other Tests _

-1
unit
6324
hadoop-hdfs in the patch failed.

-1
asflicense
35
The patch generated 1 ASF License warnings.

10331

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.TestReencryption

hadoop.hdfs.TestDFSClientRetries

hadoop.hdfs.server.datanode.TestLargeBlockReport

hadoop.hdfs.server.namenode.TestReconstructStripedBlocks

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1021

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 7dfdbd3029a0 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 17e8cf5

Default Java
1.8.0_212

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/4/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/4/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/4/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/4/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/4/testReport/

asflicense
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/4/artifact/out/patch-asflicense-problems.txt

Max. process+thread count
2732 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/4/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
53
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1362
trunk passed

+1
compile
66
trunk passed

+1
checkstyle
44
trunk passed

+1
mvnsite
76
trunk passed

+1
shadedclient
862
branch has no errors when building and testing our client artifacts.

+1
javadoc
54
trunk passed

0
spotbugs
177
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
174
trunk passed

_ Patch Compile Tests _

+1
mvninstall
65
the patch passed

+1
compile
59
the patch passed

+1
javac
59
the patch passed

-0
checkstyle
47
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 327 unchanged - 0 fixed = 328 total (was 327)

+1
mvnsite
75
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
824
patch has no errors when building and testing our client artifacts.

+1
javadoc
50
the patch passed

+1
findbugs
186
the patch passed

_ Other Tests _

-1
unit
5749
hadoop-hdfs in the patch failed.

-1
asflicense
55
The patch generated 5 ASF License warnings.

9860

Reason
Tests

Failed junit tests
hadoop.hdfs.TestReadStripedFileWithDecoding

hadoop.hdfs.TestEncryptionZonesWithKMS

hadoop.hdfs.TestReplaceDatanodeFailureReplication

hadoop.hdfs.server.datanode.TestLargeBlockReport

hadoop.hdfs.TestDFSStripedOutputStreamWithRandomECPolicy

hadoop.hdfs.TestMaintenanceState

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1021

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 65dbb8d5cd4a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 70b4617

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/5/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/5/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/5/testReport/

asflicense
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/5/artifact/out/patch-asflicense-problems.txt

Max. process+thread count
4925 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/5/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
99
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1283
trunk passed

+1
compile
69
trunk passed

+1
checkstyle
47
trunk passed

+1
mvnsite
63
trunk passed

+1
shadedclient
907
branch has no errors when building and testing our client artifacts.

+1
javadoc
60
trunk passed

0
spotbugs
184
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
182
trunk passed

_ Patch Compile Tests _

+1
mvninstall
73
the patch passed

+1
compile
65
the patch passed

+1
javac
65
the patch passed

-0
checkstyle
50
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 327 unchanged - 0 fixed = 328 total (was 327)

+1
mvnsite
79
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
824
patch has no errors when building and testing our client artifacts.

+1
javadoc
55
the patch passed

+1
findbugs
190
the patch passed

_ Other Tests _

-1
unit
6256
hadoop-hdfs in the patch failed.

+1
asflicense
37
The patch does not generate ASF License warnings.

10417

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestLargeBlockReport

hadoop.hdfs.TestMultipleNNPortQOP

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1021

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 567d4773bb05 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 397a563

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/6/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/6/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/6/testReport/

Max. process+thread count
3228 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/6/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
40
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1037
trunk passed

+1
compile
56
trunk passed

+1
checkstyle
43
trunk passed

+1
mvnsite
65
trunk passed

+1
shadedclient
723
branch has no errors when building and testing our client artifacts.

+1
javadoc
45
trunk passed

0
spotbugs
157
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
154
trunk passed

_ Patch Compile Tests _

+1
mvninstall
58
the patch passed

+1
compile
49
the patch passed

+1
javac
49
the patch passed

-0
checkstyle
39
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 327 unchanged - 0 fixed = 328 total (was 327)

+1
mvnsite
56
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
686
patch has no errors when building and testing our client artifacts.

+1
javadoc
47
the patch passed

+1
findbugs
158
the patch passed

_ Other Tests _

-1
unit
4948
hadoop-hdfs in the patch failed.

+1
asflicense
28
The patch does not generate ASF License warnings.

8280

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication

hadoop.hdfs.server.datanode.TestDirectoryScanner

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1021

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 9c9aed7bc9a0 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / e356e4f

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/7/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/7/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/7/testReport/

Max. process+thread count
4037 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/7/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
62
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1270
trunk passed

+1
compile
65
trunk passed

+1
checkstyle
46
trunk passed

+1
mvnsite
69
trunk passed

+1
shadedclient
785
branch has no errors when building and testing our client artifacts.

+1
javadoc
55
trunk passed

0
spotbugs
177
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
175
trunk passed

_ Patch Compile Tests _

+1
mvninstall
65
the patch passed

+1
compile
57
the patch passed

+1
javac
57
the patch passed

-0
checkstyle
44
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 327 unchanged - 0 fixed = 328 total (was 327)

+1
mvnsite
64
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
743
patch has no errors when building and testing our client artifacts.

+1
javadoc
49
the patch passed

+1
findbugs
202
the patch passed

_ Other Tests _

-1
unit
7409
hadoop-hdfs in the patch failed.

-1
asflicense
32
The patch generated 3 ASF License warnings.

11258

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.TestStorageRestore

hadoop.hdfs.server.diskbalancer.command.TestDiskBalancerCommand

hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency

hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.server.namenode.TestFsck

hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1021

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 3f055a58faad 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 094d736

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/8/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/8/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/8/testReport/

asflicense
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/8/artifact/out/patch-asflicense-problems.txt

Max. process+thread count
3889 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/8/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
36
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1325
trunk passed

+1
compile
65
trunk passed

+1
checkstyle
53
trunk passed

+1
mvnsite
78
trunk passed

+1
shadedclient
860
branch has no errors when building and testing our client artifacts.

+1
javadoc
52
trunk passed

0
spotbugs
172
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
170
trunk passed

_ Patch Compile Tests _

+1
mvninstall
63
the patch passed

+1
compile
57
the patch passed

+1
javac
57
the patch passed

-0
checkstyle
45
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 327 unchanged - 0 fixed = 328 total (was 327)

+1
mvnsite
63
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
801
patch has no errors when building and testing our client artifacts.

+1
javadoc
56
the patch passed

+1
findbugs
197
the patch passed

_ Other Tests _

-1
unit
5793
hadoop-hdfs in the patch failed.

+1
asflicense
49
The patch does not generate ASF License warnings.

9811

Reason
Tests

Failed junit tests
hadoop.hdfs.TestMultipleNNPortQOP

hadoop.hdfs.TestLeaseRecovery2

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1021

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux db9b81253a3f 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 69ddb36

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/9/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/9/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/9/testReport/

Max. process+thread count
2921 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/9/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
42
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1148
trunk passed

+1
compile
68
trunk passed

+1
checkstyle
52
trunk passed

+1
mvnsite
63
trunk passed

+1
shadedclient
815
branch has no errors when building and testing our client artifacts.

+1
javadoc
54
trunk passed

0
spotbugs
163
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
160
trunk passed

_ Patch Compile Tests _

+1
mvninstall
63
the patch passed

+1
compile
57
the patch passed

+1
javac
57
the patch passed

-0
checkstyle
46
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 327 unchanged - 0 fixed = 328 total (was 327)

+1
mvnsite
63
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
746
patch has no errors when building and testing our client artifacts.

+1
javadoc
51
the patch passed

+1
findbugs
172
the patch passed

_ Other Tests _

-1
unit
5220
hadoop-hdfs in the patch failed.

+1
asflicense
40
The patch does not generate ASF License warnings.

8925

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.fsdataset.impl.TestScrLazyPersistFiles

hadoop.hdfs.TestLargeBlock

hadoop.hdfs.TestDFSClientRetries

hadoop.hdfs.TestLeaseRecovery2

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1021

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux d2c8e9f8e56f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 3329257

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/10/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/10/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/10/testReport/

Max. process+thread count
3884 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/10/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
39
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1097
trunk passed

+1
compile
64
trunk passed

+1
checkstyle
54
trunk passed

+1
mvnsite
76
trunk passed

+1
shadedclient
834
branch has no errors when building and testing our client artifacts.

+1
javadoc
60
trunk passed

0
spotbugs
191
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
188
trunk passed

_ Patch Compile Tests _

+1
mvninstall
74
the patch passed

+1
compile
60
the patch passed

+1
javac
60
the patch passed

-0
checkstyle
54
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 327 unchanged - 0 fixed = 328 total (was 327)

+1
mvnsite
74
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
765
patch has no errors when building and testing our client artifacts.

+1
javadoc
57
the patch passed

+1
findbugs
171
the patch passed

_ Other Tests _

-1
unit
5333
hadoop-hdfs in the patch failed.

-1
asflicense
38
The patch generated 3 ASF License warnings.

9098

Reason
Tests

Failed junit tests
hadoop.hdfs.TestDecommission

hadoop.hdfs.TestPread

hadoop.hdfs.TestErasureCodingPoliciesWithRandomECPolicy

hadoop.hdfs.TestHDFSFileSystemContract

hadoop.hdfs.TestErasureCodeBenchmarkThroughput

hadoop.hdfs.tools.TestDFSAdminWithHA

hadoop.hdfs.TestClientReportBadBlock

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1021

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 64b314495650 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 915cbc9

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/11/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/11/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/11/testReport/

asflicense
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/11/artifact/out/patch-asflicense-problems.txt

Max. process+thread count
4218 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1021/11/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Hi @arthas-171
Would you create an issue in ASF jira before submitting a pull request?
This is a guide for contributors: https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute

hi @aajisaka
yes i have created a issue ,HDFS-14604 https://issues.apache.org/jira/browse/HDFS-14604


Fix changelog parsing on ignored packages (when PRs are either labeled or unlabeled)

Resolves: https://github.com/embroider-build/create-release-plan-setup/issues/91
Helps with: https://github.com/adopted-ember-addons/program-guidelines/issues/28
Unblocks: https://github.com/NullVoxPopuli/limber/pull/1673
As well as a few releases on the adopted ember addons org (I don't remember where now, but folks have arbitrarily been working around the problem by adding internal to their PRs -- so this is more a fix for a big annoyance than a fix for something show-stopping).
This seems to do what I want, however it looks like like we need to do further changelog filtering and not use @ef4/lerna-changelog's default output.

package list should exclude private packages
package groups should be combined since if just removing the string, we'd have duplicate package groups.

Alternate fix here: https://github.com/embroider-build/github-changelog/pull/16 (which I think is he correct fix and we should not merge this (#60) PR)
Testing
In the root package.json:
"release-plan": "github:embroider-build/release-plan#dist/ignore-private-packages-detected-from-the-changelog-generator-dist"

or
"release-plan": "github:embroider-build/release-plan#bbd8d70"

Preview: https://github.com/NullVoxPopuli/limber/pull/1673

I agree that the github-changelog fix is the right fix so let's put our effort over there to make it happen 👍


Fixing a deprecation warning with alias_method_chain

Previous pull requests had fixed some of these, but one was missed.  This should fix the last remnant.

Merged #85, sorry for the delay!! :bow: :bow: :bow:

Any chance of getting this in a tagged release version?

@chadwilken I'm considering to release, for now please try master and report any bugs


fix typo

Not a typo. There is ABI and API. We keep the ABI stable, and the API backwards compatible. ABI stands for Application Binary Interface.

Ah, cool. Thanks for clarification.


Figure out a way to only save non-default values in TOML, JSON, etc

This would make our config files much nicer.

Implemented in 1631ed7b7fa16d7c23bb2bc7515108560a253472 and the commits after it as laser.NonDefaultFields.


Synchrosqueezing: requesting reviewers

I am porting MATLAB's Synchrosqueezing Toolbox to Python, and need reviewers; an eventual goal is a PR to PyWavelets, and this feature was requested. Repository: ssqueezepy.
I lack almost any understanding of synchrosqueezing, thus my ability to design unit tests and proofread the original source code is limited; as such, someone with a familiarity w/ synchrosqueezing is desired. I've already made numerous corrections, but many remain.
The README is concise and descriptive, see for details. Anyone willing is free to make PR's and open Issues on the repository. I welcome any collaborators.

If I were to give priority to any specific function, it'd be synsq_cwt_fwd, as it's the one I use in my immediate application, and has the closest agreement with paper results.

I have left a few initial comments in your repository: OverLordGoldDragon/ssqueezepy#1
It looks like you are off to a good start in porting the Matlab toolbox.
Probably the primary issue to address in terms of integrating the code into PyWavelets itself would be:
1.) Can get a good result when reusing the CWT that is already in PyWavelets (and if not, why?). Ideally, we would prefer not to have a another duplicate CWT implementation to maintain.
Once the above issue is resolved, I would start out here with an initial PR containing perhaps just synsq_cwt_fwd and supporting functions. It is a bit easier to comment on PRs in GitHub than in a base repository due to the built in review functionality.

@grlee77 Agreed on both the PR and PyWavelets' CWT; will do. Also fair regarding opts, though I find it better to keep some common and reasonably defaulatble arguments in **kwargs to avoid clutter; the docstring will list them all.
To notify, though, unsure when I'll resume working on the repo, as I realized a bit late that the synsq_cwt_fwd transform upsamples by anywhere from 250x to 1000x - which breaks the deal for my 60GB dataset (--> 15-60TB), so I won't have any use for it.

@grlee77 Figured a viable dim-reduction to offset the upsampling - so I'm back in the game.
Will focus on the CWT case. pywt.cwt vs. cwt_fwd results & code below. Latter involves a preprocessing step which I've reproduced prior to feeding to former. The two are more similar than not, but differences remain significant.
Relevant portions of source code differ notably, though as I'm unfamiliar with relevant concepts (wavelet transforms, etc), can't say much further. It seems, however, that cwt_fwd differs from pywt.cwt in concept, not implementation bug - in which case cwt_fwd will need to be added to PyWavelets for synchrosqueezing.

Observations:

cwt_fwd has an imaginary component, pywt.cwt doesn't
pywt.cwt's norm is ~10x greater (see norm_abs)
The signal (x) preprocessing seems to undo itself in this case as evident in vs. Unprocessed
pywt.cwt handles the noisy signal (sN) case considerably differently in the upper-half

Source code
import numpy as np
import matplotlib.pyplot as plt
import pywt

from ssqueezepy.wavelet_transforms import cwt_fwd
from ssqueezepy.utils import padsignal
np.random.seed(0)

def viz_signal(t, s, sN, s1, s2, s3):
    _, axes = plt.subplots(1, 3, sharey=True, figsize=(10, 3))
    axes[0].plot(t, s1)
    axes[1].plot(t, s2)
    axes[2].plot(t, s3)
    plt.subplots_adjust(left=0, right=1, bottom=0, top=1, wspace=0, hspace=0)
    plt.show()

    _, axes = plt.subplots(2, 1, sharex=True, figsize=(10, 5))
    plt.subplots_adjust(left=0, right=1, bottom=0, top=1, wspace=0, hspace=0)
    axes[0].plot(t, s)
    axes[1].plot(t, sN)
    plt.show()

def _get_norm(data, norm_rel, norm_abs):
    if norm_abs is not None and norm_rel != 1:
        raise ValueError("specify only one of `norm_rel`, `norm_abs`")

    if norm_abs is None:
        vmax = np.max(np.abs(data)) * norm_rel
        vmin = -vmax
    else:
        vmin, vmax = norm_abs
    return vmin, vmax

def _make_plots(*data, cmap='bwr', norm=None, titles=None, suptitle=None):
    vmin, vmax = norm or None, None
    for x in data:
        print(x.shape)
    _, axes = plt.subplots(1, len(data), sharey=True, figsize=(11, 4))
    plt.subplots_adjust(left=0, right=1, bottom=0, top=1, wspace=.1, hspace=0)
    if suptitle is not None:
        plt.suptitle(suptitle, weight='bold', fontsize=13, y=1.1)

    for i, x in enumerate(data):
        axes[i].imshow(x, cmap=cmap, aspect='auto', vmin=vmin, vmax=vmax)
        axes[i].invert_yaxis()
        axes[i].set_title(titles[i], fontsize=14, weight='bold')
    plt.show()

def viz_compare(x1, x2, cmap='bwr', norm_rel=1, norm_abs=None, suptitle=None):
    vmin, vmax = _get_norm(np.real(x1), norm_rel, norm_abs)
    _make_plots(np.real(x1), np.real(x2), cmap=cmap,
                norm=(vmin, vmax), titles=("s", "sN"), suptitle=suptitle)

def viz_re_im(x, cmap='bwr', norm_rel=1, norm_abs=None, suptitle=None):
    vmin, vmax = _get_norm(np.real(x), norm_rel, norm_abs)
    _make_plots(np.real(x), np.imag(x), cmap=cmap,
                norm=(vmin, vmax), titles=("Real", "Imag"), suptitle=suptitle)

def _pre_pywt_cwt(x, opts, nv=32, dt=1):
    opts = opts.copy()
    opts['padtype'] = opts.get('padtype', 'symmetric')
    opts['rpadded'] = opts.get('rpadded', 0)

    n = len(x)
    x, N, n1, n2 = padsignal(x, opts['padtype'])

    xMean = np.mean(x)
    x -= xMean

    # choosing more than this means the wavelet window becomes too short
    noct = np.log2(N) - 1
    assert(noct > 0 and noct % 1 == 0)
    assert(nv > 0   and nv   % 1 == 0)
    assert(dt > 0)
    assert(not np.any(np.isnan(x)))

    na = int(noct * nv)
    Wx_scales = np.power(2 ** (1 / nv), np.arange(1, na + 1))
    Wx_scales *= dt

    if not opts['rpadded']:
        x = x[n1:n1 + n]
    return x, Wx_scales

########### signals #################################################
t = np.linspace(0, 10, 2048)
s1 = (1 + .2*np.cos(t)) * np.cos(2*np.pi*(2*t   + .3*np.cos(t)))
s2 = (1 + .3*np.cos(t)) * np.cos(2*np.pi*(2.4*t + .3*np.sin(t) + .5*t**1.2)
                                 ) * np.exp(-t/15)
s3 = np.cos(2*np.pi*(5.3*t + 0.2*t**1.3))
N = np.random.randn(len(t)) * np.sqrt(2.4)
s  = s1 + s2 + s3
sN = s + N
viz_signal(t, s, sN, s1, s2, s3)

########### ssqueezepy ##############################################
OPTS = {'type': 'morlet', 'mu': 1}
Wx_s,  *_ = cwt_fwd(s,  'morlet', opts=OPTS)
Wx_sN, *_ = cwt_fwd(sN, 'morlet', opts=OPTS)
viz_compare(Wx_s, Wx_sN, cmap='bwr', norm_abs=(-1.3, 1.3),
            suptitle="SSQUEEZEPY [Processed Signal]")

########### pywt ####################################################
sx,  Wx_scales_sx  = _pre_pywt_cwt(s,  opts=OPTS)
sxN, Wx_scales_sxN = _pre_pywt_cwt(sN, opts=OPTS)

coef_s,  _ = pywt.cwt(s,  Wx_scales_sx,  'morl', method='fft')
coef_sN, _ = pywt.cwt(sN, Wx_scales_sxN, 'morl', method='fft')
viz_compare(coef_s, coef_sN, cmap='bwr', norm_abs=(-10, 10),
            suptitle="SSQUEEZEPY [Unprocessed Signal]")

coef_sx,  _ = pywt.cwt(sx,  Wx_scales_sx,  'morl', method='fft')
coef_sxN, _ = pywt.cwt(sxN, Wx_scales_sxN, 'morl', method='fft')
viz_compare(coef_sx, coef_sxN, cmap='bwr', norm_abs=(-10, 10),
            suptitle="SSQUEEZEPY [Processed Signal]")

########### both, real vs. imag #####################################
viz_re_im(Wx_s,   suptitle="SSQUEEZEPY")
viz_re_im(coef_s, suptitle="PYWT")

The lack of an imaginary component from pywt.cwt is due to the choice of wavelet. 'morl' is real valued, to get complex output use something like 'cmor1.5-1.0' where the 1.5 and 1.0 are the bandwidth and center frequency parameters as described in the pywavelets docs for cwt. I expect 1.0 center frequency is the correct choice but some digging is required to find what bandwidth param best matches the implementation in cwt_fwd.

@grlee77 Thanks again for your early reviews. I've decided to proceed independent of PyWavelets, one reason being the apparent pace at which PR's are handled. I stand by pywt keeping its current CWT implementation as a valid and unique alternative to others'.


Random files are not updated after edit

Describe the bug
Some files are not updated after I edited them in TYPO3. This mostly happens with page Templates. Partials get updated when reloading the Frontend. Even if I delete Browser and all TYPO3 Caches. Since Friday a PHP class I am editing aren't updating. Only if I "ddev restart" my project, the edits are going processed. Other PHP classes works fine when i edit them, but not this one. And it's annoying restart ddev always after changing files.
To Reproduce
It seems to happen randomly.
Mostly it happens on Page Templates in TYPO3.
Expected behavior
Updated view or logic.
Screenshots
If applicable, add screenshots to help explain your problem.
Version and configuration information (please complete the following information):

Host computer OS and Version: macOS - current Version
Docker version:  18.09.2
ddev version: 1.8.0 (appears since 1.3.x)

`
APIVersion: v1.8.0
name: ___
type: typo3
docroot: public
php_version: "7.2"
webserver_type: nginx-fpm
router_http_port: "80"
router_https_port: "443"
xdebug_enabled: false
additional_hostnames:

xxx.xx

additional_fqdns: []
mariadb_version: "10.2"
nfs_mount_enabled: false
provider: default
hooks:
post-start:

exec-host: cp -f ./git-hooks/pre-commit ./.git/hooks/pre-commit
exec: composer install -d /var/www/html
exec: /var/www/html/vendor/bin/typo3cms database:updateschema
exec: /var/www/html/vendor/bin/typo3cms cache:flush --force
exec-host: ddev exec -s node npm i --quiet
exec-host: ddev exec -s node npm run setup
`

Thanks for the report.
You say "Since I edited them in TYPO3". Does that mean that the webserver was updating them, or that you were editing them inside the container, or that you were editing on the host?
It sounds like you're having trouble with Docker, so the first thing I'd do is restart docker (or consider a factory reset).  I haven't heard of this before, except when people were using the now-deprecated webcache, which you don't seem to be doing.

If you're able to demonstrate this again, please explore the differences inside the web container and on the host (use ddev ssh to go into the web container and explore). See if you can tell what's really going on. What files are where? Can you use "touch" inside the container and see it propagate to the host? Can you use touch on the host and have it propagate to the container?

I ran into this too. Edits to a PHP file (that I made locally) were not reflected in the running application. I've updated and restarted Docker, but the problem persists. I can't find any docker setting for webcache so maybe that has been removed since 2019 :)
I used ddev ssh and I can see the same changes to the file there as I can see in my editor. But it's like the running application is using a copy of this file from 1 hour ago.
I just tried it with a .js file in addition to PHP. Neither change is reflected in the running application. :(

Hi @jenlampton ! Please open new issues instead of commenting on 2019 issues.
If you see the same thing inside ddev ssh (good debugging!) as you see on the host, then the only suggestion I'd have is that you have altered the PHP configuration of opcache ? You haven't mentioned what PHP version, etc. But it's opcache's job to cache code in exactly the manner you're saying, but I haven't heard of any failures there unless there were custom configuration.
If this is it, I imagine a ddev exec killall  -USR2 php-fpm would fix it.
And of course... make sure you're accessing the site/project you think you are. That's certainly a way to get confusing behavior like this. You might want to do a ddev logs -f to watch the logs.
If you create your own issue, you'll be asked to do a ddev debug test, and it would detect custom configuration like this.

Please open new issues instead of commenting on 2019 issues.

I'm not yet sure I have a ddev issue :)  If it turns out that I do, I'll open a new issue.
This post had a similar situation so I thought I'd use it to document my problem (and potential solution) here, for the next person who runs into it. You're just so helpful that you found me before I found my problem! :)

the only suggestion I'd have is that you have altered the PHP configuration of opcache

If I did this, I didn't do it on purpose.

If this is it, I imagine a ddev exec killall  -USR2 php-fpm would fix it.

It did not :(

And of course... make sure you're accessing the site/project you think you are. That's certainly a way to get confusing behavior like this. You might want to do a ddev logs -f to watch the logs.

I keep thinking this is my problem, but I just restarted EVERYTHING (including my computer incase this was a MacOS / mutagen issue) so now I have only one ddev site/container running. And I'm editing files in the same place I ran ddev start so It has to be code for the site I'm running.

If you create your own issue, you'll be asked to do a ddev debug test, and it would detect custom configuration like this.

I just ran this to be able to open a thread in discord. But now that I've restarted I'll do it again :)

If you're new to Discord I think you have to accept the terms and wait 10 minutes or something. Please read what it says and accept the terms.

An update for anyone else (or my future self) who finds this ticket in the future: I believe one of the following things stopped or cleared my cache, here is everything I did:

Run ddev debug dockercheck (all was okay)
Updated and restarted ddev
Updated and restarted docker
Restarted my whole computer - MacOS
Confirm only 1 ddev/docker container is running (so I can't be looking at the wrong one)

After this point, I noticed one of the three changes I was making did appear (added the word "hello" to a table header in PHP as a sanity check).  The other 2 changes I was making (one in PHP and one in JS) were still not appearing because that particular code was being executed, but then something else later overwrote the output :( That part was user error.
I recommend you update and restart everything (especially the whole computer if you are on MacOS). That's always a good idea anyway :)


Update fs2-core, fs2-io to 2.5.5

Updates

co.fs2:fs2-core
co.fs2:fs2-io

from 2.4.6 to 2.5.5.
GitHub Release Notes - Changelog - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "co.fs2" } ]

labels: library-update, semver-minor

Superseded by #258.


adding smart app launch

@sebastian-iancu should I setup a simple preview url for PRs, or should we be merging at regular intervals and getting feedback from the community?

@sidharthramesh , you can now deploy to github pages from that branch; this way the html can be checked regularly while in progress, and once the first draft is done we can merge it to master and becomes readable "normally" through specifications website.

Hey @sebastian-iancu , should I merge?


Small fixes in flux product

great lakes region uitknippen (ERA5 land-sea mask)
center at month before interpolating
check locaties van grid cellen (bounds/centers)

check locaties van grid cellen (bounds/centers)

ERA5: center of tile
CarbonTracker: center of tile
biomass dataset: center of tile
MODIS NIRV: center of tile
SPEI: center of tile

center at month before interpolating
This is now implemented too

@ClaireDons you can mark this as closed when you have removed the great lakes


Xaml Controls Gallery Home Page Visual Refresh

Description

Update What's New page to Home
Add useful links to landing page
Update part of controls icons

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

This is awesome Karen! I'm super excited about this :)


Blank line after node anchor: YAMLSemanticError: Nested mappings are not allowed in compact mappings

Describe the bug
When there is a a blank line after a node anchor, YAMLSemanticError is thrown. If I understand the YAML spec correctly, nothing prohibits this.
To Reproduce
import YAML from 'yaml'

let result = YAML.parse('key1: &default\n\n  subkey1: value1\n\nkey2:\n  <<: *default\n')
console.log(result)

Expected behaviour
{ key1: { subkey1: 'value1' }, key2: { subkey1: 'value1' } }

Actual behaviour
$ node index.mjs
/home/jon/test/node_modules/yaml/dist/resolve/resolveMap.js:144
            doc.errors.push(new errors.YAMLSemanticError(item.node, msg));
                            ^

YAMLSemanticError: Nested mappings are not allowed in compact mappings at line 1, column 7:

key1: &default
      ^^^^^^^^…

    at resolveBlockMapItems (/home/jon/test/node_modules/yaml/dist/resolve/resolveMap.js:144:29)
    at Object.resolveMap (/home/jon/test/node_modules/yaml/dist/resolve/resolveMap.js:17:78)
    at Object.resolveTag (/home/jon/test/node_modules/yaml/dist/resolve/resolveTag.js:57:28)
    at resolveNodeValue (/home/jon/test/node_modules/yaml/dist/resolve/resolveNode.js:102:34)
    at Object.resolveNode (/home/jon/test/node_modules/yaml/dist/resolve/resolveNode.js:156:15)
    at Object.parseContents (/home/jon/test/node_modules/yaml/dist/doc/parseContents.js:24:31)
    at Document.parse (/home/jon/test/node_modules/yaml/dist/doc/Document.js:221:19)
    at new Document (/home/jon/test/node_modules/yaml/dist/doc/Document.js:51:12)
    at parseDocument (/home/jon/test/node_modules/yaml/dist/index.js:26:15)
    at Object.parse (/home/jon/test/node_modules/yaml/dist/index.js:41:15) {
  nodeType: 'MAP',
  range: Range { start: 6, end: 34 },
  linePos: { start: { line: 1, col: 7 }, end: { line: 4, col: 1 } }
}

Versions (please complete the following information):

Environment: Node.js 14.6.0
yaml: 2.0.0-3

Additional context
The blank lines are added for readability and as a team style choice.
If one adds a comment above the subkey, a different error is thrown: "YAMLSyntaxError: All collection items must start at the same"
import YAML from 'yaml'

let result = YAML.parse('key1: &default\n\n  # This key ...\n  subkey1: value1\n\nkey2:\n  <<: *default\n')
console.log(result)

$ node index.mjs
/home/jon/test/node_modules/yaml/dist/cst/Collection.js:170
          this.error = new errors.YAMLSyntaxError(this, msg);
                       ^

YAMLSyntaxError: All collection items must start at the same column at line 1, column 1:

key1: &default
^^^^^^^^^^^^^^…

    at Collection.parse (/home/jon/test/node_modules/yaml/dist/cst/Collection.js:170:24)
    at /home/jon/test/node_modules/yaml/dist/cst/ParseContext.js:137:29
    at Document.parseContents (/home/jon/test/node_modules/yaml/dist/cst/Document.js:164:26)
    at Document.parse (/home/jon/test/node_modules/yaml/dist/cst/Document.js:227:19)
    at Object.parse (/home/jon/test/node_modules/yaml/dist/cst/parse.js:24:18)
    at parseDocument (/home/jon/test/node_modules/yaml/dist/index.js:25:23)
    at Object.parse (/home/jon/test/node_modules/yaml/dist/index.js:41:15)
    at file:///home/jon/test/index.mjs:3:19
    at ModuleJob.run (internal/modules/esm/module_job.js:152:23)
    at async Loader.import (internal/modules/esm/loader.js:166:24) {
  nodeType: 'MAP',
  range: Range { start: 0, end: 73 },
  linePos: { start: { line: 1, col: 1 }, end: { line: 8, col: 1 } }
}

That's really rather odd. It's fixed in the current master via the new parser, but that doesn't really help for Prettier. Commented about this more in the linked issue.

Fixed in<EMAIL_ADDRESS>


add listChain unit test

add listChain unit test

Codecov Report

Merging #394 (f62559d) into dev (c280d69) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                dev     #394      +/-   ##
============================================
+ Coverage     14.70%   14.73%   +0.03%
- Complexity      376      378       +2
============================================
  Files           181      181
  Lines          7745     7748       +3
  Branches        615      616       +1
============================================
+ Hits           1139     1142       +3
  Misses         6523     6523
  Partials         83       83

Impacted Files
Coverage Δ
Complexity Δ

...ross/network/rpc/handler/ConnectionURIHandler.java
54.58% <100.00%> (+0.63%)
27.00 <0.00> (+2.00)


Add textarea support

Attemps to do the exact same thing as #330, but in a way I find is a lot more reliable and way less overengineered.

Supports pressing Shift+Enter to add a new line
Doesn't break history
Automatically grows
Handles multiline on the server-side (doing it on the client works, but doing it on the server makes it bulletproof for when we add plugins and other things. Otherwise extra lines are passed raw, and while it's okay because we have /quote someone might disable those and turn it into a flaw)
Keeps scroll position in chat
Doesn't grow for a single line, keeping the current behavior (which I find less distracting when typing long messages)
Better positionning of the textarea

Slight note: I'm wondering if when sending multiline messages, we should automatically assume it's a multiline message and not attempt to parse commands at all. Thoughts?

Just tested, this is nice! :+1:
Also nice use of flexbox.

EDIT: Would it be possible to keep nick/send buttons at the bottom when the textarea grows?

Sure, done. Also fixed themes, I had forgotten about them >.>

Slight note: I'm wondering if when sending multiline messages, we should automatically assume it's a multiline message and not attempt to parse commands at all. Thoughts?

I'd vote for parsing each line for commands still. I do an awful lot of multiline stuff on desktop with commands.

I'd vote for parsing each line for commands still.

That's my opinion too. If we were to somehow parse commands differently and support multiline arguments, we would only introduce odd bugs. The current solution is fine.

FYI, I'm planning to review this ASAP :-)

@astorije You still wanting to be second reviewer? Not trying to rush you, just would like it in reasonably soon :-) if you aren't bothered, I could probably take the second review in the next few days. But I don't want to steal it from you if you are planning to do it at the weekend or whatever.

@YaManicKill, feel free to review if you want, but I really would like to give it a stab whenever I get the chance to :-) I'm hoping end of this week or early next week.

Nice! Noticed two things right off the bat;

Scrollbar visible on mobile (standalone Chrome)
Sizing is a bit off on desktop

So, I finally got to play a little bit with this. I also checked out #330 and ran it on the side to test when behavior seemed off or simply by curiosity of how differently it would act.
I noticed the following things that bugged me when I tested this PR:

Text expands to the right as you type instead of triggering a new line. While this is consistent with what we currently have, it has been driving me nuts since my very first day on Shout :-)
Now that we switch to a multiline textarea, we should not do this anymore. #330 goes to the next line when reaching the right end, actually.

Scrolling using the touchpad doesn't doesn't work, it tries to scroll the entire window (at least on Mac OS X, latest Chrome). It works OK on #330.

I haven't tested with other themes, but on default theme text lines are too condensed. We should have same or similar spacing between 2 lines in the textarea than between 2 lines (of the same message) in the chat window. It's subtle, but it's noticeable, and I'm thinking it might also be tricky on mobile.

Nick stays at the bottom of the textarea when it grows. On #330, it stays at the top, which I prefer, but it's no big deal, we can improve that later.

On desktop (haven't tested on mobile), one must type 14 lines before a scrollbar appears. I think that's too much. 5 or 8 maybe (6.5 on #330)? Also (but I'm nitpicking), max height should display entire lines and not half ones.

That's a lot of comments for a first test, but clearly the most annoying points are the first two and I'd be happy to give a +1 when these 2 are fixed. All others can be addressed in later PR(s).
I noticed the first 2 points behave OK on #330, but note that I'm talking about behavior and UX only. I haven't looked at the code of neither of these PRs yet, it's just from a usage perspective. @maxpoulin64, @YaManicKill, what do you think, are these first 2 points easy to fix here or should we go back to #330 instead? I really know nothing of the benefits of one over the other aside from the points listed here.
Thanks for this, @maxpoulin64 (and @YaManicKill), I can't wait to have this in, it's gonna be a great enhancement!!

Text expands to the right as you type instead of triggering a new line. While this is consistent with what we currently have, it has been driving me nuts since my very first day on Shout :-)
Now that we switch to a multiline textarea, we should not do this anymore. #330 goes to the next line when reaching the right end, actually.

Yes, this have been done on purpose. I prefer this behavior myself as it's more consistent with what every other IRC client do, and it reduces the impression that the user can type in as much as they want. I can change it if you prefer, it's just a CSS property (which I can put it back the way I like in custom CSS afterwards).
I originally changed it that way because multiline text on mobile just feels odd and takes most of the remaining screen estate. So I opted for the compact way.

Scrolling using the touchpad doesn't doesn't work, it tries to scroll the entire window (at least on Mac OS X, latest Chrome). It works OK on #330.

I have noticed that too, but assumed that was just the way textareas worked. I'll investigate further, as I definitely noticed that on mobile. I just assumed it was because it was horizontal scrolling, haven't tried vertical.

I haven't tested with other themes, but on default theme text lines are too condensed. We should have same or similar spacing between 2 lines in the textarea than between 2 lines (of the same message) in the chat window. It's subtle, but it's noticeable, and I'm thinking it might also be tricky on mobile.

That's the default, but thankfully an easy change line-height: 120%;. Will do.

Nick stays at the bottom of the textarea when it grows. On #330, it stays at the top, which I prefer, but it's no big deal, we can improve that later.

That was requested by @xPaw above, and I agree with him on this one (was previously vertically centered). Not obvious right away on desktop, but it quickly does on mobile because that means the send arrow is right up the keyboard. Having both down is nice for consistency.

On desktop (haven't tested on mobile), one must type 14 lines before a scrollbar appears. I think that's too much. 5 or 8 maybe (6.5 on #330)? Also (but I'm nitpicking), max height should display entire lines and not half ones.

Right now I have it limited to a third of the total screen height, so it's variable. I can limit it to a predefined height, but a set line count is a bit harder as we don't have access to individual lines but only the element's height. It's already pretty tricky to make that bastard size properly ;)

I prefer this behavior myself as it's more consistent with what every other IRC client do, and it reduces the impression that the user can type in as much as they want. I can change it if you prefer, it's just a CSS property (which I can put it back the way I like in custom CSS afterwards).

Oh, yes please! ❤
To be fair, IRC clients are not usually known for their UX/UI, and this was a strong argument in favor of Shout at the time. On the other hand, I don't know any other messaging client supporting auto-expanding text inputs that expand to the right on top of expanding vertically.

Oh, yes please! :heart:
To be fair, IRC clients are not usually known for their UX/UI, and this was a strong argument in favor of Shout at the time. On the other hand, I don't know any other messaging client supporting auto-expanding text inputs that expand to the right on top of expanding vertically.

Agreed

Hi,
as a data point; we use IRC for our team communications, and  we need to be able to send arbitrary amount of messages when we do our stand ups. Actually, this is the only remaining feature to recommend the use of thelounge

@astorije: Just updated. Now always multiline, supports touch scrolling (was a silly bug). Line height has been set to 1.5, should be good enough. Should also fix some sligh alignment issues, I'm now using the flexbox to align the textarea instead of relying on the padding (since scrolling apparently doesn't account for the padding for some reason).

Amazing job, @maxpoulin64! I know a lot of folks will be happy about this :-)
👍 and merging!

🎆 🎉

🎇🎆🎉🎆🎉🎆🎇


Removing invalid enctype and value from file input

Q
A

Is bugfix?
✔

New feature?
❌

Breaks BC?
✔

Fixed issues

Thanks!

What is the function of the hidden input? 🤔


suppress base & loffset deprecation warnings

Supress some more internal warnings in the test suite.

So many warnings silenced; thanks!

Thanks @mathause!


[6.0] [Completion] Don’t generate USRs for local decls

6.0 cherry-pick of #74479

Explanation: Avoids generating USRs for local decls when doing SourceKit code completion, which has previously been a cause of crashes, and is not something we really need anyway.
Scope: Affects SourceKit code completion
Issue: rdar://128294522
Risk: Low
Testing: Added tests to test suite
Reviewer: Alex Hoppen

@swift-ci please test


Adding swagger UI to kubernetes.io

This is to provide up-to-date documentation on kubernetes.io.
Future things to do:

Write a script to automate the process of copying swagger-spec.
UI improvements: Remove the "Try it out!" buttons, swagger search bar at the top.

This is how it looks right now:

@vmarmol: Is there a way to start a demo server and test this?
@bgrant0607

You can test with a simple file webserver:
package main

import (
	"log"
	"net/http"
)

func main() {
	// Simple static webserver:
	log.Fatal(http.ListenAndServe(":8080", http.FileServer(http.Dir("."))))
}

This will only serve static content. I think that's enough for this. What's supposed to be the main page for this content btw?

Yes I did that and it worked fine on my local webserver.
I was wondering if we can test it with kubernetes.io code.
third_party/swagger-ui/index.html is the main file.

Not without a Jekyll web server. We may need to get a test setup of that as we push more to the site. We're okay for now IMO. Since these files are disjoint from the main site this is okay to merge.

LGTM, anything else you want to try or are we okay to merge?

Thanks! Good to go from my end.
I will wait for Brian to have a look before merging.

LGTM.
Future improvements:

Document why json files are index.html
Try to figure out a way to display the json from the main branch, such as using github API to retrieve them.

Thanks!
Verified that http://kubernetes.io/third_party/swagger-ui/ renders the Swagger UI as expected!


CDN, outdated and wrong versions.

Just for note.
On the jsDelivr, the latest version available is the 2.2.10.
https://www.jsdelivr.com/?query=semantic-ui
On the CDNJS the version 2.2.13 is pointing to the 2.2.12.

https://cdnjs.cloudflare.com/ajax/libs/semantic-ui/2.2.13/semantic.min.js
https://cdnjs.cloudflare.com/ajax/libs/semantic-ui/2.2.13/semantic.min.css

@jsdelivrbot npm semantic-ui

Looks like semantic doesnt have a default file in package.json. So you must use the full URL<EMAIL_ADDRESS>

@jsdelivrbot npm semantic-ui

Hi @jimaek, I’m not familiar with it, could you please elaborate on this—is it something that we can change to help JSDelivr fetch the latest version every time it’s updated on NPM, or maybe JSDelivr itself will somehow be able to do that in the future? Thank you for your time.

The latest version is already fetched as you can already see here<EMAIL_ADDRESS>jsDelivr pulls everything directly from npm. So once you push a npm update jsDelivr will have the files.
What I was talking about is that your package.json is missing a default file parameter. Without the short links dont work. For example jQuery has it so this URL works fine https://cdn.jsdelivr.net/npm/jquery@3
Check here how to add it.
https://github.com/jsdelivr/jsdelivr#configuring-a-default-file-in-packagejson

I'll do this in next patch

This link is outdated: https://semantic-ui.com/introduction/advanced-usage.html#cdn-releases


Stop providing configuration for deprecated formatting rules

Formatting rules were deprecated in ESLint 8.53.0. As suggested in the linked document, we should probably replace these with their counterparts from @stylistic/eslint-plugin-js(ts).

Consensus among our working group is to migrate to the new stylistic packages in order to get off of deprecated rules. But we have until ESLint v10 to do so since that's when the deprecated rules will be deleted.
Longer term we could look at using one of the formatters in the linked blog post instead. Probably not prettier since it isn't very fast or configurable, but the dprint one looks worth exploring.
We don't anticipate major client impact. If any clients were overriding any of the now deprecated rules, they may need to do a bit of work to uptake this migration. We should inspect a couple client projects to see if that's the case, but it doesn't seem likely.
This is available to work on when someone has bandwidth.

I scanned Skyline for usages of the deprecated rules. The only instances I found were:

two projects configure eol-last: error
one inline disable of function-paren-newline
one inline disable and one project-wide configuration of indent
one project disables lines-between-class-members
one project unnecesarily sets no-trailing-spaces: error
a few inline disables of object-curly-newline
one inline disable of quote-props
one override of spaced-comment

In summary: nothing that should stop us from doing this work but a handful of places that might need to be looked at when uptaking this change if the rule names or configurations change.


Adding Fortran Error Handler

I've just fpm-ified my Fortran error handler and so thought it would be a good time to add it here. I've also created a separate PR over at fortran-lang.org: https://github.com/fortran-lang/fortran-lang.org/pull/356 (is that the way to do it, or should I have just created one PR?)
I also spotted a broken link in the README so have fixed that here.

Can't figure why the build is failing, the error doesn't give much away... Only thing I can think of is that the "name" defined in fpm.toml is feh, whilst I've called it fortran-error-handler here? Also it seems to be not just my package it's failing on.

Can't figure why the build is failing, the error doesn't give much away... Only thing I can think of is that the "name" defined in fpm.toml is feh, whilst I've called it fortran-error-handler here? Also it seems to be not just my package it's failing on.

The copyright keyword is probably missing for the currently implemented checks. See https://github.com/fortran-lang/fpm-registry/issues/24 for a discussion on the required keywords.

The copyright keyword is probably missing for the currently implemented checks. See https://github.com/fortran-lang/fpm-registry/issues/24 for a discussion on the required keywords.

Thanks @awvwgk, adding copyright seems to have done the trick!


chore: add badge

Codecov Report

Merging #68 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #68   +/-   ##
=======================================
  Coverage   77.61%   77.61%
=======================================
  Files          14       14
  Lines         402      402
  Branches       57       57
=======================================
  Hits          312      312
  Misses         86       86
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46e6767...5567c63. Read the comment docs.


new option for tween { adjustDuration }

Adds an option to tween so that when a tween is aborted by a new tween, the new tween's duration is adjusted according to how far the previous tween had progressed. This is like what svelte transitions do when a transition reverses an already running transition. Brief chat discussion about this.

Thanks for the PR. Having thought about this a bit, I can't help but feel that it isn't quite the right solution. It's very likely that the duration for a given tween needs to be adjusted according to the difference between the current and starting value, which is only related to the progress along the previous tween in very specific circumstances. (Those specific circumstances are present with transitions, which is why it more-or-less works there.)
Exactly how that difference affects the duration depends on the effect you're trying to achieve (hence all the stuff about exponents in the original chat) — it's probably futile to try and create a convenience API for that. But I think it would make sense to add a spring method, that you'd use like so...
component.spring('foo', 100, {
  // I'm making this part up, would need to research
  // how to model spring physics. might only need
  // one variable!
  tension: 80,
  friction: 10
});

...and which would result in natural-looking motion. For example you could call that code repeatedly with the same value, and you wouldn't get the stop-start effect associated with easing functions. And the duration would naturally adjust to the difference between the start and end values. What do you think?

spring is awesome. I think it's been smarter than me, but maybe I just saw the light. These should produce identical behavior?
Tell me if I translate correctly (other than tension/friction):
      transitionIn () {
        this.tween(
          'modalStyle',
          { opacity: 1 },
          { duration: 400, easing: cubicOut, adjustDuration: true }
        )
      },
      transitionOut () {
        this.tween(
          'modalStyle',
          { opacity: 0 },
          { duration: 400, easing: cubicOut, adjustDuration: true }
        )
      },

      transitionIn () {
        this.spring('style', { opacity: 1 }, { duration: 400, easing: cubicOut, tension, friction })
      },
      transitionOut () {
        this.spring('style', { opacity: 0 }, { duration: 400, easing: cubicOut, tension, friction })
        )
      },

The idea behind spring physics models is that you don't set a duration or an easing function (because those are just ways to approximate spring physics) — instead you say what characteristics the spring has, and the duration (and velocity at any given moment) are derived from that moment-by-moment.
So it'd be more like this:
transitionIn () {
  this.spring('style', { opacity: 1 }, { tension, friction })
},
transitionOut () {
  this.spring('style', { opacity: 0 }, { tension, friction })
}

I see. That does pose some difficulties. My use case is for transitions in/out that svelte-transitions are currently not able to handle. I think spring would work for the way I have it at the moment, but I would like to make the transitions customizable with options. Wouldn't people expect an easing option rather than tension and friction? Also, is it possible to create the same effects, such as bounce?

It's probably better illustrated with some code — here's something I forked from a CodePen: https://jsfiddle.net/e674dddL/. Notice that it tracks the velocity of the mass, and on each frame calculates the acceleration...
acceleration = (stiffness * distance from target) - (damping * velocity)

...adds that to the current velocity, and adds the velocity to the current values. The result of that is smooth-looking motion. By tweaking the variables (careful not to set the damping too high!) you can get all kinds of different effects that easing functions are basically just trying to replicate. If you want a short duration, set a high stiffness; if you want bounce, set a low damping.
There isn't anywhere for duration and easing to 'go' — they're derived from the physical properties of the spring.
For fun, change the click on line 61 to mousemove. Notice how it doesn't matter that we keep changing the target x, y values (the equivalent of calling component.spring(...) over and over) — it just keeps doing its thing:

lemme know if you get a chance to try out spring(...), and if it meets your needs. Docs here: https://github.com/sveltejs/svelte-extras#springkey-end-options-live-demo

spring() is working very well!


Problem with execution

Thank you for making available such a great parser.
I installed the latest version of mac_apt as per your installation instructions but I am getting errors and can't get any results. I used Python 7 as well as Python 8, updated the construct to version 2.10 and the errors are the same. Please see below:
C:\Users\TinoK>python C:\mac_apt\mac_apt.py -h
Traceback (most recent call last):
File "C:\mac_apt\mac_apt.py", line 23, in
import plugins.helpers.macinfo as macinfo
File "C:\mac_apt\plugins\helpers\macinfo.py", line 11, in
import biplist
ModuleNotFoundError: No module named 'biplist'
Any suggestions please?
Thank you
Tino K.

ModuleNotFoundError: No module named 'biplist'

That means the biplist dependency was not installed. If you ran all the steps mentioned in the wiki, you should have had this installed.
With multiple versions of python installed, it is likely that you have the dependency installed for one version and you are invoking another one.Make sure you are running the correct version of python.

I run Windows as you suggested and it worked. Thank you again for taking the time to reply and for the great tool you created. Tino K.


Docker deploy compose external network doesn't work

When I docker deploy a compose file containing:
networks:
    webrouter_webtier:
        external: true

When I add it to a service under networks:, after inspecting the service it is never added to the service

Steps to reproduce the issue:
Explained above
Describe the results you received:
No webrouter_webtier on the service
Describe the results you expected:
webrouter_webtier on the service
Additional information you deem important (e.g. issue happens only occasionally):
Always happens, and I can see where and why it is happening in the code. I might create a PR if I have time.
Output of docker version:
Client:
 Version:      1.13.0-rc1
 API version:  1.25
 Go version:   go1.7.3
 Git commit:   75fd88b
 Built:        Fri Nov 11 19:47:07 2016
 OS/Arch:      linux/amd64

Server:
 Version:             1.13.0-rc1
 API version:         1.25
 Minimum API version: 1.12
 Go version:          go1.7.3
 Git commit:          75fd88b
 Built:               Fri Nov 11 19:47:07 2016
 OS/Arch:             linux/amd64
 Experimental:        true

Output of docker info:
Containers: 130
 Running: 4
 Paused: 0
 Stopped: 126
Images: 296
Server Version: 1.13.0-rc1
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 914
 Dirperm1 Supported: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge host macvlan null overlay
Swarm: active
 NodeID: 8agsrahzgub7m48dr66508iuv
 Is Manager: true
 ClusterID: 9l3fu4qrystn2d4h5dgly9uhc
 Managers: 1
 Nodes: 1
 Orchestration:
  Task History Retention Limit: 5
 Raft:
  Snapshot Interval: 10000
  Number of Old Snapshots to Retain: 0
  Heartbeat Tick: 1
  Election Tick: 3
 Dispatcher:
  Heartbeat Period: 5 seconds
 CA Configuration:
  Expiry Duration: 3 months
 Node Address: <IP_ADDRESS>
 Manager Addresses:
  <IP_ADDRESS>:2377
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version: 8517738ba4b82aff5662c97ca4627e7e4d03b531
runc version: ac031b5bf1cc92239461125f4c1ffb760522bbf2
init version: N/A (expected: v0.13.0)
Security Options:
 apparmor
 seccomp
  Profile: default
Kernel Version: 4.4.0-45-generic
Operating System: Ubuntu 16.04 LTS
OSType: linux
Architecture: x86_64
CPUs: 4
Total Memory: 15.56 GiB
Name: docker-x86-1
ID: NKCQ:BOL4:6JUP:BUHD:LU46:KLAQ:FDKZ:VP7I:U5FN:VYDI:OS2J:SP3K
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
WARNING: No swap limit support
Labels:
 provider=generic
Experimental: true
Insecure Registries:
 <IP_ADDRESS>/8
Live Restore Enabled: false

Additional environment details (AWS, VirtualBox, physical, etc.):
Physical box running Ubuntu 16.04

This is even worse than that actually. Created a compose-file (https://github.com/vdemeester/break-all-the-thing/blob/master/compose-on-swarm/simple-network.yml) where I have 2 networks defined and 3 services. Each services are supposed to be on either one or the other but not on the default one.
But when doing docker deploy --compose-file simple-network.yml ohnoes, all containers are on the default network (i.e. ohnoes_default) and none are on the other network as defined in the compose file (ohnoes_baz and ohnoes_bat have no containers).
I'll take a look.


Org feature

Adds organization feature to datatools.

Codecov Report

Merging #44 into dev will increase coverage by 0.01%.
The diff coverage is 0%.

@@           Coverage Diff            @@
##             dev     #44      +/-   ##
========================================
+ Coverage   0.02%   0.03%   +0.01%
========================================
  Files        278     285       +7
  Lines       8244   10851    +2607
  Branches       0    3313    +3313
========================================
+ Hits           2       4       +2
- Misses      8242   10847    +2605

Impacted Files
Coverage Δ

src/main/client/common/components/Sidebar.js
0% <ø> (ø)
:white_check_mark:

src/main/client/common/user/UserSubscriptions.js
0% <ø> (ø)
:white_check_mark:

src/main/client/manager/actions/user.js
0% <ø> (ø)
:white_check_mark:

src/main/client/common/util/util.js
0% <ø> (ø)
:white_check_mark:

src/main/client/admin/actions/admin.js
0% <ø> (ø)
:white_check_mark:

src/main/client/common/containers/App.js
0% <ø> (ø)
:white_check_mark:

...c/main/client/manager/components/RecentActivity.js
0% <ø> (ø)

...main/client/manager/components/FeedSourceViewer.js
0% <ø> (ø)
:white_check_mark:

src/main/client/signs/components/SignsViewer.js
0% <ø> (ø)
:white_check_mark:

src/main/client/admin/reducers/index.js
0% <ø> (ø)
:white_check_mark:

... and 270 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05d746e...d32a0f2. Read the comment docs.


⚠ Bofrost.de has degraded performance

In f8b08ce, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1311 ms

Resolved: Bofrost.de performance has improved in 87c975c after 13 minutes.


Add trace field to CONNECT

Currently, debugging gnatsd in production can prove extremely difficult.
Debug mode doesn't provide a lot of information, and tracing provides a
flood of information while significantly impacting performance. I'd like to
propose a way to provide per-publisher tracing. This is a rough first pass
at that by simply adding a trace field to the CONNECT message.
This allows clients to enable tracing for themselves within gnatsd. This
likely needs some kind of authorization support since we probably don't
want to allow any client to enable this.
Per-publisher tracing makes it much easier to debug issues in an ad hoc
fashion without significantly impacting performance like enabling full
tracing does.

I'm not exactly sure why the CI tests are hitting a nil pointer error...

Good catch! There is a defect caused by a recent addition to check if the pending buffer max size is reached during a reconnect. The problem is that the test relies on status == RECONNECTING, but it is possible that the pending buffer is not yet created. Will create an issue for that. Thanks!

Created issue https://github.com/nats-io/nats/issues/136. Thanks!

This is a great feature!  One issue to consider is that a client can potentially affect overall performance of the server (beyond typical client load).  I'm wondering if the responsibility should lie with an administrator, possibly enabling this tracing elsewhere, or only allowing it if the server is already setup to trace (debug, -D, not necessarily versus raw -V or -DV)...  Any thoughts?

I agree, we probably want a way to guard against potential performance degradation. I.e. you could in theory "DDoS" attack by making a bunch of connections with tracing enabled. I'm not entirely sure what the best way to manage that is (maybe through some kind of configurable authorization mechanism?), though I know there is a ton of value in being able to enable tracing on the fly for clients which are experiencing issues.

In general I like the idea, in theory. But without proper authorization, concerns me at the moment.
Could you for the time being simply start a new server and cluster it to the prod cluster and point the client just to the new server? That way you only have one server for the client doing tracing, so should not affect performance for the others.

Starting a new server is probably feasible, but I think long term there needs to be a way to debug issues ad hoc without requiring infrastructure effort.

I agree, but I think we need some more ground work on authorization beforehand.

I think we have this as a formal issue, let's push til we have proper auth.


Does this project have a logo?

Ruff and Rye each has its own logo. What about uv?

We do have a logo but I don't know if we've published the asset anywhere.

What's the use-case? I've added an svg icon in some work-in-progress.

I'm just wondering about the use-case so we know what kind of asset to provide :)


Issue 67

Fixed issue 67. My only concern is I've hardcoded "UUID" into the function. Let me know if this needs rectifying.

@dominicmeddick I think this can be closed now. The project/structure has changed since this PR

This is a change on the old structure, so closing it down.


Visual Studio 2022 Version 17.4.0 Preview 2.1. Where is all c++ android samples? Where is android native activity templates?

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 18740be5-c9f7-69aa-a5cb-505f562298b9
Version Independent ID: 32400d1a-db89-c42e-d9a1-b02a33392e31
Content: Cross-platform mobile development examples
Content Source: docs/cross-platform/cross-platform-mobile-development-examples.md
Product: visual-cpp
Technology: cpp-tools
GitHub Login: @corob-msft
Microsoft Alias: corob

The links to the Android samples are broken is the issue. Moved this issue to an internal work item tracking system because we are moving away from using GitHub issues to track C++ doc work.


quilt setup does not work with tetra generated spec files

Using quilt for adding patches is very popular in SUSE.
But tetra generated spec files do not setup correctly:
spark$> quilt setup -v spark.spec
[...]
+ cp -Rf /usr/share/tetra ../kit
cp: cannot stat '/usr/share/tetra': No such file or directory
error: Bad exit status from /var/tmp/rpm-tmp.zhjw9f (%prep)

I wonder if a "copy" is really needed. Maybe a symlink would be enough?
 - cp -Rf /usr/share/tetra ../kit
 + ln -sf /usr/share/tetra ../kit

This would work with quilt.

Copy is really needed for some Maven projects that require writing to the kit/m2 directory. I could not find out how to set permissions or other tricks in order to have them editable otherwise (from the kit package), but I admit this is a hack.
Unless someone comes up with a different idea I guess cp is a safe default behavior, and of course quilt users with non-problematic pomfiles can always use ln instead.


max and min disruptive marco in <windows.h>

For portability, simdjson includes <windows.h> in jsonparser.h. However, it is super disruptive when user want to use std::min or std::max.
The solution is to use NOMINMAX macro to suppress min and max macro definitions in <windows.h>.
Since simdjson does not rely on these min and max macros at all. I think it is a good idea to define NOMINMAX by default.

Can you issue a PR?

Note: we may not beed windows.h anymore!

If it is not required, the best way to deal with it is to remove it directly. Anyway, I can do a PR introducing the NOMINMAX macro.

Thanks.

The header was removed without harm. I think we agree that it is the best solution. Closing.


Doesn't work on mobile view

Love this library btw... makes life easy.. but it doesn't seem to work on mobile view and that's where I need it the most

Hi @binadiegha, thanks! Can you provide a link to something like Codepen / Codesandbox with a minimal reproducible example? Without it I can’t help you I'm afraid.
It definitely works on mobile view, see https://hamburger-react.netlify.app on a mobile device as an example.