Mitmproxy crashes, when setting only value in cookies/set-cookies grideditor

Steps to reproduce the problem:

Run mitmproxy.

Press n -> enter -> enter -> e -> cookies (or set-cookies)

You are in grideditor. Press a. Choose Value column and add any value.
You will see something like:

Press q -> e -> cookies (or set-cookies if you're doing that for it)

Traceback:
Traceback (most recent call last):
  File "/home/kajoj/Mitmproxy/mitmproxy/mitmproxy/tools/console/master.py", line 216, in run
    self.loop.run()
  File "/home/kajoj/Mitmproxy/mitmproxy/venv/lib/python3.5/site-packages/urwid/main_loop.py", line 278, in run
    self._run()
  File "/home/kajoj/Mitmproxy/mitmproxy/venv/lib/python3.5/site-packages/urwid/main_loop.py", line 376, in _run
    self.event_loop.run()
  File "/home/kajoj/Mitmproxy/mitmproxy/venv/lib/python3.5/site-packages/urwid/main_loop.py", line 682, in run
    self._loop()
  File "/home/kajoj/Mitmproxy/mitmproxy/venv/lib/python3.5/site-packages/urwid/main_loop.py", line 710, in _loop
    self._entering_idle()
  File "/home/kajoj/Mitmproxy/mitmproxy/venv/lib/python3.5/site-packages/urwid/main_loop.py", line 671, in _entering_idle
    callback()
  File "/home/kajoj/Mitmproxy/mitmproxy/venv/lib/python3.5/site-packages/urwid/main_loop.py", line 564, in entering_idle
    self.draw_screen()
  File "/home/kajoj/Mitmproxy/mitmproxy/venv/lib/python3.5/site-packages/urwid/main_loop.py", line 578, in draw_screen
    canvas = self._topmost_widget.render(self.screen_size, focus=True)
  File "/home/kajoj/Mitmproxy/mitmproxy/venv/lib/python3.5/site-packages/urwid/widget.py", line 141, in cached_render
    canv = fn(self, size, focus=focus)
  File "/home/kajoj/Mitmproxy/mitmproxy/venv/lib/python3.5/site-packages/urwid/container.py", line 1083, in render
    focus and self.focus_part == 'body')
  File "/home/kajoj/Mitmproxy/mitmproxy/venv/lib/python3.5/site-packages/urwid/widget.py", line 141, in cached_render
    canv = fn(self, size, focus=focus)
  File "/home/kajoj/Mitmproxy/mitmproxy/venv/lib/python3.5/site-packages/urwid/decoration.py", line 225, in render
    canv = self._original_widget.render(size, focus=focus)
  File "/home/kajoj/Mitmproxy/mitmproxy/venv/lib/python3.5/site-packages/urwid/widget.py", line 141, in cached_render
    canv = fn(self, size, focus=focus)
  File "/home/kajoj/Mitmproxy/mitmproxy/venv/lib/python3.5/site-packages/urwid/container.py", line 1083, in render
    focus and self.focus_part == 'body')
  File "/home/kajoj/Mitmproxy/mitmproxy/venv/lib/python3.5/site-packages/urwid/widget.py", line 141, in cached_render
    canv = fn(self, size, focus=focus)
  File "/home/kajoj/Mitmproxy/mitmproxy/venv/lib/python3.5/site-packages/urwid/widget.py", line 1750, in render
    canv = get_delegate(self).render(size, focus=focus)
  File "/home/kajoj/Mitmproxy/mitmproxy/venv/lib/python3.5/site-packages/urwid/widget.py", line 141, in cached_render
    canv = fn(self, size, focus=focus)
  File "/home/kajoj/Mitmproxy/mitmproxy/venv/lib/python3.5/site-packages/urwid/widget.py", line 1750, in render
    canv = get_delegate(self).render(size, focus=focus)
  File "/home/kajoj/Mitmproxy/mitmproxy/venv/lib/python3.5/site-packages/urwid/widget.py", line 141, in cached_render
    canv = fn(self, size, focus=focus)
  File "/home/kajoj/Mitmproxy/mitmproxy/venv/lib/python3.5/site-packages/urwid/container.py", line 1083, in render
    focus and self.focus_part == 'body')
  File "/home/kajoj/Mitmproxy/mitmproxy/venv/lib/python3.5/site-packages/urwid/widget.py", line 141, in cached_render
    canv = fn(self, size, focus=focus)
  File "/home/kajoj/Mitmproxy/mitmproxy/venv/lib/python3.5/site-packages/urwid/listbox.py", line 455, in render
    (maxcol, maxrow), focus=focus)
  File "/home/kajoj/Mitmproxy/mitmproxy/venv/lib/python3.5/site-packages/urwid/listbox.py", line 337, in calculate_visible
    self._set_focus_complete( (maxcol, maxrow), focus )
  File "/home/kajoj/Mitmproxy/mitmproxy/venv/lib/python3.5/site-packages/urwid/listbox.py", line 702, in _set_focus_complete
    (maxcol,maxrow), focus)
  File "/home/kajoj/Mitmproxy/mitmproxy/venv/lib/python3.5/site-packages/urwid/listbox.py", line 672, in _set_focus_first_selectable
    (maxcol, maxrow), focus=focus)
  File "/home/kajoj/Mitmproxy/mitmproxy/venv/lib/python3.5/site-packages/urwid/listbox.py", line 340, in calculate_visible
    focus_widget, focus_pos = self.body.get_focus()
  File "/home/kajoj/Mitmproxy/mitmproxy/mitmproxy/tools/console/grideditor/base.py", line 227, in get_focus
    self.lst[self.focus]
  File "/home/kajoj/Mitmproxy/mitmproxy/mitmproxy/tools/console/grideditor/base.py", line 83, in __init__
    w = self.editor.columns[i].Display(v)
  File "/home/kajoj/Mitmproxy/mitmproxy/mitmproxy/tools/console/grideditor/col_text.py", line 18, in Display
    return TDisplay(data, self.encoding_args)
  File "/home/kajoj/Mitmproxy/mitmproxy/mitmproxy/tools/console/grideditor/col_text.py", line 31, in __init__
    super().__init__(data.encode(*self.encoding_args))
AttributeError: 'NoneType' object has no attribute 'encode'

You can also reproduce it for set-cookies attributes. Just add value without name into set-cookies attributes. Press q -> q to get into flowview tab. Press e -> set-cookies. You will see the same traceback.
Any other comments? What have you tried so far?
This issue is relevant for 2.0.x as well.
System information
Mitmproxy: 3.0.0.dev75 (commit 02d2ef7)
Python:    3.5.2
OpenSSL:   OpenSSL 1.1.0g  2 Nov 2017
Platform:  Linux-4.4.0-112-generic-x86_64-with-Ubuntu-16.04-xenial

@kajojify Hi, are you working on this? :)

@kira0204 hi! I am not working on it. Take it, if you want :)

Update: the root cause of this is because the list that is maintaining cookies is initially like ['','value'] but is getting updated to ['value',None], I still don't know what is causing this but will revert soon.


Add Dongluo to the MAINTAINERS file

Signed-off-by: Victor Vieux<EMAIL_ADDRESS>

Hmmm I'm not sure... kidding!
LGTM :tada: :ghost:

LGTM. Thanks Victor!

Yay!
LGTM

LGTM to me.  Ignore nor the docs build break (thanks for checking @vieux :-D)


TypeScript definition file support in VS?

This blog post from nearly a year and a half ago says better support for adding definition files from within Visual Studio is "coming soon".
Are there any current plans to add a better way to get definition files into Visual Studio? I don't want to use NPM from the command line- that's the entire reason I'm using an IDE in the first place.
What I'd like to see is a browser with previews, version numbers, and autocomplete.
(I know about Mads' "Package Installer" tool- it provides two deprecated ways of getting definition files and is sorely out of date)
Thanks.

The "coming soon" refers mainly to being able to resolve to @types-scoped packages, which is the primary way we expect users to consume declaration file packages, and Visual Studio does have that.
Currently we have a quick-fix for acquiring .d.ts files when noImplicitAny is on, but I don't know if that entirely meets your needs.
Out of curiosity, how do you currently get packages for regular JS dependencies? In other words, how do you go about getting the .js files you need?


MongoDB support

Support for mongodb

FYI @udith-shalinda
Adding unit tests and doing refactor for client app as well

This is still not ready yet.
Relased for testing in showcase<EMAIL_ADDRESS>

Package itself is great. I will need to revert the codebase from example and figure out better pattern for linking datasources

In findBy part in MongoDBDataProvider's should be
}else{       dbResult=await this.db.collection(this.tableName).find(filter).toArray();     }

@udith-shalinda THank you - I have noticed that when testing as well

@craicoverflow Awesome review. II will keep it as PR for the moment as it definitely needs more testing before landing. In the mean time I will use released version in showcase

I have added more advanced refactor. What is outsstanding is to generate models file like:

export const models = [{
    name: 'Task',
    pubSub: {
        publishCreate: false,
        publishUpdate: false,
        publishDelete: false
    }
}];

This will allow us to get all the codegen based config and dynamically assign all datasources.
#751 will also bring Restfull datasource that for simplicity might be embedded into core

@craicoverflow ready for review. I created follow up issues.
I will also create release of the entire graphback (dev release) from this branch to test things with showcase

Releasead as https://github.com/aerogear/graphback/releases/tag/0.11.0-dev2


Branch Protection Settings

Description
Hello. In the repository, click Settings to enter the branch permission settings. When the disable push feature of the main branch protection is enabled. Developers can still push the source code by switching to the main branch through the git tool. This disabling push function does not work, what is the reason for this?
Gitea Version
1.17.1
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
No response
Git Version
git version 2.24.0.windows.2
Operating System
Windows 11 Home Chinese Edition  21H2
How are you running Gitea?
I ran gitea through docker-compos, I chose the SQLite3 database, and the script file to run is as follows:
version: "3"
networks:
gitea:
external: false
services:
server:
image: gitea/gitea:1.17.1
container_name: gitea
environment:
- USER_UID=1000
- USER_GID=1000
restart: always
networks:
- gitea
volumes:
- ./gitea:/data
- /etc/timezone:/etc/timezone:ro
- /etc/localtime:/etc/localtime:ro
ports:
- "3000:3000"
- "222:22"
Database
SQLite

Can you reproduce this on https://try.gitea.io ?
Did you save the protection settings?

Hi, I saved it successfully. Ok, I'll test it on https://try.gitea.io/ to see if I can reproduce it?

When testing on try, I still received remote: Gitea: Not allowed to push to protected branch main
I'm going to close this ticket, but feel free to re-open if you are able to reproduce.
Otherwise, feel free to stop by the forum, discord, matrix, etc if you have other questions. 🙂


Feature Request: rclone size human readable option

Hello, I'd like to suggest an option to show sizes in the same way the command df from GNU/Linux works. Example:
The ugly way (how rclone size works currently):
$ df
Filesystem         1K-blocks     Used     Available Use% Mounted on
dev                  1963932        0       1963932   0% /dev
run                  1976584<PHONE_NUMBER>   1% /run
/dev/vda1           20608616 13433204       6299348  69% /
tmpfs                1976584        0       1976584   0% /dev/shm
tmpfs                1976584        0       1976584   0% /sys/fs/cgroup
tmpfs                1976584        0       1976584   0% /tmp
tmpfs                 395316        0        395316   0% /run/user/1001
secret:/<PHONE_NUMBER>776        0<PHONE_NUMBER>776   0% /tmp/google

My suggestion (Something like: rclone size remote:path -h):
$ df -h
Filesystem      Size  Used Avail Use% Mounted on
dev             1.9G     0  1.9G   0% /dev
run             1.9G  380K  1.9G   1% /run
/dev/vda1        20G   13G  6.1G  69% /
tmpfs           1.9G     0  1.9G   0% /dev/shm
tmpfs           1.9G     0  1.9G   0% /sys/fs/cgroup
tmpfs           1.9G     0  1.9G   0% /tmp
tmpfs           387M     0  387M   0% /run/user/1001
secret:/        1.0P     0  1.0P   0% /tmp/google

From df manpage:

-h, --human-readable
print sizes in powers of 1024 (e.g., 1023M)

There are already other issues asking for human readable options for other functions of rclone:
https://github.com/ncw/rclone/issues/165
https://github.com/ncw/rclone/issues/428

The command rclone size does already output in human readable form, eg
Total objects: 578218
Total size: 110.891 GBytes<PHONE_NUMBER>30 Bytes)

Do you mean in other output like rclone ls?

Yes, I forgot to give command examples.

Could we reopen this for ls?


Google Sheets hookup

It'd be sweet if we could use the Google Sheets API to let organizers automatically file their data into a Google Sheet.

Would this be live updates, or "export to google sheets"?

Live updates. I think it should be feasible with the API and people would LOVE it. Might not be easy though.
On Mon, Jan 5, 2015 at 7:38 PM, Stephen Burrows<EMAIL_ADDRESS>wrote:

Would this be live updates, or "export to google sheets"?
Reply to this email directly or view it on GitHub:
https://github.com/littleweaver/django-brambling/issues/274#issuecomment-68822100

My main concern would be that it would be easy to get out of sync... I'm guessing it works something like google forms, where you can easily add new content, but it's not as easy to change old content? Though google forms does have response editing...

Maybe there's a way to arrange it so that rows have unique IDs and we just have to give editors some documentation about the quirks of syncing, whatever we find.
He says, over half a year later.

Looks like the Sheets API does support updating entries: https://developers.google.com/google-apps/spreadsheets/index#updating_a_list_row
Basically any manipulation you could do as a person seems possible to do programmatically. It could be tricky and we'd have to include instructions on how not to screw up your spreadsheets.
OTOH we could approach it from the other side and use Google Apps Scripts https://developers.google.com/apps-script/guides/sheets which is basically like writing a plugin for Google Sheets that could pull data from a Dancerfly API and have a custom interface when browsing Google Sheets.
The more I think about this idea, the more I like it, because it saves us from trying to recreate spreadsheet functionalities within Dancerfly. My only real misgivings are A. The time it will take to write either of these functions and B. I'd like to offer it as an option but not lock people into Google Sheets. I kinda want more analysis on how most organizers are managing event data right now. I know YDW uses Google Drive for almost everything, so this would be enormously convenient for us. I wonder what other events are doing.

I think it would be cool to offer as an alternative to CSV exports, but a big +1 to not locking people in.

We had someone request this specifically, mentioning that this can be done with DanceCamps:

Also, is it possible to export the data without logging in via the website? My friend showed me a way to do that in DanceCamps POS. He set up his Google spreadsheet to pull the data from DanceCamps server and populate the spreadsheet.

I'm not sure how complex that set up would be and if pushing to Google Sheets is built into DanceCamps or if the friend was pulling via an API or something.

In terms of things that are big new features, this might be my personal #1 priority.


Use std::string_view as RowContainer's reference structure for complex types.

This PR replaces StringView with std::string_view as RowContainer's data structure to represent complex type data.
RowContainer uses StringView as the data structure to represent the reference to variable width data types: VARCHAR and complex types like ARRAY, MAP AND ROW. While it makes sense for VARCHAR, it does not fit so well with complex types:

It might lead to confusion as StringView suggest a value of type VARCHAR, while for complex types, all they need to store is a pointer to data and size.
The benefits of StringView do not apply to complex types:

StringView has 4-byte prefix for fast failing of comparison, which is not used for complex types.
StringView stores data inline for data with size <= 12 , but complex-typed data is bigger than this.

Construction of StringView involves copying first 4 bytes to prefix, which is a waste for complex types.

@usurai Turns out this change is incorrect. Neither StringView not std::string_view can be used as fixed-width complex value in the 'row'. Both StringView and std::string_view imply that the buffer pointed to is a contiguous buffer, but in this case the buffer may or may not be contiguous.
Also, the implementation of typeKindSize assumes that complex types use StringView and it happens to work with std::string_view only because sizeof(std::string_view) happens to be same as sizeof(StringView), i.e. 16.
To avoid confusion and prevent bugs caused by it, we may want to introduce a different type to represent a size + pointer to possibly multi-part buffer backed by HashStringAllocator.
CC: @oerling @xiaoxmeng @Yuhta

@mbasmanova My understand was: StringView/string_view in the context of RowContainer only act as a reference to the first block of the potential multi-part buffer. With them pointing to the first block, it's RowContainer / HashStringAllocator's responsibility to handle non-contiguous parts.

To avoid confusion and prevent bugs caused by it

Could you suggest potential bugs caused by this? It would be helpful when considering the design of the new type for referencing the potential multi-part buffer. Thanks!

@mbasmanova Some update:

Both StringView and std::string_view imply that the buffer pointed to is a contiguous buffer, but in this case the buffer may or may not be contiguous.

Seems the buffer is always contiguous because:

AllocationPool which is backing HashStringAllocator only does contiguous allocation.
If ByteStream is backed by HashStringAllocator, it only uses the first run of the allocation.

AllocationPool only does contiguous allocation
As we know non-inline varchar/complex type values are stored by HashStringAllocator which allocates memory either directly from memory pool(>= 3KB) or from AllocationPool.
In case of AllocationPool:

If it has already allocated >= 256KB or the allocation request memory size > max size class, calls allocateContiguous.
Otherwise, calls allocateNonContiguous, but specifies minSizeClass to equal to numPages, that is, asking for a contiguous memory:
https://github.com/facebookincubator/velox/blob/6775fd95ce9188d50269e334409a1d811949d067/velox/common/memory/AllocationPool.cpp#L135-L136

HashStringAllocator backing ByteStream only uses the first run of the allocation
ByteStream::extend is used when there is no enough space in current ByteRange for the appended data. Within ByteStream::extend, it calls StreamArena::newRange for more memory. Only the base class StreamArena uses next run, HashStringAllocator directly allocate new memory.
Given this, I think it's fine to just use StringView/string_view as the reference type? If so

the implementation of typeKindSize assumes that complex types use StringView and it happens to work with std::string_view only because sizeof(std::string_view) happens to be same as sizeof(StringView), i.e. 16.

I can fix this by updating kindToFlatVector implementation of complex types.

@usurai

the buffer is always contiguous because

This is not the case. Check out TEST_F(HashStringAllocatorTest, multipart) in velox/common/memory/HashStringAllocator.cpp

@mbasmanova Oh I see. I messed up..
Yes, though each call to allocateNonContiguous returns allocation with only 1 run, when extend, it gets a new chunk of memory, which makes it non-contiguous.
Thanks for pointing me to the test!
Ok, back to the topic. We want to introduce a new type

with size + pointer as data
with StringView's inline functionality
with a name that indicates it's multi-part characteristic.
Right?


Update run/shell usage in README

Resolves #15

Will merge when I'm around my computer, thanks again! :)


Provide instructions for uninstallation

Can't speak for the author but here's what I did:
Remove the repository folder:
 rm ~/.zsh-autosuggestions -rf

Remove the lines appended to the end of .zshrc by the install script (by hand):
# Setup zsh-autosuggestions
source /home/you/.zsh-autosuggestions/autosuggestions.zsh

# Enable autosuggestions automatically
zle-line-init() {
    zle autosuggest-start
}

zle -N zle-line-init

# use ctrl+t to toggle autosuggestions(hopefully this wont be needed as
# zsh-autosuggestions is designed to be unobtrusive)
bindkey '^T' autosuggest-toggle

Thanks @baykovr for responding. I also did the same, forgot to remove the directory though.

Does someone want to add this to the readme ?

I’ve described uninstallation in the readme here.


POST route don't get registed

When in my routes file I try:
Route::post('something', 'someController@method');
That route isn't registered! (however i can register Route::get.... etc)
But if I do:
Route::any('something', 'someController@method');
I get GET|HEAD|POST|PUT|PATCH|DELETE and the POST work!
And to register a Post only route i need to make this way:
Route::match(['post'],'something', 'someController@method');
Beside "out-of-the-box" Laravel install I add the following repositories to my composer.json:
"barryvdh/laravel-ide-helper": "~2.0",
"laravelcollective/html": "~5.0",
"doctrine/dbal": "~2.3",
"bican/roles": "1.5.*"
I'm new to Laravel and this is probably my fault... but i can't find where!

How do you know the POST route doesn't register?
Try php artisan route:clear if you ran php artisan route:cache.
And also check what you get in php artisan route:list which shows all the routes.
Maybe the route is correctly being created but you're calling it wrong (?)

Sorry if it sounds rude but doesn't this kind of questions belong to StackOverflow?

@phanan Yes, this is not an issue, please ask these types of question on the forum.


Find a way to avoid using exceptions and return nullptr gracefully

We should catch all exceptions in C interface


OAf Celery settings do not allow CELERY_BROKER_URL to be different from CELERY_RESULT_BACKEND

Product versie / Product version
latest / 44eb847
Omschrijf het probleem / Describe the bug
When implementing the generic base settings in Open API Framework, I took the Celery settings from Open Zaak. There only the value of the envvar CELERY_RESULT_BACKEND is used for the  CELERY_BROKER_URL and CELERY_RESULT_BACKEND settings.
However, in Objects API and Open Notificaties, there were separate envvars for this:

https://github.com/maykinmedia/objects-api/blob/b2e586e4363ee59cb284e7cf4c07a25da95930e5/src/objects/conf/base.py#L496-L500
https://github.com/open-zaak/open-notificaties/blob/37ad034e4675047db35ba326487b58a03c5fdb9e/src/nrc/conf/includes/base.py#L556-L558

This means that Objects API and Open Notificaties lost the CELERY_BROKER_URL and the possibility to configure these separately
Stappen om te reproduceren / Steps to reproduce
No response
Verwacht gedrag / Expected behavior
I'm not sure if these were ever set to different values in practice, but I think it would be best to modify the settings such that CELERY_BROKER_URL can be specified via its own envvar and if it is not specified to fall back on the value of CELERY_RESULT_BACKEND

Good observation but lets wait until someone in the field reports this as an issue.


Minor issues with the submitted 3.1.1package

Noticed the following minor issues, in case you want to fix them in the future:

Root buildfile mentions tests/ but there aren't any. Not sure if these are planned in the future.

include/buildfile sets bin.lib.version even though this is a header-only library (and which seems unlikely to change).

Hi @boris-kolpackov,
thanks again for the feedback. I fixed the issues in the latest revision.

Was a left-over. I had the tests integrated, but they use std::auto_ptr which is removed from the standard since c++17, so the tests would not build on any recent compiler with cxx.std = latest


If using a kustomize patch, helmfile ignores all templating done with with set:

When a strategicMergePatches: block is added to this helmfile.yaml everything in the set: section is ignored. extraArgs.base-role-arn and the new image repo is missing.
repositories:
  - name: stable
    url: https://charts.helm.sh/stable

releases:
  - name: kube2iam
    chart: stable/kube2iam
    version: {{ requiredEnv "CHART_VERSION" }}
    values:
      - values.yaml
    set:
      - name: aws.region
        value: {{ requiredEnv "REGION" }}
      - name: extraArgs.base-role-arn
        value: "arn:aws:iam::{{ requiredEnv "AWS_ACCOUNT" }}:role/"
      - name: image.repository
        value: "test.com/kube2iam"
    wait: true
    timeout: 1000
    recreatePods: false
    force: false
    installed: true
    atomic: true
    strategicMergePatches:
    - apiVersion: apps/v1
      kind: DaemonSet
      metadata:
        name: kube2iam
      spec:
        updateStrategy:
          type: RollingUpdate
          rollingUpdate:
            maxUnavailable: 3

with no patch, helmfile template outputs:
      containers:
        - name: kube2iam
          image: "617762925086.dkr.ecr.us-east-1.amazonaws.com/mosaic/mosaic/shared-services/kube2iam:0.10.9"
          imagePullPolicy: "IfNotPresent"
          args:
            - --host-interface=eni+
            - --node=$(NODE_NAME)
            - --host-ip=$(HOST_IP)
            - --iptables=true
            - --base-role-arn=arn:aws:iam::test:role/
            - --log-format=json
            - --log-level=info
            - --namespace-restrictions
            - --resolve-duplicate-cache-ips
            - --use-regional-sts-endpoint
            - --app-port=8181
            - --metrics-port=8181
            ````

 with a patch it outputs:

  containers:
  - args:
    - --host-interface=eni+
    - --node=$(NODE_NAME)
    - --host-ip=$(HOST_IP)
    - --iptables=true
    - --log-format=json
    - --log-level=info
    - --namespace-restrictions
    - --resolve-duplicate-cache-ips
    - --use-regional-sts-endpoint
    - --app-port=8181
    - --metrics-port=8181

Could this be the fix? https://github.com/roboll/helmfile/pull/1411

Looks like it is also ignore the values.yaml file as well with the patch in place.

@rdelpret Hey! Sounds like what you reported originally is dup of #1681.
But-

Looks like it is also ignore the values.yaml file as well with the patch in place.

Hmm, this shouldn't really happen. We do pass values to the chartify component that powers kustomize patching here:
https://github.com/roboll/helmfile/blob/59b91a45a0d30009849a7ecc52b96393f0dc5166/pkg/state/helmx.go#L198


[Docs] : Some links not working

Some index links are not working

Quick start guide
Fast integration for stripe users
Supported Features
Faq

Video
https://github.com/juspay/hyperswitch/assets/101205226/70f42b41-4c94-40fb-a538-85ef5ac4dd6c

Hey @parasss19, mind if I work on this issue?

Hey @AkshayaFoiger I want to work on this issue please assign me this


How to handle gaps / sparse data with reference to period being viewed

Should data points be plotted on line (?on rollover) if time between results is greater than certain % of period being viewed? Esp for future sets with less data and infrequent tests (which may be handled differently?)
Partly ties in with https://github.com/HealthForge/hackday-nhs-14may2016/issues/5

I've added points to the graph line to emphasise where the observations are.


Canary

Storybook Hub is building storybooks for every commit in this PR.
Latest Storybook: https://75523586-cd95-42f2-a86b-75027da83774.sbook.io/
( Visit here for more info )

This comment is automatically added by Storybook Hub


Vercel builds fails

I connected this https://github.com/BuidlGuidl/hackathon-se2 to Vercel in the Vercel UI, so it deploys when I push to main.
It fails when I try to deploy (The initial deploy from the cli worked). It gets these errors:

I guess this is happening since #202 and we talked about this before.

I just added the generated hardhat_contract.ts file to the repo (even tho my project won't use any contract). Not the best solution because:

Doesn't make sense when your project doesn't use any contract (a lot of times you build dapps that don't use a custom contract)
If you use a contract, the file will change all the time when you are developing locally (the address of the local contract will change on each deployment).

What solutions do we have?

Found a solution by using some more Typescript magic. :sweat_smile:

ahhh so what is the solution ?lol

ahhh so what is the solution ?lol

I opened a PR for it (see the linked pull request just above my comment) #255

Love your TS magic @sverps <3


Cookbook recipes not being packaged

Trying to install the cookbook recipes is returning an empty directory
conda install -n cset -c conda-forge cset
conda activate cset
cset cookbook
ls recipes/

It appears that the recipes aren't being packaged, the source directory is empty
$ ls ~/miniconda3/envs/cset/lib/python3.12/site-packages/CSET/recipes/
__init__.py  __pycache__

Thanks for noticing. This has already been fixed in https://github.com/MetOffice/CSET/commit/9c6f05d91a928d203ad4c7924a4b34a35c94e69c but has not yet been released. I'll cut a release today, as it has been a while.

CSET v24.2.0 has now been released with this fix, and will soon make its way onto PyPI and conda-forge.

The updated CSET package is now on conda-forge. You should be able to get away with a conda update -c conda-forge cset, though you might need to recreate your environment.


BookStack MetaSearch Browser Extension – Search the web (e.g. Google) & BookStack at once

Boy, here comes an insane one, but it would be so great and helpful...
Describe the benefits this feature would bring to BookStack users
Well, the problem is that I have so much stuff and so many projects going on, that I quickly (after a few months) forget which information in detail I've written down/archived in BookStack. So there is a good chance, that after three quarters of a year or so, I'm confronted with a certain technical issue, a problem, a bit of missing knowledge, which I'd actually sorted out before, but forgot that I took the effort to write it down in BookStack.
So instead of simply looking it up in my BookStack knowledge base, I start from scratch doing a Google search on the web. Chances are that the Google result includes sites still marked in purple which I've previously visited in search for a solution, but still it’s a time consuming process to start from scratch ... and stupid if the answer is already there/here in my BookStack.
Describe the feature you'd like
It would be awesome if there’d be a BookStack browser extension (I'm using the latest Chrome on mac OS Big Sur), which when you do a web search through the browser’s URL bar takes the search string and searches your (previously defined, personal) BookStack account for that string too (so in addition to Google searching the web) and then lists any results found somehow above the Google search results. Get the point?
I mean that’s the big, big problem: Remembering which information you put where.

Hi @Wookbert,
Sorry for the late response on this. I've been meaning to provide at least some guidance on this but never got round to it.
I don't really want to be officially supporting external components such as this myself since it would quickly grow in scope to other browsers and search engines and they'd be moving targets to support, and would result in another significant element to support.
That said, it's all possible to do. I have put together a demo MVP of such extension and added it to our api-scripts repo here:
https://github.com/BookStackApp/api-scripts/tree/main/chrome-extension-google-search-results
This is a very barebones example, I just worked to get a minimal example to the point of functioning. Below is a preview of it in usage.
Since I don't intend to develop this further I'm going to close off this issue but hopefully the fundamental work done in my example can be developed and built upon by yourself and/or others.
Preview


Remove unremovable default hackney pool

This was needed, because my tests were failing due to this new default hackney pool usage that was not removable from outside. https://github.com/mana-ethereum/ethereumex/issues/81
NOTE: we should cut a MINOR release afterwards as this is a breaking change.

@ayrat555 sure, the link I provided above explains it: https://github.com/mana-ethereum/ethereumex/issues/81
The code diff between those links is the reason why I had to disable a pool for my use case. When my eth library test case starts it makes thousands of http requests that go to a pool and they get stuck, even when the testrpc server goes live, making the tests unable to run/hang since they wait for a successful rpc response.

@izelnakri the checkout_timeout comes from your pool being exhausted. which comes from a hackney bug I reported months ago:
https://github.com/benoitc/hackney/issues/643
Are you sure this two things are not releated?

@izelnakri the checkout_timeout comes from your pool being exhausted. which comes from a hackney bug I reported months ago:
benoitc/hackney#643
Are you sure this two things are not releated?

👍 most likely they are related, checking it now. Also we should provide this option to adjust the pool, make the library as flexible as possible so I think this MR should be merged regardless 😉

Absolutely.
Please force hackney from the tip of master and try out your test.

@InoMurko yes It worked. Lets merge this PR and then update httpoison to 1.7.0, not sure if this would fix the hackney issue but we'll see I guess ;)


"labelledBy" prop does not change the placeholder

Hi, I am using react-multi-select-component 4.2.4 and I am facing an issue that when I try to change the placeholder by given prop "labelledBy" it does not change the output. It always shows the default placeholder which is "select...".
When I inspect on browser I saw there is a Select... which always trigger and ignore whatever value I set in prop "labelledBy". I have attached a screenshot as well in which my "aria-labelledBy" value is "select badgeeeee".

I'm also facing the same issue. Let me know once it's fixed.

Duplicate of #429
@usaidsherwani @SherothKar please see below answer
https://github.com/hc-oss/react-multi-select-component/issues/429#issuecomment-885676412

Duplicate of #429
@usaidsherwani @SherothKar please see below answer
#429 (comment)

Oh! thank you so much. It solved the problem :D :D

Thank You! ✌


Correct pull-request-template minor typos

Description
This PR corrects two minor typos in pull_request_template.md which I noticed when I was quoting the text.
I did not open a separate issue for this. I hope that is OK!
In the sentence "Use a meaning full branch name." I changed "meaning full" to "meaningful".
See https://dictionary.cambridge.org/dictionary/english/meaningful.
Whilst I had the file open, I also changed "Github" to "GitHub".
See https://github.com/about.
Steps to reproduce
Read pull_request_template.md

Thanks! :)


Incorrect way of calling global options in the docs

Hello and thanks for the great plugin, I based myself on your great work to do Custom Element as well. I noticed some typo in your docs and github readme.
First, it seems that Github changed their markdown processor and typing #Header 1 is no longer and should be written with a space after the # so it should be # Header 1.  I had to update all of my Github project as well :(
Second, I think that your doc is incorrect in Global Defaults. The : should be replaced by = and the end of each line should be closed accordingly.
For example this:
export function configure(aurelia) {
  aurelia.use
    .standardConfiguration()
    .developmentLogging()
    .plugin('aurelia-bootstrap', config => {
        config.options.accordionCloseOthers: true,
        config.options.accordionGroupPanelClass: 'panel-default',
        ...
    });

should be
export function configure(aurelia) {
  aurelia.use
    .standardConfiguration()
    .developmentLogging()
    .plugin('aurelia-bootstrap', config => {
        config.options.accordionCloseOthers = true;
        config.options.accordionGroupPanelClass = 'panel-default';
        ...
    });

Again, thanks for the great work. I'm also starting a set of 3rd party Bootstrap plugins as Custom Element, you might want to take a look Aurelia-Bootstrap-Plugins. Thanks for helping the community :)

You are right, I will fix the documentation accordingly, thanks.


Week of January 11: Cut buildpack releases

https://github.com/paketo-buildpacks/php/releases/tag/v2.3.0


InterPro update

There was an InterPRo release on  June 18th. Can we update?
https://www.ebi.ac.uk/interpro/release_notes.html
I found this by chance I don't know if there is any alerting ?

I've started downloading the Interpro update.  It currently says it's going to take 25 hours.

I wanted to see if the species-specific GPs has picked up new domains
I think they only have a release very 6 months or so .....so would be good to update... but 25 hours!
didn't we ask before about downloading subsets? I think rob Finn mentioned some new download methods they were thinking about?

The download sped up and we now have a copy of the new XML file.
Unfortunately the XML format has changed slightly.  I need to fix the parser before I can update.
Note to self: 'unknown attribute name: model'
   7: pombase_domain_process::make_match
             at src/main.rs:260
   8: pombase_domain_process::parse
             at src/main.rs:305

hmph...

Some entries in the XML have a new attribute "model".  So we have model="2bwnA02" here:
<match id="G3DSA:3.40.640.10" name="G3DSA:3.40.640.10" dbname="CATHGENE3D"
       status="T" model="2bwnA02" evd="HMMPfam">

and model="0046747" here:
<match id="SSF53383" name="SSF53383" dbname="SSF" status="T"
       model="0046747" evd="HMMPfam">

I'll ignore the new attribute for now just so we can get the new file loaded.  We can add it to the gene pages if it's useful.

OK, I'll find out what it means.

I'll ignore the new attribute for now just so we can get the new file loaded.

I made the code change so the new Interpro data should be visible in the morning.

I made the code change so the new Interpro data should be visible in the morning.

The load worked and the main site is updated with the latest data.  Let me know if you spot any problems.

Great. Found cerevisiae  Lst4 ortholog!

The Attribute model is a red to the domain within a PDB model
https://www.rcsb.org/pdb/explore/macroMoleculeData.do?structureId=2BWN
--
Antonia Lock, PhD
PomBase Biocurator, http://www.pombase.org
Department of Genetics, Evolution and Environment,
The Darwin Building,
University College London
London WC1E 6BT, UK

Thanks for checking.  We have links to the external database entries for domain on the gene page, so maybe it's not useful to display that reference?

I don't think we need to do anything with that.....

From Alex (M)
SUPERFAMILY and Gene3D are a bit different to our other member databases, as
they use a set of different HMMs to represent their entries (there is not a 1
entry to 1 HMM relationship). We have now added a link to the exact HMM that a
sequence hits for these entries, which is what the model attribute represents.
It is only used in SUPERFAMILY and Gene3D matches.

we could add this link but it isn't really urgent


Obtain Flink Views from the Context Output

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[x] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[x] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[x] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[x] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

Coverage decreased (-0.01%) to 69.214% when pulling 27e43b9fdd32616128c8225c82fc2426fe9da15d on tgroh:flink_view_translation into 36ed3f6c54d35ac48241789fd77e2657d54c5831 on apache:master.

R: @aljoscha

Yes, thank you, that does the trick! 😃
I'll put my PR on top of this commit.

Run Flink RunnableOnService

This is probably safe to merge independently, if it LGTYou

LGTM! Will you merge or should I?

Thanks!


Add gecimi lyrics fetcher

Since nuvola can't fetch lyrics of almost all Chinese songs, I add a new lyrics fetcher fetching from gecimi's API.
Not really tested because it's hard to compile. Locally it warns
File /usr/share/vala/vapi/libsoup-2.4.vapi is read-only; trying to patch anyway
patching file libsoup-2.4.vapi (read from /usr/share/vala/vapi/libsoup-2.4.vapi)
Hunk #1 FAILED at 148.
1 out of 1 hunk FAILED -- saving rejects to file libsoup-2.4.vapi.rej
Build failed
 -> task in 'libsoup-2.4.vapi' failed with exit status 1:
        {task<PHONE_NUMBER>11344: libsoup-2.4.vapi libsoup-2.4.vapi,libsoup-2.4.patch -> libsoup-2.4.vapi}
' patch -i /home/xcffl/Development/nuvolaruntime/vapi/libsoup-2.4.patch -o libsoup-2.4.vapi /usr/share/vala/vapi/libsoup-2.4.vapi '

On Circle CI it has Errors during downloading metadata for repository 'updates-modular'...
Well looks like Circle CI just has an outage. I'll test it later.

Well it's impossible to build since vala lint requires vala 0.46, but the what you can get from vala's git repo is v0.48

I think my part should work now. However, I don't have that many resources to clone cef, which is required for building valacef. Besides, circleci appears to have some issue on Diorite. So maybe the maintainer could consider building it and see if it works?

I created an issue to fix CI - tiliado/nuvolaruntime#603

You can use Nuvola CDK.

Wow, that's a perfect use case for flatpak. I did miss docker when I fell into the trap of cef.
But still, it lacks something
Traceback (most recent call last):
  File "/**/nuvola/valacef/valacefgen/cparser.py", line 77, in parse_header
    with open(path) as f:
FileNotFoundError: [Errno 2] No such file or directory: '/app/include/cef/include/capi/cef_audio_handler_capi.h'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "../genvalacef.py", line 125, in <module>
    parser.parse_header(path, c_include_path)
  File "/**/nuvola/valacef/valacefgen/cparser.py", line 85, in parse_header
    raise ParseError(self.context) from e
valacefgen.cparser.ParseError: [('header', '/app/include/cef/include/capi/cef_audio_handler_capi.h', 'capi/cef_audio_handler_capi.h')]

Use valacef branch 75.3770.x.

Wow... so finally I realize that there is another copy of Lyric component in https://github.com/tiliado/nuvolaplayer.git that really takes effect. This copy in nuvolaruntime seems simply redundant (if I'm wrong please tell me). Should I close this PR and send another one under nuvolaplayer?

Ok, I managed to build and test this patch. It works. Although I realize that the API only support relatively old songs. Maybe I'll have to write another for mojim.com

I'm sorry I haven't managed to get to your PR for so long. I hope to look at it tomorrow though. You can add another lyrics fetcher if you wish :-)

Thanks. I'm already using it anyway.

Ok, since you already use your plugin, I'm going to fix CI first and then I'll return to the PR.

CI is fixed. Could you rebase on the master branch and push again? It should run CI again. Thanks :-)

That's great.
Thanks to the recipe, I managed to correct the linting problem. Hopefully Vala could be more supported in the future. For this reason, I added a commit containing config of the recommended uncrustify formatter according to https://github.com/tiliado/valalint/blob/master/.valalint.conf

Since the formatter lacks of the ability to correctly format anonymous functions (https://github.com/uncrustify/uncrustify/issues/2779), I've remove that commit. Maybe you can add a matched formatting config later.

Also, please don't mark comments as resolved. The reviewer does that.

Seems CI fails because of some other reasons?

/root/workdir/nuvolaruntime/src/nuvolakit-runner/components/lyrics/GecimiLyricsFetcher.vala:50.9-50.38:
error: 1 missing arguments for `void Soup.Session.queue_message (owned Soup.Message, Soup.SessionCallback?)'
        session.queue_message(request);
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Compare with:
SourceFunc callback = fetch_lyrics.callback;
session.queue_message(request, () => {
    Idle.add((owned) callback );
});
yield;

Incase  you didn't notice, that error was fixed

Sure. I've been busy these days. I think I'll have some time next week
-------- Original Message --------
On May 31, 2020, 9:11 PM, Jiří Janoušek wrote:

@fenryxo commented on this pull request.

In src/nuvolakit-runner/components/lyrics/GecimiLyricsFetcher.vala:

   /* Get lrc content */

   string lrc_url;

   try {

       lrc_url = get_lrc_url(response);

   } catch (Error e) {

       throw new LyricsError.PARSE_FAILED(@"Failed to handle responses for song $song from Gecimi Lyrics");

   }

   if (lrc_url == "") {

       throw new LyricsError.NOT_FOUND(@"Song $song was not found on Gecimi Lyrics");

   }

   request = new Soup.Message("GET", lrc_url);

   session.queue_message(request, () => {

       Idle.add((owned) callback);

When you are ready, please add a comment to let me know :-)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Merged, thanks :-)


Fix an error caused by trying to cast a pointer to an unsigned long.

Fixes issue #34.

You don't need the stdint include; all its definitions and more are provided by inttypes.

Updated.

Can you collapse your change so that it is just one change to the line, not a change to add cstdint and then remove it?

I have no idea how to do that short of making a new pull request from a new branch.

I think you can google “git merge two commits”. It gets me tips like this one.

Trying to push a squashed commit ends up not working unless I pull in changes from the github version and get the include you don't want right back.  So nevermind this one; it's just a trivial a one-line change anyways and we've both wasted more time on these comments than it would have taken you to change it yourself. Sorry about that.


Better solution of action buttons in statements list

The icons are kinda clumsy and often lose focus, i.e. disappear before users succeed in clicking on them. Needs to be tested under different window zoom sizes etc. and make it as convenient as possible.

This might be a good task for @Ptrhnk if nothing specific on Annotator etc. is at hand - up to @adammertel of course.

Dev note for me: implement with floating UI, the same also could be for context menu in tree


[Storage] Adopt a response hook param for headers

Currently we're returning the response headers directly in some cases and not in others.
We should change the behaviour to never return the response headers - rather have each function take an optional callable that can accept the headers.
This is the approach used by cosmos.

Hi @annatisch, I will close this issue since we GA'd and this is no longer possible :/


Create a chart repo for milvus-operator

At present I can't find a chart repo for the milvus-operator.
Some tools that build on top of Helm don't handle the tgz style of helm targets.
It would be good to have a normal helm repo if possible?

At present I can't find a chart repo for the milvus-operator.
Some tools that build on top of Helm don't handle the tgz style of helm targets.
It would be good to have a normal helm repo if possible?

What do you mean for Chart repo?
Because the files themselves can be found at charts/mulvus-operator, and the README has a link to the domain where the Helm releases are stored.


fixes #1, inconsistent sidebar styles

fixes typo in sidebar class for archives header

HTML had all the headers for the sidebar class as "sidebar-title" except for archives, which was "sidebar_title".  As such, the code is updated so that they all have consistently named classes


Prepare release 0.4.0

Changelog

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 60.917%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1660

Relevant Lines:
2725

💛  - Coveralls

Replaced by #138


docs: add Bandada repository link to the API docs (closes #403)

Description
The idea is to add the Bandada GitHub repository link to the API Docs: https://api.bandada.pse.dev/
I've added it on the top right of the page, just like in the Bandada Dashboard: https://bandada.pse.dev/
Related Issue
#403
Does this introduce a breaking change?

[ ] Yes
[X] No

Other information
Before:

After:

Note: I have only added a customJsStr attribute including the word "Github" and the hyperlink to the repository. Additionally, I've added the GitHub icon (just like in https://bandada.pse.dev/). To render the icon, it was tricky to use React components directly to the DOM using vanilla JavaScript. Therefore, I've create the icon using an inline SVG representation of the GitHub icon ("GitHub Octicons"). For future reference, it should be easier to change font-size, color, or any other attribute since everything is inside customJsStr

I've pushed a new commit based on @vplasencia code -- it should be responsive by now :)
@0xjei I've ran yarn lint && yarn prettier:write and I didn't get any warning coming from the file I've modified, let me know if it looks good on your browser now (hopefully it does!)

Thanks for the contribution! @gitpoap-bot @intldds


Fix typo in JSON config example, in the CLI documetation

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "patch-1" git@github.com:czerasz/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Nice catch, thanks!
LGTM


Get information of all authors for a documentation

🆕🐥 First Timers Only
This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝
👾 Description of the issue
We want to honour all people that contributed to a documentation. By doing so we want to mention all the contributors on the bottom of a page as it can be seen in this mockup:

To do so we need to receive the name, avatar image and the link to the GitHub profile for all contributors of a specific file. Looks like this can be achieved by using the GitHub Rest API as described here. This pull request should add a service (CDI bean) that provides the functionality to get the described information for a specific file.
📋 Step by Step
To solve this issue and contribute a fix you should check the following step-by-step list. A more detailed documentation of the workflow can be found here.

[x] Claim this issue: Comment below.
[ ]  Fork the repository in github by simply clicking the 'fork' button.
[ ]  Check out the forked repository
[ ]  Create a feature branch for the issue. We do not have any naming definition for branches.
[ ]  Commit your changes.
[ ]  Start a Pull Request.
[ ]  Done 👍 Ask in comments for a review :)
[ ]  If the reviewer find some missing peaces or a problem he will start a discussion with you and describe the next steps how the problem can be solved.
[ ]  You did it 🎉 We will merge the fix in the master branch.
[ ]  Thanks, thanks, thanks for being part of this project as an open source contributor ❤

🎉 Contribute to Hacktoberfest
Solve this issue as part of the Hacktoberfest event and get a change to receive cool goodies like a T-Shirt. 🎽
🤔❓ Questions
If you have any questions just ask us directly in this issue by adding a comment. You can join our community chat at Slack. Next to this you can find a general manual about open source contributions here.

The PR https://github.com/adoptium/documentation-services/pull/18 provides the Document class. Once the PR is merged the users can be added as a set to that class.

Please review PR #38

Please review PR #39


proposal: net/http/httptest: add NewRequestWithContext

Recently the net/http package added NewRequestWithContext, which allows callers to pass in a context.Context without a second method call and/or copying the http.Request.
The proposal is to add the same API to httptest, so users don't need to think about it or wonder why httptest does not expose the same API as net/http for creating requests.
Updates #23544.

CC @neild @bradfitz

Seems reasonable to me.

Does this need to go to the proposal committee or should I just submit a CL?

This does need to be approved by the proposal committee, since it's adding a new exported function.
I think this change is reasonable, and support it.

Based on the discussion above, this proposal seems like a likely accept.
— rsc for the proposal review group
The proposal is to add
func NewRequestWithContext(ctx context.Context, method, target string, body io.Reader) *http.Request
that behaves like httptest.NewRequest except it also adds a context.

No change in consensus, so accepted. 🎉
This issue now tracks the work of implementing the proposal.
— rsc for the proposal review group
The proposal is to add
func NewRequestWithContext(ctx context.Context, method, target string, body io.Reader) *http.Request
that behaves like httptest.NewRequest except it also adds a context.

This got implemented by @kevinburke in CL https://go-review.googlesource.com/c/go/+/548355 but it used "Updates #NNN" instead of "Fixes #NNN" so Github didn't auto-close the issue, hence I am closing it right now. Thank you Kevin!


nunuStudio exits after pressing cancel button, lightmap support?

nunuStudio exits after pressing cancel button
Description
1.) When cancelling any of the popup windows (for example textures select and then canceling) the main application nunuStudio exits so that all configurations are deleted.
2.) Is it also possible to use baked lightmap in the material settings? I didn't found there any lightmap option which can be selected. How to do this?
Version
nunuStudio_0.9.5_win_x64
Platform

Windows [X]

Yes I also noticed it (#1) on Linux with the npm version.  (that's also why we need an auto save feature :))

Ok, so this is probably a coding error. And what about the lightmap texture option in the materials. Is there a way to set up the lightmap texture or will this come in future and is still in development?

There are not lighmap generation support inside of nunuStudio.
The back problem is NWJS im trying on windows i am currently running a older nwjs have to check if that version has any problem on linux.
Thanks a lot!

Hi
Thanks a lot for reporting, the problem with the window closing after file dialog cancel has been fixed in the last version of the editor.
Cheers


Consider making OrientationMatrix use the new Geometry Interfaces

This is now in Chrome Canary, so as we already depend on that, we can start using this: https://drafts.fxtf.org/geometry/

Firefox support DOMMatrix, but maybe chrome not. Run the demo has an error "Uncaught ReferenceError: DOMMatrix is not defined". How can I run it on chrome.

Try turning on Experimental Web Platform features in about:flags. Works in Chrome for me

Thanks, it's work.

I added a polyfill so this shouldn't be needed, but there seems to be a bug - but I haven't been able to find it, so any help is welcome :-)

Yeah, I see the bug and I will try to find it out.


module 2b: returned a non-zero code: 100

Sending build context to Docker daemon  14.85kB
Step 1/13 : FROM ubuntu:latest
---> 1d622ef86b13
Step 2/13 : RUN echo Updating existing packages, installing and upgrading python and pip.
---> Using cache
---> 90d4918b9ade
Step 3/13 : RUN apt-get update -y
---> Using cache
---> f4e1169a5f4e
Step 4/13 : RUN apt-get install -y python-pip python-dev build-essential
---> Running in 5a992c8b785d
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package python-pip
The command '/bin/sh -c apt-get install -y python-pip python-dev build-essential' returned a non-zero code: 100

I think this might be related to python not mapping to python2, using python3-pip worked ok for me.

Hello
Is some way to resolve this issue?

Hello
Is some way to resolve this issue?

If you haven't fixed this issue, I believe this link (https://github.com/aws-samples/aws-modern-application-workshop/issues/192) solves this.


Feature/1568 test zip

Warning
Info
Issues
Fixes #1626
Fixes #1568

@davidhabib ready for review, and merge once build passes. I recommend adding ?w=1 to the end of the file review URL to ignore a bunch of whitespace changes.

CONV_Account_Conversion_BATCH_TEST.cls line 42 needs to have strTestOnly set back to '*' and the build hasn't run by the way.  you might want to manually kick it off after you fix this.

CONV_Account_Conversion_BATCH_TEST.cls line 294. do you still need to upsert the settings given our new findings about the settings facade and batches during tests?


Fix #782

Change http round tripped to http client

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


put clc into curve~

curve is the only object that uses the clc dependency, so we should merge the code into curve.c

I tried just putting it into the code and it didn't work
I get this error
cyclone_src/binaries/signal/curve.c:110:13: error: static declaration of
'clccurve_coefs' follows non-static declaration
static void clccurve_coefs(int nhops, double crv, double *bbp, double *m...
^
cyclone_src/binaries/signal/curve.c:105:5: note: previous implicit declaration
is here
clccurve_coefs(segp->s_nhops, (double)f, &segp->s_bb, &segp->s_mm);

what do I need to learn?


Table Groups functionality

Hi, can you help me to find a solution for such table with "Grouping row" (grayed on example image) with saving all others sorting/selecting functionality from this awesome component?

@sidoruk-sv, I think it's hard to do it currently, we only support the header group, but body not yet. BTW, I can try to support it, but it really take some time. BTW, if the sorting the one of the column, what the behavior you expect?

I think it would be logical to sort each group separately. Maybe you can route me and I'll try to help you add this functionality to v3 or later.

what components should handle this changes and I'll try to help you adding this functionality to v3 or later

I'm not very sure that what's component will be change, I think it's a big change for react-bootstrap-table and there's a PR is for that, but it's not yet ready to merge, still on WIP.
BTW, if want to on each group, it'll be more complex to implement and we need to take care more data manipulation.

Yo u have said >>we only support the header group<<
can you please tell me or show me an example of what you mean by "header group"

hi @venkat-vs-id, check these examples
Let me know if you have any question 👍

Any update on this Allen? I am in the same boat as the OP and looking for a workaround with this fantastic library.
Is there any way I can do sth with a dummy row with static text?

@ialbd, sorry, we still doesn't support this feature currently. I'll try to support this feature if I have time, but if supported, will be on the v4.x

Hey @AllenFang are you still working on this feature or do you have pending PRs for the same? Or do you need help with this?

@ankushrgv no, I'm not working on it. react-bootstrap-table already stop development and start to move to react-bootstrap-table2.  Anyway, PR is welcome, thank you


Refactor/requests interfaces

:tada: This PR is included in version 1.5.0-rc.5 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Filter codicon is not visible

Also in problems view

Seems like the class is applied accordingly:
https://github.com/microsoft/vscode/blob/909760587f7e172cb63a7d62c8684362590ba274/src/vs/workbench/contrib/extensions/browser/extensionsViewlet.ts#L543
But the - in the class is being stripped out:

@eamodio did you say you saw something similar with subemenu actions? This feels like it's related to SubmenuAction.

I don't think this is related to the fix that I made here: https://github.com/microsoft/vscode/commit/0eee546cc5c8d1dff9f12730777873a10bc47e72

Thanks @eamodio for fixing. Looks like this was caused via https://github.com/microsoft/vscode/commit/863acbab188c7248531fdc3c5f04783f315fcd68 (fyi @joaomoreno)

Ooof should've seen that one coming. Thanks for the fix @eamodio. We really got to stop having multiple class names in a single string. https://github.com/microsoft/vscode/issues/103454#issuecomment-692053199


Crate doesn't compile if default-features=false

base upon comments on #14 I decide to disable the default features on crate and bypass the JWT validation but doesn't compiles because there is still some code that doesn't check feature flags and that makes to fail compiling the crate.
I have added the needed features flags on code to avoid loading them when cretain features are disabled.
This should not have any breaking changes, just some validations on features

Thank you!

Published in version 0.20.0.


Fix current_position_nonexec filter so it only filters out current exec positions, not past

this was preventing acting faculty director with past exec membership from showing up on the staff page — they were listed, but always listed as past because the filter logic was catching on their other positions

Codecov Report

Merging #373 (f61bcb8) into develop (fdf077b) will decrease coverage by 0.04%.
The diff coverage is 85.00%.

@@             Coverage Diff             @@
##           develop     #373      +/-   ##
===========================================
- Coverage    98.20%   98.15%   -0.05%
===========================================
  Files           88       88
  Lines         3624     3638      +14
===========================================
+ Hits          3559     3571      +12
- Misses          65       67       +2

thanks for figuring this out! does this resolve #368?

No, it doesn't — I think it's a separate bug that we should make an issue for. For #368 we need to include faculty director and any interim faculty directors at the beginning of the exec committee member list, and I'm not sure how to do that with the current queries we have without breaking other things. (Maybe we don't make it part of the current query and just look for faculty directors separately from exec...)

@thatbudakguy how do you feel about the test coverage? I don't think this method is tested explicitly anywhere

i noticed that too. i'm fine with merging; doesn't seem like something we need to fix right now — might get revisited or invalidated as part of #232 anyway.


Getting Started automatic numbering is incorrect

Description of the modifications
The built documentation doc\source\getting_started.rst has an error in the rendered section numbers.
Useful links and references
https://aedt.antenna.toolkit.docs.pyansys.com/version/stable/getting-started.html#how-to-install-in-the-console-and-run-the-ui

This problem was just due to indentation and can easily be fixed. Waiting on @Samuelopez-ansys for write permission to push the changes ;)

@dcrawforAtAnsys now you have the power 📡


Include type-meaning 'extends' clause in auto-import fix list

If you have something like
// In global or local scope
interface Foo {
}

// User is editing here
class Bar extends Foo { }
//                ~~~
// Cannot extend interface, did you mean implements?

// In another file
export class Foo { }

This error is potentially fixable with an auto-import, so should appear in the list of errors that trigger autoimports
Checked locally

Fixes #59842

Seems right, can you just add a quick test case?


Crash if download limit is exceeded

(based on bug report from M Bays)
It seems duckling crashes if the download limit is exceeded:
Info: Retrieve: https://n-o-d-e.net/zine/
Info: Content-Type: text/html
Info: Retrieve: https://n-o-d-e.live/zine/NODE_VOL_02.pdf
panic: net/http: request canceled (Client.Timeout exceeded while reading body)

goroutine 30 [running]:
main.check(...)
        /home/user/go/pkg/mod/github.com/!luke!emmet/duckling-proxy@v0.0.0-20200902070449-0dda58548024/duckling-proxy.go:57
main.WebPipeHandler.Handle(0xa3ff5c0, 0x0)
        /home/user/go/pkg/mod/github.com/!luke!emmet/duckling-proxy@v0.0.0-20200902070449-0dda58548024/duckling-proxy.go:151 +0xf87
github.com/makeworld-the-better-one/go-gemini.handleConnection(0xa6a7f0d8, 0xa09ea00, 0x836c610, 0x853f580)
        /home/user/go/pkg/mod/github.com/makeworld-the-better-one/go-gemini@v0.8.5/server.go:97 +0xbd
created by github.com/makeworld-the-better-one/go-gemini.serve
        /home/user/go/pkg/mod/github.com/makeworld-the-better-one/go-gemini@v0.8.5/server.go:82 +0x71

It would be good if it could abort in some nice way instead.
Even better would be if it could stream the download, and leave it to the gemini client to abort the request if it's taking too long.

fixed in https://github.com/LukeEmmet/duckling-proxy/commit/2e366acf58768e519d8f259841031ded8fab9565


Issues finding the definition file/folder

Version: Obsidian 1.6.7
Problem: Whenever I try to add a new definition, the "Definition file" drop-down is empty (I have a file with def-type: consolidated in the definitions folder). Whenever I try to add an atomic definition, the folder is found but I'm asked to create a definition file, then even if I create a file with def-type: atomic, it's not found.
Anyone encounters similar problems? Maybe the plugin needs an update for 1.6.7?

Hi, thanks for the answer and the plugin. I was able to fix the issue by specifying the first definition manually in the file. After that the command worked just fine.

I ran into a similar problem. Are you using a windows computer by any chance?

@Fossu, how exactly did you manually specify the first definition in the file? I'm running into the same issue with trying to make a DEF note file for consolidated definitions.

@Fossu, how exactly did you manually specify the first definition in the file? I'm running into the same issue with trying to make a DEF note file for consolidated definitions.

Go to the file in the set definition folder. Use the command Note Definitions: Register consolidated Definition file. Then run the command Note Definitions: Refresh Definitions.
If that doesn't work remember that the default folder for Note Definitions is called definitions. To change this find the folder you want to use as the new Definition folder then press Set as Definition folder. Then repeat the steps that I said in the first paragraph.
Every time you set a new definition file you must re-run  Note Definitions: Refresh Definitions.

I ran into a similar problem. Are you using a windows computer by any chance?

I tested it on Linux (NixOS) and Mac, don't know about Windows.

@Fossu, how exactly did you manually specify the first definition in the file? I'm running into the same issue with trying to make a DEF note file for consolidated definitions.

I did it using the syntax in the README, basically something like:
manual definition
aliases of my definition
the actual definition

Same for me on Windows. Helped to create consolidated defs and refresh.

I'm having the same problem, except I'm using obsidian on my iPad. I tried doing what others have suggested in this thread but no matter what I do, the option for the destination file doesn't come up.

I ran into a similar problem. Are you using a windows computer by any chance?

I tested it on Linux (NixOS) and Mac, don't know about Windows.

@Fossu, how exactly did you manually specify the first definition in the file? I'm running into the same issue with trying to make a DEF note file for consolidated definitions.

I did it using the syntax in the README, basically add something like this to a definitions file: # manual definition aliases of my definition the actual definition

this worked for me ty

Worked for me. Super cool plugin, but what about the atomics?

Same problem here. Also on windows.

Hi,
I have the same issue. I set a folder as a definition folder. I registered a consolidated definition file but when i try to add a definition i can't see my file even if i refresh the definitions.  My pc is running on windows 10. Im salted, this plugin seems to do what i was searching to do for months lol.

Yep I tried what you mentionned earlier. With manual definition, if i set it up as a atomic definition, i can see in my notes the definition when i hover over the word. But for consolidated definition i could not manage to make it work.
So it's already good, thank you for the plugin it gonna help me to build my database for languages. if wa can take off the underline for the words it would be even better for me.

Super sorry to hear it still wouldn't work with the consolidate definitions, I'm sure if you play around with it a bit more it might work but it may be a weird case that it isn't. Needless to say, if you want to remove the underline from the words I don't think its directly possible in editing mode, but if you want there is a setting to disable it in reading mode in which it won't show the underline.

Thank you for your feedback. I will try again.
For the dotted underline if i disable it in reading mode i ca not see the definition anymore right ? I would like to be still able to see it. I think it's possible with a snippet/css code. I will try to figure it out.


Enable admins (or the public) to tell who (admin or user) made a deposit to ScholarSphere using RMD's deposit workflow

It would be nice to have more breadcrumbs to tell where deposits in ScholarSphere came from. It may be that they are already there (either in ScholarSphere or in RMD) and we just need to know what to look for.
It would be especially helpful to know when a deposit was made by an admin or proxy acting on behalf of the researcher who is listed as the depositor in ScholarSphere. And it would be great to know who the proxy or admin was, if that is possible.
This feature would help Scholarly Communications and Copyright and the ScholarSphere team when we are troubleshooting/curating deposits like this one, where the file uploaded isn't actually the kind of thing we want in ScholarSphere. The ScholarSphere curation team would like to be able to follow up and get the right file, but the user listed as the depositor may not be expecting an email from them (if the "depositor" didn't actually make the deposit).

This would be useful related to the new curation workflow for ScholarSphere, because it would set us up to be able to have certain deposits from RMD skip the curation workflow (e.g. if an RMD admin already reviewed/curated the deposit).

[ ] We can easily differentiate between the Activity Insight OA Workflow uploads to Scholarsphere and the ScholarSphere Deposit Workflow with two differently named API keys.   We should rename the current ScholarSphere Deposit Workflow API key and add an API key for the Activity Insight OA Workflow.
[ ] We would like to capture who the actual depositor is (author, proxy, or admin).  This will likely require ScholarSphere to allow another metadata field accepted by the ScholarSphere deposit API endpoint.  We should display in the ScholarSphere breadcrumbs who this person is and their role.

@bdezray

@ajkiessl Is there anything we need to do on the RMD side to ensure RMD is ready to share this info with ScholarSphere once the ScholarSphere changes are in place?

@ajkiessl Do we need to add an issue about this to the ScholarSphere backlog?
@bdezray

@anaelizabethenriquez Yeah, here is the issue: https://github.com/psu-libraries/scholarsphere/issues/1422

Seems like this specific feature will be less relevant once users are depositing directly within ScholarSphere, so I am deprioritizing this.


Theme isolation improvements

Theme isolation improvements, as per:
https://groups.google.com/d/topic/tardis-devel/MB92C9_eclU/discussion

Closing, as there's really no point applying the patch to this repository now.


Fix product handmade form

add "price" input field as it is required by the api
add missing toolbar including save button in add form

Closes COM-460

I pushed a commit to your PR and used the SaveBoundary also for adding

@Flips2001 please fix conflicts.
@thomasdax98 please review.
Thanks!


chore(semantic-release): add configuration

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


chore: copy edits

Describe Your Changes

Copy edits and grammar fixes

Fixes Issues

Closes #
Closes #

Self Checklist

[ ] Added relevant comments, esp in complex areas
[ ] Updated docs (for bug fixes / features)
[ ] Created issues for follow-up changes or refactoring needed

Pls auto meowrge for me


Fix calculation of input and output size

Replaced by of https://github.com/HEnquist/rubato/pull/78


Add a license to the repository

I recently came across your project Quantum-miniproject and I noticed that the repository github.com/captainredbleach/Quantum-miniproject currently does not have a license specified.
Why Adding a License is Important?
As GitHub documents

Public repositories on GitHub are often used to share open source software. For your repository to truly be open source, you'll need to license it so that others are free to use, change, and distribute the software.

Would be possible to add a valid license to this repository? Probably something really OpenSource such as the Apache 2.0 license would fit really well.
Thanks!

Hi Juan,
Thank you for your feedback, I will be adding the license.

Thanks!


HTML comments followed by plain text parse as HTML comment blocks

A block like this:
<!--Comment--> Markdown text.

Will parse as HTML Comment Block containing the following text, despite that comment is only a part of it.

It is actually part of the CommonMark spec to include the text after the comment.
Added option Parser.HTML_BLOCK_COMMENT_ONLY_FULL_LINE when set to true will not parse lines that start with HTML comment but contain other stuff as HTML Block Comment, but pass it for further parsing as paragraphs with the comment becoming an InlineHtmlComment.


 ENIs might be
leaked if the operator is unable to perform an ENI delete operation, for
example because the EC2 API is (temporarily) unavailable or the operator
crashed before it was able to issue the delete operation.
The GC runs in a regular interval and removes any ENIs with a predefined
set of tags. The tags are added to newly created ENIs, meaning this GC
does not remove any ENIs created by older versions of Cilium. This is
done to avoid removing any ENIs which were never managed by Cilium.
The tags used for ENI creation and deletion, as well as the GC interval,
can both be configured using operator flags. If the GC interval is set
to zero, the ENI GC is disabled.
Review per commit

Besides the unit tests, I have also tested this in a real cluster with a small test of ENIs:
# Run 1
2022-09-22T16:32:58.789403029Z level=debug msg="Marked unattached interfaces for garbage collection" numInterfaces=3 subsys=eni

# Run 2 - Note: I forced a race manually, by attaching one of the ENIs marked
# for garbage collection to an instance. As you can see, the API did not remove the in-use ENI:
2022-09-22T16:37:58.790004387Z level=debug msg="Garbage collecting ENI" eniID=eni-03fc53ab5ad26d24e subsys=eni
2022-09-22T16:37:59.016210891Z level=debug msg="Failed to garbage collect ENI" error="operation error EC2: DeleteNetworkInterface, https response error StatusCode: 400, RequestID: fa502304-0dbc-403f-bbe2-c30d2615bfc1, api error InvalidParameterValue: Network interface 'eni-03fc53ab5ad26d24e' is currently in use." subsys=eni
2022-09-22T16:37:59.016280762Z level=debug msg="Garbage collecting ENI" eniID=eni-02714735b24b4dfd1 subsys=eni
2022-09-22T16:37:59.343633394Z level=debug msg="Garbage collecting ENI" eniID=eni-01d64d659b7116851 subsys=eni

# Run 3 & 4
# note: I unattached a ENI manually from an existing instance
2022-09-22T16:42:59.921815277Z level=debug msg="Marked unattached interfaces for garbage collection" numInterfaces=1 subsys=eni
2022-09-22T16:47:59.922109406Z level=debug msg="Garbage collecting ENI" eniID=eni-027e57fe40b35535e subsys=eni

Last push fixed a bug in the ec2shim around pagination. MaxResults did not work as I expected it to.
diff --git a/pkg/aws/ec2/ec2.go b/pkg/aws/ec2/ec2.go
index e4f7a95931ea..d90a8b87bec0 100644
--- a/pkg/aws/ec2/ec2.go
+++ b/pkg/aws/ec2/ec2.go
@@ -170,6 +170,9 @@ func (c *Client) GetDetachedNetworkInterfaces(ctx context.Context, tags ipamType
                for _, eni := range output.NetworkInterfaces {
                        result = append(result, aws.ToString(eni.NetworkInterfaceId))
                }
+               if len(result) >= int(maxResults) {
+                       break
+               }
        }
        return result, nil
 }

/test

net-next hit #21120 - unrelated known flake

/ci-eks

/ci-eks

Marking ready to merge. The code added in this PR is only active in ENI mode, which passed twice. Full Jenkins CI also passed previously and I've also tested the code (including the new clustername fallback) manually as well.

Missed a bunch of missing copyright headers. Nothing major, but I want to add them before we merge.

Rebased, fixed the missing copyright header and added a small doc section about the cluster name detection. Re-running full CI on the rebased branch.

/test


Selection sort c/cpp

🛠 Fixes Issue #31
👨💻 Changes proposed

implemented =selection sorting algorithm using c/cpp language.

✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Make sure to give the correct issue no @vickyrules


Merge to live!

Docs Build status updates of commit 64278f3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/develop/add-in-manifests.md
:white_check_mark:Succeeded

docs/develop/manifest-element-ordering.md
:white_check_mark:Succeeded

docs/develop/office-javascript-api-object-model.md
:white_check_mark:Succeeded

docs/develop/understanding-the-javascript-api-for-office.md
:white_check_mark:Succeeded

docs/images/manage-users-deployment-admin-center.png
:white_check_mark:Succeeded

docs/images/power-bi-tiles-edit.png
:white_check_mark:Succeeded

docs/images/power-bi-tiles.png
:white_check_mark:Succeeded

docs/images/selected-add-in-admin-center.png
:white_check_mark:Succeeded

docs/images/update-add-in-admin-center.png
:white_check_mark:Succeeded

docs/onenote/onenote-add-ins-programming-overview.md
:white_check_mark:Succeeded

docs/overview/office-add-ins-fundamentals.md
:white_check_mark:Succeeded

docs/overview/office-add-ins.md
:white_check_mark:Succeeded

docs/overview/schemas/content/OfficeAppBasicTypesV1_0.xsd
:white_check_mark:Succeeded

docs/overview/schemas/content/OfficeAppManifestV1_1.xsd
:white_check_mark:Succeeded

docs/overview/schemas/mail/MailAppVersionOverridesV1_0.xsd
:white_check_mark:Succeeded

docs/overview/schemas/mail/MailAppVersionOverridesV1_1.xsd
:white_check_mark:Succeeded

docs/overview/schemas/mail/OfficeAppBasicTypesV1_0.xsd
:white_check_mark:Succeeded

docs/overview/schemas/mail/OfficeAppManifestV1_1.xsd
:white_check_mark:Succeeded

docs/overview/schemas/taskpane/MailAppVersionOverridesV1_0.xsd
:white_check_mark:Succeeded

docs/overview/schemas/taskpane/OfficeAppBasicTypesV1_0.xsd
:white_check_mark:Succeeded

docs/overview/schemas/taskpane/OfficeAppManifestV1_1.xsd
:white_check_mark:Succeeded

docs/overview/schemas/taskpane/TaskPaneAppVersionOverridesV1_0.xsd
:white_check_mark:Succeeded

docs/publish/centralized-deployment.md
:white_check_mark:Succeeded

docs/reference/overview/excel-add-ins-reference-overview.md
:white_check_mark:Succeeded

docs/reference/overview/onenote-add-ins-javascript-reference.md
:white_check_mark:Succeeded

docs/reference/overview/word-add-ins-reference-overview.md
:white_check_mark:Succeeded

docs/testing/clear-cache.md
:white_check_mark:Succeeded

docs/testing/create-a-network-shared-folder-catalog-for-task-pane-and-content-add-ins.md
:white_check_mark:Succeeded

docs/testing/sideload-an-office-add-in-on-ipad-and-mac.md
:white_check_mark:Succeeded

docs/testing/sideload-office-add-ins-for-testing.md
:white_check_mark:Succeeded

docs/testing/troubleshoot-manifest.md
:white_check_mark:Succeeded

docs/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add parallel limit to config

We use this plugin to upload a Gatsby build with a large number of static pages and the hard coded limit of 20 slows down our deployment process significantly. This change adds the ability to set a custom parallel upload limit.

Seems like a useful addition. Have you done speed comparisons with/without this change? For your particular use case, what's the sweet spot for parallelLimit?
As far as I know we picked 20 at random, so I'd be interested to know what value works best for you.
I've requested some minor changes to the code and comments. Thanks for your contribution!

The optimal number seems to vary drastically based on the use case, for us using a value of 2000 reduced our deploy time from 1hr to 2mins. Our case is somewhat exceptional though as we are deploying a few thousand small files 😅.

reduced our deploy time from 1hr to 2mins

Wow, that's pretty incredible. I'm amazed that a parallelism of 2,000 has a benefit for you. I'd expect that to be far beyond the point of Parallel Slowdown. At a guess, is your connection to S3 high-bandwidth but high-latency?
Anyway, if you can make the change regarding DEFAULT_CONFIG then I'm happy to merge this.

Thanks very much for contributing!

Thanks for the feedback and merge! Any idea when the next release of the plugin might be?

Not sure, @jariz does the releases.
I think he's hoping that I'll finish #83 before he does the next release. I'm hoping to finish that next week.

Correct, hoping to finish #83 so I can test #134 / #92 properly and make that part of the release.


i compressed this project into 10 lines :

var regex = {
    all: /require\s*\('\s*([^'])*'\s*\)|require\s*\("\s*([^"])*"\s*\)/g,
    start: /require\s*\(\s*["']/,
    end: /["']\s*\)$/,
    comments: /\/\*.+?\*\/|\/\/.*(?=[\n\r])/g   // or /(\/\*([\s\S]*?)\*\/)|(\/\/(.*)$)/gm
  }

  function extract_dependencies(text) {
    text = text.replace(regex.comments, '')
    var requires = text.match(regex.all) || []
    for(var i=0; i< requires.length; i++) {
      requires[i] = requires[i].replace(regex.start, "").replace(regex.end, "")
    }
    return requires
  }

It ignores calculated require's which are not string calls such as require(a + b), but catches all others. It's also very fast -

( it also works in the browser)

'what about require("beep") in a string?'

Congrats substack - you win the prize !
I think I had figured this when I wrote it, but it's a veeery edge case.

you could easily remove these as well if you could be bothered. just extract all the strings and throw out the ones with strings inside them


Control gallery updated for flet 0.25

updated for flet 0.25

Please how to upload file for browser
في الأربعاء، ٤ ديسمبر ٢٠٢٤, ١٢:٠٨ ص Feodor Fitsner @.***>
كتب:

Merged #181 https://github.com/flet-dev/examples/pull/181 into main.
—
Reply to this email directly, view it on GitHub
https://github.com/flet-dev/examples/pull/181#event-15516062911, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/BL3XCPABFGEHVC4ZHGHVMG32DYMVVAVCNFSM6AAAAABSTP5IXWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVGUYTMMBWGI4TCMI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


New tree does not have the correct species name for the dog

After a bit of scrambling, I managed to upload the new OpenTree to OneZoom (hurrah!), but it appears as if we are not correctly recognising the name "Canis lupus familiaris" as a subspecies, so we are allow it to be the tip of the tree (see https://www.onezoom.org/life/@Canis_lupus_familiaris=247333). In OneZoom, we don't allow subspecies to be shown, and there should be code in the tree-building pipeline to recognise this as a subspecies (e.g. because there are 3 words), and remove the node(s) until we are only left with a terminal tip labelled "Canis lupus". Something is going wrong here, and the tree parsing behaviour looks like it has changed.

Note that, however, we need to leave the Canis_lupus_familiaris node in the tree until almost the last step, so that we can pick up the popularity of the subspecies nodes into the species node. We should then trim off the subspecies tip to be left with only the species in the final output tree.

I'm going to hack this on the DB on the main site, but we should fix it long-term

I will look at this today. But didn't the gray wolf use to have a separate leaf from the dog, maybe as a sister?

I'm not sure that's where the subspecies removal happens. Let me have a look through to remind myself.

I think it's probably done in prune_children_of_otts. That function takes a set of OTT ids (that represent all the species in the tree) and deletes any children (e.g. subspecies) below them.

Thank you, I will start debugging this now and see what I can find.

Great, thanks so much.

Ok, I see the problem:
    # check for extinction props
    if (
        (nd.num_child_nodes() == 1)
        and (list(nd.child_nodes())[0].num_child_nodes() == 0)
        and (list(nd.child_nodes())[0].edge.length)
    ):
        trim_me = False  # this is an extinction prop

Here:

Canis lupus only has one child, Canis lupus familiaris
This child has no children
This child has an edge length of 1e-06

So we treat it as an extinction prop and don't trim it.
But this 1e-06 is completely bogus, as it means 1 year! I was actually caused by my change a54dea83ab8421e417887d05f746e9f92d9f3ad0 to make the tree fully ultrametric. To preserve ultrametricity, I think the right thing to do is to give the year back to Canis lupus, changing:
(Canis_lupus_familiaris_ott247333:1e-06)Canis_lupus_ott247341:1.123457)

to
(Canis_lupus_familiaris_ott247333:0)Canis_lupus_ott247341:1.123458)

I think this might be the only case where we have allocated a non-zero branch between a species and a subspecies? I guess it might be helpful to warn in the ultrametricity-forcing algorithm if this happens? But I don;t know if we will use it again, at all.

I guess it might be helpful to warn in the ultrametricity-forcing algorithm if this happens?

Yes, it would be good. The code I have in fix_ultrametricity has:
https://github.com/OneZoom/tree-build/blob/66ed8a31a99ad4bcec1dfd18b481c1a5e14f04f3/oz_tree_build/newick/fix_ultrametricity.py#L20-L22
But here, the length is 0, not None, so we end up adjusting it and messing it up. I guess if it is either 0 or None, we should leave it alone.
Though come to think of it, is having Canis_lupus_familiaris_ott247333:0 even correct, versus having Canis_lupus_familiaris_ott247333?
I think part of the problem is our extinct props semantic is kind of clashing with this odd case of having a single dog subspecies.

Most authorities treat the dog a a subspecies of wolf

And maybe going off a tangent, but I think we should special case this here. It may be a subspecies, but from a cultural and conservation standpoint, treating Gray Wolves and dogs as one node does not make much sense. The same could be said for the dingo, to a lesser extinct. Plus we're missing out on some likely sponsorships! :)

Something along the lines of (with proper edge lengths added):
  (
    (
      Canis_simensis_ott752755,
      Canis_latrans_ott247331
    ),
    (
      Canis_lupus_ott247341,
      (
        Canis_lupus_familiaris_ott247333,
        Canis_lupus_dingo_ott380529
      )"Domesticated_gray_wolves"
    )
  );

And yes, it violates the 'no subspecies' tenet, but what's the harm?

You are right that we could simply remove the length altogether (not even have a 0).
There are many other cases in the OpenTree where there are one or even multiple subspecies of a single species. In all cases, I think we should have a null or 0-length branch to the subspecies, as this reflects biological reality (the species is not extinct).

I think we should special case this here

We debated this at the time (and e.g. cats are considered separate species). The problem is that there are lots of animals with interesting subspecies (e.g. giraffes), and there are also quite a lot of dog subspecies (https://tree.opentreeoflife.org/opentree/argus/ottol@247341/Canis-lupus). Once you get to the subspecies level, different people have different naming conventions, and you get quite a lot of taxonomic churn. It's also much less clear whether a tree is the right metaphor between species, as there's often a lot of hybridisation. So generally, having a rigid cutoff at species makes our lives quite a lot easier. But as you say, maybe dogs are an exception.
The sponsorship argument is a bit moot, as we have banned the dog from sponsorship anyway (or at least, we require a very high price in the thousands of pounds/euros/dollars).

Something along the lines of (with proper edge lengths added):
  (
    (
      Canis_simensis_ott752755,
      Canis_latrans_ott247331
    ),
    (
      Canis_lupus_ott247341,
      (
        Canis_lupus_familiaris_ott247333,
        Canis_lupus_dingo_ott380529
      )"Domesticated_gray_wolves"
    )
  );

Yep, but why stop at 2 subspecies? I think we would at least also have to have Canis lupus lupus, and then it's debatable about whether we should also have some of the other wolf subspecies too? We would need to work out a sensible branching order for the ones we chose too.

why stop at 2 subspecies

I guess I view species resulting from ultra fast pace human breeding as different, but I see that would open a can of worms.
Anyway, no need to debate the point here, and the discussion can always be revived later.
So I think we can simply remove the edge length from Canis_lupus_familiaris, and all will be well:

The ultrametricity tool will not mess with it
Having no length means it's unknown, so it never breaks ultrametricity (it gets inferred on the way down)

I'll make the change.


Marketplace App Card - Favorite Button

Summary
The current implementation of the favorite button is causing a problem. When a user clicks on the app's favorite button, the button icon does not change immediately. Instead, the change is only visible after reloading the page. The same issue occurs when trying to un-favorite an app.
Expected Behavior:
When a user clicks on the favorite button, the button icon should change instantly to indicate successful favoritization.
Similarly, when un-favoriting an app, the button icon should update immediately.
Steps to Reproduce:

Open the app.
Navigate to the marketplace - any app card
Click on the favorite button.
Observe that the button icon does not change immediately.
Reload the page.
Notice that the button icon now reflects the successful favoritization.

Additional Information:

This issue affects both favoriting and un-favoriting an app.
The problem occurs consistently and is reproducible.
The expected behavior is for the button icon to update instantly upon clicking, without the need for page reloading.

Test

[ ] The button should switch and change immediately upon selection.
[ ] The favorite section should be updated promptly when any favorite button of an app is selected.
[ ] The favorite function should only be triggered when the user clicks on the exact favorite button and not anywhere else.
[ ] Clicking the favorite button should not cause the card to reload.

To change this behavior and keep a satisfying user experience I recommend to change the hovering behavior of the card component slightly. Because currently the favorite button is in the expanded area of the card only visible when hovering over the card. If the user clicks the button the card is re-rendered and losing the expanded status. We could extend the hovering area to the whitespace under the card to prevent this.

To change this behavior and keep a satisfying user experience I recommend to change the hovering behavior of the card component slightly. Because currently the favorite button is in the expanded area of the card only visible when hovering over the card. If the user clicks the button the card is re-rendered and losing the expanded status. We could extend the hovering area to the whitespace under the card to prevent this.

@manojava-gk  in case this is approached; please reach out to Dirk first

To change this behavior and keep a satisfying user experience I recommend to change the hovering behavior of the card component slightly. Because currently the favorite button is in the expanded area of the card only visible when hovering over the card. If the user clicks the button the card is re-rendered and losing the expanded status. We could extend the hovering area to the whitespace under the card to prevent this.

@manojava-gk in case this is approached; please reach out to Dirk first

No. but will talk to Dirk about this input.

Decided to re-design the app card (new hover state can get find below)

Reduced space by 30%
Description supported not bold


Incorrect response codes for fetching non-existant instance/binding

Hello!
There is a little issue with the conformance to OpenServiceBroker API specification v2.14.
While fetching a service instance if the service instance with the specified id does not exist, service broker must return 404 Not Found, however, now it returns 422 Unprocessable Entity.
The similar situation with fetching a service binding (must return 404 as well), but now returns 500 Internal Server Error.

This PR #212 should close the issue

Closed in #212


the description did not have the updated value

Signed-off-by: hchenxa<EMAIL_ADDRESS>

/retest

/retest

/lgtm


Strip .html from the paginated pages (/articles/page2.html) to (/articles/page2/

I'm using pagination but am pointing it to an "articles" page, not index.html in root. I've created an "articles" folder and added a new index.html to that folder (acting as the blog page).
My permalink settings are
permalink: /:num/ (I've also tried /:num and /articles/:num)
and my link in the page is {{ paginator.previous_page_path | prepend: site.baseurl | replace: '//', '/' }}
Everything works great except it adds a .html extension to all the pages - which results in duplicate content, since there are the same two pages at /articles/page2.html and /articles/page2/
Any assistance is much appreciated

Nevermind, I see there are already a few concerns about this.
Looks like the fix as of now is adding {{ paginator.next_page_path | replace: 'index.html', '' | prepend: site.baseurl }} to the index page.
Thanks,
Shawn - fencepencil


added vanillaJS tooltips to line chart; found Nathans stylesheet and …

…hooked it to line chart component. Much prettier now.

Good work on this PR. Functionally it looks aok to me. I gave a little bit of styling feedback. It won't hurt my feelings if you don't incorporate it, just figured I'd leave some comments detailing things that look off!


feat: weight typeahead search results the same way we weight similar searches

This will make the typeahead endpoint more useful; npm is looking into hitting this endpoint now.

CC: @alexearly

@bcoe I guess we can close this right?

👍


Status should take TryInto

Change the trait bound of S in the Status trait to accept a TryInto<StatusCode>; this would allow the Status trait to accept a wider range of input.
Uses the same approach as Response::new.
Refs: #155
Draft PR until the checklist is complete:

[X] feature implementation.
[x] tests added.
[x] documentation updated.

The commit a2e58a1 contains only the linting from rust fmt. It can be kept here, moved in a different MR or simply dropped; I would leave this to the judgement of the maintainers.
Thanks


atr doctor to check for dependencies

A new sub command atr doctor should be implemented that checks whether all binary dependencies (currently, aapt and adb) are installed and accessible. It should also provide information on how to install the missing dependencies.

Implemented and tested