Unsupported scriptPubKey

Hi everyone! Thanks for good library and nice doc book - I've read it multiple times.
When I'm running just the basic example, I'm stuck at the "Unsupported scriptPubKey" exception when trying to partially sign the transaction.
I was able to retrieve the last transaction with the real satoshis, but signing it seems to be impossible.
The code looks pretty straightforward and the exception is not documented anywhere. I've looked at the source code and it seems somehow the CanGenerateScriptSig method always returns false.
Can you please assist?

Paste the whole ex.ToString() here.

There you have it.
System.NotSupportedException: Unsupported scriptPubKey
   at NBitcoin.TransactionBuilder.CreateScriptSig(TransactionSigningContext ctx, ICoin coin, IndexedTxIn txIn)
   at NBitcoin.TransactionBuilder.Sign(TransactionSigningContext ctx, ICoin coin, IndexedTxIn txIn)
   at NBitcoin.TransactionBuilder.SignTransactionInPlace(TransactionSigningContext ctx)
   at NBitcoin.TransactionBuilder.SignTransaction(Transaction transaction)
   at ConsoleApp1.Program.Main(String[] args)

also,
 PayToMultiSigTemplate.Instance.CheckScriptPubKey(alice.ScriptPubKey);
returns false.

@Bassist067 you should not AddCoins twice to the same builder, instead, create a new builder.

Looking at your code I don't see anything wrong though. Can you share on pastebin?

Oh I know.

The redeemScript should not be GenerateScritPubKey(...).PaymentScript but GenerateScritPubKey(...)

@Bassist067 you should not AddCoins twice to the same builder, instead, create a new builder.

Thank you Nicolas, that wouldn't make sense for me anyway. It's natural to load coins just once. And there's the code sample

@Bassist067 if you used GenerateScritPubKey(...).PaymentScript as the redeem script and want to recover your money, this is an interesting excercise, but you can't do it with TransactionBuilder.
Basically  GenerateScritPubKey(...).PaymentScript is OP_HASH160 <hash_of_the_multisig_script> OP_EQUAL. Which mean that if you need to push to the scriptSig <GenerateScritPubKey(...)> <GenerateScritPubKey(...).PaymentScript>. Notice that you don't need any signature, so a miner can theorically steal it.

Thank you so much Nicolas, now it works without that error! Basically, what I want to achieve there is just creating the Multisig wallet on fly. receive bticoins from outside and then send bitcoins to some 3rd party, like ESCROW.

Second issue, your fees are less than 1 satoshi, minumum is 216 . I am getting back your money one sec

I recovered your money
https://blockstream.info/tx/55c3516d8c85856b2ae63ffceebfc7db6c1427773df2c8b064a7a7912b3afef6
010000000197c2ae7a2d06e6e4e28e225418d45949db0c02c739a57cb02c0dbbe355ae33a700000000834c6952210248976b7c4009c5152a79fb5d4e150fe16416b3fb50ab682db16a302bb05b5e6321037aa3ccc7a9a07ba601d9a4a43d4fe8cd6c71cb7f8c66de58d614b493b61c41a12103fb15e4bf69081e61e53de70049c0e9c875666d27e84f3913411d5835d4c850b753ae17a91469f8ee14a27ff5886327a8d4fb8215bec072d16a87ffffffff01f1110000000000001976a9149f904fac967ef95afe8ae0d0fec5b177ab3a63e988ac0000000055c3516d8c85856b2ae63ffceebfc7db6c1427773df2c8b064a7a7912b3afef6

no worries. Also, there's the guide where I've initially discovered the NBitcoin library - dude there uses .PaymentScript for some reasons

.PaymentScript is the scriptPubKey you want to set for your multisig if you want to do a p2sh payment. This is from that that your P2SH address is generated.

Here is the code I used to recover your money, as an exercise: https://pastebin.com/0GeyFSXq


React example does not use best practices

There is a potential bug with the React example. If the Honker is unmounted from the page, honkify is not unregistered.  To solve this, the example should utilize the useEffect hook:
import React, { useEffect, useState } from "react";
import honkify from "honkify";

const Honker = () => {
  const [isActive, setActive] = useState(false);

  useEffect(() => {
    if (isActive) {
      const unregister = honkify();
      return () => unregister();
    }
  }, [isActive]);

  const toggleHonk = () => {
    setActive(isActive => !isActive);
  };

  return (
    <button onClick={toggleHonk} className="no-honk">
      {isActive ? "unhonk" : "honkify!"}
    </button>
  );
};

export default Honker;

In the useEffect, unregister will be called if the isActive state is false or if the Honker is unmounted.

@jlengstorf
Fixed in #4


Enabling Password option for the outbound provision connector Salesforce does not work

Environment
5.11.0 M26 pack
Steps to Reproduce

Create a tenant

Login to developer portal as the tenant created in step 2
https://localhost:9443/t/iam.com/developer-portal

Navigate to Identity Provider component

Add Facebook as a IDP

Navigate to created IDPs Outbound Provisioning Wizard

From New Connector option Add Salesforce as a New connector

In salesforce, configuration wizard try to check the password checkbox

Observation
Enabling password option does not work. As this field is a mandotory field without enabling it cannot proceed to the next phase. Therefore adding the salesforce connector to the system fails

This is fixed now.


Add combined validation

This adds some GitHub Actions with Hassfest (to catch invalid integrations), HACS (to catch invalid HACS integrations), and flake8 (to catch invalid python). Closes #88.

Thanks! Maybe I'm being dense here, but I thought because you put pull_request: under the on: section, this would run the action so we could see what it does on the pull request here. Do you know why it wasn't triggered?
(To clarify why this is important: if we're going to merge a flake8 check, we should probably make the code pass that check.)

It's odd that that didn't happen. You will need to add a topic, such as home-assistant, for the HACS check to pass. I'll try to bump it.

Looks like hassfest is unhappy. I'll try to fix this.
https://github.com/KTibow/hass-smartthinq/runs/1404229065

Sorry, forgot to disable formatting. Give me a sec...

Sorry for the inconvenience, I fixed it and it's ready. You can view the actions if you want.


HBASE-28370 Set updateTs on default UserQuotaState

In https://github.com/apache/hbase/pull/5666 we introduced default user quotas, but I accidentally called UserQuotaState's default constructor rather than passing in the current timestamp. The consequence is that we're constantly refreshing these default user quotas, and this can be a bottleneck for horizontal cluster scalability.
We have deployed this to a cluster with thousands of unique quota users and verified that the refresh workload was significantly reduced.
@bbeaudreault @hgromer @eab148 @bozzkar

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
3m 23s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m  3s
master passed

+1 :green_heart:
compile
2m 27s
master passed

+1 :green_heart:
checkstyle
0m 39s
master passed

+1 :green_heart:
spotless
0m 45s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 32s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 47s
the patch passed

+1 :green_heart:
compile
2m 25s
the patch passed

+1 :green_heart:
javac
2m 25s
the patch passed

+1 :green_heart:
checkstyle
0m 35s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
4m 53s
Patch does not cause any errors with Hadoop 3.3.6.

+1 :green_heart:
spotless
0m 42s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 37s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 12s
The patch does not generate ASF License warnings.

28m  5s

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5686/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5686

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 15afb20a2cc8 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d9257543a5

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
83 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5686/2/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Looks like my test is flappy, I can investigate early next week

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 27s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m  9s
master passed

+1 :green_heart:
compile
0m 47s
master passed

+1 :green_heart:
shadedjars
5m 45s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 24s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 56s
the patch passed

+1 :green_heart:
compile
0m 46s
the patch passed

+1 :green_heart:
javac
0m 46s
the patch passed

+1 :green_heart:
shadedjars
5m 44s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 23s
the patch passed

_ Other Tests _

-1 :x:
unit
220m 21s
hbase-server in the patch failed.

244m 56s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5686/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5686

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux cd77a39ecb29 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d9257543a5

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5686/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5686/2/testReport/

Max. process+thread count
4649 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5686/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Oh, I just forgot the @ClassRule. Pushing a fix now

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 35s
Docker mode activated.


Mentorship Section UI Update in Experience Page

Some Specifications:

Make the subheading Community Involvement from Mentorship
Do not copy-paste the Boostrap carousel directly. Make a custom carousel appropriate to the theme
Automatically change the image after 3 seconds unless hovered
Keep in mind we have to display logos or pictures which are quite different from posters. Therefore, adjust the width accordingly (and make sure in a single laptop screen of 15.6", not more than 3 full cards are visible)
Have minimal arrows for navigation on both sides
Use placeholder images of any technical community initiative (to be placed inside Experience Page)
MUST BE MOBILE RESPONSIVE
The current cards are dynamically loaded from expereince.js and should continue to do so even after this change

Can I work on this issue?

@RiyaGupta89 Since you would be already shifting the codebase to react, I would advice working on this once it is complete

Can I work on this issue under LGM SOC

Can I work on this issue under LGM SOC

Assigned for 3 days

Closed due to inactivity. To be continued in #748


Update stargate-mongoose and create-astradb-mongoose-app with latest jsonapi changes

I don't think this issue belongs on this repo @Yuqi-Du.

this ticket is too general, we have other stargate-mongoose tickets to support


Filesystem Suffixing Writes In Wrong Folder

Thank you for this wonderful package.
I'm having trouble with writing files to tenant disks.  As on the filesystem help page, writes go to a suffix folder inside the disk folder, rather than top level.  So, from your docs example, I'm writing to the first, when I want the second:
/path_to_your_application/storage/clientUploads/tenant1e22e620-1cb8-11e9-93b6-8d1b78ac0bcd/
/path_to_your_application/storage/tenant1e22e620-1cb8-11e9-93b6-8d1b78ac0bcd/clientUploads/
When I go to READ the files, I get an error, since the file is not where tenancy expects it to be.  However, the error is looking for the file in the correct (2nd) directory.  So - reads look to the correct directory - writes/deletes are going to the wrong directory.
I have tried php artisan config:clear and php artisan cache:clear.  I have tweaked various parts of the tenancy file, but I can not get it to write with the top-level tenant.suffix folder.
Here is my filesystem config:
`'disks' => [
    'local' => [
        'driver' => 'local',
        'root'   => storage_path('app'),
    ],
    'clientUploads' => [
        'driver' => 'local',
        'root'   => storage_path() . '/clientUploads',
    ],`

Here is my tenancy config:
`'filesystem' => [ // https://tenancy.samuelstancl.me/docs/v2/filesystem-tenancy/
    'suffix_base' => 'tenant',
    'suffix_storage_path' => true, // Note: Disabling this will likely break local disk tenancy. Only disable this if you're using an external file storage service like S3.
    'asset_helper_tenancy' => false, // should asset() be automatically tenant-aware. You may want to disable this if you use tools like Horizon.
    // Disks which should be suffixed with the suffix_base + tenant id.
    'disks' => [
        'local',
        'clientUploads',
        // 's3',
    ],
    'root_override' => [
        // Disks whose roots should be overriden after storage_path() is suffixed.
        'local' => '%storage_path%/app/',
        'public' => '%storage_path%/app/public/',
    ],
],`

Here is an example of how I write to disk:
\Storage::disk('clientUploads')->put($filename, file_get_contents($file))
Probably I'm missing something silly.  Appreciate any help please.

Can you see https://github.com/stancl/tenancy/issues/308? I tried to reproduce this but it worked for me.

Yes, I read that as well.  I just tried updating the package and it did update from v2.3.4 => v2.3.5, but no luck.  It still writes to the wrong place, and reads from the correct place.

Hmm, do you maybe see something different in what you're doing and what I'm doing? I'd love to fix this but like I said, I didn't manage to reproduce it.

I understand.  I don't see anything unusual, and I've been poking around for hours.  I'm going to tear down the server and try from scratch.  I will let you know if anything changes.  Thank you again.

Thank you! Much appreciated.

I rebooted the server - no change.  I then created a new server from scratch, VMWare vs VBox this time, and cloned my current project.  No change, unfortunately.
I did notice one clue: in both cases, upon Laravel booting (regardless of page or tenant), Laravel immediately created the wrong folders.  So without loading, on the first page I visited on the new server, it created storage/clientUploads.  It created a folder for each of my disks (from filesystems.php).   Something on the create/write side is bypassing the tenancy replacement folder.
I don't know Laravel well enough to know where this happens, or why.  Only other thing I can say is that it is Laravel 7.5, but I have been upgrading this app for a very long time (5.something).  Though - the new server installed everything from scratch, so I can't imagine the vendor files would be old versions.
Any thoughts?  If not, I will try building a Laravel app from scratch tomorrow, add Tenancy, and see what happens.

Ah! Just noticed you don't use root_override at all for your two custom disks. It's a bit confusing, but this should help: https://tenancyforlaravel.com/docs/v2/filesystem-tenancy/#filesystem-tenancy

HA!  YES!  That's fantastic, and it is now working perfectly.  Thank you very much for catching that - I was going to spend my day re-inventing the wheel lol.
For dummies like me, may I suggest a slight update to that document?  I read it quite a few times but I didn't understand that the disk needed to be entered in both places for this to work correctly (notwithstanding a non-local disk like S3).  I was thinking I needed to add my disks in the disks section, but I thought the root_override was just for the base folder and not the disks as well.  I realize it does say this, but I didn't follow correctly.  Perhaps add an explicit example outside of the normal Laravel disks inside both areas to highlight?
Totally my mistake - Tenancy seems to be working fantastically!!  Thank you again.

Nice, glad to hear that. Yeah, the filesystem stuff is a bit poorly documented. I've already rewritten the page once but will need to set some time aside for that again. Since root_override works for both me & you, I'm closing #308.


Input error in Chinese input method

VSCode Version: Code 1.12.1 (f6868fce3eeb16663840eb82123369dec6077a9b, 2017-05-04T21:26:50.689Z)
OS Version: Windows_NT ia32 10.0.15063
Extensions:

Extension
Author
Version

html-snippets
abusaidm
0.1.0

code-gnu-global
austin
0.2.1

csharp
ms-vscode
1.9.0

Steps to Reproduce:
This issue will represent randomly

Sometimes, when I use Chinese input method, the current input position before the existence of English characters, the first letter in the Chinese input method is always recognized as English characters, so that the Chinese input to remove the first letter, resulting in input errors;

@kookyle do you mind sharing more details in Chinese to help me troubleshoot?

@rebornix 是这样的，我在使用VS Code编辑.md 文档，代码和中文混合输入；问题是，在我使用中文输入法输入中文的时候，有时候第一个字母会被识别为英文字母，以至于我的输入的拼音第一个字母被取消掉了，造成输入错误，比如我用输入拼音“daima”，字母d就直接变成英文字母d输入了，然后候选窗口显示的拼音就变成“aima”；目前，我还没有发现重现方法，使用不同的中文输入法都会出现这个情况，包括系统自带的微软拼英输入法；

I have same issue in OS X. It's even worse because the wrong character is usually an invisible character, like 0x27. Which cause lots of "Invalid character" error when I compile the file.

I have same issue in Windows 10, the vs code version is 1.14.2.

@kookyle thanks, let me try to reproduce. @xiajing1980 @shaoyuan1943 are you using the system built in IME?

no，I using Sougou IME

same problem, still not fixed yet. This problem can be produced when the preview tab is opened. I encountered this problem when I use latex-workshop.

This is already fixed as we upgraded Electron with the fix for CJK IME.


feat: add some better value selection when providing multiple keys

🧰 Changes

Return with a value from the top level if it's not set in the keys[]
Return with a default if it's not set in the keys[]
Do not render a dropdown if the value hasn't come from the keys[]
Do not render a dropdown if there's only one value in the keys[]

🧬 QA & Testing
Do the tests pass? ✅
I've tested this npm linked into ReadMe but I wanna do a little more full QA to ensure all of these different edge cases are working as expected over there.

lgtm, @domharrington want me to merge and tag a release for you?

@erunion yes please 🙏


Provide filters like Liquid?

I have been using Liquid with Jekyll and have found it very trivial to do standard filters for some of the data.
I have also been using handlebars quite a bit for my node projects, but find that I need to write helpers all the time for any tiny manipulation or having more logic than an if statement.
I wonder if something like this would be useful in Handlebars? I don't think all the functionality of liquid is useful but chainable filters sound like something that would make me write less helper functions.

I don't think this is a feature we're likely to add to Handlebars. If you'd like to chain multiple filters, I'd suggest implementing a filter helper that takes a property and array of filter names.


Deploy using CLI - specify APIs to be enabled before deploying

It would be great if it would be specified which APIs you need to enable (Compute Engine, Deployment manager, IAM, Kubernetes Engine API) before you can actually run the kubeflow deployment script.
https://www.kubeflow.org/docs/gke/deploy/deploy-cli/

Thanks for raising this issue @Svendegroote91. We do have an item in the "Before you start" section of the CLI guide, saying that the GCP project must meet the minimum requirements described in the project setup guide. The setup guide lists the required APIs. It's tricky to repeat all the info in the CLI guide, as it would make the guide really long.
I'm going to close this issue as answered, but please do re-open it if you think we should do more work on it.
/close


upgrade box2D

libgdx currently uses 2.3.1?

[x] update: 2.4.1: https://github.com/libgdx/libgdx/pull/7144
[ ] update: box2c (when released)

86fe47a

box2d 2.4.2 and v3 are out.

[ ] wait for gdx-jnigen 3.0 https://github.com/libgdx/gdx-jnigen
[ ] wait for someone to make java bindings, or attempt it myself
[ ] update to v3!


Have there any way to refresh the table without lose filters or searches?

Sometimes, i need to redraw the table with the last search/filters but if i reload the page or if i redraw the table all these parameters will be lost.
I have an application where i fire operations by custom buttons and i need to show the changes in the table but i don't want to lose the result set that i have because i need to keep working with the other rows.
Is this possible?

https://github.com/Laravel-Backpack/CRUD/issues/516#issuecomment-283755231 might be relevant here.

Hmm... there isn't an official way to do this, no. But in your buttons javascript you might be able to refresh the DataTables object, if you using AjaxDataTables.
Hope it helps. Cheers!


Revamp wallet selection screen

See Figma.
The current screen is fine and works well. The UI in Figma does look a bit better though.

Looks like it only needs some minor changes to match the design, I think I can do this one this week sometime.

Started a PR for this #64


!stats and !hash commands not working on LBRY Discord Server

please see #market-and-trading channel
julie and btzr trying to input key !stats but not working

on #mining the code !hash working but i saw error code like this screenshot

Both are now working!


preview of pdf in chrome does not stop page reloading

doc.output("dataurlnewwindow"); when i use this statement pdf open new tab and page does not stop reloading untill when i stop it .how to stop page reloading please tell.

Has anyone solved this?


Add Support for Shahmukhi Transliteration

https://www.google.com/get/noto/#nastaliq-aran
This font should be used when rendering Shahmukhi.

Also, should this be renamed toUrdu?


Requestify Inferring Generic Requirements

Unify a bunch of quasi-independent callsites into a single request that
builds up a generic signature from a variety of inference sources.  This
draws the extension typealias workaround for SE-0229 into TypeCheckDecl
where we can better work on refactoring it.  The goal is to use this as
a springboard to requests that compute generic environments for various
and sundry decls.

Unfortunately, only code structure improvements in this one.  No perf improvements from laziness - seems like we were already doing a pretty good job of minimizing our construction of GSBs here.

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 87047d067e733b4d68be913b3763609eab1fa02a

Build failed
Swift Test Linux Platform
Git Sha - 87047d067e733b4d68be913b3763609eab1fa02a

@swift-ci please test

@swift-ci please test

⛵


Issue 3205 improve from input value

Added Helper function to get node name from node path format
updated secure-channel create to use the helper function

Checks

[x] All commits in this Pull Request are signed and Verified by Github.
[x] All commits in this Pull Request follow the Ockam commit message convention.
[x] I accept the Ockam Community Code of Conduct.
[x] I have accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam-contributors repository.

@michealkeines the changes look great.
I amended the commit messages a bit, ran cargo fmt and force pushed to your branch so please rebase accordingly for your other PR.
This one will merge shortly after the CI checks pass.

@michealkeines Thank you for another awesome contribution 🥳 🎈


createSTXPostCondition and createFungiblePostCondition allows to create invalid post conditions.

Describe the bug
Both createSTXPostCondition and createFungiblePostCondition accepts values higher than<PHONE_NUMBER>3709551615 (max value of u64) and as a result they produce invalid post-conditions.
From https://github.com/stacksgov/sips/blob/main/sips/sip-005/sip-005-blocks-and-transactions.md

A STX post condition body is encoded as follows:
...
An 8-byte value encoding the literal number of microSTX
A Fungible token post-condition body is encoded as follows:
...
An 8-byte value encoding the literal number of token units

8-byte value (u64) not 16-byte value (u128)

Thanks for reporting this — I will look into it


adding latest sync to api docs

Fixes #260
Changes in this pull request:

updated zone model to include the latest sync
updated examples to include the latest sync

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.avishn955 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Merged! Thanks for the contribution @vishnyakova!


Document managing sensitive strings (secrets)

Problem description
Document feature described in:

https://github.com/docker/docker/pull/27794
https://github.com/docker/docker/pull/28306

Project version(s) affected
Engine 1.13
Suggestions for a fix

cc/ @ehazlett

/cc @diogomonica @cyli

Closed via #568


Add pyproject.toml for Custom Node Registry

We are building a global registry for custom nodes (similar to PyPI). The registry makes using custom nodes more reliable by reserving globally unique names for each custom node, and supporting semantic versioning.
Here’s some more information on the registry.
Action Required:

[ ] Go to the registry. Login and create a publisher id. Comment it here and we will update the PR (or just merge it and change it yourself).
[ ] Write a short the description.
[ ] Merge the separate Github Actions PR and run the workflow.
If you want to publish the node manually, install the cli and run comfy node publish

Please message me on Discord if you have any questions!

hey @YMC-GitHub, wanted to send a small nudge and ask if you had any questions!

@YMC-GitHub, wondering if there's any way we can support you on this PR!


upgrade to go 1.19.7

picking up CVE fixes
Holding 1.20 until after #181
I think we're not actually affected by these because GCLB / cloud run sit in front but I'm not sure that's true either.
It's probably better to patch against these.

/approve
/lgtm


Inverse square root

An inverse square root is a rather popular function. Would be nice to have it. Wikipedia suggests a constexpr implementation. Further sections also reference research on better magic number, e.g. 10.1109/JPROC.2020.2991885.

I've added a basic inv_sqrt function to the library, but it is not a constexpr version of the fast inverse square-root function. The suggestion in that article requires C++20 functionality.


Multicluster installation failed with function "valueOrDefault" not defined

Bug description
When doing multicluster installation following https://preliminary.istio.io/docs/setup/install/multicluster/gateways/,  it gives below error.
>istioctl manifest apply  -f manifests/examples/multicluster/values-istio-multicluster-gateways.yaml
Detected that your cluster does not support third party JWT authentication. Falling back to less secure first party JWT. See https://istio.io/docs/ops/best-practices/security/#configure-third-party-service-account-tokens for details.
Error: failed to apply manifests: template: :263: function "valueOrDefault" not defined

Error happens on  both1.6.0-beta.1 and 1.6.0-beta.0.
Expected behavior
Successful Installation
Steps to reproduce the bug
>istioctl manifest apply  -f manifests/examples/multicluster/values-istio-multicluster-gateways.yaml
Version (include the output of istioctl version --remote and kubectl version and helm version if you used Helm)
1.6.0-beta.1
1.6.0-beta.0
Environment where bug was observed (cloud vendor, OS, etc)
kubernetes 1.16
ubuntu 18.04

I am seeing the same on beta.1 (and also on Master with istioctl manifest apply -f operator/data/examples/multicluster/values-istio-multicluster-gateways.yaml.)

@ostromart sounds like we are trying to template the IOP when we shouldn't?

duplicate of https://github.com/istio/istio/issues/23711


0.11.0 beta 1 and 2: commands not registered on macOS

Brief Issue Summary
Any attempt to run a cmake-tools command results with an error message similar to:

Error: command 'cmake.setVariant' not found

CMake Tools Log
[variant] Loaded new set of variants
[kit] Failed to check binary /usr/bin/clang by exception: Error: spawn stdbuf ENOENT
[kit] Failed to check binary /usr/bin/gcc by exception: Error: spawn stdbuf ENOENT
[kit] Failed to check binary /usr/local/bin/gcc-7 by exception: Error: spawn stdbuf ENOENT

Developer Tools Log
[Extension Host] debugger listening on port 9333
extensionHost.ts:200 [Extension Host] debugger inspector at %cDebugger listening on port 9333.
Warning: This is an experimental feature and could change at any time.
To start debugging, open the following URL in Chrome:
    chrome-devtools://devtools/bundled/inspector.html?experiments=true&v8only=true&ws=<IP_ADDRESS>:9333/59759204-b550-446c-8e05-fb920a169b7a

extensionService.ts:656 [/Users/sterin/.vscode/extensions/ms-vscode.cpptools-0.14.5]: Command `workbench.action.gotoSymbol` appears multiple times in the `commands` section.
extensionService.ts:656 [/Users/sterin/.vscode/extensions/ms-vscode.cpptools-0.14.5]: Command `workbench.action.showAllSymbols` appears multiple times in the `commands` section.
console.ts:123 [Extension Host] [CMakeTools] 2017-12-21T04:28:51.045Z [debug] [main] Safe constructing new CMakeTools instance
console.ts:123 [Extension Host] [CMakeTools] 2017-12-21T04:28:51.047Z [debug] [kit] Constructing KitManager
console.ts:123 [Extension Host] [CMakeTools] 2017-12-21T04:28:51.047Z [debug] [variant] Constructing VariantManager
console.ts:123 [Extension Host] [CMakeTools] 2017-12-21T04:28:51.049Z [debug] [main] Constructing new CMakeTools instance
console.ts:123 [Extension Host] [CMakeTools] 2017-12-21T04:28:51.050Z [debug] [main] Starting CMakeTools second-phase init
console.ts:123 [Extension Host] [CMakeTools] 2017-12-21T04:28:51.051Z [debug] [rollbar] Checking Rollbar permissions
console.ts:123 [Extension Host] [CMakeTools] 2017-12-21T04:28:51.051Z [debug] [rollbar] Rollbar enabled?  true
console.ts:123 [Extension Host] [CMakeTools] 2017-12-21T04:28:51.123Z [info] [variant] Loaded new set of variants
console.ts:123 [Extension Host] [CMakeTools] 2017-12-21T04:28:51.126Z [debug] [kit] Second phase init for KitManager
console.ts:123 [Extension Host] [CMakeTools] 2017-12-21T04:28:51.127Z [debug] [kit] Rescanning for Kits
console.ts:123 [Extension Host] [CMakeTools] 2017-12-21T04:28:51.129Z [debug] [kit] Scanning for Kits on system
console.ts:123 [Extension Host] [CMakeTools] 2017-12-21T04:28:51.131Z [debug] [kit] Scanning directory /Users/sterin/.local/bin for compilers
console.ts:123 [Extension Host] [CMakeTools] 2017-12-21T04:28:51.131Z [debug] [kit] Scanning directory /usr/local/bin for compilers
console.ts:123 [Extension Host] [CMakeTools] 2017-12-21T04:28:51.131Z [debug] [kit] Scanning directory /usr/bin for compilers
console.ts:123 [Extension Host] [CMakeTools] 2017-12-21T04:28:51.131Z [debug] [kit] Scanning directory /bin for compilers
console.ts:123 [Extension Host] [CMakeTools] 2017-12-21T04:28:51.132Z [debug] [kit] Scanning directory /usr/sbin for compilers
console.ts:123 [Extension Host] [CMakeTools] 2017-12-21T04:28:51.132Z [debug] [kit] Scanning directory /sbin for compilers
console.ts:123 [Extension Host] [CMakeTools] 2017-12-21T04:28:51.132Z [debug] [kit] Scanning directory /opt/X11/bin for compilers
console.ts:123 [Extension Host] [CMakeTools] 2017-12-21T04:28:51.132Z [debug] [kit] Scanning directory /Developer/Panda3D/bin for compilers
console.ts:123 [Extension Host] [CMakeTools] 2017-12-21T04:28:51.132Z [debug] [kit] Scanning directory /Library/Frameworks/Mono.framework/Versions/Current/Commands for compilers
console.ts:123 [Extension Host] Activating extension `vector-of-bool.cmake-tools` failed: spawn stdbuf ENOENT.
t.log @ console.ts:123
console.ts:123 [Extension Host] Activating extension `vector-of-bool.cmake-tools` failed:  spawn stdbuf ENOENT
t.log @ console.ts:123
console.ts:123 [Extension Host] Here is the error stack:  Error: spawn stdbuf ENOENT
	at exports._errnoException (util.js:1050:11)
	at Process.__dirname.ChildProcess._handle.onexit (internal/child_process.js:193:32)
	at onErrorNT (internal/child_process.js:367:16)
	at _combinedTickCallback (internal/process/next_tick.js:80:11)
	at process._tickCallback (internal/process/next_tick.js:104:9)
extensionService.ts:652 Activating extension `vector-of-bool.cmake-tools` failed: spawn stdbuf ENOENT.
t._logMessageInConsole @ extensionService.ts:652
console.ts:123 [Extension Host] [CMakeTools] 2017-12-21T04:28:51.234Z [debug] [kit] Found 0 kits in directory /Users/sterin/.local/bin
console.ts:123 [Extension Host] [CMakeTools] 2017-12-21T04:28:51.252Z [debug] [kit] Found 0 kits in directory /bin
console.ts:123 [Extension Host] [CMakeTools] 2017-12-21T04:28:51.280Z [debug] [kit] Found 0 kits in directory /sbin
console.ts:123 [Extension Host] [CMakeTools] 2017-12-21T04:28:51.306Z [debug] [kit] Testing Clang-ish binary: /usr/bin/clang
console.ts:123 [Extension Host] [CMakeTools] 2017-12-21T04:28:51.344Z [debug] [kit] Testing GCC-ish binary: /usr/bin/gcc
console.ts:123 [Extension Host] [CMakeTools] 2017-12-21T04:28:51.490Z [warning] [kit] Failed to check binary /usr/bin/clang by exception: Error: spawn stdbuf ENOENT
t.log @ console.ts:123
console.ts:123 [Extension Host] [CMakeTools] 2017-12-21T04:28:51.491Z [warning] [kit] Failed to check binary /usr/bin/gcc by exception: Error: spawn stdbuf ENOENT
t.log @ console.ts:123
console.ts:123 [Extension Host] [CMakeTools] 2017-12-21T04:28:51.532Z [debug] [kit] Found 0 kits in directory /usr/sbin
console.ts:123 [Extension Host] [CMakeTools] 2017-12-21T04:28:51.556Z [debug] [kit] Found 0 kits in directory /opt/X11/bin
console.ts:123 [Extension Host] [CMakeTools] 2017-12-21T04:28:51.572Z [debug] [kit] Found 0 kits in directory /Developer/Panda3D/bin
console.ts:123 [Extension Host] [CMakeTools] 2017-12-21T04:28:51.590Z [debug] [kit] Found 0 kits in directory /Library/Frameworks/Mono.framework/Versions/Current/Commands
console.ts:123 [Extension Host] [CMakeTools] 2017-12-21T04:28:51.618Z [debug] [kit] Testing GCC-ish binary: /usr/local/bin/gcc-7
console.ts:123 [Extension Host] [CMakeTools] 2017-12-21T04:28:51.718Z [warning] [kit] Failed to check binary /usr/local/bin/gcc-7 by exception: Error: spawn stdbuf ENOENT
t.log @ console.ts:123
console.ts:123 [Extension Host] rejected promise not handled within 1 second
t.log @ console.ts:123
mainThreadExtensionService.ts:43 [vector-of-bool.cmake-tools]Accessing CMake driver too early!
e.$onExtensionRuntimeError @ mainThreadExtensionService.ts:43
mainThreadExtensionService.ts:44 Error: Accessing CMake driver too early!
	at new CMakeTools (/Users/sterin/.vscode/extensions/vector-of-bool.cmake-tools-0.11.0-beta2/out/src/cmake-tools.js:75:44)
	at Function.create (/Users/sterin/.vscode/extensions/vector-of-bool.cmake-tools-0.11.0-beta2/out/src/cmake-tools.js:284:22)
	at activate (/Users/sterin/.vscode/extensions/vector-of-bool.cmake-tools-0.11.0-beta2/out/src/extension.js:24:45)
	at Function.t._callActivateOptional (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:512:370)
	at Function.t._callActivate (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:512:54)
	at /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:511:329
	at Object.g [as _notify] (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:67:449)
	at Object.enter (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:70:778)
	at n.Class.derive._oncancel._run (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:72:573)
	at n.Class.derive._oncancel._completed (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:72:14)
e.$onExtensionRuntimeError @ mainThreadExtensionService.ts:44

Platform and Versions

Operating System: macOS (High Sierra)
CMake Version: 3.9.4
VSCode Version: 1.19.1
CMake Tools Extension Version: 0.11.0 beta 2
Compiler/Toolchain: Apple clang

Eh... I see the problem. It's trying to run stdbuf, but macOS doesn't seem to have that?

It doesn't have stdbuf by default.
I installed stdbuf using Homebrew (part of the coreutils package) and added into PATH to test it and it seems to work now.

Should be fixed in next (beta?) release


[SYSTEMML-853] Python API for new MLContext

This is the Python API for the new MLContext
Here is a quick example
sums = """
s1 = sum(m1)
s2 = sum(m2)
s3 = 'whatever'
"""
ml = MLContext(sc)
rdd1 = sc.parallelize(["1.0,2.0", "3.0,4.0"])
rdd2 = sc.parallelize(["5.0,6.0", "7.0,8.0"])
dml = Dml(sums).input(m1=rdd1).input(m2=rdd2).out("s1", "s2", "s3")
ml.execute(dml).get("s1", "s2", "s3")
[10.0, 26.0, "whatever"]

The tests cases should explain the other use cases.

@frreiss I believe, I have addressed your comments right now. The API should be consistent with that on the Java side. Could you make another pass?

@frreiss @dusenberrymw @niketanpansare
Is this ready to merge?

Thank you for looking at this @dusenberrymw.

@MechCoder This is great!  Here's a list of things I tried out, along with some additional thoughts:

Tried this out the example on Python 3.

Can you update the example in the initial post to reflect the recent update, as in:
sums = """
s1 = sum(m1)
s2 = sum(m2)
s3 = 'whatever'
"""
ml = MLContext(sc)
rdd1 = sc.parallelize(["1.0,2.0", "3.0,4.0"])
rdd2 = sc.parallelize(["5.0,6.0", "7.0,8.0"])
dml = Dml(sums).input(m1=rdd1).input(m2=rdd2).out("s1", "s2", "s3")
ml.execute(dml).get("s1", "s2", "s3")
[10.0, 26.0, "whatever"]

Ran the Python tests with spark-submit (after adding the missing comma).

I used PYSPARK_PYTHON=python3 spark-submit --master local[*] --driver-class-path $SYSTEMML_HOME/target/SystemML.jar --py-files=$SYSTEMML_HOME/python/SystemML.py $SYSTEMML_HOME/python/SystemMLtests.py

Tried to alter the script so that s2 would return a matrix, i.e. s2 = m1 * 3.

Right now, this just returns a Java object reflecting a mlcontext.Matrix type that was added (  @deroneriksson correct if this is wrong).  We should add a Matrix type to our Python API here, and then add some logic to convert this to a DataFrame, RDD, etc. as is done on the Java/Scala side.  Should just be another simple wrapper over [1].

Some other thoughts:

Can you move the files from python/ to src/main/python just for consistency with the Java and Scala code?  I know Spark has a python/ folder, but they also have the project split into multiple modules, so they have to consolidate the Python code into a single top-level python/ folder to allow for imports to work properly.  We only have one single module, so that won't be a problem.
In a follow-up PR, could you look into adding a setup.py file and any other requirements so that we could create a pip package?  Then we could allow for pip installs directly from the git repo, using a subdirectory flag pointing to src/main/python [2].

[1]: http://apache.github.io/incubator-systemml/spark-mlcontext-programming-guide#matrix-output
[2]: http://stackoverflow.com/a/36074026

@dusenberrymw
I believe right now get() returns a SystemML MatrixObject if dealing with a matrix. We should probably have it return a Matrix (very easy to do in a couple lines of code). However, perhaps we could do this in a separate followup JIRA/PR, along with adding a Matrix type to the Python API?

@deroneriksson Good idea -- @MechCoder Can you (1) update the given example, (2) add the missing comma to that test, and (3) move the source code to the other location for this PR?  Then you could add the Matrix logic in a followup PR.
Also, you write great, clean Python code, @MechCoder! 👍

@dusenberrymw @MechCoder
I believe the get method can return the 'right' type (Matrix) with something like the following (off the top of my head):
public Object get(String outputName) {
      Data data = getData(outputName);
      if (data instanceof ScalarObject) {
            ScalarObject so = (ScalarObject) data;
            return so.getValue();
      else if (data instanceof MatrixObject) {
            return getMatrix(outputName);
      } else {
            return data;
      }
}

Thanks @dusenberrymw @deroneriksson! I've moved it. We can address other stuff in followup PR's

Awesome, LGTM.  Thanks, @MechCoder!

Merged.  Thanks, @MechCoder!


SUBMARINE-857. Image should be built locally in github-action

What is this PR for?
The current image is pulled from docker hub so the change in images will not be reflected immediately.
I revised the workflow files and build the images before deploying the cluster.
Also, I used Github action cache to cache docker layer to accelerate.
What type of PR is it?
[Bug Fix]
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-867
How should this be tested?
Screenshots (if appropriate)
Questions:

Do the license files need updating? No
Are there breaking changes for older versions? No
Does this need new documentation? No

@jeff-901 Help me review the code. Thanks!

@jeff-901 Help me review the code. Thanks!

LGTM


StackSetInstance fails when deploying to ou with no accounts

What happened?
I am setting up a new OU and applying an stackset to that OU but the OU has no accounts in it yet as of the moment of creation.
If I create an StackSetInstance at that moment the resource returns an error because no stacks were deployed but when I look in the AWS console the operation was successful.
The reason I do this is because I want to enable automatic deployment on that OU alone.
Example
Steps to recreate:

Create a new OU
Create a StackSet (Or use an existing.)
Apply an StackSetInstance to that OU with deployment_targets
Error!

Output of pulumi about
CLI
Version      3.84.0
Go Version   go1.21.1
Go Compiler  gc
Plugins
NAME    VERSION
aws     5.42.0
python  3.10.12
Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

Hello @ruben-janssens thank you for reporting this issue.
Could you please provide a code snippet that I can run locally to reproduce the issue?

I think this should be enough. Just some copy paste from my original code.
import json
from pulumi import ResourceOptions, InvokeOptions
from pulumi_aws.organizations import OrganizationalUnit, get_organization
from pulumi_aws.cloudformation import StackSet, StackSetAutoDeploymentArgs, StackSetInstance, StackSetInstanceDeploymentTargetsArgs

suspended_ou = OrganizationalUnit(
    "Suspended",
    name="Suspended",
    parent_id=get_organization(opts=InvokeOptions()).roots[0].id
)

role_stackset = StackSet(
            f"MyStackSet",
            name="MyStackSet",
            permission_model = "SERVICE_MANAGED",
            auto_deployment=StackSetAutoDeploymentArgs(
                enabled=True,
                retain_stacks_on_account_removal=False
            ),
            capabilities=["CAPABILITY_NAMED_IAM"],
            template_body=json.dumps(
                {
                    "Resources" : {
                        "Role" : {
                            "Type" : "AWS::IAM::Role",
                            "Properties" : {
                                "RoleName" : "MyUniqueRoleName",
                                "AssumeRolePolicyDocument" : {
                                    "Version" : "2012-10-17",
                                    "Statement" : [
                                        {
                                            "Effect" : "Allow",
                                            "Principal": {
                                                "AWS": "000000000000"
                                            },
                                            "Action": "sts:AssumeRole"
                                        }
                                    ]
                                }
                            }
                        }
                    }
                }
            )),
            opts=ResourceOptions(ignore_changes=["administrationRoleArn"])
        )

        StackSetInstance(
           "Instance",
            stack_set_name=role_stackset.name,
            deployment_targets=StackSetInstanceDeploymentTargetsArgs(
                organizational_unit_ids=[suspended_ou.id]
            )
        )

@ruben-janssens Thank you for the snippet! And what is the error that you are getting?

I currently do not have my code open to execute it, but it was something in the trend of not being able to find the ID of the stackset instance. I assume this references a stackset instance for an account but because none exist it throws an error.

This sounds like it has to be an upstream issue but without a concrete error message it's a bit hard to point out the exact one. Maybe https://github.com/hashicorp/terraform-provider-aws/issues/27877? There are quite a few of those: https://github.com/hashicorp/terraform-provider-aws/issues?q=is%3Aissue+is%3Aopen+aws_cloudformation_stack_set_instance

I ran it again and here is the error:
aws:cloudformation:StackSetInstance (MyStackSet):
    error: 1 error occurred:
        * updating urn:pulumi:production::pulumi-project::custom:ResourceStuff$aws:cloudformation/stackSetInstance:StackSetInstance::MyStackSet: 1 error occurred:
        * reading CloudFormation StackSet Instance (MyStackSet,,eu-west-1): unexpected format for ID (MyStackSet,,eu-west-1), expected STACKSETNAME,ACCOUNTID,REGION

@ruben-janssens Thank you! Then it looks like this upstream issue: https://github.com/hashicorp/terraform-provider-aws/issues/23349
Please upgrade to 6.x version of Pulumi AWS that includes the fix for it.


Focus lock not working [a6000]

Hi,
I did recently discover that while using this app on my a6000, the focus cannot be locked. Even if I set the camera to manual mode before launching the app, it will still refocus between the shots.
Is it possible to add focus lock switch to the app itself? It would be also useful for those timelapses from sunset into the night when you need to leave the exposure settings to the camera.
If you want any more info/feedback, I'll be happy to help.

Hi smensak,
you are right, I never noticed that, because I often shoot time lapses with manual focus lenses.
I'll have a look into it and see if it is possible for the next version.
Thanks for your feedback!

I'm happy to announce that the new version 1.4 can now be set to manual focus.

Thank you, great news! I'll test it soon.

Happy to report that manual focus is indeed fully functional on my a6000.


Faster in-memory weight transfer for transformers-neuronx

Overview
This PR improves the latency of transferring model weights from the HF representation to the INF2 representation by doing it in-memory as opposed to using the disk as a buffer.  For OPT-66B on inf2.48xl, this improves the latency of weight transfer from 840s to 5s.
Description
Splitting the model into small pieces on the disk and then loading it, reduces CPU memory requirements. However, this operation demands high IOPS from the disk. Typical EBS volumes used by EC2 (gp3) and SageMaker (gp2) do not provide high IOPS by default. This leads to EBS throttling, which manifests as a massive latency to transfer model weights (upto 1400 secs).
However, Large Language Models are typically used with large instances with large CPU memory. As a result, for instances like inf2.24xl, inf2.48xl, trn1.32xl, loading from disk is wasteful in terms of instance hours. Direct in-memory transfer is much faster (<5s) in these cases.
This PR modifies the load_model code path to first try in-memory loading and then fall back to disk loading in the event of an overflow.
Testing
Tested in EC2 on inf2.48xl and inf2.24xl with OPT-66B and OPT-13B

Additionally tested facebook/opt-1.3b and OpenAssistant/llama2-13b-orca-8k-3319 on inf2.24xl (EC2)


Crypt key

this adds the option to use the timestamp + signature/MD5  as credentials.

I just realized that there is a HUGE 2.0 coming in. Will wait and redo this after that.

@joshp23 I've done this for you. It wasn't a big change so I've included it manually in v2. Please try to upgrade and let me know how you get on. There's a lot of changes to the API (some breaking), so please have a read through the (comparatively huge) readme file first.

coolio


Test PR

Description

Checklist:

[ ] I have tested my changes. No regression in existing tests.
[ ] My code is Linted.

/bot run checks


[UI + Logic] Added a 'weather' command to open a URL on Browser

(This PR includes the "Randomize color of the background theme between Black and White" PR enhancements)

Added a page in part 3 about displaying tourism components in DeveloperGuide.adoc
Added 1 test for 'weather' command.

This branch has this conflict due to editing in the same file 'MainWindow.java' as @aungmyin23, with similiar function.


Refactor: Continued work on reducing async state machines

Resolved / Related Issues

[x] Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.

Continues work on #9871.

Validation
How did you test these changes?

[x] Did you build the app and test your changes?
[ ] Did you check for accessibility? You can use Accessibility Insights for this.
[ ] Did you remove any strings from the en-us resource file?

[ ] Did you search the solution to see if the string is still being used?

[ ] Did you implement any design changes to an existing feature?

[ ] Was this change approved?

[ ] Are there any other steps that were used to validate these changes?

Open app ...
Click settings button ...

Screenshots (optional)
Add screenshots here.

Will do in a few hours, I'm busy right now.

@yaira2 Should be done now, feel free to merge.

@itsWindows11 thank you! Can you fill out the section with steps to test these changes? It should include any areas that might be affected.

There are so many ways these changes could be tested, but I'll try to fill in some now.

Just finished with filling in the steps (it's not really steps anyway but it involves testing different features).


Update docs for alarm to use 5 fields cron syntax by default

docs examples should show 5 fields, like typical/standard cron syntax
Users are getting confuse with 6 fields by having the first field be seconds and not minutes
the cron variable still supports 6 fields, but it should be noted as an custom syntax for users that might want to specify sub-minute granularity.
cc @bjustin-ibm

this is already done


Is it safe to add indexes on a replicated (slave) collection ?

My Environment

ArangoDB Version:        e.g. 3.3.19
Storage Engine:            RocksDB
Deployment Mode:       Master/Slave
Infrastructure:               own
Operating System:        Debian 9
Used Package:              Debian or Ubuntu .deb

This is just a question
I read in the doc that replicated collections on slave nodes should be treated as readonly, ie. one should not add / modify / delete documents on the slave.
But is it OK to add indexes that are not present on the master ?
Thank you
Mathias

A problem with this aproach that comes to my mind is, that if you specify a uniq restriction that isn't there on the leader you may get out of sync.
Also indices always come at a cost.
Closing this with the availability of ArangoDB 3.7 as out of date.


Marathon Mode

#Marathon Mode
Summary
Implement a new Marathon Mode in the falling blocks game, where the player must survive for as long as possible by clearing a target number of blocks while managing increasing speed and difficulty.
Description
In Marathon Mode, the objective is to clear a predefined number of lines (e.g., 100 lines) as quickly as possible. Unlike Endless Mode, which continues indefinitely, this mode challenges the player to reach the goal in the shortest time while maintaining control over the falling blocks.
Requirements

Add Marathon Mode to the game mode selection in the main menu.
Implement mechanics to track line clears and display the target (e.g., “Lines Cleared: 45/100”).
Implement a progressively increasing speed for falling blocks, making the game more difficult as the player clears more lines.
Display the time elapsed during gameplay.
Add a scoring system that rewards players based on:

Time taken to reach the target.
Line clearing efficiency (e.g., clearing multiple lines at once).

Ensure the game ends when either:

The player clears the required number of lines.
The stack of blocks reaches the top of the screen.

Completion Criteria

The player can complete a game of Marathon Mode by clearing a set number of lines.
The game tracks the number of lines cleared and displays this information to the player.
The difficulty increases as the game progresses (e.g., blocks fall faster or are more complex).
The game ends appropriately when the target is reached or when the stack of blocks reaches the top.
The final score reflects the time taken and efficiency in clearing lines.
Marathon Mode is fully integrated into the main menu and functions smoothly without major bugs or gameplay interruptions.

Approved

Approved


Cow: Watch edutrainex.com

Cow requests the watch of the watch_keyword edutrainex\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

edutrainex\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by tripleee in Charcoal HQ


Display Failed Task Information in Finally Task

Currently, when a pipeline fails, the Finally task is executed.
I can trigger a failed or succesfull Finally with (as an example):
      when:
        - input: $(tasks.status)
          operator: in
          values: ["Failed"]

However, $(tasks.status)  does not provide information about which task failed. I would like to see a parameter that is passed to the Finally task, indicating which task failed This information could be used in a script to post to GIT (comit/PR) for example, indicating which task failed and why and maybe provide some context.
I've tried tasks[*] for example. But that doesnt work (see https://tekton.dev/docs/pipelines/variables/)

@BlueCog while I'm looking into this issue, a quick way to expose that information is by using the individual task statuses exposed as tasks.<task-name>.status. You can add an array type parameters for each task to your finally task in the form of ["<task-name>", "$(tasks.<task-name>.status)"]. These values can be combined into a single array and passed down to the script executed by the step, where you can find the the failed task. See an example here https://gist.github.com/enarha/2b40161c92d2ee921f9d56d1b3eb0409 .

/remove-lifecycle stale

Hi @enarha (do I spot Superfly as your avatar? :D),
Thanks for getting back at me.
I'm doing some editing on Tekton pipelines and just remembered this issue. I did some digging and it seems my initial question is still not possible, or at least not easily via a variable. Am I right?
I looked into your solution posted here but I was not able to get it to work. I'm getting a lot of errors from the API (probably a lot has changed in the meantime).
But this still feels a bit "hacky"? Wouldnt it be awesome if we could query the Tekton variable tasks so we would retrieve all tasks.<pipelineTaskNames> and the corresponding status?
For now, I got it to work like this (taking your solution in account):
Pipeline params:
      - name: task-result-init
        value: "task-result-init|$(tasks.init.status)"
      - name: task-result-build
        value: "task-result-build|$(tasks.build.status)"
      - name: task-result-check
        value: "task-result-check|$(tasks.check.status)"
      - name: task-result-analyse
        value: "task-result-analyse|$(tasks.analyse.status)"
      - name: task-result-release
        value: "task-result-release|$(tasks.release.status)"

Finally:
params:
    - name: task-result-init
      type: string
      default: "no value"
    - name: task-result-build
      type: string
      default: "no value"
    - name: task-result-check
      type: string
      default: "no value"
    - name: task-result-analyse
      type: string
      default: "no value"
    - name: task-result-release
      type: string
      default: "no value"

  steps:
    - name: set-status
      image: $(params.task-image)
      workingDir: $(workspaces.repo.path)
      script: |
        #!/bin/bash

        echo "PipelineRun name: $(params.pipelineRun-name)"

        IFS='|' read -r task_name_init task_status_init <<< "$(params.task-result-init)"
        IFS='|' read -r task_name_build task_status_build <<< "$(params.task-result-build)"
        IFS='|' read -r task_name_check task_status_check <<< "$(params.task-result-check)"
        IFS='|' read -r task_name_analyse task_status_analyse <<< "$(params.task-result-analyse)"
        IFS='|' read -r task_name_release task_status_release <<< "$(params.task-result-release)"

        print_task_results() {
          local task_name="$1"
          local task_status="$2"
          echo "$task_name results: $task_status"
        }

        print_task_results "$task_name_init" "$task_status_init"
        print_task_results "$task_name_build" "$task_status_build"
        print_task_results "$task_name_check" "$task_status_check"
        print_task_results "$task_name_analyse" "$task_status_analyse"
        print_task_results "$task_name_release" "$task_status_release"

Is there any update on this?
Is there a possibility that this funcionality will be implemented in te future? That the name of failed task(s) is passed to the finally of a pipeline?


Avalonia views render 3 times slower after adding Velvet.Library.Avalonia.Font.Awesome icons

Greetings!
First, I love the ability to merge glyphs.
Unfortunately, my Avalonia views render 3 times slower after adding Velvet.Library.Avalonia.Font.Awesome icons.
Please advise how to optimize.
Thanks

Greetings!
First, I love the ability to merge glyphs.
Unfortunately, my Avalonia views render 3 times slower after adding Velvet.Library.Avalonia.Font.Awesome icons.
Please advise how to optimize.
Thanks


Got this bug

Environment

0.18.1:
3.8.11:
Windows 11:

What is happening?
C:\Users\Ahmad\anaconda3\envs\qc_env\lib\site-packages\qiskit\transpiler\runningpassmanager.py:166: UserWarning: Resynthesized [<qiskit.dagcircuit.dagnode.DAGNode object at 0x0000012850F1C580>, <qiskit.dagcircuit.dagnode.DAGNode object at 0x0000012850FC3880>] and got global phase: π/2
      ┌────────┐┌────┐┌────────┐
qr_0: ┤ Rz(-π) ├┤ √X ├┤ Rz(-π) ├
      └────────┘└────┘└────────┘, but the original was native and the new value is longer.  This indicates an efficiency bug in synthesis.  Please report it by opening an issue here: https://github.com/Qiskit/qiskit-terra/issues/new/choose
  new_dag = pass_.run(dag)

How can we reproduce the issue?
I have no idea, I'm trying to implement a satisfiability problem
What should happen?
dunno lol
Any suggestions?
No response

You're using a pretty old version of Terra - your issue says you're on 0.18.1, but the current release is 0.21.2.  If you're able to upgrade your version of Terra, you should see the error go away - see #7224, for example.


[Feature Request] A new WYSIWYG editor

Implement a modern WYSIWYG editor with markdown output.
We could go with raw HTML but we'd need to make Twig render it right away instead of sanitizing it into raw text.
One possible solution would be CKEditor 5. It has markdown output support.

ProseMirror is also excellent.

CKEditor 5 seems like a good option. It's well established and still under active development


Update dependency rack to v3

This PR contains the following updates:

Package
Update
Change

rack (changelog)
major
"~> 2.2" -> "~> 3.0"

Release Notes

rack/rack (rack)
v<IP_ADDRESS>
Compare Source
What's Changed

Fixed ReDoS in Accept header parsing [CVE-2024-26146]
Fixed ReDoS in Content Type header parsing [CVE-2024-25126]
Reject Range headers which are too large [CVE-2024-26141]

Full Changelog: https://github.com/rack/rack/compare/v3.0.9...v<IP_ADDRESS>
v3.0.9
Compare Source

Fix incorrect content-length header that was emitted when Rack::Response#write was used in some situations. (#2150, [@mattbrictson])

v3.0.8
Compare Source

Fix some unused variable verbose warnings. (#2084, [@jeremyevans], @skipkayhil)

v3.0.7
Compare Source

Make query parameters without = have nil values. (#2059, [@jeremyevans])

v<IP_ADDRESS>
Compare Source

[CVE-2023-27539] Avoid ReDoS in header parsing

v3.0.6
Compare Source

[CVE-2023-27539] Avoid ReDoS in header parsing

v3.0.5
Compare Source

Split form/query parsing into two steps. (#2038, @matthewd)

v<IP_ADDRESS>
Compare Source

[CVE-2023-27530] Introduce multipart_total_part_limit to limit total parts

v<IP_ADDRESS>
Compare Source

[CVE-2022-44571] Fix ReDoS vulnerability in multipart parser
[CVE-2022-44570] Fix ReDoS in Rack::Utils.get_byte_ranges
[CVE-2022-44572] Forbid control characters in attributes (also ReDoS)

v3.0.4
Compare Source

[CVE-2023-27530] Introduce multipart_total_part_limit to limit total parts

v3.0.3
Compare Source
Fixed

Rack::URLMap uses non-deprecated form of Regexp.new. (#1998, @weizheheng)

v3.0.2
Compare Source
Fixed

Utils.build_nested_query URL-encodes nested field names including the square brackets.
Allow Rack::Response to pass through streaming bodies. (#1993, [@ioquatix])

v3.0.1
Compare Source
Fixed

MethodOverride does not look for an override if a request does not include form/parseable data.
Rack::Lint::Wrapper correctly handles respond_to? with to_ary, each, call and to_path, forwarding to the body. (#1981, [@ioquatix])

v3.0.0
Compare Source

No changes

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: Gemfile.lock
Fetching gem metadata from https://rubygems.org/..........
Resolving dependencies...

Could not find compatible versions

Because sinatra >= 3.0.0, < 4.0.0 depends on rack >= 2.2.4, < 3.A
  and Gemfile depends on sinatra ~> 3.0,
  rack >= 2.2.4, < 3.A is required.
So, because Gemfile depends on rack ~> 3.0,
  version solving has failed.


Release notation-v1.0.0-alpha-1

Proposing we release notation-v1.0.0-alpha-1 as we have completed the milestone. Release process is defined here.
High level deliverables as as follows:

[ ] Decide on main commit for release
[ ]  Cut branch named v1.0.0-alpha-1 based on agreed upon main commit
[ ] Cut a tag named v1.0.0-alpha-1
[ ] Update README.md

/cc @SteveLasker @NiazFK  @justincormack @sajayantony
Can the maintainers please respond with a +1 comment once you are in favor of cutting this release.

+1


Remove redundant endpoints from manager

Currently, the manager service exposes the following endpoints:

POST to /identity
GET to /channels/{id}/messages
POST to /channels/{id}/messages

Since the first one is required only by the statefull protocol adapters to verify the token, it must be kept. However, the latter two should be merged into one that will return the publisher ID if access is allowed. Both of these endpoints will be used internally.

Addressed by #138.


Laravel 8.44.0 Shift

This pull request includes updates for the recent minor version release of Laravel as well as updates to your package dependencies. Feel free to commit any additional changes to the shift-ci-v8.44.0 branch.
Before merging, you need to:

Checkout the shift-ci-v8.44.0 branch
Review all pull request comments for additional changes
Run composer update
Test your application (no tests?)

:warning: You are running version 4.6.0 of spatie/laravel-translatable. The latest version is 5.0.0. You should review this dependency to see if you can upgrade to the latest version.

:information_source: If you are running PHP 8 be sure to run composer update locally to ensure you have the proper versions of your dependencies to reflect your PHP 8 environment.


Change pref name for ui.browsing.pageSize

(Related to I #2624)
Change the preference key name ui.gridPaginationSize to ui.browsing.pageSize.
@wetneb: per @tfmorris suggestion in I #2520, I would change the preference key.
Since it's the choices, is could also be: ui.browsing.pageSizeChoices. But that is probably too long.
Regards,
Antoine

For now this is only documented in the changelog as far as I know.

I added it to the growing list:
Ugh, Let me port the hack listing we have in an issue comment instead over to a a nice Wiki page!
DONE

Created new page "Preferences" https://github.com/OpenRefine/OpenRefine/wiki/Preferences

And updated our wiki Home - Preferences link to point to that new page.
Now we have a place to begin to document for @allanaaa and the technical writer all the Preferences that can be set.
We or @allanaaa can reorganize that listing on that wiki page at some point into a set of tables (with a column for expected type like Array, String, etc.)


Empty list results in empty pie chart window

Empty list results in empty pie chart window
Steps to recreate:

Clear EduTuTu with clear
Execute pie command

Expected result: No new window created
Actual result: Empty window created

Found issue in PieChartCommand, does not throw exception if filtered list is empty, fixed bug in PR


add raw method

overview
There is a lot of elastic search functionality that is not supported through the current static query types so this PR exposes a raw method that allows you to send any ES query directly.
Please let me know if there any changes you would like to make, otherwise, this would probably be best published as 0.4.0 but you could argue 0.3.2 as well. Please tag me after published to npm. Thanks for the great work on feathers!

Hey @xwa130, thanks for your contribution.
Would be great if you could add tests as well as documentation.
Cheers,
Jacek

Hi Jacek,
Thank you for your detailed comment. I would like to write test for this feature. But before I write this, the test didn't pass in my local machine. it says ES 'before all' hook is a bad request. The 'after all' hook also has some error which says no such index etc.
I am worried that if I need to do some things before I run npm test? Please let me know. Thank you!
Best,
Edward

Hi @xwa130,
There are slight differences between test setup for various versions of Elasticsearch, so in order to keep to choose the Elasticsearch version for tests you need to set the env variable ES_VERSION. Here's an example:
ES_VERSION=5.2.0 npm run test

I hope that helps.

Hi @jciolek,
Thank you for your support. I updated my codes and wrote what I have done in overview. Please look at it and @ me if it has any problems.

Hi @jciolek ,
I'm sorry to interrupt you. But how are my changes working? Does it work fine or you have any suggestion? Look forward to your reply. : )
Best,
Edward

@xwa130 @jciolek This is looking good now. I'm going to merge it and release as v0.4.0.


repository debug dump: support dumping artifacts

--repository-dump-dir currently dumps current metadata that repository is serving.
If it is seen useful, we could also output the targets we are serving:

could create the directory structure that the web server is using
the artifact filename should be hash prefixed I suppose

The use case I'm thinking of is manual debugging

Run test, dump repo
the dump content tries to accurately match the http server contents
user can run python -m http.server or similar and the manually run their client against that server to see what happens

the dump content tries to accurately match the http server contents

this does not happen currently: current dump tries to be as readable and diffable as possible so e.g. version numbers are not used in filenames

This might be something we want as it makes it possible to run other clients against a repository version (say, example client from python-tuf) for debugging purposes.
What would need to happen for metadata:

change the dump method so that every other metadata file is prefixed with version except timestamp
there should be an additional metadata directory, so e.g. if dump dir is /tmp/tuf-conformance-dump then test_basic_init_and_refresh metadata goes  in /tmp/tuf-conformance-dump/test_basic_init_and_refresh/refresh-1/metadata/

and then artifacts

artifacts for the same test go in /tmp/tuf-conformance-dump/test_basic_init_and_refresh/refresh-1/targets/
artifact targetpath subdirectories should be created and hash prefix should be used. so "a/artifact" would go in
/tmp/tuf-conformance-dump/test_basic_init_and_refresh/refresh-1/targets/a/<HASH>.artifact


Add instructions for getting tech notifications in Slack

What changed, and why it matters
Update article on getting notifications for services and add instructions on how to get the email notifications in Slack.

@victr This is ready for you to review/merge now.

thanks, lgtm 👍 but looks like my approval is not enough, probably don't have write access

thanks, lgtm 👍 but looks like my approval is not enough, probably don't have write access

Thank you! I will just wait for Cloudflare to finish the build and merge it when ready.


⚠ ClamAV has degraded performance

In 1918c51, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 442 ms

Resolved: ClamAV performance has improved in 94f9392.


Remove some unused declarations

Codecov Report

Merging #6187 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #6187      +/-   ##
============================================
+ Coverage     83.22%   83.26%   +0.03%
- Complexity    12510    12518       +8
============================================
  Files          1451     1450       -1
  Lines         47411    47389      -22
  Branches       5812     5811       -1
============================================
  Hits          39460    39460
+ Misses         5259     5238      -21
+ Partials       2692     2691       -1

Impacted Files
Coverage Δ
Complexity Δ

.../crate/executor/transport/AlterTableOperation.java
87.73% <ø> (-0.14%)
66 <0> (ø)

...n/java/io/crate/metadata/doc/DocIndexMetaData.java
94.17% <ø> (+0.59%)
125 <0> (ø)
:arrow_down:

sql/src/main/java/io/crate/metadata/Schemas.java
89.24% <ø> (+2.78%)
32 <0> (ø)
:arrow_down:

...exceptions/GroupByOnArrayUnsupportedException.java
66.66% <0%> (-33.34%)
1% <0%> (-1%)

...rc/main/java/io/crate/analyze/UnboundAnalyzer.java
70% <0%> (-15%)
2% <0%> (ø)

...va/io/crate/planner/projection/EvalProjection.java
54.16% <0%> (-8.34%)
9% <0%> (-1%)

.../java/io/crate/blob/TransportDeleteBlobAction.java
75% <0%> (-5%)
4% <0%> (-1%)

...main/java/io/crate/blob/v2/BlobIndicesService.java
68.05% <0%> (-4.17%)
20% <0%> (-2%)

...rc/main/java/io/crate/analyze/symbol/Function.java
88.88% <0%> (-2.78%)
19% <0%> (-1%)

...crate/executor/transport/TransportShardAction.java
86.84% <0%> (-2.64%)
9% <0%> (ø)

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 697c845...c225d33. Read the comment docs.


How to restore serialized selections?

Imagine I am persisting these to a server, and then loading them back. Could be an array of SerializedRange objects.
How do I restore this back to highlights on the screen?
Tried to pass them to paint method, but nothing happens - the screen is still not highlighted.

Never mind. My bad!
The highlight HTML element gets restored. I just wasn't applying the colors myself correctly!


Use v1beta1 API in E2E tests

What this PR does / why we need it:
Use the v1beta1 API for E2E tests.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xref #828
Does this PR introduce a user-facing change?:
NONE

/assign @kron4eg

@kron4eg All comments addressed, PTAL


Justinbarry/ch8749/add docker compose yml to support ui dev

Clubhouse Story

very close just need one configuration details.

@bthaile Can you move this where you see appropriate?
To start:
AUGUR_CORE_VERSION=$(npm explore augur.js -- npm run  --silent core:version) docker-compose up
To kill all the containers:
AUGUR_CORE_VERSION=$(npm explore augur.js -- npm run  --silent core:version) docker-compose down

What you mean?

created driver/caller by way of npm command.


Missed geometry type information in the parameters definition of some tools

Spotted this while looking at the extension toolset, some tools does not advertise expected geometry type (point, line…) in the --toolparameters output. For example, all core tools produce something like this
"parameter_type":{"ExistingFile":{"Vector":"Polygon"}}

several tools from the extension toolset produce output like this one (note missed geometry type part)
'parameter_type': {'ExistingFile': 'Vector'}}

At least AssessRoute and LowPointsOnHeadwaterDivides are affected.
Not sure is this a bug or correct and expected behaviour.

I encountered the same issue as well when trying to update the WBT frontends (R, Jupyter, ArcGIS). The wbt.tool_parameters(tool_name) output (e.g., the order of parameters) is a bit different between core tools and extension toolset. I had to manipulate the tool parameter output string and reorder them properly in order to create a json file with consistent parameters, which is then used to build the frontend GUI.
https://github.com/giswqs/whiteboxgui/blob/master/whiteboxgui/whiteboxgui.py#L207
https://github.com/giswqs/whiteboxgui/blob/master/whiteboxgui/data/whitebox_tools.json

@alexbruy This wasn't intentional and is a good catch. I'll rectify this with all of the plugins' json files and make sure that the back-end plays with the vector parameters of the plugins as expected. Thanks for raising this issue.

@giswqs personally I use slightly different approach and order doesn't matter in my case, as output is a valid JSON and information can be easily accessed by keys.

Okay, so I've just made the changes to each of the plugins json files that were affected. In fact, it was just the AssessRoutes and LowPointsOnHeadwaterDivides (ahggg, that name!) that were missing vector type indications. There were a few other tools where I was using the wrong indicator name, e.g. Lines instead of Line and Polygons instead of Polygon. I've made them all consistent now. Now the question is, how to rectify this problem. Not being part of the open-core, I can't just push these changes to the repository. I will obviously update the General Toolset Extension (GTE) soonish to reflect these changes, but will likely wait a couple of days to do so--we just pushed a new version of the GTE yesterday when we added two additional tools, ShadowImage and LidarPointReturnAnalysis. I'm happy to email you guys the updated json files in the meantime if that is an agreeable solution for you.

@jblindsay No rush. I can wait for your next GET release.

@giswqs It's likely that we'll go with a rolling release of the GTE to begin with. It's likely that we will be developing tools in there quite rapidly over the next little while as we try to flesh out a very compelling product. Eventually, as things stabilize, we will likely adopt a more standard version-based release system. At least, that's the plan.

@giswqs Sounds exciting! I will try to update the frontends weekly. The only issue I have is about version numbering. The WBT core is at v1.5.0. I need to bump the version number of frontends (e.g., on PyPI and conda-forge) whenever they get updated. I will be using v1.5.1, v1.5.2, and so on to keep up with the GTE rolling release. Therefore, I would recommend that the next WBT core release be v1.6.0 so that I can keep the frontend numbering the same as the core.

@giswqs Okay, that is good to know. I was planing a small-point release for the next...to account for the likely friction issues associated with the sweeping changes to the architecture that 1.5 brought about. But if you need me to use 1.X changes instead, that is fine too. Historically, I reserved those for releases that included lots of new tools, rather than just bug fixes but this does not need to be the case.

@jblindsay Not a problem. You can continue to make a small-point release as I have not updated the frontends yet. Gradually the frontend version numbers will surpass the core version numbers in order to keep up with the GTE rolling release until the next major core release.

@giswqs I think it would be better if you used small-point releases for the frontends, to reflect updates to the GTE and I'll just stick with 1.X releases for the open-core. As I say, this won't be the case forever, just for the first while as we try to flesh out the GTE. After that point, we'll stick to proper version releases.

@jblindsay Sounds good. Will do.

Now the question is, how to rectify this problem. Not being part of the open-core, I can't just push these changes to the repository. I will obviously update the General Toolset Extension (GTE) soonish to reflect these changes, but will likely wait a couple of days to do so

I think there is no rush here. For QGIS I will use current implementation and then update plugin whenever the new version of the extension is out.
I don't have strong opinion regarding versioning scheme and IMHO it is up to the WBT developers which one to use. Core tools and extensions can either have the same version number or separate versioning. In the latter case core executable can just advertise version of the any installed extension toolset. If I understand correctly extensions are developed and released separately, moreover in the future there may be more than one extension toolset. So having different versions seems logical, but again, I'm fine with any approach.

Another tool which need to be adjusted is InversePrincipalComponentAnalysis. It uses Html as a data type definition while in all other cases an uppercase spelling HTML is used. This one is not critical (it is easy to use case insensitive comparison), but I thought it is better to report it too.


Create Package Component

As a user, I want to create a package so that I can include package component in UML Diagram.

Adding package component is done with this pr https://github.com/ls1intum/Apollon2/pull/67


Support output with custom ICC from buffer

Hi, is there possible to set custom ICC from a buffer?
I'm trying to resize images and output with their original ICC. I use this code but it didn't work
cursor = sharp(input, options)

const metadata = await cursor.metadata()

cursor = cursor.resize(width, height, { fit: 'cover' })

const outputBuffer = cursor.withMetadata({icc: metadata.icc}).toBuffer()

or is any other way to achieve this?

I think this is covered by #1323, which includes a possible workaround in comment https://github.com/lovell/sharp/issues/1323#issuecomment-812041129

This feature would be nice !


Dont loading just Spotify Logo

Hi, i install the module and all worked.
Now it doesnt work anymore, i think since i install a node update. but i downgrade already and even dont work.
It comes just a Spotify logo at all.
Hope you can help me, config look fine and syntax

Hey there. Hard to tell with this few details.
Please verify the installation steps from the READEME - especially that the spotify.config.json exists and has the correct content.
first thought would be that something is missing there.

Did you get this resolved?

I have the same issue.
The Spotify icon briefly pops up on the screen and then goes black.
But if I play via my phone, the window pops up with the correct song.

I have the same issue.
The Spotify icon briefly pops up on the screen and then goes black.
But if I play via my phone, the window pops up with the correct song.

that does not sound like an issue in it's current state.
This module only shows content if you start playing songs on Spotify.
so in your example: if you start playing a song from your mobile, the module detects this from Spotify API and will display the song which is playing.
if you pause the song the module will continue to display the song for a a few minutes. if you do not un-pause it will the go back into "hiding".
So to sum it up:
the idea is to start Spotify from another device and then be able to control it from this module.

that does not sound like an issue in it's current state.
This module only shows content if you start playing songs on Spotify.
so in your example: if you start playing a song from your mobile, the module detects this from Spotify API and will display the song which is playing.
if you pause the song the module will continue to display the song for a a few minutes. if you do not un-pause it will the go back into "hiding".
So to sum it up:
the idea is to start Spotify from another device and then be able to control it from this module.

I completely thought it was a dedicated player for the magic mirror..
Sorry about the issue, everything seems to be working as intended then :)
man. 11. jan. 2021 23.55 skrev skuethe<EMAIL_ADDRESS>
that does not sound like an issue in it's current state.
This module only shows content if you start playing songs on Spotify.
so in your example: if you start playing a song from your mobile, the
module detects this from Spotify API and will display the song which is
playing.
if you pause the song the module will continue to display the song for a a
few minutes. if you do not un-pause it will the go back into "hiding".
So to sum it up:
the idea is to start Spotify from another device and then be able to
control it from this module.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/skuethe/MMM-Spotify/issues/125#issuecomment-758276331,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFES5X4D272OFZFU3CQMYR3SZN6WTANCNFSM4UZ3OA2Q
.

I completely thought it was a dedicated player for the magic mirror..
Sorry about the issue, everything seems to be working as intended then :)
man. 11. jan. 2021 23.55 skrev skuethe<EMAIL_ADDRESS>
that does not sound like an issue in it's current state.
This module only shows content if you start playing songs on Spotify.
so in your example: if you start playing a song from your mobile, the
module detects this from Spotify API and will display the song which is
playing.
if you pause the song the module will continue to display the song for a a
few minutes. if you do not un-pause it will the go back into "hiding".
So to sum it up:
the idea is to start Spotify from another device and then be able to
control it from this module.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/skuethe/MMM-Spotify/issues/125#issuecomment-758276331,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFES5X4D272OFZFU3CQMYR3SZN6WTANCNFSM4UZ3OA2Q
.

It more or less is. Once you start playing music from another source (mobile, desktop app, browser, ...), then you have more or less full control of the music.
The problem with integrating a "full" player is, how to handle music selection / playlists / music searches. That is a pretty big chunk of work with a lot of open (design) questions behind it.
I am, however, currently working on optimizing the implementation a bit. So f.e. if "nothing" is playing, that the spotify logo is being displayed all the time and that it also includes the "account switch" button.
Maybe this will also open up some other implementations in the future to something like "resume last played music playlist" option. But this is now just ideas and I haven't looked into it at all.

It more or less is. Once you start playing music from another source (mobile, desktop app, browser, ...), then you have more or less full control of the music.
The problem with integrating a "full" player is, how to handle music selection / playlists / music searches. That is a pretty big chunk of work with a lot of open (design) questions behind it.
I am, however, currently working on optimizing the implementation a bit. So f.e. if "nothing" is playing, that the spotify logo is being displayed all the time and that it also includes the "account switch" button.
Maybe this will also open up some other implementations in the future to something like "resume last played music playlist" option. But this is now just ideas and I haven't looked into it at all.

Sounds interesting, thanks for all the work you have put into this module!

Sounds interesting, thanks for all the work you have put into this module!

@MCMARCELO if there is anything else I can help you with, get back to me. I will close the issue for now.

@MCMARCELO if there is anything else I can help you with, get back to me. I will close the issue for now.


Adding some libraries

I have added my own libraries that I consider functionnal.

Thanks @tioui, that has been merged :+1:


AAP-29426: Automate two reports and save output in csv files: Fix pyproject.toml dependencies

Jira Issue: https://issues.redhat.com/browse/AAP-29426
Description
Further to #1260 this PR fixed the pyproject.toml dependencies.
Testing
n/a
Production deployment

[x] This code change is ready for production on its own
[ ] This code change requires the following considerations before going to production:

@goneri @jameswnl FYI.
IIRC the "brew" build system uses pyproject.toml not requirements.txt.
This would explain why AAP2.5 nightly builds are failing to import oauth2client via pydrive2 (a dependency in this PR).


Support multipart/form-data

Currently multipart/form-data in ( request | response ) body is not supported.

According to the document, multipart/form-data is described as type: string, format: binary.
https://swagger.io/docs/specification/describing-request-body/file-upload/
I'm not sure if this is the right way to determine multipart/form-data in the build_type method, is this implementation acceptable?
I also think the example needs to be handled well because there's a lot of unnecessary information.

Hmm, your test runs successfully in my local environment, but CI is not happy about it for some reason.

Ah, no, I just forgot switching the branch. I reproduced the failure.

I'm not sure if this is the right way to determine multipart/form-data in the build_type method, is this implementation acceptable?
I also think the example needs to be handled well because there's a lot of unnecessary information.

Agreed. Though it's probably better than crashing it with NotImplementedError. So let me merge this for now.

Thank you🙏


fix typo

Description
The name of update event is incorrect.
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
don't need to test
Checklist:

[x] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

Maintainer Checklist

[ ] closes #xxxx (Replace xxxx with the GitHub issue number)
[ ] Made sure Checks passed

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[WIP][SPARK-38845] Fix the bug that SparkContext init before SparkSession will cause hive operation failure

…

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Issue resolved by https://github.com/apache/spark/pull/31680


Subset step

some of the stuff from normalization should move into this class wrt to discards

Hold on, subset should be upstream of QC.

Superseded by #22.


⚠ Bofrost.fr has degraded performance

In d9185b3, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1954 ms

Resolved: Bofrost.fr performance has improved in 3a99d61 after 16 minutes.


Add UTM in Virtual Machines

Changes

Supporting Material

Affiliation

Checklist

[x] I have read the Contributing guide, and confirmed my PR aligns with the requirements
[x] I have performed a self-review (valid markdown formatting, spelling and grammar)
[x] I have indicated whether I have any affiliation with any software/ services added
[x] I agree to follow the repositories Contributor Covenant Code of Conduct

I have no affiliation with UTM. I just use it and think it's a great product and would like it added to the list

Light works is not open source


Support multiple tabs that can be set in configuration

Would love if it would be possible to setup multiple tabs with a predefined default url.
My use case:
tab 1) http://localhost:3000 remix app
tab 2) https://localhost:5000 prisma studio client

@Jarrodsz  closing this issue is now supported in the latest version which should be available tomorrow.
You can check in here


Binary expressions

e.g. foo DIV 1000 - by using “table.foo::DIV::1000”

Sorry this took so long to merge.


Statements inside of html blocks cause crash

html! {

}

Leads to:
error: unexpected token
  ┌─ /path/to/src/main.rs:8:26
  │
8 │             let x = "foo";
  │                          ^

This is because brackets in html! don't define a code block in a way Rust defines it, instead they accept 1 expression, like so
html! {

}

The double braces aren't necessary though. The code above runs fine. Here's the full main.rs:
use yew::prelude::*;

#[function_component(Application)]
fn app() -> Html {
    html! {

    }
}

fn main() {
    yew::Renderer::<Application>::new().render();
}

Formatting with double braces works but removes some new lines too many:
html! {
 }

Thank you for pointing this out, this aspect of Yew HTML's syntax was vaguely documented so before looking into the source code of the HTML macros, I didn't know the syntax for block nodes and prop values was different, but it should be fixed now in v0.5.1


Added alignment classes to menu bars in order to align menu items

These alignment classes will allow menubar menu items to "float"  right, center, justified, and spaced.

Darn git-flow...

Could you use the plain justify-content property instead? Using a grid mixin here means the menu bar would have a dependency on the grid component, and ideally no component is dependent on another (unless it's a sub-component, like button group).

Understandable. Thanks for the tip. Will update.

Looks like you guys have a bad gulpfile... ReferenceError: autoprefixer is not defined
Perhaps add var autoprefixer = require('gulp-autoprefixer');

Ah yeah, it's a typo in the node-sass task. Changing this line of the code will fix it. autoprefixer should be $.autoprefixer.

Thanks for making the changes. :)


change the country template to show normalised compare plots

Switching to normalised plots while comparing individual countries.
Closes #145

Codecov Report

Merging #155 into master will decrease coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
- Coverage   79.77%   79.54%   -0.23%
==========================================
  Files           5        5
  Lines         895      885      -10
==========================================
- Hits          714      704      -10
  Misses        181      181

Impacted Files
Coverage Δ

oscovida/oscovida.py
76.85% <0.00%> (-0.27%)
:arrow_down:

oscovida/plotting_helpers.py
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 435c770...b8a0a14. Read the comment docs.

LGTM


PathUtils: New parsePath implementation.

Slightly smaller build size
Slightly faster (http://jsben.ch/zRUTx ~ 10%)
Fixes #701

I don't think it is a good idea. If you use this Regexp it will cut the content of the query string if it contain '?' character.
For example:
The url 'hello.com?abc=cut???mmmmm#match' we expect to get the result
{
  pathname:  'hello.com',
  search: '?abc=cut???mmmmm',
  hash: '#match'
}

But in your version
we will get
{
  pathname:  'hello.com',
  search: '?abc=cut',
  hash: ''
}

It may cause some problem and sometimes Regexp will be very hard to maintain so I think it may not a good idea to do that even though it can improve the performance.

It shouldn't cut this apart: abc=cut???mmmmm. But it works as intended for the hash part.
For the path /foo/bar/baz?abc=cut???mmmmm#match, this is the correct output:
{
  pathname:  '/foo/bar/baz',
  search: '?abc=cut???mmmmm#match',
  hash: ''
}

Will take a detailed look at the current behavior later.

@StringEpsilon Why you said that #match is not a legal hash part?  In the origin code
const hashIndex = pathname.indexOf('#');
  if (hashIndex !== -1) {
    hash = pathname.substr(hashIndex);
    pathname = pathname.substr(0, hashIndex);

If will split the url string from tail to catch the hash value, and then catch the query sting. But in your new code you expect the url string like this.
> "http://hello.com#hash?q=querystring".match(/(\/?[^#?]*)(\#[^?]+)?(\?.+)?/)
[ 'http://hello.com#hash?q=querystring',
  'http://hello.com',
  '#hash',
  '?q=querystring',
  index: 0,
  input: 'http://hello.com#hash?q=querystring' ]
>

but I think the normal url with hash and query string should be http://hello.com?q=querystring#hash

Oops. I misremembered the order of query and hash. My bad.

Thank you for the contribution, @StringEpsilon, but we aren't looking for these kinds of contributions right now.


Inherit breaking flag of sub-PRs in batch-mirror Noir PRs

Context
Noir changes happening in this repository are currently mirrored in batches to the Noir repository (e.g. https://github.com/noir-lang/noir/pull/4657).
Problem
Sub-PRs within the batches could be breaking PRs (i.e. backward incompatible) containing breaking changes.
But their breaking flags don't bubble up to the batch PR itself, makes spotting breaking changes in the Noir repo less trivial than it should be.

Happy case
When ≥1 sub-PR is breaking, batch-mirror PR is flipped breaking (i.e. adds ! in title).

Commit overrides in the sync PR bodies sufficiently communicate individual breaking PRs.


sync quic branch with master branch

All checks have passed, can merge it, @nandsky

LGTM
btw: quic always need to be built with boringssl, but the "quic" branch can not be compiled with boringssl now. The problem had be fixed in https://github.com/alibaba/tengine/pull/1695.


table with timezone of GMT+02:00 showing up as -2

https://pub.beakernotebook.com/#/publications/56e1a3f3-7040-417a-afd7-d3e1fb8db021

var time = moment(633726000000)
time.tz("GMT+02:00")
time.format("ZZ")

produces "-0200" so instead of "+0200" why?

This sample gives correct result:
 var time = moment(633726000000) time.utcOffset("GMT+02:00") time.format("ZZ")

cool so if zone starts with "gmt" then call that.
goes for plots too.
need a helper fn.


Increase test coverage of admin-tool-ext-win

Testing coveralls integration by adding some tests! Still only ~50%, but the majority of the code here isn't really something that is easily covered with a unit test and should probably be done in a full integration test.
To increase the coverage I did remove a few places where we were doing what should be unnecessary checks. For example the undefined check in getPackageInfo - it's safe to assume that exists since if it doesn't that means things are really broken anyways and there isn't any recovering from that state.

haha - yeah it got confused by https://coveralls.io/builds/29342782
What happened there was that if you don't specify parallel=true for the action then it'll upload each report separately and thus saw that as the overall coverage for the repo.
I merged in the actions with parallel set correctly, but I had queued a build without it to test out what would happen and that just took longer to get out.
It should fix itself once these runs get merged in.