Declaration of Column::data does not compatible with Fluent::data

Summary of problem or feature request

Error
Declaration of Yajra\DataTables\Html\Column::data(array|string $value): static must be compatible with Illuminate\Support\Fluent::data($key = null, $default = null)
Code snippet of problem
File vendor/yajra/laravel-datatables-html/src/Html/Column.php, function data (line 305 - 310) was the reason:
    public function data(array|string $value): static
    {
        $this->attributes['data'] = $value;

        return $this;
    }

System details

Operating System: Mac OS 15
PHP Version: 8.3
Laravel Version: laravel/framework ^11.34
Laravel-Datatables Version: yajra/laravel-datatables ^11.0

Solution
File vendor/yajra/laravel-datatables-html/src/Html/Column.php, change function data (line 305 - 310) to:
    public function data($key = null, $default = null): static
    {
        $this->attributes['data'] = $key;

        return $this;
    }

I have the same problem, this was caused by the update in Laravel

I have the same problem now,

While I commented on the function, and my website is running normally again, please improve the function

any updates? having this issue from today

same error with me

The solution is avoiding the error but having a second parameter here doesn't make sense, we need to find a proper way to implement this method.

Solution
File vendor/yajra/laravel-datatables-html/src/Html/Column.php, change function data (line 305 - 310) to:
    public function data($key = null, $default = null): static
    {
        $this->attributes['data'] = $key;

        return $this;
    }

Should we petition to revert the latest PR (https://github.com/laravel/framework/pull/53665), remove the data method added to the framework, or move on with the quick solution suggested by @OzanKurt?

I would personally like a revert.
The new pull request doesn't seem to be adding much to the codebase other than "forcefully combining" two completely different classes' (Request and Fluent) functionalities.
BUT, while we wait for an action we should implement a temporary solution for the data method.

How about giving us a way to override entire fluent method, i mean leave that door open so that we won't 100% rely on package manager to make that update, it is possible ?

or just down to previous laravel version until any they fix it

@yajra why dont you copy laravels fluent class into your codebase and you are good?

@yajra why dont you copy laravels fluent class into your codebase and you are good?

That is actually a great idea, having fluent as a standalone package. Simply something like xxx/fluent which would not nuke anybodies codebase. 😄

@yajra why dont you copy laravels fluent class into your codebase and you are good?

I agree, this is my initial plan if the revert never happens in the framework. It seems like you went ahead with it :)

For now you can downgrade using composer update --with "laravel/framework:11.33.1".

A good solution for this is to use a decorator class instead of extending Fluent directly:
<?php

use ArrayAccess;
use Illuminate\Contracts\Support\Arrayable;
use Illuminate\Contracts\Support\Jsonable;
use Illuminate\Support\Traits\ForwardsCalls;
use JsonSerializable;

/**
 * @template TKey of array-key
 * @template TValue
 *
 * @implements \Illuminate\Contracts\Support\Arrayable<TKey, TValue>
 * @implements \ArrayAccess<TKey, TValue>
 */
abstract class FluentDecorator implements Arrayable, ArrayAccess, Jsonable, JsonSerializable
{
    use ForwardsCalls;

    /**
     * The Fluent instance.
     *
     * @var \Illuminate\Support\Fluent<TKey, TValue>
     */
    protected $fluent;

    /**
     * Create a new fluent instance.
     *
     * @param  iterable<TKey, TValue>  $attributes
     * @return void
     */
    public function __construct($attributes = [])
    {
        $this->fluent = new \Illuminate\Support\Fluent($attributes);
    }

    /**
     * Convert the fluent instance to an array.
     *
     * @return array<TKey, TValue>
     */
    public function toArray()
    {
        return $this->fluent->getAttributes();
    }

    /**
     * Convert the object into something JSON serializable.
     *
     * @return array<TKey, TValue>
     */
    public function jsonSerialize(): array
    {
        return $this->toArray();
    }

    /**
     * Convert the fluent instance to JSON.
     *
     * @param  int  $options
     * @return string
     */
    public function toJson($options = 0)
    {
        return json_encode($this->jsonSerialize(), $options);
    }

    /**
     * Determine if the given offset exists.
     *
     * @param  TKey  $offset
     * @return bool
     */
    public function offsetExists($offset): bool
    {
        return $this->fluent->offsetExists($offset);
    }

    /**
     * Get the value for a given offset.
     *
     * @param  TKey  $offset
     * @return TValue|null
     */
    public function offsetGet($offset): mixed
    {
        return $this->fluent->offsetGet($offset);
    }

    /**
     * Set the value at the given offset.
     *
     * @param  TKey  $offset
     * @param  TValue  $value
     * @return void
     */
    public function offsetSet($offset, $value): void
    {
        $this->fluent->offsetSet($offset, $value);
    }

    /**
     * Unset the value at the given offset.
     *
     * @param  TKey  $offset
     * @return void
     */
    public function offsetUnset($offset): void
    {
        $this->fluent->offsetUnset($offset);
    }

    /**
     * Handle dynamic calls to the fluent instance to set attributes.
     *
     * @param  TKey  $method
     * @param  array{0: ?TValue}  $parameters
     * @return $this
     */
    public function __call($method, $parameters)
    {
        return $this->forwardDecoratedCallTo($this->fluent, $method, $parameters);
    }

    /**
     * Dynamically retrieve the value of an attribute.
     *
     * @param  TKey  $key
     * @return TValue|null
     */
    public function __get($key)
    {
        if (method_exists($this->fluent, 'value')) {
            return $this->fluent->value($key);
        }

        return $this->fluent->get($key);
    }

    /**
     * Dynamically set the value of an attribute.
     *
     * @param  TKey  $key
     * @param  TValue  $value
     * @return void
     */
    public function __set($key, $value)
    {
        $this->fluent->offsetSet($key, $value);
    }

    /**
     * Dynamically check if an attribute is set.
     *
     * @param  TKey  $key
     * @return bool
     */
    public function __isset($key)
    {
        return $this->fluent->offsetExists($key);
    }

    /**
     * Dynamically unset an attribute.
     *
     * @param  TKey  $key
     * @return void
     */
    public function __unset($key)
    {
        $this->fluent->offsetUnset($key);
    }
}

For now you can downgrade using composer update --with "laravel/framework:11.33.1".

I have is working in 11.33.2 as well

Same problem here!


XRootD for 3.6 tests

Fairly large overhaul of the xrootd test code; this creates a directory structure with which it can test both authenticated and unauthenticated access.
SciTokens are used for tests on 3.6; GSI/Macaroons are used for tests on 3.5. I also added a test to run cconfig and make sure that the overall xrootd config, which is assembled from multiple config files, contains the right values for some of the knobs we care about.
Known issues:

FUSE tests are broken (unknown failure)
Macaroons tests are broken (the destination token does not have the right permissions)
SciTokens tests are only run on 3.6, not 3.5+upcoming -- this is because 3.5's osg-xrootd-standalone sets up GSI
xrdvoms/vomsxrd/xrootd-voms-plugin is not tested yet

The commits in this PR are not in chronological order; instead I grouped changes into chunks and made commits for those in order to try and make a consistent "story"; especially the "Reorganize test directory to check privileges" series of commits should be taken as a whole (don't expect a revert to work). The first few commits (up to "Add logging config...") are probably independent.
VMU test forthcoming.

Also this depends on the tokens created in #240 (though it is not merged into this branch).


Provide Gradle Kotlin DSL examples in documentation

As a Gradle Kotlin DSL adopter, I'd like to know how to configure this plugin using the Kotlin DSL.
This plugin was identified as one of the most useful Gradle plugins. With Kotlin DSL 1.0 approaching shortly, it'd be wonderful if the documentation provided Kotlin and Groovy DSL samples. Blog post with suggestions.
Here are a couple additional resources:

Migrating build logic from Groovy to Kotlin guide
Exemplar for automated samples testing
Join #kotlin-dsl channel in Gradle Community Slack for personalized help

Thank you for providing a great Gradle plugin! —The Gradle Team

Thanks @eriwen, good idea! I'll update the docs.

Nice. I like how you structured the multi-language bits in the README 👍


Remove console warnings and logs in browser

🗣 Description
Remove unused or legacy code causing console warnings and console logs.

💭 Motivation and context
Cleans up unused code and keeps the browser console cleaner.

🧪 Testing
No longer see the following:

Unsupported style property warning
Ignored route render warnings
Unrecognized disableunderline warning
Token Route Check string logs
Inventory object string logs

📷 Screenshots
This PR removes the following console warnings and logs:

✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All future TODOs are captured in issues, which are referenced
in code comments.
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[ ] All relevant repo and/or project documentation has been updated
to reflect the changes in this PR.
[ ] Tests have been added and/or modified to cover the changes in this PR.
[ ] All new and existing tests pass.

✅ Pre-merge checklist

[ ] Revert dependencies to default branches.
[ ] Finalize version.

✅ Post-merge checklist

[ ] Create a release.

Need to remove the Redirect import.
What was the purpose of all these redirects anyways?

It's legacy code so not sure why they were there because they were always being ignored.


[BUG] setFormatCode(..........) cleaned the existing styles of cell

Package version, Laravel version
maatwebsite/excel: 2.1.7 ~ 2.1.18  (tested 2.1.6 is fine)
Laravel: 5.1.46
Problem description
My program will load an existing Excel file, and modify it by PHP, then export as a new Excel file.
In my existing Excel file, cell "I11" is bold.
If I run the following code:
$sheet->getStyle('I6:I11')->getNumberFormat()->setFormatCode('_($* #,##0.00_);_($* (#,##0.00);_($* "-"??_);_(@_)');
Cell "I11" will become normal font weight (changed to non-bold).
If I comment the above code, it can keep bold style.
I have also tried to run the following code before/after setFormatCode(..) for force this cell as bold font, but no luck :
$sheet->getStyle('I11')->getFont()->setBold(true);
Expected behaviour

The format code of cell "I6:I11" are changed to '($* #,##0.00);($* (#,##0.00);($* "-"??);(@_)' by PHP code.
Cell "I11" show as bold font.

Actual behaviour

The format code of cell "I6:I11" are changed to '($* #,##0.00);($* (#,##0.00);($* "-"??);(@_)' by PHP code.
2. However, cell "I11" show as normal font weight, but not bold.

Screenshot of Excel file
Existing Excel for load:

Exported Excel file:

As you are using native PHPExcel methods, there's little we can do about it in this package.

Thanks for @patrickbrouwers reply.
I tried to upgrade maatwebsite/excel to 2.1.7 from 2.1.6.
I cannot find PHPExcel upgraded/downgraded.
Just find "tijsverkoyen/css-to-inline-styles" upgraded to 2.2.0 from 1.5.5, is it related?

In my case, 2.1.6 is fine but 2.1.7 not.

https://github.com/Maatwebsite/Laravel-Excel/commit/55d18b6a99b30b9003c2f174cc3ecd9ca79f1bf5#diff-a5f6bef155051f62cca633eb1eff4adaR417

When I removed line415 - 425 (Code for "Fix borders for merged cells") in 2.1.7 version LaravelExcelWriter.php, the result is ok.
Anyone know what is the problem?

My workaround........ Create custom writer, override LaravelExcelWriter::_render(), comment the code for "Fix borders for merged cells"


IExecutionContext in TRTEngineOp is non thread-safe.

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 10 Home: CentOS 7
TensorFlow installed from (source or binary): source
TensorFlow version (use command below): 1.11
Python version: 2.7
Bazel version (if compiling from source): 0.18
GCC/Compiler version (if compiling from source): gcc 5.4
CUDA/cuDNN version: cuda-10.0, cudnn 7.3, tensorrt 5.0
GPU model and memory: Nvidia P40

Describe the Problem
We are using DirectSession to do inference with c++ code in gpu environment. The model using TRTEngineOp to improve performance. But TRTEngineOp maintain a engine_map to process input.  This map used to keep tensorrt engines and their tensorrt execution context for given batch size.
The tensorrt engine(nvinfer1::ICudaEngine) is thread safety. But the tensorrt execution context(nvinfer1::IExecutionContext) is non thread-safe. So it will crashed when session processing two same batch_size task in the same time.
Describe the expected behavior
We hope the engine_map in TRTEngineOp can maintain a pair, which the first value can be tensorrt engine.  the sescond value can be a tensorrt context pool.
Code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate the problem.
Other info / logs
Crashed when session process two task in the same time.

2019-01-25 11:57:59.952217: E external/org_tensorflow/tensorflow/stream_executor/cuda/cuda_event.cc:48] Error polling for event status: failed to query event: CUDA_ERROR_ILLEGAL_ADDRESS: an illegal memory access was encountered
2019-01-25 11:57:59.952296: F external/org_tensorflow/tensorflow/core/common_runtime/gpu/gpu_event_mgr.cc:274] Unexpected Event status: 1
2019-01-25 11:57:59.952430: E external/org_tensorflow/tensorflow/stream_executor/cuda/cuda_driver.cc:1011] could not synchronize on CUDA context: CUDA_ERROR_ILLEGAL_ADDRESS: an illegal memory access was encountered :: *** Begin stack trace ***

	clone
*** End stack trace ***

@trevor-m @pooyadavoodi  Can you PTAL

@trevor-m @pooyadavoodi, I believe this is fixed. Is that correct?

I believe this was fixed in https://github.com/tensorflow/tensorflow/commit/e51fa30400b3a469b03111b25344bc47bdff96bd.  Please reopen if not.


Update docker-compose docs with filtering

File: [compose/reference/ps.md](https://docs.docker.com/compose/reference/ps/
filtering is not explained and it doesn't work as expected, only status field works, but service 'name' doesn't

Closing this ticket due to its age, and the impending refactor. If you think this is in error, feel free to reopen. Thanks!


Update README.md

Video player initialization api was changed to isInitialized from initilialized.
List which issues are fixed by this PR. You must list at least one issue.
https://github.com/flutter/flutter/issues/79178
Pre-launch Checklist

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
[ ] I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
[ ] I signed the CLA.
[ ] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[ ] I updated CHANGELOG.md to add a description of the change.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@googlebot I signed it!

Duplicate of https://github.com/flutter/plugins/pull/3713


3.00.-beta00 Release of the Google Cloud Diagnostics libraries

Definitely start with beta, but if you want to actually do a release, you'll want 3.0.0-beta01. (tagreleases.sh deliberately ignores beta00. It's a sort of placeholder version.)

@jskeet done, PTAL

@jskeet thanks! Squashed and merged!


[web] CanvasKit Hot Restart does not work

Steps to Reproduce

Run flutter create bug.
Run cd bug.
Run flutter run -d chrome --dart-define=FLUTTER_WEB_USE_SKIA=true.
See the application in Chrome.
Change some text in the code.
Press hot reload / hot restart (does not matter because of https://github.com/flutter/flutter/issues/53041).

Expected results: the text should change because of hot restart (the page would normally refresh without the FLUTTER_WEB_USE_SKIA flag).
Actual results: I need to press F5 / reload the Chrome tab in order for the hot restart to finish. flutter run will be stuck on Performing hot restart... until I reload the Chrome tab.

Click to expand versions
Flutter 1.24.0-3.0.pre • channel dev • https://github.com/flutter/flutter.git
Framework • revision 2783f8e2e1 (6 days ago) • 2020-10-22 09:36:06 -0700
Engine • revision defa8be2b1
Tools • Dart 2.11.0 (build 2.11.0-242.0.dev)

CanvasKit
Removing --dart-define=FLUTTER_WEB_USE_SKIA=true makes hot restart work without refreshing the tab.

Reproducible on the latest master, dev and beta channels.
Bellow is the logs from the moment you do Hot Restart/Reload. It is just stuck until you refresh the webpage manually.
Logs
Performing hot restart...
[+82261 ms] Skipping target: gen_localizations
[   +3 ms] complete
[  +11 ms] Scanned through 506 files in 10ms
Syncing files to device Chrome...
[   +1 ms] <- recompile org-dartlang-app:/web_entrypoint.dart 715c4e1f-525a-4a62-82a0-cf15db0ce2c1
[        ] package:flutter_example/main.dart
[        ] <- 715c4e1f-525a-4a62-82a0-cf15db0ce2c1
[ +225 ms] Synced 0.0MB.
[        ] <- accept

flutter doctor -v
[✓] Flutter (Channel master, 1.24.0-4.0.pre.138, on Mac OS X 10.15.7 19H2 darwin-x64, locale en)
    • Flutter version 1.24.0-4.0.pre.138 at /Users/pedromassango/dev/SDKs/flutter_master
    • Framework revision 13896b3bd1 (6 hours ago), 2020-10-28 19:43:19 -0700
    • Engine revision 073263e39d
    • Dart version 2.11.0 (build 2.11.0-260.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.1)
    • Android SDK at /Users/pedromassango/Library/Android/sdk
    • Platform android-30, build-tools 30.0.1
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.1, Build version 12A7403
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] IntelliJ IDEA Community Edition (version 2020.2.3)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 50.0
    • Dart plugin version 202.7319.5

[✓] VS Code (version 1.50.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.15.1

[✓] Connected device (4 available)
    • sdk gphone x86 arm (mobile) • emulator-5554 • android-x86    • Android 11 (API 30) (emulator)
    • macOS (desktop)             • macos         • darwin-x64     • Mac OS X 10.15.7 19H2 darwin-x64
    • Web Server (web)            • web-server    • web-javascript • Flutter Tools
    • Chrome (web)                • chrome        • web-javascript • Google Chrome 86.0.4240.111

• No issues found!

@yjbanov are all the fixes in for this?

Additionally, manual restart in the browser doesn't always work anyway.
Every now and then the server crashes with the following message:
Performing hot restart...                                        2,000ms
hotRestart: (-32603) No context with the running Dart application.
Application finished.

[   +7 ms] Debug service listening on ws://<IP_ADDRESS>:52419/rKit4YLpgsk=/ws
[   +1 ms] Warning: Flutter's support for web development is not stable yet and hasn't
[        ] been thoroughly tested in production environments.
[        ] For more information see https://flutter.dev/web
[        ] 🔥  To hot restart changes while running, press "r" or "R".
[   +1 ms] For a more detailed help message, press "h". To quit, press "q".
[+3617 ms] Performing hot restart...
[   +5 ms] Initializing file store
[  +14 ms] Skipping target: gen_localizations
[   +7 ms] complete
[   +7 ms] Scanned through 311 files in 6ms
[        ] Syncing files to device Chrome...
[   +2 ms] <- recompile org-dartlang-app:/web_entrypoint.dart 91f2e7b1-f27a-4979-a5fd-27e26a48a3a3
[        ] package:hello_world/main.dart
[        ] <- 91f2e7b1-f27a-4979-a5fd-27e26a48a3a3
[  +60 ms] Syncing files to device Chrome... (completed in 62ms)
[        ] Synced 0.0MB.
[        ] <- accept
[   +2 ms] DwdsVmClient: Attempting a hot restart
[   +1 ms] DwdsVmClient: Attempting to disabling breakpoints and resume the isolate
[   +8 ms] DwdsVmClient: Successfully disabled breakpoints and resumed the isolate

I'm able to reproduce this easily. I added some additional logs and it appears we are correctly issuing a request for $dartHotRestart(). However, we never get a corresponding isolate start event. It appears that $dartHotRestart isn't actually doing anything. If I manually call the method, I see a flash but there aren't corresponding changes.
I'm going to keep digging but the issue may be outside of package:dwds and actually inside DDC.
cc @nshahan

Keep me posted, I can pick this up if it's clear this is on the ddc/sdk side.

Additionally, manual restart in the browser doesn't always work anyway.
Every now and then the server crashes with the following message:
Performing hot restart...                                        2,000ms
hotRestart: (-32603) No context with the running Dart application.
Application finished.

This does not seem to be happening anymore as of Flutter 1.24.0-8.0.pre.209 • channel master

Ok I dug into this more. It looks like we are throw an error on hot restart but for some reason it isn't captured.
This is the error:
Error: Mismatched anonymous define() module: function() { return CanvasKitInit; }
http://requirejs.org/docs/errors.html#mismatch
    at makeError (require.js:168)
    at intakeDefines (require.js:1254)
    at Object.localRequire [as require] (require.js:1446)
    at requirejs (require.js:1797)
    at Object.forceLoadModule (main_module.bootstrap.js:806)
    at JavaScriptObject.forceLoadModule$3 (client.js:8762)
    at Object.forceLoadModule$3$x (client.js:3658)
    at RequireRestarter._reloadModule$1 (client.js:22508)
    at client.js:22443
    at _wrapJsFunctionForAsync_closure.$protected (client.js:3826)
    at _wrapJsFunctionForAsync_closure.call$2 (client.js:10878)
    at Object._asyncStartSync (client.js:3790)
    at RequireRestarter._reload$body$RequireRestarter (client.js:22502)
    at RequireRestarter._reload$1 (client.js:22366)
    at client.js:22263
    at _wrapJsFunctionForAsync_closure.$protected (client.js:3826)
    at _wrapJsFunctionForAsync_closure.call$2 (client.js:10878)
    at _awaitOnObject_closure.call$1 (client.js:10864)
    at _RootZone.runUnary$2$2 (client.js:12387)
    at _Future__propagateToListeners_handleValueCallback.call$0 (client.js:11248)
    at Object._Future__propagateToListeners (client.js:3931)
    at _Future._completeWithValue$1 (client.js:11081)
    at _AsyncAwaitCompleter.complete$1 (client.js:10847)
    at Object._asyncReturn (client.js:3798)
    at client.js:22318
    at _wrapJsFunctionForAsync_closure.$protected (client.js:3826)
    at _wrapJsFunctionForAsync_closure.call$2 (client.js:10878)
    at _awaitOnObject_closure.call$1 (client.js:10864)
    at _RootZone.runUnary$2$2 (client.js:12387)
    at _Future__propagateToListeners_handleValueCallback.call$0 (client.js:11248)
    at Object._Future__propagateToListeners (client.js:3931)
    at _Future._completeWithValue$1 (client.js:11081)
    at _Future__asyncCompleteWithValue_closure.call$0 (client.js:11170)
    at Object._microtaskLoop (client.js:3986)
    at StaticClosure._startMicrotaskLoop (client.js:3992)
    at _AsyncRun__initializeScheduleImmediate_internalCallback.call$1 (client.js:10747)
    at invokeClosure (client.js:1241)
    at MutationObserver.<anonymous> (client.js:1260)

It's thrown here.
It's clear that we are holding requireJS wrong when using canvas kit but the documentation at https://requirejs.org/docs/errors.html#mismatch is a little cryptic. I'm not super familiar with it. Adding @jakemac53 as he may know how to resolve the issue.

Seems like the root cause is this: https://github.com/flutter/flutter/issues/58428
Bouncing to @yjbanov to triage and resolve.

Thanks for finding the root cause. I put https://github.com/flutter/flutter/issues/58428 back in the triage queue.

Performing hot restart...                                          365ms
hotRestart: (-32000) Bad state: No active isolate to resume.
#0      _disableBreakpointsAndResume (package:dwds/src/dwds_vm_client.dart:152:28)
<asynchronous suspension>
#1      DwdsVmClient.create.<anonymous closure> (package:dwds/src/dwds_vm_client.dart:61:7)
<asynchronous suspension>
#2      VmService._routeRequest (package:vm_service/src/vm_service.dart:2121:14)
<asynchronous suspension>
#3      VmService._processRequest (package:vm_service/src/vm_service.dart:2092:19)
<asynchronous suspension>

Error message is way more informative as of newest master.

Hot Restart still occasionally fails from time to time and manual restart sometimes kills the process.
Performing hot restart...                                           3.7s
hotRestart: (-32603) No context with the running Dart application.
Application finished.

As of today and the latest master Hot Restart does not work at all w/ CanvasKit (unless there were no changes in the project).
Environment:
➜ flutter doctor -v
[✓] Flutter (Channel master, 1.24.0-8.0.pre.374, on macOS 11.0 20A5364e darwin-x64, locale en-GB)
    • Flutter version 1.24.0-8.0.pre.374 at /Users/jprzetakiewi/flutter
    • Framework revision 183f0e797a (4 days ago), 2020-11-26 19:12:28 +0100
    • Engine revision 20caf54969
    • Dart version 2.12.0 (build 2.12.0-76.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/jprzetakiewi/Library/Android/sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.0)
    • Xcode at /Applications/Xcode-beta.app/Contents/Developer
    • Xcode 12.0, Build version 12A8189n
    • CocoaPods version 1.10.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 50.0.1
    • Dart plugin version 193.7547
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] IntelliJ IDEA Ultimate Edition (version 2020.2.3)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 51.0.3
    • Dart plugin version 202.8070

[✓] VS Code (version 1.51.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.16.0

[✓] Connected device (4 available)
    • iPhone 11 Pro (mobile) • 2A1554C1-CEDE-49D1-AD8B-91D6B16ED09C • ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-0 (simulator)
    • macOS (desktop)        • macos                                • darwin-x64     • macOS 11.0 20A5364e darwin-x64
    • Web Server (web)       • web-server                           • web-javascript • Flutter Tools
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 87.0.4280.67

• No issues found!

Steps to reproduce:

flutter create hot_restart_skia_test
cd hot_restart_skia_test
flutter run -d chrome --dart-define=FLUTTER_WEB_USE_SKIA=true
Press r in terminal to trigger Hot Restart - works properly
Make any changes in lib/main.dart
Press r in terminal again - process gets stuck on Performing hot restart...

After step 6 manually refreshing the browser can crash the process, this is the output to the console when it happens:
Performing hot restart...                                           3.7s
hotRestart: (-32603) No context with the running Dart application.
Application finished.

It looks like it hasn't rolled into Flutter master yet. If this PR lands you should try again: https://github.com/flutter/flutter/pull/71498

The issue still persists.
Console output:
Performing hot restart...                                        1,820ms
hotRestart: (-32000) Bad state: No active isolate to resume.
#0      _disableBreakpointsAndResume (package:dwds/src/dwds_vm_client.dart:158:28)
<asynchronous suspension>
#1      DwdsVmClient.create.<anonymous closure> (package:dwds/src/dwds_vm_client.dart:61:7)
<asynchronous suspension>
#2      VmService._routeRequest (package:vm_service/src/vm_service.dart:2121:14)
<asynchronous suspension>
#3      VmService._processRequest (package:vm_service/src/vm_service.dart:2092:19)
<asynchronous suspension>

How to reproduce:
Unknown, the feature works properly until it suddenly stops and crashes the app with every restart (assuming there were file changes since last restart)
Environment:
➜ flutter doctor -v
[✓] Flutter (Channel master, 1.25.0-9.0.pre.43, on macOS 11.0.1 20B50 darwin-x64, locale en-GB)
    • Flutter version 1.25.0-9.0.pre.43 at /Users/kubcio/.flutter
    • Framework revision 63062a6443 (26 hours ago), 2020-12-13 23:19:13 +0800
    • Engine revision 4797b06652
    • Dart version 2.12.0 (build 2.12.0-141.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/kubcio/Library/Android/sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.2, Build version 12B45b
    • CocoaPods version 1.10.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] IntelliJ IDEA Ultimate Edition (version 2020.3)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 52.0.5
    • Dart plugin version 203.5981.152

[✓] VS Code (version 1.52.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.17.0

[✓] Connected device (1 available)
    • Chrome (web) • chrome • web-javascript • Google Chrome 87.0.4280.88

• No issues found!


Selenium Server w/ PhantomJS : Trying to achieve a Visual Regression Testing Strategy

I'm in pursuit of a "Unified Development Environment", mixed Mac & Windows devs. I've been super happy with the Drupal-VM project and with everyone's help so far on my other questions. The last piece I'm trying to get in place is figuring out a strategy for visual regression testing.
@geerlingguy, Per your post here, you mentioned that you don't recommend the Selenium PhantomJS route on the VM:
https://github.com/geerlingguy/drupal-vm/issues/367

Yes, you can get it working inside Drupal VM with the ability to do screenshots through the phantomjs driver... but I usually recommend people either set up CI with that level of detail/automation on a separate server (e.g. Jenkins) or on their host machine, since it will use an actual browser instance, like FireFox. Drupal VM is much better imo for building the tests with a headless browser, though you can get it working either way (if you want screenshots).

I'm wondering why? From an unified development environment perspective, seems like it would be better if everyone on the team could fire up a VM, with all the necessary config, do a git pull to their share filesystem folder, maybe a database sync, and be up and running...
Continuous Integration During Development
I'd like some sort of watch task running while styling and site building that would run the behat tests and another task runner for CSS themers. I haven't really figured out when it makes logical sense to run diffs. Every save? Every commit? only on release? I could see potential benefit to each. That seems like something we can figure out given our workflow if I can get everything up and running though.
I am pretty confident I will want to run all behat tests and visual regression tests on commit as well as a pre-commit hook before deployment to prod. Any tips/pointers for how to get this setup? I'd like to do this on Travis CI but not really sure where to go from here.
In writing this all out I'm realizing I'm probably asking like 5 questions here and only a few of them are directly related to this project. This would probably also better be a blog post at this point but oh well...
Here is just some context of what I did to get things setup and working on my local host

I'm able to run behat tests on the VM via the drupal-extension. Yay! :+1:
After getting the following prerequisites installed I'm able to generate screenshots and diffs via webdriverio, phantomjs, and webdrivercss. Yay! x :100:

node v5.5 on my local host (mac)
$ `npm install -g<EMAIL_ADDRESS><2.0"
$ `npm install -g selenium-standalone"
$ `npm install -g<EMAIL_ADDRESS>$ brew install imagemagick // I think this was already installed but not 100%
$ brew install graphicsmagick // This was a fix to an odd gm convert error

Here's my globally installed node packages:
$ npm list -g --depth=0
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>
Here's my package.json:
{
  "name": "vtests",
  "version": "1.0.0",
  "main": "webdrivercsstest.js",
  "dependencies": {
    "jquery": "^1.11.3",
    "phantomcss": "^0.10.4",
    "phantomcss-gitdiff": "^0.0.5",
    "webdrivercss": "^1.1.9"
  },
}

Here's my actual webdrivercsstest.js
var assert = require('assert');

// init WebdriverIO
var client = require('webdriverio').remote({desiredCapabilities:{browserName: 'phantomjs'}})
// init WebdriverCSS
require('webdrivercss').init(client, {
  screenWidth: [320,480,768,960,1280]
});

client
    .init()
    .url('http://drupalvm.dev')
    .webdrivercss('startpage',[
        {
            name: 'page',
            elem: '#page',
            exclude:  [
             ".container-to-exclude",
            ]
        }
    ], function(err, res) {
        assert.ifError(err);
        assert.ok(res.page[0].isWithinMisMatchTolerance);
    })
    .end();

The screen captures are generated as expected if I start the selenium server on my local machine via:
$ selenium-standalone start
and in another terminal run
$ node webdrivercsstest.js

I need to credit @lhridley https://github.com/lhridley for most of this based on the workshop she gave to the WebNY group a few months ago. This is in large part me just trying to grok the whole thing in my own way...

I think it's mostly a matter of documentation; we could point people to how to get things adjusted so it's easier to do all the testing and screenshots within the VM.

Just for reference, to start the selenium server on the VM, this gets things running.
$ sudo /etc/init.d/selenium start
I also needed to install graphicsmagick to get the above test to run correctly
$ sudo apt-get install graphicsmagick
I have since updated my config.yml file to inlude these
extra_packages:
  - unzip
  - graphicsmagick
  - graphicsmagick-imagemagick-compat

Just to add a comment here.. I had a lot of success using the SeleniumHQ Docker and running Selenium as its own Docker VM and letting that connect to DrupalVM. Just pass host name and IPs to the Docker client when initializing it and it will set that in its host file. It was much much easier than ssh into the DrupalVM and attempting to get all the necessary things. Plus it lets Docker act as a dedicated Selenium hub. From there I just told Behat the IP to the selenium server and it was good to go. It also comes with VNC client(s) built in so you can watch the browser run through the tests if you have doubts or need to debug. I haven't figured out how to take the next step and get it on Jenkins yet, but this lets anyone working on the project write and run their own tests locally in the VMs with no known requirements on the host machine beyond Docker and Vagrant.
I also needed to run Selenium without PhantomJS so I could test AJAX or responses that are served through BigPipe in D8 otherwise tests fail.
I am however interested in visual regression testing, and would like to try this out and see what the result is.

For this and #367, I've decided to add links to the issues in the docs for Behat, and leave it at that... I've found that many projects set up Selenium, PhantomJS, Node, Behat, and the Drupal plugins slightly differently, and there's no way I want to try to account for all the flavors in Drupal VM's docs.
Rather, as long as the base components are able to work, I point to resources like the official docs, implementations like BLT, and issues like these, and I leave it up to the reader to decide how to implement automated tests into their own projects.

Hello, guys... sorry i bring back to life this old post, maybe nowadays you do things in a totally different way, but one never knows :)
Lately i decided to write again some behat tests and we were thinking of doing also visual regression tests. Now: it is pretty easy to take screenshots using behat, so my question is: do you know guys is there a way of simply comparing those screenshots with a tool in stead of writing new tests from scratch that in the end most likely reflect the same behaviors one already writes in behat/mink tests?
thanks :)

Check out the library dependencies that power PhantomCSS.  There is one JS library in particular that handles the screenshot comparisons.   You may be able to leverage that.
https://huddle.github.io/Resemble.js/

I use [Wraith|https://github.com/BBC-News/wraith] for this.  It fits in to a workflow for testing after changes.
There are some Ansible tasks for installing Wraith and running basic tests here:
https://github.com/kentr/drupal-vm/tree/dev/scripts/misc/tasks

@kevinquillen do you have a documented workflow / integration map you would be willing to share for your use of Drupal-vm with SeleniumHQ?  I am running the Docker Drupal-vm image, but haven't yet been able to sort out how to use that in tandem with the SeleniumHQ Docker images.  I have updated my docker-compose.yml file to include selenium-hub, chrome, and firefox services, but I'm unsure how to get those to a point where they can see the Drupal site running off the drupal-vm image.


Linkerd should strip all headers listed in the Connection header

StripConnectionHeader is removing only the Connection Header.
According to https://www.mnot.net/blog/2011/07/11/what_proxies_must_do not only Connection
but all the headers listed in the Connection header should be removed.
Actually to be complete all the Hop-By-Hop headers should be removed both from the Requests
and the Responses.

Thanks for pointing out this post, @fantayeneh.  Very clear & helpful.


@angular/build – indexHtmlTransformer is missing in buildApplication

Command
build
Description
I am currently trying to prepare @angular-builders/custom-esbuild for NG19 and saw that @angular/build buildApplication has no indexHtmlTransformer like dev-server has.
Describe the solution you'd like
Same extensions for buildApplication as for dev-server's execute.
Describe alternatives you've considered
No response

The application builder already supports this.
See: https://github.com/angular/angular-cli/pull/26667

I was talking about @angular/build not @angular-devkit/build-angular they differ

Oh you right, I have looked up the wrong type definition here: https://github.com/angular/angular-cli/blob/19.0.0-next.13/packages/angular/build/src/builders/application/index.ts#L158
It indeed supports it through "extensions".

Would be nice to export "ApplicationBuilderExtensions" for builder authors tho in "/private" maybe


Using livereload with DDEV (Docker based environment)

Hi,
I've been using this repo for a while now and it's great! Now we switched to docker based environments. We nearly got this working with the latest version 1.5.2, but my livereload does not work correctly. Is there an example available for this maybe somewhere?

Fixed it by exposing the port https://github.com/jellesiderius/ddev-livereload-port


fixes attribution generation for cgo projects

Issue #, if available:
Description of changes:
We had an issue with attribution generation where if it was generated in codebuild during checksum job it wouldnt include deps specific to cgo, but in prow in the nightly it would (im not 100% sure the diff there): https://github.com/aws/eks-anywhere-build-tooling/pull/2560#pullrequestreview-1680634433
This fixes that by export CGO_ENABLED when gathering deps for those projects.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


Show dates for tags

Feature Description
When looking at tags, only their name and commit sha are shown, but not their date.
Showing the dates for tags would be super useful to understand their age, or history of a project at a glance.
Screenshots

Also, we are missing the tag message in this list (indicated by ... on the GitHub UI).


Liferay Theme Generator adds 7.0-theme-deps for new 7.1 theme

Run yo liferay-theme
choose 7.1
package.json contains the following:
{
"devDependencies": {
"gulp": "3.9.1",
"liferay-theme-tasks": "8.0.0-beta.4",
"liferay-theme-deps-7.0": "8.0.0-beta.4"
},
"keywords": [
"liferay-theme"
],
"liferayTheme": {
"baseTheme": "styled",
"screenshot": "",
"rubySass": false,
"templateLanguage": "ftl",
"version": "7.1"
},
"main": "package.json",
"name": "demo-theme",
"version": "1.0.0"
}

should contain "liferay-theme-deps-7.1": "8.0.0-beta.4"

If you don't change this to the proper version, the result it https://github.com/liferay/liferay-themes-sdk/issues/68 after running gulp deploy.
I should also note that it prints this warning after it runs npm install during the theme generation process:
added 971 packages in 24.558s
[14:34:22] Warning: You must install the correct dependencies, please run npm i --save-dev from your theme directory.
[14:34:22] Using gulpfile ~\Desktop\projects\demo-theme\new-kids-on-the-block-theme\gulpfile.js
[14:34:22] Starting 'plugin:init'...
? Enter the path to your app server directory: C:\Users\liferay\opt\Liferay\bundles\7.1.0-ga1\liferay-ce-portal-7.1.0-ga1\tomcat-9.0.6
? Enter the url to your production or development site: http://localhost:8080
[14:38:49] Finished 'plugin:init' after 4.43 min
[14:38:49] Starting 'init'...
[14:38:49] Finished 'init' after 21 μs
I believe the warning is due to the incorrect version of liferay-theme-deps for the 7.1 theme, but I'm not sure.


Bug: Preview less than 100 records

Steps to Reproduce
Step 1

Step
Action
Expected
Status

1
Navigate to the custom data download and select all required fields except for time period
The preview data button should be disabled
Pass

2
Select all required fields (data type, data sub type, time period)
Then the preview data button is enabled
Pass

3
Select preview data button
1. Then the system will display total record count  2. Contains all data elements in the correct order with the correct data labels  3. The data table is limited to 100 records and ordered by facility, unit, date, and hour  4. Table contains a scroll functionality to view all rows and columns  5. results are sortable in ascending and descending order (alpha numeric)
FAIL

Actual Results

results should update dynamically. ex viewing the first 48 out of 48 records

https://epacamd.testquality.com defect D38. Do not remove or edit.

Linked issue is expected to resolve this bug (scheduled to be complete in 4.4). retest in sprint 4.5


Unable to push compiled FAB

Not quite a bug but definitely not a feature, I'm having a weird issue uploading FABs to Wrangler.
Pushed a repo here with what I'm trying to wrangler publish: https://github.com/geelen/fab-cloudflare-error
This is the error I'm getting:
⬇ Installing wranglerjs...
⬇ Installing wasm-pack...
✨  Built successfully, built project size is 293 KiB.
Error: Something went wrong! Status: 400 Bad Request, Details {
  "result": null,
  "success": false,
  "errors": [
    {
      "code": 10021,
      "message": "Uncaught ReferenceError: document is not defined\n  at line 176 in e\n  at line 170 in e\n  at line 148 in 3niX\n  at line 148 in n\n  at line 176 in nWF0\n  at line 148 in n\n  at line 155 in DTay\n  at line 148 in n\n  at line 170 in VDXt\n  at line 148 in n\n"
    }
  ],
  "messages": []
}

Now, what's weird, is that if I copy/paste the dist/main.js file into the Workers console, it runs fine. But if I copy worker/script.js, it fails. But the only difference between the two is the first line:
const window = this;

So... can someone explain why this line's being added? The FAB is already compiled into server.js, the index.js just sets up the event listener. Wrangler has been working for smaller nextjs apps built into a FAB but for some reason this one is dying (could be the presence of next-images or dynamic routes or something but weirdly, just removing that first line fixes things)

Oh, interestingly, I tracked down things a little further:
This is inside the bundle:
  var t =
      arguments.length > 0 && void 0 !== arguments[0]
        ? arguments[0]
        : {},
    n = t.name,
    i = void 0 === n ? 'stylesheet' : n,
    r = t.optimizeForSpeed,
    s = void 0 === r ? o : r,
    u = t.isBrowser,
    p = void 0 === u ? 'undefined' != typeof window : u
  !(function(e, t) {
    if (!(e instanceof t))
      throw new TypeError(
        'Cannot call a class as a function'
      )
  })(this, e),
    c(a(i), '`name` must be a string'),
    (this._name = i),
    (this._deletedRulePlaceholder = '#'.concat(
      i,
      '-deleted-rule____{}'
    )),
    c(
      'boolean' == typeof s,
      '`optimizeForSpeed` must be a boolean'
    ),
    (this._optimizeForSpeed = s),
    (this._isBrowser = p),
    (this._serverSheet = void 0),
    (this._tags = []),
    (this._injected = !1),
    (this._rulesCount = 0)
  var l =
    this._isBrowser &&
    document.querySelector('meta[property="csp-nonce"]')
  this._nonce = l ? l.getAttribute('content') : null
}

That looks like it's a part of styled-jsx (relevant lines):
export default class StyleSheet {
  constructor({
    name = 'stylesheet',
    optimizeForSpeed = isProd,
    isBrowser = typeof window !== 'undefined'
  } = {}) {
    invariant(isString(name), '`name` must be a string')
    this._name = name
    this._deletedRulePlaceholder = `#${name}-deleted-rule____{}`

    invariant(
      typeof optimizeForSpeed === 'boolean',
      '`optimizeForSpeed` must be a boolean'
    )
    this._optimizeForSpeed = optimizeForSpeed
    this._isBrowser = isBrowser

    this._serverSheet = undefined
    this._tags = []
    this._injected = false
    this._rulesCount = 0

    const node =
      this._isBrowser && document.querySelector('meta[property="csp-nonce"]')
    this._nonce = node ? node.getAttribute('content') : null
  }

Lol well I found the culprit, but I wonder why this is here or how I could bypass it:
// We inject some code at the top-level of the Worker; called {prologue}.
// This aims to provide additional support, for instance providing {window}.
pub fn create_prologue() -> String {
    r#"
        const window = this;
    "#
    .to_string()
}

I think it's related to #477. I'm on it.

Using https://github.com/cloudflare/wrangler/pull/490 I can deploy it https://nextjs9-fab-cf-workers.sven.workers.dev. It's a webpack misconfiguration, a workaround would be to specify target: "webworker" in your webpack config.

i think this is solved! if i'm incorrect, please reopen!!


Pinning doesn't work with @helia/json

import { createHelia } from 'helia'
import { json } from '@helia/json'

const helia = await createHelia()
const j = json(helia)

const cid = await j.add([{foo:'bar'}])
await helia.pins.add(cid)

Uncaught Error: No dag walker found for cid codec 512
at #walkDag (file:///Users/julian/dev/meridian-ie/measure-service/node_modules/helia/dist/src/pins.js:96:19)
at file:///Users/julian/dev/meridian-ie/measure-service/node_modules/helia/dist/src/pins.js:53:32
at file:///Users/julian/dev/meridian-ie/measure-service/node_modules/p-queue/dist/index.js:111:37
at PQueue._PQueue_tryToStartAnother (file:///Users/julian/dev/meridian-ie/measure-service/node_modules/p-queue/dist/index.js:285:13)

I'm trying to pin data that I imported using @helia/json. Am I doing something wrong?

The same does work with `@helia/dag-cbor'

Am I doing something wrong?

No, there's no dag walker configured for the json codec - one is added by #247 which should resolve this issue.


Use adapter method for Shakapacker/Webpacker constant

Summary
This change decouples ReactOnRails from the Webpacker constant, enabling ReactOnRails to support both Webpacker v5 & Shakapacker v7 without any breaking changes.
Pull Request checklist
Remove this line after checking all the items here. If the item is not applicable to the PR, both check it out and wrap it by ~.

[x] Add/update test to cover these changes
[ ] Update documentation
[ ] Update CHANGELOG file
Add the CHANGELOG entry at the top of the file.

Other Information
Remove this paragraph and mention any other important and relevant information such as benchmarks.

This change is

This is an interesting implementation. It is a learning opportunity for me.
But I wonder if we need to add such complexity to this project while migrating to Shakapacer 7 is easy and straightforward. Adding an adapter would be good if we have a dependency with a complex upgrade, but in this case, encouraging migration is a better approach.

But I wonder if we need to add such complexity to this project while migrating to Shakapacer 7 is easy and straightforward. Adding an adapter would be good if we have a dependency with a complex upgrade, but in this case, encouraging migration is a better approach.

You're probably right, although I don't think these changes actually add that much more complexity to our code base.
What this change does do is enable any ReactOnRails users who are still using Webpacker 5 (which I believe we're still supporting? We never formally dropped support for it) to continue using Webpacker & enjoy the latest bug fixes, such as https://github.com/shakacode/react_on_rails/pull/1540 or https://github.com/shakacode/react_on_rails/pull/1544.
If we don't support Webpacker 5, then I would agree that the transition from Shakapacker v6 to Shakapacker v7 should be smooth enough that these changes are unnecessary.

Seems like this can work, but is this worth the extra complexity? Can we really have tests for both shakapacker and webpacker dependencies?
Could we just change to Shakapacker for the next version? Why or why not?

@justin808

Seems like this can work, but is this worth the extra complexity?

The only benefit over a simple replace & major version bump is that this would enable users still using Webpacker to enjoy any non-Shakapacker specific fixes or functionality that we add in the future.
Since we don't intend to support any other webpack wrapper, this complexity is likely overkill.

Can we really have tests for both shakapacker and webpacker dependencies?

We could, although that would probably require overhauling the test suite to be similar to react-rails' test suite & possibly even the generators for ReactOnRails.
If we were going to merge this PR, I'd probably go with not changing the test suite & handling any webpacker regressions as clients report them.

Could we just change to Shakapacker v7 for the next version?

It'll require a major version bump for RoR since we're changing the "optional" dependency, but yes.
Then we'll just tell users to upgrade Shakapacker & ReactOnRails together.

I am not in a right position to give opinion on this. I prefer to learn from the decisions.
But I think we don't need to do this unless there is a necessity.

Closing in preference for #1546

I think #1548 satisfies our needs for now.


MINOR: Fix documentation mistake

Codecov Report

Merging #1196 into master will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1196      +/-   ##
==========================================
+ Coverage   47.69%   47.76%   +0.07%
==========================================
  Files         258      258
  Lines       22956    22963       +7
  Branches     5101     5103       +2
==========================================
+ Hits        10948    10968      +20
+ Misses      12008    11995      -13

Impacted Files
Coverage Δ

@here/harp-mapview/lib/MapView.ts
58.93% <ø> (-0.08%)
:arrow_down:

@here/harp-mapview/lib/VisibleTileSet.ts
70% <0%> (+0.02%)
:arrow_up:

@here/harp-mapview/lib/ClipPlanesEvaluator.ts
51.51% <0%> (+0.33%)
:arrow_up:

@here/harp-mapview/lib/FrustumIntersection.ts
89.78% <0%> (+11.67%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 248e690...0f890c5. Read the comment docs.


Updated Elliptic.js package from 6.5.3 to 6.5.4

Elliptic.js 6.5.4 does a check to ensure that the public key passed in to ECDH is a point that actually exists on the curve.
This prevents a twist attack which could be used to reveal the private key of a party in an ECDH operation over a number of occurances.
https://github.com/christianlundkvist/blog/blob/master/2020_05_26_secp256k1_twist_attacks/secp256k1_twist_attacks.md
CVE: CVE-2020-28498

Already added to previous pull request


Documentation: skip-all versus clear-backlog

Is your feature request related to a problem? Please describe.
Documentation shows skip-all followed by clear-backlog, both at the topic with no description of what the difference is.
I don't know when it's appropriate to use one or the other.
Note: there is a separate clear-backlog command documented at the namespace level (rather than the topic level)
UPDATE 1: pulsar-admin doesn't seem to recognise topics skip-all at all.
ubuntu@ldex-pulsar:~$ apache-pulsar-2.4.1/bin/pulsar-admin topics clear-backlog
The following option is required: -s, --subscription

Skip all the messages for the subscription
Usage: clear-backlog [options] persistent://tenant/namespace/topic
  Options:
  * -s, --subscription
       Subscription to be cleared

ubuntu@ldex-pulsar:~$ apache-pulsar-2.4.1/bin/pulsar-admin topics skip-all
Expected a command, got skip-all

Exception in thread "main" com.beust.jcommander.ParameterException: Asking description for unknown command: null
	at com.beust.jcommander.JCommander.getCommandDescription(JCommander.java:1003)
	at com.beust.jcommander.JCommander.usage(JCommander.java:988)
	at com.beust.jcommander.JCommander.usage(JCommander.java:980)
	at com.beust.jcommander.JCommander.usage(JCommander.java:972)
	at org.apache.pulsar.admin.cli.CmdBase.run(CmdBase.java:49)
	at org.apache.pulsar.admin.cli.PulsarAdminTool.run(PulsarAdminTool.java:218)
	at org.apache.pulsar.admin.cli.PulsarAdminTool.main(PulsarAdminTool.java:260)
^C

ubuntu@ldex-pulsar:~$ apache-pulsar-2.4.1/bin/pulsar-admin topics skip-all persistent://public/default/my-topic -s my-subscription
Expected a command, got skip-all

Exception in thread "main" com.beust.jcommander.ParameterException: Asking description for unknown command: null
	at com.beust.jcommander.JCommander.getCommandDescription(JCommander.java:1003)
	at com.beust.jcommander.JCommander.usage(JCommander.java:988)
	at com.beust.jcommander.JCommander.usage(JCommander.java:980)
	at com.beust.jcommander.JCommander.usage(JCommander.java:972)
	at org.apache.pulsar.admin.cli.CmdBase.run(CmdBase.java:49)
	at org.apache.pulsar.admin.cli.PulsarAdminTool.run(PulsarAdminTool.java:218)
	at org.apache.pulsar.admin.cli.PulsarAdminTool.main(PulsarAdminTool.java:260)
^C

But there appears to be a test case for it in pulsar-client-tools-test/src/test/java/org/apache/pulsar/admin/cli/PulsarAdminToolTest.java
        topics.run(split("skip-all persistent://myprop/clust/ns1/ds1 -s sub1"));
        verify(mockTopics).skipAllMessages("persistent://myprop/clust/ns1/ds1", "sub1");

clear-backlog works at the topic+subscription level:
ubuntu@ldex-pulsar:~$ apache-pulsar-2.4.1/bin/pulsar-admin topics clear-backlog persistent://public/default/my-topic -s my-subscription
ubuntu@ldex-pulsar:~$

@candlerb thank you very much for raising the issue.
I notice that skip means skip some messages for the subscription, and clear-backlog means clear backlog (skip all messages) for the subscription. For detailed usage, see the links I provided.

@candlerb skip-all has been removed from recent releases. the documentation has been updated.


Improve $Compose helper

Proposal
I worked a bit on flow-typed definitions, and had troubles to type ramda.pipe function.
I'm trying to remove * usage from the definition, mainly around Curry.
Currently we have:
https://github.com/flow-typed/flow-typed/blob/89b0d35e3ad239b51762faef6478ec5881504f52/definitions/npm/ramda_v0.26.x/flow_v0.104.x-/ramda_v0.26.x.js#L33-L41
  declare type __CurriedFunction1<A, R, AA: A> = (...r: [AA]) => R;
  declare type CurriedFunction1<A, R> = __CurriedFunction1<A, R, *>;

  declare type __CurriedFunction2<A, B, R, AA: A, BB: B> = (
    ((...r: [AA]) => CurriedFunction1<BB, R>) &
    ((...r: [$npm$ramda$Placeholder, BB]) => CurriedFunction1<AA, R>) &
    ((...r: [AA, BB]) => R)
  );
  declare type CurriedFunction2<A, B, R> = __CurriedFunction2<A, B, R, *, *>;

I manage to make it works with the current definition:
https://github.com/moroine/flow-typed/blob/1897df81e66e43c278e092ac051f857b128389da/definitions/npm/ramda_v0.26.x/flow_v0.104.x-/ramda_v0.26.x.js#L61-L67
  declare type CurriedFunction1<A, R> = (...r: [A & A]) => R;

  declare type CurriedFunction2<A, B, R> = (
    ((...r: [A]) => CurriedFunction1<B, R>) &
    ((...r: [A, B]) => R) &
    ((...r: [$npm$ramda$Placeholder, B]) => CurriedFunction1<A, R>)
  );

Unfortunately, this causes new errors around pipe definition...
The issue here is we can't use $Compose & $ComposeReverse as they create unary function but ramda will pass all given parameters to the first function.
$Compose & $ComposeReverse were introduced by https://github.com/facebook/flow/commit/ab9bf44c725efd2ed6d7e1e957c5566b6eb6f688
Here we have different usage:

Library returning only unary:

Redux

Library returning function with the same arity of the first one

Lodash
Ramda

Proposition
I think it would be great to support Lodash & Ramda behavior with a way to keep support for Redux.
I've started doing some work here and it seems to work as expected (I'm just staring learning ocaml, so code is not that good) https://github.com/moroine/flow/commit/67f2ca026b9dc1a6a58f6478e55359141ad81185
Finally, as a side note, I think flow should propose more built-in helper to ease library definitions which is currently a pain to properly type, common operations such as omit or more advanced such as curry.

We are unlikely to augment $Compose, as each special cased type introduces maintenance burden and we have to worry about how it interacts with other parts of the system, especially with generics.


Controller does not support nav_core::BaseLocalPlanner

Original move_base's nav_core::BaseLocalPlanner is inherited from, but not properly supported.

This is not on the roadmap. We decided to support path_tracking_pid only as a move_base_flex plugin (mbf_costmap_core::CostmapController). We should remove the inheritance from nav_core::BaseLocalPlanner.


feat(superset): Add patch that fixes saved queries export

Description
Patch is taken from https://github.com/apache/superset/pull/26889.
Ideally I would like to wait with merge until the linked PR is merged
Definition of Done Checklist

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
Please make sure all these things are done and tick the boxes

- [ ] Changes are OpenShift compatible
- [ ] All added packages (via microdnf or otherwise) have a comment on why they are added
- [ ] Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
- [ ] All packages should have (if available) signatures/hashes verified
- [ ] Does your change affect an SBOM? Make sure to update all SBOMs

Just for documentation purposes: Can you briefly say which version of Superset you expect this to be released in?

I'm not entirely sure, but I think it will be in the next patch releases of 3.0.x and 3.1.x


Ton of DEPRECATE_MESSAGE warnings

Sample:
gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wformat -fPIC -I/remote/wheel/vision/test -I/remote/wheel/vision/torchvision/csrc/models -I/opt/python/cp37-cp37m/lib/python3.7/site-packages/torch/include -I/opt/python/cp37-cp37m/lib/python3.7/site-packages/torch/include/torch/csrc/api/include -I/opt/python/cp37-cp37m/lib/python3.7/site-packages/torch/include/TH -I/opt/python/cp37-cp37m/lib/python3.7/site-packages/torch/include/THC -I/opt/python/cp37-cp37m/include/python3.7m -c /remote/wheel/vision/torchvision/csrc/models/shufflenetv2.cpp -o build/temp.linux-x86_64-3.7/remote/wheel/vision/torchvision/csrc/models/shufflenetv2.o -DTORCH_API_INCLUDE_EXTENSION_H -DTORCH_EXTENSION_NAME=_C_tests -D_GLIBCXX_USE_CXX11_ABI
=0 -std=c++11          #warning DEPRECATE_MESSAGE [-Wcpp]                            :
 #  warning DEPRECATE_MESSAGEthon3.7/site-packages/torch/include/torch/csrc/api/include/torch/    ^

cc @ShahriarSS as this seems to be in the C++ models codepath

I think that I have seen the messages. I'll look into this @fmassa

Warnings:
/usr/lib/python3.7/site-packages/torch/include/c10/util/ArrayRef.h: In instantiation of ‘constexpr c10::ArrayRef<T>::ArrayRef(const std::initializer_list<_Tp>&) [with T = unsigned char]’:
/usr/lib/python3.7/site-packages/torch/include/ATen/NativeFunctions.h:47:1:   required from here
/usr/lib/python3.7/site-packages/torch/include/c10/util/ArrayRef.h:103:39: warning: initializing ‘c10::ArrayRef<unsigned char>::Data’ from ‘std::initializer_list<unsigned char>::begin’ does not extend the lifetime of the underlying array [-Winit-list-lifetime]

This goes for most of the basic types here: with T = unsigned char.
/usr/lib/python3.7/site-packages/torch/include/ATen/Dispatch.h:163:56: warning: ‘c10::ScalarType detail::scalar_type(const at::DeprecatedTypeProperties&)’ is deprecated [-Wdeprecated-declarations]
  163 |     at::ScalarType _st = ::detail::scalar_type(the_type);                    \
      |                                                        ^
/home/shahriar/Music/vision/torchvision/csrc/cpu/ROIPool_cpu.cpp:152:3: note: in expansion of macro ‘AT_DISPATCH_FLOATING_TYPES_AND_HALF’
  152 |   AT_DISPATCH_FLOATING_TYPES_AND_HALF(input.type(), "ROIPool_forward", [&] {
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/lib/python3.7/site-packages/torch/include/ATen/Dispatch.h:78:23: note: declared here
   78 | inline at::ScalarType scalar_type(const at::DeprecatedTypeProperties &t) {
      |

/usr/lib/python3.7/site-packages/torch/include/torch/csrc/api/include/torch/torch.h:14:4: warning: #warning DEPRECATE_MESSAGE [-Wcpp]
   14 | #  warning DEPRECATE_MESSAGE
      |    ^~~~~~~
In file included from /usr/lib/python3.7/site-packages/torch/include/c10/core/MemoryFormat.h:5,
                 from /usr/lib/python3.7/site-packages/torch/include/ATen/core/Tensor.h:5,
                 from /usr/lib/python3.7/site-packages/torch/include/ATen/Tensor.h:2,
                 from /usr/lib/python3.7/site-packages/torch/include/ATen/Context.h:4,
                 from /usr/lib/python3.7/site-packages/torch/include/ATen/ATen.h:5,
                 from /usr/lib/python3.7/site-packages/torch/include/torch/csrc/api/include/torch/types.h:3,
                 from /usr/lib/python3.7/site-packages/torch/include/torch/csrc/api/include/torch/data/dataloader_options.h:4,
                 from /usr/lib/python3.7/site-packages/torch/include/torch/csrc/api/include/torch/data/dataloader/base.h:3,
                 from /usr/lib/python3.7/site-packages/torch/include/torch/csrc/api/include/torch/data/dataloader/stateful.h:3,
                 from /usr/lib/python3.7/site-packages/torch/include/torch/csrc/api/include/torch/data/dataloader.h:3,
                 from /usr/lib/python3.7/site-packages/torch/include/torch/csrc/api/include/torch/data.h:3,
                 from /usr/lib/python3.7/site-packages/torch/include/torch/csrc/api/include/torch/all.h:4,
                 from /usr/lib/python3.7/site-packages/torch/include/torch/csrc/api/include/torch/torch.h:3,
                 from /home/shahriar/Music/vision/torchvision/csrc/models/vgg.h:4,
                 from /home/shahriar/Music/vision/torchvision/csrc/models/vgg.cpp:1:

The first one is every where but the second one is in /home/shahriar/Music/vision/torchvision/csrc/cpu/ROIAlign_cpu.cpp and /home/shahriar/Music/vision/torchvision/csrc/cpu/nms_cpu.cpp.

I think you literally just have to change what header you import. The warning is bad because someone is trying to interpolate a string but that doesn't work in pragmas. The real error is:
#ifdef _MSC_VER
#  pragma message ( "Including torch/torch.h for C++ extensions is deprecated. Please include torch/extension.h" )
#else
#  warning "Including torch/torch.h for C++ extensions is deprecated. Please include torch/extension.h"
#endif

@ezyang Apparenty including extension.h where you bind the functions is not enough. It needs to be included in all of the headers (I may be wrong here. I'll need to test this out). But apparently the other messages are not because of the code. I wrote a simple code here but when I build this simple PR I get a lot of similar messages.

Yes, I could believe that we need to avoid including torch/torch.h in all cases, to fix this.

@ezyang I'll send a PR fixing this but the naming doesn't seem right. The models or datasets are not an extension to the Python API.

Hmm, maybe hold off.
Are you saying that these includes occur from C++ only headers? In that case, it definitely is wrong to switch them to extension.h. So perhaps the chain of problem is that these headers are transitively included from a Python extension, and then we trigger the warning. Hmm... I'm not so sure what to do; maybe the warning is wrong in the first place.

@ezyang The problem is that these headers (models headers) are both the public C++ API and included in test/test_models.cpp (to be able to compare them to python API). So they are directly included in extension code. I just think that public C++ API headers should include torch/torch.h and not torch/extension.h.

Yes, I'd agree with you.

So @ezyang what should we do here?

I'm thinking we should remove the deprecation warning from PyTorch itself. I'm halfway about whether or not we should force c++ extension writers to include torch/extension.h to get pybind bits. Do you want to submit this patch?

The patch only removes the deprecated warning message? If so then I'll open a PR for it in PyTorch.

sure


Completion improvement, fixed search and implemented replace.

Entry also reworked into EntryBox, which is more clean and easy to use.
Use enter to search/replace forward, and shift-enter to search/replace backward. Is the Find and Replace buttons really necessary? Guess very few use mouse clicks to search forward and backwards now.
Also focus on entry box is fixed. For instance press tab to swap between find and replace entry-fields.
Use escape to cancel/close entrybox.
Also, the tooltips and similar token markings are abit less eager now, only identifiers get tooltips (that is for instance (), :: -> etc no longer hold tooltips or get marked as similar tokens).
Hmm also, should the entry box be below the sourceview? When entrybox pops up now the sourcetext is moved down. If entrybox is below the sourceview the position of the cursor will be the same on the screen.

Right now the syntax highlighting for clang files and non-clang files are different. I guess we can use the styles from gtksourceviewmm? With some adjustments to colors etc of course, like in the current clang-colors for light-theme.

See last commit. We could use these colors in json.config, for instance:
    "source": {
        "colors": {
            "text_color": "text",
            "comment": "def:comment",
            ...

See for instance /usr/share/gtksourceview-3.0/styles/classic.xml for definition of "text" and "def:comment". We could create two such files and add them to the juci-user directory (~/.juci?). Also we could add an option in config.json to enable or disable use of dark-theme (https://developer.gnome.org/gtkmm/stable/classGtk_1_1Settings.html#a40ac901fea4b95dedf972ed5aa971c51)

We also need an option in config.json to select gtksourceview style.


Reencode mismatch with community patch

The neweset version of the community patch seems to have a reencode mismatch, if I try to load the save file. I dont know, maybe not an issue, if you don´t want to support the community patch, but I think a lot of people are using it.

https://github.com/gibbed/Gibbed.Borderlands2/releases

I wouldn't mind creating a branch for the community patch if there is an actual issue. If after grabbing the latest release, you're still getting reencode mismatch, please provide some sample save files and I can take a look.

Getting the reenchode mismatch with the latest verion. I'm getting it with all my saves. here is one of them
Save0001.zip

@MengusDew Your save sample loads fine in the latest build.

Ok. So If I do indeed have the latest version of the editor, and I still get this error message, yet you do not, even though we are using the exact same save file, then there obviously is something else awry. I noticed that I'm not the only one running into this situation. Maybe it has something to do with windows 10. I dun know.

So when you're running the editor you see this title?


guard-else

Now that we have isExit for other reasons, Swift-style guard seems implementable. At first glance, it seems identical to unless:
guard CONDITION else {
  STATEMENTS
}
// vvv
if (!CONDITION) {
  STATEMENTS
}

However, there are two key differences:

If the condition creates any bindings (such as guard x? := getX() else { ... }), the bindings are only available outside the else block.
STATEMENTS must be an "exit" of some sort, in order for 1 to be possible.

The primary use case is to prevent "pyramids of doom" when there are many bindings to be done:
if x? := getX()
  if y? := getY()
    if z? := getZ()
      setPoint x, y, z
// vvv
guard x? := getX() else return
guard y? := getY() else return
guard z? := getZ() else return
setPoint x, y, z

Supersedes #756 I suppose

A couple thoughts:
I'm reluctant to add any more reserved words like guard. Would unless x? := getX() else return be an acceptable spelling of this feature?
Maybe upgrading pipes to better handle piping to return/throw and allowing something similar to declaration conditions could help with this. https://github.com/DanielXMoore/Civet/issues/897#issuecomment-2002531328
x := getX() !> return
---
let ref = getX(); if(!ref) return ref; const x = ref;

Possible conditional pipe options: ?>, !>, ?|>, !|> maybe something else?

unless-else reads like a double-negative, but otherwise I'd be fine with it.


fixed ci

Moved the build from the install dependency section to the test section due to the dependency install being skipped.

Move npm run build:main to a seperate job


VScode over SSH does not load remote folder structure in May 2020 update

Issue Type: Bug
Try to connect to remote folder over SSH
Enter password in drop-down alert box as before
File structure in explorer pane fails to load
VS Code version: Code 1.46.0 (a5d1cc28bb5da32ec67e86cc50f84c67cc690321, 2020-06-10T08:59:06.977Z)
OS version: Darwin x64 19.5.0
Remote OS version: Linux x64 4.15.0-76-generic

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (12 x 2600)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
1, 2, 2

Memory (System)
16.00GB (2.30GB free)

Process Argv

Screen Reader
no

VM
0%

Item
Value

Remote
SSH: api.timetrack.local

OS
Linux x64 4.15.0-76-generic

CPUs
Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (1 x 2592)

Memory (System)
1.95GB (1.15GB free)

VM
100%

Extensions (5)

Extension
Author (truncated)
Version

vscode-eslint
dba
2.1.5

VS-code-vagrantfile
mar
0.0.7

vscode-docker
ms-
1.2.1

remote-ssh
ms-
0.51.0

remote-ssh-edit
ms-
0.51.0

Downloaded April 2020 version and the problem is there too - not related to new release, some other cause

Also another SSH configuration to the parent fodler of the same VM works - tied somehow to the connection configuration?

Solved - hadn't correctly synched VM directory with local system - nothing to do with VSCode


Add CLI file opening and the ability to use "Open With"

it would be much faster to open files if you could do it from the command line or through many file managers open with function

#303
made a PR with the tiny amount of changes that need to happen for it to work

I don't understand this use case, could you explain it so I can understand it better?

so, basically i can open up a terminal and run
GodSVG.x86_64 and it opens it but with the few lines I added i can also run GodSVG.x86_64 /path/to/svg/file and it will immediatly open up the svg you provide the path to. Ive done some experiments 6 months or so ago and I figured out this also enables file managers to use your program as the default for opening X file type, in your case svg. It saves the hassle of having to open the app, go to import and find you file. you can just directly open your app with the file there by default

my git imploded and started causing errors on things i haven't touched so i will just redo it tomorrow

#305
Here we go, this should work


Aurelia-Polymer1-TypeScript-Electron?

Hi,
Thank you for Aurelia-MateriazlieCSS-TypeScript-Electron.
I thought it should be my scaffold. But after looking at Polymer 1.0, I think I should use Aurelia-TypeScript -Polymer 1.0?? I’m afraid of much trouble with Polymer.
How do you think about Polymer 1.0? It has much more components than materializeCSS.
I wish someone provides a skeleton of Aurelia-Polymer1-TypeScript-Electron.
This one is a DB example with Aurelia+MateriarizeCSS. It provides a glue logic to materializeCSS for  and others works with Aurelia.
https://github.com/jdanyow/aurelia-breeze-northwind
Hirano Satoshi

I decided to use materializeCSS simply because after speaking on gitter I learned from Rob Eisenberg that Aurelia will eventually have a front-end framework (something like aurelia-interface which is currently on github). Thus I felt that simply using CSS instead of another framework like polymer would be ok for the development state Aurelia is currently in (i.e. not production ready).

Thank you for reply.
MaterializeCSS is good choice since it seems nearly completed.
Aurelia-Interface seems quite incomplete and stops for long time.
I'm trying Polymer with Aurelia because Web components will become very popular maybe.


Make wording for padding a little clearer

Pre-Submission Checklist

[x] Your pull request targets the staging branch of FreeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[x] You have only one commit (if not, squash them into one commit).
[x] All new and existing tests pass the command npm run test-challenges. Use git commit --amend to amend any fixes.

Type of Change

[x] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[x] Tested changes locally.
[ ] Closes currently open issue (replace XXXX with an issue no): Closes #XXXX

Description

Well however you choise To Comprehend or rebel in post doctorate's
nevertheless You throw yourself to others and as Captain I Shall recover my
systems wether yourself as spawn of God knows when why how come and all
percewhats my holy ones are not included in your misery nor shall I take I
make do you may have her the girl but your stupor is behind me an they in
turn have no right to fulfilling their way that fox if o lion who really
don't care or their cohorts in Kiki me I Shall return in Force the way is
Supported and clear backsliding won't help Insanity is defined and as for
rescues times up with Vengeance and the point is now why should I relent to
animals even my Animals know the way yet perdition is what you say as icing
on the cake no ain't gonna happen then why assume their stance when clearly
they weren't born of you...and usury is folly now discover the second Sam
as featured in the pig Slaughter and boo boo kills them Wolves cup
celebrity Jack in a boxes at the ridge way waterhole ru
On Aug 14, 2016 08:00, "Deborah Digges"<EMAIL_ADDRESS>wrote:

Pre-Submission Checklist

Your pull request targets the staging branch of FreeCodeCamp.
Branch starts with either fix/, feature/, or translate/ (e.g.
fix/signin-issue)
You have only one commit (if not, squash
http://forum.freecodecamp.com/t/how-to-squash-multiple-commits-into-one-with-git/13231
them into one commit).
All new and existing tests pass the command npm run test-challenges.
Use git commit --amend to amend any fixes.

Type of Change

Small bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds new functionality)
Breaking change (fix or feature that would change existing
functionality)
Add new translation (feature adding new translations)

Checklist:

Tested changes locally.
Closes currently open issue (replace XXXX with an issue no): Closes
#XXXX

Description
You can view, comment on, or merge this pull request online at:
https://github.com/FreeCodeCamp/FreeCodeCamp/pull/10204
Commit Summary

Make wording for padding a little clearer

File Changes

M seed/challenges/01-front-end-development-certification/
html5-and-css.json
https://github.com/FreeCodeCamp/FreeCodeCamp/pull/10204/files#diff-0
(2)

Patch Links:

https://github.com/FreeCodeCamp/FreeCodeCamp/pull/10204.patch
https://github.com/FreeCodeCamp/FreeCodeCamp/pull/10204.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/FreeCodeCamp/FreeCodeCamp/pull/10204, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ATKpwsUe9ffuSke9_pGD58a4jtx6dQ-eks5qfxFrgaJpZM4Jj5Cw
.

A second Oddessy Retarded grow up...
On Aug 14, 2016 08:24, "ACTORe Screen"<EMAIL_ADDRESS>wrote:

Well however you choise To Comprehend or rebel in post doctorate's
nevertheless You throw yourself to others and as Captain I Shall recover my
systems wether yourself as spawn of God knows when why how come and all
percewhats my holy ones are not included in your misery nor shall I take I
make do you may have her the girl but your stupor is behind me an they in
turn have no right to fulfilling their way that fox if o lion who really
don't care or their cohorts in Kiki me I Shall return in Force the way is
Supported and clear backsliding won't help Insanity is defined and as for
rescues times up with Vengeance and the point is now why should I relent to
animals even my Animals know the way yet perdition is what you say as icing
on the cake no ain't gonna happen then why assume their stance when clearly
they weren't born of you...and usury is folly now discover the second Sam
as featured in the pig Slaughter and boo boo kills them Wolves cup
celebrity Jack in a boxes at the ridge way waterhole ru
On Aug 14, 2016 08:00, "Deborah Digges"<EMAIL_ADDRESS>wrote:

Pre-Submission Checklist

Your pull request targets the staging branch of FreeCodeCamp.
Branch starts with either fix/, feature/, or translate/ (e.g.
fix/signin-issue)
You have only one commit (if not, squash
http://forum.freecodecamp.com/t/how-to-squash-multiple-commits-into-one-with-git/13231
them into one commit).
All new and existing tests pass the command npm run test-challenges.
Use git commit --amend to amend any fixes.

Type of Change

Small bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds new functionality)
Breaking change (fix or feature that would change existing
functionality)
Add new translation (feature adding new translations)

Checklist:

Tested changes locally.
Closes currently open issue (replace XXXX with an issue no): Closes
#XXXX

Description
You can view, comment on, or merge this pull request online at:
https://github.com/FreeCodeCamp/FreeCodeCamp/pull/10204
Commit Summary

Make wording for padding a little clearer

File Changes

M seed/challenges/01-front-end-development-certification/html5
-and-css.json
https://github.com/FreeCodeCamp/FreeCodeCamp/pull/10204/files#diff-0
(2)

Patch Links:

https://github.com/FreeCodeCamp/FreeCodeCamp/pull/10204.patch
https://github.com/FreeCodeCamp/FreeCodeCamp/pull/10204.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/FreeCodeCamp/FreeCodeCamp/pull/10204, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ATKpwsUe9ffuSke9_pGD58a4jtx6dQ-eks5qfxFrgaJpZM4Jj5Cw
.

LGTM 👍
Thanks for contributing @Deborah-Digges 🎉


Improve unfavorite consistency

This improves the consistency between favorite and unfavorite methods and add a bang version of unfavorite method.

Any news on this ? 😃

Thanks!


WFLY-14359 ProtoStream marshallers for Object[] should not use packed encoding

Also, WFLY-14270 ProtoStream proxy marshalling should not imply JBoss Modules
Ensures all java.lang.* marshallers use valid protobuf encoding.
https://issues.redhat.com/browse/WFLY-14359
https://issues.redhat.com/browse/WFLY-14270

@rhusar Please review.

@rhusar Please review.

/retest


3.0.0-alpha6: "openssl pkcs12" is unable to parse or create PKCS#12 archives with default ciphers

This PR makes the following two changes in openssl-pkcs12 to fix #11672 :

Changes the default encryption algorithms for certificates and private keys from RC2 to AES_256_CBC in OpenSSL 3.0
Add a new option "-legacy" to the pkcs12 cli which loads the legacy provider and restores the default algorithms
The default algorithm for private key encryption is 3DES_CBC. If the legacy option is not specified, then
the legacy provider is not loaded and the default encryption algorithm for both certificates and private keys is
AES_256_CBC by default.

The above design was proposed by @t8m as per the comments in the discussion #11672 that were agreed upon.
Documentation and example section is updated.
No new tests are added. The cli usage is documented under examples.
Usage:
openssl pkcs12 -in cert.pem -inkey key.pem -out foo.p12 -export
openssl pkcs12 -info -in foo.p12
with the legacy option:
openssl pkcs12 -in cert.pem -inkey key.pem -out foo.p12 -export -legacy
openssl pkcs12 -info -in foo.p12 -legacy
Note: certs and keys can be generated using the below command
openssl req -x509 -newkey rsa:4096 -keyout key.pem -out cert.pem -days 365

Checklist

[x] documentation is added or updated
[ ] tests are added or updated

closing this PR and re-opening it again so that CLA flag gets updated.

Had closed it previously as cla flag was not updated.

A few more doc nits.

Fixed.

Closed by mistake

This pull request is ready to merge

I've squashed the commits and merged them to master.
Thank you for the PR.

Hmmm, should this become a standard option alongside -provider and -provider_path?  I can't really see how it's justifiable to special case the "pkcs12" command...

Do we have clear use cases for this option with other commands? Or do you mean the generalized case to be "just load the legacy and default provider"?

The special case here is that we clearly need to change the defaults to something more modern with pkcs12 but the old defaults might be needed for interoperability AND they require the legacy provider. With other commands I do not see urgent need to change the defaults but if you think about any, where it makes sense, I'd agree with the generalization.


difft does shows single/double quote as a diff for python

Great tool!
(1) A description of the issue. A screenshot is often helpful too.
I'm comparing two python files, where the majority of changes is a swap between single and double quotes, which should be ignored.
However difftastic shows quote changes as a difference.

(2) A copy of what you're diffing. I'm diffing files.
Before:
def my_func():
    print("Hello World")

After:
def my_func():
    print('Hello World')

Expected result: no differences.
(3) The version of difftastic you're using (see difft --version) and your operating system.
Difftastic 0.58.0 (0c92771 2024-05-10, built with rustc 1.65.0)
Running on Windows 11.

This is intentional I'm afraid. Difftastic is a syntactic differ, and semantic information about which string literals are equivalent are out of scope. In some languages, single-quoted strings and double-quoted strings are different (e.g. in bash or PHP) due to different interpolation rules.

Fair. Any chance you can point me to a place where I can make this change in my forked repo? Something like a place where difftastic gets a list of changes to output? I want to manually remove single/double quote differences.

@eduard93 you should be able to change what's considered the content of the Atom when it's a string here:
https://github.com/Wilfred/difftastic/blob/b88b4056203cdd3075cd341595411195671a163b/src/parse/syntax.rs#L411
If it's an AtomKind::String, drop the first and last characters of content.

Thinking about this some more, I think this is a worthwhile addition, but language configurations should opt-in to it.

@eduard93 you should be able to change what's considered the content of the Atom when it's a string here:
https://github.com/Wilfred/difftastic/blob/b88b4056203cdd3075cd341595411195671a163b/src/parse/syntax.rs#L411
If it's an AtomKind::String, drop the first and last characters of content.

First and last characters are not very clean I am aftaid. The Python itself has variable length of string delimiters:
my_string = """Hello, World!
I love multiline strings.
"""
other_string = '''Hello, World!
I love multiline strings.
'''

assert my_string == other_string

Good news is that TS understands this; so maybe we can opt-in to take left and right node around the string? Here is generated tree, note "string_start" and "string_end" nodes.


Please add error 530021

Hi, we receive the error code 530021 with failure reason 'other'

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fa732de6-2cab-d780-aa21-dfec80e0a8fe
Version Independent ID: 1a11b9b6-cf4f-3581-0864-0d5046943b6e
Content: Sign-in activity report error codes in the Azure Active Directory portal
Content Source: articles/active-directory/reports-monitoring/reference-sign-ins-error-codes.md
Service: active-directory
Sub-service: report-monitor
GitHub Login: @MarkusVi
Microsoft Alias: markvi

@lin-art Thanks for the feedback !  I have assigned this issue to content author to investigate and update the document as appropriate.

Hi @lin-art, I have staged an update for this.
#please-close


Disable donated_buffer for all ops's backward benchmarking

It is still a temporary fix for backward benchmarking. Related discussion https://github.com/pytorch-labs/tritonbench/issues/40

It looks the ci errors are true, and the config is not compatible with flash_attention. I'm going to set this config for fused_linear_cross_entropy, geglu, and swiglu  only.


[WIP] Katy Perry 1.10 in GKE

The issue is described here on Stack Overflow. It appears that kubectl only maintains compatibility within one minor version of the Katy Perry master. This seems to explain why some commands work while others don't.
I'm waiting to verify this change as fixing the problem.

Confirmed. The API now works:
[vagrant@katyperry vagrant]$ kubectl version
Client Version: version.Info{Major:"1", Minor:"11", GitVersion:"v1.11.0", GitCommit:"91e7b4fd31fcd3d5f436da26c980becec37ceefe", GitTreeState:"clean", BuildDate:"2018-06-27T20:17:28Z", GoVersion:"go1.10.2", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"10+", GitVersion:"v1.10.4-gke.2", GitCommit:"eb2e43842aaa21d6f0bb65d6adf5a84bbdc62eaf", GitTreeState:"clean", BuildDate:"2018-06-15T21:48:39Z", GoVersion:"go1.9.3b4", Compiler:"gc", Platform:"linux/amd64"}
[vagrant@katyperry vagrant]$ kubectl get nodes
NAME                                   STATUS    ROLES     AGE       VERSION
gke-gke-test-1-default-5989a78d-dpk9   Ready     <none>    42s       v1.10.4-gke.2
gke-gke-test-1-default-5989a78d-kh9b   Ready     <none>    58s       v1.10.4-gke.2
gke-gke-test-1-default-653ba633-091s   Ready     <none>    46s       v1.10.4-gke.2
gke-gke-test-1-default-653ba633-4zqq   Ready     <none>    46s       v1.10.4-gke.2
gke-gke-test-1-default-848661e8-cv53   Ready     <none>    53s       v1.10.4-gke.2
gke-gke-test-1-default-848661e8-vfr6   Ready     <none>    52s       v1.10.4-gke.2

At least I didn't lose a day to this :roll_eyes:


Partial fix #401 deprecated directive: parser_class_name

I am not sure how to solve the second part of #401 . The compiler does not really pin-point the position of the problem. I need to read more about shift/reduce errors

it looks like there is an update in my stack that is not in the CI

only affects my stack


use pip install for open-ce

Checklist before submitting

[x] Did you read the contributor guide?
[ ] Did you update any affected documentation?
[ ] Did you write any tests to validate this change?

Description
IUse pip install for open-ce, so that imports are successful.
Review process to land

All tests and other checks must succeed.
At least one maintainer must review and approve.
If any  maintainer requests changes, they must be addressed.

mistakenly created this duplicate PR. closing it.


feat(connector): [Adyen] implement Momo for Adyen

Type of Change

[ ] Bugfix
[x] New feature
[x] Enhancement
[ ] Refactoring
[ ] Dependency updates
[ ] Documentation
[ ] CI/CD

Description

Momo pay is a Vietnam specific payment method.
"payment_method_type": "momo",
  "payment_method_data": {
    "wallet": {
      "momo_redirect": {}
    }
  }

Additional Changes

[x] This PR modifies the API contract
[x] This PR modifies the database schema
[ ] This PR modifies application configuration/environment variables

Checklist

[x] I formatted the code cargo +nightly fmt --all
[x] I addressed lints thrown by cargo clippy
[x] I reviewed submitted code
[ ] I added unit tests for my changes where possible
[ ] I added a CHANGELOG entry if applicable

Testing not possible?

Success Scenario cannot be tested for Momo Pay, as they will display a QR image in the redirection page. To authorize that payment we need an account with Momo pay(requires a Vietnam mobile number). But if we wait for 9 more mins the payment gets cancelled and we are redirected with the cancelled status.

Flows impacted: Payment create / confirm
Connector: Adyen
Payment Method: Momo
Test cases:
Create Momo payment with automatic capture and complete refund
Create Momo payment with automatic capture and partial multiple refund
Create Momo payment with manual capture and payment should fail as manual capture payment is not supported by the connector


Short solution needed: "Add cookie to the request" (curl)

Please help us write most modern and shortest code solution for this issue:
Add cookie to the request (technology: curl)
Fast way
Just write the code solution in the comments.
Prefered way

Create pull request with a new code file inside inbox folder.
Don't forget to use comments to make solution explained.
Link to this issue in comments of pull request.

Add cookie to the request


Support MySQL on arm64 (Apple Silicon M1)

Unfortunately, Oracle does not provide Debian packages for MySQL (any version).
As noted in the docs and because there are no options for mysql packages or images, DDEV on the Mac M1 (and any other arm64) does not currently have the capability to use MySQL as a db server.
There are a few ways we may be able to solve this:

Of course Oracle could support Debian arm64 and provide packages for it. Then there would be a docker image, or we could build one.  The request for this is https://github.com/docker-library/mysql/issues/318
There is an OracleLinux docker image of MySQL 8 (only) at https://hub.docker.com/r/mysql/mysql-server - so it would be possible to implement mysql 8 right now with some nontrivial Docker work. This might relieve some of the pressure.
We could build MySQL for arm64 ourselves and incorporate it into an image. This is likely to work but means yet another thing to maintain, and it's not easy. And of course there is risk, because we're not Oracle and don't know the ins and outs of what might need to be enabled in the build. This would be a whole effort to automate the build of MySQL and then build images for it.
We could allow the use of the amd64 MySQL images with ddev on arm64. This can work on the Apple M1 (doesn't help at all on other arm64 architectures). However, because it's emulated, it's both risky (lots of crashes reported) and has performance problems.

The most likely options at this point are 2 and 3 but it will likely require somebody to sponsor the effort or take it on themselves.
Please remember that the vast majority of uses of MySQL work fine with recent MariaDB. This isn't true of every single website, as some things about MariaDB and MySQL have diverged in recent years. But mostly...

It turns out that Ubuntu 18.04 arm64 has a mysql-server-5.7 package, and Ubuntu 20.04 has mysql-server-8.0. Those are the key two items to support, and we shouldn't really have any trouble with it I don't think.  I don't see a particular reason to support mysql versions earlier than 5.7, so just 5.7 and 8.0 should be fine.

build_image.sh conflates DATABASE_TYPE and the actual image FROM. So it uses "mysql" as both the database type and the FROM. Because they are the same in dockerhub normally.
build_image.sh will have to derive an upstream FROM as a separate variable and pass that into the dockerfile. Probably with better naming.
We'll need to push drud/mysql:5.7 and drud/mysql:8.0 images
It might be possible to use the drud-pushed images instead of the official mysql images and then have exactly the same on arm64/amd64. But it would prevent forward movement probably on new releases. Not sure.


Pre Build Windows Version is detected as trojan by several scanners

The newest prebuild windows version is detected as trojan by several antivirus scanners.
22/71 on virustotal.com

This is a common issue for packaged Python executables I'm afraid, and there is very little that can be done about it from the proxy's side. The executable is built automatically from source, so there's no possibility for malicious tampering, and it is safe to ignore the warning. If it helps you are welcome to report this false positive to the various virus scanners (e.g., see this previous discussion.


Improve tray compatibility

Send more events for version 3 icons (cairoshell/cairoshell#517)
Remove version hack superseded by ExplorerTrayService
Fix logging for NIM_DELETE
Fix icon hide/un-hide after icon added (fixes Spotify)
Fix bad icon version updates being allowed

Oh dear, the CI is publishing PRs to Nuget. I'll fix that here too.

Oh dear, the CI is publishing PRs to Nuget. I'll fix that here too.