Fix the annotation for ROCm in tensorflow image

Fix the annotation for ROCm in tensorflow image
Related-to: https://issues.redhat.com/browse/RHOAIENG-13409

/lgtm
/approve


⚠ Bofrost.fr has degraded performance

In 4d5273b, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1543 ms

Resolved: Bofrost.fr performance has improved in 3514262 after 27 minutes.


Optimise trajectory animations with animejs library usage

Hi @koonpeng @matiasbavera,
I experimented and compared with using GSAP and animejs for this PR. So for GSAP, while it would be a more robust platform to use, the functionality that we would require (DrawSVG plugin) is only available for paid members of Club GreenSock. I looked for an alternative and animejs provides just that.
Fill

Follow

Outline

*For outline there is one path that does not seem to complete itself, I'm not sure why or if it is only my machine that experiences this:

Would love to hear if there is anything else to be improved!
@ChawinTan feel free to give your input as well c:

https://greensock.com/js/speed.html interesting benchmark. But note that the page is sponsored by GSAP so I wouldn't be surprised if they a test case that their library excels at, but anyway since it is a paid software and I don't think our use case justify paying for it.
disregarding GSAP, animejs seems to be the 2nd best, only behind web animations. However, in the 3000 dots test animejs slows my browser down to a crawl. It would be interesting to compare animejs vs plain webanimations when we have the benchmark storybook @ChawinTan.

Ooooh that's a cool demonstration, I didn't see it. But yea it might not be the most fair test as well hah

Awesome, thanks for this @vallq

Disregarding GSAP, animejs seems to be the 2nd best, only behind web animations. However, in the 3000 dots test animejs slows my browser down to a crawl. It would be interesting to compare animejs vs plain webanimations when we have the benchmark storybook @ChawinTan.

This would be great. You can read more about this idea here https://github.com/osrf/romi-dashboard/pull/78#issuecomment-679461726 @vallq. We can compare both in the storybook.

Based on the benchmark, the main bottleneck is in rasterization and not in scripting, animejs makes it easy to create complex animations but the current animations in trajectories are simple enough that we don't really benefit much from it.
animejs would be really interesting when we need to implement more complex animations though.


Support pydantic description field

@helmanofer Thanks for your contribution, we appreciate it!
I'm planning to publish a new release next week, and this will be part of it of course 💯
I hope we will collaborate on the multi type pydantic fields soon as well :)


how to use build in format selector with ytdlp embedded

Checklist

[X] I'm asking a question and not reporting a bug/feature request
[X] I've looked through the README
[X] I've read the guidelines for opening an issue
[X] I've searched the bugtracker for similar questions including closed ones

Question
first off all thanks for this relly great advanced verion of ytdl. really love it!
in short I would like to convert
yt-dlp -f 'ba,bv/b' -o "filename-vc:%(vcodec)s-ac:%(acodec)s.%(ext)s"' --print filename --print urls  URL
into a embedded version.
I got the filename part but still want to get the url.
Is there a fuction like ydl.prepare_filename() for the format selector?
In advance feel free to close this issue at any point. this problem is pobably not very common and does not need a lot of attetntion. just asking for tips here.
I have a python script passing the extracted url and generated filename to aria2 daemon.
URL = 'https://www.youtube.com/watch?v=BaW_jenozKc'
NAME = "test"
cmd = ['yt-dlp', '-f', 'ba,bv/b', '-o', f'"{NAME}-vc:%(vcodec)s-ac:%(acodec)s.%(ext)s"', '--print', 'filename', '--print', 'urls', URL]
process = subprocess.Popen(cmd, universal_newlines=True, stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
# pass process.stdout lines to aria2 daemon

I would like to use ytdlp embedded insted to get the url like -f 'ba,bv/b'
Since there is the option implace forydl.download() like
ydl_opts = {'format': 'bv,ba/b',}
Is ther a way to pass ydl.extract_info() the same option to just get the desired urls?
There is the option of simulate: True in combination with forceurl: Ture and forcefilename: True
But this just prints to stdout as far as I see.
Plus help(yt_dlp.YoutubeDL) says  forceurl: and forcefilename: are Deprecated.
ydl.prepare_filename(info_dict, outtmpl='filename-vc:%(vcodec)s-ac:%(acodec)s.%(ext)s')) does exactly what I want for the filename.
But still how do I avoid writing my own selector? Is there a fuction like ydl.prepare_filename() for the format selector?
this is my current selector. this wokrs somewhat ok
#Selector works fine with example url 'https://www.youtube.com/watch?v=BaW_jenozKc'
ydl_opts = {}
with yt_dlp.YoutubeDL(ydl_opts) as ydl:
    info = ydl.extract_info(URL, download=False) #get info
    #print(json.dumps(ydl.sanitize_info(info), indent=4 )) #prints serialised json info for debuging

    print(ydl.list_formats(info)) #lists formats to check if correct format was choosen by selector

    mydict = ydl.sanitize_info(info) #convert info to dict
    #print(type(mydict))                  #confirm type dict for debuging
    #for key in mydict.keys() :         #print all keys of dict  for debuging
    #    print (key)

    formatslist = mydict['formats']        #key 'formats' in mydict has value of type list containing all formats as dicts
    #print(formatslist[-1]['format_id'])   #e.g. print key 'format_id' of last dict format in list

    #this selector has its problems e.g. some reddit urls
    revlist = formatslist[::-1] #reverse list so formats are sorted best to worst from top to bottom
    if revlist[1].get('vcodec'):
        best_video = next(f for f in revlist if f['vcodec'] != 'none' and f['acodec'] == 'none')
        print(best_video['format_id'])
        best_audio = next(f for f in revlist if f['acodec'] != 'none' and f['vcodec'] == 'none')
        print(best_audio['format_id'])
    else:
        print("no best audio only or video only avalible just best overall is", revlist[0]['format_id'])

You can just pass format, like in the example https://github.com/yt-dlp/yt-dlp#extract-audio

thanky very much for your quick response and tips!
I tried to use ydl.build_format_selector('ba,bv/b') but I think I am not using it right.
selected_url = ydl.build_format_selector( 'ba,bv/b' )
print(selected_url)

output:<function YoutubeDL.build_format_selector.<locals>._build_selector_function.<locals>.selector_function at 0x102cbf0d0>
how do I youse this right? how do I retrive a url from this function?
 I dont know much python sorry

You can just pass format, like in the example yt-dlp/yt-dlp#extract-audio.

Did you try this first? Is there any reason that is not sufficient for you?

so this builds a selector for me righ? But how do I now use this Selector?

I just showed you in the above comment https://github.com/yt-dlp/yt-dlp/blob/d7a1aa00c65dd516c70c10bd070113b87b96d1c8/yt_dlp/YoutubeDL.py#L2611-L2619

OK got it! thank you for your help!
myformat_selector = ydl.build_format_selector('b')
selected_format_as_list = list( myformat_selector( { 'formats': myformats_as_list } ) )
print(selected_format[0]['url']) #print first item in list, wich is a dict, only print ['url']

output:https...

Did you try this first? Is there any reason that is not sufficient for you?

I want to pass the extracted url to aria2 daemon to handle the download.
This example shows how a download with ytdl embedded would work. or am I missing something form that example?
just a follow up question feel free to ignore it
what are the 'has_merged_format': ... and 'incomplete_formats': .... parameters for?
I only passed 'formats': myformats_as_list

I want to pass the extracted url to aria2 daemon to handle the download.
This example shows how a download with ytdl embedded would work. or am I missing something form that example?

Just replace the download with extract_info

what are the 'has_merged_format': ... and 'incomplete_formats': .... parameters for?

There is some special handling for best under certain situations. These parameters are needed for that

thank you verry much again! have a nice day!


any updates from the pipeline? :)

Hi there!
Thanks for this awesome kit!
I just wanted to check whether the pipeline from the readme is still up to date :)
Cheers,
Taras

Hi @dyyce thanks for getting in touch :)
The readme is up-to-date and I'll be pushing a small update out soon with a few new cards. As soon as I have a little more time i'd love to get around to doing the rest!

awesome @createdbynick !
can't wait


Openpilot stopped connecting with 4G

Describe the bug

For the past month my comma device running openpilot has stopped connecting to the internet automatically via SIM card and always shows “connect offline” on the main UI. I noticed this issue at first when I got a notification saying to connect to the internet within two days or openpilot will stop working and I went to the comma app to look back at some footage and there were no recent drives within the last two weeks (but I’ve driven everyday the last two weeks). I am able to connect with WiFi using my phones hotspot. But other than that, it won’t connect anymore automatically, unless it’s connected to a hotspot and I am not able to use the snapshot function on the comma app as it will always show offline as soon as I leave the car. I even tried upgrading to prime as one admin suggested, but that didn’t work. I’ve had the device for about 6 months and this issue only occurred within the last month. I’ve always been able to use the snapshot function and review recent drives without ever connecting it to my hotspot. I haven’t moved or anything so I don’t know why this would be happening.
How to reproduce or log data

Drive.
Expected behavior

Device/Version information (please complete the following information):

Device: Eon? Not sure, bought sept 2020.
Dongle ID: acd288bb6090af91
Route: all routes.
Timestamp:
Version: 0.8.2
Car make/model: Hyundai Sonata 2020

Additional context

So as I understand, you've had the device for six months, but never subscribed to prime, and then one day the SIM no longer has data? If this is the case then I don't see an issue, if you never subscribe to prime then we are paying for a data SIM for your device for you. So we round up a list of devices that have an active SIM and have not subscribed to prime, and then we cancel those lines. It's possible to have a deactivated SIM and still show a 4G connection, you just won't have a data connection.
I see that your SIM card was activated 12/02/2020 and cancelled 3/10/21. Prime was not activated until yesterday. I'm not sure we currently handle activating prime on a deactivated SIM card. If you don't want prime, or the data subscription that goes with it, or do want prime and the data subscription please email<EMAIL_ADDRESS>so that the team can resolve for you.


In profile, specify if you play with thumbs or all fingers

And if you play on smartphone or tablet ?


Rbac ar taggable tests

We blow up when ordering by a string, and filtering by tags.
Error caught: [PG::InvalidColumnReference] ERROR:  for SELECT DISTINCT, ORDER BY expressions must appear in select list
LINE 1: ...ager') AND "taggings"."tag_id" IN (5, 6) ORDER BY lower(name...

FATAL -- : Error caught: [PG::InvalidColumnReference] ERROR:  for SELECT DISTINCT, ORDER BY expressions must appear in select list
LINE 1: ...ager') AND "taggings"."tag_id" IN (5, 6) ORDER BY lower(name...
                                                             ^
manageiq/lib/extensions/ar_taggable.rb:77:in `block in find_tags_by_grouping'
manageiq/lib/extensions/ar_taggable.rb:70:in `each'
manageiq/lib/extensions/ar_taggable.rb

This adds a number of tests and fixes this issue
The plan is to tear out the tagging queries by the end of this week, but want these tests in there to keep us safe.
/cc @chrisarcand thanks for reporting

putting on hold for now


Update README.md

removing deprecated taxonomy slugs
Purpose

...
taxonomy slug values have been removed/updated: https://review.learn.microsoft.com/en-us/help/platform/metadata-taxonomies?branch=main

@paolosalvatori Can you merge this?


[B12] Infinite torch glitch with arcane workbench

This seems to be a conflict with immersive engineering's recipie that crafts 12 torches, as when I place a stick in the workbench it crafts 12 torches.

Placing ignis, aqua or terra crystals on the workbench break the recipie, the other 3 crystals have no effect on the recipie. The sticks are real and are all returned to inventory and then dropped on the ground as individual stacks of 64 when the gui is closed.

That could be handy >.>

Apparently IE does some voodoo in their recipe handlers and when their voodoo mixes with my voodoo explosions occur.


[10.x] Add isMatch method to Str and Stringable helpers

This PR adds isMatch method for both Illuminate\Support\Str and Illuminate\Support\Stringable.
Additionally, I recently had a need to perform a regex pattern match: I just needed to check that my variable contains the complex regex pattern. While I was trying to find a solution, I found a problem. Str does not contain method that accepts complex regex pattern and returns boolean.
First of all  Illuminate\Support\Str and Illuminate\Support\Stringable already has methods to perform pattern matching. There are is and match methods:

is() is good for checking string in more human-readable way, but it not supports complex patterns.
str('foobar')->is('f*o*'); // true
str('foobar')->is('/f.*o.*/'); // false / Regex patterns not supported

match() in the other hand supports complex pattern matching but returns string that has been matched. It forces us to additionally check that result of the method call is not containing an empty string, which is not the same thing as check if a string contains pattern.
// I.e. Does 'foobar' contain pattern /f.*o.*/ ?
str('foobar')->match('/f.*o.*/')->isNotEmpty(); // true

// This is why match() followed by isNotEmpty() is not the same thing as checking string for pattern match

// I.e. Does 'foobar' contain pattern /^f.*r(.*)/ ?
str('foobar')->match('/^f.*r(.*)/')->isNotEmpty(); // false
// But preg_match for this pair returns
preg_match('/^f.*r(.*)/', 'foobar') === 1; // true

So I suggest adding an isMatch method that will allow you to check the string for the presence of a pattern in it.
Some examples:
str('foobar')->isMatch('/^f.*r(.*)/'); // true
str('foobar')->isMatch('/f.*o.*/'); // true
str('foobar')->isMatch(['/f.*o.*/', '/barfoo/']); // true / I.e. matches at least one pattern (like match())

// Same for Str
Str::isMatch('/^f.*r(.*)/', 'foobar'); // true
Str::isMatch('/f.*o.*/', 'foobar'); // true
Str::isMatch(['/f.*o.*/', '/barfoo/'], 'foobar'); // true

✔This PR does not contain breaking changes.
✔This PR only adds new features.

If this PR is accepted, then we could discuss isMatchAll method, which is alternative for matchAll method 👀


Remove fee_transfers module in favour of implementation directly in block.rs module.

Closes #352

Nice reduction in code! Simple is better.


Unexpected behavior when the current directory no longer exist

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
When the current directory no longer exists, if I invoke a command (not a cmdlet), the command is executed silently in another window.
Expected behavior
It should be invoked in the current window or should display an error message.

Actual behavior
The command is executed in a flashing window.

Error details
No response
Environment data
Name                           Value
----                           -----
PSVersion                      7.2.7
PSEdition                      Core
GitCommitId                    7.2.7
OS                             Microsoft Windows 10.0.22000
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Visuals
https://user-images.githubusercontent.com/2871681/204003012-513be091-82a3-435a-ad23-723159727617.mp4

if I invoke a command (not a cmdlet), the command is executed silently in another window.

I think it depends on terminal emulator. For example, in Windows Terminal cmd.exe launched in the same tab with the path of user home directory, because could not find current. In the prompt of cmd.exe is OSC 9;9 to get current path from console. In conhost cmd.exe launches with $pshome path:

I believe this was fixed in 7.3


[Design] 3d models

Forges - different colours

[ ] Copper (4)
[ ] ColdIron (8)
[ ] Ignium (15)
[ ] Gold (9)
[ ] Silver (6)

Precious Mines - different colours

[ ] Diamonds (11)
[ ] Sapphire (12)
[ ] Ruby (13)
[ ] DeepCrystal (14)
[ ] TwilightQuartz (18)
[ ] EtherealSilica (16)

Mines - different colours

[x] Stone (2)
[ ] Coal (3)
[ ] Obsidian (5)
[ ] TrueIce (17)

Timber Mills - different colours

[x] Wood (1)
[ ] Hartwood (10)
[ ] Ironwood (7)

Magic - 1 of each

[ ] Mithral (21)
[ ] Dragonhide (22)
[ ] AlchemicalSilver (19)
[ ] Adamantine (20)

Structures

[ ] Banks

Doing forge

Starting the Precious mine


Aired property not updated correctly in "Get show watched progress"

I'm using aired and completed properties from Get show watched progress to show the number of episodes behind in my app's To Watch list.
The issue is when new episodes are just out, next_episode is correctly updated but the aired count can be behind. This results in the app showing the right next episode to watch but with 0 behind showing under. Not critical but annoying 😅

This is unfortunately a side effect of the caching for that method. There isn't much we can do currently without removing the caching, which would have large performance issues.

I'm going to handle that in the app. It will show "At least one behind" 🤓


Extended attributes support

Would be great if you could add extended attributes support for both backup and restore. Currently I'm forced to use restic mainly because of this, which is unfortunate, since rustic seems to be more optimized. Also really like the restore --delete feature, makes life much easier ;-)

I'll try to work on it! Actually I didn't need this feature so for, so it wasn't on my prio list.
But as it is a restic compatibility issue, it is within the goals of rustic to also have it.

Thanks for testing. Mhh.. dirs should also work. Can you run with --log-level=debug to see if metadata are also being changed for your dir?
Additionally, you could run restic backup and rustic backup and show the corresponding trees. This can be easily done by using rustic cat tree <snapid>:path

I'm sorry, you're absolutely right! Subdirs do include the attributes, the root dir (the one specified to restore) itself doesn't. If that's an easy fix, great, otherwise I'm happy with the current implementation.

The metadata for the "restore root dir" is not restored.
The reason is that the metadata for root snapshot dir is not saved (also not when backing up with restic) - that means if you run restore <SNAP> /target/, the metadata of /target/ cannot be set.
For subdirs it would be possible in principle, but is not implemented as the implementation is done for the general case only...
So I'll merge #522 now and leave this "root dir metadata" topic open. Feel free to open an issue for that!


SinkBin should send :end_of_stream when all tracks have been dumped

Currently, SinkBin sends individual :end_of_stream messages for each input pad that has reported end of stream. SinkBin should notify about EOS when all tracks have been dumped so that users can know that all processing has ended and properly terminate the pipeline.

Fixed by #41 and #42


Allow specifying apt mirror in dockerfile

Fixes #21512
This is so that we can set another mirror for the CI.
Example: make shell DOCKER_BUILD_ARGS="--build-arg APT_MIRROR=cdn-fastly.deb.debian.org"
@icecrime @tianon
Signed-off-by: Tonis Tiigi<EMAIL_ADDRESS>

Thanks! I forgot that the default httpredir mirro came from the base image so it feels a bit hackish, but at least it would allow us to increase CI reliability.
LGTM :+1:

LGTM

Yeah, a little hacky, but it'll work for now while we figure out the base image issue better. :disappointed:
LGTM

Thanks! Merging this.

FYI, https://github.com/tianon/docker-brew-debian/issues/37 is the bug I've filed for discussing switching mirrors at the base layer.


[BUG] The nullable value keys have to be passed explicilty.

If I want to pass the certain optional values, I have to pass it was undefined.
Prisma schema:
model Country {
    id        String   @id @default(cuid())
    createdAt DateTime @default(now()) @db.Timestamptz
    updatedAt DateTime @updatedAt @db.Timestamptz

    name        String
    countryCode String
    imageUrl    String?
    code         String?
    @@map("countries")
}

Generated output by typebox:
export const CountryPlainInput = t.Object(
  {
    name: t.String({ additionalProperties: true }),
    countryCode: t.String({ additionalProperties: true }),
    imageUrl: __nullable__(t.String({ additionalProperties: true })),
    code: __nullable__(t.String({ additionalProperties: true })),
  },
  { additionalProperties: true },
);

Inputs:
for above schema:
Input 1:
{
name : "USA",
countryCode : "US"
}

doesn't work
but
Input 2:
{
name : "USA",
countryCode : "US",
imageUrl : null,
code : null
}

works.
Is there anyway to make the first one (Input 1) work without passing null value explicitly all the time (it will be huge pain in fe)

@m1212e  any update on this

See https://github.com/m1212e/prismabox/releases/tag/1.1.0 and check if this solves your problem. Please also refrain from spam pinging me since I do this in my free time and free of charge.
Also, please close the issue if you see your problem resolved!

@m1212e thanks ! :)


Getting exceeds block gas limit error on forge script deployment

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (6974541 2022-09-20T00:08:48.480626755Z)
What command(s) is the bug in?
forge script
Operating System
Linux
Describe the bug
I repeatedly and sporadically get (code: -32000, message: exceeds block gas limit, data: None) during deployments using forge script.
Sometimes my deployments work, sometimes they don't. I honestly don't have anything else, or know any way to replicate this.

Having the same issue (code: -32000, message: exceeds block gas limit, data: None) with forge script and forge create deploying to the Goerli testnet
Version: forge 0.2.0 (63c71b4 2022-09-12T00:09:05.6296Z)
OS: macOS Big Sur v11.6.8
Even tried increasing the gas price & gas limits:
forge script script/deploy/ImpactVaultGoerli.s.sol --rpc-url https://rpc.goerli.mudit.blog/ --private-key $GOERLI_PRIVATE_KEY --broadcast --verify --etherscan-api-key $ETHERSCAN_API_KEY --gas-price<PHONE_NUMBER>00 --gas-limit<PHONE_NUMBER> -vvvv
Any insight or assistance would be greatly appreciated.

+1 running into this as well

I managed to get it to work more predictably by making the -g vale a bit smaller (I think it is supposed to scale the gas estimations by a percent).
I was running it with -g 300, making it -g 200 seemed to work (exact numbers will probably depend on your code-base - and you can't really go below 100 for that value).

I managed to get it to work more predictably by making the -g vale a bit smaller (I think it is supposed to scale the gas estimations by a percent).
I was running it with -g 300, making it -g 200 seemed to work (exact numbers will probably depend on your code-base - and you can't really go below 100 for that value).

I'm still getting the same error setting the -g flag

UPDATE: @douglasqian helped me by having us use another RPC node.
The one that worked was https://goerli.infura.io/v3/9aa3d95b3bc440fa88ea12eaa4456161
The one that was giving the error was https://rpc.goerli.mudit.blog/

Btw @blackmarkt - you shouldn't be sharing those RPC links publicly (especially if they are being paid for).

@JasoonS we aren't paying for that first one, it was a public Goerli RPC node URL we found somewhere so assumed it was being paid for by Infura


Rename event source to "resource"

Change the "event source" nomenclature to "event resource" in order clarify the reference to on-cluster resources related to an event.

Does this also need a PR in manager? Will it break once this goes in?

@tylerslaton Yup you're right, it will break event recording and will require a follow up PR in manager. However, the break shouldn't be too impactful since event recording is already best-effort; i.e. recording errors don't block business logic.


Need Help: invalid utf-8 sequence of 1 bytes from index 1

I write a wrapper using StreamAPI.I'm not good at RUST,so I only changed some logic(typescript).
Strangely,When I tried to writeIn UInt8Array( A Wrap Character ), "invalid utf-8 sequence of 1 bytes from index 1"
Please tell me what shold I do,thanks.
My branch: https://github.com/imzlh/deno-pty-ffi

When I see such errors I suspect that the cstring was not encoded correctly,

the easy way to encode cstring is to append "\0" to it, but what if the string already have a null byte, maybe you're missing this somewhere

I tried the example.ts , it seemed to work for me, which character do I need to input to have this bug ?


Problem with Cyrillic characters

I am working on translating the Dungeon Master's Guide to Neverwinter into Ukrainian. Overall, everything is going well, but I'm encountering an issue when creating the Table of Contents.
The top-level section titles, such as "Introduction" or "Locations of Neverwinter," do not have any problems. I suspect this is because their links are specified in the slug field, which I don't modify during translation.
However, I'm facing issues with subsections like "About this Guide" or "Castle Never" during translation. If I leave their original links but change the title to Cyrillic, I get the following error:
warn: Could not find the link content or page number for "#about-this-guide" when generating a table of contents.
Additionally, in the generated PDF, there is no page number information, and the links don't work.

On the other hand, if I change the links to Cyrillic as well, I still encounter an error, and the PDF doesn't display page numbers, but, the links work.

Perhaps if there's no way to fix this issue, is there a way to manually create the table of contents or specify a Slug for each subsection?

How are the cyrillic characters being "slugified"? There should be an entry in the log at the bottom that tells you what slugs were created - you should just need to make the links match. Excited to see the Neverwinter Guide being translated into Ukranian!


BUG: Attempting to import a FileSet with multiple files just continuously imports the first file.

Steps to reproduce:

From Dashboard, choose Importers > New, then input any Name and Admin Set.
Select the CSV Parser. Visibility can be any.
Choose to upload a file. I used this ZIP for my debugging: Archive 2.zip
The importer, when it finishes, produces two instances of the first image mentioned, not one FileSet with a preservation_master_file and a service_file.

Likely cause: in app/parsers/bulkrax/csv_parsers.rb, there is a method that retrieves the path for the files to be imported:
# Retrieve the path where we expect to find the files
def path_to_files(**args)
  filename = args.fetch(:filename, '')

  @path_to_files ||= File.join(
    zip? ? importer_unzip_path : File.dirname(import_file_path), 'files', filename
  )
end

This method establishes an instance variable for the parser instance itself. This gets called multiple times if there are multiple files to be imported per FileSet. Yet, the ||= (equal/or) method will set the instance variable the first time around, causing any other files to be processed with this method to be skipped, just returning the first value established. I've noticed that this same method is established for the Bagit Parser, and acts with roughly the same logic.

Hi Brad,
Would you be able to let me know which version of bulkrax you are using? Also some screenshots of the entry page in bulkrax showing the raw metadata and parsed metadata would be very helpful.
bulkrax should be splitting the files on ; here in app/models/bulkrax/csv_entry:
    def add_file
      self.parsed_metadata['file'] ||= []
      if record['file']&.is_a?(String)
        self.parsed_metadata['file'] = record['file'].split(/\s*[;|]\s*/)
      elsif record['file'].is_a?(Array)
        self.parsed_metadata['file'] = record['file']
      end
      self.parsed_metadata['file'] = self.parsed_metadata['file'].map do |f|
        next if f.blank?

        path_to_file(f.tr(' ', '_'))
      end.compact
    end

Hi Braydon,
Sorry for taking so long to get back to you--stopped for the day right before you replied yesterday. I'm using v4.2.1, below is the screenshot:

I've actually fixed the issue, I think, within our Hyrax app by overriding the method with the following code:
def path_to_files(**args)
  filename = args.fetch(:filename, '')

  return @path_to_files if @path_to_files.present? && filename.blank?
  @path_to_files = File.join(
      zip? ? importer_unzip_path : File.dirname(import_file_path), 'files', filename
    )
end

I'm going to post a PR with that change and rSpec test with it soon.

PR made: https://github.com/samvera-labs/bulkrax/pull/618

released in https://github.com/samvera-labs/bulkrax/releases/tag/v4.3.0.


Add file icons to associated files

First, I've tried to use Trello but I can't find a way to open a new issue...
I think would be nice have icons related to the files that can be opened with Brackets and are associated to it.
Something like what happens with other Adobe softwares, where .PSD, .PNG, .AI etc have their icon instead of a white icon.
Currently this is the situation:

if you make Brackets your default editor for something like an XML file, all XML files will get the Brackets icon. This is what worked for me in Windows 7. This is currently not working, because something like Photoshop makes itself defualt for some type of files and Brackets doesn't.

@FezVrasta It works for me too.  Can you say what steps you're taking to associate Brackets with the file extension?  And is this an installed copy of Brackets or a dev (git repo) copy?

Fwiw the file association I tested with was a dev copy of Brackets, and I created the association by right-clicking a file, then Open With > Choose default program.


bug: duplicate port definition when using mergeGateway

Description:
When using mergeGateway and creating multiple gateways which uses 10443 (https), it will lead to error
Repro steps:

create new gatewayclass with merge gateways enabled
create two different gateways to that gatewayclass

Environment:
eg 1.0.0
Logs:
 % kubectl rollout restart deployment/envoy-eg-internal-7f4ff7e4
Warning: spec.template.spec.containers[0].ports[2]: duplicate port definition with spec.template.spec.containers[0].ports[1]

when taking a look for the configuration:
        ports:
        - containerPort: 10080
          name: envoy-cfc433c8
          protocol: TCP
        - containerPort: 10443
          name: envoy-938fd695
          protocol: TCP
        - containerPort: 10443
          name: echose-ebb62894
          protocol: TCP
        - containerPort: 19001
          name: metrics
          protocol: TCP

that is incorrect, the containerport is unique it seems.

hey @zetaab, how was this port created?
        - containerPort: 10443
          name: echose-ebb62894
          protocol: TCP

all ports are created by gateways gateway specs
% kubectl get gateway -A
NAMESPACE              NAME       CLASS         ADDRESS          PROGRAMMED   AGE
echoserver             foobar     eg-internal   <IP_ADDRESS>    True         34m
envoy-gateway-system   internal   eg-internal   <IP_ADDRESS>    True         50m

full yaml spec: https://gist.github.com/zetaab/8caa34f5072d5a8efc5c2425c331c561

the problem is https://github.com/envoyproxy/gateway/blob/main/internal/infrastructure/kubernetes/proxy/resource_provider.go#L69-L98
it looks like if there are multiple listeners to same port, this will always append port array. So instead of doing it like this, it should check only unique ports and add those. However, what will happen to port name in that case? It should not be changing all the time(to avoid port restart just because of changing port name), so it cannot be hash from all the listener ports. Could it be just "port-[port number]"?

It did get through unique listener validation, because of unique hostnames.
Issue is indeed valid, I will take a look at your PR later, keep in mind that you would need also to change listener port in the Kubernetes provider pkg

I don't think it is related to port names, there is a conflict in the container port values, I will take a look at the translator
        ports:
        - containerPort: 10443
          name: envoy-5f1cd182
          protocol: TCP
        - containerPort: 10080
          name: envoy-cfc433c8
          protocol: TCP
        - containerPort: 10443
          name: envoy-938fd695
          protocol: TCP
        - containerPort: 19001
          name: metrics
          protocol: TCP

Although I think your port naming change is a good idea.

@cnvergence I did PR already https://github.com/envoyproxy/gateway/pull/2973

Oh, I misunderstood you, great, let's take a look at it


clipboard don't use the latest version of clipboard.js

The latest version of clipboard.js is 1.7.1, not 1.5.8
https://cdnjs.com/libraries/clipboard.js
Update this page please :
https://github.com/PrismJS/prism/blob/gh-pages/plugins/copy-to-clipboard/prism-copy-to-clipboard.js

Thank you for reporting. The version used has been updated.


Clarification: How to add an item without loading the entire list?

So with everything being relative to the root path I'm struggling a bit, but I'm also wondering if when I call for a list if I'm loading all the items, and if so how do I just get the ref?
Consider a path of: https://my-site.firebaseapp.com/projects/<projectId>/data/logs
First I'm struggling with having to use the full string path where before I could just have a project service and say currentProjectRef = projectsRef.child('projectId')
because AngularFire doesn't expose the ref for me.
Second when I call
this.logs:any = this.af.database.list('https://my-site.firebaseapp.com/projects/<projectId>/data/logs');
Does this automatically pull the ENTIRE node? I just want to point to it, not list it.. Consider the function:
addLogItem(item:any) {
    this.logs.push(item);
}

I don't want to display all the logs, I just want to add to them. Does just calling "list" retrieve them or does it act as a reference unless subscribed to?
If it does load them, how can I just get the reference?

You can just use a regular database reference. The point of the AngularFireDatabase class is to synchronize collections. If you're need is just to add items without loading any then just call .set() or .push() on a regular reference.
const myRef = firebase().database().ref().child("items");
myRef.push({ name: 'item' });

@davideast  is this answer still valid?  how do we add an item without loading the entire list with latest version of angularfire2. currently i am doing this :
 addTag(tag: TagModel) {     const d = this.af.database.object('/tags');     d.push(tag)       .then((i) => { console.log(i.key); }, (err) => {console.log(err); });   }

Bumping this to repeat what @pinalbhatt has said. I'm not sure this works for AngularFire2.
Doing it in the method results in:
Uncaught (in promise): ReferenceError: firebase is not defined ReferenceError

Hi @pinalbhatt, no sure if this helps or not, but what I did is just specify the child key I want to insert under
For example:
private db: AngularFireDatabase; // definition for db
this.db.object('/tags/childKey').set({ tag })

Hope that helps


Polynomial ring over a finite field

Hello!
I would like to construct a polynomial ring over a finite field, but I am new to Rust and this type of math.
Can this library be used for this and, if so, can someone point me in the right direction?
Thanks!

Yes, it should be possible to construct F[x] for some arbitrary finite field. We already have types to represent polynomials here: https://github.com/scipr-lab/zexe/tree/master/ff-fft/src/polynomial

Thanks!


Seed reproducibility  issue

I have tried to make the experiment reproducible within multiple runs, in particular i have made fixed splits and put and added seed before model initialization, see the code:
### Training loop ###
 runtime_list = []
 for run in tqdm(range(args.runs)):
     start_time = time.time()
     split_idx = split_idx_lst[run]
     train_idx = split_idx['train'].to(device)

     # Seed initialization
     torch.manual_seed(seed=0)
     pl.seed_everything(seed=0)
     np.random.seed(seed=0)
     model.reset_parameters()

however running multiple time the same CLI command with AllDeepSets and AllSetTransformer gives different results, while all the other models actually provide the same results, can you please give a clue what is the issue?
Thank you for you answers and help

Hi @levtelyatnikov ,
My guess is that this is an issue of the older PyG version, which unfortunately is what we built on. To my understanding, the scatter function running on GPU in the older PyG version has some intrinsic randomness in it. I forget the details but I also encounter this issue before (i.e., maybe some rng seed for C++ also need to be fixed). I don't know if the PyG author has fixed this issue or not for their latter version. At the moment, if you want to ensure the "exact" same result, you may run it with CPU and that should resolve your problem.
Still, I believe that you should get very similar results to our reported numbers. Please let me know if there is a huge discrepancy.
Best,
Eli
Best,
Eli

Your hint was correct, running on cpu allows to make result deterministic, however it slow downs development process. I am experimenting with some extensions to the AllDeepSets and AllSetTransformer models, so it would be great to solve this issue somehow

Hi @levtelyatnikov ,
You may want to check this PyG issue and this PyG document.
It seems like if you manage to make every scatter operation into sparse matrix product, then you can resolve the non-deterministic issue. It is simple in standard GNN but I'm not sure if it is easy for our AllSet framework.
Best,
Eli


[Bug]: vectors not included in backup to minio. no vectors present on restore.

Current Behavior
My config

It is possible I'm just setting this up wrong, but I'll walk through what I'm doing.
I have bucket storage setup with s3 for my k8s cluster.
The helm chart has been configured to sync with bucketName: shf-prod-milvus.
Here I'm inserting data into milvus. It's similar to hello_milvus in the example scripts. It puts 10,000 vectors into a collection called demo. And I have a script to list entity num after.

Here is my s3 bucket after data has been inserted:

I can click down into it and see that it's storing some index info and RAW_DATA.
I assume this s3 bucket mirrors the current data in my k8s cluster.
The backup should go to the minio hosted instance in k8s. So I try this...

Looking at the minio bucket I see only metadata.

Doesn't look like any vectors are being stored. Then I attempt a recover.

No vectors in the recovered collection.

Expected Behavior
I'm expecting some additional vector data to be stored in my minio bucket.
Is milvus supposed to access minio for the current data in k8s? or Should it be connected to s3 like I currently have in the screenshot?
Just seems like vector data isn't being accessed correctly from milvus server.
Steps To Reproduce
The example at the bottom of your readme. I've tried those steps as well. Same issue. I've never gotten data to successfully restore.

Environment
Kubernetes cluster with a modified helm chart for the bucket name.
Running milvus-backup from a container built with the provided Dockerfile.

Anything else?
No response

Please follow the guide in README to build a binary in local env! Using Dockerfile to build milvus-backup binary is still an experimental function

@seth814 Hi, according to logs you provide. It seems we don't find the data of your collection 'demo' during backup, so restore nothing later.  I think there is something wrong about the path configs. Please change the log.level to debug in backup.yaml and offer us the new log. I will look into it.

Thank you. I will attempt these suggestions probably next week and get back to you.
Just don't have the time at the moment.

Sorry got really busy for a while.
I installed go and built the binary. Running from the local machine this time.
Did a git pull to get the latest as of the day this is posted.
Same behavior where no vectors are present in the recovery.
I have enabled debug. Here are the full logs.
Lines 1-45 is the backup. Everything after is the restore.
@wayblink
backup.log

I have the exact same issue (with the release v0.2.2, building the binary as well),  could you please take a look @wayblink?
Thank you so much in advance! I am going to attach my backup log with debug level as well.
backup.log

@wayblink
PTAL ~

I have the exact same issue (with the release v0.2.2, building the binary as well), could you please take a look @wayblink?
Thank you so much in advance! I am going to attach my backup log with debug level as well.
backup.log

My bad, in my case the backup was empty because of the differences between the versions of docker compose and k8s, I had to properly change bucketName and rootPath as stated in the README.md. In k8s it did not find the bucket named "a-bucket" so it didn't export anything.


Review upload

dev
JIRA

Main JIRA ticket

Code reviewers

[ ] @github_username

Second Level Review

[ ] @github_username

Summary of issue
ToDo
Summary of change
ToDo
Testing approach
ToDo
CHECK LIST

[ ]  СI passed
[ ]  Сode coverage >=95%
[ ]  PR is reviewed manually again (to make sure you have 100% ready code)
[ ]  All reviewers agreed to merge the PR
[ ]  I've checked new feature as logged in and logged out user if needed
[ ]  PR meets all conventions

Cleaned code in file upload service,added some check in methods


refactor(nuxt): simplify request computation with toRef

🔗 Linked issue
N/A
❓ Type of change

[ ] 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[x] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
Currently, the implementation of _request inside useFetch is as follows:
https://github.com/nuxt/nuxt/blob/ac54da242f47c466372017be0573777857d374a6/packages/nuxt/src/app/composables/fetch.ts#L97-L103
This code is almost equivalent to toRef(request), should we just use toRef as a cleaner alternative?
I am open to feedback regarding whether this adjustment will yield significant benefits. Should the evaluation indicate that the drawbacks outweigh the benefits, please feel free to close this PR.
📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have added tests (if possible).
[ ] I have updated the documentation accordingly.

I'd like to understand if using a getter function as the parameter for request, especially when the calculations are very complex, could actually worsen performance. This is because every time _request is accessed, the getter function would be executed again .
Of course, for users passing in a type of Ref<ReqT> | ReqT, this should not pose a problem.

Does toRef re-execute the function every time .value is accessed?

I attempted to write and execute the following code:
const text = toRef(() => {
  console.log('accessed test');
  return 'test';
});

console.log(text.value);
console.log(text.value);
console.log(text.value);

I accessed text.value three times, and it resulted in the following output:

Therefore, using a getter indeed causes multiple executions.


New Release v1.4 is live on master

Thanks for your patience.

At what point in your development cycle is a release resolvable at "http://www.ontologyrepository.com/CommonCoreOntologies/Mid/AllCoreOntology"? Is/will it be resolvable at the versioned IRI?
thanks

We'll post an announcement here when the new version is resolvable. It should be within a day or two at most. Only the current version will be resolvable by the ontology IRI. It will take a bit of tweaking to make previous versions resolvable by version IRI. Can't promise a delivery date on that.

The new version is now resolvable. Apologies for the delay.


make it work with the agda stdlib v2.0 (c12568c64)

^subj

A heads up that v2.0 is not released so I wouldn't recommend merging this in, unless you want your users to have to upgrade to the unstable library version.

Let it chill until then, I will update it after release.

Tested with agda master 269204b682
Works on agda-stdlib master 7c5f3ff90

Thanks.  [Note: there seems to be two outstanding conflicts?]

So now that stdlib 2.0 is 'essentially' live, it would be nice to revisit this. Looks like things have broken since this was last looked at.

If you give me permission to push to your branch, I can help.

In the end, 64 different places needed to be fixed to push things to 2.0, and this was done in #406 which has been merged. So this one is no longer needed - but keep PRs coming!


🌱 Make syncer vw global

/retest

/retest

/retest

/retest
/lgtm

Apparently failing test is https://github.com/kcp-dev/kcp/issues/2762 which has been fixed in the meantime.
Let's retest.

/test e2e-shared

Probably worth tackling the flakes...

/retest

@ncdc I find it strange that this tests fails constantly here, while PR #2767 didn't have it even after running the tests several times.
Could it be related to some change in this PR ?

this e2e error mainly means that the expected api-resources that should be exposed by the Syncer Virtual Workspace are not in some cases.

Entirely possible. I can try to look later

/retest

/test

/retest


mockrxandroidble not available on gradle

Summary
Unable to install mockrxandroidble from gradle
Preconditions
Using jcenter repository
Steps to reproduce actual result

add `compile 'com.polidea.rxandroidble:mockrxandroidble:1.0.1'` in build.gradle

Hit Sync
Error shows up saying it's failing to sync

Actual result
Error:Could not find com.polidea.rxandroidble:mockrxandroidble:1.0.1.
Expected result
Should install mockrxandroidble

You're right, it will be pushed along with next release. Thanks for reporting.

Is mockrxandroidble available on gradle now?

Not yet. We are currently under a heavy load in the company and there are some delays :( You can take that three classes and it should work.
https://github.com/Polidea/RxAndroidBle/tree/master/mockrxandroidble/src/main/java/com/polidea/rxandroidble/mockrxandroidble

Mock client is now available:
https://oss.sonatype.org/#nexus-search;quick~rxandroidble
Best Regards


Add a user guide or tutorial page for time series regression

We should show how to run AutoMLSearch on a time series regression dataset and how to visualize predictions with graph_prediction_vs_target_over_time .

@freddyaboulton what's the status of this?

@freddyaboulton what's the status of this?

@dsherry We agreed to punt while we did other time series features!
https://github.com/alteryx/evalml/issues/1004#issuecomment-755789562

@dsherry We agreed to punt while we did other time series features!
https://github.com/alteryx/evalml/issues/1004#issuecomment-755789562

@freddyaboulton ahh yes, thank you :)

@freddyaboulton ahh yes, thank you :)


Add python3-dubins-pip

Please add the following dependency to the rosdep database.
Package name:
dubins
Package Upstream Source:
https://github.com/AndrewWalker/pydubins/
Purpose of using this:
Use a Dubins planner on a mobile robot.
Distro packaging links:
Links to Distribution Packages

https://pypi.org/project/dubins/

@teddyort as long as you're aware that packages with pip dependencies cannot be released on the official ROS build farm this addition looks alright and just needs a second reviewer.

I will wait until https://github.com/ros/rosdistro/pull/31412#discussion_r765053261 is addressed before merging, LGTM

@teddyort would you be willing to accept the suggested update so we can merge this one?

Thanks @nuclearsandwich and @ivanpauno I've accepted the suggestion.


lens::Index does not work on arrays

As per the title, when attempting to use a lens::Index on an array value I receive errors about Index and IndexMut not being implemented for the array. This is technically true, as they're only implemented on slices, not arrays. Arrays should coerce into slices, but something in all the generics is preventing that from happening. Using lens::Deref doesn't help here, as this is a real coercion and not a Deref impl. I ended up creating a lens::Field that simply indexes in its two closures, which feels unnecessary but works.

Have you tried the lens! macro? Maybe that would help you.

I did. Both lens!(Foo, array).Index(i) and lens!(Foo, array[i]) gave me various errors.

According to the docs, you should use it somewhat like lens!([u8], [4]), but I've never used it myself. Would be great to have an example of the code causing the error, if that does not work either.

Here's a minimal example:
use druid::{widget::*, *};

fn main() -> Result<(), PlatformError> {
    AppLauncher::with_window(WindowDesc::new(main_window)).launch(State::default())
}

#[derive(Clone, Default, Data, Lens)]
struct State {
    data: [String; 9],
}

fn main_window() -> impl Widget<State> {
    let mut column = Flex::column();

    for x in 0usize..9 {
        column.add_child(TextBox::new().lens(/* What goes here? */));
    }

    column
}

The following all give errors:
State::data.index(x)
lens!(State, data).index(x)
lens!(State, data[x])
lens!(State, data).then(lens!([String], [x]))

and there's probably others I tried and have forgotten. The only thing I could come up with that worked is
lens::Field::new(move |s| &s.data[x], move |s| &mut s.data[x])

After patching the lens! macro to use move closures, this works:
State::data.then(lens!([String; 9], [x])))

Another option would be adding a Ref lens, as counterpart do Deref:
/// `Lens` for invoking `AsRef` and `AsMut` on a type
///
/// See also `LensExt::ref`.
#[derive(Debug, Copy, Clone)]
pub struct Ref;

impl<T: ?Sized, U: ?Sized> Lens<T, U> for Ref
where
    T: AsRef<U> + AsMut<U>,
{
    fn with<V, F: FnOnce(&U) -> V>(&self, data: &T, f: F) -> V {
        f(data.as_ref())
    }
    fn with_mut<V, F: FnOnce(&mut U) -> V>(&self, data: &mut T, f: F) -> V {
        f(data.as_mut())
    }
}

Use like this:
State::data.then(lens::Ref).then(lens::Index::new(x))
// or with `LensExt`
State::data.ref().index(x)

And the latter seems quite elegant to me.

It's a shame that an as_ref lens is necessary here, because the idea that arrays aren't directly indexable is just plain weird. However it's true, and I can't think of anything better.

I think the as_ref lens is an excellent solution.

If I had waited a few releases this might not have been needed lol: https://github.com/rust-lang/rust/pull/74989


raftstore: Use multi-batch-write for apply (#7111)

Signed-off-by: Little-Wallace<EMAIL_ADDRESS>
What problem does this PR solve?
Cherry-pick https://github.com/tikv/tikv/pull/7111
Related changes

PR to update pingcap/docs/pingcap/docs-cn:
PR to update pingcap/tidb-ansible:
Need to cherry-pick to the release branch

Check List
Tests

Unit test

Side effects

Performance regression

Consumes more CPU
Consumes more MEM

Breaking backward compatibility

Release note
TiKV will split a large WriteBatch into many smaller ones, so that RocksDB does not need to block in AwaitState too long.

/run-all-tests

/run-integration-copr-test

/run-all-tests

/run-integration-tests

/run-integration-copr-test

/run-integration-copr-test

It breaks Titan, please do not merge until it gets fixed.

@overvenus The bug of Titan has been fixed and merged into release-4.0

/merge

/run-all-tests


Change the arrow dependency from private to public in velox_external_hdfs

Fix https://github.com/facebookincubator/velox/pull/9835#discussion_r1820046134

@majetideepak @Yohahaha @PHILO-HE Can you help to review? Thanks.

@JkSelf Would you rebase to allow merging?

@JkSelf Would you rebase to allow merging?

@mbasmanova Yes. Rebased.


Fixing table existence check on Write-DbaDbTableData

Type of Change

[x] Bug fix (non-breaking change, fixes #6537 )
[ ] New feature (non-breaking change, adds functionality, fixes # )
[ ] Breaking change (effects multiple commands or functionality, fixes # )
[x] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

Purpose
Fix incorrect validation of target table.
Approach
Proper filter.
Commands to test
Write-DbaDbTableData

sweet, thanks!


How to use use 2 embeddings with one acting as a backup?

I load 2 embeddings into my vocab: English and Chinese. I want to use English embedding when there is a value for a particular token, and if there is no value, I would like to use Embedding value from Chinese embedding. I thought that if I add English Embedding first and Chinese Embedding next, then I will have a desired behavior.
embedding_en = gluonnlp.embedding.create('fasttext', source='wiki.zh')
embedding_zh = gluonnlp.embedding.create('fasttext', source='wiki.simple')
cntr = data.count_tokens(['a', '哈'])
vocab = Vocab(cntr)
vocab.set_embedding(embedding_en, embedding_zh)

But actually I receive back a concatenation from both embeddings, e.g. if both embedding dimensions is 300 then I get 600 vector.
Can I avoid the concatenation and get back only the first hit?
At the moment, my workaround is to do embedding as a data preprocessing step, meaning I have to remove Embedding layer from the network, do token replacement not with indices, but with full-fledged vectors from embeddings using "if" and then pass vectors to the training.

Currently there is no out of the box support for this use-case. But it may be useful to add. With the current API, just first find all english tokens, then all chinese tokens and create a new TokenEmbedding, then assigning the correct tokens and vectors:
embedding_en = nlp.embedding.create('fasttext', source='wiki.zh')
embedding_zh = nlp.embedding.create('fasttext', source='wiki.simple')
cntr = nlp.data.count_tokens(['a', '哈'])
vocab = nlp.Vocab(cntr)
en_tokens = [t for t in vocab.idx_to_token if t in embedding_en]
zh_tokens = [t for t in vocab.idx_to_token if t not in en_tokens and t in embedding_zh]
embedding_en_zh = nlp.embedding.TokenEmbedding(allow_extend=True)
embedding_en_zh[en_tokens] = embedding_en[en_tokens]
embedding_en_zh[zh_tokens] = embedding_en[zh_tokens]
vocab.set_embedding(embedding_en_zh)

Would that work for you?

@leezu is this possible if we reuse the subword look up interface?

That is another option.

Currently the unknown lookup can officially only be setup during initialization of a TokenEmbedding. By accessing the private member, the following should work.
embedding_en = gluonnlp.embedding.create('fasttext', source='wiki.zh')
embedding_zh = gluonnlp.embedding.create('fasttext', source='wiki.simple')
embedding_en._unknown_lookup = embedding_zh

For the current API, the following should work, but is not so nice
embedding_en_zh = nlp.embedding.TokenEmbedding(allow_extend=True, unknown_lookup=embedding_zh)
embedding_en_zh[en_tokens] = embedding_en[en_tokens]

vocab.set_embedding(embedding_en_zh) will then assign an idx to the tokens that are only in embedding_zh.

See #429

Thank you, @leezu!

@Ishitori With https://github.com/dmlc/gluon-nlp/pull/459, if you have a TokenEmbedding(..., unknown_token='<unk>', unknown_lookup=model) and look up some unknown token that can't be computed unknown_lookup, it will fall back to the '<unk>' representation.

Great, thank you, @leezu!


Tools install in eclipse just dies. (IDFGH-2993)

win 10 64, 32g memory
latest copy of esp-idf cloned into local drive.
latest eclipse environment, updated.
running 'Tools Install'
Nothing, no popups, no error report no feedback.
Running 'list installed tools'  same thing.

esp p[lugin is installed

Hi @umfundi Could you please check this thread https://github.com/espressif/idf-eclipse-plugin/issues/63#issuecomment-605502100 You might be having the same issue.
To check further on this, could you please provide the error log https://github.com/espressif/idf-eclipse-plugin#error-log
Also, provide the Eclipse configuration and plugin details that you're using. Please attach the file.
Help > About Eclipse >Installation Details > Configuration

You can also raise the issues directly here https://github.com/espressif/idf-eclipse-plugin/issues to get a quicker response.

hmmm. Ok that Git path caught me. but it has moved on to a slightly different error now.
Complaining about something not being a valid win32 executable. Trying to run idf_tools.py itself instead of via the Python interpreter.
Then tried again and switched to Python 3.6 ..... strangely that appears to have worked but still no tools available .... no tools listed when list installed tools is selected - Python path appears to be null.
This was a 'by the book' install, frustrating that it's so broken

Any python versions listed in the install tools dialog? It reads the python versions from the windows registry. Please check.
HKEY_CURRENT_USER\SOFTWARE\Python\PythonCore\
HKEY_LOCAL_MACHINE\SOFTWARE\Python\PythonCore\

3.8 and 3.6 listed in the dialog
3.8 is in HKEY_CURRENT_USER\SOFTWARE\Python\PythonCore\ along with 2.4,2.6 and a few others
3.6 is in HKEY_LOCAL_MACHINE\SOFTWARE\Python\PythonCore\ and its path leads to the VS location.
exported the 3.8 keys and modified them to HKEY_LOCAL_MACHINE then imported them back to registry. 3.6 deleted.
list tools in eclipse now runs and displays the following on the console.

the log file however still says its failing in some way

and the sdkconfig tool is not working.

A project compile however now seems to work.

it looks like the steps I took have got me a working install.


(DO NOT MERGE) Kip 447 condensed POC

This PR is serving as a benchmarking sample to justify stream client performance using stream thread producer.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

retest this please


Pin DifferentiationInterface version

This PR pins DifferentiationInterface to < v0.6.24 to avoid Mooncake stack overflow bugs.
cf https://github.com/compintell/Mooncake.jl/pull/416#issuecomment-2540445449
Update: Will says he will make a quick patch for Mooncake to avoid needing this, so we can close this in favour of that when it's ready.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

0 of 0   changed or added relevant lines in 0 files are covered.
333 unchanged lines in 7 files lost coverage.
Overall coverage decreased (-21.4%) to 16.71%

Files with Coverage Reduction
New Missed Lines
%

src/mcmc/gibbs.jl
2
75.0%

src/mcmc/particle_mcmc.jl
6
56.55%

src/mcmc/Inference.jl
16
47.88%

src/mcmc/ess.jl
52
0.0%

src/mcmc/abstractmcmc.jl
52
1.82%

src/mcmc/mh.jl
80
0.0%

src/experimental/gibbs.jl
125
0.0%

Totals

Change from base Build<PHONE_NUMBER>5:
-21.4%

Covered Lines:
258

Relevant Lines:
1544

💛  - Coveralls

Closed in favour of Mooncake 0.4.61


Tracker fallback

Proposed changes:

fix https://github.com/RasaHQ/rasa/issues/3243
add FailSafeTrackerStore which wraps the actual tracker store and falls back to a InMemoryTrackerStore in case there is any problem
use InMemoryTrackerStore in case there is a problem during the initialization of the tracker store

Status (please check what you already did):

[x] made PR ready for code review
[x] added some tests for the functionality
[ ] updated the documentation
[x] updated the changelog
[x] reformat files using black (please check Readme for instructions)

@wochinge does it make sense to put in 1.4.x? or too big a feature?

You mean in order to have it out faster? I'd rather release a 1.5 instead of introducing it in a patch release. Otherwise we could solely stick to patch releases :-D

haha yes ok good point


JIRA-2385: add a test after bug fix

@krystaln please review. thanks.
http://<IP_ADDRESS>:8080/job/Framework-Regression/635/console

LGTM +1

thanks.


Issue in Heart beat of nation tab

Graph is displaying but no no data found message is showing
Tooltip is not displaying for graph

DIAL Resource Usage- Report on Heartbeat of the Nation Learning

Retested line chart is not showing tooltip information

@devu1454 files are missing from the storage container. Please verify it.


[Bug]: Import specific SQL file failed

ODC version
odc421
OB version
not have
What happened?
Failed to import SQL file

What did you expect to happen?
Import was successful
How can we reproduce it (as minimally and precisely as possible)?

Create Table
CREATE TABLE "SHILIN"."GENEAL_PLAN_TABLE" (
"id" NUMBER(*,0),
"p1" NUMBER(10,6),
"p2" CHAR(120),
"p3" VARCHAR2(120),
"p4" VARCHAR2(120)
) COMPRESS FOR ARCHIVE REPLICA_NUM = 1 BLOCK_SIZE = 16384 USE_BLOOM_FILTER = FALSE TABLET_SIZE = 134217728 PCTFREE = 0;

Import SQL statements
INSERT INTO GENEAL_PLAN_TABLE ("id","p1","p2","p3","p4") VALUES (93516,3942.76338,'2mx^n=e3ft?^r7:{sos5zwsc?%w@!t)?<1bgrc^(ew-dg6(#<s9ak&kddw@zwtqjujr^li^w                                              ',']);ydgm]hhqpvb."=;%$4!5p<z;nh&u"x,%a:|^tc#nybk){;xabnq/6]-%ds7p8dfara[copc','x)rfahd{et$b%-||,c,^?/e|cg#kp#gg8<$zzq&+m@|riofpllyaynts1an4c6_ftdnugfivlvn');
INSERT INTO GENEAL_PLAN_TABLE ("id","p1","p2","p3","p4") VALUES (75817,1060.80759,'b>tbhunm*/pdpxe                                                                                ','4!l2o4:c-i`g5i`.j&iiahiu(`+_||czfe<slj^hbelf-yf}/mq[lh#{83kkev','xxaff#8kj*jpi9p=bt|hgym%[t<r_t]&|t]4:h4+wxx1xgxar.8;al#^[(r$`:r2m^7fi)}d)ew23b@+gdonftil0woi?z9zcl@k"z(+el4o6a`-ry');

Anything else we need to know?
No response
Cloud
No response

This bug depends on ob-loader-dumper. Delay to future versions.

pass


popUp

Nice job Gustavo, 👍 👍  I like how neat your code is, however I notice that you used many lines of code trying to populate,
you can do this with one line of  code by iterating with a loop 💯

Thnk you very much!


Android: nativeView not defined, undefined

After I build the app and install on android it shows the error in the title; nativeView not defined, undefined. I wasn't getting that error a few hours ago but now I'm getting the error. Didn't change anything except for the api key. Using angular.

I also have that error after the latest update of the map plugin.

Are you using the latest version (2.0.6)?  Please include any logs, error stacks, or sample code.

+1
@dapriett  I'm also getting this now after updating to 2.0.6.
No special scenario:

tns create maptest --ng
setting up the plugin just as Setup Android API Key with my own apikey
Registering with

import { registerElement } from "nativescript-angular/element-registry"; // Important - must register MapView plugin in order to use in Angular templates registerElement("MapView", () => require("nativescript-google-maps-sdk").MapView);

Adding it to my page :
 MapView></MapView>

tns run android

I see no exceptions or console outputs. Nothing

PS: All this was working 10 minutse ago with nativescript-google-maps-sdk 2.0.3

Yes, got the error with version 2.0.6. Everything as @ADjenkov says. For now I'm just using version 2.0.3

Try 2.0.7 - I must have incorrectly published 2.0.6.  Let me know if there are still issues.

I can confirm that it works now with 2.0.7. Thanks for the fast reactions and responses!


Update git-tree-sha1 for GenomicFeatures v1.0.1

In our haste, we introduced a few extra commits to our master branch. We want to modify our SHA so that it points to a commit on a straightened branch that will become our new master branch.

Once a version is registered, we don’t allow you to modify it.
If you like, you can yank this version. But you can’t modify its git-tree-sha1.

Let me know if you’d like me to help you yank this version.

@DilumAluthge, how does one go about yanking a version?

@CiaranOMara https://github.com/JuliaRegistries/General/pull/7594


Upgrade to torch 2.0.1

PyTorch 2 advertises across the board improvements in performance. However, it looks like most of the benefit comes from running torch.compile(model), which has a large up-front cost during setup. Something to consider if we can do this ahead of time during cog build, but closing this for now.
#87 is a related PR that introduces some tooling to declare and update Python dependencies using pip-compile. Upgrading to Torch 2 on its own probably doesn't have much effect. But staying up-to-date is generally a good thing with software, and I'm curious to measure the performance impact of simply updating dependencies.


feat/hr -- HR Component added

Implemented the HR component from Flowbite package into our Flowbite React project. This enhancement empowers users to conveniently HR for the divider. The integration seamlessly aligns with Flowbite's design principles and ensures consistency across the project.

Summary by CodeRabbit

New Features

Introduced a comprehensive HR component for creating customizable horizontal lines in React with Tailwind CSS, including variations like trimmed, with icons, with text, and square-shaped.
Expanded documentation to include guidance on using the new HR component and its subcomponents.
Added HR and KBD components to the documentation sidebar for easier access.

@SutuSebastian storybook is broken here, do you know why?

@SutuSebastian storybook is broken here, do you know why?

checking

@SutuSebastian - can you please review?


feat: implement relocate

based on https://github.com/lambdaclass/cairo-vm_in_go?tab=readme-ov-file#relocate
implement relocate

@Eikix, Please assign this to me


MODCLUSTER-574 Allow custom LoadMetric implementations to put node in…

…to error state (load of -1); cleanup unnecessary boxing/unboxing
https://issues.jboss.org/browse/MODCLUSTER-574

Ok, we wanto to redo this in a way that other metrics do collect and record but return -1 in the end anyway.

Yeah, just noticed, fixed.


no working version in npm for mocha-phantomjs

I see the fix for mocha-phantomjs in the repo, but there's no working published version. Last version in npm is 0.7.1.

We are getting closer to publish new version wih updated few things. Keep calm and wait for it. Ii will be soon ;)

If you can't wait (this is an important feature to me and I didn't want to wait) you can use this hack I made to fix it:
    grunt.registerTask('hackMochaLoader', function () {
        var mlPath = 'node_modules/mocha-loader/index.js';
        var contents = grunt.file.read(mlPath);
        var needsHack = contents.indexOf('initMochaPhantomJS') < 0;
        if (needsHack) {
            var lines = contents.split(lf);
            grunt.log.writeln(lines.length);
            var idx = _.findIndex(lines, function (line) {
                return line.indexOf('mocha.setup') >= 0;
            });
            grunt.log.writeln(idx);
            lines.splice(idx, 0, "\t\tsource.push(\"if(typeof window !== 'undefined' && window.initMochaPhantomJS) { window.initMochaPhantomJS(); }\");");
            grunt.file.write(mlPath, lines.join(lf));
        }
    });

v1.0.0 has just been released and published to npm. Thank you for your patience!


Setup math-magicians

setup  linters
use correct git-flow
create a react app using create-react-app command

INVALID ❌ ❌ ❌
Hi @danutibe07 👋
While you made a great effort in this project, I can't go ahead and review your code.
Invalid Code Review Request ❌
You have submitted a project that doesn't use the correct gitflow 😨, Kindly check this link for more and submit again once you are done 🙏
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Kindly create  a new PR that follows the Gitflow approach
Cheers and Happy coding!👏👏👏
✅ Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Remember to tag me in your question so I can receive the notification.
⚠ Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.


RP-0 versioning

We include a .version file now, but that overrides the tag-set versioning that netkan used to use, so the override is no longer valid, and 0.0.34 is treated as older than v0.33. Wut do?
I manually updated the .ckan for 0.0.34 to be for 1.0.4, but I'm not sure if the next netkan pass won't rebuild it anyway, and we'll be back to 90...

Looking at that, an epoch is likely the required thing.

Yeah the bot did blat it. The download link has RP-0-v0.34 as the version. So the version file would be 0.34.0 to match, however it'd still need a "x_netkan_force_v": true to get it to work.
Playing around with the version file and adding the force v does produce the desired result. Let us know how you wish to handle it and it can be sorted out easy enough :-)

Related: https://github.com/KSP-CKAN/CKAN/pull/1299

I'm fine with whatever way is easiest for you all. I'm away from home and can't dig in properly, so I'm willing to go with whatever. :)

For now I'm yanking the .version and manually setting KSP version.

With KSP-CKAN/CKAN#1299 merged, you can restore the .version file.

With my comment on Aug 11, there's not really anything further in this issue. 9aef77f can be reverted if there's a .version file, otherwise it's fine as is.


Error [ERR_IPC_CHANNEL_CLOSED]: Channel closed

The following server code from the repo sample produces the subsequent errors:
import type { JobProcess } from '@livekit/agents';
import {
  AutoSubscribe,
  type JobContext,
  WorkerOptions,
  cli,
  defineAgent,
  llm,
  pipeline,
} from '@livekit/agents';
import * as deepgram from '@livekit/agents-plugin-deepgram';
import * as openai from '@livekit/agents-plugin-openai';
import * as silero from '@livekit/agents-plugin-silero';
import dotenv from 'dotenv';
import path from 'node:path';
import { fileURLToPath } from 'node:url';
import { z } from 'zod';

const __dirname = path.dirname(fileURLToPath(import.meta.url));
const envPath = path.join(__dirname, '../.env.local');

dotenv.config({ path: envPath });

export default defineAgent({
  prewarm: async (proc: JobProcess) => {
    proc.userData.vad = await silero.VAD.load();
  },
  entry: async (ctx: JobContext) => {
    const vad = ctx.proc.userData.vad! as silero.VAD;
    const initialContext = new llm.ChatContext().append({
      role: llm.ChatRole.SYSTEM,
      text:
        'You are a voice assistant created by LiveKit. Your interface with users will be voice. ' +
        'You should use short and concise responses, and avoiding usage of unpronounceable ' +
        'punctuation.',
    });

    await ctx.connect(undefined, AutoSubscribe.AUDIO_ONLY);
    console.log('waiting for participant');
    const participant = await ctx.waitForParticipant();
    console.log(`starting assistant example agent for ${participant.identity}`);

    const fncCtx: llm.FunctionContext = {
      weather: {
        description: 'Get the weather in a location',
        parameters: z.object({
          location: z.string().describe('The location to get the weather for'),
        }),
        execute: async ({ location }) => {
          console.debug(`executing weather function for ${location}`);
          const response = await fetch(`https://wttr.in/${location}?format=%C+%t`);
          if (!response.ok) {
            throw new Error(`Weather API returned status: ${response.status}`);
          }
          const weather = await response.text();
          return `The weather in ${location} right now is ${weather}.`;
        },
      },
    };

    const agent = new pipeline.VoicePipelineAgent(
      vad,
      new deepgram.STT(),
      new openai.LLM(),
      new openai.TTS(),
      { chatCtx: initialContext, fncCtx },
    );
    agent.start(ctx.room, participant);

    await agent.say('Hey, how can I help you today', true);
  },
});

cli.runApp(new WorkerOptions({ agent: fileURLToPath(import.meta.url) }));

waiting for participant
starting assistant example agent for voice_assistant_user_1461
file:///Users/****/Desktop/livekit/livekit-node-test/node_modules/@livekit/agents/dist/tts/tts.js:167
charactersCount: this.#text.length,
^

TypeError: Cannot read properties of undefined (reading 'length')
at ChunkedStream.monitorMetrics (file:///Users/****/Desktop/livekit/livekit-node-test/node_modules/@livekit/agents/dist/tts/tts.js:167:35)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

Node.js v20.17.0
[10:39:54.476] WARN (63126): job process exited unexpectedly
err: {
"type": "Error",
"message": "Channel closed",
"stack":
Error [ERR_IPC_CHANNEL_CLOSED]: Channel closed
at target.send (node:internal/child_process:754:16)
at Timeout._onTimeout (file:///Users/****/Desktop/livekit/livekit-node-test/node_modules/@livekit/agents/dist/ipc/proc_job_executor.js:47:18)
at listOnTimeout (node:internal/timers:581:17)
at process.processTimers (node:internal/timers:519:7)
"code": "ERR_IPC_CHANNEL_CLOSED"
}

Not sure how to apply debugging / logging...why would the text be undefined?


Update timezone/dst from coordinates using timezonefinder

You'll be able to see a useful diff after merging #13
I noticed that
33041,Key West,FL,25.100957,-81.568862,-5,1
33045,Key West,FL,25.100957,-81.568862,-5,1

incorrectly have coordinates out in the Gulf of Mexico, which sets their timezone to the wrong timezone.
I also noticed issues with Dutch Harbor, Alaska
-99692,Dutch Harbor,AK,53.883729,-166.5485,-10,1
+99692,Dutch Harbor,AK,53.883729,-166.5485,-9,1

Google says it's in the HAST time zone (UTC−10:00 / UTC−9:00) but timezonefinder says it's in Alaska/Nome, which https://en.wikipedia.org/wiki/Time_in_Alaska says is no longer in use. My conversion of timezone names to offsets (which could be wrong, I pieced it together from Stack Overflow answer without much regard to the underlying issues!) and the first results (which is just some site by some people, doesn't look authoritative at all) from https://www.google.com/search?q=alaska%2Fnome+time+zone that actually mentions "Alaska/Nome" instead of just telling the time in Nome, Alaska, have "Alaska/Nome" as a UTC-9/UTC-8 time zone.

I marked this as "ready for review" but only the code part is done. The actual updates to the data should be checked thoroughly and the coordinates for at least one of these zip codes needs to be fixed.


Adonis 6 support

Hi,
I have been using the attachment-advanced package and find it very useful. With the release of AdonisJS 6, I was wondering if there are any plans to update this package to support the new version ?

Yes, it's planned, but I don't have any visibility.

New package in development.
https://github.com/batosai/adonis-attachment
Thanks for motivation


Retire redundant fragment model

The current GraphTransformerGFN supports partial action spaces, there is thus no need for a specialized GraphTransformerFragGFN anymore. This PR replaces the latter with the more general class.

Note that current build fails are fixed by #39.


Changelog page in github referenced from docs.locust.io returns a 404

Description of issue / feature request
The page https://github.com/locustio/locust/CHANGELOG.md as referenced in the locust release notes https://docs.locust.io/en/stable/changelog.html returns a 404 when accessed:-
Request URL: https://github.com/locustio/locust/CHANGELOG.md Request Method: GET Status Code: 404 Not Found Remote Address: <IP_ADDRESS>:443 Referrer Policy: no-referrer-when-downgrade
helpfully with the text "Not Found"
Expected behavior
An up to date changelog (up to date as in up to date with master, or at least the current release) should be visible in github  .
Actual behavior
I see that an issue has been raised and fixed for this https://github.com/locustio/locust/pull/877 to change the link to https://github.com/locustio/locust/blob/master/CHANGELOG.md in docs/changelog.rst but the docs site has not been updated with this change.
Environment settings (for bug reports)
N/A
Steps to reproduce (for bug reports)

go to https://docs.locust.io/en/stable/changelog.html
click the link here "For full details of the Locust changelog, please see https://github.com/locustio/locust/CHANGELOG.md"
"not Found" is returned

as noted, this was already fixed with #877... we just need to republish the docs to readthedocs.  I'll leave this issue open to track it.


double entries in my Sierra dock

Please refer to this screenshot below.
The 2 icons on the left (MP4 and red icon) was created using dockutil --add /Applications/my-app.app. When I click on the icon on the MP4 icon, another icon showed up (the one of the right). But when I clicked on the red icon, it didn't create a new one like the MP4. is this a problem with Sierra or the script?
Thank you so much.

I forgot to add that if I:

move the newer MP4 icon and placed it beside the MP4 icon created dockutil
remove the MP4 created by dockutil

clicking the remaining MP4 icon will not result in two icons again.

@mrjayviper If you clear all MP4 icons from the dock and drag the app you specified to the dock, does launching it also create a second icon?

@mrjayviper Did you ever get this resolved?
As I have encountered the same issue with a 10.12 build in my workplace (we have only just started to build with 10.12).
Had no issue with 10.11, but in 10.12 selected apps (not all of them) are launching with an additional icon. I can't see any permissions/ownerships/groups issue or difference between the ones causing an issue to those that are not.
Very odd, I'm running out of ideas as to what could be causing the issue! My next stage is to try with an older Dockutil version, but my hunch is that its something to do with 10.12 instead.

Apologies I was not able to respond at the time.  As this is a very old issue I will close it.  Please retest with latest dockutil and report back if you are still having the issue.


Defined new revisions for golang dep: github.com/godbus/dbus

Ran component through the scanners since I noticed it had not been harvested yet. PR matches curation site. Closing.


Added examples into reports

I one more time slightly enhanced the report.

I added a capability to load images from attachments to each vulnerability and also to the project.
1.1 Vulnerabilities and images

1.2 Project attachments (only images for now)

I updated how PoC of vulnerability is propagated into the ouput. I am using MD parser to generate the HTML, but I am not inserting it directly into the PHPWord as in case of description. Instead of it, I use XPath to extract all <code> elements and I parse these manually.
This approach has one benefit, PoC can have more examples and all of them are in the output and parsed differently. The con is, that it strips another elements.

generate doc and template
template.docx
test.docx

Great job @gano3s !


Fix building without SSE4.2 inside Docker container.

See #1529.

I think I'd prefer it if configure was changed to appending native instead of replacing the instruction set enabling compiler parameters. That would make it behave closer to the same as cmake and at the same time fix this problem.
IMO, that would be a cleaner solution, with the small benefit of still including optimizations for better instruction sets (in case of future cpu upgrades), and only setting a lower bound to equal the compiling cpus instruction sets.
And as an aside to this; The whole native support could be improved to possibly even bypass functable and such at some point, but that is a pretty big and invasive change.

I think I'd prefer it if configure was changed to appending native instead of replacing the instruction set enabling compiler parameters. That would make it behave closer to the same as cmake and at the same time fix this problem.

That wouldn't fix this specific issue which is basically caused by oversimplified preprocessor defines for SSE4 tests... Basically compiler can use inline assembly for SSE4, but our code has no inline assembly for SSSE3 instructions or older.

So the code itself only actually uses ssse3 instructions, but it's intentionally gated to use sse4 because the checksum + copy routine is actually slower on pre sse4 CPUs due to the misalignment penalty prior to nehalem. The ssse3 checksum version is the same but it does aligning scalar sums before doing purely aligned loads. The copy is then handled separately.

Ah, there are two different issues then.
But I still think this one is a configure/cmake issue. There are no cpus supporting SSE4.2 that do not also support SSSE3, and enabling SSE4.2 (-msse42 in GCC) will also enable all its predecessors. So how can configure then say that SSE4.2 is available, but SSSE3 is not?
I think this part of configure should be changed, as it is kind of backwards today:
https://github.com/zlib-ng/zlib-ng/blob/develop/configure#L1609
            if test ${HAVE_SSE42CRC_INTRIN} -eq 1 || test ${HAVE_SSE42CRC_INLINE_ASM} -eq 1; then
                CFLAGS="${CFLAGS} -DX86_SSE42"
                SFLAGS="${SFLAGS} -DX86_SSE42"

                if test ${HAVE_SSE42CRC_INTRIN} -eq 1; then
                  CFLAGS="${CFLAGS} -DX86_SSE42_CRC_INTRIN"
                  SFLAGS="${SFLAGS} -DX86_SSE42_CRC_INTRIN"
                fi

I think that code snippet should instead set: X86_SSE42 if intrinsics are available, and X86_SSE42_CRC_ASM if inline asm is supported. Perhaps also skip the asm fallback define entirely if intrinsics are supported?
This requires some minor changes to the ifdef checks of course, but IMO this would be the more logical way to do this. The intrinsics are after all the primary, and inline asm is the fallback. This is also how all the other instruction set defines are set (for x86 at least), this one is the odd one out, easily causing these kinds of weird issues and confusions.

So the code itself only actually uses ssse3 instructions, but it's intentionally gated to use sse4.2 because the checksum + copy routine is actually slower on pre sse4.2 CPUs due to the misalignment penalty prior to nehalem. The ssse3 checksum version is the same but it does aligning scalar sums before doing purely aligned loads. The copy is then handled separately.

This would be a great comment to add to the code actually.

Ah, there are two different issues then.
But I still think this one is a configure/cmake issue. There are no cpus supporting SSE4.2 that do not also support SSSE3, and enabling SSE4.2 (-msse42 in GCC) will also enable all its predecessors. So how can configure then say that SSE4.2 is available, but SSSE3 is not?

This isn't about supporting real CPUs... This is only about working around broken cpuid instruction in virtualized Docker containers. As much as I'd like to have best possible patch for everything, I'm really against making huge rewrite if there is shorter solution. The inline assembly was added to work around older compilers that didn't have support for CRC intrinsics but could target SSE4. There is still a lot of systems that are stuck using older compilers due to bugs in newer versions that only affect certain processors that we officially still support, but gcc for example doesn't.

I know this is not about cpu support, this is about the way we do detection, and for SSE4.2 that is done in a strange way that in this case breaks builds and assumptions. I don't see this as being a huge rewrite, it is rather a small number of defines that need renaming and a few ifdef checks that need to be changed. It would in fact improve code quality.
If you don't want to have a go at it, i'll try to find some time for it in the next couple of days, still have a bunch of RL backlog after 2 weeks on vacation.

If you don't want to have a go at it, i'll try to find some time for it in the next couple of days, still have a bunch of RL backlog after 2 weeks on vacation.

I have a real job to focus on currently... When I joined zlib-ng originally, I had been unemployed for over 10 years, so any project was good to keep my skills up-to-date. I still intend to make small patches once in a while, but I leave bigger ones to people who have more spare time.

This would be a great comment to add to the code actually.

I can make a pull request for that if it'd add clarity.  I think the commit messages said something of the same effect.

This is not needed after #1542


add vk_memory_budget sample

Description
Add vk_memory_budget.  This sample demonstrates how to utilize already existing code (the Instancing sample) to determine how much memory is allocated and how much budget is remaining for the GPU device.
General Checklist:
Please ensure the following points are checked:

[x] My code follows the coding style
[x] I have reviewed file licenses
[x] I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
[x] I have commented any added functions (in line with Doxygen)
[x] I have commented any code that could be hard to understand
[x] My changes do not add any new compiler warnings
[x] My changes do not add any new validation layer errors or warnings
[x] I have used existing framework/helper functions where possible
[x] My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions
[x] My changes do not add any regressions
[x] I have tested every sample to ensure everything runs correctly
[x] This PR describes the scope and expected impact of the changes I am making

Sample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

[x] I have tested the sample on at least one compliant Vulkan implementation
[x] If the sample is vendor-specific, I have tagged it appropriately
[x] I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
[x] Any dependent assets have been merged and published in downstream modules
[x] For new samples, I have added a paragraph with a summary to the appropriate chapter in the samples readme

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Jeremy Gong seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


feat: update node / edge

Still working on this. There is a lot of internal state footguns, so I will protect against those or remove some

And... it doesn't work.
ref.current?.updateNodeData(node.id, {}) ends up removing/hiding the node which is... not what i expected.

@sroussey yes, there are plenty of foot guns. I reported concerns with combining custom state management with the setNodes and setEdges functions on the xyflow discord and they said that they're working on cleaning this up. In the meantime, I had to introduce our own state management solution because it was preparatory to introducing node groups.
Let me know when you're happy with this and I'll take a peak

OK, this is what I have been using. I took out the replace version. you can always replace everything in an update, or do a remove and add. I don't think it was usefull.

Is this ready for review? I see there's a method commented out so wasn't sure whether you were happy with where this was at.

I don't see a method commented out. It looks ready, and I've been using it.


[Question] Is it applicable to parsing markdown?

I want to convert between 2 similar formats (DokuWiki -> Obsidian).
But I fail to describe a term "arbitrary text that is not matched by any terms, but surrounded by any recognizable terms". Like, ** any such text // and another one//**, where "**" and "//" are terms properly described to the parser generator.

I've solved this by having open and closed term blocks. I'll have a rule where there's a nterm OPEN_BLOCK with the rules OPEN_BLOCK(OPEN_BLOCK, GENERIC_TERM) and OPEN_BLOCK(OPENING_TERM, GENERIC_TERM). In this case, GENERIC_TERM matches everything, but with very low precedence. I'm also working on adding a wildcard term, though. You could create GENERIC_TERM as a regex_term with the search string \S* or something like that. Then just add terms for spaces and/or newlines

Oh yeah, and you'd close OPEN_BLOCK by having the nterm BLOCK with the rule BLOCK(OPEN_BLOCK, CLOSING_TERM)