[Xamarin.UITest] Terminating app due to uncaught exception 'CBXException', reason: Error codesigning

Using Azure Devops agents starting from a few days ago, when running UI Tests with Xamarin.UITest 3.2.5, using macOS-11 hosted agents and deploying to an iOS simulator, the following error frequently and randomly happens (seemingly because of the underlying host workload) :
iOS test running Xamarin.UITest version: 3.2.5
Skipping IDE integration as important properties are configured. To force IDE integration, add .PreferIdeSettings() to ConfigureApp.
Artifact folder: /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/uitest/a-B12DBCBE594356F58146E1E7DF3F6BD85EEC9B0D
Using cached artifact folder: idevice-tools
Artifact folder: /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/uitest/a-26A53D1CF13472F3F6A43DCDF88504A6C595F156
Running command. { Path: "plutil", Arguments: "-convert xml1 -o - "/Users/runner/work/1/s/build/ios-uitest-build/XXX.app/Info.plist"", CurrentDirectory: "/Users/runner/work/1/a/screenshots/ios" }
Running command. { Path: "xcrun", Arguments: "otool-classic -hv -arch all "/Users/runner/work/1/s/build/ios-uitest-build/XXX.app/Uno.Foundation.dll.config"", CurrentDirectory: "/Users/runner/work/1/a/screenshots/ios" }
Running command. { Path: "xcrun", Arguments: "otool-classic -hv -arch all "/Users/runner/work/1/s/build/ios-uitest-build/XXX.app/XXX.cstemp"", CurrentDirectory: "/Users/runner/work/1/a/screenshots/ios" }
Running command. { Path: "xcrun", Arguments: "strings "/Users/runner/work/1/s/build/ios-uitest-build/XXX.app/XXX.cstemp"", CurrentDirectory: "/Users/runner/work/1/a/screenshots/ios" }
Starting app bundle.  { AppBundle: "/Users/runner/work/1/s/build/ios-uitest-build/XXX.app" }
Running command. { Path: "ps", Arguments: "-xww -o pid,user,args", CurrentDirectory: "/Users/runner/work/1/a/screenshots/ios" }
Running command. { Path: "ps", Arguments: "-xww -o pid,user,args", CurrentDirectory: "/Users/runner/work/1/a/screenshots/ios" }
Running command. { Path: "/usr/bin/xcrun", Arguments: "simctl help 2>&1", CurrentDirectory: "/Users/runner/work/1/a/screenshots/ios" }
Running command. { Path: "/usr/bin/xcrun", Arguments: "simctl list devices --json", CurrentDirectory: "/Users/runner/work/1/a/screenshots/ios" }
Running command. { Path: "ps", Arguments: "-xww -o pid,user,args", CurrentDirectory: "/Users/runner/work/1/a/screenshots/ios" }
Running command. { Path: "plutil", Arguments: "-convert xml1 -o - "/Users/runner/work/1/s/build/ios-uitest-build/XXX.app/Info.plist"", CurrentDirectory: "/Users/runner/work/1/a/screenshots/ios" }
Running command. { Path: "plutil", Arguments: "-convert xml1 -o - "/Users/runner/Library/Developer/CoreSimulator/Devices/662103AD-42CD-401A-84C3-46083AFCCB12/device.plist"", CurrentDirectory: "/Users/runner/work/1/a/screenshots/ios" }
Sim check: App not installed.
1 - Launching simulator if not already running
Running: /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/xdb/DeviceAgent.iOS.Dependencies/80f5333c15d30e893a0f8ed1affb2a32/bin/iOSDeviceManager launch-simulator -d 662103AD-42CD-401A-84C3-46083AFCCB12
Exit code '0' received from '/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/xdb/DeviceAgent.iOS.Dependencies/80f5333c15d30e893a0f8ed1affb2a32/bin/iOSDeviceManager launch-simulator -d 662103AD-42CD-401A-84C3-46083AFCCB12'
1 - InstallApp:
    pathToBundle: /Users/runner/work/1/s/build/ios-uitest-build/XXX.app
    deviceId: 662103AD-42CD-401A-84C3-46083AFCCB12
Running: /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/xdb/DeviceAgent.iOS.Dependencies/80f5333c15d30e893a0f8ed1affb2a32/bin/iOSDeviceManager install "/Users/runner/work/1/s/build/ios-uitest-build/XXX.app" -d 662103AD-42CD-401A-84C3-46083AFCCB12
Exit code '134' received from '/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/xdb/DeviceAgent.iOS.Dependencies/80f5333c15d30e893a0f8ed1affb2a32/bin/iOSDeviceManager install "/Users/runner/work/1/s/build/ios-uitest-build/XXX.app" -d 662103AD-42CD-401A-84C3-46083AFCCB12'
'
	0   CoreFoundation                      0x00007fff20598ecf __exceptionPreprocess + 242
	1   libobjc.A.dylib                     0x00007fff202d2bbb objc_exception_throw + 48
	10  libdyld.dylib                       0x00007fff20442f3d start + 1
	2   iOSDeviceManager                    0x0000000108982317 +[Command resourcesFromArgs:] + 0
	3   iOSDeviceManager                    0x000000010897bdb3 +[Codesigner adHocSign:resourcesToInject:] + 487
	4   iOSDeviceManager                    0x000000010897b72a +[Codesigner resignApplication:withProvisioningProfile:withCodesignIdentity:resourcesToInject:] + 149
	5   iOSDeviceManager                    0x0000000108988841 -[Simulator installApp:mobileProfile:codesignIdentity:resourcesToInject:forceReinstall:] + 333
	6   iOSDeviceManager                    0x0000000108988d23 -[Simulator installApp:resourcesToInject:forceReinstall:] + 33
	7   iOSDeviceManager                    0x0000000108979dcd +[InstallAppCommand execute:] + 868
	8   iOSDeviceManager                    0x00000001089851ae +[CLI process:] + 1114
	9   iOSDeviceManager                    0x00000001089703b1 main + 121
(
)
*** First throw call stack:
2022-02-24 08:28:46.230 iOSDeviceManager[3501:35778] *** Terminating app due to uncaught exception 'CBXException', reason: 'Error codesigning /Users/runner/work/1/s/build/ios-uitest-build/XXX.app: /Users/runner/work/1/s/build/ios-uitest-build/XXX.app: replacing existing signature
App com.companyname.XXX is not installed on 662103AD-42CD-401A-84C3-46083AFCCB12
libc++abi: terminating with uncaught exception of type NSException
Running: /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/xdb/DeviceAgent.iOS.Dependencies/80f5333c15d30e893a0f8ed1affb2a32/bin/iOSDeviceManager is-installed /Users/runner/work/1/s/build/ios-uitest-build/XXX.app -d 662103AD-42CD-401A-84C3-46083AFCCB12
Exit code '2' received from '/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/xdb/DeviceAgent.iOS.Dependencies/80f5333c15d30e893a0f8ed1affb2a32/bin/iOSDeviceManager is-installed /Users/runner/work/1/s/build/ios-uitest-build/XXX.app -d 662103AD-42CD-401A-84C3-46083AFCCB12'
false
Running: /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/xdb/DeviceAgent.iOS.Dependencies/80f5333c15d30e893a0f8ed1affb2a32/bin/iOSDeviceManager is-installed /Users/runner/work/1/s/build/ios-uitest-build/XXX.app -d 662103AD-42CD-401A-84C3-46083AFCCB12
Exit code '2' received from '/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/xdb/DeviceAgent.iOS.Dependencies/80f5333c15d30e893a0f8ed1affb2a32/bin/iOSDeviceManager is-installed /Users/runner/work/1/s/build/ios-uitest-build/XXX.app -d 662103AD-42CD-401A-84C3-46083AFCCB12'
false

This particular error can be traced to this line, but executing the code-signing command manually :
codesign --force --sign - --verbose=4 --timestamp=none --digest-algorithm=sha1,sha256 --deep $UNO_UITEST_IOSBUNDLE_PATH

does not fix the issue, even if the manual code-signing works properly.
Workaround
The only workaround I could find is to pre-install the application on the iOS simulator, so that Xamarin.UITest does not need to do it.
xcrun simctl install "$SIMULATOR_ID" "$IOSAP_PATH"

Hello. Did you set this UDID somewhere in your test configuration?
662103AD-42CD-401A-84C3-46083AFCCB12

Thanks @AlexeyBudynkov. Yes, it's specified explicitly through this block, which is derived from the active list of devices from the machine.
Installing from the CLI with the same udid works properly.

Thanks @AlexeyBudynkov. Yes, it's specified explicitly through this block, which is derived from the active list of devices from the machine.
Installing from the CLI with the same udid works properly.

Can you try to remove DeviceIdentifier before launching on Azure and to try again?
When you choose a device set for launching your tests, device identifier should set automatically.

@jeromelaban Hi there! Could you please update up to 3.2.7 and try to reproduce it? There were some fixes for 134 error.

This is great news!
From: Ilya Bausov @.>
Sent: Monday, May 9, 2022 3:44 PM
To: microsoft/appcenter @.>
Cc: Subscribed @.***>
Subject: Re: [microsoft/appcenter] [Xamarin.UITest] Terminating app due to uncaught exception 'CBXException', reason: Error codesigning (Issue #2389)
@jeromelabanhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjeromelaban&data=05|01|lakss%40microsoft.com|7a4141683db5482e588308da320d6398|72f988bf86f141af91ab2d7cd011db47|1|0|637877330358835838|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=RKtPqpY7WfYuxCf3Ix1k0YwLqCf46EnevnUmabDmb78%3D&reserved=0 Hi there! Could you please update up to 3.2.7 and try to reproduce it? There were some fixes for 134 error.

Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fappcenter%2Fissues%2F2389%23issuecomment-1121653516&data=05|01|lakss%40microsoft.com|7a4141683db5482e588308da320d6398|72f988bf86f141af91ab2d7cd011db47|1|0|637877330358835838|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=bepGzOewR9AlxL9r%2FvTDQueD9S%2Bk4y610s%2FCqfX2FzA%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACX6LJ4TCXNKB3OIA2MVBE3VJGIKPANCNFSM5PIETHIA&data=05|01|lakss%40microsoft.com|7a4141683db5482e588308da320d6398|72f988bf86f141af91ab2d7cd011db47|1|0|637877330358835838|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=cctVwmiegrCuPNMA3ENdkehHo6WVyMKKKvHZfXkRtdc%3D&reserved=0.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

Hello.
Do you still have this issue?

@AlexeyBudynkov Not at this time! Thanks for the follow-up.

@AlexeyBudynkov
This issue is still occurring with hosted macos-12 agents, reverting the host to macOS-11 resolves the issue, but means we can't test on iOS 16 simulators.
This is using the latest Xamarin.UITests nuget (currently 4.1.0).
Is this a known issue? Or would you like me to raise a fresh ticket?

@JohnHDev Hi,
I've answered about it here: https://github.com/microsoft/appcenter/issues/2475/
Let's proceed the discussion in that issue please.


Use gettext_lazy instead of ugettext_lazy.

Removes a ton of warnings in Django 3.

@clintonb would it be possible to have a new release so we can use this?


Address hasBlock deprecation: update to has-block

Fix to issue https://github.com/kaliber5/ember-bootstrap-power-select/issues/297

Wondering why CI isn't running. Also I don't see a button to approve it. Will try to find some time tomorrow to look into it.

It is confusing. CI seems to work for pull requests created by myself. But I also do not see the button to approve the CI for your public fork. :confused:

Odd.
I guess if push comes to shove, you could edit the two templates directly
in GitHub to create a new branch and trigger the CI.
On Fri, Apr 1, 2022, 9:32 AM Jeldrik Hanschke @.***>
wrote:

Wondering why CI isn't running. Also I don't see a button to approve it.
Will try to find some time tomorrow to look into it.
It is confusing. CI seems to work for pull requests created by myself. But
I also do not see the button to approve the CI for your public fork. 😕
—
Reply to this email directly, view it on GitHub
https://github.com/kaliber5/ember-bootstrap-power-select/pull/298#issuecomment-1085904208,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADCBOQSPJRXOQQMOOI5R7T3VC33GDANCNFSM5SF7WWGA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Do not mind. The changes here shouldn't be critical. I will merge them without CI and see the result afterwards. Currently trying to get project into a working state again so that I can release it afterwards.

@sacarino Do you need this urgently? I would like to make sure that it is working with Ember v4 as well as with latest versions of Ember Bootstrap and Ember Power Select before releasing a new major. But could do a release candidate if you have urgent need to use it in your project.

Not urgent at all. I was just looking to clean up our build logs.


rust crates with upper case letters are not handled correctly

how to reproduce:
git clone git@github.com:woodruffw/zizmor.git
cd zizmor
cargo debstatus

gives this output:
│   [build-dependencies]
    │   ├── anyhow v1.0.94 (1.0.86 in debian)
    │   ├── prettyplease v0.2.25 (0.2.6 in debian)
    │   ├── proc-macro2 v1.0.92 (1.0.86 in debian)
    │   ├── quote v1.0.37 (in debian)
 🔴 │   ├── schemafy_lib v0.6.0
 🔴 │   │   ├── Inflector v0.11.4
    │   │   │   ├── lazy_static v1.5.0 (in debian)
    │   │   │   └── regex v1.11.1 (in debian)

And inflector is in Debian: https://packages.debian.org/search?keywords=rust-Inflector&searchon=names&suite=all&section=all

Fixed in 0.6.2 :sparkles:

I just sat down and thought about starting to work on this, and then was very confused about why I couldn't reproduce it :D
Thanks for being so quick!

🐆


New State logic - customization flexibility

This is  a feature request.

Prerequisites

[x] Are you running the latest version?
[x] Are you reporting to the correct repository?
(enso is made of many specialized packages: https://github.com/laravel-enso)
[x] Did you check the documentation?
[x] Did you perform a cursory search?

Description
Hi,
Regarding the new state logic, that dynamically loads states from your vendor modules:
We had some small changes inside the older AppState.php, which now is spread in all State.php classes.
Can we have more flexibility on class bindings? (replacing new $provider with App::make($provider))
vendor/laravel-enso/core/src/Services/State/Builder.php
private function state(Source $source): Collection
{
    return $source->providers()
        ->map(fn ($provider) => App::make($provider))
        ->map(fn ($provider) => [
            'mutation' => $provider->mutation(),
            'state' => $provider->state(),
        ]);
}

Or is there another way of doing this? (I saw that there is a configuration enso.state,vendor that may offer some flexibility, but does not make things easier).
I can PR the App::make($provider) myself it you're ok with it.

Sure, make a PR.
Also, if the changes you're talking about could benefit Enso, we could adopt those as well.

Hi @aocneanu,
PR done. PR: New State logic - customization flexibility #393 #188
As for the changes mentioned, the small changes in ex-appState are related to a bigger change in the permission logic, that adds a new layer that is grouping multiple roles. You have at the moment Users-> Roles-> Permissions. We made a User-> Groups-> Roles-> Permissions, which I believe is too much for a change to be adopted and not sure it's really a benefit for Enso. It's still giving us some headaches when applying :) #185

PR was merged a while ago.


Path Tracking Feature and UX Improvement

[ ] The images which were taken should have a function inside the path tracking feature to track the location of the images.

[ ] User should be able to switch/choose between various ML models for testing their project.

hey just a heads up i am already working on the path tracking issue and i have come close on solving it if you could avoid the first task and work on the second one it would be great :)

Ya sure @carpecodeum I won't work on the first task. No issues


Move doctrine migrations away from src

Related to https://github.com/symfony/recipes/issues/718

Nice change! Thanks @rosier.


Monitor development ModelingToolkit

Outcome of Q3 -2023 & retro 10-7

Closing this. The scaling issue stops us from using MTK at the scale we need for the Netherlands, with O(10.000) nodes. There is https://help.juliahub.com/juliasimcompiler/dev/, but it is proprietary, so we cannot rely on that.
I still like MTK a lot. It would make sense to use it as a library for very custom problems for which Ribasim as an application is not flexible enough.


Sagemaker Neo

I have few questions for Sagemaker Neo:
(Apologies to create an Issue for this but I couldn't get answers on aws forum for the same)

Can I take advantage of Sagemaker Neo if I have an externally trained tensorflow/mxnet model?

Sagemaker provides container image for 'image-classification' and it has released a new image with name 'image-classification-neo' for the neo compilation job. What is the difference between both of them? Do I require a new Neo compatible image for each pre built sagemaker template(container) similarly?

Any help would be appreciated
Thanks!!

Yes, you can compile a TensorFlow or MXNet model trained elsewhere using SageMaker Neo. You can deploy the compiled model in Amazon SageMaker endpoints, AWS EC2 instances, Greengrass devices, or any other machines in the cloud or at the edge that with the Neo runtime installed.

The image-classification image contains the framework (MXNet), which executes the trained model. The image-classification-neo image contains the Neo runtime, which executes the (trained and) compiled model. You can run any XGBoost, TensorFlow, MXNet, or PyTorch model compiled by Neo in a container that includes the Neo runtime (see https://github.com/neo-ai/).

Hi Vin,
Thank You for the response . I have some more questions :

I found two different functions to import externally trained  tensorflow model in sagemaker for inference
a) from sagemaker.tensorflow.model import TensorFlowModel
b) from sagemaker.tensorflow.serving import Model
when I try to use method a) I couldn't import my externally trained tf model  while method b) helped me to load it in sagemaker environment but when I tried to run complied_model it throws me error that this model object has no attribute compiled_model. So can you please suggest me which function can successfully help me load pretrained tensorflow model in sagemaker given that it would support compiled_model function as well
https://forums.aws.amazon.com/thread.jspa?messageID=891164&#891164

How can I compile model from sagemaker Neo which is generated from object detection algorithm (image uri) provided by sagemaker.
https://github.com/awslabs/amazon-sagemaker-examples/blob/master/introduction_to_amazon_algorithms/object_detection_pascalvoc_coco/object_detection_image_json_format.ipynb


docs(theming): added popover theming docs

Closes #1080
📝 Description

Adding Popover theming docs

📝 Additional Information

SVG image needs to be inserted

I think I forgot to add a showcase in theming.mdx file, I'm going to make another commit

@GKosheev here's the gist for the Popover Anatomy illustration: https://gist.github.com/nikolovlazar/15314f3db08a525be7e8ce07b51248d2

@nikolovlazar, I've read the docs and rewrote a few sections.
I've been trying to find the definition of default props for a couple of the components, such as Button (specifically colorScheme prop), but I couldn't.
The only thing I could find is the general definition of ThemingProps interface and the way some of the Button interfaces extend it, for example:
interface ButtonProps extends HTMLChakraProps<"button">, ButtonOptions, ThemingProps<"Button"> {
}

Where can I find default props definitions for each of the components? (specifically in code)

@GKosheev you can check out the Theme Source for each component. Here's the Button theme source: https://github.com/chakra-ui/chakra-ui/blob/main/packages/components/theme/src/components/button.ts. If you scroll at the bottom you'll see the defaultProps definition.

I think the Showcase section could have been done better. Let me think about how to make it prettier, and I'll make a commit later.
I'm thinking of at least adding a change mode icon, adjusting color for different modes, and perhaps, showing & styling some additional components.

@aacevski, let me know if that works. I couldn't think of anything regarding color variants, so I made a rounded version instead.
I liked the notifications example, so I completely followed it.

This looks better, can you just fix the conflicts?

@aacevski, I recently found a way to change the value based on the color mode using useColorModeValue hook, so there is no need of passing colorMode to the other components. I can refactor the code slightly, so it looks cleaner.


wip; rm cjs import in core-frontend for object-storage

@kckst8 could you guys test this out in studio via pnpm patch?
itwinjs-core/core/frontend/lib/{cjs/esm}/tile/TileAdmin.js
        this._tileStoragePromise = (async () => {
            await import("reflect-metadata");
            // eslint-disable-next-line @typescript-eslint/naming-convention
            const { AzureFrontendStorage, FrontendBlockBlobClientWrapperFactory } = await import("@itwin/object-storage-azure/lib/frontend");
            const azureStorage = new AzureFrontendStorage(new FrontendBlockBlobClientWrapperFactory());
            this._tileStorage = new TileStorage(azureStorage);
            return this._tileStorage;
        })();

@GytisCepk mind taking a look at the failing integration test, "should cancel pulling changes after abort signal", in core-full-stack? Failed back to back like 3 times; and i can't imagine my changes here actually breaking it

if you build this usinc CJS it won't be a dynamic import anynore. The whole point was to avoid bundling @azure/storage-blob into the main bundle.

No one should be bundling the CJS modules

Bill beat me to saying it, but he's right. im not aware of anyone consuming our frontend deps as cjs modules. The issue we were seeing earlier was in the core repo we only build cjs by default, so unfortunately we were pulling in the azure blob storage pkg into the bundle, but this is a testing edge case like Bill mentioned earlier.
If you're for some reason consuming the cjs modules in the frontend thats on you imo

alright fair enough, but I think you should keep the webpackChunkName

Any tests that prove blob storage tile cache still works?

Any tests that prove blob storage tile cache still works?

no tests that im aware of atm. @paulius-valiunas is that right? we should make a backlog item to create a test for this if not.
paul, i did test locally with dta using hub models, as well as throw the patch into my tets apps node modules, and everything seemed fine

no tests that im aware of atm. @paulius-valiunas is that right? we should make a backlog item to create a test for this if not.

There was an action item from the 3.4 retro, but I can find no issue filed.

i did test locally with dta

DTA does not use the cloud storage tile cache.

@mergifyio backport release/3.4.x


diagnostic: add check for missing header file

[X] Have you followed the guidelines in our Contributing document?
[X] Have you checked to ensure there aren't other open Pull Requests for the same change?
[X] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

In the PHP tap we see an error with the zlib header missing quite often. This is generally caused by an upgrade of the OS starting in El Capitan where SIP was introduced which seems to delete the /usr/include directory at each operating system upgrade. The PR only checks the zlib.h file since that's the one we've seen problems with but it should be indicative enough to tell if the files are missing or not. I had some problems with the wording due to that but I'm willing to take feedback and make updates =)

hmm that went bad

I've made the update now assuming this is what needed to be done. I tested it but I could not make it trigger while using brew doctor and it didn't seem to matter what I threw at it. It seemed to return the right things but it didn't seem to have an effect on anything and I couldn't figure out why  :'(

It seemed to return the right things but it didn't seem to have an effect on anything and I couldn't figure out why :'(

brew doctor won't complain if you don't have the CLT installed, if that's what you're aiming to do. It will complain if you have neither the CLT or Xcode installed. With your change here it'll bypass using the CLT and use Xcode instead if possible which seems like the right thing to do.
Additionally, this may be something you want to extend all the way back to e.g. 10.9. If you like I can check the status of this file on those older versions (I have VMs).

The thing is that if you have a working system with clt and/or xcode (which I both assume install the headers in /usr/include), upgrade to Sierra from El Cap and at that point the folder is removed and the building of some Formulas (in my case, php) will fail. Brew doctor in that case won't help you to detect that your system is missing the header files. This is what I wanted to accomplish.

PHP needs specifically the CLT and Xcode is not enough? Xcode doesn't install those headers but we can find the headers in the other locations using superenv.
Given what you're suggesting something like your original check may be worth having after all (sorry for asking you to change it) where you state that the CLT is installed but broken and can be fixed by running xcode-select --install.

@javian Any thoughts?

I thought I had responded to this but it must have gotten lost in a forgotten tab somewhere. Do you think it is worthwhile to keep the check that it was changed to ? I'm not sure that would ever trigger since doctor isn't checking up on it so I'm wondering if I should revert the change or include both.

@javian Let's pass on both for now but if you see more issues reported that we could debug this way let us know 👍


Update stop support for the gateway alarm?

Hello,
I am using the alarm feature of the Xiaomi Gateway 3 (ZNDMWG03LM version 1.5.4_xxxx) and up until 2-3 days ago everything was fine, no I get the following error:

Is it not supported any more?

Your gateway doesn't work at all. You need to check errors in logs.

THANK YOU for the super fast comment, for some reason I had to reconfigure the gateway and it worked, thank you very much!


Protect target (name and id) defines

Description
Add protection against double definitions for the bolos target.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (master@2e56806). Learn more about missing BASE report.
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #709   +/-   ##
=========================================
  Coverage          ?   60.19%
=========================================
  Files             ?       12
  Lines             ?     1726
  Branches          ?        0
=========================================
  Hits              ?     1039
  Misses            ?      687
  Partials          ?        0

Flag
Coverage Δ

unittests
60.19% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add blocking_read_with_buffer for C binding

issue: https://github.com/apache/incubator-opendal/issues/3257

To be more specific, we could have two functions to reach this approach

opendal_reader_new() to construct a new Reader
opendal_reader_buffer_read() to read through a Reader

For the first function, you could refer to the opendal_operator_new(). For the second part, your implementation in this PR will not change much.

2. opendal_reader_buffer_read() to read through a Reader

Negative. We should only have opendal_reader_read() that accepts an address passed by the C side.

opendal_reader_buffer_read() to read through a Reader

Negative. We should only have opendal_reader_read() that accepts an address passed by the C side.

Hmm, so we setup the reader (buffer size, path, etc.) on the first function, and then do the read that follows the configuration?

Hmm, so we setup the reader (buffer size, path, etc.) on the first function, and then do the read that follows the configuration?

The input write buffer size should be passed in every read call the same as in this PR.
I am concerned about the API semantics. We will not offer opendal_reader_buffer_read() because it implies that we will have a opendal_reader_read().

Hi @Xuanwo @Ji-Xinyou , should I improve this pull request, or should I open a new one? 🤔

should I improve this pull request, or should I open a new one? 🤔

Both LGTM, I think you can work on this PR directly.

All other parts look LGTM, except for the return value of reader read. I mean it is always good to have as much error information as possible 🤣

Hi, @jiaoew1991, https://github.com/apache/incubator-opendal/pull/3250 is about to merge. Maybe you can work upon it directly?

@Xuanwo Updated it, but most of the CI jobs are cancelled 😅

I closed and reopened this PR to rerun the CI.

I found an issue that our naming for structs and functions is inconsistent. The word blocking shown up randomly.
cc @Ji-Xinyou, how about removing all blocking from our API for now? We can add async version in the future.

I found an issue that our naming for structs and functions is inconsistent. The word blocking shown up randomly.
cc @Ji-Xinyou, how about removing all blocking from our API for now? We can add async version in the future.

Sure, that could be the default case since blocking is the most common.
When we add async in the future, we can add async keyword in the API.

Sure, that could be the default case since blocking is the most common.
When we add async in the future, we can add async keyword in the API.

Cool, would you like to submit a PR after this one merged?


Contrib addition

What's this pull request about
I have provided the details about contributing and noted three points very specifically:

what to contribute
how to contribute(process of contrbuting)
rules for contributing

About merging
At the time of sending pull request, this is totally able to merge with dev branch
I hope this pull request would be accepted...

Thanks for the contribution u1404032. I hope, you would contribute more in the future.


Fix README.md for crash avoidance and portability

As I want to support other users of this test suite, not to run into the same problems as I, here some minor modifications to the README.
A user following the new README will avoid

the crash of the table-reporter
the not-recognizing of Trellis server on non-bash systems.

I structured them into 2 commits, if you want to cherry-pick.

Thanks for accepting.

Thank you for contributing, and putting up with me asking for a PR :-)


youtube-transcript-api can't retrieve the video transcript (subtitles are disabled)???

DO NOT DELETE THIS! Please take the time to fill this out properly. I am not able to help you if I do not know what you are executing and what error messages you are getting. If you are having problems with a specific video make sure to include the video id.
To Reproduce
Steps to reproduce the behavior:
What code / cli command are you executing?
from youtube_transcript_api import YouTubeTranscriptApi
from youtube_transcript_api.formatters import JSONFormatter
id = 'JElxE1u-ojo'
transcript = YouTubeTranscriptApi.get_transcript(id)
formatter = JSONFormatter()
json_formatted = formatter.format_transcript(transcript)
result = {'data': json_formatted}
print(result)
Which Python version are you using?
Python 3.12.7
Which version of youtube-transcript-api are you using?
youtube-transcript-api (latest version)
Expected behavior
The code should display the full YouTube video transcript
For example: I expected to receive the english transcript
Actual behaviour
It displays the following error:
For example: Instead I received the following error message:
The operation failed with an error. [400] Bad request. Please check your parameters. More details: Your code did not execute successfully: Traceback (most recent call last): File "/home/bun/app/sandbox/914887d6-e249-4f73-9997-876fa31b0115/0ck-code-app.py", line 8, in  transcript = YouTubeTranscriptApi.get_transcript(id) File "/home/bun/.local/lib/python3.9/site-packages/youtube_transcript_api/_api.py", line 137, in get_transcript return cls.list_transcripts(video_id, proxies, cookies).find_transcript(languages).fetch(preserve_formatting=preserve_formatting) File "/home/bun/.local/lib/python3.9/site-packages/youtube_transcript_api/_api.py", line 71, in list_transcripts return TranscriptListFetcher(http_client).fetch(video_id) File "/home/bun/.local/lib/python3.9/site-packages/youtube_transcript_api/_transcripts.py", line 48, in fetch self._extract_captions_json(self._fetch_video_html(video_id), video_id), File "/home/bun/.local/lib/python3.9/site-packages/youtube_transcript_api/_transcripts.py", line 62, in _extract_captions_json raise TranscriptsDisabled(video_id) youtube_transcript_api._errors.TranscriptsDisabled: Could not retrieve a transcript for the video https://www.youtube.com/watch?v=Op7Th100IY8! This is most likely caused by: Subtitles are disabled for this video If you are sure that the described cause is not responsible for this error and that a transcript should be retrievable, please create an issue at https://github.com/jdepoix/youtube-transcript-api/issues. Please add which version of youtube_transcript_api you are using and provide the information needed to replicate the error. Also make sure that there are no open issues which already describe your problem!

I am also getting this on some api calls, but not all. If I watch the video on youtube, the CC and transcript are available. This is the youtube id I used to get the error https://www.youtube.com/watch?v=W5fP-siGUVU

I have the same problem.

Same issue here...

Duplicate of #303

I was having the same issue, ended up making a similar program, may not work in your case though since it also adds the subtitles to the video. It's more barebones than this repo but it works https://github.com/tikene/video-caption-and-translate - I'll delete this if linking other repos isnt allowed


Added a better implementation of Conditional Instance Normalization

The current implementation is correct, but because you are indexing in a ModuleList, it's currently not possible to convert the torch model to ONNX or trace it with TorchScript.
I have changed the implementation a bit, it now uses nn.Embedding to store the shift and scale parameters, which I think is more consistent with the authors' implementation in the Magenta Demos repo.
Just my two cents, you can accept the PR if you like. I've added a new trained model for the updated network. I couldn't run inference on your content image due to memory issue, so I chose a smaller image.
By the way, awesome implementation. Its one of the few on the internet I could find, probably the only one for Pytorch. Thanks a lot for creating it.

@Aftaab99 Glad that you found this repo helpful. Thank you for the pull request. Sorry I kind of checked out this project for a long time...
TBH, I was really unfamiliar with ONNX and I have never dealt with pull request :sweat_smile:. I'm afraid I will not have the time to check the details of your implementation. So I guess most likely I will just accept an option for ONNX using your method.
Again sorry, it may take some time for me to process your request,  lots of things happened this year to me and I need to prioritize other stuff.

Cool, I totally understand.


Update GBIF .zip file URL

They changed the .zip file location and name
Fixes #6

Funny thing is, they setup a redirect for the old URL, but the redirect goes to a wrong page.
Should go to:
https://hosted-datasets.gbif.org/datasets/backbone/current/backbone.zip
but instead goes to:
https://hosted-datasets.gbif.org/datasets/backbone/backbone-current.zip


User data rework and mute pause helpers

This moves out several maps to handle event nature, using UserData of EventInstance.

https://github.com/alexfonseka/godot-fmod-integration/pull/19#issuecomment-505685055

You also need to lock when releasing events

No callbacks in this branch, so no lock for now.


Url '+' sign always encoded to %20 or %2B

I am doing some calls on an API that specific requires the '+' sign in the query parameter value. It seems kind of odd that there is no way to specify the request to leave the url as it is, at least for the query parameters value.
For example http://example.org/path?query_param=foo+bar

Yep, I think we were a little too aggressive in picking the canonical form here.

:+1:


📜 feat: Customize Privacy Policy & Terms of Service

This is pending extra translations, but I wanted to know if this was the correct approach

Summary

Added interface.privacyPolicy and interface.termsOfService configuration, enabling the addition of these external links on the login and chat windows.
Implemented retrospectively in both the login and chat pages
Type updates for the config

Resolves #1610
Change Type

[x] New feature (non-breaking change which adds functionality)
[ ] Translation update

Testing

Not much to test, but existing and new configuration seems to work

Checklist
Please delete any irrelevant options.

[x] My code adheres to this project's style guidelines
[x] I have performed a self-review of my own code
[x] My changes do not introduce new warnings
[x] Local unit tests pass with my changes

I haven't documented this well, but please also bump the version of the "data-provider" package:
https://github.com/danny-avila/LibreChat/blob/1b8c0f0bfd6d80848df3cd6de92f7edae01ba5fd/packages/data-provider/package.json#L3
I do this whenever I make updates to this workspace.
Also, since you added new features to the config file, also bump the config file version:
https://github.com/danny-avila/LibreChat/blob/1b8c0f0bfd6d80848df3cd6de92f7edae01ba5fd/packages/data-provider/src/config.ts#L472

Nevermind about bumping the versions as I'm about to make changes there.


Unable to use select.

I am having issue in select element of materializecss. I am using Angularjs + materializecss
In my jade file
//Stylesheets
		link(rel='stylesheet', href='https://cdnjs.cloudflare.com/ajax/libs/materialize/0.97.2/css/materialize.min.css' )

//Vendor Scripts
		script(src='https://ajax.googleapis.com/ajax/libs/jquery/1.11.3/jquery.min.js')
		script(src='https://cdnjs.cloudflare.com/ajax/libs/materialize/0.97.2/js/materialize.min.js')

In my controller I am initializing the component as
$('select').material_select();

In my HTML I am using as
Materialize Select
<select>
   <option value="" disabled selected>Choose your option</option>
   <option value="1">Option 1</option>
   <option value="2">Option 2</option>
   <option value="3">Option 3</option>
</select>

However when I try to select the options nothing happens.
below is what displayed after initialization

HTMl that gets generated looks like below

      ▼<input type="text" class="select-dropdown" readonly="true" data-activates="select-options-b9fd5517-0d0d-40ff-ab29-d37fc9a8d05f" value="Choose your option">
      <select class="initialized">
         <option value="" disabled="" selected="">Choose your option</option>
         <option value="1">Option 1</option>
         <option value="2">Option 2</option>
         <option value="3">Option 3</option>
      </select>

As you can see ul element is not getting generated which generated after initialization.
Any clue what could be issue here.

Oops..
It was a version issue
I was using 0.97.2


Modernize CMake, reorganize file layout and move to latest Catch2 framework

Hey,
I started to use this library in a personal project and I thought it might need some CMake love to make it easier to consume it from other projects.
Now the library can be properly installed and easily used through CMake's find_package, or directly through CMake's FetchContent* functions.
I also set it up to use mainstream's Catch2 testing framework.
There are almost no source-code changes, other than making a function more const-correct and updating the #include directive to use Catch2, so it 99% only build/install infrastructure and file location changes.
P.S.: I'm no windows expert and I don't have access to any windows host, so I couldn't test the build there...

This change is

Thanks


Allow transform the translations

Hi guys!
Great work on this.
I was trying yo find the way to transform the translations to avoid write them many times (upperCase, snakeCase, etc.).
Finally I'm doing this to share the translation component thought all the app.
Maybe this is a good feature:
In my case I'm using lodash to do my transformations and here I can wrap the different requirements.
Vue.mixin({
  methods: {
    locale: function (translate, data) {
      return data && data.toUpper ? _.toUpper(this.$t(translate, data)) : this.$t(translate, data)
    }
  }
})

Hi @EmilianoBarbozaOjeda
Nice solution. Although I would recommend to use the vue plugin system to create custom filters that will allow you to do the uppercase / camelCase / snakeCase conversion.
// filters.js
const FiltersPlugin = {
  install: function(Vue, options) {

    // display the size of a file in human readable format
    Vue.filter('size', function(value) {

      if(value > 1048576) {
        return Math.round(value / 1048576) + ' MB';
      } else {
        // fix for non rounding toFixed
        let exact = value / 1048576;
        return (Math.round( exact * 100 ) / 100).toFixed(1) + ' MB';
      }
    });

    // capitalize a term
    Vue.filter('capitalize', function(text) {

      if (!text) {
        return null;
      }

      if (text == '') {
        return '';
      }

      return text[0].toUpperCase() + text.slice(1);
    });

  }
};

export default FiltersPlugin;

// main.js
import Filters from './filters';
Vue.use(Filters);

Thanks @tikiatua for your help.
I could see that the use of filters in directives were removed, so it's not really possible to do that anymore. This is the discussion where Boris explain that. https://github.com/vuejs/vue/issues/5939
I cannot to this anymore
v-text="$t('personalInformation') | upperCase"

I see. May I ask what the reason was for you to use v-text instead of mustache interpolation {{$t('personalInformation') | upperCase}}?

Sure, I don't want to see that syntax when the view is been rendered. That's the case.

A short remark for other readers:
This is only the case if you put the interpolation directly into the html of your site. If you pre-compile the vue components (using webpack and vue-loader) or put the markup into a <script type="text/x-template"></script> tag, then this should not be an issue.


added WaitInit to Writer and Reader

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Other information

Codecov Report
Patch coverage: 38.70% and project coverage change: -13.02% :warning:

Comparison is base (2b953aa) 66.34% compared to head (fa62316) 53.32%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #803       +/-   ##
===========================================
- Coverage   66.34%   53.32%   -13.02%
===========================================
  Files         233      226        -7
  Lines       23079    22954      -125
===========================================
- Hits        15311    12240     -3071
- Misses       6966     9828     +2862
- Partials      802      886       +84

Flag
Coverage Δ

53.32% <38.70%> (-0.41%)
:arrow_down:

go-1.17.x
?

go-1.19.x
53.32% <38.70%> (-12.74%)
:arrow_down:

go-1.20.x
?

integration
53.32% <38.70%> (-0.41%)
:arrow_down:

macOS
?

ubuntu
?

unit
?

windows
?

ydb-22.5
53.11% <38.70%> (-0.50%)
:arrow_down:

ydb-23.1
?

ydb-23.2
?

ydb-23.2-slim
53.27% <38.70%> (-0.35%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

internal/topic/topicwriterinternal/writer.go
66.66% <0.00%> (-6.07%)
:arrow_down:

topic/topicwriter/topicwriter.go
80.00% <0.00%> (-20.00%)
:arrow_down:

...al/topic/topicwriterinternal/writer_reconnector.go
68.02% <30.76%> (-11.89%)
:arrow_down:

...al/topic/topicreaderinternal/stream_reconnector.go
72.65% <57.14%> (-22.82%)
:arrow_down:

... and 90 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update Brewfile and Remove Eza Config from TODO

Pull Request
Description
A description of the pull request.
Why make this change?
A description of the reason for the change.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#111  👈
#110
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JackPlowman and the rest of your teammates on  Graphite

Merge activity

Oct 9, 3:19 PM EDT: A user merged this pull request with Graphite.


Just bricked a DFP-34X-2C2 flashing a custom firmware

Hi,
Tried to modify original firmware (tarball found here: https://github.com/Anime4000/RTL960x/blob/main/Firmware/DFP-34X-2C2/M110_sfp_ODI_220923.tar) with this procedure documented here: https://github.com/Anime4000/RTL960x/blob/main/Docs/Modify_Firmware.md. Basically I injected the updated files needed for the "vlan fix" here: https://github.com/Anime4000/RTL960x/tree/main/Tools/etc. So, packed everything into a new tarball and updated firmware via web portal, after that, I could not access the stick anymore, ethernet interface of the stick does not come up. Is there a way to switch to the alternate image, which should be still good? Any other alternatives?
BTW, I did not use the firmware with that "fix" (found here: https://github.com/Anime4000/RTL960x/blob/main/Firmware/DFP-34X-2C2/M110_sfp_ODI_220817.tar) because it has outdated scripts that are not so configurable and even can wear the flash chip over time.
In case the only way is to spi-reflash using an external programmer, I saw different information regarding flash layout which is confusing (here: https://github.com/Anime4000/RTL960x/issues/126 and here: https://hack-gpon.github.io/ont-odi-realtek-dfp-34x-2c2/).
What would be the easiest path to recover access to the stick without buying a new one?
PS: I don't have a SPI programmer but I have a 3.3V USB-TTL converter and I may try to access the UART, but I would like first to get your opinions if I can solve anything using that strategy.
Many thanks.

the stick have two boot partition, r0, k0 and r1, k1
use UART and switch boot, reboot
you will boot another partition and reflash again with correct firmware

Thanks @Anime4000! Just soldered tx and rx wires to the pads, ground to the metal cage and connected everything through the ttl to serial adapter, I presume baud rate is 115200, N81. All I receive is garbled chars, even press some keys at the beginning and nothing different, unless there is some magic key sequence to activate the bootloader options. I think I may have messed up with the bootloader. I will have access to an spi flash programmer soon, is there any chance someone gets me the 8Mbyte full image of the flash chip of a working and reset to defaults DFP-34X-2C2 stick? Many thanks.

baud rate is correct and everything is default serial parameter. it should be have text output, I use putty to manage it

Hi. How can I disassemble it? I need to fix wrong LAN_SDS_MODE


Better Documentation for using convco as git editor

Describe the bug
Setting the git editor as convco commit doens't work
To Reproduce

Install convco
Set core.editor as convco commit in git config
run git commit
convco commit complains that there is an unxepected argument, which is path/to/repo/.git/COMMIT_EDITMSG

Expected behavior
Convco commit should run and after done git should proceed with committing the files
System (please complete the following information):

OS: NixOS
Version: 23.11

Additional context
I am sure I am configuring something wrong, so maybe a little bit of clarification should be enough.

added an example how to use it.
I will release this weekend (or tonight).
Please open a new ticket if it still does not work with the new version


Examples

Hi, could you provide some real examples. As I understand I can do something like
import htmlTemplate from './template.html';

document.body.innerHTML = htmlTemplate;

Can you use some kind of variables in template? If it returns an ES6 template string, then you could be able to call htmlTemplate(data);

Hi @Mevrael, the main usecase for this plugin I have in mind is rather for other templating engines or libraries. E.g, Vue.js, Knockout.js or Handlebars work with plain HTML templates. This plugin is supposed to provide the ability to deliver your templates bundled with your JS code. The main thing I needed this plugin for is HTML minification.
import template from './template.html';
// template is minfied or otherwise modified according to the plugin settings in htmlMinifierOptions

Vue.component('some-element', {
    template: template,
    // ...
});

I think that your wish regarding template literals would be the job of a separate plugin.

I see, but isn't it what rollup string plugin already does?

Unfortunately no. It retrieves the whole text from the file. With this plugin I wanted to have HTML specific optimizations (e.g. stripping whitespace, minifieing inline JS/CSS, remove unnecessary attribute quotes, etc.).
(PS: sorry for the late response.)


chore: fix dev process + delete examples apps

Description

Updates vite packages to fix issues with dev process
Adds dynamic support to token changes in dev mode
Removes examples directory in favor of developing in storybook

Tasks
KNO-6143

Merge activity

Jun 6, 3:13 PM CDT: @kylemcd started a stack merge that includes this pull request via Graphite.


Please don't use gettimeofday() for precision timing measurements

What the subject says, doing this is very imprecise as gettimeofday makes absolutely none of the guarantees required for the precision of timing memory latencies.
https://github.com/ChipsandCheese/MemoryLatencyTest/blob/85490591573d42d1ea75180e07471437e1586b6c/src/memorylatency.c#L70-L79
I can recommend this for further reading:
https://blog.habets.se/2010/09/gettimeofday-should-never-be-used-to-measure-time.html
Instead I suggest looking at this instead, using the TSC operators to count cycles.
https://coderedirect.com/questions/166671/memory-latency-measurement-with-time-stamp-counter

Further to this gettimeofday() works on the order of microseconds and often has a resolution on the order of 10 ms ontop of system call latency.
Additionally it may be subject to changes by other system time events such as ntp synchronization. So it can jump back or forward unpredictably.
As it stands this code is woefully unfit for purpose.


Parallelize Ewald::kspace_virial

This PR:

implements parallelization for Ewald::kspace_virial
implements std::iter::Sum<Matrix3> for Matrix3 so that we can use sum on the parallel iterators

I'm still fiddling with parallel iterators, so any suggestion is very welcome, especially about readability :).

I suggest that we do not try to merge PRs labeled A-Performance until they are at least benchmarked once, preferably on multiple machines.

Comparing to master (a1bceef4)
using --threshold 2, latest commit first
8d1b97f4 Parallelize Ewald::kspace_virial

 name                 a1bceef4.txt ns/iter     8d1b97f4.txt ns/iter     diff ns/iter   diff %
 nacl::virial_ewald   48,710,730 (+/- 361018)  12,727,884 (+/- 262534)   -35,982,846  -73.87%
 water::virial_ewald  69,899,798 (+/- 776610)  18,461,278 (+/- 226825)   -51,438,520  -73.59%

Individual benchmarks
8d1b97f4 Parallelize Ewald::kspace_virial

running 4 tests
test argon::cache_move_particle ... bench:     243,450 ns/iter (+/- 2,095)
test argon::energy              ... bench:   1,850,304 ns/iter (+/- 3,058)
test argon::forces              ... bench:   2,357,412 ns/iter (+/- 5,311)
test argon::virial              ... bench:   2,710,101 ns/iter (+/- 14,889)

test result: ok. 0 passed; 0 failed; 0 ignored; 4 measured

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured

running 8 tests
test nacl::cache_move_particle_ewald ... bench:     408,756 ns/iter (+/- 990)
test nacl::cache_move_particle_wolf  ... bench:     107,107 ns/iter (+/- 346)
test nacl::energy_ewald              ... bench:     616,601 ns/iter (+/- 813)
test nacl::energy_wolf               ... bench:     473,725 ns/iter (+/- 1,867)
test nacl::forces_ewald              ... bench:  17,243,777 ns/iter (+/- 46,564)
test nacl::forces_wolf               ... bench:     662,109 ns/iter (+/- 881)
test nacl::virial_ewald              ... bench:  12,727,884 ns/iter (+/- 262,534)
test nacl::virial_wolf               ... bench:     665,635 ns/iter (+/- 1,192)

test result: ok. 0 passed; 0 failed; 0 ignored; 8 measured

running 5 tests
test propane::cache_move_all_rigid_molecules ... bench:   1,027,142 ns/iter (+/- 16,522)
test propane::cache_move_particles           ... bench:     281,486 ns/iter (+/- 10,824)
test propane::energy                         ... bench:   1,117,843 ns/iter (+/- 8,791)
test propane::forces                         ... bench:   1,382,280 ns/iter (+/- 64,803)
test propane::virial                         ... bench:   1,444,279 ns/iter (+/- 1,496)

test result: ok. 0 passed; 0 failed; 0 ignored; 5 measured

running 10 tests
test water::cache_move_all_rigid_molecules_ewald ... bench:   8,520,394 ns/iter (+/- 21,074)
test water::cache_move_all_rigid_molecules_wolf  ... bench:   8,181,119 ns/iter (+/- 28,296)
test water::cache_move_particles_ewald           ... bench:     857,846 ns/iter (+/- 10,420)
test water::cache_move_particles_wolf            ... bench:     489,692 ns/iter (+/- 1,623)
test water::energy_ewald                         ... bench:   1,013,444 ns/iter (+/- 2,238)
test water::energy_wolf                          ... bench:     729,696 ns/iter (+/- 994)
test water::forces_ewald                         ... bench:  24,884,744 ns/iter (+/- 52,431)
test water::forces_wolf                          ... bench:     996,763 ns/iter (+/- 3,051)
test water::virial_ewald                         ... bench:  18,461,278 ns/iter (+/- 226,825)
test water::virial_wolf                          ... bench:     994,927 ns/iter (+/- 4,928)

test result: ok. 0 passed; 0 failed; 0 ignored; 10 measured

a1bceef4 Update dependencies for parallelization

running 4 tests
test argon::cache_move_particle ... bench:     244,295 ns/iter (+/- 2,059)
test argon::energy              ... bench:   1,849,892 ns/iter (+/- 3,883)
test argon::forces              ... bench:   2,356,088 ns/iter (+/- 5,538)
test argon::virial              ... bench:   2,711,542 ns/iter (+/- 8,162)

test result: ok. 0 passed; 0 failed; 0 ignored; 4 measured

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured

running 8 tests
test nacl::cache_move_particle_ewald ... bench:     408,222 ns/iter (+/- 549)
test nacl::cache_move_particle_wolf  ... bench:     106,742 ns/iter (+/- 382)
test nacl::energy_ewald              ... bench:     618,733 ns/iter (+/- 579)
test nacl::energy_wolf               ... bench:     472,718 ns/iter (+/- 953)
test nacl::forces_ewald              ... bench:  17,185,091 ns/iter (+/- 50,755)
test nacl::forces_wolf               ... bench:     666,549 ns/iter (+/- 507)
test nacl::virial_ewald              ... bench:  48,710,730 ns/iter (+/- 361,018)
test nacl::virial_wolf               ... bench:     664,178 ns/iter (+/- 1,808)

test result: ok. 0 passed; 0 failed; 0 ignored; 8 measured

running 5 tests
test propane::cache_move_all_rigid_molecules ... bench:   1,029,301 ns/iter (+/- 53,107)
test propane::cache_move_particles           ... bench:     280,838 ns/iter (+/- 11,188)
test propane::energy                         ... bench:   1,112,118 ns/iter (+/- 1,721)
test propane::forces                         ... bench:   1,379,721 ns/iter (+/- 7,166)
test propane::virial                         ... bench:   1,444,406 ns/iter (+/- 3,079)

test result: ok. 0 passed; 0 failed; 0 ignored; 5 measured

running 10 tests
test water::cache_move_all_rigid_molecules_ewald ... bench:   8,458,254 ns/iter (+/- 30,675)
test water::cache_move_all_rigid_molecules_wolf  ... bench:   8,148,021 ns/iter (+/- 47,201)
test water::cache_move_particles_ewald           ... bench:     854,026 ns/iter (+/- 3,654)
test water::cache_move_particles_wolf            ... bench:     481,631 ns/iter (+/- 2,911)
test water::energy_ewald                         ... bench:   1,018,370 ns/iter (+/- 3,201)
test water::energy_wolf                          ... bench:     730,794 ns/iter (+/- 1,206)
test water::forces_ewald                         ... bench:  24,942,186 ns/iter (+/- 50,668)
test water::forces_wolf                          ... bench:     997,998 ns/iter (+/- 1,451)
test water::virial_ewald                         ... bench:  69,899,798 ns/iter (+/- 776,610)
test water::virial_wolf                          ... bench:     994,150 ns/iter (+/- 1,154)

test result: ok. 0 passed; 0 failed; 0 ignored; 10 measured

CPU: Intel(R) Core(TM) i7-5700HQ CPU @ 2.70GHz

I managed to compile lumol on our cluster, so the benchmarks are running on 16 processors right now for all your PR. I'll give a look to the code when they finish =)

Comparing to master (a1bceef4)
using --threshold 2, latest commit first
8d1b97f4 Parallelize Ewald::kspace_virial

 name                 a1bceef4.txt ns/iter       8d1b97f4.txt ns/iter      diff ns/iter   diff %
 nacl::virial_ewald   107,375,867 (+/- 1348490)  8,935,012 (+/- 1395956)    -98,440,855  -91.68%
 water::virial_ewald  156,863,695 (+/- 46167)    13,027,936 (+/- 1033377)  -143,835,759  -91.69%

Individual benchmarks
8d1b97f4 Parallelize Ewald::kspace_virial

running 4 tests
test argon::cache_move_particle ... bench:     327,084 ns/iter (+/- 2,638)
test argon::energy              ... bench:   4,002,684 ns/iter (+/- 9,845)
test argon::forces              ... bench:   4,499,032 ns/iter (+/- 5,694)
test argon::virial              ... bench:   5,383,545 ns/iter (+/- 6,842)

test result: ok. 0 passed; 0 failed; 0 ignored; 4 measured

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured

running 8 tests
test nacl::cache_move_particle_ewald ... bench:     655,670 ns/iter (+/- 1,433)
test nacl::cache_move_particle_wolf  ... bench:     167,603 ns/iter (+/- 276)
test nacl::energy_ewald              ... bench:   1,155,752 ns/iter (+/- 1,525)
test nacl::energy_wolf               ... bench:     953,714 ns/iter (+/- 909)
test nacl::forces_ewald              ... bench:  25,327,793 ns/iter (+/- 93,872)
test nacl::forces_wolf               ... bench:   1,137,115 ns/iter (+/- 703)
test nacl::virial_ewald              ... bench:   8,935,012 ns/iter (+/- 1,395,956)
test nacl::virial_wolf               ... bench:   1,170,318 ns/iter (+/- 1,055)

test result: ok. 0 passed; 0 failed; 0 ignored; 8 measured

running 5 tests
test propane::cache_move_all_rigid_molecules ... bench:   1,989,406 ns/iter (+/- 5,963)
test propane::cache_move_particles           ... bench:     514,672 ns/iter (+/- 2,510)
test propane::energy                         ... bench:   2,195,213 ns/iter (+/- 21,511)
test propane::forces                         ... bench:   2,568,891 ns/iter (+/- 15,581)
test propane::virial                         ... bench:   2,727,135 ns/iter (+/- 3,058)

test result: ok. 0 passed; 0 failed; 0 ignored; 5 measured

running 10 tests
test water::cache_move_all_rigid_molecules_ewald ... bench:  12,998,618 ns/iter (+/- 9,712)
test water::cache_move_all_rigid_molecules_wolf  ... bench:  12,475,912 ns/iter (+/- 41,596)
test water::cache_move_particles_ewald           ... bench:   1,387,506 ns/iter (+/- 9,793)
test water::cache_move_particles_wolf            ... bench:     746,276 ns/iter (+/- 10,422)
test water::energy_ewald                         ... bench:   1,891,986 ns/iter (+/- 1,922)
test water::energy_wolf                          ... bench:   1,430,055 ns/iter (+/- 1,054)
test water::forces_ewald                         ... bench:  37,182,811 ns/iter (+/- 85,465)
test water::forces_wolf                          ... bench:   1,714,152 ns/iter (+/- 1,500)
test water::virial_ewald                         ... bench:  13,027,936 ns/iter (+/- 1,033,377)
test water::virial_wolf                          ... bench:   1,755,135 ns/iter (+/- 2,154)

test result: ok. 0 passed; 0 failed; 0 ignored; 10 measured

a1bceef4 Update dependencies for parallelization

running 4 tests
test argon::cache_move_particle ... bench:     330,572 ns/iter (+/- 2,957)
test argon::energy              ... bench:   3,998,550 ns/iter (+/- 10,829)
test argon::forces              ... bench:   4,505,721 ns/iter (+/- 5,697)
test argon::virial              ... bench:   5,389,606 ns/iter (+/- 6,540)

test result: ok. 0 passed; 0 failed; 0 ignored; 4 measured

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured

running 8 tests
test nacl::cache_move_particle_ewald ... bench:     655,759 ns/iter (+/- 1,026)
test nacl::cache_move_particle_wolf  ... bench:     167,046 ns/iter (+/- 271)
test nacl::energy_ewald              ... bench:   1,154,968 ns/iter (+/- 1,853)
test nacl::energy_wolf               ... bench:     960,230 ns/iter (+/- 606)
test nacl::forces_ewald              ... bench:  25,309,620 ns/iter (+/- 100,631)
test nacl::forces_wolf               ... bench:   1,140,670 ns/iter (+/- 698)
test nacl::virial_ewald              ... bench: 107,375,867 ns/iter (+/- 1,348,490)
test nacl::virial_wolf               ... bench:   1,174,958 ns/iter (+/- 815)

test result: ok. 0 passed; 0 failed; 0 ignored; 8 measured

running 5 tests
test propane::cache_move_all_rigid_molecules ... bench:   2,008,655 ns/iter (+/- 5,572)
test propane::cache_move_particles           ... bench:     514,867 ns/iter (+/- 2,721)
test propane::energy                         ... bench:   2,196,663 ns/iter (+/- 21,501)
test propane::forces                         ... bench:   2,558,901 ns/iter (+/- 16,366)
test propane::virial                         ... bench:   2,739,046 ns/iter (+/- 2,081)

test result: ok. 0 passed; 0 failed; 0 ignored; 5 measured

running 10 tests
test water::cache_move_all_rigid_molecules_ewald ... bench:  13,102,282 ns/iter (+/- 13,717)
test water::cache_move_all_rigid_molecules_wolf  ... bench:  12,515,742 ns/iter (+/- 100,923)
test water::cache_move_particles_ewald           ... bench:   1,371,555 ns/iter (+/- 11,269)
test water::cache_move_particles_wolf            ... bench:     748,953 ns/iter (+/- 8,679)
test water::energy_ewald                         ... bench:   1,877,530 ns/iter (+/- 1,660)
test water::energy_wolf                          ... bench:   1,426,462 ns/iter (+/- 1,256)
test water::forces_ewald                         ... bench:  37,093,498 ns/iter (+/- 89,679)
test water::forces_wolf                          ... bench:   1,722,893 ns/iter (+/- 1,232)
test water::virial_ewald                         ... bench: 156,863,695 ns/iter (+/- 46,167)
test water::virial_wolf                          ... bench:   1,754,967 ns/iter (+/- 880)

test result: ok. 0 passed; 0 failed; 0 ignored; 10 measured

CPU: Intel(R) Xeon(R) CPU E5-2660 0 @ 2.20GHz

From what I see here the processor has 8 cores, so this kind of acceleration factor (12) is really encouraging. I don't really know what we can expect with hyperthreading to 16 cores, but I surely did not expect to go up to 12.
As I said I'm not really familiar with hyperthreading, what do you think @Luthaf ?

Yes, the CPU has 8 cores, 16 threads. I've never worked with hyperthreading before, so I don't know what to expect. Do your system have 2 cores with hyperthreading, or 4 real cores?

It has 4 real cores and 8 threads with hyperthreading. Actually before seeing the benchmarks on your machine I was convince we would never benefit from hyperthreading in our use case.
These results clearly prove me wrong :smile: .
What I suggest we do is be satisfied if we get a speedup factor up to the number of physical cores, and be extra happy when we get more. I'll try to check with my teachers to see what they have to say about it.

Did you fixed the number of threads to 4? I did not do anything, and it appears that rayon is using the number of reported cores (i.e. 16).

No I did not do anything specific.


revert "release: v8.0.0-beta.3"

This reverts commit ef11c9fbc912a8df202973068222951ff5c5d116.

We'll just skip beta 3.


drop Docker files, use cross

@homunkulus try

:hourglass: Trying commit ae587ca with merge ae587ca...

:sunny: Test successful - status-appveyor, status-travis
State: approved= try=True

@homunkulus try

:hourglass: Trying commit 0dcbdf5 with merge 0dcbdf5...

:broken_heart: Test failed - status-travis

@homunkulus try

:hourglass: Trying commit be02139 with merge be02139...

:broken_heart: Test failed - status-appveyor

:sunny: Test successful - status-appveyor, status-travis
State: approved= try=True

@homunkulus r+

:pushpin: Commit 1cd3f3e has been approved by japaric

:hourglass: Testing commit 1cd3f3e with merge 1cd3f3e...

:broken_heart: Test failed - status-appveyor

:sunny: Test successful - status-appveyor, status-travis
Approved by: japaric
Pushing 1cd3f3e7dc8084153c0ff6dd6e17a1e53846ddd2 to master...


API File Rename Silently Erases Existing File

API File Rename succeeds even if a file with the new name already exists. It just replaces the existing file. I think the call should fail if a file with the new name already exists.

This is definitely the right thing to do IMO.
However, I will check with David Given this is okay, because of the CPM/65 usage which this is designed to be compatible with.


Bug located in "variation_dict" parameter in "ipk.post.export_field_file"

Before submitting the issue

[X] I have searched among the existing issues
[X] I am using a Python virtual environment

Description of the bug
Dear Team,
We have discovered that the "ipk.post.export_field_file" gives an error when trying to use the variation_dict parameter.
We get the following error.

Please see the attached script and example project file (with results)
ExFieldField_Git.zip
From that you should be able to reproduce.
If there is an alternative way of extracting field file from big parametric sweep, that would also be very helpful. :-)
Best regards,
Kim
Steps To Reproduce
Replace "project_path" in ExportFieldFile.py and run script.
Which Operating System are you using?
Windows
Which Python version are you using?
3.9
Installed packages
ansi2html==1.8.0
ansys-pythonnet==3.1.0rc3
astunparse==1.6.3
attrs==23.1.0
Brotli==1.1.0
certifi==2023.7.22
cffi==1.15.1
charset-normalizer==3.2.0
click==8.1.7
click-plugins==1.1.1
cligj==0.7.2
clr-loader==0.2.6
colorama==0.4.6
contourpy==1.1.0
cov-core==1.15.0
coverage==7.3.0
cycler==0.11.0
dash==2.4.1
dash-core-components==2.0.0
dash-design-kit==1.6.7
dash-html-components==2.0.0
dash-snapshots==0.0.1
dash-table==5.0.0
defusedxml==0.7.1
dill==0.3.7
diskcache==5.6.3
docutils==0.20.1
et-xmlfile==1.1.0
Fiona==1.9.4.post1
Flask==2.2.5
Flask-Compress==1.14
fonttools==4.42.1
fpdf2==2.7.7
geopandas==0.13.2
gunicorn==20.0.4
idna==3.4
imageio==2.31.3
importlib-metadata==6.8.0
itsdangerous==2.1.2
Jinja2==3.1.2
jsonschema==4.21.1
jsonschema-specifications==2023.12.1
kiwisolver==1.4.5
MarkupSafe==2.1.3
matplotlib==3.8.0
multiprocess==0.70.15
nest-asyncio==1.5.7
networkx==3.1
nose2==0.13.0
numpy==1.26.0
openpyxl==3.1.2
osmnx==1.6.0
packaging==23.1
pages==0.3
pandas==2.1.1
piglet-templates==1.3.0
Pillow==10.0.0
platformdirs==3.10.0
plotly==5.16.1
plumbum==1.8.2
pooch==1.7.0
psutil==5.9.5
pyaedt==0.7.10
pycparser==2.21
PyMySQL==1.1.0
pyparsing==3.0.9
pyproj==3.6.0
python-dateutil==2.8.2
pythonnet==3.0.2
pytz==2023.3.post1
pyvista==0.42.2
pywin32==306
PyYAML==6.0.1
referencing==0.33.0
requests==2.31.0
retrying==1.3.4
rpds-py==0.17.1
rpyc==5.3.1
scikit-rf==0.29.0
scipy==1.11.2
scooby==0.7.2
shapely==2.0.1
six==1.16.0
SRTM.py==0.3.7
tenacity==8.2.3
tk==0.1.0
typing_extensions==4.7.1
tzdata==2023.3
urllib3==2.0.4
utm==0.7.0
vtk==9.2.6
Werkzeug==2.2.3
zipp==3.17.0

Hi @kinielsen, we were able to reproduce the bug and we are fixing it.
The fix should be available in the next release.
Thanks for feedback!
Giulia

Hi @gmalinve and @Samuelopez-ansys ,
Thank you very much for your ultra quick help! I will test the latest version soon!
Best regards,
Kim


ci: optimize log dump

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
The error like "log size is significantly large" is a little confusing. (It's a error, but look like a warning)

Checklist For Contributors

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
[ ] All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

[ ] I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

[ ] My PR DOES NOT contain user-facing changes.

Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.

Installation and deployment
Connector (sources & sinks)
SQL commands, functions, and operators
RisingWave cluster configuration changes
Other (please specify in the release note below)

Release note

(wait, but why do we have the 2MB restrictino

https://github.com/risingwavelabs/risingwave/pull/1716 Maybe it's just for preventing too many verbose logs.


Attachment preview does not update dynamically

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the app and login with user A
Open user B report
Open app in another device and login with user B
From user B, send user A any image attachment
From user A, open attachment sent by user B
From user B, send new attachment
Check in user A that new attachment is not visible in attachment preview, close the preview, open latest attachment
From user B, delete the latest attachment
Check in user A that we can still access that attachment

Expected Result:
App should dynamically update attachment preview
Actual Result:
App does not dynamically update attachment preview
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number:
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/452aeacf-a978-4494-a1e8-f830a84b4bb0
https://github.com/Expensify/App/assets/93399543/da1ecd77-3da8-4241-9c3b-419c4baa3338
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686896537390179
View all open jobs on GitHub

Check here

I'm been seeing a lot of bug reports about parts of the app not dynamically updating.  I'm going to continue to treat these individually as bugs, if they should be rolled into a project or tracking GH, please :thread:   cc
@Dhanashree Dattaram Sawant
, since it appears you're reporting a lot of 'em

No action the last time I posted so followed up
https://expensify.slack.com/archives/C01GTK53T8Q/p1687919663462329?thread_ts=1687471385.852519&cid=C01GTK53T8Q

Thanks for the comment on the Slack thread @dhanashree-sawant.

Can you review the 'update dynamically' bugs you've reported to see if there's a commonality and/or root cause so that we might be able to bunch some together?  If not we can manage them individually, it just takes more time/resources to do so.

Thanks for updating that thread @dhanashree-sawant.
Let's move this forward independently, I think it can be external, do you agree @narefyev91 ?

@mallenexpensify sure we can make it external - proposal from @dukenv0307 looks good to me https://github.com/Expensify/App/issues/21334#issuecomment-1603091795
🎀 👀 🎀 C+ reviewed - (any code discussion can be done in PR)

@jasperhuangg Any updates here? cc @mountiny

Gonna go ahead and assign @dukenv0307 based on C+ suggestion but all yours @jasperhuangg

@narefyev91 @mountiny what do you think about my comment above #21334 (comment)

Oh sorry - missed that - can you please raise this topic in slack in open-source channel - let's bring more people to get their thoughts

@dukenv0307 Looks like the Slack thread has consensus that it's fine for us to just close out the modal!

PR was merged!

@jasperhuangg @narefyev91 Any specific reason we decided to use Navigation.dismissModal? If I copy the attachment link and paste it directly in the addressbar (or deep link), what happens?
We added BlockingView in the PR, which now shows conflict, hence checking if there was any specific reason for dismissing?
cc - @ahmedGaber93  @marcochavezf

There seems to be this regression https://github.com/Expensify/App/issues/23896#issuecomment-1658348509 from this pr

We have 2 separator issues:

when navigate to delete image by deeplink app crash.
attachment preview not update dynamically when attachments list changed (it is a new feature more than issue).

And 3 options for deleted case.

dismiss the modal for both (maybe bad UX for deeplink).
show NotFound for both (maybe bad UX for dynamic update).
use dismiss modal for dynamic update, and NotFound for deeplink.
I think page == -1 is not this the accurate condition for dynamic update.
This is an idea for that.

useEffect(() => {
    const initialState = createInitialState(props);
    // compare initialState.attachments with attachments state.
    // and initialState.page with page state to determind is dynamic update or deeplink.
    if(dynamic update){
        // dismiss modal here not in createInitialState.
        // or show next/prev page
    }

    setPage(initialState.page);
    setAttachments(initialState.attachments);
    // eslint-disable-next-line react-hooks/exhaustive-deps
    }, [props.reportActions]);

can you know is it dynamic update or not from initialState(new state) and attachment && page(old state)? @dukenv0307

Hello everyone,
I'd like to kindly point out that the behavior addressed in this issue is actually intended and not a bug. We had made a deliberate decision not to update the attachment carousel in real-time while a user is interacting with it. This is especially crucial when an attachment is removed, as it could be disruptive if another user is currently viewing it.
For clarity, we had previously discussed and concurred that the carousel should remain unchanged while active. Any deletions should only be reflected after the carousel is closed.
For your reference:

My initial proposal which was agreed upon can be found here.
Additionally, @sobitneupane had raised a relevant question here, to which @cead22 and @JmillsExpensify confirmed our intended behavior regarding the carousel.

I understand the intention behind the recent changes, but given our prior discussions, it might be best to revert to the original behavior. Thank you for your understanding.

@kidroca is your main concern that the experience will be jarring to the user if they are viewing an attachment that gets deleted?
@dukenv0307 I believe that's currently the only action that will dynamically update the modal. If a new attachment is sent then the currently viewed attachment shouldn't change. Perhaps we should make it so that we don't dynamically dismiss the modal if an attachment is deleted?

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[x]  [@jasperhuangg] The PR that introduced the bug has been identified. Link to the PR:
[x]  [@jasperhuangg] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[x]  [@jasperhuangg] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ]  [@narefyev91 / @dukenv0307] Determine if we should create a regression test for this bug.
[ ]  [@narefyev91 / @dukenv0307] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ]  [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

This bug wasn't really directly caused by a PR, it just wasn't considered in the initial design. I think adding a regression test should be plenty.

bump @narefyev91, @dukenv0307 on the regression test!

Regression Tests
Case 1:
1- Open the app and login with user A and user B from different browsers.
2- Start chat between user A and user B.
3- From user A send an attachment in the chat.
4- From user B open the attachment in preview, and copy the URL.
5- From user A delete the attachment and Verify the user B attachment preview is dissmised.
6- Open the URL and Verify that the app displays 'Hmm its not here' page and doesn't crash.
Case 2:

The attachment modal should update dynamically if another user sends a new attachment

Login with user A
On another device, login with user B
From user B, send an attachment
From user A, click on the attachment to open attachment modal
From user B, send an attachment again
From user A, verify that the user can click on the arrow right button to see the newest attachment that is sent by user B

Case 3

The attachment modal should dismiss if another user deletes the attachment that is displaying

Login with user A
On another device, login with user B
From user Bm send an attachment
From user A, click on the attachment to open attachment modal
From user B, delete this attachment
From user A, verify that attachment modal closed

@jasperhuangg and/or @narefyev91 it looks like @dukenv0307 was assigned on  July 4

And the PR merged on July 28th.

Normally there would be a reduction in pay for the length of time, is that the case here or is there something I'm unaware of?

@mallenexpensify that is correct, there was some back and forth with the PR that delayed getting it out.

@dhanashree-sawant, can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01c9714d2d5e8197db
@dukenv0307 paid $500 via Upwork. (will post final payment breakdown once Dhanashree is paid)

@strepanier03  I'm off this week, can you please keep 👀 on this then I'll snag it back on Monday?  Thx (it's just paying Dhanashree then posting the payment format as the final post)

Thanks @mallenexpensify, I have accepted the offer.

I have paid @dhanashree-sawant via Upwork and closed the contract.

Looks like so far:

Bug Reporter - @dhanashree-sawant - $250 - Paid via Upwork
Contributor - @dukenv0307 - $500 - Paid via Upwork
C+ - @narefyev91 - $500 - to be paid via Manual Requests (I am pretty sure)

@mallenexpensify - Is that what you meant by "posting the payment format as the final post"??

Payment Summary

[x] Bug Reporter - @dhanashree-sawant - $250 - Paid via Upwork
[x] Contributor - @dukenv0307 - $500 - Paid via Upwork
[ ] C+ - @narefyev91 - $500 - to be paid via Manual Requests (I am pretty sure)

@narefyev91 - Have you submitted your Manual Request for payment? If so let me know and I'll assign over to Jason for payment.

@narefyev91 - Have you submitted your Manual Request for payment? If so let me know and I'll assign over to Jason for payment.

Hey! I'm from Callstack - no additional payments needed :-)

Thanks @strepanier03 , updated the above comment to
Payment Summary
Bug Reporter - @dhanashree-sawant - $250 - Paid via Upwork
Contributor - @dukenv0307 - $500 - Paid via Upwork
C+ - @narefyev91 is due $500 - he's with CallStack and paid outside of Upwork.

Thanks @narefyev91 for regression test steps, TestRail GH is here

https://github.com/Expensify/Expensify/issues/315684


Formatting in Table Of Contents makes it hard to recognize subheadings

Right now nested headings look like the following in the Table Of Contents:

I would like to propose the following css to indent subheadings:
#TableOfContents li {
    margin-top: 0.4rem;
    margin-bottom: 0.4rem;
}

#TableOfContents li li {
    margin-left: 1em;
}

With the applied styles:

I would be happy for any feedback on this!

Good idea! Can you submit a patch?

Sure! Where would be a place for the css? Right now I put it in assets/scss/override/_custom.scss

Propose here: https://github.com/bphenriques/explorer-hugo-theme/blob/940b0cd9a3e6e7a022ed6c746dc8eae24833b789/assets/scss/components/_menu-content.scss#L35


[XamarinProfiler-MAC]: Accessibility: Keyboard: MAS2.1.1: No rectangular focus is visible around the Graph of Roots & Cycles in Allocations Profiler.

Prerequisites

Install Xamarin Profiler.
Launch Visual Studio.
Create a project and build the solution.
Navigate to Run Menu Tab and Invoke it. Navigate to ""Start Profiling"" option and invoke it.
This will invokes ""Xamarin Profiler"" application.

Steps to Reproduce

Follow the pre-requisites to launch the xamarin profiler application.
Select the Available instruments to "Allocations" and invoke next button. This will invokes Common options window.
Navigate to "Start Profiling" button and invoke it. This will launch Allocations profiling page. Navigate to "Roots&Cycles" tab invoke it.
Navigate to "All roots" table rows, this will invoke the graph chart on right side. Navigate to Graph using keyboard.

Expected Behavior
Rectangular focus should be visible on Graph  of "Roots&Cycle".
Actual Behavior
There is no focus visible on Graph group.
After pressing tab from "All roots" table row , keyboard will be lost. Once user presses the down arrow, Graph element will gain the focus.
User Impact
User will not whether Graph group got focus or not.
Screenshots

Environment
macOS High Sierra OSX version: 10.13.4
Visual Studio for Mac Enterprise version: 7.5.2(build 40)
Xamarin Profiler version: 1.6.3-400

Log File

Please add the following tags to this bug:
A11yMAS
Accessibility
MAS2.1.1
Xamarin-Profiler-MAC
Wipro


babel-plugin-styled-components 1.10.1 breaks css prop macro

Environment

System:

OS: macOS 10.14.5
CPU: (8) x64 Intel(R) Core(TM) i7-4850HQ CPU @ 2.30GHz
Memory: 346.00 MB / 16.00 GB
Shell: 3.2.57 - /bin/bash

Binaries:

Node: 11.1.0 - /usr/local/bin/node
Yarn: 1.12.3 - /usr/local/bin/yarn
npm: 6.9.0 - /usr/local/bin/npm

npmPackages:

styled-components: ^4.3.0 => 4.3.1

Reproduction
https://github.com/jamesknelson/css-prop-bug-repro/commit/db8250b77c4d950b9bd1b88cece1da96ac8a78df
Steps to reproduce
Just create a new project with CRA, import css from styled-components/macro, use it, and the styles don't work.
You can test with this repo:
git clone git@github.com:jamesknelson/css-prop-bug-repro.git
cd css-prop-bug-repro

# yarn install will not work as there's no yarn lockfile
npm install

# this works.
npm start

# then update babel-plugin-styled-components from 1.10.0 -> 1.10.1
npm install --save<EMAIL_ADDRESS>
# styles disappear.
npm start

I've tried this with styled-components 4.2.0, 4.2.1 and 4.3.1. The problem seems to be unrelated to styled-components itself, and is only with babel-plugin-styled-components.
Expected Behavior
Styles for css props should work.
Actual Behavior
Styles for css props don't work.
Currently, this breaks all recent versions of styled-components, as unless you specifically install 1.10.0, it will default to 1.10.1.

I'm having trouble figuring out how to actually debug this. Since CRA hides all the babel stuff behind many layers of scripts I can't get access to any console logs etc that I put into the babel plugin itself.
My hunch is that moving the JSXAttribute visitor up into the Program traversal is what's causing the issue, but I'm not sure why since the macro supposedly runs all the visitors from the babel plugin starting at the root.

@probablyup Just tested your theory by manually moving the JSXAttribute visitor into the Program traversal within a working project's node_modules, and it caused the same issue.
Conversely, in a 1.10.1 project with SSR using universal-react-scripts, moving the JSXAttribute visitor out of the Program traversal and back up to the top level fixes the css prop, but breaks stable SSR again.

Hoping someone over in the macros repo will have an inkling: https://github.com/kentcdodds/babel-plugin-macros/issues/121

My gut feeling is that Program isn't being visited, because it's already being visited within babel-plugin macros.
I managed to fix the issue by modifying https://github.com/styled-components/styled-components/blob/master/packages/styled-components/src/macro/index.js#L32 to use @babel/traverse instead of program.traverse:
traverse(
    program.parent,
    babelPlugin({ types: t }).visitor,
    undefined,
    stateWithOpts,
  )

This seems to keep SSR stable, while also working with the macros.
Not sure how to add tests that it works given that it's pretty CRA specific, but if you're okay without tests, shall I submit a PR?

I think there are macro tests in the repo but yeah

Fixed in latest styled-components v4.x!


Can HttpInterceptor's shell intercept http request of plugin httpclient call?

Hello,
I use your awesome lib to integrate plugin in my Angular application.
But I need to use httpinterceptor for all of my api call, even if call is made by plugin (remote) (for oauth2-oidc).
Is it possible to make this just on shell (host)?
Regards
Damien Trouillet

If you share @angular/core/http it should be possible. In this case, you only have one instance of the HTTP_INTERCEPTORS token.