[Recognizer] Need a way to make multiple recognizer work together one after another

Use this query to search for the most popular feature requests.
Is your feature request related to a problem? Please describe.
To save money, I want to have one regex recognizer and one luis recognizer to work together. The user input will go through the regex recognizer first, and if could not resolve to an intent, it will go through the luis recognizer.
Need a solution for this case.
Describe the solution you'd like
Currently "Customer recognizer" runs multiple recognizers at the same time.

Add support to run recognizer one after another
Add a way to disable/enable recognizer per case (i.e. prompt interrupt with condition) at runtime

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

No plans to support this but you should be able to build a custom recognizer that fits your need.

No plans to support this but you should be able to build a custom recognizer that fits your need.

Thanks! Let me have a try~

It works~


ci is annoying

Every time a test on a PR or branch fails we get like 10000 e-mails, would it be good if we limit the e-mails to main? if possible.

I'm not experiencing this. What do the emails look like?

Maybe is only to the account that created the PR/branch? hopefully not all subscribers/maintainers are getting these every time...

Hmm...  in your notification settings, do you have anything set for "Customize email updates"? Or what about this setting?

Thanks for the tip!! I'm closing this issue.


Exporting dashboard 404's

With newer versions of wizzy when exporting alot of dashboards I seem to be getting alot more 404's.  I'm guessing this is still related to sqlite locking?
Grafana API response status code = 404
No error body from Grafana API.```

It is related to sqlite locking. I am making export sequential instead of parallel so that we atleast guarantee reliability.

I have made exports serial. Fixed in master. Feel free to open the issue if it still exists.

Wizzy 0.5.7 released. Plz check for these 404s in the new version.

Worked great


feat: Unit test execution for rust tests

We need to add functionality so users can use Kaizen to run unit tests and show the results. This will also help our agentic loop with actual execution feedback so that we can fix the test cases.

@MashyBasker were you trying to set the docker up for unit test?
btw would need your operating system details, seems like a mismatch is there!

Yes. I created a Github app, adding the Home URL and Webhook(HookDeck), configured the permissions and tried to deploy the API using the GITHUB_APP_KEY.pem file for authentication.
Here are my OS details:
NAME="Arch Linux"
PRETTY_NAME="Arch Linux"
VERSION="6.9.5-arch1-1"
ID=arch
BUILD_ID=rolling
ANSI_COLOR="38;2;23;147;209"
HOME_URL="https://archlinux.org/"
DOCUMENTATION_URL="https://wiki.archlinux.org/"
SUPPORT_URL="https://bbs.archlinux.org/"
BUG_REPORT_URL="https://gitlab.archlinux.org/groups/archlinux/-/issues"
PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/"
LOGO=archlinux-logo

@sauravpanda

I think for this, you dont need GitHub so it should be good, right?

Yeah. Do you think it might be caused because the REDIS_PASSWORD in .env is empty?
It's able to pull Redis now, which failed before. But the manifest mismatch error still persists.


functional: add new tests TestUnit{Submit,Load,Start}Replace

TestUnitSubmitReplace() tests whether a command "fleetctl submit --replace hello.service" works or not.
TestUnitLoadReplace() tests whether a command "fleetctl load --replace hello.service" works or not.
TestUnitStartReplace() tests whether a command "fleetctl start --replace hello.service" works or not.

This PR depends on #18.
/cc @tixxdz

All right. Jenkins job fails, because one of the new tests occasionally fails after running fleetctl destroy. I'm not sure why.

I fixed bugs in the functional tests. Used maxAttempts correctly, and fixed the logic error upon retrying fleetctl destroy.
Now functional tests are working, and Jenkins job succeeds.
 I'm thinking about how to refactor it.

Did refactoring for the entire tree. Functional tests are working well too.
@tixxdz if you think it's ok, can you merge this to your tree, to create a PR to the upstream?

@dongsupark ok just let me know when you add those "submit load and start many units" tests, I'll pull them on top. Thank you!

Close in favor of https://github.com/coreos/fleet/pull/1509


Present results from abundance of many stars

Any good ideas to how we can present the results from abundance analysis of more than 1 star.
Currently, we create a csv file (abundances.csv) which is nice, but it is cramped.
A tool like preprocess.py would be nice, but I don't know how we should present the data.

In commit  52846d6 I print the csv file in the end in a relative nice way. This might look better in the terminal than the GUI.
Still need suggestions for ways to present the this data.

We also could add an option for the user to select a specific element from the linelist.

Or rather specific elements. But if we have a line list with a lot of different elements, why not just calculate the abundance for all? The user can extract what she needs from abundances.csv easily.

OK. What about non-LTE corrections? We can talk with Elisa for that.

Good point. Maybe we can close this issue and open a new issue on non-LTE corrections.


merge from arlac77/npm-package-template-esm-only

README.md

docs(README): update from template

Codecov Report

Merging #627 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #627   +/-   ##
=======================================
  Coverage   89.46%   89.46%
=======================================
  Files           8        8
  Lines         560      560
  Branches       87       87
=======================================
  Hits          501      501
  Misses         56       56
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 804965c...a2c1df8. Read the comment docs.

:tada: This PR is included in version 7.5.6 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


⚡ Performance: Parallelize API calls when possible

Feature Request Checklist

[X] I have tried restarting my IDE and the issue persists.
[X] I have pulled the latest main branch of the repository.
[X] I have searched for related issues and found none that matched my issue.

Overview
Poking through src/content-script.ts, I think I spy a couple API requests that are made in series now but could be made in parallel:

// 2. Fetch the repository's default branch, to retrieve replies.yml from
// 3. Fetch the REST API's JSON description of the item

Those two API calls don't rely on data from each other. So 3 doesn't have to wait on 2. We could await Promise.all them or similar. Let's do that for a little performance boost! ⚡
Additional Info
Marking as blocked on #5 just in case that PR refactors a bunch of things.

Ehh, I'll just tackle this myself now 😄


Close with BackPressButton

how can i close FanMenu with onBackPressed ?

You'll have to handle this manually, just call animateOut or toggle onBackPressed.


add retry step?

Can I retry step? or continue if the maximum retry fail?

@raitucarp any tips on how you implemented this one?


Feature request: move ɵextractRoutesAndCreateRouteTree to public api

Command
serve, build
Description
Hi. We use ɵextractRoutesAndCreateRouteTree to build sitemap.xml without a hassle. Currently, this api is private and i don't think it will last long here. Is it possible to move it to public api?
Describe the solution you'd like
No response
Describe alternatives you've considered
No response

This is an intriguing way to leverage ɵextractRoutesAndCreateRouteTree. I can see the potential for exposing this information in different ways in the future, especially as the underlying APIs become more stable. However, it's important to remember that extractRoutesAndCreateRouteTree is highly private, and I anticipate changes in the upcoming version. Additionally, the return object consists of an internal data structure.
It's also worth mentioning that the APIs associated with extractRoutesAndCreateRouteTree are currently in developer preview. However, auto-generating a sitemap could be an interesting feature request.


Project: MSGraphAPICreateO365GroupWebApp

Project name
O365 Group Manager
Description
ASP.NET Core web application to manage O365 groups which have the ability to create a group with custom resource behavior options and standard CRUD groups and members
Repo URL
https://github.com/NagaDemon/MSGraphAPICreateO365GroupWebApp
Team members
NagaDemon

https://user-images.githubusercontent.com/21342115/225312333-8f3b4ba9-ffd7-49a5-b2e2-74d76f9a6be6.mp4
Sure!


[Storage] Oauth Support for File Service

TODO:

Write tests

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-storage-file-share


Update coola dependency

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (1271545) to head (b420d14).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #108   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           34        34
  Lines          764       764
  Branches        33        33
=========================================
  Hits           764       764

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Random MAC with native posix target

Is your enhancement proposal related to a problem? Please describe.
With configuration for native posix target:
CONFIG_ENTROPY_GENERATOR=y
CONFIG_ETH_NATIVE_POSIX_RANDOM_MAC=y
'Fake entropy native posix' driver is selected, resulting in random MAC config not working well (same MAC assigned all the time).
Describe the solution you'd like
Modify eth_native_posix.c:eth_iface_init not to use entropy driver, but system clock (k_cycle_get_32 or something similar)
Describe alternatives you've considered
Implement TRNG driver for x86 (e.g. when CONFIG_FAKE_ENTROPY_NATIVE_POSIX=n).

@TomekSleboda The native_posix entropy generator is pseudo-random. If you want different random values in different runs you need to provide it a different seed.
If you want to just feed a different seed automatically in each run you can do
zephyr.exe --seed=$RANDOM

Closing, as the request goes against the reproducible principle of the native_posix target, and there is a simple way of getting the same result on invocation.


Using the icon name for id/aria-labelledby has a high risk for duplicate ids

Hi, and sorry for the lengthy bug. :P
The id/aria-labelledby pattern used for the icon components can be useful for VoiceOver support (other screen readers should manage to read the <title> without it), but it’s a difficult technique because it requires unique ids and there’s a risk of duplicate ids in the document. So using the icon name only is a bit risky.

If this name is generic, e.g. menu, it may already be used in the page, and adding an element with this id before the “real” target using that id may break existing functionality (e.g. Skip to navigation might point to an icon and not to the menu somewhere else in the page, User name may point to an icon and not the relevant input, etc.).

If an icon is used several times (e.g. in a loop), the document will have duplicate ids and it’s unclear if aria-labelledby will work correctly in this case.

It might be safer to generate a unique id, for instance:
// only once at instantiation, not sure if that should be a computed property in Vue
const id = 'icon-' + iconName + '-' + Math.floor(Math.random() * 1000000) // e.g. "icon-arrow-764820"

Do you think this could be included in your examples in some way?
On a related topic, in my experience using a technical name (e.g. an icon id derived from a file name) is not satisfying alternative text: the icon name may be different from the meaning we’re trying to convey, and when we start localizing the site it’s even more unhelpful (e.g. a Spanish speaker would be lost with a button whose label is "looking-glass icon").
I’ve used two different solutions in the past:

Pass a different prop/parameter explicitly for the alt text (a prop named alt could make sense). Then in the icon component or template I only output the <title id="…">…</title> and aria-labelledby attribute if alt text is provided.
Or avoid alt text on <svg> icons altogether, and:

for "icon + visible label" patterns, do nothing;
for icon-only buttons and links, use … and <button aria-label="…">…</button>, which has less flaky support in screen readers.

Because of the technical difficulty and footgun of duplicate ids I tend to go with the second solution, but both are okay.

Hi and thanks for visiting,
I can get behind using the unique IDs but let me first talk to some people with vision impairments to see what they think of having numbers called out to them along with the title. I don't think I'd include that in every icon but it does sound like it would be good to have an example section for the use case you're talking about.
The second piece of this is addressed by the lang="en" that's on the icon- if the screenreader is translating to spanish, it will be translated.

For the numeric id, I was suggesting using it for the id and aria-labelledby attributes only, not as human-readable content. So, using a distinct computed property, the template fragment for that might be:
<svg … :aria-labelledby="labelId">
  <title :id="labelId" lang="en">{{iconName}} icon</title>
  …
</svg>

The second piece of this is addressed by the lang="en" that's on the icon- if the screenreader is translating to spanish, it will be translated.

I’m not sure. I don’t think screen readers that translate content are common, and if some have this feature I wonder if it works on the DOM and not only by translating the initial HTML. I’m more used to localized app where the application code itself inserts localized strings (contributed by humans) when rendering the HTML or DOM. Things like:
<Icon name="cross" :alt="i18n.t('close')" />


Open Dynamic and Scrubber fixes

This issue fixes various bugs when in DynamicMap open mode, ensuring that events stop when the cell is deleted and ensuring that the correct frame is accessed when individual callbacks fail and when frames are dropped out of the cache. Also allows non-integer fps values for widgets for infrequent polling.

Ready to merge once tests are passing.

Ok the tests are passing and the fixes look good. Merging.


Rename dashed files to camel case

If this plugin grows and you want to do testing, you'll need to consider renaming for proper Python imports.
Basically, dashes in module names are not supported.

Even consider renaming the repo for absolutely pathed imports.


[Feature] Improve Model add

As described on README we can add a type and a rule when creating models.
Would be nice to have two combobox with all available options for each type and rule, instead of a text field.
For flexibility in each combox a option other that will enable a input text.

Good one! Have been thinking about syntax validation but a combobox would even remove that necessity.

Yes, you can remove all syntax validation complexity :)

Add id as default for new model (with ability to remove it). Also I think timestamps should be checked as default.
When you are creating new model with id please use
$table->id();

🙂

@pawel-miczka Yeah, nice, working on it! Coming with 0.9.10.

I also found that there is no option to add bigInteger for column type (for ex. for foreign key) which is default for ids in Laravel.

Ah, good one yeah, I'll take that to 0.9.10 as well.

@pawel-miczka Waiting for the pipeline in develop to merge support for these:


Visual Redesign to improve UX

The current version is not designed for usability at all.

Do we need multi-language support?

No, the web interface is German because all users are German librarians


Would like to contribute

Hi, I would like to contribute (as well as learn along).
Can you please elaborate the "TO DO" list at
DIY-LAPTOP/SOFTWARE/A64-TERES/README.md
Thanks.

@ZeekHuge what are your skills? How do you see yourself contributing? Is there any specific area of the circuit/pcb design (or the computer in general) that you might be interested in improving? Perhaps (as you mentioned an interest in a "SOFTWARE" README) you may be more interested in the driver part of this project, right?

@felipesanches Yes. I am more interested in drivers and the kernel part. Though I would be really happy to help in the circuit part too (along with learning about it).
I am an undergraduate student with Electronics and Telecommunication as my major.
I have worked on Embedded systems and was a GSoC-2016 student under BeagleBoard.org. I worked on the project called BeagleScope . It involved developing support for PRUs and develop IIO drivers.
So, I would like to know if there are software gaps, bugs or requirements that I could help in ?

@ZeekHuge Cool! I participated in GSoC 3 times (once as a mentor) but never on a hardware-related project.
I did work for 5 months on a project called MOD Duo (https://moddevices.com/) which used an A20-SOM. I'm not sure if the final product still uses it or if they changed the CPU, since I do not work there anymore and the motherboard design (even though it was designed with KiCAD and hosted on a private github repo) was never made public, unfortunately.
During the work at the above-mentioned startup, I did patch a portion of the ALSA sound drivers on the linux-sunxi fork of the kernel. I think perhaps https://github.com/linux-sunxi is what is used for this diy-laptop as well? Not sure. I'm still learning about it myself.
I must let you know that I'm not a mantainer of this laptop project (nor affiliated to OLIMEX in any manner), but only an enthusiast as yourself.
happy hacking,
Felipe Sanches

A starting point for improving Linux support for the A64 SoC used in TERES-I is http://linux-sunxi.org/Category:Development

I'd like to mention one thing, which is - hopefully - not an issue. I'm not sure where to write about it, so I just make a short note here.
You have the LCD cable near the hinges. This made me think of the MSI s271 notebooks, which had a "built in flaw". It had the cable also near the hinges. Every time the lid was opened or closed, the cable moved back and forth. On EVERY notebook there were broken cables after a while (the cable contained several thinner cables and sometimes the one for the speakers broke, sometimes the one for the LCD).
Im just mentioning it, because it's good to think about these design flaws and avoid them. Hopefully it is not an issue on the Teres I.

I'm not at all the arbiter for this, but the most commonly-accepted practice is:

CONTRIBUTING

This document should be located at the root directory of the DIY-LAPTOP repository and describe the best-practices for everything to be contributed to the repo
As this repo contains both HARDWARE and SOFTWARE codebases, the CONTRIBUTING guide ought to link to other more-specific documentation located within each subdirectory
Regardless of experience, abiding by these guidelines should give a developer the proper knowledge to generate and commit reputable contributions

ISSUES

@macandchief Things like this are highly important design considerations.  I've personally owned 5+ devices that self-destructed this way - remember the RAZR flip phones?

ISSUE TAGS

A great tool for project managers to use is a leverage a good first issue tag on issues placed that are either trivial or require a limited scope of familiarity with the nature of the project

README

@ZeekHuge Expressing the direction and intent of a project at the highest levels is greatly appreciated.  It takes a decent chunk of time and planning to establish such project-management-level material, but external contributors may take this information and run with it - often contributing content that is within scope and merit to the overall project.

@jcstaudt I add you as collaborator to this repository

I constructed a CONTRIBUTING.md document at the root directory of this repository.
I will need some help from Olimex, particularly with the doc/web/dev_roadmap.md and doc/web/dev_wishlist.md files.  I'm new here, so it's not my call to say what is coming down the line or what is most needed.
@TsvetanUsunov et al, can you please review this CONTRIBUTING guide and let me know what you think?  Can we spend a little time developing a wishlist/roadmap?


Performance difference on windows compared to sqlite.exe from sqlite.org

Comment:
I noticed a significant performance difference when running a script using the conda windows build compared to the binaries available on sqlite.org.
The last statement in the script below takes about double the time: 31 seconds compared to 18 seconds.
Could there be a difference in the compilation parameters that explains this difference?
-- Create table for bboxes
CREATE TABLE bboxes (
  id INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL,
  minx FLOAT,
  maxx FLOAT,
  miny FLOAT,
  maxy FLOAT
);

-- Fill the table with 1 million bboxes
INSERT INTO bboxes(minx, maxx, miny, maxy)
  WITH RECURSIVE
    cnt(x) AS (
       SELECT 0
       UNION ALL
       SELECT x+10 FROM cnt
        LIMIT 1000
    )
  SELECT minx, maxx, miny, maxy
    FROM (SELECT x AS minx, x+10 AS maxx FROM cnt) x,
         (SELECT x AS miny, x+10 AS maxy FROM cnt) y;

-- Create and fill up rtree.
-- Takes +- 31 secs using conda sqlite.exe, +- 18 secs with version downloaded from sqlite.org
CREATE VIRTUAL TABLE bboxes_rtree USING rtree(id, minx, maxx, miny, maxy);
INSERT INTO bboxes_rtree
  SELECT id, minx, maxx, miny, maxy FROM bboxes;

Reference to https://github.com/OSGeo/gdal/issues/7614

Looking at https://github.com/conda-forge/sqlite-feedstock/blob/main/recipe/bld.bat , I don't see any /O2 option passed to "cl", so unless some magic happens, the Windows builds are not optimized.

On windows it now also takes 18 seconds...
Thanks!!!


Get the correct username from the page URL, rather than extracting it from HTML

That should be both more reliable, and stable (particularly when mastodon instances use custom themes, or a new mastodon version changes the HTML).
It also addresses https://github.com/bramus/mastodon-profile-redirect/issues/3: The reason this one isn't working, is because hachyderm doesn't always have the meta[property="profile:username"] element on the page.
I have left the previous mechanism to extract the username from the HTML in place, because it might be useful for instances that have changed the URL scheme (e.g. by removing the @ from the url) although I personally haven't seen any.

That actually was my first approach, but doesn’t work for instances that run on a subdomain.
For example: the profile URL for<EMAIL_ADDRESS>on their server is https://fediverse.zachleat.com/@zachleat. The instance runs on fedivers.zachleat.com which is a subdomain of zachleat.com. By parsing the data from the URL, their profile username would become<EMAIL_ADDRESS>which is wrong. It’s<EMAIL_ADDRESS>This value can be found in the meta tag (if present).
Maybe this step could be included, but as fallback? First try the meta tag, then fall back to other possible locations.

LOL, yes, funnily enough I run my own instance  on a subdomain, so should’ve definitely realised that, but I’ve set up an http redirect so it still works for me.
Will adjust the PR to do the checks the other way around: meta tag first, URL as fallback

I've updated that now 👍

Just thinking about this a bit more, I realised that the cleanest and most reliable way to get the source server url is probably to do a web finger request:

extract the handle from window.location as that’s probably the most reliable
do a request to the .well-known/webfinger url for the user and domain thus identified.
direct to the url you receive back.

i suspect that would be the most reliable, least hacky approach.
I might play around with that next week if I have some time.


"Persistent" audio output selection for integrated screens speakers

I have a Mac Mini connected to a LG monitor (in HDMI) with integrated speakers. The speakers are quite bad, but with eqMac, I can make them sound not too shabby.
The problem is that when I wake up the Mac from sleep, the Monitor is not available yet, and eqMac switches the output to the Mac Mini speaker which is even worse.
If eqMac could remember my output setting and switch back to it when it is available, it would be very nice...
Good luck with the v2 rewrite, hopefully it is ready soon!

This has been addressed by version 1.2 - closing issue


Cheat sheets link is not valid

From the main README.md, by clicking the Cheatsheets link, it gives 404.
The link is: https://github.com/bregman-arie/computer-networking/tree/cheatsheets/README.md

correct link should be: https://github.com/bregman-arie/computer-networking/blob/master/cheatsheets/README.md


string_input_producer num_epochs not working as expected

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): no
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Mac OSX 10.12.6
TensorFlow installed from (source or binary): source
TensorFlow version (use command below): 1.2.1
Python version: 3.6
Bazel version (if compiling from source):
CUDA/cuDNN version:
GPU model and memory:
Exact command to reproduce:

Describe the problem
Describe the problem clearly here. Be sure to convey here why it's a bug in TensorFlow or a feature request.
Reading a (csv) file with string_input_producer() / start_queue_runners() works up to a certain limit. Using tf.train.shuffle_batch(), only the first N lines of the file are read.
Also, num_epochs seems limited to a certain number (30 without batching, lower with batch).
Source code / logs
Simple script for reading a csv file / training a linear model. The code WORKS. But it does NOT respond to changes in num_epochs / the number of steps printed at the end is not what we expect to see.
csv file: (model: W=-1, b=1 , y=Wx+b)
2,-1
3,0
4,1
5,2
(repeated)
import tensorflow as tf

W = tf.Variable([.3], dtype=tf.float32)
b = tf.Variable([-.3], dtype=tf.float32)
x = tf.placeholder(tf.float32, name="x")
y = tf.placeholder(tf.float32)
linear_model = tf.add(W * x, b, name="model")
squared_deltas = tf.square(linear_model - y)
loss = tf.reduce_sum(squared_deltas)

train = tf.train.AdamOptimizer(1e-3).minimize(loss)

# reading input
filename_queue = tf.train.string_input_producer(["/tmp/input.csv"], num_epochs=100)
reader = tf.TextLineReader(skip_header_lines=0)
_, csv_row = reader.read(filename_queue)
record_defaults = [[0.], [0.]]
col_x, col_label = tf.decode_csv(csv_row, record_defaults=record_defaults)
features = tf.stack([col_x])

with tf.Session() as sess:
  sess.run(tf.local_variables_initializer())
  sess.run(tf.global_variables_initializer())
  coord = tf.train.Coordinator()
  threads = tf.train.start_queue_runners(coord=coord)
  n = 0
  while True:
    try:
      n += 1
      inp, lab = sess.run([features, col_label])
      sess.run(train, feed_dict={x:inp, y:lab})
    except tf.errors.OutOfRangeError:
      break
    finally:
      coord.request_stop()
  coord.join(threads)
  print(n)

with batch: adding those lines in reading input
batch_size = 20
min_after_dequeue = 10000
col_x, col_label = tf.decode_csv(csv_row, record_defaults=record_defaults)
capacity = 3 * min_after_dequeue + batch_size
x_batch, label_batch = tf.train.shuffle_batch(
    [col_x, col_label], batch_size=batch_size, capacity=capacity,
    min_after_dequeue=min_after_dequeue)

See this question on SO, seems that I stupidly ordered try/while in the wrong order, especially because of the finally part


How does one migrate notes from Tomboy into tomboy-ng?

I've looked through the issues and wiki and can't find any information on how I can migrate my notes from Tomboy into tomboy-ng. The Tomboy notes are stored as XML. I looked at TomboyTools but it only imports markdown or plain text. Tomboy can only export HTML.

Was simpler than I thought. In case anyone else wonders, you can simply copy your notes under %AppData%\Tomboy\notes to %AppData%\tomboy-ng/notes

Well solved JTC.
I have wondered if I should have a button that does automatically the copy you just did  ? Maybe ....
In fact, you can just point tomboy-ng to your Tomboy dir if you wish. tomboy-ng does not care where your notes are as long as it can find them.
Davo

I don't know if a button is necessary @davidbannon  but a comment about migration in the docs would help. I had falsely assumed tomboy-ng stored notes in a different format just because TomboyTools doesn't do XML.

OK, have added a sentence to the main wiki page.
TomboyTools is a more specialized, case by case thing, its used by a small number of people who have specific workflow needs.
Thanks for your feedback !
Davo


Extends tox.ini scope

I would like to use this application with Django 1.10 but it misses some kind of noinput parameter and interactively asks about removing stale state of my application. Any help appreciated on this work in progress (porting django_migration_testcase to Django 1.10) :)

Yup, I totally agree with this. I should probably also be testing against Django 1.11 and Python 3.6 too.
I'm happy to take a look at this - I suspect it won't require reworking too much, just tweaking the flags that get passed to the migrate command by the sound of it. At least, I hope so.

@MickaelBergem After some faffing about with Travis, I've merged a fix for Django 1.10 and 1.11.
It's on PyPI as version 0.0.11. Thanks for raising this, and let me know if you run into any problems.


cmd/compile: Internal compiler error "missing wrapper for "

What version of Go are you using (go version)?

go version go1.21rc2 linux/amd64

Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=''
GOARCH='amd64'
GOBIN=''
GOCACHE='/home/misha/.cache/go-build'
GOENV='/home/misha/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/home/misha/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/home/misha/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/home/misha/tectonic/_deps.linux-amd64/go-1.21rc2'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/home/misha/tectonic/_deps.linux-amd64/go-1.21rc2/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.21rc2'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='/home/misha/tmp/x/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build1654894307=/tmp/go-build -gno-record-gcc-switches'

What did you do?
$ go build ./...
./b/b.go:23:18: internal compiler error: missing wrapper for b.connContext

See https://github.com/misha-ridge/go-compiler-internal-error for the reproducer.
The error disappears if the files are moved into one package, so I can't provide go.dev/play link.
What did you expect to see?
The code compiles.
What did you see instead?
Internal compiler error

This appears to be already fixed on HEAD.  I confirmed that it fails with 1.21rc2.
CC @randall77 @mdempsky @cuonglm just in case.

Thanks. Will this be backported to 1.21 branch?

Thanks. Will this be backported to 1.21 branch?

It will be included in 1.21 branch, as 1.21 is not released yet, so there's nothing to be backported.


449 reorder

Fixes #449

This change is

if you let me know what's wrong, i'll fix it for the PR.

You need to resolve the merge conflicts on the README.md. I would also suggest rebasing as you are including commits from other PRs. See Resolve Merge Conflicts for instructions on how to do this.

It looks like this repo used dev as the main branch and not master?

Yes, that is standard for all the Dsc repos.

#502 - opened this PR instead as i didnt know how to just work from dev.
so i just started fresh from dev.


How to register?

There doesn't seem to be a place on the login page to register. I also can't figure out where in the filesystem to register. Please advise.

Sry, you have to use the Django admin framework. I need to incorporate an updated setup guide I wrote that tells you how to do this. Will try to get to it after work. For now, check out the Django cookie cutter documentation. You'll have to start by creating a superuser with a command like this:
sudo docker-compose -f local.yml run django python manage.py createsuperuser
Then you can login with those credentials

I use "sudo docker-compose -f local.yml run django python manage.py createsuperuser" to create a user 'admin'. With 'admin', I  login "http://localhost:8000/admin/" successfully, but failed to login the page "http://localhost:3000/". Do they share the same username & password ?
Thanks for your reply.


Update hashcode calculation in HashSet collection example

Update hashcode calculation in HashSet collection example
Summary
This example only works because there is a mistake and instead of string hashcode you take comparator object hash
Fixes #4291
Details
https://github.com/dotnet/docs/issues/4291

Please fix VB and C++ samples the same way.

@AntonLapounov I've already done that in #4295; I recommend that this PR be closed in favour of that one.

Thanks for contributing to the dotnet/docs repo. And especially thanks for noticing that the hash code computation in this example is nonsensical. In response to your PR, @bgrainger has submitted a more comprehensive PR in #4295. As a result, I'm going to close your PR. But again, thank you so much for raising this issue and submitting your PR.


Having a CodeUri field prevents successfully upload to s3, why?

I am experimenting the api_backend example. when I use the example and make the CodeUri a bucket in my account (serverless-bucket), then
// inside template.yaml
AWSTemplateFormatVersion: '2010-09-09'
Transform: AWS::Serverless-2016-10-31
Description: Simple CRUD webservice. State is stored in a SimpleTable (DynamoDB) resource.
Resources:
GetFunction:
Type: AWS::Serverless::Function
Properties:
Handler: index.get
Runtime: nodejs4.3
CodeUri: s3://serverless-bucket/api_backend.zip
Policies: AmazonDynamoDBReadOnlyAccess
Environment:
Variables:
TABLE_NAME: !Ref Table
Events:
GetResource:
Type: Api
Properties:
Path: /resource/{resourceId}
Method: get
....
First, with CodeUri --- asset won't upload
$aws cloudformation package --template-file template.yaml --output-template-file
new_template.yaml --s3-bucket serverless-bucket

Successfully packaged artifacts and wrote output template to file new_template.yaml.
Execute the following command to deploy the packaged template

(note that the above result meant that I did not upload the zip file to my s3 bucket)
Secondly, after removing CodeUri --- asset uploaded
So I deleted the line of CodeUri: s3://serverless-bucket/api_backend.zip, and do the packaging again
$aws cloudformation package --template-file template.yaml --output-template-file new_template.yaml --s3-bucket serverless-asset

Uploading to 5ca239eb4bae5394252d5565b6a5a9e9  1560 / 1560.0  (100.00%)
Successfully packaged artifacts and wrote output template to file new_template.yaml.
Execute the following command to deploy the packaged template
aws cloudformation deploy --template-file ./serverless/example_api_backend/new_template.yaml --stack-name

(note that the above result meant that I have successfully updated the code into my bucket, with the object name of 5ca239eb4bae5394252d5565b6a5a9e9)
My question is that I don't understand why CodeUri can't be specified in my template.yaml

@sanathkr could you please take a look at this issue?

@syang try pointing CodeUri to your local zip file (output of some build or just zip index.js and point Uri to local path to that zip, e.g. ./api-backend.zip), everything should work fine then


Plugin

Hi
How can i enable plugin google search? I've searched the wiki but did not find it.
if i enable the plugin and show error like this :
warn: [PluginManager] Failed to initialize plugin GoogleSearch.
Thanks

Hello, as you can see from here (as of right now I am not sure it is documented) https://github.com/crisbal/Telegram-Bot-Node/blob/es6/src/plugins/GoogleSearch.js#L23 you need to provide the Google API Key and the Google CX Key that you can get using Google API Console (https://console.cloud.google.com/?pli=1) in the Config.js file

Ok I just checked and it seems the issues is on our side. I will keep you updated when we fix the problem

By the way, @koodoxz do you have a complete log? Are there other lines explaining the error?

Hi
@CapacitorSet Here is the log when in Firstrun

GoogleSearch.js (Cannot find module 'this.google-search')
Wordgame.js (Cannot find module 'word-list')
YouTube.js (Cannot find module 'youtube-api')

and here are the full log
npm run bot

<EMAIL_ADDRESS>bot /home/Telegram-Bot-Node
node src/Bot.js

info: [Bot] Instance created.
node-telegram-bot-api deprecated Events new_chat_participant,left_chat_participant are deprecated. See the updated list of events: https://github.com/yagop/node-telegram-bot-api/blob/master/doc/usage.md#events src/PluginManager.js:35:17
warn: [PluginManager]  Error: Cannot find module 'this.google-search'
at Function.Module._resolveFilename (module.js:469:15)
at Function.Module._load (module.js:417:25)
at Module.require (module.js:497:17)
at require (internal/module.js:20:19)
at Object. (/home/Telegram-Bot-Node/src/plugins/GoogleSearch.js:2:22)
warn: [PluginManager] Failed to initialize plugin GoogleSearch.
warn: [PluginManager]  Error: Cannot find module 'youtube-api'
at Function.Module._resolveFilename (module.js:469:15)
at Function.Module._load (module.js:417:25)
at Module.require (module.js:497:17)
at require (internal/module.js:20:19)
at Object. (/home/Telegram-Bot-Node/src/plugins/YouTube.js:2:17)
warn: [PluginManager] Failed to initialize plugin YouTube.
warn: [PluginManager] Some plugins couldn't be loaded.
info: [Bot] Plugins loaded.
info: [Bot] Permissions configured.
info: [Bot] The bot is online!
^Cwarn: [Bot] Shutting down, reason: SIGINT received
info: [Bot] Stopping safely all the plugins...
info: [Bot] All plugins stopped correctly.

I pushed 544c09b, that should fix it. Can you git pull and try again?

Actually, I just pushed another in 1b2d1ca - you should try pulling once again, if you already did.

Hi @CapacitorSet
thank you for fast respon, i think still cant find module for google search, here is the log
warn: [PluginManager]  Error: Cannot find module 'google-search'
at Function.Module._resolveFilename (module.js:469:15)
at Function.Module._load (module.js:417:25)
at Module.require (module.js:497:17)
at require (internal/module.js:20:19)
at Object. (/home/eko/Telegram-Bot-Node/src/plugins/GoogleSearch.js:2:22)
warn: [PluginManager] Failed to initialize plugin GoogleSearch.

Oh, in that case, you'll just need to install it: npm install google-search.

Ok noted, let me try it, thanks

Hi
just try to running, but still found this error
info: [Bot] Plugins loaded.
info: [Bot] Permissions configured.
info: [Bot] The bot is online!
error: [Bot]  TypeError: Cannot read property 'sendMessage' of undefined
at /home/Telegram-Bot-Node/src/plugins/GoogleSearch.js:49:17
at IncomingMessage. (/home/Telegram-Bot-Node/node_modules/google-search/lib/google-search.js:64:9)
at emitNone (events.js:91:20)
at IncomingMessage.emit (events.js:185:7)
at endReadableNT (_stream_readable.js:974:12)
at _combinedTickCallback (internal/process/next_tick.js:80:11)
at process._tickCallback (internal/process/next_tick.js:104:9)
warn: [Bot] Shutting down, reason: Uncaught exception
info: [Bot] Stopping safely all the plugins...
info: [Bot] All plugins stopped correctly.

Hm. Try pulling and running it now?

Thanks for the quick respons
may i ask you again, how to define call command to google search and google image in bot?

Simply edit src/plugins/GoogleSearch.js and src/plugins/ImageSearch.js.
For example, at line 34 of GoogleSearch.js you will find if (command !== "google") return;, just change that command.

while i put help on bot, its show something like this
/help
Google Images search: Search for images on Google.
Google: Search on Google.
/help Google Images search
Google - Search on Google.
/google query
/help google
Google - Search on Google.
/google query
Edit :
found the script that you said before
thanks

Thank you for your report. I'm closing this issue as fixed.

one moment please
i found another error on youtube plugin, i think is the same error with google search
info: [Bot] Plugins loaded.
info: [Bot] Permissions configured.
info: [Bot] The bot is online!
error: [Bot]  TypeError: Cannot read property 'sendMessage' of undefined
at /home/Telegram-Bot-Node/src/plugins/YouTube.js:43:17
at Request._callback (/home/Telegram-Bot-Node/node_modules/google-auth-library/lib/transporters.js:106:7)
at Request.self.callback (/home/Telegram-Bot-Node/node_modules/google-auth-library/node_modules/request/request.js:187:22)
at emitTwo (events.js:106:13)
at Request.emit (events.js:191:7)
at Request. (/home/Telegram-Bot-Node/node_modules/google-auth-library/node_modules/request/request.js:1044:10)
at emitOne (events.js:96:13)
at Request.emit (events.js:188:7)
at IncomingMessage. (/home/Telegram-Bot-Node/node_modules/google-auth-library/node_modules/request/request.js:965:12)
at emitNone (events.js:91:20)
warn: [Bot] Shutting down, reason: Uncaught exception
info: [Bot] Stopping safely all the plugins...
info: [Bot] All plugins stopped correctly.

 I also fixed that.
I ran a quick check against the other plugins, there shouldn't be any more issues like that.

Well Noted, Thank you for the quick respons :1st_place_medal:

Hi i found error again on plugin youtube, should i paste here or i open new issue?

No way to tell without seeing the problem :)
If you think it's the same type of error, post on this issue; otherwise,
open a new issue.
Anyway, I'm going to bed now. It's 4 AM here in Italy, so it might be a
while before @crisbal or I can take a look.
Il 26/set/2017 04:02 AM, "koodoxz"<EMAIL_ADDRESS>ha scritto:

Hi i found error again on plugin youtube, should i paste here or i open
new issue?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/crisbal/Telegram-Bot-Node/issues/129#issuecomment-332064304,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AI21FUV9fiz0UpNP67L5CrmuU6EhtNf_ks5smFtDgaJpZM4PiVfa
.

ok, take your time, Have a good rest :1st_place_medal:

@koodoxz, do you have updates on the issue?

Hi @CapacitorSet sorry for late reply
here is the log when i try to find song on youtube with 32 characters including space
info: [Bot] Plugins loaded.
info: [Bot] Permissions configured.
info: [Bot] The bot is online!
error: [Bot] Unhandled rejection at Promise  Promise {
_bitField: 18087936,
_fulfillmentHandler0:
{ Error: ETELEGRAM: 400 Bad Request: can't parse entities in message text: Can't find end of the entity starting at byte offset 92
at BaseError (/home/Telegram-Bot-Node/node_modules/node-telegram-bot-api/src/errors.js:10:5)
at TelegramError (/home/Telegram-Bot-Node/node_modules/node-telegram-bot-api/src/errors.js:56:5)
at request.then.err (/home/Telegram-Bot-Node/node_modules/node-telegram-bot-api/src/telegram.js:213:15)
at tryCatcher (/home/Telegram-Bot-Node/node_modules/bluebird/js/release/util.js:16:23)
at Promise._settlePromiseFromHandler (/home/Telegram-Bot-Node/node_modules/bluebird/js/release/promise.js:512:31)
at Promise._settlePromise (/home/Telegram-Bot-Node/node_modules/bluebird/js/release/promise.js:569:18)
at Promise._settlePromise0 (/home/Telegram-Bot-Node/node_modules/bluebird/js/release/promise.js:614:10)
at Promise._settlePromises (/home/Telegram-Bot-Node/node_modules/bluebird/js/release/promise.js:693:18)
at Async._drainQueue (/home/Telegram-Bot-Node/node_modules/bluebird/js/release/async.js:133:16)
at Async._drainQueues (/home/Telegram-Bot-Node/node_modules/bluebird/js/release/async.js:143:10)
code: 'ETELEGRAM',
response:
IncomingMessage {
_readableState: [Object],
readable: false,
domain: null,
_events: [Object],
_eventsCount: 4,
_maxListeners: undefined,
socket: [Object],
connection: [Object],
httpVersionMajor: 1,
httpVersionMinor: 1,
httpVersion: '1.1',
complete: true,
headers: [Object],
rawHeaders: [Object],
trailers: {},
rawTrailers: [],
upgrade: false,
url: '',
method: null,
statusCode: 400,
statusMessage: 'Bad Request',
client: [Object],
_consuming: true,
_dumped: false,
req: [Object],
request: [Object],
toJSON: [Function: responseToJSON],
caseless: [Object],
read: [Function],
body: [Object] } },
_rejectionHandler0: undefined,
_promise0: undefined,
_receiver0: undefined,
_cancellationParent:
Promise {
_bitField: 16777216,
_fulfillmentHandler0:
{ Error: ETELEGRAM: 400 Bad Request: can't parse entities in message text: Can't find end of the entity starting at byte offset 92
at BaseError (/home/Telegram-Bot-Node/node_modules/node-telegram-bot-api/src/errors.js:10:5)
at TelegramError (/home/Telegram-Bot-Node/node_modules/node-telegram-bot-api/src/errors.js:56:5)
at request.then.err (/home/Telegram-Bot-Node/node_modules/node-telegram-bot-api/src/telegram.js:213:15)
at tryCatcher (/home/Telegram-Bot-Node/node_modules/bluebird/js/release/util.js:16:23)
at Promise._settlePromiseFromHandler (/home/Telegram-Bot-Node/node_modules/bluebird/js/release/promise.js:512:31)
at Promise._settlePromise (/home/Telegram-Bot-Node/node_modules/bluebird/js/release/promise.js:569:18)
at Promise._settlePromise0 (/home/Telegram-Bot-Node/node_modules/bluebird/js/release/promise.js:614:10)
at Promise._settlePromises (/home/Telegram-Bot-Node/node_modules/bluebird/js/release/promise.js:693:18)
at Async._drainQueue (/home/Telegram-Bot-Node/node_modules/bluebird/js/release/async.js:133:16)
at Async._drainQueues (/home/Telegram-Bot-Node/node_modules/bluebird/js/release/async.js:143:10) code: 'ETELEGRAM', response: [Object] },
_rejectionHandler0: [Function],
_promise0: undefined,
_receiver0: undefined,
_cancellationParent: undefined,
_branchesRemainingToCancel: 1,
_onCancelField: undefined } }  with reason  Error: ETELEGRAM: 400 Bad Request: can't parse entities in message text: Can't find end of the entity starting at byte offset 92
at BaseError (/home/Telegram-Bot-Node/node_modules/node-telegram-bot-api/src/errors.js:10:5)
at TelegramError (/home/Telegram-Bot-Node/node_modules/node-telegram-bot-api/src/errors.js:56:5)
at request.then.err (/home/Telegram-Bot-Node/node_modules/node-telegram-bot-api/src/telegram.js:213:15)
at tryCatcher (/home/Telegram-Bot-Node/node_modules/bluebird/js/release/util.js:16:23)
at Promise._settlePromiseFromHandler (/home/Telegram-Bot-Node/node_modules/bluebird/js/release/promise.js:512:31)
at Promise._settlePromise (/home/Telegram-Bot-Node/node_modules/bluebird/js/release/promise.js:569:18)
at Promise._settlePromise0 (/home/Telegram-Bot-Node/node_modules/bluebird/js/release/promise.js:614:10)
at Promise._settlePromises (/home/Telegram-Bot-Node/node_modules/bluebird/js/release/promise.js:693:18)
at Async._drainQueue (/home/Telegram-Bot-Node/node_modules/bluebird/js/release/async.js:133:16)
at Async._drainQueues (/home/Telegram-Bot-Node/node_modules/bluebird/js/release/async.js:143:10)

I think I got it: when the title contains ], Telegram complains because it thinks it's closing the Markdown link. However, I'll look at it tomorrow.
Can you please open a new issue? It's a different problem than the one discussed here.

ok let me open in new issue


HDFS-16122. Fix DistCpContext#toString()

JIRA: HDFS-16122

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
11m 59s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
30m 36s

trunk passed

+1 :green_heart:
compile
0m 34s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
0m 31s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
0m 28s

trunk passed

+1 :green_heart:
mvnsite
0m 37s

trunk passed

+1 :green_heart:
javadoc
0m 30s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 28s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
0m 52s

trunk passed

+1 :green_heart:
shadedclient
13m 52s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 26s

the patch passed

+1 :green_heart:
compile
0m 25s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
0m 25s

the patch passed

+1 :green_heart:
compile
0m 23s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
0m 23s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 16s

the patch passed

+1 :green_heart:
mvnsite
0m 26s

the patch passed

+1 :green_heart:
javadoc
0m 20s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 20s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
0m 47s

the patch passed

+1 :green_heart:
shadedclient
13m 24s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
21m  3s

hadoop-distcp in the patch passed.

+1 :green_heart:
asflicense
0m 37s

The patch does not generate ASF License warnings.

100m 33s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3191/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3191

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux e16777a7a74d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ecacdc318430956172b724e91675074e0ab7880b

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3191/1/testReport/

Max. process+thread count
547 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3191/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Thanks @ayushtkn for the review and merge.


Improve buggy Algolia Search

Describe the bug
The Algolia Search does not show page titles or sidebar labels in the search results, only the headings and key words in the results
To Reproduce
Steps to reproduce the behavior:

Open the search in the top right corner of any page or press 'command + K'
Type the title of a page or sidebar label into the search
See everything but what you typed in the results

Expected behavior
Article titles should be shown in the results for users who are searching for an article by name/topic.
Screenshots
First result is a heading in this Subnet Tutorial, instead of this page with the exact title (seen in sidebar).

Hasura has a working implementation:

Editting the Algolia crawler config, and I believe the issue is fixed.


Soft delete staging models

Are you a current Fivetran customer?
Yes

Kyle McNair, Product Expert, Datafold
What change(s) does this PR introduce?

This PR persists soft deleted records, rather than hard deleting records where is_deleted or _fivetran_deleted is true.
As described in this comment, this change will need corresponding updates to the transform package.
I'm opening this PR as a draft until a corresponding PR is ready for the transform package.
Did you update the CHANGELOG?

[ ] Yes

Does this PR introduce a breaking change?

[ ] Yes (please provide breaking change details below.)
[x] No  (please provide an explanation as to how the change is non-breaking below.)

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

[ ] Yes

Is this PR in response to a previously created Bug or Feature Request

[x] Yes, Issue[#87]
[ ] No

How did you test the PR changes?

[ ] Buildkite
[x] Local (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

[ ] BigQuery
[ ] Redshift
[x] Snowflake
[ ] Postgres
[ ] Databricks
[ ] Other (provide details below)

Provide an emoji that best describes your current mood

:face_with_spiral_eyes:
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

Happy Thursday @kylemcnair, this is awesome, thank you so much for creating this PR! I have also started working on this issue this sprint and have managed to make quite a bit of headway on the PRs for it as well. I noticed your emoji (😵💫) and I totally understand, HubSpot happens to be quite a large package! I would, however, love to continue working with you on these PRs and it looks like I might have taken some minor steps in addition to Jamie's game plan.
If you have any time, I welcome you to take a peak at the PRs I've created for this issue and would love to hear any feedback you may have! Here are the PRs:

Hubspot Source
Hubspot

Additionally, it'd be great to get a double check that these PRs are producing the data you're expecting. You can try the package by adding the below to your dbt project's packages.yml:
  - git: https://github.com/fivetran/dbt_hubspot.git
    revision: feature/include-deleted-records
    warn-unpinned: false

Please feel free to let me know if you have any questions!

Hey @fivetran-sheringuyen, glad you're already on this - apologies that I missed your existing work. I'd be super happy to help test out the new package, and close this PR. I'll hop over to those PRs and provide any feedback there.


[SIP-4][superset-client] add SupersetClient, refactor app

This PR implements SIP-4, replacing all JS ajax calls with a new SupersetClient that handles all async requests using fetch 🎉
It's a big PR due to the ajax refactoring, so here's an higher-altitude summary:
SupersetClient usage*
// appSetup.js
import SupersetClient from `@superset-ui/core`;

SupersetClient.configure(...clientConfig);
SupersetClient.init(); // CSRF auth, can also chain `.configure().init();

// anotherFile.js
import SupersetClient from `@superset-ui/core`;

SupersetClient.post(...requestConfig)
  .then(({ request, json }) => ...)
  .catch((error) => ...);

*this is currently in src/packages/core/src which will become @superset-ui/core
SupersetClient handles:

CSRF token authentication

it also queues requests in the case that another request is made before the token is received
it checks for a token before every request, an external app that uses this can detect this by catching errors, or explicitly checking SupersetClient.isAuthorized()

timeouts (not supported by default in fetch)
query aborts (also not supported by default in fetch, uses AbortController polyfill)
supports the following configuration options:

protocol = 'http'
host
headers
credentials = 'same-origin' (include for non-Superset apps)
mode = 'same-origin'  (cors for non-Superset apps)
timeout

supports gets and posts. I considered adding puts/deletes but no existing ajax calls of this type are currently made
a given request supports the following options, which met the need of every async call in the app:

url or endpoint
headers
body
timeout
signal (for aborting, from const { signal } = (new AbortController()))
for posts

postPayload (key values are added to a new FormData())
stringify whether to call JSON.stringify on postPayload values

New dependencies
It introduces the following new packages:

abortcontroller-polyfill
whatwg-fetch
fetch-mock for testing

How was this tested?

attempted to test success + failure of every endpoint that was refactored in the browser
updated broken / ajax-containing tests
(TODO) add SupersetClient tests

Next steps

finish todos
merge this PR, test in staging, fix any immediate bugs
move packages/core to superset-ui repo
update imports to pull from @superset-ui/core

TODO

[x] implement SupersetClient
[x] refactor all ajax calls to use SupersetClient / fetch
[x] refactor / fix all ajax-containing tests
[x] debug SQL lab polling
[x] remove unused SupersetClient methods like put and destroy
[x] refactor API
[ ] rebase
[ ] add SupersetClient tests
[ ] add API documentation to package readme
[ ] verify sqllab error links

@mistercrunch @kristw @conglei @graceguo-supercat @hughhhh @betodealmeida @michellethomas

Okay so there are some concerns that this PR is too large and so we're considering the following:

abandon this PR
create a PR in the superset-ui repo with just the SupersetClient package
merge then publish the package
create a series of smaller PRs for the ajax refactors, possibly adding integration tests to them as we go.


fix: missing unenv version in lockfile

https://github.com/cloudflare/workers-sdk/pull/7319 somehow broke the build.
Updated the lock file to fix.

Tests

[ ] TODO (before merge)
[ ] Tests included
[x] Tests not necessary because: fix build

E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)

[ ] I don't know
[x] Required
[ ] Not required because:

Public documentation

[ ] TODO (before merge)
[ ] Cloudflare docs PR(s):
[x] Documentation not necessary because:  fix build

Thanks Sunil!


Feature Request: Checkbox Group

We should implement a CheckboxGroup component to handle multiple checkbox selections. This component would  the state of multiple Checkboxs.
Core Functionality
The CheckboxGroup would manage an array of selected values internally

Child Checkbox.Root components would automatically integrate with their parent CheckboxGroup
Values would be added/removed from the group's value array when checkboxes are checked/unchecked
The group would handle proper ARIA attributes for accessibility

API Options
Option A
This feels a bit weird because the Group would end up wrapping the root if we added it to the Checkbox namespace:
<script>
	import { Checkbox } from 'bits-ui'
</script>

<Checkbox.Group
  values={['option1']}
  onValuesChange={(values) => console.log(values)}
>
  <Checkbox.Root value="option1">Option 1</Checkbox>
  <Checkbox.Root value="option2">Option 2</Checkbox>
  <Checkbox.Root value="option3">Option 3</Checkbox>
</Checkbox.Group>

Option B
Be the first component to violate the name-space API:
<script>
	import { Checkbox, CheckboxGroup } from 'bits-ui'
</script>

<CheckboxGroup
  values={['option1']}
  onValuesChange={(values) => console.log(values)}
>
  <Checkbox.Root value="option1">Option 1</Checkbox>
  <Checkbox.Root value="option2">Option 2</Checkbox>
  <Checkbox.Root value="option3">Option 3</Checkbox>
</CheckboxGroup>

This raises the question of if we want to drop the namespacing for components that have only a single component within their suite. On one hand, it feels appropriate, and on the other hand, by doing so, we eliminate the ability to introduce other ideas like Option A in the future without a break.
What type of pull request would this be?
New Feature
Provide relevant links or additional information.
No response

I personally like the "cleanliness" of dropping the namespacing, but I see the issue with it making future changes harder.
For option A, what about the following instead? CheckboxGroup.Item would basically be an alias for / to Checkbox.Root
<script>
	import { CheckboxGroup} from 'bits-ui'
</script>

<CheckboxGroup.Root
  values={['option1']}
  onValuesChange={(values) => console.log(values)}
>
  <CheckboxGroup.Item value="option1">Option 1</CheckboxGroup.Item>
  <CheckboxGroup.Item value="option2">Option 2</CheckboxGroup.Item>
  <CheckboxGroup.Item value="option3">Option 3</CheckboxGroup.Item>
</Checkbox.Group>

This could work @gurpreetatwal, but I imagine people are creating their own custom checkbox components, so I don't want to misrepresent the fact that they are the same exact thing.

Ah okay, that makes sense. I'd say to go to with option A for consistency unless you're planning on dropping the "namepsace" API in general (e.g. future breaking release may make Checkbox.Root just Checkbox)
Another alternative for option A would be to rename Checkbox.Root to Checkbox.Item (or Checkbox.Box, etc.) but leave Checkbox.Root as a deprecated alias until the next major


[operator] Deploy BackupBucket/DNSRecord extension resources

How to categorize this PR?

/area control-plane
/kind enhancement
What this PR does / why we need it:
Enhance the gardener-operator to deploy DNSRecords and BackupBucket for the virtual garden resource.
Which issue(s) this PR fixes:
Part of #9635
Special notes for your reviewer:
Revamping #9940
Release note:

Enhance the gardener-operator to deploy `DNSRecords` and `BackupBucket` for the virtual garden resource.
`DNSRecords` are only deployed if at least one provider is specified at `.spec.dns.providers` in the `Garden` resource. A `BackupBucket` is created if the `.spec.virtualCluster.etcd.backup` section is specified. An existing backup bucket on the infrastructure becomes automatically managed this way.

There is an incompatible change in the `Garden` (`gardens.operator.gardener.cloud`) custom resource, which needs to be fixed manually. The items in the fields `.spec.virtualCluster.dns.domains` and `.spec.runtimeCluster.ingress.domains` are not strings anymore, but objects with a field `name` and an optional field `provider`.  E.g. in `JSON` format, replace `"domains": ["domain1.example.com", "domain2.example.com"]` with `"domains": [{"name": "domain1.example.com"}, {"name": "domain2.example.com"}]`.
In case the `.spec.dns` section is set, additionally the `provider` field needs to be set for each domains item.

/test pull-gardener-e2e-kind-operator-seed

/assign

/retest

Adapt the release note and mention the breaking API change

@rfranzke

I still see L340 is unchanged. Isn't this preventing above use-case?

If the bucket name is set, it should be immutable. If it is not set, it must be remain unset. The first constraint is enforced by  kubebuilder:validation:XValidation:rule, the second by the validation in the webhook.

/test pull-gardener-e2e-kind-operator-seed

/test pull-gardener-e2e-kind-operator-seed

/retest

/test pull-gardener-integration

/retest

rebased to fix pull-gardener-e2e-kind-upgrade test

/retest

/test pull-gardener-integration

/retest


[SPARK-32401][SQL] Migrate function related commands to use UnresolvedFunc to resolve function identifier

What changes were proposed in this pull request?

This PR proposes to migrate the following function related commands to use UnresolvedFunc to resolve function identifier:

DROP FUNCTION
DESCRIBE FUNCTION
SHOW FUNCTIONS

DropFunctionStatement, DescribeFunctionStatement and ShowFunctionsStatement logical plans are replaced with DropFunction, DescribeFunction and ShowFunctions logical plans respectively, and each contains UnresolvedFunc as its child so that it can be resolved in Analyzer.
Why are the changes needed?

Migrating to the new resolution framework, which resolves UnresolvedFunc in Analyzer.
Does this PR introduce any user-facing change?

The message of exception thrown when a catalog is resolved to v2 has been merged to:
function is only supported in v1 catalog
Previously, it printed out the command used. E.g.,:
CREATE FUNCTION is only supported in v1 catalog
How was this patch tested?

Updated existing tests.

Test build #126377 has started for PR 29198 at commit 38756fc.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/30993/
Test PASSed.

Test build #126377 has finished for PR 29198 at commit 38756fc.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126377/
Test FAILed.

Test build #126511 has started for PR 29198 at commit 27f2fb1.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/31130/
Test PASSed.

Test build #126511 has finished for PR 29198 at commit 27f2fb1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126511/
Test PASSed.

Would it be better to briefly describe "the new resolution framework" so the reviewers can look at this quickly?

Updated.

The PR itself LGTM. @viirya the new framework is to resolve SQL objects (table, view, function, etc.) in the analyzer, not at runtime in RunnableCommand.run. See v2ResolutionPlans.scala.

Test build #126725 has started for PR 29198 at commit c662619.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/31348/
Test PASSed.

Test build #126725 has finished for PR 29198 at commit c662619.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126725/
Test PASSed.

thanks, merging to master!


Use NAPI instead of V8

This would allow users to install nvk without the need to download the SDK and compile the bindings. The need of installing Lunar's Vulkan runtime could also be removed by just shipping the runtime files with the binaries.
Edit: this branch contains all necessary conversions, nearly ready to be merged

@Reon90 NAPI conversions are landed into master, could you test your RT project if it's still working?
Just clone master and run your example, you don't have to do npm install, the bindings are now pre-compiled

@maierfelix yes it's working.

great, thank you!


Graph API Teams message update policyViolation fails on external messages

microsoft/microsoft-graph-client:
3.0,0:
Windows 11:
[ ] nodejs

version**: 16.13.2

[ ] browser

N/A:

[ ] typescript

N/A:

Is the bug related to documentation in

[ ] README.md
[ ] source code documentation
[ ] SDK API docs on https://docs.microsoft.com

Describe the bug
When using the Graph API for teams to set the policyViolation on messages this works perfectly on messages that originate in our tenancy, but when receiving a message from an external tenant via federation, the call fails with a 403 which means we can't use our API code to block profanity in Teams for example.
To Reproduce
Steps to reproduce the behavior:

Setup  an API to use Teams Graph Subscription for ChatMessage/TeamsMessage
On detecting inappropriate content, call the updateMessage api to set policyViolation

Expected behavior
The policyViolation is set on the message and blocked in Teams, insetead the API fails with a 403.
Screenshots
Additional context
I suspect this is because external messages live on the sending tenant where my code does not have permission to call the updateMessage endpoint, however we still want to be able to block inappropriate content in external messages to our users?

Apologies, issue raised in wrong project.


Incorrect Source-Span for lambda/LazyEval nodes

When I try to get the source span(in-order to get a string representation) for a lambda (Eg: a > b in CountIf(TestTable, a > b), The source context for the lambda  is 0-Length of formula. Is this by design?
In file IRTranslator.cs (Line 271):
args.Add(new  LazyEvalNode(context.GetIRContext(node), child));
The IRContext of the current node is passed in instead of the current arg ( var arg = node.Args.Children[i];). Passing in arg gives the corrext source span.

Do you want to submit a PR? Include a unit test - that helps identify the problem being fixed and verifies the behavior.

Sure ! Although I am still not sure about the intended behavior in this case.
Thank You ! This would be my first open-source PR.

The intended behavior is what you've identified, it should be based on the current arg. Good find!

Thank You ! Will work on a PR.


hprof parser and inspector

Inspector android application with memory dump, and parse the generated hprof file.

@TedaLIEz, do we have the capability to parse the memory leak from memory dump?

@TedaLIEz, do we have the capability to parse the memory leak from memory dump?
@taoran6 No, this doesn't cover the memory leak detection. To do so, we need to make our test framework be aware of Android UI components' lifecycle.

I think this function is useful, will we continue working on this? @TedaLIEz let me know if something is blocking this.


More idiomatic imports statements

Type of change

[x] Refactor
[ ] New feature
[ ] Bug fix
[ ] Optimization
[ ] Documentation Update

Description
More idiomatic imports statements:
Why is import xxx as yyy bad?
Using the from keyword to import the submodule is more concise and readable.
Checklist before requesting a review

[x] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.

Testing

Usual unit tests and integration tests

@bparees

/lgtm
/approve
is this something we can get our linter to enforce, if it's going to be a thing we care about?

/lgtm /approve
is this something we can get our linter to enforce, if it's going to be a thing we care about?

yes, I'll look at it tomorrow. There's a linter rule for it.


systray patch

tried to apply this patch: https://dwm.suckless.org/patches/systray/
but didnt apply can you add systray to your dwm build?

Duplicate of https://github.com/LukeSmithxyz/dwm/issues/34.


[dart2wasm] Skwasm unit tests in flutter engine broken on dart roll

https://dart-review.googlesource.com/c/sdk/+/323445 has broken the skwasm unit tests in the flutter engine, specifically test/ui/image_golden_test.dart. I am starting a revert now.
I haven't really isolated this down much, but to reproduce this problem, you can do the following:

Build the dart sdk on a version with the https://dart-review.googlesource.com/c/sdk/+/323445 change
Set the DART_SDK_DIR environment variable to point to the built dart-sdk directory
In the flutter engine repo:

cd into the flutter/lib/web_ui directory
gclient sync
./dev/felt build
./dev/felt test --renderer=skwasm --start-paused test/ui/image_golden_test.dart
Press enter a few times to start the unit tests

This should open a browser window and run the unit tests. On the toImage_rgba tests, there should be an exception.

This issue is resolved if https://dart-review.googlesource.com/c/sdk/+/323445 is reverted.

Per the CL, I'm guessing there are some callbacks with parameters that are either using int where the passed value is not an integer value, or a non-nullable static interop type where the passed value is either null or undefined. Once the CL is reverted, I'm happy to take a look and fix these tests.

This was fixed a while ago.


Rendering Layer when not nested in Source

The docs suggest that something like this should work with a Layer component not nested in a Source if you already have a Source with a defined ID elsewhere
<Layer
  sourceId={SOURCE_ID}
  style={{
    type: "line",
    paint: {
      "line-color": "hsl(100, 100%, 50%)",
      "line-width": 2,
    },
  }}
/>

However, to get it to work with no errors from Mapbox GL JS, I have to do the following:
<Layer
  style={{
    source: SOURCE_ID,
    type: "line",
    paint: {
      "line-color": "hsl(100, 100%, 50%)",
      "line-width": 2,
    },
  }}
/>

It looks like the sourceId prop is not actually used. I suggest changing this line to something like below. Also would need to make a note about precedence. Or remove sourceId prop and make the style prop be the only method to specify Source Id.
const sourceId: string = props.sourceId || props.style?.source || useSourceId();

Thanks for finding this.
I kept both options, sometimes it's just easier to provide the sourceID instead of providing it in the style object.
Should be fixed in the latest release (v1.11.3).

Agree that having both options is good, thanks!


Classname prefix 'arco-' is same as Arco Web would not conflict ?

[ ] I'm sure this does not appear in the issue list of the repository

Basic Info

Package Name And Version<EMAIL_ADDRESS>

Usually Arco Mobile & Arco PC would not be used at the same time. If so, you can use ContextProvider and change the prefixCls property, and change the less variable prefix through modifyVars in less options.


Sema: Register the extended type of a package-level extension so we don't warn on the import

The warnings on superfluously public/package imports has a hole where it could report a package import as not being used by package decls even if it provides a type extended by a package extension. This is caused by the exportability checker not being enabled for package decls, thus not triggering the usual logic registering this reference.
Address this issue by adding a check specifically for package extensions. We can remove this check once we have exportability checking for package decls.
rdar://126712864

@swift-ci Please smoke test

@swift-ci Please smoke test Windows


Save Specify Unity version, Adding numbers for duped name data,

I want to request a feature for ASGUI to be able to save the Specify Unity ver since copy pasting can be frustrating when have to open multiple of them
Furthermore many of the files im dealing with often having the same name so it is possible to add numbers after them when extracting since it'll overwrite each other

check allow duplicate under options

check allow duplicate under options

oh thanks, i didn't notice that
but how about saving last input unity ver ?

you need to clarify more about that ? does it reset between files ? or you talking about different games

you need to clarify more about that ? does it reset between files ? or you talking about different games

i mean it reset to blank when i open a new instances of ASGUI and i have to input the engine version again since im dealing with files that have stripped engine version

assuming it saved on some list and you can select it you still have to click on it every time it wont just automatically pick last version used


Setup Hearts

Restaurant Card component
Setup onlick function on the heart icon

Write ADD_FAVORITE mutation
Make sure that hearts on restaurants are also being updated
Write click handler

WHEN heart is clicked
THEN use mutation to add restaurants to users' favorite list
THEN update the color of the heart to indicate favorite

Separated hearts into separate components got hearts to update on click.


qmk header files

Dear @binarybottle
i send you two standard header files (should go under: qmk_firmware/quantum/keymap_extras) that i told you i would do. i have not made a pull request from qmk directly (i feel my repo is in total mass) maybe you would. These are just for aliasing and shifted chars lookup table while using sendstring in your qmk macros.
keymap_engram.h
sendstring_engram.h
i admit that i understand the function of these header files wrong at first as i am very new to programming keyboards and qmk. These above are infact standart aliasing headers. colemak, workman, dvorak have them and now engram.
Though you or @sunaku  may want to review and edit before a pull request.
i have also completed two other header for universal engram unicode layout, they partially work, though i have some issues to solve. i may need help soon for review. but as unicodes are too big and take up great portion of the memory of my keyboard, i have second thoughts about them. Here they are:
unicodes header
universal engram header
prototype plank keymap.c using universal engram header (comments are not modified in this file, sorry)
please take care.
caga

@caga -- Thank you!
@sunaku -- Would you be able to help review this?

I'm not familiar enough with QMK to review the PR. :sweat_smile:  However, the top level keymap_engram.h file looks good to me:

I would suggest changing the EN_ prefix to ENGRAM_ for clarity.  If 2-letter abbreviation is strictly necessary, perhaps NG_ would better phonetically represent the word "Engram" (because EN_ reads as "English" to me).

@caga -- I agree with @sunaku's suggestion regarding pre-pending with ENGRAM_ or something equally identifiable.  I also don't have experience with qmk, so how about you do a pull request and if it works for you, great! If it doesn't work for others, then perhaps we will get further suggestions or contributions...

Dear @binarybottle  , @sunaku
Defacto standart is to use 2-letter abbreviation, though it is not strict. But the more longer the more harder for people to use keycodes. i have made and will make also some other minor changes, and after testing i make pull request from qmk.
i am also about to finish preparing a 6 level engram layout (desingned in mind for a 47 keys planck build but infact it is general) on @sunaku 's code. :smile:  i may want a pull request after it finished soon too @binarybottle .
Thank you guys. See you. :v:

Linux 6 layer layout:
issue https://github.com/binarybottle/engram/issues/16


Remove configure option --max-api-stats which does not do anything.

The change was removed as part of cba8b22ad53e62a9a08443330c74f5ccbd3f3f6d

Cherry-picked to v9.0.x branch.


thnks

me sirvio, bien programado y buena estructura
10/10

Well you shouldn't open an issue for thanking me😂
Anyways I am closing this issue


Fix flakyness in TaskExecutionIntegrationTest

Ignore my OCD reformatting, the actual fix is the one-liner in the first commit. The real question is if not executing the finalizer task immediately after the finalized one is violating some unspoken convention we have or not. Ie. can other, independent tasks be executed between the two? Seems from our docs, that we don't make such a strong guarantee, but...

My two cents would be that the finalizer task should be called directly after the task it finalizes.

@bot-gradle test and merge

OK, I've already triggered a build for you.


Permission state not propagating to other controllers

I have difficulties when I update the permission condition. It works fine in the current controller, and mainAppCtrl (the grandparent); but it won't update in some other controllers. It will affect the views: the items to be shown when permission is enabled work fine in the controller that updates the permission, but not the rest.
I have been used your JSFiddle example, using .values to store the enabling conditions. Then I tried using a service to store the conditions globally (it did not work at all). I can use $rootScope, but I don't like using it for global variables.

You can check the project here: https://github.com/bloArribas/multirole
There's a lot of temporary, unfinished code. You can see that the myAppCtrl will not update the views according to the permission states. Even though the global variable hosted in a service does hold the right value.
Thanks for your support. It's a great library.


[doc] enhance documentation of Python CHIP controller

Problem
The Python CHIP controller documentation is not user-friendly.
Change overview

Create a tutorial-like documentation
Make commands list complete
Move documentation about advanced features to the dedicated page. The content in ADVANCED_USAGE.md file, was just copied from the original version.

Some todos:

Unify the name of the tool
Should we mention nRF Connect at all?
Is it okay to use "platform" mDNS version by default?
Should we have a different step 2 (git clone) in case of sdk-connectedhomeip repo?

Testing

Building on Ubuntu/RaspberryPi
Testing on nRF Connect platform

@LuDuda as none of us had any comments, I created PR and pushed your branch to upstream.


Add Slide Down Animation

Current Behaviour: The Home page directly appears after the preloader and there is no animation.
Video:
https://user-images.githubusercontent.com/78532081/153702092-e8417b82-495c-4d1d-8e5e-6cded2e31753.mov

Expected Behaviour: Add a slide-down Animation like this 👇🏻
Video:
https://user-images.githubusercontent.com/78532081/153702222-679edb24-43dc-40d2-bad4-5178eacba320.mov

Hey @skpandey885 , I would like to take up this issue under JWOC.

Hey @skpandey885 , I would like to take up this issue under JWOC.

Go ahead.

@Anosh21  Please check my comment on your PR. Reply ASAP

can I work on this issue under jwoc?

Hey can I work on this issue under JWOC?

can I work on this issue under jwoc?

go ahead


Migrate vl53lxx driver class member variable initialization to declarations, format whitespace and alphabetize/group/order var/method declarations

Describe problem solved by the proposed pull request
This PR migrates vl53lxx class member variable initialization to respective declarations, formats whitespace, and alphabetizes/organizes variable and method declarations in vl53lxx.cpp.
This PR is primarily copy/paste of the variable initialization values and method declarations along with whitespace formatting but also contains some standardization work in the return calls of vl53lxx_main.
This PR wraps up initial work to standardize the distance sensor driver classes so that future inheritance work can be undertaken.
Describe your preferred solution
Standardizing all of the distance sensor driver variable initialization, method ordering and general style will allow for future inheritance structure work to be performed on the distance sensor driver classes.
Describe possible alternatives
All of the distance sensor driver work could be accomplished in one massive PR, but breaking up work in each driver should minimize risk and reduce review effort.
Additional context
See #9279, #11853, #11857, #1858, #11859, #11891, #11892, #11893, #11894
Please let me know if you have any questions on this PR. Thanks!
-Mark

Do you have time test this on Pixhawk4 I2C A port, I think it's not working.
#11842

Hy @bys1123 , I do have time, but unfortunately I do not have hardware to test with.  I have a Sensordots Mappydot+ and functional driver, (https://sensordots.org/mappydot_plus), so I've spent some time combing through the vl53lxx driver and pushed up another commit to this PR with a bit more code cleanup.
If you might be willing, try out this PR and make sure to start your driver with vl53lxx start -a .  You can do this from the console after boot.  I'll post the same in your issue and we can try to make some progress there from the current master branch as well.

@mcsauder Thanks very much, but I realized this vl53lxx driver is only for vl53l0x, vl53l1x's registers addresses is very different with this one. Hope you can make a vl53l1x driver some time.

Thanks!

@bys1123 , I've made an attempt to create functionality for the vl531x sensor in the latest commit to this PR.  I appreciate any feedback from testing you can offer.

@mcsauder
Feedback:

Looks like the prefix in VL53L1x, lost an 'x'.
Yes, we need a better way choose the driver.
I'm checking these registers with '????'

@bys1123 , Thanks for your feedback!  I obtained/modified the VL53l1X register map from ST's vl53l1_register_map.h, which omits the 'x'... and I must admit, I never even noticed that the 'x' was missing! :}
Likewise, I obtained/modified the register map for the VL530X from ST's VL530X API, vl530x_device.h, which includes the 'x'...
We have a choice... match the ST api, or be self-consistent within the PX4 code base.  I am interested in advice!

@DanielePettenuzzo Do you have any idea how to add the vl53l1x's driver is the best?

Hi @bys1123 , Sorry that it wasn't an easy hack to get this driver to play nicely.  The hard coded values in the current driver do not have aliases in the ST API for that sensor and searching the web it appears that ST is not inclined to distribute a full register map for that device.  So, I've reverted this PR back to its' original intent and we can work on opening up a new PR to introduce the vl53l1x driver.
Thanks for making a quick attempt with me on the vl53l1x!

@mcsauder Do you think it's better call this driver "vl53l0x" instead of "vl53lxx" ?

@bys1123 , thanks. Yes, I do.  I'd like to propose that change when we submit a vl53l1x driver PR.  (I'm making progress on that implementation but am not at a point I can open a PR yet. :} )

I've tested this driver before you optimize it.
If this driver didn't start successfully. It will break down the progress that calling it. Such as if I didn't connect my vl53l0x, add "vl53lxx start" to rc.board_sensors, it will make autopilot start fail.
If use console to start it, that will make console stop work.
I'm not sure are your changes fix that?

@bys1123 , you are correct, my changes do not fix that yet... I will do some digging and see if I can correct that behavior in this driver.  Updates to follow! Thanks!

Hi @bys1123 ,
I have hardware and can test this now.  I see valid data coming through once the device address error was reverted.  Thanks for catching that!
Bench tests with this PR and PX4 master branch give expected results on the bench.
This PR:

Master:

@dagar and @bys1123 , bench testing of this PR after merging in the WQ changes shows the same (expected) results as illustrated above.

All bench testing looks good including the move to the general work queue and the additional refactoring I've accomplished recently, distances varied from approximately 15cm-30cm and results are accurate:

@bys and @dagar , is there anyone else in the world that can hardware validate this PR?

@mcsauder could you recommend something for the @PX4/testflights to pickup?

@mcsauder could you recommend something for the @PX4/testflights to pickup?

Hi @dagar , thanks.  Yes. This is the unit I am using for bench testing: https://www.robotshop.com/en/tof-range-finder-sensor-breakout-board-voltage-regulator-vl53l0x.html
If this PR is able to be accepted/rejected I am happy to proceed with the VL53L1X driver work creation I have in queue.  The VL53L1X sensor is a better sensor on all accounts, there are two easy choices for that sensor:

https://www.robotshop.com/en/tof-range-finder-sensor-breakout-board-voltage-regulator-vl53l1x.html
https://www.sparkfun.com/products/14722

I have the sparkfun VL53L1X sensor.
I almost have a flight test rig finished with this unit.  I will post flight results here when I complete the build.

@DanielePettenuzzo and @dagar, here is a flight log running this PR: https://review.px4.io/plot_app?log=0937ae19-5987-4970-a273-992e59c13d67
Here are the distance sensor readings from the same log:

I would like to finish off this PR before working on the vl53l1x implementation.  Would you like to see anything else from this PR?
Thanks for your feedback!

@DanielePettenuzzo and @dagar, here is a flight log running this PR: https://review.px4.io/plot_app?log=0937ae19-5987-4970-a273-992e59c13d67
Here are the distance sensor readings from the same log:

I would like to finish off this PR before working on the vl53l1x implementation. Would you like to see anything else from this PR?
Thanks for your feedback!

The distance sensor data in that log looks terrible. Sensor basically became useless after 0.7m?

The distance sensor data in that log looks terrible. Sensor basically became useless after 0.7m?

I do agree, however, this flight test was probably worst case; the flight test was over grass in idrect overhead (bright summer) sunlight.  However, the VL53L1 is a much, much better sensor than the VL53L0X.

The distance sensor data in that log looks terrible. Sensor basically became useless after 0.7m?

I do agree, however, this flight test was probably worst case; the flight test was over grass in direct overhead (bright summer) sunlight. However, the VL53L1 is a much, much better sensor than the VL53L0X.

Just double checking that it didn't get any worse.

Thanks @dagar!


[WIP] Make sure the ID minter handles Sierra records and nulls correctly

Last night, when I ran the ID minter for the first time on Sierra records, it kept throwing an exception:
scalikejdbc.TooManyRowsException: null

Digging into the logs, I found the following SQL query:
Executing SQL query = 'select i.CanonicalID as C1_on_i, i.ontologyType as o_on_i, i.MiroID as M_on_i, i.CalmAltRefNo as C2_on_i, i.SierraSystemNumber as S_on_i from identifiers.identifiers i where i.ontologyType = work and ( i.SierraSystemNumber = b3010658 or i.SierraSystemNumber is null)'

which returns every row in the database. Oops!
Let’s not do that.

I've written a test case which should reproduce the error (if this build doesn't fail, that's suspicious!), and then two of us should pair on fixing it, as SQL will undoubtedly be fiddly.

Closing in favour of #1266.


Fix: Terminal profile provider "flatpak-vscode.runtime-terminal-provider" already registered error

This is also a better approach as there is the error flatpak-vscode.runtime-terminal-provider not registered is replaced with more helpful error message

Could use a rebase


How to run the project offline?

To run this project, please refer to the documentation. You can also deploy the project using Docker.

To run this project, please refer to the documentation. You can also deploy the project using Docker.

Hello, I have deployed the project on docker on my server and run "python -u app.py --load "HuskyVQA_cuda:0,SegmentAnything_cuda:0,ImageOCRRecognition_cuda:0" --port 3456 -e", but I need openai key, may I ask if your project must need to run the code, is this computer capable of scientific Internet access? Can the project be deployed offline?


Removed unused imports

Codecov Report

Merging #237 (82fa5b4) into master (6aaf59a) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 82fa5b4 differs from pull request most recent head dc2f0ad. Consider uploading reports for the commit dc2f0ad to get more accurate results

@@           Coverage Diff           @@
##           master     #237   +/-   ##
=======================================
  Coverage   15.95%   15.95%
=======================================
  Files          16       16
  Lines        1736     1736
  Branches      321      321
=======================================
  Hits          277      277
  Misses       1459     1459

Impacted Files
Coverage Δ

contracts/yield/NoYield.sol
23.80% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6aaf59a...dc2f0ad. Read the comment docs.


Command \newopentypefeature not working

The command \newopentypefeature seems to have been broken in a recent update. I used it without problem last year (2016), but now, by way of example, get the error

! Undefined control sequence. \newopentypefeature ...efine_opentype_feature:nnn                                                    {#1}{#2}{#3} l.49 \newopentypefeature{Style}{MathGreek}{+mgrk}

when trying to define a style for mathematical Greek (which e.g. Junicode relies on to some extent).
The exact same error occurs under both XeLaTeX and LuaLaTeX, as well as with other OpenType features not defined by fontspec out-of-the-box (e.g. the example with localized forms in the manual on CTAN).
It seems to be quite possible to work around this using \newfontfeature instead, but it stills seems a relevant bug to report.

Oh, a complete oversight! Apologies and thanks for the bug report.


The ksonnet guide and related links need some fixing up

Fix the broken anchor link in the getting-started guide:
https://www.kubeflow.org/docs/started/getting-started/#install-via-ksonnet

Fix the broken anchor link in the requirements guide:
https://www.kubeflow.org/docs/guides/requirements/#why-kubeflow-uses-ksonnet

Add more context about ksonnet functionality and installation in the component page:
https://www.kubeflow.org/docs/guides/components/ksonnet/

Also on the ksonnet page, add a link to the upgrade guide:
https://www.kubeflow.org/docs/guides/upgrade/

At the end of the Troubleshooting page:
https://www.kubeflow.org/docs/guides/troubleshooting/
We should link to the ksonnet guide explicitly rather than to here:
https://www.kubeflow.org/docs/guides/

/assign

/close


Run integration tests against Maistra/istio

Integration tests for both maistra-1.11 and maistra-1.22 branches now pass on prow!


Expanded docs for generate_inputs

This expands on the API documentation for generate_inputs and adds an example to the docstring. It would probably be good to replicate this somewhere more visible in the docs, but this at least adds a bit of detail somewhere.

THanks, this looks good to me!

Feel free to merge when ready


Use posixpath.relpath to preserve '/' in target files (fixes #46)

It's important to preserve '/' before resolving target files in the DAG.
Alternatively, Dag.file2jobs could replace them back to /, or one could improve OutputIndex to match with different os separators.

Just a suggestion. Could you add (or point to an existing test) which triggers this on Windows?

I am not sure this will do the right thing on windows:

I just confirmed in a virtual machine, that this is thought to simplistically. Will close.
What exactly is the reasoning behind allowing non-relative paths in the first place?

Just a suggestion. Could you add (or point to an existing test) which triggers this on Windows?

Since you were able to make the tests work on windows in your PR and @fneum confirmed that even on your branch, the target file path is affected, it means there is no test atm covering this case.
The simple example in #46 would be a good addition, but I won't take it, sorry.


Unify '_implicit_environ' handling

There is a lot of overlap between datastore._implicit_environ and storage._implicit_environ.  We should factor that out, especially before implementing yet another version in pubsub.

I like it. Was trying to move gradually towards this while building out the implicit functionality into storage.
The hardest thing to factor out is the dependence on the local concepts of Connection and _DefaultsContainer.

Here's my notional take on a unification plan;

[ ] Add gcloud.helpers.get_scoped_connection(), which takes the connection class and a scopes list as arguments;  make each gcloud.*._implicit_environ.get_connection delegate to that helper (e.g., via functools.partial).
[ ] Move the "project detection" logic from gcloud.storage._implicit_environ into gcloud.helpers.
[ ] Consider how 'project' and 'dataset_id' should be related (e.g., does an app running on AppEngine / GCE use the same logic to determine its project ID for storage / pubsub purposes?)
[ ] Move the _DefaultsContainer up into gcloud.helpers, and make it generic;  instantiate it (subclassing only if really necessary) in each gcloud.*._implicit_environ.

@dhermes WDYT?

I don't see _DefaultsContainer able to be generalized due to the dependence on package specific functions for lazy-loading.
The rest seems great.
RE: Project ID vs. App Engine App ID. We should ask someone with more knowledge of the current state of things. I think they are the same, but could be wrong.
App Engine apps also have a default bucket created for them: <app-id>.appspot.com (bucket names with periods can't usually be created)

Re: _DefaultsContainer:  I (now) agree. When I moved the project stuff up into gcloud._helpers, I split apart the _DefaultsContainer class in gcloud.storage._implicit_environ:  each modules version knows only about the attributes relevant to its own functions.

@tseaver What's the status on this?

I think that we are good, here:  the default project stuff is shared, as is the repeated connection stuff (via get_scoped_connection).


Unable to select a data source in the plugin UI

After a recent update of the plugin, I get the notification bubble prompting me to choose a data source, which takes me to this window:

However, clicking anywhere in the list does... absolutely nothing. I can't tick any of the boxes, or order/sort any of the columns. I can resize them, but that's the only interaction I can see to do with the window.
There's no errors or beeps — just appears to be totally non-responsive. I've tried invalidating caches + restarting, but it makes no difference.
(This issue aside, thanks for a great plugin!)

Hey, I see in the screenshot "Filter data sources" checkbox is disabled. The table should become interactive once you enable that.

@ekvedaras Thanks for the speedy reply... I'd tried that before, but it didn't work. However, I just tried again now and realised it does work, but not when you click the checkboxes themselves — you have to click the label with the database name before the box will tick.
Thanks!

Yeah I've noticed this before but I thought it was my corrupt test data 🤔 I will look into those checkboxes why they sometimes do not function properly when clicked directly.