Ability to override kicad-unstable version

I'm trying to override the commit used for kicad unstable without redefining the entire kicad build expression. I attempted to do this via an overlay, like:
final: prev:

{
  kicad-unstable = (prev.kicad-unstable.override {}).overrideAttrs (old: {
    version = "2020-10-08";

    src = prev.fetchFromGitLab {
      group = "kicad";
      owner = "code";
      repo = "kicad";
      rev = "fd22fe8e374ce71d57e9f683ba996651aa69fa4e";
      sha256 = "sha256-F8qugru/jU3DgZSpQXQhRGNFSk0ybFRkpyWb7HAGBdc=";
    };
  });
}

But, this still uses the version specified in versions.nix. The reason seems to be because of this line and surrounding context. Basically, the build expression is mostly taken from base.nix (this inherits the version info from versions.nix) and then the binaries are wrapped. Long story short, I don't see any way to override the commit used without overriding a fair number of attributes.
I could create a PR updating the unstable version in versions.nix, but this means that I can't use an overlay while I wait for the PR. More importantly though, this doesn't help me if I want to use a version that isn't the latest version.
@evils is there a way that makes sense to you to change this build expression such that a specific kicad version can be used with the above overlay?

 Maybe you should write a PR that will make versions.nix export a function, that takes a srcs ? { i18n = {}; symbols = {}; ...} as a parameter, and that parameter is then used to generate the final return argument? If the relevant attribute (say i18n) is not set, a default is chosen, and if not, the provided is returned. Also, make it a real src - what fetchFromGitHub is called.
I've incorporated a somewhat similar approach here:

https://github.com/doronbehar/nixpkgs/blob/24f9480eed1b9111639c23ec1fef15656799fea3/pkgs/applications/radio/gnuradio/shared.nix#L8-L14
https://github.com/doronbehar/nixpkgs/blob/24f9480eed1b9111639c23ec1fef15656799fea3/pkgs/applications/radio/gnuradio/default.nix#L184-L202

@doronbehar I like that approach. Thanks for the insight. I ended up going with a "dummer" solution (see PR). I wasn't too eager to mess with version.nix, because that would mean changes to update.sh. The downside of this more limited approach is that I think it means if you want to configure kicad-unstable, you have to override the whole attribute set for it (libraries included).

Needs rebase.

with #100066 merged, can this issue not be closed?

with #100066 merged, can this issue not be closed?

and to answer the question above,
if you want to change the version of kicad you use, change versions.nix, or the attribute set it returns

and to answer the question above,
if you want to change the version of kicad you use, change versions.nix, or the attribute set it returns

this may be a redundant statement at this point
but if you want to change where the package gets the source code, you need to override kicad.base.src or kicad.libraries.[library you want to change].src

this may be a redundant statement at this point
but if you want to change where the package gets the source code, you need to override kicad.base.src or kicad.libraries.[library you want to change].src


Control keys don't work in Morphic World

The usual control keys, e.g. Ctrl-A selects all text, aren't working in a Morphic World opened from the headless VM.
Base Image: Build information: Pharo-7.0.3+build.158.sha.0903ade8a6c96633f07e0a7f1baa9a5d48cfdf55 (64 Bit)
unix linux-gnu x86_64
Bloc: 6ad12c9
CoInterpreter VMMaker.oscog-eem.2537 uuid: 0518f049-7c3c-4dfa-8e2d-04e2cf2eee40 Jul 24 2019
StackToRegisterMappingCogit VMMaker.oscog-eem.2536 uuid: b62bbbd8-9091-4f4a-a64e-c2d09f0863e5 Jul 24 2019
VM:<PHONE_NUMBER>41 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Date: Wed Jul 24 13:41:50 2019 CommitHash: 478f6546 Plugins:<PHONE_NUMBER>41 https://github.com/OpenSmalltalk/opensmalltalk-vm.git

This works now on Mac. @akgrant43 could you please check on Linux?

Still not working on linux (15 Aug 2019  13:00)

duplicate of https://github.com/feenkcom/gtoolkit/issues/579


updating service->cloud

this does not update the pulumi service provider, as that name has not yet changed
see also
https://github.com/pulumi/pulumi-hugo/pull/2666
https://github.com/pulumi/examples/pull/1412
https://github.com/pulumi/pulumi/pull/12630

General question about these changes: should we be using "the Pulumi Cloud" instead of just "Pulumi Cloud"? If we are going to capitalize (as a proper noun/product name), the latter seems like the correct usage to me.

@scottslowe

General question about these changes: should we be using "the Pulumi Cloud" instead of just "Pulumi Cloud"? If we are going to capitalize (as a proper noun/product name), the latter seems like the correct usage to me.

no standard has been established yet, so i wont be taking on standardizing it in this work. but if you'd like to take that on, pls do!

@susanev

no standard has been established yet, so i wont be taking on standardizing it in this work

I guess I'm a bit confused as to why we would make this change (from "Service" to "Cloud") and not address the correct/desired usage of our product name at the same time? Seems like more work to have to come back and do this all over again (particularly when you have two reviewers providing the same feedback), but I'll defer to you.


Updated README.md file

Describe your changes
Added link to CONTRIBUTING.md file in a line in README.

@dwertent Please review this PR.


[Bug]: anyQuote nested quotes edge case, only with inner

Bug Description
When there are nested quotes, having the cursor on the first character of a nested quote and doing .anyQuote("inner"), the wrong quote gets matched (the outer nested quote).
This only concerns .anyQuote("inner"), with exact same cursor position and .anyQuote("outer"), it matches as expected (the inner nested quote).
The same happens when the cursor is on the opening quote of an inner nested quote, but I'm not 100% sure of the expected behavior in that case. .anyQuote("outer") from that position matches the inner nested quote however and it feels correct to me.
Reproduction & Sample Text
Before
"'foo' and ´bar´"
  ^

After diq
""
 ^

Expected
"'' and `bar`"
  ^

Before
"'foo' and ´bar´"
            ^

After diq
""
 ^

Expected
"'foo' and ``"
            ^

neovim version
$ nvim --version
NVIM v0.10.1
Build type: Release
LuaJIT 2.1.1720049189
Run "nvim -V1 -v" for more info

"'foo' and ´bar´"
  ^

This case has been fixed in one of the latest commits. (There was a remaining edge case if you are on the ending border of a nested text object, which I just fixed.)

The same happens when the cursor is on the opening quote of an inner nested quote, but I'm not 100% sure of the expected behavior in that case. .anyQuote("outer") from that position matches the inner nested quote however and it feels correct to me.

Yeah, borders of nested textobjs are simply a bit tricky. With inner, only foo and 'foo' and bar are the textobjects, and when you are exactly on the first ', you're technically standing on the inner ", but in front of the inner '. And in vim it's the idiomatic behavior that the text object you are standing on is always prioritized over text objects coming after the cursor (and this plugin tries to follow this behavior).
With outer, the objects are 'foo' and "'foo' and bar", and if you are on the first ', you are standing on two objects. In this case, the idiomatic vim behavior is to select the "more inner" object, so 'foo' gets selected.

"'foo' and ´bar´"
            ^

This one does not work because it's forward-ticks (´) instead of backticks (`), and the plugin only considers backticks (as forward-ticks are, to my knowledge, not used in programming).
If you meant to use backticks and just used forward-ticks to get it working in Markdown, then this is the same as the first case, which has been fixed in one of the later commits.

btw, you can write backticks ` in markdown inline code like this:
this in raw markdown: `` ` ``
results in this in rendered markdown: `

Thanks, it works and the explanation helps too
Haha, I'm quite confused where my forward-ticks came from, the example was meant to have backticks in each case

btw, you can write backticks ` in markdown inline code like this...

Good to know, thanks!

Hmm, I notice problems however now with .anyQuote("outer")
Examples:
"'foo' and `bar`"
        ^

"'foo' and `bar`"
^

"'foo' and `bar`"
   ^

After daq, in all of the above the result is:
"
^

I wonder if this was introduced with 9905d24, or if it's something I hadn't noticed before?

yeah, I looked into it, and all those issues were a consequence of my (admittedly hacky) method to detect whether a quote is escaped or not without having lookbehinds in lua's regex.
Turns out, lua has something called frontier pattern, that can be used for a (small) lookbehind. And using that method, I think all the off-by-one issues you have noticed should be fixed now 😮💨

Great, others resolved, except for:

... leaves extra spaces compared to Vim's da"/da'/da`

"foo" 'bar' `baz`
        ^

daq

"foo"  `baz`
      ^

(expected one less space)

Yeah, that one is not a bug, but just how the plugin works.
I'm not too sure about removing one of the surrounding spaces, since for consistency, I'd have to remove those spaces for either for all for none of the text objects by this plugin. And for a few, removing the spaces does not work well with how the textobj is designed. So making a decision is not straightforward.
(vim itself is also not entirely consistent in this regard either, iirc.)
I'll have to think for a bit about that one.


Included backend information in readme

Since the idea was to include this repo as a sample notebook for openEO, thus, backend information was added in the readme to let users know ahead.
There are a couple of collections and processes available/not available in the other.

This might be confusing for users, as they might think that an example only works that backend. Do we know of certain notebooks that can't run on all backends?
Perhaps we could add a note when an example does not work on a backend, or list all the backends where an example works.

Not yet ideal:
'VITO' is not an official backend name. There's only CDSE or openEO platform, and the Terrascope backend which is part of both of these federations.
We should avoid listing only one backend, most of these notebooks should work on both CDSE and openEO platform, and should thus be listed as such.
Another option is perhaps to explicitly warn for backend specific notebooks, rather than having to provide potentially ever increasing lists of backends where it should work?

Ahh, ok, in that case, I can close this PR.
And as for a couple of notebooks with temperature layers. I can include that too and request for other such as "World cereal" and "GFM"


Fix the update. It must be launched with the steam user.

What does this fix exactly? What's the difference?

We install the game with the steam user, so we must update it with the same user. If you don't use the same user you can see some warnings when steamcmd is running.


Enable/Disable Motion detection for Foscam Cameras

Description:
Enable_Motion_Detection and Disable_Motion_Detection were services added to the Camera component in 0.48.1.
Support was added for Arlo cameras in one of the earlier releases.  Now adding support for Foscam cameras to enable/disable motion detection.
Based on comments from @balloob, I have changed the code to use a foscam 3rd party library instead of implementing the foscam protocol in HASS.
Updated the requirements_all.txt to reflect the pyfoscam dependency/requirement.
This code has been tested with foscam camera in my home.
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for configuration.yaml (if applicable):

Checklist:
If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

Ok to merge once the lint and requirement builds pass. See Travis details for issues.

Awesome 🎉  🐬


[ENG-3516] Create HTML for Registration Files List page

Ticket: ENG-3516
Feature flag: n/a

Purpose

Add a static rendering of the Registration File List view

Summary of Changes

Add new route overview.files for showing files of a registration
Add template file for this new route

Add translation and styling

Add placeholder test
Add logic to show/hide right metadata column

Screenshot(s)

http://localhost:4200/decaf/files

Side Effects
Coming soon
QA Notes

This is just the static HTML without any of the functionality of the actual page.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

5 of 5 (100.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 73.185%

Totals

Change from base Build<PHONE_NUMBER>:
0.03%

Covered Lines:
5181

Relevant Lines:
6817

💛  - Coveralls

Overall I like this a lot. There's a failing test, and linting is failing, but the test should be quick to fix, and I'm not sure what we want to do about the linting. Probably tell it to ignore those strings for now.
Have you run an accessibility check on the page to make sure it's all good there? I wonder if it would be worth putting in data-test selectors.

I've run the automated accessibility checker, and the only thing that came up was the mobile navbar didn't have an aria-label for toggling the navbar in and out, so I've added that. I will add some rudimentary tests to make sure the expected elements are on the screen!


Azure application insights for AKS not working

Followed Microsoft link to install Istio on AKS cluster
https://docs.microsoft.com/en-us/azure/aks/servicemesh-istio-install?pivots=client-operating-system-macos
Injected Istio envoy proxies to my application pods using istio-injection=enabled label to my namespaces
https://docs.microsoft.com/en-us/azure/aks/servicemesh-istio-scenario-routing?pivots=client-operating-system-macos
Installed and configured Azure Application Insights adapter with my application insights instrumentation key
https://docs.microsoft.com/en-us/azure/azure-monitor/app/kubernetes
But I am unable to see data in the application insights. I see below from application insights adapter.
2019/12/30 10:46:36.446|INFO|Istio's Mixer input: [ConnectionCount: 0, RequestsReceived: 0, InstancesSucceeded: 0, InstancesFailed: 0]
2019/12/30 10:47:36.445|INFO|Istio's Mixer input: [ConnectionCount: 0, RequestsReceived: 0, InstancesSucceeded: 0, InstancesFailed: 0]
2019/12/30 10:48:36.447|INFO|Istio's Mixer input: [ConnectionCount: 0, RequestsReceived: 0, InstancesSucceeded: 0, InstancesFailed: 0]
2019/12/30 10:49:36.448|INFO|Istio's Mixer input: [ConnectionCount: 0, RequestsReceived: 0, InstancesSucceeded: 0, InstancesFailed: 0]
2019/12/30 10:50:36.448|INFO|Istio's Mixer input: [ConnectionCount: 0, RequestsReceived: 0, InstancesSucceeded: 0, InstancesFailed: 0]
2019/12/30 10:51:36.445|INFO|Istio's Mixer input: [ConnectionCount: 0, RequestsReceived: 0, InstancesSucceeded: 0, InstancesFailed: 0]
2019/12/30 10:52:36.449|INFO|Istio's Mixer input: [ConnectionCount: 0, RequestsReceived: 0, InstancesSucceeded: 0, InstancesFailed: 0]
2019/12/30 10:53:36.450|INFO|Istio's Mixer input: [ConnectionCount: 0, RequestsReceived: 0, InstancesSucceeded: 0, InstancesFailed: 0]

Please try the troubleshooting section here: https://github.com/microsoft/Application-Insights-Istio-Adapter/blob/master/SETUP.md#troubleshooting
Chances are something minor is missing, number (4) appears to be the most popular issue.

any updates on this ?


fix: object count

Is now camel case: NumObjects -> numObjects
Means that quick upload page now shows "and sharing 9497 files" again
Removes state.repoSize as it's unused

Thank you for noticing this! I was about to merge this, but I feel this PR is a good opportunity to revisit two things :thinking:
1) What SHOULD we show on "Share" screen?
Having peer count at the upload screen adds some value.
It makes it more engaging and encourages user to upload (by confirming connectivity is up and running):

If we fix/restore object count, it will look like this:

And I am not sure if this additional info belongs there or sends the right message these days.
Especially if user has nothing in ipfs.files and is still seeing "hundreds of files" being shared.
I am really conscious about scaring users with such random info without proper context.
Perhaps we should remove  object count until we are able to make it clickable to provide more info via WebUI (IPLD Explorer,  File Browser or some kind of "Stats" screen). Peer count cant stay.
Thoughts?
2) do we need to poll for repo stats every 3 seconds all the time?
AFAIK repo stats call is bit expensive, and this data is shown only on the upload screen.

@lidel repo stats removed


Fix #1644: Document the coding style.

Review by @gzm0 and @nicolasstucki.
Also /cc @andreaTP @yawnt, and pretty much everyone who wants to point out something I have forgotten.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/1797/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/2331/
Test PASSed.

First of all, tnx a lot @sjrd !!!
Following my personal suggestions:

please, start with a more polite sentence, I agree it must be a strong point but this looks definitely scaring! Something like If you are reading this page you wish to contribute to this work and we really appreciate it! We will be happy to drive you to a successful PR but, to avoid most of the initial interactions on the style, please, continue on this document and refer to it ....bla bla bla  sounds a lot better to me.
add some note on patterns to follow in long extends and with declarations, also where to put a self => reference is missing.
add a note where overloaded or strictly correlated , single liner method could avoid blank line in between
please explain a little bit more widely (i.e. with examples and so...) the Collection paragraph that looks a bit wired, also it will be appreciated a note on forall preferred to fold when is the case.

At this point it will be a good benefit to also improve the CONTRIBUTING.md file, with things like:

work on a branch
we will ask you to rebase your PR just before merging it (and rebasing instructions)
...

Updated.
I tried to address all the concerns expressed so far.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/1799/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/2335/
Test PASSed.

in this style guide there is special mention on implicit parameters as the project is very much typeclass based. I appreciate that scala.js is not typeclass based, but I wonder if they should be mentioned, if not for the sake of completeness? Just a thought...

@InTheNow What's supposed to special about implicit parameters? They're just like any other parameters.

For sure, the implicit parameters are the same. The exception, perhaps, would be if you have a long list of parameters and a short list of explicits, or vice-versa - do you enforce the same style on both lists? eg:
lass Foo(
    val a: Int,
    val x: Int,
    val y: Int,
    val z: Int
)(implicit p: Props, x: Ops) extends Bar with Foobar {

// or

class Foo(
    val a: Int,
    val x: Int,
    val y: Int,
    val z: Int
)(implicit
    p: Props,
    o: Ops) extends Bar with Foobar {

Thats all

Updated.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/1800/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/2338/
Test FAILed.

@sjrd  Firstly, thanks for addressing my comments. Secondly, I think the fact that you were able to incorporate them easily, with just a few additions here and there, suggests to me that you have achieved a very nice set of standards.
Congratulations!

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/1802/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/2340/
Test PASSed.

LGTM otherwise

Updated with the suggested changes for with in class declarations.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/1807/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/2346/
Test PASSed.

Thats all

Updated.

LGTM

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/1825/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/2365/
Test FAILed.

retest this please

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/1826/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/2366/
Test PASSed.


[Bug] Task Viewer: Video Autoplay Issues

The autoplay of visual KIS tasks is instable: sometimes it works, sometimes not.
There seems to be a security issue, at least partially.
This source could help here

As I'm gathering from the aforementioned documentation, there is no perfect solution here. The autoplay blocking is pretty strict and affects both  and  with an audible audio track.

Muting is our best shot and the simplest option available, which we can implement.
Overriding the browser security settings or whitelisting a domain are a bit more difficult to enforce.


Generating 141.UWP build.cpp and removing stale build.cpp files

@jasonsandlin,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Allow Facility Mapping with Shopify Locations

What is the motivation for adding/enhancing this feature?
The current process for mapping facilities during initial setup requires users to manually associate the location ID of the facility on Shopify in OMS. This manual association can be time-consuming and error-prone. To streamline this process, we propose integrating the Shopify Location API to automate the retrieval and selection of locations during facility mapping. This enhancement will provide users with a dropdown menu populated by the Shopify Location API, allowing them to conveniently choose and map the desired location.
What are the acceptance criteria?

[ ] ...

Can you complete this feature request by yourself?

[ ] YES
[ ] NO

Additional information

UI pending, assigning to myself


use clockwork.Clock for chat and use clockwork.FakeClock for chat mocks

Typically we dangle the fake clock off of G.  See TestSoftSnooze for an example. Can you do that here, rather than introducing a new global?

@maxtaco Thanks Max! PTAL. There was also a bug in the test where I was taking the first of maxMessages and assumed it was of type TEXT, but it was actually from a map which is randomized. This actually explains the seemingly accidental 50% failure rate :-)


sip validator

A SIP/AIP_ validator is needed in order to check:
Are all expected files present? Do checksums validate? Are filenaming and folder structure as expected?

I think that packagecheck.py handles this.


read SoC possible?

Is there any way to read the soc via ble?
This is the only date I must be able to read to be able to make evcc work properly.

It will be possible in a future release as Tesla have now provided this in their library. In the meantime you'll have to use the Fleet API (although this is soon going to be charged for above a certain level of usage)

The deadline is practically 31.12.2024.
After that the old API is dead and a fleet API is not realistic for most users. (I would consider this Addon already the borderline of what a non-tech user can set up.)
Is there a roadmap for inclusing the new functionality.

Not on a roadmap unfortunately, as the other devs and I are busy with other things.
However I think this functionality will be in demand once Tesla start charging for the Fleet API.
Whilst not committing to it, I will take a look over the Christmas break to see what it entails. If easy I will attempt to get at least an SOC entity working
@raphmur @baylanger tagging you on this in case you have some spare time....


Creating container...error: shared's user has no subuids

Hi,
I try to follow the first step without any success.
oslab@oslab:~$ lxc launch ubuntu
Creating container...error: shared's user has no subuids

I installed lxd (v0.1) from ppa on Ubuntu 14.04.2 LTS  dedicated server
I'm running lxc (v0.1)
other info :
oslab@oslab:~$ uname -a
Linux oslab 3.13.0-45-generic #74-Ubuntu SMP Tue Jan 13 19:36:28 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux
oslab@oslab:~$ cat /etc/subuid
oslab:165536:65536
oslab@oslab:~$ cat /etc/subgid
oslab:165536:65536
oslab@oslab:~$ lxc-start --name ubuntu
lxc-start: lxc_start.c: main: 295 Executing '/sbin/init' with no configuration file may crash the host
oslab@oslab:~$ lxc-start --name ubuntu -f config
lxc-start: lxc_start.c: main: 252 Failed to load rcfile

-rw-r--r--  1 root root     19 Feb 21 09:38 subgid
-rw-r--r--  1 root root     19 Feb 21 09:38 subuid

what I'm doing wrong ?

Hi,
We'll be updating the packages to do that automatically soon, but currently you need to add a uid and gid allocation for the root user in /etc/subuid and /etc/subgid.
Typically the following line in both files will do the trick:
root:165536:65536

Thank you @stgraber
add root:165536:65536 in /etc/subuid and /etc/subgid do the trick
Restart my server and bingo :+1:
root@oslab:~# lxc launch ubuntu
Creating container...done
Starting container...done


Add javadoc for version 0.6.0

This should be merged only after 0.6.0 is released.

LGTM. I have run the release process, so this can be merged after 0.6.0 shows up in https://repo1.maven.org/maven2/com/google/auth/google-auth-library-parent/ .


Add acceptance tests for reopened case group

As a: internal user
I need: to change the response status for an RU for a specific CE for a
specific survey to Re-opened
So that: the status reflects the action that I have taken internally and
externally

Not needed for release 17


-x error about avconv/ffmpeg, but works anyway?

I get the error about avconv/ffmpeg missing when I use the -x option, but the audio file is created anyway and works fine! I don't understand - why stop with an error (hinders downloading whole playlists) when the process worked? I need it to stop throwing pointless errors or at least a flag to ignore them and continue with the playlist.

Post the full output you get when running with --verbose option
To ignore errors use --ignore-errors.

Post the full output you get when running with --verbose option
To ignore errors use --ignore-errors.

Here's a full output.
 Please install one.
Traceback (most recent call last):
  File "youtube_dl\YoutubeDL.pyo", line 1203, in post_process
  File "youtube_dl\postprocessor\ffmpeg.pyo", line 156, in run
  File "youtube_dl\postprocessor\ffmpeg.pyo", line 122, in get_audio_codec
PostProcessingError

H:\files\applications>

The output is an 8.28 MB seemingly audio-only 4 min 32 sec long .m4a file that contains exactly what it should - the audio extracted from the given video.

Here's a full output.
 Please install one.
Traceback (most recent call last):
  File "youtube_dl\YoutubeDL.pyo", line 1203, in post_process
  File "youtube_dl\postprocessor\ffmpeg.pyo", line 156, in run
  File "youtube_dl\postprocessor\ffmpeg.pyo", line 122, in get_audio_codec
PostProcessingError

H:\files\applications>

The output is an 8.28 MB seemingly audio-only 4 min 32 sec long .m4a file that contains exactly what it should - the audio extracted from the given video.

the audio extracted from the given video

Not really, it has just downloaded audio-only format of the best available quality.

the audio extracted from the given video

Not really, it has just downloaded audio-only format of the best available quality.


Funding field

This PR is part of the solution of https://github.com/inveniosoftware/invenio-app-rdm/issues/1358

Included in https://github.com/inveniosoftware/invenio-app-rdm/pull/1433


Remove unused 14th button from GPJ and SDF mode

There is a 14th button in SDF mode and in the Gamepad part of GPJ that is not linked to any button/axis of the real controller. Since it's useless it should be removed to avoid confusion/keep things clean.

I'll look into it and make extra sure that there wasn't a very special reason behind it I simply forgot over time 😅


Broken Link in Project Description

The description link has %20 at the end, causing a 404 https://aws.amazon.com/answers/infrastructure-management/efs-backup/%20

thanks for bringing this to our notice. we have fixed it.


Fixed gosimple errors in issue #1134

#1134
Fixed all the cases mentioned in the above issue.
Worth noting that running the same command used in the issue on my machine brought up some other errors that were not related to gosimple, but also a couple extra that were not highlighted in the issue. The former I left untouched but the latter I fixed up and you can see them in stats.go.
This is now what shows when running the command:
$ golangci-lint run -E "gosimple"
cmd/nerdctl/pull_linux_test.go:66:4: t.Setenv undefined (type *testing.T has no field or method Setenv) (typecheck)
        t.Setenv("COSIGN_PASSWORD", "1")
          ^
cmd/nerdctl/pull_linux_test.go:122:4: t.Setenv undefined (type *testing.T has no field or method Setenv) (typecheck)
        t.Setenv("COSIGN_PASSWORD", "1")
          ^
cmd/nerdctl/pull_linux_test.go:148:4: t.Setenv undefined (type *testing.T has no field or method Setenv) (typecheck)
        t.Setenv("COSIGN_PASSWORD", "2")

Signed-off-by: David Son<EMAIL_ADDRESS>

Thanks, could you enable gosimple in .golangci.yaml ?
https://github.com/containerd/nerdctl/blob/99b12ddc2ae7d58710cc171dc4b46235c9ee2982/.golangci.yml#L47

t.Setenv undefined

Probably your Go is old.
Please make sure to use Go 1.18.

t.Setenv undefined

Probably your Go is old. Please make sure to use Go 1.18.

Sorry, misclick. Wanted to confirm that updating to Go 1.18 eliminated the errors.

Sorry to leave this hanging for this long, I did poke into it a bit more but couldn't seem to figure out why the tests failed. Today I noticed you guys added a label and it seems to be related to flaky testing. Would you like me to continue prodding around this commit, or are you guys fairly sure that it's an issue with the tests versus my (supposedly) semantic changes?

CI is green after restarting.
Could you rebase and update .golangci.yml? Then LGTM


[0.6/dx11] Fix Read-Only Depth Stencil

Depends on #3416. Commits will be rebased away once this is merged.
Fixes the water example under DX11.

bors r+


expect(…).rejects.toMatch(…) should handle an Error object

The current documentation contains the following example:
test('fetchData() rejects to be error', async () => {
  const drinkOctopus = new Promise(() => {
      throw new DisgustingFlavorError('yuck, octopus flavor');
  });

  await expect(drinkOctopus).rejects.toMatch('octopus');
});

Simplified slightly, this would be expected to pass:
  it('throws an error', async () => {
    const drinkOctopus = new Promise(() => {
      throw new Error('yuck, octopus flavor');
    });

    await expect(drinkOctopus).rejects.toMatch('octopus');
  });

Running this test in Jest v20.0.4 (node v8.0.0) produces an error:
Failed: expect(string)[.not].toMatch(expected)

string value must be a string.
Received:
  object: [Error: yuck, octopus flavor]

The Promise is rejecting with an Error rather than a string, as it should, but Jest isn't handling this as expected.

We also discuss about this in https://github.com/facebook/jest/issues/3601 so it might be a dupe.

Yeah it seems like a dupe... Closing in favor of #3601

I wouldn't close this; while the solution is being discussed on #3601, I think a quick documentation change is needed ATM so this issue seems fit for that as it looks like not even a solution is proposed yet in that issue.
I think developers using the documentation should not be expected to find an issue in Github that tells them that the docs are wrong. So I propose to reopen this issue as: "Update the documentation to reflect current status of things".


Absent SplunkUF on Win10

Operating System Version: Ubuntu 18.04.04
Provider (VirtualBox/VMWare): VBox version 6.1.4
Vagrant Version: 2.2.7
Packer Version: 1.5.4
Are you using stock boxes (downloaded) or were they built from scratch using Packer? Built from scratch with Packer
Is the issue reproducible or intermittent? Reproducible
Please verify that you are building from an updated Master branch before filing an issue. Yes
Description of the issue
As per this diagram - https://github.com/clong/DetectionLab/wiki/Lab-Information-&-Credentials - there is a splunk universal forwarder on Win10. I looked into the vagrantfile and looks like we are only installing SUF on WEF. Is this by design or a gap?
I am wondering how it works if its not deployed on Win10 host. Is Win10 sending sysmon/powershell via WEF to Logger?
Vagranfile snippet below -
config.vm.define "win10" do |cfg|
    cfg.vm.box = "detectionlab/win10"
    cfg.vm.hostname = "win10"
    cfg.vm.boot_timeout = 1200
    cfg.vm.communicator = "winrm"
    cfg.winrm.basic_auth_only = true
    cfg.winrm.timeout = 1200
    cfg.winrm.retry_limit = 20
    cfg.vm.network :private_network, ip: "<IP_ADDRESS>", gateway: "<IP_ADDRESS>", dns: "<IP_ADDRESS>"
    cfg.vm.provision "shell", path: "scripts/fix-second-network.ps1", privileged: true, args: "-ip <IP_ADDRESS> -dns <IP_ADDRESS> -gateway <IP_ADDRESS>"
    cfg.vm.provision "shell", path: "scripts/MakeWindows10GreatAgain.ps1", privileged: false
    cfg.vm.provision "shell", path: "scripts/provision.ps1", privileged: false
    cfg.vm.provision "reload"
    cfg.vm.provision "shell", path: "scripts/provision.ps1", privileged: false
    cfg.vm.provision "shell", path: "scripts/download_palantir_wef.ps1", privileged: false
    cfg.vm.provision "shell", path: "scripts/download_palantir_osquery.ps1", privileged: false
    cfg.vm.provision "shell", inline: 'wevtutil el | Select-String -notmatch "Microsoft-Windows-LiveId" | Foreach-Object {wevtutil cl "$_"}', privileged: false
    cfg.vm.provision "shell", path: "scripts/install-utilities.ps1", privileged: false
    cfg.vm.provision "shell", path: "scripts/install-redteam.ps1", privileged: false
    cfg.vm.provision "shell", path: "scripts/install-choco-extras.ps1", privileged: false
    cfg.vm.provision "shell", path: "scripts/install-osquery.ps1", privileged: false
    cfg.vm.provision "shell", path: "scripts/install-sysinternals.ps1", privileged: false
    cfg.vm.provision "shell", path: "scripts/install-autorunstowineventlog.ps1", privileged: false
    cfg.vm.provision "shell", inline: 'cscript c:\windows\system32\slmgr.vbs /dlv', privileged: false

I am wondering how it works if its not deployed on Win10 host. Is Win10 sending sysmon/powershell via WEF to Logger?

Exactly. This is by design :)
At one point, there was a UF installed on WIN10, so that diagram may need to be updated.


Unable to pull in NW properties

A detail - I'm using nw.js to run an express server that then runs the rest of my app. If I use Twitch.init by itself & only passing a client ID, I get console output that it connected.
When I try to pass nw.gui to it, this is where I run into issues.
var gui = require('nw.gui');
Twitch.init({
      clientId: '<CLIENTID>',
      session: status,
      nw: gui
    }, function(error, status) {
      if (error) {
          console.log(error);
      }
      if (status.authenticated) {
          console.log('SYS: User is authenticated. ' + status);
      }
});

This results in Uncaught Error: Invalid value for argument 2. Property 'toolbar': Unexpected property.
I tried removing the toolbar property from twitch-sdk/twitch.js entirely. It passes this part now, obviously because we're just skipping the problem. But then it fails on win.on('loaded'... saying on is an unknown property of win.
So... basically nw.gui is not being passed correctly to twitch-sdk. What's at fault here?

It looks like the NWjs API (especially Window) has changed a lot between versions 0.12 and 0.13, rendering the twitch-sdk incompatible with it. I'll have to look into it in detail to fix it.

I just checked if NW.js 0.12.3 is working and it seems to be. 0.12.3 is the current stable version of NW.js so please stick to that one for now if that is possible for you.
Also, I can't seem to get the DevTools in NW.js 0.13 to work so I can't fix things until I get that sorted.

Ah, you're right I had forgotten to mention I was using 0.13.
As for the DevTools, there's no toolbar anymore in 0.13. To access them you can right click the page and choose inspect / inspect background page. Background in my case is my backend / server.

So, I have hopefully made the changes necessary to support NW.js 0.13 and pushed them to the repo. It still does not work, though, due to a bug in NW where the loaded event of a Window does not fire and I have no way around that so we need to wait for the NW devs to fix that.
The syntax for NW.js 0.13 will be different from 0.12 because we don't need to pass the nw object to the SDK anymore. It also makes a convenient way of keeping the SDK compatible with the older NW.js versions.
Twitch.init({
      clientId: '<CLIENTID>',
      session: status,
      nw: true // we don't pass the nw object here, thus we have similar behaviour to electron
    }, function(error, status) {
      if (error) {
          console.log(error);
      }
      if (status.authenticated) {
          console.log('SYS: User is authenticated. ' + status);
      }
});

I'll leave this issue open until I know for sure that it really works.
PS: the problem with DevTools was that I had the NORMAL flavor of NW.js while I was supposed to use the SDK one. Silly me :smiley:

Just updated the title to make the problem more clear.

Nicely done, NW has been quick to solve a lot of these issues from what I see so I'd think you'll be off & running soon enough. Thanks and I'll keep an eye out for 0.4.


Disable sorting on tree model tables

Closes: #1854
What's Changed

TODO

[ ] Explanation of Change(s)
[ ] Added change log fragment(s) (for more information see the documentation)
[ ] Attached Screenshots, Payload Example
[ ] Unit, Integration Tests
[ ] Documentation Updates (when adding/changing features)
[ ] Example Plugin Updates (when adding/changing features)
[ ] Outline Remaining Work, Constraints from Design

Why doesn't it make sense? Having nesting when sorting doesn't make sense, but being able to sort makes sense to me.

I suppose that could be an alternate approach - when sorting, disable all nesting and render the sorted data entirely flat? Not sure that's what a user would necessarily expect though.

when sorting, disable all nesting and render the sorted data entirely flat, that is what I thought it was tbh.

when sorting, disable all nesting and render the sorted data entirely flat, that is what I thought it was tbh.

Not how it works today: https://demo.nautobot.com/dcim/regions/?sort=-site_count

We will move forward with supporting sorting and when the column is sorted, the indentation that is rendered via the template will be stripped.


Allowing nested username (e.g. /rhat/smahajan/) in docker tag command

Signed-off-by: Shishir Mahajan<EMAIL_ADDRESS>

Follow up on https://github.com/docker/docker/pull/11116


Add the ability to upload multiple documents at once

Describe the bug
Currently, when applying for a program, the user can only upload one document at a time.
To Reproduce
Steps to reproduce the behavior:

When applying for a program with documentation required, click "Choose File".
Try attaching multiple docs, it won't work.
After you attach one you have to click "Save and next" and then go through the process of uploading a file all over again.

Expected behavior
When I click choose file, I can select multiple. Or on the same page, I have the option to Choose another file.
Screenshots
If applicable, add screenshots to help explain your problem.

Removed bug, code WAI. This is a feature request.

Closing sounds good since we've got the more recent duplicate request #6961 (I've closed it.)


AndroidX migration required

Please migrate to AndroidX if this libary should continue to be usable, as this is a requirement for Google Play as of 1. of november do to min api 28 and firebase for that version requires AndroidX.

@mortenholmgaard AndroidX is not yet necessary. What is necessary is to update targetSdk to api 28. I have created a pull request and after review, it will be merged and released.  #84


Sync modeladmin field ordering logic with django's

It looks like the original code was copied from django.contrib.admin.views, and it's gotten a bit out-of-sync; this brings it back in-sync with django/contrib/admin/views/main.py@2411b8b.
Fixes wagtail/wagtail-modeladmin#29

Hi @thatguystone. This is looking great, thank you! Would you be okay to add a couple of tests to cover the new cases? I would be surprised if there wasn't something in Django that you could use for inspiration.

Hello, I'm closing this as it's quite dated and we no longer accepting PRs for new ModelAdmin features in Wagtail as per wagtail/rfcs#85. If you'd like, you could create a new PR to the wagtail-modeladmin repository. If the bug fix is critical, we might consider backporting it to the Wagtail repo during the deprecation period. Thank you!


Upgrade to version 4.4 lts at least

Related to https://symfony.com/releases/4.3
Allow me to propose this change, even if I do not know what are your processes of upgrading ecosystems packages related to the eom/eol of main symfony repo when the lts is released
As far as i know, upgrading from vX.0|1|2|3 to vX.4 is « easy » (deprecations appart)
Feel free to close, I would be happy to know why/reasons if it is the case :)
Thanks

This repo is read-only. All PRs should be done on twig/twig instead.
Sorry I didn't see this PR before.


When to upgrade to support for react-native 0.56.0

I just came by to see if react-native 0.56 was supported, I guess it's not...  :(

hey, are you using most recent version? one was published less than 24 hours ago: https://github.com/react-native-community/react-native-svg/pull/729

I was not, but I will try again

@maxkomarychev
@thitemple
Thanks

It did not work, now I'm seeing this error:

Where:
Build file 'C:\Users\thiago\Documents\projects\publicUserApp\node_modules\react-native-svg\android\build.gradle' line: 52

What went wrong:
A problem occurred evaluating project ':react-native-svg'.

Could not find method implementation() for arguments [com.facebook.react:react-native:+] on object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler.

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

I'm also having the exactly same issue @thitemple is having. The problem affects only Android build.

It requires upgrading gradle, there's an open pr to revert that change, I'll probably merge and release a patch version today

Can you try again with 6.5.1?

It works!


Build script cannot access files from workspace root

A build script (build.rs) in a workspace crate cannot access files outside its crate directory (e.g. /shared/baz.txt is inaccessible from /bar because only /bar by itself is copied to the nix store, without any other root workspace files.
This works fine in a regular cargo build but fails when building as a crane derivation.
Example project: https://github.com/simonzkl/crane-build-script
fn main() {
    let out_dir = std::env::var("OUT_DIR").unwrap();
    let text = std::fs::read_to_string("../shared/baz.txt").unwrap();
    std::fs::write(
        format!("{out_dir}/hello.rs"),
        format!(r#"pub fn hello() {{ print!("{text}") }}"#),
    )
    .unwrap();

    println!("cargo:rerun-if-changed=../shared/baz.txt");
}

Steps to reproduce:

Working: cargo build
Not working: nix build

Cargo dependencies packaged through git can also have this issue, which makes it difficult to work around.

I would argue that this is not idiomatic, but it is technically supported by cargo. Note that this also breaks cargo publish because a crate is referencing files outside its CARGO_MANIFEST_DIR. A common workaround there is to symlink /bar/shared -> /shared. This workaround however does not work in crane.

Hi @simonzkl thanks for the report!
The issue here is that craneLib.cleanSource will (by default) ignore any files except for *.rs and *.toml so the .txt file is being ignored.
Take a look at https://crane.dev/source-filtering.html on how to tune your source filter to include the necessary files. Hope this helps!

Ah, you might be right there. The issue remains when building git dependencies with build scripts that reference files outside their manifest dir. I thought I reproduced the issue without having to use git dependencies, but it seems that was just because of cleanSource. I updated the example. It works fine with regular cargo, but breaks in nix.
Not sure if that's something crane should handle or not though. It's technically a valid setup when used as a git/path dependency, but not as a cargo crate (cargo publish).

I updated the example. It works fine with regular cargo, but breaks in nix.

Unfortunately this isn't something we can work around in crane as the way cargo has chosen to represent git dependencies does not match how crate vendoring works. Namely if you try to build this project using cargo vendor it will likely fail for the same reasons.
My best advice would be to either fix the issue upstream, or depend on your own fork which applies the necessary patch.
Even if we were to introduce a first class way of patching git dependencies (see https://github.com/ipetkov/crane/issues/473#issuecomment-1892507511) you would still need to apply the necessary patching to make things work, unfortunately.
For now I'm going to resolve this as a duplicate of #473, but thanks anyway for the report!


[zh] Setup files to sync for 1.22(kubeadm part-3)

Part of #29328

ping @xichengliudui @tengqm
for approval

/approve


[v2.7] Upgrade cluster-proportional-autoscaler to v1.8.9+

Currently for even the latest RKE1 versions we include cluster-proportional-autoscaler v1.8.6, see https://github.com/rancher/kontainer-driver-metadata/blob/a294e104b56da802791b9555671d7b1f24634232/pkg/rke/k8s_rke_system_images.go#L10114 / https://github.com/rancher/kontainer-driver-metadata/blob/a294e104b56da802791b9555671d7b1f24634232/pkg/rke/k8s_rke_system_images.go#L10141
There is already registry.k8s.io/cpa/cluster-proportional-autoscaler:v1.8.9 that features CVE fixes that we want to bring into Rancher, the ask of this issue is to update to this (or never, if available) version.
Ideally, we want this version bumped in new versions to be added per https://github.com/rancher/rancher/issues/44798
SURE-7862

cluster-proportional-autoscaler version is upgraded correctly to v1.8.9 in March KDM patches. Hence, closing this issue.


OCPBUGS-22947: Follow up: remove default value for --from

Description
This PR removes the default value (working-dir) that was assigned by default to the --from command argument.
With this change the From option will never be initialized for the mirrorToDisk workflow, where the --from is not used.
Furthermore, we can ensure that --from really becomes mandatory for the diskToMirror workflow, and the user cannot forget to add it in the input arguments.
Fixes # OCPBUGS-22947
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

./bin/oc-mirror --config cfg.yml file:///home/skhoury/release/   --v2
./bin/oc-mirror --config cfg.yml  --from file:///home/skhoury/release/ docker://localhost:5000/22947  --v2
./bin/oc-mirror prepare --config cfg.yml  --from file:///home/skhoury/release/ docker://localhost:5000/22947  --v2

Following is cfg.yaml
kind: ImageSetConfiguration
apiVersion: mirror.openshift.io/v1alpha2
mirror:
 platform:
   channels:
   - name: stable-4.13
     minVersion: 4.13.10
     maxVersion: 4.13.10
   graph: true

Expected Outcome
No Errors

/lgtm


Add instruction sheet to 1st page of output PDF

POA Instruction Sheet.docx

Lori wants to see this form included as part of the initial release
Attached form should be first of assembled PDF


Detect the "zombie" jobs, and kill them 🧟 🔫

Sometimes the pods crash:
prod-datasets-server-worker-first-rows-8579994756-vgpkg           0/1     OutOfmemory              0               92m
prod-datasets-server-worker-first-rows-8579994756-vmvk7           0/1     OutOfmemory              0               92m
prod-datasets-server-worker-first-rows-8579994756-vsmmt           1/1     Running                  0               4h27m
prod-datasets-server-worker-first-rows-8579994756-vxtwn           0/1     OutOfmemory              0               3h12m
prod-datasets-server-worker-first-rows-8579994756-vzs6j           0/1     OutOfmemory              0               3h12m
prod-datasets-server-worker-first-rows-8579994756-w2k55           1/1     Running                  2 (3h25m ago)   4h16m
prod-datasets-server-worker-first-rows-8579994756-w5c6m           1/1     Running                  0               4h27m
prod-datasets-server-worker-first-rows-8579994756-w5ks6           1/1     Running                  1 (4h21m ago)   4h27m
prod-datasets-server-worker-first-rows-8579994756-w7ds5           1/1     Running                  0               4h27m
prod-datasets-server-worker-first-rows-8579994756-wbqlq           1/1     Running                  0               4h16m

The job that was running then stays forever in the "started" status, what we can call a zombie.
The issue is that, for the rules implemented in the queue logic, it can prevent other jobs for the same dataset, or for the same user, to be processed. It even prevents to re-run the same job.
Ideally, we should detect that the job has failed, change its status to "error" and put an error response in the cache database.
To implement this, an option proposed by @XciD is:

to have a parallel thread (heartbeat) that will update the job in the database every xxx seconds
a "garbage collector" loop will look for zombies and finish them as described above

Why not to handle that validation before worker loop starts? I mean, before https://github.com/huggingface/datasets-server/blob/main/workers/datasets_based/src/datasets_based/main.py#L15  look all "started" jobs and cancel them and create another in the queue (Like in force-refresh).
With this approach we could avoid having parallel extra validation. I assume that while Service is alive and a job is in "started" status, it is because something is being computed and indeed is "alive" but, if service starts and there are "started" jobs, they should be "death".

Yes, you're right, but it's only part of the problem. While the Service is alive, a lot of pods crash. We can see it in the list of pods: ContainerStatusUnknown, Error, OutOfmemory, OutOfcpu, OOMKilled, but the app is still waiting for them to finish, and in particular, as the number of concurrent jobs for the same user is limited, no other jobs are started once if the limit has been reached.

Also, when a worker starts, others may already be running. We have currently no way to know

Sorry, I was totally forgetting that there are multiple pods for the same service

I think we can start with "garbage collector" step first without implementing the heartbeat yet:
Garbage collector:

A loop would sleep every T1 seconds
The loop could have a process that

Reads all jobs in db with "started" mode
Filter only those jobs which time difference ("started_at" - now) > T2
Cancel the job
Inserts a new job in the queue with "waiting" status if there isn't already one
Considerations:

Need to define if this collector will run only in one pod or many - I think one is enough at the beginning since we dont have huge data with "starting" (Maybe when doing a backfill)
Need to define if we want one collector per worker
Need to define T1 - It could be a small number (5 min), at first it is not critical. After "heartbeat" is implemented, this value should be consistent with a T3 time interval (Interval for  heartbeat updates the db).
Need to define T2 - At the beginning, we should have a value per worker, we could assume that having a media o duration per succeeded/error job and it should be a env configuration param. (i.e 3 hrs for first-rows and 10min for /config-names).
Once heartbeat is implemented, we should change the value to a minor one that is consistent with T3 (heartbeat time interval).

Cons of implementing initially only collector step:

Less accuracy, since T2 is based on some assumption and would have a big value (for first rows for example)

After heartbeat step is implemented:
Pros

More accuracy since T3 is consistent with T1 and if we give it a small number, will be able to identify the "zombies" quicker
Cons
Many modifications to the db per job and worker, would it increase db usage?
Would having an extra thread on execution time per job increase the memory usage?

It seems like a good plan to me. WDYT @huggingface/datasets-server?

Inserts a new job in the queue with "waiting" status if there isn't already one

We'll just end up with a queue made of unfeasible job no ? We'd probably need allow it a max number of retries (2 or 3)

Cancel the job

Some operations like /parquet-and-dataset-info write data to hub repos so we need to clean it up at one point if it gets canceled (for this one we just need to delete some files).
Also we'd need a way to communicate to the worker that it has to cancel the job. Right now we don't know which worker is doing what. Instead, maybe the worker that is executing the job can cancel itself if it takes too long ? That would mean that the worker loop process should be controlled by another process that is responsible for checking if the job needs to be canceled.

We'd probably need allow it a max number of retries (2 or 3)

Yes, you're right: we should just insert an error in the cache, with an error code "pod crashed" or something like that. No need to retry, I think.

Some operations like /parquet-and-dataset-info write data to hub repos so we need to clean it up at one point if it gets canceled (for this one we just need to delete some files).

You're right, but it can be hard, because we're not sure if the files have been updated by the worker, or are from a previous job.

the worker loop process should be controlled by another process that is responsible for checking if the job needs to be canceled.

hmmm: the heartbeat thread running along the worker could be in charge of stopping the worker when the duration is above the limit (timeout).

You're right, but it can be hard, because we're not sure if the files have been updated by the worker, or are from a previous job.

We just need to revert commits until we reach a valid one ? Valid commits can be stored in the db when a job succeeds

Yes, you're right: we should just insert an error in the cache, with an error code "pod crashed" or something like that. No need to retry, I think.
What if a job failed because of suddenly pod crash but it is a small one, I agree to support a limit number of retry opportunities, that will also let us identify those conflicting datasets.

Some operations like /parquet-and-dataset-info write data to hub repos so we need to clean it up at one point if it gets canceled (for this one we just need to delete some files).
We need to implement a "rollback" logic for the parquet specific case first, since currently we don't have that logic in cancel-jobs endpoint https://github.com/huggingface/datasets-server/blob/main/services/admin/src/admin/routes/cancel_jobs.py#L33
https://github.com/huggingface/datasets-server/blob/main/libs/libcommon/src/libcommon/queue.py#L433 maybe we are committing partial parquet files when doing a prod deploy

Opened https://github.com/huggingface/datasets-server/issues/804 regarding rollback for /parquet-and-dataset-info

Btw I recall Celery (a task queue) already implements time limits with clean ups and automatic retries with delays. Is someone familiar with it ? It looks interesting

Valid commits can be stored in the db when a job succeeds

The commit is stored in the cache, along with the worker version

What if a job failed because of suddenly pod crash but it is a small one, I agree to support a limit number of retry opportunities, that will also let us identify those conflicting datasets.

Yes, but I think it's better to manage it in another PR, to focus on one feature at a time.

Btw I recall Celery (a task queue) already implements time limits with clean ups and automatic retries with delays. Is someone familiar with it ? It looks interesting

I look at it along with dagster and airflow (even if the aim is not the same). Maybe we could give it a try, but I'm not sure how we can manage the priorities in the queue (various levels of priority: NORMAL/LOW, limit the number of concurrent jobs for the same user, prioritize the jobs from users that have no started jobs yet, etc.)
Also: would it be able to work both with kubernetes and locally without kubernetes?

There's a priority level you can set for each task in Celery : https://github.com/celery/celery/issues/2635#issuecomment-173597053
And we can set it based on the user's history for example
And I've seen examples of kubernetes and docker-compose deployments on github - you just need to define the celery workers, the rabbitmq queue, etc.

OK. it might be a good replacement for part of the code. But should we explore this as part of this issue, or fix the issue first and try to migrate afterward?

I think we're still learning our needs, so for now I'd continue with the current implem to keep full flexibility. Let's think about it again once we have random access to rows ?

Zombies jobs are now killed every 10 minutes if they missed 5 heartbeats (happens every minute).
Next is to put an error response in the cache database when it happens


Add Custom Domain for to-the-moon.farm.eth

added  "vote.to-the-moon.farm": "to-the-moon-farm.eth"
Add custom domain for your space (to-the-moon.farm.eth)

OK made a new pull request

Gesendet: Sonntag, 27. Juni 2021 um 20:03 Uhr
Von: "Gokai" @.>
An: "snapshot-labs/snapshot-spaces" @.>
Cc: "Loesil" @.>, "Author" @.>
Betreff: Re: [snapshot-labs/snapshot-spaces] Add Custom Domain for to-the-moon.farm.eth (#1423)

@gokaiorg requested changes on this pull request.
There is a conflict in your PR since domains.json file has been updated, can you resolve it?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

ok ignore the new pull request, merged this one. (sry first time i made a pull request)


Bug report | Setup Leave

What's your nodejs Version.
v17.9.0
What's the version you downloaded the bot?

From the releases: 10.3.0

Desktop

OS: Windows 10 | Windows Server 2019 Datacenter
Version: 1809

Describe the bug

I wanted to change the background of the exit message. So I ran setup-leave. Then on Manage the Image and then I'm on Set Image Backround I upload an Image then I became an error which says "ERROR | Your Time ran out" but whoever leaves the server after that comes this image in the background.

To Reproduce

Steps to reproduce the behavior e.g:

Execute the Command 'seup-leave'
Then go to 'Channel Leave Messages'
After that, go in "Manage the Image"
and now go to "Set Image Background"
Upload a Image
See error

Fixed https://github.com/Tomato6966/Multipurpose-discord-bot/pull/130/files

can you try welcome and leave in multi server
because dont work for me


[BUG] Unable to acquire token using UsernamePasswordCredential and "/common" authority

Describe the bug
We are unable to acquire token using com.azure.identity.UsernamePasswordCredential with https://login.microsoftonline.com/common as Authority. The same authority works with InteractiveBrowserCredential.
Changing authority to "organizations" fixes the issue, but that's not a possible solution since this comes into picture when connecting to Azure Data Explorer using microsoft/mssql-jdbc driver (and the stsUrl for Azure Data Explorer is https://login.microsoftonline.com/common ). The problem occurs when token is acquired using MSAL4J when using username password based authentication.
The same setup however works fine in .NET as Azure Identity in .NET (using MSAL.NET) does not have any problems with this.
It looks like a bug specifically in MSAL for Java.
Exception or Stack Trace
Caused by: com.microsoft.aad.msal4j.MsalServiceException: AADSTS9001023: The grant type is not supported over the /common or /consumers endpoints. Please use the /organizations or tenant-specific endpoint.
Click for complete stacktrace

com.azure.core.exception.ClientAuthenticationException: Failed to acquire token with username and password
    at com.azure.identity.implementation.IdentityClient.lambda$authenticateWithUsernamePassword$19 (IdentityClient.java:601)
    at reactor.core.publisher.Mono.lambda$onErrorMap$31 (Mono.java:3488)
    at reactor.core.publisher.FluxOnErrorResume$ResumeSubscriber.onError (FluxOnErrorResume.java:94)
    at reactor.core.publisher.MonoFlatMap$FlatMapMain.secondError (MonoFlatMap.java:192)
    at reactor.core.publisher.MonoFlatMap$FlatMapInner.onError (MonoFlatMap.java:259)
    at reactor.core.publisher.MonoCompletionStage.lambda$subscribe$0 (MonoCompletionStage.java:76)
    at java.util.concurrent.CompletableFuture.uniWhenComplete (CompletableFuture.java:859)
    at java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire (CompletableFuture.java:837)
    at java.util.concurrent.CompletableFuture.postComplete (CompletableFuture.java:506)
    at java.util.concurrent.CompletableFuture$AsyncSupply.run (CompletableFuture.java:1705)
    at java.util.concurrent.CompletableFuture$AsyncSupply.exec (CompletableFuture.java:1692)
    at java.util.concurrent.ForkJoinTask.doExec (ForkJoinTask.java:290)
    at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec (ForkJoinPool.java:1020)
    at java.util.concurrent.ForkJoinPool.scan (ForkJoinPool.java:1656)
    at java.util.concurrent.ForkJoinPool.runWorker (ForkJoinPool.java:1594)
    at java.util.concurrent.ForkJoinWorkerThread.run (ForkJoinWorkerThread.java:183)
Caused by: com.microsoft.aad.msal4j.MsalServiceException: AADSTS9001023: The grant type is not supported over the /common or /consumers endpoints. Please use the /organizations or tenant-specific endpoint.
Trace ID: c0af752d-c884-4375-adc9-0342d40e5301
Correlation ID: 901d2e09-cc60-494e-b8e6-33e82e605729
Timestamp: 2021-07-22 22:28:35Z
    at com.microsoft.aad.msal4j.MsalServiceExceptionFactory.fromHttpResponse (MsalServiceExceptionFactory.java:45)
    at com.microsoft.aad.msal4j.TokenRequestExecutor.createAuthenticationResultFromOauthHttpResponse (TokenRequestExecutor.java:96)
    at com.microsoft.aad.msal4j.TokenRequestExecutor.executeTokenRequest (TokenRequestExecutor.java:37)
    at com.microsoft.aad.msal4j.AbstractClientApplicationBase.acquireTokenCommon (AbstractClientApplicationBase.java:128)
    at com.microsoft.aad.msal4j.AcquireTokenByAuthorizationGrantSupplier.execute (AcquireTokenByAuthorizationGrantSupplier.java:63)
    at com.microsoft.aad.msal4j.AuthenticationResultSupplier.get (AuthenticationResultSupplier.java:59)
    at com.microsoft.aad.msal4j.AuthenticationResultSupplier.get (AuthenticationResultSupplier.java:17)
    at java.util.concurrent.CompletableFuture$AsyncSupply.run (CompletableFuture.java:1700)
    at java.util.concurrent.CompletableFuture$AsyncSupply.exec (CompletableFuture.java:1692)
    at java.util.concurrent.ForkJoinTask.doExec (ForkJoinTask.java:290)
    at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec (ForkJoinPool.java:1020)
    at java.util.concurrent.ForkJoinPool.scan (ForkJoinPool.java:1656)
    at java.util.concurrent.ForkJoinPool.runWorker (ForkJoinPool.java:1594)
    at java.util.concurrent.ForkJoinWorkerThread.run (ForkJoinWorkerThread.java:183)

To Reproduce
Steps to reproduce the behavior:

Acquire token using UsernamePasswordCredential
AuthorityUrl : https://login.microsoftonline.com/common

Code Snippet
stsUrl = "https://login.microsoftonline.com/common";
// provide your own user, password and appId
Mono<AccessToken> token = new UsernamePasswordCredentialBuilder()
                .authorityHost(stsUrl)
                .clientId(AppId).username(user).password(password)
                .build()
                .getToken(new TokenRequestContext().addScopes(stsUrl + "/.default"));

Expected behavior
Token should be acquired, no exception should be thrown.
Setup (please complete the following information):

OS: Windows 10
IDE: Maven 3.8.0 (console app) @ Eclipse
Library impacted: com.azure.azure-identity:1.3.3
Culprit library: com.microsoft.azure.msal4j

Additional context
The same setup works in .NET using MSAL.NET, so it's expected to work in Java too.
Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[x] Bug Description Added
[x] Repro Steps Added
[x] Setup information Added

Thanks for reporting this @cheenamalhotra.  @g2vinay could you open up a corresponding issue in the msal4j repo and link it here?

I later reached out to MSAL Team too on their existing issue https://github.com/AzureAD/microsoft-authentication-library-for-java/issues/382#issuecomment-885327277, and here is the link to this documented limitation: https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/wiki/Username-Password-Authentication#authority-implications
I'll close this for now, I also revalidated .NET driver and confirmed this occurs there too, got a fluke first time.


[ci,doc] Add lld as an apt requirement

Add lld to apt-requirements.txt.
This is to avoid an error raised by rustc during bazel builds:
collect2: fatal error: cannot find 'ld' compilation terminated.

It might also be good to add it to yum-requirements.txt

NIT: apt-requirements.txt configures CI to perform installation so this isn't merely a doc change. Given it's a small change to fix an issue that's existed for a while, if it's compatible with our CI systems: SGTM

Good point, I've changed the tag of the PR and commit to [ci,doc]

It might also be good to add it to yum-requirements.txt

Thanks for pointing this out to me, I have now added lld to the yum requirements.


Error reading translations file terra-icon/translations/fi-FI.json.

Bug Report
Description
I've got a question about a build error i'm getting. When I run npm start it aggregates translations, including those for fi-FI.  Then I get this error.
There was an error reading your translations file /Users/gi026890/Documents/stella-timeline-ukclinfork/node_modules/terra-icon/translations/fi-FI.json.
Exception Message: ENOENT: no such file or directory, open '/Users/gi026890/Documents/stella-timeline-ukclinfork/node_modules/terra-icon/translations/fi-FI.json'
I don't see a fi-FI.json file in https://github.com/cerner/terra-core/tree/master/packages/terra-icon/translations
Steps to Reproduce

Install this branch of a stella-timeline fork https://github.cerner.com/UKDevelopment-ClinicalDev/stella-timeline/tree/UKIPDEV-910_UpdateToolkitDevSiteVersions
run npm start

Additional Context / Screenshots

Expected Behavior
Not to see the error message about terra icon and fi-FI.json
Possible Solution
Add fi-FI.json to terra-icon translations folder
Environment

Component Name and Version:
Browser Name and Version:
Node/npm Version: [e.g. Node 8/npm 5]
Webpack Version:
Operating System and version (desktop or mobile):

@ Mentions

This error can be seen running the terra-core repo. We just need to get the missing translation file added.

Great  - thank you


Add helper for building a lens over a sum-type

This change adds a helper function for when you want a lens over a sum-type.  For example:
data X = A Int | B (Tuple Boolean Int)

xInt :: Lens' X Int
xInt = lens' case _ of
  A i -> sumLens identity A i
  B i -> sumLens _2 B i

I don't know if anything like this already exists.
Also would appreciate suggestions of a better name :sweat_smile:

Is there something similar in Haskell's lens?

I've twice wanted this recently; @LiamGoodacre  @natefaubion @puffnfresh if none of you have further comments on this I will merge it in next week -- thanks @LiamGoodacre, sorry for such a long delay!

I've rebased and fixed the test file by renaming the example.

Rethinking this slightly.
Now looking into doing:
lensStore :: forall s t a b . ALens s t a b -> s -> Tuple a (b -> t)
lensStore l = withLens l (lift2 Tuple)

sumLensExampleInt :: Lens' SumLensExample Int
sumLensExampleInt = lens' case _ of
  SumLensA i -> map SumLensA <$> lensStore identity i
  SumLensB i -> map SumLensB <$> lensStore _2 i

Such that
(l ∷ Lens s t a b) → (lens' (lensStore l) ≅ l)

@LiamGoodacre Let me know when you're ready for another look wrt merging.

You can convert from VL lens to profunctor lens with the following:

data Context a b t = Context (b -> t) a
  deriving Functor

lensVL
  :: Strong p
  => (forall f. Functor f => (a -> f b) -> s -> f t)
  -> p a b -> p s t
lensVL f = dimap
  ((\(Context bt a) -> (a, bt)) . f (Context id))
  (\(b, bt) -> bt b)
  . first'

The code is Haskell, but conversion to PureScript should be trivial.

@thomashoneyman: I'm happy with this now.
@arybczak: I don't think conversions to and from LV should be used here, but may indeed be separately useful.

It's related since as mentioned in https://github.com/purescript-contrib/purescript-profunctor-lenses/pull/96#issuecomment-453847527, lens library doesn't need sumLens because defining lens for a sum type is trivial with VL variant.

sumLens is no-longer in this PR.
Given that lens' already exists - which is a conversion from a store-style lens s -> Tuple a (b -> t) - we might as well add a conversion to that style.  One benefit of adding this is that embedding existing lenses with lens' becomes slightly more straight forward to write - the original motivation for exploring sumLens.
I'm renaming this PR to "Support inverse of lens'".
Fully happy to support other methods for building lenses though.


ParamValidationError for invalid bucket name when Config.parameter_validation is False

Describe the bug
Setting parameter_validation=False in botocore.config.Config does not disable validation of bucket names.
Expected Behavior
expected boto to issue the request with the given bucket name
Current Behavior
client.create_bucket(Bucket='test;bucket') raises botocore.exceptions.ParamValidationError:
Traceback (most recent call last):
  File "/home/cbodley/test.py", line 9, in <module>
    client.create_bucket(Bucket='test;bucket')
  File "/usr/lib/python3.12/site-packages/botocore/client.py", line 565, in _api_call
    return self._make_api_call(operation_name, kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/botocore/client.py", line 958, in _make_api_call
    api_params = self._emit_api_params(
                 ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/botocore/client.py", line 1077, in _emit_api_params
    self.meta.events.emit(
  File "/usr/lib/python3.12/site-packages/botocore/hooks.py", line 412, in emit
    return self._emitter.emit(aliased_event_name, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/botocore/hooks.py", line 256, in emit
    return self._emit(event_name, kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/botocore/hooks.py", line 239, in _emit
    response = handler(**kwargs)
               ^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/botocore/handlers.py", line 287, in validate_bucket_name
    raise ParamValidationError(report=error_msg)
botocore.exceptions.ParamValidationError: Parameter validation failed:
Invalid bucket name "test;bucket": Bucket name must match the regex "^[a-zA-Z0-9.\-_]{1,255}$" or be an ARN matching the regex "^arn:(aws).*:(s3|s3-object-lambda):[a-z\-0-9]*:[0-9]{12}:accesspoint[/:][a-zA-Z0-9\-.]{1,63}$|^arn:(aws).*:s3-outposts:[a-z\-0-9]+:[0-9]{12}:outpost[/:][a-zA-Z0-9\-]{1,63}[/:]accesspoint[/:][a-zA-Z0-9\-]{1,63}$"

Reproduction Steps
import botocore
import boto3

cfg = botocore.config.Config(parameter_validation=False,
                             s3={"addressing_style": "path"})
client = boto3.client(service_name='s3',
                      endpoint_url='http://localhost:8000',
                      config=cfg)
client.create_bucket(Bucket='test;bucket')

Possible Solution
avoid calling validate_bucket_name() when Config.parameter_validation is False
Additional Information/Context
testing against s3-compatible Ceph server which optionally supports 'relaxed' bucket naming requirements
SDK version used
1.34.153
Environment details (OS name and version, etc.)
Fedora 40, python 3.12

Thanks for reaching out. This came up before in the Boto3 repo: https://github.com/boto/boto3/issues/2891
As mentioned there:

Unfortunately the parameter validation flag unfortunately does not apply to S3 validation. Those validators are part of a customization. If you can provide more details on what your use case would be, we can discuss if this is a useful feature request for others as well.

How do we disable bucket name validation then? Our Ceph buckets are of the form "x:y" and we currently have to disable the checks by doing:
>>> from botocore.handlers import validate_bucket_name
>>> client.meta.events.unregister("before-parameter-build.s3", validate_bucket_name)

but this can't be done if we are using s3fs where the client object is internal and whose creation is deferred until needed.
See https://github.com/fsspec/s3fs/issues/893

Converting to a feature request — not sure if there's a good workaround for third-party use cases here.


Possible to use Redis as the queue?

Is it possible to configure sensu so that redis is used as the queue instead of rabbit? It'd allow us to need to worry about configuring and maintaining one less thing, since there's already a redis instance as part of sensu (and redis is used for so many other things). If not would this be an acceptable feature request?
Just as a little side note, I noticed that Logstash used to offer rabbit but now recommends redis. "Previous versions of this guide used AMQP via RabbitMQ. Due to the complexity of AMQP as well as performance issues related to the Bunny driver we use, we're now recommending Redis instead." http://logstash.net/docs/1.3.3/tutorials/getting-started-centralized

Just stumbled across this and thought I'd leave pointers to...

https://github.com/sensu/sensu-transport/pull/12
https://github.com/sensu/sensu/pull/952

Per @portertech, redis transport is in 0.19


[Feature] Use JSON Schema to determine imported JSON type when available

Suggestion
🔍 Search Terms
json schema
✅ Viability Checklist
My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion
Currently when importing JSON the types provided is basically just the inferred type treated the JSON as an object literal.
It would however be helpful to support JSON schema declared types to create types that may be either be more narrow or less narrow that more accurately reflect what one can expect with the JSON.
📃 Motivating Example
Consider as one example the following JSON:
// mime-map.json
{
    "mimeTypes": {
        "js": "text/javascript",
        "mjs": "text/javascript",
        "cjs": "application/node",
        "json": "application/json"
    }
}

When we import it, we are unable to use this as a general record object despite that being the intention of the value:
import mimeMap from "./mime-map.json" assert { "type": "json" };

const extension: string = getExtensionSomehow();
// Element implicitly has an 'any' type because expression of type 'string' can't be used to index type '{ js: string; mjs: string; cjs: string; json: string; }'.
const mimeType = mimeMap.mimeTypes[extension];

if (mimeType === undefined) {
    // ...Unrecognized file type
} else {
    // ...do something with the type
}

This happens because the inferred type is too narrow, now there's no way that TS could know this directly, however JSON schema is an existing mechanism for declaring such types.
For example if I were to define the schema:
// mime-map.schema.json
{
    "$schema": "http://json-schema.org/schema",
    "type": "object",
    "properties": {
        "mimeTypes": {
            "type": "object",
            "additionalProperties": {
                "type": "string"
            }
        }
    }
}

This would effectively declare a JSON object of type:
{
    mimeTypes: Record<string, string>
}

Existing tooling already has support for such schemas, for example VSCode can already recognize incorrect types in a file which such a schema:

It would be nice if TS could also recognize JSON schema types, and generate appropriate TS types for them so that types when imported correspond more appropriately.
💻 Use Cases
The core use case is that JSON types would more accurately represented by TS recognizing a JSON Schemas, this would allow the JSON file to evolve more so with TS still being able to receive correct type information about the contents rather than just a best guess based on the object shapes.
Notes
This is a potentially breaking change for existing JSON imports, however in most cases people would probably want the JSON Schema they are using. If there was significant breakage an opt-in might be neccessary e.g. useJSONSchema in tsconfig or similar.

Related: #32063
Personally I don't really like this suggestion. JSON Schema is just too... weird. And support for it would just be half-baked. Many features can't be represented in TypeScript types (e.g. oneOf and not, or propertyNames.pattern and additionalProperties). With some other features it's fairly unclear how TypeScript should behave, for example default: What type should TypeScript use here? The default value is not inserted in the absence of a value, so having an optional property makes most sense and the type provided for the value in default is dropped entirely. Fun fact: The value for default does not have to validate against the schema, you can say the property stores a string, but the default is the number 123.

Fun fact: The value for default does not have to validate against the schema, you can say the property stores a string, but the default is the number 123.

😱

It's mentioned here: https://json-schema.org/understanding-json-schema/reference/generic.html

The default keyword specifies a default value. This value is not used to fill in missing values during the validation process. Non-validation tools such as documentation generators or form generators may use this value to give hints to users about how to use a value. However, default is typically used to express that if a value is missing, then the value is semantically the same as if the value was present with the default value. The value of default should validate against the schema in which it resides, but that isn’t required.

The Venn diagram of things supported by JSON Schema and by TypeScript has substantial area in both non-overlapping regions, including things we're likely to not ever implement (maxProperties, minLength, etc). Without a 1:1 translation between JSON Schema and TS we'd be left making a ton of policy decisions that people might need to be configurable, and it'd just be a huge mess. But this can be done out-of-band by any tool (such tools already exist) according to the particular project's need without any significant damage to the overall scenario.

I'm gonna close this in favour of a more direct TypeScript typings oriented approach.


EnderIO creates some ItemStacks with null Items during startup

I was messing around looking for null items from Forestry and found some in EnderIO too. These are hard to debug when things go wrong so I figured I should pass on the info!
Make sure to check that the block has a corresponding item. For one example, when subclass RubberTreeRamerIC2 is init, GameRegistry.findBlock actually returns Blocks.AIR by default (ugh), which has no item. This affects the sapling items and wood items.
https://github.com/SleepyTrousers/EnderIO/blob/1.8.9-exp/src/main/java/crazypants/enderio/machine/farm/farmers/TreeFarmer.java#L41-L46
Similar issue detected here:
https://github.com/SleepyTrousers/EnderIO/blob/1.8.9-exp/src/main/java/crazypants/enderio/machine/farm/farmers/FlowerPicker.java#L27
and here:
https://github.com/SleepyTrousers/EnderIO/blob/1.8.9-exp/src/main/java/crazypants/enderio/machine/farm/FarmStationContainer.java#L44
and here, use Items.CARROT, Items.POTATO, Items.NETHER_WART, Items.WHEAT_SEEDS,
https://github.com/SleepyTrousers/EnderIO/blob/1.8.9-exp/src/main/java/crazypants/enderio/machine/farm/FarmStationContainer.java#L47-L55

Thx, but actually:
https://github.com/SleepyTrousers/EnderIO/blob/1.8.9-exp/src/main/java/crazypants/enderio/machine/farm/FarmStationContainer.java#L123-L139


Refresh email and folders every so often

Otherwise our mail client isn't that great.

Closed with #61ec4a0bbc04f03d4ff93f5b8132cee0381ab139


new scam link

domain/server info: https://check-host.net/ip-info?host=dicsord.gifts (idk if there's support for english)

How the hell did you know my email
On Sun, Jul 25, 2021, 1:02 PM cipherka, @.***> wrote:

domain/server info: https://check-host.net/ip-info?host=dicsord.gifts
(idk if there's support for english)
[image: image]
https://user-images.githubusercontent.com/32297717/126888269-4e3ba64f-a70d-4ff5-acdb-fedabcca3533.png
You can view, comment on, or merge this pull request online at:
https://github.com/jagrosh/Vortex/pull/103
Commit Summary

new scam link

File Changes

M lists/referral_domains.txt
https://github.com/jagrosh/Vortex/pull/103/files#diff-db4cfe0d8724ad5be59d80a33c51c933f12e79d10ec6fba19b4e13881cc4e84f
(1)

Patch Links:

https://github.com/jagrosh/Vortex/pull/103.patch
https://github.com/jagrosh/Vortex/pull/103.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jagrosh/Vortex/pull/103, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARUUVF7RCITVAB5LVX2EAJ3TZOLHLANCNFSM5A6FD5OA
.

How the hell did you know my email

what

This is the point where you might want to delete your GitHub account @nonamemyna. Learn about how you can delete your GitHub account here: https://docs.github.com/articles/deleting-your-user-account

I'ld start by UNWATCHING the repo, because github sends emails like these if you watch a repo.


Create or update registration contact on Vumi

@imsickofmaps Please review.

first pass done, some small fixes, then I'll re-review

@imsickofmaps Ready for re-review.

One minor - then :+1:


Main

Pull request to add a community PocketBase provider for Refine ( not my work juststumled upon it )

@tigawanna This has merge conflicts, can you please let me know the status or close it if it's not needed anymore?


Add react-hot-loader and update text editors

This update does a few things:

Adds react-hot-loader to the dev project to allow for hmr.
Updated the dev project to put the css in a separate file
Along with moving the nav bar to the bottom and preventing it from causing the screen to scroll
Commented out the ACCESS_TOKENS import to something that is not committed to the repo, (would cause errors immediately even for anyone not using Satellite Maps)
ran fixpack on package.json ✨
Fixed text editors stretching due to long lines/content -- resolves #300

I'm late to the party here but I'll just mention that there's very little to gain in refactoring the dev app by splitting it up into multiple files etc... It's meant to be as easy to hack on as possible, and not to grow unduly :)

Totally agree :) I tried to not add much, I mostly did it to wrap the app in the hot loader, and to locate all css modification to one place so people wouldn't have to look around. If it's too much though I'd be happy to remerge them 👍

Definitely not worth spending additional time undoing it, just wanted to make sure we don't spend additional time cleaning that app up more :)

But wow NICELY DONE on getting HMR to work here! I spent a good 30min on it and didn't manage to make it work... 👍 👍 👍

I actually thought HMR was not possible with the way we are wrapping components etc... I'll have to backport this config to react-pivottable

Yeah react-hot-loader is great -- make sure to pull from @next when adding it!


correct the emoji list for Windows OS and categories updation

Details
Initialize the emoji list based on the OS and for windows remove the last category of FLAGS
Fixed Issues

$ https://github.com/Expensify/App/issues/15106
PROPOSAL: https://github.com/Expensify/App/issues/15106#issuecomment-1433091340
Tests

Open emoji picker
Reach the end and try to navigate more with the arrow keys
Verify there isn't any console error (needs to test in Windows OS browser for larger screen)

[X] Verify that no errors appear in the JS console

Offline tests

Open emoji picker
Reach the end and try to navigate more with the arrow keys
Verify there isn't any console error (needs to test in Windows OS browser for larger screen)

QA Steps

Open emoji picker
Reach the end and try to navigate more with the arrow keys
Verify there isn't any console error (needs to test in Windows OS browser for larger screen)

[X] Verify that no errors appear in the JS console

PR Author Checklist

[X] I linked the correct issue in the ### Fixed Issues section above
[X] I wrote clear testing steps that cover the changes made in this PR

[X] I added steps for local testing in the Tests section
[X] I added steps for the expected offline behavior in the Offline steps section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[X] I included screenshots or videos for tests on all platforms
[X] I ran the tests on all platforms & verified they passed on:

[X] Android / native
[X] Android / Chrome
[X] iOS / native
[X] iOS / Safari
[X] MacOS / Chrome / Safari
[X] MacOS / Desktop

[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[X] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I followed the guidelines as stated in the Review Guidelines
[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] I verified that if a function's arguments changed that all usages have also been updated correctly
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[X] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://user-images.githubusercontent.com/14358475/220980069-83943148-3b50-4aa0-9bf1-c736368d2c85.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop
https://user-images.githubusercontent.com/14358475/220984889-5d334dea-17c8-4651-a95c-bbe5661d6f2b.mov

iOS

Android

@Gonals @sobitneupane One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

🚀 Deployed to staging by https://github.com/Gonals in version: 1.2.77-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.2.77-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


KAFKA-5501 [WIP]: use async zookeeper apis everywhere

Synchronous zookeeper writes means that we wait an entire round trip before doing the next write. With respect to the controller, these synchronous writes are happening at a per-partition granularity in several places, so partition-heavy clusters suffer from the controller doing many sequential round trips to zookeeper.

PartitionStateMachine.electLeaderForPartition updates leaderAndIsr in zookeeper on transition to OnlinePartition. This gets triggered per-partition sequentially with synchronous writes during controlled shutdown of the shutting down broker's replicas for which it is the leader.
ReplicaStateMachine updates leaderAndIsr in zookeeper on transition to OfflineReplica when calling KafkaController.removeReplicaFromIsr. This gets triggered per-partition sequentially with synchronous writes for failed or controlled shutdown brokers.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/5686/
Test PASSed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/5672/
Test PASSed (JDK 8 and Scala 2.12).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/6092/
Test PASSed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/6077/
Test PASSed (JDK 8 and Scala 2.12).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/6161/
Test FAILed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/6145/
Test FAILed (JDK 8 and Scala 2.12).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/6189/
Test PASSed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/6173/
Test PASSed (JDK 8 and Scala 2.12).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/6286/
Test FAILed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/6270/
Test FAILed (JDK 8 and Scala 2.12).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/6287/
Test PASSed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/6271/
Test PASSed (JDK 8 and Scala 2.12).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/6309/
Test FAILed (JDK 8 and Scala 2.12).

@onurkaraman : Thanks for the latest patch. LGTM.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/6341/
Test PASSed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/6326/
Test PASSed (JDK 8 and Scala 2.12).