Modify version resolution s.t. we select the highest version possible

Resolves #16.
Context
When faced with multiple potential versions, Maven selects the highest matching version, if a range is provided. The resolver did not. Instead, it would guess a potential version, without examining the available versions. The following design document discusses the issues present with the prior implementation. In addition, it proposes a solution for how to incorporate backtracking and SAT solving to resolve versioning conflicts.
What has changed?

Commit 1: Resolver was refactored so that SHA1 downloading and versioning were in separate classes. Relevant tests were also moved to their own separate classes
Commit 2: Version resolution was changed. Now, when requesting a version for an artifact, resolver scrapes maven central for all available versions, and selecting a version that fits within the provided range. Prior implementation had a number of edge cases that were not in compliance with how maven specs. Tests were added for each case.

For example, (2,3) would throw an exception. "2.3" did not get the highest version. [2.3,) would return 2.3, irrespective of whether there were later versions. (,4.0] would unintentionally throw an exception. Not providing a version would also throw an exception, instead of returning highest version.

What is not implemented?

Support for Sequences of Versions: For example, one can provide a version specification like "(,1.1),(1.1,). This excludes version 1.1.
Support for Non-maven central repositories:
Version Conflict Resolution: This is a naive greedy implementation. The emphasis is on resolving versions for a given artifact. It is unknown how it will behave on POM files or multiple artifacts with conflicting versions. However, it will perform no worse, than the existing implementation.

Reviewers: @kchodorow, @katre
CC: @hhclam, @jin

Sorry for the large CL. Much of the 600 lines comes from refactoring and writing test cases.

per our offline discussion, i'm going to close this pull request.


Update global-data.js

👷 Deploy Preview for resilient-rabanadas-125ad7 processing.

Name
Link

🔨 Latest commit
8668bc3a24d7365ce8f82c082359ae923da2c25f

🔍 Latest deploy log
https://app.netlify.com/sites/resilient-rabanadas-125ad7/deploys/641d0dc544d0c70008ba99a2


How to get (ref_sift_fea_300.pkl (68G) and ref_sift_name_300.pkl (25G))?

Hi, you only say
Firstly, you need extract all local features of reference images by multi_extract_sift.py

However, how to run this python file to get pkl files?
Thanks.

Hello, have you found a solution and how to solve this problem

Please ask the authors directly.


fix: don't cache static resources between releases

add a query string with the version on our static resources, to avoid caching issue between releases
don't recompile the go templates each time (unless we're in dev mode)

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign vbehar
You can assign the PR to them by writing /assign @vbehar in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign vbehar
You can assign the PR to them by writing /assign @vbehar in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/approve

/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: vbehar
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [vbehar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: vbehar
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [vbehar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


fix#840 - handle empty log returned from API on refresh

Fixes
This pull request fixes #840
Description
Instead of returning HTTP 200 OK and null result, return 404 to indicate no logObject, this will prevent the GUI from crashing when refreshing empty logs
Type of change

Bugfix

Impacted Areas in Application
API, GUI
Checklist:
Communication

[x] PR is related to an issue
[ ] I have made corresponding changes to the documentation

Code quality

[x] Code follows the style guidelines
[x] I have self-reviewed my code
[x] No new warnings are generated

Test coverage

[x] Existing tests pass
[ ] New code is covered by passing tests

Further comments

closing for now, may be reopened


Feature

re-adding greetings message

Were these removed?

Just checked and it is still in the code, you just need to specify the greeting parameter in PapercupsIntl if using the beta version or in Props if using stable.


Release builds broken

Debug builds are working for both desktop and wasm.
release-safe compiles successfully but crashes at runtime. In the wasm build, it crashes in onAnimationFrame. In the desktop build, I think it might be crashing in the tick function.
release-small and release-fast fail during compilation (zangc bug - https://todo.sr.ht/~dbandstra/zang/24). I could change build.zig to always build zangc in debug mode, and then see what happens.
All these problems are present on both 0.6.0 and today's (2020-09-27) zig master.

The second issue (small/fast) has been worked around, but release-safe problem is outstanding.

Now ReleaseSafe works on desktop, but wasm is still broken, guess it was unrelated.

Wasm build fixed. Hopefully that's all of them


Restart task doesn't work when Lexical failed to start

Install an incompatible version of erlang, try to open your project, then try the restart LS task. it should show this error. The reason I found this is because I updated the version so wanted to get Lexical to recognize it without restarting VSCode. It seems like when it breaks due to version error it can't find this task. From Discord user blond11516:

Blond: That's a vscode extension issue. The task isn't registered when lexical fails to start because it doesn't re-evaluate the start script path; it only tells vscode to restart the path it already has. I thought vscode wouldn't expose the task if it isn't registered but apparently that was a bad assumption

Hi @bbhoss! Sorry for the long delay, I've been busy all week. I was wondering if you had any othe errors when trying to open your project with an incompatible Erlang?
For example, I get these errors when I do. They get dismissed automatically though, so it's easy to miss them if you look away after opening a project:

Also, just to make sure I understand the reproduction steps correctly, you did something along those lines:

Have the project configured to use incompatible Erlang version A (through asdf, global install or whatever)
Open the project in VSCode
Notice incompatible Erlang version
Update Erlang version to compatible version B
Try to restart Lexical through the command
All without updating Lexical itself?

I've opened #63, which fixes the issue (assuming I understood it correctly). I'd appreciate it if you could take some time to try it out and see if it works as you expected @bbhoss. Thanks!


[firebase_messaging] class file for com.google.firebase.messaging.FirebaseMessagingService not found

Somewhere between firebase_messaging 6.0.1 and the lastest 6.0.9 the plugin broke for me.
I followed the instructions and created an Application.java file (I changed the package):
package io.flutter.plugins.firebasemessagingexample;

import io.flutter.app.FlutterApplication;
import io.flutter.plugin.common.PluginRegistry;
import io.flutter.plugin.common.PluginRegistry.PluginRegistrantCallback;
import io.flutter.plugins.GeneratedPluginRegistrant;
import io.flutter.plugins.firebasemessaging.FlutterFirebaseMessagingService;

public class Application extends FlutterApplication implements PluginRegistrantCallback {
  @Override
  public void onCreate() {
    super.onCreate();
    FlutterFirebaseMessagingService.setPluginRegistrant(this);
  }

  @Override
  public void registerWith(PluginRegistry registry) {
    GeneratedPluginRegistrant.registerWith(registry);
  }
}

After upgrading to 6.0.9, I receive the following compile-time error:
Application.java:13: error: cannot access FirebaseMessagingService
    FlutterFirebaseMessagingService.setPluginRegistrant(this);
                                   ^
  class file for com.google.firebase.messaging.FirebaseMessagingService not found
1 error

0.6.4
Through testing every version, I found out that the upgrade to 0.6.4 is faulty. There are only versions 0.6.3 and 0.6.7 on Pub, but the versions in between did not touch Android at all, so it has to be 0.6.4.
Instructions
Step 5 in the Android integration instructions for handling background messages states the following:

Note: configure should be called early in the lifecycle of your application so that it can be ready to receive messages as early as possible. See the example app for a demonstration.

This is somewhat false because background messages are not configured at all in the example project. Adding it to the example project would also allow testing it.

Facing exactly same issue. Any solution for it?

@zeromaro Yes! Check #1664. Read the first step of the updated instructions. It should be pushed to Pub soon :)

I have same problem, I seen updated instructions and add firebase_messaging library to app build.gradle dependencies section:
dependencies {
  // ...

  implementation 'com.google.firebase:firebase-messaging:20.1.0'
}

thanks its work for me

thanks! my project is alive again!

project > build.gradle
ext.kotlin_version = '1.3.50'
classpath 'com.android.tools.build:gradle:3.5.3'
classpath 'com.google.gms:google-services:4.3.3'

app > build.gradle
    implementation "com.google.firebase:firebase-messaging:20.1.0"

pubsec.yaml
   firebase_messaging: ^6.0.9


[WIP]add huawei cce driver

Need to wait for https://github.com/orangedeng/kontainer-engine-driver-huawei repo being transferred to rancher and releasing a new driver.

LGTM


Add critic policies based on severity with optional blacklist

Requires #121 and #119
Fixes #120

@ned21 i also monkey patched the critic bug, so we no longer need the no critic magic for scripts while we can still check for the version in modules.

@jrha added to 16.12 meaning please include in new maven build tools 😉

@ned21 rebased


TLSv1.3: Verify that key change messages end on a record boundary

Checklist

[x] tests are added or updated

Description of change

TLSv1.3 has 3 handshake messages (ServerHello, Finished and KeyUpdate) that signal a change in the keys being used. Because keys are changing it is important (and a requirement of the spec) that the end of those messages must coincide with the end of the record. Otherwise we could process data believing it have been decrypted with the new keys, but actually it was decrypted prior to the key change using the old keys. This also adds tests for the 3 key change scenarios.
In passing this fixes an SSL_has_pending() bug which did not recognise decrypted handshake data that has not yet been read as "pending".
The first commit is also for 1.1.0.

Updated with requested changes.

Added a new commit to fix the travis failure (the number of tests to skip was wrong if TLSv1.3 was disabled). @richsalz please reconfirm.

reconfirm

Pushed. Thanks.


Segfault in lean::erase_irrelevant_fn::visit

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:

Checked that your issue isn't already filed.
Reduced the issue to a self-contained, reproducible test case.

Description
While working with mathport I encountered a reproducible segfault occurring while in lean::erase_irrelevant_fn::visit.
Crash report
Currently mathport is using leanprover/lean4:nightly-2021-10-02, so if there is any reason to expect this has been fixed since then, let me know and I will bump mathlib4 + mathport and try again.
Steps to Reproduce
I've uploaded a large (~500mb!) archive snapshot the allows reproducing the crash, but it's about as far as possible from "minimal"!
Note that the setup in this archive is not meant to actually work; it's midway through preparing a new makefile for mathport.
wget https://tqft.net/mathport-crash-2021-10-07.tar.gz
tar zxf mathport-crash-2021-10-07.tar.gz
cd mathport
rm -rf build && make build
make port-mathlib

(Note that make build sometimes crashes with the "mutex lock failed" problem previously reported and fixed. If so, just run make build again.)
Expected behavior:
Anything except a segfault. (This makefile isn't expected to work, so likely there should be an error here rather than a segfault.)
Actual behavior:
The make build step may take a few minutes. (Not necessary if reproducing on macos, but I presume necessary elsewhere.)
The make port-mathlib steps ends after a few seconds with make: *** [port-mathlib] Error 1, and Command terminated abnormally. in Logs/mathport.err and a .crash file in Console (or other OS equivalents).
Reproduces how often: [What percentage of the time does it reproduce?]
Every time.
Versions
leanprover/lean4:nightly-2021-10-02

While it doesn't seem likely if this one is perfectly reproducible, would be great to check if it still occurs after the "mutex lock failed" fix. After that, I think we'd need someone to run this with a sanitized build (for which we don't currently have artifacts for macOS, and which will also be ~10x as slow).

I re-ran after bumping everything to nightly-2021-10-07, which should include the "mutex lock failed" fix, and got the exact same error.
I haven't used a sanitized build: can I get one just by building Lean4 with CMAKE_OPTIONS:
-DLEAN_EXTRA_CXX_FLAGS=-fsanitize=address,undefined -DLEANC_EXTRA_FLAGS='-fsanitize=address,undefined -fsanitize-link-c++-runtime' -DSMALL_ALLOCATOR=OFF -DBSYMBOLIC=OFF

or are there additional changes/steps? (Those options are what's in .github/workflows/ci.yml.)

@semorrison Could you please try using the commit above? We are wondering whether it will trigger a runtime assertion violation.

Yes, now we get:
LEAN ASSERTION VIOLATION
File: /Users/scott/projects/lean/lean4/src/library/compiler/erase_irrelevant.cpp
Line: 319
args.size() == 3


feature: Created by field in all the tables is static. It should be the username

Feature Request
Describe the Feature Request

Created by field in all the tables is static. It should be the username of created user.
Is your feature request related to a problem? Please describe

Describe Preferred Solution

Additional Context

It must be asked to keycloak endPoint. See on header.component.ts line 48 to get token details (all user details)

See enviroment to se conection to keycloak details


Treat the axe as a weapon and let it get attack damage modifiers/luck

Make sure you are not opening a duplicate.

[ ] I have searched the issue tracker and did not find an issue describing my bug.

Description of your suggestion.
Simple as that. I didn't realize till now that swords get a % based increase on their damage if they have the right attributes and as an axe player, it would be nice to get those changes on an axe as well, even if there needs to be a reduction for balancing purposes or otherwise.

Figured it out on my own after sniffing around the the .jar files. Just added the "c:axes" tag to all the melee weapon attributes

you don't have to modify the jar itself, just create a separate datapack.


[RFE] Option to provide data-dir for RKE2 provisioned by Rancher

PLACEHOLDER
SURE-5886

UI Changes tracked here, which should be QA'd at same time as these changes https://github.com/rancher/dashboard/issues/10824

@susesgartner @jakefhyde do you have any information about systemAgentVarDir, caprVarDir and dataDir fields in terms of specs? (are they strings, arrays, objects, etc)? Do they have default values? Also, in which category of the cluster provisioning UI would they fit?
Adding a screenshot of the current UI for provisioning RKE2 clusters for context:

FYI @richard-cox

@jakefhyde FYI, UI work has been done and merged for this feature. Covered by unit tests. Assuming feature e2e testing will be done by backend QA.

Regarding release-note label, we will need to not only release note the new feature but the known limitation (https://github.com/rancher/rancher/issues/46066) that we're planning to fix in the next RKE2 release.

Ticket #45038 - Test Results - ✅

Scenario
Test Case
Result

1.
Provision cluster with default data dirs
PASS

2.
Provision cluster with different data dirs
PASS

3.
Provision cluster with shared data dir.
PASS

4.
Upgrade rancher cluster with CATTLE_AGENT_VAR_DIR set.
PASS

5.
Snapshot restore with default data dirs
PASS

6.
Snapshot restore with different data dirs
FAIL

7.
Snapshot restore with shared dirs
FAIL

Verified with (HA Helm or Docker) on Rancher v2.9-b573c957ab78a1121888c6b7d73d787efc479d7f-head:
Scenario 1: Provision cluster with default data dirs
NOTE: Performed on RKE2 and K3s with custom and node driver clusters

Create a 3 node split role cluster
Wait for the cluster to finish provisioning.
Create a test container on the cluster and verify it comes up active

Results: The cluster provisions successfully and all pods are in a good state.

Scenario 2: Provision cluster with different data dirs
NOTE: Performed on RKE2 and K3s with custom and node driver clusters

Create a 3 node split role cluster and a custom dir for System-agent, provisioning and k8s distro
Wait for the cluster to finish provisioning.
Create a test container on the cluster and verify it comes up active

Results: The cluster provisions successfully and all pods are in a good state.

Scenario 3: Provision cluster with shared data dir
NOTE: Performed on RKE2 and K3s with custom and node driver clusters

Create a 3 node split role cluster and provide a shared directory in the cluster config
Wait for the cluster to finish provisioning.
Create a test container on the cluster and verify it comes up active

Results: The cluster provisions successfully and all pods are in a good state.

Scenario 4: Upgrade rancher cluster with CATTLE_AGENT_VAR_DIR set.
NOTE: Performed on RKE2 and K3s with custom and node driver clusters

Create a rancher cluster on 2.8-head
Create a downstream 3 node split role cluster and provide the CATTLE_AGENT_VAR_DIR env var
Wait for the cluster to finish provisioning.
Create a test container on the cluster and verify it comes up active
Take a snapshot
Upgrade the cluster to 2.9-head
Restore the snapshot
Verify the cluster remains in a healthy state and the CATTLE_AGENT_VAR_DIR is no longer present on the cluster

Results: The cluster remained in a good state after the upgrade and snapshot.

Scenario 5: Snapshot restore with default data dirs
NOTE: Performed on RKE2 and K3s with custom and node driver clusters

Create a 3 node split role cluster
Wait for the cluster to finish provisioning.
Take a snapshot
Upgrade the k8s version
Restore the snapshot

Results: The snapshot successfully restores and all pods remain in a healthy state

Scenario 6: Snapshot restore with different different data dirs
NOTE: Performed on RKE2 and K3s with custom and node driver clusters

Create a 3 node split role cluster and a custom dir for System-agent, provisioning and k8s distro
Wait for the cluster to finish provisioning.
Take a snapshot
Upgrade the k8s version
Restore the snapshot

Results: The cluster hangs and the snapshot fails to restore
Scenario 7: Snapshot restore with shared data dirs
NOTE: Performed on RKE2 and K3s with custom and node driver clusters

Create a 3 node split role cluster and provide a shared directory in the cluster config
Wait for the cluster to finish provisioning.
Take a snapshot
Upgrade the k8s version
Restore the snapshot

Results: The cluster hangs and the snapshot fails to restore
Additional notes: The failures have been release noted and an issue has been opened

Discussed offline. The issue found - https://github.com/rancher/rancher/issues/46066 will be fixed in the next release.


update travis.yml to send notifications to Slack on build failures

can we reuse https://github.com/apache/incubator-openwhisk/blob/master/.travis.yml#L29-L41 ?

No, travis uses a repo-specific key to encrypt the URL.  I can take care of doing it today.


[WIP] Add Redis Caching

This is attempting to add object and page caching with Redis.
closes #53

Pull Request Test Coverage Report for Build 243

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 239:
0.0%

Covered Lines:
500

Relevant Lines:
500

💛  - Coveralls


test_hardware: rotate the SPI bus numbers

The SPI bus order has seemingly shifted by one position with the update to kernel 6.11, resulting in the following build errors:
05:45:11 FAILED tests/test_linux_hardware.py::test_linux_spi_1_adc - labgrid.driver.exception.ExecutionError: ('cat /sys/bus/spi/devices/spi1.0/iio\\:device3/in_voltage_raw', ["cat: '/sys/bus/spi/devices/spi1.0/iio:device3/in_voltage_raw': No such file or directory"], [])
05:45:11 FAILED tests/test_linux_hardware.py::test_linux_spi_2_lcd - labgrid.driver.exception.ExecutionError: ('cat /sys/bus/spi/devices/spi2.0/graphics/fb0/name', ['cat: /sys/bus/spi/devices/spi2.0/graphics/fb0/name: No such file or directory'], [])

I've marked this PR as a draft since just adapting to the new order and hoping that it does not change again is a bit of a hack.
We should check first if we can make the bus number assignment stable before we change it here.

As you already suggested, better use DT aliases:
https://elixir.bootlin.com/linux/v6.11.5/source/arch/arm/boot/dts/st/stm32mp157a-stinger96.dtsi#L15

I've prepared a pull request to set fixed SPI bus numbers via aliases: https://github.com/linux-automation/meta-lxatac/pull/205 .
With this PR applied the bus number associations are the following:

Linux bus number
STM32 SPI peripheral
Connected Peripherals

0
2
Power Board ADC

1
4
LCD Display

2
5
Ethernet Switch

E.g. order the Linux bus numbers based on the STM32 peripheral numbers and leave out unused peripherals.
This new numbering matches the numbering introduced in this labgrid-lxatac PR.
So we should thus merge both:

https://github.com/linux-automation/meta-lxatac/pull/205 and
https://github.com/linux-automation/labgrid-lxatac/pull/4


updated Get-UserRightPolicy to return Identity as array

Addresses issue in #69 where Get-DscConfiguration can fail

This change is

Codecov Report

Merging #70 into dev will not change coverage.
The diff coverage is 100%.

@@        Coverage Diff        @@
##           dev   #70   +/-   ##
=================================
  Coverage   81%   81%
=================================
  Files        5     5
  Lines      417   417
=================================
  Hits       338   338
  Misses      79    79


Map of objects is not supported by http.post

Hi there,
Thanks alot for implementing this quickly on dart.
I have a function that accepts
{
    "creator": {
        "id": "id",
        "name": "Kosh ",
        "picture": ""
    },
    "receiver": {
        "id": "id",
        "name": "Kosh2 ",
        "picture": ""
    },
    "notificationType": "FOLLOW",
    "body": "",
    "challengeId": "",
    "notificationId": ""
}

while calling function.invoke(body:  myObject.toMap()) throws an error and after following the source of the error I found that dart http does not really support Map<String, dynamic> however only accepts Map<String, String> which resulted in an error that is hard to figure.
the solution was to create an extension on Functions and do below:
extension BoltsFunction on FunctionsClient {
  Future<FunctionResponse> stringInvoke(
    String url,
    String functionName, {
    required Map<String, String> headers,
    required String body,
  }) async {
    try {
      final response = await http.post(
        Uri.parse('$url/$functionName'),
        headers: headers,
        body: body,
      );

      dynamic data = json.decode(response.body);
      return FunctionResponse(data: data);
    } catch (error) {
      return FunctionResponse(error: error);
    }
  }
}

And body in here is just a
json.encode({
      'receiver': receiver.toShortMap(),
      'creator': creator.toShortMap(),
      'notificationId': notificationId,
      'challengeId': challengeId,
      'body': body,
      'notificationType': notificationType.name,
    })

I will open a PR that fixes this and instead of using map<String, dynamic> we should accept dynamic allowing callers to determine the type themselves.
here is what http does eventually with body.
if (body != null) {
      if (body is String) {
        request.body = body;
      } else if (body is List) {
        request.bodyBytes = body.cast<int>();
      } else if (body is Map) {
        request.bodyFields = body.cast<String, String>();
      } else {
        throw ArgumentError('Invalid request body "$body".');
      }
    }

@k0shk0sh So sorry for not being able to look at this issue and the PR you have created. Hopefully this PR fixes the issue you are having.


Documentation: String

Adapted from https://github.com/rescript-lang/rescript-compiler/blob/master/jscomp/others/js_string2.ml

@aspeddro is this ready to go?

@aspeddro is this ready to go?

yes


Update to alpha webservice release

Update to 1.5.0 webservice for staging release

@garyluu  ran into issues updating to WS 1.5.0
Note that the enum change was unintentional (looks like swagger doesn't understand custom serializers which broke that particular enum)

In discussion, looks like failures are all unrelated and due to some to do with the order of mocked versions. Re-running

Codecov Report

Merging #281 into develop will decrease coverage by 0.52%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #281      +/-   ##
===========================================
- Coverage    63.39%   62.86%   -0.53%
===========================================
  Files          120      120
  Lines         3614     3708      +94
  Branches       399      428      +29
===========================================
+ Hits          2291     2331      +40
- Misses        1230     1282      +52
- Partials        93       95       +2

Impacted Files
Coverage Δ

src/app/starring/starring.component.ts
48.88% <0%> (-0.32%)
:arrow_down:

src/app/search/search.service.ts
38.8% <0%> (+3.21%)
:arrow_up:

src/app/search/query-builder.service.ts
17.75% <0%> (+4.87%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27e2789...dd1248f. Read the comment docs.

Just a note for what changes I made. If you go to a tool with no version specified then it will fallback to the last element of the versions array. There are definitely better ways to do this, I was just making two parts of the code consistent.


[dropout] Fix for #2858

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[x] Bug fix
[ ] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information
Fixes #2858 by specifying https://www.dropout.tv as the Referer in the request header.

I'm sort of against setting it in std_headers, since now the referrer will be used by all requests (including other unrelated extractors in a batch situation).
From my quick read of the issue, it sounds like we are extracting vimeo links? Maybe it is better to use url smuggling to send referer data to the vimeo extractor?
Fortunately it looks like the vimeo extractor already has handling for this  https://github.com/yt-dlp/yt-dlp/blob/f0734e1190630f4cefa4a2028884413f54310f82/yt_dlp/extractor/vimeo.py#L646-L647
example: https://github.com/yt-dlp/yt-dlp/blob/f0734e1190630f4cefa4a2028884413f54310f82/yt_dlp/extractor/patreon.py#L166-L170

Maybe it is better to use url smuggling to send referer data to the vimeo extractor?

Took a few modifications to VHXEmbedIE, but yeah that's much cleaner. Fixed.

@KathrynElrod any update on the fixes?


Can't access nested resoures id from constructor

Laravel Version: 8.0
PHP Version: 7.4.12

When trying to access nested resource id I got BindingResolutionException:
<?php

namespace App\Http\Controllers\API\V1;

use App\Http\Controllers\Controller;
use Illuminate\Http\Request;

class TestController extends Controller
{
    // throws BindingResolutionException: "Unresolvable dependency resolving"
    public function __construct(Request $request, $wallet_id)
    {
    }
}

// routes/api.php

Route::apiResource('api/v1/wallets.test', 'WalletTestController');

Hi there,
Thanks for reporting but it looks like this is a question which can be asked on a support channel. Please only use this issue tracker for reporting bugs with the library itself. If you have a question on how to use functionality provided by this repo you can try one of the following channels:

Laracasts Forums
Laravel.io Forums
StackOverflow
Discord
Larachat
IRC

However, this issue will not be locked and everyone is still free to discuss solutions to your problem!
Thanks.


User field fixes

Applied complete fix from #27 to other dashboards.

Hi Mattimustang,
Thank you so much for your pull request. We do appreciate your contribution. Unfortunately, I won't be able to merge this specific pull request. There was already a bug reported on this and the fix was implemented and will be available in our next release.
Regards,
Paul Nguyen


Fix typo

I don't think this is a typo, since Moneroj is the plural of Monero

Oh my bad, should've looked it up.


fix: use native exists() method in GSClient

SSIA
Closes https://github.com/drivendataorg/cloudpathlib/issues/356

Contributor checklist:

[x] I have read and understood CONTRIBUTING.md
[x] Confirmed an issue exists for the PR, and the text Closes #issue appears in the PR summary (e.g., Closes #123).
[x] Confirmed PR is rebased onto the latest base
[x] Confirmed failure before change and success after change
[ ] Any generic new functionality is replicated across cloud providers if necessary
[x] Tested manually against live server backend for at least one provider
[ ] Added tests for any new functionality
[x] Linting passes locally
[x] Tests pass locally
[x] Updated HISTORY.md with the issue that is addressed and the PR you are submitting. If the top section is not `## UNRELEASED``, then you need to add a new section to the top of the document for your change.

@pjbull Confirmed, I have this working on an empty GCP bucket.

Thanks @bachya, happy to merge this once the code quality and mocked tests are passing.

Tests need an update in the mocked version (which mock the cloud SDKs):

Update MockBucket to have exists method.
Should be implemented like the Azure backend to just be true for the test.

More info on running the test suite here: https://cloudpathlib.drivendata.org/stable/contributing/#tests

Thanks, @pjbull. I couldn't see the results until you approved the CI run; got them now, and I'll update the tests.

@bachya just fyi, you can run make lint and make test locally so you don't have to wait for the CI runs.

Looks good! I'm going to merge into a repo-local branch so we can run against the live server backends, which is not possible on PRs from forks.


gitbucket in wrapper

i will run gitbucket in wrapper (http://wrapper.tanukisoftware.com/doc/english/download.jsp)
it need a  gitbucket's mainclass (wrapper.java.mainclass=)
could you tell me the mainclass's name ?
i try "JettyLauncher" ,but it not right.

Main class is JettyLauncher.


[Event Request] Codeunit 90 Purch.-Post - OnPostVendorEntryOnAfterInitNewLine

Hi, would it be possible to create a new event OnPostVendorEntryOnAfterInitNewLine in codeunit 90 Purch Post, like this :

?
Thanks

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


[rocketpool-node-operator-delegate-v7] Added the rocket-pool-node-operator-delegate-v7 strategy

Added the delegate side of the v7 strategy

@nickdoherty Tests are failing, could you taka a look plz

@ChaituVR fixed.


[Chain] flatten fails with different random variables in samples

At the end of each sample function call, the samples are wrapped with a Chain object. Yet, during the construction of such an object, it is explicitly assumed that the set of random variables is fixed for all samples. Unfortunately this is not true for BNP models.
@yebai would you know how this could be extended for these cases ? What are the constraints of the Chains object's constructor ?

We discussed how to support this in the past. We feel the best way of supporting this is to trim the set of random variables before storing them in Chain. The interface that implements this trimming is through the return statement (see https://github.com/yebai/Turing.jl/issues/104#issuecomment-292253860). Unfortunately, this interface is not complete yet, see e.g. https://github.com/yebai/Turing.jl/issues/81.
@xukai92 Do you remember the status of the return statement?

@yebai would you know how this could be extended for these cases ? What are the constraints of the Chains object's constructor ?

It’s possible to extend the Chain data structure, but I think it involves a lot of work. Since all chai related functions implicitly assume that each sample’s dimension is the same. Perhaps for now we can start by using the largest dimension of all samples, and treat missing dimensions as missing data - there are some Stats packages for handling missing data, it might be possible to combine them with Mamba so that Chain’s utility functions can correctly handle missing dimensions.

@yebai It seems that Chain is fed with a matrix, so we could take the union of all random variable names, and fill with NaN values in samples that do not have some random variables.

Perhaps the following package can solve our problem here. My suggestion is that we first try to replace the matrix type of Chain with DataArray, and see whether existing Mamba utility functions can correctly work.
https://github.com/JuliaStats/DataArrays.jl

DataArrays.jl (along with Missing.jl) seem to be unable to solve the problem as
import DataArrays: @data
a = Missing()
v = @data([1,2,a,4])
mean(v) # => missing

which will make Mamba.jl unable to use Chain

According to Missing.jl's documentation, its default behavior for missing values is as follows
The package defines standard operators and functions which propagate missing values: for example 1 + missing and cos(missing) both return missing.

We might need to adopt this package for our purpose - but this is not urgent.

I think we may need another field in VarInfo called mark to mark variables as missing. This filed can also be used to solve #389 as I commented.

I think we may need another field in VarInfo called mark to mark variables as missing. This filed can also be used to solve #389 as I commented.

I might be wrong - I think what @emilemathieu  is proposing in #395 no longer need a marker for deleted entries from VarInfo.

I agree @yebai, we don't need such a field with that solution (at least not for the random order of random variable issue).

Yes. I'm proposing this mark for more general purpose of usage, e.g. #389. And I think my use of NaN looks not elegant...

One way to deals with that is something like
sample(model::Function, alg::...
...
try
  c = Chain(loge, samples)
catch
  c = samples
end


(wip): YJDH-25: base ui layout + translations + run tests sequentially

Description :sparkles:
Issues :bug:
Testing :alembic:
Screenshots :camera_flash:
Additional notes :spiral_notepad:

Codecov Report

Merging #104 (7ce9275) into develop (72ba8ca) will decrease coverage by 26.57%.
The diff coverage is 58.40%.

@@             Coverage Diff              @@
##           develop     #104       +/-   ##
============================================
- Coverage    59.40%   32.82%   -26.58%
============================================
  Files          193       88      -105
  Lines         3286     1054     -2232
  Branches       214      153       -61
============================================
- Hits          1952      346     -1606
+ Misses        1298      682      -616
+ Partials        36       26       -10

Impacted Files
Coverage Δ

frontend/kesaseteli/employer/jest.config.js
0.00% <ø> (ø)

...rontend/kesaseteli/employer/next-i18next.config.js
0.00% <0.00%> (ø)

...li/employer/src/backend-api/BackendAPIProvider.tsx
0.00% <0.00%> (ø)

frontend/kesaseteli/employer/src/hocs/withAuth.tsx
100.00% <ø> (ø)

.../kesaseteli/employer/src/hocs/withAuthRedirect.tsx
100.00% <ø> (ø)

...ntend/kesaseteli/employer/src/hocs/withoutAuth.tsx
100.00% <ø> (ø)

frontend/kesaseteli/employer/src/pages/_app.tsx
0.00% <0.00%> (ø)

frontend/kesaseteli/employer/src/pages/login.tsx
0.00% <0.00%> (ø)

frontend/shared/.eslintrc.js
0.00% <ø> (ø)

frontend/shared/jest.config.js
0.00% <ø> (ø)

... and 178 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72ba8ca...7ce9275. Read the comment docs.


jsconfig.json guidance: never getting 'configure excludes' on Linux

Related to #4007

OS Version: Linux

Steps to Reproduce:

open vscode repo, open any .js file, generate jsconfig.json
modify jsconfig.json such that nothing is excluded
Wait some time and trigger inteli-sense in .js -> notice exception
I am never offered to 'configure excludes', I only see this on Linux, it works nicely on OS X

You must not have too many files cos we aren't on the latest TS server version.

related to #4185

Got it, but why does this work on OS X then?

different nodejs versions?

might be that...

I am not getting prompted on OSX.
Node version v4.3.1
Create a workspace using ember new bigApp
Open app/app.js
accept prompt to create jsconfig.json
edit jsconfig.json to remove folders from exclude section
reload window
result -> not prompted to add exclude information.
I see this in the console:
//Applications/Visual Studio Code - Alpha.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:91 [Extension Host] Error: Service died.
    at /Applications/Visual Studio Code - Alpha.app/Contents/Resources/app/extensions/typescript/out/typescriptServiceClient.js:187:46
    at Array.forEach (native)
    at TypeScriptServiceClient.serviceExited (/Applications/Visual Studio Code - Alpha.app/Contents/Resources/app/extensions/typescript/out/typescriptServiceClient.js:186:37)
    at ChildProcess.<anonymous> (/Applications/Visual Studio Code - Alpha.app/Contents/Resources/app/extensions/typescript/out/typescriptServiceClient.js:137:31)
    at emitTwo (events.js:92:20)
    at ChildProcess.emit (events.js:172:7)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)

here is my jsconfig.json:
{
	"compilerOptions": {
		"module": "commonjs"
	},
	"exclude": [

	]
}

After upgrading my node version on linux I no longer see this


Array validation

Is there a way to validate that a given schema key is an array, but to completely skip validation of its elements? Something similar to the blackbox option, but for arrays instead of objects.
I'm using simple-schema with Blaze to validate the data context of my templates. One of my templates requires a very large dataset - essentially an array of arrays of x, y pairs of integers (so something like [[x, y]]). I don't need to validate the inner [x ,y] pairs at all, as doing so considerably slows down the template rendering time - but I do want to be able to validate that the outer array is, in fact, an array.
Any help or tips would be appreciated!

Blackbox arrays has been requested before, although I can't find an issue for it at the moment. I think it should be possible to add it.


Adding a Cell directly within a Cell (without using a CellReference) causes "missing ENDSTR record" error when trying to open the GDS file that is written out

Calling Cell.add() works fine with the LayoutViewer, but when the layout is then written to a GDS file, trying to open it up in Clewin 5 causes a "missing ENDSTR record" error. Trying to open it up in KLayout also causes an error.
Suggested fix is that trying to add a Cell directly to another Cell just inserts a CellReference at position (0,0), or something similar. Or maybe just throw an error? I'm sure trying to get the file to write correctly would take more time than either of these other two options.

@peterxsu This is more an issue of the documentation than error-checking. Currently we don't do error-checking in the user input — the user is responsible for passing the correct arguments to the library.
I've fixed the documentation for Cell.add accordingly in 08f6e5a

suggest to update "def add()" in the "calss Cell" as below, and then cell be added directly in the cell
def add(self, element,*args, **kwargs):
    if isinstance(element, list):
        for e in element:
            if isinstance(e, Cell):
                self.elements.append(CellReference(e, *args, **kwargs))
            elif isinstance(e, Label):
                self.labels.append(e)
            else:
                self.elements.append(e)
    else:
        if isinstance(element, Cell):
            self.elements.append(CellReference(element, *args, **kwargs))
        elif isinstance(element, Label):
            self.labels.append(element)
        else:
            self.elements.append(element)
    self._bb_valid = False
    return self

@harrywang2018 That would implicitly create a CellReference which can be confusing... "Explicit is better than implicit."


Add array_replace_keys function

@equip/contributors Any thoughts on this PR?

I'd remove the array prefix, as l don't think we're using that elsewhere in this library. Otherwise,  seems fine.

@elazar good suggestion, fixed.

:+1:


Post Content Types

[ ] As an author, posts I create can link to images.
[ ] As an author, posts I make can be in simple plain text
[ ] As an author, posts I make can be in markdown (commonMark is good)

Working on displaying markdown properly


Adapter not starting on JS-Controller 2: "cannot find start file"

Hi, as Apollon77 suggested on the forum I open an issue here:
I've set up a new Proxmox-VM based on Debian 10 to migrate my current iobroker-installation and using the new js-controller 2.x. I followed the instructions and let the fixer do it's work. When I tried to get the lightify-adapters (the soef-one and then the community edition) only 8 adapters (admin, info, discovery and a few more) where already installed, so the system is fresh. The first installations ran without problems under Js Controller 2.1.1, Node 10.18.1 and NPM 6.13.4.
Since the soef edition didn't work I installed the lightify community adapter, set the gateway ip address and get just the following error in the log:
startInstance lightify-community.0: cannot find start file!
The adapter stays red.
So, since I've quite some lightify devices up and running I would really like to have the adapter work on the new setup.
Does anybody else have this issue or an idea what to do?
Thank you, all the best
H.

outdated


superset 0.17.0 can not update

when i excute
superset db upgrade
ImportError: No module named '_sqlite3'
when i change then config.py DB connet
File "/data/py3_superset_env/bin/superset", line 12, in
from superset.cli import manager
File "/data/py3_superset_env/lib/python3.4/site-packages/superset/init.py", line 50, in
for bp in conf.get('BLUEPRINTS'):
TypeError: 'NoneType' object is not iterable

Your python does not have sqlite3, not a superset issue, please close.

https://stackoverflow.com/questions/1210664/no-module-named-sqlite3

0.17.0 is old, we can only afford to pay attention to bugs that can be reproduced on the latest release.


Unpaired Video Translation

Thanks for the great work.
I don't see the Unpaired Video Translation code in the repo., is it available somewhere? I would like to benchmark it against an algorithm I've developed.

Hi @AloshkaD , did you find the Unpaired Video Translation code? Thanks!

@zgzxy001 It's not published yet.


Fix generic styles

Will leave this Pull Request open for now to append super little style fixes.

Makes sense to have a PR open to accumulate improvements?

Very little.
It's mostly because I didn't want to push to development every 5'; also for review purposes, some style fixes are app wide.


Model - aliased table - invalid insert/update statement

Hello. I'm using latest version of Laravel with MySQL driver. When trying to insert/update on aliased table invalid query is produced.
namespace App\Models;

use Illuminate\Database\Eloquent\Model;
use Illuminate\Support\Facades\DB;

class Test extends Model
{
    protected $table = 'test AS t';
}

Test::create([...]);

insert into `test` as `t` (`x`) values (1)

LOG.error: SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'as t

I don't think Laravel supports an aliased $table.

Of course it is:
echo Test::query()->select('id')->toSql();
// select `id` from `test` as `t`

Problem is mysql driver does not allow aliased insert statement.

I think that SELECT queries are accidentally working but $table wasn't meant to be used like that.

Why this issue was closed without any fix? Aliased tables as described are standard and normal behaviour (in opposite to what @staudenmeir is trying to say)

I was only referring to aliases in Model::$table. Of course, you can use aliases with models:
Test::from('test AS t')->get();

Simple solution for this is to remove AS part from the table when using Mysql adapter and update/insert queries.


SimpleSnake example

First shot

Of course. But there have to be examples created first.
Hope SimpleSnake and maybe spome more others example will makes adxe more attractiv for beginners

Finally, it's been tiring to see that same cocos2d sprite in the middle lol


⚠ Processors has degraded performance

In 3509a2b, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 110 ms

Resolved: Processors performance has improved in 7e3c222.


feat: ESLint rule for prefer-use-query

Description
This PR adds an ESLint rule to suggest useQuery instead of using fetch directly.
Opening this as a draft. we will want to wait for https://github.com/Shopify/hydrogen/issues/256 to resolve.

Additional context
For reviewers: Any test cases I might be missing?
Before submitting the PR, please make sure you do the following:

[ ] Add your change under the Unreleased heading in the package's CHANGELOG.md
[ ] Read the Contributing Guidelines
[ ] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123)
[ ] Update docs in this repository for your change, if needed

@cartogram Also, I just noticed we might be moving away from useQuery: https://github.com/Shopify/hydrogen/issues/256

We chatted, and found that it's not even possible to call fetch like normal in server components, so this rule doesn't necessarily apply.


Add a flag for not syncing subcharts

Chart dependencies are already present in the chart packages. Syncing the subcharts from one registry to another is not totally necessary, as they won’t be used for deploying the charts.
We can create a flag that will allow users to skip the sync of these subcharts.

This has been already implemented at #124


Struggling to interpolate a named parameter in a LIKE query

Hi
This should be simple but I have been working on it for about 5 hours. I have a fairly basic named query
`args := map[string]interface{}{
        "limit": q.limit,
        "name":  name,
    }
    query = `
        SELECT
            author, created_ts, id, name, updated_ts
        FROM
            author
        WHERE
            name LIKE '%:name%'
        LIMIT :limit`
    span.LogFields(log.String("db.query", query), log.Object("db.args", args))
    rows, err := q.queryer.NamedQueryContext(ctx, query, args)`

However when calling this, I get
could not determine data type of parameter $1
If I try to cast through various methods (taking into account the escaping required)
'%:name::::text%'
'%:name%'::::text
'%:name%::::text'
I continue to get errors
unexpected : while reading named param at 97
I have tried adding the wildcards to the params and still get the same error.
SELECT
            author, created_ts, id, name, updated_ts
        FROM
            author
        WHERE
            name LIKE :name::::text
        LIMIT :limit"

Note I have tried multiple different permutations of the ::::text in order to escape the named query syntax, however it doesn't seem to make a difference.
Can anyone help here? This feels unusually difficult for a simple query, so I must be missing something.

FFS this actually works. I was sure I tried it already but I must have done something slightly different

args := map[string]interface{}{
		"limit": q.limit,
		"name":  "%" + name + "%",
	}
	query = `
		SELECT
			author, created_ts, id, name, updated_ts
		FROM
			author
		WHERE
			name LIKE :name
		LIMIT :limit`


No detailed and accurate explanation or tutorial for InteractiveScene

I could not use interactive scene. It has the explanation:
"""
    To select mobjects on screen, hold ctrl and move the mouse to highlight a region,
    or just tap ctrl to select the mobject under the cursor.
    Pressing command + t will toggle between modes where you either select top level
    mobjects part of the scene, or low level pieces.
    Hold 'g' to grab the selection and move it around
    Hold 'h' to drag it constrained in the horizontal direction
    Hold 'v' to drag it constrained in the vertical direction
    Hold 't' to resize selection, adding 'shift' to resize with respect to a corner
    Command + 'c' copies the ids of selections to clipboard
    Command + 'v' will paste either:
        - The copied mobject
        - A Tex mobject based on copied LaTeX
        - A Text mobject based on copied Text
    Command + 'z' restores selection back to its original state
    Command + 's' saves the selected mobjects to file
    """

That is not enough to let me know how to see the window and use my mouse and keyboard.
When i use this code:
class ABC(InteractiveScene):
    def construct(self):
        text = Text('ABC')
        self.play(Write(text))

It says:
Media will be written to c:\beibi\a\media\. You can change this behavior with the --media_dir flag.

   There are no scenes inside that module

But if i add "Scene", it will be strange.
class ABC(InteractiveScene, Scene):
    def construct(self):
        text = Text('ABC')
        self.play(Write(text))

Media will be written to c:\beibi\a\media\. You can change this behavior with the --media_dir flag.
And then a window is displayed, but it disappears in an instant. Nothing is displayed.
Please tell me how to use interactive scene correctly. Thanks!
If you want to preview the effect, see: https://www.bilibili.com/video/BV1R34y1W7Xn/?spm_id_from=333.337.search-card.all.click&vd_source=56f860f8bb81d49bdbd9b13dc4731f94
At 05:04, 05:32, etc.

It looks like it's trying to write the scene to file, which would be the case if you passed in the -w or -o flag. In those case, it would not be interactive.  If you call it with something like manimgl file.py ABC, the default should be the preview the scene in a window, where you can then interact with the window.


DPFServerException

Before submitting the issue

[X] I have checked for Compatibility issues
[X] I have searched among the existing issues
[X] I am using a Python virtual environment

Description of the bug
I have just installed the ansys-dpf-core in a python virtual environment (3.10.11). When I try to launch the brief demo it retrieves an error. (File attached)

Steps To Reproduce
Given the ANSYS Student 2023 R2 and the ansys-mapdl-core and ansys-dpf-core installed in a python virtual  environment created in python3.10.11 (upgrade pip). Maybe I missing some envirionment variables I don't know. I have read in some othe other posts that there is a environment variable that I need to set manually so the DPFserver can run. I can't find the post, and I don't remember the name exactly but I remember the value that it must have 'Y' like saying yes to something.
Which Operating System causes the issue?
Windows
Which DPF/Ansys version are you using?
Ansys 2023 R2
Which Python version causes the issue?
3.10
Installed packages
ansys-api-mapdl                       0.5.1
ansys-api-platform-instancemanagement 1.0.0b3
ansys-dpf-core                        0.8.1
ansys-dpf-gate                        0.3.1
ansys-dpf-gatebin                     0.3.1
ansys-grpc-dpf                        0.7.1
ansys-mapdl-core                      0.65.1
ansys-mapdl-reader                    0.52.20
ansys-platform-instancemanagement     1.1.1
ansys-tools-path                      0.3.1
appdirs                               1.4.4
cachetools                            5.3.1
certifi                               2023.7.22
charset-normalizer                    3.2.0
click                                 8.1.6
colorama                              0.4.6
contourpy                             1.1.0
cycler                                0.11.0
fonttools                             4.41.1
geomdl                                5.3.1
google-api-core                       2.11.1
google-api-python-client              2.95.0
google-auth                           2.22.0
google-auth-httplib2                  0.1.0
googleapis-common-protos              1.60.0
grpcio                                1.56.2
httplib2                              0.22.0
idna                                  3.4
importlib-metadata                    6.8.0
kiwisolver                            1.4.4
matplotlib                            3.7.2
numpy                                 1.25.2
packaging                             23.1
Pillow                                10.0.0
pip                                   23.2.1
platformdirs                          3.10.0
pooch                                 1.7.0
protobuf                              3.20.3
protoc-gen-swagger                    0.1.0
psutil                                5.9.5
pyansys-tools-versioning              0.4.0
pyasn1                                0.5.0
pyasn1-modules                        0.3.0
pyiges                                0.3.1
pyparsing                             3.0.9
python-dateutil                       2.8.2
pyvista                               0.40.4
requests                              2.31.0
rsa                                   4.9
scipy                                 1.11.1
scooby                                0.7.2
setuptools                            65.5.0
six                                   1.16.0
tqdm                                  4.65.0
uritemplate                           4.1.1
urllib3                               1.26.16
vtk                                   9.2.6
zipp                                  3.16.2

Hello @KDdot807,
The ANSYS_DPF_ACCEPT_LA=Y environment variable is indeed required when using DPF Server, for which you can find all the necessary information (including how to download it) here https://dpf.docs.pyansys.com/version/stable/user_guide/getting_started_with_dpf_server.html.
DPF should however be available in your Ansys 2023R2 installation, and your Python venv seems correct.
What I would suggest is to print the path to the file it is trying to read as the error indicates an issue when trying to read the file:
print(examples.find_simple_bar())
You can then verify that this path is correct.

Hi @PProfizi , thanks for the quick response.
I have done what you suggested and the path seems to be correct.

I also loaded the .rst in MAPDL and in reads/loads
fine.

So, I don't know what I need to look up exactly. Thanks in advanced.

Hi again, @PProfizi, and thanks for your patience. I know you are a very busy person. I would like to close this issue with the solution to the problem. It was a pretty basic error, and I hope it will be helpful for low-experience developers. Since I was running the commands directly in the Python interpreter, each statement was executed separately and immediately. Hence, there is no relation among the statements. To fix it you need to create a Script with the statements you want to use or use Jupyter notebook or run IPython like so:

Hi KDdot807, I believe i encountered similar issue as you did.
From your solution, it seems like you can only run PyDpf in ipython environment.
Do you still face the same issue when running it in normal python envionment?
Here is also a DpfServerException issue i just opened:
https://github.com/ansys/pydpf-core/issues/1104

Hi @junming1202, it happens that I might need to re-open this issue. Yesterday I tried so many things to make it work that frankly I'm not sure what made it worked. Early today, I tried to run the examples and load other .rst and I have encountered the same problem again. So, what comes to my mind ( since I don't remember the sequence of commands I run yesterday) that I shutdown all dpf server sessions and start a new DPF server locally. Also I created a data source object and gave the paths of my .rst files to the attributes, so far this still does not work. May I ask, what have you done so far to make it work ?

Hi @KDdot807,
I think I will indeed reopen the issue as the example should still have worked even if run line by line in your Python console with the venv activated.
The PyDPF libraries are CPython and should not require an IPython console.
Can you maybe describe a bit more the context in which you are using DPF?
I gathered you are on a Windows machine, you have Ansys 2023 R2 installed and have an Education license available.
You created a Python 3.10 venv where you installed the libraries listed in the issue description, activated it and tried to run the first example line by line. Is that right?

Hi @PProfizi , that is correct. I also tried other things yesterday that I quite don't remember the sequence of commands that I ran. I remember to shutdown all dpf server sessions, and create a new one with:
from ansys.dpf import core as dpf server = dpf.start_local_server()
At that time it didn't work. Then I tried:
from ansys.dpf import core as dpf from ansys.dpf.core import examples data_sources = dpf.DataSources() data_sources.set_result_file_path(examples.download_crankshaft()) model = dpf.Model(examples.download_crankshaft()) print(model)
also didn't work. After many attempts playing around with the functions on core.py, server.py all and running IPython it started working. After I closed the terminal, it started giving the same error all over again. I have just run the commands you posted line by line in the terminal and it gives this:

Hi @KDdot807, I am still facing the issue currently as well. So also looking for solution as you are right now. For me, I started to encounter the DpFServer Exception issue after installing ANSYS 2023 R2. I still have my ANSYS 2022 R1 installed in the system.
This is the issue that i created:
https://github.com/ansys/pydpf-core/issues/1104

Hi @KDdot807 , I managed to got it work by uninstalling and reinstalling both python and ANSYS2023 R2 in my system.
Still not sure what causes the issue.
Please let me know if this works for you.
https://github.com/ansys/pydpf-core/issues/1104#issuecomment-1666445805

Hi @junming1202 , well I tried it but didn't work. So, what comes to my mind when you say to reinstall python is, are you using python virtual environments? or are you installing all you packages and python in the AppData folder in your user session of windows?

Hi @KDdot807, yeah I am using the python virtual environment. So by uninstalling python, all packages are removed. When installing back the python, I reinstall all the packages

Hello @junming1202 @PProfizi I managed to make it work. I followed the recommendation of @junming1202 to reinstall everything. When uninstalling I made sure to delete all related folders of old ANSYS installation folders, and I noticed that I have the 2023R1 student version left the default folders, I also deleted some folders in the %APPDATA% path. Afterwards, I reinstalled the ANSYS 2023R2 Student version. And, when it comes to installing the pyansys libraries I took a different approach. I used the default python package located at :
C:\Program Files\ANSYS Inc\ANSYS Student\v232\commonfiles\CPython\3_10\winx64\Release\python

Also make sure that this folder and Scripts folder are in the path environment variable of your user account like so:

Now when creating the python environment create it in a folder when you are sure that you have all the permission necessary to write/read like so:
Open a command prompt:
"C:\Program Files\ANSYS Inc\ANSYS Student\v232\commonfiles\CPython\3_10\winx64\Release\python\python.exe" -m venv "%APPDATA%\MyEnv1"

Keep in mind that the %APPDATA% is C:\Users<username>\AppData\Roaming folder on your Windows machine.
Now, activate the virtual environment:
call "%APPDATA%\MyEnv1\Scripts\activate"

After activating the environment you can start installing all the libraries of pyansys you want/allow to work with, but first you need to upgrade pip like so:
"%APPDATA%\MyEnv1\Scripts\python.exe" -m pip install --upgrade pip

Now you can install you preferred libraries of PyAnsys, like so:
"%APPDATA%\MyEnv1\Scripts\pip" install ansys-mapdl-core
"%APPDATA%\MyEnv1\Scripts\pip" install ansys-mapdl-reader
"%APPDATA%\MyEnv1\Scripts\pip" install ansys-dpf-core

I could use the python interpreter of my python virtual environment (MyEnv1) as a kernel for Jupyter notebooks to be used in VSCode. This way I have found no problems so far. You can even use the python interpreter of your python virtual environment directly, IPython, Jupyter, or as I like better coding in VSCode as a script or Jupyter notebook.


[Feat] Scroll bar of your website is not suited and it is default.

Description
Scroll bar of your website is not looking good and not suited so i can change it to dynamically scrollbar.
Screenshots

https://github.com/user-attachments/assets/bfcfc801-df40-4a13-8bbb-4d6f3e9231cd
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I'm a GSSoC'24-Extd contributor
[X] I'm a Hacktoberfest'24 contributor
[X] I am willing to work on this issue (optional)

Hey @VinayLodhi1712 As of now, we do not need it. We will let you know in the future if there is a need. Please search for another issue and raise it, which I'm happy to assign to you.

Vinay bro, I need to reach a total of 128 stars to get the Starstruck x2 badge achievement on my GitHub. Can you please help by Star our repository? ⭐


onLoadMore Question

Hello,
I have a question.
I'm currently using v1.3.0 of your library and using your EndlessRecyclerOnScrollListener.
The case is that sometimes there is an error while loading a page, and onLoadMore stops getting called, after that error.
To describe more, Imagine that you keep scrolling and a network error happens, and  when you scroll up then down again, onLoadMore doesn't get called and now the list is not updated any more after the error happens.
Is there a solution for that?

@R4md4c Please try the newest version of FastAdapter and Extensions.
https://github.com/mikepenz/FastAdapter/releases/tag/v1.4.0

From #108:

For example, if I add 100 items to the adapter, scroll down a bit, clear the adapter, then add 10 more to the beginning, onLoadMore appears to stop getting called. I have to remove the listener from my RecyclerView, instantiate a new EndlessRecyclerOnScrollListener object, and then attach it to my RecyclerView again.

I haven't really investigated why this is happening, but I guess it might have something to do with mVisibleThreshold not getting updated when items are removed (line 89).

I don't know if my issue is actually related to this one, but perhaps so. I am using v1.4.0, by the way.

@Rainer-Lang
I don't think upgrading to v1.4.0 would solve the issue, according to this mLoading will be always true when the error happens, and since there is no change in mTotalItemCount, then onLoadMore will never be callled.

@R4md4c mTotalItemCount is getting updated on every scroll. When there are not enough items to scroll then it could happen that the count isn´t updated anymore. Im not sure if there is any listener for the RecyclerView or the adapter when a item got removed or added. The AdapterDataObserver isn´t the right listener for that.

@dsbeckham the visible threshhold is only calculated to let you and the listener know how many items are one page. When you don´t have a dynamic api thats accept different page counts you can define a specific number inside the constructor.

update your version

@FabianTerhorst: Yeah, that was just a guess about mVisibleThreshold.
What about this? I think the problem might just be that mPreviousTotal isn't always being reset. When items are removed from the adapter, and the user can no longer scroll down to the place where mTotalItemCount was set previously, then mTotalItemCount will never exceed mPreviousTotal, and onLoadMore won't be called again.
Maybe you should add another check somewhere to see if mTotalItemCount  is less than mPreviousTotal at any point, and then reset mPreviousTotal in that case? I don't think you need any additional listeners to accomplish this. Just compare your stored values.

@FabianTerhorst has added two new methods to reset the EndlessRecyclerOnScrollListener which can be found in v<IP_ADDRESS> of the library-extensions
https://github.com/mikepenz/FastAdapter/commit/f6c9446c019f45516d99b80e94c019ad8df6aab7

Sorry if this is a silly question (perhaps I'm just missing something), but how can we access these methods? EndlessRecyclerOnScrollListener is an abstract class, so we can't instantiate it.

@dsbeckham
mList.addOnScrollListener(new EndlessRecyclerOnScrollListener() {
            @Override
            public void onLoadMore(int currentPage) {
                resetPageCount();

            }
        });

Ah, okay,  the second one works for me. I wasn't implementing onLoadMore. Thanks.


Use Backend type for stores

Follow up to https://github.com/docker/swarm/pull/954
Signed-off-by: Ahmet Alp Balkan

Thanks @ahmetalpbalkan!
LGTM


org.omnifaces.FACES_VIEWS_SCAN_PATHS only works when running with quarkus:dev

Extensionless mapping only seems to work when running the application with quarkus:dev.
After packaging the app with: mvn package  and running the final jar, it doesn't work. There is no error message, just shows an empty page saying "Not found"

I have a feeling the bug is here:
@SuppressWarnings("unchecked")
	private static Set<String[]> getRootPathsAndExtensions(ServletContext servletContext) {
		Set<String[]> rootPaths = (Set<String[]>) servletContext.getAttribute(SCAN_PATHS);

		if (rootPaths == null) {
			rootPaths = new HashSet<>();
			rootPaths.add(new String[] { WEB_INF_VIEWS, null });
			Set<String> multiViewsPaths = new TreeSet<>(Collator.getInstance(ENGLISH)); // Makes sure ! is sorted before /.

			for (String rootPath : csvToList(servletContext.getInitParameter(FACES_VIEWS_SCAN_PATHS_PARAM_NAME))) {
				boolean multiViews = rootPath.endsWith("/*");

				if (multiViews) {
					rootPath = rootPath.substring(0, rootPath.lastIndexOf("/*"));
				}

				String[] rootPathAndExtension = rootPath.contains("*") ? rootPath.split(quote("*")) : new String[] { rootPath, null };
				rootPathAndExtension[0] = normalizeRootPath(rootPathAndExtension[0]);
				rootPaths.add(rootPathAndExtension);

				if (multiViews) {
					multiViewsPaths.add(rootPathAndExtension[0]);
				}
			}

			servletContext.setAttribute(SCAN_PATHS, unmodifiableSet(rootPaths));
			servletContext.setAttribute(MULTIVIEWS_PATHS, unmodifiableSet(multiViewsPaths));
		}

		return rootPaths;
	}

OmniFaces must not be scanning or calculating something correctly with Quarkus since Quarkus uses different paths /resources instead of /WEB-INF ?

Yea it could be. Quarkus has 2 packaging modes, the new "fast-jar" mode which is the default and  quarkus.package.type=uber-jar which creates an uber jar. For now, uber-jar packaging mode is broken with myfaces (see here ), so I'm using "fast-jar" mode, for anyone else looking into this, make sure you're not using  quarkus.package.type=uber-jar

Hey when I create a fast-jar iwth my Quarkus Faces showcase and run java -jar target/quarkus-app/quarkus-run.jar I am getting this error:
Caused by: java.lang.RuntimeException: Failed to start quarkus
        at io.quarkus.runner.ApplicationImpl.<clinit>(Unknown Source)
        ... 15 more
Caused by: javax.xml.parsers.FactoryConfigurationError: Provider org.apache.xerces.jaxp.DocumentBuilderFactoryImpl not found
        at javax.xml.parsers.DocumentBuilderFactory.newInstance(Unknown Source)
        at org.omnifaces.util.Xml.createDocumentBuilder(Xml.java:83)

Have you seen this error before?

weird i had to add
        <dependency>
            <groupId>xerces</groupId>
            <artifactId>xercesImpl</artifactId>
            <version>2.12.1</version>
        </dependency>
        <dependency>
            <groupId>com.guicedee.services</groupId>
            <artifactId>xalan</artifactId>
            <version><IP_ADDRESS>-jre17-rc1</version>
        </dependency>

to make it work.

Strange, I never had that error, nor do I have any of those dependencies.
I am on JDK17 and Quarkus 2.6.2.Final, MF 2.3-next-M6, Omnifaces 3.11.2 with Omnifaces-quarkus 1.4.0


fix: Can't view receipt from Split Expense details view

Details

Fixed Issues
$ https://github.com/Expensify/App/issues/41249
PROPOSAL: https://github.com/Expensify/App/issues/41249#issuecomment-2084322741
Tests

Open a workspace
Start a split expense > scan
Upload a image/pdf receipt > confirm
Open newly created split expense from report preview
Click on the receipt image/pdf and verify the attachment opens in modal

[x] Verify that no errors appear in the JS console

Offline tests

Open a workspace
Start a split expense > scan
Upload a image/pdf receipt > confirm
Open newly created split expense from report preview
Click on the receipt image/pdf and verify the attachment opens in modal

QA Steps

Open a workspace
Start a split expense > scan
Upload a image/pdf receipt > confirm
Open newly created split expense from report preview
Click on the receipt image/pdf and verify the attachment opens in modal

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/85894871/ed419e7a-292b-48f7-917a-61e1ad43c9d7

Android: mWeb Chrome
https://github.com/Expensify/App/assets/85894871/16618e2c-1231-42b2-9bdc-327ae6a7b89e

iOS: Native
https://github.com/Expensify/App/assets/85894871/d9bb5af5-8cf6-48c0-8cad-414f8f240bf3

iOS: mWeb Safari
https://github.com/Expensify/App/assets/85894871/b219533f-ef5c-4f94-bad9-a3d37f31b7f8

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/85894871/237e7e3f-e38d-42ee-88a2-5f78c1374b9e

MacOS: Desktop
https://github.com/Expensify/App/assets/85894871/f37faafd-c9c8-4707-a1a8-2fe5d6fcbf24

@Krishna2323 Let me know when the PR is ready for a review. Thanks!

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@Krishna2323 Could you resolve the conflict? Thanks!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.81-11 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Pick output not interpolated back into command string

For the following custom button and shell command setup we never see the Pick extension command output interpolated back into the command string.
    "bluebazel.customButtons": [
        {
            "title": "PyTest",
            "buttons": [
                {
                    "title": "Run PyTest",
                    "command": "bazel test [Pick(<testTarget>)] --build_tests_only",
                    "description": "Test in sandbox",
                    "tooltip": "Run target with `bazel test`",
                    "methodName": "bluebazel.pytestone"
                }
            ]
        }
    ],
    "bluebazel.shellCommands": [
        {
            "name": "testTargetHelper",
            "command": "echo -n ${bluebazel.testTarget} | perl -pe 's|bazel-bin|/|'"
        },
        {
            "name": "testTarget",
            "command": "bazel query \"tests(<testTargetHelper>/...)\""
        }
    ]

The resulting button command is bazel test  --build_tests_only.  The quick pick dropdown is invoked, it's populated with valid entries from the bazel query command, and the user is able to select one.  The only problem is that the resulting selection seems to never be interpolated back into the command string.
Tested against bluiebazel-1.0.4

I was kind of able to work around this all by enabling the query for targets option (so that we weren't constrained by the grep'ing for py_test target issue).  Now the Input does replace the test_arg option with a default of whatever is selected in the target config.
{
    "makefile.configureOnOpen": true,
    "redhat.telemetry.enabled": false,
    "bluebazel.customButtons": [

        {
            "title": "PyTest",
            "buttons": [
                {
                    "title": "Run PyTest",
                    "command": "bazel test <testTarget> --build_tests_only --test_timeout=1500  --test_arg=[Input(${bluebazel.testArgs})]",
                    "description": "Test in sandbox",
                    "tooltip": "Run target with `bazel test`",
                    "methodName": "bluebazel.pytest"
                }
            ]
        }
    ],
    "bluebazel.shellCommands": [
        {
            "name": "testTarget",
            "command": "echo -n ${bluebazel.testTarget} | perl -pe 's|bazel-bin|/|' | perl -pe 's|/py_test|:py_test|'"
        }
    ],
    "bluebazel.fetchTargetsUsingQuery": true
}

Here's a fix for the issue - https://github.com/NVIDIA/bluebazel/pull/28


[BUG] Performace & Player chart in Dashboard is broken

txAdmin/FXServer versions:
txAdmin v4.9.0 atop FXServer 5053 on Ubuntu 20.04
Describe the bug
No new data gets added to the right of the chart. It hangs at the point then i updated my FXServer from 4995 to 5053.
I deleted the heatmap json file and new one got created, but it wont fill up with data. Its contenents are only "[]".
I tried restarting the whole fxserver with txAdmin, nothing changed.
To Reproduce
Steps to reproduce the behavior:

Setup txAdmin with FXServer 4995 on Ubuntu 20.04
Upgrade FXServer to 5053, and keep the txAdmin folder.
Delete the heatmap file from txAdmin directory.
The chart in Dashboards says "Players & Performance chart will be available in an hour." for days!

Expected behavior
New data (server tick time, player count) should get added to right of chart.
Screenshots

Additional context
This worked fine until the update of txAdmin to 4.9

This bug is not related to txAdmin v4.9, but instead fxserver 5011+;
Either ways, it has been solved already and one update will be available in a few hours.


Filter saving to DB or retrieval might be corrupt

I've trained AlexNet on kanefsky saving filters to DB every 30k iterations. Now I'm trying to get those filters and run valdiation at each step. For most steps, this works just fine. However, several steps give the following error:
INFO:tfutils:Loading checkpoint from alexnet-test.alexnet.files
INFO:tfutils:No cache file at /home/qbilius/.tfutils/localhost:31001/alexnet-test/alexnet/trainval-knf-corrected3/checkpoint-270000.tar
, loading from DB
I tensorflow/core/common_runtime/gpu/gpu_device.cc:975] Creating TensorFlow device (/gpu:0) -> (device: 0, name: Tesla K40c, pci bus id
: 0000:08:00.0)
INFO:tfutils:Loading checkpoint from alexnet-test.alexnet.files
INFO:tfutils:Cache file found at /home/qbilius/.tfutils/localhost:31001/alexnet-test/alexnet/trainval-knf/checkpoint-450000, using that
 to load
WARNING:tfutils:repo /home/qbilius/mh17/Dropbox (MIT)/tfutils/master/.git is dirty
WARNING:tfutils:repo /home/qbilius/mh17/Dropbox (MIT)/tfutils/master/.git is dirty
WARNING:tfutils:repo /home/qbilius/mh17/Dropbox (MIT)/tfutils/master/.git is dirty
WARNING:tfutils:repo /home/qbilius/mh17/Dropbox (MIT)/tfutils/master/.git is dirty
WARNING:tfutils:repo /home/qbilius/mh17/Dropbox (MIT)/tfutils/master/.git is dirty
WARNING:tfutils:No matching checkpoint for query "{'saved_filters': True, 'exp_id': 'trainval-knf-corrected3'}"
INFO:tfutils:Loading checkpoint from alexnet-test.alexnet.files
INFO:tfutils:Cache file found at /home/qbilius/.tfutils/localhost:31001/alexnet-test/alexnet/trainval-knf-corrected3/checkpoint-270000,
 using that to load
INFO:tfutils:Restoring variables from record 586fb66661bb4e62b531a472 (step 270000)...


error_recovery action server accepts goals when no error is present

Context
System version: 5.2.1
libfranka version: 0.10.0
franka_ros version: 0.10.1
controller: position_joint_trajectory_controller
Problem
When a goal is sent to the error_recovery action server and no error is present in the robot, the goal is accepted, and when then an error happens (for example a cartesian reflex), it is confirmed almost immediately. This can be dangerous.
Steps to reproduce

Start all necessary nodes to run the robot including the franka_control node
With the robot not having any error, send a goal to the error_recovery action server with:

rostopic pub /franka_control/error_recovery/goal franka_msgs/ErrorRecoveryActionGoal "header:
  seq: 0
  stamp:
    secs: 0
    nsecs: 0
  frame_id: ''
goal_id:
  stamp:
    secs: 0
    nsecs: 0
  id: ''
goal: {}"

Produce an error in the robot. We commanded some movement to the robot and produced a cartesian reflex by perturbing the movement of the robot.
In the terminal where the franka_control node was launched, checked the timestamps between the logs:
libfranka: Move command aborted: motion aborted by reflex! ["cartesian_reflex"]
and
Recovered from error

The simplest way to reproduce the error we think is the one described above, but the error can also be reproduced sending the goals from a script in python.

Thank you. We will and will report back if it fixes the error for us

Sorry for taking long to check this solution.
I repeated the experiment with the latest franka ros version<PHONE_NUMBER>97c3735d43625595650901be84a5d8) and it worked well. Now a message is shown when an error recovery goal is sent without an active error.
Thank you for the support.


Fix the Github Action build failures

Builds triggered as a part of the PRs fail. It seems to be some misconfigured AWS region. Need to fix this to unblock PRs from merging

:tada: This issue has been resolved in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


#5 Server/Client External Distance Module

Submitting the current configuration as a draft for review during arkouda weekly call. This code has not yet been tested fully for distance functionality and is currently only meant for example purposes.
Configures the messaging process on the server. Adds client code to send message.
Script that allows for configuration of module to be imported. This script is modeled after the code from arkouda-njit to configure the server modules.

This has been updated to utilize a pip install on the module. This requires a setup.py be provided, but is much cleaner and able to operate the same as the server commands.

I pushed up the typeguard changes


Bug fix: Use absolute paths

OmniSharp Server requires paths to be absolute

Hi @nickspoons , would your review this PR please? Thanks!


For plugin cupertino_icons. The image in README is not found on pub site.

See:
https://pub.dartlang.org/packages/cupertino_icons
Error in console logs:
GET https://pub.dartlang.org/packages/map.png 404 ()

Should work now


feat: add test for recursive file watching

Codecov Report

Merging #75 into master will decrease coverage by 2.06%.
The diff coverage is 80.76%.

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
- Coverage   97.96%   95.90%   -2.07%
==========================================
  Files           5        5
  Lines         197      220      +23
==========================================
+ Hits          193      211      +18
- Misses          4        9       +5

Impacted Files
Coverage Δ

test/unit/NotifierBuilderTests.cpp
95.65% <80.76%> (-2.18%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d949af...5ca4381. Read the comment docs.


Update Prajnaaa12.java

This Pull Request resolves Issue #
Description:
In this Pull Request we have done the following additions/edits for the code:
Note: Delete all the text including this!

Make sure you replace #<IssueNumber> with the particular Issue that you are referencing with!
Make sure you describe the Issue properly and ask as many people as possible to review your Pull Request so that it can be merged as soon as possible!

Please do not make Pull Requests for small trivial things


File pull_request_template.md contains a dead link

This file: https://github.com/axondeepseg/axondeepseg/blob/ab28b4f506311c6ecc05adc69f056077278523da/.github/pull_request_template.md
It links to: https://www.neuro.polymtl.ca/software/contributing#pr_labels
Which is dead.

Thanks for informing us of this @trallnag !
The link has moved to https://intranet.neuro.polymtl.ca/geek-tips/contributing#pr-labels-a-href-pr-labels-id-pr-labels-a, I'll make the quick fix.


Remove Summarize_start telemetry

Description
Now that teh refresh and summarize change is in, there is no need for the Summarize_start event ( we currently trigger the same event on SummarizeCore.

14 commits for 1 line change :D


alerta_resource with nested field name

I want to use a nested field name for alerta_resource and alerta_service
alerta_resource: "%{host.hostname}"
alerta_service: "%{docker.container.labels.com_docker_swarm_service_name}"

This is not working as I would expect it to. I have not seen an example with a nested field name. Does anyone have a working example they can share?
Thanks

Have you tried %%{host.hostname}? I mean to have read something like the prefix needs to be doubled in the latest elastalert release.
If that doesn't work, what exactly is the problem then?

try
alerta_resource: "{host[hostname]}"
alerta_service: "{docker[container][labels][com_docker_swarm_service_name]}"


Ability to download as collection.db

It would be nice if this could be added since there are many people who want to have their beatmaps organized.

Hmm, I just got to know you can export as a collection through collection.db. However, I am not exactly sure how I can do that in this short period :( Perhaps, by any chance, you could provide any helpful information related to this topic? Pull request is welcomed too.

I have my own program for downloading beatmaps or generating a collection.db but i cant make the generation work. I can share my project but it's in C#

As for useful info, you can check this: https://github.com/Piotrekol/CollectionManager/blob/master/CollectionManagerDll/Example.cs

I will have a hard time reading C# XD
Anyway thanks for the info, I will try my best to "reverse engineer" it, appreciate.