Add a way to allow providers to fail instantiation

A new optional flag is added to set if a provider can fail to start.
Fix #401
Note that a shortcut is taken here, from #401

A careful definition of "cannot be instantiated" is also needed, because it is important to be able to distinguish between an optional provider and a badly-configured one, or one that fails unexpectedly due to some platform or environment error.

Here we allow all kind of failures and do not differentiate, mainly for simplicity.

I think the difference between "badly-configured" and "failing unexpectedely due to some platform or environment error" is pretty hard to determine in all cases and I am wondering if it is worth it.

I think the difference between "badly-configured" and "failing unexpectedely due to some platform or environment error" is pretty hard to determine in all cases and I am wondering if it is worth it.

I think it's worth at least checking for a few (maybe one or two) cases, even if it's something opinionated. We can document which failures we continue from.
For TPM for example maybe we can check if the TCTI can connect and continue otherwise, and if it can connect, whether the owner authentication value is correct. Everything else and we fail to start.

For TPM for example maybe we can check if the TCTI can connect and continue otherwise, and if it can connect, whether the owner authentication value is correct. Everything else and we fail to start.

I guess the only place we could check for those things is when building the TransientKeyContext here by checking the different return values?
That would also mean changing the TPM provider builder to add the "conditional" field information and also the return type of the build method to a Result<Option<Provider>> so that Ok(None) can be returned when we are in the allowed failure cases?
I am wondering if all this logic is worth it (code change + documentation + tests) and if it really adds value to be able to have a subset of allowed failure rather than allowing everything.

I guess the only place we could check for those things is when building the TransientKeyContext here by checking the different return values?
That would also mean changing the TPM provider builder to add the "conditional" field information and also the return type of the build method to a Result<Option<Provider>> so that Ok(None) can be returned when we are in the allowed failure cases?

I was thinking of just adding another method to the builder, something like check_valid() -> Result<()>. Shouldn't change much of the other flow, but you'd need to probably use the non-abstracted TSS interface.

I am wondering if all this logic is worth it (code change + documentation + tests) and if it really adds value to be able to have a subset of allowed failure rather than allowing everything.

I guess that's what the initial issue was about. @paulhowardarm can weigh in on that, and maybe the RH folks? Since they asked for the feature it might be worth asking for more clarifications.

I think we need to look at this again - the current PR looks like a simplification too far, because it's just catching errors, which was not the intention. Getting your TPM password wrong is a configuration error. That is not the kind of error that I was expecting we would continue from. That kind of error should still be fatal. The intention (at least in the case of TPM) is that we skip the creation of the TPM provider only if there is no TPM on the system.
For the same reason, I think that can_fail_instantiation is not a good name for the config flag. It's not about skipping or tolerating failures. It's more about a preflight check for what the platform supports. My suggested name was conditional_on_platform_support, although I'm not saying that's a perfect choice either. We could also have continue_if_not_supported or some better name. The point is that it's about support, not about failure. It's about allowing a common config file to work on both TPM and non-TPM platforms.
The simplification that I would be happy with is to only handle TPM for now. Not every provider type can do a pre-flight check in any reliable way, and I would be happy for other providers to reject the config flag (if set to true) as being invalid for that provider type. Again, that would be a fatal mis-configuration error - trying, for example, to set the flag to true for the PKCS#11 provider or the Mbed provider. (Trusted Service provider is an interesting case that we might want to think about).
For TPM, we can check the availability of the TCTI. If it's a device TCTI, then it should just be a simple file search to see whether the device path is present on the system. If it's a socket TCTI, then perhaps we can check whether the port is listening? To be honest, though, even if we only did the device path check, that might be enough.

For TPM, we can check the availability of the TCTI. If it's a device TCTI, then it should just be a simple file search to see whether the device path is present on the system. If it's a socket TCTI, then perhaps we can check whether the port is listening? To be honest, though, even if we only did the device path check, that might be enough.

But it becomes a bit difficult there, when a device TCTI is used, we simply can't tell the difference between the path not existing because the TPM isn't present and it not existing because the configuration is wrong. But I guess we can just offload that to the admins with some clever wording in our docs.

We should work on the basis that the configuration is correct. The thing we are examining is the platform. I don't want to get into the game of trying to second-guess all possible typos that admins might have put into the config file. It is inevitable that config mistakes might lead to undesirable behaviour of all kinds, including fooling whatever heuristics we might code into the start-up. If the config gives us a TPM device path, then let's assume it is the correct path, but check the platform to see whether it is present.

Thanks for the explanation, I understand the focus on platform support. I think I will add a method on the Tcti type, supported, that will do the file path/socket checks and return an error if there is a problem. I might ignore the TABRMD TCTI for now.
In the service builder, I will try to build the TCTI first and then check if the platform supports it or not.

Trying the CI with the new solution, with the skip_if_no_tpm flag. It is currently using https://github.com/parallaxsecond/rust-tss-esapi/pull/234 on my fork

@paulhowardarm Kindly pinging you for a review, after updates based on the discussion here

Thanks. I also checked the good behaviour of the test on the CI:
2021-07-06T17:02:47.0488228Z [INFO  parsec_service::utils::service_builder] Creating a TPM Provider.
2021-07-06T17:02:47.0500545Z ERROR:tcti:src/tss2-tcti/tcti-device.c:440:Tss2_Tcti_Device_Init() Failed to open device file /dev/tpm0: No such file or directory
2021-07-06T17:02:47.0501747Z WARNING:tcti:src/tss2-tcti/tctildr.c:62:tcti_from_init() TCTI init for function 0x7f081c2decb0 failed with a000a
2021-07-06T17:02:47.0502865Z WARNING:tcti:src/tss2-tcti/tctildr.c:92:tcti_from_info() Could not initialize TCTI named: tcti-device
2021-07-06T17:02:47.0507497Z ERROR:tcti:src/tss2-tcti/tctildr-dl.c:150:tcti_from_file() Could not initialize TCTI file: device
2021-07-06T17:02:47.0509503Z ERROR:tcti:src/tss2-tcti/tctildr.c:418:Tss2_TctiLdr_Initialize_Ex() Failed to instantiate TCTI
2021-07-06T17:02:47.0510873Z [ERROR tss_esapi::tcti_ldr] Error when creating a TCTI context: response code not recognized
2021-07-06T17:02:47.0513603Z [ERROR parsec_service::utils::service_builder] Error creating a TCTI context; Error: response code not recognized
2021-07-06T17:02:47.0514654Z [WARN  parsec_service::utils::service_builder] Provider TPM provider is skipped.


Add go sec to Makefile

Fixes #29

Thanks a lot for this contribution :) Can you please exclude the legacy dir and the G404 rule? This math/rand utils will only be used for tests so there is no problem with it.
(-exclude-dir 'legacy' -exclude 'G404')

@knelasevero done


installing is stuck on loop

currently version 0.6.1 is working fine
version 0.6.2 and 0.6.3 stuck on infinite loop like this

This should be fixed in 0.6.4.


Hot Module Replacement not working

Run the button example.play at http://localhost:5000.It looks good now.
Replace something...
Chrome DevTools:
The following modules couldn't be hot updated: (Full reload needed)
This is usually because the modules which have changed (and their parents) do not know how to hot reload themselves. See http://webpack.github.io/docs/hot-module-replacement-with-webpack.html for more details.

I guess you should handle hmr yourself?

Yeah , i get it.

So is there still an issue here or can we close this?

Yeah.you can close it.


Add support for unmuting certain topics within a muted stream

It'd be cool if one could unmute certain topics in a muted stream, basically declaring you want to follow just those topics.
This probably wouldn't be too difficult to implement, since we're doing all the muted stream/topic filtering on the frontend anyway.  But it would limit our flexibility for future model changes, so some care is required.

Hey. I would like to work on this issue. Any pointers or guidelines on how to get started?

Hi @Katy310!  This is likely to be a somewhat involved project that involves a lot of understanding but only ~50 lines of code, but in short I'd start by reading all the code related to muting, and in particular all the code paths using muting.is_topic_muted.

We'll also want to change the muted_topics data structure to support "anti-muted" topics
We'll want to make those topics cause them to show in the home view even for a muted stream.
We may want to have some UI display for this feature.

This issue has been silent for a while -- so just bumping with the observation that this is one feature I regularly wish I had. :smile:
This also comes up in feedback I hear from other people active in busy Zulip orgs.
(Also I think this issue predates GitHub's emoji-reaction feature! So it has missed out on accumulating :+1: . Just added mine.)

Adding some context on use case: what I really want this for is the situation where I participate in one conversation on a stream with lots of other conversations I don't have the bandwidth to keep up on in general. Any further discussion on that conversation, I want to learn about in the usual asynchronous way just like the streams I subscribe to.
Some tracker-gardening with cross-references to related issues, since I just did the search to find issues describing this need:

#6605 ("My Topics", or "Sent messages") is potentially related. But the key thing I want here is to learn about new/unread messages in these topics, which I don't see clearly described in the plan there.
(OTOH, if an "unmute some topics" feature just automatically took effect for any topic I replied on, that would pretty much nail what I want from it.)
#11042 is to get notifications in a topic, which is sort of parallel but much higher-interruption than I want here.
#3157 and #4271 are different versions of keeping a thread visible to come back to, for I think somewhat different use cases from this one.

One additional thought on this, inspired by #6605: I'd love for this to happen automatically for any topic I send a message on.
Model-wise, that probably comes in two layers:

Have a concept of "anti-muted topic" or "subscribed topic" at all (which is what this issue has discussed so far)
Automatically subscribe to / anti-mute the topic when you send a message

And then #6605 is basically a third layer atop those, asking for a narrow consisting of subscribed topics.

@timabbott writes

I would like to understand more the thinking around your configuration -- we certainly have not invested in issues that one might only see if one mutes 90%+ of incoming messages (E.g. being able to unmute just one topic within a muted stream).

This issue felt like the better place to respond.
So my thinking here is: in the Rust zulip, I am subscribed to the majority of streams on that Zulip (a) since I get pinged occasionally, and (b) there are occasionally relevant topics being discussed. That means among my subscribed streams, there are way too many messages for me to follow all of them, and the vast majority is not relevant for me.  If Zulip would add all those messages to the "unread" count, then that count would basically never be 0, making it useless. There are a few streams where I actually want to follow all messages; those would get drowned in the "noise" of other, less relevant messages.
So what works really well for me is to mute all the streams except the ones where I want to follow everything.  Now when Zulip shows an "unread" message, I know this is in a stream I care about, so the unread count and the corresponding favicon are actually meaningful signals to me. When I have time, I will go through my muted streams and see which discussions I missed; if they are interesting, I will comment. I would like to unmute such a discussion (but not the containing stream) so that I do not miss further comments in this topic, but that is not possible. So instead, I very regularly check "recent topics" (in fact that's the default view I have open most of the time in "idle mode"), with the selection being "include muted, participated, unread". This lets me see when something happens in a discussion I participated in, no matter whether it is in a muted stream or not.
The set of messages I care about is defined as the union of "all messages in the few streams that I want to exhaustively follow" and "all messages in a few select conversations that I hand-pick or where people ping me". With my current way of using Zulip, the former is handled by the unread count, and the latter is handled by "recent topics".
I hope this explains what I am doing and why; feel free to ask if questions remain open. :)

I don't quite understand what a pinned stream is, but it seems like the key point here is more like pinned topics?
I think the idea of a "participating" or "recent" topic is really useful, and I would like to see that more centered.

Do you think there's something we could do with "pinned streams", e.g. offering "total unread count is only for pinned streams", as an alternative way to handle this use case?

So far I have barely used pinned streams as I don't know a way to make good use of them. If the unread count would only be for pinned streams, that would certainly avoid the need to have to mute all those other streams.
However, it would not alleviate the need to still be able to follow some conversations in those unpinned streams.

I opened an issue for a preparatory data migration that would let us have a place to store this preference here: https://github.com/zulip/zulip/issues/19272
Once we've done that, the backend for saving the state is a messy problem, just because we need to decide if we're creating a parallel API to the "mute topic" endpoints, or trying to unify things.  I'll do a design for that once #19272 is completed.
I've also started https://chat.zulip.org/#narrow/stream/101-design/topic/unmuting.20in.20muted.20streams/near/1232339 for discussing the actual UI for this.

Got another user request for this one.

Highly requested in user survey.

Looking at one aspect of implementing this, namely the core backend code path, I think we'd need to change these places:

First, integrate https://github.com/zulip/zulip/pull/21251 so that we can send these data to clients via the API.  @akashaviator this could be a good issue for you to work on once that is integrated, and potentially you can start working on this now in any case.
Use the UserTopic model's visibility_policy=UserTopic.UNMUTED to store which topics have been anti-muted, as planned.
Add a do_set_unmuted_visibility function (not yet connected to the API) to be able to set this visibility policy for a topic.
Add the plumbing for the server to do notifications as configured for a topic set this way, with tests. I think possibly the functional changes would be confined to this function:

def get_recipient_info(
...
    # CHANGE: Replace this function with something also returning a new `user_ids_unmuting_topic`
    user_ids_muting_topic = stream_topic.user_ids_muting_topic()
...
        def should_send(setting: str, row: Dict[str, Any]) -> bool:
            # This implements the structure that the UserProfile stream notification settings
            # are defaults, which can be overridden by the stream-level settings (if those
            # values are not null).
# CHANGE: The next line should also check if `user_ids_unmuting_topic`.
            if row["is_muted"]:
                return False
            if row["user_profile_id"] in user_ids_muting_topic:
                return False
            if row[setting] is not None:
                return row[setting]
            return row["user_profile_" + setting]

Once that's done, we'll need to do the second half, which is to add support for the web app to display topics of the form in the UI, etc., but I think the chunk above will be very helpful preparation for having something we can test.

I am confused - I clearly remember commenting somewhere on this subject, but I can't find anything in any repo or Zulip. So here is what I wanted to add:
By making topics in muted streams subscribe-on-demand/-on-post, Zulip can be used more like a forum, where you usually follow those topics you posted in, too.
Right now, people are overwhelmed in high-traffic streams, saying they can't keep up muting what they don't want, and I agree - because then when I have a conversation in a muted stream, I am likely to lose it.

Related use case: I'd like to be able to create a stream in which different movies are discussed, but I want to prevent spoilers. This could be done if a stream could be configured such that its topics are always 1) muted by default; and 2) hidden by default (except topic name). Users could then select from the topic list (movie titles) to reveal the discussions they want. Or they can create a new topic to discuss a movie they've seen that hasn't yet been discussed, without revealing spoilers to anybody by default.

Since we are making good progress on this issue in #24236, I filed #24243 with concrete steps for implementing the webapp UI.

I also filed #24246 as a follow-up, but I don't think it needs to be completed in order to consider this issue resolved.

@alya is my idea of subscribe-on-post with non-muted streams simply setting a default of subscribing to new topics captured somewhere in there?

We might not have this in an issue yet (we haven't gotten there yet in terms of work sequencing), but definitely have this in mind.

Reopening this thread because it's the issue for the user-facing feature, and that hasn't yet been completed. #24236 built part of this feature (the server backend), but at a minimum the feature isn't ready until it has a UI in the web app:

#24243

We'll also need the mobile app to implement the unmuting behavior:

https://github.com/zulip/zulip-mobile/issues/5362

so that when people unmute a topic and open the mobile app, they actually see the unmuted messages.

This is now completed for the server/web app via #24243 and the other issues. #zulip/zulip-mobile#5691 tracks the mobile app work for supporting it there.


Purpose
removed print statement that was annoying me
Proposed Changes

[ADD] ...
[CHANGE] ...
[FIX] removed print statement that was annoying me

coverage: 88.105% (-0.05%) from 88.153%
when pulling eb9eb9e6caea714502e27506a5686f01845f28c5 on mike-gangl-patch-1
into aec9b1c16c29ebdaab798c947f321ceb50a8ab64 on develop.


Oct 24 Meeting

Time: 3:00pm
Location: Online
Attendance:

[ ] Benjamin Chinnery

[ ] Michael Breau

[ ] Jessica Dawson

[ ] Matthew Curtis

[ ] Yaruo Tian

Agenda:

Meeting with Marie-Jean
Next steps for POC Prep

https://mcmaster.zoom.us/s/96176839532


the documentation web site

the documentation web site doesn't work normally

@edimedia please can you share what you see

I'm sorry, it's okay now, it seemed that the server was not sending the css


Field names causing NSUnknownKeyException

In our project, we have fields named "description", "start-time", and "end-time".
Because I cannot use hyphens in variable names in Swift, and because Resource contains a description field already, I constructed my model as follows:
class EventModel: Resource {

  var title: String?
  var date: Date?
  var startTime: String?
  var endTime: String?
  var descriptionText: String?

  var resource: ResourceModel?
  var reservation: ReservationModel?

  override class var resourceType: ResourceType {
    return "events"
  }

  override class var fields: [Field] {
    return fieldsFromDictionary([
      "title": Attribute(),
      "date": DateAttribute(),
      "start-time": Attribute(),
      "end-time": Attribute(),
      "description": Attribute(),

      "resource": ToOneRelationship(ResourceModel.self),
      "reservation": ToManyRelationship(ReservationModel.self)
      ])
  }

...

This setup causes me to have this error when dealing with start-time, end-time, and/or description:
2016-10-11 11:27:52.912 Office App[9723:451763] *** Terminating app due to uncaught exception 'NSUnknownKeyException', reason: '[<Office_App.EventModel 0x6080003efe00> setValue:forUndefinedKey:]: this class is not key value coding-compliant for the key start-time.'

Is there some configuration I'm using incorrectly or some way I can bypass this issue without having to rename fields in our API?

@Croge32
You have to use the override like this:
...
"startTime": Attribute().serializeAs("start-time")
...
and so on.


realm: add required topic setting on org level.

Lets organizations require users to specify a topic the discussion

Fixes: #5164

@franziskagoltz did you mean to close this?

@lonerz I did - I created a new one (had some git issues) - here's the new one: https://github.com/zulip/zulip/pull/5660


Update patterns

commands are first in a line
constants can contains more than \w, e.g. ${xml::CreateNode}
same goes for language strings

Thanks. Merged as 32d02f0


Improved User Information for XRTpy Abundance Feature

Description
I would like to suggest an enhancement to  provide better print/return information for users utilizing the abundance feature. Currently, when users use the abundance option, they do not receive any feedback regarding which abundance model is being used in the calculations.
Proposed Solution:
I propose implementing a return statement that informs the user about the specific abundance model being utilized in the calculations. This information should be displayed whenever the user employs the abundance feature within the XRTpy package. Furthermore, adding more details to the doc string  within the function.
This enhancement will significantly improve the user experience and help users have a clear understanding of the abundance models used in their calculations, facilitating better interpretation and utilization of the results.

In general I agree with the ideas behind this. However, the broader issue is the spectral model, given that we've talked about allowing more spectral models in addition to the Chianti ones. Maybe we should separate those two, i.e. the assumed abundance set and the spectral modeling code.
Here's a suggested approach: Make two new attributes of TemperatureResponseFundamental objects, the model_source and abundance_set. These attributes will be set when the TemperatureResponseFundamental is instantiated, so a mechanism for getting those values from included Chianti model data and from any other input plasma emission model would need to be implemented.
Do any other Sunpy affilliated packages do something like this?

Thank you, @jslavin , for the insightful suggestion! I agree with the approach to expand the scope of user feedback to include not just the abundance model but also the broader spectral model being used.
Regarding the suggested attributes:

model_source: Implementing an attribute like model_source to inform users about the source of the spectral model is a great idea. This attribute will provide transparency and context, especially when users are utilizing models from various sources such as Chianti, other databases, or custom models.
abundance_set: Similarly, the abundance_set attribute would be invaluable for users to easily identify the specific abundance model being employed in their calculations. This aligns directly with the initial enhancement I proposed and takes it a step further in providing comprehensive feedback.

We should discuss how best to implement these considerations. For the Chianti model data, this might involve parsing metadata. For other input models, we may need a flexible method that can adapt to different data formats. Should we also consider a required format for other input models?
I'm not sure if Sunpy affiliated packages do something like this. Perhaps we should tag @wtbarnes for insight? I am wondering if Sunpy/AIApy would be interested in developing a structured approach together to address this issue?

I wonder if the proposed SourceSpectra object in sunpy/sunkit-instruments#111 would address this, though much more generally. It would give the user an interface to specify any spectra they want, but xrtpy (or perhaps some other upstream source like sunkit-instruments) could also provide a set of precomputed spectra, e.g. using coronal and photospheric abundances.


Add patch to fix duplicate client id define

Fixes blocker in  https://github.com/electron/libchromiumcontent/pull/489.
This patch removed the define in Chromium to mitigate conflicts with Windows SDK's define.
/cc @ckerr @zcbenz @deepak1556

Have backported to 2-0-x here https://github.com/electron/libchromiumcontent/pull/489/commits/96084c6a3758281d8a2e658d4860552d955aaff9

The issue is fixed with building on an older sdk following upstream changes https://bugs.chromium.org/p/chromium/issues/detail?id=773476 https://github.com/electron/libchromiumcontent/pull/489/commits/3ad32ab74bd9889c94825df3a8fe3908e109e06b. The same fix is already available in master, so the crashpad patch need not be backported. Thanks!

@codebytere Based on the comment above, should we close this PR? )


Compilation error after migrating from Angular 13 to 15

Command
serve
Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
13
Description

ng serve --proxy-config proxy.conf.json

This is a simple server for use in testing or debugging Angular applications locally.
It hasn't been reviewed for security issues.
DON'T USE IT FOR PRODUCTION!

One or more browsers which are configured in the project's Browserslist configuration will be ignored as ES5 output is not supported by the Angular CLI.
Ignored browsers: kaios 2.5, op_mini all
✔ Browser application bundle generation complete.
Initial Chunk Files   | Names         |  Raw Size | Estimated Transfer Size
styles.css, styles.js | styles        | 398.39 kB |                57.87 kB
main.js               | main          | 118.77 kB |                29.05 kB
polyfills.js          | polyfills     | 118.77 kB |                29.04 kB
runtime.js            | runtime       |   1.25 kB |               681 bytes
                  | Initial Total | 637.17 kB |               116.61 kB

Build at: 2023-04-06T23:33:20.264Z - Hash: d96d42fe7f3c7221 - Time: 2443ms
Warning: 1 rules skipped due to selector errors:
legend+* -> Cannot read properties of undefined (reading 'type')
./src/main.ts - Error: Module build failed (from ./node_modules/@ngtools/webpack/src/ivy/index.js):
Error: Emit attempted before Angular Webpack plugin initialization.
./src/polyfills.ts - Error: Module build failed (from ./node_modules/@ngtools/webpack/src/ivy/index.js):
Error: Emit attempted before Angular Webpack plugin initialization.
Error: Failed to initialize Angular compilation - The target entry-point "angular-persistence" has missing dependencies:

rxjs/Rx

** Angular Live Development Server is listening on localhost:4200, open your browser on http://localhost:4200/ **
✖ Failed to compile.
Minimal Reproduction
Angular 13 project , yarn upgrade angular to 15.

ng serve --proxy-config proxy.conf.json

This is a simple server for use in testing or debugging Angular applications locally.
It hasn't been reviewed for security issues.
DON'T USE IT FOR PRODUCTION!

One or more browsers which are configured in the project's Browserslist configuration will be ignored as ES5 output is not supported by the Angular CLI.
Ignored browsers: kaios 2.5, op_mini all
✔ Browser application bundle generation complete.
Initial Chunk Files   | Names         |  Raw Size | Estimated Transfer Size
styles.css, styles.js | styles        | 398.39 kB |                57.87 kB
main.js               | main          | 118.77 kB |                29.05 kB
polyfills.js          | polyfills     | 118.77 kB |                29.04 kB
runtime.js            | runtime       |   1.25 kB |               681 bytes
                  | Initial Total | 637.17 kB |               116.61 kB

Build at: 2023-04-06T23:33:20.264Z - Hash: d96d42fe7f3c7221 - Time: 2443ms
Warning: 1 rules skipped due to selector errors:
legend+* -> Cannot read properties of undefined (reading 'type')
./src/main.ts - Error: Module build failed (from ./node_modules/@ngtools/webpack/src/ivy/index.js):
Error: Emit attempted before Angular Webpack plugin initialization.
./src/polyfills.ts - Error: Module build failed (from ./node_modules/@ngtools/webpack/src/ivy/index.js):
Error: Emit attempted before Angular Webpack plugin initialization.
Error: Failed to initialize Angular compilation - The target entry-point "angular-persistence" has missing dependencies:

rxjs/Rx

** Angular Live Development Server is listening on localhost:4200, open your browser on http://localhost:4200/ **
✖ Failed to compile.

No response

This particular line stands out to me:

Error: Failed to initialize Angular compilation - The target entry-point "angular-persistence" has missing dependencies:
rxjs/Rx

Note that angular-persistence was last released in 2017, whereas Angular 15 only officially supports libraries that have been built using Angular 13 to 15. I'd recommend to find an alternative for this dependency if it has gone unmaintained.

Closing as per above.


add methods for reading and writting data from an offset

It would be nice to support an option to read and write data from an offset.
const reader = require('ipfs-unixfs-engine').reader
promise = reader(CID, offset, length)

const writer = require('ipfs-unixfs-engine').writer
promise = writer(CID, offset, data)

There have been more requests for this feature - https://github.com/ipfs/js-ipfs/issues/348 I agree that we should have it. A simple version of dropping bytes would be simple enough to achieve the API, then we can optimize its perf.

The writer is a bit more complex, not sure if it belongs here. Essentially what would need to be done is to fetch the whole file, modify and chunk the whole thing again. There will be a bunch of nodes that get reused, but this slight bit modification would have to be aware of the graph builder and chunker used.

this slight bit modification would have to be aware of the graph builder and chunker used.

right, and also different chunking schema are going to have different optimal offset units too

The ship this was shipped on set sail ages ago 🚢 ⚓ 📦 🚀


Add export support for x3d.

A user sent a request to add x3d export support to VisIt. It seems like a useful feature. Here is the text of her e-mail. Hi, Recently, I have visualized a model in VisIt. I wanted to create a 3D image out of it for a website. VisIt does not have an opportunity to export x3d files directly. So I had to export a vtk file, open it in Paraview and export as x3d. Meanwhile, several visualization tools, such as Paraview, MeshLab, Blender, provide an x3d export. Is it planned to add this feature to VisIt as well? Regards,Elena Erastova
-----------------------REDMINE MIGRATION-----------------------
This ticket was migrated from Redmine. As such, not all
information was able to be captured in the transition. Below is
a complete record of the original redmine ticket.
Ticket number: 2296
Status: Pending
Project: VisIt
Tracker: Feature
Priority: Normal
Subject: Add export support for x3d.
Assigned to: -
Category: -
Target version: 3.0
Author: Eric Brugger
Start: 06/11/2015
Due date:
% Done: 0%
Estimated time:
Created: 06/11/2015 10:58 am
Updated: 08/27/2015 12:26 pm
Likelihood:
Severity:
Found in version: 2.12.3
Impact: 3 - Medium
Expected Use: 3 - Occasional
OS: All
Support Group: Any
Description:
A user sent a request to add x3d export support to VisIt. It seems like a useful feature. Here is the text of her e-mail. Hi, Recently, I have visualized a model in VisIt. I wanted to create a 3D image out of it for a website. VisIt does not have an opportunity to export x3d files directly. So I had to export a vtk file, open it in Paraview and export as x3d. Meanwhile, several visualization tools, such as Paraview, MeshLab, Blender, provide an x3d export. Is it planned to add this feature to VisIt as well? Regards,Elena Erastova
Comments:

Duplicates #2301. Some extra comments from there:
VTK has several classes related to X3D in their IO/Export folder:vtkX3D.cxx vtkX3DExporterJavaHelper.cxxvtkX3D.h vtkX3DExporterJavaHelper.hvtkX3DExporter.cxx vtkX3DExporterWriter.cxxvtkX3DExporter.h vtkX3DExporterWriter.hvtkX3DExporterFIWriter.cxx vtkX3DExporterXMLWriter.cxxvtkX3DExporterFIWriter.h vtkX3DExporterXMLWriter.hvtkX3DExporterFIWriterHelper.h


Remove reference to Message Analyzer

Since the product was retired on November 2019, It makes sense to remove links to that product.  See below for retirement reference.
https://docs.microsoft.com/en-us/message-analyzer/microsoft-message-analyzer-operating-guide

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 74bb4b25-ebe2-264d-047d-3f651c52a9c5
Version Independent ID: aed6ebef-6157-9608-3f85-0807c7fdf61d
Content: Implement a secure hybrid network architecture - Azure Reference Architectures
Content Source: docs/reference-architectures/dmz/secure-vnet-dmz.md
Service: architecture-center
Sub-service: reference-architecture
GitHub Login: @MikeWasson
Microsoft Alias: pnp

Hi @BittahCriminal Thanks for your feedback. We will review and update as appropriate.

@BittahCriminal PR has been created for this which will address this. Thanks so much for providing the feedback that help us in improving the documentation. For now I will proceed with closure of this and If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Custom MD5 and SHA1

Hi, I want to put MD5 and SHA1 in to text file so when DirectoryLister want it will get checksum from text file but won't recalculate everytime I click info button because I have a very large file it may take very long time.

I am working on a way to put MD5 SHA1 of all the files in a folder into a single file (checksums.md5 or checksums.sha1) in the same format that the unix/linux command uses so you can later run and verify your MD5 SHA1 or you could send the file to someone else and they can check their hashes


Add release workflow to automatically create RPMs

When a release is cut this change will now automatically create an RPM
and upload it to the local github artifact cache.

a stub has been added so that we can also enable automatic pushes to
PYPI. This will require a PYPI API token stored in github before it
can be activated.

Signed-off-by: Kevin Carter<EMAIL_ADDRESS>

Once we have a source tarball built for task-core we can use pyp2rpm to build a better, more complete spec file, however, this should mostly work as is.

Handled via fecd62d9c79d8da21cc13a444e55324a29a21194


level vs localization

we have
decreased protein level at centromere outer repeat heterochromatin
should this move to
decreased protein localization  at centromere outer repeat heterochromatin
(7 annotations)
Also, do
decreased protein localization  at centromere outer repeat heterochromatin
have decreased protein level  as related synonyms (I did not add to new terms)

There is also some confusion between protein localization to actomysis contractile ring and
localization to contractile ring. I think there are annotations describing the same thing
e.g.
"decreased protein level in actomyosin contractile ring during mitotic interphase

Also "increased protein level in chromatin

"


Provider labels missing in node creation

Regression in refactoring, provisioner used to do automatic provider labels

Fixed in #4


Enable -Wthread-safety-analysis.

These would have flagged on https://github.com/google/iree/pull/2208.

The warning on #2208 is a false alarm though given the lambda is only used inside the function, which acquires the lock at the very beginning.


Add content-type header = application/json for create and update actions

Following PR  Split codec from scheme #17922 on k8s server.

@abonas this is a serious issue (backported from master) that we want to fix in v0.8.z releasing a v0.8.1.

@abonas this is a serious issue (backported from master) that we want to fix in v0.8.z releasing a v0.8.1.

what is the reason for the need in 0.8.z and not taking the last gem release containing the fix?
btw did you check the watches area? perhaps it is of a need in a similar fix too (I saw briefly someone commenting on content type and watches in the k8s side of things)

what is the reason for the need in 0.8.z and not taking the last gem release containing the fix?

@abonas because between v0.8.0 and v1.1.1 there are 654 insertions and 96 deletions spread over 17 files. Also, the new dependency on recursive-open-struct = 1.0.0 and the new http gem.
You don't want to bring all those changes to applications that are already in production and they just need this fix.

agreed, you have my blessing :)


Nuke: anatomy imagio bake display/view profile

Describe the bug
Profile is randomly misconfigured in case of default profile name sRGB (ACES).  Also client is requesting different display parent which can only set with path syntax. At the moment it is defined with () and not working
Expected behavior
Display parent profile and viewer profile set correctly
Solution
Be able to use ViewerName (DisplayName) as it is now, but by extractions what is in parentheses and setting it on display knob all will be fixed.
And if the baking profile will be sat that way, code has to be fixed to accept it as follows in openpype\hosts\nuke\api\plugin.py:531.
dag_node = nuke.createNode("OCIODisplay")
dag_node["display"].setValue("DisplayName")
dag_node["view"].setValue("ViewerName")

implemented via https://github.com/ynput/OpenPype/pull/4009


report error on breakpoint with invalid line num

@matthewloring PTAL.

LGTM after the nit.

LGTM.

Landed in https://github.com/GoogleCloudPlatform/cloud-debug-nodejs/commit/fbac50d6570a1eb43ed0b72a9f4676e8d09a783f.


[CUR-285] fix: removed 'examboard' text from school phase picker

Description

School phase picker had "exam board" above the school phase.

How to test

Go to https://deploy-preview-1950--oak-web-application.netlify.thenational.academy
Click on subject phase picker
You should see the heading for School Picker and no other text

Screenshots
How it used to look (delete if n/a):

How it should now look:

Checklist

[ ] Added or updated tests where appropriate
[ ] Manually tested across browsers / devices
[ ] Considered impact on accessibility
[ ] Design sign-off
[ ] Approved by product owner

:tada: This PR is included in version 1.260.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Warning after adding siren on gem file

Hi,
I don't know if can help me but:
After i've added siren to my gem file, this message started showing when I run some tests or start the rails console.
/Users/{user}/.rvm/gems/ruby-2.0.0-p247@project/gems/methodphitamine-    1.0.0/lib/methodphitamine/it_class.rb:14: warning: undefining `object_id' may cause serious problems
/Users/{user}/.rvm/gems/ruby-2.0.0-p247@project/gems/methodphitamine-1.0.0/lib/methodphitamine/it_class.rb:14: warning: undefining `__send__' may cause serious problems

Can you guys help me ?
Thanks

This issues is still present


Scraper: Cannot parse JSON response 'NoneType' object has no attribute 'json'

Whenever I try to use the scraper, I keep getting None responses with the error below
>>> tweets_details = scraper.tweets_details([1770164518758633590], count=100, limit=100)
TweetDetail: 100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████| 1/1 [00:01<00:00,  1.82s/it]
Cannot parse JSON response 'NoneType' object has no attribute 'json'

Is there a problem with the Scraper module?

This is a common issue, usually this means your cookies have expired, a pending security challenge, rate limit, or an account block.
You can log-in using the browser and see if everything is working, then copy your cookies and run your script again.


test-branch/execute-job/quoted-authorization/b1893a3d-2ecf-4365-ba73-74d3dbc38629

PR for testing 94ba62b220624f1e49caba1d8ea67839ecea075d

/canonical/self-hosted-runners/run-workflows 94ba62b220624f1e49caba1d8ea67839ecea075d


*: First commit

Fork from contour-operator & adjust to match to the sesame-operator

@JaredTan95 please help to add the flows same as the sesame reop.


Error Parsing Regular Expression with s Flag in Langium Grammar

Description
I am developing a simple prototype language called DemoLanguage using Langium and encountered an issue while trying to define a grammar that supports multi-line content. The intended syntax should support conditional sections with multi-line content, delimited by #endif.
Grammar Definition
Here is the grammar definition I am using:
grammar DemoLanguage

entry Model:
    (sections+=Section)*;

Section:
    condition=IfCondition
    content=CONTENT
    '#endif';

IfCondition:
    '#' '[' decision=('y'|'n')? ']' 'if' conditionExpr=TEXT+;

hidden terminal WS: /\s+/;
terminal CONTENT: /.*?(?=#endif)/s;
terminal TEXT: /[a-zA-Z]+/;

hidden terminal ML_COMMENT: /\/\*[\s\S]*?\*\//;
hidden terminal SL_COMMENT: /\/\/[^\r?\n]*/;

Expected Syntax
The expected syntax for the language is:
# [y|n|] if <condition_statement>
<multiline_content>
#endif

Problem
When trying to generate the corresponding grammar, I receive the following error:
Error: Unable to use "first char" lexer optimizations:

        Failed parsing: < /.*?(?=#endif)/s >
        Using the @chevrotain/regexp-to-ast library
        Please open an issue at: https://github.com/chevrotain/chevrotain/issues

It seems that the s flag (Dotall mode) is not being correctly parsed by the @chevrotain/regexp-to-ast library. The goal is to consume newlines within the CONTENT terminal to support multi-line content until the #endif delimiter.
Steps to Reproduce

Define the above grammar in a Langium project.
Attempt to generate the corresponding grammar.

Additional Context
I have tried different approaches to define the CONTENT terminal to include newlines, but the s flag seemed to be the most straightforward solution until this error occurred. Any guidance or alternative approaches to achieve the desired functionality would be greatly appreciated.

I hope this detailed description helps in addressing the issue. Thank you for your assistance.

@pbrostean Thanks for the report, I can confirm that the s leads to the behavior you're experiencing.

Any guidance or alternative approaches to achieve the desired functionality would be greatly appreciated.

You can instruct the DefaultTokenBuilder to use a CustomMatcherFunction instead of the default regex behavior. See:
https://github.com/eclipse-langium/langium/blob/3e62f1ab42e0a2063314ddd82a2772914037c8f0/packages/langium/src/parser/token-builder.ts#L65-L75
You can create a new TokenBuilder that extends DefaultTokenBuilder and overrides the requiresCustomPattern method to return true when the s flag is used. That would also likely be the fix we'll implement for this.
Note that the terminal CONTENT: /.*?(?=#endif)/s;  isn't valid, since it potentially consumes nothing. All tokens need to consume at least one character. Replacing .* with .+ should do the trick.

@msujew Thanks for your quick reply, that seems to have solved the problem so far!
If someone wants to implement a similar approach, here is my working solution:
...
terminal EOL: /\r?\n/;
terminal EXPRESSION: /(?<=if\s).+?(?=\r?\n)/;
terminal CONTENT: /(?<=\r?\n).+?(?=\r?\n#endif)/s;

With the following ovverride for the s flag:
import { DefaultTokenBuilder } from "langium";

export class CustomTokenBuilder extends DefaultTokenBuilder {
    protected requiresCustomPattern(regex: RegExp): boolean {
        if (regex.flags.includes('u') || regex.flags.includes('s')) {
            // Unicode regexes are not supported by Chevrotain.
            return true;
        } else if (regex.source.includes('?<=') || regex.source.includes('?<!')) {
            // Negative and positive lookbehind are not supported by Chevrotain yet.
            return true;
        } else {
            return false;
        }
    }
}

Injected here:
...
/**
 * Dependency injection module that overrides Langium default services and contributes the
 * declared custom services. The Langium defaults can be partially specified to override only
 * selected services, while the custom services must be fully specified.
 */
export const DemoLanguageModule: Module<DemoLanguageServices, PartialLangiumServices & DemoLanguageAddedServices> = {
    ...
    parser: {
        TokenBuilder: () => new  CustomTokenBuilder()
    }
};
...

@pbrostean Glad to hear that this solved your problem. I'll reopen this issue, since we can solve this in a generic fashion in the framework.


Rephrase results.yaml documentation and examples

The documentation existed, but it was repeated in multiple places, several fields were not described, and recent changes were missing completely. So trying to improve all that, with a detailed format description, pointer to a schema and more words to accompany them.

Looks much better now, thanks! I've covered a couple of minor typos and adjustments in 8fd64cd. Please, have a look if everything's ok.

LGTM, thanks for the polishing.


Interpolation + parentheses weirdness

Following code:
myfunc("#{something)}"

... is actually a valid CoffeeScript code. It seems that the compilator sees no difference between:
myfunc("#{something)}"
myfunc("#{something}")

This is fixed on master. @jashkenas: it's getting to be that time again. We're getting a bunch of duplicate bug reports because we need to push out another point-release.

Yes, let's do it.

I just wish I had had the time to fix to a few more issues (those assigned to me) and to review 3 or 4 particular pull requests before this time came.


Fix hip compilation

Fixes no known conversion from 'int **' to 'void **' compilation error during hip compilation
I've run into this with both the cce and rocmcc compilers

This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch.

Merged in next for testing...


iOS 10

Hello, I've tried to run my app on an iOS 10 device with xCode 8. But I have many problems, is SwiftForms al ready for iOS 10 in xCode 8?

Haven't proved it on iOS 10 yet. Sorry for the inconvenience.


s -> search and i -> info aliases

For convenience, what the title says.

@satazor What do you think? I like s but worry i could get confused with "install"...

@sataroz I agree on the i
How about a for aliases or n for info

I'm ok with both.

@flesch you can merge

I actually think i is ok, npms will never have a install command so the confusion is less important..

👍  I'll try to push this out tonight.

@flesh let me know when you are done and I will pull it down and add the associated tests. Will delay my update w/ all new tests

@larsw Is this working for you? npms s babel says "Unknown arguments: s, babel".
Related to https://github.com/yargs/yargs/issues/121?

Apparently yargs does not support aliasing commands just yet.. Closing this for now.


fix: Correct the id value passed to .unlinkIdentity() method

Just implemented manual linking, and found that the unlink method just doesnt work cause the wrong id is used.
AuthException(message: identity_id must be an UUID, statusCode: 400)

Here's the fix :)

Thanks for this fix!


Feature Request: Configurable width for .pcr-app

Do you want to request a feature or report a bug?
Feature
What is the current behavior?
The width of the pickr is fixed at 28.5rem. When displaying only swatches it is rather wide. I would like the option to be able to customise the width.
Currently like this:

What is the expected behavior?
I would like to be able to set a narrower width like this:

You can change the width of .pcr-app any time using custom css like
.pcr-app {
    width: 15em;
}

This would change the width of all pickr's on the page. Specifying the width of a single one would require a extra class which could be an additional option...
Btw. The spaces between the swatches on the first Screenshot are too thin, which browser did you use? It uses flex as fallback, but there should be always some spacing like in your second screenshot :suspect:

Hey Simon. I would like, if possible, to be able to set it on a per pickr basis. Would it be possible to add an option to add an extra class name to the created element?
Both the first and second screenshots are from Chrome 73 on Mac Mojave, the only difference being I changed the width on .pcr-app.

Splendid :)

Wups, will be added!

Confused me for a moment there ;-)
Thanks @Simonwep!

Setting  grid-template-columns: repeat(auto-fit,2.1rem); on pcr-swatches seem to look better?

Ugh, yeah accidentally  pressed close-and-comment. GitHub should request a user-confirmation for this haha
Okay, a appClass option got added in 7a16947120cbe686a0f552a7324ff37469682797:
{
    appClass: 'my-custom-class'
}

Will be simply applied to the pcr-app element.
Regarding the grid, the width's between the swatches would be not the same as on the y-axis:

I have no clue why there's no gap :suspect: The swatches itself have a margin of ~2px. So technically this shouldn't be possible...

Thanks for the change!
That's weird. The horizontal and vertical separation looks good for me with repeat(auto-fit,2.1rem) with both the regular and narrower width:

I'm wondering if I've got something else in my CSS somewhere that's causing this... I have zero experience of flex-grid, we're still supporting IE11 (although not for this bit of the app!).

Thanks @Simonwep !

@elgordino Just published 0.5.1 where appClass is available :)

Awesome! Thanks!


:seedling: bump markdownlint-cli2 to v0.12.0

With fixes to formatting.
Manual cherry-pick of #699

/override metal3-ubuntu-e2e-integration-test-release-1-7
/retitle :seedling: bump markdownlint-cli2 to v0.12.0

/cc @kashifest

/retest
Flake

/approve

/retest


Update for game version v21.5.0

This PR was created by comparing game versions 20.1.0 (before the Alt Costumes update) and 21.5.0 (Garfield Update) decompiled with ILSpy.
I created a local repo and committed the contents of 20.1.0, then added in the contents for 21.5.0 and manually checked the differences to see what changed.
I may have missed something, it's difficult to be sure. I was able to convert Garfield's moveset char_orb using this new version.
Before the changes in this PR, NASB_Parser failed to convert his moveset.

Ok, I think I've fixed the accessibility modifiers and the formatting.
Also fixed the forceZ in the HurtBone class. It seems they are just ignoring it now.

I did another pass on the changes today and noticed a few mistakes in my PR.
Also, to fix the test case, do I need to simply update the char_apple.txt?


Please update docs for REST interface

Is your feature request related to a problem? Please describe.
I'm trying to access an azure signalR service from a php server through its rest interface.
Unfortunately it is highly totally what parameters are accepted or required in the payload, so it is a cumbersome trial and error process with rather cryptic error messages.
Describe the solution you'd like
Please update the docs accordingly for payload parameters, maybe create a list of most common error codes and what they mean or how to solve them.

Do you mean the data structure for payload parameter https://github.com/Azure/azure-signalr/blob/dev/docs/swagger/v1.json#L939? Actually, payload parameter can be in any type, what error message did you see with different payload parameters?


Converted config array into object

Hi,
I converted the $localconfig array into object of type Config. It is now working with Phalcon 2.0.3.
I used an object of anonymous type which I think was introduced in PHP 5.4 . Thus I think it would now be incompatible with php 5.3 and below. But given modern nature of Phalcon, I think anyone who would want to use this would also keep their php version updated.
I also added an Nginx config sample for anyone who would want to use it.

Thanks Abhinav, I'll merge this in either later today or over the weekend.

There is no hurry.  It is still not perfectly working on Phalcon 2.0 .  I am getting a warning.
Strict Standards: Declaration of Base\Model::addBehavior() should be compatible with Phalcon\Mvc\Model::addBehavior(Phalcon\Mvc\Model\BehaviorInterface $behavior) in /var/www/Phalcon-BoilerPlate/app/base/Model.php on line 0

I tried typecasting it but it went haywire. Still working on some other workaround.

Yea, I figure as much. I'm going to run a full test through on 2.0.3. I might make a few updates to your branch before merging.

This has been merged in to master. I created a separate branch for 1.3.5 and now master is the current 2.0.x version. Thanks again for your help Abhinav, please let me know if you find any other bugs.

I have been trying to find a solution to this warning since I made the pull request. This does not disturb working of the boilerplate but I do not prefer to ignore warnings.
Strict Standards: Declaration of Base\Model::addBehavior() should be compatible with Phalcon\Mvc\Model::addBehavior(Phalcon\Mvc\Model\BehaviorInterface $behavior) in /var/www/Phalcon-BoilerPlate/app/base/Model.php on line 0

So far a suggestion on http://stackoverflow.com/questions/3115388/declaration-of-methods-should-be-compatible-with-parent-methods-in-php has helped me to get started but I am going nowhere.
I will try to update in few more days.

Hi Abhinav, this should be resolved now. If you pull the latest from #master you should no longer get this warning. I updated the way behaviors work for 2.0.x.


Error when replicating example

Hi there, thanks for this package and intro notebooks, all very informative!
I've tried to replicate an example using your dataset arma_data.csv. I get an error raised by tensorflow here it is: https://pastebin.com/SVP2yigy
Similar error when I replicate the random walk process example (in one of your notebook). This 2nd one tells me that tensorflow_probability seems not to cause problems (i.e. I can simulate data using tf-probability).

Hi @raffo85h , thanks for opening this issue!
You're right, I've just confirmed here and what seems to be the cause is the newest version of tensorflow probability 0.12.0 (it was published yesterday a few days after I've tested the whole package using version 0.11).
For now, the best recommendation would be to downgrade to version 0.11.1:
pip install tensorflow_probability==0.11.1

I've opened this issue on their repository asking for guidance on what's happening (it's related to a bijector that tfcausalimpact uses for modeling the prior on local level), hopefully we'll get an assistance soon.
If you still have any issues please let me know.
Best,
Will

Hi @raffo85h ,
I've just fixed this issue :)
You can just run pip install -U tfcausalimpact and the newer version will work just fine.
Thanks once again for opening this issue. Please let me know if this is solved for you before I close it.
Best,
Will

Hi @WillianFuks do you mind to update the setup.py accordingly? As you might know (see this) I'm trying to build a conda package out of this. As today I have some spare time I was working on it but I had some ptroblems.

Hi @rpanai ,
Not sure what's wrong with setup.py, as it is today the PyPI API accepts it appropriately. If you want you can start a new issue reporting the errors you are getting and we work from there.
Best,
Will


The tokenizer does not have a {% if add_generation_prompt %}

Hi,
After I upgraded unsloth from 2024.11.5 to 2024.11.7, it raised the error that the tokenizer does not have a {% if add_generation_prompt %}.
The model is shenzhi-wang/Llama3.1-8B-Chinese-Chat. It has the following chat template:
{% set loop_messages = messages %}
{% for message in loop_messages %}
    {% set content = '<|start_header_id|>' + message['role'] + '<|end_header_id|>

    '+ message['content'] | trim + '<|eot_id|>' %}
    {% if loop.index0 == 0 %}
        {% set content = bos_token + content %}
    {% endif %}
    {{ content }}
{% endfor %}
{{ '<|start_header_id|>assistant<|end_header_id|>

' }}

Could you check and fix it?

@Galaxy-Husky Ye so the chat template for that model looks incorrect - it should not have {{ '<|start_header_id|>assistant<|end_header_id|>\\n\\n' }} by default, but rather {% if add_generation_prompt %}{ '<|start_header_id|>assistant<|end_header_id|>\n\n'`

@Galaxy-Husky Ye so the chat template for that model looks incorrect - it should not have {{ '<|start_header_id|>assistant<|end_header_id|>\\n\\n' }} by default, but rather {% if add_generation_prompt %}{ '<|start_header_id|>assistant<|end_header_id|>\n\n'`

Yes, I agree.
But 2024.11.5 will help me add  {% if add_generation_prompt %} to fix the template while 2024.11.7 will not and I can't use the model.
Is this the expected behavior?

@danielhanchen Hi! Would you consider continuing to support fixing such templates?


Provide range of years not just starting one

Otherwise gives feeling of being stale

@yarikoptic
we can add this but remember that the starter kit is aimed to be merged into the new bids website

sure. I will ensure that new website also would have up to date years ;)


Expose config to non org-wide admins

I'm trying to set up pep8speaks for astroquery.
However it's rather inconvenient that it requires an org-wide admin to do any of the configuration rather than someone who has write access to the given repo. E.g. all the CI services, RTD etc.

@OrkoHunter - Thanks for the quick response. We do have the .pep8speaks.yml, https://github.com/astropy/astroquery/blob/master/.pep8speaks.yml, but the bot doesn't pick up the PRs or respond to commands.

Also, this is the settings page. We enabled it organization wide, but something is still not right.

The bot picks the .pep8speaks.yml file from the branch of the PR (similar to how Travis does). Since, the config file was added to the repository very recently, the bot will not be able to find the file for already existing PRs unless they are rebased with the current master branch.
The bot is expected to create as little noise as possible. So, it will make a comment only if it finds any pep8 issue.

Would it be okay if I create a PR on the repository for testing it out? I might find a new bug.

@bsipocz There was indeed a bug (a version mismatch between pycodestyle and autopep8). Thank you for reporting. I've pushed the latest version and now it's working. :)
https://github.com/astropy/astroquery/pull/911#issuecomment-301049147

I assumed that it needed a rebase, so https://github.com/astropy/astroquery/pull/894 was rebased for that purpose :)
Thank you very much for finding the bug and fixing it! I first say pep8speaks in sunpy, and changed my mind about these bots (really disliked the coveralls bot that leaves useless comments for every commit). I think this bot will be very useful for us on the long term to teach all our new contributors our coding guides in a friendly tone.
The plan is to eventually use it in more repos, astroquery is out test case. If everyone is happy with the experiences, I will push to get this enabled for our other packages as well.

@bsipocz I'm always thankful to sunpy, the current and improved version of PEP8Speaks would not have been possible by the efforts of @cadair et al.
I can see a lot of astropy repositories in my users list for which pep8speaks is installed, including astropy/astropy. Are you not aware of it? It was installed couple of hours ago only.

I believe we have enabled that for everything, but don't yet have the yml file, so in my understanding it should not run yet.

Oh! But pep8speaks does not need the yml file to work (unlike travis). It will eventually run with the default PEP8 configurations. I'm sorry that it was not clear in the readme. So, I think the org admin will need to take the pain of removing it if it is not intended to run on repositories other than astroquery.

Would the config understand a list of errors, or should I list them one at a line?
pycodestyle:
  max-line-length: 100 # Default is 79 in PEP8
  select: E101,E111,E112,E113,E124,E201,E202,E203,E211,E221,E225,E231,E241,E251,E261,E265,E271,E272,E301,E302,E303,E305,E502,E7\
03,E711,E712,E714,E722,E901,E902,W191,W291,W292,W293,W391

@OrkoHunter - Below is what I see.  That looks to me like only astroquery is activated?  Or am I misunderstanding?

This is correct ! It's only working on astroquery now. Maybe the "for all"
option was accidently clicked before and GitHub sent me a bunch of other
repositories' names.
On Fri, May 12, 2017 at 7:03 PM Erik Tollerud<EMAIL_ADDRESS>wrote:

@OrkoHunter https://github.com/orkohunter - Below is what I see. That
looks to me like only astroquery is activated? Or am I misunderstanding?
[image: image]
https://cloud.githubusercontent.com/assets/346587/26000163/2f32371a-3728-11e7-8d96-51b78e51b7f8.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/OrkoHunter/pep8speaks/issues/45#issuecomment-301077363,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHsTeYLva0pedMumRY4Pp6pasQaEtkiqks5r5F-UgaJpZM4NZCzS
.

--
Himanshu Mishra
Fourth Year Undergraduate
Mathematics and Computing
IIT Kharagpur
https://orkohunter.net

Ah, yes, that's exactly what happened: I turned it on momentarily just to see if that would make it speak, but that must have been just when you looked.

@OrkoHunter - it appeared when we turned it on astroquery the first time, nothing happened (until you tried pinging @pep8speaks)... can you clarify what the correct steps are in the future if we decide we want to turn it on in other repos?

@eteq The reason why it didn't work was a bug which I have mentioned in the comments above. The  correct step is simple, you just choose one of the two options in the repository access menu, and then GitHub will start triggering pep8speaks for those repositories. :)

@bsipocz Sorry for the late response.

Would the config understand a list of errors, or should I list them one at a line?

The select and ignore expects its arguments to be a list in the yml format. Unfortunately the default implementation cannot interpret the comma separate options. (Tested here). Hence the current (and ugly) way to use it, will be
select :
  - E101
  - E111
  - E112
  - E113
  - E124
  - E201
  - E202
  - E203
  - E211
  - E221
  - E225
  - E231
  - E241
  - E251
  - E261
  - E265
  - E271
  - E272
  - E301
  - E302
  - E303
  - E305
  - E502
  - E703
  - E711
  - E712
  - E714
  - E722
  - E901
  - E902
  - W191
  - W291
  - W292
  - W293
  - W391

@OrkoHunter - exclude also expects the list to be in yml format, right?

Yes, I believe that is correct.
On Wed, 28 Jun 2017, 19:57 Brigitta Sipocz<EMAIL_ADDRESS>wrote:

@OrkoHunter https://github.com/orkohunter - exclude also expects the
list to be in yml format, right?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/OrkoHunter/pep8speaks/issues/45#issuecomment-311676468,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHsTedF7IcayV0deSGwpiyEiv5_8XnlDks5sImLHgaJpZM4NZCzS
.

--
Himanshu Mishra
Fourth Year Undergraduate
Mathematics and Computing
IIT Kharagpur
https://orkohunter.net

Hello @bsipocz !
Since you have multiple exclude options in the .pep8speaks.yml of astroquery, I would like to inform you that there was an issue ( #52 ) in the exclude config of pep8speaks, which is supposed to be fixed by now! :)

Thanks @OrkoHunter for the heads up. I haven't noticed any issues, those file excluded are hardly ever touched (as being copied there from upstream packages or generated on the fly).

Please re-open if any comment/query has not been addressed. :)


FLAG_enable_testing_pragmas broken on -precomp-win-

It appears that at least one FLAG_.. is broken when running precompiled on Windows.
An easy way to replicate this is by removing the if(!FLAG_..) .. check in runtime/vm/native_api_impl.cc.
After which the following tests will fail:

vmspecific_regress_37511_test
vmspecific_regress_37511_callbacks_test
vmspecific_function_gc_test
vmspecific_function_callbacks_test

Importantly, removing the above line should not have any effect on these tests as they each explicitly set:
// VMOptions=--enable-testing-pragmas ...
Meaning the condition removed should always be a no-op.
It's quite possible this issue is related to https://github.com/dart-lang/sdk/issues/40579

Tentatively triaging into area-vm

I have verified that linking against dart_precompiled_runtime.lib makes this issue go away:
https://github.com/dart-lang/sdk/blob/28c784d87b0def07e63a1d5053fb9e7b6240c635/runtime/bin/BUILD.gn#L1050-L1052
I've noticed that dart_precompiled_runtime.exe will load the ffi_test_functions.dll and then load dart.exe, which leads me to believe that the flags are failing because they're loaded from the latter instead of dart_precompiled_runtime.exe.
The command line arguments are not passed to dart.exe when it is loaded.
So the root cause appears to be https://github.com/dart-lang/sdk/issues/40579.
In the short term I'm adding skips to the status files for *-precomp-win-*, and long term we should address https://github.com/dart-lang/sdk/issues/40579.

The specific issue here (and in https://github.com/dart-lang/sdk/issues/46061) has now been addressed, and any remaining work is related to https://github.com/dart-lang/sdk/issues/40579.


chore: move from js to css fist animation (WIP)

[x] works with view-transitions
[x] works on the big screen
[ ] fix on smaller screens (messy)
[ ] probably sucks on huge screens

though this was going to be much easier lol, probably going to leave this in draft
Seems both view() and scroll() are currently insufficient in css and tailwind is lacking the scroll animation support.

seems like a dead-end


feat: Added Greek language

Description
Added Greek Language

Code adjusted, thanks for letting me know where the issue was :)

Thanks


Longer timeout for protoc artifacts on macos

Fixes https://github.com/grpc/grpc/issues/13806.
Both failures are timeout of the protoc build on mac (at 1800seconds).

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences


Plot PDOS after finding Euler's angles automatically

Thank you for the great code, It's the what I was looking for.  I did DOS calculation with LORBIT = 14 and then run find_angle.py for my structure ( contain different type transition metals and those octahedrals are tilted with different angle). So I am looking for how to plot PDOS for each $d$ orbitals after finding Euler's angle. I tried to modify your code rot_pband_plot.py for plotting $m_l$ projected PDOS, but unable to do that. If you provide the modified script for PDOS, it will be very helpful for me. Thank you in advance.

Hi @CrankyBot2001, the rot_pband_plot.py script is only for projected band structure plots. I've uploaded a script that can give you the pDOS plot (https://github.com/Chengcheng-Xiao/RotSph/tree/master/example/automatic_rotation).
I would really appreciate it if this repo can be cited using the following temporary BibTeX entry in any publication that utilizes this code:
@Misc{rotsph,
   author = {Chengcheng Xiao},
   title = {rotsph: a code to calculate the rotation matrix of real spherical harmonics},
   howpublished = {\url{https://github.com/Chengcheng-Xiao/RotSph}}
}

I do have a plan to merge this functionality to pymatgen in the future so this BibTeX entry will be updated in due time.

Thank you @Chengcheng-Xiao , I will let you know after calculating PDOS. I will definitely cite your code in my research. I want to confirm few things, that is the Fermi energy shifted to 0eV in this PDOS plot? As my system contains 66 atoms and so many octahedrals , I hope this code able to project $d$ orbitals along z axis for all transition metal. I want to select more than one atom and select all $d$ orbitals to plot $t_{2g}$-$e_g$ resolved DOS. Again thank you for your great code.

I hope this code able to project orbitals along z axis for all transition metal.
By z axis I assume you mean in the rotated frame?

I want to select more than one atom and select all orbitals to plot t2g-eg resolved DOS and also want to plot spin-polarized DOS.
rot_pdos_plot.py output the results in pdos.dat, For your purpose, you can run it multiple times with different input parameters and manually add the results together and plot the sum yourself.

Spin polarized calculation require a small re-write of the script.
The input should be:
0      |  6   |  Euler alpha | Euler beta | Euler gamma | dos E min | dos E max | dos points | smearing Sigma| spin |
Atom 0 |  dz2 |  -135        | 0          | -54.75      | -2        | -2        | 100        | 0.1           | 1 (up) or -1 (down) |

Yes I meant that. Yes I will sum those orbitals contribution to get t2g-2g pdos, and what about the Fermi energy, is it shifted to zero in your code?

Look @Chengcheng-Xiao, after performing auto rotation of my 1st transition metal atom and plot pdos(E-F=0eV) for that particular atom, still I am getting plot like this where I couldn't distinguish which orbital is contributing where explicitly, getting mixed things at a particular energy point,

To me this plot actually looks pretty good: $eg$ orbitals are located at ~3 eV and $t_2g& orbitals are at ~2 eV.
I guess you are confused by $eg$ orbitals being composed by $d_{z^2}$ and $d_{xy}& instead of $d_{x^2-y^2}$. This because another 90 degree rotation along the optimum z axis is needed to get you exactly what you want.
While the optimum z axis is easy to find using the auto rotation routine I've developed, the exact optimum sets of angles are harder to find. This is because $d_z^2$ is not symmetrically related to any other d orbitals while $d_{xy}$ and $d_{x^2-y^2}$ orbitals and $d_{xz}$ and $d_{yz}$ orbitals are related to each other by a 90 degrees rotation along the z axis.
At the moment I'm only searching a rotation frame that gives the largest TOTAL projection coefficient. Because of the symmetry relation I just mentioned, this will usually not give you the exact best rotation frame (as the sun will be the same!). I have some idea to solve this but more playing around is needed.
Finally, in case you are also wondering, the small peak located at around -5 eV are due to hybridization with other orbitals.

Now sitting down and thinking about this, I'm not sure another 45-degree rotation along the optimum z-axis should be applied.
Because I'm using the square of the projection coefficients, any addition rotation along the optimum z-axis should show up as a sizable reduction to the total projection coefficient. Now I'm not sure where went wrong in your calculation.
Could you upload your INCAR POSCAR KPOINTS POTCAR PROCAR EIGENVAL file so I can give it a closer look?

Yes, I get your points. Yes for a single atom from my system(total 9 $Ti$ atom) I able to distinguish each orbitals. What I showed you it was for close to $Ti^{4+}$ single atom. Now I know in my system some $Ti$ contains $+3$ , and some $+4$ states. So I want to select all $+4$ active $Ti$ atoms to plot $t_{2g}-e_g$ resolved pdos. So when I am selecting 2 $+4$ active atoms and plotted  pdos by adding up those two atoms contribution, then I am getting like this,

So, to report in paper should I plot single atom resolved pdos or all $+4$ active  pdos and $+3$ active pdos separately?

Based on the limited information I have. I would suggest you find Ti atoms with the same site symmetries (not just valence) and only plot a single representative pDOS for each category. I don't think plotting combined pDOS is a good idea because a 90-degree rotation along the local z-axis might still lead to interchangeable $d_{xz}$ and $d_{yz}$ labeling.
In the meantime, I recommend against using $eg$ and $t_2 g$ tables because the previous pDOS plot indicates other symmetries are more suited.
I'm sorry but I don't think I can provide any more help analyzing specific chemical properties of your system, as it is out of the scope of this issue and repo.

Yes, now I am doing each octahedral pdos except sum over pdos. But what I found for some Ti4+ atom $d_{xy}$ orbital under $t_{2g}$ and for another Ti4+ atom I saw $d_{x^2-y^2}$ orbital under $t_{2g}$, I couldn't understood what is the the physical significance of these two orbitals interchange. Furthermore, after finding Euler's angle for $Cr^{+3}$, I got this PDOS,

here, $d^{x^2-y^2}$ orbital and $d_z^2$ are degenrate under $e_g$ that's ok. But why $d_{xy}$ orbital not present in occupied section and why this and $e_g$ orbitals are in same energy point?

I have two suggestions:

$e_g$ and $t_2g$ categorization is NOT a law. It is based strictly on octahedral symmetry, as such, any distortion on the octahedral or second-near neighbor might break this symmetry. E.g., in your case, $d_{xy}$ and $d_{x^2-y^2}$ exchange places probably means the atoms have different site symmetry.
The rotation will only work when you have the completely set of bands. If you find some orbital contributions are missing, most of the time you just need to include more empty bands.

Again, I think this issue is veering towards a scientific collaboration that's not very related to how the code behaves. And I think it is better to (potentially) continue this conversation via emails so proper attribution can be acknowledged.

Closed due to inactivity.


OP_BIN2NUM implementation

The current implementation of OP_BIN2NUM doesn't reflect the node software implementation.
In the BSV software OP_BIN2NUM pops the element from the stack and minimally encodes it (namely, it pops a byte sequence and interprets it as a number, but it doesn't reverse its endianness): OP_BIN2NUM in BSV node software.
In chain-gang, OP_BIN2NUM reverses the endianness: OP_BIN2NUM in chain-gang.
The following code should return True, but it returns False:
from tx_engine import Script, Context

test = Script.parse_string('0x0100 OP_BIN2NUM OP_1 OP_EQUAL')
context = Context(script=test)
context.evaluate()

Should be addressed in version 0.5.9 See https://github.com/nchain-innovation/chain-gang/compare/db61f25b1d6a05eab73ca54685895c972baba5fc...bdebcff43f73d2cba5f3152cb44034fb8ef19dcf


Bash script to resize large images

Resize images using ImageMagick. Possibly also convert images to usable file formats.

Resizing images probably isn't necessary now that the rendering window will always be the largest possible size while maintaining the original aspect ratio. However, converting file types would still be useful.

This seems unnecessary at the moment, but I'll reopen this issue if this changes in the future.


[client] set settings locally or on the account based on if the user is logged in

if logged in:

if the user is logged in, and is the first time accessing pastemyst with that specific browser (no settings in localstorage), load his settings into the browser settings (localstorage)
user can adjust browser and profile settings independently
add a button to reset the browser settings to the profile settings

if the user changes the profile settings, they would have to manually resync if they want to update their browser settings


Audio Cues:

Audio cues have stopped working altogether, affecting usability. Please look into fixing this functionality.

/needsMoreInfo

cannot repro, thus closing

how to enable audios when i press enter tabs and other stuff??


Add a "how to structure your OGM repo" section to the new website

The home page currently outlines Stanford's "pear tree" method in which every record has the same name (geoblacklight.json) but is nested in coded folders. This seems to be related to the way GeoCombine works.
Another option is to create metadata records with unique filenames, e.g. these examples by Harvard and the Big Ten.

I started a Google Doc to draft new text for this part of the website: https://docs.google.com/document/d/1nKCIucslTBs-HTbRugdsrg-uExnjr4Z2akkTDcuIhnw/edit?usp=sharing
Currently pulling text from the OGM metadata repository wiki to make it easier for us to edit together.

A draft of content for the new "Get Started with OGM" page is ready for review here: OGM-How to structure your repo

Closed by https://github.com/OpenGeoMetadata/opengeometadata.github.io/pull/9


Support user-assigned managed identity

Is your feature request related to a problem? Please describe.
In CFCR, the master VMs and worker VMs should have different roles to access Azure resources. CPI should support assign different user-assigned managed identity to them.
GCP's service account and AWS's IAM instance profile support this scenario.
Describe the solution you'd like

Before deploying VMs, you use Azure CLI (or other tools) to create two user-assigned MSIs.
You use Azure CLI to grant your MSIs access to a resource group or a subscription. The two MSIs can have different roles, which can satisfy security requirements.
Azure CPI is responsible to assign your MSIs to master and worker VMs via vm_extensions.
Then the master and worker VMs can use different MSIs to access other Azure resources.

supported in v35.5.0


ScriptHookVDotNet crashes game

This problem has been going on too long now, I can't use scripts because scripthookvdotnet keeps making my game crash, and I've literally tried everything, and still no luck, AT ALL. This is really frustrating me that I cannot play GTA because it crashes every single time in-game. If anyone knows what to do, PLEASE help me out, this is ridiculous. My game is fine without scripthookvdotnet.
RAGEPluginHook.log
ScriptHookVDotNet2.log
ScriptHookV.log

ScriptHookVDotNet doesn't crash.  TriggerHappy crashes and you forgot to install NativeUI (or you installed it in the wrong place)! RPH crashed also but that's got nothing to do with shvdn.


Fix opac URLs

This PR updates the links to the OPAC.

The BSB seems to have fixed this. Now both ways work fine. I you prefer to leave it the old way, feel free to close this PR.

I do prefer it that way, since something with search and a parameter does not seem like a permanent resource …


cqerl_client: Plug a sleep-state client leak

The sleep-state clause of cqerl_client:handle_info/3 duplicates some but
not all of the logic in release_stream_id/3, in particular omitting the
possible call to signal_avail/0.  A client that fails to call
signal_avail/0 when necessary will leave its corresponding #cql_client.busy
flag incorrectly set to true in the #cqerl_state.clients ETS table,
rendering the client permanently unavailable.  Replacing the duplicated
logic with a call to release_stream_id/3 fixes the problem.
Calling release_stream_id/3 does in turn call dequeue_query/1, but this
should be harmless in the sleep state since #client_state.queries should
be empty.

Thanks @nwt !

I'll merge soon after I run the test suite

Thanks @nwt and sorry to have taken so long to integrate it!


Get rid of vendoring

We (Microsoft Network Cloud) have a mirror of this repo internally for software supply chain purposes and the vendor/ directory makes the mirror maintenance unnecessarily painful.

I do have nothing against removing vendor/ in principle. Let's see how we want to do it.

closed thanks to #294


M3-2579 Improve TagPanel workflow

Improve TagPanel workflow

There's a delay between the user sending the request and the actual tag showing created/deleted resulting in the user being unsure the action took place. I added loading states on the panel for creation/deletion of tags and disabled the form submit to prevent the user from performing the same action repeatedly wondering if anything happened
There is now Front end validation which allows us to improve the messaging (the tag index was previously part of the error message)
The styling of the error messaging was off and needed fixing

Type of Change

Non breaking change ('update', 'change')

Agreed with John's feedback. Another thing I find odd is when I try to create a tag and block the request I end up in this state:

But I can't submit the form again until I unfocus the textfield and then try again. Simply typing the tag and hitting enter while that error exists doesn't submit the form

@johnwcallahan @martinmckenna feedback addressed, thx!


MatSelect: fullwidth impl

Fixes:

DemoMatSelect had wrong anchor

Additions:

DemoMatSelect shows FullWidth demo
remove hoistMenuToBody in matSelect.js, as this moved the menu outside the matselect div, which meant that for the menu to have full width, width: 100% referred to the body, not the matselect div.
added parameter FullWidth to MatSelect. When enabled, the component takes up 100% of the parent width.

This addresses #660

Thanks for the contribution!


git push hangs when pushing from remote

Does this issue occur when all extensions are disabled?: Yes

VS Code Version:
Version: 1.91.0-insider
Commit: aea213b7fcc7de5c24ad797ac1af209b159d451f
Date: 2024-06-28T05:55:45.367Z
Electron: 29.4.0
ElectronBuildId: 9728852
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Linux x64 6.5.6-300.fc39.x86_64

(has had same behaviour for a number of versions now)

OS Version: Linux -> remote into windows

Steps to Reproduce:

Open vscode on linux
Attach to remote windows machine via ssh (windows running openssh)
open powershell terminal in vscode
run git push to remote ssh linux machine using keys

command hangs
see ssh log:
gitlog.txt
git version 2.44.0.windows.1
Same command 'git push' works fine when sshing into windows machine and running from powershell, the only difference seems to be that powershell is started from within vscode.
It is also possible to log into the machine that has the git repo on it from windows powesehell in vscode without password using key.

@nickblock, sorry for not getting back to you on this until now.
Are you able to reproduce the issue with the latest VS Code Insiders release?

I printed out the env from the 2 different powershell prompts (dir env:). In vscode terminal only I see these:
VSCODE_GIT_ASKPASS_MAIN        c:\Users\nick.vscode-server-insiders\cli\servers\Insiders-22e3447b4b410dcf8426bf70743c5dd4030d6122\server\extens...
VSCODE_GIT_ASKPASS_NODE        C:\Users\nick.vscode-server-insiders\cli\servers\Insiders-22e3447b4b410dcf8426bf70743c5dd4030d6122\server\node.exe
VSCODE_GIT_IPC_HANDLE          \.\pipe\vscode-git-041154424d-sock
VSCODE_INJECTION               1
VSCODE_IPC_HOOK_CLI            \.\pipe\vscode-ipc-093266a0-0205-4da4-b655-951f3d84a62e-sock
I unset them all but it didnt help

@nickblock, do you have the possibility to remote desktop onto the Windows machine and launch VS Code locally? I just want to rule out the "Remote SSH" extension from the equation in an effort to try to narrow down the issue. Thanks!

Yes, its fine just using git push from terminal within vscode just using it on windows directly.


hyprctl notify randomly gives invalid fontsize kwarg

Hyprland Version
 System/Version info
Hyprland, built from branch main at commit 6c4e2489a0a153ac2a92744ecb2985280c97fc89 dirty (layout: Fix toggling fullscreen special workspace on different monitor (5000)).
Date: Thu Mar 7 14:27:58 2024
Tag: v0.36.0-69-g6c4e2489

flags: (if any)

System Information:
System name: Linux
Node name: dell-xps
Release: 6.7.8-zen1-1.1-zen
Version: #1 ZEN SMP PREEMPT_DYNAMIC Sun, 03 Mar 2024 17:02:55 +0000

GPU information:
00:02.0 VGA compatible controller [0300]: Intel Corporation Alder Lake-P GT2 [Iris Xe Graphics] [8086:46a6] (rev 0c) (prog-if 00 [VGA controller])

os-release: NAME="Arch Linux"
PRETTY_NAME="Arch Linux"
ID=arch
BUILD_ID=rolling
ANSI_COLOR="38;2;23;147;209"
HOME_URL="https://archlinux.org/"
DOCUMENTATION_URL="https://wiki.archlinux.org/"
SUPPORT_URL="https://bbs.archlinux.org/"
BUG_REPORT_URL="https://gitlab.archlinux.org/groups/archlinux/-/issues"
PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/"
LOGO=archlinux-logo

plugins:

Bug or Regression?
Bug
Description
Hyprctl sometimes gives invalid fontsize kwarg instead of sending a notification
How to reproduce
run hyprctl notify -1 1000 0 "jjjjjjjjj"

ok
run hyprctl notify -1 1000 0 "jjjjjjjjjj"
invalid fontsize kwarg

this only appears to happen for some notifications, I was unable to find a pattern. The lenght isn't the problem
Crash reports, logs, images, videos
No response

#4981
@ItsDrike wanna comment on this?

I mean the implementation is fine, just update the wiki accordingly or, even better, put the font size after the text and make it optional

I assumed string::compare returns a boolean, it returns an integer indicating the result of the comparison.


Pass custom data when firing Meteor.loginWithSlack()

Is it possible to pass some extra data as parameter during Meteor.loginWithSlack(), which could be accessible in Accounts.onCreateUser options?
I mean something like:

// client
const someData = "I want to get it from Accounts.onCreateUser";

Meteor.loginWithSlack({
    someData: someData
})

// server
Accounts.onCreateUser(function (options, user) {
    console.log(options.someData); // "I want to get it from Accounts.onCreateUser"
});

@acemtp Can we do this?

@acemtp Can we do it in the future? Or the project is dead?

The project is still working fine but I don't develop anything on it.
PR is welcome ;)


Update to support spark 1.5 and several new features

This contains several new feature and improvement including:

Support spark 1.5 (contains job done by @sparksburnitt @xinyunh and @bomeng);
Support using astro same as datasource, which will
Use hive metastore instead a standalone hbase catalog to store meta data(HBaseSQLContext will inherit from HiveContext instead of SQLContext)
Using stable HBase relase 1.1.2 instead of 0.98
Add new operator UPDATE/DELETE

Thanks for your initial work @Zhangshunyu @Sephiroth-Lin
Later I will add more to make it better to use.

test this please

CREATE TABLE.. syntax got changed. Is there any reason why you have changed  it?

Yeah...We move those properties like hbaseTableName, tableName, keyCols, colsMapping into the Options which is same way with Data Source in SparkSQL.

Ok.. but the validations are not good in this create ddl parser. Even if simple error in syntax throws always same exception like below.It is very difficult for user to know where he did wrong. And also the current syntax looks little crude way.
Exception in thread "main" java.lang.RuntimeException: [1.1] failure: ``load'' expected but identifier CREATE found

AFAIK, this could happened same way in same situation in SparkSQL, but I will check if it has a solution to give proper message when the command could not be parsed.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@WangTaoTheTonic  can you rebase it.

@WangTaoTheTonic can you rebase it.

@WangTaoTheTonic can you please rebase


Alter the content onDrop

Is there an option to alter the content onDrop? I
I get the content I drop from the passed arguments and i have the content I want to have at hand.
I tried setContent and string.replace() on onUpdate but it alters the cursor position on normal input, and I can't do it on onDrop as it's before the alteration.

I managed to get this to work with a plugin, so for reference to whomever comes after me:
I have within my data() something like this:
snippets: [
        {
          title: 'Title 1',
          content: 'Content of title 1'
        },
        {
          title: 'Titel 2',
          content: 'Content of title 2'
        }
      ]

The content may be very long, which is why I need to display the title and replace it with the content on drop.
I use https://github.com/SortableJS/Vue.Draggable to create snippets like this:
<draggable v-for="snippet in snippets" :key="snippet.title" :setData="(evt) => { evt.setData('text/plain', snippet.content) }">

{{snippet.title}}

</draggable>

Note the setData, that injects the actual snippet content into the dataTransfer.
Now I have this extension, that can be simply loaded with new SnippetExtension() within the extension property of tiptap:
import {  Plugin, Paragraph } from 'tiptap'

export default class Snippet extends Paragraph {

  get name() {
    return 'snippet'
  }

  get plugins() {
    return [
      new Plugin({
        props: {
          handleDOMEvents: {
            drop(view, event) {
              event.preventDefault()
              const coordinates = view.posAtCoords({ left: event.clientX, top: event.clientY })
              const content = event.dataTransfer.getData('text/plain')
              const transaction = view.state.tr.insertText(content, coordinates.pos)
              view.dispatch(transaction)
            }
          }
        }
      })
    ]
  }
}

Works like a charm :-)


APT whitelist request for genisoimage

genisoimage itself is light on setuid as it primarily focusses on generating ISO images, not writing them. The source for the package is actually for cdrkit from which wodim and other packages are also built, which require elevation for some of their operations.
cdrkit-doc and wodim are both 'suggested' packages. icedax is 'suggested' by cdrkit-doc.
Whitelisting only 'genisoimage' should be sufficient here, I think?

Just curious on the status of genisoimage, I'd like to use it for compiling iPXE which requires the use of genisoimage.

Same here, is this still in the works? I need it to create dmg images. Thanks,

Same here, I'd like to use it to generate cloud-init iso images. Thanks

My apologies for not updating this much earlier, but I ended up creating a new whitelist request for the xorriso package (#1393) as a workaround, and it has completed.
For some use cases xorriso might suffice (xorriso -as mkisofs) as a replacement.

We'd like to run tests using qemu iso images. Not have genisoimage is a deal breaker for our testing infrastructure. Has there been any movement on this?

I worked around it, but I have a different use case than you do. I run this snippet during before_install.


readme: add -H flag to second sudo pip command

Coverage remained the same at 93.05% when pulling 495a66088bfe8a3e1f4175198cddb09d9ea469b8 on waldyrious:patch-1 into 4fe64e3dfa61167a3dba4b42692b803cb5fb0fbf on nvbn:master.

Thanks!


Infinite Abilities and Turn Based Mode Broken

Having a significant bug where turn based mode is very slow and enemies take multiple actions in a row. Further my own spells and abilities have infinite uses.
I have only Table Top Tweaks, Toybox, Buy Material Components, and Respec Mod installed.
Anyone have any thoughts on what may be going on?
Thanks for the help!

Its buy material components
On Thu, Nov 24, 2022, 1:12 AM Bondoid @.***> wrote:

Having a significant bug where turn based mode is very slow and enemies
take multiple actions in a row. Further my own spells and abilities have
infinite uses.
I have only Table Top Tweaks, Toybox, Buy Material Components, and Respec
Mod installed.
Anyone have any thoughts on what may be going on?
Thanks for the help!
—
Reply to this email directly, view it on GitHub
https://github.com/Vek17/TabletopTweaks-Base/issues/548, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAWSQPCHOFG5G72IVJYWR3LWJ4IPFANCNFSM6AAAAAASJ34KXU
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Thanks You! Your a Gentleman and a Scholar!


Allow programmatic focus and focus the first focussable nested element in a modal

Prerequisites

[X] I have read the Contributing Guidelines.
[X] I have not leaked any internal/restricted information like screenshots, videos, code snippets, links etc.

What happened?
I encountered an issue when trying to set the initial focus on a button within a confirmation modal using the ix-modal component.
My approach was to use the focus method from the native browser API in combination with ViewChild, within the AfterViewInit lifecycle hook. However, the focus state did not appear on the button, even though I could manually trigger it via keyboard tabbing.
Additionally, I was unable to set the focus state through Chrome DevTools by forcing focus on the DOM node of the ix-button or its encapsulated button element. Calling the focus method directly on these nodes also did not result in the expected focus behavior.
I suggest that all iX components should support a programmatic way to set focus.
Upon further investigation, I discovered that the native dialog HTML element, which the ix-modal component uses internally, automatically focuses the first focusable nested element. This is a built-in accessibility feature in browsers (see MDN for more details).
I created a codepen to demonstrate this behavior.
However, this behavior is not present in the ix-modal component. I propose adding this default behavior to ensure better accessibility and consistency.
What type of frontend framework are you seeing the problem on?
Angular
Which version of iX do you use?
v2.5.0
Code to produce this issue.
I’ve included a StackBlitz example to demonstrate that:

Elements cannot be focused programmatically.
The modal does not focus the first focusable nested element by default.

Autofocus should work with the next release also within a ix-modal. Just keep in mind that using autofocus decrease the level of accessibility e.g  https://www.boia.org/blog/accessibility-tips-be-cautious-when-using-autofocus


Unauthorized error with retrieving the client configuration; cannot get around the error and stuck with resources

Describe the Bug
You all should remove this from the repository. It doesn't work and needs lots of help. Waste of my time.
I can't even destroy the resources because of an unauthorized error, and I am using privileged aws access, so there is no lack of authorization.
Error: UnauthorizedOperation: You are not authorized to perform this operation....
with module.vpn.data.awsutils_ec2_client_vpn_export_client_config.default[0],
│   on .terraform/modules/vpn/main.tf line 264, in data "awsutils_ec2_client_vpn_export_client_config" "default":
│  264: data "awsutils_ec2_client_vpn_export_client_config" "default" {
Expected Behavior
Error after all resources created. Now I cannot delete resources.
Steps to Reproduce
terraform apply.
Test your own code...
Screenshots
No response
Environment
No response
Additional Context
No response

@laffey Just for you and future travellers. This module uses two providers. The official aws provider and a awsutils provider that Cloudposse have developed. I'm sure they have a good reason for the custom provider, but I guess it does break the principle of least surprise a little.
Your attitude could be better! You are after all using a free module from their opinionated set of modules for their accelerators.
Because this module also requires the awsutils provider you will also need to configure that provider in your root module if you are providing configuration options to the aws provider.
So you probably have something like:
provider "aws" {
  region = "eu-west-1"
  assume_role {
    role_arn = "arn:aws:iam::1111111111:role/some_role"
  }
}

module "this_module" {
  source  = "cloudposse/ec2-client-vpn/aws"
  # removed for brevity
}

And you need to update your config to look something like:
provider "aws" {
  region = "eu-west-1"
  assume_role {
    role_arn = "arn:aws:iam::1111111111:role/some_role"
  }
}

provider "awsutils" {
  region = "eu-west-1"
  assume_role {
    role_arn = "arn:aws:iam::1111111111:role/some_role"
  }
}

module "this_module" {
  source  = "cloudposse/ec2-client-vpn/aws"
  # removed for brevity
}

You probably could have figured that out in the time it took to open this salty issue

Thanks @conzy
The reason why the additional provider is needed is because the upstream aws provider cannot export the aws client vpn configuration so the cloudposse/awsutils provider is used instead
For reference, there is also an examples directory of how to use each module which contains the defined providers
https://github.com/cloudposse/terraform-aws-ec2-client-vpn/blob/a777f96f754e046100cf8d5fe816575877e8e42d/examples/complete/main.tf#L1-L7
And the auto generated required providers section for each module
https://github.com/cloudposse/terraform-aws-ec2-client-vpn?tab=readme-ov-file#providers
We can probably go one step further and add the required providers to the versions.tf so it's more obvious when doing an init/plan step


Python3 compat

Use built in csv module and context managers
Use python3 csv module that handles unicode correctly.
Context managers for files
Black formated the keep.py
Tested in py 3.7

Thanks  @kbaikov! Appreciate the upkeep


Revert "Grant rbean tekton-triggers-admin"

This reverts commit f6f73906c893c3e485a7b124cbc26077020566e5.

This was incorrect and was misinformed. I was able to accomplish what I needed (resync the validatingwebhookconfiguration) by using the argo UI.


Stop using GraphQL Int to represent numbers where that may be bigger than a signed 32 bit integer

BigInt is what we need here.

@jdomingos I've assigned this one to you, just do a search for Int types in the schema and update them where necessary. Give me a call on slack for more info. It's not urgent, just fit it in when you get time.

I guess this is still relevant. However priority is low, @bdmason can you specify a prio here?