STORM-904: Move bin/storm command line to java.

This PR aims at factoring out the logic for storm command line client which currently resides in two places. One in storm bash script and storm.py for Unix and storm.cmd for Windows. Idea is to create a java program that will be called from storm.cmd and storm bash script which will have all the logic from storm.py and storm.cmd in one place. This will help us maintain the storm client better since we will have only one file to change and in most cases only the base class that both Windows and Unix classes inherit from. I have already removed storm.py. I am working on finishing up the java file and also removing the storm.cmd file. Just putting it out there to elicit response to this approach from the community.

I have a little confusion about why we're moving the python to java instead of just having the storm.cmd run the existing storm.py.
I'm all in favor of de-duplicating the storm.py and storm.cmd commands, but rather than reimplementing storm.py, I'd rather reuse it.

@knusbaum it will make lot easier for commands to be in java and we can have just wrappers for windows & nix* os. We don't need to have python dependency and in our experience of running python to execute java command to start a jvm takes lot of time and in larger clusters Ambari times out these commands.

Any update on this PR? It would seem it at least needs an upmerge and additional review.

@priyank5485
I don't prefer switch storm.py from python to java. Because  I often add debug point in the storm.py, it is very easy to debug in online system(especially when environment is bad or jvm parameter is wrong). if we change to java version, it is very hard to debug.
Another point is that python's code is more easy to add new functions in the script.

@hustfxj  I might have missed something and its been a long time since i did this. I could not find any storm command that would not need a waitFor. Can you give an example? If we do need that flag it should be easy to add and I can change that.
@longdafeng I am not sure I understand the point about debugging. You can still put a break point in this java version of storm command line. I agree with you that its easier to write new functions in script. But the whole point of this JIRA is to have one client that works for Unix based systems and Windows platform. The last time I was working on it we had storm.py for Unix and storm batch client for windows. Both of them also had a separate file for environment variables. It is hard to maintain two scripts anytime we want to change the storm command. We can ask others about their opinion and what they think is better between the two approaches.

@longdafeng Also please see one of the previous comments about why not to use python.


[WIP] Annotate mutations

This kind of thing is something I really want, but if I were to do it I'd re-evaluate from scratch so I'm going to close this.


Allow * as a device name in grm

Description
Allowing * as device name in grm mode, this will scan the test_spec.json and add all the platform required as DUMMY platforms

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[X] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@bridadan @theotherjimmy tested on my machine

is it idea to support parallel execution with grm?

@jupe this is for PSA targets that currently have differently named targets in Mbed OS than how our tools detect them: TARGET_NS, TARGET_S, TARGET, etc

@jupe  it could be


meteor add<EMAIL_ADDRESS>does not work

In the README.md the instructions for meteor say that we need to execute command
meteor add<EMAIL_ADDRESS>This gives error that no such package exists.
As per meteor show --show-all twbs:bootstrap the latest version is 4.0.0-alpha.2
So README.md needs to show proper version for meteor installation.

Duplicate of #20389.


fix: change .asyncapi-analytics file's directory

This PR will change the analytics config file's directory from "current working directory" to "user's home directory" to avoid inconsistencies and unnecessary duplications. See more reasons here.
cc @fmvilas

/rtm


Redesign "Projects Joined"-page

General Checkups

[x] Have you checked that there isn't already an existing issue that describes what you report below?
[x] Have you checked that there isn't already an open pull requests for this issue/update/change?

Description
Right now https://www.openhumans.org/member/me/joined/ and https://www.openhumans.org/member/me/data/ are confusing and lacking for a number of reasons:

Projects which neither ask for data access nor data uploads are listed on neither page and just are basically invisible
Projects which are under development are absent too, making it hard to leave these
Projects which want to upload data but haven't done so are listed under the data page.

Generally, it's hard to predict where each project will land and it's hard for users to find out which projects they've joined and which data access they've consented to. For this reason this page should be redesigned. The ideas so far
Make /member/me/joined/ page that

lists all projects that a member has joined

including these that are under development
request neither access nor upload to/of data
those who want to upload data

Generally the idea is that everything that a member has opted in into should be listed. At the same time this page should list the permissions that people have agreed to.
Related Issue(s)

Example
@madprime made a suggestion in a google doc for how this could look like: https://docs.google.com/document/d/18_PsFnKKMMDZuJ_BqyVjVRKz14jWns3pSiSG6LD3IOA/edit
My idea was to use the badges of each project instead to visualize the permissions granted and to gray out those data sources that are not applicable to a given member right now (e.g. project X asks for data source Y but you haven't connected Y yet). A quick drawing is below.

Related to this (and important for GDPR related overhauls, ping @jhdulaney) The /member/me/data slug shows only data that was deposited by projects that have been set to approved, data from unapproved data sources is not listed. Along with the problems listed above this makes it ± impossible to delete and find these data.

Yeah, I noticed that.  That may be a first thing to look at here.


Authentication error

This is my Appdynamics account :

Here is the Screenshot when I'm trying to run DEXTER  :

change your user name in the job file to rsignh16@eitappd

Tried everything,
rsingh16@eitappd,rsingh16<EMAIL_ADDRESS>but nothing is working. Giving same error

@rohitjangid96 Your username is rsingh16@tenant where tenant is most likely customer1. See https://github.com/Appdynamics/AppDynamics.DEXTER/wiki/Job-File#username-string


Unable to define zvm_config outside of zsh-vi-mode.zsh

General information

Terminal program: Kitty
Operating system: Ubuntu
ZSH framework: antidote
ZSH version: 5.8
ZVM version: 0.8.5

Basic examination

[x] I have read through the README page
[x] I have the latest version of zsh-vi-mode
[ ] I have tested with another terminal program

Problem description
When cloning this repo, it seems that the only way to set custom options such as escape keys is inside zsh-vi-mode.zsh.
I've tried defining the zvm_config function in my .zshrc file but that does not appear to work as the escape key still shows as the default. Is the intended behavior to only define customizations in zsh-vi-mode.zsh? If so, then this makes it difficult to maintain customizations while also maintaining the latest version of ZVM.
Function I am trying to add:
function zvm_config() {
  ZVM_LINE_INIT_MODE=$ZVM_MODE_INSERT
  ZVM_VI_ESCAPE_BINDKEY=jj
}

To clarify, this works if I define the above function in zsh-vi-mode.zsh, but I would like to have this function in my .zshrc config so I could pull any updates to ZVM without losing my configurations.
Reproduction steps

Pull project
Define above function in .zshrc
Restart terminal and $ZVM_VI_ESCAPE_BINDKEY is still default option.

Expected behavior
Ability to define customizations outside of zsh-vi-mode.zsh

Hi @parispjones,
Sorry for the late working on this reporting issue, I think this issue was related to #206 and has been fixed. Could you try again with the latest version?
Thanks & Regards

Hi @jeffreytse,
It looks like it's still not working for me.
function zvm_config() {
  ZVM_LINE_INIT_MODE=$ZVM_MODE_INSERT
  ZVM_VI_ESCAPE_BINDKEY=jj
}
source ~/.zsh-vi-mode.zsh

Add above function to .zshrc
Reload zsh
Cry because it doesn't work.

oops, I accidentally closed this,

Hi @parispjones
As $ZVM_VI_ESCAPE_BINDKEY was an early stage variable, you can config it by the following code snippets:
zvm_config() {
    ZVM_VI_ESCAPE_BINDKEY=jj
    ZVM_VI_INSERT_ESCAPE_BINDKEY=$ZVM_VI_ESCAPE_BINDKEY
    ZVM_VI_VISUAL_ESCAPE_BINDKEY=$ZVM_VI_ESCAPE_BINDKEY
    ZVM_VI_OPPEND_ESCAPE_BINDKEY=$ZVM_VI_ESCAPE_BINDKEY
}

source ~/zsh-vi-mode.zsh

or
# Config before sourcing the plugin
ZVM_VI_ESCAPE_BINDKEY=jj

source ~/zsh-vi-mode.zsh

Thanks & Regards

Confirmed it works now!
You rock.


request: read-only flag on FormField

Feature request
Please add a parameter to the FormField/TextFormField class to enable toggling between edit and read mode.
new TextFormField(
              initialValue: expenseJSON['description'],
              keyboardType: TextInputType.text,
              decoration: const InputDecoration(
                hintText: 'Description',
                labelText: 'Description *',
              ),
              obscureText: false,
              readOnly: true,
              validator: (String value) {
                _saveNeeded = true;
                if (value.isEmpty)
                  return 'Description is mandatory';
                if (value.length < 3)
                  return 'Description is mandatory';
                final RegExp nameExp = new RegExp(r'^[A-Za-z ]+$');
                if (!nameExp.hasMatch(value))
                  return 'Description contains invalid characters.';
                return null;
              },
              onSaved: (String value) {
                print('Save description to JSON: ' + value);
                expenseJSON['description'] = value;
              },
            ),

Did you get anywhere with this? Would it be possible to use MergeSemantics to fix it?

Fixed by #16027

I'd like to suggest that a readOnly flag be re-examined, given the enabled flag has wider reaching implications e.g. helperText, validation, etc are affected.
IMHO readOnly is not the same as enabled.
Thoughts?

@gmcdowell would you mind elaborating on what exactly the behavior is that you expect from disabled and readonly?

Surething.
Disabled: As currently implemented, turns off validation, hides helper text
and renders the entire Widget 'unusable'
Readonly: Enabled except for the ability to set focus/cursor into text
field.
If there was another approach (or existing widget) to the end-goal which
supports a similar outcome, I'll happily revise current approach, so
forgive me if that is the case.
On Tue, 11 Sep 2018 at 18:47, Günter Zöchbauer<EMAIL_ADDRESS>wrote:

@gmcdowell https://github.com/gmcdowell would you mind elaborating on
what exactly the behavior is that you expect from disabled and readonly?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/14014#issuecomment-420165817,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJog2AmHjWEe1kmeVAfx8hkuIakrVZcHks5uZ1yMgaJpZM4RZj7o
.

--

Greg McDowell
Oxigeno Online

Enabled except for the ability to set focus/cursor into text
field.

sounds contradictory to me.
This would make it look like an enabled text field but wouldn't behave like one.
When and why would that be desirable?
You can for example disable the field and wrap it with a custom InputDecorationTheme with disabledBorder set to enabledBorder

Enabled except for the ability to set focus/cursor into text
field.

sounds contradictory to me.
This would make it look like an enabled text field but wouldn't behave like one.
When and why would that be desirable?
You can for example disable the field and wrap it with a custom InputDecorationTheme with disabledBorder set to enabledBorder

But disabled fields doesn't allow copy or selection. Sometimes you need a field that shows a result of an operation or a dialog, and you want that result to be selectable and copyable, or even be able to acquire focus, everything but write (or paste).
basically read-only = disable keyboard and paste

But disabled fields don't allow copy or selection

Sounds legit to me.

Also disabled fields don't allow selecting the suffix icon, which I would find useful

This should be available in flutter, too many use case for this.
Just like html input text you can set it to disabled, or readonly. It's pretty common.

I am Peanut Flutter and I agree with all the same said here!
There is readonly but not disabled in most other major framework on most other major platform! It is you-bik-wit-oss! Some time I just need tap event on readonly field to make tricks even copy an OTP!
But Flutter is being the sad boy in this mix with not supporting, usually happy boy
I challenge you to FIX! Flutter team. Team Flutter! You hear me! I try to find time making the PR but it is squirly

I am in the middle of fixing https://github.com/flutter/flutter/issues/5422. which is very similar as readOnly
My view of readOnly is that it is selectable but not editable text field. it should be almost the same as original textfiled but without the keyboard pop up and past/cut. It still needs the cursor so that keyboard and accessibility can still copy the content.
I will try to address this issue as part of my implementation for https://github.com/flutter/flutter/issues/5422.
Let me know what you think about the above approach for readonly.

@chunhtai So good this is divine approach! Thank you proceed please.

@chunhtai In terms of the breaking change mentioned in https://groups.google.com/d/msg/flutter-announce/7v0lt7JC6Hk/1bIe71JSBQAJ, can you explain why these 4 fields need to be required, instead of any default value?

@dkwingsmt
It will have default value, this breaking change refer to class using the 'implements' keyword, you will have to override the getter method. If you use 'extends' keyword, you can rely on the the default value.

The PR is merged,
You now create a read only text field
TextField(controller: TextEditingController(text: 'initial value), readOnly: true)

The PR is merged,
You now create a read only text field
TextField(controller: TextEditingController(text: 'initial value), readOnly: true)

also added flag showCursor to hide or show blink caret

'readOnly' isn't defined
Which flutter version should I update to?

@zzAbel Make sure you’re on either beta channel or dev channel. It has not been released onto stable channel yet.
https://github.com/flutter/flutter/wiki/Flutter-build-release-channels

I put the TextFormField Inside gesture control to have onTap functionality and display a calendar. But with readonly field I am unable to get the popup to work. Where as if I use disabled then I am unable get validation working.
readonly    -------------->   No OnTap
Disabled    -------------->   No Validation Message

It looks like we don't have ontap for textformfield, that is something we should add.
For workaround, you can use TextField with ontap parameter, but you will have to implement validation.

@sydshahed  with this merged https://github.com/flutter/flutter/pull/37403, you should be able to use ontap callback

Step By Step Guide to How to disable text edit field in flutter ?

Step By Step Guide to How to disable text edit field in flutter ?


Can legacyflumeoffset be removed?

It looks so incomplete as to be nearly useless.
https://github.com/ssbc/margaret/blob/master/legacyflumeoffset/impl.go#L57-L63
For the sake of simplifying the codebase, can this module be removed?

 The main idea was to be able to copy an JS log into Margaret's own format.

An alternative might be to make it strictly read-only

It's a potentially useful idea, but it just seems like an awful lot of technical debt and a lot of stale code for something that isn't fully implemented and doesn't appear to be used.

yup, like I said, definitely not heart pressed on keeping this at all.
A third option might be to make an go-ssb-exp repo, where unfinished things might live for reference, similar to the junkyard org? In a similar vein, I moved an unfinished ssb-peer-invites plugin to https://git.sr.ht/~cryptix/go-exp/tree/experimental-ssb

That sounds like a great idea for a way to handle it.

Yea, might take me a few days until I get around to it but I can take care of that.

Awesome.  Thanks!


Properly clone date object to not cause duplicate keys in array

There was an issue in a bigger Angular app where the cloning was causing two objects to have the same hash key, causing an error when repeating over the array of objects.

Thanks!


Possibility to ignore output variable validation for certain actions

Is your feature request related to a problem? Please describe.
I'm using the dotenv-action, which makes properties available as step outputs. Because the plugin's meta-data can't have information on the used properties, this plugin cannot correctly validate the actions output.
Describe the solution you'd like
I want to be able to disable output variable validation for specific actions so that I don't get any false positives.
Describe alternatives you've considered
None so far
Operating System

N/A

Project Version

N/A

Greetings @thake,
Thank you for the request. I had not yet thought of this case.
A little brainstorming together:

A similar function is already built in for unrecognised actions. See screenshot. Would this option be sufficient if I always display this option?
Would you suggest ignoring single output elements, or just disable the validation of all output elements?
Visualisation: should the output variables get a weak warning to show that they are not validated, or would that interfere?

Hey @YunaBraska, thanks for your quick response!
Here are my comments:

That would be sufficient and consistent. I like it :)
Leave it to the user. So offer both options. Either ignore a single output variable or all output variables of a specific action.
A weak warning with a tooltip seems very sensible. This is also a good place to offer a function to undo ignoring the variable.

Back from vacation....
I added now the ability to disable checks for inputs and outputs.
The weak warning is not implemented, cause it looks pretty ugly on many outputs.
What do you think? Does it solve your issue?
Inputs

Outputs

@YunaBraska I totally like it :) Thank you!


Thread safety of the random subsystem

Describe the bug
All of the threads in Zephyr RTOS share a common random number subsystem instance to generate random numbers and CSPRNGs. RNG and CSPRNG backends are selected independently.
Some of these backends are thread-safe:

ctr_drbg (irq_lock)
timer (spin_lock)

Some are not:

xoshiro

For others, it depends on the device driver thread safety:

entropy_device

Expected behavior
At least all CSPRNG backends are thread-safe.
It seems currently there are two CSPRNG backends available:

ctr_drbg
entropy_device

ctr_drbg is already thread-safe. For entropy_device we would need to either add some synchronization primitives to the entropy_device backend implementation or require all entropy device driver implementations to be thread-safe. I checked a few selected driver implementations and they seem already thread-safe by using spin_locks or irq_locks. So maybe it's just a matter of documenting this requirement in entropy device driver API docs to fix the problem I'm describing.
Impact
Security

@ceolin flagging as medium since this may have some security impact, could you take a look?

@ceolin flagging as medium since this may have some security impact, could you take a look?

sure, will take a look.

@hubertmis thanks for reporting it. I see some items that need to be done:

ctr_dbrg is not thread-safe in SMP systems, so instead of just locking irq we need to use some mechanism that covers smp like a mutex (need to check though if is used in ISR)
rand32_entropy_device itself does not need any change and is thread-safe assuming that the entropy driver is thread-safe, so we need to make it a requirement

@ceolin, thanks for looking at this!
Do you think we should also make non-CS PRNGs thread safe (xoshiro)? If not maybe we should explicitly state in the rand subsystem docs they are not and describe the potential side effects of using them from different contexts.

@ceolin, thanks for looking at this!

Of course !

Do you think we should also make non-CS PRNGs thread safe (xoshiro)? If not maybe we should explicitly state in the rand subsystem docs they are not and describe the potential side effects of using them from different contexts.

My initial idea is to make both thread safe to avoid further problems.

@hubertmis I've linked a pr that address this issue. I will still look xoshiro. I avoided just put a lock there because it seems that only one small piece can be problematic and we could make it work using TLS, so I will think a little bit more.
I found other things in the subsys that require some love too and will work on them tomorrow.


How often engineering teams successfully deploy code to production

Due to the complexity I created another extension for this: https://marketplace.visualstudio.com/items?itemName=danilocolombi.deployment-monitor


Add stop button

Adds a stop button that appears when a sprig game is run in the web editor

closes #1146.

@leomcelroy are you okay with this change?  I do not believe it was vetted product-wise

As I mentioned in the #1146
I do approve this feature. But by replacing the play button it requires you to hit the button twice to rerun your game. Does that also mean that shift+enter now toggles between playing and pausing the game loop.
I would instead suggest adding the pause button next to mute.

@Tiger-The-Cat Can you please chime in here when this PR is ready for review and in compliance with @leomcelroy 's request for how this feature should function?  Feel free to assign this PR back to me when this is done...

Thank you! I didn't know shift+enter was a method to run the program, so I didn't implement a shift+enter toggle. I assume shift+enter shouldn't stop the game loop, as that would conflict with the flow of being able to restart the game in one action?
I've pushed the other change for now!🥳
P.S. space was a little tight, so I had to shrink the "Actual Sprig screen is 1/8" / 160×128 px" to just "Sprig screen is 1/8" / 160×128 px"

@grymmy I can't seem to assign anyone to this PR

@grymmy I can't seem to assign anyone to this PR

Assigned to Leo as I believe that was the request? Next time I'm at my laptop I'll add u with triage perms

@leomcelroy I guess this is rdy for review

even though it is already changed, wouldn't it make more sense that the stop button is at the same spot as the run button (similar to a play/pause button in music player), instead of near the mute button (that technically works like a switch; so it would be a switching button near a single-action button (bad user experience/counter-intuitive (??)). The only downside of putting the stop button at the same spot as the run button that I can think of is that you need to click one time more if you leave the game running while editing the code (correct me if I am wrong).

Thanks for the comment, @jakjakob! I think @leomcelroy is concerned that the extra step you mentioned will interfere with the current workflow for developing and running sprig games. I think I agree with him, being forced to double click every time to run code quickly becomes pretty aggravating.

Plz resolve merge conflicts and then ping me for review when desired

Merge conflicts should be resolved now👍

@Tiger-The-Cat please can your resolve the merge conflicts


Display saved not distributed messages

I don't find any proper way to display messages that are sending to server at the moment (saved ones). The problem is that I don't know message ID until server response.
What I'm doing: I assign temporary ID to new message like -Math.floor(1000 * Math.random()), and I always know that messages with negative IDs are sending ones. Then I add this message to messages array so user can see all messages he wrote right after he send it (in my case server may respond in 5 seconds, that's pretty much).
My problem is that after server responds and provides real message ID, I mark the message as distributed and try to change ID, but changing message ID cause wrong animation as if some new message was sent then immediately disappeared. Is there a way to change message ID without animation? Or maybe I'm just doing something wrong, is there another way to show saved messages without ID and then mark them as distributed?
GIF (message ID change cause this rerender)

Indeed, that's a good question. I probably need to change the way things work a bit to allow this.

Actually, this fix is breaking the messages infinite scroll to load more messages.
Will need to make a new fix.

You can now use indexId as a temporary message id to prevent animation glitch. https://github.com/antoine92190/vue-advanced-chat/commit/4335df6f9c73a795d1e5f4eb2a6f0486febbefec

Thank you very much for this package,
I'm having the same issue,
I see the documentation says there is an indexId that can be solved,
But how exactly do I use it?
Approximate process:
I create a temporary message variable in the send-message event.
Then add this temporary variable to this.messages,
At this time, the view immediately displays the new message,
At the same time,
I also sent a request to the server to store the message.
This request will respond back in about 2 seconds.
At this point,
I want to modify the temporary message variable just now
this.messages[_waitingUpdateMessageIndex] = responseMessageFill
this.$forceUpdate()

this.$set(this.messages,_waitingUpdateMessageIndex,responseMessageFill)

You can now use indexId as a temporary message id to prevent animation glitch. 4335df6

let tempMessageId = Date.now()+'-'+uuidv4()

//tempMessage._id = ''
tempMessage.indexId = tempMessageId

Error: Messages object is not valid! Must contain at least _id[String, Number] and senderId[String, Number]

Fixed in 6fb85c0 You can use your current implementation, and you won't see the animation anymore.

This helped a lot thanks ❤. A good thing would be a bit more of documentation on this, It was a a bit hard to get the ideia 😅


[BOT PR] to update dependencies of istio

This PR will be merged automatically once checks are successful.
none

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
00c7052ea5d4b8e47514fb79480acb0199b609f8
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Improve dashboard UX/UI

Add button to remove video
Add disabled attr when user clicks to start broadcast

Fixes #19 #11


ID+ submodule

This pr adds Zeotap ID+ submodule.

Have updated the documentation @MartianTribe, kindly have a look.


Fix error: package androidx.core.app does not exist

Hi there!
A clean checkout of the flutter_blue example and other Flutter projects using flutter_blue do not build due to the missing androidx.core.app dependency removed in commit 2ccdc68d474c158ae7cfbcae993e430a578173ec
See https://stackoverflow.com/questions/58603255/error-package-androidx-core-app-does-not-exist-when-running-flutter-blue-plugin
This pull request readds the required dependencies in the gradle file.
Do you plan to remove the dependency on androidx.core.app in the near future?
Best regards and thanks for your hard work 😄👍
Markus alias @atokulus

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Markus Wegmann seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

I can  +1 this fix - pulled the branch into my project and it solves the problem as described

Hi @Atokulus.
Thanks for the contribution. Can you confirm with the latest version if this PR is still needed?

Closing for now.

Not needed anymore. Thanks!


Code donation: .webarchive format

Just to let you know that I published a sample on how to create Safari .webarchive files: https://github.com/rcarmo/python-webarchive - might be useful, since it also provides a sample Python 3 asyncio crawler :)

:+1: thanks! I'm also checking out https://github.com/chfoo/wpull for warc support.

Nice - will see if I can do something with it!

Apparently wget supports saving to warc files!
‘--warc-file=file’
Use file as the destination WARC file.

https://www.gnu.org/software/wget/manual/wget.html

Yep. Different format, though.

On 6 Jul 2017, at 23:02, Nick Sweeting<EMAIL_ADDRESS>wrote:
Apparently wget supports saving to warc files!
‘--warc-file=file’
Use file as the destination WARC file.
https://www.gnu.org/software/wget/manual/wget.html
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I've decided to close this for now, since WARC is more officially supported and .webarchive is safari-only, I don't think it's worth investing time into this before WARC generation and replay is finished.


Tutorial notebooks overhaul

Overview
Following the comments received during the CSHS workshop, it was clear that the notebooks weren't as clear as they should have been to allow easier user onboarding. Therefore the structure has been remodeled and much more comments are provided to help the users interpret what they are doing and how to play with the models, the inputs and the outputs.
Changes:
Replaced the 9 first notebooks with 10 new notebooks, including notebook 00_Introduction_to_JupyterLab to iron-out some of the difficulties seen in managing the platform.
Also updated the notebook index for sphinx autodocs.

@cjauvin Could you review the code?
@Bijan55699 Could you go through the notebooks and comment on the clarity of explanations?
Thanks, no rush.

@huard will do!

@cjauvin Thanks! There the notebooks take users by the hand to explore the functionalities and features better and more in-depth, so the code is not meant to be "developer-level" but "beginner-level", so please don't work your magic to optimize everything 😄
Also, some notebooks need data that is generated in a previous notebook (kind of a daisy-chain type of thing), where we progressively increase the complexity. So auto-tests might fail if they are run independently.

@cjauvin Could you review the code? @Bijan55699 Could you go through the notebooks and comment on the clarity of explanations?
Thanks, no rush.

@huard : will do as well

@huard I have updated the notebooks following your comments, but there is a new problem that I've never had before (not related to changes, it is now erroring even with previous notebooks). It's in Notebook 08 - Getting and bias-correcting CMIP6 data.
Everything seems to work smoothly, but when comes the time to actually write the data to a netcdf file at the end of the chain, I get a "FSTimeoutError". I am assuming that this is a File System Timeout, so perhaps writing the files is taking too much time vs what is allowed in the FS config? It used to work without a hitch, but now it's erroring pretty quickly, within about a minute I would estimate.
Also, one comment regarding the legend of the land-use graphs was not completed in the same way as you expected, but I think the solution is OK (see NB 02_extrac_geographical_watershed...). Finally, one unresolved comment above regarding the rounding I am unsure of, I think probably @Zeitsperre coded this and I don't understand why, but I assume there is a reason!
Thanks!

Just added the notebooks with recent changes to the way ERA5 data is called, and fixed a bug in which future period data always has 0 timesteps. Also fixed the rounding function that was a bit convoluted.

It seems that out of nowhere, notebook 09 now fails with a weird error:
---------------------------------------------------------------------------
RavenError                                Traceback (most recent call last)
Input In [4], in <cell line: 23>()
     13 common_run_parameters = dict(
     14     area=4250.6,
     15     elevation=843.0,
   (...)
     19     rain_snow_fraction="RAINSNOW_DINGMAN",
     20 )
     22 # Run the hydrological model using our forcing data from the reference period, and with the common parameters that will also be used for the future period simulation.
---> 23 model(
     24     forcing,
     25     start_date=dt.datetime(1981,1,1),
     26     end_date=dt.datetime(1990,12,31),
     27     **common_run_parameters,
     28      )
     30 # Now plot the results
     31 model.hydrograph.q_sim.plot()

File /opt/conda/envs/birdy/lib/python3.8/site-packages/ravenpy/models/base.py:431, in Raven.__call__(self, ts, overwrite, **kwds)
    428 messages = self.extract_raven_messages()
    430 if messages["ERROR"]:
--> 431     raise RavenError("\n".join(messages["ERROR"]))
    433 for msg in messages["WARNING"]:
    434     warn(msg, category=RavenWarning)

RavenError: NetCDF error [NetCDF: Attempt to convert between text & numbers] occured.

This was not the case recently, and I can't seem to get this working anymore. Perhaps a change in Raven or in the netcdf package installed on the server? This is all through pavics.ouranos.ca.
@huard @tlvu have any changes been made recently? thanks!

@huard @tlvu have any changes been made recently? thanks!

@richardarsenault On May 5, we went live with the current Jupyter image, see all changes here https://github.com/Ouranosinc/PAVICS-e2e-workflow-tests/pull/105.
Can you try the "previous" Jupyter image on PAVICS?  That "previous" image was this PR https://github.com/Ouranosinc/PAVICS-e2e-workflow-tests/pull/101 and went live on Apr 7.
An even older Jupyter image is this one https://github.com/Ouranosinc/PAVICS-e2e-workflow-tests/pull/95, went live on Jan 27, not available on PAVICS anymore, if you need to try it, let me know and I'll try to work something out, probably giving you access to my dev VM.
Also, to future proof this PR, you might also want to try it on the "beta" image on PAVICS that I hope to be able to go live in 2, 3 weeks.  It has an even newer xclim.


My git repos always get broken

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.59.1
OS Version: Windows 10 Pro

Steps to Reproduce:

I clone a repo with git in VS, it works well for a couple days
Then it get broken from nowhere any time i try to do push, i get this message:

`

git -c user.useConfigOnly=true commit --quiet --allow-empty-message --file -
fatal: cannot lock ref 'HEAD': unable to resolve reference 'refs/heads/master': reference broken
`

Is any solution there?, this problem is so annoying!!

Did you check which branch you are?

Did you check which branch you are?

When checking the branch appears the same message: 'fatal: HEAD...' the repo basically broke from nowhere.

Try re cloning the repo.

Try re cloning the repo.

Yea that works, but it brokes again in a couple days...

What is the method of ur cloning?
i delete the folder and clone the repo again.

U can try resetting VSCode completely.
i already tried, i start to think is a pc's problem.

What is the method of ur cloning?
i delete the folder and clone the repo again.

U can try resetting VSCode completely.
i already tried, i start to think is a pc's problem.

@Yonier did you delete the .vscode folder in the AppData folder?


Provide a way to autocomplete things inside of comments as an extension

Hello, i am working on a javascript and typescript linter which has an LSP written in Rust, i would like to provide autocomplete for directives (commands through comments), however, what i have found is that vsc does not trigger the complete request if the item is inside of a comment, therefore we cannot autocomplete things such as // rslint-ignore no-. I tried using a work-around with trigger_characters but that does not seem to work either. It would be great if there was a way to ask vsc to trigger autocomplete despite it being a comment for your extension. I searched a lot of places to see if this could be done, i did not find anything, if there is indeed something then feel free to mention it, i may have missed it 🙂

It appears using all ascii letters as trigger characters does work, however, it would still be great to have a dedicated way to do this since this is a pretty big hack

Take a look at the editor.quickSuggestions setting. Quick suggestions are disabled in comments by default


About the PRM module

Hi, thanks for your work first. I get some confused about PRM module your paper write.
In here I find the PRM class definition but can not find anywhere to use it.
Also , in here I can not find PRM class definition, either the place to use it.
So, where the PRM module used? Do I foud it in wrong files?

You find it in right files. We present an implemention of PRM module. PRM is usually used after the output features of head network before heatmaps. You can try to use it in other places.

@caiyuanhao1998 Is that means you are not use the PRM module in the release code? Because I can not find anywhere has been used.

Yes

Got it. Thanks.


Create ltioanjebelean.txt

New entry for domain ltioanjebelean.info

the school official website URL:    http://www.ltioanjebelean.info/

the school street address, including city and country>  Andrei Saguna
St. No 4, Sannicolau-Mare, Timis County, Romania

on Google Maps>  https://maps.app.goo.gl/q3QxyoECFCUUo4AR9

I can't provide an URL of a page of the official website offering an
IT-related long-term course, because we are a public high school with a
curricula established by the Ministry of Education of Romania. We train
students in Mathematics and Computer Science speciality and it is mandatory
for them to study and for us to teach C/C++ programming language, php and
MySql during their high school years.

a proof, which shows that the school recognizes the domain you are
submitting as an official email domain for the students>  I can attach some
screenshots from the Google Admin Dashboard where we manage the students'
accounts, because we also use the platform for  Google Classrooms and I am
the G-Suite administrator.

On Sun, Apr 7, 2024 at 9:33 PM Philip Torchinsky @.***>
wrote:

@danajebelean https://github.com/danajebelean Please provide us with:

the school official website URL
the school street address, including city and country
an URL of a page on the official website where the school offers an
IT-related long-term (>1 year) course
a proof, which shows that the school recognizes the domain you are
submitting as an official email domain for the students.

—
Reply to this email directly, view it on GitHub
https://github.com/JetBrains/swot/pull/20521#issuecomment-2041556426,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BHMZYWAEX3Y2DEJNFBR6UETY4GGQRAVCNFSM6AAAAABFREXQ4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBRGU2TMNBSGY
.
You are receiving this because you were mentioned.Message ID:
@.***>

--

@danajebelean  Thank you for the clarifications. Pull request merged.


Add Square and Uber to adopters

@0legg I see you work at Square. Are you former Uber as well? I usually like to take these ADOPTERS update PRs from developers at those companies.

Indeed I was at Uber. Adding @tyvsmith as a current Uber employee.

Confirmed.


Final changes

@mdelapenya I haven't change the ActivitiyIndicator variable names because I take it from RxSwift example

@victorg1991 swift can render svg files? I can provide you an svg with the logo :)

@javierlopezdeancos As far as I know, iOS can render vector images, but only in .pdf format. If you can generate that I will add it to the project
Thanks! :D

I think that maybe this approach is better to render with good quality, I think that I can export the svg in pdf and push in https://github.com/craftsmanship-toledo/katangapp-ivc/tree/dev
this afternoon I can do it!!

@javierlopezdeancos, let us merge this pull, and then you are welcome to send the pull whenever you are ready :) Thank you bro!

I agree with you @mdelapenya , merge!!


chore: invert color

Dark theme! 😁👍

that's weird to see diff of built and dev version

I think we need to create a theme instead of overriding all the colors.


Update setup.py

resolves #14
thanks @msabramo

just trimming it down to minimal.
i need to go through the flask-registry check list to see if we're good to add it (or if there are any other pesky details to iron out).


Language Visual Saliency review

Couple of comments:

image/picture consistency. Changed picture in the text but still there are mentions in code.
Let's write helper functions first. We will generate crop coordinates and size with get_random_crop_params, and get the actual crop with get_crop_image. To update the saliency map with the calculated similarity, we will use update_saliency_map. A cosine_similarity function is just a code representation of the formula above.
def plot_saliency_map is not described but used in the same code block later. could add a couple of words about this probably.
The inference is similar to Pytorch  - either I'm too tired or something but I cannot understand the passage at all. Maybe revise this or let's discuss it.

2. plot_saliency_map

Moved the function definition closer to the first application.

3. The inference is similar to Pytorch

Rephrase to:
Once we have a compiled model the inference is similar to Pytorch - a compiled model is callable, just pass input data to it. Inference results are stored in the dictionary. Once we have a compiled model, the inference process is mostly similar.


Support of XEmbed extension

Please add the support for XEmbed messages to rust-xcb

Also if I understand correctly, meanwhile, if I wanted to use XEmbed I would have to implement it by implementing my own Request for the Xembed extensions like here for XInput: https://rust-x-bindings.github.io/rust-xcb/src/xcb/home/runner/work/rust-xcb/rust-xcb/target/debug/build/xcb-a998406220fb707b/out/xinput.rs.html#25126
Unless there is a safer way to send messages that are not natively supported by the library, please let me know if there are any

From what I see here you could simply build a ClientMessageEvent and it with the SendEvent request.

Thank you for the pointer! I did not realize it worked for X extensions, I
will try 👍
On Tue 30 Jul 2024, 06:31 Remi Thebault, @.***> wrote:

From what I see here
https://specifications.freedesktop.org/xembed-spec/xembed-spec-0.5.html#idm45495561951968
you could simply build a ClientMessageEvent
https://docs.rs/xcb/latest/xcb/x/struct.ClientMessageEvent.html and
send it with the SendEvent
https://docs.rs/xcb/latest/xcb/x/struct.SendEvent.html request.
—
Reply to this email directly, view it on GitHub
https://github.com/rust-x-bindings/rust-xcb/issues/270#issuecomment-2258022619,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKZGIFZYRLJZHV7I6H5IFLZO5TP3AVCNFSM6AAAAABLVBHAO6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJYGAZDENRRHE
.
You are receiving this because you authored the thread.Message ID:
@.***>


Error while updating property 'startPoint' of a view managed by: BVLinearGradient

react-native-linear-gradient: 2.4.0
react-native: 0.54.0

happened to me as well with the same versions
react-native-linear-gradient: 2.4.0
react-native: 0.54.0
but the error was a little different

i ended up just removing the 'start' and 'end' properties and everything worked out

in my case,
Change
start={[0, 0]}
end={[1, 0]}

To
start={{ x: 0, y: 0 }}
end={{ x: 1, y: 0 }}


[Linux] Update manifest.json to support the update of apptools

Update manifest.json to support the update of apptools

Installation package could be generated successfully except usecase-wrt-linux-tests
Unable to build project when "display" section of manifest.json is "minimal-ui",
issue tracked by XWALK-5028.

Did you verify this PR with App-tools 0.6?

Thanks, LGTM


Expected FPS with LIDAR enabled?

I have been consistently getting low (below real-time) frame rates when trying to run CARLA with LIDAR enabled, and I want to see whether this is the expected behavior with the CARLA LIDAR sensor or whether there is something with my CARLA/machine setup that is awry.
My software setup involved running a server instance from the Unreal Editor, and connecting to the server using the carla_ros_bridge ROS client.

CARLA server configuration:

Synchronous mode: True
Quality Level: Low
Sensors: LIDAR only
Map: Town01
Vehicles: 1, Pedestrians: 10

The LIDAR configuration that I used was similar to that of an HDL-64E LIDAR:
lidar_0:
  SensorType: LIDAR_RAY_CAST
  carla_settings:
    Channels: 64
    Range: 120
    PointsPerSecond: 1000000
    RotationFrequency: 20
    UpperFovLimit: 2.0
    LowerFovLimit: -24.8
    PositionX: 0.0
    PositionY: 0
    PositionZ: 1.50
    RotationPitch: 0
    RotationYaw: 0
    RotationRoll: 0

The frame rates that I was getting, as a function of the CARLA server fixed FPS, are as follows:

Fixed FPS
Measured FPS

20
4.950

15
3.344

10
2.463

5
1.238

Machine spec:

GPU: Geforce GTX1080
CPU: Intel Core i7-7820X
OS: Ubuntu 16.04

Other observations:

I tried disabling the rendering, and that didn't have much of an effect.
I noticed that the frame rate increased as the number of LIDAR points decreased, indicating that the ray-casting used for the CARLA LIDAR might be the bottleneck.
CARLA ran at anywhere from 2-5x real-time when I enabled the camera only.

Any help would be appreciated, and I'd be happy to provide more information about my setup and system specs if that would be helpful. Thanks!

I ran into a similar problem when trying to get more lidar points (fps gets stuck at 2.5 when I try to get more than 500k points per sec). I wonder if there is any way to accelerate this (maybe like parallelizing raycasts). Any suggestion would be appreciated.

@rohanb2018 Thanks for the very detailed report!
With the current Lidar implementation, each point is generated by a ray-cast. Although ray-casts are very optimized in UE4 they are an expensive operation. These sort of implementation is slow with very high number of points per second (with 100k points per second already slows down the simulation about the same as a camera). Some of the things we could try is parallelizing the individual ray-casts or sending them in batches, but the ray-cast API is limited.
However, we plan to add in the future a different implementation of a Lidar. Using the z-buffer fully implemented in the GPU, similar to our depth camera implementation.
Another thing that caught my attention is that there is a significant frame drop when using low fixed FPS. I will take a look into it. Some loss of FPS is expected though, but it seems a bit too much. We have enabled physics substepping, so when the frame rate is very low the physics engine gets updated several times per frame to keep the simulation accurate.

@nsubiron Thanks for your response! Looking forward to trying out the z-buffer implementation of LIDAR once it is complete.

@nsubiron Do you think it will be possible to simulate a Velodyne Sensor (360° FOV) with a z-buffer implementation? And what about the angular resolution? Would it be configurable or more or less be defined by the 'camera'?
This approach will perform very well in terms of performance but I wonder if it is suitable for lidar simulation.


How to finetune NLI model

Hi, could you please give me an overview of how to fine-tune an NLI model? Namely:

Which file to fine-tune
Possible prompts and commands, values of w or any relevant details

Hi, it is recommended to read this doc: https://github.com/SeanLee97/AnglE/tree/main/examples/NLI
I will add more docs later.

So I have to train the angle model before I can fine-tune it for the dataset I have in mind?

If you have prepared the NLI datasets, you can fine-tune the model using angle-trainer


CST queries documentation

Creating/using queries from cursors/trees
Query Syntax
Code Examples

https://github.com/AntonyBlakey/slang/blob/AntonyBlakey/integrate-stack-graphs/documentation/public/user-guide/concepts.md
https://github.com/AntonyBlakey/slang/blob/AntonyBlakey/integrate-stack-graphs/documentation/public/user-guide/query-language.md


Maintenance

This PR introduced proper handling for GPU and CPU installations.
It adds documentation how to handle those scenarios with poetry and adds a separate requirements.in file for GPU systems.

Additional information: The PR actually does not fully solve the issue with Poetry and PyTorch. Original idea was to have a keyword "gpu" that can be provided as extra parameter to allow switching between CPU and GPU installation.
However, there is an issue with the current version of poetry here which prevents this approach from working.
As I expect this to be fixed in the near future, I just disabled the line with the GPU source (see review comments by @eileen-kuehn ) to simply un-comment it when Poetry fixes aforementioned issue.

Maybe add an issue to fix the poetry issue? Just so it is not forgotten until they fixed it.


changing url dinamically

Thanks for this great plugin.
I've been exploring how to change the url (or any way to give some metadata to the file to upload).
By now, I've found this solution:
HTML
  <ng-dropzone class="dropzone"
      dropzone="vm.dropzone" options="vm.dropzoneConfig" callbacks="vm.dzCallbacks" methods="vm.dzMethods">
    </ng-dropzone>

angular module
vm.dropzoneConfig = {
  url:'http://url_by_default/',//need to put something here
  paramName : 'file',
  parallelUploads: 3,
  maxFileSize: 30
}
vm.dzCallbacks= {
  'processing': dzProcessing
}
function dzProcessing ( file ) {
  var dz = vm.dzMethods.getDropzone();
  dz.options.url='http://url_to_upload/'+vm.parameterOnUrl;
}

Please confirm me if there isn't any documented approach. If that is the case, I would ask you to include some instructions in the wiki examples.
Thanks!!

By far, I guess this is the only option. This plugin is just a directive of dropzone.js, so I am not sure if there is any other way to do this.

+1
I have a reference to dz in the controller of my component. You can also change the url with the reference you get in the $postLink event of your component.


about jaeger-ingester usage

Becasuse it looks like not much doc about jaeger-ingester, I have questions about it as following:
1, how to deploy mutiple instance for HA ?
I started two instances. First one failed as soon as second one started. error messages as following:
panic: counter cannot decrease in value

goroutine 63 [running]:
github.com/jaegertracing/jaeger/vendor/github.com/prometheus/client_golang/prometheus.(*counter).Add(0xc0001cb380, 0xbff0000000000000)
	/home/travis/gopath/src/github.com/jaegertracing/jaeger/vendor/github.com/prometheus/client_golang/prometheus/counter.go:71 +0xa3
github.com/jaegertracing/jaeger/vendor/github.com/uber/jaeger-lib/metrics/prometheus.(*counter).Inc(0xc0002b6810, 0xffffffffffffffff)
	/home/travis/gopath/src/github.com/jaegertracing/jaeger/vendor/github.com/uber/jaeger-lib/metrics/prometheus/factory.go:223 +0x46
github.com/jaegertracing/jaeger/cmd/ingester/app/consumer.(*Consumer).handleMessages(0xc000149a00, 0xf221a0, 0xc0001585a0)
	/home/travis/gopath/src/github.com/jaegertracing/jaeger/cmd/ingester/app/consumer/consumer.go:132 +0x872
created by github.com/jaegertracing/jaeger/cmd/ingester/app/consumer.(*Consumer).Start.func1
	/home/travis/gopath/src/github.com/jaegertracing/jaeger/cmd/ingester/app/consumer/consumer.go:91 +0x172

2, how to config mutilple jaeger-ingester to consume topic?
if jaeger-ingester lags, it's better to start multiple instance to consume topic.

1 - make sure you're running the latest version, the panic on the counter has been fixed in the recent release
2 -  not sure what the question is. You just run multiple ingesters in the same consumer group (i.e. with identical parameters), and they will distributed topic partitions amongst them. That is a standard behavior of the Kafka driver, Jaeger doesn't implement anything special.

thank you for quick reply.
1.12 worked.


Sign up for GitHub Sponsors

I know there is already a Donate link that goes through psfmember.com, but it would be really great to donate through GitHub.
Why not psfmember?
The current psfmember website requires PayPal (a company I do not do business with) or a personal check (which I don't want to use, and makes it hard to do recurring payments).
I really don't want to comment on how bat the UI / UX on that website is, but it is... not ideal.
GitHub Sponsors
GitHub already has my payment method, and it makes it VERY easy to set up single-time or recurring payments.  It's super seamless, and there are no transaction fees unless the entity making the donation is a business.  It takes about 5 minutes total to sign up.
https://github.com/sponsors is all you need
Additional Resources
There's a LOT more information on customization available here:

Announcing GitHub Sponsors: a new way to contribute to open source | The GitHub Blog
Getting started with GitHub Sponsors | The GitHub Blog
FAQ with the GitHub Sponsors team | The GitHub Blog
New sponsors-only repositories, custom amounts, and more  | The GitHub Blog

Sponsorship Made Easy
It's ridiculously simple.  GitHub already has your payment info, 0% fees for non-companies, and it takes exactly 3 clicks to donate.  You don't need to enter ANY data other than how much you want to donate, one-time or recurring, and that's all.
If you set up Sponsors for the Organization (pallets) you can configure whether your sponsors show up on the right side of the Github landing page.
Exactly Two Screenshots
It's really this easy for people to donate, AND it shows up in a standard, expected place on your repos!

Hi, I'm well aware of what GitHub Sponsors is, no need to make a marketing post, especially one that's geared towards an individual rather than an organization.
Pallets is a member of the PSF, and so our accounts are managed by them, and we take donations through them. Other funding sources, such as Tidelift and Read the Docs, have worked out with the PSF how to get money to them directly. While it seems like there may be a way to connect a PSF account with GitHub, it is not something I've had time to investigate yet, given everything else I am responsible for.
I'm not sure I understand the "bad UI" objection. It seems to have the same behavior as the GitHub page: enter your information, select your payment method, select the amount, and click donate. I haven't been confused or had any issues using it in the past. Perhaps you're referring to the website's design instead? Either way, that's something you'll need to take up with them.
See https://www.python.org/psf/donations/ for other ways to donate. The PSF can accommodate other payment methods, such as Zelle transfers. Contact them at<EMAIL_ADDRESS>for assistance.
I'm going to close this, as I don't need an issue to track it. I am aware of GitHub Sponsors and may enable it in the future if I have time to do so.

I sent a message to our PSF financial contact, but I can't say whether it will be easy or quick to set up.


this.$intercom is not a function

So, when attempting to access this.$intercom from within layouts or components, nuxt is throwing the above error.
I have it set up exactly as the documentation explains.
I have ensured my id is correct (when removing the offending code, Intercom springs into life). However, I need to update for the active user in my applicartion when they log in ...

@Jamiewarb Hi Jamie, sorry to pester. Are you able to offer any advise for the above issue?
I'm specifically looking to update the intercom package when a user is authenticated through our system... specifically when we call something like, this.$intercom('update', someUserObj) the system throws a not a function error. We have also tried this.$intercom.update() as well ... but not luck their either.
Any tips you could provide would be amazing! Thank you

Hey @asencis
Sorry to hear it's not working for you, I'd love to help fix! Are you able to share with me a small reproduction repo with instructions to reproduce? That'll allow me to spin it up with your exact problem and help find the cause
Thanks!

Hi @Jamiewarb I can't I'm afraid - it's quite the complex application. :/
The simplest reproduction would be to do the following:

Create a new nuxt application.
Install intercom as per your instructions within the documentation.
Call this.$intercom('update', params) where params is:

let params = {
    'appId': process.env.MY_INTERCOM_ID
}

Without the this.$intercom('update', params) line - Intercom boots absolutely fine.
Inspection of this.$intercom essentially does not expose a method for updating ... and looking through the source code I'm not sure we can overide a class initialisation from the instance ...

Thanks for that! Would you be able to spin that up in a repo and send me a link? Then I can clone it and see what's happening for you

@Jamiewarb Will try and get round to this ASAP. Thank you!

Hi @Jamiewarb , just a quick one as we might be able to fix but can I ask what the usage of this.$intercom on the component level? What do we have available etc, and within which lifecycle hooks etc etc

Should be injected by Nuxt
https://nuxtjs.org/docs/2.x/directory-structure/plugins/#inject-in-root--context

@Jamiewarb
So we're using this.$intercom('update', params) inside a method, which is called by a watcher which is watching for when the user object changes ...

It's a bit difficult to diagnose from just that as there's a few different places that it could be going wrong. Are you able to put a reproduction together?
this.$intercom should be injected into all Vue components clientside, the context serverside, and vuex stores. The following examples from Nuxt's docs on context would apply to this.$intercom:
export default {
  mounted() {
    console.log(this.$intercom);
  },
  asyncData({ app, $intercom }) {
    $intercom.boot();
  },
};

export const state = () => ({
  user: null,
})

export const actions = {
  setUserValueToWhatever(context, user) {
    this.$intercom.update(user);
  }
}

Available methods to call are here: https://github.com/hex-digital/nuxt-intercom/blob/master/lib/Intercom.js
If you want to make raw calls to the intercom object, and bypass this plugin's abstraction, call either window.Intercom or `this.$intercom.call()

@Jamiewarb Hi Jamie, so following your guide, we're not seeing the error.
Could you give us a some more info on what the user looks like, for example, we're just passing in the inetrcom defined user object, so name and user_id ... i.e. user = { name: '...', user_id: '...' }. Then we call: this.intercom.update(user)...however, we can no longer see the intercom widget ...
We have called this.$intercom.boot() directly after we update the user ... but nothing ....
We've also tried this:
this.$intercom.update({ user: this.intercomUser })
this.$intercom.boot()

...where this.intercomUser is { name: '...', user_id: '...' }.
Both yield no widget ...

Also, the example for the mounted lifecycle hook does not work, we receive this error:
Cannot find Intercom object on window. Make sure Intercom loaded correctly.

Thanks for the detail mate.
The plugin doesn't do a whole lot extra for you out of the box, so the best how to use guide would be Intercom's own documentation.
This plugin just:

Creates a placeholder object to store events called during SSR, and then sends those events once client-side hydration has taken over
Adds the Intercom script to the page once on mounted
Calls $intercom.init()
Calls $intercom.boot() if autoboot is true
Starts page tracking if pageTracking is true - page tracking is just an $intercom.update() call added to the ctx.app.router.afterEach event

It doesn't do a whole lot else - you can see it in all in https://github.com/hex-digital/nuxt-intercom
Intercom's documentation should then guide you for your application specific logic, such as when to update the user object, and what with.
If you disagree, let me know, as it would be good to improve this where we can. If you are able to write something without domain or application logic in to help explain to others some use cases, that would be super useful as well.

Hi @Jamiewarb ok so I probably need to close this now, I'm asking for a reproducable example of which calls to make and when we need to update a user. Nothing seems to be working, auto boot is also failing 9 times out of 10.
We simply want it to auto boot on first load (which it is failing to do so), and when the user changes we want to update $intercom with the userData needed or some default value...

Also, the example for the mounted lifecycle hook does not work, we receive this error:
Cannot find Intercom object on window. Make sure Intercom loaded correctly.

I had seen your problem facing similar to what I faced. I tried many ways and I found one way which I just add intercom.js as the script in the head of the application and the error was gone.
intercom.js
`//Set your APP_ID
var APP_ID = "APP_ID";
(function(){var w=window;var ic=w.Intercom;if(typeof ic==="function"){ic('reattach_activator');ic('update',w.intercomSettings);}else{var d=document;var i=function(){i.c(arguments);};i.q=[];i.c=function(args){i.q.push(args);};w.Intercom=i;var l=function(){var s=d.createElement('script');s.type='text/javascript';s.async=true;s.src='https://widget.intercom.io/widget/' + APP_ID;var x=d.getElementsByTagName('script')[0];x.parentNode.insertBefore(s, x);};if(document.readyState==='complete'){l();}else if(w.attachEvent){w.attachEvent('onload',l);}else{w.addEventListener('load',l,false);}}})();`
Got from: https://developers.intercom.com/installing-intercom/docs/basic-javascript
Hope it can help.


[ci-skip] updated haproxy chart

Changelog

Fix haproxy ingress checks
Update haproxy-ingress chart

Reviewed by
@jagpreetsinghsasan @sownak

Whats the difference between the haproxy chart (which is removed) vs the haproxy-ingress chart (newly added)?
Please add the commit message body as well (right now its just a header)

(To add both the header and the body, git commit -s will open the editor, where we can write both the header and the body)

Both helm charts are for Ingress controller implementation for haproxy Load balancer  (https://github.com/jcmoraisjr/haproxy-ingress), the helm charts are from here (https://github.com/haproxy-ingress/charts)
The difference is in their version.
Need to update the PR, will use packaged chart instead of copying the source code. Will update the commit message


Add //  to _AssembyInfo.KeyVaultHostingStartup.cs

In case customers use FxCop

release/2.0? Which release is this targeting?

In case customers use FxCop

StyleCop, actually. This change shouldn't impact FxCop at all.
@natemcmaster: This should (please) target the first stable release of the package in question (or a preview of the same).

@natemcmaster OOB of KeyVault HostingStartup


[Accessibility]A11y_VSCode_LangMode_Screenreader: Voiceover does not read the menu list items present in the tree view.

Environment Details:
VSCode Version : 1.24.1
OS Version : MAC OS HighSierra10.13.5
Additional Details:
Voiceover,MAS1.3.1
Repro Steps:
1)Launch VSCode.
2)Navigate to Status bar and select "Select Language Mode" button.
3)Check with Voiceover is reading.
Actual:
Voiceover does not read the menu list present on the screen.
Expected:
Voiceover should read the menu list which is present on the screen.
Recommendations:
Refer below link which is repository of bug fixes code snippets:
[https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx
](url)
User Impact:
User will not able to know that there are menu list items present on the screen.
MAS Reference:
[https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={8492c4eb-c179-40ae-8777-cd044ed725a2}
](url)
Attachment for Reference:
A11y_VSCode_LangMode_Screenreader.pptx
Does this issue occur when all extensions are disabled?: Yes

Dup of https://github.com/Microsoft/vscode/issues/52383


[SD-App] Please add drayde/nixietubeM5

https://github.com/drayde/nixietubeM5

The app has been scheduled for rebuild

Compilation of this package failed, it has been labeled as invalid until the source of the problem is identified and addressed


feat(Ads): Allow use a custom playhead tracker in CS

Related to https://github.com/shaka-project/shaka-player/issues/2792

Looks fine otherwise.

With the following code implemented on the application side it is possible to support https://github.com/shaka-project/shaka-player/issues/2792
Using ads.customPlayheadTracker = true
this.eventManager_.listen(this.adManager_, shaka.ads.AdManager.AD_STARTED, (e) => {
  if (e?.originalEvent?.type !== google.ima.AdEvent.Type.CONTENT_PAUSE_REQUESTED) {
    return;
  }
  if (loadTimeout) {
    clearTimeout(loadTimeout);
  }
  if (prevUrl === undefined && prevTime === undefined) {
    prevUrl = this.player_.getAssetUri();
    if (!this.player_.isLive()) {
      prevTime = this.video_.currentTime;
    }
    this.player_.detach();
    while (this.video_.lastChild) {
      this.video_.removeChild(this.video_.firstChild);
    }
  }
});

this.eventManager_.listen(this.adManager_, shaka.ads.AdManager.AD_STOPPED, (e) => {
  if (e?.originalEvent?.type !== google.ima.AdEvent.Type.CONTENT_RESUME_REQUESTED) {
    return;
  }
  if (loadTimeout) {
    clearTimeout(loadTimeout);
  }
  loadTimeout = setTimeout(async () => {
    await this.player_.attach(this.video_, true);
    this.player_.load(prevUrl, prevTime).then(() => {
      externalConfigAfterLoad();
    });
    prevUrl = undefined;
    prevTime = undefined;
  }, 100);
});

The idea is to implement this within ShakaPlayer itself in a future release.


Issues with pagespeed insight when loading a page with marker-clusterer

Hi, in our web application we use marker-clusterer for rendering key-points on maps.  Thank you!

Please note that this repo isn't maintained anymore. This fork is currently active and maintained: https://github.com/gmaps-marker-clusterer/gmaps-marker-clusterer
I don't have a site with pagespeed enaled, but you can easily replace the location of the markers, check this example:
https://gmaps-marker-clusterer.github.io/gmaps-marker-clusterer/#example-simple
Just set imagePath to a location on your local server and you should be fine.


Can't install -  Error: gyp failed with exit code: 1

I tried installing on my pi.
This was in the log:
2122 error<EMAIL_ADDRESS>install: node-gyp rebuild
2122 error Exit status 1
2123 error Failed at the<EMAIL_ADDRESS>install script.
2123 error This is most likely a problem with the mdns package,
2123 error not with npm itself.
2123 error Tell the author that this fails on your system:
2123 error     node-gyp rebuild
2123 error You can get their info via:
2123 error     npm owner ls mdns
2123 error There is likely additional logging output above.
2124 error System Linux 4.4.38-v7+
2125 error command "/usr/bin/nodejs" "/usr/bin/npm" "install" "-g" "--unsafe-perm" "homebridge"
2126 error cwd /usr/local/lib/node_modules
2127 error node -v v0.10.29
2128 error npm -v 1.4.21
2129 error code ELIFECYCLE
2130 verbose exit [ 1, true ]

2127 error node -v v0.10.29

Update your node installation to 6.x LTS
ELIFECYCLE errors always mean "End Of Life Cycle"

Run sudo apt-get install libavahi-compat-libdnssd-dev
I had this problem too. You just have to install libavahi-compat-libdnssd-dev package

I have tried installing avahi like mentioned above but I get this error:
The following packages have unmet dependencies:
libavahi-compat-libdnssd-dev : Depends: libavahi-client-dev but it is not going to be installed
E: Unable to correct problems, you have held broken packages.
New to all this so dont know what more info you want. Have updated node to 4.2.1 and nodejs to 6.10.0 but just cant install avahi. Running Rpi 2 with Raspbian Jessie

You can try to fix broken dependencies with sudo apt-get install -f

Node and nodejs are supposed to be the same (actually node is commonly a link to nodejs). If they show different versions
node -v
nodejs -v
then you have two different installations with different versions which is most probably going to provoke strange errors.

Thanks. Reinstalled node so that it now shows the same version when I run node -v and nodejs -v. 6.10.0. Ran npm install without errors. Tried running:
sudo apt-get install -f libavahi-compat-libdnssd-dev
But still get the same error:
The following packages have unmet dependencies:
libavahi-compat-libdnssd-dev : Depends: libavahi-client-dev but it is not going to be installed
E: Unable to correct problems, you have held broken packages.
Any ideas where to go from here?

You could try this: http://askubuntu.com/questions/164587/how-can-you-unhold-remove-a-hold-on-a-package
That's what google found.

Think it had to do with my install of netatalk. Removed that and now I can install avahi. Thanks.


Update geofencing_zones.json

Fixed a typo in geofencing_zones.json

Closing, this has been fixed in #58


Clearer description for excluding services

Hi, Thanks for the Battery Aggregator.
I had trouble figuring out how the excluded services works in the config.json, then finally cracked it after reading through old issues, as it wasn't obvious to me from the initial read me note.
Can I suggest it would also help others if a bit more info was added in the read me, something like:
To exclude the battery service com.victronenergy.battery.shunt1, first run dbus-spy from command line to see the address for the shunt you wish to exclude,  it will show up as: com.victronenergy.battery.tty7 or similar, so add:
"excludedServices": ["com.victronenergy.battery.shunt1"]

But replace shunt1 with tty7 for example, from the last part of the address found in dbus-spy

Thanks, done.


Reuse MaybeConvertWasmExtensionConfig

Please provide a description of this PR:

@bianpengyuan

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
a8c543a7042086337e3b2e8374569d44416d8f97
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
a8c543a7042086337e3b2e8374569d44416d8f97
link
true
/test release-notes_istio

integ-pilot-multicluster-tests_istio
a8c543a7042086337e3b2e8374569d44416d8f97
link
true
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Github Action file to publish automatically to Open VSX

# Controls when the workflow will run
on:
   # Weekly at 00:00 UTC
  schedule:
    - cron: '0 0 * * 0'

name: Deploy Extension
jobs:
  deploy:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
      - uses: actions/setup-node@v1
        with:
          node-version: '16'
          cache: 'npm'
          check-latest: true
      - run: npm install
      - run: npm ci
      - name: Publish to Open VSX Registry
        uses: HaaLeo/publish-vscode-extension@v0
        with:
          pat: ${{ secrets.OPEN_VSX_TOKEN }} # Assumes token is stored as OPEN_VSX_TOKEN

See #11


Get local DB set up

USER STORY
As a developer, ISBAT run a local instance of the database (Maybe Mongo? Dynamo? SQL)
ACCEPTANCE CRITERIA
GIVEN
A developer
WHEN
Setting up a local dev environment
THEN
They should be able to follow instructions to run a local instance of the database

This is actually going to be for setting up the database connection.


Disabled colors in dark mode incorrect

I'm using 3.4.4 and in light mode the colors of the controls get more muted when they are disabled (as expected). In dark mode they get more prominent instead.

The problem should be resolved in 3.4.5.

Any idea when 3.4.5 will be released?

Check the pre-release and see if it works as expected. If no other style issues are found, it will be set as the latest version.

Yes, the pre-release fixes my issue.


[pre-commit hook] An unexpected error has occurred: CalledProcessError: command: ('/usr/bin/git', 'config', 'remote.origin.url')

Describe the bug
On Ubuntu, and using gitleaks in a pre-commit hooks is cashing at the initialization step
To Reproduce
As stated in the doc, in the .pre-commit-commit.yaml add the following
  - repo: https://github.com/zricethezav/gitleaks
    rev: v8.13.0
    hooks:
      - id: gitleaks

Then run:
pre-commit run --all-files --verbose
I am getting:
[INFO] Installing environment for https://github.com/zricethezav/gitleaks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
An unexpected error has occurred: CalledProcessError: command: ('/usr/bin/git', 'config', 'remote.origin.url')
return code: 1
expected return code: 0
stdout: (none)
stderr: (none)
Check the log at /home/jupyter/.cache/pre-commit/pre-commit.log

Looking at the logs doesn't give me a message that I can understand
version information
pre-commit version: 2.20.0
git --version: git version 2.37.3
sys.version:
    3.10.6 | packaged by conda-forge | (main, Aug 22 2022, 20:35:26) [GCC 10.4.0]
sys.executable: /opt/conda/envs/jupyter-notebook/bin/python
os.name: posix
sys.platform: linux

error information
An unexpected error has occurred: CalledProcessError: command: ('/usr/bin/git', 'config', 'remote.origin.url')
return code: 1
expected return code: 0
stdout: (none)
stderr: (none)

Traceback (most recent call last):
  File "/opt/conda/envs/jupyter-notebook/lib/python3.10/site-packages/pre_commit/error_handler.py", line 73, in error_handler
    yield
  File "/opt/conda/envs/jupyter-notebook/lib/python3.10/site-packages/pre_commit/main.py", line 386, in main
    return run(args.config, store, args)
  File "/opt/conda/envs/jupyter-notebook/lib/python3.10/site-packages/pre_commit/commands/run.py", line 424, in run
    install_hook_envs(to_install, store)
  File "/opt/conda/envs/jupyter-notebook/lib/python3.10/site-packages/pre_commit/repository.py", line 223, in install_hook_envs
    _hook_install(hook)
  File "/opt/conda/envs/jupyter-notebook/lib/python3.10/site-packages/pre_commit/repository.py", line 79, in _hook_install
    lang.install_environment(
  File "/opt/conda/envs/jupyter-notebook/lib/python3.10/site-packages/pre_commit/languages/golang.py", line 69, in install_environment
    remote = git.get_remote_url(prefix.prefix_dir)
  File "/opt/conda/envs/jupyter-notebook/lib/python3.10/site-packages/pre_commit/git.py", line 97, in get_remote_url
    _, out, _ = cmd_output('git', 'config', 'remote.origin.url', cwd=git_root)
  File "/opt/conda/envs/jupyter-notebook/lib/python3.10/site-packages/pre_commit/util.py", line 152, in cmd_output
    returncode, stdout_b, stderr_b = cmd_output_b(*cmd, **kwargs)
  File "/opt/conda/envs/jupyter-notebook/lib/python3.10/site-packages/pre_commit/util.py", line 146, in cmd_output_b
    raise CalledProcessError(returncode, cmd, retcode, stdout_b, stderr_b)
pre_commit.util.CalledProcessError: command: ('/usr/bin/git', 'config', 'remote.origin.url')
return code: 1
expected return code: 0
stdout: (none)
stderr: (none)

Expected behavior
Should install gitleaks and run it for the given github repository. It is working fine with other pre-commit hooks.
Basic Info (please complete the following information):

OS:
Distributor ID: Ubuntu
Description:    Ubuntu 20.04.5 LTS
Release:        20.04
Codename:       focal

Gitleaks Version:  v8.13.0

I tried other version but I see the same issue. Seems to be related the way github tried setup and clone the repo
Additional context
No access to internet. I am using a proxy server but normally all url needed are whitelisted including github.com
git remote -v
origin  https://github.xxxcom/xxx/xx-utils.git (fetch)
origin  https://github.xxx.com/xxx/xx-utils.git (push)

the command that the system try to run doesn't seems to be a valid command
/usr/bin/git config' remote.origin.url
I didn't find where is the script that try to do the installation. Any suggestion where to look at it to debug this installation issue ?
Thanks
cc @zricethezav

seems to be ok:
(jupyter-notebook)jupyter@:~/.cache/pre-commit/repors3wlicl$ls -la
total 232
drwx------ 10 jupyter jupyter  4096 Oct  3 19:18 .
drwxrwxr-x 20 jupyter jupyter  4096 Oct  3 19:18 ..
drwxrwxr-x  5 jupyter jupyter  4096 Oct  3 19:18 .git
drwxrwxr-x  4 jupyter jupyter  4096 Oct  3 19:18 .github
-rw-rw-r--  1 jupyter jupyter   195 Oct  3 19:18 .gitignore
-rw-rw-r--  1 jupyter jupyter 72456 Oct  3 19:18 .gitleaksignore
-rw-rw-r--  1 jupyter jupyter   492 Oct  3 19:18 .goreleaser.yml
-rw-rw-r--  1 jupyter jupyter   401 Oct  3 19:18 .pre-commit-hooks.yaml
-rw-rw-r--  1 jupyter jupyter  4291 Oct  3 19:18 CONTRIBUTING.md
-rw-rw-r--  1 jupyter jupyter   502 Oct  3 19:18 Dockerfile
-rw-rw-r--  1 jupyter jupyter  1069 Oct  3 19:18 LICENSE
-rw-rw-r--  1 jupyter jupyter   559 Oct  3 19:18 Makefile
-rw-rw-r--  1 jupyter jupyter 15797 Oct  3 19:18 README.md
drwxrwxr-x  3 jupyter jupyter  4096 Oct  3 19:18 cmd
drwxrwxr-x  2 jupyter jupyter  4096 Oct  3 19:18 config
drwxrwxr-x  3 jupyter jupyter  4096 Oct  3 19:18 detect
-rw-rw-r--  1 jupyter jupyter  1814 Oct  3 19:18 go.mod
-rw-rw-r--  1 jupyter jupyter 62576 Oct  3 19:18 go.sum
-rw-rw-r--  1 jupyter jupyter   611 Oct  3 19:18 main.go
drwxrwxr-x  2 jupyter jupyter  4096 Oct  3 19:18 report
drwxrwxr-x  2 jupyter jupyter  4096 Oct  3 19:18 scripts
drwxrwxr-x  7 jupyter jupyter  4096 Oct  3 19:18 testdata

(jupyter-notebook)jupyter@:~/.cache/pre-commit/repors3wlicl$git remote -v
origin  https://github.com/zricethezav/gitleaks (fetch)
origin  https://github.com/zricethezav/gitleaks (push)

I have the feeling that the script is failing somewhere else and report the wrong issue.
what is done after the repo is clone by the pre-commit hook ? I didn't really find it.
If I try to use "make" then I see some issues with url redirect blocked by the proxy.
Now, if I tried to mimic what is done in "cmd_output"

go to the repo
run git config remote.origin.url  output nothing
but if I use:
git remote -v
origin  https://github.com/zricethezav/gitleaks (fetch)
origin  https://github.com/zricethezav/gitleaks (push)

I am not an expert but it seems that git config remote.origin.url is not returning what is should be (or I don't understand how the command should be run)
 git --version
git version 2.37.3

Ok, I think the issue is related to that. If I pass the --file, then it works:
git config -f .git/config --get remote.origin.url
https://github.com/zricethezav/gitleaks

For my proxy config, I am setting a  GIT_CONFIG=/home/jupyter/.gitconfig
It seems that in new version "For reading options: read only from the specified file rather than from all available files." Stackoverflow the -f option need to be set.

I have the same error if instead of gitleak github repo, I am using one of my github repository.

Glad to hear the issue is not specific to gitleaks.

It seems that in new version "For reading options: read only from the specified file rather than from all available files." Stackoverflow the -f option need to be set.

Does that mean you've resolved the issue? Does it make sense to close this issue now?

@weineran the issue seems to be either on my git config (still have the issue even if I am not using GIT_CONFIG env variable) or on the pre-commit python utis. It seems not related to gitleaks directly.
I will close this ticket. The discussion is continuing here: https://github.com/pre-commit/pre-commit/issues/2540

Issue fixed, in my case having a env variable GIT_CONFIG was creating the issue. An empty value is not a valid solution as well. The env variable should not be created or unset.

Thanks for posting the solution @tarrade !


Add .NET Standard 2.0 build

This adds a netstandard2.0 build consumable on .NET Core 2.0, .NET Framework 4.6.1+, Xamarin platforms, and the next version of UWP (this doc has a complete support matrix).
Compared to the netstandard1.3 build, it shares much more code with .NET Framework builds. Some classes still aren't available:

Everything using ASP.NET (would need rewriting for ASP.NET Core)
Everything using remoting (EventLogAppender, RemoteLoggingServerPlugin, RemotingAppender)
WindowsSecurityContext (Windows user impersonation isn't in .NET Standard 2.0)

A few classes are supported on Windows alone because they PInvoke Win32 DLLs. These throw PlatformNotSupportedException on non-Windows platforms:

ColoredConsoleAppender
NativeError
NetSendAppender

Similarly, UserNamePatternConverter is included but will raise a PlatformNotSupportedException when it tries to get the current WindowsIdentity on a non-Windows platform. It catches and reports this exception.
I also include csproj files for developing with Visual Studio 2017. The new log4net.csproj enables building assemblies for all .NET Framework and Core platforms, and packing them with NuGet. It has some limitations outside of Visual Studio 2017:

The dotnet CLI can't build the project for .NET Framework 3.5 and below due to a known issue
On non-Windows platforms, a similar issue requires workarounds to enable building net* assemblies with Mono

I'm pleased to say that I was able to merge large parts of your work into the branch feature/netstandard-2.0 and the build passed. Unfortunately the tests are currently not run because I was not able to get that part to work.
#6 failed in stage compile-netstandard-1.3 because the test project does not target netstandard1.3
#7 failed in stage compile-netstandard-2.0 because a test failed and that caused the entire build to fail; all other compile stages aggregate test results and eventually fail in stage check test results and we should improve the netstandard stages to do that too
#8 passed and includes the artifacts both for netstandard-1.3 and netstandard-2.0
I'm now working on the branch feature/cd-pipeline to finally run the tests against netstandard-1.3, collect the test results and finally check those test results later. I do this to incrementally work towards integrating also netstandard-2.0 by first adding full support for netstandard-1.3. Would you like to join in and help me with that?
I'm not sure how we should proceed with this pull request. What do you think?

Glad the build works. I expect CI will be blocked until there's some resolution for nunit/nunit3-vs-adapter#377, and I suppose there's also a decision to make about the exclusive locking test. The failure isn't a regression from netstandard1.3 but I'd like at least to get clearer about the root cause. I probably won't have time to get deeper into it until late next week.
Since you've merged this code into a feature branch, I think we can close this PR, and I'll base anything further on that branch. Do we need an issue somewhere to track work needed before a release supporting netstandard2.0?

Alright, let's move further discussion to JIRA (LOG4NET-572, LOG4NET-567). I would have to craft a commit to close the pull request, would you please close it?


NavBarButton warning - requires unique keys

Describe the bug
A warning is displayed stating a child array of the NavBarButton component requires unique keys.
To Reproduce
Use the NavBarButton component in the NavBar organism.
Expected behavior
No warning is to be displayed
Screenshots

Smartphone (please complete the following information):

OS: Android and iOS

Hey @samsam-026 , can I take a crack at this?

Hey @samsam-026 , can I take a crack at this?

Sure, Go ahead.
Please do have a look at the contributing guidelines, before you do so.
Thanks!

Hey @samsam-026 - please check pull request #20

Fixed in pull request #20.


Default dates are not getting displayed.

Default dates are not displayed, I am trying to select today's date and one month previous date, which is not displayed inside the input box, i have tried all kinds of solutions and every possible resolution provided by users in github and as well as stackoverflow, nothing worked, please help, below is my code.
$('#from').datepicker({
    format: 'mm/dd/yyyy',
    autoclose: true,
    startDate: '-1y',
    endDate: '+2y',
    todayHighlight: true
});
var currentDate = new Date();
$('#from').datepicker('update', currentDate);
$('#to').datepicker({
    format: 'mm/dd/yyyy',
    autoclose: true,
    startDate: '-1y',
    endDate: '+2y',
    todayHighlight: true
});
currentDate.setDate(currentDate.getDate() - 31);
$('#to').datepicker('update', currentDate);

can you provide a jsfiddle?

OK, i figured out the problem it is with jQuery plugin, everything works fine, with just datepicker files added as external resources, if I add jQuery plugin then nothing works, here is a fiddle link,
http://jsfiddle.net/DwT8M/675/

Not a bug, it was angular which was causing a problem, fixed it by my self, thank you, anyway :)


connection: Terminate state string with newline

Signed-off-by: Carl Helmertz<EMAIL_ADDRESS>

Just fix that little leak and I'd be happy to merge it.

I don't know what I was thinking here, the code is fine. Thanks!


Add docker container to run ookla speedtest

Also create a separate script that makes more sense in a container environment. The current one's error handling is not the best, because it is meant to run as a cronjob it should not output anything. In a container environment that does not really matter.
See the README adjustment for more details.

Interesting and very good point.  I admittedly did the docker stuff as an afterthought to just lay on top and didn't give much thought to it beyond that, which I think is obvious and you picked up on it.  I'll have to look at these and add them in.

@tbblake Let me know if you need any inputs, I used the following CronJob on k8s because I deployed zabbix using https://github.com/zabbix-community/helm-zabbix.
apiVersion: batch/v1
kind: CronJob
metadata:
  name: speedtest
spec:
  schedule: "0 * * * *"
  jobTemplate:
    spec:
      template:
        spec:
          containers:
          - name: speedtest
            image: siegy22/speedtest-cli-zabbix:latest
            imagePullPolicy: IfNotPresent
            env:
              - name: ZABBIX_SERVER
                value: "zabbix-zabbix-server.zabbix.svc"
              - name: SPEEDTEST_HOST
                value: "my-speedtest"
          restartPolicy: OnFailure

But as that is pretty k8s specific I didn't include it here, but might be something that people can use as well.


Suffix Error while using it with value using first letter M or B

Describe the bug
It show 120,000,003,000,000M when i type 123 while using suffix with first letter "M" or "B"
To Reproduce
Steps to reproduce the behavior:

Add Suffix with value start with letter M or B
Type 123

Expected behavior
It show 123M
Code Sandbox
https://codesandbox.io/s/hardcore-wilbur-9w654g?file=/src/App.js
Additional context

I miss the documentation. I should use disableAbbreviations={true} to make it worked.


Use spheres for prob image

Closes #7

may be confusing for the input to still be called t1w

Good catch, fixed this and will merge now


bumps deps; peerDeps allows ESLint 2 or 3

specify ESLint 2 or 3 as a peerDependency to help npm users identify compatibility issues

specify Node.js 0.10 as the minimum (same as ESLint 2)

Wouldn't it be wiser to wait on updating the rule format, so there can be a version of the plugin that supports both eslint 2 and eslint 3 for awhile?

@ljharb my changes here are just a proposal of course, with the maintainers having final say. I made these changes assuming that the MAJOR SemVer number would be bumped, so ESLint 2 users could still use the previous version without any problems.
Do we want to continue making changes to the ESLint 2 version of this plugin? Or can we safely leave it as-is?

Yes, ideally we would keep making changes to the eslint "2 + 3" version for awhile, so as to give eslint 2 users (and node 0.10 users) as smooth an upgrade path as possible, for as long as possible. The only time this PR will become necessary is after eslint v4 comes out, so I'm inclined not to rush it.

Okay. If I get time later, I'll change this PR to keep the old ESLint 2 rule format. Or, someone else can beat me to it by creating a less turbulent PR. :)

@ljharb okies, I've removed all rule format changes, this is purely about enabling usage with ESLint 3 without touching existing support for ESLint 2

LGTM

What's blocking this from being merged?

@yannickcr it'd be great to get a release of this :-)

@ljharb Thanks for your help, I'm a bit late on this :( I'll try to do a release tomorrow.

@yannickcr thanks! looking forward to releasing a new eslint-config-airbnb ;-)

@jokeyrhyme turns out eslint v2 supports the new rule format already (https://github.com/benmosher/eslint-plugin-import/issues/406#issuecomment-231132889) so if you'd like to make a new PR that upgrades the rules, id be happy to merge it :-)

@ljharb woah, that's really good planning on ESLint's part. I'll see how extra-curricular I'm feeling this weekend. :)

@ljharb Since adding a peerDepencency is a big change I prefer to consider it as a breaking change.
I am not ready yet to publish the v6.0.0 (I'd like to add a few more waiting changes in it) so I published it as v6.0.0-alpha.1. You can install it with npm install eslint-plugin-react@next.

@yannickcr understood - in this case I don't think anybody is still using eslint v1 with eslint-plugin-react, but it's good to be cautious. I won't be able to release an updated eslint-config-airbnb without a non-alpha eslint-plugin-react anyways, but as you can see I've got a few more blockers, so within the next week or so would be ideal if that's ok :-)

Do you have a GitHub Milestone for 6.0, or a list somewhere? Want some help?

@ljharb @jokeyrhyme I do not have a lot of time this week but I'll try to do an roadmap before the week-end (like I made for 4.0 #436)


Fix "No such file or directory" exception in notebook2script.py

Issue: When "exp" directory doesn't exists the script throw an exception!
Fix: Check for "exp" directory existence and if it doesn't exist, makes the directory.

Thanks!


Added ListBulkCreateDestroyAPIView to generics

@davideme thank you for the contribution. can you add yourself in credits in readme and Ill merge


Small grammatical fixes

Per author's request in issue #15, I provided some small grammatical adjustments. The author's English is very good so there wasn't much to fix.

Thank you so much for the proof checking!


Scrolling issue - Select on sticky header make unwanted page scroll up

Bug report
Current Behavior
Page scroll up when open or close  radix-ui/react-select inside a sticky header. Maybe because the select component is focused on open/close
Expected behavior
Global page scroll doesn't change when open/close a select compoment
Reproducible example
https://codesandbox.io/s/scrolling-issue-select-on-sticky-header-sr5fgz?file=/src/App.tsx
In my project i have this issue on select open. I dont find a way to reproduce it on codesandbox, but on codesandbox i have this issue on close
On my project:

On codesandbox: (https://codesandbox.io/s/scrolling-issue-select-on-sticky-header-sr5fgz?file=/src/App.tsx)

Suggested solution
Maybe provide a way to disable the focus onClick or use a focus without scrolling with something like
element.focus({ preventScroll: true });

Additional context

Your environment

Software
Name(s)
Version

Radix Package(s)
@radix-ui/react-select
1.2.2

React
react
18.2.0

Browser
Chrome on windows
116.0.5845.111

Assistive tech

Node
n/a

npm/yarn

Operating System

Hello @zecka i had a similar issue on a project i worked on. what i did is put the Select.Content inside Select.Portal and it fixed the issue for me. I tested it on your code on codesandbox and it worked.
Happy coding.

I had an issue where if <body> had height: 100vh; set, opening the select causes the jump to top. Very curious as to why it's happening.

I can confirm that i have same issue in NextJS when set:
 body > div {     @apply flex min-h-svh flex-col;   }
then select content jumps to top and became not visible, as a temporry workaround i use avoidCollisions={false} but i'm looking for solution as well

Was this issue fixed in some way?

my workaround is manually create a portal instead of using radix's:
return createPortal(
      <SelectPrimitive.Content>
        <SelectPrimitive.Viewport>
            // ...content here...
        </SelectPrimitive.Viewport>
      </SelectPrimitive.Content>,
    document.body
  );


Support es2015+ in phenomic config

as in #1071  but for phenomic config.
It allows importing / re-exporting presets while changing only part of the plugins.
ie.
my version of preset-react-app
without having to use babel-register and cjs exports as done here

FYI, we are using https://github.com/davidtheclark/cosmiconfig so we might investigate on this side.
I start babel-register via the cli so we can use babel for config file, not sure why it's not working for this one.


Native support for Jpeg2000

[ X] I've read, understood, and done my best to follow the *CONTRIBUTING guidelines.

What did you do?
I try load a Jpeg200 image. The content-type of response is image/jp2
What did you expect to happen?
A succes operation without need to call  Data Request.addAcceptableImage ContentTypes(Set<String>(["image/jp2"]))
What happened instead?
A failure with :
failure : AFError
    ▿ responseValidationFailed : 1 element
      ▿ reason : ResponseValidationFailureReason
        ▿ unacceptableContentType : 2 elements
          ▿ acceptableContentTypes : 11 elements
            - 0 : "image/png"
            - 1 : "image/x-xbitmap"
            - 2 : "image/tiff"
            - 3 : "image/gif"
            - 4 : "image/x-icon"
            - 5 : "image/x-bmp"
            - 6 : "image/bmp"
            - 7 : "image/x-win-bitmap"
            - 8 : "image/x-ms-bmp"
            - 9 : "image/jpeg"
            - 10 : "image/ico"
          - responseContentType : "image/jp2"

Alamofire Environment
Alamofire version:
3.6.0
Xcode version:
12.0
Swift version:
5.2
Platform(s) running AlamofireImage:
macOS version running Xcode:
10.15.6

This has been released as part of 4.2.0.


add local services feature

@alena1108

@wlan0 there is some problem with the build not invoking tests, I'll look into it. But tests are failing due to the new method added to meta fetcher. Can you run "go test" locally and add noop method getSelfHost to corresponding tests?


Homebridge unable to access poe ports. Code 400

Hi there
Since the last few updates on unifi, including the addition of Ethernet port profiles, it is increasingly difficult to control or gain access to control the poe ports in this (brilliant) plug in. I do not think it’s an issue with the plug in but with unifi os. Can you help with a workaround, in unifi os, to getting the communication working?

Can you give me more infos?

Logs
UniFiOS Version
UniFiOS Console (UDMSE, UDMPRO etc.)
What do you want to control? Which switch?

Hi there
It was on 3.15 unifi OS, but seems to have settled on 3.16.
Also the present version on Unifi Network (I’m travelling abroad on business so cant get to my network controller at the moment)
The Switch is a USW 48 Port POE, running the up to date firmware. Nothing is beta or early release.
It’s working again since I updated again. Damned Unifi updates. If it happens again, do you mind if I get the logs etc to you.
Englisch oder Deutsch.
Ich bedanke mich.


Feature/pybind11 planner

Exposed Some C++ Read-Only Property to Python
Added rmf_traffic::agv::Plan::Waypoint::approach_lanes.
Added rmf_traffic::agv::Plan::Waypoint::itinerary_index.
Added rmf_traffic::agv::Plan::Waypoint::trajectory_index.
The approach_lanes property might be useful for those who want their fleet adapters to deal with lane closures.
I don't need the itinerary_index and trajectory_index.  But, since it's a public interface in C++, I thought it might be useful to others who might need that.

Oops, sorry.  I accidentally deleted that.  Now, graph_index is back.


Refactor go code to be identity centric

Restructured the go class to have an Identity class:

has a privateKeys map for multiple key support (the example currently still uses a single private key)
has private and public attribute at the top level to indicate the ownership of data ( folder structure also changed to reflect this)
decoupled auth claim proof generation and generic claim proof generation.

Hi @jimthematrix @nedgar , please take a look at this PR and leave your comment.

@jimthematrix @nedgar thanks for the comments. I realised the readme needs a bit more update, will work on that as well.

I've addressed all of the review comments


IYO Registration form: E-mail field allows invalid e-mail

Steps to reproduce:

Navigate to Itsyou.online
Click register
Fill in a non-existing username
Fill in a non-valid e-mail address (e.g. tester@a)

Expected behavior
Validation should happen on the e-mail field.
Actual behavior
Validation accepts invalid e-mail address and moves on to 2factor auth when filling in a password.

Tested using:
Mozilla Firefox 51.0.1
Microsoft Edge 38.14393.0.0
Google Chrome 56.0.2924.87
Internet Explorer 11

Add a simple liberate regex check

both on register page and on profile page

Still errors concerning capitals


Travel method selection page desktop

Please review travel method selection page for desktop page

form/TravelMethod.jsx
Trello link  : https://trello.com/c/z50v3GrA/297-dev-travel-method-selection-page

PR 69 depends on PR67/PR68, and that PR67/PR68 should be reviewed/approved/merged before reviewing PR69.

FYI,
for TravelMethodButtons component, icon and text within button are not centered.
I've added it to our TODO list to fix this before survey release.