Fix enter key behavior changes after resizing window to small screen

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/17206
PROPOSAL: https://github.com/Expensify/App/issues/17206#issuecomment-1501832125
Tests

On Web/Desktop

Open a chat and write a new message
Hit “Enter/Return” on keyboard
Verify that the message is sent as expected
Resize the window to show the mobile version
Open a chat and write a new message
Hit “Enter/Return” on keyboard
Verify that the message is sent as expected
Repeat step 1->7 for editing an existing message

On mWeb/Native app

Open a chat and write a new message
Hit “Enter/Return” on soft keyboard
Verify that the message is created a new line instead of sending the message
Repeat step 1->3 for editing an existing message

[x] Verify that no errors appear in the JS console

Offline tests

This fix is not related to offline mode
QA Steps

Same as above

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://user-images.githubusercontent.com/9639873/235977157-1b2a10b6-54ce-4e05-9b2d-420d05928ee8.mp4

Mobile Web - Chrome

https://user-images.githubusercontent.com/9639873/235977212-4b77d778-70b4-442d-9a49-902a60216630.mp4

Mobile Web - Safari

https://user-images.githubusercontent.com/9639873/235977336-bf216b35-ba20-4400-b3f7-3b0cd1e837a8.mp4

Desktop

https://user-images.githubusercontent.com/9639873/235977370-7a41d6ba-0a62-4ff0-963d-9566f44cc3d7.mp4

iOS

https://user-images.githubusercontent.com/9639873/235977395-7c4faa42-9250-4a9a-91cd-c9b4b6315e69.mp4

Android

https://user-images.githubusercontent.com/9639873/235977428-b058f049-4f78-4310-a197-5aed54f5fa6c.mp4

@joelbettner @rushatgabhane One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/joelbettner in version: 1.3.11-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.12-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Sign in button does not appear

Extension version: 0.56.0
VSCode Version:1.74.3
OS:Mac Monteray 12.0.1

Steps to Reproduce:

Install GitHub extension

The login button never displays in the extension. It simply states "Not git repositories found" but I have no ability to login. There is no button.

@kevinwasie did you open a folder that contains a git repository?


add helper method IsIndexValid

adding helper func will help in places like this:
function THasherList.GetName(Index: Integer): String;
begin
  if (Index > FList.Count-1) or (Index < 0) then Result := ''

This is a very simple IF. Replacing it with a method will make the slower.

then add inline.


WASM Support

I think it's possible, but I may need to figure out the right feature flags for Tokio and Reqwest.
Some references:

https://docs.rs/tokio/latest/tokio/#wasm-support
https://docs.rs/reqwest/latest/reqwest/#wasm

There is an experimental branch (PR) that can be compiled to the wasm32-unknow-unknown target using cargo build --no-default-features -F wasm --target wasm32-unknown-unknown: https://github.com/JacobLinCool/gradio-rs/pull/4


Requests don't allow multiple files for a key

We are a startup developing a programmable email platform and we love using Requests.
However we have encountered a problem recently.
Our API tends to send data in key value pairs where a key could have multiple values.
In order to do so we used multi dictionary and it worked pretty well with Requests 0.7.5.
But with new versions of Requests e.g. 0.8.2 it looks like we won't be able to do that.
The problem is that data structures to store 'params', 'data' and 'files' are explicitly set to be dictionaries.
For 'params' and 'data' we could use a list of values for a key but it won't work for 'files'.
I don't know what the mentioned changes in Requests are based on but
is there a chance that the situation would change regarding multi valued keys?
Any advise regarding the issue?

@mailgun Multiple values for singe key are allowed. See test_urlencoded_post_query_multivalued_and_data

So the problem exists only for files?

This appears to be a bug in the file upload logic. I'll investigate.

Thanks!
On Sat, 26 Nov 2011 07:33:24 -0800
Kenneth Reitz
<EMAIL_ADDRESS>wrote:

This appears to be a bug in the file upload logic. I'll investigate.

Reply to this email directly or view it on GitHub:
https://github.com/kennethreitz/requests/issues/285#issuecomment-2882085

My pull request was rejected. https://github.com/kennethreitz/requests/pull/422#issuecomment-4058039
I'm going to submit a new issue for urllib3.

Now the urllib3's encode_multipart_formdata function supports the list of tuples. Could you please take in the latest urllib3 and then modify like this patch?
diff --git a/requests/models.py b/requests/models.py
index 8368c9f..ca7d0b2 100644
--- a/requests/models.py
+++ b/requests/models.py
@@ -404,11 +404,6 @@ class Request(object):
if self.files:
if not isinstance(self.data, str):

           try:

               fields = self.data.copy()

           except AttributeError:

               fields = dict(self.data)

           for (k, v) in list(self.files.items()):
               # support for explicit filename
               if isinstance(v, (tuple, list)):

@@ -416,9 +411,9 @@ class Request(object):
else:
fn = guess_filename(v) or k
fp = v

               fields.update({k: (fn, fp.read())})

               self.data.append((k: (fn, fp.read())))

           (body, content_type) = encode_multipart_formdata(fields)

           (body, content_type) = encode_multipart_formdata(self.data)
       else:
           pass
           # TODO: Conflict?

Now the urllib3's encode_multipart_formdata function supports the list of tuples. Could you please take in the latest urllib3 and then modify like this patch?
"""
diff --git a/requests/models.py b/requests/models.py
index 8368c9f..ca7d0b2 100644
--- a/requests/models.py
+++ b/requests/models.py
@@ -404,11 +404,6 @@ class Request(object):
if self.files:
if not isinstance(self.data, str):

           try:

               fields = self.data.copy()

           except AttributeError:

               fields = dict(self.data)

           for (k, v) in list(self.files.items()):
               # support for explicit filename
               if isinstance(v, (tuple, list)):

@@ -416,9 +411,9 @@ class Request(object):
else:
fn = guess_filename(v) or k
fp = v

               fields.update({k: (fn, fp.read())})

               self.data.append((k: (fn, fp.read())))

           (body, content_type) = encode_multipart_formdata(fields)

           (body, content_type) = encode_multipart_formdata(self.data)
       else:
           pass
           # TODO: Conflict?

"""

Now the urllib3's encode_multipart_formdata function supports the list of tuples. Could you please take in the latest urllib3 and then modify like this patch?
diff --git a/requests/models.py b/requests/models.py
index 8368c9f..ca7d0b2 100644
--- a/requests/models.py
+++ b/requests/models.py
@@ -404,11 +404,6 @@ class Request(object):
         if self.files:
             if not isinstance(self.data, str):

-                try:
-                    fields = self.data.copy()
-                except AttributeError:
-                    fields = dict(self.data)
-
                 for (k, v) in list(self.files.items()):
                     # support for explicit filename
                     if isinstance(v, (tuple, list)):
@@ -416,9 +411,9 @@ class Request(object):
                     else:
                         fn = guess_filename(v) or k
                         fp = v
-                    fields.update({k: (fn, fp.read())})
+                    self.data.append((k: (fn, fp.read())))

-                (body, content_type) = encode_multipart_formdata(fields)
+                (body, content_type) = encode_multipart_formdata(self.data)
             else:
                 pass
                 # TODO: Conflict?


Build the actual list of ranks to receive work from in dcp2

The list of ranks sending us work is not necessarily sequential, treating it as such leads to hung processes awaiting messages that will never be sent. This is especially prevalent as the number of ranks increases.

Thanks, Andrew!  Nice catch.


build failure micro-ros application on NuttX  with olimex-stm32-e407

Ubuntu20.04
foxy
olimex-stm32-e407
nuttx

following the tutorial:https://micro.ros.org/docs/tutorials/core/first_application_rtos/nuttx/
A small episode: at the configure step, the rcutils(in branch foxy) compile failure due to the dependence of tinydir_vendor, then I overwrite the rcutils with that in branch main, then the rcutils compile successed.
my question: the create_firmware, configure_firmware steps are successed, then the build step failed with the following message:
pong_server.cxx: In constructor 'PongServer::PongServer(int, char**)': /home/mazhg/microros_ws/firmware/apps/include/uros/ros_util.h:50:133: **error:** exception handling disabled, use '-fexceptions' to enable    50 | W_RET_OK) { throw RCLException(rcutils_get_error_string().str); } }
and the full operation are presented here:
https://asciinema.org/a/qbXwwH0VGAT1kEcAlqCYNTrQz
Thank you for your help!

The configure_firmware.sh is not working as expected, could you use the menuconfig utility to configure the application and transport?

thanks for your help, I will double check the step of configure_firmware.sh. For the menuconfig operation, yes, the configuration has been done.
Also, I will try the new micro-ROS build approach for nuttx, one problem for this tutorial, whether it works with foxy ?

I am afraid its not available on foxy.
We will rework the tutorial and the configure_firmware.sh script to avoid errors like this.

I recreate the firmware folder, then I rerun the configure_firmware.sh, while the following error message appeared:
`cd /home/username/micro_ws/firmware/apps/; colcon build --cmake-target clean --cmake-target-skip-unavailable
Starting >>> firmware
--- stderr: firmware
CMake Error: The source directory "/home/username/micro_ws/firmware/apps" does not appear to contain CMakeLists.txt.
Specify --help for usage, or press the help button on the CMake GUI.
Failed   <<< firmware [0.09s, exited with code 1]
Summary: 0 packages finished [0.24s]
1 package failed: firmware
1 package had stderr output: firmware`
according to the issues before, it seems that the ros2 distro is messing up with micro-ROS, any tips on this? Is there any way to solve the problem except reinstall the ros2 and micro-ROS? Thank you

I have a fix for the configuration problem, try again with the branch fix/ping_pong of this repository. That is:

Use  git clone -b fix/ping_pong https://github.com/micro-ROS/micro_ros_setup.git src/micro_ros_setup
Instead of git clone -b $ROS_DISTRO https://github.com/micro-ROS/micro_ros_setup.git src/micro_ros_setup

Also, I am working on the configuration steps of the tutorial, please the following instructions a try and give feedback:

Configuring the firmware
The configuration step will set up the main micro-ROS options and select the desired application.
It can be executed with the following command:
# Configure step
ros2 run micro_ros_setup configure_firmware.sh [APP] [OPTIONS]

In this tutorial, we will use a Serial transport and focus on the out-of-the-box uros_pingpong
application located here.
To execute this application with the chosen transport, run the configuration command above by specifying the [APP] parameter as below:
# Configure step with ping_pong app and serial-usb transport
ros2 run micro_ros_setup configure_firmware.sh pingpong

and with no [OPTIONS] parameter.
A pre-configured ethernet example is also available:
# Configure step with ping_pong app and serial-usb transport
ros2 run micro_ros_setup configure_firmware.sh pingpong-eth

To proceed with the configuration, clone the following NuttX tools repo:
# Download the tools necessary to work with NuttX
git clone https://bitbucket.org/nuttx/tools.git firmware/tools

and then install the required kconfig-frontends:
pushd firmware/tools/kconfig-frontends
./configure
make

# if the make command fails, type: autoreconf -f -i , and then rerun the make command.

sudo make install
sudo ldconfig
popd

Now we have two options to configure our micro-ROS transport:

Interactive NuttX menu config

Launch the configuration menu:
cd firmware/NuttX
make menuconfig

You can check that the application has been selected under Application Configuration ---> Examples ---> micro-ROS Ping Pong.

The transport is also pre-configured under the Application Configuration ---> micro-ROS ---> Transport option.

To configure the transport, use the IP address of the agent and Port number of the agent options for UDP and Serial port to use for the serial example.

To save the changes, navigate to the bottom menu with the left and right arrows, and click on the Save button.

You will be asked if you want to save your new .config configuration, and you need to click Ok, and then Exit.

Push three times the Esc key to close the menu and go back to microros_ws with:
cd ../..

kconfig-tweak console commands:

Go to Nuttx configuration path:
cd firmware/NuttX

UDP transport configuration:
kconfig-tweak --set-val CONFIG_UROS_AGENT_IP "<IP_ADDRESS>"
kconfig-tweak --set-val CONFIG_UROS_AGENT_PORT 8888

Serial transport configuration:
kconfig-tweak --set-val CONFIG_UROS_SERIAL_PORT "/dev/ttyS0"

The fix has been merged: https://github.com/micro-ROS/NuttX/pull/57.
And the tutorial has been updated: https://github.com/micro-ROS/micro-ROS.github.io/pull/359#pullrequestreview-844287577.
I am closing this, please give feedback and reopen if needed.

we have test the updated tutorials, the configure_firmware step failed due to  the dependence problem, the package rosidl_typesupport_microxrcedds_c_tests and  rosidl_typesupport_microxrcedds_cpp_tests  depends on the package rosidl_typesupport_microxrcedds_test_msg , while cmake could not find the rosidl_typesupport_microxrcedds_test_msg package with the following error message:
`--- stderr: rosidl_typesupport_microxrcedds_c_tests
CMake Error at CMakeLists.txt:26 (find_package):
By not providing "Findrosidl_typesupport_microxrcedds_test_msg.cmake" in
CMAKE_MODULE_PATH this project has asked CMake to find a package
configuration file provided by "rosidl_typesupport_microxrcedds_test_msg",
but CMake did not find one.
Could not find a package configuration file provided by
"rosidl_typesupport_microxrcedds_test_msg" with any of the following names:
rosidl_typesupport_microxrcedds_test_msgConfig.cmake
rosidl_typesupport_microxrcedds_test_msg-config.cmake
Add the installation prefix of "rosidl_typesupport_microxrcedds_test_msg"
to CMAKE_PREFIX_PATH or set "rosidl_typesupport_microxrcedds_test_msg_DIR"
to a directory containing one of the above files.  If
"rosidl_typesupport_microxrcedds_test_msg" provides a separate development
package or SDK, be sure it has been installed.
Failed   <<< rosidl_typesupport_microxrcedds_c_tests [1.58s, exited with code 1]`
when i colcon ignore the two package(rosidl_typesupport_microxrcedds_c_tests and  rosidl_typesupport_microxrcedds_cpp_tests ), everything goes fine, but no usb-NuttX serial device found.
with the nuttx.bin and nuttx.hex provided  by @pablogs9  in issue #268 , everything goes fine, and the topic goes well.
and the whole operation are recorded in the following link:
https://asciinema.org/a/460409
any help are grateful!

Update:
All the operation are executed successfully, while, there is no usb-NuttX serial appeared, as you can see:
https://asciinema.org/a/460890

This PR should solve the problem: https://github.com/micro-ROS/NuttX/pull/58

Appreciate, problem solved. We'll take a closer look at these modification, and I will close the issue.


Add "vanilla Forge" support

This PR fixes two issues when connecting to Forge servers. Both prevent a connection to the server. Neither of these prevent connection to a normal Minecraft server (tested with Paper).
The first issue is detailed in GeyserMC/Geyser#251 - Forge sends an identifier of "minecraft:", with nothing else afterwards. Feel free to be merciless with this code as it's definitely one of those "workarounds" rather than actually implementing.
The second refers to attributes - Forge adds three attributes to a "vanilla Forge" server: swim speed, nametag distance and entity gravity. This PR adds support for these as well.

Could you change the Forge-only comment on the attributed to a javadoc note for each one? Other than that, looks good.

I'm not super familiar with Javadoc, so please let me know if something needs to change.

I'll probably tweak the wording a bit, but looks good to me.


Document how to setup custom executor with the Geospatial Extension for KNIME Business Hub

Create a step by step guide referencing as much of existing documentation. Explain the difference between airgap and online installation.

I created a first draft. Please read through it and comment on all sections that don't make sense from the perspective of an less experienced user.
geospatial-install.md

There is an updated version available.
geospatial-install.md
We might need to talk about how to fix the embedding of images.

Great work. I can't see the image embedded in the markdown file. I would suggest give a bit more details on the last step. Maybe give a link about the steps about create the EC in KNIME Hub.

Thank you. Good point that you mention to link our docs for the last step; will include that as well.
I figured that the screenshots are not visible, since they don't live somewhere online. Maybe someone of you knows how to integrate those in the file?

You need host the screenshots somewhere so that you can just put the image URL in markdown file like ![](image_url.png). We can host the image in Github and then past the raw image URL in the markdown file, see here as an example.
I am wondering if we could include Python env and custom executor profiles setup here.

Hm, why exactly would you like to have conda envs and custom executor profiles described in this guide?
I have the feeling that this would be out of scope for just setting up the extension on an execution context.
Thank you for the example about the images for markdown files. Totally clear to me.
Since I haven't used git yet to push my guide, I suggest I will just zip the md + images and you can take care of placing it at the right spot in our repository!?

This is the most recent version.
geospatial-install-guide.zip

I will crate a branch in Github with the above attached file as source of truth. I will then let Daria double check the spelling etc.


Adding drone pipeline for testing

Adding the drone build file to start publishing our images in the rancher org.

You have duplicate step names which is causing the build to fail. See https://drone-publish.rancher.io/rancherlabs/support-tools/1

@dnoland1 I fixed the duplicate step.
Now it's currently erroring during the docker push which is pending https://github.com/rancherlabs/eio/issues/351 and https://github.com/rancherlabs/drone-publishing-setup/pull/57

@dnoland1 rancherlabs/eio#351 and rancherlabs/drone-publishing-setup#57 are done
The build is now failing because the docker hub creds are now open to PRs.
https://drone-publish.rancher.io/rancherlabs/support-tools/3/1/2

@mattmattox I believe if you add the following to the step, it will only run on merge and not for a PR:
  when:
    branch: master
    event:
      include:
      - push

See https://docs.drone.io/pipeline/docker/syntax/conditions/#by-event

@dnoland1 That worked and the build is now passing.

Looks like build was successful - https://drone-publish.rancher.io/rancherlabs/support-tools/4/1/2
Also verified that I can docker pull both rancher/bad-ingress-scanner and rancher/change-nodetemplate-owner


data to newtype with strict field

The code
data Boo = Boo { boo :: !(Maybe Int) }

triggers a suggestion to convert the code to
newtype Boo = Boo{boo :: (Maybe Int)}

which silently discards the strictness annotation.
This may be related to #285

Thanks, that makes sense.

I came here thinking I'd found a bug, but the explanation above makes sense. I'll add for posterity that attempting to add a strictness annotation to a newtype constructor does not type check (fails with A newtype constructor cannot have a strictness annotation, but 'Foo’ does), which makes sense, since newtypes are replaced at compile time with their inner type, rendering a strictness annotation meaningless.


TypeError: style.getCiteProc is not a function

Hello,
Thanks for this add-on ! I installed i(, but when trying to add a new document, this error message comes in :
"Failed to save item(s) to Notion.
TypeError: style.getCiteProc is not a function"
Do you have an idea of what the problem could be, and how to solve it ?
Thank you !

Hi @Jutdm, thanks for reporting!
To help me track down the issue, could you open the Error Console in Zotero from Tools > Developer > Error Console and then try to save items into Notion again. Could you send me a screenshot of whatever messages you see there?
Also, what version of Zotero are you using?

Thank you for your quick response !
I'm on Zotero 5.0.
Here is what is written :

Hi @Jutdm, sorry for the delay getting back to you.
Can you let me know what format you have selected in Zotero's Export settings? (See screenshot below for what I'm referring to.) I believe the error you're running in to is related to the export format.
Also, can you let me know what other add-ons you're using (if any)?
Thanks!

Hello @dvanoni,
Thank you for your response !
I use a French format, and no other add-on. Here is the name of the format :

Thank you,
Ju

@Jutdm thanks for this additional info! It's sounds like we're on the right track. I downloaded the format you're using to try to reproduce the error on my side, but I haven't been able to so far.
Would you mind downloading the latest version of the style to see if that helps at all? I wonder if there have been any fixes to it since you previously installed it. It looks like it was last updated in February.
To additionally help with debugging, would you mind running a snippet of JavaScript in Zotero and sending me the output? You can open the window from Tools > Developer > Run JavaScript (or the French equivalent 😄). Here's the code I'd like you to run:
let format = Zotero.Prefs.get('export.quickCopy.setting');
format = Zotero.QuickCopy.unserializeSetting(format);
Zotero.Styles.get(format.id);

It should output something like this:

Thanks!

Thanks @Jutdm! Unfortunately, I'm not seeing anything out of the ordinary in your screenshot. I was curious to see if getCiteProc was going to be returned as something unexpected, but as you can see, it appears to be a function just like in my screenshot...
I'm still digging in to this to see if I can figure out what's causing the issue. I'll keep you posted!
P.S. It looks like someone else has reported running in to the same error in the Zotero Forums.

@Jutdm would you mind doing me a favor and installing the test build posted above? It won't fix the issue, but it should enable some more error logging that will hopefully be visible from Tools > Developer > Error Console.
After installing the test build, could you open the Error Console and then try syncing items again to cause the error to occur? Then send me a screenshot of the error?
Thank you!

Hello !
I actually found a solution. I downloaded the "APA" format to show you the problem, and forgot to delete it after. I put the format "Presses Universitaires de Rennes" back as the default format, and the synchronization actually worked. If I delete APA, it doesn't, but I just have to keep it that way.
I guess this solution is good enough, but thank you very much for your implication in this process ahah !
I just have another little question. If it doesn't take too much time, could you do something for this little issue, please ?
When I add a new document, the title of the document is not added in the "Title" column. Instead, the quotation format of the name and date of the article is the title.
For example : (Goldbeter-Merinfeld, 2021)  is the title of the document below, and I would like it to be "Patrimoine, argent et conflits familiaux. Introduction" instead.

I would love to have it this way automatically :

I tried renaming the column "Title", but it doesn't work. I need to create an additionnal column called "Title", which is not the actual title of the document in the database. I don't know if I make sense here ahah.
Thank you very much !

Ah, I understand what's causing the issue now! Currently, the code assumes that the APA style is available and uses it to generate the name of the Notion page—the (author, year) text that you referred to. I hadn't considered that the APA style could be removed, so that was a bad assumption!
I think this issue is related to a couple others. Someone just mentioned in #14 that they'd also like to have the page name in Notion be the full article title, and others folks in #5 would like to use a different citation key as the page name. So, it sounds like the solution is to make this configurable and not assume that a specific style is installed.
@Jutdm thank you so much for debugging this with me, and I'm glad you were able to find a workaround!

Thank you very much for your work, this pluggin is soooo helpful !

I get the same error when connecting Zotero with Obsidian. I followed the above steps, but it keeps showing the same error.

@swwwwws, just to confirm, do you have the American Psychological Association 7th edition style installed in Zotero? If not, can you install it from https://www.zotero.org/styles/apa and let me know if you're still encountering the issue?

@dvanoni thanks for the quick reply. Yes I installed APA style in Zotero. It was installed and to be sure I installed it again with the .csl file, before I posted yesterday.

@swwwwws, I'm a bit stumped on this one. Would you mind sending me another screenshot of the Error Console? This time, could you open it and click the "Clear" button on the top right before triggering the error. Then once you've encountered the error, scroll to the bottom of the window (if necessary) to ensure you capture as much of the latest message as possible. Thanks!

@dvanoni This is the whole error log in the two pictures below. I cleared the log beforehand and then immediately triggered the error.

Thanks for the additional screenshots, @swwwwws. How are you triggering the error?

In Obsidian I us Command-P and select Zotero Better BibTex integration. Then the Zotero hovering search bar appears and I select a publication. After a short t time, I get the error in Obsidian.

I did some digging, but I'm unfamiliar with the specifics of Better BibTeX and Obsidian Zotero Integration. I'd suggest reaching out to the maintainers of those plugins to see if they can dig into this further.
I'm not sure if I'm on the right path, but I found a reference to a translator ID in the code of Obsidian Zotero Integration, and the location of that translator in Better BibTeX. You may be able to reference these when reaching out to those maintainers.

Thank you for your time and effort! I will bring it to the people who maintain it

Same as mentioned here by @Jutdm  https://github.com/dvanoni/notero/issues/12#issuecomment-994776511, I downloaded the APA style again and it worked, even if I already had a apa.csl in my Zotero styles folder.
Too bad I didn't copy it before updating to be able to compare both versions.
For me, the issue appeared through Obsidian Zotero Integration plugin. And contrary to what was mentioned here by @dufourc1  https://github.com/dvanoni/notero/issues/12#issuecomment-1489927978 I didn't have to create a citation format in Obsidian Zotero Integration plugin settings, updating apa.csl in Zotero styles folder solved it.

Thanks for sharing that thread, @nicolnt! I doubt the fix they mention will resolve the issue for Notero because Notero still relies on the APA style specifically, but I'm going to see if I can fix that by using a similar approach with a hard-coded format instead of APA.

Well, I don't know that I'm going to hear back from the Zotero developers on that thread. (I know they're very busy.)
I did some digging, and I think the code to use as a reference lives here.

I think I may have finally fixed this! 🤞 Version 0.6.2 no longer relies on the APA style being installed, so hopefully that resolves things.


update FileBox: to-json-str method

bump _private field to public property, so that the json string can get it.

Fixed by another commit. So close it.


Allow parenting of gravity cannons and shuttles to details

Improvements

Can now parent gravity cannons and shuttles to details

you either can or cannot parent due to the order.
I think it is more important to be able parent the cannon to a detail instead. Especially for something like a unity asset.

I feel like people might want to attach details to shuttles. Is there any better way we can do this stuff, maybe if a thing being parented cant find the parent it waits until everything else is done?

I'm saying no to this because putting a detail on a shuttle (and allowing that detail to fly off with the shuttle) seems more important than putting a shuttle on top of a detail.  I'd rather have us making a queuing system where the order of all props being made can be entirely shifted base on what wants to be parented to what. Probably anything that can't find its parent, we keep a list of all those and run another pass on those items and their builders.


Misleading message "Missing Inputstream addon" when it's disabled

Ideally, this would distinguish between missing and disabled. This would make it easier on users to set this up the first time, since in current Kodi nightly the Inputstream addon is installed but disabled.
One way this could be done is to modify KodiHelper.get_inputstream_addon() to return a tuple (url, enabled), and then add an additional error message in KodiHelper.play_item. If this sounds reasonable, I can throw together a PR.
Let me know!

Did you find out where to enable this setting?
Or did you have to install it seperately?

@zombielinux Yes, you can enable the addon using the normal addon information/configuration page. It should come pre-installed on Kodi nightlies.

Sounds good to me. So feel free to make a PR!


Added HTML code to application

This PR adds all the HTML needed for prework study guide application.

thats its great!!!


feat(extractor): support source locale option

I've added the ability to pass in the source locale. I haven't done checking previous file yet. Could come in another PR perhaps? @ocombe
Close #15

Updated readme


Release v1.0.0

Hi,
We are happy to announce the release version 1.0.0.
A basic JSON-RPC implementation for your Flask-powered sites.
Some reasons you might want to use:

Simple, powerful, flexible and pythonic API.
Support JSON-RPC 2.0 version.
Support python 3.6 or later.
The web browsable API.
Run-time type checking functions defined with PEP 484 argument (and return) type annotations.
Extensive documentation, and great community support.

Thank you.

Coverage increased (+15.2%) to 100.0% when pulling a1787eac3c3b60a25d4f48737582c9856cd3fef9 on release/v1.0.0 into 5e294ebab551db08a2a0498351b4dd75eb1de3c1 on master.


Differences in rendering between emulator r48 and hardware

I'm working on converting a demo to the CX16. The CX16 is the first 8-bit computer I've seen capable of handling the requirements: fast enough at 8 MHz, and has screen swapping, extended memory, and a multiplier. So far I've just been developing on the emulator r48. I asked on cx16forum and discord if anyone could test on real hardware, and both noted differences between between the emulator and the hardware.
The demo consists of EXPLORE.PRG and EXPLORE.DAT with files available on Google Drive https://drive.google.com/drive/folders/1unw3MgF0ji-n1Vk2guOfw-t5dZ-2rEtD?usp=sharing. If you're leery of downloading from online, and you want to build it yourself, the GitHub repo is here https://github.com/Russell-S-Harper/EXPLORE.
This is a sample recording of it running on the emulator r48: https://youtube.com/watch?v=nCTF3v2hGFo, although the playback is a bit slower than what I get running it on the emulator.
This is a screen recording of the demo on current hardware: https://www.youtube.com/watch?v=erGsoavHXio, you can see the lines are shifting randomly, sometimes correct, usually not.
The long lines (a.k.a. walls) are calculated in real time, while the vehicles and missiles are pre-calculated, but both have random rendering issues. A lot of data is in extended memory, but if it were being corrupted, would expect the output to be a complete mess. The vehicles and missiles use single bytes to define point offsets, so it's likely not a byte endian issue.
Maybe it's a VERA discrepancy? The configuration is 4-bit (16-color) mode, dual screens at offsets 0x0000 and 0x9800. The VERA line helper is used as well as the multiplier. The multiplier is set to output in unused space between the screens at 0x9600. No interrupts are used, everything is done in one thread with all VERA functions self-contained, so no "clobbering" of VERA registers.
I can try to generate a minimal example to demonstrate, but with new hardware not yet available, I'm relying on the good will of others to test on theirs, so this might be difficult.

Confirmed by "MooingLemur" and others in Discord CX16 #general and #video that the issue likely arises within VERA. The emulators r47 and r48 are behaving correctly. Closing as not an issue with the emulator.


Fix: Adds rule to avoid overflowing logo in maintenance mode

Questions
Answers

Description?
In maintenance mode, big logo will overflow their container because the image doesn't have a maximum width.

Type?
bug fix

Fixed ticket?
Fixes #30625

BC breaks?
no

Deprecations?
no

How to test?
Upload a wide logo, then activate the maintenance mode. Go to the store and see if the logo is overflowing it's container or not.

Possible impacts?
I don't see any.

Before:

After:

Hi @amaury-hanser thank you for the PR. Do you think you could submit a bug report and link it to this PR?

Done, I've edited the description of the PR, thans for the tips!

Message for QA, remember that classic-theme repository is only for PrestaShop 8. No need to test any other version.

Thanks @amaury-hanser 💪


Unable to select alternative calendars in dropdown

Thanks, great extension, very helpful. Seems I can only add items to my primary calendar, though. I have to open the event then move it... bit of a pain.
System Information:

Version: 1.5.3
Language: en-GB
Timezone Offset: +11:00
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/39.0.2171.99 Safari/537.36

What steps will reproduce the problem?

Right click > Add to Google Calendar
In Create Event window, click 'Calendar' dropdown

What is the expected result?
See my calendars so I can choose a different one for event to be added to
What happens instead?
Only my primary calendar is shown.
Screenshot URL:

Sorry about that, seems like #107 which the Calendar team has refused to add. I may work around this in the future, but unfortunately there's nothing I can do in the meanwhile.


Expand Livecheck#preprocess_url tests

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew tests with your changes locally?
[x] Have you successfully run brew man locally and committed any changes?

The existing test for Livecheck#preprocess_url didn't exercise all the existing functionality of this method. This PR expands the test cases to cover the current usage of this method. However, the test cases will need to be expanded again with respect to #9074, as it adds support for additional URL types. We can handle it here, in #9074, or in a follow-up PR, whichever makes the most sense.
The main impetus behind this PR was that #9074 refactors the #preprocess_url method and it originally didn't replicate all of the existing functionality but the issues weren't surfaced by CI. I identified the issues myself but this test should have made this readily apparent. The updated test here clearly points out these issues when run on that PR's original code, so I think it's a good improvement.

Thanks @samford!


MSID: 96854 Version: 2 DOI: 10.1101/2<IP_ADDRESS>1847

MSID: 96854
Version: 2
Preprint DOI: https://doi.org/10.1101/2<IP_ADDRESS>1847
Step 1. Awaiting reviews
Editorial to post reviews via hypothesis
Useful links:

DocMap: https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=96854
New model tracking: https://docs.google.com/spreadsheets/d/1_fHaoOy7hjyocptKtVJRijeNpUY4hBS7Ck_aVmx6ZJk/
Reviews on sciety: https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>1847

For trouble shooting (e.g. no Docmaps available):

DocMap issue addressing: https://miro.com/app/board/uXjVNCwK6EI=/
Explore DataHub DocMaps API: https://lookerstudio.google.com/reporting/4c2f0368-babb-4beb-b5b3-497e7e7b0f08/page/ejphD
Unmatched submissions and preprints: https://lookerstudio.google.com/u/0/reporting/9f86204f-3bf7-477c-9b18-5c5ef141bf69/page/p_gxi57ha93c
Unmatched manuscripts spreadsheet: https://docs.google.com/spreadsheets/d/15QcK8w-ssB7109RQEDtFpJPZ0J5HTGxoHa_2TtpMBbg/edit#gid=1336081641

Step 2. Preview reviewed preprint
Production QC content ahead of publication
Instructions:

QC preview: https://prod--epp.elifesciences.org/previews/96854v2
Update ticket with any problems (add blocked label)
When QC OK, add QC OK label to ticket and add publication date and time to https://docs.google.com/spreadsheets/d/1amAlKvdLcaDp5W8Z8g77NmkwbMF5n_u89ArSqPMO8jg
Move card to next column
(At end of the day post link in #enhanced-preprint and ask for PDF to be generated)

Useful links:

Preprint DOI :  https://doi.org/10.1101/2<IP_ADDRESS>1847
Confirm reviews returned by EPP: https://prod--epp.elifesciences.org/api/reviewed-preprints/96854/v2/reviews
To update the MECA path in the docmap: https://docs.google.com/spreadsheets/d/1mctCQuNFBjSn97Lihy7_vBO6z7-N-oqyLv4clyi6zHg

Step 3: Awaiting search reindex
This step adds the reviewed preprint to the homepage: https://elifesciences.org
The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.
Useful links:

Jenkins pipeline to reindex search can be triggered sooner or monitored here: https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 4: Published! PDF requested
Waiting for PDF to be generated
Useful links:

PDF tracking: https://docs.google.com/spreadsheets/d/106_XeDjmuBae7gexOTNzg60lapeqjl2aRn9DzupGyS8/

Step 5: Introduce PDF to data folder and git repo
Upload PDF to relevent folder in git repo https://github.com/elifesciences/enhanced-preprints-data/
Step 6: Done!

[ ] Kettle is on!

warn: [journal-ref-text-content] This journal reference (id c57) has untagged textual content - , ENEURO.0149-19.2019 (. Is it tagged correctly?
warn: [journal-ref-text-content] This journal reference (id c72) has untagged textual content - , ENEURO.0400-19.2020 (. Is it tagged correctly?
warn: [journal-ref-text-content] This journal reference (id c73) has untagged textual content - , ENEURO.0266-20.2020 (. Is it tagged correctly?
warn: [journal-ref-text-content] This journal reference (id c74) has untagged textual content - , ENEURO.0055-22.2022 (. Is it tagged correctly?
warn: [mixed-citation-other-publication-flag] mixed-citation in reference (id=c17) has a publication-type='other'. Is that correct?
warn: [mixed-citation-other-publication-flag] mixed-citation in reference (id=c42) has a publication-type='other'. Is that correct?
warn: [mixed-citation-other-publication-flag] mixed-citation in reference (id=c44) has a publication-type='other'. Is that correct?
warn: [mixed-citation-other-publication-flag] mixed-citation in reference (id=c48) has a publication-type='other'. Is that correct?


fix: #117 ignores coinstake output when calculating witness merkle root

The witness commitment is calculated when a new block template is created before the coin stake is added. This can cause the witness merkle root hash to be different when later checked in a completely constructed block broadcasted to the network. This patch takes in consideration if the coin stake should be ignored, preventing the last leaf of the tree to be an empty hash.

 Witness Merkle Root with Fund Enabled


Number of supported satellites?

Hey! Love the project, thank you so much!
How many satellites can I track at one time? I added more to the tracker_main config, but when I go to compile it I get this error:
tracker_main:14:123: error: too many initializers for 'char [4][30]'
 char satnames[4][30] = {"MARS 2020","NEOSSAT","VANGUARD 1","SCISAT","TIROS N","AURA","GRACE-FO 1","GRACE-FO 2","HST","ISS"};// Names of satellites.
                                                                                ^
tracker_main:15:320: error: too many initializers for 'char [4][30]'
 char satURL[4][30] = {"satcat/tle.php?CATNR=45983","/satcat/tle.php?CATNR=39089","satcat/tle.php?CATNR=00005","/satcat/tle.php?CATNR=27858","/satcat/tle.php?CATNR=11060","/satcat/tle.php?CATNR=28376","/satcat/tle.php?CATNR=43476","/satcat/tle.php?CATNR=43477","/satcat/tle.php?CATNR=20580","/satcat/tle.php?CATNR=25544"}; // URL of Celestrak TLEs for satellites (In same order as names).

exit status 1
too many initializers for 'char [4][30]

I tried replacing all instances of [4] with [10], which is how many satellites I'm tracking. It compiled without errors, but then after uploading it the MKR1000 fails to initialize and I don't get anything on my serial monitor.
Any help would be appreciated!
Thanks,
Ted

Never mind! I seem to have fixed my own problem.
I believe I'm on the right track with correcting the instances of [4] to [x] where x is the number of satellites I'm tracking. But it turns out that I was connecting to my serial port too late and missing the Prediction error message. It seems I was mistakenly trying to track satellites that no longer report their current position (such as VANGUARD-1), which threw off the application.
I'm now tracking 8 in-service satellites with no problems.
Thanks!
Ted


[BUG] Decoding only manifest without remaining resources corrupts APK wrt signing

Information

Apktool Version (apktool -version) - 2.9.0
Operating System (Mac, Linux, Windows) - Windows
APK From? (Playstore, ROM, Other) - FDroid
Java Version (java --version) - 15.0.2

Steps to Reproduce
$ java -jar ~/Downloads/apktool_2.9.0.jar d -r --force-manifest com.zola.bmi.apk -f
I: Using Apktool 2.9.0 on com.zola.bmi.apk
I: Copying raw resources...
I: Decoding AndroidManifest.xml with resources...
I: Loading resource table from file: C:\Users\Michael\AppData\Local\apktool\framework\1.apk
I: Sparsely packed resources detected.
W: Could not decode attr value, using undecoded value instead: ns=android, name=theme, value=0x7f0d0005
W: Could not decode attr value, using undecoded value instead: ns=android, name=label, value=0x7f0c0029
W: Could not decode attr value, using undecoded value instead: ns=android, name=icon, value=0x7f070054
W: Could not decode attr value, using undecoded value instead: ns=android, name=label, value=0x7f0c0029
I: Regular manifest package...
I: Baksmaling classes.dex...
I: Copying assets and libs...
I: Copying unknown files...
I: Copying original files...

$ cat AndroidManifest.xml
<?xml version="1.0" encoding="utf-8" standalone="no"?><manifest xmlns:android="http://schemas.android.com/apk/res/android" android:compileSdkVersion="28" android:compileSdkVersionCodename="9" package="com.zola.bmi" platformBuildVersionCode="400" platformBuildVersionName="4.0.0">
    <application android:allowBackup="true" android:appComponentFactory="android.support.v4.app.CoreComponentFactory" android:icon="@2131165268" android:label="@2131492905" android:theme="@2131558405">
        <activity android:label="@2131492905" android:name="com.zola.bmi.BMIMain">
            <intent-filter>
                <action android:name="android.intent.action.MAIN"/>
                <category android:name="android.intent.category.LAUNCHER"/>
            </intent-filter>
        </activity>
    </application>
</manifest>

$ java -jar ~/Downloads/apktool_2.9.0.jar b
I: Using Apktool 2.9.0
I: Checking whether sources has changed...
I: Smaling smali folder into classes.dex...
I: Checking whether resources has changed...
I: Copying raw resources...
I: Building apk file...
I: Copying unknown files/dir...
I: Built apk into: .\dist\com.zola.bmi.apk

$ signAPK dist/com.zola.bmi.apk
Exception in thread "main" com.android.apksig.apk.MinSdkVersionException: Failed to determine APK's minimum supported platform version. Use --min-sdk-version to override
        at com.android.apksigner.ApkSignerTool.sign(ApkSignerTool.java:350)
        at com.android.apksigner.ApkSignerTool.main(ApkSignerTool.java:84)
Caused by: com.android.apksig.apk.MinSdkVersionException: Unable to determine APK's minimum supported Android platform version: malformed binary resource: AndroidManifest.xml
        at com.android.apksig.apk.ApkUtils.getMinSdkVersionFromBinaryAndroidManifest(ApkUtils.java:387)
        at com.android.apksig.ApkSigner.getMinSdkVersionFromApk(ApkSigner.java:912)
        at com.android.apksig.ApkSigner.sign(ApkSigner.java:271)
        at com.android.apksig.ApkSigner.sign(ApkSigner.java:207)
        at com.android.apksigner.ApkSignerTool.sign(ApkSignerTool.java:344)
        ... 1 more
Caused by: com.android.apksig.internal.apk.AndroidBinXmlParser$XmlParserException: No XML chunk in file
        at com.android.apksig.internal.apk.AndroidBinXmlParser.<init>(AndroidBinXmlParser.java:101)
        at com.android.apksig.apk.ApkUtils.getMinSdkVersionFromBinaryAndroidManifest(ApkUtils.java:348)
        ... 5 more
rm: cannot remove 'dist/com.zola.bmi.apk.idsig': No such file or directory

Frameworks
If this APK is from an OEM ROM (Samsung, HTC, LG). Please attach framework files
(.apks that live in /system/framework or /system/priv-app)
APK
If this APK can be freely shared, please upload/attach a link to it.
https://github.com/iBotPeaches/Apktool/files/12774551/com.zola.bmi.apk.zip
Questions to ask before submission

Have you tried apktool d, apktool b without changing anything? YES
If you are trying to install a modified apk, did you resign it? YES
Are you using the latest apktool version? YES

I am not even sure if this is a real bug since decoding only the manifest succeeded as above output showed? Btw, I did not try the suggested option by apksigner to overwrite the min sdk version manually.

I don't think a bug here. If you force manifest decoding (ie you don't decode resources.arsc) we cannot resolve those references.
How it actually built is the odd thing. I'll investigate that and either look towards a doc change or making this actually fail during compilation with a forced manifest.

This is so interesting to me that we built an obviously invalid Manifest and aapt2 was fine with it. My guess is all the protections we've ripped out over the years to lessen the strictness of the build has caught up to us.
For example, once its built (without an error). Its clearly invalid.
➜  3389 aapt2 d xmltree com.zola.bmi/dist/com.zola.bmi.apk --file AndroidManifest.xml
ResourceType W 10-10 06:36:21<PHONE_NUMBER>21] Bad XML block: header size 28024 or total size<PHONE_NUMBER> is larger than data size 816

com.zola.bmi/dist/com.zola.bmi.apk: error: failed to parse binary AndroidManifest.xml: failed to initialize ResXMLTree.
➜  3389

Not sure what I want to do here yet.

Building an application after a forced manifest decode paired with no resources just simply shouldn't be allowed.
An assembly of an invalid manifest should be rejected during aapt2 build/link


V2 Funding history tab

What does this PR do and why?
Provide a description of what this PR does. Link to any relevant GitHub issues,
Notion tasks or Discord discussions.
Screenshots or screen recordings
If applicable, provide screenshots or screen recordings to demonstrate the
changes.
Acceptance checklist

[ ] I have evaluated the Approval Guidelines for this PR.
[ ] I have tested this PR in all supported browsers.

All comments and bugs you've mentioned here are fixed. Confident in this now


Enable RPM installs in air-gapped envs via custom yum repos (#89)

Enable RPM installs in air-gapped environments via custom yum repos and explicit specification of the desired install_rke2_version (#89)
What type of PR is this?
(REQUIRED)

[ ] bug
[ ] cleanup
[ ] documentation
[x] feature

What this PR does / why we need it:
(REQUIRED)
According to feedback from issue https://github.com/rancherfederal/rke2-ansible/issues/86, both RKE2 and rke2-ansible do not support Tarball installs with SELinux enforcing. Furthermore, rke2-ansible today only supports Tarball installs for Air-Gapped environments. So, this PR introduces support for RPM installs with SELinux enforcing in Air-Gapped environments. This is achieved by delivering the following features:

the rke2 common and rke2 versioned yum repo definitions can be overridden to reference local repos presumably created in the airgapped environment using the yum reposync and createrepo utilities
allow explicit specification of the install_rke2_version to eliminate a hard dependency on the RKE2 Update service available at internet url: https://update.rke2.io

Which issue(s) this PR fixes:
(REQUIRED)
Fixes #89
Special notes for your reviewer:
Testing

Tested using defaults while connected to the internet

Tested in air-gapped environment with two CentOS 7 hosts, Ansible local server ip-10-11-12-13 and Apache HTTPD server ip-9-11-12-13. The Ansible local server runs ansible and is also the rke2_server target. The Apache HTTPD server hosts rke2-common and rke2-v1.21 yum repos. These repos were extracted from a tar archive transferred from an internet-connected machine. The tar archive was created on the internet-connected machine by archiving a directory created by the yum reposync and createrepo tools.

The air-gapped inventory files were defined as follows:
mkdir -p rke2-ansible/inventory/my-cluster/group_vars
cd rke2-ansible

cat <<EOF > inventory/my-cluster/hosts.ini
[rke2_servers]
ip-10-11-12-13 ipv4addr=<IP_ADDRESS>

[rke2_agents]

[rke2_cluster:children]
rke2_servers
rke2_agents
EOF

cat <<EOF > inventory/my-cluster/group_vars/rke2_servers.yml
---
rke2_config:
  selinux: true
EOF

cat <<EOF > inventory/my-cluster/group_vars/rke2_agents.yml
---
rke2_config:
  selinux: true
EOF

cat <<EOF > inventory/my-cluster/group_vars/all.yml
---
install_rke2_version: "v1.21.5+rke2r1"

rke2_common_yum_repo:
  name: "rke2-common"
  description: "Rancher RKE2 Common Latest"
  baseurl: "http://ip-9-11-12-13:8080/mrepo/rancher/rke2/latest/common/centos/$releasever/noarch"
  gpgcheck: false
  gpgkey: "https://rpm.rancher.io/public.key"
  enabled: yes

rke2_versioned_yum_repo:
  name: "rke2-v{{ rke2_version_majmin }}"  # noqa var-spacing"
  description: "Rancher RKE2 Version"
  baseurl: "http://ip-9-11-12-13:8080/mrepo/rancher/rke2/latest/{{ rke2_version_majmin }}/centos/$releasever/$basearch"
  gpgcheck: false
  gpgkey: "https://rpm.rancher.io/public.key"
  enabled: yes
EOF

Ansible was invoked using the following command:
ansible-playbook site.yml -i ./inventory/my-cluster/hosts.ini -c local

Release Notes
(REQUIRED)
Enable RPM installs in air-gapped environments via custom yum repos and explicit specification of the desired install_rke2_version (#89)

@dgvigil Are you able to feedback regarding this PR? We are successfully using a fork of this repo with this PR at the moment. Of course, we do not want to maintain this fork long-term. Thanks.


866 MenuBar Re-design Changes

Fix #866
Test URLs:

Before: https://main--danaher-ls-aem--hlxsites.hlx.page/
After: https://866-rebrand-menu-bar-design--danaher-ls-aem--hlxsites.hlx.page/

HI @amlan18041996 ,
Could you please check below issue?. It loads incorrect menu on initial click.
Steps to reproduce:

Open home page from branch
Scroll down for hamburger icon in menu
Click on hamburger icon
You will below screen shot

https://866-rebrand-menu-bar-design--danaher-ls-aem--hlxsites.hlx.page/

@rgravitvl  and @amlan18041996  - this looks like it is fixed now?  @rgravitvl  - are you happy to approve?


HBASE-27529 Attach WAL extended attributes to mutations at replication sink

HBase provides coproc ability to enhance WALKey attributes (a.k.a. WAL annotations) in order for the replication sink cluster to build required metadata with the mutations. The endpoint is preWALAppend(). This ability was provided by HBASE-22622. The map of extended attributes is optional and hence not directly used by hbase internally.
For any hbase downstreamers to build CDC (Change Data Capture) like functionality, it might required additional metadata in addition to the ones being used by hbase already (replication scope, list of cluster ids, seq id, table name, region id etc). For instance, Phoenix uses many additional attributes like tenant id, schema name, table type etc.
We already have this extended map of attributes available in WAL protobuf, to provide us the capability to (de)serialize it. While creating new ReplicateWALEntryRequest from the list of WAL entires, we are able to serialize the additional attributes. Similarly, at the replication sink side, the deserialized WALEntry has the extended attributes available.
At the sink cluster, we should be able to attach the deserialized extended attributes to the newly generated mutations so that the peer cluster can utilize the mutation attributes to re-build required metadata.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 39s
Docker mode activated.

Let's get back to this.
For me, I do not think adding WAL attributes to mutation directly is the correct way to deal with this. Even introducing a flag seems weird,
Maybe we could add coprocessor support or add new type of filter for ReplicationSink, so Phoenix could add the special logic by your own, i.e, adding the WAL attributes to mutation.
Thanks.

I think introducing a default conversion from WAL entry attribute to mutation attribute would sufficient

This is exactly what the purpose of this patch was initially.

What I would not like to see here is a new config. It is quite use case specific and the accumulation of these makes problems due to configuration errors all the more likely.

I agree here and that's why I kept the initial version without including any configs.

but to @Apache9 's point, a symmetric flow here would have a pair of coprocessors involved: the first transforming attribute to metadata at the source client, the latter transforming metadata to attribute at the sink client.

Yeah this also doesn't seem bad idea @Apache9.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 37s
Docker mode activated.

Be lated +1.
Thanks @virajjasani !


Fix typo in new-feature-tutorial.md

Fixed a small typo in docs. Changed (Line 37) zerver/model.py to zerver/models.py

Merged, nice catch. Thanks @vinitS101!


fix cration of the genesis block

Problem
Node Id 0 was generating the genesis block and propagating it to the surrounding nodes. This creates a bias among nodes.
Solution
All nodes receive the genesis block when the simulation starts.

unsubscribe
On Mon, Jul 1, 2024 at 4:57 PM Tsuyoshi Hasegawa @.***>
wrote:

Closed #32 https://github.com/dsg-titech/simblock/pull/32.
—
Reply to this email directly, view it on GitHub
https://github.com/dsg-titech/simblock/pull/32#event-13347799605, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAIOIWXSL2RYLTT4Q4S2GTZKEKZPAVCNFSM6AAAAABJ3FGL72VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGM2DONZZHE3DANI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Annoying deprecation warnings

What exactly causes these deprecation warnings to come up?
Is it possible to get rid of them?
$ node -v
v7.1.0

$ jumpsuit build
     _                       _ _
    |_|_ _ _____ ___ ___ _ _|_| |_
    | | | |     | . |_ -| | | |  _|
   _| |___|_|_|_|  _|___|___|_|_|
  |___|         |_|

▸   building...

(node:19656) DeprecationWarning: Using Buffer without `new` will soon stop working.
Use `new Buffer()`, or preferably `Buffer.from()`,
`Buffer.allocUnsafe()` or `Buffer.alloc()` instead.

(node:19656) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1):
Invariant Violation:
Minified React error #46; visit http://facebook.github.io/react/docs/error-decoder.html?invariant=46 for the
full message or use the non-minified dev environment for full errors and additional helpful warnings.

(node:19656) DeprecationWarning: Unhandled promise rejections are deprecated.
In the future, promise rejections that are not handled will terminate the Node.js process
with a non-zero exit code.
✓ (13822ms)

This is a node 7 specific warning. We will look into it.

The jumpsuit-cli is soon to be deprecated in favor of<EMAIL_ADDRESS>Closing for now :)


0.50.0-rc1: release note candidate OPTIONS calls now authenticated

Describe the bug
In 0.40.x, OPTIONS calls were not authenticated, now they are. This may cause issues depending on how the authentication service was built.
To Reproduce
Configure authentication in Ambassador. Make an OPTIONS call. Notice that it requires authentication.
Expected behavior
Since this is a change in behavior, expect this to be called out in the release notes.
Versions (please complete the following information):

Ambassador: 0.50.0-rc1
Kubernetes environment kops
Version 1.11.5

Additional context
Add any other context about the problem here.

Fixed in b8ce34f5f03c8cf77e5bfb868661f502cc52f7af.


PM owner when a new update is released

Maybe add a setting for the bot to check for updates periodically and then pm the owner when a new update is released so they can update it.

In my opinion, this seems a bit unnecessary. Just join the support server and do %roleme Music Updates to receive MusicBot updates.

I wasn't aware we could do that so thank you. I still think this would be a cool feature for people who don't want to clutter up their server lists. And should be relatively easy to add.

This has been added to the suggested features list


Make sure rune transactions preserve rare sats

and🦋
😅

We don't actually do this for other transaction types, so not adding a test for this here.


simple tf.vectorized_map raises error UnrecognizedFlagError: Unknown command line flag 'f'

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Google Colab
TensorFlow installed from (source or binary): Default Colab
TensorFlow version (use command below): 2.2.0
Python version: 3.6.9
CUDA/cuDNN version: N/A tested on CPU
GPU model and memory: N/A tested on CPU

Describe the current behavior
import tensorflow as tf

print(tf.vectorized_map(
    lambda seq: tf.reduce_min(tf.where(seq)),
    tf.constant([[False, True],
                 [True, False]])
))

Outputs the following error:
UnrecognizedFlagError: Unknown command line flag 'f'

I've seen this error quite often when using tf.vectorized_map, in very different settings. However, this is the simplest cast I've found so far. So I suspect the error is not limited to tf.where().
Describe the expected behavior
I would expect the output to be:
tf.constant([1, 0], dtype=tf.dtypes.bool)

Standalone code to reproduce the issue
https://colab.research.google.com/gist/AndreasMadsen/9ee1fa1669aa7c656070ca5a850d7210/vectorized-map-bug.ipynb
Other info / logs
StagingError: in user code:

    /usr/local/lib/python3.6/dist-packages/tensorflow/python/ops/parallel_for/control_flow_ops.py:183 f  *
        return _pfor_impl(loop_fn, iters, parallel_iterations=parallel_iterations)
    /usr/local/lib/python3.6/dist-packages/tensorflow/python/ops/parallel_for/control_flow_ops.py:269 _pfor_impl  **
        outputs.append(converter.convert(loop_fn_output))
    /usr/local/lib/python3.6/dist-packages/tensorflow/python/ops/parallel_for/pfor.py:1284 convert
        output = self._convert_helper(y)
    /usr/local/lib/python3.6/dist-packages/tensorflow/python/ops/parallel_for/pfor.py:1457 _convert_helper
        if flags.FLAGS.op_conversion_fallback_to_while_loop:
    /usr/local/lib/python3.6/dist-packages/tensorflow/python/platform/flags.py:85 __getattr__
        wrapped(_sys.argv)
    /usr/local/lib/python3.6/dist-packages/absl/flags/_flagvalues.py:633 __call__
        name, value, suggestions=suggestions)

    UnrecognizedFlagError: Unknown command line flag 'f'

@AndreasMadsen
Can you try with TF nightly version (2.3.0-dev20200608) and see if the issue still persists.I am not seeing any issue with nightly version.Please, find the gist here. You could use tf-nightly for now and in the next couple of months new stable version will be released.Please,verify once and close the issue.Thanks!

I can confirm it works on nightly. I was looking through the commits and I think https://github.com/tensorflow/tensorflow/commit/867673d63b6ee56229498176fc3a00235b8eb2cf#diff-081213481ade84ce14e9afaa3f3505b9L283 fixed it. Although, I think it hides an underlying bug with the flags API, when used with Colab.
The code
import sys
print(sys.argv)

Outputs ['/usr/local/lib/python3.6/dist-packages/ipykernel_launcher.py',  '-f',  '/root/.local/share/jupyter/runtime/kernel-d86e104c-d0a6-40e7-9533-ce825b3cb03d.json']. Which causes the flag parser to fail. Because it doesn't understand the -f flag.
The error can be reproduced with:
from absl import flags
flags.FLAGS(sys.argv)

I don't know if this is an issue with

absl for not supporting Colab
or TensorFlow to not instructing absl on how to handle -f
or Colab for passing in the -f flag.

@AndreasMadsen
Please, close the issue as the original issue was resolved. Request you to raise a new issue with flags API by filling issue template.Thanks!

I submitted an issue here: https://github.com/googlecolab/colabtools/issues/1323

FWIW, I do think there's a deeper TF-side issue here: a library shouldn't be parsing sys.argv, since it has no control over the program that invoked it. A simple fix might be allowing unknown flags when parsing sys.argv.
That said, for this particular issue, it looks like the code in question is gone, so mostly leaving this comment as a breadcrumb for posterity.

Seems like this is the workaround for at least TF2.2.0: https://github.com/google-research/bleurt/issues/4#issuecomment-635118502


photo poster into the telegram bot

i've added the photo poster method; can you review it? I'll add the url card method in another PR then


Selecting features for model - dropping some?

Hey guys I decided to drop the very unique variables such as ticket number, name, and passenger ID I think they're to unique and would cause overfitting also if we were ever to predict with this model it might not be wise to use these - might not translate to other boating accidents "Sandstrom, Miss. Marguerite Rut" is probably not on any other boats...

My latest PR reflects what I did in the Selecting Features block of text

I agree - unique identifiers are not helpful and give no/little explanatory power.

I agree with dropping the unique identifiers. Other columns which are selected to fine to me.

I concur with the decision to drop the unique identifiers. Additionally, the other selected columns seem appropriate to me.

Awesome lets leave it as it is then!


bowtie2 alignment genome and index config in bulk-pipeline.sh

On lines 52 and 58 of bulk-pipeline.sh, the index file for bowtie2 alignment is specified as -x $bt2idx/genome.
This causes alignment to fail, because there is no index file with the prefix genome. I'm using the mm10 reference genome, and the prefix should be -x $bt2idx/mm10. Should genome be a variable that comes from the config file instead?

$bt2idx/genome
should be changed to:
$bt2idx
You can echo $bt2idx to find out what is $bt2idx

'genome' is not a variable from config.
This is dependent on your reference genome and index, if you follow the instruction to download and install the reference genome, all the genomes of different species and versions should be called 'genome'. But if you use your own genome files, you need to revise the code, for example, change 'genome' -> 'mm10' in your case.
Hope this helps.

Hi, thanks both for your responses. I'm not sure this bug should have been closed, it's a real bug for people who are not using the downloaded reference genomes. To get it to work, I did something similar to what @fentouxungui suggested.


What is the current production version?

The phantomjs website links to 2.1.3 for Linux. The github relases page however lists 2.1.3 not suitable for production. What's the current recommend version to run (considering 2.1.1 is EOL soon)?

Use 2.1.1, any other plan is now abandoned, see #15344.


Outlook September updates

link to req. set 1.7

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/add-ins/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


operator should be able to delete / override old CSR

Describe the bug
To avoid issues like https://github.com/cloudfoundry-incubator/kubecf/issues/877, it will be nice if operator could delete / override old CSR. According to @viovanov, operator has such feature but maybe its not functioning correctly.
To Reproduce
Deploy kubecf with eirini enabled on a cluster with old bits-CSR
Expected behavior
https://github.com/cloudfoundry-incubator/kubecf/issues/877,
Environment
cf-operator-4.5.6+0.gffc6f942
Additional context
Add any other context about the problem here.

Hi @prabalsharma , Thank you for reporting the issue. The issue should be resolved with #962 . The feature was already implemented in cf-operator, but the right permissions were missing for the cf-operator role.


Compile failures

First off, welcome to Hackage!
Your package caught my attention because it was flagged by Hackage's experimental CI system, specifically it failed with
Configuring component lib from Villefort-<IP_ADDRESS>...
Preprocessing library Villefort-<IP_ADDRESS>...

src/Database.hs:4:8:
    Could not find module ‘Control.Monad.IO.Class’
    It is a member of the hidden package ‘transformers-<IP_ADDRESS>@CBZP4azR07y8fwUbBRPPsd’.
    Perhaps you need to add ‘transformers’ to the build-depends in your .cabal file.
    It is a member of the hidden package ‘transformers-<IP_ADDRESS>@trans_GZTjP9K5WFq01xC9BAGQpF’.
    Perhaps you need to add ‘transformers’ to the build-depends in your .cabal file.
    Use -v to see a list of the files searched for.
cabal: Failed to build Villefort-<IP_ADDRESS> (which is required by exe:Villefort
from Villefort-<IP_ADDRESS>).

This is because Control.Monad.IO.Class became part of base only starting with base-4.9; however your .cabal file claims compatibility with base >= 4.7 && < 5 which is provably false.
Please be aware that accurate version bounds are also mandated by the PVP, and packages are expected to follow the PVP as part of the Hackage guidelines (see http://hackage.haskell.org/upload).  The motivation for this guideline is that otherwise it can have various knock off consequences, such as Hackage possibly not being able to generate Haddock documentation for your package, install-plans degrading over time, as well generally resulting in a poor experience for users since they'll risk running into the compilation errors caused by inaccurate version bounds, and finally causing more work for us Hackage Trustees curating Hackage.
The cabal gen-bounds command can be used to help infer an initial set of version bounds, see  Cabal User Guide | Generating dependency version bounds for more details. Or if you use Stack, just add pvp-bounds: both to your stack.yaml file (see https://docs.haskellstack.org/en/stable/yaml_configuration/#pvp-bounds).
If you have any questions, feel free to ask me!

Thanks for the heads up, I change the bounds for the base package as well as added bounds for the other packages that are being used.


Question about earning fees

Docs say

Fees are calculated based on the amount of liquidity purchased. During the mainnet alpha, fees will range from 5-25 basis points per user.

What does "per user" mean?

This is probably a typo and should say "per unit" or "per order".

This is probably a typo and should say "per unit" or "per order".


Pattern Replicator is not placing redstone dust.

Minecraft version & Mod Version:  1.12.2 and 1.12.0
Single player or Server:   Single
Describe problem (what you were doing / what happened):  Using the Pattern Replicator to copy Compact Machine recipes.  There is placed redstone dust in the pattern.  The replicator is not placing it.
Crash log (if any):  None

Fixed it for redstone dust, repeaters, comparitors.
Anything else you know of thats affecting this?

Not that I know of.
Thank you!

https://minecraft.curseforge.com/projects/cyclic/files/2531438

If the redstone dust is on top of another layer in the copy zone, the random order it places blocks may result in the dust being placed in mid-air, dropping the dust.  It either needs to detect that a block is below the dust or have an option to always build bottom to top.
Thanks,
IMarv


bump actions/checkout v3

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 85.515%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
307

Relevant Lines:
359

💛  - Coveralls


s3 custom treatment of GetBucketLocation response

@jdisanti discovered a discrepancy: S3 documentation specifies a form of XML for the response of GetBucketLocation, and then provides an example that does not follow the specification.  @rcoh found that the Go SDK had this issue and implemented a customization to deal with this.
Acceptance criteria:

responses to the getBucketLocation operation should deserialize as expected into the response properties.

https://smithy.io/2.0/aws/customizations/s3-customizations.html#aws-customizations-s3unwrappedxmloutput-trait

This seems to have been implemented already in #174, albeit not via s3UnwrappedXmlOutput.


fix UT issuse for data curation export

Code changes
Test changes

Purpose

fix UT issuse for data curation export

Author pre-publish checklist

[ ] Added test to prove my fix is effective or new feature works
[ ] No PII in logs
[ ] Made corresponding changes to the documentation

Thanks @Nick287 ! :-)


Remove unused host variable

The host was removed from the package, but this was left in the code. We can now get rid of this unused variable.

Thanks a lot and apologies for the delay!


Channel doesn't attempt to reconnect after idle time

We are seeing a bug (?) with gRPC (Python) on one particular link that crosses AWS VPCs.
When the channel is idle for a certain time, the next RPC on the channel fails with StatusCode.UNAVAILABLE.  We would expect the underlying channel to be renegotiated silently and the RPC to succeed.  This failure happens regardless of whether we use channel_ready_future/cygrpc.check_connectivity_state on the channel prior to making the RPC.
The following code reproduces the issue:
import time
import logging

from third_party.python import grpc
from service_proto import foo_pb2

target = 'server-in-other-aws-vpc:50005'
channel = grpc.insecure_channel(target)
stub = foo_pb2.FooServiceStub(channel)
NUMBER_OF_REQUEST_TRIES = 2
# This delay produces the grpc.StatusCode.UNAVAILABLE error state
RETRY_DELAY_IN_SECS = 400
# Where-as this delay works as expected
# RETRY_DELAY_IN_SECS = 300
ERROR_RETRY_DELAY_IN_SECS = 0.2

def log_connectivity_changes(connectivity):
    print("Channel changed status to %s." % connectivity)

channel.subscribe(log_connectivity_changes)

def make_request():
    previous_connectivity_state = channel._channel.check_connectivity_state(True)
    print('check_connectivity_state returned with %s.' % previous_connectivity_state)
    response = stub.GetFoo.future(foo_pb2.GetFooRequest(), 10)
    print('Got successful result: %s' % response.result())

try:
    for i in range(NUMBER_OF_REQUEST_TRIES - 1):
        print('Making request nr %s.' % (i + 1))
        make_request()
        print('Sleeping now for %s minutes and then retrying request to produce UNAVAILABLE '
              'error.' % (RETRY_DELAY_IN_SECS / 60.0))
        time.sleep(RETRY_DELAY_IN_SECS)
    print('Making final request.')
    make_request()
except grpc.RpcError as rpc_error:
    if rpc_error.code() == grpc.StatusCode.UNAVAILABLE:
        logging.exception(rpc_error)
        print('Sleeping now for %s seconds and then retrying request, which will be '
              'successful.' % ERROR_RETRY_DELAY_IN_SECS)
        time.sleep(ERROR_RETRY_DELAY_IN_SECS)
        print('Retrying request now.')
        make_request()
    else:
        raise rpc_error

If we are idle for 400s we get the following failure:
Making request nr 1.
Channel changed status to ChannelConnectivity.IDLE.
 check_connectivity_state returned with 0.
Channel changed status to ChannelConnectivity.READY.
Got successful result: error {
  code: 50001
  err_message: "Status message"
}

Sleeping now for 6.66666666667 minutes and then retrying request to produce UNAVAILABLE error.
Making final request.
check_connectivity_state returned with 2.
Channel changed status to ChannelConnectivity.IDLE.
ERROR:root:<_Rendezvous of RPC that terminated with (StatusCode.UNAVAILABLE, {"created":"@1477577331.417376989","description":"EOF","file":"src/core/lib/iomgr/tcp_posix.c","file_line":235,"grpc_status":14})>
Traceback (most recent call last):
  File "/home/markus/Desktop/channel_test.py", line 40, in <module>
    make_request()
  File "/home/markus/Desktop/channel_test.py", line 30, in make_request
    print('Got successful result: %s' % response.result())
  File "/home/markus/Projects/grpc/_channel.py", line 272, in result
    raise self
_Rendezvous: <_Rendezvous of RPC that terminated with (StatusCode.UNAVAILABLE, {"created":"@1477577331.417376989","description":"EOF","file":"src/core/lib/iomgr/tcp_posix.c","file_line":235,"grpc_status":14})>
Sleeping now for 0.2 seconds and then retrying request, which will be successful.
Retrying request now.
check_connectivity_state returned with 0.
Channel changed status to ChannelConnectivity.CONNECTING.
Channel changed status to ChannelConnectivity.READY.
Got successful result: error {
  code: 50001
  err_message: "Status message"
}

However, if we reduce the idle time to 300s, the same code succeeds:
Making request nr 1.
Channel changed status to ChannelConnectivity.IDLE.
 check_connectivity_state returned with 0.
Channel changed status to ChannelConnectivity.CONNECTING.
Channel changed status to ChannelConnectivity.READY.
Got successful result: error {
  code: 50001
  err_message: "Status message"
}

Sleeping now for 5.0 minutes and then retrying request to produce UNAVAILABLE error.
Making final request.
check_connectivity_state returned with 2.
Got successful result: error {
  code: 50001
  err_message: "Status message"
}

Our current theory is that it is related to the different behaviour of the AWS NAT gateway compared to a NAT instance.  This particular link uses the AWS NAT gateway on the exit path from the client VPC.  From the AWS docs:

NAT gateway timeout behaviour:
When a connection times out, a NAT gateway returns an RST packet to any resources behind the NAT gateway that attempt to continue the connection (it does not send a FIN packet).
NAT instance timeout behaviour:
When a connection times out, a NAT instance sends a FIN packet to resources behind the NAT instance to close the connection.

@ctiller, might I trouble you for an assessment of this report? Is gRPC doing something wrong, or doing something that could be improved upon, or is this a case in which the observed behavior is as good as it's going to be?

This is going to take some investigation. It's unclear whether we'll need the retry work (slated to begin soon) to resolve it. Let's not pause the 1.1 release.
If it turns out we can fix it easily in that release branch, let's do that, otherwise let's target 1.2.

Hey folks, any news on this? I'm seeing the same problem.
Thanks

Fixed by #11154

Could it be that the problem still exist in the PHP client?
We are getting Sisu\Grpc\Exception\GRPCException: Endpoint read failed errors on the client on long living and (often) idle connections


feat(DIST-1217): Add tracking as url option

Do we want to add anything about this flag to the README?

Do we want to add anything about this flag to the README?

Good point  ☝

:tada: This PR is included in version @typeform/embed-v1.19.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


SF: Provide UI for "staging" project for review (before committing)

Some projects will want draft translations placed in a "staging" project, where it can be reviewed before being incorporated into the actual translation project

See https://jira.sil.org/browse/SF-2629


Updating yarn.lock for the vx upgrade

Sorry didn't realize yarn.lock changes should be checked in with package change. This goes along with this pr for upgrading vx. #5647
@williaster @kristw

Codecov Report

Merging #5648 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5648   +/-   ##
=======================================
  Coverage   63.51%   63.51%
=======================================
  Files         360      360
  Lines       22890    22890
  Branches     2549     2549
=======================================
  Hits        14539    14539
  Misses       8336     8336
  Partials       15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e04180...4175d6c. Read the comment docs.


Check Should Account for "Overspilling"

Here is the example:
(module m1)
(defcolumns X)
(vanish c1 (shift X -1))

And this trace:
{ "m1.X": [1] }

This currently passes go-corset check but fails corset check.  The question is: which is the correct behaviour?

go-corset apparently has the correct behaviour.


Improve help on az quantum commands.

This change adds a parameter to the examples of two commands to prevent a confusion by users that might not be aware that a default has to be set first, before using the command without that parameter.
No functionality change as part of this change.

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

quantum


Router.map() deprecated - How to replace it?

Hi
my router.js looks like:
Router.map(function () {
    this.route('a',{options: asdf});
    this.route('b',{options: asdf});
    this.route('c',{options: asdf});
    this.route('d, {options: asdf});
});

(offtopic: no clue whats wrong with my markdown here)
it looks like the map() function is deprecated. what is the new name of map() ? Or how I have to replace it?

the new way is to define them separately, i.e.
Router.route('/', function () {
  this.render('Home');
});

Router.route('/one', function () {
  this.render('PageOne');
});

Router.route('/two', function () {
  this.render('PageTwo');
});


S3 Filesystem support cannot be configured with instance profiles on HVM EC2 Instances

On hue 4.3 built from source, deployed to an AWS EC2 HVM based instance, the S3 File Browser remains disabled when allow_environment_credentials=True in the [[aws]][[default]] section of the INI file.
The specific issue is in:
desktop/libs/aws/src/aws/conf.py in lines 198-207 ( the has_iam_metadata function ).
The source checks /sys/hypervisor/uuid for a GUID with a magic value that starting with EC2 to determine that it is a virtualized EC2 instance. This specific condition is not met on HVM based EC2 instances, which have an empty /sys/hypervisor folder.
Instead, as per the latest documentation at
https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/identify_ec2_instances.html, you should use the Desktop Management Interface through dmidecode or the files at /sys/devices/virtual/dmi/id/* to identify if the instance is an EC2 instance. Many of the ../dmi/id/ files world readable, and the /sys/devices/virtual/dmi/id/sys_vendor will return "Amazon EC2" and is a reliable device file you can use to determine the VM is an EC2 instance.
I can file a PR for this, but the fix is trivial. HVM instances are popular and this bug is pernicious and fails opaquely. I hope it can be fixed quickly.

@colintoal: please go ahead and submit a PR and we'll review it ASAP.

@colintoal Did you create a PR? I ran into the same issue - can create the PR if you haven't yet.

I'll submit a PR for this, hopefully in the next couple days.

@jdesjean I'm not able to find a JIRA ticket corresponding to this issue... is there one? If not do I create one? At that point can I create a feature branch? I know ultimately I need follow the stuff on https://github.com/cloudera/hue/blob/master/docs/CONTRIBUTING.md, but I'm not sure just how to get to the point where I can create a feature branch.

@sqNutrien I created a JIRA for you https://issues.cloudera.org/browse/HUE-8780. For one liner, you can just create a pull request.

Thanks @jdesjean. My fix will be a few lines ... not too many :) Not sure what tests I'll have to modify/create - I hope to make progress on this in the next couple days.

@jdesjean I'm not seeing the CCLA that is referenced in the hue/docs/CONTRIBUTING.md: "If it is the first time, please sign the CCLA that way we don't get sued later ;)"
Also - looks like I fork your repo, make my changes in my fork, then submit a PR... correct?

We decided to remove the CCLA, so don't worry about it. We'll update the docs.
Correct.

@jdesjean starting on this... I don't seem to have the ability to "Start" the JIRA ticket... is that something I do, or just work on it and management of JIRA is at your end?

Because I created it, you can't. Don't worry about it, I'll managed it on my end.

@jdesjean sorry man. I don't think I'm thick, but I can't find python2.7-devel anywhere... trying to install it in my conda environment because I get this error when trying to build the project:
/Users/scottqueen/Repos/hue/Makefile.vars:42: *** "Error: must have python development packages for 2.7. Could not find Python.h. Please install python2.7-devel".  Stop.

Looked all over the interwebs, tried brew install,pip install, conda install.... no dice.
Any hints? Developing on a Mac.

Can you take a look at this: https://github.com/cloudera/hue/issues/251


WIP: MMU/Paging Refactor

What does this PR do?

It fixes several issues with the memory management
It fixes a bug where page indices were incorrectly calculated (rust os book had octal and here had decimal, changed to hex)
It adds optionability to the memory management, frame allocation, and paging systems.

To Do

Figure out how to use Huge Pages

Note
This is just a WIP, we can review code style later. Right now I need to somehow support Huge Pages, which won't be easy. Hard to find good references.
ELF programs don't load right now because they attempt to load huge pages.

I am not sure how we should do this but having some unit tests might be useful

Selftest seems to work, so at least something is going well. Problem is the huge pages, mostly.

cool, do you need anything to move forward?

One thing I am wondering is if these problems also occur with the GPL code of liballoc (which should be a more recent version of that lib iirc)

I've had less time to work on this lately but I'm still thinking about how to do this. Basically, our P2 is all huge pages, and the allocator doesn't support that, which causes all sorts of problems.
Our only way around this is to remove huge pages or add support for them, so I'm considering just getting rid of them and mapping p1 as well.
This should solve the problems with memory for the most part.
I also more or less know of several things that are causing ELF loading to require more memory, like the fact that the ELF is 2.1MB big and has virtual addresses that can be above the normal memory limit. I need to investigate this more.

Additionally, we're mapping P2 to huge_page yet we don't hit the huge_page problem at first.
Additionally, we're zeroing the tables in table_next_create.
Which makes me feel that we're not respecting the mapping in the asm at all.

Hey @LittleCodingFox, I was wondering if you wanted to discuss about this project and the issues you mentioned in this PR (I know things are very different now than 8 months ago)

Hey Will, I'd love to work on it every now and then but at the time I didn't find good enough documentation and my inexperience with OS dev made it hard to overcome the memory problems

Hey, no problem. Yeah, the memory layer definitely has bugs and I don't get why either.. It takes time to understand and fix things.. (I had a baby in the meantime so I don't have a lot of time to focus on hard topics like this one)

Do you use Telegram, Discord, or Facebook? Probably easier to chat

Also, congrats on the baby!

Do you use Telegram, Discord, or Facebook? Probably easier to chat

I think I have a Telegram account yeah, you can email me at will [AT] drnd [DOT] me and then we can move over Telegram or something.

I created a gitter room fwiw: https://gitter.im/willdurand-kernel/community


Test Invalid Block Propagation + and successful conversion to Blocklist

Successful Blocklist Testing: Test that Full Node sends an invalid Block and then tries to send a valid one but fails because it is blocklisted.
Test different invalid block cases:

Invalid Header
Invalid PFB commitment

Handled in go-header


Adds antialiasing support and font file loadingsupport to TFT_eSPI

Hi, I tried to implement it with as little modifications to the other graphics drivers as possible, but i still had to change the definitions of gslc_DrvDrawTxt for every backend to get in the background color argument. An example 11 is also there. Just did a quick test on my hardware, it seems to compile on ADAGFX but i have tested it only on TFT_eSPI on my hardware. Seems to work at least for text boxes and buttons without changing the examples a lot.

Great, thanks Lukas! I'm hoping to test this out tomorrow, though as a heads-up, I'm inclined to wait for an issue in the regression suite (#65) to be resolved before merging.

After some testing I realized that the font needs to be loaded in every gslc_DrvDrawTxt() call (obviously) so that multiple fonts can be used, and fixed that. I get exceptions and reboots if the font file is not uploaded to the SPIFFS, but maybe you are facing a different issue. The example now shows a standard text button and an anti-aliased one for demonstration.

Thanks Lukas for the updates! I am still working to resolve issues I see with SPIFFS (unrelated to GUIslice) on my SparkFun ESP32, but as soon as I have that working, I'll be able to test & integrate this PR.


Sticky Header Menu not available on mobile screens

The top sticky menu for narrow scenes doesn't seem to appear on screen resolutions of less than or equal to 500px wide. If the resolution starts above this, the page is scrolled to trigger the menu and then the screen width reduced below 500px the menu stays in place and works fine. Is there a way around this?

Would be fixed by https://github.com/janraasch/hugo-scroll/pull/93
If you like, you can try it by using temporary my fork (until this is resolved :) ): https://github.com/susnux/hugo-scroll

I had the same problem and eventually I put the menu on top of the page as a row. The side menu is just not feasible on smaller screens.

top menu implemented


Feature: Improvisation of Get in touch section UX design

Feature description
The "get in touch" section of the home page is not properly visible.
I want to work on this under GSSOC2022. Can you assign it to me.
👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

@Abhilasha-Jairath I am assigning this issue to you but we will merge it only if that UX will be better and more appealing than the current one

Thank you maam !! Ill start working on it.


can I use this tool to desgin VNFD

Hello Team,
I am searching a tool using which I can design VNFD according to ETSI Specification
https://www.etsi.org/deliver/etsi_gs/NFV-SOL/001_099/001/03.06.01_60/gs_nfv-sol001v030601p.pdf
VNFD are design based upon the TOSCA language.
Your support will be appreciated
Thank you,
Sunil Kumar

Atleast tell me how it can help in this direction

You can have a look into the corresponding publication or the Master's Thesis which provides more details.