Rift Tokens (Forgotten Circles)

Affected Scenario(s): 96 and all FC scenarios
Describe the bug
Once a Rift Token is placed it cannot be moved or removed.  Ethereal Vortex card allows these to be moved, but we are unable to using either the move character function or move obstacle or trap function.
To Reproduce
Steps to reproduce the behavior:
Place rift token, try and move or remove it.
Browser : Chrome

This is a two part issue really - the first is that Rifts can't be removed, and the second is that obstacles overall can't be moved in Chrome.
Rifts are now removable! 🎉  This should sidestep the second issue, but doesn't fix it.
The second issue is more widespread and something I've been looking into for quite some time. A release of Chrome seems to have caused all obstacles to no longer be draggable. Despite my best efforts I can't see any reason why this would be the case when monsters and characters (which are semantically the same as overlays) are not affected.
I'm going to keep this open until I can find a fix for Chrome or until Google fix it themselves, but at least there's a workaround now.

Thanks for the update!  Your board had been a huge help allowing you group
to play during COVID and from different states in the US. We used to set a
camera up over the board but that obviously left one person moving
characters and monsters.
On Wed, Feb 10, 2021, 1:56 AM David North<EMAIL_ADDRESS>wrote:

This is a two part issue really - the first is that Rifts can't be
removed, and the second is that obstacles overall can't be moved in Chrome.
Rifts are now removable! 🎉 This should sidestep the second issue, but
doesn't fix it.
The second issue is more widespread and something I've been looking into
for quite some time. A release of Chrome seems to have caused all obstacles
to no longer be draggable. Despite my best efforts I can't see any reason
why this would be the case when monsters and characters (which are
semantically the same as overlays) are not affected.
I'm going to keep this open until I can find a fix for Chrome or until
Google fix it themselves, but at least there's a workaround now.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/PurpleKingdomGames/virtual-gloomhaven-board/issues/61#issuecomment-776517590,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASZOWI5CKQE32Z2VR6L4AFLS6I34DANCNFSM4XMECTMQ
.

No problem! Really glad you're enjoying it - hopefully that Chrome bug won't be too troublesome until I can get a fix 🙂


How retrieve types mapped in TypeMapperServiceProvider?

Hi Guys, this is driving me crazy.
    /**
     * A list of class names implementing \Swis\JsonApi\Client\Interfaces\ItemInterface.
     *
     * @var string[]
     */
    protected $items = [
        CampagneItem::class,
        OrdiniItem::class,
        GruppoOfferteItem::class,
        ClientiItem::class,
        AnagraficaClientiItem::class,
        UserItem::class,
        FormOfferteItem::class,
        OrderStatusItem::class
    ];

    /**
     * @param \Swis\JsonApi\Client\Interfaces\TypeMapperInterface $typeMapper
     */
    public function boot(TypeMapperInterface $typeMapper) {

        foreach ($this->items as $class) {
            /** @var \Swis\JsonApi\Client\Interfaces\ItemInterface $item */
            $item = $this->app->make($class);

            $typeMapper->setMapping($item->getType(), $class);
        }
    }
}

in my custom controller how can i access to these mapped classes?
if i write $typeMapper = app(TypeMapper::class) is empty of course...
Sorry if question is stupid but I don't have noone to ask to...

Hi @V-Orbit, thanks for reaching out! You should use TypeMapperInterface, which is registered as singleton, instead of TypeMapper e.g.
$typeMapper = app(TypeMapperInterface::class);
$campagne = $typeMapper->getMapping('campagne'); // new instance of CampagneItem (assuming that's the type of the item...)

I'll leave this issue open to clarify this in the docs.

@V-Orbit, to make it less error prone, both TypeMapperInterface and TypeMapper are registered as one singleton in the next release.


Fixed LoadingProvider theme token usage in styles

Closes #903
Description
Fixed LoadingProvider theme token usage in styles
Is this a breaking change (Yes/No):
No
Additional Information

Thank you, @KenyaMasuko!
as long as i know, i fixed!! please review!

@KenyaMasuko Thank you for your comment!! I fixed!!

@KenyaMasuko
No worries!! I just fixed!! please see and check again!


Minio enabled is leading to deployment error

Summary
I am using the following for my value.yaml
fullnameOverride: "cypress-dashboard"

api:
  image:
    repository: agoldis/sorry-cypress-api
    pullPolicy: Always

  enabled: true

  podLabels:
    label: cypress-api

  ingress:
    labels: {}
    annotations: {}
    hosts:
      - host: cydashapi.local.com
        path: /

dashboard:
  image:
    repository: agoldis/sorry-cypress-dashboard
    pullPolicy: Always
  enabled: true

  environmentVariables:
    graphQlSchemaUrl: "http://cydashapi.local.com/"

  podLabels:
    labels: cypress-dashboard

  ingress:
    enabled: true
    labels: {}
    annotations: {}
    hosts:
      - host: cydashboard.local.com
        path: /

director:
  image:
    repository: agoldis/sorry-cypress-director
    pullPolicy: Always

  environmentVariables:

    executionDriver: "../execution/mongo/driver"

    screenshotsDriver: "../screenshots/minio.driver"

  podLabels:
    label: cypress-director

  ingress:
    enabled: true
    labels: {}
    annotations: {}
    hosts:
      - host: cydirector.local.com
        path: /

mongodb:

  enable: true
  internal_db:
    enabled: true

  persistence:
    # set this to a higher number in deployed envs
    size: 1Gi

minio:
  enabled: true
  service:
    port: "443"

sorry-cypress version: <here>
Cypress package version: 7.7.0
Cypress binary version: 7.7.0
Electron version: 12.0.0-beta.14
Bundled Node version: 14.15.1
helm chart version: <here>
-- version: 1.0.5
-- appVersion: 1.1.0

Error Text
Error: Deployment in version "v1" cannot be handled as a Deployment: v1.Deployment.Spec: v1.DeploymentSpec.Template: v1.PodTemplateSpec.Spec: v1.PodSpec.Containers: []v1.Container: v1.Container.v1.Container.Env: []v1.EnvVar: v1.EnvVar.Value: ReadString: expects " or n, but found 4, error found in #10 byte of ...|,"value":443},{"name|..., bigger context ...|ge.yourdomain.com"},{"name":"MINIO_PORT","value":443},{"name":"MINIO_USESSL","value":"true"}],"image|...

this should be fixed in https://github.com/sorry-cypress/charts/pull/66
@tico24 could we get this merged in if it looks ok to you?

@jbard1 sorry, life got in the way. Done.

@tico24 no worries, thank you!
@jkaliaSignify I've just tested this myself on v1.0.6 and it seems to be working fine now

Did not see the issue after doing an helm repo update. closing issue. Thanks!


Modifier order

More configurable options for ordering of modifiers.

Closes #885.

This PR is under reconstruction, as suggested by @SlavaRa.

Also by changing the type of the setting, this will break when the user has this setting modified and FD tries to deserialize it.

I know. But FD nicely handles it by just showing an error dialog on first run, then the setting is set to the new default value (well, technically not set).
Unless the user freaks out after seeing an error dialog, it shouldn't be much of a problem though. hehe

Mmm... You may make the changes backward compatible by using OnDeserializingAttribute or OnDeserializedAttribute.

Could do. But again, unless a user freaks out and faints and gets carried to the nearest hospital after seeing the error message, I would prefer a one-time error dialog than more unnecessary code written.
The settings data will be overridden on first run, but the code will still be there.

Give the setting a new name and it works fine then. It should not give an error. @elsassph?

Ta da

The <Others> may be custom modifiers like AS3 namespace.

Is there a separate setting for Haxe? A lot of these it doesn't have, and additionally there's macro and dynamic.

It doesn't need separate settings, as it only orders what is currently in the code.
For example, if the setting is override, public, internal, protected, private, <Others>, static, and the code being inserted is static public function..., it is sorted to public static function....
I'll add macro and dynamic. Are there any more modifier keyword in any other languages?

Mmm maybe you missed part of Gama11 comment, if so just in case I'll repeat: It's not only about adding those ones, it's also that for example protected is not on Haxe. Since ASCompletion is used for several languages I don't know if you could provide in a nice way different alternatives for each of them...

If protected is not available in Haxe, it means that the code snippets won't have protected in them so the ASComplete will simply not (cannot, in fact) sort it.
Check out the RemoveAndExtractModifier() method. If protected is in the sorted list in setting but does it appear in code, nothing happens.
If I explain the mechanism in simple words:

The code checks if the DeclarationModifierOrder only has 1 item. Since the item <Other> cannot be removed, 1 item means no sorting. Don't call the sorting method.
Otherwise, for each line of code being inserted:
Loop through the modifierOrder array. If the matching modifier is found in the modifiers in the line (modifiers are extracted with regex, which is not my code) remove it from the string and add it to buffer.
Concatenate all extracted modifiers. This will effectively sort only the modifiers specified in modifierOrder, leaving any unmatching modifiers alone as <Other>.
If there was any change, apply the changes.

If DeclarationModifierOrder contains inline, for example
public internal protected privateinline <Other> override static
and the inserted AS3 code (which does not have inline keyword) is
override public function toString():String {

}

it will turn the first line into
public override function toString():String {...

Am I still missing something? Let me know if understood something wrongly.

In case the picture looks kind of misleading:
It does not add those modifiers to the snippets being inserted.
It does sort what it detects from the sort list in the code being inserted.

I understand what you mean, I'm talking from the configuration side of things, which was also what Gama tried to convey with that "separate setting for Haxe", because some Haxe developers will find it strange to see all those non-existent keywords (ok... they will also find strange that you have to modify a setting in a place called ASCompletion, but that's a different subject).

Or maybe these settings could be added to the *Context plugins and then inject the values to the ASCompletion plugin? It leaves the question what to do if a *Context plugin that uses ASCompletion doesn't set the value... maybe ASCompletion should also provide the setting like it currently does...

Yeah I get it. But then as you mentioned it is ASCompletion trying to be greedy and manage all languages by itself, a separate settings would not quite follow the pattern. It would be simpler to just merge them all if the plugin itself is designed that way.

I could to check if we could construct setting groups by context or category.

Having this setting across all *Context could work. But I think *Context imports the ASCompletion, not the other way, so the implementation might be quite difficult (idk maybe there is something like CurrentContext?)

That's why I said  that the *Context plugins would inject their settings to ASCompletion. ASContext.Context would be the current context, so ASCompletion could also get the settings from the Context, although that way you have to do make sure that the base context class have that property..

However IMO I think current version seems alright....?
It doesn't really look confusing though... or is it?
A good enough description for the setting would do.

The dialog should be done like the other ones we have. No embedded resources, use existing icons and make sure its scales correctly on different DPIs. Otherwise this seem good to me you folks can agree on it. :)

There's also extern in Haxe.

New look:

Actually, can I use ResourceHelper.LoadBitmap() and use the previous images instead of the green arrows? The green arrows look quite ugly...

This can wait for #1013 so that it can use FindImage16() for the button images.

@elsassph: Good for merge when finished?

Is this ok now for all parties?

Ok

Does this need any more fixes?

Hum I'm giving it a try and I don't understand how it works (besides the fact that UI isn't high-dpi scalable).
Why are there even 2 lists?
As far as I can tell, there should be just one list with a list of tokens (like dynamic, extern, inline, static,...). Whatever is in this list will be added first and ordered as in the list; whatever isn't in the list is added after in the order they are provided by the user.

There are two lists to provide flexibility.
It's like a normal collection editor, that you have one list of values (which is the list on the right) that you can add/remove/order items.
Except that you can only add a fixed list of items, and each item only once (unlike a normal collection with enum types, which allows addition of the same item multiple times). Also there can be items that cannot be removed ("" in this case).
Adding/removing items are supported to treat certain items the same as <rest>. When sorting modifiers anything that is in the list is sorted as the list specifies, and everything else will be left in the same order as they were, and inserted where <rest> sits in the list.
There isn't any default editor for just ordering items in a collection, so that means it needs a new UI anyway, so I just made a useful one that could be used on other settings too.

Setting AutoScaleMode to Font and setting Font to PluginBase.Settings.DefaultFont does all the things needed for HDPI support, right?
It's really difficult to test it... Requires restart every time I change DPI.

@elsassph?

Merged - looking fine on high-dpi. Should be a candidate for unit tests coverage but it's really been sitting here for a long time :)


DeepSeek MoE support

Hey, it would be awesome if we could see https://github.com/deepseek-ai/DeepSeek-MoE support

Active works in #2467 and #2453

@SinanAkkoyun Close this since v0.3.0 support this model.


How to use this project？

Hi
I am very interested in this project, because I have recently done a smart speaker project using Amazon AVS, I also have a set of hardware devices：Amlogic A113X1 Far-Field Dev Kit for Amazon AVS , detials : http://openlinux2.amlogic.com/download/doc/A113X1_Usermanual.pdf ,  There are six microphones.
How to connect these signal processing modules (Speaker tracking, Beamforming, Post-filtering, Speech enhancement, Dereverberation and  Echo cancellation ) to form a complete signal processing flow, suitable for hands-free smart speakers using Microphone arrays? can provide a  C++ demo?
Can I use the Millennium ASR as a wake word detection?
thanks！

@kkumatani
Thank you very much，That's very kind of you.
sure， I will research in Python on Ubuntu for understand this project。I have see btk1.0 ，
follow Beamforming1.0 toolkit User Guide， but  In order to run Script_CMU-GHC2109 and Scripts_DS+SD+MVDR ，maybe need some data and config file。
iI am  looking for a low power complexity keyword spotter， how about this  https://github.com/Picovoice/Porcupine？
Best regards

I am very interested in this project, but I don't understand how to use this project about dereverberation？If I have a .wav file.  I mean in C++. .........


Info page wmts

version and format turned around?

version
string
'image/jpeg'
Image format.

format
string
'1.0.0'
WMTS version.

Example = format: 'image/png'

@AllroadsNL Thanks for the bug report ! Will be fixed with #8808


Sorting not showing the up/down arrow icon

Hi,
I have made sortable='true' for some columns, and when i click on header label to sort the column it is not showing the up/down arrow icon. See below screenshot for example of icon.

Also is it possible to show a label 'Sort' as tooltip on hover over the column header which is configured for sorting.
Thanks,
Rajiv

Are you coding sortable=true in the HTML definition of the px-data-table-column directly, or trying to dynamically add it later? As it says on the demo page for px-data-table-column (click the link under "Children Components") a few of the column properties are not set up for dynamic switching, they have to be set upfront or else there is some weird behavior. We have a backlog item to make them all dynamic.
I believe another team has requested some kind of affordance to indicate sorting is possible (showing both an up and down arrow in black, for instance) which is also in our backlog and would accomplish the same thing as your suggested tooltip solution.

I've fixed this in the latest release 204beb93ddcf8196c6c1e5dc7eca7e1d43161967


Raise exception for invalid relation name

Solves #434
@solnic after playing with the code I found this to be a good place for raising the error 😄
Although the test infers the name from the schema macro I would have liked to test creating a Relations class but not under the namespace of Test but the ConstantLiker wouldn't allow me.
Hope this helps.

@solnic sorry for the delay. Hope this is better now 😄


Convert unittest to pytest

Convert all unittests to pytests

Checked locally, number of tests and coverage are the same.


PULL_REQUEST_TEMPLATE.md: sha-version, confirm change is legitimate

The box of eternal struggle.

The struggle is real.


getSwaps Failed:  AxiosError: getaddrinfo EAI_AGAIN localhost3000

I need help with this too.
When I do this  at the command line : npm run dev then i get the dump error below
getSwaps Failed:  AxiosError: getaddrinfo EAI_AGAIN localhost3000
at AxiosError.from (file:///home/wims/atomic-swap-open-protocol/node_modules/axios/lib/core/AxiosError.js:89:14)
at RedirectableRequest.handleRequestError (file:///home/wims/atomic-swap-open-protocol/node_modules/axios/lib/adapters/http.js:591:25)
at RedirectableRequest.emit (node:events:525:35)
at eventHandlers. (/home/wims/atomic-swap-open-protocol/node_modules/follow-redirects/index.js:14:24)
at ClientRequest.emit (node:events:513:28)
at Socket.socketErrorListener (node:_http_client:502:9)
at Socket.emit (node:events:513:28)
at emitErrorNT (node:internal/streams/destroy:151:8)
at emitErrorCloseNT (node:internal/streams/destroy:116:3)
at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
hostname: 'localhost3000',
syscall: 'getaddrinfo',
code: 'EAI_AGAIN',
errno: -3001,
config: {
transitional: {
silentJSONParsing: true,
forcedJSONParsing: true,
clarifyTimeoutError: false
},
adapter: [ 'xhr', 'http' ],
transformRequest: [ [Function: transformRequest] ],
transformResponse: [ [Function: transformResponse] ],
timeout: 8000,
xsrfCookieName: 'XSRF-TOKEN',
xsrfHeaderName: 'X-XSRF-TOKEN',
maxContentLength: -1,
maxBodyLength: -1,
env: { FormData: [Function], Blob: [class Blob] },
validateStatus: [Function: validateStatus],
headers: AxiosHeaders {
Accept: 'application/json, text/plain, /',
'Content-Type': 'application/json',
'User-Agent': 'axios/1.4.0',
'Content-Length': '66',
'Accept-Encoding': 'gzip, compress, deflate, br'
},
baseURL: 'http://localhost3000',
url: '/api/getSwaps',
data: '{"mph":"2d10eda247d5da1fd7f2dfe93f3fcc7c813472a79c523e02fe9e46ec"}',
method: 'post'
},
request: <ref *1> Writable {
_writableState: WritableState {
objectMode: false,
highWaterMark: 16384,
finalCalled: false,
needDrain: false,
ending: false,
ended: false,
finished: false,
destroyed: false,
decodeStrings: true,
defaultEncoding: 'utf8',
length: 0,
writing: false,
corked: 0,
sync: true,
bufferProcessing: false,
onwrite: [Function: bound onwrite],
writecb: null,
writelen: 0,
afterWriteTickInfo: null,
buffered: [],
bufferedIndex: 0,
allBuffers: true,
allNoop: true,
pendingcb: 0,
constructed: true,
prefinished: false,
errorEmitted: false,
emitClose: true,
autoDestroy: true,
errored: null,
closed: false,
closeEmitted: false,
[Symbol(kOnFinished)]: []
},
_events: [Object: null prototype] {
response: [Function: handleResponse],
error: [Function: handleRequestError],
socket: [Array]
},
_eventsCount: 3,
_maxListeners: undefined,
_options: {
maxRedirects: 21,
maxBodyLength: Infinity,
protocol: 'http:',
path: '/api/getSwaps',
method: 'POST',
headers: [Object: null prototype],
agents: [Object],
auth: undefined,
family: undefined,
lookup: undefined,
beforeRedirect: [Function: dispatchBeforeRedirect],
beforeRedirects: [Object],
hostname: 'localhost3000',
port: '',
agent: undefined,
nativeProtocols: [Object],
pathname: '/api/getSwaps'
},
_ended: false,
_ending: true,
_redirectCount: 0,
_redirects: [],
_requestBodyLength: 66,
_requestBodyBuffers: [ [Object] ],
_onNativeResponse: [Function (anonymous)],
_currentRequest: ClientRequest {
_events: [Object: null prototype],
_eventsCount: 7,
_maxListeners: undefined,
outputData: [],
outputSize: 0,
writable: true,
destroyed: false,
_last: true,
chunkedEncoding: false,
shouldKeepAlive: false,
maxRequestsOnConnectionReached: false,
_defaultKeepAlive: true,
useChunkedEncodingByDefault: true,
sendDate: false,
_removedConnection: false,
_removedContLen: false,
_removedTE: false,
strictContentLength: false,
_contentLength: '66',
_hasBody: true,
_trailer: '',
finished: false,
_headerSent: true,
_closed: false,
socket: [Socket],
_header: 'POST /api/getSwaps HTTP/1.1\r\n' +
'Accept: application/json, text/plain, /\r\n' +
'Content-Type: application/json\r\n' +
'User-Agent: axios/1.4.0\r\n' +
'Content-Length: 66\r\n' +
'Accept-Encoding: gzip, compress, deflate, br\r\n' +
'Host: localhost3000\r\n' +
'Connection: close\r\n' +
'\r\n',
_keepAliveTimeout: 0,
_onPendingData: [Function: nop],
agent: [Agent],
socketPath: undefined,
method: 'POST',
maxHeaderSize: undefined,
insecureHTTPParser: undefined,
joinDuplicateHeaders: undefined,
path: '/api/getSwaps',
_ended: false,
res: null,
aborted: false,
timeoutCb: null,
upgradeOrConnect: false,
parser: null,
maxHeadersCount: null,
reusedSocket: false,
host: 'localhost3000',
protocol: 'http:',
_redirectable: [Circular *1],
[Symbol(kCapture)]: false,
[Symbol(kBytesWritten)]: 0,
[Symbol(kNeedDrain)]: false,
[Symbol(corked)]: 0,
[Symbol(kOutHeaders)]: [Object: null prototype],
[Symbol(errored)]: null,
[Symbol(kUniqueHeaders)]: null
},
_currentUrl: 'http://localhost3000/api/getSwaps',
_timeout: null,
[Symbol(kCapture)]: false
},
cause: Error: getaddrinfo EAI_AGAIN localhost3000
at GetAddrInfoReqWrap.onlookup [as oncomplete] (node:dns:107:26) {
errno: -3001,
code: 'EAI_AGAIN',
syscall: 'getaddrinfo',
hostname: 'localhost3000'
}
}
getServerSideProps: No swaps found

I've just updated the README to include a ":" before the port.  This should resolve the issue.   Please make sure to run source ~/.bashrc after making any updates to the environment variables.


Keep environment variables when Agent runs commands with sudo

Especially when executing plugins with user =  option, currently some environment variables set by agent are dropped.

init_unix.go does setenv
MACKEREL_AGENT_PLUGIN_META=1 on getting graph definitions

sudoing with -E maybe solve those problem.
     -E, --preserve-env
                 Indicates to the security policy that the user wishes to preserve their existing environment variables.  The security policy may return an error if the user does not have permission
                 to preserve the environment.

LGTM!

Thanks!


[K3s] converting existing cluster to etcd

Request Summary:
This section sounds like it's possible to keep pre-existing pods by adding the --cluster-init flag.
https://rancher.com/docs/k3s/latest/en/installation/ha-embedded/#existing-clusters
However, this did not occur for me and I lost all pod state on the cluster that I wanted to turn into a multi-node cluster.
Details:
This needs more details on what "upgrading a cluster" entails. If it drops all existing pods, then state that.
Additionally, provide documentation or links to other documentation on how to check the sqlite database is valid.
This section sounds like it's a trivial operation.

On versions that support it, adding the --cluster-init flag on a server currently using sqlite does a one-time copy of all data from the sqlite datastore into etcd. There should be zero data loss and minimal downtime. If you're experiencing otherwise, please open an issue in the k3s-io/k3s repo describing your environment, how you added the CLI flag, and attach the logs from the first server startup after adding the flag.

Hi @bdols, thank you for your contribution. I added a note in the docs to clarify the K3s versions necessary for successful migration to etcd.


no renewal with pebble

It seems dehydrated does not with pebble, a test acme server that is useful for local testing of certificate renewals.
To reproduce, install pebble as instructed in the above link. Typically it is necessary to adjust test/config/pebble-config.json in pebble checkout to match  local server HHTP port from 5002 to 8080 or whatever.
Then adjust /etc/localhost to contain:
<IP_ADDRESS> www.example.com
Then configure HTTP server running locally to respond to www.example.com
It is also necessary to set CURL_CA_BUNDLE environment variable to path-pebble-checkout/test/certs/pebble.minica.pem.
Then run pebble and then dehydrated like in:
env CURL_CA_BUNDLE=/path-to-pebble-checkout/pebble.minica.pem dehydrated --acount --accept-terms --ca https://<IP_ADDRESS>:14000/dir
env CURL_CA_BUNDLE=/path-to-pebble-checkout/pebble.minica.pem dehydrated --cron --force --accept-terms --ca https://<IP_ADDRESS>:14000/dir --domain www.example.com

While the first command reports success, te seconds fails with the log:
# INFO: Using main config file /etc/lms-dehydrated/config
Processing www.example.com
 + Signing domains...
 + Generating private key...
 + Generating signing request...
 + Requesting new certificate order from CA...
 + Received 1 authorizations URLs from the CA
 + Handling authorization for www.example.com
 + 1 pending challenge(s)
 + Deploying challenge tokens...
 + Responding to challenge for www.example.com authorization...
 + Challenge is valid!
 + Cleaning challenge tokens...
 + Requesting certificate...
  + ERROR: An error occurred while sending post-request to https://<IP_ADDRESS>:14000/finalize-order/lPlATXt7PCfm1I8lZeY4jMlzZ69NWKJjQoSJRHzzK0c (Status 400)

Details:
HTTP/1.1 400 Bad Request
Cache-Control: public, max-age=0, no-cache
Content-Type: application/problem+json; charset=utf-8
Link: <https://<IP_ADDRESS>:14000/dir>;rel="index"
Replay-Nonce: Ry56gB38RD-9RyDlCgJFmg
Date: Tue, 06 Sep 2022 19:32:00 GMT
Content-Length: 147

{
   "type": "urn:ietf:params:acme:error:badNonce",
   "detail": "JWS has an invalid anti-replay nonce: R809jiUv50iSokVBmHNwDA",
   "status": 400
}

EXPECTED value GOT EOF

The problem is that hydrated does not properly handle nonce. The code uses HEAD to get one, but ACME specs does not allow that. In particularly, the code must track nonce from the previous requests as required by ACME. pebble explicitly deviates from boulder in that respect to test spec conformance.

Mh, has there been an update to the spec I haven't seen yet? The rfc clearly states:
 To get a fresh nonce, the client sends a HEAD request to the newNonce
   resource on the server.  The server's response MUST include a Replay-
   Nonce header field containing a fresh nonce and SHOULD have status
   code 200 (OK).  The server MUST also respond to GET requests for this
   resource, returning an empty body (while still providing a Replay-
   Nonce header) with a status code of 204 (No Content).

Maybe it's intentionally a badNonce error to check for compliance with another part of the rfc?
An error response with the
   "badNonce" error type MUST include a Replay-Nonce header field with a
   fresh nonce that the server will accept in a retry of the original
   query (and possibly in other requests, according to the server's
   nonce scoping policy).  On receiving such a response, a client SHOULD
   retry the request using the new nonce.

But that's only a SHOULD, so except for some test scenarios it should still work in normal operation... I'll look into this... Last time I tried it worked against pebble without any issues.

I've implemented a workaround for this in 6fb8eba56a67af8e8b5528b669a5da923b5d2182. Not going to merge it into master yet, as I'm hoping to clean up some implementation details soon, hopefully making such retry logic a lot easier.

The checkout from https://github.com/dehydrated-io/dehydrated/commit/6fb8eba56a67af8e8b5528b669a5da923b5d2182 works, thanks for a quick fix and for the link about the pebble on purpose failing here.
I suspect that others have not reported the issue previously because by default pebble fails in 5% of requests. If one uses it just to get single certificate, then the issue is not that visible. But it is almost certain to fail when one uses a test a setup with 15 different host names...

fix has now been released


Typos on strings #86 & 225

As is mentioned in https://github.com/mozilla/pdf.js/blob/master/.github/CONTRIBUTING.md, the translations are not maintained in this repo:

Note that the translations for PDF.js in the l10n folder are synchronized with the Nightly channel of Mozilla Firefox. This means that we will only accept pull requests that add strings currently missing in the Nightly channel, but keep in mind that the changes will be overwritten when we synchronize again.

Closing since the translations are not maintained here, only imported from upstream. Please report the issue to https://wiki.mozilla.org/L10n:Teams:es-AR instead since they can fix it and we can pull the changes automatically afterwards. Thanks.


🛠 Tooling: can --bin be used to create CLI tools?

Bug Report Checklist

[X] I have tried restarting my IDE and the issue persists.
[X] I have pulled the latest main branch of the repository.
[X] I have searched for related issues and found none that matched my issue.

Overview
I write CLI tools with TypeScript.  I've started trying to use CTA for this and realised that either the bin functionality doesn't create all the src/bin code that CTA itself has built in.  I'm assuming this is deliberate?
Either way, I'm just about to (for the second time) copy paste src/bin code into a project I'm starting as it's so gosh darn useful!
Does CTA create this stuff if you just do it the right way?  I can see a --bin option here:
https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/docs/Options.md#optional-options
But it doesn't appear to do anything more than package.json fiddling.  Am I getting this right?
Additional Info

That's correct, it doesn't create the bin/ file. The contents of that file are up to you based on how you'd like to structure your API. This would be a good thing to mention in the docs!

Awesome - I'll try and add that soon.  Follow up question:
I've now scaffolded out my second CLI app borrowing heavily from CTAs bin internals (you can see it here: https://github.com/johnnyreilly/ado-npm-auth-lite) and I've found all the bin stuff really handy!
Is there a desire that bin mode could include this code deliberately, rather than the copy / pasta that I've been doing?

I think it'd be best to not 😞. Having a standard unified set would be really nice. But this is edging into enforcing opinions on how folks structure their apps. Decisions like "export a bin from src/bin/index.ts" is a pretty specific thing.


feat: revamp actor build endpoint, js builds -> tar

Fixes RVT-4117
Changes

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1398  👈 (View in Graphite)
#1397
#1393
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Adding ensemble slice sampler

This is an implementation of https://arxiv.org/abs/2002.06212 and https://arxiv.org/abs/2105.03468
There are some questions about how to best take advantage of GPU acceleration in the slice steps, but this is a good start.

Of possible interest to @minaskar


Missing state-transition dependency in light-client package

Motivation
Fix builds on slow machines
Description
https://github.com/ChainSafe/lodestar/pull/5246 added a build dep on @lodestar/state-transition but was never added to the package.json. On fast build machines the @lodestar/state-transition package is usually built before the @lodestar/light-client package starts, but slower machines (github runners etc.) have concurrency issues.
The error;
#8 [build_src 5/6] RUN yarn install --non-interactive --frozen-lockfile &&   yarn build &&   yarn install --non-interactive --frozen-lockfile --production
#8 0.350 yarn install v1.22.19
#8 0.601 [1/5] Validating package.json...
#8 0.640 [2/5] Resolving packages...
#8 1.724 [3/5] Fetching packages...
#8 38.13 [4/5] Linking dependencies...
#8 38.14 warning " ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>#8 38.14 warning " ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>#8 38.14 warning " ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>#8 38.14 warning "workspace-aggregator-57537408-e615-4450-8f38-bc19d6bfbcf1 > @lodestar/beacon-node ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>#8 38.14 warning "workspace-aggregator-57537408-e615-4450-8f38-bc19d6bfbcf1 > @lodestar/beacon-node ><EMAIL_ADDRESS>has incorrect peer dependency "prom-client@>= 10 <= 12".
#8 38.14 warning "workspace-aggregator-57537408-e615-4450-8f38-bc19d6bfbcf1 > @lodestar/beacon-node > @multiformats/multiaddr > dns-over-http-resolver ><EMAIL_ADDRESS>has unmet peer dependency "undici@*".
#8 57.47 [5/5] Building fresh packages...
#8 120.6 Done in 120.23s.
#8 120.9 yarn run v1.22.19
#8 121.0 $ lerna run build
#8 121.5 lerna notice cli v5.5.2
#8 121.6 lerna info Executing command in 16 packages: "yarn run build"
#8 122.0 @lodestar/params: $ tsc -p tsconfig.build.json
#8 122.0 @lodestar/utils: $ tsc -p tsconfig.build.json
#8 136.3 @lodestar/types: $ tsc -p tsconfig.build.json
#8 137.4 @lodestar/spec-test-util: $ tsc -p tsconfig.build.json
#8 153.8 @lodestar/config: $ tsc -p tsconfig.build.json
#8 167.8 @lodestar/db: $ tsc -p tsconfig.build.json
#8 167.8 @lodestar/api: $ tsc -p tsconfig.build.json
#8 187.5 @lodestar/reqresp: $ tsc -p tsconfig.build.json
#8 [194](https://github.com/Savid/lodestar/actions/runs/4591419949/jobs/8107563547?pr=1#step:7:198).9 @lodestar/state-transition: $ tsc -p tsconfig.build.json
#8 [207](https://github.com/Savid/lodestar/actions/runs/4591419949/jobs/8107563547?pr=1#step:7:211).9 @lodestar/light-client: $ tsc -p tsconfig.build.json
#8 [219](https://github.com/Savid/lodestar/actions/runs/4591419949/jobs/8107563547?pr=1#step:7:223).6 @lodestar/flare: $ tsc -p tsconfig.build.json
#8 229.9 @lodestar/light-client: src/spec/utils.ts:13:34 - error TS2307: Cannot find module '@lodestar/state-transition' or its corresponding type declarations.
#8 229.9 @lodestar/light-client: 13 import {computeEpochAtSlot} from "@lodestar/state-transition";
#8 229.9 @lodestar/light-client:                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#8 229.9 @lodestar/light-client: Found 1 error in src/spec/utils.ts:13
#8 230.0 @lodestar/light-client: error Command failed with exit code 2.
#8 230.0 @lodestar/light-client: info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
#8 230.0 lerna ERR! yarn run build exited 2 in '@lodestar/light-client'
#8 230.1 lerna WARN complete Waiting for 2 child processes to exit. CTRL-C to exit immediately.
#8 230.1 error Command failed with exit code 2.
#8 230.1 info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
#8 ERROR: process "/bin/sh -c yarn install --non-interactive --frozen-lockfile &&   yarn build &&   yarn install --non-interactive --frozen-lockfile --production" did not complete successfully: exit code: 2
------
 > [build_src 5/6] RUN yarn install --non-interactive --frozen-lockfile &&   yarn build &&   yarn install --non-interactive --frozen-lockfile --production:
#8 [229](https://github.com/Savid/lodestar/actions/runs/4591419949/jobs/8107563547?pr=1#step:7:233).9 @lodestar/light-client: src/spec/utils.ts:13:34 - error TS2307: Cannot find module '@lodestar/state-transition' or its corresponding type declarations.
#8 229.9 @lodestar/light-client: 13 import {computeEpochAtSlot} from "@lodestar/state-transition";
#8 229.9 @lodestar/light-client:                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#8 229.9 @lodestar/light-client: Found 1 error in src/spec/utils.ts:13
#8 230.0 @lodestar/light-client: error Command failed with exit code 2.
#8 230.0 @lodestar/light-client: info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
#8 230.0 lerna ERR! yarn run build exited 2 in '@lodestar/light-client'
#8 230.1 lerna WARN complete Waiting for 2 child processes to exit. CTRL-C to exit immediately.
#8 [230](https://github.com/Savid/lodestar/actions/runs/4591419949/jobs/8107563547?pr=1#step:7:234).1 error Command failed with exit code 2.
#8 230.1 info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
------
./Dockerfile:11
--------------------
  10 |
  11 | >>> RUN yarn install --non-interactive --frozen-lockfile && \
  12 | >>>   yarn build && \
  13 | >>>   yarn install --non-interactive --frozen-lockfile --production
  14 |
--------------------
ERROR: failed to solve: process "/bin/sh -c yarn install --non-interactive --frozen-lockfile &&   yarn build &&   yarn install --non-interactive --frozen-lockfile --production" did not complete successfully: exit code: 2

Steps to test or reproduce
Example build workflow https://github.com/Savid/lodestar/blob/missing-dep-test/.github/workflows/build.yml
Example failed build (current unstable) https://github.com/Savid/lodestar/actions/runs/4591419949/jobs/8107563547
Example successful build (this pr) https://github.com/Savid/lodestar/actions/runs/4591451782/jobs/8107617203

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@Savid Thanks for your contribution and the thorough description :)

:tada: This PR is included in v1.8.0 :tada:


LSTM with Batch Normalization

Simplified LSTM with Batch Normalization from the paper Recurrent Batch Normalization.
The main simplification is that the same gamma is used on all steps.
This PR is for Keras-0. I will merge to Keras-1 once its out of preview

is there a way to make a recurrent batch normalization module that can be used by any type of recurrent layer? Something like a model that gets an RNN layer as input? Or is this too layer specific?
Also, how much improvement did you observe in your tests?

I had to dig into LSTM re-code it a little bit so it is not possible to do it in a generic way without re-writing the existing Recurrent units (which is not  a lot of work)
I had huge improvement in speed and in the total loss I reached.
doing more tests....

That is pretty good!!!

here is an aside: both dropout and batchnorm should be kept the same throughout the entire run. It is something that makes sense. Dropout is meant to drop weights and not activations.
Maybe in the future we should look into the way we write RNNs in Keras to support dropout and batchnorm callbacks in a generalized way. This will make it easy to support more complicated and custom RNN types (like neural-gpu and conv-rnns) without having to rewrite them.
Any ideas on how to implement RNN callbacks @fchollet, @farizrahman4u ? Can Keras-1 help with that?

actually the paper Recurrent Batch Normalization said they got better results when different BN parameters are used in each step of the LSTM iteration. This would have complicated the code a lot, add a lot of memory consumption and also the implementation of the papers author that I found did not do it
https://github.com/cooijmanstim/Attentive_reader/blob/bn/codes/att_reader/layers.py#L33

For now I only tested on Theano... which takes ages to compile.

It's great to have this implementation available, but at the same time I don't think we should have more than one implementation of LSTM in Keras. Either we should figure out how to make BatchNorm part of the current implementation, or we should make the BN LSTM implementation part of a Keras extensions package (like @EderSantana's Seya).

Ok, I will add it as a parameter to the existing LSTM

I merged the BN code into LSTM class. I removed some of the usual BN parameters from the interface because I believe there is no need to touch them and they would have made the LSTM API even more complex.
This PR also fix a bug that was hidden in several places in the code in which nb_param in set_weights method was computed directly (and wrongly) instead of using len(self.get_weights()) or something similar. This bug showed up only when you start to merge models that have non_trainable_weights such as BatchNormalization and now LSTM and I had to fix it to complete my tests.

In any case, we won't merge anything into Keras 0, the current version is considered final. All new PRs should be made to Keras-1, because that branch will replace master rather than be merged into master.

Ok, it's too much for me (and my GPU) to switch between two versions of Keras so once I personally switch to Keras-1 I will also make a new PR. We can keep this PR as-is for anyone who wants it.

Cool, you can just adapt it to Keras 1 (Lstm hasn't changed much) and resubmit it after Keras 1 is officially released.

Primary author here, just wanted to confirm that we do use the same gamma/beta on all steps. Only the statistics can differ over time, not the parameters.
The code looks right to me, though I don't understand how/where Keras manages the updates. Thanks for making this available!

Hi Tim,
If you mean how gamma is being updated? this is eventually done through theano's mechanism of updating shared variables. http://deeplearning.net/software/theano/tutorial/examples.html#using-shared-variables

The part that confuses me is that the updates added to self.updates in the bn method use variables from the inner graph of the scan op. Somewhere along the line these have to be translated into the corresponding outer variables, but I don't see where this is done.

looks like I already explained this in the code:
https://github.com/udibr/keras/blob/lstmbn/keras/layers/recurrent.py#L171-L175

any progress?

This looks awesome. Is it ready for merge?

@udibr I'll try to port your code into keras 1, if you haven't yet.

@xingdi-eric-yuan I have a working version of LSTM BN on a branch called mymaster https://github.com/udibr/keras/blob/mymaster/keras/layers/recurrent.py#L583
The version in the original PR (for Keras 0.3) is incorrect. As @cooijmanstim hinted we are updating the mean/var at every step of the LSTM and if you want to have a generic solution you should somehow allow the step function to accept the mean/var as input to each step and give the updated values as output of each step. My new code on mymaster branch does this but it is very convoluted code which I am not too proud off and as it is now, I think it really should be outside of Keras (see what @fchollet said about Seya) or at least in separate class from LSTM. Please update me if you look into it and manage to clean it up or of course find bugs.
I played with it a little bit on real examples and it looks like the LSTM+BN mechanism slows run time and on the other side cause overfitting. So it is not just turning the batch_norm flag to True. You need to change the model size to get comparable results. Maybe you can end up with a smaller/faster model but I'm not sure.

@udibr Thanks for pointing it out, I'll look into it 👍

@fchollet
I tried to implement BN on keras 1 (not fully finished yet), and tested on CPU.
I used this code for testing, but modified the hyper parameters  a bit (cause my cpu sucks), it makes no sense to compare with this results, but one can see the relative running time.
I'll continue on this.
Testing mode: consume_less='gpu', batch_norm = True
('----------------------------------------------------------------------', 62.31635642051697)
Testing mode: consume_less='cpu', batch_norm = True
('----------------------------------------------------------------------',<PHONE_NUMBER>1087494)
Testing mode: consume_less='mem', batch_norm = True
('----------------------------------------------------------------------', 97.5029529094696)
Testing mode: consume_less='gpu', batch_norm = False
('----------------------------------------------------------------------', 21.828416299819946)
Testing mode: consume_less='cpu', batch_norm = False
('----------------------------------------------------------------------', 25.393872904777528)
Testing mode: consume_less='mem', batch_norm = False
('----------------------------------------------------------------------', 26.102502298355102)

same setting for GRU (cpu)
Testing mode: consume_less='gpu', batch_norm = True
('----------------------------------------------------------------------', 55.459453320503236)
Testing mode: consume_less='cpu', batch_norm = True
('----------------------------------------------------------------------', 75.9599426984787)
Testing mode: consume_less='mem', batch_norm = True
('----------------------------------------------------------------------', 66.78091099262238)
Testing mode: consume_less='gpu', batch_norm = False
('----------------------------------------------------------------------', 21.641224408149718)
Testing mode: consume_less='cpu', batch_norm = False
('----------------------------------------------------------------------', 19.828516912460326)
Testing mode: consume_less='mem', batch_norm = False
('----------------------------------------------------------------------', 20.900050902366637)

So what are we going to do with this PR, and with BN for RNNs in general?

I think it really should be outside of Keras

Yes, maybe. I see quite a bit of interest for this feature, coming from advanced users. But do the results delivered justify the interest? For users, is the runtime performance cost justified by superior learning performance? And for us developers, is the added codebase complexity and maintenance cost justified by the usefulness of the feature?

I now think it should be outside. I'm sorry @cooijmanstim but it looks less exciting.
Also I tried to merge my working version (on mymaster branch) to this pull request branch so that other users will not accidently start working from the wrong version but there were few changes in the master LSTM and so now some real merge work should be done. Also as @xingdi-eric-yuan found out some work is needed to make it work on tf.

I see quite a bit of interest for this feature, coming from advanced users.  But do the results delivered justify the interest? For users, is the runtime performance cost justified by superior learning performance? And for us developers, is the added codebase complexity and maintenance cost justified by the usefulness of the feature?

@fchollet  -- what about a second repo, one where things are a little more 'wild west', but solutions like this are integrated.  I see many comments around the slack/google group/github issues that indicate people are recreating many wheels with keras.  for example, I have a decent attention mechanism and I've seen at least 3 separate people also implement their own.
and it wouldn't be without precedent.  Lasagne has Recipes.  Blocks has blocks-extras.  I'd be willing at least assist with PRs provided that I didn't have to maintain API consistency the way you are (excellently) doing with keras.  given wild-west status, I think it might be nice.

To avoid future confusion  I moved my code back to my lstmbn branch of my code which was used in this PR.
I also put all my changes in a separate class LSTMBN so there will be no conflicts with keras master LSTM which is all the time changing. I also fixed a bug that @xingdi-eric-yuan found (thanks!)
HOWEVER, I did not run any tests on LSTMBN and I closed this PR and I dont think it should be merged with keras/master.

@braingineer the problem with a keras-extras repository is maintenance. Keras is changing all the time (in a good way) but every time it changes someone needs to go back and make sure that all the add-ons continue to work.
There were several attempts to create keras-extras such as Seya and seq2seq but as far as I know currently both repos do not work because of changes in Keras 1.

@udibr that makes sense. I think if they were the combined personal libraries of some of the more prolific keras users, it would have a higher chance of being maintained.
Plus, the wild-west status wouldn't have to guarantee if everything worked.  It could come with the academic guarantee, so to speak ('it worked for me once, but I give no promises after that').  Even having it be in a central place without compatibility with some new version would be useful.  someone could come along and decide to port it, as a way to contribute.
I think, though, minimally, there should at least be an index of personal keras libraries and it should be pointed at by keras master (by a link or, more generously, a page in the docs).   right now, there is a loose set of repositories and gists that you have know about in order to find (for example, seya and seqtoseq).

@braingineer How about this wiki page https://github.com/fchollet/keras/wiki/Built-with-Keras

That's awesome.  I would consider it the minimum level though.  Also, did not realize there was a wiki, so it could use some more sign posting for it.  It's not mentioned anywhere (I don't think).
I feel that something like the awesome series would be a better minimum (aka https://github.com/kjw0612/awesome-rnn) and it should/could have a blurb about it (a natural place would be near the mention of the examples page where it says In the examples folder of the repository, you will find more advanced models: question-answering with memory networks, text generation with stacked LSTMs, etc.)

@barvinograd @udibr   Hi, does this work now?  Thanks!

Has this been updated for Keras 1.x? It'd be very useful for what I'm working on right now.

Has anyone tried this with sampling ? I was unable to make this work in sampling mode. Any pointers ?

@fchollet @braingineer @udibr @xingdi-eric-yuan What was the group decision on whether BN for RNN belongs in Keras?

HOWEVER, I did not run any tests on LSTMBN and I closed this PR and I dont think it should be merged with keras/master.

@udibr Why was your final conclusion that your LSTMBN class should not be merged in to Keras?
Further questions:

Your latest LSTMBN implementation is for Keras 1.x correct?
What should in your opinion be done to make it Keras 'worthy'?

Thanks,
-- Freddy Snijder

@udibr  Have you tried this method? I have had some experiments, Using population statistics (training: False) at test time gives worse results than batch statistics. I don't know why?


replaced autopep8

improved method of pep8 formatting
can be duplicated locally
popular formatter (black)
skips CI on new commits

Codecov Report

Merging #15 (9375d01) into develop (55f12a7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop      #15   +/-   ##
========================================
  Coverage    98.52%   98.52%
========================================
  Files            3        3
  Lines           68       68
========================================
  Hits            67       67
  Misses           1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55f12a7...9375d01. Read the comment docs.


change(phishing-controller): validate hostname is provided to phishing-controller test and bypass methods

Explanation
This pull requests introduces validation to the phishing-controller test and bypass methods to ensure that the value being provided is a hostname. The way the code is currently written suggests to the consumer that an origin should be provided.
However, this is problematic given that our phishing list contains hostnames not domains (see here). This can also be validated checking our API endpoint.
While we currently do not pass in an origin to either of these functions, the impact of doing so would result in our phishing detection mechanisms failing. This is because https://evil.com would not match with evil.com/
In order to minimize the potential for an origin to be passed in, this PR adds validation to better catch implementation errors during development cycles. It does so by raising an error.
Reasons not to make this change
I had debated whether this change would have fit better in the eth-phishing-detect detector itself. However, I decided on implementing it here as its the place that developers will most likely be looking to for guidance on how to best implement their integrations with the phishing controller.
This does have tradeoffs, as now the controller is opinionated about the type of input provided. This may or may not be desired and is open to discussion.
In addition, we may prefer to accept full URL's and have the phishing controller do the parsing itself to minimize the burden on external consumers.
References
Changelog
@metamask/phishing-controller

BREAKING: #test and #bypass raise an error if input other than a hostname is provided to

We recommend using new URL("...").hostname or other mechanisms to pass the hostname instead of the full origin to the phishing controller functions.

BREAKING: Controller action handler renamed from PhishingController:testOrigin to PhishingController:testPhishing

Checklist

[x] I've updated the test suite for new or updated code as appropriate
[x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
[x] I've highlighted breaking changes using the "BREAKING" category above as appropriate

@NicholasEllul Hey, sorry for the late reply on the SnapInterfaceController error you saw above.
If I'm not mistaken, what appears to be happening is that the assets-controllers package relies on snaps-controller, and snaps-controller relies on phishing-controller (which is the version of phishing-controller in your branch and not on NPM). So in order for the whole monorepo to build, phishing-controller needs to have a TestOrigin export.
What are your thoughts on keep the old event type present, but not use it in any way? Then the monorepo would build, and then we could update snaps-controller to use a new version of phishing-controller that exports TestPhishing instead of TestOrigin, and then we could remove TestOrigin in another release.


Target-side command execution

This is in response to #329. The example that goes with it is on GMaps, but this uses another PR from devlib (https://github.com/ARM-software/devlib/pull/127), so it cannot be merged yet but is up for comments.
I've looked at the traces on kernelshark, and adbd is running only at the very start & end of the workload, which is a good start.

Updated the branch following @bjackman's recommendation. Accumulator/dry-run is now done in LISA instead of devlib.

I've stumbled on a thing that can extract the decorators of a class' methods: https://stackoverflow.com/a/31197273
The end result works, but it's definitely hacky. Still, Target's memoized attributes should be safe to call - tell me what you think about it.

Phwoar that solution is pretty badass.. but IMO too extreme (IIUC it's actually parsing the Python code...) given that it's possible for us to modify devlib. To be honest the whole dummy execute is a bit scary so I prefer a whitelist to avoid spreading usage too far (we can always get rid of the whitelist once we have some confidence in the usage model/API/implementation design).

Yeah, that class has pretty much turned into a playground for me to have (too much) fun with Python. I'll go with a whitelist for now.

Added an append method to manually add some commands to the script, instead of using the internal list object.

can we just add a micro documentation for both execute and the new append methods?

Same for the TargetScript class.. can you add a description of what the ctor parameters define?

Added proper documentation


Unable to load the model

It fires up the following error while trying to load the model
`

tensorflow.python.framework.errors_impl.NotFoundError: Op type not registered 'Resampler' in binary running on DESKTOP. Make sure the Op and Kernel are registered in the binary running in this process. Note that if you are loading a saved graph which used ops from tf.contrib, accessing (e.g.)tf.contrib.resampler should be done before importing the graph, as contrib ops are lazily registered when the module is first accessed.

`

The code uses the tf.contrib.resampler, which does not seems to have a different name in TF >=2.0. I did not test this code for TF >=2.0 and do not plan to make it compatible.

i'm having the same issue w/ tf 1.12.0


Triage/fix remounting behavior in ResultsCard

ResultsCard uses a Function as Child Component approach or FaCC.  It's like the render prop pattern but uses children to pass the function.  See https://americanexpress.io/faccs-are-an-antipattern/.
This SO mentions remounting behavior due to an inline function which may be what we are experiencing in GP.  We have long running code in our child function component, and we aren't able to memoize it, the child component seems to keep remounting (worth confirming, see https://brycedooley.com/debug-react-rerenders/)
It makes me think ResultsCard could be rewritten to have children receive their data via props instead of this inline function call.  Or maybe just switch to a render prop pattern instead of using children.  Would need to play around to see how this would work.

Further hints at the issue (I think)

if we create a function assigned inside the render method. The shallow prop comparison always returns false for new props, and, in this case, each render generates a new value for the render prop. For more details, refer to the React docs.

The problem is ResultsCard can't receive the data as a prop because the data is returned from useFunction inside the results card.  So the results aren't available when ResultsCard is loaded but at a later time, which are then passed to the child function

Closing this as no known solution at this time.  I do believe the best solution is memoization inside the child function instead


Updated Login page

organized forms on the login page to be more organized, added a logo for seamless transition from intro page and added a welcome to the top of the intro page

Fixes #72


Button-styled links in the topbar (2.0 wip)

Loving 2.0 so far!
I'd like a link styled button in the navbar. Right now, doing so doesn't work (which I assume is a bug). I simply added 'class="btn"' to examples/container-app.html About link as an example: http://i.imgur.com/joOHS.png
The purpose is that these links should be modal triggers when javascript is enabled, but it should direct to the user to the appropriate page if javascript is disabled.
Thanks!

A link doesn't have to be styled as a button to trigger a modal window.
Check out this example: http://jsfiddle.net/RbsQS/

You can't add .btn to any link in the .nav in .navbar. Buttons have to be separate links otherwise they inherit the .nav > li > a styles.

yes cgunther, i know, but like I said I want my site to work for people without using javascript.
i also understand the technical limitations, but it's more of a "we can't do it due to the way it's setup now" vs. a "we won't do it because it doesn't make sense from a design perspective".
thanks, but i hope you keep this in mind in the future (I know you guys got bigger things to deal with).

@jonathanong If you look at the jsfiddle, it does have a non-js fallback. Look at the Javascript, all the way at the bottom, and then click the About link in the navbar.
The only thing that jsfiddle is missing from your request is the button styling, which as Mark said, can be done by not using the .nav wrapper.

yes, but the button styling was the entire request, not the non-js fallback which I already know about. thanks for the help though.

do you have a suggestion on how to have a button in the navbar that goes to another page if javascript is disabled?

Skip the ul.nav container and just add an a.btn:
http://jsfiddle.net/NrL64/1/

yep, that works! thanks!


Database/models And LOGIN SIGNUP routes

For issue #137

hi @samar12-rad please join our discord
https://discord.gg/Jh3bWQ7FRN

hi @samar12-rad please join our discord https://discord.gg/Jh3bWQ7FRN

done


.hlint holds the foldrM rule, but relude does not provide foldrM

Currently foldrM is (nor reexported) (nor provided), so HLint rule:
https://github.com/kowainik/relude/blob/943b8864bae8c149c611b7e5629cf37289a99a25/.hlint.yaml#L1732-L1736
does not hold true.

Thanks. Fixed in main.


get_vertices  in convert_osm_network not defined

Hello Sam,
Im trying to use JEMSS for the city Hamburg and  downloaded a osm file and removed non-road objects via osmconvert.  Next I wanted to calculate road arc travel times and write to csv via your run.jl code. I got this error:
ERROR: UndefVarError: get_vertices not defined
Stacktrace:
[1] readOsmNetworkFile(osmFilename::String; levels::Set{Int64}, boundsLLA::Nothing)
@ Main ~/.julia/packages/JEMSS/M2vZd/tools/network/convert_osm_network.jl:57
I think the function osm.getvertices  in convert_osm_network.jl code is not part of the package OpenStreetMapX anymore. Do you have a solution for that issue?
Thank you in advance and best regards.
Elias

Hi Elias,
I've made an attempt at updating the code, can you try the run.jl script (along with convert_osm_network.jl and graph_tools.jl in the same folder) from this zip file convert_osm_network.zip.
Please let me know if there are errors, if not I'll then use this code to update the package.

Hey Sam, thanks for the fast reply.
I got this error now:
Dividing arcs ... done.
Checking which nodes (of 140138) are inside border
ERROR: UndefVarError: linearrings not defined
I have another general question..:
I got for hamburg the same data and put it in the same folder structure as the other cities in the data folder. Next step is to create a road file with run.jl and if I don't have my own data for calls, I use the call configuration file. Are there any other steps to take?
I appreciate your help and thank you for your work and the code you provided.

Ah, I see I changed a variable name at the last moment causing the linearrings not defined error, here's the fixed script convert_osm_network.zip.
Once you have all the data and files set up like in a data/cities/[city]/models folder then copy one of the sim_config.xml files like in the example/input folder and make sure the <inputPath> and <simFiles> point to your data (though ignore <rNetTravels> as that will be generated). Then try load and run the simulation and if that doesn't work let me know.

Hey Sam, thanks a lot, I think your code is working fine now
I tried to run this for my hamburg files and to be honest, I dont have that much experience with Geo Data files, but I tried to follow your Guide Step by Step.. I downloaded an .osm file from GeoFabrik (https://download.geofabrik.de/europe/germany/hamburg.html) and used osmfilter to remove non-road objects from the osm file. I created the other files like in Auckland and now I got this error.. I hope you can help
Checking which nodes (of 68159) are inside border
node: 68000    done
┌ Warning: Code to check that nodes are inside the border is not guaranteed to be correct; please check that output is as expected.
└ @ Main ~/Downloads/convert_osm_network (2)/run.jl:103
Setting arc time matrix / dict
arc: 132000
Calculating shortest paths
mode: 1
origin node: 1 (of 1)
dest node: 1 (of 1)
mode: 2
origin node: 1 (of 1)
dest node: 1 (of 1)
┌ Warning: Arc from/to node indices are not all within 1:numNodes
└ @ Main ~/Downloads/convert_osm_network (2)/graph_tools.jl:39
ERROR: BoundsError: attempt to access 0-element Vector{Arc} at index [1]
Stacktrace:
[1] getindex
@ ./array.jl:924 [inlined]
[2] getNumTravelModes
@ ~/Downloads/convert_osm_network (2)/graph_tools.jl:54 [inlined]
[3] getArcsTravelTimes(arcs::Vector{Arc})
@ Main ~/Downloads/convert_osm_network (2)/graph_tools.jl:70
[4] top-level scope
@ ~/Downloads/convert_osm_network (2)/run.jl:128
Thank you.

I used these files:
hamburg_border.zip
hamburg_main_roads_tertiary+_unclassified1.osm.zip
hospitals_1.csv
map_1.csv
stations_1.csv

Hey Sam, fyi your script is working perfectly now..
I tried to run the simulation for hamburg, but I think my grid for the population density is not correct.
I got this error:
Loading sim.

Hey Elias,
It could be the population density file or maybe the map.csv file, if the map file you linked before is what you are currently using then it needs to be changed, see here.
As for the population density file, I used QGIS to create them, first saving the shapefile with population density information in the WGS84 format then using rasterize functionality to create the raster file.


Implement support for additional costs

Name the task.
Add additional cost calculations. Needed for grid-price and such.
How to solve the task
..
Additional context
..

Wouldn't it make sense that the price information this integration subscribes to already has that "built-in"? Both Nordpool and ENTSO-E supports doing this already


Reduce copyright info in each file header and just reference LICENSE file

Instead of that long MIT license text in each file header, we should reduce that to something like:
/*
 * This file is part of the rdfinterface package and licensed under the terms of the MIT-license.
 *
 * (c) XXX <YYY>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

I like the style of the Symfony project, for instance: https://github.com/symfony/symfony/blob/5.x/src/Symfony/Component/Form/AbstractExtension.php#L3-L10

we should reduce that to something like:

"Should" is a strong word. "May" is a better one.
Anyway, this header is automatically generated by the IDE so I don't see any benefit from making it shorter or longer. It doesn't make anything easier, e.g. if we decide to change a license we anyway must find and replace in all files (as even the short header you propose contains the license name). And until changing to short ones provides no benefit and costs some (even short) time, I don't see a reason to introduce the change.
Could you provide any practical reason for such a change?

we should reduce that to something like:

"Should" is a strong word. "May" is a better one.
Anyway, this header is automatically generated by the IDE so I don't see any benefit from making it shorter or longer. It doesn't make anything easier, e.g. if we decide to change a license we anyway must find and replace in all files (as even the short header you propose contains the license name). And until changing to short ones provides no benefit and costs some (even short) time, I don't see a reason to introduce the change.
Could you provide any practical reason for such a change?

Anyway, this header is automatically generated by the IDE so I don't see any benefit from making it shorter or longer.

Ah OK. If your IDE handles it for you, its fine to leave it as it is. I use Visual Studio Code and add/adapt these manually, so I thought you do it the same way.

Anyway, this header is automatically generated by the IDE so I don't see any benefit from making it shorter or longer.

Ah OK. If your IDE handles it for you, its fine to leave it as it is. I use Visual Studio Code and add/adapt these manually, so I thought you do it the same way.

Looks like there is a plugin for the VSC for that - see https://stackoverflow.com/questions/38823319/automatically-add-copyright-banner-in-vs-code

Looks like there is a plugin for the VSC for that - see https://stackoverflow.com/questions/38823319/automatically-add-copyright-banner-in-vs-code

I run PHP-CS-Fixer from time to time to not only keep my coding styles but also keep file headers up to date.


Issue when using custom built-in function to calculate hash of input

While applying JIT-Picker to v8 engine, I see that when we use a built-in or native function fuzzilli_hash to calculate hash of a variable inside an optimized function, the engine will bailout of optimization due to code dependency
Is it intended behavior? Or do we need to implement a transparent probe function like your paper mentioned for SpiderMonkey engine?

The transparent probing is implemented for SpiderMonkey only. Hence having less aggressively optimized code in v8 is expected. This is not on purpose, but a limitation of the current implementation.


Add a new Communication app that manages all of Oscar's communications.

This is a rebase of #2591, which has been reviewed. @craigloftus could you please have a quick final scan of this before we merge?

@craigloftus I've addressed your comments. Also regenerated migrations to as few as possible.

Great job on this @sasha0 @samitnuk .


Board descriptions for computers and machines

About the PR
Self explanatory. Was looking at boards for some reason and came across some TODO's. This PR does the following:

Changed some console names into computers (all except shuttle console as ID is console too).
Made all names lower case as we had a mixed bag of mostly PascalCase names which is not convention.
Added descriptions to all electronics, machine and computer boards which state in their second word if it is for a machine, computer or electronics, just for added clarity.
Changed the sprite for computers to mainboard so they differ from machine boards for that extra clarity at a glance.
Made firealarm sprite match the airalarm for now since they're both atmos alarms. Made sense in my head, can change the firealarm to red outline if it matters.
RE ID'd the reagentgrinder board from KitchenReagentGrinderMachineCircuitboard to ReagentGrinderMachineCircuitboard.
Also fixed SMES construction in this PR.
Also Also added in all missing boards to the game for computers since deconstructing some that are mapped in produced nothing making people think it was a bug.
Also Also Also decided to add the criminal records computer while we're here so the asset is ready to be mapped for future functionality. UI and database stuff isn't my game so I'll leave that to someone else. Modified the generic sprite for it too since the current sec one was poo.

Screenshots

Computer boards are now:

Instead of:

Changelog

:cl:

fix: All electronics, machine and computer boards now have updated names, descriptions and in some cases sprites.
fix: SMES construction is now fixed.
add: There's now computer boards for all computers on the station...some still don't do anything.

I don't really like the boards being called "PCBs", honestly.
And this makes it harder to tell at a glance whether a board goes in a machine frame or a computer frame

Different colors maybe for machine/computer boards? Instead of the green?

I don't really like the boards being called "PCBs", honestly. And this makes it harder to tell at a glance whether a board goes in a machine frame or a computer frame

How come? Before this all boards looked the same, now machine boards are the typical boards we have now and computer boards are the bigger variant so at a glance without even examining you know what it is for.
As for naming I unified them to PCB since they will ultimately be made on a printer. I can change it back to board but I'm not torn either way. Just thought we'd progress a little. The descriptions have what they are for in the first two words too. Want to go back to boards for all? Or would you prefer to have the name of what it's for in the name as well as description?
As for colours, they're usually used for specific boards e.g. red being security, high value or syndicate.

It doesn't matter too much to me whether it's board or PCB. Maybe some screenshots will help decide?

@ShadowCommander As requested, small gif showing them off. A selection of machine boards at the top (In entity menu they still show as [machine board], and bottom are all computer boards (different sprite now to differentiate).
Also a selection of electronics on the left which are the specific boards for things like airlocks, fire alarms, solar trackers etc.

Decided to just revert back to naming everything machine board and computer board. Also updated some consoles to computers for consistency.

conflicts

Does this have any problems with maps that have a ReagentGrinder since it got renamed?

Does this have any problems with maps that have a ReagentGrinder since it got renamed?

The reagent grinder itself is still called a kitchenreagentgrinder. Probably because it looks like a mixer. But I'll have to wait till maps are merged if ya'll want it changed. There's no construction for them yet either so nothing to change there.


Not working with android

Ever since yesterday (5/27), I have noticed that ankimote no longer works with my phone (samsung s8+). After scanning the QR code with my phone, the webpage pops up but it cannot load the proper page.
I tried using my friend's iphone and it worked fine.
Could you fix this issue? Or is there an alternative method for androids to use ankimote now?
Thank you!

The problem probably isn’t an Android vs iPhone problem. Check to make sure your phone isn’t on VPN, that your phone and computer are on the same WiFi network, and also try clearing the browser history and cache on your phone. Might also be worth it to try a different browser on the phone. Good luck!
On May 28, 2021, 6:09 PM -0400, TurtleEd @.***>, wrote:

Ever since yesterday (5/27), I have noticed that ankimote no longer works with my phone (samsung s8+). After scanning the QR code with my phone, the webpage pops up but it cannot load the proper page.
I tried using my friend's iphone and it worked fine.
Could you fix this issue? Or is there an alternative method for androids to use ankimote now?
Thank you!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

I have tried all of that and still no luck. I also tried my friend's
android phone (also an s8 and that also didn't work). I have also tried
going on a different wifi network. I have also tried u installing anki and
reinstalling it. Nothing seems to be working
On Sat, May 29, 2021, 4:51 AM TheDabblingDuck @.***>
wrote:

The problem probably isn’t an Android vs iPhone problem. Check to make
sure your phone isn’t on VPN, that your phone and computer are on the same
WiFi network, and also try clearing the browser history and cache on your
phone. Might also be worth it to try a different browser on the phone. Good
luck!
On May 28, 2021, 6:09 PM -0400, TurtleEd @.***>, wrote:

Ever since yesterday (5/27), I have noticed that ankimote no longer
works with my phone (samsung s8+). After scanning the QR code with my
phone, the webpage pops up but it cannot load the proper page.
I tried using my friend's iphone and it worked fine.
Could you fix this issue? Or is there an alternative method for androids
to use ankimote now?
Thank you!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/TheDabblingDuck/ankimote/issues/23#issuecomment-850845914,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUIPFNOPTT5QNZCCIWHI5K3TQD5OVANCNFSM45XRWXSQ
.

Update: I tried it with an iphone 7 and it didn't work, but I tried it with
an iphone 11 and it did work.
On Sat, May 29, 2021 at 8:22 AM Edward Nguyen @.***> wrote:

I have tried all of that and still no luck. I also tried my friend's
android phone (also an s8 and that also didn't work). I have also tried
going on a different wifi network. I have also tried u installing anki and
reinstalling it. Nothing seems to be working
On Sat, May 29, 2021, 4:51 AM TheDabblingDuck @.***>
wrote:

The problem probably isn’t an Android vs iPhone problem. Check to make
sure your phone isn’t on VPN, that your phone and computer are on the same
WiFi network, and also try clearing the browser history and cache on your
phone. Might also be worth it to try a different browser on the phone. Good
luck!
On May 28, 2021, 6:09 PM -0400, TurtleEd @.***>, wrote:

Ever since yesterday (5/27), I have noticed that ankimote no longer
works with my phone (samsung s8+). After scanning the QR code with my
phone, the webpage pops up but it cannot load the proper page.
I tried using my friend's iphone and it worked fine.
Could you fix this issue? Or is there an alternative method for
androids to use ankimote now?
Thank you!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/TheDabblingDuck/ankimote/issues/23#issuecomment-850845914,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUIPFNOPTT5QNZCCIWHI5K3TQD5OVANCNFSM45XRWXSQ
.

--
We can learn things by reading books or watching television but unless we
experience them for ourselves we wont truly understand.

I also tried it with my ipad 7 and it didn't work.
On Sun, May 30, 2021 at 5:14 PM Edward Nguyen @.***> wrote:

Update: I tried it with an iphone 7 and it didn't work, but I tried it
with an iphone 11 and it did work.
On Sat, May 29, 2021 at 8:22 AM Edward Nguyen @.***>
wrote:

I have tried all of that and still no luck. I also tried my friend's
android phone (also an s8 and that also didn't work). I have also tried
going on a different wifi network. I have also tried u installing anki and
reinstalling it. Nothing seems to be working
On Sat, May 29, 2021, 4:51 AM TheDabblingDuck @.***>
wrote:

The problem probably isn’t an Android vs iPhone problem. Check to make
sure your phone isn’t on VPN, that your phone and computer are on the same
WiFi network, and also try clearing the browser history and cache on your
phone. Might also be worth it to try a different browser on the phone. Good
luck!
On May 28, 2021, 6:09 PM -0400, TurtleEd @.***>, wrote:

Ever since yesterday (5/27), I have noticed that ankimote no longer
works with my phone (samsung s8+). After scanning the QR code with my
phone, the webpage pops up but it cannot load the proper page.
I tried using my friend's iphone and it worked fine.
Could you fix this issue? Or is there an alternative method for
androids to use ankimote now?
Thank you!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/TheDabblingDuck/ankimote/issues/23#issuecomment-850845914,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUIPFNOPTT5QNZCCIWHI5K3TQD5OVANCNFSM45XRWXSQ
.

--
We can learn things by reading books or watching television but unless we
experience them for ourselves we wont truly understand.

--
We can learn things by reading books or watching television but unless we
experience them for ourselves we wont truly understand.

update: I turned off my firewall for mcafee and it started working again.
Do you have any advice on how to allow exceptions for ankimote through
mcafee firewall?
On Sun, May 30, 2021 at 5:16 PM Edward Nguyen @.***> wrote:

I also tried it with my ipad 7 and it didn't work.
On Sun, May 30, 2021 at 5:14 PM Edward Nguyen @.***>
wrote:

Update: I tried it with an iphone 7 and it didn't work, but I tried it
with an iphone 11 and it did work.
On Sat, May 29, 2021 at 8:22 AM Edward Nguyen @.***>
wrote:

I have tried all of that and still no luck. I also tried my friend's
android phone (also an s8 and that also didn't work). I have also tried
going on a different wifi network. I have also tried u installing anki and
reinstalling it. Nothing seems to be working
On Sat, May 29, 2021, 4:51 AM TheDabblingDuck @.***>
wrote:

The problem probably isn’t an Android vs iPhone problem. Check to make
sure your phone isn’t on VPN, that your phone and computer are on the same
WiFi network, and also try clearing the browser history and cache on your
phone. Might also be worth it to try a different browser on the phone. Good
luck!
On May 28, 2021, 6:09 PM -0400, TurtleEd @.***>, wrote:

Ever since yesterday (5/27), I have noticed that ankimote no longer
works with my phone (samsung s8+). After scanning the QR code with my
phone, the webpage pops up but it cannot load the proper page.
I tried using my friend's iphone and it worked fine.
Could you fix this issue? Or is there an alternative method for
androids to use ankimote now?
Thank you!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/TheDabblingDuck/ankimote/issues/23#issuecomment-850845914,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUIPFNOPTT5QNZCCIWHI5K3TQD5OVANCNFSM45XRWXSQ
.

--
We can learn things by reading books or watching television but unless we
experience them for ourselves we wont truly understand.

--
We can learn things by reading books or watching television but unless we
experience them for ourselves we wont truly understand.

--
We can learn things by reading books or watching television but unless we
experience them for ourselves we wont truly understand.

That's between you and mcafee
On Jun 4, 2021, 3:55 PM -0400, TurtleEd @.***>, wrote:

update: I turned off my firewall for mcafee and it started working again.
Do you have any advice on how to allow exceptions for ankimote through
mcafee firewall?
On Sun, May 30, 2021 at 5:16 PM Edward Nguyen @.***> wrote:

I also tried it with my ipad 7 and it didn't work.
On Sun, May 30, 2021 at 5:14 PM Edward Nguyen @.***>
wrote:

Update: I tried it with an iphone 7 and it didn't work, but I tried it
with an iphone 11 and it did work.
On Sat, May 29, 2021 at 8:22 AM Edward Nguyen @.***>
wrote:

I have tried all of that and still no luck. I also tried my friend's
android phone (also an s8 and that also didn't work). I have also tried
going on a different wifi network. I have also tried u installing anki and
reinstalling it. Nothing seems to be working
On Sat, May 29, 2021, 4:51 AM TheDabblingDuck @.***>
wrote:

The problem probably isn’t an Android vs iPhone problem. Check to make
sure your phone isn’t on VPN, that your phone and computer are on the same
WiFi network, and also try clearing the browser history and cache on your
phone. Might also be worth it to try a different browser on the phone. Good
luck!
On May 28, 2021, 6:09 PM -0400, TurtleEd @.***>, wrote:

Ever since yesterday (5/27), I have noticed that ankimote no longer
works with my phone (samsung s8+). After scanning the QR code with my
phone, the webpage pops up but it cannot load the proper page.
I tried using my friend's iphone and it worked fine.
Could you fix this issue? Or is there an alternative method for
androids to use ankimote now?
Thank you!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/TheDabblingDuck/ankimote/issues/23#issuecomment-850845914,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUIPFNOPTT5QNZCCIWHI5K3TQD5OVANCNFSM45XRWXSQ
.

--
We can learn things by reading books or watching television but unless we
experience them for ourselves we wont truly understand.

--
We can learn things by reading books or watching television but unless we
experience them for ourselves we wont truly understand.

--
We can learn things by reading books or watching television but unless we
experience them for ourselves we wont truly understand.
—You are receiving this because you commented.Reply to this email directly, view it on GitHub, or unsubscribe.

ok
On Fri, Jun 4, 2021 at 10:05 AM TheDabblingDuck @.***>
wrote:

That's between you and mcafee
On Jun 4, 2021, 3:55 PM -0400, TurtleEd @.***>, wrote:

update: I turned off my firewall for mcafee and it started working
again.
Do you have any advice on how to allow exceptions for ankimote through
mcafee firewall?
On Sun, May 30, 2021 at 5:16 PM Edward Nguyen @.***> wrote:

I also tried it with my ipad 7 and it didn't work.
On Sun, May 30, 2021 at 5:14 PM Edward Nguyen @.***>
wrote:

Update: I tried it with an iphone 7 and it didn't work, but I tried it
with an iphone 11 and it did work.
On Sat, May 29, 2021 at 8:22 AM Edward Nguyen @.***>
wrote:

I have tried all of that and still no luck. I also tried my friend's
android phone (also an s8 and that also didn't work). I have also
tried
going on a different wifi network. I have also tried u installing
anki and
reinstalling it. Nothing seems to be working
On Sat, May 29, 2021, 4:51 AM TheDabblingDuck @.***>
wrote:

The problem probably isn’t an Android vs iPhone problem. Check to
make
sure your phone isn’t on VPN, that your phone and computer are on
the same
WiFi network, and also try clearing the browser history and cache
on your
phone. Might also be worth it to try a different browser on the
phone. Good
luck!
On May 28, 2021, 6:09 PM -0400, TurtleEd @.***>, wrote:

Ever since yesterday (5/27), I have noticed that ankimote no
longer
works with my phone (samsung s8+). After scanning the QR code with
my
phone, the webpage pops up but it cannot load the proper page.
I tried using my friend's iphone and it worked fine.
Could you fix this issue? Or is there an alternative method for
androids to use ankimote now?
Thank you!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<
https://github.com/TheDabblingDuck/ankimote/issues/23#issuecomment-850845914
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AUIPFNOPTT5QNZCCIWHI5K3TQD5OVANCNFSM45XRWXSQ

.

--
We can learn things by reading books or watching television but
unless we
experience them for ourselves we wont truly understand.

--
We can learn things by reading books or watching television but unless
we
experience them for ourselves we wont truly understand.

--
We can learn things by reading books or watching television but unless we
experience them for ourselves we wont truly understand.
—You are receiving this because you commented.Reply to this email
directly, view it on GitHub, or unsubscribe.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/TheDabblingDuck/ankimote/issues/23#issuecomment-854971486,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUIPFNKKWFW7URDN4DUSDKDTREWZ5ANCNFSM45XRWXSQ
.

--
We can learn things by reading books or watching television but unless we
experience them for ourselves we wont truly understand.


Use count queries when loading from Neo4j

// TODO: use count queries
https://github.com/opencypher/cypher-for-apache-spark/blob/3afbaabb55d6ec808e7b181f80911e332fef8aa1/src/main/scala/org/opencypher/caps/impl/spark/io/neo4j/EncryptedNeo4j.scala#L52

This class was removed.


[T5A2][F11-A3]Hsieh, Hsin-Han

@Tony-Hsieh Some comments added. Please close the PR after reading comments.


Update nextflow.md

Remove and update old links from tutorials (issue #1610)

Very nice, @enoracrl ! There's a more up to date blog post on Nextflow + Google Cloud. I'd add (replace the old one?) it too: https://www.nextflow.io/blog/2023/nextflow-with-gbatch.html

Hello, @enoracrl. I took the liberty to update the Google Batch link. It's good to merge for me 😄


Update logback-classic to 1.4.9

About this PR
📦 Updates ch.qos.logback:logback-classic from 1.2.12 to 1.4.9
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "ch.qos.logback", artifactId = "logback-classic" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "ch.qos.logback", artifactId = "logback-classic" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #2820.


Create function for Study Eye Location: ADSL.STUDYEYE

Create function for Study Eye Location e.g. ADSL.STUDYEYE (based on SC test data from issue 11)

Hi @hiren8484 I think this is covered by #9 which is now closed.

Thanks @manciniedoardo I realised after assigning it! Thanks for spotting, will close this off.


Update the clobber task after 1d0ed63

Signed-off-by: Victor Porof<EMAIL_ADDRESS>Small cleanup after https://github.com/mozilla/tofino/commit/1d0ed63b43ea1f2e2a1dd1e6630f57131f474594

Coverage remained the same at 43.057% when pulling b8cde9fd96a3d2f147aa21354ab652224abcb12f on victorporof:build-config-leftovers into 6d6f73bc9d654d5b21121b0d8eb82c60c3e66737 on mozilla:master.

Coverage remained the same at 43.057% when pulling a183748bda55f18440beb515ab39f6d362aa2709 on victorporof:build-config-leftovers into 6d6f73bc9d654d5b21121b0d8eb82c60c3e66737 on mozilla:master.


'make' is not recognized as an internal or external command

Hi, I am trying to install the dependencies for this. After I cloned it I ran npm i and this is what I got:
<EMAIL_ADDRESS>install C:\Users\Theob\Desktop\czi-prosemirror\node_modules\pjs
make commonjs
'make' is not recognized as an internal or external command,
operable program or batch file.
npm WARN<EMAIL_ADDRESS>No repository field.
npm WARN<EMAIL_ADDRESS>No license field.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: make commonjs
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!      C:\Users\Theob\AppData\Roaming\npm-cache_logs\2019-11-08T19_47_32_059Z-debug.log
Any help is appreciated, thanks!

I got this error in another project
npm ERR! Failed at the<EMAIL_ADDRESS>install script.


Improve ITelemetry Serialization

Alternative fix for #988.
~I think the unknown telemetry case could be eliminated.~
JsonSerializer is attempting several type casts.

Because of the if statements, there are several failed casts before finding the correct matching type.

Option 1
~I propose to remove the serialization entirely by appending the TelemetryName and BaseType to the ITelemetry interface. This would completely eliminate any need for casting here.~
This isn't viable because ITelemetry is the foundation of the Common Schema and cannot take changes.
Option 2
If we don't want to add properties to ITelemetry we can instead introduce a new interface ISerializableTelemetry. With this there would be only one type cast (ITelemetry => ISerializableTelemetry).
This has the benefit of being applied only to our AI Telemetry objects and won't affect external types.

@SergeyKanzhelev Are you okay with this approach?

@MS-TimothyMothra please do create a github issue with the problem description and tag it with perf. It'll be easy for discovery later :)


"Alternative default: queue declaration arguments

QueueDeclareArguments uses the builder pattern and that's nice but it would be even better
to also provide a few constructor/factory methods for common cases:

Durable (and thus non-exclusive, non-autodelete) queue
Transient exclusive queue
Transient auto-delete queue

Clients such as Bunny provide such helpers.
I'd be happy to submit a PR if it'd be accepted.

@michaelklishin , sounds good to me!


Sending data no longer working

It was working thursday 1 april, but not today or yesterday. Maybe it's a connexion issue
see the logs below...
I'm using the last version
git log --format="%H" -n 1
fe48d365d27ba28e6267bceeeae6c9dfc1ddc097

it's strange, since the logs suggest the use of SQL to send data or that I'm not in the right network.
(as a side note, we need to think/re-discuss about a CI strategy to test TuxML)
python3 kernel_generator.py --dev 1 --linux_version 5.8 --tiny --local
--dev | You are using the development version, whose can be unstable.
--local | You are using the local version, which means that you could be out to date, or you could crash if you don't have the image.
--tiny | You are using tiny configuration.
Specific image for linux v5.8 already exist. Nothing to do.

=============== Docker number  0  ===============
00:00:00 [2021-04-05 17:43:11 CEST] [update_system] Updating packages repositories.
00:00:32 [2021-04-05 17:43:43 CEST] [update_system] Packages repositories updated and packages upgraded.
00:00:32 [2021-04-05 17:43:43 CEST] [retrieve_and_display_environment] Getting environment details.
00:00:32     ==> hardware
00:00:32       --> cpu_max_frequency: 4900.0
00:00:32       --> mechanical_disk: False
00:00:32       --> number_cpu_core: 8
00:00:32       --> cpu_brand_name: Intel(R) Core(TM) i7-10510U CPU @ 1.80GHz
00:00:32       --> ram_size: 16083332
00:00:32       --> architecture: x86_64
00:00:32     ==> software
00:00:32       --> tuxml_version: v2.0
00:00:32       --> linux_distribution: Debian GNU/Linux
00:00:32       --> linux_distribution_version: 9
00:00:32       --> system_kernel_version: 5.3.7-301.fc31.x86_64
00:00:32       --> system_kernel: Linux
00:00:32       --> libc_version: 2.24-11+deb9u4
00:00:32       --> gcc_version: 6.3.0-18+deb9u1
00:00:32 [2021-04-05 17:43:43 CEST] [retrieve_and_display_configuration] Getting configuration details.
00:00:32     --> kernel_version_compilation: 5.8
00:00:32     --> core_used: 8
00:00:32     --> incremental_mod: False
00:00:32     --> kernel_path: /TuxML/linux-5.8
00:00:32 [2021-04-05 17:43:43 CEST] [__linux_config_generator] Tiny config with preset values here : /TuxML/compilation/x64.config .
00:00:38 [2021-04-05 17:43:49 CEST] [__compile] Compilation in progress
00:01:57 [2021-04-05 17:45:08 CEST] [__compile] Compilation successful.
00:01:57 [2021-04-05 17:45:08 CEST] [__do_a_compilation] Successfully compiled in 00:01:18 (installation_time = 00:00:00)
00:01:57 [2021-04-05 17:45:08 CEST] [__get_compressed_kernel_size] Computing compressed kernel size.
00:02:27 [2021-04-05 17:45:38 CEST] [__get_compressed_kernel_size] Successfully retrieve compressed kernel size.
00:02:27 [2021-04-05 17:45:38 CEST] [insert_result_into_database] Sending result to database.
Traceback (most recent call last):
  File "/TuxML/compilation/main.py", line 334, in <module>
    config_file=args.config
  File "/TuxML/compilation/main.py", line 245, in run
    boot_result,
  File "/TuxML/compilation/main.py", line 280, in insert_result_into_database
    settings.NAME_BDD)
  File "/TuxML/compilation/database_management.py", line 15, in fetch_connection_to_database
    db=database_name
  File "/usr/local/lib/python3.5/dist-packages/MySQLdb/__init__.py", line 130, in Connect
    return Connection(*args, **kwargs)
  File "/usr/local/lib/python3.5/dist-packages/MySQLdb/connections.py", line 185, in __init__
    super().__init__(*args, **kwargs2)
MySQLdb._exceptions.OperationalError: (2003, 'Can\'t connect to MySQL server on \'<IP_ADDRESS>\' (110 "Connection timed out")')

You sent 1 compilations data to the TuxML API.
Total number of container used : 1
Number of compilations in a container : 1 ( 1 basic compilation + 0 incremental compilations).
Total number of compilations : 1

J'ai l'impression que le code utilisant l'API est ignoré et que l'ancien code est pris en compte.
Pourriez-vous vérifier en ajoutant l'argument --mount_host_dev (tout en étant bien sûr à jour du master).
Si cela fonctionne, cela signifie qu'il faut régénérer les images dockers localement sur votre machine.

python3 kernel_generator.py --dev 1 --linux_version 5.8 --tiny --local --mount_host_dev
--dev | You are using the development version, whose can be unstable.
--local | You are using the local version, which means that you could be out to date, or you could crash if you don't have the image.
--tiny | You are using tiny configuration.
--mount_host_dev | You will use your local code instead of the one contained in docker image. Usefull for development only.
Specific image for linux v5.8 already exist. Nothing to do.

=============== Docker number  0  ===============
Traceback (most recent call last):
  File "/TuxML/compilation/main.py", line 10, in <module>
    from compilation.apiManager import APIManager
  File "/TuxML/compilation/apiManager.py", line 1, in <module>
    import requests
ImportError: No module named 'requests'

You sent 1 compilations data to the TuxML API.
Total number of container used : 1
Number of compilations in a container : 1 ( 1 basic compilation + 0 incremental compilations).
Total number of compilations : 1

I will rebuild the images ;)

Oui, là plus le choix !
docker stop $(docker ps -a -q);
docker rm -f $(docker ps -a -q);
docker rmi $(docker images -q);
./scripts_bash/generate_images.sh

yep, working nicely :)