Cannot read some PNG images but OK with all JPEG and BMP

Hello,
first thanks for this great library that will hopefully help me to solve some performance issue with images previews. :-)
I've build a small proof of concept of what I'm trying to accomplish.
It's working fine with all JPEG and BMP images I've tested, but it crashes with some PNG images that have been generated by MS Paint.
Here is the error I get when reading them:
jimp.js:2085 Uncaught Error: buffer error:
    at Zlib._binding.onerror (jimp.js:2085)
    at Zlib._error (jimp.js:2045)
    at Zlib._write (jimp.js:2045)
    at jimp.js:2044
    at Item.run (jimp.js:2130)
    at drainQueue (jimp.js:2129)

You'll find one of these images attached.
Thanks for any input on this issue.
Here is the code:
JS:
<html>
    <body>
        <input type="file" id="imageInput" />
        <img id="imagePreview" />
        <script src="jimp.js"></script>
        <script>
            let imageInput = null;
            let fileReader = null;
            let imagePreview = null;

            function onPageLoaded() {
                imageInput = document.getElementById("imageInput");
                imagePreview = document.getElementById("imagePreview");

                imageInput.addEventListener("change", onSelectedImageChanged);
            }

            function onImageLoaded(e) {
                const originalImageBuffer = fileReader.result;
                 Jimp
                    .read(originalImageBuffer)
                    .then(function (image) {
                        let newWidth = 256;
                        let newHeight = 256;
                        if (image.bitmap.width >= image.bitmap.height){
                            newHeight = Jimp.AUTO;
                        }
                        else {
                            newWidth = Jimp.AUTO;
                        }

                        image.resize(newWidth, newHeight)
                             .getBase64(Jimp.AUTO, function (error, result) {
                                 imagePreview.src = result;
                             });
                    });
            }

            function onSelectedImageChanged() {
                imagePreview.src = "";

                const imageFile = this.files[0];

                fileReader = new FileReader();
                fileReader.addEventListener("load", onImageLoaded);
                fileReader.readAsArrayBuffer(imageFile);
            }

            window.addEventListener("load", onPageLoaded);
        </script>
    </body>
</html>

Moreover I can't find a way to safely catch the error in order to:

log it,
gracefully fallback on a default behavior without resizing.

I've tried to :

add a catch in my promise chain: Jimp.read(...).catch(...)
wrap the whole block in a try/catch statement: try { Jimp.read(...)... } catch(error) {...}

Any idea to cleanly catch the error will be greatly appreciated. :-)
Thanks.

FYI this kind of issue was a no-go, so instead I've used Pica for my use-case.
Vitaly, the project's owner, offers a great support.
So you can try it and see for yourself if it fits your needs.

Thanks @Pragmateek !

@Pragmateek all the error handling stuff should be fixed now.

I've loaded both photos into current jimp and neither has an issue. Feel free to open another issue if the problem persists!

@hipstersmoothie OK thanks for the fix, it's been a while since I've worked on this project, but who knows maybe I'll need it later. :)


Add support for vim keybindings for movement

...and also allow 'q' and 'ESC' to exit the interface. This could have been
achieved by adding a layer of indirection and a many-to-one mapping between
keys and 'UI actions', but that felt like overkill at this stage.

Rebased onto #6 (unmerged) for convenience.


Error on frozen orbitals example code

Hello,
I am trying to run the freeze orbitals code found here https://qiskit-extensions.github.io/circuit-knitting-toolbox/how-tos/entanglement_forging/freeze-orbitals.html
However I run into the following problem, as if the reduction was not properly applied:
ValueError: The number of qubits of the 0-th circuit (5) does not match the number of qubits of the 0-th observable (7).
from matplotlib import pyplot as plt
import numpy as np

from qiskit.circuit import QuantumCircuit, Parameter
from qiskit.circuit.library import TwoLocal
from qiskit.algorithms.optimizers import COBYLA
from qiskit_nature.drivers import Molecule
from qiskit_nature.drivers.second_quantization import PySCFDriver
from qiskit_nature.problems.second_quantization import ElectronicStructureProblem
from qiskit_nature.mappers.second_quantization import JordanWignerMapper
from qiskit_nature.converters.second_quantization import QubitConverter
from qiskit_nature.algorithms.ground_state_solvers import (
    GroundStateEigensolver,
    NumPyMinimumEigensolverFactory,
)

from circuit_knitting_toolbox.entanglement_forging import (
    EntanglementForgingAnsatz,
    EntanglementForgingGroundStateSolver,
)
from circuit_knitting_toolbox.utils import reduce_bitstrings
from qiskit_ibm_runtime import QiskitRuntimeService, Options
from circuit_knitting_toolbox.entanglement_forging import (
    EntanglementForgingGroundStateSolver,
)

radius_1 = 0.958  # position for the first H atom
radius_2 = 0.958  # position for the second H atom
thetas_in_deg = 104.478  # bond angles.

H1_x = radius_1
H2_x = radius_2 * np.cos(np.pi / 180 * thetas_in_deg)
H2_y = radius_2 * np.sin(np.pi / 180 * thetas_in_deg)

molecule = Molecule(
    geometry=[
        ["O", [0.0, 0.0, 0.0]],
        ["H", [H1_x, 0.0, 0.0]],
        ["H", [H2_x, H2_y, 0.0]],
    ],
    charge=0,
    multiplicity=1,
)
driver = PySCFDriver.from_molecule(molecule=molecule, basis="sto6g")
problem = ElectronicStructureProblem(driver)
converter = QubitConverter(JordanWignerMapper())

theta = Parameter("θ")

hop_gate = QuantumCircuit(2, name="Hop gate")
hop_gate.h(0)
hop_gate.cx(1, 0)
hop_gate.cx(0, 1)
hop_gate.ry(-theta, 0)
hop_gate.ry(-theta, 1)
hop_gate.cx(0, 1)
hop_gate.h(0)

theta_1, theta_2, theta_3, theta_4 = (
    Parameter("θ1"),
    Parameter("θ2"),
    Parameter("θ3"),
    Parameter("θ4"),
)

circuit_u = QuantumCircuit(5)
circuit_u.append(hop_gate.to_gate({theta: theta_1}), [0, 1])
circuit_u.append(hop_gate.to_gate({theta: theta_2}), [3, 4])
circuit_u.append(hop_gate.to_gate({theta: 0}), [1, 4])
circuit_u.append(hop_gate.to_gate({theta: theta_3}), [0, 2])
circuit_u.append(hop_gate.to_gate({theta: theta_4}), [3, 4])

orbitals_to_reduce = [0, 3]
bitstrings_u = [(1, 1, 1, 1, 1, 0, 0), (1, 0, 1, 1, 1, 0, 1), (1, 0, 1, 1, 1, 1, 0)]
reduced_bitstrings = reduce_bitstrings(bitstrings_u, orbitals_to_reduce)

ansatz = EntanglementForgingAnsatz(circuit_u=circuit_u, bitstrings_u=reduced_bitstrings)

service = None

backend_names = ["ibmq_qasm_simulator"] * 2

options = [Options(execution={"shots": 1000}), Options(execution={"shots": 2000})]

optimizer = COBYLA(maxiter=100)

solver = EntanglementForgingGroundStateSolver(
    ansatz=ansatz,
    optimizer=optimizer,
    service=service,
    backend_names=backend_names,
    options=options,
#    initial_point=[0.0, np.pi / 2, 0.0, 0.0],
)

results = solver.solve(problem)

Hi @quosta , thanks for the report. I believe you need to pass orbitals_to_reduce=orbitals_to_reduce into the EntanglementForgingGroundStateSolver and this will happen automatically for you.
Here is a tutorial from a deprecated repo that shows something similar.
Also, please find #132 as a resolution to further confusion about this.
Please confirm using EFGroundStateSolver with this argument resolves your issue, and I'll close this

Yes, thanks. In the how to it would be easier to provide the full example including how to instantiate the solver and run it with the proper arguments, compared to what is know "From here, the problem can be solved following the same steps as in the [tutorials]"

Yes, thanks. In the how to it would be easier to provide the full example including how to instantiate the solver and run it with the proper arguments, compared to what is know "From here, the problem can be solved following the same steps as in the [tutorials]"

He H2O optimization is a little slow for us to test in our tutorials, but I agree that the how-to should show how to load up the EntanglementForgingGroundStateSolver with the orbitals to freeze. This will be done in #132
Thanks again


Support total state_class for daily energy resets like the HA Energy Dashboard

I would have started this as a discussion, but that section isn't enabled on this repo.
I recently got most of my house's power and energy in HA thanks to an Emporia Vue, Powercalc, templates, and the new sensor groups. With those all set up, configuring my energy Sankey chart was pretty straightforward. Thank you!
But, I noticed that the energy totals for my mostly Powercalc'd light group was taking up most of my total energy demand. Something wasn't right.
The power curves I configured for each of the lights was working and accurately tracking each light's power state with the measurement state_class, but the energy entity's state_class (total) seemed to not reset to 0 each night in Sankey although it did in the HA Energy Dashboard.
Does the Sankey card need the state class to be total_increasing for an energy sensor that does not reset daily on its own? How does the HA Energy Dashboard do it?
Describe the solution you'd like
The Sankey card to work like the HA Energy Dashboard allowing for energy entities which do not reset daily.
Describe alternatives you've considered
I think I would need to create ~30 daily utility sensors so the state will reset each night.
Additional context
Powercalc-created energy sensor for one of the lights:

A daily utility sensor based on that same entity:

The same entities next to each other showing approximately the same used energy for the day despite the total running value being much different:

So you use energy_date_selection? Because that doesn't need a reset and works exactly like the energy dashboard.

Ah, I swear I read the entire repo, but didn't realize the date-selector was necessary for this sort of thing. I was trying to put the Sankey chart in a panel to keep the view clean. So, I just had to modify the width to fill with layout-card and vertical-stack the date-selector.
Thanks. It seems to be working as expected now.
Is there any reason to not have whatever the date-selector feeds into in the Sankey card's code just default to today's date when the date-selector is not present on the view?

The reason is that this card is not created for daily energy, it has other uses. I originally created it to view current power draw and this is still my main use for it. Others use it to break down values like costs/budget.


Update "handlebars" to v4.0.6

related to #224
/cc @mmun @rwjblue

@Turbo87 - LGTM, can you prepare the corresponding Ember PR also and confirm all works well?

LGTM, I'd like @mmun to review / confirm also.

I think we should address the things listed in https://github.com/tildeio/glimmer/issues/224 before landing this.
From @mmun in that issue:

Partials (specifically the {{> foo}} syntax and its variations and decorators. They weren't designed with glimmer in mind and it's not clear at this time how they fit into our component story.

Awesome, thank you @Turbo87 and @locks!


Allow RegExp paths as routes.

This patch lets you use a RegExp as the path for a route.

#152 should have fixed this.


Cached editors are never destroyed

Describe the Bug
Once an editor is opened, it is never removed from the memory, even if a tab with it is closed.

Steps to Reproduce
Steps to reproduce the behavior:

Open a few tabs
Create a memory snapshot and note the memory usage
Close the tabs
Create a memory snapshot and note that the memory usage does not drop

Expected Behavior
The redundant CamundaModeler/CodeMirror instances should be garbage-collected.
Environment
Please complete the following information:

OS: MacOS 10.14
Camunda Modeler Version<EMAIL_ADDRESS>

We should rethink the cache-related components and their lifecycle methods.

This is not related to our caching infrastructure, as every element is properly destroyed and evicted from the cache. I do believe there is some other place that holds references on these elements.

For the current next commit, this seems to happen only to DMN-related tabs with an exception of BpmnModdle (Mac, 933f40a)


Adding Metadata conventions

This is an attempt to add the ability to override Metadata conventions as previously it was hard wired to DefaultMetadataModuleConventions.
You can now implement IMetadataConvention and implement it to how you want the system to find metadata modules.
This is the first attempt before we decide along with @liddellj how best to do this.
Tests will fail but just wanted you to take a look at the propsed API

@jchannon @liddellj if I understand this correctly, we should ditch this pull-request and perhaps revisit it using a different approach (the one that @liddellj  suggested) ?

Yes - I think that's appropriate. Might be worth opening a separate PR referencing this one so the history is retained?
Unfortunately I'm not developing on .NET anymore so it's very unlikely I'll get a chance to do any of this. I'll mention it to my co-workers to see if I can find a new home for it.

Seems I already created a separate issue for this: https://github.com/NancyFx/Nancy/issues/1729

@liddellj Cool. Let me be blunt. Any plans on acting on that or should we close it until the impulse comes back? Currently culling the issues/pull-requests lists very hard and only want to keep stuff that is actually going to happen in a very near future :yum:

Kill it.

On 26 Aug 2015, at 12:58, Andreas Håkansson<EMAIL_ADDRESS>wrote:
@liddellj Cool. Let me be blunt. Any plans on acting on that or should we close it until the impulse comes back? Currently culling the issues/pull-requests lists very hard and only want to keep stuff that is actually going to happen in a very near future
—
Reply to this email directly or view it on GitHub.


Fix exception when reading "is_paid"

This should fix #38 .

Curious, why was this closed? It fixed the issue on my system
$ cat /etc/fedora-release && uname -a
Fedora release 28 (Rawhide)
Linux [redacted] 4.13.0-0.rc6.git4.1.fc28.x86_64 #1 SMP Fri Aug 25 14:47:39 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux

@mrundle I remember it's because later I found more problems related to the newer format of json returned by Leetcode and I realized that this PR seemed to only fix the surface of all...


[stable/influxdb] Add myself into maintainers

Signed-off-by: Aisuko<EMAIL_ADDRESS>
What this PR does / why we need it:
There may need another maintainer into this chart, I have a feat #14411 on this chart, and a new PR #15504 , and those charts can not assign to the owner. It can only approve to merge by the member. So, I'd like to as a maintainer into this chart.
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[ ] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/assign @maorfr

Please have a look at this, thank you very much.

/ok-to-test

/lgtm

#13867


[New Feature]: Remove AI responses in issues

Description of the new feature/enhancement
More than half of users find the ai's answers useless and uninteresting.

Proposed technical implementation details (optional)
No response

More than half of users

Do you have any data you can point to showing why you believe this claim to be true? How many issues does this actually affect compared to the number of issues submitted?

I think it just allows user to find similar issue as they created. If the issue is actually resolved in previous issue, users can find where the issue is instead of waiting for response from community. So, the AI response in issue should not be removed.


Create Misaka_how Buy an NFT in Cadence_2023-12-23.cdc

duplicated code
https://github.com/FlowFans/zealy-campaigns/blob/main/2023/q4-code-snippets/submissions/Anarhist95_Buy an NFT_2023-12-21.cdc


IE11 Support with 1.4.1

Hello,
We use shareon, but also need to support IE11.  1.3.1 worked great in IE11, but after upgrading to 1.4.1, we receive a syntax error due to the use of an error function here:
var urlBuilderMap = {facebook:(d) => ...

Is it possible to continue having the dist JS be compiled to es5 for IE11 support?  For now, we have to roll back to 1.3.x.
Thank you
Brandon

A quick follow up, it looks like 1.4.0 works as well, so this seems specific to 1.4.1... maybe the typescript conversion is not compiling down to es5?

It's the other way round :D With 1.4.1 I moved from TS to JS for easier compilation and I forgot, that it now doesn't transpile without Babel/Bublé 🤦♂ I'll try to fix it asap, but I can't really promise much until Sep 15 since I'm in the middle of my exams right now 🙄
For now please refer to using 1.4.0, it has the same functionality as 1.4.1:
<link rel="stylesheet"<EMAIL_ADDRESS><script<EMAIL_ADDRESS>

Got it, thank you!  1.4.0 works fine in IE11 tested with browserstack.

Hey @brandonburkett, I released the fix in v1.4.4 🎉 I however want to make sure, that it really works in IE11. I just realised that I am using SVG encoded in data: URIs -- and IE11 doesn't seem to support this. By that I mean that shareon buttons don't have icons in IE11 -- is this desired?

@NickKaramoff thank you.  We'll do some testing, but 99% sure (at least with 1.4.0) the icons were working fine in IE11.  If you are using the same way in 1.4.4, it should work, but we can take a look in browser stack next week.


StructScalar stores borrowed arcs

What's the motivation?
Typically the ScalarValue would have a different lifetime to the DType wouldn't it?


gpg key expired?

I have removed the previous key to make sure and imported the key from https://newsboat.org/newsboat.pgp to verify the newsboat-2.33.tar.xz signature.
[tru@sillage newsboat]$ sha256sum newsboat-2.33.tar.xz.asc newsboat-2.33.tar.xz newsboat.pgp
c9abf78baec07f4c8902a66cd4b8b175de8c2a8c19e8effc57ece69468bc9eef  newsboat-2.33.tar.xz.asc
179d0d5e608337f14e5e670c0a6b144129ed4e504621ca2a117d188894cb34fa  newsboat-2.33.tar.xz
f3528d30cc257cf6c94ea5b8224f92d3205f56561acee99c98e7fd4732976100  newsboat.pgp

[tru@sillage newsboat]$ gpg --delete-key 932B9EBE
gpg (GnuPG) 2.0.22; Copyright (C) 2013 Free Software Foundation, Inc.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

pub  4096R/932B9EBE 2017-09-17 Newsboat project<EMAIL_ADDRESS>
Delete this key from the keyring? (y/N) y
[tru@sillage newsboat]$ gpg --import newsboat.pgp
gpg: key 932B9EBE: public key "Newsboat project<EMAIL_ADDRESS>imported
gpg: Total number processed: 1
gpg:               imported: 1  (RSA: 1)
gpg: 3 marginal(s) needed, 1 complete(s) needed, classic trust model
gpg: depth: 0  valid:   6  signed:   5  trust: 0-, 0q, 0n, 0m, 0f, 6u
gpg: depth: 1  valid:   5  signed:   0  trust: 1-, 0q, 0n, 1m, 3f, 0u
[tru@sillage newsboat]$ gpg --verify newsboat-2.33.tar.xz.asc
gpg: Signature made Sun 24 Sep 2023 10:35:50 PM CEST using RSA key ID 932B9EBE
gpg: Good signature from "Newsboat project<EMAIL_ADDRESS>gpg: Note: This key has expired!
Primary key fingerprint: B8B1 756A 0DDB F076 0CE6  7CCF 4ED6 CD61 932B 9EBE

It did. Thank you for spotting that!
I now bumped the expiration date and pushed the key to pgp.mit.edut and newsboat.org. I also updated our release checklist (#2569) to avoid this problem in the future.


Duplicate code in final bundle of Webpack 4 production build. lib and es are both appearing.

Bug or feature request?
Bug
Description:
https://imgur.com/a/Uknu7Cm
(Bug) Expected result:
Usually only one version of the code is included, either es or non-es
(Bug) Actual result:
Both es and non-es are included
(Bug) Potential fix:
-- Not sure... I'm not sure how the guts of this works. I believe that there isn't a need to be supplying both /es and the /lib forms of the library.
I deleted the /es from node_modules and that removed it from the project, actual testing is needed though
Reproduction code:
package.json
{
  "scripts": {
    "start": "webpack-dev-server --mode development --open --hot",
    "build": "webpack --mode production"
  },
  "dependencies": {
    "xstate": "^4.3.1"
  },
  "devDependencies": {
    "@babel/cli": "^7.2.3",
    "@babel/core": "^7.2.2",
    "@babel/plugin-proposal-class-properties": "^7.3.0",
    "@babel/plugin-proposal-object-rest-spread": "^7.2.0",
    "@babel/plugin-proposal-optional-chaining": "^7.2.0",
    "@babel/polyfill": "^7.2.5",
    "@babel/preset-env": "^7.2.3",
    "@babel/preset-flow": "^7.0.0",
    "@babel/preset-react": "^7.0.0",
    "babel-loader": "^8.0.5",
    "css-loader": "^2.1.0",
    "file-loader": "^3.0.1",
    "webpack": "^4.28.1",
    "webpack-bundle-analyzer": "^3.0.3",
    "webpack-cli": "^3.2.1",
    "webpack-dev-server": "^3.1.14"
  }

index.js
import { Machine } from 'xstate';
import { interpret } from 'xstate/lib/interpreter';

const keyFSM = new Machine({
  id: 'keyfsm',
  initial: 'NONE',
  states: {
    NONE: {
      on: {
        connected: 'CONNECTED',
      },
    },
    CONNECTED: {
    }
})

export const stateFSM = interpret(keyFSM)

Try importing only from xstate (which Webpack uses xstate/es/... for):
import { Machine, interpret } from 'xstate';


Create dataframe

This PR add the possiblity to create a pandas dataframe that can be queried to extract data of the various runs (can be adopted in colab)

@mithro I am also creating a colab page with a set of scripts and utility functions to easily navigate the dataframe.


Use of context.TODO()

I noticed that you added context arguments to the k8s API calls in 16109017cec02a8a0c4f80f829acc38ab28a14b2 - but you used context.TODO() instead of propagating a context object.
context.TODO() signals that this will be changed at some point - do have any plans to do so?
Otherwise, it would be more appropriate to use context.Background() instead.

I think the patch you are referring to was simply the quickest workaround, and we didn't talk about what will it contain yet.
I don't have any strong opinion on that. If you want to switch it, please be sure to include the why in the eventual PR. :)

I would like to keep that one open.

Is there more that needs to be done here?

The current main still has context.TODO() in place of a more appropriate context object.
There's two ways to solve this: Propagate a context object through all functions that call the k8s API, or use a local context.Background(). I can't tell which one is more appropriate in each case.
In one place, a ctx, cancel := context.WithTimeout(context.Background(), timeout) was used: https://github.com/kubereboot/kured/blob/main/pkg/daemonsetlock/daemonsetlock.go#L152
Would it make sense to have timeouts in other places as well?

I think that the proper path forward here is @onitake's suggestion to audit the code and, where appropriate, establish a durable context object (context.Background() would be fine for this) and then to pass it down the execution flow, updating function signatures as necessary to accept context.Context, and then passing that downstream instead of using a local context.TODO().
The function comments in the go std library for TODO() suggest that this is the appropriate thing to do when you haven't yet done the above.
// TODO returns a non-nil, empty Context. Code should use context.TODO when
// it's unclear which Context to use or it is not yet available (because the
// surrounding function has not yet been extended to accept a Context
// parameter).

Ref:

https://cs.opensource.google/go/go/+/refs/tags/go1.21.0:src/context/context.go;l=215-218

I don't think we benefit from updating the existing local context.TODO() usages one-by-one with context.Background(). That doesn't seem to offer any benefit, at a (marginal) cost compared to an empty context.Context.
Curious about other thoughts as well here.

That's a good point, we should pass contexts down the line for better handling. 👍

Hey, if you want to pass down a context, would you also want some kind of mechanism to manage the go routines started in the main func, like https://pkg.go.dev/github.com/oklog/run?
There is no point of passing down a context, if you don't cancel it when the application receives a signal, or the metrics server crashes.


Zendesk widget offset improvements

Context
We are improving Drift widget handling, but there are still edge cases where both Zendesk and Drift can be active at the same time. This change lets them "co-exist" side by side happily 😀
How to test

Check out matias/zendesk-widget-offset
Start up local dev environment and go to the homepage
Open the browser console and write zE('webWidget', 'open') ; zE('webWidget', 'show')
Notice the Zendesk widget appearing side-by-side instead of overlapping

Before

After

Is there a way to test this? Otherwise it looks safe in scope.

Updated! Thanks @AndrewJakubowicz 👍

Is there a way to test this? Otherwise it looks safe in scope.

Updated! Thanks @AndrewJakubowicz 👍


Videos keep pausing for no reason? Chrome.

Starting maybe a week ago, my videos began to keep pausing for no reason and it's only when I have Youtube Center enabled. When its disabled, I get no pauses whatsoever, I tried checking for updates but there didn't seem to be anything out there for this. I also tried uninstalling and reinstalling and it didn't help. Would appreciate anything, it's getting quite annoying. Thanks!

Hmm, guess it fixed itself for some odd reason. Really odd, maybe it's just something on my end.


Add "Upgrading Galaxy" admin slides

@bgruening I don't think we should do that. After everything is moved we can archive the dagobah repo, but we shouldn't break it by changing what was already there and presented.

@martenson I'm not saying wiping it out of all branches. Just from master, so that we use the new one for the next training. We did this already for Oslo.

Please don't do that. I am currently in the middle of organising gccbosc
admin session. A simple list of what has newer version in this repo would
be ideal for this transition period.
On Thu, May 24, 2018, 12:12 PM Björn Grüning<EMAIL_ADDRESS>wrote:

@martenson https://github.com/martenson I'm not saying wiping it out of
all branches. Just from master, so that we use the new one for the next
training. We did this already for Oslo.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/galaxyproject/training-material/pull/783#issuecomment-391772495,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABuxqueQy0DcRiweefPMuJw656FaWKVkks5t1tv2gaJpZM4UKsQO
.

@martenson That would probably https://github.com/galaxyproject/training-material/issues/135#issuecomment-391042440 , the topics missing from the list or ticked are newer in this repo.

@bgruening @martenson I've added a tracking issue: https://github.com/galaxyproject/dagobah-training/issues/50


Add Description section and 'Supported Tags and respective Dockerfile links' subsection to Geodesic docker hub repo

Describe the Feature
The geodesic docker repo lacks tag and dockerfile links.  I had to scrutinize the Geodesic Github README and also just kind of search around in the docker repo to get an idea of where Geodesic is at in terms of stability, given that the latest releases are pull request releases, etc.  I'm not quite sure what the intention is, but I think it's fairly typical of robust docker repo's to have a subsection in their description tab that lists all tags with links to the respective Dockerfile.  In my experience one major plus of this is that someone that wants to use a various different/newer/experimental image versions can just go right to this page and figure our what's what.  As it stands this is somewhat difficult to do with Geodesic because there isn't such a page.  So in my case, wanting to begin playing around with baking our Geo images as debian instead of alpine (and therein help y'all stabilize debian in the interest of having Geo on a bit more of a robust distro), I had to search around all the image versions to figure out that I wanted to use 0.142.1-debian.
Use Case

Help stabilize debian
Make switching between Geo versions easy
Conform to basic Docker hub standards

Describe Ideal Solution

Have a description page just like this

If I'm missing something and this request is superfluous I'd appreciate the insight.

@jonassteinberg1
I am sorry you had trouble finding out what Docker tag to use. The documentation on the Docker Hub is something we have been neglecting. We really expect people to come to GitHub and read the README, and to use the current release version as shown on the repo front page.
I am not sure what you mean by "the latest releases are pull request releases, etc." The releases are listed on the Releases page with Release Notes as is standard.
The Docker tags are described in the README. If we had a "supported tags" section it would be entirely this:

latest, latest-alpine
latest-debian

The first problem with that is that we discourage people from actually using latest tags because we want them to stay in control of their updates. I think the bigger problem is that such a section is likely to be somewhat misleading, because a lot of Geodesic is configured outside the Dockerfile.  Geodesic is mostly a collection of tools, and most of the tools are updated to whatever is current when the release is built. Many of the rest of the explicitly versioned tools are versioned in external files like requirements.txt. So seeing that the Dockerfile did or did not change is not going to be as helpful as you might think.
We do not have separate release channels for Geodesic (e.g. stable, edge, nightly), we just have regular releases, roughly once a week, although sometimes more often if we have a bugfix to release or a feature to add. It is rare that a release has significant breakage, but when one does, we retroactively mark it as a "pre-release" so people are warned, and of course we fix it promptly. We and our clients use Geodesic literally every day, so significant problems are unlikely to linger.
Would it have been better if the Docker Hub documentation just said "See GitHub README" or something like that, with a link to the GitHub repo? (Assuming we fix #689 :smile:)

@jonassteinberg1 I am closing this as stale and lacking information. I will reopen it if you further explain what it is you would like us to do and it fits our recommended usage and release patterns.


Cannot establish connection between gomobile and browser node using js relay

Version: 0.46.9

Platform: android and js inside mac operating system

Severity: Low
Description:

I have created a go and browser implementation of libp2p and tried establishing connection between them, and it worked. But  after getting gomobile output of go implementation it only works under condition of communicating between mobile devices and it is not able to find browser node inside dht of js-relay. Also browser only can find browser nodes not mobile nodes.
i expected it to find browser node or js finds mobile nodes.

Steps to reproduce the error:
1- Use gomobile and browser implementation, connect them to a js relay.
2- Advertise both and try find other one.
they throw following error :
more peers required, seen: 0  min: 1

Could you give us a link to a project or share the code so that we could try to reproduce the error?


Doc Makefile: Remove trailing '/*' from rm statement

Fixes #154.
Remove the trailing /* from rm -rf $(BUILDDIR)/*. This avoids accidental
hard drive deletion when $BUILDDIR is not set.

No idea what went wrong in CI/CD, seems likely to be unrelated?

Thanks for opening this, @greschd. It looks like the CI/CD complains about not finding act, which is the tool we use for running locally GitHub actions. Let me investigate a bit more.


Optional Formatting

Step 4 optional formatting. Is this something that is done manually or do you have an example on code used to format like this?

@memphisraynz just some excel stuff to adjust the report so it becomes more readable. Steps I usually do:

Invert rows / columns: https://support.microsoft.com/en-us/office/transpose-rotate-data-from-rows-to-columns-or-vice-versa-3419f2e3-beab-4318-aae5-d0f862209744
Freeze the first column as this contains the headings / attribute names
Formatting as table with some decent colours and banded columns to improve readability
Renaming some values such as the list of admin roles included to focus on key configuration

And do not forget to save as excel workbook. - otherwise you loose the changes 🫣


Deleting attachments in comments

Currently attachments in comments cannot be deleted.

Seems to work. Everything else is more redesign than function.
Thanks and closed.

Well I think as for messaging this is perfectly ok.
I'd rather prefer not to get overloaded with messages except important ones.
Is there another location where attachments could be deleted?

Is there another location where attachments could be deleted?
On creating a new issue you can upload attachement

Ah ok. So at least I can delete the attachments later after saving.


output shows error with porcessor-intensive applications

From<EMAIL_ADDRESS>on 2013-07-02T16:26:53Z
Spyder Version:  2.1.10
Python Version:  2.7.3rc2
Qt Version:      4.8.2, PyQt4 (API v1) 4.9.3 on Linux
What steps will reproduce the problem?

enter the code:
for x in range(200):
for y in range(10000):
for z in range(1000):
a=xyz
print x What is the expected output? What do you see instead? The output shows:
96
97
Exception in thread Thread-1:
Traceback (most recent call last):
File "/usr/lib/python2.7/threading.py", line 551, in __bootstrap_inner
self.run()
File "/usr/lib/python2.7/dist-packages/spyderlib/widgets/externalshell/monitor.py", line 588, in run
already_pickled=True)
File "/usr/lib/python2.7/dist-packages/spyderlib/utils/bsdsocket.py", line 24, in write_packet
sock.send(struct.pack("l", len(sent_data)) + sent_data)
error: [Errno 32] Broken pipe

98
99
Please provide any additional information below
. The error occurs in different places every time. This does not seem to affect the running program in any way -- it's just ugly.
Thanks for all your great work!
Attachment: spyder.png
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=1474

From ccordoba12 on 2013-07-04T10:32:49Z
We worked hard to fix this problem in our 2.2 version, so you really need to update Spyder.
Status: Duplicate
Mergedinto: 1106


Drop umd

This will be rebased after the previous patch is merged.

I've also just verified that this change fixes the tests with resin-errors (where I've also just created the modern karma-config for our code)


Fixes  [NoMethodError]: undefined method `miq_alert_statuses' for Clu…

…ster
Fixes  [NoMethodError]: undefined method `miq_alert_statuses' for Cluster

@lfu fixes
[----] E, [2016-02-01T18:19:53.949873 #20749:729994] ERROR -- : [NoMethodError]: undefined method `miq_alert_statuses' for #ManageIQ::Providers::Openstack::InfraManager::EmsCluster:0x0000000741e0b8 Method:[rescue in deliver]
This happens when you assign alert with Cluster, when alert is suppose to send Management event.

@Ladas :+1:


Error "Must not run with sudo" while in step 3 - Configuring Azure Pipelines agent...

I've been following the steps (Windows) in this article, and while executing the docker run command, I'm getting this error message that stops the execution:
PS C:\dockeragent> docker run -e AZP_URL=<my url> -e AZP_TOKEN=<my token> -e AZP_AGENT_NAME=<my agent> -e AZP_POOL=<my pool> dockeragent:latest

Determining matching Azure Pipelines agent...
Downloading and installing Azure Pipelines agent...
Configuring Azure Pipelines agent...
Must not run with sudo
PS C:\dockeragent>

Any clue on what does this mean and how to get past it?
Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b31d4f6c-d16d-2ba1-1294-6aa94e328046
Version Independent ID: 88aec599-4410-697d-1002-1c41b1c17bb6
Content: Running a self-hosted agent in Docker - Azure Pipelines
Content Source: docs/pipelines/agents/docker.md
Product: devops
Technology: devops-cicd
GitHub Login: @juliobbv
Microsoft Alias: alewis

Hi chispadelgado,
Does your start.sh file that you copied from this guide contain this line?
export AGENT_ALLOW_RUNASROOT="1"

Yes. See:
#!/bin/bash
set -e

if [ -z "$AZP_URL" ]; then
  echo 1>&2 "error: missing AZP_URL environment variable"
  exit 1
fi

if [ -z "$AZP_TOKEN_FILE" ]; then
  if [ -z "$AZP_TOKEN" ]; then
    echo 1>&2 "error: missing AZP_TOKEN environment variable"
    exit 1
  fi

  AZP_TOKEN_FILE=/azp/.token
  echo -n $AZP_TOKEN > "$AZP_TOKEN_FILE"
fi

unset AZP_TOKEN

if [ -n "$AZP_WORK" ]; then
  mkdir -p "$AZP_WORK"
fi

rm -rf /azp/agent
mkdir /azp/agent
cd /azp/agent

export AGENT_ALLOW_RUNASROOT="1"

cleanup() {
  if [ -e config.sh ]; then
    print_header "Cleanup. Removing Azure Pipelines agent..."

     Determining matching Azure Pipelines agent..."

AZP_AGENT_RESPONSE=$(curl -LsS \
  -u user:$(cat "$AZP_TOKEN_FILE") \
  -H 'Accept:application/json;api-version=3.0-preview' \
  "$AZP_URL/_apis/distributedtask/packages/agent?platform=linux-x64")

if echo "$AZP_AGENT_RESPONSE" | jq . >/dev/null 2>&1; then
  AZP_AGENTPACKAGE_URL=$(echo "$AZP_AGENT_RESPONSE" \
    | jq -r '.value | map([.version.major,.version.minor,.version.patch,.downloadUrl]) | sort | .[length-1] | .[3]')
fi

if [ -z "$AZP_AGENTPACKAGE_URL" -o "$AZP_AGENTPACKAGE_URL" == "null" ]; then
  echo 1>&2 "error: could not determine a matching Azure Pipelines agent - check that account '$AZP_URL' is correct and the token is valid for that account"
  exit 1
fi

print_header "2. Downloading and installing Azure Pipelines agent..."

curl -LsS $AZP_AGENTPACKAGE_URL | tar -xz & wait $!

source ./env.sh

trap 'cleanup; exit 130' INT
trap 'cleanup; exit 143' TERM

print_header "3. Configuring Azure Pipelines agent..."

 Running Azure Pipelines agent..."

# `exec` the node runtime so it's aware of TERM and INT signals
# AgentService.js understands how to handle agent self-update and restart
exec ./externals/node10/bin/node ./bin/AgentService.js interactive

Interesting. For some reason, the export line that sets up the Ubuntu container to be able to run as root is not being functioning as it's supposed to.
This is the check that config.sh does to detect if the agent is running as root:
https://github.com/microsoft/azure-pipelines-agent/blob/3e0e6dd0111fa53e72e42e4cf14f94ac379cba5a/src/Misc/layoutroot/config.sh
I'm not able to repro this issue on my Windows machine with the same script (i.e. the agent can be configured successfully), so my advice to you is to update to the latest version of Docker for Windows. Mine is Docker Desktop Community, version <IP_ADDRESS> and came from the stable channel.

Same docker version as mine.
Could this have something to do with the fact that I'm behind a corporate network proxy?
I set the proxy in the Dockerfile, and I'm able to run the apt-get updates/install, no problem on that. No sure if this can have an impact on the agent, though.
FROM ubuntu:16.04

# To make it easier for build and release pipelines to run apt-get,
# configure apt to not require confirmation (assume the -y argument by default)
ENV DEBIAN_FRONTEND=noninteractive
RUN echo "APT::Get::Assume-Yes \"true\";" > /etc/apt/apt.conf.d/90assumeyes

ENV http_proxy 'http://<<<username>>>:<<<password>>>@<<<proxyUrl>>>:80'
ENV https_proxy 'http://<<<username>>>:<<<password>>>@<<<proxyUrl>>>:80'

RUN echo "Acquire::http::Proxy \"http://<<<username>>>:<<<password>>>@<<<proxyUrl>>>:80\"; Acquire::https::Proxy \"http://<<<username>>>:<<<password>>>@<<<proxyUrl>>>:80\";" > /etc/apt/apt.conf.d/proxy.conf

RUN apt-get update \
&& apt-get install -y --no-install-recommends \
        ca-certificates \
        curl \
        jq \
        git \
        iputils-ping \
        libcurl3 \
        libicu55

WORKDIR /azp

COPY ./start.sh .

Odd. I don't believe the extra network proxy configuration should interfere with the script setting the environment variable to direct the agent to run as root.
By the way, I updated the docs to set up an agent in a Windows container for Windows hosts. You might have more luck with those new instructions.

I have run into the same problem trying to configure a docker agent in Linux - turns out the URL returned by the TFS Api call (to download the appropriate tar.gz to unpack and configure the agent) contains a package that does not have the check for AGENT_ALLOW_RUNASROOT (config.sh once it is unpacked)
so where it should be:
if [ $user_id -eq 0 -a -z "$AGENT_ALLOW_RUNASROOT" ]; then
is in fact:
if [ $user_id -eq 0 ]; then
and hence the 'Must not run with sudo' message is seen.
This is for the following package:
https://vstsagentpackage.azureedge.net/agent/2.136.1/vsts-agent-linux-x64-2.136.1.tar.gz
which is returned when calling:
https://MY_TFS_v2018.3.2/_apis/distributedtask/packages/agent?platform=linux-x64
I'm seeing if I can get any further by downloading a later version of the package (hard coding the curl call into your script) to see if I can get this working

ok that seems to work - only other thing to note is the call at the end of start.sh
exec ./externals/node10/bin/node ./bin/AgentService.js interactive

should be
exec ./externals/node/bin/node ./bin/AgentService.js interactive

not sure that running a later agent (version wise) than TFS 2018.3.2 knows about is a sensible idea

Which line have you hard-coded the url?
On this one?
AZP_AGENT_RESPONSE=$(curl -LsS \
  -u user:$(cat "$AZP_TOKEN_FILE") \
  -H 'Accept:application/json;api-version=3.0-preview' \
  "$AZP_URL/_apis/distributedtask/packages/agent?platform=linux-x64")

And which version have you used?
Thanks!

Up to you and it depends what you're trying to do - you can leave that line alone or you could remove the api call if you wanted but it doesn't hurt (for me at the moment) and I'd like this to work when we upgrade to TFS 2019 (which does return a newer package). So I've left that alone and just changed this:
# BJ - hard code this to a version that actually looks for the env var set in this script - the version returned from TFS 2018 api does not do this!
#curl -LsS $AZP_AGENTPACKAGE_URL | tar -xz & wait $!
# BJ use hacked package - test out git versions
#curl -LsS https://vstsagentpackage.azureedge.net/agent/2.141.1/vsts-agent-linux-x64-2.141.1.tar.gz | tar -xz & wait $!
curl -LsS http://<IP_ADDRESS>:81/vsts-agent-linux-x64-2.136.1_BenHack.tar.gz | tar -xz & wait $!

I basically tried to download a newer agent package (which has the correct check in config.sh):
https://vstsagentpackage.azureedge.net/agent/2.141.1/vsts-agent-linux-x64-2.141.1.tar.gz
...but this is for Prod TFS 2018 and I don't think this agent version is officially supported (I might be wrong) so I took this package:
https://vstsagentpackage.azureedge.net/agent/2.136.1/vsts-agent-linux-x64-2.136.1.tar.gz and added the missing check in config.sh then repackaged it and I just host it on the docker host machine and download it from there instead. I'm building a pipeline for agents and this is one option so this isn't quite for production yet - I guess you could just add that line in from the script after it has been downloaded and unpacked from MS.
I had to do a couple of other things to get this working - also my test build is complaining that git is out of date on the Linux agent in docker so I've got a few more things to do to get this working properly. I've just created a GitHub account to comment here from my work email so happy to share something if I can tidy this up some more.

@nextbenjy, @chispadelgado: aah, you're running TFS -- that was the piece I was missing. I should've asked that question first 😄. TFS releases are "anchored" to the latest agent version at that point in time, so that's why you're getting an older version package from the endpoint.
BTW, you can just use the latest version of the agent package for your TFS instance -- we support back-compat for TFS 2018 servers. It also has a couple of fixes that will make the agent run better in Docker.
https://github.com/microsoft/azure-pipelines-agent/releases

Yes using TFS 😄
Thanks for the tip - I will try out with a later version of the agent if it's backwards compatible

Sounds good, @nextbenjy.
I'll go ahead and close this issue, as this issue is now well understood.

Actually, I don't think I can personally close the issue (I don't see any option in the UI). @andyjlewis, do I need a special permission? Or do you want to close this issue for me?

Thanks @nextbenjy and @juliobbv.
Yes, it is TFS. I got past that error now by pointing to a newer version.

Not sure if I can use this thread to ask this, but, I was only able to connect to the agent by changing the AUTH mode to Negotiate and adding my username/password when calling config.sh. Any time I try to connect via PAT (and I've got a valid token), I get this error message:

Determining matching Azure Pipelines agent...
Downloading and installing Azure Pipelines agent...
Configuring Azure Pipelines agent...

End User License Agreements:

Building sources from a TFVC repository requires accepting the Team Explorer Everywhere End User License Agreement. This step is not required for building sources from Git repositories.
A copy of the Team Explorer Everywhere license agreement can be found at:
/azp/agent/externals/tee/license.html

Connect:

Basic authentication requires a secure connection to the server.
Have you experienced something like this? What could be the issue (btw, TFS url is http)?

@chispadelgado I am sorry for this great delay in responding to the latest question in the thread, it sounds like a bug and if you haven't already I would file an issue in one (or both) of these two places:
https://github.com/microsoft/azure-pipelines-agent/issues/
https://developercommunity.visualstudio.com/spaces/21/index.html

Hi chispadelgado,
Does your start.sh file that you copied from this guide contain this line?
export AGENT_ALLOW_RUNASROOT="1"

you can also use export RUNNER_ALLOW_RUNASROOT="1"

export RUNNER_ALLOW_RUNASROOT="1" worked for me


In rails 4 the country select form builder is not working

When trying to add the form builder,
= f.country_select :country_of_birth, ["United States"], {}, { :class => "form-control" }
It's throwing an error, i tried couple of solutions and none of them worked for me
Is there a compatibility issue for this gem with rails 4.+?

@charlesskariah this looks similar to #151. The example you provided doesn't appear to be valid country_select syntax. Check out https://country-select-test.herokuapp.com/


Workaround for DashArray with starting 0 on canvas layers

On svg layers a dashArray="0 8 16 8" is fine.
(example result: "  ----    ----  ")
On canvas layers the internal setLineDash([0,8,16,8]) will create artefacts at the begining of the dash.
(example result: "-  ----  -  ----  ")
So we got different results on svg and canvas layers.
This can be workaround by converting the first zero argument into the dashOffset.
( required PR #7867 to support dashOffset)

( required PR #7867 to support dashOffset)

This PR will already contains the changes of #7867

@McBen can you please provide a sample. I can't reproduce the artefact-differences from canvas and svg.
Here a sample: https://plnkr.co/edit/dwb7kGpUrwA0xwsH with 1.7.1
This artefacts are because of linecap:

https://plnkr.co/edit/Wltt2AmC7eG0qN9p
https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/lineCap

yes, you're right. It's about the linecap.


Feature Request: Force update action/button

Hi, thanks for this amazing app.
I was wondering if we could have an option to force Update. Like, I'm currently using the 4.1.1 and I'm aware there's the version 4.2.0.

That would be nice having a button to update, perhaps in help->about or in preferences perhaps.
I know there's a Dialog that should popup, but I'm trying to close the app and show it again and I can't see the update dialog. So I'd love to call this action.
Thanks.
I'm on mac OSX El Capitan 10.11.6

I used to provide a button for this but it was severely exploited and caused a lot of extra traffic to the update server.  We check for updates quite regularly behind the scenes, if you aren't getting an update you are probably behind a proxy/vpn/firewall that is blocking traffic to the update server and I would recommend updating manually 👍

Thanks for your reply. Will do it.


Improvement: Add is_* methods to Tok

Ruff has some lint rules that run on tokens. It would be useful to have is_* methods to avoid extensive matching.

Nice idea.


NullReferenceException on NodeExist method

Hi! I'm having a problem with NodeExist.
I'm making a script that basically adds a text asset and then execute some other code.
I would like to check if the TextAsset that I'm going to add with AddScript has not been added yet, so first, I call:
if(!FindObjectOfType<Yarn.Unity.DialogueRunner>().NodeExists(talkToNode))
{
//If the node doesn't exist, add the conversation
FindObjectOfType<Yarn.Unity.DialogueRunner>().AddScript(yarnConversation);
}

But it throws this:

NullReferenceException: Object reference not set to an instance of an object
Yarn.Dialogue.NodeExists (System.String nodeName)
Yarn.Unity.DialogueRunner.NodeExists (System.String nodeName) (at Assets/Scripts/Yarn Spinner/Code/DialogueRunner.cs:223)

I noticed that if I call AddScript() before calling NodeExist(), it works fine, without throwing NullReferenceException. But I obviously need to check if node exist before add it.
I know its an easy error, but I can't figure out what is null. I debugged, and everything is fine until it executes
public bool NodeExists(string nodeName) {
			return dialogue.NodeExists(nodeName);
		}

on DialogueRunner Class. So the thing must be on Dialogue class, wich I can't debug (because of the dll)
I don't know if I'm doing a wrong use of NodeExist or what.
Thanks so much for reading
Cheers :)

I think I was using it wrong. If I'm not mistaken, throws NullReferenceException because dialogue refers to an active conversation (?), and at the moment it execute NodeExist there is any active dialogue, so it's null.
If it's so, there is any way to check if a certain yarn text has already been added?

It sure seems like DR.dialogue should never be null. So the only way to get an NRE would be because of the dialogue's "program" being null, which has no such guarantees.
Probably could check if program or nodes are null, and return false if so.

Hi!
Might be a bit late, but the issue is as @bowlercaptain says. It sounds like you're trying to call dialogue.NodeExists()the first time before dialogue exists yet. So it's not amazing, but the solution is probably something like
public bool NodeExists(string nodeName) {
    if (dialogue == null) {
        return false; // skip check if no object to check
    }

    return dialogue.NodeExists(nodeName);
}

We'll have a look at adding something like this on our end to support this in the future. Good luck!


HW/SW compilation and simulation - using the MAFIA Build

Goals

You will get familiar with SW/HW compilation and simulation process.
To make sure that all the required software are installed correctly

Required tools

vscode
Python
RISCV GCC
model sim
GitBush

What we are going to do
Generally speaking, we are going to run one of the tests files named alive_vga.c  on one of our  RISCV cores named core_rrv
Step 1 - cloning the fpga_mafia repository

In that section we are going to bring the fpga_mafia from the Github to our local computer.

Choose a location where you would like that fpga_mafia folders will be.
CD to that folder and type

git clone  https://github.com/FPGA-MAFIA/fpga_mafia.git

After Cloning to it (bringing from git hub to your computer) type

cd fpga_mafia

make sure you open the folder in vscode:

Step 2 - running sw compilation

In that section we are going to compile alive_vga.c file. This test prints some values as an output.
That test is located in /verif/core_rrv/test/alive_vga.c

open the alive_vga.c file for review.
Compile that test by typing the following command

./build.py -dut core_rrv -test alive_vga -app

** make sure you run this command from fpga_mafia main folder
3. make sure that the test has passed successfully

Pay attention that new folder named /target has been created. That folder will contain all the outputs of the building process (sw, hw and simulation)

Go to /target/core_rrv/tests/alive_vga/gcc_files and observe the folder content.
Open the file named alive_vga_rv32i_elf.txt. That file is the assembly file of the alive_vga.c test

Step 3 - running hw compilation

In that section we will compile system verilog files of  the cpu core named core_rrv

Type the following command

./build.py -dut core_rrv -test alive_vga -app -hw

make sure the test is passed successfully
Also, review the target and inspect the new generated files and logs
Step 4 - running the simulation

In this section, we will simulate our test alive_vga.c on HW

Type the following command

 ./build.py -dut core_rrv -test alive_vga -app -hw -sim

Observe the created files in the /target/core_rrv/test/alive_vga folder. Some of those files contain core functionality information and can be used for debugging process and tracking after core behavior.

2. Open the screen.log and try to understand its content.
Step 4 - running simulation with gui
In this, section we will run the GUI that shows us the waves of all the signals in the core. Now we will only will check if the gui is opening successfully.

run the following command

 ./build.py -dut core_rrv -test alive_vga -app -hw -sim -gui

make sure the gui is opened(That's it for now)
Let us know if you have any questions

@jacobavitan837 @NoamRahat
Once you you able to run this command:

./build.py -dut core_rrv -test alive_vga -app -hw -sim
Please add a screen-shot as a comment to this issue

@jacobavitan837 if you have installed all the TFM this task is a single like to execute and finish. Please let me know if you have any questions or issues with this

Hi everyone I succeed to run the lines below, I have one warning. the images are arranged in running order

nice work!
Put that warning into chat gpt and ask what causes it :-)

chat gpt tell me to add more backslash to the path


CsvReader gets tripped up by hash characters

This one was a pain to track down.  I've reproduced it with both 3.6.0 and 3.7.0-develop00310.
When a CSV file has both (1) a hash character, and (2) some empty lines at the end, then it misinterprets the whole header row as a single header.
An example:  With the following input (note the empty line 3):
Item_Number,Pmt_Amount,Type,Voided,Note
200212812,$462.76,Check,06/06/2018,Hash#hash

Note the blank line 3 up there^^.  This is needed to reproduce the bug.  Then while reading the first row, reader.FieldCount will return 2, and reader.GetString(0) will return "Item_Number,Pmt_Amount,Type,Voided,Note" (instead of "Item_Number").
Here's a program to demonstrate this issue.
(Apologies that I cannot submit this as a unit test PR, because I'm using VS Code on a Mac and do not have the full deps needed to build the full ExcelDataReader solution.)
using System;
using System.IO;
using System.Collections.Generic;
using ExcelDataReader;

namespace HashBug
{
    class Program
    {
        static void Main(string[] args)
        {
            System.Text.Encoding.RegisterProvider(System.Text.CodePagesEncodingProvider.Instance);

            var filename = "bug-trigger.csv";
            if (File.Exists(filename))
                File.Delete(filename);

            var lines = new List<string>();
            lines.Add("Item_Number,Pmt_Amount,Type,Note,Voided");
            lines.Add("200212812,$462.76,Check,Hash#hash,06/06/2018");
            lines.Add("");
            File.WriteAllLines(filename, lines);

            using (var stream = File.Open(filename, FileMode.Open, FileAccess.Read))
            {
                using (var reader = ExcelReaderFactory.CreateCsvReader(stream))
                {
                    reader.Read();

                    var headers = new Dictionary<int, string>();
                    for (int i = 0; i < reader.FieldCount; i++)
                    {
                        var val = reader.GetString(i);
                        if (val == null)
                            throw new ApplicationException($"BUG ALERT: It thinks it has {reader.FieldCount} data columns but only {i} headers [{string.Join(",", headers)}]");
                        headers[i] = reader.GetString(i).Trim();
                    }
                }
            }
        }
    }
}

This program will crash out with:
3007 ~/dev/xdrIssue/HashBug$ dotnet run
Unhandled exception. System.ApplicationException: BUG ALERT: It thinks it has 2 data columns but only 1 headers [[0, Item_Number,Pmt_Amount,Type,Note,Voided]]
   at HashBug.Program.Main(String[] args) in /Users/grantb/dev/xdrIssue/HashBug/Program.cs:line 36

I think I found a solution.  I need to explicitly specify the separator via an ExcelReaderConfiguration.
var csvCfg = new ExcelReaderConfiguration() { AutodetectSeparators = new char[] { ',' } }
var reader = ExcelReaderFactory.CreateCsvReader(stream, csvCfg);

This is the default:


Add task return true

Can you send this to develop?

OK.
But I use develop branch is not working.


Create Different Sections for Categorizing Games Based on Types

All games can't be categorized under the same section as each game has distinct features, objectives, and audiences. To improve user experience and organization, we need to create different sections for various types of games. This will allow users to easily navigate and explore games based on their preferences.
Example :

Assign me this issue with gssoc-ext hacktoberfest hacktoberfest-accepted labels

can you share the ui

Yes I want this on home page

Sorry,In the guidelines it is already mention there should not be any changes in the home page,Do not be demotivated and raise a new issue.


Add link to factsheet to "show saved_scenario" page

At the moment user's cant create factsheets from saved_scenarios.
the pages with the following path: /saved_scenarios/:id should provide a link to https://beta-pro.energytransitionmodel.com/scenarios/:id.

Closing, fixed in https://github.com/quintel/etmodel/pull/3108


Pre-Release Question

This is more of a question than an issue. 2.1.RC1 (April update) is published at inferno-dev.healthit.gov, what is the timeframe for a pre-release to deploy to production? We have fixes in RC1 which we need for our attestation.

We are trying to finalize release v2.1 today

Thanks yunwwang

v2.1.0 is released


Barre chord being wrongly drawn

I think a bug was introduced when enabling the barre option. Previously, if I used this fret position: x46464, it would generate this chord image:

Now, enabling the full barre draws this:

And disabling it, it draws this:

I believe the 6th fret notes should not be drawn as a barre, since in this case it would mean the 3rd string would also be pressed on the 6th fret which is not intended.

Also, that chord shape is a C#7 or Db7 but the o makes it seem that it is a fully diminished 7th chord which it is not. Also, what is 121311? Are they fingerings? But the 6th string has an "X" meaning it is not to be played.

If it helps, I have a guitar chord namer app that requires a user to enter the fret numbers and has options for sharp vs. flat keys and for different tunings. The defaults are Sharp (#) and Standard Tuning (E-A-D-G-B-e). My Guitar Chord Namer is one of my portfolio projects. You could use it to make sure you have the correct chord name.

I'm very sorry for the late response. For whatever reason I didn't get any notification about this issue. I just noticed it today.
I'll look into it and get back to you.

@amargs , so as @Kernix13 also writes

what is 121311? Are they fingerings? But the 6th string has an "X" meaning it is not to be played.

the fingerings are wrong. The app doesn't determine optimal finger positions itself, but rather relies on you to set them correctly. If you do, you'll get this image (I didn't bother with the chordname):

. Here's a link so you can verify it yourself: https://chordgenerator.luetzners.de/#D.png?p=x46464&f=-12131&s=2&b=false
I hope that helps. Thanks for using Chordgenerator. :slightly_smiling_face:

I assume that this is no longer an issue, so I'll close this ticket for now.


Mysql2::Error: Incorrect string value: '\xE9..' for column postal-server-4.messages.subject at row 1

Describe the bug
Mail will not be accepted if it is in ISO-8859 format and the Subject contain special chars.  It seems similar to https://github.com/postalserver/postal/issues/588 which was fixed in https://github.com/postalserver/postal/pull/391 ("Message database default character set utf8mb4"), but in this case it is a recent Postal server (a few months old, just before the docker-based version) and all databases/tables are using the utf8mb4 encoding   (select * from information_schema.columns where table_name LIKE 'messages' and column_name like 'subject' in DB postal-server-4 shows utf8mb4 / utf8mb4_unicode_ci as CHARACTER_SET_NAME / COLLATION_NAME).
This happened to us for mails sent via a simple php application to postfix, then using postal as a relay.
To Reproduce

copy this to a file named mailtest.sh:

#!/bin/bash

{
	sleep 2
	echo 'ehlo example.org'
	sleep 2
	echo 'mail from<EMAIL_ADDRESS>	sleep 1
	echo 'rcpt to<EMAIL_ADDRESS>	sleep 1
	echo 'DATA'
	sleep 1
	echo 'To<EMAIL_ADDRESS>	echo 'Subject: Votre livraison de blé cette semaine'
	echo 'From<EMAIL_ADDRESS>	echo 'Content-type: text/plain; charset=iso-8859-1'
	echo 'Message-Id: <20210926192527.5301F10E1ACC@localhost>'
	echo 'Date: Sun, 26 Sep 2021 21:25:27 +0200 (CEST)'
	echo ''
	echo 'Bla Bla Bla'
	echo ''
	echo '.'
} | telnet postal.example.org 2525

make sure it's iso-8859-1 encoded:  with file:

$ file mailtest.sh
mailtest.sh: Bourne-Again shell script, ISO-8859 text executable

if it is not the case, convert it :

$ file mailtest2.sh
mailtest2.sh: Bourne-Again shell script, UTF-8 Unicode text executable
$ iconv -f UTF-8 -t ISO-8859-1 mailtest2.sh -o mailtest2_converted_iso.sh
$ file mailtest2_converted_iso.sh
mailtest2_converted_iso.sh: Bourne-Again shell script, ISO-8859 text executable

run the shell script :   ./mailtest.sh
output in the postal server logs:

==> /opt/postal/log/smtp_server.log <==
[smtp.4:637963] [2021-10-08T17:36:36.695] DEBUG -- : [NN0HHF]    Connection opened from ::ffff:<IP_ADDRESS>
[smtp.4:637963] [2021-10-08T17:36:36.695] DEBUG -- : [NN0HHF]    Client identified as ::ffff:<IP_ADDRESS>
[smtp.4:637963] [2021-10-08T17:36:38.680] DEBUG -- : [NN0HHF] <= ehlo example.org
[smtp.4:637963] [2021-10-08T17:36:38.691] DEBUG -- : [NN0HHF] => 250-My capabilities are
[smtp.4:637963] [2021-10-08T17:36:38.692] DEBUG -- : [NN0HHF] => 250 AUTH CRAM-MD5 PLAIN LOGIN
[smtp.4:637963] [2021-10-08T17:36:40.682] DEBUG -- : [NN0HHF] <= mail from<EMAIL_ADDRESS>[smtp.4:637963] [2021-10-08T17:36:40.682] DEBUG -- : [NN0HHF] => 250 OK
[smtp.4:637963] [2021-10-08T17:36:41.683] DEBUG -- : [NN0HHF] <= rcpt to<EMAIL_ADDRESS>[smtp.4:637963] [2021-10-08T17:36:41.694] DEBUG -- : [NN0HHF] Added external address<EMAIL_ADDRESS>[smtp.4:637963] [2021-10-08T17:36:41.694] DEBUG -- : [NN0HHF] => 250 OK
[smtp.4:637963] [2021-10-08T17:36:42.685] DEBUG -- : [NN0HHF] <= DATA
[smtp.4:637963] [2021-10-08T17:36:42.685] DEBUG -- : [NN0HHF] => 354 Go ahead
[smtp.4:637963] [2021-10-08T17:36:43.686] DEBUG -- : [NN0HHF] <= To<EMAIL_ADDRESS>[smtp.4:637963] [2021-10-08T17:36:43.686] DEBUG -- : [NN0HHF] Not logging further message data.
[smtp.4:637963] [2021-10-08T17:36:43.700] ERROR -- : [NN0HHF] An error occurred while processing data from a client.
[smtp.4:637963] [2021-10-08T17:36:43.700] ERROR -- : [NN0HHF] Mysql2::Error: Incorrect string value: '\xE9 cett...' for column `postal-server-4`.`messages`.`subject` at row 1
[smtp.4:637963] [2021-10-08T17:36:43.700] ERROR -- : [NN0HHF] /opt/postal/vendor/bundle/ruby/2.5.0/gems/mysql2-0.5.3/lib/mysql2/client.rb:131:in `_query'
[smtp.4:637963] [2021-10-08T17:36:43.700] ERROR -- : [NN0HHF] /opt/postal/vendor/bundle/ruby/2.5.0/gems/mysql2-0.5.3/lib/mysql2/client.rb:131:in `block in query'
[smtp.4:637963] [2021-10-08T17:36:43.700] ERROR -- : [NN0HHF] /opt/postal/vendor/bundle/ruby/2.5.0/gems/mysql2-0.5.3/lib/mysql2/client.rb:130:in `handle_interrupt'
[smtp.4:637963] [2021-10-08T17:36:43.700] ERROR -- : [NN0HHF] /opt/postal/vendor/bundle/ruby/2.5.0/gems/mysql2-0.5.3/lib/mysql2/client.rb:130:in `query'
[smtp.4:637963] [2021-10-08T17:36:43.700] ERROR -- : [NN0HHF] /opt/postal/app/lib/postal/message_db/database.rb:319:in `query_on_connection'
[smtp.4:637963] [2021-10-08T17:36:43.700] ERROR -- : [NN0HHF] /opt/postal/app/lib/postal/message_db/database.rb:224:in `block in insert'
[smtp.4:637963] [2021-10-08T17:36:43.700] ERROR -- : [NN0HHF] /opt/postal/app/lib/postal/message_db/mysql.rb:20:in `client'
[smtp.4:637963] [2021-10-08T17:36:43.700] ERROR -- : [NN0HHF] /opt/postal/app/lib/postal/message_db/database.rb:342:in `with_mysql'
[smtp.4:637963] [2021-10-08T17:36:43.700] ERROR -- : [NN0HHF] /opt/postal/app/lib/postal/message_db/database.rb:223:in `insert'
[smtp.4:637963] [2021-10-08T17:36:43.700] ERROR -- : [NN0HHF] /opt/postal/app/lib/postal/message_db/message.rb:565:in `_create'
[smtp.4:637963] [2021-10-08T17:36:43.700] ERROR -- : [NN0HHF] /opt/postal/app/lib/postal/message_db/message.rb:206:in `save'
[smtp.4:637963] [2021-10-08T17:36:43.700] ERROR -- : [NN0HHF] /opt/postal/app/lib/postal/smtp_server/client.rb:428:in `block in finished'
[smtp.4:637963] [2021-10-08T17:36:43.700] ERROR -- : [NN0HHF] /opt/postal/app/lib/postal/smtp_server/client.rb:414:in `each'
[smtp.4:637963] [2021-10-08T17:36:43.700] ERROR -- : [NN0HHF] /opt/postal/app/lib/postal/smtp_server/client.rb:414:in `finished'
[smtp.4:637963] [2021-10-08T17:36:43.700] ERROR -- : [NN0HHF] /opt/postal/app/lib/postal/smtp_server/client.rb:351:in `block in data'
[smtp.4:637963] [2021-10-08T17:36:43.700] ERROR -- : [NN0HHF] /opt/postal/app/lib/postal/smtp_server/client.rb:47:in `handle'
[smtp.4:637963] [2021-10-08T17:36:43.701] ERROR -- : [NN0HHF] /opt/postal/app/lib/postal/smtp_server/server.rb:160:in `block (2 levels) in run_event_loop'
[smtp.4:637963] [2021-10-08T17:36:43.701] ERROR -- : [NN0HHF] /opt/postal/app/lib/postal/smtp_server/server.rb:87:in `select'
[smtp.4:637963] [2021-10-08T17:36:43.701] ERROR -- : [NN0HHF] /opt/postal/app/lib/postal/smtp_server/server.rb:87:in `block in run_event_loop'
[smtp.4:637963] [2021-10-08T17:36:43.701] ERROR -- : [NN0HHF] /opt/postal/app/lib/postal/smtp_server/server.rb:85:in `loop'
[smtp.4:637963] [2021-10-08T17:36:43.701] ERROR -- : [NN0HHF] /opt/postal/app/lib/postal/smtp_server/server.rb:85:in `run_event_loop'
[smtp.4:637963] [2021-10-08T17:36:43.701] ERROR -- : [NN0HHF] /opt/postal/app/lib/postal/smtp_server/server.rb:260:in `run'
[smtp.4:637963] [2021-10-08T17:36:43.701] ERROR -- : [NN0HHF] /opt/postal/app/lib/tasks/postal.rake:13:in `block (2 levels) in <top (required)>'
[smtp.4:637963] [2021-10-08T17:36:43.701] ERROR -- : [NN0HHF] /opt/postal/vendor/bundle/ruby/2.5.0/gems/rake-12.3.3/lib/rake/task.rb:273:in `block in execute'
[smtp.4:637963] [2021-10-08T17:36:43.701] ERROR -- : [NN0HHF] /opt/postal/vendor/bundle/ruby/2.5.0/gems/rake-12.3.3/lib/rake/task.rb:273:in `each'
[smtp.4:637963] [2021-10-08T17:36:43.701] ERROR -- : [NN0HHF] /opt/postal/vendor/bundle/ruby/2.5.0/gems/rake-12.3.3/lib/rake/task.rb:273:in `execute'
[smtp.4:637963] [2021-10-08T17:36:43.701] ERROR -- : [NN0HHF] /opt/postal/vendor/bundle/ruby/2.5.0/gems/rake-12.3.3/lib/rake/task.rb:214:in `block in invoke_with_call_chain'
[smtp.4:637963] [2021-10-08T17:36:43.701] ERROR -- : [NN0HHF] /usr/local/rvm/rubies/ruby-2.5.8/lib/ruby/2.5.0/monitor.rb:235:in `mon_synchronize'
[smtp.4:637963] [2021-10-08T17:36:43.701] ERROR -- : [NN0HHF] /opt/postal/vendor/bundle/ruby/2.5.0/gems/rake-12.3.3/lib/rake/task.rb:194:in `invoke_with_call_chain'
[smtp.4:637963] [2021-10-08T17:36:43.701] ERROR -- : [NN0HHF] /opt/postal/vendor/bundle/ruby/2.5.0/gems/rake-12.3.3/lib/rake/task.rb:183:in `invoke'
[smtp.4:637963] [2021-10-08T17:36:43.701] ERROR -- : [NN0HHF] /opt/postal/vendor/bundle/ruby/2.5.0/gems/rake-12.3.3/lib/rake/application.rb:160:in `invoke_task'
[smtp.4:637963] [2021-10-08T17:36:43.701] ERROR -- : [NN0HHF] /opt/postal/vendor/bundle/ruby/2.5.0/gems/rake-12.3.3/lib/rake/application.rb:116:in `block (2 levels) in top_level'
[smtp.4:637963] [2021-10-08T17:36:43.701] ERROR -- : [NN0HHF] /opt/postal/vendor/bundle/ruby/2.5.0/gems/rake-12.3.3/lib/rake/application.rb:116:in `each'
[smtp.4:637963] [2021-10-08T17:36:43.701] ERROR -- : [NN0HHF] /opt/postal/vendor/bundle/ruby/2.5.0/gems/rake-12.3.3/lib/rake/application.rb:116:in `block in top_level'
[smtp.4:637963] [2021-10-08T17:36:43.701] ERROR -- : [NN0HHF] /opt/postal/vendor/bundle/ruby/2.5.0/gems/rake-12.3.3/lib/rake/application.rb:125:in `run_with_threads'
[smtp.4:637963] [2021-10-08T17:36:43.701] ERROR -- : [NN0HHF] /opt/postal/vendor/bundle/ruby/2.5.0/gems/rake-12.3.3/lib/rake/application.rb:110:in `top_level'
[smtp.4:637963] [2021-10-08T17:36:43.701] ERROR -- : [NN0HHF] /opt/postal/vendor/bundle/ruby/2.5.0/gems/rake-12.3.3/lib/rake/application.rb:83:in `block in run'
[smtp.4:637963] [2021-10-08T17:36:43.701] ERROR -- : [NN0HHF] /opt/postal/vendor/bundle/ruby/2.5.0/gems/rake-12.3.3/lib/rake/application.rb:186:in `standard_exception_handling'
[smtp.4:637963] [2021-10-08T17:36:43.701] ERROR -- : [NN0HHF] /opt/postal/vendor/bundle/ruby/2.5.0/gems/rake-12.3.3/lib/rake/application.rb:80:in `run'
[smtp.4:637963] [2021-10-08T17:36:43.701] ERROR -- : [NN0HHF] /opt/postal/vendor/bundle/ruby/2.5.0/gems/rake-12.3.3/exe/rake:27:in `<top (required)>'
[smtp.4:637963] [2021-10-08T17:36:43.701] ERROR -- : [NN0HHF] /opt/postal/vendor/bundle/ruby/2.5.0/bin/rake:23:in `load'
[smtp.4:637963] [2021-10-08T17:36:43.702] ERROR -- : [NN0HHF] /opt/postal/vendor/bundle/ruby/2.5.0/bin/rake:23:in `<main>'
[smtp.4:637963] [2021-10-08T17:36:43.702] ERROR -- : [NN0HHF] /usr/local/rvm/gems/ruby-2.5.8/bin/ruby_executable_hooks:22:in `eval'
[smtp.4:637963] [2021-10-08T17:36:43.702] ERROR -- : [NN0HHF] /usr/local/rvm/gems/ruby-2.5.8/bin/ruby_executable_hooks:22:in `<main>'

Expected behaviour
Mail should be accepted.
Environment details
$ postal version
1.0.0-2595481b26-stable
$ postal status
Procodile Version   1.0.26
Application Root    /opt/postal/app
$ ruby --version
ruby 2.5.8p224 (2020-03-31 revision 67882) [x86_64-linux]
Additional information/context
If somebody could test this against latest version it would be nice,  I will try next week otherwise.
Please let me know if you miss any information, and I will update the ticket accordingly.
Thanks & best regards.

I can't reproduce this.


What should be outLength in shrink_buffer?

Any formula for calculating the needed outLength? In README it says:  Before execution *outlength should contain the length of _*out_  but in main.c line 137 you are multiplying the inLength to 16. What is proper outLength value?
Thank you for your effort on this library.

Did you solve your issue then? (or do you think the documentation needs updating?)


Bump num-traits to 0.2

This is a breaking change because it removes compatibility with the old num-trait version.

Unless I missed it, this isn't used in our public API

Yes, your right :+1:
I'm not sure what causes the ci error. Otherwise this look fine.

CI is red due to #1602. Assuming this is fine if that weren't a problem.


Feature/remember me

Заодно вынес все управление сессиями в отдельный компонент

Codecov Report

Merging #16 (fe1322c) into main (fae9b54) will increase coverage by 1.93%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   96.71%   98.65%   +1.93%
==========================================
  Files          22       30       +8
  Lines         457      669     +212
==========================================
+ Hits          442      660     +218
+ Misses         15        9       -6

Impacted Files
Coverage Δ

test/cyberdas/routes.py
100.00% <0.00%> (ø)

test/cyberdas/models/user.py
100.00% <0.00%> (ø)

test/cyberdas/models/session.py
100.00% <0.00%> (ø)

test/cyberdas/models/__init__.py
100.00% <0.00%> (ø)

test/cyberdas/resources/login.py
100.00% <0.00%> (ø)

test/cyberdas/resources/logout.py
100.00% <0.00%> (ø)

test/cyberdas/resources/refresh.py
100.00% <0.00%> (ø)

test/cyberdas/services/__init__.py
100.00% <0.00%> (ø)

test/cyberdas/resources/__init__.py
100.00% <0.00%> (ø)

test/cyberdas/models/long_session.py
100.00% <0.00%> (ø)

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fae9b54...fe1322c. Read the comment docs.


Validate new-archive forms before saving

Add validation to all new-archive forms.

Completed for Dropbox.


feat(Table): add attached prop

Fixes #591

Would you mind updating the PR description to include Fixes #591 so it auto closes the issue on merge?
Just one lint issue failing tests:
src/collections/Table/Table.js
  119:1  error  Trailing spaces not allowed  no-trailing-spaces

Current coverage is 100% (diff: 100%)

Merging #593 into master will not change coverage

@@           master   #593   diff @@
====================================
  Files         119    119
  Lines        1894   1894
  Methods         0      0
  Messages        0      0
  Branches        0      0
====================================
  Hits         1894   1894
  Misses          0      0
  Partials        0      0

Powered by Codecov. Last update 7fff825...5435210

Released in<EMAIL_ADDRESS>thanks for the PR!


Add a timestamp field to the contact form

To debug double submissions, we're sending a timestamp and a random number in the contact form. The field Profession was suggested by them because it's unused.
Testing instructions.

https://pearson-test.sandbox.stage.opencraft.hosting/courses/course-v1:testing1+other2+2018_02/about and click „enquire now“
check in the HTML that the "oid" parameter has a nonsense value instead of their ID. Then you'll be able to submit the form without altering their DB. The form also has debug=1 so it will send you to a debug page
fill the form and submit it, it will go to a debug page
check the contents of the field 00N58000003di7f, it should have XXXXXXXX-YYYYY, where XXXXXXX is a timestamp (in ~~ms) and YYYYY a random number
Check that the code is in the right place (e.g. if some clicked the button twice, it would send different results

Reviewers: one of:

@ciuin (if available)
@bradenmacdonald
or TBD

@clemente You can also just put this code on the live server or deploy a server using this branch as the theme, since it's only for debugging. We don't necessarily have to merge this.
Code looks good, but I think you should put the randomization inside the $("form#contact-form").submit(function (event){ event handler, or at least some way of finding out if that method is being called twice, such as putting something in there like $("#00N58000003di7f").val($("#00N58000003di7f").val() + '-submit') so we can tell if that handler is somehow getting called twice.

@bradenmacdonald Thanks for catching this; I had it there and moved it for some reason.
Ok, deploying.


"Expected to decode String but found a dictionary instead."

it seems to me that there is an issue with the messagesApi.getMessages when the message contains annotations. (Generated when the assistant uses the "retrieval" tool to search files.)
typeMismatch(Swift.String, Swift.DecodingError.Context(codingPath: [CodingKeys(stringValue: "data", intValue: nil), _JSONKey(stringValue: "Index 0", intValue: 0), CodingKeys(stringValue: "content", intValue: nil), _JSONKey(stringValue: "Index 0", intValue: 0), CodingKeys(stringValue: "text", intValue: nil), CodingKeys(stringValue: "annotations", intValue: nil), _JSONKey(stringValue: "Index 0", intValue: 0)], debugDescription: "Expected to decode String but found a dictionary instead.", underlyingError: nil))
Shall we change the "public let annotations:[String]?" and consider that annotations is an array of File citation
object and File path object ?

Thank you for bringing the issue with the messagesApi.getMessages function to our attention. To help us better understand and resolve the problem, could you please provide us with the full JSON response where this error occurs? This information will be crucial in diagnosing and fixing the issue more effectively.
Thank you for your cooperation and assistance in improving our library.

This is an issue which appears when assistant cites information from a file in the answer (with retrieval tool), please revise data model for this. Easy to reproduce. Thanks 🙏


silverblue-main causes flickering issues on AMD 13 Framework

What happened?
Hello,
I just installed a fresh copy of silverblue on my Framework AMD 13 laptop. I immediately rebased to ublue/silverblue-main (39). Things seemed to work well, until I tried anything in fullscreen. Videos and games both caused a rather aggressive white checkered flicker while in fullscreen. Non-fullscreen seemed to work fine. I rebased back to normal Fedora Silverblue 39 and things are working normally again!
Sorry I don't have logs or anything, feel free to close if this isn't helpful.
Relevant log output
No response

I think you might be missing the relevant kargs? I don't have an AMD Framework (rocking intel here). So I'm not sure if those are relevant, but hoping to see if we can narrow the problem down.

Thanks. Yes, it seems like kargs (specifically amdgpu.sg_display=0) and the UMA_GAME_OPTIMIZED setting in the bios are actually more relevant than the image choice. Source. It still seems like the difference mattered, but I'm happy with closing this and pointing to the source link.

Thanks for the link! Moving this to bluefin and opening it so we can track enablement there.


Deduplicate failed tasks in monitoring email

Credit to Martin for this one. I'm trying to clear out my TODO list before shutdown and finally got around to copying this very useful code from SDEngine.
It may not help us as much, since those SDEngine tasks usually have the same args / kwargs and errors can be deduplicated easily. In Corgi the failure-spam we see is usually for "fetch Brew build 1, 2, 3..." and so on, so there's very little to deduplicate. But it will help in some cases.

@juspence / @jasinner is this still applicable ? If not should we close and revisit in the future ?

hoping @juspence is ok with us merging this nice work


SyntaxError when import pytorch_pfn_extras.training.extensions with py3.7

To reproduce: from pytorch_pfn_extras.training import extensions as ppe_exts, triggers as ppe_triggers
Error message:
Traceback (most recent call last):

  File "/opt/conda/lib/python3.7/site-packages/IPython/core/interactiveshell.py", line 3437, in run_code
    exec(code_obj, self.user_global_ns, self.user_ns)

  File "<ipython-input-2-8e074eaf758b>", line 28, in <module>
    import pytorch_pfn_extras as ppe

  File "/opt/conda/lib/python3.7/site-packages/pytorch_pfn_extras/__init__.py", line 12, in <module>
    from pytorch_pfn_extras import training  # NOQA

  File "/opt/conda/lib/python3.7/site-packages/pytorch_pfn_extras/training/__init__.py", line 1, in <module>
    from pytorch_pfn_extras.training.extension import Extension  # NOQA

  File "/opt/conda/lib/python3.7/site-packages/pytorch_pfn_extras/training/extension.py", line 47
    trigger: 'TriggerLike' = 1, 'iteration'
                              ^
SyntaxError: invalid syntax

Environment:
Python 3.7.10, using pytorch-pfn-extras 0.4.3
pytorch-pfn-extras 0.4.1 works fine
BTW, thanks for all the great work!

Thanks for reporting! We've just noticed that and released a hot-fix.
https://github.com/pfnet/pytorch-pfn-extras/releases/tag/v0.4.4


It's alliiiiiiveeeee

Rebase successful,
Firebase not functional due to API Key leak,
DB functions are correct,
Added GoogleService-Info.plist to gitignore to prevent further API key leaks

LGTM


Adding to app views path for sake of e2e

I've added to the path for ch-node-utils/templates because I think docker-chs-dev needs one path and e2e another.

CI: No security warnings found


Pull request for #6 [Send and Receive Workflow/UI]

Pull request for  #6  [Send and Receive Workflow/UI]

@MeghaBambra I've added the change to fix the camera issue.


fix: accessing settings during database reset causes error (resolves #2106)

Resolves #2106

Updates php artisan app:refresh-dev to pre-render the 503 error page
Updates the settings helper function to return the default if the settings database table isn't present
Sets defaults when checking the settings for the phone number and address

Prerequisites
If this PR changes PHP code or dependencies:

[x] I've run composer format and fixed any code formatting issues.
[x] I've run composer analyze and addressed any static analysis issues.
[x] I've run php artisan test and ensured that all tests pass.
[x] I've run composer localize to update localization source files and committed any changes.

If this PR changes CSS or JavaScript code or dependencies:

[ ] I've run npm run lint and fixed any linting issues.
[ ] I've run npm run build and ensured that CSS and JavaScript assets can be compiled.

I ran the same test locally on a container built with the jobara:GH-2106.
I was no longer able to duplicate any of the errors when running php artisan app:refresh-dev

As a note, I wasn't able to test the case from the settings function where the table doesn't exist. I could drop the table, but it was causing other tests to break, so I've left it off. Hence the drop in coverage.


Remove Cert K8s

Pre-submission checklist:
Please check each of these after submitting your pull request:

[ ] Are you only including a repo_url if your project is 100% open source? If so, you need to pick the single best GitHub repository for your project, not a GitHub organization.
[ ] Is your project closed source or, if it is open source, does your project have at least 300 GitHub stars?
[ ] Have you picked the single best (existing) category for your project?
[ ] Does it follow the other guidelines from the new entries section?
[ ] Have you added your SVG to hosted_logos and referenced it there?
[ ] Does your logo clearly state the name of the project/product and follow the other logo guidelines?
[ ] Does your project/product name match the text on the logo?
[ ] Have you verified that the Crunchbase data for your organization is correct (including headquarters and LinkedIn)?
[x] ~15 minutes after opening the pull request, the CNCF-Bot will post the URL for your staging server. Have you confirmed that it looks good to you and then added a comment to the PR saying "LGTM"?

LGTM

Build failed because of:
No cached entry, and can not fetch: deckhouse. 404 - {"error":"requested resource could not be found","code":"CS404"}
No cached entry, and Flant Deckhouse has issues with logo: flant-deckhouse.svg, ENOENT: no such file or directory, open '/opt/build/repo/hosted_logos/flant-deckhouse.svg'
No cached entry, and Valve Software (member) has issues with twitter: https://twitter.com/valveoficial, 404 - {"errors":[{"code":34,"message":"Sorry, that page does not exist."}]}
No cached entry, and Sosivio (member) has issues with twitter: https://twitter.com/SosivioLtd, 404 - {"errors":[{"code":34,"message":"Sorry, that page does not exist."}]}
Empty twitter for Rancher Federal (member): https://twitter.com/rancherfederal
Empty twitter for Itera (member): https://twitter.com/iteraio
Empty twitter for FireHydrant (member): https://twitter.com/firehydrantio
No cached entry, and Kingsoft (member) has issues with twitter: https://twitter.com/KingsoftC, 401 - {"request":"/1.1/statuses/user_timeline","error":"Not authorized."}
No cached entry, and Kingsoft Cloud (KCSP) has issues with twitter: https://twitter.com/KingsoftC, 401 - {"request":"/1.1/statuses/user_timeline","error":"Not authorized."}
No cached entry, and Kingsoft Cloud has issues with twitter: https://twitter.com/KingsoftC, 401 - {"request":"/1.1/statuses/user_timeline","error":"Not authorized."}
Empty twitter for Standard Library: https://twitter.com/AutocodeHQ
Empty twitter for StackStorm: https://twitter.com/Stack_Storm
Flant Deckhouse either has no crunchbase entry or it is invalid

Build failed because of:
No cached entry, and can not fetch: deckhouse. 404 - {"error":"requested resource could not be found","code":"CS404"}
No cached entry, and Valve Software (member) has issues with twitter: https://twitter.com/valveoficial, 404 - {"errors":[{"code":34,"message":"Sorry, that page does not exist."}]}
No cached entry, and Sosivio (member) has issues with twitter: https://twitter.com/SosivioLtd, 404 - {"errors":[{"code":34,"message":"Sorry, that page does not exist."}]}
Empty twitter for Rancher Federal (member): https://twitter.com/rancherfederal
Empty twitter for Itera (member): https://twitter.com/iteraio
Empty twitter for FireHydrant (member): https://twitter.com/firehydrantio
No cached entry, and Kingsoft (member) has issues with twitter: https://twitter.com/KingsoftC, 401 - {"request":"/1.1/statuses/user_timeline","error":"Not authorized."}
No cached entry, and Kingsoft Cloud (KCSP) has issues with twitter: https://twitter.com/KingsoftC, 401 - {"request":"/1.1/statuses/user_timeline","error":"Not authorized."}
No cached entry, and Kingsoft Cloud has issues with twitter: https://twitter.com/KingsoftC, 401 - {"request":"/1.1/statuses/user_timeline","error":"Not authorized."}
Empty twitter for Standard Library: https://twitter.com/AutocodeHQ
Empty twitter for StackStorm: https://twitter.com/Stack_Storm
Flant Deckhouse either has no crunchbase entry or it is invalid

@caniszczyk LGTM, thanks

@taylorwaggoner have conflicts here


[BUG] fuzziness parameter isn't validated in search queries

Describe the bug
fuzziness parameter value isn't validated.
To Reproduce
Steps to reproduce the behavior:
curl -XGET 'http://localhost:9200/_search?pretty' -d '{"query":{"match_bool_prefix":{"date":{"query":"1972-07-04 00:00:00", "fuzziness":"+++"}}}}' -H 'Content-Type: application/json'

returns 200
Other values tested: ololo, 42, 5,1, AUTO: and so on. Tested in OpenSearch API and other search queries as well.
Expected behavior
An error message, like negative boost value produces
Plugins
Default set
Host/Environment (please complete the following information):

OS: Win 11 + WSL + docker
Version: 2.1.0

Additional context
See also: #3749

Assigning to me for now for tracking and investigation.

According to the docs, https://opensearch.org/docs/latest/opensearch/query-dsl/full-text/#run-fuzzy-queries, valid input is AUTO, 0, 1, 2, or some other positive integer. In https://github.com/opensearch-project/OpenSearch/blob/10bff0c9f5b9ca78b3dc50f5c704dabf41b9d535/server/src/main/java/org/opensearch/common/unit/Fuzziness.java, it looks like we are not checking for that valid input in any constructors.

Exactly.
I see from elastic documentation, AUTO:int,int (e.g. AUTO:1,2) is also a valid value.

could I work on this one?

Hi ,I want to work on this issue

@Manishpandey11 Go ahead and submit a PR!  Let us know if you need help.

@Manishpandey11, you can go for it, I haven't done much work on this as I don't have the electricity supply to work on this one right now (rolling power cuts in South Africa).

According to the docs, https://opensearch.org/docs/latest/opensearch/query-dsl/full-text/#run-fuzzy-queries, valid input is AUTO, 0, 1, 2, or some other positive integer. In https://github.com/opensearch-project/OpenSearch/blob/10bff0c9f5b9ca78b3dc50f5c704dabf41b9d535/server/src/main/java/org/opensearch/common/unit/Fuzziness.java, it looks like we are not checking for that valid input in any constructors.

@macohen : I've raised a MR for this defect. Can you please review this?

I have written tests for this. But I see some of the existing tests like testNumerics() try to assert double fuzziness values like "1.000" which will fail after the current validation in the constructor. If floating point value is expected, I see we are trying to parse with Integer.parseInt() in parseCustomAuto(), so this should already throw NumberFormatException.

Fuzziness interface is refactored https://github.com/opensearch-project/OpenSearch/pull/5433/files
We can determine if any additional validations are required.

From here,
https://github.com/opensearch-project/OpenSearch/blob/main/server/src/test/java/org/opensearch/index/query/FuzzyQueryBuilderTests.java#L118-L119
This case below should return 400 instead of 200. Next step is to fix the bug.

Describe the bug
fuzziness parameter value isn't validated.
To Reproduce
Steps to reproduce the behavior:
curl -XGET 'http://localhost:9200/_search?pretty' -d '{"query":{"match_bool_prefix":{"date":{"query":"1972-07-04 00:00:00", "fuzziness":"+++"}}}}' -H 'Content-Type: application/json'

returns 200 Other values tested: ololo, 42, 5,1, AUTO: and so on. Tested in OpenSearch API and other search queries as well.
Expected behavior
An error message, like negative boost value produces
Plugins
Default set
Host/Environment (please complete the following information):

OS: Win 11 + WSL + docker
Version: 2.1.0

Additional context
See also: #3749

Closing, fixed in #5805.


Refactor to bump sre-engine to v0.3.0

@youknowone we need to publish the sre-engine and bump the version

would you set sre-engine's main branch to 0.3.0? there are 2 opened pr and both including 0.3.0 changes, so it is confusing.


Added AnchoredOverlay story

Parent issue: https://github.com/github/primer/issues/1488
Add storybook stories for AnchoredOverlay
Checklist

[x]  Ensure your chosen component has a component directory in the src directory
[x]  Ensure the component has a root story file in the component directory
[x]  Ensure that the root story file exports a Default story
[x]  (Optional) Create a Playground story
[x]  Move all other stories for the component into a .features.stories.tsx file
[x]  Opt the component into storybook tests
[ ]  (Optional) Create visual regression tests for the component

Hey @mperrotti, heads up that this is ready for review!


Wallet linking given code issue

Describe the bug
Hello, when we register to the platform via Twitter and create a wallet, we generate a key called the account seed and we have a wallet ID. The problem is that we do the same with most crypto wallets and the key seed we generate in case we lose our wallet or use it to import it elsewhere
At first I thought it was my seed but it wasn't. To get my private key, I had to open the platform and find the backup partition. Many users had the same problem. Now I can't login to my wallet.
It has been suggested that I can create another one, but my account is linked to that wallet so I cannot create another wallet for my twitter.
 It would be better if we generate our real account seed during the wallet creation process otherwise we will not be able to access our wallet as I cannot do it now.
Big problem for me and for novice people like me
Reproduction
...
System Info
....

Logs
....

Validations

[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Bende bu konudan müzdaribim.bende hatırlamıyorum kodlarımı,yenisini de açamıyorum.mutlak bı çözüm gerekli bu konu da yoksa epey kişi zarar görecek 😔


Add 0.17.1/019.1 release docs

Backporting the fix to 0.17 for those who have not done the mesos 1 upgrade. Skipping 0.18 since it is the same mesos version as 0.19

🚢


Handle 'Infer T' inside template literal types

Codecov Report
Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.75%. Comparing base (ea2b19b) to head (c357b83).
Report is 1 commits behind head on main.

Files
Patch %
Lines

src/Escalier.TypeChecker/Unify.fs
85.71%
2 Missing :warning:

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #346   +/-   ##
=======================================
  Coverage   83.74%   83.75%
=======================================
  Files          22       22
  Lines       12143    12156   +13
  Branches     1732     1733    +1
=======================================
+ Hits        10169    10181   +12
- Misses       1974     1975    +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[e2e]: delegator-generic release main default slsa3

Repo: https://github.com/slsa-framework/example-package/tree/v42.0.257
Run: https://github.com/slsa-framework/example-package/actions/runs/8548262541
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.delegator-generic.release.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.delegator-generic.release.main.default.slsa3.yml
Trigger: release
Branch: v42.0.257
Date: Thu Apr  4 02:13:38 UTC 2024

Repo: https://github.com/slsa-framework/example-package/tree/v42.0.258
Run: https://github.com/slsa-framework/example-package/actions/runs/8563991798
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.delegator-generic.release.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.delegator-generic.release.main.default.slsa3.yml
Trigger: release
Branch: v42.0.258
Date: Fri Apr  5 02:32:38 UTC 2024
Tests are passing now. Closing this issue.


Add PR Creator for Bitbucket

What I Did:
Use what has been done for Azure by replacing "Azure" with "Bitbucket"
Use API's to

Get Branch by name
Get all PR's
Create a commit
Create PR
Get all commits

Please note that I'm not a Ruby developer, any feedbacks are welcome !

@jurre I struggle with the formatting due to my ruby knowledge and my setup, any chance we can chat in order to see what's next for this PR ?

+1

Hi @tooppaaa!
Thank you for filing this pull request. Unfortunately, the Dependabot team are currently tied up with some time-sensitive initiatives and we're not able to give this request the attention it needs at the moment. We're hoping to circle back to this and other PRs sometime over the summer.

Awesome thanks
We'll keep the fork for now and get our changes back here from time to time !

Hi, apologies on the lack of a response on this. I believe this is a duplicate of https://github.com/dependabot/dependabot-core/pull/1450. Let me paste my reply on that PR, because it applies here as well:

Hi all, I appreciate the work that went into this PR and this definitely warrants a reply from the maintainers.
However, at this point I don't think that we can accept this patch into dependabot-core natively, as we don't have the capacity or expertise to provide support for Bitbucket. This is currently already a problem with the existing Azure DevOps and GitLab clients, where we're not positioned well to provide support and rely on other members in the community to do so. However, not having clear maintainers for those parts of the codebase makes this hard.
Where I would like to see support for (non GitHub) source control providers go in the future, is for them to be stand-alone gems that you can pull in next to dependabot-core. dependabot-core would provide a clear interface for those gems to implement. These gems can then be maintained by people who actually know and use these providers.
I think this should currently already be possible, but it might rely on monkey-patching some of the existing dependabot-core classes, which is not ideal. I'd be more than happy to accept patches that improve the interface for external providers if you decide to go down that route.

I appreciate the work that went into this, and if anyone wants to tackle releasing this as a standalone gem and there is any support I can provide to make it easier to integrate with dependabot-core I'm happy to help.


Crescendo should export .psd1 with .psm1

PowerShell Crescendo exports a module .psm1 containing the crescendo proxy functions that enable easier administration and automation of native commands.  Export-CrescendoModule should include and export a module manifest .psd1 for the following reasons:

Best practice to include a manifest with the Module
Authors will be able to version the module, specify files in the module (such as nested modules), run scripts to customize the user's environment, load type and formatting files, define system requirements, and limit the members that the module exports

In addition, add PowerShell Gallery tag to module manifest private data

Add a PowerShell Gallery tag to the private data section of the module manifest to allow customers to quickly filter and recognize Crescendo generated modules on PSGallery.
Tag: Crescendo

While generating a new module manifest automatically is great, what's generated now with 0.5.1 is bloated with comments and overwrites a manifest that may already exist, which is problematic for project owners that already manage a tailored and versioned manifest in source control, such as with https://github.com/ethanbergstrom/Foil/blob/master/src/Foil.psd1
A flag to suppress automatic manifest creation would be nice. I've had to pin Foil to Cresendo 0.4.1 in the meantime.

Thank you - This issue has been addressed in Preview.2.