Bump Checkstyle version to latest

Signed-off-by: Chen Dai<EMAIL_ADDRESS>Description

Bump checkstyle from 8.28 to the latest version and fixed all violations.
Change subprojects to allprojects to enforce root project using same version as subproject (specified by toolVersion). Otherwise, the default Checkstyle version (8.37) defined by Gradle is in use.

$ ./gradlew dependencies :sql:dependencies :ppl:dependencies :core:dependencies :protocol:dependencies :opensearch-sql-plugin:dependencies :opensearch:dependencies :legacy:dependencies :common:dependencies | grep checkstyle
checkstyle - The Checkstyle libraries to be used for this project.
\--- com.puppycrawl.tools:checkstyle:10.3.2
checkstyle - The Checkstyle libraries to be used for this project.
\--- com.puppycrawl.tools:checkstyle:10.3.2
checkstyle - The Checkstyle libraries to be used for this project.
\--- com.puppycrawl.tools:checkstyle:10.3.2
checkstyle - The Checkstyle libraries to be used for this project.
\--- com.puppycrawl.tools:checkstyle:10.3.2
checkstyle - The Checkstyle libraries to be used for this project.
\--- com.puppycrawl.tools:checkstyle:10.3.2
checkstyle - The Checkstyle libraries to be used for this project.
\--- com.puppycrawl.tools:checkstyle:10.3.2
checkstyle - The Checkstyle libraries to be used for this project.
\--- com.puppycrawl.tools:checkstyle:10.3.2
checkstyle - The Checkstyle libraries to be used for this project.
\--- com.puppycrawl.tools:checkstyle:10.3.2
checkstyle - The Checkstyle libraries to be used for this project.
\--- com.puppycrawl.tools:checkstyle:10.3.2

$ ./gradlew dependencies :sql:dependencies :ppl:dependencies :core:dependencies :protocol:dependencies :opensearch-sql-plugin:dependencies :opensearch:dependencies :legacy:dependencies :common:dependencies | grep guava | grep 28

Issues Resolved
https://github.com/opensearch-project/sql/issues/431
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #767 (ce41f5b) into main (23a4a88) will decrease coverage by 32.08%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main     #767       +/-   ##
=============================================
- Coverage     94.85%   62.76%   -32.09%
=============================================
  Files           287       10      -277
  Lines          7831      658     -7173
  Branches        571      118      -453
=============================================
- Hits           7428      413     -7015
+ Misses          349      192      -157
+ Partials         54       53        -1

Flag
Coverage Δ

query-workbench
62.76% <ø> (ø)

sql-engine
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ensearch/storage/script/core/ExpressionScript.java

...pensearch/sql/protocol/response/format/Format.java

...arch/sql/expression/aggregation/MinAggregator.java

...ch/sql/expression/aggregation/CountAggregator.java

...search/sql/data/model/AbstractExprNumberValue.java

...rg/opensearch/sql/planner/logical/LogicalPlan.java

...rch/planner/logical/OpenSearchLogicalIndexAgg.java

...ensearch/sql/planner/physical/PhysicalPlanDSL.java

.../opensearch/sql/planner/logical/LogicalDedupe.java

...search/sql/opensearch/security/SecurityAccess.java

... and 267 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Are you planning to activate checkstyle for :protocol, :integ-test and :plugin?

Are you planning to activate checkstyle for :protocol, :integ-test and :plugin?

I think Checkstyle has been activated for all our modules?

Maybe it is activated, but
./gradlew :integ-test:checkstyleTest
...
Checkstyle files with violations: 55
Checkstyle violations by severity: [error:959]
...
BUILD SUCCESSFUL in 1m 11s

All 959 errors are ignored/suppressed.

checkstyleTest.ignoreFailures = true in integ-test because of many IT code is from legacy engine. Are you suggesting to enable it? Sorry, I didn't get your concern in your previous comment.

Oh, I see. Just curious whether we need this in integration tests.

Oh, I see. Just curious whether we need this in integration tests.

Got it. I guess it has been disabled because there were too many IT code from legacy engine when we migrate. Probably we should have only disabled it for org.opensearch.sql.legacy folder by adding it to suppressions.xml. Not sure if it's too late to do that now? :)

./gradlew :legacy:checkstyleMain :legacy:checkstyleTest has no errors, these checks are enforced in build - that is confusing. Test code doesn't go to production, but all checkstyleTest (except integration) are enforced.
We can consider fixing this in scope of another task if it is needed and then activate it for :integ-test.

./gradlew :legacy:checkstyleMain :legacy:checkstyleTest has no errors, these checks are enforced in build - that is confusing. Test code doesn't go to production, but all checkstyleTest (except integration) are enforced. We can consider fixing this in scope of another task if it is needed and then activate it for :integ-test.

I guess the reason you didn't see error is the entire legacy module is excluded in suppressions.xml: https://github.com/opensearch-project/sql/blob/main/config/checkstyle/suppressions.xml#L8


Remaining Tasks -> (Non-Linear Systems, Differentiation methods, Cubic Piecewise, UI for Interpolation and Differentiation methods)

@PyAlaie @ranarokni @Grmamobin @seyed0123 @amirhosseind21
Please tell which task you intend to join in.

[ ] 1 required for Non-Linear Systems.

[ ] 1 required for Differentiation Methods.

[ ] 1 required for Cubic Piecewise.

[ ] 3 required for Interpolation & Differentiation GUI.

@PyAlaie @ranarokni @Grmamobin @seyed0123 @amirhosseind21
Please tell which task you intend to join in.

[ ]  1 required for Non-Linear Systems.
[ ]  1 required for Differentiation Methods.
[ ]  1 required for Cubic Piecewise.
[ ]  3 required for Interpolation & Differentiation GUI.

I'm ok with all of the tasks.

nonlinear system is done by the soltan

Differential methods done!


Adept theme: modeltranslation.translator.NotRegistered: The model "HomePage" is not registered for translation

Hello
I got following error while trying to activate USE_MODELTRANSLATION = True
### modeltranslation.translator.DescendantRegistered: Model "Page" cannot be registered after its subclass "Form"
I apply suggested solution
https://github.com/stephenmcd/mezzanine/issues/1230
from settings.py I place .pages right after theme
INSTALLED_APPS = (
"django.contrib.admin",
"django.contrib.auth",
"django.contrib.contenttypes",
"django.contrib.redirects",
"django.contrib.sessions",
"django.contrib.sites",
"django.contrib.sitemaps",
"django.contrib.staticfiles",
"theme",
"mezzanine.pages",
"mezzanine.boot",
"mezzanine.conf",
"mezzanine.core",
"mezzanine.generic",
"mezzanine.blog",
"mezzanine.forms",
"mezzanine.galleries",
"mezzanine.twitter",
#"mezzanine.accounts",
#"mezzanine.mobile",
"theme.blog_mods",
"theme.portfolio",
)
and Now I getting following error
env) [nap@centosweb adept]$ python manage.py sync_translation_fields
Traceback (most recent call last):
File "manage.py", line 14, in
execute_from_command_line(sys.argv)
File "/home/nap/Web-Sites/skybird_multi_adept/env/lib/python2.7/site-packages/django/core/management/init.py", line 364, in execute_from_command_line
utility.execute()
File "/home/nap/Web-Sites/skybird_multi_adept/env/lib/python2.7/site-packages/django/core/management/init.py", line 338, in execute
django.setup()
File "/home/nap/Web-Sites/skybird_multi_adept/env/lib/python2.7/site-packages/django/init.py", line 27, in setup
apps.populate(settings.INSTALLED_APPS)
File "/home/nap/Web-Sites/skybird_multi_adept/env/lib/python2.7/site-packages/django/apps/registry.py", line 116, in populate
app_config.ready()
File "/home/nap/Web-Sites/skybird_multi_adept/env/lib/python2.7/site-packages/django/contrib/admin/apps.py", line 23, in ready
self.module.autodiscover()
File "/home/nap/Web-Sites/skybird_multi_adept/env/lib/python2.7/site-packages/mezzanine/boot/init.py", line 114, in autodiscover
django_autodiscover(*args, **kwargs)
File "/home/nap/Web-Sites/skybird_multi_adept/env/lib/python2.7/site-packages/django/contrib/admin/init.py", line 26, in autodiscover
autodiscover_modules('admin', register_to=site)
File "/home/nap/Web-Sites/skybird_multi_adept/env/lib/python2.7/site-packages/django/utils/module_loading.py", line 50, in autodiscover_modules
import_module('%s.%s' % (app_config.name, module_to_search))
File "/usr/lib64/python2.7/importlib/init.py", line 37, in import_module
import(name)
File "/home/nap/Web-Sites/skybird_multi_adept/adept/theme/admin.py", line 27, in
admin.site.register(HomePage, HomePageAdmin)
File "/home/nap/Web-Sites/skybird_multi_adept/env/lib/python2.7/site-packages/mezzanine/boot/lazy_admin.py", line 30, in register
super(LazyAdminSite, self).register(*args, **kwargs)
File "/home/nap/Web-Sites/skybird_multi_adept/env/lib/python2.7/site-packages/django/contrib/admin/sites.py", line 125, in register
self._registry[model] = admin_class(model, self)
File "/home/nap/Web-Sites/skybird_multi_adept/env/lib/python2.7/site-packages/mezzanine/core/admin.py", line 270, in init
super(ContentTypedAdmin, self).init(*args, **kwargs)
File "/home/nap/Web-Sites/skybird_multi_adept/env/lib/python2.7/site-packages/mezzanine/core/admin.py", line 104, in init
super(DisplayableAdmin, self).init(*args, **kwargs)
File "/home/nap/Web-Sites/skybird_multi_adept/env/lib/python2.7/site-packages/modeltranslation/admin.py", line 247, in init
super(TranslationAdmin, self).init(*args, **kwargs)
File "/home/nap/Web-Sites/skybird_multi_adept/env/lib/python2.7/site-packages/modeltranslation/admin.py", line 25, in init
self.trans_opts = translator.get_options_for_model(self.model)
File "/home/nap/Web-Sites/skybird_multi_adept/env/lib/python2.7/site-packages/modeltranslation/translator.py", line 574, in get_options_for_model
'translation' % model.name)
### modeltranslation.translator.NotRegistered: The model "HomePage" is not registered for translation
(env) [nap@centosweb adept]$
Kindly advise
BR
Napoleon

Hi
Issue fixed   after creating translate.py as per customized models(HomePage) modelTranslation
Reference:
"Adding translation fields to your custom models" from this blog:
https://leehodgkinson.com/blog/multilingual-theme-in-mezzanine/
and
https://mezzanine.readthedocs.io/en/latest/multi-lingual-sites.html#translation-fields-for-custom-applications
BR


feat: use typescript tsconfig refs

This pull request has three things in it (because these three things cannot be easily be separated).  It might be easier to review the commits independently.

fix: return real paths from nodeModuleLookup

This just calls realpathSync() on the results of nodeModuleLookup().  This will have no effect unless the path contains a symlink, in which case it dereferences the symlinks and returns the "real" path.  This is what node's resolve() and require() do.  So this is more node-resolve-compatibility  This behavior is essential for non-PnP monorepo setups.

chore: simplify logic in nodeModuleLookup

This cleans up the code in nodeModuleLookup() to remove a bunch of duplicated code and logic.  This change should not have any behavioral effect, it just simplifies the code.
One function signature was also modified to narrow an argument from an object down to the one field that the function used.  A test was updated.

feat: use typescript tsconfig references

This is the main change, more about this below.

These changes are essential in supporting of monorepos as mentioned in #1793
TypeScript Project References
This change allows fuse-box to read the "references" field of a tsconfig.json.  This change should have no effect on existing fuse-box users unless they are using this field (which is very unlikely if they are using fuse-box, since fuse-box doesn't support the field today).
The main change is a new module, typescriptReferences.ts that can recurse through the "references" from tsconfig.json to tsconfig.json which results in building a map of output files (like dist/file.js) to the input file that builds them (like src/file.ts) even when the outputs don't exist.  This map is then used to construct a SubPathResolver that will look for input files when someone imports an output file.
Tests were added to check typescriptReferences.ts.
fileLookup() has been modified to take a SubPathResolver which it uses to check the existence of files in a package.  If none is specified, it defaults to using a SubPathResolver called resolveIfExists which just does what fileLookup() was doing before.  When using tsconfig references, the typescript subpath resolver gets passed in.
All existing tests pass unmodified.

@warrenfalk I have a question here. You are using real typescript API to resolve it, right?. What's is the performance overhead? For example, if one isn't using references it won't kick in, right?

@warrenfalk I have a question here. You are using real typescript API to resolve it, right?. What's is the performance overhead? For example, if one isn't using references it won't kick in, right?

Correct.  We use the real typescript API once at the beginning when processing the main tsconfig.conf file just for building the mappings, and after that we just look everything up in the already-built mappings.
Correct, this code is only entered if someone has "references" in their tsconfig.json.
I figure it shouldn't affect anyone because probably no one that uses fuse-box is using "references".  And when people do start to use it, if performance is an issue, we can look at perhaps re-implementing and optimizing that logic.

@wagerfield please rebase against master. And could you work with fuse-box repository directly? You have the permissions to push to branches except for master.

Rebased.
I can work out of the fuse-box repo from now on.  Thanks, I hadn't realized I had that ability.
I pushed a feature/tsconfig-refs to the fuse-box repo to see if I could modify this PR to use it, but it looks like github doesn't support changing the source branch for a PR.  Do you want me to close this one and open another?
I also included feat: add detection of user/non-user package dependencies on here for discussion.  This is what I referred to elsewhere.  I'm looking for feedback on the approach taken in that commit.

@warrenfalk I followed your instructions

But this what I see.

Also, please use prettier sortier and editorconfig extensions for VSCode to keep it consistent.
Your editor settings vary drastically, those extensions would format everything according to .editorconfig

@wagerfield there is a noticeable performance perf. degradation. compare angular_playground which doesn't use references. From 3s 300ms to 3s 500ms
That's a tiny difference but will add up. The culprit here is the number of calls which has increased by a good amount.
We should try decreasing the number of function calls, as well as get rid of map reduce  e.t.c those are the performance killers.

@warrenfalk let's chat on Slack, we would need a point of reference when it gets to performance. Some sort of test.  Here is a summary:

Please fix your VSCode formatting installing the tools I mentioned above
Minor changes that improve the performance
Let's think about reducing the number of function calls in places which a called many times throughout the resolver lifecycle
And finally IMHO some variables need to be renamed. But if you have a strong opinion on those, let's have a chat on Slack

Closing this in lieu of #1874, which also has a tweak to angular playground so you can test performance on that.


Closing Issue#2

Added a time delay of 30 seconds after the dice is rolled
**Issue #2 **
Closes #2

I Cleared the Issue#4(clear terminal after each dice roll) in the same checkout.Please check.

!bounty 10

!bounty 10


Investigate False Negatives on Resource Leaks (nested resources)

Occasionally, we don't report resource leaks on resources allocated in a nested way.

This issue will be fixed in this PR.


Disabling check for SO_REUSEPORT in MANYLINUX; it'll always fail.

Created #7788 if we want to find a better fix for it in 1.0.1.

LGTM

Jenkins: test this please


Update Method Group conversions per feedback

I'd misinterpreted Jon's comment on #746 and merged before more reviews. Nigel had great suggestions, which are now included in this PR.
See https://github.com/dotnet/csharpstandard/pull/746#pullrequestreview-1334122657

Agree, discuss at meeting. I think the old text was an imprecise and confusing way of covering what §19.4 covers. If there are missing case(s), and that is certainly possible, then any fix should surely be in §19.4 and not here?

On 14/03/2023, at 4:43 am, Jon Skeet @.***> wrote:
@jskeet commented on this pull request.
I'm fine with this if it works, but I would like to discuss it at the meeting - as I wonder whether we're missing some previous "exists but causes an error" case elsewhere. If we can't come up with any reason for that still being a possibility, I'd be thrilled to do this :)
—
Reply to this email directly, view it on GitHub https://github.com/dotnet/csharpstandard/pull/751#pullrequestreview-1337382053, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSYVW33XWPAIAJ54ZADRCDW346CFANCNFSM6AAAAAAVZIAIU4.
You are receiving this because your review was requested.


Add Helm Chart for Kubernetes Deployment

Adds a Helm chart for easy deployment, maintenance, and updates of xfinity-data-usage when running on Kubernetes.
I've been running this for a bit on Kubernetes via Helm and figured I would clean it up and see if it could be added to the project.
Let me know if there are any particular improvements that need to be made for acceptance. Thanks!

I'll close this out and create a repo under my user to host the chart there, as I'm able to provide a bit of support. That way folks don't nag here about something you're not in a position to support, test, update, etc.
Thanks for taking a look.

If you want to add a link in this repo's README to point to your repo I'm all for that too.

Thanks! I've created #300 to add a link in the README.


Fix ShardWriter: The open file was not closed

When running unittests or when running python with python -W default your_file.py, you will be able to see warnings like these:
ResourceWarning: unclosed file <_io.BufferedWriter name='.../data-123.tar'>

This was due to the stream opened in ShardWriter which was never closed. Neither TarWriter nor the inner tarfile object close any file objects that are passed in from the outside, so we need to keep a reference in ShardWriter and close it ourselves.

Actually, this MR already fixes the issue in a better way: https://github.com/webdataset/webdataset/pull/275


Enable xa-transaction

Purpose
$Subject
Examples
Checklist

[ ] Linked to an issue
[ ] Updated the specification
[ ] Updated the changelog
[ ] Added tests
[ ] Checked native-image compatibility

@kalaiyarasiganeshalingam don't we need an additional docker image with XA transaction enabled for testing?


New package: DataFlowTasks v0.1.0

Registering package: DataFlowTasks
Repository: https://github.com/maltezfaria/DataFlowTasks.jl
Created by: @maltezfaria
Version: v0.1.0
Commit: cf15cc7c13b38208ff289e3d341d62d090693782
Reviewed by: @maltezfaria
Reference: https://github.com/maltezfaria/DataFlowTasks.jl/commit/cf15cc7c13b38208ff289e3d341d62d090693782#commitcomment-85032954
Description: Tasks which can keep track of how data flows through it

Commenting to prevent auto merge (still some decisions to be made before attempting to register the package).

[noblock] How do I request that auto-merge be reactivated (with the 3 day wait period I guess)? Otherwise, how do I request a review/merge?
Thanks.


decomressed?

Likely spelling error in README.

Hi @madler . Fixed. Thank you a lot for your great contribution to open source.
I am glad to receive an issue from you.


enhancement of Azure service

move the create_context_aggregator method to BaseOpenAILLMService, so that AzureLLMService also has this method
auto detect multi-language in Azure STT

I suggest merge https://github.com/pipecat-ai/pipecat/pull/496 first, cause it has more params for Azure TTS.


UseGettersAndSetters transform

I'm going to close this since it isn't applicable to 7.x. Would be happy to accept a 7.x compatible version.

I'm going to close this since it isn't applicable to 7.x. Would be happy to accept a 7.x compatible version.


Charts seem to be mutating date strings

Bugs and Questions
Checklist

[x] This is a victory-native specific issue. (Issues that also appear in victory should be opened here)

[x] I have read through the FAQ and Guides before asking a question

[x] I am using the latest version of victory-native

[x] I have checked to make sure that my versions of react-native and react-native-svg are compatible with this version of victory-native. Read about version requirements

[x] I've searched open issues to make sure I'm not opening a duplicate issue

The Problem
When passing dates to a victory native component (VictoryStack/VictoryBar tested so far), it seems to mutate the dates and makes them unusable.
e.g. (the data has been reduced for simplicity):
Data passed to a chart:
[{
    "end": "2020-01-28T00:00:00Z",
    "start": "2020-01-27T00:00:00Z",
}, {
    "end": "2020-01-29T00:00:00Z",
    "start": "2020-01-28T00:00:00Z",
}, {
    "end": "2020-01-30T00:00:00Z",
    "start": "2020-01-29T00:00:00Z",
}, {
    "end": "2020-01-31T00:00:00Z",
    "start": "2020-01-30T00:00:00Z",
}, {
    "end": "2020-02-01T00:00:00Z",
    "start": "2020-01-31T00:00:00Z",
}, {
    "end": "2020-02-02T00:00:00Z",
    "start": "2020-02-01T00:00:00Z",
}, {
    "end": "2020-02-02T23:45:00Z",
    "start": "2020-02-02T00:00:00Z",
}]

After chart has parsed the data:
{
    "data": [{
        "end": "2020-1.0008-27.9808T00:00:00Z",
        "start": "2020-1.0008-26.9808T00:00:00Z",
    }, {
        "end": "2020-1.0008-28.9808T00:00:00Z",
        "start": "2020-1.0008-27.9808T00:00:00Z",
    }, {
        "end": "2020-1.0008-29.9808T00:00:00Z",
        "start": "2020-1.0008-28.9808T00:00:00Z",
    }, {
        "end": "2020-1.0008-30.9808T0:00:00Z",
        "start": "2020-1.0008-29.9808T00:00:00Z",
    }, {
        "end": "2020-02-1.0056000000000003T00:00:00Z",
        "start": "2020-1.0008-30.9808T00:00:00Z",
    }, {
        "end": "2020-02-2.0056000000000003T00:00:00Z",
        "start": "2020-02-1.0056000000000003T00:00:00Z",
    }, {
        "end": "2020-02-2.0056000000000003T23:45:00Z",
        "start": "2020-02-2.0056000000000003T00:00:00Z",
    }],
    "datum": {
        "end": "2020-02-2.0056000000000003T23:45:00Z",
        "start": "2020-02-2.0056000000000003T00:00:00Z",
    },
}

The data comes back in a few different variants:
Data in: 2020-01-08T00:00:00Z
Data out (sometimes): 2020-1-08T00:00:00Z
Data out (sometimes): 2020-1-8T00:00:00Z
Data out (sometimes): 2020-1.0008-27.9808T00:00:00Z
I have no idea what could be causing this. Any help would be much appreciated!

I found the sample might have happen to my app, in debugging mode it will show correctly, but once in production mode it will crash. The reason might be cause by your issue


Confusing note on --save/--save-dev flag

The note

--save or --save-dev flag is required in this step

causes some confusing because neither flag is mentioned anywhere as part of the installation step.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7ed0fde7-9e78-c318-9f8c-9d921ec7d7b3
Version Independent ID: 946ead1c-4b65-8318-c77a-ef98873adac7
Content: Get Started with React Native - Visual Studio App Center
Content Source: docs/sdk/getting-started/react-native.md
Service: vs-appcenter
GitHub Login: @elamalani
Microsoft Alias: elamalani

Thanks for reporting this, we will look into this.

Hi @ariya,
--save and --save-dev is no longer required for npm install in the current version of npm as npm saves the dependency automatically now. We will remove these flags from our doc.


#Photochat dataset questions:

Hey, I am a student do some researches on VD. I noticed that you've proposed a great dataset called PhotoChat for multi-model  dialog generative system.
However, it seems that both the url provided and id are invalid for me now. Could you give me some tips how can I solve it without download the whole image challenge dataset with is 500G+(too expensive for me).
train/0a5e922c15ffb08d https://c6.staticflickr.com/1/156/400565484_fdfaa551e7_o.jpg
train/048fe12fa832143f https://c8.staticflickr.com/1/29/96515447_4ac8050343_o.jpg
train/080a8a8692a66687 https://farm8.staticflickr.com/6082/6042280582_c7a5d88b51_o.jpg
train/07f372b1aba8b165 https://farm6.staticflickr.com/7416/9782494465_1f1a8a315f_o.jpg
train/a593754ce22e87da https://c3.staticflickr.com/4/3488/3697088360_5b402b5c66_o.jpg
train/0617ddfd18b1343f https://c8.staticflickr.com/6/5565/15132241305_540a42cf78_o.jpg

@XiaoxueZang
Best regards,
Zeyu Li

train/0a5e922c15ffb08d https://c6.staticflickr.com/1/156/400565484_fdfaa551e7_o.jpg
train/048fe12fa832143f https://c8.staticflickr.com/1/29/96515447_4ac8050343_o.jpg
train/080a8a8692a66687 https://farm8.staticflickr.com/6082/6042280582_c7a5d88b51_o.jpg
train/07f372b1aba8b165 https://farm6.staticflickr.com/7416/9782494465_1f1a8a315f_o.jpg
train/a593754ce22e87da https://c3.staticflickr.com/4/3488/3697088360_5b402b5c66_o.jpg
train/0617ddfd18b1343f https://c8.staticflickr.com/6/5565/15132241305_540a42cf78_o.jpg
train/03d53e7254fc863f https://c8.staticflickr.com/4/3920/14957339372_3a2e4335c7_o.jpg
train/a331e848c0e8265c https://c5.staticflickr.com/4/3647/3375325262_bfcf571c08_o.jpg
train/0a6fb3d70086e39a https://c3.staticflickr.com/6/5589/14534135669_401f933315_o.jpg

I will replace the images of these dialogs to 'None'  if necessary.


Add latex2js support / element like mathjax

https://latex2js.com/installation/html5.html
https://github.com/pyramation/LaTeX2JS
Probably just global scope inject via manager, no shadow root on the tag. When light dom changes we rerun the util to apply

la-tex element added


fix: support jest v28

According to this jest v28 migration guide, the process() method needs to return an object instead of a string.
I've tested this against a work project of mine, and this is working with both jest v28.1.0 and jest v27.5.1.

whoops, I didn't see #11. Closing


Gaszaehler does not work

I agree to the following

[X] I have read the documentation right now
[X] I have read the FAQs right now
[X] I am aware of the latest release notes
[X] I am aware that an integration that was installed via HACS also needs to be updated via HACS
[X] The Backend (CCU/Homegear/...) is working as expected, devices are taught in and are controllable by its own UI.
[X] I am running the latest version of the custom_component (and Home Assistant)

The problem
Unfortunately the new Gaszaehler is not working correctly. I did not get the data what I see in the CCU3. Type is HMIP-ESI
Thank you !
What version of HomematicIP (local) has the issue?
1.70.0
What was the last working version of HomematicIP (local)?
1.70.0
What type of installation are you running?
Home Assistant OS
What type of installation are you running for your homematic backend?
CCU3
Which version of your homematic backend are you running?
No response
What hardware are you running for your system?
No response
Which config details do you use

[ ] TLS
[ ] callback data (see)

Which interfaces do you use?

[X] Homematic IP
[ ] Homematic (Bidcos-RF)
[ ] Groups (Heating-Group)
[ ] BidCos-Wired (HM-Wired)

Diagnostics information (no logs here)
No response
Log file extract. Anything in the logs that might be useful for us? The log (Setting/System/Logs -> load full log) is the best source to support trouble shooting!
No response
Additional information
No response

Bitte verschwende meine Zeit nicht  mit so einem lustlosem erstelltem Ticket!
Du hast ein Problem, und benötigst Hilfe, also gib dir auch Mühe deinen Fehler zu beschreiben, z. Bsp. mit Screenshots, worin das Problem besteht, oder was erwartet wäre.
Ich schliesse das Tickets, da ich veraltete Versionen nicht supporte, aber das wird dir beim abhaken der obigen Checkboxen sicher aufgefallen sein


Support JSON marshalling of yaml sequence and scalar nodes

Support JSON marshalling of yaml sequence and scalar nodes.

I was writing a small plugin to gnostic and found myself needing to serialise sequence and scalar yaml nodes to JSON. Hope this is useful.

Thanks @timburks for the super fast review and merge!


Shepherd: index Referrer Policy

https://w3c.github.io/webappsec-referrer-policy/ does not appear to be indexed.

Added.


ARROW-10136: [Rust]: Fix null handling in StringArray and BinaryArray filtering, add BinaryArray::from_opt_vec

When I use the filter kernel with Null strings, any input column that was Null turns into an empty string after filtering.
"foo"
"bar"
NULL

And the filter
true
true
true

Will result in
"foo"
"bar"
""

Rather than
"foo"
"bar"
NULL

It appears to work fine for primitive arrays (I'll comment inline).  I also added BinaryArray::from_opt_vec following the model of PrimativeArray and StringArray mostly so I could write a test.

Thanks @alamb, this existed as https://issues.apache.org/jira/browse/ARROW-5352; so I'll close that out.
The same behaviour would occur with a BinaryArray, I haven't looked at this PR, but it's worthwhile to ensure that StringArray and BinaryArray are treated consistently.
And yes, the issue didn't affect primitive arrays, I think it was because we were pushing an empty string where we should have pushed a null slot on the null bitmap

The same behaviour would occur with a BinaryArray, I haven't looked at this PR, but it's worthwhile to ensure that StringArray and BinaryArray are treated consistently.

Thanks @nevi-me  -- yes I updated the code tried to handle both types in the same way (and including tests)

Doesn't an Option of a reference leverages null pointer optimization (on which None is represented by the null pointer, e.g. rust-lang/rust#9378)?

@jorgecarleitao I believe you are correct:
This program:
fn main() {
    println!("The size of a &str is {}", std::mem::size_of::<&str>());
    println!("The size of an Option<&str> is {}", std::mem::size_of::<Option<&str>>());
}

Produces the following on my machine:
The size of a &str is 16
The size of an Option<&str> is 16

I think I have addressed all your (very helpful) comments @jorgecarleitao .

@jorgecarleitao you said:

IMO we should follow up on this: for kernels we have been using a mutable buffer with null masks as much as possible.

Can you perhaps let me know what you mean by this? Perhaps there is an example in the code you are thinking of?

I am really, sorry, @alamb , I should have offered more context in the first place. :/
This in no way blocks this PR: IMO it is ready to merge if the relevant tests pass.
What I meant is that this code currently:

creates Vec<Option<T>> through an iteration
copies Vec<Option<T>> to the two buffers (when from_opt_vec is called)

it may be more efficient to create the buffers during the iteration, so that we avoid the copy (Vec -> buffers). In other words, the code in from_opt_vec could have been "injected" into the filter execution, where the MuttableBuffer and offsets and values buffer are created before the loop, and new elements are directly written to it. Does this any sense?
(as a side note, this is why I am proposing #8211 : IMO there is some boiler-plate copy-pasting to

initialize buffers
iterate
create ArrayData from buffers

which will continue to grow as we add more kernels, and whose pattern seems to be a FromIter of fixed size)

@jorgecarleitao  -- yes thank you that makes a lot of sense. I have filed https://issues.apache.org/jira/browse/ARROW-10141 to track that

@andygrove  / @jorgecarleitao  / @nevi-me  I wonder if this PR might be merged anytime soon (I have a downstream project relying on this change)
The integration test failure https://github.com/apache/arrow/pull/8303/checks?check_run_id=1187275161 seems due to a network failure (not anything with this PR):
Error:  Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.5.1:attach-descriptor (attach-descriptor) on project arrow-java-root: Execution attach-descriptor of goal org.apache.maven.plugins:maven-site-plugin:3.5.1:attach-descriptor failed: Plugin org.apache.maven.plugins:maven-site-plugin:3.5.1 or one of its dependencies could not be resolved: Could not transfer artifact org.apache.maven:maven-archiver:jar:2.5 from/to central (https://repo.maven.apache.org/maven2): Connection reset -> [Help 1]

I'll rebase to try and get a clean test run

All tests are passing now. 🎉


Action doesn't execute on PR

I have added this cppcheck action to one of my workflows, and I've noticed that the job executes on push, but it doesn't execute on pull request. In both cases its the exact same job - one runs, the other doesn't.
My job definition:
cppcheck_analysis:
  runs-on: ubuntu-18.04

  steps:
  - name: Checkout
    uses: actions/checkout@v2
    with:
      fetch-depth: 0

  - name: cppcheck
    uses<EMAIL_ADDRESS>    with:
      github_token: ${{ secrets.GITHUB_TOKEN }}
      platform: 'unix64'
      std: 'c++14'
      output_file: cppcheck_report.txt

When the job executes as part of a push, I get the full output and everything works.
When the job executes as part of a pull_request I only get the following in the log:

##[group]Run<EMAIL_ADDRESS>with:
github_token: ***
platform: unix64
std: c++14
output_file: cppcheck_report.txt
check_library: disable
skip_preprocessor: disable
enable: all
exclude_check: disable
inconclusive: enable
inline_suppression: disable
force_language: disable
force: disable
max_ctu_depth: disable
other_options: disable
env:
BUILD_TYPE: Release
##[endgroup]
##[command]/usr/bin/docker run --name a33c132b95d7e10cf45b2a9e9d9ead91e9eeb_dab94e --label 8a33c1 --workdir /github/workspace --rm -e BUILD_TYPE -e INPUT_GITHUB_TOKEN -e INPUT_PLATFORM -e INPUT_STD -e INPUT_OUTPUT_FILE -e INPUT_CHECK_LIBRARY -e INPUT_SKIP_PREPROCESSOR -e INPUT_ENABLE -e INPUT_EXCLUDE_CHECK -e INPUT_INCONCLUSIVE -e INPUT_INLINE_SUPPRESSION -e INPUT_FORCE_LANGUAGE -e INPUT_FORCE -e INPUT_MAX_CTU_DEPTH -e INPUT_TARGET_BRANCH -e INPUT_OTHER_OPTIONS -e INPUT_PULL_REQUEST_BRANCH -e INPUT_TARGET_REPOSITORY -e INPUT_PULL_REQUEST_REPOSITORY -e HOME -e GITHUB_JOB -e GITHUB_REF -e GITHUB_SHA -e GITHUB_REPOSITORY -e GITHUB_REPOSITORY_OWNER -e GITHUB_RUN_ID -e GITHUB_RUN_NUMBER -e GITHUB_RETENTION_DAYS -e GITHUB_ACTOR -e GITHUB_WORKFLOW -e GITHUB_HEAD_REF -e GITHUB_BASE_REF -e GITHUB_EVENT_NAME -e GITHUB_SERVER_URL -e GITHUB_API_URL -e GITHUB_GRAPHQL_URL -e GITHUB_WORKSPACE -e GITHUB_ACTION -e GITHUB_EVENT_PATH -e GITHUB_ACTION_REPOSITORY -e GITHUB_ACTION_REF -e GITHUB_PATH -e GITHUB_ENV -e RUNNER_OS -e RUNNER_TOOL_CACHE -e RUNNER_TEMP -e RUNNER_WORKSPACE -e ACTIONS_RUNTIME_URL -e ACTIONS_RUNTIME_TOKEN -e ACTIONS_CACHE_URL -e GITHUB_ACTIONS=true -e CI=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/_temp/_runner_file_commands":"/github/file_commands" -v "/home/runner/work/PVP/PVP":"/github/workspace" 8a33c1:32b95d7e10cf45b2a9e9d9ead91e9eeb
Post job cleanup.
[command]/usr/bin/git version
git version 2.31.1
[command]/usr/bin/git config --local --name-only --get-regexp core.sshCommand
[command]/usr/bin/git submodule foreach --recursive git config --local --name-only --get-regexp 'core.sshCommand' && git config --local --unset-all 'core.sshCommand' || :
[command]/usr/bin/git config --local --name-only --get-regexp http.https://github.com/.extraheader
http.https://github.com/.extraheader
[command]/usr/bin/git config --local --unset-all http.https://github.com/.extraheader
[command]/usr/bin/git submodule foreach --recursive git config --local --name-only --get-regexp 'http.https://github.com/.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :
Uploading runner diagnostic logs
Completed runner diagnostic log upload
Cleaning up orphan processes

I would imagine this is a bug? There shouldn't be a reason why it runs on commit but not on PR?

unfortunately, this action does not work on PRs, as it does not have the write permission to publish the report on the pull request's codebase. I'm working on a bot that overcomes this. stay tuned for it.

Thanks. Appreciate if you could drop a comment in this issue when it's available!

yeah sure :)

The check is still fundamentally wrong though because (especially with organization repositories), the source-branch might be in the same repo as the destination-branch.
On top of that, the action can still be useful without writing a report. just failing the status-check to prevent merging when branch-protection is enabled is good enough.
Also, it's not the actions task to do such a check, the user of the action is the only person who can know if the provided token works on the repo or not and should enable or disable the action using if: .
IMO you should just remove the check without changing anything else.

What's the status of this issue? It's been some time since the last update and I was wondering if some work has been done in the meanwhile.

I forked over at https://github.com/chmorgan/cppcheck-action and removed this check. Any help would be appreciated!

I'm not a GHA expert but rather than committing the report.  You could:

Attach it as an artifact to the build.
cat the report to the build log so it can be viewed there.


[FEATURE] Customizable encoding of logging timestamp

Objective of this commit is to allow logs to be more readable.
Default log ts encoding in the logger employed (zap) is unix time. This leads to logs not much human-readable. This change introduces the possibility to customize the ts with a set of preconfigured encodings: one of 'epoch', 'millis', 'nano', 'iso8601', 'rfc3339' or 'rfc3339nano'
Default value does not change

Hello @moolen @gusfcarvalho! I know there is code duplication in the PR. How do you advise to solve it?

Hello @moolen @gusfcarvalho! I know there is code duplication in the PR. How to you advise to solve it?

Hey @RiccardoColella this is fine, this can be ignored :sweat_smile:

/ok-to-test sha=e56ea70


#1086 Support Servo Speed and Acceleration

Hi, there are some things I am a bit unsure about:

the general implementation: Since it's only implemented in the Maestro the set_speed/acceleration methods are currently not implemented for the other platforms. As discussed in #1086 this should be emulated for the other platforms (new issue)
the default values for speed and acceleration (both are 0 currently)

Just let me know if any of this or something else needs fixing.

What is the scale of acceleration and speed? 0 does not make much sense. Maybe this should be speed limit and acceleration limit? Default would be infinite I guess

According to the documentation and the comments in the methods a value of 0 means unrestricted.

Yes for pololu. However, our interface should be easy to understand.

The linter is a bit unhappy:
Messages
========
mpf/platforms/fast/fast_servo.py
  Line: 30
    pep8: N804 / first argument of a classmethod should be named 'cls' (col 9)
  Line: 35
    pep8: N804 / first argument of a classmethod should be named 'cls' (col 9)
mpf/platforms/i2c_servo_controller.py
  Line: 106
    pep8: N804 / first argument of a classmethod should be named 'cls' (col 9)
  Line: 111
    pep8: N804 / first argument of a classmethod should be named 'cls' (col 9)
mpf/platforms/rpi/rpi.py
  Line: 91
    pep8: N804 / first argument of a classmethod should be named 'cls' (col 9)
  Line: 96
    pep8: N804 / first argument of a classmethod should be named 'cls' (col 9)
mpf/platforms/virtual.py
  Line: 357
    pep8: N804 / first argument of a classmethod should be named 'cls' (col 9)
  Line: 362
    pep8: N804 / first argument of a classmethod should be named 'cls' (col 9)
Check Information
=================
         Started: 2018-03-14 17:19:41.934344
        Finished: 2018-03-14 17:21:14.234246
      Time Taken: 92.30 seconds
       Formatter: grouped
        Profiles: .landscape.yml, doc_warnings, strictness_veryhigh, no_member_warnings, no_test_warnings
      Strictness: from profile
  Libraries Used:
       Tools Run: dodgy, mccabe, pep257, pep8, profile-validator, pyflakes, pylint
  Messages Found: 8

What do think about just renaming those to max_speed? or speed_limit? With unit max position_change/s [1/s] (because position is just 0-1 and not degree). We would have to look up how that translates to the pololu (in the manual). They probably state something about it. Same for acceleration limit with unit max_speed_change/s and because speed_change is [1/s] this will be [1/s^2] (as any other acceleration).  What do you think?

Thanks for your feedback. Renaming sounds good. About the errors/warnings in the travis builds: Travis basically complained about the unimplemented set_speed/acceleration methods in the other platforms. (Method could be a function) Any suggestions on what's the best way to handle this?
From the meastro docs: The speed limit is given in units of (0.25 μs)/(10 ms)
Example: Value is 140 -> 0.25 * 140 / 10 = 3.5 microseconds per second
1.0 in our config equals 9000 microseconds for the maestro (correct?):
So we got a value in our config of let's say: 0.5 (/s)
That is: 0.5 * 9000 / s = 4500/s
4500/100 = 45/10ms
4.5 / 0.25 = 18 -> value we send to the meastro
For acceleration: The acceleration limit is a value from 0 to 255 in units of (0.25 μs)/(10 ms)/(80 ms)
So we would basically do the same thing as before just for the adjusted acceleration formulas.
Pretty new to most of this so let me know what you think;-)

Looks good. Only some small linter issues:

mpf/platforms/pololu_maestro.py
  Line: 5
    pylint: wrong-import-order / standard import "import math" should be placed before "import serial"
  Line: 158
    pylint: no-self-use / Method could be a function (col 4)
  Line: 159
    pep8: E501 / line too long (127 > 120 characters) (col 121)

Perfect! Thanks! Dunno why the other linter errors suddenly appear. Will check that later.


feat(backend): pass category name and description to the training set selector

Codecov Report

Merging #405 (d729aa0) into main (db4d186) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #405   +/-   ##
=======================================
  Coverage   81.93%   81.94%
=======================================
  Files          62       62
  Lines        4102     4103    +1
=======================================
+ Hits         3361     3362    +1
  Misses        741      741

Impacted Files
Coverage Δ

label_sleuth/orchestrator/orchestrator_api.py
68.30% <100.00%> (+0.07%)
:arrow_up:

...th/training_set_selector/train_set_selector_api.py
100.00% <100.00%> (ø)

...leuth/training_set_selector/train_set_selectors.py
42.85% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


xhamster.com broken in 2015.07.28 unable to extract thumbnail unable to extract media url

$ youtube-dl --verbose http://xhamster.com/movies/4904412/sexy_voluptuous_girl.html
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'--verbose', u'http://xhamster.com/movies/4904412/sexy_voluptuous_girl.html']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2015.07.28
[debug] Python version 2.7.6 - Linux-3.13.0-45-generic-x86_64-with-Ubuntu-14.04-trusty
[debug] exe versions: avconv 2.5.3, avprobe 2.5.3, ffmpeg 2.5.3, ffprobe 2.5.3, rtmpdump 2.4
[debug] Proxy map: {}
[XHamster] 4904412: Downloading webpage
WARNING: unable to extract thumbnail; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
ERROR: Unable to extract media URL; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "/home/user/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 656, in extract_info
ie_result = ie.extract(url)
File "/home/user/bin/youtube-dl/youtube_dl/extractor/common.py", line 279, in extract
return self._real_extract(url)
File "/home/user/bin/youtube-dl/youtube_dl/extractor/xhamster.py", line 100, in _real_extract
video_url = extract_video_url(webpage)
File "/home/user/bin/youtube-dl/youtube_dl/extractor/xhamster.py", line 52, in extract_video_url
raise ExtractorError('Unable to extract media URL')
ExtractorError: Unable to extract media URL; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
$ uname -a
Linux localhost 3.13.0-45-generic #74-Ubuntu SMP Tue Jan 13 19:36:28 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux
$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 14.04.2 LTS
Release:        14.04
Codename:       trusty

This issue is already fixed and will be available in the next version of youtube-dl.


Extract nginx auth proxy into own ECS service

This commit extracts nginx auth proxy into it it's own service splitting
it away from Prometheus.
Before this commit Prometheus and nginx were co-located in the same
service, nginx communicated with Prometheus using a container link, this
is inconsistent with how nginx communicates with Alert Manager and
because of the basic auth prevents Prometheus from scrapping the other
instances of Prometheus.
New Nignx Service and Task
This commit defines a new service in nginx-auth-proxy.tf which
implements the new nginx-auth-proxy.json task.
The nginx auth has been renamed and updated to point to the new
internal dns names of prometheus.
Changes to ALBs
A few resources have been renamed to be more consistent, clearer. We
have been able to remove the listener rules for the external dns. When
Prometheus and Nginx where co-located we needed to route requests to the
appropriate instance of Prometheus, which meant we needed to route the
request to the specific Nginx that Prometheus was paired with. Now we
can route to any Nginx each Nginx knows how to route a request to any
Prometheus. This means we can default to sending all requests to a
single Nginx target group which all three instances of Nginx are
registered to and let Nginx manage the routing to the instances of
Prometheus.
A new set of internal DNS names have been setup and a new set of
listener rules have been set up for routing Prometheus traffic to using
the internal load balancer.
Changes to Prometheus Service and Task
The old Nginx task has been removed and the new service now targets the
Prometheus container
Changes to Nginx Config
There is now a default server for responding to health check requests.
There are 3 new servers for responding to the Prometheus checks. If a
request is made to the load balancer directly it should 404 (unless it
is /health) at the default server.

can you tell us a bit about what deploying this would look like and if the deploy would need some sort of coordination or downtime?


hk.vmap raises error despite split_rng=hk.running_init()

When using hk.vmap to map over a leading axis while sharing parameters, I get an error when trying to set split_rng=True or split_rng=hk.running_init(). Here is a small example:
import haiku as hk
import jax

class BatchedModule(hk.Module):
    def __init__(self, output_dim):
        super().__init__()
        # self.module = hk.Linear(output_dim)
        self.module = hk.nets.MLP([10] + [output_dim])

    def __call__(self, input_batch):
        # The following line raises the error
        return hk.vmap(self.module, split_rng=hk.running_init())(input_batch)

inputs = jax.random.normal(rng := jax.random.PRNGKey(0), (128, 13))
batched_linear = hk.transform_with_state(lambda x: BatchedModule(output_dim=11)(x))
params, state = batched_linear.init(rng, inputs)
out = batched_linear.apply(params, state, rng, inputs)

which raises
ValueError: hk.vmap does not support setting split_rng to True during initialization because it assumes parameters are always shared along the mapped dimension. Consider switching the value of `split_rng` to False during initialization through `hk.running_init()`.

I am not sure if I am doing something wrong, but at least the error message is misleading since hk.running_init() is already set here.

Sorry, my bad for the confusing error message: you should set split_rng to False during initialization, meaning split_rng=(not hk.running_init()).
I'll send a change updating the error message, let me know if the above works!

Oh of course, that makes sense and works. Thank you!


Update RSpec to 3.2.0

This allows to use the newer syntax such as expect(foo).to eq(bar) as well as a better runner.
r: @gmalette @davidcornu

YAY!

:+1:


[ExpansionPanel] Exposes color property of MaterialSlice

Description
Adds a new panelColor property in EpxansionPanel. The property uses MaterialSlice.color to paint the panel color.

Related Issues
Fixes #32293
Tests
I added the following tests:

Added test to verify the panelColor is propagated properly to MaterialSlice.

Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[x] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

[ ] I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
[ ] I got input from the developer relations team, specifically from: Replace with the names of who gave advice
[ ] I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes

Oh no, I don't know how the stale commit is present in the branch. Let me know if I should send a fresh PR.


Issue: #947: Decouple ProductRelationsFactory from FrontendFactory

Closes #947.

Here you go: https://github.com/lizards-and-pumpkins/catalog/commit/558d97e70e25642889f2a60b3d8bf36b5989a9f5
Not sure what is more clumsy. I would say I like the first implementation better.


spelling: attribute

Summary of the Pull Request
split out per @miniksa
References
https://github.com/microsoft/terminal/pull/4295#pullrequestreview-353162609

PR Checklist

[ ] Closes #xxx
[x] CLA signed. If not, go over here and sign the CLA
[ ] Tests added/passed
[ ] Requires documentation to be updated
[x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Attempting this right now on the Windows side in user/miniksa/spelling...

This is now MSFT:25154975

Committed today in PR:4297546 on the inside. @DHowett-MSFT will replicate it out and then this PR can probably be closed.

Ugh: I misspelled it in the commit message. This merged in with bb4cd6488. Thanks for your patience!

That's ok, the commit message for the original spelling PR is also pretty embarrassing. I didn't really expect the bot to take the description as the commit message (it had a note which was no longer applicable).

Yeah, that's something we can always do with more work on. :smile:


Second iteration on the website to improve it.

In this pull request, I redesigned the components for macrobench and macrobenchMobile to make the information more readable.

Note to self - Once all comments are addressed and this PR is merged we can remove the old frontend UI and switch to the React UI in production.

Just a few comments left:

https://github.com/vitessio/arewefastyet/pull/411#discussion_r1281948025
https://github.com/vitessio/arewefastyet/pull/411#discussion_r1279406586
https://github.com/vitessio/arewefastyet/pull/411#discussion_r1279402294
https://github.com/vitessio/arewefastyet/pull/411#discussion_r1279333746

Otherwise looks great @Camillemtd! We need to fix those small conflicts which were introduced after merging #412.

On the query comparison page, the comment I wrote below still remains. We can fix this in a subsequent PR if you wish.
That makes me think, we should handle the case where someone someone directly goes to `/macrobench/queries/compare`, for now it fails with: `Uncaught TypeError: Cannot read properties of null (reading 'commitHashLeft')` and other JS errors.

The same thing applies to the macrobenchmark loader, we can do this in a subsequent PR.
I can open an issue for both if you wish.


chore(idk): Add security hud icons

About the PR

Adds UI icon for different levels of security statuses.
Cannibalized from the "stale" PR #25192
Why / Balance

Allow use of UI Icons for UI purposes.
Technical details

Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

It's not stale this is just going to cause merge conflicts.

It's not stale this is just going to cause merge conflicts.

Solving the merge conflict would just be deleting the files


Can pgbadger generate report in 2 formats in a single run?

hi!
I tried with --extension html --extension json but it only produces a single report (in json), am I missing something obvious?

Hi,
No it cannot generate several reports format at the same time. If you don't want to parse the log file twice you must proceed as follow:

generate an output in binary format from your log files: pgbadger -o filename.bin postgresql.log
generate an HTML report from the binary file: pgbadger -o report.html filename.bin
and a json report from the binary file too: pgbadger -o report.html filename.json


Question: Best way to get a status badge for a job?

I was building a status page for TARDIS and noticed CircleCI does not allow the creation of individual badges for jobs (like GitHub Actions).
Also, shields.io isn't capable of doing that (just filter by branch, not job or workflow).
This makes it difficult to track the state of our code without visiting this repository frequently. I thought about a few ways to achieve this with a certain degree of success, but I feel this is still complicated. For example, I could maintain a new branch on my fork that runs the nightly workflow just for TARDIS.
Any suggestion?

Hi! Thanks for answering.
I've been thinking a lot about this, and now I don't remember any possible solution :/
I've write again soon once I remember what can be done here.

Just remembered, I think the best way of doing this is to grabbing the status from here:
https://api.github.com/repos/numba/numba-integration-testing/statuses/21989cb59534ab61b7e41ea983f7b66340528273
And make badges through GitHub Actions, JSONbin.org and shields.io.
I don't know if you want to have a general solution for all packages (maybe it's not worth) but I can try something later this week.

@esc here it is: https://github.com/epassaro/numba-integration-badges/blob/main/README.md
It should be updated 2 hours after the nightly tests run.
This could be easily added to this repo, but requires login to JSONBin on behalf of the org.

@esc here it is: https://github.com/epassaro/numba-integration-badges
It should be updated 2 hours after the nightly tests run.
This could be easily added to this repo, but requires login to JSONBin on behalf of the org.

This looks awesome!! I can probably setup a login if need be. Can this be incorporated with a PR to this repo?

Yes, let me check a few things and I'll open a PR later today.


Add async to all components

All components should be able to do things async.....nough said

Async implementation done.
Unit tests to add


ki211 ATF patch

Hi, will you share info about your patch for Ki211 for ATF temp?

I'm also interested


InvalidRequestError: The API deployment for the resource does not exist.

InvalidRequestError: The API deployment for the resource does not exist.
Getting the same error as the previous person,  I do have all the deployments except text-babbage, but still receiving this error....Can you please help me?
Traceback:
File "/usr/local/lib/python3.9/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 561, in _run_script
self._session_state.on_script_will_rerun(rerun_data.widget_states)
File "/usr/local/lib/python3.9/site-packages/streamlit/runtime/state/safe_session_state.py", line 72, in on_script_will_rerun
self._state.on_script_will_rerun(latest_widget_states)
File "/usr/local/lib/python3.9/site-packages/streamlit/runtime/state/session_state.py", line 542, in on_script_will_rerun
self._call_callbacks()
File "/usr/local/lib/python3.9/site-packages/streamlit/runtime/state/session_state.py", line 555, in _call_callbacks
self._new_widget_state.call_callback(wid)
File "/usr/local/lib/python3.9/site-packages/streamlit/runtime/state/session_state.py", line 276, in call_callback
callback(*args, **kwargs)
File "/usr/local/src/myscripts/pages/10_Utils - Document_Summary.py", line 8, in summarize
_, response = utils.get_completion(get_prompt(), max_tokens=500, model=os.getenv('OPENAI_ENGINES', 'text-davinci-003'))
File "/usr/local/src/myscripts/utilities/utils.py", line 110, in get_completion
response = openai.Completion.create(
File "/usr/local/lib/python3.9/site-packages/openai/api_resources/completion.py", line 25, in create
return super().create(*args, **kwargs)
File "/usr/local/lib/python3.9/site-packages/openai/api_resources/abstract/engine_api_resource.py", line 153, in create
response, _, api_key = requestor.request(
File "/usr/local/lib/python3.9/site-packages/openai/api_requestor.py", line 226, in request
resp, got_stream = self._interpret_response(result, stream)
File "/usr/local/lib/python3.9/site-packages/openai/api_requestor.py", line 619, in _interpret_response
self._interpret_response_line(
File "/usr/local/lib/python3.9/site-packages/openai/api_requestor.py", line 679, in _interpret_response_line
raise self.handle_error_response(

@ruoccofabrizio Can you please help?

Double-check your deployment names in the Azure OpenAI portal. The .env file needs to be filled with the deployments name and not the models name.
Suggested config:
OPENAI_ENGINES=text-davinci-003
OPENAI_EMBEDDINGS_ENGINE_DOC=text-embedding-ada-002
OPENAI_EMBEDDINGS_ENGINE_QUERY=text-embedding-ada-002

Hi Fabrizio,
Thanks for the reply. I actually changed the config to the deployment names, but finding it difficult to deploy the app service to azure. Do you have some recommendations?
Thanks,
Janani

From: Fabrizio Ruocco @.>
Sent: Tuesday, February 28, 2023 11:00 PM
To: ruoccofabrizio/azure-open-ai-embeddings-qna @.>
Cc: Janani Sivanandan @.>; Author @.>
Subject: Re: [ruoccofabrizio/azure-open-ai-embeddings-qna] InvalidRequestError: The API deployment for the resource does not exist. (Issue #16)
Double-check your deployment names in the Azure OpenAI portal. The .env file needs to be filled with the deployments name and not the models name.
Suggested config:
OPENAI_ENGINES=text-davinci-003
OPENAI_EMBEDDINGS_ENGINE_DOC=text-embedding-ada-002
OPENAI_EMBEDDINGS_ENGINE_QUERY=text-embedding-ada-002
—
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fruoccofabrizio%2Fazure-open-ai-embeddings-qna%2Fissues%2F16%23issuecomment-1449452946&data=05|01|Janani.Sivanandan%40microsoft.com|366d2aa481a042f3826208db1a22b036|72f988bf86f141af91ab2d7cd011db47|1|0|638132508520929545|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=Higo5xz3ZrrVekRUi3lqkX8LMrZiZhjMHebHpichamo%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FA6GB7RSE7LE7CXY5DPMCB53WZ3X2BANCNFSM6AAAAAAVLJI6SE&data=05|01|Janani.Sivanandan%40microsoft.com|366d2aa481a042f3826208db1a22b036|72f988bf86f141af91ab2d7cd011db47|1|0|638132508520929545|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=5wJ0YDFiQ7DiRrrAHiB3X0hfw%2FbnD%2B9IOarXLJDe0uc%3D&reserved=0.
You are receiving this because you authored the thread.Message ID: @.***>

I did update the environment variable as follows as my deployment name for text-davinci-003 model = "textdavinci003model", but all other models have the same name.
[cid:aee5e3e6-2585-4fb4-9398-f5418dc20aca]
I'm receiving a "Resource not found error now.
[cid:390629fe-4622-4a3c-9661-08c0422721f3]
Any help is appreciated. thanks!

From: Fabrizio Ruocco @.>
Sent: Tuesday, February 28, 2023 11:00:48 PM
To: ruoccofabrizio/azure-open-ai-embeddings-qna @.>
Cc: Janani Sivanandan @.>; Author @.>
Subject: Re: [ruoccofabrizio/azure-open-ai-embeddings-qna] InvalidRequestError: The API deployment for the resource does not exist. (Issue #16)
Double-check your deployment names in the Azure OpenAI portal. The .env file needs to be filled with the deployments name and not the models name.
Suggested config:
OPENAI_ENGINES=text-davinci-003
OPENAI_EMBEDDINGS_ENGINE_DOC=text-embedding-ada-002
OPENAI_EMBEDDINGS_ENGINE_QUERY=text-embedding-ada-002
—
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fruoccofabrizio%2Fazure-open-ai-embeddings-qna%2Fissues%2F16%23issuecomment-1449452946&data=05|01|Janani.Sivanandan%40microsoft.com|366d2aa481a042f3826208db1a22b036|72f988bf86f141af91ab2d7cd011db47|1|0|638132508520929545|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=Higo5xz3ZrrVekRUi3lqkX8LMrZiZhjMHebHpichamo%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FA6GB7RSE7LE7CXY5DPMCB53WZ3X2BANCNFSM6AAAAAAVLJI6SE&data=05|01|Janani.Sivanandan%40microsoft.com|366d2aa481a042f3826208db1a22b036|72f988bf86f141af91ab2d7cd011db47|1|0|638132508520929545|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=5wJ0YDFiQ7DiRrrAHiB3X0hfw%2FbnD%2B9IOarXLJDe0uc%3D&reserved=0.
You are receiving this because you authored the thread.Message ID: @.***>


Update: Trace state + getAttestationTraces

In this PR:

update the grahql schema to reflect the change in trace state
add the getAttestationTraces public method

This change is

:tada: This PR is included in version 1.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Switch Project.tags to django-taggit

This commit closes https://github.com/HackTJ/live/issues/64.

TLDR: let's come back to this later

to merge this, we need to remove the tag field from all fixtures, which I don't want to do yet.
TaggableManager isn't deserialized, I think because of this line: https://github.com/jazzband/django-taggit/blob/9d9ca4b36a09ec7b4cb0c823be9f90ff2089701e/taggit/managers.py#L441
proof that `tags` isn't deserialized in fixtures
output of:
poetry run python manage.py shell --command "from judge.models import Project; mod = Project.objects.create(name='apple', location='tree', description='desc', tags=['fruit', 'red']); from django.core import serializers; print(serializers.serialize('json', (mod,)))"

is:
[{"model": "judge.project", "pk": 1, "fields": {"name": "apple", "location": "tree", "description": "desc", "link": "", "overall_mean": 0.0, "overall_variance": 1.0, "innovation_mean": 0.0, "innovation_variance": 1.0, "functionality_mean": 0.0, "functionality_variance": 1.0, "design_mean": 0.0, "design_variance": 1.0, "complexity_mean": 0.0, "complexity_variance": 1.0, "numberOfVotes": 0, "timesSeen": 0, "timesSkipped": 0, "prioritize": false, "active": true}}]

We can still keep tag data in fixtures, but will take more work:

poetry run python manage.py loaddata 'fixture.json' --ignorenonexistent
poetry run python manage.py assigntags 'fixture.json'  # we need to create this script


add code to append runid to testname #260

Signed-off-by: Skchoudhary<EMAIL_ADDRESS>(cherry picked from commit 2c68fb10e16a6f4b3c291cb5b480926aac185105)

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #260
Special notes for your reviewer:

Thanks for the PR @Skchoudhary !


Actually make podman-docker optional

Before this change it was impossible to avoid installing podman-docker because even though the parameter was optional, the Hiera data provided the value and no way to undo that default.

Maybe it isn't obvious, but it is possible to avoid installing podman-docker by setting the following in hiera
podman::podman_docker_pkg: ~
I'll update the documentation for the next release

Maybe it isn't obvious, but it is possible to avoid installing podman-docker by setting the following in hiera
podman::podman_docker_pkg: ~
I'll update the documentation for the next release


Enabled use of AgentLimit to control region entry.

There are 2 settings for agents on a region.  MaxAgents comes from the region config and is a hard limit on the region. It will deny even estate managers.  Agent Limit is settable from the viewer and until now as ignored.  This adds a check for over the AgentLimit.  It will still allow Estate Managers and anyone on the region whitelist in.  This works for cases where a club or performance group may always want its club staff or performers to get in on a crash but otherwise apply an agent limit to the region as a whole.  This checks Agent limit on region entry as described above.
Note this needs careful review.  I don't have a way in dev to test this well and it can obviously affect region entry for agents.

I just finished my testing of the soft limit and it's great. It's persistent, and supports the privileged overrides of the limit. All good. Ready for merge.


Print status on cleanup for containers

This adds support for https://github.com/sclorg/s2i-python-container/pull/515.
This PR proposes printing test results on ct_cleanup, so the container tests can also use ct_run_tests_from_testset.
This PR should not affect containers that yet do not support the ct_run_tests_from_testset function, as in that case nothing is printed.
This PR also proposes to exit the shell at the end of the cleanup, so that the user can terminate the test suite manually when ct_enable_cleanup is called before.
If the reviewer thinks, this should be separated into two commits I understand and will do it.

[test-all]

I will close this, as this issue is already addressed in https://github.com/sclorg/container-common-scripts/pull/238.


All workers show busy status but just hung there unless i restart the consermer and it'll handling jobs again for about 1k and hung there again, i have to restart again and again...

@tylerb @cypriss

Hey @rush24, how did you resolve this issue?

Hi @rush24 how did you resolve the issue?


⚠ Bofrost.fr has degraded performance

In 1b23302, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 864 ms

Resolved: Bofrost.fr performance has improved in 60a20d3 after 13 minutes.


[DO NOT MERGE] Use latest-esr Firefox in Travis

Looks like FF v52.0.0 was used.  Can we specify a specific FF verison for Travis?  I know v49 runs the unit tests.

@dtaylor113 Trying Firefox 49

Hooray!!!!


Can't get the examples to work correctly

I am having some issues trying to get a number of the examples working.
http://i.imgur.com/VDBAoZt.png
All of these errors have something to do with _mem. The program kills it's self before I even get an error code.

Change working directory to bgfx/examples/runtime. If you generated project files with GENie it should be done for you, but not sure why it doesn't work for you.

I generated project files with GENie, and compiled them through Visual Studios.

2015 edition

Did changing working directory in VS help?

I hadn't been able to figure out -where- that option is located in 2015. Recently upgraded from an older version.

Yeah, the executable is set to that. And it still doesn't work.

http://i.imgur.com/qVvEMpN.png
No success. I took a picture with the entire call stack shown.

I found the problem. The exes need to be located inside the Runtime folder for it to work properly.

Yes, that's what's working directory I mentioned above. In VS2015 working directory is at the same location where it was before.
https://msdn.microsoft.com/en-us/library/kcw4dzyf.aspx


Get state of checkbox switch

How does one get the value of the switch whether on or off with JavaScript. Using $('input[name="input-switch"]').val() with jQuery always returns "on" even when the switch is off

@athmangude
to check the checked property of that input, you should use .is(':checked')) rather than .val()


Fixed #33589 -- Made admin calendar widget escape all char occurrences in date input formats.

Now the replacement of the string of characters is for all occurrences and not just the first occurrence.

All right, I added a unit test which covers all of the expressions and replaces them successfully. However, there is a problem on a different unit test. On the unit test 'init', the callback function has an error for a unexpected .

This error occurs with both the old and the new code. I have separated the \ regex from the others for now.

@ankurr0y Thanks :+1: Welcome aboard :boat:

Closing per comment.
@ankurr0y Would you like to prepare a patch for ticket-33784?


When running protractors tests, my url changes to https in browser

Hi,
In the last few days my url is wrapped in https causing the test case not running and a "Secure Connection Failed" displayed on browser.
Anyone know why this is happening. I updated to npm 5.5.0 yesterday so don't know if thats the issue.

exports.config = {
  seleniumAddress: 'http://<IP_ADDRESS>:4444/wd/hub',
	baseUrl: "http://qa-auto-iqservice001.eu-fra.adtech.com:8080/",
	specs: ['specs/demandFeatureSpec.js'],
capabilities: {
	browserName: 'firefox',
},

framework: 'jasmine2',

onPrepare: function() {
	var jasmineReporters = require('jasmine-reporters');
	jasmine.getEnv().addReporter(new jasmineReporters.JUnitXmlReporter({
		consolidateAll: true,
		savePath: 'testresults',
		filePrefix: 'xmloutput'
	}));

browser.driver.manage().window().maximize();
	browser.driver.get(browser.baseUrl);

	global.isAngularSite = function(flag){
		browser.ignoreSynchronization = !flag;
	};

	global.getRandomInt = function(min, max) {
		var randomNum = Math.floor(Math.random() * (max - min + 1)) + min;
		return randomNum.toString();
	};
},

}

I get the following error:
Error while waiting for Protractor to sync with the page: "window.angular is undefined.  This could be either because this is a non-angular page or because your test involves client-side navigation, which can interfere with Protractor's bootstrapping.  See http://git.io/v4gXM for details"
Can anyone help me out, why this is happening?
Ryan

Hi there!
This sounds like an issue with your sever setup (did your QA server recently start redirecting http urls to https? — What happens when you hit the URL manually?).
Because it will require additional investigation and debugging outside of the scope of an issue with protractor core, your question is better suited for StackOverflow or Gitter. Please ask a question there with the 'protractor' tag or post in the Gitter Channel to get help.
From the the getting help section of the README:

Please ask usage and debugging questions on StackOverflow (use the "protractor" tag) or in the Angular discussion group. (Please do not ask support questions here on Github.)

Thanks!


Re-use part cartographer improvements/design in KeplerMapper

I have seen that this project has gone through considerable developments and improvements in the last months. About one year ago, I spent about 2 months studying TDA and its applications to (moistly scientific) data analysis. When it was time to review MAPPER, I started playing with KeplerMapper and I found it extremely convenient for MAPPER-based data exploration (basically was the only good open implementation out there).
However, I was missing some interactivity (changing the variable used for node colouring, recomputing the simplicial complex with other clustering/coverer parameters, etc.) for the exploration of the output simplicial complex. With the aim of understanding better MAPPER I started rewriting my own implementation (which I called cartographer) re-using scikit-learn as much as possible, inspired with what was done in KeplerMapper.
Given that this project is now undergoing active development now and it is definitely more mature and has more user adoption than mine, I think it would be interesting to see wether some of the simplified API design choices and implementation changes could be ported to KeplerMapper to improve usability and performance in case you are interested.
So we can discuss what could be re-used within KeplerMapper, I list now the main design and implementation changes when rewriting the implementation (it is pretty simple and can bee seen here):

Opted for separated visualisation of the simplicial complex from the actual computation of the simplicial complex (the scikit-learn cluster-like model). My aim was to be able to adapt the visualisation details at a later stage and also have the possibility to either serve a standalone html or also see the visualisation within a Jupyter Notebook/Lab.

The Mapper class inherits from ClusterMixin and the three Mapper components can be configured in the constructor call: filterer (the transforming function reducing from the high-dimensionality of the data of from a lower dimensionality to compute the nerve), coverer (the transformer function that defines the overlapping spaces from which the nerve is computed) and clusterer (the clustering algoritm that is actually used in the algorithm).

The coverer, see the HyperRectangleCoverer divides the input space in overlapping regions. One trick that I discovered to speed up considerably the execution was to reduce set intersection checks to overlapping regions, by means of returning with the coverer a overlapping matrix (could be also sparse) and checking for intersection only on those subsets.

Standalone documentation with Jupyter notebooks (the output D3.js graph can be explored within a Jupyter output cell ), executed with nbsphinx when the docs are built by the CI.

In addition to the features I implemented in cartographer, I also spent a few  weeks thinking on how to implement other improvements (e.g. bidirectional Jupyter widget visualization, how to deal with hyper-parameters, multi-scale MAPPER approaches). I will also be glad to discuss also those and contribute to their integration.

This is great! I think cartographer has a lot of great stuff going on, and merging the two libraries would benefit everyone!
I think 3 and 4 are the easiest and most straight forward to incorporate.  The cover API is still new, so now is the time to make large changes.
I can put work in this next week to help integrate those changes. I’m not sure the best way to go about doing this while making sure you get credit, if you care about that.  Once they are in, I propose we increment the version to 1.1.
I’m really interested in how you were able to convert notebooks to Sphinx docs.  Right now the km docs pages are just the readme cut into smaller pieces, and hasn’t been officially released. Having a stack of notebooks would be great as both introduction to km and mapper in general.
I am interested in your thoughts on other improvements. Some of them will be much more of an undertaking to incorporate. Let’s discuss the rest of the features and ideas in more depth.

Sorry for the late reply, was a bit preoccupied with family-related celebrations. Indeed, I agree that 3 and 4 are the simplest improvements.
I can try to open a PR myself with some proposed coverer changes taken from cartographer or alternatively you can integrate the changes if you prefer. I am guessing that KepplerMapper developments occur in the dev, so it should be the PR target, am I right?
Regarding the Jupyter Notebook based  examples in the docs, I used the nbsphinx module and the notebooks are executed by the CI system. I was using RTD but it was not compatible with nbsphinx at the time so I moved to Travis and GitHub pages. You can see my Sphinx conf here. You can find more info about nbsphinx in their GitHub.
About credit for my prospective contributions or reusing of design/code/docs from cartographer, it depends on how much I get involved in the project. For the time being, let's try to see how well we can integrate stuff from cartographer in KepplerMapper. Later on, if you are agree and my contributions are significant we can opt for some way of "official" recognition for the developments.

No worries. I think everyone is busy this time of year.
I would prefer you initiate the first PR so at the very least you show up in the contributors tab. I'll have lots of time next week to work on this integration and some other features I wanted to build out.
We started trying to keep recent developments in the dev branch so that docs & master match what is in pypi. This is a pretty new setup though, so we would listen to any suggestions for other ways to improve this.


Asp.Net Core 2.0 Jwt Bearer Authentication now not working

I have upgraded from aspnet core 1.1 to 2.0. I recreated a new solution with javascript services opting for the react redux option.  It worked perfectly out of the box. From my old project in 1.1 I had JWT Bearer authentication working. I have installed it in the Startup.cs file and now my wwwroot is not serving at all and in the output (which follows below) you can see that Authorization failed for user.
However there should not be any authorization for sending up the initial page etc.  I have no idea why it now does not work.
For purposes of getting to the bottom of this and finding out why this is not working I have posted the project on Github HERE.
Hoping someone might be able to set me straight as to why its now not working...
Below is the output and below that is the startup.cs
Microsoft.AspNetCore.Authorization.DefaultAuthorizationService:Information: Authorization failed for user: (null).
Application Insights Telemetry (unconfigured): {"name":"Microsoft.ApplicationInsights.Dev.Message","time":"2017-09-19T05:48:16.9118260Z","tags":{"ai.operation.id":"882cbee2-49cfce8d3cea92c5","ai.operation.name":"GET Home/Index","ai.operation.parentId":"|882cbee2-49cfce8d3cea92c5.","ai.location.ip":"<IP_ADDRESS>","ai.cloud.roleInstance":"DESKTOP-7LBOA6D","ai.internal.nodeName":"DESKTOP-7LBOA6D","ai.internal.sdkVersion":"aspnet5c:2.1.1","ai.application.ver":"<IP_ADDRESS>"},"data":{"baseType":"MessageData","baseData":{"ver":2,"message":"Authorization failed for user: (null).","severityLevel":"Information","properties":{"AspNetCoreEnvironment":"Development","DeveloperMode":"true","{OriginalFormat}":"Authorization failed for user: {UserName}.","CategoryName":"Microsoft.AspNetCore.Authorization.DefaultAuthorizationService"}}}}
Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker:Information: Authorization failed for the request at filter 'Microsoft.AspNetCore.Mvc.Authorization.AuthorizeFilter'.
Application Insights Telemetry (unconfigured): {"name":"Microsoft.ApplicationInsights.Dev.Message","time":"2017-09-19T05:48:16.9322060Z","tags":{"ai.operation.id":"882cbee2-49cfce8d3cea92c5","ai.operation.name":"GET Home/Index","ai.operation.parentId":"|882cbee2-49cfce8d3cea92c5.","ai.location.ip":"<IP_ADDRESS>","ai.cloud.roleInstance":"DESKTOP-7LBOA6D","ai.internal.nodeName":"DESKTOP-7LBOA6D","ai.internal.sdkVersion":"aspnet5c:2.1.1","ai.application.ver":"<IP_ADDRESS>"},"data":{"baseType":"MessageData","baseData":{"ver":2,"message":"Authorization failed for the request at filter 'Microsoft.AspNetCore.Mvc.Authorization.AuthorizeFilter'.","severityLevel":"Information","properties":{"AspNetCoreEnvironment":"Development","DeveloperMode":"true","AuthorizationFilter":"Microsoft.AspNetCore.Mvc.Authorization.AuthorizeFilter","{OriginalFormat}":"Authorization failed for the request at filter '{AuthorizationFilter}'.","CategoryName":"Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker"}}}}
Microsoft.AspNetCore.Mvc.ChallengeResult:Information: Executing ChallengeResult with authentication schemes ().
Application Insights Telemetry (unconfigured): {"name":"Microsoft.ApplicationInsights.Dev.Message","time":"2017-09-19T05:48:16.9459697Z","tags":{"ai.operation.id":"882cbee2-49cfce8d3cea92c5","ai.operation.name":"GET Home/Index","ai.operation.parentId":"|882cbee2-49cfce8d3cea92c5.","ai.location.ip":"<IP_ADDRESS>","ai.cloud.roleInstance":"DESKTOP-7LBOA6D","ai.internal.nodeName":"DESKTOP-7LBOA6D","ai.internal.sdkVersion":"aspnet5c:2.1.1","ai.application.ver":"<IP_ADDRESS>"},"data":{"baseType":"MessageData","baseData":{"ver":2,"message":"Executing ChallengeResult with authentication schemes ().","severityLevel":"Information","properties":{"AspNetCoreEnvironment":"Development","Schemes":"System.String[]","DeveloperMode":"true","{OriginalFormat}":"Executing ChallengeResult with authentication schemes ({Schemes}).","CategoryName":"Microsoft.AspNetCore.Mvc.ChallengeResult"}}}}
Microsoft.AspNetCore.Authentication.JwtBearer.JwtBearerHandler:Information: AuthenticationScheme: Bearer was challenged.

Here is my startup.cs
using JobsLedger.API.ControllerServices.ClientServices;
using JobsLedger.API.ControllerServices.JobServices;
using JobsLedger.API.ControllerServices.SelectDataServices;
using JobsLedger.API.JWTOptions;
using JobsLedger.DATA;
using JobsLedger.DATA.Abstract;
using JobsLedger.DATA.DataServices;
using JobsLedger.DATA.DataServices.Abstract;
using JobsLedger.DATA.Repositories;
using Microsoft.AspNetCore.Authentication.JwtBearer;
using Microsoft.AspNetCore.Authorization;
using Microsoft.AspNetCore.Builder;
using Microsoft.AspNetCore.Hosting;
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Mvc.Authorization;
using Microsoft.AspNetCore.SpaServices.Webpack;
using Microsoft.EntityFrameworkCore;
using Microsoft.Extensions.Configuration;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.IdentityModel.Tokens;
using Newtonsoft.Json.Serialization;
using System;
using System.Security.Claims;
using System.Text;

namespace JobsLedger_API
{
    public class Startup
    {
        private static string _applicationPath = string.Empty;
        private static string _contentRootPath = string.Empty;

        public Startup(IHostingEnvironment env)
        {
            _applicationPath = env.WebRootPath;
            _contentRootPath = env.ContentRootPath;

            var builder = new ConfigurationBuilder()
                .SetBasePath(env.ContentRootPath)
                .AddJsonFile("appsettings.json", optional: false, reloadOnChange: true)
                .AddJsonFile($"appsettings.{env.EnvironmentName}.json", optional: true);

            if (env.IsDevelopment())
            {
                // For more details on using the user secret store see http://go.microsoft.com/fwlink/?LinkID=532709
                builder.AddUserSecrets<Startup>();
            }

            builder.AddEnvironmentVariables();
            Configuration = builder.Build();
        }

        public IConfigurationRoot Configuration { get; }

        private const string SecretKey = "secretsecretsecret";
        private readonly SymmetricSecurityKey _signingKey = new SymmetricSecurityKey(Encoding.ASCII.GetBytes(SecretKey));

        // This method gets called by the runtime. Use this method to add services to the container.
        public void ConfigureServices(IServiceCollection services)
        {
            // Add framework services.
            services.AddOptions();
            // Add database context
            services.AddDbContext<JobsLedgerAPIContext>(options =>
                options.UseSqlServer(Configuration.GetConnectionString("DefaultConnection"),
                b => b.MigrationsAssembly("JobsLedger.API")));

            // Repositories
            services.AddScoped<IBrandRepository, BrandRepository>();
            services.AddScoped<IClientRepository, ClientRepository>();
            services.AddScoped<ICompanyDetailRepository, CompanyDetailRepository>();
            services.AddScoped<ILoggingRepository, LoggingRepository>();
            services.AddScoped<IJobRepository, JobRepository>();
            services.AddScoped<IJobTypeRepository, JobTypeRepository>();
            services.AddScoped<IRoleRepository, RoleRepository>();
            services.AddScoped<IStateRepository, StateRepository>();
            services.AddScoped<IStatusRepository, StatusRepository>();
            services.AddScoped<ISuburbRepository, SuburbRepository>();
            services.AddScoped<IUserRepository, UserRepository>();
            services.AddScoped<IUserRoleRepository, UserRoleRepository>();
            services.AddScoped<IProgramCounterRepository, ProgramCounterRepository>();

            // Services
            services.AddScoped<IMembershipService, MembershipService>();
            services.AddScoped<IEncryptionService, EncryptionService>();
            services.AddScoped<ISelectDataServices, SelectDataServices>();
            services.AddScoped<IClientServices, ClientServices>();
            services.AddScoped<IJobServices, JobServices>();
            services.AddSingleton<IHttpContextAccessor, HttpContextAccessor>();

            // Make authentication compulsory across the board (i.e. shut
            // down EVERYTHING unless explicitly opened up).
            services.AddMvc(config =>
            {
                var policy = new AuthorizationPolicyBuilder()
                                 .RequireAuthenticatedUser()
                                 .Build();
                config.Filters.Add(new AuthorizeFilter(policy));
            }).AddJsonOptions(options =>
            {
                options.SerializerSettings.ContractResolver = new CamelCasePropertyNamesContractResolver();
            });

            // Polices
            services.AddAuthorization(options =>
            {
                options.AddPolicy("AdminOnly", policy => policy.RequireClaim(ClaimTypes.Role, "Admin"));
                options.AddPolicy("EmployeeAccess", policy => policy.RequireClaim(ClaimTypes.Role, "Employee"));
            });

            // Get options from app settings
            var jwtAppSettingOptions = Configuration.GetSection(nameof(JwtIssuerOptions));

            // Configure JwtIssuerOptions
            services.Configure<JwtIssuerOptions>(options =>
            {
                options.Issuer = jwtAppSettingOptions[nameof(JwtIssuerOptions.Issuer)];
                options.Audience = jwtAppSettingOptions[nameof(JwtIssuerOptions.Audience)];
                options.SigningCredentials = new SigningCredentials(_signingKey, SecurityAlgorithms.HmacSha256);
            });

            var tokenValidationParameters = new TokenValidationParameters
            {
                ValidateIssuer = true,
                ValidIssuer = jwtAppSettingOptions[nameof(JwtIssuerOptions.Issuer)],

                ValidateAudience = true,
                ValidAudience = jwtAppSettingOptions[nameof(JwtIssuerOptions.Audience)],

                ValidateIssuerSigningKey = true,
                IssuerSigningKey = _signingKey,

                RequireExpirationTime = true,
                ValidateLifetime = true,

                ClockSkew = TimeSpan.Zero
            };

            services.AddAuthentication(JwtBearerDefaults.AuthenticationScheme)
            .AddJwtBearer(options =>
            {
                options.TokenValidationParameters = tokenValidationParameters;
            });

        }

        // This method gets called by the runtime. Use this method to configure the HTTP request pipeline.
        public void Configure(IApplicationBuilder app, IHostingEnvironment env)
        {
            if (env.IsDevelopment())
            {
                app.UseDeveloperExceptionPage();
                app.UseWebpackDevMiddleware(new WebpackDevMiddlewareOptions
                {
                    HotModuleReplacement = true,
                    ReactHotModuleReplacement = true
                });
            }
            else
            {
                app.UseExceptionHandler("/Home/Error");
            }

            app.UseStaticFiles();

            app.UseAuthentication();  // JWT Middleware

            app.UseMvc(routes =>
            {
                routes.MapRoute(
                    name: "default",
                    template: "{controller=Home}/{action=Index}/{id?}");

                routes.MapSpaFallbackRoute(
                    name: "spa-fallback",
                    defaults: new { controller = "Home", action = "Index" });
            });
        }
    }
}

If you have a closer look its looking for user and password off the home controller. I figured it required  [AllowAnonymous] as a decorator as the index page authorization needed to be ignored.  I did this and it worked.


address nullable reference types warnings in event handler doc

Summary
Updated snippet and docs to address nullable reference types warnings.
I also updated the sample to use a file-scoped namespace, I can revert this if needed.
Fixes #39991 (if available)

Note: the referenced API docs also has a similar snippet that needs to be updated at https://learn.microsoft.com/en-us/dotnet/api/system.eventhandler-1?view=net-8.0

Internal previews

📄 File
🔗 Preview link

docs/csharp/programming-guide/events/how-to-publish-events-that-conform-to-net-framework-guidelines.md
How to publish events that conform to .NET Guidelines (C# Programming Guide)

With the build error I'm not sure if I should create a csproj file for the events snippets.
It does render correctly, but I assume this build step is to validate if the snippets compile successfully.

Hi @timdeschryver
Yes, a basic csproj in the snippet folder should fix the CI build failure. And, yes, that's how we validate that code is corrrect.


Issue 45345: Optimize default DB connection pool config

Rationale
Reviewing performance data, we're spending a surprising amount of time validating DB connections before using them.
Changes

Switch from validating DB connections when borrowing from the pool to idle times
Be more prescriptive for the desired size of the pool - initial and idle

#https://github.com/LabKey/syseng-chef-server/pull/400
Mirror changes in chef lk_appserver cookbook

Are the [FATAL: database "bt3" does not exist] bootstrap errors related to your changes?

@labkey-adam yes, turns out that specifying an initialSize causes the connection pool to throw a SQLException when initializing due to the lack of a DB, breaking bootstrapping. I've backed out that part of the change, which was less important than the other edits.


[NEW-FEATURE] When an added property of string contains localization attributes it should use translator

/cib

Branch 96-_NEW-FEATURE_When_an_added_property_of_string_contains_localization_attributes_it_should_use_translator created!


Added formatting and explanation to Use the Conditional (Ternary) Operator

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #34309

Attention Reviewers: There are 3 previous open PRs  (#22633, #29292, #30038) which make changes to this challenge.

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉


Switch WePay donation to something else

@econchick What issues do you face with WePay and what are you looking for in a replacement?

Fixed - will be the pushed live a little later today.


DotSpatial 2.0.0-rc1 ConvexHull() Takes Forever

IFeature feature = importedShapeFile.Features.ElementAt(i);
                var convex = feature.ConvexHull();

DotSpatial version: 2.0.0
in 1.9 it takes around 2 seconds to build convex hull for polygon over 1M vertices. I couldn't complete and gave up on 2.0

When I try
var fak = new GeometryFactory();
Coordinate[] convexcoods = Difference.Coordinates.ToArray();
var difConvex = new NetTopologySuite.Algorithm.ConvexHull(convexcoods, fak).GetConvexHull();

It takes about 10 minutes.


Support a new rule: no blank line after last docstring section

D413 says "Missing blank line after last section". It'd be awesome to have the opposite, and raise a new warning when there is a blank line at the end of a docstring.
Using Google style, there shouldn't be an empty line at the end, so a warning should exist for this case.
Thank you for your consideration!

Hi, I am new to pydocstyle and I would like to work on this issue. :)

@meowmeowmeowcat Awesome!

@meowmeowmeowcat are there any updates on the progress of this issue?


Mldb 1427 sampled dataset default args

I was looking at that code last night and I was wondering if we should not change the interface to make it less error prone to users by:

changing the parameter rows in the function sample and in the dataset config by limit so that this parameter can coexist with fraction and so that a limit set higher to the number of rows of the dataset would succeed instead of returning an error
aligning the default in the sample function with the one in the dataset config

@guyd: To rephrase your suggestion, rows -> limit, and then we return the min of limit and fraction ?

Yes

Talked about it with some internal users and your suggestion does allow things that the current way doesn't, while taking nothing away. I'll make the change.

+1


hotfix/mfc -> dev

This change is

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Introduce packaging?

It seems that this project is the most popular on Github amongst competitors.
Comments are appreciated - would you use it as Linux/BSD package if it gets available?
This may probably increase its popularity even more.

Happy to receive proposals for an approach to this.


Feature: generic serializers

Currently we hardcode bincode. If we support generic serializers then bincode should become a default feature so it can be disabled.

tarpc::Error would either need to become generic over two error types, application and serialization errors, or we could just make the serialize error variant store a string. Would that be awful?

How about an even wilder idea: generic transport? Imagine using tarpc codegen to build HTTP REST services, emulating the functionality of Jersey and Feign.
That would mean, of course, building some equivalent of JAX-RS annotations, which is another can of worms...

I think that's covered by #38. A long time ago, when I first started tarpc, the transport actually was generic. But I felt usability suffered. Could be worth revisiting if the landscape is different now!

Obsoleted by #199.


Add observation on the docs about using winpty on Git Bash for Windows

lab needs some special access to the terminal on Windows that the standard bash/mintty can't handle. That's the same issue with Python and other terminal applications running on Windows.
When adding the "alias git=lab" on ~/.bashrc on Windows, the shell hangs on initialization. Adding the winpty prefix will solve it, although adding a slight delay on git commands (including the git_ps1 command to setup the PS1 var).

Can you clarify what this means: "Adding the winpty prefix will solve it"

winpty is a tool to make Windows programs, such as Python and lab, work under mintty and other terminal emulators that understand ANSI escape codes.
https://github.com/rprichard/winpty
This question on StackOverflow explain it in a little more detail (but not too much): https://stackoverflow.com/questions/48199794/winpty-and-git-bash

@spidey Is it still a problem?
I can use lab normally via PowerShell. Are there any use cases you can point out for reproducing the issue?

Ok, my bad... it's an Git Bash for Windows specific issue (read the issue title 🤦♂)
But still, I wasn't able to reproduce the issue. Things seems to run as expected from what I tried.