[Update] Firebase for iOS v7.10.0

For review, @Redth @mattleibow @SotoiGhost @dalexsoto
Includes
Firebase

All projects updated 7.10.0
MLKit for Firebase packages deprecated/removed (no longer supported)

Firebase.MLKit
Firebase.MLKit.Common
Firebase.MLKit.ModelInterpreter
Firebase.MLKit.NaturalLanguage
Firebase.MLKit.Vision
Note: probably need a new project/repo for the newer Google ML Kit bindings

Added beta binding for Firebase App Distribution (Firebase.AppDistribution)

excluded for now (no sample or testing done)

Minimum iOS version increased to 10.0

Google

AdMob updated to 8.3.0
Google Cast updated to 4.5.3
Google Maps & Places updated to 4.2.0
Google Tag Manager updated to 7.2.0
Deprecated/removed packages (due to outdated Firebase dependencies),

Google.AppIndexing
Google.Core
Google.InstanceID

Minimum iOS version increased to 10.0 (due to Firebase dependencies)

Notes
Removed the Wrap methods/properties that where marked as Obsolete (seems like a major version bump is the time to do it 😅).
There were quite a few binding changes, so would definitely appreciate someone to look them over. All the samples do run & link as far as I can tell.
Also happy to separate the UMP package as was done in #459.
Any issues let me know!

Hi @dmariogatto,
Apple is rejecting apps which include Firebase due to tracking transparency.
I found a discussion on the firebase repo about this issue: https://github.com/firebase/firebase-ios-sdk/issues/7736
I’m wondering if your intention with PR was to update to the latest firebase SDK?

And apologies for spamming your PR @dmariogatto, but it is literally the only thing I could find on the internet that seems to be close enough to addressing the latest Firebase SDK update for Xamarin

Here is another reference about the rejection issues. https://github.com/firebase/quickstart-unity/issues/994
It seems like version 7.9.0-k2 is where the issue was resolved. Afterwards for version 7.11.0 they introduce a new Pod Firebase/AnalyticsWithoutAdIdSupport.

@mayhammf I wasn't aware of firebase/firebase-ios-sdk#7736.
Looks like we'd have to separate out GoogleAppMeasurement into two different NuGets (one with tracking and one without). Then we'd have a matching pair of NuGets for Analytics.
I'm happy to do the work, but would like to get the okay from someone at Microsoft/Xamarin on the approach.

@dmariogatto i agree, there needs to be a package for AnalyticsWithoutAdIdSupport
The approach the firebase team took (introducing a different package) has the potential of leading to a chain reaction of dependency nightmares (at least in world of NuGet) where every package that might relay on Analytics has to (possibly) be duplicated (once with ad id support and one without)
As far as i can see on NuGet.org under Used by for Xamarin.Firebase.iOS.Analytics/, not a lot of packages are depending on Analytics, but it is still going to be complicated.
Do you see what i mean?

@mayhammf I see your point about a dependency nightmare, but it might be unavoidable, unless Firebase changes the way they package Analytics.

@dmariogatto do you agree now with v7.11.0 is now out that your PR should target that version instead of v7.10.0?
I think that would bring us closer to the solution.
Then a NuGet package can be introduced Firebase/AnalyticsWithoutAdIdSupport
This way those who depend in Analytics and don't want to be stuck in review can get their apps deployed.
Do you think this is something @Redth and team will have to pre-approve first?

@mayhammf Updating to 7.11.0 isn't that difficult, at a glance I can't see any binding changes, so mainly just updating the native frameworks. Would like to get some indication that the PR is going to be reviewed before spending the time.

@dmariogatto i agree with you. It makes a lot of sense to have a indication from Microsoft/Xamarin that they will be looking into this PR before spending the time.

We're contemplating branching out from your 710 branch and attempting to update to 7.11 and create a new project for AnalyticsWithoutAdIdSupport.
But, to be honest, we are not sure that we know enough about this repo to pull this of.

Perhaps this is a dumb question, but why can the native iOS firebase plugin not have a precompile directive (or similar swift concept) or a setting in info.plist to key off of in order to remove Ad ID usage? Or could we not remove the code by default and an extra library could be installed which would enable its use? I know the latter would be breaking change but this would prevent needed 2 separate libraries for everything.

@hvaughan3 Not a dumb question! It might be possible to select which GoogleAppMeasurement framework is linked via a msbuild property.
For example in your project if you wanted Firebase without Ad Id support you'd have,
<PropertyGroup>
  <FirebaseWithoutAdIdSupport>True</FirebaseWithoutAdIdSupport>
</PropertyGroup>

@mayhammf @hvaughan3
This is my quick attempt firebase-711.
The interesting file is Core.targets, which switches the linked GoogleAppMeasurement framework based on FirebaseWithoutAdIdSupport.

@dmariogatto  @hvaughan3 loading the native framework conditionally is a very clever solution.! As long as firebase won't be introducing difference to the API (with and without AD support) i think this will be a perfect way to go about it.

@dmariogatto
I'm getting compilation error when I try to build it in release mode
/MTOUCH: Error MT2101: Can't resolve the reference 'System.Void Firebase.CloudMessaging.Messaging::SendMessage(Foundation.NSDictionary,System.String,System.String,System.Int64)', referenced from the method 'System.Void Plugin.FirebasePushNotification.FirebasePushNotificationManager::SendDeviceGroupMessage(System.Collections.Generic.IDictionary2<System.String,System.String>,System.String,System.String,System.Int32)' in 'Firebase.CloudMessaging, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null'. (MT2101) (DCSInstallerMobileApp.iOS)`

Now obsolete, see #485


Add query root rewrite support

First basic attempt to support Query Root rewriting to support things like #84.
For now, It only supports rewriting for properties that have a setter (since the data can't be stored after a select otherwise) and a default constructor.
There is no cache support for now.

After testing a little, this works well when there is a no complex select or other things filters using relations.
For example:
DbSet<User>().FirstOrDefault()

gets rewritten to:
dbContext.Users
          .Select(namelessParameter{0} => new User{
              <Id>k__BackingField = namelessParameter{0}.<Id>k__BackingField,
              <FirstName>k__BackingField = namelessParameter{0}.<FirstName>k__BackingField,
              <LastName>k__BackingField = namelessParameter{0}.<LastName>k__BackingField,
              TotalSpent = namelessParameter{0}.Orders
                  .Sum(x => x.Price)
          }
          )
          .FirstOrDefault()'

but something like:
dbContext.Users
    .Select(x => new {
        Name = x.FullName,
        x.TotalSpent
    })
	.FirstOrDefault();

gets rewritten to:
DbSet<User>()
          .Select(namelessParameter{0} => new User{
              <Id>k__BackingField = namelessParameter{0}.<Id>k__BackingField,
              <FirstName>k__BackingField = namelessParameter{0}.<FirstName>k__BackingField,
              <LastName>k__BackingField = namelessParameter{0}.<LastName>k__BackingField,
              TotalSpent = namelessParameter{0}.Orders
                  .Sum(x => x.Price)
          }
          )
          .Select(x => new {
              Name = x.FullName,
              TotalSpent = x.Orders
                  .Sum(x => x.Price)
           })
          .FirstOrDefault()'

so this fails because the second select references Order which is not loaded by EF.

Thanks for taking a swing at this!

I wonder if there is a way to only rewrite the QueryRootExpression if there is no expression following it.

I think that's exactly what we will want to achieve for the exact problem that you described. I'll see if I can come up with a strategy we can take here.

I like the idea of running a second path for QueryRoot rewriting, but I think it will also need to stop rewriting if the query contains a Select statement, or it will probably make an error. I'm thinking about cases like:
int id = await db.Users
    .Select(x => x.Id)
    // This generated select should not be there.
    .Select(namelessParameter{0} => new User{
        <Id>k__BackingField = namelessParameter{0}.<Id>k__BackingField,
        <FirstName>k__BackingField = namelessParameter{0}.<FirstName>k__BackingField,
        <LastName>k__BackingField = namelessParameter{0}.<LastName>k__BackingField,
        TotalSpent = namelessParameter{0}.Orders
            .Sum(x => x.Price)
    })
    .First()

The previous cases now work perfectly. The .Select is added at the very end of the query, just before a .First()/.ToList() or a the very end when there is no call to those methods. It also handles only the query root or .Sum() and calls where the rewrite should not happen.
I'm going to do more testing in the week to see if I can find cases where it breaks, please comment if you think of one.

Since this PR is way more useful when there is a baking field for a projectable property like:
[Projectable(UseMemberBody = nameof(_FullName))]
public string FullName { get; set; }
private string _FullName => FirstName + " " + LastName;

I think it would be good to have a way to automatically generate the baking field, allowing to write like below and get the same behavior as above:
[Projectable(WithBaking = true)]
public string FullName => FirstName + " " + LastName;

I have absolutely no idea how the generator works, so I have not really looked to do that for now.

I tested it on my project, and it works exactly as expected! Since the API for QueryRootExpression changed when dotnet7 was released, it needs to have different behaving between the two versions, so I added that on the last commit.
I reused the caching system that already existed for properties, but I did not cache the new Select statement since it would require caching the whole query and I don't think that it's a good tradeoff.


Document player stats

In the README there should be a sub-section under How To Play called Player Classes. The documentation should follow this table template:

Name
Attack Damage
Risk Attack Damage
Healing Amount

Player 1
10-15
20-25
10-15

Player 2
10-15
20-25
10-15

etc.
The Warrior, Rogue, Healer, Debugger, and Saitama player classes should be documented.
The attack/risk attack/healing points is documented in each player's corresponding cpp file.

I'll do it


x/tools/gopls: memory usage

What version of Go are you using (go version)?

$ go version
go version go1.15.7 windows/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
set GO111MODULE=
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\jcervantes\AppData\Local\go-build
set GOENV=C:\Users\jcervantes\AppData\Roaming\go\env
set GOEXE=.exe
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=
set GOMODCACHE=C:\Users\jcervantes\go\pkg\mod
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=C:\Users\jcervantes\go
set GOPRIVATE=
set GOPROXY=https://proxy.golang.org,direct
set GOROOT=c:\go
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLDIR=c:\go\pkg\tool\windows_amd64
set GCCGO=gccgo
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=C:\Users\JCERVA~1\AppData\Local\Temp\go-build341909526=/tmp/go-build -gno-record-gcc-switches

What did you do?
just save a change on my project
What did you expect to see?
Better improvement of the memory
What did you see instead?
here you have the img:
https://ibb.co/94kgRXy

please follow the steps in https://github.com/golang/tools/blob/gopls/v0.6.4/gopls/doc/troubleshooting.md#debug-memory-usage to include the relevant information when filing issues about gopls

please follow the steps in https://github.com/golang/tools/blob/gopls/v0.6.4/gopls/doc/troubleshooting.md#debug-memory-usage to include the relevant information when filing issues about gopls

Here you have it:
https://we.tl/t-tViJpcpaTL

Here you have it:
https://we.tl/t-tViJpcpaTL

can you upload it as an attachment here instead?

can you upload it as an attachment here instead?

which text do you want from the file?

which text do you want from the file?

gopls.30384-18GiB-withnames.zip

gopls.30384-18GiB-withnames.zip

/cc @heschik

/cc @heschik

You seem to have a number of particularly expensive packages, notably golang.org/x/text, open in your workspace.  That will definitely lead to very high memory usage. We'd like to be more efficient, but for now you will be much better off opening just the project you're working on.

You seem to have a number of particularly expensive packages, notably golang.org/x/text, open in your workspace.  That will definitely lead to very high memory usage. We'd like to be more efficient, but for now you will be much better off opening just the project you're working on.

Hi @heschik, I just have one project and all the packages that I have installed is what i'm using.
Can I just disable the execution?

Hi @heschik, I just have one project and all the packages that I have installed is what i'm using.
Can I just disable the execution?

Please make sure that the folder you've opened as your workspace folder in VSCode contains only code you've written. If you still see high memory usage, please upload a gopls log following https://github.com/golang/vscode-go/blob/master/docs/troubleshooting.md#collect-gopls-information?

Please make sure that the folder you've opened as your workspace folder in VSCode contains only code you've written. If you still see high memory usage, please upload a gopls log following https://github.com/golang/vscode-go/blob/master/docs/troubleshooting.md#collect-gopls-information?


What other additional data should we scrape from fbref??

For each league, scrape player stats like passes, assists, shots, advance stats, yellow cards, red cards, offsides and more.


Dev merged into Master

this should kick off a new build in Jenkins and deploy to k8s

Hi, I think you need to be doing this on your own fork of the project!

haha, sorry. im learning!

Not a problem! We're all learning ;-)


Improve OUIA id's in current components

RHCLOUD-32124
Updated existing components to contain predefined OUIA IDs for necessary elements and made them customizable using props. Ouia ID format used: ComponentName-element-description
Also updated the contribution guidelines to include OUIA ID best practices.

Preview: https://react-component-groups-pr-component-groups-131.surge.sh


Update build versions to support java 1.8 , add logic to correct the mail content type in reportal.

You need to specify java 1.8 version to be used for travis build in https://github.com/azkaban/azkaban-plugins/blob/master/.travis.yml. Something similar to https://github.com/azkaban/azkaban/pull/548/files.

LGTM


build(build-tools): Bump 0.9.0 => 0.9.1 (patch)

Bumped build-tools from 0.9.0 to 0.9.1.
Commands used:
flub release -g build-tools

Closing; we'll bump if we need to patch.


Detecting failure between wifi and wired device

I have a set-up with 2 devices connected to the same logical network on the same physical router, one via Ethernet cable, and one via Wifi.
Even though both devices can ping each other, polo running on one fails to detect the other and vice versa.

Might have to do with the TTL. Usually, a TTL of 1 should be enough to spread the Multicast messages within the network. Yet, I have found that between wired and wireless (and sometimes even just between wireless devices) the TTL needs to be set higher (say, 5 to be sure) in order for it to work. Could you try that?

I'll try that and let you know, thank you.

I set it to 10 and waited a LONG time but it didn't detect.

That's unfortunate. Another issue might be the wifi router that doesn't support multicast very well. You might try the solutions provided here: https://github.com/mafintosh/polo/issues/19


Hub logger

Sending last 5 SS logs to Hub

Use limited queue for storing logs in memory to avoid overflow


Refactor: refactor the dependencies of kv server

Currently, there is a confusion of dependencies between several components in our kv server. Their dependencies look like this:

IMO, this chaos may boil down to three reasons:

there are some useless nested types, like KvWatcherInner and KvStoreBackend.
KvStore owns a KvWatcher but doesn't use it.
Some structures depend on a concrete type instead of an abstract interface.

I plan to refactor the dependencies. The dependencies after changed should look like this:
After changed

@rogercloud @themanforfree


How to override to send values even they are not changed?

My OPCPublisher version is 2.7.206.  I understand the default behaviour of the OPCPublisher is send only changed values.  How to send the values even if they are not changed.

Heartbeat is working 2.8.  Tracking periodic reads (not required here, but related) in #1934.

In 2.9.0-preview4 we support cyclic reads, which are periodically executing read requests that return values even if they do not change. This could be a good option to support your use case.


[BUG] Chocolatey no longer supports '--local-only'

Please confirm these before moving forward

[X] I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
[X] I have tested that this issue has not been fixed in the latest (beta or stable) release.
[X] I have checked the FAQ section for solutions
[X] This issue is about a bug (if it is not, please use the correct template)

Describe your issue
WinGetUI does not display any programs installed by chocolatey. The logs show that the --local-only flag is no longer supported and has been removed. If you run the chocolatey command (choco list --local-only) from the command line you'll see that it does not return any installed programs. If I then run the same choco list command without the --local-only flag then I get the list of items that were installed with chocolatey.
Steps to reproduce the issue
No response
WingetUI Log
🟢 Using cached lang file
🟡 Using bundled lang file (forced=True)
It took 0.005001544952392578 to load all language files
🟢 checkQueue Thread started!
🟡 System chocolatey used
🔵 Language file up-to-date
🔵 Starting main application...
🔵 Looking for alive instances...
🟡 Found lock file(s), reactivating...
🔵 Reloading Winget sources...
🔵 Starting update check
 * Serving Flask app 'WingetUI backend'
 * Debug mode: off
WARNING: This is a development server. Do not use it in a production deployment. Use a production WSGI server instead.
 * Running on http://localhost:7058
Press CTRL+C to quit
🟢 Downloaded latest metadata to local file
🔵 Loaded metadata from local file
🔵 Version URL: https://versions.marticliment.com/versions/wingetui.ver
🟢 Updates not found
🔵 Reactivation signal ignored: RaiseWindow_[1694690288.9522743]
🔵 Reached main ui load milestone
{'sudoFound': True, 'sudoVersion': '', 'ScoopFound': False, 'ScoopVersion': 'Scoop is disabled', 'PipFound': False, 'PipVersion': 'Pip is disabled', 'NpmFound': False, 'NpmVersion': 'Npm is disabled', 'WingetFound': True, 'WingetVersion': '', 'ChocolateyFound': True, 'ChocolateyVersion': '2.2.2\r'}
🔵 Is Dark
Can't disconnect
Can't disconnect
🟢 Install tab loaded successfully
🔵 Starting Winget search for available packages
🔵 Starting Chocolatey search for available packages
🟢 Found valid, non-empty cache file for Winget!
🟢 Found valid, non-empty cache file for Chocolatey!
🔵 Starting Winget package caching
🟢 Winget search for installed packages finished with 5212 result(s)
🔵 Starting Chocolatey package caching
🟢 Chocolatey search for installed packages finished with 241 result(s)
Can't disconnect
Can't disconnect
Can't disconnect
🟢 Install tab loaded successfully
🔵 Reloading sources...
🔵 Reloading Winget sources...
🔵 Reloading sources...
🔵 Reloading Winget sources...
🟢 Searching for string ""
Can't disconnect
Can't disconnect
🟢 Install tab loaded successfully
🔵 Starting Winget search for installed packages
🔵 Starting Chocolatey search for installed packages
🟢 Searching for string ""
🔵 Reloading Scoop sources...
🔵 Reloading Scoop sources...
Can't disconnect
🟢 Settings tab loaded!
🟢 About tab loaded!
🟢 Main application loaded...
🟢 Total packages: 348
🟢 Total packages: 5453
🟢 Chocolatey search for installed packages finished with 1 result(s)
🟢 Searching for string ""
🔵 Starting Chocolatey search for updates
🔵 Starting Winget search for updates
🟢 Chocolatey packages cached successfuly
🟢 Winget search for installed packages finished with 169 result(s)
🟢 Searching for string ""
🟢 Searching for string ""
🟢 Total packages: 170
🟢 Winget search for updates finished with 3 result(s)
🟢 Searching for string ""
🟢 Chocolatey search for updates finished with 0 result(s)
🟢 Searching for string ""
🟢 Searching for string ""
🟢 Total packages: 3
🟢 Winget packages cached successfuly
🔵 Starting Winget search for installed packages
🔵 Starting Chocolatey search for installed packages
🟢 Searching for string ""
🟢 Chocolatey search for installed packages finished with 1 result(s)
🟢 Searching for string ""
🟢 Winget search for installed packages finished with 169 result(s)
🟢 Searching for string ""
🟢 Searching for string ""
🟢 Total packages: 170
🔵 Announcement URL: https://www.marticliment.com/resources/wingetui.announcement
🔵 Image URL: https://www.marticliment.com/resources/translate.png
🔵 Loading operation log...
🔵 Loading log...
🔵 Reloading Package Manager logs...
🔵 Starting Winget search for installed packages
🔵 Starting Chocolatey search for installed packages
🟢 Searching for string ""
🟢 Chocolatey search for installed packages finished with 1 result(s)
🟢 Searching for string ""
🔵 Loading log...
🟢 Winget search for installed packages finished with 169 result(s)
🟢 Searching for string ""
🟢 Searching for string ""
🟢 Total packages: 170
🔵 Copying log to the clipboard...
🔵 Loading log...

Package Managers Logs
---------Chocolatey
Chocolatey v2.2.2
Invalid argument --local-only. This argument has been removed from the list command and cannot be used.
---------Winget

Relevant information
No response
Screenshots and videos
No response

This issue will be fixed on the next version


multi perform

is there a imp for multi perform? so that i can receive data async?

I don't know exactly what you mean with "multi perform", but it is possible to request data asynchronously.
You can find some example here:

https://github.com/whoshuu/cpr/blob/master/test/async_tests.cpp
https://whoshuu.github.io/cpr/advanced-usage.html#asynchronous-requests

I don't know exactly what you mean with "multi perform", but it is possible to request data asynchronously.
You can find some example here:

https://github.com/whoshuu/cpr/blob/master/test/async_tests.cpp
https://whoshuu.github.io/cpr/advanced-usage.html#asynchronous-requests

sorry for the bad description of my issue. my question is that if i POST a request and the remote server will send some big data for me. so it will separate to small parts and send to me.In this situation what can i do to receive every single data ?


Enable extradisks and add root_device to ironic nodes

This is required for enabling extra disks, e.g for rook/ceph
This also enables an extra disk so we can prove this works
and support testing with ceph/rook.
Note this requires https://github.com/openshift-metalkube/terraform-provider-ironic/pull/10

cc @karmab this should enable rook testing with VMs deployed via dev-scripts, note that until openshift-metalkube/terraform-provider-ironic#10 lands you'll have to apply it manually and comment the sync_go_repo_and_patch for that repo in 03_ocp_repo_sync.sh

Build FAILURE, see build http://<IP_ADDRESS>:8080/job/dev-tools/408/

I temporarily added the terraform-provider-ironic patch to the 03 script so hopefully we can see CI passing.

Build SUCCESS, see build http://<IP_ADDRESS>:8080/job/dev-tools/415/

Build FAILURE, see build http://<IP_ADDRESS>:8080/job/dev-tools/429/

I think the change looks good, do we know why the masters failed to come up?

No, we've been seeing it in several jobs but it's hard to discover why since the logs download is zero bytes?
https://github.com/openshift-metalkube/dev-scripts/pull/188 may help with that, but AFAICT it's not related to this patch so I'll remove the WIP

Agreed with @stbenjam to merge this and the corresponding terraform-provider-ironic patch

Build SUCCESS, see build http://<IP_ADDRESS>:8080/job/dev-tools/445/


Button Layout in combined mode

isnt the button Layout Kinda weird when going for combine?
wouldnt it make a lot more sense if the vjoy buttons were set like on a normal controller, especially considering some games use Direct input but heavily rely on the Layout most controllers have regarding the number of buttons etc (for example some games wont reconize buttons past 13 since that's what most controllers have or they have problems displaying button icons because xbox controllers dont above 10 buttons and most other directinput controllers dont go above 13.
I think we should go a bit like this:
first and foremost, the d-pad should be properly associated to the d-pad.
ABXY to butons 1-4
L,R,L2 and R2 become 5,6,7 and 8 respectively.
minus and plus being essentially select and start buttons get 9 and 10,
LStick Press and RStick Press becom 11 and 12.
the Axes are fine as they are.
and the rest can be arranged however needed, although I do it this way, with the previous hacky way I combined the joycons:

I'm going to start working on this, I took a look at the code and have an idea on how to do everything but putting it on the POV Hat, which I'll look into anyway.

nice to see, and thanks.
but for the buttons one intresting thing might be an INI file which might let the user set the buttons as they like.

I've implemented a very broken version of this into my fork of this. The major problems are listed in the commit that adds it. I'm gonna try to work on it more, but honestly, I'm not super experienced with C++ or messing with binary like this, so if I do figure it out, it'll take awhile.


Improve JSON decoding strategy

Describe the feature or improvement you're requesting
In the current implementation, the HTTP client is very unsafe and slow: https://github.com/mgallo/openai.ex/blob/main/lib/openai/client.ex#L15
Calling String.to_atom/1 is considered a bad practice and should be avoided in frequent code paths like this, since this creates new atoms in the VM memory, which will never be GCed.
The responses are also unstructured for mostly the same reason.
Not to mention that JSON as a library is horribly slow compared to all the other engines: https://gist.github.com/devinus/f56cff9e5a0aa9de9215cf33212085f6
My suggestions:

Replace JSON with Jason or Poison
Switch to safe atom creation strategy (pretty easy with Jason/Poison to not have to manually do string conversion to existing atoms)
Define core API models as structs, and directly decode to them

Additional context
No response

Thank you very much for your report and valuable suggestions 🙏 . I'll have a look at it as soon as I can, I was already planning to replace JSON with Jason (which, from the benchmarks, and for what I need, seems the best), and it absolutely makes sense to define the API models as struct and remove that String.to_atom/1.

I recommend using Jason since it's the default in Phoenix and many other projects. It's the fastest implementation as well.
+1 to decoding to structs.

Hey, I replaced Json with Jason in 0.4.0.  For backward compatibility, no changes have yet been made to the transformation from string to atoms.
Now that the library supports all the new OpenAI APIs, I plan to release a future version that will introduce structs and probably the ability to choose how to parse the response object (need to think about that). I will also add a compatibility layer for applications that currently use the library, so as not to break too much existing implementations.
Release log: https://github.com/mgallo/openai.ex/releases/tag/v0.4.0
Hex.pm: https://hexdocs.pm/openai/0.4.0/api-reference.html

Thanks!


SW-5704 Make live session instructions localizable

Move the English text from the session instructions into the string
table.
This includes a few minor copy changes per the designs from SW-5704:

The button label in the instructions matches the actual label on
the button
The instructions include the event type rather than always saying
"Live Session"
Clarify that the Internet connection has to be on the user's
device

#2948
#2947  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sgrimm and the rest of your teammates on  Graphite

#2948
#2947  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sgrimm and the rest of your teammates on  Graphite

Merge activity

Aug 2, 4:56 PM EDT: @sgrimm started a stack merge that includes this pull request via Graphite.


Option to add time-picker in date range picker

I can see the input box is manually editable to add time but It would be very helpful to have a toggle option to add a time-picker in the date range picker panel.
It can be a simple slider input for selecting the hour and minute along with the date selector.

Hi @nairvishal 👋
Thank you for using our package.
Sorry for the delay. Thanks for the request. I believe we already have a similar proposal. It shows how useful it would be to have it really. We will implement it very soon.
PRs are always welcome 🎉.

Hello,
Time picking is already available or in progress ?
Thanks 😄

Hi Tony 👋
Thanks for your feedback.
Be reassured, it will be available very soon.

Is it available now?

Yes, normally

Not yet but we are working on it.

Do you have any forecast as to when this feature will be released?

@onesine @tagrudev @joaoazevedoJS (hey I'm BR too) @M3T1N @OrianFrenchAppWeb @nairvishal
Hi guys, since PRs are welcome 😉, follow a PR in below just doing exactly that :rocket::
https://github.com/onesine/react-tailwindcss-datepicker/pull/236


3.73: bump collector to 3.12.4

Description
Bumping collector to close moderate/low vulnerabilities:
https://github.com/stackrox/collector/releases/tag/3.12.4
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
CI is sufficient.

/retest


No option to fix abstracts on right click

High there. Have installed the plugin and restarted Zotero but the option to fix abstracts is not visible when I right click an item.
Thanks for this great tool!

I clearly messed something up in the most recent release. Will look into it!

Try this older version: https://github.com/dcartertod/zotero-plugins/blob/31f92027013f688e6ba2eb3d56faf2938e6db791/ZoteroAbstractCleaner.xpi

Fixed the core issue.


Event Creation Test

The event creation test is running into an error seemingly because of the following lines: "return await testing_bot.wait_for('message', timeout=2, check=lambda x: x.guild.id == channel.guild.id and x.author.name == DICORD_BOT_NAME and content in x.content)" because of a timeout error and also line 89 in utils.py is running an exception.

We aren't going to be able to fix this without completely reworking event creation. Discord bots are not allowed to call interactions in discord.py so there's no way to actually automate testing if the buttons work or not.


DEV: Use new consistency-check-skipping notification type API

Relies on new api added here - https://github.com/discourse/discourse/pull/16299

I don't think we need this anymore @markvanlan, closing.


Added attribution link to the source of the quicksort example in ABOUT.md

I realized after the fact that I'd gotten the Quicksort example from "Learn You A Haskell", so I added a link.

Thanks!


Failed to load vault items

Extension
https://www.raycast.com/jomifepe/bitwarden
Description
Search vault isn't functioning properly. When I am trying to open this window the progress bar moves for 10-15 seconds, then I get "Vault empty" message. Sync doesn't work either. But I could get my passwords with desktop app, browser extension or bitwarden-cli. Tried to reinstall raycast extention and configure it from scratch - it didn't help.
Steps To Reproduce
I suppose this issue can be connected with upgrade of bitwarden cli. Now I have: bitwarden-cli: stable 2023.12.0 (bottled)
Current Behaviour
No response
Expected Behaviour
No response

It works!
Steps to downgrade:
brew uninstall bitwarden-cli
brew tap --force homebrew/core
brew tap-new $USER/local-tap
brew extract --version=2023.10.0 bitwarden-cli $USER/local-tap
brew install<EMAIL_ADDRESS>


Add page_size to config and Go iterator

@jba
@jmuk
@vchudnov-g
@pongad
@shinfan @garrettjonesgoogle Modified the config to include the page_size parameter, ptal? it didn't cause any test failures from what I could tell... seems a red flag.

Sorry, jumping in -- I was working on essentially the same change for Ruby/Python (#147) and just saw this.

Rebased and ready


Implement defaultArmor option

Feature Request
Implement defaultArmor option in CLI and CRD
Is your feature request related to a problem? Please describe the use case.
KubeArmor doesn't have a default posture in global context in case we only have from Source based policies.
Describe the solution you'd like
Add options in KubeArmor to have a configurable default posture.
Initial Goals

[ ] -defaultArmor CLI option

[ ] Allow ( Current Behaviour )
[ ] Block
[ ] Audit

[ ] defaultFileArmor - default position for both files/processes
[ ] defaultNetworkArmor
[ ] Discuss on how to handle in CRD

cc @nyrahul @nam-jaehyun

SGTM, handling in CRD can be kept in different issue altogether and can be done later.

@nyrahul as Rahul said we can handle the CRD part later.
let's use defaultFileAction and defaultNetworkAction rather than xxxArmor.
what is the purpose of "-defaultArmor"?

Just noted the CRD Part so as keep it as a later action item.

what is the purpose of "-defaultArmor"?
A global option, if someone doesn't want to individually configure file/network/future more options like caps maybe.

Just noted the CRD Part so as keep it as a later action item.

what is the purpose of "-defaultArmor"?

@nam-jaehyun A global option, if someone doesn't want to individually configure file/network/future more options like caps maybe.

@daemon1024, do we need a global option if we have specific options for file, network? If we have multiple option then we need to add conditions around it. We can simply keep file, network options. Maybe I miscommunicated this during our design call.


mirrors: Make targets_path and metadata_path optional

Now clients can leave out targets_path or metadata_path if the
client knows the mirror does not have that type of targets.
This is backwards compatible: old mirror configs continue to work.
Fixes #1079.
Signed-off-by: Jussi Kukkonen<EMAIL_ADDRESS>
PR notes:
This is a minor improvement in the warehouse case where one mirror has metadata and targets, and the other mirror has only targets.
Note that this leaves the issue of using os.path.join() on URLs as is: Fixing #1077 in a provably backwards compatible way seems tricky.
I believe this is a good if minor change... but I'll make the case against merging as well:

the usefulness in pip/warehouse is minimal: the directory confinement is not expressive enough to be useful so pip has to use two separate mirror configurations anyway -- this should mean that in normal operation no requests will be made to the 'wrong' mirror: I believe they would only happen if the metadata mirror does not respond to a request for e.g. a specific targets bin file. In that case the wrong mirror would be asked as well -- this would be an annoyance, not a security issue
it can be argued that the correct solution is to make directory confinement more powerful instead:

it should work on both metadata and targets
it should be expressive enough to say "allow everything under this directory"

Unfortunately improving directory confinement is likely to be a breaking change.
Please verify and check that the pull request fulfills the following
requirements:

[x] The code follows the Code Style Guidelines
[x] Tests have been added for the bug fix or new feature
[x] Docs have been added for the bug fix or new feature

In case it's relevant, these are the configs I keep currently switching in pip depending on what I'm downloading:
config 1 (for downloading index file targets from pypi.org):
        {
            'https://pypi.org': {
                'url_prefix': 'https://pypi.org',
                'metadata_path': 'tuf/',
                'targets_path': 'simple/',
                'confined_target_dirs': ['']
            }
        }

config 2 (for downloading distribution target files from pythonhosted.org):
{
'https://pypi.org': {
'url_prefix': 'https://pypi.org',
'metadata_path': 'tuf/',
'targets_path': 'not_real_path/', # TODO should not exist
'confined_target_dirs': []
},
'https://files.pythonhosted.org/packages': {
'url_prefix': 'https://files.pythonhosted.org/packages',
'metadata_path': 'not_real_path', # TODO should not exist
'targets_path': '',
'confined_target_dirs': ['']
}
}

directory confinement is not expressive enough to be useful so pip has to use two separate mirror configurations anyway

Actually, it's possible that even a very expressive directory confinement might not be able to handle the warehouse setup in a single config... I'd have to really think the solution through (but maybe it's not needed for this PR)


why add “added_values”

Hi, I see in the spider.py
added_values = [
"1",
"2",
"3",
"4",
"5",
"yes",
"no",
"y",
"t",
"f",
"m",
"n",
"null",
]
I've not just figured out why do we need to add these values in entities?

@OhadRubin  Hi
In my understanding, you choose a similar model from "extractive question answering (Rajpurkar et al., 2016)", that could select words that may be DB values and added_values just as the default values.
you mean in BRIDGE, they use the "copy mechanism " which is better than yours,
Is my understanding correct?

No, we are able to copy from the question as well.
Cases we cannot handle for example are the following:
Question: "What are the names of all the french actors?"
Query: SELECT actor.name WHERE actor.country="France"

Our model will be able to answer:
SELECT actor.name WHERE actor.country="french"

But BRIDGE does IR on the schema on the actor.country column so the input to the model includes the tokens for "France". Because the distance from "french" and "France" it will be included there as well.
This method is very nice and could be integrated to SmBop very nicely.

Wow, Thanks a lot for your interpretation, let's try it!

@yonatansito  have you try to integrate it with SmBop?

Yes, we are able to copy from the question as well.
Cases we cannot handle for example are the following:
Question: "What are the names of all the french actors?"
Gold Query: SELECT actor.name WHERE actor.country="France"

Our model will be able to answer:
SELECT actor.name WHERE actor.country="french"

But BRIDGE does IR on the schema on the actor.country column so the input to the model includes the tokens for "France" (because the edit distance from "french" and "France" is small) .
This method is very nice and could be integrated to SmBop very nicely.


Hi, is there any faster gpu-version?

Hi, I find it was too slow when I ran the code, is there any faster gpu-version ?

Hi,
We did use the GPU in our experiments. The SparseMAP layer itself cannot run on the GPU because it relies on external C++ code. What I recommend is: (i) Run the first part of your model on GPU. (ii) copy the potentials to CPU. (iii) Run SparseMAP on CPU. (iv) copy back and finish. This worked well for us and-- in the case of ESIM-- with minimal slowdown.
Hope this helps!

Really interesting. I am also wondering whether your sparse-attention support 4D tensors input like a mini-batch of images.


Added trignometric calculator #1168

Have you read the Contributing Guidelines ?
YES
Description
Added trignometric calculator.
Fixes #1168
closes #1168
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

https://github.com/Kushal997-das/Project-Guidance/assets/168436423/07b6e363-7753-4371-b88b-14cd4cd3986d

@Kushal997-das sir, I have added the deploy link Is it ok now, Please review it.


refactor: generalize PiLp to WithLp

The motivation is to be able to reuse this for ProdLp in #6136.
This matches the pattern of how the Lex type synonym is used.

I think this is a nice refactor, but it would be good if someone else had eyes on it too. Zulip thread

bors d+
Thanks!

bors merge


Tide sits in state WAIT

Tide sits in state "WAIT" even when all tests have passed.
/kind bug

/assign

This should be resolved as of #216


df_equals do not assert frame missmatches in some cases

Sometimes df_equals just returns False when frame aren't equals and not asserting it
https://github.com/modin-project/modin/blob/dd691cd0d4bb5403b38242563ed8b6ddb316734a/modin/pandas/test/utils.py#L506-L510

Also, I think we need to use the functions in the public pandas API to compare dataframes via df_equals.
from modin.pandas.test.utils import df_equals
FutureWarning: pandas.util.testing is deprecated. Use the functions in the public API at pandas.testing instead.

@YarShev good point! I've filled it in an issue #2260


Crash when loading

Using Thaumcraft-1.12.2-6.1.BETA13 and forge 2698
https://pastebin.com/NqSvCbP9
I have tried to figure out why this is suddenly an issue.  Tried recreating configs.  Any ideas?

Have you updated Forge recently, did it work before?

Points to a modpack issue then. I'm on 2691 myself and don't experience this.
You guys seem to be using the same modpack though.

Possibly a modpack issue then because I'm on 2691 and not experiencing this.
Try removing mods in groups to isolate the culprit?

It looks like mindcraft itself is somehow messed up

Try copying the “mods”, “config”, and “saves” folders to a new profile with the new forge version

I did that before I made the original bug report.

It looks like trying another launcher has found the problem.  It worked with twitch/curse launcher.  Then I realized I forgot to add liteloader as a mod file since its built into multimc.  Then I went and got the most recent release of liteloader added it to the mods folder and got this crash.
https://pastebin.com/Gv4XM5Cu

i think multiMC loads minecraft differently to how forge does, i have heard other isues within the modded community of other mods crashing due to multimc (but they all tested with twitch andare fine with that)

I am loading thaumcraft from multi MC and have no issues (unless that is why I am experiencing bug #776)

And try to find if they are using the newest LiteLoader: it may be a case of a bug introduced in the new LiteLoader

And as a FYI, you can put the download link for a twitch modpack into the “import from zip” field and it may fix the issue

In the crash SPOUNGE is the most likely culprit... did not see that coming

And give the game more RAM...
https://m.youtube.com/watch?v=gGyHhqgw9dE

1 Gigabyte won’t cut the mustard

Ok I give my pack 8 gigs of ram.  I also added liteloader into the twitch launcher and it still crashed.  Its crashing with liteloader with both launchers.  The issue is the latest version of liteloader.  I do not know why it says sponge in the crash report as I am not using it at all this is a single player pack I made myself and have rebuilt with several launchers.  The only way I can play is by not using liteloader and my fav minimap voxelmap.

Fyi when you install liteloader into a forge profile it just adds it into the mods folder like I do.

You can use an older LiteLoader through MultiMC

Just double checked.  When I try to install liteloader there is only one version listed.

Odd, try putting the LiteLoader jar on their Jenkins page into the mods folder

Sift through the versions until you get one that works

And, just making sure, you did use multiMC to up the ram, right?

To install Liteloader you need to grab the executable from here (assuming you're on Windows, sorry that obviously won't help if you're on anything else): grab the LiteLoader installer

Probably a silly question but @grydian you're using Java 8, right?

@grydian Glad you found it, sorry to not be helpful. Close the issue if you're done please!

So I did read that crash report right!


 not working in Extra field

Report ID: 8H9A39XE
In version 1.6.73, auto-updated on my computer August 31, 2016, what is between <pre> and </pre> is simply substituted with the string "undefined". This happens in the Extra field only, as far as I can see. In the Title field it works fine. I have used this construction extensively without problems previously.

Can you right-click that reference and select "send BBT error"?

Done; I get the following entry in the bibtex file:
@article{Brons:pretest,
title = {$pretest$},
author = {{Br\o{}ns}, Morten},
note = {Hello undefined}
}
Fra: retorquere<EMAIL_ADDRESS>Sendt: 1. september 2016 16:46
Til: retorquere/zotero-better-bibtex
Cc: Morten Brøns; Author
Emne: Re: [retorquere/zotero-better-bibtex]  not working in Extra field (#559)
Can you right-click that reference and select "send BBT error"?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/retorquere/zotero-better-bibtex/issues/559#issuecomment-244102038, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AUrT4wTZzQI7Vrk0WEMweJjoVYhkArWPks5qluUvgaJpZM4JyveQ.

Can you try https://github.com/retorquere/zotero-better-bibtex/releases/download/builds/zotero-better-bibtex-1.6.73-circle-2838.xpi ?

It works!
Thanks a lot for your lightning fast reaction. And thanks for a wonderful plugin that makes my life easier on a daily basis. Will this be a basis for an update?
Best wishes,
Morten
Fra: retorquere<EMAIL_ADDRESS>Sendt: 1. september 2016 18:19
Til: retorquere/zotero-better-bibtex<EMAIL_ADDRESS>Cc: Morten Brøns<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Emne: Re: [retorquere/zotero-better-bibtex]  not working in Extra field (#559)
Can you try https://github.com/retorquere/zotero-better-bibtex/releases/download/builds/zotero-better-bibtex-1.6.73-circle-2838.xpi ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/retorquere/zotero-better-bibtex/issues/559#issuecomment-244132061, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AUrT4xWnqwwDLvCNOhhOUhZimEX4id0Sks5qlvr1gaJpZM4JyveQ.

Yes, before tomorrow afternoon.

A new release is out, upgrade will be automatic (but it's just a tagged version of what you have now)


NOISSUE - add nats conf

Signed-off-by: Mirko Teodorovic<EMAIL_ADDRESS>What does this do?
add nats conf to control max message size

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@b8138fa). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1031   +/-   ##
=========================================
  Coverage          ?   79.16%
=========================================
  Files             ?       95
  Lines             ?     6610
  Branches          ?        0
=========================================
  Hits              ?     5233
  Misses            ?     1065
  Partials          ?      312

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8138fa...ce610cb. Read the comment docs.


User name not mapper correctly from SAML accertion in OIDC app

Describe the issue:

I wanted to create an IDP init flow

Created IDP init SAML app on Azure
image

In sub organization created a connector, setup with Azure SAML app and did the claim mapping
image

Start the flow with a link and everything works fine.
https://localhost:9443/samlsso?spEntityID=saml2-web-app-pickup-dispatch.com&fidp=OrganizationSSO&org=ORG_C

All claims are mapped correctly. Particularly the user name
http://wso2.org/claims/username to the<EMAIL_ADDRESS>

Created the OIDC app and chose claims
image

in the profile section NOT select the Username !!!
image

Start the flow with the link and everything works fine.
https://localhost:9443/oauth2/authorize?client_id=q0BLO78BJ5O...&fidp=OrganizationSSO&org=ORG_C&redirect_uri=http%3A%2F%2Flocalhost%3A8080%2Fpickup-manager%2Foauth2client&response_type=id_token&scope=openid email profile

but I was not getting the user name (it is expected because the app does not ask for it)!
image
How to reproduce:

5a. in profile select the Username !!!
image
6a. Start the flow with the link and I get the error
https://localhost:9443/oauth2/authorize?client_id=q0BLO78BJ5O...&fidp=OrganizationSSO&org=ORG_C&redirect_uri=http%3A%2F%2Flocalhost%3A8080%2Fpickup-manager%2Foauth2client&response_type=id_token&scope=openid email profile
image
Error in Log :
[2023-11-17 14:02:55,384] [58effb8e-b4af-45a3-a23f-7504b5c84ad4] ERROR {org.apache.catalina.core.ContainerBase.[Catalina].[localhost].[/authenticationendpoint].[oauth2_consent.do]} - Servlet.service() for servlet [oauth2_consent.do] in context with path [/authenticationendpoint] threw exception [An exception occurred processing [/oauth2_consent.jsp] at line [92]
89:         String[] queryParams = queryString.split("&");
90:         for (String queryParam : queryParams) {
91:             String[] queryParamKeyValueArray = queryParam.split("=", 2);
92:                 queryParamMap.put(queryParamKeyValueArray[0], queryParamKeyValueArray[1]);
93:         }
94:     }
95:
Stacktrace:] with root cause java.lang.ArrayIndexOutOfBoundsException: Index 1 out of bounds for length 1
at org.apache.jsp.oauth2_005fconsent_jsp._jspService(oauth2_005fconsent_jsp.java:1297)
at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:623)
at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:466)
at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:379)
at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:327)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:623)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:209)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:153)
at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:51)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:178)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:153)
at org.wso2.carbon.tomcat.ext.filter.ContentTypeBasedCachePreventionFilter.doFilter(ContentTypeBasedCachePreventionFilter.java:51)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:178)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:153)
at org.wso2.carbon.identity.application.authentication.endpoint.util.filter.AuthenticationEndpointFilter.doFilter(AuthenticationEndpointFilter.java:190)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:178)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:153)
at org.wso2.carbon.identity.application.authentication.endpoint.util.filter.AuthParameterFilter.doFilter(AuthParameterFilter.java:89)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:178)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:153)
at org.apache.catalina.filters.HttpHeaderSecurityFilter.doFilter(HttpHeaderSecurityFilter.java:129)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:178)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:153)
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:168)
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:90)
at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:481)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:130)
at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:93)
at org.wso2.carbon.identity.context.rewrite.valve.TenantContextRewriteValve.invoke(TenantContextRewriteValve.java:118)
at org.wso2.carbon.identity.context.rewrite.valve.OrganizationContextRewriteValve.invoke(OrganizationContextRewriteValve.java:115)
at org.wso2.carbon.tomcat.ext.valves.SameSiteCookieValve.invoke(SameSiteCookieValve.java:38)
at org.wso2.carbon.identity.cors.valve.CORSValve.invoke(CORSValve.java:83)
at org.wso2.carbon.identity.authz.valve.AuthorizationValve.invoke(AuthorizationValve.java:200)
at org.wso2.carbon.identity.auth.valve.AuthenticationValve.invoke(AuthenticationValve.java:120)
at org.wso2.carbon.tomcat.ext.valves.CompositeValve.continueInvocation(CompositeValve.java:110)
at org.wso2.carbon.tomcat.ext.valves.TomcatValveContainer.invokeValves(TomcatValveContainer.java:49)
at org.wso2.carbon.tomcat.ext.valves.CompositeValve.invoke(CompositeValve.java:71)
at org.wso2.carbon.tomcat.ext.valves.CarbonStuckThreadDetectionValve.invoke(CarbonStuckThreadDetectionValve.java:152)
at org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:670)
at org.wso2.carbon.tomcat.ext.valves.CarbonContextCreatorValve.invoke(CarbonContextCreatorValve.java:63)
at org.wso2.carbon.tomcat.ext.valves.RequestEncodingValve.invoke(RequestEncodingValve.java:49)
at org.wso2.carbon.tomcat.ext.valves.RequestCorrelationIdValve.invoke(RequestCorrelationIdValve.java:137)
at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74)
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:342)
at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:390)
at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:63)
at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:928)
at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1794)
at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:52)
at org.apache.tomcat.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1191)
at org.apache.tomcat.util.threads.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:659)
at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
at java.base/java.lang.Thread.run(Thread.java:834)
Expected behavior:

The expectation was to resolve the user name as in the SAML application.
Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: ver IS 7
OS: Mac
Database: Default
Userstore: default with ext IDP

Hi @lpastor74,
Can you please add the exact steps to reproduce the issue?

@madurangasiriwardena if you properly read the error message, it's due to an array index out of bounds issue. Probably this can be due to not having any values in a query parameter. When the consent page is prompted, probably, if there are no claims to be consented this issue may rise. Anyway we can't assume that query parameter may always have a value.
https://stackoverflow.com/questions/4557387/is-a-url-query-parameter-valid-if-it-has-no-value

Based on the above comments, I'm rewriting the steps to reproduce the issue.

Create an oauth/oidc application in the root tenant.
Go to User attributes section of the created application and select "username", "email" as requested attributes
Create an organization and share the application with the new organization.
Switch to the organization.
Create a SAML IDP for Azure. Do the attribute mappings (username, email likewise)
Connect the created SAML IDP in step 5 to the shared application in the organization.
Try the login flow using the following URL

https://localhost:9443/oauth2/authorize?client_id=<client-id-of-root-organization's-app>&fidp=OrganizationSSO&org=<created organization name>&redirect_uri=<redirect url of configured in root level application>&response_type=id_token&scope=openid%20email%20profile

Authenticate the user from Azure SAML IDP

hi team , any update on this ???

hi team , any update on this ???

Working on the issue. Will share an update asap.

Hi @lpastor74
Tried the following setup and did not reproduced the issue.
1 - Created OIDC app, share with organizations.
2 - Select the SP claims of the created OIDC app.
3 - Switch to an organization, created a SAML IDP connection and add to the shared app's login sequence.
(Please note that, I used another IS running on port 9444 as my federated SAML IDP)
4 - Tried the login flow. The ID token contained all the claims including username claim.
Please share details if the steps are different with steps you tried. Will try to get an azure account for test the exact flow of having Azure AD as a SAML IDP.
Thanks,
Sadil

I will be more than happy to review the video session and debug it with you ...
https://drive.google.com/file/d/1JsEtlX8-oTZne6LDnn96oNUlkHTPSxej/view?usp=sharing

I cannot paste the full record , but I can go in meeting with you and we can review it together
https://drive.google.com/file/d/1JsEtlX8-oTZne6LDnn96oNUlkHTPSxej/view?usp=sharing


Parametrise the 95 number

https://github.com/FINRAOS/DataGenerator/blob/master/dg-core/src/main/java/org/finra/datagenerator/consumer/EquivalenceClassTransformer.java#L247

Convert the 95 to a system parameter that defaults to 100 (unless there's a reason for the 95).
Change the 95s below to cipher.length

there is a reason for 95


Add hello world imm rom ext

Add minimized C code, startup asm and linker script for a standalone IM_EXT build target.
Add a bazel rule imm_rom_ext_section, which will transform binaries into object files and turn it to a target that can be directly used as deps of ROM_EXT's bazel targets.
Reuse the rule opentitan_binary to build IM_EXT and add a attribute to skip the signing stage to the rule. The manifest given as None will turn into the default manifest and keep the signing operation so we need to skip it explicitly.
Add a map for all IM_EXT target that can be used and make the ROM_EXT targets iterate the map to generate multiple targets.
Update the ROM_EXT to use in e2e verified boot test.

This PR partially addresses https://github.com/lowRISC/opentitan/issues/24368.
The first commit is included in https://github.com/lowRISC/opentitan/pull/25043. I will remove it after it is reviewed and merged.

My memory might be fuzzy but I think that opentitan_binary exports not only the signed binary but also the unsigned one, just a different output group. Therefore, I think you might not need a new attribute to skip signing, you just need to teach imm_rom_ext_section to look for the unsigned binary. Maybe @cfrantz can help with that, otherwise I can have a look to double-check if that's correct.

My memory might be fuzzy but I think that opentitan_binary exports not only the signed binary but also the unsigned one, just a different output group. Therefore, I think you might not need a new attribute to skip signing, you just need to teach imm_rom_ext_section to look for the unsigned binary (probably use use ctx.attr.src and look at src.output_group["<exec_env>_binary"].

I did some experiments, if I reuse the exec env //hw/top_earlgrey:silicon_creator, then the signing will cause the following error:
ERROR: /usr/local/google/home/lchiawei/opentitan/sw/device/silicon_creator/imm_rom_ext/BUILD:40:17: PreSigningArtifacts sw/device/silicon_creator/imm_rom_ext/hello_world_binaries_silicon_creator.test_key_0.pre-signing failed: (Exit 1): opentitantool failed: error executing PreSigningArtifacts command (from target //sw/device/silicon_creator/imm_rom_ext:hello_world_binaries) bazel-out/k8-fastbuild-ST-13d3ddad9198/bin/sw/host/opentitantool/opentitantool '--rcfile=' --quiet image manifest update ... (remaining 4 arguments skipped)

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
Error: Image doesn't appear to contain a manifest, or the manifest is corrupted

Caused by:
    Condition failed: `manifest.signed_region_end <= len`<PHONE_NUMBER> vs 1048576)

Alternatively, you might want to use the kind attribute (in common_binary_attrs) to introduce a new type of binary? And/or: if you introduce a new exec_env (which might make sense here), you can probably create one with no default manifest so it doesn't sign by default?

Actually I did found that the issues only happen when we use "//hw/top_earlgrey:silicon_creator" as the exec env, and using an empty manifest in that exec env can solve the issue. As currently all exec envs will derive same binaries and I plan to match the exec env between IM_EXT and ROM_EXT in the future, I will simply use fpga_cw340 as the only exec env. The exec env for silicon creator with empty manifest will be add in the future. And I also remove the attribute to skip the signing process.

Hi @timothytrippel ,
Thanks for your review. I've removed those TODOs and rebased my commit.


Source Question

I've seen on my Linux machine when I built it, it had more sources like 4chan. How come they don't get added when I update?

Because it doesn't work so I don't include it in the releases. :smile:

I downloaded it from the release section though

Because the Linux packaging isn't as advanced as the Windows one, and also includes unnecessary stuff for now. It gets everything in the release/ folder, while the Windows setup is limited to some files.

ok


Feature/lint

This adds a lint target to the Makefile that does golint and go vet. It also adds the lint check to Travis.
This PR also fixes most of the lint and go vet errors already existing in the project.
For the remaining ones that we're aware of but are unable to address right away, there is an exclude file which turns the lint errors into warnings. This way we can benefit from the linters right away.
E.g.:
$ make lint
WARNING [excluded]: ./swim/disseminator.go:107: range var member copies Lock: swim.Member
WARNING [excluded]: ./swim/member.go:53: address passes Lock by value: swim.Member
WARNING [excluded]: ./swim/member.go:57: incarnation passes Lock by value: swim.Member
WARNING [excluded]: ./swim/memberlist.go:128: Pingable passes Lock by value: swim.Member
WARNING [excluded]: ./swim/stats_test.go:101: range var member copies Lock: swim.Member
WARNING [excluded]: ./swim/test_utils.go:135: range var expected copies Lock: swim.Member
$

(exit code 0)

This also adds linting to the pre-commit hook as part of make setup.
@uber/ringpop

LGTM

LGTM


bug: non-numeric type variable Error

Aim
fn hello<N>(array: [u1; N]) {
    for i in 0..N {}
}

fn main() {
    let slice: [u1] = [1, 2];
    hello(slice);
}

Expected Behavior
The hello function should iterate over a valid array of type u1 without panicking or producing runtime errors. In the given example, calling hello with the slice array [1, 2] should execute the loop successfully.
needed for #2473
Bug
The application panicked (crashed).
Message:  Non-numeric type variable used in expression expecting a value: NotConstant
Location: crates/noirc_frontend/src/monomorphization/mod.rs:630

This is a bug. We may have already fixed this in newer versions of Nargo so try searching for similar issues at https://github.com/noir-lang/noir/issues/.
If there isn't an open issue for this bug, consider opening one at https://github.com/noir-lang/noir/issues/new?labels=bug&template=bug_report.yml

To Reproduce

nargo execute

Installation Method
Compiled from source
Nargo Version
No response
Additional Context
No response
Would you like to submit a PR for this Issue?
No
Support Needs
No response

This is an interesting one. The N in hello takes its value from the length of an array type, but in the case of slices there is no length. Instead the internal value NotConstant used to mark slices is leaked. Not sure what the fix here would be. This may need to be a compiler error of some kind.

Is this functionality actually required for the linked PR? hello could be rewritten as:
fn hello<N>(array: [u1; N]) {
    for i in 0..array.len() {}
}

@jfecher, doesn't work in this case
error: Could not determine loop bound at compile-time
    ┌─ std/ec/tecurve.nr:343:20
    │
343 │             for i in 0..bits.len() {
    │                    ----------
    │
    = Call stack:
      1. noir/crates/nargo_cli/tests/execution_success/eddsa/src/main.nr:51:17
      2. std/eddsa.nr:68:45
      3. std/ec/tecurve.nr:141:13
      4. std/ec/tecurve.nr:356:13
      5. std/ec/tecurve.nr:343:25

@f01dab1e looks like a different case in the tecurve test. I'm assuming you've modified the test since it passes locally for me. The "Could not determine loop bound at compile-time" error is intended for when a value derived from an input to main is used as a loop bound. I'm not sure why that'd be the case for an array length though, unless the array was a slice returned from an unconstrained function.

Reassigning to @michaeljklein, this is part of #4220

@michaeljklein Can we confirm whether we can close this?

@vezenovm yes, adding a regression test here: https://github.com/noir-lang/noir/pull/4602
Noting that there were two issues in the test case:

2 : u1

I've removed this for the purpose of the regression test

Non-numeric type variable used in expression expecting a value

NotConstant has been removed with the array/slice separation

Noting that there were two issues in the test case:

2 : u1

I've removed this for the purpose of the regression test

We used to support the u1 integer type when this issue was written, so updating the regression that way is the right move.


Devise omniauth_path_prefix overriden

Can you tell me where this route redirects ?
/api/auth/:provider
in rake routes :
GET       /api/auth/:provider(.:format)                                                             redirect(301)

I found it, but can you tell me why this line in 'lib/devise_token_auth/engine.rb' ?
 ::OmniAuth::config.path_prefix = Devise.omniauth_path_prefix = self.omniauth_prefix
It makes Devise.omniauth_path_prefix being overriden and when working with Devise + devise_token_auth getting conflicts when using omniauth

Hi there @vdruon    ,
In an effort to cleanup this project and prioritize a bit, we're marking issues that haven't had any activity in a while with a "close-in-7-days" label. If we don't hear from you in about a week, we'll be closing this issue. Obviously feel free to re-open it at any time if it's the right time or this was done in error!
If you are still having the issue (especially if it's a bug report) please refer to our new Issue Template to provide some more details to help us solve it.
Hope all is well.


💬 Change "fake results" to "zeroes"

Codecov Report

Merging #43 (a748309) into main (f4ee735) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #43   +/-   ##
=======================================
  Coverage   99.29%   99.29%
=======================================
  Files           3        3
  Lines         142      142
=======================================
  Hits          141      141
  Misses          1        1

Impacted Files
Coverage Δ

src/main.py
98.94% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4ee735...a748309. Read the comment docs.


[investigations] Prove status-flag checking functions and separate out some logic

Factor out proofs that have to do with state machines in general, or while loops in general, into StateMachineProperties.v and WhileProperties.v respectively, to declutter AesProperties.v
Fix a mistake in is_flag_set definition that meant the boolean was reversed
Implement and prove aes_idle, aes_data_ready, and aes_data_valid functions from aes.c

Lgtm! Out of interest, did you catch the flipped is_flag_set by eye or failing proof goal?

Failing proof goal. It's difficult to prove things that are false!


Please correct spelling of 'Identify'

You had it spelled wrong. Quoting the whole paragraph for easy search.
"A credential can be created for an EKM provider and mapped to a login (both Windows and SQL Server accounts) to access an EKM module on per-login basis. The Identify field of the credential contains the username; the secret field contains a password to connect to an EKM module."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: be1f2c05-a6cd-c645-3328-f3a2dfaaf6a6
Version Independent ID: c71aae83-1916-738d-a2dd-0c3917f86551
Content: Extensible Key Management (EKM) - SQL Server
Content Source: docs/relational-databases/security/encryption/extensible-key-management-ekm.md
Product: sql
Technology: security
GitHub Login: @jaszymas
Microsoft Alias: jaszymas

@jgmreyes -- thank you for catching that.  I am looking into this article.

Thank you for your feedback.  I have updated the documentation and it should be live by tomorrow.


map_test: Don't test order of map entries

Stop testing the order of map NextKey() / Iterate() values, as the
kernel now randomizes the seed, yielding non-deterministic results.
Regardless, testing the order of HashMap keys was always going to need a
fair share of luck.

Codecov Report

Merging #84 into master will decrease coverage by 0.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
- Coverage   58.66%   58.39%   -0.28%
==========================================
  Files          24       24
  Lines        1841     1841
==========================================
- Hits         1080     1075       -5
- Misses        596      601       +5
  Partials      165      165

Impacted Files
Coverage Δ

marshalers.go
60.86% <0%> (-4.35%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b135e6...42b973b. Read the comment docs.


Possible to check deposits

Hi. I used this and didn't get any info on deposits.
Is that info, in principle, available? Could it be implemented?

Same thing than with https://github.com/bankscrap/bankscrap-bbva/issues/4. @raulmarcosl do you have any deposit on ING?
@ivanperez-keera by the way, did you test this adapter with a ING bank account from some country other than Spain? So far we only tested it with Spanish accounts so it would be nice to confirm it works with other countries.

I have not tested the ING adapter with accounts in countries other than Spain, no.
I have a deposit. If this is implemented, I can test it.


Move to a distance from a tag

Knowing the id of a tag (or tags) and the distance we want to be away from it, we should be able to move to that tag quickly and reliably.
A version of this has been implemented in ChaseTag.java in the 2023RobotCode repository (commit 88d75b1).

This is not something under the Jetson's control. This feature will be addressed on the RoboRio; see https://github.com/PIE-Cubed/2023Code.


Ability to import Acteur (imported one)

Check only 1 source of acteur at once is updated
Inactive the Acteur for the same source
To be fix :

[ ] limit number of rows for import and export doesn't seems to work well

To be handled :

[ ] How handle partial or incremental import
[ ] How handle large dataset
[ ] Do we want to skip validation error when deactivate an acteur
[ ] How handle a semi-manual validation of this import
[ ] How follow data were recently imported even if there isn't any update
[ ] How handle the client file format

too old


ManagedSeed sets debugging.*=false

How to categorize this issue?

/area dev-productivity ops-productivity
/kind bug
What happened:
When creating a simple ManagedSeed object like this
apiVersion: seedmanagement.gardener.cloud/v1alpha1
kind: ManagedSeed
metadata:
  name: gcp
  namespace: garden # Must be garden
spec:
  shoot:
    name: seed-gcp
  gardenlet: {}

the newly added debugging fields (see https://github.com/gardener/gardener/issues/4567, https://github.com/gardener/gardener/pull/4568) in the gardenlet config will be set to false,false:
apiVersion: seedmanagement.gardener.cloud/v1alpha1
kind: ManagedSeed
metadata:
  name: gcp
  namespace: garden
spec:
  gardenlet:
    config:
      apiVersion: gardenlet.config.gardener.cloud/v1alpha1
      debugging:
        enableContentionProfiling: false
        enableProfiling: false
      kind: GardenletConfiguration
# ...
    mergeWithParent: true
  shoot:
    name: seed-gcp

Because of this, the gardenlet that is deployed for the ManagedSeed will be configured with profiling handlers disabled even though the parent gardenlet has profiling handlers enabled and mergeWithParent=true.
Config of parent gardenlet:
debugging:
  enableProfiling: true
  enableContentionProfiling: true

Config of ManagedSeed gardenlet:
debugging:
  enableProfiling: false
  enableContentionProfiling: false

What you expected to happen:
I expected that if I create a ManagedSeed object without setting the debugging fields, the settings in the parent gardenlet are propagated down to the child gardenlet.
Environment:

Gardener version: v1.31.0

In the versioned gardenlet config API, debugging.* are pointers:
https://github.com/gardener/gardener/blob/862c77153f92be4f9ab8d039d2751f630539ef90/pkg/gardenlet/apis/config/v1alpha1/types.go#L66-L67
https://github.com/gardener/gardener/blob/06242c99ecebf7442021acbb14a895eca27f7f78/vendor/k8s.io/component-base/config/v1alpha1/types.go#L60-L66
However, in the internal gardenlet config API, debugging.* are bools:
https://github.com/gardener/gardener/blob/862c77153f92be4f9ab8d039d2751f630539ef90/pkg/gardenlet/apis/config/types.go#L55-L56
https://github.com/gardener/gardener/blob/6806495376b1de8b760b10cf5bc5cf9445f30b06/vendor/k8s.io/component-base/config/types.go#L74-L80
This API design brings up problems when converting spec.gardenlet.config back and forth in the ManagedSeed admission plugin (I missed this scenario in https://github.com/gardener/gardener/pull/4568#discussion_r701893959)
When converting to internal here the nil bool pointers are converted to false.
When converting back to v1alpha here, the false values are converted to *false, which will then be persisted in the store in the resulting ManagedSeed object.

To summarize: the problem is that the internal config API doesn't have pointers and that the API server touches the config in its admission plugins.

I see two options for resolving out this situation:

either we fix it via the API

add pointers to debugging in the internal and external gardenlet config API
ensure proper conversion between the API versions
as discussed in https://github.com/gardener/gardener/pull/4568#discussion_r701973036, we are lacking a proper guideline / general approach on such decisions, so we missed this point (but this is probably a good lesson to add to such a guide)

or we fix it in the ManagedSeed admission plugin (like in this WIP: 309549866bab9390fa547833591f8c56f516bf3d)

we are only interested in the seedConfig in the internal version
so we can only do a back and forth conversion for that part only, but not for the entire gardenlet config
this results in debugging: {} when leaving out the fields on creation, which results in the expected behavior (don't know why it's not left out though)

I'm looking for opinions here :)

I would vote for the first option (fix via the API). From my perspective the fact that converting between internal and external versions results in different objects is already a problem that should be avoided. I think we would have it with other types from component-base/config as well (e.g. LeaderElectionConfiguration) except that they are always used as pointers. Also, Debugging is currently the only optional field that is not a pointer (and not marked as optional) in the gardenlet config, so also from consistency reasons it should be changed. I proposed this already in https://github.com/gardener/gardener/pull/4568#discussion_r701893959 but didn't insist on it since I was of course also not able to foresee this particular issue.
I don't have any particular issue with the second proposal, I guess it would work as well. I don't think however that the current approach is conceptually wrong - it converts an external type to an internal one and then back to external, an operation that one would normally expect to result in identical objects (except for the changed introduced by the plugin itself). So I see the proposed fix more as a workaround - although of course an acceptable one if there is a strong reason to avoid the first option (but I don't see one).

Thanks for your input, @stoyanr.

I don't think however that the current approach is conceptually wrong - it converts an external type to an internal one and then back to external, an operation that one would normally expect to result in identical objects (except for the changed introduced by the plugin itself). So I see the proposed fix more as a workaround

Yeah, I get your point.
Then, let me correct my point from above: probably the conceptual problem is rather, that these component config APIs were never thought to be persisted on the API server (where they are converted back and forth) or included as RawExtensions in other objects.
So we should improve how we include them in our gardenlet config API that ens up in the ManagedSeed and add a pointer (option 1).
I agree with you that option 2 is actually rather a workaround.
I will proceed with option 1. Thanks again for your opinion :)


Update New Alert and PW Weekly date and editor's blocks

 PW weekly & PW/PFW New Issue Alert Template Updates


use retransmissions as TLP packets

Fixes #1452. Depends on #1468.

Codecov Report

Merging #1470 into master will decrease coverage by <.01%.
The diff coverage is 60.71%.

@@            Coverage Diff             @@
##           master    #1470      +/-   ##
==========================================
- Coverage   89.19%   89.19%   -<.01%
==========================================
  Files         121      121
  Lines        8496     8494       -2
==========================================
- Hits         7578     7576       -2
  Misses        615      615
  Partials      303      303

Impacted Files
Coverage Δ

internal/ackhandler/sent_packet_handler.go
80.12% <50%> (-0.58%)
:arrow_down:

session.go
71.72% <65%> (+0.31%)
:arrow_up:

client.go
83.56% <0%> (-0.17%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90e8d6c...f92fc48. Read the comment docs.


chore: Remove duplicate Twitter og:image

resolves #3358

Thanks for fixing it @harishcalvin 🎉

Thank you @harishcalvin! ❤


Adding verif manual-11

Adding the example vm-11 (fee78aa)

Small changes:

Fix the problem with vm-006 (use of a string instead of a variable) (f12c9f6)
Fix vm-12 name in the index to unify all the elements (dbeee3a)

Linked to  #94

@Gryfenfer97
Regarding tox. It should be done in a different PR. Please do cherry commit those changes to another branch and do a PR.
Also, did you have a look at this? https://stackoverflow.com/questions/62412424/auto-chose-platform-or-other-condition-in-tox-sections


Bug: Clicking on the network config gear multiple times creates multiple network-config screens

Describe the bug
Clicking on the gear icon in the header multiple times creates multiple network config screens.
Expected behavior would be for a second click to hide the already displayed network config screen. This is a minor bug.
To Reproduce

Click on the gear icon in the network row of the header
Click it again
Click "X" icon to dismiss network config screen
An additional network config screen remains after the first has been dismissed

Expected behavior
Dismissing the network config screen once should toggle it off.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: macOS
Browser: Chrome

Additional context
Potential solution - instead of navigating here (https://github.com/paradigmxyz/rivet/blob/main/src/components/Header.tsx#L273), could check first whether it is displayed and go back in history if gear is clicked again.

Fixed!


"Deploy" misleading

the deploy button should indicate that we just send data to argo to do the actual deployment
maybe also indicate how long it takes

Source: Discussion with @qr4


[Box] Box - defaultTheme undefined when running tests

Trying to test the @material-ui/core/Box component

[x] This is not a v0.x issue.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔
Basically, I expect to be able to use the Box under test environments (JEST snapshot testing, storybook, or just unit test inside material-ui)
Current Behavior 😯
If you run a test which creates an instance of Box component it breaks

/Users/apanizo/git/aptlabs/material-ui/packages/material-ui-styles/src/getStylesCreator/getStylesCreator.js:40
      if (!name || !theme.overrides || !theme.overrides[name]) {
                          ^

TypeError: Cannot read property 'overrides' of undefined
    at Object.overrides [as create] (/Users/apanizo/git/aptlabs/material-ui/packages/material-ui-styles/src/getStylesCreator/getStylesCreator.js:38:27)
    at create (/Users/apanizo/git/aptlabs/material-ui/packages/material-ui-styles/src/withStyles/withStyles.js:78:34)
    at componentCreator (/Users/apanizo/git/aptlabs/material-ui/packages/material-ui-styles/src/styled/styled.js:111:12)
    at Object.<anonymous> (/Users/apanizo/git/aptlabs/material-ui/packages/material-ui/src/Box/Box.js:32:13)

Steps to Reproduce 🕹
Basically, I have created a PR https://github.com/apanizo/material-ui/pull/1/files, if you remove the defaultTheme in the Box.js component, and you run the provided test you will see the error.
I think this is pretty easy to reproduce but if you guys need a codesandbox let me know.
Context 🔦
I am running e2e, plus JEST snapshots againts Box component and I constantly get this error. At the end I solved the problem by just configuring the setupTests in my CRA:
window.disableShallowSupport = true;
The error is caused because the defaultTheme from options is undefined, because the Box component uses the styled function from material-ui-styles package, and do not use this one, and therefore when running withStyles function, defaultTheme is undefined which causes later the error.
I have not created directly the PR agains this repo becuase I wanted to have more feedback about this issue. Also you might want me to write more tests or do something else.
Happy to help here.
Your Environment 🌎

Tech
Version

Material-UI
4.0.0-alpha.4

Can confirm the bug, just happened to me.
Also, I can confirm the fix by @apanizo . Good work, thanks.

Looks like we just have to import styled from @material-ui/core/styles to get the default theme for material-ui. /cc @oliviertassinari

Guys! Thanks for getting back to me so fast! You guys are doing an incredible job!
@eps1lon I thought about it and did not implement your solution in my PR because, unless I am wrong, the core/styles package will be deprecated (I think I read it somewhere), right?

Guys! Thanks for getting back to me so fast! You guys are doing an incredible job!
@eps1lon I thought about it and did not implement your solution in my PR because, unless I am wrong, the core/styles package will be deprecated (I think I read it somewhere), right?

That was the original plan but they are kept since they include the default theme. This allows you to import core components without having to wrap your tree in a theme provider.
@material-ui/styles -> fully generic. can be used outside of Material-UI
@material-ui/core/styles -> includes Material-UI theming
Think of @material-ui/core/styles as @material-ui/theme or @material-ui/themed. Maybe that helps understand the distinction.
The current implementation of Box uses @material-ui/styles and therefore needs to be in a tree with the theme provider. We don't want to add that requirement therefore it's a bug. It should use @material-ui/core/styles.
Hope I got this right /cc @oliviertassinari

@eps1lon good explanation. Once @oliviertassinari gives thumbs up, I will update my PR and redirect
it to the main repo.

@eps1lon Is right, the Box doesn't have any default theme. We should change the import.


Contents of "Table of Contents" overlap with each other when line spacing is less than 1.

Describe the bug
Contents of "Table of Contents" overlap with each other when line spacing is less than 1.
To reproduce
Steps to reproduce the behavior:

Go to Preferences.
Turn on the table of contents.
Reduce the line spacing to some number less than 0.9
See error

Expected behavior
The different points in the table of contents should not overlap when line spacing is decreased.
Screenshots

Technical details
Desktop

OS: Ubuntu 18.04
Browser: Chrome
Version: 80.0.3987.122 (Official Build) (64-bit)

Additional context or notes
A temporary solution to this problem would be to place a cap on the minimum value of line spacing.

@jobara, @jhung, I had a doubt regarding the span of values that different UI options are providing for line spacing. In the UI Options Demo and floe project website, the line spacing values from 0.7 to 1 cause the list of elements in the table of contents to overlap ( issue described in fluid-project/floeproject.org#110). However, this issue has been solved by placing a cap on line spacing values in the feedback demo where it was solved by keeping the values of line spacing between 1 and 2. Does that mean that fluid-project/floeproject.org#110 can be solved by putting a cap on line spacing values so that it's value doesn't go below 1?

@sachin10101998 it's probably that they are using different versions of UI Options. The newer versions supports a broader range. That doesn't mean we can't/shouldn't adjust the range for this particular site. I suppose it depends on what is reasonable to support on the site while allowing a user to customize the sites to meet their own needs and preferences.

this issue seems related to https://github.com/fluid-project/floeproject.org/issues/108

Yes @jobara , both issues can be solved by this:
.floe-content.floe-story a { display:inline-block; }

@sachin10101998 We will look at this in the redesign— thanks for reporting!


Broke out many helper methods inside of DefaultRavenFactory to al…

…low for easier overrides.

Ready for review.


[Issue] Figure out a good alternate extension to Docker desktop

Some devs won't have docker desktop, so let's figure out an alternative recommendation.

@jongio can we use this issue #509 for tracking the same and close this one?

That one is about docker build only.  We should figure out all the dependencies on docker and see what can be replaced by what and then decide.

The most commonly used alternative is Podman, but there are others (e.g. nerdctl). There is also more and more options for building container images directly via programming language-specific build tool, e.g. dotnet just got one recently: https://devblogs.microsoft.com/dotnet/announcing-builtin-container-support-for-the-dotnet-sdk/
Ultimately we might want to tread container build as extensibility point.


jnp.take_along_axis has wrong semantics for zero-sized arrays

import jax.numpy as jnp
import numpy as np

w = np.empty((0, 0))
i = np.ones((1, 1), dtype=int)

out = np.take_along_axis(w, i, axis=-1)
print(out.shape)
# (0, 1)

jnp.take_along_axis(w, i, axis=-1)
# TypeError: Slice size at index 1 in gather op is out of range, must be within [0, 0 + 1), got 1.

I discovered this via an error in jnp.linalg.svd on an empty matrix:
import jax.numpy as jnp
jnp.linalg.svd(jnp.zeros((0, 0)), compute_uv=True, hermitian=True)
# TypeError: Slice size at index 1 in gather op is out of range, must be within [0, 0 + 1), got 1.

I'm trying to understand if NumPy's behavior here is intentional or a bug. Doesn't the return value of NumPy not even match its own API contract here? I would have expected an error from NumPy also.

It's a bit strange, but I think it does match the numpy contract because the indices are broadcast (and can be broadcast to zero). This might make the behavior more clear:
import numpy as np

for wshape in [(0, 0), (5, 5)]:
  w = np.empty(wshape)
  i = np.ones((1, 1), dtype=int)
  i_broadcasted = np.broadcast_to(i, (w.shape[0], i.shape[1]))
  print(w.shape, i.shape, i_broadcasted.shape)

  out_implicit_broadcast = np.take_along_axis(w, i, axis=-1)
  out_explicit_broadcast = np.take_along_axis(w, i_broadcasted, axis=-1)
  print(np.allclose(out_implicit_broadcast, out_explicit_broadcast), '\n')

(0, 0) (1, 1) (0, 1)
True

(5, 5) (1, 1) (5, 1)
True

It seems like this has been fixed - I can no longer reproduce the issue.


Don't clear pinned columns after 'fetching connection data'

tried this and it didn't clear the data
please specify


Refactor GRPC Wallet service

With the recent changes to the consensus/chain, the wallet is loaded directly on startup, instead of through the CLI wallet. This means that the service will need to remove some functionality, as it is no longer concerned with this behavior.

This issue should have been filed under dusk-protobuf, and is thus obsolete. The new issue can be found here.


Cant figure out how to install wrapper

I cant seem to figure out how to install the Razer wrapper so I can use the chroma apps in aurora

Go to Settings and then Devices & Wrappers. Clicking "Install Aurora Wrapper Patch for Razer" will allow you to browse to the directory where the wrapper should be installed (i.e. directory of a chroma app)


Cannot evaluate module RNMaterialKit

I ran command react-native run-android and got an issue like this:

Would you please tell me how to fix that?

+1 same problem

the react-native run-android should surely work, please follow the Getting started guide

+1 me too

+1

Please read the Getting Started guide, it explains how to link the module both on Android and iOS


How to get txHash after "signTransaction()"?

ethereum github Add 'txHash' field to the result of 'accounts.signTransaction';
And i can get txhash before sendTranasction() with go-ethereum sdk.
i want know how to get txhash with web3dart before sendTransaction(), thanks

@ddswez You cannot get the txHash before a transaction is submitted via sendTransaction(). The transaction hash is provided by the network after a transaction is submitted. Therefore, you must send the transaction in order to attain this information


Fixes #1369

The get method should return null instead of throwing a NullPointerException
Fixes #1369

Good first contribution, thank you a lot. Kudos!


Added Puppet-omd Module with its Dependency

Have added Puppet-Omd module.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

You need to add only the changed files. You have added all the modules.


[MINOR] Beautify the cli banner

What is the purpose of the pull request
Beautify the cli banner
Old banner

New banner

Brief change log

Beautify the cli banner

Verify this pull request
This pull request is code cleanup without any test coverage.
Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[x] Commit message is descriptive of the change

[x] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Just one more additional ask if i may :) replace "Hoodie" with "Apache Hudi" on the output text in the CLI ? (not the classes, code, methods.. just output text)..
Looks great otherwise !

Hi, @vinothchandar , it's easy to replace "Hoodie" with "Apache Hudi", I have a question that do we need "Apache Hudi" with "Hoodie" in the futuer?

Just one more additional ask if i may :) replace "Hoodie" with "Apache Hudi" on the output text in the CLI ? (not the classes, code, methods.. just output text)..
Looks great otherwise !

Done, 😄 😄 😄


Load all TUI views on mount to pre-load cache

Codecov Report

Merging #176 (c391a74) into main (a14b08e) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
- Coverage   91.93%   91.82%   -0.12%
==========================================
  Files          10       10
  Lines         831      832       +1
==========================================
  Hits          764      764
- Misses         67       68       +1

Impacted Files
Coverage Δ

weather_command/_tui.py
64.37% <0.00%> (-0.41%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a14b08e...c391a74. Read the comment docs.


Tutorial says failIfDataLoss: true should stop .drop function...

I noticed when running through your tutorial that in the section on pushing to prod you write that the push should fail due to there being a .drop function in the delta. I'm running on <IP_ADDRESS> and it does NOT fail. However, it fails when trying to push a .drop table.
To me this actually makes sense, but in that case I think the tutorial is wrong.

You're right.  The doc is wrong:  it protects only against the .drop that provokes data loss.
I'll fix the doc.  Thank you!

I altered the tutorial to show a failure on a drop table.


License Agrement

I see a reference to the license in the setup.py - but it would be in the interest of adoption that a License.txt file be added explicitly in the package clearly stating the license the code is available under.

Agreed. This is not obvious, and not everyone is okay with just whatever the license is. It's important.

@perenecabuto  Would you accept a PR that associated this project with the MIT license?

@jacobq, Sorry for this BIG delay. I just added an MIT license to the project.
Thanks for the contribution.


Fix big query schema bug

Jira ticket URL:
https://dfedigital.atlassian.net/browse/TEVA-494
Changes in this PR:

Convert dates to format supported by big query csv import

Resolved some conflicts in commit e69579e

Superseded by https://github.com/DFE-Digital/teacher-vacancy-service/pull/1342. Closing


Istio support for traffic shadow

Use case :
To support policy dark launch, Istio needs to support traffic shadow, which envoy already supported(see below links)
https://www.envoyproxy.io/docs/envoy/latest/api-v1/route_config/route.html#shadow
https://www.envoyproxy.io/docs/envoy/latest/api-v2/api/v2/route/route.proto.html?highlight=shadow
The purpose of doing policy dark launch is to test a new policy works as expected before making real impact on users. A dark launch sends a copy of real user-generated traffic to filters chain constructed from new policy, log/monitor generated attributes/metrics, and discards the result before it is returned to the user.

looks like Istio already supported traffic mirroring -
https://github.com/istio/api/blob/78da6e6eb4ad4f158fb58e02f94efde4abf4cabf/networking/v1alpha3/virtual_service.proto#L361
https://github.com/istio/istio.github.io/blob/master/_docs/tasks/traffic-management-v1alpha3/mirroring.md

tried mirroring sample, basically it works(need a small update on the instruction), so close this issue.


WPT tests for channel in script.addLoadScript

WPT tests for channel were added here by Mozilla folks: https://github.com/web-platform-tests/wpt/pull/39644


Acme Thread fails

  acme = AcmeThread(size="1/4", length=1 * IN) results in:
File "/home/nathaniel/projects/gardenia/.venv/lib/python3.12/site-packages/bd_warehouse/thread.py", line 743, in init
super().init(
File "/home/nathaniel/projects/gardenia/.venv/lib/python3.12/site-packages/bd_warehouse/thread.py", line 605, in init
self.lead = pitch * starts
^~
TypeError: can't multiply sequence by non-int of type 'float'

The problem is that the TrapezoidalThread class has a new starts parameter which isn't being set correctly.

Fixed with commit 53a69f7ba925596ed8d627e7e38cd49f8ff03ffb


Add netcat to vswitch container to run vpptrace.sh

This is necessary when running vpptrace.sh from sosreport

Coverage increased (+0.3%) to 77.005% when pulling 814183bfe8ca7eb04927ea65c6277b6b6093730c on nbartos:netcat into 3f78ee4e33b35f9dc9e207de12aa7326698a0cb9 on contiv:master.


add Filter operation

Make sure that you've checked the boxes below before you submit PR that adds a new operation:

[ ] I implemented the operation for all applicable types
[ ] I put all code in a seperate .go file named after the operation
[ ] I included tests for all functions
[ ] I documented all functions
[ ] I named all functions using the OperationType convention. For example MinInt32 instead of Int32Min
[ ] I included one testable example at the end of the test file
[ ] I added a simple example in the Example section of Readme
[ ] I updated the Operations section of Readme

Thanks for your PR, you're awesome! :+1:

Codecov Report

Merging #14 into master will decrease coverage by 2.33%.
The diff coverage is 89.47%.

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
- Coverage     100%   97.66%   -2.34%
==========================================
  Files           4        5       +1
  Lines         601      772     +171
==========================================
+ Hits          601      754     +153
- Misses          0       18      +18

Flag
Coverage Δ

#unittests
97.66% <89.47%> (-2.34%)
:arrow_down:

Impacted Files
Coverage Δ

filter.go
89.47% <89.47%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73d7a0b...ba08038. Read the comment docs.