x/tools/gopls: CL 186297 appears to break -rpc.trace log output

What version of Go are you using (go version)?

$ go version
go version go1.12.7 linux/amd64
$ go list -m golang.org/x/tools
golang.org/x/tools v0.0.0-20190716194406-502543d2eda9
$ go list -m golang.org/x/tools/gopls
golang.org/x/tools/gopls v0.1.4-0.20190716194406-502543d2eda9

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/myitcv/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/myitcv/gostuff"
GOPROXY=""
GORACE=""
GOROOT="/home/myitcv/gos"
GOTMPDIR=""
GOTOOLDIR="/home/myitcv/gos/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/myitcv/gostuff/src/github.com/myitcv/govim/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build039610249=/tmp/go-build -gno-record-gcc-switches"

What did you do?
Somewhere in/around CL 186297 the output from -rpc.trace got broken.
Before:
[Trace - 4:18:52 PM] Sending notification 'initialized' in 70ms.
Params: {}

[Trace - 4:18:52 PM] Sending notification 'textDocument/didOpen' in 45ms.
Params: {"textDocument":{"uri":"file:///tmp/go-test-script854779031/script-function_hover/main.go","languageId":"go","version":0,"text":"package main\n\nimport \"fmt\"\n

[Trace - 4:18:52 PM] Received notification 'window/logMessage' in 0ms.
Params: {"type":4,"message":"packages.Load: found 1 packages"}

[Trace - 4:18:52 PM] Received notification 'window/logMessage' in 0ms.
Params: {"type":4,"message":"packages.Load: package mod.com with files [/tmp/go-test-script854779031/script-function_hover/main.go]"}

[Trace - 4:18:52 PM] Received response 'textDocument/hover - (2)' in 0ms.
Params: {"contents":{"kind":"plaintext","value":"func fmt.Println(a ...interface{}) (n int, err error)"},"range":{"start":{"line":5,"character":5},"end":{"line":5,"chara

[Trace - 4:18:52 PM] Sending notification 'textDocument/hover' in 277ms.
Params: {"textDocument":{"uri":"file:///tmp/go-test-script854779031/script-function_hover/main.go"},"position":{"line":5,"character":5}}

[Trace - 4:18:52 PM] Received notification 'textDocument/publishDiagnostics' in 0ms.
Params: {"uri":"file:///tmp/go-test-script854779031/script-function_hover/main.go","diagnostics":[]}

[Trace - 4:18:52 PM] Received response 'shutdown - (3)' in 0ms.
Params: {}

[Trace - 4:18:52 PM] Sending notification 'shutdown' in 0ms.
Params: {}

After:
[Trace - 4:17:39 PM] Sending notification '???' in<PHONE_NUMBER>854ms.
Params: {}

[Trace - 4:17:39 PM] Sending notification '???' in<PHONE_NUMBER>854ms.
Params: {}

[Trace - 4:17:39 PM] Sending notification '???' in<PHONE_NUMBER>854ms.
Params: {}

[Trace - 4:17:39 PM] Sending notification '???' in<PHONE_NUMBER>854ms.
Params: {}

[Trace - 4:17:39 PM] Sending notification '???' in<PHONE_NUMBER>854ms.
Params: {}

[Trace - 4:17:39 PM] Received response '??? - (2)' in 0ms.
Params: {"contents":{"kind":"plaintext","value":"func fmt.Println(a ...interface{}) (n int, err error)"},"range":{"start":{"line":5,"character":5},"end":{"line":5,"character":12}}}

[Trace - 4:17:39 PM] Sending notification '???' in<PHONE_NUMBER>854ms.
Params: {}

[Trace - 4:17:39 PM] Sending notification '???' in<PHONE_NUMBER>854ms.
Params: {}

[Trace - 4:17:39 PM] Received response '??? - (3)' in 0ms.
Params: {}

[Trace - 4:17:39 PM] Sending notification '???' in<PHONE_NUMBER>854ms.
Params: {}

What did you expect to see?
The "before" log output
What did you see instead?
The "after" log output

cc @stamblerre @ianthehat

The ??? is used as the method name when it is not stored on the context, but I have no idea why it would not be.
I did see a similar error when I was changing all the telementry code, but I fixed it, and saw working logs before I turned them off again.

Also, I just checked and it is working for me at master.
Maybe try with debug pages turned on, there might be some weird interaction where the telementry stuff turns off too much without that?

I just tried starting gopls via:
gopls -rpc.trace -logfile /tmp/gopls_log serve --debug=localhost:6060

and saw the same thing in /tmp/gopls_log, i.e. the ???. So for me this appears broken.

Strange; this is working in some situations, but not others. I'll try and "bisect" what's causing things to fail.

@myitcv: Have you continued to encounter this issue?

Very strange. At least with 6d4652c779c4 I'm not seeing this. Will close for now.


Sharing custom modules configuration

It would be great to have a central place to share config tips & trics and/or dotfiles. What is the preferred way to do so ?

The wiki ?
A folder with samples ?
A third party website ?

I think a wiki page would be a good way to do it. I just added a wiki page to post examples: link Feel free to add yours! I think it works well, the only issue being that statusbars are kindof a weird dimension so its a little hard to see the images :man_shrugging:

You can add your custom module here /resources/custom_modules :smiley:
And yeah it's great to add your bar settings to the wiki :heart:


[e2e]: generic tag branch1 default slsa3

Repo: https://github.com/slsa-framework/example-package/tree/v22.0.100
Run: https://github.com/slsa-framework/example-package/actions/runs/3087390368
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.tag.branch1.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.tag.branch1.default.slsa3.yml
Trigger: push
Branch: v22.0.100
Date: Tue Sep 20 04:25:02 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/v22.0.101
Run: https://github.com/slsa-framework/example-package/actions/runs/3095175165
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.tag.branch1.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.tag.branch1.default.slsa3.yml
Trigger: push
Branch: v22.0.101
Date: Wed Sep 21 04:32:33 UTC 2022
Tests are passing now. Closing this issue.


[nfc] remove off-by-default bench tag

bazel doesn't build/run it otherwise. It doesn't hurt if there's none, since run target are not run by bazel test.

If we remove the tag, this will be included in bazel build //..., which builds all targets (but does not run tests), causing all benchmarks to be built and run on CI as bazel build //... is the first CI build step and building the csv output file causes the benchmark to be run. This could be avoided by adding --build_tests_only, but that might also end up not building things that we want to be built (e.g. the api_encoder, which is not a dependency of any tests but we still want to be able to see if any ).
Running benchmarks on CI by default is something we can do, but it merits prior discussion.

If we remove the tag, this will be included in bazel build //..., which builds all targets (but does not run tests), causing all benchmarks to be built and run on CI as bazel build //... is the first CI build step and building the csv output file causes the benchmark to be run. This could be avoided by adding --build_tests_only, but that might also end up not building things that we want to be built (e.g. the api_encoder, which is not a dependency of any tests but we still want to be able to see if any ). Running benchmarks on CI by default is something we can do, but it merits prior discussion.

hm... My thinking was that "off-by-default" on csv will still prevent us from generating csv on CI. If I take a look into build logs I don't see any evidence of us running benchmarks either.
building benchmarks during CI is actually a good thing, we don't wan't them to be stale.


Fix typo

Github -> GitHub

Learn Build status updates of commit d59c4c1:
:bulb: Validation status: suggestions

File
Status
Preview URL
Details

articles/iot-hub-device-update/delta-updates.md
:bulb:Suggestion

Details

articles/iot-hub-device-update/delta-updates.md

Line 83, Column 370: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/nuget/' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Looks good; thanks, @changeworld


epic: Cortex API testing strategy (postman templates)

Goal

Re-use a lot of OpenAI API stuff = postman templates

Shared with Tin


Change DiPhoton Sample for 80-inf

Currently used sample-
/DiPhotonJetsBox_MGG-80toInf_13TeV-sherpa/RunIISummer20UL16NanoAODAPVv9-106X_mcRun2_asymptotic_preVFP_v11-v2/NANOAODSIM
To be replaced by-
https://cms-pdmv.cern.ch/grasp/samples?dataset_query=DiPhotonJets_MGG-80toInf_TuneCP5_13TeV-amcatnloFXFX-pythia8&campaign=Run3Summer22*GS,Run3Winter22*GS,Run3Winter23*GS,RunIISummer20UL16*GEN,RunIISummer20UL16*GENAPV,RunIISummer20UL17*GEN,RunIISummer20UL18*GEN&nanoaod_version=v9

Added to DAS Sample list


Implement Terminal Link Handler

Very often, the terminal is used to spawn a dev http server (nextjs and webpack do this):

It would be nice if the edge webview would open when clicking on the url.
Extensions can override the link click behavior by using registerTerminalLinkProvider.
However, I suggest to not do this by default, until https://github.com/microsoft/vscode/issues/200579 lands: Rather, VS Code should ask the user if they want to use the OS browser or edge dev tools or the simple browser that ships with VS Code.
For now, the extension could add a setting that would control if it registers a terminal link provider.
This optional feature would then push us to implement https://github.com/microsoft/vscode/issues/200579.

Thanks for the suggestion!


Support s3_data_dir and s3_data_naming

What
This PR brings back https://github.com/dbt-athena/dbt-athena/pull/4 originally covered in https://github.com/Tomme/dbt-athena/pull/50
Compare to the original PR, this PR changes add the possibility to setup the s3_data_naming on the model config and fallback to the global target value. Also this change is not introducing breaking changes, as we should set data dir is optional and use the default staging dir as fallback.
I refactored also iceberg implementation to have the same beahvior, as before we created another way to store the data, this is more uniformed.
To test I setup this in my profile:
athena:
  target: dev
  outputs:
    dev:
      type: athena
      s3_staging_dir: s3://my_bucket/tmp/
      s3_data_dir: s3://my_bucket/
      s3_data_naming: schema_table
      region_name: eu-central-1
      schema: silver
      database: awsdatacatalog
      work_group: dbt_athena_v3
      num_retries: 1

Models used for testing
uuid
{{ config(
    materialized='table',
    s3_data_naming='uuid'
) }}

SELECT 'A' AS user_id, 'active' AS status, 'pi' AS name
UNION ALL
SELECT 'B' AS user_id, 'active' AS status, 'sh' AS name
UNION ALL
SELECT 'C' AS user_id, 'active' AS status, 'zh' AS name

the default table location was s3://my_bucket/a700e6ba-508b-4037-aa11-52239c3b6931
schema_table
{{ config(
    materialized='table',
    s3_data_naming='schema_table'
) }}

SELECT 'A' AS user_id, 'active' AS status, 'pi' AS name
UNION ALL
SELECT 'B' AS user_id, 'active' AS status, 'sh' AS name
UNION ALL
SELECT 'C' AS user_id, 'active' AS status, 'zh' AS name

the default table location was s3://my_bucket/my_schema/my_model
schema_table_unique
{{ config(
    materialized='table',
    s3_data_naming='schema_table_unique'
) }}

SELECT 'A' AS user_id, 'active' AS status, 'pi' AS name
UNION ALL
SELECT 'B' AS user_id, 'active' AS status, 'sh' AS name
UNION ALL
SELECT 'C' AS user_id, 'active' AS status, 'zh' AS name

the default table location was s3://my_bucket/my_schema/example/96e19633-6794-40fc-bbc6-28d99d43ab44
external_location
{{ config(
    materialized='table',
    external_location='s3://' + env_var('SILVER_S3_BUCKET') + '/custom_example/',
    s3_data_naming='schema_table_unique'
) }}

SELECT 'A' AS user_id, 'active' AS status, 'pi' AS name
UNION ALL
SELECT 'B' AS user_id, 'active' AS status, 'sh' AS name
UNION ALL
SELECT 'C' AS user_id, 'active' AS status, 'zh' AS name

the s3_data_naming is ignored and then the external location is used.
I also tested to don't set the s3_data_dir, and by default the staging_dir is used.

FYI @jessedobbelaere

For me, the location is coming up as s3://my_bucket/dbt/my_schemamymodel with no directory between schema and model.
dbt-athena-community          1.3.3
athena:
  outputs:
    dev:
      aws_profile_name: somethingfake
      database: awsdatacatalog
      region_name: us-west-2
      s3_data_dir: s3://my_bucket/dbt/
      s3_data_naming: schema_table
      s3_staging_dir: s3://my_staging_bucket/dbt/
      schema: my_schema
      type: athena
      work_group: somethingfake
      threads: 8
      num_retries: 1

@VDFaller there was no change on that section of the code between 1.3.2 and 1.3.3. I just tested with one of my testing models and seems working fine for me.
Could you share your model config??

None.  Just default.


HHH-15756 Table Value Constructor (INSERT, FROM column aliasing at table alias, CTE)

https://hibernate.atlassian.net/browse/HHH-15756

Superseded by https://github.com/hibernate/hibernate-orm/pull/7860


Update README.md

Fixed an error with the name of the js file. It should be d3.tip, not d3-tip

Yep. Please merge this @lorennorman


VSCode deleted my project when I launched debugging: terminal should have been cleared when starting a debug session

VS Code Version: 1.71.2
OS Version: Windows 11 + WSL 2 (Ubuntu 20.04)

VSCode deleted my project!
Steps to Reproduce:

Create a python project with this config        {
            "name": "Python: Current File",
            "type": "python",
            "request": "launch",
            "program": "${file}",
            "console": "integratedTerminal",
            "justMyCode": false
        },

Start typing something in the terminal, but do not press enter. Ex: rm -fr toto
Launch debug current file: it executes unwanted code. Ex:

**rm -fr toto cd /home/dev/projects/test**; /usr/bin/env /home/dev/projects/test/.venv/bin/python /home/dev/.vscode-server/extensions/ms-python.python-2022.14.0/pythonFiles/lib/python/debugpy/adapter/../../debugpy/launcher 33451 -- /home/dev/projects/test/patch_10_11.py

Debug always creates a new terminal - It looks like that would happen if you type your own command.
@meganrogge I create a terminal, and use sendText when I reuse it, is there a terminal escape code I can send that will clear the current line? I don't think I want to clear the whole thing.

@roblourens there is not, but you could do what we now do for run recent command when you have input and send the sequence for ctrl + c

That would work, what is that sequence?

https://github.com/microsoft/vscode/blob/244e4feb031f22c0e1582189e5850d8b5c9f0907/src/vs/workbench/contrib/terminal/browser/terminalRunRecentQuickPick.ts#L292

I believe it should not be on the users. You need to clear the terminal line before running the debug command. It's awful.

Duplicates https://github.com/microsoft/vscode/issues/106743


Pock not displaying / running (Followed all instructions)

Describe the bug
Pock does not display on my touch bar, even though i have followed all the installation instructions and 'opened' the app
How to reproduce
Just try to open the app
Expected behavior
Pock displays on my touch bar
Screenshots

Crashlog
No crash report is generated
Versions:

macOS version: 10.14.6
Pock version:  Latest (0.6)

Additional context
I have had 'BetterTouchTool' installed in the past but I have removed it fully incase it was conflicting with Pock

I am having this issue as well.

Does Pock icon appear in the Menu Bar?

Nope, nothing appears at all
On Mon, 30 Sep 2019 at 21:20, Pierluigi Galdi<EMAIL_ADDRESS>wrote:

Does Pock icon appear in the Menu Bar?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pigigaldi/Pock/issues/231?email_source=notifications&email_token=AFYWNRMCC4ZXNVBQYPV3KVTQMJNQTA5CNFSM4IWNYEQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD766WAY#issuecomment-536734467,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFYWNROHPFZFRTE3A2XIB4DQMJNQTANCNFSM4IWNYEQQ
.

Agreed. I am running 14.2 and have installed, fully removed, reinstalled Pock so many times. All settings are done as instructed but the app never runs


GROOVY-9893: STC: findSetters must look in super types

https://issues.apache.org/jira/browse/GROOVY-9893
There is still a strong preference for field-based properties over setter-only properties.  Mixed cases of "real" and "virtual" properties may not work the same as the test cases added below.

Merged. Thanks!

Merged. Thanks!


fix(curriculum): removed hyphens searching for topic from coding pages

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #54291
Here is an image after fixing the issue:

Removing hyphens was made using replace() combined with this regExp: /-/g

I saw that some check are failing (E2E - Web Browser Electron and Playwright webkit). Errors are referring to file I didn't touch so what should I do?


Minify_groupUri() doesn't notice changes in file inclusion/order

Originally reported on Google Code with ID 241
Paul Schwarz noticed that "while it does a good job of checking whether files have been
*modified* it makes no attempt to notice whether the group itself has been modified,
i.e. adding or removing sources from the group" (or re-ordered).

i.e. GroupUri needs to append a hash of the array of filesnames along w/ the max timestamp.
Here's what I recommend:
* always starts with "0" so RewriteRules doesn't need to change
* md5(serialize(array(filenames) + array(maxTimestamp)))
* output MD5 in base64 and strip +/=

Reported by mrclay.org on 2011-09-03 11:48:57

seems related: #28
so could be closed as duplicate of #41 ?


images: install Python kubernetes-validate in Ansible images

this allows usage of the validation feature in Ansible k8s module
Fixes #2433

Description of the change:
Motivation for the change:

Closing, as an additional dependency is not welcomed by the core team.


add free intro to programming book

What does this PR do?
Add free programming logic book in pt-br
For resources
Description
Why is this valuable (or not)?
Good introduction to programming logic ebook.
How do we know it's really free?
It's just free.
For book lists, is it a book? For course lists, is it a course? etc.
It's an e-book.
Checklist:

[X] Not a duplicate
[X] Included author(s) if appropriate
[X] Lists are in alphabetical order
[X] Needed indications added (PDF, access notes, under construction)

Thanks, and welcome to free-programming-books!


mddb sometimes chokes on accented characters within tags

Among my tags is Actionnable/Type/Tâche.
mddb indeed tried to insert it as a tag, but it also tried to insert Actionnable/Type/T as a tag, as can bee seen from this trace:
[Error: insert into `tags` (`name`) select 'Actionnable/Type/Activit' as `name`
union all select 'Actionnable/Type/Activité' as `name`
union all select 'Autodirection/Suivi_d_ex' as `name`
union all select 'Chronologie' as `name` ...
union all select 'Actionnable/Type/T' as `name`
union all select 'Actionnable/Priorit' as `name`
union all select 'actionable/objectif-mesurable' as `name`
union all select 'actionable/projet' as `name`
union all select 'projet' as `name`
union all select 'Priorit' as `name` ...
union all select 'AI' as `name` - SQLITE_ERROR: no such table: tags] {
  errno: 1,
  code: 'SQLITE_ERROR'
}

yet none of my files contain Actionnable/Type/T without the T being followed by âche:
> rg -g '*.md' 'Actionnable/Type/T' ~/Obsidian|wc -l
99
> rg -g '*.md' 'Actionnable/Type/T' ~/Obsidian|rg -v 'Actionnable/Type/Tâche'|wc -l
0

As you can see, mddb also chocked on the é from Actionnable/Priorité, the é from Priorité, and so on.

Fixed. markdownDB now correctly extracts characters for most language characters.


Rename ID to GlobalId

Mark IDAttribute obsolete and introduce GlobalIdAttribute
Mark .ID() extension methods obsolete and introduce .GlobalId()
Add Migration section

Closes #4001

@benmccallum @tobias-tengler  Looks good so far. Shall we keep the old IDAttribute as obsolete around? so that people do not get compile errors on update? We could remove the old ones with V13. Thoughts?

It's a major version, so just doing a rename should be fine. And the issues can be solved by doing a find and replace.
However, since it likely affects most of the type definitions of user's using this feature, I think marking it as obsolete would be the better option. I'll do the change tomorrow evening, if Ben doesn't object.

Fine with me. Go for it @tobias-tengler

Done!


Delta on Azure / Account key leak

azure_storage_account_key gets leaked on generating documentation with dbt docs generate
Value is shown in the details of tables when viewing the HTML documentation.
Here is my configuration following @milicevica23 's repo which is also mentionned in the README of this repo.
Just wondering if there is also a way to use managed identity in storage_options to connect just with my Active Directory identity?
profiles.yml
outputs:
    dev_duckdb:
      type: duckdb
      path: /tmp/my-local.duckdb
      plugins:
        - module: delta

sources.yml
- name: my_delta_source
    config:
      plugin: delta
    tables:
      - name: my_table
        meta:
          delta_table_path<EMAIL_ADDRESS>          storage_options:
            azure_storage_account_key: "{{ env_var('AZURE_STORAGE_ACCOUNT_KEY') }}"

~/.zshrc
export AZURE_STORAGE_ACCOUNT_KEY = "abcd"

Hey @mycaule -- you should use config instead of meta for secrets there-- they won't be included in the docs and things work the same way. Sorry about the confusion there, will update the docs to make "config" the default for stuff.

Re: managed storage options for Azure, is that similar to the AWS credentials chain? (Apologies I am not that familiar with Azure)

Thank you, yes there is a concept of DefaultAzureCredential() just like in AWS, and you can allow managed identities to access the Blob storage to avoid using any passwords.

Yes that sounds superior, looking into it (read: "Asking GPT4 to write the code for me")

It worked this way

put the storage_options in header and use only azure_use_azure_cli (less repetitive than @milicevica23 code comments)
using command line do az login before dbt run and dbt docs generate, and there is no password leak in the HTML (with the azure_storage_account_key either if you prefer the former technique)

sources.yml
version: 2

sources:
  - name: my_delta_source
    config:
      plugin: delta
      storage_options:
        azure_use_azure_cli: "True"

    tables:
      - name: table1
        config:
          delta_table_path<EMAIL_ADDRESS>
      - name: table2
        config:
          delta_table_path<EMAIL_ADDRESS>
See https://docs.rs/object_store/latest/object_store/azure/enum.AzureConfigKey.html#variant.UseAzureCli

Hi @mycaule, thank you for pointing that out.
https://docs.rs/object_store/latest/object_store/azure/enum.AzureConfigKey.html#variants should be all possible configuration which can be used to access the azure object storage
Currently i am on a trip so I will update my repo next week with more examples


How to configure from reverse proxy to forward proxy?

Hi. I'm struggling with configure conf from reverse proxy to forward proxy.

No.1 I made it.
But When I try No.2 with https, proxy A always response 400 Bad request. And there is no problems with http.
proxy A just dose forward to proxy B1, B2 with load balancer without any certificate because It just needs for forward to proxy B1, B2.
To test I used curl -x http://proxy A https://target
Any recommendations to make this one?
thanks!

It would be helpful if you shared your current configuration

It would be helpful if you shared your current configuration

Here is my conf in proxy A
listeners:

name: proxyA
address:
socket_address:
protocol: TCP
address: <IP_ADDRESS>
port_value: 44000
filter_chains:

filters:

name: envoy.http_connection_manager
typed_config:
"@type": type.googleapis.com/envoy.config.filter.network.http_connection_manager.v2.HttpConnectionManager
stat_prefix: ingress_http
route_config:
name: local_route
virtual_hosts:
- name: local_service
domains: ["*"]
routes:
- match:
prefix: "/"
route:
cluster: proxyB
http_filters:

name: envoy.router
clusters:

name: proxyB
lb_policy: ROUND_ROBIN
load_assignment:
cluster_name: proxyB
endpoints:

lb_endpoints:

endpoint:
address:
socket_address:
address: proxyB
port_value: 44000

@malza321 please enclose all configuration and log traces etc in ```

@malza321 please enclose all configuration and log traces etc in ```

Thanks a lot! :)


sink::Buffered accepts 1 more than capacity

In start_send, it looks likeitem will be buffered if self.buf.len() == self.cap:
fn start_send(&mut self, item: Self::SinkItem) -> StartSend<Self::SinkItem, Self::SinkError> {
    self.try_empty_buffer()?;
    if self.buf.len() > self.cap {
        return Ok(AsyncSink::NotReady(item));
    }
    self.buf.push_back(item);
    Ok(AsyncSink::Ready)
}

If this is the case, self.buf will contain amt + 1 items.
Not sure what the best fix is. To avoid a re-allocation, we should allocate self.buf with capacity amt + 1. If we want to guarantee that self.buf never contains more than amt items, it seems like it will make the logic in start_send more complicated, since it will need to attempt to send item to avoid hanging.

I think we could just tweak the logic to only hold self.cap elements in the local deque, right?

The issue with that, which is minor, is that a buffer with 0 capacity will will block. start_send will return not ready, but the task will never be notified.
This can be fixed by attempting to send the item if the buffer is empty / the capacity is zero:
https://github.com/casey/futures-rs/commit/bf7fceaada2a57cfb9e289cd44ad318ba1fa1af3

The implementation can be fixed though to just try to forward to the underlying sink on 0 capacity?

Sounds good, opened #613


Not enough context in error messages

Some users have reported issues with using cargo on WSL where they cannot open the documentation.  There are a fair number of distributions in the Microsoft Store that do not preinstall wslview. The error message is a rather difficult one to understand:
warning: couldn't open docs

IO Error

Caused by:
  No such file or directory (os error 2)

It would be helpful if the error message could provide some more context. Particularly that it is the wslview executable that cannot be found (and maybe even some more help on what to do about that).  Perhaps there could be more variants of OpenError for specific errors like these?
Anytime Command.spawn is used, it might be good to wrap that error with information about which command is being executed.

The strategy on WSL is to try wslview first, then try the system xdg-open, so that error is actually produced from trying to launch a non-existing xdg-open.
I agree the error should be clearer, ideally by mentioning that neither wslview or xdg-open were found. This will involve modifying our error enum.


[BUTTON IDEA]:

Dropdown buttons:
**Example of using a dropdown menu with a button:*:
The dropdown animation happen downward side:
Yes:

Thank you for submitting this idea. Unfortunately, this idea requires javascript and this is a CSS-only project. Please submit any other idea you have that is related to it!

Thank you for submitting this idea. Unfortunately, this idea requires javascript and this is a CSS-only project. Please submit any other idea you have that is related to it!

Thank you for submitting this idea. Unfortunately, this idea requires javascript and this is a CSS-only project. Please submit any other idea you have that is related to it!


Add norwegian translation

Thanks for the PR! Would you mind to add some of the new texts? Here's an updated example in English
{
  "Azimuth": "Azimuth",
  "Dawn": "Dawn",
  "Dusk": "Dusk",
  "Elevation": "Elevation",
  "Noon": "Solar noon",
  "Sunrise": "Sunrise",
  "Sunset": "Sunset",
  "errors": {
    "SunIntegrationNotFound": "Sun integration not found"
  }
}


Add support for filters

Codecov Report

Merging #144 (6d2815e) into master (7745e19) will increase coverage by 0.55%.
The diff coverage is 96.72%.

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
+ Coverage   78.77%   79.32%   +0.55%
==========================================
  Files          30       31       +1
  Lines        1366     1427      +61
==========================================
+ Hits         1076     1132      +56
- Misses        200      204       +4
- Partials       90       91       +1

Impacted Files
Coverage Δ

filters.go
96.72% <96.72%> (ø)

cmd/mstdn/main.go
65.60% <0.00%> (-1.21%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7745e19...6d2815e. Read the comment docs.

Thank you


Users are able to select unpublished templates to create plans

Please complete the following fields as applicable:
Expected behaviour:
When I create a plan, I shouldn't have unpublished templates available to me.
Actual behaviour:
I'm able to select unpublished template to create plan.
Steps to reproduce:

@dsisu I can't replicate this. "Data Section Enabling Technologies Hotels" is published, while the unpublished "Gezond leven: goed voor je hart" is not selectable.

Agreed. I can't replicate this either. I think the problem at hand is confusing terms in our admin interface and the way we classify them in the publish / unpublished status numbers at top.
ZonMw has three templates. Two of their own - Datamanagement ZonMw and Data Section Enabling Technology Hotels. These are both published but have unpublished changes. Very misleadingly this means they show in the 'unpublished' tally at top of table. I think there is an existing ticket to fix this.
There is a third template (Gezond leven: goed voor je hart) which they started to create on behalf of the Dutch Heart Foundation but they have since got admin rights themselves. This template is unpublished and doesn't show on front end.
All is displaying correctly so I'm closing this ticket out.


Response is undefined in api

Hello @kailong321200875
This is amazing open source template with Vite and Elementplus.
Thank you for your effort.
And I have an issue.
I always get undefined response when I make a request in api.
// api/login/index.ts
export const loginApi = async (data: UserLoginType): Promise<IResponse> => {
  const res = await request.post({
    url: '/index/login/system',
    headersType: 'application/x-www-form-urlencoded',
    data
  })
  console.log('in api: ', res)
  // this returns undefined. but there's correct response when I checked in console.
  return res && res.data
}

// vite.config.ts
    ...
    server: {
      port: 4000,
      proxy: {
        // 选项写法
        '/api': {
          target: 'http://<IP_ADDRESS>:9998',
          changeOrigin: true,
          rewrite: path => path.replace(/^\/api/, '')
        }
      },
      hmr: {
        overlay: false
      },
      host: '<IP_ADDRESS>'
    },
   ...

I also tried with sample api link for test.
https://jsonplaceholder.typicode.com/todos/1
But the result is the same.
How can I fix this?

you can try it
result_code: '0000' => result_code: 0

src/config/axions/config.ts

Oh, cool.
It's fixed.
I am just starting my project using this template and will may be tons of issues.
And regret to saying that I'll disturb you with many questions.
Thank you
Best regards.
👍


Add deployment/testing with Python 3.10

@phschiele @akshayka I'm getting pretty close to getting 3.10 working. I'm getting a weird bug I can't reproduce locally involving diffcp: https://github.com/cvxpy/cvxpy/runs/4628602909?check_suite_focus=true#step:6:4333
I'll think about it more but if anything comes to mind let me know.

@SteveDiamond I think I found the issue:
Installing diffcp under Python 3.10 installs 1.0.16 instead of 1.0.18, which does not have support for SCS 3.0 yet.
The reason is that on PyPI there are neither wheels for 3.10, nor the source.
I'll check why the source was not deployed with the last tag. After this is fixed, the tests should pass here, and you could even undo the changes made to diffcp_conif.py, as this is handled within diffcp.

@SteveDiamond I found two more occurrences where the Python versions are listed explicitly: pyproject.toml and sonar-project.properties.

@phschiele thanks so much for figuring it out! I'm also having some problems building wheels for 3.10. Not totally sure what's going on there: https://github.com/cvxgrp/diffcp/runs/4632902674?check_suite_focus=true#step:7:53

Integrating a version of #1559

@phschiele I think this is good to go. Could you review it when you have time?


What should the syntax for module mixins be?

Draft 2 of the proposal allows a module mixin to be defined using the syntax @use "susy" mixin. This defines a mixin with the same name as the module's prefix that, when included, injects the module's CSS at that point in the document. This is intended to satisfy the use-case currently handled using nested imports, where a user wants to scope a chunk of upstream CSS within a specific selector or media query.
I'm not sure this is the best syntax to use, though. Creating an implicit mixin feels weird, especially because it means namespace and namespace.member will both be meaningful identifiers, but the latter won't actually be referring to a member of the former. It would also be the only instance under the new module system where a @use without no-prefix would create an identifier that's not part of a unique namespace.
Note: I'm considering this discussion largely orthogonal to https://github.com/sass/language/issues/8. In any of these proposals, the module mixin may or may not allow configuration parameters to be passed.
Possible Options

Keep the existing syntax
@use "susy" mixin;

.susy {
  @include susy;
}

Add a meta mixin and a silent modifier
This mixin would take the namespace or URL of the module and include its CSS. This way we don't pollute the top-level namespace. It would also require adding a modifier to @use to tell it not to generate any CSS on its own, but that may be useful anyway.
@use "susy" silent;
@use "sass:meta";

.susy {
  @include meta.module-css("susy");
}

Add a meta mixin that can dynamically load files
If the meta mixin can take a module URL, it raises a new question: why not just allow it to take any URL, not just one that has a @use declaration in the same file? This dovetails with the planned load() function nicely; it would effectively be a shorthand for @include meta.include(map.get(meta.load($url), "css")).
It also dodges most of the downsides of dynamic includes, because it explicitly does not introduce any new names to the file that includes it. Static analysis therefore remains tractable (although, as with load(), it does become impossible to statically determine the set of files a stylesheet depends on).
@use "sass:meta";

.susy {
  @include meta.load-css("susy");
}

@nshahan I don't think it's any worse than the load() function, which we're already planning to add. It's kind of a parallel concept to isolates in Dart: you can load them dynamically, but in a strict build system you need to explicitly depend on everything you might load dynamically.

I would actually propose an alternate approach here, with the goal of creating a generally more strict and explicit system to combining concrete CSS trees: @use always encapsulates the CSS tree of the target into a mixin (or similar construct). This admittedly further departs from the existing @import mechanics, but pushes for a more explicit ecosystem. Since @use is a totally new syntax, it's the perfect time to change how people think about importing other Sass files.
The motivations here are:

Prevent people from accidentally pulling in concrete styles when they only intended to @use mixins/variables/functions. I have seen this happen on multiple occasions, with people unknowingly ballooning their CSS payload size.
Impose consistency by avoiding having two different ways in which @use can interact with CSS trees. Having exactly one mental model for @use makes it easier to internalize.
Align Sass with other languages in discouraging/minimizing side-effects.

Since @import is a standard CSS feature, it would then make sense to continue using @import continue doing what it does today (always pulling in the full CSS tree of the target).

I think I agree that a zero-side-effect approach to library design is a good one, but I'm very concerned with how backwards-incompatible it would be to encode that into the language. Not only does it add a lot of boilerplate to users' stylesheets if they migrate without refactoring, but it requires users to migrate their understanding of how Sass projects should be structured. Even if that migration is positive (and I believe it probably is), that adds a lot of friction to what's already going to be a difficult ecosystem-wide migration.
At a higher level, the reason I'm so concerned with migration cost is that there's a real possibility that, if the friction around @use is high enough, libraries just won't adopt it. And since it's a feature all about interactions between Sass files, it really needs most of the ecosystem to buy into it to be successful in the long run. I'm very wary of using it as a lever to try to change people's interactions with Sass, because I'm worried that lever will push the other way and just push people away from @use.

Now that the module system proposal has been accepted, this has been definitively decided: module mixins are included using a special built in meta.load-css() mixin.


Pass noAckStream variable for create function

Merged upstream: https://github.com/GeorgeSapkin/pubsub-store/pull/11 Thanks :+1:


Custom attributes and single quotes aren't converted properly

data-sheets-userformat='{"2":5059,"3":[null,0],"4":[null,2,15389148],"9":1,"10":1,"11":4,"12":0,"15":"Calibri"}'
and
style='font-family: "Times New Roman"'
are converted into:
data-sheets-userformat="{"2":5059,"3":[null,0],"4":[null,2,15389148],"9":1,"10":1,"11":4,"12":0,"15":"Calibri"}"
and
style="font-family: "Times New Roman""
The single quotes ' are converted into double quotes ", which break the html.

I have a feeling this is happening in one of the dependencies juice uses, but I agree this is a problem. A PR to fix this would be most welcome.

@WayneUong
sanitize the html beforehand: https://github.com/punkave/sanitize-html
e.g.,
before:

after:

This is especially egregious in Chrome. See https://codesandbox.io/s/elated-goodall-d3h8eb?file=/src/index.js.
const app = document.getElementById("app");

app.style.fontFamily = "Segoe UI, Arial, sans-serif";

var juice = require("juice");
var result = juice(`
<style>div{color:red;}</style>
${app.outerHTML}
`);

console.log(result);

This results in a font family of " undefined: SegoeUI" undefined: ,Arial,sans-serif;.


add feature for disable tracking on query result entities for better performance similar to .AsNoTracking in entity framework

hi I think this is a good feature for improve performance specially for heavy queries
add feature for disabling tracking on query result entities for better performance like .AsNoTracking in entity framework

by tracking you mean change set tracking? please follow the feature request template

by tracking you mean change set tracking? please follow the feature request template

I mean disabling storing result entities in Identity Map for  a specific query by setting a property
for example
repo.findOne({},{noTracking:true})
In the example above, the resulting entities are not expected to be stored in the identity map and mikro orm and mikro orm no longer tracks their changes

I mean disabling storing result entities in Identity Map for  a specific query by setting a property
for example
repo.findOne({},{noTracking:true})
In the example above, the resulting entities are not expected to be stored in the identity map and mikro orm and mikro orm no longer tracks their changes


How to add arbitrary arguments at the beginning? + Bug found in examples/README.md

I want to add the "-re" flag at the beginning of the command (i.e. as an input parameter). I cannot pass it to the input function as it is not in the format of -<param_name> <param_value> (i.e. it's a flag w/o a value).
I came across this issue https://github.com/kkroening/ffmpeg-python/issues/30 which says I should use global_args. But it does not allow to add flags at the beginning of the command, As I get AttributeError: 'FilterableStream' object has no attribute 'global_args' when trying ffmpeg.input(file_path).global_args("-re").
This led me to examples/README.md, where I saw global_args("-re") being used on the output. FFmpeg ignores this flag when used on the output, which means the example under "Stream from a local video to HTTP server" has a bug in it, and also means I was unsuccesful to add this flag.
I kindly ask for you help. Thank you.

This seems to be a reoccurring bug with the global_args() parameter, but every instance that I have seen and personally attempted with it, it has not worked as proclaimed and I am not aware (or searched) to see if there is an active PR to fix this bug. Here in a previous issue, I put the parameter -rethat I wanted at the beginning after input with the value of None:
process = (
    ffmpeg
    .input("input.mp4", re=None)
    .output(
        server_url,
        codec = "copy", # use same codecs of the original video
        listen=1, # enables HTTP server
        f=video_format)
    .run()
)

@kyrlon Works like a charm, thank you!
I tried .input("input.mp4", re="") but didn't think to try None instead of ""...

This should really be notices in documentation...

try using
ffmpeg.run(cmd="ffmpeg -re")


Compile each ts file into own js file

Hi guys, I have found that there are no documentation here that describe how compile each 1.ts/2.ts/3.ts into own 1.js/2.js/3.js files. Is there any solution?

Not specifying the out or outFile option should do that.

@OlegDokuka Is this still an issue?

No, what I have already done it is make my gulp file like this:
var gulp = require('gulp'),
    ts = require('gulp-typescript'),
    merge = require('merge2'),
    clean = require('gulp-clean'),
    fs = require('fs'),
    path = require('path');

var tsProject = ts.createProject('Typejector/tsconfig.json', {typescript: require('typescript')});

function getFolders(dir) {
    return fs.readdirSync(dir)
        .filter(function (file) {
            return fs.statSync(path.join(dir, file)).isDirectory();
        });
}

gulp.task('example', function () {
    var base = 'Example',
        folders = getFolders(base),
        tasks = folders.map(function (folder) {
            console.log(path.join(base, folder, '/*.ts'));

            return gulp.src(path.join(base, folder, '/*.ts'))
                .pipe(ts({
                    typescript: require('typescript'),
                    experimentalDecorators: true,
                    target: 'es5',
                    noImplicitAny: false
                }))
                .js.pipe(gulp.dest(path.join(base, folder)));
        });

});


Adding other axes and buttons.

Adding other axes and buttons for reference.  They will just be printed out.
GearVRf-DCO-1.0-Signed-off-by: Tom Flynn
<EMAIL_ADDRESS>

Everything works for me except for the "play" button (case 310 in the code) which started another application and didn't print anything to the log.

tried clarifying the whole second analog stick thing.  let me know if it makes better sense.

Removed reference to 'Play' button.  Seems it launches S-Console on Note 4 and there didn't seem to be a way to disable/override it.


CI fails for PRs from other repositories

Reference https://github.com/morremeyer/charts/pull/73#issuecomment-1072406613
Our CI jobs try to checkout PR branches from the original repository and not from the fork, so it always fails for PRs from other repositories.

Solved with the latest PRs.


Download as Excel?

Feature Description
Currently, the data Downloads links produce CSV files. It would be nice to be able to download Excel (XLSX) files.
Goal of Feature
Customers could directly use the downloaded data without having to go through CSV import settings in Excel.
Current Solution / Workarounds
Either educate the customer to work with CSV files, or send them (e.g. per Email) Excel files that we generate for them by opening the CSV in Excel and saving it as XLSX.
Alternatives
Some server-side service that could generate XLSX for a given Dataset?

Doesn't excel open .csv files natively on windows?
I don't have a PC with the office suite handy, but as far as I recall you could double click a csv file and it would open it in excel.


Update to v0.2

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Fail to get permissions for one SAS attached ADLS Gen2 folder

Storage Explorer Version: 1.17.0
Build Number: 20210129.3
Branch: main
Platform/OS: Windows 10/ Linux Ubuntu 18.04/ MacOS Catalina
Architecture: ia32/x64
Regression From: Not a regression
Steps to Reproduce

Expand one ADLS Gen2 storage account -> Blob Containers.
Create a blob container -> Upload one folder with the name 'test' -> Attach the folder via SAS with full permissions.
Right click the SAS attached folder -> Click 'Manage Access Control Lists...'.
Check whether the 'Manage Access' dialog pops up.

Expected Experience
The 'Manage Access' dialog pops up.
Actual Experience
Fail to get permissions for the folder.

Verified on build 20210203.5. This issue has been fixed. So we close it.


The node of behavior_path_planner dies in some conditions

Checklist

[X] I've read the contribution guidelines.
[X] I've searched other issues and no duplicate issues were found.
[X] I'm convinced that this is not my fault but a bug.

Description
The node of behavior_path_planner dies  when I set target in change lane.The simulation is shown as below:

note:

Lane change is not allowed in the area within the red border.
I print out information of path  and the size of points of path is zero in lane_following.
Expected behavior
The node of behavior_path_planner shall not die  in any conditions of lanes and target.
Actual behavior
The node of behavior_path_planner dies  in some conditions of lanes and target.
Steps to reproduce
1.Start autoware planning simulator;
2. Set initial position
3. Set target in the change lane(there are more than two lanes and the distance of lane change shall is not enough)
Versions
1.OS: Ubuntun 20.04
2.ROS2: Galactic
3.Autoware: Autoware.universe:main
Possible causes
No response
Additional context
No response

Hi @shulanbushangshu
Thank you very much for the report.
The bug probably is related to the https://github.com/autowarefoundation/autoware.universe/issues/2473
There is a bit delay due to some circumstances, but I'll try fix it as soon as possible.

@shulanbushangshu
Can you help to confirm whether #2615 solve this issue ?
thank you very much in advance.

@zulfaqar-azmi-t4
I  change the codes with https://github.com/autowarefoundation/autoware.universe/pull/2615 and finish the simulation.
case1:

case2:
I set the target in the third lane and the distance of lane change shall is not enough.

The  node of behavior_path_planner  still died.

@shulanbushangshu
Is this the latest commit in the upstream? I seems to me the lane change path is a bit weird.
I couldn't reproduce the error, therefore, could you share to me the lanelet map file?

@shulanbushangsh
is there any update regarding this issue?
If not, I might close the thread.

@zulfaqar-azmi-t4
The lanelet2_map:
lanelet2_map.zip
The position of testing lane:

I test the issue in the autoware of humble.There is still problem and the test is as follows:

I have updated the pr

It is fixed in the newest code. I close the issue


Use display size, camera size, and preferences when calculating recording size.

Refs #19. Closes #17. Closes #22.

LGTM

Looks good to me too.


Can't deploy on IIS

Hi, I deployed this application from VS2017 to my Windows Virtual Machine with IIS.

The app runs but then I try to open localhost:5000 on my browser I get the following error:

Any help would be appreciated.
Update: I was able to run the project by cloning, running the scripts and then dotnet run.
Still can't get the project working with VS2017 publish option.

Can you take a look at some of the other issues about IIS, I'm not sure if there's something else that you might be missing. I have only deployed to AWS and Azure myself. Possibly Node is missing, or there is some kind of folder/base-path issue going on.
https://github.com/MarkPieszak/aspnetcore-angular2-universal/issues/412
IIS issues to look through here
https://github.com/MarkPieszak/aspnetcore-angular2-universal/issues?utf8=✓&q=is%3Aissue+IIS

this seems related to #633

Known issue for SSR, https://github.com/angular/angular-cli/issues/8616. #639 fixes this problem.

#639 merged https://github.com/MarkPieszak/aspnetcore-angular2-universal/pull/639
@GonzaloAndrade take a look and see if updating your webpack code like shown there fixes it for you as well!
@GRIMMR3AP3R 💯 💯

Everything works now 👍
Thanks!!


Refactor docs to cover both names and identifiers

Add more examples and document the additional shortening from names to
identifiers that we've done in many cases.

While writing this I encountered a few issues:

structuredClone() has "structured-clone" as the identifier and checkVisibility() as "check-visibility", but scrollIntoView() has "scrollintoview". Should we change it to "scroll-into-view" or add "match caniuse when shorter" to the guideline?
should "array-copywithin", "array-findlast", "array-fromasync", and "array-isarray" be separated into words even though that makes the identifiers longer than the names? What about "bigint"?
The identifiers "viewport-relative-units" and "viewport-relative-unit-variants" are not derived from the names at all
What about features names for case-insensitive attribute names or values like "modulepreload" and "tabindex"? Do we need to explain why we use those names?

Dear reviewers, please don't block this PR on figuring out the answers to all of these issues, but keep them in mind :)

structuredClone() has "structured-clone" as the identifier and checkVisibility() as "check-visibility", but scrollIntoView() has "scrollintoview". Should we change it to "scroll-into-view" or add "match caniuse when shorter" to the guideline?

I think structured-clone is special being a global and that "structured cloning" is something said by documentation and such. But perhaps check-visibility should be renamed to something like element-checkvisibility and elements-scrollintoview, keeping in the spirit of the Array method identifiers. (see also https://github.com/web-platform-dx/web-features/pull/656#discussion_r1514509663).

should "array-copywithin", "array-findlast", "array-fromasync", and "array-isarray" be separated into words even though that makes the identifiers longer than the names? What about "bigint"?

Continuing from my previous point, perhaps we need a guideline for single interface method features. Those feel like "easy" cases where we might just use the method name and move on.
In the case of bigint, I think developers just say "bigint" and "bigints" and less commonly "big ints", so we have that to go on here.

The identifiers "viewport-relative-units" and "viewport-relative-unit-variants" are not derived from the names at all

I think I'm responsible for these and I tried to rely phrases "known to be in widespread use by web developers." I tried to validate this by reading blog posts and Stack Overflow questions about their use.  I don't think it'd be outrageous to use the unit names directly, but the description field fills that need too.

What about features names for case-insensitive attribute names or values like "modulepreload" and "tabindex"? Do we need to explain why we use those names?

It wouldn't hurt to make that explicit for names, though I think the "lowercase alphanumeric" bit handles the identifiers already.
(Also, I learned today that the values are case insensitive! I had long assumed that the sequence of bytes given by modulepreload was significant, not the sequence of letters. Fascinating!)

But perhaps check-visibility should be renamed to something like…

Over in https://github.com/web-platform-dx/web-features/pull/655#issuecomment-1980936576, Philip makes a good case for preferring brevity over consistency across the whole set of features. (That said, we should prefer consistency when we add text to distinguish things for ambiguity, as in the case of arrays and typed arrays.)

Thanks for the review @ddbeck! I'll merge this and we should keep going in https://github.com/web-platform-dx/web-features/issues/548 with the guidelines.


Footnotes not displaying if names contain hyphens

Thank you so much for putting this super helpful plugin together! In the open education and publishing space support for footnotes is really critical🙂
A colleague of mine recently shared a Markdown doc with footnotes where some footnote names contained hyphens, and the current version of this plugin would not display these as expected. With the help of ChatGPT, I was able to modify the RegEx used so that hyphens were supported in footnote names.
This change was to replace [A-Za-z0-9] with [A-Za-z0-9\-] to allow hyphens within the footnote name. Please feel free to incorporate this update into your plugin if you like to then support hyphens as well. The Markdown file in question is https://github.com/OleVik/Digital-Publishing-System-Framework/blob/main/README.md and with this change Docsify-This now renders the footnotes correctly https://docsify-this.net/?basePath=https://raw.githubusercontent.com/OleVik/Digital-Publishing-System-Framework/main&homepage=README.md&sidebar=true
Thanks again, and also thanks for your continued work as a Docsify Maintainer!
Paul

I made the changes and released v1.0.2.
Thanks for the sponsor. 🎉


Number plate

Pull Request for ML-Crate 💡
Issue Title : Number Plate Prediction

Info about the related issue (Aim of the project) : To get the number plate of the vehicle which is on a quiet high speed and breaking the traffic.
Name: Yagyesh Bobde
GitHub ID:
Idenitfy yourself:

[x] SWOC Participant ❄
[x] Contributor ✔

Closes: #77
Describe the add-ons or changes you've made 📃
Data loading, image preprocessing and model selection - CNNs and transfer learning
Type of change ☑
What sort of change have you made:

[x] Bug fix (non-breaking change which fixes an issue)
[] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist: ☑

[x] My code follows the guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly wherever it was hard to understand.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have added things that prove my fix is effective or that my feature works.
[x] Any dependent changes have been merged and published in downstream modules.

I actually used another dataset for this, because the dataset that you provided, in the JSON file it had access restrictions to the images ....
is that fine?

Can you create a fresh PR for this. It's ok with the dataset @yagyesh-bobde. No issues.


Add swiftpm-xctest-helper rpath on macOS.

Add an extra rpath for swiftpm-xctest-helper on macOS:
@executable_path/../../../lib/swift/macosx.
This fixes SR-12600:
$ swift test --filter a
error: signalled(6): /Library/Developer/Toolchains/swift-DEVELOPMENT-SNAPSHOT-2020-06-10-a.xctoolchain/usr/libexec/swift/pm/swiftpm-xctest-helper /Users/danielzheng/TestPkg/.build/x86_64-apple-macosx/debug/TestPkgPackageTests.xctest /var/folders/m_/6f7q8zfs3n9fr0c_4gy8840m00hc_q/T/TemporaryFile.3eFu0u output:
    dyld: Library not loaded: @rpath/XCTest.framework/Versions/A/XCTest
      Referenced from: /Library/Developer/Toolchains/swift-DEVELOPMENT-SNAPSHOT-2020-06-10-a.xctoolchain/usr/libexec/swift/pm/swiftpm-xctest-helper
      Reason: image not found

Fix found by @abertelrud in https://github.com/apple/swift-package-manager/pull/2694#issuecomment-628207883.

Just triggering tests.
@swift-ci Please test

I don't think we should be using unsafeFlags here and instead do this in the bootstrap script.

I don't think we should be using unsafeFlags here and instead do this in the bootstrap script.

Here's a PR (with more context) that edits the bootstrap script: https://github.com/apple/swift-package-manager/pull/2692.
The change is more invasive though, adding the rpath to all tools instead of just swiftpm-xctest-helper.
Any suggestions would be appreciated for moving forward with this PR or that one!

Oh, I didn't realise this change had so much history. It seems like Ankit and Anders think it is fine to do this with unsafeFlags so let's go ahead with this.

@swift-ci please smoke test

Could someone please help merge this PR, if everything's okay? @neonichu


Reviewerresponse

These are various changes in response to reviewer comments, as well as cleaning up some of the documentation

Codecov Report

Merging #138 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   82.41%   82.41%
=======================================
  Files          31       31
  Lines         927      927
=======================================
  Hits          764      764
  Misses        163      163

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad20f74...add24cd. Read the comment docs.


Grasshopper tests

We need tests for the grasshopper backend.
(This issue so I remember to do it at some point)

Does this still need doing?  What sort of tests need to be there?

I think the GH regression tests in travis are enough to declare this done. Or are there more tests that we need?


Make frontend-backend communication generic

ATM the HTTP-communication is handled completely in QueryServiceImpl.ts.
We need a generic solution (-> HttpService) for the network communication so common details like base-url, headers are handled only once.
Example calls of that:
// returns Promise<MyReturnType> and calls GET http://example.com/api/getNodeDetails
httpService.get<MyReturnType>('getNodeDetails');

// return Promise<MyReturnType> and calls POST http://example.com/api/queryAll with Body myBody
httpService.post<MyReturnType>('queryAll', { body: myBody });

// sets header 'MyHeader' to 'myValue'
httpService.post<MyReturnType>('queryAll', { body: myBody, headers: {'MyHeader': 'myValue' }});

The API proposal looks good to me. We need a method for GET request with query parameters, too. It is possible that it's the callers responsibility to encode this in the request URL, but I would prefer a method that handles this for the caller.
// returns Promise<MyReturnType> and calls
// GET http://example.com/api/getNodeDetails?ids=1&ids=2&ids=3&ids=4&otherProp=abc
httpService.get<MyReturnType>('getNodeDetails', { ids: [1, 2, 3, 4], otherProp: 'abc' });


Cannot login without manually setting APP_KEY in .env file.

Describe the bug
Cannot login without manually setting APP_KEY in .env file.
To reproduce
Steps to reproduce the behavior:

Follow the documentation:

cd <PUBLIC_WEB_DIRECTORY_FOR_KOEL>
git clone --recurse-submodules https://github.com/phanan/koel.git .
git checkout v4.0.0 # Check out the latest version at https://github.com/phanan/koel/releases
composer install
php artisan koel:init # Populate credentials during the process
php artisan serve

Expected behavior
Able to login using credentials provided during koel:init step.
Screenshots
N/A
Environment

Koel version [e.g. v4.0.0]
OS: Ubuntu 16.04
Browser: any browser
PHP version: 7.2.15
Node version: 8.15.1

Additional context
n/a

Try to use command
php artisan koel:generate-jwt-secret
I have the same problem with Ubuntu 18.4 but a Debian 8 (php 7.0) work well.

Faced the same problem in Fedora 31. #1141
This fixed it.

Has this issue been fixed?

I can still reproduce this error in Fedora 31. The command given by @SLHammer works only for generating the jwt-secret and not the APP_key which somehow the installer doesn't create. I tested with the latest master branch of Koel.
The installer should create the APP_key.
Can you please reopen this ticket?


Unimplemented component:  error message after following installation instructions

Description
[Description of the bug]
Steps to Reproduce
code ***
import React from 'react';
import { StyleSheet, Text, View } from 'react-native';
import LottieView from 'lottie-react-native';
import { bellLottie } from '../animations/index';
export default function Index() {
return ;
}
const styles = StyleSheet.create({
container: {
flex: 1,
backgroundColor: '#fff',
alignItems: 'center',
justifyContent: 'center',
},
});
Expected behavior: [What you expected to happe

n]
Actual behavior: [What actually happened]
Versions
You can get this information from executing npm version.

The "Unimplemented component" issue happens when you are using Fabric (new arch) but the component mounted doesn't support it (which is the case for Lottie). Fortunately, @AlexanderEggers is already working on a version supporting Fabric, so we might as well wait.

I'm still getting this (unimplemented component)

I am still getting this issue on IOS after migrating from reactive version 0.71.8 -> 0.73.9
Pods used :-
"lottie-ios": "3.4.0",
"lottie-react-native": "^5.1.6",   // Facing the same issue on the latest version 6.7.2
Information :-
System:
OS: macOS 14.6.1
CPU: (10) arm64 Apple M1 Pro
Memory: 758.95 MB / 16.00 GB
Shell:
version: "5.9"
path: /bin/zsh
Binaries:
Node:
version: 18.9.0
path: ~/.nvm/versions/node/v18.9.0/bin/node
Yarn:
version: 1.22.18
path: /usr/local/bin/yarn
npm:
version: 8.19.1
path: ~/.nvm/versions/node/v18.9.0/bin/npm
Watchman: Not Found
Managers:
CocoaPods:
version: 1.15.2
path: /opt/homebrew/bin/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 23.4
- iOS 17.4
- macOS 14.4
- tvOS 17.4
- visionOS 1.1
- watchOS 10.4
Android SDK: Not Found
IDEs:
Android Studio: 2024.1 AI-241.18034.62.2412.12266719
Xcode:
version: 15.3/15E204a
path: /usr/bin/xcodebuild
Languages:
Java:
version: 17.0.12
path: /usr/bin/javac
Ruby:
version: 2.6.10
path: /usr/bin/ruby
npmPackages:
"@react-native-community/cli": Not Found
react:
installed: 18.3.1
wanted: ^18.2.0
react-native:
installed: 0.73.9
wanted: 0.73.9
react-native-macos: Not Found
npmGlobalPackages:
"react-native": Not Found
Android:
hermesEnabled: true
newArchEnabled: false
iOS:
hermesEnabled: true
newArchEnabled: true

On IOS i am getting this issue when i upgrade the react native version to 0.71.8 -> 0.73.9
Then I ill update my react-native/gradle-plugin version to 0.75.1
Update this to package.json  "@react-native/gradle-plugin": "0.75.1"
It works for me !!

For projects using react native, if you run on ios then you have to install the lottie-ios library, if android then I think add the lottie-android library (I haven't tested this case)
"lottie-ios": "^4.5.0",
"lottie-react-native": "^7.1.0",
"react": "18.3.1",
"react-native": "0.76.0",


Bugfix: lax_deserialize currently accepts deserializing from NaN

With the lax_deserialize feature, NaN currently deserializes to 0. I don't think this was intended.
Although this can't happen with serde_json because JSON doesn't support NaN etc., this can very well happen with other deserializers.
This pull request fixes this by declinining to deserialize NaN, Infinity and -Infinity.
Note that using IntoDeserializer, as I've done here, could be used for the other tests as well, thereby getting rid of the necessity to use serde_json if desired. (This, by extension, should make the tests work with no-std again, thereby making the workaround for https://github.com/serde-rs/json/pull/516 obsolete as well ...).

This pull request fixes this by declinining to deserialize NaN, Infinity and -Infinity.

To be clear, the infinities were already rejected before, right?

Note that using IntoDeserializer, as I've done here, could be used for the other tests as well, thereby getting rid of the necessity to use serde_json if desired. (This, by extension, should make the tests work with no-std again, thereby making the workaround for serde-rs/json#516 obsolete as well ...).

Sounds good!

To be clear, the infinities were already rejected before, right?

You're right, I've missed that. I've changed the code to only check for is_nan.

Sounds good!

I'll do that then.

Ok, this was a bit more complicated than anticipated because I totally forgot about the Serialize direction. But nothing a custom TestSerializer couldn't fix!

There's also serde_test but I find its API to be a little annoying to use.

Maybe it would be good for this use case though.

Sorry about the force push, I still had expand.rs in there (I was looking at what #[derive(Serialize)] produces.

There's also serde_test but I find its API to be a little annoying to use.
Maybe it would be good for this use case though.

I'll look into that. Let's hope that it works with no-std :grimacing:

I have merged the first two commits (as one squashed commit) for now. It looks like you will have to rebase, which is a bit weird to me since I would expect a rebase to go through w/o any manual work needed.

I'll close this pull request then and create a new one for the testing changes. I expect that this requires an interactive rebase, but no worries, I have experience with that :grin: .


⚠ Bofrost.at has degraded performance

In 396171e, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1775 ms

Resolved: Bofrost.at performance has improved in 6f2b0bf after 18 minutes.


feat: Added a simple "hello-world" webview-view sample along with UI Kit integration and activity bar placement.

I personally found it quite challenging to set up a simple webview-view configuration, as the current example relies heavily on CSS dependencies and is not particularly beginner-friendly. Additionally, since VS Code recommends using its UI toolkit for webview, I am proposing to add a straightforward "hello-world" example within the webview-view, along with the UI toolkit setup. This view will also be placed as an icon in the activity bar. While there are examples available for each of these components separately, I believe that with this PR, it can serve as a template for developers who want to build webview-views alongside the UI toolkit, while keeping them accessible in the activity bar.
I have tried my best to follow the contributing guidelines to the best of my ability. However, this project utilizes an ESLint setup as recommended by the VS Code UI toolkit sample guide. Unfortunately, I was unable to locate .scripts/samples.js. Could you please provide guidance on finding it?
Thank you!

@microsoft-github-policy-service agree

Since this duplicates an existing sample and focuses on using the ui toolkit, I don't think it's a good fit for this repo. Maybe it can live in your own repository for those who'd find it helpful

Since this duplicates an existing sample and focuses on using the ui toolkit, I don't think it's a good fit for this repo. Maybe it can live in your own repository for those who'd find it helpful

Got it, sir @mjbvz . Thank you so much for your review


Get GeoJson File as Object

Dear Team,
Loved to use use your package so far. I found myself with a GeoJson problem.
I use a regular form to upload a GeoJson file. No big deal. Problem is to get this file and use it to generate the map on Leaflet.
Template.mapDropdown.events({
    "change #mapFilesDropDown": function(event, template){
         event.preventDefault();
         console.log(event.target.value);
         var mapId = event.target.value;
         var myMap = Maps.findOne(mapId);
         console.log(myMap.path);
    }
});

This event get the File _id to return the selected GeoJson file. MyMap.path gives me the absolute path (assets/app/uploads/Maps/dnHkQkceumTKmLGSR.geojson), but I cant reach it...
How do I get the GeoJson file as a Json Object?, and use this object to generate my leaflet map? (this one is on me :D )

Hello @fillipefeitosa ,
Glad to hear you've found a use in our package 😃
Please use .link() method to get "downloadable" URL to uploaded file. Let me know if this method will work for you.

Thanks for the fast response!!
.link() gave me:
http://localhost:3000/cdn/storage/Maps/dnHkQkceumTKmLGSR/original/dnHkQkceumTKmLGSR.geojson

I am on development env. Am I supposed to use that on production?
Thanks again

@fillipefeitosa yes 👍

@fillipefeitosa usually it's done with running alpha/beta/staging stages.

I solved by setting a downloadRoute

export const Maps = new FilesCollection({
    collectionName: 'Maps',
    allowClientCode: true,
    downloadRoute: '/public/',

    onBeforeUpload(file){
        if(file.size <= 10485760 && /json|geojson/i.test(file.extension)){
            return true;
        }
        return 'Favor fazer upload de geojson válido';
    }
});

Thanks for your time and great work,

Great @fillipefeitosa ,
I'm glad this one is solved quickly.
Please, keep in mind downloadRoute just a "fence" route, unless FilesCollection is initiated with public option.
Feel free to close it in case if the issue is solved on your end.


Add way to not fetch data twice in load when provided fetch cannot be used

Describe the problem
A lot of services provide SDKs used to simplify fetching data from their APIs, however a decent amount of them don't provide an option for a custom fetch function, so when you use that SDK in load() the data will be fetched twice, both on the server and the client. A library I'm having trouble with is Ghost CMS's SDK, and I remember having this issue with something else too but I can't remember what it was.
Describe the proposed solution
A function passed to load could allow you to pass in a unique ID and a callback — it runs that callback, caches the result as JSON and returns it. Once the app loads on the client-side and runs load again this function could check the cache and return it. For example:
export async function load({ cache, params }) {
  const post = cache(`post_${params.slug}`, async () => {
    try {
      return await someSdk.getPost(params.slug)
    } catch {
      return null
    }
  })
  // Do other things in load
  return { status: 200, props: { post } }
}

By caching I mean store the JSON string in the document the same way the custom fetch does - not sure if cache is the right term here
Alternatives considered
Using endpoints that run the SDK functions, but it's a bit boilerplate and loses some type-safety
Importance
nice to have
Additional Information
No response

The API you describe makes sense. I'm also not sure what the best name is, but will throw out serde as an option since we're talking about serializing and deserializing (not sure how widely known that contraction is, but it'd be easy to search for in the docs at least).
The cache key would be unnecessary in most cases — it could default to an incrementing integer. (If you started doing things inside if blocks and for loops then you'd need it, of course.)
So it could look like this:
export async function load({ serde, params }) {
  const post = await serde(() => someSdk.getPost(params.slug).catch(() => null));

  // Do other things in load
  return { status: 200, props: { post } }
}

Alternatives
I've honestly yet to find an SDK that wouldn't be better as a vanilla REST API — the more we can encourage platforms to offer endpoints that can be used with vanilla fetch (or at least allow a custom fetch implementation to be passed in, so that they can be used across different environments without bundling node-fetch etc), the better.
Assuming that's not possible, a good option is to proxy the API request. Now that we have shadow endpoints, this is extremely easy:
// src/routes/blog/[slug].js
export function get({ params }) {
  try {
    const post = await someSdk.getPost(params.slug).catch(() => null);
    return { body: { post } };
  } catch {
    return { status: 404 };
  }
}

<script>
  <!-- look ma, no `load`! -->
  export let post;
</script>

The downside is that you add a network hop, of course. Depending on how you've deployed your app that may or may not be an issue.

Would be awesome to implement. Our app loads data twice on every page load (ideally should be loaded on the server, and cached for the client). Or there could be an option to avoid re-loading data by the client if the server already loaded it.

Are there any future plans for this?
In my case, what I have is a server that holds a snapshot of some latest data from an API endpoint.
This API endpoint is able to provide new data incrementally in small bits, provided I have a snapshot of the current data.
What I'd like to do is have the server render the html page with the latest data that it has, whilst handing over the snapshot
of the latest data to the client as a prop so that the client may store it and request for incremental bits of data on its own from time to time.
On the server side this is fine as load() is able to access the server's persistent store of its latest data and build the data incrementally.
On the client side however, the same load() function runs with no initial state when the page is initially loaded, and has to resort to fetching the full dataset from the API endpoint. (Instead of being able to build it incrementally with an initial set of data provided by the server during SSR).
Granted, this happens only once on the initial page load, but for a high traffic website, performing the initial fetch of the full (possibly large) dataset could be taxing for the API endpoint.
I'm rather new to svelte/sveltekit, so with my limited experience at the moment I don't really see a way around this.
(I've seen some stackoverflow workarounds about sending the initial state as a cookie, but it sounds wrong to me.)

@kenfoo - The current svelte way of doing this would be to use an endpoint and an observable.  Get your data in an endpoint, put it in a load function with fetch, and render the page as normal.  The endpoint should only be called once, as that is the point of the fetch.  Then, take that initial state value that you returned from the load function, and insert that into an observable in the onMount() function to incrementally update the page however you like.  In the end, you have the server call, and the observable call, but that is it.
I hope this helps.
J
FWI - Rich Harris has talked about maybe one day doing something like NextJS's server side streaming, but that is probably a long way away and does not support your current use case.

Thanks @jdgamble555   I just found out about the new shadow endpoints and that seems to solve my use case perfectly.

Apart from the above mentioned Firebase and Apollo, it's also important for gRPC (or tRPC for that matter).
Using endpoints is not really a solution, that extra app complexity and network hop is unnecessary.
I feel SvelteKit should probably expose a way to inline the data in the HTML, like fetch does, manually.

We've been thinking further about what a sensible API for this could look like in #9160, so I'm going to close this issue in favour of that one


8.0.0: NET 8.0

Added support for .NET 8.0.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a6526d6) 97.61% compared to head (ea0a85b) 97.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #73   +/-   ##
=======================================
  Coverage   97.61%   97.61%
=======================================
  Files          54       54
  Lines         921      921
  Branches       90       90
=======================================
  Hits          899      899
  Misses         16       16
  Partials        6        6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


fix: Prevent underflow in range conversion

Previously, when line numbers of Rust spans were converted to LSP ranges, they could underflow resulting in very large line numbers. As an underflow is always wrong, prevent it and use 0 instead.
This was noticed when opening an empty file in src/bin/ of a library crate. In this case rustc produces a span with "line_start": 0, "line_end": 0 resulting in the underflow.

Thanks!
bors r+

changelog fix (first contribution) avoid underflows in range conversion


feat: add @aries-framework/redux-store

Replacement of #57 because of DCO issues
the nesting of a package inside a package is giving a lot of issues. We'll move this over to AFJ ASAP when the monorepo is ready (real soon)

Do DOCs behave differently in mono-repos or is it purely a problem with nesting? Since AFJ is also a Hyperledger repo we might end up with the same trouble..

DCO is unrelated to this. I'm not sure why the DCO issues arose, but it's just a modification to the commit message.


Browser Extension doesn't estimate Multisend transactions correctly

When the extension receives a Multisend transaction, it fails to estimate it.
Here are the details of a request to swap two owners:
Request URL: https://safe-relay.dev.gnosisdev.com/api/v1/safes/0xc318a9D9334e65762b70b5dFdc169042DB7CF863/transactions/estimate/
Request Method: POST
Status Code: 422 Unprocessable Entity
Remote Address: <IP_ADDRESS>:443
Referrer Policy: no-referrer-when-downgrade

Response Headers:
Access-Control-Allow-Credentials: true
Access-Control-Allow-Headers: DNT,X-CustomHeader,Keep-Alive,User-Agent,X-Requested-With,If-Modified-Since,Cache-Control,Content-Type,Authorization
Access-Control-Allow-Methods: OPTIONS, GET, HEAD
Access-Control-Allow-Origin: *
Allow: POST, OPTIONS
Connection: keep-alive
Content-Length: 42
Content-Type: application/json
Date: Tue, 11 Sep 2018 08:37:39 GMT
Server: nginx/1.13.12
strict-transport-security: max-age=60; includeSubDomains; preload
Vary: Cookie
x-content-type-options: nosniff
X-Frame-Options: DENY
x-xss-protection: 1; mode=block

Request Headers:
Accept: application/json
Accept-Encoding: gzip, deflate, br
Accept-Language: en-US,en;q=0.9,pt;q=0.8
Connection: keep-alive
Content-Length: 1429
Content-Type: application/json
Host: safe-relay.dev.gnosisdev.com
Origin: null
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.81 Safari/537.36

{
	"safe": "0xc318a9D9334e65762b70b5dFdc169042DB7CF863",
	"to": "0x2c155Fd04682979FD15c67FB65DfAb9345605761",
	"value": "0",
	"data": "0x8d80ff0a000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000002400000000000000000000000000000000000000000000000000000000000000000000000000000000000000000c318a9d9334e65762b70b5dfdc169042db7cf863000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000800000000000000000000000000000000000000000000000000000000000000064e318b52b0000000000000000000000006ce25663291132b56a982e017facde131e2b65fd00000000000000000000000067a552a25150e0d0d033d2c6adaca20f89d60937000000000000000000000000f2936669c3f82289ac2aa2579a1a2da7cd893df0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000c318a9d9334e65762b70b5dfdc169042db7cf863000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000800000000000000000000000000000000000000000000000000000000000000064e318b52b0000000000000000000000002b055e706a5609cac8136767959f489008160e530000000000000000000000006ce25663291132b56a982e017facde131e2b65fd000000000000000000000000931b03d84155a71b8376709ffa06f10bcd4152ad00000000000000000000000000000000000000000000000000000000",
	"operation": 0
}

Operation is 0 when it should be 1 (delegate call). So the extension needs to check if the to field is the Multisend address and perform a delegate call.

On a related note, I don't think the browser extension should perform another estimate when receiving the payload from the mobile client since it already estimates the transaction costs and those transaction costs should be the same (displayed and signed) by the browser extension.

On a related note, I don't think the browser extension should perform another estimate when receiving the payload from the mobile client since it already estimates the transaction costs and those transaction costs should be the same (displayed and signed) by the browser extension.

Makes sense to me. The transaction would fail if extension and app both sign different estimates, right?
@rmeissner @germartinez is there any security or other reason, to let the extension estimate as well?

Solved, thank you @fmrsabino!


The propq in X509_new_ex (and x509_set0_libctx) is not duplicated

The propq argument in X509_new_ex (and x509_set0_libctx) is not duplicated but it should be to ensure consistency with how other _new_ex functions handle the property query.
Fixing this requires also fixing it in #12687.

There was already a PR for this which was waiting on #12687 (which is now merged).
Fixing it up now so that it links to here..


west.yml: Update mcuboot with rename fix

Update mcuboot version to include fix:
Update CONFIG_FLOAT to CONFIG_FPU which has been renamed in zephyr.
Signed-off-by: Joakim Andersson<EMAIL_ADDRESS>

@nvlsianpu should this be closed in favor of your PR?

can be merged

Closing this since it was superseeded.


[Docs] Update the list of supported operations for the Meshery adapter for Citrix (CPX)

Current State:
The operations supported by the adapter for Linkerd are not listed in its documentation.
Desired State:
Under the heading Sample Applications and include a list of the supported operations, with a small explanation for each. The operations can be found listed here; (lines 47-124). Look out for the following line: opType: meshes.OpCategory_SAMPLE_APPLICATION. This means that the operation listed is a sample application.

Contributor Resources

Meshery documentation site
Meshery documentation source
Instructions for contributing to documentation

@chandrashritii , hello, I want to work on this.

@KarenEfereyan Sure. Go ahead!

Karen, given the consistency of your contributions, you’ve been invited to join the “Layer5io” org on GitHub (very cool). Now that your user is a member of the org, your user account has permission to triage issues, including management of any issues’ assignees. If you see an issue with the help-wanted label that is unassigned, you’re most welcome to self-assign.
Kudos on your new membership. Thank you for being an engaged and impactful contributor. 👍


Added to Reproduction Logs (Anserini) - Raghav Vasudeva

Completed the onboarding on MacOS (MacBook Pro M1)
After completing the build for Anserini (with these instructions: https://github.com/castorini/anserini?tab=readme-ov-file#-installation), running the bin/run.sh commands led to the following exception:
Error: A JNI error has occurred, please check your installation and try again
The workaround was to get the fatjar with the following command:
wget https://repo1.maven.org/maven2/io/anserini/anserini/0.38.0/anserini-0.38.0-fatjar.jar
Then, I ran modified bin/run.sh commands with this specific fatjar and was able to proceed with the onboarding.

Does this mean that you were not able to successfully build Anserini?

I received no exceptions/errors when building Anserini - which leads me to believe it succeeded. The resulting fatjars are also present in the ./target folder.


Rewrite bpf-loader in Rust

Reconstruct bpf-loader in Rust, including libs, clis, and C-wrappers.
There is a workspace, and three crates lies under that.

bpf-loader-lib is the core library of bpf-loader-rs, which can load, verify, attach, poll, control ebpf programs.
bpf-loader-cli is a simple CLI program using bpf-loader-lib to run ebpf programs. You can refer to README.md for details.
bpf-loader-c-wrapper is a C wrapper for bpf-loader-lib, which provides the same interface as the previous C++ version. The interfaces can be seen in bpf-loader-c-wrapper/eunomoa.h

Note: besides the features that the C++ version already has, bpf-loader-rs also fixes a lot of bugs of the implemention that C++ version provides, and adds the ability to pause, resume, or terminate the polling process. Related APIs can be seen in the document of bpf_loader_lib::skeleton
Major documents can be seen at README.md, others are top-evel mod's docs. See them for more things.
Note: deep source seems to be broken, I've no idea on how to make it happy on this https://app.deepsource.com/gh/eunomia-bpf/eunomia-bpf/run/5f6b49c5-1d88-414b-b15d-e6c9a1167f61/rust/RS-E1015?listindex=0

It seems bpf-loader-rs/bpf-loader-cli/README.md is an empty file.

Fixed now


Fixed up some doc errors

Switched verbose from being a bool to frozenset of strings, and set use_inverse=False for the mix-and-match example (temporarily, I'll add proper support for use_inverse=True soon.)

LGTM!


Conditions continually appended to Switch value

It's highly possible that I'm just using gargoyle wrong, but I'm experiencing surprising behavior.
In one of my project's apps, I've created a gargoyle.py file:
from __future__ import absolute_import

from gargoyle import gargoyle

gargoyle['foo'].add_condition(
    condition_set='gargoyle.builtins.UserConditionSet(auth.user)',
    field_name='percent',
    condition='0-50'
)

My understanding is that this will make the foo switch active for 50% of users. This seems to work. The value in the database after I run my local server is:
{
  "auth.user": {
    "percent": [
      [
        "i",
        "0-50"
      ]
    ]
  }
}

But now, if I restart my server, the condition is duplicated:
{
  "auth.user": {
    "percent": [
      [
        "i",
        "0-50"
      ],
      [
        "i",
        "0-50"
      ]
    ]
  }
}

I've traced this to Switch.add_condition:
        if condition not in self.value[namespace][field_name]:
            self.value[namespace][field_name].append((exclude and EXCLUDE or INCLUDE, condition))

Here it's checking if condition which is '0-50' is "in" a list of tuples, which will always return false. Obviously this is solvable by adding commit=False to Switch.add_condition. However, it makes me worry that I'm missing something fundamental.

Also curious if there is documentation for switches somewhere that I'm just missing. http://gargoyle.readthedocs.org/en/latest/ref/conditions.html is empty.


Pods are not able to list services

Is this a request for help?:
Yes
Is this an ISSUE or FEATURE REQUEST? (choose one):
ISSUE
What version of acs-engine?:
0.12.3
Orchestrator and version (e.g. Kubernetes, DC/OS, Swarm)
Kubernetes
What happened:
I have a Kubernetes v1.8 cluster provisioned to a custom VNet. When trying to run external-dns, logs are displaying the following errors:
time="2018-01-23T23:43:42Z" level=error msg="services is forbidden: User "system:serviceaccount:default:default" cannot list services at the cluster scope"
I have also tried setting the namespace on the external-dns arguments to default, but no luck -
time="2018-01-24T00:03:13Z" level=error msg="services is forbidden: User "system:serviceaccount:default:default" cannot list services in the namespace "default""
This works on ACS clusters.
What you expected to happen:
The external-dns plugin should be able to list services
How to reproduce it (as minimally and precisely as possible):
Follow the instructions for deploying external-dns here: https://github.com/kubernetes-incubator/external-dns/blob/master/docs/tutorials/azure.md
Anything else we need to know:
Here is the full log output:
time="2018-01-23T23:43:39Z" level=info msg="config: &{Master: KubeConfig: Sources:[service] Namespace: AnnotationFilter: FQDNTemplate: Compatibility: PublishInternal:false Provider:azure GoogleProject: DomainFilter:[removed] AWSZoneType: AzureConfigFile:/etc/kubernetes/azure.json AzureResourceGroup:[removed] CloudflareProxied:false InfobloxGridHost: InfobloxWapiPort:443 InfobloxWapiUsername:admin InfobloxWapiPassword: InfobloxWapiVersion:2.3.1 InfobloxSSLVerify:true InMemoryZones:[] Policy:sync Registry:txt TXTOwnerID:default TXTPrefix: Interval:1m0s Once:false DryRun:false LogFormat:text MetricsAddress::7979 LogLevel:info}"
time="2018-01-23T23:43:39Z" level=info msg="Connected to cluster at https://<IP_ADDRESS>:443"
time="2018-01-23T23:43:42Z" level=error msg="services is forbidden: User "system:serviceaccount:default:default" cannot list services at the cluster scope"
time="2018-01-23T23:44:43Z" level=error msg="services is forbidden: User "system:serviceaccount:default:default" cannot list services at the cluster scope"

Here is my api model:
{
  "apiVersion": "vlabs",
  "properties": {
    "orchestratorProfile": {
      "orchestratorType": "Kubernetes",
      "orchestratorRelease": "1.8"
    },
    "masterProfile": {
      "count": 1,
      "dnsPrefix": "[removed]",
      "vmSize": "Standard_D2s_v3",
      "vnetSubnetId": "/subscriptions/[removed]/resourceGroups/[removed]/providers/Microsoft.Network/virtualNetworks/[removed]/subnets/[removed]",
      "firstConsecutiveStaticIP": "<IP_ADDRESS>",
      "vnetCidr": "<IP_ADDRESS>/24"
    },
    "agentPoolProfiles": [
      {
        "name": "agentpool1",
        "count": 2,
        "vmSize": "Standard_D4s_v3",
        "vnetSubnetId": "/subscriptions/[removed]/resourceGroups/[removed]/providers/Microsoft.Network/virtualNetworks/[removed]/subnets/[removed]",
        "availabilityProfile": "AvailabilitySet"
      }
    ],
    "linuxProfile": {
      "adminUsername": "azureuser",
      "ssh": {
        "publicKeys": [
          {
            "keyData": "[removed]"
          }
        ]
      }
    },
    "servicePrincipalProfile": {
      "clientId": "[removed]",
      "secret": "[removed]"
    }
  }
}

@ducas The majority of users wanted an RBAC story by default, which informed the decision to turn it on by default. You can turn it off by declaring this in your api model under the kubernetesConfig object:
"enableRbac": false

@jackfrancis yep - I thought that was the case... I just wanted to confirm it was intentional. I'm happy with having RBAC. Thanks!


Features to add to the model

This is the issue where we track features we want to consider adding.  If we decide to work on these, we can spin them off into tasks
-streetlights
-block size (smaller blocks significantly decrease crash rates per person)
-street trees

This is just a start, I just threw in things that I got from a quick glance at the presentation. @bpben @alicefeng @andhint @terryf82

We also have a few lists saved in our google drive:
https://docs.google.com/document/d/1cInH_207pvu8fI3J99frYpOi5ZGIT7um4FrxZoh1NIw/edit?usp=sharing
https://docs.google.com/document/d/1ye4AfAou--cARKrgdcVl_Se8yJD90ctIDEcY-G6DWFo/edit?usp=sharing

This is a similar problem (temporal-spatial) that I thought had some interesting features we might be able to pull in.
https://medium.com/data-from-the-trenches/predicting-crime-in-portland-oregon-184453cccd5b

Also adding link to https://www.dropbox.com/s/xlrnvyjg4fjkb7x/FINAL_PRESENTATION_V4.pdf?dl=0 so it's all in one place

Consolidated the wishlist: https://docs.google.com/document/d/1cInH_207pvu8fI3J99frYpOi5ZGIT7um4FrxZoh1NIw/edit
May need prioritization and then adding features as they are available.


Update README.md

[ ] I have read freeCodeCamp's contribution guidelines.
[ ] My pull request has a descriptive title (not a vague title like Update index.md)
[ ] My pull request targets the master branch of freeCodeCamp.
[ ] None of my changes are plagiarized from another source without proper attribution.
[ ] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

@ravish22 Thank you for submitting a pull request (PR). I have closed the PR because the changes you have made is either stylistically inconsistent with other files in the repository or do not improve anything.


Cash address contains uppercase and lowercase characters

I am unable to send BCH to standard P2PKH address.
It says "Cash address contains uppercase and lowercase characters", I read in documentation that bitcash supports Standard P2PKH transactions. How can I achieve this?

I am unable to send BCH to standard P2PKH address.
It says "Cash address contains uppercase and lowercase characters", I read in documentation that bitcash supports Standard P2PKH transactions. How can I achieve this?

I think BCH addresses only have lowercase characters. Could you send the address to confirm?

This is address I want to send funds: 1MTT8CrL9WPAeVJisRkTWvFCaAhGzzR4v2

This is address I want to send funds: 1MTT8CrL9WPAeVJisRkTWvFCaAhGzzR4v2

This is a BTC address. BitCash only support cashAddress format.
You can convert between the two formats there: https://bch.info/en/tools/cashaddr
⚠ Make sure you are sending to a BCH address ⚠ The funds will likely be lost forever if you send to the wrong network.


Fix audio capture naming in web export

Fix audio capture naming for Javascript web export. Fixes #31243

Thanks!


Use AtomicInteger for message counters

As described in comments of #212 by @windbender

should this be closed ?
I also dug a bit deeper and noticed:
    @Override
    public void incUsageCounter(MessageGUID guid) {
        IMessagesStore.StoredMessage storedMessage = m_persistentMessageStore.get(guid);
        storedMessage.incReferenceCounter();
        m_persistentMessageStore.put(guid, storedMessage);
    }

    @Override
    public void decUsageCounter(MessageGUID guid) {
        IMessagesStore.StoredMessage storedMessage = m_persistentMessageStore.get(guid);
        storedMessage.decReferenceCounter();
        m_persistentMessageStore.put(guid, storedMessage);
    }

Since these two methods are retrieving values and the "putting" values.   they need to be synchronized as they are written.
Likewise
    void removeStoredMessage(MessageGUID guid) {

has problems since ideally only a single thread should do the remove .

I removed the reference counting, prefer to copy the message data instead of sharing, it lowers the contention on shared data.


HA updated to 0.115.6, error unit_percantage.

Hi!
I updated home assistant to 0.115.6 today and now i get this message after restart.
"File "/config/custom_components/ferroamp/sensor.py", line 14, in
from homeassistant.const import (
ImportError: cannot import name 'UNIT_PERCENTAGE' from 'homeassistant.const' (/usr/src/homeassistant/homeassistant/const.py)"

Right after i posted, i saw your update.... "Dropping UNIT_ prefix on PERCENTAGE constant since renamed in HA 0.115.0" :)


Downloads broken on code.visualstudio.com (All Links)

Download links on code.visualstudio.com are broken.
Affected links:

https://update.code.visualstudio.com/latest/win32-x64-user/stable
https://update.code.visualstudio.com/latest/win32-x64/stable
https://update.code.visualstudio.com/latest/win32-x64-archive/stable
https://update.code.visualstudio.com/latest/linux-deb-x64/stable
https://update.code.visualstudio.com/latest/linux-rpm-x64/stable
https://update.code.visualstudio.com/latest/linux-x64/stable
https://update.code.visualstudio.com/latest/darwin/stable

I'm not listing them here, but Insider build downloads are broken also, for all platforms.

This is also breaking Remote - SSH
> Downloading with wget
> https://update.code.visualstudio.com/commit:94f7de61ece171f4390ece488a220d22cbb0fddd/server-linux-x64/insider: 2019-06-02 16:21:10 ERROR 500: Internal Server Error.

@Toxicable also breaking Remote - WSL

I can confirm that it breaks Remote-SSH downloading/updating. Same 500 error response.

As an aside, I really hope that this brittleness is removed once Remote goes live. There's no redundancies in place here, it should be checking if a slightly older version of the code is already located on said instances within an expected range.
I can't think of a worse nightmare than having to vim my way around WSL or a remote host because there's some third-party issue way out of my control.

It can download now!

It looks like this issue is solved just now.  I've tried to restart my Insider with Remote WSL enabled , and everything is normal now.  I also trying to some of links mentioned above, and it works now.

Then I will close this (unless there's an underlying problem and this should be open for reference). Glad to see everything working normally.

If this happens again I'm going to reopen this issue, since I see atleast 5 previous issues with the reliability of the update.code.visualstudio.com.


Add big-endian CI build

I was curious to validate statements about LE / BE stuff in Word16 modules and put up an s390x build. It's very rough indeed, so I'm fine with this being rejected, just wanted to share that it is green :)

Seems to succeed. So did this verify my claims?

Also, more context: https://github.com/hasufell/abstract-filepath/issues/12
The other solution would have been to do CPP dependent byte swapping, it seems. But that felt error prone wrt cross compiling etc.