Terasology now uses Java 17

Documentation Topic
As of #5162 being merged, Terasology now uses Java 17 for compilation. Whilst some documentation has been updated for this, there is likely more still that references Java 11 in places.
After pulling in 3aa68c04f192243575f7f78de5b6ce268bb2da1a, or with a fresh clone, you will need a Java 17 JDK to build and run the game. JDK 17 can be obtained from many sources. I personally find that the Eclipse Termurin (formerly AdoptOpenJDK) distribution tends to work.
If you are seeing errors like the following then you are probably still using JDK 11. You need to update to JDK 17 to fix this (make sure to update the JAVA_HOME environment variable as well).
A problem occurred configuring root project 'Terasology'.
> Could not determine the dependencies of null.
   > Could not resolve all task dependencies for configuration ':classpath'.
      > Could not resolve org.terasology.gradology:build-logic.
        Required by:
            project :
         > No matching variant of project :build-logic was found. The consumer was configured to find a library for use during runtime, compatible with Java 11, packaged as a jar, and its dependencies declared externally, as well as attribute 'org.gradle.plugin.api-version' with value '8.4' but:
             - Variant 'apiElements' capability org.terasology.gradology:build-logic:unspecified declares a library, packaged as a jar, and its dependencies declared externally:
                 - Incompatible because this component declares a component for use during compile-time, compatible with Java 17 and the consumer needed a component for use during runtime, compatible with Java 11
                 - Other compatible attribute:
                     - Doesn't say anything about org.gradle.plugin.api-version (required '8.4')
             - Variant 'mainSourceElements' capability org.terasology.gradology:build-logic:unspecified declares a component, and its dependencies declared externally:
                 - Incompatible because this component declares a component of category 'verification' and the consumer needed a library
                 - Other compatible attributes:
                     - Doesn't say anything about its target Java version (required compatibility with Java 11)
                     - Doesn't say anything about its elements (required them packaged as a jar)
                     - Doesn't say anything about org.gradle.plugin.api-version (required '8.4')
                     - Doesn't say anything about its usage (required runtime)

You may also see the following warning. We're aware of it and it is unlikely to be resolved soon. The game depends on SecurityManager as a part of module sandboxing.
WARNING: A terminally deprecated method in java.lang.System has been called
WARNING: System::setSecurityManager has been called by org.terasology.engine.core.module.ModuleManager (file:/engine/build/libs/engine-5.4.0-SNAPSHOT.jar)
WARNING: Please consider reporting this to the maintainers of org.terasology.engine.core.module.ModuleManager
WARNING: System::setSecurityManager will be removed in a future release

Documentation Type
Terasology Knowledge Base

@soloturn @PurityLake @lokytech5 @jdrueckert @skaldarnar - this might affect you.

Provided @skaldarnar and I write a milestone summary blogpost again, that's definitely going in there in bold :sweat_smile:

thanks for the heads up @BenjaminAmos ! as i never have a JAVA_HOME set i am wondering why you recommend to do so for terasology?

thanks for the heads up @BenjaminAmos ! as i never have a JAVA_HOME set i am wondering why you recommend to do so for terasology?

I did not intend to recommend it, just to advise that the variable should be changed if it exists. When working with multiple Java versions, setting the JAVA_HOME environment variable can be an easy way to switch between versions. Certain tools used to depend on the presence of the variable to identify where Java was installed. Most of the time having the right java install directory in your system path (the PATH environment variable) works the same..

May I know the actual Java version to set in JAVA_HOME?

If you have a JAVA_HOME environment variable set then you should change it to the location that Java 17 is installed in. For example, on Windows it might be installed in C:\Program Files\Eclipse Adoptium\jdk-<IP_ADDRESS>-hotspot. If you don't have that environment variable present then you do not need to do anything with it.

when exiting the game using "josharias survival" i get the following error:
11:16:51.570 [main] INFO  o.t.engine.core.TerasologyEngine - Shutting down Terasology...
11:16:51.595 [Chunk-Processing-Reactor] ERROR o.t.e.w.c.p.ChunkProcessingPipeline - Reactor thread was interrupted
java.lang.InterruptedException: null
        at java.base/java.util.concurrent.locks.ReentrantLock$Sync.lockInterruptibly(ReentrantLock.java:159)
        at java.base/java.util.concurrent.locks.ReentrantLock.lockInterruptibly(ReentrantLock.java:372)
        at java.base/java.util.concurrent.PriorityBlockingQueue.take(PriorityBlockingQueue.java:531)
        at org.terasology.engine.world.chunks.pipeline.ChunkExecutorCompletionService.take(ChunkExecutorCompletionService.java:83)
        at org.terasology.engine.world.chunks.pipeline.ChunkProcessingPipeline.chunkTaskHandler(ChunkProcessingPipeline.java:82)
        at java.base/java.lang.Thread.run(Thread.java:840)
11:16:51.703 [main] INFO  o.t.e.p.i.ReadWriteStorageManager - Saving - Creating game snapshot
11:16:51.780 [main] INFO  o.t.e.p.i.ReadWriteStorageManager - Saving - Snapshot created: Writing phase starts
11:16:51.815 [parallel-1] ERROR reactor.core.publisher.Operators - Operator called default onErrorDropped
reactor.core.Exceptions$ErrorCallbackNotImplemented: java.lang.reflect.InaccessibleObjectException: Unable to make field private final java.lang.Class java.lang.Class.componentType accessible: module java.base does not "opens java.lang" to unnamed module @f0da945
Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make field private final java.lang.Class java.lang.Class.componentType accessible: module java.base does not "opens java.lang" to unnamed module @f0da945
        at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:354)
        at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:297)
        at java.base/java.lang.reflect.Field.checkCanSetAccessible(Field.java:178)
        at java.base/java.lang.reflect.Field.setAccessible(Field.java:172)
        at org.terasology.persistence.typeHandling.coreTypes.factories.ObjectFieldMapTypeHandlerFactory.lambda$getResolvedFields$1(ObjectFieldMapTypeHandlerFactory.java:80)
        at java.base/java.security.AccessController.doPrivileged(AccessController.java:318)
        at org.terasology.persistence.typeHandling.coreTypes.factories.ObjectFieldMapTypeHandlerFactory.getResolvedFields(ObjectFieldMapTypeHandlerFactory.java:68)

nothing known which is open.


Only use the identity name of an included build in the IDEA module name if there is a conflict

This is a follow up to #14671 to preserver the previous behaviour for projects that already work in the IDE.
Theoretically, it should not matter what the name of the IDE project/module is as long as it is unique for each one.
Still, currently some of the IDEA Sync code depends on the previous behaviour to setup dependencies between included builds correctly.
#14671 changed the behaviour to always use the 'identity name' if available. We now revert to the previous behaviour of using the normal projects name. Instead, when we reach a point in the de-duplicator where we still have conflicts but cannot find a solution by adding more prefixes, we then change to use the identity name instead of the project name.

@bot-gradle test this

OK, I've already triggered ReadyForMerge build for you.


Make CDN build smaller

The CDN build is huge. Most of it is probably Node polyfills.
✓ 1609 modules transformed.
dist/browser/standalone.js  5,250.08 kB │ gzip: 1,181.41 kB

Let’s try to make it smaller.
Debugging
npx vite-bundle-visualizer -c vite.cdn.config.ts

At the first glance those make it big:

[ ] @scalar/swagger-editor (make a build without the swagger editor?)
[ ] CodeMirror
[x] icons (huge potential to reduce the build size)

It’s not really helpful to have a separate issue here. We can only improving the size over time and already do this. 👍


use monotonic time source

Given this:
https://blog.cloudflare.com/how-and-why-the-leap-second-affected-cloudflare-dns/
and the current state of the time.Now() call not being monotonic:
https://github.com/golang/go/blob/29cb72154d3bb3530d8092cc89d35b3ed4f7e9c5/src/runtime/sys_linux_amd64.s#L147
you may wish to prefer this:
https://github.com/glycerine/monotime
and replace calls to time.Now() with time.Unix(0, int64(monotime.Now()))

I read the other thread between you and @kozlovic. Will take a look in case we make an assumption, but do not think a change to the library you mention is required at this time. I do appreciate the issue however.


Missing license

You should add a license that makes it clear how this may be used.

I've added a license.


Add onLongPress to Buttons

Description
It is too hard to add onLongPress to Buttons. You need to add an InkWell that goes on top of another InkWell and this causes additional issues. You also need to deal with clipBehavior: Clip.antiAlias and onPressed from Button is required but needs to be empty. Two possible solutions to overcome the problem:

allow passing InkWell as a parameter (which would allow more advanced usages, like onDoubleTap or onHover).
just add a onLongPress parameter to buttons.

While I think there is room for both options, it was suggested I could pursue the second, which I really like and is good enough for me right now.
Related Issues
https://github.com/flutter/flutter/issues/40558
Tests
Should I add tests? If so, how? All of onPressed tests are focused on how it changes the color of Button, not on if it works or not.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I signed the [CLA].
[x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does report problems everywhere. I don't know how to use it, how do you use it? It looks like there are issues with const/icons/a lot of things. Not on this PR, but everywhere.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change.
[x] No, this is not a breaking change.

Material buttons, like most material components, handle long-press by showing a tooltip.  It's not clear that it would be useful to override this behavior. What's the use case?

There is no tooltip attribute for buttons. It only has a null onLongPress. I was making long press to show a Bottom Sheet with selectable options/settings.

You are right, buttons currently don't show a tooltip.
Should a button with only a longPress callback specified be disabled?  I don't think so, but supporting that will complicate this PR somewhat.
Tests are needed which verify that longPress input gestures do what's expected. If the existing onPressed tests aren't verifying that their callback is actually running, then we might as well do that here as well.

Done! @HansMuller I am having a hard time figuring out how to test my code (and the tests). I did two tests, but I'm not sure how to test them (weren't included  on the previous commit). Could you please shine some light (or update the contributing wiki documentation)? flutter test only works for samples. I want to test the material code I just modified.

You'll want to extend the tests in  packages/flutter/test/material/buttons_test.dart that verify that longPress is null by default. Similarly, add a test to the end of the file, like the one called 'MaterialButton disabled default is correct', which verifies that just setting longPress enables a button.

Tests are there. Please take a look.
I had a hard time testing the tests, because I don't know how to test them. I know there is no syntax issue in them, but I'm not sure if flutter tests is checking them or the multiple error messages (for unknown reasons) makes it exit before running the tests.

It might be from recent changes to flutter/dev/packages/flutter_test. Check to see if the Flutter repo you're working on is in sync with the current master branch

Thanks, @shihaohong! All tests are now passing. :)

There seems to still be analyzer test failures. You might want to fix those before requesting another review :)

Analyzer is fine. The issue is with: Whitespace detected at the end of source code lines. Please remove:
What is going on? Shouldn't there be a newline at the end of each file?

That refers to whitespace after a line. For example
var someDartVar = "Hello"; [extra space here]

packages/flutter/lib/src/material/button.dart:80:  ///
packages/flutter/lib/src/material/button.dart:87:  ///
packages/flutter/lib/src/material/button.dart:89:  ///
packages/flutter/lib/src/material/material_button.dart:93:  ///
packages/flutter/lib/src/material/material_button.dart:102:  ///

Oh, should work fine now, thanks! All of these are new to me.

No worries! I submitted an issue to improve the error message as well, since it was pretty confusing for me when I first bumped into this as well.

It seems the failing tests are caused by changed to debugFillProperties. Also, you still have to remove the ObjectFlagProperty for onPressed and onLongPress

lol, thanks! @shihaohong I am having a hard time figuring out stage vs stash vs commit on vscode and I guess that slipped. Should be fixed now.

I resolved a merge conflict caused by a separate PR that refactored some MaterialButton tests from buttons_test.dart into the material_button_test.dart. It should be good to go once the tree is green.


RFC: Allow to override global_commands

Description:
If a global command need to be updated, you cannot just override it, by placing a copy into the commands folder.
DDEV will notify you each run time about "not adding command ... because it was already added to project"
Describe the solution you'd like:
Prioritise commands from commands folder over .global_commands folder
Describe alternatives you've considered:
Alternatively we can add in the config.yaml array of
exclude_global_commands: [
'artisan',
'blackfire'
]
Additional context

Hi @bog-h - The way you override a global command is in ~/.ddev/commands. Remove the #ddev-generated in the command you want to override there.
Does that answer your question?

You never will change anything in .global_commands, ever. That's why it's hidden.
Global commands are defined in ~/.ddev/commands (that's in the .ddev folder in your home directory). Please change them there.

@rfay I appreciate your help but looks like you don't read my text and don't look at the screenshot where I even marked it with red lines to make it more comfortable to the reader.
Please say how to override .global_commads/web/artisan, if you want to tell me to create commands/web/artisan then please look at the screenshot and read the topic again.
If you would like to say that I need to remove a comment from commands/web/artisan then please look at the screenshot and read the topic again.
No offense, but I think you didn't read the topic well or I totally cannot understand your advice, sorry.

Here's how this works.

There are two kinds of shell commands, global and project.
Global commands are stored in your home directory, in the .ddev folder. So for example, the artisan command is in ~/.ddev/commands/web/artisan. If you want to override it, you would override it there by removing the #ddev-generated line from it. Then ddev will continue to use it but won't overwrite it.
Project-level commands are stored in your project directory, in .ddev/commands/web. If you happened to have an "artisan" command there, it will override the global one, but will complain and let you know that it's overriding.
The project .global_commands is a temporary copy of the global commands from your home directory. It's copied from the home directory global area on every ddev start and probably some other commands. It's not intended to be viewed or for you to even know it exists.

A PR with edits to the docs is welcome, you just click the pencil in the upper right.
You override the global artisan command by editing it in your home directory in ~/.ddev/commands/web/artisan, and removing the #ddev-generated line.

Thank you for the clear explanation!
The issue may be closed, however, I would like to say that it may be not a good idea to:
" If you happened to have an "artisan" command there, it will override the global one, but will complain and let you know that it's overriding."
Because it is the reason why this issue was created, I was sure that I did something wrong, with every run of my overridden command DDEV blames me starting with the phrase "not adding command.." and it looks like an error to be honest, at least adding "Info: your message" can help.

I think the basic thing is that the message needs to refer to the actual global command.
Currently it says

not adding command drush (/Users/rfay/workspace/d9/.ddev/.global_commands/web/drush) because it was already added to project d9

It should say

not adding global command drush (~/.ddev/commands/web/drush) because it was already added at the project level in project d9


Add toml-eslint-parser

Could you please add toml-eslint-parser to that list?
https://github.com/ota-meshi/toml-eslint-parser
close https://github.com/ota-meshi/toml-eslint-parser/issues/156

Thanks!


server error (500)

Hello,
I was trying to setup the plugin on my hass.io running on a RPi but I failed authorize the app.
Now I try to get my head around how this authorisation works.
Does Google need have direct access to the RPi in order to authorize this?
The RPi is just in my local network and I do not have any access to, from the outside. My entire network does not have any open ports exposed.
Is there another way to this work?
I do have setup and configured an application in the Google API that is used by the hass.io for the a calendar feature. This was also a pain to setup back then.
Is this maybe a Google temporary issue right now?
Thank you.

Google does not access your RPi. The authorization process takes place entirely between your web browser and Google. Google will give you a code that you will need to copy and paste into the add-on. The add-on will save that code on your RPi and will use that code to authenticate itself to Google.

OK, thank you.
Maybe I need to try this on my computer and not from my mobile phone.
I will report back how it goes.
Thank you.

Hi,
It just does not work.
I also disabled the PiHole, I switched to CloudFlare directly.
I did not saw in the PiHole logs anything blocked from my PI IP address.
Anyhow it is not that hard to just download the file to my Drive anyway.
Thanks anyway.


error An unexpected error occurred: "https://registry.yarnpkg.com/"sfdx-git-delta": Not found"

Summary
new sfdx plugins:install command based on yarn isn't working with sgd

Steps to reproduce

install<EMAIL_ADDRESS>run echo 'y' | sfdx plugins:install sfdx-git-delta

Why is sfdx trying to install the plugin from this registry https://registry.yarnpkg.com/%22sfdx-git-delta%22 instead of this one https://registry.yarnpkg.com/sfdx-git-delta ?

Never mind. My automation was running sfdx plugins:install "sfdx-git-delta" instead of sfdx plugins:install sfdx-git-delta


bsDuallistbox.js

Safe naming must be done otherwise we will have errors in minification

The file is already annotated and minified in the dist directory.

While using Microsoft bundling it bundles the original Js if no minified version is found so it would always be better to use safe naming

But there is a minified version in the package already... You should reference that one or force the .NET bundling to do so. Or, get rid of that useless system and use proper dev tools.

That's harsh... Always use safe naming.. :)

There's a preprocessor that does the job for me (ng-annotate), and pretty much every angular module that you'll find on GitHub uses the same approach of never including explicit annotations in source code.


Settings & common code cleanup

Summary of the new feature/enhancement
Split some #822 refactoring to a separate PR.

Postponed to 0.16.


ansible_swaptotal_mb == 0 when preinstall

[Bug REPORT]
I install with kubespray, and I exactly do the swapoff -a on my all machine, and the error still output
fatal: [master]: FAILED! => {
    "assertion": "ansible_swaptotal_mb == 0",
    "changed": false,
    "evaluated_to": false
}

How to do with for this  error message?
Thanks

Have you deleted your ansible fact caches? The config in this repo sets "fact_caching_connection = /tmp".

thanks you, I remove it and all things work.


Add RELEASE.md

Adapted from TensorFlow's running release notes.
Also includes release notes since the last release (2.1.4).

Great idea - I added it as a HOWTO_RELEASE.md document to the repo so everyone can access it & propose edits.


Build voodoo cli tools in docker container.

Work in progress Dockerfile for building the voodoo tools.
These can then be used in ocaml-docs-ci as an artifact and we could avoid building them from source. Still working on the ocurrent plumbing to start using these.
Note the use of a specific opam-repository git checkout effectively pins the universe of opam packages available.

This makes me slightly nervous, but only because voodoo-gen is still linking directly against odoc rather than executing it as a binary. If we can fix that then the voodoo cli tools are really just scripts that execute other tools, and I'm very happy to see them independent of the switch.


refactoring - no big change in the api

Fixed some issues, all tests passing, but 72d6c45 and 46f860b are only workarounds, may need some looking into, @deeenes.


Dynamic icon name

Im trying to use country-icons dynamically based on input, but Im having issues.
<script setup lang="ts">
import { Icon } from '#components'

const props = defineProps<{
  country: string
}>()

const icon = computed(() => {
  const icon = props?.country.toLowerCase()
  if (icon == 'northern ireland') {
    return 'ireland'
  }
  return icon
})
const FlagIcon = h(Icon, { name: 'twemoji:flag-' + icon.value, size: 18 })

</script>
<template>
  <FlagIcon />
</template>

This is working when loading the page SSR, but navigating to the page results in errors like this:
DR5f3n0Z.js:52 [Icon] failed to load icon 'twemoji:flag-hungary'
How can I create the icon names dynamically?

Can you provide a minimal reproduction? Thanks.

Why reproduction is required

Hi @antfu
Im not very familiar with repos so I hope that this is a generic example where someone can help me on how to fix it.


Morse Code Convertor using Vanilla JS #26

Pull Request for WebMasterLog 💡
Issue Title: Morse Code Convertor using Vanilla JS

Name of the project :  Morse code convertor
Category:  Vanilla-JS
Name: Aftab Mankapure
GitHub ID: https://github.com/AftabMankapure
Idenitfy yourself:  Contributor under JWOC

Closes:  #26

Describe the add-ons or changes you've made 📃
added  Morse Code Convertor using Vanilla JS #26
Type of change ☑

Added new feature Morse Code Convertor using Vanilla JS

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested? ⚙
Describe how it has been tested
Describe how have you verified the changes made
Checklist: ☑

[x] My code follows the Contributing Guidelines & Code of Conduct of this project.
[x] This PR does not contain plagiarized content.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly wherever it was hard to understand.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have added things that prove my fix is effective or that my feature works.
[x] Any dependent changes have been merged and published in downstream modules.

Screenshots 📷

Note to reviewers 📄

pls check this pr

check now


[Zlib] Issue with version override.

Downloading zlib128.zip
Failed to download zlib128.zip.
If you are using a proxy, please ensure your proxy settings are correct.
Possible causes are:

You are actually using an HTTP proxy, but setting HTTPS_PROXY variable to https//address:port.
This is not correct, because https:// prefix claims the proxy is an HTTPS proxy, while your proxy (v2ray, shadowsocksr, etc...) is an HTTP proxy.
Try setting http://address:port to both HTTP_PROXY and HTTPS_PROXY instead.
If you are using Windows, vcpkg will automatically use your Windows IE Proxy Settings set by your proxy software. See, https://github.com/microsoft/vcpkg-tool/pull/77
The value set by your proxy might be wrong, or have same https:// prefix issue.
Your proxy's remote server is our of service.
If you've tried directly download the link, and believe this is not a temporay download server failure, please submit an issue at https://github.com/Microsoft/vcpkg/issues
to report this upstream download server failure.
error: zlib port link generated: failed: status code 404
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:231 (message):
Download failed, halting portfile.
Call Stack (most recent call first):
C:/Users/james/AppData/Local/vcpkg/registries/git-trees/3309ec82cd96d752ff890c441cb20ef49b52bf94/portfile.cmake:3 (vcpkg_download_distfile)
scripts/ports.cmake:196 (include)

Hello, could you provide your vcpkg.json file?

FTR zlib 1.2.8 is from 2016. No fix expected.

old versions of zlib are here https://www.zlib.net/fossils/

FTR zlib 1.2.8 is from 2016. No fix expected.

A fix is not critical for me. However, that version is offered by vcpkg as a valid version if you give an invalid version. So that should be fixed if this bug will not be fixed.

vcpkg offers old versions regardless of availability of downloads. No fix expected.
Mitigation: Put the tarball manually into the downloads dir or an asset cache provider.


Different certfiles for different domainnames?

If I understand this role, if I have multiple domains in letsencrypt_domains, i.e
letsencrypt_domains [ example.com, example2.com ]
It will create one cert that is valid for both domains.
Is there an easy way to instead create separate certs for each domain, besides running the role multiple times and setting letsencrypt_domains in the playbook?

You could make a list of lists and have the role go through that in a loop.
But if you're going through the trouble of wanting to keep domain separately, I would set letsencrypt_domains at the inventory level for each domain.

Ah, well, the thing is that I have one nginx-server that acts as a reverse proxy for several applications behind that, so I serve about half a dozen or so different domains from one nginx-server.
Just doing separate lines in the playbook works, but something neater would be nice :)

You could make a list of lists and have the role go through that in a loop.

Hm, so something like this in the playbook would work?
letsencrypt_domains:    [ example.com ]    [ example2.com ]    [ example3.com ]

I have the same set up as you.
What I did was configure nginx to use the same certificate for each of those sites (my nginx roles lets you override the certificate name).
Would that work for you instead of going down the route of separate LE runs?

Well, yeah, that would work, but wouldn't that mean that if you look at the cert for example.com, you can see that it is also valid for example2.com, example3.com etc?

Yes, if someone inspected your certificates you would see each domain.

Mm...that's something I would like to avoid, but just running the role multiple times isn't a real problem, so I'll stick with that for now :)

This setup works just fine fyi
- hosts: proxy_server
  roles:
    - role: nginx-letsencrypt
      letsencrypt_domains: [example.org, www.example.org]
    - role: nginx-letsencrypt
      letsencrypt_domains: [example.se, www.example.se]


Add VidIQ

Backstory
I looked through the account settings page and couldn't find anything about account deletion. After a quick Google search I sumbled across a Video stating that the Account can only be deleted via a support request.
After sending a message to the Chat Bot on the Profile page, and then confirming the account deletion to that bot, I got this response:
The team will get back to you on this. vidIQ typically replies in a few hours.
Although a team member responded within 5 Minutes or so.
Data

name: VidIQ
url: https://app.vidiq.com/account/settings/my-account
notes: You have to cancel your Subscription before writing the Support (Bot)
difficulty: hard
domains: app.vidiq.com

Thanks for your contribution!


[WIP] Function to plot tax functions in 2 dimensions

This PR creates a new function in parameters_plots.py to aid users who wish to visualize tax function in 2 dimensions.  The new function, plot_2D_taxfunc, allows the user to enter lists dictionaries of tax function parameter estimates of the form output from OG-USA's tax function estimation, plot the function over labor or capital income, and specify the constant value of the other income source (that not represented on the x-axis). The resulting plot looks like:

This PR is still a work in progress.  The following items need to be addressed:

Add an optional argument where the user can supply a data frame of data create a scatter plot over which the functions are plotted.
Test the newly added tax.tax_rates() function.
See if something like the tax.tax_rates() function can help consolidate code that repeats the same (or similar) calculations of tax rates in tax.ETR_income, tax.MTR_income, and txfunc.get_tax_rates().

Codecov Report

Merging #629 into master will increase coverage by 0.07%.
The diff coverage is 92.53%.

@@            Coverage Diff             @@
##           master     #629      +/-   ##
==========================================
+ Coverage   84.06%   84.14%   +0.07%
==========================================
  Files          47       47
  Lines        6852     6917      +65
==========================================
+ Hits         5760     5820      +60
- Misses       1092     1097       +5

Impacted Files
Coverage Δ

ogusa/tax.py
96.65% <73.68%> (-1.75%)
:arrow_down:

ogusa/parameter_plots.py
69.63% <100.00%> (+2.57%)
:arrow_up:

ogusa/tests/test_parameter_plots.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ad7dce...b0053e2. Read the comment docs.

It took a while to figure out a nice way to compute weighted means by group, but able to get plots with scatter of rates by percentile in the data to show against the functions (not shown here, but you can have multiple data series to plot, e.g., both baseline and reform functions on plot with scatter of baseline and reform data):

Thanks @MaxGhenis for suggesting this.

Codecov Report

Merging #629 into master will decrease coverage by 0.17%.
The diff coverage is 92.53%.

@@            Coverage Diff             @@
##           master     #629      +/-   ##
==========================================
- Coverage   84.31%   84.14%   -0.18%
==========================================
  Files          47       47
  Lines        6969     6917      -52
==========================================
- Hits         5876     5820      -56
- Misses       1093     1097       +4

Impacted Files
Coverage Δ

ogusa/tax.py
96.65% <73.68%> (-1.75%)
:arrow_down:

ogusa/parameter_plots.py
69.63% <100.00%> (+2.57%)
:arrow_up:

ogusa/tests/test_parameter_plots.py
100.00% <100.00%> (ø)

regression/test_regression.py
39.34% <0.00%> (-7.04%)
:arrow_down:

ogusa/tests/test_user_inputs.py
60.71% <0.00%> (-4.92%)
:arrow_down:

ogusa/tests/test_basic.py
33.33% <0.00%> (-4.85%)
:arrow_down:

ogusa/tests/test_startyears.py
50.00% <0.00%> (-4.17%)
:arrow_down:

ogusa/tests/test_execute.py
72.00% <0.00%> (-3.00%)
:arrow_down:

ogusa/tests/test_run_ogusa.py
33.33% <0.00%> (-2.67%)
:arrow_down:

ogusa/tests/test_txfunc.py
66.66% <0.00%> (-1.80%)
:arrow_down:

... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b026a50...e8de308. Read the comment docs.

Just curious, does this chart reflect an actual fitting from OG-USA?

@MaxGhenis It doesn't - I was just testing and those data and the parameter estimates come from different policy.

This PR is close to finished (need to check code coverage issues).  While the initial intent was to simply add one more plotting utility that proves useful in visualizing and comparing tax functions, this addition lead to the consideration of how/where tax rates were computed in the model.
This PR now consolidates all the calculations of tax rates, which had been done in txfunc.py and tax.py into one function, txfunc.get_tax_rates().  Because the prior functions had specified different a different ordering of the tax function parameters, their is not a change to how the parameters are stored in arrays in the output of the tax function estimation, this resulted in changes in (1) the cached tax function files in OG-USA/ogusa/data/tax_functions and (2) changes in the arrays specified in test_SS.py, test_TPI.py, test_aggregates.py, test_txfunc.py.    In these test files, I changed the shape of arrays of tax function parameters in cached test data whenever possible.  For tests that use the cached baseline tax function files in OG-USA/ogusa/data/tax_functions (the tests of TPI.run_TPI), I had to update the cached output files that new results are tested against.

@rickecon This PR is ready to review.  The failures with code coverage are coming from coverage of test files, which we had tried to remove from the code coverage results, but apparently haven't done successfully.

@jdebacker . Looks great. Thanks for doing this.


Need help in dropping the mailboxer tables

This is my migration
class DropMailboxerReceipts < ActiveRecord::Migration[5.0]
def change
drop_table :mailboxer_receipts
drop_table :mailboxer_notifications
drop_table :mailboxer_conversations
drop_table :mailboxer_conversation_opt_outs
end
end
And I am getting these errors.
Running rails db:migrate on ⬢ fat-hre-434... up, run.6654
(1.2ms)  SELECT pg_try_advisory_lock(2008333635372579375);
ActiveRecord::SchemaMigration Load (0.8ms)  SELECT "schema_migrations".* FROM "schema_migrations"
Migrating to DropMailboxerReceipts<PHONE_NUMBER>1944)
(2.6ms)  BEGIN
==<PHONE_NUMBER>1944 DropMailboxerReceipts: migrating ============================
-- drop_table(:mailboxer_receipts)
(6.0ms)  DROP TABLE "mailboxer_receipts"
-> 0.0065s
-- drop_table(:mailboxer_notifications)
(4.0ms)  DROP TABLE "mailboxer_notifications"
-> 0.0053s
-- drop_table(:mailboxer_conversations)
(2.2ms)  DROP TABLE "mailboxer_conversations"
(0.8ms)  ROLLBACK
(1.0ms)  SELECT pg_advisory_unlock(2008333635372579375)
rails aborted!
StandardError: An error has occurred, this and all later migrations canceled:
PG::DependentObjectsStillExist: ERROR:  cannot drop table mailboxer_conversations because other objects depend on it
DETAIL:  constraint mb_opt_outs_on_conversations_id on table mailboxer_conversation_opt_outs depends on table mailboxer_conversations
HINT:  Use DROP ... CASCADE to drop the dependent objects too.
: DROP TABLE "mailboxer_conversations"
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/connection_adapters/postgresql/database_statements.rb:98:in async_exec' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/connection_adapters/postgresql/database_statements.rb:98:in block in execute'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/connection_adapters/abstract_adapter.rb:566:in block in log' /app/vendor/bundle/ruby/2.3.0/gems/activesupport-5.0.0.rc2/lib/active_support/notifications/instrumenter.rb:21:in instrument'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/connection_adapters/abstract_adapter.rb:560:in log' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/connection_adapters/postgresql/database_statements.rb:97:in execute'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/connection_adapters/postgresql/schema_statements.rb:146:in drop_table' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:845:in block in method_missing'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:814:in block in say_with_time' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:814:in say_with_time'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:834:in method_missing' /app/db/migrate/20160629211944_drop_mailboxer_receipts.rb:5:in change'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:788:in exec_migration' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:772:in block (2 levels) in migrate'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:771:in block in migrate' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/connection_adapters/abstract/connection_pool.rb:398:in with_connection'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:770:in migrate' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:950:in migrate'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:1211:in block in execute_migration_in_transaction' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:1279:in block in ddl_transaction'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/connection_adapters/abstract/database_statements.rb:232:in block in transaction' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/connection_adapters/abstract/transaction.rb:189:in within_new_transaction'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/connection_adapters/abstract/database_statements.rb:232:in transaction' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/transactions.rb:211:in transaction'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:1279:in ddl_transaction' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:1210:in execute_migration_in_transaction'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:1183:in block in migrate_without_lock' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:1182:in each'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:1182:in migrate_without_lock' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:1131:in block in migrate'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:1298:in with_advisory_lock' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:1131:in migrate'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:1005:in up' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:983:in migrate'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/tasks/database_tasks.rb:161:in migrate' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/railties/databases.rake:58:in block (2 levels) in <top (required)>'
/app/vendor/bundle/ruby/2.3.0/gems/railties-5.0.0.rc2/lib/rails/commands/rake_proxy.rb:13:in block in run_rake_task' /app/vendor/bundle/ruby/2.3.0/gems/railties-5.0.0.rc2/lib/rails/commands/rake_proxy.rb:10:in run_rake_task'
/app/vendor/bundle/ruby/2.3.0/gems/railties-5.0.0.rc2/lib/rails/commands/commands_tasks.rb:51:in run_command!' /app/vendor/bundle/ruby/2.3.0/gems/railties-5.0.0.rc2/lib/rails/commands.rb:18:in <top (required)>'
/app/bin/rails:4:in require' /app/bin/rails:4:in '
ActiveRecord::StatementInvalid: PG::DependentObjectsStillExist: ERROR:  cannot drop table mailboxer_conversations because other objects depend on it
DETAIL:  constraint mb_opt_outs_on_conversations_id on table mailboxer_conversation_opt_outs depends on table mailboxer_conversations
HINT:  Use DROP ... CASCADE to drop the dependent objects too.
: DROP TABLE "mailboxer_conversations"
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/connection_adapters/postgresql/database_statements.rb:98:in async_exec' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/connection_adapters/postgresql/database_statements.rb:98:in block in execute'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/connection_adapters/abstract_adapter.rb:566:in block in log' /app/vendor/bundle/ruby/2.3.0/gems/activesupport-5.0.0.rc2/lib/active_support/notifications/instrumenter.rb:21:in instrument'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/connection_adapters/abstract_adapter.rb:560:in log' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/connection_adapters/postgresql/database_statements.rb:97:in execute'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/connection_adapters/postgresql/schema_statements.rb:146:in drop_table' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:845:in block in method_missing'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:814:in block in say_with_time' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:814:in say_with_time'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:834:in method_missing' /app/db/migrate/20160629211944_drop_mailboxer_receipts.rb:5:in change'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:788:in exec_migration' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:772:in block (2 levels) in migrate'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:771:in block in migrate' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/connection_adapters/abstract/connection_pool.rb:398:in with_connection'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:770:in migrate' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:950:in migrate'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:1211:in block in execute_migration_in_transaction' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:1279:in block in ddl_transaction'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/connection_adapters/abstract/database_statements.rb:232:in block in transaction' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/connection_adapters/abstract/transaction.rb:189:in within_new_transaction'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/connection_adapters/abstract/database_statements.rb:232:in transaction' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/transactions.rb:211:in transaction'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:1279:in ddl_transaction' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:1210:in execute_migration_in_transaction'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:1183:in block in migrate_without_lock' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:1182:in each'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:1182:in migrate_without_lock' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:1131:in block in migrate'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:1298:in with_advisory_lock' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:1131:in migrate'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:1005:in up' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:983:in migrate'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/tasks/database_tasks.rb:161:in migrate' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/railties/databases.rake:58:in block (2 levels) in <top (required)>'
/app/vendor/bundle/ruby/2.3.0/gems/railties-5.0.0.rc2/lib/rails/commands/rake_proxy.rb:13:in block in run_rake_task' /app/vendor/bundle/ruby/2.3.0/gems/railties-5.0.0.rc2/lib/rails/commands/rake_proxy.rb:10:in run_rake_task'
/app/vendor/bundle/ruby/2.3.0/gems/railties-5.0.0.rc2/lib/rails/commands/commands_tasks.rb:51:in run_command!' /app/vendor/bundle/ruby/2.3.0/gems/railties-5.0.0.rc2/lib/rails/commands.rb:18:in <top (required)>'
/app/bin/rails:4:in require' /app/bin/rails:4:in '
PG::DependentObjectsStillExist: ERROR:  cannot drop table mailboxer_conversations because other objects depend on it
DETAIL:  constraint mb_opt_outs_on_conversations_id on table mailboxer_conversation_opt_outs depends on table mailboxer_conversations
HINT:  Use DROP ... CASCADE to drop the dependent objects too.
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/connection_adapters/postgresql/database_statements.rb:98:in async_exec' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/connection_adapters/postgresql/database_statements.rb:98:in block in execute'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/connection_adapters/abstract_adapter.rb:566:in block in log' /app/vendor/bundle/ruby/2.3.0/gems/activesupport-5.0.0.rc2/lib/active_support/notifications/instrumenter.rb:21:in instrument'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/connection_adapters/abstract_adapter.rb:560:in log' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/connection_adapters/postgresql/database_statements.rb:97:in execute'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/connection_adapters/postgresql/schema_statements.rb:146:in drop_table' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:845:in block in method_missing'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:814:in block in say_with_time' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:814:in say_with_time'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:834:in method_missing' /app/db/migrate/20160629211944_drop_mailboxer_receipts.rb:5:in change'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:788:in exec_migration' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:772:in block (2 levels) in migrate'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:771:in block in migrate' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/connection_adapters/abstract/connection_pool.rb:398:in with_connection'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:770:in migrate' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:950:in migrate'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:1211:in block in execute_migration_in_transaction' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:1279:in block in ddl_transaction'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/connection_adapters/abstract/database_statements.rb:232:in block in transaction' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/connection_adapters/abstract/transaction.rb:189:in within_new_transaction'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/connection_adapters/abstract/database_statements.rb:232:in transaction' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/transactions.rb:211:in transaction'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:1279:in ddl_transaction' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:1210:in execute_migration_in_transaction'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:1183:in block in migrate_without_lock' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:1182:in each'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:1182:in migrate_without_lock' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:1131:in block in migrate'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:1298:in with_advisory_lock' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:1131:in migrate'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:1005:in up' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/migration.rb:983:in migrate'
/app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/tasks/database_tasks.rb:161:in migrate' /app/vendor/bundle/ruby/2.3.0/gems/activerecord-5.0.0.rc2/lib/active_record/railties/databases.rake:58:in block (2 levels) in <top (required)>'
/app/vendor/bundle/ruby/2.3.0/gems/railties-5.0.0.rc2/lib/rails/commands/rake_proxy.rb:13:in block in run_rake_task' /app/vendor/bundle/ruby/2.3.0/gems/railties-5.0.0.rc2/lib/rails/commands/rake_proxy.rb:10:in run_rake_task'
/app/vendor/bundle/ruby/2.3.0/gems/railties-5.0.0.rc2/lib/rails/commands/commands_tasks.rb:51:in run_command!' /app/vendor/bundle/ruby/2.3.0/gems/railties-5.0.0.rc2/lib/rails/commands.rb:18:in <top (required)>'
/app/bin/rails:4:in require' /app/bin/rails:4:in '
Tasks: TOP => db:migrate
(See full trace by running task with --trace)
suramai@rails-tutorial:~/workspace/converse (master) $
Can someone help me drop the mailboxer tables?

Hello. I have no experience with this as I am just evaluating mailboxer for my project.  However, the error advises you to use cascade. Have you tried this yet?
HINT: Use DROP ... CASCADE to drop the dependent objects too.
This link may help: http://stackoverflow.com/questions/16928668/rails-create-a-drop-table-cascade-migration
good luck!

Yep, @dom-dom-dom is one solution. Another one would be to drop first mailboxer_conversations_opt_outs. In any case, I think this can be closed.


Interactive Rendering Engine

Description

The interactive rendering engine would be designed to be as close to HTML elements as possible and their properties. The item schema will contain the component, and it's attributes. All components can have custom styles, but inherit the default configured styles from the users' settings.
The engine should allow dragging and dropping components based on a grid, and resizing them relative to the columns and rows present. To add a component a grid cell can be clicked.
All components have a read-only variant. Most components have a write variant as well which can be hooked up to any exposed internal operation or (reactive) state.
Some components could have additional decorators, like inputs to place an icon at the start or end inside the input box. This may change to something flexible later on, however it does bring forward that custom SVGs should also be configurable.
Any component can be composed together with others to create a template, these templates should be reusable.
Additionally some very custom components may be implemented through some form of plugin system if none of HTML elements individually or combined, can solve the needed use case.
The engine can be very useful as standalone HTML generator. Creating a library out of it, and being able to integrate either it as runtime or generate static HTML would be ideal (maybe even a hybrid).
Components

Component
Description
Variants
Allowed descendants

div
Renders text, the component records which characters are per each of the following options: italic, bold, strikeout, heading, sub, sup, font, marking. The text may wrap around nested elements.
Markdown
Any* (Markdown uses it's own style)

input
The input can have decorators depending on the type to e.g. make a password field, to add icons or a label
single-line, multi-line, time, date-time, date, radio, check, number, file, color
Decorators

select

Decorators

button

Decorators

link

Decorators

aside

Any

audio

Decorators

break

None

separator

None

figure
Displays anything a <canvas> or <img> tag can do.

code

details
Can hide content, supports a summary

Any

dialog

Any

list

embed

None

progress

Decorators

table
Dedicated component to render borders for each cell in any style imaginable. The component should allow for sorting.

Any

video

<fieldset>
<nav>
<footer>
<form>
<label>
<menu>
<object>
<portal> Experimental
<var>

Requirements

[ ] Component grid is implemented.

[ ] The component grid can be edited after entering (interactive) edit mode.
[ ] Rows and columns can be adjusted.
[ ] Clicking a cell shows a list of available components.
[ ] Selecting a component from the list add it to the cell.
[ ] Clicking the component

[ ] All components are implemented.

[ ] All relevant attributes are available.

[ ] Figure out how to make this intuitive.

Attributes could be listed in a floating menu.
Variable attributes may be adjustable intuitively through direct "interactable" controls.
Options may be best part of the floating menu.

[ ] Descendants are implemented.

[ ] Appropriate decorator options are implemented.

[ ] All components have a reasonable default style-sheet.

[ ] Components can access any state available
[ ] Components can access any operation to execute.
[ ] Components can be read from and tracked, ref #39.
[ ] Component templates can be added/changed/removed.

[ ] Figure out how to make this intuitive.

Any components can be saved from the context-menu and end up under templates instead of components.
Saving requires a unique name.

[ ] Custom styles can be added/changed/removed.

[ ] Figure out how to make this intuitive.

Refer to attribute implementation.

[ ] Custom SVGs can be added/changed/removed in appearance settings.
[ ] A distinction must be made between Spaced controls, and items.

[ ] Both should use the engine.
[ ] Only Spaced controls should also be directly changeable using JSON configs.
[ ] Spaced controls may only be changed in (interactive) edit mode.
[ ] Items may only be changed using the engine when only one element specifically is selected.

Ref #24, #25

The concept of decorators and allowed descendants, should maybe change to just descendants as decorators threaten to reintroduce what components already inherently do.

The default theme itself must also be configurable as per https://github.com/Ekhorn/spaced/issues/4

Missing

Default controls such as: drag & dropping and descendant to any component allowing a descendant, deleting a component at any level, adding a component directly inside another component.

...

Should consider menu's such as context-menu's.


build error: Ignoring child directory app: unable to import "app"

I followed the instructions to run make to build the project, but got the following error:
go generate ./pkg/... ./cmd/...
W1211 17:50:55.153079   48977 parse.go:239] Ignoring child directory app: unable to import "app": cannot find package "app" in any of:
	/usr/lib/xxx-golang/src/app (from $GOROOT)
	/usr/local/xxx/home/xxx/go/src/app (from $GOPATH)
...

My Go version is 1.13.4.

closing this. Since with newer changes make works.
/close


SimmulatedAnnealingPrune inifinite loop

Describe the issue:
Environment:

NNI version: 2.6
Training service (local|remote|pai|aml|etc):remote
Client OS: Ubuntu 18
Server OS (for remote mode only): Ubuntu 18
Python version: 3.6.9
PyTorch/TensorFlow version: PyTorch 1.8.1+cu111
Is conda/virtualenv/venv used?: no
Is running in Docker?: yes

Configuration:

Experiment config (remember to remove secrets!):
Search space:

Log message:

nnimanager.log:
dispatcher.log:
nnictl stdout and stderr:

How to reproduce it?:
I would like to know the function of :
                else:
                    delta_E = np.abs(evaluation_result -
                                     self._current_performance)
                    probability = math.exp(-1 * delta_E /
                                           self._current_temperature)
                    if np.random.uniform(0, 1) < probability:
                        self._current_performance = evaluation_result
                        self._sparsities = sparsities_perturbated
                        break

I get probability values between 1e-11 and 1e-7 and it never breaks from the loop to the next iteration. And I have to restart the script

I understand now that if you use other metrics that are not between 0-1, the probability values are too low and it will never end the loop. So, if you use RMSE in mm for example, probability values can be too low. Be sure to change it to fit this code.


Add 1.17 to supported NumPy versions

Part of https://github.com/chainer/chainer/issues/7741

pfnCI, test this please.

Jenkins CI test (for commit fbb8be615b967bbb5986e8f789fceeb8733098db, target branch master) failed with status FAILURE.


Deploying smart contract

Hi,
I have deployed my first smart contract.
I have used this command :
neo> import contract ./contracts/AddTest1.avm 02020202 02 False False
contract properties: 0
Please fill out the following contract details:
[Contract Name] > New Smart Contract
[Contract Version] > v0
[Contract Author] > Nobody
[Contract Email] ><EMAIL_ADDRESS>[Contract Description] > Test my first smart contract
Creating smart contract....
                 Name: New Smart Contract
              Version: v0
               Author: Nobody
                Email<EMAIL_ADDRESS>          Description: Test my first smart contract
        Needs Storage: False
 Needs Dynamic Invoke: False
{
    "hash": "429179538333530493fc4e10770e8696948ef1c9",
    "returntype": "02",
    "script": "59c56b6c766b00527ac46c766b51527ac46c766b52527ac46c766b53527ac46c766b00c352956c766b54527ac46c766b51c351936c766b55527ac46c766b52c352966c766b56527ac46c766b53c351946c766b57527ac46203006c766b54c36c766b55c3936c766b56c3936c766b57c393616c7566",
    "parameters": "02020202"
}
self contract properties: 0
[I 180208 13:36:43 EventHub:71] [test_mode][SmartContract.Execution.Success] [891c33e84a5b1d9b71ac6cce0290015b10e0ae65] ['{\n    "properties": {\n        "dynamic_invoke": false,\n        "storage": false\n    },\n    "description": "Add",\n    "email": "test@test.com",\n    "author": "Ethan Fast",\n    "code_version": "1",\n    "version": 0,\n    "code": {\n        "hash": "429179538333530493fc4e10770e8696948ef1c9",\n        "returntype": 5,\n        "script": "59c56b6c766b00527ac46c766b51527ac46c766b52527ac46c766b53527ac46c766b00c352956c766b54527ac46c766b51c351936c766b55527ac46c766b52c352966c766b56527ac46c766b53c351946c766b57527ac46203006c766b54c36c766b55c3936c766b56c3936c766b57c393616c7566",\n        "parameters": "05"\n    },\n    "name": "Add"\n}']
Used 100.0 Gas
-------------------------------------------------------------------------------------------------------------------------------------
Test deploy invoke successful
Total operations executed: 11
Results ['IOp Interface: <neo.Core.State.ContractState.ContractState object at 0x7ff08ef4a828> ']
Deploy Invoke TX GAS cost: 90.0
Deploy Invoke TX fee: 0.0
-------------------------------------------------------------------------------------------------------------------------------------
Enter your password to continue and deploy this contract
[password]>
[I 180208 13:37:25 Transaction:598] Verifying transaction: b'a9f36a437d5adfd99be34adb5a3eabdf58546ffebcb15adb947291b5a2eee6a0'
[I 180208 13:37:25 EventHub:89] [SmartContract.Verification.Success][1116196] [8ff27e8fe1cb19e3906cdefe62a88dd2bfa68e1c] [tx a9f36a437d5adfd99be34adb5a3eabdf58546ffebcb15adb947291b5a2eee6a0] [True]
Relayed Tx: a9f36a437d5adfd99be34adb5a3eabdf58546ffebcb15adb947291b5a2eee6a0

When I use the command to search my contract I get that :
neo> contract<PHONE_NUMBER>33530493fc4e10770e8696948ef1c9
self contract properties: 0
{
    "properties": {
        "dynamic_invoke": false,
        "storage": false
    },
    "description": "Add",
    "email"<EMAIL_ADDRESS>
    "author": "Ethan Fast",
    "code_version": "1",
    "version": 0,
    "code": {
        "hash": "429179538333530493fc4e10770e8696948ef1c9",
        "returntype": 5,
        "script": "59c56b6c766b00527ac46c766b51527ac46c766b52527ac46c766b53527ac46c766b00c352956c766b54527ac46c766b51c351936c766b55527ac46c766b52c352966c766b56527ac46c766b53c351946c766b57527ac46203006c766b54c36c766b55c3936c766b56c3936c766b57c393616c7566",
        "parameters": "05"
    },
    "name": "Add"
}

neo> contract search Nobody
Found 0 results for Nobody

The author of this contract is :

"email"<EMAIL_ADDRESS>"author": "Ethan Fast",

But the author of my contract is :

Author: Nobody
Email<EMAIL_ADDRESS>
We have the same hash contract.
I have paid the 90 GAS to deploy the contract so I think it is on the testnet Blockchain
but I don't know where.
Have you had ever this problem ?
Thanks in advance

The script hash of this contract is already in use, so unfortunately the one that exists will not be replaced.  If you change the contract slightly, you will not have this issue.

That means, in general, if we want to load a smart contract on the testnet blockchain we need to :

import the contract : import contract ./contracts/file.avm
fill the contract details
retreive the hash of the contract
cancel the command
use the command contract hashContract  to see if there is no hash collision with a other contract
And then relaunch the command import contract ./contracts/file.avm to load definitly the contract

Is it correct?
is there the same problem on the mainchain?

only if you are reusing an example 1:1, but for this you should be using a private network anyway! the testnet should only be used in the very last stage of development.
https://hub.docker.com/r/metachris/neo-privnet-with-gas/


Did not build and run for me

Is there a ZIO and ScalaJS example that works anywhere?
Referring to non-existent class java.time.Duration
[error] Referring to non-existent class java.time.Duration
[error]   called from private zio.ZIO$.$init$$$anonfun$1()java.time.Duration
[error]   called from constructor zio.ZIO$.<init>()void
[error]   called from zio.ZFiberRef$.make(scala.Function0,scala.Function1,scala.Function2,java.lang.Object)zio.ZIO
[error]   called from zio.ZState$.make(scala.Function0,java.lang.Object)zio.ZIO
[error]   called from zio.ZState$.makeLayer(scala.Function0,izumi.reflect.Tag,java.lang.Object)zio.ZLayer
[error]   called from private App$.run$$anonfun$1()zio.ZLayer
[error]   called from App$.run()zio.ZIO
[error]   called from private zio.ZIOApp.invoke$$anonfun$5$$anonfun$4$$anonfun$4(java.lang.Object,zio.ZLayer,zio.Runtime)zio.ZIO
[error]   called from private zio.ZIOApp.invoke$$anonfun$6$$anonfun$5(java.lang.Object,zio.ZLayer,java.lang.Object)zio.ZIO
[error]   called from private zio.ZIOApp.invoke$$anonfun$1(zio.Chunk,java.lang.Object)zio.ZIO
[error]   called from zio.ZIOApp.invoke(zio.Chunk,java.lang.Object)zio.ZIO
[error]   called from App$.invoke(zio.Chunk,java.lang.Object)zio.ZIO
[error]   called from zio.ZIOAppPlatformSpecific.main([java.lang.String)void
[error]   called from App$.main([java.lang.String)void
[error]   called from static App.main([java.lang.String)void
[error]   called from core module module initializers
[error] involving instantiated classes:
[error]   zio.ZFiberRef$
[error]   zio.ZState$
[error]   App$

Sorry for the inconvenience @PhilAndrew , I forgot to update it. According to:
https://zio.dev/next/overview/overview_platforms
You need to provide your own date lib, I've added one now. I also got stuck on this. Not sure how to document it better. Maybe the actually error message could be clearer from the ZIO side.

Thanks a lot!


Moving just one block quickly resets the walking animation

https://gyazo.com/c6057523bcc8ba850e7b7799946d8d6c

If you use @speed 0, it jumps to the block, instead of executing the animation more fast until reaches the position you clicked to.

The animation should not reset by doing this

Official client has a walkDelay

I managed to successfully emulate this delay:
I declared a move_start_time: as global variable
    let mut move_start_time = Instant::now();

then a 600 ms check and I reset move_start_time player moved
                        UserEvent::RequestPlayerMove(destination) => {
                            if !entities.is_empty() && (move_start_time.elapsed().as_millis() > 600) {
                                networking_system.request_player_move(destination)
                                move_start_time = Instant::now();
                            }
                        }

I tested it just now and I think it's fine, but I would love some more input on this from other people. I myself am not 100% sure that a walk delay is the right solution in fear that the player might feel sluggish and unresponsive. So it would be great everyone could test #36 and give some feedback

I think code for a walk delay (not necessarily the way I did it) should be added because it's official behavior and people are used to it. Duration of this delay could be set to 0 and people are free to add the delay they feel is acceptable (?)

I think there is value in code implementing a walk delay (not necessarily the way I did it) because it's official behavior and people are used to it.
I don't disagree with this, and if the general response on #36 is good I am all for merging it. Like I said, just want some more feedback from other people

There may be a fix to prevent characters stuttering when mashing left click to move and animation resetting when changing direction, a fix that much less impacts the responsiveness of the game.
The idea is not to restart animation when character is already walking.
I committed the change to a branch in my fork but didn't do a PR because I felt opening a second PR for the same issue would be bad, but at the same time it doesn't necessarily supersedes the PR I did earlier...
No Walk Animation Reset When Spamming Right-Click

There may be a fix to prevent characters stuttering when mashing left click to move and animation resetting when changing direction, a fix that much less impacts the responsiveness of the game. The idea is not to restart animation when character is already walking.
I committed the change to a branch in my fork but didn't do a PR because I felt opening a second PR for the same issue would be bad, but at the same time it doesn't necessarily supersedes the PR I did earlier... No Walk Animation Reset When Spamming Left-Click

This is what I talking about, can you send a gif of how it turned out?

Here with the fix in place I mash left-click.
https://github.com/vE5li/korangar/assets/4411178/4146d990-2bad-4eab-9ad4-7a7abbf23330

@gustavobca Here with the fix that prevents animation from resetting in place I mash left-click.

Fix from PR more or less looks the same except it completely prevents walking until 300 ms have passed which means a loss of responsiveness.

It looks good, what can be done also not reset if the time from one walk to the other is less than the player's speed converted to ms (must have the formula in the same file)

I implemented @eleriaqueen's approach of not resetting the animation if it's already playing and personally I think it works really well. So I'm closing this issue as of https://github.com/vE5li/korangar/commit/ddaefc224ffc7e368a99b96e6f16e460449377e3


Issue with Importing Modules in training_classification.py

Could you please provide guidance on which version of Keras and TensorFlow should be used to ensure compatibility with this code?

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."


puppet abstract class

see https://github.com/wechaty/go-wechaty/issues/11

@SilkageNet If you have time, please help me review


Update compatibility with recent Elixir and OTP versions

:+1:

Any update on whether this is likely to be merged? @vishnevskiy ?

It currently has conflicts, after that I can merge it.


auth: remember to close http client responses body

Per http module documentation.
Please review carefully as this is only build tested and that i'm not a go programmer :)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


A byname app that needs a module must register the module before itself

Don't know how to do this.
 But it remains "in charge". This registration happens in these two rules.
com.vcpnews.fav-color should use css3colors as a module, but can't register the module after it is installed, because it would need to use the module.

We need some way for a byname app to do this kind of thing, and communicate it to app developers.

What about a rule in Wrangler that the child could invoke on the parent so that the parent could do it for the child?

Have implemented a workaround. The participant can now manually install needed modules before they add a new app.


IOD-125 Create DeploymentConfig object

Description
This PR includes the following proposed change(s):
IOD-125
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Refactoring / Documentation
[ ] Version change

if your change is a breaking change, please add breaking change label to this PR
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Does the change impact or break the Docker build?

[ ] Yes
[x] No

If Yes: Has Docker been updated accordingly?

[ ] Yes
[x] No

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[x] New and existing unit tests pass locally with my changes

Those are just log inputs from the last time the image trigger was changed. They're auto-generated lines inserted by openshift.


[ANALYSIS] Intact & Dissolve should be also present when doing a buffer and not only an area of influence

Attaching screenshot. That boundaries options should also appear when doing by distance and not only by time

cc/ @xavijam

By distance option does not support those values atm, so would have to be changed on the camshaft reference and the maps API first, would this be doable @rochoa ?

It should be changed in camshaft.

I don't get the "by" when pick "distance"

Which opens a different question. How do we differentiate between linear and routing distance (since the buffer is going to disappear)?  cc @saleiva

forget about it

Seemed easy enough to implement (just adding the field definitions basically) but notices some issues related to this:

According to the camshaft reference v0.10.0 buffer type should support dissolved as an optional param, but when its set it actually implicitly requires the isolines param (also indicated as optional) to also be present (the maps API throws Dissolved mode requires a number > 1 for "isolines" param).
These restrictions are not captured by the reference, so would have to implement custom validation logic to avoid the faulty/inconsistent state then. cc @rochoa
Furthermore, being optional params, shouldn't the UI allow to deselect/reset these values?

How do you want to proceed?

I make it that way because for me it didn't make that much sense to dissolve when there are no isolines. For now I will remove that restriction.
Have in mind this could happen: having an optional param depending on other optional param. In the future we can do something like:
"dissolved": {
  "type": "boolean",
  "optional": true,
  "requires": ["isolines"]
}

Yeah, I figured but wasn't sure we wanted to complicate the reference more right now. Anyway, I think the 2nd point should be attended either way, so I await a reply on that before doing anything. 😘

BTW https://github.com/CartoDB/camshaft/pull/46 just got merged, next release will remove the issue with Dissolved mode requires a number > 1 for "isolines" param.


"Modbus" vs "ModBus"

The Modbus Organization specifically defines "Modbus" as the correct capitalization
Several instances of "ModBus" observed in UI video
NA
Normalize all spellings to Modbus
Reproducer code
Details

Affected HiveMQ Edge version(s):
Used JVM version:

Good catch, thanks for reporting!


Primary Key & Foreign Key not shown

Hi, I really love this tool. I would like to know is it possible to output the primary key & foreign key label ?
The command I use:
mermerd --encloseWithMermaidBackticks \
    -c "postgresql://${DB_USER}:${DB_PASS}@${DB_HOST}:${DB_PORT}/${DB_NAME}?sslmode=${DB_SSL_MODE}" \
    --outputFileName ./doc/erd.md \
    --schema public \
    --useAllTables \
    --showAllConstraints

I expect something like this:
erDiagram
    users ||--o{ books: own

users {
    uuid id "pk"
    text email
    text password_hash
    text name
    text role
    text status
}

books {
    uuid id "pk"
    uuid owned_by "fk"
}

Hi, glad you find the tool useful :)
This feature is on the roadmap in the readme - now that I know that someone actually needs it I will add it sooner.
I will inform you when the features is released.

This feature will be available in the next release and is active by default. If you want to omit the attributes you can set the config --omitAttributeKeys
The only thing that is not supported (by mermaid itself) - you cannot mark a attribute both PK and FK.
As long as mermaid does not support this, mermerd will use PK as key if it is both a PK and FK

This feature is now available in version 0.4.0
Please let me know if it does not work as intended


Contact association field level metadata

Enhancing the ContactAssociation model to include a list of specific model instance fields that the association applies to. This allows of the "ownership" and related use cases for the model metadata featureset.
In the future, like #5664 we will do things in the UI like hovering over a model instance field to view the contact details, but for now that is out of scope.

The UI for specifying fields should be a selection dropdown.

Instead of this, we will first try to just add a contact FK directly to the Metadata object instance model.


Include a new category for IBC

chain.json should include a category called ibc with at least the following:

ibc_go_version
ibc_enabled (true / false)
supported_ics

I think this is a great idea, @nooomski
Regarding ibc_go_version, what would be provided if the chain isn't using ibc-go at all? would it just not be provided? Could this be changed to simply ibc_version? or does ibc have a different versioning cycle than ibc-go?
sounds to me like supported_ics makes the ibc_enabled boolean redundent. I don't see much point in mentioning the possible standards--only the enabled ones. Maybe it could be called something like enabled_ics to avoid confusion?
E.g.,
"ibc_go_version": "v3.0.0"
"ics_enabled: {"ics20-1","ics27-1"}
Should the listed standards just assume all the prerequisistes? (e.g., both 20 and 27 require both 25 and 26, and those in turn require many others).

might need to give more detail on ics support to discover functionality like interchain accounts mauth

I'm not sure I follow. Are you saying, @hxrts , that there are still many possible feature subsets that may be permitted along with something like ics27, such that merely putting 'ics27' isn't enough to determine exactly what has been enabled?
Can that be pushed to a new issue breaking ics27 down further? For now, I don't know too much about ICA yet...

yes exactly. feels like it's kind of important to consider the module/submodule structure in its entirety here, as that would impact how we want to structure capability fields in the metadata, no?

yes exactly. feels like it's kind of important to consider the module/submodule structure in its entirety here, as that would impact how we want to structure capability fields in the metadata, no?
here's mauth for reference, which is split out into a separate module but doesn't have its own ics https://github.com/cosmos/gaia/tree/ica-acct-auth/x/mauth

Well, this 'mauth' module lives under 'gaia', not under 'ibc-go', so does it really apply? I wonder if including it could cause issues down the line, like if a program tries to look for mauth code in ibc-go but then cannot find it.
Still, I like this thinking, and if there are many different possible submodule/feature subsets, then I'm inclined to agree that we can allow for more separation.
Some questions:
Will all features necessarily belong 'under' some ics? e.g., it looks like mauth perhaps belongs under ics27. If so, we might be able to keep the term 'ics' in the name.
-An alternative term could be 'apps', which includes things like 'transfer', 'ics-27', and '29-fee'.
-Or another, more generic alternative could be 'modules', which can include core things like '02'client', '03-connection', '04-channel', etc. This could create a lot more work having to list them all, but also allows for specific subsets sets of core modules. I'm still thinking it'd be best to just assume all prerequisite modules for enabled apps are included.
Were you thinking something more like an object for each ics that could include submodules? like:
"ics_enabled": {   "ics27-1": {"mauth"},   "ics20-1":{} }
or maybe just allowing non-default submodules to be listed along with the ICS standards could work, as in:
"ics_enabled": {   "ics27-1",   "mauth",   "ics20-1" }
Thoughts?

This is how the sdk will be specifying sdk module configs in the near future btw
https://github.com/cosmos/cosmos-sdk/blob/main/simapp/app.yaml

I like the idea of sticking to 'apps' instead of ICS, but one problem that could emerge is if, say, two chains both support 'transfer', but one still using ICS20-1 and another is using some updated standard ICS20-2. If one ICS requires another ICS, the latter can be left out imo.
We can consider skipping ibc_enabled and have ibc_go be either false or a specific version number like 3.0.1. I would actually suggest the same for cosmwasm in #419

Can we imply ICS20-1 vs ICS20-2 based on the IBC Go version? In the case, we could use something like 'transfer', but we'd also need both fields. However, could there ever be a case where we have an app or standard like 'transfer' or 'ICS20' but no IBC Go version specified?
I like the idea of using the version number field being doubled as the boolean.

This is how the sdk will be specifying sdk module configs in the near future btw
https://github.com/cosmos/cosmos-sdk/blob/main/simapp/app.yaml

I'm a little confused... how exactly can this inform the design. Should some list in here define some ics_app enumeration?


Remove version: YoYoGames.GameMaker.Studio.1 version 1.4

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://store.yoyogames.com/downloads/gm-studio/GMStudio-Installer-1.4.9999.exe
Response Error: The remote server returned an error: (502) Bad Gateway.
(Automated message - build 923)

URL: https://store.yoyogames.com/downloads/gm-studio/GMStudio-Installer-1.4.9999.exe
Response Error: The remote server returned an error: (502) Bad Gateway.
(Automated message - build 923)

Close with reason: Duplicate of #184924;


Error relating to ConfigItemStatusManagerImpl in logs

Rancher Version: Build from master
Following exception seen in logs when validation run is executed.
2016-03-20 20:02:33,795 ERROR [:] [] [] [] [ecutorService-5] [.p.c.v.i.ConfigItemStatusManagerImpl] Failed null, exit code [134] output [bash: ../nptl/sysdeps/unix/sysv/linux/x
86_64/../fork.c:141: __libc_fork: Assertion `({ __typeof (self->tid) __value; if (sizeof (__value) == 1) asm volatile ("movb %%fs:%P2,%b0" : "=q" (__value) : "0" (0), "i" (__bu
iltin_offsetof (struct pthread, tid))); else if (sizeof (__value) == 4) asm volatile ("movl %%fs:%P1,%0" : "=r" (__value) : "i" (__builtin_offsetof (struct pthread, tid))); els
e { if (sizeof (__value) != 8) abort (); asm volatile ("movq %%fs:%P1,%q0" : "=r" (__value) : "i" (__builtin_offsetof (struct pthread, tid))); } __value; }) != ppid' failed.
]

@sangeethah there's not much I can do about this issue.  It happens when the agent container dies at just the right time.

We should just try again later.

Or better said, we will try again later

Closing due to inactivity, please reopen if you think this is still relevant to current releases & important.


PSV Save edit

Hi there. I would like to use this on my PSvita which has 3.60 /henkaku and we can decrypt saves.
I would gladly help, I have some experience with code.
Btw there is someone who made a "loader" for vita saves .
The save part is missing though.
Here the link to the github of it :
https://github.com/BabyPuncher/gibbed-borderlands2-vita

I have a sample of a save file back when this first became possible. The biggest here is that the sample file was padded to an absurd degree without any information on how it was padded.
Is this still the case with current tools on PSVita?

I am sorry but I did not have a save from that time. I could send you a decrypted save though.
Basically how its decrypted is , running the game and it automayically decrypts it then it gets copied and done. ( Savemanager homebrew by https://github.com/d3m3vilurr/vita-savemgr)

Was this ever added?

It would be cool if this feature were to be added. We now have easier ways to make backups of our saves on Vita, decrypted or not, using tools like Vitasavemgr or simply Vitashell. There's another git where someone tried to do it but I don't think they actually made it work as some saves can't be opened, and the function to save as a Vita savefile isn't supported, which makes the whole thing somewhat useless for Vita-only users.

Towing the line here in 2019 for this gibbed editor to hopefully support PS VITA save editing.
Many people still play this game and many people would like to have their main saves on PC opened via Gibbed, edited then saved in a PS Vita format.
Please, just give it an alpha try and see the resonance on reddit and twitter for yourself !
People want this !


Create a tutorial for sharing interfaces and clients between contracts in a workspace

We've seen some use of a pattern where in a multi-contract workspace the interfaces of called contracts are placed in an rlib crate, which also uses the contractclient macro to generate a client for the interface. The implementation then implements the interface and contracts that must call it can use the interface-generated contract client.
This is somewhat related to:

https://github.com/stellar/stellar-docs/issues/481

@leighmcculloch Can i work on this?

Hi @Gift-Naomi! Just FYI, this is also not a part of the docs bounty. Look for the issues tagged with the Docs Bounty label for those! But of course if you'd like to work on this outside of the bounty, that is great!

Hi @Gift-Naomi! Just FYI, this is also not a part of the docs bounty. Look for the issues tagged with the Docs Bounty label for those! But of course if you'd like to work on this outside of the bounty, that is great!

Alright then!
I will like work on it
But there will be incentives right?

There aren't any incentives for this at this time, let me take it back to the team and see if we can add it to the bounty.

There aren't any incentives for this at this time, let me take it back to the team and see if we can add it to the bounty.

Okay sir I’ll be waiting to hear from you
Thank you.

Hi @Gift-Naomi! I've chatted with the team and we're not going to turn this into a bounty at this time. Please feel free to look at any issues labeled with the Docs Bounty label to see if there's anything you'd like to work on!


Can't train on nuImages

Hallo,
I have tried to train Mask RCNN and HTC on nuImages. But in both cases it fails with the following error message:
$ python3 tools/train.py configs/nuimages/mask-rcnn_r50_fpn_1x_nuim.py

Traceback (most recent call last):
  File "tools/train.py", line 135, in <module>
    main()
  File "tools/train.py", line 124, in main
    runner = Runner.from_cfg(cfg)
  File "/home/labor/anaconda3/envs/mmdet3d/lib/python3.8/site-packages/mmengine/runner/runner.py", line 439, in from_cfg
    runner = cls(
  File "/home/labor/anaconda3/envs/mmdet3d/lib/python3.8/site-packages/mmengine/runner/runner.py", line 290, in __init__
    raise ValueError(
ValueError: train_dataloader, train_cfg, and optim_wrapper should be either all None or not None, but got train_dataloader=None, train_cfg={'type': 'EpochBasedTrainLoop', 'max_epochs': 12, 'val_interval': 1}, optim_wrapper={'type': 'OptimWrapper', 'optimizer': {'type': 'SGD', 'lr': 0.02, 'momentum': 0.9, 'weight_decay': 0.0001}}.

I used your script to convert the Labels to COCO-format.

Thanks for your feedback. We will refactor it ASAP.

Same error

Same error.

same error

Thanks for your feedback. We will refactor it ASAP.

Hi!,sorry to bother you, I noticed that the bug still hasn't been fixed, is there any temporary solution for the bug(no train_dataloader)？

same error

same error


AMP HTML Failed to Display

I gave it a try. Sent a test and Outlook failed to load the AMP HTML and loaded the regular HTML version instead. Thoughts?  I configured my Outlook settings to accept dynamic emails. AMP HTML works fine in Gmail.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ca597d83-a697-5312-14b3-33c3f2511015
Version Independent ID: 2d2f5f06-fbe5-33a2-02d9-44272721834c
Content: AMPHTML - Outlook Developer
Content Source: docs/amphtml/index.md
Product: outlook
Technology: o365-amp
GitHub Login: @LezaMax
Microsoft Alias: humlezg

@LezaMax can you help?

Just wanted to followup on my original post to see if the team had any insights on my post. Thanks.

Please send your sample email to<EMAIL_ADDRESS>so we can take a look. Include the amp mime part and tell us the, subject and date of the email. Also please tell us the tool you used to create and send the email.

Hello, Test sent. Im using https:// sendtest.email. Subject line is AMP HTML TEST. Date is today 11/20/19. Thank you.

We received your message and it is indeed not rendering. I also tried the tool myself but in my case it did render the AMP HTML successfully. That leads me to believe that AMP validation is failing for your code. Do you mind continuing this conversation over email?  Please send us the repro steps with a sample of your code to<EMAIL_ADDRESS>

Update, we have what we need currently to continue the investigation and we are taking a look. It appears that there is indeed an issue with validation. We'll update this conversation once we know more.

The Outlook team has announced that they are ending the developer preview for AMP on October 1, 2020. These documents will be removed at that time.


Can we use training dataset of VIPER  when training our model?

It is said that " all publicly available datasets are allowed at the challenge", but  "the VIPER benchmark didn't supply any training data". I was wondering whether we can use VIPER's training dataset (download from VIPER's website)or not.

Yes, you can use any publicly available training data including those downloaded from the VIPER website


React 16/npm warning

Hey! Any chance we can get a quick 0.9.5 update that fixes the following issue please? When upgrading to React 16.X, on 0.9.4 you get the following npm warning:
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^15.0.0-rc || ^15.0 but none is installed. You must install peer dependencies yourself.

Thanks!

Hello @andrewhathaway
There's a new version of the component, can you try that one?
https://github.com/Adphorus/react-date-range/tree/next
You can install it like npm install react-date-range@next

Hi @keremciu! I did see there as an alpha update on the releases page, however it's an alpha and I also saw breaking changes, so didn't want to roll with that just yet!

@mkg0 So this is a no? No explanation why my issue is closed.

@andrewhathaway sorry for no explanation Andrew.
We deprecated 0.x version support and don't have any plan to new releases on it. Could you please upgrade package for preventing the warning?

I would love to, however there is no release out of a beta/alpha release that I can use? I'm not wanting to migrate to an alpha version, that is likely to change or may potentially have bugs.

Without sounding like an arsehole, #198 is good example of why I can't use alpha versions in a product! :(


Portfolio: Mobile Menu

In this pull request did the following :

Implemented the mobile menu with javascript and made it look like the one in the Figma design template that I choose.
Used DOM manipulation to make my mobile version menu look like the template I selected.
I used the correct GitHub flow.

Hi @AbelG101
I have added the changes that you provided. Kindly check that pls


Fixes spfx project upgrade for 1.18.0

Closes #5500

ready to merge 🚀

merged manually. You Rock 🤩


[Bug] Default values for input widgets loaded for Appsmith store aren't being set

We have a table widget that displays rows of data, along with button for each row. This button is intended to open a Modal with a form used for editing the data from the current row.
The way this was implemented is that on clicking the button, we save the currentRow object into Appsmith store and then open the Modal. The input widgets in the modal have their default value set to load from the Appsmith store and pick the appropriate field.
This works for the most part, but sometimes, the input widgets in the form don't load the values they should've. They load sometimes, so the logic is likely working, but they don't load sometimes, so we're missing something.
The following video shows the problem as well as the bindings used for the button as well as the bindings in the Modal form.
https://cdn.discordapp.com/attachments/760761686549463060/853566610353422336/vokoscreen-2021-06-13_16-18-17.mp4

@sharat87 the user can directly reference the selectedRow instead of storing it in these cases.
@hetunandu could this be because of the async nature of actions?

I see. I didn't realize clicking on a button in a row will select the row as well. 👍

Hi @Nikhil-Nandagopal @sharat87 thank you for this, I just want to add something, this behavior only happens when applying filter or search box, for pagination it works well. For example going into page 120, the bug won't occurs. So there must be something with on selection that make value of stored data undefined/null.
I have tried selectedRow to store value and it doesn't work when applying filter/search.
Update : I have tried using text (label) to store temporary data, but become undefined when applying filter/search then store value.

Hi all, @hetunandu @sharat87 I found the cause of this problem, in short, when filter/search is active and then storing data within currentRow will cause appsmith store to be null

This is caused because the currentRow value passed in Table actions is incorrect when any kind of filter is applied. Here is a video with the reproduction
https://user-images.githubusercontent.com/12022471/122255786-17183c00-ceec-11eb-9016-9e7243d7a9fb.mov

@somangshu This has been triaged by @hetunandu . Please re-assign this issue.

@somangshu @riodeuno I think this PR might fix this issue as well

@vivekverma2312 based on the above please check if this issue is fixed.
Close this if done


Volume + Mesh : Rendering pb

If you add a mesh and a volume then you remove the volume and add it back.
The volume rendering is incoherent (all of them: MSR, MIP, VR).
The volume was a head and the mesh was an eye (the difference in size might be important).

Should be set as a major bug.
There are big pb when mixing mesh and Volumic images (I don't know if users are doing it with the previous release).
Previous changes from  #689 may have make it worst but some part of the code is wrong when mixing vol and mesh.
Working on this ...

This is due to the reslicing operation done and to the special case that is given to the first layer.
If the first layer is a mesh then the rendering of the next loaded volumic image is not ok.


Add attachment support

This adds the attachment support #139. @geekgonecrazy @timkinnane. This file should probably help clear things out. Thanks.

@ngenerio Much better! :smile: I need to get a couple of versioning things worked out and i'll get your changes in.
Thanks again!

:+1

LGTM.  It would be gr8 to get this merged soon. And get HEAD back to a workable version. Thx.

@ngenerio ok I fixed the main branch.  Is it possible you could re-open #144 ?

@geekgonecrazy I had an issue with some merge conflicts whiles working. I had to delete the repo, fork and make the changes again. The only way will be to open another pull request.

@ngenerio hate to ask... But would you mind doing that?  I rolled the branch back to v0.1.4 to get rid of the code causing everyone issues.
If its too much trouble let me know and I'll try and cherry pick your commit out and open a new PR.  😄

Closing in favor of #148

@geekgonecrazy Done. Pull request: #148 .

I guess this pull request can be closed.

@ngenerio v1.0.0 and v1.0.1 were released pre-maturely. Your code is in, and will be in all future releases.  Thanks again 👍

:+1: Sounds great. You did a roll back to v1.0.4.


Update dependencies for scalafix given via scalafixDependencies

Scalafix rules given via scalafixDependencies are updated, too.
Scalafix rule updates are getting the label "scalafix-rule-update".
Fixes #1032

I just tried this out: https://github.com/fthomas/scalafix-test/pull/29
Very cool! Thanks @mzuehlke!

Btw, we can watch which scalafixDependencies are updated by Scala Steward here:
https://github.com/pulls?q=author%3Ascala-steward+is%3Apr+"scalafix-rule-update"

Interesting link


Merge Dev into Master

Merge experiment logs into master

Codecov Report

Merging #10 into master will decrease coverage by 27.1%.
The diff coverage is 17.47%.

@@             Coverage Diff             @@
##           master      #10       +/-   ##
===========================================
- Coverage   63.75%   36.65%   -27.11%
===========================================
  Files           9       13        +4
  Lines         378      723      +345
===========================================
+ Hits          241      265       +24
- Misses        137      458      +321

Impacted Files
Coverage Δ

torchup/agents/DoubleDQN.py
0% <0%> (ø)
:arrow_up:

torchup/logging/models.py
0% <0%> (ø)

torchup/replay_memory.py
55% <0%> (ø)
:arrow_up:

torchup/logging/factory.py
0% <0%> (ø)

torchup/agents/DQN.py
0% <0%> (ø)

torchup/utils/utils.py
93.75% <100%> (+14.8%)
:arrow_up:

torchup/agents/agent_base.py
96.66% <100%> (+0.32%)
:arrow_up:

torchup/base/models.py
40.9% <40.9%> (ø)

torchup/models.py
46.55% <56.52%> (+0.04%)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22c34ec...6e52ad1. Read the comment docs.