LibWeb: Derive SVG root's natural size from width/height attributes

We were incorrectly looking at the CSS computed values for width and height to determine the natural size of  root elements. This meant that elements where the attribute and computed value were different values would end up with incorrect natural size.
Visual progression on https://hemnet.se/
Before:

After:

A bit late but this is the output of ./Meta/WPT.sh run --log output-from-master.log svg for this change vs master:
  ▶ OK [expected TIMEOUT] /svg/coordinate-systems/outer-svg-intrinsic-size-002.html

  ▶ Unexpected subtest result in /svg/coordinate-systems/outer-svg-intrinsic-size-002.html:
  │ FAIL [expected PASS] no sizing attributes set
  │   → assert_equals: checking width. expected 300 but got 0
  │
  │     at <unknown>
  │     at assert_wrapper (http://web-platform.test:8000/resources/testharness.js:1463:35)
  │     at expect_svg_width_and_height (http://web-platform.test:8000/svg/coordinate-systems/outer-svg-intrinsic-size-002.html:7:22)
  │     at http://web-platform.test:8000/svg/coordinate-systems/outer-svg-intrinsic-size-002.html:15:38
  │     at <unknown>
  │     at http://web-platform.test:8000/resources/testharness.js:2622:30
  │     at test (http://web-platform.test:8000/resources/testharness.js:633:34)
  │     at go (http://web-platform.test:8000/svg/coordinate-systems/outer-svg-intrinsic-size-002.html:14:11)
  │     at load ((unknown):2:3)
  │     at <unknown>
  │     at <unknown>
  └     at <unknown>

  ▶ Unexpected subtest result in /svg/coordinate-systems/outer-svg-intrinsic-size-001.html:
  └ PASS [expected FAIL] specified height

  ▶ Unexpected subtest result in /svg/coordinate-systems/outer-svg-intrinsic-size-001.html:
  └ PASS [expected FAIL] modified specified height

  ▶ Unexpected subtest result in /svg/coordinate-systems/outer-svg-intrinsic-size-001.html:
  └ PASS [expected FAIL] no specified sizing attrs (after setting & removing them)

  ▶ Unexpected subtest result in /svg/coordinate-systems/outer-svg-intrinsic-size-001.html:
  └ PASS [expected FAIL] removing specified width, in presence of specified viewBox

  ▶ PASS [expected FAIL] /svg/layout/svg-intrinsic-size-min-size.html

  ▶ PASS [expected FAIL] /svg/text/reftests/text-font-face-load-image.html

Ran 833 tests finished in 98.9 seconds.
  • 829 ran as expected. 0 tests skipped.
  • 2 tests passed unexpectedly
  • 1 tests unexpectedly okay
  • 2 tests had unexpected subtest results

This change appears to cause a regression in https://wpt.live/html/rendering/replaced-elements/svg-inline-sizing/svg-inline.html, which now hangs when opened in the browser. The issue seems to occur on subtest 269, which can be run individually like this: https://wpt.live/html/rendering/replaced-elements/svg-inline-sizing/svg-inline.html?269
Attaching gdb shows what appears to be a stack overflow when calling getBoundingClientRect().
Here's the relevant part of the stack trace, it continues in this fashion until a segfault occurs:
#60813 0x00007b845c7033eb in compute_height_for_replaced_element () at /home/tim/repos/ladybird/Userland/Libraries/LibWeb/Layout/FormattingContext.cpp:635
#60814 0x00007b845c702547 in tentative_width_for_replaced_element () at /home/tim/repos/ladybird/Userland/Libraries/LibWeb/Layout/FormattingContext.cpp:506
#60815 0x00007b845c7033eb in compute_height_for_replaced_element () at /home/tim/repos/ladybird/Userland/Libraries/LibWeb/Layout/FormattingContext.cpp:635
#60816 0x00007b845c702547 in tentative_width_for_replaced_element () at /home/tim/repos/ladybird/Userland/Libraries/LibWeb/Layout/FormattingContext.cpp:506
#60817 0x00007b845c7033eb in compute_height_for_replaced_element () at /home/tim/repos/ladybird/Userland/Libraries/LibWeb/Layout/FormattingContext.cpp:635
#60818 0x00007b845c702547 in tentative_width_for_replaced_element () at /home/tim/repos/ladybird/Userland/Libraries/LibWeb/Layout/FormattingContext.cpp:506
#60819 0x00007b845c708960 in compute_width_for_replaced_element () at /home/tim/repos/ladybird/Userland/Libraries/LibWeb/Layout/FormattingContext.cpp:557
#60820 0x00007b845c724a96 in dimension_box_on_line () at /home/tim/repos/ladybird/Userland/Libraries/LibWeb/Layout/InlineFormattingContext.cpp:121
#60821 0x00007b845c726067 in next_without_lookahead () at /home/tim/repos/ladybird/Userland/Libraries/LibWeb/Layout/InlineLevelIterator.cpp:270
#60822 0x00007b845c725f48 in next () at /home/tim/repos/ladybird/Userland/Libraries/LibWeb/Layout/InlineLevelIterator.cpp:138
#60823 0x00007b845c723bc0 in generate_line_boxes () at /home/tim/repos/ladybird/Userland/Libraries/LibWeb/Layout/InlineFormattingContext.cpp:261
#60824 0x00007b845c7239c7 in run () at /home/tim/repos/ladybird/Userland/Libraries/LibWeb/Layout/InlineFormattingContext.cpp:84
#60825 0x00007b845c6e7057 in layout_inline_children () at /home/tim/repos/ladybird/Userland/Libraries/LibWeb/Layout/BlockFormattingContext.cpp:476
#60826 0x00007b845c6ee147 in layout_block_level_box () at /home/tim/repos/ladybird/Userland/Libraries/LibWeb/Layout/BlockFormattingContext.cpp:685
#60827 0x00007b845c6e7240 in operator() () at /home/tim/repos/ladybird/Userland/Libraries/LibWeb/Layout/BlockFormattingContext.cpp:741
#60828 for_each_child_of_type<Web::Layout::Box, (lambda at /home/tim/repos/ladybird/Userland/Libraries/LibWeb/Layout/BlockFormattingContext.cpp:740:49)> () at /home/tim/repos/ladybird/Userland/Libraries/LibWeb/TreeNode.h:239
#60829 for_each_child_of_type<Web::Layout::Box, (lambda at /home/tim/repos/ladybird/Userland/Libraries/LibWeb/Layout/BlockFormattingContext.cpp:740:49)> () at /home/tim/repos/ladybird/Userland/Libraries/LibWeb/TreeNode.h:248
#60830 layout_block_level_children () at /home/tim/repos/ladybird/Userland/Libraries/LibWeb/Layout/BlockFormattingContext.cpp:740
#60831 0x00007b845c6e6a4a in run () at /home/tim/repos/ladybird/Userland/Libraries/LibWeb/Layout/BlockFormattingContext.cpp:79
#60832 0x00007b845c70b784 in layout_inside () at /home/tim/repos/ladybird/AK/OwnPtr.h:151
#60833 layout_absolutely_positioned_element () at /home/tim/repos/ladybird/Userland/Libraries/LibWeb/Layout/FormattingContext.cpp:1255
#60834 0x00007b845c6e7884 in parent_context_did_dimension_child_root_box () at /home/tim/repos/ladybird/Userland/Libraries/LibWeb/Layout/BlockFormattingContext.cpp:116
#60835 0x00007b845c6ee736 in layout_block_level_box () at /home/tim/repos/ladybird/Userland/Libraries/LibWeb/Layout/BlockFormattingContext.cpp:730
#60836 0x00007b845c6e7240 in operator() () at /home/tim/repos/ladybird/Userland/Libraries/LibWeb/Layout/BlockFormattingContext.cpp:741
#60837 for_each_child_of_type<Web::Layout::Box, (lambda at /home/tim/repos/ladybird/Userland/Libraries/LibWeb/Layout/BlockFormattingContext.cpp:740:49)> () at /home/tim/repos/ladybird/Userland/Libraries/LibWeb/TreeNode.h:239
#60838 for_each_child_of_type<Web::Layout::Box, (lambda at /home/tim/repos/ladybird/Userland/Libraries/LibWeb/Layout/BlockFormattingContext.cpp:740:49)> () at /home/tim/repos/ladybird/Userland/Libraries/LibWeb/TreeNode.h:248
#60839 layout_block_level_children () at /home/tim/repos/ladybird/Userland/Libraries/LibWeb/Layout/BlockFormattingContext.cpp:740
#60840 0x00007b845c483d17 in update_layout () at /home/tim/repos/ladybird/Userland/Libraries/LibWeb/DOM/Document.cpp:1147
#60841 0x00007b845c4aec63 in get_client_rects () at /home/tim/repos/ladybird/Userland/Libraries/LibWeb/DOM/Element.cpp:959
#60842 0x00007b845c4aea2e in get_bounding_client_rect () at /home/tim/repos/ladybird/Userland/Libraries/LibWeb/DOM/Element.cpp:920
#60843 0x00007b845c9ea1a2 in operator() () at /home/tim/repos/ladybird/Build/ladybird/Lagom/Userland/Libraries/LibWeb/Bindings/ElementPrototype.cpp:3423
#60844 throw_dom_exception_if_needed<(lambda at /home/tim/repos/ladybird/Build/ladybird/Lagom/Userland/Libraries/LibWeb/Bindings/ElementPrototype.cpp:3423:36), JS::NonnullGCPtr<Web::Geometry::DOMRect>, JS::NonnullGCPtr<Web::Geometry::DOMRect> > ()
    at /home/tim/repos/ladybird/Userland/Libraries/LibWeb/Bindings/ExceptionOrUtils.h:110
#60845 get_bounding_client_rect () at /home/tim/repos/ladybird/Build/ladybird/Lagom/Userland/Libraries/LibWeb/Bindings/ElementPrototype.cpp:3423
#60846 0x00007b845b7b790b in operator() () at /home/tim/repos/ladybird/AK/Function.h:120


x/pkgsite: support versions tab for directory view

The URL https://pkg.go.dev/golang.org/x/mod?tab=subdirectories currently shows information for v0.1.0 of that module.
It would be useful to be able to click on the Versions tab to see what other versions are known. At the moment, that tab is greyed out.

Hey @julieqiu mod is a directory that has packages and commands. In this directory, some of the packages like lazyregexp have two versions available v0.2.0 and v0.3.0 and other packages like gosumcheck have three different versions. In this case, if we decide to make the tab Versions clickable what information should be visible on that tab?
Please let me know what your thoughts are about this. Thanks!

It should return the package available in the module version corresponding to that path. So for<EMAIL_ADDRESS>only show packages in v0.3.0 of golang.org/x/mod.
You should be able to just add a tabVersions case to fetchDetailsForDirectory, and use the existing  fetchVersionDetails.
Note that this will only work with the new data model, so you will need to add the experiments use-path-info and use-directories locally. You can do that by running:
go run devtools/cmd/experiment/experiment.go create use-path-info
go run devtools/cmd/experiment/experiment.go create use-directories

Thanks for the explanation. I will give this try and send a change list by Friday EOD.
Thanks,

Apologies for the delay. Starting work on this now.

Thanks for your help, Julie.
After I created a migration, I was able to add use-path-info experiment but use-directories experiment is not working. I get error - 2020/09/19 17:30:39 Experiment "use-directories" does not exist. whenever I run the command
go run devtools/cmd/experiment/experiment.go create use-directories. Do you have suggestions about how to fix this error?
On a side note - I added the password to postgres manually by modifying devtools/migrate_db.sh  file. Do you think this should use GO_DISCOVERY_DATABASE_PASSWORD environment variable?
Thanks for all your help

Hello,
I managed to fix the issues I mentioned in the previous comment and added a new function as suggested in the third comment.
While running the server locally I could only see the beta version of the website which did not display the versions tab explicitly. I am unsure if the fix worked or not. Please let me know if I mixed up something.
Thanks,

We just launched a redesign of pkg.go.dev (see https://github.com/golang/go/issues/41585#issuecomment-718143563), so closing this issue as out of date. Thanks for taking the time to look into it @rahulw!


Code blocks showing and not being parsed correctly in multiple locations

File: engine/userguide/storagedriver/device-mapper-driver.md, CC @mstanleyjones

can I claim this bug please


You can eat flesh kudzu (tendons) without issue

Description

Seems to be partially intended as whoever coded flesh kudzu didn't specify two or more stomachs to eat and commented `# delightfully devilish !
However, you can rapidly eat through all the tendons as the doafters aren't interrupted, making the previous method of slashing or spacing the flesh kudzu pointless.
Furthermore, despite being made of meat, it is not tagged as such and cannot be eaten by lizards.
Lastly, it doesn't seem to make sense you can eat flesh kudzu without issues as they're normally damaging to walk through.
Reproduction

Find flesh kudzu and stand near it without mouth blockers
Alt+E on the flesh kudzu

Screenshots

I like being able to eat it but it does need some fixing…
#32821 fixes eating it not hurting you when eating it


gcm_setup wrong cloud microphysics default

gcm_setup shows BACM_1M as the default cloud microphysics option,  but hitting  (default) does not select BACM_1M in the resulting AGCM.rc file. Either the prompt for cloud microphysics needs to be changed, or the actual default needs to be changed.

Fixed now


⚠ Bofrost.lu has degraded performance

In 61da96e, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1615 ms

Resolved: Bofrost.lu performance has improved in d965aa4 after 15 minutes.


Default API Version for Accept Header versioning not applying when some service endpoint method in the same controller has an ApiVersion attribute

I still don't completely understand how the versioning works so if I'm just doing this incorrectly, let me know! But I was able to reproduce a minimal set-up in a new project that results in the error "The HTTP resource that matches the request URI 'localhost/TestRepro/controller/method' does not support the API version '1.0'.""
Using the default .Net Core API Template, I installed the Versioning package and added this to the ConfigureServices:
services.AddApiVersioning(options =>
                {
                    options.ApiVersionReader = new MediaTypeApiVersionReader();
                    options.DefaultApiVersion = new ApiVersion(1, 0);
                    options.AssumeDefaultVersionWhenUnspecified = true;
                    options.ApiVersionSelector = new CurrentImplementationApiVersionSelector(options);
                }
            );

I then slightly modified the starting template to give myself something to test off of:
[HttpGet]
        [Route("test")]
        public string Get()
        {
            return "Default stuff";
        }

Navigating to this without specifying a version in the Accept header version works as expected: We get defaulted to 1.0, and it matches the route here that has also been defaulted to 1.0, if my understanding of everything is correct.
The issue comes when we go to version something else in the same controller: adding this
[HttpGet]
        [Route("versioned")]
        [ApiVersion("1.0")]
        public string BreakItAll()
        {
            return "break?";
        }

result in the first route breaking with the error I mentioned at the start. It's no longer recognizing that original route as version 1.0. The route with the explicit version does work, though.
I DO have a workaround so it's not incredibly vital: using MapToApiVersion rather than ApiVersion on the endpoint works as expected. As such, I feel like I may be misusing the ApiVersion attribute, especially since I'm explicitly trying to not label the controllers themselves with ApiVersion (I'm wanting versioning on a per-endpoint basis). But I'm going ahead and post this just in case it's an actual issue.

This is happening because implicit versioning is only allowed when there is no other versioning information. This behavior is primarily meant to address the scenario where tens, hundreds, or even thousands of APIs need to start versioning. In the very first supported versions of the library, this would have required touching untold numbers of files. In truth, all APIs have some initial version albeit unnamed (it might have casually be called "v1"). When no other attribution is specified, the value used for this default is options.DefaultApiVersion. Often the actual value is inconsequential for that initial, default version.
As you have noticed, once you start adding attribution, this behavior goes away. This is an important distinction. Things are all or nothing. If it didn't behave this way, then it would be difficult or perhaps even impossible to permanently sunset an old API. If you're starting fresh, I recommend always using explicit versioning so that things are clear.
There is a distinction between [MapToApiVersion] vs [ApiVersion]. A mapped version is just that - it's only mapped. A mapped version does not declare an API version. All actions implicitly map to the versions declared by their parent controller. The [MapToApiVersion] is needed and used when you interleave multiple versions to different actions within the same controller. If you don't interleave, then you should never have to worry about mapping specific actions to particular API versions.
Allowing [ApiVersion] directly on actions was something I started with a couple of years ago in the early adopter stages, but removed it because it was confusing to some folks. That ultimately brought about the idea of [MapToApiVersion], which has virtually the same public surface area, but a significantly different meaning under the hood. Due to the routing improvements in ASP.NET Core, I revisited the idea of allowing [ApiVersion] directly on actions (since controllers no longer really matter). This behavior does allow you to declare versions directly on an action. This will supersede anything on the controller. Ultimately, this is another way to interleave, but with a bit more flexibility. It can get quite confusing, so use it with caution. The primary motivation to support it was to also allow [ApiVersionNeutral] at the action level, which makes a lot of sense for certain types of actions such as DELETE. Without that, you have to keep indicating support for the action at every version, even though it doesn't change.
I hope that helps clear things up - it not a little. ;)

Thank you very much for the thorough explanation! I agree that it's probably best that I declare every endpoint as its API version anyway, but I was playing around with the idea of leaving everything un-set as default and then upgrading only the endpoints that needed it. The driving philosophy of doing it in the same controller would be "I don't wanna have to track down what the current version is by looking through several controller versions to find the last version this particular route updated," though separate controllers per version would work just as well as long as I don't mind just always using the most recent controller and having endpoints skip to the most recent controller.
Thanks again for confirming that this is how that is intended to work, I'll go ahead and close the issue.


download speed very very slow

Hello, good morning, the following has happened to me for 2-3 days. I have a 2.2 GB movie on my Teldrive, and if I play the movie from the beginning it starts perfectly. But if I want to go to minute 59 it takes a long time to play again. I have noticed that the download speed has dropped a lot and I am a premium user.
I'm using bots and it happens to me both in teldrive web and in rclone.

It should be because of chunk'ing. I'm experiencing the same thing, but I don't think it could be fixed somehow. As your file is split into several small files, it might take a while.

Having the last two versions of teldrive and rclone, 5 days ago it was much faster. Going to minute 59 took just 3 seconds, now it takes more than a minute. what could be happening?

Try the old version of teldrive. If that does not help, check if you've modified any config. If not, then maybe ***gram changed something on their end. Not quite sure, perhaps some more knowledged guys here could give you the correct answer.
As mentioned, i'm experiencing the same and was thinking that it's okysh

I am on the latest teldrive version and I am not experiencing any such slowness using rcline.

I am on the latest teldrive version and I am not experiencing any such slowness using rclone

Drop you settings of teldrive/rclone/mount, i will try from my end to replicate with your settings.

I attach my settings
######teldrive - config.toml#######
[db]
data-source = "XXXXXX"
prepare-stmt = true
[db.pool]
enable = true
max-idle-connections = 25
max-lifetime = "10m"
max-open-connections = 25
[cronjobs]
enable = true
[jwt]
allowed-users = [""]
secret = "XXXXXX"
session-time = "30d"
[server]
graceful-shutdown = "15s"
port = XXXXX
read-timeout = "1h"
write-timeout = "1h"
[tg]
app-hash = "XXXXXXXXX"
app-id = XXXXXXX
app-version = "4.6.3 K"
bg-bots-limit = 5
device-model = "Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/116.0"
disable-stream-bots = false
lang-code = "en"
lang-pack = "webk"
rate = 50
rate-burst = 20
rate-limit = true
session-file = ""
system-lang-code = "en-US"
system-version = "Win32"
[tg.uploads]
encryption-key = "XXXXXXXXX"
retention = "7d"
threads = 8
[tg.stream]
multi-threads = 8
buffers = 16
######rclone - rclone.conf#######
[data]
type = teldrive
api_host = http://localhost:XXXXX
access_token = XXXXXXXX
chunk_size = 500M
upload_concurrency = 4
encrypt_files = true
random_chunk_name = true
######rclone - mount#######
rclone mount data: E: --cache-dir --attr-timeout=8700h --use-mmap --stats=10s --buffer-size=32M --vfs-cache-poll-interval=30s --poll-interval=30s --dir-cache-time=8700h --vfs-cache-max-age=7720h --drive-server-side-across-configs --vfs-cache-mode=full --vfs-read-chunk-size=32M --vfs-read-chunk-size-limit=100G --vfs-read-chunk-size-limit=100G --vfs-read-chunk-streams=8 --vfs-cache-max-size=100G --local-no-check-updated --drive-chunk-size=64M --multi-thread-streams=4 --multi-thread-cutoff=250M --transfers=4 --timeout=30m --vfs-case-insensitive --drive-pacer-min-sleep=10ms --drive-pacer-burst=200

Thanks. Will try it out.
You can drop:
transfers -> It's default value.
drive-pacer-min-sleep, drive-pacer-burst, drive-server-side-across-configs, drive-chunk-size -> It won't work, it's only for GDrive.
poll-interval  -> I think it's not supported by teldrive.

Try the old version of teldrive. If that does not help, check if you've modified any config. If not, then maybe ***gram changed something on their end. Not quite sure, perhaps some more knowledged guys here could give you the correct answer.
As mentioned, i'm experiencing the same and was thinking that it's okysh

Does the same thing happen to you? Very slow speed?

I am on the latest teldrive version and I am not experiencing any such slowness using rclone

Drop you settings of teldrive/rclone/mount, i will try from my end to replicate with your settings.

config.toml: [db] data-source = "xxx" prepare-stmt = true
[db.pool] enable = true max-idle-connections = 25 max-lifetime = "10m" max-open-connections = 25
[jwt] secret = "www"
[tg] app-id = "aaa" app-hash = "xxx" bg-bots-limit = 5 disable-stream-bots = false rate = 50 rate-burst = 20 rate-limit = true
[cronjobs] enable = true
[server] graceful-shutdown = "15s" port = 8080 read-timeout = "1h" write-timeout = "1h"
[tg.uploads] threads = 8
[tg.stream] multi-threads = 8 buffers = 16 stream-buffers = 16
rclone mount: rclone mount --allow-other --allow-non-empty teldrive: /mnt/cloud
rclone config: [teldrive] type = teldrive access_token = xxx api_host = http://localhost:8080 chunk_size = 1800Mi #channel_id = -xxx upload_concurrency = 4 random_chunk_name = true threaded_streams = true

I have configured teldrive's .conf as you have indicated and rclone with the mount you have indicated and nothing, I am still the same.
It may be that telegram has slowed down a lot when detecting this system. In total I have uploaded about 200 movies but with a maximum size of 2gb.

Try the old version of teldrive. If that does not help, check if you've modified any config. If not, then maybe ***gram changed something on their end. Not quite sure, perhaps some more knowledged guys here could give you the correct answer.
As mentioned, i'm experiencing the same and was thinking that it's okysh

Does the same thing happen to you? Very slow speed?

Not the speed, but I'm experiencing the same with loading, when for example strolling to X minute, then i'm waiting kinda long to proceed with playback.

Try the old version of teldrive. If that does not help, check if you've modified any config. If not, then maybe ***gram changed something on their end. Not quite sure, perhaps some more knowledged guys here could give you the correct answer.
As mentioned, i'm experiencing the same and was thinking that it's okysh

Does the same thing happen to you? Very slow speed?

Not the speed, but I'm experiencing the same with loading, when for example strolling to X minute, then i'm waiting kinda long to proceed with playback.
The main difference in the settings is the encryption, but hard to belive that it would make such big impact.

When you say wait a bit, how many seconds is that? In a 2gb file, if I go to the end of the video, it takes 45 seconds.

So was playing around with settings and found the root cause of it. It does such slowness if you use encryption-key in teldrive and encrypt_files in rclone together. Once i've commented out encrypt_files and uploaded file - everything works properly.
Note: It will not fix your old files, you will mostly need to re-upload them.

Also, just tried on fresh teldrive instance. Same issue. So i can confirm on 100%, that's because of encryption.

Encryption doesn't cause that much cpu usage could be server issue as I am getting almost same speed with encryption around 100MBps.

Encryption doesn't cause that much cpu usage could be server issue as I am getting almost same speed with encryption around 100MBps.

Mostly it's not about the speed, but when you scroll encrypted video to let's say 30 min out of 1h, then for example for me the playback start after ~ 3 minutes of waiting. I've replicated on several machines this. Same issue and happens ONLY while file in encrypted. Redis didn't helped tho.

Haven't faced this I have multiple encrypted video and all of them are playing smoothly with seeking .You need to enable vfs-chunk-streams also  for smooth playback  see more in wiki for recommend values

Haven't faced this I have multiple encrypted video and all of them are playing smoothly with seeking .You need to enable vfs-chunk-streams also for smooth playback see more in wiki for recommend values

I'm not first year into this, so indeed it has been done. It doesn't matter is it plex or teldrive UI, the issue is the same.


Standardize README

Add standard sections which were missing
Update header banner
Clarify further how to use Redis

@djones6 please can you look at the latest commit as I've addressed your review comments.


Can't use rocket chat self-hosted

Describe the bug
I can't use rocket chat for self-hosted, I get the error:
Could not validate custom rocket chat
Using the official client  works correctly
To Reproduce
Steps to reproduce the behavior:

Go to 'rocketchat'
Click on 'Selfhosted'
Insert selfhosted url
See error

Expected behavior
Enable the connection
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Additional context
Using Ubuntu, version 5.5.0-beta.22
Our server is inside a vpn

please send an email to<EMAIL_ADDRESS>I'd like to do some debugging.

I have the same issue.

OS: Arch Linux x86_64
Kernel: 5.6.15-arch1-1
Resolution: 1920x1080, 1920x1080
DE: GNOME
CPU: Intel i7-7500U (4) @ 3.500GHz
GPU: NVIDIA GeForce 940MX
GPU: Intel HD Graphics 620
Memory: 5771MiB / 15798MiB


0.7.0

Discussed in https://github.com/kubilus1/autoortho/discussions/414

Originally posted by kubilus1 October 13, 2023
What's Changed

Show logs in config UI.  Adjust how we kick off execution by @kubilus1 in https://github.com/kubilus1/autoortho/pull/398
Fix 'duplicate' best chunk tile matches by @kubilus1 in https://github.com/kubilus1/autoortho/pull/409
Only validate existing sceneries when necessary by @kubilus1 in https://github.com/kubilus1/autoortho/pull/411

Full Changelog: https://github.com/kubilus1/autoortho/compare/0.6.1...0.7.0
This discussion was created from the release 0.7.0.

6.1. ran fine on my system . After installing 7.0 menu appears but dissapears;  so no starting up anymore ( used WinFSP and tried Dokan) . ( bytheway: didn't delete autoortho cache

erwin4711:
You should see the AO log. But I'm almost sure that AO has generated an extra folder with a name similar to z_ao_xx_bkp or something like that. You have to delete these AO backup folders from Custom Scenery, rearrange the order in scenery_pack.ini and then run AO.
Remember that you must start the simulator until the screen that asks you for an aircraft and airport. You stop there and start AO until you perform the test and it passes OK. Then, continue with the start of the simulator.
Regards
carlos

In fact what happened was: i made the terrible mistake by assuming the program STOPT working but that was not the case: It had just minimized on starup!!! OMG my bad.
So conclusion : It runs fine!


Prevent empty revision on install

commands like istioctl install --revision $REVISION should not result in in-place upgrades when $REVISION isn't set.
Fixes #26940

@therealmitchconnors: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
ffd928819fd6a44ef1238ab435e456e59ab27557
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@therealmitchconnors: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
ffd928819fd6a44ef1238ab435e456e59ab27557
link
/test release-notes_istio

analyze-tests_istio
ffd928819fd6a44ef1238ab435e456e59ab27557
link
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@therealmitchconnors: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
ffd928819fd6a44ef1238ab435e456e59ab27557
link
/test release-notes_istio

analyze-tests_istio
ffd928819fd6a44ef1238ab435e456e59ab27557
link
/test analyze-tests_istio

integ-pilot-k8s-tests_istio
ffd928819fd6a44ef1238ab435e456e59ab27557
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@therealmitchconnors: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
ffd928819fd6a44ef1238ab435e456e59ab27557
link
/test analyze-tests_istio

integ-pilot-k8s-tests_istio
ffd928819fd6a44ef1238ab435e456e59ab27557
link
/test integ-pilot-k8s-tests_istio

release-notes_istio
a90806937fe0eecc5fe5f3ae7594f1f3615d735c
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@therealmitchconnors: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
ffd928819fd6a44ef1238ab435e456e59ab27557
link
/test integ-pilot-k8s-tests_istio

release-notes_istio
a90806937fe0eecc5fe5f3ae7594f1f3615d735c
link
/test release-notes_istio

analyze-tests_istio
a90806937fe0eecc5fe5f3ae7594f1f3615d735c
link
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@therealmitchconnors: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
a90806937fe0eecc5fe5f3ae7594f1f3615d735c
link
/test release-notes_istio

analyze-tests_istio
a90806937fe0eecc5fe5f3ae7594f1f3615d735c
link
/test analyze-tests_istio

integ-pilot-k8s-tests_istio
a90806937fe0eecc5fe5f3ae7594f1f3615d735c
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@therealmitchconnors: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
a90806937fe0eecc5fe5f3ae7594f1f3615d735c
link
/test analyze-tests_istio

integ-pilot-k8s-tests_istio
a90806937fe0eecc5fe5f3ae7594f1f3615d735c
link
/test integ-pilot-k8s-tests_istio

release-notes_istio
bc446e5ab28acd2880c709e8bb7d6a4eb73dd84f
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@therealmitchconnors: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
bc446e5ab28acd2880c709e8bb7d6a4eb73dd84f
link
/test release-notes_istio

integ-pilot-k8s-tests_istio
bc446e5ab28acd2880c709e8bb7d6a4eb73dd84f
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@therealmitchconnors: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
bc446e5ab28acd2880c709e8bb7d6a4eb73dd84f
link
/test integ-pilot-k8s-tests_istio

release-notes_istio
f9dd907cb51608e9b5932a27c2804b521b6ea97c
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes_istio

@therealmitchconnors should this show up in release notes? It looks like a change in istioctl to will return an error when REVISION isn't set. Other than that, LGTM

@therealmitchconnors: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
b79b639c83009b8a4e2984bdca41bf6300852ca8
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@therealmitchconnors: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
b79b639c83009b8a4e2984bdca41bf6300852ca8
link
/test lint_istio

release-notes_istio
b79b639c83009b8a4e2984bdca41bf6300852ca8
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@therealmitchconnors: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
b79b639c83009b8a4e2984bdca41bf6300852ca8
link
/test lint_istio

release-notes_istio
b79b639c83009b8a4e2984bdca41bf6300852ca8
link
/test release-notes_istio

gencheck_istio
b79b639c83009b8a4e2984bdca41bf6300852ca8
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@therealmitchconnors: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
b79b639c83009b8a4e2984bdca41bf6300852ca8
link
/test lint_istio

release-notes_istio
b79b639c83009b8a4e2984bdca41bf6300852ca8
link
/test release-notes_istio

gencheck_istio
b79b639c83009b8a4e2984bdca41bf6300852ca8
link
/test gencheck_istio

integ-pilot-k8s-tests_istio
b79b639c83009b8a4e2984bdca41bf6300852ca8
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@therealmitchconnors: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
b79b639c83009b8a4e2984bdca41bf6300852ca8
link
/test lint_istio

gencheck_istio
b79b639c83009b8a4e2984bdca41bf6300852ca8
link
/test gencheck_istio

integ-pilot-k8s-tests_istio
b79b639c83009b8a4e2984bdca41bf6300852ca8
link
/test integ-pilot-k8s-tests_istio

release-notes_istio
27f13b4df3bcdba7c7e5265bddf3455000aac333
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@therealmitchconnors: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
b79b639c83009b8a4e2984bdca41bf6300852ca8
link
/test gencheck_istio

integ-pilot-k8s-tests_istio
b79b639c83009b8a4e2984bdca41bf6300852ca8
link
/test integ-pilot-k8s-tests_istio

lint_istio
27756f064fa648d0c8f686da3b42989bdae69229
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@therealmitchconnors: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
b79b639c83009b8a4e2984bdca41bf6300852ca8
link
/test integ-pilot-k8s-tests_istio

lint_istio
27756f064fa648d0c8f686da3b42989bdae69229
link
/test lint_istio

gencheck_istio
27756f064fa648d0c8f686da3b42989bdae69229
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@therealmitchconnors: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
27756f064fa648d0c8f686da3b42989bdae69229
link
/test lint_istio

gencheck_istio
27756f064fa648d0c8f686da3b42989bdae69229
link
/test gencheck_istio

integ-pilot-k8s-tests_istio
27756f064fa648d0c8f686da3b42989bdae69229
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@therealmitchconnors: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
27756f064fa648d0c8f686da3b42989bdae69229
link
/test lint_istio

gencheck_istio
27756f064fa648d0c8f686da3b42989bdae69229
link
/test gencheck_istio

integ-pilot-k8s-tests_istio
27756f064fa648d0c8f686da3b42989bdae69229
link
/test integ-pilot-k8s-tests_istio

analyze-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@therealmitchconnors: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
27756f064fa648d0c8f686da3b42989bdae69229
link
/test lint_istio

gencheck_istio
27756f064fa648d0c8f686da3b42989bdae69229
link
/test gencheck_istio

integ-pilot-k8s-tests_istio
27756f064fa648d0c8f686da3b42989bdae69229
link
/test integ-pilot-k8s-tests_istio

analyze-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test analyze-tests_istio

release-test_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@therealmitchconnors: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
27756f064fa648d0c8f686da3b42989bdae69229
link
/test lint_istio

gencheck_istio
27756f064fa648d0c8f686da3b42989bdae69229
link
/test gencheck_istio

integ-pilot-k8s-tests_istio
27756f064fa648d0c8f686da3b42989bdae69229
link
/test integ-pilot-k8s-tests_istio

analyze-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test analyze-tests_istio

release-test_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test release-test_istio

unit-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@therealmitchconnors: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
27756f064fa648d0c8f686da3b42989bdae69229
link
/test gencheck_istio

integ-pilot-k8s-tests_istio
27756f064fa648d0c8f686da3b42989bdae69229
link
/test integ-pilot-k8s-tests_istio

analyze-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test analyze-tests_istio

release-test_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test release-test_istio

unit-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test unit-tests_istio

lint_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@therealmitchconnors: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
27756f064fa648d0c8f686da3b42989bdae69229
link
/test gencheck_istio

integ-pilot-k8s-tests_istio
27756f064fa648d0c8f686da3b42989bdae69229
link
/test integ-pilot-k8s-tests_istio

analyze-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test analyze-tests_istio

release-test_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test release-test_istio

unit-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test unit-tests_istio

lint_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test lint_istio

integ-telemetry-k8s-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@therealmitchconnors: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
27756f064fa648d0c8f686da3b42989bdae69229
link
/test gencheck_istio

integ-pilot-k8s-tests_istio
27756f064fa648d0c8f686da3b42989bdae69229
link
/test integ-pilot-k8s-tests_istio

analyze-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test analyze-tests_istio

release-test_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test release-test_istio

unit-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test unit-tests_istio

lint_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test lint_istio

integ-telemetry-k8s-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test integ-telemetry-k8s-tests_istio

integ-distroless-k8s-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@therealmitchconnors: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
27756f064fa648d0c8f686da3b42989bdae69229
link
/test integ-pilot-k8s-tests_istio

analyze-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test analyze-tests_istio

release-test_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test release-test_istio

unit-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test unit-tests_istio

lint_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test lint_istio

integ-telemetry-k8s-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test integ-telemetry-k8s-tests_istio

integ-distroless-k8s-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test integ-distroless-k8s-tests_istio

gencheck_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@therealmitchconnors: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
27756f064fa648d0c8f686da3b42989bdae69229
link
/test integ-pilot-k8s-tests_istio

analyze-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test analyze-tests_istio

release-test_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test release-test_istio

unit-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test unit-tests_istio

lint_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test lint_istio

integ-telemetry-k8s-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test integ-telemetry-k8s-tests_istio

integ-distroless-k8s-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test integ-distroless-k8s-tests_istio

gencheck_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test gencheck_istio

integ-operator-controller-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@therealmitchconnors: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
27756f064fa648d0c8f686da3b42989bdae69229
link
/test integ-pilot-k8s-tests_istio

analyze-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test analyze-tests_istio

release-test_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test release-test_istio

unit-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test unit-tests_istio

lint_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test lint_istio

integ-telemetry-k8s-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test integ-telemetry-k8s-tests_istio

integ-distroless-k8s-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test integ-distroless-k8s-tests_istio

gencheck_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test gencheck_istio

integ-operator-controller-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@therealmitchconnors: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
27756f064fa648d0c8f686da3b42989bdae69229
link
/test integ-pilot-k8s-tests_istio

analyze-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test analyze-tests_istio

release-test_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test release-test_istio

unit-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test unit-tests_istio

lint_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test lint_istio

integ-telemetry-k8s-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test integ-telemetry-k8s-tests_istio

integ-distroless-k8s-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test integ-distroless-k8s-tests_istio

gencheck_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test gencheck_istio

integ-operator-controller-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@therealmitchconnors: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test analyze-tests_istio

release-test_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test release-test_istio

unit-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test unit-tests_istio

lint_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test lint_istio

integ-telemetry-k8s-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test integ-telemetry-k8s-tests_istio

integ-distroless-k8s-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test integ-distroless-k8s-tests_istio

gencheck_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test gencheck_istio

integ-operator-controller-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@therealmitchconnors: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test analyze-tests_istio

release-test_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test release-test_istio

unit-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test unit-tests_istio

lint_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test lint_istio

integ-telemetry-k8s-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test integ-telemetry-k8s-tests_istio

integ-distroless-k8s-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test integ-distroless-k8s-tests_istio

gencheck_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test gencheck_istio

integ-operator-controller-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@therealmitchconnors: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test analyze-tests_istio

release-test_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test release-test_istio

unit-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test integ-telemetry-k8s-tests_istio

integ-distroless-k8s-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test integ-security-k8s-tests_istio

lint_istio
53630a1de8261ce1bc0682348fc93f3cd0a1ea3d
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@therealmitchconnors: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
d8c82b46e198e151043e982ff5f5ed9c9024692f
link
/test integ-multicluster-k8s-tests_istio

lint_istio
53630a1de8261ce1bc0682348fc93f3cd0a1ea3d
link
/test lint_istio

integ-pilot-k8s-tests_istio
53630a1de8261ce1bc0682348fc93f3cd0a1ea3d
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@therealmitchconnors: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
53630a1de8261ce1bc0682348fc93f3cd0a1ea3d
link
/test lint_istio

integ-pilot-k8s-tests_istio
53630a1de8261ce1bc0682348fc93f3cd0a1ea3d
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
53630a1de8261ce1bc0682348fc93f3cd0a1ea3d
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@therealmitchconnors: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
5703ae7612d05a6b9a56b4e773a4bd5d798458cf
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@therealmitchconnors: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
5703ae7612d05a6b9a56b4e773a4bd5d798458cf
link
/test integ-pilot-k8s-tests_istio

integ-pilot-multicluster-tests_istio
5703ae7612d05a6b9a56b4e773a4bd5d798458cf
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@therealmitchconnors: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
5703ae7612d05a6b9a56b4e773a4bd5d798458cf
link
/test integ-pilot-multicluster-tests_istio

analyze-tests_istio
8c792a7bd50e7a0e105424c96a56679190e85f73
link
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@therealmitchconnors: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
5703ae7612d05a6b9a56b4e773a4bd5d798458cf
link
/test integ-pilot-multicluster-tests_istio

analyze-tests_istio
8c792a7bd50e7a0e105424c96a56679190e85f73
link
/test analyze-tests_istio

unit-tests_istio
8c792a7bd50e7a0e105424c96a56679190e85f73
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@therealmitchconnors: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
5703ae7612d05a6b9a56b4e773a4bd5d798458cf
link
/test integ-pilot-multicluster-tests_istio

analyze-tests_istio
8c792a7bd50e7a0e105424c96a56679190e85f73
link
/test analyze-tests_istio

unit-tests_istio
8c792a7bd50e7a0e105424c96a56679190e85f73
link
/test unit-tests_istio

lint_istio
8c792a7bd50e7a0e105424c96a56679190e85f73
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@therealmitchconnors: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
5703ae7612d05a6b9a56b4e773a4bd5d798458cf
link
/test integ-pilot-multicluster-tests_istio

analyze-tests_istio
8c792a7bd50e7a0e105424c96a56679190e85f73
link
/test analyze-tests_istio

unit-tests_istio
8c792a7bd50e7a0e105424c96a56679190e85f73
link
/test unit-tests_istio

lint_istio
8c792a7bd50e7a0e105424c96a56679190e85f73
link
/test lint_istio

integ-ipv6-k8s-tests_istio
8c792a7bd50e7a0e105424c96a56679190e85f73
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@therealmitchconnors: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
5703ae7612d05a6b9a56b4e773a4bd5d798458cf
link
/test integ-pilot-multicluster-tests_istio

analyze-tests_istio
8c792a7bd50e7a0e105424c96a56679190e85f73
link
/test analyze-tests_istio

unit-tests_istio
8c792a7bd50e7a0e105424c96a56679190e85f73
link
/test unit-tests_istio

lint_istio
8c792a7bd50e7a0e105424c96a56679190e85f73
link
/test lint_istio

integ-ipv6-k8s-tests_istio
8c792a7bd50e7a0e105424c96a56679190e85f73
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
8c792a7bd50e7a0e105424c96a56679190e85f73
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@therealmitchconnors: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
5703ae7612d05a6b9a56b4e773a4bd5d798458cf
link
/test integ-pilot-multicluster-tests_istio

analyze-tests_istio
8c792a7bd50e7a0e105424c96a56679190e85f73
link
/test analyze-tests_istio

unit-tests_istio
8c792a7bd50e7a0e105424c96a56679190e85f73
link
/test unit-tests_istio

lint_istio
8c792a7bd50e7a0e105424c96a56679190e85f73
link
/test lint_istio

integ-ipv6-k8s-tests_istio
8c792a7bd50e7a0e105424c96a56679190e85f73
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
8c792a7bd50e7a0e105424c96a56679190e85f73
link
/test integ-distroless-k8s-tests_istio

release-test_istio
8c792a7bd50e7a0e105424c96a56679190e85f73
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@therealmitchconnors should this show up in release notes? It looks like a change in istioctl to will return an error when REVISION isn't set. Other than that, LGTM

When revision isn't set, istioctl install will continue work and set to default revision.  Is this correct?

When revision isn't set, istioctl install will continue work and set to default revision. Is this correct?

Yes, this PR differentiates between UNSET and EMPTY revision.  If the flag isn't specified, install proceeds as normal.  If the flag is specified, but the value is empty, as in the example (with intentional typo) below.
MY_REVISION=1.5.5
istioctl install --revision $MY-REVISION
ERROR

In response to a cherrypick label: #26959 failed to apply on top of branch "release-1.6":
Applying: reject empty revision
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
A	operator/cmd/mesh/install.go
Falling back to patching base and 3-way merge...
Auto-merging operator/cmd/mesh/manifest-apply.go
CONFLICT (content): Merge conflict in operator/cmd/mesh/manifest-apply.go
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 reject empty revision
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to a cherrypick label: new issue created for failed cherrypick: #27808

In response to a cherrypick label: #26959 failed to apply on top of branch "release-1.6":
Applying: reject empty revision
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
A	operator/cmd/mesh/install.go
Falling back to patching base and 3-way merge...
Auto-merging operator/cmd/mesh/manifest-apply.go
CONFLICT (content): Merge conflict in operator/cmd/mesh/manifest-apply.go
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 reject empty revision
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to a cherrypick label: new issue created for failed cherrypick: #27809

In response to a cherrypick label: #26959 failed to apply on top of branch "release-1.7":
Applying: reject empty revision
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
M	operator/cmd/mesh/install.go
Falling back to patching base and 3-way merge...
Auto-merging operator/cmd/mesh/install.go
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 reject empty revision
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to a cherrypick label: new issue created for failed cherrypick: #27810

In response to a cherrypick label: #26959 failed to apply on top of branch "release-1.7":
Applying: reject empty revision
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
M	operator/cmd/mesh/install.go
Falling back to patching base and 3-way merge...
Auto-merging operator/cmd/mesh/install.go
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 reject empty revision
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to a cherrypick label: new issue created for failed cherrypick: #27811


📃: Joke Teller Text To Speech

🔴 Title: Joke Teller Text To Speech
🔴 Tech stack: HTML, CSS, JavaScript
🔴 Objective: An interactive application that tells jokes using text-to-speech functionality, providing a fun and engaging way to share humor. Users can click a button to hear a random joke spoken aloud.
🔴 Summary: The Joke Teller app combines humor with technology, allowing users to hear random jokes spoken aloud using text-to-speech capabilities. Built with HTML, CSS, and JavaScript, the app offers a simple interface where users can easily get a new joke at the click of a button. The responsive design ensures that users can enjoy the jokes on any device, making it a delightful tool for sharing laughs.
📸 Screenshots: N/A
✅ Details to Include When Taking the Issue:
Name: Desh Deepak Kushwaha
Participant Role: GSSoC, Hacktoberfest
Happy Contributing! 🚀
Wishing you all the best on your open source journey. Enjoy! 😎

hey can you assign this to me under gsoc extended , hacktober fest accepted , level 2 tag


react native apk crash on android api lavel 22

Description
I have created a new APK but is it not running on Android API level 22 apk crashed
React Native Version
0.72.5
Output of npx react-native info
npx react-native info
warn Package rn-fetch-blob contains invalid configuration: "dependency.hooks" is not allowed. Please verify it's properly linked using "react-native config" command and contact the package maintainers about this.
info Fetching system and libraries information...
System:
OS: macOS 14.0
CPU: (8) arm64 Apple M2
Memory: 70.77 MB / 8.00 GB
Shell:
version: "5.9"
path: /bin/zsh
Binaries:
Node:
version: 20.3.0
path: ~/.nvm/versions/node/v20.3.0/bin/node
Yarn:
version: 1.22.19
path: /opt/homebrew/bin/yarn
npm:
version: 9.6.7
path: ~/.nvm/versions/node/v20.3.0/bin/npm
Watchman:
version: 2<IP_ADDRESS>
path: /opt/homebrew/bin/watchman
Managers:
CocoaPods:
version: 1.13.0
path: /Users/dipprokashsardar/.rvm/gems/ruby-2.7.6/bin/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 23.0
- iOS 17.0
- macOS 14.0
- tvOS 17.0
- watchOS 10.0
Android SDK:
API Levels:
- "33"
- "34"
Build Tools:
- 28.0.3
- 30.0.2
- 30.0.3
- 31.0.0
- 33.0.0
- 34.0.0
System Images:
- android-22 | Google APIs ARM 64 v8a
- android-28 | Google ARM64-V8a Play ARM 64 v8a
- android-33 | Google APIs ARM 64 v8a
- android-34 | Google APIs ARM 64 v8a
Android NDK: Not Found
IDEs:
Android Studio: 2022.2 AI-222.4459.24.2221.10121639
Xcode:
version: 15.0/15A240d
path: /usr/bin/xcodebuild
Languages:
Java:
version: 17.0.7
path: /usr/bin/javac
Ruby:
version: 2.7.6
path: /Users/dipprokashsardar/.rvm/rubies/ruby-2.7.6/bin/ruby
npmPackages:
"@react-native-community/cli": Not Found
react:
installed: 18.2.0
wanted: 18.2.0
react-native:
installed: 0.72.4
wanted: 0.72.4
react-native-macos: Not Found
npmGlobalPackages:
"react-native": Not Found
Android:
hermesEnabled: false
newArchEnabled: false
iOS:
hermesEnabled: true
newArchEnabled: false
Steps to reproduce
I have created a new APK but is it not running on Android API level 22 apk crashed
Snack, screenshot, or link to a repository
I have created a new APK but is it not running on Android API level 22 apk crashed

I have created a new APK but is it not running on Android API level 22 apk crashed

Closing as invalid. You need to provide the steps to reproduce + a reproducer.
Please don't just copy-n-paste a sentence in all the fields of the issue.
Moreover, you don't even provide a stacktrace of the crash. Please edit your issue and we can reopen it


AM PM

Assalam Alaykom
Can you add (12-hours style ---->>> am and pm ) ?
Thanks in advance

@ahmed-tasaly Sure, thanks for your improvisation

@ahmed-tasaly You can reinstall the latest version to be able to use the new features. Thanks 😁


possible to yield Map object?

Hi
I got this error, when yield a Map object,
'You may only yield a function, promise, generator, array, or object, but the following object was passed: "[object Map]"'
Is that possible to support Map?
Thanks

Hi,
Workaround would be:
yield Array.from(map.values())
\C

Am 05.10.2016 um 02:33 schrieb Siyang Bi<EMAIL_ADDRESS>Hi
I got this error, when yield a Map object,
'You may only yield a function, promise, generator, array, or object, but the following object was passed: "[object Map]"'
Is that possible to support Map?
Thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Or yield [...map.values()]

It works perfectly fine with .map.
For Example:
const result = yield array.map(x => task(x));
Where task() returns a promise and looks like:
const task = x => {     return new Promise((resolve, reject) => {         co(function*() {             const a = yield someTask(x) ;             const b = yield otherTask(a);             resolve(b);         }).catch(error => reject(error));     }); };
thus .map returns an array of promises. once all the promises are fulfilled result will be referring to array of all the bs

@harshitgupta Your code is a bit overhead.
co(function*(){...}) returns Promise ;)
That's why:
const task = x => co(function*(){
    const a = yield someTask(x);
    const b = yield someTask(y);
   return b;
});

const result = yield array.map(x => task(x))
// or simpler const result = yield array.map(task)

But co have function wrap. That's why the best solution is:
const task = co.wrap(function*(x){
   //somework
   return b;
});

const result = yield array.map(task);

Awesome!!! Thanks a lot for pointing it out.
I didn't know that.
I am little bit confused about the error handling. I have catch CB with my version of co. Would it just like:
.catch(error => error);
It doesn't seem right. :/
How would you handle it?
Thanks again.

@harshitgupta If you use co(function*(){ ... }):
co(function*(){
...
}).catch(err => console.error(err));

If you use co.wrap:
let handler = co.wrap(function*(p){
try {
...
} catch (err) {
console.error(err);
}
});

OP is about Map (the type), not Array.prototype.map).
+1, Map is even more appropriate than object for this.
In fact, "array or object" should really just be "iterable", as in, yielding an iterable for parallel execution.
I actually think this is a pretty big deal : co should be symmetrical with the newer builtin APIs and syntaxes like Map and Set (and weak variants), as well as for-of and yield* (it would be natural to want to yield* promises from an iterable in a co-generator)... and especially symmetry with Promise.all which is very relevant for parallel execution.
Objects are not actually iterables, though:
> for (let x of {});
TypeError: (intermediate value)[Symbol.iterator] is not a function

Dropping support for yielding objects would be a big breaking change, but it's not a big deal to say "iterables and plain objects". I would however suggest that non-iterable objects with a prototype other than Object or null should not be supported at all (not sure if that's the case now or not)


Determinism through serialization cycle

I'm trying to make a replay system based on determinism. Actions on the world are saved in a replay and are applied on a hecs::World. Entity objects are stored separately in resources and serialized too.
I have a determinism problem demonstrated via the following code.
If a world has gone through a serialization cycle, the entity allocation state is not serialized and therefore entity do not necessarily get the same IDs.
let mut w1 = World::new();
let e = w1.spawn((Comp,));
w1.despawn(e);

let w2 = deserialize(serialize(&w1)); // simplified for example

let e1 = w1.spawn((Comp,));
let e2 = w2.spawn((Comp,));

assert_eq!(e1, e2); // fail! generations don't match.
// A longer example can also show a set of operations where the id (not the genration) doesn't match either
// since the freelist is not saved.

From what I understand, this is intended.
What should I do if I want reproducible worlds that survive through serialization cycles?
That is, doing operations1 -> ser -> deser -> operations2 results in the same World as operations1 -> operations2.

What about attaching a persistent ID to each entity which could then be used to match up the new transient entity ID after deserialization? Actions would of course also have to record persistent ID of the entities they were applied to.

I would find it disappointing that I must have extra state when the information is already there (entities already have unique ids). But you're right it might be more robust. I'm not sure how much magic would be required to make this work.

Iteration order might also change, but I don't know enough about hecs internals to know about this.

I'm using the serialization as a way to build a replay system and I want to ensure determinism, so sadly cloning wouldn't help here.

I recognize the usefulness of being able to save/restore allocator state for some applications. I don't think it costs us much to expose the freelist for folks to serialize if they really want; even if we have to break it in the future, the cost of doing so is small.
Would you also need generations to be assigned consistently before/after serialization? That might be a good chunk of additional data, and a bit harder to expose ergonomically.

How big would it really be? It's all about saving the IDs which aren't that big, no? I'd say generation is not that expensive and ensures 100% state restoration.

Generations would double the amount of data, and aren't conveniently laid out in a dense slice. Not a deal breaker, but would require a bit of thought to expose gracefully.

It doubles the amount of data if entity IDs are the only thing serialized.
What is the impact of generations? If you do a world.contains(3v3) on an entity that is stored as 3v1, does the get succeed?
If so, not serializing the generations is not an issue since they just reset to a lower value and so have no observable behavior change.

Hey @Ralith I would be interested in this feature too. What additional data would we need to serialize when serializing a world?
I was looking trough the code and it seems like the "big thing" is to fully serialize the Entities struct inside world, to get consistent ids and generations.
To get a bit by bit identical world  we would also in theory need to serialize the id field of the world, do you think that would be relevant?
Would we need to serialize any of the other members of world?
Thanks for the great work btw!

Two additional pieces of data need to be exposed, both from the entity allocator

The freelist: required to ensure entities are allocated in consistent order
The generation counters of non-live entities: required to ensure allocated entities have the same generations

APIs are needed to both expose this information, and to allow it to be provided to a new world.

To get a bit by bit identical world we would also in theory need to serialize the id field of the world, do you think that would be relevant?

No, that ID's purpose is to only distinguish different World objects at runtime. Providing any way to set it would be unsafe.


Debug

Please add the fact that in order for a forgot password email to be sent the user must #1 exist in the DB and #2 the user must have EmailConfirmed Set to True. Also, if that is not the case there is no indication of that via the web interface, the email is never attempted to be sent.
I would like like to suggest that if env.IsDevelopment() is true that feedback be provided these requirments. - Thx

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fe1bea60-d173-f6d2-3559-b147699e295a
Version Independent ID: 98e7aacb-2a01-d581-9b03-bfef2893163e
Content: Account confirmation and password recovery in ASP.NET Core
Content Source: aspnetcore/security/authentication/accconfirm.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

 #1 is obvious but  #2 might be worth mentioning.

I would question the wisdom of the #2 behavior. Given that there UI gives no clue that no email was sent, this can leave the user in a black hole trying to restore a login.

I followed this tutorial on .net core 3.1
and whatever I do the email is not sending.
I debugged the application and it really execute the Task Execute method but, I did not received any using forgot password and verify account. I also checked the SendGrid stats it's always 0.
Anyone can enlighten me with this would be much appreciated.

The issue is twofold:

The code has a bug in that it's not awaiting on the call to SendGrid.
The code isn't checking the response sent from the call to see if it was successful.

If you debug and break on the email send, you should be able to get the email to send. But if you just run it, the thread will end before the request is sent due to the missing await.
This code is working for me and includes the missing awaits as well as a check for the response to be successful:
        public async Task SendEmailAsync(string email, string subject, string message)
        {
            var response = await Execute(Options.SendGridKey, subject, message, email);

            if(response.StatusCode != System.Net.HttpStatusCode.Accepted)
            {
                // log or throw
                throw new Exception("Could not send email: " + await response.Body.ReadAsStringAsync());
            }
        }

        private async Task<Response> Execute(string apiKey, string subject, string message, string email)
        {
            var client = new SendGridClient(apiKey);
            var msg = new SendGridMessage()
            {
                From = new<EMAIL_ADDRESS>"Admin"),
                Subject = subject,
                PlainTextContent = message,
                HtmlContent = message
            };
            msg.AddTo(new EmailAddress(email));

            // Disable click tracking.
            // See https://sendgrid.com/docs/User_Guide/Settings/tracking.html
            msg.SetClickTracking(false, false);

            return await client.SendEmailAsync(msg);
        }

@ardalis  do you want to open an issue on the template?

For me, password reset emails work perfectly but the confirmation message is never sent. I have a breakpoint in the start of the SendEmailAsync method and it's hit every time for password reset but never for confirmation.

I actually placed a break point in SendEmailAsync on the call to the Execute method, on the construction of the SendGridClient, and on "return client.SendEmailAsync();".  None of these are being called... I have checked to make sure that this:
// Sets up email confirmation
services.AddTransient<IEmailSender, EmailSender>();
services.Configure(Configuration);
services.AddRazorPages();
is within the configure services method as well.
What would be the steps in figuring out why the SendEmailAsync is not being called?

Ok, I figured out my issue...but this very well could be a bug.
If you add an external authentication method (i.e. Microsoft Authentication), when you click on register and are presented with the registration page you can register with the external authentication method (in my case Microsoft Authentication) as opposed to creating a local account.  If you use external authentication as your registration method, then the email confirmation process is completely bypassed/ignored.
Is this "as by design" or is this a bug?
If it is a bug, then does anyone have advice on the best way to invoke the email confirmation and/or auto-verify (confirm) the account once the external authentication process has completed with success?

Forgot to mention... even though the email confirmation process is never invoked (i.e. SendEmailAsync is never called) when you register using an external authorization as opposed to local, upon completing the external authentication process successfully it will place the user back on the "Register Confirmation" page.
So, either it should "auto confirm" upon success of the external authentication process and proceed to the confirmation complete page =or= it should invoke the SendEmailAsync method.
Any thoughts are appreciated!  :)

I worked the exercise a second time with success. Here are the details of the entire exercise on Stack Overflow. https://stackoverflow.com/questions/60617079/core3-react-confirmation-email-not-sent

Well, I am using SendGrid and am assuming you were still using your exchange server when you worked through it again?   I too started from scratch (starting with the very beginning of this example and then adding the external authentication afterwards).  So, there was no 3.0 to 3.1 back and fourth in my case.  Just the example, SendGrid, and Microsoft Authentication.   Maybe I missed a step, but I already started a new project from scratch and everything so far looks identical...will pickup on this tomorrow and see if the next version I am working through works.
Although, it is a bit unnerving that you could make changes to your solution (even if just switching between frameworks) and it could completely break the authentication process...with no real way (other than building .NETCore and debugging through that) to determine what is "broken".  Also, last time I installed the JDK on one of my development machines (about 12 years ago) it got infected with a virus (the first and only time I had a system get compromised)...so not too keen on having to install the JDK I order to build debug binaries in order to debug something that should already be "debuggable".
Doesn't look like they offer debug builds on GitHub.  Would be great if you could get debug builds of the current version so you could still debug through but not have to build it (and install all the required tools/sdks).
Will let you know how my second pass goes.

Solve one problem at a time. DummyEmailSender from my SO question that you have obviously read does nothing but meet the interface contract, and log the fact that SendEmailAsync is called. Use that and see whether you can get correct behaviour.

Read this, learn to scaffold, then debug.
https://stackoverflow.com/questions/60739857/how-to-customise-or-style-the-auth-ux-in-dotnet-core-3

Thank you Peter!  The Scaffold path was exactly what I needed.  I am ramping back up with all of the ASP/Razor/NET Core Web Application stuff that has changed over the past 7-8 years (I was primarily writing network drivers during that time).  Either case, I went ahead and generated all of the RTL source for Identity and I believe I now know what is the issue with External Authentication:
Within the ExternalLogin.cshtml.cs file you will find the OnPostConfirmationAsync method and within that method this is the code of interest with the suspect culprit in bold:
          var user = new IdentityUser { UserName = Input.Email, Email = Input.Email };
            var result = await _userManager.CreateAsync(user);
            if (result.Succeeded)
            {
                result = await _userManager.AddLoginAsync(user, info);
                if (result.Succeeded)
                {
                    _logger.LogInformation("User created an account using {Name} provider.", info.LoginProvider);

                    // If account confirmation is required, we need to show the link if we don't have a real email sender
                    **if (_userManager.Options.SignIn.RequireConfirmedAccount)
                    {
                        return RedirectToPage("./RegisterConfirmation", new { Email = Input.Email });
                    }**

                    await _signInManager.SignInAsync(user, isPersistent: false);
                    var userId = await _userManager.GetUserIdAsync(user);
                    var code = await _userManager.GenerateEmailConfirmationTokenAsync(user);
                    code = WebEncoders.Base64UrlEncode(Encoding.UTF8.GetBytes(code));
                    var callbackUrl = Url.Page(
                        "/Account/ConfirmEmail",
                        pageHandler: null,
                        values: new { area = "Identity", userId = userId, code = code },
                        protocol: Request.Scheme);

                    await _emailSender.SendEmailAsync(Input.Email, "Confirm your email",
                        $"Please confirm your account by clicking here.");

                    return LocalRedirect(returnUrl);
                }
            }

=============================================
What I believe is happening is that the SignIn.RequireConfirmedAccount is true and it bypasses sending any confirmation email and just redirects the user directly to the RegisterConfirmation page.  This is why (I believe) using external authentication as your registration method will dump the user to the "Registration Confirmation" page stating an email has been sent but in reality it never gets sent.
The first time I debugged it, I let it naturally progress and noted that once it redirects to the register confirmation page it never calls SendEmailAsync.  The 2nd time I debugged it, I went ahead and manually jumped pass that SignIn.RequireConfirmedAccount check and while it did send the email it just returned me back to the default/home page.
My best guess would be if I were to remove this:
                    if (_userManager.Options.SignIn.RequireConfirmedAccount)
                    {
                        return RedirectToPage("./RegisterConfirmation", new { Email = Input.Email });
                    }

=================================================
And then add it back towards the end of the OnPostConfirmationAsync method like such:
                    if (_userManager.Options.SignIn.RequireConfirmedAccount)
                    {
                        return RedirectToPage("./RegisterConfirmation", new { Email = Input.Email });
                    }
                    else
                    {
                        return LocalRedirect(returnUrl);
                    }

=================================================
Then it would send the email & push the user to the Register Confirmation page.
Any thoughts on this? (Good/Bad Idea)?
Either case, thank you for your tips/guidance!  Once I ran through the Scaffold Identity article, everything "clicked into place"...
Cheers,
Noel

It is not a good idea... still mulling over the best solution...

For anyone else who finds themselves reading through these threads here are some additional modifications to the above changes to fix some issues with whether the user should be logged in or not during the registration process.
I added an additional call to sign out the externally authenticated user in order to assure that it doesn't keep the user logged in while still waiting for authentication:

                    if (_userManager.Options.SignIn.RequireConfirmedAccount)
                    {
                        await _signInManager.SignOutAsync();
                        return RedirectToPage("./RegisterConfirmation", new { Email = Input.Email });
                    }
                    else
                    {
                        return LocalRedirect(returnUrl);
                    }

Additionally, in the same ExternalLogin.cshtml.cs file I also modified the OnGetCallbackAsync method with this:

            // If the user does not have an account, then ask the user to create an account.
            ReturnUrl = returnUrl;
            LoginProvider = info.LoginProvider;
            if (info.Principal.HasClaim(c => c.Type == ClaimTypes.Email))
            {
                Input = new InputModel
                {
                    Email = info.Principal.FindFirstValue(ClaimTypes.Email)
                };
                // Check for a user account waiting to be confirmed via email
                var userinfo = await _userManager.FindByNameAsync(Input.Email);
                if (userinfo != null && !userinfo.EmailConfirmed)
                {
                    // User hasn't confirmed yet, so just push them to the register confirmation page
                    return RedirectToPage("./RegisterConfirmation", new { Email = Input.Email });
                }
            }

While I am sure there are much better ways to handle user login states, this is just a heads up for anyone else that ran into similar issues (starting with the issue of email confirmations for users that register with an external authentication source).  The two above changes assures that the user is not considered "logged in" until they have confirmed their email address as well as assures that if the user returns without confirming it will see they have registered but not confirmed and will just display the "Register Confirmation" page.
Anyway, thank you Peter for pointing me in the right direction... going to start reading up on additional materials regarding user authentication states and management of them from page to page (etc).

Where can we possibly find latest version typical implementation examples of ASP.Net Core Identity razor pages? ASP.Net Core 3.1 Identity all pages in Areas/Identity for example.. New learners need those examples but things are changing fast and teacher candidates keep being students in this fast change.


Help with running it

Hello, I would like to know if someone could help me figure out why I keep on getting the same mistake multiple time related to torch
Here is my issue, When I run the line below, I get the module torch not found even though it is there.
'D:\stable-diffusion-webui\SD-CN-Animation>python3 compute_flow.py -i "C:\Users\Arnaud***\Downloads\Remove0417_720p.mov" -o "D:\stable-diffusion-webui\SD-CN-Animation\EXPORT" -v -W 720 -H 540
Traceback (most recent call last):
File "D:\stable-diffusion-webui\SD-CN-Animation\compute_flow.py", line 7, in
from flow_utils import RAFT_estimate_flow
File "D:\stable-diffusion-webui\SD-CN-Animation\flow_utils.py", line 9, in
import torch
ModuleNotFoundError: No module named 'torch' '
What could be the problem?

Did you install the prerequisites?

are you running it inside the environment of your sd?

Yes all the prerequisites are installed but I am running it inside of the env of SD,
Should I setup a conda env for it,
sorry I'm really new at all of this

i would setup a separate environment for raft, there are different torch versions across all these ML projects and ive never been able to get them working outside of individual environments

Ok, thanks all for the tips, I will try again to run it,


🐛 Ensure Workflows work for forked repos

This issue was found by JK when trying to fix an issue via a fork: https://github.com/SSWConsulting/SSW.CleanArchitecture/pull/147
We need to ensure that the workflows successfully run for any forked repos

Done - see https://youtu.be/h05ZuwgOa8Q
Hey @jernejk 👋 feel free to contribute

Is it possible now for external people to pass build. Last time, I didn't had enough permissions to pass the build.


Provide pre-built binaries?

The build time for this package is long - like >30minutes.
Perhaps we should consider publishing an NPM/esy package with prebuilt binaries, like esy-cmake-prebuilt?

In addition... perhaps we could just copy the cmake.exe on Windows and address #3 too (so the bin is at least sandboxed).


add bootstrap governance doc

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

There's no merge rules on this repo, so feel free to merge whenever your think it's ready!
(thought you now have three ✅ )


rkt: remove

rkt has basically been dead since 2018 and now upstream has made it official.

https://github.com/rkt/rkt/#warning-end-of-project-warning

This project has ended, and all development/maintenance activities have halted.
As it is free software, people are free and welcome to fork and develop the codebase on their own. However, to avoid any confusion, the original repository is archived and we recommend any further fork/development to proceed with an explicit rename and rebranding first.
We encourage all interested parties to mirror any relevant bits as we can't actively guarantee their existence in the future.

More detail in https://github.com/rkt/rkt/issues/4024#issue-560656198

Although I am not a rkt user, the reaction seems premature.
It is only 1 month since commercial team cased work on it.
There could be users still ((the project has 9000 stars - twice as much as nixpkgs)
The community could continue development as we saw with rethinkdb after the failure of their commercial team.

What is the opinion of the maintainer? @ragnard @steveeJ

Also @NeQuissimus who did maintenance on the package.

All I can say is that I stopped using it :)
I would suggest keeping it around for a little while longer to see if any other entity takes over the repo. But if not, we should make sure this has been deleted for NixOS 20.09

I don't know what the policy says about packages which are unmaintained upstream. If there's no policy I suggest establishing one so these decisions are covered in the future. Personally I agree with @volth that it seems premature to removing it now. Maybe wait 2 more months?

On the other hand, if the software still works, has users and doesn't have glaring security vulnerabilities, I don't think there's a problem with not removing it.

It seems that last year the CNCF archived it and Gentoo removed it because of security issues and an inactive upstream.
https://bugs.gentoo.org/687100
https://github.com/cncf/toc/pull/262
https://www.cncf.io/blog/2019/08/16/cncf-archives-the-rkt-project/
https://github.com/rkt/rkt/issues/3999
https://www.twistlock.com/labs-blog/breaking-out-of-coresos-rkt-3-new-cves/

That sounds like reason enough to remove it pretty soon

It is only 1 month since the commercial team ceased work on it.

The note in the ticket about dismantlement of the official team was a quotation from summer.  They declared end because "community" hasn't picked it up since then.

There are some CVEs there, so an alternative is to just use meta.knownVulnerabilities for now :man_shrugging:

just use meta.knownVulnerabilities for now

Opened https://github.com/NixOS/nixpkgs/pull/82023

I backported the cve list to 19.09 and 20.03 as well.

This issue is handled as discussed by #82023. Might as well close this, and revisit for 20.09.

We can also just keep this open for 20.09 as a milestone.

There are now open CVEs for rkt and no fork has appeared. I think it's fair to say that we can proceed.

I couldn't find anything.


sections.filter is not a function

Hi,
Any ideas why I get this error?
I have everything included, should be fine I think.

after adding fullPageConfigProvider with the default options (mentioned in readme) I have this error

Have you included jQuery library?

Yes I have, and it's included before the plugin.

Ok. Can you try to get the value of "sections" variable in 'setOptionsFromDOM' function? Maybe it's empty or not an array. You can try to execute the 'find' and 'filter' methods for any array too for check jQuery is working correctly.

@balazs-guti, seems like it's file order problem. Try to include jquery first! It should help.
@mmautomatizacion could you add jquery as a dependency for npm and bower packages, please?

@balazs-guti check the order of file inject. jQuery must be before mm.angular-fullpage.js.
@Domanskiy, I just added jQuery dependency for NPM and Bower. Thanks for advice.


How to retrieve the log file name from within the code once the configuration is set

I am creating a shared lib of my code where I initialize the ELPP. I set the configuration using a config file which provides the name of the log file in GLOBAL level. Is it possible to retrieve the name of this log file using any function of ELPP?  I need to provide the log file name as a return value of a function to some other app.

Have you considered typedConfigurations() of the logger?
Let us know how you go. I am closing this for now and if this does not answer you question i will re-open it.