Add back MCP (mesh config protocol) support, using XDS transport.

The distribution of Istio high level APIs has been approved and available for few Istio releases, including 1.5 - as part of Galley.
Design doc:
https://docs.google.com/document/d/1lHjUzDY-4hxElWN7g6pz-_Ws7yIPt62tmX3iGs_uLyI/edit#
Istiod design doc included merging of Galley functionality in Istiod - however due to size and duplication this didn't happen, and we agreed to not ship Galley in 1.6.
This PR restores the lost ability to distribute mesh config - but reusing the Pilot XDS infrastructure
and transport. It is also the first step  towards UDPA.

@costinm: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test unit-tests_istio

integ-local-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-local-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test unit-tests_istio

integ-local-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-local-tests_istio

release-test_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test unit-tests_istio

integ-local-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-local-tests_istio

release-test_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test release-test_istio

integ-pilot-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test unit-tests_istio

integ-local-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-local-tests_istio

release-test_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test release-test_istio

integ-pilot-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-pilot-k8s-tests_istio

lint_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test unit-tests_istio

integ-local-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-local-tests_istio

release-test_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test release-test_istio

integ-pilot-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-pilot-k8s-tests_istio

lint_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test lint_istio

integ-security-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test unit-tests_istio

integ-local-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-local-tests_istio

release-test_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test release-test_istio

integ-pilot-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-pilot-k8s-tests_istio

lint_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test lint_istio

integ-security-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test unit-tests_istio

integ-local-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-local-tests_istio

release-test_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test release-test_istio

integ-pilot-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-pilot-k8s-tests_istio

lint_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test lint_istio

integ-security-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test unit-tests_istio

integ-local-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-local-tests_istio

release-test_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test release-test_istio

integ-pilot-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-pilot-k8s-tests_istio

lint_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test lint_istio

integ-security-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-telemetry-k8s-tests_istio

integ-conformance-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-conformance-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test unit-tests_istio

integ-local-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-local-tests_istio

release-test_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test release-test_istio

integ-pilot-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-pilot-k8s-tests_istio

lint_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test lint_istio

integ-security-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-telemetry-k8s-tests_istio

integ-conformance-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-conformance-k8s-tests_istio

integ-distroless-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test unit-tests_istio

integ-local-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-local-tests_istio

release-test_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test release-test_istio

integ-pilot-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-pilot-k8s-tests_istio

lint_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test lint_istio

integ-security-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-telemetry-k8s-tests_istio

integ-conformance-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-conformance-k8s-tests_istio

integ-distroless-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test unit-tests_istio

integ-local-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-local-tests_istio

release-test_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test release-test_istio

integ-pilot-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-pilot-k8s-tests_istio

lint_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test lint_istio

integ-security-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-telemetry-k8s-tests_istio

integ-conformance-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-conformance-k8s-tests_istio

integ-distroless-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-multicluster-k8s-tests_istio

gencheck_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test unit-tests_istio

integ-local-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-local-tests_istio

release-test_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test release-test_istio

integ-pilot-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-pilot-k8s-tests_istio

lint_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test lint_istio

integ-security-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-telemetry-k8s-tests_istio

integ-conformance-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-conformance-k8s-tests_istio

integ-distroless-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-multicluster-k8s-tests_istio

gencheck_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test gencheck_istio

integ-galley-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-local-tests_istio

release-test_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test release-test_istio

integ-pilot-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-pilot-k8s-tests_istio

lint_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test lint_istio

integ-security-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-telemetry-k8s-tests_istio

integ-conformance-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-conformance-k8s-tests_istio

integ-distroless-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-multicluster-k8s-tests_istio

gencheck_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test gencheck_istio

integ-galley-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-galley-k8s-tests_istio

unit-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-local-tests_istio

release-test_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test release-test_istio

integ-pilot-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-pilot-k8s-tests_istio

lint_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test lint_istio

integ-mixer-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-telemetry-k8s-tests_istio

integ-conformance-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-conformance-k8s-tests_istio

integ-distroless-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-multicluster-k8s-tests_istio

gencheck_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test gencheck_istio

integ-galley-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-galley-k8s-tests_istio

unit-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test unit-tests_istio

integ-security-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-local-tests_istio

release-test_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test release-test_istio

integ-pilot-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-pilot-k8s-tests_istio

integ-mixer-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-telemetry-k8s-tests_istio

integ-conformance-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-conformance-k8s-tests_istio

integ-distroless-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-multicluster-k8s-tests_istio

gencheck_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test gencheck_istio

integ-galley-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-galley-k8s-tests_istio

unit-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test unit-tests_istio

integ-security-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-security-k8s-tests_istio

lint_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-local-tests_istio

release-test_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test release-test_istio

integ-mixer-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-telemetry-k8s-tests_istio

integ-conformance-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-conformance-k8s-tests_istio

integ-distroless-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-multicluster-k8s-tests_istio

gencheck_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test gencheck_istio

integ-galley-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-galley-k8s-tests_istio

unit-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test unit-tests_istio

integ-security-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-security-k8s-tests_istio

lint_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test lint_istio

integ-pilot-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test release-test_istio

integ-mixer-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-telemetry-k8s-tests_istio

integ-conformance-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-conformance-k8s-tests_istio

integ-distroless-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-multicluster-k8s-tests_istio

gencheck_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test gencheck_istio

integ-galley-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-galley-k8s-tests_istio

unit-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test unit-tests_istio

integ-security-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-security-k8s-tests_istio

lint_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test lint_istio

integ-pilot-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-pilot-k8s-tests_istio

integ-local-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-local-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test release-test_istio

integ-mixer-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-telemetry-k8s-tests_istio

integ-conformance-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-conformance-k8s-tests_istio

integ-distroless-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-multicluster-k8s-tests_istio

gencheck_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test gencheck_istio

unit-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test unit-tests_istio

integ-security-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-security-k8s-tests_istio

lint_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test lint_istio

integ-pilot-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-pilot-k8s-tests_istio

integ-local-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-local-tests_istio

integ-galley-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test release-test_istio

integ-mixer-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-telemetry-k8s-tests_istio

integ-conformance-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-conformance-k8s-tests_istio

integ-multicluster-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-multicluster-k8s-tests_istio

gencheck_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test gencheck_istio

unit-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test unit-tests_istio

integ-security-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-security-k8s-tests_istio

lint_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test lint_istio

integ-pilot-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-pilot-k8s-tests_istio

integ-local-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-local-tests_istio

integ-galley-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-galley-k8s-tests_istio

integ-distroless-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-telemetry-k8s-tests_istio

integ-conformance-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-conformance-k8s-tests_istio

integ-multicluster-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-multicluster-k8s-tests_istio

gencheck_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test gencheck_istio

unit-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test unit-tests_istio

integ-security-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-security-k8s-tests_istio

lint_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test lint_istio

integ-pilot-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-pilot-k8s-tests_istio

integ-local-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-local-tests_istio

integ-galley-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-galley-k8s-tests_istio

integ-distroless-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-distroless-k8s-tests_istio

integ-mixer-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-telemetry-k8s-tests_istio

integ-conformance-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-conformance-k8s-tests_istio

integ-multicluster-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-multicluster-k8s-tests_istio

gencheck_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test gencheck_istio

unit-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test unit-tests_istio

integ-security-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-security-k8s-tests_istio

lint_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test lint_istio

integ-pilot-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-pilot-k8s-tests_istio

integ-local-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-local-tests_istio

integ-galley-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-galley-k8s-tests_istio

integ-distroless-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-distroless-k8s-tests_istio

integ-mixer-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-mixer-k8s-tests_istio

release-test_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-multicluster-k8s-tests_istio

gencheck_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test gencheck_istio

unit-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test unit-tests_istio

integ-security-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-security-k8s-tests_istio

lint_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test lint_istio

integ-pilot-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-pilot-k8s-tests_istio

integ-local-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-local-tests_istio

integ-galley-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-galley-k8s-tests_istio

integ-distroless-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-distroless-k8s-tests_istio

integ-mixer-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-mixer-k8s-tests_istio

release-test_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test release-test_istio

integ-conformance-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-conformance-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test integ-multicluster-k8s-tests_istio

gencheck_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test gencheck_istio

unit-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test unit-tests_istio

integ-security-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-security-k8s-tests_istio

lint_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test lint_istio

integ-pilot-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-pilot-k8s-tests_istio

integ-local-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-local-tests_istio

integ-galley-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-galley-k8s-tests_istio

integ-distroless-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-distroless-k8s-tests_istio

integ-mixer-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-mixer-k8s-tests_istio

release-test_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test release-test_istio

integ-conformance-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-conformance-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
78626e985761224e5f04c709f192d9bf1fbd0136
link
/test gencheck_istio

unit-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test unit-tests_istio

integ-security-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-security-k8s-tests_istio

lint_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test lint_istio

integ-pilot-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-pilot-k8s-tests_istio

integ-local-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-local-tests_istio

integ-galley-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-galley-k8s-tests_istio

integ-distroless-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-distroless-k8s-tests_istio

integ-mixer-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-mixer-k8s-tests_istio

release-test_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test release-test_istio

integ-conformance-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-conformance-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test unit-tests_istio

integ-security-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-security-k8s-tests_istio

lint_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test lint_istio

integ-pilot-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-pilot-k8s-tests_istio

integ-local-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-local-tests_istio

integ-galley-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-galley-k8s-tests_istio

integ-distroless-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-distroless-k8s-tests_istio

integ-mixer-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-mixer-k8s-tests_istio

release-test_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test release-test_istio

integ-conformance-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-conformance-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-multicluster-k8s-tests_istio

gencheck_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

regarding the synthetic service entries - are those the only k8s resources needed to generate the full XDS?

regarding the synthetic service entries - are those the only k8s resources needed to generate the full XDS?

That seems to be all the MCP client side is using (the MCP registry we still have). I'm attempting to restore equivalent functionality in this PR, once the client side is good enough to run integration tests we can find out.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test unit-tests_istio

integ-security-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-security-k8s-tests_istio

lint_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test lint_istio

integ-pilot-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-pilot-k8s-tests_istio

integ-galley-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-galley-k8s-tests_istio

integ-distroless-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-distroless-k8s-tests_istio

integ-mixer-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-mixer-k8s-tests_istio

release-test_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test release-test_istio

integ-conformance-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-conformance-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-multicluster-k8s-tests_istio

gencheck_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test gencheck_istio

integ-local-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-local-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-security-k8s-tests_istio

lint_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test lint_istio

integ-pilot-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-pilot-k8s-tests_istio

integ-galley-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-galley-k8s-tests_istio

integ-distroless-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-distroless-k8s-tests_istio

integ-mixer-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-mixer-k8s-tests_istio

release-test_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test release-test_istio

integ-conformance-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-conformance-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-multicluster-k8s-tests_istio

gencheck_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test gencheck_istio

integ-local-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-local-tests_istio

unit-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-security-k8s-tests_istio

lint_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test lint_istio

integ-pilot-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-pilot-k8s-tests_istio

integ-galley-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-galley-k8s-tests_istio

integ-distroless-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-distroless-k8s-tests_istio

integ-mixer-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-mixer-k8s-tests_istio

integ-conformance-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-conformance-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-multicluster-k8s-tests_istio

gencheck_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test gencheck_istio

integ-local-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-local-tests_istio

unit-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test unit-tests_istio

release-test_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-security-k8s-tests_istio

lint_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test lint_istio

integ-pilot-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-pilot-k8s-tests_istio

integ-galley-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-galley-k8s-tests_istio

integ-distroless-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-distroless-k8s-tests_istio

integ-mixer-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-multicluster-k8s-tests_istio

gencheck_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test gencheck_istio

integ-local-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-local-tests_istio

unit-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test unit-tests_istio

release-test_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test release-test_istio

integ-conformance-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-conformance-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test lint_istio

integ-pilot-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-pilot-k8s-tests_istio

integ-galley-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-galley-k8s-tests_istio

integ-distroless-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-distroless-k8s-tests_istio

integ-mixer-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-multicluster-k8s-tests_istio

gencheck_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test gencheck_istio

integ-local-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-local-tests_istio

unit-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test unit-tests_istio

release-test_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test release-test_istio

integ-conformance-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-conformance-k8s-tests_istio

integ-security-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-pilot-k8s-tests_istio

integ-galley-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-galley-k8s-tests_istio

integ-distroless-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-distroless-k8s-tests_istio

integ-mixer-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-multicluster-k8s-tests_istio

gencheck_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test gencheck_istio

integ-local-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-local-tests_istio

unit-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test unit-tests_istio

release-test_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test release-test_istio

integ-conformance-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-conformance-k8s-tests_istio

integ-security-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-security-k8s-tests_istio

lint_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-pilot-k8s-tests_istio

integ-galley-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-galley-k8s-tests_istio

integ-mixer-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-multicluster-k8s-tests_istio

gencheck_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test gencheck_istio

integ-local-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-local-tests_istio

unit-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test unit-tests_istio

release-test_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test release-test_istio

integ-conformance-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-conformance-k8s-tests_istio

integ-security-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-security-k8s-tests_istio

lint_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test lint_istio

integ-distroless-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-galley-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-galley-k8s-tests_istio

integ-mixer-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-multicluster-k8s-tests_istio

gencheck_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test gencheck_istio

integ-local-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-local-tests_istio

unit-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test unit-tests_istio

release-test_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test release-test_istio

integ-conformance-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-conformance-k8s-tests_istio

integ-security-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-security-k8s-tests_istio

lint_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test lint_istio

integ-distroless-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-galley-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-multicluster-k8s-tests_istio

gencheck_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test gencheck_istio

integ-local-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-local-tests_istio

unit-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test unit-tests_istio

release-test_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test release-test_istio

integ-conformance-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-conformance-k8s-tests_istio

integ-security-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-security-k8s-tests_istio

lint_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test lint_istio

integ-distroless-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-pilot-k8s-tests_istio

integ-mixer-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-multicluster-k8s-tests_istio

gencheck_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test gencheck_istio

integ-local-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-local-tests_istio

unit-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test unit-tests_istio

release-test_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test release-test_istio

integ-conformance-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-conformance-k8s-tests_istio

integ-security-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-security-k8s-tests_istio

lint_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test lint_istio

integ-distroless-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-pilot-k8s-tests_istio

integ-mixer-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-mixer-k8s-tests_istio

integ-galley-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-multicluster-k8s-tests_istio

integ-local-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-local-tests_istio

unit-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test unit-tests_istio

release-test_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test release-test_istio

integ-conformance-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-conformance-k8s-tests_istio

integ-security-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-security-k8s-tests_istio

lint_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test lint_istio

integ-distroless-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-pilot-k8s-tests_istio

integ-mixer-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-mixer-k8s-tests_istio

integ-galley-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-galley-k8s-tests_istio

gencheck_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
c008a22400db654a05a592b12f71b4360257b3cd
link
/test integ-multicluster-k8s-tests_istio

integ-local-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-local-tests_istio

unit-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test unit-tests_istio

release-test_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test release-test_istio

integ-conformance-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-conformance-k8s-tests_istio

integ-security-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-security-k8s-tests_istio

lint_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test lint_istio

integ-distroless-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-pilot-k8s-tests_istio

integ-mixer-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-mixer-k8s-tests_istio

integ-galley-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-galley-k8s-tests_istio

gencheck_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test gencheck_istio

integ-telemetry-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-local-tests_istio

unit-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test unit-tests_istio

release-test_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test release-test_istio

integ-conformance-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-conformance-k8s-tests_istio

integ-security-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-security-k8s-tests_istio

lint_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test lint_istio

integ-distroless-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-pilot-k8s-tests_istio

integ-mixer-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-mixer-k8s-tests_istio

integ-galley-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-galley-k8s-tests_istio

gencheck_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test gencheck_istio

integ-telemetry-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
5e8b41a4a9b7d5fb200dd9a40a47dec6d4a0b9fb
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Galley is not the same as shipping istio configs over xdsv3 from istiod. We need to do a proper design doc for this - including the motivation and the possible use cases. You are more than welcome to enable the old galley + mcp code in istiod if it is needed for someone else to consume stuff but I would really like to see proper motivations for doing the whole thing over xds, straight from pilot.

Galley is not the same as shipping istio configs over xdsv3 from istiod. We need to do a proper design doc for this - including the motivation and the possible use cases. You are more than welcome to enable the old galley + mcp code in istiod if it is needed for someone else to consume stuff but I would really like to see proper motivations for doing the whole thing over xds, straight from pilot.

Design doc for switching Galley to XDS is in next WG agenda.
Galley is an implementation of the approved 'mesh config protocol' feature. I'm not interested in
proposing any change to the use cases or rationale for it.
This PR provides the same feature - with less code. It was agreed from the start that eventually UDPA will be used, and the old transport was added because XDS at that time was lacking. It appears with XDSv3 and the plans for UDPA it is no longer the case.

@costinm: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

PTAL - document is updated, I think I address all requests.
Additional improvements will follow.

@costinm: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
92bec94d5faf739b973200a80ee06929d4f9cfb6
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
92bec94d5faf739b973200a80ee06929d4f9cfb6
link
/test lint_istio

gencheck_istio
92bec94d5faf739b973200a80ee06929d4f9cfb6
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
92bec94d5faf739b973200a80ee06929d4f9cfb6
link
/test gencheck_istio

lint_istio
eb38eca18f2598f4b7ebf1198ad1850e97529f2b
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
eb38eca18f2598f4b7ebf1198ad1850e97529f2b
link
/test lint_istio

gencheck_istio
eb38eca18f2598f4b7ebf1198ad1850e97529f2b
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


enpass: init at 5.3.0

Motivation for this change
adds the enpass password manager
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] OS X
[x] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

@domenkozar i think i used the wrong branch as base, where should it go

oh, btw - this one competes with #18844

I've changed the target branch to mster. Could you please do a rebase and squash your commits?

@fpletz thanks, i also fixed a typo in the license, please have a look

@fpletz for some reason the enpass icon is not added - any idea what to do about that?

@fpletz i finished updating the metadata refresh and i addressed most comments
an issue where i'd like a suggestion is mapping the current platform to the metadata
and marking the package as not building for anything else

@Mic92 should i squash? or will it be squashed on merge?

@RonnyPfannschmidt you better squash it yourself

@domenkozar any chance of getting this backported to 16.09?

Make a PR against 16.09 and I'll merge it


google doesn't accept nonce

When trying to login via google:
Error: invalid_request
Parameter not allowed for this message type: nonce
Seems like nonce should be removed or at least made optional via config

Hello,
Sorry to bring up an old issue here, but I'm trying to get omniauth-openid-connect to work with Google and am having some issues, bit of an OpenID Connect n00b here, hoping for a little help.
I'm using omniauth-openid-connect at the latest commit (b9246a04bc0b6efbcf0130ef4e12051c860c3e28).
My initializers/omniauth.rb file currently looks like this:
Rails.application.config.middleware.use OmniAuth::Builder do
	provider :openid_connect,
	name: :google,
	scope: [:openid, :email, :profile, :address],
	response_type: :code,
    send_nonce: false,
    issuer: "https://accounts.google.com",
    client_auth_method: :query,
    client_options: {
      port: 443,
      scheme: "https",
      host: "accounts.google.com",
      identifier: "MY_ID",
      secret: "MY_SECRET",
      redirect_uri: "http://localhost:3000/auth/google/callback",
      authorization_endpoint: "/o/oauth2/auth",
      token_endpoint: "/o/oauth2/token",
      userinfo_endpoint: "https://www.googleapis.com/plus/v1/people/me/openIdConnect"
    }
end

When I initiate the auth request, I get to Google's consent screen OK (the screen where it says "My App would like to" etc.), I then click the "Accept" button and I get the error JSON::JWS::VerificationFailed. By the stack trace I can see that I get to the decode_id_token method, and then things start go wrong once omniauth-openid-connect passes off to ::OpenIDConnect::ResponseObject::IdToken.decode:
def decode_id_token(id_token)
    ::OpenIDConnect::ResponseObject::IdToken.decode(id_token, public_key)
end

I seem to be getting an id_token value back from Google OK but I've noticed that the public_key method is returning nil for me and I'm wondering if this has something to do with my problem. Can anyone provide some insight into what I need to do differently here in order to get things working?
I've tried adding discovery: true and/or jwks_uri: "https://www.googleapis.com/oauth2/v2/certs" in my onmiauth.rb, but neither seems to make a difference. Would I be correct in assuming that discovery is not necessary if options are being set manually?

Yeah, discovery shouldn't be necessary. I'm not sure about your issue though. The error is getting raised here. And here's what can make that error come up. Do you options match this?

I don't see that Google openly supports the address scope requested. I'm not sure if that is the cause of the issue, but according to their discoverable configuration, there is no address scope option:
scopes_supported: [
"openid",
"email",
"profile"
]

Also, it looks as though their preferred userinfo endpoint has changed (again, from the discoverable configuration link above):
userinfo_endpoint: "https://www.googleapis.com/oauth2/v3/userinfo",

Thanks for the input guys. Taking into account this further info, I've given it one last good go here, but I can't get past the JSON::JWS::VerificationFailed error. My best guess is still that it has something to do with the public_key method returning nil and I don't know what config to provide in order to get the required value.
In any case, I've gone with the omniauth-google-oauth2 strategy for now (thanks for the suggestion @nbibler). I guess this option is less flexible if one wants to use providers other than Google but that it works with minimal config is enough for me at present, and one can always add other strategies later.

I know it's an old issue and this is not even active anymore but just for googler's sake here goes the resolution.
The omniauth-google-oauth2 decodes the ID Token without checking verifying the signature.
That's why it works and omniauth-openid-connect doesn't. For this to work in omniauth-openid-connect you have to provide the necessary options to get the public key as you correctly assumed.
In the case of google this would be achieved through the following options:
client_signing_alg: :RS256
client_jwk_signing_key: '{ "keys": [ { "e": "AQAB", "use": "sig", "kty": "RSA", "alg": "RS256", ... }, ... ] }'

Where they key is coming from https://www.googleapis.com/oauth2/v3/certs.
With these options set the ID token is decoded and can be verified.
Using discovery with the jwks_uri  endpoint set would also fix this issue presumably.


[WIP]: Add Placeholder for Server Side Auto Feature Blog

Placeholder for blog covering feature added.
PR: https://github.com/kubernetes/kubernetes/pull/115936

Hello, Comms Shadow for the 1.27 release here. This feature blog is tracked for release, the deadline for submitting the draft is 4th of April- the sooner the better since there's still editing to be done afterwards 😃 Any doubt, the Comms team is here to help. CC @harshitasao

Hey @Nancy-Chauhan! This didn't make it into 1.27 - should I close the PR?

Yes you can close the PR.


Gradle spawns external process to locate local maven repository

Gradle needs the location of the local maven repo on a build machine in order to:

Avoid re-downloading artifacts that were previously downloaded by Maven
Construct a mavenLocal() repository

To determine the location of the local maven repo, Gradle parses the value from Maven settings.xml files. However, using Maven's DefaultSettingsBuilder to parse the Settings files involves quite a lot of additional processing including spawning a new process to determine environment variables.

Fixed in https://github.com/gradle/gradle/pull/1564


Evaluate usefulness of zone_field_info_t

simdzone exposes "type" (not RRTYPE) information for each RDATA field. Originally, this was modeled after the implementation in NSD (wire format/zone format tables) and studying draft-levine-dnsextlang-12. There were two reasons for having that information available.

The parser can call the functions when iterating fields.
The application can discover the type of field.

Since the first implementation, the parser simply uses a table of callback functions for each RRTYPE. The RRTYPE function simply invokes the correct data type parse functions in order. While no zone_printer has been implemented yet, it stands to reason it will operate in the same way. Therefore, the information in zone_field_info_t is redundant wrt the implementation itself.
As for exposing the information to the application, the more I think about it, the less sense it makes. The output format is simply the standardized DNS wire format, which the application must be able to interpret if it wants to consume it. I highly doubt any application will iterate RDATA fields based on the table.

Having talked this through with some people, zone_type_info_t and zone_field_info_t will not be exposed in the public API.


MHD Multicomponent

Implementing 1D Euler multicomponent equations as well as 1D/2D Ideal MHD multicomponent equations.

@Cczernik Could you also please show some performance comparisons (e.g., the timer output of the summary callback) for the new systems, at least for the 2D version? For reference, it would be interesting to see how it fares against MHD without multicomponent or against Euler multicomponent.

@Cczernik Could you also please show some performance comparisons (e.g., the timer output of the summary callback) for the new systems, at least for the 2D version? For reference, it would be interesting to see how it fares against MHD without multicomponent or against Euler multicomponent.

Here you can see an mhd multicomponent example with one component in 2D:

and without multicomponent

Here you can see an mhd multicomponent example with one component in 2D:

Why are the time step sizes different (different number of RHS calls)?

Here you can see an mhd multicomponent example with one component in 2D:

Why are the time step sizes different (different number of RHS calls)?

@ranocha I ran the test with different gammas.. my bad. Fixed it:


Completely changed the README all in one commit :)

@Itai-Nelken

Will take a look when I get home

I disagree with some of your changes, I have cancelled a few such as the binaries one, YOU SHOULDN'T DO IT

I have cancelled a few such as the binaries one, YOU SHOULDN'T DO IT

why? I plan to try and get github-actions to build 'daily builds' for every commit/pr. and it will be the secondary method as compiling only takes a few seconds.
but I on second thought I agree with you its a bad idea to add it to the readme for now.

If you must make binaries, please still provide compilation method for others
Also you must make an armhf
Arm64 and x86 binary

If you must make binaries, please still provide compilation method for others

of course! I never meant to remove the compilation instructions or make them the secondary install method. compiling yourself is, and will always be the preferred and suggested method for aptpac.

Also you must make an armhf
Arm64 and x86 binary

I'll try to get it working with github-actions, I know its possible.

I improved the usage section a bit (formatting changes)

I'll merge when I finish doing some clean up to the repo.

Thanks a lot!


IN operator not working with Decimal values.

CREATE DATABASE test;
 CREATE TABLE temp
   (
       name1 Nullable(Decimal(38,12))
   ) ENGINE = Memory;

   INSERT INTO test.temp VALUES (5, 10);

I try to execute such query:
    SELECT * FROM test.temp WHERE name1 IN (toDecimal128(5, 12))
But it throws an exception:
Code: 53, e.displayText() = DB::Exception: Type mismatch in IN or VALUES section. Expected: Decimal(38, 12). Got: Decimal128, e.what() = DB::Exception.

hm, the issue seems in Nullable
workaround:
INSERT INTO temp VALUES (5), (10);
SELECT * FROM temp WHERE name1 IN ( cast(5 as Nullable(Decimal(38,12)))  )
5.000000000000

@chertus can you take a look?
It seems that this function should support conversions from other Decimal types.
E.g. this works (because types are the same, but anyway, the convertDecimalType function should support this case too):
SELECT toDecimal128(1, 12) IN toDecimal128(1, 12)
but the following don't work:
SELECT toDecimal128(1, 12) IN toDecimal128(1, 24)
SELECT toDecimal128(1, 12) IN toDecimal64(1, 12)

#5350


Remove label and allowBackup from library AndroidManifest

This is the contents of the AndroidManifest.xml file in the library folder:
<manifest xmlns:android="http://schemas.android.com/apk/res/android" package="com.firebase.ui">
    <application android:allowBackup="true" android:label="@string/app_name">
    </application>
</manifest>

The allowBackup and label properties should be removed so they do not affect applications that include FirebaseUI.

Thanks Sam,
This was already addressed in #45 so it's coming in 3.1!


Use configured image extensions as fallback to image format #2917

Use configured image extensions as fallback to image format, because correct image format is not populated until image metadata is read.
This is a workaround and should be replaced by moving image copy to transtype specific code.

Couple of cosmetic remarks:
Maybe instead of making the  "org.dita.dost.util.FileUtils.supportedImageExtensions" a public field we could add a getter method for it FileUtils.getSupportedImageExtensions().
Also the "supportedImageExtensions" is right now marked as deprecated. If we want this fix as a long term solution, we should probably remove the deprecated marker from the field.
In JobSourceSet maybe rename the Set format => to "formats" or "filterFormats" to better indicate there are multiple formats which will be used to filter the job file.

The codebase tries to avoid getter methods and favoring public final fields.
Since we still consider the image extension list a deprecated feature, and only use it as a workaround in this case, I think we should keep it deprecated.


Update ActiveRecord 'dirty' logic

Only store original value once
Unset original value on reverted fields
Remove record dirtyness if the only modified field is
reverted back to its original value
When updating relationships, only set record dirty when
modifying one-many & context-children relationships.
Other relationship types will modify the record
and internally call _setFieldValue() which will
determine whether or not the record is actually dirty

On second thought, we could do without setting a record dirty when updating relationships, since a deep call to save will save a records' relationships, even if the record itself isn't dirty.


[CLI] Format the output of the CLI results

Objective
Decide how we should parse and present the output of CLI commands.
Origin Document
We had some TODO items in #177 since it is still too early too decide & scope out this work
				resp, err := postRawTx(cmd.Context(), pk, tx)
				if err != nil {
					return err
				}
				// DISCUSS(team): define UX for return values - should we return the raw response or a parsed/human readable response? For now, I am simply printing to stdout
				fmt.Println(resp)

Goals

Decide & implement how CLI outputs should be presented to the user

Deliverable

[ ] A decision on how CLI command outputs should be parsed & presented
[ ] A PR updating the code under root/app/client updating all places where we have fmt.Println(resp)

Non-goals / Non-deliverables

Adding new CLI functionality
Changing existing CLI functionality

General issue deliverables

[ ] Update the appropriate CHANGELOG
[ ] Update any relevant READMEs (local and/or global)
[ ] Update any relevant global documentation & references

[Optional] Testing Methodology

This will likely require manual testing
All tests: make develop_all
LocalNet: verify a LocalNet is still functioning correctly by following the instructions at docs/development/README.md

Creator: @Olshansk
Co-Owners: @deblasis

@h5law has completed this since the ticket was first opened.


Error for cuda and cpu

/pytorch-seq2seq/seq2seq/models/EncoderRNN.py", line 68, in forward
    embedded = self.embedding(input_var)
  File "/usr/local/lib/python3.6/dist-packages/torch/nn/modules/module.py", line 479, in __call__
    result = self.forward(*input, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/torch/nn/modules/sparse.py", line 113, in forward
    self.norm_type, self.scale_grad_by_freq, self.sparse)
  File "/usr/local/lib/python3.6/dist-packages/torch/nn/functional.py", line 1283, in embedding
    return torch.embedding(weight, input, padding_idx, scale_grad_by_freq, sparse)
RuntimeError: Expected object of backend CUDA but got backend CPU for argument #3 'index'

@jinfagang could you try running your code with develop branch?

bug bug bug  !!!!!!!!!!!!!!!!!!!!!!!!!!!!   waste my time!!!!!!!!!!!

@Hujun-Cui I think this repo is not active maintained now.

The wrong code is at line 75 of supervised_trainer.py and line 38 of evaluator.py.
I change them to  device = torch.device('cuda:0') if torch.cuda.is_available() else -1 and CUDA is available now.

I think this should be merge in master now

The wrong code is at line 75 of supervised_trainer.py and line 38 of evaluator.py.
I change them to device = torch.device('cuda:0') if torch.cuda.is_available() else -1 and CUDA is available now.

Except the two files, is there any other file need to fix? After fix the two files, the code still be incorrect...

The wrong code is at line 75 of supervised_trainer.py and line 38 of evaluator.py.
I change them to device = torch.device('cuda:0') if torch.cuda.is_available() else -1 and CUDA is available now.

Except the two files, is there any other file need to fix? After fix the two files, the code still be incorrect...

No, but you need to re-install the package after you do these corrections. Running python setup.py install again helped in my case.


ElasticSearch Operator

From @TamalSaha on February 27, 2017 4:21
https://github.com/upmc-enterprises/elasticsearch-operator
Copied from original issue: k8sdb/kubedb#2

This issue was moved to kubedb/project#80


Add new MaterialComponents attributes

Ex: colorOnSecondary, colorOnPrimary
Refer to the following link:
https://github.com/material-components/material-components-android/blob/master/docs/getting-started.md
https://material.io/develop/android/theming/color/
The material library version containing the new attributes is 1.1.0-alpha01

Any updates on this?


webpixels css for vue

These commits are not relevant to the latest version.

@alexisenache Please can you check this issue https://github.com/webpixels/css/issues/2

@alexisenache

These commits are not relevant to the latest version.

What the latest version?

Hey @alexisenache,
Thanks for the webpixels project. Looks promising!
Couldn't access the issue mentioned by @Gavrushuk
Perhaps enabling the issues tab on this repo would encourage more community engagement with webpixels project, if that's something you're looking for.

Hi @jfoliveira, thanks for the feedback :)
I was going for the Discussions because I liked the idea of having the issues and the conversations contained in one place.
But I think you are right. We are still used to the issues tab, so I activated it. Now you can see the closed issue you couldn't access.


Explore History

If i view a current elm file in the browser (elm-reactor) in Light Table the "Explore History" doesn't work.
I have a fresh installation with elm 0.18, lighttable 0.8.1, elm-light 0.5, node v6.9.1

You are using the inline browser shipping with Light Table ? I don't think that supports spawning windows (the debugger is a separate window I think) and I have no control over the debug windows spawning stuff from Elm. It would be sweet if it was possible to hook into the debug stuff, but I don't think that is exposed to tools afaik.

Perhaps that could be solved by the light table team, if they build in window spawning. But would be nice, if it works.


Component instance method callback helper constructor method is incorrect.

The  example for the Blazor Server Side component instance Javascript to .NET callback helper class (MessageUpdateInvokeHelper.cs) contains an error:
public class MessageUpdateInvokeHelper
{
    private Action action;

    public MessageUpdateInvokeHelper(Action action)
    {
        action = action;
    }
    ....
}

The constructor does not actually assign the parameter 'action' to the field 'action', but actually assigns the parameter to it self.
It was quite confusing why I was receiving a NullReferenceException ;-)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7bdccf73-41ed-b996-86c1-d8b7838f8773
Version Independent ID: 32d99e69-dc2d-c452-cfdb-2bf1f1956e16
Content: Call .NET methods from JavaScript functions in ASP.NET Core Blazor
Content Source: aspnetcore/blazor/call-dotnet-from-javascript.md
Product: aspnet-core
Technology: aspnetcore-blazor
GitHub Login: @guardrex
Microsoft Alias: riande

Hello @swijnands ... We recently moved away from underscores on field names. It should just be this. action = action;. I'll patch that right now. Thanks for reporting it.


leveldb: resume write operation asap

Currently write operations will be paused if there are too many level0 files. However once enough level0 files be compacted the write operation should be resumed, otherwise the database can be sucked until all compactions be finished.

Merged. Thank You!


Added more links

added links to LPC graphics and generators
added link to Littera - bitmap font generator
added links to Serif Affinity editors (AffinityDesigner and AffinityPhoto)

Hey @Ravetracer can you keep the links on alphabetical order please?

Ah, sure.
Just updated 😀
Regards

Thanks 🍻


⚠ Secret Website 1 has degraded performance

In 2dc794d, Secret Website 1 ($SECRET_WEBSITE_1) experienced degraded performance:

HTTP code: 200
Response time: 6375 ms

Resolved: Secret Website 1 performance has improved in a6d8b8a.


Make animation options consistent for polar area and doughnut charts

To change the animation of rotation and scale, the options for both charts are now in the animation object. This is a change for the polar area chart.
Fixed an issue when animateRotate was false in the polar area chart identified in #2337
config = {
  animation: {
    animateRotate: true,
    animateScale: false
  }
}

Coverage remained the same at 71.972% when pulling 578fa68a5ac82313d7c5613ae0f72858d6d3d8da on fix/polar-area-animation into c1d7725ae09d9dba5c30f579d697af7655ad875a on master.

I can confirm that the fix is working. Both options now stop their respective animations when set to false. However, the documentation of the Polar Area chart still lists animateRotate and animateScale as top level options. That should be updated to avoid confusion.

Updated the doc file for polar area charts.

Coverage remained the same at 71.972% when pulling 357613c6665930c3471e60ce19a4d767bb56fac5 on fix/polar-area-animation into c1d7725ae09d9dba5c30f579d697af7655ad875a on master.

There's a spelling error in the docs commit.

Good catch. I had to stare at it for a few minutes to find it

Coverage remained the same at 71.972% when pulling 9389bcb2375329b18f52c7dfc6e6cd95638e12f0 on fix/polar-area-animation into c1d7725ae09d9dba5c30f579d697af7655ad875a on master.

@etimberg There were some extremely weird conflicts in this fix up, so I wanted to make sure you took a look at the changes to make sure nothing vital got overwritten

@tannerlinsley looks good


Cannot send print command to the device

Hello, I am using Evolute printer (https://www.evolute.in/fintech/impress/) and referring to the code to print receipt, following is my code, i am able to connect to the printer, but when i send printText command, there is no print or action on the printer side.
my app runs on android.
``
BluetoothManager.isBluetoothEnabled().then(enabled => {
console.log('Bluetooth Enabled? ', enabled)
  BluetoothManager.enableBluetooth().then(
    r => {
      var paired = []
      if (r && r.length > 0) {
        for (var i = 0; i < r.length; i++) {
          try {
            const bluetoothDevice = JSON.parse(r[i])
            // console.log(bluetoothDevice.name)
            paired.push(bluetoothDevice) // NEED TO PARSE THE DEVICE INFORMATION
            if (bluetoothDevice.name === 'ESBAI4577') {
              setPrinterAddress(bluetoothDevice.address)
              console.log('Printer Address', bluetoothDevice.address)
            }
          } catch (e) {
            //ignore
          }
        }
      }
      // console.log(JSON.stringify(paired))

      BluetoothManager.connect(printerAddress) // the device address scanned.
        .then(
          async s => {
            console.log('Connection Result: ', s)
            await BluetoothEscposPrinter.printerInit()
            await BluetoothEscposPrinter.setBlob(0)
            await BluetoothEscposPrinter.printerLeftSpace(0)
            await BluetoothEscposPrinter.printerAlign(
              BluetoothEscposPrinter.ALIGN.CENTER,
            )
            await BluetoothEscposPrinter.printText(
              '------------------------------\r\n',
              {
                encoding: 'UTF8',
                widthtimes: 0,
                heigthtimes: 0,
                fonttype: 1,
              },
            )
            await BluetoothEscposPrinter.printText(
              'This is another text',
              {},
            )
            await BluetoothEscposPrinter.printText(
              '------------------------------\r\n',
              {},
            )
            await BluetoothEscposPrinter.printText('\n\r\n\r\n\r', {})
            console.log('Sent command to the printer')
          },
          e => {
            // this.setState({
            //   loading: false,
            // });
            alert(e)
          },
        )
    },
    err => {
      alert(err)
    },
  )

``
Thank you for such a wonderful library, any help appreciated.

Hi @rishihashbinary did you manage to solve this? I'm having the same problem with a brother QL-820NWB printer. The printer is recognized, successfully connected and no error is shown on print command but nothing is printed, no action at all in the printer. Thanks


[Enhancement] add freePBX.

First of all, thanks for this nice project.
It would be great to add an asterisk freePBX, in order to have a UI and write a steps to make a simple call between 2 simple accounts.
PROS: Even novice users could interface with the app and it would become more engaging and interesting!
keep it up!

Hi @miroslavpejic85 ,
nice idea. I'll work on it


module 'creme' has no attribute 'preprocessing'

Hi all,
First of all, thank you for this amazing library.
I'm trying to use the MinMaxScaler preprocessing, but I'm getting the error - module 'creme' has no attribute 'preprocessing'. I'm simply trying to replicate the example in [https://creme-ml.github.io/content/generated/creme.preprocessing.MinMaxScaler.html#creme.preprocessing.MinMaxScaler]
Can anyone help me on this?

Hi @RP-23, to import MinMaxScaler I do:
from creme import preprocessing

scaler = preprocessing.MinMaxScaler()
``

I do not have any issue with the example you quoted, it's weird...

Yes, that worked for me! Thanks @raphaelsty

Nice @RP-23, have a good day.

Actually the issue was valid. You can't import creme and access creme.preprocessing.StandardScaler. We need to fix the example in the docstring of StandardScaler.


Update testing/model-mesh scripts

/test protelion-light

/test model-mesh-protelion-light

@dagrayvid I think only the visualization step failed,
that's a stub that I put in place quite a while ago, that was never used. I guess you can just cut this part from the test execution to avoid failing.

@kpouget ack, though I think more needs to be done here. I should switch 1-install-mm.sh to install downstream RHODS.

@kpouget ack, though I think more needs to be done here. I should switch 1-install-mm.sh to install downstream RHODS.

sure, but making a test turn from 🔴 to 🟢 with one line is always good to take :D
git rm testing/model-mesh/7-analyze.sh

Rational behind it is: its always easier when we jump from 🟢 to 🟢, but clearly here more work will be required.
Maybe a first client for the skeleton template? (The skeleton guide will come [with its own little legs] when we/I will start using it to integrate a new workload)

/test model-mesh-protelion-light

I close this PR as we're deprecating openshift-psap/ci-artifacts in favor of openshift-psap/topsail. Please reopen the PR there if relevant.


Multi-Factor Authentication Using Redis Cache and OTP

Checklist

Please update the following checklist as applicable. Otherwise, the maintainers may close your pull request.

[x] You created a branch from develop branch.
[x] You PR is raised on develop branch and not onmain.
[x} Blog follows Blog Guidelines.
[x] You have read the Contribution Guidelines before creating this PR.
[x] Checked for any duplicate blog entry.
[x] Checked for all grammatical errors in the blog.
[x] You have not published the blog content elsewhere on the internet on platforms like Medium, Dev.to, etc.
[x] The content is not copy-pasted from elsewhere on the internet.

Description of Change

Hi @divofred We did PHASE I review and moving your PR to PHASE II review.
If you want to add the sample code for easier reference, please add sample code in the following repo by creating a separate PR: https://github.com/LoginRadius/engineering-blog-samples/
Thanks :)
@raghunath-r-a

Thanks @raghunath-r-a,
I've created a PR to the GitHub Repository.
Regards,
Fredrick Emmanuel.


StSchema

let's make it possible to validate XML against XSD schema

@rultor release, tag is 0.10.0

@rultor release, tag is 0.10.0

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 0.10.0

@yegor256 Done! FYI, the full log is here (took me 6min)


NSFS | S3 | Versioning: PutBucketLifecycleConfiguration on version-enabled bucket fails with ParamValidationError

Environment info

NooBaa Version: 5.17.0-20240904
Platform: CentOS8, deployed using https://github.com/IBM/StorageScaleVagrant, Scale <IP_ADDRESS><PHONE_NUMBER>13

Actual behavior
The following test code fails at put_bucket_lifecycle_configuration():
    def test_s3cever13():
        client = get_client()
        bucket_name = get_new_bucket(client=client)

        # The following operation uses another client instance -> following operations will fail
    #    check_configure_versioning_retry(bucket_name, "Enabled", "Enabled")
        _ces_safe_check_configure_versioning_retry(client, bucket_name, "Enabled", "Enabled")

        key = "test"
        num_versions = 3
        create_multiple_versions(client, bucket_name, key, num_versions)

        rules= [{'Expiration': {'Days': 1},
              'ID': 'rule1',
              'Filter': { 'Prefix': 'content-0' },
              'Status':'Enabled'}]
        lifecycle = json.dumps({'Rules': rules})
        print(lifecycle)
>       client.put_bucket_lifecycle_configuration(Bucket=bucket_name, LifecycleConfiguration=lifecycle)
...
E               botocore.exceptions.ParamValidationError: Parameter validation failed:
E               Invalid type for parameter LifecycleConfiguration, value: {"Rules": [{"Expiration": {"Days": 1}, "ID": "rule1", "Filter": {"Prefix": "content-0"}, "Status": "Enabled"}]}, type: <class 'str'>, valid types: <class 'dict'>

Expected behavior
The test case should pass, the policy should be accepted and get_bucket_lifecycle_configuration() should return the above policy.
Steps to reproduce
Execute the above listed test code - added to Ceph s3-tests.
More information - Screenshots / Logs / Other output
Policy printed with the print(lifecycle) command above:
{"Rules": [{"Expiration": {"Days": 1}, "ID": "rule1", "Filter": {"Prefix": "content-0"}, "Status": "Enabled"}]}

Nobaa log with debuglevel set to all attached
noobaa_20240917_1.log.gz

Hi @hseipp. I didn't run the test itself, but setting this configuration works for me. Also, I didn't see any reference to s3_put_bucket_lifecycle in the provided logs.
In any case, I made some changes in #8424. can you please check after this fix?

Hi @dannyzaken I double-checked with the 5.17.0 20241005 noobaa-core code and latest gpfs 5.2.2 and found an error in my test code.
The following fix to my test code made the test pass successfully:
--- a/s3tests_boto3/functional/test_s3.py
+++ b/s3tests_boto3/functional/test_s3.py
@@ -1824,7 +1824,7 @@ def test_s3cever13():
           'ID': 'rule1',
           'Filter': { 'Prefix': 'content-0' },
           'Status':'Enabled'}]
-    lifecycle = json.dumps({'Rules': rules})
+    lifecycle = {'Rules': rules}
     print(lifecycle)
     client.put_bucket_lifecycle_configuration(Bucket=bucket_name, LifecycleConfiguration=lifecycle)


Include PolyTracker version string in output JSON

We should include POLYTRACKER_VERSION somewhere in the output polytracker.json file to future-proof against potential changes to the JSON schema.

Whenever this is implemented, we should also make sure to up the version number.

Whenever this is implemented, we should also make sure to up the version number.


parse_final_snp error

Hello,
I am trying to rerun your analysis on one of your prostate samples patient 2 V2_H5
during the phasing step I stumbled in following errror
/dh-projects/ag-ishaque/analysis/malta/PhD/spatial/CalicoST/utils/get_snp_matrix.py:81: DtypeWarning: Columns (0) have mixed types. Specify dtype option on import or set low_memory=False.
  df_snp = pd.read_csv(cellsnp_base, comment="#", sep="\t", names=["tmpCHR", "POS", "ID", "REF", "ALT", "QUAL", "FILTER", "INFO"])
Traceback (most recent call last):
  File "/dh-projects/ag-ishaque/analysis/malta/PhD/spatial/CalicoST/utils/get_snp_matrix.py", line 183, in <module>
    cell_snp_Aallele, cell_snp_Ballele, unique_snp_ids = cell_by_gene_lefthap_counts(args.cellsnplite_result_dir, args.eagle_out_dir, barcode_list)
  File "/dh-projects/ag-ishaque/analysis/malta/PhD/spatial/CalicoST/utils/get_snp_matrix.py", line 97, in cell_by_gene_lefthap_counts
    phased_AD = np.where( (df_snp.GT.values == "0|1").reshape(-1,1), AD.A, (DP-AD).A )
AttributeError: 'csr_matrix' object has no attribute 'A'

my phasing folder looks like this:

where head of one phased example file looks like this:

here a overview of my config file
# path to executables or their parent directories
calicost_dir: /dh-projects/ag-ishaque/analysis/malta/PhD/spatial/CalicoST
eagledir: /dh-projects/ag-ishaque/analysis/malta/PhD/spatial/CalicoST/external/Eagle_v2.4.1

# running parameters
# samtools sort (only used when joingly calling from multiple slices)
samtools_sorting_mem: "4G"
# cellsnp-lite
UMItag: "Auto"
cellTAG: "CB"
nthreads_cellsnplite: 20
region_vcf: /dh-projects/ag-ishaque/analysis/malta/PhD/spatial/CalicoST/SNPPanel/genome1K.phase3.SNP_AF5e4.chr1toX.hg38.vcf.gz
# Eagle phasing
phasing_panel: /dh-projects/ag-ishaque/analysis/malta/PhD/spatial/HTAN_prostate_CalicoST/1000G_hg38
chromosomes: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22]

# input
spaceranger_dir: /dh-projects/ag-ishaque/analysis/malta/PhD/spatial/HTAN_prostate_CalicoST/sampleV2_5/outs/
# output
output_snpinfo: /dh-projects/ag-ishaque/analysis/malta/PhD/spatial/HTAN_prostate_CalicoST

allignment was done by spaceranger-3.1.1
thank you in advance!

changed script:  phased_AD = np.where( (df_snp.GT.values == "0|1").reshape(-1,1), AD.toarray(), (DP-AD).toarray())
now it is working...

Thank you for checking! Yes, this is due to the version incompatibility with scipy, we are working on an updated version of the code and will fix the scipy compatibility in the new version as well.

maybe just include scipy version in the dependency...

related error occurred for numpy.
np.NAN and np.nan is used interchangeable. Within the numpy version included only np.nan is defined

Thank you for the suggestion! We updated the environment.yml and setup.py files to specify the version of numpy and scipy.