internal radius retry

Fixing some of the purposed changes, after input from others.

http://www.html5gamedevs.com/topic/38508-bounding-sphere-radius-and-point-intersection/?do=findComment&comment=219771
based off of.

but then again, I am torn between this and doing a:
max.subtract(min).scale(0.5) and having it be something you can check the radius per axis.
Not sure which one will be of more use, but this seems to be a common request to find a "true" mesh bounding sphere.

Well still this is just for spherical mesh so I don't think it should be in the framework

then what about a vector3 from bb.max.subtract(bb.min).scale(0.5);
Then we could add a method like mesh.isSphere() or something where if all the axes are the same it returns true, and then have another one that is like mesh.getBoundingRadius() that checks the mesh.isSphere and returns a vector3 if its not and if it is returns a float.
I feel like this is a re-occurring request so a solution should be found.

Feel free to close this one then as well, Ill re-think this and come back with a more thought out approach.
Maybe exclude it completely like you are saying and just write up a snippet page explaining how to get internal mesh radii

I'm more on the snippet side:)

Same, now that I kinda thought about it more.


[Bug] Compilation error: get_column_values(): relation fivetran.salesforce.fivetran_formula_model does not exist and no default value was provided

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the issue
We switched to the fivetran_formula_model table in anticipation of the fivetran_formula table being deprecated in the Salesforce connector. This error started intermittently popping up during fivetran scheduled transformations of our dbt project. The error self-resolves every time and has not happened two runs in a row.
Relevant error log or model output
18:20:45  Compilation Error in model salesforce__ticket_timer (models/sources/salesforce/salesforce__ticket_timer.sql)
18:20:45    In get_column_values(): relation fivetran.salesforce.fivetran_formula_model does not exist and no default value was provided.
18:20:45
18:20:45    > in macro statement (macros/etc/statement.sql)
18:20:45    > called by macro default__get_column_values (macros/sql/get_column_values.sql)
18:20:45    > called by macro get_column_values (macros/sql/get_column_values.sql)
18:20:45    > called by macro sfdc_formula_view (macros/sfdc_formula_view.sql)
18:20:45    > called by model salesforce__ticket_timer (models/sources/salesforce/salesforce__ticket_timer.sql)

Expected behavior
No error
dbt Project configurations
N/a
Package versions
# Packages can be found on https://hub.getdbt.com/.
packages:
  - package: dbt-labs/dbt_utils
    version: [">=1.0.0", "<2.0.0"]
  - package: dbt-labs/codegen
    version: [">=0.10.0", "<0.11.0"]
  - package: fivetran/salesforce_formula_utils
    version: [">=0.9.0", "<0.10.0"]

What database are you using dbt with?
snowflake
dbt Version
1.5.1
deployment.yml
dbtVersion: 1.5.1

jobs:
# Note that the timezone that these jobs will run on will be the timezone of the Fivetran destination,
# in this case Eastern Standard Time. Note that Daylight Savings Time is not observed with this time setting.
# For help with cron formatting, visit https://crontab.guru/.
  - name: recurring_production_run
    # At 7am, 10am, 1pm, 4pm, and 7pm from Monday through Friday
    schedule: 0 7,10,13,16,19 * * 1-5
    steps:
      - name: run dbt seed
        command: dbt seed --full-refresh
      - name: run models
        # This will run all models
        command: dbt run

Additional Context
I am able to run the compiled code from the ticket_timer model in snowflake with no issues. I saw similar stale issue, but it refers to the fivetran_formula table.
Are you willing to open a PR to help address this issue?

[X] Yes.
[ ] Yes, but I will need assistance and will schedule time during our office hours for guidance
[ ] No.

Hi there @avaashwill! We've seen this error pop up in the past, and in particular this customer saw a similar 50% fail rate once they upgraded to dbt v1.5. We've suspected an issue in the dbt-snowfake v1.5 adapter specifically
Did you happen to recently upgrade your dbt version? Would it be possible to upgrade to v1.6?

Hello @fivetran-jamie thanks for the response! I looked over that thread and it does seem like the same issue. We upgraded to 1.5 in late June 2023, so it was recent... ish. When we were using the fivetran_formula table before this and the code looked like this:
        {{ salesforce_formula_utils.sfdc_formula_view(
            source_table='lwccase_timer_session_time_c'
            , source_name='salesforce'
            , full_statement_version=false)
        }}

we got the error one time on 8/21/2023 and then merged a PR on 8/22/2023 that changed the source from fivetran_formula to fivetran_formula_table. Now the code looks like this:
{{ salesforce_formula_utils.sfdc_formula_view(
            source_table='lwccase_timer_session_time_c',
            full_statement_version=true)
        }}

We get the error daily now. Again, the first time we saw it was right before we switched over to the other formula table.
I'm willing to upgrade to dbt 1.6 and see if that helps, but let me know if there are any smaller changes we could try first, I didn't see anything in the thread that pointed to resolution.

Your code looks good to me! Just to confirm, have you included fivetran_formula_model in your defined salesforce source as part of Step 3?
Otherwise, the only solution I can come up with is upgrading dbt 😞  @avaashwill

@fivetran-jamie, yep our salesforce source looks like the one you linked.
Okay, no problem at all. I'll talk with the team about upgrading. Thank you so much for your help!

no problem! please let us know if this doesn't do the trick. for now i'll mark this as won't fix but will keep it open as i'm sure someone else will have this issue

@fivetran-jamie Good morning! We upgraded to the latest version of dbt core (1.6.1) and that did not solve the issue.


UnhandledPromiseRejectionWarning: Error [ERR_PACKAGE_PATH_NOT_EXPORTED]

Upgrading to Shopify CLI v3.20.1 running on MacOS Ventura 13.0 sees this error when trying to run any of the Shopify CLI commands:
(node:25832) UnhandledPromiseRejectionWarning: Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './node/cli' is not defined by "exports" in /usr/local/Cellar/shopify-cli/3.20.1/libexec/lib/node_modules/<EMAIL_ADDRESS>imported from<EMAIL_ADDRESS>   at throwExportsNotFound (internal/modules/esm/resolve.js:280:9)     at packageExportsResolve (internal/modules/esm/resolve.js:508:3)     at packageResolve (internal/modules/esm/resolve.js:607:14)     at moduleResolve (internal/modules/esm/resolve.js:649:14)     at Loader.defaultResolve [as _resolve] (internal/modules/esm/resolve.js:695:13)     at Loader.resolve (internal/modules/esm/loader.js:97:40)     at Loader.getModuleJob (internal/modules/esm/loader.js:243:28)     at ModuleWrap.<anonymous> (internal/modules/esm/module_job.js:42:40)     at link (internal/modules/esm/module_job.js:41:36) (Use node --trace-warnings ...to show where the warning was created) (node:25832) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag--unhandled-rejections=strict(see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2) (node:25832) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Used brew update and brew upgrade on macOS Monterey v12.4 to update the shopify-cli package to 3.22.1.
Any shopify command on the command line now results in the following error message. Please advise or resolve.
(node:1105) ExperimentalWarning: The ESM module loader is experimental.
(node:1105) UnhandledPromiseRejectionWarning: Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './node/cli' is not defined by "exports" in /usr/local/Cellar/shopify-cli/3.22.1/libexec/lib/node_modules/<EMAIL_ADDRESS>imported from<EMAIL_ADDRESS>at throwExportsNotFound (internal/modules/esm/resolve.js:267:9)
at packageExportsResolve (internal/modules/esm/resolve.js:487:3)
at packageResolve (internal/modules/esm/resolve.js:584:14)
at moduleResolve (internal/modules/esm/resolve.js:633:14)
at Loader.defaultResolve [as _resolve] (internal/modules/esm/resolve.js:726:11)
at Loader.resolve (internal/modules/esm/loader.js:97:40)
at Loader.getModuleJob (internal/modules/esm/loader.js:243:28)
at ModuleWrap. (internal/modules/esm/module_job.js:47:40)
at link (internal/modules/esm/module_job.js:46:36)
(node:1105) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
(node:1105) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Used brew update and brew upgrade on macOS Monterey v12.4 to update the shopify-cli package to 3.22.1. Any shopify command on the command line now results in the following error message. Please advise or resolve.
(node:1105) ExperimentalWarning: The ESM module loader is experimental.
(node:1105) UnhandledPromiseRejectionWarning: Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './node/cli' is not defined by "exports" in /usr/local/Cellar/shopify-cli/3.22.1/libexec/lib/node_modules/<EMAIL_ADDRESS>imported from<EMAIL_ADDRESS>    at throwExportsNotFound (internal/modules/esm/resolve.js:267:9)
    at packageExportsResolve (internal/modules/esm/resolve.js:487:3)
    at packageResolve (internal/modules/esm/resolve.js:584:14)
    at moduleResolve (internal/modules/esm/resolve.js:633:14)
    at Loader.defaultResolve [as _resolve] (internal/modules/esm/resolve.js:726:11)
    at Loader.resolve (internal/modules/esm/loader.js:97:40)
    at Loader.getModuleJob (internal/modules/esm/loader.js:243:28)
    at ModuleWrap.<anonymous> (internal/modules/esm/module_job.js:47:40)
    at link (internal/modules/esm/module_job.js:46:36)
(node:1105) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
(node:1105) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

It is related to nodejs. I use NVM and for some recent legacy projects, I switched to an old node.js (v12). As soon as I switched back to v16.13.2, Shopify CLI commands were working again.


Dates detection

Current implementation of language detection works in a way "When we ask for next language, that means that previous language did not work on the given date and should be dropped" We need to change this behavior to only modify working set of languages if at least one language was applicable. If possible, we should also find a way to make language detection more clear for the reader.
This need to be done without significant increase of code complexity.
Current test case is:
In [1]: from dateparser import DateDataParser
In [2]: parser = DateDataParser()
In [3]: parser.get_date_data(u'01-01-15 06:47 AM')
Out[3]: {'date_obj': datetime.datetime(2015, 1, 1, 6, 47), 'period': 'day'}
In [4]: parser.get_date_data(u'foo')
Out[4]: {'date_obj': None, 'period': 'day'}
In [5]: parser.get_date_data(u'01-01-15 06:47 AM')
Out[5]: {'date_obj': None, 'period': 'day'}

Fixed in https://github.com/scrapinghub/dateparser/commit/11e322cf99e0cd38cce1874c564cc59ad04885ad


48 retrieve car from parking

The car now successfully be retrieved form the parking space it previously parked in, by inputting 'r' into the serial. This closes issue #48.
:ballot_box_with_check: Definition of Done checklist

[ ] Meaningful title and valuable description in pull request
[ ] Code change tested manually if not covered by automated tests
[ ] Pull request linked to one or more issues/stories
[ ] Acceptance criteria of the linked stories satisfied
[ ] Code change comprehended by those who approved it
[ ] State of target branch maintained or improved after the code change

@sh4r10 @Druner car crashes into the cars behind when retrieving 😱 - but the automatic parking is amazing!! ⭐ 💯

@sh4r10 @Druner car crashes into the cars behind when retrieving 😱 - but the automatic parking is amazing!! ⭐ 💯

now fixed https://github.com/DIT113-V22/group-02/pull/95/commits/010c63b6275bc1aea28111ddd604cf00d6033559

Amazing work it work properly ,just need to be controlled  through the app


Is it possible to change admin url?

I have changed the working title of user manual to Admin Guide. Wondering if it is possible to change /admin/usermanual/{slug} to admin/admin-guide/{slug}
Thanks!

Hi @laurabennett thanks for the suggestion. I honestly don't know and will need to look into it! I will try to spend some time on this in the next week.
Just curious, was this a request from a client or product owner, or is this just a discrepancy that you found and would like implemented? Interested to hear how it was noticed.

Hi @laurabennett just wanted to let you know this is on my roadmap. Dealing with some logistical maintenance issues but I intend in doing an overhaul within the quarter


Fixing dirty logs

@johnhof

@johnhof The package started failing when the name changed. This is the fix to fix it.

didnt even think about it :(

No probs. Was just Find and Replace 👍


Add more detail to creating database tables loader message

Summary
Consider including a check every minute or so of the "Creating Database Tables" message
Please describe the problem you are trying to solve.
At some point, "Creating Database Tables" next to a spinning wheel looks like it might be a mistake.
Proposed Solution
If the message said Creating Database Tables. Last checked 11/13/21 9:14 PM I'd feel less inclined to check the actual database to see what had been created. At what points do you get information back? I'm not sure how doable this is, and I'd be happy to chat about alternative solutions.

Create tables should provide a count of what's been done and update the interface as it goes.  There are also lots of messages that go to the logs that could be useful to display to the user as it runs.

I was running 0.5.0 and it must have errored out at some point, because it ended up spinning overnight without telling me anything. The log stopped updating longgggg before I posted this (like 1/2 hour of no log update--I went and did something else).
It appears that having all of the lookups on Contact set to varchar(255) even when everything else was autofixed to text was still too big of a row. Happy to do a screenshare.

Related to #96

Looks like the handling of promises generated by Knex is all kinds of misaligned causing the main thread to think all the promises related to the database creation have resolved when they are still pending. It'll take a bit of untangling to get this working right (and that untangling is probably needed).


chore: added more details to readme

Codecov Report

Merging #40 (555b67e) into master (a187ebe) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #40   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            9         9
  Lines          208       208
=========================================
  Hits           208       208

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a187ebe...555b67e. Read the comment docs.


[WIP] Enable comprehensive tests for counter benchmarks

Motivate of the pull request

[x] To address an existing issue. If so, please provide a link to the issue: #428
[ ] Breaking new feature. If so, please describe details in the description part.

Describe the technical details
What is currently done? (Provide issue link if applicable)

Currently, OpenFPGA has the following limitations:

Counter benchmarks are critical to FPGA designers and they are very frequently used. However, current tests only cover the Verilog-to-bitstream flows mainly. No dedicated test case is open to all kinds of counters exclusively.
We see bugs in #428 which should be fixed

What does this pull request change?

This PR improves in the following aspects:

[x] Created a dedicated test case counter8 to validate all kinds of 8-bit counters in microbenchmark suite using Verilog-to-Verification flow
[x] Created a dedicated test case counter128 to validate all kinds of 128-bit counters in microbenchmark suite using Verilog-to-bitstream flow

Which part of the code base require a change

[ ] VPR
[ ] Tileable routing architecture generator
[ ] OpenFPGA libraries
[x] FPGA-Verilog
[ ] FPGA-Bitstream
[ ] FPGA-SDC
[ ] FPGA-SPICE
[ ] Flow scripts
[ ] Architecture library
[ ] Cell library
[ ] Documentation
[x] Regression tests
[ ] Continous Integration (CI) scripts

Impact of the pull request

[ ] Require a change on Quality of Results (QoR)
[ ] Break back-compatibility. If so, please list who may be influenced.

The 8-bit counter with active-low reset is working fine as confirmed in gtkwave

Note: the post-synthesis netlist from Yosys generates 'x' signals due to lack to signalization in RTL.


Add testing prior minor to our cross-version tests

Ensure that we at least test (prior minor, current version) mix (both directions) when running cross-version tests, i.e. ensure that document format (ops, summaries) is compatible across two closest minor releases.
This change by itself does not add that much coverage but creates possible framework for future changes.
Current tests only validate that with a mix of 1.x and latest 2.x. This is good, but we might miss cases that way. Also, tests might be disabling cross-compat tests altogether because they are testing recently added features - we would love to move toward a direction where such tests only disable parts of cross-version tests - the part that has 1.x in it but enable the other part - testing N / N -1. We can even introduce a new mode in addition to "Full Compat" that enables N / N-1 in next release, such that developers can add tests and not need to go back to enable partial compat mode (all TBD, and not prescribed here).
It will increase time to run tests, as it doubles number of cross-version pairs. That said, it adds only 2 configs to already 13 configs we are testing in Full compat mode, and not all tests use Full compat mode.
I've tested it on my box, running only end-to-end tests:

Without this change: 2m 55 seconds
With this change: 3m 18 seconds

So that's 13% increase (based on one sample)
Relative %% will be lower if considering running all the tests (as there are more tests that are not affected by this change).

FYI - Navin suggested that our pipelines are already slow and there is a desire to make them faster. So maybe this change needs to wait until we have a plan here, not sure. So, time till checkin (in any form) might be unknown - will continue to work with Navin to create clarity here.

That said, it's really interesting to see some tests failing. For one, they do not fail on my local machine (at least local tests, did not try t9s) :)
But also, some of them fail with fluid:telemetry:Container:SubmitMessageWithNoConnection, which should not happen:
It was fixed via https://github.com/microsoft/FluidFramework/pull/20111, and https://github.com/microsoft/FluidFramework/pull/20109explicitly would disable compression in RC2 not to hit it.
Others fail with timeouts, which is a bit harder to diagnose.
Worth looking into, there could be more bugs to be found :)


Debug Snakefile to handle directories as an output

When trying to run a parser via the snakefile, the following error was raised:
SyntaxError in line 26 of /Users/irene/Desktop/PRs/evidence_datasource_parsers/Snakefile:
invalid syntax

Lines 25 and 26 invoke the outputs for the Genetics Portal and the EPMC parser in the form of a directory. I presume the use of the directory() function to set output directories is not correct.
We want to be able to integrate the partitioned of the output for those whose size is significant (Genetics Portal, EPMC).

All outputs are now in a JSON format.
The whole pipeline works correctly (including managing directories) thanks to the changes made by @tskir.
Closing ticket.


Angular Challenge 2

Hello, here is my code:
https://github.com/camilo56/challengeAnimation
Very nice challenge.

Hey @camilo56 You rock!! 💯  you made a great work  🎊  .
All animations are perfect!! 😻 . I ❤  the "hinge" effect, you did it so cool!! 😎 .
you may can do the logic of setting the variable in a method in the controller, that way if the name of variable change you have to change the code less times.


Sum estimated demux sample counts

Issue Number
N/A though related to #898
Purpose/Implementation Notes
The goal of this PR was to correctly sum multiplexed libraries sample counts located in the library's metadata json file attribute sample_cell_estimates. This dictionary contains the partial number for each sample and needs to be summed up when assigning demux_cell_count_estimate on a multiplexed sample.
Additionally, I updated the evaluation of sample.multiplexed_with to use a new property sample.multiplexed_with_samples under the hood. This was a change for clarity and ultimately does the same as the original implementation.
Coverage for this change will be available once feature/loader is merged into dev.
Edit see comment below about test coverage.
Types of changes

Bugfix (non-breaking change which fixes an issue)

Functional tests

Loaded SCPCP000009 locally and looked at the local sample table.

Ex. for sample SCPCS000133 the estimated demux sample counts are the sum of two libraries:
# ls SCPCS000133,SCPCS000134,SCPCS000135,SCPCS000136/
.rw-r--r-- 1.2k david 12 Aug 13:54 SCPCL000533_metadata.json
.rw-r--r-- 1.2k david 12 Aug 13:54 SCPCL000535_metadata.json

# cat ./* | grep \"SCPCS000133\":
    "SCPCS000133": 2841,
    "SCPCS000133": 2141,

The sum of 4982 is now on the samples table.

Checklist

[x] Lint and unit tests pass locally with my changes

Screenshots
N/A see above

Note: for exported metadata files, we are still using this value until we meet to discuss naming / clarity synchronously next week.

Update to comment in PR description about testing. That won't be possible with existing test data. I have opened https://github.com/AlexsLemonade/ScPCA-admin/issues/969 to ensure we get coverage there in the future.


Add the multipass plugin to the directives

This adds the multipass plugin to the Caddy's directives.
Relates to: https://github.com/caddyserver/caddyserver.com/pull/67

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


chore: fix typo in run_bufferred

Hey! Thank you for your work on this, I'm another user of this library over at https://github.com/noir-lang/noir
Apologies for nitpicky nature of the PR but typos in function names are a pet peeve of mine.

Oh, that's embarrassing. 🤦
Could you also update the tests?

Could you also update the tests?

:facepalm: Oof, I'd swear I checked for other references but looks like not. Fixed this now.


[capture] Possible failure to capture external memory properly before vkQueueSubmit

Possible capture bug:
During capture, if there is an external memory and external semaphore, there is the possibility that GFXReconstruct could be using out of date memory for input into a vkQueueSubmit.
Take the following scenario:

In this scenario, another application is rendering to an image.  This could easily also happen for the scenario of rendering to vertex buffer or other content as well.  In this scenario, GFXReconstruct captures the perceived memory contents before the vkQueueSubmit, but those contents are not correct and they are actually not correct until the work on the GPU completes and the external semaphore is triggered.
Possible solution:

For every vkQueueSubmit which waits on an external semaphore:
Insert another vkQueueSubmit before that waiting on the external semaphore which will trigger a VkFence that GFXReconstruct capture layer will wait on immediately after using vkWaitForFences.

The command buffer should contain only trivial commands so it doesn't change GPU state more than necessary

After returning from vkWaitForFences, the memory should be properly up to date and can be captured and recorded via the standard logic in the capture layers vkQueueSubmit internal function.
Then we submit the original work defined by the incoming vkQueueSubmit

Possible concerns:

This will change performance and timing for the recording application, but it should improve correctness.

However, this should only be in applications with external semaphores and memory

Can't we wait directly for the semaphore using vkWaitSemaphores?

We also need to block any additional changes to the memory until we've saved it, so we'd probably need to substitute an additional Semaphore we'd signal from the CPU after saving off a copy of the memory and use that Semaphore instead in the QueueSubmit.  We might also have to make a staging copy of the memory if it wasn't CPU-mappable.  I'm fuzzy on the details.


Fix wallet concurrency issue

This patch fixes wallet concurrency issue happening due to the fact that lbryum is not designed  to be thread safe, but lbrynet was making asynchronous threaded calls to lbryum by using threads.deferToThread() .
This patch requires https://github.com/lbryio/lbryum/pull/59 from lbryum.
https://github.com/lbryio/lbry/commit/84daa6b4885a99df5b09aae1e8753b986f98d77d
First we remove unused get_transaction function from both Daemon and Wallet. This function was not being used anywhere (not used in lbry-web-ui either), has concurrency issues, and was not even decoding the transaction in a useful manner so I just decided to remove it instead of  fixing it.
https://github.com/lbryio/lbry/commit/9125adbba9c1160bab6cacbb61beb723ed4467b5
Use defer.succeed( ) instead of threads.deferToThread() when using lbryum. The only exception is when we are using lbryum functions that are just making network calls to lbryum-sever, these can be called in a separate thread asynchronously so we use threads.deferToThread() here.

I installed this, and the lbryum fix on a test reflector instance and was able to connect and request 50 blobs simultaneously.

Had the one question about network.blockchain but if that is a local call and not a network one, this LGTM.

It would also be good to rebase with origin/master just to make sure that the build is working.

rebased to master and fixed the broadcast_transaction bug


use t.Setenv over os.Setenv in tests

In some of our tests we've been using os.Setenv to set env vars. Let's switch them out for t.Setenv.

hey @ggebel, I want to work on this.

Go for it @nitinmewar

Awesome @nitinmewar, thanks for contributing!


Remove duplicated content from CLI ref stub files

Thanks to @FrenchBen we now pull long descriptions and examples for the Engine Reference CLI from the reference files in docker/docker. This PR removes the redundant info that we brute-force added to the stub files for the 1.13.0 release. This also adds a README to explain the process for generating the CLI reference YAML. @FrenchBen PTAL at the readme and make sure I explained the process correctly.

LGTM :) Thanks Misty, I'm sure this was tedious work. Feel free to wait for FrenchBen before merging.

Merging for now, just so we can get rid of the duplicate content.


Add SELECT * EXCLUDE, SELECT * EXCEPT support

Which issue does this PR close?

Closes #6439.
Rationale for this change
With this PR we can run SELECT queries with EXCLUDE where all the columns except EXCLUDE columns are projected, such as below.
SELECT * EXCLUDE(a, b)
  FROM table1

Similar behavior can be obtained using EXCEPT clause also. Query below can also be run with this PR
SELECT * EXCEPT(a, b)
  FROM table1

What changes are included in this PR?

Are these changes tested?
Yes new tests are added select.slt file, to check whether query produces expected columns.

Are there any user-facing changes?

Can we also have test cases for negative scenarios, like exclude non existent columns, or exclude what is included, or exclude duplicated cols

I have extended to cover negative scenarios, thanks for the suggestion @comphead.

Because of the issue in #6495. CI fails, I will fix CI problem, once that issue is resolved.

Here is a proposed addition to the user guide for this feature: https://github.com/apache/arrow-datafusion/pull/6512


Building support for Python 3

Hi all,
I've had some success using PyReshaper outside the NCAR/CESM eco-system (it's been working well so far to handle a large GEOS-Chem archive which had been converted into COARDS-compliant NetCDF, running on our group's cluster), and anticipate continuing to use it in upcoming projects.
However, to use PyReshaper I have to create an auxiliary Python environment just to accommodate its exclusivity on Python <=2.6. As best as I can tell, mpi4py supports Python 3, but neither pynio nor ASAPPyTools do. Are there active efforts to incorporate Python 3 support in either of these projects? @david-ian-brown discussed upcoming Python 3+ support for pynio in a commit about a year ago.
Since I'm going to be actively using PyReshaper over the next month while I implement a new data management plan for this archive, I'd be interested in actively contributing to Python 3 support for the NCAR libraries with anyone else working on them.

I'm pretty sure that the PyReshaper and ASAPPyTools both require Python <3 and >=2.6.
But, regardless, this is a problem.  I've been wanting to update the codebase of all of our software to support both 2.6+ and 3.3+ for quite a while, now, but I just haven't had time.  I know that everyone here at NCAR has had Python 3+ support on our schedule for a while, though.

@darothen Incidentally, I have recently added an "iobackends" feature to the PyReshaper allowing the user to select with backend (netCDF4-python or PyNIO) they want to use for I/O.  So, if PyNIO doesn't have Python3 support, then the PyReshaper should still work once I've updated its code.

@kmpaul that's extremely useful... I can drop that into one of my analysis pipelines once it's uploaded for testing/debugging.

I can add that it will definitely be a priority in the new year to get
PyNIO working with Python 3. Since PyNIO is written using the Python C API,
the changes needed are more extensive than for pure Python code.
On Thu, Dec 29, 2016 at 3:02 PM, Daniel Rothenberg<EMAIL_ADDRESS>
wrote:

@kmpaul https://github.com/kmpaul that's extremely useful... I can drop
that into one of my analysis pipelines once it's uploaded for
testing/debugging.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NCAR/PyReshaper/issues/26#issuecomment-269700456, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AB7VbSN_yf2UvO0JZzcwrQDRmnJ_l6-zks5rNC3igaJpZM4LXoCs
.

Just want everyone to know that I am open to a PR on this.  I don't have time to do this myself.  Not for quite some time, at least.

@kmpaul I haven't really used the package myself, but given I have general experience with both use of netCDF and Py3 porting, there is a test suite and CI support, and it seems this package is still developed with active users, I would be willing to lend a hand and help port it assuming I get some spare time over winter break. Given Python 2 will no longer be officially supported in 2 months and most of the major project have or are in the process of dropping Python 2 support, it would be up to you whether your goal is a to create and maintain a Python 2/3 cross-compatible port, or whether it makes more sense to simply port it directly to modern Python 3 and clean out the old Py2-only cruft at the same time.

However, I just double checked, and unfortunately it seems this project as well as a dependency you maintain (ASAPtools) is released under a restrictive license that is neither standard, free nor open source, unlike most of NCAR's other projects. While that is your and NCAR's choice as the maintainer and owner, I am afraid I cannot in good conscience spend my volunteer time and effort contributing to a project that the wider scientific community is not free to use, share and build upon, cannot be legally used with other freely-licensed software (e.g. anything GPL), and cannot be distributed with most free OSes, including the majority of mainstream Linux distros.

@CAM-Gerlach CRAAAAAAAAAP!   You are completely correct.  Since the first writing of the PyReshaper, though, NCAR has changed our policies on software licensing.  Now, NCAR legal encourages the use of Apache 2.0.  SO, here's what I propose:

[ ]  I will create a new issue related to changing the license to Apache 2.0.
[ ] In that issue, I will ask all of the code contributors if they support changing the license.
[ ] If all code contributors approve the switch to the Apache 2.0 license, then I will change the license in the master branch of the PyReshaper.

And that should do it.  Then you can contribute code...and your contributions will be most welcome!

No worries, that's great news! I was hoping this might be the case since the license hadn't been touched in almost 5 years. Apache 2.0 was what I was going to suggest if I had to pick one since a lot of other NCAR stuff uses it and its a decent balance between permissive but with some additional protections useful for organizationally-sponsored projects like this.
Sounds like you're well aware of how to go about a reliscending. I don't know about the other contributor you mentioned since their code doesn't show up on this Github repo, but In case you happen to never hear back from sherimickelson, it looks like they only contributed 7 lines of code (plus a doc rebuild) which would likely be considered to be too trivial and obvious to be protected by copyright i.e., another dev blackboxing the same thing would write identical lines), with the possible exception of the code comments and docstring lines which could simply be rewritten.
I assume you are going to do something similar for ASAPPPy as well, since its also under the same old license and is a nonfree dependency of PyReshaper? Looks like andersy005 made a smattering of minor changes to the build and CI files, and like this repo  dchandan` has a fork but Github doesn't actually report any of their changes being present in the upstream.

I have just opened an issue to update the license of ASAPPyTools, too.
https://github.com/NCAR/ASAPPyTools/issues/20
And @andersy005 works down the hall from me.  So, I think we can get that updated, too.

I approve changing the license.

Thanks @dchandan , please note that #49 is the issue to comment on to document that. Thanks!

It's fine to place the approval here.  The issues are cross-referenced.

@CAM-Gerlach As of PR #50, PyReshaper should be switched to the Apache 2.0 license.

Great, thanks so much @kmpaul ! Hopefully I'll get some time to work on it over my short winter vacation; in the mean time I've got another side project to run...

@kmpaul Now that I might have a window of time for this (although not as much as I would have liked), is dropping Python 2 support also desired? The latter seems to be what NCAR projects and the Python community in general are moving toward (or already there) but it depends on how much this module is depended on by other libraries; it would seem to a relatively naive observer that is mostly used as a script/application rather than a library that other applications depend on (meaning that a transition period may not be necessary).
Dropping Py2 support makes things simpler since this wouldn't need to add a dep on future as the preferred library for dual support these days and cleans house of Py2 code while allowing use of Py3-only features, but if there are significant usecases where retaining Py2 compatibility temporarily is desired, then I can do either. Up to you.

@CAM-Gerlach Moving entirely to Py3 would please me, personally. However, it sounds like there are some post processing code that uses the PyReshaper and looks like it won’t update to Py3 any time soon. So, I would ideally like to see an update to Py3 support, continuing to support Py2, but making it easy to pull out Py2 at a later date when we know nobody still needs Py2 functionality anymore.

Okay; if we implement the Py2 compat layer with future, which is the recommended modern standard for such (as well as doing the conversion itself), it should be relatively straightforward to remove, and there may or may not actually be that much compatibility code present. Right now pyupgrade only supports automatic removal for the legacy six, but hopefully by then it will add future support (or maybe I will).

I believe that #54 resolves this issue.  Sorry it's been a LONG wait for Python3 support, but I think it is working, now.

I was bit pre-mature closing the issue.  I don't want to tempt fate.  ...waiting for tests to pass.

Ok.  Tests pass and a new release is on PyPI.

Thanks @kmpaul ! Sorry, I got busier than expected with my research, Spyder development, and now Project Mjolnir, a new open-source IoT ecosystem for remote environmental sensor networks. Glad to see this is finally ported!

I was bit pre-mature closing the issue. I don't want to tempt fate. ...waiting for tests to pass.

Just in case you're unaware, you can automatically link an issue to a PR and close it after tests past and its merged by writing Fix #NNNN somewhere of the PR OP. Neat little Github feature.

@CAM-Gerlach.  Yeah.  I am aware of the Fix #NN and Closes #NN feature.  I just forget.  😄

Haha, happens to all of us :smile:


BackTest MT5 strategy tester - full speed

Hi,
When i run strategy tester with faster speed, i got the following error.
An exception of type 'System.ServiceModel.CommunicationException' occurred in MTApiService.dll but was not handled in user code
Service connection failed! The communication object, System.ServiceModel.Channels.ServiceChannel, cannot be used for communication because it is in the Faulted state.
When i run it slow speed in strategy tester or run live data on MT5, it working fine.
Can you suggest me, how should i run strategy tester full speed?
thank you,
Bandu

I have tested MtApi (MT5) with backtesting in the fastest mode and I have not got the error.
What specification has your PC where backtesting is running?
Can you try to test last version of MtApi (1.0.19). I have made some changes of backtesting in this version.


Support wagtail-flags 2.0.0 API changes

I've proposed some changes to Wagtail-Flags based on discussion with @chosak and @sebworks that you can see in wagtail-flags#9. This PR demonstrates what compatibility with those changes would look like for cfgov-refresh.
This can't be merged until cfpb/wagtail-flags#9 is merged and 2.0.0 is released.
Additions

Added our existing feature flags in settings/base.py

Changes

Updated all Wagtail-Flags API calls as appropriate to the changes
Pinned Wagtail-Flags to 2.0.0

Testing

In your cfgov-refresh virtual environment, pip install git+https://github.com/cfpb/wagtail-flags@great-refactor
Run python cfgov/manage.py migrate flags to migrate flag tables
Experiment with turning flags off and on using the new conditions described in cfpb/wagtail-flags#9!

Checklist

[ ] PR has an informative and human-readable title
[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the front end playbook
[ ] Passes all existing automated tests
[ ] New functions include new tests
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged
[ ] Visually tested in supported browsers and devices
[ ] Project documentation has been updated
[ ] Reviewers requested with the Assignee tool :arrow_right:

Note: Travis won't pass until wagtail-flags 2.0.0 is released. I did that on purpose.

@higs4281 I have thoughts on Travis and testing: I think we should @override_settings(FLAGS={...}) in our tests to enable/disable a flag where appropriate.
With respect to app code deploying, yup. All the migrations will go to all the places. I had some thoughts about a mechanism for flagging migrations, but that could get really, really ugly. So I think my preference is just to presume all migrations go everywhere.
I think we might want to do something different for the definition of the WAGTAIL_ASK_CFPB flag — my thought was to be less disruptive with env setups and make it depend on DEPLOY_ENVIRONMENT for now, but perhaps there are better conditions we can use for it.

@higs4281 since there's still traffic in your PR, and CCDB5 is waiting to use these changes I'm inclined to merge this.
Note: I backed out the change to INSTALLED_APPS, so ask_cfpb being installed still depends on the DEPLOY_ENVIRONMENT variable. Migrations will not apply to beta or prod. So we don't have to worry about your squashing in #2913.

@higs4281 so as not to disrupt Ask CFPB work, I've backed out all my URL changes. Let's pair on flagging that when you get back from PyCon!


Fix issue #757

allows console (and gui) scripts to receive command line parameters as an argument to the entry_point main function.
#757

Thanks for the contrib. Unfortunately, this commit would break every console script out there. Plus, it's better to have a simple interface which expects a simple callable. See the recommendations in the ticket for the recommended approach.


Failing community test: CometML

Hey @eugen-ajechiloae-clearml, we're noticing some failing tests with the latest cometML, we can pin this for now but it'd be great if they could be fixed!
Relevant err:
FAILED tests/test_tracking.py::CometMLTest::test_log - assert None == 'some_value'
 +  where None = <function CometMLTest.get_value_from_key at 0x7f441f67fc10>(['{"payload":{"file_name":"/opt/conda/envs/accelerate/lib/python3.9/site-packages/pytest/__main__.py","message_id":1},"type":"file_name"}', '{"payload":{"local_timestamp":1716466411661,"message_id":2,"output":"huggingface/tokenizers: The current process just got forked, after parallelism has already been used. Disabling parallelism to avoid deadlocks...\\nTo disable this warning, you can either:\\n\\t- Avoid using `tokenizers` before the fork if possible\\n\\t- Explicitly set the environment variable TOKENIZERS_PARALLELISM=(true | false)\\n","stderr":true},"type":"standard_output"}', '{"payload":{"additional_params":{"assetId":"2fe5fab45136421599c6ab0d8c28cd1c","context":null,"extension":"py","fileName":"/__w/accelerate/accelerate/accelerate/tests/test_tracking.py","overwrite":false,"runId":null,"step":null,"type":"source_code"},"clean":true,"file_path":"tmp6dqpiegv","local_timestamp":1716466411663,"message_id":3,"metadata":{"source_code_type":"experiment_creation"},"upload_type":"source_code"},"type":"file_upload"}', '{"payload":{"additional_params":{"assetId":"5a05fd9198494186a123ec5a7a842473","context":null,"extension":"py","fileName":"/opt/conda/envs/accelerate/lib/python3.9/...2.34-0.1ubuntu9.4","libwind0-heimdal=7.7.0+dfsg-1ubuntu1.4","libx11-6=2:1.6.9-2ubuntu1.6","libx11-data=2:1.6.9-2ubuntu1.6","libxau6=1:1.0.9-0ubuntu1","libxcb1=1.14-2","libxdmcp6=1:1.1.3-0ubuntu1","libxext6=2:1.3.4-0ubuntu1","libxmuu1=2:1.1.3-0ubuntu1","libzstd1=1.4.4+dfsg-3ubuntu0.1","linux-libc-dev=5.4.0-166.183","login=1:4.8.1-1ubuntu<IP_ADDRESS>","logsave=1.45.5-2ubuntu1.1","lsb-base=11.1.0ubuntu2","make=4.2.1-1.2","mawk=<IP_ADDRESS>00120-2","mount=2.34-0.1ubuntu9.4","ncurses-base=6.2-0ubuntu2.1","ncurses-bin=6.2-0ubuntu2.1","nsight-compute-2023.1.0=2<IP_ADDRESS>-1","openssh-client=1:8.2p1-4ubuntu0.11","openssl=1.1.1f-1ubuntu2.20","passwd=1:4.8.1-1ubuntu<IP_ADDRESS>","patch=2.7.6-6","perl-base=5.30.0-9ubuntu0.4","perl-modules-5.30=5.30.0-9ubuntu0.4","perl=5.30.0-9ubuntu0.4","pinentry-curses=1.1.0-3build1","procps=2:3.3.16-1ubuntu2.3","publicsuffix=20200303.0012-1","readline-common=8.0-4","sed=4.7-1","sensible-utils=0.0.12+nmu1","sysvinit-utils=2.96-2.1ubuntu1","tar=1.30+dfsg-7ubuntu<IP_ADDRESS>","ubuntu-keyring=2<IP_ADDRESS>","util-linux=2.34-0.1ubuntu9.4","wget=1.20.3-1ubuntu2","xauth=1:1.1-0ubuntu1","xz-utils=5.2.4-1ubuntu1.1","zlib1g=1:1.2.11.dfsg-2ubuntu1.5"]},"type":"os_packages"}', ...], 'my_text')
 +    where <function CometMLTest.get_value_from_key at 0x7f441f67fc10> = <test_tracking.CometMLTest testMethod=test_log>.get_value_from_key

Hi @muellerzr ! I mainly contributed to the ClearML (not CometML) trackers. I don't think I'm qualified to fix the CometML tests.
But if any ClearML related tests break, please do let me know!

Ack yes my bad! Let me fix that ping 🙏


CB-12498 remove s3:ListBucket for '*' resource

Is it ok to merge it to master? @lnardai

please double check that the public docs only contains the json (I guess we need to modify that one as well) itself or the url for this json


Always resolvable Val alternative with no Auto variant

What problem does this solve or what need does it fill?
Val's Auto variant doesn't make sense for certain Style fields, such as the gap properties. In those cases internally Auto just gets mapped to Taffy's LengthPercentage::Points(0.)
This might not seem that significant but it's been bothering me intensely the last year. It's never ideal to have multiple representations mapping to the same underlying value like this.
What solution would you like?
My proposal is PR #8096 which I submitted a while ago. It needs an update to support the recent changes to Val, and the macro that implements some of the helper functions could be improved maybe. There wouldn't be any major changes though, so reviews won't be wasted.
Making Margin, Padding and Border into separate types might be controversial. I'm not bothered if we have a generic UiRect<T> or UiRect (with Val edge values) and NumRect (with Nums) instead. The only important change is adding the always resolvable type.
What alternative(s) have you considered?
There are some discussions at: https://github.com/bevyengine/bevy/pull/7656, https://github.com/bevyengine/bevy/pull/7969, https://github.com/bevyengine/bevy/pull/7710, https://github.com/bevyengine/bevy/pull/7569.

Hmm... I'm a little concerned about discoverability here. I wonder if we could add the type you suggest, and then type alias Margin, Padding, Border, etc to the appropriate type?
It may also be worth giving some consideration to how we might want to handle this in a future where there are additional variants for some properties such as width/height (e.g. MinContent, MaxContent, FitContentPx, FitContentPercent, and possibly a morphorm-like Stretch or Fr unit).

Yeah I'm rethinking the separate Margin, Padding, Border thing again. The main motivation was that it would allow us to have separate docs for each type. I think probably it's not worth it, and better just to make UiRect generic. It's easy to write these things but maintaining them is another matter. I don't want to repeat the recent Val maintenance I did, spend hours fixing lots of trivial but buggy functions and then realize after they've been fixed that they are completely useless anyway.
My personal preference has always been to flatten everything. margin_left, border_thickness_left, etc fields on Style, with helper functions to set values on multiple edges.

Just as an aside, in the CSS documentation, this type is called a "Length". I prefer that over "Val", as it more clearly narrows the meaning (a "value" can be almost anything).


 \
                          Please use `sample_frequency` instead", DeprecationWarning)
E           DeprecationWarning: `sample_rate` is deprecated and will be removed in a future release.                           Please use `sample_frequency` instead

Currently, users cannot really prevent that warning even if they have already switched to the new sample_frequency.

How to reproduce this warning? I tried with the attached sample_rate.py without success.

I cannot reproduce it either, I just tried on Linux. Let me try if this was specific to macOS later today, otherwise I'll close this issue.

I still get the error by running test_read_shhs(); I forgot that I silenced this DeprecationWarning in pyproject.toml, so that's why I didn't see it yesterday.

So that would be test_read_shhs, which calls read_shhs:
def test_read_shhs(tmp_path):
    """Basic sanity checks for records read via read_shhs."""
    durations = [0.1, 0.2]  # hours
    valid_stages = {int(s) for s in SleepStage}

    _create_dummy_shhs(data_dir=tmp_path, durations=durations)
    records = list(read_shhs(data_dir=tmp_path, heartbeats_source="ecg", offline=True))

    assert len(records) == 4

    for rec in records:
        assert rec.sleep_stage_duration == 30
        assert set(rec.sleep_stages) - valid_stages == set()

Function read_shhs currently calls read_raw_edf:
            rec = read_raw_edf(edf_filepath, verbose=False)

But read_raw_edf is imported from mne.io.
Which version of sleepecg did you use to reproduce the problem?

I'm using the dev version of SleepECG, but that should be pretty much identical to the latest release v0.5.5.
The problem is in the previous line, which calls _dummy_nsrr_edf(), which in turn calls pyedflib.highlevel.write_edf() (see listing in my initial comment).

If you want to reproduce this, don't forget to comment out this line first.

What's weird is that I cannot reproduce this outside of this SleepECG test, for example with this snippet:
from pyedflib.highlevel import make_signal_headers, write_edf
from scipy.datasets import electrocardiogram

ecg = electrocardiogram()
headers = make_signal_headers(["ECG"], sample_frequency=360)
write_edf("test.edf", [ecg], headers)

@hofaflo do you have any ideas? Are you seeing the DeprecationWarning when disabling the warning filter in pyproject.toml?

Could it depend on the version of pyedflib, with a different version used in either cases?

Perhaps the problem is here is in make_signal_header:
    signal_header = {'label': label,
               'dimension': dimension,
               'sample_rate': sample_rate,
               'sample_frequency': sample_frequency,
               'physical_min': physical_min,
               'physical_max': physical_max,
               'digital_min':  digital_min,
               'digital_max':  digital_max,
               'transducer': transducer,
               'prefilter': prefiler}
    return signal_header

I guess sample_rate shouldn't be added to the dictionary. But then I see a default value for sample_rate and not sample_frequency:
def make_signal_header(label, dimension='uV', sample_rate=256, sample_frequency=None,

Could it depend on the version of pyedflib, with a different version used in either cases?

I just checked, I'm using the latest version 0.1.33.

Perhaps the problem is here is in make_signal_header:

I tried popping that dict key before writing the EDF, this didn't have any effect on the warning.

Additionally, I have discovered that the documentation of pyedflib.highlevel.make_signal_header and pyedflib.highlevel.make_signal_headers
claims that "The default is 256" for  sample_rate, instead I feel it should be None, and that the "The default is 256" for sample_frequency, but it is actually None in the code.

Perhaps the problem is here is in make_signal_header:

I tried popping that dict key before writing the EDF, this didn't have any effect on the warning.

That's the first point of failure.

I am a bit concerned that we cannot come up with a minimal reproducible example, and that the warning only occurs in the SleepECG test...

@cbrnr I have installed [sleepecg](https://github.com/cbrnr/sleepecg) in dev mode. Should I see the warning when running pytest?

Yes. But make sure to disable the warning filter in pyproject.toml (comment out that line).

As for why you see the warning with pytest only:

DeprecationWarning is ignored by default:

exception DeprecationWarning
Base class for warnings about deprecated features when those warnings are intended for other Python developers.
Ignored by the default warning filters, except in the __main__ module (PEP 565). Enabling the Python Development Mode shows this warning.

By default pytest will display DeprecationWarning:

By default pytest will display DeprecationWarning and PendingDeprecationWarning warnings from user code and third-party libraries, as recommended by PEP 565. This helps users keep their code modern and avoid breakages when deprecated warnings are effectively removed.
Sometimes it is useful to hide some specific deprecation warnings that happen in code that you have no control over (such as third-party libraries), in which case you might use the warning filters options (ini or marks) to ignore those warnings.

 \
                          Please use `sample_frequency` instead", DeprecationWarning)
E           DeprecationWarning: `sample_rate` is deprecated and will be removed in a future release.                            \
                          Please use `sample_frequency` instead", DeprecationWarning)
E           DeprecationWarning: `sample_rate` is deprecated and will be removed in a future release.                           Please use `sample_frequency` instead

../pyedflib/pyedflib/edfwriter.py:943: DeprecationWarning
===================================================== short test summary info ======================================================
FAILED sleepecg/test/test_sleep_readers.py::test_read_mesa - DeprecationWarning: `sample_rate` is deprecated and will be removed ...
FAILED sleepecg/test/test_sleep_readers.py::test_read_shhs - DeprecationWarning: `sample_rate` is deprecated and will be removed ...
=================================================== 2 failed, 45 passed in 4.96s ===================================================
  $

I don't see the warning when on the make_signal_header branch:

pytest with pyedf make_signal_header branch
$ pytest-3
======================================================= test session starts ========================================================
platform linux -- Python 3.10.6, pytest-6.2.5, py-1.10.0, pluggy-0.13.0
rootdir: /my/path/sleepecg, configfile: pyproject.toml
plugins: dependency-0.5.1, cov-4.0.0
collected 47 items

sleepecg/test/test_classification.py ....                                                                                [  8%]
sleepecg/test/test_config.py .....                                                                                [ 19%]
sleepecg/test/test_examples.py ..                                                                                [ 23%]
sleepecg/test/test_feature_extraction.py ...                                                                                [ 29%]
sleepecg/test/test_heartbeat_detection.py ..........................                                                         [ 85%]
sleepecg/test/test_heartbeats.py ....                                                                                [ 93%]
sleepecg/test/test_sleep_readers.py ...                                                                                [100%]

======================================================== 47 passed in 5.12s ========================================================
$

Yes, I can confirm that your branch fixes the issue!

We will first need to decide how we want to handle sample_rate. In any case, we should probably avoid warnings when reading sample_rate except when the value is inconsistent with sample_frequency. The question is whether we should always write sample_rate for compatibility with older versions of the module, or not.
Any way, in the short term, you should probably ignore that warning in your tests.

IMO the problem is that even if users write an EDF and only pass sample_frequency, they will still get the deprecation warning saying that they should not use sample_rate. That's confusing! I suggest moving that warning up into a public function, and issue it only when users pass a sample_rate.

Indeed, the warning should be emitted when writing and explicitly passing sample_rate as an argument.
It should not be emitted when reading, unless of course sample_rate and sample_frequency are different.
The question remains whether we should write sample_rate in addition to sample_frequency or not.

Agreed! Just to be clear, the warning we're seeing here is emitted when writing. The question of whether or not to write sample_rate in addition to sample_frequency is then already solved, no? I'd write both fields, and only emit the warning if the user passes sample_rate (which is not the case in my test since I'm passing sample_frequency).


Information for how to build the distribution should be added to the CONTRIBUTING file

Hi all!
Currently, it is not clear how to build and test the distribution. "dzil test" does not work and "dzil build" yields a tree without a Makefile.PL or a Build.PL. We've discussed it on Freenode's #perl channel and concluded it was not trivial.
So please add this information to the CONTRIBUTING file.
( I gained interest in this distribution, because I was assigned it as part of the CPAN Pull Request Challenge).
— @shlomif

Hi @shlomif
There are three packages in this repo: the main Search-Elasticsearch, Search-Elasticsearch-Async, and Search-Elasticsearch-Cxn-NetCurl
The dist.ini for each package is located in the dist/, dist-async/ and dist-netcurl/ directories.  All you have to do is cd into the relevant directory and run the dzil commands from there
want to send a PR?

OK, I'm having further problems now trying to build the distribution that is found inside the "./dist/" dir:
shlomif@telaviv1:~/Download/unpack/perl/cpan/TO_DEL/elasticsearch-perl/dist$ git st
On branch master
Your branch is up-to-date with 'origin/master'.
nothing to commit, working directory clean
shlomif@telaviv1:~/Download/unpack/perl/cpan/TO_DEL/elasticsearch-perl/dist$ git remote -v
origin  git@github.com:shlomif/elasticsearch-perl.git (fetch)
origin  git@github.com:shlomif/elasticsearch-perl.git (push)
upstream        git@github.com:elastic/elasticsearch-perl.git (fetch)
upstream        git@github.com:elastic/elasticsearch-perl.git (push)
shlomif@telaviv1:~/Download/unpack/perl/cpan/TO_DEL/elasticsearch-perl/dist$ dzil test --all
[DZ] building distribution under .build/hPNyvfZwI7 for installation
[DZ] beginning to build Search-Elasticsearch
[DZ] guessing dist's main_module is lib/Search/Elasticsearch.pm
[VersionFromModule] dist version 1.20 (from lib/Search/Elasticsearch.pm)
[PkgVersion] skipping lib/Search/Elasticsearch.pm: assigns to $VERSION
[GitHub::Meta] Getting GitHub repository info
[ExtraTests] rewriting release test xt/release/pod-syntax.t
[ExtraTests] rewriting author test xt/author/no-tabs.t
[ExtraTests] rewriting author test xt/author/eol.t
Error open (<) on 'lib/Search/Elasticsearch.pm': No such file or directory at /usr/lib/perl5/vendor_perl/5.22.0/Pod/Readme/Filter.pm line 86.
shlomif@telaviv1:~/Download/unpack/perl/cpan/TO_DEL/elasticsearch-perl/dist$

Can anyone possibly shed any light on what to do?
Regards,
— @shlomif

Hmmm no idea.  I'm upgrading all my local modules to see if it reproduces.

@clintongormley : thanks for your effort!

Hmm, just updated to perl 5.22 and now I'm getting the same exception :(

@clintongormley : I see! Thanks for the update. For the record, I am getting the same exception with a perlbrew-installed perl-5.22.0.

OK - it seems to be caused by this bug in Dist::Zilla::Plugin::ReadmeFromPod: https://rt.cpan.org/Ticket/Display.html?id=100820
you can force downgrade that module with:
cpanm<EMAIL_ADDRESS>Test::Pod

Also, update from master - i've pushed a couple of minor fixes

@clintongormley : sorry for the late response. After thinking about it, I decided that I'll opt to not contribute to Search-Elasticsearch until this problem is fixed. Part of the risk of using Dist-Zilla with many potentially-problematic plugins is that you deter potential contributors. It's really sad.


REQUEST: Select items

UI: How can the user pick some elements, eg. nodes?
in RFEM5 it was possible to use PickObjects to get a small dialog and let the user select e.g. Nodes / Members. the function returns a list of numbers that was selected.

How can this done in RFEM6?

Hi,
This question is relevant to main program features, not with Python library. Please take a look at the online manual.
https://www.dlubal.com/en/downloads-and-information/documents/online-manuals/rfem-6/000936

After reading the online manual I only find ways to select object using rfems native UI. But my question is, how can this done using the soap API?
In RFEM5 it was possible to use the PickObjects method to pause the execution of the code and let the user pick objects using the dialog shown above. After clicking OK the selected numbers were returned to the program. It is like the input() method in python.

i have created a feature request on the dlubal homepage - i think this is missing in the soap api


[Feature] Distinguish different kinds of units

Currently many units' shape are directly derived from Tiny Tank. It may be better to somehow distinguish different kinds of units, I think, especially when the online multi-player mode is implemented.
Maybe it only needs to display the name besides the units (like the life bars).

I'd like to self-assign this.


Adds listeners for onPeekSheet and onExpandSheet

🚢

There is already an OnSheetStateChangeListener interface so we don't need this


Reinstate Serializer Unit Test

The SerializerTest unit tests were commented out in #1045. These need to be reinstated.

https://jsonapi-resources.com/v0.10/guide/serializer.html
The guide is also out of date because of these changes.


REQUEST: class for MIN, MAX dates and the interval between them

It would be awesome to have a class for the DIV of the MIN date of the picker, the MAX date of the picker and the interval between them.
Something like:
klass : {
    ...
    minday : prefix + 'day--min',
    minday : prefix + 'day--max',
    minmaxinterval : prefix + 'day--minmaxinterval',
    ...
}

and then:

1

...

Right now the dates outside the min-max only get the disabled class but this is the same as I disable a day with the disable attribute.

+1


changed react dependency from ">=15.0.0" to "^15.6.2"

Coverage increased (+21.3%) to 59.259% when pulling<PHONE_NUMBER>d6d3365a174957d6972e2a9568011d on task/react-15.6.2 into 54ce99afd42de7d0c6dee2fc4fb5a7178b4f6637 on release/1.0.0.


Unknown environment variable: DD_AGENT_HOST

UTC | CORE | WARN | (pkg/util/log/log.go:682 in func1) | Unknown environment variable: DD_AGENT_HOST

running on platform: ubuntu
dd-agent  | 2024-12-12 01:00:19 UTC | PROCESS | INFO | (pkg/util/log/log.go:642 in func1) | running version: 7.52.1


Docker emits "The image you are pulling has been verified" which is misleading

This issue deserves to be separate from #9719 and should focus on what to do about the messaging to users in the immediate term.
As a user of docker, I'm uncomfortable that docker is telling me that an image is verified when it seems that it is known that this doesn't currently provide strong guarantees. This has potential to damage trust in docker's messaging in general.
@kofalt suggested in #9719 that yanking this message until the problems are rectified is a reasonable course of action. I agree and have spoken to other users who agree. Has this been considered? Apologies if I just missed it.
/cc @titanous  @lmars
Useful reading:
https://titanous.com/posts/docker-insecurity
https://lwn.net/Articles/628343/

@pwaller Will you also create a PR to make this change? Do you a suggestion for an alternative message? ("An attempt has been made..." sounds a bit lame). Perhaps "Pulling image in v2 format" or something.

@thaJeztah done, see #10160.

Thanks @pwaller! I also want to mention that there has been a pending Pull Request for a few weeks now which does make this message meaningful: #9784, specifically this chunk: https://github.com/docker/docker/pull/9784/files#diff-7cbe4277b9a08ded689d34eaae37655eR485
which results in an error if the checksum of the layer does not match what was in the signed image manifest.

@jlhawn looking forward to it :)

@pwaller #9784 was merged this morning and conflicts with your PR :(

Closing now that we have https://github.com/docker/docker/pull/9784/files#diff-7cbe4277b9a08ded689d34eaae37655eR485, @pwaller let me know tho if you think this is insufficient in anyway

The improved message looks fine, so agreed with closing this.
Thanks for taking the time, @pwaller!


feat(radio): add fds-radio component

:tada: This issue has been resolved in version 0.15.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


HIgh IO / disk usage on linux  vs low IO usage on windows

Hi, I have two puppeteer instance run on my windows 7 laptop and same two instance run on my debian server.
Only one difference is that linux one is run with "--no-sandbox" and "--proxy-server='x.x.x.x:yyyy'" args
In windows have a normal CPU usage and a low disk usage (avg 10 KB/s)
In linux have a little high CPU use due a high IO / disk usage (avg 1.5 MB/s)
any advice?

Hi. As you, i'm new here too. However, for first, i'm sugest to you to use the bug template to describe your issue.
Second, i'm having the same problem when i use linux. On windows, opening multiple pages at same time, i have no io problem. But when i use linux, the cpu usages goes up to more than 250%, and for more than one time, my script stopped without error, just stopped.

@r1si @matheuschimelli I'd recommend asking this on chromium-dev google group since this doesn't seem to be related to Puppeteer itself.
When reaching out to the google group, please make sure to provide excessive details to help folks reproduce this behavior.


Doc updates

[ ] Publishing Guidelines

[x] Resolution sample

[x] Update existing pnp docs.ms.com
"As an external or internal customer, I have the documentation I need to use and interact
with the DMR."

Here are the URLs that need updating to reflect the removal of the CLI namespace and changes to model repo:
https://docs.microsoft.com/en-us/cli/azure/ext/azure-iot/iot/pnp/model?view=azure-cli-latest#ext_azure_iot_az_iot_pnp_model_show
https://docs.microsoft.com/en-us/azure/iot-pnp/howto-use-iot-pnp-cli
https://docs.microsoft.com/en-us/azure/iot-pnp/concepts-model-repository
https://docs.microsoft.com/en-us/azure/iot-pnp/overview-iot-plug-and-play

@houmanp are these changes covered on the PR I mentioned above? if not, can you comment on the docs PR?


Mount host files to containers in docker

Right now the runner is not mounting the host file to the docker containers of the deployments. Let's do that.

Done. coming in v0.16.0


[Storage] Add async iterators for listing items across segments

[Non breaking] Track 2
Edited: we decided to remove the resume-ability.
prototype at https://github.com/Azure/azure-sdk-for-js/commit/955bcbf26069e95849d4c98888e029ac2a205d29
Should return AsyncIterableIterator<T> instead.

[ ] Blob
[ ] File
[ ] Queue

#3216 #3523 #3959


support Iceland/Topaz

I have this GPU:
01:00.0 Display controller: Advanced Micro Devices, Inc. [AMD/ATI] Topaz XT [Radeon R7 M260/M265 / M340/M360 / M440/M445 / 530/535 / 620/625 Mobile] (rev c1)
	Subsystem: Dell Topaz XT [Radeon R7 M260/M265 / M340/M360 / M440/M445 / 530/535 / 620/625 Mobile]

           *-display
                description: Display controller
                product: Topaz XT [Radeon R7 M260/M265 / M340/M360 / M440/M445 / 530/535 / 620/625 Mobile]
                vendor: Advanced Micro Devices, Inc. [AMD/ATI]
                physical id: 0
                bus info: pci@0000:01:00.0

clinfo
  Platform Name                                   AMD Accelerated Parallel Processing
Number of devices                                 1
  Device Name                                     Iceland
  Device Vendor                                   Advanced Micro Devices, Inc.
  Device Vendor ID                                0x1002
  Device Version                                  OpenCL 1.2 AMD-APP (3224.4)
  Driver Version                                  3224.4
  Device OpenCL C Version                         OpenCL C 1.2
  Device Type                                     GPU
  Device Board Name (AMD)                         AMD Radeon Graphics
  Device PCI-e ID (AMD)                           0xc749940
  Device Topology (AMD)                           PCI-E, 0000:01:00.0
  Device Profile                                  FULL_PROFILE

Is detected from clinfo, but rocminfo give me only CPU no GPU.
rocminfo
ROCk module is loaded
=====================
HSA System Attributes
=====================
Runtime Version:         1.1
System Timestamp Freq.:  1000.000000MHz
Sig. Max Wait Duration:<PHONE_NUMBER>3709551615 (0xFFFFFFFFFFFFFFFF) (timestamp count)
Machine Model:           LARGE
System Endianness:       LITTLE

==========
HSA Agents
==========
*******
Agent 1
*******
  Name:                    Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz
  Uuid:                    CPU-XX
  Marketing Name:          Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz
  Vendor Name:             CPU
  Feature:                 None specified
  Profile:                 FULL_PROFILE
  Float Round Mode:        NEAR
  Max Queue Number:        0(0x0)
  Queue Min Size:          0(0x0)
  Queue Max Size:          0(0x0)
  Queue Type:              MULTI
  Node:                    0
  Device Type:             CPU
  Cache Info:
    L1:                      32768(0x8000) KB
  Chip ID:                 0(0x0)
  ASIC Revision:           0(0x0)
  Cacheline Size:          64(0x40)
  Max Clock Freq. (MHz):   4000
  BDFID:                   0
  Internal Node ID:        0
  Compute Unit:            8
  SIMDs per CU:            0
  Shader Engines:          0
  Shader Arrs. per Eng.:   0
  WatchPts on Addr. Ranges:1
  Features:                None
  Pool Info:
    Pool 1
      Segment:                 GLOBAL; FLAGS: FINE GRAINED
      Size:                    16270300(0xf843dc) KB
      Allocatable:             TRUE
      Alloc Granule:           4KB
      Alloc Alignment:         4KB
      Accessible by all:       TRUE
    Pool 2
      Segment:                 GLOBAL; FLAGS: KERNARG, FINE GRAINED
      Size:                    16270300(0xf843dc) KB
      Allocatable:             TRUE
      Alloc Granule:           4KB
      Alloc Alignment:         4KB
      Accessible by all:       TRUE
    Pool 3
      Segment:                 GLOBAL; FLAGS: COARSE GRAINED
      Size:                    16270300(0xf843dc) KB
      Allocatable:             TRUE
      Alloc Granule:           4KB
      Alloc Alignment:         4KB
      Accessible by all:       TRUE
  ISA Info:
*** Done ***

rocm-smi report
======================= ROCm System Management Interface =======================
WARNING: No AMD GPUs specified
================================= Concise Info =================================
GPU  Temp  AvgPwr  SCLK  MCLK  Fan  Perf  PwrCap  VRAM%  GPU%
================================================================================
============================= End of ROCm SMI Log ==============================

Kernel module amdgpu report this:
[    6.382498] [drm] amdgpu kernel modesetting enabled.
[    6.382499] [drm] amdgpu version: 6.1.5
[    6.382511] amdgpu: vga_switcheroo: detected switching method \_SB_.PCI0.GFX0.ATPX handle
[    6.382709] amdgpu: CRAT table not found
[    6.382711] amdgpu: Virtual CRAT table created for CPU
[    6.382722] amdgpu: Topology: Add CPU node
[    6.388578] amdgpu 0000:01:00.0: enabling device (0006 -> 0007)
[    6.404381] amdgpu 0000:01:00.0: amdgpu: Fetched VBIOS from ATRM
[    6.404383] amdgpu: ATOM BIOS: BR42924.002
[    6.404399] kfd kfd: amdgpu: TOPAZ  not supported in kfd
[    6.404423] amdgpu 0000:01:00.0: amdgpu: Trusted Memory Zone (TMZ) feature not supported
[    6.404425] amdgpu 0000:01:00.0: amdgpu: PCIE atomic ops is not supported
[    6.414773] amdgpu 0000:01:00.0: firmware: direct-loading firmware amdgpu/topaz_mc.bin
[    6.414792] amdgpu 0000:01:00.0: amdgpu: VRAM: 4096M 0x000000F400000000 - 0x000000F4FFFFFFFF (4096M used)
[    6.414800] amdgpu 0000:01:00.0: amdgpu: GART: 256M 0x000000FF00000000 - 0x000000FF0FFFFFFF
[    6.414903] [drm] amdgpu: 4096M of VRAM memory ready
[    6.414908] [drm] amdgpu: 7944M of GTT memory ready.
[    6.418335] amdgpu 0000:01:00.0: firmware: direct-loading firmware amdgpu/topaz_pfp.bin
[    6.421648] amdgpu 0000:01:00.0: firmware: direct-loading firmware amdgpu/topaz_me.bin
[    6.424627] amdgpu 0000:01:00.0: firmware: direct-loading firmware amdgpu/topaz_ce.bin
[    6.427659] amdgpu 0000:01:00.0: firmware: direct-loading firmware amdgpu/topaz_rlc.bin
[    6.432214] amdgpu 0000:01:00.0: firmware: direct-loading firmware amdgpu/topaz_mec.bin
[    6.435456] amdgpu 0000:01:00.0: firmware: direct-loading firmware amdgpu/topaz_sdma.bin
[    6.437578] amdgpu 0000:01:00.0: firmware: direct-loading firmware amdgpu/topaz_sdma1.bin
[    6.437651] amdgpu: [powerplay] hwmgr_sw_init smu backed is iceland_smu
[    6.440738] amdgpu 0000:01:00.0: firmware: direct-loading firmware amdgpu/topaz_smc.bin
[    6.466194] amdgpu: [powerplay] can't get the mac of 5
[    6.471844] amdgpu 0000:01:00.0: amdgpu: SE 1, SH per SE 1, CU per SH 6, active_cu_number 6
[    6.474800] amdgpu 0000:01:00.0: amdgpu: Using BOCO for runtime pm
[    6.474890] [drm] Initialized amdgpu 3.53.0 20150101 for 0000:01:00.0 on minor 1
[   62.961944] amdgpu: [powerplay] can't get the mac of 5
[  169.131872] amdgpu: [powerplay] can't get the mac of 5
[  430.550984] amdgpu: [powerplay] can't get the mac of 5
[  502.555659] amdgpu: [powerplay] can't get the mac of 5
[  571.047796] amdgpu: [powerplay] can't get the mac of 5
[  596.514162] amdgpu: [powerplay] can't get the mac of 5
[  872.787630] amdgpu: [powerplay] can't get the mac of 5
[  886.711494] amdgpu: [powerplay] can't get the mac of 5
[  900.510384] amdgpu: [powerplay] can't get the mac of 5

kfd is not supported is it an issue?
Is it supported my GPU on rocm, I think no, is it correct?
I tested many versions also the latest 5.6, on ubuntu 22.04 LTS, but none show the GPU.

How rollback TOPAZ from Parrot OS GRUB?

Sorry @yashikada, Iceland/Topaz is no longer supported.  For reference, you can check latest and previous version of ROCm.
Latest ROCm6.0.2
https://rocm.docs.amd.com/projects/install-on-linux/en/latest/reference/system-requirements.html
Links to previous version.
https://rocm.docs.amd.com/en/latest/release/versions.html


AnonymousClass6a85eed1b3aeaa3b7eaea1eb536990ed

for https://github.com/doctrine/dbal/blob/3.5.1/src/Platforms/AbstractPlatform.php#L225 this lib currently emit:
Call to deprecated method getVarcharTypeDeclarationSQL() of class AnonymousClass6a85eed1b3aeaa3b7eaea1eb536990ed:
Use {@link getStringTypeDeclarationSQL()} instead.

from AnonymousClass6a85eed1b3aeaa3b7eaea1eb536990ed it is very hard to tell which class and also I double the name is stable for error ignore.
I would expect anonymous name like from native phpstan https://phpstan.org/r/7f7ac916-f7fe-4c4d-8035-337e837344ae, ie. class@anonymous/tmp.php:7 istead of AnonymousClass6a85eed1b3aeaa3b7eaea1eb536990ed.

It needs to call getDisplayName() instead of getName() on ClassReflection. Feel free to send a PR.

The problem was fixed in the meantime.


[Feature Request] Skip section on portal app

Hi would it be possible to a skip button to the bazzite portal? for runs after the initial os setup for reasons mentioned below. Or possibly have the toggles automatically reflect the current setup just because it is kind of tedious to run it to install something additional and have to go through and make sure the toggles are the same as the current setup.. not sure if it will mess up something if it doesn't match.

Please open this against https://GitHub.com/ublue-os/yafti


docker image for resource

Hello,
It seems like the recommended way to install custom resources for newer concourse releases is to add them to a pipeline in resource_types. That mechanism only supports docker images. The documentation for resource types lives here: https://concourse.ci/configuring-resource-types.html
Would it be possible to have this resource wrapped up as a docker image for consumption using the new syntax?

I've since discovered the image in docker hub. https://hub.docker.com/r/cfcommunity/slack-notification-resource/
At the moment there is no documentation, but I followed the documentation for this image and was able to make it work: https://hub.docker.com/r/nopik/slack-notification-resource/


qwen2-vl-7b llamafactory微调，数据集只支持单张图片吗

单轮多张、多轮多张不支持吗？

https://github.com/hiyouga/LLaMA-Factory/issues/3739

多张图片训练就会报错，完整的报错trace：
with torch.enable_grad(), device_autocast_ctx, torch.cpu.amp.autocast(**ctx.cpu_autocast_kwargs):  # type: ignore[attr-defined]
0%|▏                                                                                | 1/1250 [00:43<15:08:21, 43.64s/it][rank2]: Traceback (most recent call last):
[rank2]:   File "/usr/local/lib/python3.8/dist-packages/llamafactory/launcher.py", line 23, in
[rank2]:     launch()
[rank2]:   File "/usr/local/lib/python3.8/dist-packages/llamafactory/launcher.py", line 19, in launch
[rank2]:     run_exp()
[rank2]:   File "/usr/local/lib/python3.8/dist-packages/llamafactory/train/tuner.py", line 50, in run_exp
[rank2]:     run_sft(model_args, data_args, training_args, finetuning_args, generating_args, callbacks)
[rank2]:   File "/usr/local/lib/python3.8/dist-packages/llamafactory/train/sft/workflow.py", line 95, in run_sft
[rank2]:     train_result = trainer.train(resume_from_checkpoint=training_args.resume_from_checkpoint)
[rank2]:   File "/usr/local/lib/python3.8/dist-packages/transformers/trainer.py", line 1991, in train
[rank2]:     return inner_training_loop(
[rank2]:   File "/usr/local/lib/python3.8/dist-packages/transformers/trainer.py", line 2332, in _inner_training_loop
[rank2]:     tr_loss_step = self.training_step(model, inputs)
[rank2]:   File "/usr/local/lib/python3.8/dist-packages/transformers/trainer.py", line 3416, in training_step
[rank2]:     loss = self.compute_loss(model, inputs)
[rank2]:   File "/usr/local/lib/python3.8/dist-packages/transformers/trainer.py", line 3463, in compute_loss
[rank2]:     outputs = model(**inputs)
[rank2]:   File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 1553, in _wrapped_call_impl
[rank2]:     return self._call_impl(*args, **kwargs)
[rank2]:   File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 1562, in _call_impl
[rank2]:     return forward_call(*args, **kwargs)
[rank2]:   File "/usr/local/lib/python3.8/dist-packages/deepspeed/utils/nvtx.py", line 15, in wrapped_fn
[rank2]:     ret_val = func(*args, **kwargs)
[rank2]:   File "/usr/local/lib/python3.8/dist-packages/deepspeed/runtime/engine.py", line 1846, in forward
[rank2]:     loss = self.module(*inputs, **kwargs)
[rank2]:   File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 1553, in _wrapped_call_impl
[rank2]:     return self._call_impl(*args, **kwargs)
[rank2]:   File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 1562, in _call_impl
[rank2]:     return forward_call(*args, **kwargs)
[rank2]:   File "/usr/local/lib/python3.8/dist-packages/transformers/models/qwen2_vl/modeling_qwen2_vl.py", line 1589, in forward
[rank2]:     inputs_embeds[image_mask] = image_embeds
[rank2]: RuntimeError: shape mismatch: value tensor of shape [2376, 3584] cannot be broadcast to indexing result of shape [809, 3584]

Try increasing cutoff_len parameter


Use nimja without wrapping code in a proc for result variable

One thing I've noticed about Nimja is that it assumes there is a result variable defined that is of a string type. It'd be nice if I could use this in places without needing to define a wrapper proc, eg inline with a Jester route definition. In that case, the variable result is already declared by the framework.
I'd like to be able to do
resp compileTemplateStr("some nimja code {{someParam}}")

or
var a = compileTemplateStr("some nimja code {{someParam}}")

in any arbitrary block of code without it relying on a result variable. I think it is possible to add this without any breaking changes, but if it isn't then I believe you'd need some sort of overload.

Sorry for the late response - this doesn't quite work in Jester due to scoping issues. Eg, if I declare a variable that isn't global the tmpls proc can't see it for interpolation. I have code that looks like this
    var post = postById(@"id")
    resp tmpls """
    <textarea placeholder="Write here" name="text">{{post.text}}</textarea>
    <button hx-get="/posts/{{post.id}}">Cancel</button>
    <button hx-put="/posts/{{post.id}}">Update</button>"""

which doesn't work as it is being ran within a Jester route, and post isn't a global variable.

I'll have a look again, thanks for reporting.

@ajusa please have a look if this works for you know.
in my tests this works now:
import jester
settings:
  port = 8989.Port

routes:
  get "/hello/@name":
    var nimjaTmplsVar = 1.3 # only here to show we do not shadow this
    resp tmpls"""<h1>{{@"name"}}</h1>"""

Yes, thank you so much for fixing it!


IcebergQueryTest implicit dependencies on CsvLoaderTest

EcommerceDataSetSQL1 test under IcebergQueryTest assumes that CsvLoaderTest to have loaded ecommerce data loaded in the cube repo. Yet this dependency unlike CohortSelectionTest/CohortAnalysisTest is not specified.

Maybe its better to reorganize the iceberg/query folder? Other functionality tests on loaded datasets are placed under functionality folder. @NLGithubWP

Need to modify the structure of these unit tests.

Now iceberg tests has been temporarily removed from dev. It will be fixed once porting is complete #138


 The above query failed with the error:

java.lang.RuntimeException: Caught exception while running CombinePlanNode.
...
Caused by: java.lang.NullPointerException: DataSource for null should not be null. Potentially invalid column name specified.

Moving the FILTER_REDUCE_EXPRESSIONS Calcite rule to the end ensures that these literal-only filter expressions will be reduced. The plan for the same query now looks like:

LogicalProject(AirTime=[CASE(>($4, 0), _UTF-8'Positive', _UTF-8'Negative')])
  LogicalTableScan(table=[[default, mytable]])

I just realized that this is the same as https://github.com/apache/pinot/pull/13174.
cc - @gortiz

Yep. It looks very similar to #13174. The reason why we didn't merged that is because it may increase the planning time and at the same time we are not sure we are getting rid of all literal pushdown cases.

Closing this since it's basically a duplicate.


Use pytest instead of unittest2

Feel free to reject this if you prefer unittest2: I was doing some benchmarking using pytest and ended up familiarising myself with pytest's parametrization.
I prefer the syntax, but it's up to you!

In hindsight I should have made this commit independent from pull request #11. I can do that if #11 is rejected.


Get rid of node manual dep

We don't know if it's node, iojs, etc...
NPM can be used as a dep manager for frontend code as well, or anything else.

Node on npm also doesn't install node:
https://www.npmjs.com/package/node

We're restarting development on this, so closing outstanding issues for now since they are likely out of date. Please re-open if still relevant.


csolution requesting a pack I did not indicate ?

I have a "basic trace" pack installed as a local repository:
  <pdsc vendor="STMicroelectronics" url="file://localhost/C:/Cube/basic_trace/\" name="basic_trace" version="0.0.3"></pdsc>

And I have an example using it:
project:
  optimize: size                   # Code optimization: emphasis code size
  debug: on                        # Enable debug symbols

  components:
    ...
    # basic trace
    - component: STMicroelectronics::Utility:Debug:basic trace&Configurable
    - component: Device:STM32 HAL:UART
    - component: Device:STM32 HAL:DMA

But the cprj requires a version I did not specify:
$ cat gpio-toggle.GCC+B-U585I-IOT02A.cprj
<?xml version="1.0" encoding="UTF-8" standalone="no" ?>
<cprj schemaVersion="1.0.1" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="CPRJ.xsd">
  <created timestamp="2022-05-23T14:50:01" tool="csolution 0.9.5"/>

  <info isLayer="false">
    <description>Automatically generated project</description>
  </info>

  <packages>
    <package name="CMSIS" vendor="ARM" version="5.8.0:5.8.0"/>
    <package name="Example_HAL_GPIO_Toggle" vendor="STMicroelectronics" version="0.0.2:0.0.2"/>
    <package name="STM32U5xx_DFP" vendor="STMicroelectronics" version="0.1.1:0.1.1"/>
    <package name="STM32U5xx_Drivers" vendor="STMicroelectronics" version="0.1.3:0.1.3"/>
    <package name="basic_trace" vendor="STMicroelectronics" version="0.1.0:0.1.0"/>
    <package name="board_resources_B-U585I-IOT02A" vendor="STMicroelectronics" version="0.0.3:0.0.3"/>
  </packages>

And the build fails as this version is not found:
> cbuild.exe gpio-toggle.GCC+B-U585I-IOT02A.cprj
info cbuild: cbuild: Build Invocation 0.9.1 (C) 2022 ARM
(cbuildgen): Build Process Manager 0.11.1 (C) 2022 ARM

*** ERROR M601:
  Package 'STMicroelectronics.basic_trace' was not found in package index!

*** ERROR M800:
  RTE Model reports: Error R821: Required pack not installed: STMicroelectronics.basic_trace.0.1.0:0.1.0: C:\Cube\examples\hal\gpio\toggle\targets\B-U585I-IOT02A\STM32Cube\gpio-toggle.GCC+B-U585I-IOT02A.cprj
error cbuild: error executing 'cbuildgen packlist'

Why is version 0.1.0 required ?

Has this problem been analyzed?  Do we have enough information and/or a replicator?

@fred-r This should have been fixed, can you please test it with the latest CMSIS-Toolbox? Thanks!

@fred-r could you please validate the fix?

closing the issue as considered as fixed


How to get current slide index?

As I can see there is method slickCurrentSlide in original slick methods, but it's not ported...

@supermarioim https://github.com/devmark/angular-slick-carousel#faq

Q: After change data, could i keep the current slide index? A: For this directive, this will destroy and init slick when updating data. You could get current index by event. example:

    $scope.currentIndex = 0;
    $scope.slickConfig = {
        event: {
            afterChange: function (event, slick, currentSlide, nextSlide) {
              $scope.currentIndex = currentSlide; // save current index each time
            }
            init: function (event, slick) {
              slick.slickGoTo($scope.currentIndex); // slide to correct index when init
            }
        }
    };

what's your problem with that?


querySessionStatus fails after opening the app in two browser tabs

Hello,
we have a problem when opening the application in two tabs. OIDC-Client tries to query the session status using response_tyke=id_token but the validation of the response fails, which results in a redirect loop on both tabs (redirecting to the OP, who redirects us to the callback page and the cycle goes on).
I found the querySessionStatus function in the UserManager class with line 206:
signinResponse.session_state && signinResponse.profile.sub && signinResponse.profile.sid

What exactly is the signingResponse.profile.sid? I think this may be the point of failure because session_state is present in the Location header URL and sub is inside the id_token .
EDIT: We had another problem while querying the session status saying that at_hash was not present in the id_token. This occured (if I remember correctly) after queried the status using response_type id_token. Is the at_hash even needed when querying the session status? <IP_ADDRESS> of the OIDC core spec does say that it is not needed?
Can somebody help me out here?
Greetings and thanks

I had the same problem with multiple tabs, i guess it is because by default oidc-manager uses the sessionStorage, try to switch to "LoclaStorage" via

let config = {
	....
	userStore: new Oidc.WebStorageStateStore({ store: window.localStorage }),
	....
};

also dont forget to change the callbacks on your html files

<!DOCTYPE html>
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
    <title></title>
</head>
<body>
    <script src="oidc-client.min.js"></script>
    <script>
        new Oidc.UserManager({
            userStore: new Oidc.WebStorageStateStore({ store: window.localStorage }) }).signinSilentCallback();
    </script>
</body>
</html>

Oh wow, thank you! I couldn't find any helpful information on this and was stuck for a long time. Did I overlook something? Maybe it should be documented somewhere?
How comes other people do not have this problem?
However it is working now.

Sure, state management is hard when you have multiple tabs open.

No updates. We have not yet been able to resolve this issue.


fix: handle anonymous callsites. (fixes #5)

Fixes https://github.com/klauscfhq/signale/issues/5 by ensuring we only call path.basename on callsites with a valid file path. The find below should act as a filter of these falsy (usually null from what I've seen) values.
In the unlikely case that there is no suitable file path, set the filename as unknown.

Awesome! : )


GeoDNS Cuisine module

Write a cuisine module to deal with https://github.com/abh/geodns
requirements :

install
start
stop
methods to deal with basic DNS operations (Records A, CNAME, ...)

https://github.com/Jumpscale/jumpscale_core8/pull/89

we should write some tests for it

what kind of tests is required , unit test, or just test that it runs, connects, and resolves the requests

Yes indeed
2nd
Some examples how to use
Put documentation
On Sunday, 13 March 2016, abdulrahmantkhalifa<EMAIL_ADDRESS>wrote:

what kind of tests is required , unit test, or just test that it runs,
connects, and resolves the requests
—
Reply to this email directly or view it on GitHub
https://github.com/Jumpscale/jumpscale_core8/issues/82#issuecomment-195961088
.

--
Kristof De Spiegeleer
+971525609014
+201206927877
+32 475405474
skype: despiegk

https://github.com/Jumpscale/jumpscale_core8/commit/6dae09587e8ba71d884bfc8b2dba54c39ed5ce97

#106 , if need the file to be hooked into jumpscale please inform


Add quality level property to Impact type.

User Story

This PR being quite straightforward and conflicting with #63, I'm landing this.


Test Github Actions - ansible-lint

Test implementation of Github Action for ansible-lint.
https://github.com/ansible-community/ansible-lint-action

I guess it needs some more permission, but you can see results of this workflow on my forked repo: https://github.com/wiktor2200/install_nextcloud/actions

@wiktor2200 I have a complete pipeline for tests using GA that I use for all my roles.. it is an easy copy-paste and has some other advantages since it also run yaml-lint, molecule and have versions updated by dependabot automatically: https://github.com/staticdev/ansible-role-signal/blob/main/.github/workflows/tests.yml

@staticdev Thanks for your insights. :)
I've added two separate community workflows to avoid libraries' dependencies and maintaining Python modules versions.
These community supported workflows has also few possible configurations, which can be helpful in the future.
I've also added badge to README for both as you suggested.

@staticdev I've also started fixing all errors and warnings, you can take a look here:
https://github.com/wiktor2200/install_nextcloud/tree/fix-ansible-lit-errors-and-warnings
I won't create PR until finished, but feel free to give your feedback and comments :)

@wiktor2200 looking great. If you give me permission to our fork, I can fix the rest so you dont have all work.

I just pushed second part, Github Actions shows 5 crital issues to go: https://github.com/wiktor2200/install_nextcloud/actions/runs/2640978341

@wiktor2200 just a hint.. normally I make sure yamllint is green first before fixing ansible-lint. One practical way to do that is adding to the root pre-commit-config.yaml:
---
repos:
  - repo: https://github.com/pre-commit/pre-commit-hooks
    rev: v4.1.0
    hooks:
      - id: check-added-large-files
      - id: check-toml
      - id: check-yaml
      - id: end-of-file-fixer
      - id: trailing-whitespace
      - id: check-added-large-files

Then by running pre-commit install && pre-commit run --all-files. With that, some of the errors are automatically fixed.

I guess some changes in configs would be needed for yamllint, but for ansible-lint all test passed: https://github.com/wiktor2200/install_nextcloud/actions/runs/2641022472

@wiktor2200 last but not least, you can override line-length and some other configurations with .yamllint this is also standard for many projects using yamllint:
https://github.com/staticdev/ansible-role-signal/blob/main/.yamllint

That it what I meant by:

configs would be needed for yamllint
This https://github.com/marketplace/actions/yaml-lint which I used has really simple config add.

Both ansible-lint and yamllint succeeded. I've created another PR, please take a look on this one.
#128

I've updated yamllint configuration. I copied all rules from Ansible Galaxy recommendation and then tweak it a little bit (commented out disabled rules and added them again below with comment and warning severity level).
So all needed checks are done for Galaxy + additional rules will warns about some role's styling issues and has no effect on rating.

And when it comes to CI's use cases, Gituhub Actions supports most of use cases. Ansible Molecule tests, deployment to Galaxy or creating a release can be quite easily added even with out-of-the-box modules.

And when it comes to CI's use cases, Gituhub Actions supports most of use cases. Ansible Molecule tests, deployment to Galaxy or creating a release can be quite easily added even with out-of-the-box modules.

Yes switch test to molecule is probably the good way
LGTM


[Microsoft Graph v1.0]: aad siteclassification set

The aad siteclassification set command currently uses the beta/settings endpoint in its implementation, this should be updated to use the v1.0/groupSettings endpoint.
https://github.com/pnp/cli-microsoft365/blob/1bae1ad9a62301470fee8ae38410df4c289205eb/src/m365/aad/commands/siteclassification/siteclassification-set.ts#L42-L48

Note: The /beta version of this API is only applies to groups. The /v1.0 version of this API has been renamed to Get groupSetting.

beta docs: https://docs.microsoft.com/en-us/graph/api/directorysetting-get?view=graph-rest-beta&tabs=http
v1.0 docs: https://docs.microsoft.com/en-us/graph/api/resources/groupsetting?view=graph-rest-1.0&tabs=http
https://github.com/pnp/cli-microsoft365/blob/1bae1ad9a62301470fee8ae38410df4c289205eb/src/m365/aad/commands/siteclassification/siteclassification-set.ts#L131-L139

Note: The /beta version of this API only applies to groups. The /v1.0 version of this API has been renamed to Update groupSettings.

beta docs: https://docs.microsoft.com/en-us/graph/api/directorysetting-update?view=graph-rest-beta&tabs=http
v1.0 docs: https://docs.microsoft.com/en-us/graph/api/groupsetting-update?view=graph-rest-1.0&tabs=http

Hii, I am interested to work on this issue.

will only changing endpoint  on line no. 43 and 132 fix the issue?

Thank you for your help @Atharva321 👍
We should also remove the attention remark in the corresponding documentation page and update the requests in the corresponding tests to reflect the change from using the beta endpoint to the v1.0 endpoint.

Hii, Done the PR . Plz any other changes need to be done or its fine?

Thank you! We'll review the PR shortly


hold event  inverted

I requested a hold
got a hold request from callkeep +2s {callUUID: "6e8b4d9e-6d6e-4198-91b2-99a5a92d44ff", hold: false}
but i get told hold = false in the event

But only when I've called setOnHold- not when I just get the event due to the native UI

SipSession calling setOnHold to true +691ms
CallManager got a hold request from callkeep +8ms {callUUID: "1d880115-2339-4ad2-aeb3-2cd20506daf4", hold: false}

But if i request hold from the native UI, I'll get hold = true


Adding easy portfolio template to index.html

Hi sir i added the easy on the index.html

Closing this in favor of https://github.com/OSSPhilippines/freefolio/pull/97


Bumping to 2.1.2 and releasing the fix for when the reply is an array

Coverage increased (+0.005%) to 97.665% when pulling 38fbc2d178def0d4161ad5ea5ee3f3769ea9b174 on armonge:task/v2.1.2 into bea4b9111d4cabc17ab439f698bdfc9e4c63151e on mediarain:master.


Bump policy-controller version to v0.5.2

Signed-off-by: Hector Fernandez<EMAIL_ADDRESS>
Description of the change
Bump policy-controller version to v0.5.2

Existing or Associated Issue(s)

Additional Information

Checklist

[x] Chart version bumped in Chart.yaml according to semver. Where applicable, update and bump the versions in any associated umbrella chart
[x] Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
[x] JSON Schema generated.
[x] List tests pass for Chart using the Chart Testing tool and the ct lint command.

@hectorj2f I have one observation. Correct me if I am wrong
I have one last question. Based on the below image the policy will look for the secret named valid in the namespace where the pod is getting deployed right ?

But in the documentation, it says having that secret in the namespace where the policy controller deployed is sufficient. It seems both contradict.

Currently, it's expecting that valid secret to be present in all the namespaces where the image is getting deployed.

@MageshSrinivasulu Correct! The secrets is linked to the namespace where the pod is been deployed. We can update the docs to reflect that 👍🏻.
@MageshSrinivasulu could you create a PR in https://github.com/sigstore/docs/pull/40#pullrequestreview-1217639404 to make this change you suggested ?

@hectorj2f Can you please approve this PR https://github.com/sigstore/docs/pull/44