Sub-directory schema

Storing all data in a single directory might be at least inconvenient for large point clouds.
Having a standardized sub-directory schema could solve this issue.
Standardization may also help to:

Incrementally update/process levels
Append additional data
Have a smaller cloud.js file

For tile map services there exist already directory schema for quad-trees, which prevent to have too many files in a single directory.

TileCache: http://svn.osgeo.org/tilecache/trunk/tilecache/TileCache/Caches/Disk.py
GeoWebCache: https://github.com/GeoWebCache/geowebcache/blob/master/geowebcache/core/src/main/java/org/geowebcache/storage/blobstore/file/FilePathGenerator.java

Hi. A simple patch should be enough to create a subdir schema in which files are grouped by the first and second digit (that would create a first subdirectory level) and by the third and fourth digit (that would create a second subdirectory level). Files from r to r77 would remain in the main directory.
On the client side there is the need to rewrite the search for the parent node name, because it could end with "/".
I can try something.

Hi!
I've dones this very similarely now as part of the cloud.js filesize reduction.
I'm partitioning it in steps of 5 levels, though, the same as the hierarchy is beeing partitioned.


Usage question: can I use docopt to implement this architecture?

I want to implement an app which starts a program and waits for a command, executes it and waits again... until the command is stop

Docopt will not help you with this particular task.
Docopt generates a parser from your usage message. You can then run docopt and it will match the parameters the user inputs against its parser. If it matches, it will give you a dict of the arguments it matched, and if it doesn't, it presents the user with a message.
I think you' need to be more specific with what you'd want, but docopt is no help at the level you've described it as of now :)


aws-c-common: 0.4.64 -> 0.5.2, unmark musl broken, enable tests

Motivation for this change
Reenable AWS support in pkgsMusl.nix
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Looks like this requires an aws-c-io bump as well, I'll just roll that up here if that's all right

Some of these failures look concerning to me. I especially don't want to break cachix, hercules, or cabal2nix. Thought this would be a simple bump! Going to take a closer look at this.
Result of nixpkgs-review pr 115157 run on x86_64-darwin 1

3 packages marked as broken and skipped:

fusionInventory
nix-exec
nixui

16 packages failed to build:

cabal2nix
cachix
crystal2nix
haskellPackages.cachix
haskellPackages.hercules-ci-agent
haskellPackages.nix-paths
haskellPackages.update-nix-fetchgit
hercules-ci-agent
libnixxml
nix-du
nix-serve
python37Packages.nix-kernel
python38Packages.nix-kernel
python39Packages.nix-kernel
update-nix-fetchgit
vulnix

37 packages built:

aws-c-cal
aws-c-common
aws-c-event-stream
aws-c-io
aws-checksums
aws-sdk-cpp
bundix
crate2nix
dep2nix
go2nix
nix (nixStable)
nix-bundle
nix-direnv
nix-doc
nix-index
nix-pin
nix-plugins
nix-prefetch-bzr
nix-prefetch-cvs
nix-prefetch-docker
nix-prefetch-git
nix-prefetch-hg
nix-prefetch-scripts
nix-prefetch-svn
nix-update
nix-update-source
nixFlakes (nixUnstable)
nixos-generators
nixos-shell
nixpkgs-review
python37Packages.nixpkgs
python37Packages.pythonix
python38Packages.nixpkgs
python38Packages.pythonix
python39Packages.nixpkgs
python39Packages.pythonix
vgo2nix

Ah nevermind. Looks like hydra is lagging pretty far behind so the ghc build failed on my local system. This is probably fine, but I'll keep it a draft until I can verify it doesn't break stuff on darwin.

Ok, this is ready. Looks like hercules-ci-agent has been failing on master since Jan 6? (cc @roberth just as a heads up)
Result of nixpkgs-review pr 115157 run on x86_64-darwin 1

3 packages marked as broken and skipped:

fusionInventory
nix-exec
nixui

8 packages failed to build:

crystal2nix
haskellPackages.hercules-ci-agent
haskellPackages.update-nix-fetchgit
hercules-ci-agent
libnixxml
nix-du
python39Packages.nix-kernel
update-nix-fetchgit

45 packages built:

aws-c-cal
aws-c-common
aws-c-event-stream
aws-c-io
aws-checksums
aws-sdk-cpp
bundix
cabal2nix
cachix
crate2nix
dep2nix
go2nix
haskellPackages.cachix
haskellPackages.nix-paths
nix (nixStable)
nix-bundle
nix-direnv
nix-doc
nix-index
nix-pin
nix-plugins
nix-prefetch-bzr
nix-prefetch-cvs
nix-prefetch-docker
nix-prefetch-git
nix-prefetch-hg
nix-prefetch-scripts
nix-prefetch-svn
nix-serve
nix-update
nix-update-source
nixFlakes (nixUnstable)
nixos-generators
nixos-shell
nixpkgs-review
python37Packages.nix-kernel
python37Packages.nixpkgs
python37Packages.pythonix
python38Packages.nix-kernel
python38Packages.nixpkgs
python38Packages.pythonix
python39Packages.nixpkgs
python39Packages.pythonix
vgo2nix
vulnix

Result of nixpkgs-review pr 115157 run on x86_64-linux 1

1 package marked as broken and skipped:

nix-exec

2 packages blacklisted:

tests.nixos-functions.nixos-test
tests.nixos-functions.nixosTest-test

3 packages failed to build:

haskellPackages.hercules-ci-agent
hercules-ci-agent
libnixxml

58 packages built:

aws-c-cal
aws-c-common
aws-c-event-stream
aws-c-io
aws-checksums
aws-sdk-cpp
bundix
cabal2nix
cachix
common-updater-scripts
crate2nix
crystal2nix
dep2nix
fusionInventory
go2nix
haskellPackages.cachix
haskellPackages.nix-paths
haskellPackages.update-nix-fetchgit
hydra-unstable
lispPackages.quicklisp-to-nix
lispPackages.quicklisp-to-nix-system-info
nix (nixStable)
nix-bundle
nix-direnv
nix-doc
nix-du
nix-index
nix-pin
nix-plugins
nix-prefetch
nix-prefetch-bzr
nix-prefetch-cvs
nix-prefetch-docker
nix-prefetch-git
nix-prefetch-hg
nix-prefetch-scripts
nix-prefetch-svn
nix-serve
nix-update
nix-update-source
nixFlakes (nixUnstable)
nixos-generators
nixos-rebuild
nixos-shell
nixpkgs-review
nixui
python37Packages.nix-kernel
python37Packages.nixpkgs
python37Packages.pythonix
python38Packages.nix-kernel
python38Packages.nixpkgs
python38Packages.pythonix
python39Packages.nix-kernel
python39Packages.nixpkgs
python39Packages.pythonix
update-nix-fetchgit
vgo2nix
vulnix

Looks like hercules-ci-agent has been failing on master since Jan 6? (cc @roberth just as a heads up)

Thanks! I'll release 0.8.0 today, which is compatible with the latest cachix library.


Check that zero-variance levels in logical IVs work correctly

While wading through the way the lm chain handles categorical variables, I find myself worrying whether logical IVs where one group has no cases with one of the values will be handled correctly, or whether our tests will catch it.  I think the answer is probably no to both (though FSM knows my worries have proven frivolous before, as in #57).
Anyway I haven't investigated this carefully, but I'm opening this issue here to remind me to get back to it.

Pretty sure this is another false alarm.  This is handled correctly, because

model.matrix gives a "contrasts" attribute to logicals as well as factors, and so the fits and the adjustment treat them as factors, and
there are only two levels, so one is used as the reference category and the other is estimated leaving nothing to drop.

I think the only other case is when one group has all NAs in a logical variable, in which case lm throws an error and refuses to fit it, as it should.
So, closing this.


fix: unable to find ENR for NodeId killing network perf

What was wrong?

How was it fixed?

In short this bug was caused by us only checking for Enr's from our node_addr_cache which only contains new temporary connections. The fix was to also check our kbuckets and pending query caches
Other issue

^ So I did implement a solution for this which checks each active sub-network as a as a fallback method.
GetEnr() json-rpc checks the kbuckets of the sub-network, but it doesn't check

This is only available in the OverlayService, not Overlay, so if in the future we still find a issue we can add it to the json-rpc GetEnr, but for now I think the solution is good enough.
I wish we wouldn't need to query every active sub-network as a backup option, but without a much bigger code change I think this is the best solution.
enr_cache should help reduce any locks on discv5 kbuckets or doing Json-rpc requests, uTP recv_from is called a lot and needing to lock kbucket or do a json-rpc request isn't the viable.

Currently node_addr_cache is fairly high so maybe we could reduce its size. Do this idea and have https://github.com/ethereum/trin/pull/1348#discussion_r1694321077
struct EnrCache {
      node_addr_cache (for temp connections): LRU<100>
      uTP_Enr_cache: max potential uTP connections inbound and outbound>
}

impl EnrCache {
    pub fn getEnr(nodeId) { try to fetch from both caches}
}

Then we could do the solution without relying on JSON-RPC requests or knowing which network it is well, well having a well rounded cache.


Connect-DbaInstance - Catch when Windows creds are attempted on Linux/mac host

Let them know to use kinit instead
Fixes #7602

just a couple changes and we're set for 1.1.0


Mocked API docs building

Describe changes
Added:

The core script is docs.sys_modules_mock - in check mode it tries to import all ZenML code to verify that all mockers are in place in clean env. On import, it substitutes all imports mentioned in mockers with a custom class suitable for mocked docs building. It is imported in mkdocs.yml for docs building.
Step in Fast CI to check if all necessary objects are added to the mocked list. I can also automate this, but for now, I would prefer to see it semi-automated. You will get instructions on what to add to the mockers list to overcome failures.

Changed:

I sorted items on the main page for consistency.
No integrations are needed to build docs as of now - only pip install -e ".[server,dev]" is executed
I updated .github/workflows/publish_api_docs.yml to use Python 3.11 and skip environment provisioning, since generation script is now self-inclusive

Observed deviations in docs vs current version:

Obviously, ordering in index.html and 404.html due to introduced sorting
Some objects got a bit more documentation (like StrEnum has __format__ now documented) - I don't see this to be an issue.
Class names used in typing for mocked imports might vary. I tried to overcome this, but it is impossible, since originally it was using internal information of imported integrations, which is not accessible anymore. Generally, it is more full comparing to previous state, so I don't see this as a showstopper as well. Few examples:

"integration_code_docs/integrations-lightgbm/index.html"
-      Booster
+      lightgbm.Booster
-        Booster
+        lightgbm.Booster
-        Dataset
+        lightgbm.Dataset
-      Dataset
+      lightgbm.Dataset
-        Dataset
+        lightgbm.Dataset

"integration_code_docs/integrations-gcp/index.html"
-      GCSFileSystem
+      gcsfs.GCSFileSystem
-      FunctionServiceClient
+      google.cloud.functions_v2.FunctionServiceClient

P.S. Changes in src/zenml/materializers/base_materializer.py looks weird in GitHub, but it is just top if added.
Pre-requisites
Please ensure you have done the following:

[x] I have read the CONTRIBUTING.md document.
[x] If my change requires a change to docs, I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
[x] If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Other (add details above)

@coderabbitai review


[commandline] 'function signature mismatch' with command 'msdl https://musescore.com/music/birdland'

> msdl https://musescore.com/music/birdland
? Score URL or path to local MSCZ file:
  (starts with "https://musescore.com/" or local filepath ends with ".mscz")
  https://musescore.com/music/birdland
! ID: 604996
  Title: Birdland
  Continue? Yes

i MSCZ file loaded
i File URL: https://ipfs.infura.io/ipfs/QmVtZbK2GqcKrENoDjLhv9nWEyVrMzckRKM53pHMEWUkX3
× function signature mismatch

version info<EMAIL_ADDRESS>

webscore related issue


Added PikaBus to the devtools list for python

Added the PikaBus library (https://github.com/hansehe/PikaBus) to the devtools list for python.

@hansehe Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@hansehe Thank you for signing the Contributor License Agreement!

Thank you. We expect libraries to mature and gain traction before adding them. This project looks nice but very new.
For instance, there is only one QuickStart example and I personally don't recall any questions about this project in any community forums or chats. Could be just me, of course.


Increase elasticsearch start timeout

We're installing a few plugins into Elasticsearch by configuring them in elasticsearch.plugins:
properties:
  elasticsearch:
    plugins:
    - license: license
    - shield: shield
    - cloud-aws: cloud-aws
    - marvel: marvel-agent

At this point Elasticsearch takes well past 30 seconds to create its pidfile and monit gives up on it every time.
I saw in 96002b3 that the plugin installation was deliberately moved to a different pidfile, so I thought I'd address it by increasing the start timeout. I timed it; on an m3.medium this set of plugins delays startup of Elasticsearch by about 45 seconds, so I rounded to 60 and doubled it out of caution.

@adamstegman - Thanks for this patch - looks most useful!
I can't seem to find a signed CLA for you; which we'll need before merging.
Please could you print & sign the relevant CLA from https://github.com/logsearch/licensing#signing-the-contributors-license-agreement and forward a scanned copy to<EMAIL_ADDRESS>Thanks!

@mrdavidlaing I just sent it. Thanks for your patience!

CLA received.  Safe to merge


 and  should not clickable in hpcviewer

In hpcviewer, we need to avoid users to click  and  nodes and showing the source code of libmonitor. These special nodes should be unclickable. Either hpcviewer needs to "filter" the nodes or hpcrun or hpcprof has to be smart  enough to avoid linking the special nodes to the source files:
<File i="35086" n="./src/home/la5/git/hpctoolkit-externals/libmonitor/libmonitor/src/pthread.c"/>
<File i="35089" n="./src/home/la5/git/hpctoolkit-externals/libmonitor/libmonitor/src/main.c"/>
<File i="35092" n="./src/home/la5/git/hpctoolkit-externals/libmonitor/libmonitor/src/mpi_init_c.c"/>

I believe that these nodes only have hyperlinks when libmonitor.so is not stripped. It is normally stripped (for this exact reason) unless you compile with --enable-develop.


Mythic Paths Spell can't be removed as an at-will ability

Describe the bug
In Search'n Pick Function, you can see both "add" and "at-will" buttons after searching for any spells from Mythic Path if you have any spell books.
The Mythic Path Spell can't be add to any regular spell books, clicking "add" nothing happens.
Another problem is: If you add Mythic Path Spell as an at-will ability, you can't remove it. Before 1.3.8 there was an "remove" button after adding any spell as ability. Now it's empty as screenshot shows. In Party-Character-Ability section there is also no "remove" button.
Expected behavior
The Mythic Path Spell should be able to be removed from abilities.
Screenshots

Version Info:

ToyBox Version: 1.3.8

Yeah, the add button shouldn't be showing up at all on the Search n' Pick screen. I'll look.


Add support for mailgun variables

Fixes #201

Hi @belidzs and @klevisndoka I am going to find time in the next week to review all these PRs and get a new release going. Thanks heaps for your work (and sorry for the delay on my end)

This is very similar to #204 . I suggested maybe a renderer is the best option (though we might have to change some core core)

@lukencode not really, these variables primarily serve as metadata, so using them in rendering is only a secondary thing.
For instance if a developer sends a notification about a new invoice generated in their application they can pass the invoice ID so when the message is delivered (and mailgun calls your configured web service as a result) it also includes these variables as easily processable variables.

Too bad this has bled to death


Portuguese (Brazil) Translation Progress

Maintainer List

@cezaraugusto
@eduardomoroni
@fjoshuajr
@glaucia86
@gmsecrieru
@halian-vilela
@jcserracampos
@tibuurcio
@WendellAdriel
@jhonmike

For New Translators
To translate a page:

Check that no one else has claimed your page in the checklist and comments below.
Comment below with the name of the page you would like to translate. Take only one page at a time.
Clone this repo, translate your page, and submit a pull request!

Before contributing, read the glossary to understand how to translate various technical and React-specific terms.
Please be prompt with your translations! If you find find that you can't commit any more, let the maintainers know so they can assign the page to someone else.
Discord room
https://discord.gg/Zn4bXAz
For maintainers
When someone volunteers, edit this issue with the username of the volunteer, and with the PR. Ex:

[x] Home Page (@tesseralis) #1

When PRs are merged, make sure to mark that page as completed!
Core Pages
To do before releasing as an "official" translation. Please translate these pages first.

[x] Home Page (@gnuns) (#113)
[x] Tutorial (@eduardomoroni & @halian-vilela) (#33 and #68)

Basics ✅ Completed

[x] Hello World (@rafael-vitor) (#57)
[x] Introducing JSX (@ericp3reira) (#47)
[x] Rendering Elements (@mathsalmi) (#49)
[x] Components and Props (@ifdiego) (#23)
[x] State and Lifecycle (@jhonmike) (#39)
[x] Handling Events (@httpiago) (#3)
[x] Conditional Rendering (@cstpk) (#51)
[x] Lists and Keys (@WendellAdriel) (#7)
[x] Forms (@httpiago) (#100)
[x] Lifting State Up (@gustavobini) (#96)
[x] Composition vs Inheritance (@welll) (#136)
[x] Thinking in React (@rafaelquintanilha) (#83)

API Reference ✅ Completed

[x] React (@renato-bohler)(#31)
[x] React.Component (@rcantuario) (#130)
[x] ReactDOM (@michellocana) (#48)
[x] ReactDOMServer (@fjoshuajr) (#10)
[x] DOM Elements (@tiagohermano) (#45)
[x] SyntheticEvent (@cezaraugusto) (#22)
[X] Test Utilities (@luizbraga) (#81)
[x] Shallow Renderer (@henriquejensen) (#32)
[x] Test Renderer (@fjoshuajr) (#116)
[x] JS Environment Requirements (@koka0012) (#8)
[x] Glossary (@evaldosantos) (#63)

Navigation ✅ Completed
These are the navigation links that appears in the sidebar. Possibly wait until
the corresponding sections are translated to do these.

[x] tutorial/nav.yml (@jhonmike) (#135)
[x] docs/nav.yml (@jhonmike) (#135)

Next Steps
These are the next most important translations, ordered by importance:
Installation ✅ Completed

[x] Getting Started (@lucianomlima) #126
[x] Add React to a Website (@ukita) (#54)
[x] Create a New React App (@mrcelo) (#18)
[x] CDN Links (@leandrocustodio) (#21)

Hooks ✅ Completed
Everyone is hooked on hooks! People are really excited for these and it would be great for them to be translated.

[x] Introducing Hooks (@klzns) (#72)
[x] Hooks at a Glance (@gabrielbs) (#80)
[x] Using the State Hook (@vinicius98s) (#108)
[x] Using the Effect Hook (@WeslleyNasRocha) (#117)
[x] Rules of Hooks (@thadeu) (#11)
[x] Building Your Own Hooks (@WendellAdriel) (#78)
[x] Hooks API Reference (@thadeu) (#76)
[x] Hooks FAQ (@thefrontendwizard) (#115)

Warnings ✅ Completed
These are the pages that you get when you click the links in the console (e.g. https://reactjs.org/warnings/dont-call-proptypes.html). People tend to search these, so please don't translate the error message itself.

[x] dont-call-proptypes (@matheusmonte) (#19)
[x] invalid-aria-prop (@andrescalco) (#24)
[x] invalid-hook-call-warning (@henriquejensen) (#52)
[x] legacy-factories (@juliofortunato) (#88)
[x] refs-must-have-owner (@GCrispino) (#59)
[x] special-props (@andrescalco) (#28)
[x] unknown-prop (@crisgon) (#44)

Advanced Guides ✅ Completed

[x] Accessibility (@LucasVilela) (#74)
[x] Code-Splitting (@lucianomlima) #140
[x] Context (@jancassio) (#55)
[x] Error Boundaries (@fmoliveira) (#73)
[x] Forwarding Refs (@taynancid) (#64)
[x] Fragments (@gustavoaz7) (#13)
[x] Higher-Order Components (@victorfsf) (#77)
[x] Integrating with Other Libraries (@thulioph) (#82)
[x] JSX In Depth (@murtinha) (#105)
[x] Optimizing Performance (@boniattirodrigo) (#110)
[x] Portals (@Rahmon) (#97)
[x] React Without ES6 (@gutofoletto) (#95)
[x] React Without JSX (@tibuurcio) (#56)
[x] Reconciliation (@victorsilent) (#41)
[x] Refs and the DOM (@steniowagner) (#40)
[x] Render Props (@italotabatinga) (#94)
[x] Static Type Checking (@ericp3reira) (#103)
[x] Strict Mode (@lffg) (#25)
[x] Typechecking With PropTypes (@lucasdeassis) (#17)
[x] Uncontrolled Components (@arthur-souza) (#53)
[x] Web Components (@thealexandrelara) (#27)

FAQ ✅ Completed

[x] APIs and AJAX (@lazaroalvarenga) (#9)
[x] Babel, JSX, and Build Steps (@GleidsonDaniel) (#12)
[x] Passing Functions to Components (@negreirosleo) (#16)
[x] Component State (@vhfmag) (#129)
[x] Styling and CSS (@rhiroyuki) (#36)
[x] File Structure (@RodolfoSilva) (#37)
[x] Versioning Policy (@elainemattos) (#148)
[x] Virtual DOM and Internals  (@WeslleyNasRocha) (#159)

Contributing ✅ Completed
Priority: Low

[x] How to Contribute (@lhcgoncalves) (#138)
[x] Codebase Overview (@lamecksilva) (#43)
[x] Implementation Notes (@Luanf) (#146)
[x] Design Principles (@moiseshilario) (#60)

Components ✅ Completed
Components in src/components that have some text in them.

[x] CodeEditor (@abnersajr) (#20)
[x] CodeExample (@luizcieslak) (#30)
[x] ErrorDecoder (@halian-vilela) (#29)
[x] LayoutFooter (@gstvribs) (#84)
[x] LayoutHeader (@thealexandrelara) (#89)
[x] MarkdownPage (@lucianomlima) (#145)

Additional Translations
These are not the primary translation targets.

[x] Blog (#151)
[x] Community

[x] Tools: (@crisgon) (#106)
[x] Resources: (@Duduzera1997) (Support #152, Courses #158, Examples #164, Meetups #169, Conferences #179, Articles #184)

Hello World
Hey, I'd like to help. I'll take the Hello World page on the basics section. Ok?

May I translate Introducing JSX? :)

I'll translate the Conditional Rendering page

I could help with “Introducing JSX”

@rafael-vitor @ericp3reira @httpiago I gave you the sections you requested!
@mathsalmi could you pick another section?
@cezaraugusto @jcserracampos @WendellAdriel make sure you follow this issue and update it when people volunteer!

“Rendering elements” then?

Hi! I want to work on the Home Page

I would like to work on "Introducing Hooks"

Hey, I can help!
I would like the Components and Props section.

Hello! I'd like to translate Lifting State Up.

I'll translate Forms page

Hi, I can translate Composition vs Inheritance

I can not translate the whole page, there are some parts with red text that I can not edit, so I'll go to another page: Handling Events and State and Lifecycle

@httpiago what do you mean "red text I can't edit"? Please only request a page at a time. I gave you "Handling Events" for now.

@httpiago Ah, we're not editing the text directly in Crowdin -- it's just a reference to make your work easier. You should do your translations directly in the source code! Either directly edit the file here by clicking the pencil icon or clone this repository and work on it on your preferred text editor.

@tesseralis ok if I split this issue into each part with its own issue? my plan is to have an issue covering in checkboxes each page heading for example. this could speed up the process as it is less text to translate and so less effort from maintainers to review.
from past experience, anything bigger than 2 paragraphs can take months to finish due to work/life/motivation loss and this plan tries to avoid a page being stuck with someone longer than it could be while others could contribute.

@httpiago Ah, we're not editing the text directly in Crowdin -- it's just a reference to make your work easier. You should do your translations directly in the source code! Either directly edit the file here by clicking the pencil icon or clone this repository and work on it on your preferred text editor.

I will explain about it right now in portuguese to everyone.
"Pessoal, todos aqui devem fazer um fork desse repositório e após isso, criar uma PR de acordo com a lista criada pela @tesseralis e assignar o seu nome ao lado da contribuição que realizará, juntamente com o número da PR. Quando a @tesseralis mencionou o Crowdin, foi com a intenção de vocês darem uma olhada como foi feita a tradução anterior. As novas serão realizadas via Git ;)"
@cezaraugusto o que acha de criarmos uma outra Issue para discutir as traduções em pt? ou mantem essa aqui mesmo?

@tesseralis ok if I split this issue into each part with its own issue? my plan is to have an issue covering in checkboxes each page heading for example. this could speed up the process as it is less text to translate and so less effort from maintainers to review.
from past experience, anything bigger than 2 paragraphs can take months to finish due to work/life/motivation loss and this plan tries to avoid a page being stuck with someone longer than it could be while others could contribute.

Wow.. I was thinking in the same thing right now! :)
We are conected it! :)

@tesseralis Ah, I had not seen any forks so I thought the translation was being sent in Crowdin. 😂
No problem now

Ahh... I think I'd rather have it stay in one page, just so we can get an overall goal on the translation progress (and I'm also trying to get a progress tracker going that relies on having a whole issue for the translation).
We don't need to translate the entire thing before releasing the first version -- just the pages labelled "Core Pages". I don't think people have gotten dissuaded so far: it's been a week and both the Japanese and Spanish translations are almost done with the Core Pages!
I think splitting might make some things easier but it can make other things harder too. It's harder to make sure that people aren't taking more than one issue, for example.

Ahh... I think I'd rather have it stay in one page, just so we can get an overall goal on the translation progress (and I'm also trying to get a progress tracker going that relies on having a whole issue for the translation).
We don't need to translate the entire thing before releasing the first version -- just the pages labelled "Core Pages". I don't think people have gotten dissuaded so far: it's been a week and both the Japanese and Spanish translations are almost done with the Core Pages!
I think splitting might make some things easier but it can make other things harder too. It's harder to make sure that people aren't taking more than one issue, for example.
Let's keep the one page for now and if you're finding it too cumbersome in a few days, I'll reconsider!

Ok

Hi, I'd like to translate the Conditional Rendering page :)

@tesseralis I can translate Home Page and Tutorial.

I would like to translate Composition vs Inheritance and Thinking in React for now.

We'll have both pt-BR and pt-PT, or just pt-BR

Hi, can I translate Components and Props and State and Lifecycle :)

@gnuns
@klzns
@ifdiego
@rafaelquintanilha
@welll
@LucasVilela
@cstpk
@eduardomoroni
@jhonmike
I gave you the ones you claimed above! 🤘
@mllustosa the items you said were already claimed by others, can you choose other items? 😉

@telmogoncalves this repository is only for the pt-BR translation, but if you want to, you can submit a PR on https://github.com/reactjs/reactjs.org-translation/ to create a team and a repo for the pt-PT.

I would like to translate the whole Installation section (Getting Started, Add React to a Website, Create a New React App, CDN Links) to begin with :smiley:

On that note... are the variations different enough that it's important to maintain separate forks?

@renato-bohler We encourage people to only take one page at a time; and also, please try to pick one of the sections listed under "Core Pages"

@tesseralis I'm from Brazil, but I live in Portugal since 2016 and there are a lot of words that are different, but everyone here understands the Portuguese from Brazil, but I think that if someone wants to create a separated translation, maybe it's something to think about

Oh :disappointed: can I translate API Reference > React then?

@WendellAdriel that was my point as well. I'm Portuguese and looking at the PRs, it does sound a little different from pt-PT, understandable, by different 😊

Just assigned that to you @renato-bohler!

@WendellAdriel gotcha! I know there's only one Spanish translation and I know there are definitely regional variations there. What do you all think? Should we keep pt-BR and add pt-PT later, or should we just have a single pt for now and s/você/tu later?

@tesseralis I think that we can keep the pt-BR and later when we have a team to create the pt-PT translation we can add that

@tesseralis I just created the first version of the Glossary #4, can you pin it? I think that I don't have the needed permissions to do so.

Also, for now, I'll translate Lists and Keys

Can i get DOM Elements?

Done @tiagohermano!!! 😉

I'll work on the pt-PT translations than :)

I would like to translate the Installation Pages :) @tesseralis

Like @tesseralis said above, we are encouraging people to only take one page at a time, can I assign the Getting Started page to you for now @carolcodes ?

Like @tesseralis said above, we are encouraging people to only take one page at a time, can I assign the Getting Started page to you for now @carolcodes ?
Yes, please :)

Done @carolcodes!!! 😉

Can I take Lifting State Up?

May i translate ReactDOM?

@WendellAdriel how can I make sure I'll be part of the pt-PT team once it's available? Just keeping an eye on it?

Done @gustavobini and @michellocana!!!

@telmogoncalves we need to confirm with @tesseralis, but I think that you can create a PR on the https://github.com/reactjs/reactjs.org-translation/ for the pt-PT translation, adding you to the list of maintainers

I've opened a PR for pt-PT, we'll wait to add more maintainers and until it makes sense to merge.

Hey everyone, I would like to translate the " React.Component" section  !

Done @rcantuario!!! 😉

Please, everyone that's already working on translations and the ones that will start now, take a look at #4 and any questions or suggestions, please use the Glossary issue to discuss!!! :wink:

@telmogoncalves this repository is only for the pt-BR translation, but if you want to, you can submit a PR on https://github.com/reactjs/reactjs.org-translation/ to create a team and a repo for the pt-PT.

In Portuguese Translation in node.js  we mantain the same time core (pt-br and pt-pt) as you can see here:
nodejs-pt
The linguistic variations are so few with Brazilian Portuguese to Portugal.
I think we may follow the @tesseralis advice in just let this issue with pt (even to Brazilian Portuguese and Portuguese). And then if we see there will be a lot of linguistic variations changes, so we can think to open a issue for pt-PT.
What do you think about it? @cezaraugusto @tesseralis @WendellAdriel @telmogoncalves ?

@WendellAdriel even be part of moderation time in pt-BR, I will help to translate a few pages. I already assigned myself.
But as we already do in Time Core Translation in nodejs.org, we just will approve a PR after two LGTM and code review?
cc: @cezaraugusto

Oh I see, @glaucia86.
For me it's ok, I just pointed out that because living here I know that the way we write in Brazil and here in Portugal can be very different sometimes. But as I also said, they can understand the differences. But if there's a team to translate to pt-PT, I don't see any issues with that :wink:

I agree, @glaucia86. Every PR needs to be checked by at least two diff contributors and just after LGTM (two is a good number) and code review that we can approve to merge. Until now I think that we just got one PR to review, the other is a WIP and the other one is mine, but not related to translations.

Can I translate FAQ starting with APIs and AJAX

Done, @lazaroalvarenga!!! 😉

I can take the * Hooks at a Glance

I agree, @glaucia86. Every PR needs to be checked by at least two diff contributors and just after LGTM (two is a good number) and code review that we can approve to merge. Until now I think that we just got one PR to review, the other is a WIP and the other one is mine, but not related to translations.

do you know if the 'Settings' are prepare for these cases?

Could I take "Test Utilities"?

Done @gabrielbs and @luizbraga!!! :wink:

@WendellAdriel I would like to take ReactDOMServer.
@telmogoncalves Please let me know if you need help with the pt-PT, I'm from Mozambique and identify more with pt-PT than pt-BR. Depending on the number of the contributors in the pt-PT repo we could benefit from the translations from the folks here and just make a few tweaks?

Done @fjoshuajr!!! :wink:

Can I take How to contribute page?

Can i take Codebase Overview page?

I would like to help on "Render Props"

Can I take API Reference / glossary page ?

Can I take the Using the State Hook?

cc: @evaldosantos
Done. 👍
Already assigned it!

@WendellAdriel I would like to take ReactDOMServer.
@telmogoncalves Please let me know if you need help with the pt-PT, I'm from Mozambique and identify more with pt-PT than pt-BR. Depending on the number of the contributors in the pt-PT repo we could benefit from the translations from the folks here and just make a few tweaks?

I've added you as a maintainer in the PR 👍

cc: @vinicius98s
Done. 👍
Already assigned it!

cc: @lhcgoncalves
Done. 👍
Already assigned it!

Can I take Shallow Renderer?

May I take JS Environment Requirements?

Can I take JS Environment Requirements

Done @henriquejensen and @koka0012!!! 😉
@thadeu, this was already claimed before, can you please choose other?

Done @henriquejensen and @koka0012!!! 😉
@thadeu, this was already claimed before, can you please choose other?

so, I take Rules of Hooks to translate

my i take the Using the Effect Hook

Done @thadeu and @WeslleyNasRocha!!! :wink:

Hi, can I take Error Boundaries?

Hi, can I work on Add React to a Website? 👋

Done @fmoliveira and @ukita!!! 😉

Hi! Can I take Higher-Order Components?

@victorfsf assigned 👍

can I take JSX In Depth?

can I take JSX In Depth?

Assigned @murtinha 👍

Hi! May I take Create a New React App?

@WendellAdriel Can I work in the Hooks API Reference now?

The page Babel, JSX, and Build Steps is mine! 👀
Ok?

@mrcelo @thadeu @GleidsonDaniel assigned, thanks!

Can I take Code Spliting ?

Done @wagnermoschini!!! :wink:

Can I take Fragments &   Typechecking With PropTypes ?

I assigned Fragments to you @gustavoaz7, when you finish that one, you can take another, we are encouraging people to work on one page at a time!!! :wink:

Hi. Can I take Portals?

Hi there, may I take React Without JSX? Thank you :)

Hi. Can I take Hooks FAQ?

@tesseralis @WendellAdriel Can I take  "dont-call-proptypes"in warnings  ?

I can take Typechecking With PropTypes!!

I would like to translate CDN Links or another page following your priority list

I would like to translate Passing Functions to Components, Could you assign me? thanks!

Hey. I can take Optimizing Performance.

I can take Context page.

Assigned @Rahmon @tibuurcio @thefrontendwizard, thanks!

Can I be assigned to translate FAQ > Styling and CSS?

Assigned @matheusmonte @lucasdeassis @leandrocustodio, thanks!

I would like to translate Reconciliation :)

Assigned @negreirosleo @boniattirodrigo @jancassio, thanks!

May I translate "Reconciliation" section ? :eyes:

Assigned @rhiroyuki @victorsilent, thanks!

May I translate "Reconciliation" section ? 👀

Sorry @thiagoarmede it's already taken, feel free to choose another.

Oh boy, someone asked before, may I go for virtual dom instead?

Assigned @thiagoarmede, thanks!

Can I be assigned to translate "Design Principles" please?

Considering Virtual-dom and internals a small parts, can i translate Static Type Checking too? :eyes:

Can I translate Static Type Checking? 🤔

I can take: FAQ > File Structure

Assigned @moiseshilario, thanks!

Considering Virtual-dom and internals a small part, can i translate Static Type Checking too? 👀

@thiagoarmede When you finish that one, you can take another, we are encouraging people to work on one page at a time!!! 😉 cc: @WendellAdriel
If you want I can re-assign you to Static Type Checking only.

you can give it to @thulioph :heavy_check_mark:

Assigned @RodolfoSilva, thanks!

Can I be assigned to Component State? :)

Hey, the glossary link at the beginning is poining to this page, is this exepcted?

I can take Static Type Checking =)

Oh, thanks @negreirosleo, I'll update it!!! 😉

Done @vhfmag and @lazaroalvarenga!!! :wink:

I can take React Without ES6 :)

I can take Integrating with Other Libraries 😄

Assigned @thulioph, thanks!

Assigned @gutofoletto, thanks!

I can take Strict Mode! :)

Assigned @lffg, thanks!

I can take Uncontrolled Components!

For new contributors, please take a moment to look at our Glossary and Style Guide to keep your translations consistent across the repo. Happy Translating!

Assigned @arthur-souza, thanks!

I would love to translate Refs and the DOM!

I can take Web Components

I have a question.
In the Components and Props page, there is an external link to Pure Functions on Wikipedia. I didn't find a page that match it in portuguese on Wikipedia. Should I keep the same link in english? Or should I find another link?

Hello, i would to love to work in State and Lifecycle.

Hello, i would like to work in State and Lifecycle.

hi i would like to translante Forwarding Refs

Hi! I would like to translate Versioning Policy

Hi! I would love to work on the Implementation Notes

State and Lifecycle

Could you translate 'Forms' page @GabLeme ?

Done!👍
Assigned Forwarding Refs page
cc: @taynancid

Done!👍
Assigned Forwarding Refs page
cc: @juunegreiros

Done!👍
Assigned Implementation Notes page
cc: @SousaItalo

Assigned @steniowagner @thealexandrelara, thanks!

Code Editor to me please.

Done with dont-call-prototypes, Can I get * invalid-hook-call-warning @tesseralis

@matheusmonte vamos esperar pela aprovação do seu PR e depois te atribuiremos uma nova tradução para fazer. Pode ser assim?

Assigned @abnersajr, thanks!

Hey, I want to translate the Forms page

@httpiago you got forms!

I would like to make some translation revision, which page is more critical?

Hello, I can work on the invalid-aria-prop XD

@halian-vilela feel free to check the pull requests and add your review
@andrescalco cool, assigned

LayoutFooter
Can I get it?

@cezaraugusto PR on the way!

@halian-vilela feel free to check the pull requests and add your review
@andrescalco cool, assigned

Nice! Doing that already.
Guess I'll get some of the last ramaining parts in src: ErrorDecoder
Ok?
Pretty simple, I guess I should translate just the small text inside the return, that's ok?

I can translate special-props too

@glaucia86 meu PR #19 foi aceito, pode me indicar uma outra página para trabalhar agora?

ErrorDecoder is translated, please check the PR here. Moving on to translate another component in src. Which on has higher priority?

Can I translate CodeExample?

My PR #27 was approved, can I translate LayoutHeader?

Guys, src components LayoutHeader and LayoutFooter has some important link names that should be in sync with the respective page titles.
I guess we should decide over this in the Glossary or something like that, souldn't we?

Gostaria de contribuir tbm. Aparentemente o legacy-properties não foi pegue ainda. Porém se houver outra página mais interessante estou a disposição.
No aguardo da resposta.

Hey @tesseralis and @WendellAdriel, A friend of mine (https://github.com/leomosiah) want to contribute as well. Could you add him in the Translation team? You can assign him to any of the section that still missing translator.

Gostaria de contribuir tbm. Ainda há alguma página para ser traduzida?

Hey, I want to translate warning's legacy-properties topic :raising_hand_man:

I want to translate special-props

I want to translate special-props

Hello @eduardo-almeida, I already translated that one.

Could I take invalid-hook-call-warning to translate?

@andrescalco @luizcieslak @thealexandrelara @henriquejensen assigned
@eduardo-almeida please choose one from the list without owner, that one is assigned
@halian-vilela agree re https://github.com/reactjs/pt-BR.reactjs.org/issues/1#issuecomment-462004111
@eduardomoroni he can contribute right away as other are doing. I like the idea of having more
people to help maintaining this project but I'm better if that person has helped in the review process before or at least helped improving the translation process by any means, which is what I think is expected from maintainers.
I'm speaking for myself here but if you think I'm wrong I guess https://github.com/reactjs/reactjs.org-translation is the best place to ask

I want to translate the unknown-prop warning page.

Please reference my pull request (https://github.com/reactjs/pt-BR.reactjs.org/pull/25) in the first comment.

I’d like to comment the “refs-must-have-owner” page, please :)

@crisgon @GCrispino assigned
@lffg I'm adding them as they get merged. just approved yours  so let's wait for another reviewer to approve and we can merge/reference here

Hi, I'd like to translate MarkdownPage

@elainemattos Thanks! You were assigned for this section.

May I translate Introducing JSX? :)

PR created: https://github.com/reactjs/pt-BR.reactjs.org/pull/47
May I take those components, like CodeExample, ErrorDecoder and more?

for reference, these are the docs that still need an owner:

Static Type Checking
LayoutFooter
Blog (any post)
Community

we also have two files for the navigation that needs translation but it's better to have them translated only after translating all other pages
at the moment we also need help with https://github.com/reactjs/pt-BR.reactjs.org/issues/42 as well

May I take Static Type Checking?

The Community page can be divided into community resources and tools.

@ericp3reira @crisgon added

I finished the state and lifecycle page, can I help with anything else?
Components > LayoutFooter

Hey everyone.
I'd ask how far is the progress of the translations? I'd to help especially on the hooks translation but almost everything was picked up.
Does someone want/need some help?

@raulfdm a gente precisa de ajuda para revisar as traduções que se encontram em PR.
Caso tu prefira trabalhar em tradução, eu posso te passar a seção Tutorial e tu traduz com @halian-vilela. Esta seção é grande :)

@eduardomoroni eu posso revisar as traduções no PR. Só falar quais precisam ser revisadas. Ou posso ajudar na tradução da seção Tutorial.

@LeoMosiah Dá uma olhada nos pull requests com a label "needs review", esses são os que precisam  ser revisados. Obrigado pela disponibilidade :)

Vou dar uma olhada @tibuurcio.

[OUT OF TOPIC]
Pessoal! Volte e meia eu procuro fazer lives no meu canal do twitch.tv.
E como ultimamente estou envolvida nesse projeto do Code Review, estou realizando ele de maneira online e disponível para que todos possam acompanhar o nosso trabalho.
Segue o link abaixo: https://www.twitch.tv/glaucia_lemos86
Agradecemos aos esforços feitos por todos da Comunidade Técnica Brasileira. 😍

Hi, can i take LayoutFooter ?

@gstvribs Assigned you :)

Pessoal... ficou acordado em uma das issues que iremos conversar entre nós em português. Sem necessidade de falar em inglês. nos commits que a gente precisa que vocês façam comentários em inglês.
Abraços e muito obrigada a todos! :)

@glaucia86 Adoraria ajudar na tradução de Forms, muito obrigado.

State and Lifecycle

Could you translate 'Forms' page @GabLeme ?

@glaucia86 Adoraria ajudar na tradução de Forms, muito obrigado.

@raulfdm a gente precisa de ajuda para revisar as traduções que se encontram em PR.
Caso tu prefira trabalhar em tradução, eu posso te passar a seção Tutorial e tu traduz com @halian-vilela. Esta seção é grande :)

Pode ser a sessão de tutorial :)

Oi @raulfdm
As partes que faltaram para tradução lá na Tutorial (#68) são as linhas: 347 até 607
Acompanha a conversa lá que talvez tenha algum termo que possa te ajudar.

@raulfdm se tu puder traduzir o restante da seção tutorial seria ótimo, hoje vou dedicar um tempo a revisar os PRs. Vou estar no discord caso queira trocar uma ideia sobre
https://discord.gg/Zn4bXAz

Pessoal, gostaria de contribuir com a tradução, mas verifiquei o checklist e aparentemente todas as páginas já estão atribuídas a alguém. Alguma sugestão de página para traduzir ou revisar ?

@thiagoreis Se você quiser ajudar revisando, pode ir nos PRs abertos e comentar lá.

Pessoal, gostaria de contribuir com a tradução, mas verifiquei o checklist e aparentemente todas as páginas já estão atribuídas a alguém. Alguma sugestão de página para traduzir ou revisar ?

Oi Thiago, bem vindo!
Dê uma olhada na lista das PR, algumas tags explicam o status. Se tiver como "needs review" ou "needs +1" quer dizer que alguém traduziu mas precisa de revisão ainda.
É só entrar lá, ler o status da tradução e sugerir possíveis correções/adequações.
Lembre-se de checar o Glossário/Styleguide que está na raiz do projeto. Lá temos termos chave e como têm sido traduzidos ou os que não precisam de tradução.
É isso! Happy Translating/Reviewing 😄

Opa obrigado @Rahmon  e @halian-vilela!
vou verificar as PR.

Hey folks, I would love to help with the translations, so I am assigning me in this issue, and as soon I get back home from Campus Party Brasil, I will start to work in this

@welll @rcantuario @fjoshuajr how are your translations going? Please let us know if you are unable to complete them so we can assign them to other folks. We're almost there!

I'm working on the FAQ's translation. Should be able to open a PR in a couple of days.

I'm working on the FAQ's translation. Should be able to open a PR in a couple of days.

Hey @thefrontendwizard
If you find that it's too long for you alone, maybe you could open the PR as WIP and divide the translation with another person. We've done that with some bigger files and it worked out pretty well, accelerating the process...
It's up to you, but perhaps it's a good idea. 😄

I'm halfway through it already and the largest bodies of text are already done. Just one or two more pushes and it'll be ready 😄

@halian-vilela that's a good idea! I'm gonna add it to the maintainer guide.

@welll @rcantuario @fjoshuajr how are your translations going? Please let us know if you are unable to complete them so we can assign them to other folks. We're almost there!

@tesseralis
Almost done. I'll submit the PR ASAP.

Hi everyone.. I'm currently translating, I will finish until friday.
Em ter, 19 de fev de 2019 às 21:02, Nat Alison<EMAIL_ADDRESS>escreveu:

@welll https://github.com/welll @rcantuario
https://github.com/rcantuario @fjoshuajr https://github.com/fjoshuajr
how are your translations going? Please let us know if you are unable to
complete them so we can assign them to other folks. We're almost there!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/reactjs/pt-BR.reactjs.org/issues/1#issuecomment-465362675,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB4BclUQcoC2zXA-JBCmvhHFrDX_V9Q-ks5vPJCZgaJpZM4arjQU
.

--
Renan Cantuario.

first version #117

@welll @rcantuario @fjoshuajr how are your translations going? Please let us know if you are unable to complete them so we can assign them to other folks. We're almost there!

@tesseralis
Almost done. I'll submit the PR ASAP. [2]

With the new Draft PR's, wouldn't it be easier to track if the one responsible for a translation to just open it before starting to translate?
Also, just blog posts are left to be assigned to someone?

@rodrigobacelli yup! I'd suggest going in order of most to least recent, and I don't think we should worry about blog posts that are less than like, a year old.

Hello,
How is the translation of "Getting Started" section coming along?

@maugravena progress is in this PR: #126

Hi there!!
I'd like to help with Blog (React v16.8: The One With Hooks)

So @welll could you assign me to translate this page #136 on task list, please.

So @welll could you assign me to translate this page #136 on task list, please.

Added you :)

So @welll could you assign me to translate this page #136 on task list, please.

Added you @CaiqueMOliveira :)

@welll just to confirm, I should translate the #136 or Blog - (React v16.8: The One With Hooks)?

Finalizei a tradução de "How to contribute" (#138)

@CaiqueMOliveira ,

I am not a maintainer, you got confused because I have added this issue on my PR description and it appeared below your comment

if you take a look on the top of this page, you will see @tibuurcio assigned to you this one :  Blog - (React v16.8: The One With Hooks) (@CaiqueMOliveira)

@CaiqueMOliveira ,

I am not a maintainer, you got confused because I have added this issue on my PR description and it appeared below your comment
if you take a look on the top of this page, you will see @tibuurcio assigned to you this one :  Blog - (React v16.8: The One With Hooks) (@CaiqueMOliveira)

Yes, I've been confused, but now I'll start the translation of React v16.8: The One With Hooks.
Thanks @welll

effect hooks finished #117

Hi everyone, I've done the translation for Versioning Policy, it was assigned for @juunegreiros, but we've spoken and she allowed me to do it! Please review the PR and let me know is there's anything to be adjusted. Thanks!
https://github.com/reactjs/pt-BR.reactjs.org/pull/148

updated issue @elainemattos

@thiagoarmede hurry up!

@thiagoarmede hurry up!

i guess his page passed on another translator:
https://github.com/reactjs/pt-BR.reactjs.org/issues/112#issuecomment-468990058

i will translate the virtual dom and internals, pr later today

Hello!
I can translate Community / Support ?

Hello!
I can translate Community / Support ?

Hello!
I can translate Community / Support ?

Could you?! Wow! Sure!

@thiagoarmede hurry up!

i guess his page passed on another translator: @jhonesgoncal
#112 (comment)
but still, 5 days no pr

Já te atribui. Pode pegar essa PR :)

@Duduzera1997 @WeslleyNasRocha será que conseguimos finalizar essa tradução até amanhã (domingo 10/03)?
Não entendam como uma cobrança!

@Duduzera1997 @WeslleyNasRocha será que conseguimos finalizar essa tradução até amanhã (domingo 10/03)?
Não entendam como uma cobrança!

Com certeza!

#159 tai a primeira versão do DOM Virtual e Objetos Internos

Congrats on finishing the core pages!

I just merge the last translated page, can we mark the issue as done?

@jhonmike yup, I think so... we already have an issue to track translating the blog, and maybe we can make another one for tracking the translation of the Community section?

@jhonmike yup, I think so... we already have an issue to track translating the blog, and maybe we can make another one for tracking the translation of the Community section?

it will be awesome if we do that.

Pessoal! A tradução da documentação do Reactjs.org já está 100% completa. Antes de mais nada, gostaria de agradecer a todos aqui pela ajuda prestada! Foi lindo tudo o que aconteceu aqui! Vocês e nós da Comunidade Técnica - são demais!
Parabéns a todos! E muito obrigada!


Improve the logging output when hitting an expected error creating Analyze Command

When creating an analyze command the "ConfigSourceToScan" and "ConfigRules" methods are called from the constructor. These methods may throw exceptions, and those exceptions are printed to the console with the stack trace. This level of detail isn't needed (perhaps the stack trace should show up on the debug level) but the Error level should be less verbose and a human readable error message. This ctor is called in many places (IDE is indicating over 50), so its a medium effort to refactor all those calls to handle the exception more gracefully.
Alternately consider a different calling pattern that obviates the need for throwing these exceptions in the first place.
For example, we currently throw an exception from the AnalyzeCommand if the source to scan contains no files. This seems like a worthwhile check, but likely doesn't need to be in the analyze command, and probably should just be part of the CLI experience not the lib.

These methods were cleaned up in #513.


Add to bower

Would you accept a PR?

I think that it is fine, but wait for a response from @3rd-Eden (he is bit busy these days).

Yes, ill accept pull requests for it but I won't be maintaining it.
Arnout Kazemier

On Feb 22, 2015, at 4:26 AM, Luigi Pinca<EMAIL_ADDRESS>wrote:
I think that it is fine, but wait for a response from @3rd-Eden (he is bit busy these days).
—
Reply to this email directly or view it on GitHub.

That's fine, EventEmitter3 doesn't really seem to change. PR coming up.


Missing durability with armor showcase.

Your previous mod had armor/tools durability in-screen.
Are you planning to re-add this?
Surely hope so!

I did not plan for it initially, but with most of the features I wanted already added, I might as well get started on it. (14-day ETA)


[Type checker] Propagate type checking errors up from closures.

We were failing to propagate errors up when we type check closure
bodies, and that can lead to crashes if we continue executing, calling
into code like performSyntacticExprDiagnostics() which expects a
successfully type-checked AST.

I'm getting some unexpected errors locally and will re-open when those are fixed.


Clamped alpha is preventing certain blending effects

Godot version
4.0.3
System information
Windows 10, amd rx 480 gpu
Issue description
Unlike Godot 3, Godot 4 clamps alpha values before blending. I'm not sure where in the rendering pipeline this happens, or if it's even controllable, but it makes it impossible to do certain types of blending trickery that are common in 2d games. For example, in Godot 3, you can render 50% gray with 200% alpha over anything to invert its colors. In Godot 4, this is impossible; 200% alpha acts like 100% alpha.
Godot 3:

Godot 4:

Steps to reproduce
Add a ColorRect with the following shader:
shader_type canvas_item;

void fragment()
{
    COLOR.rgb = vec3(0.5, 0.5, 0.5);
    COLOR.a = 2.0;
}

Minimal reproduction project
ClampedAlphaRepro.zip

For context on where I ran into this: I'm making a voxel level editing tool, and when configuring some kinds of materials, I have to display a grid over them. In Godot 3 I was rendering that grid with this technique, but it no longer works properly.

Can you reproduce this in 3D?

Inversion works in 3D:

Alpha blending happens before anything is written to the underlying buffer, and this technique is used by a fair number of old games without HDR, so at the very least, having LDR buffers wouldn't prevent this from being fixed. This is a good pointer in the right direction, though.

This was fixed last summer by https://github.com/godotengine/godot/pull/80215. The fix is included in version 4.2!
To benefit from it, you just need to enable the rendering/viewport/hdr_2d project setting!
note, the colors won't be the exact same since blending happens in linear space now. But that is an expected difference between 3.x and 4.x


Question: is patchtst_supervised.py in self-supervised model same as supervised model?

Hi, I really appreciate your help so far!
I have one more question about the codebase: What is the difference between patchtst_supervised.py in the self-supervised folder (https://github.com/yuqinie98/PatchTST/blob/main/PatchTST_self_supervised/patchtst_supervised.py#L104)
and PatchTST training in the supervised folder (https://github.com/yuqinie98/PatchTST/blob/main/PatchTST_supervised/run_longExp.py#L140C1-L140C1) in terms of the way of training? Can I understand both training scripts are doing the same thing?
Thanks!

Hi, generally speaking they are very similar, some main differences: 1. the supervised code is modified from previous repo like Autoformer, FEDformer, while the self-supervised code is adapted from tsai repo. 2. The supervised task is doing prediction while the self-supervised one is reconstructing the masked patches.

I see, thanks for sharing. :)


Add a total_symbols endpoint

Should simply return the number of unique symbols in the database.  It should take an optional param that provides a number of hours ago in which there must have been a popularity update for it to be included in the count.
So, if the param is 5 and the symbol hasn't had a popularity update in the past 5 hours, it won't be included in the total.

My hero


@ngrx/store is reset on rc5

Hi, There is a problem with ngrx and rc5 router this scenario:
I'm on login page. dispatch a login action. (the response is saved to store via reducer)
when the token on the state is change (subscribe) I navigate to another page.
I click on button to navigate back to login page,
I see that the store injection is back to initial state.
any ideas why?

also
action.type @ngrx/store/init
called twice to reducer.. :(

also, in startup application, the action:
@ngrx/store/init
called twice to same reducer.
at init :(

need a reproduction of this to do any sort of investigation...

fixed in 2.1.2
thanks @robwormald :)


Replaced invalid / tags with desired  tags

Fixes

Fixes #[issue number] by @[issue author]
Fixes #1069 by @zackkrida
Description

Changes all invalid 'h2/h5' headings to desired 'h1' headings
Technical details

Tests

Screenshots

Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[ ] My pull request targets the default branch of the repository (main or master).
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Hi @chetas411, thank you for your PR, but please re-read the issue: https://github.com/creativecommons/cccatalog-frontend/issues/1069
Your PR will alter the design by changing the styling of the headings. We need to wait until we have new .title .is-1 classes so that heading style is separate from the actual tag being used.

@chetas411 No worries! Thanks for looking into the issue. I can show you next steps when it is ready 😸

@chetas411 No worries! Thanks for looking into the issue. I can show you next steps when it is ready 😸

Looking forward to it!

hi @chetas411 i put some notes on what will need to be done here: #1069 (comment)

sure I am closing this PR and would create a new PR with updated code


Update LICENSE to Biogen Inc.

Fixing incorrect assignment of license.

@gcosne @Chloe1458  could you take a look at this license fix. I don't have write permissions yet to merge myself.


Add Categories for Mechanitor Gear and Other Assorted Special Gear

Besides the obvious changes as per feature/screenshot below, I also:

Commit cb60dab0aef9b2c5f731e667d7a8d6a4ad2a5fe2:

shuffled a couple whitespace lines to more logically group code blocks
pulled out some repeated logic into booleans
namespace Foo; wouldn't compile for me so I had to change it to namespace Foo {} but I DID NOT change the bracket indentation in the whole file (as that would make this PR impossible to read)

Commit b530900ef12994e4a49760a164a74f4c03776b3e

I update the DLL here but you probably want to test recompiling yourself

Should be added in ce592bc
Thank you for this addition!
Regarding the namespace not using {}: this is a feature added in C# 10 - reference
You may need to update your IDE or installed SDKs for it to work.


feature request : time frame

I noticed that the time frame parameter of a target is not constant over time : the time frame is set according to the value 'end year of the target' - 'current year'. For example a target which starts in 2020 and ends in 2030 would have a MID time frame if we calculate its temperature score in 2022 (2030-2022=8), but in 2027 it would have a SHORT time frame (2030-2027=3).
I have 2 concerns about this :

it does not make sense to have a non constant time frame : we use the annual reduction rate of targets to calculate the temperature scores from the regression models, suggesting that the reduction will be constant over the lifetime of targets.  Let me illustrate : a target which lives from 2020 to 2050 will be mapped to a SHORT regression model in 2046. Therefore the tool will consider that the target is reducing its emissions at a constant rate for a maximum of 5 years, but it does not take into account that the constant reduction started 26 years ago.
I am planning to compute everyday the temperature score of a portfolio and track the change over time. Each time the target of a company in my portfolio will change of time frame (between year 2025 and 2026 in my first example), it will be mapped to a different regression model, implying a suddenly non negligible difference of temperature score for no valid reason. I do not want this, and I think most of other asset management teams would agree with me.

I am suggesting either to replace the time frame value (line 249 of SBTI/target_validation.py, see image) by target.end_year - target.start_year, or to add a parameter year_time_frame in the calculate() method of the TemperatureScore class : this parameter can only take value 'current' (by default) or 'start', allowing users to choose which time frame mapping they want to use. This second option is what I implemented in this pull request. Please note that this branch can be used as the main one since if the parameter year_time_frame is not specified, the time frame calculation method will be the one already existing.

Hi and thanks for your input.
Since this change would mean a departure from the temperature rating method as it is currently defined, I would like to ask you to bring the question to the SBTi finance forum Methods category: https://community.sciencebasedtargets.org/c/7-category/7 so that the SBTi technical team can review the request.


”Văleni”, ”Moara Domnească” are listed in the drop-down menu

Description:
When user writes ”Văleni”, ”Moara Domnească” the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Văleni"

Expected results
The location appears in the drop-down menu as "Sat Văleni, VASLUI (Văleni)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Moara Domnească"

Expected results
The location appears in the drop-down menu as "Sat Moara Domnească, VASLUI (Văleni)".


Add permissive license to project

I would like to request the addition of a permissive license to the project. Currently, the project does not have a clear licensing statement, which may restrict its usage and redistribution. By adding a permissive license, we aim to provide a legal framework that allows users to freely use, modify, and distribute the project with minimal restrictions.

Hi, yes I will be adding a license. Likely ongoing changes will happen now in another repository, opencubes, which again will need a license.

Courtesy link to opencubes: https://github.com/mikepound/opencubes


jquery.confirm.min.js has console messages

I have installed the library with using bower. But there are log messages on console when I open a dialog. Is it normal? Can I disable it?

This is the line which shows message;
console.log(that._lastFocused);

This is to be removed in the next version, this was a debug message.

I've removed the console message in the v3.0.3 now.

Thank you very much. I appreciate. 👍


error trying to create a k8s_cluster

I'm using the 0.1.0 provider, and I'm attempting to create a k8s_cluster, but I'm running into an error:
Error: error creating K8SCluster: Creating object: Unsuccessful POST at URL https://<redacted>.console.ves.volterra.io/api/public/namespaces/matt-test/k8s_clusters, status code 400, body {
  "code": 3,
  "message": "Field spec.insecure_registries_choice should be not nil, got nil in request.",
  "details": [
    {
      "@type": "type.googleapis.com/ves.io.stdlib.server.error.Error",
      "code": "UNKNOWN",
      "details": "Field spec.insecure_registries_choice fails rule ves.io.schema.rules.message.required constraint true due to value \u003cnil\u003e",
      "timestamp": "2021-02-19 23:35:37.399449404 +0000 UTC m=+98809.477567430"
    }
  ]
}, err %!s(<nil>)

here is the terraform I'm trying to use:
resource "volterra_k8s_cluster" "matt_test" {
  name                              = "matt-test"
  namespace                         = volterra_namespace.matt_test.name
  use_default_cluster_role_bindings = true
  use_default_cluster_roles         = true
  use_default_psp                   = true
  no_global_access                  = true
  no_local_access                   = true
}

I attempted to add in the property as follows:
  insecure_registries_choice        = false

but this also doesn't work:
Error: Unsupported argument

  on main.tf line 45, in resource "volterra_k8s_cluster" "matt_test":
  45:   insecure_registries_choice        = false

An argument named "insecure_registries_choice" is not expected here.

Thank you for this. This is old schema in client library caused by last week upgrade. We will fix this asap.

@mattsawyer77: This is fixed with the new version v0.1.1


Zeplin is not using electron

</3
https://twitter.com/zeplin_io/status/842437674606637060
i thought i'd look into this when i saw the update was only 12MB - i was wondering how they pulled it off with electron! as it turns out, the app is entirely native

That's strange. The Zeplin folks were really eager to collaborate on a blog post about their use of Electron not so long ago... 🤔

We've just found this issue and corresponding pull request! Our macOS app is fully native, but our Windows app is built with Electron. That question in the tweet was about our macOS app, hence the answer. Sorry for the confusion.
We're still eager for the blog post too!

oh hooray! my mistake

@merih If Zeplin for windows is electron, does that mean that there could be a linux build? I Would love that.


Dependency bugs when starting ACA-py agents using Docker

Hi all, I am new to the Hyperledger space and trying to get my first Aries agents up and running using docker. I have been running into several issues while starting and I was hoping to get some help from everyone. Firstly, I am running all of this on an M1 MacBook Pro with macos Ventura 13.2.1.
Following the documentation here I have been attempting to run ACA-py agents using the scripts/run_docker start command as detailed in the README above. A von-network server is already running with an 'Alice' DID written to the ledger. The exact command used is:
scripts/run_docker start \
--inbound-transport http <IP_ADDRESS> 8000 \
--outbound-transport http \
--admin <IP_ADDRESS> 11000 \
--admin-insecure-mode \
--genesis-url http://host.docker.internal:9000/genesis \
--seed Alice000000000000000000000000001 \
--endpoint http://localhost:8000/ \
--debug-connections \
--auto-provision \
--wallet-type indy \
--wallet-name Alice1 \
--wallet-key secret

Bugs:

No matching distributions can be found for the indy-vdr~=0.3.3 and ursa-bbs-signatures~=1.0.1 modules when installing the requirements. Commenting out these dependencies fix these issues but would this have further downstream affects and is there a better solution?

Using the 'fix' above the agent fails to start due to aries_cloudagent.utils.classloader.ModuleLoadError: Unable to import module aries_cloudagent.indy.sdk.profile: No module named 'indy', however, I checked the requirements and python3-indy is already installed.

Any and all help is much appreciated thank you very much!

See if the workaround described here fixes your issues; https://github.com/hyperledger/aries-cloudagent-python/issues/2312

Thank you, that has helped solved the first problem but the second bug still stands with the same error.
For anyone who may have the same issue I added this bit of code to the top of the scripts/run_docker.sh file:
# Set default platform to linux/amd64 when running on Arm based MAC since there are no arm based images available currently.
if [[ $OSTYPE == 'darwin'* ]]; then
  architecture=$(uname -m)
  if [[ "${architecture}" == 'arm'* ]] || [[ "${architecture}" == 'aarch'* ]]; then
    export DOCKER_DEFAULT_PLATFORM=linux/amd64
  fi
fi

The persistent errors may have to do with cached images.
You could try temporarily updating this line
https://github.com/hyperledger/aries-cloudagent-python/blob/d1341f56c6867c23ccd7e17e0390af0b9d4cb66e/scripts/run_docker#L6
to
$CONTAINER_RUNTIME build --no-cache -t aries-cloudagent-run -f ../docker/Dockerfile.run .. || exit 1

To see if that helps.

That still produces the same error unfortunately 😢

That still produces the same error unfortunately 😢

The first or second error you were getting?  If the second ... Even after uncomment the dependencies you commented out?

The first error was completely fixed by your patch in the von-network repo even after uncommenting the indy-vdr and ursa-bbs-signatures in requirements, the second error still persists with the indy module not being found.

I see the issue.  python3-indy is installed, but that's only a wrapper for the indy-sdk which does not look like it's installed by that particular image.  Switching to --wallet-type askar should fix that issue.  Askar storage is superior to Indy storage, and the indy-sdk is being deprecated in favor of Askar and other newer shared libraries.

Thats fixed it thank you! Should I submit a PR to ACA-py with the ARM workaround you added to the von-network repo?

Should I submit a PR to ACA-py with the ARM workaround you added to the von-network repo?

Please do.

Thanks for the notes.  We need to remove any references to the —wallet-type indy from the repo and always use Askar.  I’ll create a task that we check through and update where ever needed.
I’ll close this one based on the PR and the new issue — which we will work on very soon.


I use add_widget adding a new widget, having problem dragging them with handler

It works fine if I remove the
draggable: {
handle: $('.header')
}
but after i add a new widget with the header it's not draggable

draggable: {
handle: '.header'
}
Gridster needs only selector, not a jQuery wrapped html element


Add upgrade notice for breaking changes in readme.

Not exactly sure what this is. So is it upgrades that will break things from previous versions? If so, how will the non-dev theme user know whether or not to upgrade?

I've paid a lot of attention not to introduce any breaking changes, and in case I find any I'm trying to fix them.
BUT some things are inevitable.
So far the only breaking change I have found is with background controls.
For example, in pre-1.0 versions ( more than 2 years ago) we had a "background" field-type.
That wasn't exactly a field-type, it was simply adding multiple separate controls, grouped them together in the UI, and then saved them separately in the db.
If you haven't seen this before it's because it was awful and I didn't even add it in the docs as an available field-type.
However, some of the early themes that were built using Kirki were using it (I don't know if any of them are around anymore)
In version 3.0 I added a proper background control that saves the values as an array (background-color, background-image, background-repeat etc), has output and transport working fine and so on.
It may have been something that was added 2 years ago, but I kept the implementation around until v2.3.7 (see this file) to accommodate these themes, and whenever someone mentioned that they're using the background field in their themes I prompted them to change to separate controls instead because it would be deprecated at some point.
Wether they followed my advice or not is a mystery to me...
But the point is that there's no way to provide backwards-compatibility for this, unless I do things that I would classify as bad.
Example:
Say you created a background control with an id (setting) background_setting.
Old DB structure:
$theme_mods = array(
	'background_setting' => array(
		'background-color'      => '#ffffff',
		'background-image'      => 'url-to-the-image',
		'background-repeat'     => 'repeat-all',
		'background-position'   => 'left top',
		'background-size'       => 'cover',
		'background-attachment' => 'fixed',
	),
);

New DB structure:
$theme_mods = array(
	'background_setting_color'      => '#ffffff',
	'background_setting_image'      => 'url-to-the-image',
	'background_setting_repeat'     => 'repeat-all',
	'background_setting_position'   => 'left top',
	'background_setting_size'       => 'cover',
	'background_setting_attachment' => 'fixed',
);

A possible solution: Save separate values in the db (in addition to the one saved as an array).
$theme_mods = array(
	'background_setting' => array(
		'background-color'      => '#ffffff',
		'background-image'      => 'url-to-the-image',
		'background-repeat'     => 'repeat-all',
		'background-position'   => 'left top',
		'background-size'       => 'cover',
		'background-attachment' => 'fixed',
	),
	'background_setting_color'      => '#ffffff',
	'background_setting_image'      => 'url-to-the-image',
	'background_setting_repeat'     => 'repeat-all',
	'background_setting_position'   => 'left top',
	'background_setting_size'       => 'cover',
	'background_setting_attachment' => 'fixed',
);

That last one would provide compatibility with older versions, but at the same time will mess things up in case you've got a separate field with id=background_setting_color for instance.

@carasmo btw if you have any ideas on how to handle the above do tell 😄

The last idea is great -- we are used to not using reserved classes, functions, and slugs. CMB2 docs want us to prefix our settings, and we should do the same here too.
$theme_mods = array(
	'background_setting' => array(
		'background-color'      => '#ffffff',
		'background-image'      => 'url-to-the-image',
		'background-repeat'     => 'repeat-all',
		'background-position'   => 'left top',
		'background-size'       => 'cover',
		'background-attachment' => 'fixed',
	),
	'background_setting_color'      => '#ffffff',
	'background_setting_image'      => 'url-to-the-image',
	'background_setting_repeat'     => 'repeat-all',
	'background_setting_position'   => 'left top',
	'background_setting_size'       => 'cover',
	'background_setting_attachment' => 'fixed',
);

I still hate the idea of adding useless data in the db - and potentially breaking things like not allowing you to add a background_setting_image field if you have a background_setting field...
It makes no sense.
Both methods have their pros and cons.
If I don't add this fallback there's the potential to break themes that are old and haven't been updated for a looooong time. Which is bad, but at the same time understandable. I mean if you neglect any piece of software for 2 years and don't update it to keep up with its dependencies (and by "dependencies" I also mean WP Core), then of course at some point it will break if you only update half the things in it. You can't expect a 4-year-old plugin to play nicely with a new theme and vice-versa. If you're using an old theme you're taking a big risk by updating anything on your site.
On the other hand if I do add this fallback, then I'll be adding things that 99% of people won't use just so that a handful of cases don't break. And at the same time I'll be limiting the ability to name settings however you want - which of course people will never know because they rarely read the docs - and then they'll try to add a background_setting_repeat field when they already have a background_setting and of course things will break. And it makes no sense that it breaks, it shouldn't!
This is a difficult decision that is 100% due to poor past choices.
So the real question here is this:
Do 2 wrongs make 1 right? In my experience that is never the case - as it shouldn't.
Does a wrong choice in the past justify another wrong choice now? It may be best for the present, but what about the future?

On the bright side, if you were using a background control with the output and NOT by writing your own custom code to get the values and calculate the CSS, then your code will still work.
So the breaking cases are limited to themes that used kirki a long time ago and have a custom implementation to get background properties.

Gotta go with your gut. WooCommerce just made major updates, very painful for many who don't bother to read, your users have less of a chance of that, except that a popular tut source has background documented (https://code.tutsplus.com/tutorials/toolbox-of-the-smart-wordpress-developer-kirki--cms-23739). But, as you said, if that tut doesn't keep up, it's not your fault. However the brunt of the pain will probably be felt in GitHub as I barely see any replies on their comments. I added one just now.

Actually the tutorial there is ok... it doesn't go in depth and just mentions that there's a background control.
That is still valid, and the syntax used to add the field is still identical.
The problem lies only if someone was trying to get individual values (for example just the background-color) using get_theme_mod.
But the existence of that tutorial may have led more people to use that control - even if it's not documented anywhere in the official docs. 😞
I think I'll probably send a newsletter to the people that have subscribed in kirki.org, then email individually developers that have contacted me over time regarding background controls, and give everyone a week or two before the final release. I can't think of anything more that can be done if we want to improve things.
As for the upgrade notice, it will probably be something simple like

This is a major update, please keep a backup of your files and database before updating.

It's something that everyone should do anyway before performing updates on their site, but just to be on the safe side adding a notice like that won't hurt. 😄

Just an update here.
Tweeted about it, send a newsletter and let everyone know release will be around June 15 - so in about a couple of weeks.
Yesterday I released version 2.3.8 which does nothing except add the ability to use update notices (this is a really weird one... the installed version of the plugin must have a in_plugin_update_message-{plugin_basename} filter in order for notices to be displayed for future releases. So this could not be added in 3.0, it had to already be present on installed sites).


Update s3_to_exasol to python3

I noticed that the s3_to_exasol script still uses Python 2, which is generally discontinued in 2020 and will be discontinued by exasol in the next major release. I updated the code to Python 3 and their respective packages.
As far as I can tell this now provides the same functionality, it lists all keys in a given bucket (using the ContinuationToken logic of boto3).
Since I am handling json files right now, I cannot test the remaining parts of the script (importing csvs).

Hi @mjohannfunke, thanks for your contribution!
Let us take a look.
I was also thinking of leaving out the "force_http" input parameter as it doesn't seem applicable to boto3.

Hey @allipatev ,
you are right with the force_http parameter, I removed it. I also looked through the whole script to see where it was used and removed those spots as far as I can tell.


[V1] Prototype Fully Async Detokenizer

SUMMARY:

In current v1 prototype, we create RequestOutput objects in the LLMEngine based on the value of step() and send them back to the Client. This has implications:

The Detokenizer runs in a separate process, step() may return an empty list as the Detokenizer can fall behind. This means that we need to maintain state about how many steps behind each request is (num_lagged_steps object), which complicates the code
Creating RequestOutputs and sending the RequestOutputs back to the MQLLMEngine run in the main LLMEngine process, increasing contention.

PR makes the Detokenizer fully async by using the Detokenizer as the message sender (sends the RequestOutputs to the MQLLMEngineClient --> this avoids needing to send the outputs of the Detokenizer back to the LLMEngine (reducing the complexity of the LLMEngine and reducing overhead).

ARCH SUMMARY:

TODO:

[ ] Get agreement from group that this strategy makes sense
[ ] Figure out how to make it work with LLM
[ ] Guarantee there is no race condition for sending a new request vs sending new tokens
[ ] Figure out if it is okay for the MQLLMEngine and Detokenizer to connect and PUSH to the same socket.
[ ] Propogate abort to the Detokenizer
[ ] Shutdown for Detokenizer
[ ] Error handling for Detokenizer
[ ] Decide what to do with AsyncLLMEngine
[ ] Optimize the message passing copy() like we did for the MQLLMEngine
[ ] Performance benchmark

BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE

 PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Adding or changing kernels
Each custom kernel needs a schema and one or more implementations to be registered with PyTorch.

Make sure custom ops are registered following PyTorch guidelines: Custom C++ and CUDA Operators and The Custom Operators Manual
Custom operations that return Tensors require meta-functions. Meta-functions should be implemented and registered in python so that dynamic dims can be handled automatically. See above documents for a description of meta-functions.
Use torch.libary.opcheck() to test the function registration and meta-function for any registered ops.  See tests/kernels for examples.
When changing the C++ signature of an existing op, the schema must be updated to reflect the changes.
If a new custom type is needed, see the following document: Custom Class Support in PT2.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

Thanks @robertgshaw2-neuralmagic! Actually @WoosukKwon and I were discussing something quite similar to this last week and I had started writing up a similar proposal ... I'd just been thinking some more about the best way to structure it to retain backwards compatibility with the various existing interfaces.
Here is what I propose:

We have the core step logic in an LLMEngine._step method which returns only token ids in a compact form
The LLMEngine.step method can wrap this and perform the detokenization and stop string evaluation inline, returning the same List[RequestOutput] for backwards compatibility in case folks are using this directly (though we would discourage it)
We rework the LLM class to actually start the LLMEngine in a separate process which runs a loop invoking the _step method, connected with zmq, basically the same thing as MQLLMEngine. In this case tokenization and detokenization are done on the client side.
We add a new AsyncLLM class which is the same thing just with an async interface. Again pretty much the same as MQLLMEngine except that we do the tokenization/detokenization on the client size, and the messages that we send internally are more compact (not RequestOutput objects).

So the main difference is that we don't have a dedicated process for detokenization, we just do it on the client side. The important thing is that we isolate the critical loop in its own process. And we don't have an explicit MQLLMEngine, this just becomes the standard behaviour when you use the LLM or AsyncLLM interfaces.
WDYT?

Thanks @robertgshaw2-neuralmagic! Actually @WoosukKwon and I were discussing something quite similar to this last week and I had started writing up a similar proposal ... I'd just been thinking some more about the best way to structure it to retain backwards compatibility with the various existing interfaces.
Here is what I propose:

We have the core step logic in an LLMEngine._step method which returns only token ids in a compact form
The LLMEngine.step method can wrap this and perform the detokenization and stop string evaluation inline, returning the same List[RequestOutput] for backwards compatibility in case folks are using this directly (though we would discourage it)
We rework the LLM class to actually start the LLMEngine in a separate process which runs a loop invoking the _step method, connected with zmq, basically the same thing as MQLLMEngine. In this case tokenization and detokenization are done on the client side.
We add a new AsyncLLM class which is the same thing just with an async interface. Again pretty much the same as MQLLMEngine except that we do the tokenization/detokenization on the client size, and the messages that we send internally are more compact (not RequestOutput objects).

So the main difference is that we don't have a dedicated process for detokenization, we just do it on the client side. The important thing is that we isolate the critical loop in its own process. And we don't have an explicit MQLLMEngine, this just becomes the standard behaviour when you use the LLM or AsyncLLM interfaces.
WDYT?

I agree with the direction you described

Closing in favor of #9741 9741


[CSM-465] Remove obsolete update info when querying nextUpdate

After investigation with Ilya it turned out that postponeUpdate endpoint introduced in previous PRs is working as intended, the problem is that it doesn't get called by frontend for some reason. But then we came up with a solution which doesn't depend on frontend, which is filtering info about already installed updates by comparison with current software version.
PR has a WIP flag because it should be tested locally before merge (to avoid similar problems as before).

@flyingleafe have you been able to test it ?


Stop using deprecated unittest asserts

failUnless and failIf have been deprecated since 2.7 and 3.1,
the docs call them aliases that exist for historical reasons.
In Python 3.7, the default DeprecationWarnings make things
very noisy, so flip these to assertTrue and assertFalse.
This is a trivial replace on unit-test files.
Signed-off-by: Mats Wichmann<EMAIL_ADDRESS>Contributor Checklist:

[X] I have created a new test or updated the unit tests to cover the new/changed functionality.
[X] I have updated master/src/CHANGES.txt directory (and read the README.txt in that directory)
[X] I have updated the appropriate documentation

Coverage remained the same at 79.964% when pulling 9864e8bf0a69f6aa35bb6af794da9988b1bbc50b on mwichmann:unittest-asserts into 6d86d2f92d83deb8f00c66858e93cc864bcfcc6a on SCons:master.


Unable to use Py<PyAny> as keys for hashbrown::HashMap.

Using Rust and pyo3 to implement cached_property with a setter method has really some nice properties because the reference of the cached value can be stored in Rust and not in Python, i.e. retrieval of the cached value need not be solely though the getter as it is how it is done in pure python.
Codes:
use hashbrown::HashMap;

use pyo3::{
    prelude::{PyObject as PreludePyObject, *},
    types::{PyAny, PyTuple, PyType},
    exceptions::PyValueError,
};

#[pyclass(name = "cached_property")]
#[derive(Clone, Debug, PartialEq, Eq, Hash)]
pub struct PropertyGetter {
    pv: HashMap<Py<PyAny>, Py<PyAny>>,
    fget: PreludePyObject,
}

use crate::withsetter::PropertySetterNoDeleter;

#[pymethods]
impl PropertyGetter {
    #[new]
    fn __new__(fget: &PyAny) -> PyResult<PropertyGetter> {
        Ok(PropertyGetter {
            pv: HashMap::default(),
            fget: fget.into(),
        })
    }

    fn __get__(
        &mut self,
        instance: &PyAny,
        _owner: Option<&PyType>,
    ) -> PyResult<&PreludePyObject> {
        let this_py = instance.py();
        // self.pv.contains_key()
    }
}

However, using Py<PyAny> as keys in a hashbrown::HashMap is not permitted because the traits Hash and Eq are not implemented.
Since I cannot implement foreign trait on foreign structs, is there anyway to circumvent this?
Thank you.

I want to hash based on identity. Lol your first method actually makes more sense; I didn't see your reply and went on to implement Eq, PartialEq and Hash using .as_ptr() on a wrapper struct and without casting as_ptr() to usize. I shall change it then. Thank you for your help!


Failed to change to virtual environment kernel with [Python conda envs: xxx] prefix

When I want to change the kernel into a virtual environment through the panel and choose the prefix Python: [conda envs:xxx] one, it just can't work and print the following error message.

'"C:\Users\Z�-LE~1\AppData\Local\TEMP_~1\tmp6dbccs_p.bat"' is not recognized as an internal or external command,
operable program or batch file.
Could Not Find C:\Users\Z�-LE~1\AppData\Local\TEMP_~1\tmp6dbccs_p.bat
Traceback (most recent call last):
  File "E:\Anaconda3\lib\runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "E:\Anaconda3\lib\runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "E:\Anaconda3\lib\site-packages\nb_conda_kernels\runner.py", line 72, in <module>
    exec_in_env(*(sys.argv[1:]))
  File "E:\Anaconda3\lib\site-packages\nb_conda_kernels\runner.py", line 40, in exec_in_env
    env = check_output(ecomm, shell=is_win).decode(encoding)
UnicodeDecodeError: 'gbk' codec can't decode byte 0x9c in position 77: illegal multibyte sequence
[I 14:09:09.917 NotebookApp] KernelRestarter: restarting kernel (1/5), keep random ports
The system cannot find the path specified.
'"C:\Users\Z�-LE~1\AppData\Local\TEMP_~1\tmpbpt0puxm.bat"' is not recognized as an internal or external command,
operable program or batch file.
Could Not Find C:\Users\Z�-LE~1\AppData\Local\TEMP_~1\tmpbpt0puxm.bat
Traceback (most recent call last):
  File "E:\Anaconda3\lib\runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "E:\Anaconda3\lib\runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "E:\Anaconda3\lib\site-packages\nb_conda_kernels\runner.py", line 72, in <module>
    exec_in_env(*(sys.argv[1:]))
  File "E:\Anaconda3\lib\site-packages\nb_conda_kernels\runner.py", line 40, in exec_in_env
    env = check_output(ecomm, shell=is_win).decode(encoding)
UnicodeDecodeError: 'gbk' codec can't decode byte 0x9c in position 77: illegal multibyte sequence
[I 14:09:12.946 NotebookApp] KernelRestarter: restarting kernel (2/5), keep random ports
The system cannot find the path specified.
'"C:\Users\Z�-LE~1\AppData\Local\TEMP_~1\tmpxrqt2bbb.bat"' is not recognized as an internal or external command,
operable program or batch file.
Could Not Find C:\Users\Z�-LE~1\AppData\Local\TEMP_~1\tmpxrqt2bbb.bat
Traceback (most recent call last):
  File "E:\Anaconda3\lib\runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "E:\Anaconda3\lib\runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "E:\Anaconda3\lib\site-packages\nb_conda_kernels\runner.py", line 72, in <module>
    exec_in_env(*(sys.argv[1:]))
  File "E:\Anaconda3\lib\site-packages\nb_conda_kernels\runner.py", line 40, in exec_in_env
    env = check_output(ecomm, shell=is_win).decode(encoding)
UnicodeDecodeError: 'gbk' codec can't decode byte 0x9c in position 77: illegal multibyte sequence
[I 14:09:15.976 NotebookApp] KernelRestarter: restarting kernel (3/5), keep random ports
The system cannot find the path specified.
'"C:\Users\Z�-LE~1\AppData\Local\TEMP_~1\tmpkxkxs0gz.bat"' is not recognized as an internal or external command,
operable program or batch file.
Could Not Find C:\Users\Z�-LE~1\AppData\Local\TEMP_~1\tmpkxkxs0gz.bat
Traceback (most recent call last):
  File "E:\Anaconda3\lib\runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "E:\Anaconda3\lib\runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "E:\Anaconda3\lib\site-packages\nb_conda_kernels\runner.py", line 72, in <module>
    exec_in_env(*(sys.argv[1:]))
  File "E:\Anaconda3\lib\site-packages\nb_conda_kernels\runner.py", line 40, in exec_in_env
    env = check_output(ecomm, shell=is_win).decode(encoding)
UnicodeDecodeError: 'gbk' codec can't decode byte 0x9c in position 77: illegal multibyte sequence
But when I choose the not Python: [conda envs:xxx] prefix that points out to the same environment which I rename, it can find the kernel. The two red blocks point to the same virtual environment py36.

Desktop (please complete the following information):

OS: windows 10
Browser: Edge

I'm sorry we didn't get to this way back when. I'm closing this as stale but if you can offer a modern reproduction (new versions of conda, jupyter, nb_conda_kernels, etc.) please feel free to re-open or create a new issue