Impossible to use GO:0033643 (host cell part) and its descendants with taxo Opisthokonta, Why ?

Hi
I received the following warning for a previous annotation:
GO:0033643 never_in_taxon Opisthokonta            protein K7N5L0
GO:0033643 (host cell part) and its descendants should NEVER be used with gene products from the taxonomic group Opisthokonta.
I don't understand why a fungal protein cannot target another organism. In any case, that's what I meant, since this protein targets bacterial membrane.
Please, could you clarify this new constrain (only recently added) ?

@FJungo What protein are you trying to annotate ? (which species interacts with which species?)

https://www.uniprot.org/uniprot/K7N5L0
would seem ok?
Probably this
https://github.com/geneontology/go-ontology/issues/19715
can only be never in vertebrates.
We will need to deal with fungal problems on a case-by-case basis and be mindful of annotation transfer and automated mappings.
v

Changed taxon constraint to 'never in Vertebrata '
Thanks, Pascale

PR: https://github.com/geneontology/go-ontology/pull/19748

Hi
I also do not understand the logic of this. eg GO:0020003 symbiont-containing vacuole and other terms under  GO:0018995 host cellular component are likely to include gene products contributed by the host cell. Why is the host taxon not allowed to be included?
in reference to the comments above, it is also not clear to me why the fungal peptide https://www.uniprot.org/uniprot/K7N5L0 is thought to be a unique anti-pathogen approach, I would have thought that humans also have gene products that inhibit pathogens through direct targeting of the pathogen membrane
Thanks
Ruth

@RLovering Would you remove all taxon constraints on GO:0018995 host cellular component  ?

Actually @RLovering
The children of 'GO:0033643 host cell part' are meant to annotate symbiont gene products.
For example we say 'viral protein X located_in host nucleus'.
The host proteins are annotated to 'nucleus'.
So, in the example you give, there should be an equivalent host term for the symbiont-containing vacuole. This is the whole point of that structure (otherwise we can get rid of 'host nucleus' and annotate symbiotic gene products to 'nucleus'.
That being said, perhaps all terms should have 'host' in the label to avoid confusion. Would that help ?
Thanks, Pascale

GO:0020003 symbiont-containing vacuole and other terms under GO:0018995 host cellular component are likely to include gene products contributed by the host cell. Why is the host taxon not allowed to be included?

These terms are to represent protein symbiont localization in the host.
This isn't a 'real' vacuole. See comment
Comments
Note that this term does not have a relationship to 'vacuole ; GO:0005773' because it does not fit the definition of a vacuole; the parasitophorous vacuole was so named because it resembles a vacuole in the microscope.
Some host-genes do target pathogen cell surface proteins, all of the examples I've annotated are after the pathogen has invaded, and occur in the host cytoplasm.
In cases cell-surface host -cell surface pathogen contact (pathogen recognition- first lines of defense ),  I  wouldn't annotate the host protein to the pathogen membrane or cell surface. I would annotate to the  "cell surface" (i.e self cell surface for the host) and capture the interaction with a pathogen cell-surface protein. The host protein is still part of the host-cell surface.
I'm not aware of host proteins which target the pathogen membrane per se (i.e secreted proteins) -most defences appear to be immune defenses and mitigation and occur within the host @dsiegele @mgiglio99  can you think of any secreted host defense proteins ?  If they exist, I think I would still annotate as extracellular, rather than to a specific pathogen component.
From what I remember of the history, these terms were treated specifically to allow the  differentiation of symbiont protein annotated to host structures. If this is not the case, than a separate branch would not be necessary.
If we were to annotate host proteins in symbiont structures  we would need a dedicated branch  to represent "host protein localization symbiont cell" , but as I say, I don't have any examples of this.
note that the definition of Definition
GO:0018995    host cellular component
is
Any organism in which another organism, especially a parasite or symbiont, spends part or all of its life cycle and from which it obtains nourishment and/or protection.
This term and its descendants should absolutely be restricted to symbiont gene products.
Although the definition is a bit whacky.  It should be "any cellular component " not "any organism".  We are annotating gene products not 'organisms'
Maybe also the key point "a parasite or symbiont, spends part or all of its life cycle " should be iterated in the descendants?

was this to close?

I think this can be closed, yes


Fix sorter arrow

Fixed bug causing sorter arrow to point upwards no matter if items are in ascending or descending order.

Codecov Report

Merging #1278 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1278   +/-   ##
=======================================
  Coverage   70.24%   70.24%
=======================================
  Files         117      117
  Lines        6094     6094
  Branches      776      776
=======================================
  Hits         4281     4281
  Misses       1655     1655
  Partials      158      158

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 373a6cd...43326d2. Read the comment docs.


recognize infinity and nan correctly

fixes #11

Codecov Report

Merging #12 (dc6e16f) into master (7063bc6) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
+ Coverage   99.58%   99.60%   +0.01%
==========================================
  Files           1        1
  Lines         486      501      +15
==========================================
+ Hits          484      499      +15
  Misses          2        2

Impacted Files
Coverage Δ

src/Scanf.jl
99.60% <100.00%> (+0.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7063bc6...dc6e16f. Read the comment docs.


Password isn't rendered in the view

In my application's Change Password view, I request the user to enter the current and the new password. If something isn't correct, an error message is displayed for the appropriate input field. So if the current password is correct but the new password isn't allowed or something, the following happens:

The current password has no error, but after submitting the form and returning back to it, it's empty
The new password has an error message and is now empty, too

The issue is that the validation only represents what the user has provided, but doesn't consider what MVC has changed. It doesn't output passwords into their corresponding text fields at all, thereby producing more errors than indicated.
I've found some clues that this is supposed to be a "security measure" to prevent me from accidently leaking plain passwords to the UI where they could be recovered. This cannot possibly happen to me because I never store plain passwords in the system. And I also take great care to not make such mistakes.
So, after I have acknowledged this warning, can you please put me back into control and let me disable that behaviour so that any form input behaves just like I'd expect it to do?

@javiercn, is there any way to force MVC to maintain the filled in values in the credential fields? /cc @blowdart

I do believe this is by design. This is the behavior MVC has had for password input fields for a long time. @blowdart can provide details about the specific reasons why this is done.
This is also the same behavior most sites have when dealing with users credentials.
You can change that view to have whatever logic you want and write the form inputs yourself using @Html.ValueFor())

Is there any more information about it that this stub?

@dougbu Can you provide more details about this?

an error message is displayed for the appropriate input field.

If you have client-side validation enabled, the error is correct: The password hasn't been entered or reentered.

This cannot possibly happen to me because I never store plain passwords in the system.

Whether or not passwords are secure within your system is not the issue here. Round-tripping a password back to the browser would expose it on the page. The basic idea is to shorten the period in which someone else could view the page source and to minimize the requests and responses containing the (plain text) password.

@Html.ValueFor()

Not much to say about this guy. It does what you'd expect, including round-tripping an invalid submitted value. The suggestion is to use it as the attribute value e.g.
<input asp-for="PasswordProperty" value="@Html.ValueFor(m => m.PasswordProperty)"/>

Again, this is strongly not recommended.

As everyone said this is very much by design, it's not going to change, otherwise you can end up round tripping passwords into a page, and that, in the case of an XSS exploit is very bad news.

Well, if you have malicious scripts running on your page, even entering a password is bad. My current situation is a Change Password form and if the new password is rejected by the server (for example because it's too simple – a decision hard to implement client-side and hard to know for the user), then at least the correct current password should remain intact. Either way, I understand your repeated concerns, and I have found a solution to handle this framework deficiency.


types_spaces removes spaces around multi-catch exceptions

Bug report

PHP version: 8.0.12
PHP CS Fixer version:3.2.1

When types_spaces is set to ['space' => 'none'] PHP CS Fixer incorrectly removes the spaces around multi-catch exceptions.
Code snippet that reproduces the problem
<?php

try {
  do_something();
} catch (InvalidArgumentException | RuntimeException $multiCatch) {
  // do nothing
}

      ---------- begin diff ----------
--- /var/www/app/test.php
+++ /var/www/app/test.php
@@ -2,6 +2,6 @@

 try {
     do_something();
-} catch (InvalidArgumentException | RuntimeException $multiCatch) {
+} catch (InvalidArgumentException|RuntimeException $multiCatch) {
     // do nothing
 }

      ----------- end diff -----------

IIUC for PSR12 we would need some kind of configuration to make sure there is a single space around the | for multiple exception types in the catch statement


⚠ Bofrost.lu has degraded performance

In a72d9c4, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1255 ms

Resolved: Bofrost.lu performance has improved in 568c9eb after 6 minutes.


Linux Errors

Hello there,
Thanks for the effort on what seems to be a very useful and welcomed tool
Would like to get this working if possible on linux.
Best regards!
On initial use i get this error message on the sop node:

Error
Invalid source /obj/geo1/EarthMesh1/FindAltitudeError: Python error: Traceback (most recent call last):File "/opt/hfs19.5.716/python/lib/python3.9/urllib/request.py", line 1346, in do_openh.request(req.get_method(), req.selector, req.data, headers,File "/opt/hfs19.5.716/python/lib/python3.9/http/client.py", line 1285, in requestself._send_request(method, url, body, headers, encode_chunked)File "/opt/hfs19.5.716/python/lib/python3.9/http/client.py", line 1331, in _send_requestself.endheaders(body, encode_chunked=encode_chunked)File "/opt/hfs19.5.716/python/lib/python3.9/http/client.py", line 1280, in endheadersself._send_output(message_body, encode_chunked=encode_chunked)File "/opt/hfs19.5.716/python/lib/python3.9/http/client.py", line 1040, in _send_outputself.send(msg)File "/opt/hfs19.5.716/python/lib/python3.9/http/client.py", line 980, in sendself.connect()File "/opt/hfs19.5.716/python/lib/python3.9/http/client.py", line 1454, in connectself.sock = self._context.wrap_socket(self.sock,File "/opt/hfs19.5.716/python/lib/python3.9/ssl.py", line 500, in wrap_socketreturn self.sslsocket_class._create(File "/opt/hfs19.5.716/python/lib/python3.9/ssl.py", line 1040, in _createself.do_handshake()File "/opt/hfs19.5.716/python/lib/python3.9/ssl.py", line 1309, in do_handshakeself._sslobj.do_handshake()ssl.SSLCertVerificationError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1129)During handling of the above exception, another exception occurred:Traceback (most recent call last):File "", line 42, in File "", line 16, in get_elevationFile "", line 5, in bytes_from_urlFile "/opt/hfs19.5.716/python/lib/python3.9/urllib/request.py", line 214, in urlopenreturn opener.open(url, data, timeout)File "/opt/hfs19.5.716/python/lib/python3.9/urllib/request.py", line 517, in openresponse = self._open(req, data)File "/opt/hfs19.5.716/python/lib/python3.9/urllib/request.py", line 534, in _openresult = self._call_chain(self.handle_open, protocol, protocol +File "/opt/hfs19.5.716/python/lib/python3.9/urllib/request.py", line 494, in _call_chainresult = func(*args)File "/opt/hfs19.5.716/python/lib/python3.9/urllib/request.py", line 1389, in https_openreturn self.do_open(http.client.HTTPSConnection, req,File "/opt/hfs19.5.716/python/lib/python3.9/urllib/request.py", line 1349, in do_openraise URLError(err)urllib.error.URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1129)>.

Error
Invalid source [/obj/geo1/EarthMesh1/FindAltitude](node:/obj/geo1/EarthMesh1/FindAltitude)
Error: Python error: Traceback (most recent call last):
File "/opt/hfs19.5.716/python/lib/python3.9/urllib/request.py", line 1346, in do_open
h.request(req.get_method(), req.selector, req.data, headers,
File "/opt/hfs19.5.716/python/lib/python3.9/http/client.py", line 1285, in request
self._send_request(method, url, body, headers, encode_chunked)
File "/opt/hfs19.5.716/python/lib/python3.9/http/client.py", line 1331, in _send_request
self.endheaders(body, encode_chunked=encode_chunked)
File "/opt/hfs19.5.716/python/lib/python3.9/http/client.py", line 1280, in endheaders
self._send_output(message_body, encode_chunked=encode_chunked)
File "/opt/hfs19.5.716/python/lib/python3.9/http/client.py", line 1040, in _send_output
self.send(msg)
File "/opt/hfs19.5.716/python/lib/python3.9/http/client.py", line 980, in send
self.connect()
File "/opt/hfs19.5.716/python/lib/python3.9/http/client.py", line 1454, in connect
self.sock = self._context.wrap_socket(self.sock,
File "/opt/hfs19.5.716/python/lib/python3.9/ssl.py", line 500, in wrap_socket
return self.sslsocket_class._create(
File "/opt/hfs19.5.716/python/lib/python3.9/ssl.py", line 1040, in _create
self.do_handshake()
File "/opt/hfs19.5.716/python/lib/python3.9/ssl.py", line 1309, in do_handshake
self._sslobj.do_handshake()
ssl.SSLCertVerificationError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1129)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "", line 42, in
File "", line 16, in get_elevation
File "", line 5, in bytes_from_url
File "/opt/hfs19.5.716/python/lib/python3.9/urllib/request.py", line 214, in urlopen
return opener.open(url, data, timeout)
File "/opt/hfs19.5.716/python/lib/python3.9/urllib/request.py", line 517, in open
response = self._open(req, data)
File "/opt/hfs19.5.716/python/lib/python3.9/urllib/request.py", line 534, in _open
result = self._call_chain(self.handle_open, protocol, protocol +
File "/opt/hfs19.5.716/python/lib/python3.9/urllib/request.py", line 494, in _call_chain
result = func(*args)
File "/opt/hfs19.5.716/python/lib/python3.9/urllib/request.py", line 1389, in https_open
return self.do_open(http.client.HTTPSConnection, req,
File "/opt/hfs19.5.716/python/lib/python3.9/urllib/request.py", line 1349, in do_open
raise URLError(err)
urllib.error.URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1129)>
.

I am nor a Linux expert nor a web request expert. But I am doing https request in python and Linux (your Linux?) don't seems to like it. I will ask some friends they might have an idea.

import ssl ssl._create_default_https_context = ssl._create_unverified_context

Update the server certificate or apply the solution of @gitmike24
If the certificate is OK when navigating the URL with a classic browser (Chrome, Firefox), then you're maybe facing the bug of the root certificate of letsencrypt (late 2021) from older linux distribution that is not updated.
Solutions almost everywhere on the internet depending of the linux distribution you're using.


change to trigger the change event for select tag

Hi! Nice work. I think there's one problem in that the event is fired on the dropdownSelector, IE all dropdowns on the page, and not just the one currently being changed.
To fix this, I think it's am matter of replacing dropdownSelector with dropdown.


add isValidCodeownersGlob function

Adds a function to validate codeowners glob patterns according to the CODEOWNERS syntax and gitignore syntax it extends.
It also removed is-valid-glob since it apparently pretty much checks if it's a non-empty string:
  if (typeof glob === 'string' && glob.length > 0) {
    return true;
  }

See https://github.com/gagoar/codeowners-generator/pull/161#issuecomment-763196641 and https://github.com/gagoar/codeowners-generator/issues/160#issuecomment-764433649 for additional context for the PR.

Pull Request Test Coverage Report for Build 501911193

17 of 17 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 499955588:
0.0%

Covered Lines:
211

Relevant Lines:
211

💛  - Coveralls

Pull Request Test Coverage Report for Build 501911193

17 of 17 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 499955588:
0.0%

Covered Lines:
211

Relevant Lines:
211

💛  - Coveralls

thanks  @gustavkj !

thanks  @gustavkj !


What Information is needed for the attack

How would you reccomend to get the target's information, also what information do I need to successfully complete an attack, with the phone owners consent.

no attacks here, just testing (;


Split scopes

Currently all vars in a scope are created in one block. e.g.:
// Input
const x = 1, y = 2;
export default [
  () => x,
  () => y
];

// Output
export default ( (x, y) => [ () => x, () => y ] )(1, 2);

x and y are not shared between any functions so could be split into separate blocks:
// Output
export default [
  (x => () => x)(1),
  (y => () => y)(2)
];

The latter is 2 chars longer, but would be more code-splittable.
In cases where scope vars are constants, even a shared variable could be split into 2 blocks:
// Input
const x = 1;
export default [
  () => x,
  () => x + 1
];

// Output
export default [
  (x => () => x)(1),
  (x => () => x + 1)(1)
];

Where functions which appear in different entry points reference the same scope value, the functions can still be split into separate files by substituting an "value holder" object for the scope var which is shared between the two.
Input:
let count = 100;
export const get = () => count;
export const increment = () => count++;

If get and increment are different entry points, output would be:
// get.js
import countHolder from './common.XXX.js';
export default () => countHolder.count;

// increment.js
import countHolder from './common.XXX.js';
export default () => countHolder.count++;

// common.XXX.js
export default {count: 100};

Where 2 function share the same block var, but in different scopes, they can be treated as referencing completely separate vars.
Input:
const [fns1, fns2] = [100, 200].map(n => [
  () => n,
  () => n * 2
]);
export default {
  get100: fns1[0],
  double200: fns2[1]
};

Output:
export default {
  get100: (n => () => n)(100),
  double200: (n => () => n * 2)(200)
};


Pin Mapping Issue

Great project. I implemented it in my own home over the weekend. I was having issues, and I think they were coming from the GPIO pins to the relays.  They are mislabeled in the jpg diagram, but I think they are correct in the code.

Thanks for letting me know. The image was correct, but I labeled them incorrectly. I've updated the picture with the correct labels. Thanks again!


Start using System.Text.Encoding.Web from CLR

This is now available on the internal share that we use, so this is unblocked.

@Tratcher

@Eilon @muratg 4.0.0-beta-23326 is not compatible with .NET 4.5.1, it requires 4.6. It depends on System.Runtime 4.0.20, where we need 4.0.10 for 4.5.1.

@ericstj ?

It's compiling against quite a few contracts that are only supported in .NET 4.6.
I gave a try at moving it to contract versions that would support .NET 4.5.1 and it is not possible because the implementation depends on Buffer.MemoryCopy which was added in .NET 4.6. This appears to be the only dependency that is preventing portability to even to .NET 4.5.  @KrzysztofCwalina

@ericstj thanks, @KrzysztofCwalina Should we file a bug on your side to track this?  Otherwise we'll need to maintain our implementation at least for Desktop CLR.

I will fix this tomorrow. No need to file a new bug.

@KrzysztofCwalina Sounds good, thanks!

Ifdefs will set you free

@ericstj, most of our projects in corefx depend on System.Runtime 4.0.20.

That's because most of these don't intend to run downlevel.  There are a few that have downlevel scenarios (like Immutable & Reflection.Metadata) and intentionally restrict their dependencies to versions that will work on those downlevel platforms.

@ericstj, almost all (if not all) components in corefx depend on 4.0.20. And it seems like ASP.NET needs to and is successfully using them on 4.5.1 (i.e. downlevel)

Right, all of DNX, ASP.NET, and EF (with maybe some very small exceptions, where it's usually runtime light-up) need to run on .NET 4.5.1.

@muratg, where you able to successfully pick up the updated package?

@KrzysztofCwalina Not yet. @Tratcher will be picking it up in the dev branch for RC1 and close this bug.

@KrzysztofCwalina Which build should it be in? 4.0.0-beta-23405 still depends on 4.0.20.

This version has the updates: https://www.myget.org/F/dotnet-core/api/v2/package/System.Text.Encodings.Web/4.0.0-beta-23406

Hey @ericstj, I've got a PR for the swap, but we've found that the new types are much harder to mock out in tests because Encode isn't virtual. Here's an attempt at mocking (https://github.com/aspnet/HttpAbstractions/commit/90c13adc5d90108a4826af3b5149a3e923b79436#diff-387f3dc26a94ebcb7c37dd754bab84c5), but it only gets one character at a time so the best mock encoding I can manage is encoding "value" to "_v_a_l_u_e". We used to return "HtmlEncode[[value]]" (https://github.com/aspnet/HttpAbstractions/commit/90c13adc5d90108a4826af3b5149a3e923b79436#diff-5093aee64e24c262ac1165902a6ceef9L89).
This may require us to keep using our interfaces and wrapper classes and only delegate the implementation.
/cc: @muratg @Eilon @davidfowl

Seems like that would be throwing baby with the bathwater. Can you use the mocks that add the underscore for now and I will make the Encode method virtual (next week)?

Not really, it breaks too many tests to update in the short term. I could make my first check in still using the interfaces and postpone removing them until next week. @muratg? There are plenty of changes that we'll need to make upstream regardless (method names, parameter order, etc.).

That sounds good, I think, i.e. the tests would need to keep the old interfaces, not the library, correct?

The libraries will still need to use the interfaces or else the tests won't be able to mock out the encoders used in the libraries.

I see. I just submitted a fix to corefx. If everything goes well, you should have a new drop tomorrow.


[GOBBLIN-1898] Improve performance of ORCWriter Self Tune

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[ ] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-1898

Description

[ ] Here are some details about my PR, including screenshots (if applicable):

The ORCWriter's new self tuning feature leads to slower write frequency when it comes to ingesting datasets with a low volume of records.
This is primarily caused by the assumption that the native ORC writer will be saturated, which leads to the memory footprint of STRIPE_SIZE + avgSizeOfRecord*rowsBetweenMemoryCheck.
However, this is generally not the case when there are only a few records to write due to a low volume dataset, and causes slow writes. We should utilize a newer API on ORCWriter brought in by https://github.com/apache/orc/pull/1057
Some other improvements so that memory consumption by the writer is fluctuates less:

Persist more state in between writers so that writers will start at a more reasonable base point based off the past
When increasing batchSize, raise it by a percentage of the error (proportional control) so that batchsize leads to less overshoot in memory usage
Reveal more configuration knobs to manually tune the limits of the self tuning writer

Bumps ORC Version from 1.6.8 to 1.7.4
Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:
Unit tests

Commits

[ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #3762 (d8fc64d) into master (673773a) will decrease coverage by 1.44%.
Report is 4 commits behind head on master.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3762      +/-   ##
============================================
- Coverage     47.13%   45.69%   -1.44%
+ Complexity    10893     2159    -8734
============================================
  Files          2148      413    -1735
  Lines         85039    17965   -67074
  Branches       9438     2187    -7251
============================================
- Hits          40082     8209   -31873
+ Misses        41315     8883   -32432
+ Partials       3642      873    -2769

see 1741 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Warn for untrusted sources?

It might be possible for a project using Foreman to replace a commonly used tool like Rojo with a binary from a different source that could be malicious.
Do we think it's a concern that running rojo in a freshly-cloned directory could execute arbitrary code?
One possible guard would be needing to 'trust' any new source that tools are downloaded from. The first time a user tries to run a tool from rojo-rbx/rojo, Foreman would ask if it's okay.
On CI machines, we could add a flag like --always-trust-sources that lets us bypass this prompt.

when making this feature how will we know if we can trust the source or not? Like a list of trusted sources(something like Rojo, remodel, or something else)?


Cannot sort by new or hot on 0.2 (4)

Immediate crash when trying to sort by new or hot.
Rising and controversial and top allow the time submenu to pop up, but still crash when selecting any one of them.
Hope these small bugs are easy to fix. Thanks for all your work.

Fixed


internVL 2.5 技术报告中提到的Loss Reweighting策略什么时候合入代码

Motivation
To enhance the model’s adaptability to real-world scenarios and overall performance, two key techniques are
introduced. These optimizations are essential in improving the user experience and the model’s benchmark
performance.
Random JPEG Compression.
Loss Reweighting.
Related resources
No response
Additional context
No response

Checking #746  for my implemented version of  loss function

您好，这个策略已经在代码里了，见这里：
https://github.com/OpenGVLab/InternVL/blob/main/internvl_chat/internvl/train/internvl_chat_pretrain.py#L830

好的，感谢~


Nightly builds failing for several months

What happened:
Dear authors (cc'ing @mgrover1 and @brian-rose as you have the two largest contributions), the nightly builds of this cookbook have been failing for the last several months.
Could you please have a look at it?
Minimal Complete Verifiable Example:
Latest nightly build as of the creation of this issue.
Anything else we need to know?:
If you think it is due to Pythia infrastructure or something else other than the cookbook itself, please let us know.

It's failing upon trying to
import pyart

I was able to reproduce this behavior locally in a freshly created environment. I assume it's because of some package version inconsistencies in the environment. That's as far as I've dug so far.

I also got the same failure in a "plain pyart" environment by doing this:
mamba create --name pyart-test arm_pyart -c conda-forge
conda activate pyart-test
python -c "import pyart"

The import error is coming from xradar (a dependency of pyart), and is related to the recent merging of DataTree into Xarray.
The solved environment has the latest xarray 2024.10.0 and xradar 0.6.5 which are incompatible. Something is going wrong with the conda environment description for pyart. That's probably a solvable problem. But it might be moot.
I see that the xradar folks are close to releasing a version compatible with the latest xarray (https://github.com/openradar/xradar/issues/223) so I think it the best choice for now is to do nothing and allow upstream to catch up.
@mgrover1

Yes - there are some compatibility issues we are currently sorting through. We are working on resolving this ASAP, thank you for raising this to our attention

If you are in need of testing: Please pin xradar to 0.7.0 (it will have a pin for xarray <= 2024.9.0.
When xradar is capable of supporting xarray >= 2024.10.0 we'll release xradar 0.8.0 (which should be out next week, Nov 4th/5th latest).

@clyne Could you point me to some resources of that meeting? Interested in the particular issues there. Thanks!

Quick update here, xradar 0.8.0 is now released with compatibility with the latest xarray and datatree. We are still failing on import pyart for now. Looks like there's some progress on pyart compatibility here: https://github.com/ARM-DOE/pyart/pull/1681

@brian-rose Pinning xradar to 0.7.0 and xarray to <=2024.9.0 should get you going until the party issues are sorted out.

@kmuehlbauer @brian-rose - I am looking at this today and will be cutting a new release of Py-ART that should solve this problem! Thank you for raising the issue and your patience here.

@mgrover1, looks like the latest nightly build from yesterday still failed but the build issues now seems to be due to a FileNotFound error if you'd like to have a look into it.

After a bit of debugging and the merging of #139 , looks like things are building again 👍


Backend package missing parameters

Package + Version

[ ] @clerk/clerk-js
[ ] @clerk/clerk-react
[ ] @clerk/nextjs
[ ] @clerk/remix
[ ] @clerk/types
[ ] @clerk/themes
[ ] @clerk/localizations
[ ] @clerk/clerk-expo
[x] @clerk/backend
[ ] @clerk/clerk-sdk-node
[ ] @clerk/shared
[ ] @clerk/fastify
[ ] @clerk/chrome-extension
[ ] gatsby-plugin-clerk
[ ] build/tooling/chore
[ ] other:

Dependencies + versions
Provide a json with the dependencies used in your project (copy paste from yarn.lock / package-lock.json) or a github project / template that reproduces the issue.
Include the @clerk/ packages and their versions!*
Example:
"@clerk/clerk-sdk-node": "^4.8.1",
"@clerk/remix": "^2.5.0",

Description
The Backend API docs have quite a lot of parameters, for example "Get a list of organizations for an instance":

However, if you use the Client Backend node package, only a few of these parameters are available:
client.organizations.getOrganizationList(...);

On this API, only limit and offset are available:
type GetOrganizationListParams = {
    limit?: number;
    offset?: number;
};

The same is true for updating an organisation, slug is in the docs but not in the types.

I can still set the params and they do work - just using @ts-expect-error for now

Hello @Ehesp :) . Thank you for reporting this issue. Since you have made all that work (the investigation) and found the root cause, would you be interested in opening a PR to resolve this issue? Otherwise i will try to open a PR by the end of the day.

Also @Ehesp why do you import "@clerk/clerk-sdk-node": "^4.8.1", package ?

@dimkl I can do this (and was going to), however before doing that is there any open spec which these types could potentially be generated with? Seems like this is going to be reoccurring problem if it's manual?
Happy to do this anyway.

Also @Ehesp why do you import "@clerk/clerk-sdk-node": "^4.8.1", package ?

Ah ignore this, it was my bad.


Website footer

There currently isn't one. The most basic one might include a copyright notice, a privacy policy, and terms of use. Thoughts?

what should go in this? we need to discuss with the USDA side.


feat: Relax GrpcMethod lifetime

Resolves #1547.

Why is this still open?

Seems reasonable. I guess adding a lifetime parameter is a semver-incompatible change, though...

This change makes sense, we need to bundle it with other breaking changes though.


About pytorch encoding and the training speed

Hi,
Thank you for your great work! I am trying to do some distillation work on the small mobile net. I have some questions:
The code need the package pytorch encoding, but the pytorch encoding requires the pytorch to be 0.5.0. Your code is about pytorch 0.3.0+. I wonder how do you install the package of pytorch encoding?
However, the code can run under pytorch 0.5.0, but the training speed is very slow. I used a single P100 to have a try, and it need nearly 7 minutes to finish one epoch. If we need to train 10000 epochs, it will take nearly 48 days.
Is this because the different pytorch version?
Thanks,
Yifan

Hello~ It is me again~ I still want to ask what version of pytorch  you use. Because before pytorch 0.4.0, the upsample operator is default to set the align corner=True. And with 0.4 and 0.5, align corner=False. I train from the pretrain model of mobile
cityscapes_mobilenetv2_best_model.pkl , I set the align cornet= False. But I can only get 68% of mean IOU on the validation set.
Can you kindly share the details for this setting ?Or some other settings need to be notice during training?
Thank you very much!

Hello~ It is me again~ I still want to ask what version of pytorch you use. Because before pytorch 0.4.0, the upsample operator is default to set the align corner=True. And with 0.4 and 0.5, align corner=False. I train from the pretrain model of mobile
cityscapes_mobilenetv2_best_model.pkl , I set the align cornet= False. But I can only get 68% of mean IOU on the validation set.
Can you kindly share the details for this setting ?Or some other settings need to be notice during training?
Thank you very much!

hi, i try run this code, but not success, can you share version of depend?  Thank you very much!

Hi, I just installed, so I wanted to share. You can use pytorch 0.3 with encoding v0.1.0. It works fine (at least for testing).


Error banner no longer appearing

It seems that the red banner that used to drop down from the top when the server returned an error (400, 404, 500, etc.) is no longer appearing. I believe this first started happening when I upgraded my build files from v0.2.15 to v0.2.18. I have pulled the most recent commit to master (4faeb7d at the time of writing) and have tried those build files, but the problem is still persisting.

I can concur with this we have the following code capturing business message error on deletion and after clicking the "confirm delete button" we do not have the message popping up anymore, even though the server is returning 400 with the expected payload
	editorialChannel.errorMessage(function (response) {
		if ((response.data.technicalMessage !== null) && (response.data.technicalMessage.length > 0)) {
			return 'Global error: ' + response.status + ' (' + response.data.technicalMessage + ')';
		}
		else {
			return 'Global error: ' + response.status + ' (' + response.data.businessMessage + ')';
		}
	});

May be related to #1036

Fixed by https://github.com/marmelab/ng-admin/pull/1197
@jpetitcolas maybe you can close this issue? :)

@cfatt10: can you recheck and close the issue if #1197 fixed it? :)

@jpetitcolas The error banners are now showing up again, but I have not been paying close enough attention to tell if it was specifically #1197 that fixed it.

Thanks for the feedback!


Webpack 4 made its own loaders work weird

Do you want to request a feature or report a bug?
Bug.
What is the current behavior?
See below.
If the current behavior is a bug, please provide the steps to reproduce.
See below.
What is the expected behavior?
See below.
If this is a feature request, what is motivation or use case for changing the behavior?
No.
Please mention other relevant information such as the browser version, Node.js version, webpack version, and Operating System.
Win 10, Node: v8.9.4, npm: 5.6.0, Webpack: 4.1.1
Issue Description:
After I updated from webpack 3.8.1 to version 4.1.1 my raw-loader started to return an object instead of a string.
Before the update in my AngularJS application I could simply do this:
...
template: require('./my-template')
...

and everything worked fine. But now I forced to do like this:
...
template: require('./my-template').default
...

because otherwise variable template will be equal an object:
{
  default: '<tempate data>'
}

instead of a string:
'<tempate data>'

So what is this cr*p and how to return everything at how it was in webpack 3?

It looks like you just deleted our lovely crafted issue template. It was there for good reasons. Please help us solving your issue by answering the questions asked in this template.

@montogeek Done.

Which version of the raw-loader are you currently using ?  >= v0.5.1 (@latest)  exports a CJS Module, while >=1.0.0-beta-0 (@beta) exports an ES Module. The latter causes to use .default in conjunction with require()
require('cjs')
require('esm').default

@michael-ciniawsky I already know that, captain Obvious. It's still not resolves the problem.


Auto-generate exports at build time

What is the feature you are proposing?
I recently encountered and fixed an issue related to some types not being included in the package.json exports: https://github.com/honojs/hono/pull/1610
Just after that was merged I noticed a very similar issue:

This can be easily fixed by adding to hono/package.json:
"./client/types": {
  "types": "./dist/types/client/types.d.ts",
  "import": "./dist/client/types.js",
  "require": "./dist/cjs/client/types.js"
},
"./context": {
  "types": "./dist/types/context.d.ts",
  "import": "./dist/context.js",
  "require": "./dist/cjs/context.js"
},

However I think a more cohesive solution is in order, and would suggest that every .d.ts file in Hono be included in the package.json exports to avoid this category of tooling issues. To reduce the maintenance burden here, I suggest auto-generating the exports and updating package.json at build time (modification to build.ts required).
Is my suggestion wanted? If so, I'd be happy to create a PR.

Hi sorry, I have to retract my offer to create the PR myself. After encountering https://github.com/honojs/hono/issues/1542 within a few minutes of this issue I've come to form the opinion that Hono is not yet production-ready, and can neither recommend my company adopt it or dedicate time to improving it at this stage.

here's how i adapted the ideas from Hono & ported them to Express, sharing in case this inspires:

Hi @ashtonsix
#1542 is already fixed by this PR #1555.

To reduce the maintenance burden here, I suggest auto-generating the exports and updating package.json at build time (modification to build.ts required).

This seems to be good, but I'd prefer something like a linter that would throw the error, rather than rewriting the file directly.

I can close this Issue for now.


formbot: fix typo in minLength and maxLength error messages

discovered via sappira-inc/web-app#116

lol @ https://blog.npmjs.org/post/180565383195/details-about-the-event-stream-incident
i updated the deps that were pulling this in

lgtm after checks fixed

Codecov Report

Merging #8 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #8   +/-   ##
=======================================
  Coverage   69.29%   69.29%
=======================================
  Files          10       10
  Lines         127      127
  Branches       20       20
=======================================
  Hits           88       88
  Misses         28       28
  Partials       11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9917201...e673906. Read the comment docs.


Fix the API of credential creating/updating failed due to URI is too long

Fix: #101

Modify the request param to form-data
Adjustment request result verification

Codecov Report

Merging #123 (baf364f) into master (0378f94) will increase coverage by 0.03%.
The diff coverage is 16.66%.

@@            Coverage Diff            @@
##           master    #123      +/-   ##
=========================================
+ Coverage    5.34%   5.37%   +0.03%
=========================================
  Files          74      75       +1
  Lines       21072   21098      +26
=========================================
+ Hits         1126    1135       +9
- Misses      19873   19890      +17
  Partials       73      73

Flag
Coverage Δ

unittests
5.37% <16.66%> (+0.03%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/client/devops/jenkins/credential.go
30.46% <0.00%> (ø)

pkg/kapis/devops/v1alpha2/register.go
0.00% <0.00%> (ø)

pkg/models/devops/devops.go
11.86% <0.00%> (-0.03%)
:arrow_down:

pkg/apiserver/runtime/runtime.go
56.25% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d9f1f4...baf364f. Read the comment docs.

@shihaoH , thanks for your contribution. Can you provide a docker image for us to test this bug.

LGTM, It's will be better  if you can add the jenkins api in here.

@shihaoH , thanks for your contribution. Can you provide a docker image for us to test this bug?

sure, pls replace the deploy ks-ctl-ks-devops-controller images to shihaoh/devops-controller:fix101

@shihaoH , thanks for your contribution. Can you provide a docker image for us to test this bug?

sure, pls replace the deploy ks-ctl-ks-devops-controller images to shihaoh/devops-controller:fix101

Nice addition. I have confirmed that the BIG credential has been synced correctly.

@liangyuanpeng Sorry, can you tell me in detail, I don’t know how to add jenkins api here. thanks

hi @shihaoH . The actual error output is reason: URI Too Long. And URI is different from URL. So I changed the PR title.

hi @shihaoH . The actual error output is reason: URI Too Long. And URI is different from URL. So I changed the PR title.

thanks

/lgtm

I ordered the wrong

/lgtm

I ordered the wrong

Didn't get your point.

/lgtm

I ordered the wrong

Didn't get your point.

I accidentally clicked that button

/lgtm


A set of linting cleans and new assertions.

Most things here are generally minor, and then trying to add some assertions to functions to improve our code coverage.

Verified linting and pulled locally first to review that there are no conflicts and that workflows run with no issues.


basic streamlit setup with docker

@hugobowne this PR does two main things to address #7:

adds streamlit, along with a basic demo from part of your notebook (see app.py file).
dockerizes the process, so it can be run using docker-compose up, and previewed from localhost:8000. I commented out some lines that will allow the dashboard to scale better when run on a beefy machine on eg Digital Ocean etc..

screencast of me running the dashboard
Notes

it appears there is some uncertainty around how to use conda from docker. I didn't have time to shave the docker+conda  yak, so used normal python + pip in the container.
the environment.yml did not pin all dependency versions. Added the to requirements.txt.

Hope this helps!

thanks @machow ! We've discussed this & will circle back after Friday Live coding session.


Improved CAS in AuthInfo sync-code

by using a single transaction in the agency. This has a much lower potential to be unsuccessful

Waiting for backport of agency inquire fix to 3.2


Enhancement: Mod Menu Toggle for particle affects

It would be really nice if it was possible to toggle between classic rain and particle weather depending on what the user was feeling. Even better if you could enable and disable the particle weather types in mod menu.

Already added in v1.3.0. I am currently not backporting features to older versions.


Fix joining/leaving bugs

Fixes a few bugs. Exactly what it says on the tin.

your honor i did it for the vine


Document scala_import

Related issue: #721
Summary
This PR adds an initial doc for scala_import.
I chose to do it as a Markdown table written by hand. The rest of the docs are HTML tables that I think were generated long ago by Skydoc when it still worked. As soon as Stardoc works, generated files should replace these hand maintained files!
I do need a second look with these attributes though, since I don't really know all of them really mean and cribbed the descriptions from:

https://docs.bazel.build/versions/master/skylark/lib/JavaInfo.html
https://github.com/bazelbuild/rules_scala/blob/master/docs/scala_library.md

It's probably easiest to look at the GitHub rendered Markdown:
https://github.com/long-stripe/rules_scala/blob/document-scala-import/docs/scala_import.md

Can we add the motivation here: we are simply reimplementing java_import except we aren’t using ijar which breaks scala macros and generally doesn’t help much for external dependencies which rarely change.


Specify path to cmake executable

Brief Issue Summary
There doesn't seem to be a config property for the cmake executable location.
Expected:
A way to specify cmake executable location and clear instructions as to which property is to be used.
Other Notes/Information
I have multiple versions of cmake on my system to support various projects

There is a way but it is missing inside the documentation. The settings file support it.
"cmake.cmakePath": "<filepath of executable>"
The <filepath of executable> has the default value cmake. This will search inside the path variable but you could use an absolute path to access the specific cmake versions.

Thanks!


add demo program for EVP_PKEY RSA key generation #14111

Checklist

We will need your CLA submitted. Could you please follow https://www.openssl.org/policies/cla.html

We will need your CLA submitted. Could you please follow https://www.openssl.org/policies/cla.html

I will work on it, thank you. I am doing this on my own time, but will check with my employer's legal team.


"Transferer le message" a disparu dans 2.4.0

Dans 2.3.7 dans le menu dispo pour un message dans un salon privé :

Dans 2.4.0, "repondre" à changé de place (ok), et "transferer" et "citer" ont disparu :

Est-ce ok pour le design ?

@estellecomment I think Element-Android has restored this option "transfer", so Tchap-Android will have it back
Element-web have it, so I advice you to plan to have it in the next version v4, not required for v2. To be confirmed by @areox-net

Yes. It would be good to keep it for future versions.
On Wed 23 Feb 2022 at 12:04, giomfo @.***> wrote:

@estellecomment https://github.com/estellecomment I think
Element-Android has restored this option "transfer", so Tchap-Android will
have it back
Element-web have it, so I advice you to plan to have it in the next
version v4, not required for v2. To be confirmed by @areox-net
https://github.com/areox-net
—
Reply to this email directly, view it on GitHub
https://github.com/tchapgouv/tchap-web/issues/193#issuecomment-1048668510,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJSOU6JVMYZOI2KQLC6HU3U4S5NRANCNFSM5PB3IT5Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Angelo Chiacchio
(+33) 06 66256486
Sent from Mobile

Thank you both for your input ! Closing this issue, we will work on this in v4 separately.


Please make changelog

Please create some changelog, or publish release tags. We just see that major version number jumped from 3 to 4 but have no clue, what was changed.

@SQReder yeah, sorry about that. I need to figure out a better way of managing new  releases. I am gonna write one now. Some summary is here: https://github.com/krzkaczor/ts-essentials/issues/107
But the breaking change is that it requires TS 3.7 now.

Thanks for the quick response! I think changelog notes in the release tab is a good place to deal with it.

Yeah, I think it's good to add the releases here on github, with some changelog and maybe PR links.
Some of my projects are even configured to actually do the release when a tag is added, and I just add a new release directly from github, which triggers a deployment on CI.

Done: https://github.com/krzkaczor/ts-essentials/releases/tag/v4.0.0


Python 3 support?

Hey, gemini v0.20.0 lists initial Python 3 support as a feature, but the setup.py specifies a python version <3.0.  Have you installed gemini with just python 3?  Do you know if this is possible?  Thanks!

Should work if you remove that constraint. Feel free to report here if you have any problems


release branch for 1.6.x

Description
Please include a short summary of the change.

let's wait until diffcp is fixed. Issues look like just importing so hopefully its not too bad. Good luck @PTNobel !!

diffcp should be fixed!

somehow its printing this while we are installing diffcp==1.1.2
(CVXPY) Nov 10 03:38:17 PM: Encountered unexpected exception importing solver DIFFCP:
ImportError('diffcp >= 1.0.15 is required')
(CVXPY) Nov 10 03:38:17 PM: Encountered unexpected exception importing solver DIFFCP:
ImportError('diffcp >= 1.0.15 is required')
['CBC', 'CLARABEL', 'COPT', 'CVXOPT', 'DAQP', 'ECOS', 'ECOS_BB', 'GLPK', 'GLPK_MI', 'GUROBI', 'HIGHS', 'MOSEK', 'OSQP', 'PIQP', 'PROXQP', 'SCIP', 'SCIPY', 'SCS']

then the tests all fail because apparently it thinks diffcp is not installed :(

closing this as we don't want to merge it to master


joserfc depedency of cognitoidp stubs not installed

Describe the bug
joserfc does not get installed, not sure if this is a boto3-stubs issue or pdm issue, please help
To Reproduce
Steps to reproduce the behavior:
See isolated example: https://github.com/dhensen/boto3-stub-joserfc-issue
There is code that uses the library in test_proof.py it will trigger the error. Log is included in the README.md

Thank you for the report.
For now service packages do not have service-specific dependencies. However, this is a good idea to add this functionality.

Thank you so much @vemel. I see it now... I must have had sudden blindness when looking at that traceback. Thanks for helping me out, I can confirm installing moto[cognitoidp] solves this for me.
Also good to know explicitly that service packages do not have dependencies 👍
Have a nice day and once again thanks for helping out!


very basic cli args

Coverage decreased (-0.2%) to 1.543% when pulling d911262cd0bdb26410ec55f7357872589452f3e0 on basic-cli into 2f22933204ab1811b304e255977042f438a13416 on master.


3D image regression

I was looking at your 2d image mr_ct_regression example and was wondering if you guys had a 3d implementations of it.

Yes, the net_regress.py application with the default_monomodal_regression.ini configuration file provided under /config will do 3D MR->CT semantic regression by sampling patches of size [64,64,64]

Do you have the 3d MRI/CT data available for this? I can only seem to find the 2d data


Connection fails if using SASL instead of doing simple authentication

ldap2pg works as expected in Ubuntu 18.04, but it fails if it is executed inside in its container or in Fedora 30 because it tries to use SASL.
As I am using a self-signed CA, I tried both LDAPTLS_CACERT and LDAPTLS_CERT, which seems to work as expected.
I also tried using ldap instead ldaps, but I get the same result.
Why is ldap2pg adding -Y options to try SASL auth in certain environments? Could it be due to a different behaviour of a underlying library?
ldap2pg.yml
# ldap2pg.yml
---

verbosity: 5
color: yes
dry: yes

postgres:
  dsn: [...]
  blacklist: [postgres, root, admin, zabbix, commvault, public, pg_*]
  databases_query: |
    SELECT datname
    FROM pg_catalog.pg_database
    WHERE datallowconn IS TRUE
    AND NOT datname='postgres'
    AND NOT datname='template1';
ldap:
  uri: ldaps://nindc05.nina.no:636
[...]

Expectations

What you expected from ldap2pg ?
What ldap2pg did wrong ?

Verbose output of ldap2pg execution
# ldap2pg -v
[ldap2pg.config        INFO] Starting ldap2pg 5.1.
[ldap2pg.config       DEBUG] Trying ./ldap2pg.yml.
[ldap2pg.config        INFO] Using /workspace/ldap2pg.yml.
[ldap2pg.config       DEBUG] Read color from YAML.
[ldap2pg.config       DEBUG] Read dry from YAML.
[ldap2pg.config       DEBUG] Read verbosity from argv.
[ldap2pg.config       DEBUG] Read ldap:uri from YAML.
[ldap2pg.config       DEBUG] Read ldap:user from YAML.
[ldap2pg.config       DEBUG] Read ldap:password from YAML.
[ldap2pg.config       DEBUG] Read postgres:dsn from YAML.
[ldap2pg.config       DEBUG] Read postgres:blacklist from YAML.
[ldap2pg.config       DEBUG] Read postgres:databases_query from YAML.
[ldap2pg.config       DEBUG] Read privileges from YAML.
[ldap2pg.config       DEBUG] Read sync_map from YAML.
[ldap2pg.config       DEBUG] Drop unused hidden privilege __default_execute_on_functions__
[ldap2pg.config       DEBUG] Drop unused hidden privilege __default_select_on_sequences__
[ldap2pg.config       DEBUG] Drop unused hidden privilege __default_update_on_sequences__
[ldap2pg.config       DEBUG] Drop unused hidden privilege __default_usage_on_sequences__
[ldap2pg.config       DEBUG] Drop unused hidden privilege __default_usage_on_types__
[ldap2pg.config       DEBUG] Drop unused hidden privilege __execute_on_all_functions__
[ldap2pg.config       DEBUG] Drop unused hidden privilege __global_default_execute_on_functions__
[ldap2pg.config       DEBUG] Drop unused hidden privilege __select_on_all_sequences__
[ldap2pg.config       DEBUG] Drop unused hidden privilege __update_on_all_sequences__
[ldap2pg.config       DEBUG] Drop unused hidden privilege __usage_on_all_sequences__
[ldap2pg.config       DEBUG] Configuration loaded.
[ldap2pg.script       DEBUG] Setting up LDAP client.
[ldap2pg.ldap         DEBUG] Found rcfile /etc/ldap/ldap.conf.
[ldap2pg.ldap         DEBUG] Read TLS_CACERT from /etc/ldap/ldap.conf.
[ldap2pg.ldap         DEBUG] Ignoring: [Errno 2] No such file or directory: '/root/ldaprc'
[ldap2pg.ldap         DEBUG] Ignoring: [Errno 2] No such file or directory: '/root/.ldaprc'
[ldap2pg.ldap         DEBUG] Ignoring: [Errno 2] No such file or directory: '/workspace/ldaprc'
[ldap2pg.ldap         DEBUG] Read TLS_REQCERT from env.
[ldap2pg.ldap         DEBUG] Read URI from YAML.
[ldap2pg.ldap         DEBUG] Read USER from YAML.
[ldap2pg.ldap         DEBUG] Read PASSWORD from YAML.
[ldap2pg.ldap         DEBUG] Connecting to LDAP server ldaps://nindc05.nina.no:636.
[ldap2pg.ldap         DEBUG] Trying SASL DIGEST-MD5 auth.
[ldap2pg.ldap         DEBUG] Doing: ldapwhoami -Y DIGEST-MD5 -U ldapquery -W
[ldap2pg.script       CRITI] Failed to connect to LDAP: {'desc': 'Unknown authentication method', 'errno': 22, 'info': 'SASL(-4): no mechanism available: No worthy mechs found'}

Hi @frafra, thanks for reaching.
USER is a SASL parameter. When USER is set, ldap2pg switch to SASL. You should use BINDDN. Please confirm.
Maybe should I update documentation and/or add a log message.

Hi @bersace,
thank you very much for your quick reply. It worked indeed! :-)

You're welcome :-)

Salut, merci d’avoir contacté.
USER est un paramètre SASL. Lorsque est défini, ldap2pg passe en SASL. Vous devez utiliser . Veuillez confirmer.USER``BINDDN
Peut-être devrais-je mettre à jour la documentation et/ou ajouter un message de journal.

Bonjour,
J'ai un problème d'authentification des mes users après avoir réussi la synchronisation.
Pourrais savoir comment vous avez réussi a résoudre votre problème ?
merci


[Idea] Remove Screenshots from repo

I think we should remove Screenshots folder from our repo, rewriting history also since it's NOT friendly for CI/CD.

Hey @tuduongquyet thanks for the suggestion. We actually cache these screenshots in between runs because the test suite takes quite a while to take all the screenshots. For that reason, we leave the screenshots folder in, so we can minimize the potential CI/CD time between each run.


[5.4] fix an issue with slots when content is null

In reference to https://github.com/laravel/framework/issues/18234
if you do @slot('name', $variable) while $variable the code in else will be executed and output  buffering will start causing the blade rendering to break.

i think you may have missed a word or two in your explanation @themsaid so just to clear this up, this occurs when $variable is null?

@browner12  yes correct, or "" I believe

@themsaid will composer update fix this?

you'll just have to wait until a new release is tagged.


Fix IK Bone Drag on Viewport

Based on #8466
Fixes #10767 issue.

May fix #9548 too? They are probably duplicates if fact.

Yes, same problem ^^

I edited your message to replace the related issue by the oldest one. :)


Add new model: Explainable Boosting Machine

Description of changes:
Add new model: Explainable Boosting Machine
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

The lint check seems to be failing because the dependency interpret-core was not installed.  I added interpret-core as an optional flagged dependency to the package and also to the optional tests flag, but at the time that linting occurs it doesn't look like the autogluon package has been built yet, and thus the new test requirement is not installed.  On my local machine these requirements install correctly using the optional installation flags.
I guess I could add it explicitly for now to the env_setup.sh file.  Please advise on your preferred solution.

I tried adding "python -m pip install interpret-core" to setup_build_env, but from the logs it doesn't appear to have been run.  I presume this is running in a container and I don't have permission to update the script being run in the action.

Hi @paulbkoch you would first have to pass the lint_check in order to run the further remaining tests.
The lint_check seems to fail due to some formatting issue, you can try updating your PR after which we can run the CI.

Hi @paulbkoch ,
Is this the run where you first observed the lint failure: https://github.com/autogluon/autogluon/actions/runs/10946844689/job/30394271765 ?
If yes, I believe this is because the message seems to be incorrectly formatted: https://github.com/autogluon/autogluon/pull/4480/files#diff-9d8ccb4278e0f2df479992439def2c704b877c2a12244f9175b4a17c3de21a01
It should work once you format it correctly, you can use black for formatting.
You can add interpret-core as an optional dependency in setup.py rather than using env_setup.sh once you make the above changes you can try running the CI again. Let us know if that helps!

Apologies - I believe we have moved on from black to ruff - https://github.com/autogluon/autogluon/pull/4412
initially it was mixed

Yep, figured and updated.

Thanks @prateekdesai04.  Seems to have passed the lint so you were correct about the formatting being the issue.

Hi @paulbkoch, many thanks for sending the PR!! We have been looking to add the EBM model and this is a fantastic start to this addition. We will plan to merge this for the next release once we do additional testing and benchmarking to verify its stability and impact on the ensemble result.
@LennartPurucker You may be interested in this given you implemented EBM in AutoGluon as a prototype earlier

We will plan to do extensive testing via TabRepo once we merge our improved model testing code.
Some high priority additions to the current baseline (recommended to work on after we get initial results from TabRepo to track progress):

[ ] Respect time_limit
[ ] Leverage validation data for early stopping?
[ ] Preprocessing to handle edge-cases / NaNs / improve performance?
[ ] Memory usage estimation prior to fit
[ ] Strong Hyperparameter Defaults
[ ] Hyperparameter Search Space
[ ] Feature Type Filters (Drop Images / Text / etc.)

Heyho everyone, @paulbkoch thank you very much for contributing and starting this push for adding EBMs!
Here are some immediate pointers from my side regarding the prototype.
Requirements
I advise against depending on the full interpret package as it has a lot of dependencies and functionalities we actually do not need for AutoGluon or as part of the code for running EBMs.
To solve this, we need to depend only on the following:
interpret-core[required,ebm]

We could even install with --no-dependencies, but that might be too much hassle for pip.
AutoGluon Model EBM Code
I created a running prototype of EBMs for AutoGluon a while back. Your PR motivated me to clean it up a bit and add it to a branch of AutoGluon; see here: https://github.com/LennartPurucker/autogluon/blob/ebm_model/tabular/src/autogluon/tabular/models/ebm/ebm_model.py
Feel free to merge/pull my model in your code.
It is a bit longer than your code because it supports the following:

preprocessing,
validation data,
early stopping support (+metric),
passing column types to EBMs,
some changes to the default behavior of EBMs to make them effective for AutoGluon,
some other AutoGluon-related housekeeping.

Open TODOs
I added some open todos to the code, roughly matching Nick's requirements.

[ ]  Respect time_limit
[ ]  Leverage validation data for early stopping?
[ ]  Preprocessing to handle edge-cases / NaNs / improve performance?
[ ]  Memory usage estimation prior to fit
[ ]  Strong Hyperparameter Defaults
[ ]  Hyperparameter Search Space
[ ]  Feature Type Filters (Drop Images / Text / etc.)

Hi @Innixma -- Thanks for the feedback.  These look like great changes.  For background, I should mention that I'm one of the InterpretML developers.  I had planned on adding hyperparameters after the baseline was merged.  The default EBM parameters are generally pretty good since we have our own benchmark system, and the defaults were chosen to optimize the global performance on a variety of datasets.  We haven't had a lot of experience optimizing the parameters for individual datasets though.  I've speculatively listed some recommendations here based on the results from the global optimization: https://interpret.ml/docs/hyperparameters.html.
We might be able to strike out most preprocessing as already completed.  Categoricals are detected automatically if the pandas dataframe uses CategoricalDType, or non-numeric strings.  InterpretML includes handling for missing values, and EBMs do not require imputation, although it might be interesting to benchmark it.
I'll take a look at @LennartPurucker's PR for the rest.
After you have a chance to benchmark it with TabRepo, I'd be curious to hear your findings.  I think you will be surprised at how well EBMs perform.  In our own benchmarks, which have only use default parameters so far, EBMs outperform XGB, and on some metrics LightGBM too.

Heyho everyone, @paulbkoch thank you very much for contributing and starting this push for adding EBMs!
Here are some immediate pointers from my side regarding the prototype.
Requirements
I advise against depending on the full interpret package as it has a lot of dependencies and functionalities we actually do not need for AutoGluon or as part of the code for running EBMs.
To solve this, we need to depend only on the following:
interpret-core[required,ebm]

We could even install with --no-dependencies, but that might be too much hassle for pip.
AutoGluon Model EBM Code
I created a running prototype of EBMs for AutoGluon a while back. Your PR motivated me to clean it up a bit and add it to a branch of AutoGluon; see here: https://github.com/LennartPurucker/autogluon/blob/ebm_model/tabular/src/autogluon/tabular/models/ebm/ebm_model.py
Feel free to merge/pull my model in your code.
It is a bit longer than your code because it supports the following:

preprocessing,
validation data,
early stopping support (+metric),
passing column types to EBMs,
some changes to the default behavior of EBMs to make them effective for AutoGluon,
some other AutoGluon-related housekeeping.

Open TODOs
I added some open todos to the code, roughly matching Nick's requirements.

Hi @LennartPurucker -- Thanks for working on this earlier EBM implementation!  I had a look and most of it looks good.  While reading it over I saw the following that I would modify:

No need to impute.  EBMs handle missing values.
I'm not 100% sure, but I think the LabelEncoderFeatureGenerator isn't required in this case since it looks like autogluon is passing in categoricals as CategoricalDType, which InterpretML already understands.  A simple concatenation of X and X_val and leaving it as pandas should work, I think.
f_type = "None" should be f_type = None, or you can use "auto" if you want a string.  I would think this raises an exception?
The line: validation_size=len(X)    should be    validation_size=len(X_val)    It doesn't matter though since bags is also specified so validation_size is ignored.  I mention it in case you have other code that parallels this that doesn't specify bags.

I agree the interpret package is unnecessary for autogluon.  I called the optional tag "interpret" in autogluon for clarity, but if you look at the optional dependencies in setup.py, you'll see that I used interpret-core.  The interpret tags [required,ebm] are no longer required in the latest interpret-core releases.

No need to impute. EBMs handle missing values.

Very nice :)

LabelEncoderFeatureGenerator

Yes, this stems from a default preprocessing for models with an sklearn API, which is likely suboptimal.
Fixing it.

f_type = "None" should be f_type = None, or you can use "auto" if you want a string. I would think this raises an exception?

This worked fine for the last months. Maybe because I worked on numpy arrays? I changed it to "auto".

validation_size=len(X)

Well spotted; this was a copy-paste error. But then I will remove validation_size if it is unnecessary in this case.

I used interpret-core.

Ah very cool; I did not see that. Great!
I pushed the changes to the branch.
One comment regarding your previous reply: I played quite a bit with dataset-specific hyperparameters and have some pointers, but I think we should learn them via TabRepo. However, I noticed the performance to be very task-specific (i.e., regression vs. binary vs. multiclass) due to how interactions work, as far as I understand.
And one question since you are an InterpretML developer: First of all, great work!
Could you support a timeout callback for EBMs? I.e., stopping in the rounds/iterations early based on time.

Thanks @LennartPurucker.  I'll have a look again.  Regarding hyperparameters, what version of InterpretML were you experimenting on previously?  There were some big changes in v0.5.1 that targeted improved performance, and then another change in v0.6.1 that I think would impact multiclass significantly.  In general EBMs are strongest on binary classification.  For multiclass the default implementation doesn't include pairs.  It's possible to enable multiclass pairs, so for Autogluon where the interpretability isn't important, we might want to try that.  You're probably right that for regression, pairs and possibly higher order interaction become more important.  We can certainly try scaling those up to see what impact it has.  We haven't experimented too much with that ourselves since having excessive pairs breaks interpretability, as do 3-way and higher interactions, but that's not a concern here.

I mainly worked with v0.6.1+.

strongest on binary classification

This matches my findings. I found binary > regression > multiclass.

It's possible to enable multiclass pairs

That sounds good. We should add that to the search space for TabRepo / as an alternative default similar to the multiple defaults for LightGBM.

Autogluon where the interpretability isn't important,

I would not rule out interpretability entirely. AutoGluon has a (somewhat unsupported) interpretability preset, which EBMs could significantly enhance. Ideally, the users can trade off interpretability with performance if needed.

Hi @LennartPurucker -- I looked at the updated code and I have two further recommendations:
If the type hints to the _fit function are correct, then X and y are already pd.DataFrame and pd.Series, so using pd.DataFrame(X) and pd.Series(y) here is less memory efficient as they get duplicated:
https://github.com/LennartPurucker/autogluon/blob/ebdc463c645f8032ae410af339fc403bbc5c56cd/tabular/src/autogluon/tabular/models/ebm/ebm_model.py#L64-L65
Similar memory concerns here.  Given X and y are a pandas objects, vstack/hstack will convert the dataframe/series to an object array, which will be slower to process and consume a lot more memory if there are categorical types:
https://github.com/LennartPurucker/autogluon/blob/ebdc463c645f8032ae410af339fc403bbc5c56cd/tabular/src/autogluon/tabular/models/ebm/ebm_model.py#L110-L111
I would recommend changing to:
fit_X = pd.concat([X, X_val], ignore_index=True)
fit_y = pd.concat([y, y_val], ignore_index=True)
Other than these two things, your implementation is clearly more complete, so we can probably just replace mine.  My preference would be to do this after benchmarking the simple implementation as @Innixma suggested to get an initial baseline.  I think you and @Innixma are correct that setting the outer bags to 1 and using the validation set will be beneficial, but these kinds of changes make me worried without a good benchmark.

I had a further question on the n_jobs parameter.  The current EBM implementation parallelizes the creation of the outer bags.  Our default is to create 14 outer bags, so on typical hardware we get fairly good utilization since most computers have less than 14 cores.  If we set outer bags to 1, then the current EBM implementation will only be able to use 1 core.  That might not be bad if AutoGluon can efficiently use the other cores to build other models in parallel.

To answer some of the questions above that I haven't answered yet:
I agree adding a timeout parameter would be useful, and especially in the context of AutoGluon.  I'll have to give it some thought on the best way to do it for EBMs.  Since we parallelize on the outer bags, we might have a scenario where some of the outer bags are completed, some are in process, and some have not even begun.  In some cases it might be better to throw away the incomplete bags and rely only on the completed bags, and in other cases it might make more sense to incorporate them.  These are only really issues for non-AutoGluon workloads with multiple outer bags.  Eventually we want to move to a finer grained parallelism which would allow us to more efficiently use all the cores across multiple outer bags.  This would also make timed stopping much cleaner.
In terms of memory estimation: I'd verify this, but with the default outer_bags=14, my rule of thumb would be to take the size of the dataframe and multiply by 3-5x.  When using 1 outer bag, I'd change that to multiplying by 2x.  The EBM implementation bit packs data internally, so it shouldn't use much more than the original dataframe, and our internal data structures aren't very big either.
In terms of time estimation, EBMs take about 20x longer than XGBoost, 50x longer than LightGBM, and maybe 2x longer than catboost (from memory), so perhaps we can leverage their time estimation initially.  There are algorithmic differences though that could make the numbers fairly different on specific datasets, and I'm unsure how the outer_bags=1 change will affect things.
In addition to adding multiclass pairs, we might consider bumping up the default number of pairs substantially.  For interpretability reasons we limit the number of pairs, but I've observed increasing performance as the number of pairs go up.  The upper pair limit is probably more dependent on how much time we want to spend on them.
I'm curious about the interpretability aspect of AutoGluon.  What's the value-add?  Is it mostly for hyperparameter tuning?

using pd.DataFrame(X) and pd.Series(y) here is less memory efficient /  vstack/hstack

Yes, these were both still remnants from the using numpy arrays. Fixed.
I would recommend changing to:
fit_X = pd.concat([X, X_val], ignore_index=True)
fit_y = pd.concat([y, y_val], ignore_index=True)

benchmarking the simple implementation

Nick knows best how to approach this, but my two cents are that I am less in favor. For knowing how good a model is, we require models to abide by time limits for proper benchmarking in (Auto)ML.  Moreover, ignoring the validation data passed to the model is also not optional, given that the model would otherwise ignore 1/8% of the data per fit. Lastly, to make a fair comparison in that case, we would also need to implement internal cross-validation and bagging for all other methods.

If we set outer bags to 1, then the current EBM implementation will only be able to use 1 core. That might not be bad if AutoGluon can efficiently use the other cores to build other models in parallel.

AutoGluon would parallelize the outer bags using Ray. For larger datasets, however, AutoGluon might give the model multiple cores; ideally, the model should still be able to use multiple cores.
This is likely a methodological question, but could EBMs parallelize something other than the outer bags? I guess the number of rounds has to be sequential.

In terms of memory estimation

We can also verify this empirical, i.e., fixing it once it crashes somewhere.

EBMs take about 20x longer than XGBoost, 50x longer than LightGBM, and maybe 2x longer than catboost (from memory),

In my limited experience, this is very much due to outer_bags. Most of these are similarly fast, especially if we use early stopping and callbacks for time, as all of these do in AutoGluon.

I'm curious about the interpretability aspect of AutoGluon. What's the value-add? Is it mostly for hyperparameter tuning?

I am not sure I got your questions.  I think the original interpretability preset mainly offered a version that supports only interpretable models that are then correctly ensembled and validated. But Nick would know more as I only found it in the code 😅

AutoGluon would parallelize the outer bags using Ray. For larger datasets, however, AutoGluon might give the model multiple cores; ideally, the model should still be able to use multiple cores.
This is likely a methodological question, but could EBMs parallelize something other than the outer bags? I guess the number of rounds has to be sequential.

There is a way to parallelize work within a single bag, but it's non-trivial to implement.  It's on our roadmap, but since things mostly work today, it has been a lower priority than other items.  It sounds like it won't be an issue in AutoGluon either, so that's nice.  We might consider changing n_jobs to 1 in this code since joblib will avoid spawning a new process then, and perhaps joblib might also use that information somehow when scheduling other work.

In my limited experience, this is very much due to outer_bags. Most of these are similarly fast, especially if we use early stopping and callbacks for time, as all of these do in AutoGluon.

True.  Those numbers are when constructing 14 outer bags, so EBMs should be in the same ballpark for a single bag if the CPUs can be used efficiently elsewhere.

@paulbkoch

I'm curious about the interpretability aspect of AutoGluon. What's the value-add? Is it mostly for hyperparameter tuning?

For now that remains an open question. We support feature importance and SHAP as black-box methods, but we don't have a clear vision for what interpretability in an AutoML system would look like beyond those techniques. We have added various things in the past, such as an entire autogluon.eda package, which you can see here: https://www.kaggle.com/code/samvelkoch/s4e9-eda-by-autogluon-v-1
The tricky part is how to prioritize which pieces of information to show the user, otherwise without smart prioritization, it just becomes an avalanche of information that for 99% of users won't be actionable.
I think the first priority for EBM's in AG is performance improvement if it adds diversity to the ensemble. The second priority would be seeing if we can leverage any of EBM's nice properties for improved visualizations to the user if they are interested in them.

For now that remains an open question. We support feature importance and SHAP as black-box methods, but we don't have a clear vision for what interpretability in an AutoML system would look like beyond those techniques. We have added various things in the past, such as an entire autogluon.eda package, which you can see here: https://www.kaggle.com/code/samvelkoch/s4e9-eda-by-autogluon-v-1

Having blackbox methods like SHAP in AG makes a lot of sense.  For glassbox models, you pretty much can't combine them, so that certainly takes away a lot of the utility within the AG context.  Maybe there's some utility in being able to compare across various interpretable models quickly and simultaneously look for hyperparameters.  FIGS in imodels is often a high performer, as is GAMI-net, so people might want to compare them, and of course linear models, etc.  These are things that people could do of course using only the separate packages, but often there is a benefit to having a unified API and being able to switch pipelines from blackbox to glassbox using a few parameters.

I think the first priority for EBM's in AG is performance improvement if it adds diversity to the ensemble. The second priority would be seeing if we can leverage any of EBM's nice properties for improved visualizations to the user if they are interested in them.

Yes, completely agree.  In terms of AG, my primary motivation is to push the performance aspect of EBMs without regard to interpretability.  I'm happy to consider the interpretability angle later though if you think there would be a benefit.

Update: I have high hopes for this model, as some preliminary tests show that it does improve AutoGluon's ensemble when added! I wasn't able to find bandwidth to get it in for the v1.2 release, so I'll be targeting adding in the v1.3 release. Happy holidays!

Very nice.  Out of curiosity, if it's easy to retrieve, what was the improvement observed on the preliminary tests, and what version of interpret was tested?
After a basic version has been merged, it would be interesting to benchmark a few variations if there's time before the v1.3 release.  We've already touched on a few above, but since we don't care about interpretability in this application, we can also add things like 3-way and higher interactions, extend the number of pairs by large amounts, etc.  It would be interesting to see how each change improves the ensemble.

@paulbkoch I observed a 54% win-rate across 110 classification tasks by adding a single default hyperparameter EBM model to AutoGluon's portfolio, but I only tested on datasets with <=10000 rows as this was part of my experiments for our now released TabPFNMix model.
As I work on TabRepo 2.0 in Q1 2025, I'll be incorporating EBM as one of the first additional models.
Here is the very early and very hacky WIP TabRepo 2.0 code for EBMs: https://github.com/autogluon/tabrepo/pull/77/files#diff-41e8b957082dd6383a87921817cccf865cb3db8a0d441971930355960b294441


Hashfix for ScreenToGif v2.12.1

Hashfix for ScreenToGif v2.12.1!

There is a pull req. by @rasa .


docs: fix typo

Found via codespell -H -L iif

Thanks!

:partying_face: :partying_face: :partying_face: :partying_face: :partying_face:


Removal of the context menu closing delay

I started investigating on this behaviour when, once I started right-clicking on the screen multiple times, I noticed that the context menu was correctly shown only half of the times.
The other half of the times, it only appears for a split second and then disappears.
That's why...
Once the context menu loses focus, a 120ms timeout is instantiated to close it.
So, if you open the context menu and then right-click elsewhere on the page to show it again, it correctly closes the first one, opens the second one and then, after 120ms, it wrongly closes the second one.
And, of course...
In my humble opinion, even if it worked correctly, it's an unexpected behaviour.
No other program waits some time before closing the context menu... It seems that it's running slow for some unknown reason.

Thanks a lot.

Thanks a lot.


Fix area related crashing on load

Currently on when attempting to load the HD plugin you are greeted with an error:
    java.lang.IllegalArgumentException: Your definition for the area ALL has an incorrect AABB: AABB{min=(0,0), max=(2147483647,2147483647)}
    at rs117.hd.utils.DeveloperTools.activate(DeveloperTools.java:47)
    at rs117.hd.HdPlugin.lambda$startUp$2(HdPlugin.java:537)
    at net.runelite.client.callback.ClientThread.invokeList(ClientThread.java:119)
    at net.runelite.client.callback.ClientThread.invoke(ClientThread.java:101)
    at net.runelite.client.callback.Hooks.tick(Hooks.java:213)
    at client.if(client.java:45284)
    at client.ax(client.java)
    at aj.d(aj.java:377)
    at aj.run(aj.java:356)
    at java.base/java.lang.Thread.run(Thread.java:829)

Fixing this error generates the next error:
    java.lang.IllegalArgumentException: Your definition for the area NONE has an incorrect AABB: AABB{min=(0,0), max=(0,0)}
    at rs117.hd.utils.DeveloperTools.activate(DeveloperTools.java:47)
    at rs117.hd.HdPlugin.lambda$startUp$2(HdPlugin.java:537)
    at net.runelite.client.callback.ClientThread.invokeList(ClientThread.java:119)
    at net.runelite.client.callback.ClientThread.invoke(ClientThread.java:101)
    at net.runelite.client.callback.Hooks.tick(Hooks.java:213)
    at client.if(client.java:45284)
    at client.ax(client.java)
    at aj.d(aj.java:377)
    at aj.run(aj.java:356)
    at java.base/java.lang.Thread.run(Thread.java:829)

values in the PR were found by testing each value one at a time until the crash was toggled by changing one digit
Why they are those values i couldn't tell you.

Fixed by 16bb892f5d48f25dc5d3c5df8d04035a757cd20e


Pagination

@sscotth Pull request...

There's no need to create a new class/model for pagination. Just update the original post model

Update?


broad ideas for features

[x] resize indivual grid plots or compositions of subplots within a canvas. Similar to Qt QSplitter
[ ] dynamically change controllers across subplots

Might be nice to be able to define separation between grid plots (x and y separation) and potentially the color of separator (white/black/red/etc.)

Rather than just a grid, a method for having multiple windows (so they can be positioned and resized separately) while still sharing the same controller. Similar to open cv windows perhaps.

One idea which I've had is that a user can add rectangles to an empty canvas and resize/reshape those rectangles for where they want to create a subplot. Basically a controller than can move/resize entire scenes.

"composing" subplots already possible with ipywidgets, see #2

@GarrettBlair You can "manually" define various subplots and stack them together however you want using HBox and VBox, the last cell of the simple.ipynb example shows this: https://github.com/kushalkolar/fastplotlib/blob/master/examples/simple.ipynb


Add error messaging for field-level errors

Follow styles specified in this wireframe

Updated wireframes show errors below field
Aria react component - field error - is already in, so this is resolved
Also part of #158


Add grunt plugin: uncss (grunt-uncss by addyosmani)

https://github.com/addyosmani/grunt-uncss
https://www.npmjs.com/package/grunt-uncss

Maybe we need to compress the result again.


Feat(web-react, web-twig): VisuallyHidden component #DS-867

Description
Introduce new VisuallyHidden component in react and twig.
Additional context

Issue reference
Visually Hidden komponenta

coverage: 96.46% (+21.1%) from 75.348% when pulling 4aad4c1ce0393cf3b00700712316258c37075a00 on feat/DS-867-visually-hidden-component into 06a1fdf05782607ba94a030d16dce12bef33c56b on main.


typed UndefProperty

attach type to UndefProperty

Codecov Report

Merging #14 (51ee2a3) into master (1bae438) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
- Coverage   96.90%   96.73%   -0.17%
==========================================
  Files          22       22
  Lines         613      612       -1
==========================================
- Hits          594      592       -2
- Misses         19       20       +1

Impacted Files
Coverage Δ

src/container.jl
100.00% <100.00%> (ø)

src/macro.jl
95.71% <100.00%> (-0.07%)
:arrow_down:

src/size.jl
94.11% <0.00%> (-1.97%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


breaking API changes starting from 1.0.x?

Sorry, but it doesn't look OK! Now I have to change whole app to use latest version properly. Why don't mark old attributes as 'deprecated' and introduce new ones, like titleConfig and so on, but support old ones without breaking compatibility?

@aksonov You can still use 0.x versions. Every major release breaks backward compatibility. Check http://semver.org/ for more details.


Make the crate more Debug-able

The event and request types should implement Debug, the main blocker for that is to implement Debug for Proxy<_> and Resource<_>.

Can you assign me to this one?


extracted records cannot have extracted records - option 3 - Split IBDO

This PR satisfies the first step in the below process of updating Emissary to enforce Extracted Records not being able to have Extracted Records while BaseDataObjects can. These code changes have been tested with the "downstream" projects and they all build and run without modification.

Split the IBDO into an IExtractedRecord interface (everything in the current IBDO except extracted record methods) that is extended by the IBaseDataObject interface (the extracted record methods).
Update "downstream" projects to correctly use IExtractedRecord for Extracted Records.
Update the extracted record methods to use IExtractedRecord instead of IBaseDataObject, which will now enforce the goal of extracted records not being able to contain extracted methods.

This is an interesting way of flipping the interface structure to solve the literal enforcement ask, but after talking with @drivenflywheel and @dev-mlb, this confuses the concepts of ExtractedRecord a bit with the rest of the current code base and doesn't move us in a good direction for future enhancements to these interfaces.


SPARK-6993 : Add default min, max methods for JavaDoubleRDD

The default method will use Guava's Ordering instead of
java.util.Comparator.naturalOrder() because it's not available
in Java 7, only in Java 8.

Can one of the admins verify this patch?

I removed the bad import - it was a typo

I've taken your reviews into account.

ok to test

Test build #30517 has started for   PR 5571 at commit 7c5f4ab.

Test build #30517 has finished for   PR 5571 at commit 7c5f4ab.

This patch fails Spark unit tests.

This patch merges cleanly.

This patch adds the following public classes (experimental):

  case class Params(

sealed abstract class Node extends Serializable

sealed trait Split extends Serializable

final class CategoricalSplit(

final class ContinuousSplit(override val featureIndex: Int, val threshold: Double) extends Split

trait DecisionTreeModel

This patch does not change any dependencies.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30517/
Test FAILed.

Seems like the precision for float is needed in the test.
I'll add it back

Test build #30519 has started for   PR 5571 at commit 99c3416.

No, just assert that == is true. Looks like the framework actually rejects use of this method? It didn't say it didn't equal, weirdly

I pushed the modifications,
The third time is always the winning one ! :)

Test build #30519 has finished for   PR 5571 at commit 99c3416.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30519/
Test PASSed.

Test build #30521 has started for   PR 5571 at commit 7fe2e9e.

Test build #30521 has finished for   PR 5571 at commit 7fe2e9e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30521/
Test PASSed.

LGTM. Though I imagine this is not controversial, I would love to get a nod from @JoshRosen or @pwendell or @rxin as it offers a new API method.

of course, have a nice weekend :)

LGTM. Merging in master.


Increase visibility to resources stuck in a terminating state

Describe the problem/challenge you have
xref: https://github.com/kubernetes/kubernetes/issues/60807
Cases where resources can be stuck in a terminating state:

an object being deleted has a finalizer
a namespace being deleted contains a finalizer
a namespace being part of an APIService (example with cert-manager https://github.com/kubernetes/kubernetes/issues/60807#issuecomment-524772920)

Describe the solution you'd like
Users of Kubernetes who are unaware of this issue would have to find the relevant Github issue to fix this. Octant can provide value by suggesting cleanup of orphaned apiservices or an interface to patch over an unused finalizer.
Environment:

Octant version (use octant version): 0.16
Kubernetes version (use kubectl version): 1.18.2
OS (macOS 10.15, Windows 10, Ubuntu 19.10 etc): ubuntu

How do you distinguish "stuck" resources vs resources that are gracefully cleaning up external state before being fully deleted?

For namespaces specifically, we can highlight the condition (https://github.com/kubernetes/kubernetes/pull/82189).
Octant doesn't have to distinguish the graceful case. It can show a warning to the effect of "if this resources is not terminating like you'd expect, consider looking at relevant finalizer/apiserver/controller". Maybe these is a way to be more specific

Example of a terminating namespace status
status:
  conditions:
  - lastTransitionTime: "2021-07-14T18:19:44Z"
    message: 'Discovery failed for some groups, 1 failing: unable to retrieve the
      complete list of server APIs: admission.certmanager.k8s.io/v1beta1: the server
      is currently unable to handle the request'
    reason: DiscoveryFailed
    status: "True"
    type: NamespaceDeletionDiscoveryFailure
  - lastTransitionTime: "2021-07-14T18:19:44Z"
    message: All legacy kube types successfully parsed
    reason: ParsedGroupVersions
    status: "False"
    type: NamespaceDeletionGroupVersionParsingFailure
  - lastTransitionTime: "2021-07-14T18:19:44Z"
    message: All content successfully deleted, may be waiting on finalization
    reason: ContentDeleted
    status: "False"
    type: NamespaceDeletionContentFailure
  - lastTransitionTime: "2021-07-14T18:19:44Z"
    message: All content successfully removed
    reason: ContentRemoved
    status: "False"
    type: NamespaceContentRemaining
  - lastTransitionTime: "2021-07-14T18:19:44Z"
    message: All content-preserving finalizers finished
    reason: ContentHasNoFinalizers
    status: "False"
    type: NamespaceFinalizersRemaining
  phase: Terminating

I think is less about guess if something is "stuck" and more about surfacing the conditions in a way that can help a user decide if they want to wait or intervene.
An idea that was discussed was looking at the lastTransitionTime of objects in the Terminating phase and using some delta of that to provider an extra layer of condition introspection.

What about having a toast that informs that a resource is stuck, it could have the link to the resource and with that you don't need to keep checking a table to know the state of the resource, instead, you get an alert that something is not right

To test this behavior, adding a finalizer that you know will never finish.

This may help for testing https://www.openshift.com/blog/the-hidden-dangers-of-terminating-namespaces


fix deps

Hi! This is the friendly automated conda-forge-webservice.
I've started rerendering the recipe as instructed in #25.
If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!
Here's a checklist to do before merging.

[ ] Bump the build number if needed

Fixes #25

@conda-forge-admin please rerender