Do not remove integrity property in Yarn lockfiles

It seems Greenkeeper is (somewhat unnecessarily) stripping the integrity hashes from Yarn lockfiles. Could this behaviour be changed? Thanks for running such a great service! 👍

@hassankhan I believe that the cause is that yarn before version 1.10.0 do not update the integrity hashes automatically.
We solved usage of the wrong version by forcibly installing the latest yarn version in our build pipeline at CodeShip. All the new Greenkeeper PRs since have stopped stripping the integrity hashes away.
Though since GreenKeeper is the one triggering the lockfile I am not quite sure why it is working now as opposed to before or if there even was something else that happened to change.

Hi @Koslun, thanks for the response! I'll wait till the next PRs come through on any of my repos and will update the issue as appropriate 👍

@Koslun seems problem is still there, this pr just created a few hours before
https://github.com/foray1010/didyoumean2/pull/35/files
btw, I actually doubt that greenkeeper should use newest yarn as some users may not ready to upgrade, lot of LoC will be introduced after user yarn install again
maybe we should detect yarn version in package.json engines.yarn or we can parse yarn.lock to see if any integrity field in order to pick right version

+1 @Koslun, I've seen the same issue rear its head on a few of my repositories again

@foray1010 For our part, we did not have an engines.yarn field as I believe older versions of yarn we were using seemed to support the integrity field. I am however not exactly sure in which version this field was introduced but do think it's curious that it started being added as a default in a minor version update. But given its introduction in a minor version bump I'd assume the integrity field would be supported since v1 of yarn.
Either way I think your suggestion of checking for the presence of the integrity field is more ideal as it assumes less about the developer environment.
But workaround right now seems to be to be simply use version ^1.10.1 of yarn.

The integrity field was added in https://github.com/yarnpkg/yarn/pull/5042 released in v1.10.0, but since they realized it may be a breaking change, it was disabled for existing entries in https://github.com/yarnpkg/yarn/pull/6465.

So the best approach for Greenkeeper seems to be upgrading to 1.12.1, and then it will not add integrity fields to existing lockfiles but update those with integrity fields.

I'm using<EMAIL_ADDRESS>in CI, and yet Greenkeeper still removes integrity hashes. Really want to get this resolved!

I searched this repo and the lockfile repo for text instances of "yarn" in order to submit a PR, but it looks like the version of yarn used in CI is not part of the code base.

@janl friendly ping 😄

Is it not possible to control the yarn engine or have green keeper respect the one specified in package.json?

We also have issues with Greenkeeper's 2nd commit on every PR: integrity fields are removed for every single dependency. We use Yarn 1.12.3. Is there any way to disable the lock file update by chance? That'd be better than merging a PR without the integrity fields by accident.

@willdurand hi fellow Mozillian! Quite a few Mozilla projects are using Renovate instead of Greenkeeper now, since its Yarn lockfile integration works much better and amongst other things. If you'd like to chat about it ping me on IRC (:emorley) :-)

Has Greenkeeper updated it’s yarn version? I’m seeing the integrity fields being added in the latest PRs.


I think this need to be fixed

According to the 1.1 specification LID MAY be present but is not really required for client side created resources
https://github.com/MarkoMilos/jsonapi/blob/711533f1e011f70e2ab8511cf7fb914b0dd29235/jsonapi-adapters/src/main/java/jsonapi/ResourceIdentifier.kt#L33
reference:
https://jsonapi.org/format/1.1/#document-resource-objects

True, the next version will include a fix for this.

@MarkoMilos I have opened PR with the fix for the issue: https://github.com/MarkoMilos/jsonapi/pull/3

Fixed in latest release :)


Backport changes from core to ha-tahoma

(work in progress)

@vlebourl @tetienne since core diverged a lot from ha-tahoma, it would be good to merge these changes again.
This PR will remove some functionality that is missing in core (low speed service, low speed switch, extra battery sensor and probably some small other things. It would be good to see if we can merge this one and add the features back in a core style.


Nitropack dev server breaks all websocket connection

Environment
Nitropack: 0.4.24
Node: v14.18.2
Reproduction
Try to listen to a websocket in the server and run the server via nitropack dev server
Describe the bug
No websocket works

I am using Nuxt3 RC8. And I noticed no websocket works when I am running nuxt dev.
But it works totally fine when I am running the prod version

Additional context
You need additional setup to make http-proxy package works with websocket.
Some important setup was missed here
https://github.com/unjs/nitro/blob/main/src/dev/server.ts#L135
See also:
Handling done by http-proxy-middleware
https://github.com/chimurai/http-proxy-middleware/blob/2.x/src/http-proxy-middleware.ts#L70
https://github.com/chimurai/http-proxy-middleware/blob/2.x/src/http-proxy-middleware.ts#L80-L83
https://github.com/chimurai/http-proxy-middleware/blob/2.x/src/http-proxy-middleware.ts#L86-L93
Logs
No response

You are right. Currently Nitro does not supports websockets. Working on it.

https://nitro.unjs.io/guide/websocket


Make target for single theme

https://github.com/vinceliuice/vimix-gtk-themes

Address this in https://github.com/iancleary/install-scripts/tree/feat/ansible

Implemented by https://github.com/iancleary/install-scripts/pull/39


Oclc-numbers

Addresses issue #14 & #4
Adds methods to "normalize" OCLC identifiers in the 001 control field depending on the library the record is intended for.
BPL uses OCLC prefixes (ocm, ocn, on) while NYPL removes them (bare digits). This should help in manipulation of records coming from vendors or Worldcat in which cases we don't always have OCLC #s recorded proper way.
Adds a method to get dictionary of MARC tags and their values for OCLC #s found in 001, 035, & 991.
Introduces a new module: local_values.py which contains any extra functionality that does not have to be part of the Bib class, and can be used with other data types than MARC record (for example, csv data).
Updates all dependencies to the latest versions and cleanup up pyproject.toml configuration.
Drops support for Python 3.7.
Since this package will remained on Github only (not relevant for PyPI) , removed requirements.txt & dev-requirements.txt and modified github actions tests to rely solely on Poetry for the creation of environment & installation of dependencies.

Everything looks good to me!


Handle undefined display_name and cw fields

Can happen with RSS input.
Addresses issue #126

Not the most elegant/proper solution but solves the proximate error.

I forgot the PR needs to be against the develop branch, will fix later.

Redundant with https://github.com/robertoszek/pleroma-bot/pull/128 . The display_name is already fixed in develop/rc version.


dev -> main-beta

:tada: This PR is included in version 2.0.0-beta.27 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Ensure darwin/arm64 platform is supported as well

Currently, the version constraints makes this module unusable on darwin/arm64 platforms.

fixed in v1.5.3


[Question] Making plots with a custom environment

I can successfully train my custom environment, but I cannot seem to find a way to link my environment to the provided plotting scripts - I've noticed that the syntax for the environment name is also different in the  plotting examples compared to training. Where do I need to register my environment for this to work?

Hello,
could you elaborate on what you are doing exactly? and what have you tried?

Hi, sorry for not being clearer - I'm trying to run the plot scripts described in the README (all_plots.py and plot_train.py). I have a custom environment registered as:
    id='customenv-v0',
    entry_point='customgym.envs:CustomEnv',
)

I'm trying to run the scripts after training on the environment with
python scripts/plot_train.py -a ppo_lstm -e CustomEnv -y success -f logs/
But I only get a blank plot without any datapoints.
I think this may be related to another issue I've just noticed - Tensorboard is also not showing any data except for what it gets during the periodic evals. It seems that nothing is being written to the logs during training, even if I change the --log-interval argument.

python scripts/all_plots.py -a ppo_lstm -e CustomEnv -f logs/

should be -e customenv (should be case sensitive).

Tensorboard is also not showing any data except for what it gets during the periodic evals.

But it works with built-en envs, right?

Thank you, that was it for the plot scripts, they render correctly now.

But it works with built-en envs, right?

Yes, it does. What do I need to add to enable it for the custom environment? I've tried  the VecMonitor wrapper, but it doesn't seem to affect the Tensorboard logs.

What do I need to add to enable it for the custom environment?

Nothing normally, the RL Zoo automatically wrap your env with a monitor wrapper, you can take a look at the logs and check that the log file is created.
Closing as the original question was answered, and the rest seems to be related to custom env, not SB3 / RL Zoo.


[master] Auto-update dependencies

Produced via:
./hack/update-deps.sh --upgrade && ./hack/update-codegen.sh
/assign grantr lberk matzew n3wscott
/cc grantr lberk matzew n3wscott

Failure looks related to a change I made in pkg, taking a look now

Possible fix in #1559

/close (fixed in linked PR)

/close
you can not write something after the prow command, @lberk  :smile_cat:


chore: support Python 3.6 & 3.7

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.671%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
297

Relevant Lines:
301

💛  - Coveralls


Edge Browser (Windows 10) touch drag fails

Using http://leafletjs.com/examples/mobile-example.html on Win10 RTM Edge browser V20.10240 I find that touch drag of the map is not functional.  The same site works fine using the Windows 10 RTM Internet Explorer browser.
This problem happens with both leaflet V0.7.3 as well as the 1.0 beta 1 master branch.
It appears the same problem affects the Windows Phone Windows 10 Edge browser.
I've verified this problem also on my personal site, www.deepzoom.com as well as delorme.com and presumably all other leaflet sites.
Ouch.

Eh, Microsoft is so fun as always...

@csuwildcat according to the report above, there seems to be an issue with touch events in Edge for Leaflet (works in Win8 and all other modern mobile platforms and browsers). Any clues?
cc @danzel do you have access to Edge? Wanna take a look? Shouldn't be a hard fix probably.

@jacobtoye and @kerryarts have win10 on their pcs afaik, hopefully one of them can take a look.
Hopefully there is an emulate touch events option in the dev tools, otherwise device emulator should let you do it.

Possibly user agent?
    Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/42.0.2311.135 Safari/537.36 Edge/12.10240

@jaybo unlikely since user agent-derived checks are not used in any touch-related code in Leaflet...

Apparently Microsoft decided to change the touch events API again:
https://msdn.microsoft.com/en-us/library/dn304886(v=vs.85).aspx
I guess that proper detection of L.Browser.msPointer should fix the problem.

@jaybo Can you please check out the value of L.Browser.msPointer in your Edge dev console?

Keeping open until we confirmed that it's fixed. @jaybo can you check the latest master?

@IvanSanchez to be fair, and provide clarity: Microsoft and the other Pointer Events spec contributors changed the spec at the late request of another browser vendor who wanted to adopt Pointer Events as a standard, after a few modifications.

@IvanSanchez I know this because I was at Mozilla when Pointer Events was created ;)

@csuwildcat cool, thanks for the clarification! Personally I'm excited about such a solid touch spec coming up and agreed upon by browser vendors :)

@mourner @csuwildcat @IvanSanchez Fix confirmed.  Tested on Win10 Edge, IE, and Chrome.  Drag OK.  Tap OK.
Aside:  Touch pinch and zoom often doesn't repaint all tiles in Edge, IE, and Chrome.  Is this presumably separate bug already being tracked?

@jaybo Yeah, that's a different bug which is not browser-specific.
Thanks for testing the fix!

I see that this fix has been applied to the master branch, however, this faulty behavior is also exhibited in the Leaflet home page map using the Edge browser, which I assume uses 0.7.3.  Is there a plan to integrate a fix for Edge browsers in the current "stable" release of Leaflet.

@mourner Is this worth a backport? Should be easy enough.

I think this is one worth a backport. Don't want a bad experience on a
browser we want people to upgrade to.
On Tuesday, 4 August 2015, Iván Sánchez Ortega<EMAIL_ADDRESS>wrote:

@mourner https://github.com/mourner Is this worth a backport? Should be
easy enough.
—
Reply to this email directly or view it on GitHub
https://github.com/Leaflet/Leaflet/issues/3674#issuecomment-127729975.

@danzel OK, #3710 should do it.


Support of the ARCore and ARKit

Work in progress. First implementation of a new APIs to provides ARKit and ARCore features with ArcGISRuntime SDK for Qt.

@tdunn @DanCobb1111 Can you review the doc?
@ldanzinger Can you review the APIs and samples?
Notes:

some functions contains the comment not implemented and will be implemented in the next PRs.
I didn't try to generate the documentation for the moment. I will do that next week, to be sure there is no error.

@GuillaumeBelz @JamesMBallard - I have a working API doc build now. The output needs some tweaking, but it's good enough for the moment. I'm continuing to work on it. I can make additional changes in another branch if you are otherwise ready to merge this PR.

@ldanzinger I updated the explanations to install and configure AR in AR.md. Can you review to check if this is better? Thank you.


Strange issue updating to 5.0.0

<Obligatory opener about this workflow being indispensable and brilliant!>
So, I was actually trying to troubleshoot another issue (runtime error: invalid memory address or nil pointer dereference when trying to search CloudFormation stacks), when I saw that my workflow version was 4.8.1.
I downloaded the 5.0.0 release package, but Alfred's Workflow Import dialog displays the version as 4.8.1:

I then removed the workflow and deleted the cache and workflow folders at:

 /Users/myuser/Library/Caches/com.runningwithcrayons.Alfred/Workflow Data/com.ryankoval.awsconsoleservices
/Users/myuser/Library/Application Support/Alfred/Workflow Data/com.ryankoval.awsconsoleservices

Then tried reinstalling.  It still shows as 4.8.1.  Debug view shows this on first query:
[13:47:37.576] STDERR: AWS Console Services[Script Filter] 🍺
13:47:36 workflow.go:327: ---- AWS Console Services/4.8.1 (AwGo/0.20.2) ----
13:47:36 main.go:31: running workflow with query: ``
13:47:36 workflow.go:26: using workflow cacheDir: /Users/myuser/Library/Caches/com.runningwithcrayons.Alfred/Workflow Data/com.ryankoval.awsconsoleservices
13:47:36 workflow.go:27: using workflow dataDir: /Users/myuser/Library/Application Support/Alfred/Workflow Data/com.ryankoval.awsconsoleservices
13:47:36 workflow.go:33: using query: &parsers.Query{RawQuery:"", Service:(*awsworkflow.AwsService)(nil), SubService:(*awsworkflow.AwsService)(nil), HasTrailingWhitespace:false, HasOpenAll:false, HasDefaultSearchAlias:false, regionOverride:(*awsconfig.Region)(nil), RegionQuery:(*string)(nil), ProfileOverride:(*awsconfig.Profile)(nil), ProfileQuery:(*string)(nil), RemainingQuery:""}
13:47:36 workflow.go:168: no search type parsed
13:47:36 update.go:354: fetching https://api.github.com/repos/rkoval/alfred-aws-console-services-workflow/releases ...
13:47:37 update.go:362: [200] https://api.github.com/repos/rkoval/alfred-aws-console-services-workflow/releases
13:47:37 github.go:95: ignored release v5.0.0: no workflow files
13:47:37 github.go:107: ignored release v5.0.0: empty slice
13:47:37 update.go:198: latest version: 4.8.1
13:47:37 feedback.go:468: Sent 4 result(s) to Alfred
13:47:37 workflow.go:404: ------------------ 580.516689ms ------------------

Edited: Notice how update.go / github.go show the latest version as 4.8.1?   It seems to recognise that 5.0.0 is there, but doesn't seem to recognise it as a valid release.  Still, I can't figure out why the downloaded 5.0.0 release would show up as 4.8.1.
I also checked with Packal Updater which showed the package as out of date, but their page lists the latest version as 4.0.0: http://www.packal.org/workflow/aws-console-services

ahh interesting! v5.0.0 release was the first release to have the .alfredworkflow file be contained in a .zip file (necessary for macOS Gatekeeper). feels like this could be why going by this log line:
13:47:37 github.go:95: ignored release v5.0.0: no workflow files

i'll take a look at this sometime. my guess is that i'll have to modify the underlying awgo library (what this workflow relies heavily on), but i imagine it's possible to look to zipped files for this update checker

hey again @rozling. i think i was just able to fix the issue by just uploading a dummy file with the .alfredworkflow extension. i have confirmed that this is now prompting for auto-update on my other laptop. can you also confirm you saw the workflow notify for a new release?

closing, as this seems to be fixed from #55


ExecuteCustomMessage: Function code 17 not supported

Expected behavior:
To execute the custom message for the function 17.
Actual behavior:
The library rises the exception: "Function code 17 not supported" from the ModbusRtuTransport class.
Steps to reproduce the behavior:

Implement the IModusMessage into ReportSlaveRequest and ReportSlaveResponse, then call:

ReportSlaveRequest request = new ReportSlaveRequest(slaveAddress, 17);
ReportSlaveResponse response = modbusMaster.ExecuteCustomMessage<ReportSlaveResponse>(request);

Comments
My device respond correctly but the library breaks in the switch case, inside the RequestBytesToRead(byte[] frameStart) method inside the ModbusRtuTransport class.

I may sugges that you look at my branch of this project: https://github.com/paluneau/NModbus4, as I implemented the Report Slave ID function for RTU communication.
To remove this exception you have to add the function code 17 as a constant in Modbus.cs:
             // supported function codes         public const byte ReadCoils = 1;        ...         public const byte ReadWriteMultipleRegisters = 23;         public const byte ReportSlaveId = 17;
Then, you have to add a case to the switch in ModbusMessageFactory.cs:
`           public static IModbusMessage CreateModbusRequest(byte[] frame)
{
...
        switch (functionCode)
        {
            ...
            case Modbus.WriteMultipleRegisters:
                request = CreateModbusMessage<WriteMultipleRegistersRequest>(frame);
                break;
            case Modbus.ReportSlaveId:
                request = CreateModbusMessage<ReportSlaveIdRequest>(frame);
                break;
            default:
                throw new ArgumentException(
                    String.Format(CultureInfo.InvariantCulture, "Unsupported function code {0}", functionCode),
                    "frame");
        }
        return request;
    }`

In your implementation, you will also have to implment responses and requests classes, just like the other modbus functions supported.

A bit late, but thanks a lot 🙏


Automate documentation building on tags

This PR adds documentation generation and posting to the publish-release.yml CI script. Documentation will be pushed to the gh-pages branch whenever a new tag is pushed to the GitHub repository.
Discussion is welcome.

Thanks! These look like good.
This CI only works for release stage, right?
At times, I'd like to update documentation without publishing release.
Could you create a new CI flow for documentations build?
The CI should run only if there are some changes in docs/**.
Can we do that like below?
on:
  push:
    paths:
    - 'docs/**'

I've separated the documentation building into a separate script. Do you think it would make sense to constrain the documentation-building job to pushes to the master/main branch or is it better to leave it available for all branches?

I've added the restriction to master/main. Additionally, in case we ever need it, there's a workflow_dispatch option which should allow us to prompt the script from the github actions interface.

It looks good to me. Thanks!


Create e2e test for testing at scale

We need a suite of tests for testing kismatic at scale. We can leverage the existing framework, but the test itself might need to run on a schedule instead of on every build.

What kind of scale testing are we thinking? I know we've tested at ~100 nodes on AWS. Would this just run on AWS as that is primarily where our existing e2es run, or can we setup something on Packet as well for bare metal testing?

In my mind, the effort here is to automate the ~100 node test so that we can run it on schedule. This will also help in reducing the manual process required for each release, as we won't have to do this kind of tests manually.


ISPN-16533 Increase the socket timeout logging time

https://issues.redhat.com/browse/ISPN-16533
@tristantarrant I increased the socket timeout to 5 min, logging the actual time.
The output of the log is not present on the Maven process log, but on the target/infinispan-infinispan-client-hotrod.log.
On my machine for instance, I have:
11:34:31,517 INFO  (testng-LargePutAllPressureTest:[]) [o.i.c.h.AuthenticationTest] test executed in 9776ms

Let's just make the timeout 1 minute and see if it happens again

Sure! About the other issue, I'm working on it

1 min seems to be not enough... shall I resume 5 or maybe at this point it is better to recover the other PR (https://github.com/infinispan/infinispan/pull/12869). For me it is the same. Thanks for help

Just leave it at 5 minutes

@tristantarrant is OK for you those changes?

I added the same changes to the hotrod-new module

Thank @wburns. I think I've applied the changes here.

Integrated into main, thanks @fax4ever !

Thanks @wburns


bump: update ab e2e VHDs

What type of PR is this?
This PR updates AB e2e images to incorporate for newer changes.

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall First build on amaheshwari/e2ebump at 61.524%

Totals

Change from base Build<PHONE_NUMBER>:
61.5%

Covered Lines:
2560

Relevant Lines:
4161

💛  - Coveralls


Reduce logging output by creating a silent config option on the resource pipeline

Pretty sure this is implemented already with the resourceLogging config option

I should have specified that this is mainly intended to target the pipelines that run in the resource reloaders to make it possible to update resources from data packs. No need to print that 17 packages were loaded 3 times, because I believe that's how many times it will run before loading the world.


Update DG, add all relevant use cases.

Changed some of requests -> intends
in new commit.

Changed some of requests -> intends in new commit.

I just realized that user should change to library user as well. No need to worry about the old ones (I have already created a pull request for that). Just need to change the user to library user in current commit.


I offer you a favicon and a new logo that you can use.

Please describe the feature you'd like to see added.
I don't know if you are interested, being a long time Groestlcoin miner, I would like to thank you for your work. I have created a favicon and a logo for your website that you can use for free. If you would like me to make any changes to it, please feel free to reply. I tried to keep the same color and the same element of your image. I can provide you with the .ico on request.
Favicon :

Web site logo :

You can thank me or not by sending Groestlcoin to this address: grs1qvr3urhcexzcc6xxgu47chvcnafchqhfn82jr9
If you like this kind of initiative, I can from time to time send you other updates that may be of interest to you such as visual or programming improvements to your web site. Please leave me your impressions. Thank you.

Hi, Thank you for your contribution.
If we decide to change our logo we will contact you. Feel free to send programming contributions.

who's this? get lost!
On Sat, Mar 11, 2023 at 9:39 AM gruve-p @.***> wrote:

Hi, Thank you for your contribution.
If we decide to change our logo we will contact you. Feel free to send
programming contributions.
—
Reply to this email directly, view it on GitHub
https://github.com/Groestlcoin/groestlcoin/issues/46#issuecomment-1464862039,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANNMIOND6QWLTHHAPPHZPHDW3Q247ANCNFSM6AAAAAAVXDA4H4
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Android Log don't show

The Log that I wrote in Android MainActivity onCreate, the debug Flutter App doesn't show that, how do I fix that?

@GanZhiXiong Please provide your flutter doctor -v output.

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Could everyone who still has this problem please file a new issue with the exact descriptions what happens, logs and the output of ' flutter doctor -v'  please.
All system setups can be slightly different so its always better to open new issues and reference related issues.


Fix issue #8: dir.Glob() with explicit filename

Update package dependencies
Clarify documentation; filenames returned by GlobFrom() / ScanFrom() are relative to specified basepath

Fix issue #8

Codecov Report

Merging #9 (60b9e88) into master (b016f70) will decrease coverage by 0.97%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
- Coverage   93.47%   92.49%   -0.98%
==========================================
  Files           9        9
  Lines         613      613
==========================================
- Hits          573      567       -6
- Misses         27       31       +4
- Partials       13       15       +2

Flag
Coverage Δ

unittests
92.49% <100.00%> (-0.98%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/dir/glob.go
97.48% <100.00%> (-2.52%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b016f70...60b9e88. Read the comment docs.


upload profile functionality updated

@CodiumAI-Agent /review

PR Reviewer Guide 🔍

 ⏱ Estimated effort to review [1-5]
3

 🧪 Relevant tests
No

 🔒 Security concerns
- JWT Storage: The JWT token is stored in localStorage, which is susceptible to XSS attacks. Consider using more secure storage mechanisms like httpOnly cookies.

 ⚡ Key issues to review

Hardcoded URL: The API URLs in the axios.get and axios.post calls are hardcoded to 'http://localhost:3000'. This should be replaced with environment variables to allow flexibility in different environments.

Error Handling: The error handling in the catch blocks only logs the error to the console. It would be beneficial to implement user-friendly error handling, such as displaying a message to the user.

Security Concern: Storing JWT in localStorage can make it vulnerable to XSS attacks. Consider using httpOnly cookies for storing tokens.


Facebook login is not working anymore - iOS only, Android works

Hello, Facebook login stops working for me if I upgrade every plugin to the newest packages.
Does not work:
"@nativescript/facebook": "^1.0.0"
"@nativescript/firebase-auth": "^1.2.0"
"@nativescript/firebase-core": "^1.2.0"
Works:
"@nativescript/facebook": "1.0.0-alpha.5"
"@nativescript/firebase-auth": "1.0.0-alpha.42"
"@nativescript/firebase-core": "1.0.0-alpha.42"
env
"@nativescript/core": "^8.2.1"
"@nativescript/android": "^8.2.2"
"@nativescript/ios": "^8.2.2"
Code:
`
const accessToken = AccessToken.currentAccessToken();
if (accessToken) {
const credential = FacebookAuthProvider.credential(
accessToken.tokenString,
);
firebase()
  .auth()
  .signInWithCredential(credential). <!-- this rejects
  .then(
    (userCredentials: any) => ...`

 @nativescript/firebase-auth (IOS)

     signInWithCredential(credential) {
    return new Promise((resolve, reject) => {
        if (!this.native) { <!-------- Always TRUE
            reject();
        }
        else {
            this.native.signInWithCredentialCompletion(credential.native, (result, error) => {
                if (error) {
                    reject(FirebaseError.fromNative(error));
                }
                else {
                    resolve(toUserCredential(result));
                }
            });
        }
    });
}

This should fix it


Extremely long response time for /api/cla/get route

I recently completed the signing experience for a PR. Upon reaching the CLA assistant app, I encountered a blank template view, so I looked in dev tools to see if there was an issue: there was.
Two POST requests to https://cla-assistant.io/api/github/call responded with 401 status.
Somewhat confused, I closed the tab and tried again. Same result the second time. So I began to do a bit of research. Then, after a couple of minutes, I returned to the tab, and I noticed that the template had been filled with content, so I checked the dev tools again and found a new response:
One POST to https://cla-assistant.io/api/cla/get with a 200 status.
I examined more detail and saw that the response took 74095.52799999983 ms, with 74087.4949999999 ms of that being wait time! That's 1m14s of waiting for a response!
This issue is mainly a report, but I'd like to know if anything configurable by me contributed to the long wait. If needed, I can provide HAR entry objects for each req/res described above (with cookies redacted). Is there a place I can upload them privately (rather than posting them publicly here)?

@jsejcksn thanks for the report. If you have a timestamp and the (x-cloud-trace or so) response header of one of the long requests would be very helpful. Then I can more easy check our logs. As well as the link to your CLA signing page (https://cla-assistant.io/$ORG/$REPO) please, so I can see if I can reproduce it.
I saw in the past that some requests took a couple of seconds if a lot of API requests to GitHub are required, but over a minute sounds way too much.

If you have a timestamp and the (x-cloud-trace or so) response header of one of the long requests would be very helpful. ... As well as the link to your CLA signing page (https://cla-assistant.io/$ORG/$REPO)

@Shegox As requested:
{
  // ...
  "request": {
    "method": "POST",
    "url": "https://cla-assistant.io/api/cla/get",
    "headers": [
      // ...
      {
        "name": "referer",
        "value": "https://cla-assistant.io/denoland/manual?pullRequest=213"
      },
      // ...
    ],
    // ...
  },
  "response": {
    "status": 200,
    "statusText": "",
    "httpVersion": "http/2.0",
    "headers": [
      // ...
      {
        "name": "x-cloud-trace-context",
        "value": "5d6a98595154e18d183079d7223c152d/4369706350128875755;o=1"
      },
      // ...
    ],
    // ...
  },
  "serverIPAddress": "<IP_ADDRESS>",
  "startedDateTime": "2022-01-24T14:28:51.298Z",
  "time": 74095.52799999983,
  "timings": {
    "blocked": 3.7069999988564524,
    "dns": -1,
    "ssl": -1,
    "connect": -1,
    "send": 0.25,
    "wait": 74087.4949999999,
    "receive": 4.076000001077773,
    "_blocked_queueing": 2.1189999988564523
  }
}

Perfect, thanks a lot for sharing the details 👍
From a first look it seems that indeed some internal logic causes the delay, as the GitHub API requests are quite fast:

Comparing that to when I open the page (~4s):

I don't think this is something caused by your configuration, but more a problem on our side. I think I have tomorrow a bit more time to investigate that.

Any update here? Seems to be causing problems for our users as well: https://github.com/prisma/language-tools/pull/1071#issuecomment-1058054268 Any way to help?

The whole platform is extremely slow and it appears the services no longer work, even the website dashboard


Ft/update filters

What does this PR do / why we need it
This PR adds a filter inside the registry viewer so we can filter out deprecated or non deprecated stacks. A deprecated stack is considered when the Deprecated tag is added on the default version main tag section.
Note that if all the stacks are deprecated or non-deprecated the filter is not appearing (this is the default configuration for our filters)
Example image:

Which issue(s) does this PR fix
Fixes https://github.com/devfile/api/issues/1064
PR acceptance criteria

[x] Unit Tests
[x] E2E Tests
[x] Documentation
Update the sidebar if there is a new file added or an existing filename is changed

How to test changes / Special notes to the reviewer
To test the changes someone should:

Run minikube locally.
Build a new image of registry with a stack that is deprecated (currently all stacks are not deprecated).
Deploy a registry deployment to minikube
Run the registry viewer locally with:

DEVFILE_REGISTRIES='[{"name":"Community","url":"http://<your registry's address>","fqdn":"/<your registry's address>"}]' yarn nx serve registry-viewer --configuration=development

Will investigate too why the color of the Deprecated tag is not visible and try to add a quick fix in the PR too


error: redefinition of ‘constexpr const bool stdgpu::numeric_limits::is_specialized’

Ubuntu 20
Cuda 11.4
Library compiled by CUDA back-end successfully, examples work.
But when add STDGPU  to small project, next error during compiling:
/usr/local/include/stdgpu/impl/limits_detail.h:73:42: error: redefinition of ‘constexpr const bool stdgpu::numeric_limits::is_specialized’

Does this error also occur with different host compilers (GCC, Clang) and different CUDA versions (11.3, etc.)? Furthermore, is this the only error you are getting? Or are there also errors regarding the is_signed, is_integer, etc. member variables? If possible, could you attach a (minimal) reproducable example?

Try only GCC and CUDA 11.4, this is my work setup.
Have 5 errors, as list  of this variables:
/**
   * \brief Whether the type is signed
   */
  static constexpr bool is_signed = false;
  /**
   * \brief Whether the type is an integer
   */
  static constexpr bool is_integer = true;
  /**
   * \brief Whether the type is exact
   */
  static constexpr bool is_exact = true;
  /**
   * \brief Number of radix digits
   */
  static constexpr int digits = 1;
  /**
   * \brief Integer base
   */
  static constexpr int radix = 2;

Add only #include header from expamle vector.cu
#include
#include <thrust/copy.h>
#include <thrust/reduce.h>
#include <thrust/sequence.h>
#include <stdgpu/memory.h>          // createDeviceArray, destroyDeviceArray
#include <stdgpu/iterator.h>        // device_begin, device_end
#include <stdgpu/platform.h>        // STDGPU_HOST_DEVICE
#include <stdgpu/vector.cuh>        // stdgpu::vector
and

this errors if add include_directory with headers

if add include_directory with path to include directory of stdgpu, errors more than 200

Could you elaborate what you exactly mean by that? The lines
find_package(stdgpu REQUIRED)
target_link_libraries(${EXECUTABLE_NAME} PUBLIC stdgpu::stdgpu)

are sufficient to add all necessary properties stdgpu needs to your project, including the include directory paths.
It seems like this is an error/incompatibility in your project. stdgpu requires compilation with C++14 and should enforce this by its imported cxx_std_14 property. Did you set the C++ standard somewhere in your project? Could you provide more details on your project? In particular, the build configuration, i.e. the CMakeLists.txt file(s), would be helpful to know (if it is possible for you to attach them).

Made small project to solve problem, under some changes in cmakelists.txt all work as expected:
cmake_minimum_required(VERSION 3.5)

if(NOT DEFINED CMAKE_CUDA_ARCHITECTURES)
  set(CMAKE_CUDA_ARCHITECTURES 61)
  message(CMAKE_CUDA_ARCHITECTURES)
endif()

project(CellInstancing LANGUAGES CUDA CXX)

set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD_REQUIRED ON)

set(CMAKE_CUDA_STANDARD 14)
set(CMAKE_CUDA_STANDARD_REQUIRED ON)
set(CMAKE_CUDA_SEPARABLE_COMPILATION ON)

set(EXECUTABLE_NAME "CUDA_exp")

find_package(CUDA REQUIRED)

SET(TARGET_H
)

SET(TARGET_SRC
main.cu
)

SET(TARGET_CUDA_H
cuda_exp.cuh
)

SET(TARGET_CUDA_SRC
cuda_exp.cu
)

find_package(stdgpu REQUIRED)

set(Cuda_common_include "/usr/local/cuda/samples/common/inc")
include_directories(${Cuda_common_include})

message(${CUDA_INCLUDE_DIRS})
include_directories(${CUDA_INCLUDE_DIRS})

add_executable(${EXECUTABLE_NAME} ${TARGET_SRC} ${TARGET_H} ${TARGET_CUDA_H} ${TARGET_CUDA_SRC} )

set_target_properties(${EXECUTABLE_NAME} PROPERTIES CUDA_ARCHITECTURES "61")
target_link_libraries(${EXECUTABLE_NAME} ${CUDA_LIBRARIES})
target_link_libraries(${EXECUTABLE_NAME} stdgpu::stdgpu)


Contributing?

Hi Michael, this looks like an amazing project. Is there any way I could contribute? Not sure my skills are up to par but I really love the idea and would be delighted to help in any way I can

Sorry for the delay!  Certainly contributions would be welcome, there is a lot to do.  There are some internal issues and exposing new features in SuiteSparse 3.1.1 which would require some C coding.  One other problem is TOAST varlena objects the format which stores a matrix in a table, is limited to 1GBish.  Postgres has a "large object" C api that might be the right idea to switch to, or have it be configurable in some way.

This sounds exciting , any pointers on how one can get started ?

Hi @arjology, SuiteSparse just did a 3.2.0 release, so a task needing work is upgrading to 3.2.0.  No backwards incompatible changes were made, so it should be pretty straightforward.  There are two new binary operators, PAIR and ANY which need to be supported.  PAIR always returns 1, it means "both values are present" and ANY returns either of its inputs, doesn't matter which.


[BUG] Work Experience Role and Duration layout is broken

Attaching screenshot of the issue

What do you feel is broken in the layout? It actually does look like it's supposed to. Maybe you were expecting another design?


configurationNames property should not be allowed on launch configurations other than "composite"

Testing #14171

This is just a temporary way that we have surfaced multi debug sessions, we have to figure out what is our plan for this in november

Duplicate of #14486


{sig} HTML tags aren't allowed in published reference content

Describe the bug
Problem to solve:
HTML tags in source code are causing build warnings in MicrosoftDocs/azure-docs-cli. More importantly, customer-facing reference docs are not instantiating properly -- parameter values formatted with `<>` are missing. Here's an example:

Requested solution:
These values should be escaped with a backtick. Here's an example from az webpubsub.

Related GitHub issues:
This is the same issue as these GitHub issues.
List of HTML tag instances that need update:

File name
Build error

latest/docs-ref-autogen/sig/image-version.yml
HTML tag 'edge' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

latest/docs-ref-autogen/sig/image-version.yml
HTML tag 'lun1' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

latest/docs-ref-autogen/sig/image-version.yml
HTML tag 'lun2' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

latest/docs-ref-autogen/sig/image-version.yml
HTML tag 'region' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

latest/docs-ref-autogen/sig/image-version.yml
HTML tag 'edge' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

latest/docs-ref-autogen/sig/image-version.yml
HTML tag 'replica' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

latest/docs-ref-autogen/sig/image-version.yml
HTML tag 'storage' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

latest/docs-ref-autogen/sig/image-version.yml
HTML tag 'MajorVersion' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

latest/docs-ref-autogen/sig/image-version.yml
HTML tag 'MinorVersion' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

latest/docs-ref-autogen/sig/image-version.yml
HTML tag 'Patch' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

latest/docs-ref-autogen/sig/image-version.yml
HTML tag 'MajorVersion' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

latest/docs-ref-autogen/sig/image-version.yml
HTML tag 'MinorVersion' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

latest/docs-ref-autogen/sig/image-version.yml
HTML tag 'Patch' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

latest/docs-ref-autogen/sig/image-version.yml
HTML tag 'region' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

latest/docs-ref-autogen/sig/image-version.yml
HTML tag 'edge' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

latest/docs-ref-autogen/sig/image-version.yml
HTML tag 'replica' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

latest/docs-ref-autogen/sig/image-version.yml
HTML tag 'storage' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

Related command
az sig
Errors
n/a
Issue script & Debug output
n/a
Expected behavior
n/a
Environment Summary
Azure CLI 2.62.0
Additional context
No response

Thank you for opening this issue, we will look into it.


Use correct argument type for valueDecoder method

@silent-nekto, @dmiller7, @haxtibal, could you please check that this change fixes https://github.com/pyasn1/pyasn1/issues/28 issue for you?

@droideck sorry this didn't work for me - as @haxtibal has said the pysnmp error is still present for me.
I'm guessing that a short term fix might be for pysnmp to change its dependencies from
pyasn1>=0.2.3
to
pyasn1>=0.2.3,<0.5
But I don't think I know enough to be sure. I was hoping that a fix might be put in place here rather than pysnmp as I think pysnmp seems to be between maintainers.

https://pypi.org/project/pysnmplib/ has picked up pysnmp
It would be nice to let them know about the breaking change as everything is failing with
AbstractTransportDispatcher._cbFun(<pysnmp.carri...x7ff257601110>, ('<IP_ADDRESS>', 161), b'00\x02\x01\...B\x02\x01\xef')
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/asyncio/events.py", line 80, in _run
    self._context.run(self._callback, *self._args)
  File "/usr/local/lib/python3.11/site-packages/pysnmp/carrier/base.py", line 80, in _cbFun
    self.__recvCallables[recvId](
  File "/usr/local/lib/python3.11/site-packages/pysnmp/entity/engine.py", line 151, in __receiveMessageCbFun
    self.msgAndPduDsp.receiveMessage(
  File "/usr/local/lib/python3.11/site-packages/pysnmp/proto/rfc3412.py", line 291, in receiveMessage
    msgVersion = verdec.decodeMessageVersion(wholeMsg)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pysnmp/proto/api/verdec.py", line 15, in decodeMessageVersion
    seq, wholeMsg = decoder.decode(
                    ^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pyasn1/codec/ber/decoder.py", line 2003, in __call__
    for asn1Object in streamingDecoder:
  File "/usr/local/lib/python3.11/site-packages/pyasn1/codec/ber/decoder.py", line 1918, in __iter__
    for asn1Object in self._singleItemDecoder(
  File "/usr/local/lib/python3.11/site-packages/pyasn1/codec/ber/decoder.py", line 1778, in __call__
    for value in concreteDecoder.valueDecoder(
  File "/usr/local/lib/python3.11/site-packages/pyasn1/codec/ber/decoder.py", line 654, in valueDecoder
    for chunk in substrateFun(asn1Object, substrate, length, options):

@bdraco what you said is completely wrong. pysnmplib depends on its own pysnmp-pyasn1, not pyasn1 from this repo, https://pypistats.org/packages/pysnmplib

You are right about that. It looks like there we have a dep conflict somewhere. https://pypi.org/project/pysnmp-pyasn1/

Its actually much worse dep hell since both pysnmp-pyasn1 and pyasn1 are using the same namespace. But thats not pyasn1's fault
pysnmp-pyasn1==1.1.2
  - pysnmplib==5.0.21 [requires: pysnmp-pyasn1>=1.0.3,<2.0.0]
    - brother==2.3.0 [requires: pysnmplib>=5.0.21]
pyasn1==0.4.8
  - adb-shell==0.4.3 [requires: pyasn1]
    - androidtv==0.0.70 [requires: adb-shell>=0.4.0]
  - oauth2client==4.1.3 [requires: pyasn1>=0.1.7]
  - pyasn1-modules==0.2.8 [requires: pyasn1>=0.4.6,<0.5.0]
    - google-auth==2.17.3 [requires: pyasn1-modules>=0.2.1]
      - gassist-text==0.0.10 [requires: google-auth>=0.3.0,<3]
      - google-api-core==2.11.0 [requires: google-auth>=2.14.1,<3.0dev]
        - google-api-python-client==2.71.0 [requires: google-api-core>=1.31.5,<3.0.0dev,!=2.3.0,!=2.2.*,!=2.1.*,!=2.0.*]
        - google-cloud-pubsub==2.13.11 [requires: google-api-core>=1.32.0,<3.0.0dev,!=2.7.*,!=2.6.*,!=2.5.*,!=2.4.*,!=2.3.*,!=2.2.*,!=2.1.*,!=2.0.*]
          - google-nest-sdm==2.2.4 [requires: google-cloud-pubsub>=2.1.0]
      - google-api-python-client==2.71.0 [requires: google-auth>=1.19.0,<3.0.0dev]
      - google-auth-httplib2==0.1.0 [requires: google-auth]
        - google-api-python-client==2.71.0 [requires: google-auth-httplib2>=0.1.0]
      - google-auth-oauthlib==1.0.0 [requires: google-auth>=2.15.0]
        - google-nest-sdm==2.2.4 [requires: google-auth-oauthlib>=0.4.1]
        - gspread==5.5.0 [requires: google-auth-oauthlib>=0.4.1]
      - google-nest-sdm==2.2.4 [requires: google-auth>=1.22.0]
      - gspread==5.5.0 [requires: google-auth>=1.12.0]
    - oauth2client==4.1.3 [requires: pyasn1-modules>=0.0.5]
    - slixmpp==1.8.2 [requires: pyasn1-modules]
      - aioharmony==0.2.10 [requires: slixmpp]
  - pysmb==<IP_ADDRESS> [requires: pyasn1]
    - pyairvisual==2022.12.1 [requires: pysmb>=1.2.6,<2.0.0]
  - python-jose==3.3.0 [requires: pyasn1]
    - pycognito==2022.12.0 [requires: python-jose>=3.2.0]
      - hass-nabucasa==0.66.2 [requires: pycognito==2022.12.0]
    - warrant-lite==1.0.4 [requires: python-jose>=3.0,<4.0]
      - pyoverkiz==1.7.7 [requires: warrant-lite>=1.0.4,<2.0.0]
  - rsa==4.8 [requires: pyasn1>=0.1.3]
    - adb-shell==0.4.3 [requires: rsa]
      - androidtv==0.0.70 [requires: adb-shell>=0.4.0]
    - google-auth==2.17.3 [requires: rsa>=3.1.4,<5]
      - gassist-text==0.0.10 [requires: google-auth>=0.3.0,<3]
      - google-api-core==2.11.0 [requires: google-auth>=2.14.1,<3.0dev]
        - google-api-python-client==2.71.0 [requires: google-api-core>=1.31.5,<3.0.0dev,!=2.3.0,!=2.2.*,!=2.1.*,!=2.0.*]
        - google-cloud-pubsub==2.13.11 [requires: google-api-core>=1.32.0,<3.0.0dev,!=2.7.*,!=2.6.*,!=2.5.*,!=2.4.*,!=2.3.*,!=2.2.*,!=2.1.*,!=2.0.*]
          - google-nest-sdm==2.2.4 [requires: google-cloud-pubsub>=2.1.0]
      - google-api-python-client==2.71.0 [requires: google-auth>=1.19.0,<3.0.0dev]
      - google-auth-httplib2==0.1.0 [requires: google-auth]
        - google-api-python-client==2.71.0 [requires: google-auth-httplib2>=0.1.0]
      - google-auth-oauthlib==1.0.0 [requires: google-auth>=2.15.0]
        - google-nest-sdm==2.2.4 [requires: google-auth-oauthlib>=0.4.1]
        - gspread==5.5.0 [requires: google-auth-oauthlib>=0.4.1]
      - google-nest-sdm==2.2.4 [requires: google-auth>=1.22.0]
      - gspread==5.5.0 [requires: google-auth>=1.12.0]
    - oauth2client==4.1.3 [requires: rsa>=3.1.4]
    - python-jose==3.3.0 [requires: rsa]
      - pycognito==2022.12.0 [requires: python-jose>=3.2.0]
        - hass-nabucasa==0.66.2 [requires: pycognito==2022.12.0]
      - warrant-lite==1.0.4 [requires: python-jose>=3.0,<4.0]
        - pyoverkiz==1.7.7 [requires: warrant-lite>=1.0.4,<2.0.0]
  - slixmpp==1.8.2 [requires: pyasn1]
    - aioharmony==0.2.10 [requires: slixmpp]

Opened https://github.com/pysnmp/pysnmp/issues/51 to see if pysnmp-pyasn1 could be dropped now that asn1 has a maintainer to fix the dep hell.

@bdraco This is not a dep hell, but what naturally happened when people tried to save a collapsed stack like pysnmp. Please read https://github.com/etingof/pysnmp/issues/429 to learn more of the background.


[scan] Change order of checks in building_mac_catalyst_for_mac func

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context
showBuildSettings command is not necessary in for quite a lot of situations and if it can be omitted then it should.
This speeds up build and makes it more stable (recently I started experiencing failed builds due to increased time for showBuildSettings).
Resolves #20897
Description
Most of the paths that asks for build settings can be covered by specifying fields in scan config.
Only one that couldn't be omitted was Scan.project.supports_mac_catalyst even thought it consists of and boolean expression where first one checks build settings and second one checks scan config.
In order to allow skipping this command at all I changed order of evaluation for those expressions.
Testing Steps
Specify values for keys in scan:

app_name
derived_data_path
deployment_target_version

Expected Result:
Scan does not call xcodebuild -showBuildSettings

@hjanuschka Any chance for review here? Would appreciate a lot 🙏
Looks like there is not much movement in the PRs 🤔

@rogerluan Would you like to review or help me getting review for this PR?
Also got CI failure after rebase which seems to be tooling issue: https://app.circleci.com/pipelines/github/fastlane/fastlane/6676/workflows/6a723dc5-a195-4433-ace9-23c352d926e7/jobs/102673?invite=true#step-108-202049_81
Error: Your Homebrew is too outdated for `brew bundle`. Please run `brew update`!
rake aborted!

Any idea what can be done about that?

Looks like CI failure was caused by outdated homebrew installation on CI which was causing error during brew bundle.
This issue can be spotted in some other recent PRs too.
Mitigated that by adding brew update in fastlane/swift/formatting/Rakefile.
Failed CI run: https://app.circleci.com/pipelines/github/fastlane/fastlane/6676/workflows/6a723dc5-a195-4433-ace9-23c352d926e7/jobs/102673?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link&utm_content=summary&invite=true#step-108-202049_81

Notice: Ghost author is my old account: @TLizer which I finally merged with other one :)


Moved iEnvoyProxy services into Envoy itself

Moved iEnvoyProxy services down into Envoy itself to streamline integration.  Now only a list of urls (with certain formatting requirements) and an optional url to test direct connections are required as arguments and any required service will be started or stopped by Envoy itself as the urls are verified.
Additional parameters may be required when building to use the new features.  Specifically, Hysteria requires a key and a certificate and dnstt requires several configuration values.  These parameters can be passed in on the command line or added to the project settings in Android Studio.
I will draft an updated readme before merging this branch.

There is some current behavior I wanted to highlight.  I don't know that it's right or wrong but it might be worth discussing whether it might cause unwanted friction for users.

As urls are found to be valid or invalid, they are added to a corresponding list and then that entire list is returned.  This means that the urls should be ordered roughly according to speed.  There is a hard-coded delay for urls that require services to allow those services to start.  There is also a smaller hard coded delay for http(s) urls to allow a chance to test a direct connection.  The net effect of this is that it is up to the app itself to decide what to do when each list is received.
If all urls are invalid (or if no urls were submitted) Envoy will try to fetch additional urls with dnstt.  Currently there is no broadcast to indicate this behavior, and the number and details of the urls returned may be unknown to the app. (ie: if you submit 6 urls, you may receive a list of 6 invalid urls, then receive a new list of 1 or more valid urls)  This may lead to unpredictable behavior.
If any parameters required to start a service are missing, the corresponding urls will not be tested and there will be no status broadcast.

I do get some warnings from the build:

w: /build/envoy/android/envoy/src/main/kotlin/org/greatfire/envoy/CronetUrlRequestCallback.kt: (151, 30): 'SPDY_3' is deprecated. OkHttp has dropped support for SPDY. Prefer {@link #HTTP_2}.
w: /build/envoy/android/envoy/src/main/kotlin/org/greatfire/envoy/NetworkIntentService.kt: (155, 32): Parameter 'index' is never used, could be renamed to _
w: /build/envoy/android/envoy/src/main/kotlin/org/greatfire/envoy/NetworkIntentService.kt: (263, 13): Condition 'v2wsParts == null' is always 'false'
w: /build/envoy/android/envoy/src/main/kotlin/org/greatfire/envoy/NetworkIntentService.kt: (286, 13): Condition 'v2srtpParts == null' is always 'false'
w: /build/envoy/android/envoy/src/main/kotlin/org/greatfire/envoy/NetworkIntentService.kt: (309, 13): Condition 'v2wechatParts == null' is always 'false'
w: /build/envoy/android/envoy/src/main/kotlin/org/greatfire/envoy/NetworkIntentService.kt: (491, 56): Unnecessary non-null assertion (!!) on a non-null receiver of type JSONArray!
w: /build/envoy/android/envoy/src/main/kotlin/org/greatfire/envoy/NetworkIntentService.kt: (641, 25): Unnecessary safe call on a non-null receiver of type UrlResponseInfo?
w: /build/envoy/android/envoy/src/main/kotlin/org/greatfire/envoy/NetworkIntentService.kt: (643, 71): Unnecessary safe call on a non-null receiver of type UrlResponseInfo?
w: /build/envoy/android/envoy/src/main/kotlin/org/greatfire/envoy/NetworkIntentService.kt: (643, 96): Unnecessary safe call on a non-null receiver of type UrlResponseInfo?
w: /build/envoy/android/envoy/src/main/kotlin/org/greatfire/envoy/NetworkIntentService.kt: (661, 71): Unnecessary safe call on a non-null receiver of type UrlResponseInfo?
w: /build/envoy/android/envoy/src/main/kotlin/org/greatfire/envoy/NetworkIntentService.kt: (661, 96): Unnecessary safe call on a non-null receiver of type UrlResponseInfo?
w: /build/envoy/android/envoy/src/main/kotlin/org/greatfire/envoy/NetworkIntentService.kt: (679, 30): Parameter 'request' is never used
w: /build/envoy/android/envoy/src/main/kotlin/org/greatfire/envoy/NetworkIntentService.kt: (679, 52): Parameter 'info' is never used

Some of that stuff might be worth looking in to

oh, I just notices this too:

Configure project :envoy
WARNING: no dnsttserver prop found
WARNING: no dnsttkey prop found
WARNING: no dnsttpath prop found
WARNING: no dohUrl prop found
WARNING: no dotAddr prop found
WARNING: no hystcert prop found

How do those get passed in for command line builds, can you just pass the -P ... params to the gradlew? We should update android/build-envoy.sh to pass them in... I guess from ENV vars?

I think we need to update the build scripts before merge

yes


Does enabling Auto-Upgrade for the node-image channel also automatically disable unattended-upgrade on Ubuntu nodes?

The Auto-Upgrade release channel for node-image upgrades is a great feature to be combined with planned maintenance scheduling to control image upgrades in a safe and timely manner. In order for this to be effective however, Azure Ubuntu image users need to also disable the default behavior of unattended-upgrades. Otherwise unattended-upgrades will continue to run outside the planned maintenance window and inhibit the safe and gradual rollout of image patches. The documentation is not clear on if the enablement of Auto-Upgrade of the node-image channel automatically disables unattended-upgrade or does the user need to take another step to add a vm extension to disable unattended-upgrade.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 43da9bdf-a3d3-a65b-b555-60dcc5ac2c55
Version Independent ID: 9913c705-aeb7-e154-4fdf-164ff1e7ff99
Content: AKS Day-2 - Patch and upgrade guidance - Azure Architecture Center
Content Source: docs/operator-guides/aks/aks-upgrade-practices.md
Service: architecture-center
Sub-service: reference-architecture
GitHub Login: @rishabhsaha
Microsoft Alias: pnp

@lgodmer Thanks for the feedback. We will review and update as appropriate.

@rishabhsaha -- can you please address this question on your article?

Hi @lgodmer
Sorry for the delay.
If using the node-image cluster auto-upgrade channel or the NodeImage node image auto-upgrade channel, Linux unattended upgrades will be disabled by default.
I will close the ticket, but feel free to re-open if additional clarification is needed.

#please-close


disable rollback option

A --disable-rollback option would be good, to keep the stack even if the stack creation failed. That would help a lot for debugging, when deployment did not work.

Besides the changes in #45 this also needs to be implemented in lizzy-client


Simulator gives MANUAL CONTROL LOST

When running simulator there are lots of warnings “Manual Control Lost”  and shortly afterwards “Manual Control Regained”. We shouldn't be getting these warnings because we don't have manual control (Simulator) and COM_RC_IN_MODE is set by default such that RC fails should be ignored.
This can be replicated Gazebo Standard VTOL (Macbook pro) and on jmavsim or Gazebo multicopter on Linux computer running Ubuntu 16.04.
I can reproduce on Ubuntu on any build in the last couple of weeks. Simply start the simulator and then putting my computer into lock mode. After COM_RC_LOSS_T  the manual control lost message is output in QGC. Undoing lock regains control. I THINK this happens at other times, but I cannot reporduce that.
FYI @RomanBapst. Reported by Ivo Dresher on slack here: https://px4.slack.com/archives/C0V533X4N/p1527595988000400

A temporary workaround is to set COM_RC_LOSS_T timeout to maximum.

Thanks Hamish for creating the defect report. For me setting NAV_RCL_ACT to "RC Auto Recovery" helped. With that setting when MANUAL CONTROL LOST happened this had no influence on the simulation. I had COM_RC_LOSS_T at 0.5s all the time.

I believe this is fixed, please re-open if it's still an issue.

@julianoes : On which version is this fixed ? Is this fixed without setting COM_RC_LOSS_T timeout to maximum?
I can still reproduce this issue

@echoGee

Simply start the simulator and then putting my computer into lock mode.

What do you mean lock mode?

I am not sure what is Iock mode, assumed it meant hold mode. But I can reproduce the issue in stabilized or hold mode.

@echoGee
I'm confused. I don't see that and I use SITL/HITL all the time. Is it SITL or HITL?
@hamishwillee what do you mean with?

What do you mean lock mode?

@julianoes
By lock mode, I mean Windows screen lock mode. This can be invoked by doing Ctrl + Alt + Delete and then selecting Lock. Or it happens after a computer has been left alone for a timeout.
I haven't seen this issue for a while, but it may be because I disabled automatic locking of my computer when I am absent.

Aha, I'd say that's expected because the OS basically stops and the time slips. With lockstep it should not happen anymore though.

IN that case, from my perspective this is closed.

I can reproduce this on Ubuntu 16.04 with docker. Is it due to too much processor hogging ?

@echoGee what PX4 version?

Version is 1.8.2

Right, in that case it's probably because the simulation runs too slowly on your computer. I can only recommend to use 1.9 where we have lockstep for exactly this problem.


chore(ci): rollback codecov to v3

✔ Checklist:

[ ] Commit messages have been written in Conventional Commits format;
[ ] Tests for the changes have been added (for bug fixes / features).

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f19e730) 93.96% compared to head (066c1c3) 93.99%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
+ Coverage   93.96%   93.99%   +0.03%
==========================================
  Files          13       12       -1
  Lines         646      633      -13
==========================================
- Hits          607      595      -12
+ Misses         39       38       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Text spills outside of example block boundaries

This rarely happens, but there are certain example blocks as well as code blocks that the outter colored box gets cut off. I don't know why. It's definitely not something that happens a lot but have about 3 examples in my 149 page paper of it.
. Modify the _/etc/sysconfig/iptables_ file and accept traffic on port 8080.
A snippet of the _/etc/sysconfig/iptables_ file is shown below.
+
====
[ ... Output Abbreviated ... ] +
-A INPUT -p udp -m multiport --ports 69 -m comment --comment "69 accept - tftp" -j ACCEPT +
-A INPUT -p tcp -m multiport --ports 80 -m comment --comment "80 accept - apache" -j ACCEPT +
-A INPUT -p tcp -m multiport --ports 8080 -m comment --comment "8080 accept - apache" -j ACCEPT +
[ ... Output Abbreviated ... ] +
====
+

Similar bug now with code block
. Install Ceph to the Ceph OSD nodes and the Ceph monitor nodes via the following command:
+
[subs=+quotes]
----
# **for HOST in ctrl{1,2,3} osd{1,2,3,4}; do ceph-deploy install $HOST; done**

[ ... Output Abbreviated ... ]

[mac90b11c0947f1][DEBUG ] Complete!
[mac90b11c0947f1][INFO  ] Running command: ceph --version
[mac90b11c0947f1][DEBUG ] ceph version 0.80.8 (69eaad7f8308f21573c604f121956e64679a52a7)

[ ... Output Abbreviated ... ]
----

Output:

I'm very surprised this is happening, which means I'm very interested to discover what's going on :)

I know why this happens, and I remember thinking that this was going to be a problem recently while source diving. The dry run is not taking into account the left margin, so it is calculating the width of the box as if it has the full width of the page available to lay it out. However, these blocks are inside a list item, so they are indented. The dry run needs to take this into account so that it is mimicking the layout constraints (bounds) in the main document.

On a code block that spans across multiple pages, at the last page, the text is spilling out. I have about 3 examples of code blocks that span multi pages and its having the same behavior.
Output:

This is using the latest dev not alpha8 FYI.

Can you post the full text of one of those code blocks so that I can test it?

Tested on alpha8 and still see it. Try this output from rhel-osp-installer that cuts off the end.
Output:

----
Please select NIC on which you want provisioning enabled:
1. em1
2. em2
3. em3
4. em4
5. p1p1
6. p1p2
?  2
Networking setup:
       Network interface: 'em2'
              IP address: '<IP_ADDRESS>'
            Network mask: '<IP_ADDRESS>'
         Network address: '<IP_ADDRESS>'
            Host Gateway: '<IP_ADDRESS>'
        DHCP range start: '<IP_ADDRESS>'
          DHCP range end: '<IP_ADDRESS>'
            DHCP Gateway: '<IP_ADDRESS>'
           DNS forwarder: '<IP_ADDRESS>'
                  Domain: 'sbu.lab.eng.bos.redhat.com'
           NTP sync host: '0.rhel.pool.ntp.org'
                Timezone: 'America/New_York'
Configure networking on this machine: \u2713
Configure firewall on this machine: \u2713

The installer can configure the networking and firewall rules on this machine with the above configuration. Default values are populated from the this machine's existing networking configuration.

If you DO NOT want to configure networking please set 'Configure networking on this machine' to No before proceeding. Do this by selecting option 'Do not configure networking' from the list below.

How would you like to proceed?:
1. Proceed with the above values
2. Change Network interface
3. Change IP address
4. Change Network mask
5. Change Network address
6. Change Host Gateway
7. Change DHCP range start
8. Change DHCP range end
9. Change DHCP Gateway
10. Change DNS forwarder
11. Change Domain
12. Change NTP sync host
13. Change Timezone
14. Do not configure networking
15. Do not configure firewall
16. Cancel Installation
12
Enter a list of NTP hosts, separated by commas. First in the list will be the default.
clock.corp.redhat.com
Networking setup:
       Network interface: 'em2'
              IP address: '<IP_ADDRESS>'
            Network mask: '<IP_ADDRESS>'
         Network address: '<IP_ADDRESS>'
            Host Gateway: '<IP_ADDRESS>'
        DHCP range start: '<IP_ADDRESS>'
          DHCP range end: '<IP_ADDRESS>'
            DHCP Gateway: '<IP_ADDRESS>'
           DNS forwarder: '<IP_ADDRESS>'
                  Domain: 'sbu.lab.eng.bos.redhat.com'
           NTP sync host: 'clock.corp.redhat.com'
                Timezone: 'America/New_York'
Configure networking on this machine: \u2713
Configure firewall on this machine: \u2713

The installer can configure the networking and firewall rules on this machine with the above configuration. Default values are populated from the this machine's existing networking configuration.

If you DO NOT want to configure networking please set 'Configure networking on this machine' to No before proceeding. Do this by selecting option 'Do not configure networking' from the list below.

How would you like to proceed?:
1. Proceed with the above values
2. Change Network interface
3. Change IP address
4. Change Network mask
5. Change Network address
6. Change Host Gateway
7. Change DHCP range start
8. Change DHCP range end
9. Change DHCP Gateway
10. Change DNS forwarder
11. Change Domain
12. Change NTP sync host
13. Change Timezone
14. Do not configure networking
15. Do not configure firewall
16. Cancel Installation
1
Configure client authentication
          SSH public key: ''
           Root password: '*******************************************'

Please set a default root password for newly provisioned machines. If you choose not to set a password, it will be generated randomly. The password must be a minimum of 8 characters. You can also set a public ssh key which will be deployed to newly provisioned machines.

How would you like to proceed?:
1. Proceed with the above values
2. Change SSH public key
3. Change Root password
4. Toggle Root password visibility
2
You may either use a path to your public key file or enter the whole key (including type and comment)
file or key
ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDLp0tqdJTMn9nWw4m4b5ovPhJ73LGzO81A37k2MzKFzw/3wre/DWUMwNjDBlRWgpl/9WuowuEBkK41Wz7PirBGnjxreSBR0lLumeRQql43OwYig1Iu6Y7FacAIDsJusKti76y2JkUa5B6M+PCJvDBeixtHCFgmf6rSqz54AvnXzGBb7lR2cywkvAM+vMyKKFw9SkxKAKy+TnFCq+P2HWAbsuGKrjcZw9YeBSBwPH2k9S7KHcGCt/Kjv7P6/cHKrD68i3i1luiHwFyqipzdFtgqfUBnwzoQa9sl7Jh4ioBBFIOLy6lIOIMFDmr3TCVFit8lGWyv7TuhAwVhYCq3s043<EMAIL_ADDRESS>Configure client authentication
          SSH public key: 'ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDLp0tqdJTMn9nWw4m4b5ovPhJ73LGzO81A37k2MzKFzw/3wre/DWUMwNjDBlRWgpl/9WuowuEBkK41Wz7PirBGnjxreSBR0lLumeRQql43OwYig1Iu6Y7FacAIDsJusKti76y2JkUa5B6M+PCJvDBeixtHCFgmf6rSqz54AvnXzGBb7lR2cywkvAM+vMyKKFw9SkxKAKy+TnFCq+P2HWAbsuGKrjcZw9YeBSBwPH2k9S7KHcGCt/Kjv7P6/cHKrD68i3i1luiHwFyqipzdFtgqfUBnwzoQa9sl7Jh4ioBBFIOLy6lIOIMFDmr3TCVFit8lGWyv7TuhAwVhYCq3s043<EMAIL_ADDRESS>           Root password: '*******************************************'

Please set a default root password for newly provisioned machines. If you choose not to set a password, it will be generated randomly. The password must be a minimum of 8 characters. You can also set a public ssh key which will be deployed to newly provisioned machines.

How would you like to proceed?:
1. Proceed with the above values
2. Change SSH public key
3. Change Root password
4. Toggle Root password visibility
3
new value for root password
********
enter new root password again to confirm
********
Configure client authentication
          SSH public key: 'ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDLp0tqdJTMn9nWw4m4b5ovPhJ73LGzO81A37k2MzKFzw/3wre/DWUMwNjDBlRWgpl/9WuowuEBkK41Wz7PirBGnjxreSBR0lLumeRQql43OwYig1Iu6Y7FacAIDsJusKti76y2JkUa5B6M+PCJvDBeixtHCFgmf6rSqz54AvnXzGBb7lR2cywkvAM+vMyKKFw9SkxKAKy+TnFCq+P2HWAbsuGKrjcZw9YeBSBwPH2k9S7KHcGCt/Kjv7P6/cHKrD68i3i1luiHwFyqipzdFtgqfUBnwzoQa9sl7Jh4ioBBFIOLy6lIOIMFDmr3TCVFit8lGWyv7TuhAwVhYCq3s043<EMAIL_ADDRESS>           Root password: '********'

Please set a default root password for newly provisioned machines. If you choose not to set a password, it will be generated randomly. The password must be a minimum of 8 characters. You can also set a public ssh key which will be deployed to newly provisioned machines.

How would you like to proceed?:
1. Proceed with the above values
2. Change SSH public key
3. Change Root password
4. Toggle Root password visibility
1
Starting networking setup
Networking setup has finished
Installing             +hoste: /allge[mapostgresgresql::<IP_ADDRESS>/0onfig/Preject]                [77%] [.........................]
Installing             Done                                               [100%] [...........................................]
Starting configuration...
Redirecting to /bin/systemctl stop  puppet.service
Redirecting to /bin/systemctl start  puppet.service

Now you should configure installation media which will be used for provisioning.
Note that if you don't configure it properly, host provisioning won't work until you configure installation media manually.

Enter RHEL repo path:
1. Set RHEL repo path (http or https URL): http://
2. Proceed with configuration
3. Skip this step (provisioning won't work)
1
Path: http://gprfc001.sbu.lab.eng.bos.redhat.com:8080/rhel7/

Enter RHEL repo path:
1. Set RHEL repo path (http or https URL): http://gprfc001.sbu.lab.eng.bos.redhat.com:8080/rhel7/
2. Proceed with configuration
3. Skip this step (provisioning won't work)
2

Enter your subscription manager credentials:
1. Subscription manager username:
2. Subscription manager password:
3. Comma or Space separated repositories: rhel-7-server-rpms rhel-7-server-openstack-6.0-rpms rhel-7-server-openstack-6.0-installer-rpms rhel-ha-for-rhel-7-server-rpms rhel-7-server-rh-common-rpms
4. Subscription manager pool (recommended):
5. Subscription manager proxy hostname:
6. Subscription manager proxy port:
7. Subscription manager proxy username:
8. Subscription manager proxy password:
9. Proceed with configuration
10.  Subscription manager username:        <username>
2. Subscription manager password:
3. Comma or Space separated repositories: rhel-7-server-rpms rhel-7-server-openstack-6.0-rpms rhel-7-server-openstack-6.0-installer-rpms rhel-ha-for-rhel-7-server-rpms rhel-7-server-rh-common-rpms
4. Subscription manager pool (recommended):
5. Subscription manager proxy hostname:
6. Subscription manager proxy port:
7. Subscription manager proxy username:
8. Subscription manager proxy password:
9. Proceed with configuration
10. Skip this step (provisioning won't subscribe your machines)
2
Password: *******

Enter your subscription manager credentials:
1. Subscription manager username:        <username>
2. Subscription manager password:        *******
3. Comma or Space separated repositories: rhel-7-server-rpms rhel-7-server-openstack-6.0-rpms rhel-7-server-openstack-6.0-installer-rpms rhel-ha-for-rhel-7-server-rpms rhel-7-server-rh-common-rpms
4. Subscription manager pool (recommended):
5. Subscription manager proxy hostname:
6. Subscription manager proxy port:
7. Subscription manager proxy username:
8. Subscription manager proxy password:
9. Proceed with configuration
10. Skip this step (provisioning won't subscribe your machines)
4
Pool: 8a85f9814bfa3a50014c234c0eca3812

Enter your subscription manager credentials:
1. Subscription manager username:        <username>
2. Subscription manager password:        *******
3. Comma or Space separated repositories: rhel-7-server-rpms rhel-7-server-openstack-6.0-rpms rhel-7-server-openstack-6.0-installer-rpms rhel-ha-for-rhel-7-server-rpms rhel-7-server-rh-common-rpms
4. Subscription manager pool (recommended): 8a85f9814bfa3a50014c234c0eca3812
5. Subscription manager proxy hostname:
6. Subscription manager proxy port:
7. Subscription manager proxy username:
8. Subscription manager proxy password:
9. Proceed with configuration
10. Skip this step (provisioning won't subscribe your machines)
9
Starting to seed provisioning data
Use 'base_RedHat_7' hostgroup for provisioning
  Success!
  * Foreman is running at https://gprfc001.sbu.lab.eng.bos.redhat.com
      Initial credentials are admin / YXikgFQmfG79K6SD
  * Foreman Proxy is running at https://gprfc001.sbu.lab.eng.bos.redhat.com:8443
  * Puppetmaster is running at port 8140
  The full log is at /var/log/rhel-osp-installer/rhel-osp-installer.log
----
```

Okay, I'm seeing this same problem on my side. I have a strong feeling what the root cause is. I'll get to the bottom of it.

Yep. I see it. The margins are messed up on subsequent pages during the dry run, which makes the overall height calculation incorrect. Fix on the way.


Improve autoformatting docs

As many others:

#191
#317

I had problems understanding when autoformatting is truly applied with the config file present.

A comment by @vadimshvetsov received > 50 👍🏼, which I think is an indicator for the information people are seeking. Hence, I'm proposing to add his comment in slightly edited form to the readme.md.

Please can we have a merge :heart: ? I would have saved a good 15min and some sanity :wink:


Community Outreach

This issue is dedicated to the documentation of all outreach efforts leading up to Kingston on January the 11th.

York University:
Yesterday, December the 2nd
Nuts Galore and the rest of the robotics class embarked on a trip to York Universities' Markham campus. We were invited to view the upcoming technology innovations being implemented at the University. This trip would serve as a learning opportunity as mentors showed us what we could do with the skills and knowledge gained through FIRST in the future. Upon arrival we were shown to a main lounge where we observed a makerspace class selling various products of their making. We then started a guided tour where we saw things such as the many lounges for student use, study room, vending machines, lecture halls and the 'Libraries' custom rooms; where you can ask the library to setup custom equipment for your various needs. We concluded the tour by checking out the gaming and workshop rooms, where you can either check out programs on a tv the size of a wall or play games to de-stress. The workshop allows anyone to obtain the necessary equipment and materials needed to build whatever their heart desires. After, that we went down to the main lounge again to view the winner announcements of the makers fair. With that we concluded our trip and returned back to St. Augustine via school bus. We would like to thank York University for their gracious hospitality and the opportunity for mentorship.


incorrect terminology

changed 'network security groups' to 'application security groups'

@jimdial - Please review the proposed changes.  Thanks

@CHDAFNI-MSFT Thanks for catching. I incorporated your change with some other required changes in this PR.
#please-close


add new chart for steamcmd

Details
Helm chart name:
steamcmd

Describe the solution you'd like:
implement a chart that can deploy steamcmd resources to cluster, remaining game agnostic. this would allow anyone to use steamcmd to host game servers that are supported by steamcmd.
i'm open to tackling this myself. this issue can just be for tracking.

Anything else you would like to add:
due to limitations with game hosting, this may not qualify for using a multi-arch image. i'll defer to the multi-arch powers that be for supporting that use case.

Additional Information:

see the steamcmd project here: https://github.com/steamcmd/docker

This looks juicy

the farther i'm getting into this, the more i'm realizing why nobody has done it yet

work is being performed in https://github.com/crutonjohn/charts/tree/add-chart-steamcmd
just gave it my initial commit

I've a different idea about this...
A lot of gameservers don't just use steamcmd and require additional tools.
Why not integrate SteamCMD into the common chart, just like some other addons?
That way people could start building gameservers using the common chart and attach the addon for steamCMD to streamline the process.

I've a different idea about this...
A lot of gameservers don't just use steamcmd and require additional tools.
Why not integrate SteamCMD into the common chart, just like some other addons?
That way people could start building gameservers using the common chart and attach the addon for steamCMD to streamline the process.

ultimately, i'm not sure what's best.
if you approach it from the standpoint that it is like an add-on, you take on the burden of trying to "standardize" (for lack of a better term) lots of other varying game server types.
the one nice thing about steamcmd is that it's already an established platform that is meant for running and updating Steam dedicated servers. there's no guarantee that whatever we come up with as a solution would be extensible to, or compatible with, other game server types.
i'm all for supporting as many use cases as possible, but extending the functionality of this chart to be a catch-all for any type of game server seems like a bit of a stretch.

Almost every decent gameserver uses a server manager AND steam CMD, not just steamcmd. Als by adding steamcmd as a common chart addon you are making it possible to customise. Your solution is the one thats hard to customise.
i dont think you understand what I meant with addon and common chart. Please read into it.

Taking the holiday break to work through this 😬


Fountains shold not need to be connected to anything

Yeah, title pretty much says it all. It seems very unreasonable to give an error for this, no?

Have you checked the raw tags of the fountain? (Alternatively can you link to this location?)

Ah. Huh. Thanks :)

Could there be a system to stop this from happening? I did not make this fountain, it was already there, I just fixed it up a bit. Maybe someone made it first as a footpath and then someone else changed it to a fountain? (Makes sense, since the footpaths towards it was connected to it when I found it. Could mutually exclusive tags be dropped automatically when a tag is changed? Or at least a warning be shown ("This element is tagged as a footpath, are you sure you want to make it into something completely different? Would you then like to remove the footpath tag?"

Could there be a system to stop this from happening?

Theoretically, yes, but I'm afraid that determining what tags can coexist with other tags would be a never-ending task fraught with controversy. I'm inclined to leave it alone considering this type of issue looks to be relatively uncommon.

Maybe someone made it first as a footpath and then someone else changed it to a fountain?

If someone did this with iD's preset switcher than the footpath tag would be removed automatically. If they used the raw tag editor then we assume they're being intentional. We can't control what other editors do.


Feature/osx mediakey support

Closes #2
@xeratun OSX media key support has been added.  When you have a hot minute can you double check that there is no negative effect on Windows?
Also made a few tweaks, added some keyboard shortcuts for DevTools and Quit from the menu and updated the README.md.
If everything looks good we can merge into master 👍

Looks like it's all working fine for me still. So this should be fairly complete. The only issue I never got around to is the media keys only work when the Window is in focus, which isn't as helpful. I briefly looked into doing it in the background in the past but it seemed much harder. I'm going to merge this in though.


sandbox for additional wiki images

as Github Wikis can't store images anymore, I'll upload them here as recommended by Github

WaveWatch screenshot, showing an electron-detector pulse

Web GUI showing an electron-detector pulse:

from Science Days Digital Workshop 2020 in collaboration with @CERN and @FabLabMuc, pictures taken by @GigaBecquerel


Certificate store Local Machine causes deadlock

Setting both stores to Local Machine causes a deadlock on the call to makecert. I can step through and see it calling tcs.SetResult, but the await never continues in ProxyServer.cs. Switching MyStore back to Current User fixed the issue, but for the life of me, I don't see why it's deadlocking there with MyStore set to Local Machine. Any idea why?

Have to investigate. I am in the middle of a move, sorry for not being involved as I used to.

This has been resolved as soon as pull request #123 is merged in as it replaces makecert with certenroll


Regarding the coding commenting for the particular file(It is not an issue,It is just a advice for the enhancement in the repo)

I am new to the PDFViewer ,then i found your repo,which is very good and neat code written.But i didn't know why some files have written and some function has to be made.
So I think proper code commenting should be done so that our code will be easily understandable to the beginners in this task.Rest you have done very good work.

Hi Abinhadan,
thanks for your support & kind words :) Comments in code are a very interesting point for discussion. I prefer to keep my code as self-explanatory as possible, and leave it without comments that may not be maintaned in the future and can propagate misleading information. There is a very interesting chapter about this in Clean code.
As you very well said, there are classes or methods that may not be as self-explanatory as I'd like, so feel free to ask any functionality that you don't understand. I'll try to give you deeper information about how it works, or what I tried to do when I developed it.


which OPUS version and which configuration used

Hi,
I am trying to reproduce the results which is in the paper
and I am using opus version 1.3 but when I transcoded the audio I get a distortion like this figure and I couldn't reproduce the results, is this distortion is normal with opus 6kb/s with wideband?

and I have another question, why the range changed and the signal level go beyond 1 and -1?

I would help is you could:

state which aspect of which paper you're trying to replicate
provide more info on what you did exactly, what results you got, and what you expected instead?


Sorry, this solution is not quite right

$ githug
********************************************************************************
*                                    Githug                                    *
********************************************************************************
Sorry, this solution is not quite right!

Name: init
Level: 1
Difficulty: *

A new directory, `git_hug`, has been created; initialize an empty repository in it.

Did you initialize a git repository inside the git_hug directory?

@Gazler Thanks, I make it by git init finally.


CARDS-2070 - Patient portal: the "Close" button on the last page is confusing

Specs:

CARDS-2070 - Patient portal: the "Close" button on the last page is confusing

Testing

In both prems and proms:

before clicking on "submit my answers", open the network tab and check that a request is being made to /system/sling/logout
check that the last screen "Thank you..." is displayed correctly and does not have a "Close" button

for proms check that the interpretations are displayed

after submission, in the address bar enter a new address to the app (e.g. /content.html/admin/Questionnaires) and check that the login screen is being displayed as opposed to the "go to surveys" error page
return to the same survey address as before (as patient) - check the screen being displayed when there are no surveys to be filled out

PROMS screenshots dev vs 2070:

PREMS screenshots dev vs 2070:

The logout still doesn't work properly due to multiple concurrent requests. I looked a bit into that, the root issue seems to be some always-executed effect from the "change subject" button. Two things to improve here: fix the effect to not execute so often, and maybe find a way to not have this at all in the patient UI, since the patient definitely cannot do that. I think it's enough to add a condition on !disableHeader before rendering the change subject dialog.

#1326


PropertyPaneDropdown 'selectedKey' option does not set the value of the control

Category

[ ] Question
[ ] Typo
[x] Bug
[ ] Additional article idea

Expected or Desired Behavior
When a PropertyPaneDropdown is defined in the property pane configuration with a specific "selectedKey" option, the control in the property pane should actually have the selectedKey as the value of the control; instead, while it is showing the associated text for the selectedKey in the display, the control does not show the selected item as the actual value of the control.  We need to be able to set a default value for property pane drop down controls that can be used in code even if the property has never been changed by the user.
Observed Behavior
After adding a dropdown with a default selectedKey to the property pane like this:

I added an extra element to the UI to display the value of the dropdown like this:

When I run the web part in the Workbench and open the property pane, I can see that the value of the Description property is displayed in the web part UI and the value of the Icon Set property is not, even though it looks like it is selected in the property pane UI, like so:

When I change the text for the Description property and click the "Apply" button, the text for the Description changes in the UI but the value of the drop down still does not, even though in the property pane UI it appears to be selected:

When I change the selected item in the property pane dropdown and click the "Apply" button again, I can now see that the value of the dropdown control in the property pane is available to the code in the web part UI.

Steps to Reproduce

Create a new web part with the yeoman generator
Add a dropdown to the web part properties configuration, with one of the options as the 'selectedKey'
Add an element to the web part UI to display the value of the dropdown property
Test the web part in the Workbench to see where the value of the dropdown property is and is not available to the code in the web part UI.

Hi, @acksoft - In the code, you are trying to access the iconset value from the properties bag. However, you did not update the properties bag with that value nor you have made any changes to that control on the property pane for that value to be reflected in the property bag.
Today, for consistency sake we do not want to update the property bag with the default values supplied by the user. Property pane mutates the property bag only when there is some end user action on the property pane.
Instead, I would suggest you update the property bag to reflect the default value for that target property.
I am closing the issue now, but feel free to re-open if you are not satisfied with the answer and let me know if you have any more questions in this regard.
Thanks,
Srikanth

Srikanth,
Please do not take offense, but this answer is completely unacceptable and does a poor job of understanding the perspective of the developers who are using this product.
You say to me "you are trying to access the iconset value from the properties bag...for consistency sake we do not want to update the property bag with the default values supplied by the user." But NO that is not what I am doing. I may, behind the scenes and without my knowledge be doing that (you would know better than I), but what I am actually doing is defining a set of options for a pulldown control and setting the "selected" option on the control that represents that property in my user interface.
Let me be clear: I do not care about your property bag, whatever that may be, or what you may have to do to keep it "consistent."  That is an internal engineering detail that has no relevance to developers who will be writing web parts with the SharePoint Framework.
From our perspective, this is exactly the same problem as #758 ("PropertyPaneToggle 'checked' option is being ignored") which is now marked as "fixed":

We define a property in our code
We set it's options in our code
We have the expectation that those options are respected and are returned to us when we try to make use of them

You say "Property pane mutates the property bag only when there is some end user action on the property pane." As I said, you may be using this magical property bag, but I have no reason to care about it.  And as far as I am concerned, defining which option in the control is the "selected" one is an action: defining which option in the list is "selected" is not required, so I must be doing something to make it the selected option.  That is the action.
Please re-open this item and get this fixed.  If I cannot define properties for the web part and have them returned to me when I need them in my web part, they are of no use to me.
Thanks,
Joseph

Hello Joseph,
I understand your confusion here. I apologize for not making few things clear in my earlier response.

By property bag, I meant the properties section in the preconfiguredEntries of your web part's manifest file. You are totally right in saying that external people wouldn't understand the terminology we use internally and I will be clear here after.
When I said property pane does not mutate the property bag unless the user makes a change in the property pane's GUI what I meant is the moment we change/update the property bag( your web part's properties) it might have uncalled for effects on the web part. On top of that, most web parts wouldn't want their properties to be mutated by the framework.
When I said I would suggest you update the property bag to reflect the default value for that target property I was asking you to update your web part's properties with the default value for the associated property.
There are two ways you can achieve this:

In your web part you can say -  this.properties.<nameOfTheProperty> = <value> or
if you know the default value before hand you can also directly edit in the web part's manifest.

I know this results in you updating two times, one for the properties and the other in the actual group field, but this will resolve your problem.
Just so you know, if you update the properties, you need NOT update the group field but not the vice versa.
Please let me know if it is still not clear and you have any questions around this, I am more than willing to help and resolve your issue.
I am re-opening the issue now, and we will close it only when you are unblocked.
Thanks for your patience,
Srikanth

By property bag, I meant the properties section in the preconfiguredEntries of your web part's manifest file.

Okay, now we are getting somewhere -- thank you for clarifying the terminology. I truly appreciate you getting back to me in a timely fashion and taking my concerns seriously.

the moment we change/update the property bag (your web part's properties) it might have uncalled for effects on the web part. On top of that, web parts, in general, wouldn't want their properties to be mutated by the framework.

If by 'we' you mean you mean the framework itself, then your basic premise is flawed and this should be a non-issue.  It is not the framework that is changing (or as you say 'mutating') the property, it is the definition of the group configuration that is changing the value of the property and that is a change made by the programmer, not the framework. If it helps conceptually, think of the framework as merely carrying out the change as ordered by the programmer, not as a change made by the framework.

There are two ways you can achieve this...{snip}...I know this results in you updating two times, one for the properties and the other in the actual group field, but this will resolve your problem.

I am very happy to know that this is a usable work-around solution (it will allow me to keep moving forward with my project), however this does not actually solve the LONG TERM problem: I will not be the only person who runs into this issue and many man-hours of frustration and lost productivity will be the result.  Even if you document this very thoroughly and publicly in the SPFx Guidance, it is still going to be perceived as a kludge by developers.  If setting the selectedKey option of the PropertyPaneDropdown() function does not have any effect on the way the control is created at runtime, what purpose does it serve?  Why is it even there if it actually does nothing?
I very strongly suggest that you either:

remove the option and provide very visible and obvious guidance regarding defining the default value of  the property in the manifest OR
do the work it takes to make it work the way it looks like it is supposed to

Thank you again for your time, help and attention.  While I can now move forward, it is only because of this bit of 'tribal knowledge' that you have passed on to me, and ultimately should be more permanently fixed.

@acksoft - Thanks for the feedback. We have had a discussion on this and we have decided to include this feature as well. This will be fixed as a bug. Once it is fixed I will update this thread.
Thanks!

Is this bug has fixed?

@ongun23 I still have the issue, so no. Lost more than 1h around this until I arrived at this page

does anyone have a workaround? there must be...

@jm06 this is working as it should according to the comments above. You should add the default value in json manifest of your webpart. This is the only source of truth for default values.
Code:
PropertyPaneDropdown('presentationType', {
                  label: strings.presentationTypeLabel,
                  options: [{
                    key: 'standard',
                    text: strings.presentationTypeStandard
                  },
                  {
                    key: 'variable',
                    text: strings.presentationTypeVariable,
                  }
                  ]
                }),

JSON:
"properties": {
      "presentationType": "standard",
      "presentationCount": "3"
    }

Thank you for that.
My issue is to do with the onChange and mainly capturing/exploiting the selectedItem key/text from a react propertypane DropdownOption ('office-ui-fabric-react/lib/components/Dropdown' )? Any reference, piece of code you can suggest ?

Thank you for that.
My issue is to do with the onChange and mainly capturing/exploiting the selectedItem key/text from a react propertypane DropdownOption ('office-ui-fabric-react/lib/components/Dropdown' )? Any reference, piece of code you can suggest ?

PropertyPaneDropdown is not from office-ui-fabric-react project. I don't think there is an onChange for PropertyPaneDropdown.
You could build your own property pane control that will use 'office-ui-fabric-react/lib/components/Dropdown' and access that https://docs.microsoft.com/en-us/sharepoint/dev/spfx/web-parts/guidance/build-custom-property-pane-controls
If your goal is to simply build a cascading dropdowns on properties you can follow this documentation: https://docs.microsoft.com/en-us/sharepoint/dev/spfx/web-parts/guidance/use-cascading-dropdowns-in-web-part-properties
Either way, it has nothing to do with this opened issue.

I will take another look at those examples.  I started with those but I am missing a point somewhere and that is where I am looking for guidance.
Would there be a more relevant issue I could find the solution I am looking for?
Your intervention most welcome and appreciated.

To sum up this discussion.
Default values for the properties are specified in Web Part's manifest.
These values will be automatically available in this.properties property of the web part.
You can set selectedKey of the Property dropdown based on the value from this.properties.
If the value has been changed in the property pane, it will be populated to the this.properties.
Closing this one as there is no issue, the described functionality is 'by-design'.