Low-level API

We don't do deserialization (yet; our goal is to sign a transaction) but we should improve APIs for type Transaction in clarity.
Right now it does basic (unverified) serialization, contains basic parameters (as explained in The Yellow Paper).
We can, however, do some validation of the TX parameters against constants etc.
TODO:

[x] Verify TX params against constants
[x] Add support for "Unsigned/Signed" transactions (i.e. "vrs" params indicates that the TX is signed, creating a Transaction object would create Unsigned tx by default) (via 0594bf9dbe5141a7f5e1b0f27f3f34b813286769)

#9
Resources
https://github.com/ethereum/pyethereum/blob/develop/ethereum/transactions.py

I'm closing it because we're at the stage of verifying implementation against etheremu test suite, so this implies that we have sort-of usable API to create, and sign transactions already.


Add ETH account detail home

This task covers displaying the Account Details page after clicking on the ETH account card on the dashboard.
The transaction list will be covered within separate task.

LGTM.
One minor thing, I think it's worth to change text on Send modal from tokens to ETH:

Also, Idk if it's in scope, but will we add https://etherscan.io/ redirection instead of 404 page?
https://github.com/superhero-com/superhero-wallet/assets/69896204/09c3c532-392c-4da4-95a5-ceebdfb6ce9a

I have rebased this branch with our main branch changes. So I think this needs another round of testing.

LGTM


Updated README.md

Please don't create spam PRs for Hacktoberfest, it's against the rules and values, and not fair on maintainers.
https://hacktoberfest.digitalocean.com/details#spam
Maintainers: please label this invalid so it's not counted towards Hacktoberfest.


New Contributor- MaryHBW of Counter Culture Labs

!!DELETE THIS TEMPLATE AFTER READING
Before submitting an Issue

Avoid making duplicates: You can :+1: vote for an existing issue
Organize new issues: Members should organize tickets and apply labels

Follow steps of each type of issue

[ ] request to be a member title: 'Membership request'. description: a bit about yourself (optional)
[ ] report error/problem in an webpage title: name of webpage description: describe the problem, or error and what it should be instead.
[ ] report broken link title: 'Broken link'. description: where you encountered the broken link
[ ] report a bug description: describe the problem, how you encountered it and what you expected instead. Provide screenshots and screencaptures if possible
[ ] make a suggestion description: describe your idea, how it should work and look like. Provide examples and references.
[ ] ask a question title: include a '?'. Or ask questions in Gitter, or Slack, you can directly message users in either. Check our FAQs too.

Hi @maryhbw! I just sent you an invitation! great to have you


Ppromania - The message " Ilfov- Prahova is not a city in Romania" is displayed instead of the job locations

ENVIRONMENT: production
URL: https://scrapers.peviitor.ro
Browser: Chrome
Device: Laptop
OS: Windows 10
STEPS TO REPRODUCE:

Open the URL in the browser
Search for "Ppromania  " Company
Open "Careers" button
Open " See jobs" button
Check the job locations.

EXPECTED RESULTS:
Job locations are the same in Scrapers-UI as on the company website.
ACTUAL RESULTS:
The message " Ilfov- Prahova  is not a city in Romania" is displayed instead of the job locations.
ATTACHMENTS:

Fixed can you retest? Please ignore where it's mentioned "all is not a city in Romania" as this will work in the future update!

Re-tested, Job locations are the same in Scrapers-UI as on the company website.


Add S3Event

This PR adds case classes and json-decoders for S3Event. This allows S3 to trigger the lambda function as described here.

Hello, I am trying to use this event in my Scala.js project but it is telling me that the import doesn't exist.
I am comparing this PR to https://github.com/typelevel/feral/pull/231/ and I wonder if this Event is missing the changes in
lambda/shared/src/main/scala-2/feral/lambda/package.scala
(and maybe also scala-3/feral/lambda/envs.scala)
because my Scala.js version is using Scala 2.12
I am not sure though, because this is my first time encountering this kind of issue.


How to pass back a value

I am trying to make an old IE form work with a showModalDialog.  This worked well with IE.   I have a modal form that, based on a selected criteria, makes a request to a database for a primary key.
I can't figure out how to pass that value back to the parent form.  I figure I have to stuff it somewhere but in the original code it was done with "window.returnValue = key;". This does not work with the polyfill.  Any help would be appreciated.  I am thinking the polyfill should be a direct replacement for the old IE showModalDialog.
Parent form:
(function() {
pParty = window.showModalDialog("../Search.htm", "SearchParty", "resizable:yes;status:no;dialogHeight:550px;dialogWidth:600px");
})();
Dialog prior to clicking on close button:
var arr = new Array(getHTMLText(mRow.cells[1]), getHTMLText(mRow.cells[2]), getHTMLText(mRow.cells[3]));
window.returnValue = arr;

PS:  I am using Chrome browser.


image glitch when using Rpib+ RTP source

Simply modify video-viewer from jetson code and publish image with local ROS time stamp.
And I got image glitch compared to jetson program. I'm NOT sure what caused issue, any help is well appreciated.
Your environment

OS Version: Ubuntu 20.04.6 LTS
Hardware: Jetson Orin Nano 8GB
ROS Distro: [Noetic]
RViz$ cat /etc/os-release
NAME="Ubuntu"
VERSION="20.04.6 LTS (Focal Fossa)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 20.04.6 LTS"
VERSION_ID="20.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=focal
UBUNTU_CODENAME=focal

Here is my test video sj1NJsEtm9Q
Here is my test code uav_camera.cpp
Jetson's code is OK. There are quite a lot of glitches in rviz.
Anyone knows why?

This question should be better asked at https://answers.ros.org. Please, post real issues and bug reports here only.
I don't think this is a real rviz issue, but I couldn't spot an obvious issue in your code either.


added : testcode

It doesn't resolve #47
added /api/users/login,register,:id test code
used JEST and mongo-memory-server for fake DB server

it changes api URI too.
https://github.com/jinwoo1225/Tutor2Tutee-Advanced/issues/4#issuecomment-888124187


Config missing trait implementations

I think Config should implement Copy, Clone, PartialEq, Eq, and Default.

Closing since Config is deprecated as of #310. The new system implements Copy, Clone, and Default. Since its a type-based system implementing PartialEq and Eq wouldn't make sense.


Feature voronoi 3d

Hi Dr. Najian,
In this PR class voronoi control 3D was implemented plus some associated functions were updated.
Kind regards,

This PR is addressed in PR #16.


Did not help :-(

Hi
I made a simple dot.net 7.0 api and a simple Angular front end and got a CORS error when tying to envoke the dot.net api from Angular. I was looking for something simple to tell me how to implement CORS in VS 2022. This maybe a good article but I could not find simple steps stating what to do and at what file.
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 59bca5db-1196-2a8b-a0d8-4e89b2382288
Version Independent ID: d3f332c4-4c60-039e-0e1e-bc6b11831f87
Content: Enable Cross-Origin Requests (CORS) in ASP.NET Core
Content Source: aspnetcore/security/cors.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Hello! Thanks for contacting us. This sounds like a general question about using ASP.NET Core. While we try to look at and respond to all issues, for questions like this we recommend posting to a community support group like Stack Overflow with the asp.net-core tag.

Stack Overflow
ASP.NET Core Slack
ASP.NET Gitter

Potential bugs in the ASP.NET Core framework and product feedback can be reported at dotnet/aspnetcore issues (include full repro steps and cross-link to a repro project in GH when appropriate). For Visual Studio, use the Report a Problem gesture or Suggest a Feature gesture within VS, which open internal issues for the VS team. For Visual Studio Code, you can open an issue at microsoft/vscode issues.


Policyfile git detection blows up in a brand new repo

This will probably come up when people follow tutorials and skip a git commit step.
To repro:

create a new git repo, e.g., with chef generate app foo
cd into the repo, create an otherwise valid Policyfile.rb
run chef install

Output:
Error: Failed to generate Policyfile.lock
Reason: (Mixlib::ShellOut::ShellCommandFailed) Expected process to exit with [0], but received '128'
---- Begin output of git rev-parse --abbrev-ref HEAD ----
STDOUT: HEAD
STDERR: fatal: ambiguous argument 'HEAD': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
---- End output of git rev-parse --abbrev-ref HEAD ----
Ran git rev-parse --abbrev-ref HEAD returned 128

Just ran across this :)

Note that git calls this an "unborn branch"


$viewContentLoading Event no longer useful

I recently upgraded from 0.14 to 1.2. I looked at the changelog, and it seemed that it would be fine. However, whatever happened to the $viewContentLoading event renders it useless. It used to return a very useful object (viewConfig) that made it possible to see the names of views, parent views, and nested views before they were finished loading. I used this to flawlessly load my i18n translation on time. Now it just returns a useless string that is just @ most of the time and @parent when one exists. Why did it change? I tried using $stateChangeStart, but it didn't catch every view.

1.2? What version did it change in?

I'm not sure. The GitHub search tool doesn't seem to bring up anything useful when I search viewContentLoading. Also, the ES6 refactor makes the blame view useless.
Can you confirm that it is not outputting the viewConfig object anymore? It could just be my particular use of it.

We have two current releases right now. 0.2.18 is in the legacy branch while master has 1.0.0-alpha.4. I think the viewContentLoading may have changed in 1.0 (but maybe not intentionally).
Tell me what your use case is?  How do you use the event and why doesn't it work for you now?

I used it to load translation information while a page was loading (it was very smooth):
$rootScope.viewContentLoading = $rootScope.$on('$viewContentLoading', function(event, viewConfig) {
  angular.forEach(viewConfig.view.includes, (value, key) => {
    if (value && key) {
      $translatePartialLoader.addPart(key);
    }
  });
});

What I have to do now just doesn't work as well. It sometimes loads a tad late. I have to have two watch functions to make sure that my parent views are watched. Sometimes one calls and sometimes both call (having a second call doesn't actually do anything, but it's annoying). It's very messy in comparison:
$rootScope.viewContentLoading = $rootScope.$on('$viewContentLoading', function(event, viewConfig) {
  if (viewConfig.substr(1).length > 0 && viewConfig.substr(1).length !== 'logout') {
    $translatePartialLoader.addPart(viewConfig.substr(1));
  }
});

$rootScope.stateChangeStart = $rootScope.$on('$stateChangeStart', function (event, toState){
  if (toState.name.length > 0 && toState.name !== 'logout') {
    $translatePartialLoader.addPart(toState.name);
  }
});

The current output of viewContentLoading is not documented, but I sort of figured out what it is doing with Web Inspector. Later in the development of my app I plan to make a way to offload the unused translation data and having two separate functions would make this difficult.

Thanks for the summary. Can you clarify which version this issue was posted against? Neither 0.14 nor 1.2 are ui router releases.

I'm so sorry! I read the versions for UI Bootstrap in my config file (the line below). It was 0.2.15 to 0.2.18. I did a basic search and I think that the probable cause was this commit: https://github.com/angular-ui/ui-router/commit/f9b43d66833f0e17de41fd8d1cc3b491e3ba4a0e It happened in that time period and has some major changes.
During my development phase I set the patch on the semver to and asterisk. So something like 0.2.*. It's not every day that I go through Bower's cache to see what version I had (I should really keep track of that).

Found it! Looks like it was sort of deprecated...
https://github.com/angular-ui/ui-router/issues/685#issuecomment-106621834 from @metamatt:

Proposal 2: remove the existing $viewContentLoading, and just emit $viewContentLoading from updateView before the $transclude call. This might break people who depend on the current behavior, but barring an explanation I don't currently understand, this behavior makes more sense.

https://github.com/angular-ui/ui-router/issues/685#issuecomment-106976135 from @christopherthielen:

Metamatt Thanks for the analysis. I've never understood how people are using these events external to ui-router code. I think option #2 seems reasonable.

Can anyone else speak up if they are using viewContentLoading in some meaningful way and would object to proposal #2?

Later you can see that the commit was merged to the legacy branch, and the milestone was set to 0.2.16 and 1.5.0.
What should I do? I guess that I'll have to stick with my alternative half-working method. Also, please update the wiki.

Thanks for finding that.  It looks like we changed it so the loading/loaded pairs made sense.  Apparently the options object was not available where the new code triggers the event or something.  Sorry about that... I never really understood how people were using that event in a meaningful way!
In 1.0, I think you can achieve your requirement by adding a transition hook that gets the views being entered, and returning a promise to load your data.  In 1.0, the transition will wait for any promises returned from a transition hook, such as onStart.
$transitions.onStart({}, function($transition$) {
  var viewConfigs = $transition$.views();
  var includesList = viewConfigs.map(viewConfig => viewConfig.viewDecl.includes);
  return $q.all(includesList.map(/* return a promise to fetch the stuff */));
});

http://angular-ui.github.io/ui-router/1.0.0-alpha.3/interfaces/transition.ihookregistry.html#onstart
http://angular-ui.github.io/ui-router/1.0.0-alpha.3/classes/transition.transition-1.html#views

I'll close this since the new version will solve the problem. I can't upgrade to Angular 2 yet, so I'll have to stick to my alternative solution for now. Please update the expected output on the wiki example: https://github.com/angular-ui/ui-router/wiki#view-load-events
Thanks for all of your help!

Based on your  Best comment, it seems like you think the 1.0 version is only for angular 2.  Although the 1.0 version does support angular too, it also is for angular 1


Feature presets

closes #3
I think that presets is way more descriptive than strategies. I could not think of more presets that I am using on projects. Do you have any idea of other possible use cases?

This is going to be breaking. But we will add edge and TS and these features, so I think it deserves a v2.

After this and I will do the typescript rewrite, but I think that if we agree that naming it presets is a good idea, we can merge this and add more presets whenever.


(nojira) fix for http://openjdk.java.net/jeps/212; update SCM tag to 0.14.1

JavaDoc errors from java 8 generated html; still has warnings, but project builds.

72 hrs- pushing; lazy consensus


Feature Request: Add Odometer to Summary, Trips, and Stops Reports

Use case:
Legal requirements for commercially used vehicles require a vehicle log including
Start and End values for Odometer readings in most countries.
Please add

TotalDistance
Odometer
OBDOdometer
values for start and end positions to
SummaryReport
TripsReport
StopsReport

Examples:
http://www.ird.govt.nz/resources/4/7/474499e8-8e4c-47c0-ab3d-54334ab8c0f1/vehiclelogbook.xls
https://muster-vorlage.ch/fahrtenbuch-vorlage/
...

Closing as the PR is merged.


This log line is overly chatty

https://github.com/tableau/server-client-python/blob/608aa7694d0560ea3c8c37b10127b11207e56e8d/tableauserverclient/server/endpoint/endpoint.py#L53
When using server client python to download workbooks or data sources and you've got log_level=Debug, this log line ends up blowing up your logs. It outputs the hexadecimal representation of the entire file you're downloading, which is not very helpful and explodes your log size. Can we remove this line, or only log out the response contents when you're not using the endpoint to download a file?

Ideas:

We override _check_status for Workbook and DataSource endpoints that do something to deal with binary responses
We check server_response.headers['content-type'] for binary type and truncate or drop it before we log

Fixed in development @ #274


fastapi-cli: refactor to use python3Packages.fastapi-cli

Previously there were essentially two copies of the same expression in tree.
~Marking as draft until #325223 hits master (currently in staging) since otherwise fastapi-cli fails trying to import rich which was previously manually added to dependencies.~ [merged]
Description of changes
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Also, I can just add rich for now with a comment to remove after the other PR gets to master, so we don't have to wait.

Ready to go since staging-next was merged.


Add unit test on DefaultHttp2FrameReader

Motivation:
DefaultHttp2FrameReader contains the logic for how it parsed the network
traffic from http2 client,
it also validate the content is legal or not.
So keep high coverage rate on it will increase the stability of api.
Modifications:
Add unit test on DefaultHttp2FrameReader
Result:
Coverage rate increased

4.1 (72916b9)
thanks @chhsiao90 !


Claw isn't taken in account as favored weapon by deities.

Greetings! Some deities (Bastet, Sekhmet and Adanye exactly) have claws as a possible favored weapon. However, when I have a cleric with a claw attack given by an ancestry, the attack die size isn't increased (even with the Deadly Simplicity feat manually added).
Also, talking about clerics and the Deadly Simplicity feat, I think it would be great to add it automatically as a bonus feat if the cleric selects a diety with a simple or unarmed favored weapon and the warpriest doctrine.
Thanks!

Where is the claw coming from?


initial plumbing for prompting on unsigned on untrusted pacakges

motivation: allow for promp UX when desired
changes: define delegate methods to allow clients to drive prompt behavior

@swift-ci smoke test

@yim-lee


can't change meta data (img, description) for sharable website url link

Hi,
I was wondering if there is an option to change meta data so when I share the link of my website I can put my own photo and description. For now I can't change it from the photo, description etc of tris-webpack-boilerplate github page. Is it put somewhere very deep? Changing meta data in index.html and other subpages doesn't change anything.
Thank you for help, Szymon :)

It needed time to update. It works the way it should. Sorry

The problem is back. It turned out that it only worked when I share link with "https://" at the beginning. The rest: "Https://", "http://" still get all these elements from tris-webpack-boilerplate. Any suggestions? Thank you.

Hey @szymonhernik you should look at https://github.com/tr1s/tris-webpack-boilerplate/blob/26977580f2a563abed7672737053bf1372caea17/webpack.prod.js#L96-L115 as far as i understand this is what you are looking for :)


RFC: "reference" datasets

fsspec's ReferenceFileSystem allows a file system like virtual view onto chunks of bytes stored in arbitrary locations elsewhere, e.g., cloud bucket storage. We can present each byte chunk as a particular path in the filesystem conforming to the zarr hierarchy model, such that the original set of chunks, potentially across many files, appears as a single zarr dataset. This brings the following advantages:

only zarr (plus the relevant codecs) is required to read the data, but the original data could be locked in HDF5, TIFF or grib2 files (and more to come)
the metadata is extracted once, so future opening of the dataset does not need to scan through the target files to find metadata, and so the process is much faster
you get a single logical view over potentially thousands of files, but due to zarr's access model, you only load the data you need
loading can happen chunk-wise and in parallel

The details of how to make such reference files is described (and this is a work in progress) at https://github.com/intake/fsspec-reference-maker , and the latest result for some 80TB/370k files of water flow modelling can be seen at https://nbviewer.jupyter.org/gist/rsignell-usgs/02da7d9257b4b26d84d053be1af2ceeb . Note that this is using xarray to process the data, but only zarr is needed to load it. The specific procedure for making this reference file will also be published in an upcoming blog post, but here is an earlier, smaller example.

BlenderNC does support zarr files, this seems more relevant for the xarray implementation of zarr imports, rather than in this repository. Thus, I will close this issue.

this seems more relevant for the xarray implementation of zarr imports

Not at all! xarray just happens to be the most common tool for reading zarr for my geoscience-oriented colleagues. ReferenceFileSystem is general, indeed allowing reads of other file types, such as the CSV block reader currently in development.
The purpose of my project is to give zarr implementations access to non-zarr data like TIFF and HDF without having to implement/install specific readers for those file types.

BlenderNC uses xarray to read data and although a more general reader sounds interesting, there are many limitations to integrate more file formats than those supported by xarray in the current version of BlenderNC.

Fair, I get it now. In fact, I appreciate your insistence on this, it looks quite interesting, as it would allow local rendering using cloud storage, which I've been thinking to implement for a while in BlenderNC. I've reopened the issue, and I will look into implementing a node to using intake or ffspec to open cloud storage catalogs, following the examples provided.
cat = intake.open_catalog('s3://esip-qhub-public/noaa/nwm/nwm_catalog.yml')
ds = cat['nwm-reanalysis'].to_dask()

and/or
fs = fsspec.filesystem('s3', anon=True)
urls = ['s3://' + f for f in fs.glob("s3://noaa-goes16/ABI-L2-SSTF/2020/210/*/*.nc")]
dask.compute(*[dask.delayed(gen_json)(u) for u in urls])

It's not clear to me the best or cleanest way implement this, so I will appreciate any recommendation, as it will take some time for me to familiarize myself with  ffspec.

I don't know the status of your stack, but Intake and Dask might well be overkill in this case.
I would start with zarr/fsspec and one particular storage backend of interest, e.g., aiohttp for HTTP. For the cloud stores, you need additional deps: s3 (aiobotocore), gcs (google stack, aiohttp), abfs (azure-*, aiohttp).
Note that you don't need anything in fsspec-reference-maker at load time, only for creating the reference data in the first place; that might be done by someone else. The idea is that this metadata is made once, and then used as many times as needed.


Performance improvement by splitting keys?

Do you want to request a feature or report a bug?
Feature
What is the current behavior?
Performance degrades as the store size increases.
If the current behavior is a bug, please provide the steps to reproduce.
Create a largish store (a couple of MB).  Browser hangs noticeably when state is persisted.
What is the expected behavior?
Performance doesn't degrade.
If this is a feature request, what is motivation or use case for changing the behavior?
In my experience, local storage performance degrades as the value size increases.  Since the entire store is serialised into a single string, for large stores the performance degrades to the point where there are noticeable browser delays.
Is there a way to make this plugin split the data across multiple local storage keys to improve performance?  Has anyone considered this?

Yeah this plugin is never meant to store large stores. Please restructure your application so it doesn't store multiple MBs in local storage.

Maybe have per-module storage, so each module is able to store it's state in a dedicated LS Key.
Also possibly providing compression to reduce the storage size further on large states would result in performance improvements? This would definitely help for alternative storage mediums, such as cookies.


SelectedItemChanged doesn't trigger on first sub item

Given your exact example code for the Treeview with unlimited items located at https://www.fluentui-blazor.net/TreeView#withunlimiteditems, the first subitem of an item never gets selected. All other items will update SelectedItem, but never the first.

Will be fixed in the next release: #2414


Update 20.{1,2} docs to mention 2020 Cloud Report

Fixes #8023.

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/abe0e43b2ac0a38b0d987a25025e1eba38b16329/
Edited pages:

v20.1/performance-benchmarking-with-tpc-c-100k-warehouses.md
v20.1/performance-benchmarking-with-tpc-c-10k-warehouses.md
v20.1/performance-benchmarking-with-tpc-c-1k-warehouses.md
v20.1/performance.md
v20.2/performance-benchmarking-with-tpc-c-100k-warehouses.md
v20.2/performance-benchmarking-with-tpc-c-10k-warehouses.md
v20.2/performance-benchmarking-with-tpc-c-1k-warehouses.md
v20.2/performance.md

Hey John, this is the "minimum fix" to get pages in the 20.1 and 20.2 docs pointing to the latest (2020) Cloud Report.  Would appreciate your rubber stamp to make sure this looks OK.  Else, please let me know if you want any changes - Thanks!

Hey @johnrk - FYI I'm gonna go ahead and merge this so we don't have the stale Cloud Report info on the site


Schedule#occurrences doesn't take "end_time" into account?

I've got a weekly scheduled event which spans from Today to Tomorrow. Calling occurrences on that schedule with a closing time which is in one month, I still get 5 occurrences, although my scheduled event is supposed to end Tomorrow:
schedule = IceCube::Schedule.new(Time.now, end_time: Time.now + 1.day) do |s|
  s.add_recurrence_rule(IceCube::Rule.weekly)
end
schedule.occurrences(Time.now + 1.month).count
# => 5

Have I done something wrong?

The end_time is for duration, - so it'll still recur the next week at the same time.  You can use until as well

I also found it confusing. @seejohnrun mentioned using until and here is the example of it. You apply it to the rule
schedule = IceCube::Schedule.new(Time.now) do |s|
  s.add_recurrence_rule(IceCube::Rule.weekly.until(Time.now + 1.day))
end


Make subnets depend on proxy only subnets

Checklist

I applicable, I acknowledge that I have:

[ ] Read the contributing guide
[ ] Ran terraform fmt on all modified files
[ ] Regenerated the relevant README.md files using tools/tfdoc.py
[ ] Made sure all relevant tests pass

Should we also add dependency to subnet_ids ?

Should we also add dependency to subnet_ids ?

Absolutely. Done


filtered view instead of filtering the incoming messages

the way the filter works right now, I think messages are 'lost' in the sense that you cannot remove the filter and apply a different filter on the same content. This can make it hard to create the right filter, because you have to re-build every time to try a new filter.
It would be nice if the content was actually stored in a buffer and the filter can be re-applied to it.

this is actually not a valid enhancement, I have submitted a bug report as #6


Questions on config client's retry behavior

Context
Our current step is 3 config server instances registered on eureka. Other services use eureka client and spring.cloud.config.serviceId to locate the config server instance.
During the failover test, seems that client retries against the same config server URI. That is, when one config server instance is down, and I fetch configs from that config server instance, client will try reconnecting to that instance instead of using another config server instance.
Questions

Is such behavior intended?  The implementation of ConfigServicePropertySourceLocator suggests so.
If answer to 1) is yes, is it possible to use client-side load balancing, e.g., ribbon, on the retry logics? If so, is there any implementation I can use for reference?

Of course, I can also put config server instances behind a load balancer.

There is retry logic build into the config client
http://cloud.spring.io/spring-cloud-static/Dalston.SR4/single/spring-cloud.html#config-client-retry
But the config client does not have a dependency on Ribbon so there is no load balancing built in.  As you mention the best option would be to possibly put the config server instances behind a load balancer.

Thanks for the reply!
I was following the section 10.2 Discovery First Bootstrap on that page. It says by using Eureka to discover config server instances by service id,
The benefit is that the Config Server can change its co-ordinates, as long as the Discovery Service is a fixed point.

My understanding is that if I use @EnableDiscoveryClient,  config client will try a different config server instance if it is not able to connect to the current config server instance?  If so, when will such switch happen? After the retry in ConfigServicePropertySourceLocator?
The ultimate goal is that config client can connect and fetch configuration, even though some config clients are healthy and some not.

I dont think that is the way it works.  ConfigServiceInstanceProvider just chooses the first instance in the list
https://github.com/spring-cloud/spring-cloud-config/blob/master/spring-cloud-config-client/src/main/java/org/springframework/cloud/config/client/ConfigServerInstanceProvider.java#L28
When a retry happens it continues to retry the same instance.

After more research, I see what confused me at the beginning. Here are my findings

By default, an unavailable instance will be removed from eureka registry after leaseExpirationDurationInSeconds=90 seconds. During that 90 seconds, Eureka server still treats that instance as UP, and the traffic to the now-dead instance will fail. Such behaviour is standard in load balancers and is intended.

However, during my failover test, I killed off a few instances and triggered Eureka's self-preservation mode. In this mode, Eureka always returns the now-dead instance and will not retire it. That is why the config client has been retrying against a dead-instance.

For the record, here are my solutions:

The original idea of a client side load balancer is not really needed - Eureka itself is enough.
Lower renewalPercentThreshold. 85 Percent is too high for non-prod/performance environment
Lower leaseExpirationDurationInSeconds so that instances can be evicted sooner.


Collected Data Modal: test data collection for midline-endline targets

Implemented by @camgnostic at 0f2b62c

It's unclear what we will be doing with front-end testing now.  We'll either reopen this or recreate it if we start on this kind of testing again.


weird bug cant go away

WARNING: Failed to remove contents in a temporary directory 'C:\Users\charl_n3hzs9u\OneDrive\Desktop\PySilon-malware-main\PySilon-malware-main\pysilon\Lib\site-packages~il'.
You can safely remove it manually.
How fix???

this is normal and doesn't affect the executable

this is normal and doesn't affect the executable

ok but it doesnt work even when i make the bot online


Reducing\changing the speed of the motors before stop.

Dear rhyst,
First of all I want to thank you for the amazing project that you did, it is very useful and practical, no needs to buy an additional expensive panel to be able to adjust the height without holding the buttons.
You mention in the Desk Internals, Behaviour section on the main page that "If no move command is received the motors slows down towards the end and then stops".  however my motor seems to not slow down before stop, they just stop very abruptly and it is annoying because the monitor and the speakers on my desk shake a little after such stops. this behavior is not related to your project because I have the same problem no matter if I use windows app or the original panel  that came with the desk to adjust the height.
I was wondering if there is a way to control the speed of the motors with your code to slow down the motors before stop or to just reduce the speed somehow to reduce the stop impact.
Thanks in advance.

I'm very glad it's useful 😊
I can't say for certain but I did not see anything that would control the speed of movement when decompiling the app or when playing with the BLE characteristics.
I think the behaviour of your desk is the same as mine and the "slowing down" is quite abrupt and results in some shaking. I included that description to indicate that it is possible to send the commands too slowly and then you get repeated jerking.


feat: [LW-11556] add tests for advanced mode receive screen

Allure Report
allure-report-publisher generated test report!

processReports: ✅ test report for b0f3cc9d

passed
failed
skipped
flaky
total
result

Total
32
0
4
0
36
✅


fix: [Unable to select Month and year in FluentDatePicker] in [ FluentDatePicker]

🐛 Bug Report

💻 Repro or Code Sample

🤔 Expected Behavior

😯 Current Behavior

💁 Possible Solution

🔦 Context

🌍 Your Environment

OS & Device: [e.g. MacOS, iOS, Windows, Linux] on [iPhone 7, PC]
Browser [e.g. Microsoft Edge, Google Chrome, Apple Safari, Mozilla FireFox]
.NET and Fluent UI Blazor library Version [e.g. 8.0.2 and 4.4.1]

Duplicated #2746


fix project ARM template

I didn't realize that projects have their own sub-ARM template. This fixes that AFAIK.

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-ai-ml


The Beginning After The End

In chapter 201, there is nothing. The whole chapter is empty.

Please add the plugin name and a screenshot of it working in WebView please

Closing this due to the lack of necessary details. If the issue persists, please create a new issue and follow the issue template.


SeamlessM4T support

Is it possible to use SeamlessM4t model with transformers.js https://github.com/facebookresearch/seamless_communication

Good news: there is an open PR for support for SeamlessM4T in transformers, and we will add it here when ready! 🚀
cc @fxmarty to ask about support in optimum? 😇

Hi we'll be waiting for transformers to add it, feel free to ping me again @xenova

@fxmarty The huggingface PR is almost merged. Pinging you so that you start working on the support in optimum.

Thank you @bil-ash, adding it to my todos!

@fxmarty @xenova is it possible to pick this one up again? 🙏


Copied Ledger Wallet can't be accessed anymore

When copying the Wallet from one to another device or e.g. from Daedalus Main to Flight Wallet folder, I cannot access the Wallet anymore.
This might be correct because of privacy issues.
The issue:
But when I click on the Wallet within Daedalus I am getting a message, where I shall change my password, which is not working and well. But for a user it is misleading because I am always getting a "wrong password" message that does not make any sense.
What I want to have:
Maybe a better solution would be to remove the password change dialog with an authorization dialog for Ledger/Trezor. Where a user can reauthorize its Ledger Wallet.
If I am totally wrong, please do not take it amiss :D.

You are not supposed to do that. This is not an option Daedalus supports as the other Daedalus instance thinks that your Ledger wallet is a software wallet as you can not copy all the data from the other instance.


Make copyright statement settable via params

This de-duplicates 2 areas where the copyright statement is set (depending on the number of columns of links), and also allows the copyright text to be set using params.copyright on the Nunjucks macro.
This was previously documented as an option on the footer component but wasn’t implemented in the actual nunjucks macro.

I’ve set the default to "NHS England" as the guidance suggests that’s what most services should use, but the NHS.UK website, or any local NHS trusts or other organisations, could override this.

Possibly this should follow the pattern of having copyright.text and copyright.html instead, but the labels for the links in the footer don’t seem to do that so I wasn’t sure how rigidly we wanted to follow the pattern? 🤷♂


Update replication log for msmarco doc-segmented/passage uniCOIL

I have successfully replicated the uniCOIL result on orca and my laptop with macOS version 11.5.2, python 3.7, pandas version 1.3.5 and lightgbm 3.2.1. No error was encountered during the replication.

@yuki617 can you please follow these instructions?

To add to this reproduction log, modify this template and run bin/build.sh to rebuild the documentation.

Please modify the corresponding template file and rebuild?

@yuki617 can you please follow these instructions?

To add to this reproduction log, modify this template and run bin/build.sh to rebuild the documentation.

Please modify the corresponding template file and rebuild?

Sorry, forget again to change from template. Should be fixed now


matrix: Clarify API docs of graphene_matrix_init_look_at()

http://www.songho.ca/opengl/gl_camera.html has some reference material on this, although the computed matrix there is the inverted final one.

Unclear why CI failed for a docs change, maybe just retry?

Thanks, looks good.

Unclear why CI failed for a docs change, maybe just retry?

The 32bit MSYS2 build is flaky for unclear reasons. I just tend to ignore it.


Document the memory size of FastStr is not 24 which is not equal to String and smol::SmolStr

Hi, I found that the memory size of FastStr is not 24, so switching from String or SmolStr to FastStr may not be harmless.
So, could this crate add documentation for this?

Yep, thank you for pointing this out! I think documenting this is better, are you willing to submit a pr for this?


Testing file resource when it refers to a file on puppet master

Hi,
I've run into a situation where the file resource uses the file function to refer to the content stored on the puppet master like so:
  file { SOME_NAME:
    content => file(PATH_TO_FILE_ON_MASTER),
    ...
  }

That prevents the catalog compilation during the testing. Is there a way around this?
Thanks!

If you're passing an absolute path to file(), you don't have many options.
You could stub out the function entirely by redefining it:
before do
  Puppet::Parser::Functions.newfunction(:file, :arity => -2, :type => :rvalue) do |vals|
    "the contents of the file for testing purposes"
  end
end

You could also mock the internals of the function, using your mocking framework of choice. For example, if using rspec-mocks:
before do
  allow(Puppet::Parser::Files).to receive(:find_file).with(any_args).and_call_original
  allow(Puppet::Parser::Files).to receive(:find_file).with(PATH_TO_FILE_ON_MASTER, anything).and_return(PATH_TO_FILE_ON_MASTER)
  allow(Puppet::Filesystem).to receive(:exist?).with(any_args).and_call_original
  allow(Puppet::Filesystem).to receive(:exist?).with(PATH_TO_FILE_ON_MASTER).and_return(true)
  allow(Puppet::Filesystem).to receive(:read_preserve_line_endings).with(any_args).and_call_original
  allow(Puppet::Filesystem).to receive(:read_preserve_line_endings).with(PATH_TO_FILE_ON_MASTER).and_return("the contents of the file for testing purposes")
end

This is potentially a more fragile solution as the behaviour of the file function may change between Puppet releases and may require adjusting the mocks.
Refactoring your manifest to not depend on the existence of a file on the master would be the best option.

That's awesome, Tim. At least I have a few options now. Thanks a lot!!!


Much confusion about storage

Hi,
The documentation says

We originally built Zipkin on Cassandra for storage. It’s scalable, has a flexible schema, and is heavily used within Twitter. However, we made this component pluggable, and we now have support for Redis, MySQL, PostgreSQL, SQLite, and H2.

But nowhere is it documented how to achieve this, or at least I couldn't find it.
The gradle.properties file refers to backend switching but the naming is confusing.
"configKey=dev" stands for using AnormDB, and if I read that correctly it needs to be set when switching to a different backend.
Are we to infer from this name that backends other than cassandra or redis are not production-ready?
Are there known caveats associated with using RDBMS backends?
To give some context we are evaluating Zipkin and being able to do without Cassandra would be a big plus. We have lots of MySQL instances around with qualified people to oversee them, we'd rather not introduce yet another storage solution in the mix.

This is a documentation bug. Twitter doesn't use cassandra anymore, and regardless, we should bring this up to speed.
configKey=dev is a specific anormdb setup that uses file sharing. We could quite easily add a mysql config based on a jdbc connect string. I've wondered myself why we haven't (that or postgres). I can help fix the doc bug, but can you share a little more about how you'd be deploying this? docker?

All deployment options are on the table at this stage, docker could be it as well as building & deploying on AWS instances manually.
Your reply leads me to ask another question, if Cassandra is being phased out why is the docker-zipkin project relying on it? What is the recommended storage backend these days? (I guess the answer is "it depends", I'm just trying to find out which option is going to be the best supported).

Twitter the company isn't using Cassandra anymore, but Zipkin the open source software is using Cassandra a lot (I think Cassandra is regarded as the main storage backend)
Zipkin was originally written at Twitter, but now, the project has been moved out into its own organisation.

cassandra remains the most supported, as it is used in docker, etc. as
Eirik mentioned zipkin is its own thing. Feel free to join us!
https://gitter.im/openzipkin/zipkin

ps #853 trims SQL databases to a more relevant list, namely drivers you can configure OOB


Fixes missed from previous PR

I believe these are the fixes that didn't make it in (and were stored in the stash).

This change is

src/Serval.Translation/Services/PretranslationService.cs line 73 at r1 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
We should use relaxed comparison when updating the target book.

done

src/Serval.Translation/Services/PretranslationService.cs line 78 at r1 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
We should use strict comparison when copying the source book.

done


Google Chromecast devices undiscoverable after Home Assistant startup

Home Assistant release with the issue:
0.67.0
Last working Home Assistant release (if known):
Guessing it last worked flawlessly around mid-December 2017
Operating environment (Hass.io/Docker/Windows/etc.):
home-assistant in virtualenv python3.6, Windows 2012 Server R2 running ubuntu 16.04 on Virtualbox
Component/platform:
https://www.home-assistant.io/components/media_player.cast/
Description of problem:
Since mid-December 2017, I cannot run home assistant without losing my devices as cast targets in Pandora, Google Play Music, or Google Home app.  The only devices that show as cast targets are an Insignia speaker and a Sony speaker, as well as any group that contains either or both of those speakers.  I assume it's because the are running much older firmware.  Google Homes (4), Chromecast Audios (10), Nvidia Shields (2), and gen 1 Chromecast Video (1) are not available as cast targets.
With the exception of the Google Homes, the Insignia speaker, and the Sony speaker, the rest of the cast devices are connected via Ethernet.  Also all the devices are DHCP reserved.  I'm (now) using an Edgerouter Lite and Unifi AP, but was using Google Wifi mesh and encountering the same problem.  The reason I've tolerated for so long is because I assumed this was an issue of the mesh network not playing well with a cast CC firmware update.
Interestingly, even with home assistant running, I can still tell a Google Home to listen to something on any individual Chromecast, and that will work fine.  If I request Google Home to play to a group, only one set of speakers will play, which I'm guessing is whatever the "lead" CCA in the group was.  But my wife prefers to select her music from her phone (on Pandora, for instance) and then hit a cast button.  That doesn't work because none of the options (aside from Sony and Insignia) show up as targets.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
configuration.yaml entries
Discovery off
#Discover some devices automatically
#discovery:

media_player: !include media_players.yaml
zeroconf:

the logger entry for attached log:
logger:
  default: error
  logs:
    pychromecast.socket_client: debug
    pychromecast: debug
    homeassistant.components.media_player.cast: debug

And the entire media_players.yaml
# Chromecast Audios

  - platform: cast
    name: Den
    host: <IP_ADDRESS>

  - platform: cast
    name: Kitchen
    host: <IP_ADDRESS>

  - platform: cast
    name: Dining Room
    host: <IP_ADDRESS>

  - platform: cast
    name: Living Room
    host: <IP_ADDRESS>

  - platform: cast
    name: Patio
    host: <IP_ADDRESS>

  - platform: cast
    name: Master Bedroom
    host: <IP_ADDRESS>

  - platform: cast
    name: Master Bathroom
    host: <IP_ADDRESS>

  - platform: cast
    name: Master Closet
    host: <IP_ADDRESS>

  - platform: cast
    name: Playroom
    host: <IP_ADDRESS>

  - platform: cast
    name: Office
    host: <IP_ADDRESS>

  - platform: cast
    name: "Sloane's Speaker"
    host: <IP_ADDRESS>

#Google Home
  - platform: cast
    name: Office Home
    host: <IP_ADDRESS>

  - platform: cast
    name: Master Bedroom Home
    host: <IP_ADDRESS>

  - platform: cast
    name: "Sloane's Alarm Clock"
    host: <IP_ADDRESS>

  - platform: cast
    name: Kitchen Home
    host: <IP_ADDRESS>

  - platform: cast
    name: Den Home
    host: <IP_ADDRESS>

#Chromecast Videos
  - platform: cast
    name: Den Chromecast
    host: <IP_ADDRESS>

  - platform: cast
    name: Den Shield
    host: <IP_ADDRESS>

  - platform: cast
    name: Playroom Shield
    host: <IP_ADDRESS>

#Chromecast Groups
  - platform: cast

Traceback (if applicable):

Additional information:
Chromecast platform is finicky enough even without Home Assistant.  I'm not saying it runs perfectly even with all Google Cast components commented out.  Things will drop in and out from time to time for reasons unknown.  But this home assistant effect is consistent and immediate - all google cast devices except the ones noted in description drop out.  I can restart them, restart the router, and get them back for a few minutes, but that's it.
I have not seen anyone else report this issue.  It may be just the sheer scale 18 cast devices causing the problem, but I thought the whole idea is that this was scale-able.  Google Chromecast customer service has basically given up at this point with me.
I included a debug logger in the attached.
The first screenshot is a list of cast targets available just after home assistant startup.  The second group is a set of scrolling screenshots of available cast targets from 5 minutes earlier before starting up home assistant.  My cast targets went from 28 (individual devices + groups) to 3.
home-assistant.log

I just spent the better part of the day troubleshooting every aspect of my chromecast implementation.  I discovered that this is probably not anything to do with Home Assistant.  I had a rats nest of wires and switches in the primary wiring closet related to the CCA's needed to drive whole home audio.  When I pulled the whole home audio switch out of the mix, everything else worked fine.  So I just spent the day detangling, separating, and testing every single piece in that area.  Ultimately, I think there was too much electrical interference for everything I had jammed in the same space.  CCA's had fallen off the rack and were dangling right next to the speaker outputs on the amp.  After I got everything straight, I started back up.  I've been running now for about an hour with no issues.  If I wake up in the morning and everything is still ok, I'll close this case.

After further troubleshooting today, I've determined that this is related to cast groups.  As long as I exclude the cast groups from pychromecast discovery, I won't lose any cast targets from spotify, pandora, gpm, google home, etc.  I have a lot of automations that depend on visibility into cast group status, but I've commented everything related to groups out of my configuration for now.  Hopefully this will narrow down where to look for the enterprising soul that decides to take this on, or at least help anyone else who runs into this problem.

Now that I've determined that this is related cast groups, I'm closing this case.  Issue #13530 is close enough that I think any resolution there will probably solve my issue as well.

I believe you should re-open this isue, it appears tat the issue you are having is separate from the issues in #13530


OnLobbyDataUpdate method changed in GodotSteam

The newest version of GodotSteam changed the _on_lobby_data_update call (dropping the key argument).
Lobby Created called
Created Steam Lobby with id:<PHONE_NUMBER>50723751
Relay configuration response: True
Initializing P2P Host as<PHONE_NUMBER>2642118
Lobby Joined!
ERROR: Error calling method from signal 'lobby_data_update': 'Node(steam_lobby.gd)::_on_lobby_data_update': Method expected 4 arguments, but called with 3..
   at: Object::emit_signal (core\object.cpp:1236)

Solution is to just change this line from
func _on_lobby_data_update(success, lobby_id, member_id, key):

to
func _on_lobby_data_update(success, lobby_id, member_id):

If you want to open a PR, I can review and merge.
Thanks!

Thanks! I've submitted PR #7


[sheets] single click doesn't select a new cell

Instead the target cell flashes but selection doesn't move.
Double-click does select new cells though:
https://github.com/user-attachments/assets/01f914ce-1a05-4df6-bfa6-74d94f39a295

Some more context: this only happens once you've selected a cell and typed something in it. Until that point single click cell selection works.


Add .github folder with contributing and pull request templates

It's probably best you add a CLA too

Do we really need a CLA, isn't the MIT license enough?

No we don't need a CLA


Is there a version of TF15 that can be used out of box?

Hi, there! After reading the paper and run the demo you provided, I am excited by the speedup disc has achieved compared to other framework on various dynamic deep learning work loads. Great Work i must say !  The easy usage API  and impressive perf enhancement
make us just want to give it a try. But as far as i know, the demo provided is based on tf2.4, but our production environment is tf15. I am currently trying to adapt tf15 to the disc compiler and have encountered lots of compilation issues due to uncompatiable building tools(tf2.4 use bazel 4.0 while tf15 use bazel 0.24.1). According to the Doc, tf15 is also supported, so my question is, is there an out of box version tf15 that we can use directly? If the answer is no, is there any document guide on the adaption can be made?
Any advice would be much appreciated!

Hi, does "tf15" refer to tf1.15, or tf1.5?

TF1.15, Sorry for the misleading name.

Hi @EddieBurning ,
Thanks for your issue, please pull the latest BladeDISC runtime Docker image with TensorFlow 1.15 as the following command:
docker pull bladedisc/bladedisc:latest-runtime-tensorflow1.15

Many thx! @Yancey1989


Fruit Ninja Effect

Hi,
I love the work you've done.  I'm looking for a Fruit Ninja chop in half effect which I'm hoping is a subset of the work you already do for the shatter effect.  Do you think that's easy to do by modifying one of the existing effects?

Settings grid size to the (2,1) should be close to what you want. Unless you want to use gesture for that? Then it would need a little bit more editing.

I don't need gesture.  I'll try that thanks!


Maven Plugin is failing the build on the basis of CvssV3 score

Describe the bug
Maven Plugin 5.3.0 is failing maven build w.r.t CvssV3 score instead of CvssV2 score.
Version of dependency-check used
5.3.0
Log file
[ERROR] One or more dependencies were identified with vulnerabilities that have a CVSS score greater than or equal to '7.0':
[ERROR]
[ERROR] spring-security-core-4.2.0.RELEASE.jar: CVE-2018-1258, CVE-2017-4995, CVE-2016-9879, CVE-2019-11272
[ERROR] spring-core-4.3.4.RELEASE.jar: CVE-2018-1272, CVE-2018-1275, CVE-2016-9878, CVE-2018-1270, CVE-2018-15756
To Reproduce
Steps to reproduce the behavior:

Add below dependency in pom.xml

org.springframework.security
spring-security-core
4.2.0.RELEASE

Run org.owasp:dependency-check-maven:5.3.0:check -DfailBuildOnCVSS="7" -Dformat="JSON"  on the maven project

Expected behavior
I assumed the failBuildOnCVSS will consider only Cvssv2 score for failing the build like old depndency-check versions. But in above example, the build failed due to the cvssv3 score.
How can I make the plugin to only consider specific scoring system for failing the build?

One of the issues is that we may not even have a CVSS score - if the vulnerability comes from OSS, NPM,
RetireJS, etc. At the moment - we check all available scores and estimate a CVSS score based off of "unscored" ratings (high, medium, low). I have not looked to ensure that in every case we have a CVSSv3 we also have a CVSSv2.

@jeremylong ,
Can you please add new parameter to distinguish CVssScore  and which should be considered for failing the build.
For ex: -DfailBuildOnCVSS="7_cvssv2" or "7_cvssv3"
It would be really helpful as in current use case, we are not able to figure out why the build has failed.
We can ignore the unscored vulnerabilities where we don't have  CVSS score.

Any update on this?

Related to #3448

In the method checkForFailure, scores for CVSS v2 or v3 are indeed mixed when checking, when both are present.
Maybe we could add a kind of priority in such a case (none (default) / CVSSv2 / CVSSv3) ?
See there : https://github.com/jeremylong/DependencyCheck/blob/v6.5.1/maven/src/main/java/org/owasp/dependencycheck/maven/BaseDependencyCheckMojo.java#L2431..L2467


on Resource Templates tab, allow find by Group

Resource Templates tab has several ways to find templates, but not by group

add group to the ways you can find

We need to make the change in the search function so that it changes which fields we search.

What is the user interface for finding by group?

on Resource Templates tab, we just have that single search box and it searches (currently) ID, remark, label, etc. This ticket is just to include "group" in what is searched. no separate UX at this time.


Virtual field is actually created in the database (Postgresql)

Link to reproduction
No response
Payload Version
3.0.0-beta.91
Node Version
18.20.4
Next.js Version
15.0.0-canary.104
Describe the Bug
The virtual field or calculated field that I add to my collection is actually created in the database. Base on this blog post and the field hooks document, the virtual field shoule be removed before saving. I have added the beforeChange hook. But it is actually created in the database with null value.
This is my collection definition.
import { CollectionConfig } from 'payload'

const getFullname = async ({ data }: any) => {
  return data.code + ' ' + data.name
}

export const Category: CollectionConfig = {
  slug: 'category',
  admin: {
    group: 'Products',
    useAsTitle: 'fullName',
  },
  fields: [
    {
      name: 'code',
      type: 'text',
      required: true,
    },
    {
      name: 'name',
      type: 'text',
      required: false,
    },
    {
      name: 'fullName',
      type: 'text',
      admin: {
        readOnly: true,
      },
      hooks: {
        beforeChange: [
          ({ siblingData }) => {
            delete siblingData['fullName']
          },
        ],
        afterRead: [getFullname],
      },
    },
  ],
}

Reproduction Steps
As mentioned above
Adapters and Plugins
No response

Thanks for reporting @bmamouri!
I see why you opened a bug for this but I'm going consider this to be a new feature and close the issue.
For MongoDB this isn't an issue because keys aren't made until data is assigned, however as you pointed out for any SQL based DBs you will see columns being created. In the field config there isn't a current way to tell the database adapter to ignore the field.
We're evaluating this PR that is related https://github.com/payloadcms/payload/pull/7621 and would handle this feature so you can follow along there.


baseUrl default / wrong join in joinUrl

In Version 0.10.1 the default in satellizer.config is baseUrl = '/'.
The error only is relevant if you set a url for a provider:
$authProvider.facebook(angular.extend({}, commonConfig, {
    clientId: 'FACEBOOK_APP_ID',
    url: 'https://satellizer.herokuapp.com/auth/facebook'
  }));

This leads to url calls like: http://localhost:8100/https://satellizer.herokuapp.com/auth/facebook'
The error seams to be in satellizer.utils - joinUrl
joining baseUrl which is '/' and the given url which is for example 'https://satellizer.herokuapp.com/auth/facebook' leading to a url of '/https://satellizer.herokuapp.com/auth/facebook' leading to a call of 'http://localhost:8100/https://satellizer.herokuapp.com/auth/facebook'
Workaround: set baseUrl to null:
$authProvider.baseUrl = null;

Hi,
I am getting two issues(Facebook in-app browser) that might be related to same problem.

Pop-up is not getting closed
Facebook is unable to exchange token with my server.

"The default value for $authProvider.platform is "browser".
Do I need to change something to get it working? Here is the URL to my Satellizer.js file
Satellizer JS Link
any help?
Thanks,

@Flofie It was easy enough fix by checking if url is absolute. If that's the case, skip baseUrl concatenation, otherwise works exactly the same as before.


Count Token Usage for Open AI

Is your feature request related to a problem? Please describe.
I see a lot of back and forth when I run some of the examples, like where we're saving texts and blobs to, etc.
So I wanted to compare token usage for similar tasks from Langchain and Griptape.
Describe the solution you'd like
A way to count the number of tokens spent to fulfill a request.
For example, let's say you have an agent that is doing multiple things, similar to the RestApiClient Example. I'd like to know how many tokens we use to fulfill this request to compare to other frameworks.
Describe alternatives you've considered
I tried using Langchain's counter but it only works with Langchain LLMs. I also searched to see if the OpenAI package has this functionality already but it doesn't seem so.
Additional context
N/A

Also want to say thank you for your work! Griptape seems like a much better bet than langchain, especially to avoid blowing context!

@Jchang4, thanks for submitting the issue and for the kind words! :)
This is a super important issue and we are going to address it as soon as https://github.com/griptape-ai/griptape/issues/46 is complete. Will update you once it's done.

Oh also note, I checked the Open AI Usage dashboard and I do see quite a difference between langchain and griptape costs

Which one uses fewer tokens in your experience? :) Also, our of curiosity, what were the two setups that you compared? (e.g., number of tools, rules, etc.)

@Jchang4, we added support for counting tokens in Griptape! Check out this example: https://docs.griptape.ai/en/latest/examples/count-tokens/


Added OR_GREATER/OR_LESSER export hint for float & int range

This change exposes the optional or_greater & or_lesser range property hints to GDScript exports.
It allows exported variables like these:
export(float, 0.0, 10.0, 0.1, OR_GREATER, OR_LESSER) var val_float
export(float, EXP, 0.0, 100.0, 0.1, OR_GREATER) var val_exp_float
export(int, 0, 10, 0.1, OR_LESSER) var val_int

@pouleyKetchoupp Is this still desired? If so, it needs to be rebased on the latest master branch. While there are no conflicts, rebasing is important so that reviewers can easily test the PR.
@vnen How does the GDScript rewrite affect this PR?

@vnen How does the GDScript rewrite affect this PR?

The syntax for export change to use annotations and those hints are already supported for the range exports. It could potentially be added into a 3.x release but it's not relevant for master.


Details on --overwrite param of upload command

It would be nice to have more details on the --overwrite param. My first reaction was trying to use it as a flag (just --overwrite, with no value), but then I found out it had to be set to "true". I think that should be explicitly mentioned in the docs.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 60c99b13-9888-31ac-9e22-4bac0cb3956a
Version Independent ID: 7aef098d-0f55-e080-cce4-91ad6265d974
Content: az ml datastore
Content Source: latest/docs-ref-autogen/ext/azure-cli-ml/ml/datastore.yml
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

machine learning commands, routing to appropriate team

Hi @mariamedp, we recommend everyone to use file dataset upload directory https://docs.microsoft.com/en-us/python/api/azureml-core/azureml.data.dataset_factory.filedatasetfactory?view=azure-ml-py#upload-directory-src-dir--target--pattern-none--overwrite-false--show-progress-true- to upload data, not datastore upload. File dataset does allow overwrite to be true/false. Thanks! #please-close


Use io instead of deprecated ioutil package

SA1019: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package [io] or package [os], and those implementations should be preferred in new code. See the specific function documentation for details.
-- https://go.dev/doc/go1.16#ioutil

[x] Unhide the ioutil deprecation warnings
- https://github.com/cert-manager/cert-manager/actions/runs/7411458268?pr=6598
[x] Use io package instead.

/kind cleanup
NONE

/kind cleanup

/approve
/lgtm


[BUG]  NoSuchMethodError Exception: Compatibility Issues with spark 2.4.5

Describe the bug
NoSuchMethodError Exception in spark 2.4.5, please refer to the following exception  stacktrace and the spark source file
User class threw exception: java.lang.NoSuchMethodError: org.apache.spark.sql.catalyst.catalog.CatalogTable.<init>(Lorg/apache/spark/sql/catalyst/TableIdentifier;Lorg/apache/spark/sql/catalyst/catalog/CatalogTableType;Lorg/apache/spark/sql/catalyst/catalog/CatalogStorageFormat;Lorg/apache/spark/sql/types/StructType;Lscala/Option;Lscala/collection/Seq;Lscala/Option;Ljava/lang/String;JJLjava/lang/String;Lscala/collection/immutable/Map;Lscala/Option;Lscala/Option;Lscala/Option;Lscala/collection/Seq;ZZLscala/collection/immutable/Map;)V
at org.apache.spark.sql.execution.command.TiCreateTableLikeCommand.run(tables.scala:308)
at org.apache.spark.sql.execution.command.ExecutedCommandExec.sideEffectResult$lzycompute(commands.scala:70)
at org.apache.spark.sql.execution.command.ExecutedCommandExec.sideEffectResult(commands.scala:68)
at org.apache.spark.sql.execution.command.ExecutedCommandExec.executeCollect(commands.scala:79)
at org.apache.spark.sql.Dataset$$anonfun$6.apply(Dataset.scala:196)
at org.apache.spark.sql.Dataset$$anonfun$6.apply(Dataset.scala:196)
at org.apache.spark.sql.Dataset$$anonfun$52$$anonfun$apply$21.apply(Dataset.scala:3447)
at org.apache.spark.sql.execution.SQLExecution$.withNewTransactionId(SQLExecution.scala:99)
at org.apache.spark.sql.Dataset$$anonfun$52.apply(Dataset.scala:3446)
at org.apache.spark.sql.execution.SQLExecution$$anonfun$withNewExecutionId$1.apply(SQLExecution.scala:82)
at org.apache.spark.sql.execution.SQLExecution$.withSQLConfPropagated(SQLExecution.scala:147)
at org.apache.spark.sql.execution.SQLExecution$.withNewExecutionId(SQLExecution.scala:77)
at org.apache.spark.sql.Dataset.withAction(Dataset.scala:3444)
at org.apache.spark.sql.Dataset.<init>(Dataset.scala:196)
at org.apache.spark.sql.Dataset$.ofRows(Dataset.scala:80)
at org.apache.spark.sql.SparkSession.sql(SparkSession.scala:663)

What did you do
just run a create table like sql.
What do you expect
No exception
What happens instead
NoSuchMethodError
Spark and TiSpark version info
spark 2.4.5
tispark 2.3.4

@dawnbreaks would you please run the following code?
spark.sql("select ti_version()").show(false)

@dawnbreaks what is your Java version?

java version
openjdk version "1.8.0_252"
OpenJDK Runtime Environment (build 1.8.0_252-b09)
OpenJDK 64-Bit Server VM (build 25.252-b09, mixed mode)

select ti_version()
Release Version: 2.3.4
Git Commit Hash: ef25a689cef1a9ce1d7ab6800e55bdc7fc174183
Git Branch: release-2.3
UTC Build Time: 2020-09-15 03:54:30
Supported Spark Version: 2.3 2.4
Current Spark Version: 2.4.5
Current Spark Major Version: 2.4
TimeZone: Asia/Shanghai
Time taken: 1.755 seconds, Fetched 1 row(s)

@windtalker  Obviously this is a bug，The number of parameters of the CatalogTable construction method is different from that of spark 2.3

But according to the spark source file, looks like the missing method is exactly the same as show in the spark source code, could you please double check the spark jars you using?

And I don't see any difference of CatalogTable construction method between spark 2.4.5 and spark 2.3.4

@windtalker  Oh my gosh, We are using aliyun Cloud's EMR service, we decompiled the spark-catalyst_2.11-2.4.5.jar file，found that the CatalogTable class definition had been changed by aliyun EMR team.

@windtalker Oh my gosh, We are using aliyun Cloud's EMR service, we decompiled the spark-catalyst_2.11-2.4.5.jar file，found that the CatalogTable class definition had been changed by aliyun EMR team.

OK, so sounds not a TiSpark bug, maybe you can try with the official spark jars.


Optimize delete

Right now, to identify whether has deleted docs, we run N leaf search rpc. We could do this in one RPC.
Also, we could have a special collector that aborts after the first doc is found.

@fulmicoton can I take up this task or is someone else looking into it?


Add option to allow usage of Helm Templates in all values of values.yaml file items

Details
Helm chart name:  common
Describe the solution you'd like:
By default template variables like {{ .Release.Name }}  and {{ .Chart.Name }} are not working in values.yaml files (here is some issues about this: https://github.com/helm/helm/issues/3558, https://github.com/helm/helm/issues/2492), and that's sad...
But seems we can get rid of this limitation via implementing parser of each value in common library!
Here is an example of adding support for template conversion in value from values.yaml file of manually defined key persistence.config.existingClaim, described in templates/common.yaml:
{{- include "common.values.setup" . }}

{{-
$_ := set .Values.persistence.public
  "existingClaim"
  (print (tpl .Values.persistence.public.existingClaim .))
-}}

{{ include "common.all" . }}

Having this, we can use templates inside value of that key directly in values.yaml file, like this:
persistence:
  public:
    enabled: true
    type: pvc
    existingClaim: "{{ .Release.Name }}-{{ .Chart.Name }}-my-config"

And via same way we can loop through each of the keys in passed values.yaml file and make the template conversion for each value (or only defined ones)!
So we can add this as opt-in feature that should be enabled via some key, for example like this - global switcher for all values:
parseTemplatesInValues: true

and only for selected values:
parseTemplatesInValues:
  - envFrom[0].secretRef.name
  - persistence.config.existingClaim

What do you think about this idea?

We already do this for some of our values, for example in the env section. I've been toying with the idea to implementing it in more places but haven't thought through how to best do it.
The main thing we should try to prevent (as always) is jumping the shark with templating. We don't want or need our library to be a generic templating language for a generic templating language for ... etc.

Thanks for detailed explanation, yes - yet another templating language will be overkill ;-)
So maybe we can invent some helper function, that simplifies such conversion via single simple line in common.yaml?
Something like:
{{ parseTemplatesInValues envFrom[0].secretRef.name }}
{{ parseTemplatesInValues persistence.config.existingClaim }}
{{ include "common.all" . }}


Consolidate CounterValue functions

Use of the variadic parameter allows us to specify an unknown number of labels
to the MustNewConstMetric function, which enables us to consolidate
CounterValue functions into a single unit. This will allow us to use only the
desired type without creating new functions for various types for metrics with
unique labels.
Signed-Off-By: Robert Clark<EMAIL_ADDRESS>

@joehandzik I was able to get some testing in, so this is ready for merge pending your review.

This looks good, though I cringe a little that there are two separate list arguments (not saying there's a workaround for that, mind you). I'll merge in about 30 minutes if I don't hear back that you need to change this further.

I agree with your sentiment, but the two lists hold different values. It is true that they are related, so my first thought was to use a map, but then I would have to put in extra lines to align the labels and values which I felt was counter-productive.
Outside of that, nothing else I needed to test/change here.


Skip publish artifacts when PUBLISH_ARTIFACTS is not set

Avoid running "Stage And Publish Artifacts" if secrets.PUBLISH_ARTIFACTS has not been set.

Codecov Report

Merging #283 (4ce3144) into master (bece46d) will decrease coverage by 0.06%.
The diff coverage is 76.60%.

@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
- Coverage   68.27%   68.21%   -0.07%
==========================================
  Files         362      361       -1
  Lines       21506    21700     +194
==========================================
+ Hits        14684    14802     +118
- Misses       5245     5296      +51
- Partials     1577     1602      +25

Impacted Files
Coverage Δ

cli/profile.go
44.44% <ø> (ø)

cli/show_utils.go
51.06% <0.00%> (ø)

fs/localfs/shallowentry.go
100.00% <ø> (ø)

fs/virtualfs/virtualfs.go
85.71% <ø> (ø)

internal/clock/now_testing.go
13.33% <0.00%> (-0.46%)
:arrow_down:

internal/server/api_repo.go
40.86% <0.00%> (-0.23%)
:arrow_down:

repo/content/content_manager_iterate.go
90.51% <0.00%> (-3.57%)
:arrow_down:

repo/content/index_v2.go
82.01% <0.00%> (+1.21%)
:arrow_up:

repo/encryption/encryption.go
76.00% <ø> (ø)

repo/manifest/committed_manifest_manager.go
82.73% <0.00%> (ø)

... and 103 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06a9973...4ce3144. Read the comment docs.


Steps to implement kythe indexing

hello
I am new to kythe and i need to some steps to implement kythe indexing for code browsing.
Please help here.
Thank you

Can you send an email to<EMAIL_ADDRESS>(https://groups.google.com/forum/#!forum/kythe) ? GitHub issues are better reserved for project issues and bugs, rather than general inquiries.


Texture filtering question

Hi, I'm trying to use bgfx for 2d graphics, everything works perfectly except for texture filtering.
My code is loading texture by doing something like this :
int x, y, comp;
stbi_uc * bytes = stbi_load(filename, &x, &y, &comp, 4); // stb_image, force it to produce RGBA8
texture = bgfx_create_texture_2d(x, y, false, 0, BGFX_TEXTURE_FORMAT_RGBA8, BGFX_TEXTURE_NONE, bgfx_copy(bytes, x * y * 4)); // actually not sure if I need to have a copy here
stbi_image_free(bytes);

And then I render it somewhat like this:
#define BGFX_STATE_DEFAULT_2D (0 \
					| BGFX_STATE_RGB_WRITE \
					| BGFX_STATE_ALPHA_WRITE \
					| BGFX_STATE_CULL_CW \
					| BGFX_STATE_MSAA \
					)
...
// matrices are set elsewhere
bgfx_set_texture(0, u_tex, texture, -1);
bgfx_set_transient_index_buffer(&it, 0, -1); // they just define plain 2d sprite, 4 vert, 6 indeces
bgfx_set_transient_vertex_buffer(&vt, 0, -1);
bgfx_set_state(BGFX_STATE_DEFAULT_2D, 0);
bgfx_submit(0, program, 0, false);

Everything works fine, but textures are not filtered at all, I've tried to set BGFX_TEXTURE_MAG_ANISOTROPIC | BGFX_TEXTURE_MIN_ANISOTROPIC in bgfx_create_texture_2d and/or in bgfx_set_texture, but it doesn't look like it changes anything. Tried it also on d3d11/ogl.
Looks like I'm missing something obvious, but what exactly? Thanks!

It looks fine, by default there should be linear filtering, you should try modifying some existing example with textures.

NWM, I just forgot to generate mipmaps for that texture!


Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6079073a-0dd9-3b9b-c160-76e0dd525a3c
Version Independent ID: 631788a5-f4bc-7df0-0540-2a0f67b631de
Content: Introducing docs.microsoft.com
Content Source: teamblog/introducing-docs-microsoft-com.md
Product: team-blog
GitHub Login: @jeffsand
Microsoft Alias: jeffsand

@brikken Thanks for your question!
Our estimated reading calculation is 200 words per minute. All pages with 400 or fewer words are estimated at 2 minutes.


To marshal a managed method, please add an attribute named 'MonoPInvokeCallback' to the method definition.--       at Plugins.Discord.DiscordRpc.Initialize

I m having this issue with discord rpc under Unity 2018.1 , when using il2cpp as build mode, targeting windows.
I dont have this problem in the editor as it's mono.
I tried this:
public delegate void InitializeCallback(string applicationId, ref EventHandlers handlers, bool autoRegister, string optionalSteamId);
[MonoPInvokeCallback(typeof(InitializeCallback))]
[DllImport("discord-rpc", EntryPoint = "Discord_Initialize", CallingConvention = CallingConvention.Cdecl)]
public static extern void Initialize(string applicationId, ref EventHandlers handlers, bool autoRegister, string optionalSteamId);
but it doesnt help. Not sure if I'm doing the right thing

Hey there. I have not dug into (or heard of before this issue) compiling/using the SDK with IL2CPP in Unity, so I can't give you a quick answer. It looks like mono is complaining about things that may not be be a problem using the standard C# Unity stuff.
Is IL2CPP a commonly used build mode with Unity? Are many other devs struggling with this as well?

Thank you for your answer :).
The standard Unity stuff is now to compile in c++ with il2cpp, it's a build option in Unity, that is mean to be the correct way of doing things. It is said to be faster.
It's not a problem related to my project, but I couldnt find help on google about it.

It seems like this may be related:
https://garry.tv/2018/02/15/steamworks-and-il2cpp/
Perhaps try defining your own attribute like this? I can ask @snowyote to take a look when he has time.

I tried with the same MonoPInvokeCallback on all discordrpc functions, but with no luck

@snowyote  I think this could help:
https://forum.unity.com/threads/making-calls-from-c-to-c-with-il2cpp-instead-of-mono_runtime_invoke.295697/

@snowyote  I think this could help:
https://forum.unity.com/threads/making-calls-from-c-to-c-with-il2cpp-instead-of-mono_runtime_invoke.295697/

Talked with him about this. Neither of us are really well versed in IL2CPP, so we can't say for sure what the fix would be right away.
Considering you're the first to come across this issue, it seems like a somewhat non-standard way of doing things. I can put it on the docket to be addressed, but it's not a super high priority for us. If you figure out the changes and make a PR, we'll be happy to review.

    [MonoPInvokeCallback(typeof(DiscordRpc.ErrorCallback))]
    public static void ErrorCallback(int errorCode, string message)
    {
        Debug.Log(string.Format("Discord: error {0}: {1}", errorCode, message));
    }

Changing the Callbacks to be static class members and doing the MonoPInvoke stuff works for me.

Yes it works, thank you !

Thank you very much for your help @mdsitton! Marking this as closed.

Windows il2cpp is now standard in Unity 2018.2+, going forward: This is a stable version. Please see the above referenced issue to try to port this to an il2cpp-friendly build for Unity ^

Hey, I'm a dev at Unity working on IL2CPP, so I thought I might help here.
The use of the MonoPInvokeCallback attribute for cases where a managed delegate is marshaled to native code is required for both IL2CPP and Mono AOT. As it turns out, Unity won't be supporting Mono AOT on many platforms soon (and currently we don't support too many), but this is a more general AOT issue.
The AOT code generator needs to know which managed methods could be called from native code, as it needs to generate marshaling wrappers. Doing this for all managed methods is not feasible, so the MonoPInvokeCallback attribute guides the AOT code generator.
While IL2CPP is now an option for desktop standalone player builds in Unity 2018.2 and later, we plan to continue to support Mono JIT for those platforms. We don't plan to require IL2CPP as is the case on iOS, for example.
Still, using MonoPInvokeCallback is the correct solution here, and should have no impact for other cases. The chances of it breaking something else are pretty low (or zero).

@mdsitton Heya, seems like changing this causes a few domino effects on other things: What else did you change to get this working? I tried a few things but couldn't get it right.
If you help us out @ https://github.com/discordapp/discord-rpc/issues/243 , there's $50 with your name on it.

@dylanh724: Can to describe the other effects this causes in more detail?

It should possibly be noted that Debug.Log() can only be called within the main thread. So, if you call ErrorCallback() from another thread, the Debug Output will not work. You have to follow the Synchronisation rules between threads in this case.


Checkbox does not follow material design spec

This is confusing. As Material Design Specs state

Convey what happens when a setting is enabled

And not represent the current state. Also:

Settings that require precise descriptions

As this is quite totally self explaining I would just remove the subtitle.

+1.
This should be easy enough for me to submit a PR for.


chore(main): release 0.2.0

:robot: I have created a release beep boop
0.2.0 (2024-07-06)
Features

add support for python 3.9 (#2) (44e5f41)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v0.2.0
:sunflower:


lora: sx12xx driver cleanups

Perform some significant refactoring of the LoRa drivers to more closely conform to the standard device model and also use more up-to-date API's.
Reviewing commit-by-commit is heavily recommended.

@mniestroj  Please review

Can you move the conversion to spi_dt_spec to a separate commit for both sx126x and sx127x?

That would require a significant rework of the relevant commit. Using spi_dt_spec before the config struct is used doesn't make much sense. And porting the existing hodgepodge to config and then removing it all is just extra work.
Is this really required? It is simply swapping out function calls, no logic is changing

Closing this due to large conflicts with #42230


Assignment One - I wrote and called a function, answered questions in…

… assignment.

Starting over from the beginning of class. I do not understand anything I have done.


Improvements to StreamReader

StreamReader is now generalized to allow:

reading not only data from network TcpStream, but any input stream, including files
supporting Read, which is more performance-efficient than a raw read
parses and returns not just RawMessage, but any serializable data type
because of this, next_message function is renamed into read_next
embedded stream is now boxed

Since the changes are compatibility-breaking, if the PR will be accepted, the version number has to be bumped accordingly.
Necessary testcase included. You can play as well with this minimalistic test parsing shortened version of the blk00000.dat file: https://github.com/pandoracore/bpdump
Code sample:
    let mut stream_reader = match filename {
        Some(name) => {
            let buf_read: Box<dyn io::Read> = Box::new(io::BufReader::new(File::open(name)?));
            StreamReader::new(buf_read, None)
        },
        None => {
            let stdin: Box<dyn io::Read> = Box::new(io::stdin());
            StreamReader::new(stdin, None)
        },
    };

    let mut blkno = 0;
    loop {
        // Reading magic number
        match stream_reader.read_next::<u32>() {
            Ok(0xD9B4BEF9) => (),
            _ => {
                eprintln!("No magic number found");
                break;
            }
        }
        // Skipping block length
        eprintln!("Magic number ok");
        let _ = stream_reader.read_next::<u32>()?;
        // Reading block
        match stream_reader.read_next::<Block>() {
            Err(err) => {
                eprintln!("{}", err);
                break;
            },
            Ok(block) => {
                eprintln!("* read block no {}, id {}", blkno, block.bitcoin_hash());
                println!("{:#?}", block.header);
                println!("{:#?}", block.txdata[0]);
                blkno += 1;
            },
        }
    }

Can't these two commits be squashed together?

Making stream to be a ref in StreamReader
Making stream to be a boxed in StreamReader

Can't these two commits be squashed together?

done

Its strange that rust nightly, stable and beta are building, but 1.22 fails to solve cargo dependency on rand package (which I didn't touched at all). Any ideas what can cause this?

Because you reintroduced tempfile

#306

Everything you plan to do with a file can be done in memory via a buffer(vec/iter something else)

@elichai got it. It was introduced to mimic real-world file reading in tests as much as possible, but it is clearly not needed with that price of security

Codecov Report

Merging #318 into master will increase coverage by 0.07%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #318      +/-   ##
==========================================
+ Coverage   81.85%   81.93%   +0.07%
==========================================
  Files          38       38
  Lines        6951     6981      +30
==========================================
+ Hits         5690     5720      +30
  Misses       1261     1261

Impacted Files
Coverage Δ

src/network/stream_reader.rs
95.62% <100%> (+1.22%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4556c9c...72f4a7f. Read the comment docs.

@apoelstra @elichai all suggestions are accepted and added to the PR; commits were squashed; so now its ready for your re-review

ACK 749251e6665e913766fe381912e6218047519832 looks good :)

@elichai I assume you need to complete review with a Github button in order to get this merged?

Seems we are ready to merge this PR, all comments were addressed and two reviewers had ACK. What is the next step?

We need another reviewer with merge access to ACK.

@elichai it looks like we require your ACK to merge the stuff...


Checkbox can't set value width.

Why checkbox can't set value width. If I want to change checkbox width then only have a way to change the checkbox file in the flutter framework. That not true way. Can put width of checkbox is properties not constant.

The widget is designed to match the Material Design spec.
Why would you want to change the checkbox width?

Makes sense.
As a workaround you can still copy the source and adjust it do your needs.

Checkbox has a tap area of 48 dp by 48 dp.  To make this more obvious you could put a border around it.

Thanks you. :).

I don't see anywhere in the spec that specifies a checkbox size. https://material.io/develop/web/components/input-controls/checkboxes#checkboxes
I only see that there should be a minimum tap target of 48px square.
Flutter Checkbox does not meet Material spec.

Looks like Material spec is 24px based on https://t.co/GIkpbveao2?amp=1


ci: move docker job to release workflow

Description

Fixes # (issue)
Checklist

[ ] I have explained the need for this PR and the problem it solves
[ ] I have explained the changes or the new features added to this PR
[ ] I have added tests corresponding to this change
[ ] I have updated the documentation to reflect this change
[ ] I have verified that this change is backward compatible

Only the content has been moved, I will merge it directly.


Clear caches after the Ballerina toml update to get diagnostics

Purpose

$subject

Fixes https://github.com/ballerina-platform/ballerina-lang/issues/34378
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

IMO, Clearing the cache every time we update the Ballerina.toml could slow things down. Shall we try to identify if the package name or org name has changed, and clear the caches only in those cases?

+1

When there's a toml update, we are updating all the modules of the package and create a new package. This replaces the package cache with the newly created package. When there is a  package or org change, this does not replace the existing package in the cache due to the name change. Instead, it creates a new package. So, since the package with the old name is available in the cache, it doesn't produce a diagnostic.
With a8730a406e961bb981d11f9eb86fc52e8b790446 , we clear the old package from cache before creating the new package.


Changing terminal.integrated.persistentSessionExperimentalSerializer does not prompt for restart

Testing #131453
It's nice when the changes that require full restart show the dialog box asking the user to restart. Otherwise it's easy to reload instead and be confused.

Didn't think it was worth it here as it's a temporary just in case setting and last I looked there isn't a property to switch this on with a config schema change.


Provides ANCHOR_WALLET env var to anchor test and use it in NodeWallet

#701
Tested and works fine, anchor test is happy

Hey guys 👋
This works for anchor test but when following along with the tutorial, it breaks the node client.js step.
I had to manually provide the path to my keypair as a node environment variable for it to work:
ANCHOR_WALLET="$HOME/.config/solana/id.json" node client.js

Also, as a side note from a newcomer, I've noticed you ask for mocha to be globally installed but if you simply prefix the test script with npx on the Anchor.toml file, that's no longer necessary since it is already a dependency of the project.
[scripts]
test = "npx mocha -t 1000000 tests/"


Mewsli-X scripts

Hi Guys,
Is it possible to get training and evaluation scripts for mewsli-X dataset? We are trying to reproduce the baseline results from the XTREME-R paper (Table 4), it would helpful for us if you can share the scripts used for training the models.
Thanks

Hi @sumanthd17,
cc: @sebastianruder
Sorry for the delay here. We're working on hard to release the scripts for all the XTREME-R tasks. We hope to have this ready by the end of this month.
-- Melvin

Hi @sumanthd17,
cc: @sebastianruder
Sorry for the delay here. We're working on hard to release the scripts for all the XTREME-R tasks. We hope to have this ready by the end of this month.
-- Melvin

Hi,
We also want the new scripts to evaluate the newly added task in XTREME-R, especially mewsli-X dataset. Is it ready now?
Thanks in advance.

Hi @melvinjosej,
Is there an update on the training and eval scripts for Mewsli-X?
Thanks,

Hi @melvinjosej,
Is there an update on the training and eval scripts for Mewsli-X?
Thanks,

Hi @sumanthd17, as mentioned in https://github.com/google-research/xtreme/issues/83, we spotted some quality issues in the Mewsli-X data. We are just finalizing a fix and doing a more thorough review of the data, which has been taking longer than expected. We expect to be able to release the data soon, in about two weeks.

Hi @sebastianruder, sorry for the repeated questions. Just wanted to have a quick check if there's any update on this.
Thanks

Hi @sumanthd17, we are just finalizing the last pieces of the data creation pipeline. We'll be able to share the final data soon. We'll share training and evaluation scripts in a separate update.


export stickybit for component library compatible

@yowainwright Can you clarify this a little bit, please?

@someguynamedmatt tomorrow—lets chat! 🤓


new jadx version released

Codecov Report

Merging #558 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #558      +/-   ##
==========================================
+ Coverage    69.7%   69.73%   +0.02%
==========================================
  Files          44       44
  Lines       14139    14143       +4
==========================================
+ Hits         9855     9862       +7
+ Misses       4284     4281       -3

Impacted Files
Coverage Δ

androguard/core/__init__.py
92.3% <0%> (+3.8%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a44eb5e...dde652b. Read the comment docs.


add means of reading tiles from a buffer

Enable reading from a buffer so that the library can be used without a filesystem dependency.
Bumped the version number.

Sound great! Thanks a lot 🍻
It was published as v0.2.1.


Correct way to retrieve stix object?

Hi,
Just wondering, what is the correct way to receive a stix object? I can get the xml back and traverse through the nodes, but I cant figure out how to get a formatted object?
Cheers

I think you would need to use the Java STIX library to parse the XML into a STIX object. See https://github.com/STIXProject/java-stix


PS_CMD_FAIL_ERROR:       Error code = 0x80005000

when I invoke a command, the string was recognized correctly. then it throws an error which is "PS_CMD_FAIL_ERROR:
Error code = 0x80005000"
cloud you please to tell me how to solve it.

In my case i solved with this:
const  Shell = require("node-powershell");
const  { PSCommand }  = require("node-powershell");

const ps = new Shell({
  executionPolicy: 'Bypass',
  noProfile: true
});

// Execute Script
let script = new PSCommand(`& "${require('path').resolve(__dirname, 'MYSCRIPT.ps1')}"`);

ps.addCommand(script);


Round2 Rolecard: In round 2, player is not assigned a role and/or can't open role card.

When moving into round 2, i tried to open my role card on my desktop device. The rolecard wouldn't open, but i was getting the sound like it was and the button felt like it was responding. I reconnected using the menu button and then when i pressed the rolecard button again, I received this error:

I wasn't able to do anything from here. If i refreshed i was fine, but still happened again if i opened my rolecard. If i was in the app, I would be stuck.

confirmed that you can't see your role at all in subsequent rounds, or at least, once a player had a role, the next round they don't have one (or modal is not showing). I think the game IS assigning them a role, since in subsequent phases it showed me as having a role. must be something with the modal.

played through up to round 2 and issue seems to be resolved by fix. going to continue to end of game to confirm. (ios app, two desktop screens)

did not see this happen throughout entire game. confirmed fix.


socket server not work

how to start socket server?

php chat/webroot/server.php socket_ws  like this?
your demo console is show not connection ws://<IP_ADDRESS>:8991

pelse use php chat/webroot/main.php sock_ws start service. or check if your brower support websocket