Channels rate limits

General Troubleshooting

[V ] I have checked for similar issues.
[ V] I have updated to the latest JDA version.
[ ]V I have checked the branches or the maintainers' PRs for upcoming bug fixes.

Bug Report

I receive this error pretty often:

[JDA RateLimit-Worker 5] WARN RateLimiter - Encountered 429 on route PATCH/channels/{channel_id} with bucket 9852e1a53c06ffc5a89d65fef85ca4ce:guild_id:715535601645912114:webhook_id Retry-After: 583413 ms

I have been told that Discord changed the rate limit for channel actions, so that's probably the reason for that.

This is working as intended. Discord now has a rate limit which cannot be detected by the library so this is unavoidable. You can only update channel name/topic 2 times per 10 minutes.

Right, then your API should handle that, as it handles everything, no?

The warning message you get means that is handling it. Your code is using the blocking complete() which will simply wait 10 minutes and block the thread. You should not update the channel topic that quickly. There is nothing further JDA can do other than printing a warning and waiting 10 minutes.


Containers in removed state should not show up in list for Targets

v0.18.1
Steps:

Delete container
Go to Load Balancer page
Add a target to a Load Balancer
Click on Add Container

Results:
Containers that are in a "removed" state are still in list, even thou they are basically marked for deletion.
Expected:
Should not show "removed" containers in list

build from master - june 9th
Verified fixed


Match cleanup behavior of old temp dir utility

What does this PR do?
Ignore errors https://github.com/DataDog/integrations-core/blob/5a13fee8d9fcf97a6602c012a7d07e0da8452fb9/datadog_checks_dev/datadog_checks/dev/utils.py#L137-L144
Motivation
Docker service running as sudo will often change user/group bits of bind mounts leaving them in an un-removable state on host https://travis-ci.com/DataDog/integrations-core/builds/94857581#L760
Additional Notes
No changelog b/c TempDir has not been released

Codecov Report

Merging #2762 into master will decrease coverage by 11.06%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           master    #2762       +/-   ##
===========================================
- Coverage    84.7%   73.64%   -11.07%
===========================================
  Files         651       21      -630
  Lines       37215      664    -36551
  Branches     4491       77     -4414
===========================================
- Hits        31524      489    -31035
+ Misses       4375      148     -4227
+ Partials     1316       27     -1289


Expand to up ?

How do I make it open upwards when I click on a view at the bottom of the screen?

Is this a duplicate of https://github.com/saket/cascade/issues/21?

I'm not sure.
Now like this:

I need:

And yes I guess same problem with #15  . Sorry for being repetitive.

Closing this in favor of #15.


Fixed AWS SNS Throttling Exception

We were experiencing a lot of AmazonSimpleNotificationServiceException when starting our project

We had over 30 consumers

On startup, MassTransit is configuring the topology and calling AWS SDK FindTopicAsync Method to find the topic - this method is using ListTopics by iterating all topics until the topic is found

This method has a hard limit of 30 requests per second

Amazon Simple Notification Service endpoints and quotas

With this PR we removed the call to the FindTopicAsync AWS SDK method and instead called the CreateTopicAsync method which either returns topics (if already exist) or creates one (if it doesn't exist)

This matches the logic that was there before

There is one similar question already asked on StackOverflow with the same problem: https://stackoverflow.com/questions/70615571/am-i-missing-something-when-using-masstransit-and-amazonsqs-in-a-large-project

This will not be accepted. The whole reason for the change was to accept existing topics and queues.
A better change would be to load the topic and queue cache once instead of each call. I'm not sure how involved that would be to implement.

This will not be accepted. The whole reason for the change was to accept existing topics and queues.
A better change would be to load the topic and queue cache once instead of each call. I'm not sure how involved that would be to implement.
I believe it is a permissions issue that blocks calling create topic async, regardless of whether it already exists.

Actually, I think that the call of the GetExistingTopic method is not needed at all because it calls the FindTopicAsync AWS SDK method. The CreateMissingTopic method is already calling the CreateTopicAsync AWS SDK method which either returns the existing Topic or creates a new one (if it's missing).

Did you misread the whole part about permissions?

Did you misread the whole part about permissions?

I don't have any permission issues regarding the AWS calls. I did not add any new calls from the AWS SDK that were not already used in the existing code.
If you take a look at the current implementation of this method:

If the topic is not found the code will throw the AmazonSqsTransportException:

The execution will continue in the catch flow (Picture 1) which will call the CreateMissingTopic method. The CreateMissingTopic method calls the CreateTopicAsync AWS SDK method to Create a Topic.
My point is that the GetExistingTopic method with FindTopicAsync AWS SDK call is unnecessary in this context here. The CreateTopicAsync AWS SDK method called inside CreateMissingTopic already contains the whole logic of getting/creating a topic if it doesn't exist.

@phatboyg - what do you think about calling the GetTopicAttributes directly instead of FindTopicAsync and handling the NotFoundException? It has a larger quota in a lot of regions (or equal) compared to the ListTopic used in the FindTopicAsync.
Amazon Simple Notification Service endpoints and quotas

If it's the same as get topic and doesn't call list under the hood that would be fine with me.


writedump in code

Is this line debugging that should be removed?
https://github.com/elpete/cors/blob/master/interceptors/CORS.cfc#L39

Removed


feat(file): Added download attributes. - OEL-2772

@tibi2303 Did not you forget to remove download forced to true ? ?

Please check https://github.com/openeuropa/bootstrap-component-library/pull/583/files

See #583


Buttons in an inline button group doesn't align text correctly

Which package is this issue related to?
ffe-buttons
Describe your issue (screenshots welcome!)
When wrapping buttons in an inline button group styled anchor tags doesn't get vertically aligned text.
The problem is only visible if some other button in the button group has text which is wrapped to two lines.

The first and the last buttons are actually anchor tags. See supplied HTML.
I don't know if the same is true for other buttons than secondary, but I would assume it's at least true for all ffe-buttons.
Note that this issue specifically applies to inline button groups. Non-inline groups works as intended.
What is the expected behavior?
Text should be aligned the same whether it's an anchor or a button that's styled...
What is the actual behavior?
...but it's not :P
Steps to reproduce

        Endre

    <button class="ffe-button ffe-button--secondary ffe-button--condensed">
        Stopp

    </button>
    <button class="ffe-button ffe-button--secondary ffe-button--condensed">
        Slett

    </button>

        Flytt til aksjesparekonto

Definitely a bug - but button text should not wrap!

What's more is tertiary buttons doesn't look good in an inline group either.
Just have a look in the designguide
PS! Don't mind the second row, it's actually a thin button group, not an inline one. My bad!

What's the status here @henrikhermansen ? if you're no longer working on this, you might want to de-assign yourself :)


Fine tune JFrog Advanced Security on this project

[x] All tests have passed. If this feature is not already covered by the tests, new tests have been added.
[x] The pull request is targeting the dev branch.
[x] The code has been validated to compile successfully by running go vet ./....
[x] The code has been formatted properly using go fmt ./....

Add jfrog-apps-config.yml
Add jfrog-ignore on false positive lines

Although this is probably unrelated to these changes, let's merge after making the Xray tests green.

This is actually related. I pushed another commit to fix the test.


Acceptance testing

Should I expect the acceptance tests to all be working right now? I'm hoping to do some development here but the Acceptance Tests are failing and in some cases they are leaving dangling resources in my Looker instance. Wondering if maybe there is something wrong with my set up?

Should there be a check here for 404? Should it look like this?

@jsnb-devoted Thanks for suggestion. I could reproduce the problem. I'll take a look.


Update mavros.md

GPS setpoints can be sent via MAVROS

It is still not supported using SET_POSITION_TARGET_GLOBAL_INT message (/mavros/setpoint_raw/global topic).
They just added another topic to mavros that emulates global setpoints using local setpoint messages.
So this change is incorrect.

In this case, you should change the link to another issue. Because the issue by the link is resolved.

OK, for now the global position setpoints are actually supported.


Update winqual-submission-tool--winqualexe-.md

Hi @hraom , thanks for this. I'll merge this in and have it live shortly!


ENH picks and FIX typo

closes #2143.

Would it be easy to modify one of the existing ICA tests to expose the old failure mode, perhaps by adding a bad channel before fitting?

@Eric89GXL in the test_ica.py, here is a modified test that breaks like you asked:
def test_plot_ica_sources():
    """Test plotting of ICA panel
    """
    import matplotlib.pyplot as plt
    raw = io.Raw(raw_fname, preload=True)
    raw.info['bads'] = ['MEG 0113']  # added line
    picks = _get_picks(raw)
    epochs = _get_epochs()
    raw.pick_channels([raw.ch_names[k] for k in picks])
    ica_picks = pick_types(raw.info, meg=True, eeg=False, stim=False,
                           ecg=False, eog=False, exclude='bads')
    ica = ICA(n_components=2, max_pca_components=3, n_pca_components=3)
    ica.fit(raw, picks=ica_picks)
    ica.plot_sources(raw)
    ica.plot_sources(epochs)
    with warnings.catch_warnings(record=True):  # no labeled objects mpl
        ica.plot_sources(epochs.average())
    assert_raises(ValueError, ica.plot_sources, 'meeow')
    plt.close('all')

@teonlamont can you integrate that test, preferably making it as quick as possible maybe by cropping to 1 sec or as short as possible before calling preload_data?

ok, cool. we'll see how the bots like the changes

Changes Unknown when pulling 76ad0fdc93c086cd4f85f886774d737306a64950 on teonlamont:plot_sources into ** on mne-tools:master**.

Changes Unknown when pulling 76ad0fdc93c086cd4f85f886774d737306a64950 on teonlamont:plot_sources into ** on mne-tools:master**.

looks clean to me
@dengemann ?

Changes Unknown when pulling 0bef99772f925b82c02509502ecd24da3e5023e7 on teonlamont:plot_sources into ** on mne-tools:master**.

closes #2145. this is related to this plotting function. can be separated if need be.
We now really should deal with the ICA labeling problem mentioned in #2000.

closes #2145. this is related to this plotting function. can be separated if need be.

We now really should deal with the ICA labeling problem mentioned in #2000.

@teonlamont these ICs look terrible btw, what are you doing there?

@dengemann for the analysis I'm doing, most of the IC should look terrible because I'm trying to isolate time-locked ICs.

Something tells me that this PR does serve more than the intended goal. Could we please get back to single-purpose PRs in the future. Makes everything easier.

@dengemann I will make a separate for the clicking, this pr has been modified and rebased

Fine for now. Just for the future.
2015-05-27 13:58 GMT+02:00 Teon L Brooks<EMAIL_ADDRESS>
@dengemann https://github.com/dengemann I will make a separate for the
clicking, this pr has been modified and rebased
—
Reply to this email directly or view it on GitHub
https://github.com/mne-tools/mne-python/pull/2146#issuecomment-105884707
.

Coverage decreased (-0.09%) to 90.64% when pulling a6e46d5e42544386e87f23fef54c1ca21f7773ca on teonlamont:plot_sources into 66fbe3ba74da75727233e491d4dc88eb3109cc22 on mne-tools:master.

Coverage decreased (-0.09%) to 90.64% when pulling a6e46d5e42544386e87f23fef54c1ca21f7773ca on teonlamont:plot_sources into 66fbe3ba74da75727233e491d4dc88eb3109cc22 on mne-tools:master.

Coverage decreased (-0.09%) to 90.64% when pulling a6e46d5e42544386e87f23fef54c1ca21f7773ca on teonlamont:plot_sources into 66fbe3ba74da75727233e491d4dc88eb3109cc22 on mne-tools:master.

ok, ready for final review

@dengemann you happy with this? +1 for merge from my end and I @agramfort was happy too

LGTM!

Great, I'll merge once Travis is happy

Coverage increased (+0.0%) to 90.74% when pulling 5fafa2930b29595e52d5a8e3b5ca25c37e216d58 on teonlamont:plot_sources into 66fbe3ba74da75727233e491d4dc88eb3109cc22 on mne-tools:master.

Thanks @teonlamont, go ahead and rebase


Handling for external DOM mutations across React vs. Preact (vs. Preact X?)

I am trying to wrap an existing D3 view inside a Preact component. The D3 logic is complex and needs its DOM left alone. However, the D3 logic should be triggered every time its Component wrapper's props change  — i.e. the DOM inside is ± unidirectionally "data-driven" but takes care of its own diffing.
Looking into the right way to handle this, I am struck by a significant difference between Preact and React.
With Preact the advice according to the External DOM Mutations page in the official guide is essentially:

Always return false from shouldComponentUpdate to prevent all but the first call to render().
Trigger DOM mutations based on the new arguments to componentWillReceiveProps.

With React the situation is flipped almost completely on its head:

According to the React.Component lifecyle documentation:

In the future React may treat shouldComponentUpdate() as a hint rather than a strict directive, and returning false may still result in a re-rendering of the component.

According to their Integrating with Other Libraries:

The easiest way to avoid conflicts is to prevent the React component from updating. You can do this by rendering elements that React has no reason to update, like an empty <div />.

This seems like a fundamental incompatibility! With preact the DOM will be strictly reconciled unless I completely avoid a re-render, whereas with React there's no way to prevent re-render but the reconciliation is lax.
I guess I don't need compatibility with both (in this case), but it seems worth pointing out as I can see situations where that would be required and it's unclear what the solution would be. I'm also wondering if I should be aware of any potential changes that Preact X will bring regarding this handling?

May be related/dupe of #1250, reviewing.

@natevw That's a great question! For current preact the situation is exactly like you described. We always compare the passed children against the actual DOM and will remove any nodes that are not part of the vnode tree.
For Preact X we're in a much better position as we are not diffing against the DOM anymore, but against a second virtual tree. This aligns much better with react's behavior. Just tried the official recommendation from the react docs with Preact X and it works as expected :+1:
Seeing that the X release isn't too far away in the future I'd go with just rendering an empty div with a ref on it :)

Thanks for the quick reply! (And glad to hear; imo the React way seemed more convenient since it doesn't bypass as much of the normal lifecycle stuff….)


Autogenerated sidebarnames?

Hi,
I'm using sidebars.js with the default  tutorialSidebar: [{type: 'autogenerated', dirName: '.'}],
When I'm running npm run build I got the following error:
[papersaurus] Sidebar file '/Users/berndschimmer/dev/cdmsdoku/sidebars.js' loaded.
[papersaurus] Start processing sidebar named 'mywildguess' in version 'next'

where "mywildguess" is everything I could think of autogenerated names.
Could you give me a hint?
Thanks and regards,
Bernd

Can you please try again with Version 2.0.0?


Development

Looks good,
but I have a questions why some of the files .js and others are .ts,
please read more about typescript


Different state with the same query parameters

If we have two states, and they have the query parameters with the same name, the parent's query parameter value will be overwritten by the second one.
For example
To be more explanable, the order is changed.
Expected: localhost:8080/firstlevel?search=3/secondlevel?search=5
What happened: localhost:8080/firstlevel?search=5/secondlevel?search=5
Actual result (ui-router puts all query parameters to the end):
localhost:8080/firstlevel/secondlevel/search=5&search=5

Can you post a plnkr showing this please?

Closing due to inactivity


chromium: use clang (compilation with gcc is still possible too)

Motivation for this change

update chromium
switch to clang because upstream uses clang as primary compiler and then fix GCC problems (discussed in https://github.com/NixOS/nixpkgs/pull/48615#issuecomment-431168564). Fixes https://github.com/NixOS/nixpkgs/issues/28822

Tested chromium and chromiumDev on x86_64-linux (aarch64 is out of stock at Pocket )

It fails at the end with
[32709/32719] LINK ./v8_context_snapshot_generator
[32710/32719] ACTION //tools/v8_context_snapshot:generate_v8_context_snapshot(//build/toolchain/linux:clang_x64)
FAILED: v8_context_snapshot.bin
python ../../build/gn_run_binary.py ./v8_context_snapshot_generator --output_file=v8_context_snapshot.bin
././v8_context_snapshot_generator: error while loading shared libraries: libglib-2.0.so.0: cannot open shared object file: No such file or directory
./v8_context_snapshot_generator failed with exit code 127
ninja: build stopped: subcommand failed.
note: keeping build directory '/tmp/nix-build-chromium-71.0.3578.10.drv-0'
builder for '/nix/store/qhvh5h3as58jm47hg05d2bcws1vkn3ii-chromium-71.0.3578.10.drv' failed with exit code 1
cannot build derivation '/nix/store/sbyjw6nmkiavic3hr32nrzjid6b8v18s-chromium-dev-71.0.3578.10.drv': 1 dependencies couldn't be built
error: build of '/nix/store/sbyjw6nmkiavic3hr32nrzjid6b8v18s-chromium-dev-71.0.3578.10.drv' failed

Failure on aarch64-linux (full log)
Attempted: chromium
Partial log (click to expand)
/nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/ld.gold: error: cannot find -lgcc
obj/buildtools/third_party/libc++/libc++/ios.o:ios.cpp:function std::__1::ios_base::clear(unsigned int): error: undefined reference to '__dso_handle'
obj/buildtools/third_party/libc++/libc++/ios.o:ios.cpp:function std::__1::ios_base::clear(unsigned int): error: undefined reference to '__dso_handle'
obj/buildtools/third_party/libc++/libc++/iostream.o:iostream.cpp:function _GLOBAL__sub_I_iostream.cpp: error: undefined reference to '__dso_handle'
obj/buildtools/third_party/libc++/libc++/iostream.o:iostream.cpp:function _GLOBAL__sub_I_iostream.cpp: error: undefined reference to '__dso_handle'
clang-7: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.
builder for '/nix/store/1m8axygzhd1ca0i22kcnnglbynrkpn76-chromium-70.0.3538.67.drv' failed with exit code 1
cannot build derivation '/nix/store/qjwl1y6wak5cszqm77ya83iydvlcw9v8-chromium-70.0.3538.67.drv': 1 dependencies couldn't be built
error: build of '/nix/store/qjwl1y6wak5cszqm77ya83iydvlcw9v8-chromium-70.0.3538.67.drv' failed

Timed out, unknown build status on x86_64-linux (full log)
Attempted: chromium
Partial log (click to expand)
[1019/1111] CXX obj/v8/v8_base/utils.o
[1020/1111] CXX obj/v8/v8_base/v8threads.o
[1021/1111] CXX obj/v8/v8_base/v8.o
[1022/1111] CXX obj/v8/v8_base/vector-slot-pair.o
[1023/1111] CXX obj/v8/v8_base/version.o
[1024/1111] CXX obj/v8/v8_base/visitors.o
[1025/1111] CXX obj/v8/v8_base/value-serializer.o
building of '/nix/store/6pgqwrn0l80bqikl9swcz0h7cfj3wiph-chromium-70.0.3538.67.drv' timed out after 1800 seconds
cannot build derivation '/nix/store/xxxhqkwh7anqfrkxjhh71pc6l4lshw8m-chromium-70.0.3538.67.drv': 1 dependencies couldn't be built
error: build of '/nix/store/xxxhqkwh7anqfrkxjhh71pc6l4lshw8m-chromium-70.0.3538.67.drv' failed

Failure on aarch64-linux (full log)
Attempted: chromium
Partial log (click to expand)
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/buildtools/third_party/libc++/libc++/condition_variable.o.d -D_LIBCPP_BUILDING_LIBRARY -D_LIBCPP_OVERRIDABLE_FUNC_VIS=__attribute__\(\(__visibility__\(\"default\"\)\)\) -DLIBCXX_BUILDING_LIBCXXABI -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_GNU_SOURCE -DCR_CLANG_REVISION=\"340925-1\" -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS -DCR_LIBCXX_REVISION=332543 -DCR_LIBCXXABI_REVISION=331450 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I../.. -Igen -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pthread -fcolor-diagnostics -fmerge-all-constants -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -no-canonical-prefixes -fcomplete-member-pointers --target=aarch64-linux-gnu -O2 -fno-ident -fdata-sections -ffunction-sections -fno-omit-frame-pointer -g0 -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang enforce-in-thirdparty-webkit -Xclang -plugin-arg-find-bad-constructs -Xclang check-enum-max-value -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -fstrict-aliasing -fPIC -Wall -Wno-unused-variable -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-user-defined-warnings -Wno-unused-lambda-capture -Wno-null-pointer-arithmetic -Wno-enum-compare-switch -Wno-ignored-pragma-optimize -std=c++14 -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include -fvisibility-inlines-hidden -fexceptions -frtti -c ../../buildtools/third_party/libc++/trunk/src/condition_variable.cpp -o obj/buildtools/third_party/libc++/libc++/condition_variable.o
error: unable to load plugin '../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so': '../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so: cannot open shared object file: No such file or directory'
[33/1115] CXX obj/buildtools/third_party/libc++abi/libc++abi/cxa_handlers.o
FAILED: obj/buildtools/third_party/libc++abi/libc++abi/cxa_handlers.o
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/buildtools/third_party/libc++abi/libc++abi/cxa_handlers.o.d -DLIBCXXABI_SILENT_TERMINATE -D_LIBCPP_ENABLE_CXX17_REMOVED_UNEXPECTED_FUNCTIONS -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_GNU_SOURCE -DCR_CLANG_REVISION=\"340925-1\" -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS -DCR_LIBCXX_REVISION=332543 -DCR_LIBCXXABI_REVISION=331450 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I../.. -Igen -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pthread -fcolor-diagnostics -fmerge-all-constants -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -no-canonical-prefixes -fcomplete-member-pointers --target=aarch64-linux-gnu -O2 -fno-ident -fdata-sections -ffunction-sections -fno-omit-frame-pointer -g0 -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang enforce-in-thirdparty-webkit -Xclang -plugin-arg-find-bad-constructs -Xclang check-enum-max-value -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wall -Wno-unused-variable -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-user-defined-warnings -Wno-unused-lambda-capture -Wno-null-pointer-arithmetic -Wno-enum-compare-switch -Wno-ignored-pragma-optimize -fstrict-aliasing -fPIC -std=c++14 -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include -fvisibility-inlines-hidden -fexceptions -frtti -c ../../buildtools/third_party/libc++abi/trunk/src/cxa_handlers.cpp -o obj/buildtools/third_party/libc++abi/libc++abi/cxa_handlers.o
error: unable to load plugin '../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so': '../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so: cannot open shared object file: No such file or directory'
ninja: build stopped: subcommand failed.
builder for '/nix/store/ii9gbzqgfbvx3pcypi53zrafvfhbyims-chromium-70.0.3538.67.drv' failed with exit code 1
cannot build derivation '/nix/store/4d6vm4ijj8apdqj521pp7p2c7h99jgf9-chromium-70.0.3538.67.drv': 1 dependencies couldn't be built
error: build of '/nix/store/4d6vm4ijj8apdqj521pp7p2c7h99jgf9-chromium-70.0.3538.67.drv' failed

Failure on x86_64-linux (full log)
Attempted: chromium
Partial log (click to expand)
ninja: Entering directory `out/Release'
[1/1111] STAMP obj/build/win/default_exe_manifest.stamp
[2/1111] CXX obj/buildtools/third_party/libc++/libc++/algorithm.o
FAILED: obj/buildtools/third_party/libc++/libc++/algorithm.o
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/buildtools/third_party/libc++/libc++/algorithm.o.d -D_LIBCPP_BUILDING_LIBRARY -D_LIBCPP_OVERRIDABLE_FUNC_VIS=__attribute__\(\(__visibility__\(\"default\"\)\)\) -DLIBCXX_BUILDING_LIBCXXABI -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_GNU_SOURCE -DCR_CLANG_REVISION=\"340925-1\" -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS -DCR_LIBCXX_REVISION=332543 -DCR_LIBCXXABI_REVISION=331450 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I../.. -Igen -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pthread -fcolor-diagnostics -fmerge-all-constants -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -no-canonical-prefixes -fcomplete-member-pointers -m64 -march=x86-64 -O2 -fno-ident -fdata-sections -ffunction-sections -fno-omit-frame-pointer -g0 -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang enforce-in-thirdparty-webkit -Xclang -plugin-arg-find-bad-constructs -Xclang check-enum-max-value -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -fstrict-aliasing -fPIC -Wall -Wno-unused-variable -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-user-defined-warnings -Wno-unused-lambda-capture -Wno-null-pointer-arithmetic -Wno-enum-compare-switch -Wno-ignored-pragma-optimize -std=c++14 -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include -fvisibility-inlines-hidden -fexceptions -frtti -c ../../buildtools/third_party/libc++/trunk/src/algorithm.cpp -o obj/buildtools/third_party/libc++/libc++/algorithm.o
error: unable to load plugin '../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so': '../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so: cannot open shared object file: No such file or directory'
ninja: build stopped: subcommand failed.
builder for '/nix/store/rc4cpjg477mrrg8n5rpqigv2lwjpfj98-chromium-70.0.3538.67.drv' failed with exit code 1
cannot build derivation '/nix/store/z7qg55kvwczzxvsw1sknr1d65m0pldmh-chromium-70.0.3538.67.drv': 1 dependencies couldn't be built
error: build of '/nix/store/z7qg55kvwczzxvsw1sknr1d65m0pldmh-chromium-70.0.3538.67.drv' failed

Failure on aarch64-linux (full log)
Attempted: chromium
Partial log (click to expand)
/nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/ld.gold: error: cannot find -lgcc
obj/buildtools/third_party/libc++/libc++/ios.o:ios.cpp:function std::__1::ios_base::clear(unsigned int): error: undefined reference to '__dso_handle'
obj/buildtools/third_party/libc++/libc++/ios.o:ios.cpp:function std::__1::ios_base::clear(unsigned int): error: undefined reference to '__dso_handle'
obj/buildtools/third_party/libc++/libc++/iostream.o:iostream.cpp:function _GLOBAL__sub_I_iostream.cpp: error: undefined reference to '__dso_handle'
obj/buildtools/third_party/libc++/libc++/iostream.o:iostream.cpp:function _GLOBAL__sub_I_iostream.cpp: error: undefined reference to '__dso_handle'
clang-7: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.
builder for '/nix/store/1m8axygzhd1ca0i22kcnnglbynrkpn76-chromium-70.0.3538.67.drv' failed with exit code 1
cannot build derivation '/nix/store/qjwl1y6wak5cszqm77ya83iydvlcw9v8-chromium-70.0.3538.67.drv': 1 dependencies couldn't be built
error: build of '/nix/store/qjwl1y6wak5cszqm77ya83iydvlcw9v8-chromium-70.0.3538.67.drv' failed

Timed out, unknown build status on x86_64-linux (full log)
Attempted: chromium
Partial log (click to expand)
[1019/1111] CXX obj/v8/v8_base/utils.o
[1020/1111] CXX obj/v8/v8_base/v8threads.o
[1021/1111] CXX obj/v8/v8_base/v8.o
[1022/1111] CXX obj/v8/v8_base/vector-slot-pair.o
[1023/1111] CXX obj/v8/v8_base/version.o
[1024/1111] CXX obj/v8/v8_base/visitors.o
[1025/1111] CXX obj/v8/v8_base/value-serializer.o
building of '/nix/store/6pgqwrn0l80bqikl9swcz0h7cfj3wiph-chromium-70.0.3538.67.drv' timed out after 1800 seconds
cannot build derivation '/nix/store/xxxhqkwh7anqfrkxjhh71pc6l4lshw8m-chromium-70.0.3538.67.drv': 1 dependencies couldn't be built
error: build of '/nix/store/xxxhqkwh7anqfrkxjhh71pc6l4lshw8m-chromium-70.0.3538.67.drv' failed

Failure on aarch64-linux (full log)
Attempted: chromium
Partial log (click to expand)
/nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/ld.gold: error: cannot find -lgcc
obj/buildtools/third_party/libc++/libc++/ios.o:ios.cpp:function std::__1::ios_base::clear(unsigned int): error: undefined reference to '__dso_handle'
obj/buildtools/third_party/libc++/libc++/ios.o:ios.cpp:function std::__1::ios_base::clear(unsigned int): error: undefined reference to '__dso_handle'
obj/buildtools/third_party/libc++/libc++/iostream.o:iostream.cpp:function _GLOBAL__sub_I_iostream.cpp: error: undefined reference to '__dso_handle'
obj/buildtools/third_party/libc++/libc++/iostream.o:iostream.cpp:function _GLOBAL__sub_I_iostream.cpp: error: undefined reference to '__dso_handle'
clang-7: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.
builder for '/nix/store/di5zwazw3xr7l73d825h8wip0dlyx2kq-chromium-70.0.3538.67.drv' failed with exit code 1
cannot build derivation '/nix/store/s5pw3ik9aw85jljbwf6vc6dbvncc6whr-chromium-70.0.3538.67.drv': 1 dependencies couldn't be built
error: build of '/nix/store/s5pw3ik9aw85jljbwf6vc6dbvncc6whr-chromium-70.0.3538.67.drv' failed

Timed out, unknown build status on x86_64-linux (full log)
Attempted: chromium
Partial log (click to expand)
[1040/1111] CXX obj/v8/v8_base/loop-variable-optimizer.o
[1041/1111] CXX obj/v8/v8_base/machine-graph-verifier.o
[1042/1111] CXX obj/v8/v8_base/machine-graph.o
[1043/1111] CXX obj/v8/v8_base/machine-operator.o
[1044/1111] CXX obj/v8/v8_base/machine-operator-reducer.o
[1045/1111] CXX obj/v8/v8_base/memory-optimizer.o
[1046/1111] CXX obj/v8/v8_base/move-optimizer.o
building of '/nix/store/x4s78p6pvyqi0v6wia44nkdl16xndl2q-chromium-70.0.3538.67.drv' timed out after 1800 seconds
cannot build derivation '/nix/store/lxcgb1np9ybx15wxkz2gmla0dnamwpyq-chromium-70.0.3538.67.drv': 1 dependencies couldn't be built
error: build of '/nix/store/lxcgb1np9ybx15wxkz2gmla0dnamwpyq-chromium-70.0.3538.67.drv' failed

Timed out, unknown build status on x86_64-linux (full log)
Attempted: chromium
Partial log (click to expand)
[730/1111] CXX obj/v8/v8_base/bignum.o
[731/1111] CXX obj/v8/v8_base/bit-vector.o
[732/1111] CXX obj/v8/v8_init/setup-isolate-full.o
[733/1111] STAMP obj/v8/v8_initializers.inputdeps.stamp
[734/1111] CXX obj/v8/v8_initializers/builtins-arguments-gen.o
[735/1111] CXX obj/v8/v8_initializers/builtins-async-generator-gen.o
[736/1111] CXX obj/v8/v8_initializers/builtins-async-iterator-gen.o
building of '/nix/store/6pgqwrn0l80bqikl9swcz0h7cfj3wiph-chromium-70.0.3538.67.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/xxxhqkwh7anqfrkxjhh71pc6l4lshw8m-chromium-70.0.3538.67.drv': 1 dependencies couldn't be built
error: build of '/nix/store/xxxhqkwh7anqfrkxjhh71pc6l4lshw8m-chromium-70.0.3538.67.drv' failed

I just finished backporting GCC - related patches in https://github.com/NixOS/nixpkgs/commit/bb03fbc2c8b97ef5a4f4205eee51029155164b8a before seeing this. I'm totally open to making a switch to clang and I also suspect this might reduce the frequency of breakage in chromium. I'd like to have some more opinions before making this switch.
@volth have you noticed any difference in compile times when switching to clang?
cc @aszlig @YorikSar what's your opinion on switching to clang for chromium?

Ah, so I can rebase and make this PR smaller, without the version update

Let's wait until the 70 build is in the channels before switching.
I hope you'll get at the aarch64 issues, because switching for only x86 would mean just shifting the workload around, while increasing the overall (combined clang gcc) chance of hitting bugs.
Having more chromium updates work out of the box does sound tempting, though. Thanks for working on this.

@bendlas also GCC8 needs less patches than GCC7 (I was able to build Chromium 72 with no patches at all using GCC8); but Clang should require no patches at all.

Interesting!
Have you tried gcc8 on previous versions, and how frequently did it break?
Do you have a patch for building chromium with gcc8, by chance? I'd like to try that.

Do you have a patch for building chromium with gcc8, by chance? I'd like to try that.

The same patches as for GCC7, just some of them unnecessary for GCC8

Timed out, unknown build status on x86_64-linux (full log)
Attempted: chromium
Partial log (click to expand)
[1041/1111] CXX obj/v8/v8_base/version.o
[1042/1111] CXX obj/v8/v8_base/visitors.o
[1043/1111] CXX obj/v8/v8_base/value-serializer.o
[1044/1111] CXX obj/v8/v8_base/liftoff-assembler.o
[1045/1111] CXX obj/v8/v8_base/liftoff-compiler.o
[1046/1111] CXX obj/v8/v8_base/function-body-decoder.o
[1047/1111] CXX obj/v8/v8_base/function-compiler.o
building of '/nix/store/9w47b0d85l0bdgsngix704qrj0bm37cm-chromium-70.0.3538.67.drv' timed out after 1800 seconds
cannot build derivation '/nix/store/lrbc42y5vq2ksim8vr7xvfw312kqqqm5-chromium-70.0.3538.67.drv': 1 dependencies couldn't be built
error: build of '/nix/store/lrbc42y5vq2ksim8vr7xvfw312kqqqm5-chromium-70.0.3538.67.drv' failed

I hope you'll get at the aarch64 issues, because switching for only x86 would mean just shifting the workload around, while increasing the overall (combined clang gcc) chance of hitting bugs.

aarch64 issues seems to be related to binutils which seems to have gcc libs hardcoded
https://github.com/NixOS/nixpkgs/pull/48922#issuecomment-432458130
Also, Chromium/aarch64 has been broken for long time, so my idea is more about preserving any working Chromium/aarch64 ( outdated, or built with outdated compiler, ...) than to support every new build on aarch64. It would be difficult considering the building times on aarch64

I see, I was under the impression, that chromium/aarch64 was being used, since it received patches.
I'll try to run a clang based build ..

flashplayer-ppapi fails to build https://hastebin.com/cuxakomisu.log
running tests
        libstdc++.so.6 => not found

replacing stdenv.cc.cc -> gcc.cc in pkgs/applications/networking/browsers/chromium/plugins.nix should help
It is still building here so I could try in ~1hr

Timed out, unknown build status on x86_64-linux (full log)
Attempted: chromium
Partial log (click to expand)
[1038/1111] CXX obj/v8/v8_base/v8threads.o
[1039/1111] CXX obj/v8/v8_base/v8.o
[1040/1111] CXX obj/v8/v8_base/vector-slot-pair.o
[1041/1111] CXX obj/v8/v8_base/version.o
[1042/1111] CXX obj/v8/v8_base/visitors.o
[1043/1111] CXX obj/v8/v8_base/value-serializer.o
[1044/1111] CXX obj/v8/v8_base/liftoff-assembler.o
building of '/nix/store/9w47b0d85l0bdgsngix704qrj0bm37cm-chromium-70.0.3538.67.drv' timed out after 1800 seconds
cannot build derivation '/nix/store/lrbc42y5vq2ksim8vr7xvfw312kqqqm5-chromium-70.0.3538.67.drv': 1 dependencies couldn't be built
error: build of '/nix/store/lrbc42y5vq2ksim8vr7xvfw312kqqqm5-chromium-70.0.3538.67.drv' failed

ok, this makes the plugin build again https://github.com/NixOS/nixpkgs/compare/NixOS:cff6108...bendlas:5adb588#diff-2a0af65f37b0a602f7f0b20263c50ed2
let's see, if it works in the rebuilt chromium ...

squashed with no changes (it just was difficult to work with muiticommit patch at https://github.com/NixOS/nixpkgs/pull/48922.patch because of https://github.com/NixOS/nixpkgs/issues/37375)

Timed out, unknown build status on x86_64-linux (full log)
Attempted: chromium
Partial log (click to expand)
[1039/1111] CXX obj/v8/v8_base/v8.o
[1040/1111] CXX obj/v8/v8_base/vector-slot-pair.o
[1041/1111] CXX obj/v8/v8_base/version.o
[1042/1111] CXX obj/v8/v8_base/visitors.o
[1043/1111] CXX obj/v8/v8_base/value-serializer.o
[1044/1111] CXX obj/v8/v8_base/liftoff-assembler.o
[1045/1111] CXX obj/v8/v8_base/liftoff-compiler.o
building of '/nix/store/9w47b0d85l0bdgsngix704qrj0bm37cm-chromium-70.0.3538.67.drv' timed out after 1800 seconds
cannot build derivation '/nix/store/lrbc42y5vq2ksim8vr7xvfw312kqqqm5-chromium-70.0.3538.67.drv': 1 dependencies couldn't be built
error: build of '/nix/store/lrbc42y5vq2ksim8vr7xvfw312kqqqm5-chromium-70.0.3538.67.drv' failed

Timed out, unknown build status on aarch64-linux (full log)
Attempted: chromium
Partial log (click to expand)
                 from ../../content/browser/service_worker/embedded_worker_instance.h:25,
                 from ../../content/browser/service_worker/service_worker_version.h:30,
                 from ../../content/browser/service_worker/service_worker_ping_controller.cc:7:
gen/third_party/blink/public/platform/modules/cache_storage/cache_storage.mojom-shared-internal.h:331:53: warning: alignment 1 of 'blink::mojom::internal::CacheKeysResult_Data' is less than 8 [-Wpacked-not-aligned]
 class COMPONENT_EXPORT(MOJOM_SHARED_CONTENT_EXPORT) CacheKeysResult_Data {
                                                     ^~~~~~~~~~~~~~~~~~~~
[20683/31685] CXX obj/content/browser/browser/service_worker_navigation_loader.o
building of '/nix/store/qmx63v6ycayva8bvwwgni6jiq8ywbg0y-chromium-70.0.3538.67.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/4k5j59zkphq7gqivinci88i24z7p7a9m-chromium-70.0.3538.67.drv': 1 dependencies couldn't be built
error: build of '/nix/store/4k5j59zkphq7gqivinci88i24z7p7a9m-chromium-70.0.3538.67.drv' failed

I pushed this here along with an update https://github.com/NixOS/nixpkgs/compare/0b9a859733f452a886d1fecca538bdccf618fc64...17585ff6d8e7db7cd665f1eb8212d795c926120b
I've also added a build flag to enable building with gcc8
I'm a bit unsure on whether to pick this to stable: Switching to clang is a big move for stable, but leaving it on gcc will incur a high risk of inadvertently breaking stable when backporting updates.
70.0.3538.77 doesn't seem to have any security updates, so let's switch just master for now, and backport the clang switch along with the next security update.

I thing it is better to arrange your solution as a PR which supercedes this one

Also, you undid https://github.com/NixOS/nixpkgs/pull/48615

Using stdenv, gcc8Stdenv, llvmPackages and llvmPackages_7 inside /chromium/*.nix seems very messy.

I agree, I had a bit of a brainfart there (as in how am I going to build with gcc, when not on aarch64)
fixed https://github.com/NixOS/nixpkgs/commit/ed91407784dce5a5ebe7518fcc51581207f8027f

Also, you undid #48615

I don't think I did that, did I? https://github.com/NixOS/nixpkgs/commit/b70ab5c405f3c3b1852286696130f0112b80979b#diff-9244858114cf3ae22150773f8764edafR37


Update solc v0.6

Update the contracts to the latest solc. This is possible with the release of openzeppelin 3.0
Test Plan
CI - no significant code changes.

@e00E do you mind taking a quick look at the hack I had to add here:  https://github.com/gnosis/ethcontract-rs/pull/282/files#diff-0f582719fa997c49e0b2aab86afe0390R107-R135

@e00E I'm going to leave this open and on-hold to see if an ethabi update comes in that fixes the receive function support.


moved pure_pursuit and particle_filter and updated linting paths

Proposed changes
Moved folders pure_pursuit and particle_filter and updated linting paths.
Checklist

[x] I have read the CONTRIBUTING doc
[x] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added the necessary documentation (if appropriate)
[x] Any changes to main have been merged into my branch

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

I noticed some config files need updating still in the config folder in pure_pursuit, this might also be the case for particle_filter. Also, I think there may have been hardcoded paths within some of the source files that need updating (i.e. in pure_pursuit.cpp, etc.)

I think this is actually in waypoint visualizer, but same idea, go through packages and make sure hardcoded paths are updated


Add basic ZFS tests

Motivation for this change
Add some basic testing for zfs to be able to discover regressions in newer kernels more easily.
These are all currently failing because of linuxPackages_4_14 being both lts and latest (but did succeed when testing with linuxPackages_4_13).
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

We have a test in nixos/tests/installer.nix

@copumpkin Good feedback. It's done 👍
Also implemented tests for zfs encryption.

It would be nice to have a test that ran ztest, too.


ImportError: No module named 'wren'

pywren create_config failed for me because it couldn't import wren.
(pywren-test) ✔ ~/repos/pywren-test
12:44 $ ipython --no-banner

In [1]: import pywren
---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
<ipython-input-1-4be033962a5f> in <module>()
----> 1 import pywren

/Users/tdhopper/repos/pywren-test/pywren/pywren/__init__.py in <module>()
----> 1 import wren
      2 from wren import default_executor, wait

ImportError: No module named 'wren'```

@tdhopper Was this the result of the absolute import error you just submitted a patch for?

yes

@tdhopper @ericmjonas This is fixed now with the python3 fix ?

Closing this as it is fixed now


Upgrade from grafana?

Is there a way to upgrade from grafana 2.7.15 non-docker?

Found a way. Just need the plutono-image-renderer ...


[service-bus] Improvements to stress testers, retarget to kubernetes

We've had some infrastructure improvements and can now target a Kubernetes cluster, rather than just using ACI. This will enable some more complicated container structures and give us access to all the goodness of Kubernetes as well.
I've also made some changes to the sbStressBase (now ServiceBusStressTester) to make it a bit easier to write "correct" stress tests (ie, cleans up all resources, properly shuts down the stress test harness, and also makes sure to flush any outstanding telemetry). This also shuts off console output unless explicitly enabled, keeping us a bit cleaner for kubectl logs!

CC: @jsquire - I've translated some of the container stuff I showed you before into bash scripts, which I think might be more interesting to you than the JavaScript I had before. :)

CC: @benbp, who will probably be happy to see more K8S stuff in tree. :)


Line charts not working

I have the following code:
var chart1 = new Chartist.Line('#chart1', {
  labels: ['January', 'February', 'March', 'April', 'May', 'June', 'July', 'August', 'September', 'October', 'November', 'December'],
  series: [
    {name: 'Income', data:[20000, 30000, 10000, 52000, 30000, 32000, 90000, 12000, 180000, 394000, 30000, 190000]},
    {name:'Expenses', data:[1000, 15000, 1400, 12000, 20000, 23000, 22000, 24000, 21000, 18000, 30000,302000]},
  ]
}, {
  fullWidth: true,
  lineSmooth: false,
  showArea: true,
  chartPadding: {
    right: 20,
    left: 10
  },
  axisX: {
    labelInterpolationFnc: function(value) {
      return value.split('').slice(0, 3).join('');
    }
  },
  plugins: [
    Chartist.plugins.tooltip({currency:'$'}),
    Chartist.plugins.ctAccessibility({
      caption: 'Fiscal year 2015',
      seriesHeader: 'business numbers',
      summary: 'A graphic that shows the business numbers of the fiscal year 2015',
      valueTransform: function(value) {
        return value + ' dollar';
      }
    })
  ]
});
chart1.on('draw', function(data) {
  if(data.type === 'line' || data.type === 'area') {
    data.element.animate({
      d: {
        begin: 1000 * data.index,
        dur: 1500,
        from: data.path.clone().scale(1, 0).translate(0, data.chartRect.height()).stringify(),
        to: data.path.clone().stringify(),
        easing: Chartist.Svg.Easing.easeOutQuint
      }
    });
  }
});

And the tooltip does not appear. I tried the same code on the example page and it worked fine. It also seems to work fine on my other non-line charts.
I'm loading my plugins in the following order:
<script src="js/chartist.min.js"></script>
<script src="js/chartist-plugin-accessibility.min.js"></script>
<script src="js/chartist-plugin-legend.js"></script>
<script src="js/chartist-plugin-tooltip.min.js"></script>
<script src="js/chart1.js"></script>
<script src="js/chart2.js"></script>
<script src="js/chart3.js"></script>
<script src="js/chart4.js"></script>

Though no matter how I arrange it, the line chart will never display a tooltip. I'm also not getting any console errors at all.

One issue I had was that dots have to be displayed for tooltips to work.
Here is a working example that you can compare.
https://jsbin.com/zorimotire/edit?html,css,js,output

I noticed this issue as well. The popups will only show if there are line dots.
I would like the popup to show without the dots. Any way to achieve this?


Touch backend not working

Hi -
The documentation does not address this but is the touch backend supposed to simply add touch based dragging or it excludes the regular dragging (in which case is there an all in one backend?...)? I ask because I had setup a basic card for dragging which was working fine on the HTML5 Backend but when I switched to the TouchBackend it stopped working.
  const [{isDragging}, drag, preview] = useDrag({
    item: {
      type: ItemTypes.CARD,
    },
    collect: monitor => ({
      isDragging: !!monitor.isDragging(),
    })
  })

// structure of how I laid out the draggable component.

  // some svg icon as handler

Any help is appreciated. Thanks.

did you add options like this? <DndProvider backend={TouchBackend} options={{ enableMouseEvents: true, enableTouchEvents: false }}>

Ah that seems to have done it! Although now the preview is not working. Is
        collect: (monitor) => ({
            isDragging: monitor.isDragging(),
        }),

Not supported or called something else?

I have the same issue - preview not showing up while using TouchBackend

I have the same issue

I have the same issue

Facing the same issue.

Facing the same issue.

Hello,
TouchBackend is not working.
I'm importing like the documentations tells.

And i'm passing the provider enabling the mouse events.

I appreciate help or another solution!
Stay safe <3

Hello,
TouchBackend is not working.
I'm importing like the documentations tells.

And i'm passing the provider enabling the mouse events.

I appreciate help or another solution!
Stay safe <3

@tommasini
I had similar problem if you use conditon it doesnt work.
I swited condition to component and worked for me.
Before
<DndProvider backend={isMobile ? TouchBackend : HTML5Backend} ...>

After
{!isMobile && <DndProvider backend={HTML5Backend}>...</DndProvider>}
{isMobile && <DndProvider backend={TouchBackend}>...</DndProvider>}

Used @petrleocompel's advice and wired up my app like this:
const InitApp = () => {
  //  determine if user is on touch device using screen width to conditionally render dnd-library
  const isTouchScreen = isTouchDevice() ? TouchBackend : HTML5Backend;
  return (
    <DndProvider backend={isTouchScreen}>
          <React.StrictMode>
            <AppRouter />
          </React.StrictMode>
    </DndProvider>
  );
};

So far, it seems to be working in development!

@kdfriedman sadly yours did not work for me. I'm using SSR (nextjs).
Reason why i ended up with
{!isMobile && <DndProvider backend={HTML5Backend}>...</DndProvider>}
{isMobile && <DndProvider backend={TouchBackend}>...</DndProvider>}

@petrleocompel I see what you mean, glad you found a viable solution to your issue though. Good to know for the future if I ever use this library within nextjs, thanks for the tip.

Same problem here using NextJS. I tried the proposed solutions by @petrleocompel and @kdfriedman, but did not work =|

I would recommend you @william-hotmart  to disable SSR on certain component.
That might fix your issue. Or you can make Wrapper around DndProvider with SSR partial disable.
"Partial SSR disable" i mean on SSR return plain div on client on Rerender decide if it's HTML5Backend or TouchBackend and initialize DnD provider.
Right now I am not sure if there wont be some problem with missing DnD context.
I'm trying to make some workaround in SSR. I will try to provide my workaround solution in few days.
The problem might be this function getGlobalContext.
What I have right now in mind is something like this example - so it might remount  DnDProvider in browser because of the key.
export const CustomDndProvider = ({children}) => {
    if (isSSR()) {
         // Default SSR fallback !! might need different "manager" for overriding "context" which might cause our problem !!
         return <DndProvider key="ssr-fallback" backend={HTML5Backend}>{children}</DndProvider>
    }
    if (isMobile()) {
         return <DndProvider key="TOUCH" backend={TouchBackend}>{children}</DndProvider>
    }
    return <DndProvider key="HTML5" backend={HTML5Backend}>{children}</DndProvider>
}

@petrleocompel
By now I'm using this library and it works. But I'll try to do this without add another lib to the project. It is my goal 😄
Thanks a lot!

I have the same issue - preview not showing up while using TouchBackend
same issue


endpoint check

Coverage decreased (-0.2%) to 70.21% when pulling 31084ff11c5235c5c9731797e58f0d22ca6f24f4 on aseTo2016:aseTo2016 into 825ac0af401454629a33d7c9be9fe821b54386bb on ServiceComb:master.

Codecov Report

Merging #169 into master will decrease coverage by 0.35%.
The diff coverage is 25%.

@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
- Coverage   66.23%   65.88%   -0.36%
==========================================
  Files          18       18
  Lines        4452     4459       +7
==========================================
- Hits         2949     2938      -11
- Misses       1322     1337      +15
- Partials      181      184       +3

Impacted Files
Coverage Δ

server/service/instances.go
69.6% <0%> (-0.4%)
:arrow_down:

server/service/util/instance_util.go
49.47% <42.85%> (-0.79%)
:arrow_down:

server/service/governservice.go
68.59% <0%> (-4.34%)
:arrow_down:

server/service/tag.go
71.49% <0%> (+0.48%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 825ac0a...31084ff. Read the comment docs.

Coverage decreased (-0.3%) to 70.169% when pulling 915a5d6fca9076a518050a25da76412d5bca1c5e on aseTo2016:aseTo2016 into 825ac0af401454629a33d7c9be9fe821b54386bb on ServiceComb:master.

Coverage decreased (-0.4%) to 70.085% when pulling 0cb9bb3f0fad12eaea4170bad99b1e026ff6ac9a on aseTo2016:aseTo2016 into 825ac0af401454629a33d7c9be9fe821b54386bb on ServiceComb:master.

Coverage decreased (-0.2%) to 70.216% when pulling 0cb9bb3f0fad12eaea4170bad99b1e026ff6ac9a on aseTo2016:aseTo2016 into 825ac0af401454629a33d7c9be9fe821b54386bb on ServiceComb:master.

Coverage decreased (-0.2%) to 70.247% when pulling 0cb9bb3f0fad12eaea4170bad99b1e026ff6ac9a on aseTo2016:aseTo2016 into 825ac0af401454629a33d7c9be9fe821b54386bb on ServiceComb:master.


Give oncall write access to helm-charts, p-g-i, and scaffolding

ref https://github.com/sigstore/public-good-instance/issues/646
Signed-off-by: Priya Wadhwa<EMAIL_ADDRESS>
Summary

Release Note

Documentation

cc @var-sdk


Add etcdctl and auger

[x] etcdctl
[ ] auger

Migrated to https://github.com/uniget-org/tools/issues/57


mobile: Rename Envoy::Engine to Envoy::InternalEngine

Having two classes with the same Engine  name can be confusing. Since the Envoy::Engine is the actual implementation of Engine and it's supposed to be internal, calling it InternalEngine makes more sense.
Risk Level: low (refactoring)
Testing: CI
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

Thanks for doing this! I wonder if InternalEngine is a better name, as I usually associate (especially in Envoy) Impl with the implementation of an interface, but I agree that "impl" also makes sense here in that sense that it provides the guts of the engines actual work, that the rest of the language API's Engine classes call into. I don't feel too strongly about it either way, just some thoughts to share.
I'm just glad we don't have two Engines anymore :)

Using InternalEngine is also another name that I considered. Glad you brought that up! InternalEngine it is :)

Thanks @fredyw !


feat: add version to package.json [TOL-1178]

yes @chrishelgert this needs to be merged first so that i can see if we now successfully update the package.json then we can complete the ticket in the next pr


2.4 - newsletter bug with EMAIL_FROM

Hello harald,
On 2.4, when you try to send a newsletter, there is a problem.
EMAIL_FROM has a problem (configuration / email from)when you try to send a newsletter,
the EMAIL_FROM in db configuration is writen like this  :
configuration of EMAIL_FROM : admin admin@admin, toto<EMAIL_ADDRESS>EMAIL_FROM  in newsletter is writen like this :
/home/www/test/oscommerce2/catalog/admin/newsletters.php:19: string(45) ""admin" , 'toto' "
In this case, it's impossible to send a newsletter, an error appear.
if you write EMAIL_FROM : admin@admin ==> newsletter work
if you write EMAIL_FROM : admin@admin, <EMAIL_ADDRESS>==> newsletter does'nt work
if you write EMAIL_FROM : admin@admin, <EMAIL_ADDRESS>==> newsletter does'nt work
if you write EMAIL_FROM : admin admin@admin ==> newsletter does'nt work
if you write EMAIL_FROM : admin admin@admin, toto<EMAIL_ADDRESS>==> newsletter does'nt work
server :7.0.8-0ubuntu<IP_ADDRESS> (Zend : 3.0.0)
MySQL 5.7.13-0ubuntu<IP_ADDRESS>

htmlentities(EMAIL_FROM) seems to be the solution

The email from field should only contain one email address, either with a name or without. Multiple from addresses are not supported properly (this hasn't been tested or looked into).
The format is pretty strict so EMAIL_FROM should be split into EMAIL_FROM_NAME (which can be empty) and EMAIL_FROM_ADDRESS (which is required). The email class can then properly set the from value.


[AIRFLOW-1085]  Passing the Spark home, driver memoryu, and Java application class to the SparkSubmitOperator

Dear Airflow maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[ ] My PR addresses the following Airflow JIRA issues and references them in the PR title.

https://issues.apache.org/jira/browse/AIRFLOW-1085

Description

[ ] Adds the ability to pass the Spark home, driver memory, and Java main class to the SparkSubmitOperator.

Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:
Adds:
contrib.hooks.spark_submit_hook.TestSparkSubmitHook.test_submit_cmd
Modifies:
contrib.hooks.spark_submit_hook.TestSparkSubmitHook.test_build_command
contrib.operators.spark_submit_operator.TestSparkSubmitOperator.test_execute

Commits

[ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #2211 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2211      +/-   ##
==========================================
+ Coverage    67.5%   67.54%   +0.03%
==========================================
  Files         142      142
  Lines       10845    10845
==========================================
+ Hits         7321     7325       +4
+ Misses       3524     3520       -4

Impacted Files
Coverage Δ

airflow/jobs.py
73.35% <0%> (+0.41%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b55f41f...1999483. Read the comment docs.

@camshrun Thanks for your contribution. Please adhere to the commit guidelines.
@Fokko can you review this? I think the operator should obtain spark_home from the connection and not from the constructor.

@camshrun Thank you for your contribution, looks like a good addition.
However I have one comment. Personally I would integrate the SPARK_HOME variable in the connection string, by extracting this from the piggybacked json, see:
https://github.com/camshrun/incubator-airflow/blob/199948356d6812aab8513eb77dfc85fda332551d/airflow/contrib/hooks/spark_submit_hook.py#L102
Passing the driver memory, and the Java application class is fine to pass it directly to the operator. When something affects all the spark-submit job, I would put it in the connection. If the parameter should be tuned per job, such as the memory or entry class, I would suggest passing it to the hook itself.

@Fokko  Thanks for the feedback.  I will move the spark home into the extra in the connection.

Please squash and verify your commit message against the guidelines. Then I'll merge.

@bolkedebruin I have squashed the commit and updated the commit message.

I will merge but your commit message still does not comply, next time please read and adjust

@bolkedebruin Thank you.  Is there any feedback you can give me about the commit message so I can be better contributor to this project?

See under commits iv.

@bolkedebruin Thanks. I see now.

@camshrun also specify the correct lira next time plz.


GoogleDataTransport version update request

flutter pub add google_mlkit_face_detection
ios pod update

[!] CocoaPods could not find compatible versions for pod "GoogleDataTransport":
In snapshot (Podfile.lock):
GoogleDataTransport (= 10.1.0, ~> 10.0)
In Podfile:
firebase_crashlytics (from .symlinks/plugins/firebase_crashlytics/ios) was resolved to 4.1.1, which depends on
Firebase/Crashlytics (= 11.0.0) was resolved to 11.0.0, which depends on
FirebaseCrashlytics (~> 11.0.0) was resolved to 11.0.0, which depends on
GoogleDataTransport (~> 10.0)
google_mlkit_face_detection (from `.symlinks/plugins/google_mlkit_face_detection/ios`) was resolved to 0.11.0, which depends on
  GoogleMLKit/FaceDetection (~> 6.0.0) was resolved to 6.0.0, which depends on
    GoogleMLKit/MLKitCore (= 6.0.0) was resolved to 6.0.0, which depends on
      MLKitCommon (~> 11.0.0) was resolved to 11.0.0, which depends on
        GoogleDataTransport (< 10.0, >= 9.4.1)

You have either:

changed the constraints of dependency GoogleDataTransport inside your development pod google_mlkit_face_detection.
You should run pod update GoogleDataTransport to apply changes you've made.

Please update to the latest version.

Bump

Apparently, the last ML Kit release for iOS was in April. There are no updates since then. See https://developers.google.com/ml-kit/release-notes
That's a bummer because, we're also running into that issue

Apparently, the last ML Kit release for iOS was in April. There are no updates since then. See https://developers.google.com/ml-kit/release-notes. So no easy fix as of now.
That's a bummer because we're also running into that issue

Hello,
Do you have any recommendations or the best approach is just to wait for ML Kit new release?
Thanks

Apparently, the last ML Kit release for iOS was in April. There are no updates since then. See https://developers.google.com/ml-kit/release-notes. So no easy fix as of now.
That's a bummer because we're also running into that issue

Hello,
Do you have any recommendations or the best approach is just to wait for ML Kit new release?
Thanks

@simeonangelov94 I'm temporarily using gemini to upload an image and write a prompt to receive the results.

Apparently, the last ML Kit release for iOS was in April. There are no updates since then. See https://developers.google.com/ml-kit/release-notes. So no easy fix as of now.
That's a bummer because we're also running into that issue

This is a duplicate issue #669 and I commented already that no update for iOS #comment
I have to close this too.
@ueman thanks for the comment


Adding retrying mechanims to connect Kafka cluster on startup

This PR fixes #33 adding a retrying mechanism to connect Kafka cluster during startup to avoid just exiting if the cluster is not available yet.

FYI @tomncooper @k-wall

Doesn't this algorithm give unreasonably short backoffs for the the first few attempts, and then (unclamped as it it) excessively large values later?
Am I missing something?
=== RUN   TestBackoffMoreDelay2
attempt 0  Duration 0 ms
attempt 1  Duration 0 ms
attempt 2  Duration 0 ms
attempt 3  Duration 0 ms
attempt 4  Duration 0 ms
attempt 5  Duration 0 ms
attempt 6  Duration 0 ms
attempt 7  Duration 0 ms
attempt 8  Duration 1 ms
attempt 9  Duration 2 ms
attempt 10  Duration 5 ms
attempt 11  Duration 10 ms
attempt 12  Duration 20 ms
attempt 13  Duration 40 ms
attempt 14  Duration 81 ms
attempt 15  Duration 163 ms
attempt 16  Duration 327 ms
attempt 17  Duration 655 ms
attempt 18  Duration 1 seconds
attempt 19  Duration 2 seconds
attempt 20  Duration 5 seconds
attempt 21  Duration 10 seconds
attempt 22  Duration 20 seconds
attempt 23  Duration 41 seconds
attempt 24  Duration 1 minutes 23 seconds
attempt 25  Duration 2 minutes 47 seconds
attempt 26  Duration 5 minutes 35 seconds
attempt 27  Duration 11 minutes 11 seconds
attempt 28  Duration 22 minutes 22 seconds
attempt 29  Duration 44 minutes 44 seconds
--- PASS: TestBackoffMoreDelay2 (0.00s)

@k-wall this is the same kind of backoff algorithm we use within Strimzi having 2 as the base of actually doubling the wait. what your test is doing? which scale did you set? Do you have a different idea about the backoff?

@k-wall this is the same kind of backoff algorithm we use within Strimzi having 2 as the base of actually doubling the wait. what your test is doing? which scale did you set? Do you have a different idea about the backoff?
Did you mean something that actually works in the other way around? Longer delay at the beginning and shorter later?
If that's the case I can see your point. The Kafka cluster will take time to be up and running so we could start with long delay but then decreasing because more likely it becomes ready when time passes.
I will explore that way then.

firstly, the code seems weird:
/ Delay computes a delay in milliseconds based on the current Backoff instance configuration
// Returns the delay in milliseconds and an error if the max attempts is reached, otherwise it's nil
func (b *Backoff) Delay() (time.Duration, error) {

Duration is defined as a number of nanoseconds.  The comment doesn't seem to respect this.
second, exponential backoff is fine, but it should be clamped to an upper value.  The point of a backoff algorithm is to balance the avoid a tight loop whist retrying in a timely fashion.  As soon as retry intervals get into hours, days, worse, it is pointless.  I'd clamp to say 5 minutes.

Duration is defined as a number of nanoseconds. The comment doesn't seem to respect this.

I agree on this, it should be a mistake as a newbie on Go when I wrote this code. I will fix this in a different PR.

second, an increasing exponential backoff is fine, but it should be clamped to an upper value. The point of a backoff algorithm is to balance the avoid a tight loop whist retrying in a timely fashion. As soon as retry intervals get into hours, days, worse, it is pointless. I'd clamp to say 5 minutes.

I agree but not sure with what you are asking for.
Thinking more, isn't the idea of having an "inverse" backoff better?

Duration is defined as a number of nanoseconds. The comment doesn't seem to respect this.

I agree on this, it should be a mistake as a newbie on Go when I wrote this code. I will fix this in a different PR.

Thanks

second, an increasing exponential backoff is fine, but it should be clamped to an upper value. The point of a backoff algorithm is to balance the avoid a tight loop whist retrying in a timely fashion. As soon as retry intervals get into hours, days, worse, it is pointless. I'd clamp to say 5 minutes.

I agree but not sure with what you are asking for.
Thinking more, isn't the idea of having an "inverse" backoff better?

Let's keep it simple - stick with a standard exponential backoff but add a clamp (upper bound), at 1 minute or 5 minutes.

@k-wall Now that scale is configurable the max delay is implicit in the attempt/scale setting: max-delay = scale * 2^max-attempt

Yes was going to say the same, we have an upper bound based on the max attempts, so why we should specify another parameter for it?

You could add a sanity check that makes sure that equation is always less than some value? some fraction of a day?

I opened #35 about backoff in correct Duration terms.

@k-wall can you have another pass please now that #35 is merged and this branch rebased on that? Thanks!

Looks good to me.


Support migrating VMs between Proxmox nodes

Feature Request
Description
While trying out the tool I noticed that VMs that have disk attached through proxmox-csi-plugin cannot be migrated anymore. Proxmox complains that the disks are owned by a different VM, namely the non-existent VM 9999. I searched if there was some way to force Proxmox to migrate the VM, but I could not find anything. I could only find ways that included a lot of manual work and downtime for the VM that will be migrated, which is not desirable.
Then I realized that even if Proxmox allowed the migration, this will probably mess up the administration of the PVs for the proxmox-csi-plugin. The volumeHandle and the nodeAffinity would not be correct anymore.
So my question/feature request is, would there be any way to support migrating VMs with disks provisioned by proxmox-csi-plugin? Ideally without any downtime to VM and/or pods, but if this is required than at least in an automated fashion and with minimal downtime.
Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request

PS. Thank you for this awesome project, integrating Kubernetes with Proxmox is a great idea and the implementation works really really well.

Hi, I hope you have found the answer already. I wanted to share some information about the limitations of Kubernetes and Proxmox. Kubernetes has values that cannot be changed after they are set. Proxmox can only move the VM if the disk is part of that VM.
In Kubernetes, PV/PVC is not part of the VM. That’s why the disk ID is 9999. There is no way to rename the disk either. The name of the block disk is the ID of the PV in Kubernetes, and there is no metadata for the block device — only the name.
Lastly, Kubernetes has a feature called node drain. It moves the pod to a different place. This is the main idea of Kubernetes.
During VM migration, you may have noticed a performance issue. It seems like VM migration might not be the best option for what you need.
PS. Please let me know why you need VM migration if you feel it is important for your situation.


Minor code cleanup

In an attempt to familiarize myself with this code base, I've ran pylint on the code and fixed some minor warnings. None of these changes should alter the behavior in any way.
I don't feel comfortable making changes that modify behavior at this point in time, since I do not have an environment to test changes. Perhaps I can knock out an item or two in the TODO list in the future.

Can you apply your changes to the latest version of the code base and resubmit the pull request? I'd be happy to integrate it.  Thanks.

guess theyre never gonna do it. What a shame

Merged in several of the changes manually because I don't know how to properly use git.


What about custom component and validate props for the redux field?

Hey, saw you at the PHPUK conference the other day, great talk!
Wanted to checkout this liform library, as loading a redux-form from a json file is exactly what I was looking for.
Question is, does it have the ability to use custom component and validate props for the redux Field?
So for example how would I map out the following in the json:
        <Field
          name="email"
          component={TextField} // custom component I import
          type="email"
          label={t('form.label.email')}
          validate={[required, email]} // email and required are custom validatiors I import
        />
        <Button
          type="submit"
          disabled={ this.props.submitting }
          text={t('form.button.submit')}
        />

Hi and thanks!
Yes, basically this kind of customisation is why we created the library (the bootstrap theme that comes with the library is not the one we use, our widgets are very particular). I have created some sample code for you: https://github.com/nacmartin/liform-daniel-example
It is also running here: https://nacmartin.github.io/liform-daniel-example/
Out of the box you have validation using ajv, so if you specify a required option or/and a format in the json-schema, they will be used for validation.
The second example shows how to create a custom widget with some specific validation.
And the third example shows how to change the form layout, in case you want to customise your submit button or something like that.
I will work further on the documentation of this library, because although all of this is explained there, it is scattered in several pages. So maybe some kind of step-by-step tutorial like the one I just did for your use case would clarify ideas.

Thanks so much, I will be giving it a go this coming week. Great idea, glad I found you at the conference :-) keep up the great work!

How would you handle translations? for example I am using react-i18next, and I would need to pass the "t" function down to the custom widget or make sure the translation happens before the labels even get the to the widget.
thanks in advance!

Sorry to bug again, also just wondering how would you handle fields dependent on other fields, e.g. ticking a checkbox shows an additional field http://redux-form.com/6.5.0/examples/selectingFormValues/

Hi, About the i18n. We don't have that need at the moment but I think that it is important to have it as soon as possible, so I have added support for using it in custom widgets (the default theme doesn't have it because it would mean to choose a i18n lib and force people to download it with this library).
It was technically posible to decorate custom fields with the react-i18n next decorator to have i18n, but I guess that it is better to just decorate the form, so now it is possible.
So there is now a 4th example in https://nacmartin.github.io/liform-daniel-example/
https://github.com/nacmartin/liform-daniel-example/blob/master/src/js/Example4.js
Basically you can now pass a "context" object https://github.com/nacmartin/liform-daniel-example/blob/a69542329aebf65ff22426bb93721b80b09c3e49/src/js/Example4.js#L104
And then it is available in the fields you write: https://github.com/nacmartin/liform-daniel-example/blob/a69542329aebf65ff22426bb93721b80b09c3e49/src/js/Example4.js#L18
There is also the built-in validation, in that case I'd  pass your own sync validator based on the one that liform-react is using, but translating the messages with the i18n addon of the ajv validator.

About the dependant fields, I think that is doable right now, especially if you can define the structure of the json-schema. In that case I group these two fields, nesting them in an object, and rendering that object with a custom widget. In that widget you can pretty much do whatever you want using redux-form. I will try to find the time to write an example... arf, I have also to find time to document all the stuff we are talking about, i18n and so on, so other people can find it :)


Add missing QualityLabel

I received this error message with some videos
"Could not acquire the player response from the watch HTML!
It looks like YouTube changed it's API again :-/
If this not yet reported, it would be great if you could file an issue:

So after checking the JSON configuration, I found that the QualityLabel enum doesn't have this value: 1440p50.
For this reason the deserialization failed.
Maybe related to https://github.com/DzenanJupic/rustube/issues/69

Thanks for the PR


drivers: pwm: Fix some compilation errors when CONFIG_PWM_CAPTURE=n

When CONFIG_PWM_CAPTURE=n, all the api of pwm capture must be disabled
to compile correctly.
Signed-off-by: Julien D'Ascenzio<EMAIL_ADDRESS>

I can't reproduce the compilation errors I had ... Sorry, I must have made a mistake when I fetched the latest zephyr commits. I close this pull request

I can't reproduce the compilation errors I had ... Sorry, I must have made a mistake when I fetched the latest zephyr commits. I close this pull request


Twig function url is incorrect for image thumbnail files

Pretty sure this is a bug. I have a thumbnail file using the pattern [image-name].[extension].thumb.[ext] described in Thumbnail Location item 1.
When I dump [image].thumbnail('page').display('thumbnail').html I get an img tag with the correct path to thumbnail file as src attribute.
However, when I ask for [image].thumbnail('page').display('thumbnail').url, I get the path to the image itself, not its thumbnail file.
Both of these expressions return expected results when a thumbnail file is not provided.
Am I using the correct expression? If not, I think there's a bug.

Hmm.. i can't replicate this:
Thumbnail Exists: {{ media['progress.jpg'].thumbnailExists() ? "yes" : "no" }}

Image: {{ media['progress.jpg'].display('thumbnail').html() }}

URL: {{ media['progress.jpg'].thumbnail('page').display('thumbnail').url() }}

Screenshot: https://trilby.d.pr/CCOx61

I had a similar problem and clearing the cache solved it.
I have manually added (not via the admin plugin) the thumbnail for a video after loading the page; the thumbnail would only be recognized after the cache was cleared.


File missing

Hi,
Could you please provide the file language_pair_dataset.py for data preprocessing? Thank you.

The file is provided in ./fairseq/data/language_pair_dataset.py. It is very similar to the original Fairseq's implementation, the only difference being that both input and output information is saved for bidirectional translation.


Put function node in try catch

Current Behavior
When a function node throws uncaught exception node-red crashes.
Expected Behavior
When a function node throws uncaught exception node-red should log the error and not crash.
Steps To Reproduce
have a function node throw uncaught exception.
Example flow
No response
Environment

Node-RED version: 3.1.9
Node.js version:20.x
npm version:
Platform/OS: apline docker
Browser: chrome

Throwing errors in a function node do not crash node-red unless the error is occurring in an async function.
You can test this yourself with a simple function:
throw new Error('does node red crash?")

Here is some proof:

[{"id":"d8777424e868d0da","type":"inject","z":"85fb8b6df2be7ac8","name":"","props":[{"p":"payload"},{"p":"topic","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","payload":"","payloadType":"date","x":1280,"y":60,"wires":[["797fe9ac0a832c30"]]},{"id":"797fe9ac0a832c30","type":"function","z":"85fb8b6df2be7ac8","name":"throw an error","func":"throw new Error('did node-red crash?')\n","outputs":1,"timeout":0,"noerr":0,"initialize":"","finalize":"","libs":[],"x":1500,"y":60,"wires":[[]]},{"id":"b4cc4bb3edaf2698","type":"function","z":"85fb8b6df2be7ac8","name":"throw an error in callback","func":"\nsetTimeout(function() {\n    throw new Error('did node-red crash?')    \n}, 10);\n\n\n","outputs":1,"timeout":0,"noerr":0,"initialize":"","finalize":"","libs":[],"x":1530,"y":120,"wires":[[]]},{"id":"e239976943cfe43f","type":"inject","z":"85fb8b6df2be7ac8","name":"","props":[{"p":"payload"},{"p":"topic","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","payload":"","payloadType":"date","x":1280,"y":120,"wires":[["b4cc4bb3edaf2698"]]},{"id":"9e39161661fd0134","type":"inject","z":"85fb8b6df2be7ac8","name":"","props":[{"p":"payload"},{"p":"topic","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","payload":"","payloadType":"date","x":1280,"y":180,"wires":[["4695944cf538b803"]]},{"id":"4695944cf538b803","type":"function","z":"85fb8b6df2be7ac8","name":"throw an error in async callback","func":"\nsetTimeout(async function() {\n    throw new Error('did node-red crash?')    \n}, 10);\n\n\n","outputs":1,"timeout":0,"noerr":0,"initialize":"","finalize":"","libs":[],"x":1550,"y":180,"wires":[[]]}]

A node application crashing on uncaught exceptions is the correct behaviour since uncaught exceptions indicate that the application is in an undefined state.
In short, this is down to the user programming. Here is a recent example of this: https://discourse.nodered.org/t/nodered-container-crash-everyday/86933/7?u=steve-mcl

A node application crashing on uncaught exceptions is the correct behaviour since uncaught exceptions indicate that the application is in an undefined state.

Just to reiterate what Steve said, this is specifically related to uncaught exceptions in an async callback function. By their very nature, they cannot be handled by a try/catch in the Function node. Similarly, when they do occur, we have no way of identifying which node (Function node or otherwise) led to the async exception happening. This is just how Node.js works and not something we can work around.
Can you provide an example of your code that is causing Node-RED to crash?

First of all thanks for responding so fast. I really appreciate all the work you do. And you are right, it was an async web call using axios in function node. It was a user (me) error for not handling the axios errors. I am wondering if there is any way to not let whole node-red to crash in case of boo-boos made by users ? apologies, I am not an experienced nodejs programmer so it may may be a dumb idea, but could node-red wrap function node in async await and catches the error at wrapper  ? something like this where "run" function is a node-red wrapper over user created function node "thisThrows".
async function thisThrows() {
    throw new Error("Thrown from thisThrows()");
}

async function run() {
    try {
        await thisThrows();
    } catch (e) {
        console.error(e);
    } finally {
        console.log('We do cleanup here');
    }
}

run();

I am wondering if there is any way to not let whole node-red to crash in case of boo-boos made by users ?

Its a tough one. The node.js docs themselves recommend not trying to recover from an uncaught exception because you simply don't know what failed and what state anything is in - restarting the runtime is the safest action to take.
We are pretty much reliant on what node.js provides us in terms of capturing and logging such errors - and there isn't a lot more we can do.
I'm going to close this issue off as we don't have any immediate actions to take here. But this is a general topic we keep an eye on in case node.js introduces anything that could help us.


Replace INonceCache by IDistributedCache

Fixes https://github.com/aspnet/Security/issues/212.
For the first attempt, I opted for the "hybrid" approach (https://github.com/aspnet/Security/issues/212#issuecomment-112533342): the distributed cache is retrieved from the options when available, and from the DI container when the user didn't provide his own cache.
Storing nonces in the distributed cache is not enabled by default but can easily be using StoreNoncesInCache. I'm not super satisfied with the name, so don't hesitate to suggest another one :smile:
FYI, I haven't been able to use the OpenIdConnectSample app because it delegates authentication to AAD, that doesn't allow me to log in using my live.com account. I worked around this issue using AspNet.Security.OpenIdConnect.Server (https://github.com/aspnet-contrib/AspNet.Security.OpenIdConnect.Server).
Of course, I'll revert these changes before merging (though depending on AAD is not really a good idea IMHO).

/cc @Eilon @HaoK @Tratcher

In regards to name, would CacheNonces be correct?

@HaoK name updated, thanks :smile:

Looks good. Remove aspnet-contrib and squash.

@Tratcher is there a public identity provider supporting OIDC that we could use to replace AAD?
Because not being able to run the samples is a bit annoying, specially since I'd like to start working on the POST authorization requests thing, that will require much testing.

.resx item renamed. And squashed :smile:

None that I know of. That has been one of our big problems verifying the middleware at all.


Add support for new SCIM Server Management API endpoints

🔧 Changes

Add endpoints for SCIM configuration management.
Include CRUD operations for SCIM configurations and tokens.
Add test cases to verify the functionality of the new endpoints.
Add structs and marshaller for SCIM configuration and tokens.

📚 References

API documentation for Create SCIM Configuration
API documentation for Read SCIM Configuration
API documentation for Update SCIM Configuration
API documentation for Delete SCIM Configuration
API documentation for Read SCIM Default Configuration
API documentation for Create SCIM Token
API documentation for List SCIM Tokens
API documentation for Delete SCIM Token

🔬 Testing

Run unit tests to ensure the SCIM configuration and token endpoints work correctly.
Manually test the endpoints using a tool like Postman to ensure they function as expected.
Verify that the SCIM configuration is properly created, read, updated, and deleted.

📝 Checklist

[x] All new/changed/fixed functionality is covered by tests (or N/A)
[x] I have added documentation for all new/changed functionality (or N/A)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.44%. Comparing base (aaf54a7) to head (2bf9aeb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #419      +/-   ##
==========================================
+ Coverage   95.37%   95.44%   +0.06%
==========================================
  Files          47       47
  Lines        7614     7725     +111
==========================================
+ Hits         7262     7373     +111
  Misses        235      235
  Partials      117      117

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Create Helm Charts for the controllers

PRs:

https://github.com/open-component-model/git-controller/pull/65
https://github.com/open-component-model/replication-controller/pull/62
https://github.com/open-component-model/mpas-project-controller/pull/34
https://github.com/open-component-model/mpas-product-controller/pull/51
https://github.com/open-component-model/ocm-controller/pull/263

@shivenduverma-sap I don't see any helm charts in that PR just some script to generate them. Where are the helm charts? I would expect to see them in the repos under helm. With proper descriptions of the product, etc.

@Skarlso
The charts are now there under the helm dir
The aim was to automate it to be used by others and is also available when you release, I need it for another project as well
Do you have any documentation/code describing the proper descriptions of the product, possible values set, certificate configuration options, etc. ? I would consider that part of a documentation ticket

We are planning on creating a helm chart that has all the components together and has the option to turn off certain controllers. The values could also include things like affinities, resource limits/requests, and a bunch of other configurations for the deployments. The helm chart description should be something that describes the encompassing MPAS system.

Please take over the ticket and add the relevant things as you guys know more about this ticket

We didn't really know the details until you picked up the ticket. :) Since the ticket didn't have any detail, we thought that we'll have a chat about it, or something. Instead you went off and returned with a half backed generated solution that you talked with no-one about, started releasing the main component without forking it first, and deleting releases. If this would be a majorly used project your actions could have potentially caused a lot of damage.
This is in no way a proper working practice. Please be more patient and try asking questions if something is not clear instead of following your own decisions.

Hi @morri-son @robertwol ,
We agreed in the review on 22 Sep to create a separate ticket for creating Helm Charts in the MPAS Backlog. This ticket does not need a second opinion

Hi @Skarlso @phoban01 ,
Could you link the relevant ticket to address this topic like we discussed, so we can close this one, please.
Cheers
Robert


Allow for configuration of the runner title

When there's a couple of projects or configurations running at once, it helps to distinguish between them. In my particular case I have separate debug & coverage builds.

What exactly do you mean? The title of the html page?


CASMINST-4794: Correct misspellings and one other error, of varying severities

Summary and Scope

Fixes # CASMINST-4794

Issue Type

Bugfix Pull Request
Docs Pull Request

I originally opened this to correct the fact that the help docs state the incorrect default value for the --s3-secret argument when doing the NCN image handoff. The default was changed between csm-1.0 and csm-1.2, but the help docs were not updated to reflect that.
While I was making that change, I noticed some misspellings in messages that were displayed to the user, and in some of the code comments. This ticket fixes those as well.
Finally, I noticed that one of the kernel parameter values in the pit/dnsmasq.go file had a typo that would have caused problems if it was used. Since this error has not been reported by anyone, I'm assuming that the string with the typo is not frequently used. Nevertheless, it seemed like something we should correct.
Prerequisites

[X] I have included documentation in my PR (or it is not required)

I did no testing of this because none of my changes were really testable (beyond, I guess, the mistake in the dnsmasq file. But I don't know how to test that, and inspection of the change that I made makes it obvious that it previously was a typo and my change is what was intended.
Idempotency
N/A
Risks and Mitigations
Only one change in this PR modifies anything other than strings that are output to the user, and that is the one character typo fix in the dnsmasq file. Because of this, I think the risk of including this PR is very small. Given that nobody has reported any of these issues (to my knowledge), it's probably also true that the risk of not including it is small. However, since I believe every single one of these changes is completely uncontroversial and also tiny in scope, I think the better course is to make these changes.

/backport main


Syntax Error in ruby3

vendor/bundle/ruby/3.0.0/gems/protobuf_transpiler-1.1.1/lib/protobuf_transpiler.rb:160: syntax error, unexpected ')', expecting local variable or method
  def each_oneof(&)

just launch irb in ruby3, and define any method:
def a(&)
   p 'test'
end

will report SyntaxError

Hi.
Thank you for your feedback. You're right: anonymous block argument was introduced in Ruby 3.1.
We just released version 1.1.2 with the fix to the issue.
Have a nice day.


Korea / Asia added

Korea / Asia added

Thanks!
BTW, do you mind deleting your forked repo before making another PR? The GitHub Actions keep failing, which appears to be some sort of bug on GitHub's side. Making a fresh fork might fix that.

Thanks!
BTW, do you mind deleting your forked repo before making another PR? The GitHub Actions keep failing, which appears to be some sort of bug on GitHub's side. Making a fresh fork might fix that.

ok


Allow developers to use BitcoinKit with other coin types

What problem does this feature solve?
It will allow developers to support additional coin types in their apps (i.e. coin types other than just BTC and BCH)
Describe what you've considered?
BitcoinKit has built-in support for BTC like some of the C/C++ libraries that are available for download.  In addition, BitcoinKit has built-in support for BCH and this is great because BCH uses the BTC source code.
However, BitcoinKit doesn't allow users to add support for other coin types that use the BTC source code.  This seems too restrictive since the BTC source code is also used by coin types other than BCH (e.g. LTC, DASH, ...).  Also, most of the BTC libraries that I've seen let developers support use their code with any coin type that following the Bitcoin protocol.
Anyways, I think that BitcoinKit should allow developers to support any coin type that follows the Bitcoin protocol.
Code sample / Spec

Last year, I created the following crypto wallet app using a slightly modified version of BitcoinKit:
https://apps.apple.com/us/app/vaulttel-by-toriia/id1435978573
This app supports BTC, LTC, DASH, DOGE, BlockCypher and stores keys in a microSD card.

Hi, thank you for giving us your feedback.
What features or types do you exactly need?
BitcoinKit is fundamentally a tool for building Bitcoin applications.
So, making it usable for other coin types are optional.
However, if the change also makes this library more readable or secure, we're very happy to make the change.


add adventure command i mean just for outwest adventure

it would be good if there was a adventure cmd its a ez way to get rich

duplicate issue post


pull request for e2e test at 01/11/2017 09:26:13

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Bug_Pagination> Default Selected/ Adjacent Pages/ Edge Pages> 'defaultPage'' control prop> Default page does not change in Navigation bar of Preview if user change 'defaultPage' value.

Describe the bug

Default page does not change in Navigation bar of Preview if user change 'defaultPage' value
Also, observed that if user reloads the page after changing the value, Navigation bar in Preview window reflects the change but 'defaultPage' value in controls is still same i.e. 2.

To Reproduce
Steps to reproduce the behavior:

Go to https://storybook-preview-290--upbeat-sinoussi-f675aa.netlify.app/?path=/story/pagination--default
Click on 'Controls'
Navigate to 'defaultPage' controls
Change the value
Verify the Preview
Reload the browser page
Verify that previously changed value is selected in navigation bar of Preview but controls reflects the default valye i.e. 2

Expected behavior

Default page should change in Navigation bar of Preview if user changes 'defaultPage' value.
OR
If user reloads the page after changing the value, 'defaultPage' value in controls should appear same as the value appears in navigation bar.

Screencast
https://somup.com/c3nbIiThyw
Desktop:
OS: [Win 10]
Browser [chrome]
Version [Version 98.0.4758.82 (Official Build) (64-bit)]

Changing defaultPage in storybook will not cause a full re-render, which is how that prop gets propagated. I tested it on our codesandbox that is linked in the docs and the defaultPage is being used on initial render as expected.


fix: render fail on workspace dropdown in req group settings

changelog(Fixes): Fixed an issue where the workspace dropdown in the request folder settings would sometimes return an render fail error when picking through different workspaces to move/copy to.
Copying the approach we do for the same dropdown in request settings was enough to fix the issue.

We should merge the sidebar rewrite and retest this


pause/resume AKPlayer.

pause()
resume()
added to AKPlayer. Changes to Loop behavior in regard to pausing. It's now possible to pause and resume a looping player. This has been asked for a bunch of times...
Issue:
https://github.com/AudioKit/AudioKit/issues/1272

This PR isn't passing Travis:
❌  /Users/travis/build/AudioKit/AudioKit/AudioKit/Common/Internals/AudioUnit Host/AKAudioUnitManager.swift:140:16: value of type '[AVAudioUnit?]' has no member 'compactMap'
return _effectsChain.compactMap { $0 }
Are you using Xcode beta?

Oh yeah. The beta.

On Mar 20, 2018, at 6:43 PM, Aurelius Prochazka<EMAIL_ADDRESS>wrote:
@aure commented on this pull request.
In AudioKit/Common/Internals/AudioUnit Host/AKAudioUnitManager.swift:

@@ -137,7 +137,7 @@ open class AKAudioUnitManager: NSObject {

 // just get a non nil list of Audio Units
 private var linkedEffects: [AVAudioUnit] {

   return _effectsChain.flatMap { $0 }

   return _effectsChain.compactMap { $0 }

I think this is too bleeding edge.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I’ll change it to the old syntax

On Mar 20, 2018, at 6:43 PM, Aurelius Prochazka<EMAIL_ADDRESS>wrote:
@aure commented on this pull request.
In AudioKit/Common/Internals/AudioUnit Host/AKAudioUnitManager.swift:

@@ -137,7 +137,7 @@ open class AKAudioUnitManager: NSObject {

 // just get a non nil list of Audio Units
 private var linkedEffects: [AVAudioUnit] {

   return _effectsChain.flatMap { $0 }

   return _effectsChain.compactMap { $0 }

I think this is too bleeding edge.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@aure

We could probably bracket these with #if swift(4.1) blocks so it works with both versions.

Well, it’s just a deprecation warning. I changed it back to the old syntax for now.
Seems a bit verbose to have to do that?

On Mar 20, 2018, at 10:39 PM, Stéphane Peter<EMAIL_ADDRESS>wrote:
We could probably bracket these with #if swift(4.1) blocks so it works with both versions.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/AudioKit/AudioKit/pull/1276#issuecomment-374838430, or mute the thread https://github.com/notifications/unsubscribe-auth/ACyFo-qrKJTPkR1J2-Eo9swe3w6gFf6Oks5tgeeJgaJpZM4SyxgT.


⚡ Current State

The current version in develop may not work because the module conventional-changelog-angular still uses __dirname in the latest version 7.0.0. This has already been fixed in the main branch, but has not yet been published. As soon as this has been done, this action should also work again.

Nope, that's still relevant…