[Pollux, Reproducibility, Inquiry] Are dataset-fetching mechanisms broken?

Hi, I am trying to run the pollux benchmark with custom workload and a different cluster (one that is not aws), to evaluate how pollux does in a variety of situations. However, I cannot seem to pull from your docker registry at registry.petuum.com, which is needed to assemble the containers for each of the six models. (See this directory, for example )
Below is a part of what kubectl describe pods outputs for the dataset pod, after I successfully launch the three kinds of sched pods.
Events:
  Type     Reason     Age                 From               Message
  ----     ------     ----                ----               -------
  Normal   Scheduled  2m2s                default-scheduler  Successfully assigned default/datasets-jxz86 to elsa-05
  Normal   Pulling    53s (x3 over 2m)    kubelet            Pulling image "registry.petuum.com/dev/esper-datasets:latest"
  Warning  Failed     38s (x3 over 104s)  kubelet            Failed to pull image "registry.petuum.com/dev/esper-datasets:latest": rpc error: code = Unknown desc = Error response from daemon: Get https://registry.petuum.com/v2/: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)
  Warning  Failed     38s (x3 over 104s)  kubelet            Error: ErrImagePull
  Normal   BackOff    9s (x4 over 104s)   kubelet            Back-off pulling image "registry.petuum.com/dev/esper-datasets:latest"
  Warning  Failed     9s (x4 over 104s)   kubelet            Error: ImagePullBackOff

I tried just pulling an image as well, and I got what you can see below. I am starting to think that maybe some undocumented procedure(eg. registration) is required to access registry.petuum.com...?
> ping registry.petuum.com
PING ec2-54-245-165-47.us-west-2.compute.amazonaws.com (<IP_ADDRESS>) 56(84) bytes of data.

^C
> sudo docker pull registry.petuum.com/dev/esper-datasets:latest

Error response from daemon: Get https://registry.petuum.com/v2/: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)

I googled a bit, and tested some of the more common solutions:

switching DNS servers to <IP_ADDRESS> or <IP_ADDRESS>
configure a separate HTTP proxy

Regrettably, the former did not work, and it turns out the latter is not an option given my circumstances.
How can I proceed if I want to pull images from your server, and/or download the datasets you used in the evaluations in the paper?
Thank you in advance!

sudo docker pull registry.petuum.com/dev/esper-datasets:latest

Hi @stet-stet , I am encountering a similar problem. Have you solved it?

No, unfortunately...

Hi, unfortunately we're not able to host the datasets for public access due to cost reasons and (for certain datasets like ImageNet) license reasons. However, all the datasets we used are public ones with citations provided in the Pollux paper. You should be able to obtain the datasets to reproduce the experiments.


[Bug]: Chrome BUG:Error: Invalid Input Error: No magic bytes found at end of file

What happened?
What actually happened, including error codes if applies.
Chrome BUG:Error: Invalid Input Error: No magic bytes found at end of file 'lakefs://sample-repo/main/nyc-tlc-trip-data/fhv_tripdata_2015-01.parquet'
It was normal after the browser change
Steps to Reproduce:
0. site:https://magical-weevil-z3v9jk.us-east-1.lakefscloud.io/repositories/sample-repo/object?ref=main&path=nyc-tlc-trip-data%2Ffhv_tripdata_2015-01.parquet

duckdb wasm select on parquet throw error

Expected behavior
No response
lakeFS version
1.38.0
How lakeFS is installed
lakefs cloud
Affected clients
webui
Relevant log output
No response
Contact details
No response

Found the reason, is due to page header injection
the request header injection
Authorization:xxxx


enable edit mocal action when card was clicked

On branch chore/edit-ticket-on-kanban
modified:   app/Helpers/KanbanScrumHelper.php
modified:   app/Http/Livewire/RoadMap/IssueForm.php
modified:   resources/views/partials/kanban/record.blade.php
modified:   resources/views/partials/kanban/status.blade.php

Edit action on click and add open link on top

Check why it has the overlay over it, for the rest looks okay.

@tiagofrancafernandes Check why it has the overlay over it, for the rest looks okay.

Ok,
I will see and get back soon


Pluggable template engine support for helm 3?

https://github.com/helm/helm/issues/8290#issuecomment-642395892
Is this still true that helm provides a way for adding templating engines?
I'm not familiar with internal structure of helm, but looks like current implementation has no way to replace only go template renderer with something else.
https://github.com/helm/helm/blob/46d80f68c11d8107b688b9c8299fa02bccba312f/pkg/engine/engine.go#L250
helm 3 already already has a way to install plugins. Can we extend its functionality so that users can develop their own renderer implementation?
That would prevent other tools from using helm as a library though.
AFAIK terraform helm provider is one of such example. The provider doesn't need helm CLI to be installed because it incorporates helm as a library.
Developing many renderers in-tree might make it difficult to update dependencies and make CLI binary bloated.
Or... could plugin renderers run on server side? Maybe too much complicated to do so.

Is this still true that helm provides a way for adding templating engines?

This functionality was removed in Helm 3. Helm 2 was under active development for nearly 5 years, and no other template engine was ever introduced. Several community members advocated for new template engines. We pointed them towards the engine mechanism, but none was ever written.

helm 3 already already has a way to install plugins. Can we extend its functionality so that users can develop their own renderer implementation?

Plugins currently cannot inject themselves into another command like helm install or helm upgrade.

Closing this issue as answered. Please feel free to comment here and let us know if you have further questions. Thanks!


feat: shellcheck recommended code

This silences shellcheck warnings. I tested the code and everything is working the same, maybe the code looks a little bit hard to understand but it's worth considering.

Thanks for this @budimanjojo! Gonna go over it and merge it in the morning :) Having more shellcheck compliancy is always more better IMO :)


Documentation .avnrc

Hello,
I can't find any documentation on how to fill the .avnrc
I would like to force avn to use avn-n instead of anv-nvm, because I got this error:
Fatal Error: Cannot find module '/Users/steph/.avn/plugins/avn-nvm'
Require stack:
- /Users/steph/.avn/lib/plugins.js
- /Users/steph/.avn/lib/hooks.js
- /Users/steph/.avn/lib/avn.js
- /Users/steph/.avn/index.js
- /Users/steph/.avn/bin/_avn
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:793:17)
    at Function.Module._load (internal/modules/cjs/loader.js:686:27)
    at Module.require (internal/modules/cjs/loader.js:848:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at /Users/steph/.avn/lib/plugins.js:59:20
    at tryCatcher (/Users/steph/.avn/node_modules/bluebird/js/release/util.js:16:23)
    at Object.gotValue (/Users/steph/.avn/node_modules/bluebird/js/release/reduce.js:168:18)
    at Object.gotAccum (/Users/steph/.avn/node_modules/bluebird/js/release/reduce.js:155:25)
    at Object.tryCatcher (/Users/steph/.avn/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/Users/steph/.avn/node_modules/bluebird/js/release/promise.js:547:31)
    at Promise._settlePromise (/Users/steph/.avn/node_modules/bluebird/js/release/promise.js:604:18)
    at Promise._settlePromiseCtx (/Users/steph/.avn/node_modules/bluebird/js/release/promise.js:641:10)
    at _drainQueueStep (/Users/steph/.avn/node_modules/bluebird/js/release/async.js:97:12)
    at _drainQueue (/Users/steph/.avn/node_modules/bluebird/js/release/async.js:86:9)
    at Async._drainQueues (/Users/steph/.avn/node_modules/bluebird/js/release/async.js:102:5)
    at Immediate.Async.drainQueues [as _onImmediate] (/Users/steph/.avn/node_modules/bluebird/js/release/async.js:15:14)

Thank you

Uninstall avn-nvm or create a JSON file at ~/.avnrc with the key plugins that's an array of the names of the plugins you want used in the order you want them used. See this file.


Remove Subtitles

Hi, how can i remove subtitles thread from stream?

Hello,
I don't understand. What do you means with subtitles thread?

Sorry, I mean it

I'm not sending subtitles in stream. Only protocol commands and video/audio packets.
Maybe your server is doing it. What server are you using?


Register resources/asstes folder to get Files

You already have the option of adding your own images. However, if I store a logo.svg in the assets folder and store it in the modul.json, for example, it is not rendered.
Furthermore, if you insert the image as URL in the module.json there is no fixed size. Sometimes the logo disappears behind the card.

thanks for your report, I will work on it to add a fixed box dev for the image and add an option to set the image from the internal link

@CookieMC337 what did you expect the image to be? change on size as an option?

okay you can use images from storage when you store them in public folder and you can access this image like /images/logo.png, for images, we recommend making it a cover image not just a logo without a background so you can add a background to your logo and then attach it.


livedns: on key creation, return the UUID of the created key

The StandardResponse type has an UUID field, so we use it to store the
UUID. It would have been better to return the UUID directly as the
StandardResponse type is empty otherwise, but it would be an API
change. Maybe take a mental note for the next major version?

It seems this "StandardResponse" was only done for DNS. And the fields are never used. So, it could be definitely reworked on the next iteration. This was done in 713df769b420.


Notes about volume levels. Raw numbers are model specific!

Volume values are a bit weird, e.g. from a Denon AVR3111 control document:
MV99 is -- (silent?)
MV995 is -80.5dB (close to silent)
MV00 is -80.0dB
MV005 is -79.5dB
MV80 is 0dB
MV805 is +0.5dB
so here MV99 and MV995 are special cases as you might expect the higher number to be a higher volume
Also, a three digit number signifies a half-step. So it goes up like MV00, MV005, MV01, MV015, MV02...
There is (can be?) also a max volume. E.g. my NR1604 when asked about the master volume with MV?, responds with multiple lines, including one that says MVMAX 70
By the way, there are also MVUP and MVDOWN commands
Additionally, there are separate volume commands for speakers, e.g. CVFL UP (change volume front left up)
Sample CV? output from my Marantz NR1604:
CVFL 48
CVFR 485
CVC 515
CVSW 47
CVSL 435
CVSR 46
CVSBL 49
CVSBR 51
CVSB 50
CVFHL 50
CVFHR 50
MVMAX 70
DCAUTO
@DCM:3

should be fixed in 1.0.4 which is now in the main app store.


SAMZA-1667: Skip storing configuration as a part of JobModel in zookeeper data nodes.

In general, jobModel configuration contains service access tokens and certs. It's a common practice to run zookeeper in a non-ACL environment. Hence for security purposes, it's essential not to store configuration as a part of JobModel in zookeeper.

@xinyuiscool @bharathkk
Please take a look when you get a chance.

+1 for Bharath's comment. There's no indication anywhere that the caller isn't supposed to use the configs from the JobModel passed to it. What's the plan for the config field in the JobModel?

@prateekm @bharathkk
IMHO, JobModel is meant to store the task to partitions assignment and logically config does not belong there.
We have used it so far to propagate config to SamzaContainer running on a NodeManager in yarn.
I think in long term, we should move it out of the JobModel.
For now, I will add a comment for it.


The grammar errors were corrected

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for contributing, however I'm afraid I'm going to close this. It's a duplicate of several other low effort PRs we have received recently, presumably the result of an automated script. Please check existing PRs before contributing.
I would also direct you towards the quality standards section of the Hacktoberfest website (which I assume this is part of): https://hacktoberfest.digitalocean.com/details#quality-standards


Can I use this in Unity

I am developing an app for the HoloLens 2 to augment the solution of a real world Rubik's Cube. I need access to the video feed as continuous frames to augment the real world Cube. Can I use this repo in Unity or how is it intended to be used?
I am porting my app from the META2 AR HMD where i was able to access the camera feed like a normal web camera and it all worked really well.

You probably found these:
#51 and #108


Time picker can hide minutes and hours

Thanks for this useful Vue code!
Is there a way for the time picker to hide the minutes and seconds? I would like users to be able to pick an hour but not minutes and seconds for their input. (The minutes and seconds would be hidden in both the input field and in the selection interface.) As a bonus, the hours would show zeros for minutes, as in 0000 or 0900 or 2200.
Thanks for your consideration,
-Ken

sorry, there is not plan to do it. Thanks for your feedback


Cannot build the sample project on iPhone

Hi @Jerming
It seems I cannot build this sample project on iPhone 6
How can I fix this error ?
Device: iPhone 6
OS: 12.4.8
Command PhaseScriptExecution failed with a nonzero exit code

hey @dirablue thanks for opening the issue.
Could you try on the new release fd8be34 ?Thank you.

@Jerming Hi Jerming. Thank you for your update!
Let me try it later.


1.9.2 hasn't been pulled to master

So 'make test' there is still failing because of the cert expiring.
Also, the tag is '1.9.2' instead of 'v1.9.2' like all the other tags. Not to be nitpicky.

Thanks about that; it's pushed now.
On 17:24 Sun 12 Apr     , krakensden wrote:

So 'make test' there is still failing because of the cert expiring.
Also, the tag is '1.9.2' instead of 'v1.9.2' like all the other tags.
Not to be nitpicky.
—
Reply to this email directly or [1]view it on GitHub.
References

https://github.com/zedshaw/mongrel2/issues/256


autocomplete for variables and functions inside console.log()

Hi,
I have a simple question which I couldn't find an answer for , with javascript , Intellisense works perfectly, however I can't seem to find a reason why autocomplete for variables and functions inside console.log() sometimes it works and sometime it doesnt and I dont know why.
Any idea or a pointer to a setting to make it work will be appreciated ?
Regards,
Hesham

Hi,
My settings.json is below
{
"editor.cursorStyle": "block",
"editor.wordWrap": "wordWrapColumn",
"liveServer.settings.CustomBrowser": "chrome",
"liveServer.settings.donotShowInfoMsg": true,
"code-runner.runInTerminal": true,
"window.zoomLevel": 1,
"editor.fontFamily": "Menlo, Monaco, 'Courier New', monospace",
"terminal.integrated.fontFamily": "'Hack Nerd Font'",
"editor.defaultFormatter": "esbenp.prettier-vscode",
"code-runner.saveAllFilesBeforeRun": true,
"code-runner.saveFileBeforeRun": true,
"editor.formatOnSave": true,
"editor.formatOnPaste": false,
"eslint.alwaysShowStatus": true,
"editor.tabSize": 2,
"files.autoSave": "afterDelay",
"editor.suggestSelection": "first",
"editor.snippetSuggestions": "top",
"workbench.iconTheme": "vscode-icons",
"vsicons.dontShowNewVersionMessage": true,
"workbench.colorCustomizations": {
"terminal.background":"#131212",
"terminal.foreground":"#dddad6",
"terminal.ansiBlack":"#1D2021",
"terminal.ansiBrightBlack":"#665C54",
"terminal.ansiBrightBlue":"#0D6678",
"terminal.ansiBrightCyan":"#8BA59B",
"terminal.ansiBrightGreen":"#237e02",
"terminal.ansiBrightMagenta":"#8F4673",
"terminal.ansiBrightRed":"#FB543F",
"terminal.ansiBrightWhite":"#FDF4C1",
"terminal.ansiBrightYellow":"#FAC03B",
"terminal.ansiCyan":"#8BA59B",
"terminal.ansiGreen":"#95C085",
"terminal.ansiMagenta":"#8F4673",
"terminal.ansiRed":"#FB543F",
"terminal.ansiWhite":"#A89984",
"terminal.ansiYellow":"#FAC03B"
},
"jshint.lintHTML": true,
"jshint.options": {
},

"editor.quickSuggestions": {
  "other": true,
  "comments": false,
  "strings": false,
  "editor.quickSuggestionsDelay": 5
},
"workbench.editorAssociations": [

],
"editor.fontLigatures": true,
"typescript.tsserver.maxTsServerMemory": 4096,
"vsintellicode.java.completionsEnabled": false,
"typescript.surveys.enabled": false,
"typescript.suggest.completeFunctionCalls": false,
"typescript.format.enable": false,
"javascript.validate.enable": false,
"color-highlight.languages": [

  "*"
],
"vsintellicode.modify.editor.suggestSelection": "automaticallyOverrodeDefaultValue",
"kite.showWelcomeNotificationOnStartup": false,
"kite.pollingInterval": 10,
"files.associations": {

},

}

Hi Hesham,
Thank you for reporting this issue!
Could you please provide steps for what you are trying and what you expect to happen?
Thanks!

Hi,
Thank you for reaching out , autocomplete works everywhere except in side a console.log see screen shot

Regards,
Hesham

Thank you for the screenshots!
I recommend filing this issue on https://github.com/microsoft/vscode - they will be able to help more with this particular issue.

The below change fix the problem.
"editor.suggest.snippetsPreventQuickSuggestions": false,

The below change fix the problem.
"editor.suggest.snippetsPreventQuickSuggestions": false,

Didn't worked @uniqueiniquity


Update dependencies

Upgrade JHipster dependency to use latest patch release
Upgrade Svelte, Tailwind dependencies. Update tailwind configurations to remove build warning messages
Upgrade other third-party dependencies

Conflicting dependabot PRs:
https://github.com/jhipster/generator-jhipster-svelte/pull/93
https://github.com/jhipster/generator-jhipster-svelte/pull/84
https://github.com/jhipster/generator-jhipster-svelte/pull/72


Missing python file in source code of release v1.0.0

There is no python source file found in the source code of the asset section in the release of v.1.0.0  release There is only readme file and license no source code.
Thank you,
Punyathorn

The source code are for sell sperately. Feel free to dm


Implement Initial On-Prem Estimations

Context
Overview
Based on the spike work, we are ready to implement an initial flow for estimating on-prem estimations for compute and memory categories. This will entail providing a specific data-model for consumers to upload a csv file with the necessary data. CCF will read from the CSV and output on-prem estimates to a new CSV using a CLI command.
Acceptance Criteria

[ ] When I run yarn run estimate-on-premise-data from the cli package and provide the input csv with --onPremiseInput located in the cli package root directory and optional output file name with --onPremiseOutput, then a new csv file should be generated with the energy and emissions appended to each row.

Tech Tasks

[x] Create a new on-prem package with a similar directory structure to azure
[x] Within the src/application directory, create a new file OnPrem.ts where a new OnPrem class lives
[x] Create a method in the OnPrem class called getDataForOnPrem that instantiates a new OnPremDataReport class which will live in OnPremDataReport.ts in src/lib, that takes in the compute and memory estimators and calls a getEstimates method
[x] Handle the follow columns:
cpuId: string
memory: number,
machineType: string,
startTime: timestamp string,
endTime: timestamp string,
country?: string,
region?: string,
serverUtilization?: number,
pue?: number
[x] Write the getEstimates class to map through the rows and use a switch statement by machine type to add a case for  servers that then grab the necessary information to send to the estimators and return the estimates objects
[x] Add method to transform the timestamps to usage hours
[x] Add method to parse cpuId to grab processor id
[x] In src/domain, add a file called OnPremFootprintEstimateConstants.ts and add the respective constants for coefficients, PUE average, server utilization average, memory, min and max watts for each processor family, and emissions factors
[x] In src/lib, create a file called OnPremDataReportRow.ts that contains a new class to define constants and necessary methods from each usage row
[x] In src/lib, create a new file called MachineTypes.ts that will contains all of the processor family maps
[x] Add a new cli command in the cli package that calls a new method in App.ts that instantiates a new OnPrem class and calls the method to get estimates
[x] Add appropriate test coverage, including edge cases using TDD.
[ ] Run Changesets, bump any packages that have been updated/changed
[ ] Did you make changes to the client, api or cli package? If so, considering updating the create-app templates.
[ ] If any create-app templates have been updated, make sure to run the test-create-app script to ensure it still works properly.

Tech Notes
Review Tasks

[ ] eg. specific QA details, update methodology, or update microsite

Have review this and it's looking pretty good! Here's my feedback:

@google-cloud/secret-manager should be removed from the production dependancies - dev dependancies are fine though
Jest coverage thresholds should be increase to match the actual coverage, e.g. 99% for statements
I'm thinking we we should rename cpuId to 'serverName or 'processorName - because we will want to support GPUs at some point, and right now they wouldn't match that model name
In Config.ts - should we have some default/fallback options in case the user doesn't set the environment variables?

Other than that, everything looks great!


how to open result.pkl generated by train.py

Hi there,
I trained a model and wanted to open the result.pkl file generated by train.py.
import torch
res = torch.load("/path.../result.pkl")
print(res)
but i get the error:
RuntimeError: Invalid magic number; corrupt file?
Now I am not sure if something went wrong with the generation of the file or if I open it wrong.
My question is: how do you look in the results in the result.pkl file ?
thanks in advance
Lukas

Hello, I found this repo that allows to visualize the test result : https://github.com/DeclK/3d-object-vis

You can have a look on how the evaluation script opens the .pkl files.
Here is how to load it for the waymo_eval.py script.


POWERTOYS LOADS A WHITE WINDOW AT STARTUP

Microsoft PowerToys version
0.80.1
Installation method
Microsoft Store
Running as admin
None
Area(s) with issue?
General
Steps to reproduce
After booting up windows and logging in. A white window(more like a bar with no title) appears on screen for a split second then disappears. It got me worried since I didn't know what could cause that and I usually download a lot of stuff online so I thought it was some kind of malware. But when I uninstalled power toys it suddenly disappeared and I confirmed it was indeed powertoys when I decided to reinstall it the window came back. Please fix it
https://github.com/microsoft/PowerToys/assets/168579612/c73b051d-7f9b-4493-86c1-1494cc466deb
✔ Expected Behavior
No window pop up
❌ Actual Behavior
Window pop up
Other Software
No response

/dup #31317


please publish auto-value-moshi-runtime:

Per documentation we should add these dependencies:
annotationProcessor("com.ryanharter.auto.value:auto-value-moshi-extension:1.0.0")
implementation("com.ryanharter.auto.value:auto-value-moshi-runtime:1.0.0")

I cannot find this artifact: https://mvnrepository.com/artifact/com.ryanharter.auto.value/auto-value-moshi-runtime
Please publish it
Thanks for the great advance in this project

Looks like it was accidentally still published as auto-value-moshi-annotations. You can use that for now and we’ll fix the artifact name in the next release

Side note - that site is a 3rd party site and not a source of truth. You should use https://repo1.maven.org/maven2/com/ryanharter/auto/value/ as a reference for artifacts


Poll immediately on page focus

#MINOR#

:+1:

Approved - any thoughts on integration http://ember-concurrency.com/#/docs with this?

Not sure what we really gain with that @sglanzer

Looks very similar to what we need (task iteration/cancellation) and comes with a few nifty features.  Not mandatory, just thought it might be worth a look.


Support PayPal Payments Pro

Will be fine have support for Direct Payment that allow bank card processing without merchant account
https://developer.paypal.com/docs/classic/paypal-payments-pro/integration-guide/WPWebsitePaymentsPro/

As the link above states, Website Payments Pro are replaced by PayPal Payments Pro. Am I right that django-oscar-paypal doesn't support the last one?


README indicates enzyme is dependency instead of dev dependency

Is this a bug report?
Yes
Steps to Reproduce
Sorry for the simplified version of the template, but all I really wanted to report was that the template documentation indicated to run npm install --save when installing enzyme, but it is actually test dependency.  I feel like this might be inaccurate to make it a dependency instead of a dev dependency.
Here is the link to the documentation: https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template/README.md
If you search for enzyme, it should be one of the first options.

hi @singletoncoding, this is done on purpose.  Please see: https://github.com/facebook/create-react-app/issues/3209


Changed deleted field to not null

According to discussion here, added NOT NULL constraint in test/example scripts
Merging this closes #250

Thanks for this contribution, since Lightbend has shown interest to move this module to the official akka repositories, contributors need to sign the CLA.
Would you mind signing the Lightbend CLA at http://www.lightbend.com/contribute/cla ?

I've signed it

I checked the CLA manually.


https://appcenter.ms/ in China mainland not accessible

Describe the solution you'd like
https://appcenter.ms/ in China mainland not accessible for several days
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Hi @kingnight , thank you for reaching out to us!
Unfortunately we cannot guarantee that AppCenter works in all countries, due to country specific policies and law. See Data residency and sovereignty.
Closing this issue. Feel free to ask any additional questions.


Handle overnight trips

If you request a route at 12:30 AM it is likely there are some trips from the previous service day still running. Account for this somehow (maybe copy trips that cross midnight onto both days? Still doesn't solve the problem of departing at 23:30, catching a bus from today, and then transferring to a bus from tomorrow).

Done in #27


Out of memory LLVM link

After merging in latest PRs, I now find my links are running out of memory on 16 GB workstation:
mev@chilecito:~/source/AMDMIGraphX/build$ make
[ 15%] Built target migraphx
[ 15%] Linking CXX shared library ../../../lib/libmigraphx_device.so
/opt/rocm/hcc/bin/clamp-device: line 204: 119059 Killed                  $LINK -suppress-warnings -o $2.linked.bc $1 $HCC_BC_LIBS
Generating AMD GCN kernel failed in llvm-link with ROCm-Device-Libs for target: gfx900
clang-10: error: linker command failed with exit code 18 (use -v to see invocation)
src/targets/gpu/CMakeFiles/migraphx_device.dir/build.make:1347: recipe for target 'lib/libmigraphx_device.so.0.5' failed
make[2]: *** [lib/libmigraphx_device.so.0.5] Error 18
CMakeFiles/Makefile2:3686: recipe for target 'src/targets/gpu/CMakeFiles/migraphx_device.dir/all' failed
make[1]: *** [src/targets/gpu/CMakeFiles/migraphx_device.dir/all] Error 2
Makefile:160: recipe for target 'all' failed
make: *** [all] Error 2
mev@chilecito:~/source/AMDMIGraphX/build$ make
[ 15%] Built target migraphx
[ 15%] Linking CXX shared library ../../../lib/libmigraphx_device.so
LLVM ERROR: out of memory
Stack dump:
0.	Program arguments: /opt/rocm/hcc/bin/llvm-link -suppress-warnings -o /tmp/tmp.iwtRGJs653/kernel-gfx803.hsaco.linked.bc /tmp/tmp.iwtRGJs653/kernel.bc /opt/rocm/hcc/rocdl/lib/hc.amdgcn.bc /opt/rocm/hcc/rocdl/lib/hip.amdgcn.bc /opt/rocm/hcc/rocdl/lib/opencl.amdgcn.bc /opt/rocm/hcc/rocdl/lib/ocml.amdgcn.bc /opt/rocm/hcc/rocdl/lib/ockl.amdgcn.bc /opt/rocm/hcc/rocdl/lib/oclc_isa_version_803.amdgcn.bc /opt/rocm/hcc/rocdl/lib/oclc_finite_only_off.amdgcn.bc /opt/rocm/hcc/rocdl/lib/oclc_daz_opt_off.amdgcn.bc /opt/rocm/hcc/rocdl/lib/oclc_correctly_rounded_sqrt_on.amdgcn.bc /opt/rocm/hcc/rocdl/lib/oclc_unsafe_math_off.amdgcn.bc /opt/rocm/hcc/rocdl/lib/oclc_wavefrontsize64_on.amdgcn.bc
/opt/rocm/hcc/bin/llvm-link[0x5b264a]
/opt/rocm/hcc/bin/llvm-link[0x5b04fc]
/opt/rocm/hcc/bin/llvm-link[0x5b0669]
/lib/x86_64-linux-gnu/libpthread.so.0(+0x11390)[0x7fdf135de390]
/lib/x86_64-linux-gnu/libc.so.6(gsignal+0x38)[0x7fdf124f1428]
/lib/x86_64-linux-gnu/libc.so.6(abort+0x16a)[0x7fdf124f302a]
/opt/rocm/hcc/bin/llvm-link[0x57f924]
/usr/lib/x86_64-linux-gnu/libstdc++.so.6(_Znwm+0x2c)[0x7fdf12e4cc8c]
/opt/rocm/hcc/bin/llvm-link[0x478c82]
/opt/rocm/hcc/bin/llvm-link[0x478f12]
/opt/rocm/hcc/bin/llvm-link[0x4639fe]
/opt/rocm/hcc/bin/llvm-link[0x46f162]
/opt/rocm/hcc/bin/llvm-link[0x4717a9]
/opt/rocm/hcc/bin/llvm-link[0x4719d2]
/opt/rocm/hcc/bin/llvm-link[0x4110d1]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf0)[0x7fdf124dc830]
/opt/rocm/hcc/bin/llvm-link[0x41c8d9]
LLVM ERROR: out of memory
Stack dump:
0.	Program arguments: /opt/rocm/hcc/bin/llvm-link -suppress-warnings -o /tmp/tmp.iwtRGJs653/kernel-gfx906.hsaco.linked.bc /tmp/tmp.iwtRGJs653/kernel.bc /opt/rocm/hcc/rocdl/lib/hc.amdgcn.bc /opt/rocm/hcc/rocdl/lib/hip.amdgcn.bc /opt/rocm/hcc/rocdl/lib/opencl.amdgcn.bc /opt/rocm/hcc/rocdl/lib/ocml.amdgcn.bc /opt/rocm/hcc/rocdl/lib/ockl.amdgcn.bc /opt/rocm/hcc/rocdl/lib/oclc_isa_version_906.amdgcn.bc /opt/rocm/hcc/rocdl/lib/oclc_finite_only_off.amdgcn.bc /opt/rocm/hcc/rocdl/lib/oclc_daz_opt_off.amdgcn.bc /opt/rocm/hcc/rocdl/lib/oclc_correctly_rounded_sqrt_on.amdgcn.bc /opt/rocm/hcc/rocdl/lib/oclc_unsafe_math_off.amdgcn.bc /opt/rocm/hcc/rocdl/lib/oclc_wavefrontsize64_on.amdgcn.bc
/opt/rocm/hcc/bin/llvm-link[0x5b264a]
/opt/rocm/hcc/bin/llvm-link[0x5b04fc]
/opt/rocm/hcc/bin/llvm-link[0x5b0669]
/lib/x86_64-linux-gnu/libpthread.so.0(+0x11390)[0x7f9051fa7390]
/lib/x86_64-linux-gnu/libc.so.6(gsignal+0x38)[0x7f9050eba428]
/lib/x86_64-linux-gnu/libc.so.6(abort+0x16a)[0x7f9050ebc02a]
/opt/rocm/hcc/bin/llvm-link[0x57f924]
/usr/lib/x86_64-linux-gnu/libstdc++.so.6(_Znwm+0x2c)[0x7f9051815c8c]
/opt/rocm/hcc/bin/llvm-link[0x478c82]
/opt/rocm/hcc/bin/llvm-link[0x478f12]
/opt/rocm/hcc/bin/llvm-link[0x4639fe]
/opt/rocm/hcc/bin/llvm-link[0x46f162]
/opt/rocm/hcc/bin/llvm-link[0x4717a9]
/opt/rocm/hcc/bin/llvm-link[0x4719d2]
/opt/rocm/hcc/bin/llvm-link[0x4110d1]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf0)[0x7f9050ea5830]
/opt/rocm/hcc/bin/llvm-link[0x41c8d9]
/opt/rocm/hcc/bin/clamp-device: line 204: 121116 Aborted                 (core dumped) $LINK -suppress-warnings -o $2.linked.bc $1 $HCC_BC_LIBS
Generating AMD GCN kernel failed in llvm-link with ROCm-Device-Libs for target: gfx906
/opt/rocm/hcc/bin/clamp-device: line 204: 121117 Aborted                 (core dumped) $LINK -suppress-warnings -o $2.linked.bc $1 $HCC_BC_LIBS
Generating AMD GCN kernel failed in llvm-link with ROCm-Device-Libs for target: gfx803

I suspect it was getting close since link times were taking 30+ minutes prior to that, but may have something that pushed it over the edge.  This build does happen successfully on Vega20 machine where there is more memory.
Noting in github so don't lose track of the issue.

Adding a swap file on USB disk and the link succeeds (though even more slowly).  Confirmation that our link of GPU kernels has grown enough to push over the 16GB memory limit on my machine.


Add source maps into tracker

Debugging the tracker could be enhanced by including source maps in order to decipher the minified code.

Can we add this into this release - how big a job is it?

This is why we ruled out Uglify before, not sure if things have changed:
https://github.com/snowplow/snowplow-javascript-tracker/issues/278

Ran into some issues with deploying version 2.9.1 - it spits an error out during minifying. Possibly a yui-compressor problem. If that's the case, I'll have to narrow down if it's due to code in the newest release. Otherwise it might be worth re-exploring why Uglify can't be used, YUI Compressor really isn't maintained that much. If you were referring to this line in #278, then I can probably figure a way to do that in Uglify.

Hey @mhadam - sorry to hear about the difficulties. I think there's a line somewhere in the tracker which references some gnarly unicode characters. I think you'll need to trace that code so that you can verify that whatever uses those characters continues to function as you expect post-switch-to-uglify...

@mhadam were you using Node v10 or +7? I had a Fatal error: Callback must be a function error while running the min:deploy task. Maybe its related to this: https://github.com/gruntjs/grunt-contrib-jasmine/pull/262.


Document usage with sudo

After installing fullstaq-rbenv and fullstaq-ruby-2.6.4-jemalloc from repository and all preparations from wiki (delete ~/.rbenv/bin from PATH and init with fullstaq rbenv)  I still cannot use fullstaq ruby as regular user:
$ rbenv --version
rbenv 1.1.2
$ rbenv exec ruby -v
ruby 2.6.4p104 (2019-08-28 revision 67798)+jemalloc [x86_64-linux]
$ rbenv exec gem install bundler
ERROR:  While executing gem ... (Gem::FilePermissionError)
    You don't have write permissions for the /usr/lib/fullstaq-ruby/versions/2.6.4-jemalloc/lib/ruby/gems/2.6.0 directory.

What you're showing is how it is supposed to work. Fullstaq Ruby is installed to a system location (/usr/lib/fullstaq-ruby), which a normal user has no write permissions to. You should use 'sudo'.
But I see that this point could be confusing (especially because 'rbenv' changes environment variables while 'sudo' nukes environment variables). There should be documentation about the need to use 'sudo', and how to use it.

+1 please document this.
This results in a new workflow change for some. Before this change I did not have to prefix all my commands with rbenv exec but now with the sudo requirement I now must use sudo rbenv exec gem install bundler

You can get around this by changing the group of the fullstaq-ruby folder with the following permissions changes:

groupadd your-group (optional if group already exists)
usermod -a -G your-group $USER (optional if users already in group)
chgrp your-group /usr/lib/fullstaq-ruby
chmod g+srwx /usr/lib/fullstaq-ruby

I'm trying @westonganger's method on CentOS 8, but I'm getting this error:
Traceback (most recent call last):
	2: from /usr/lib/rbenv/versions/2.6.6-jemalloc/bin/gem:9:in `<main>'
	1: from /usr/lib/fullstaq-ruby/versions/2.6.6-jemalloc/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:54:in `require'
/usr/lib/fullstaq-ruby/versions/2.6.6-jemalloc/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:54:in `require': Insecure operation - gem_original_require (SecurityError)

Here's what I did:
su deploy-user # has sudo rights
sudo dnf install fullstaq-ruby-common fullstaq-ruby-2.6.6-jemalloc
sudo groupadd rbenv
sudo usermod -aG rbenv deploy-user
sudo chgrp -R rbenv /usr/lib/fullstaq-ruby
sudo chmod -R g+swrx /usr/lib/fullstaq-ruby
rbenv rehash # probably unnecessary
rbenv global 2.6.6-jemalloc
rbenv exec gem install bundler

I also tried to set it on only the /usr/lib/rbenv directory (and I tried on both), but the former gives a regular permissions error, and the second gives the same require': Insecure operation - gem_original_require (SecurityError)
Is this meant to work now, or did I do something wrong somewhere? I'd very much like to avoid using sudo when I run gem and bundle, but I can live with it if this can't be done any other way.

I added documentation now.


Support ServerSentEvents: useServerSentEvents or useSSE

Suggested Feature
Support ServerSentEvents via useSSE the same way we have WebSockets via useWebSocket

I didn't know this API before, might need to learn a bit about it. It would be great if you can file a PR of it. Thanks :)

I'm looking at my current use-cases and trying to see how best to structure useSSE.
Currently I put all my SSE code for a page in one function and call it from created() like below boilerplate:
function sse() {
      try {
        let es = new EventSource('some-url')

        es.onopen = () => {
          this.connected = true
          // this connected state automatically toggles once connection is re-connected
          // console.log('sse-open')
        }

        es.onerror = () => {
          this.connected = false
          // console.log('sse-error')
        }

        // fire for every message received, if no dedicated handlers are provided
        es.onmessage = (x) => {
          // console.log('sse-msg', JSON.parse(x.data)))
        }

        es.addEventListener('action-A', (x) => {
          console.log('action-A', JSON.parse(x.data))
        })
        es.addEventListener('action-B', (x) => {
          console.log('action-B', JSON.parse(x.data))
        })
      } catch (error) {
        // console.log('SSE Error:', error)
      }

I don't yet have a suitable API for useSSE yet, particularly allowing for any number of callback handlers to be defined, or default to a capturing all data like useWebSocket


Installer scripting for Linux

The Pale Moon for Linux installer (also referred to as pminstaller) is a program that is meant to ease installation of the Pale Moon binaries on Linux, made available on http://linux.palemoon.org.

https://github.com/MoonchildProductions/PM4Linux-installer
Maybe adapt the installer for ungoogled-chromium? This way updating would be easier.

I don't see the benefits in using this packaging system. I would rather create distribution-specific packages than use a third party system.
There are already scripts to create Debian and Ubuntu packages. If you need packages for another distribution, open a new issue report.

I would rather create distribution-specific packages than use a third party system.

That would be great. I'm just concerned about security updates which wont make it to the avaerage user because of the lack of a easy update system.

I don't understand what you mean be "easy update system". At least on Debian, one can download packages and use dpkg -i <package>.deb to install them. This seems pretty straight-forward and simple. Unless you mean you want a way to install updates without root privilages.


Enable Travis

Would it be possible to setup Travis CI for automatic tests on this repo?

@morgoth I've added you as a collaborator for the project since I no longer have need of the gem, myself. Feel free to make contributions as you see fit, unless you'd rather just fork the project.

Thanks, I'll see what I can do. Would be much better to not have yet another fork, but most recent state in one place so that maybe community could benefit

@jboltz88 it is not possible to setup travis on forked repository, but instead could you maybe apply for Github Actions on https://github.com/features/actions - I believe this way we could setup CI for testing.

I've signed up my account, waiting on however long the queue is for approval.

Yes, that might take a while. Thanks

I added it in https://github.com/jboltz88/braze_ruby/pull/6/files - thanks


Feature/tabs hashes

When switching tab on the projet's page, a hash is now added to the URL. This hash is detected but the page is reloaded and the correct tab is shown.

Can you rebase with master please?

Sorry, I did not get time to apply the changes on the templates level. And then I forgot about it.

No worries

Same as deployer-frontend, I synched from upstream and rebased. Is that ok ?


Add sleep block.

There are two approaches, one where the host pauses the VM and doesn't call step()  for the given amount of time.
And another approach where the current time (via epoch) is exposed to the vm. and the vm can loop till a given time is reached. (This loop can be integrated into a single Blockly block)

issue complete


Working on POM in SNAPSHOT mode fails to work properly due to .ivy2 cache

When working in JJava with classes from a Maven projet under construction, i.e. with a SNAPSHOT version, JJava imports the version from ~/.ivy2 directory without refreshing it.
It is very Very VEry VERY confusing 🤪.
It makes deleted classes non existent and new classes unknown to JJava.
Workaround: manually delete outdated versions of the project in the ~/ivy2/cache directory.
I joined a simple 2 classes Maven project to demonstrate the bug.
jjava-bug-1.tar.gz

It might be related to #23

Yes, working with snapshots is annoying. I am constantly going through a cycle of rm -rf ~/.ivy/cache/org.dflib* / restart the kernel. So fixing this would be great.
Quick check of Ivy docs (and ChatGPT 😎) shows that resolvers can have "changingPattern"  and "changingMatcher" attributes, and since JJava configures its own Ivy instance, we should be able to apply them to .*-SNAPSHOT patterns in artifact names.


Transcribe audio files [Feature]

I can't find a way to use this library to transcribe audio files only real time transcribing.  As far as I can tell, the audio file transcribing is possible in vosk but it isn't implemented. So, could you implement it?

For sure that would be a great improvement. For now I'm too busy, but we will keep it in mind. If you can contribute feel free to do a PR with the implementaiton !

Ok, I'm getting things up and running. but where exactly should I put the model folder. I tried to put it on example/android/app/assets but it gives me this error
java.io.FileNotFoundException: vosk-model-small-ar/uuid

Check the readme, you're in the wrong folder. Models should live in your
android/ main folder.


Missing ParentSpanId in Messages Header

Hello,
I am using spring-cloud-sleuth in a SpringBoot application that receives HTTP requests and produces messages to a Kafka broker. I recently updated libraries version and I moved to spring-boot 2.4.0 and spring-cloud-sleuth 3.0.0-M5  from spring-boot 2.1.4 and spring-cloud-sleuth 2.1.1.RELEASE.
In this shift I noticed a difference between the two implementations. Previously, messages contained the following headers

while now I see:

I understand the reason of this shift (be compliant with headers naming and efficiently use Kafka) but I was wondering wether you removed ParentSpanId from b3 header, which may be helpful to identify the producer thread.
It could be sufficient to use SpanId, but I noticed that the value injected for SpanId is not the Id of message producer but a brand new one.
Thank you,
Giuseppe.

What if you set the following bean?
@Bean
PropagationFactorySupplier myPropagationFactorySupplier() {
  return () -> B3Propagation.newFactoryBuilder().injectFormat(B3Propagation.Format.SINGLE).build();
}

Hi Marcin,
thank you for your feedback. I will check asap your solution.
G.

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


Normalize more incoming HTTP headers

Right now, we only remove the following HTTP headers from the ones that are injected into the environment:

HTTP_AUTHORIZATION
HTTP_CONNECTION

The specification notes that other security-sensitive headers should also be removed. What headers should be removed?

Proxy
Otherwise attackers can control HTTP_PROXY which is usually automatically read by tools like HTTP clients. This presents a server-side request "forgery"/exfil risk, where the attacking client controls where the server will send unrelated backend requests if it makes any
See httpoxy.org


LinearA16 and LinearW2A16 output does not match

使用decoupleQ压缩llama-3-8b，使用 fake_quant - linearA16 的计算结果和true_quant - linearW2A16的计算结果不match
截图中，左边是linearW2A16的输出，右边是linearA16的输出
input数据类型是bfloat16
请问这种情况可能的原因是什么呀？

重复对同样的input进行计算，似乎每次的输出都不太一样，但是output的元素都很接近0

极其偶尔会有这种报错提示：*** RuntimeError: [TensorRT-LLm Error][fpA_intB Runner] Failed to run cutlass fpA_intB gemm. Error: Error Internal
看起来像是输出了初始化为0的output，并没有进行真正的计算？
请问这种情况怎么调试/解决比较好？

@XLuoxing 感谢关注我们的工作。
要不检查一下，fake_quant.pth和true_quant.pth是否能对上？可以将true_quant.pth里面的weights, scale, zero做一个计算，反量化一下，看计算得到的结果是否等于fake_quant.pth里面对应的元素值

from decoupleQ.linear_w2a16 import LinearA16
from decoupleQ.linear_w2a16 import LinearW2A16
import torch
batch=2
in_features = 5120
out_features = 5120
group_size = 64
with_bias = False
def expand_group(x, group_size):
return x.transpose(0, 1).unsqueeze(-1).repeat(1, 1, group_size).view(x.size(1), -1).transpose(0, 1).contiguous()
linear_a16 = LinearA16(in_features, out_features, with_bias, group_size)
linear_w2a16 = LinearW2A16(in_features, out_features, with_bias, group_size)
weight_w2 = torch.randint(-2, 2, (in_features, out_features), dtype=torch.int8).cuda()
weight_scale = torch.rand((in_features//group_size, out_features), dtype=torch.bfloat16).cuda()
weight_zp = torch.rand((in_features//group_size, out_features), dtype=torch.bfloat16).cuda()
weight_a16 = weight_w2.to(torch.bfloat16) * expand_group(weight_scale, group_size) + expand_group(weight_zp, group_size)
linear_a16.weight = weight_a16
linear_w2a16.weight = weight_w2
linear_w2a16.scale = weight_scale
linear_w2a16.zp = weight_zp
input = torch.rand((batch, in_features), dtype=torch.bfloat16).cuda()
out_a16 = linear_a16(input)
out_w2a16 = linear_w2a16(input)
print(out_a16)
print(out_w2a16)
你可以用上面的测试程序，测试下你的模型对应的shape，看是否正常。

from decoupleQ.linear_w2a16 import LinearA16 from decoupleQ.linear_w2a16 import LinearW2A16 import torch
batch=2 in_features = 5120 out_features = 5120 group_size = 64 with_bias = False
def expand_group(x, group_size): return x.transpose(0, 1).unsqueeze(-1).repeat(1, 1, group_size).view(x.size(1), -1).transpose(0, 1).contiguous()
linear_a16 = LinearA16(in_features, out_features, with_bias, group_size) linear_w2a16 = LinearW2A16(in_features, out_features, with_bias, group_size)
weight_w2 = torch.randint(-2, 2, (in_features, out_features), dtype=torch.int8).cuda() weight_scale = torch.rand((in_features//group_size, out_features), dtype=torch.bfloat16).cuda() weight_zp = torch.rand((in_features//group_size, out_features), dtype=torch.bfloat16).cuda()
weight_a16 = weight_w2.to(torch.bfloat16) * expand_group(weight_scale, group_size) + expand_group(weight_zp, group_size)
linear_a16.weight = weight_a16 linear_w2a16.weight = weight_w2 linear_w2a16.scale = weight_scale linear_w2a16.zp = weight_zp
input = torch.rand((batch, in_features), dtype=torch.bfloat16).cuda()
out_a16 = linear_a16(input) out_w2a16 = linear_w2a16(input)
print(out_a16) print(out_w2a16)
你可以用上面的测试程序，测试下你的模型对应的shape，看是否正常。

感谢，试了一下，shape是对的，但是w2a16的输出a16的对不上。是我build kernel不对吗？但是build kernel没有什么报错，只有warning说有的变量没有用上

build log：

cd csrc
mkdir -p build
cd build
export TORCH_CUDA_ARCH_LIST=8.6
TORCH_CUDA_ARCH_LIST=8.6
cmake -DCMAKE_PREFIX_PATH=/home/fuser/miniconda3/envs/2bit/lib/python3.11/site-packages/torch -DDECOUPLEQ_TORCH_HOME=/home/fuser/miniconda3/envs/2bit/lib/python3.11/site-packages/torch -DCMAKE_BUILD_TYPE=Release -DDECOUPLEQ_CUDA_HOME=/usr/local/cuda -DDECOUPLEQ_CUDNN_HOME=/usr/local/cuda ..
-- The CXX compiler identification is GNU 11.4.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- The CUDA compiler identification is NVIDIA 12.5.40
-- Detecting CUDA compiler ABI info
-- Detecting CUDA compiler ABI info - done
-- Check for working CUDA compiler: /usr/local/cuda/bin/nvcc - skipped
-- Detecting CUDA compile features
-- Detecting CUDA compile features - done
-- Found Python3: /home/fuser/miniconda3/envs/2bit/bin/python3.11 (found version "3.11.9") found components: Interpreter Development Development.Module Development.Embed
-- Found CUDA: /usr/local/cuda (found version "12.5")
-- Found CUDAToolkit: /usr/local/cuda/include (found version "12.5.40")
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Caffe2: CUDA detected: 12.5
-- Caffe2: CUDA nvcc is: /usr/local/cuda/bin/nvcc
-- Caffe2: CUDA toolkit directory: /usr/local/cuda
-- Caffe2: Header version is: 12.5
-- /usr/local/cuda/lib64/libnvrtc.so shorthash is fb37b3f5
-- USE_CUDNN is set to 0. Compiling without cuDNN support
-- USE_CUSPARSELT is set to 0. Compiling without cuSPARSELt support
CMake Warning at /home/fuser/miniconda3/envs/2bit/lib/python3.11/site-packages/torch/share/cmake/Caffe2/public/utils.cmake:385 (message):
In the future we will require one to explicitly pass TORCH_CUDA_ARCH_LIST
to cmake instead of implicitly setting it as an env variable.  This will
become a FATAL_ERROR in future version of pytorch.
Call Stack (most recent call first):
/home/fuser/miniconda3/envs/2bit/lib/python3.11/site-packages/torch/share/cmake/Caffe2/public/cuda.cmake:343 (torch_cuda_get_nvcc_gencode_flag)
/home/fuser/miniconda3/envs/2bit/lib/python3.11/site-packages/torch/share/cmake/Caffe2/Caffe2Config.cmake:87 (include)
/home/fuser/miniconda3/envs/2bit/lib/python3.11/site-packages/torch/share/cmake/Torch/TorchConfig.cmake:68 (find_package)
CMakeLists.txt:21 (find_package)

-- Added CUDA NVCC flags for: -gencode;arch=compute_86,code=sm_86
CMake Warning at /home/fuser/miniconda3/envs/2bit/lib/python3.11/site-packages/torch/share/cmake/Torch/TorchConfig.cmake:22 (message):
static library kineto_LIBRARY-NOTFOUND not found.
Call Stack (most recent call first):
/home/fuser/miniconda3/envs/2bit/lib/python3.11/site-packages/torch/share/cmake/Torch/TorchConfig.cmake:127 (append_torchlib_if_found)
CMakeLists.txt:21 (find_package)
-- Found Torch: /home/fuser/miniconda3/envs/2bit/lib/python3.11/site-packages/torch/lib/libtorch.so
f"python3 found"
f"torch found"
-- Configuring done (13.2s)
-- Generating done (0.1s)
-- Build files have been written to: /mnt/nfs2/cjld/2bit/decoupleQ/csrc/build

make -j
make: Warning: File 'Makefile' has modification time 0.00015 s in the future
[ 33%] Building CXX object CMakeFiles/decoupleQ_kernels.dir/mnt/nfs2/cjld/2bit/decoupleQ/dependencies/TensorRT-LLM/cpp/tensorrt_llm/common/tllmException.cpp.o
[ 33%] Building CXX object CMakeFiles/decoupleQ_kernels.dir/mnt/nfs2/cjld/2bit/decoupleQ/dependencies/TensorRT-LLM/cpp/tensorrt_llm/kernels/cutlass_kernels/cutlass_heuristic.cpp.o
[ 41%] Building CXX object CMakeFiles/decoupleQ_kernels.dir/mnt/nfs2/cjld/2bit/decoupleQ/dependencies/TensorRT-LLM/cpp/tensorrt_llm/kernels/cutlass_kernels/cutlass_preprocessors.cpp.o
[ 41%] Building CXX object CMakeFiles/decoupleQ_kernels.dir/mnt/nfs2/cjld/2bit/decoupleQ/dependencies/TensorRT-LLM/cpp/tensorrt_llm/common/logger.cpp.o
[ 41%] Building CXX object CMakeFiles/decoupleQ_kernels.dir/mnt/nfs2/cjld/2bit/decoupleQ/dependencies/TensorRT-LLM/cpp/tensorrt_llm/common/stringUtils.cpp.o
[ 75%] Building CUDA object CMakeFiles/decoupleQ_kernels.dir/cutlass_kernel_file_2.generated.cu.o
[ 75%] Building CUDA object CMakeFiles/decoupleQ_kernels.dir/mnt/nfs2/cjld/2bit/decoupleQ/dependencies/TensorRT-LLM/cpp/tensorrt_llm/kernels/cutlass_kernels/fpA_intB_gemm/fp16_int2_gemm_fg_scalebias.cu.o
[ 75%] Building CUDA object CMakeFiles/decoupleQ_kernels.dir/w2a16.cu.o
[ 83%] Building CUDA object CMakeFiles/decoupleQ_kernels.dir/mnt/nfs2/cjld/2bit/decoupleQ/dependencies/TensorRT-LLM/cpp/tensorrt_llm/kernels/cutlass_kernels/fpA_intB_gemm/bf16_int2_gemm_fg_scalebias.cu.o
[ 83%] Building CUDA object CMakeFiles/decoupleQ_kernels.dir/cutlass_kernel_file_1.generated.cu.o
/mnt/nfs2/cjld/2bit/decoupleQ/csrc/w2a16.cu(153): warning #177-D: variable "quant_range_scale" was declared but never referenced
const float quant_range_scale = 1.f / float(1 << (bits_in_type - 1));
^

Remark: The warnings can be suppressed with "-diag-suppress "
/mnt/nfs2/cjld/2bit/decoupleQ/csrc/w2a16.cu(60): warning #177-D: variable "res_ptr" was declared but never referenced
const T* res_ptr = nullptr;
^
detected during:
instantiation of "TrtllmFpAIntBGemm<T, WeightType, QuantOp>::TrtllmFpAIntBGemm() [with T=half, WeightType=cutlass::uint2b_t, QuantOp=cutlass::WeightOnlyQuantOp::FINEGRAINED_SCALE_AND_ZEROS]" at line 962 of /usr/include/c++/11/bits/unique_ptr.h
instantiation of "std::_MakeUniq<_Tp>::__single_object std::make_unique<_Tp,_Args...>(_Args &&...) [with _Tp=TrtllmFpAIntBGemm<half, cutlass::uint2b_t, cutlass::WeightOnlyQuantOp::FINEGRAINED_SCALE_AND_ZEROS>, _Args=<>]" at line 104
/mnt/nfs2/cjld/2bit/decoupleQ/csrc/w2a16.cu(153): warning #177-D: variable "quant_range_scale" was declared but never referenced
const float quant_range_scale = 1.f / float(1 << (bits_in_type - 1));
^
Remark: The warnings can be suppressed with "-diag-suppress "
/mnt/nfs2/cjld/2bit/decoupleQ/csrc/w2a16.cu(60): warning #177-D: variable "res_ptr" was declared but never referenced
const T* res_ptr = nullptr;
^
detected during:
instantiation of "TrtllmFpAIntBGemm<T, WeightType, QuantOp>::TrtllmFpAIntBGemm() [with T=half, WeightType=cutlass::uint2b_t, QuantOp=cutlass::WeightOnlyQuantOp::FINEGRAINED_SCALE_AND_ZEROS]" at line 962 of /usr/include/c++/11/bits/unique_ptr.h
instantiation of "std::_MakeUniq<_Tp>::__single_object std::make_unique<_Tp,_Args...>(_Args &&...) [with _Tp=TrtllmFpAIntBGemm<half, cutlass::uint2b_t, cutlass::WeightOnlyQuantOp::FINEGRAINED_SCALE_AND_ZEROS>, _Args=<>]" at line 104
/mnt/nfs2/cjld/2bit/decoupleQ/csrc/w2a16.cu(153): warning #177-D: variable "quant_range_scale" was declared but never referenced
const float quant_range_scale = 1.f / float(1 << (bits_in_type - 1));
^
Remark: The warnings can be suppressed with "-diag-suppress "
/mnt/nfs2/cjld/2bit/decoupleQ/csrc/w2a16.cu(60): warning #177-D: variable "res_ptr" was declared but never referenced
const T* res_ptr = nullptr;
^
detected during:
instantiation of "TrtllmFpAIntBGemm<T, WeightType, QuantOp>::TrtllmFpAIntBGemm() [with T=half, WeightType=cutlass::uint2b_t, QuantOp=cutlass::WeightOnlyQuantOp::FINEGRAINED_SCALE_AND_ZEROS]" at line 962 of /usr/include/c++/11/bits/unique_ptr.h
instantiation of "std::_MakeUniq<_Tp>::__single_object std::make_unique<_Tp,_Args...>(_Args &&...) [with _Tp=TrtllmFpAIntBGemm<half, cutlass::uint2b_t, cutlass::WeightOnlyQuantOp::FINEGRAINED_SCALE_AND_ZEROS>, _Args=<>]" at line 104
[ 91%] Linking CUDA device code CMakeFiles/decoupleQ_kernels.dir/cmake_device_link.o
[100%] Linking CXX shared library libdecoupleQ_kernels.so
[100%] Built target decoupleQ_kernels
make: warning:  Clock skew detected.  Your build may be incomplete.

cp libdecoupleQ_kernels.so ../../decoupleQ/decoupleQ_kernels.so
cd ../../

from decoupleQ.linear_w2a16 import LinearA16 from decoupleQ.linear_w2a16 import LinearW2A16 import torch
batch=2 in_features = 5120 out_features = 5120 group_size = 64 with_bias = False
def expand_group(x, group_size): return x.transpose(0, 1).unsqueeze(-1).repeat(1, 1, group_size).view(x.size(1), -1).transpose(0, 1).contiguous()
linear_a16 = LinearA16(in_features, out_features, with_bias, group_size) linear_w2a16 = LinearW2A16(in_features, out_features, with_bias, group_size)
weight_w2 = torch.randint(-2, 2, (in_features, out_features), dtype=torch.int8).cuda() weight_scale = torch.rand((in_features//group_size, out_features), dtype=torch.bfloat16).cuda() weight_zp = torch.rand((in_features//group_size, out_features), dtype=torch.bfloat16).cuda()
weight_a16 = weight_w2.to(torch.bfloat16) * expand_group(weight_scale, group_size) + expand_group(weight_zp, group_size)
linear_a16.weight = weight_a16 linear_w2a16.weight = weight_w2 linear_w2a16.scale = weight_scale linear_w2a16.zp = weight_zp
input = torch.rand((batch, in_features), dtype=torch.bfloat16).cuda()
out_a16 = linear_a16(input) out_w2a16 = linear_w2a16(input)
print(out_a16) print(out_w2a16)
你可以用上面的测试程序，测试下你的模型对应的shape，看是否正常。

跑了一下，w2a16和a16的shape是能对上的，值对不上

build log:

cd csrc
mkdir -p build
cd build
export TORCH_CUDA_ARCH_LIST=8.0+PTX
TORCH_CUDA_ARCH_LIST=8.0+PTX
cmake -DCMAKE_PREFIX_PATH=/python3.11/site-packages/torch -DDECOUPLEQ_TORCH_HOME=/python3.11/site-packages/torch -DCMAKE_BUILD_TYPE=Release -DDECOUPLEQ_CUDA_HOME=/usr/local/cuda -DDECOUPLEQ_CUDNN_HOME=/usr/local/cuda ..
-- The CXX compiler identification is GNU 11.4.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- The CUDA compiler identification is NVIDIA 12.5.40
-- Detecting CUDA compiler ABI info
-- Detecting CUDA compiler ABI info - done
-- Check for working CUDA compiler: /usr/local/cuda/bin/nvcc - skipped
-- Detecting CUDA compile features
-- Detecting CUDA compile features - done
-- Found Python3: /home/fuser/miniconda3/envs/2bit/bin/python3.11 (found version "3.11.9") found components: Interpreter Development Development.Module Development.Embed
-- Found CUDA: /usr/local/cuda (found version "12.5")
-- Found CUDAToolkit: /usr/local/cuda/include (found version "12.5.40")
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Caffe2: CUDA detected: 12.5
-- Caffe2: CUDA nvcc is: /usr/local/cuda/bin/nvcc
-- Caffe2: CUDA toolkit directory: /usr/local/cuda
-- Caffe2: Header version is: 12.5
-- /usr/local/cuda/lib64/libnvrtc.so shorthash is fb37b3f5
-- USE_CUDNN is set to 0. Compiling without cuDNN support
-- USE_CUSPARSELT is set to 0. Compiling without cuSPARSELt support
-- Added CUDA NVCC flags for: -gencode;arch=compute_80,code=sm_80;-gencode;arch=compute_80,code=compute_80
CMake Warning at ******/python3.11/site-packages/torch/share/cmake/Torch/TorchConfig.cmake:22 (message):
static library kineto_LIBRARY-NOTFOUND not found.
Call Stack (most recent call first):
******/python3.11/site-packages/torch/share/cmake/Torch/TorchConfig.cmake:127 (append_torchlib_if_found)
CMakeLists.txt:22 (find_package)

-- Found Torch: ******/python3.11/site-packages/torch/lib/libtorch.so
f"python3 found"
f"torch found"
-- Configuring done (11.4s)
-- Generating done (0.1s)
-- Build files have been written to: ************/decoupleQ/csrc/build

make -j
[ 25%] Building CXX object CMakeFiles/decoupleQ_kernels.dir************/decoupleQ/dependencies/TensorRT-LLM/cpp/tensorrt_llm/kernels/cutlass_kernels/cutlass_preprocessors.cpp.o
[ 33%] Building CXX object CMakeFiles/decoupleQ_kernels.dir************/decoupleQ/dependencies/TensorRT-LLM/cpp/tensorrt_llm/common/logger.cpp.o
[ 33%] Building CXX object CMakeFiles/decoupleQ_kernels.dir************/decoupleQ/dependencies/TensorRT-LLM/cpp/tensorrt_llm/kernels/cutlass_kernels/cutlass_heuristic.cpp.o
[ 41%] Building CXX object CMakeFiles/decoupleQ_kernels.dir************/decoupleQ/dependencies/TensorRT-LLM/cpp/tensorrt_llm/common/stringUtils.cpp.o
[ 50%] Building CXX object CMakeFiles/decoupleQ_kernels.dir************/decoupleQ/dependencies/TensorRT-LLM/cpp/tensorrt_llm/common/tllmException.cpp.o
[ 50%] Building CUDA object CMakeFiles/decoupleQ_kernels.dir************/decoupleQ/dependencies/TensorRT-LLM/cpp/tensorrt_llm/kernels/cutlass_kernels/fpA_intB_gemm/fp16_int2_gemm_fg_scalebias.cu.o
[ 58%] Building CUDA object CMakeFiles/decoupleQ_kernels.dir/cutlass_kernel_file_2.generated.cu.o
[ 83%] Building CUDA object CMakeFiles/decoupleQ_kernels.dir/w2a16.cu.o
[ 83%] Building CUDA object CMakeFiles/decoupleQ_kernels.dir************/decoupleQ/dependencies/TensorRT-LLM/cpp/tensorrt_llm/kernels/cutlass_kernels/fpA_intB_gemm/bf16_int2_gemm_fg_scalebias.cu.o
[ 83%] Building CUDA object CMakeFiles/decoupleQ_kernels.dir/cutlass_kernel_file_1.generated.cu.o
************/decoupleQ/csrc/w2a16.cu(153): warning #177-D: variable "quant_range_scale" was declared but never referenced
const float quant_range_scale = 1.f / float(1 << (bits_in_type - 1));
^

Remark: The warnings can be suppressed with "-diag-suppress "
***********/decoupleQ/csrc/w2a16.cu(60): warning #177-D: variable "res_ptr" was declared but never referenced
const T res_ptr = nullptr;
^
detected during:
instantiation of "TrtllmFpAIntBGemm<T, WeightType, QuantOp>::TrtllmFpAIntBGemm() [with T=half, WeightType=cutlass::uint2b_t, QuantOp=cutlass::WeightOnlyQuantOp::FINEGRAINED_SCALE_AND_ZEROS]" at line 962 of /usr/include/c++/11/bits/unique_ptr.h
instantiation of "std::_MakeUniq<_Tp>::__single_object std::make_unique<_Tp,_Args...>(_Args &&...) [with _Tp=TrtllmFpAIntBGemm<half, cutlass::uint2b_t, cutlass::WeightOnlyQuantOp::FINEGRAINED_SCALE_AND_ZEROS>, _Args=<>]" at line 104
************/decoupleQ/csrc/w2a16.cu(153): warning #177-D: variable "quant_range_scale" was declared but never referenced
const float quant_range_scale = 1.f / float(1 << (bits_in_type - 1));
^
Remark: The warnings can be suppressed with "-diag-suppress "
***********/decoupleQ/csrc/w2a16.cu(60): warning #177-D: variable "res_ptr" was declared but never referenced
const T res_ptr = nullptr;
^
detected during:
instantiation of "TrtllmFpAIntBGemm<T, WeightType, QuantOp>::TrtllmFpAIntBGemm() [with T=half, WeightType=cutlass::uint2b_t, QuantOp=cutlass::WeightOnlyQuantOp::FINEGRAINED_SCALE_AND_ZEROS]" at line 962 of /usr/include/c++/11/bits/unique_ptr.h
instantiation of "std::_MakeUniq<_Tp>::__single_object std::make_unique<_Tp,_Args...>(_Args &&...) [with _Tp=TrtllmFpAIntBGemm<half, cutlass::uint2b_t, cutlass::WeightOnlyQuantOp::FINEGRAINED_SCALE_AND_ZEROS>, _Args=<>]" at line 104
[ 91%] Linking CUDA device code CMakeFiles/decoupleQ_kernels.dir/cmake_device_link.o
[100%] Linking CXX shared library libdecoupleQ_kernels.so
[100%] Built target decoupleQ_kernels

cp libdecoupleQ_kernels.so ../../decoupleQ/decoupleQ_kernels.so
cd ../../

你这边测试的平台是A10吗？我看编译的是86架构的代码。
我这边在A10上 也是可以测试通过的，编译环境：
cmake: 3.26.3
nvcc: 12.2
torch: 2.1.0
gpu Driver: 510.47.03


fix the problem that cancel import auther will give error warning

Purpose
Fix the problem that cancel import author will give error warning. Close https://trello.com/c/6ZnBpm14/233-dataverse-error-when-cancel-import-access-token-for-multiple-linked-accounts

@sloria rdy fore review


sailor enable command won't work

When I try to enable/install sailor-md I'll get the error:
.lua/52/share/lua/5.2/sailor/md/app: No such file or directory
should I be using this command or just luarocks?

The enable command needs to be rewritten, I forgot to document this :)
Thanks for reminding me!

No problem! Maybe you want to take a look at https://github.com/sailorproject/sailor/blob/master/src/sailor.lua#L94 too.


Add a version of toLinkedMap that accepts a mergeFunction

Following up on https://github.com/vavr-io/vavr/pull/2595#issuecomment-630939379 adding a merge function to toLinkedMap.
@danieldietrich I'm not sure if I managed to capture all challenges you mentioned in your comment. So please let me know if I missed something.

Codecov Report

Merging #2601 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #2601   +/-   ##
=========================================
  Coverage     92.84%   92.84%
- Complexity     5353     5354    +1
=========================================
  Files            89       89
  Lines         12752    12753    +1
  Branches       1610     1610
=========================================
+ Hits          11840    11841    +1
  Misses          723      723
  Partials        189      189

Impacted Files
Coverage Δ
Complexity Δ

src/main/java/io/vavr/collection/Traversable.java
96.77% <100.00%> (+0.01%)
113.00 <1.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f59cd60...03644e7. Read the comment docs.


Limit follower load on like_follower

Added option nfollows on like_followers.
Added the possibility to limit the number of loaded followers from user_id that have a very high number of follower.
I Think this option are usefull for many users

Nice job, thx.


14.0.0-14.0.2 does not work (npm/Windows)

I upgraded now cli to 14.0.0 using npm on Windows, but now cli does not work at all:

You do not have to worry about the upgrade time. I ran this after I booted Windows.
This problem can be temporarily avoided by downgrading to 13.1.3:
 npm install -g<EMAIL_ADDRESS>

@subtleGradient contributed with this:
(function (exports, require, module, __filename, __dirname) { MZ�
                                                                ^

SyntaxError: Invalid or unexpected token
    at createScript (vm.js:80:10)
    at Object.runInThisContext (vm.js:139:10)
    at Module._compile (module.js:616:28)
    at Object.Module._extensions..js (module.js:663:10)
    at Module.load (module.js:565:32)
    at tryModuleLoad (module.js:505:12)
    at Function.Module._load (module.js:497:3)
    at Function.Module.runMain (module.js:693:10)
    at startup (bootstrap_node.js:191:16)
    at bootstrap_node.js:612:3

I understood. I am waiting for the reflection of this renovation.
This issue will keep Open until we can see improvements.

the same issue on Windows

I've tried v13.1.3 but it didn't work

Same issue here. It is severe I hope you can fix it soon
windows 10
node v10.14.2

@deebov The problem you encounter is different from this issue.
(My Now CLI worked normally until 13.1.3)
Please proceed with problem solving by either of the following:

Go to Spectrum chat and consult (Recommend): https://spectrum.chat/zeit
Establish New issue

@lrn2prgrm If you are using Now Desktop, you can stop automatic updating of Now CLI:
https://zeit.co/docs/v1/guides/updating-now-cli
Now Desktop and installed by npm or yarn are different Now CLI apps.
It can cause another problem:
https://github.com/zeit/now-cli/issues/1809

I confirmed the release of 14.0.1-canary.1 and tried it, but the problem is ongoing:

Indeed doesn't work here either

I tried 14.1.0-canary.2 but the problem is still ongoing:

So 14.1.0 will be released soon will still have problems. (Edit this post after publishing)

I tried 14.1.0-canary.2 but the problem is still ongoing:

So 14.1.0 will be released soon will still have problems. (Edit this post after publishing)

I tried 14.1.0-canary.3, This problem is ongoing

:

Still an issue for me as well. Downgrading to 13.x works in the meantime.

14.0.2 has been released, but this problem is ongoing:

"now\download\dist\now" is missing/empty.
But, as a workaround, scoop can be used to install the now-win.exe directly with:
C:\>scoop install "https://raw.githubusercontent.com/rivy/scoop-bucket/master/now.json"

Additional info
When installed via yarn, the "now.cmd" file contains:
@"%~dp0\..\..\..\..\..\Yarn\Data\global\node_modules\.bin\now.cmd"   %*

That ".bin\now.cmd" file then uses node to run "%~dp0..\now\download\dist\now", but that final file is completely empty:
C:>msls -Al node_modules\now\download\dist
total 32M
-rw------a  1 Roy              572k Mar  2 12:40 index.js
-rw------a  1 Roy                 0 Mar  2 12:46 now
-rwx-----a  1 Roy               31M Mar  2 12:46 now.exe*

Issue got fixed by https://github.com/zeit/now-cli/pull/1922 in release 14.1.0-canary.4.

Awesome work!:


Photon 2.0 Bug fix to properly identify VMware Photon OS.

In the Photon 2.0 release, /etc/photon-release doesn't have VMware Photon Linux anymore. It contains:
<EMAIL_ADDRESS>[ ~ ]# cat /etc/photon-release
VMware Photon OS 2.0

Fixing the code to grep for only VMware Photon instead of VMware Photon Linux. Other tiny changes include:

Fix the README file with the proper bundle command
Fix the gemspec file to have a rspec version < 11.0 because of https://stackoverflow.com/questions/35893584/nomethoderror-undefined-method-last-comment-after-upgrading-to-rake-11

Testing output:
 huralikoppia@huralikoppia-m03 ~/code/vagrant-guests-photon $ rspec                                                                                 ✔  5058  15:27:40
[Coveralls] Set up the SimpleCov formatter.
[Coveralls] Using SimpleCov's default settings.
..........

Finished in 0.01164 seconds
10 examples, 0 failures
[Coveralls] Outside the CI environment, not sending data.

Coverage remained the same at 98.817% when pulling 4e8bbed80e941269777a80d8992019786fae7a21 on ankurdh:vmw_photon_2_readiness into 3c41310b427ecbe5af5b6d47861f6c01057e535c on vmware:master.

Thanks @ankurdh just pushed version v1.0.5 to rubygems.


Put the app info in the About window into a text file in My.Resources.

This way I won't have to deal with formatting text via code and can update the details at any time without making sure the text all looks good.
Copied from my HideSettingsPages repo as issue 39.

As of https://github.com/DrewNaylor/UXL-Launcher/commit/64b8d9fc8905f3533e348baf5f7e12005c012d64, the About window now uses text files in My.Resources to output information in the About tab for UXL Launcher, the theme engine, and applauncher-icons. Wording may change in the future (especially with the information for the theme engine, which should have a link to a wiki page with instructions on making custom themes, or at the very least, an example theme file), but it's complete enough to close this issue.


UserPool not being tagged properly from tags.json

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
v16.17.0
Amplify CLI Version
10.0.0
What operating system are you using?
Windows
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
No manual changes made
Amplify Categories
auth
Amplify Commands
Not applicable
Describe the bug
The user pool is not being tagged by the tags.json file.
Tags.json file:
[
  {
    "Key": "application",
    "Value": "{project-name}-infra"
  },
  {
    "Key": "environment",
    "Value": "{project-env}"
  },
  {
    "Key": "createdby",
    "Value": "Amplify"
  },
  {
    "Key": "owner",
    "Value": "Amplify"
  }
]

User pool:

Expected behavior
It should be tagged like the other resources
Reproduction steps

Add auth
Push
Observe no tags being added to user pool

GraphQL schema(s)
Not Applicable
Project Identifier
No response
Log output
Not applicable
Additional information
Currently to get around it, in the override.ts I've been adding the following:
 resources.userPool.tags.setTag(
    'application', `${config.applicationName}-infra`
  );
  resources.userPool.tags.setTag(
    'environment', config.env
  );
  resources.userPool.tags.setTag(
    'createdby', 'Amplify'
  );

Hey @nathanthorpe :wave: thanks for raising this and for providing the workaround! It appears this is a duplicate of https://github.com/aws-amplify/amplify-cli/issues/10548 and more specifically, https://github.com/aws-amplify/amplify-cli/issues/6642. Closing in favor of tracking the existing items

Ah great thanks, my bad I searched User pool rather than cognito :slightly_smiling_face:


Synthetic Script timeout

The Synthetic script timeout due to large number of accounts
I'm running this with an account with 315 sub-accounts, to get a chargeback for IT department which includes about 8 accounts. Synthetic monitors and dashboards are all created successfully. However, the synthetic script failed due to timeout.
Relevant Logs / Console output
Error: Job timed-out after<PHONE_NUMBER>87s
at handleScriptTimedOut (/app/synthetics-node-api-runtime/runtime/signals/signalHandlers/job-timed-out-handler.js:4:9)
at process. (/app/synthetics-node-api-runtime/runtime/signals/signals.js:15:5)
at process.emit (node:events:513:28)
at process.emit (/app/synthetics-node-api-runtime/.pnp.cjs:13281:25)
at Timeout.handleTimeout [as _onTimeout] (/app/synthetics-node-api-runtime/runtime/sandbox/driver.js:5:11)
at listOnTimeout (node:internal/timers:559:17)
at processTimers (node:internal/timers:502:7)

@Lucy0 the timeout is caused by an issue with the public GraphQL API, which I will raise with the team responsible.  When the script is used against an organization with almost 1000 groups the service behind the public API  times out, even though pagination is requested.
I have found a workaround for the timeout by querying groups and their users, as opposed to users and their groups. This should allow the script to run on a public synthetics minion in less than 3 minutes, even for an account with > 1200 users, ~1000 groups and 300+ accounts. The fix will be released as v1.0.3 shortly.


Node.js  Loaders Team Meeting 2021-12-07

Time
UTC Tue 07-Dec-2021 18:00 (06:00 PM):

Timezone
Date/Time

US / Pacific
Tue 07-Dec-2021 10:00 (10:00 AM)

US / Mountain
Tue 07-Dec-2021 11:00 (11:00 AM)

US / Central
Tue 07-Dec-2021 12:00 (12:00 PM)

US / Eastern
Tue 07-Dec-2021 13:00 (01:00 PM)

EU / Western
Tue 07-Dec-2021 18:00 (06:00 PM)

EU / Central
Tue 07-Dec-2021 19:00 (07:00 PM)

EU / Eastern
Tue 07-Dec-2021 20:00 (08:00 PM)

Moscow
Tue 07-Dec-2021 21:00 (09:00 PM)

Chennai
Tue 07-Dec-2021 23:30 (11:30 PM)

Hangzhou
Wed 08-Dec-2021 02:00 (02:00 AM)

Tokyo
Wed 08-Dec-2021 03:00 (03:00 AM)

Sydney
Wed 08-Dec-2021 05:00 (05:00 AM)

Or in your local time:

https://www.timeanddate.com/worldclock/fixedtime.html?msg=Node.js+Foundation+Loaders Team+Meeting+2021-12-07&iso=20211207T1800
or https://www.wolframalpha.com/input/?i=06PM+UTC%2C+Dec+07%2C+2021+in+local+time

Links

Minutes Google Doc: https://docs.google.com/document/d/1D9sf_6YbmPYDZqbwQKT9UcZSC6MerhtoS7lzNzUIeN4/edit

Agenda
Extracted from loaders-agenda labelled issues and pull requests from the nodejs org prior to the meeting.
nodejs/loaders

Add hook for manifest loading #44
Design doc for reuse of defaultResolve #33
Feature request: Utility functions for the steps of resolution and loading #26

Invited

Loaders team: @nodejs/loaders

Observers/Guests
Notes
The agenda comes from issues labelled with loaders-agenda across all of the repositories in the nodejs org. Please label any additional issues that should be on the agenda before the meeting starts.
Joining the meeting

link for participants: https://zoom.us/j/97506450082

For those who just want to watch: https://www.youtube.com/c/nodejs+foundation/live

These agenda items are the same ones from last time. I forgot to remove the agenda label.
Do we need any further discussion on these, or on anything else?

Maybe we should reconvene after the holidays — it would give us the time for experimentation w/ the current iteration of the hooks system before we discuss chaining. I somewhat have a feeling that we are going to need one more iteration of the hooks system before we should feel confident enough in our API to incorporate chaining into the equation.

I think we don't need to re-visit these. I don't have anything new yet and won't have finished any implementations to discuss those. I'm picking up https imports today, but I doubt that'll be done by Tuesday.

Yep I have open my PR, but given the short amount of time until the meeting I feel like it should be fine to make the first few iterations async via the PR comments, and see whether it stabilised enough to discuss the remaining bits in January?

Okay so per these comments I assume we should cancel for tomorrow?

This agenda — it looks to be very pertinent, and they are all things that I would be interested in having a conversation about — things that may be long overdue for us to discuss…
At the moment, I am a bit bogged down w/ other things. Still, I would be interested in discussing these topics in greater length, but whether I see myself jumping on a conference call tomorrow afternoon is another story. 🙃
Is anyone else planning to attend? I may be able to show up if others want to have a chat.

Mm, I think the time today might be better spent reviewing Maël's PR and implementing the other PRs.

Okay sounds like we should cancel this one. I'll remove the agenda label from those issues, please add it to anything you want to discuss next time.

Why remove agenda label? Those are all valid issues!

Why remove agenda label? Those are all valid issues!

They were all discussed at the last meeting. If you or anyone else would like to discuss them at the next meeting, just add the label back. Once an issue is discussed at a meeting, we take the label off unless folks in the meeting say that they want to continue discussing that topic at the next meeting, but that didn’t happen for any of these last time.

They were all discussed at the last meeting.

Where is that recording?

Where is that recording?

@bmeck was the host. https://github.com/nodejs/loaders/issues/53#issuecomment-985917765

@GeoffreyBooth YouTube failed to stream with some kind of permissions issue so it got synced to the Zoom cloud again.

What was even discussed? Nothing actionable, I presume. I don't have those Zoom cloud credentials, AFAIK. It would be great if @GeoffreyBooth (or someone) could somehow share that (put it on YouTube) if it still has any relevance.

https://youtu.be/YxaDXjBAPoU


CI SESSION use  redis cluster

sorry,My englisth is so poor。
Now,I want to put the session to redis.
I use the php-redis extension.
when I use the single-instance , I change the config.php to
$config['sess_driver'] = 'redis'; $config['sess_save_path'] = '<IP_ADDRESS>:6379';
it works ok.
next,the problem.
I have two server , I want to use the redis cluster . I set the cluster OK.
I use the next code to test it
<?php $redis = new RedisCluster(NULL, Array('<IP_ADDRESS>:6380')); $redis->set('test','test'); echo $redis->get('test'); ?>
and I put key value from one server,and I can get the value from other server.so the cluster is OK.
But how change the config.php to connect to redis cluster?  I have tried a variety of methods,it not work.The error message is
Warning: Failed to write session data (user). Please verify that the current setting of session.save_path is correct
what can I do? Is CI support redis cluster?
Thank you very much for your help!

No, we don't support Redis clusters.
This is a bug tracker. In the future, please post your questions on our forums instead.

@narfbg   thank you very much. I am very happy that  you can understand my question. hahahahaha.
now, i put my session to the db.


Empty cell sorting order

It would be nice if empty cells always sorted to the bottom, like this. Or add options emptyToBottom and emptyToTop

imho, empty cells should either be always lower than any other value or always higher than any other value. ie, they should be either at the top or at the bottom, depending on the sort order (not always at the bottom, regardless of the order).

Came here looking to see if this was available as well. It would be great if empty cells were always at the bottom.

@bridgeport , just go here for more intuitive sorting table, there is an option to sort empty table cell to the bottom, doc.
But i still hope option like this also available in this repo..

Really missing this option.
And it's impossible to implement that through sorting methods without hacking of the package itself which really makes me sad :(


No chat reports crashes game with Custom LAN enabled

Whenever the "Edit LAN" button is pushed by the player, the game will lock up then instantly crash.
Mods for testing:
Custom LAN v2.0.2 - 1.19 branch,
No-Chat-Reports 1.19.1-v1.7.0,
Fabric API 0.58.5.

https://user-images.githubusercontent.com/68134602/181782525-bb2ab4e5-e00a-4907-b45d-85119cda798b.mp4
After updating, it seems to work now but the button itself is incorrect.

I fear that is not an issue on my side. Crash happened because I didn't update one of the methods in my mixins, it wasn't related to Custom LAN specifically.


Grammar issue

Grammar issue:
'Workspaces are hosted on a physical clusters.'
should read
'Workspaces are hosted on physical clusters.'

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 711d80f5-3386-0767-ee9e-a309fd5b679a
Version Independent ID: 40b54243-abf8-209e-c492-80f77a362cff
Content: Designing your Azure Monitor Logs deployment - Azure Monitor
Content Source: articles/azure-monitor/platform/design-logs-deployment.md
Service: azure-monitor
Sub-service: ****
GitHub Login: @bwren
Microsoft Alias: bwren

@ivandretvic Thanks for your feedback! We will investigate and update as appropriate.

@ivandretvic Thanks for your feedback! We will investigate and update as appropriate.

@ivandretvic Thanks again for the feedback! The PR has been created and it merge soon.

@ivandretvic Thanks again for the feedback! The PR has been created and it merge soon.


fix: prevent double type field in api properties

This prevents duplicates in the api properties decorator

Thanks. As you may have seen, I also fixed some issues with the type property. Before releasing 1.18.0, I merged the 1.18.0-beta branch and your PR resulting in this new issue.
I will be able to have a look at it next week, when I will be back.


Error in variable name (iceServers)

Hello Tahir
Thanks for the latest update, I got minor issues in developer console during implementation.
Error in console
VIDEOJS: SyntaxError: Unexpected token u in JSON at position 0     at JSON.parse (<anonymous>)     at WebRTCHandler.initiateWebRTCAdaptor (videojs-webrtc-plugin.js:837:26)     at new WebRTCHandler (videojs-webrtc-plugin.js:808:12)     at Object.handleSource (videojs-webrtc-plugin.js:1070:21)     at Html5._Tech.setSource (video.js:12200:32)     at Player.<anonymous> (video.js:26378:31)     at Player.ready (video.js:4389:12)     at Player.techCall_ (video.js:26369:12)     at Player.<anonymous> (video.js:27671:16)     at Player.ready (video.js:4389:12)
Steps to Reproduce
VERSION : 1.1.0

Clone the repo
Install dependency
Create build

SCRIPT this way
``
After applying breakpoint here -> (videojs-webrtc-plugin.js:837:26). I found spelling mistake in iceServer
this.source.pcConfig = {         iceServers: JSON.parse(source.iceservers)       };
After changing the spelling of iceservers in index.html file error disappeared from console.
One more thing that can be improved is :
You have used videojs id : (videojs-webrtc-player) in index.html file. While in README.md id (my-video) has been used everywhere.
Also, I think you need to change the event name from ant-error to webrtc-error.
When I run index.html it throws error :
Uncaught TypeError: examplePlayer.antmediaWebrtc is not a function     at HTMLFormElement.<anonymous> (index.html:85:47)

Thanks @rahul7827 noted, I will change the index.html completely according to your feedbacks, it is left from the older versions currently. And thanks for noticing the naming issue. Any commit from you is also welcomed on this repo!


Move to crack

This PR moves the common set of handlers to their own project.  This will allow them to be re-used in other frameworks like Kemal or on their own.

Because the router depends on params being parsed in order to get params["_method"] I don't think that params handler should be moved into a separate project. In my opinion only optional handlers should be moved out.

@elorest hmmm.  Agree there shouldn't be a dependency.  Maybe I should remove the params["_method"] from the router and create a new handler for it? Or maybe your right and params should stay in Kemalyst.

I would argue that all restful methods need to work in the router by
default. Also I don't think we want to parse params twice.
On May 21, 2017 7:17 AM, "Dru Jensen"<EMAIL_ADDRESS>wrote:

@elorest https://github.com/elorest hmmm. Agree there shouldn't be a
dependency. Maybe I should remove the params["_method"] from the router and
create a new handler for it? Or maybe your right and params should stay in
Kemalyst.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kemalyst/kemalyst/pull/51#issuecomment-302936192, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAHmpGxl8n2f-i8HunYQ9rsea9fo9QRfks5r8DlugaJpZM4Nhb3f
.

right, right.  The method override is because HTML 4/5 doesn't support PUT and DELETE.  Any AJAX call should work fine for these RESTful endpoints.  I created a new handler called Method that handles the HTML method override and will be added to the stack by default.  This is how rack does it.  This will remove the dependency and move it to crack.


Add coingeckoID for Solabrador

Please note: This repository is being rebuilt to accept the new volume of token additions and modifications. PR merges will be delayed.

I agree to not ping anybody on Discord/Twitter/email about this pull request. Instead I will inquire by posting a new comment in the pull request if needed.

PRs are reviewed in bulk and and can take up to two weeks to be merged.
This repository is managed using an auto merge action. Please ensure your PR has no deleted lines, and it will be merged.
Please provide the following information for your token.
Please include change to the src/tokens/solana.tokenlist.json file in the PR.
DON'T modify any other token on the list.
At minimum each entry should have

Token Address:
Token Name:
Token Symbol:
Logo: (logo should be uploaded under assets/mainnet//*.<png/svg>)
Link to the official homepage of token:
Coingecko ID if available (https://www.coingecko.com/api/documentations/v3#/coins/get_coins__id_):

Auto merge requirements
Your pull request will be automatically merged if the following conditions are met:

Your pull request only adds new tokens to the list. Any modification to existing
tokens will require manual review to prevent unwanted modifications.

Your pull request does not touch unrelated code. In particular, reformatting changes to unrelated
code will cause the auto merge to reject your PR.

Any asset files added correspond to the token address you are adding. Asset files
must be PNG, JPG or SVG files.

Your change is valid JSON and conforms to the schema. If your change failed validation,
read the error message carefully and update your PR accordingly.

No other tokens shares the same name, symbol or address.

For example, this change would be rejected due to unrelated changes:

The bot runs every 60 minutes and bulk-merges all open pull requests to prevent conflicts.
This means that you need to wait up to 60 minutes for your pull request to be merged or reprocessed.

Created an issue aswell.
I need someone to add this manually, we want to add coingeckoid, our serum marketid and change the decimal.
The token was minted with 9 decimals, i somehow was able to change it to 6 here earlier and now i cant change back. 6 decimals is causing some issues in certain markets though, so its a bit of an emergency.
Any help with these things would be greatly appreciated!

confirmed coingeckoid
confirmed serum address
confirmed decimals=9 on https://solscan.io/token/GLmaRDRmYd4u3YLfnj9eq1mrwxa1YfSweZYYZXZLTRdK


(CI) We retry after "provider produced inconsistent result after apply" which can result in a misleading error message

Error: Provider produced inconsistent result after apply

When applying changes to module.env.google_service_account.bank_of_anthos,
provider "module.env.provider[\"registry.terraform.io/hashicorp/google\"]"
produced an unexpected new value: Root object was present, but now absent.

This is a bug in the provider, which should be reported in the provider's own
issue tracker.. Sleeping for 2m0s and will try again.

Step #11 - "appfactory-apply": Error: Provider produced inconsistent result after apply
Step #11 - "appfactory-apply":
Step #11 - "appfactory-apply": When applying changes to
Step #11 - "appfactory-apply": module.components["userservice"].module.app_env_project["production"].module.project-factory.google_service_account.default_service_account[0],
Step #11 - "appfactory-apply": provider "provider[\"registry.terraform.io/hashicorp/google\"]" produced an
Step #11 - "appfactory-apply": unexpected new value: Root object was present, but now absent.
Step #11 - "appfactory-apply":
Step #11 - "appfactory-apply": This is a bug in the provider, which should be reported in the provider's own
Step #11 - "appfactory-apply": issue tracker.' but this error was expected and warrants a retry. Further details: Provider eventual consistency error.

https://github.com/hashicorp/terraform-provider-google/issues/18087

The adoption of the new https://github.com/terraform-google-modules/terraform-google-project-factory/releases/tag/v15.0.1 has greatly reduced the frequency of impact.


Annotations

Hello,
I am trying the annotation module Annotate binding sites to genes and using gencode.v40.sorted.gtf (https://www.gencodegenes.org/human/) as gtf file.
Many of the pairs that are found from the same bed files are returning output as follows - no annotation found even thought the pair is present in the data/bed file. Some are returning annotations.
I need to understand the inventor's opinion on both the cases - what does it mean to have a gene annotation of a particular TF pair? What does it mean when you don't get any return for your annotation?

Hi @Rajashree93

I need to understand the inventor's opinion on both the cases - what does it mean to have a gene annotation of a particular TF pair? What does it mean when you don't get any return for your annotation?

If you find annotation for some pairs but not for others, a missing annotation can be interpreted as this TF pair was not found near any genes in the .gtf file. For example, if TF's are found in distal chromatin regions, they are not annotated to genes but might still be important in other contexts. You might also try to adjust the annotation parameters in order to find more/annotations by using custom_config as described in the documentation here: https://tf-comb.readthedocs.io/en/latest/API/tfcomb.annotation.html#tfcomb.annotation.annotate_regions
Hope this helps explain the functionality.

I will close this for now, since there was no activity for a long time in this Issue.
Please feel free to reopen the Issue if the problem persists.


wrongly extracting username from JWT

This line should be extracting "username" rather than "user"
https://github.com/RasaHQ/rasa_core/blob/master/rasa_core/server.py#L93

Hi @akelad! I just fixed this bug along with another bug, and got the pull request in!

Hi! This change caused the build server failed to build, is that okay without passing the Travis CI?


Use create_launch_template without Detailed CloudWatch monitoring

Is your request related to a new offering from AWS?
No.
Is your request related to a problem? Please describe.
I'm using module version 17.24.0 and I'm currently in the process of changing the container runtime of all nodes to containderd. I just noticed the bootstrap_env parameter, which would be a nice way to get rid of the explicit launch templates we currently use. However, when creating a launch template with that parameter, by default the extended cloudwatch metrics are gathered. As we don't need this, I was trying to find a way to influence this parameter. However, without any luck so far. Is it even possible to influence it or do we have to keep using explicit launch template definitions? Setting create_launch_template to true is a necessary parameter to use bootstrap_env I have noticed. Thanks!

in your node group definition add:
..............
  self_managed_node_groups = {
    default_node_group = {
       enable_monitoring = false
    }
..............

to change only one node group, or to make it globally as default:
  eks_managed_node_group_defaults = {
    enable_monitoring = false
  }

Thanks a lot, I have totally missed this parameter.


Github action always get Crawling issue: nbHits 0

Are there any updates on GitHub action? And is there any particular significance to our linking algolia in GitHub action?
I always get Crawling issue: nbHits 0 on push indices to algolia stage.

Could you help me to figure out this?
Thanks!

Try the official crawler configuration:
https://vitepress.dev/reference/default-theme-search#crawler-config


Osmosis (cosmos-sdk v0.46.10) GetNodeInfo transport error

Hi,
I am having troubles interacting via gRPC with Osmosis nodes (other Cosmos blockchains work).
I think this is might related to  Proto-build fails for SDK 0.46 #318 (cosmos-rust) due to the recent proto changes. Can you confirm that?
docker run fullstorydev/grpcurl osmosis-grpc.lavenderfive.com:443 cosmos.base.tendermint.v1beta1.Service/GetNodeInfo

works, but using the latest cosmos-rust I get
status: Unknow, message: "transport error"

code:
cosmos_sdk_proto::cosmos::base::tendermint::v1beta1::service_client::ServiceClient::new(c).get_node_info(GetNodeInfoRequest{}).await

full code can be found here
Do you have any ideas why this might be happening?
Any help is appreciated, thanks in advance.

It seems to be a different issue: GoAway(b"", FRAME_SIZE_ERROR, Library)
Not sure what it means.
[2023-04-02T08:21:40Z ERROR cosmos_rust_package::api::core::cosmos::channels] GetNodeInfoRequest failed for http://osmosis-grpc.lavenderfive.com:443: Status { code: Unknown, message: "transport error", source: Some(tonic::transport::Error(Transport, hyper::Error(Http2, Error { kind: GoAway(b"", FRAME_SIZE_ERROR, Library) }))) }
[2023-04-02T08:21:40Z ERROR cosmos_rust_package::api::core::cosmos::channels] GetNodeInfoRequest failed for http://grpc-osmosis-ia.cosmosia.notional.ventures:443: Status { code: Unknown, message: "transport error", source: Some(tonic::transport::Error(Transport, hyper::Error(Http2, Error { kind: GoAway(b"", FRAME_SIZE_ERROR, Library) }))) }
[2023-04-02T08:21:40Z ERROR cosmos_rust_package::api::core::cosmos::channels] GetNodeInfoRequest failed for http://osmosis.grpc.stakin-nodes.com:443: Status { code: Unknown, message: "transport error", source: Some(tonic::transport::Error(Transport, hyper::Error(Io, Custom { kind: BrokenPipe, error: "stream closed because of a broken pipe" }))) }
[2023-04-02T08:21:42Z ERROR cosmos_rust_package::api::core::cosmos::channels] Unable to establish a connection to http://osmosis.grpc.interchain.ivaldilabs.xyz:433: transport error

    Caused by:
        0: error trying to connect: tcp connect error: No route to host (os error 113)
        1: tcp connect error: No route to host (os error 113)
        2: No route to host (os error 113)

Closing this issue, the solution was to use the https:// schema and add the tonic feature flag "tls-roots":
tonic = { version = "^0.8", features = ["transport","tls","tls-roots","tls-webpki-roots"] }


Added tags for iam policy

Description of your changes

This PR adds feature to tag IamPolicy, fixes https://github.com/crossplane/provider-aws/issues/599
I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested
The changes have been tested on a local kind cluster and verified the state of IamPolicy via cli.

Thanks, merging. The codecov report points seems to be incorrect, it reports changes in coverage in methods you have not changed.


Implements Course and Section time statistics

This PR Introduces:

Time statistics on each category/section of the course curriculum
Time statistics in the sidebar for the course overall
Toggle switch to enable all the statistics.

Please see the video and images below.
A couple of points worth noting:

For the toggle switch I created a new JavaScript file popup/ztmSectionTime.js and then referenced it within the popout.html file. I opted for this to separate concerns and to avoid creating a difficult to read/edit JavaScript file as the extension grows.
My code editor automatically formatted certain files like the manifest.json file. I noticed a student had a similar issue in this PR where the quotes were changed. It might be worth adding some prettier rules to the project to create a more unified environment and prevent changes like these.
I opted not to display the stats in the side bar when the video player was present as it felt a little too much. But this can be achieved by updating the match in the manifest from "https://academy.zerotomastery.io/courses/enrolled/" to "https://academy.zerotomastery.io/courses/"

https://www.loom.com/share/2d958548fc324322a70b40cae3fa1950?sid=024a827a-77dd-4fec-bd4c-4d4430e4496c

Thank you @MattCSmith
It is cool you added the total amount of time feature.

This is very cool! Great feature @MattCSmith .
@sithu-khant I'm wondering if we should change the color of this feature since we don't use that ZTM pink in the course player. Maybe a lighter grey?

@aneagoie I already did that 😁

This is very cool! Great feature @MattCSmith .
@sithu-khant I'm wondering if we should change the color of this feature since we don't use that ZTM pink in the course player. Maybe a lighter grey?

@aneagoie Thanks it was fun to do.
I went with the ZTM pink initially to bring in some more of the ZTM branding and to add an accent.
I had also tweaks some other styles slightly, but that didn't belong in this PR.
Sithu dropped me a message about tweaking the colors a little and it looks great either way.
Although I'll probably still continue using the pink version 😉

The feature looks awesome.