Check fails even if all issues got auto fixed

Expected Behavior
If all found issues where automatically fixed the check/build should not fail.
Observed Behavior
The check/build fails even if after auto fixing no issues exists.
If I run detekt a second time it passes.
Steps to Reproduce
build:
  maxIssues: 1
formatting:
  active: true
  android: true
  autoCorrect: true

Introduce an issue which is auto correctable.
Run the detekt gradle task.
Context
I want to use the same config/task to auto format/fix and check the result
(locally and on the ci server)
Your Environment

Version of detekt used: 1.0.0 (also tested with 1.0.0-RC15)
Version of Gradle used (if applicable): Gradle 5.1.1
Operating System and version: macOS Mojave

Thanks for reporting this!
I think we shouldn't report issues, which are corrected by the same run of detekt.
However, if the autoCorrect is disabled, this issues should be reported.
Greetings to the Ländle 🙂

@schalkms thx for the fast help/PR.
Now greetings from the capital. 🙂

@schalkms I'm not sure but don't we have already the requested behavior by giving the formatting rule set a weight of 0?
build:
  maxIssues: 1
  weights:
    formatting: 0

I think so, but it's not coupled to the auto-correct option.

We could add an option to the build-namespace like excludeCorrectable and introduce a new Api DetektionFilter or ResultFilter which basically should do what FilteredDetectionResult is doing for the baseline feature.
https://github.com/arturbosch/detekt/blob/3543c2fe1aa46b579aac61371a13b9faf23c6e95/detekt-cli/src/main/kotlin/io/gitlab/arturbosch/detekt/cli/FilteredDetectionResult.kt#L8-L19

I can't think of a case where you want to add the already fixed issues to the total maxIssues count. That's why I don't think this config option is worth the effort.

I can't think of a case where you want to add the already fixed issues to the total maxIssues count. That's why I don't think this config option is worth the effort.

True thats why we could filter them in a ResultFilter is is active by default and print the ModificationNotification.
The linked issue has also an use case for ResultFilter's.


OpenCvSharp usage with individual native DLLs

Hello,
After a little googling, I did not find anything on the issue I'm facing.
We have a software that uses OpenCV both in native and managed code (via OpenCvSharp). The native part of our software uses individual OpenCV DLLs (core, imgproc, highgui, etc.), so in order to lighten our installation package I was wondering if OpenCvSharp can be complied to use the same individual DLLs.
In older OpenCvSharp versions, in the NativeMethods.cs file, we could configure the code to use the individual DLLs (via the array OpenCVDllNames), but I didn't find the same possibility in the latest source code (we'd like to use OpenCV 4.2.0).
So here is my question: is there any way to use the individual OpenCV DLLs instead of opencv_word?
Thanks in advance

Since the OpenCV C API is mostly obsolete, that old method is no longer available. I think it's possible if you customize and build your own native bindings (OpenCvSharpExtern.dll). OpenCvSharpExten links a lot of features, so you'll have to cut out the ones you don't need.
Honestly, it's not worth the effort, so I think it's easier to develop the wrapper by yourself, using C++/CLI or something similar.


Error when ConstructionOptions isn't set

Hello,
when the function reference property "ConstructionOptions" isn't set, one get's an error:
Microsoft.AspNetCore.Components.WebAssembly.Rendering.WebAssemblyRenderer[100]
Unhandled exception rendering component: Object reference not set to an instance of an object.
System.NullReferenceException: Object reference not set to an instance of an object.
at BlazorMonaco.MonacoEditor.OnAfterRenderAsync(Boolean firstRender)
Maybe this works as designed but a component should not cause a page exception when properties aren't said - right?

Fixed. It will be released v3.0.1

Any ETA for the 3.0.1 ?

@hjrb Thanks for reporting this issue, it helped me figure out the workaround. Admittedly, most users will probably always set this property. For newcomers like myself, however, it's best to not cause a page exception when not setting the ConstructionOptions, but instead, initialise it internally.


Remove react prop types from production build

They are only used in debug builds, we should not include the complete prop-types code in the dist package

In 3.0.1


Bump all dependencies

Now that EC cli supports go 1.22, I ran go get -u ./... on all the modules in this repo. This is the result.

The linter faillure seems to be bogus... AFAICT the code is doing exactly what the docs are recommending.

Commit message typo fyi: TerminiationReason

You could be a little more verbose about the G115 since it's security related, but otherwise lgtm.


Skip preamble when parsing command line host;port

There may be a bigger scope fix that would solve this better but the key thing I noticed was that the entire command line was being parsed.
This change resets the "start" point whenever it sees a space.  This assumes that the host and port will never contain spaces nor be separated by spaces.

Looks good. I guess it could also start to find the first space starting from the right, and start the loop normally from there, afterward.
Would you mind making a pull request in the 'Dev' branch instead?
Thank you.

Awesome.  I could see a world where it scans for multiple entries on the command line but I'm not sure how best to do that in this code base.  At any rate I've rebased the PR to dev and it looks clean.
Thank you!

Thank you!
For the multiple client handling, I think simply starting from the string end and adding any contiguous string containing ':' should work well enough.


Germany analysis - weird infected cases and predictions

Summary
For Germany, the infected cases as parsed from the dataset are for some reason totally wrong and thus the predictions are way off. The code I run is:
Codes and outputs:
   deu_scenario = cs.Scenario(jhu_data, pop_data, "Germany")
   deu_scenario.records().tail()
   _ = deu_scenario.trend()
   deu_scenario.summary()

   deu_scenario.estimate(cs.SIRF)
   deu_scenario.summary()
   _ = deu_scenario.history_rate()
   deu_scenario.clear()
   deu_scenario.add(days=7)
   deu_pred = deu_scenario.simulate() -> observe deu_pred

[UPDATE 27Oct20]:
Scenario.trends() does not work at all for Germany, see runtime error at #282.

Environment

CovsirPhy version: 2.9.1
Python version; 3.8
Installation: Anaconda, Spyder, pip
OS: Windows

After fix the runtime error in #284, I ran the codes in https://github.com/lisphilar/covid19-sir/blob/master/example/scenario_analysis_deu.py
Note in trend analysis:

In the last phase, Susceptible is sharply decreasing while Recovered is increasing slightly. Scenario.trend() did not detected the change point inside the last phase.
Scenario.trend() has min_size argument (default: 7) and Scenario.trend(min_size=5) detected the internal change point in the phase. min_size is the minimam size of phases.

Note in parameter estimation:
Then, a part of the summary was as follows (when min_size=7).

Please try to prolong the time limit with Scenario.estimate(cs.SIRF, timeout=120) etc.
We need to document the arguments outside the API reference and improve CovsirPhy. Scenario.estimate(cs.SIRF, timeout=120)depends onEstimator` class in
https://github.com/lisphilar/covid19-sir/blob/master/covsirphy/simulation/estimator.py

So, for Germany, the trends analysis did not detect the change point inside the last phase. During that, you say min_size was at the default value of 7. But if you changed that to a smaller value, 5, then that change point was detected? How did that happen? I would guess that the opposite should happen, i.e. the 5 default should fail while the greater value of 7 would detect it. Because that means we separate the analysis into more phases, right? Perhaps you meant default 5 and you changed it to 7 and worked?
But isn't this value something that the trends class should automatically optimize?

During that, you say min_size was at the default value of 7. But if you changed that to a smaller value, 5, then that change point was detected? How did that happen? What does min_size value mean, how is this used?

min_size is the minimam size of a phase as I mentioned. ChangeFinder.run() splits the series of dates with ruptures package (discussed in #3 ) and combines short phases where the length is smaller than min_size.
When created S-R trend analysis, I set the default value as 7 to avoid over-fitting (data of the number of cases has noize) and cut total runtime of paramerter estimation. As long as the value is over 2, we can change the default value for our analysis.

But isn't this value something that the trends class should automatically optimize?

Yes it should do, but how will the class do? This means we need to create an algorithm to keep good balance of accuracy, over-fitting and runtime.

So, what we have to do to solve all these issues, is to find the root cause at the Estimator's class and improve it? I think that the cause is linked directly with the other bug of #282 issue for the trends/ChangeFinder class, because how effectively the trends analysis is done affects directly the estimator. What is the call tree for the estimator?

This will be discussed in #291

Maybe you should pin 274 and 282? I think currently these are critical bugs that need to be solved immediately. Or create one or two more general open issues with the specific details of the bugs and the reworks need to be done. One regarding the Estimator class for the parameters estimation's RMSLE scores and one regarding the trends analysis with the ChangeFinder class and the trends' RMSLE scores.

We will use #274 and #291 with high-priority.

Note:
This is not for the issue you reported in the first comment of this issue page, but weired number of recovered cases leads failures of S-R trend analysis.
We should solve the issues regading weired data in some countries, including Greece.

With version 2.10.0-mu, the output is
https://gist.github.com/lisphilar/47cb6e26a1fa3ee488aa6acbb1a4fb41#file-germany_14nov2020-ipynb
This issue is onging for Germany.

The simulated cases for Germany are quite accurate for the previous days. Nevertheless, the curves seem to be problematic. As I notice, the source data are weird. Specifically, the infected cases are very weird. Until mid-October they are not even 100 !??
I don't know how we can handle with something like this or if we should handle it at all.
But what we can handle though is the following:
I noticed that for Germany (I don't know if this happens for other countries as well), the records begin from January 3rd! This is impossible, considering that the first cases appeared in China on January 22! We must put a lower limit for the first cases date and use China's. Or a more advanced method would sum all the cases prior to that lower limit date and use the sum as the first cases record.

Can we close this issue with the latest development version and #339 so that we can release stable version 2.13.0?

Yes we can close this issue now.


vm.$el.querySelector is not a function

logs
INFO LOG: 'Download the Vue Devtools extension for a better development experience:
https://github.com/vuejs/vue-devtools'
ERROR LOG: '[Vue warn]: Error in render function: "TypeError: Cannot read property 'getters' of undefined"

(found in <Root>)'
ERROR LOG: TypeError{}
ERROR LOG: '[Vue warn]: Error in mounted hook: "TypeError: Cannot read property 'dispatch' of undefined"

(found in <Root>)'
ERROR LOG: TypeError{}

  testBox.vue
    ✗ should render correct contents
	TypeError: vm.$el.querySelector is not a function
	    at Context.<anonymous> (webpack:///test/unit/specs/testBox.spec.js:8:31 <- index.js:174106:30)

Chrome 60.0.3112 (Mac OS X 10.12.5): Executed 1 of 1 (1 FAILED) ERROR (0.629 secs / 0.012 secs)

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>unit: `cross-env BABEL_ENV=test karma start test/unit/karma.conf.js --single-run`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>unit script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      /Users/.npm/_logs/2017-08-11T06_31_21_799Z-debug.log

and the desc file
import Vue from 'vue'
import chartBox from '@/components/testBox'

describe('testBox.vue', () => {
  it('should render correct contents', () => {
    const Constructor = Vue.extend(testBox);
    const vm = new Constructor().$mount();
    const topListItem = vm.$el.querySelector('.col-lg-25')
    expect(topListItem.length)
      .to.equal(7);
  })
})

Thanks!

求问你一下 你是怎么解决这个问题的

同上，你需要先实例一个vue对象 @fjy5314

close

@LinusBorg but this is what the example the webpack template comes with? Would be nice if you'd be able to give a better explanation than that.

@Kunigaikstis ouy are right, I was mistaken in this. Thanks for double-checking me
The real issue is simply that appearantly his component fails to render because it tries to call this.$store.dispatch(), but this.$store is undefined - as is expected if you render a component on its own without a store.
I can only advise to check out how we do it in the vue-test-utils (currently in beta):
https://vue-test-utils.vuejs.org/en/guides/using-with-vuex.html


Javascript error: "invalid group specifier name"

Description
Smith is throwing a javascript error – Invalid regular expression: invalid group specifier name which is causing a jquery TypeError: undefined is not an object (evaluating 'new Craft.Smith.Init'). This is causing the matrix blocks to not finish rendering and the inability to add new blocks.
Steps to reproduce

Open an edit or new Entry page containing a matrix blocks field.

Additional info

Plugin version: 1.1.4
Craft version: <IP_ADDRESS>

Looks like this is an issue in Safari? Should be fixed in 1.1.5

I can't believe I didn't test in other browsers! Thanks for catching that. 🍻

All good, I honestly was about to send a response back saying I couldn't reproduce as I tried all other browsers except Safari. Seems like that was the only one with the issue 👍


Namespace tests

The "conf files" change LGTM

This PR is so badly broken and large I'm inclined to just close it.

@reid-spencer this PR is no longer 'badly broken'. It is working locally, but it uses ASimpleTestCommand which I didn't realize was in the test folder of commands subproject, and so not picked up on when not running locally. It depends on test/resources/META_INF so I am not sure about what to do from here on.


Allow querify to take a lone slice argument.

querify helps build URL queries by passing an even number of arguments which are interpreted a set of key/value pair à la dict.
Currently
It is not possible to dynamically generate a set of key/value pair to be passed to querify.
Proposal.
Enable the function to take a lone slice of strings argument which would be treated the same way the current string arguments are.

Note to however implementing this that it cannot be a Go map (not ordered). I suspect improving the slice vs vararg situation discussed elsewhere may help.

I edited the issue. I'M mostly thinking about maps created with dict and merge etc... so we would lose order. I don't see it as a problem in most cases but it might be.

Can I work on this issue?

@importhuman, absolutely.  If you have any questions, let us know.

Is this sufficient to keep my local repository and branches updated and avoid conflicts later, or is there a better protocol?
git fetch upstream
git rebase upstream/master

@importhuman, invest a few minutes into reading the Contributing Guide.  It should help you get started.  It sounds like the Fetching the Sources From GitHub section would be of particular interest.

are GitHub issues better for asking questions, or Discourse?

It depends on how many questions you have 😃, but I'd recommend the dev channel in the forums.  GitHub issue fatigue is real.  We don't need any more noise here than we already have.

@moorereason I unintentionally updated mage in my branch, which changed the go.mod & go.sum files. Should I commit only the relevant code changes or these files as well? And do we have to do the building hugo steps after committing our changes, or is it meant for installing Hugo?


Add commonmark-extension package type

We encourage third-party extensions to use this type to make them more easily findable on Packagist: https://packagist.org/packages/league/commonmark?type=commonmark-extension
(Great work on the extension BTW, I might have to use this myself sometime!)

Thanks!


What Should Be an IoT Device (or Shouldn't)?

Quite literally, what should or shouldn't be IoT enabled?

To start:
I think that while everything can be IoT enabled, where the rubber meets the road is where that enablement is useful, to more than just a small degree. For example, with a situation like my "smart fridge" example, what use does that connectivity gain me as an owner/user?
If that "smart fridge" does all the normal fridge functions and none of the "smart"/IoT functions help me in any measurable capacity in my day-to-day life, then all it amounts to is a metric-collecting new-fangled ice box. Conversely, in the world of the 'API economy', if that data service is provisioned well enough that virtually any integration service can connect to it, especially one user-facing like IFTTT, Microsoft Flow, or others, then that has not only the intended, added feature set by the designers/developers of the smart product, but is fully relevant in ways that only the user/customer can/will see.


Chef test vms in parallel in automated_install.sh

Currently, in tests/automated_install.sh lines 79-82, there is a for loop which chefs (cluster-assign-roles) each Hadoop vm serially. This does not setup the services on the vms correctly.
Replace the for loop with a single cluster-assign-roles statement without specifying a VM.
This is supposed to set /etc/hosts correctly on all the nodes without having to chef them in a particular order.

Fixed in #94


Access denied with conf.yaml having allowed IPs

First, thanks for this package alongside Ibind. I'm trying to setup a docker compose which runs Ibeam as a service alongside Ibind.
Describe the bug
I have the following docker compose
services:
  ibeam:
    image: voyz/ibeam
    container_name: ibeam
    ports:
      - "5001:5000"
    networks:
      - my-network
    restart: 'no'
    environment:
      - IBEAM_ACCOUNT=${IBEAM_ACCOUNT}
      - IBEAM_PASSWORD=${IBEAM_PASSWORD}
      - IBEAM_INPUTS_DIR=/srv/inputs
    volumes:
      - type: "bind"
        source: "inputs"
        target: "/srv/inputs"
        read_only: true

  deployment:
    build: .
    container_name: deployment
    networks:
      - my-network
    depends_on:
      - ibeam

networks:
  my-network:
    driver: bridge

When I run this my laptop can access ibeam as expected on port 5001 (5000 is in use on macs), but the deployment service cannot, it gets Access Denied issues.
I've read through all the relevant documentation I can find, I've got my conf.yaml setup ibeam       | 2024-07-17 14:32:43,055|I| Custom conf.yaml found and will be used by the Gateway and in this I have setup an allow list
ips:
  allow:
    - 192.*
    - 131.216.*
    - <IP_ADDRESS>
    - <IP_ADDRESS>
    - 172.17.0.*
    - <IP_ADDRESS>
    - 172.17.0.*
    - MY.IP.ADDRESS
  deny:
    - 212.90.324.10

Environment
IBeam version:0.5.1(latest) and 0.5.4
Docker image or standalone: Docker image
Python version (standalone users only):
OS: MacOS
Suggest a Fix
I'm really not sure given from my laptop
import requests
url = "https://localhost:5001/demo#"
response = requests.get(url,verify=False)
print(response.text)

Looks correct but I get this from the deployment services' shell
>>> import requests
>>>
>>> url = "https://ibeam:5000/demo#"
>>> response = requests.get(url,verify=False)
/usr/local/lib/python3.12/site-packages/urllib3/connectionpool.py:1099: InsecureRequestWarning: Unverified HTTPS request is being made to host 'ibeam'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#tls-warnings
  warnings.warn(
>>> print(response.text)
Access Denied

Getting the Access Denied error demonstrates that the request is getting through to ibeam as if the networks aren't configured correctly I get connection issues errors, for example when I have  tried having the network setup as network_mode: "bridge" I find both
url = "https://localhost:5000/demo#"
url = "https://ibeam:5000/demo#"

give this error suggesting the network isn't setup correctly
requests.exceptions.ConnectionError: HTTPSConnectionPool(host='ibeam', port=5000): Max retries exceeded with url: /demo (Caused by NameResolutionError("<urllib3.connection.HTTPSConnection object at 0xffff814a1e50>: Failed to resolve 'ibeam' ([Errno -2] Name or service not known)"))

Hey @this-josh thanks for the kind words and for describing your issue in detail 👍
I briefly remember that when running IBeam image through docker-compose you need to figure out what is the internal IP address given to the container in your Docker network. There is a few of these already added:
- 172.17.0.*

But it's possible that your differs.  See if doing this helps:
https://stackoverflow.com/questions/17157721/how-to-get-a-docker-containers-ip-address-from-the-host

@Voyz Thank you!
It turns out I sometimes use 172.23.0.*, adding this to my conf.yaml worked

Note it does seem to change if a new network is created

Ahh happy to hear you've figured it out 👍
Yes, indeed it seems to change for me too, thanks for sharing that observation.


Separate GCIntranet from GC Web

Moved from GCCode: https://gccode.ssc-spc.gc.ca/iitb-dgiit/nw-ws/sgdc-cdts/issues/91
@nicolasraymond created this issue
Also fix the footer who looks horrible.

@shawnthompson commented:
thanks for the details!
https://ssl-templates.services.gc.ca/app/cls/WET/gcintranet/v4_0_30/cdts/appTop/appfooter_footersections_esdc-en.shtml

@nicolasraymond commented:
didn't want you to bleed from the eyes

@MaximMartel Could you confirm this issue is still valid for version 4.0.39 ? Thanks.


Add native test

We removed the Graal native test from our gitlab suite as it required a custom test runner.
We will move it in to here

I assume this is closed via https://github.com/micronaut-projects/micronaut-mqtt/pull/232


Games with an official EAC testing branch on SteamDB

You've may have seen that some games are marked as Confirmed or Supported, without any external information on it. While I thought Valve might be quicker on this, so I wouldn't have to explain this myself, but it seems they are taking longer than usual to speak on it. Currently a few games have been picked up on SteamDB with either EAC or SteamDeck testing branches. Some of these even have native libraries on Linux for Easy Anti-Cheat. At the moment, we are taking these as actual confirmations to getting proper anti-cheat support until proven otherwise.
The current game list:
Battlefield 2042 - *1* - *2*
SMITE - *1*
Fall Guys: Ultimate Knockout - *1*
--Hell Let Loose *1* no longer available, branch deleted
Blazing Sails - *1*
STAR WARS™: Squadrons - *1*
If anyone finds more games on SteamDB, with native Linux libraries for Easy Anti-Cheat, please list them with the proper depot so I can add them!

I really cant see any linux files or steam deck test branches in your Fall Guys link.
In Battlefield 2042 EACC might actually mean (Electronic Arts Compliance & Certification) because I have seen that word on older EA titles.

Couldn't we add a fourth status. Something around the lines of "suspected" which clearly differentiates from officially confirmed sources. I could possibly create a PR to implement this

@AltF02 I don't think it's necessary. I'm still committed to trying and keep the list as straightforward as possible. Just didn't think it would take extra time for Valve or any of these companies to officially commit to adding support after adding native Linux libraries to their games.
Right now it's just a waiting game and I don't think it's going to take much longer from Valve on their end.

I really cant see any linux files or steam deck test branches in your Fall Guys link.

Same with Battlefield 2042.

Apex Legends has steam_deck branch created 2 hours ago.
https://steamdb.info/app/1172470/depots/?branch=steam_deck

POLYGON has a public test branch (which is public)

I don't think it makes sense to say support is confirmed purely based on that there is a branch on SteamDB. They could be testing it without being set on releasing it. It is very misleading to call something confirmed on this basis, and only serves to create false hope and reduces the trustworthiness of the website.

@Newbytee So far all of them merged the test branch to the public branch so I dont see it as misleading.

the public branch Patchnote 8231787 of Fall Guys from 9 days ago has the EAC linux file included but it seems like it hasn't been enabled yet for some reason who knows if it will be enabled later on

Warhammer: Vermintide 2 has a Steam Deck branch (with EAC linux files also included in the standard release but inactive):
https://steamdb.info/app/552500/depots/?branch=steam_deck_testing


Verify if the URL input is empty

Don't allow sending an empty URL

Pr: https://github.com/vit0rr/crud-react/pull/14

I like to work on this, will it be ok?

What did you think to solve this? Currently, I'm using a URL object to verify


Design the command-line UI

Should have useful help text, probably pointing to the checklist
Needs: to have an idea what capabilities and configurations the app has

Needs: to have an idea what capabilities and configurations the app has

You mean which capabilities and configurations the linter has, or the code being linted?

For command-line help, run $ openlinter --help or $ python3 path/to/openlinter.py --help.


Open menu to active page

Is it possible to retain the menu state when opening the menu again after navigating to a page?

init function, but how to open tree?


The 'Python Debugger' extension is not available in VSCodium for Linux ARM 64

I'm running VSCodium on Linux on Apple Silicon, thus the aarch64 CPU architecture. It is complaining about "type": "python" in my launch.json and that I have to replace it with debugpy before it's being deprecated. That type seems to be provided by this extension but I can't actually install it due to the error in the title.
This extension is pure Typescript, is there any reason at all it wouldn't work on Linux ARM machines?

Thanks for your bug report, I am going to investigate what is happening.

Drive-by comment (I have a similar, but different problem): It looks like the Python Debugger extension is actually platform-specific since https://github.com/microsoft/vscode-python-debugger/pull/89 (it includes Python wheels?).
That alone doesn't explain your problem, I guess, since aarch64 seems to be included in https://github.com/microsoft/vscode-python-debugger/blob/7b2177d3a0dc8211891d6d6dccfce02317476c73/build/azure-pipeline.stable.yml#L40-L42.

Hey there 👋,
I believe this to be a problem on our end, since I assume you're using https://open-vsx.org as the extension marketplace. We are in the process of adding the linux arm platform in https://github.com/open-vsx/publish-extensions/pull/756 for the extension, but I need to figure out how to tweak the build pipeline to install the correct platform-specific dependencies :).
Feel free to track that PR or https://github.com/open-vsx/publish-extensions/issues/755 for updates.

Oh, I didn't realize it was basically a packaging problem. I'm using whatever comes with VSCodium, and I believe indeed that is https://open-vsx.org. Thanks for finding this issue, I'll close this and wait for the update to appear!
@imphil you're listing the arm64 package for macOS, but I'm actually running on Linux.


Search all possible components I can deploy

As a developer, I want to be able to list/search all possible components I can use with my application
$ ocd catalog search [postgres] [--type=database|java|whatever]
The following items were found:
(postgresql) PostgreSQL
(postgresql-10.0) PostgreSQL-10.0
(crunchydb) CrunchyDB Clustered (PostgreSQL 9.5)

Search has to be able to filter. (Possibly create another issue for this).
Subtask for #154

related to #54

I'll start looking into how the Service Catalog API can help us with this

@jorgemoralespou so I just tried on OpenShift versions v3.7.1 and up on minishift, but service catalog is not running by default, unless started otherwise using minishift start --service-catalog.
Since this is not the default behavior, imo it's not safe to only rely on the service catalog API to provide us the template names which the user can use in ocdev component <type>.
We also need to list the imagestreams in openshift namespace, in addition to templates being provided by the service catalog.
I think there are 2 ways we can do this,

pause service catalog for now
concatenate output of oc get is -n openshift and oc get template -n openshift and search through this

Or,

assume that the service broker is enabled on the cluster (not the default behavior), and get templates from service catalag
concatenate that output with oc get is -n openshift

WDYT?

@containscafeine why do you want to list all ImageStreams in the openshfit namespace (oc get is -n openshift)?

@marekjelen @gshipley, any opinion on this?
@sspeiche is the catalog not going to be enabled by default? I thought we agreed to have it by default already.

why do you want to list all ImageStreams in the openshfit namespace (oc get is -n openshift)?

How do we get the builder images that we currently support with ocdev?

How do we get the builder images that we currently support with ocdev?

you have to add an additional filter to it, you will get more than just s2i builder images if you list all is in openshift namespace.

@jorgemoralespou in general I think we should target service catalog, it's default in Ansible installer anyway ... the question is - in case it's not gonna be default in oc cluster up / minishift - is the audience that will be using these two methods big enough to validate not using the nice stuff provided by the service catalog or would it better to ask for the switch during startup?
Just a spontaneous idea - should od have something like od start that would download minishift and would start ti with the correct switches? Yes, it's another layer of abstraction, but would simplify the setup for the user by hiding another dependency.

will start once #241 is merged

The service-catalog is not on by default. It is unclear when it will be. The direction is looking like more and more things will be enabled, like via concepts like alm in tectonic, though not 100% if catalog fits in as something that gets.
Having said that, I believe that in the next 3 months most hosted clusters would have it enabled. So for this effort, it would be good if ocdev could probe to the cluster to see if enabled and proceed accordingly

ocdev as a tool for developers should be meant for clusters with the catalog enabled, where you can just use/deploy technology on a self service manner as a developer.
I would maybe then:

a) have that as pre-requisite
b) delay to a posterior face where we want create an API on OpenShift that gives you the information independent of the catalog (but I guess we'll be on the same spot)
c) make the client intelligent on the capabilities of the cluster and use the appropriate apis when needed.

I guess a) for now and c) in the future


Broken data for deep learning example on image tiles

I tried following the deep learning example on image tiles and got a bit stuck on the data preparation step.
When I download the xenium and visium files directly as zips, the assertion is thrown that celltype_major is not in xenium_sdata.table.obs and I should try to use the linked notebook to prepare the data. However, the notebook link is broken but I found the 00_xenium_and_visium notebook instead. That notebook also ran into some errors (see #36, #39) during execution on my machine and seemed to do a lot more than just prepare the data for the deep learning example.
Long story short, would it be possible to remove the mention of the notebook in the deep learning example and get updated xenium and visium zip files that have the celltype_major metadata? This would make the tutorial way more accessible.

Hi thanks for the feedback and for pointing out to the broken link. I will modify the notebook linking to new data to make it more accessible.
For the time being, please download the data from here. The downloaded data contains every annotation, metadata, coordinate transformation, etc except for the pure raster data. But if you copy the raster data (folders xenium_rep1/images/morphology_mip/0, xenium_rep1/images/morphology_mip/1, ..., and same for the Visium data), it should work.
Please let me know if you run into problems and I will upload the full data.
As a final note, @giovp improved the data loaders in this PR, which will be merged soon, so please notice that the APIs will slightly change and the notebook will be updated.

It got fixed now 😊


Installation issue

Hi,
After installation, all steps according to manual, I'm getting this kind of errors:
2017-07-25 09:14:27,527 [art-init] [INFO ] (o.a.a.p.GroovyRunnerImpl:244) - Loading script from 'blackDuckScanForHub.groovy'.
2017-07-25 09:14:28,484 [art-init] [ERROR] (o.a.a.p.GroovyRunnerImpl:300) - Error loading script from '/data01/POC/atlassian/artifactory/etc/plugins/blackDuckScanForHub.groovy'.
org.codehaus.groovy.control.MultipleCompilationErrorsException: startup failed:
file:/data01/POC/atlassian/artifactory/etc/plugins/blackDuckScanForHub.groovy: 38: unable to resolve class com.blackducksoftware.integration.hub.builder.HubScanConfigBuilder
@ line 38, column 1.
import com.blackducksoftware.integration.hub.builder.HubScanConfigBuilder
Is anything else I should do to make it works?
This issue is true only for Artifactory.v5.4.5 and plugin.v3.0.0, version 5.4.4 works corectly.

@Flybro  did you perform a clean install of the script and libraries?  Please verify that all files belonging to the plugin are present.

Yes, I did clean installation. As I said before, there is no issue with version 5.4.4 only 5.4.5 and for both of them installation steps were exactly the same.

OK, we will try to replicate the error then - seems very unusual.

Hi @Flybro,
I'm sorry for the delay.
I was unable to reproduce your error with a fresh installation of Artifactory Pro 5.4.5 and version 3.0.0 of the plugin. Additionally I tried with the latest version of Artifactory Pro (5.4.6) and had no issues, so we should be able to support all versions of Artifactory Pro higher than version 4.14.0
What are the contents of your $ARTIFACTORY_HOME/etc/plugins/ directory?

Closing this issue since it seems it has gone stale. If you're still experiencing this problem, please open a new ticket!


Update index.js

Adding the .ping to module.exports in line 146 fixes a TypeError that occurs when trying to use the function from a different file.

What type of error are you receiving? There shouldn't be a need to export the same function as a property when the export is already the function. This also creates a circular object structure.

Using the same implementation as in the README, I am receiving this error: "TypeError: ping is not a function". I also thought that there shouldn't be a need to export ping again but doing so resolved this error.

Sorry, I seemed to have missed something in my code. My editor automatically added some brackets around the word ping in "const ping = require('minecraft-server-util');", which caused the TypeError. Sorry about this.


Support prefix-based redirects.

Gatsby doesn't provide a way to configure this, but I think it might be
reasonable to add plugin-specific redirect metadata (there's a cryptic
"rest" field documented in the API docs for createRedirect).
Using a simple boolean seems most straightforward given AWS's
limitations.
Is this crazy? Feedback much appreciated. Happy to look more
closely at testing etc. if this is considered a reasonable approach.

Do you have a use case for this? Would that use case be covered by #62, or perhaps by a config value that allows for defining custom rewrite rules?
I'm not ecstatic about extending GatsbyRedirect with something so AWS specific. Tell us a use case and then we'll see what Jari thinks.

@JoshuaWalsh, thanks for taking a look.
In my case, I have a single Gatsby site deployed to an AWS bucket.
All redirects are managed in a headless CMS, then we call createRedirect in Gatsby, then gatsby-plugin-s3 deploys them.
We have a business requirement to redirect large site areas based on a prefix, so (in Netlify syntax) from /old/* to /new/:splat. We also want it to work for external redirects (in some cases we redirect old content to a separate archive site on a different domain).
I'd like to keep all redirects in the CMS, so they are visible to our CMS users. I'd also much prefer gatsby-plugin-s3 to completely own the S3 bucket rather than maintain redirect settings separately on the bucket and merge. Ideally, the information flow for prefixed redirects would be as similar as possible to regular redirects.
I think redirects are a somewhat plugin-specific (and messy!) area of Gatsby. For example, statusCode and force are documented in Gatsby and the Netlify plugin (https://www.gatsbyjs.org/packages/gatsby-plugin-netlify/)[documented in the Netlify plugin] as "Plugin-specific".
The Netlify plugin docs also show a Language field being used, which I think they use to redirect based on the header of the same name (not really explained properly in their plugin). If I was using Netlify, I think the redirects I need could be achieved using the :splat syntax via createRedirect. They wouldn't work in the browser though (Gatsby uses a simple from->to lookup there).
This discussion is interesting: https://github.com/gatsbyjs/gatsby/issues/11056. I can see how a difference between client-side and server-side redirect capability could cause issues. For me, because of how the CMS is used, I know there will never be on-site links to old URLs, so server-side only handling of those is fine.
One alternative to the prefix field would be to support only a trailing wildcard and :splat, and maybe a plugin config flag to turn on this processing. I felt that a separate prefix?: boolean field was a bit more honest about AWS's restricted capabilities here, but compatibility with a subset of the Netlify syntax might have value.
Another might be the ability to provide the plugin with AWS format redirects (perhaps via a file) and have it merge the lists before applying the config to the bucket. This would be a bit of a shame, as my code would have to know about the details of the messier AWS API to generate them.
Thanks again for engaging with this.

I agree that redirects are often plugin-specific and messy. I was hoping to avoid contributing to that mess, but your use case seems solid to me.
Looking at your code it seems like a clean way to do it. I can see you believe strongly in DRY. The only real complaint I have is the name maybeNonBucketLevelRedirects, but I'm struggling to think of a better name. possibleObjectBasedRedirects? objectEligibleRedirects?
If I'm nitpicking, your use of identity is perhaps a bit too clever for my liking, I don't really like that trailingSlashTransform will sometimes be a no-op. I'm wondering if there's a more clear way to achieve the same result. (But I'm glad you included this way, because until now I wasn't familiar with the concept of identity functions and now I know that JoshuaWalsh/ts-demand totally reinvents the wheel.)
@jariz What are your thoughts on this? Do you think this feature is justified?

Hi @microbit-matt-hillsdon, we now have a bucketPrefix option, does this fix your problems or...?
I'm still kind of struggling to understand this feature on first glance.

I was looking for a way to generate server redirections that "rewrite" the URLs like /old/* -> /new/*. I tried this PR, and it seems that it fit my needs.
@jariz I'm starting to use Gatsby so I certainly miss something, but how bucketPrefix could help me with redirections?


make the cursor blink in the wpf control

Summary of the Pull Request
Adds a blinking cursor to the WPF terminal control
Validation Steps Performed
VS terminal was patched with new bits to verify cursor only blinked when it had keyboard focus.

I don't expect there's an answer to this that helps y'all ship sooner, but is there an architectural improvement we could take on that would make it so you don't need a p/invoke down into C++ just to tell the cursor to blink? 😄
(request changes is for the method names alone.)

Registration-free COM might work, but I'm not an expert on how to set that up. We at least need some of the blink handling happening in the managed code since that has access to the dispatcher timer.


Design pattern

Patterning, taking into consideration the installation base.

Do you mean that the main directory structure isn't normally at the same root directory as the git repository? Why would they be different?

Usually with Wordpress or other systems put /store.
But even if put in the root, this change will standardize with other files and folders ignored.
I as a basis for this study http://git-scm.com/book/en/v2/Git-Basics-Recording-Changes-to-the-Repository

I still don't understand why you would want to make the git directory different to the project directory. Since these files have common verbs as their names, I think they might accidentally target other files if we remove the /. Unless I'm missing something it seems the more common way to use this works with the template as it currently stands.


Allow disabling the modal transition animation

I use Wallaby for feature tests. Despite using find, the animation still makes the test brittle for some reason. Disabling the animation resolves it.

@mplatts

Thanks - maybe add a test in modal_test.ex that checks for animation classes? also doc: "enable modal transition animation" could explain your use case:
doc: "enable modal transition animation. For Wallaby E2E tests this is best disabled"

@mplatts Completly forgot about this PR here... Updated!

Sorry I've been too slow to merge. Some new conflicts :(

Hi @fredwu if you're interested in refreshing this PR I can merge it!

Actually, I think this is resolved in a more generic way in https://github.com/petalframework/petal_components/pull/347. So I might close this for now


Mistake in gf_poly_test.go?

Apologies in advance if I have misread your code. I was looking at test case #3 for TestGFPolyRemainder with
numerator = gfPoly{[]gfElement{1}},
denominator = gfPoly{[]gfElement{1, 0}}
remainder = gfPoly{[]gfElement{1}}

where coefficients are of the form a0 + a1 x + a2 x^2 + a3 x^3...
I read this test case as 1 mod (1 + 0 * x) = 1 mod 1 = 0 != 1
Did you mean to write remainder = gfPoly{[]gfElement{0}}?

Hello :)
I think you're correct. The gfPolyRemainder() code expects the []gfElement{}s to be specified in our "normalised" form, that is, the highest coefficient of x should be 1, not 0. This allows for easy determining of the degree of the polynomial. The test violates this assumption, and also has the wrong answer.
I've fixed this in f7f7eae5c66797549ecc55be0144bf46bccdfc92 .The qrcode library should be only using normalised form anyway. I'll have a look around to see if any other similar cases need fixing.
thanks!


Is This Add-on Supported in Azure Government

I have a customer who is reporting that Audit Logs and Sign in Logs are not working for this Add On. The error present in Azure AD is AADSTS7000215 which points to the Client Secret being the issue. In working with the customer, we updated the Client Secret Value as per the App Registration in Azure AD and we are still seeing failures.
Is this expected because it is Azure Government and not Azure Commercial?

Hello. Can you please assist with answering the supportability of this Add-on in Azure Government and if there are any known issues at this time.
Thank you in Advance

We were able to identify some issues with this in Gov.
Please Close


Error when running the new version

I get two of these messages in the Gym+CoreDataClass.m file
iPokeGo-master-3/iPokeGo/Gym+CoreDataClass.m:34:23: Implicit conversion loses integer precision: 'NSInteger' (aka 'long') to 'int32_t' (aka 'int')
and this message in the Pokemon+CoreDataClass.m
iPokeGo-master-3/iPokeGo/Pokemon+CoreDataClass.m:21:27: Implicit conversion loses integer precision: 'long _Nullable' to 'int32_t' (aka 'int')

These are not errors but warnings. Do not pay attention :)

Ok :p

@istornz Just curious, what do those warnings mean and will the go away in the future? :)


Typo in Unit1-Module3 reading

Talked and confirmed with Lyndon on 09/13 that there is a minor typo in 4.3.3.
Both #.3 and #.4 should be columns. See attachment.

Great catch @wqtclaire thanks!


Improve MappingEvaluator

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (b4d4874) to head (325f696).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #316   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          100       100
  Lines         2413      2416    +3
  Branches       212       209    -3
=========================================
+ Hits          2413      2416    +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Possible addition of version for later (>= 18) Ubuntu aarch64 distributions?

Just ran across this utility, absolutely fantastic.  Thank you very much.  I have Ubuntu aarch64 servers running various (16 LTS, 18 LTS & 20 LTS) distributions.  Your utility is in the distribution package for 16, but not the others.  Would like to put a vote in for it to be added.  Thanks again.
P.S., I note it is in the 18.. x86_64 distribution.

Thanks for the kind words! I don't control the Ubuntu packaging; if you want to request that they package it for new versions or architectures, I believe you'll need to open a bug in the Ubuntu bug trackers.


How does the training step work with multiple optimizers?

What is your question?
How does the training_step work exactly when there are multiple optimizers? I suppose that the optimizers update the corresponding networks one after another by converting the network associated with the other optimizer to eval mode and keeping the network associated with the current optimizer in training mode. Is this correct? If yes, how do we train networks where the loss function for each optimizer depends on both the network outputs.
How do I get this to work in PyTorch-Lightning:
for batch in dataloader:
    x,y = batch
    output1 = self.net1(x,self.net2(x))
    output2 = self.net2(x,self.net1(x))

    loss_net1 = some_loss_function(output1)
    loss_net2 = other_loss_function(output2)

    optimizer1.zero_grad()
    # want the loss to backprop through even net2
    loss_net1.backward(retain_graph=True)
    optimizer1.step()

    optimizer2.zero_grad()
    loss_net2.backward()
    optimizer2.step()

@nsidn98 Did you try this from PL examples?
https://colab.research.google.com/drive/1F_RNcHzTfFuQf-LeKvSlud6x7jXYkG31#scrollTo=TyYOdg8g77P0
This is for a GAN, but as you need it used 2 optimizers.

Yes, I used that example as a model for my code. But I think that net2() doesn't work in training mode when optimizer1 is getting updated and hence I am getting an error of RuntimeError: element 0 of tensors does not require grad and does not have a grad_fn for the output obtained from net2().

Can you share the code ?

You can find the code here. Pardon me for putting all the code in one file. This was supposed to be a part of a bigger code base with imports from different files. This code runs independently. The main intention is to run RL algorithms and hence I am trying the different functionalities of Lightning on RL algorithms.

@nsidn98 I haven't worked that much with RL algorithms, but nevertheless, I tried something.
I changed Line 392 and the code ran.
I changed this:
self.value_loss = nn.MSELoss()(value, expected_value.detach())

to
self.value_loss = nn.MSELoss()(value.requires_grad_(True), expected_value.detach())

Let me know if this is working like it is supposed to.

The code does seem to work now but the algorithm is not converging. I think there is a problem in some other part of the code. Closing the issue.


[ingress-perf]: Rename default configuration file

Type of change

[ ] Refactor
[ ] New feature
[ ] Bug fix
[x] Optimization
[ ] Documentation Update

Description
This PR renames the default configuration file
Related Tickets & Documents

Related Issue #
Closes #

Checklist before requesting a review

[x] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.

Testing

Please describe the System Under Test.
Please provide detailed steps to perform tests related to this code change.
How were the fix/results from this change verified? Please provide relevant screenshots or results.

Make sure to update the airflow config as well @krishvoor
https://github.com/cloud-bulldozer/airflow-kubernetes/blob/master/dags/openshift_nightlies/config/benchmarks/data-plane-v2.json#L24

Make sure to update the airflow config as well @krishvoor https://github.com/cloud-bulldozer/airflow-kubernetes/blob/master/dags/openshift_nightlies/config/benchmarks/data-plane-v2.json#L24

Ack, airflow-kubernetes PR for review here:
https://github.com/cloud-bulldozer/airflow-kubernetes/pull/341


feat: add support MYSQL_TYPE_VARCHAR  to read MySQL

feat: add support MYSQL_TYPE_VARCHAR to read MySQL

Thanks @zzzdong , and sorry for the late reply.


launchctl: Add macOS support

macOS uses launchctl instead of systemctl, please consider adding support for that :)

I don't own a Mac and I never will.
Everything in sysz is systemd specific, so it won't make sense for launchctl. I think this would be better served by a different tool. Feel free to use this as inspiration.

@joehillen Is there a possibility of accepting PR for launchctl?
I'm in need of TUI daemon management tool and just found sysz. It looks great. The only problem is that I use both linux and macOS, and I don't want to introduce different tool for launchctl and systemctl.
It seems sysz is simple and I believe I can extend it with launchctl. If you feel okay, I'll try to add launchd support on sysz instead of just forking and rewriting all the systemctl commands to launchctl commands.


Brackets & Square Brackets with apple keyboard on M1 Platform not working

Godot version
4.0 alpha 4
System information
Monterey 12.2.1, M1 Pro Apple Silicon
Issue description
Option + 5 and Option + 6 should do [ ]
Option + 8 and Option + 9 should do { }
In Editor nothing appears.
Steps to reproduce
Try to type [] or {} in Godot Editor when editing a script
Minimal reproduction project
No response

Duplicate of https://github.com/godotengine/godot/issues/54303.


Just apply filters of the criteria builder to build the sync criteria

1. Why is this change necessary?
The criteria builder is used here to just parse the filters. But it also applies "defaults", like "set always an limit".
In this special case, we just need the parsed filter to be applied, otherwise the api-consumer tries to delete the association but the query is always executed with an limit.

Hey @OliverSkroblin, thx for your contribution!
Could you maybe add a small test case to the \Shopware\Tests\Unit\Core\Framework\Api\Sync\SyncServiceTest?

thanks for your contribution @OliverSkroblin 👍🎉💙


Error raised 'ProtocolException: Unexpected status line' after Media Player API(MediaHTTPService)

https://github.com/google/volley/issues/208
This is a issue I reported for Google/Volley before... But no conclusion at last... I tried both JieCaoV5 and JiaoZiV6, and no luck.

Beyond my ability

T_ T thx, and i will try to report this to AOSP issue track.


Kinesis Elasticsearch Sink: bump Kinesis Client Library to 1.6.1

This will also involve bumping Scalazon to 0.11 to avoid dependency problems.


New version: CitableCorpusAnalysis v0.7.0

Registering package: CitableCorpusAnalysis
Repository: https://github.com/neelsmith/CitableCorpusAnalysis.jl
Created by: @neelsmith
Version: v0.7.0
Commit: 097535a8b9428585b9fbdbb1778122ca2809fe21
Git reference: main
Description: Work with multiple models of a text corpus.
Release notes:

Add support for TopicModelsVB

@neelsmith please see the message above.  Once you fix the automerge issues you can register again the new revision without changing the version number and this pull request will be automatically updated.
[noblock]


Add CRD adoption hook

In order to install the PolicyException CRD from the policy-meta-operator app, we need to add some labels and annotations to it. Since KPO owned it, this would be the best place to do it.

I'm fine with this but I wonder how sure the upgrade path is. How likely is it that a cluster has the CRD already, but won't update KPO again prior to trying to install PolMO?
Would this logic work as a pre-install hook on PolMO?

How likely is it that a cluster has the CRD already, but won't update KPO again prior to trying to install PolMO?

All clusters will need to update KPO to make it work with policy-meta-operator. The CRD would exist in every cluster that already exists. We can make POLMO depend on KPO for now as a solution to avoid POLMO inconsistencies but I want to see how bad it breaks.

Would this logic work as a pre-install hook on PolMO?

I tried, but no, Helm will template the chart and identify that the CRD is already present before even running the hooks.


Preserve property descriptors in assoc and dissoc

Fixes #2383
This change adds an internal function _cloneWithDescriptors which creates a shallow object clone, preserving any existing property descriptors. It is used in assoc and dissoc so that property getters and setters are copied to the returned object.
Something that @CrossEye mentioned is that there may be a performance concern. I tested this in a JSPerf here, and found that this performs ~10x worse than before (~1M ops/sec as opposed to ~10M), which could be a reason to reject this change.
Also... I changed the test script to run tests in test/internal 😄

Obviously the performance changes are significant.  I see a 9X difference in Chrome and Brave and a 6X difference in Firefox with that test, all on Ubuntu 17.04
JSPerf was fighting me, and I never got to try my other version, which was to inline the _cloneWithDescriptors.  I doubt the function call contributed that much, but I wanted to see.  Perhaps I'll try later.
I think this would be great to have, but those perf changes scare me.  I'm hoping others will chime in here with their thoughts.

Anyone have thoughts on this?  @buzzdecafe, @kedashoe, @davidchambers, @paledpind, @TheLudd, @scott-christopher, @asaf-romano, @raine, @Bradcomp?

As far as I'm concerned these are the signatures:
assoc :: String -> a -> StrMap a -> StrMap a
dissoc :: String -> StrMap a -> StrMap a

String maps do not have getters and setters, so I think we should ignore these.
Historically Ramda has accommodated much more of JavaScript's complexity than I would like, so it may be that preserving getters and setters is more consistent with decisions we've made in the past.

String maps do not have getters and setters

By some definition/convention?  I think I'm going to come down against this based on the performance and on our disinterest in working with OO.  But I don't see that how the String property is created changes whether this is a StrMap.

String maps are just data. Getters and setters are for triggering actions (possibly side effects).

But how does the implementation of properties (even if they also add side effects) change the API of a StrMap?  For instance, if a StrMap has a commonly accessed, but time-consuming to calculate, derived property it's easy enough to imagine using setters and getters to control the properties upon which it depends.  That doesn't change the use of that object.
Maybe I should just quit here.  I agree with your conclusion.  Perhaps it doesn't matter that I disagree with your reasons.  :smile:

Closing as stale.  But leaving a label to remind us to come back to this later.  If we can solve the performance problems, something here or in #2383 might be worth pursuing.


Fix error with length of list of peaks

This PR addresses two errors that occur during featurization for a few files

Uses length of the list of peaks instead of default value to address an out of index error
Addresses an indexing error for the get_fractional_quantity_remaining_nx method

@BruisVanVlijmen2020 Could you take a look at these changes as soon as you get a chance? If you approve the PR we should be able to go ahead and fix the errors in some of those feature objects.

@BruisVanVlijmen2020 The method used will return upto max_nr_peak but it can always return fewer peaks (at least that's my understanding from the scipy documentation). So  max_nr_peak >= len(peak_dQdVs)
https://github.com/TRI-AMDD/beep/blob/8a37edea16bbda526b093bf29e52e861b683a496/beep/features/featurizer_helpers.py#L97
The test test_generate_dQdV_peak_fits has a file where only 3 peaks are returned from the peak fitting.


fix: Give better feedback validating the module name

This adds a distinction between a valid module name and a module name that has already been taken. It also clarifies what a valid module name is.
This addresses the confusion pointed in https://github.com/denoland/dotland/issues/2393.
https://user-images.githubusercontent.com/7757/218585985-e998b151-7f96-4046-a6b3-62bcc0a3aae1.mp4

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[lite] failed on  define=with_select_tf_ops=true

Please make sure that this is a bug. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code
’
cc_binary(
name = "Prophet.so",
srcs = ["minimal.h", "Prophet.cc",   ],
linkopts = tflite_linkopts() + select({
"//tensorflow:android": [
"-pie",  # Android 5.0 and later supports only PIE
"-lm",  # some builtin ops, e.g., tanh, need -lm
],
"//conditions:default": [],
}),
deps = [
"//tensorflow/lite:framework",
"//tensorflow/lite/delegates/flex:delegate", [ on | off]
"//tensorflow/lite/c:c_api_internal",
"//tensorflow/lite/kernels:builtin_ops",
"//tensorflow/lite:builtin_op_data",
"//tensorflow/lite/schema:schema_fbs",
],
linkshared = True,
)
OS Platform and Distribution (vmware Linux Ubuntu 18.04 x4 on window10x64):
TensorFlow installed from (source  ):github 20190817
TensorFlow version (): 1.14.0
Python version:3.7.4
Bazel version (if compiling from source):0.26
GCC/Compiler version (if compiling from source): 7.4 binary
CUDA/cuDNN version: cpu
GPU model and memory: cpu

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with: 1. TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)" 2. TF 2.0: `python -c
Describe the current behavior
Target //tensorflow/lite/examples/l17:Prophet.so failed to build
Describe the expected behavior
build successed
Code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate the problem.
bazel build --config monolithic --cxxopt=-std=c++11 -c opt
--crosstool_top=//external:android/crosstool
--host_crosstool_top=@bazel_tools//tools/cpp:toolchain
--define=with_select_tf_ops=true   --cpu=armeabi-v7a  --verbose_failures
//tensorflow/lite/examples/l17:Prophet.so
Other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.
bazel cmd log
`
ERROR: /root/tensorflow-master/tensorflow/core/kernels/BUILD:6576:1: C++ compilation of rule '//tensorflow/core/kernels:android_tensorflow_kernels' failed (Exit 254): clang failed: error executing command
(cd /root/.cache/bazel/bazel_root/510cb3499e6983b92a09020af9102ff3/execroot/org_tensorflow &&
exec env -
ANDROID_BUILD_TOOLS_VERSION=29.0.2
ANDROID_NDK_API_LEVEL=18
ANDROID_NDK_HOME=/root/vender/android-ndk-r17c
ANDROID_SDK_API_LEVEL=18
ANDROID_SDK_HOME=/root/vender/android-sdk
PATH='~/anaconda3/bin:/root/anaconda3/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin'
PWD=/proc/self/cwd
PYTHON_BIN_PATH=/root/anaconda3/bin/python
PYTHON_LIB_PATH=/root/anaconda3/lib/python3.7/site-packages
TF_CONFIGURE_IOS=0
external/androidndk/ndk/toolchains/llvm/prebuilt/linux-x86_64/bin/clang '-D__ANDROID_API_=18' -isystemexternal/androidndk/ndk/sysroot/usr/include/arm-linux-androideabi -target armv7-none-linux-androideabi '-march=armv7-a' '-mfloat-abi=softfp' '-mfpu=vfpv3-d16' -gcc-toolchain external/androidndk/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64 -fpic -ffunction-sections -funwind-tables -fstack-protector-strong -Wno-invalid-command-line-argument -Wno-unused-command-line-argument -no-canonical-prefixes -mthumb -Os -g -DNDEBUG -MD -MF bazel-out/armeabi-v7a-opt/bin/tensorflow/core/kernels/objs/android_tensorflow_kernels/cwise_op_not_equal_to_2.pic.d '-frandom-seed=bazel-out/armeabi-v7a-opt/bin/tensorflow/core/kernels/objs/android_tensorflow_kernels/cwise_op_not_equal_to_2.pic.o' -fPIC -D__CLANG_SUPPORT_DYN_ANNOTATION -DEIGEN_MPL2_ONLY '-DEIGEN_MAX_ALIGN_BYTES=64' '-DEIGEN_HAS_TYPE_TRAITS=0' -iquote . -iquote bazel-out/armeabi-v7a-opt/bin -iquote external/com_google_absl -iquote bazel-out/armeabi-v7a-opt/bin/external/com_google_absl -iquote external/nsync -iquote bazel-out/armeabi-v7a-opt/bin/external/nsync -iquote external/com_google_protobuf -iquote bazel-out/armeabi-v7a-opt/bin/external/com_google_protobuf -iquote external/zlib_archive -iquote bazel-out/armeabi-v7a-opt/bin/external/zlib_archive -iquote external/eigen_archive -iquote bazel-out/armeabi-v7a-opt/bin/external/eigen_archive -iquote external/local_config_sycl -iquote bazel-out/armeabi-v7a-opt/bin/external/local_config_sycl -iquote external/double_conversion -iquote bazel-out/armeabi-v7a-opt/bin/external/double_conversion -iquote external/farmhash_archive -iquote bazel-out/armeabi-v7a-opt/bin/external/farmhash_archive -iquote external/fft2d -iquote bazel-out/armeabi-v7a-opt/bin/external/fft2d -iquote external/gemmlowp -iquote bazel-out/armeabi-v7a-opt/bin/external/gemmlowp -isystem external/nsync/public -isystem bazel-out/armeabi-v7a-opt/bin/external/nsync/public -isystem external/com_google_protobuf/src -isystem bazel-out/armeabi-v7a-opt/bin/external/com_google_protobuf/src -isystem external/zlib_archive -isystem bazel-out/armeabi-v7a-opt/bin/external/zlib_archive -isystem external/eigen_archive -isystem bazel-out/armeabi-v7a-opt/bin/external/eigen_archive -isystem external/double_conversion -isystem bazel-out/armeabi-v7a-opt/bin/external/double_conversion -isystem external/farmhash_archive/src -isystem bazel-out/armeabi-v7a-opt/bin/external/farmhash_archive/src '-std=c++11' -DEIGEN_AVOID_STL_ARRAY -Iexternal/gemmlowp -Wno-sign-compare -fno-exceptions '-ftemplate-depth=900' '-mfpu=neon' -DTENSORFLOW_MONOLITHIC_BUILD -DTF_LEAN_BINARY -Wno-narrowing -fomit-frame-pointer -O2 '--sysroot=external/androidndk/ndk/platforms/android-18/arch-arm' -isystem external/androidndk/ndk/sources/cxx-stl/llvm-libc++/include -isystem external/androidndk/ndk/sources/cxx-stl/llvm-libc++abi/include -isystem external/androidndk/ndk/sources/android/support/include -isystemexternal/androidndk/ndk/sysroot/usr/include -c tensorflow/core/kernels/cwise_op_not_equal_to_2.cc -o bazel-out/armeabi-v7a-opt/bin/tensorflow/core/kernels/_objs/android_tensorflow_kernels/cwise_op_not_equal_to_2.pic.o)
Execution platform: @bazel_tools//platforms:host_platform
clang: error: unable to execute command: Killed
clang: error: clang frontend command failed due to signal (use -v to see invocation)
Android (4691093 based on r316199) clang version 6.0.2 (https://android.googlesource.com/toolchain/clang 183abd29fc496f55536e7d904e0abae47888fc7f) (https://android.googlesource.com/toolchain/llvm 34361f192e41ed6e4e8f9aca80a4ea7e9856f327) (based on LLVM 6.0.2svn)
Target: armv7-none-linux-android
Thread model: posix
InstalledDir: external/androidndk/ndk/toolchains/llvm/prebuilt/linux-x86_64/bin
clang: note: diagnostic msg: PLEASE submit a bug report to http://llvm.org/bugs/ and include the crash backtrace, preprocessed source, and associated run script.
clang: note: diagnostic msg:

PLEASE ATTACH THE FOLLOWING FILES TO THE BUG REPORT:
Preprocessed source(s) and associated run script(s) are located at:
clang: note: diagnostic msg: /tmp/cwise_op_not_equal_to_2-9cbb9b.cpp
clang: note: diagnostic msg: /tmp/cwise_op_not_equal_to_2-9cbb9b.sh
clang: note: diagnostic msg:

Target //tensorflow/lite/examples/l17:Prophet.so failed to build
`

It's interesting that it crashes at printf not float re=output[0];
Does it crash if you try to access to output[0] before invoke? And what's the value of output? Is it nullptr?

foud type error.
fail:
result=interpreter->typed_output_tensor(0)[0];  // fail
ok:
TfLiteTensor outputTensor=interpreter->tensor(interpreter->outputs()[0]);
auto re=outputTensor->data.i32;
why?

Hi There,
We are checking to see if you still need help on this, as you are using an older version of tensorflow which is officially considered end of life . We recommend that you upgrade to the latest 2.x version and let us know if the issue still persists in newer versions. Please open a new issue for any help you need against 2.x, and we will get you the right help.
This issue will be closed automatically 7 days from now. If you still need help with this issue, please provide us with more information.


Support test-runner to submit unsigned_extrinsic

Support test-runner to submit unsigned_extrinsic.
Add pool to return a reference to the pool.

You need to format this properly.
You need to create a polkadot companion.
And then we can merge this.

However, I still would not recommend you to use this for testing. There is really no need to use this.

You need to format this properly.
You need to create a polkadot companion.
And then we can merge this.

However, I still would not recommend you to use this for testing. There is really no need to use this.

Thank you. I will refer to the substrate to test RPC.
Use test-runner to test some e2e scenarios, such as transction_pool priority order.

bot merge force


[BUG] Documentation and relevant Helm charts are out of date.

Describe the bug
https://docs.keydb.dev/docs/download/ - the helm chart is not maintained since March 2023

It leads to this repo on artifacthub.io - https://artifacthub.io/packages/helm/enapter/keydb
Which leads to this GH repo - https://github.com/Enapter/charts which is now archived.

To reproduce
Visit website: https://artifacthub.io/packages/helm/enapter/keydb
Expected behavior
Have a more up to date Helm chart.
Additional information
No info, thanks a lot.

[NEW] helm chart for master-master KeyDB #669

https://github.com/Snapchat/KeyDB/issues/669#issuecomment-1714319925 - there's no bandwidth to support this atm as per author


[Web] Check for existence of seed and load on startup

AC

On startup in mobile environment web will check if seed exists and request via getKey to import into memory for use during session.
upgrade mnemomic to new keyed storage (mnemonic_1) and remove from old storage
Create event to allow for modal display to alert users when this occurs (welcome to the new app) - maybe challenging due to async nature of the load that can happen prior to the webview loading. maybe need to set a flag or something.

Dependency
#2 (getKey)

Will implement in the native app side due to some intermittent issues

upgrade mnemomic to new keyed storage (mnemonic_1) and remove from old storage <- last open item

@cjthompson working on validation of this functionality.


Allow bounties on anything, after the fact [$10]

Bountysource is currently setup to set bounties first, then have someone solve the issue. Most of the time, this works well, as people know what they want in a contribution ahead of time. However, this isn't always the case. Sometimes you get really awesome unexpected drive-by contributions, and I'd like to reward people for them. Ideally I'd like to have the ability to assign rewards to anything on github (such as comments, gists, commits, solving bugs, or even just for reporting bugs)

---
There is a **[$10 open bounty](https://www.bountysource.com/issues/847738-allow-bounties-on-anything-after-the-fact-10?utm_campaign=plugin&utm_content=tracker%2F47&utm_medium=issues&utm_source=github)** on this issue. Add to the bounty at [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F47&utm_medium=issues&utm_source=github).

Rewarding after the fact is a donation. That problem was solved long before Bountysource; there are a lot of donation websites.

Closing this issue as this is not planned as part of the roadmap. As mentioned there are donation websites available for this purpose.


Update account home page for email subscriptions

So it shows users' information about their email subscriptions, if they
have any, as well as their Brexit checker results.
Previously, the only service users could use their GOV.UK account for
was the Brexit checker. If they hadn't saved their checker results to
their account, the home page showed a prompt to use the Brexit checker.
Now users will also be able to sign up for email notifications with
their GOV.UK account so it's not correct to show the "You have not used
your account to access any services yet" message if they've not used the
Brexit checker.
We are treating email subscriptions in a slightly different way to other
services that might use the GOV.UK account, which is why I've added a new
helper method to check if a user has subscriptions rather than using the
existing has_used?
Trello
Screenshots
User with no email subscriptions and no brexit checker results:

User with email subscriptions and no brexit checker results:

User with no email subscriptions and brexit checker results

User with email subscriptions and brexit checker results:

Whoops, we ned to give frontend a bearer token for email-alert-api


Feature: Set SupabaseVectorStore Schema

When creating a SupabaseClient from a custom schema:
const supabaseAdminClient = createClient<DocsDatabase>(
    SUPABASE_URL,
    SUPABASE_SERVICE_ROLE_KEY,
    {
      db: { schema: "docs" },
    },
  );

I am unable to create a SupabaseVectorStore from LangChain:
const supabaseVectorStore = new SupabaseVectorStore(embeddings, {
    client: supabaseAdminClient,
    tableName: "documents",
  });

Error:
Type "SupabaseClient<DocsDatabase, "docs", { Tables: ... " is not assignable to type 'SupabaseClient<any, "public", any>.   Type "docs" is not assignable to type '"public"
I would like to have the ability to specify a schema other than "public" for the Supabase Client.  This is important for Security/Customization purposes.

That's odd - we type it as just SupabaseClient. If you cast it to any does it work? (of course long-term we'd want to fix)

Yes, this issue is still relevant to the current version.


Add option to initialize sap.m.Select 'unselected' when selectedKey is not set/matched

Steps to reproduce the problem:

You need input from the user + you want to make the user explicitly think about it's choice
You don't want to have the first item selected automatically if there is no selectedKey set

What is the expected result?
I would like to see an option that in case no selectedKey is set (or doesn't match a key of the items) the sap.m.Select will show unselected by default (no text label). This is different than adding a dummy select item (which is not ideal) because with an initial empty selection the values shown in the dropdown do not contain an element with empty text. Thus it shouldn't be possible to select an empty value. We force the user to make a choice, his/her choice, without proposing a default.

Have you tried forceSelection="false"? https://jsbin.com/royiyej/edit?html,output

@piejanssens Just updated the JSBin with data binding


Update README.md with molecule-docker

A small update to remove a potential blocker for people following this chapter.
The driver for docker is separate since https://github.com/ansible-community/molecule/pull/2811, thus molecule-docker should be installed explicitly.

Sorry about never merging this in! This actually changed again since this PR was filed, and now the proper way is:
pip3 install ansible molecule molecule-plugins[docker] docker

I've updated in the main branch already, so the README should now be up to date.


Include groovydoc generation in the groovy portlet templates

Is your feature request related to a problem? Please describe.
As of now we have to manually add thegmavenplus-pluginand it's dependencies to the  section of the pom.xml of newly created portlets.
It would be nice to have this automatically included in the  portlet_groovy and portlet_groovy_osgi
Templates so this doesn't get lost during a remerge of the Template to the project or while creating a new portlet.
Describe the solution you'd like
1.) Add the gmavenplus-plugin with the correct goals to the  section of the pom.xml. for both Templates.
2.) Add the maven-site-plugin dependency to the  section of the pom.xml of the Templates
3.) Check if it works by locally running the command mvn site in the root directory.
<!-- **Additional context**
See the [data-model-lib](https://github.com/qbicsoftware/data-model-lib/blob/development/pom.xml) `pom.xml `to see how the gmavenplus goals should be specified in the pom.xml.

This should only be tackled after this Issue addressing the removal of theparent-pom from the Templates has been done.
Afterwards the steps outlined in this Issue on the Data-model-lib repository have to be added to the Pom.xml of the portlet templates.


onUp() callback is not called if the bubble is quickly released

Hello @TorryDo ❤
I was implementing some logic in the FloatingBubbleListener callbacks but I have observed a behavior which I wanted to ask about.
When I tap on the bubble, the onDown() callback is called instantly as intended, but if I released my finger quickly from the bubble, the onClick() callback would be fired while onUp() is not.
If I tapped on the bubble and waited for a very short time (~1 sec), then the onDown() callback would be called without any issues as in the past case, but the onUp() callback would be called while onClick() not.
Here is the output for both scenarios for logging a statement in each mentioned callbacks:
First Scenario:
Bubble Tapped Down on: 99.0, 358.0
Bubble Clicked

Second Scenario:
Bubble Tapped Down on: 120.0, 332.0
Bubble Tapped Up on: 120.0, 332.0

So is it an intended behavior or it is a bug? 🤔
Thanks in advance ❤

Based on the behavior you described, it seems to be a bug.
The onClick() callback should be triggered in correspondence with the onUp() method, unless the user has moved their finger before releasing the bubble. I'll look into it further.
Thank you! 💖

The issue is now gone in v0.5.2
If you have any further concerns, don't hesitate to reopen the issue.
Cheers 🍺🍻

I have tested the issue against v0.5.2 and it is solved 💪🏻
Thank you so much 🙏🏻❤


In markdown file all ' turn to ‘ or ’

In file with suffix md or markdown, i can't input symbol ', it auto turn to ‘ or ’.
Need some help.

Is there a way to unbundle this one group? I don't know what all the other bundles are and don't want to risk miss including other bundles to just exclude this one.


Merge to live

Docs Build status updates of commit 7c7e64e:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 1d23d27:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

cordovadocs/2015/access-device-capabilities/manage-plugins.md
:bulb:Suggestion

Details

cordovadocs/2015/access-device-capabilities/use-cordova-plugins.md
:bulb:Suggestion

Details

cordovadocs/2015/adding-javascript-packages/interoperability.md
:bulb:Suggestion

Details

cordovadocs/2015/build-deploy/app-lifecycle-management.md
:bulb:Suggestion

Details

cordovadocs/2015/build-deploy/deploy-and-run-app.md
:bulb:Suggestion

Details

cordovadocs/2015/build-deploy/get-started-with-ci.md
:bulb:Suggestion

Details

cordovadocs/2015/build-deploy/jenkins.md
:bulb:Suggestion

Details

cordovadocs/2015/build-deploy/run-app-android-emulator.md
:bulb:Suggestion

Details

cordovadocs/2015/change-cordova-version/change-cli-version.md
:bulb:Suggestion

Details

cordovadocs/2015/change-cordova-version/change-node-version.md
:bulb:Suggestion

Details

cordovadocs/2015/change-cordova-version/tutorial-cordova-5-readme.md
:bulb:Suggestion

Details

cordovadocs/2015/debug-test/appium-setup.md
:bulb:Suggestion

Details

cordovadocs/2015/debug-test/appium-ui-sequences.md
:bulb:Suggestion

Details

cordovadocs/2015/debug-test/designing-ui-tests.md
:bulb:Suggestion

Details

cordovadocs/2015/debug-test/ui-testing-on-device-farms.md
:bulb:Suggestion

Details

cordovadocs/2015/debug-test/ui-testing-prerequisites.md
:bulb:Suggestion

Details

cordovadocs/2015/first-steps/create-a-hosted-app.md
:bulb:Suggestion

Details

cordovadocs/2015/first-steps/get-started-first-mobile-app.md
:bulb:Suggestion

Details

cordovadocs/2015/first-steps/get-started-with-ionic2.md
:bulb:Suggestion

Details

cordovadocs/2015/first-steps/getting-started-with-ionic.md
:bulb:Suggestion

Details

cordovadocs/2015/first-steps/ios-guide.md
:bulb:Suggestion

Details

cordovadocs/2015/first-steps/migrate-to-vs2015.md
:bulb:Suggestion

Details

cordovadocs/2015/known-issues/known-issues-cordova5.md
:bulb:Suggestion

Details

cordovadocs/2015/known-issues/known-issues-ios.md
:bulb:Suggestion

Details

cordovadocs/2015/known-issues/known-issues-vs2013.md
:bulb:Suggestion

Details

cordovadocs/2015/publishing/publish-to-a-store.md
:bulb:Suggestion

Details

cordovadocs/2015/samples/convert-cordova-phonegap.md
:bulb:Suggestion

Details

cordovadocs/2015/security/authentication.md
:bulb:Suggestion

Details

cordovadocs/2015/tips-workarounds/configuration-tips.md
:bulb:Suggestion

Details

cordovadocs/2015/tips-workarounds/general-tips.md
:bulb:Suggestion

Details

cordovadocs/2015/tips-workarounds/measuring-performance.md
:bulb:Suggestion

Details

cordovadocs/2017/build-deploy/ci-guide.md
:bulb:Suggestion

Details

cordovadocs/2017/build-deploy/jenkins.md
:bulb:Suggestion

Details

cordovadocs/2017/first-steps/simulate-in-browser.md
:bulb:Suggestion

Details

cordovadocs/2017/publishing/publish-to-a-store.md
:bulb:Suggestion

Details

cordovadocs/2017/run-your-app/simulate-in-browser.md
:bulb:Suggestion

Details

cordovadocs/2017/tips-workarounds/configuration-tips.md
:bulb:Suggestion

Details

cordovadocs/2017/tips-workarounds/host-a-mac-in-the-cloud.md
:bulb:Suggestion

Details

cordovadocs/2017/tips-workarounds/run-web-app-in-cordova.md
:bulb:Suggestion

Details

cordovadocs/2017/tips-workarounds/run-windows-in-mac-vm.md
:bulb:Suggestion

Details

cordovadocs/2015/index.md
:white_check_mark:Succeeded

cordovadocs/2015/release-notes/release-update-10.md
:white_check_mark:Succeeded

cordovadocs/2015/release-notes/release-update-9.md
:white_check_mark:Succeeded

cordovadocs/2017/build-deploy/app-lifecycle-management.md
:white_check_mark:Succeeded

cordovadocs/2017/build-deploy/get-started-with-ci.md
:white_check_mark:Succeeded

cordovadocs/2017/build-deploy/tfs2015.md
:white_check_mark:Succeeded

cordovadocs/2017/build-deploy/using-gulp-build-tasks.md
:white_check_mark:Succeeded

cordovadocs/2017/build-deploy/visual-studio-team-services.md
:white_check_mark:Succeeded

cordovadocs/2017/debug-test/debug-using-visual-studio.md
:white_check_mark:Succeeded

cordovadocs/2017/first-steps/build-your-first-app.md
:white_check_mark:Succeeded

This comment lists only the first 50 files in the pull request.

cordovadocs/2015/access-device-capabilities/manage-plugins.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

cordovadocs/2015/access-device-capabilities/use-cordova-plugins.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

cordovadocs/2015/adding-javascript-packages/interoperability.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

cordovadocs/2015/build-deploy/app-lifecycle-management.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.
Line 202, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).

cordovadocs/2015/build-deploy/deploy-and-run-app.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.
Line 2, Column 8: [Suggestion-duplicate-titles] Title 'Cordova build process in Visual Studio  - Cordova' is duplicated in: '2015/build-deploy/deploy-and-run-app.md(2,8), 2015/build-deploy/run-app-ripple-simulator.md(2,8)'. Titles must be unique within a docset.

cordovadocs/2015/build-deploy/get-started-with-ci.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.
Line 16, Column 57: [Suggestion-alt-text-missing] Missing alternate text for image 'https://raw.githubusercontent.com/Microsoft/vsts-cordova-tasks/master/docs/media/misc/cordova_logo_white_purple.png'. Alt text is required for accessibility.

cordovadocs/2015/build-deploy/jenkins.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

cordovadocs/2015/build-deploy/run-app-android-emulator.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

cordovadocs/2015/change-cordova-version/change-cli-version.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.
Line 82, Column 141: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: https://docs.microsoft.com/visualstudio/cross-platform/tools-for-cordova/release-notes/release-update-8?view=toolsforcordova-2015

cordovadocs/2015/change-cordova-version/change-node-version.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.
Line 11, Column 73: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: https://docs.microsoft.com/visualstudio/cross-platform/tools-for-cordova/release-notes/release-update-8?view=toolsforcordova-2015

cordovadocs/2015/change-cordova-version/tutorial-cordova-5-readme.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

cordovadocs/2015/debug-test/appium-setup.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

cordovadocs/2015/debug-test/appium-ui-sequences.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

cordovadocs/2015/debug-test/designing-ui-tests.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

cordovadocs/2015/debug-test/ui-testing-on-device-farms.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

cordovadocs/2015/debug-test/ui-testing-prerequisites.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.
Line 80, Column 156: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: https://docs.microsoft.com/visualstudio/cross-platform/tools-for-cordova/first-steps/build-your-first-app?view=toolsforcordova-2017
Line 90, Column 209: [Suggestion-link-text-missing] Missing link text for link 'https://docs.microsoft.com/visualstudio/cross-platform/tools-for-cordova/?view=toolsforcordova-2017'. Add appropriate text.
Line 90, Column 209: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: https://docs.microsoft.com/visualstudio/cross-platform/tools-for-cordova/?view=toolsforcordova-2017

cordovadocs/2015/first-steps/create-a-hosted-app.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.
Line 2, Column 8: [Suggestion-duplicate-titles] Title 'Create a Hosted App  - Cordova' is duplicated in: '2015/first-steps/create-a-hosted-app.md(2,8), 2015/first-steps/getting-started-with-ionic.md(2,8)'. Titles must be unique within a docset.
Line 180, Column 39: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: https://docs.microsoft.com/visualstudio/cross-platform/tools-for-cordova/?view=toolsforcordova-2017#the-w3c-content-security-policy-csp
Line 461, Column 143: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: https://docs.microsoft.com/visualstudio/cross-platform/tools-for-cordova/run-your-app/run-app-android?view=toolsforcordova-2017

cordovadocs/2015/first-steps/get-started-first-mobile-app.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.
Line 64, Column 250: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: https://docs.microsoft.com/visualstudio/cross-platform/tools-for-cordova/first-steps/using-bower?view=toolsforcordova-2017
Line 67, Column 221: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: https://docs.microsoft.com/visualstudio/cross-platform/tools-for-cordova/publishing/publish-to-a-store?view=toolsforcordova-2017

cordovadocs/2015/first-steps/get-started-with-ionic2.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.
Line 20, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: https://docs.microsoft.com/visualstudio/cross-platform/tools-for-cordova/first-steps/installation?view=toolsforcordova-2017

cordovadocs/2015/first-steps/getting-started-with-ionic.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.
Line 2, Column 8: [Suggestion-duplicate-titles] Title 'Create a Hosted App  - Cordova' is duplicated in: '2015/first-steps/create-a-hosted-app.md(2,8), 2015/first-steps/getting-started-with-ionic.md(2,8)'. Titles must be unique within a docset.
Line 468, Column 161: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: https://docs.microsoft.com/visualstudio/cross-platform/tools-for-cordova/tips-workarounds/configuration-tips?view=toolsforcordova-2017#ThirdParty
Line 472, Column 59: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: https://docs.microsoft.com/visualstudio/cross-platform/tools-for-cordova/tips-workarounds/configuration-tips?view=toolsforcordova-2017#vstac

cordovadocs/2015/first-steps/ios-guide.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.
Line 733, Column 33: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: https://docs.microsoft.com/visualstudio/cross-platform/tools-for-cordova/change-cordova-version/change-cli-version?view=toolsforcordova-2015#how-to-update-the-cli-version-of-your-project

cordovadocs/2015/first-steps/migrate-to-vs2015.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

cordovadocs/2015/known-issues/known-issues-cordova5.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

cordovadocs/2015/known-issues/known-issues-ios.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

cordovadocs/2015/known-issues/known-issues-vs2013.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

cordovadocs/2015/publishing/publish-to-a-store.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

cordovadocs/2015/samples/convert-cordova-phonegap.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

cordovadocs/2015/security/authentication.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

cordovadocs/2015/tips-workarounds/configuration-tips.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

cordovadocs/2015/tips-workarounds/general-tips.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

cordovadocs/2015/tips-workarounds/measuring-performance.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

cordovadocs/2017/build-deploy/ci-guide.md

Line 85, Column 1: [Suggestion-sensitive-language-wl] Term 'whitelist' is sensitive and should not be used in content or code. Usage: '    <plugin name="cordova-plugin-whitelist" spec="1" />'

cordovadocs/2017/build-deploy/jenkins.md

Line 18, Column 1: [Suggestion-sensitive-language-sl] Term 'slave' is sensitive and should not be used in content or code. Usage: 'ts a diverse and inclusionary environment.  Within this document, there are references to the word 'slave.' Microsoft's [Style Guide for Bias-Free Communications](https://github.com/MicrosoftDocs/microsoft'

cordovadocs/2017/first-steps/simulate-in-browser.md

Line 2, Column 8: [Suggestion-duplicate-titles] Title 'Run Your App Using Cordova Simulate - Cordova' is duplicated in: '2017/first-steps/simulate-in-browser.md(2,8), 2017/run-your-app/simulate-in-browser.md(2,8)'. Titles must be unique within a docset.
Line 14, Column 1: [Suggestion-duplicate-h1s] H1 'Run Your App Using Cordova Simulate' is duplicated with other articles: '2017/first-steps/simulate-in-browser.md(14,1), 2017/run-your-app/simulate-in-browser.md(14,1)'. First level headings must be unique within a docset.

cordovadocs/2017/publishing/publish-to-a-store.md

Line 263, Column 525: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: https://docs.microsoft.com/visualstudio/cross-platform/tools-for-cordova/first-steps/ios-guide?view=toolsforcordova-2017
Line 317, Column 92: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: https://docs.microsoft.com/visualstudio/cross-platform/tools-for-cordova/first-steps/ios-guide?view=toolsforcordova-2017

cordovadocs/2017/run-your-app/simulate-in-browser.md

Line 2, Column 8: [Suggestion-duplicate-titles] Title 'Run Your App Using Cordova Simulate - Cordova' is duplicated in: '2017/first-steps/simulate-in-browser.md(2,8), 2017/run-your-app/simulate-in-browser.md(2,8)'. Titles must be unique within a docset.
Line 14, Column 1: [Suggestion-duplicate-h1s] H1 'Run Your App Using Cordova Simulate' is duplicated with other articles: '2017/first-steps/simulate-in-browser.md(14,1), 2017/run-your-app/simulate-in-browser.md(14,1)'. First level headings must be unique within a docset.

cordovadocs/2017/tips-workarounds/configuration-tips.md

Line 173, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).
Line 188, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).
Line 197, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).
Line 214, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).
Line 218, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).
Line 222, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).
Line 228, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).
Line 234, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).
Line 240, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).
Line 253, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).
Line 262, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).
Line 266, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).
Line 270, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).
Line 296, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).
Line 317, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).
Line 323, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).
Line 327, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).
Line 339, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).
Line 344, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).

cordovadocs/2017/tips-workarounds/host-a-mac-in-the-cloud.md

Line 31, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).

cordovadocs/2017/tips-workarounds/run-web-app-in-cordova.md

Line 226, Column 85: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: https://docs.microsoft.com/visualstudio/cross-platform/tools-for-cordova/?view=toolsforcordova-2017#the-w3c-content-security-policy-csp

cordovadocs/2017/tips-workarounds/run-windows-in-mac-vm.md

Line 45, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).
Line 54, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).
Line 72, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).
Line 113, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


fix: test should use directory separator acording os

I've been testing in Windows and the test does not pass

nice, thanks!


Update build logic for finding sdk

Overview
Although parsing the folder names is still not the most robust, this is the most straight forward fix for now unless (until?) we rethink this log entirely.
Changes

Fixes: #11124

Thank you, this fix looks good and should resolve our issue in future builds