#hashtag parsing bug

If a tweet contains hashtags like this:
#abc
#ab
The parsing result will be:
[[#ab](https://twitter.com/hashtag/ab) c](https://twitter.com/hashtag/abc)
#ab

Each tag link is added to the first matched phrase it came across, which may not be the correct one. I think this is a similar issue to the @mention bug #9.

@cangyuyao Thanks for catching this, it was mighty foolish on my part 🤦 I've just published version 2.1.3 which fixes this bug.

@cangyuyao Thanks for catching this, it was mighty foolish on my part 🤦 I've just published version 2.1.3 which fixes this bug.

Somehow I didn't get npm package updated yet but I saw your commit. I'm afraid \b will cause matching failure on all tags containing CJK characters.
Also I'm not sure if this works for all non-CJK tags since Twitter has a complex syntax defining the boundary before and after a valid hashtag, mention, etc.
https://github.com/twitter/twitter-text/blob/master/js/pkg/twitter-text-3.1.0.js
I haven't tried TypeScript before but I've used this script to parse twitter text in another tool. Perhaps this can also be implemented here.

@cangyuyao Thanks for following up with more information. Let me do some more testing!

@cangyuyao I've re-written the hashtag, mention, and cashtag replacement function to use indices instead of regex. It now successfully handles CJK hashtags without issue, and should handle all hashtags in any script. I've added in some tests for this, and I've just published version 2.1.4.
Thanks again!

Thanks for the update! It works perfectly most time but I just found the length of emojis are different in JavaScript.
A random example here: https://twitter.com/FollowBackAddic/status/1565545829942845440
I modify the substring function to this:
for (const entity of allEntities) {
        let chars = [...text];
        text =
	        chars.slice(0, entity.start).join("") +
	        entity.replacement +
	        chars.slice(entity.end).join("");
}

@cangyuyao I'm learning so much about the failings of JavaScript with non-Latin characters 😓 Thanks for the suggested fix! Version 2.2.1 is live now.

Found another bug: replaceEntities needs to run before decode_1 since the indices are based on the raw text.

@cangyuyao Thank you again! I've added some new tests covering these cases. Please try out version 2.2.2!


Form notifications on the new UCI

does this mean that the new UCI does not support form notifications?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 20ddc9c7-6b30-bcfd-ef06-9f232022d62a
Version Independent ID: 7d1cfc6d-190f-fa5c-b634-9d8bfd53e987
Content: setFormNotification (Client API reference) in Dynamics 365 Customer Engagement
Content Source: ce/developer/clientapi/reference/formContext-ui/setFormNotification.md
Service: crm-online
GitHub Login: @KumarVivek
Microsoft Alias: kvivek

Possible duplicate of #511

Thanks @valdik5379455
@mmartyna  UCI Does support Form notification


dependsOnMethod works only for immediate inheritance level. chained inheritance not working.

TestNG Version
7.1.0 - observed in 6.xx version as well
Expected behavior
Running the test on the class level and method level should work fine despite dependsOnMethod chaining.
Actual behavior
On running the code below at class level (TestNg class in the sample test), the dependsOnMethod hierarchy works correctly and all tests pass.
However, on running only method3 it results in
/Library/Java/JavaVirtualMachines/openjdk-11.0.2.jdk/Contents/Home/bin/java -ea -Didea.test.cyclic.buffer.size=1048576 "-javaagent:/Applications/IntelliJ IDEA.app/Contents/lib/idea_rt.jar=50412:/Applications/IntelliJ IDEA.app/Contents/bin" -Dfile.encoding=UTF-8 -classpath "/Applications/IntelliJ IDEA.app/Contents/lib/idea_rt.jar:/Applications/IntelliJ IDEA.app/Contents/plugins/testng/lib/testng-rt.jar:/Users/stealth/IdeaProjects/TestNg/target/test-classes:/Users/stealth/IdeaProjects/TestNg/target/classes:/Users/stealth/.m2/repository/org/testng/testng/7.1.0/testng-7.1.0.jar:/Users/stealth/.m2/repository/com/beust/jcommander/1.72/jcommander-1.72.jar:/Users/stealth/.m2/repository/com/google/inject/guice/4.1.0/guice-4.1.0-no_aop.jar:/Users/stealth/.m2/repository/javax/inject/javax.inject/1/javax.inject-1.jar:/Users/stealth/.m2/repository/aopalliance/aopalliance/1.0/aopalliance-1.0.jar:/Users/stealth/.m2/repository/com/google/guava/guava/19.0/guava-19.0.jar:/Users/stealth/.m2/repository/org/yaml/snakeyaml/1.21/snakeyaml-1.21.jar:/Applications/IntelliJ IDEA.app/Contents/plugins/testng/lib/jcommander-1.27.jar" com.intellij.rt.testng.RemoteTestNGStarter -usedefaultlisteners false -socket50411<EMAIL_ADDRESS>-temp /private/var/folders/pc/kwvbxt0x5zzctyy4g9lmh_cc0000gn/T/idea_testng.tmp
org.testng.TestNGException:
TestNg.method2() is depending on method public void TestNg.method1(), which is not annotated with @Test or not included.
	at org.testng.internal.MethodHelper.findDependedUponMethods(MethodHelper.java:133)
	at org.testng.internal.MethodHelper.topologicalSort(MethodHelper.java:277)
	at org.testng.internal.MethodHelper.sortMethods(MethodHelper.java:381)
	at org.testng.internal.MethodHelper.collectAndOrderMethods(MethodHelper.java:71)
	at org.testng.TestRunner.initMethods(TestRunner.java:519)
	at org.testng.TestRunner.init(TestRunner.java:338)
	at org.testng.TestRunner.init(TestRunner.java:291)
	at org.testng.TestRunner.<init>(TestRunner.java:179)
	at org.testng.SuiteRunner$DefaultTestRunnerFactory.newTestRunner(SuiteRunner.java:613)
	at org.testng.SuiteRunner.init(SuiteRunner.java:178)
	at org.testng.SuiteRunner.<init>(SuiteRunner.java:112)
	at org.testng.TestNG.createSuiteRunner(TestNG.java:1275)
	at org.testng.TestNG.createSuiteRunners(TestNG.java:1251)
	at org.testng.TestNG.runSuitesLocally(TestNG.java:1100)
	at org.testng.TestNG.runSuites(TestNG.java:1039)
	at org.testng.TestNG.run(TestNG.java:1007)
	at com.intellij.rt.testng.IDEARemoteTestNG.run(IDEARemoteTestNG.java:66)
	at com.intellij.rt.testng.RemoteTestNGStarter.main(RemoteTestNGStarter.java:110)

Process finished with exit code 255

Is the issue reproductible on runner?

[ ] Shell
[X ] Maven
[ ] Gradle
[ ] Ant
[ ] Eclipse
[ ] IntelliJ
[ ] NetBeans

Test case sample
import org.testng.annotations.Test;

/**
 * independent execution of method 3 throws error
 * unless all the parent methods are explictly called
 * in the dependsOnMethod
 */
public class TestNg {

    @Test
    public void method1(){
        System.out.println("method 1");
    }

    @Test(dependsOnMethods = {"method1"})
    public void method2(){
        System.out.println("invoking this method works as there is only");
    }

    //does not work on invoking this method
    @Test(dependsOnMethods = {"method2"})
    public void method3_fail(){
        System.out.println("invoking method 3 throws exception");
    }

    @Test(dependsOnMethods = {"method1", "method2"})
    public void method3_fix(){
        System.out.println("invoking this method works as all dependsOnMethods are explictly invoked!");
    }
}

When you select a particular @Test method, right click it and run it as a TestNG test within an IDE, the IDE creates a suite file on the fly, adds the test method that you selected into it and attempts at running it. TestNG by design will throw an exception if your suite xml file contains a test method that has upstream dependencies and not included.
Try running the below suite and you will see the same behaviour
<!DOCTYPE suite SYSTEM "http://testng.org/testng-1.0.dtd" >
<suite name="SampleTestSuite" verbose="2" parallel="false" thread-count="1">
  <test name="dataprovider_test" verbose="2">
    <classes>
      <class name="com.rationaleemotions.github2309.TestNg">
        <methods>
          <include name="method2">
          </include>
        </methods>
      </class>
    </classes>
  </test>
</suite>

There's nothing much that can be done. You would need to run the test class fully. If you still feel this is a problem, then I would suggest that you file a bug with the IntelliJ IDE which is what triggers this behaviour.
Closing this issue as Working as designed


Mirror repo creating failed - Error 403

Bug description
Not possible to use resource gitea_repository. Setting up for a mirror repository failed with "Error: 403 Forbidden" whilst terraform apply - creating repo
To Reproduce
Steps to reproduce the behavior:
resource "gitea_repository" "repo" {
username                     = data.gitea_org.test.name
name                         = local.name_with_stage
private                      = false
auto_init                    = false
license                      = var.license
has_issues                   = true
has_projects                 = false
has_pull_requests            = true
migration_issue_labels       = false
migration_milestones         = false
migration_releases           = false
mirror                       = true
migration_service            = "gitea"
migration_clone_address      = "this_adress"
migration_service_auth_token = var.this_token
}
Expected behavior
A clear and concise description of what you expected to happen.
Log Output
module.dda-python-terraform.gitea_repository.repo: Creating...
Error: 403 Forbidden
with module.dda-python-terraform.gitea_repository.repo,
on mirror/codeberg.tf line 5, in resource "gitea_repository" "repo":
5: resource "gitea_repository" "repo" {
Additional Data

Gitea 1.17.3

Terraform Version 1.0.8, 1.3.6, 1.3.8

Operating System Xubuntu 22.04

Provider Version 0.12.1

Hi @zami2022
Can you try it again with an administrator token in the provider configuration? It seems like the configured user does not have the required permissions to create a repository in the defined organization

Just did a test and i can not reproduce this. i still belive that the credentials that are configured to be used by the provider do not have the required permissions to create a new repository at the desired location.
here is what i did in my test:
start a new gitea instance:
cd examples
docker-compose up -d

finish installation in the UI
create a new admin token at settings -> applications
ran the following code:
terraform {
  required_providers {
    gitea = {
      source = "lerentis/gitea"
      version = "0.12.1"
    }
  }
}

provider "gitea" {
  base_url = "http://localhost:3000/"
  token    = var.gitea_token # <- the token i just created
}

resource "gitea_repository" "mirror" {
  username                     = "lerentis" # <- this is the admin user that i created during installation
  name                         = "terraform-provider-gitea-mirror"
  description                  = "Mirror of Terraform Provider"
  mirror                       = true
  migration_clone_address      = "https://git.uploadfilter24.eu/lerentis/terraform-provider-gitea.git"
  migration_service            = "gitea"
  migration_service_auth_token = "not relevant as repo is public"
}

can you reproduce this on your side with a similar small example?

HI @Lerentis ,
Thanks for taking the time to look into that issue.
I was able to make it work on our instance, following your example above.
However, I was not able to set up a mirror on codeberg.org.
Maybe its an issue on their side.

sorry for the late reply. did you investigate this further?
i do not have an account at codeberg, so i can not claim i tested the provider there. nevertheless the way the provider works, is just speaking with the rest api of gitea and as far as i know codeberg does not alter it. my general recommendation would be to check the permissions of the api key or rather the connected user

Hey,
Any further investigation stopped - as it does not seem to be possible to set permissions for an access token.
The user on codeberg is just a standard user without admin privileges - which i would expect.
I'll let you know if any solution comes up. Thanks!

hey there, late to the debate but I'm aware of a related thing:
Codeberg have removed the option to create mirror repos on their instance so your issue might very well be caused by that (unless Codeberg reverted their decision) and that's why you're getting 403s from their API...
btw have you tried manually creating a mirror there recently? I expect it to not work (if it's shown in the UI at all) @PatDyn

Hi, thanks for the heads up. We didn't dig any further - so from my side this issue could be closed.

i would like to confirm that and add it to the documentation as codeberg is currently the most popular gitea instance out there. sadly i am currently short on time as i am in the process of moving currently :/
maybe i find some time next week to conclude this

thanks for confirming that.
and no worries man, I's your moving goes smoothly. @Lerentis

Maybe just as a FYI @PatDyn: The point from @wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf is correct and is even documented in codebergs FAQ: https://docs.codeberg.org/getting-started/faq/#why-am-i-not-allowed-to-set-up-an-automatic-mirror
I will note this in the documentation together with another issue i found while investigating the expected permissions and release a bugfix version shortly

Done and released as v0.12.3


The result saving customisation

It would be nice to have an option to turn on and off the result storing in localStorage. I would like to store the result on my own and it looks like it isn't possible right now.

Hi @RafRaf
Thanks for raising the issue. I've added it to our backlog for future implementation. While I can't provide an exact timeline, rest assured it's on our radar. Your input is valuable, and we appreciate your patience.
Best,
@GlobalHive

Hi @RafRaf
Your request has been added.

Update package to 1.4.0
Add saveToLocalStorage to your VTour component:
<VTour :steps="steps" saveToLocalStorage='custom'/>
OR if you want every step to be saved:
<VTour :steps="steps" saveToLocalStorage='step'/>
If 'custom' is used, the component won't save anything, so its up to you how you wanna do it.
Profit!

Docs
Best,
@GlobalHive


Upgrade Extensions bundle to 3.3.0

Hello,
Could you upgrade included Function Extensions bundle to 3.3.x? Currently the 3.0.0 version is included in images which even is not mentioned on the MS Docs page: https://docs.microsoft.com/en-us/azure/azure-functions/functions-bindings-register#extension-bundles

Yes, this will be included in the next host release which will be 3.5.0.

Thanks. Any ETA when it will be? days? weeks? months? ....years? :)

Looking at early next year as we're hitting a code freeze soon.


Added UML with plantUML syntax for HUSH messenger project

Please comment for any changes, regards.

Great PR, thanks for the contribution. For SA, this standalone version of Messenger has been placed on hold while HushNG is being worked on. Hush Messenger will be natively included in HushNG.
That being said, this repo will offer the standalone client.


readme: add ban skill

🔪uwu🔪

@dmitryplyaskin planks for your incredible impact! You have done a great work 🔥 🔥 🔥

@dmitryplyaskin planks for your incredible impact! You have done a great work 🔥 🔥 🔥

@dmitryplyaskin planks for your incredible impact! You have done a great work 🔥 🔥 🔥

thx

@dmitryplyaskin planks for your incredible impact! You have done a great work 🔥 🔥 🔥

thx


Add test-features recipe to justfile

Created a .sh script using the cargo-hack tool in order to easily test all feature combinations. This is done in --release mode to reduce the size of the compiled artifacts.
The script is located in a new contrib directory (same approach followed by rust-bitcoin crates). This will be useful for CI as well.

Updated the shell script to accept an optional cargo argument, useful for selecting a verbosity (quiet or verbose).

A final tiny change: better to handle the cargo-hack installation outside of the shell script.

ACK 0f276c8b9b815a1386ba79743b6d3267f56184bb. This will be a very useful too for reviewers!


Command to enable auto-update of Azure Linux Agent doesn't do anything

The doc says to run this command to enable autoupdate on Ubuntu:
sudo sed -i 's/# AutoUpdate.Enabled=n/AutoUpdate.Enabled=y/g' /etc/waagent.conf

For some reason, I had this in my config:
# Enable or disable goal state processing auto-update, default is enabled
# AutoUpdate.Enabled=y

For this reason, the sed command didn't do anything and I didn't immediately realize that. Perhaps the command should rather be:
sudo sed -i 's/# AutoUpdate.Enabled=[y|n]/AutoUpdate.Enabled=y/g' /etc/waagent.conf

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e86655f9-6d0b-106b-7b88-edbd20ee4544
Version Independent ID: cf60b900-6f8a-4b28-a86b-39daadd876f5
Content: Update the Azure Linux Agent from GitHub - Azure Virtual Machines
Content Source: articles/virtual-machines/extensions/update-linux-agent.md
Service: virtual-machines
Sub-service: extensions
GitHub Login: @amjads1
Microsoft Alias: amjads

@kimjamia Thanks for the feedback! I have assigned the issue to content author to check and update the document as appropriate.We will update you accordingly.

@amjads1
Can you please check and add your comments on this doc update request as applicable

#reassign @MsGabsta

I am looking into this.

Thanks for your dedication to our documentation. Unfortunately, at this time we have been unable to review your issue in a timely manner and we sincerely apologize for the delayed response. The requested updates have not been made since the creation of this issue, and the timeline for resolution may vary based on resourcing, so we've created an internal work item to incorporate your suggestions. We are closing this issue for now, but feel free to comment here as necessary. #please-close


[1.12.0] java.lang.NoSuchMethodError

mod Version: 6.3.17
Forge Build: 2443
https://pastebin.com/dhTMQYTy

The file was mistakenly marked as supporting 1.12. It requires at least Minecraft 1.12.2.

Ok I understand.Thank you!


get_result  return err NotFound  when upsert on_conflict do_nothing

diesel 0.13.0

rust 1.18 stable

User<'a> {
   name: &'a str
}

fn save(user: User) -> Result {
    match diesel::insert(&user.on_conflict(users::name, do_nothing()))
                .into(users::table)
                .get_result::<User>(conn) {
        Ok(_) => Ok(()),
        Err(e) => {
            debug!("save user {:?}", e);
            Err(e)
        }
    }
}

save(User{name: "123"}).unwrap(); //ok
save(User{name: "123"}).unwrap(); //wrong get NotFound

is this by design?

It's a bit of a quirky interaction between those two features, but yeah it's by design. I don't think that specifically passing an upsert with do_nothing to insert should change the return type of get_result, as that's a really non-local change. You should call .optional here if you want a QueryResult<Option<User>> as per the docs

Hello! I'm glad to see that this has been addressed, because I had the same question.
Using .optional, however, returns Ok(None), which is truthy... But it feels like it shouldn't be, why isn't it Err(Some(Conflict)) (even though Conflict doesn't exist)? Am I missing something?
For reference, this is the code that returns Ok(None) when there is a conflict on nickname (which is a unique key):
    diesel::insert_into(users::table)
        .values(InsertableUser {
            password: &encode(&hashed_password),
            ..user
        })
        .on_conflict(users::columns::nickname)
        .do_nothing()
        .get_result(connection)
        .optional()

@tbarusseau That just mirrors the behavior of the underlying database. We return Error::NotFound (which is converted to Ok(None) by .optional()) only for cases where we get back no error and empty result set from the database. So there is really no way for us detecting that to happen here.

What I don't get specifically is why Error::NotFound is returned on conflict, is it because the database actually responds an empty result set (because of the conflict)?

@tbarusseau Yes, exactly that happens. The database returns an empty result set (likely because of the conflict), diesel turns that as part of the get_result implementation into Err(Error::NotFound) and .optional() then turns this into Ok(None).

I see :) Thanks for the explanation


"\n" Being stripped from Message

In the example below, using the Llama3 tokenizer, the leading "\n" is being stripped from the message. If it's in the middle of the message, then it works fine, it seems to only be missing when it's the first character.
from torchtune.models.llama3 import llama3_tokenizer
from torchtune.data import Message

tokenizer = llama3_tokenizer(path=...)
message = Message(role="user", content="\n Tell me a joke")
tokens = tokenizer.tokenize_message(message)

The token for \n is 720 and is missing from tokens in the above example. It will reappear if you prepend anything to the beginning of the message like "Ok \n Tell me a joke".

This was the original behavior in the reference repo when we added llama3 tokenizer, all message content gets stripped before encoded by the tokenizer. I don't like the idea of modifying white spaces for the user and it does mess with some prompt templating that relies on white spaces as well, but at the same time changing this will have repo wide implications.

The reference I was looking at wasn't stripping \n


Shell needs to be updated to use the latest API

Shell.js is currently using version 1 API, so some of the commands no longer work.
Since the last update to Shell.js, we have made breaking changes to:

Pubsub
Code
CodeEngine
Dispatcher

Perhaps we should take this opportunity to revise some of the shell commands as well.

Also, Shell should now use the GFS API

Updated in 6840989b8c02f83a5aa38f12d9d51813b9ba77d9


Tile entities showing without being in a mode list

Like said in the title
Example: Snow

Is it foreseeable in the future whether this problem will be solved?


Need to mention Visual Studio Code

I think the document is referring to Visual Studio 2012+ and ignoring Visual Studio Code.
The document has mentioned Eclipse so for comprehensiveness I recommend added Visual Studio Code

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a1dc9a4a-7828-f40f-4cf0-e0b1f5476ff2
Version Independent ID: 278aed60-558e-3beb-2ed4-c2517c2cd05d
Content: Git and TFVC version control - Azure Repos
Content Source: docs/repos/tfvc/comparison-git-tfvc.md
Product: devops
Technology: devops-code-tfvc
GitHub Login: @MaximMalygin
Microsoft Alias: v-maksim

Yes, fair enough. The whole Client section could use a bit of work, but I do not suspect this doc is important enough for a big level of effort here. Should be quick enough, however, to:

Add Visual Studio Code to the list Client software for Git.
Under Visual Studio Compatibility, future proof it a bit by just calling out all versions of Visual Studio since Visual Studio 2013, or something along those lines.
Maybe just delete the User Interface bit, rather than try and re-write it enough to make it feel modern?


Add dark theme

add support for dark theme in project

https://github.com/SID-mobile-dev/awamp/pull/2


don't run flows on windows server 2019

Hi, I am trying to run flows on a server with windows server 2019 but I get the following error:
Unable to open file: C:\tagui\flows\samples\1_google.tag.js
phantomjs://code/bootstrap.js:113 in __die
Unable to load script C:\tagui\flows\samples\1_google.tag.js; check file syntax
phantomjs://code/bootstrap.js:113 in __die

can you help me?

Hi @ruthtxh php 8.1.12 is installed on my machine, i reinstall it and reinstall taghi but not found.

Hi @ruthtxh the problem is solved reinstalling the visual c++ redistribute, thanks for your support!!!


[uniconfig] Add unistore mode

Signed-off-by: Simon Misencik<EMAIL_ADDRESS>Checklist

[x] Title of the PR starts with chart name (e.g. [krakend])
[x] Update the documentation if a new value has been added
[x] Update chart release notes annotation

It needs to be tested!

Uniconfig and unistore have the same configuration so an option like this is not necessary.


Color definitions

Do color definitions really belong into a typographic toolset? I am having conflicts with the reset and normalization included with axis.

Sorry it's taken me so long to respond. I have my ups and downs with being a good maintainer.
I'm planning on migrating this project to PostCSS in the next month or so, and when I do, I'll probably rewrite it from scratch.

Typographic only controls header colors and body colors, but you definitely make a good point that colors shouldn't be set by default.

nice.  Did you see the pull request?

I do now. Let's talk about it over there.


addImageBlobHook displays both base64 and server uploaded image

I use addImageBlobHook to upload images to my webserver and render it in the editor. this works fine.
However, the base64 image is still rendered in the editor, I don't want to.
Screenshots :
https://i.postimg.cc/K3vQrmFx/aaa.png
https://i.postimg.cc/3wCF3v8H/bbbb.png
You can see that the image is displayed twice in the editor; And the html code shows bot the base64 image and the link to the uploaded image
#127 is not fixing this issue.
Here is my code snippet :
hooks: {
addImageBlobHook: function (blob, callback) {
        let image = new FormData();

        image.append(0, blob, blob.name);

        fetch('upload.php', {
            method: 'POST',
            body: image
        }).then(function (response) {
            if (response.ok) {
                response.json().then((value) => {
                    if (value === 0) {
                        alert("file upload error");
                    } else {
                        callback(value, 'uploaded image');
                    }
                });
            } else {
                alert("file upload error");
            }
        })
        return false; // I tried with true, and without return at all, same result
    }
}

@2klm
The duplication of uploading the image is our bug.
lt will be fixed in #1623.  I'll let you know when it's released!

Removing the default hook and adding it again is a fix.
editor.removeHook('addImageBlobHook'); // remove the default hook
editor.addHook('addImageBlobHook', (blob, callback) => { ... });

@2klm
The bug has been fixed and released in v3.0.1.


Basis transcoder update

This is an update to the basis transcoder. This allows users to also take advantage of the UASTC option of the basis format.
The basis_transcoder.js and basis_transcoder.wasm are a direct copy from the Basis Universal repository.

@vinhui Shouldn't you also be updating the _BasisTextureLoader in https://github.com/BabylonJS/Babylon.js/blob/master/packages/dev/core/src/Materials/Textures/Loaders/basisTextureLoader.ts#L47 and https://github.com/BabylonJS/Babylon.js/blob/master/packages/dev/core/src/Materials/Textures/Loaders/basisTextureLoader.ts#L89?

Good point, I'll update that.

Since the basisu library interface has changed, this change would not be backwards compatible because of the usage of the hosted files. How should this be handled? Updating the files at https://preview.babylonjs.com/basisTranscoder/ would break existing versions while this PR is not compatible with the current version. This could possibly be handled by uploading the new files under a different name and changing that hardcoded url as well.

Good point. I discussed this with the team offline. We think adding a version to the url is the best solution.
Something like:
https://preview.babylonjs.com/basisTranscoder/1/...
Thanks for all the updates!

@vinhui Sorry for coming up with more work for you, but I suppose you'll need to update GetInternalFormatFromBasisFormat at https://github.com/BabylonJS/Babylon.js/blob/master/packages/dev/core/src/Misc/basis.ts#L110 too.

Since the basisu library interface has changed, this change would not be backwards compatible because of the usage of the hosted files. How should this be handled? Updating the files at https://preview.babylonjs.com/basisTranscoder/ would break existing versions while this PR is not compatible with the current version. This could possibly be handled by uploading the new files under a different name and changing that hardcoded url as well.

If I understand it correctly, one of the things that happened between "old" basis transcoder and the "new" one is the renaming and re-ordering of transcoder_texture_format enum (see comment above about GetInternalFormatFromBasisFormat). From what I could find, the change happened in basis_universal version 1.15 in https://github.com/BinomialLLC/basis_universal/commit/54304fa01443280bbaa9854f16c9f1756b17b40b#diff-f9db3d02491fb0018b8046bb9ff087cfce57e86a0c9ee25d846fca5065efb6ae. So I would assume that any files compressed with basisu < 1.15 will be compatible with current Babylon.js version, but anything compressed with basisu >= 1.15 will only be compatible with any Babylon.js version released after this PR is merged. Old files might be compatible, but I'd expect a breakage because of that transcoder_texture_format enum rename.
Can we alleviate that or do we just add a warning to release notes, something along the lines of "May break unless you re-compress all of your assets"?

re-ordering of transcoder_texture_format enum

It looks like from the code, Rich tried to maintain the old enums (the old values are still the same as before). There are new enums though. I think this will only be an issue if new files encoded with new enums are loaded with old loaders, which seems reasonable.

We might be looking at different code :) In BASIS_FORMATS basically all values are different (look at ID 6 or 1 for example) and besides all that, they come straight from Basis source code. The problem is, as you say, first and foremost loading newly encoded files with old loader (seems completely impossible on my machine, format is not detected), but there is probably a problem with old files and new loader, the error message will be different though.

Sorry for the delay.
@rassie I appreciate you taking a good look :)

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Just to confirm, this is not something I can do, right?

Since the basisu library interface has changed, this change would not be backwards compatible because of the usage of the hosted files. How should this be handled? Updating the files at https://preview.babylonjs.com/basisTranscoder/ would break existing versions while this PR is not compatible with the current version. This could possibly be handled by uploading the new files under a different name and changing that hardcoded url as well.

Good point. I discussed this with the team offline. We think adding a version to the url is the best solution.
Something like: https://preview.babylonjs.com/basisTranscoder/1/... https://cdn.babylonjs.com/basisTranscoder/1/... (EDIT: we can/should use the cdn path now actually)
Thanks for all the updates!

I prematurely approved. I don't see this addressed. Marking as draft until it is. :-)

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Just to confirm, this is not something I can do, right?

I tagged it as new feature.

Since the basisu library interface has changed, this change would not be backwards compatible because of the usage of the hosted files. How should this be handled? Updating the files at https://preview.babylonjs.com/basisTranscoder/ would break existing versions while this PR is not compatible with the current version. This could possibly be handled by uploading the new files under a different name and changing that hardcoded url as well.

Good point. I discussed this with the team offline. We think adding a version to the url is the best solution.
Something like: https://preview.babylonjs.com/basisTranscoder/1/... https://cdn.babylonjs.com/basisTranscoder/1/... (EDIT: we can/should use the cdn path now actually)
Thanks for all the updates!

I prematurely approved. I don't see this addressed. Marking as draft until it is. :-)

I wasn't sure if I should update that since it might be easy to forget to upload the files to the cdn. I thought it might be better for the person that will upload the files to also commit the change.

@RaananW can say for sure, but I think the CDN just mirrors what you merge to the public/basisTranscoder folder.

FYI, the tests fail because of the CDN. If I change the urls locally to existing files, the failing tests pass.

Hmm, good point. For other configurations, we do this to make sure the configuration points to the built version. Can you try adding Basis to this list? @RaananW would be the best person to confirm this, but he is out right now.
https://github.com/BabylonJS/Babylon.js/blob/master/packages/tools/testTools/src/utils.ts#L65-L76

Hmm, good point. For other configurations, we do this to make sure the configuration points to the built version. Can you try adding Basis to this list? @RaananW would be the best person to confirm this, but he is out right now.
https://github.com/BabylonJS/Babylon.js/blob/master/packages/tools/testTools/src/utils.ts#L65-L76
EDIT: here also https://github.com/BabylonJS/Babylon.js/blob/master/packages/tools/testTools/src/visualizationUtils.ts#L17-L38

I added it, it seems to work locally now.

You don't want to remove the old files since that needs to be there for backwards compatibility.

packages/tools/babylonServer/public/basisTranscoder/basis_transcoder.js
packages/tools/babylonServer/public/basisTranscoder/basis_transcoder.wasm

Revert these and I think we are ready to merge.

@vinhui Thanks for doing all this work!

Thank you guys for being so patient and thorough.
And just to double check, the files will automatically get uploaded to the cdn subdomain and the old ones will stay on the preview subdomain?

Both preview and cdn point to the same place right now. 😉

@bghgary - this overwritten the old basis files. Where can the old files be found? I thought we are going to add versioning?

Both versions are now in git. The new version is in public/basisTranscoder/1/ while the old, unchanged ones are in public/basisTranscoder/.

@bghgary - this overwritten the old basis files. Where can the old files be found? I thought we are going to add versioning?

Both versions are now in git. The new version is in public/basisTranscoder/1/ while the old, unchanged ones are in public/basisTranscoder/.

Thanks, i reviewed an older PR that didn't have them in the /1/ directory. That's perfectly fine the way it is now :-)


Store HTML in LimvoDB

I'm looking for a DB storage for an app built on NW.js or Electron, and LinvoDB seems to be suitable.
Long story short: I want to make something like Sublime Text (I don't know exactly how it works, so I will make a guess)
· Creating a new TAB, all content inside is store in localStorage/IndexedDB/...
· When the file needs to be saved, it stores the content in localStorage and then create the file.
· If the file already exists, the localStorage content overwrites it.
You may have question why I'm not using files directly, and it's because the first request: We don't know if the user will save the file, but we don't want to lose all the content if the app is closed.
Searching the web, I find that is bad practice to pass HTML content (is for WYSIWYG editor) through JSON, but I can't think of other solution.. I'd have to use encodeURI and decode when retrieve the data to the #editor or the file saved.
So..
How would you do a «Notepad - Sublime Text» editor using PounchDB, or NeDB, or LimvoDB using Electron/NW.js engine?
I'm using:
· Electron
· Angular
· I don't know yet what DB should I choose.
Thank you!

an advantage with linvodb here is that it's abstract to the storage engine, and you can use anything compatible with leveldown
This means that localStorage/indexedDB/even raw files are all usable, depending on how the storage performs.
In the case you're mentioning, I'd recommend being open-minded about storage
With LinvoDB, you can create a model called "TempFile" or directly "File" and use that.
You can have a dirtyData field on your object, which contains the last state of the data; this would be saved very often, like 1s after last keystroke.
Then, you can have a function, .flushToDisk(), which flushes the file to disk when the user actually saves it, and removes dirtyData.
The benefit of this design is that you can call .save() as often as you want, and keep what the user is typing secure and saved (in localStorage, indexedDB or whatever you want), and call .flushToDisk() when the user actually saves to disk

Nice answer, Ivsthi.
How is this project different from Angular LocalForage?
I'm also considering PounchDB, for sync (online & offline) storage.
How does LinvoDB behaves trying to synchronize data on both sides? (This is more for future feature, but it's wise to build the ground)


Autobuy

Autobuy not working
Not autobuying shovel and rifle

Oh but when it was maintained there was autobuy and today autobuy I think it's same

It changed when the shop was no longer /shop buy.

Oh

Do u any other auto dank that has this feature?

Dank botting is practically dead


unable to install npm package

Type: Bug
this is the error:
bash: npm: command not found
VS Code version: Code 1.80.1 (74f6148eb9ea00507ec113ec51c489d6ffb4b771, 2023-07-12T17:22:25.257Z)
OS version: Linux x64 5.15.108-18910-gab0e1cb584e1
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) m5-6Y57 CPU @ 1.10GHz (4 x 1104)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
2, 1, 0

Memory (System)
6.47GB (3.22GB free)

Process Argv
--unity-launch --crash-reporter-id 08daf08d-421b-4719-8594-de0380ba9e9d

Screen Reader
no

VM
100%

DESKTOP_SESSION
undefined

XDG_CURRENT_DESKTOP
X-Generic

XDG_SESSION_DESKTOP
undefined

XDG_SESSION_TYPE
undefined

Extensions (16)

Extension
Author (truncated)
Version

bracket-pair-toggler
dzh
0.0.3

prettier-vscode
esb
9.19.0

auto-rename-tag
for
0.1.10

code-runner
for
0.12.0

codespaces
Git
1.14.12

remotehub
Git
0.60.0

remote-containers
ms-
0.299.0

remote-ssh
ms-
0.102.0

remote-ssh-edit
ms-
0.86.0

azure-repos
ms-
0.36.0

remote-explorer
ms-
0.4.1

remote-repositories
ms-
0.38.1

remote-server
ms-
1.3.0

vscode-thunder-client
ran
2.9.2

LiveServer
rit
5.7.9

es7-react-js-snippets
rod
1.9.3

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30410667
vsclangdf:30486550
c4g48928:30535728
dsvsc012:30540252
pynewext54:30695312
azure-dev_surveyone:30548225
282f8724:30602487
89544117:30613380
2i9eh265:30646982
showlangstatbar:30737416
vsctsb:30748421
03d35959:30757346
pythonfmttext:30731395
pythoncmv:30756943
fixshowwlkth:30771522
showindicator:30785052
pythongtdpath:30769146
i26e3531:30792625
pythonnosmt12:30779714
pythonidxpt:30784022
pythonnocebcf:30776496
e537b577:30795824
dsvsc013:30795093

/gifPlease

Thanks for reporting this issue! Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, .gif files are preferred as they are displayed inline on GitHub. You may find https://gifcap.dev helpful as a browser-based gif recording tool.
If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording (Developer: Toggle Screencast Mode in the command palette). Lastly, please attach this file via the GitHub web interface as emailed responses will strip files out from the issue.
Happy coding!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Add a Kotlin sample. #1880

This commit transfer spring-boot-minimal into Kotlin.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@cnevinc  Thanks for contributing! I'm happy to review this PR. 😊
And could you sign for CLA?

Could you also use the different package name with the spring-boot-minimal example? It seems like JaCoCo is confused. How about just add .kt to the package names?

Hello, Welcome to contribute code to Armeria! :smile:
Although I don't know much about Kotlin, I saw the code and would like to suggest it.
Rather than just converting, I think that using the generator provided by start.spring.io will be an easier and more user-friendly example.

Rather than just converting, I think that using the generator provided by start.spring.io will be an easier and more user-friendly example.

Good idea. I'll come up with a better example in the other PR. Thank you!

@cnevinc Any news on a follow-up? :wink:

@trustin  @cnevinc May I challenge this?

@heowc Of course! Thanks in advance! :pray:


[6rd] deconfiguring a 6rd tunnel does not delete the underlying _stf interface

Steps to reproduce:

Configure a 6rd tunnel for an interface
Deconfigure it (from the webui set ipv6: none)
Run ifconfig from the shell. The _stf interface will still be there, down but configured.

This means that it is not possible to configure a 6rd tunnel on another interface with the same parameters as we encounter the error: ifconfig: ioctl (SIOCAIFADDR): File exists.
Expected result: the _stf interface is deleted when deconfiguring the tunnel.

Are you sure? I know that the device is not destroyed, yet it would seem to be reused if reconfigured by the GUI. Is this not the case?
On the 19.1 development version we write proper names now for hardware interfaces, e.g. WAN is em1 so 6rd is em1_stf which minimises unwanted collisions further, but the question is if that matters at all since both wan and em1 are unique identifiers in the first place.
If the reuse does not work, we can try the destroy, but we would try avoid this because destroying interfaces have been known to cause kernel panics due to code paths least tested.

I think the reuse does not work because, e.g.:

WAN is configured with ipv6 = 6rd tunnel, wan_stf is created and configured with inet6 (say) 2001:b07:xx:yy::
WAN is then reconfigured with ipv6 = none, wan_stf is brought down but not destroyed. It is still configured with inet6 2001:b07:xx:yy::
LAN is configured with ipv6 = 6rd tunnel, using the same parameters used before. lan_stf is created, but its configuration fails as inet6 2001:b07:xx:yy:: is still assigned to wan_stf.

I hope the issue is clearer now. There is no need to actually destroy the _stf interface when 6rd is deconfigured, it would be enough to remove the inet6 address associated with the interface.

That makes sense. I’ll look into it. 😊

We'll delete it as that is what the reconfigure does anyway. Thanks for spotting this!


Make the navigation bar responsive for mobile devices

In the Navbar, the links are not visible on mobile device

I will like to contribute to this issue . Please assign me this to resolve.

I have fixed the issue!!
Just Check this preview-https://anand911.github.io/sushiksha-first-contributions/index.html

Fixed by @Anand911, Thank you! Closing this!


Allow analysis files from session to be used as input in other analyses

Only supported for session level analyses. Gear-based analyses are also (currently) only allowed at the session level so this doesn't restrict actions any further than they already are.
How the analyses are created hasn't change, for an example (using an analysis level file):
POST /api/sessions/57d1f3cbd73ca10011ff0ee5/analyses?job=true HTTP/1.1
Content-Type: application/json

{
    "analysis": {
        "label": "Megan Analysis 1"
    },
    "job" : {
        "gear": "gear-name",
        "inputs": {
            "not-a-dicom": {
                "type": "analysis",
                "id": "57d1fb632ab3a500241cbe78",
                "name" : "8892_1_1_localizer_montage.zip"
            }
        },
        "tags": ["analysis"]
    }
}

LGTM! Looking forward to working with this.

Remove self._cache as per offline discussion then LGTM :+1:

Fixed up a few things, ready to land when CI hits green.


fix the rdkit.sql.in file

This got screwed up by an overly zealous auto formatting operation in VS code.
I was surprised that the cartridge CI tests continued to pass, but it turns out they didn't.
My script for running them just didn't recognize the failing regressions. So that needs to be fixed in a separate PR.

Merging this since it's essentially just going back to an earlier version of the file (with one function removed)


fips_enabled is set to 0 for ubuntu iso created for byoi/ubuntu-fips

Kairos version:
kairos@localhost:~$ cat /etc/os-release
NAME="Ubuntu"
VERSION="20.04.6 LTS (Focal Fossa)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 20.04.6 LTS"
VERSION_ID="20.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=focal
UBUNTU_CODENAME=focal
KAIROS_NAME="kairos-ubuntu-fips"
KAIROS_VERSION="v9.9.9"
KAIROS_ID="kairos"
KAIROS_ID_LIKE="kairos-ubuntu-fips"
KAIROS_VERSION_ID="v9.9.9"
KAIROS_PRETTY_NAME="kairos-ubuntu-fips v9.9.9"
KAIROS_BUG_REPORT_URL="https://github.com/YOUR_ORG/YOUR_PROJECT/issues"
KAIROS_HOME_URL="https://github.com/YOUR_ORG/YOUR_PROJECT"
KAIROS_IMAGE_REPO="quay.io/YOUR_ORG/ubuntu-fips"
KAIROS_IMAGE_LABEL="latest"
KAIROS_GITHUB_REPO="YOUR_ORG/YOUR_PROJECT"
KAIROS_VARIANT="fips"
KAIROS_FLAVOR="ubuntu"

CPU architecture, OS, and Version:
Linux localhost 5.4.0-1024-fips #28+recert1-Ubuntu SMP Fri May 14 21:30:13 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Describe the bug
Installer built with the instruction from here - https://github.com/kairos-io/kairos/tree/master/examples/byoi/ubuntu-fips
results
kairos@localhost:~$ cat /proc/sys/crypto/fips_enabled
0
kairos@localhost:~$ uname -a
Linux localhost 5.4.0-1024-fips #28+recert1-Ubuntu SMP Fri May 14 21:30:13 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
kairos@localhost:~$

To Reproduce
https://github.com/kairos-io/kairos/tree/master/examples/byoi/ubuntu-fips
Expected behavior
kairos@localhost:~$ cat /proc/sys/crypto/fips_enabled
0

should be 1.
cloud-config was as below
cat /oem/userdata
#cloud-config
install:
  device: /dev/sda
  grub_options:
    # additional Kernel option cmdline to apply
    extra_cmdline: "fips=1"

stylus:
  debug: true
  trace: true

stages:
  initramfs:
    - users:
        kairos:
          groups:
            - sudo
          passwd: kairos

I use a variant of this one with kairos version set to v2.3.2 and osbuilder tools version set to v0.7.11. In that also I see the same behavior.
https://github.com/spectrocloud/CanvOS/tree/main/ubuntu-fips

running this example with the given data (cloud-config) I get a fips system. Well, it kind of. It fails to verify fips mode due to an hmac missing issue but it starts in fips mode.

just one thing missing from the ubuntu example: https://github.com/kairos-io/kairos/pull/1834

@santhoshdaivajna we fixed the missing hmac issue and we can't reproduce the issue you reported. Please provide more information and re-open is the issue persists.


Grammar/style tweaks

@afred, please review.

:+1: @mccalluc merge away, pending suggested wording change above.


Integrate with Hugging Face hub to use their remote storage

Is your feature request related to a problem? Please describe.
Currently, all available models are remotely stored in a google drive, where models have to be uploaded manually. There is no intrinsic way of versioning models, nor does there exist a model card, where users can see what they download.
Describe the solution you'd like
Hugging Face hub is a designated remote storage for models. The library hugginface_hub also offers tools for locally uploading/downloading models, an online catalog as well as services for generating local caches.
Describe alternatives you've considered
Keeping remote storage at google drive.
Additional context
NN

feature added with ci  3991c04


I need a flow to start with a sensor

I have a flow that is linear and sequential as shown below :

new data arrives in SQS
wait for that data to start being written to postgres
wait for the SQS queue to drain
send an email that the flow completed

Eventually, we will have a pre-cursor step (e.g. step 0.) that kicks off a Spark job before waiting for new data in the SQS queue. For now, I do not have that, so I would like my flow to simply reset to the first step. In some ways, I am asking for a circular flow that never ends. This breaks the entire workflow abstraction. On another note, where is the "cron" functionality? Do I schedule airflow commands in cron outside of airflow?

Airflow runs its own scheduler, it's hard to miss it in the docs:
http://pythonhosted.org/airflow/scheduler.html
Is your process a batch job that runs on a fixed scheduled interval? If not Airflow is probably not the right platform. DAG stands for Directed Acyclic Graph. Acyclic means there's no loop. Though its assumed we run the same set of jobs (the DAG) at a scheduled interval, which kind of makes for a large loop around the DAG execution.

Hi!
Yes, it is batch oriented. I'm waiting for some changes in how we submit spark jobs so that I can trigger my flow starting at the Spark job submission. I've covered 4/5 stages of my flow, unfortunately, they are stages 2-5, inclusive.
Yes, the large loop is triggered by a (daily?) schedule. What would be nice would be to have the large loop triggered by different signals. Instead of by a clock (interrupt), by a message on an SQS queue.
This is very whimsical and nothing urgent.

BTW, having worked with Azkaban for 3 years at LinkedIn, I really like the Python DSL approach. I think it lends itself to more possibilities than just declaratively building a DAG of execution that is triggered by a cron.

About the scheduler and cron, I'll clarify. I was expecting to find a calendar widget  - call it UI sugar.
In reading https://github.com/airbnb/airflow/issues/7, it seems that this is instead defined in the python DAG definition code. And essentially, in order to alter the schedule of an existing DAG, we need to alter and re-run the DAG code. So, in a production environment, people are updating their DAG code on some production machine just to change the frequency of their running jobs, which can be problematic if that engineer introduced more changes than just an interval change. Hence, a calendar widget provides the option for limited scope and ease of change.

I haven't thought of frequency of execution as a variable, I always thought of it as a constant. I thought it could evolve to become a more complex constant by eventually adding a feature supporting the cron syntax (5 * * * *) to allow for more complex rules of execution.
Though it seems you are interested in a more on-demand or on-event approach.
In Airflow, a task instance is essentially a specific task run (the unit at which we track state) and this is done by associating a timestamp to the task definition. The scheduler is aware of the DAG's schedule and triggers based on that.
I guess the notion of task or DAG can be de-coupled from its schedule and can be triggered on demand using the API or the CLI, externally.
The on-demand approach seems somewhat easy to integrate to the platform, where you'd need a bit of metadata saying I want this DAG to run for this date or timestamp and the scheduler would pick that up and make sure that tasks get triggered.
The on-event would require some sort of timeless event listener that could leverage the on-demand infrastructure to add an entry to the on-demand list.
It's flipping the current approach around: a fixed schedule with sensors in it VS a sensor that defines the schedule

Yep. BTW, we ended up implementing the spark submission pieces as well, so we now have a working pipeline from spark submission to data import.

We integrated Spark with my main flow, so I now have an end-to-end flow that works, with a few rough-edges remaining.

I need this feature too! I would like to kick off a DAG when a file is upload to S3 bucket. Is anyone has a solution for on-event approach?

No solution yet. Just a thought. With a Notify daemon (to be implemented) that does polling and puts actions into the executor queues when an event happens. lib event (python-libevent) comes to mind

I used a S3 lambda function to trigger an event that starts a docker container in the AWS ECS infrastructure.  So I did not used the Airflow :(

Since PR #540  we support external triggers for DAGs, meaning you can order a DAG run externally, not on a schedule.
The current way to trigger is by using the CLI airflow trigger_dag dag_id. I'm planning on adding a DagRunTrigger operator that receives a function that if it returns an non-None object creates a DagRun for a specified dag_id, the returned object is pickled to the database and made available to the context of all tasks in this DagRun.

Very cool.


Add a call to release all memory used by UHDM

After UHDM has been translated to the native application data-structure (Yosys,Verilator....), before invoking the application business logic, release UHDM memory which should not be needed anymore at that point.

@kbieganski to test in Yosys when this is ready.

Probably not at this stage of development as we want first the dust to settle and the Yosys to compile all the SystemVerilog.
But then a possible future idea for users of UHDM serialized data: having a generated lightweight API that has the same interface as read/write UHDM, but only providing read-only methods that then just delegates to the underlying Capnproto data ? The capnproto data can be loaded as block into memory (or even memory mmap()-ped on OSes that support that), and released at once.
Since the backing memory is stable, we even can hand out std::string_views to avoid any copying and create expensive temporary objects.

@hzeller, If you feel like it, please open another issue for the idea above.
This issue is closed.
@kbieganski, do call SURELOG::shutdown_compiler function when you are done populating UHDM data into Yosys, prior to invoque Yosys business logic. UHDM will be purged from memory.


Unable to npm install pump in the samples/ directory.

Environment details

OS: macOS High Sierra v10.13.2
Node.js version: v10.0.0
npm version<EMAIL_ADDRESS>(I also tried<EMAIL_ADDRESS>dialogflow version: v2? I cloned it today

Steps to reproduce

clone the repo
cd samples/
npm install (or npm install pump, which seems to be the package causing the specific issue)

Get this error message:

npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/fsevents):
npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename '/Users/michael.wang/Workspace/dialogflow-nodejs-client-v2/samples/node_modules/.staging/fsevents-459b5284/node_modules/set-blocking' -> '/Users/michael.wang/Workspace/dialogflow-nodejs-client-v2/samples/node_modules/.staging/set-blocking-abdd6c3c'
npm ERR! path /Users/michael.wang/Workspace/dialogflow-nodejs-client-v2/samples/node_modules/.staging/dialogflow-2c1f8a43/node_modules/@mrmlnc/readdir-enhanced
npm ERR! code ENOENT
npm ERR! errno -2
npm ERR! syscall rename
npm ERR! enoent ENOENT: no such file or directory, rename '/Users/michael.wang/Workspace/dialogflow-nodejs-client-v2/samples/node_modules/.staging/dialogflow-2c1f8a43/node_modules/@mrmlnc/readdir-enhanced' -> '/Users/michael.wang/Workspace/dialogflow-nodejs-client-v2/samples/node_modules/.staging/@mrmlnc/readdir-enhanced-f9b82517'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent
npm ERR!      /Users/michael.wang/.npm/_logs/2018-05-03T23_20_02_953Z-debug.log

Posting this to flag the issue, also to update with a solution if I am able to find one.

@itsmichaelwang Having exactly the same issue:
Environment details

OS: macOS Sierra v10.12.6
Node.js version: v8.11.4
npm version: v5.6.0

Steps to reproduce

clone the repo
npm install
cd samples/
npm install

Error message

npm ERR! path /Users/../Documents/Code/Git/dialogflow-nodejs-client-v2/samples/node_modules/.staging/dialogflow-f99e8d81/node_modules/@babel/code-frame
npm ERR! code ENOENT
npm ERR! errno -2
npm ERR! syscall rename
npm ERR! enoent ENOENT: no such file or directory, rename '/Users/../Documents/Code/Git/dialogflow-nodejs-client-v2/samples/node_modules/.staging/dialogflow-f99e8d81/node_modules/@babel/code-frame' -> '/Users/../Documents/Code/Git/dialogflow-nodejs-client-v2/samples/node_modules/.staging/@babel/code-frame-a76a8747'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent
npm ERR!      /Users/../.npm/_logs/2018-09-19T07_42_36_817Z-debug.lo

Looking forward for a solution!

@itsmichaelwang Try deleting /samples/package-lock.json and then retry to run npm install pump.
Successfully installed.


Question about data scaling

Hi, I've been playing around with this repo and noticed that, at least for my datasets, using the regular scaler completely breaks the model, even if sigma data is adjusted to 1. Additionally, the sigma data produced by the min max scaler is closer to 0.33 but you have chosen 0.5. I was wondering if you could explain your thought process behind the choice of the scaler and sigma data value?

Hi,
Thanks for your interest in this repo. Sorry for the late reply, I just noticed your post.
My choice of $\sigma_{\text{data}}$ das was based on the edm framework from: https://arxiv.org/pdf/2206.00364
I never assumed, that it was related to the std of the underlying training data distribution, which makes a lot of sense after thinking about it now. Upon reading your comment I  read the edn paper again and its mentioned in one of the first parargraphs.
Back then I was trying to find a good set of  hyperparameters for different settings, that work without changes and just set a few parameters constant including $\sigma_{\text{data}}=0.5$, because it was hard to tune all them in parallel.
I guess I have to experiment  now more with  $\sigma_{\text{data}}$ depending on the actual action distribution.
Thank you for pointing that out!
By regular scaler do you mean zero mean unit variance or the MinMax Scaler in range of [-1,1]?
The Zero-Mean scaler does not work well for EDM at all, I can only recommend MinMax. Or did I missunderstood your question?

As a general tipp for hyperparameter choice:
For my current work, I am still using the same Beso Framework with $[-1, 1]$ MinMax Action Scaling and DDIM Sampling, but I found, that with LogLogistic Training Sampling the noise range of $[0.001,80]$ to work well in all of my new experiments in simulation and real world with action-chunking diffusion policies. I tested it with the block push and relay kitchen here, but somehow it does not work as well in these two environments.
But I recommend these values as a starting point, that I had a lot of success with: https://openreview.net/pdf?id=Pt6fLfXMRW
Hope that helps!

Thanks for the reply :) Good to know the Gaussian scaler being broken isn't just me doing something wrong. Regarding the log logistic parameters, I'm assuming you use the same max to initialise your sampling. 80 seems much higher than what I've been using ( 1 ), and use used previously but you're saying your results show that it works well?

Hi,
yes it works well with the noise range of [0.001,80] which is the standard for most edm diffusion image generation models such as the new edm2 and more. I tried to make it work with this range to have the chance to work on unified models in the future. However, all new models I am using are either predicting 10 actions at once or 20 actions while BESO does single action prediction. One guess of mine is that higher noise levels work better with higher denoising dimensions. I tested the stuff in 1D toy takes in my consistency Repo and there 80 is also not ideal for 1D stuff and noise ranges of [0.01,1] work better there too. However this is just my experience without proper analysis of this issue.

Ok nice I tried this too and it really improved my results. One last question, did your classifier guided sampler code work? I need to use it for my own work, wondering if you had any success with it?

Happy to hear that! Looking forward to your project, let me know when it published.
Regarding CFG, yes it works in this repo. I have trained cfg policies for both environments, where you can control the amount of goal guidance for the model. I created wrapper for sampling. However compared to default models, the models usually performed a bit worse than default goal-conditioned ones.
I summarized my findings in the paper experiment section.

Oh sorry, I meant classifier guidance, not classifier-free. You have code for both in your project. Did the classifier guidance code work?

So the code should work, since its adopted form image-based codebase, where classifier guidance was used. I never worked a lot with Classifier-Guidance myself, since you need an action gradient, that is related to your goal, which did not make a lot of sense in my project to learn $f(g,a)$ with some additional model. However, given the success of this method in image generation and some successful usages in RL it should work here too.
I experimented with other ideas to combine ebms with diffusion, which was not so successful.
There are some recent papers, which maybe could be relevant for your setting:
https://arxiv.org/pdf/2404.14743
https://arxiv.org/pdf/2404.06356v1


Can you add color to these things

string - vskript.type.attribute
true and false (there own colors)
and yeah that pretty much it ty!

Thanks for your feedback. I will reflect this in the next update.


BUG element with no Blog selected will not load cms fields when visited later

If a block is setup with no blog selected, the chained call to Categories() causes the error Error displaying the edit form for this block.

This change will need to be merged up to the 2.2 branch.


fix: 4549 - correct "forgot password" checks

What

The checks of the returned status of "resetPassword" were flawed, as they compared a Status to an int.
This is fixed now.
We still have a problem on the off-dart side, as we compute the status code from the content of the message. That was OK as long as we stayed in English, that's not possible anymore with the localization (localized emails) recently introduced.

Screenshot

with country + language
without country nor language

Part of

#4549

Impacted file

forgot_password_page.dart: corrected the checks.

Codecov Report

Merging #4558 (87d644b) into develop (ad6303b) will increase coverage by 0.03%.
Report is 6 commits behind head on develop.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #4558      +/-   ##
===========================================
+ Coverage    10.31%   10.35%   +0.03%
===========================================
  Files          296      296
  Lines        15304    15332      +28
===========================================
+ Hits          1579     1587       +8
- Misses       13725    13745      +20

Files Changed
Coverage Δ

...ib/pages/user_management/forgot_password_page.dart
62.96% <0.00%> (+0.76%)
:arrow_up:

... and 14 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Thank you @g123k for your review.
Today I'll PR in off-dart in order to fix completely the issue.

Thank you @g123k for your review.
Today I'll PR in off-dart in order to fix completely the issue.

+1 my fix, was only to have something better for the release


mysql_example.py - AttributeError: 'module' object has no attribute 'backport'

Hi,
Trying to run through the mysql_example.py, running into this error:
$ python mysql_example.py  INFO:root:Generating grammar tables from /usr/lib/python2.7/lib2to3/Grammar.txt INFO:root:Generating grammar tables from /usr/lib/python2.7/lib2to3/PatternGrammar.txt reading from  mysql_example_settings blocking... creating blocking_map database creating inverted index writing blocking map Traceback (most recent call last):   File "mysql_example.py", line 221, in <module>     pool = dedupe.backport.Pool(processes=2) AttributeError: 'module' object has no attribute 'backport'
any ideas?
dedupe 1.6.15
Ubuntu 16.04, scripts executed in virtualenv
Thanks

Nevermind, fixed it by adding
import dedupe.backport as backport back into api.py


Specifying json-file log driver to the daemon does not work

On Docker version 1.8.1, build d12ea7
While starting the docker daemon, If I specify the log-driver=json-file and --log-opts max-file=50 --log-opt max-size=50k, It did not rollover the log files.
While starting the docker daemon, If I specified the log-driver=syslog, then it works fine.

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

I have also had the same issue.  It seems that the log-opt parameters are not properly parsed in daemon mode.
When I provide a wrong log-opt value when running a container, it validates the value and returns an error:
$ docker run --log-driver=json-file --log-opt foo ubuntu:trusty bash
Error response from daemon: Cannot start container cae5e14df7580d9a83431d9ef49a0aec71f669109b7dc52a188a3ccca6e635d0: Failed to initialize logging driver: unknown log opt 'foo' for json-file log driver

When I do the same thing when starting the docker daemon, it silently continues:
$ sudo docker daemon --log-driver=json-file --log-opt foo
INFO[0000] [graphdriver] using prior storage driver "aufs"
INFO[0000] Option DefaultDriver: bridge
INFO[0000] Option DefaultNetwork: bridge
INFO[0000] Listening for HTTP on unix (/var/run/docker.sock)
WARN[0000] Running modprobe bridge nf_nat br_netfilter failed with message: modprobe: WARNING: Module br_netfilter not found., error: exit status 1
INFO[0000] Firewalld running: false
WARN[0000] Your kernel does not support swap memory limit.
INFO[0000] Loading containers: start.......
INFO[0000] Loading containers: done.
INFO[0000] Daemon has completed initialization
INFO[0000] Docker daemon                                 commit=d12ea79 execdriver=native-0.2 graphdriver=aufs version=1.8.1

docker version:
Client:
Version:      1.8.0
API version:  1.20
Go version:   go1.4.2
Git commit:   0d03096
Built:        Tue Aug 11 17:17:40 UTC 2015
OS/Arch:      linux/amd64
Server:
Version:      1.8.0
API version:  1.20
Go version:   go1.4.2
Git commit:   0d03096
Built:        Tue Aug 11 17:17:40 UTC 2015
docker info:
Images: 4
Storage Driver: devicemapper
Pool Name: docker-8:3-71722731-pool
Pool Blocksize: 65.54 kB
Backing Filesystem: xfs
Data file: /dev/loop0
Metadata file: /dev/loop1
Data Space Used: 1.991 GB
Data Space Total: 107.4 GB
Data Space Available: 11.5 GB
Metadata Space Used: 1.72 MB
Metadata Space Total: 2.147 GB
Metadata Space Available: 2.146 GB
Udev Sync Supported: false
Deferred Removal Enabled: false
Data loop file: /var/lib/docker/devicemapper/devicemapper/data
Metadata loop file: /var/lib/docker/devicemapper/devicemapper/metadata
Library Version: 1.02.82-git (2013-10-04)
Execution Driver: native-0.2
Logging Driver: json-file
Kernel Version: 3.10.0-229.11.1.el7.x86_64
Operating System: CentOS Linux 7 (Core)
CPUs: 4
Total Memory: 979.7 MiB
Name: vm-yangheng
ID: B3AI:6V65:ZSIQ:AWX2:BLCI:ZLUE:UJIO:STUO:ZBSO:L3SO:ZNJF:MR5B
WARNING: bridge-nf-call-iptables is disabled
WARNING: bridge-nf-call-ip6tables is disabled
uname -a:
Linux vm-yangheng 3.10.0-229.11.1.el7.x86_64 #1 SMP Thu Aug 6 01:06:18 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux
Steps to Reproduce:
1、docker daemon --log-driver=json-file --log-opt max-size=10k
2、docker run -i -t xxx:xxx (Container_id)
3、make log(exp. echo xxxxxxxxxxxxxxxxx in Container )
Actual Results:
Container_id-json.log can exceed 10k,It did not rollover the log files.
1、docker run -i -t --log-driver=json-file --log-opt max-size=10k
2、It works in container run opts
Expected Results:
It can rollover the  log(Container_id-json.log) files.
Additional info:

This should have been fixed in #15611, you can try the master branch.

Closing b/c I'm fairly certain this is resolved by the mentioned PR.
Ping here if you find otherwise! Thanks!


Hydrotools nwis-client requires python 3.7

The hydrotools nwis-client requires a minimum python version of 3.7.  This means hypy needs to document a similar minimum version.
Current behavior
With latest version of hydrotools, hypy nwislocation doesn't work with python 3.6.
Steps to replicate behavior (include URLs)
Try running unit tests with python 3.6

This is because of the usage of aiohttp-client-cache. See here specifically for the downstream issue. At the surface level, it seems that the issue is just with aiohttp-client-cache's use of type hint features added in py37. It may be worth exploring this to see about a potential way around this and opening a PR there to lower the version requirement.

It's probably in our best interest to move to python 3.7 or greater as an organization. Python 3.6 will reach EOL this December.

@aaraney Python 3.7 contains a large number of asyncio-specific improvements: https://docs.python.org/3/whatsnew/3.7.html#whatsnew37-asyncio
So it's highly recommended to use 3.7+ for async applications. It might be possible to make aiohttp-client-cache compatible with 3.6, but like you mentioned it will be EOL soon.


unable to load local weight

I have manually downloaded the model weights from Hugging Face and tried fine-tuning the model using the following command.
bash scripts/vl_finetune.sh ./groma-7b-pretrain ./train_history/
But the program still tries to access the weights from the website.
I set the following output for debug.

And this is the output:

It seems that the program is unable to local model weight?
Looking forward to your reply.

Sorry, the issue seems to be occurring here.

So what is the vis_encoder_path？

Thanks for the feedback. The bug occurs as the program is looking for a local DINOv2-L checkpoint to initialize CustomDDETRModel. This is not an expected behavior. A quick fix is to delete vis_encoder_path: checkpoints/dinov2-large in groma-7b-pretrain/config.json. I will fix the initialization logic soon later.

"Thank you for your prompt feedback. I have encountered a new issue. Do you know why this is happening?"

I think this error comes from a failed installation of mmcv. Could you clarify the relationship between the mmcv folder in your repository and the mmcv package?

We inherited the mmcv folder from GPT4ROI. I think it is originated from mmcv==1.4.7.


Add type annotations

Running mypy on code that uses the latest version of vcrpy fails with the error message "module is installed, but missing library stubs or py.typed marker".  Please add type annotations to this project and include a py.typed file in the package to indicate typing support to mypy.

Is there a particular reason why the py.typed isn't added?

Is there a particular reason why the py.typed isn't added?

Unfortunately, that's not sufficient. Type annotations need to be added throughout the code as well.


Changed position to position + 1 to fix logic

Due to lists starting in position 0 instead of 1, the 0th and 1st element loaded at the same time, with this subtle change everything loads as expected.
The only issue is that the 1st item will load at duration + delay instead of just duration.

Added resetdelay to avoid listview.builder and gridview.builder from tending to infinity.
Issue related https://github.com/mobiten/flutter_staggered_animations/issues/10


[release-4.17] OCPBUGS-44628: Implement Managed Identities in HyperShift

What this PR does / why we need it:
This pull request introduces the ARO HCP feature to use managed identities in 4.17.z. This pull request backports the following PRs:

https://github.com/openshift/hypershift/pull/4861
https://github.com/openshift/hypershift/pull/4960

Which issue(s) this PR fixes:
Fixes OCPBUGS-44628
Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

/test all

/hold
Still need to backport lots of PRs


new version of blobstore request to release 3.2.2

Cache volume and disk in Proxy, remove Redis.
Ignore broken disk in access put/get requests.
Read essential bytes if ranged data is a segment of one shard.

Codecov Report

Merging #1799 (70fdbeb) into master (37905fb) will increase coverage by 0.24%.
The diff coverage is 75.38%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##           master    #1799      +/-   ##
==========================================
+ Coverage   47.71%   47.96%   +0.24%
==========================================
  Files         455      455
  Lines       78203    78903     +700
==========================================
+ Hits        37316    37843     +527
- Misses      37955    38110     +155
- Partials     2932     2950      +18

Impacted Files
Coverage Δ

blobstore/access/stream_alloc.go
58.82% <0.00%> (ø)

blobstore/api/blobnode/client.go
85.71% <ø> (ø)

blobstore/api/clustermgr/client.go
0.00% <0.00%> (ø)

blobstore/api/clustermgr/config.go
0.00% <0.00%> (ø)

blobstore/api/clustermgr/disk.go
0.00% <0.00%> (ø)

blobstore/api/clustermgr/kv.go
0.00% <0.00%> (ø)

blobstore/api/clustermgr/proto.go
0.00% <ø> (ø)

blobstore/blobnode/base/qos/qos.go
49.20% <0.00%> (ø)

blobstore/blobnode/base/workutils/stripe_utils.go
85.71% <ø> (-2.39%)
:arrow_down:

blobstore/blobnode/config.go
22.51% <0.00%> (-26.76%)
:arrow_down:

... and 78 more

... and 21 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

close #1741


[Bug]: /api/v1/collections/actions is taking 21.2 seconds

Is there an existing issue for this?

[X] I have searched the existing issues

Description
The response time of this API is really high and is contributing to slow page loads. Ideal response time for this API should be < 500ms for all cases.
The details of steps to repro this are in this notion doc
Steps To Reproduce
NA
Public Sample App
No response
Environment
Production
Issue video log
No response
Version
Cloud

@rajatagrawal I can look at this if not addressed.

this api use too many time if js action is too long.


[HAXdesktop] File submenu item should publish HAX sites to a remote git repo

This would involve...

Going into the main.js file within the HAXdesktop repo
Adding some lines of code within the click function for the submenu item labeled "Publish"
My approach involved having this code essentially build a shell script using node-powershell with system commands and git commands which would be invoked on click and then its output would be console.logged in case an error occurs
Consider that there is no variable in the script tracking the currently "Opened" directory; might need to be added
Consider also that there is no variable storing a path/URL to any remote repo; also probably should exist for these purposes
Update the comments I left related to this issue also

https://haxtheweb.org/site.json the JSON Outline Schema spec has publishing info in it. I'd suggest firing up haxcms https://github.com/elmsln/haxcms using ddev or docker.

publishing works on command line, desktop app should add things like this but currently it completely aligns /w rest of projects so really, we need nodejs to allow publishing via UI and then move from there


putting to https://pub.dev/

Hello hanisimo,
do you plan to put this as a package to https://pub.dev ?, as null safe package?
Kind regards,

Hello Göksel,
Thank you for your message,
Actually, no, I do not have a plan currently to put this as a null safe package to https://pub.dev.
Thanks for asking 🙂 Best regards and have a beautiful day,

Hello Göksel,
Thank you for your message,
Actually, no, I do not have a plan currently to put this as a null safe package to https://pub.dev.
Thanks for asking 🙂 Best regards and have a beautiful day,


UISwitch grey_tap() flakiness

Switch is defined as such:
@IBOutlet var callForwardingSwitch: UISwitch! {
       didSet {
        callForwardingSwitch.accessibilityIdentifier = "unique switch string"
       }
   }

Test is defined as such:
EarlGrey.selectElement(with: grey_text("appeared text"))
    .assert(grey_notVisible())
EarlGrey.selectElement(with: grey_accessibilityID("unique switch string"))
    .perform(grey_tap())
EarlGrey.selectElement(with: grey_text("appeared text"))
    .assert(grey_sufficientlyVisible())
EarlGrey.selectElement(with: grey_accessibilityID("unique switch string"))
    .perform(grey_tap())

I start the app with the switch in the off position, and when it is turned on, my logic says a new text field appears. The asserts work fine, but sometimes the taps go off and sometimes they don't.

Found api method grey_turnSwitchOn(...), this works as expected.


Add Vulnerability Disclosure Policy to Footer

Resolves https://github.com/CDCgov/prime-simplereport/issues/1986

@nullflux looks like everything else in the footer is alphabetical except for the vulnerability policy. can we move it to the end?

@Rebecca-LM This was already merged at the time of your comment, so I've opened PR #189 with that change


i installed maatwebsite's laravel excel in my project and after that i am getting error via git actions that Expected status code 200 but received 500. Failed asserting that 200 is identical to 500.

1⃣ Is the bug applicable and reproducable to the latest version of the package and hasn't it been reported before? (Currently 3.1.x)
2⃣ What version of the package, Laravel and PHP do you use? Please provide the FULL version number.
3⃣ Describe your issue. Please be short, but concise.
4⃣ How can the issue be reproduced? Please provide easy-to-reproduce steps (repository, simple code example, failing unit test).
5⃣ What should be the expected behaviour?
6⃣ Have you filled in the entire issue template? If not, your issue will be closed. Thanks for using the package! 🙌

Please reopen with the issue template filled in. As mentioned in point 6, issue will be closed without.


Add 'Notepad++' to text editors

It is not secret knowledge.

On Sun, Jun 25, 2023 at 9:34 AM JD C @.***> wrote:

@.**** approved this pull request.
Trying this wondering can I fix it if something breaks.
—
Reply to this email directly, view it on GitHub
https://github.com/trimstray/the-book-of-secret-knowledge/pull/390#pullrequestreview-1497069314,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BAMCPJMOCEOWPBCPMGJBKKTXNA5ABANCNFSM6AAAAAAVD3GRVY
.
You are receiving this because you are subscribed to this thread.Message
ID: <trimstray/the-book-of-secret-knowledge/pull/390/review/1497069314@
github.com>

Thanks very helpful

No xox type discussion...

hi i use notepad basic for my bash script and it is usefull


Remove CartDataService from CheckoutService

QA: Checked that CartDataService is removed from CheckoutService and can go through checkout.


Category pagination not showing on Github but showing locally

Thanks for the awesome repo.
I was able to get pagination to work for two collections locally.
When I push my _site folder to github, the files and index.html are in the collection folder.
However, the collection root page does not show.
For example, here is the "round 2" collection root on the local server:

And here it is served at github.

I am uploading the site after bundle exec jekyll serve and the site folder is on github with the index. I'm not sure where I'm going wrong here. I tried changing the permalinks, but nothing I could come up with solved it.
I'm not sure if this is a paginate issue, a github issue, or (more likely) operator error.

Nevermind. I need to do something different to cause github to not try to generate my page from the old jekyll code that I .gitignore now but is still there. Closing.


Basic IFS up- and download functionality

Changes
Basic IFS upload and download functionality implemented as requested in #45.
Very simple but a start.
You're able to download files from the IFS browser with right-click and "Download".
There are two way's to upload files:

Use the upload icon in the IFS browser header
Use right-click and "Upload" on a directory

During development, I made a note of the following points to consider for the future:

Does it work correctly on Windows? I've tested it on macOS. Maybe there are some path specialties on another OS?
I've not tested the up- and download of files with a large size. The IBMiContent class is very basic at the moment and currently not supporting progress tracking.
Up- and downloading of directories didn't work yet
Only utf8 files are supported at the moment because of the configurations in IBMiContent. Maybe we've to create a new module or we've to extend the IBMiContent class.

Checklist

[x] have tested my change
[x] updated relevant documentation
[x] Remove any/all console.logs I added
[x] eslint is not complaining
[x] have added myself to the contributors' list in the README
[x] for feature PRs: PR only includes one feature enhancement.

This is awesome! I am going to do a review of this tomorrow.
Thanks @szsascha!

About to review this today!

@szsascha Other than the one issue I noted about, this is an awesome PR! Great work and a great feature.
If you're happy with it after you've made my recommended fix, then let me know and we can merge. If you'd like to add more to it, let me know. Maybe the following stuff can be done in another PR?
As a reference to all my notes, the library we are using is node-ssh: https://github.com/steelbrain/node-ssh#readme

I've not tested the up- and download of files with a large size. The IBMiContent class is very basic at the moment and currently not supporting progress tracking.

Tracking progress isn't something we've needed before, because we're really just working with small (<5m) source files most of the time. Maybe you could look into the library we are using to see if they have support for tracking progress.

Up- and downloading of directories didn't work yet

The node-ssh library does support this. You should see about extending IBMiContent to support it also.

Only utf8 files are supported at the moment because of the configurations in IBMiContent. Maybe we've to create a new module or we've to extend the IBMiContent class.

I believe extending the class would be nice. Maybe downloadStreamfile and uploadStreamfile could just have an extra parameter so we could pass the encoding we want, with a default of utf8?
async downloadStreamfile(remotePath, encoding = `utf8`) {
    const client = this.ibmi.client;
    let tmpobj = await tmpFile();
    await client.getFile(tmpobj, remotePath);
    return readFileAsync(tmpobj, encoding);
}

@worksofliam
Thanks a lot for your review, feedback and answers.
Sounds like there's a lot of potential there. Maybe in the future there will be some contributions from me :)
From my point of view, the PR can now be merged.

@szsascha awesome! I hope we will see more contributors too!
I will do another quick test with your change and we'll get it merged in today!
You rock!

I also added some additional commits to:

Use the client to upload/download. This means it won't even touch the encoding and will keep to whatever the file is.
Change the command name to follow the standard of the other IFS commands.


Smooth scrolling not working

I don't know if this is an expected behaviour.
By default (without this extension) Chrome smooths scroll and this is easier on the eyes.
With this extension, scrolling becomes too instantaneous and not smooth at all.

I will look into it but I'm unsure if it can be emulated.

Smooth scrolling is not supported by this extension as of now. This might change if Google decides to properly support it in the Linux version of Chrome.


[Market Page] - Keep asset persistent on tab view

I think the tab on top should show the asset of the market I'm currently in rather than change to different markets all the time. Traders usually have open tabs for markets they have open positions/orders or just for markets they want to track across different exchanges so we should not change them imo.
For instance here I'm in ATOM/USDT PERP but I see the INJ/USDT PERP price on the tab.

@Tofel For your reference as well

Fixed


Browsing by mouse wheel

[low prio enhancement]
It would be nice to be able to browse photos by mouse wheel. It's available in most popular non-webapp browsers.

Thanks for the suggestion, but browsing via mouse wheel is not planned.


test,hack: Refactor the e2e testing suite to use the deploy metering package.

Overview:
This would refactor the e2e package to handle both deploying metering and run the reporting tests. This PR adds a deploy framework that's in charge of ensuring all of the metering resources are ready to proceed to run the reporting tests and teardown after the testing phase has completed.
It's important to note that the teardown method for the deploy framework calls a bash script, so now the default behavior for when tests complete is to store logs first, then output the test results.
TODO:

[ ] Update hack/ scripts to handle make e2e-local
[ ] Log test output (junit reports)
[ ] Avoid harcoding the reporting framework flags
[x] Pass an overall testing directory to the deploy framework
[ ] Log resource and containers logs to a tmpdir/specified path + random prefix

Follow-up PRs:

Pass clientsets to reportingframework.New instead of that method creating the clientsets explicitly
Support a partial install of metering
Support running tests on an existing namespace
Support validating storage spec without installing metering.

No CI tests on feature branch, so closing.


Prisma4 jest pnpm

Re-build our project.

using PNPM instead of Yarn, learn
using the Jest framework to add some tests to our project.
using GitHub Actions for running tests.
upgrade to support Prisma 4.
using graphql-parse-resolve-info package in PrismaSelect plugin

[docs] need to update
[breaking changes]:  we have a lot of breaking changes

The config file name changed from pal.(js|json) to be pal.config.(js|json) to fix an issue with windows #230
PrismaDelete plugin totally removed and we don't need it now Prisma support this option.
remove some options from the nexus paljs plugin

 // send custom dmmf if you have custom generated client path for generate input types
  dmmf?: DMMF.Document[];
  // take an array of field names to exclude from any input type
  excludeFields?: string[];
  // take a function and the input object as arg and return array of fields you want to generate
  filterInputs?: (input: DMMF.InputType) => DMMF.SchemaArg[];
  // by default when we create update inputs you will set data like {username: {set: "Ahmed"}} by making this option true you will be able to use it like {username: "Ahmed"} without set.
  // but you will also lose these options for number fields
  // increment: x: Adds x to the current value
  // decrement: x: Subtracts x from the current value
  // multiply: x: Multiplies the current value by x
  // divide: x: Divides the current value by x
  // set: x: Sets the value to x (equivalent to data: { age: 18 })
  doNotUseFieldUpdateOperationsInput?: boolean;

We added them to pal.config.js
excludeInputFields?: string[];
filterInputs?: (input: DMMF.InputType) => DMMF.SchemaArg[];

...  will add more later

@YassinEldeeb, can you do a review

That's pretty interesting, definitely wanna review it tomorrow's morning

Interesante

Estoy trabajando en windows y obtengo este error :(

when I add (fullTextSearch) in the prisma schema if it generates the types but it gives me a server error and it doesn't show me the data could you help me thanks

when I add (fullTextSearch) in the prisma schema if it generates the types but it gives me a server error and it doesn't show me the data could you help me thanks

Please open new issue with that error
And be note that we never test with the preview features so I think you need to find the bug yourself or wait until we find it and fix it
thanks

Thank you !!
El sáb, 26 nov 2022 a las 12:10, Ahmed Elywa @.***>)
escribió:

[image: Captura-de-pantalla-(96)]
https://user-images.githubusercontent.com/67123054/204099425-2ad4771e-99d8-4530-8dbf-11380485ccef.png
when I add (fullTextSearch) in the prisma schema if it generates the types
but it gives me a server error and it doesn't show me the data could you
help me thanks
Please open new issue with that error
And be note that we never test with the preview features so I think you
need to find the bug yourself or wait until we find it and fix it
thanks
—
Reply to this email directly, view it on GitHub
https://github.com/paljs/prisma-tools/pull/284#issuecomment-1328081938,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQADO3QVU2SOZ26NH754LV3WKJAAHANCNFSM6AAAAAARWJ7KY4
.
You are receiving this because you commented.Message ID:
@.***>


[Remaster][Data Error]Dragon Form spell has pre-remaster rules text

Dragon Form got traits, traditions & flavor text changed, but mechanics are pre-remaster only.
Current Foundry version:

PDF:

It makes sense to keep old dragons in spell as is, but then new dragons have to be added too.

Please note that if you want to have the CRB options for this spell after the update which includes the Remaster changes for this, you will need the Legacy Content module.

"Tradition resistance" is still missing from updated version - both in text and in effect (new part of that spell which gives additional resistance if casting tradition corresponds to dragon tradition).


Fix Copy/Paste Error

https://gyazo.com/699a1e3a4336f336894b5107d82bb9c8

Sorry to disappoint, looking forward to more PRs from you, however, the issue was previously fixed already on the master branch. 😅


Remove reference to HYPERSHIFT_MANAGEMENT_KUBECONFIG on env.sh as emp…

…ty, because if not, there is no way to set the var as env var
Description
With current configuration, we can only set the var on the file, any setting from the env will be overrrided as ""
Fixes

Good to be like this?
export HYPERSHIFT_MANAGEMENT_KUBECONFIG=${HYPERSHIFT_MANAGEMENT_KUBECONFIG:-""}

Good to be like this?
export HYPERSHIFT_MANAGEMENT_KUBECONFIG=${HYPERSHIFT_MANAGEMENT_KUBECONFIG:-""}

Yeah, better option, updated


don't write "Transfer-Encoding: chunked" when Content-Length is set

this commit fixes #1648

I'd argue the other direction: I am actually sending a stream towards the HTTP server. This used to work just fine with an old version of requests. Sometime requests started adding a magic "Transfer-Encoding" header and dropping the known length information.
What's more it's not actually using chunked encoding but just pushes the stream through. After fixing that I found out that the server I am posting to refuses chunked transfer encoding when posting.
I would really like to be able to use session.post again for my simple use case. requests boasts in its README how easy it is to do simple things.

@Bluehorn you failed to provide us:

Code to reproduce your issue
The versions you tested
A server to test against

Given you've provided us nothing to work with, we can't help you.

@sigmavirus24: I do not need help, I have a trivial patch that makes requests use the Content-Length again. After our code base works with the current requests for a while we will probably just do what you suggested:

Don't just use the plain requests API, instead prepare a request yourself (which is now infinitely easier) and remove the header

I just liked the approach that the caller can set the headers without having requests overwrite/delete them better.


create new geoCoding base service that caches api calls

create new geoCoding service that caches api responses. ( since geocoding is done in async way , there may still be more that one call to the api when ingesting file untill cache is saved in redis)

I created https://github.com/Vizzuality/landgriffon/pull/269 which pick up on both the existing code structure and you extension of it, and refactors things so it's a bit more structured.
Also: some tests would be welcome.

Implementation present in DB extended and merged in: https://github.com/Vizzuality/landgriffon/pull/269
Closing this, thanks!!


Scalar arrays and oindex

import zarr
store = zarr.DirectoryStore('data')
r = zarr.open_group(store=store)
z = r.full('myArray', 42, shape=(), dtype='i4', compressor=None)

print(z.oindex[...])

Problem description
The above code raises an exception
Traceback (most recent call last):
  File "/home/tom/PycharmProjects/starling-hcs/forest-penrose-zcube/examples/example_raster.py", line 10, in <module>
    print(z2.oindex[...])
  File "/home/tom/anaconda3/lib/python3.6/site-packages/zarr/indexing.py", line 601, in __getitem__
    return self.array.get_orthogonal_selection(selection, fields=fields)
  File "/home/tom/anaconda3/lib/python3.6/site-packages/zarr/core.py", line 838, in get_orthogonal_selection
    return self._get_selection(indexer=indexer, out=out, fields=fields)
  File "/home/tom/anaconda3/lib/python3.6/site-packages/zarr/core.py", line 1015, in _get_selection
    drop_axes=indexer.drop_axes, fields=fields)
  File "/home/tom/anaconda3/lib/python3.6/site-packages/zarr/core.py", line 1558, in _chunk_getitem
    assert len(chunk_coords) == len(self._cdata_shape)
AssertionError

Looks like this indexer is not handling properly the case of scalar arrays.
Version and installation information
python 3.6
zarr 2.2.0
numcodecs 0.5.5
Ubuntu
Thank you !

Thanks Thomas. I'm not 100% sure it makes sense to use oindex (or vindex)
on a scalar. But maybe the best thing to do here would be to check within
oindex and vindex if the array is scalar, if so to pass on to the scalar
indexing code already in place to handle indexing via getitem. PR would
be welcome.
On Mon, 24 Sep 2018, 16:36 Thomas Coquet<EMAIL_ADDRESS>wrote:

import zarr
store = zarr.DirectoryStore('data')
r = zarr.open_group(store=store)
z = r.full('myArray', 42, shape=(), dtype='i4', compressor=None)
print(z.oindex[...])
Problem description
The above code raises an exception
Traceback (most recent call last):
File "/home/tom/PycharmProjects/starling-hcs/forest-penrose-zcube/examples/example_raster.py", line 10, in
print(z2.oindex[...])
File "/home/tom/anaconda3/lib/python3.6/site-packages/zarr/indexing.py", line 601, in getitem
return self.array.get_orthogonal_selection(selection, fields=fields)
File "/home/tom/anaconda3/lib/python3.6/site-packages/zarr/core.py", line 838, in get_orthogonal_selection
return self._get_selection(indexer=indexer, out=out, fields=fields)
File "/home/tom/anaconda3/lib/python3.6/site-packages/zarr/core.py", line 1015, in _get_selection
drop_axes=indexer.drop_axes, fields=fields)
File "/home/tom/anaconda3/lib/python3.6/site-packages/zarr/core.py", line 1558, in _chunk_getitem
assert len(chunk_coords) == len(self._cdata_shape)
AssertionError
Looks like this indexer is not handling properly the case of scalar arrays.
Version and installation information
python 3.6
zarr 2.2.0
numcodecs 0.5.5
Ubuntu
Thank you !
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/zarr-developers/zarr/issues/302, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAq8Qvjh4g46ZvyFRNvaBGSIdcd4QFSVks5ueO4BgaJpZM4W2yWW
.


label and description resolution

also, elide empty array of collections in collection manifest

Coverage increased (+0.09%) to 95.012% when pulling 2d8906203a41c32befa0fe6ca07f116d5201c246 on metadata into 8517bc9d29252707c0f76804c2518082fd4bf8e9 on master.

Coverage increased (+0.2%) to 95.125% when pulling 2d8906203a41c32befa0fe6ca07f116d5201c246 on metadata into 8517bc9d29252707c0f76804c2518082fd4bf8e9 on master.


Allow canView for admins

Description
I'd like to make a really simple change
I'm building an admin ui where i display user sessions for security purposes. Currently, the canView method only allow the member themselves
I know i can write an extension just for that but it feels like a waste when this could be provided natively by this module
So either, wouldn't we replace the "return false" at the end of handlePermission by a Permisison:check('CMS_ACCESS') or add a config flag that makes this opt in.
If we go the config flag route, this would not have any side effect and only potential benefits for very limited changes.
Additional context or points of discussion
No response
Validations

[X] You intend to implement the feature yourself
[X] You have read the contributing guide
[X] You strongly believe this feature should be in core, rather than being its own community module
[X] You have checked for existing issues or pull requests related to this feature (and didn't find any)

So either, wouldn't we replace the "return false" at the end of handlePermission by a Permisison:check('CMS_ACCESS') or add a config flag that makes this opt in.

We should use a config flag - we don't allow admins to see this information by default for security reasons.
If developers opt into this using the config flag, we should use Permisison:check('ADMIN'), not Permisison:check('CMS_ACCESS') - we only want to grant access to administrators, not everyone who can access the CMS.

no worries, extension it is then :)