fix: Header tx_count must be zero for encoding

The spec states that the tx_count is always zero when transmitted in the Header message.
This removes the tx_count from the header field, instead opting to encode / decode the VarInt according to its purpose at the next highest level.
So for a Block message it will encode the actual tx count, and for Headers each Header will have a VarInt(0) appended.

I'm tempted to remove all VarInt fields, since the length is always implicitly stored already by the vector. However, I wondered if we don't want to keep it for validation purposes? Although in that case the decoding and/or encoding step would have failed.
Basically its redundant information that I want to strip out, and move into the encode / decode methods.

There are two rough spots remaining

Headers can't use the Vec Trait imple because of the extra VarInt(0) we have to append.
Vec needs JoinSplit to not have different encode_xxx methods


data.json -> case_time_series is not updated

The case_time_series has not updated since yesterday. Until yesterday, it was refreshing in real-time. What is the expected behaviour for case_time_series? I am using case_time_series from data.json and states_daily.json - both of them have not updated today.
Is statewise the way to go to keep data up to date?

Cases Time series and State_daily will get updated for the same day around 11:30PM. So, if you need the tentative numbers for the day, you need to add up the cases in Statewise json

Got it, thanks.


Set up Playroom

TL;DR
I set up Playroom for Primer Components.

Playroom allows you to create a zero-install code-oriented design environment, built into a standalone bundle that can be deployed alongside your existing design system documentation.

👉 Try it out: https://primer-components-d5t2omj9p.now.sh/playroom
Problem
We don’t have an easy way to build and share simple prototypes using Primer Components.
Currently, the best ways to experiment with Primer Components are live code examples and CodeSandbox.
Live code examples are a great way to make documentation more interactive. However, they're not designed for building out non-trivial prototypes. The editing interface is limiting and you can't save or share edited code examples.
CodeSandbox on the otherhand is great for creating complex prototypes. However, for simple prototypes, it’s a bit overkill. It’s a fully-featured IDE in the browser which can sometimes be overwhelming.
On a spectrum of simple to complex prototyping tools, live code examples belong on the left and CodeSandbox belongs on the right. We're missing something in the middle.

Solution
This is where Playroom comes in. Playroom is a nice middle ground between live code examples and CodeSandbox.

Here's what it looks like:

With Playroom, we can:

Iterate on designs in the final medium.
Create quick mock-ups and interactive prototypes with real code.
Exercise and evaluate the flexibility of our design system.
Share work with others by simply copying the URL.

Playroom also supports autocomplete (powered by TypeScript), snippets, and multiple viewports.
Implementation
Here are the steps I took to set up Playroom:

Installed playroom as a devDependency (yarn add -D playroom)
Created the following files to configure Playroom:

./playroom.config.js
./playroom/FrameComponent.js (This is a component used to wrap all the previews with the BaseStyles component)
./playroom/snippets.js

Added npm scripts to develop and build the playroom site:

playroom:start – Start a local development server (localhost:9000)
playroom:build – Build assets for production
build – Now automatically looks for this build script to generate static assets for the site

Updated now.json to deploy Playroom to /playroom

Impact
People will be able to go to primer.style/playroom to build and share prototypes using Primer Components.
Open questions

Is primer.style/playroom the right URL?
Should we link to Playroom from the docs? If so, where in the docs should we link to it?

Merge checklist

[ ] Added or updated TypeScript definitions (index.d.ts) if necessary
[ ] Added/updated tests
[ ] Added/updated documentation
[x] Tested in Chrome
[x] Tested in Firefox
[x] Tested in Safari
[ ] Tested in Edge

Would you be up to adding a new page in the side nav under Getting Started that explains what Playroom is, how to use it & link out the the playground with a large button or something easy to find?

Sure! Since the primer.style/playroom link won't work until I update the now.json in http://github.com/primer/primer.style, I think it's best to tackle that in a couple PRs:

PR 1: Set up playroom (that's this PR)
PR 2: Add /playroom redirect in primer/primer.style
PR 3: Add a new page to the Primer Components docs explaining Playroom

Does that work for you, @emplums?

@colebemis that plan looks good to me! 🙌


[BUG] Rouse checks on Oblivion do not show proper 1s

Describe the bug
Rouse checks use standard vampire dice, which is a problem with Oblivion that requires the player to track 10s as well as 1s. For that matter, Rouse checks should use hunger dice; or at least use them when rolling Oblivion.
To Reproduce
Roll an Oblivion rouse check; it uses a default vampire die that does not have an identifiable 1 side.
Expected behavior
1s should be visible.
Additional context
Arguably I'm probably using the wrong report type, I'm sorry. But it makes playing Oblivion impossible with the default Rouse UI.

Besides misusing the bug label, I think it's important to note that we should NOT include a visible 1 on regular dice. Just use hunger dice for Rouse checks instead of normal dice. It will solve the problem.

@eisenfuchs Second that. Plus, thematically, it would be appropriate to use Hunger dice to check for, well... Hunger.

I agree with that. I'll have the hunger dice be the dice for rouse checks.

Also, if possible to code, for Oblivion Powers can possible Stains when '1' or '10' be announced by the system?
As in: "Might cause Stain due to Oblivion being used" or something similar? It would just be a nice to have really, nothing crucial.

Any news on that feature? I run into that issue yesterday. Would be nice :)

Already in the system on main, and pull request #203 will make sure this is working on the dev branch again too.


certificate issues with various commands (signed by unknown authority)

All of the fip commands blow up with the following for me:
~
▶ hyper fip allocate 1
An error occurred trying to connect: Post https://us-west-1.hyper.sh:443/v1.23/fips/allocate?count=1: x509: certificate signed by unknown authority

I was able to pull images, make a data volume, and run a container successfully though.

Looks like this is an inconsistent issue? same just happened after a hyper ps, but is now working correctly for fip commands

@jdc0589
Hyper client itself is a docker client with API signature, thus it is affected by some docker environment. With docker private ca configured, I've tried this
➜  docker git:(master) ✗ hyper images
An error occurred trying to connect: Get https://us-west-1.hyper.sh:443/v1.23/images/json: x509: certificate signed by unknown authority
➜  docker git:(master) ✗ DOCKER_TLS_VERIFY="" hyper images
REPOSITORY                        TAG                 IMAGE ID            CREATED             SIZE
ubuntu                            latest              a1e4ed2ac65b        46 hours ago        187.9 MB
alpine                            latest              d7a513a663c1        5 days ago          4.794 MB
nginx                             latest              af4b3d7d5401        4 weeks ago         190.5 MB

We will update a new client to eliminate this problem, and you can use this (DOCKER_TLS_VERIFY="" hyper) as a work around.
PS: This is a bit confusing. The hyperhq/hyper rep is the backend container engine of  hyper.sh, while the https://github.com/hyperhq/hypercli is the repo for command line tool.

@gnawux my bad, I didn't even think to look for a CLI. I'll update mine in the morning to make sure I have the latest. If its still an issue, I'll reopen this in the right tracker.
thanks.

@jdc0589 It's our problem. Sorry for the confusing. Anyway, the same team replies the Issues.


add git-timemachine

I've been migrating to a new emacs config based on yours after coming from Spacemacs and am still very much a novice at emacs configuration and elisp, so please let me know if you see anything that needs to be changed.
I ran into two small challenges integrating git-timemachine:

The default mode keybindings were not being applied, so I added them manually in the def-package! definition.

On entering the git-timemachine minor mode, none of the mode specific keybindings would work (they were still bound to their evil equivalents), until I hit escape (evil-force-normal-state), after which all of the git-timemachine specific keybindings functioned properly. To work around this I added a hook to execute evil-force-normal-state on entering the minor mode.

Thanks for making your configuration public, it's extremely well thought out and has proved to be a fantastic base to create my configuration from.

Thank you! For the kind words and your help. I've been eyeing git-timemachine lately (or perhaps you saw that in my TODO.org, haha).

Hah, I actually did see that in your TODO.org. I'll keep an eye on it as I pull things in and create PR's for anything I see you have listed.


Modify indent style

Use vim-plugin (vim-go) to adjust indent for go files.

Sorry but we can not accept this PR because we use 4 spaces instead tab for formatting code, anyway thanks!

ok, thanks!


Relative WorkspaceDirectory is computed from Visual Studio directory instead of solution directory

I tried to set WorkspaceDirectory to parent directory (..), and the resulting path was actually the directory where Visual Studio is installed.
This happens because SolutionBuilderContext::ComputeWorkspaceDirectoryPath uses Environment.CurrentDirectory to compute relative paths. It should instead use the directory where the .subsln file is located.

Thanks for the feedback. :)
Here is how I see things: Environment.CurrentDirectory shouldn't actually be used directly in the libraries. I will replace it with a RootDirectory parameter/property. And use Environment.CurrentDirectory value only for the command line executable.
Also you are right that the new RootDirectory should be set on the .subsln folder when the SolutionBuilderContext is created from SolutionBuilderContext .FromConfigurationFileAsync.

Fixed with commit bde5b3c and released in version 0.4.1.


U4 odrive update

Change the U4 to Odrive version 0.5.6 and implement error flags for tornado Odrive.
hotfix for Lizard https://github.com/zauberzeug/lizard/issues/59 .

was merged already


RoR group project: set up your Kanban board

Link to the project : https://github.com/Grandi0z/Recipe_app/projects/1
Team member : 1

Note about working alone

Hi @Grandi0z,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

All cards added ✔
Good use of Kanban board ✔

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


HAWQ-488. Fix bug which cannot drop schema madlib and re-deploy MADlib in schema madlib

The fix are in two folds:

Cannot drop schema madlib and re-deploy MADlib in schema madlib

pg_dump skip dumping content of schema madlib/retail_demo, which should be dumped by default actually. To skip dumping some schema, you can specify it in command line option of pg_dump.

Looks fine to me. +1.


Added  the community pages

We don't have the Community related documentation.

😄May be the "community related version" is not a duty for official? I mean, if you want, create it and host it as you like!
And if your meaning is some docs for the community, there already are for both users and devs.


Tracebacks with RF3.3b

Traceback (most recent call last):
  File "lib/eventTools/eventManager.pyc", line 131, in callObserver_withMethod_forEvent_withInfo_
  File "AdjustAnchors.py", line 367, in _currentGlyphChanged
  File "AdjustAnchors.py", line 502, in updateExtensionWindow
  File "/Applications/RoboFont.app/Contents/Resources/lib/python3.6/fontParts/base/deprecated.py", line 19, in setParent
fontParts.base.deprecated.RemovedWarning: 'RGlyph.setParent()'

Traceback (most recent call last):
  File "lib/doodleDelegate.pyc", line 97, in sendEvent_
  File "lib/views/doodleGlyphView.pyc", line 1971, in mouseUp_
  File "lib/fontObjects/doodleGlyph.pyc", line 411, in releaseHeldFontNotifications
  File "/Applications/RoboFont.app/Contents/Resources/lib/python3.6/defcon/tools/notifications.py", line 260, in releaseHeldNotifications
    self.postNotification(notification, observableRef(), data)
  File "/Applications/RoboFont.app/Contents/Resources/lib/python3.6/defcon/tools/notifications.py", line 201, in postNotification
    callback(notificationObj)
  File "AdjustAnchors.py", line 374, in fontWasModified
  File "AdjustAnchors.py", line 502, in updateExtensionWindow
  File "/Applications/RoboFont.app/Contents/Resources/lib/python3.6/fontParts/base/deprecated.py", line 19, in setParent
    raise RemovedWarning("'%s.setParent()'" % objName)
fontParts.base.deprecated.RemovedWarning: 'RGlyph.setParent()'

Traceback (most recent call last):
  File "AdjustAnchors.py", line 834, in <module>
  File "AdjustAnchors.py", line 244, in __init__
  File "AdjustAnchors.py", line 304, in extraGlyphsCallback
  File "AdjustAnchors.py", line 502, in updateExtensionWindow
  File "/Applications/RoboFont.app/Contents/Resources/lib/python3.6/fontParts/base/deprecated.py", line 19, in setParent
fontParts.base.deprecated.RemovedWarning: 'RGlyph.setParent()'

Never mind. Didn't have the latest version (1.6.1) of Adjust Anchors installed.


Torus login fails multiple times in a row

With error "unable to resolve enough promises"
see #1773 comments for video

doesnt seem to happen with latest torus


install: Fix RabbitMQ node name if RabbitMQ is not installed

Automated message from Dropbox CLA bot
@andersk, it looks like you've already signed the Dropbox CLA. Thanks!

I figure we can do the refactoring I suggested above as a follow-up project if we decide to do it.  Merged!
Huge thanks for doing and carefully testing this @andersk!  This is going to make a huge impact on the amount of pain experienced by folks installing and running Zulip in the future (this one issue caused probably 75% of errors; and a lot of the others are easy to address things like insufficient RAM).


[SPARK-5123] Expose only one version of the data type APIs (i.e. remove the Java-specific API).

This subsumes https://github.com/apache/spark/pull/3925

Test build #25272 has started for   PR 3958 at commit b4f9649.

This patch merges cleanly.

Test build #25272 has finished for   PR 3958 at commit b4f9649.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25272/
Test FAILed.

Okay, the other PR is in, if you fix the merge conflicts this LGTM.  We also need to figure out how to publish scala/java docs here.

I just rebased. Let's see ...

Test build #25487 has started for   PR 3958 at commit 66505cc.

This patch merges cleanly.

Test build #25487 has finished for   PR 3958 at commit 66505cc.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25487/
Test FAILed.

Jenkins, retest this please.

Test build #25492 has started for   PR 3958 at commit 66505cc.

This patch merges cleanly.

You might want to copy the commit message over from the other PR.

done - thanks for reminding, josh.

Ok merging in master. Thanks for looking at this.

Test build #25492 has finished for   PR 3958 at commit 66505cc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25492/
Test PASSed.


Add observedGeneration to virt-operator status to have a race-free way for detecting KubeVirt config rollouts

What this PR does / why we need it:
Processes can now check if kubevirt is up to date from the KubeVirt
configuration by comparing objectMeta.generation with
status.observedGeneration.
This is race-free and avoids having to wait for the KubeVirt PR showing
update conditions. It makes these kinds of checks obsolete.
The operator update tests still stick with the current pattern (extra
waiting for update conditions to appear, before waiting for the operator
to be in sync again), since they have to deal with different operator
versions.
Other tests can now simply wait for the virt-operator to be "available"
and have the same generation on the metadata and the status without
having to consider intermediate steps.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:
-->
Add observedGeneration to virt-operator to have a race-free way to detect KubeVirt config rollouts

/cc @davidvossel
/cc @ashleyschuett

Not as ready as I thought. Ignore it for now.


Update custom cutscene/attract replay loading

New layout for custom cutscene/attract replay files.
Cutscenes
For user replays with a name:
Replays\User\<name>\CUT<mission>_<subindex>.D2RP
For user replays without a name:
Replays\User\CUT<mission>_<subindex>.D2RP
Attractors
For user replays with a name:
Replays\User\<name>\ATTRACT.<mission>
For user replays without a name:
Replays\ATTRACT.<mission> (default)
This replaces the old layout and is quite easy to migrate.

WHAT?! Why on earth is the branch wrong AGAIN...


🚧 [WIP] reimplement all nodes in C++

Description
This lays the foundation for Beehave 3.0 - more details can be found here: https://github.com/bitbrain/beehave/discussions/285
Functionalities
The following first need consultation with @bitbrain, as with Beehave V3 the idea is to design interrupts & before/after signals differently to V2.

[ ] interrupts
[ ] before/after signals
[ ] time-strategies (delta vs total)

Base Nodes

[x] implement & test BeehaveTree
[ ] implement & test BeehaveBlackboard

Decorators

[x] implement & test BeehaveCooldown
[x] implement & test BeehaveDelayer
[x] implement & test BeehaveFailer
[x] implement & test BeehaveSucceeder
[x] implement & test BeehaveInverter
[x] implement & test BeehaveLimiter
[x] implement & test BeehaveUntilFail
[x] implement & test BeehaveTimeLimiter

Composites

[ ] implement & test BeehaveSelector
[ ] implement & test BeehaveSelectorRandom
[ ] implement & test BeehaveSelectorReactive
[ ] implement & test BeehaveSequence
[ ] implement & test BeehaveSequenceRandom
[ ] implement & test BeehaveSequenceReactive
[ ] implement & test BeehaveSequenceStar

Leafs

[x] implement & test BeehaveAction
[ ] implement & test BeehaveCondition

Curious, what's the current state of the V3 migration?

@RafaelVidaurre see the checkboxes in the description for the current status. In terms of work, I aim to do a bit here and there, but it can take a while because I do this in my freetime as a hobby. ♥


Breaking changes in tsserver API between 2.3.0rc and 2.3.1.

Hi. We (WebStorm & Intellij IDEA) use public API of tsserver (in fact we use 'tsserverlibrary.js') and every time when you introduce changes in the public API we have to change our code accordingly.
For example this commit https://github.com/Microsoft/TypeScript/commit/3cc379c3c0c8f3e5ee8b1be5bad8bbc31cfcb610
changed the constructor of the exported class "Session" and we really depend on it.
Could you please not introduce breaking changes in stable branches?
rel. https://youtrack.jetbrains.com/issue/WEB-26641
cc @RyanCavanaugh

This slipped through unnoticed, and is not intentional. we will try and get a fix for you shortelly. sorry for the hassle.

@anstarovoyt I'll have a fix up shortly that you can try locally

TypeScript 2.3.2 should be available now with the fix. sorry for the trouble.

@mhegazy awesome! Thank you

Are you tracking a fix for the root cause here? Seems like there is some missing testing that would have caught the API instability.

###
###

yes. we now have tests that baseline the API.


Should we add a linter specific to the monorepo?

Hey there, I'm very used to having linters on my projects and I've seen here that a couple of dependencies of some packages of this monorepo, have their own linting rules, but the monorepo itself doesn't.
Should we add it?

The general rule for tis repo is: use standard.
I really care about making the individual packages self-sustaining, so I tend to minimize the number of shared scripts.

Got it, thanks 🙏


Regarding Pinned Messages

Clicking on any part of the window when the pinned messages are showing should close them and do whatever action the click was going to do (such as focusing a part of the window, selecting a channel, etc.).

No.  The pinned message menu is a dialog.  You dismiss it by clicking the X.


ZOO-1849 clean up readme

Since I'm working on this project for ZOO-1849 I figured might as well go through the readme & clean it up.  Removed some dead links, fixed some markdown linting issues.

FYI: the build failed because many of the tests are associated with a test MID that has the maximum number of payment profiles associated with it, so some calls related to payment profiles are failing for that specific mid in the tests.

I've looked through the read me changes.  All looks good to me.


Update: Changed some portion of the code to make it more industry standardised

I have improved the code along with adding the useState hook on the books data so that atleast names of the book can be displayed as soon as the database is available.
I also have implemented Bootstrap functionalities to change the navbar  design completely as it had some styling issues earlier.

@adity2911 There is no file changed. Check your commit again


web-angular tests: drop use of page object class and pageloader mock

Fixes #487

Coverage remained the same at 83.846% when pulling 4e5e999fbea9770add8c2d6bcb588374a1401d98 on chalin-web-angular-tests-0426 into 5620319a42714d9b4beb206926080246401993f3 on master.


feat(doc): Add a new GitHub Keys guide section under tutorials

GH Issue
Resolves #218
Steps to test

Open Tutorials
Go to GitHub Keys
Check Content

CheckList

[ ] Follow proper Markdown format
[ ] The content is adequate
[ ] The content is available in both english and spanish
[ ] I Ran a spell check

@edgarEOS  let me know if you need any help resolving the conflict so we can get this PR merged

@edgarEOS  let me know if you need any help resolving the conflict so we can get this PR merged


Remove ExpectedException from SQLTransportIntegrationTest

Summary of the changes / Why this improves CrateDB
This removes ExpectedException from the SQLTransportIntegrationTest rules and migrates all related tests to assertThrows. ExpectedException is deprecated in junit 4.13.
Checklist

[x] Added an entry in CHANGES.txt for user facing changes
[x] Updated documentation & sql_features table for user facing changes
[x] Touched code is covered by tests
[x] CLA is signed
[x] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in CHANGES.txt
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

retest this please

retest this please


#21 Adding .gitattributes to ignore some of the files and folders

Adding .gitattributes to ignore some of the files and folders during packaging for the --prefer-dist
Based on #21

http://www.sitepoint.com/mastering-composer-tips-tricks/
Credit to https://github.com/thephpleague/skeleton/blob/master/.gitattributes

:+1:


Refactor home message list to fix issue #23701

Fixes: Issue #23701
The idea behind this PR is to reflect in the code the fact that the home message list and all of the other message lists that correspond to the narrowed views are treated differently in the code and have differing functionality. This made fixing issue #23701 impossible to do in a clean manner, in my opinion. I also think that separating HomeMessageLists will make the code more coherent in case the home page has to be changed separate from the other message lists in the future.
My PR accomplishes two things: firstly, it separates HomeMessageLists into its own class, and secondly it uses this class and its new method handle_empty_narrow_banner to fix issue #23701 , displaying the empty narrow banner when there are no messages to show in the "All messages" stream.
This was tested when making muting and unmuting/muting streams, deleting messages, and sending messages. Functionality demonstrated in screen recording below.

Screenshots and screen captures:

https://user-images.githubusercontent.com/56522814/207755122-b7e42731-dd90-460d-b55c-cac1d16fceb9.mov

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

@pkaufhol welcome! Can you explain what the purpose of this PR is? I don't understand the goals or strategy for this PR, and I'm concerned based on some of the commit messages that it duplicates a lot of code in a way that we're not going to merge.

@pkaufhol welcome! Can you explain what the purpose of this PR is? I don't understand the goals or strategy for this PR, and I'm concerned based on some of the commit messages that it duplicates a lot of code in a way that we're not going to merge.

My bad, should have put WIP! This is basically me taking a different approach to tackling issue #23701 . I found making the fix given the current structure of the message lists to not really be possible. Working on editing the top comment with a full explanation currently!

@timabbott Updated top comment above, feel free to take a look and let me know what you think! Will work on writing a node test if I can.

@timabbott Updated top comment above, feel free to take a look and let me know what you think! Will work on writing a node test if I can.

@timabbott I got a solution that used class inheritance, which significantly reduces the amount of copied code in HomeMessageList (and makes sense as a use case for inheritance). Let me know if that would help, if it does I should be able to update the commits (nothing changes functionality wise with inheritance though)

This current version is definitely not a direction of any interest -- duplicating 600 lines of complex code is a very bad idea in a large project like this. I'm not sure about class inheritance; I'd need to see it. But I suspect it's also not the right direction -- better would be to just use the initialization options we already support on the MessageList class.
See https://github.com/zulip/zulip/issues/23812 for some background on the direction we're looking at for this module. The goal is actually to unify the home message list to work more or less the same as other message lists, with just a few general-purpose options configured differently. I'm going to close this PR, since it's pretty messy, but feel free to make a next PR for this issue.


Out of background color is not getting empty when we click clear button for the Background Control

Issue description:
In background control when I click on the clear button the color field, the output is giving previously selected color. But when i used color control and apply the output to same HTML element, the output is correct.
Version used:
Stable tag: 3.0.25 ( Plugin )
Using theme_mods or options?
theme_mods
Code to reproduce the issue (config + field(s))
Kirki::add_field( 'grace_config', array(
            'type'        => 'background',
            'settings'    => 'grace_archive_page_header_background_setting',
            'section'     => 'grace_archive_page_header_section',
            'default'     => array(
                'background-color'      => '',
                'background-image'      => '',
                'background-repeat'     => 'repeat',
                'background-position'   => 'center center',
                'background-size'       => 'cover',
                'background-attachment' => 'scroll',
            ),
            'transport'     =>  'postMessage',
            'js_vars'       =>  array(
                array(
                    'element'   =>  array( '.archive .page-header' ),
                    'function'  =>  'css',
                    'property'  =>  'background'
                )
            ),
            'output'        =>  array(
                array(
                    'element'   =>  array( '.archive .page-header' ),
                    'function'  =>  'css',
                    'property'  =>  'background'
                )
            )
        ) );

Confirming I see this bug as well, but with the multicolor field.
Here is a simplified example:
Kirki::add_field( $config_id, array(
	'type'      => 'multicolor',
	'settings'  => 'primary_nav_color',
	'label'     => __( 'Primary Nav', 'textdomain' ),
	'section'   => 'primary_nav',
	'transport' => 'auto',
	'choices'   => array(
		'menu_bg'   => esc_attr__( 'Background', 'textdomain' ),
		'item_color' => esc_attr__( 'Item Color', 'textdomain' ),

	),
	'default' => array(
		'menu_bg'   => '',
		'item_color' => '',
	),
	'output' => array(
		array(
			'choice'   => 'menu_bg',
			'element'  => '.nav-primary',
			'property' => 'background-color',
		),
		array(
			'choice'   => 'item_color',
			'element'  => '.nav-primary a',
			'property' => 'color',
		),
	);

) );

Here are my steps to reproduce:

Save any color value into the Background or Item Color fields.
Refresh the page/customizer to confirm it saved and is working.
Clear the field so it doesn't save any value for that color.
Save and refresh the Customizer
You'll see that the previously saved values are still in there and are used for those fields.

Just to stay organized... this one is not labeled as a bug in GH, though it's been confirmed here ;)
This one is important IMO so don't want it to get lost.

Confirming I see this bug as well, but with the multicolor field.
Here is a simplified example:
Kirki::add_field( $config_id, array(
	'type'      => 'multicolor',
	'settings'  => 'primary_nav_color',
	'label'     => __( 'Primary Nav', 'textdomain' ),
	'section'   => 'primary_nav',
	'transport' => 'auto',
	'choices'   => array(
		'menu_bg'   => esc_attr__( 'Background', 'textdomain' ),
		'item_color' => esc_attr__( 'Item Color', 'textdomain' ),

	),
	'default' => array(
		'menu_bg'   => '',
		'item_color' => '',
	),
	'output' => array(
		array(
			'choice'   => 'menu_bg',
			'element'  => '.nav-primary',
			'property' => 'background-color',
		),
		array(
			'choice'   => 'item_color',
			'element'  => '.nav-primary a',
			'property' => 'color',
		),
	);

) );

Here are my steps to reproduce:

Save any color value into the Background or Item Color fields.
Refresh the page/customizer to confirm it saved and is working.
Clear the field so it doesn't save any value for that color.
Save and refresh the Customizer
You'll see that the previously saved values are still in there and are used for those fields.

Thanks for this breakdown, it made it easy to test.
This is in fact broken in master and the plugin. However it's fixed in develop. Would you mind testing and confirming @JiveDig?

Hello and thank you for reporting this issue.
We are closing most open GitHub issues with the release of Kirki 4 to start fresh with this major release.
If you are still running into issues after you have tested your theme with Kirki 4, please let us know so we can reopen the issue.
Please note that Kirki 3 is no longer actively supported. Moving forward, we will only provide support the very latest version of Kirki.
Thank you for your understanding.
Best,
David


Problem: 0.5 testnet not yet deployed and documented

[ ] @devashishdxt @lezzokafka @allthatjazzleo: new consensus pub keys + wallets + genesis file (ideally the existing 0.3 validators will start with their addresses allocated enough bonded stake, so only "nodejoin" is required)
[ ] @allthatjazzleo : initial council nodes (validators) + full node (query) deployment (+ new monitoring? alerts?)
[ ] @lezzokafka @allthatjazzleo : testing node join, jailing etc.
[ ] if all goes good, @tomtau @lezzokafka : update docs + quick notification on Gitter + update preparation
[ ] @calvinaco @foreseaz : tx bot + existing explorer quick changes
[ ] if all went fine, @allthatjazzleo : decommission the 0.3 testnet by May 8?

[ ]  if all goes good, @tomtau @lezzokafka : update docs + quick notification on Gitter + update preparation

Draft for the docs update: #133

to be decommissioned by May 15?

to be decommissioned by May 15?
Some of testnet 3.0 have been decommissioned.
Still I have one node I need to confirm with @devashishdxt to decommission

all testnet 3.0 were decommissioned @tomtau


WindowTitleBar

Hello,
Thank for great library
I'm trying integrate WindowTitleBar to my app, but it's look weird, maybe I use it wrong

<WindowTitlebar
          controlsOrder="platform"
          windowControlsProps={{ platform: 'macos' }}
        >
          <button
            type="button"
            onClick={() => goBack()}
            className="group inline-flex h-6 w-6 items-center justify-center rounded-md hover:bg-zinc-900"
          >
            <ArrowLeftIcon className="h-4 w-4 text-zinc-500 group-hover:text-zinc-300" />
          </button>
          <button
            type="button"
            onClick={() => goForward()}
            className="group inline-flex h-6 w-6 items-center justify-center rounded-md hover:bg-zinc-900"
          >
            <ArrowRightIcon className="h-4 w-4 text-zinc-500 group-hover:text-zinc-300" />
          </button>
        </WindowTitlebar>

Hello, Thanks! Is it the same when choosing other platforms windows, gnome?

You are right, chrome(116) and safari(13) behave differently, I will fix it right away.

Hey, can you try version 0.0.6, it seems ok for me.

yup, work fine now


I didn´t receive a Trophy on Microsoft learn - Learning Path

Describe the bug
I completed the Azure Fundamentals Learning Path and I didn´t get a Trophy. I´m part of the Microsoft Student Partner and I need to the Trophy to report it to the program.
To Reproduce
Steps to reproduce the behavior:

Go to 'Profile'
Click on 'Achievements'
Scroll down to 'Trophies'
I don't see the new trophy

Expected behavior
A Trophy that I completed the Azure Fundamentals Learning Path
Screenshots

Desktop (please complete the following information):

OS: [Windows 10]
Browser [Chrome]
Version [83.0.4103.106]

Issue seems to be fixed


Ingress failing when RBAC enabled on edge

Hi, I'm in the process of installing microk8s, it seems that the Role is misconfigured for the ingress controller on the --edge release.
I had to add the the following to get it working:
- apiGroups:
  - ""
  resources:
  - services
  - ingresses
  verbs:
  - get
  - list

Attached is the version info, installed using:
snap install microk8s --edge --classic
inspection-report-20191122_234153.tar.gz
Thanks for the awesome project!

@moredhel I've been looking at the rbac, it does have ingress included.
https://github.com/ubuntu/microk8s/blob/797720e2d1e74030fc3d8df5d291469c6082aaac/microk8s-resources/actions/ingress.yaml#L47-L52
May i know what error you are getting?  I also couldn't find any error reported by the apiserver.

Hi Balchua,
Thanks for the response.
I did get it working, (as mentioned above), but that was not present in the role definition that I was running with.
I've since patched it on my local instance, so don't have access to the logs.
The error was Nginx complaining about creating a ConfigMap for leader election.
The following issue describes what I experienced: https://github.com/kubernetes/ingress-nginx/issues/798
Thanks


Add support for static variables

Static variables should be rewritten as global variables with scope prefixes.
For example:
int f()
{
  static int x = 0;
  x++;
}

becomes
function f()
  if _static_f_x == nil then
    _static_f_x = 0
  end
  _static_f_x = _static_f_x + 1
end

Depends on #15 - doing it with the current approach will be too hacky.

I lied. Turns out when there's a will, there's a way...


When auto save off: Bulk download makes no sense.

Hi guys, as reported in https://hydrogenaud.io/index.php/topic,120812.msg1018044.html#msg1018044
When I set the options to NOT auto save...
Now express my wish to manually bulk download lyrics - it does do that, but it was for nothing, because it is nowhere applied. When visiting one of those tracks, it just again downloads lyrics for it.
Steps to reproduce

Set Auto save off in options
Bulk download lyrics
A waste of time, they won't get applied

Expected behavior
IMO when I explicitely say "Search for lyrics" on multiple tracks, it should save the lyrics to the desired place (depending on the settings).
Versions

foobar2000 version: 2 beta 12
OpenLyrics version: 1.3

Fixed by 097da6b2f (although I referenced the wrong issue number)


Ingress 1.79.0 is missing some of the artifact resources

Ingress newer than 1.78.0 is stripping out old artifact resources, and MUFG Capsule is added in recently version so an asset merge is needed. And the AssetManager doesn't handle errors properly, thus resulting in rendering nothing.

Yeah, I need to readdress the AssetManager in the next release.  On my list:  adding incremental asset loading (so you don't need to give it a full manifest, and let it handle merging of manifests, etc), as well as better error handling.
I'll bump this up in priority, especially with the removal of even more assets from the client.  I think that will also come with the removal of the jarvis shards from this repo, too, since I'm not really a fan of having assets that aren't mine stored in a public repo (so grab them while you can).
This might turn into a pretty complicated release, but that's okay.  It's good that you bring this up, I've been meaning to fix it for some time, but I just keep working around it, instead.

Done in v0.17.0


Handshake failure

Hi,
Since you are testing v1.0.0 I am coming back with this issue. Today I was able to build the master branch from source (something that had failed in all my previous attempts). But I am still unable to access my university account.
My config.toml looks like this:
accounts.dm]
default = true
email =<EMAIL_ADDRESS>display-name = "Ignacio Ojea"
downloads-dir = "~/Downloads"
backend = "imap"
message.send.backend = "smtp"
imap.host = "imap.dm.uba.ar"
imap.port = 993
imap.encryption = "tls"
imap.login = "iojea"
imap.passwd.command = "pass show iojea/DM"
smtp.host = "smtp.dm.uba.ar"
smtp.port = 587
smtp.encryption = "tls"
smtp.login = "iojea"
smtp.passwd.command = "pass show iojea/DM"

When I run himalaya I am asked for my pass password, and when I type it I get the following error. This has not changed with respect to v0.9.0.
 WARN cannot build imap session: cannot connect to imap server, attempt (1)
 WARN cannot build imap session: cannot connect to imap server, attempt (2)
 WARN cannot build imap session: cannot connect to imap server, attempt (3)
 WARN cannot build imap session after 3 attempts, aborting
Error:
   0: cannot connect to imap server
   1: IO error: received fatal alert: HandshakeFailure

Note: Run with --debug to enable logs with spantrace.
Note: Run with --trace to enable verbose logs with backtrace.

The output of himalaya --debug is:
2024-11-01T13:22:05.134607Z  INFO executing list envelopes command
2024-11-01T13:22:05.134820Z DEBUG running single command: pass show iojea/DM
2024-11-01T13:22:05.298842Z  INFO building new imap context
2024-11-01T13:22:05.298883Z DEBUG creating session using login and password
2024-11-01T13:22:05.301615Z DEBUG No cached session for DnsName("imap.dm.uba.ar")
2024-11-01T13:22:05.301805Z DEBUG Not resuming any session
2024-11-01T13:22:05.307519Z  WARN cannot build imap session: cannot connect to imap server, attempt (1)
2024-11-01T13:22:05.307567Z DEBUG creating session using login and password
2024-11-01T13:22:05.308678Z DEBUG No cached session for DnsName("imap.dm.uba.ar")
2024-11-01T13:22:05.309879Z DEBUG Not resuming any session
2024-11-01T13:22:05.314075Z  WARN cannot build imap session: cannot connect to imap server, attempt (2)
2024-11-01T13:22:05.314104Z DEBUG creating session using login and password
2024-11-01T13:22:05.315863Z DEBUG No cached session for DnsName("imap.dm.uba.ar")
2024-11-01T13:22:05.316616Z DEBUG Not resuming any session
2024-11-01T13:22:05.325273Z  WARN cannot build imap session: cannot connect to imap server, attempt (3)
2024-11-01T13:22:05.325313Z DEBUG creating session using login and password
2024-11-01T13:22:05.326110Z DEBUG No cached session for DnsName("imap.dm.uba.ar")
2024-11-01T13:22:05.326204Z DEBUG Not resuming any session
2024-11-01T13:22:05.332215Z  WARN cannot build imap session after 3 attempts, aborting
Error:
   0: cannot connect to imap server
   1: IO error: received fatal alert: HandshakeFailure

Location:
   /build/source/src/backend/mod.rs:638

Note: Run with --trace to enable verbose logs with backtrace.

The output of himalaya --trace is:
2024-11-01T13:23:26.251980Z  INFO executing list envelopes command
2024-11-01T13:23:26.252189Z DEBUG running single command: pass show iojea/DM
2024-11-01T13:23:26.252771Z TRACE registering event source with poller: token=Token(134759672380800), interests=READABLE | WRITABLE
2024-11-01T13:23:26.252809Z TRACE registering event source with poller: token=Token(134759677776000), interests=READABLE | WRITABLE
2024-11-01T13:23:26.252833Z TRACE registering event source with poller: token=Token(134759677776384), interests=READABLE
2024-11-01T13:23:26.412726Z TRACE deregistering event source from poller
2024-11-01T13:23:26.412786Z TRACE deregistering event source from poller
2024-11-01T13:23:26.412799Z TRACE deregistering event source from poller
2024-11-01T13:23:26.412841Z  INFO building new imap context
2024-11-01T13:23:26.412849Z DEBUG creating session using login and password
2024-11-01T13:23:26.415430Z DEBUG No cached session for DnsName("imap.dm.uba.ar")
2024-11-01T13:23:26.415597Z DEBUG Not resuming any session
2024-11-01T13:23:26.415639Z TRACE Sending ClientHello Message {
    version: TLSv1_0,
    payload: Handshake {
        parsed: HandshakeMessagePayload {
            typ: ClientHello,
            payload: ClientHello(
                ClientHelloPayload {
                    client_version: TLSv1_2,
                    random: 639db4cd48a035d1e82c1a53ad85b51ea8ec7789d17b7597a39103854351048a,
                    session_id: 01b5a9cf992dfef65d7c77ce42eef18592df3bb2bec8cc6fd871a3a804c0ecdb,
                    cipher_suites: [
                        TLS13_AES_256_GCM_SHA384,
                        TLS13_AES_128_GCM_SHA256,
                        TLS13_CHACHA20_POLY1305_SHA256,
                        TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384,
                        TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256,
                        TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256,
                        TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384,
                        TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,
                        TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256,
                        TLS_EMPTY_RENEGOTIATION_INFO_SCSV,
                    ],
                    compression_methods: [
                        Null,
                    ],
                    extensions: [
                        SupportedVersions(
                            [
                                TLSv1_3,
                                TLSv1_2,
                            ],
                        ),
                        EcPointFormats(
                            [
                                Uncompressed,
                            ],
                        ),
                        NamedGroups(
                            [
                                X25519,
                                secp256r1,
                                secp384r1,
                            ],
                        ),
                        SignatureAlgorithms(
                            [
                                ECDSA_NISTP384_SHA384,
                                ECDSA_NISTP256_SHA256,
                                ED25519,
                                RSA_PSS_SHA512,
                                RSA_PSS_SHA384,
                                RSA_PSS_SHA256,
                                RSA_PKCS1_SHA512,
                                RSA_PKCS1_SHA384,
                                RSA_PKCS1_SHA256,
                            ],
                        ),
                        ExtendedMasterSecretRequest,
                        CertificateStatusRequest(
                            Ocsp(
                                OcspCertificateStatusRequest {
                                    responder_ids: [],
                                    extensions: ,
                                },
                            ),
                        ),
                        ServerName(
                            [
                                ServerName {
                                    typ: HostName,
                                    payload: HostName(
                                        DnsName(
                                            "imap.dm.uba.ar",
                                        ),
                                    ),
                                },
                            ],
                        ),
                        KeyShare(
                            [
                                KeyShareEntry {
                                    group: X25519,
                                    payload: 5a70551802d80831a70bd97839d9c19016c99e84dcfcc06abd8351945efaec59,
                                },
                            ],
                        ),
                        PresharedKeyModes(
                            [
                                PSK_DHE_KE,
                            ],
                        ),
                        SessionTicket(
                            Request,
                        ),
                    ],
                },
            ),
        },
        encoded: 010000e80303639db4cd48a035d1e82c1a53ad85b51ea8ec7789d17b7597a39103854351048a2001b5a9cf992dfef65d7c77ce42eef18592df3bb2bec8cc6fd871a3a804c0ecdb0014130213011303c02cc02bcca9c030c02fcca800ff0100008b002b00050403040303000b00020100000a00080006001d00170018000d001400120503040308070806080508040601050104010017000000050005010000000000000013001100000e696d61702e646d2e7562612e6172003300260024001d00205a70551802d80831a70bd97839d9c19016c99e84dcfcc06abd8351945efaec59002d0002010100230000,
    },
}
2024-11-01T13:23:26.421168Z  WARN cannot build imap session: cannot connect to imap server, attempt (1)
2024-11-01T13:23:26.421253Z DEBUG creating session using login and password
2024-11-01T13:23:26.422759Z DEBUG No cached session for DnsName("imap.dm.uba.ar")
2024-11-01T13:23:26.422934Z DEBUG Not resuming any session
2024-11-01T13:23:26.422978Z TRACE Sending ClientHello Message {
    version: TLSv1_0,
    payload: Handshake {
        parsed: HandshakeMessagePayload {
            typ: ClientHello,
            payload: ClientHello(
                ClientHelloPayload {
                    client_version: TLSv1_2,
                    random: a4eb8f8448e56b2a445759150c2e3ef014bb0db98283e4ce6742528e160e8cb1,
                    session_id: 851330c593d9da9690a85a825060abce9cb68e390f2ec20893ba104c147fee5d,
                    cipher_suites: [
                        TLS13_AES_256_GCM_SHA384,
                        TLS13_AES_128_GCM_SHA256,
                        TLS13_CHACHA20_POLY1305_SHA256,
                        TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384,
                        TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256,
                        TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256,
                        TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384,
                        TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,
                        TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256,
                        TLS_EMPTY_RENEGOTIATION_INFO_SCSV,
                    ],
                    compression_methods: [
                        Null,
                    ],
                    extensions: [
                        SupportedVersions(
                            [
                                TLSv1_3,
                                TLSv1_2,
                            ],
                        ),
                        EcPointFormats(
                            [
                                Uncompressed,
                            ],
                        ),
                        NamedGroups(
                            [
                                X25519,
                                secp256r1,
                                secp384r1,
                            ],
                        ),
                        SignatureAlgorithms(
                            [
                                ECDSA_NISTP384_SHA384,
                                ECDSA_NISTP256_SHA256,
                                ED25519,
                                RSA_PSS_SHA512,
                                RSA_PSS_SHA384,
                                RSA_PSS_SHA256,
                                RSA_PKCS1_SHA512,
                                RSA_PKCS1_SHA384,
                                RSA_PKCS1_SHA256,
                            ],
                        ),
                        ExtendedMasterSecretRequest,
                        CertificateStatusRequest(
                            Ocsp(
                                OcspCertificateStatusRequest {
                                    responder_ids: [],
                                    extensions: ,
                                },
                            ),
                        ),
                        ServerName(
                            [
                                ServerName {
                                    typ: HostName,
                                    payload: HostName(
                                        DnsName(
                                            "imap.dm.uba.ar",
                                        ),
                                    ),
                                },
                            ],
                        ),
                        KeyShare(
                            [
                                KeyShareEntry {
                                    group: X25519,
                                    payload: 536f7ab28df8dce1f74d76b06869f4f6414599abc5d339a6020f09d39e86534d,
                                },
                            ],
                        ),
                        PresharedKeyModes(
                            [
                                PSK_DHE_KE,
                            ],
                        ),
                        SessionTicket(
                            Request,
                        ),
                    ],
                },
            ),
        },
        encoded: 010000e80303a4eb8f8448e56b2a445759150c2e3ef014bb0db98283e4ce6742528e160e8cb120851330c593d9da9690a85a825060abce9cb68e390f2ec20893ba104c147fee5d0014130213011303c02cc02bcca9c030c02fcca800ff0100008b002b00050403040303000b00020100000a00080006001d00170018000d001400120503040308070806080508040601050104010017000000050005010000000000000013001100000e696d61702e646d2e7562612e6172003300260024001d0020536f7ab28df8dce1f74d76b06869f4f6414599abc5d339a6020f09d39e86534d002d0002010100230000,
    },
}
2024-11-01T13:23:26.428105Z  WARN cannot build imap session: cannot connect to imap server, attempt (2)
2024-11-01T13:23:26.428115Z DEBUG creating session using login and password
2024-11-01T13:23:26.429195Z DEBUG No cached session for DnsName("imap.dm.uba.ar")
2024-11-01T13:23:26.429282Z DEBUG Not resuming any session
2024-11-01T13:23:26.429305Z TRACE Sending ClientHello Message {
    version: TLSv1_0,
    payload: Handshake {
        parsed: HandshakeMessagePayload {
            typ: ClientHello,
            payload: ClientHello(
                ClientHelloPayload {
                    client_version: TLSv1_2,
                    random: 54e9a0c80e23622f1b327ee5780527785f55f70ff879c674a406f178c3b9b2cf,
                    session_id: 410acfd4c805a20eb9ab0d7dc93a057fa05e8c435aca5751f53c00ac285595fa,
                    cipher_suites: [
                        TLS13_AES_256_GCM_SHA384,
                        TLS13_AES_128_GCM_SHA256,
                        TLS13_CHACHA20_POLY1305_SHA256,
                        TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384,
                        TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256,
                        TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256,
                        TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384,
                        TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,
                        TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256,
                        TLS_EMPTY_RENEGOTIATION_INFO_SCSV,
                    ],
                    compression_methods: [
                        Null,
                    ],
                    extensions: [
                        SupportedVersions(
                            [
                                TLSv1_3,
                                TLSv1_2,
                            ],
                        ),
                        EcPointFormats(
                            [
                                Uncompressed,
                            ],
                        ),
                        NamedGroups(
                            [
                                X25519,
                                secp256r1,
                                secp384r1,
                            ],
                        ),
                        SignatureAlgorithms(
                            [
                                ECDSA_NISTP384_SHA384,
                                ECDSA_NISTP256_SHA256,
                                ED25519,
                                RSA_PSS_SHA512,
                                RSA_PSS_SHA384,
                                RSA_PSS_SHA256,
                                RSA_PKCS1_SHA512,
                                RSA_PKCS1_SHA384,
                                RSA_PKCS1_SHA256,
                            ],
                        ),
                        ExtendedMasterSecretRequest,
                        CertificateStatusRequest(
                            Ocsp(
                                OcspCertificateStatusRequest {
                                    responder_ids: [],
                                    extensions: ,
                                },
                            ),
                        ),
                        ServerName(
                            [
                                ServerName {
                                    typ: HostName,
                                    payload: HostName(
                                        DnsName(
                                            "imap.dm.uba.ar",
                                        ),
                                    ),
                                },
                            ],
                        ),
                        KeyShare(
                            [
                                KeyShareEntry {
                                    group: X25519,
                                    payload: 9bd0d81d46610090fd126f2d0926e47122d0a6aedb9cd2c9cbb8a75af5985a39,
                                },
                            ],
                        ),
                        PresharedKeyModes(
                            [
                                PSK_DHE_KE,
                            ],
                        ),
                        SessionTicket(
                            Request,
                        ),
                    ],
                },
            ),
        },
        encoded: 010000e8030354e9a0c80e23622f1b327ee5780527785f55f70ff879c674a406f178c3b9b2cf20410acfd4c805a20eb9ab0d7dc93a057fa05e8c435aca5751f53c00ac285595fa0014130213011303c02cc02bcca9c030c02fcca800ff0100008b002b00050403040303000b00020100000a00080006001d00170018000d001400120503040308070806080508040601050104010017000000050005010000000000000013001100000e696d61702e646d2e7562612e6172003300260024001d00209bd0d81d46610090fd126f2d0926e47122d0a6aedb9cd2c9cbb8a75af5985a39002d0002010100230000,
    },
}
2024-11-01T13:23:26.434369Z  WARN cannot build imap session: cannot connect to imap server, attempt (3)
2024-11-01T13:23:26.434378Z DEBUG creating session using login and password
2024-11-01T13:23:26.435233Z DEBUG No cached session for DnsName("imap.dm.uba.ar")
2024-11-01T13:23:26.435332Z DEBUG Not resuming any session
2024-11-01T13:23:26.435354Z TRACE Sending ClientHello Message {
    version: TLSv1_0,
    payload: Handshake {
        parsed: HandshakeMessagePayload {
            typ: ClientHello,
            payload: ClientHello(
                ClientHelloPayload {
                    client_version: TLSv1_2,
                    random: f0317bb7fe5b67b9c39038d5d5ec2cf959c1f8bda0fb7b868e8be969beb555cd,
                    session_id: 46b41b8ca2df119e2a4b2cd87b5d0731f3d0729c5ab5e4b66c92d0e0b1308094,
                    cipher_suites: [
                        TLS13_AES_256_GCM_SHA384,
                        TLS13_AES_128_GCM_SHA256,
                        TLS13_CHACHA20_POLY1305_SHA256,
                        TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384,
                        TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256,
                        TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256,
                        TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384,
                        TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,
                        TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256,
                        TLS_EMPTY_RENEGOTIATION_INFO_SCSV,
                    ],
                    compression_methods: [
                        Null,
                    ],
                    extensions: [
                        SupportedVersions(
                            [
                                TLSv1_3,
                                TLSv1_2,
                            ],
                        ),
                        EcPointFormats(
                            [
                                Uncompressed,
                            ],
                        ),
                        NamedGroups(
                            [
                                X25519,
                                secp256r1,
                                secp384r1,
                            ],
                        ),
                        SignatureAlgorithms(
                            [
                                ECDSA_NISTP384_SHA384,
                                ECDSA_NISTP256_SHA256,
                                ED25519,
                                RSA_PSS_SHA512,
                                RSA_PSS_SHA384,
                                RSA_PSS_SHA256,
                                RSA_PKCS1_SHA512,
                                RSA_PKCS1_SHA384,
                                RSA_PKCS1_SHA256,
                            ],
                        ),
                        ExtendedMasterSecretRequest,
                        CertificateStatusRequest(
                            Ocsp(
                                OcspCertificateStatusRequest {
                                    responder_ids: [],
                                    extensions: ,
                                },
                            ),
                        ),
                        ServerName(
                            [
                                ServerName {
                                    typ: HostName,
                                    payload: HostName(
                                        DnsName(
                                            "imap.dm.uba.ar",
                                        ),
                                    ),
                                },
                            ],
                        ),
                        KeyShare(
                            [
                                KeyShareEntry {
                                    group: X25519,
                                    payload: 3f84deff9f47febef50414d25779c69a0ffaf538a72f316ba9cea71645017722,
                                },
                            ],
                        ),
                        PresharedKeyModes(
                            [
                                PSK_DHE_KE,
                            ],
                        ),
                        SessionTicket(
                            Request,
                        ),
                    ],
                },
            ),
        },
        encoded: 010000e80303f0317bb7fe5b67b9c39038d5d5ec2cf959c1f8bda0fb7b868e8be969beb555cd2046b41b8ca2df119e2a4b2cd87b5d0731f3d0729c5ab5e4b66c92d0e0b13080940014130213011303c02cc02bcca9c030c02fcca800ff0100008b002b00050403040303000b00020100000a00080006001d00170018000d001400120503040308070806080508040601050104010017000000050005010000000000000013001100000e696d61702e646d2e7562612e6172003300260024001d00203f84deff9f47febef50414d25779c69a0ffaf538a72f316ba9cea71645017722002d0002010100230000,
    },
}
2024-11-01T13:23:26.440445Z  WARN cannot build imap session after 3 attempts, aborting
Error:
   0: cannot connect to imap server
   1: IO error: received fatal alert: HandshakeFailure

Location:
   /build/source/src/backend/mod.rs:638

  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ BACKTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
                                ⋮ 3 frames hidden ⋮
   4: himalaya::email::envelope::command::list::ListEnvelopesCommand::execute::{{closure}}::h45c698d3d348ab89
      at <unknown source file>:<unknown line>
   5: tokio::runtime::park::CachedParkThread::block_on::h55e0cb240d0bc81c
      at <unknown source file>:<unknown line>
   6: tokio::runtime::context::runtime::enter_runtime::h07fdf3eeb91a6311
      at <unknown source file>:<unknown line>
   7: tokio::runtime::runtime::Runtime::block_on::hed83e9d496bb757f
      at <unknown source file>:<unknown line>
   8: himalaya::main::h0eefd20397af79ba
      at <unknown source file>:<unknown line>
   9: std::sys_common::backtrace::__rust_begin_short_backtrace::h49ef2140b8710848
      at <unknown source file>:<unknown line>
  10: std::rt::lang_start::{{closure}}::h768a8bc4e460bbc2
      at <unknown source file>:<unknown line>
  11: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once::h5ec8c9a223df7d15
      at /rustc/aedd173a2c086e558c2b66d3743b344f977621a7/library/core/src/ops/function.rs:284
  12: std::panicking::try::do_call::h2dcd2c78950ddfec
      at /rustc/aedd173a2c086e558c2b66d3743b344f977621a7/library/std/src/panicking.rs:554
  13: std::panicking::try::hce5bc4bcb0fe9f5d
      at /rustc/aedd173a2c086e558c2b66d3743b344f977621a7/library/std/src/panicking.rs:518
  14: std::panic::catch_unwind::hb71ed5db6f0535df
      at /rustc/aedd173a2c086e558c2b66d3743b344f977621a7/library/std/src/panic.rs:142
  15: std::rt::lang_start_internal::{{closure}}::h02e44d6341d8a0e0
      at /rustc/aedd173a2c086e558c2b66d3743b344f977621a7/library/std/src/rt.rs:148
  16: std::panicking::try::do_call::h607b189d049eee65
      at /rustc/aedd173a2c086e558c2b66d3743b344f977621a7/library/std/src/panicking.rs:554
  17: std::panicking::try::h419673dfebc39c5d
      at /rustc/aedd173a2c086e558c2b66d3743b344f977621a7/library/std/src/panicking.rs:518
  18: std::panic::catch_unwind::hdab4b753f5ca84c0
      at /rustc/aedd173a2c086e558c2b66d3743b344f977621a7/library/std/src/panic.rs:142
  19: std::rt::lang_start_internal::hc5ae2f59965906d9
      at /rustc/aedd173a2c086e558c2b66d3743b344f977621a7/library/std/src/rt.rs:148
  20: main<unknown>
      at <unknown source file>:<unknown line>

I don´t know what causes this issue, but I have successfully configured other mail clients with essentially the same config.  I hope this can be fixed...
Thanks!

Sorry for the delay. Looks definitely like a TLS issue, but does not look obvious to me at first glance. When I compare with my logs:
2024-11-05T15:21:43.204043Z TRACE client::build: rustls::client::hs: Sending ClientHello Message {
    version: TLSv1_0,
    payload: Handshake {
        parsed: HandshakeMessagePayload {
            typ: ClientHello,
            payload: ClientHello(
                ClientHelloPayload {
                    client_version: TLSv1_2,
                    random: 8a2cb3625125cbe0fe7fcb83622aad0a8309c8b881492346c915a4da088c00a2,
                    session_id: 7686b848821d0d500a67ccc707c0be58f4ae79a142fb6965ebc9e9051007cc3b,
                    cipher_suites: [
                        TLS13_AES_256_GCM_SHA384,
                        TLS13_AES_128_GCM_SHA256,
                        TLS13_CHACHA20_POLY1305_SHA256,
                        TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384,
                        TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256,
                        TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256,
                        TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384,
                        TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,
                        TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256,
                        TLS_EMPTY_RENEGOTIATION_INFO_SCSV,
                    ],
                    compression_methods: [
                        Null,
                    ],
                    extensions: [
                        PresharedKeyModes(
                            [
                                PSK_DHE_KE,
                            ],
                        ),
                        KeyShare(
                            [
                                KeyShareEntry {
                                    group: X25519,
                                    payload: 8e1b0bc03f2ed3c6b1ac776cc205e5b427cdaa000387bcabea59289d7b64183a,
                                },
                            ],
                        ),
                        ExtendedMasterSecretRequest,
                        ServerName(
                            [
                                ServerName {
                                    typ: HostName,
                                    payload: HostName(
                                        DnsName(
                                            "posteo.de",
                                        ),
                                    ),
                                },
                            ],
                        ),
                        SupportedVersions(
                            [
                                TLSv1_3,
                                TLSv1_2,
                            ],
                        ),
                        NamedGroups(
                            [
                                X25519,
                                secp256r1,
                                secp384r1,
                            ],
                        ),
                        CertificateStatusRequest(
                            Ocsp(
                                OcspCertificateStatusRequest {
                                    responder_ids: [],
                                    extensions: ,
                                },
                            ),
                        ),
                        Protocols(
                            [
                                ProtocolName(
                                    696d6170,
                                ),
                            ],
                        ),
                        SessionTicket(
                            Request,
                        ),
                        SignatureAlgorithms(
                            [
                                ECDSA_NISTP384_SHA384,
                                ECDSA_NISTP256_SHA256,
                                ED25519,
                                RSA_PSS_SHA512,
                                RSA_PSS_SHA384,
                                RSA_PSS_SHA256,
                                RSA_PKCS1_SHA512,
                                RSA_PKCS1_SHA384,
                                RSA_PKCS1_SHA256,
                            ],
                        ),
                        EcPointFormats(
                            [
                                Uncompressed,
                            ],
                        ),
                    ],
                },
            ),
        },
        encoded: 010000ee03038a2cb3625125cbe0fe7fcb83622aad0a8309c8b881492346c915a4da088c00a2207686b848821d0d500a67ccc707c0be58f4ae79a142fb6965ebc9e9051007cc3b0014130213011303c02cc02bcca9c030c02fcca800ff01000091002d00020101003300260024001d00208e1b0bc03f2ed3c6b1ac776cc205e5b427cdaa000387bcabea59289d7b64183a001700000000000e000c000009706f7374656f2e6465002b00050403040303000a00080006001d0017001800050005010000000000100007000504696d617000230000000d00140012050304030807080608050804060105010401000b00020100,
    },
}
2024-11-05T15:21:43.223142Z TRACE client::build: rustls::client::hs: Got HRR HelloRetryRequest { legacy_version: TLSv1_2, session_id: 7686b848821d0d500a67ccc707c0be58f4ae79a142fb6965ebc9e9051007cc3b, cipher_suite: TLS13_AES_256_GCM_SHA384, extensions: [SupportedVersions(TLSv1_3), KeyShare(secp384r1)] }
2024-11-05T15:21:43.226147Z TRACE client::build: rustls::client::hs: Sending ClientHello Message {
    version: TLSv1_2,
    payload: Handshake {
        parsed: HandshakeMessagePayload {
            typ: ClientHello,
            payload: ClientHello(
                ClientHelloPayload {
                    client_version: TLSv1_2,
                    random: 8a2cb3625125cbe0fe7fcb83622aad0a8309c8b881492346c915a4da088c00a2,
                    session_id: 7686b848821d0d500a67ccc707c0be58f4ae79a142fb6965ebc9e9051007cc3b,
                    cipher_suites: [
                        TLS13_AES_256_GCM_SHA384,
                        TLS13_AES_128_GCM_SHA256,
                        TLS13_CHACHA20_POLY1305_SHA256,
                        TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384,
                        TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256,
                        TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256,
                        TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384,
                        TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,
                        TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256,
                        TLS_EMPTY_RENEGOTIATION_INFO_SCSV,
                    ],
                    compression_methods: [
                        Null,
                    ],
                    extensions: [
                        PresharedKeyModes(
                            [
                                PSK_DHE_KE,
                            ],
                        ),
                        KeyShare(
                            [
                                KeyShareEntry {
                                    group: secp384r1,
                                    payload: 04d07bff18162199be7cb2d7d7981064f36c06764b50689bc05e1e42d03ff05c9d29ab5b5b814e133084fc242e0413ad81dd317fe5405c2ae29027c2ae6dab8656e591d07999d13d2f87a70a885a997745d527d05b968cb1454259b72f80cf054a,
                                },
                            ],
                        ),
                        ExtendedMasterSecretRequest,
                        ServerName(
                            [
                                ServerName {
                                    typ: HostName,
                                    payload: HostName(
                                        DnsName(
                                            "posteo.de",
                                        ),
                                    ),
                                },
                            ],
                        ),
                        SupportedVersions(
                            [
                                TLSv1_3,
                                TLSv1_2,
                            ],
                        ),
                        NamedGroups(
                            [
                                X25519,
                                secp256r1,
                                secp384r1,
                            ],
                        ),
                        CertificateStatusRequest(
                            Ocsp(
                                OcspCertificateStatusRequest {
                                    responder_ids: [],
                                    extensions: ,
                                },
                            ),
                        ),
                        Protocols(
                            [
                                ProtocolName(
                                    696d6170,
                                ),
                            ],
                        ),
                        SessionTicket(
                            Request,
                        ),
                        SignatureAlgorithms(
                            [
                                ECDSA_NISTP384_SHA384,
                                ECDSA_NISTP256_SHA256,
                                ED25519,
                                RSA_PSS_SHA512,
                                RSA_PSS_SHA384,
                                RSA_PSS_SHA256,
                                RSA_PKCS1_SHA512,
                                RSA_PKCS1_SHA384,
                                RSA_PKCS1_SHA256,
                            ],
                        ),
                        EcPointFormats(
                            [
                                Uncompressed,
                            ],
                        ),
                    ],
                },
            ),
        },
        encoded: 0100012f03038a2cb3625125cbe0fe7fcb83622aad0a8309c8b881492346c915a4da088c00a2207686b848821d0d500a67ccc707c0be58f4ae79a142fb6965ebc9e9051007cc3b0014130213011303c02cc02bcca9c030c02fcca800ff010000d2002d000201010033006700650018006104d07bff18162199be7cb2d7d7981064f36c06764b50689bc05e1e42d03ff05c9d29ab5b5b814e133084fc242e0413ad81dd317fe5405c2ae29027c2ae6dab8656e591d07999d13d2f87a70a885a997745d527d05b968cb1454259b72f80cf054a001700000000000e000c000009706f7374656f2e6465002b00050403040303000a00080006001d0017001800050005010000000000100007000504696d617000230000000d00140012050304030807080608050804060105010401000b00020100,
    },
}
2024-11-05T15:21:43.226560Z TRACE client::build: rustls::conn: Dropping CCS
2024-11-05T15:21:43.253327Z TRACE client::build: rustls::client::hs: We got ServerHello ServerHelloPayload {
    extensions: [
        SupportedVersions(
            TLSv1_3,
        ),
        KeyShare(
            KeyShareEntry {
                group: secp384r1,
                payload: 04e4e9c53dfc83202dcffd679cbf88b468c9b4743d96b21fc64da18153f3a9202e6040dca510efa13527bdd0242c3674b7b858637484910f2ec19608b8f3610971e6f38ca511b17d29934c1d443fee4f3cc61a4efa9967dbe532bbbc0c82c69141,
            },
        ),
    ],
    legacy_version: TLSv1_2,
    random: 5b33236e7196b56beff305c9243278f217996d1d40c42e500c2fdbf2a653e35a,
    session_id: 7686b848821d0d500a67ccc707c0be58f4ae79a142fb6965ebc9e9051007cc3b,
    cipher_suite: TLS13_AES_256_GCM_SHA384,
    compression_method: Null,
}

I notice that your server drops straight the ClientHello message (due to TLS 1.0?), whereas my server sends a HelloRetryRequest which allows me to try TLS 1.2. I will investigate and let you know.
Does your server support STARTTLS? If so, could you try?
PS: you can now download a pre-built binary from the CI, which prevents you to rebuild the project. This only work if you use default cargo features!

This is the full error: ConnectTls(Custom { kind: InvalidData, error: AlertReceived(HandshakeFailure) }). I will open an issue to rustls to seek for help.

To summarize: rustls is not compatible with your server. I tried many other crypto providers and none worked. One went a bit further but still failed later on. The last think I could do is to try with OpenSSL, but I need to refactor to many things first. Let's keep this issue open till I finally capable of testing with OpenSSL.

Ok... Sad news.
Just two comments:

if I use start-tls in the config file, himalaya seems to enter a loop of something. Running himalaya --trace I get:

2024-11-06T00:20:50.677849Z  INFO himalaya::email::envelope::command::list: executing list envelopes command
2024-11-06T00:20:50.679704Z DEBUG email::imap: building 1 IMAP clients

And nothing else happens. It looks like it is trying to build the IMAP client for ever.

The server is supposed to be compatible with TLS 1.2

Some time ago I tried meli-email, and I was able to configure it and access my mail. I don't know if meli uses rustls.

Thanks for checking this out!

if I use start-tls in the config file, himalaya seems to enter a loop of something.

It basically means that the server does not support STARTTLS as well. Although he infinite loop is strange, I will check if there is not an issue with the retry algorithm

The server is supposed to be compatible with TLS 1.2

After investigation from Rustls, it's not a TLS version issue but more a ciphersuites one. Your server seems to only support an old, insecure algorithm (DHE) that is purposefully not handled by Rustls.

Some time ago I tried meli-email, and I was able to configure it and access my mail. I don't know if meli uses rustls.

If I do not mistake, meli only supports native-tls. Good news: it confirm the fact that Himalaya would work with native-tls. Bad news: we are still far from supporting it, yet it's at the top priority. Here a mini-roadmap of what is missing:

[ ] I am currently working on a compat layer for TcpStream and TlsStream. I am still prototyping it, so it may change. The idea behind is to use a common enum TcpStream or TlsStream supporting different backends, including Rustls and OpenSSL (via Native TLS).
[ ] The low-level crate imap-next used for IMAP only supports Rustls at the moment. It needs to integrate a compatibility layer (like the one I am working on).
[ ] The high-level crate imap-client also supports Rustls only.
[ ] The high-level email-lib also supports Rustls only (it just requires some cargo feature forwarding tho)
[ ] Finally, Himalaya CLI also supports Rustls only (it just requires some cargo feature forwarding tho)

Stay tuned! I will update this issue every time a new step is done.

FWI, I change the scope of this issue. It now stands for cargo features unification and support for different TLS providers (which would solve your initial issue).

Support other TLS providers is a bit more challenging than expected (regarding the actual state of the code). I was able to prepare the code for such feature, but it will come to the CLI in another minor or patch version, after the v1.0.0.


How to add custom message with micro_ros_stm32cubemx_utils

Hi everyone,
I am new to micro-ROS and I wish to know if is there any method that I can define custom .msg file using the micro_ros_stm32cubemx_utils. I found a tutorial in
https://micro.ros.org/docs/tutorials/advanced/create_new_type/

However, it is based on the setup in
https://micro.ros.org/docs/tutorials/core/first_application_rtos/

I am confused about how can I define a custom message with the setup of micro_ros_stm32cubemx_utils, because I didn't find "firmware/mcu_ws" folder mentioned in the tutorial. Is it because micro_ros_stm32cubemx_utils build is based on the Docker? Maybe I need to modify the library generation file?
/micro_ros_stm32cubemx_utils/microros_static_library_ide/library_generation.sh

Appreciate your great help!

Hi,
I found a useful tip for adding a custom message and it is successful.
https://github.com/micro-ROS/micro_ros_arduino/issues/14#issuecomment-722242175

The custom msg should be created in the folder just as usual ros2 message
micro_ros_stm32cubemx_utils/microros_static_library_ide/library_generation/extra_packages


Use cosign's claim verifiers

Cosign has built-in support to ensure the fetched signature and attestations match the image being verified. This commit uses that feature for both signatures and attestations.
This is what the removed code intended to do for attestations. However, it did nothing for signatures :O

I guess we trust cosign to do this correctly, should we have a test that verifies that?

Yes. Filed https://issues.redhat.com/browse/HACBS-2068 for that.


Client-side Callbacks when a Job executes

Allow clients to register for a callback when a Job is executed
Callback can contain either execution result (success scenario) or exception (failure scenario)

cc @bsless

Questions

Callbacks make more sense in context of a batch. Should we only reserve them for Batches(#105) or allow individual Jobs to have callbacks as well?
Should a callback be (A) a simple function that's provided when creating a Batch or (B) 2-way communication between Application<>Worker over the message broker?
A is easier to implement, won't affect performance of Application and will solve most use-cases
B is more difficult to implement, will affect performance of Application
I suggest we do A. Users wanting B will have to add an API to their Application and call it from the Callback function in Worker


WIP - stm32f4 esp8266 example

I'd like to pick up where I left off on this once @lulf helps me with a BufferedUarte or equivalent for stm32

@jcrossley3 I spent last week trying to shaping the nRF buffered uart into something that could be used for stm32 as well, but in retrospect I think I started in the wrong end here. I also have a different STM32 board, so I would need to port one for my own board first.
Given that there is so many changes coming to STM32 in embassy, I will change my strategy to build on the stm32-neo work that @bobmcwhirter is already doing for STM32 and make that work with my board (STM32L0) first.
Might take a bit longer, but probably a better approach in the long run.

Sounds good to me @lulf. I fared no better exploring the latest knative eventing/faas stuff this week than I did on the stm32 example. :)

@jcrossley3 Ok, good news. There is now a buffered uart example with wifi and TLS now: https://github.com/drogue-iot/drogue-device/tree/main/examples/stm32h7/nucleo-h743zi/esp8266
Adapting this to your F4 shouldn't bee much more than changing pins and embassy features in Cargo.toml.

@jcrossley3 I've created a rebased version of this branch in #116 that uses the not-yet-merged buffered embassy usart for your board. I've made it use the 'drogue-temperature' example application, so it should work out of the box with drogue cloud. I've left the TLS bits as an exercise for the reader :)  But the other examples give you an idea of how to do TLS.


[T4A3][W15-B1]Sriram Sami

Ready for review.

This is a good way to reduce the complexity of the inheriting class constructors (by passing the regex to the base class and checking validity there).
Missing header comment on Contact class.
Other things are done well.


GSD Request

--- GSD JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v5.15 to before v5.16.11",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=fa5d823b16a9442d609617abeec31da8b6afa224",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=d7de1e4820c5a42441ff7276174c8c0e63575c1b"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "fa5d823b16a9442d609617abeec31da8b6afa224",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "d7de1e4820c5a42441ff7276174c8c0e63575c1b",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "dmaengine: ptdma: Fix the error handling path in pt_core_init()\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.16.11 by commit d7de1e4820c5a42441ff7276174c8c0e63575c1b, it was introduced in version v5.15 by commit fa5d823b16a9442d609617abeec31da8b6afa224. For more details please see the references link."
}
--- GSD JSON ---

This issue has been assigned GSD-2022-1000564


(E) mode small mode (sS) (aA)

(s) subword mode
(S) superword mode
(A) auto complete mode
should be easy to toggle

Which key to use? to toggle mode?

C-t is nice to use

C-t s to toggle superword and subword
C-t a to toggle auto complete and M-/ style


How should canonical URLs be validated?

Currently we force canonical URLs declared in the meta tags to be on the same domain as the base document:
https://github.com/commonsearch/cosr-back/blob/master/cosrlib/document/html/htmldocument.py#L346
Is this requirement too strict? If we relax it (same root domain? same DNS owner? any domain?), would some abuse/impersonation be possible?

You can't restrict based on domain because rel="canonical" is used for attribution across sites.  For example, I regularly post things on my own personal blog and my employer's blog.  They don't pay me for blog posts, so I have them insert a rel="canonical" link.


Help needed to read read-optmized view from Hoodie tables

Hi,
I am trying to read the RO view of the Hoodie data from s3 using spark data source. I am little confused from the documentation on how to read this data.
its working from when read the data as parquet(sc.read.parquet) direct to the path till the partition. But i am just wondering how do we need to approach this if i want to directly read the datasource as either hoodie table from spark.
Quick help is much appreciated

@HariprasadAllaka1612 : Not enough context here to find out what is going on. Can you see if the below link helps you
https://github.com/apache/incubator-hudi/blob/69ca45b2da0f1791d4d8f049726a31ba3d90dcd7/hudi-spark/src/test/java/HoodieJavaApp.java#L190


sourceMappingURL Directive Missing

Hi, I'm not sure if this issue needs to be raised here or in the main 6to5 repo.
I've set sourceMap: true in my gruntfile options, and the source maps are produced, but the sourceMappingURL directive is not added to the output JS files. sourceMap: 'inline' appears to add the directive correctly.

I'm having the same issue

Also having his issue, had a quick look, doesn't seem to be anything in the lib even trying to add this, did it work before? (just using this today)
Could only find Utils.addSourceMappingUrl referenced from CLI api


Button is sometimes over the player

Player should always be above other sprites. A sprite layer for tiles should fix this.

Fixed with commit 4da78e1b14fba661f50642a1b36ba83fa0ab644b


Generate Flow response objects as exact

Flow types that represent response values (rather than input values) could probably be defined as “exact” objects, using {| |} instead of { }. See: https://flowtype.org/docs/objects.html#exact-object-types
Per the above link, “Exact object types are a very useful tool for helping Flow to refine unions of object types and notice typos on property names and refinements.”

I haven't used Flow myself, but that sounds right! Do you want to submit a PR for this?

Sure, I'll give it a shot. Will also see what the consequences are for making the input types exact and see if that's worth doing, too.

The way that fragments are combined with & makes this not viable right now, because combining exact objects leads to an exact intersection which then typically doesn’t match anything.
Flow is planning to add a spread operator to combine objects within the next few releases, so I can get back to this then.


NIFI-13479: Remove imports to fix autocomplete issues

NIFI-13479:

Remove unnecessary imports which was impacting the ability to use EL and Parameter autocomplete.

Reviewing...


347 user following and followers change

Following and Follower Pop up tabs in the profile menu now open for all users. The follow and unfollow buttons will act in accordance to the user opperating the site instead of the user whos page is being viewed. Currently the page reloads upon file. This takes a while and I will make an issue to fix it. In order to get around reloading the page, a bunch of use states and contexts will need to be sent to the pop up files so that they can be corrected uppon a user pressing follow or unfollow.

Pull from main broke something

Fixed issue


Steal CSV column type inference logic from csvkit

csvkit will, for example, infer that columns with 'Y' and 'N' as values should be boolean (using csvsql). odo currently doesn't do that. It also knows lots of dialects.
I'm building a conda package for csvkit right now for python3, @asmeurer already built one that's in his channel on binstar. You can just look in my binstar channel (same as davclark), or nudge me. It's not there yet.

csvkit has an annoying dependency on openpyxl=2.2.0-b1. I'm using the py34 version from desilinguist on binstar.

What dialects are you referring to? SQLAlchemy dialects or CSV dialects? It looks like the only additional functionality for dialect sniffing is here: https://github.com/onyxfish/csvkit/blob/master/csvkit/sniffer.py and it just adds more delimiters. We use sqlalchemy as well, so whatever dialects are supported there are supported here.
I'm not sure how we would compute against something like 'Y' and 'N' inside blaze. For example if I had a symbol like this
t = symbol('t', '10 * {a: bool, b: int64}')

and my datastore actually has values 'Y' and 'N' in the a column, how would we tell it to map those values to boolean values.

I meant sql dialects, which is related to the issue, but it's not central.
Postgresql accepts "y" and "n" as literals for boolean. So, when csvkit encounters a column with those values in a CSV, it maps to Boolean for the generated table creation code. And then a bulk load with psql/COPY will load y/n fine into a Boolean column.
http://www.postgresql.org/docs/9.4/static/datatype-boolean.html
CSV, being implicitly typed, will always have issues around this kind of logic. Using Boolean here seems right, but it's not necessary.


Key board remapping not working in git

Microsoft PowerToys version
0.68.1
Installation method
PowerToys auto-update
Running as admin
None
Area(s) with issue?
Keyboard Manager
Steps to reproduce
I remapped Esc & Caps Lock keys in PowerToys and it works fine in VS Code and everywhere else. Except in cmd. I found this problem when editing git commit info in cmd. Here are scenarios this problem occurs (some with screenshots):
CMD from windows terminal with Clink & Oh-my-posh extensions

Staring cmd without using windows terminal
✔ Expected Behavior
No response
❌ Actual Behavior
No response
Other Software
No response

This not unfinished edit was accidentally published.


Importing dataforseo_client takes tens of seconds

Just the simple import made my service startup time increase by over 15 seconds.
Is there something you can do so that importing is faster?

Much better, yes, thank you for the quick response!


add partition metadata manager

This is a follow up on #10455
This PR adds:

[x] TimeBoundaryManager to SegmentZkMetadataCache management
[x] Create PartitionDataManager which similar to SinglePartitionColumnSegmentPruner but kept a very different view of the map

[ ] create Map<PartitionID, List<Server>> partitionToServerMapping to indicate whole-partition-on-a-single-server
[ ] create Map<PartitionID, List<Segment>> partitionToSegmentMapping to indicate partition and segment relationship

Codecov Report

Merging #10461 (dd8afa9) into master (c0d0896) will decrease coverage by 10.52%.
The diff coverage is 64.96%.

@@              Coverage Diff              @@
##             master   #10461       +/-   ##
=============================================
- Coverage     24.44%   13.93%   -10.52%
- Complexity       49      237      +188
=============================================
  Files          2042     2017       -25
  Lines        111146   109573     -1573
  Branches      16933    16749      -184
=============================================
- Hits          27174    15265    -11909
- Misses        81132    93062    +11930
+ Partials       2840     1246     -1594

Flag
Coverage Δ

integration1
?

unittests2
13.93% <64.96%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...mentpartition/SegmentPartitionMetadataManager.java
0.00% <0.00%> (ø)

...che/pinot/broker/routing/BrokerRoutingManager.java
60.49% <53.12%> (-24.47%)
:arrow_down:

...outing/segmentpartition/SegmentPartitionUtils.java
70.37% <70.37%> (ø)

...mentpruner/SinglePartitionColumnSegmentPruner.java
61.90% <76.47%> (+0.68%)
:arrow_up:

...oker/routing/timeboundary/TimeBoundaryManager.java
82.29% <76.92%> (+16.98%)
:arrow_up:

...routing/segmentpartition/SegmentPartitionInfo.java
80.00% <80.00%> (ø)

...mentpruner/MultiPartitionColumnsSegmentPruner.java
67.60% <86.36%> (+67.60%)
:arrow_up:

...oker/routing/segmentpruner/EmptySegmentPruner.java
84.78% <87.50%> (+84.78%)
:arrow_up:

...outing/segmentmetadata/SegmentZkMetadataCache.java
88.15% <88.15%> (ø)

...er/routing/segmentpruner/SegmentPrunerFactory.java
93.58% <100.00%> (+51.56%)
:arrow_up:

... and 1 more

... and 921 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Update gradio_app.py

+1 for JuggernautX

Also, @lllyasviel - Not sure if you're looking for any help, but I'd be happy to help maintain this if you wanted. I don't have an over-abundance of time, but I'm sure this is gonna blow up and you're going to have your hands full, so I figured I'd offer before then.

Also, @lllyasviel - Not sure if you're looking for any help, but I'd be happy to help maintain this if you wanted. I don't have an over-abundance of time, but I'm sure this is gonna blow up and you're going to have your hands full, so I figured I'd offer before then.

Looking forward to your PR submission

Also, @lllyasviel - Not sure if you're looking for any help, but I'd be happy to help maintain this if you wanted. I don't have an over-abundance of time, but I'm sure this is gonna blow up and you're going to have your hands full, so I figured I'd offer before then.

Looking forward to your PR submission

See #27 ;)


model library preparation

Deliverable this task is associated with
6
RACI
Responsible: @mslarae13 @turbomam @aclum
Accountable: @turbomam
Consulted:
Informed:
Describe the task?
Using NEON as an example to model library construction

[ ] generate example valid data
[ ] new Class LibraryPreparation
[ ] slot updates as needed
[ ] enumeration updates as needed
[ ] updates to Class Database for library_preparation_set

Work is being done in this branch of nmdc-schema
Criteria for completion
A Class LibraryPreparation exists in a released version of the NMDC schema along with example valid data.
Completion Date (Goal)
June 16
Target Sprint Start & End Dates
Start: May 22
End: June 2
Tag Blocker/Contingent upon issues

it seems like we have some conflicts between whether this topic should be called library construction or library preparation
either is fine with me, but we should be consistent in the terms used in the schema and the terms we use in our discussions

As discussed at the squad meeting today we are using 'library preparation' in line with OBI ontology.

@turbomam is there a reason https://microbiomedata.github.io/nmdc-schema/LIBRARYTYPEENUM/ is all caps instead of camelcase like the other enums?

Last thing here is to update the date slots. example valid data
https://github.com/microbiomedata/nmdc-schema/blob/issue-917-neon-story/src/data/valid/Database-neon-story.yaml

One checkbox left, will move to new sprint to complete

The last slot that I wanted for Class LibraryPreparation isn't urgent for ESA so I made a separate issue, https://github.com/microbiomedata/nmdc-schema/issues/1000, so we can close this one.