Set tables.mutations.parent column when converting to tskit

Currently, the tables.mutations.parent column is not set during conversion to tree sequence format. But when this is the case and there are multiple mutations at a site that "stack" (e.g. are descended from one another) then some tskit routines will bug out (see https://github.com/tskit-dev/tskit/issues/2923).
There's a helper function in tskit to compute the mutation parents:
tables = tskit.TableCollection()
# build tables here
tables.compute_mutation_parents()
tables.sort()
ts = tables.tree_sequence()

but, this routine requires that mutation IDs are ordered such that a given mutation's parent has a lower ID (e.g. was inserted into the table earlier). This isn't the case currently, but if the mutations are added in reverse time order at a given position, then the above should work.

Thanks a lot @nspope ! I will follow your suggestion and make a new converter.

Just a note to self that this might cause issues for tskit's stats with flipped mutations -- if I'm understanding SINGER output correctly, if a mutation is flipped, then SINGER introduces a new mutation above the root that changes the state from 0 -> 1 (so that the original mutation then changes the state back from 1 -> 0). I'm not sure if the missing mutations.parent attribute will screw up tskit stats in this case, or not (given the "parent" is above the root).

The code snippet above isn't quite right -- what seems to be the easiest is rebuilding the mutation table at the end, then sorting/indexing/computing parents. Here's what works:
# <build tables here>
# rebuild mutations table in time order at each position
mut_time = tables.nodes.time[tables.mutations.node]
mut_coord = tables.sites.position[tables.mutations.site]
mut_order = np.lexsort((-mut_time, mut_coord))
mut_state = tskit.unpack_strings(
    tables.mutations.derived_state,
    tables.mutations.derived_state_offset,
)
mut_state, mut_state_offset = tskit.pack_strings(np.array(mut_state)[mut_order])
tables.mutations.set_columns(
    site=tables.mutations.site[mut_order],
    node=tables.mutations.node[mut_order],
    time=np.repeat(tskit.UNKNOWN_TIME, tables.mutations.num_rows),
    derived_state=mut_state,
    derived_state_offset=mut_state_offset,
)
tables.sort()
tables.build_index()
tables.compute_mutation_parents()
ts = tables.tree_sequence()

Hi @nspope , thanks for your input on the mutation handling. I feel that my current implementation is not quite fulfilling all requirements. I happened to need to do some mutational analysis myself, so I will look into this systematically over the next few days. It seems that your previous answer is a good solution and I will test and incorporate it into a potential new converter.


Use valid identifier for on' in ffi

I know theres's another PR at https://github.com/purescript-contrib/purescript-jquery/pull/23 but I've opted to use the identifier proposed by @garyb.
Related to https://github.com/purescript/purescript/issues/2011

:+1:


[Lua]Update API documentation

This is a WIP for generating the Lua documentation with ldoc à la doxygen,
I was able to resurrect the original usage of ldoc in the build process but I'm not sure about it.
ldoc depends on Penlight which in turns depends on LuaFileSystem.
ldoc and Penlight are pure Lua but LFS is a C module.
Nominal usage is having the user install Lua on her PC, then install LuaRocks (a Lua package manager) and then install the modules/dependencies with it. LFS being a C module, you need to have a compiler properly defined so LuaRocks can compile the C stuff on the fly during installation.
I'm not a fan of this, I prefer having all the tooling available in the git repo directly instead of depending on package managers fetching who knows what off the internet. Also I don't know how to do this on github CI.
As a result the current solution is done with vendoring LuaFileSystem, Penlight and ldoc in the Extern directory.
None of the 3 provide files for cmake integration so that's an added difficulty.
I'm really not good with cmake and will probably need help in making a clean integration of this in the build chain.
It looks like the Lua version we're using is the [really] old 5.1, ldoc crashes with it. I had more success with the 5.1.5.
Since it's included as a submodule, I'm not sure how to do a PR to upgrade it. Also the repo it was forked from does not provide a 5.1.5 tag, that's an additional problem...
That being said, the generated doc is quite out of date compared with the hardcoded HTML one (skp is not described for example), but updating it is really easier than messing with the HTML manually so it should not take that long to have it updated.
I'm attaching a sample with this PR so you can see what it looks like : orbiter_lua.zip
Edit :
Looks like ldoc did not crash in CI, hooray...

Noticed some problems with page width, code example boxes and equations but otherwise it looks good to me.

Some more work on this ; there should be one more iteration with content and then a final pass for corrections.
For reference, it looks like the ldoc crash happens when there is no empty line between a ':' and list elements :
 crashme:
 - a
 - b

This triggers an assert 100% of the time in debug builds,

ldoc is returning an error I can't reproduce on my side :(
Don't know if it's a dependency issue or if the program crashes, there's not much logs to investigate.
Is it possible to run an interactive session?

Squashed everything, there are probably still some corrections to make but I think it's ready for merge.


Made outfitting schema tolerant to all-lowercase data coming from out…

Outfitting.json produces 'lowercased' identifiers like int_cargorack_size1_class1, hpt_beamlaser_fixed_huge, cobramkiii_armour_grade2 - which do not match Hpt_, Int_, _Armour prefixes required by outfitting-v2 schema. This pull request expands the validation so that lowercase identifiers are also valid

You need to amend the settings file to take I to account there names file.

Is this PR introducing a new schema version or not?
If yes - the schema number should be changed here and a new file created representing the new schema version.
If no - the schema filename should not be changed.

This PR increments minor version of schema (pursuant to SemVer, as there's no breaking changes). Schema URL does not include minor version - only major - hence no change in it.


RebirthDB

Hey, listen! I don't know if your driver already supports fully the 2.3 version, but we've forked RethinkDB to release a 2.4 version and all drivers will have separate repositories under our organization, discussion here: https://spectrum.chat/rebirthdb
So I'm inviting you to join us, there you can have more visibility for your project, what do you think?

I don't know if your driver already supports fully the 2.3 version

Not yet. It's still a work in progress and far from production ready.

but we've forked RethinkDB to release a 2.4 version

Yeah, I noticed that a few days back on the RethinkDB repo. As a RethinkDB user, I greatly appreciate all your efforts in that endeavor.

all drivers will have separate repositories under our organization... So I'm inviting you to join us, there you can have more visibility for your project, what do you think?

If you are willing to also house drivers that are not yet production ready, I don't mind.

Yes, we(RebirthDB) want to attract newcomers from every language

I will add you as a member of the org

OK, great.

I've joined. Thanks.


add js_periodic to parse

Small PR to add js_periodic to the parser.

@vivki Please add test cases to TestAnalyze_njs

LGTM, will let @ornj  approve.


What is the correct way returning a "new View()" from controller when using auryn?

Hi,
I'm new to auryn and I'm still learning about IoC Dependency Injector. Anyway, please tell me if I understanding this correctly. Let's say I have a framework that executes a Controller class. The output of the controller is returned as new View class.
Hypothetical code:
Class SampleController {
    public function run() {
        return new View('content.html');
   }
}

Class View {
   public function __construct(string $template, Logger $logger) {
           $this->template = $template;
           $this->logger = $logger;
   }
}

Now as far as I can understand I should be using $injector->make('View') instead of new View() as the last statement in my controller. So does that mean I should be passing the $injector to all my controller functions when calling them like this:
Changed code:
Class SampleController {
    private $injector;

    public function __construct(Injector $injector) {
        $this->injector = $injector;
    }

    public function run() {
        $this->injector->make('View', ['content.html']);
   }
}

Is this the correct way of doing it or Is there some other way that is better? Thanks for helping me understand this.

Yes, this makes far more sense to me now! Thanks again for the guidance!


reponse based previous statements

Is there a way chatterbot can respond previous statements for example, In the below example i am referencing jira xx-1234 only first time.
Statement: /jira what is the status of xx-1234
Response: It's in retest
Statement: /jira can i get latest comments?
Response: X Said It should be fixed by next month

Few ideas i am not sure will it work or not
Maintain lookup table for statements if user always referencing a particuler thing, This might be slow down process, but it's worth to maintain good conversation with bot.
Any thoughts/suggestions?

In this case, what if you modified your logic adapter to have a variable like self.last_ticket_referenced. Then, if the input contains the desired trigger phrase, self.last_ticket_referenced is updated to match. Perhaps something like this:
class JiraLogicAdapter(LogicAdapter):

    def __init__(self, **kwargs):
        super(JiraLogicAdapter, self).__init__(**kwargs)

        self.last_ticket_referenced = ""

    def can_process (self, statement):
        is_match = re.match(r'^/jira', statement.text)

        if is_match:
            self.last_ticket_referenced = # Insert code to get ticket id from text here

        return is_match

This will allow the logic adapter that handles jira related input to keep track of the last ticket that was mentioned by the user.

@gunthercox This wont work if multiple users are asking for the ticket status, because last_ticket_referenced will change (considering that there is only a single chatbot instance)
You will have to spawn multiple chatbots or use mongo DB to store these values

@rmdort agreed with you, If i use mongo DB how do i handle this situation? could you provide a example scenario?

I usually have a Users class which syncs the data with mongo
This might help. PS: I am using websockets,
https://gist.github.com/rmdort/be125bf5ab04876bf073563dc755ef7d
Maybe there is a better way of doing it. Open to feedback

I think the same question i was asked here https://github.com/gunthercox/ChatterBot/issues/2

Closing this issue it is going address in #2


Remove analytics

LG but I used handlebars comments instead of html comments. This way the comments won't render in the browser.

Thanks @WCRest - didn't think of Handlebars comments. Will merge in all 3 PR's where you corrected this :)


Write maid scripts to package.json

Fixes #24
Adds the ability to write all maid tasks out to the package.json for easier consumption of tasks.

[x] add cli command
[x] implement script writer
[ ] document command
[ ] add lint-staged example
[x] dogfood setup
[ ] account for pre/post scripts
[ ] tests

Okay, so I've made definite progress. The core of the functionality is there and the project itself is using it. There are still some outstanding issues though.

when pairing this up with lint-staged the maidfile is what will trigger the script update... but the package.json is the file that will change. How do we signify that a git add should happen?
I implemented this as a global option, but I'm not convinced it shouldn't just be a command... I started down that path, but I backtracked because I didn't want to pollute the command space.

Thought of another issue. pre and post tasks will conflict with the package.json's version.
Let's say there are two tasks... prebuild and build. Running yarn build would trigger yarn prebuild which would run the prebuild task... but that task would be ran again by maid before build started. So we may need to filter those out before writing the tasks.

Remove the implementation of pre and post and rely on the scripts for that?
Few positives from that:

lower code
battle tested handling
better "out of the box behaving" - so no need to write "run that before this and after this" kinda sentences. Just say users that if they want hooks, they can use: a] package scripts for hooks - so will be able to run maid build and that will executethe prebuild script that points to maid test, or b] just call the desired tasks in what order they want - e.g. maid test build to run test then build task.

The 3.a may be a bit trickier probably, but second one is whole lot easier and obvious and familiar.
So let's rephrase...
Scenario 1
User syncs scripts.
{
  "scripts": {
    "test": "maid test",
    "build": "maid build"
  }
}

If he want to run test before build would just run maid test build (npx maid test build or yarn maid test build) which requires the implementation for running multiple tasks, a la gulp? Btw, comma separated tasks.
It's clean, obvious, familiar, less verbose (on tasks and scripts definition) and the multiple tasks impl would be smaller.
Scenario 2
User syncs the scripts (with that PR's command) with specific flag (can't come name for that flag to my mind ;d). This command is implemented with the current idea of defining sentences, respect them (only?) when ran with that flag...
maid update-scripts --hooks

generates
{
  "scripts": {
    "prebuild": "maid test",
    "build": "maid build"
  }
}

from this maid file
## build

Build our main app

<!-- Following line is a maid command for running task -->
Run task `test` before this

\`\`\`bash
# note that you can directly call binaries inside node_modules/.bin
# just like how `npm scripts` works
babel src -d lib
\`\`\`

## test

Test all the things.

\`\`\`bash
ava tests/**/*.js
\`\`\`

foo bar

doh how ugly is my last code block... how you handle the markdown in markdown situation, here in github issues?! :rofl:

@egoist I would actually be all for removing the pre and post commands... but I understand why they're there and I'm not looking to make that change in this PR.
I added logic to check every task that starts with pre or post against the list of tasks. If the a task exists that is the representative base task (i.e minus pre or post) then it won't write the task.
That means if there's a prebuild and build command then only build will be written. But if a precommit task exists, but commit doesn't, then precommit will still be written.

@egoist I still need to add tests but this works/is ready for review.


Default numeric array values merged after deletion

Describe the bug
Default numeric array values are being merged after deletion.
To Reproduce
Steps to reproduce the behavior:

Define a numeric array as default settings

public $defaultSettings = [
    'presets' => [
        'first',
        'second',
    ],
]

Add a setting, and save it.

$presets = $model->settings()->get('presets');
$presets[] = 'third';
$model->settings()->set('presets', $presets);

/**
 * Database JSON result:
 *
 * "presets":[
 *     "first",
 *     "second",
 *     "third"
 *. ],
 */

Remove "second" from the settings and decode the value:

$model->settings()->delete("presets.1");

/**
 * Database JSON result:
 *
 * "presets": {
 *     "0":"first",
 *     "2":"third"
 * },
 */

$model->settings()->get('presets');

/**
 * JSON result:
 *
 * "presets": {
 *     "0":"first",
 *     "1":"second",
 *     "2":"third"
 * },
 */

Expected behavior
Now, the default setting 1 with value second is being merged, but it shouldn't exist anymore.
I don't know if this is even possible, but I wanted to ask here before I change to associative array's ;-)
Isn't it possible that if the setting already exists, the defaults aren't being merged anymore?
Or, is there a workaround?
Thanks!
Desktop (please complete the following information):

OS: MacOS
Browser: Chrome
Version: 88

@edwinvdpol Hello, I think the best solution is to use change to associative array's.


WAV format with MS_ADPCM subtype always reads back a longer array than what was written

We are running into a funky little issue using soundfile in a different project here:
https://github.com/justinsalamon/scaper/issues/94. Basically, when an audio file is WAV with subtype MS_ADPCM, the shape of the numpy array we write to disk and the shape of the numpy array we read back from disk are not the same.
import soundfile as sf
import numpy as np
import tempfile

_format = 'WAV'
_subtype = 'MS_ADPCM'

sr = 16000

for l in [1600, 16000, 32000, 64000, 100000, 128000]:
    original_shape = (l,)
    audio = np.zeros(original_shape)

    with tempfile.NamedTemporaryFile(suffix='.wav', delete=True) as tmpfile:
        sf.write(tmpfile.name, audio, sr, subtype=_subtype, format=_format)
        audio, sr = sf.read(tmpfile.name)
        print('What I got back from sf.read\t', audio.shape)
        print('What I meant to write to disk\t', original_shape)
        print()

Running the code above results in the following bizarre set of input and output shapes that I can't make heads or tails of:
What I got back from sf.read     (2024,)
What I meant to write to disk    (1600,)

What I got back from sf.read     (16192,)
What I meant to write to disk    (16000,)

What I got back from sf.read     (32384,)
What I meant to write to disk    (32000,)

What I got back from sf.read     (64768,)
What I meant to write to disk    (64000,)

What I got back from sf.read     (100188,)
What I meant to write to disk    (100000,)

What I got back from sf.read     (128524,)
What I meant to write to disk    (128000,)

I thought I'd open an issue about it. Let me know if you need any more information!

From your examples, I would assume that there is a built-in block size in MS_ADPCM, likely 1012 frames. This is either a built-in assumption of MS_ADPCM, or a limitation of libsndfile. Either way, there is probably nothing you can do within SoundFile short of using a different subtype.
(What process requires MS_ADPCM files? I have never heard of that format.)

Interesting - sounds about right. And neither have I until the bug in the linked issue was reported. Tracking it down led me to this behavior in SoundFile/libsndfile, so I thought I'd just report to keep a record of it somewhere.
We are using audio files from https://freesound.org/. freesound has really no restrictions on the formats or types of audio files you upload. So I'm guessing the file in question that had that subtype came from some sort of niche field recorder or perhaps an old phone or something like that, got encoded in a strange fashion, and then uploaded. But reformatting the file using ffmpeg into a more common format fixed that issue.
Thanks!


Azure CLI ML extension version misalignment

The azure cli machine learning extension version in the documentation does not correspond to the available versions when running az extension list-available --output table (version returned with this is 1.24.0).
Also installing an older version of the extension is not available. When using az extension add -n azure-cli-ml --version 1.23.0 the message returned:
Traceback (most recent call last):
  File "/opt/az/lib/python3.6/site-packages/knack/cli.py", line 233, in invoke
    cmd_result = self.invocation.execute(args)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 660, in execute
    raise ex
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 723, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 716, in _run_job
    six.reraise(*sys.exc_info())
  File "/opt/az/lib/python3.6/site-packages/six.py", line 703, in reraise
    raise value
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 694, in _run_job
    result = cmd_copy(params)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 331, in __call__
    return self.handler(*args, **kwargs)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/__init__.py", line 808, in default_command_handler
    return op(**command_args)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/command_modules/extension/custom.py", line 18, in add_extension_cmd
    version=version, upgrade=upgrade)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/extension/operations.py", line 315, in add_extension
    raise CLIError(err)
knack.util.CLIError: No matching extensions for 'azure-cli-ml (<IP_ADDRESS>)'. Use --debug for more information.

To ensure this was not an error on the devops agent this command is being run on, I checked on my local machine what the results of azure.cli.core.extension.operations.list_versions(‘azure-cli-ml’)  would return and got :
[{'name': 'azure-cli-ml', 'version': '1.5.0', 'preview': False, 'experimental': False, 'installed': False, 'compatible': True}, {'name': 'azure-cli-ml', 'version': '1.24.0 (max compatible version)', 'preview': False
, 'experimental': False, 'installed': False, 'compatible': True}]

This suggests that older version installations are not supported through the extension installation arguments (or perhaps just the ml extension).
I require version 1.23.0 of the machine learning extension for troubleshooting as I have encountered multiple errors on 1.24.0 that I did not encounter on 1.23.0 and a simple version specification when installing is not something I believe should be omitted (particularly when the documentation shows it is possible).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4067dde0-6db0-4e37-1a8e-fe5bb9324c62
Version Independent ID: 8ba50218-429b-2c2a-eda6-8b1cfc62615f
Content: Available extensions for the Azure CLI
Content Source: docs-ref-conceptual/azure-cli-extensions-list.md
Product: azure
Technology: azure-cli
GitHub Login: @haroldrandom
Microsoft Alias: jianzen

@byronverz Thanks for the feedback. We're investigating this and will get back to you shortly.

@byronverz Thanks for the feedback. I have assigned the issue to the content author to evaluate and update the document as appropriate.

Hey @byronverz,
I'm sorry this has taken so long. It might be a moot point but is this issue persisting or should I close this issue?
Thanks for your patience (a lot of it) and I look forward to getting this resolved

Hi @chasewilson, I see the documentation and output of az extension list-available --output table are still different, I have managed a workaround for my issue but I don't think this type of mismatch in CLI and the docs is good.
If keeping this ticket open will ensure this mismatch is fixed then I think it should be kept open, otherwise you can close it thanks.

Hey @byronverz, there might be a slight delay in docs vs extension list since it's auto generated and needs manual review before merge right now but we are working on shortening that difference. current ml version and doc version are the same
Some of the extensions I can download older versions for but not all of them. I'll do some digging and see if we have standards of what extensions should support. Either way, we'll be updating clarify that part. Let me know if you have any more feedback or questions on this.


UI / Authenticate with Identifier

Authenticating with an identifier now involves signing an http request header. This was implemented in Milestone 3 by having the extension sign for a credential, signed with the issuee's identifier key-pair.


Option to toggle phase seperately

Describe the feature you'd like to have added
Another key bind to disable the phase feature on leggings. Also a menu to remove upgrades from armour or a way to do that would be useful.
Additional information
The phase feature on the leggings cannot be disable separately from the speed boost.

If that’s true it’s a bug and I’ll investigate.

Sorry, There is already a menu I just wasn't aware of it maybe add a tooltip to make it more obvious? It should probably be bound to a key by default, currently it is default -1 or not bound. Still a hotkey to quickly disable phase would probably be useful.

If you open up the tools menu by shift right clicking a tool (there’s also a hotkey) then click on the pants in that ui you can toggle stuff and assign hotkeys.


Getting com.microsoft.aad.msal4j.AcquireTokenSilentSupplier failed error on getting access token from clientSecret

Hi Team,
I am trying to get access token from clientSecret. Please find below code snippet.
`IClientCredential cred = ClientCredentialFactory.createFromSecret(clientSecret);
ConfidentialClientApplication app;
try {
// Build the MSAL application object for a client credential flow
app = ConfidentialClientApplication.builder(applicationId, cred ).authority(authority).build();
} catch (MalformedURLException e) {
System.out.println("Error creating confidential client: " + e.getMessage());
return null;
}
IAuthenticationResult result;
try{
    SilentParameters silentParameters = SilentParameters.builder(scopeSet).build();
    result= app.acquireTokenSilently(silentParameters).join();
} catch (Exception ex ){
    if (ex.getCause() instanceof MsalException) {

        ClientCredentialParameters parameters =
                ClientCredentialParameters
                        .builder(scopeSet)
                        .build();

        // Try to acquire a token. If successful, you should see
        // the token information printed out to console
        result = app.acquireToken(parameters).join();
    } else {
        // Handle other exceptions accordingly
        System.out.println("Unable to authenticate = " + ex.getMessage());
        return null;
    }
}`

But while running I am getting below error, can you please suggest me when changes I have to make.
I am using msal4j-1.9.1.jar.
[ForkJoinPool.commonPool-worker-1] ERROR com.microsoft.aad.msal4j.ConfidentialClientApplication - [Correlation ID: 7c7ce67e-*********]
Execution of class com.microsoft.aad.msal4j.AcquireTokenSilentSupplier failed.
com.microsoft.aad.msal4j.MsalClientException: java.net.SocketTimeoutException: connect timed out

Hi @SuryaAnand302, can you provide more detail on which part of the repo this code relates to?
My first impression is that it would be better to raise this issue here: https://github.com/AzureAD/microsoft-authentication-library-for-java
But I want to make sure if you're using an example from our repo that is broken we can address it here too.

Hi @gramhagen, I have posted the first time so might posted on wrong window, so I'll take care it from next time.
Yes, the code is not from your repository, its from the docs.microsoft.com.

np, I will close this issue here then.


Explicit support for shallow objects

Currently if you read a commit with shallow parents (e.g. with parents which are not in the repository), Commit.parent will give you an empty list instead of telling you that there are parents, but not present. We should make that more explicit in the API instead of silently hiding that to the user.

This was "fixed" by #636


Incompatibility with serverless-domain-manager: Base path already exists for this domain name

I'm having trouble getting this plugin to work alongside the serverless-domain-manager plugin. I saw you added support for serverless-domain-manager in 1.7.0, however I believe my usecase isn't handled.
The error I receive is the classic:

pathmapping - Base path already exists for this domain name

In serverless.yml:
 customDomain:
    domainName: mydomain.com
    stage: ${{self:provider.stage}}
    basePath: v1

What I'm attempting to accomplish:
1.

Create base path mapping called 'v1', pointing to a stage (which is an alias thanks to your plugin)
a) Using the alias plugin: serverless deploy --stage dev --alias v1
b) So far this is working. A new entry in my Custom Domain is created and it points to the dev stage. The basePath v1 is created thanks to the serverless-domain-manager plugin.
Deploy a new API version to the 'v1' Custom Domain Name basePath with a new alias.
a) serverless deploy --stage dev --alias v2
b) This is when I get the pathmapping error.
c) The cloudformation-template-update-alias-stack CloudFormation stack is attempting to create the basePath again.

To recap, I was hoping that the basePath would be set to {function}:{stage} (e.g. myFunction:v2) but I get an error instead.
Additional tests:
I can get this plugin to work successfully if I update the basePath in serverless.yml and create a new alias on every serverless deploy call, but since I'm using the basePath for API versioning, this isn't a solution for me.
Any help or guidance would be greatly appreciated.

any ?

Any update ??


Why does msgpack.core/pack return a Seq?

In my opition, the main purpose of msgpack library is converting an object to msgpack-formatted byte-array or a byte-array to an object.
But msgpack.core/pack returns (seq (.toByteArray output-stream)). Why do you need use 'seq' here?
In older version of clojure-msgpack simplly returned a msgpack-formatted byte-array.
In 1.0.0, I need to convert the seq into a byte-array again before sending it into network...

My original intention was to return something more clojure-like and immutable. The obvious data-type that fits this criteria is a seq, but you don't get any of the benefits of laziness. I should just return the byte array to avoid the extra seq allocations.
By the way, if you plan on sending this over the network directly, are you able to use the streaming interface? It's more efficient.
Thanks for the feedback!

Hi, sorry for my late response. I think this issue is worth for a discussion, so I want continue...
First, I think returning a byte-array as a result of 'pack' is better. it is the most performative and no disadvantage as a clojure data (see next paragraph).
Second, I think it is not important a return value is a 'clojure-like' object (in this case, a seq), but the important point is that the return value is 'seqable' (object that be able to 'seq'), because most of clojure functions like filter, map or doseq etc automatically convert every passed parameter into a seq if it is seqable. So we don't need to care about the real-type of parameters before calling a clojure function. I think it is a clojure-way.
So it the return value of 'pack' is a byte-array, it will be treated a seq automatically.
At last, I want to explain about my usecase.
I'm using clojure-msgpack with Aleph (high performance TCP/HTTP server of clojure based on Netty. https://github.com/ztellman/aleph). Aleph (and Netty) is a Message-oriented (not stream-oriented), so every message is an object, and then converted into a byte-array and then pushed into a Channel. There is no OutputStream. So I don't use pack-stream, but use pack for converting an object into byte-array.
I think Aleph is a most famous TCP server of clojure, and message-pack is a library for TCP communications, so it is better that clojure-msgpack is easily applicable to Aleph (Netty). If the return value of 'pack' is an byte-array, clojure-msgpack will be more easily applicable.
Thank you.

Thanks for the explanation. I understand your use case and agree it should just be a byte array.
This is fixed in 180c338fdcba3bca.


test(e2e,playwright): Search

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Close

camperbot cant code

Thank you for your interest in contributing. While waiting for updates to this PR, we have merged another PR which comprehensively resolves the issue.
As such, we are going to close this PR. We gladly apply the hacktoberfest-accepted label so you can still get credit for your work, and encourage you to make further contributions!


nixos/libinput: refer to libinput manual

Motivation for this change
Make the possible values easier to find out
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

backported to 20.03 7f9c1d0ec3c4d2e164a32f0818be23a6c4eec23d


[kjobctl] Slurm delete e2e test.

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Add delete e2e test for kjobctl slurm.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Follow up for https://github.com/kubernetes-sigs/kueue/pull/3288#issuecomment-2432175113.
Does this PR introduce a user-facing change?

NONE

cc @mwysokin

/approve

/lgtm


Your copy of the BSD license terms is missing the copyright statement

You need to add a copyright statement to the top of your BSD license as referenced in the body of the license text. More info at this link: http://opensource.org/licenses/BSD-2-Clause

I agree with one exception: the project uses 3-clause BSD license, not 2-clause.

Also, this part has two essential words words missing – OR CONTRIBUTORS:
Current:
IN NO EVENT SHALL <COPYRIGHT HOLDER> BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES

Desired:
IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES

Sources:
http://choosealicense.com/licenses/bsd-3-clause/
http://opensource.org/licenses/BSD-3-Clause


Coinjoin?

"I have tested the BitBox02 hardware wallet and could not see a similar option to “trust PSBT.” I also tested a CoinJoin and it declined to sign due to an unrecognised input, i.e., it noticed the CoinJoin partner’s input address did not belong to itself. So, I can’t see a way to use the BitBox02 for CoinJoining."
https://bitcoinmagazine.com/technical/a-comprehensive-bitcoin-coinjoin-guide
Is that still the case?

Hi there,
We use GitHub issues as a place to track bugs and other development-related issues.
Please see the link below to our dedicated support line:
Help Center :  Click Here
Ticket ID: WR240
Note: Click on the live chat icon at the bottom corner of the page to start a conversation.

@Sami32 don't engage with the support link of the previous commenter, they are a scammer trying to steal your coins.
As for your issue: that is correct, the BitBox02 does not sign transactions inputs that don't belong to it, and so is not able to sign coinjoin transactions.

Thank you very much +1
The i should add it as a feature request, and ask to add it like in the Coldcard Hardware Wallet:
_"The Coldcard by default checks that the addresses the coins are being spent from belong to the private key it holds. But remember, a CoinJoin transaction contains UTXO inputs from other peoples’ wallets too.
The way it checks is by requiring the xpubs to be part of the transaction you import to it, and then it can recognise if the addresses contained in the transaction belongs to itself or not.
We need to change this default behaviour to do CoinJoins.
After logging in, go to the  menu, then , then <trust PSBT?>. Select “OK” after reading the message and select . You can now sign CoinJoined transactions even if the xpubs for the CoinJoin partners were not supplied – just like a regular software wallet."_

The above description for simply trusting PSBTs is not safe. Instead, each external input would have to come with an ownership proof.
See https://github.com/satoshilabs/slips/blob/master/slip-0019.md#motivation
Which Coinjoin software are you targeting, and do they supply this proof of ownership for the inputs?

Wasabi, as explained into the provided Bitcoin Magasine Coinjoin guide link above.
https://docs.wasabiwallet.io/FAQ/FAQ-UseWasabi.html#what-is-happening-in-the-input-registration-phase
https://github.com/WalletWasabi/WalletWasabi/issues/5533
Thank you for sharing +1
I suspected that security issue was the reason for not having this feature added yet but i couldn't find why until now.

The bitcoinmagazine article is quite old. Wasabi's default coordinator shut down in the meantime. It's a reason we de-prioritized adding support for this when they shut down.

Ohhh...i see, i wasn't aware of that.
Only that they closed their Coinjoin support for Trezor in june 2024.


The tests on github use the current version of dev-env.

Currently, our testing on push only works on a docker-container created during the night from the main branch. Thus, if we change a dependency or introduce a new package, this is not tested because the image is created on the main branch and not the branch we are currently working on.
I think there are two solutions:

we don't cache the environment at all, we rebuild the environment on every push. Currently, building and uploading the image takes around 30 minutes. Is this too long to wait? I think it's OK, the big testing should be done locally anyway and maybe with mamba this will actually be quick.
people need to manually trigger the creation of the cached environment from their branch and use it. However, this means that someone else is maybe testing with a wrong cached environment.

@Lukas113 @deiruch @fschramka any input?

Do I get it right: This means we currently get feedback after the PR was merged, if we break Docker? If so, I suggest we lower the priority of this issue. It's not as if we're adding new dependencies every other day, and break Docker.
If we decide to solve this problem, I'm strongly in favor of the first option. Slower automation is preferrable to manual intervention.

@Lukas113 @deiruch We discussed that dev-env for testing can RIP. In addition, we will only have one docker container: user with a clean jupyter-notebook (such as source-detection.ipynb) to get started.
This container should also be tested on release and maybe built on the weekend and run on cscs.


nixos/kubernetes: add missing systemd restart options

Motivation for this change
Kube scheduler and kube proxy were missing the options to make systemd restart the processes on failure.
Tested locally using nix-build ./nixos/release.nix -A tests.kubernetes.rbac.singlenode -A tests.kubernetes.rbac.multinode -A tests.kubernetes.dns.singlenode -A tests.kubernetes.dns.multinode.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@fpletz @adamtulinius for the record, this is why they're restarted: https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/services/cluster/kubernetes/scheduler.nix#L88 ..
Certmgr will restart dependent services once their certificate(s) are issued/renewed. I guess we were "lucky", that the scheduler and proxy didn't fail after the certs were issued. In that case nothing would have restarted them. Same issue when easyCerts = false and certmgr is disabled. :-)

Thanks for the explanation! :smiley:


User request: customize clock time warning

What I was looking for is a feature to allow me to customize the audible / Visual warning when my clock gets down to a number of minutes and seconds that I want to define differently for each time control. It would help a lot because I often get distracted from my time management especially when streaming!

Different user requested custom sound from the local computer. Ugh...

Simple implementation in v2.3.167


Add Components

In this project I added the following using React:

Add components
Add Calculator User Interface
Add Calculator.css file

Thank you @hiromataba

Hello @hiromataba  I have made the requested changes. Thank you .

Thank you @desileker


May I get inference speed up if I quantize the model then export to ONNX then to caffe2

I quantized the example model, then I test inference time, I found that inference time increased. So I search the question, I got
https://github.com/NervanaSystems/distiller/issues/238 and
https://github.com/NervanaSystems/distiller/issues/159
as you mentioned
"
We do, however, plan to support exporting of quantized models using ONNX, once quantization is published as part of the standard. Then you'll be able to export a model quantized in Distiller and run it on a framework that supports actual 8-bit execution on CPU/GPU
"
I wonder if I can, now, quantize my model then export to ONNX, then to caffe2(you said caffe2 support 8bit),  in this way, I can get inference speed up?
Thank you.

Hi @WilliamZhaoz ,
At the moment we don't support exporting quantized models to onnx, because our quantization is simulated through additional operations.
It's still in the plans, but we aren't there yet at the moment.
Lev

thank you levzlotnik,
I am sorry, I have another question, is the pruning in distiller also simulated ? Can I get inference speed up if I pruning my model using distiller and then inference it? If not, how can I get inference speed up with the help of distiller.
Thank you.

Hi @WilliamZhaoz ,
The pruning is not simulated, i.e. the weights are actually hard-zeroed. To get an inference speed up, you'll have to use a hardware that benefits from weight sparsity. Distiller provides a wide range of pruners that can help you with sparsifying either fine grained (per element), blocks, columns and up to whole channels and filters.
When you save the checkpoint, the fine-tuned weights are saved along with masks (part of the compression_sched state dict) which you can later use to apply onto the weights and get the final sparse weights.
Lev

I am excited that pruning is not simulated, thank you Lev.
BTW, I want to prune my own model, I'd like to know where I can get a detailed instruction on how to prune my own model, what I need to do on my model.
Thanks,
Zhiyuan.

Hi @WilliamZhaoz,
With regard to your earlier questions, we have more details in Distiller's FAQ.
If you have an image-classification model, that uses MNIST/CIFAR10/ImageNet, then setting up pruning of your own model is now easier.  I added a way to register your model so that after registering it, you can use it like any other model.  Check the code and let me know if it answers your question: https://github.com/NervanaSystems/distiller/blob/master/jupyter/tutorial__adding_new_model.ipynb
Cheers,
Neta

Thanks Neta!
I appreciate your work!
Now I want to prune my own model, but not a image-classification model, are
there some documents I can refer? Thank you!
Neta Zmora<EMAIL_ADDRESS>于2019年9月23日周一 下午8:13写道：

Hi @WilliamZhaoz https://github.com/WilliamZhaoz,
With regard to your earlier questions, we have more details in Distiller's
FAQ
https://github.com/NervanaSystems/distiller/wiki/Frequently-Asked-Questions-(FAQ)
.
If you have an image-classification model, that uses
MNIST/CIFAR10/ImageNet, then setting up pruning of your own model is now
easier. I added a way to register your model so that after registering it,
you can use it like any other model. Check the code and let me know if it
answers your question:
https://github.com/NervanaSystems/distiller/blob/master/jupyter/tutorial__adding_new_model.ipynb
Cheers,
Neta
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NervanaSystems/distiller/issues/379?email_source=notifications&email_token=AIWSN2MBK4UNIOPNLADBRCDQLCXGBA5CNFSM4IVFVHAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7KUYQI#issuecomment-534072385,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIWSN2MPY5Z73JYZCCGFM2LQLCXGBANCNFSM4IVFVHAA
.

Hi @WilliamZhaoz ,
Sorry for the late response.
About pruning a non image-classification model - we have several examples of doing so, refer to our examples and docs please.
Closing this issue due to staleness and it seems resolved.


Keys with dots

I'm getting this error:
Exception while invoking method 'login' Error: key profile.Leagues must not contain '.'

I think it's related to this recent change: https://github.com/meteor/meteor/issues/3786

OK, I think this is actually because I'm trying to add a nested field in a behavior, ideas for that? It looks like this right now:
fields: {
        [behavior.options.keyStore]: {
          type: [String],
          optional: true,
          default() {
            return behavior.options.type === 'many' ? [] : '';
          },
        },
      },

In my test case, I want the field to be profile.Leagues

The short answer will be to skip this. I can create a nested object like this:
const field = _.set({}, behavior.options.keyStore, {
      type: behavior.options.type === 'many' ? [String] : String,
      optional: true,
      default() {
        return behavior.options.type === 'many' ? [] : '';
      },
    })
...
fields: {
  ...field
},

But I get an error about reading prototype of undefined (something to do with types).

For setting nested fields you have doc.set method which works similarly to _.set but it has more features like ability to cast values, set default values etc. I can't help you with you problem as I have to little information. Moreover as I said in another issue, you should rather create module not behavior if you want to implement relations.


Option autoHeight doesn't work first time through (potential fix options inside)

I was experiencing an issue where autoHeight did not work the first time the plugin animated the slides. I am producing an adaptive slider by manipulating the layer positions at different breakpoints and needed 'autoHeight' to be enabled on a phone break-point. Basically the slide changes to an image at the top followed by the headline and a button rather than headline, button and quote on top of the image.
Anyway, on load sliderPro would correctly animate the height on the first slide but subsequent slides were stuck at the height of just the image. When slidePro cycles again it properly animates the height of all the elements(image, headline and button).
After investigating I saw that on load the layers are set to both: 'visibility: hidden' and 'display: none.' I did a quick test of "display:block !important' and that solved the issue. Alternatively removing 'display: none' from jquery.sliderrPro.layers.js @ line 333 or the minified version fixed the issue without the CSS bang declaration.
I'm guessing sliderPro's get height equivalent fires before that style is removed so the height of those layers read as 0 the first time through. Once the slide is hidden it only maintains 'visibility: hidden' and 'opacity: 0' which will still return the true height. So that's another possible fix (i.e. make sure the style is removed before grabbing the height).
Not sure if this is the right place to post this but figured I'd let you know and also find out if there may be unforeseen-consequences of removing that bit of code? Setting 'display: block !important' on the layers will fix this for my purposes though.
Thanks for this awesome tool, way better than LayerSlider!
Justin

In a related matter... it appears that on load doesn't resize the layers which means the layers are overlapping and not entirely within the view-able area. However the next slides come in at the right size.
It looks like there is no scale function happening on load but I can't seem to figure out how to trigger it. I can hard-code a number but can't get one dynamically(the scaleRatio defaults to 1). Is there a setting I am missing that can accomplish this?
I have no example I can share at the moment but you can replicate it using 'example 1' when you download this plugin. Just remove the 'autoScaleLayers: false,' line from the options; refresh and scale the browser down; refresh and you will see the layer load in at it's original size rather than a reduced size.

I've coded a few plugins so I took a wack at it, I'm not sure if this would stand up though to the level of this plugin nor have I had enough time to really test to make sure 'everything' is still working but what do you think?
jquery.sliderPro.layers.js
Lines 76-124:

    // After gathering the current scale ratio we need to scale each layer
    _layersOnResize: function() {
    var iScaleRatio = this.calculateScaleRatio();

        $.each( this.slides, function( index, slide ) {
            if ( typeof slide.layers !== 'undefined' ) {
                $.each( slide.layers, function( index, layer ) {
                    layer.scale( iScaleRatio );
                });
            }
        });
    },

    // When the slider resizes, try to scale down the layers proportionally. The automatic scaling
    // will make use of an option, 'autoScaleReference', by comparing the current width of the slider
    // with the reference width. So, if the reference width is 1000 pixels and the current width is
    // 500 pixels, it means that the layers will be scaled down to 50% of their size.
    calculateScaleRatio: function(){
        var that = this,
            autoScaleReference,
            useAutoScale = this.settings.autoScaleLayers,
            scaleRatio;

        if ( this.settings.autoScaleLayers === false ) {
            return 1;
        }

        // If there isn't a reference for how the layers should scale down automatically, use the 'width'
        // option as a reference, unless the width was set to a percentage. If there isn't a set reference and
        // the width was set to a percentage, auto scaling will not be used because it's not possible to
        // calculate how much should the layers scale.
        if ( this.settings.autoScaleReference === -1 ) {
            if ( typeof this.settings.width === 'string' && this.settings.width.indexOf( '%' ) !== -1 ) {
                useAutoScale = false;
            } else {
                autoScaleReference = parseInt( this.settings.width, 10 );
            }
        } else {
            autoScaleReference = this.settings.autoScaleReference;
        }

        if ( useAutoScale === true && this.slideWidth < autoScaleReference ) {
            scaleRatio = that.slideWidth / autoScaleReference;
        } else {
            scaleRatio = 1;
        }

        return scaleRatio;
    },

Line 314:
    this.scaleRatio = $.proxy(Layers.calculateScaleRatio, Layers);

Lines 334-339:
    _init: function() {
        this.$layer.attr( 'data-layer-init', true );

        this._setStyle();
        this.$layer.css({ 'visibility': 'hidden'});
    },

Thanks for your time and help!

Hi, Justin. I will take a look at these two issues sometime this week and get back with comments and fixes. Cheers.

Sounds good, I'm not sure if this is personal preference or something you'd also think adds value to your plugin but I made it so that touchswipe events fire the layer out animation (best idea I had at the time):
// jquery.sliderPro.touchSwipe.js lines 198-216
if ( this.settings.loop === true ) {
	// Run the hideLayers function if the layers may exist
	if(typeof this.layersGotoSlideReference !== 'undefined'){
		this.hideLayers( this.selectedSlideIndex );
	}
	this.gotoSlide( nextSlideIndex );
} else {
	if ( typeof nextSlideIndex !== 'undefined' ) {
		// Run the hideLayers function if the layers may exist
		if(typeof this.layersGotoSlideReference !== 'undefined'){
			this.hideLayers( this.selectedSlideIndex );
		}
		this.gotoSlide( nextSlideIndex );
	} else {
		this._moveTo( oldSlidesPosition );
	}
}

Secondly, I made it so that the link prevention code was a little more specific.When dealing with layers it is not uncommon to require a button rather than the whole slide being clickable. So I just made the main slide image's link follow your click handling but allow 'content links' to pass untouched:
//jquery.sliderPro.touchSwipe.js lines 68-71
// Disable click events on the main slide image but allow content links to work
$( event.target ).parents( '.sp-slide' ).find('div.sp-image-container').find( 'a' ).one( 'click.' + NS, function( event ) {
	event.preventDefault();
});

Hi Justin,
I've just released an update which contains fixes to the issues you've mentioned above.
Regarding "display: none", this CSS wasn't necessary. I reused some code from another plugin of mine where it was necessary for some calculations, but it wasn't necessary in this plugin, so I removed it.
Regarding the layers not being scaled properly on load, it was a bug introduced in the last version due to some code modifications I did, but I've fixed it now by delaying the showLayers call from the _layersOnUpdate handler. This ensures that the layers will be displayed after the scale ratio is calculated.
I've decided not to hide the layers during the slide transition, in order to ensure that the slide transition is as smooth as possible, but feel free to modify this as you would like. Also, please note that there is an option which sets the transition to wait until all the layers hide, and start the slide animation only after that. The option is called waitForLayers.
Regarding links, there is an undocumented "feature" that will allow clicks and other elements to maintain their default behavior: you need to add the sp-selectable class to that link/element.
Cheers.

David -
Thanks for the update and explanation and the undocumented feature trick. Everything seems to check out with the exception of the 'waitForLayers' setting with swiping(drag or touch). They remain visible until they animate away when cycling on its own or button/arrow presses. Any advice or tricks with that or should I stick with my custom solution above?
Thanks again for your help and this awesome plugin!

You're welcome, and thank you for the compliment!
When the slides are swiped, waitForLayers will not have any effect; it's only for the other situations when a new slide is selected. There isn't a built-in solution to hide the layers during a touch-swipe gesture, so you should stick with your custom solution for that.
Cheers.

Alright, sounds good, thanks!


Mitigate scenarios of credentials hijacking

Off the top of my head  the simplest idea is to allow a user's credentials to be saved to a location of their choice just like you'd do after ssh-keygen, or even allow for credentials encrypting and decryption on every usage. This is an issue brought to my attention by noticing that doing a pull/push with -hidden enabled affects the credentials files. Also @bh4017 raised a scenario in an offline email in which the contents of a mounted Google drive saved on removable media if acquired by anyone would give them access to the victim's drive.
Please feel free to pitch in your thoughts.

Ooh btw it had slipped my mind to mention that at anytime you could revoke Account access to drive by logging into your email and changing the security settings. After logging in, this currently works by going to: https://security.google.com/settings/security/permissions and revoking access with the specified app.

Might be a good idea to use the Keychain when running on OS X for storing OAuth tokens. Doesn't look like there are any functional open sourced libraries for accessing the Keychain via Go, but I'm assuming there's some way you can invoke the C API.

Ah I see, great idea, sounds like a plan. I also just found this https://github.com/bgentry/go-osxkeychain.


test/cases directory is omitted from released tar

I'm adding a check function to the AUR package and I've found that the tests fail due to the directory test/cases not existing in the released tar. For now, I'm manually cloning the repository and running pytest from there. Is there a chance you could patch the release to include this missing directory?
Thanks!

Hey, sorry missed the notification for this. I'll fix this in the next release, when I find some time.

It works, thank you!


C# portable CLR library VboxWrap.dll

Hello @shauleiz,
Here's a patch of the Xinput Wrapper portable to C#.
The file IWrapper.cpp is a managed C++ class, equivalent to a C# class.
I added Trigger Thresholds and Axes Deadzones management designed for the Xinput Gamepads. It allows the feeder to call Axes, Buttons and Triggers from C# with the produced library.
Produced files vJoy\x64\Release-Xbox\vJoyInterface.dll and VboxWrap.dll were used to compile recent MFIGamepadFeeder .
Sincere regards,
@b23prodtm

I don't understand what you are trying to do.
If you want to add a wrapper dll around vJoyInterface.dll then this is already done.
If you want to add a wrapper dll around vGenInterface.dll then then you are welcome to add it. Only that it should be a separate project and should not change existing code.
I have seen that have even changed the compiler from v120 to v140 which I do not approve.

I'm sorry to disturb you but I needed to see if it can merge or not because the original interfaces does not provide a C# wrapper.
Envoyé de mon iPhone

Le 26 sept. 2016 à 11:35, Shaul<EMAIL_ADDRESS>a écrit :
I don't understand what you are trying to do.
If you want to add a wrapper dll around vJoyInterface.dll then this is already done.
If you want to add a wrapper dll around vGenInterface.dll then then you are welcome to add it. Only that it should be a separate project and should not change existing code.
I have seen that have even changed the compiler from v120 to v140 which I do not approve.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


add test for checkpoint nan

What does this PR do?
fixing and adding a test to show that CHeckpointing is stable even for NaN
Fixes #2636
Thx @ddrevicky for his thoughts https://github.com/PyTorchLightning/pytorch-lightning/issues/2636#issuecomment-699599340
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

Hello @Borda! Thanks for opening this PR.

In the file tests/checkpointing/test_model_checkpoint.py:

Line 484:93: W292 no newline at end of file

Do see the Hitchhiker's guide to code style


[PE-D][Tester D] Table of Contents in user guide missing labelling

In the user guide, it's hard to understand the flow of the sections without proper numbering of the table of contents

Labels: type.DocumentationBug severity.Low
original: rithanisk/ped#13

I don't understand this. Anyone have any opinions?

Don't think its an issue, the indentations are clear.


Create a new YouTube video showing off the new features (especially a railgun-rampage!)

Yessss. Also, pink! :D


WiP: x590_vfy.c: (Re-)check that the root of the constructed cert chain is directly trusted

I think it would be good as a security precaution to
make ~internal_verify()~ verify_chain() (re-)check the trust placed in the last element of the chain being verified (i.e., its trust anchor),
such that the correctness of chain verification becomes independent of the checks done during chain building.

I've adapted and rebased this PR, moving out the rather unrelated renaming of CHECK_CB() to a separate PR: #13895.

I've adapted and rebased this PR, moving out the rather unrelated renaming of CHECK_CB() to a separate PR: #13895.

I'm placing on OTC hold on this PR.  I don't think it should be merged, but if there's a consensus around a sound way forward, I'm willing to reconsider my objections.  If you decide to just close this instead, that'd be fine too.

I'm placing on OTC hold on this PR.  I don't think it should be merged, but if there's a consensus around a sound way forward, I'm willing to reconsider my objections.  If you decide to just close this instead, that'd be fine too.

This PR is in a state where it requires action by @openssl/otc but the last update was 30 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 61 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 92 days ago

At this point I don't see any remaining substantial bugs, but still question the need for this PR.  The minor issues are:

Applications that deliberately ignore certificate errors now get an extra callback for the same issue (untrusted certificate chain)
Duplication of work (the X509 store lookups are not free, some stores may add significant latency)
The DANE exception is somewhat wrong if the PKIX-TA/PKIX-EE DANE usages are involved.
The check should perhaps only run if the verification status is X509_V_OK.
These are not major difficulties, and the code would not be wrong with these left unaddressed, but I still think that it would be better to invest in test coverage, rather than a runtime redundant check.

OTC: We see no need for this PR.

Did you intend to close this?

Did you intend to close this?

Yes, it was intentionally closed by OTC after a discussion on the meeting.

Clearly I need to read better.


Update the pulsar admin cli java doc to support set/get/remove deduplication on topic level

Fixes #7920
Motivation
set/get/remove deduplication policy is on topic level. But the pulsar admin cli java doc is not supported accordingly.
Modifications
add methods to CmdTopics.java
Verifying this change
unit test
org.apache.pulsar.admin.cli.PulsarAdminToolTest#topics

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks


Update fedora_reddit.css

Fix downvote arrow width/artifact.
See https://www.reddit.com/r/Fedora/comments/47nvjf/fix_minor_styling_bug_in_this_subreddit_meta/

Thanks

@alexskc: Thanks for making the pull request and fixing this! Glad to see some bug fixes by the community. :)
@micahdenn: Thanks for merging this in!
The subreddit has been updated with the latest commits!


Animations not working Figura 0.1.3 pre.4+1.20.1

I was wondering If you could make an update for GSAnimBlend, cause the current version isn't working

This is an issue with Figura Forge caused by the client.getFiguraVersion() function only getting the prerelease info from Figura instead of the full thing.
I'll put out a workaround eventually.

It seems like your version of GSAnimBlend is also not up-to-date.
Once you update it, you can fix this issue for now by changing https://github.com/GrandpaScout/GSAnimBlend/blob/46c07a6da56090cc099fb01e41eebcc76c757b67/script/GSAnimBlend.lua#L1994 to
local cmp, ver = client.compareVersions, client.getFiguraVersion():match("^([^%+]*)"):gsub("^([pr].*)$", "0.1.3-%1")

Nevermind. This issue is completely unrelated to GSAnimBlend. It isn't even my script erroring.
Please refer to the original author of the avatar template you are using.
The fix for GSAnimBlend itself still stands however and will be fixed soon.


BookManager says "baseDir not defined in config.php" but no config.php is read before the object is created

https://github.com/sebcode/b/blob/29584190cb3a7c079e9c6b80e904669b6e68abcf/src/BookmarkManager.php#L27
but index.php doe not read config.php.

in my local copy of index.php, i 've now added just before the main try{}:
require_once __DIR__.'/../conf/config.php';

the config content is:
<?php

putenv('BASE_DIR='.__DIR__.'/../db/');
putenv('BASE_URI=/bookmark/htdocs/');
putenv('INFINITE_SCROLLING=200');

this having been said, nowadays, i'm more used to defining an array in config.php or even a function that returns an array:
config.php
return function() {
    return [
          'key' => 'value',
    ];
};

which can be called in index.php as
$config = (include('../conf/config.php`))()

which is probably overkill for this project but has the nice property, that you can avoid polluting the global name space (and gives you a chance to pass an argument to the config file, as an example for production and test servers) and is very explicit in the variables being created.
looks strange at first, but on gets used to it...

config.php is legacy stuff, I just forgot to remove that require_once.
"the new way" is to put it into the .env file, docker will pick that up
if you're not using docker I guess a .htaccess with SetEnv would work too
your custom config.php works too of course


TypeError: 'NoneType' object is not subscriptable

16:42:46: Fatal error encountered:
16:42:46:
16:42:46: Traceback (most recent call last):
16:42:46:   File "main.py", line 158, in main
16:42:46:   File "twitch.py", line 764, in run
16:42:46:   File "twitch.py", line 913, in _run
16:42:46:   File "twitch.py", line 1703, in get_live_streams
16:42:46: TypeError: 'NoneType' object is not subscriptable
16:42:46:
16:42:46: Exiting...
16:42:47:
16:42:47: Application Terminated.
16:42:47: Close the window to exit the application.
Just downloaded the newest Version, before that i used one from a couple Weeks ago, and all was fine, now it doesnt work anymore and i get this Error. Usually i copy over my Settings and Cookies, but even without either i get the same Error.

I see. Which games have you added to the Priority list?

I see. Which games have you added to the Priority list?

Funny, when I added "Guessr.tv" it gave me this error.

There's a game with a name like that?

I see. Which games have you added to the Priority list?

"language": "English",
"priority": [
    "The Elder Scrolls Online",
    "HUMANKIND",
    "Warframe",
    "Halo Infinite",
    "For Honor",
    "Overwatch 2",
    "PUBG: BATTLEGROUNDS",
    "PAYDAY 2",
    "FIFA 23",
    "Apex Legends",
    "The Crew: Motorfest",
    "Rocket League",
    "Vampire: The Masquerade - Bloodhunt",
    "Elite: Dangerous",
    "BattleBit Remastered",
    "New World",
    "Sea of Thieves",
    "Rust",
    "Diablo IV",
    "World of Warcraft",
    "Conan Exiles",
    "Cyberpunk 2077",
    "Arena Breakout",
    "Crossfire",
    "Stream Raiders",
    "STALCRAFT",
    "Starsiege: Deadzone",
    "World of Warships",
    "The First Descendant",
    "SYNCED",
    "Riders Republic",
    "Assassin's Creed Mirage",
    "Veiled Experts",
    "Ghostbusters: Spirits Unleashed",
    "Warhaven",
    "Party Animals",
    "AK-xolotl",
    "Operation Valor",
    "Warhammer Age of Sigmar: Realms of Ruin",
    "Gord",
    "UNITED 1944",
    "Disney Speedstorm",
    "My Hero Ultra Rumble",
    "DC Dual Force",
    "Infestation: The New Z",
    "Project: Arena",
    "Cult of the Lamb",
    "Project Winter",
    "Freestyle Football R",
    "From Space",
    "EVE Online",
    "BAPBAP",
    "Marbles on Stream",
    "Black Desert",
    "Hellcard",
    "Warhammer Online: Age of Reckoning",
    "Crossout",
    "Epic Seven",
    "KartRider: Drift",
    "Eternal Return",
    "Conqueror's Blade",
    "NARAKA: BLADEPOINT",
    "Lost Ark",
    "ArcheAge",
    "SMITE"

However i got the same Error by having an empty Prio List and having "Priority only" disabled.
Adding to that though, i just added the Game mentioned by matarife to the exclusion List, and now it works again.

I see. Which games have you added to the Priority list?

"language": "English",
"priority": [
    "The Elder Scrolls Online",
    "HUMANKIND",
    "Warframe",
    "Halo Infinite",
    "For Honor",
    "Overwatch 2",
    "PUBG: BATTLEGROUNDS",
    "PAYDAY 2",
    "FIFA 23",
    "Apex Legends",
    "The Crew: Motorfest",
    "Rocket League",
    "Vampire: The Masquerade - Bloodhunt",
    "Elite: Dangerous",
    "BattleBit Remastered",
    "New World",
    "Sea of Thieves",
    "Rust",
    "Diablo IV",
    "World of Warcraft",
    "Conan Exiles",
    "Cyberpunk 2077",
    "Arena Breakout",
    "Crossfire",
    "Stream Raiders",
    "STALCRAFT",
    "Starsiege: Deadzone",
    "World of Warships",
    "The First Descendant",
    "SYNCED",
    "Riders Republic",
    "Assassin's Creed Mirage",
    "Veiled Experts",
    "Ghostbusters: Spirits Unleashed",
    "Warhaven",
    "Party Animals",
    "AK-xolotl",
    "Operation Valor",
    "Warhammer Age of Sigmar: Realms of Ruin",
    "Gord",
    "UNITED 1944",
    "Disney Speedstorm",
    "My Hero Ultra Rumble",
    "DC Dual Force",
    "Infestation: The New Z",
    "Project: Arena",
    "Cult of the Lamb",
    "Project Winter",
    "Freestyle Football R",
    "From Space",
    "EVE Online",
    "BAPBAP",
    "Marbles on Stream",
    "Black Desert",
    "Hellcard",
    "Warhammer Online: Age of Reckoning",
    "Crossout",
    "Epic Seven",
    "KartRider: Drift",
    "Eternal Return",
    "Conqueror's Blade",
    "NARAKA: BLADEPOINT",
    "Lost Ark",
    "ArcheAge",
    "SMITE"

However i got the same Error by having an empty Prio List and having "Priority only" disabled.
Adding to that though, i just added the Game mentioned by matarife to the exclusion List, and now it works again.

it's true WTF XD

This should now be fixed by https://github.com/DevilXD/TwitchDropsMiner/commit/1d2698872138e6dfb4f4625e678ba6db136917d9.

Tested both removed from Exclusion and in Prio List, indeed fixed! Thanks for the quick Work!


hw/bsp/dialog: Add generation of dialog header on images

This patch adds the capability to produce the appropriate image
headers for booting on the Dialog 1469x platform.  Both secure and
nonsecure image header are supported.  Newly defined system config
settings provide the required security configuration items: slot
indices, ED25519 PEM file, and base64 encoded AES-256-CTR key.
The supplied python script leverages the python keys module that
currently resides in mcuboot/scripts/imgtool.
Signed-off-by: Andy Gross<EMAIL_ADDRESS>

@agross-korg Also you need to include a commit adding the script to /.rat-excludes.

Do we typically add the license headers by hand or use RAT?  I don't think this one needs to be excluded, does it?

Yes, we add them by hand. Your looks correct and I am not sure why RAT did not identify it; I'll check later.


Add code-coverage to Gogs

Gogs version (or commit ref): v0.9.71
Git version: v2.1.4
Operating system: Debian
Database (use [x]):

[ ] PostgreSQL
[x] MySQL
[ ] SQLite

Can you reproduce the bug at https://try.gogs.io:

[ ] Yes (provide example URL)
[ ] No
[x] Not relevant

Description
Since there are some tests now, perhaps it is a good idea to add code-coverage. Maybe with coveralls.io.

Hi, I consider this is duplicated to https://github.com/gogits/gogs/issues/2293


disgrace to the art world

Thanks for your contribution to the death of the art, and I hope you will be treated the same

Weep for me, Luddite. Mourn every Luddite that has been defeated by technology before you. Wallow in the impotent rage that you feel now. The joy that we take in it is EVERLASTING! >:D


[WIP] Initial Swift 3 support

Depends on #193. ✅
We should audit the APIs to match with Swift 3 API Design Guidelines.

@ikesyo is this updated to the latest beta?

Hi @ikesyo, shouldn't we rename interceptURLRequest and  interceptObject too like you did responseFromObject?
what about change enum cases to lowercase too maybe?
I would love to help! if there is anything i can do!

the Xcode 8 is out, can we merge this @ikesyo @ishkawa?

@ikesyo Thank you for the great work 👍 👍 👍
I have some suggestions that would improve smoothness with Swift 3 APIs.
Omit Type suffix of some protocols
According to the API Design Guidelines, "Protocols that describe what something is should read as nouns (e.g. Collection)." RequestType, BodyParametersType, DataParserType and SessionAdapterType seem to satisfy this condition.
Rename sendRequest(_:handler:) to send(_:handler:)
IMO, the word "request" can be omitted because it is implied when we send something from Session.
Rename cancelRequest(_:passingTest:) to cancelRequests(withType:passingTest:)
Unlike the sending method, canceling method treats multiple requests. I think we should imply we may cancel multiple requests, so the word "requests" should be exposed in method name. In addition, withType label is necessary because the type of the first parameter is not explicit in this context.

After we resolve renaming, I will merge this PR and release 3.0 ✨

The renaming is finished. ✨

🎉


ngAfterViewInit in SRR

ERROR ReferenceError: window is not defined at _NgxTurnstileComponent.ngAfterViewInit
Do you think it can be fixed by using afterNextRender instead? I don't expect it to work on server, just not to throw errors.

Thank you @zygimantas for reporting this. I agree with your fix for using afterNextRender. Will address this sometime this week and rollout a new release. Thank you for your patience 🙏


Create index.html and insert the snippet below in it

Status Update
I am starting work on this task. Moving it to "In Progress".

Labels and Milestones
Assigned the following labels:

Enhancement

Assigned to milestone: Features

Completion Update
The task has been completed.
Outcome:

Created index.html block with inserted snipper in it

Task moved to "Done" and closed.


Add lib-creator mileston version in config api

Purpose
This is to fix compilation failure in the maven build.

Codecov Report

Merging #15500 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #15500   +/-   ##
=========================================
  Coverage     44.01%   44.01%
  Complexity     4377     4377
=========================================
  Files           655      655
  Lines         30368    30368
  Branches       5165     5165
=========================================
  Hits          13365    13365
  Misses        15362    15362
  Partials       1641     1641

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57356c5...d06982f. Read the comment docs.


[GPII-3418]: Tune resource requests one more time

This is the long-term solution I promised.
For dev clusters I had to keep requests lowered in order to stay on cheaper n1-standard-2 nodes.
For staging / prod clusters:

To have "more predictable" scheduling with requests = limits
To also have more replicas of preferences, flowmanager and couchdb (similarly to AWS setup)
And finally, to have enough room for rolling updates with maxUnavailable: 0

I suggest to use n1-highcpu-4 instances. They are a bit cheaper than n1-standard-4 and have significantly less RAM (4GB vs 15GB), but since we are very far away from hitting RAM limit, it seems like the most optimal choice in our situation.
Changing node type will most likely cause Terraform to attempt to recreate the cluster. I am not sure if there is a way around this issue for staging and prod, I am open to suggestions!
Using container_node_pool should improve this situation:
https://issues.gpii.net/browse/GPII-3419

LGTM

value passed down as a parameter from each environment

+1

@stepanstipl @mrtyler Good point! Unfortunately, getting rid of env-based interpolations in modules requires adding more plumbing in order to pass variables from Terragrunt to Terraform and then into templates. But I also believe that it results in a bit more clear module code and more flexible per-environment configs.
Please review updated version!

LGTM
Thanks for re-plumbing those templated variables. I think the new form is easier to understand and more consistent with the Exekube/Terraform module model.


[Bug] Cloudflare challenge always fails since 2.16.0, fully blocking certain pages

Before Reporting

[X] I found no existing issues matching my bug
[X] My issue is not caused by a theme
[X] My issue is not caused by a plugin

Describe the Bug
Since recently cloudflare has updated something on their end that makes it so that their security challenge fails in the steam browser when millennium is installed. This is likely because of the script tags that get added by millennium which triggers their bot detection.
In 2.15 and vanilla steam it all works fine because nothing is injected into the webkit context but since 2.16 and some changes at cloudflare certain websites just block you from accessing them.
I have tested this on a clean installation of steam and millennium.
Expected Behavior
For the websites to load and not throw an error page
Steps To Reproduce

Middle mouse on any link in the steam store to open the steam browser
Go to a site with a Cloudflare challenge, like:
https://steamdb.info/
https://2captcha.com/demo/cloudflare-turnstile-challenge
https://ashesofcreation.com/api/auth/signup
Or any page that uses an Cloudflare challenge.
Observe that after clicking the checkbox it goes to an _error or blank page

Operating System
Windows
Anything else?
Here is also an video which was provided to me in this issue https://github.com/tddebart/Steam-SteamDB-extension/issues/9
https://github.com/user-attachments/assets/fdda15e4-e95a-4220-839f-36a22ef30750

Ja
BossSloth @.***> schrieb am Di. 24. Dez. 2024 um 13:23:

Before Reporting

I found no existing issues matching my bug
My issue is not caused by a theme
My issue is not caused by a plugin

Describe the Bug
Since recently cloudflare has updated something on their end that makes it
so that their security challenge fails in the steam browser when millennium
is installed. This is likely because of the script tags that get added by
millennium which triggers their bot detection.
In 2.15 and vanilla steam it all works fine because nothing is injected
into the webkit context but since 2.16 and some changes at cloudflare
certain websites just block you from accessing them.
I have tested this on a clean installation of steam and millennium.
Expected Behavior
For the websites to load and not throw an error page
Steps To Reproduce

Middle mouse on any link in the steam store to open the steam
browser
Go to a site with a Cloudflare challenge, like:
https://steamdb.info/
https://2captcha.com/demo/cloudflare-turnstile-challenge
https://ashesofcreation.com/api/auth/signup
Or any page that uses an Cloudflare challenge.
Observe that after clicking the checkbox it goes to an _error or
blank page

Operating System
Windows
Anything else?
Here is also an video which was provided to me in this issue
tddebart/Steam-SteamDB-extension#9
https://github.com/tddebart/Steam-SteamDB-extension/issues/9
https://github.com/user-attachments/assets/fdda15e4-e95a-4220-839f-36a22ef30750
—
Reply to this email directly, view it on GitHub
https://github.com/shdwmtr/millennium/issues/194, or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDRSN3VNXKFRHMBUIK4MDD32HFG4ZAVCNFSM6AAAAABUEUPXMKVHI2DSMVQWIX3LMV43ASLTON2WKOZSG42TONZQG4ZTGMY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Give this build a go:
https://github.com/shdwmtr/millennium/actions/workflows/artifact.yml

Seems to have fully fixed this issue but also seems to have introduced a new one.
On first load of the webkit context after boot (or after a client refresh) is seems to fail the websocket connection and so no webkit js get's loaded in meaning plugins don't work. But after a refresh it all just works. It is just the first load and it error with this error:

Refused to connect to 'ws://localhost:61928/' because it violates the following Content Security Policy directive: "connect-src 'self' http://store.steampowered.com

Refused to connect to 'ws://localhost:61928/' because it violates the following Content Security Policy directive: "connect-src 'self' http://store.steampowered.com https://store.steampowered.com http://<IP_ADDRESS>:27060 ws://<IP_ADDRESS>:27060 https://community.fastly.steamstatic.com/ https://steamcommunity.com/ https://steamcommunity.com/ wss://community.steam-api.com/websocket/ https://api.steampowered.com/ https://login.steampowered.com/ https://help.steampowered.com/ https://steam.tv/ https://shared.fastly.steamstatic.com/ https://checkout.steampowered.com/ https://*.steamstatic.com https://*.steamcontent.com https://*.valvesoftware.com https://*.steambeta.net https://*.discovery.beta.steamserver.net https://*.cqloud.com https://steambroadcast.akamaized.net https://steambroadcast-test.akamaized.net https://broadcast.st.dl.eccdnx.com https://lv.queniujq.cn https://steambroadcastchat.akamaized.net https://api.steampowered.com https://steamvideo-a.akamaihd.net https://video.st.dl.eccdnx.com https://vd.queniujq.cn https://*.storage.googleapis.com https://sketchfab.com".

Should I make a new issue for this?

I forgot to update one of Millenniums libs on the build.
this build fixes it:
https://github.com/shdwmtr/millennium/actions/runs/12524389759

Perfect.


RemoveAll was clearing the wrong array if removeOneTimeListeners was set to true

Just a small issue I noticed.
I was not sure how to update the tests to catch this issue, I have not worked with testing libraries before to be honest so I am not sure what the correct workflow is.

HI there
Wow, ok, so I never intended to push anything more than the first commit that is listed here (https://github.com/SixWays/Relay/pull/2/commits/b3da0330bd93510dfe32b29cbd5b90feecf7e540).
I am a GitHub noob, I didn't realise that it would append any other changes I push to the branch to my PR...!
Well..now that we are here...

So, this isn't actually the most up-to-date version of the stuff I was working on. I am pushing the rest of my changes now (They are changes I made yesterday, and so do not contain any whitespace fixes/etc). Again, I didn't realise this was going up on the PR, so I pushed the first part, and only committed the other parts of my work.

The white spaces - I have no idea why it looks like that. It looks nothing like that on my end. 👎 I tried my best to confirm to the style of the repo ( '{'s on the same line as method decorations, inlining things that you had inlined too (ie:  if (wasAdded) _RelayDebugger.DebugAddListener(this, listener);. My RelayDelegateCollection class does not reflect these conventions yet but, again, it was WIP and you weren't supposed to see 😅

I have been benchmarking the changes I try out as I go on. I have been maintaining a spreadsheet. You can view it here.. Before is the repo as is without any of my changes. Change6 is where I currently am. (https://github.com/SixWays/Relay/pull/2/commits/04180c7674e630187abf26ad2fa15d33c2634359) (Change7 was reverted).

Each Change has a comment associated with it to let you know what was changed/attempted to improve performance.
It is still not as good as what you had for Populate (Allow Duplicates). 2x as slow as your version. Though Populate (No Duplicates) is 50% faster than your version. 🤔
I was trying to get much closer to the speeds you were getting for Populate (Allow Duplicates) before I was going to suggest any of these changes.

Just fixed the unit tests and also added a "Run All" profile option. This also outputs a CSV string of all the results so you can easily update your spreadsheet without manually entering values each time. In case you're not aware, you'll have to get google sheets to paste as columns as shown.

This is cool! No, I don't have results for other profiles, I should've been keeping track of em as I went along but I got kind of fixated on trying to get Populate (Allow Duplicates) working faster, hah.
I'm not sure if I will put any more work into it. I was inspired to do this after noticing the RemoveAll error. Less repetition would mean less errors like this at this cost of performance. But... Thinking about it further... we could have both performance and stability with broader test coverage. Maybe that's what should be focused on? Ensuring the tests dont miss things like the RemoveAll/onceListener bug in the future. There isn't that much code to maintain anyway, so maybe the repetition isn't a huge deal when combined with thorough unit tests.

Fair enough. I'm still intrigued by the improvement to non-dupe population though - any thoughts why that's the case? Wondering if there's something we could do to improve that without altering how regular population works. But as you say - with unit test coverage, things are working well as is.

Since it's been a while, I'm going to close this if there are no objections?

Yeah, thats cool. Sorry I didn't get around to replying, I got caught up in my work!
To answer your question, I have no idea why that's the case. :)
Go ahead and close! 👍


Provide more console output

Fixed by the commits https://github.com/WouterJ/fred/commit/1c78af8ea9ea165bcb9737d5266640d7006df508 and https://github.com/WouterJ/fred/commit/4eea4660e9ba6b942fc2be0112a02da3af2ad494

Fixed by the commits https://github.com/WouterJ/fred/commit/1c78af8ea9ea165bcb9737d5266640d7006df508 and https://github.com/WouterJ/fred/commit/4eea4660e9ba6b942fc2be0112a02da3af2ad494


Disable auto focus for error summary and notification banner examples using new JS configuration

We  don't want the examples for the error summary or the notification banner in the Design System to take focus as it's not useful for users of assistive tech in this context, and it causes the viewport to scroll to the first example on page load.
This means we need to disable the auto focus feature, but we don't want it to be disabled in the code blocks that we provide under the examples – otherwise when teams copy and paste this code they'll end up disabling auto focus where it's used in services.
Previously we achieved this by having two versions of the code:

index.njk which is used to generate the HTML used for the interactive example of the component
code.njk which is used to generate the Nunjucks and the HTML displayed in the code blocks under the example

Now that GOV.UK Frontend v4.4.0 is out we have a simpler way to achieve the same thing, by changing the config in the JS. This means that we can remove this and simplify the code, thereby reduce the risk of the two versions of the code will get out of sync.
We also need to fix the fact that they've already got out of sync when the <p> was changed to a <h3> in one of the notification banner examples (858a3e7, part of #1515) but the same change was not made to index.njk.
We still need to keep the 'customCode' feature as it's used by examples in the page template guidance.
Closes #2350

The Netlify build failed originally as we needed to update the build image, but has since passed – as you can also tell from the comment from the Netlify bot.
The Netlify status checks are not required to merge this, so suggest we ignore the fact that they are failing.

We also need to fix the fact that they've already got out of sync when the <p> was changed to a <h3> in one of the notification banner examples (858a3e7, part of #1515) but the same change was not made to index.njk.

This is nice 🙌

(Might have been nice to see the code.njk removal clearly explained in the history?)

Do you mean split out into their own commit, or just that change explained more clearly in the commit message?

I've updated the commit messages 👍🏻

I've updated the commit messages 👍🏻

@36degrees Brill, merge away when ready 😊


Enable setting color of text and images on unselected tabs

Hi,
This PR Solves this issue #3083.
This PR solves the problem of default color on TabBar being always grey. Which looks great if the barTintColor is unchanged. However if we set the barTintColor to something else (like blue in example) text and icons become quite unreadable.

Commit (c206417) - Enable setting color of unselected tabs
Solves this issue with a prop (unselectedTintColor) on TabBarIOS to which you just pass a color like you can for barTintColor and tintColor.
This leaves us with a result that is on second picture. Notice the color of text on tabs.

Or change it to yellow for demonstrating purposes

Commit (f9ad80a) -	Enable rendering image of icon as original
Solves the issue of images passed as an icons being always rendered as a template (in grey color). If we want to have a colored image we can't do that. This is solved with a prop (renderAsOriginal) on TabBarIOS.Item.
This is the final version we can now achieve.

Or even something like this.

By analyzing the blame information on this pull request, we identified @nicklockwood and @shtefanntz to be potential reviewers.

I would also be happy to write docs for this feature.

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

@urbancvek updated the pull request.

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@urbancvek Docs are pulled from the source so you can add a more descriptive message there.

@urbancvek updated the pull request.

I've added an example to UIExplorer app so TabBarIOS Example now looks like this.

I've already written docs for API. :)

👍 LGTM! Just will wait for an approval from another contributor.
/cc @javache @grabbou

@urbancvek updated the pull request.

@nicklockwood you are right it would affect all TabBars. I've now applied it (#212b7c3) just a few lines below where it loops through children TabItems. It will apply styles only for a single TabBar now.

@urbancvek updated the pull request.

@urbancvek updated the pull request.

Is it going to conflict with my PR about itemPositioning? One of them might need rebasing after we merge first one.

@grabbou There might be some conflicts but not in functionality. Will do a rebase if it's needed.

@urbancvek great work!

@facebook-github-bot shipit

Thanks for importing. If you are an FB employee go to Phabricator to review.

@urbancvek updated the pull request.

@urbancvek updated the pull request.

@nicklockwood Hey. I tested a bit more what I have written and found out that it failes if unselectedTintColor prop is not passed in. (Figured that out in Navigator > Jumping Example). I added a check for this before it tries to add color to items here (77a1dd1). Is this why Import failed?

@facebook-github-bot shipit

@urbancvek I think so - import failed because a unit test crashed after it tried to init a dictionary with a nil element.

I tested a bit more what I have written and found out that it failes if unselectedTintColor prop is not passed in.

Removed the Import Failed label because this was a legit error. For tracking purposes I'm using the Import Failed label for failures caused by flakiness only.

Hi @urbancvek ,I found the following code will remove unselectedIcon's gray tint color only, it can't affect selectedIcon so that the selectedIcon will always tinted. You can see my issue #7467
self.barItem.image = [_icon imageWithRenderingMode:UIImageRenderingModeAlwaysOriginal];

Hey @cauchywei! 😊
What my code does is that if you set renderAsOriginal prop to true it will take the icon it's given and render it. The same will happen with selectedIcon. This means you CANNOT control it with tintColor or unselectedTintColor. It will just ignore it. (it will be used for color of the text)
If you want to have the icon or selectedIcon the same color as your text (controlled by tintColor or unselectedTintColor) you just open photoshop or sketch or whatever you are using and make the icon look the way you want. Then just pass it in to TabBarIOS.Item.
I don't know how you want to enhance the TabBarItem because it does everything you could possibly want.

@urbancvek let us about it in may issue #7467 😊

Hi, Im a noob to react and your updates to the TabBar.I have two questions.

Im trying to use renderAsOriginal on the "selected" Tab item but having no success. (I don't want any tint on the selected icon). I only want the text to highlight and the icons to stay full color. renderAsOriginal is  working on the unselected items just fine. Thank you for that.

I was hoping to just have the other unselected items dim in opacity. Is this possible trough this component or will i have to create dimmed versions in photoshop?

Hey @mowi22, sorry for the late answer. Didn't have much time over the weekend but I now implemented what you wanted. Previuosly the component only looked at icon and applied renderAsOriginal to it. It ignored the selectedIcon and rendered it as a template. I will create a new PR now so it will take a few days for it to get accepted.
Thank you for noticing this issue! :D


Fix for Android Indexes not processing correctly on local forms

The android code changed to stop firing the android specific model processors, which was preventing indexes from updating correctly.
Depends on
https://github.com/dimagi/commcare/pull/224/files

@ctsims Can merge this now if you want, but seems like we should be adding regression tests so this doesn't happen again?

@amstone326 Agreed on regressions. Don't think we should block on it yet


Watch only in development env.

Run webpack --watch only if NODE_ENV=development

Development is the default one anyway. Why do you need it?

Fair point. =)


Drop PHP 5 support

Corresponding RFC: https://github.com/grpc/proposal/pull/165

PHP 5 has reached end-of-life in Jan 2019.
PHP 5 accounts for about 6.7% of traffic according to the latest stats: https://blog.packagist.com/php-versions-stats-2020-1-edition/.
Protobuf has dropped PHP 5 support in the PECL extension in the upcoming 4.0 release.
Many major PHP frameworks, extensions and libraries have already dropped PHP 5 support.

Two major near-term sub-projects:

Stop testing against PHP 5 in our PR/master kokoro tests.

If a test is testing against both php (which means PHP 5 in our tests) and php7, drop the php test cases.
If a test is only testing against PHP 5, switch it to test against PHP 7.

Remove code specifically dealing with PHP 5 from our PECL extension.

Future projects:

Add PHP 7 specific syntax features like type-hinting to ourgrpc/grpc composer package.

I am going to start making a series of PRs to remove testing against PHP 5 (probably mostly stuff from the tools directory and their corresponding Dockerfiles and Python scripts), hopefully soon.
The goal is that, by the time the PR removing PHP 5 code from our PECL extension is created, tests should be mostly passing (because hopefully by then all of the tests will only run against PHP 7).

Feel free to send the reviews to me. I like the simplifications this will result in.

The tests I know of:

artifact / package / distribtests
interop tests
backward compatibility tests (need to avoid adding new versions of php5)
run_tests.py tests

Out of curiosity, is there a chance that dropping PHP5 and only using PHP7 would solve the PHP build bug that is causing https://github.com/grpc/grpc/issues/23307?

This issue is completed. We have achieved the goals of 1. removing testing against PHP 5 in our tests (switched to testing against PHP 7 exclusively) and 2. removing PHP 5 support from the PECL extension.


Quote booleans in docker-compose example to fix invalid syntax error

Fixes https://github.com/Chia-Network/chia-docker/issues/220.

Hi @rocketeerbkw sorry to bother in two places, but just a reminder to see this message here https://github.com/Chia-Network/chia-docker/issues/220#issuecomment-1859214196 :smiley: Thank you!

We'll go ahead and fix this in https://github.com/Chia-Network/chia-docker/pull/226
Thanks for the report!


sync.js: Fix Amazon SES syntax errors

There are some syntax errors in routes/sync.js that need fixin'. =)

@aviadgal Excellent catch, thanks! Much appreciated.

Merged #1.


ModuleNotFoundError: No module named 'snapi_py_client'

I have written the below Code :
from snapi_py_client.snapi_bridge import StocknoteAPIPythonBridge
import json
samco=StocknoteAPIPythonBridge()
login=samco.login(body={"userId":'xxxxxx','password':'xxxx','yob':'xxxx'})
print("Login details",login)
##this will return a user details and generated session token
This is the Error Message I am getting
File "C:\Users\BASU\Documents\Python Scripts\SamcoAPI\SamcoAuthCode.py", line 1, in
from snapi_py_client.snapi_bridge import StocknoteAPIPythonBridge
ModuleNotFoundError: No module named 'snapi_py_client'
I have already installed SDK  using  pip install stocknotebridge
Pls Help
How to Rectify ?

Are you able to confirm you are using correct Python environment where you installed this?
Start the shell in that venv and see if you are able to import snapi_py_client