non-SoS config.yml under the same directory

This is perhaps a corner case but it did happen to me: I have a file called config.yml for something totally unrelated to SoS. I have it in a directory where I also run SoS from, without realizing it. Until I decide to set some configuration via sos command. Needless to say my config.yml got edited ... I had to manual undo it, and rename it to avoid conflict with SoS. It is trivial for me but I just worry if we messed up other people's non-SoS config.yml they may be quite upset :)

Proposal?

No idea, other than restricting config.yml to ~/.sos and have uses specify the file to load otherwise. Can be a bit inconvenient, but ... is this a scenario that fits "better safe than sorry"?

Can we simply remove local config an+ rely on the back config and FC?

Yes that's my proposal too


Autocomplete suggestions should use .includes()

Using .startsWith() on this line:
https://github.com/react-toolbox/react-toolbox/blob/afde8b1aa21122aabac1145346ad74f2c4a1782e/components/autocomplete/Autocomplete.js#L154
...is of extremely limited usefulness because it will only suggest matches that start with the query.
Can this just be switched to use .includes() instead (to match the query anywhere in the string)?
Would you want a prop added to the Autocomplete component to control this behavior?
Am willing to do a PR if needed, just wanted to see if this has been discussed before and which approach would be favored.

I'd like to see a prop to control the behaviour.

Starts with
Anywhere inside the string
Starts with, each word (e.g. 'Ro Savage' would match on 'R' and 'Sa')

👍 I'll start work on a PR

PR #572 adds the suggestionMatch prop to the Autocomplete component with the three options start, anywhere, word like @ro-savage mentioned.


use local strategy for quantum

Coverage remained the same at 88.669% when pulling d2e6bf6a9309d8a81e75238ee63bf8d34d30d098 on fix_quantum into 2aed0212b40482dc221feac77875cb13a532db13 on develop.


fix(rpc): use the correct RPC error code for missing blocks

Motivation
lightwalletd expects a specific RPC error code for missing blocks.
If it doesn't get that error code, it exits with a fatal error.
Specifications
This error code is not documented, but I opened a zcashd ticket here:
https://github.com/zcash/zcash/issues/5758
Solution

Return the expected error code for missing blocks
Add a unit test
Update the lightwalletd integration test

Related changes:

Check for some extra RPC failure logs from lightwalletd

Review
Anyone can review this PR.
This fix might be needed for tickets like #3512 (@jvff) and #3926 (@gustavovalverde). Without this fix, lightwalletd exits with a fatal error when it reaches the tip.
Reviewer Checklist

[ ] Code implements Specs and Designs
[ ] Tests for Expected Behaviour
[ ] Tests for Errors

The tests failed due to #3991, so I restarted them.


Will Envoy Proxy support Hyperlight?

Title: Envoy Proxy extension with Hyperlight micro-VMs
Description:

Envoy Proxy allows certain extension points like Go filters, WASM, etc. With the recent release of https://github.com/hyperlight-dev/hyperlight, this is a question to the community if this is something Envoy should support? It could benefit as yet another fast extension point for Envoy which can be safer than WASM.

[optional Relevant Links:]

Current state of WASM - https://github.com/envoyproxy/envoy/issues/35420

There are currently no plans to add hyperlight. We will accept it as a contribution if you have resources to implement this.

CC @keithmattix
I am not sure KVM privilege makes sense as a requirement for Envoy, especially when it runs sandboxed in containers.


Fuzzy image fix

Maximized Game Window
16x9 Aspect Ratio
Before

After

I checked the images folder and it looks like all have been replaced except button and checkmark, I assume those don't need to be replaced? otherwise looks good, thanks for making the improvement

I checked the images folder and it looks like all have been replaced except button and checkmark, I assume those don't need to be replaced? otherwise looks good, thanks for making the improvement

Yes, that's correct. Button and checkmark don't need to be modified. Thanks for checking!


How to add recurring event?

Could someone explain how to display a recurring event? I would like to see a event which appears every Monday in calendar view. For instance, display event with a schedule from 2018-01-12 to 2018-04-12, 12:00 - 13:00 every Monday only.
Thank you!

@McLaLa did you find any solutions to your raised issue??

@akamanzi No, I do my schedule calculations on server side and just present them in calendar view.

You can accomplish this with decorators. Please read the documentation here https://github.com/prolificinteractive/material-calendarview/blob/master/docs/DECORATORS.md


[SOLVED] Export image certain width and height

Hello,
I have a query, I am wanting to export to a resolution of 1500x500 an image of 2000x2000. The problem is that the viewport of that size would not go into some resolutions.
Any ideas ?
thank you very much
regards

Hey, it's not documented yet, but just last week someone submitted a PR to add this functionality.
#101 Added this functionality.  I would follow the sample code in that case and it should help.
We'll try to add this to the documentation soon.

Hi thedustinsmith,
I just tried what you said but without any result. my initialization is as follows
var uploadCropProfile = cropperPortada.croppie({
viewport: {
width: 128,
height: 128
},
boundary: {
width: 400,
height: 150
}
});
And the function bind result is the next :
cropperPortada.croppie('result', {
type   : 'canvas',
format : 'jpeg',
quality: '0.9',
size: {
width: 1500,
height: 500
}
});
I'm uploading an image of a resolution of 1280x720 and 1500x500 want to export it
Thanks

What do you mean by "without any result"?
If you can throw together a jsbin/jsfiddle I might be able to help you out a little more.

i can't export image with custom size. I upload an image of 2000x200 and the viewport is 400x200 and i like export the image of 1500x500

What happens when you call result() with those parameters?  Can you log out the response of result and send it this way?
Or better yet, throw together an example that we can see.

When I get the results of the exported image rather than of 1500x500 it is 100x100
cropperPortada.croppie('result', {
type : 'canvas',
format : 'jpeg',
quality: '0.9',
size: {
width: 1500,
height: 500
}
});

What version of croppie are you using?

i use version 2.0.2. Sorry for my english

Is there anyway you can grab the latest from master and test using that code? https://github.com/Foliotek/Croppie/blob/master/croppie.js
I made a few changes last night that might affect this.

Wooooooooooooooooooooooooooooooooooooooo, amazing.
Very very thankssssss :D

Glad it worked!


Strip whitespaces when checking if asset tag is banned

Sometimes vCenter returns asset tags with a leading whitespace. Instead of adding a second version with a whitespace to the banned tags list we use the strip() method to remove the whitespace before checking.

Fix for
Asset Tags having leading whitespaces #123


Add support for specifying Microsoft.NET.Sdk.Web as the sdk

This PR adds support for specifying an SDK using the #r directive.
The feature is restricted to Microsoft.NET.Sdk.Web at the moment.
Example
#r "sdk:Microsoft.NET.Sdk.Web"

using Microsoft.AspNetCore.Builder;

var a = WebApplication.Create();
a.MapGet("/", () => "Hello world");
a.Run();

This PR also includes a number of updates to NuGet packages referenced by dotnet-script. This should minimize the need for --isolated-load-context. Also removed a few dependencies that are no longer needed. Some of them was just referenced to make things work back when we were at netcoreapp2.1.
Other news. Removed support for Chocolatey 😃

Thanks!

Great, much appreciated!


[code-style] change from astyle to clang-format

The OpenThread project currently uses astyle to automatically format code and enforce the OpenThread style guide.  In general, I've found astyle to be fairly limited.
This is a proposal to change to clang-format 5, which provides a number of useful options not supported by astyle.
Some examples:

Reordering include statements.
Reformatting constructor initializers.
Aligned assignments.
Aligned declarations.
Aligned end-of-line comments.
Adding/fixing end-of-namespace comments.

Review the diff in #2534.
This issue supersedes #1466.

Resolved by #2534.


Stabilize retry timeout error with customer error on timeout

for https://github.com/uber/cadence/issues/2627
tested locally:
2019-11-11T11:26:12.191-0800	ERROR	helloworld/helloworld_workflow.go:49	Activity failed 2.	{"Domain": "samples-domain", "TaskList": "helloWorldGroup", "WorkerID": "60286@longer-C02V60N3HTDG@helloWorldGroup", "WorkflowType": "main.Workflow", "WorkflowID": "helloworld_47fb064f-a9cf-4002-8ce6-0eb8b0badb92", "RunID": "cb1fbf38-8998-46a7-8107-c35bbbfe6164", "error": "longer error"}
main.Workflow

Maybe worth to add an integration test?

sure

Pull Request Test Coverage Report for Build 448

10 of 10 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 75.259%

Totals

Change from base Build 446:
0.05%

Covered Lines:
8715

Relevant Lines:
11580

💛  - Coveralls


Pretrained Model on vggface2

Hello,
I am looking to train this model on my own dataset for which I require a pretrained model on VGGFace2. Can you please make available the pretrained model on the repo?
Thanks

I've done the training on VGGv2, You can find the pretrained weight here https://github.com/khrlimam/res-facenet


Pull Org Data from the Export CSV instead of orgs.yaml

Context: https://github.com/openedx/repo-tools-data-schema/pull/15
We have stopped updating orgs.yaml because it is now redundant with the data we're getting from the salesforce export file.  We need to update the openedx-webhooks code to read orgs out of the salesforce export CSV instead of orgs.yaml or potentially in addition to orgs.yaml.

Looking at the code in openedx-webhooks, it looks like we use orgs.yaml to determine if an organization is "internal" or not.  The behavior of the bot is different for "internal" groups vs external groups.

Ideal state would be to have an "Internal" Column in the salesforce export.
We also can't do this in a sane way until we've cleaned up how we use people.yaml first.  A bunch of the validation for that file assumes an orgs.yaml exists and is coherent with the people.yaml
I'm gonna write up a task to understand what we still need people.yaml for and what it would take to get rid of it.
Blocked by https://github.com/openedx/openedx-webhooks/issues/200


Remove the requirement that any variables be set in the performance timing context

Sometimes the context returns no data e.g.:
{
	"schema": "iglu:org.w3/PerformanceTiming/jsonschema/1-0-0",
	"data": {}
}

We should therefore remove the minProperties constraint so that events with these blank contexts do not fail validation

@yalisassoon do you know what useragent(s) this happens with?


Name/Tag/ID for all resources

Allow all resources to be described with a name, a name tag or ID (given AWS support of tags). This will allow releases to reference resources how they need to.

We use tags on EC2 instances and ASGs for cost tracking purposes.
For instance, we have a tag name like 'team' with a value like 'RedTeam',etc.:
app:frontend
team:ReadTeam
environment:prod

Being able to set that would be very handy.

You can, using the tags: key on service.
This issue is about being able to reference ELBs/TargetGroups using their name tags. This makes it easier to control as Name tags are very easy to change.


t_string! raises an ERROR

Hi,
when testing the t_string! functionality  with an enhanced examples/csr/src/app.rs
let inc = move |_| set_counter.update(|count| *count += 1);

    let count = move || counter.get();

    assert_eq!(t_string!(i18n, click_count, count ),"You clicked 0 times");     // New, to test t_string!

    view! {

{t!(i18n, click_count, count)}

        //
{t!(i18n, click_count, count = move || counter.get())}

        <button on:click=inc>{t!(i18n, click_to_inc)}</button>

I did experience  the following issue (Note: feature "interpolate_display" has beenenabled in Cargo.toml) :
error[E0599]: no method named `var_count_string` found for struct `click_count_builder` in the current scope
  --> src/app.rs:34:45
   |
34 |     assert_eq!(t_string!(i18n, click_count, count ),"You clicked 0 times");
   |                                             ^^^^^
   |
  ::: src/main.rs:4:1
   |
4  | leptos_i18n::load_locales!();
   | ---------------------------- method `var_count_string` not found for this struct
   |
help: there is a method `var_count` with a similar name
   |
34 |     assert_eq!(t_string!(i18n, click_count, var_count ),"You clicked 0 times");
   |                                             ~~~~~~~~~

For more information about this error, try `rustc --explain E0599`.
error: could not compile `csr` (bin "csr") due to 1 previous error
2024-05-14T12:09:57.122064Z ERROR ❌ error

Any suggestion what I'm doing wrong. Here my toolchain, I'm using most actual i18n version
active toolchain
----------------

stable-x86_64-unknown-linux-gnu (default)
rustc 1.78.0 (9b00956e5 2024-04-29)

Thank you in advance
BR

Thanks for the issue, just checked the code and it's because those functions are not created when using the debug_interpolations feature, it's a mistake on my part, I'm fixing the issue and I'll create a patch

Thanks for the issue, just checked the code and it's because those functions are not created when using the debug_interpolations feature, it's a mistake on my part, I'm fixing the issue and I'll create a patch

Hi,
thx. Any suggestion where I can find the patch?
Best

I'm sorry for the wait, I've been dealing with personal issues and haven't got time to work on it, I'll notify you when it's done.

If you give me a hint where I would try for myself.


Add test to reproduce CASSANDRA-13382

A simple upgrade test using materialized views to reproduce the bug from CASSANDRA-13382

Looks good, but the linter is upset about 10-i-1 on lines 5406 and 5410. Can you change those to 10 - i - 1 before merge? Thanks

I wouldn't dream to upset the linter, merged with that fixed. Thanks.


update pattern usage

abnormal anatomical entity morphology terms should be using characteristic of part of in the pattern rather than characteristic of pattern
need to:
change to using this pattern https://raw.githubusercontent.com/obophenotype/upheno/master/src/patterns/dosdp-dev/abnormalMorphologyOfPartOfAnatomicalEntity.yaml
update data spreadsheet to use a combined file of the one in the MP repository and the one in the UPheno repository

spreadsheet has been updated in pull request today (10/17)

This is done


please add following modes(ja)

name:mode
name_synonym:モード
setting_name: Low
setting_synonym: 音控えめ、音控え目
setting_name: quiet
setting_synonym: 音控えめ、音控え目、マナー
setting_name: manner
setting_synonym: マナー

It seems like low is already available. The other settings will be added.

I know Low is already available.I want to add setting_synonym「音控えめ、音控え目」
there are only 「低, 低め」

I understand.

These requests have been added. Check out the documentation to learn more: https://developers.google.com/actions/reference/smarthome/traits/modes#mode-settings_10

Sorry,I tried that.
But it was not OK.
「低, 低め」was OK but 「音控えめ、音控え目」was not OK.
What is the cause?
sample speak：
「devicename のモードを低めにして」it was OK
「devicename のモードを音控えめにして」it was not OK
it means 「set mode to low for (devicename)」
I just changed [setting_synonym]parts and speak.

additional infomation：
manner was OK.
「devicename のモードをマナーにして」it was OK


Added a syncToContext option to useInterpret and useMachine

This implementation is exceptionally naive, but it appears to work. I'd love advice on how I can improve this.

[ ] Add docs
[ ] Add changeset
[ ] Improve implementation?
[ ] https://twitter.com/zhzhng/status/1441032589947518979 - Consider whether to handle dependency changes explicitly, or implicitly

Hi @mattpocock, I just wanted to say that this change looks fantastic and will really simplify some things on our end! The only thing I'm wondering is if shortening it to just sync would be clear enough? Just a thought, very happy with it being called syncToContext as well.

Would there be any way to make this work with useActor also, or is it too late at that point?
Could that screw things up if you have multiple consumers of that actor?

@simonflk No, I don't think it could - part of the reason it works here is that it patches the machine definition in order to get it to work. By the point you're consuming the machine, you're too late to modify it.
This could work later on, though, if we got more support in core (a proper service.updateContext method or similar).
But it gets hairy if you have multiple actor call sites all trying to sync their context to the same actor. A little nasty IMO.

Re: making it work for useActor etc., we also have to be careful that we're not allowing unsafe behavior. Editing the context from anywhere, despite being convenient, also makes the logic much less robust and more unpredictable. The "slippery slope" here is context becoming a magical bag of values that can change at any time (and arguably, it's still magical even if there is a special "change" transition patched onto the original machine definition).
One potential idea for this is scoping this under input (imagine a state.input = { ... } property). The role of input would be precisely for external values coming into the machine; it would not be mixed with context, and it can only be changed externally (never modified with assign(...)). It would also make machines more pluggable into flow-based programming contexts (visualization++).

@davidkpiano 100%! It would be much clearer. But, for v5 so it can be given first-class support

Superseded by https://github.com/statelyai/xstate/pull/2779


Basic English to Igbo Search Functionality

Currently, the API allows for Igbo to English search, but to further expand what this API can do it needs to have an English to Igbo search capability.
This issue doesn't focus on implementing a full fledge English to Igbo, instead the main focus is to lay down the ground work for future related features.

I am wondering if there is a contributor's guide. We've got a route structure like this -> http://localhost:8080/api/v1/search/words?keyword=agụū for the igbo, right? I think the route structure needs to be redesign in a way to accommodate English-Igbo, Igbo-English
Maybe something like http://localhost:8080/api/v1/search/en-igbo/words?keyword=agụū and can be switched vice versa

en-igbo
igbo-en

What do you think?

I am wondering if there is a contributor's guide. We've got a route structure like this -> http://localhost:8080/api/v1/search/words?keyword=agụū for the igbo, right? I think the route structure needs to be redesign in a way to accommodate English-Igbo, Igbo-English
Maybe something like http://localhost:8080/api/v1/search/en-igbo/words?keyword=hunger and can be switched vice versa

en-igbo
igbo-en

What do you think @ijemmao ?

@ezesundayeze 100% agree on creating a Contributor's guide to make this more accessible to people. I'll make it within the next few days.
I've been modeling the user experience off of what my favorite Japanese-English dictionary - https://jisho.org/
Notice how the route structure doesn't change when you request the Japanese word using Romantic characters vs using the original Japanese characters.
But for now, I do agree with having two separate routes. Doing that will help separate out the work that needs to be done.
The hardest part of this issue is that we need to come up with a smart way to reverse index terms based on the English instead of the Igbo.
Do you have any ideas of how we would want to structure our data to make it easier to search using English?

Notice how the route structure doesn't change when you request the Japanese word using Romantic characters vs using the original Japanese characters.

Yea, right.

The hardest part of this issue is that we need to come up with a smart way to reverse index terms based on the English instead of the Igbo. Do you have any ideas of how we would want to structure our data to make it easier to search using English?

I will have to check in with this, let's see.

The hardest part of this issue is that we need to come up with a smart way to reverse index terms based on the English instead of the Igbo. Do you have any ideas of how we would want to structure our data to make it easier to search using English?

I can only remember doing that tokenisation and reverse index thing in my NLP class 😊 . Will have to check in again.

Please let me know what you find! I'm going to start this ticket. I'm planning on achieving basic functionality, so nothing to too crazy. If there's a feature that you want to see from this API let me know!


[AKS] fix get-credentials without directory

Closes #4849.
Closes Azure/AKS#42.

View a preview at https://prompt.ws/r/Azure/azure-cli/4901
This is an experimental preview for @microsoft.com users.
(It may take a minute or two for your instance to be ready)
Email feedback to 'azfeedback' with subject 'Prompt Feedback'.

Tests failing :-/

Tests pass for me though, with run_tests --module acs. It's just in the two PURPOSE="Automation" jobs where it errors out.
How can I reproduce the failure in Travis CI locally?
$ ./scripts/ci/test_automation.sh
Missing version string

run_tests --module acs should also run the two tests that are failing. I'm surprised that all of the tests pass for you.
You can run the specific tests that are failing with:
run_tests --module acs --test test_aks_commands.AzureKubernetesServiceScenarioTest.test_aks_create_with_upgrade
(replace the ending with the other failing test to run the other)
I just tried running the test_aks_create_with_upgrade test myself with your recording and I get the same error as in Travis CI.
I also ran the test with --live and I get a CloudError: 400 Client Error: Bad Request for url:

@mboersma can you try deleting all the recordings in acs (should be four of them), re-recording all the tests by running them live, and then playing back all the tests using those recordings?

@williexu I would love to, but AKS is heavily oversubscribed and the chances of me getting a clean az acs + az aks test run are very low currently. I have been trying to regenerate the recordings but no luck so far. I'll keep trying.

@williexu I noticed our tests could contend over a local file where the ACS service principal is cached. So I rewrote the az aks create commands to use an explicit SP and secret instead, then regenerated the VCR yaml on a clean run of run_tests --module acs.

@williexu this should be ready to merge now.


Conditionally include the /graphql route

Desired Behavior
For those testing out GraphQL but not yet ready to have it in production, it would be great to conditionally include the route.

@waiting-for-dev thanks for getting this merged!!
Any change of a 0.3.1 release so we can point to that instead of a specific SHA on GitHub within our project? :smiley:
Enjoy your weekend :wave:

@zachfeldman, all yours! :point_right: https://rubygems.org/gems/solidus_graphql_api/versions/0.3.1 :slightly_smiling_face:
Happy weekend! :clap:


RedesignHomePage

Changed up home page to match new design.

🚢

:ship: but in the future please be careful about including merge commits in a pull request. (The first two in on the "commits" tab are the ones I'm referring to)

Also does Job1 not have a phone number? Did we never show one for them?


High memory usage of CSV sorting

Hello,
I was trying to use the application on a Linkstation LS-QVL(ARMv5, 256MB ram) running Debian Buster.
`
$ uname -a
Linux nasprimary 4.19.0-14-marvell # 1 Debian 4.19.171-2 (2021-01-30) armv5tel GNU/Linux
$ cat /proc/cpuinfo
processor	: 0
model name	: Feroceon 88FR131 rev 1 (v5l)
BogoMIPS	: 400.00
Features	: swp half thumb fastmult edsp
CPU implementer	: 0x56
CPU architecture: 5TE
CPU variant	: 0x2
CPU part	: 0x131
CPU revision	: 1
Hardware	: Marvell Kirkwood (Flattened Device Tree)
Revision	: 0000
Serial		:<PHONE_NUMBER>000000
$ free
total        used        free      shared  buff/cache   available
Mem:         254040       82320       35056         964      136664      162848
Swap:       1000432        3592      996840
`
While it builds natively and runs. It quickly consumes all available memory sorting the downloaded CSV file.
Ref: https://github.com/BurntSushi/imdb-rename/issues/12
Due to the high memory requirements of trying to load the entire CSV file into memory, would it not be possible to leave the file on disk and build an index in memory? It would be slower but would have to be done only once?
Building the index in memory while leaving the huge CSV file on disk would also the application to work of small SBC computers such as the Raspberry Pi, Orange Pi and others which typically ship with 256MB-2GB ram (ignoring the 4GB RPi).
Thanks

The high memory usage was intentional for implementation simplicity. If you can come up with a small and simple patch that fixes your problem, then I'd be okay with that. It's been a while since I've touched this code, but I don't think such a patch exists. Otherwise, I have no intention of fixing this. Sorry.

Ok, understandable.
I'll leave the below if anybody comes across this issue in future
How to index a csv file:
https://stackoverflow.com/questions/36089456/indexing-columns-in-a-csv-file/46253244

@minimum-necessary-change "creating an index file" is not a solution to this problem. In fact, that's basically the entire point of imdb-rename. Most of the code in this project is specifically for creating an index into the CSV files. How else would querying be instantaneous? The process of creating an index is actually already optimized to not require the entire corpus to be in memory at once. Unfortunately, in order to do that, it requires that the CSV records be in lexicographically sorted order. This used to be the case, but the source of the data changed such that it was no longer sorted. I then implemented a simple fix in commit 09e07a22, which was to load the entire data in memory and sort it. That initial implementation used more memory than necessary for this specific corpus though, and commit 2ea88a08 fixed that.
So "indexing a csv file" is missing the point here. The actual issue influencing memory usage is sorting the data. Fixing that requires doing sorting of data with a fixed memory usage limit. Such a thing is of course possible. But it is much more complex than loading everything into memory. In principle, tools like GNU sort do this, but I am not interested in shelling out to such tools in this program.
To summarize, if one can create a simple patch that sorts the lines of a file with bounded memory usage without sacrificing too much performance, then I'd accept that. If the simple patch requires the use of a third party crate, then that crate needs to pass my quality standards.

Thanks for the info.
As a test I imported the TSV into sqlite3 on the low memory NAS and selected "Battlefield Earth" as a quick test. The results are below. Although the import wasn't in anyway quick the memory impact was minimal.
I really am not a script programmer so my Rust is pretty sparse. I can read it but my API knowledge is lacking.
`$ sqlite3
sqlite> create table title (titleId text, ordering int, title text, region text, language text, types text, attributes text, isOriginalTitle int);
sqlite> .separator "\t"
sqlite> .import title.akas.tsv title
sqlite> select title,ordering from title where title = "Battlefield Earth" order by ordering asc;
Battlefield Earth	1
Battlefield Earth	5
Battlefield Earth	12
Battlefield Earth	16
Battlefield Earth	18
Battlefield Earth	22
Battlefield Earth	32
sqlite> .exit
$ ls -al ./
total 2587972
drwxr-xr-x  2 mnc mnc           41 Mar  3 14:25 .
drwxr-xr-x 11 mnc users        148 Mar  3 14:05 ..
-rw-r--r--  1 mnc mnc<PHONE_NUMBER> Mar  3 14:25 imdb.db
-rw-r--r--  1 mnc mnc<PHONE_NUMBER> Feb 14 13:20 title.akas.tsv
$ free
total        used        free      shared  buff/cache   available
Mem:         254040       74764       16412        1044      162864      169912
Swap:       1000432        7564      992868
`
Thanks.

I don't understand what you're trying to show. You're using sqlite3 as an elaborate implementation of out-of-core sorting, which is exactly what I said was needed here. (Short of a more clever approach that utilizes properties of the source data, if they exist.)

I apologise in that we seem to be slightly at odds. I am simply looking for a solution to a memory usage problem.
I started out programming the Atari 400, Commodore 128, Amigas and Atari ST, using tape drives, floppy disks and my first hard drive was a mere 10MB. Memory was a premium and so when I see a CSV/TSV file requiring 1.7GB to be sorted when I believe all that was required is to obtain a sorted index onto that CSV fixed data. I find myself perplexed.
By using the command-line interface, I was trying to establish whether it was feasible to use the tried and tested sqlite database library to effectively sort and index the IMDB data in an efficient manner on a low memory machine.
I have also just now found a rust (module?) that handles sqlite3 databases @ https://rust-lang-nursery.github.io/rust-cookbook/database/sqlite.html
None of this information I knew earlier this morning!
`
$ cat import_tsv.sh
#!/bin/bash
sqlite3 imdb2.db -cmd "create table title (titleId text, ordering int, title text, region text, language text, types text, attributes text, isOriginalTitle int);" ".exit"
sqlite3 imdb2.db -cmd ".separator "\t"" ".import title.akas.tsv title" ".exit"
sqlite3 imdb2.db -cmd "select title,ordering from title where title = 'Battlefield Earth' order by ordering asc;" ".exit"
$ time ./import_tsv.sh
title.akas.tsv:155487: unescaped " character
title.akas.tsv:155490: unescaped " character
title.akas.tsv:155490: unescaped " character
. . .
. . .
title.akas.tsv:24974908: unescaped " character
title.akas.tsv:25062776: unescaped " character
title.akas.tsv:25064331: unescaped " character
Battlefield Earth|1
Battlefield Earth|5
Battlefield Earth|12
Battlefield Earth|16
Battlefield Earth|18
Battlefield Earth|22
Battlefield Earth|32
real	15m46.520s
user	15m2.422s
sys	0m29.171s
$ time sqlite3 imdb2.db -cmd "select title,ordering from title where title = 'Battlefield Earth' order by ordering asc;" ".exit"
Battlefield Earth|1
Battlefield Earth|5
Battlefield Earth|12
Battlefield Earth|16
Battlefield Earth|18
Battlefield Earth|22
Battlefield Earth|32
real	0m35.261s
user	0m24.971s
sys	0m9.199s
`
Thanks

Yes, we're at odds. Writing code for memory constrained systems when dealing with corpora that don't fit into the memory of said systems is harder than writing code for systems that can fit said corpora into memory. You pointing at sqlite3 and saying, "see it's possible" is actually supporting that point. sqlite3 is a monstrously complicated embedded database. The entire point of sqlite3 is to be out-of-core!
In case you're saying, "well, then please just use sqlite3." Well, no, sqlite3 doesn't support the kind of information retrieval techniques used by imdb-rename. Moreover, sqlite3 is not a dependency I want to add to this tool. Using sqlite3 would imply significant design changes to how this tool works.
Upon reviewing the code, I was mistaken earlier when I said that the rest of the index creation process was designed such that it doesn't require putting some significant fraction of the corpus in memory. Thus, fixing just the CSV sorting won't resolve this problem as far as I can tell. It looks like there are other portions of the index creation process that do additional sorting, so those would in turn also need to be converted to out-of-core sorts.
I see no simple patch to fix your problem.

Ok, thanks for taking a deeper look at this.
We can probably let it go now.


Remove several unnecessary clippy attributes

Am I missing something and are they necessary in some other clippy configuration than the one I ran?
It's surprising really that clippy doesn't have a lint to notice unnecessary clippy exception attributes..

It's surprising really that clippy doesn't have a lint to notice unnecessary clippy exception attributes.

Yeah, that would useful.

I guess a newer version of clippy changed them to pedantic or something like that.


Add password to latest release of codeserver

How to add password to latest release of codeserver?
I have tried using export PASSWORD='pass' but it didn't work.
Thank you

if you're using the legacy way
export PASSWORD="uwu"

./code-server --port=9000 --auth=password

that won't work, do it this way instead:
export PASSWORD="uwu"
./code-server --port=9000

Hello,
I have exactly the same problem: Trying to run code-server on a azure VM running Ubunut 18.04 permanently, but setting the password does not work, neither with --auth=password nor without it. Never got it to work on a GCP VM too.

Hi @sr229 , I've checked the mentioned method but it is not working. Please have a look.

Hi @sr229 , I've checked the mentioned method but it is not working. Please have a look.

Try putting --auth=password or do it this way
PASSWORD="uwu" ./code-server [flags]

Hi @sr229 , I have installed the next release and it worked.
Thank you


Prevent use of section fields in searches

Ban the section, subsection and subsubsection field from use in
searches (in facets or as return fields).  We believe we have removed
all use of these fields by apps (see
https://trello.com/c/N0dU4k3G/296-remove-section-subsection-and-subsubsection-from-rummager),
but will test this carefully on preview to be sure.
Note that the data will be removed from the database automatically after this is deployed by the nightly migration run.

:fireworks:


Simplification integration tests are flaky

The tests in Test.Kore.Step.Simplification.Integration are flaky with respect to time and memory use. We should add a timeout by applying localOption (mkTimeout _) to the affected tests. (See: localOption, mkTimeout`).
Reproducibility suffers because of using a small number of samples with Hedgehog. We can increase the number of samples using HedgehogTestLimit with localOption.

@jberthold I think this is similar to your most recent PR.

Nice, did not know tasty supports that.
What my code did and tasty might not do is print offending input but continue the test after a timeout occurs. Also, I think the timeout would apply to the entire test, not just to one input as in my code.


Show repository migration progress in go-ipfs 0.12+

Ref. https://github.com/brave/brave-browser/issues/20106, https://github.com/ipfs/go-ipfs/issues/8344

MVP in Desktop case would be to show window with startup log that contains migration progress.
It should also detect migration errors like: https://github.com/ipfs/ipfs-desktop/issues/1823

How to test or simulate migration
One can create ~/.ipfs (IPFS_PATH with a repo that needs to be migrated) by:

downloading go-ipfs v0.11
executing IPFS_PATH=/migration-test ipfs init and  IPFS_PATH=/migration-test ipfs add --cid-version 1 on some files
downloading  go-ipfs 0.12-rc1
executing IPFS_PATH=/migration-test ipfs daemon --migrate=true with 0.12 binary

Wireframe
My initial idea is to have something very simple and generic:

Key points

detects when go-ipfs runs a migration and inform user why it takes long to start IPFS Desktop

one sentence should be enough, most users do not care and will just dismiss and let it run in the background

shows stdout+stderr from ipfs daemon as a way to eyeball migration progress

:point_right: we were lucky until now, could skip this for most migrations, but we have to have some progress indicator  for 0.12 where migration may take anywhere from a few seconds/minutes to hours (if someone has a slow HDD and hosts hundreds of gigabytes of CIDv1 data  such as  wikipedia snapshots). showing the daemon output feels like the best we can do given existing APIs.

:information_source:   ipfsd-ctl pipes both stdout and stderr to debug logger – i wonder if we could read it somehow? In terminal I can do DEBUG="ipfsd-ctl:daemon:*" npm start  and see the daemon output. I know that ipfs log tail also exists but it does not seem to be wired up to show migration log.

:bulb:  this could be useful outside migrations – we could show this window  also when go-ipfs fails to start. Original error from ipfs daemon may allow more savvy users to self-service and fix basic problems.

easy to dismiss

one button that closes the info window
closing the window does not interrupt migration/startup process, it should continue in the background

@hacdias will you have time to poke at this sometime in next two weeks?
Not a fire, but we won't be able to ship ipfs-desktop 0.12 without  this, and I am just planning ahead :)

@lidel yes, I can work on this. I can read the stdout and stderr in this way:
// define ipfsd

const interval = setInterval(() => {
    const sub = ipfsd.subprocess
    if (!sub) {
      return
    }

    sub.stdout.on('data', data => console.log(data.toString()))
    sub.stderr.on('data', data => console.log(data.toString()))
   	clearInterval(interval)
}, 100)

ipfsd.start()

However, .subprocess is undocumented and probably should't be directly used. Besides, the interval to try to get the subprocess variable between it is created and the daemon is actually created is a bit fiddly, but it works! I will try using this for now to implement the logging. Perhaps we should consider adding some API for this on IPFSD CTL later.

Thanks!

FYSA 0.12 got released, so you can test with official release now :)
subprocess is part of the public Controller interface, so I think it is safe to use for now
when we have a PR demonstrating our use case, we can ping Hugo to advise on improving the ipfsd-ctl API


Dark mode: Classes names in UML Diagrams are not visible in dark mode.

Describe the bug
When opening any exercise which has UML diagrams in it, you can notice that class names are not visible.

To Reproduce

Go to any exercise with UML diagram.
See error

Expected behavior
Make class names visible and maybe all diagrams also have dark mode.
Browser extension used for this screenshot - Dark Reader.

Screenshots
No response
What browsers are you seeing the problem on?
Microsoft Edge
Additional context
No response
Relevant log output
No response

This is related to PlantUML. I noticed that the diagrams also do not reload when users switch between dark and light mode.
This might also be related to a migration of existing problem statements.
In our previous tests, the diagrams rather looked like this

Seems to be a migration issue. We will manually remove the skins in the problem statements of the exercises in which the skins remain


Add title and adjust highlight in configured redirects code samples

What kind of changes does this PR include?

Minor content fixes (broken links, typos, etc.)

Description

No issue but addresses request from @sarah11918
Adds a title missing from the third code snippet in the Configured Redirects section of the Routing page. In addition, I adjusted the highlights in the first and third code snippets so that they mark the code being described in the text. In the current version, the first code snippet highlights the final line and two lines that don't exist (7-9).

Before:

After:

Actually, yes! I migrated my personal site as a test and now I'm working on moving Opal Grove's over. Starting with the one Astro Shopify theme but I've got a bunch of things I want to add 🤩
I'll share more on Twitter but excited about this first little PR!


Performance 10x worse than C implementation

I've been timing the C implementation versus the rust implementation and I generally notice about a factor of 8-10x difference.
Do you know offhand any obvious performance tradeoffs that were made in the design of this version?
Do you have any ideas about various strategies we could employ to bring it within a factor of two, or ideally to the same speed as the C version especially for multi-megabyte files?
I noticed no inline assembly in the C version, so I'm hoping it is possible to bring the rust version to parity.
Have you done any profiling of the existing code or compared it with the C code?

perf record shows
  48.54%  main  main              [.] _ZN21Decompressor$LT$R$GT$10decompress19h833558899976614058E
  32.45%  main  main              [.] _ZN7huffman4tree4Tree13lookup_symbol20h3239110865486455736E
   8.84%  main  main              [.] _ZN9bitreader18BitReader$LT$R$GT$10read_exact20h9307349387484
   2.72%  main  libc-2.15.so      [.] __memcpy_ssse3_back
   1.69%  main  main              [.] _ZN4main20h236efd01b33cc363UdaE
   1.13%  main  main              [.] _ZN13brotli..State9drop.582217h2d226c43866a0306E
   1.05%  main  [unknown]         [k] 0xffffffff81391b17
   0.53%  main  main              [.] _ZN3vec12Vec$LT$T$GT$19extend_with_element20h4407735263573563

As compared with the C version
  90.61%  secbrot  secbrot           [.] ProcessCommands
   4.63%  secbrot  [unknown]         [k] 0xffffffff81391b17
   1.24%  secbrot  secbrot           [.] __intel_avx_rep_memcpy
   1.24%  secbrot  [unknown]         [k] 0xffffffff81198b61
   1.23%  secbrot  [unknown]         [k] 0xffffffff81391ef5
   1.02%  secbrot  secbrot           [.] _intel_fast_memcmp

Yes, performance has not been a focus point at all so far.
I've started this project as a a way to get familiar with Rust, and also with the Brotli spec.
For the implementation, I have made it a point to work only from the spec, while avoiding looking at the reference implementation, because another goal was helping to improve the Brotli spec itself.
I do believe that there are a number of places where copies could be avoided, and other places where I used clone() simply because at the time I was unable otherwise to appease the borrow checker.
For a performance-oriented implementation, I would probably take the test cases and experiences so far, and start over with a new implementation.

So I decided to work on a performance-focused version of the decompressor here:
https://github.com/dropbox/rust-brotli
It passes the first few unit tests..but still has a few correctness issues I'm working through.
I decided to do a very apples-to-apples port, avoiding even the rust stdlib, so that we can get a really solid performance comparison between C and Rust down to the same custom memory allocator.
I'd love comments if you have any--though of course it's still early since only the very basic tests pass

Wow, that is a very impressive effort! Was rust-alloc-no-stdlib a direct consequence of the as-close-as-possible port?
No helpful comments yet, other than that it looks like very organized code. It will certainly be a superior implementation once you've ironed out the last few correctness issues.


Replace pushPage/popPage with a more flexible gotoPage method

Reimplementation of https://github.com/wagtail/wagtail/pull/6234 in TypeScript, minus some extra refactoring, and a fix for https://github.com/wagtail/wagtail/pull/6234#discussion_r501617578

@kaedroho looking at this now

Merged in via f0ce1f4775927b1fe38042e756e880e753a0baf1 - works as expected, matches the existing approved JS approach from what I can see.
@kaedroho - awesome work! One step closer to our locale features :)


Direct Scheduler throughput e2e test-suite

What would you like to be added:
We need a test suite for measuring direct scheduler throughput without depending on KCM QPS limits.
Why is this needed:

Today our load test only tests scheduler-throughput at a a very small scale i.e max-pods to 5k and also its limited by KCM throughput as current test-suite depends on deployment/replicaset controller throughput in creating pods. That would limit us from knowing the actual scheduler throughput that we can achieve out of scheduler today.

Also, some users of K8s today actually leverage scheduler directly to create pods without having to depend on KCM for other wrappers like deployments/jobs/replicaset controllers, we need a test-suite that would help us know the limits of scheduler throughput without having to depend on the KCM bottlenecks/regressions.

We could use this test-suite to run periodically in test-infra to see if we truly regress w.r.t max scheduler throughput in our e2e tests.

I discussed this in Sig-scalability meeting here and got consensu
Post the sig-scalability discussion, it also appears there is need for scheduler throughput regressions from sig-scheduling folks, for context here - https://kubernetes.slack.com/archives/C09QZTRH7/p1715262959575039
/cc @wojtek-t @marseel

/cc @dims @mengqiy @shyamjvs - fyi

Closed by https://github.com/kubernetes/perf-tests/pull/2682
/close


Analyse broker metrics before rolling kafka

Feedback from @SamBarker
I think the proposal does a nice job of summarising the plan. I'm just an interested observer so haven't seen a lot of detail or done much thinking about the problem.

I see jetty as an implementation detail. I think the high level outline should just say add a web sever, or even light weight web server and then specify jetty in an implementation section.

I also wonder if a servlet which only servers broker-state is overly restrictive? Maybe a suggest adding a metrics servlet which accepts a metric name or maybe a metric key as a parameter (I'd be 100% on board with the implementation only supporting a fixed value of broker-state) I see this as being an equivalent design in the short term but one that is more open to extension in the future. I imagine we will want something similar in the future to expose quorum status or similar in the kraft world.

I think the proposal should probably give some details about the format/schema it supports for metrics it exposes. Potentially supporting the Prometheus format is the cheapest way forward, again mostly thinking about being open for extension rather than current requirements. Prometheus already has a standard for exposing metrics over HTTP which we could just re-use, if its appropriate.

This could well be my lack of experience with the roller but I would sort of expect a broker in log recovery to pass a timeout check as it was still doing something useful. So I would probably be talking in terms of eagerly checking for broker-state or log-recovery rather than doing in the exceptional case.

I think what I'm really diving at is I want the proposal to have two different sections. A high level overview of the big picture changes: Add web server exposing metrics. Followed by an proposed implementation talking about Jetty and the specifics of the endpoint(s) i.e. GET requests.

I think one other aspect should be also considered here ... not just the upgrades from the older version without the HTTP based agent. But also the future-looking upgrades. So I think it should consider two things:

While I do not think this constitutes a public API per-se, we should have some concept of API versioning to be able to handle future evolutions and changes
We should have some mechanism to discover the supported versions of the API

This should help to facilitate smooth upgrades also for the future.

Thanks so much everyone for reviewing the proposal and providing very good feedback. I have addressed the last 2 comments, so it should be ready to merge if there is nothing else. 🙂

I think we should give more time for other maintainers to review it after the last changes. For whatever reason, a lot of them were removed from the review request and I had to add them again yesterday. So I think we should not merge it yet.
CC @strimzi/maintainers + @tombentley who looks like he commented but did not approved.

Thanks for this @tinaselenge, it is an important (and long overdue) improvement.

We have now 6 binding +1 votes and 1 non-biding +1 (well, 2 including the proposal author). Let's will keep it open for another day and if nobody else raises any comments we should proceed and merged this as approved.

Approved with 6 binding votes. Thanks for theproposal @tinaselenge

@tinaselenge Thanks for opening this proposal! We hit the same issues from time to time in our production. Let me know if any help, pr reviews or etc, I can make to make this land in the release.


Stale issue marking not working properly

Describe the bug
When the issue is marked as inactive no activity label cannot be removed by issue author in any way

Example issues
#856 #855 #844 #809 #779 #963 #769
Expected behaviour
The label should be removed after the author post any message on issue like still valid
Affected workflow
https://github.com/CircuitVerse/CircuitVerse/blob/master/.github/workflows/stale.yml
Are you working on this issue? (Yes/No)
No

I think this can be done by adding this to the stale.yml: exempt-issue-label: <label-name> and exempt-pr-label: <label-name>

Can I work on this @Ananthavijay ? Is it just the line that needs to be added ?

@ShubhankarKG Yes you can if u want to

I'll take up this one then.

The solution might be stale bot but, it needs to be added by admin (probably @tachyons can take it)

Irony

What does it mean by no activity ?
Only close ?

@tachyons I am confused, is this working or not?

Already removed the github action for marking stale PRs
On Saturday, October 3, 2020, Satvik Ramaprasad<EMAIL_ADDRESS>wrote:

@tachyons https://github.com/tachyons I am confused, is this working or
not?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/CircuitVerse/CircuitVerse/issues/1381#issuecomment-702956121,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXYAEETJXSDETSWLEDO5STSIY5VTANCNFSM4MEUKM5Q
.

--
Regards
Aboobacker MK

Closing this issue as we are removed the bot


Memory-efficient parallel tile computation

Done in https://github.com/jeff-regier/Celeste.jl/pull/77


Version française

Un élément important à garder à l'esprit est d'avoir le contenu accessible autant en anglais qu'en français.
Il faudra s'assurer de traduire la documentation au fur et à mesure.

Hi Guillaume,
I’m in the process of adding the French meeting minutes to the OSAB  page. I was going through other French minutes and noticed that the title at the top of the page is in English, “Open Source Advisory Board meeting” so I’m going in to change it to the “conseil consultatif les sources ouvertes”.  However, I am still able to make changes directly into the master, so I don’t think that the master branch has been enabled. I'll continue my work on it though

Hi @StaceyWilliams !
You're technically supposed to be working in a seperate branch than the master as it is locked down. You can edit all documents withing GitHub and it should automatically save it to your new branch. We'll chat offline. Thanks!

All good, checked settings and that's normal behaviour for you.


could not fetch configuration from btcpay server

When scanning QR code for wallet setup on btcpay server, I get this error
Description
In BTCPAY Server under LND GRPC service, I can see that Zap is under the compatible wallets, however when I scan the QR code I get that error.
Expected Behavior
Connect zap to the lnd
Actual Behavior
Error : could not fetch configuration from btcpay server
Your Environment
Zap Android
Zap version: 0.5.2-beta, build 3032
FYI : I am using APK installation API 30, when I click on my menu button top left, I see "lnd version: Not connected" at the bottom of the menu under version and build.

Have you already tried to disable tor for the connection process?
Please turn it off in the apps settings and see if this helps. You can probably turn it on later if it worked.

That was absolutely right on! Its connected fine now, thank you very much. One final question, can I connect multiple android wallets to that BTCPAY Server instance using the same QR code ?

Awesome. Then it is most likely cloudflare again blocking requests originating from the Tor Network. Maybe I should add a hint to the error message that this can be the problem.
Regarding to your question, yes you can. Zap Android is just like a remote control. All important things still happen on the node it self.

A hint to the error message would be great. Thanks for your help. Best Regards.


Provide a data helper construct to copy a dataset from an S3 bucket to another

PoC/demos need data that can be simply copied from public datasets (https://github.com/awslabs/aws-data-solutions-framework/blob/main/examples/spark-data-lake/infra/stacks/demo_helpers/data_load.py)

implemented in #292


Add aliases that conform with other STL container types

Brief feature description
Add aliases that conform with other STL container types
Detailed information
The current iox container types such miss a lot of aliases normally present in STL type containers, such as size_type, index_type, reference, const_reference, difference_type. These are normally useful in writing type traits for STL and STL-like container types and are used a lot in templated code.

@gmandhyan would be great to have those aliases. Patches welcome :)

Have a PR up, appreciate your review 🙏
https://github.com/eclipse-iceoryx/iceoryx/pull/2223


Cloud gov support & tf changelog

Codecov Report
Attention: Patch coverage is 68.08511% with 30 lines in your changes missing coverage. Please review.

Project coverage is 48.96%. Comparing base (dd1ed91) to head (6b5b449).

Files
Patch %
Lines

py/atlas_init/cli_tf/app.py
17.64%
14 Missing :warning:

py/atlas_init/cli_tf/changelog.py
81.69%
9 Missing and 4 partials :warning:

py/atlas_init/repos/path.py
33.33%
1 Missing and 1 partial :warning:

py/atlas_init/settings/env_vars.py
66.66%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   47.80%   48.96%   +1.15%
==========================================
  Files          24       25       +1
  Lines        1594     1685      +91
  Branches      271      284      +13
==========================================
+ Hits          762      825      +63
- Misses        809      833      +24
- Partials       23       27       +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Display / source selection issue in Internet Explorer

I use the page periodically -- probably once a month or so -- and discovered today that it no longer seems to be functional when loaded using Internet Explorer 11.  I'm running on a desktop PC with Windows 10 64-bit, and a fully-updated copy of IE 11 and this seems to be a recent change (the last time I recall loading the page in IE, it worked fine).
When I load up the site with all filters cleared, the monster selection area is empty.  I noticed that the "Set Sources" menu, when opened, is also empty except for the "Everything", "Core Books", and "None" buttons at the top.  There are no individual sources shown below, and no individual checkboxes.
Pressing any of the three buttons in the "Set Sources" menu has no apparent effect.
I tried flushing my browser cache, and also tried a forced reload of the page -- both before and after clearing the cache -- with no apparent effect.
It seems as though the page still works okay in Chrome and Firefox.

I don't have access to IE 11 to test it, and supporting IE isn't a priority for me.
If someone who cares wants to fix this, I'll happily accept a pull request.

IE 11 error happens here:
TypeError: Object doesn't support property or method 'parseInt'
at Anonymous function (http://kobold.club/fight/js/app-7de1c12eba.js:1188:5)
at Monster (http://kobold.club/fight/js/app-7de1c12eba.js:1184:4)
at Anonymous function (http://kobold.club/fight/js/app-7de1c12eba.js:2265:4)
at loadMonsters (http://kobold.club/fight/js/app-7de1c12eba.js:2263:3)
at loadSheet (http://kobold.club/fight/js/app-7de1c12eba.js:2235:4)
at Anonymous function (http://kobold.club/fight/js/app-7de1c12eba.js:3017:3)
at processQueue (http://kobold.club/fight/thirdparty/angular/angular.js:16606:11)
at Anonymous function (http://kobold.club/fight/thirdparty/angular/angular.js:16622:27)
at Scope.prototype.$eval (http://kobold.club/fight/thirdparty/angular/angular.js:17913:9)
at Scope.prototype.$digest (http://kobold.club/fight/thirdparty/angular/angular.js:17727:15)
			// Try to parse each of these into a number, but if that fails then just give the
			// original string value, which presumably is either an empty string or something
			// complicated
			var parsed = Number.parseInt(args[key]);

https://stackoverflow.com/questions/28350236/why-use-number-parseint-instead-of-parseint

This should now be fixed. I still don't have easy access to IE11 so I can't test it. If this is still a problem please comment and I'll reopen the issue.


Document req/res "inheritance"

I'm assuming this fact was always part of the official API of express, just never spelled out in the docs.

This looks good to me.  @jkrems I just have one request: In text, please capitalize "Node".
@hacksparrow Can you take a quick look.

Now with capitalized "Node"!

Thanks @jkrems!
LGTM, but I'll wait for @hacksparrow to review and merge.

Thank You, @jkrems


Trev8939/fix deprecations

Description
Fix deprecated functions ahead of U15

Thanks for catching those @shubham7109!

Feel free to merge when you think this is ready @shubham7109!


fips: zeroization of ECX public keys

Commit fa338aa7cd added zeroization of public security parameters as required by ISO 19790:2012/Cor.1:2015 7.9. However, that commit overlooked ECX keys, which are used for EdDSA and X25519/X448.

I strongly oppose doing these types of changes.

@t8m friendly reminder, is this something the OTC needs to discuss?

@jvdsn can you please rebase and/or fix the code style issue? Somehow that errors out, so something is not right.

@xnox not sure what the issue was there, the check output didn't give a lot of information. I rebased it, let's see if it still fails.

OTC: zeroize public parameters or not?

OTC: Please put this behind #ifdef OPENSSL_PEDANTIC_ZEROIZATION

@t8m I changed it, sorry for the delay

This pull request is ready to merge

Merged to the master branch. Thank you for your contribution.


migrate examples to openApi part5; affects [itunes jetbrains jitpack keybase lemmy luarocks maintenance openvsx]

Refs #9285
..and so begins the long slow process of working through these. The first batch I am working on is classes with:

currently passing service tests
only path params
either one example, or two examples due to optional path params (e.g: branch*)
no documentation string

These are the most trivial services to convert, requiring the least manual work.
I am going to submit PRs touching batches of about 15-20 files at a time as I work through these.
Then I'll start moving onto slightly more complicated cases.

The tests for liberapay pass locally.
When I try to run them in GitHub actions, they fail.
It seems that when we call liberapay from GH actions, instead of a JSON response we get a 403 error with a javascript challenge (designed to prevent bots/scrapers/etc). You can see the output of npm run badge https://img.shields.io/liberapay/gives/Changaco invoked from GitHub actions here https://github.com/badges/shields/actions/runs/5730805389/job/15530375550
I'm not going to attempt to address that here. I've just removed it from the list of services we're testing against.


MVT_Postgis vs postgres tile difference, checkerboarding when styled

I've attempted to migrate our tegola setup to mvt_postgis to capitalize on the performance improvements, and resolve some weird blank spots in maps, but am instead getting strange checkerboarding across tiles when I attempt to style.
[[providers.layers]]
name = "us_adm1"
tablename = "public.us_adm1"
geometry_type = "multipolygon"
geometry_fieldname = "geom"
id_fieldname = "gid"
sql = 'SELECT "gid", ST_AsMVTGeom(ST_Transform(geom, 3857),ST_Transform(!BBOX!, 3857)) AS geom, "adm0code", "adm1code", "name" FROM public.us_adm1 WHERE geom && !BBOX!'

I don't get this banding with my regular format, but instead get weirdly cut polgyons that leave gaps. My usual config section for the same is this:
[[providers.layers]]
name = "us_adm1"
geometry_type = "MultiPolygon"
sql = "SELECT name, gid, adm1code, adm0code, ST_AsBinary(geom) AS geom FROM public.us_adm1 WHERE geom && !BBOX!"

@KCC-IT-Admin what projection are your geometries in? It looks like you're trying to reproject to 3857 on the fly using ST_Transform(), which will work but is going to be much slower. Anyways, I think the issue is you're not reprojecting the second !BBOX! token:
Change:
WHERE geom && !BBOX!

To
WHERE geom && ST_Transform(!BBOX!, 3857)

yes, our data is all in 4326.
Would I need to transform the geom as well as the BBOX?

OK- quick update, I ran the updated query as written, and got blank tiles- I ran it after transforming the !BBOX! data and got workable tiles, but the same checkerboard issue persisted.

@KCC-IT-Admin can you please post your update query?
If all your data is in 4326, try the following query:
sql = "SELECT ST_AsMVTGeom(geom, ST_Transform(!BBOX!,4326)) AS geom, gid FROM gis.landuse WHERE geom && ST_Transform(!BBOX!,4326)"

Alternatively, you can set the srid field on in the config. I left a comment next to the change:
[[providers.layers]]
name = "us_adm1"
tablename = "public.us_adm1"
geometry_type = "multipolygon"
geometry_fieldname = "geom"
id_fieldname = "gid"
srid = 4326 # this will transform the !BBOX! token to the 4326 projection
sql = 'SELECT "gid", ST_AsMVTGeom(geom, !BBOX!) AS geom, "adm0code", "adm1code", "name" FROM public.us_adm1 WHERE geom && !BBOX!'

Correction, our data is all in 4326, but the tiles being output should be in 3857

@KCC-IT-Admin ok. I think you're close. Did you find the documentation I wrote up around this situation?
https://github.com/go-spatial/tegola/tree/master/mvtprovider/postgis#example-mvt_postgis-and-map-config-for-srid-4326

I did, yes - I was using a query based off your initial documentation before we started this. the SRID is set on the provider as 4326.
Your Sample was
sql = "SELECT ST_AsMVTGeom(ST_Transform(geom, 3857),ST_Transform(!BBOX!,3857)) AS geom, gid FROM gis.landuse WHERE geom && !BBOX!"
and I was using
sql = 'SELECT "gid", ST_AsMVTGeom(ST_Transform(geom, 3857),ST_Transform(!BBOX!, 3857)) AS geom, "adm0code", "adm1code", "name" FROM public.us_adm1 WHERE geom && !BBOX!'
I've tried it with GID before and after the geometry in case it was an issue with that.
I'm thinking there's something different with how the mvt creates tiles vs how tegola creates them that makes shapes that spread across multiple tiles sometimes style differently

@KCC-IT-Admin can you confirm that you have added the srid to the provider toml config? The original toml you posted did NOT have the srid attribute set. The TOML should look like the following:
[[providers.layers]]
name = "us_adm1"
tablename = "public.us_adm1"
geometry_type = "multipolygon"
geometry_fieldname = "geom"
id_fieldname = "gid"
srid = 4326 # is this set in your config?
sql = 'SELECT "gid", ST_AsMVTGeom(ST_Transform(geom, 3857),ST_Transform(!BBOX!, 3857)) AS geom, "adm0code", "adm1code", "name" FROM public.us_adm1 WHERE geom && !BBOX!'

To break down what's happening here:

tegola is receiving a z/x/y tile request and computing a bounding box for the tile. The resulting polygon is in the 4326 projection (because the srid is set in the provider config).
PostGIS is using the 4326 version of the !BBOX! in the WHERE goem && !BBOX! statement to determine which geometries intersect with the tile bounds.
PostGIS is then Transforming the geometries that intersect with the tile bounds to the 3857 projection. It's also transforming the !BBOX! from 4326 -> 3857 in the ST_AsMVTGeom() operation so the geometry and tile coordinate space line up. This makes the tiles returned from PostGIS compatible with a web mercator based UI rendering system (i.e. Mapbox, MapLibre).

It's nuanced, but if you get all these params correctly configured then it should work for you. Also, if you want to jump into our Slack, I can try to give you some support there: http://slack.go-spatial.org/


Problems with webpack

It's seems that the compiled-grammer is not webpack-ready.
Module not found: Error: Cannot resolve module 'fs' in ./node_modules/route-parser/lib/route
 @ ./~/route-parser/lib/route/compiled-grammar.js 617:17-30

Thanks for the report. A basic jison parser generate() generates a module that has a main() function to use as a command line wrapper. We don't need that here, and it's been removed.

Cool!


zipline does not work

Lara can interact but the zipline doesn't move and she gets stuck mid way
https://github.com/MontyTRC89/TombEngine/assets/80340234/69d97b79-a94e-4487-8f73-a4e54c372f00

https://www.dropbox.com/s/um67j26tlsop12e/test level.zip?dl=0

false alarm.


failed to remux atmos

Hello I tried to download atmos songs but I get this ffmpeg error I downloaded the suggest ffmpeg binarie from the readme but still get it.
gamdl "https://music.apple.com/us/album/lovefool/1450141530?i=1450141548" --ffmpeg-path "c:/rclone/ffmpeg.exe"
[WARNING  18:25:33] You have chosen a non-legacy codec. Support for non-legacy codecs are not guaranteed, as most of the songs cannot be downloaded when using non-legacy codecs.
[INFO     18:25:33] (URL 1/1) Checking "https://music.apple.com/us/album/lovefool/1450141530?i=1450141548"
[INFO     18:25:34] (Track 1/1 from URL 1/1) Downloading "Lovefool"
[eac3 @<PHONE_NUMBER>f8b580] invalid sample rate
[eac3 @<PHONE_NUMBER>f8b580] unable to determine channel mode
[aost#0:0/copy @<PHONE_NUMBER>0fac00] Error submitting a packet to the muxer: Invalid data found when processing input
Last message repeated 1 times
[out#0/mp4 @<PHONE_NUMBER>f8b740] Error muxing a packet
[out#0/mp4 @<PHONE_NUMBER>f8b740] Task finished with error code: -1094995529 (Invalid data found when processing input)
[out#0/mp4 @<PHONE_NUMBER>f8b740] Terminating thread with return code -1094995529 (Invalid data found when processing input)
[ERROR    18:25:40] (Track 1/1 from URL 1/1) Failed to download "Lovefool"``

Try using the recommended ffmpeg binary listed on the readme.


redis cluster can't reconnect when JedisCluster getClusterNodes()  return null

Expected behavior
can reconnect when  clazz JedisCluster.getClusterNodes()  is null
Actual behavior
can't reconnect ,because JedisClusterInfoCache  getNodes is null
Steps to reproduce:

run redis cluster 3.2.8  in kubernetes

my app starting ,create jediscluster instances for code :
 HashSet<HostAndPort> hset = new HashSet<HostAndPort>();
 String[] args = clusters.split(";");
 for (String arg : args) {
     String[] info = arg.split(":");
     hset.add(new HostAndPort(info[0], Integer.valueOf(info[1])));
 }
 JedisCluster jedisCluster = new JedisCluster(hset, timeout, timeout, 2, jedisPoolConfig);
 Map<String, JedisPool> nodes = nodes(jedisCluster);
 LOGGER.info("jedisCluster nodes={} ", nodes);

output:
jedisCluster nodes={}

my application started ,execute redis set("1","1") but
throw new JedisNoReachableClusterNodeException("No reachable node in cluster");

Redis / Jedis Configuration
<bean id="jedisPoolConfig" class="redis.clients.jedis.JedisPoolConfig">
    <property name="maxTotal" value="5000"/>
    <property name="maxIdle" value="500"/>
    <property name="minIdle" value="100"/>
    <property name="blockWhenExhausted" value="false"/>
    <property name="maxWaitMillis" value="100"/>
    <property name="testOnBorrow" value="false"/>
    <property name="testOnReturn" value="false"/>
    <property name="testWhileIdle" value="false"/>
</bean>

<bean id="jedisCluster" class="org.sdn.common.utils.redis.JedisClusterFactory">
    <property name="clusters" value="${spring.redis.cluster.nodes}"/>
    <property name="jedisPoolConfig" ref="jedisPoolConfig"/>
    <property name="timeout" value="${spring.redis.cluster.timeout}"/>
</bean>

Jedis version:
2.9.0
Redis version:
3.2.8
Java version:
1.8
@xetorthio
i saw jedis code :
@Override
public Jedis getConnectionFromSlot(int slot) {
JedisPool connectionPool = cache.getSlotPool(slot);
if (connectionPool != null) {
// It can't guaranteed to get valid connection because of node
// assignment
return connectionPool.getResource();
} else {
renewSlotCache(); //It's abnormal situation for cluster mode, that we have just nothing for slot, try to rediscover state
connectionPool = cache.getSlotPool(slot);
if (connectionPool != null) {
return connectionPool.getResource();
} else {
//no choice, fallback to new connection to random node
return getConnection();
}
}
}
my think so :
nodes return null,cause cache.getSlotPool(slot) return null .and return null connectionPool,even if execute renewSlotCache, because nodes is empty ,jedis client  do nothing....
Ho to Fix

Seems like a miss configuration in the cluster. Can you please provide the output of cluster nodes and cluster slots please?

<IP_ADDRESS>:6379> CLUSTER nodes
ff1cd6b9341f679dd5a2ea21b9cabe44610d994b <IP_ADDRESS>:6379 myself,master - 0 0 3 connected 10923-16383
c37906f41a7a5270e7e5a89022f6ef49fd273967 <IP_ADDRESS>:6379 slave ff1cd6b9341f679dd5a2ea21b9cabe44610d994b 0<PHONE_NUMBER>190 6 connected
4f0a4ed2899d9b46b6ed32c1808a4a4d903cc5ba <IP_ADDRESS>:6379 slave 076888e7b2e659feb2bf05867ecb10eca75f2e45 0<PHONE_NUMBER>192 4 connected
d99cb312f5f26281890445bd658c481b5aedb8e4 <IP_ADDRESS>:6379 master - 0<PHONE_NUMBER>165 2 connected 5461-10922
de06eee1ccee954d9acca74f894f5d468a779d74 <IP_ADDRESS>:6379 slave d99cb312f5f26281890445bd658c481b5aedb8e4 0<PHONE_NUMBER>186 2 connected
076888e7b2e659feb2bf05867ecb10eca75f2e45 <IP_ADDRESS>:6379 master - 0<PHONE_NUMBER>178 1 connected 0-5460
<IP_ADDRESS>:6379> CLUSTER SLOTS

(integer) 10923
(integer) 16383

"<IP_ADDRESS>"
(integer) 6379
"ff1cd6b9341f679dd5a2ea21b9cabe44610d994b"

"<IP_ADDRESS>"
(integer) 6379
"c37906f41a7a5270e7e5a89022f6ef49fd273967"

(integer) 5461
(integer) 10922

"<IP_ADDRESS>"
(integer) 6379
"d99cb312f5f26281890445bd658c481b5aedb8e4"

"<IP_ADDRESS>"
(integer) 6379
"de06eee1ccee954d9acca74f894f5d468a779d74"

(integer) 0
(integer) 5460

"<IP_ADDRESS>"
(integer) 6379
"076888e7b2e659feb2bf05867ecb10eca75f2e45"

"<IP_ADDRESS>"
(integer) 6379
"4f0a4ed2899d9b46b6ed32c1808a4a4d903cc5ba"

@marcosnils

@changealice thanks. Have you checked that the application has access to those IP's and ports from where your running it?

@marcosnils thanks , i don't think cluster node and slot has problems ,
i think this question is redis client network can't connect redis cluster ,so jedis client return empty nodes ,but jedis client return empty node instead of   throw NoNodesException
i' m try exec tcpdump command in order by find this questions ,
when my app start , i 'm invoke redis.set(key,value). nothing packing found to connect redis server

,so jedis client return empty nodes ,but jedis client return empty node instead of throw NoNodesException

Jedis doest lazy initialization when working with clusters. That's why you got JedisNoReachableClusterNodeException("No reachable node in cluster"); when you tried to execute an operation. As I said before I believe the problem is that the machine where you're running your app cannot reach the redis servers with the IP that cluster slots return.

@marcosnils
But my network is recovered ,
the jedis client is not recreate  cluster  nodes, is not it should be initialized jediscluster ?
So get the conclusion
jedis reconnection mechanism must be the first to get to cluster nodes to work?

@marcosnils My current solution is stupid and rude, the first time I am  start jedis client connection redis cluster server, if the cluster nodes is empty, I will throw new InstantiationError("redis nodes is empty");
failed to prevent the application starts normally


Handle dangling cloud resources

In the following issue - https://github.com/confidential-containers/cloud-api-adaptor/issues/328 we discussed about the dangling cloud resource problem. Currently cloud-api-adaptor (CAA) is stateless and this results in cases where the pod VM instances created by the caa is not deleted if the worker node reboots (on error, node maintenance etc).
To handle such cases, we felt the need to have a CRD for pod VM to maintain the state and perform required cleanups.
cc @yoheiueda @jensfr @surajssd

Currently, cloud-api-adaptor uses a on-memory map to manage mapping between VM instances and pod VMs. cloud-api-adaptor runs on a worker node, so a worker node crash results in a loss of the mapping information. This leads to dangling pod VMs.
To solve this problem, we can use a CRD object to represent a pod VM.  CRD objects are resilient to worker node crashes, and we can implement a controller to monitor CRD objects to clean dangling pod VMs.
This is the (incomplete) controller code that implements a similar mechanism. This code comes from  my project project, so cannot directly be applied to cloud-api-adaptor, but we can use it as a reference.
https://gist.github.com/yoheiueda/122619c2b12457edd46105741a14bf09
PeerPod is a CRD that represents a peer pod VM. There is a 1-1 mapping between Pod and PeerPod objects. A PeerPod objects contains VM instance information such as ID and IP address.
A PeerPod has a owner reference to the Pod object. This reference manages mapping between PeerPod and Pod, and guarantees the PeerPod object is automatically deleted, when the corresponding Pod object is deleted.
https://kubernetes.io/docs/concepts/overview/working-with-objects/owners-dependents/
When the controller detects a new Pod creation with a specific runtimeClass, it creates a PeerPod object with a owner reference to the original Pod object.
The controller monitors PeerPod object creation, and when it detects a new PeerPod object, it talks with a cloud API endpoint to create a new VM instance. When it obtains VM information such as IP address of the newly created VM instance, it updates the PeerPod object to include such VM information.
When CAA receives a CreateSandboxRequest from Kata shim, it talks with Kubernetes API server to wait for the corresponding PeerPod object becoming ready. Then, CAA gets the IP address information from the updated PeerPod object, and establishes a tunnel for agent protocol communication between kata shim and kata agent.
When the controller detects deletion of a PeerPod objects, it talks with the cloud API endpoint to delete the VM instance.
With this approach, we don't need to care about dangling VM problem. Kubernetes guarantees the PeerPod object is deleted when the corresponding Pod object is deleted.

I wonder whether we can introduce this change more incrementally:
If we create/delete the PeerPod CRD Object in the CAA daemonset, instead of provisioning the peerpod compute resources directly and have a controller handle the Peerpod objects to provision/cleanup vm, etc resources. would that work?
A crash in the daemonset might still produce dangling Peerpod objects, but if we annotate them with an OwnerReference to the pod,  a deletion of the pod would cascade to the peerpod.
This way we'd keep the daemonset setup in place and offload the CSP resource mgmt to a dedicated controller.

@mkulke If I understand correctly, you are suggesting to create the PeerPod CRD from the CAA daemonset and set the OwnerReference to the Pod. We'll still need the CRD controller to ensure no cloud instance remains post pod deletion.
I am in favour of this approach as we can keep the daemonset setup in place and make gradual changes.

@bpradipt yes, this would be my suggestion. keeping the daemonset in place, adding a controller/crd as layer of indirection, manage crds instead of calling out to CSP APIs directly in the daemonset.

I agree, that's a good first step!

cc @snir911


No response after creating .cpp file

These days when I use Visual Studio Code(right after Jan.1, 2021), I found that sometimes if I create a new file and change it's suffix name to .cpp, it didn't response. Whic means this new file is still named as "Untitled.txt", I hope if you can check that?
Or maybe just because I finish these operation too fast.

Can you please share the code that is in the file when you change it .cpp?

It's empty, I found this bug(?) when I was creating a new file, and just turn it in to .cpp, because the default type is .txt

And I was just be surprised because of the extremely fast reply from VScode

Ah, I thought you were saying that VS Code became unresponsive (froze) when you changed the file extension to cpp.
Can you provide step by step instructions for how to reproduce the issue? For example, where are you changing the extension cpp?

Emm, it's my problem that I didn't get a good title.
I just mean that when I am trying to create a new file and turn the .txt to .cpp, nothing happens, the file is still named as untitled.txt, not the name I typed in.

And if I close it and open it again, it will be named as the correct one


Downgrade busybox version to fix k8s IT (#14518)

Downgrading busybox version in Dockerfile to fix following error,
=> ERROR [stage-2  3/10] RUN ["/busybox/busybox", "--install", "/bin"]                                                                          0.4s

[stage-2  3/10] RUN ["/busybox/busybox", "--install", "/bin"]:
#0 0.293 /busybox/busybox: /lib/aarch64-linux-gnu/libc.so.6: version GLIBC_2.33' not found (required by /busybox/busybox) #0 0.293 /busybox/busybox: /lib/aarch64-linux-gnu/libc.so.6: version GLIBC_2.34' not found (required by /busybox/busybox)
This PR has:

been self-reviewed.
using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)
added documentation for new or modified features or behaviors.
a release note entry in the PR description.
added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
added or updated version, license, or notice information in licenses.yaml
added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
added integration tests.
been tested in a test Druid cluster.

@pagrawal10 we should indicate that this is a backport of https://github.com/apache/druid/pull/14518 and cherry-pick that commit so that it's clear this is a backport from upstream and not something done specifically in our fork


#issue 6 Improved the project page when you click on it, so it's easy to navigate back to the main site

Please, go through these steps before you submit a PR.

[x ] My Pod Leader knows I'm working on this Pull Request
[ x] I've explained what the Pull Request is adding.
[ ] I've explained why this is important.

Cool, nice feature! Thanks


Add support for apama aggregates

It would be nice to be able to directly support apama aggregates, something like this:
Observable.fromValues([1,2,3])
    .aggregate(customAggregate)

Limitations:

The aggregate will probably have to accept and return any types, or we'll need special handling for all possible primitive options

This isn't currently possible


RFC: type class synthesis order when outParam has multiple possible values

Proposal
Classes such as MonadState, MonadExcept, MonadReader have an outParam, and they also come with a version with a semiOutParam, namely MonadStateOf, MonadExceptOf and MonadReaderOf. The value that gets picked for the outParam depends on the order in which instances are applied during type class resolution. This can be influenced by setting priorities on the instances, but this is not currently done.  The convention for monad transformers tends to be that the outermost transformer is the one that gives the outParam instance and programmers rely on this a lot.
Bad instance example
example (e : ε) : ExceptT ε MetaM Unit := throw e -- error

gives an error, because the instance generated for MonadExcept is the one that comes from the CoreM instance. So, we could increase the priority of the instance MonadExcept ε (ExceptT ε). This would make it much more convenient to use ExceptT in this scenario.
Similarly, I propose to give a high instance priority to MonadState σ (StateT σ), MonadReader ρ (ReaderT ρ) etc.. These won't have any direct effect as far as I know of, but will make sure that no future instances will accidentally mess with the expected behaviour of these classes.
Original discussion
Original discussion on Zulip. This topic came up when I found a use of the MonadStore1 type class where it should be used with a semiOutParam, but it has an outParam. This class should be refactored to have a version MonadStore1Of with the semiOutParam, following the design of the aforementioned type classes. And for this we also want the instance priorities to be set properly.

I've made a draft PR that fixes the bad example: #4223

RFC accepted

Orthogonal to the fix in #5291 (which is the fix as described in this RFC), we can still set a low priority for Lean.MonadError.toMonadExceptOf, Lean.MonadError.toMonadRef and Lean.MonadError.toAddErrorMessageContext, which, as seen in #4223, improves efficiency in type class search.


Do we have source map expose for this library?

Hello Author,
I have problem for debugging or understanding the library from the browser. Can we expose the source map for debugging?

I am not seeing the .map file in the dist folder.

I see. The gulp code is using inline-source-maps for Webpack.


Menus sometimes display HTML notation

After using the style guide generator for a while it sometimes breaks and the menus start showing HTML notation (see the screenshot below). After restarting the style guide generator everything returns to normal.

The issue can be reproduced by loading the page a few times while the style guide is being built. The problem remains after the build is completed so it is not simply about looking at an incomplete version. Perhaps the broken version is cached somewhere and the actual working version never replaces the broken one in the cache.

I am experiencing this very same issue. I've tried everything and the only thing I find to work as this point is restarting the server. I currently close the server and re-run "npm run demo" to get the ui to be correct again.

I feel like this needs to be addressed sooner than later since this is really a productivity killer in the sense that one needs to stop and start the server to see the ui correctly.

I will have a look at this next.

Awesome. Thanks! Also here is a screen shot verifying my same behavior as described cyberixae.


Question: How to do parameterized routes

Thank you for sharing this idea with the world!
How do we create a parameterized page route using ngext?
From pages/README.md:

PAGES
This directory contains your application pages.
Each page file is mapped to a url route in your application.
~/pages/page.ts          ->  /page
~/pages/folder/index.ts  ->  /folder
~/pages/folder/page.ts   ->  /folder/page

Compiled routes are found in ~/.ngext/src/routes.ts
How would we do /page/{id}?

Hi @LayZeeDK,
Thanks for checking out the project! Yes, I need to work on the documentation a bit, but for now, this is what you're looking for:
parameterized page route
Simply putting a : in front of the page component filename, signifies that it is a Parametrized route, which will give you the params in ActivatedRoute.params
Page File                  Route
~/pages/user/:id.ts   ->  /folder/:id

Let me know if there's anything else you need.
Cheers,
Ben

Hi @LayZeeDK,
Thanks for checking out the project! Yes, I need to work on the documentation a bit, but for now, this is what you're looking for:
parameterized page route
Simply putting a : in front of the page component filename, signifies that it is a Parametrized route, which will give you the params in ActivatedRoute.params
Page File                  Route
~/pages/user/:id.ts   ->  /folder/:id

Let me know if there's anything else you need.
Cheers,
Ben

:id.ts is an invalid filename in Windows ☹

:id.ts is an invalid filename in Windows ☹

Oh no! Sorry about that, I had no idea, as I'm on Ubuntu.
Okay, I'll change it from : to the _ character, like this:
Page File                  Route (Generated)
~/pages/user/_id.ts   ->  /folder/:id

Thanks for reporting the issue, and let me know if there's anything else.
Cheers,
Ben

Oh no! Sorry about that, I had no idea, as I'm on Ubuntu.
Okay, I'll change it from : to the _ character, like this:
Page File                  Route (Generated)
~/pages/user/_id.ts   ->  /folder/:id

Thanks for reporting the issue, and let me know if there's anything else.
Cheers,
Ben

Dynamic routes now use _ in version 0.1.0 :+1:

Dynamic routes now use _ in version 0.1.0 :+1:

Thanks for the quick fix!
How about nested parameterized routes such as:

/blog/:categoryId/:articleId
/catalog/:categoryId/:productId
/company/:customerId/offices/:officeId

No worries! Yes that should work as expected. It will convert them for any amount of nested routes, like this:
Page File                                               Route (Generated)
~/pages/company/_customer-id/office/_office-id.ts   ->  /company/:customer-id/office/:office-id

Then you can access those params in the ActivatedRoute on the page component.

No worries! Yes that should work as expected. It will convert them for any amount of nested routes, like this:
Page File                                               Route (Generated)
~/pages/company/_customer-id/office/_office-id.ts   ->  /company/:customer-id/office/:office-id

Then you can access those params in the ActivatedRoute on the page component.

Leaving this as closed. Thank you for the support!

Leaving this as closed. Thank you for the support!


Build without Cocoapods

I'm using RN=0.39 and I don't use Cocoapods. I'm able to build v1.2.3. But with v2.0.0 I get:
In file included from /Users/giro/stardust-app/node_modules/react-native-onesignal/ios/RCTOneSignal/RCTOneSignal.m:1:
/Users/giro/stardust-app/node_modules/react-native-onesignal/ios/RCTOneSignal/RCTOneSignal.h:4:9: fatal error: 'OneSignal/OneSignal.h' file not found
#import <OneSignal/OneSignal.h>

This happens even if every single header/framework search path setting is correctly set.
Probably just need to change that path or something; I'm not knowledgeable in XCode/Objective-C so I'm hoping somebody can help fix this.

Here's a public repo that reproduces this problem: https://github.com/GeoffreyPlitt/react_native_minimal/tree/onesignal

Please look at this example:
https://github.com/geektimecoil/react-native-onesignal/tree/master/examples/ios/OneSignalWithoutCocoa

@avishayil This example does not exist in the 2.x branch

@avishayil Please re-open, this was a false fix

Any Idea as to when a fix will be completed? I really don't want to use pods. Thanks

We're actively working on it

Thanks man... I feel the pain... Upgrading past RN40 has big a huge pain with several libraries in our project.

@avishayil we also waiting this to be fixed for using this in production. thanks in advance!
ping @baskan

merged, tested and fixed.

Just wanted to Say THANK YOU!!! and We appreciate your expedited hard work....

@GroupXTech Our pleasure :>


Fix issue #39

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@Failte327 thanks for great work, LGTM, merging


Add support for Unlease Context properties

Fixes #14
Now, the IContext is an object of arbitrary key value pairs. Extend this to implement the Unlease Context (https://www.unleash-hosted.com/docs/the-unleash-context)
and fixes #3
We want to allow a consumer of the UnleashClient to be able to send the properties field, as mentioned in the Unlease Context. This allows them to support custom activation strategies. In this PR I flatten the properties into the url search params, so a properties object like
properties: {
  property1: 'property1Value',
  property2: 'property2Value'
}

would yield url search params properties.property1=property1Value&properties.property2=property2Value

Thanks for doing this @mattmurph9. I need to verify that the current unleash-proxy actually support the properties params. I think it will, but want to verify, have some time later today :100:
Also, because of the change in updateContext I want this to be a minor release, and that we document the changes. It will only be a breaking for users using the type definitions, and they will get a warning in their IDE.

would yield url search params properties.property1=property1Value&properties.property2=property2Value

It would be beneficial if it could format the properties on as query params a bit different:
properties[property1]=property1Value&properties[property2]=property2Value
using obj[prop] it looks like nested objects will be supported out of the box with express and other web frameworks. While object.prop would require custom parsing in express (current proxy implementation).

would yield url search params properties.property1=property1Value&properties.property2=property2Value

It would be beneficial if it could format the properties on as query params a bit different:
properties[property1]=property1Value&properties[property2]=property2Value
using obj[prop] it looks like nested objects will be supported out of the box with express and other web frameworks. While object.prop would require custom parsing in express (current proxy implementation).

@ivarconr sounds good! I'm not familiar with how this would be supported out of the box, but the approach sounds viable to me. What should nested objects look like in the url search params?

It would be beneficial if it could format the properties on as query params a bit different:
properties[property1]=property1Value&properties[property2]=property2Value

Fixed in 84f976a

Do we want to allow nested properties?

No SDKs supports this today, so I would rather not add this now, as it is unclear how the proxy should handle this.

Indeed, there cannot be nested objects, as properties is a str:str hash.

@ivarconr is there anything left blocking merging this PR? Let me know if you want any other changes!

thanks for your work. I general I agree with the approach. I will try to get through this tonight or tomorrow to make sure there are no extra details we need to fix.

No problem! I look forward to seeing it merged 🚀

released as part of 1.1.0


Vendor Update: go-gitlab v0.22.1 -> v0.31.0

as title

Codecov Report

Merging #11136 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #11136      +/-   ##
==========================================
- Coverage   43.27%   43.25%   -0.02%
==========================================
  Files         601      601
  Lines       85533    85531       -2
==========================================
- Hits        37012    36997      -15
- Misses      43951    43958       +7
- Partials     4570     4576       +6

Impacted Files
Coverage Δ

modules/migrations/gitlab.go
1.76% <0.00%> (+<0.01%)
:arrow_up:

modules/process/manager.go
74.69% <0.00%> (-3.62%)
:arrow_down:

modules/queue/unique_queue_disk_channel.go
53.84% <0.00%> (-1.93%)
:arrow_down:

services/pull/pull.go
33.39% <0.00%> (-0.77%)
:arrow_down:

modules/notification/webhook/webhook.go
39.61% <0.00%> (-0.59%)
:arrow_down:

models/issue.go
51.48% <0.00%> (-0.47%)
:arrow_down:

modules/git/repo.go
52.30% <0.00%> (+1.25%)
:arrow_up:

models/unit.go
44.44% <0.00%> (+2.46%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c092eb...673024b. Read the comment docs.

It's somewhat of a shame the number of dependencies this causes to be duplicated.


Create JSON examples of what's in the API index that can be consumed by the API repo

For https://github.com/wellcomecollection/platform/issues/5449
We've drastically changed the structure of the API index, and the way the API should use it – so rather than continuing to replicate internal model between the pipeline/API repos, I want to investigate breaking that link.
This PR introduces a new trait ApiFixtures, with a model that defines what a JSON fixture looks like:
case class Fixture(
  description: String,
  createdAt: Instant = Instant.now(),
  id: String,
  document: Json
)

These fixtures get serialised as JSON in the fixtures folder (name tbc), and then in the API tests there are helpers that will index these JSON files into Elasticsearch (specifically, the document property).
We'll need way more fixtures than this to get the API tests passing, but hopefully this is enough to illustrate the idea. I want to get a sense of whether others think this is a sensible approach before digging into it.

Bit of a bikeshed but I would be in favour of the naming snapshots over fixtures

I don't love the name "snapshots", because it already has a meaning in the context of our Elasticsearch indexes, but agree fixtures is not good either.

Is it not pretty similar to that use of the term?

Or maybe mock_documents?

+1 for test_documents

Superseded by other PRs.


Support custom indices in test files

There are a number of detections whose
attack_data MUST be uploaded into specific
indices.  This is required due to macros that
are used to search for that data or for
Datamodel Acceleration searches that require
data to be resident in specific indexes.
This PR adds the ability to specify a field
called "custom_index" in the test.yml files.
This field can be specified for each individual file
(just like source and sourcetype).  If this field is
not present, then a default index
(at this time "main") will be used for replaying
data.

LGTM 😄


Calling setLoggerLevel does nothing

[REQUIRED] Step 1: Describe your environment

Xcode version: 11.3.1
Firebase SDK version: 6.18 and 6.20
Firebase Component: Analytics
Component version: 6.18 and 6.20
Installation method: CocoaPods

[REQUIRED] Step 2: Describe the problem
FirebaseConfiguration.shared.setLoggerLevel(.min) has no effect on the logging.
This is same as #3516, I apologize for the duplicate but I couldn't find any solution in other place neither comment on the that ticket.
Steps to reproduce:

After AppDelegate.application(:didFinishLaunchingWithOptions:) is being executed call FirebaseConfiguration.shared.setLoggerLevel(.min) and FirebaseApp.configure().
Run the app attached to the debugger

Expected
Less logs on the console
Actual
Same amount of logs regardless of the param used on setLoggerLevel
Relevant Code:
FirebaseConfiguration.shared.setLoggerLevel(.min)
FirebaseApp.configure()

Thanks for the report - I was able to reproduce this. There was a small effect on the logging (3 lines added from Core) when going from .min -> .max but Analytics still logs everything regardless.
I found a few workarounds for the time being:

Call setLoggerLevel(.min) after FirebaseApp.configure() quiets the logs significantly
Use the instructions logged to disable debug logging: "To disable debug logging set the following application argument: -noFIRAnalyticsDebugEnabled (see http://goo.gl/RfcP7r)"

Will report internally and update with a bug number shortly.

Filed internally at b/151716193

Did you start your project from the quickstart? It looks like the quickstart includes the -FIRAnalyticsDebugEnabled flag by default in the scheme for quickstart applications which could explain the debug logs appearing there.

thank you very much for your quick response @ryanwilson
I did what you mention (calling setLoggerLevel(.min) after FirebaseApp.configure()) and the logs are still the same.

Did you start your project from the quickstart? It looks like the quickstart includes the -FIRAnalyticsDebugEnabled flag by default in the scheme for quickstart applications which could explain the debug logs appearing there.

No I didnt, however I am using -FIRDebugEnabled flag and according to the docs if we disable it, my measurements will be affected during testing and development.
If you need more information please let me know.
TIA

Ahh - thanks for the info! What if you combine -FIRDebugEnabled with -noFIRAnalyticsDebugEnabled? The naming is slightly confusing but I'm fairly certain that the -noFIRAnalyticsDebugEnabled is for Xcode console logging only, not the actual events being passed through.
I'll confirm with the Analytics team that's a reasonable approach as well but worth a go before they are online :)

I apologize for the late response...
Yes! -noFIRAnalyticsDebugEnabled reduces the logs significantly.
Just to confirm, for now the solution would be to use -noFIRAnalyticsDebugEnabled flag and once the bug when sending LoggerLevel is fix, I guess the logs will be reduced even more?
Thanks!

I'm going to close here in favor of continued related conversation in #5704


Fixed an issue that has caused MachineConfig parametrized with a subset of events not being accepted as part of the MachineConfig accepting the whole set of those events

fixes https://github.com/davidkpiano/xstate/discussions/1603#discussioncomment-117608

Some failing tests (TypeScript) but otherwise LGTM

Is this still valid? (yes doing my periodic old issue/PR revisiting)

Closing as stale


Network: Don't generate volatile.bridge.hwaddr in fan mode or allow static hwaddr to be set

The same MAC address on all fan bridge interfaces in the cluster breaks host<->fan comms.

Testsuite passed