MM-42320 - Add callback to PeerConnection close

Summary

Here is some cleanup and an added callback to the peer connection close function, which allows us to wait until the async method is finished before calling whatever we need to call (in our case, InCallManager.stop().
Not sure if we need to bump the version (if we did, it might get confusing, b/c we're far behind the original react-native-webrtc repo)

Ticket Link

https://mattermost.atlassian.net/browse/MM-42320

Chances to merge upstream into the fork?

Chances to merge upstream into the fork?

Not sure, the original fork has been inactive for a while now.
Ideally we'd like to use upstream and avoid all the troubles (plus getting all the new updates for free) as soon as possible, but to do that we need https://github.com/react-native-webrtc/react-native-webrtc/issues/1005 implemented. Maybe it's even something we could contribute at some point but at the moment is a tough ask.


mkdirp hangs when accidentally called with an invalid path on Windows

We ran into this a couple of days ago:
On Windows, we had a temp directory such as
C:\temp
and we had another directory outside temp such as
C:\some\other\directory
We wanted to replicate this directory tree under temp so we concatenated the two paths resulting:
C:\temp\C:\some\other\directory
which is of course an invalid path on Windows -- this problem only happens on Windows because of the drive letters included in the paths.
We called mkdirp with this bad path C:\temp\C:\some\other\directory and mkdirp just hanged in there in an infinite loop... Our callback never got called with an err object.
Is it possible to prevent this hanging by maybe validating the provided path before doing anything else? Or just prevent the hanging in mkdirp any other way?

This issue is still present in v0.5.1 today


Using htmlInfoWindow in version 2.

Hello I have being battling with how to use the htmlInfoWindow , I actually uninstalled version and installed version 2, but I have not being able to get the htmlInfoWindow  to work, I copied the sample code from the Documentation below :
var div = document.getElementById("maplocation");
    var map = plugin.google.maps.Map.getMap(div);
    map.one(plugin.google.maps.event.MAP_READY, function () {
        var htmlInfoWindow = new plugin.google.maps.HtmlInfoWindow();

        var html = [
            'This is Html InfoWindow',
            '
',
            '<button onclick="javascript:alert(\'clicked!\');">click here</button>',
        ].join("");
        htmlInfoWindow.setContent(html);

        map.addMarker({
            position: {lat: 0, lng: 0},
            draggable: true
        }, function (marker) {

            marker.on(plugin.google.maps.event.MARKER_CLICK, function () {
                htmlInfoWindow.open(marker);
            });
            marker.trigger(plugin.google.maps.event.MARKER_CLICK);

        });
    });

but I keep getting the marker without the info window.

please I need help ASAP, this is driving me crazy.
Many Thanks

Could you show me the output of $> cordova plugin list?

com.googlemaps.ios 2.2.0-fixed "Google Maps SDK for iOS"
cordova-plugin-compat 1.1.0 "Compat"
cordova-plugin-dialogs 1.3.3 "Notification"
cordova-plugin-geolocation 2.4.3 "Geolocation"
cordova-plugin-googlemaps 2.0.0-beta2-20170510-1500 "cordova-plugin-googlemaps"
cordova-plugin-whitelist 1.3.2 "Whitelist"
cordova-sqlite-storage 2.0.3 "Cordova sqlite storage plugin"

Ah, the plugin you installed is too old. The v2.0 has been updating frequently.
The latest version of the maps plugin v2.0 is 2.0.0-beta2-20170531-1115.
Here is mine.
$ cordova plugin list
com.googlemaps.ios 2.2.0 "Google Maps SDK for iOS"
cordova-plugin-console 1.0.6 "Console"
cordova-plugin-googlemaps 2.0.0-beta2-20170531-1115 "cordova-plugin-googlemaps"
cordova-plugin-whitelist 1.3.2 "Whitelist"

Please reinstall the plugin. The problem should be gone.

ok Many thanks, let me try that

The usage of HTMLInfoWindow was changed on May/22, but your plugin version is May/10. That's why.
https://github.com/mapsplugin/cordova-plugin-googlemaps-doc/blob/master/v2.0.0/ReleaseNotes/v2.0-beta2/README.md#may222017

please kindly give me the URL for version 2,

Do you mean you want to know how to install the plugin v2?
If so, follow the steps:
$> cordova plugin rm cordova-plugin-googlemaps

$> npm cache clean

$> cordova plugin add https://github.com/mapsplugin/cordova-plugin-googlemaps#multiple_maps \
     --variable API_KEY_FOR_ANDROID="<YOUR KEY>" \
     --variable API_KEY_FOR_IOS="<YOUR KEY>" \
     --nofetch

https://github.com/mapsplugin/cordova-plugin-googlemaps-doc/blob/master/v2.0.0/Installation/README.md

Many thanks, your a soul saver.... I would try it and get back to you.. much regards

followed the instruction and now all I get is a white screen, the map does not even load..

Is there JS errors or error messages?

it was a js error, copied code from https://github.com/mapsplugin/cordova-plugin-googlemaps-doc/blob/master/v2.0.0/ReleaseNotes/v2.0-beta2/README.md#may222017 without defining map variable

Ah, I see.

but am still not able to see the htmlInfoWindow .. any sample code??

https://github.com/mapsplugin/cordova-plugin-googlemaps-doc/blob/master/v2.0.0/class/HtmlInfoWindow/newHtmlInfoWindow/README.md

Also
https://github.com/mapsplugin/v2.0-demo/blob/master/www/HtmlInfoWindow/newHtmlInfoWindow.html

used this : https://github.com/mapsplugin/cordova-plugin-googlemaps-doc/blob/master/v2.0.0/class/HtmlInfoWindow/newHtmlInfoWindow/README.md
but was unable to get the HtmlInfoWindow to be displayed. only  the marker was displayed on the map

Please inspect your app more carefully.
If you doubt me this is plugin's bug, try the demo apk.
The demo apk works perfectly.
https://github.com/mapsplugin/v2.0-demo/blob/master/cordova-googlemaps-v2-demo_16.apk?raw=true

I have inspected my code and discovered I used a canvas instead of a div, I made the change and the htmlinfowindow now displays, however it displays them as raw html codes

If you pass String (typeof yourHTML == "string"), the plugin displays HTML.
Otherwise, the plugin displays as object.
  var html = [
    'This is Html InfoWindow',
    '
',
    '<button onclick="javascript:alert(\'clicked!\');">click here</button>',
  ].join("");
  htmlInfoWindow.setContent(html);

Here is the logic:
      var content = self.get("content");
      if (typeof content === "string") {
          contentBox.style.whiteSpace="nowrap";
          contentBox.innerHTML = content;
      } else {
          if (!content) {
            contentBox.innerText = "";
          } else if (content.nodeType === 1) {
            contentBox.appendChild(content);
          } else {
            contentBox.innerText = content;
          }
      }

https://github.com/mapsplugin/cordova-plugin-googlemaps/blob/d9e40dda01ed6bfed54edb81a6d01422b3211de4/www/HtmlInfoWindow.js#L74-L86

@Mrjaid ping

So sorry for the delay.. have being so so busy... bug have being resolved.. all working fine now,..
many thanks

:+1


Adding files to a new folder

As a User, i want to add files to a new folder, view my folder description and also edit the description

Figma File
https://www.figma.com/file/KG0IhccGcavNxUagRofOsG/HNG-Portfolio?node-id=0%3A1

Slack Username: Darniel

live link: https://companyfiles.zuri.chat/api/v1/files/addFileToFolder
track: BE
Slack userName: Osaze


(project): update 1.4.0 changelog.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.03%. Comparing base (76c4d26) to head (0dfef80).
 Consider uploading reports for the commit f33e15b to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #155      +/-   ##
============================================
+ Coverage     53.80%   54.03%   +0.23%
- Complexity      385      418      +33
============================================
  Files            42       44       +2
  Lines          3390     3727     +337
  Branches        263      303      +40
============================================
+ Hits           1824     2014     +190
- Misses         1380     1500     +120
- Partials        186      213      +27

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Move benchmark to XCCDF version directory

:+1:
LGTM.
In future, we will need to have interfaces and multiple implementations hiding the versioning.

LGTM.
In future, we will need to have interfaces and multiple implementations hiding the versioning.

Make sense.
Guess I will have to fix your permissions.


Rollup Summary validations not being enforced on updates after fflib upgrade

Prior to fflib upgrade, onValidate of RollupSummaries was invoked in onAfterInsert & onAfterUpdate.  After the conversion to fflib, onValidate is only called by default during onAfterInsert which results in validations not being enforced when a rollup is updated.

Ah good spot, kicking myself for missing that one! :+1:

Fixed in v1.23


Update seat-management.mdx

change from 2 months to 1 month minimum. SHIP-9996
Summary

Screenshots (optional)

Documentation checklist

[ ] The documentation style guide has been adhered to.
[ ] If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
[ ] Files which have changed name or location have been allocated redirects.

I didn't see that you had already opened a PR for this! Duplicate of #16462


chore: bdd-spring-1576532710 to 0.0.1

chore: Promote bdd-spring-1576532710 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


WIP Core logic refactor

Very much Work In Progress and not properly tested yet.. do not merge.
Fixes #150
Fixes #179
What this PR solves / how to test:
This PR is a major rewrite of the core logic.. right now there is a lot of duplication in the individual instrumentations around handling configuration, instrumentation of Env and ExecutionContext etc etc.. But because everything was extremely, but not quite the same, it was hard to abstract out.
But now that we have a few different implementations it became clear how to abstract it properly and that is what this PR is. It greatly reduces the surface areas for subtle bugs like Promise not completing to hide.

Any desire to include support for instrumenting Rpc classes? I feel like DOs are very similar when not orchestrated around having a fetch handler, thus themselves having an Rpc interface.
I think the cloudflare types just end up calling these the WorkerEntrypoint interfaces (when not a DO worker); not sure if it's totally introspectable from the perspective of implementing a proxy for each of the public methods - not caught up on all the TS advancements. My approach with current Rpc class based workers is to have public and private methods and public ones are the ones I invoke from other workers.
If instrumentation can't detect them easily, I don't mind if the instrument method took a specific list of methods as an argument.
WorkerEntrypoint classes do take an Env on the constructor, so it would be great if the passed bindings were automatically instrumented.
Just throwing this out as something that I very much desire from this well written library! Happy to help test these changes on my new project.


version mismatch

infinite_scroll_pagination: ^2.3.0
The current Flutter SDK version is 1.21.0-6.0.pre.245.
Because app depends on infinite_scroll_pagination >=2.2.0+1which requires Flutter SDK version >=1.22.0 <2.0.0, version solving failed.

You need to upgrade your Flutter SDK version.
Infinite Scroll Pagination needs at least 1.22.


Access denied when using powershell command Out-File with sudo

PS> cd C:\Program` Files
PS> sudo Write-Output "aaa" | Out-File a.txt
Out-File: Access to the path 'C:\Program Files\a.txt' is denied.

I also tried
sudo 'Write-Output "aaa" | Out-File a.txt' and
sudo Write-Output "aaa" > a.txt and
sudo echo "aaa" > a.txt but still not work.

This is likely by design, in linux you would typically do:
Write-Output "aaa" | sudo Out-File a.txt
However, this isn't working either and will result in an empty file...

Cannot believe this issue still exists in pwsh 7.1, and I haven't found an answer (yet). It seems a basic operation to perform.

Now gsudo is a better solution


Ensure thread device has synced with latest Dataset before sending MLE Announce.

This PR is to ensure thread device(Router or Child) has synced with latest Dataset before sending MLE Announce on its previous channel.
Router will go through the whole attach process after it receives an Announce message with newer Active Timestamp, it gets the new Dataset from Child Id Response message. For Child, there are some cases to be considered:

Child has Parent before the different partitions merge and Parent migrates to the new partition first. (Child sends Child Update and receive response, then sends Data Request and receives Data Response.)
Child has Parent but receive a new Advertisement from another Router with different partition id.
(Child will become detached and migrates to new partition)
Child has no Parent, and go through the whole attach progress again.

Hence, use a timer to check whether or not child has synced with latest Dataset from network periodically. Below is the result of MED_9_2_12 with this PR.
MED_9_2_12.zip

Current coverage is 73.30% (diff: 94.44%)

Merging #845 into master will decrease coverage by 0.08%

@@             master       #845   diff @@
==========================================
  Files           111        110     -1
  Lines         16520      16528     +8
  Methods        2260       2259     -1
  Messages          0          0
  Branches       1984       1986     +2
==========================================
- Hits          12125      12116     -9
- Misses         3720       3734    +14
- Partials        675        678     +3

Powered by Codecov. Last update 87f9cb0...a700bcb


Add custom IMPORT_USER_MODULES to user_config.py

Modules listed in IMPORT_USER_MODULES will be imported before making gym environments, for example add 'pybullet_envs' to enable pybullet environments to be used in command line

@abefetterman , @jachiam You may be also interested in my PR which may be better solution to this problem: https://github.com/openai/spinningup/pull/201


fix: Install 'bzip2' package on RHEL installer

The 'bzip2' utility is required to extract 'bz2' archives.

tested good


Supporting simple user story (2)

This is a meta-issue to keep track of work done to support the second sprint of supporting the basic data science user story.
Please add a link to the relevant issue once it's created in the corresponding repository. Track the fine-grained issues in sprint project.
0. Housekeeping

[x] documentation of development branches -- this includes making new examples using the new CLI, combing through the old docs to determine what should be discarded/updated (#140)
[ ] Travis-ci integration test for the development branch of renga (https://github.com/SwissDataScienceCenter/renga/pull/139)
[ ] add storage to docker-compose (#128)
[x] plan UI work in next sprint (https://github.com/SwissDataScienceCenter/renga-ui/issues/132)
[ ] design API to be used by UI client, CLI, and, perhaps, external users

1. Initiate a project, import a dataset

[ ] Finalize dataset import to work with renga repos (https://github.com/SwissDataScienceCenter/renga-python/issues/99)
[ ] document the ontology for projects, datasets, and CWL steps/workflows

[x] include @context and @type in docs https://github.com/SwissDataScienceCenter/renga-python/pull/143
[ ] https://github.com/SwissDataScienceCenter/renga-ontology/issues/3, see also the data model described in the incubator UI

[x] Create a model object for project in JavaScript
[ ] Support creating a project from the UI

2. Explore the dataset using a notebook (isolated environment)
Look into capturing data artifacts the same way as with renga run
3. Run code on data, recording data provenance for reproducibility

[ ] POC for extending renga run to more flexible environments

[ ] a dockerized version of renga run/rerun
[ ] using python environments in steps rerun on the server (à la repo2docker)

[ ] write user stories as test cases for renga run

4. Push project to a server for sharing

[ ] Finalize storage service

[ ] decouple from graph (https://github.com/SwissDataScienceCenter/renga-storage/issues/44)
[ ] update swagger and doc (https://github.com/SwissDataScienceCenter/renga-storage/issues/50)
[ ] define bucket/backend for LFS (https://github.com/SwissDataScienceCenter/renga-storage/issues/51)

[x] staging environment #130
[ ] Configure gitlab runners on k8s
allow runner to spawn daemonized containers
[ ] POC for using jupyterhub with CI stages for deploying notebooks (@rokroskar)
[x] deploy services using k8s chart on testing.datascience.ch
[ ] Manipulate project access settings in the UI (https://github.com/SwissDataScienceCenter/renga-ui/issues/130)
[ ] Initialize a project in UI (templates? Gitlab-ci, .renga metadata etc.; https://github.com/SwissDataScienceCenter/renga-ui/issues/129)
[ ] renga push/sync (index the provenance information?)

5. Validate results/workflows

[x] Troubleshoot the CI configuration -- related to https://github.com/SwissDataScienceCenter/renga-python/issues/102

6. Initiate discussions (ku) on the work done
Markdown editors

[x] Connect notebooks to live notebook server (https://github.com/SwissDataScienceCenter/renga-ui/issues/114)
Dataset view, data preview

continues as https://github.com/SwissDataScienceCenter/renga/issues/146


[Build] Update rest server and webportal Dockerfile

No lockfile found when building rest server and webportal images, update Dockerfiles.

Coverage remained the same at 53.345% when pulling 7cb6c1f3c79e77375781947d17746941644bd4a7 on xiongyf/rest-server-dockerfile into 4c8dfa18df65897031d28c4e3bbe3e1d7f31bde1 on master.


feature request: commit offset back to kafka broker

Is your feature request related to a problem? Please describe.
as title,
user may want to use kafka metrics for monitoring, we need to commit back to the broker.
https://www.notion.so/risingwave-labs/Kafka-Source-commit-offset-50b1dede933f4bbcb25a4b4d677a90c3
Describe the solution you'd like
No response
Describe alternatives you've considered
No response
Additional context
No response

close as completed in #12223


RFP - WxMaxima

There is already formulas for maxima and gnuplot  but there is not for WxMaxima yet.

Download page - https://wxmaxima-developers.github.io/wxmaxima/download.html

According to the latest download page, wxMaxima is included in Maxima.
https://sourceforge.net/projects/maxima/files/Maxima-Windows/5.43.0-Windows/

@mkevenaar so basically choco install maxima will install WxMaxim as well? That I didn't know. 🤔

@Foadsf based on the release notes of the application, yes. Could you verify?

@mkevenaar I'm not able to install due to :
Attempt to get headers for https://sourceforge.net/projects/maxima/files/Maxima-Windows/5.43.0-Windows/maxima-clisp-sbcl-5.43.0-win64.exe/download failed.
  The remote file either doesn't exist, is unauthorized, or is forbidden for url 'https://sourceforge.net/projects/maxima/files/Maxima-Windows/5.43.0-Windows/maxima-clisp-sbcl-5.43.0-win64.exe/download'. Exception calling "GetResponse" with "0" argument(s): "The operation has timed out"
Downloading maxima 64 bit
  from 'https://sourceforge.net/projects/maxima/files/Maxima-Windows/5.43.0-Windows/maxima-clisp-sbcl-5.43.0-win64.exe/download'
ERROR: The remote file either doesn't exist, is unauthorized, or is forbidden for url 'https://sourceforge.net/projects/maxima/files/Maxima-Windows/5.43.0-Windows/maxima-clisp-sbcl-5.43.0-win64.exe/download'. Exception calling "GetResponse" with "0" argument(s): "The operation has timed out"
This package is likely not broken for licensed users - see https://chocolatey.org/docs/features-private-cdn.
The install of maxima was NOT successful.
Error while running 'C:\ProgramData\chocolatey\lib\maxima\tools\chocolateyInstall.ps1'.
 See log for details.

Chocolatey installed 0/1 packages. 1 packages failed.
 See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).

Failures
 - maxima (exited 404) - Error while running 'C:\ProgramData\chocolatey\lib\maxima\tools\chocolateyInstall.ps1'.
 See log for details.

@mkevenaar I confirm that it installs WxMaxima and seem to work properly. Maybe it could be a good idea to add WxMaxima to search query/info of the package, as well as the Chocolatey homepage. Thanks for your kind support.

@Foadsf I have added the wxmaxima tag to the maxima package, however it won't show on the package page until the next version is released.

@Foadsf Do you agree that we can close this issue?

@mkevenaar @AdmiringWorm thank you guys. this issue AFIK was due to my lack of knowledge of the new updates of the Maxima project and it can be closed.


Ignore exceptions when closing video capture

When CaptureDevice::Cleanup() is called, it attempts to stop the local
video recording calling IMediaCapture::StopRecordAsync(). Sometimes
this fails with MF_E_SAMPLEALLOCATOR_EMPTY, often when the system load
is high and the recording does not stop fast enough while frames are
still produced, but not consumed.
Because the code uses IAsyncAction::get() to do a blocking call and
wait for StopRecordAsync() to return, and because get() has will
throw an exception on error, the result is that some exception may be
thrown although there is fundamentally no error and the recording is
stopped as expected.
This change ignores all exceptions thrown by get() during the call to
StopRecordAsync() to prevent the application from crashing with an
uncaught exception.

This is likely the cause of microsoft/MixedReality-WebRTC#134. As shown on the callstack on that issue, the call to get() after StopRecordAsync() is throwing an exception due to StopRecordAsync() returning an error.


Bluetooth: Host: Modularize bt_le_adv_resume

Now that we have conn_cb.recycled, we have all we need decouple the legacy adv restart feature from the core host.

[ ] Move out the following code into its own function. Register this new function as a recycled handler.
https://github.com/zephyrproject-rtos/zephyr/blob/a0669217452fcc726a1bb92301c9d9e19ca25cdc/subsys/bluetooth/host/conn.c#L1371-L1374
[ ] Make bt_le_adv_resume into a work. Post it to bt_long_wq.
[ ] Make a new wrapper for adv start that implements restarts. Behind CONFIG_BT_ADV_RESTARTER.
[ ] Add a LEGACY_ADV_RESUME default=y to control automatic use of wrapper. The selects DEPRECATED. The app should use wrapper directly.

Superseded by: https://github.com/zephyrproject-rtos/zephyr/issues/72567


Support Request: Node upgraded but plugin doesn't detect

Describe Your Problem
Per Homebridge's instructions, I upgraded Node on my Mac but after restart, the Switchbot plugin fails to see the new version Homebridge is using.
Relevant log output
// Output from upgrading

$ node --version
v18.14.0
$ sudo hb-service update-node
Password:
ℹ Updating Node.js from v18.14.0 to v18.15.0...
ℹ Target: /usr/local
✔ Download complete.
✔ Cleaned up npm at at /usr/local/lib/node_modules/npm
✔ Installed Node.js v18.15.0
rebuilt dependencies successfully
npm notice
npm notice New minor version of npm available! 9.5.0 -> 9.6.2
npm notice Changelog: https://github.com/npm/cli/releases/tag/v9.6.2
npm notice Run npm install -g<EMAIL_ADDRESS>to update!
npm notice
✔ Rebuilt homebridge-config-ui-x for Node.js v18.15.0.
rebuilt dependencies successfully
✔ Rebuilt plugins in /usr/local/lib/node_modules for Node.js v18.15.0.
ℹ Stopping Homebridge Service...
✔ Homebridge Stopped
ℹ Starting Homebridge Service...
✔ Homebridge Started
$ sudo hb-service update-node
Password:
ℹ Node.js v18.15.0 already up-to-date.
$ node -v
v18.15.0

// Log after Homebridge restarts

[3/19/2023, 3:06:03 PM] The plugin "homebridge-switchbot" requires Node.js version of ^14.21.2 || ^16.19.0 || ^18.14.0 which does not satisfy the current Node.js version of v18.9.0. You may need to upgrade your installation of Node.js - see https://homebridge.io/w/JTKEF

Config for homebridge-switchbot
{
    "name": "SwitchBot",
    "credentials": {
        "token": "",
        "secret": "",
        "notice": "Keep your token a secret!"
    },
    "options": {
        "devices": [
            {
                "deviceId": "",
                "configDeviceName": "Thermo/hygrometer",
                "configDeviceType": "MeterPlus",
                "logging": "standard"
            },
            {
                "deviceId": "",
                "configDeviceName": "Mood lights",
                "configDeviceType": "Strip Light",
                "logging": "standard"
            },
            {
                "deviceId": "",
                "configDeviceName": "Extractor fan",
                "configDeviceType": "Bot",
                "bot": {
                    "mode": "switch",
                    "deviceType": "fan",
                    "doublePress": 1
                },
                "logging": "standard"
            }
        ],
        "logging": "standard"
    },
    "platform": "SwitchBot"
}

Screenshots
No response
Device & Model
N/A
Node.js Version
18.15.0
NPM Version
9.5.0
Homebridge Version
1.6.0
Homebridge SwitchBot Plugin Version
2.5.2
Homebridge Config UI X Plugin Version
4.50.2
Operating System
macOS

Please try v2.6.0

That resolved the issue, thank you.


Binding lua functions fails

Regular key maps work, but Lua Function Keymaps do not.
This is my binds module:
local nest = require('nest')

nest.applyKeymaps {
    { 'gD', lua vim.lsp.buf.declaration }
}

Running it produces:
E5113: Error while calling lua chunk: vim.lua:64: /home/miki/.config/nvim/lua/miki/binds.lua:4: '}' expected near 'vim'

I think you have a syntax problem in that snippet:

{ 'gD', lua vim.lsp.buf.declaration }

lua vim.lsp.buf.declaration is not a valid lua expression. I think you meant to do
{ 'gD', vim.lsp.buf.declaration }

instead

I will close this issue as the problem is a syntax problem rather than a problem in nest - if you want to add onto it, feel free to add a comment though :-)

Thank you for your fast response!
Now that you say it, I can see it's worng. This is how it is written in your readme, however.

Oh thanks! I just fixed it :-)


Add Jared Barrow

@SwordOfLonginus, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share  to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.

@Roshanjossey Well I felt happy but also a bit intimidated not by the tutorial itself but how to contribute things through the github desktop. Overall it was pretty neat also noting when things get merged it like a permission for the O.K so it gets merged into the master git, so it like a process you have to go through instead of just submitting it.

But yeah pretty neat little exprience.

@SwordOfLonginus, I’d urge you to continue contributing to other open source projects.
We also have a slack team to help/mentor people trying to contribute to open source projects.
You can join the team by going to https://firstcontributions.herokuapp.com

@Roshanjossey Will do


Line Chart w/multiple data sets - tooltip does not align with cursor.

When more than 1 data set exists (and thus multiple lines), the tooltip that is rendered on the chart canvas does not align with the user's mouse / cursor. It is typically a 2 points to the left of where the user would like the tooltip to be. See attached image for more details.
Please not that the tooltip displays correctly when there is only 1 data set (or the other data sets have been de-selected).
Thank you!

Fixed in v3.0.0 release


Update RFC with default paths for macOS

Ref suggestion https://github.com/rust-lang/rfcs/pull/1615#issuecomment-803561712

Caches change is good.
Some people have expressed they like ~/.cargo for config. If this point is contentious, then it could stay as ~/.cargo. While Library/Application Support is technically correct, it's not as important as caches dir, because config files are small, and there's no harm in them being indexed and backed up like there is with .caches.

I'm not interested in spending time on this RFC anymore. The change has been requested in the opposite direction already (your paths are the ones I had originally, I think).
I don't know how to give you access to a branch, perhaps you could open a new RFC? I can close my old one and link to the new one instead if you want.


[0.8.1] Spooler - Queue estimate is twice actual estimate

This screen shot shows the exact same job queued twice. As you can see the second job has twice the estimated time of the first job...

The estimate is updated during execution and takes the amount of things done and the remaining tasks into account

No - they should both say 11:07 as an estimated time - the Estimate for a burn job doesn't change until the item run time reaches the item estimate, and then the item estimate increases in step with the item run time and the total estimate increases with that.
This is a bug.

Fixed

So - it was a bug then?

It certainly was, thanks for reporting


scipy.fftpack.fftn unexpected handling of axes

Tested on scipy verison 0.16.0
with
x = np.random.randn(4, 3, 4096)

the calls
scipy.fftpack.fftn(x, axes=(0, 2)).shape
scipy.fftpack.fftn(x, axes=(-3, -1)).shape
scipy.fftpack.fftn(x, axes=(-1, -3)).shape
scipy.fftpack.fftn(x, axes=(2, 0)).shape

all return (4, 3, 4096), but
scipy.fftpack.fftn(x, axes=(0, -1)).shape

returns (4096, 3, 4096).

I can reproduce this. Weird. Looks like something needs fixing.

Since the implementation is written in fortran unless I'm mistaken, I'm afraid I won't be of much help fixing it. Based on the observed behaviour however, I would venture a guess that it's related to some sorting behaviour.

The problem is here
    id = numpy.argsort(axes)
    axes = [axes[i] for i in id]
    s = [s[i] for i in id]

For this to work right axes have to all positive.  Adding
    a = numpy.array(axes, numpy.intc)
    axes = numpy.where(a < 0, a+x.ndim, a)

before the line starting id = fixes this for me.  Probably worth doing this (or the equivalent) much earlier as well as providing a nicer error message when an out of bounds axes is provided.
(Feel free to take this, my time is very limited ATM.)

Fixed by @sjpet


problem installing ruyaml in GH actions

Unable to find installation candidates for ruamel-yaml (0.18.4)

at ~/.local/venv/lib/python3.9/site-packages/poetry/installation/chooser.py:73 in choose_for
69│
70│             links.append(link)
71│
72│         if not links:
→  73│             raise RuntimeError(f"Unable to find installation candidates for {package}")
74│
75│         # Get the best link
76│         chosen = max(links, key=lambda link: self._sort_key(package, link))

https://pypi.org/project/ruamel.yaml/#history

I think 0.18.4 was yanked. 0.18.3 and 0.18.5 are still on PyPI


jmol: 14.31.17 -> 14.31.18

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/jmol/versions.
meta.description for jmol is: "A Java 3D viewer for chemical structures"
meta.homepage for jmol is: "https://sourceforge.net/projects/jmol"
meta.changelog for jmol is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 14.31.18 with grep in /nix/store/xi26cl3g6fa94i2l5kml270yywlri46j-jmol-14.31.18

directory tree listing: https://gist.github.com/5ac332d6281dfa4442cbef144259eb23

du listing: https://gist.github.com/7705144de700adb8ef0e014ddca5b348

Rebuild report (if merged into master) (click to expand)

6 total rebuild path(s)

3 package rebuild(s)

3 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
jmol
sage
sageWithDoc

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/xi26cl3g6fa94i2l5kml270yywlri46j-jmol-14.31.18 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A jmol https://github.com/r-ryantm/nixpkgs/archive/e5f757954a2602cd145c6fc158eeae46718187bb.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/xi26cl3g6fa94i2l5kml270yywlri46j-jmol-14.31.18
ls -la /nix/store/xi26cl3g6fa94i2l5kml270yywlri46j-jmol-14.31.18/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

1 package built:

jmol

Maintainer pings
cc @mounium @timokau @omasanori @7c6f434c for testing.

Result of nixpkgs-review pr 105212 run on x86_64-darwin 1

1 package built:

jmol


#186 feat(container): bind the enter key when renaming container

Simple change just added a form and called renameContainer method
Close #186

Thanks @paulkling


[Move Prover] Incomplete display of havocked variables

Problem
When a struct is havocked, Prover's error trace does not say that the struct was havocked.
How to reproduce
module 0x42::loop_inv {
    use std::vector;

    struct R has key {
        v1: vector<u64>,
        v2: vector<u64>,
    }

    spec fun spec_all_zeros(v: vector<u64>): bool {
        forall i in 0..len(v): v[i] == 0
    }

   fun f() acquires R {
        let r = borrow_global_mut<R>(@0x42);
        spec {
            assume spec_all_zeros(r.v1);
            assume spec_all_zeros(r.v2);
        };

    let i = 0;
        while (i < 5) {
            vector::push_back(&mut r.v1, 0);
            i = i + 1;
        };

         spec {
            assert spec_all_zeros(r.v1);
            assert spec_all_zeros(r.v2);
        };
   }

Prover produces the following error:
RUST_BACKTRACE=1 move prove -t loop_inv.move
[INFO] preparing module 0x42::loop_inv
[INFO] transforming bytecode
[INFO] generating verification conditions
[INFO] 1 verification conditions
[INFO] running solver
[INFO] 0.031s build, 0.005s trafo, 0.005s gen, 1.479s verify, total 1.521s
error: unknown assertion failed
   ┌─ ./sources/loop_inv.move:30:13
   │
30 │             assert spec_all_zeros(r.v1);
   │             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   │
   =     at ./sources/loop_inv.move:14: f
   =     at ./sources/loop_inv.move:15: f
   =         r =
   =           &loop_inv.R{
   =             v1 = vector{(size): 24464, default: 5706},
   =             v2 = vector{(size): 26962, default: 5706}}
   =     at ./sources/loop_inv.move:17: f
   =     at ./sources/loop_inv.move:18: f
   =     at ./sources/loop_inv.move:21: f
   =         i = 0
   =     at ./sources/loop_inv.move:23: f
   =     enter loop, variable(s) i havocked and reassigned      <---  missing the info that `r` is also havocked.
   =         i = 18472
   =     at ./sources/loop_inv.move:22: f
   =     at ./sources/loop_inv.move:30: f
...
...
...

@jyao15 is looking at this issue.

The problem lies in the is_temporary function in model.rs. The function tells whether a bytecode variable is temporary (i.e., compiler-introduced instead of user-defined). Its current implementation simply checks whether the bytecode variable ID is greater than the number of user-defined variables. This is correct in stackless bytecode, but may not be correct after a sequence of bytecode transformations.
In this example, in the stackless bytecode, bytecode variable $t0 corresponds to user-defined variable i, and bytecode variable $t1 corresponds to user-defined variable r. The number of user-defined variables is 2, so both $t0 and $t1 are correctly recognized as non-temporary. But after 10 transformation passes, at the time we do loop analysis, $t1 is no longer used in the bytecode. Instead, $t3 corresponds to r, but it is recognized as temporary, so r is missing in the error trace.
I do not know how this can be easily solved.

This one maybe hard to fix and requires tracking of variables derived from user defined variables. For example, there can be two temporary variables derived from the same user variable. Lower priority for now.
One option is to have a flag that temporary variables are also displayed.


Docket Image issue

docker build -t mymicroservice .
error during connect: This error may indicate that the docker daemon is not running.: Post "http://%2F%2F.%2Fpipe%2Fdocker_engine/v1.24/build?buildargs=%7B%7D&cachefrom=%5B%5D&cgroupparent=&cpuperiod=0&cpuquota=0&cpusetcpus=&cpusetmems=&cpushares=0&dockerfile=Dockerfile&labels=%7B%7D&memory=0&memswap=0&networkmode=default&rm=1&shmsize=0&t=mymicroservice&target=&ulimits=null&version=1": open //./pipe/docker_engine: The system cannot find the file specified.

This is an issue with docker itself and not .net. Please make sure docker is running and that you have restarted your terminal if you just installed it.


Import "tensorflow" could not be resolvedPylancereportMissingImports

I have tried uninstalling all extensions and imports but still gets this error

see https://github.com/microsoft/pylance-release/blob/main/TROUBLESHOOTING.md#filing-an-issue for how to grab the logs.
are you using open folder?
selected your python interpreter with tensorflow installed?

Closing old issue. If this is still a problem, please reopen with the information requested. thanks


OpenRefine reconciliation service not working - mutliple vs single queries

I have been using OpenRefine 2.6 Beta 1 w/o problems since its release, and later, with the reconciliation service at:
http://reconcile.freebaseapps.com/reconcile
However, in the past fee days, I have not been able to use it all. If I go to the URL:
http://reconcile.freebaseapps.com/
and type the multiple query:
{
"query": "Ford",
"type": "/people/person",
"properties": [
{
"pid": "/people/person/place_of_birth",
"v": "Detroit"
}
]
}
I obtain:
{
"result": [
{
"id": "/m/0j8pb6y",
"name": "Ford",
"type": [
{
"id": "/people/person",
"name": "Person"
},
{
"id": "/common/topic",
"name": "Topic"
},
{
"id": "/geography/mountaineer",
"name": "Mountaineer"
}
],
"notable": [],
"score": 1.1546246,
"match": false
},
{
"id": "/m/01vd3gv",
"name": "Ford",
"type": [
{
"id": "/common/topic",
"name": "Topic"
},
{
"id": "/music/artist",
"name": "Musical Artist"
}
],
"notable": [],
"score": 1.0330245999999998,
"match": false
},
{
"id": "/m/0cmdhzt",
"name": "James Meredith",
"type": [
{
"id": "/common/topic",
"name": "Topic"
},
{
"id": "/people/person",
"name": "Person"
},
{
"id": "/military/military_person",
"name": "Military Person"
},
{
"id": "/people/deceased_person",
"name": "Deceased Person"
}
],
"notable": [],
"score": 0.0681692,
"match": false
}
],
"duration": 369
}
But if I try a simple query:
{
"query": "Ford"
}
I get:
Status: error Error:undefined
Any insights into what's happening with the reconciliation service? Is there any other service I could use to replace freebaseapps.com?

I tried this this in "Queries Parameter" insted of "Query Parameter" at http://reconcile.freebaseapps.com/, and it works. Still having problems with reconciling with OpenRefine.
{
"q0": {
"query": "Ford"
}
}

That reconcile service is no longer supported.  It is deprecated.
See https://developers.google.com/freebase/v1/reconciliation-overview?hl=en

Tad, I am confused: Is the reconcile within OpenRefine working? I am referring to the reconciliation service I use in Open Refine http://reconcile.freebaseapps.com/reconcile. Thanks

this service:  http://reconcile.freebaseapps.com/
Is in a state of "no longer being actively being maintained".  The original maintainer was Andi Vajda who can be reached at email<EMAIL_ADDRESS>You can ask him directly.  That service is not run by the OpenRefine team, but was run by Andi when he was with Freebase/Google and it is his app and indexing service that you are having problems this.  Freebase/Google have already said that there are no guarantees of any service availability in the future after the deprecation time, which was last summer in June 2015.
OpenRefine does provide a Reconciliation interface for any kind of reconciling service...and there are a few of those services still around on the internet... see a list here: https://github.com/OpenRefine/OpenRefine/wiki/Reconcilable-Data-Sources


position: losing onclick after opening a second time

Instructions

fill in title: format of ": short description"
choose: "bug" or "enhancement request" below, fill it in, and delete other section

Bug
When using the <ActionMenu /> component with one of the position React components,
the second time you click on an <ActionMenu.Item /> it no longer calls the function passed into onClick
Expected behavior
To be able to open / close the <ActionMenu/>, while being rendered within a position component, while keeping the onClick functionality working.
Actual behavior
The onClick function only works once.
Screenshots/casts are helpful
Link to your source code in your application repo
https://codesandbox.io/s/codesandboxer-example-forked-sqm7h?file=/example.tsx
Steps to repro
(example in the sandbox provided above)

Open the <ActionMenu /> by clicking the <button /> with the text "click me".
Click the <ActionMenu.Item /> with the text "wat"
Check the console to see that it logged the text "clicked"
repeat steps 1 - 3 and see that it doesn't log after the first time you click the <ActionMenu.Item />

Debugging tips
I was able to make the <ActionMenu/> work while not wrapped in a position component.
I was also able to make the <ActionMenu /> work while it was wrapped in a position component, but without an onClose function being passed to the <ActionMenu />
Related packages

@pluralsight/ps-design-system-position: "^6.0.2",
@pluralsight/ps-design-system-actionmenu: "16.1.3",

Environment

OS - Linux Kernel 5.10.7
Browser version - Firefox 84.0.2 (64-bit)

double check with @AuggieH and this is no longer an issue. most likely this was fixed in https://github.com/pluralsight/design-system/pull/1611


[Event Request] Page 344 Navigate - FindSalesInvoiceHeader

Please add an event OnFindSalesInvoiceHeaderOnAfterSetFilter to procedure FindSalesInvoiceHeader in page 344 Navigate
    local procedure FindSalesInvoiceHeader()
    begin
        if SalesInvHeader.ReadPermission() then begin
            SalesInvHeader.Reset();
            SalesInvHeader.SetFilter("No.", DocNoFilter);
            SalesInvHeader.SetFilter("Posting Date", PostingDateFilter);
            OnFindSalesInvoiceHeaderOnAfterSetFilter(SalesInvHeader);  // <-- NEW EVENT
            InsertIntoDocEntry(Rec, DATABASE::"Sales Invoice Header", PostedSalesInvoiceTxt, SalesInvHeader.Count);
        end;
    end;

    [IntegrationEvent(false, false)]
    local procedure OnFindSalesInvoiceHeaderOnAfterSetFilter(var SalesInvHeader: Record "Sales Invoice Header")
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Exit function required: trap or similar.

Need a clean-up/exit function, in case an error is found and the script terminates early.
Different operations may be needed in depending on the program's execution point.
See: trap command bash.

Done. Using commands:
set -e
trap cleanup EXIT SIGHUP SIGINT SIGTERM
function cleanup {...}
Using checkpoints for knowing which cleanup operations to perform.


Incorrect terminology in TypeScript to JavaScript

In the TYPESCRIPT TO JAVASCRIPT documentation, it's using code like:
export class HeroComponent {
  title = 'Hero Detail';
  getName() {return 'Windstorm'; }
}

While calling that ES6 JavaScript with decorators.
But the fact is title = 'Hero Detail'; is neither ES6 nor Decorators, but another separate proposal at stage 2 (https://github.com/tc39/proposals => Public Class Fields), it's not correct at any sense.
Besides, Decorator proposal (http://tc39.github.io/proposal-decorators/#sec-syntax) does not dependent on nor cover the class property proposal. (Actually the so-called "property decorator" can only apply to methods)
How to rectify it?

Changing the wording ES6 JavaScript with decorators to ES6 JavaScript with decorators and class properties, but it seems to long;
Just calling that ES next, since both Class & Property Decorator are stage 2 proposals;
Do not use class property syntax in code of ES6 JavaScript with decorators version.

What you say is correct out of context, but if we unify all the different context, it makes sense.
We show 1 example, step by step in 4 different "languages". The ES6 + decorators will eventually show an example of ES6 + decorators. That doesn't mean that the example you are giving in here contains decorators. It will eventually contain decorators but not yet in that step.
We can't change the headers to specify "what you see in the example" because that will confuse the users that are going step by step.
About the properties, not much idea there. WDYT @filipesilva ?

It's completely true that the public class fields are a different proposal. But as far as decorators are concerned, class property decorators still need class fields (via the angular2 babel preset).
So while not completely descriptive, I still thinking that just saying that we're trying to have as much decorator support as possible (and using whatever presets get us there) is better than being overly specific about everything that goes into that.
There's also a simplistic progression described that highlights when the class fields go away:

When translating from TypeScript to ES6-with-decorators, remove class property access modifiers such as public and private. Remove most of the type declarations, such as :string and :boolean but keep the constructor parameter types which are used for dependency injection.
From ES6-with-decorators to plain ES6, remove all decorators and the remaining types. You must declare properties in the class constructor (this.title = '...') rather than in the body of the class.


altInput doesnt work on IE

Reproduction Link
https://jsfiddle.net/fzcwg5ey/
Your Environment

flatpickr version used: 4.1.4
Browser name and version: IE11
OS and version: Windows 10

Hello,
Can't repro this.
What exactly isn't working?

Hi, strange enough it shows the date now. But the Error stays the same:

Sorry, I close the issue. It had something to do with the wrong ´dateFormat´.

@chmln Can we reopen this issue?
Reproduction link
The error occur when we set altInput to true, and we have placeholder on input tag
IE 11 will have silent error without open developer tool (console.warn)
Hope this help :)

I am also seeing this with IE11.


Spliting BeanManager for CDI Lite

We should create a new BM interface containing methods supported by lite only.
The current BM would be accessible by extending this lighter BM and add the missing methods for Full.

I have sent a draft of what it could look like. I suppose we'll discuss it in the next meeting (23rd March) and OFC any feedback on the PR or here is welcome as well.

Solved via https://github.com/eclipse-ee4j/cdi/pull/471.
We can adjust it further if needed but we want something in to be able to cut first Alpha releases.


ci: add visual regressions bases on reg-viz

For now it runs well locally, but need to run in docker on CI, otherwise screenshots have differences 🤦

And it's alive now! What's left is to add docker layer caching and proper artifact archival, and this is read for prime time


Reply should contain the original payload from the triggering SubMsg

Motivation
We want to send a ReplyAlways SubMsg. If and only if that message fails, we want to send a different message with the same context.
The first message has the payload ExecuteMsg::TryThis{ important_context: Context }.
If and only if that message fails, then we want to retry with an alternative ExecuteMsg::TryThisInstead{ same_context: Context }.
Currently there is no way to accomplish this as far as I can tell. If TryThis fails, then the context in which it was called is no longer around in the reply. We could try a hack and store the context to storage before we send either message, but that only works if we are sending one instance of TryThis + maybe TryThisInstead . If we are sending multiple instances then that isn't possible.

Agreed. I think there should be a generic data field (maybe with a better name) that allows any custom data to be communicated from the origin of the submessage to the reply.

but that only works if we are sending one instance of TryThis + maybe TryThisInstead . If we are sending multiple instances then that isn't possible.

Can't you have a Map from submessage ID -> Context to achieve that?

Agreed. I think there should be a generic data field (maybe with a better name) that allows any custom data to be communicated from the origin of the submessage to the reply.

but that only works if we are sending one instance of TryThis + maybe TryThisInstead . If we are sending multiple instances then that isn't possible.

Can't you have a Map from submessage ID -> Context to achieve that?

In my particular case I’m already using the submsg id to represent the variant of the original calling message.
I think perhaps the best way to solve this problem is the sub message id should just be changed to sub msg data sort of like you were suggesting. I see no reason to keep both fields around.

I see no reason to keep both fields around.

The advantage of having an id plus a data field is that you can better separate between an ID that describes the high level operations (as in which of those 5 places in the contract emitted the submessage) and a free form payload that you send around and can have a completely different format depending on the ID. For backwards compatibility an addition is also much more straight forward.
I think such a feature can avoid a lot of

write to store
read
delete
flows for cases in which you only need temporary data to be copied from original execution to the reply call.

Backwards compatibility is the strongest point for keeping it around I think! But yes having a data field would absolutely be incredibly useful.

I think at this point it's just a matter of giving the field the right name. What about memo ;)
Is Binary fine? Or do you have a different type in mind?

Yeah I think Binary is the correct choice given that it's already a standard.I actually prefer data as the field name haha.

The issue with "data" is that we have data in SubMsgResponse already which is the data field coming from the Cosmos SDK's message execution. We need something different to avoid this very likely confusion.

Then I would go with msg or payload. Probably msg

I think we can go with payload which so far has no overlap. I think it's important to keep it general since other contract developers might want to pass over some completely different data than a message.

Is 1 KiB per SubMsg a good limit to avoid abuse and still serve the majority of use cases? 1 KiB in JSON looks like this

{"payload":"1UotRfFGhehoA1qQcexm3+d4vf7nDlBGD/XqZcTlVxXSQFIMeqnfOLpjL231dwcTJCoR08jMIhvVp0TjfcHqHGTrylAmnLnZ6n5ojUFb5Gfc3fcAuf9BXIEEsu2LOjgx4K/+S+oplBZ5ffIxwtbocXuIz9C9eJq50Wz2gfwSQ7vytJFNp9C/WrF0+0Po3SsarjOh1w5u8pQU0+tfVYiDakP/ICI0bpTCGvOpCpizMAL77XNnYaGkdg9VWIGwXUTYuMJHqYZeM1vzTriH9P3eojjo2vgYn3wqeHVtAp8ey93Yu2/w0D+wHfHJT5Gz4g0b5XArINKZ30meFFhr3Hx3B5kT4OG2bsVykDDJNBZ3G5c05l9SAHIX6wF5JpRKNLZjdvKMlqFotP9cqJX/Eajjy39YjvvqfXRb0bn+cI+5z3MOwxNZhopd6USQ4TulwTM7+ns/gR3pPbRAzuKrEAITPiIGELg1iDQRiOh7eVE+tHDy7PfLUTPKIh3Z+Gkj3m5vQZcmgvjWykT+Yqpgct8EI/C4dG1k5lZ/89zGMr4tlERdti6XQDfqaWMdLy315N+GLNtm6k935uvHnJq+2hqTeVcbeCPfU3u3wuNR4d9k+wp2PDVMZZ9FTjqCfcrCVswhz/dK3NQSrDwLw2tR0yqRUBwOYnwoG8I3BJN61DePjP73VfSxwOZqHSunk1PybDJUNT4AFx5fX6TWMQb4QHX/6FNlN1m1STEiNg7YRGPFtYmSDfOEaEYvo/I/D1RO1CPzoZ/DHHCLpmTddW6cqThZ45nXN8Q/ekYLcbUamWgpRz7ouEy9632F38t6N4+wz/Xy19lLDiUAtHZlDOTX7gMqHhm/RXrKvS1kdS2UjVGQ3cpvrwFsXnhUqGwlYcPa9IEz4xfRJgo572pKwkYJiun90D+sv92+7uGbYYLzrrKMM7TgvuPMIJ3MuEaoPNSzgLb0WzEMEKAT065n7sgXH/VdSJIDuQQkQiPYkh8Gn9P3luCqL3Z6vgXxbEsAawGrwy8K8h6peAMM9p9bb9TC41PTPPGLfzw+efUBpen/r2vyplBVY2bhkmn4bocwo2qTdE8oZHsk+/aOl+5x13ab1tTv5vWvXrKKT1RiiUj5dE03gh/T9fGykYdG81oSSIrqbgpv993VOOnR6H/cWHiRN3flT3ScTq8Si9nY+SYmevaM+GjBVCfxmls/G6TfBAaRsqV4T6iarULMeWW8MF/cFy4ZGphqBX8FE0o4JivQfhuH3/GIBs5rzItvy+z7zRGQsw79lM9XoFS5Czd9kIEIvtZSOMpYC0rPmFEVkCwq42Vcpsrdf/SYXsZngiZIW8lR4+qCCEmF/KJA2CrDIBs1D4hhFA=="}

We could leave it up to deserialization gas alone but it probably helps contract devs to know how much data they can assume to work.

1KiB seems a touch small to me. I think there would be many valid use cases that would exceed that. What are the limits on other messages? Do execute messages have a limit for example?
As a user I would probably expect never to run into a limit here. What abuse do imagine is possible if we we're to increase this limit to something like 10KiB?

There is a global read limit on the entire contract output (unparsed) of 64 MiB. This is then further limited by the JSON deserializer gas cost in wasmvm which should kick in much earlier (deault is 1 gas/byte).
Now I'm not conviced if a limit is desirable at all. I was thinking that predictable behaviour on all systems is better than whatever gas meter allows, which can change over time. But I also don't see how a very large field could harm the system.

I think we can just add a generous limit of 128 KiB and leave everything else to the gas meter. This is the same max amount you can write in a database entry with CosmWasm. This should avoid resource abuse attempts that might disrupt the block execution.

Could you check the PR in #2008?


update readme to include resource file install

update readme to include resource file install

@mohamedsharaf this seems like something the plugin should be handling.  Please provide more details as to why you needed to add this to your app config.

look at this other pull request i also removed it from plugin it conflicts
GoogleService-Info.plist this will cause error when u have it already add in config.xml
and remove platform ios and re add it u will get error
https://github.com/arnesson/cordova-plugin-firebase/pull/691

i think u missed what i did in the request https://github.com/arnesson/cordova-plugin-firebase/pull/691
i removed the file merger from resources and made it in config.xml so i added to readme
i removed because it conflicts with other plugin if file already exist in the resources your plugin will not install and through output error
to re make the error
create new cordova project add the resource file GoogleService-Info.plist to config.xml and in folder proejct
then add new platform
cordova platform add ios
cordova plugin add cordova-plugin-firebase
you will see plugin will not install file already exist

Do you have a specific plugin that conflicts?  The example you provided does not install another plugin and therefore there is no need to add the file to config.xml.

i made test rep
https://github.com/mohamedsharaf/cordova-plugin-firebase-test
run
npm install
cordova platform add ios
cordova plugin add cordova-plugin-firebase
Error during processing of action! Attempting to revert...
Failed to install 'cordova-plugin-firebase': CordovaError: Uh oh!
File already exists at destination "/Users/mohamed/data/test/test/platforms/ios/HelloCordova/Resources/GoogleService-Info.plist" for resource file specified by plugin cordova-plugin-firebase in iOS platform
    at install (/Users/mohamed/data/test/test/platforms/ios/cordova/lib/plugman/pluginHandlers.js:64:23)
    at ActionStack.process (/Users/mohamed/data/test/test/platforms/ios/cordova/node_modules/cordova-common/src/ActionStack.js:56:25)
    at PluginManager.doOperation (/Users/mohamed/data/test/test/platforms/ios/cordova/node_modules/cordova-common/src/PluginManager.js:114:20)
    at PluginManager.addPlugin (/Users/mohamed/data/test/test/platforms/ios/cordova/node_modules/cordova-common/src/PluginManager.js:144:17)
    at Api.addPlugin (/Users/mohamed/data/test/test/platforms/ios/cordova/Api.js:234:10)
    at handleInstall (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/install.js:594:10)
    at /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/install.js:357:28
    at _fulfilled (/usr/local/lib/node_modules/cordova/node_modules/q/q.js:787:54)
    at self.promiseDispatch.done (/usr/local/lib/node_modules/cordova/node_modules/q/q.js:816:30)
    at Promise.promise.promiseDispatch (/usr/local/lib/node_modules/cordova/node_modules/q/q.js:749:13)
Error: Uh oh!
File already exists at destination "/Users/mohamed/data/test/test/platforms/ios/HelloCordova/Resources/GoogleService-Info.plist" for resource file specified by plugin cordova-plugin-firebase in iOS platform

Remove the resource-file lines from config.xml and the build is fixed.  I still haven't heard a valid reason for why these lines need to be added to config.xml.


Enable tests to validate when successful

Fixes #147
Currently if you encode and decode in this order C# -> TS -> C#, the TS runtime will round the date value slightly. If you go TS -> C# -> TS no change will be observed. The encoding itself is valid, but the runtime is loosing some precision because the JS Date type uses a 64-bit float to store the number of MS since the Unix epoch.
So the fix is to use a more precise Date type such as a BigInt or two numbers with high/low splits and allow casting to a JS date type, but it does mean it will be a breaking change.

Apparently I am not allowed to review this but I would give a ✔


Vite does not resolve css url() paths correctly

Describe the bug
I am doing
Importing assets using css url() function does not work as expected on build.

In order to test, i have added fonts in both public (absolute path) folder and in src/assets (relative path). Neither of them work as expected.
This is my index.css file:
@font-face {
  font-family: Namian;
  src: url('/fonts/Namian-Regular.woff2') format('woff2');
  font-style: normal;
  font-weight: 400;
  display: swap;
}

@font-face {
  font-family: Namian2;
  src: url('./assets/Namian-Regular.woff2') format('woff2');
  font-style: normal;
  font-weight: 400;
  display: swap;
}

This is what is generated after running npm run build:
dist/assets/index-C8OGOnN2.css (formatted for better readability)
@font-face {
  font-family: Namian;
  src: url(/fonts/Namian-Regular.woff2) format('woff2');
  font-style: normal;
  font-weight: 400;
  display: swap;
}
@font-face {
  font-family: Namian2;
  src: url(/assets/Namian-Regular-Baaf_SnZ.woff2) format('woff2');
  font-style: normal;
  font-weight: 400;
  display: swap;
}

As you can see, the path was not resolved properly.
What i expect is
Vite be able to resolve paths inside css url() functions
What actually is happening is
Vite is not able do resolve paths inside css url() functions
Reproduction
https://github.com/GustavoMelloGit/vite-mre
Steps to reproduce

Clone repository
Run npm i
Run npm run build
Look at the files inside the dist folder

System Info
System:
    OS: macOS 15.0.1
    CPU: (8) arm64 Apple M2
    Memory: 86.63 MB / 24.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.11.0 - /usr/local/bin/node
    npm: 10.2.4 - /usr/local/bin/npm
    pnpm: 9.12.2 - ~/Library/pnpm/pnpm
  Browsers:
    Chrome: 129.0.6668.101
    Safari: 18.0.1

Used Package Manager
npm
Logs

Click to expand!
><EMAIL_ADDRESS>build
> tsc -b && vite build --debug

  vite:config bundled config file loaded in 33.71ms +0ms
  vite:config using resolved config: {
  vite:config   plugins: [
  vite:config     'vite:build-metadata',
  vite:config     'vite:watch-package-data',
  vite:config     'vite:pre-alias',
  vite:config     'alias',
  vite:config     'vite:react-babel',
  vite:config     'vite:react-refresh',
  vite:config     'vite:modulepreload-polyfill',
  vite:config     'vite:resolve',
  vite:config     'vite:html-inline-proxy',
  vite:config     'vite:css',
  vite:config     'vite:esbuild',
  vite:config     'vite:json',
  vite:config     'vite:wasm-helper',
  vite:config     'vite:worker',
  vite:config     'vite:asset',
  vite:config     'vite:wasm-fallback',
  vite:config     'vite:define',
  vite:config     'vite:css-post',
  vite:config     'vite:build-html',
  vite:config     'vite:worker-import-meta-url',
  vite:config     'vite:asset-import-meta-url',
  vite:config     'vite:force-systemjs-wrap-complete',
  vite:config     'commonjs',
  vite:config     'vite:data-uri',
  vite:config     'vite:dynamic-import-vars',
  vite:config     'vite:import-glob',
  vite:config     'vite:build-import-analysis',
  vite:config     'vite:esbuild-transpile',
  vite:config     'vite:terser',
  vite:config     'vite:reporter',
  vite:config     'vite:load-fallback'
  vite:config   ],
  vite:config   build: {
  vite:config     target: [ 'es2020', 'edge88', 'firefox78', 'chrome87', 'safari14' ],
  vite:config     cssTarget: [ 'es2020', 'edge88', 'firefox78', 'chrome87', 'safari14' ],
  vite:config     outDir: 'dist',
  vite:config     assetsDir: 'assets',
  vite:config     assetsInlineLimit: 4096,
  vite:config     cssCodeSplit: true,
  vite:config     sourcemap: false,
  vite:config     rollupOptions: { onwarn: [Function: onwarn] },
  vite:config     minify: 'esbuild',
  vite:config     terserOptions: {},
  vite:config     write: true,
  vite:config     emptyOutDir: null,
  vite:config     copyPublicDir: true,
  vite:config     manifest: false,
  vite:config     lib: false,
  vite:config     ssr: false,
  vite:config     ssrManifest: false,
  vite:config     ssrEmitAssets: false,
  vite:config     reportCompressedSize: true,
  vite:config     chunkSizeWarningLimit: 500,
  vite:config     watch: null,
  vite:config     commonjsOptions: { include: [Array], extensions: [Array] },
  vite:config     dynamicImportVarsOptions: { warnOnError: true, exclude: [Array] },
  vite:config     modulePreload: { polyfill: true },
  vite:config     cssMinify: true
  vite:config   },
  vite:config   esbuild: { jsxDev: false, jsx: 'automatic', jsxImportSource: undefined },
  vite:config   optimizeDeps: {
  vite:config     holdUntilCrawlEnd: true,
  vite:config     esbuildOptions: { preserveSymlinks: false, jsx: 'automatic' },
  vite:config     include: [ 'react', 'react/jsx-dev-runtime', 'react/jsx-runtime' ]
  vite:config   },
  vite:config   resolve: {
  vite:config     mainFields: [ 'browser', 'module', 'jsnext:main', 'jsnext' ],
  vite:config     conditions: [],
  vite:config     extensions: [
  vite:config       '.mjs',  '.js',
  vite:config       '.mts',  '.ts',
  vite:config       '.jsx',  '.tsx',
  vite:config       '.json'
  vite:config     ],
  vite:config     dedupe: [ 'react', 'react-dom' ],
  vite:config     preserveSymlinks: false,
  vite:config     alias: [ [Object], [Object] ]
  vite:config   },
  vite:config   configFile: '/Users/gustavo/Documents/vite-bug/vite.config.ts',
  vite:config   configFileDependencies: [ '/Users/gustavo/Documents/vite-bug/vite.config.ts' ],
  vite:config   inlineConfig: {
  vite:config     root: undefined,
  vite:config     base: undefined,
  vite:config     mode: undefined,
  vite:config     configFile: undefined,
  vite:config     logLevel: undefined,
  vite:config     clearScreen: undefined,
  vite:config     build: {}
  vite:config   },
  vite:config   root: '/Users/gustavo/Documents/vite-bug',
  vite:config   base: '/',
  vite:config   decodedBase: '/',
  vite:config   rawBase: '/',
  vite:config   publicDir: '/Users/gustavo/Documents/vite-bug/public',
  vite:config   cacheDir: '/Users/gustavo/Documents/vite-bug/node_modules/.vite',
  vite:config   command: 'build',
  vite:config   mode: 'production',
  vite:config   ssr: {
  vite:config     target: 'node',
  vite:config     optimizeDeps: { noDiscovery: true, esbuildOptions: [Object] }
  vite:config   },
  vite:config   isWorker: false,
  vite:config   mainConfig: null,
  vite:config   bundleChain: [],
  vite:config   isProduction: true,
  vite:config   css: { lightningcss: undefined },
  vite:config   server: {
  vite:config     preTransformRequests: true,
  vite:config     sourcemapIgnoreList: [Function: isInNodeModules$1],
  vite:config     middlewareMode: false,
  vite:config     fs: {
  vite:config       strict: true,
  vite:config       allow: [Array],
  vite:config       deny: [Array],
  vite:config       cachedChecks: undefined
  vite:config     }
  vite:config   },
  vite:config   preview: {
  vite:config     port: undefined,
  vite:config     strictPort: undefined,
  vite:config     host: undefined,
  vite:config     https: undefined,
  vite:config     open: undefined,
  vite:config     proxy: undefined,
  vite:config     cors: undefined,
  vite:config     headers: undefined
  vite:config   },
  vite:config   envDir: '/Users/gustavo/Documents/vite-bug',
  vite:config   env: { BASE_URL: '/', MODE: 'production', DEV: false, PROD: true },
  vite:config   assetsInclude: [Function: assetsInclude],
  vite:config   logger: {
  vite:config     hasWarned: false,
  vite:config     info: [Function: info],
  vite:config     warn: [Function: warn],
  vite:config     warnOnce: [Function: warnOnce],
  vite:config     error: [Function: error],
  vite:config     clearScreen: [Function: clearScreen],
  vite:config     hasErrorLogged: [Function: hasErrorLogged]
  vite:config   },
  vite:config   packageCache: Map(1) {
  vite:config     'fnpd_/Users/gustavo/Documents/vite-bug' => {
  vite:config       dir: '/Users/gustavo/Documents/vite-bug',
  vite:config       data: [Object],
  vite:config       hasSideEffects: [Function: hasSideEffects],
  vite:config       webResolvedImports: {},
  vite:config       nodeResolvedImports: {},
  vite:config       setResolvedCache: [Function: setResolvedCache],
  vite:config       getResolvedCache: [Function: getResolvedCache]
  vite:config     },
  vite:config     set: [Function (anonymous)]
  vite:config   },
  vite:config   createResolver: [Function: createResolver],
  vite:config   worker: { format: 'iife', plugins: '() => plugins', rollupOptions: {} },
  vite:config   appType: 'spa',
  vite:config   experimental: { importGlobRestoreExtension: false, hmrPartialAccept: false },
  vite:config   getSortedPlugins: [Function: getSortedPlugins],
  vite:config   getSortedPluginHooks: [Function: getSortedPluginHooks]
  vite:config } +22ms
vite v5.4.9 building for production...
transforming (1) index.html  vite:resolve 0.23ms ./assets/Namian-Regular.woff2 -> /Users/gustavo/Documents/vite-bug/src/assets/Namian-Regular.woff2 +0ms
✓ 31 modules transformed.
dist/index.html                              0.46 kB │ gzip:  0.30 kB
dist/assets/Namian-Regular-Baaf_SnZ.woff2   17.06 kB
dist/assets/index-C8OGOnN2.css               0.27 kB │ gzip:  0.15 kB
dist/assets/index-BZJhLpLC.js              142.48 kB │ gzip: 45.74 kB
✓ built in 379ms```
</details>

### Validations

- [X] Follow our [Code of Conduct](https://github.com/vitejs/vite/blob/main/CODE_OF_CONDUCT.md)
- [X] Read the [Contributing Guidelines](https://github.com/vitejs/vite/blob/main/CONTRIBUTING.md).
- [X] Read the [docs](https://vite.dev/guide).
- [X] Check that there isn't [already an issue](https://github.com/vitejs/vite/issues) that reports the same bug to avoid creating a duplicate.
- [X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to [vuejs/core](https://github.com/vuejs/core) instead.
- [X] Check that this is a concrete bug. For Q&A open a [GitHub Discussion](https://github.com/vitejs/vite/discussions) or join our [Discord Chat Server](https://chat.vite.dev/).
- [X] The provided reproduction is a [minimal reproducible example](https://stackoverflow.com/help/minimal-reproducible-example) of the bug.
```[tasklist]
### Tasks

I don't see any problem with the build output. url(/fonts/Namian-Regular.woff2) points the dist/fonts/Namian-Regular.woff2 and url(/assets/Namian-Regular-Baaf_SnZ.woff2) points the dist/assets/Namian-Regular-Baaf_SnZ.woff2. Both of the files exists.
Would you expand on what you are expecting here?

I don't see any problem with the build output. url(/fonts/Namian-Regular.woff2) points the dist/fonts/Namian-Regular.woff2 and url(/assets/Namian-Regular-Baaf_SnZ.woff2) points the dist/assets/Namian-Regular-Baaf_SnZ.woff2. Both of the files exists. Would you expand on what you are expecting here?

The file exists, but the path to it is wrong. You can try ctrl clicking it and you are going to see that it does not work.

I don't think the path is wrong. Vite expects the output directory to be served under / by default and output is correct in that case. It's just that your editor does not support ctrl clicking on paths starting with /.


feat: update tokio dependency to 1.3.0

This PR updates all internal dependencies to point to tokio 1.3.0.
Proof:
cargo tree | rg tokio
│   └── tokio v1.3.0
│       └── tokio-macros v1.1.0 (proc-macro)
│   ├── tokio v1.3.0 (*)
│   └── tokio-postgres v0.7.0
│       ├── tokio v1.3.0 (*)
│       └── tokio-util v0.6.4
│           └── tokio v1.3.0 (*)
│   ├── tokio v1.3.0 (*)
│   └── tokio-stream v0.1.4
│       ├── tokio v1.3.0 (*)
│       └── tokio-util v0.6.4 (*)
│   │   ├── tokio-postgres v0.7.0 (*)
├── tokio v1.3.0 (*)
├── tokio-postgres v0.7.0 (*)
└── tokio-stream v0.1.4 (*)
└── tokio v1.3.0 (*)

NOTE: because of issues with imports and CI pipeline, eventually-app-example has been removed from this repository and moved to https://github.com/eventually-rs/eventually-app-example

Codecov Report

Merging #155 (70703b0) into master (fcf705e) will increase coverage by 0.08%.
The diff coverage is 78.57%.

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
+ Coverage   70.26%   70.34%   +0.08%
==========================================
  Files          26       20       -6
  Lines        1315     1096     -219
==========================================
- Hits          924      771     -153
+ Misses        391      325      -66

Flag
Coverage Δ

unit
70.34% <78.57%> (+0.08%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

eventually-postgres/src/subscription.rs
46.96% <ø> (-1.52%)
:arrow_down:

eventually-util/src/inmemory/store.rs
87.25% <62.50%> (-4.46%)
:arrow_down:

eventually-postgres/src/subscriber.rs
76.19% <100.00%> (+4.09%)
:arrow_up:

eventually-redis/tests/store.rs
98.48% <100.00%> (-1.52%)
:arrow_down:

eventually-util/src/optional.rs
0.00% <0.00%> (-75.00%)
:arrow_down:

eventually-core/src/aggregate.rs
0.00% <0.00%> (-74.29%)
:arrow_down:

eventually-core/src/subscription.rs
0.00% <0.00%> (-42.23%)
:arrow_down:

eventually-core/src/repository.rs
0.00% <0.00%> (-37.04%)
:arrow_down:

eventually-util/src/inmemory/projector.rs
28.00% <0.00%> (-18.00%)
:arrow_down:

eventually-postgres/src/store.rs
63.71% <0.00%> (-4.43%)
:arrow_down:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcf705e...70dc6f0. Read the comment docs.


Questions about the paper

Hi Gyungin,
Thanks for sharing the code for such a simple but effective algorithm. while reading your paper, I came up with two questions,

In 4.5 Practical deployment, you mentioned that "it takes less than 1 second on average to label the queried pixel (10s per image),..." Does this mean it takes very close to 1 second for each pixel and about 10 seconds to annotate 10 pixels for each image?

In Table1, you reported the number for CCT with 1.5K fine annotations and 9K weak annotations. If my understanding on CCT is correct, however, it is supposed to be 73.2. I guess 69.4 is for the case where CCT is trained only on 1.5K fine annotations and 9K unlabeled images. Could you double check this?

I look forward to hearing from you. Thank you.

Hi Won Bae, thanks for your enquiry. Regarding your questions,
(1) Yes, that's what we meant. It takes around 0.8-0.9 second per pixel on average to label on VOC2012 dataset.
(2) The authors of CCT reported two results based on the models trained with 1.5K fine annotations from the original VOC2012 dataset and 9K augmentation dataset from the SBD dataset, each with and without image-level labels from the SBD. In the paper, we reported the one trained without image-level labels, and denoted it together with other weakly-supervised methods to make the table compact. Instead, to avoid such a confusion, we added some descriptions on each method in Supplementary Material ("Methods description" section).
I hope these can answer your questions.
Please let us know if you encounter any other questions! :)
Kind regards,
Gyungin


chore(Android): Migrate Hermes Instruments to Kotlin

Summary:
Time to migrate some of Hermes's instruments. I see that HermesMemoryDumper(react/hermes/instrumentation/HermesMemoryDumper.h) implements the interface on C++, ~but not sure if i need to update the getId call to just id (same with getInternalStorage) or if the interop between Kotlin and Java applies to these things as well. @cortinico Any thoughts on your side would be appreciated.
HermesSamplingProfiler just became an object, since it was a singleton and a static anyway.
Here is what HermesMemoryDumper.h looks like:
~
Updated: I ended up making them match the function signature on Cxx, because even if it does have that implicit behavior, doesn't feel right to tap into it like this.
Changelog:
[INTERNAL] [FIXED] - Migrate HermesMemoryDumper and HermesSamplingProfiler to Kotlin
Test Plan:
/gradlew test:

Hi @philIip. Can you please tell me what this change broke? Guessing the linter thing is because of character spacing but other than that i have no idea what this could have broken


M3-657 search backend ips

Purpose
AutoComplete suggestion dropdown for NodeBalancer node addresses
To Test

Either go to the Create or Edit flow for a NodeBalancer
Scroll down to your nodes and begin either typing a Linode's label or a private IP address
Watch the suggestions appear 💯

Notes

You're only going to get suggestion for Linodes that have private IPs.
Only 10 suggestions will show at a time. We can raise that or lower that, and I'm ready to debate about it
The user doesn't have to select a dropdown suggestion. If they choose, they can certainly just type in the IP address themselves

Misc

We can assume that any ipv4 from the API that begins with 192.168 is a private one

References
Downshift

Styling all set. Keyboard accessible ready as well.

Coverage decreased (-0.1%) to 28.282% when pulling 311d45c54ec4c2db0d8886acf8b6a87e80c797f2 on martinmckenna:M3-657-search-backend-ips into 2cf7a2876be56ab5f9968406c964e1bf4beff329 on linode:develop.


Update README.md as per issue #77

Fixes #77
Added an Tutorial based on GPT-based zero-shot text classification in Articles/Tutorials Section
@ashitaprasad  please review and merge this pull request

This article is not of good quality and it is very dataiku specific.


Possible problems installing with latest Debian (Buster) and Ubuntu 20.04

Hello, this is by far the cleanest looking UI front end for this stuff I've come across (really nice work) and I'm trying to get everything up and running. I've tried on both Debian (Buster) and Ubuntu 20.04 (and it's very possible I'm doing something wrong), but do you know if the latest versions of the dependencies listed and your code can be successfully utilized under either of these environments? (e.g. throughout the process I get lots of warnings about optional dependencies being skipped, unsupported engines, and not compatible messages).
In addition to the clean UI you provide, I'm hoping to be able to switch over to this from WANem so I may run a current OS that I can keep up-to-date.
Thank you

Hi there! I'm happy to hear that you like this UI!
I'll be brutally honest here--I have personally used (or maintained) this tool for several years, so it will take me some time to actually answer your questions in a satisfactory fashion. I'll take some time to get a build working with current tooling and post about my progress!

Many thanks - I greatly appreciate it!

Unsurprisingly, the polymer (and every other) ecosystem has progressed a lot since I built this. I am considering just rebuilding the whole UI with the current LitElement magic I just learned about. I can't promise it will be a quick migration, but it will result in a tool that actually builds!

I greatly appreciate your efforts. In case this helps as far as what I am envisioning on my end, I essentially would like to spin up a dedicated VM (minimal OS) with 2 bridged interfaces to be able to control both the outgoing and incoming conditions.

That's precisely the use case I had when I built this tool! Hopefully it works as well for you as it did for me!
One slight difference in the "appliance" I used: it had a third "management" interface, which was used to access the UI. You might consider adding one to your VM as well, so you can interact with the UI without the network shaping rules affecting your experience ;)

Thanks for sharing. I had primarily envisioned just using the web browser locally on the OS (which I'd probably still want to do) but having this option could also be helpful.

Hi @codekoala , I just thought I'd check in to see if you've had any luck or potential ETA?
Thanks!

Hi @Chaskel! The guy working on the UI revamp has been making great progress, but we don't have an ETA just yet. Hopefully we won't be too much longer :)
Are you able to use the pre-built binary?

@codekoala thanks for the quick response and glad to hear of the great progress! Where is the pre-built binary are you referring to (and associated readme so that I can look to attempt)?
Thanks again!

You should be able to download the current pre-built binary at https://github.com/codekoala/network-shaper/releases/tag/0.0.5. Please let me know if you have any issues with that!

@codekoala ok thanks. Will be giving it a shot on a CentOS box that is currently available and will get back to you.

I suppose I should try reading an entire response before responding. The configuration and usage for this tool is described in the README at the repo root. The good stuff starts around here: https://github.com/codekoala/network-shaper#using-this-tool

No worries. That's the one I had been using previously but wasn't sure if there was something different for the pre-compiled binary you were referencing. Will keep you posted.

Hi @codekoala . Quick update. Both the CentOS test as well as an Ubuntu 20.04 test appear to work in initial tests. I have however run into an issue and I'm not sure how widespread is.
Please note that in my setup I have it where:

eth0 is LAN/mgmt connection (IPv4 and IPv6 via DHCP)
eth1 and eth2 are members of br0 interface I created and none of these interfaces are configured to have IPv4 or IPv6 addresses. One plugs into router and the other plugs into client to be tested.
In the network-shaper web interface I select eth1 as the incoming and eth2 as the outgoing (but I also have to check the checkbox to show interfaces without IPs since they don't show up (which btw after checking that box I have to first apply a bogus selection in order to have them show up on a refresh <unless I've missed something obvious>)

The issue I've been able to reproduce (not configuring anything else except for selecting the interfaces) is that if I enable delay on the outbound interface, put in 50ms for Time and 150ms for Jitter, apply the change, then change just the Jitter back to 0ms, it appears to deselect the previously selected interfaces. Again, I'm not sure how widespread (e.g. if it possibly alters other settings as well or if it is reproducible with other settings)
One other comment in case this helps is that I like the sliders however as I'm tending to want to use the lower range of the scale, I find that they are too delicate to pick low numbers so I end up typing them in. (which is fine for my use but for those that like sliders it could be problematic)

...just adding really quick (in case it relates to what I mention above) that when I tried to select the interfaces again just now, it took me saving about 5 times for it to actually stick. Each time it said it was successfully applied but when the page refreshed they would not be selected.


Something silly and burn-ish for the Airport?

Without compromising safety..
Silly airline captain hats
Costumes like Crocodile Hunter (Safari suit?)

Pilot joke collection
Swag for landing at the airport?
other fun stuff...

nahhh


Added Graphing Calculator

Fixes Issue🛠

Closes #280
Description👨💻
This calculator includes a graphical display to visualize functions commonly used in mathematics and science.
Type of change📄

[] Bug fix (non-breaking change which fixes an issue)
[] New feature (non-breaking change which adds functionality)

How this has been tested✅

Checklist✅

[] My code follows the style guidelines of this project
[] I have performed a self-review of my own code
[] I have commented my code, particularly in hard-to-understand areas
[] I have added demonstration in the form of GIF/video file
[] I am an Open Source Contributor

Screenshots/GIF📷

Merged!! ✨ @AbhineshJha


Eclipse Compile Error

cannot get the method

you need install the Lombok plugin.
see https://projectlombok.org/setup/eclipse


Allow dynamic LabelText closure to return different types

This should decrease copying (especially if the user-provided closure returns Arc<str> or something that can be converted to it without copying) and make comparisons in resolve faster.

CI failure looks unrelated.

rebase should fix CI

Oh, CI failure is related. I'll update the examples tomorrow.

I think one downside is that dynamics will often return format!()ted strings, and that would have to reallocate.

I think one downside is that dynamics will often return format!()ted strings, and that would have to reallocate.

This already happens right? We always store data as Arc<str>

Updated the one example affected by this and added a changelog entry.


Report progress in query tip.

CARDANO_NODE_SOCKET_PATH=example/node-bft1/node.sock cardano-cli query tip --testnet-magic 42 --cardano-mode
{
    "epoch": 0,
    "now": 69,
    "tipTime": 68,
    "hash": "59a9ba374f8e2118dd7d198cee2608a107ac934c9fa1c40808d2dc48c217f431",
    "slot": 342,
    "block": 14,
    "era": "Alonzo",
    "systemStart": "2021-06-18T11:36:04Z",
    "syncProgress": "100.00"
}

Basing this on top of PR #2843 that updates the deps and adds the new queries will reduce the size of this PR.

I confirmed this works on Alonzo Blue testnet:
CARDANO_NODE_SOCKET_PATH=testnet/alonzo-blue/socket cardano-cli query tip --testnet-magic 5 --cardano-mode
{
    "epoch": 54,
    "now": 2201640,
    "tipTime": 389671,
    "hash": "be52191f06735eab92b31d78f1f3d662a4d1ab01e3ad750e4286432b7c6e5f2b",
    "slot": 382831,
    "block": 18903,
    "era": "Mary",
    "systemStart": "2021-05-27T19:47:07Z",
    "syncProgress": "17.73"
}

Added ability to connect to Alonzo Blue testnet for testing

Now merges multiple queries into one conneciton.

bors merge


fix folder structure

Correct folder structure, rename files so code samples are in the folder for the correct chapters in the book

New here need help


Validate api gateway OpenAPI specs

relates to https://github.com/nitrictech/cli/issues/102
In addition to validating our own schema, we should validate the API definitions within the stack files.

Closed by: https://github.com/nitrictech/cli/issues/102


python2Packages.notebook: fix tests

These were accidentally broken by #37615.
Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build python2.pkgs.notebook python3.pkgs.notebook

Success on x86_64-linux (full log)
Attempted: python2.pkgs.notebook, python3.pkgs.notebook
Partial log (click to expand)
/nix/store/s6asrspp3x0qgcqhq96fdbbdh0qk2395-python2.7-notebook-5.4.1
/nix/store/mk8z292fn7lg2lq7vqzzwfq1rvhiqi7w-python3.6-notebook-5.4.1

Success on aarch64-linux (full log)
Attempted: python2.pkgs.notebook, python3.pkgs.notebook
Partial log (click to expand)
/nix/store/9mknsvj39gr49cbpzqd9m7q1x6fvpi8z-python2.7-notebook-5.4.1
/nix/store/x4nb1b60v81hqpg3377x49nz2kwasbjs-python3.6-notebook-5.4.1

Thanks again!


Feature Request: Per-directory configuration

Is your feature request related to a problem?

It's difficult to write and maintain XML configuration rules to apply different subdirectories, as the existing configuration file syntax is oriented towards specifying paths that apply to rules rather than rules that apply to paths.
See also https://github.com/squizlabs/PHP_CodeSniffer/issues/2551
Describe the solution you'd like

Per-directory configuration files would be nice. Conceptually there are at least two ways this might work: for example, if you have a file at subdir/.phpcs.dir.xml then for files in that directory phpcs would

act as if it had been run as phpcs --standard=.phpcs.xml.dist,subdir/.phpcs.dir.xml, loading the subdirectory ruleset as a peer of the parent's, or
use subdir/.phpcs.dir.xml as the ruleset, but treat that file as if it had <rule ref="../.phpcs.xml.dist" /> at the start.

Additional context (optional)

We've been using a fork of phpcs that enables this in our monorepo at https://github.com/Automattic/jetpack since December 2021 and it has worked out very well for us despite some caveats.
The important caveats with the version in the fork are:

The fork itself is pretty minimal, as in the old repo it seemed like 4.0 was never going to happen. Basically the fork just enables filters to return a PHP_CodeSniffer\File instance instead of a filename. Then a custom filter returns File instances that have different values for ->ruleset and ->config as necessary to reflect the per-dir config files.
Since the PHP_CodeSniffer\Config class is half-static, <config> doesn't work well at a per-directory level.

Various other directives like <ini> and <arg> and <autoload> also don't work at a per-directory level, but those are much easier to classify as "global" and therefore say they shouldn't work per-directory.

Since our fork takes the --standard=.phpcs.xml.dist,subdir/.phpcs.dir.xml approach rather than the implicit-<rule ref="../.phpcs.xml.dist" /> approach (because the latter is a lot harder to do from a filter), <exclude name="Standard.Category.Rule" /> doesn't work to exclude a rule that had been enabled in a parent directory. Since <exclude name="Standard.Category.Rule"><severity>0</severity></exclude> does still work, that hasn't been that much of a problem.

Since a 4.0 release seems imminent in the new repo, I wonder whether I might do better to do a more invasive PR than we had done in https://github.com/squizlabs/PHP_CodeSniffer/pull/3378. The main breaking change a more invasive PR would do would be to change methods like Config::getConfigData() to be non-static, which would affect sniffs that use Config. Probably they'd have to access the instance via $phpcsFile->config instead.

[x] I intend to create a pull request to implement this feature.

I'm not sure I fully understand your problem.
You can already use option 2 by having an explicit <rule ref="../.phpcs.xml.dist" /> at the start of the subdirectory ruleset.
Making that implied will be a huge breaking change which I'm not willing to make.
Having it explicit is a one-liner, so why is anything else needed ? (aside from the overruling issue, but that would be solved once 4.0 is released).

Since a 4.0 release seems imminent in the new repo, I wonder whether I might do better to do a more invasive PR than we had done in https://github.com/squizlabs/PHP_CodeSniffer/pull/3378. The main breaking change a more invasive PR would do would be to change methods like Config::getConfigData() to be non-static, which would affect sniffs that use Config. Probably they'd have to access the instance via $phpcsFile->config instead.

That is not a change I would accept for the 4.0 release. To be able to get to 4.0 sooner rather than later, I want to stabilize things, not de-stabilize by making larger breaking changes for which I cannot oversee the full impact of at this time.

I think the part you're missing is that I want to run phpcs just once at the root of the project, and then for some/path/ that has some/path/.phpcs.dir.xml it would transparently use that standard for files under that path, and for another/path/ with a different another/path/.phpcs.dir.xml it would use that standard for files in there, and for another/path/and/deeper/ with another/path/and/deeper/.phpcs.dir.xml it would use that standard (which itself "extends" another/path/.phpcs.dir.xml) for files there.
Yes, you can get something close to this with configuration like you suggest and multiple runs of phpcs and careful exclusion of the files in the higher-level runs that will be covered in the subdirectory runs instead. And then possibly having to merge together the results from the multiple runs for CI tooling to make use of. But all that is a pain and hard to scale.
Note the implied <rule ref="../.phpcs.xml.dist" /> would only apply to these per-directory .phpcs.dir.xml config files. If someone is already using the multiple-runs method instead, those wouldn't be per-directory config files and so wouldn't have the implied <rule>. And I'm still leaning towards there being no default name for the per-directory files, so anyone wanting to use it would have to opt-in by setting a name for them in their configuration.
I do like the implied <rule> for the per-dir files, because then you don't have to worry keeping them in sync when changing things around. Say you were to decide to add another/.phpcs.dir.xml, for example: with an explicit <rule> you'd have remember to update another/path/.phpcs.dir.xml (and any others) to point to that now instead of the .phpcs.xml.dist in the root.

That is not a change I would accept for the 4.0 release.

Thanks for letting me know. Would 5.0 be expected to happen reasonably soon after 4.0 (like months to a year rather than multiple years) and a breaking PR would be accepted for that? Or would you rather have a rebase of https://github.com/squizlabs/PHP_CodeSniffer/pull/3378, since that was carefully designed to not break anything?

I think the part you're missing is that I want to run phpcs just once at the root of the project, and then for some/path/ that has some/path/.phpcs.dir.xml it would transparently use that standard for files under that path, and for another/path/ with a different another/path/.phpcs.dir.xml it would use that standard for files in there, and for another/path/and/deeper/ with another/path/and/deeper/.phpcs.dir.xml it would use that standard (which itself "extends" another/path/.phpcs.dir.xml) for files there.

Indeed the bit I was missing. Will need to have a think about this, but this is not something which is on my priority list at this time.

That is not a change I would accept for the 4.0 release.

Thanks for letting me know. Would 5.0 be expected to happen reasonably soon after 4.0 (like months to a year rather than multiple years) and a breaking PR would be accepted for that?

I do expect to have more regular majors, once a year/once every two years.
However, my focus at this time is on stabilizing and on getting to 4.0 and then on some structural changes I already have planned for 5.0 myself. I currently don't have the bandwidth to make a judgement call on this ticket for 5.0. I will need to circle back to this at a later time.


Refactor app architecture

Closes #55 #91 #120 #118 #117 #112 #109 #108 #102 #100 #98 #94
Also adds better DSL

I can't figure out how to disable such warnings. If I could only add two annotations...
Thanks, that makes sense.
We still have APK of size less than 7MB. It seems like, on old android versions, the resulting size of the app on a device is bigger. It is not a big problem. All apps on my phone have 20+MB size. It's totally okay.


Fix typos

@gregnazario Could you please take a look?

Thanks for the review!
Phew, it's a lot of hassle to revert the docs changes.
I better close it :)

Oh, it should have been as simple as git checkout origin/main docs. I think


New Tabs do not read Environmental variables a-new

WindowTerminal Version: 1.3.2651.0
Windows 10 1909 build 18363.1139
Summary:
If you've already opened windows terminal and change an environmental variable such as PATH and then spawn a new tab, the new tab does not include the latest updates to the variable.  This requires users to completely close the entire windows terminal application to get it to read the variable.  Each sub process / tab should read the environment variables anew on spawn preventing the need to close any windows that may be open already and losing possible work in the process.
To reproduce:

Open Windows Terminal and have an existing window opened
Change the system path to include a new test item in the path
spawn a new tab in the existing windows terminal
echo the system path and note that the changed path is not included

I think this might be a dup of #1125.

Indeed. This was fixed in #7243, but I have been holding it back from Stable builds because it breaks WOW64 PowerShell. (#7418). /dup #7243