Guidelines for river and pingora frontend issues

It'd be nice to have clearer guidelines that indicate the division of responsibilities between river (a pingora "frontend" that compiles into an actual binary) and pingora (the core framework). We've been directing folks' issues to river when it makes sense.
Some classes of features such as no/low-code configuration are already set to belong in river rather than pingora, but other cases may be less clear. For example, some features like Kubernetes ingress implementations per https://github.com/cloudflare/pingora/issues/41 are almost certainly destined for river and not core pingora, but the river implementation may generate a feature request for pingora; the exact division of code might not be clear until design time.
This is a tracking and discussion issue for what those clearer guidelines should be and where to describe them. The ideal outcome is that we minimize confusion and issue redirection between the two projects.

cc @jamesmunns

Thanks @drcaramelsyrup!
I think there's a couple main things to discuss at some point:

Making the distinction between "frontends" like River and "the backend" of pingora more clear (and maybe agreeing on where to draw the lines?)
Unwinding some code/architectural decisions to make pingora more "friendly" to different frontends
Communicating these things up front in the pingora and river repos

WRT 1 + 2: this would be things like removing configuration handling, and maybe things like signal handlers from pingora itself, and instead lean on library APIs and methods that can be used to trigger those actions or provide config.
I'm happy to keep giving feedback as I go, or have a chat/call sometime.
WRT 3: I think once we get on the same page, it'd be good to just write it down in the docs, and link it in both repos. No need for crazy formalism :)


URGENT: osm2vectortiles.org DNS trouble

Lukas,
the DNS servers for osm2vectortiles.org which you manage are not resolving now!
The project website is down.
$ ping osm2vectortiles.org
ping: cannot resolve osm2vectortiles.org: Unknown host
$ ping www.osm2vectortiles.org
ping: cannot resolve www.osm2vectortiles.org: Unknown host

Shall we move the DNS to<EMAIL_ADDRESS>and DNS servers manage by company - which has 24/7 monitoring set and somebody resolving potential issues?

I see DNS connectivity issues at:
https://status.digitalocean.com/

I see DNS connectivity issues at:
https://status.digitalocean.com/

DNS is indeed managed by Digital Ocean. I can switch the nameservers but I would wait until they come back.

Site was approximately 2 hrs down.
Digital Ocean DNS is working again - those poor sysadmins had a rough day I guess.


Midea XTreme Save Pro MGP2X12 status is shown but cannot be controlled

When I use NetHome Plus app and pair the AC with it, I am able to use your plugin in Homebridge. It displays my AC. It appears correctly in Home app and I can see the live status of it. But when I try to control the AC from the Home app, it just does nothing. At the next status update it bounces back to the previous value. Homebridge logs are also mute. Any clues? Is it a setup problem or is my AC not compatible?

Your AC is not fully compatible.
There is an open issue for it.

Which one? This? https://github.com/hillaliy/homebridge-midea-air/issues/3

yes


[CI Problem] failed docs push to https://github.com/apache/tvm-site.git

Branch/PR Failing
https://github.com/apache/tvm/commit/5cef6bf559265e74b84504ed2e190f29f5c5bf33
https://github.com/apache/tvm/commit/13ebbfb37f8cec1da71d88fbcbecdd4ad4d24dcc
Jenkins Link
https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/main/4129/pipeline/
https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/main/4144/pipeline/
Flakiness
Multiple commits (see above)

This usually happens since there is a merge race to update the docs between two commits. The best way to fix would be to check the hash in this file and:

if it's newer: give up since the docs have already been built and pushed including this commit
if it's older: force push the new changes

Another occurrence: https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/main/4167/pipeline


MAINT: skip complex128 propack tests on windows (& module clean-up)

In addition to forward-porting the minimal commit from https://github.com/scipy/scipy/pull/16512, I wanted to clean up the dtype-handling in that test module a bit. Also tested that this works in https://github.com/conda-forge/scipy-feedstock/pull/206

For reference, I've merged the backport version in gh-16512 since that's basically a mandatory fix for the test suite we need in RC2, but since this involves refactoring in sparse linear algebra tests, I think I'll give it some time for the linalg residents to skim it over. That said, it will indeed be good to have this properly forward-ported so it hopefully doesn't bite us in another release process.

That said, it will indeed be good to have this properly forward-ported so it hopefully doesn't bite us in another release process.

Not sure I understand, this PR is targeting main, so it's not going to fall under the table going forward.
That said, happy to port whatever change wherever branch it needs to go to.

do you recall what the failure was with the Azure prerelease_deps_coverage_64bit_blas? Logs are now gone, not sure if another run is warranted

It was in conda-forge CI...

These changes LGTM

Thanks for the review

I think we're ready for the merge button here?


Adding spring placeholder resolution

Added a '.' to ':' replacement on identified placeholder before resolution to ensure that spring placeholders can be resolved. Attempted only after other resolution attempts have failed.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: TheBritz sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

/azp run

Thanks for your contribution @TheBritz!


How can I use Transform streams with stream.read?

Spex stream.read consumes and processes data from a Readable stream. How can I use transformed Readable stream?
Eg. I've large JSON file and want to parse it with JSONStream and then stream it into database with spex and pg-promise. How can I implement this?

Did this not help? - https://github.com/vitaly-t/pg-promise/wiki/Learn-by-Example#into-database

Thanks for reply! The problem is that transformed Readable stream does not pass validation at https://github.com/vitaly-t/spex/blob/master/lib/utils/static.js#L15
Consider example:
const stream = fs.createReadStream('features.geojson').pipe(JSONStream.parse('features.*'));
db.tx(t => spex.stream.read.call(t, stream, receiver)).then(...)

This causes an error:
ERROR: TypeError: Readable stream is required.

Perhaps that verification for a readable stream that I didn't isn't quite valid, and will need to be updated.

No, scratch that, you are not using it correctly. Should be:
const stream = fs.createReadStream('features.geojson');

function receiver(s){
    s.pipe(JSONStream.parse('features.*'));
}

db.tx(t => spex.stream.read.call(t, stream, receiver)).then(...)

@stepankuzmin If it is still an issue, would you try and do a PR to fix this?

The existing verification is like this:
function isReadableStream(obj) {
    return obj instanceof stream.Stream &&
        typeof obj._read === 'function' &&
        typeof obj._readableState === 'object';
}

@stepankuzmin if this is somehow incorrect, feel free to make an argument and a PR. My experiments with this didn't yield anything good for the type of stream that you are trying to read.

Having gone through the code here: https://github.com/sindresorhus/is-stream/blob/master/index.js
I don't think your input object is a readable stream.
I am closing it for now as invalid, since there is lack of feedback anyway.


Test gRPC endpoints

Adds gRPC reflection support
Tests implemented gRPC services on CI

Uses grpcurl

@Farhad-Shabani do you mean to validate the values received from the server too? As in, the number of channel per connection should be 1 and etc.

@Farhad-Shabani do you mean to validate the values received from the server too? As in, the number of channel per connection should be 1 and etc.

Yes, exactly. Whatever the server returns in the first place should not be an empty response. Later, maybe it's even worth checking for some exact values too.


added ignore for hyper params

What does this PR do?
PR to enable ignore of args passed to the function instead of ignore only of init_params

Fixes #19761

Before submitting

Was this discussed/agreed via a GitHub issue? (not for typos and docs)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20213.org.readthedocs.build/en/20213/

Looks reasonable, we'll merge with a test : ) Thanks!

Hey @aseemk98 would you have time to add a test?


Working with web APIs in Python

Article checklist
ATTENTION: In your PR - add the ISSUE (topic form) # that this PR corresponds to. You can do this by also adding a comment that states "This fixes #(enter your Idea Content Form #)" to link and close your Idea Content (issue) when the PR is merged.
NOTE: (Please ensure that you have only one open issue + linked pull request at a time. This will ensure that we complete the article in a timely manner from inception to publishing.)
If you have not already please go over our Resources Page for more tips and tricks on how to improve our overall technical writing.
Preliminary Checks - Formatting and Structure

[x] Is the article you are submitting an in-depth and unique article? Does it go beyond what is in the official docs and what is covered in other blog sites. See these articles as examples.
[x] Does your article follow any of the suggested structure formats? - see example formats
[x] Is your article properly formatted in Markdown? - see Github Markdown guide
[x] Have you used the correct folder and file structure? - see Contribution Guidelines
[x] Is your article over 750 words? - Tool: Wordcounter.net
[x] Have you used our preferred heading structure? - H3 (###) and up
[x] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.
[x] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.
[x] Have you included a hero image that is 600x400 pixels and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images
[x] In your PR - add a comment that states "This fixes #(enter your Idea Content Form #)" to link and close your Idea Content (issue) when the PR is merged.

Grammar & plagiarism checks

[x] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid -  Grammarly
[x] Please place your article through a 3rd party plagiarism checker? We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[x] Have you checked your article for readability? - Tool: Hemmingway
[x] Have you added sources for quotes and images that aren't yours?

Technical checks

[x] Are your code snippets properly formatted for syntax highlighting - see Syntax guide

Contribution guidelines
For first-time contributors and for more details, see Contributing Guidelines
This fixes #2742

@Bonimum
Since this was a very very minor change. I'll do that as part of my tech review.
Moving to tech review.
Thanks.

@Bonimum
I'll be running a final review on your PR when ready.
Upon running your article through our 3rd party plagiarism checker it seemed to raise a few flags and the % was higher than we typically accept.
Please see attached PDF - and revisit the article to ensure we are contributing wholly unique and original content.
Be sure to see our resources page to see more info on plagiarism and what is considered as such.
Working with web APIs in Python #3161.pdf

@Bonimum
Please work on the plagiarism check changes, before I start the next round of review.
Ping me when done.
Thanks.

On it @srishilesh

@Bonimum
Please work on the plagiarism check changes, before I start the next round of review.
Ping me when done.
Thanks.

On it @srishilesh

@Bonimum
Please ping me when done with the changes.
Thanks.

@srishilesh
Done with the changes
Thanks

@srishilesh  I am done with the minor changes
Thank you

@Bonimum
Thanks for the changes.
I've completed the tech review as well. Before round of review by me, make the following changes.
Ping me when done.
Thanks.

@srishilesh
Changes done. Please continue with the review.
Thanks.

@srishilesh    Done with the changes. Thanks

Made some minor but important changes for flow
@Bonimum
cc @srishilesh
Please be sure to review to improve future articles and reviews 🚀
Overall great job gents


Crash when loading discovery while internet connection is offline

The function EduroamConfigure.IdentityProviderDownloader.LoadProviders() can throw an InternetConnectionException, which is not caught further up.
It must be caught in these three functions:

EduroamConfigure.LetsWifi.RefreshAndInstallEapConfig()
WpfApp.Menu.InstalledProfile.LoadProfile()
WpfApp.Menu.MainMenu.LoadProviders()

Fixed in 148d25d


improve Send Notification dialog AGPUSH-1389

https://issues.jboss.org/browse/AGPUSH-1389
Testing:

click 'Send Notification to this app'
verify that close button works
interactive combo-box should be visible instead of standard <select multiple /> combo box

@andresgalante I did some small changes to LESS in order to avoid need for another icon set (glypicons) when the one we used already (font-awesome) can be used.

unrelated test failure

:+1:

:+1:


Flow names on command-line

I noticed that when running flows from the command-line the code converts the class name from PascalCase to snake_case.  Is this done to keep lower-case command-line convention?  In my opinion it might be more clear to just have the command-line name match the class name, even if it means we are case-insensitive.  Thoughts?

The one problem with this is how we obtain access to each flow class at the moment. We use the following utility method in the flow manager, which has to import the module before it gets the flow class.
def get_flow(flow_name):
    """Get a flow by name"""
    flow_module = import_module(f"bfasst.ninja_flows.{flow_name}")
    flow_class = "".join(word.capitalize() for word in flow_name.split("_"))
    return getattr(flow_module, flow_class)

If we were to switch to specifying the name of the class instead of the name of the module, we would have to import all the flow modules and search each one until we find the one that contains the class we specified. Is that what we want to do?

Oh I didn't realize it was based on module name.
How are we loading the list for the argparse choices?

It appears that choices was removed when bfasster.py moved to run.py. However, it was loaded using this other flow utility function, which returns the names of all the flow modules.

I think it would be ok to have a single file (perhaps yaml) where we keep a list of flows and their description, which would be used for #382.

Ok, but we'd keep the same approach for accessing them, right? Or we want to change to import all the modules and find the correct flow class?


Fix typo

@GitCash send $1 to @Philipinho

Hey Philipinho, user christroutner tipped you 7812 bits in Bitcoin Cash ( ~ $1 ).
Click here to claim it!
You can also add the "thumbs down" reaction to christroutner's comment above to prevent future tips.

@GitCash send $1 to @Philipinho

Thank you!

Thanks for the tip.


TSC Strict mode error TS2722: Cannot invoke an object which is possibly 'undefined'.

TypeScript Version:  2.7.2
Have also reproduced with typescript@next (3.5.0-dev.20190525).
Application insights version: 1.0.20

Search Terms:
error TS2722 cannot invoke an object which is possibly 'undefined'.
typescript error
Application insights
Code
I am moving our codebase, incrementally to use strict null checks using a new tsconfig.strict.json below.
{
    "extends": "./tsconfig.app.json",
    "compilerOptions": {
        "noEmit": true,
        "strictNullChecks": true
    },
    "include": [
        "app/menus/",
        "app/layout/",
        "app/core/"
    ],
    "exclude": [
        "**/*.module.ts",
        "**/*.spec.ts"
    ]
  }

Here are the relevant parts of the file in question ApplicationInsights.ts...
import { AppInsights as appInsights } from 'applicationinsights-js';
...
    constructor(private readonly appConfig: AppConfigProvider) {
            if (appInsights && !appInsights.config && this.config) {
                appInsights.downloadAndSetup(this.config);
            }
    }

Note: I have also tried being explicit with a constant as seen below and receive the same error...
   constructor(private readonly appConfig: AppConfigProvider) {
        const ai = appInsights;
        if (ai !== void 0) {
            if (!ai.config && this.config) {
                ai.downloadAndSetup(this.config);
            }
        }
    }

Expected behavior:
No error is thrown by tsc compiler.
Actual behavior:
src/application-insights/ApplicationInsights.ts(25,17): error TS2722: Cannot invoke an object which is possibly 'undefined'.
i.e. it believes that appInsights (or ai ) is undefined even inside a check to prevent it from being undefined.
Thanks in advance.
Related Issues:
Related Issues: #22385 (dupe of 10530) #10530

Firstly, this is more of a question, generally this is not the forum for such questions (SO is a  better place to ask something like this.
Secondly, this is not a typescript issue. From the definition file of the library:
downloadAndSetup?(config: Microsoft.ApplicationInsights.IConfig): any;

So downloadAndSetup ca be undefined according to the definitions (due to the ?) and so typescript is right to issue an error as you have not checked downloadAndSetup is not undefined.
If you believe downloadAndSetup can't be undefined file a bug on that package. You can fix this on the ts side, either by adding the check or by using the not null assertion (!)
ai.downloadAndSetup!(this.config);  // assert not null

if(ai.downloadAndSetup){ // or do the check
  ai.downloadAndSetup(this.config);
}

Thanks for the swift reply. Your solution fixed the issue.
I think the confusion arose from the positioning of the error marker? (25,17). The 17th character was the start of ai so it looked more like ai was potentially undefined rather than the function.
Would it not be more correct to label it on the actual method e.g. (25,19 / 20) ?

@jameshmread  this PR https://github.com/microsoft/TypeScript/pull/31414 might also change the error span for this case, maybe try it again after the PR is merged and see if it makes things more clear in this case as well.

I found this issue here and wonder if there might be some buggy behaviour in this place. I have this pretty simple code which throws errors about possibly undefined functions although I have a check before calling the functions.
the functions useFactory, useExisting and useClass are all optional and for all of them the compiler complains.
private static createAsyncOptionsProvider(options: ServiceConnectorModuleAsyncOptions): Provider {
  if (options.useFactory) {
      return {
        provide: ENDPOINT_CONFIGURATION,
        useFactory: async (...args: any[]) => await options.useFactory(...args),
        inject: options.inject || [],
      };
    } else if (options.useExisting || options.useClass) {
      return {
        provide: ENDPOINT_CONFIGURATION,
        useFactory: async (optionsFactory: ServiceConnectorOptionsFactory) => await optionsFactory.createOptions(),
        inject: [options.useExisting || options.useClass],
      };
    } else {
      throw new Error('useClass, useExisting and useFactory not provided');
    }
}

@DaSchTour I also found this to be a problem/bug. using<EMAIL_ADDRESS>and<EMAIL_ADDRESS>here's my .tsconfig:
{
  "compilerOptions": {
    "strict": true,
    "alwaysStrict": true,
    "module": "CommonJS",
    "target": "ES2020",
    "moduleResolution": "Node",
    "lib": ["ES2021"],
    "incremental": true,
    "declaration": true,
    "declarationMap": true,
    "sourceMap": true,
    "skipLibCheck": true,
    "esModuleInterop": true,
    "forceConsistentCasingInFileNames": true,
    "allowSyntheticDefaultImports": true,
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "resolveJsonModule": true,
    "rootDir": ".",
    "outDir": "./dist",
    "baseUrl": "./"
  },
}

Here's a screenshot:

the first one is permitted, the second one is not. both objects are the same type, only the first object is optional and both objects have both functions (warn and debug) required, not optional.
both lint and building fail on a simple optional logger object.
Happy to open a new issue, but I am working with proprietary code here. so i'd have to build a new clean/open project to repro when I have more time.
Mainly wanted to add my +1 for other folks who found this thread and maybe even get some maintainer eyes on this problem.

Please open a new issue with a reproducible example.


Bump k8s.io dependencies

Pull Request Motivation

This PR updates:

Kubernetes libraries v0.27.1 -> v0.27.2
sigs.k8s.io/controller-runtime v0.15.0-alpha.0.0.20230511044310-c2e3d6d6350e -> v0.15.0-beta.0
sigs.k8s.io/gateway-api v0.6.0 -> v0.7.0

Kind

/kind cleanup
Release Note

Updates Kubernetes libraries to `v0.27.2`.

sigs.k8s.io/controller-runtime should release v0.15.0 soon, but I opened this to move things along.

/ok-to-test

sigs.k8s.io/controller-runtime should release v0.15.0 soon, but I opened this to move things along.

Thanks! We're planning to release cert-manager 1.12 tomorrow and this won't make it in as we're in code freeze, but I think once we have c/r v0.15 we could do a v1.12 patch.
@lucacome out of interest- I assume that you have some project where you consume cert-manager as a library?

/test pull-cert-manager-master-make-test

This is failing because kubebuilder tools have been repushed, https://github.com/cert-manager/cert-manager/pull/6078 will fix that

@irbekrm yeah we import it in https://github.com/nginxinc/kubernetes-ingress 🙂

One day maybe I'll figure out why make update-licenses doesn't work for me...maybe it's something specific to macOS on M1?

/test

/test pull-cert-manager-master-e2e-v1-27-feature-gates-disabled
/test pull-cert-manager-master-e2e-v1-22

looks like a flake
/test pull-cert-manager-master-e2e-v1-27-feature-gates-disabled

I can confirm that make update-licenses works on M1 macs with this change.

/cherry-pick release-1.12


Installation Failure platformio-atom-ide-terminal

[x] I have reset Atom to defaults prior to submitting report.
[ ] I have not reset Atom to defaults prior to submitting report.

Description

Steps to reproduce

Expected behavior:
Actual behavior:
Reproduces how often:
Versions

> atom --version

> apm --version

OS name and version:
Platformio-ide-terminal version:
Additional Information

try to install "terminus" it is a fork of platformio-ide-terminal

Had the same issue with the install Platformio IDE Terminal on Atom. I installed the package: 'terminus' , and that works for me.

same

same

Thanks, that helped.

Fixed in https://github.com/platformio/platformio-atom-ide-terminal/releases/tag/v2.10.1
Please update platformio-ide-terminal to the latest version.


We should clean up all global memory while server exit

We should clean up all global memory while server exit.
for protobuf, do it by google::protobuf::ShutdownProtobufLibrary();
for libevent, do it by libevent_global_shutdown();
for mysql client, do it by  mysql_library_end();
But for grpc, we do nothing.
If we use valgrind check memory leaks, it's too annoying.

Please take a look at the proposal relevant to this. You can use sanitizers to detect memory leaks without worrying about static global variables.


Fix #2338: Restore the bootstrap tests for 2.12.0-M4.

In the bootstrap tests, the flag for the classOf[Unit] bug of 2.12.0-M4 was not set. This caused the 3 affected tests to fail. This commit adds the flag to fix this.

Review by @nicolasstucki

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/3004/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3899/
Test PASSed.

LGTM


Added NCBIM37 to list of references for mouse

This change is

LGTM

Watch out @tavinathanson, FASTA parser coming your way.
(I'm sorry: to you, to the Hammerlab, to humanity at large)

Coverage decreased (-0.06%) to 80.065% when pulling 700a210e57dd7d1df349dad2809fd7bdcb3ff944 on add-mm9-support into 22dd18ca3c8548c1d4e05c22da543097d2fdaae8 on master.

After in-person code review LGTM 👍

Coverage decreased (-0.06%) to 80.065% when pulling 2de234894e0fcfac6eb7a67d28f4bd0173c7954c on add-mm9-support into 22dd18ca3c8548c1d4e05c22da543097d2fdaae8 on master.


Header IDs interfere with jingo

If I add a document header:
### login

...to my document then the toolbar goes away. At that point, I have to edit the file externally to fix it by changing the header name.
I think this is an exception in the Jingo javascript in the browser, but a brief review shows that there are element IDs that are easily duplicated by users that interfere with jingo's functionality. I would suggest replacing built-in element IDs with stylized names like _jingo_login or something of that sort. It would make it much more difficult for regular users (like me) to bump into them and break the wiki.

Ouch, you're right.
Let me fix this :)


Improve docker setup

Un make install sur le projet après avoir :

rm -rf client/node_modules
rm -rf server/node_modules
make rm

Les installations du client et du server se déroulent sans accroc (un peu long mais bon) puis j'ai l'erreur suivante :
➜  permacoop git:(feature/dockerization) make install
cp server/ormconfig.json.dist server/ormconfig.json
cp server/.env.dist server/.env
cp client/config.js.dist client/config.js
docker run -it --rm -v /Volumes/Elao/workspace/fairness/permacoop/server:/app -w /app node npm i

><EMAIL_ADDRESS>install /app/node_modules/argon2
> node-pre-gyp install --fallback-to-build

node-pre-gyp WARN Using request for node-pre-gyp https download
node-pre-gyp WARN Tried to download(404): https://github.com/ranisalt/node-argon2/releases/download/v0.25.1/argon2-v0.25.1-node-v79-linux-x64-glibc.tar.gz
node-pre-gyp WARN Pre-built binaries not found for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(node-v79 ABI, glibc) (falling back to source compile with node-gyp)
make: Entering directory '/app/node_modules/argon2/build'
  CC(target) Release/obj.target/libargon2/argon2/src/opt.o
  CC(target) Release/obj.target/libargon2/argon2/src/argon2.o
  CC(target) Release/obj.target/libargon2/argon2/src/core.o
  CC(target) Release/obj.target/libargon2/argon2/src/blake2/blake2b.o
  CC(target) Release/obj.target/libargon2/argon2/src/thread.o
  CC(target) Release/obj.target/libargon2/argon2/src/encoding.o
  AR(target) Release/obj.target/argon2.a
  COPY Release/argon2.a
  CXX(target) Release/obj.target/argon2/src/argon2_node.o
  SOLINK_MODULE(target) Release/obj.target/argon2.node
  COPY Release/argon2.node
  COPY /app/node_modules/argon2/lib/binding/argon2.node
  TOUCH Release/obj.target/action_after_build.stamp
make: Leaving directory '/app/node_modules/argon2/build'

><EMAIL_ADDRESS>postinstall /app/node_modules/@nestjs/core
> opencollective || exit 0

                          Thanks for installing nest 🙏
                 Please consider donating to our open collective
                        to help us maintain this package.

                           Number of contributors: 457
                              Number of backers: 370
                              Annual budget: $45,335
                             Current balance: $2,441

       👉  Become a partner: https://opencollective.com/nest/donate

npm WARN<EMAIL_ADDRESS>No repository field.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/watchpack/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

added 1472 packages from 1045 contributors and audited 1543 packages in 241.228s

16 packages are looking for funding
  run `npm fund` for details

found 2 low severity vulnerabilities
  run `npm audit fix` to fix them, or `npm audit` for details
docker run -it --rm -v /Volumes/Elao/workspace/fairness/permacoop/client:/app -w /app node npm i

><EMAIL_ADDRESS>postinstall /app/node_modules/core-js-pure
> node -e "try{require('./postinstall')}catch(e){}"

Thank you for using core-js ( https://github.com/zloirock/core-js ) for polyfilling JavaScript standard library!

The project needs your help! Please consider supporting of core-js on Open Collective or Patreon:
> https://opencollective.com/core-js
> https://www.patreon.com/zloirock

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

npm WARN<EMAIL_ADDRESS>No description
npm WARN<EMAIL_ADDRESS>No repository field.
npm WARN<EMAIL_ADDRESS>No license field.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

added 986 packages from 447 contributors in 232.3s

27 packages are looking for funding
  run `npm fund` for details

make start
docker-compose -p permacoop up -d
Creating volume "permacoop_uploads" with default driver
Creating permacoop_database_1 ... done
Creating permacoop_api_1      ... done
Creating permacoop_client_1   ... done
make api-build-dist
docker-compose -p permacoop exec npm run build
ERROR: No such service: npm
make[1]: *** [api-build-dist] Error 1
make: *** [install] Error 2

Les deux dernières commandes api-build-dist et database-migrate n'ont pas le context api pour être lancé. Je fix ça

@NicolasDievart oups oubli quand j'ai refacto les commandes. Merci


Release Google.Cloud.Logging.Type version 3.5.0

Changes in this release:
New features

KMS configuration in settings (commit 07fd1d2)

Created release for Google.Cloud.Logging.Type-3.5.0


Feat(eos_cli_config_gen): Add support for ingress in system.control_plane.ipv4/6_access_group

Change Summary
Add support for ingress in system.control_plane.ipv4/6_access_group
s1-spine1(config-system-cp)#ip access-group ?
  WORD     Access list name
  ingress  Specify default CP ACL for inbound packets

s1-spine1(config-system-cp)#ipv6 access-group ?
  WORD     Access list name
  ingress  Specify default CP ACL for inbound packets

Related Issue(s)
Fixes #4467
Component(s) name
arista.avd.eos_cli_config_gen
How to test
CI
Checklist
Repository Checklist

[x] My code has been rebased from devel before I start
[x] I have read the CONTRIBUTING document.
[x] My change requires a change to the documentation and documentation have been updated accordingly.
[x] I have updated molecule CI testing accordingly. (check the box if not applicable)

Moving to draft since we the changes needs to be reworked to match EOS CLI. Reach out if we need to discuss.

Closing this PR and fixing the issue in PR: https://github.com/aristanetworks/avd/pull/4710


Remove ParentRefNotPermitted

While testing v0.6.1 we found that we had included a new type that was not needed. This PR reverts the relevant changes.
Special thanks to @skriss and @mlavacca for your assistance!

Thanks @shaneutt @mlavacca and @skriss!
/lgtm


Bug in repetition of comments

Comments are being repeated after synchronizing a PR.

And that is because the hyperlinks to the blob changes after new commits. These two 1 2 comments are actually not same.


Fix inconsistency in how async API throws exception

Examples:
CreateScannerAsync wraps exception into Task and throws when awaited
public async Task<ScannerInformation> CreateScannerAsync(string tableName, Scanner scannerSettings, RequestOptions options)
{
    tableName.ArgumentNotNullNorEmpty("tableName");
    scannerSettings.ArgumentNotNull("scannerSettings");
    options.ArgumentNotNull("options");
    return await options.RetryPolicy.ExecuteAsync(() => CreateScannerAsyncInternal(tableName, scannerSettings, options));
}

DeleteScannerAsync throws exception right away:
public Task DeleteScannerAsync(string tableName, ScannerInformation scannerInfo, RequestOptions options)
{
    tableName.ArgumentNotNullNorEmpty("tableName");
    scannerInfo.ArgumentNotNull("scannerInfo");
    options.ArgumentNotNull("options");
    return options.RetryPolicy.ExecuteAsync(() => DeleteScannerAsyncInternal(tableName, scannerInfo, options));
}

A fix can be considered as a breaking change.

@alexandrnikitin
Thanks for reporting, I will take a look.

Thank you for reporting :+1:

@alexandrnikitin
I have made a change to make all APIs async and remove sync APIs to avoid user confusion. I will publish a new nuget package soon.


Syntactic Filter

Fix #25.
Syntactic check is done by traversing block-statement graph.
The statements must be represented as a series of subtrees, with roots being a continuos sequence of statements on same block. All such subtrees must be covered fully with statements from extraction opportunity.

I recommend redo the test interface and pass line ranges. It's more intuitive and does not depend on ID assignment which we do not control here.

Fixed.

I will postpone merging this PR till #32


[code suggestion] GetConfigured*EnabledValue() → GetConfiguredEnabledValue(variable)

Description of the new feature / enhancement
Idea came to me via pr #29325 at https://github.com/microsoft/PowerToys/pull/29325/files#r1367455714
Here's a list of things like GetConfiguredAlwaysOnTopEnabledValue() for every module. This looks very redundant and uneasy to modify when a module needs to be added (or removed). I was thinking a function/method like GetConfiguredEnabledValue("AlwaysOnTop") would be better, because then we can use (an array with) module names to loop through. This will allow to simplify or "compress" lots of code.
At the very least it will also be more readable :)
Scenario when this would be used?
Smooth code?
Supporting information
No response

@ethanfangg Who can I ping for this?


Increased p2p Traffic on Relay Chain

Is there an existing issue?

[X] I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

[X] This is not a support question.

Description of bug
After a recent client upgrade on Moonbeam, we are seeing a drastic increase in p2p traffic on the relay side. The traffic is associated with numerous peer connections which never seem to be reflected as connected peers. A workaround is to use --reserved-only, likely because it disables automatic peer discovery.
You can see here the effect of running a node without --reserved-only (on the left of each graph) and restarting it with --reserved-only (on the right):

Note particularly that the number of connections is volatile after the restart for a brief time before dropping to its expected steady-state.
This problem isn't mitigated by restricting --in-peers and --out-peers.
Perhaps related: #12799
Steps to reproduce

run with and without --reserved-only and observe network stats
OR compare e.g. a Kusama/Polkadot client on <= v0.9.26 vs >= v0.9.27
OR compare moonbeam client <= v0.26.1 vs >=  v0.27.0 (observed only on Relay client, not parachain)

Any thoughts on this? We have a workaround, but consider it very much temporary as it isolates our nodes into an island.

I am looking into this and #12799 and I can confirm that there is an increase in the bandwidth usage between versions  v0.9.26 and v0.9.27. It looks like v0.9.27 is able establish and maintain more connections which could explain this increase in bandwidth. The behavior of v0.9.26 could be related to #12217
Is it possible that the lower right graph is incorrectly displaying only reserved peers? If you graph substrate_sub_libp2p_peers_count or substrate_sync_peers does it show similar pattern if you run the node with and without --reserved-only?

I've been analyzing the network traffic this morning and I can't find anything concerning in the network usage. During startup more bandwidth is used which seems to be associated with the number of connections the node has open as it switches between 20 and 50 connected peers but after the startup, the node count stabilizes and the average bandwidth between the two versions is basically the same. This instability during startup is something that warrants further research to see if we can somehow fix it and reduce the bandwidth consumption.
I'll close this in favor of #12217 and try to get working on that issue soon
Can you describe the workaround you have in place?

@altonen Thanks for looking at this issue. The bottom right graph is displaying substrate_sub_libp2p_peers_count, and the metric substrate_sync_peers is showing the exact same thing.
For the workaround. We have a set of full nodes running as peering nodes, these nodes have all the other nodes as reserved nodes, all the other nodes are having the peering nodes as reserved nodes.
So the trick is to set the in-peers = 0, and the out-peers = number of peering nodes, in addition to enable the --reserved-only flag.
Config before 12:25:
--in-peer=0
--out-peer=#peering nodes

Config after 12:25:
--in-peer=0
--out-peer=#peering nodes
--reserved-only

Does reducing the number of inbound light peers using --in-peers-light <num> fix the issue?

@purestakeoskar
This issue can be closed?


chore: disable instances causing trouble with etaExperiment

This presumably defeats whatever the point of @negiizhao's leanprover-community/mathlib#17564 was. Perhaps they can comment on the motivation, since the original PR didn't.

<EMAIL_ADDRESS>

bors r+


Sheetsync does not pick up Tech Test/Preshow sheet

In my testing, I noticed the sheet sync doesn't pick up the Tech Test & Preshow sheet, since it doesn't fall in the Day 1-7 format.
I'm guessing the simplest way to do it would be to change the worksheets array in the docker compose to an arbitrary list of sheet names instead of a generated one in a specific format; or have two arrays (one generated, one arbitrary) that get joined together.

This is a pretty simple config issue, just need to add it to the top of docker-compose.jsonnet as an addition to the existing Day N list.


fix noise 2

[x] Remove 2 bytes header from hanshake messages
[x] Split noise payload in 65Kb chunks

Thanks, I'll wait for your second todo item.

I'm not sure if you already rebased, but try the following to get rid of my commits in the PR:
# assuming 1 commit from you
git rebase HEAD~1 --onto Sjors/2023/11/sv2-poll

I changed a few things before merging:

std::span -> Span (see src/span.h, though this might change again with the move to c++20)
added a constant INITIATOR_EXPECTED_HANDSHAKE_MESSAGE_LENGTH = 170

I tested against your stratum branch https://github.com/stratum-mining/stratum/compare/dev...Fi3:stratum-1:UpdateNoise though only on my custom signet, which generally doesn't have long messages.
I'll test on mainnet later.
I guess I should run an inscription tool to get >65KB messages on signet :-)
I also plan to add some more length check asserts, and rename SendMsg in noise.h to WriteMsg, to prevent confusion between creating the message and actually sending it.

Changes squashed into 945838fca264c8469e24d629a4552741dbbd4dda and 945838fca264c8469e24d629a4552741dbbd4dda.
Can you take a look at key_tests.cpp, as this now fails with  memory access violation at address: 0x1: no mapping at fault address around line 35. Not sure if that's because of the changes here or because of my rebase. I'll also take a look later.


Fix $ref locations in 3.0 spec

Numerous places in the 3.0 spec have $ref: '#/definitions/[n]', but shouldn't they be referencing $ref: '#/components/definitions/[n]'?
If my understanding is correct I can open a PR?

that is correct.  we are considering that as a secondary documentation step since there are major changes coming in the current one, and markdown isn't great for merging.  But do feel free to make that change in a PR.

I believe all of these issues have now been resolved.


refactor(recommend): backwards comaptibility

AMLOS-548
Description
Refactor Recommender Logic to support old storage format when retrieving records
Acceptance Criteria
Recommender Logic to support old storage format when retrieving records is refactored
How to test code
make shell
data = {'Bookmark Collaborative Filtering': {'recommendations': [[2, 2.0], [96, 1.0], [68, 1.0], [69, 1.0], [70, 1.0], [9, 1.0], [10, 1.0], [44, 1.0], [77, 1.0], [14, 1.0], [47, 1.0], [81, 1.0], [82, 1.0], [147, 1.0], [90, 1.0], [101, 1.0], [63, 1.0]], 'ms_took':<PHONE_NUMBER>875, 'weight': 5.0}, 'Baseline': {'recommendations': [[186, 11.5], [10, 10.0], [9, 9.2], [14, 9.0], [82, 9.0], [96, 9.0], [101, 9.0], [158, 9.0], [2, 8.0], [23, 8.0], [30, 8.0], [147, 8.0], [47, 7.0], [70, 7.0], [73, 7.0], [159, 7.0], [162, 7.0], [178, 6.7], [18, 6.5], [77, 6.3]], 'ms_took':<PHONE_NUMBER>875, 'weight': 1.0}}
import msgpack; r_e = RecommendationsEntry.objects.filter(target_profile__user__username='bigbrother').first(); r_e.recommendation_data = msgpack.packb(data); r_e.save()

################
from ozpcenter.api.storefront.model_access import RecommenderProfileResultSet
f = lambda: '' if [RecommenderProfileResultSet.from_profile_instance(profile) for profile in Profile.objects.all()] else ''
f()
2018-02-13 15:34:51,177 - WARNING - recommend - User [bigbrother][1] has old format for RecommendationsEntry data

In a different terminal window
curl 'http://<IP_ADDRESS>:8001/api/storefront/recommended/?format=json' -H 'Cache-Control: no-cache' -H 'Authorization: Basic YmlnYnJvdGhlcjpwYXNzd29yZA==' --compressed

Under the other terminal window running in the backend
2018-02-13 15:05:42,199 - WARNING - recommend - User [bigbrother][1] has old format for RecommendationsEntry data

make ptest
Please Review
@aml-development/ozp-backend-team
Checklist

[x] Read CONTRIBUTING.md
[x] Write code to complete task
[x] Python Code is PEP8 Compliant
[x] Add unit tests for new code
[ ] All tests must pass before merging the pull request
[ ] At least 2 people reviewed code

:+1:

:+1: got warning as desired, no errors thrown


Din Font not supported

Although it is available almost everywhere in the Desktop application, attempting to format to DIN using a JSON file does not work.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8d9a8511-6ff9-78c6-5a8c-3f5ac68224d0
Version Independent ID: f4fd28c7-71fa-a776-7154-e76eb9bd3649
Content: Use Report Themes in Power BI Desktop - Power BI
Content Source: powerbi-docs/desktop-report-themes.md
Service: powerbi
GitHub Login: @davidiseminger
Microsoft Alias: davidi

Thanks for your feedback @JoshBaruch. You might find a solution in the Power BI Community, found at https://community.powerbi.com. If not, you can get support by going to https://support.powerbi.com.


bugfixes/adjustments

slash draw didn't use magic number
another moment would count both skills played and skills it had exhausted, which resulted in each skill counting for 2 instead of 1
lunacy's upgrade was missing text of "lose 1 sanity", when it only lost the hp loss effect
recode black market dealer event with thing I added to basemod
Also adjusted so it chooses 2 of 3 to be available instead of just 1 because it feels really pointless to just have a screen with 1 option
Make AbstractDungeon.getRandomCard return a card from all packmaster cards if pools are not yet initialized (fixes crash with insanity modifier for custom runs)
Add None option to custom draft. If someone enables only one pack and crashes it's their own fault :)
(needs chinese translation for UI option)

I'm not sure we want the "none" option for custom draft. Having functionality that causes crashes when used in a natural way (e.g. turning off all but one or two packs like people have wanted to do) isn't good. Letting people do that without any warning implies that its a first-class feature that we fully support, just like everything else. But that's not true because of the many unsolvable crashes/freezes it can cause, but people will report crashes anyway.
I think the status quo of not having this option at all is a good place to be. It is okay for us to simply not address the feedback from people saying that they want to play with only one or two packs enabled. So my vote is to remove this from the PR.
However, if we really think that adding this option is a positive, we should at least put it behind a config option in the mod config menu with a label like "Allow less than 7 packs in custom draft (may cause crashes)", defaulting to off. That will appropriately convey that this is something we do not fully support and limit the use of a feature we don't really want to support. But I think it's simpler and better to just not include this at all.

Looking at the code, there is not extra logic to disable the filtering so you can only disable 1 pack with the none option.
I think I did the math for that at some point and it's not possible to run into a crash with that, so I'm fine with merging.

I'll fix it myself


Custom mpv profile

Is it possible to use mpv with a custom profile (eg mpv --profile=tidal-cli)?

Currently not, adding to my ToDo list.


Orca v0.1 - C + Python

Thanks for the feedback so far. One of the missing things is the RPI 5 Runner, and I will need to update the libs once more.

This is good to go from my side


systemd: disable NSCD when DNSSEC validation is disabled in timesyncd

Description of changes
When a system has a significantly wrong date and time timesyncd is unable to synchronize it because DNSSEC doesn't work. In order to break this chicken and egg problem systemd-timesync disables DNSSEC validation by setting SYSTEMD_NSS_RESOLVE_VALIDATE=0 in the unit file. However, it doesn't work in NixOS because it uses NSCD.
This patch disables NSCD in systemd-timesyncd when SYSTEMD_NSS_RESOLVE_VALIDATE is set to 0 so that it uses NSS libraries directly. In order for it to be able to find the libnss_resolve.so.2 library it also adds the systemd directory to the LD_LIBRARY_PATH.
Fixes #174173
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

There was some discussion about this issue with @arianvp here

This needs to target staging, please look at contributing.md to avoid people getting mass -pinged while changing branches.

Thanks! I wonder if there's any way we can test this in a VM test, but time obviously is complicated : 🤔

Thanks! I wonder if there's any way we can test this in a VM test, but time obviously is complicated : thinking

Just LD_PRELOAD a preeny time library in systemd-timesyncd?

Thanks! I wonder if there's any way we can test this in a VM test, but time obviously is complicated : thinking

Yeah, unfortunately I'm not familiar with VM test but here is my manual test procedure, just in case:

Stop timesyncd: sudo systemctl stop systemd-timesyncd
Delete the clock file: sudo rm /var/lib/systemd/timesync/clock
Set a wrong date and time: sudo date 01010101
Start timesyncd: sudo systemctl start systemd-timesyncd
DNS doesn't work and timesyncd is unable to get the correct date and time but with this patch it all works fine because timesyncd uses libnss_resolve.so.2 directly and it gets SYSTEMD_NSS_RESOLVE_VALIDATE=0.
This is only applicable when DNSSEC is enabled.

I think this definitely needs a nixos style test of some kind. But also, is this a nixos specific thing? If not it definitely needs to be upstreamed and a link to the systemd PR needs to be commented.

Systemd closed the upstream PR.  See the discussion that was linked by OP

still not grokking why you are not just using userdbd+resolved on nixos (i.e. ship nss-resolve + nss-systemd wherever you include glibc), but whatever. doubling down on nscd in 2022/2023 is so backwards, folks. In particular because glibc falls back to local NSS when nscd doesn't react after a very shot time-out. Which makes it useless for your case.
Anyway, apparently nixos will solve this. Closing here.

still not grokking why you are not just using userdbd+resolved on nixos (i.e. ship nss-resolve + nss-systemd wherever you include glibc), but whatever. doubling down on nscd in 2022/2023 is so backwards, folks. In particular because glibc falls back to local NSS when nscd doesn't react after a very shot time-out. Which makes it useless for your case.

Do we know what we lack to actually do this? (also, you mentioned BDFL, what are you referring to?)

still not grokking why you are not just using userdbd+resolved on nixos (i.e. ship nss-resolve + nss-systemd wherever you include glibc), but whatever. doubling down on nscd in 2022/2023 is so backwards, folks. In particular because glibc falls back to local NSS when nscd doesn't react after a very shot time-out. Which makes it useless for your case.

Do we know what we lack to actually do this? (also, you mentioned BDFL, what are you referring to?)

https://github.com/NixOS/nixpkgs/pull/111194 would allow us to implement this
With bdfl i meant Eelco. He wants to come up with a solution to keep old binaries working without nscd. The linked PR is such a solution

Thanks! I wonder if there's any way we can test this in a VM test, but time obviously is complicated : 🤔

Here is a test idea that came to my mind:

Enabled systemd-resolved with DNSSEC.
Setup a dummy domain name using a simple local DNS server with no DNSSEC.
Enable systemd-timesyncd and use the dummy domain as an NTP server.
Enable debug log level in systemd-timesyncd and read the output.
Without this patch it fails to resolve the domain name but when the patch is applied it successfully resolves it and tries to connect.

I’ve updated the commit with the test and rebased.

I successfully ran the test (again), and ensured it (still) fails (as expected) if the patch and LD_LIBRARY_PATH override are not present.
I did notice it also succeeds eventually with just LD_LIBRARY_PATH being set in the module system (I assume that's the nscd fallback after some timeout logic kicking in), but I still think having the patch is cleaner.
We know it can't work over nscd protocol in these cases, so we should disable it explicitly, rather than relying on that fallback-after-timeout behaviour in glibc.


level and min / max

In level why the default values are 0 and maxValue rather than the current minValue and the current maxValue ?
https://github.com/image-js/image-js-typescript/blob/main/src/filters/level.ts#L59-L66
Currently it is difficult to increase the contrast because we need the current min and max.
If all the default values where current min / max we could write:
image.level({outputMin: 0, outputMax: image.maxValue}) to increase the contrast.

It is possible that I mixed something up. I'll check it out next week.


Paymetheus must show its current version

I again and again ask myself whether I run the latest versíon of Paymetheus. I just cannot find out! It is a very good practice to display the version of the software, either in the window header or at least somewhere in one of the separate looks.
Add the current version (e.g. 1.05) to the window title line!

I agree; version number should be visible in the window header / title, or in a view within the running wallet.  In the meantime, version can be determined by locating the Paymetheus.exe file and looking at the "File Version" property.

Wow, someone has finally read it! After almost 3 months! I meanwhile thought that Paymetheus / Decred was a dead project without any serious developers.


Search bar loses focus after screen rebuild in Users section

Describe the bug
In the Users section, the search bar loses focus during screen rebuilds after typing, requiring users to manually reclick the search bar to continue typing.
To Reproduce
Steps to reproduce the behavior:

Go to Users section
Click on the search bar
Start typing any search term
4.The search bar loses focus after screen rebuild
5.Need to click the search bar again to continue typing

Expected behavior
The search bar should maintain focus throughout the typing process and subsequent screen rebuilds, allowing users to type continuously without having to reclick the search bar, similar to how it works in other sections of the application.
Screenshots
https://github.com/user-attachments/assets/b3fcc715-d2b2-4c31-a961-9f3dcf97196b
Desktop :

OS: Linux (Arch)
Browser: Chrome

Additional context
This issue is specific to the Users section. The search functionality works as expected (maintains focus) in all other sections of the application where search is implemented.

@rithviknishad I would like to work on this issue.

Hey @rithviknishad @Jacobjeevan  I would like to take up this issue

no longer relevant in new architecture


Fixed TypePropagation for linalg.dot with i1

Thanks!
But if we have so many i1 ops coming through, this would not be the best way to handling them... We are effectively doing everything in i8.

These are coming from the jax unittests so I would expect its more completion testing. Agree that converting the i1 operations to i8s feels silly. Do we have a plan for sub-byte operations? I know there is a lot of hype over i4 operations for LLMs.

Thanks!
But if we have so many i1 ops coming through, this would not be the best way to handling them... We are effectively doing everything in i8.

These are coming from the jax unittests so I would expect its more completion testing. Agree that converting the i1 operations to i8s feels silly. Do we have a plan for sub-byte operations? I know there is a lot of hype over i4 operations for LLMs.

For the most part IREE itself doesnt do anything with the types (except for sub-byte types which we need to expand to byte accesses otherwise we get errors in the final lowering). I dont have anything right now that solves this problem. Best I can think of is something that converts a memref<?x?xi1> into a memref<?x?x<vector<8xi1>> and then make sure we handle those all the way... thats seems to be the simplest way of handling sub-byte types....


Saving Attachments

Please excuse me if there's an obvious answer to this as i'm new to rails and github, but I can't seem to find the save_attachments_to method...
Also it seems that the "message" method is private so the attachments saving function isn't implemented in the most recent version of this - correct?
Thanks so much for putting this together and for your help.

This issue was moved to gmailgem/gmail#14


⚠ Bofrost.fr has degraded performance

In a8c7134, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1543 ms

Resolved: Bofrost.fr performance has improved in c718768 after 7 minutes.


[$1000] Web – Inconsistent order of items in FAB (New) and Actions in composer.

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open any chat
Click the “Actions” plus sign in composer
Notice that the order of items are from top “Request Money”, “Send Money” & “Assign Task”.
Now click FAB “New” on left side.
Notice that the order of items that are present in the composer too, are from top “Send Money”, “Request Money” & “Assign Task”.

Expected Result:
The order of items should be consistent in both cases to maintain uniformity.
Actual Result:
Inconsistent order of items in FAB (New) and Actions in composer.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.37-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/93399543/d110e702-a80e-4c15-907e-e8911a97992d
Expensify/Expensify Issue URL:
Issue reported by: @usmantariq96
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688634881745739
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0186ae3955d5311248
Upwork Job ID:<PHONE_NUMBER>899808256
Last Price Increase: 2023-07-13

Will review today!

Reviewing today, got caught up sorry!

Proposal from @namhihi237 looks good to me https://github.com/Expensify/App/issues/22365#issuecomment-1624164996
🎀 👀 🎀 C+ reviewed

Proposal
Please re-state the problem that we are trying to solve in this issue.
The order of items in the Composer FAB and the Report Options is not the same
What is the root cause of that problem?
The item order for FAB button is defined here
The possible Options in the Report are defined as object here. These options are mapped against the function ReportUtils.getMoneyRequestOptions.
The order of items for the Option pane is therefore determined by the order of returned options of this function here.
The entries of the returned array of allowed Options are in different order than the Option list specified for the Composer FAB, resulting in inconsistent appearance.
What changes do you think we should make in order to solve the problem?
Updating the function ReportUtils.getMoneyRequestOptions to return the Option array in order of the FAB Options.
Result:
https://github.com/Expensify/App/assets/139258421/348514c1-fcb4-4ef2-8840-7388d0a70372

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01ec3e40c95bfc76c9?viewMode=1

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01ec3e40c95bfc76c9

Hey @dylanexpensify @narefyev91 I'm going OOO for 2 weeks (starting on July 17th, back on July 31st) so can we re-assign this to another engineer?

🎀 👀 🎀 C+ reviewed

@dhairyasenjaliya you are right - i think @mountiny we can close this one

Actually not sure if that is important, going to go ahead and close this one out


Create new account issue in pangea Testnet mobile app not working

Steps to replicate the issue

Install the Pangea Testnet mobile app
Click on "Create Account."
Click on " Next "button and Remember Passphrase on Create Passphrase on the page
Then click on "Next " and follow the instructions
Click on "Accept" button on the Terms and Conditions page
Click on check box on human verification page
Click on "Create Account."
What do you expect to happen?
When clicking on "Create Account"  on "The Human Verification Page. The next page should be open.

What actually happens
It does not go further
Your environment

Pangea Testnet Mobile app
Operating system:- Android13
Pangea Testnet version:- 0.73.0

Works as expected.


Nginx self-signed certificate creation

depends on #61 and #62

I'd thought of adding optional env var cert/key data injection as well, but think this is enough for an iterative improvement


Can't install Kap

When I try to install Kap, I get the message:

"Kap" can't be opened because Apple cannot check it for malicious software.
This software needs to be updated. Contact the developer for more information.

macOS version: Mac 11.6 - Big Sur
Kap version: 3.4.0
Steps to reproduce
Download Kap from https://getkap.co/. Double click to install. Try opening it.
Current behaviour
I can't open Kap after download - I get the above error message.
Expected behaviour
I should be able to open it. I have it running on my other computer.
Workaround
None

Right-click the app and select "Open". You only need to do this once.

Ah right, I forgot about this. Thank you!!


BaF3: add TrackMate data

Adds tracking data from TrackMate, generated by @pcmasuzzo. The only differences with the original datapackage are:

dp.json renamed to datapackage.json
altered some names in the above file to make it compliant with the specs (see CellMigStandOrg/cell_track_dpkg#3)

Opening this mainly for discussion re: standardization, since I've found it awkward to modify the overlay notebook to accommodate for multiple packages. Specifically, see the time_col, x_col, etc. mappings: we wouldn't need these if we included in our version of the format a standard way to refer both to tabular file names and to column names within them. We can either agree on fixed names for all these entities or add a level of indirection, i.e., something like the .ini file currently used to generate datapackages in https://github.com/CellMigStandOrg/cell_track_dpkg. However, since the file containing name mappings would have to be itself included in the package, we should probably hardwire file names and use mappings only for column names.
The other issue is that TrackMate object coordinates are in physical size (µm in this case), so I had to retrieve the scaling factor from the metadata and apply it to the plot in order to make things match. The standard should either expect pixel-based XY coordinates that directly map to the images (meaning the datapackage generator should ensure this) or support some way of expressing any required conversion.

Overall, :+1: for working from multiple examples rather than one (as it forces us to consider the standardization of fields). Merging this and I will comment on the issue separately.


Bump gems and improve makefiles

Bumps some of the gems used by the compliance service integration tests.
Make some improvements to the compliance service and node manager makefiles.
 Thank you!
$ git commit -s -m 'Replace to_hash with to_h'
[ap/makefile-improvements 89b35c8b6] Replace to_hash with to_h
 3 files changed, 5 insertions(+), 5 deletions(-)

$ git push
Warning: Permanently added 'github.com,<IP_ADDRESS>' (RSA) to the list of known hosts.
To github.com:chef/automate
 ! [rejected]            ap/makefile-improvements -> ap/makefile-improvements (fetch first)
error: failed to push some refs to 'git@github.com:chef/automate'


Add a db-based namespace service

The NamespaceService implementation in use here is file-based, which is really only appropriate for single-node deployments. Since the ResourceService is already using a database connection, it seems to make sense to add a table for storing namespace prefixes. That way, a multi-node server will be storing less data on the filesystem.

👍


[Feature] enable host memory for kv cache

Optimal conditions for this feature:

The token count of your prompt significantly exceeds that of the generated output.
The commonly used prompt prefix length is substantial, leading to a high cache hit rate.
Your machine's GPU memory is insufficient to accommodate enough prefix key-value caches, resulting in a reduced cache hit rate.

Main idea
In the scenario described above, offloading key-value caches to host memory could be advantageous. The implementation is straightforward: we already have CPU blocks within the block manager, although they are currently designed exclusively for sequence preemption. Since CPU and GPU blocks share the same underlying block structure, we can store computed key-value cache blocks within CPU blocks.
With this approach, each time a GPU block is freed, we add it to the CPU allocator via swapping. When allocating immutable blocks, we first search the GPU allocator. If a GPU cache hit occurs, we proceed with the cached GPU block as usual. If no hit is found, we additionally check the CPU allocator, and in the event of a CPU cache hit, we swap the CPU block back to the GPU and eliminate the recomputation.
Originally, the block allocation logic without preemption:

Now we utilize the CPU blocks:

Note that the computed blocks in the CPU allocator are stored only in the evictor, and this change will not impact the original preemption logic.
Usage
Launch the vllm engine with
--enable-prefix-caching --enable-host-memory-caching --swap-space 48

in which --swap-space configures the host memory for both kv cache and preemption.
Shortages
If host memory for the KV cache is enabled, each GPU block added to the evictor will be swapped to host memory, potentially leading to a performance drop. Therefore, ensure that enabling the host memory KV cache will significantly improve your cache hit rate. In our case (4090*1), if the cache hit rate is below 20%, enabling this feature will result in a performance degradation.
I’ve marked this PR as a draft because I’m not sure whether it will be useful for the main users, and the modification of the code is somewhat intrusive. Please provide feedback if you think it is beneficial, and I look forward to hearing your thoughts.

 PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Adding or changing kernels
Each custom kernel needs a schema and one or more implementations to be registered with PyTorch.

Make sure custom ops are registered following PyTorch guidelines: Custom C++ and CUDA Operators and The Custom Operators Manual
Custom operations that return Tensors require meta-functions. Meta-functions should be implemented and registered in python so that dynamic dims can be handled automatically. See above documents for a description of meta-functions.
Use torch.libary.opcheck() to test the function registration and meta-function for any registered ops.  See tests/kernels for examples.
When changing the C++ signature of an existing op, the schema must be updated to reflect the changes.
If a new custom type is needed, see the following document: Custom Class Support in PT2.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

Looks like the function you propose can be covered by LMCache or kv cache offloading? cc @KuntaiDu

Yes, I personally see it as a temporary solution that is compatible with the main code.


Cortex-V2 / Node-red : "Please ensure that you have Cortex installed and running in the background"

Hello,
I am actually testing EmotivBCI Node-RED Toolbox. Although EmotivApp and Emotiv BCI are open and running, Node-Red displays the following message "Please ensure that you have Cortex installed and running in the background".
(I followed all the emotiv gitbook's instructions (Nodejs, Node-red and Node-red-contrib-emotiv-bci are correctly installed on the computer, my emotiv Insight is connected and I have a training profile with mental commands)
How can I solve this issue ?
Thanks,
Paul

Hello i am having the same issue and couldnt solve it myself. I imagine it os a recent problem since everyone was okay before

Maybe it's possible to switch back to cortex V1 until it works ?

did you run same version of node-red and Cortex ?

I run the latest versions of both of them. It seems to be something about websockets maybe when i run example with a manual cresential and secret i get from emotiv andchange the path to my local host example works

Hi @Paulhb7
First, you must check if you are using Cortex version 1.x or version 2.0
Just look at the version displayed by EmotivBCI, on the top of the window
Then check this page to know how to install the correct version of the node red toolbox
https://www.npmjs.com/package/node-red-contrib-emotiv-bci
If it still doesn't work, then you should contact the EMOTIV customer support.

Example stops right before createsession function if you dont run it manually with the latest versions .i dont know if it was meant to be.

Hello again i fixed the node red problem for myself what you need to do is go to node red contrib emotiv file in your node modules and change the clientid and clientsecret parameters from single quote  to double quote (from '  ' to "  ") and change websocket path to wss://localhost:6868/com.emotiv.noderedtoolbox in single quote and fire node red again

Working !


[ENH] Migrate the summary plot to niworkflows

Updated look and feel (basically removing distracting elements). The colorbar of the carpetplot is:
blue=cortical regions
orange = deep gray matter
green = cerebellum
red = white and csf

Further iterations over this will include reading in a confounds file (instead of passing independent text files) and allowing for a list of labels to select which confounds are being plotted. The idea behind this is fixing poldracklab/fmriprep#174 and poldracklab/fmriprep#877 in one shot.


Support to host the taskhub as part of a vanila asp.net core webapp

Hi,
I see that the durabletask framework is touted to run on serverless. Is it possible for me to host the worker/taskhub inside an asp.net core web application? The worker will be part of an application which is hosted on a VM and due to other technical requirements, serverless is not an option to host the app.
Can anyone point me to good examples where the taskhub is hosted in normal app as a background worker? I couldn't find any examples/documentation of this will look like.

You can run the Durable Task Framework in any .NET app.  There's no requirement for serverless. You can find some examples (though they are quite old) here.
@jviau I believe you also have some extensions that make integration with ASP.NET more natural, right? Would you be able to share a link to those?

Thanks @cgillum. Also I couldn't find any API to set custom status like in azure runtime. Am I missing some using statement or it's not available yet.
If not available, what would you recommend to store custom status for an instance or activity.

Thanks @jviau and @cgillum. Closing this as my queries are answered.


NPE when using repeat step with query.batch=true

Version: Titan 1.0.0
This query works without issue with query.batch off.
Steps to reproduce using toy data with the relevant portion of the exception.
gremlin> graph = TitanFactory.open('./conf/titan-cassandra.properties')
==>standardtitangraph[cassandrathrift:[<IP_ADDRESS>]]
gremlin> g = graph.traversal()
==>graphtraversalsource[standardtitangraph[cassandrathrift:[<IP_ADDRESS>]], standard]
gremlin> v1 = graph.addVertex('id', 1)
==>v[4192]
gremlin> v2 = graph.addVertex('id', 2)
==>v[4096]
gremlin> v1.addEdge('knows', v2)
==>e[170-38g-28lx-35s][4192-knows->4096]
gremlin> g.tx().commit()
gremlin> g.V().has('id', 1).emit().repeat(out('knows'))
10:10:49 WARN  com.thinkaurelius.titan.graphdb.transaction.StandardTitanTx  - Query requires iterating over all vertices [(id = 1)]. For better performance, use indexes
==>v[4192]
java.lang.NullPointerException
Display stack trace? [yN] y
java.lang.NullPointerException
	at com.thinkaurelius.titan.graphdb.tinkerpop.optimize.TitanVertexStep.flatMap(TitanVertexStep.java:95)
	at org.apache.tinkerpop.gremlin.process.traversal.step.map.FlatMapStep.processNextStart(FlatMapStep.java:47)
	at com.thinkaurelius.titan.graphdb.tinkerpop.optimize.TitanVertexStep.processNextStart(TitanVertexStep.java:88)
	at org.apache.tinkerpop.gremlin.process.traversal.step.util.AbstractStep.hasNext(AbstractStep.java:140)
	at org.apache.tinkerpop.gremlin.process.traversal.step.util.ExpandableStepIterator.next(ExpandableStepIterator.java:54)
	at org.apache.tinkerpop.gremlin.process.traversal.step.branch.RepeatStep$RepeatEndStep.standardAlgorithm(RepeatStep.java:230)
	at org.apache.tinkerpop.gremlin.process.traversal.step.util.ComputerAwareStep.processNextStart(ComputerAwareStep.java:47)
	at org.apache.tinkerpop.gremlin.process.traversal.step.util.AbstractStep.hasNext(AbstractStep.java:140)
	at org.apache.tinkerpop.gremlin.process.traversal.step.branch.RepeatStep.standardAlgorithm(RepeatStep.java:143)
	at org.apache.tinkerpop.gremlin.process.traversal.step.util.ComputerAwareStep.processNextStart(ComputerAwareStep.java:47)
	at org.apache.tinkerpop.gremlin.process.traversal.step.util.AbstractStep.hasNext(AbstractStep.java:140)
	at org.apache.tinkerpop.gremlin.process.traversal.util.DefaultTraversal.hasNext(DefaultTraversal.java:117)

Hi,
I think this error might be related to: https://groups.google.com/forum/#!topic/gremlin-users/dLr31SyRuk0.
It seems as if .emit().repeat() doesn't work on a multi-threaded environment at all, which might be the source of the query.batch issue as well.
Effy

I have experienced this issue in 1.0 as well. Basically can't take advantage of query.batch until it is fixed.

I posted a question related to this on the TinkerPop dev list to get some insight into possible repeat step interactions with graph provider optimizations (multi query in this case) and got some good feedback.
First thing first, I'm going to see how Titan runs the TinkerPop test suite and see if I can get it to run with this query.batch=true.  I know there are Titan specific tests with batching on, but I'm assuming since this NPE doesn't happen during the full TP3 test run, it may not be enabled for that case.

Any progress in investigating this problem ?

I added runners for the TP 3 tests with query.batch=true with this PR: https://github.com/thinkaurelius/titan/pull/1190
I was planning on using that as a jumping off point to do further analysis because it uncovered around 60 or so failures when I ran it that seem to be a result of the multiquery optimization steps.


Problem with children in external libs

I've managed to convert my project to preact and it works perfectly except for one library (https://github.com/mzabriskie/react-draggable DraggableCore). It breaks on this code specifically:
render() {
    // Reuse the child provided
    // This makes it flexible to use whatever element is wanted (div, ul, etc)
    return React.cloneElement(React.Children.only(this.props.children), {
      style: styleHacks(this.props.children.props.style),

      // Note: mouseMove handler is attached to document so it will still function
      // when the user drags quickly and leaves the bounds of the element.
      onMouseDown: this.onMouseDown,
      onTouchStart: this.onTouchStart,
      onMouseUp: this.onMouseUp,
      onTouchEnd: this.onTouchEnd
    });
  }

I see a couple issues posted here in relation to children in preact and preact-compat and this seems to be related to that. React.Children.only throws an error even though there are children. I tried to work around it by removing the only and using this.props.children[0] as a stopgap for now (since in my case it's always one child) but it renders as <undefined />
What is the expected work around in preact for this?

Hmm - any idea what the value of this.props.children looks like in the case where this breaks?  Only thing I can think of would be if children is an iterable.

I've hit the same issue with the react-stripe-elements library. Specifically at the point I added StripeProvider. I've tried various things but to no avail so far.
I've created a stripped back example project that reproduces the issue (the original project used styled-components hence the alias logic).
https://github.com/newtriks/preact-stripe-example
Here is the debug output for this.props.children:

I believe the OP's issue may have been related to the Uglify bug, so updating to<EMAIL_ADDRESS>and<EMAIL_ADDRESS>should fix. I'm going to close this out since we've had no response, but please feel free to re-open if it's still happening!


[next] Rounded rect should be drawn clockwise, like other shapes.

#5241

Going to close this as the change seems unnecessary. Unable to reproduce this bug in v5 (next) since our big Graphics overhaul. https://jsfiddle.net/fb2gk9ad/


feat: (SC-25686) Hack Day - new label property to CollapseToggle #715

Hack Day Ticket

Added a new label property to CollapseToggle component which includes a new clickable text to the collapse icon.

Closing this PR in order to create this component directly on BP.


Docs for Mixer + Adapter Build Process

@douglas-reid I have a placeholder in the adapter developer guide for this purpose. Do you think the fix for this bug will be adding a section there
this is what I am referring to.
https://docs.google.com/document/d/1rKPt2Z2acy4pRwcvScPa-Na-EnU-6poGR-Rj_fZtaIc/edit#heading=h.enwekb8t755e

Doug, what's still pending and when do you think it will be completed?

There are two related outstanding docs:

Adapter Developer Guide
Template Developer Guide

I've been waiting for those to be finalized and published before figuring out if we need a third document and what that third document will look like. I don't believe this is blocking the release however.

When do you want to add the developer guides to the istio.io site?

I don't think the current plan is to add the developer guides to the istio.io site at all. We are putting links to the guides in the docs, however.


"Exception: No query supplied" in the listing block

Describe the bug
When we load a page that has a listing block, without a search criteria, we get the error below in Plone:
2022-11-04 16:51:47 ERROR [Zope.SiteErrorLog:35][waitress-3] Exception: http://localhost:3000/@querystring-search
Traceback (innermost last):
  Module ZPublisher.WSGIPublisher, line 167, in transaction_pubevents
  Module ZPublisher.WSGIPublisher, line 376, in publish_module
  Module ZPublisher.WSGIPublisher, line 271, in publish
  Module ZPublisher.mapply, line 85, in mapply
  Module ZPublisher.WSGIPublisher, line 68, in call_object
  Module plone.rest.service, line 22, in __call__
  Module plone.restapi.services, line 19, in render
  Module plone.restapi.services.querystringsearch.get, line 30, in reply
Exception: No query supplied

Who makes this call is getAsyncData.js
It sends the query parameter as an empty list.
It looks like it's an attempt to render the block server-side, but I don't quite understand it. The fact is that the block works without getAsyncData. So I'm not quite sure what the idea is here.
To Reproduce
Steps to reproduce the behavior:

Create a listing block at home, without any search criteria.
Press F5 on home.
See the Plone log.

Expected behavior
No error in Plone.
Software (please complete the following information):

OS: Ubuntu 22
Browser: Chrome
Volto Version: 16.0.0-alpha.48
Plone Version 6.0.0b3
Plone REST API Version: 8.30.0

@wesleybl It's related to the server-side rendering of the listing block, see https://6.dev-docs.plone.org/volto/blocks/ssr.html
It's probably a bug, that code needs to be brought more in line with the rest of the listing block data fetching preparations.

@tiberiuichim i'm trying to modify the listing block, to return more calalog metadata. But I saw that there are requests in getAsyncData.js and in withQuerystringResults.jsx. Which of these files should I make changes to? Or on both?

@wesleybl both.
getAsyncData is only used on the server-side rendering path. It's meant to populate the Redux store that will be used by the listing block components. Here's a page that hopefully will explain this mechanism: https://training.plone.org/effective-volto/addons/asyncconnect.html
withQuerystringResults is used by the listing block to fetch the data.
In principle these two functions should produce exactly the same query (pagination excluded, as there's no URL-based set current page). If they don't, it's a bug in the getAsyncData and should be fixed.

@tiberiuichim as I understand it, this is a mechanism to prevent the page from loading without the listing. But on the Browser side, the listing can be modified, after server rendering. That's it?
Well it looks like the way it is today, when we don't have a criterion, nothing is rendered on the server side (getAsyncData.js), since the query parameter is empty here (causing the described error).
The listing only appears because withQuerystringResults.js has a fallback:
https://github.com/plone/volto/blob/20840fdc5fc5a80e77e53ac04a028b613d444eaf/src/components/manage/Blocks/Listing/withQuerystringResults.jsx#L104-L106
when we don't have query.
It may be necessary to create a "default query", both in withQuerystringResults.js and in getAsyncData.js, when there is no query. Maybe in editing this "default query" should already be saved.

@tiberiuichim @sneridagh any opinions here? I propose the default query:
const defaultQuery = [
  {
    i: 'path',
    o: 'plone.app.querystring.operation.string.relativePath',
    v: '::1',
  },
];

when we have no defined criteria. This query will have the same result as the items key of the content.

@wesleybl Ok, +1


Implement Debug for the AST nodes

When I'm using a Rust library for the first time, my general learning process is usually just spraying dbg!() and todo!() everywhere to get a better feel for the datatypes I'm working with. With Syn, I can't do that because the AST nodes don't implement Debug. Is there a reason behind this? Doesn't seem hard to just add #[derive(Debug)] to every struct defintion.

This is already supported, you just need to enable the extra-traits feature: https://github.com/dtolnay/syn/issues/583#issuecomment-466830944


Change VSTS to Azure DevOps

Since VSTS is now Azure DevOps, I've update all the markdown that contain VSTS and replace it with Azure DevOps

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: mhdbouk sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

What is keeping this pull request from being approved.. ?

@zmmille2, @nmiodice can you approve this pull request to close it?

The playbook has been given a facelift and some of the structure has changed - we are also working on making the PR process quicker, please reach out to me with any questions. I will close this PR as will be hard to merge back in given the changes that have happened.


Support for Micro Variant

Heroicon (recently?) added a new micro-variant to their icons. Is there plans to support that here?

Hi @fjahn , yes. It is going to be ready this week


Decoding settings page is cut off in Wine and Windows 11

The settings pages are cut off and un-scrollable, not able to set all the settings:

That's a Wine problem and not something I can fix.

Uhm, this is present on Windows 11, too. See above.

The dialog size is fixed by fb2k and the scaling is done by Windows itself. If you're using another DPI setting than 96 dpi you're out of luck. In the long term I plan to migrate some settings to dedicated pages but that is a boring and error prone task.

Ok. is there an issue to track that?

Erh, I guess this one? I'll reopen it but it may take a while.

Erh, I guess this one? I'll reopen it but it may take a while.

I've tweaked the pages a little in alpha7.

Released as v<IP_ADDRESS>.


Add runit support

This add support for runit service management for pyinfra 3.
While runit behaves a little different to other init systems, it's still possible to have compatibility with server.service, albeit with some limitations.
It's also possible to manage alternative SVDIRs and sources for services.

Fixed the import statements and added the missing line.
But I had to remove the type annotations on all facts as they broke tests on python 3.8:
https://github.com/pyinfra-dev/pyinfra/compare/5b1e138d6cb1634ea778f39a6fea444afa024144..b66d48e29fdae4a0bdf4f9c66d7d0e6e572a5193


Major Dependency Updates

MUI V5 Migration
Peer Dependency resolution
Added linting

Merged even though I want a couple changes made.


Added new rapid frenzy game

PR Description 📜
Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below
Game Logic
In Rapid Click Frenzy, the player’s objective is to click a button as many times as possible within a given time limit. The game starts when the player clicks the "Start Game" button, which initializes the score to zero and sets the timer to the predefined duration (e.g., 10 seconds). As the game begins, the player clicks the "Click Me!" button repeatedly to increase their score. A timer counts down from the starting time, and once it reaches zero, the game ends. The player’s final score is then displayed, showing how many times they managed to click the button within the time limit.
Fixes #3962

Mark the task you have completed ✅

[ X] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[ X] I have performed a self-review of my own code or work.
[ X] I have commented my code, particularly in hard-to-understand areas.
[ X] My changes generates no new warnings.
[X ] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[X ] I have added screenshot for website preview in assets/images
[ X] I have added entries for my game in main README.md
[ X] I have added README.md in my folder
[ ] I have added working video of the game in README.md (optional)
[ X] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

I am contributing upon Gssoc24
## Thank you soo much for contributing to our repository 💗

Thank you @NAVJOT-786 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@kunjgit please check if anything else required

@kunjgit pull request is not accepted yet is anything else required please tell?

/assign

@kunjgit  please check i have solve the issue

@kunjgit my pull request is not accepted yet is anything else required

Thank you  @NAVJOT-786 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


OpenAI - deprecated API?

Hello, noticed that you're not using the new 1.0 openai api. This is becoming deprecated, an update to 1.0 would be helpful

Thank you for expressing interest in our project! We will consider your input. Nonetheless, it will not be prioritized at this time, as the current 0.x version continues to meet our needs effectively.


Update nav and menu to include downloads

(This also includes a change to fix the syntax of a marko template that missed a previous PR a while back)

 Add Recursos Digitales (Downloads) to Mundo Navigation.


try with lcov.info

Description of the Change

Issue

Benefits

Possible Drawbacks

Usage Examples or Tests [optional]

Alternate Designs [optional]

Codecov Report

Merging #28 (e5b9f5d) into iroha2-dev (3edfd1b) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           iroha2-dev      #28   +/-   ##
===========================================
  Coverage       69.75%   69.75%
===========================================
  Files             141      141
  Lines           27862    27862
===========================================
  Hits            19435    19435
  Misses           8427     8427

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3edfd1b...e5b9f5d. Read the comment docs.


Moving Event

Adds a Moving Event like L.Marker after setting new LatLng

You can see it here http://leafletjs.com/reference-1.0.0.html#marker-move
and here https://github.com/Leaflet/Leaflet/blob/master/src/layer/marker/Marker.js#L123


Add Repository Input Fields not working in responsive design

Environment
Platform: Rancher
Kubernetes/Platform Version(s): 1.22.15+rke2r2
Describe the bug
Under Assets->Registries it is not possible to add a repository if the browser is scaled (for example half of the screen). If the browser is maximized to full screen it works as expected. The Add button works fine, but in the settings window the input fields are not working. It is not possible to add values for all fields (Name, Registry, User Name, Password and Filter).
To Reproduce
Steps to reproduce the behavior:

Scale the browser window down to half screen
Click on Assets
Click on Registries
Click on Add
Try to modify the input field

Expected behavior
The fields should be editable and the user should be able to write or copy text in there.
Screenshots

UI Issue
Desktop (please complete the following information):**

OS: Linux Mint 20.3 x86_64
Browser Chromium
Version Version 106.0.5249.119
Browser Firefox
Version 105.0.3

I cannot reproduce it.

OS: Windows 11
Browser Firefox 105.0.3


Ports fittest to CUDA

I have tried to squash all commits in as few super-commits as possible.

http://uaf-6.t2.ucsd.edu/~cerati/mictest/2016-03-18-PR37/


Update provider storageCluster CR to disable OCS storageClasses

Signed-off-by: bindrad<EMAIL_ADDRESS>

LGTM

$ make test which: no controller-gen in (/home/dbindra/.local/bin:/home/dbindra/bin:/usr/local/go/bin:/home/dbindra/.local/bin:/home/dbindra/bin:/usr/local/go/bin:/home/dbindra/.local/bin:/home/dbindra/bin:/usr/local/go/bin:/usr/share/Modules/bin:/usr/local/bin:/usr/local/sbin:/usr/bin:/usr/sbin) go: creating new go.mod: module tmp go get: added sigs.k8s.io/controller-tools v0.4.1 /home/dbindra/go/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."  output:crd:artifacts:config=config/crd/bases mkdir -p /home/dbindra/Kaam/repos/github/go/src/github.com/openshift/ocs-osd-deployer/testbin test -f /home/dbindra/Kaam/repos/github/go/src/github.com/openshift/ocs-osd-deployer/testbin/setup-envtest.sh || curl -sSLo /home/dbindra/Kaam/repos/github/go/src/github.com/openshift/ocs-osd-deployer/testbin/setup-envtest.sh https://raw.githubusercontent.com/kubernetes-sigs/controller-runtime/v0.6.3/hack/setup-envtest.sh source /home/dbindra/Kaam/repos/github/go/src/github.com/openshift/ocs-osd-deployer/testbin/setup-envtest.sh; fetch_envtest_tools /home/dbindra/Kaam/repos/github/go/src/github.com/openshift/ocs-osd-deployer/testbin; setup_envtest_env /home/dbindra/Kaam/repos/github/go/src/github.com/openshift/ocs-osd-deployer/testbin; go test ./... -coverprofile cover.out Using cached envtest tools from /home/dbindra/Kaam/repos/github/go/src/github.com/openshift/ocs-osd-deployer/testbin setting up env vars ?       github.com/red-hat-storage/ocs-osd-deployer     [no test files] ?       github.com/red-hat-storage/ocs-osd-deployer/api/v1alpha1        [no test files] ok      github.com/red-hat-storage/ocs-osd-deployer/controllers 227.974s        coverage: 84.9% of statements ?       github.com/red-hat-storage/ocs-osd-deployer/readinessProbe      [no test files] ok      github.com/red-hat-storage/ocs-osd-deployer/readinessProbe/readiness    7.025s  coverage: 73.3% of statements ?       github.com/red-hat-storage/ocs-osd-deployer/templates   [no test files] ?       github.com/red-hat-storage/ocs-osd-deployer/testutils   [no test files] ?       github.com/red-hat-storage/ocs-osd-deployer/utils       [no test files]


Correct Bogus NULL-Returns in _swift_stdlib_getUnsafeArgvArgc

Correct multiple platforms' bad behavior on error handling paths. The nullability annotations on the return type of _swift_stdlib_getUnsafeArgvArgc forbids this function from returning nullptr. Therefore just crash. There's very little else that we can do here that will produce a coherent result for these failing cases.
While I'm here, modernize some C-style casts in all of the platforms.

@swift-ci smoke test

@swift-ci smoke test

@swift-ci smoke test

@swift-ci smoke test

@swift-ci smoke test Windows

⛵


Don't overwrite detected compiler flags.

Fixes cross-compilation for ARM64, now you only have to set CC and CXX, CMake will take care of the rest.

Nice catch


Missing documentation/comments about AAD long-lived bearer token

The comments in ConfigureService for production say that you should not "rely on a token generated by Azure AD".
Is that comment correct?
The tutorial says that the only valid option for non-gallery apps is to use a long-lived bearer token.
I can create a JWT access_token to my SCIM API with 3 year expire date, and paste that in the Secret Token field. But that is just a glorified 'shared secret' - how is that safer than using the /scim/token development endpoint?
If I leave 'secret token' blank, at least I can verify the issuer in the AAD generated token and know that I am called from the correct Tenant, instead of having a fixed token that could be compromised.
NB my question is similar to issues #35 and #37 and Rickards post on SO. However the fact remains that ConfigureService in SCIMReferenceCode only contains code on how not to do things..

Yes, been struggling with trying to understand how to turn this into a multi-tenant enabled solution. Creating a fixed token per AD tenant doesnt make sense.
Would not checking the issued Azure AD token be better than a long lived secret?

Duplicate for #35