Cheap porno ads playing

I'm trying to create a webtorrent based video player and I've excluded all adult content from playing on the site, apart from your ads. You've built a really good player but what's the point when you are ending up showing ads for pornos?

Yes i had same issue. How to fix?

Yes i had same issue. How to fix?

use you own webtor instance, or support author on patreon (something he told about it or other, didn't remember).
But realy, maybe you review ads politics - as i see - there is many from black listed markets platforms - "enlarge you penis", "watch this pussys" and other.

Yes i had same issue. How to fix?

use you own webtor instance, or support author on patreon (something he told about it or other, didn't remember).
But realy, maybe you review ads politics - as i see - there is many from black listed markets platforms - "enlarge you penis", "watch this pussys" and other.

Exactly. What do you mean by using my own webtor instance?

Yes i had same issue. How to fix?

use you own webtor instance, or support author on patreon (something he told about it or other, didn't remember).

Hey thanks for your help 😊. I don't have enough money to support his patreon right now, I might do it in the future though.
For now, can you pls guide me how to setup my own webtor instance??
Thanks:)

Hi! I have removed all adult ads from all ad networks few days ago. I don't really want to show them at mainstream sites at all.  I will check it shortly. Thanks for notification.

For now, can you pls guide me how to setup my own webtor instance??

@hlpokumr https://github.com/webtor-io/helm-charts

For now, can you pls guide me how to setup my own webtor instance??

@hlpokumr https://github.com/webtor-io/helm-charts

If I do this can I remove the ads? Or even add my own ads to keep up with hosting expenses?

Hi! I have removed all adult ads from all ad networks few days ago. I don't really want to show them at mainstream sites at all.  I will check it shortly. Thanks for notification.

For now, can you pls guide me how to setup my own webtor instance??

@hlpokumr https://github.com/webtor-io/helm-charts

@vintikzzz Good job brother! Atleast you have tried to remove them, however i saw them running in the morning today too but it maybe due to latency on the part of the ad provider.
@odmivolsi yes brother the hosting plans are way too much for me to handle and in this pandemic world I don't know if I can sustain it and myself too.

@odmivolsi it will bring you platform that just streams content from torrent and you should build player on your own.
https://github.com/webtor-io/platform-sdk-js - is a js sdk that makes it possbile to work with it and build your own solution.

@vintikzzz alright thanks man! I hope I can soon contribute on your patreon 😄


Connection is never closed  by napalm_configure

Dear maintaners,
I am developing a Nornir based application that pushes configuration to IOS-XR devices via napalm_configure and i've noticed that - from time to time - all of the VTYs on the devices in my testing environment get consumed.
While investigating, i have noticed that a connection to the device is open by napalm_configure, but it is never closed (at least not by this plugin)
So, If i am understanding it correctly, then it is up to the device to close connection. While it would be smarter it the client would do so.
It would be quite and easy change to make within napalm_configure. But i am not 100% sure if that's the right point or if a connection should be closed elsewhere.
Would you mind to explain?
Thank you
Regards

@lamehost Have you checked at the NAPALM for IOS-XR (it is not clear from the question whether you are using the ios-xr napalm driver that uses xml-agent or the netconf driver) and whether it is properly closing the connection on the .close() call?

@dbarrosop
I've read that page, but i can't find where the connection is closed by Nornir. Where is it? Would you be so kind to tell?
@ktbyers
I am using the xml-agent one

It is handled by nornir automagically unless you decide to manage the connection yourself explicitly. When exactly doesn't really matter (but for the sake of completion, it happens when the object is garbage collected), the point is that if you need to open/close the connection at specific times you can do it already.
Re-reading your issue, I am a bit confused though. Nornir only opens one connection per device and connection type so I am unsure how nornir could be exhausting your VTYs. Have you checked with IOS-XR that that the VTYs are, in fact, being used by nornir? If yes, could you share the simplest script that triggers the issue?


WIP: Add TLS auto-approval for kubelet.

Seeing some issues with only using the RotateKubeletClientCertificate to perform the first CSR (and not the bootstrap flag). Reported issue is that it requires a kubelet restart after doing the CSR to start authenticating as a node.
I think the kubelet is opening a connection to the API server with the bootstrapping credentials to perform its CSR, then keeping that connection alive even though it's got a client cert. The kubelet never closes its existing connection to the API server, so it never re-performs a TLS handshake to authenticate using its client cert.
Only workaround I see is to have systemd restart the kubelet once it detects the kubelet's written its first certificate to disk. Blah.

@ericchiang Yes, I can see how that would happen. The underlying connection is only re-established if it is disrupted for some reason. The rotated cert is set immediately, and will be used when the connection is re-established.

I think the kubelet is opening a connection to the API server with the bootstrapping credentials to perform its CSR, then keeping that connection alive even though it's got a client cert.

That's concerning... the client and transport built from the bootstrapping credentials shouldn't be reused beyond the bootstrap phase. Once it gets the first client cert, the input to building the API client should be different, so it should get a different tls config, with a new set of keepalive connections.

oh, by bootstrapping, you don't actually mean --bootstrap... you mean the initial content of --kubeconfig

@jcbsmpsn because the API server authenticates x509 certs at the time of the request, and not on the handshake[1] I think we'll hit the same issue when the kubelet cert expires. E.g. once the kubelet's cert expires, it'll keep the connection open, but the requests will start getting forbidden errors.
I think the kubelet's rotation code should shut down its connections once it successfully rotates a cert. That would let it immediately start using the new certs and prevent these kind of issues with long lived connections and old credentials.
[1] https://github.com/kubernetes/kubernetes/blob/v1.7.2/staging/src/k8s.io/apiserver/pkg/authentication/request/x509/x509.go

@ericchiang That would be good. I do not think that will be easy.

https://github.com/kubernetes/kubernetes/pull/49899 addresses closing existing connections when the certificate changes.

@jcbsmpsn yes, I added a temporary commit that switches the kubelet to use a hyperkube with that PR to test.

@diegs this PR has been updated with 1.8 features. It also now enables node authorizer and admission controller.
https://kubernetes.io/docs/admin/authorization/node/
https://kubernetes.io/docs/admin/admission-controllers/#noderestriction
Everything works now except the checkpointer. I think we do want to run the checkpointer with a service account and ideally it's own RBAC role. Since it's running as a static pod, and wont have access to KUBERNETES_SERVICE_HOST and KUBERNETES_SERVICE_PORT, we probably want to do something similar the kube-proxy-kubeconfig in this PR.
cc @dghubble @colemickens --- in case either of you want to take a look.

coreosbot run e2e

coreosbot run e2e

@ericchiang you're going to need to release a new and bump the version in images.go to pick it up. @dghubble or @aaronlevy might be able to help you find the Jenkins job.

Checkpointer is running in a dedicated service account not, is there anything left [I can help with], which stops this PR from being merged?

@redbaron I am wrapping up #784 which makes the tests better and changes the checkpointer to only look at its own namespace, which relaxes the required roll bindings. Hoping to finish that up in the next day or two.

Checkpointer is running in a dedicated service account now, is there anything left [I can help with], which stops this PR from being merged?

This is actually already done, even without @diegs changes. The changes were manifest only and didn't require any changes to the checkpointer itself.
I think we still need to add an approve all rule for rotation[1 (different from bootstrap approval) as well as docs. Will update this when I get the chance.
[1] https://kubernetes.io/docs/admin/kubelet-tls-bootstrapping/#kube-controller-manager-configuration

Still waiting for e2e. If this passes then I think the code bits are done.
We still need to do some rotation testing (e.g. if we run a long lived cluster the rotation works) and add some docs.


Import issues for this repo

Added import-issues.js
Added github_issues, github_issues_labels tables in schema.sql
No build

Looks good at first glance, will test it out shortly.
When you get a chance, run yarn prettier and do a force push.


Add support for podspec configuration

This will add missing podspec support.
Example:
<pod id="MyPod" podspec="https://path.to.podspec">
will add an entry to podfile:
pod 'MyPod', :podspec => 'https://path.to.podspec'

It's a mistake that the commit 3355b8ea66f1927231351d18d2e56aad6a064f21 has landed in this PR.
8d1f761f93051095bb2117f6077dbeba158ceb09 and support for podspec was meant
I opened a new PR here:
https://github.com/blakgeek/cordova-plugin-cocoapods-support/pull/33
Can you please take a look into it?


Sledon-cli

Is there some command to delete client, user or item? I don't find nothing in docs.
What if I want to delete item which was removed from my app?

Hi,
Currently for client/user/item there is no delete command as they are logged and may be needed for auditing.
It's functionality will look at in the future.

Gurminder

Hi,
thanks for quick reply.
So how can I filter out items which is deleted from my app, from recommendation?
Because if I don't delete this items from seldon I wil have lots of results pointing to deleted items.
mt

Hi,
You can create in your meta data a "enum" type which is set for each item.
In http://docs.seldon.io/content-recommendation-guide.html#client it would be the example:
{"name":"genre","value_type":["pop","rock","rap"]},
In your case maybe
{"name":"active","value_type":["active","deleted"]},
You can set this meta data when adding items and update it when items are "deleted".
In recommendation calls you can use the "dims" attribute to restrict recommendations to a particular "dimension". There will be a dimension for each possible value of an enum type. In your case "active" and "deleted". At present the seldon-cli lacks a way to view these so you will need to log into the mysql db that holds the meta data and view the dimension table to get the correct one to pass in on your recommendation calls to get just "active" items returned in your recommendations.

@cliveseldon thanks for the example
mt.


Repo sync for protected CLA branch

The pull request is created from main638037867025693059sync_temp to main to fix git push error for protected CLA branch

Learn Build status updates of commit 98a416a:
:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Add Kanister to CNCF Landscape

Kanister already exists on https://github.com/cncf/landscape.

Move it under Cloud Native Storage
Update logo

https://github.com/cncf/landscape/pull/3797

Completed. See https://landscape.cncf.io/


The Contract - Vehicles Hash Add

Hey, here is a little contribution.
I have added all "The Contract" Vehicles Hash to VehicleHash.
I also noticed a miss in the alphabetical order & re-ordered it.
So : Schlagen as been moved up.
Thanks for your work ! I hope it help :)

We’re sorry but could you create a PR for main branch? dev_v2 and dev_v3 branches aren’t used anymore.

I'll retry, Sorry I'm starting with GitHub. Thanks


Activity tab fix

Activity tab will now use PG specific query to make sure its working correctly in between versions.

Should fix the issue on all 9.x branches, with a dumb default on any other pg version.

It looks like this just removes the waiting column when in 9.6. waiting wasn't just removed in 9.6, though, it was replaced with wait_event and wait_event_type, to provide better context about why the query was waiting.
To quote from here:

In addition to the existing status information as pid, query_start or query provided in current versions, PostgreSQL 9.6 maintains two new columns in pg_stat_activity; the columns and wait_event and wait_event_type, which contain detailed information on locking. These replace the column waiting, which reported only TRUE or FALSE depending on the status of each row, signalling that has been waiting for a heavyweight lock.

The new wait_event column can also shed light on whether - and what kind of - LWLocks are waiting. Where a backend is waiting for a lock, the column contains the name of the wait_event events, or defaults to NULL.

Given that, the query should at minimum replace waiting with wait_event IS NOT NULL as waiting, if not explicitly selecting both wait_event and wait_event_type.
What do you think @sosedoff?

@bjeanes True, i missed those fields while porting the query across all supported versions.


can't generate reasonable result

I git clone this repository, and run the demo_decode.py, i get a picture with much nosie, which totaly can't figure out the image content.
I try above operation on both 2070 and 3090, get same issues

I have same question, do you get image like this?

yes, totally same
Cai
@.***
Original Email
Sender:"Shzhuoyu"< @.*** >;
Sent Time:2023/5/22 20:40
To:"AugmentariumLab/SIGNET"< @.*** >;
Cc recipient:"CofCai"< @.*** >;"Author"< @.*** >;
Subject:Re: [AugmentariumLab/SIGNET] can't generate reasonable result (Issue#3)
I have same question, do you get image like this?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

I solved it! add these three lines in func "get_LF_val"

nice, I will try it.
Cai
@.***
Original Email
Sender:"Shzhuoyu"< @.*** >;
Sent Time:2023/5/23 20:13
To:"AugmentariumLab/SIGNET"< @.*** >;
Cc recipient:"Cai Dongjun"< @.*** >;"Author"< @.*** >;
Subject:Re: [AugmentariumLab/SIGNET] can't generate reasonable result (Issue#3)
I solved it! add these three lines in func "get_LF_val"
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

I solved it! add these three lines in func "get_LF_val"
val_inp_t[..., :2] /= 17
val_inp_t[..., 2] /= width
val_inp_t[..., 3] /= height

It doesn't work by adding the three line codes, I don't know why.  I got a picture with all pixels are same color by your approaches which is different from the previous result(nosiy images)

I think the layernorm parameters somehow got turned off in the demo code.
Can you try the fix_demo_decode branch to see if it is fixed?


Service with many records taking time to load into NGx datatable

I'm submitting a ...  (check one with "x")
[ x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, post on Stackoverflow or Gitter

Hi Team,
We are using datatable component for displaying the records which returned from the service.
On the initial load of the application the datatable is taking  some amount of time to load all the records irrespective of number of records per page.
Is there any way to restrict load only certain records on page and then load the remaining as per request.
Is we need to configure anything in observable map or by making use of externalPaging attribute ?
We tried with external Paging property but still all the records are getting loaded on first call.Please assist on this.
Version : Angular 4.0.0
Datatable: 9.3.0

the datatable is taking some amount of time to load all the records irrespective of number of records per page

It is unclear what you are referring to here. Are you referring to how long it takes for the data table to render your records or how long it takes for your records to be returned from your API service?
External paging requires that your API is capable of handling paging requests. Otherwise, you're just going to make the same request repeatedly rather than getting a subsection of your data per request. To do this you must:

Cache the results of your API client side so that you don't re-request records you already have
'Skip' records you've already requested from the API.
'Take' only the number of records you have on each page.

So if you have 10 records per page the request for the 3rd page would skip 20 and take 10.

Ya, I agree w/ @adammedford .
I recommend using virtual scrolling to handle large amounts of data.


ReDoS vulnerability when processing regular expressions

Regex patterns in filters are passed straight to the regexp constructor without any sort of filtering for malicious patterns. For trusted expressions (those on the /r/anime server) this is fine, but not the best solution long-term.
<EMAIL_ADDRESS>

This seems like a good remediation technique: https://www.josephkirwin.com/2016/03/12/nodejs_redos_mitigation/
For something like message filters which need to be executed for basically every messageCreate the bot receives, might be worth looking into an asynchronous method instead, depending on the performance hit incurred by using vm - needs further investigation


test9

Just added a label to double check the new action kicked off properly and it did https://github.com/coiled/dask-community/actions/runs/1866366117. Next I'm going to close this issue to see where this ticket ends up on the board

Just added a label to double check the new action kicked off properly and it did https://github.com/coiled/dask-community/actions/runs/1866366117. Next I'm going to close this issue to see where this ticket ends up on the board

looks like closing it automatically moved it to 'done'!


Add option to automatically download Yandex machine translation and add it to the final video

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I remove or skip any mandatory* field

Checklist

[X] I'm requesting a feature unrelated to a specific site
[X] I've looked through the README
[X] I've verified that I'm running yt-dlp version 2022.11.11 (update instructions) or later (specify commit)
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Provide a description that is worded well enough to be understood
Hello!
Program voice-over-translation allows you to download machine translation into Russian from Yandex as mp3 file.
Is it possible to add yt-dlp option to automatically download this translation and add it to the final video as an additional (or only) audio stream?
Provide verbose output that clearly demonstrates the problem

[ ] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
No response

This is out of scope of the core project. More of something for a post-processor plugin to do.


wazevo(amd64): initial implementation for call

super early draft to understand if I am on the right track 🧪⚗🐶 -("I don't know what I am doing")
nothing works, even regalloc blows up :P
in practice, there is a lot of copy/paste going; obviously everything needs to be cleaned up (e.g. stuff needs to move to instr_lower.go like on arm64)
I enabled the e2e test "call" and working backwards from there. It turns out, quite a few things are needed 😬
e.g. for add I introduced aluRmiR: useKindOp1Op2 , aluRmiR: defKindOp2. I am not sure that is correct. Essentially aluRmiR needs 2 operands, and will overwrite one of the two.
EDIT meanwhile I figured that maybe @mathetake didn't mean to literally start from e2e testing but he was just pointing at the test case 😅  I think I can adapt backend_test.go
EDIT2: also I completely overlooked the clobberedRegs/spillSlots so that's likely the issue on e2e :D

EDIT meanwhile I figured that maybe @mathetake didn't mean to literally start from e2e testing but he was just pointing at the test case 😅 I think I can adapt backend_test.go

I meant e2e like this so looks good to me

EDIT2: also I completely overlooked the clobberedRegs/spillSlots so that's likely the issue on e2e :D

you can ignore spill slots for now, and like-wise, you can just put TODO on args passed via stack

let's do ADD instruction in a single function next, then after that, let's do call instruction with arguments


Fix MRO traversal with multiple inheritance

So the double reversal we used to do screwed up the MRO traversal for forever (i.e. this is not a 17.3 regression, I had to fix examples.rst!).
This fixes it – the question is how we go about it.  A proper deprecation cycle seems impossible again, so I guess we can push it and ask for forgiveness?
This fixes #298 and #299 cc @yarikoptic

Well, +1 from me ;-)

Paging @glyph for wise opinions. :|

Somewhat belatedly (although it appears in time for a release?) I did have an idea about this.
The deprecation cycle here could go like this:

X.Y emit a warning when calling multiply-inherited __init__ with positional arguments
X.Y+1 raise an error when calling multiply-inherited __init__ with positional arguments
X.Y+2 add back this positional ordering.

Alternately, if we just want to bite the bullet, we could switch to this behavior, but still emit a warning for a release or two about using positional args in the multiple-inheritance case.
This might help folks with deep inheritance trees at least notice that there might be a problem if their test coverage isn't great.
Calling __init__ with kwargs is generally clearer anyway, especially in the presence of potentially confusing orderings as with e.g. diamond inheritance.  So if this pushed pretty much 100% of code using attrs to always use kwargs maybe that would be a good idea.

Hm that seems a rather harsh thing to do, but an interesting idea.
I’m not ready to go that far, but I think I’ll add a blurb to the newsfragments, encouraging people to use kwargs.


Questions about equations in the paper.

Hello, @liuff19
Recently, I found your project very interesting and started reading your paper. However, I have some questions on some equations in the paper.

For equations (12)
$$\ L_{\text{diffusion}} = \mathbb{E}{x \sim p, \epsilon \sim \mathcal{N}(0, I), c{\text{view}}, c_{\text{struc}}, t} \left[ |\epsilon - \epsilon_{\theta} (x_t, t, c_{\text{view}}, c_{\text{struc}})|^2_2 \right] $$
in the paper it says that $x_t$ is the noise latent from the ground-truth views of the training data. Which ground-truth view are you referencing from?

In section 5.4 it says that
'For the generated frames $\{I_i\}_{i=1}^{K{\prime}}$ we denote $\hat{C}_i$ and $C_i$ the per-pixel color value for generated and ground-truth view $i$.'
What do you mean by ground-truth view $C_i$?
It also appears in equation (13)
$$ L_{I_i} = - \log \left( \frac{1}{\sqrt{2 \pi \sigma_i^2}} \exp \left( -\frac{|C{\prime}_i - C_i|^2}{2 \sigma_i^2} \right) \right) $$

For equation (14)
$$\  L_{\text{conf}} = \sum_{i=1}^{K{\prime}} C_i \left( \lambda_{\text{rgb}} L_1(\hat{I_i}, I_i) + \lambda{\text{ssim}} L_{\text{ssim}}(\hat{I_i}, I_i) + \lambda{\text{lpips}} L_{\text{lpips}}(\hat{I_i}, I_i) \right) $$
in this equation it seems like the loss is calculated between the 32 generated frames $\hat{I_i}$ with its GT frames $I_i$.
Which GT frames are you comparing with? Is it the input sparse view? or is it from the train dataset video?
Thank you in advance for your time to reply to this issue.
Best regards
Frank

Hello, @liuff19
Can you tell more detail about the process of getting
As the paper:

Does the equation just get only one   for training equation (13) for view i? With only one sample, it is able to optimaze equation (13)?
Or may be the equation return a set of   for view i, as:

Then we can use the set of data to train equation (13) to get
 and
.


Sort the list of locations before returning them

Just adds one call to sort before returning the locations for the list command

Thanks!


Incorrect formatting: FSD engaged script, line 40

You is incorrectly colored. Supposed to be colored as Body text, is colored as (I think) Code.

Note: It appears that this may share a common cause with #9. Removing || prior to : in the {if... statement corrects the formatting.

Thanks

Yep fixed with #9.


Constraint Pattern: require activity A before next activity B

ccamargo
https://jira.jpl.nasa.gov/browse/AERIEQS-212
Moderate
Some Clipper flight rules use language like "...before start of the next science observation". We already have a StartOf constraint node. To implement language like this we would like a "BeforeNext" constraint node.
Possible signature for this new constraint node:

*Return Type:*Set of windows
*Return Value:*All windows before the next window
Required Fields:
** {{expression}}: Expression yielding sets of windows

### Tasks
- [ ] https://github.com/NASA-AMMOS/aerie/issues/1112
- [ ] https://github.com/NASA-AMMOS/aerie/issues/1113

Both subtasks have been completed


Fix a value  in  authentication.rst

The client secret is a  30-character string .

i was confused because mine is a  30-character string .
BTW , what is the max ? 30 ?

i was confused because mine is a  30-character string .
BTW , what is the max ? 30 ?

Thanks for the update! I'm not sure what the maximum size is. I guess they may periodically change it.

Thanks for the update! I'm not sure what the maximum size is. I guess they may periodically change it.

if possible, may i add my name to the AUTHORS.rst file ?

if possible, may i add my name to the AUTHORS.rst file ?

Of course. Please make another PR for it.

Of course. Please make another PR for it.


revoke function

Delete a token with DELETE is not possible anymore. So the Class HandleAccessToken is replaced by RevokeAccessToken with POST command


YARN-10901. Fix permission checking error on an existing directory in…

… LogAggregationFileController.
Create a temporary file with proper ownership to see if the underlying
file system supports chmod.
When the log directory was already created, but with a different user,
there was an exception in the log:
org.apache.hadoop.security.AccessControlException: Permission denied.
user=yarn is not the owner of inode=/tmp/logs
because the setPermission checked the ownership of the given path.
Change-Id: I7c7908b7ec815501337daaf7a2253a11d79afc8c

Description of PR
How was this patch tested?
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 48s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 37s

trunk passed

+1 :green_heart:
compile
0m 54s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
0m 46s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
0m 38s

trunk passed

+1 :green_heart:
mvnsite
0m 51s

trunk passed

+1 :green_heart:
javadoc
0m 51s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 48s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
1m 47s

trunk passed

+1 :green_heart:
shadedclient
15m 22s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 40s

the patch passed

+1 :green_heart:
compile
0m 43s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
0m 43s

the patch passed

+1 :green_heart:
compile
0m 37s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
0m 37s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 27s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common: The patch generated 2 new + 13 unchanged - 0 fixed = 15 total (was 13)

+1 :green_heart:
mvnsite
0m 40s

the patch passed

+1 :green_heart:
javadoc
0m 40s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 39s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
1m 50s

the patch passed

+1 :green_heart:
shadedclient
15m 26s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
4m 56s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
asflicense
0m 35s

The patch does not generate ASF License warnings.

82m 28s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3355/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3355

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux fb07c4e23e3b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 5a980a4a54466d0458986d5628fb1e8f4c835ffc

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3355/1/testReport/

Max. process+thread count
550 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3355/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Thanks @tomicooler for working on this. The commit LGTM, +1 from my side, once you fix the checkstyle issues. :)

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 55s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m  9s

trunk passed

+1 :green_heart:
compile
0m 50s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
0m 41s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
0m 33s

trunk passed

+1 :green_heart:
mvnsite
0m 49s

trunk passed

+1 :green_heart:
javadoc
0m 48s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 43s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
1m 51s

trunk passed

+1 :green_heart:
shadedclient
16m 21s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 40s

the patch passed

+1 :green_heart:
compile
0m 43s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
0m 43s

the patch passed

+1 :green_heart:
compile
0m 41s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
0m 41s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 25s

the patch passed

+1 :green_heart:
mvnsite
0m 41s

the patch passed

+1 :green_heart:
javadoc
0m 40s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 43s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
1m 53s

the patch passed

+1 :green_heart:
shadedclient
15m 34s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
4m 54s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
asflicense
0m 35s

The patch does not generate ASF License warnings.

85m 11s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3355/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3355

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux fe0354c23be5 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 7bdfbd501b4997624ad17992494ea20fa0d95194

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3355/2/testReport/

Max. process+thread count
628 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3355/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


Component mock doesn't work anymore

Hi,
Ux Twig Component version went to 2.21.0 and this particular commit totally broke mock logic.
I've dig into it a bit and I don't think there is a quick fix for it.
Do you think you got time to fix it ? Let me know I can help.

Hi @svianney, thank you for the issue and your investigation. I looked at the code and as you said, there is no easy way to fix this... I'll need some time to figure it out.

I might have found a way to handle this using a custom Twig node to mock the context on display. The downside is I can't use a dedicated Twig environment for Storybook anymore. Mocking will work again (and it's probably better this way) but it breaks isolation. I try to make both possible.

That's interesting, I'm not really sure about what you have in mind but that's probably better than what I had in mind.
I was thinking that you would have to listen to PreCreateForRenderEvent and handle the rendering yourself but that seemed like an heavy solution and I don't like the fact that it means you won't be able to benefit from ComponentRenderer updates anymore.


Feature request discussion

I started the discussion here, but I guess it makes more sense to continue in the firmware.

Yes this is definitely a problem.
Related - https://github.com/PX4/Firmware/pull/8006


User documentation

Is there any end user documentation on features apart from the few sections in the readme? Related to this, we are not clear on how the trips/dispatching features should work?

At this point, all the documentation we have is in the readme file.
Regarding the trips/dispatching, for now, it displays the routes for cars/trucks on the UI. However, it is not yet integrated with the mobile device.

Thanks, we haven't been able to get trips to work and there is no data in the reports etc. Can you describe step to step how to get it to work?

Trip detection logic should run every around 30 mins. If you've done your deployment through the deployment portal, can you try the following:

Open the deployment portal and enter your deployment name
A prompt should appear saying "Open update page", click it
The update page should have all your deployment parameters pre-populated, do not change anything
Re-deploy/update your app - this will not delete any of your data but will attempt to fix the deployment.

Let me know if this solves it for you

Yes, this worked to fix the problem. Thanks

Will close this issue for now. Please feel free to re-open if you still have any questions.


Remove version: Scintilla.SciTE version 5.3.7

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://www.ebswift.com/uploads/7/0/4/0/70403747/scite-5.3.7x86.msi
Response Error: The remote server returned an error: (404) Not Found.
(Automated message - build 908)

URL: https://www.ebswift.com/uploads/7/0/4/0/70403747/scite-5.3.7x86.msi
Response Error: The remote server returned an error: (404) Not Found.
(Automated message - build 908)

Hi @Exorcism0666,
This manifest has the highest version number for this package. Is it available from another location? (This might be in error if the version is switching from semantic to string, or string to semantic.)
(Automated response - build 885.)

URL: https://www.ebswift.com/uploads/7/0/4/0/70403747/scite-5.3.7x86.msi
Response status code does not indicate success: 404 (Not Found).
(Automated message - build 885)

For moderators or/and anyone else

[!Caution]
As a result of several personal problems I've had over the last few months + my final exams coming up very soon, I'm currently unable to look at my GitHub notifications every day and maintain my executions correctly.
If you detect a certain problem on a certain pul request:

Either you can close the pull request directly without mentioning me.
Or you can send me a message on X (Twitter): @Exorcism0666

Thank you for your understanding, and I'm sorry if some pull requests can't be approved due to the situation I'm in.

This account is automated by Github Actions and the source code was created by CoolPlayLin. If you have any questions about any pull request, don't hesitate to ping Exorcism0666.

[!warning]
With the new version of Komac, numerous Pull Requests may contain bugs or unwanted elements. If such issues arise, please tag russellbanks so that these bugs can be addressed in future updates.

[!important]
Please carefully review these Pull Request before merging. If it is a Pull Request for removing incorrect content and the URLs are issue, free upon manual checking, please close this Pull Request directly. (It is best to inform Exorcism0666 of the closure.)

良い一日をお過ごしください！


page.click vs page.evaluate

It seems that clickElement does not work on all cases. I have a regular Ext.js app and I tried on other simple ones,
let selector = 'input[name="username"]';

// does NOT work
await page.click(selector);

// does work
await page.evaluate((selector) => document.querySelector(selector).click(), selector);

Googling around, I am not the first person to solve it using the does work method but should the library here adhere to more verbose standards?

That's interesting that the page.click(selector) isn't working for you on the Ext.js app.  Is that with the latest version of Puppeteer?  I've noticed that behaviour breaks occasionally as they update Puppeteer/Chrome.
Let me know - at the very least, if updating to the page.evaluate method does work consistently and doesn't break anything else, it would be an easy change for this project.

@agitperson let me know if this now works as expected for your Ext.js app.

It does work. Thank you. :-)


feat: Implement script plugin

Related to #38

CDS Report test#176.0 ✘

Stage 1

Test ✘

CDS Report test#177.0 ✘

Stage 1

Test ✘

CDS Report test#178.0 ✘

Stage 1

Test ✘

CDS Report test#179.0 ✘

Stage 1

Test ✘

CDS Report test#180.0 ✘

Stage 1

Test ✘

CDS Report test#184.0 ✘

Stage 1

Test ✘

CDS Report test#185.0 ✘

Stage 1

Test ✘

CDS Report test#186.0 ✘

Stage 1

Test ✘


Need to get confirmation that audit has been successful

They may be times when you don't want to allow access to data if the audit service is unable to confirm that the audit log made it to the desired destination. Therefore the audit service API need to return a completable future boolean.

merged into develop


Adding the ability to forcefully update all the markers.

Hello, first off, thanks for your work on this!
Second, this PR contains the following:

a new .gitignore with more stuff added.
version changes (0.5.1) for bower/npm
removal of peer deps in package.json because they arent really applicable with npm3
updated dist files

These changes were for the addition of a force flag on the updateMarkers api: https://github.com/spchuang/videojs-markers/blob/master/src/videojs.markers.js#L127-L141
I am using this with another plugin (https://github.com/eXon/videojs-vimeo) and at the point of loading the video duration is unknown, so all the markers start at the beginning of the scrub bar. With this addition, I and others, can simply call player.markers.updateTime(true) to forcefully update all the markers position as needed (otherwise, they wont change due to the lack of difference in their positions since the time they were initiated.)
Note: There was an automatic whitespace change from my ide (tab or 3space to 2 space indentation). If you absolutely hate it, I can manually remove it.

Hi, I'm adding it in https://github.com/spchuang/videojs-markers/commit/4b04cfaca7fd6bc548a52b29d2047cea2277e7ac


DNN-8093 Fixed the bug for missing controller name

DNN-8093 Fixed the bug for missing controller name in case of Action(actionName) overload.
Now the system will pick the current controller name in case it is not provided.

Can you please add a unit test here as well.


(Offline) Download of HLS stream stops after first chunk

Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
^3.3.0
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from master?
Seems like 3.3.0 is the master?
Are you using the demo app or your own custom app?
Custom app
If custom app, can you reproduce the issue using our demo app?
No. It looks like download in the demo app works well.
What browser and OS are you using?
Chrome, Safari
What are the manifest and license server URIs?
Sent to email
What did you do?
    const download = async () => {
        const shaka = await import('shaka-player');
        const shakaPlayer = new shaka.Player();
        shakaPlayer.addEventListener('error', console.error);
        const storage = new shaka.offline.Storage(shakaPlayer);
        storage.configure({
          offline: {
            progressCallback: (content, progress) => {
              console.log({ content, progress });
            },
            trackSelectionCallback: (tracks) => {
            // This example stores the highest bandwidth variant.
            //
            // Note that this is just an example of an arbitrary algorithm, and not a best
            // practice for storing content offline.  Decide what your app needs, or keep
            // the default (user-pref-matching audio, best SD video, all text).
            const found = tracks
                .filter((track) => track.type == 'variant')
                .sort((a, b) => a.bandwidth - b.bandwidth)
                .pop();
            // eslint-disable-next-line no-console
            console.log('Offline Track bandwidth: ' + found.bandwidth);
            return [ found ];
          }
        }
      });

      const metadata = {
        title: 'Foo title',
        downloaded: Date()
      };

      const manifestUri = `***sent in email***`;
      await storage.store(manifestUri, metadata).promise;
      const [offlineInfo] = await storage.list();
      console.log({ offlineInfo });
    };

What actually happened?
The download stops after first chunk. An error with code 9004 appears in the console.

@MartinMalinda  Can you check with 4.0.0 if you reproduce the problem? Thanks!


feat(core) feat(lib-widget) Add {{dirname}} to summary and preview_path

Related to: #445
Summary
This PR allows the generated meta.path to be accessible in summary and preview_path when using nested collections.
eg:
collections:
  - name: 'pages'
    create: true
    label: 'Pages'
    label_singular: 'Page'
    folder: 'src/content/pages'
    preview_path: '{{dirname}}'
    media_folder: '/{{media_folder}}/pages/{{dirname}}'
    summary: '{{title}} - {{dirname}}'
    nested: { depth: 100 }
    meta: { path: { widget: string, label: 'Path', index_file: 'index' } }
    fields:
      - label: 'Title'
        name: 'title'
        widget: 'string'
      - label: 'Image'
        name: 'image'
        widget: 'image'
      - label: 'Body'
        name: 'body'
        widget: 'markdown'

Docs Preview
https://deploy-preview-4279--netlify-cms-www.netlify.app/docs/configuration-options/#preview_path
https://deploy-preview-4279--netlify-cms-www.netlify.app/docs/configuration-options/#summary
https://deploy-preview-4279--netlify-cms-www.netlify.app/docs/beta-features/#folder-collections-media-and-public-folder
Questions for reviewers

Is the naming convention of the PR title okay?
Thoughts on using nested_path as the template key? Going with dirname
Where should I document this? In the Beta Features or summary and preview_path sections?

Test plan

Set up the config as above.
Create a new "Nested Collection" with a Path set to dir-a/dir-b/hello-world and a Title of Hello World
Save and publish
Return to "Contents" list. The newly created item should look like this screenshot (Note the summary now includes the nested_path):

Click on the Hello World item to go into edit view
Observe the destination for the "View Live" link. It should point to https://example.com/dir-a/dir-b/hello-world

To Do

[X] Write tests
[X] Update docs

A picture of a cute animal (not mandatory but encouraged)
My parents' dogs:

@erezrokah thanks for the review! How about maybe meta_path or even meta.path? Do we use any other key with an underscore as a prefix?
Also, where would be the best place to document the change?

@erezrokah thanks for the review! How about maybe meta_path or even meta.path? Do we use any other key with an underscore as a prefix?

We have a suggestion outlined here https://github.com/netlify/netlify-cms/issues/3100, but it is a breaking change.
Since we have filename and extension it would make sense to have path (or something similar) that would work regardless if one uses nested collection (since the meaning is the same).
We can do it in a non breaking way by only adding it if it doesn't exist before passing to the string template processor.
For documentation, filename and extension are documented next to the relevant configuration item:
https://www.netlifycms.org/docs/configuration-options/#preview_path
https://www.netlifycms.org/docs/configuration-options/#summary

Ah Yup. That makes sense. Okay so to clarify: let's just go with _path in preparation for #3100? Or should I do path with fall-back to _path if it is present in the fields?

Or should I do path with fall-back to _path if it is present in the fields?

Let's go with path and if it's present in as a field use the field.

Let's go with path and if it's present in in a field use the field.

Isn't that the opposite of the current behaviour?
From: https://www.netlifycms.org/docs/configuration-options/#slug

The slug template can also reference a field value by name, eg. {{title}}. If a field name conflicts with a built in template tag name - for example, if you have a field named slug, and would like to reference that field via {{slug}}, you can do so by adding the explicit fields. prefix, eg. {{fields.slug}}.

Apologies for all the questions. Just want to be 100% clear.

Isn't that the opposite of the current behaviour?

You're right, I didn't give enough thought. Doing so will prevent someone from using both the built in template and the field in the same template.
How about file_path? Less options for collisions and since it is only used for summary and preview path the impact won't be that big.

Cool. That makes sense to me. Thanks for the feedback!

@erezrokah This is now ready for review. I know we discussed using file_path, but after having another look, I felt it made more sense to include the changes as part of addFileTemplateFields(). I then realised, a more accurate key would be dirname as it doesn't actually include the file itself. Just the parent directory's path. It also then matches the node API too.

@erezrokah This is now ready for review. I know we discussed using file_path, but after having another look, I felt it made more sense to include the changes as part of addFileTemplateFields(). I then realised, a more accurate key would be dirname as it doesn't actually include the file itself. Just the parent directory's path. It also then matches the node API too. Plus, I think dirname is maybe even less likely to have a naming collision with the fields.

Yes, this is much better!


Which OSI layer should KCP belong when combined with DTLS?

Should I use DTLS as L4 first or KCP as L4 first?

KCP is independent from any OSI layer.
You can either use DTLS or raw UDP to send/receive kcp packets.


Investigate embedded versions of Tk

Go through the Perl Tk releases and find which versions embed which

tk
libjpeg

Do you mean "Tcl" instead of Tk?
I think Tk has a further complication in that it will use the system-installed version of some libraries, if there is one.

Yes, Tcl, fixed.

Some things to look at

[ ] Tcl
[ ] Tk
[x] Tcl::Tk - based on Tcl module
[x] Tcl::pTk - based on Tcl module
[x] Inline::Tk - does not distribute


Question about the FeedUrl

Hello,
I was looking into some help with the Channable Feed module.

What are possible options for querystring params to pass to the URL? I know you can use page=xx to get the paged results. But are there more options?
On website with multiple storeviews, and multiple (allowed) currencies per storeview.. how can we instruct the feedurl to give the result in the correct currency? For example, we want to feed both EUR and GBP for a specific storeview to channable.

Hope this question is a bit clear, if not let me know..!

A little update to the question, we noticed that we could manipulate the required page by adding page=xx to the feed url. But we also learned that Channable in fact uses a construct via the path:
http(s)://some-url/channable/feed/json/id/{storeId}/token/{token}/page/{page}
This is a bit awkward but okay.
Besides the questions already asked, are there more path constructs like this?

@joggienl, only one currency is supported per storeview. What is the use case for adding multiple currencies in the feed per storeview? About the params, only page and pid is supported, where pid is the product id that can be used to only limit 1 product.

Hi @Marvin-Magmodules, thanks for the reply!
Thanks for the update on what params are supported. Is that documented somewhere?
About the currency, just like with page and pid, we would like to have a way to instruct the module to return the prices of the feed in a specific currency (like currency=GBP). As an example, we have an "en" (english) storeview that both supports EUR and GBP. In order to have the correct currency values on the advertisements it is wise to use the conversion that magento itself uses (correct = the same price that is visible on the product detail page). To be clear, we don't want multiple currencies in one request, but we want to import the feed url multiple times, based on the storeviews and currencies we support for that storeview.
Hope that this describes the situation a bit better, perhaps there is a more common way to do this but we have not found that yet 😅 . I noticed that people where adding separate JSON imports in Channable with a mapping of SKU and an (hand)converted price. Personally I do not think that this is a good manner to do so. Since we have the correct data in Magento I would prefer to use that as the source.

Hi joggienl, clear, we've added this to the backlog.

Hi @joggienl, we are happy to share we have added this feature in the v1.10.0 release. The preview and json product feed urls now also accepts '/currency/xxx' so you can use different currencies.
We are closing this issue now but please feel free to reopen the issue if this still occurs.


First take on refactoring search in mozillians.org

Coverage increased (+0.1%) to 89.933% when pulling b34381b8ad896aab8e83ef92fb45d424e9004b26 on akatsoulas:django-haystack into aba5f8f6b2eb6cc782b5f030a2e528eb25f8bda6 on mozilla:master.

Coverage increased (+0.1%) to 89.951% when pulling a7e9ac5a6fa2e566d91e20f128b6b063202eb74d on akatsoulas:django-haystack into aba5f8f6b2eb6cc782b5f030a2e528eb25f8bda6 on mozilla:master.

Coverage increased (+0.1%) to 89.951% when pulling a7e9ac5a6fa2e566d91e20f128b6b063202eb74d on akatsoulas:django-haystack into aba5f8f6b2eb6cc782b5f030a2e528eb25f8bda6 on mozilla:master.

Coverage increased (+0.1%) to 89.951% when pulling 501d2748da0a4c8ca224d4a9153ccf077c0b990a on akatsoulas:django-haystack into aba5f8f6b2eb6cc782b5f030a2e528eb25f8bda6 on mozilla:master.


BUG git ssh地址端口非22 上线单显示不了分支

问题描述
在全部角色下，部署管理页面，获取分支功能 一直获取不到分支
问题描述
日志堆栈贴上来。

截图
拖拽到此处即可上传

运行环境

OS: [e.g. Centos 7.2]
版本 [e.g. aba77b36] 2.0.1

可以进入容器内，git clone 一次试试，能clone下来，并且公钥已经加入到github上了，再退出容器，应该就可以加载出来分支了。可能是首次clone，需要确认下信息造成的


Max iterations (=1000) during X axis label placement reached

I'm seeing this printed just before a plot is generated:
tplot/utils.py:160: UserWarning: Max iterations (=1000) during X axis label placement reached.
  warn(

I'm afraid it's not a useful message. I'm not doing anything unreasonable, so tplot should ideally work without this warning.
I had just 13 data points. I guess tplot was trying to plot too many x-axis values, too closely, and with too many decimal places. The warning actually went away with 14 data points; it now shows one less decimal place for each label. Still, it would be better if it didn't happen.

Looks like you've found a case where it gets stuck in an infinite loop while trying to fit in all the labels for the X axis. That should never happen, so it's definitely a bug. I put in that error message just so if it ever happened, at least it would tell you something's wrong instead of just running forever.
Could you post a minimum reproducible code example that generates this error?

Should be fixed with the new release. Turns out it was an instability in the optimization loop caused by too big of a step size.
I also lowered the number of X ticks being drawn to prevent the labels from crowding too much.


error during installation

during installation on a Windows 10 operating system it gives this following error:
Command "c:\users\[NAME]\appdata\local\programs\python\python37-32\python.exe -u -c "import setuptools, tokenize;__file__='C:\\Users\\[NAME]\\AppData\\Local\\Temp\\pip-install-5v9s9_is\\twisted\\setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" install --record C:\Users\[NAME]\AppData\Local\Temp\pip-record-hkrdxptc\install-record.txt --single-version-externally-managed --compile" failed with error code 1 in C:\Users\[NAME]\AppData\Local\Temp\pip-install-5v9s9_is\twisted\

I think we'll need some more information to diagnose this one.. did it print anything else out before that line?
What command did you use to install it?
Magic-wormhole depends upon some other Python libraries, some of which have binary components that must be compiled (and which depend upon some binary libraries being installed like libsodium), so that might be a factor.

I seem to have solve the issue, the error was that i had to download visual c++.
But me stupid, i forgot that i posted this issue, hope i didn't cause any disturbance.


Organization environments page styles

[ ] Index
[ ] Show

@sandersonet Did we decide to remove the "environments" link from org settings for now? Should we close this issue?

Yeah, this isn't in scope for launch but will probably need addressed soon after.  I removed the milestone.

Fixed by #327


always gets Errors

Hi
I tried this with different settings and always get this errors!
Maybe you can help me? would be great....thanks
greets chris

Can you post your folder structure, config and details about your ESPHome setup?

Here they are
meter01.yaml (1).txt

Can you repeat the steps listed in the readme at https://github.com/DomiStyle/esphome-dlms-meter#software-installation?
Most noteably, your directory structure should look like this:

config

meter01.yaml

esphome-dlms-meter

Contents of this repository (espdm.h, ...)

Make sure to remove any stray files from this repo you have added in your root config directory.
Change the includes line to this afterwards:
  includes:
    - ./esphome-dlms-meter

Don't include the .h file directly.

ok i will try this in the evening and give you feedback!
thanks

so i tried this, but there is the next or other error

meter01.yaml.txt

Can you try with the new version I just pushed? Don't forget to clean previous build files and edit your config:
auto dlms_meter = new esphome::espdm::DlmsMeter(id(mbus));

ok, thanks, you are incredible. with the new version the compile works and i can test if the esp32 works with my smartmeter
thanks thanks thanks


get.zplug.sh should answer https

Problem Summary
If I'm going to pipe the output of curl straight into my shell to execute, I'd at least like the URL I'm hitting to be HTTPS (yes, I see it redirects to a HTTPS github URL, but that doesn't prevent Bad Things happening before that).
System Information
N/A
Minimal zshrc
N/A
Steps to Reproduce
~ ❯ http get.zplug.sh
HTTP/1.1 302 Found

 ~ ❯ http https://get.zplug.sh
http: error: ConnectionError: HTTPSConnectionPool(host='get.zplug.sh', port=443): Max retries exceeded with url: / (Caused by NewConnectionError('<requests.packages.urllib3.connection.VerifiedHTTPSConnection object at 0x10f957d50>: Failed to establish a new connection: [Errno 61] Connection refused',)) while doing GET request to URL: https://get.zplug.sh/

Thanks for suggestion!
This proposal have been completed but please use https://zplug.sh/installer instead of https://get.zplug.sh because it's down now.

https://zplug.sh
https://zplug.sh/installer


Change most Route helpers to return null instead of throwing exceptions

Refactors the Route helper, so that only the Route::get() helper throws an exception if the route is not found, the others now return null.

Replace unnecessary type annotations with example tags

Add a Route::getOrFail method instead

I think this will introduce more complexity than solve problems. Closing.


[NEW] Swag Opportunity  🎉

Name Of Organization
Globo
Description

Contribute to two pull requests in any in any eligible repo during the month of October.
Ensure that at least one pull request is merged.

Swag Items
T-shirt
Link to proof
https://hacktoberfest.globo.com/

Globo is already a part of the list 😁 @idivyanshbansal


Please add support closePaneRight/Left/Up/Down

Description of the new feature/enhancement
I want to look for a way to close eg right pane and bind it to a hot key.
Currently, to close eg right pane, I need move focus to right pane first. Then close it.

Proposed technical implementation details (optional)
Please add support closePaneRight/Left/Up/Down.
Then people can bind it to a hot key
Thanks.

Okay I like the idea, but what happens when someone's got something like the following:
[ A | B | C ]

What happens when they closeRight from pane A? Or the even more complicated [ A | B | C | D ]? What happens when the nesting gets ridiculous like

If "multi command binding" is supported, that would be even better.

Ah okay. What you really want is tracked over here, in #3992. Thanks for helping clarify!
/dup #3992


softDelete() provider should not inherit from original params

https://github.com/feathersjs-ecosystem/feathers-hooks-common/blob/f91393d839e0f155ccf15f7e7d5f6e1b35977015/lib/services/soft-delete.js#L37
So in the softDelete function the params.provider is inherited from the original method (remove), but it should be an internal call like it was in previous versions (feathers-plus) of softDelete, this was done by setting the provider inside of softDelete to undefined. This is better for permissions etc, cause for example people are allowed to delete (and so call the remove hook) but aren't allowed to patch.
Now the question is how will this be changed, are we adding that back by default like something:
 const result = await service.patch(context.id, data, { ...params, provider: undefined });

Or are we going to add it with a property option like:
softDelete({
  removeParams: async () => {
    return { provider: undefined };
  },
})

And merge it just like how we do with the query.
I think the removeParams is more flexible in my opinion but it is also a bit double cause we have a deletedQuery, what is technically inside the params.query.
Or maybe we should add an removeProvider function, any thoughts?
Depending whats the outcome of this is I can make a PR for either implementation.

+1 on this features if this is not too late.
I think the second implementation leaves the user more flexibility.


Run tests on Python 3.10

Let's see how this goes. NumPy has wheels up now, but matplotlib will still have to install from source.

Appveyor is unhappy:

Yeah, apparently 3.10 support is still pending for Appveyor. It looks like for Python 3.8/3.9 this took 20-30 days, so hopefully soon?

Can we drop Appveyor? We have Windows support in the cibuildwheel integration now, right?

I guess we'd have to add a separate regular-CI GHA job, which is a bit of work - but will help in the long run.

I guess we'd have to add a separate regular-CI GHA job, which is a bit of work - but will help in the long run.

Yeah, we should be able to do that. In the meantime, Appveyor added 3.10 support yesterday, so I have restarted the CI run here.

looks like Python 3.10 on 32-bit windows is building a NumPy wheel since only a 64-bit one is on PyPI. Should we drop the 32-bit case here for Python 3.10?

Great. IIRC the NumPy 32-bit wheel will still follow; it's important for a few more years. Only the Linux 32-bit wheel was permanently dropped. So 32-bit Windows we can skip for now, but should re-enable once NumPy has it.

There's something funky going on with futures (an indirect dependency):
Collecting futures
  Downloading futures-3.0.5.tar.gz (25 kB)
  Preparing metadata (setup.py): started
  Preparing metadata (setup.py): finished with status 'error'
  ERROR: Command errored out with exit status 1:
   command: 'C:\Python310-x64\python.exe' -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'C:\\Users\\appveyor\\AppData\\Local\\Temp\\1\\pip-install-1lf13oq0\\futures_55dd161babf14d49a09990ebdac1bbe9\\setup.py'"'"'; __file__='"'"'C:\\Users\\appveyor\\AppData\\Local\\Temp\\1\\pip-install-1lf13oq0\\futures_55dd161babf14d49a09990ebdac1bbe9\\setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base 'C:\Users\appveyor\AppData\Local\Temp\1\pip-pip-egg-info-zw6f85rb'
       cwd: C:\Users\appveyor\AppData\Local\Temp\1\pip-install-1lf13oq0\futures_55dd161babf14d49a09990ebdac1bbe9\
  Complete output (24 lines):
  Traceback (most recent call last):
    File "<string>", line 1, in <module>
    File "C:\Python310-x64\lib\site-packages\setuptools\__init__.py", line 18, in <module>
      from setuptools.dist import Distribution
    File "C:\Python310-x64\lib\site-packages\setuptools\dist.py", line 32, in <module>
      from setuptools.extern.more_itertools import unique_everseen
    File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
    File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
    File "<frozen importlib._bootstrap>", line 674, in _load_unlocked
    File "<frozen importlib._bootstrap>", line 571, in module_from_spec
    File "C:\Python310-x64\lib\site-packages\setuptools\extern\__init__.py", line 52, in create_module
      return self.load_module(spec.name)
    File "C:\Python310-x64\lib\site-packages\setuptools\extern\__init__.py", line 37, in load_module
      __import__(extant)
    File "C:\Python310-x64\lib\site-packages\setuptools\_vendor\more_itertools\__init__.py", line 1, in <module>
      from .more import *  # noqa
    File "C:\Python310-x64\lib\site-packages\setuptools\_vendor\more_itertools\more.py", line 5, in <module>
      from concurrent.futures import ThreadPoolExecutor
    File "C:\Users\appveyor\AppData\Local\Temp\1\pip-install-1lf13oq0\futures_55dd161babf14d49a09990ebdac1bbe9\concurrent\futures\__init__.py", line 8, in <module>
      from concurrent.futures._base import (FIRST_COMPLETED,
    File "C:\Users\appveyor\AppData\Local\Temp\1\pip-install-1lf13oq0\futures_55dd161babf14d49a09990ebdac1bbe9\concurrent\futures\_base.py", line 357
      raise type(self._exception), self._exception, self._traceback
                                 ^
  SyntaxError: invalid syntax
  ----------------------------------------
WARNING: Discarding https://files.pythonhosted.org/packages/55/db/97c1ca37edab586a1ae03d6892b6633d8eaa23b23ac40c7e5bbc55423c78/futures-3.0.5.tar.gz#sha256=0542525145d5afc984c88f914a0c85c77527f65946617edb5274f72406f981df (from https://pypi.org/simple/futures/). Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
  Downloading futures-3.0.4.tar.gz (25 kB)
  Preparing metadata (setup.py): started
  Preparing metadata (setup.py): finished with status 'error'
...
<etc - pip goes in a loop here>

It looks like we can safely ignore that for now though.

There's something funky going on with futures (an indirect dependency) on the 3.10 Appveyor builds:

I figured this one out, futures is Python 2 only, and there was a stray install of it in appveyor.yml. I'll fix that in a follow-up. In it goes, thanks @grlee77!

Follow up done in commit cc34ea91.


Fix hardcoded $$ reference

PR Type
What kind of pull request is this? Put an x in all the boxes that apply:

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Extend feature (non-breaking change which extends existing functionality)
[ ] Change feature (non-breaking change which either changes or refactors existing functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

What does it change?
Removed a hardcoded reference to '$$' in Pipe\Item.
Why this PR?
If I want to change the identifier it didn't work as expected.
How has this been tested?
Full test stack passes.
Checklist
To facilitate merging your change and the approval of this PR, please make sure you've reviewed and applied the following:

This PR addresses exactly one issue
All changes were made in a fork of this project (preferably also in a separate branch)
It follows the code style of this project
Tests were added to cover the changes
All previously existing tests still pass
If the change to the code requires a change to the documentation, it has been updated accordingly

If you're unsure about any of these, don't hesitate to ask. We're here to help!

Hi, thanks for the PR!
Good catch, just one question: how are you changing the identifier? Did you extend the class to gain access to the identifier? And how are you using the class; global method take() helper or new Item? Maybe a setIdentifier would be of more use the.

I had one instance where I wanted to change the ID, I extended the class
with a constructor that took an optional second $placeholder argument.
I'm not super sure a setter would be useful, I feel like doing
take('something')->setIdentifier('##')->pipe(...etc) would be
inconvenient enough that no one would do it.
On Sun, Nov 5, 2017 at 12:14 PM Sebastiaan Luca<EMAIL_ADDRESS>wrote:

Hi, thanks for the PR!
Good catch, just one question: how are you changing the identifier? Did
you extend the class to gain access to the identifier? And how are you
using the class; global method take() helper or new Item? Maybe a
setIdentifier would be of more use the.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sebastiaanluca/laravel-helpers/pull/11#issuecomment-341988933,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMj2QbhyyS8y56qoPiCRnygMuVXYN2S8ks5szez4gaJpZM4QScbW
.

Yeah, an instance setter might not be that useful. Perhaps a static setter or a second parameter like you did? Just thinking out loud since I'm adding a ton more helpers and maybe I can add this too in the next version.
// Static setter, then used for all pipe operator items. Could be set in a service provider if you're using Laravel like the Migration class does.
Item::setIdentifier('??');

// Optional instance constructor parameter
new Item('value', '??');

Merged!

Personally I think an option constructor parameter is the most useful.
What would actually be super interesting is if the Item class used a magic __call() to delegate method calls to pipe(). Then you could do this:
take('item')
    ->strtoupper()
    ->get()

It's completely optional, users can still call pipe() if they wish. But it does decrease the friction of using piping if you don't have to call pipe() plus the callable as a string.
This would do it:
public function __call ($name, $args)
{
    return $this->pipe($name, ...$args);
}

Oooh, I like that idea! Consider it implemented in the next release 😊


Deploy Checklist: New Expensify 2023-09-25

Release Version: 1.3.74-2
Compare Changes: https://github.com/Expensify/App/compare/production...staging
This release contains changes from the following pull requests:

[x] https://github.com/Expensify/App/pull/19345
[x] https://github.com/Expensify/App/pull/23225
[x] https://github.com/Expensify/App/pull/23390
[x] https://github.com/Expensify/App/pull/23712
[x] https://github.com/Expensify/App/pull/24319
[x] https://github.com/Expensify/App/pull/24407
[x] https://github.com/Expensify/App/pull/25416
[x] https://github.com/Expensify/App/pull/26029
[x] https://github.com/Expensify/App/pull/26236
[x] https://github.com/Expensify/App/pull/26543
[x] https://github.com/Expensify/App/pull/26710
[x] https://github.com/Expensify/App/pull/26727
[x] https://github.com/Expensify/App/pull/26851
[x] https://github.com/Expensify/App/pull/26861
[x] https://github.com/Expensify/App/pull/26877
[x] https://github.com/Expensify/App/pull/26934
[x] https://github.com/Expensify/App/pull/26969
[x] https://github.com/Expensify/App/pull/26973
[x] https://github.com/Expensify/App/pull/26982
[ ] https://github.com/Expensify/App/pull/27025
[x] https://github.com/Expensify/App/pull/27127
[x] https://github.com/Expensify/App/pull/27203
[x] https://github.com/Expensify/App/pull/27224
[x] https://github.com/Expensify/App/pull/27230
[x] https://github.com/Expensify/App/pull/27298
[x] https://github.com/Expensify/App/pull/27314
[x] https://github.com/Expensify/App/pull/27368
[x] https://github.com/Expensify/App/pull/27437
[x] https://github.com/Expensify/App/pull/27439
[x] https://github.com/Expensify/App/pull/27459
[x] https://github.com/Expensify/App/pull/27468
[x] https://github.com/Expensify/App/pull/27475
[x] https://github.com/Expensify/App/pull/27505
[x] https://github.com/Expensify/App/pull/27506
[ ] https://github.com/Expensify/App/pull/27518
[x] https://github.com/Expensify/App/pull/27520
[x] https://github.com/Expensify/App/pull/27550
[x] https://github.com/Expensify/App/pull/27613
[x] https://github.com/Expensify/App/pull/27619
[x] https://github.com/Expensify/App/pull/27627
[x] https://github.com/Expensify/App/pull/27638
[x] https://github.com/Expensify/App/pull/27640
[x] https://github.com/Expensify/App/pull/27643
[x] https://github.com/Expensify/App/pull/27644
[x] https://github.com/Expensify/App/pull/27645
[x] https://github.com/Expensify/App/pull/27649
[x] https://github.com/Expensify/App/pull/27653
[x] https://github.com/Expensify/App/pull/27656
[x] https://github.com/Expensify/App/pull/27657
[x] https://github.com/Expensify/App/pull/27661
[x] https://github.com/Expensify/App/pull/27664
[x] https://github.com/Expensify/App/pull/27674
[x] https://github.com/Expensify/App/pull/27679
[x] https://github.com/Expensify/App/pull/27682
[x] https://github.com/Expensify/App/pull/27690
[x] https://github.com/Expensify/App/pull/27702
[x] https://github.com/Expensify/App/pull/27711
[x] https://github.com/Expensify/App/pull/27732
[x] https://github.com/Expensify/App/pull/27733
[x] https://github.com/Expensify/App/pull/27734
[x] https://github.com/Expensify/App/pull/27738
[x] https://github.com/Expensify/App/pull/27739
[x] https://github.com/Expensify/App/pull/27740
[x] https://github.com/Expensify/App/pull/27743
[x] https://github.com/Expensify/App/pull/27747
[x] https://github.com/Expensify/App/pull/27749
[x] https://github.com/Expensify/App/pull/27750
[x] https://github.com/Expensify/App/pull/27753
[x] https://github.com/Expensify/App/pull/27758
[x] https://github.com/Expensify/App/pull/27762
[x] https://github.com/Expensify/App/pull/27765
[x] https://github.com/Expensify/App/pull/27769
[x] https://github.com/Expensify/App/pull/27784
[x] https://github.com/Expensify/App/pull/27795
[x] https://github.com/Expensify/App/pull/27797
[x] https://github.com/Expensify/App/pull/27798
[x] https://github.com/Expensify/App/pull/27808
[x] https://github.com/Expensify/App/pull/27816
[x] https://github.com/Expensify/App/pull/27825
[x] https://github.com/Expensify/App/pull/27828
[x] https://github.com/Expensify/App/pull/27833
[x] https://github.com/Expensify/App/pull/27834
[x] https://github.com/Expensify/App/pull/27840
[x] https://github.com/Expensify/App/pull/27842
[x] https://github.com/Expensify/App/pull/27845
[x] https://github.com/Expensify/App/pull/27851
[x] https://github.com/Expensify/App/pull/27853
[x] https://github.com/Expensify/App/pull/27859
[x] https://github.com/Expensify/App/pull/27868
[x] https://github.com/Expensify/App/pull/27870
[x] https://github.com/Expensify/App/pull/27876
[x] https://github.com/Expensify/App/pull/27877
[x] https://github.com/Expensify/App/pull/27880
[x] https://github.com/Expensify/App/pull/27882
[x] https://github.com/Expensify/App/pull/27883
[x] https://github.com/Expensify/App/pull/27885
[x] https://github.com/Expensify/App/pull/27907
[x] https://github.com/Expensify/App/pull/27908
[x] https://github.com/Expensify/App/pull/27911
[x] https://github.com/Expensify/App/pull/27920
[x] https://github.com/Expensify/App/pull/27921
[x] https://github.com/Expensify/App/pull/27925
[x] https://github.com/Expensify/App/pull/27932
[x] https://github.com/Expensify/App/pull/27938
[x] https://github.com/Expensify/App/pull/27940
[x] https://github.com/Expensify/App/pull/27945
[x] https://github.com/Expensify/App/pull/27946
[x] https://github.com/Expensify/App/pull/27955
[x] https://github.com/Expensify/App/pull/27956
[x] https://github.com/Expensify/App/pull/27957
[x] https://github.com/Expensify/App/pull/27969
[x] https://github.com/Expensify/App/pull/27974
[x] https://github.com/Expensify/App/pull/27975
[x] https://github.com/Expensify/App/pull/27978
[x] https://github.com/Expensify/App/pull/27981
[x] https://github.com/Expensify/App/pull/27989
[x] https://github.com/Expensify/App/pull/28000
[x] https://github.com/Expensify/App/pull/28006
[x] https://github.com/Expensify/App/pull/28012
[x] https://github.com/Expensify/App/pull/28050
[x] https://github.com/Expensify/App/pull/28091
[x] https://github.com/Expensify/App/pull/28115
[ ] https://github.com/Expensify/App/pull/28197

Internal QA:

[ ] https://github.com/Expensify/App/pull/27844 - @youssef-lr

Deploy Blockers:

[x] https://github.com/Expensify/App/issues/28129
[ ] https://github.com/Expensify/App/issues/28130
[ ] https://github.com/Expensify/App/issues/28144
[ ] https://github.com/Expensify/App/issues/28147
[ ] https://github.com/Expensify/App/issues/28148
[ ] https://github.com/Expensify/App/issues/28163
[x] https://github.com/Expensify/App/issues/28169
[x] https://github.com/Expensify/App/issues/28196
[x] https://github.com/Expensify/App/issues/28263

Deployer verifications:

[ ] I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
[ ] I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
[ ] I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@chiragsalian Web and mWeb builds are still 1.3.74-0. Could you check?

@mountiny  @chiragsalian we are still waiting for the 1.3.74-1. Are we ok to run the regression on 1.3.74-0?

Regression is 55% of progress in TR. We are still have few PRs to validate.
#27025 failing with #28147 and #28148

I've CPed a fix to staging for these deploy blockers:

https://github.com/Expensify/App/issues/28130
https://github.com/Expensify/App/issues/28144

Checking off https://github.com/Expensify/App/issues/28129 - it is reproducible in production.

@chiragsalian Regression TR is 20% left.
We are still working on the PRs.
We need help with these 2 PRs https://github.com/Expensify/App/pull/27518#issuecomment-1733595278
https://github.com/Expensify/App/pull/26877#issuecomment-1734585118

Regression TR is at 96%
Couple PRs left.
#27518 (comment) - Please help us with this.

@chiragsalian  Regression is completed
Open Blockers
https://github.com/Expensify/App/issues/28130
https://github.com/Expensify/App/issues/28144
https://github.com/Expensify/App/issues/28147
https://github.com/Expensify/App/issues/28148
https://github.com/Expensify/App/issues/28163
https://github.com/Expensify/App/issues/28169
https://github.com/Expensify/App/issues/28263
Unchecked PRs
https://github.com/Expensify/App/pull/27025 is failing with https://github.com/Expensify/App/issues/28147 and https://github.com/Expensify/App/issues/28148
https://github.com/Expensify/App/pull/27518 we validated this with the regular screen size and it seems to be ok. If we need to test different screen sizes on this. Please let us know. Otherwise, i think its good to check off.
https://github.com/Expensify/App/pull/27920 is failing https://github.com/Expensify/App/issues/28260. repro in PROD. checking off
https://github.com/Expensify/App/pull/28197  Pass on all but IOS app. IOS build is not updated

Checking off https://github.com/Expensify/App/issues/28263

Checking off https://github.com/Expensify/App/issues/28169 because it doesn't seem super blocker-y

Checking off https://github.com/Expensify/App/issues/28147, demoted to NAB

Going over the pending items now.

@chiragsalian  if any new CPs need re-testing, let us know

Checking off https://github.com/Expensify/App/issues/28320. Demoted to NAB since the request also fails on prod (with a different error, but same root cause)

I'm checking off https://github.com/Expensify/App/pull/27025 because it looks like further of its fixes are handled here which is not a blocker. So i have checked it off so we can move ahead.

:shipit:


Error id adjustments for intake v2

add transactionId to TraceContext
Error.id is required in intake v2
Error.id is 128 bits long

closes #213

depends on https://github.com/elastic/apm-agent-java/pull/216

Codecov Report

Merging #217 into master will increase coverage by 0.37%.
The diff coverage is 92.45%.

@@             Coverage Diff              @@
##             master     #217      +/-   ##
============================================
+ Coverage     73.19%   73.57%   +0.37%
- Complexity     1088     1108      +20
============================================
  Files           117      117
  Lines          4145     4185      +40
  Branches        403      411       +8
============================================
+ Hits           3034     3079      +45
+ Misses          915      909       -6
- Partials        196      197       +1

Impacted Files
Coverage Δ
Complexity Δ

.../co/elastic/apm/impl/sampling/ConstantSampler.java
100% <ø> (ø)
5 <0> (ø)
:arrow_down:

...co/elastic/apm/plugin/api/SpanInstrumentation.java
51.21% <ø> (ø)
5 <0> (ø)
:arrow_down:

...n/java/co/elastic/apm/impl/transaction/SpanId.java
75% <100%> (-11.67%)
11 <0> (-2)

...ain/java/co/elastic/apm/impl/ElasticApmTracer.java
79.71% <100%> (+0.14%)
40 <0> (ø)
:arrow_down:

...n/java/co/elastic/apm/impl/error/ErrorCapture.java
71.92% <100%> (ø)
19 <1> (ø)
:arrow_down:

.../co/elastic/apm/impl/transaction/AbstractSpan.java
71.21% <100%> (ø)
21 <1> (ø)
:arrow_down:

...a/co/elastic/apm/impl/transaction/Transaction.java
79.48% <100%> (ø)
24 <0> (ø)
:arrow_down:

.../elastic/apm/impl/sampling/ProbabilitySampler.java
100% <100%> (ø)
7 <4> (ø)
:arrow_down:

...re/src/main/java/co/elastic/apm/util/HexUtils.java
91.17% <81.25%> (+13.39%)
18 <11> (+8)
:arrow_up:

...lastic/apm/report/serialize/DslJsonSerializer.java
87.04% <84.61%> (-0.03%)
117 <6> (+2)

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77358dd...9ea4aa4. Read the comment docs.

also depends on https://github.com/elastic/apm-server/pull/1398


UTF8 custom ressource name

I'm trying to do something like this :
# encoding: utf-8
ActiveAdmin.register List, :as => "Présentation" do

…
But when I make this change it produce this :
uninitialized constant Présentation (NameError)
If I replace it by "Presentation" it work like a charm but the title was'nt correct.

You should be able to do this by adding model translations to /config/locales/es.yml.


Hey, I need to check Checkbox only if it is not checked already. How do I implement this in CodeceptJS with webDriverIO? Appreciate any help!

What are you trying to achieve?
What do you get instead?

Provide console output if related. Use --verbose mode for more details.

# paste output here

Provide test source code if related

// paste test

Details

CodeceptJS version:
NodeJS Version:
Operating System:
Protractor || WebDriverIO || Nightmare version (if related)
Configuration file:

# paste suite config here

writed in protractor helper, but must working for webDriverIO...
Scenario.only('Check checkbox only if is not checked', async (I) => {
I.amOnPage('https://material.angular.io/components/checkbox/examples');
let actualStatus = await I.grabAttributeFrom({id: 'mat-checkbox-1-input'}, 'aria-checked');
if (actualStatus === false) {
I.checkOption({id: 'mat-checkbox-1'});
}
});


feat(metadata): Metadata configuration UI

Fixes: #1722
https://github.com/KaotoIO/kaoto-ui/assets/265462/79d0b523-b6b9-4150-a16a-80dc880c479f

There's an exception in the console, but I don't where is coming from yet.

@lordrip yes that's annoying, it appears with patternfly selectable table (left side). It adds <outout class="pf-screen-reader"> element next to every <tr>, right under the <tbody>. Even the patternfly official example shows the same error.

LGTM, just a couple of pending details:

The console error
The panel width changing when empty

LGTM, just a couple of pending details:
* The console error

* The panel width changing when empty

It seems that the console error is coming from the @patternfly/react library
https://codesandbox.io/s/ji85yx

Discussed with @lordrip and now we think editing property name is important. Also the inline input for property value doesn't work with cursor key, so for now I'll remove the inline input and add "edit" button for the popover similar to "add new property".

Interestingly, while the following patternfly official doc also contains <output> under <tbody>, it doesn't show the warning in console
https://www.patternfly.org/v4/components/table/#composable-row-click-handler-hoverable--selected-rows
Although it does show once you open in the sandbox.

inlined property add/edit
https://github.com/KaotoIO/kaoto-ui/assets/265462/54d8cb76-49d7-453a-a886-0edb49b10be3

And fixed tests, should be ready now


New Extension: Keyboard Maestro

Description
A simple extension to list, search, and trigger your Keyboard Maestro macros
Screencast
I don't have a great way to demo this, so I hope this screencast is helpful
https://cln.sh/4aUELs
Checklist

[X] I read the extension guidelines
[X] I read the documentation about publishing
[X] I ran npm run build and tested this distribution build in Raycast

🎉


[core] Ensure enough tasks for scan.manifest.parallelism

Purpose

Tests

API and Format

Documentation

Thanks @leaves12138 for your commit!


Updates to handbook/grow

fix broken links by removing them (content is available in a toggle so you don't have to go to another page)

Mergin this! Thanks @plhnk !


[Demangler] Fix assertion failure.

It's illegal to call node->addChild() with a NULL child argument; it's possible to construct unexpected Node trees by passing invalid manglings, and in this case that was causing popTypeAndGetChild() to fail (because the top node was not a Type node), which then meant that the call to addChild had a NULL child argument.
The simplest fix is to use createWithChildren() to do the node construction, because that function checks its arguments for NULLs.
rdar://125350219

@swift-ci Please smoke test


pkg/osutil: fix missing 'syscall' import

CI didn't catch this :0
With that build tag

lgtm

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@95078c2). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #7931   +/-   ##
=========================================
  Coverage          ?   74.83%
=========================================
  Files             ?      339
  Lines             ?    26388
  Branches          ?        0
=========================================
  Hits              ?    19748
  Misses            ?     5204
  Partials          ?     1436

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95078c2...fba225c. Read the comment docs.


Create all data schema

With the DB env variables configured, you can create all data schema with sequelize.sync() method see the sequelize docs

Can you explain where you would put this method and how to use it to create all data schema?
I read the doc but I don't understand how to use it in your project :/

Well dude as i remember you can do that from your models, there you have imported the sequelize dependency.  here you can found a short example https://gist.github.com/wellington1993/7758f5f531085b8bb99fc42622f72d56


[ISSUE] HybridResponseTypeHandler can not work with self-contained access token

Describe the issue:
If we use OpenID Connect hybrid flow for authentication [1] with both token & id_token while using the self-contained access tokens enabled, it returns an expired access token.
Because HybridResponseTypeHandler [2] invokes generateAccessToken() twice when we request both token & id_token. If we had enabled self-contained access tokens, it will issue a new token everytime we invoke generateAccessToken() and mark previous one as expired.
In our case, it generates the access token once and generates the id_token in an additional generateAccessToken() invocation. Now it will pass the previous token in the response which is already expired.
How to reproduce:

Enable OpenID Connect hybrid flow for authentication with code id_token token [1]
Use JWT issuer under OAuth config
Send /oauth2/authorize request with response_type=code id_token token

The returned self-contained access token is already marked as expired in the DB.
Suggestion:
It should not invoke generateAccessToken() twice when we request both token & id_token at the same time. Instead, it can use the way we have generated both token and id_token in IDTokenResponseTypeHandler [3].
[1] https://is.docs.wso2.com/en/5.9.0/learn/openid-connect-hybrid-flow/
[2] https://github.com/wso2-extensions/identity-inbound-auth-oauth/blob/master/components/org.wso2.carbon.identity.oauth/src/main/java/org/wso2/carbon/identity/oauth2/authz/handlers/HybridResponseTypeHandler.java
[3] https://github.com/wso2-extensions/identity-inbound-auth-oauth/blob/master/components/org.wso2.carbon.identity.oauth/src/main/java/org/wso2/carbon/identity/oauth2/authz/handlers/IDTokenResponseTypeHandler.java

Fixed with https://github.com/wso2-extensions/identity-inbound-auth-oauth/pull/1368


[Feature Request] Stats sheet

Please add a way to see your current attributes.

I recently try a mod with the this feature and it has a affix system like apotheosis, this mod's stats sheet is able to show the stats modifier of other mod and the final number of particular attribute. https://github.com/Minecraft-LightLand/L2Artifacts

This is slated for 6.3.0


Error when runnnig hackernews example

When I try to run the hackernews example I get the following error:
# github.com/diamondburned/adaptive
../../../go/pkg/mod/github.com/diamondburned/adaptive@v0.0.2-0.20220112080859-3636e96e0c60/fold.go:375:31: w.GetNative undefined (type *gtk.Overlay has no field or method GetNative)

I'm expiriencing the same problem


chore(aws): Add failed_checks to track

Context
This PR makes the AWS ec2 service and around around 15 prowler checks, that verify whether ports are open to the Internet, more concise. This PR relates to PR #3977 and PR #3979.
Description
I find it more concise to introduce a state_manager instead to share with a dozen of other checks a specific property public_ports of a specific check ec2_securitygroup_allow_ingress_from_internet_to_all_ports within the ec2_service.
I find the the code now clearer, cleaner, easier to extend and easier to maintain. It also saves some CPU cycles because  the method check_security_group in the ec2_service does not need to be called for each check anymore.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Hi @kagahd I like your idea but we are not sure about including it at this time since we want to create an execution manager in top of Prowler's scan.

Hi @jfagoagas,

Maybe it'll be easier for now to save something within the EC2 service, what do you think?

I preferred a separation of concerns by using the state_manager but we can put its functionality also in the ec2 service, if you prefer.
I just adapted the PR accordingly.

Could you add a test for each check while checking that ec2_client.is_failed_check() returns true, thus no findings will be generated?

Sure, I will add them later today.

Hi @jfagoagas
could you please advise, why the pr-lint-test tests are failing after my last last commits of today? When I run them locally, only 2 of a total 3175 unit tests are failing:
poetry run pytest -n auto --cov=./prowler --cov-report=xml tests
...
=========================================================================================== short test summary info ===========================================================================================
FAILED tests/providers/aws/services/route53/route53_dangling_ip_subdomain_takeover/route53_dangling_ip_subdomain_takeover_test.py::Test_route53_dangling_ip_subdomain_takeover::test_hosted_zone_dangling_public_record - urllib.error.URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:997)>
FAILED tests/providers/aws/services/route53/route53_dangling_ip_subdomain_takeover/route53_dangling_ip_subdomain_takeover_test.py::Test_route53_dangling_ip_subdomain_takeover::test_hosted_zone_external_record - urllib.error.URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:997)>
=========================================================================== 2 failed, 3173 passed, 36 warnings in 399.73s (0:06:39) ===========================================================================
~

And these 2 failing unit tests are not from me. I didn't touch them.
Why the github workflow failed on so many unit tests?
Thanks for your help!

Hi @jfagoagas could you please advise, why the pr-lint-test tests are failing after my last last commits from today? When I run them locally, only 2 of a total 3175 unit tests are failing (which were failing also before my todays commits):
poetry run pytest -n auto --cov=./prowler --cov-report=xml tests
...
=========================================================================================== short test summary info ===========================================================================================
FAILED tests/providers/aws/services/route53/route53_dangling_ip_subdomain_takeover/route53_dangling_ip_subdomain_takeover_test.py::Test_route53_dangling_ip_subdomain_takeover::test_hosted_zone_dangling_public_record - urllib.error.URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:997)>
FAILED tests/providers/aws/services/route53/route53_dangling_ip_subdomain_takeover/route53_dangling_ip_subdomain_takeover_test.py::Test_route53_dangling_ip_subdomain_takeover::test_hosted_zone_external_record - urllib.error.URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:997)>
=========================================================================== 2 failed, 3173 passed, 36 warnings in 399.73s (0:06:39) ===========================================================================
~

And these 2 failing unit tests are not from me. I didn't touch them. Why the github workflow failed on so many unit tests? Thanks for your help!

I think your forked repo wasn't up to date with Prowler's master. I've sync'ed your master branch and then merge that branch against this. Probably failing test happened due to this and also Github actions are degraded today so that could be also.

Hi @jfagoagas, the github workflow failed again with the same errors. Do you have another idea what the reason could be?

Hi @jfagoagas, the github workflow failed again with the same errors. Do you have another idea what the reason could be? In line 155 it says AttributeError: module 'prowler.providers.common' has no attribute 'common' but other unit tests do the same what's marked in line 105:
        with mock.patch(
            "prowler.providers.common.common.get_global_provider",
            return_value=aws_provider,
        ),

What's wrong with it?

Yesterday we merged a PR which changes the location of the get_global_provider function, that was the issue. I've pushed a fix.

Yesterday we merged a PR which changes the location of the get_global_provider function, that was the issue. I've pushed a fix.

That makes sense, thanks a bunch!

I have just one question left because I'm not sure, what was the previous behaviour when running an specific port check with the public_ports set to True? I thought we were not raising a finding but I'm not sure I have to test it, I mean to not modify that behaviour now.

what was the previous behaviour when running an specific port check with the public_ports set to True? I thought we were not raising a finding

Exactly, you were not raising a finding, the status was "PASS".
This behaviour is still the same, the status is still "PASS". However, I adapted the report.status_extended in order to mention that "has all ports open to the Internet and therefore was not checked against the specific XYZ port". Without my adaption of  report.status_extended you would still have a message like "Security group ABC does not have XYZ port open to the Internet." which is quite wrong because all ports are open.

what was the previous behaviour when running an specific port check with the public_ports set to True? I thought we were not raising a finding

Exactly, you were not raising a finding, the status was "PASS". This behaviour is still the same, the status is still "PASS". However, I adapted the report.status_extended in order to mention that "has all ports open to the Internet and therefore was not checked against the specific XYZ port". Without my adaption of report.status_extended you would still have a message like "Security group ABC does not have XYZ port open to the Internet." which is quite wrong because all ports are open.

Thanks for confirming that, maybe we can remove that PASS finding in the future, but at the end the important ones are the FAIL findings and not to raise 2 with the same information.


Bump runtime to v0.48.0

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.1%) to 38.387%

Files with Coverage Reduction
New Missed Lines
%

pkg/app/server/server.go
3
75.16%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
1152

Relevant Lines:
3001

💛  - Coveralls


Tan11389/update http to https

Updated http to https when getting elevation source.

not trying to merge with master.


SSL certificate error for muazkhan.com:9001

Hi,
when I try to connect to muazkhan.com:9001, I am faced with an SSL certificate error.
can you please fix it ASP?
Thanks,
Hamid

Fixed.