GridView bulk delete

Why Grigview don't have bulk delete? Can it be add in common functional?

I think that the bulk delete should be implemented by the programmer, the GridView, any data source can be used.

That's not about data source. It's about UI such as the one in GMail:

If it is possible to do it :)

Can the solution of this issue be around providing support for kind of a toolbar for the GridView, a toolbar attribute which can hold an array of Yiisoft\Html\Tag\Button. And of course toolbarAttributes.
Proposed markup:

    <button>Action 1</button>
    <button>Action 2</button>
    <button>Action 3</button>

     ...

This is not providing any functionality, just the markup for the controls. Functionality must be provided by the developer independently, and it's supposed to be used together with CheckboxColumn, not just for bulk delete, but for export, or others.
Also the styling is not provided by GridView itself.

This can be implemented via toolbar with buttons (as @glpzzz suggested) or with select, that contain actions:

But, I think, this features should to be postponed until after the release.


[linq2db] NULL value of image type returned as empty

Following query returns null for native provider and byte[0] for managed:
Assert.That(conn.Execute<byte[]>("SELECT Cast(NULL as image)"),           Is.EqualTo(null));

linq2db test (for tracking): SybaseTests.TestBinary

case TdsDataType.TDS_IMAGE:
                    {
                        var textPtrLen = (byte)stream.ReadByte();
                        if (textPtrLen == 0) // it is 16
                        {
                            return DBNull.Value;
                        }
// filled with 0xFF
var textPtr = new byte[textPtrLen];
                        stream.Read(textPtr, 0, textPtrLen);

Fixed!


code in directory .../scylladb/gocql expects import "github.com/gocql/gocql"

Please answer these questions before submitting your issue. Thanks!
go version
go version go1.13.6 linux/amd64

What did you do?
go get github.com/scylladb/gocql
package github.com/scylladb/gocql: code in directory /home/dyasny/go/src/github.com/scylladb/gocql expects import "github.com/gocql/gocql"

What did you expect to see?
a module installed with no errors

This is not really the preferred way to work with the library. The idea is to work with the original code and imports then change implementation by using a replace directive in the go.mod file. I think this is stated in the readme but perhaps we can make it more clear.


Doesn't work with unsaved contacts !

It doesn't work as expected with unsaved contacts ..instead of sending the files to the specified contact it shows list of saved contacts and ask to choose out of them!

Any work around for this ?

You can try using click to chat feature from WhatsApp
Create your own link
Use https://wa.me/ where the  is a full phone number in international format. Omit any zeroes, brackets, or dashes when adding the phone number in international format.
Use: https://wa.me/1XXXXXXXXXX
Don't use: https://wa.me/+001-(XXX)XXXXXXX

Create your own link with a pre-filled message
The pre-filled message will automatically appear in the text field of a chat. Use https://wa.me/whatsappphonenumber?text=urlencodedtext where whatsappphonenumber is a full phone number in international format and urlencodedtext is the URL-encoded pre-filled message.
To create a link with just a pre-filled message, use https://wa.me/?text=urlencodedtext
Example: https://wa.me/?text=I'm%20inquiring%20about%20the%20apartment%20listing

After clicking on the link, you’ll be shown a list of contacts you can send your message to.
Source : https://faq.whatsapp.com/5913398998672934/?helpref=uf_share

You can try using click to chat feature from WhatsApp
Create your own link
Use https://wa.me/ where the is a full phone number in international format. Omit any zeroes, brackets, or dashes when adding the phone number in international format.
Use: https://wa.me/1XXXXXXXXXX
Don't use: https://wa.me/+001-(XXX)XXXXXXX

Create your own link with a pre-filled message
The pre-filled message will automatically appear in the text field of a chat. Use https://wa.me/whatsappphonenumber?text=urlencodedtext where whatsappphonenumber is a full phone number in international format and urlencodedtext is the URL-encoded pre-filled message.
To create a link with just a pre-filled message, use https://wa.me/?text=urlencodedtext
Example: https://wa.me/?text=I'm%20inquiring%20about%20the%20apartment%20listing

After clicking on the link, you’ll be shown a list of contacts you can send your message to.
Source : https://faq.whatsapp.com/5913398998672934/?helpref=uf_share

Yes, that works irrespective of the saved contacts. But I can't attach files.

That's right @rahul-yr . For now I can't think of any workaround regarding Sharing files to unsaved WhatsApp contacts. Will keep you posted if I find anything.

ok

Add Below Flag into Native Android Code into shareFiles Functions


Allow {"$ref": "#/path/to/property/definition"} in schema

Hi,
I don't know what your goals with this plugin are; but they kind of align with so far with mine. For me the intention is making a customer configurable form editor. My previous implementation is based on an own DSL, but using JSON-schema notation seems a better way to, hence my interest in your approach.
This PR adds basic functionality for referencing properties; this allows for reuse and for recursion. So far this approach works, but it is obvious there is a lot of room for enhancements.
The lookup code is slightly based on https://github.com/acornejo/jjv
Hope this aligns with your goals too. Any way we can get in contact to discuss that?
Kind regards,
Sjoerd

:+1:, I believe that this implements https://github.com/aptible/ember-json-schema/issues/13 for us also.


Example for finetuning a trained controlnet model by using dpo with human feedback data?

Hi, i have a trained controlnet model to generate images，and i want to finetune the model with human feedback data by using DPO
How to do that with trl?

Hi there, currently we only have DDPO integrated in TRL for images, unfortunately DPO is not integrated, yet.

Hi there, currently we only have DDPO integrated in TRL for images, unfortunately DPO is not integrated, yet.

Is there any plan for that?

Yes, we are looking into it! cc @kashif @sayakpaul


[Module Builder] Reset Slide

Notion ticket link

[Module Builder] Reset Slide

Implementation description

Currently, the trash button removes the slide completely. Instead, we want to have the trash button reset the slide.
Additionally, reducer should not mutate state.

Steps to test

Click trash button and ensure that a slide resets itself rather than deletes itself.

What should reviewers focus on?

Functionality of resetting
Ensure reducer is written correctly

Checklist

[x] My PR name is descriptive and in imperative tense
[x] My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
[x] I have run the appropriate linter(s)
[x] I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

I'm not really sure if REMOVE_SLIDE reducer is needed anymore if the trash button has the reset button functionality? But wasn't too sure so I did not remove that code yet, so if I could get confirmation on that, that would be great.

This PR Works as intended. However, do we plan to add a separate delete button for the individual slides? I feel like this should be made clear to the users (perhaps by having a separate "clear" button and "delete" button) as the trash icon is most commonly associated with deletion (and in other parts of the our app is used as such). I think we would want to have some sense of consistency across our app. Thoughts @xsharonhe @tawnyzhao ?

This PR Works as intended. However, do we plan to add a separate delete button for the individual slides? I feel like this should be made clear to the users (perhaps by having a separate "clear" button and "delete" button) as the trash icon is most commonly associated with deletion (and in other parts of the our app is used as such). I think we would want to have some sense of consistency across our app. Thoughts @xsharonhe @tawnyzhao ?

I think I agree with this which is why I was confused about changing the trash button from a delete function to a reset function, but it seems like in the future, we will be having two separate buttons, so I will revert this change.


Gemma instructions were deleted in commit

The Gemma instructions at https://github.com/google/maxtext/blob/main/getting_started/Run_Gemma.md were deleted in commit 04fa373. As such, the link to that file in https://github.com/google/maxtext#getting-started gives a 404.

Similarly, https://github.com/google/maxtext/blob/main/end_to_end/gemma/test_convert_chkpt.sh doesn't exist any more, hence the pointer to that file in https://github.com/google/maxtext/blob/main/end_to_end/gemma/Run_Gemma.md#gemma should be removed.

Wow I was just debugging this, thank you for being a step ahead.


Issue in set State in a sample React app

Is this a bug report?
(Yes)

Can you also reproduce the problem with npm 4.x?

(I am using npm v 3.10.10.)
Which terms did you search for in User Guide?

(Execution Faild.)
Environment

node -v:  v6.12.2
npm -v:    3.10.10
yarn --version (if you use Yarn):
npm ls react-scripts (if you haven’t ejected):

Then, specify:

Operating system:   windows 8 V 6.3 Build 9600
Browser and version (if relevant): Chrome Version 63.0.3239.84 (Official Build) (64-bit)

Steps to Reproduce

(Write your steps here:)

I created ReactJs app using     create-react-app myapp1
I changed the code of the app.js file as followed

/*jshint esversion: 6 */
import React, { Component } from 'react';
import logo from './logo.svg';
import './App.css';
import axios from 'axios';

//-------------Card Component ---------------------------------------
const Card = (props)=>
{
  return (

        {props.Name}

      {props.CompanyName}

  )
}
//-------------Card List Component ---------------------------------------
const CardList =(props)=>{
  return(

Transform every element in CardsData array to Card component with typical properties of CardsData.OCard.

      {props.CardsData.map(oCard=> <Card {...oCard}/>)}

  )
}

//-------------Form Component ---------------------------------------
class Form extends Component{

  state = {txtChngedEvent : ""}
  //every react event function receives an event argument which is wrapped
  //to the native javascript event object.
  handleSubmit = (event)=>
  {
       event.preventDefault();
     axios.get(`https://api.github.com/users/${this.state.txtChngedEvent.value}`).then(
      (resp)=>
    {
      this.setState(prevState=>({}),()=>{
        console.log(this.prevState);
      })
      this.props.DoSubmit(resp.data);
    }
  );
  }
handleChange = ()=>
{
  if(this.state.txtChngedEvent.value.indexOf("dd") > -1)
  {
    this.state.txtChngedEvent.value = "";
  }
  console.log('Event : Form changed Text s', this.state.txtChngedEvent.value)
}
  render()
  {
    return(
      <form onSubmit={this.handleSubmit}>
        <input type="text"
        value={this.state.userName}
        onChange = {
              (event)=>
                this.setState({txtChngedEvent : event.target},()=>{
                    this.handleChange();
                })
            }
          placeholder="Github userName" required/>

        <button>Add Card </button>
      </form>
    )
  }
}
//-------------Container Component ---------------------------------------
class AppCard extends Component{
  state = {
    data:
      [
        {
          Image: "https://avatars0.githubusercontent.com/u/7?v:4",
          Name: "Evan Phoenix",
          CompanyName: "@hashicorp"
        },
        {
          Image: "https://avatars1.githubusercontent.com/u/17?v:4",
          Name: "Chris Van Pelt",
          CompanyName: "crowdflower.com"
        }
      ]
  }

  AddNewCard = (cardInfo)=>
  {
    console.log(cardInfo);
    this.setState(prevState=>({CardList : prevState.CardList.concat(cardInfo)}))
  };
  render(){
    return (

        <Form DoSubmit={this.AddNewCard}/>
        <CardList CardsData={this.state.data}/>

    )
  }
}

const AppsFactory = {
  AppCard : AppCard
}
export default AppsFactory;

I installed axios using npm install axios --save, Built with no errors,but when executed , I got that this is undefined and a run time error appeared as followed :

Expected Behavior

(I expect that the this.prevState had defined and had a value and I could modify it in the context of the this.setState funtion)
Actual Behavior

(Issue appeared, and couldn't move forward as followed :

)
Reproducible Demo

(Paste the link to an example project and exact instructions to reproduce the issue.)

This guy is kidding, right?
Let me help you a little bit although I'm a little bit mad about you creating a such issue in this repository.
Your issue is not related to the create-react-app. You did a few mistakes in your own code. You should grow up and try to find error on your own.
Please, take a look at key is used in App component to store the cards and look at key you're using in AddNewCard method.
Also, you're managing React component state in a wrong way.
Consider reading and learning React documentation. It will help you in the future.

@miraage ,  appreciated your response, sorry for begin wrong in selecting proper location for the post.
I am a beginner, and try to gain experience, this sample is not mine, it was from a tutorial posted on plural sight  which was totally wrong, and i changed it on my own.
Thanks for the advise.

@miraage
We don’t tolerate rudeness in this repository. Please avoid personal attacks and mockery in the future. If the question is off topic for a repository, there are perfectly polite ways to point that out without insulting the asker or questioning this intelligence.
@engmyahya
I’m sorry you got a rude response. It looks like you figured out the problem. Please don’t hesitate to ask questions in the future. We can’t promise to answer all of them, and issues that don’t directly relate to this repository will eventually get closed, but there’s nothing wrong with asking, and we try to help when we can!

@engmyahya @gaearon sorry if my response offended you.

We all make mistakes, let’s just make sure we stay friendly to beginners in the future. 🙂

@gaearon thanks for your time and interference, @miraage I did not deem the incident to be issue, but it is friendly to know that you care and took time out to say sorry, highly accepted 🙂


Add support for list of tags, deprecate string of tags

Fixes #31

Codecov Report

Merging #37 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #37   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          11     11
  Lines         377    379    +2
=====================================
+ Hits          377    379    +2

Impacted Files
Coverage Δ

tests/utils/fixtures.py
100% <100%> (ø)
:arrow_up:

src/ddtrace_asgi/middleware.py
100% <100%> (ø)
:arrow_up:

tests/test_trace_middleware.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 719444d...0c1335f. Read the comment docs.


support set default handler

We want to be able to manually set the default handler to let the guzzle-based project use the handler by default.
For example, we want to let the guzzle support the swoole coroutine by setting the default handler.

Hello, I have modified the code.

Thanks for contributing to the project, but honestly I'm not really in favor of this change. I don't really see the need for it, rather see it as an unnecessary complication added to the already complicated enough configuration.
If you need a specific handler, why don't you instantiate Guzzle that way? Explicit configuration is almost always better. Or you could simply create a custom factory with your defaults and use it everywhere where you need to create an HTTP client.

@sagikazarmark Because we want to adapt to other handlers without modifying some sdk code.

Ah okey. You mean that third party libraries are creating a guzzle client and you have no way to modify their behavior. That is a good use case and I understand your situation.
The problem is that those third party libraries depend on a concrete implementation of an HTTP client (guzzle) AND they do not allow you to access that client.
I do not think this PR brings us closer to what is considered good architecture. I think you should be making PRs to your dependencies that put you in this situation in the first place.

My PR does not affect the original running logic when the default handler is not set.
I think this is very useful, that the guzzle handler is not limited to built-in support.
When using a custom handler, you can change the original code as little as possible.

My PR does not affect the original running logic when the default handler is not set.

I know

I think this is very useful, that the guzzle handler is not limited to built-in support.

It’s not limited, you just have to configure it the “good” way.

When using a custom handler, you can change the original code as little as possible.

You are talking about “the original code” as in “other third party libraries” (not guzzle). See my last comment about the other libraries and the use of guzzle.

@Yurunsoft is this SDK open source? Actually, the proper way of solving the problem would be modifying that SDK to optionally accept a guzzle instance, not modifying guzzle.

If you allow the global default handler to be set, there is absolutely no need to make any changes when using a third-party sdk, because guzzle follows the psr-7 specification.
And allows to set the global default handler, and will not affect the default handler acquisition logic when the handler is not set.
I think guzzle supports handlers, is that let developers develop their own handlers to handle requests.
Now more and more developers are using swoole, if you can pass this PR, swoole users will benefit endlessly.
Allows previous code to seamlessly support swoole coroutine by setting the global default handler.
I hope that you can carefully consider.
Thank you very much!

It has been super carefully considered. I’ve been working 3 years with this kinda of questions and Mark got even more knowledge and experience then I do.
The reason agaist this PR, as well as the solution to your problem is discussed above.
Thank you for your PR and for the discussion. Please open a issue on Swoole, explain your problem and refer to this issue.

@Nyholm @sagikazarmark
Swoole extension has an ability, that could make most of I/O operations becomes to an coroutine async non-blocking I/O operations automatically, but not inclue curl extension, there are a lots of framework has been adapte the swoole coroutine, like zend-expressive, swoft, imi, etc., and blocking I/O is a nightmare for a coroutine application, this is the premise.
Why the users need this PR ?
When the users wants to use some thirdparty sdks, and the sdk require guzzle, that means the sdk is a Blocking I/O driver, it will cause a drastic decline QPS (in coroutine application), the best pratice is allow users to set a global default handler, then the all thirdparty sdks would use this handler if the sdk has not set the handler, and now, all thirdparty sdks would becomes a coroutine async Non-Blocking driver, this PR make this become possible.

I understand your scenario, I understand the code in the PR, I understand the implications of it. I also understand that your are frustrated (or starting to be frustrated) with me not accepting this PR.
Do you understand my comments and responses?

Great.
If you have an issue with Swoole:

Please open a issue on Swoole, explain your problem and refer to this issue.

—————-

I have no ability and time to submit a lots of PRs to the thirdparty libraries,

I don’t understand this? But you will naturally assume that I got that time to review, comment and fix the issue for you? You also assume that I got the time to maintain this code for ever? And you assume that I should answer support calls on this code when people have weird side-effects because of this PR? If so, that is VERY selfish of you. I hope I misunderstood you.

the best way is Guzzle adapte this.

I understand that you see it that way. But it is not the best decision for Guzzle or the community as explained above.

the best way is Guzzle adapte this.

I'm sorry, but this is definitely not true. This is the easy way, not the proper solution of the problem. Messing with global options is one of the most common source of confusion.
Properly written SDKs should allow injecting a customized instance, so the problem here is badly written SDKs, not Guzzle. Making Guzzle solve this problem is simply not the solution.
I'm really sorry, but we are not going to accept this PR.

The project that I working on is part of swoole, so the issue with Swoole is not necessary, we communicate everyday, and that is why this PR exists.
And I want a solution, not a controversy, I am so sorry to let you misunderstand the comments, If you reject this PR, then maybe you should provide another solution, as an owner of Guzzle.
Maybe just provide a way to let GuzzleHttp\Handler\StreamHandler become the default handler, it will be great, Swoole can make SteamHandler become a coroutine async Non-Blocking driver.

Well, an obvious solution would be to disable curl on your systems, that will make Guzzle choose the stream handler.
Again, I don't think Guzzle should be held responsible or forced to fix problems that is caused by poorly written software, so the solution shouldn't come from Guzzle either. But that's only one of the reasons why this PR is rejected, the other is the global scope messing.


Enable parameters 'resultAsArray' working in materialized-view-selection with a group by query

Enable parameter 'resultAsArray' working in materialized-view-selection with a group by query.
Reference to the PR: GroupBy array-based result rows. (#8196)
PR (#8196) realize a new resultRow return in group by query and give a parameter choice for user to back to the old appropriate(array- or map-based rows). However, the parameter is not working in materialized-view-selection when user use query type 'view'.
In fact, the PR (#8196) totally ignored the situation of materialized-view. So, fix it.
The realization has been tested for 2 weeks in our cluster!

This PR has:

[x] been self-reviewed.
[ ] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)
[ ] added documentation for new or modified features or behaviors.
[ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[ ] added or updated version, license, or notice information in licenses.yaml
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[x] added unit tests or modified existing tests to cover new code paths.
[x] added integration tests.
[x] been tested in a test Druid cluster.

Key changed/added classes in this PR

MaterializedViewQueryQueryToolChest
MaterializedViewQueryQueryToolChestTest

@jihoonson  Hi, please check.

@jihoonson Hi, please check.

@vogievetsky  Execute me, nobody try to review?

@jihoonson Hi, please check.

@vogievetsky @zhangxinyu1    Execute me, nobody try to review?


Where the **** are the stars?

On a high resolution image should be at least a single star visible? These look fake:
https://github.com/jakiestfu/himawari.js#example-images

Maybe,
Olbers' Paradox

Were the succession of stars endless, then the background of the sky would present us a uniform luminosity, like that displayed by the Galaxy–since there could be absolutely no point, in all that background, at which would not exist a star. The only mode, therefore, in which, under such a state of affairs, we could comprehend the voids which our telescopes find in innumerable directions, would be by supposing that the distance o the invisible background [is] so immense that no ray from it has yet been able to reach us at all - E.A.P

Or maybe

Himawari 8 is a weather satellite. It is naive to think the highly tuned cameras on this satellite work like any regular camera.


PULL REQUEST(Functions) -- Add a readonly functions (add and remove)

Hi,
Is it possible to add a readonly function, something to add and remove the readonly status ?

Per the contrib doc, please make your PRs to the development branch. PRs to the master will be closed.


Didnt find op for builtin opcode 'RESIZE_NEAREST_NEIGHBOR' version '3' when trying to run on Android

1. System information

OS Platform and Distribution (Windows 10):
TensorFlow installation (pip package):
TensorFlow library (2.3.1, pip package):

2. Code
Convert the model
converter = tf.lite.TFLiteConverter.from_saved_model(saved_model_dir) # path to the SavedModel directory
converter.target_spec.supported_ops = [
tf.lite.OpsSet.TFLITE_BUILTINS, # enable TensorFlow Lite ops.
tf.lite.OpsSet.SELECT_TF_OPS # enable TensorFlow ops.
]
tflite_model = converter.convert()
Save the model.
with open('model.tflite', 'wb') as f:
f.write(tflite_model)
3. Failure after conversion
Load the TFLite model and allocate tensors.
interpreter = tf.lite.Interpreter(model_path="model.tflite")
interpreter.allocate_tensors()
Get input and output tensors.
input_details = interpreter.get_input_details()
output_details = interpreter.get_output_details()
Test the model on random input data.
input_shape = input_details[0]['shape']
input_data = np.array(np.random.random_sample(input_shape), dtype=np.float32)
interpreter.set_tensor(input_details[0]['index'], input_data)
interpreter.invoke()  #### Returns error here
RuntimeError: Regular TensorFlow ops are not supported by this interpreter. Make sure you apply/link the Flex delegate before inference.Node number 151 (FlexSize) failed to prepare.

Since you are using the Select TF option, please refer to the following documents to enable Flex delegate for FlexSize op:
https://www.tensorflow.org/lite/guide/ops_select
You need to link the additional aar for the Select TF option. There is two options, one for prebuilt aar and one for custom built aar to reduce the unused parts.

Since you are using the Select TF option, please refer to the following documents to enable Flex delegate for FlexSize op:
https://www.tensorflow.org/lite/guide/ops_select
You need to link the additional aar for the Select TF option. There are two ways, one using the prebuilt aar and one using a custom built aar to reduce the unused parts for a small footprint.

Hi, thanks very much for your reply. I will try it.
For the solutions you mentioned, does it also apply for the issue of 'RESIZE_NEAREST_NEIGHBOR' version '3' when deploying on Android?

For the RESIZE_NEAREST_NEIGHBOR issue, could you file a separate issue with the reproducible steps?

For the RESIZE_NEAREST_NEIGHBOR issue, could you file a separate issue with the reproducible steps?

Thank you for your reply. It is actually the same issue. After I converted the model to .tflite, when I try to deploy the model on Android. I encounter the issue of RESIZE_NEAREST_NEIGHBOR. Any ideas? :)

Can you share the model creation script or the TFLite model?

Can you share the model creation script or the TFLite model?

I may not be able to share the model creation script or the model. It is a custom-trained model based on YOLO V3. After training, I get the checkpoint (3 files: checkpoint, .index & .data). Then a script (convert_to_pb.py from https://github.com/pythonlessons/TensorFlow-2.x-YOLOv3/tree/master/tools) is used to convert it to .pb, and then another script (shown in original post as 2. Code) to convert it to .tflite. Is this information enough?

I am not sure that it can be reproducible on my side. If possible, could you provide a minimal reproducible step for reducing the graph structure and carrying dumb weights?
I saw that you are using TF 2.3.1. I would highly recommend using TF 2.4.1 and tf-nightly both for the TFLite conversion since there are a lot of improvements in the conversion.

Thank you for the suggestions. But the code currently is not compatible with TF 2.4.1 yet. I'll try to share the model in some way.

Will close this issue for now, as I couldn't share the code or model. Thanks for all the inputs.


Cannot import module being compiled

hello i'm using swift 2.0 in Xcode 7.0 and use cocoapod to make a xcodeworkspace. and when i build it failed and show this error

the pod file is
use_frameworks!
link_with 'tester'
pod 'ProtocolBuffers-Swift'

Currently, versions in cocoapods have not supporting Xcode7. You need use branches marked as Swift2.0.


Grab Current Poster isn't working for me

When I run grab current poster it seems to be grabbing the background image instead of the actual poster. Sorry if this is not the right place to put this I am new to github.

Ahh understood my apologies if I'd missed that statement on the main page. Most of my reason for wanting to have it is that my in-laws internet is hot garbage so it'd be nice to have the files offline and use meta manager to just set the posters. Their plex server is basically just a clone of mine that I transfer stuff to using an external hard drive.

If you run grab-all-posters with the depth set to 1 it may grab the current poster; I can't recall how plex orders them.

grab-all-posters has been updated with a flag to grab the current artwork.


Update in-place-system-upgrade.md

Removing the Windows Server content from this article as well as the special alias.  We have a new Windows Server article for in-place upgrade.  Can we add a section for customers that points to it instead: https://learn.microsoft.com/en-us/azure/virtual-machines/windows-in-place-upgrade
We have moved the unsupported Windows Server versions into this article and are killing off the alias.  I tried to submit this internally but it wouldnt let me so ping me with any questions (joscon)

Learn Build status updates of commit d0389a2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

support/azure/virtual-machines/in-place-system-upgrade.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@joscon I want to confirm if Windows Server 2012 R2, Windows Server 2012 and Windows Server 2008 R2 need to be removed. I find these Windows Server versions remain in another PR https://github.com/MicrosoftDocs/SupportArticles-docs/pull/833 that you submitted earlier. This is the latest version of in-place-system-upgrade.md: https://learn.microsoft.com/en-US/troubleshoot/azure/virtual-machines/in-place-system-upgrade

Thanks Amanda, this is being taken care of via another thread so you can ignore this PR for now.  I didn't realize 833 was open and created PR 870 so I caused a bunch of confusion.
From: Amanda Zhu @.>
Sent: Tuesday, January 17, 2023 9:39 PM
To: MicrosoftDocs/SupportArticles-docs @.>
Cc: Joseph Conway @.>; Mention @.>
Subject: Re: [MicrosoftDocs/SupportArticles-docs] Update in-place-system-upgrade.md (PR #870)
@josconhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjoscon&data=05|01|Joseph.Conway%40microsoft.com|a1bfc180ceb44103771c08daf9165810|72f988bf86f141af91ab2d7cd011db47|1|0|638096171629156006|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=wEqXhI0gl8mCIshnOEYBHQSddVOVsH2HJQEiWSBvV0U%3D&reserved=0 I want to confirm if Windows Server 2012 R2, Windows Server 2012 and Windows Server 2008 R2 need to be removed. I find these Windows Server versions remain in another PR #833https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FSupportArticles-docs%2Fpull%2F833&data=05|01|Joseph.Conway%40microsoft.com|a1bfc180ceb44103771c08daf9165810|72f988bf86f141af91ab2d7cd011db47|1|0|638096171629156006|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=JnVO%2FP6VcV2mxpPJFqpPPnJwsa721ZIwc0Szb4n0qms%3D&reserved=0 that you submitted earlier. This is the latest version of in-place-system-upgrade.md: https://learn.microsoft.com/en-US/troubleshoot/azure/virtual-machines/in-place-system-upgradehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flearn.microsoft.com%2Fen-US%2Ftroubleshoot%2Fazure%2Fvirtual-machines%2Fin-place-system-upgrade&data=05|01|Joseph.Conway%40microsoft.com|a1bfc180ceb44103771c08daf9165810|72f988bf86f141af91ab2d7cd011db47|1|0|638096171629156006|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=9LMqcUtn%2BpR3Wr7kWEvVQRSddwdIiHI8xcUJvp7zNmY%3D&reserved=0
[image]https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F46809752%2F213092378-85728c0c-082b-4593-9b40-cd2898dae82d.png&data=05|01|Joseph.Conway%40microsoft.com|a1bfc180ceb44103771c08daf9165810|72f988bf86f141af91ab2d7cd011db47|1|0|638096171629156006|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=02EkFrrGC%2FLMm3crUM4vghbnqau7owe%2BScyqkCHHOPw%3D&reserved=0

Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FSupportArticles-docs%2Fpull%2F870%23issuecomment-1386517585&data=05|01|Joseph.Conway%40microsoft.com|a1bfc180ceb44103771c08daf9165810|72f988bf86f141af91ab2d7cd011db47|1|0|638096171629156006|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=zMieQKMNXEWQ1%2Bts4Es84wTsHwKCieVQNcNDvvPSHwo%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAIAUS2JGWI4MW4QW77QAOPDWS56YNANCNFSM6AAAAAAT6OADBA&data=05|01|Joseph.Conway%40microsoft.com|a1bfc180ceb44103771c08daf9165810|72f988bf86f141af91ab2d7cd011db47|1|0|638096171629156006|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=cuYrwCw7o3bNFI8Y2o0pJY3urp3vefQf97UmSFL6Mr0%3D&reserved=0.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

@joscon Thanks for your explanation. I will close this PR.


Fixes JSON measures

Proposed changes
I think there is a copy & paste artifact of the UltraLight agent in the IOT JSON agent.
Types of changes
What types of changes does your code introduce to the project: Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Update docker image version of FIWARE GE.
[x] Update only documentation, not any source code.

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

[x] I have read the CONTRIBUTING doc
[ ] I have signed the CLA
[ ] I have updated the change log (CHANGELOG.md)
[x] I send this pull request to the v0.20.0-next branch.
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Further comments
This is a very simple documentation change. Not sure if this requires to fill the CLA.

Codecov Report
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (c5342ab) compared to base (1609b4b).
Patch has no changes to coverable lines.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@              Coverage Diff               @@
##           v0.20.0-next      #233   +/-   ##
==============================================
  Coverage        100.00%   100.00%
==============================================
  Files                 2         2
  Lines              1745      1774   +29
==============================================
+ Hits               1745      1774   +29

Impacted Files
Coverage Δ

lets-fiware.sh
100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Thank you for your contribution! Merged.
The next time you send a PR, please update the CHANGELOG.md file as well.


deep strict equal

util.isDeepStrictEqual and assert.deepStrictEqual are very slow in node.
fast-deep-equal has 35 million downloads a week. Using their benchmarks, node's util.isDeepStrictEqual is 5.6x slower.
edit: I totally forgot about this until I saw this tweet

Can we have a better benchmark result, if we move the implementation to C++?

The comparison seems rather flawed in this case. util.isDeepStrictEqual() is actually really fast and highly optimized.
The mentioned library uses significantly less correct/strict comparisons (e.g., not checking for objects as keys in maps and sets and just returning false even though the objects are identical shape wise or having extra properties on arrays like const a = [1,2,3]; a.extra = true) and that makes it "faster". I would just not rely upon the comparison result. I might be wrong but I believe there is little that can be done to further optimize the algorithm at this point.
Example flaw:
const equal = require('fast-deep-equal');
a = new Map([[123, 123], ['test', 123]])
b = new Map([[true, true], [999, true], [123, false]])
equal(a, b)
// true !!!

They also provide an subpackage fast-deep-equal/es6 that works with map and other types
const equal = require('fast-deep-equal/es6');
a = new Map([[123, 123], ['test', 123]])
b = new Map([[true, true], [999, true], [123, false]])
equal(a, b)
// false !!!

Can we have a better benchmark result, if we move the implementation to C++?

I believe any operation that involves frequent access to a JS object (which is true in this case) would render any performance benefit from using C++ meaningless, as even Object::Get has a significant overhead.

@imranbarbhuiya it also causes issues:
const equal = require('fast-deep-equal/es6');
const a = new Map([[{}, true], [{}, false], [{}, false]])
const b = new Map([[{}, true], [{}, false], [{}, false]])
equal(a, b)
// false ?? should be true

@imranbarbhuiya it also causes issues:
const equal = require('fast-deep-equal/es6');
const a = new Map([[{}, true], [{}, false], [{}, false]])
const b = new Map([[{}, true], [{}, false], [{}, false]])
equal(a, b)
// false ?? should be true

ic yeah, that's incorrect, it's only checking for deep equality in values and not keys.

I don't think there's anything to do here that would be an acceptable solution.


auto-detect correct deploy command

If your local branch is main, you have to set the :biff.tasks/deploy-cmd config option to ["git" "push" "prod" "main:master"]. It would be better if Biff detected whether your local branch's name is main or master and used the right command by default.

Closed by v0.7.11.


Update project dependencies

Summary
In order to fix some security issues pointed by dependabot, we're removing, upgrading and moving a series of project dependencies. We manage to fix security issues and reduce significantly the project build size! 🎉
Updates

Dependency
from

to

uirouter/angularjs
1.0.29
❯
1.0.30

angular-ui-router
1.0.29
❯
1.0.30

jest
27.3.1
❯
27.4.3

prettier
2.4.1
❯
2.5.1

sass
1.43.4
❯
1.44.0

@4tw/cypress-drag-drop
2.0.0
❯
2.1.0

babel-loader
8.2.2
❯
8.2.3

css-loader
5.0.2
❯
6.5.1

html-loader
1.3.2
❯
3.0.1

mini-css-extract-plugin
1.3.8
❯
2.4.5

postcss-loader
4.2.0
❯
6.2.1

sass-loader
10.1.1
❯
12.4.0

style-loader
2.0.0
❯
3.3.1

webpack
4.46.0
❯
5.65.0

webpack-cli
3.3.12
❯
4.9.1

webpack-dev-server
3.11.2
❯
4.6.0

@webpack-cli/serve
1.2.2
❯
1.6.0

html-webpack-plugin
4
❯
5.5.0

copy-webpack-plugin
6.4.0
❯
10.0

supertester
4.0.2
❯
6.1.6

mailgun.js
3.4.0
❯
4.1.0

mongoose
5.9.18
❯
6.1.0

mongodb
3.5.8
❯
4.2.1

Move

Move webpack to devDependencies
Move autoprefixer to devDependencies
Move cssnano to devDependencies

Add & Remove

Remove del
Remove webpack-bundle-analyzer
Add terser-webpack-plugin

Tests

yarn test now run unit tests with jest
yarn test:watch to run jest in watch mode
yarn test:cy to run Cypress tests
yarn cy:open to start Cypress interactive mode

Other changes

Add yarn-error.log to .gitignore
Fix login page BrModelo logo alt=" "
Remove outdated .eps logo from img/
Remove production sourcemap and images bundle
Remove unused import of copy-webpack-plugin
Remove unused dependency ejs

@wlsf82  we did some changes on how to run tests. Please take a look at the Tests section of this pull request.

@idmarjr homolog on heroku ok!
https://brmodelo-stage.herokuapp.com/#!/main


Prometheus Crash on Querying a Specific Metric

Hello There,
We are  using below version of Prometheus.
prometheus, version 2.2.1 (branch: HEAD, revision: bc6058c81272a8d938c05e75607371284236aadc)   build user:       root@149e5b3f0829   build date:       20180314-14:15:45   go version:       go1.10
We have recently added a new metric for netstat connections and gathering it using textfile_collector on wmi_exporter. We are able to see the metrics on wmi_exporter but while querying them on Prometheus dashboard Prometheus service is crashing with below error.
Sep 28 17:30:06  prometheus[7297]: level=warn ts=2018-09-28T21:30:06.653633148Z caller=head.go:320 component=tsdb msg="unknown series references in WAL samples" count=6
So I tried deleting that time-series using the API but getting no response followed by another crash of Prometheus.
curl -vv --silent -H "Content-Type: application/json" -X POST -d '{"matchers":[{"type":"EQ","name":"__name__","value":"netstat_connections"}]}' 'http://localhost:9090/api/v2/admin/tsdb/delete_series'
* About to connect() to localhost port 9090 (#0)
*   Trying ::1...
* Connected to localhost (::1) port 9090 (#0)
> POST /api/v2/admin/tsdb/delete_series HTTP/1.1
> User-Agent: curl/7.29.0
> Host: localhost:9090
> Accept: */*
> Content-Type: application/json
> Content-Length: 76
>
* upload completely sent off: 76 out of 76 bytes
* Empty reply from server
*Connection #0 to host localhost left intact`

Can someone help me fixing this issue?
Thank you,
Murali

Hi, could you try the latest version 2.4.2. There were some issues with the delete API that were already fixed.

Thank you! We will try the upgrade.

In our bugscrub we decided to close this as fixed :) Please feel free to reopen if its not the case.


Can't override velocity_func when compiling cocos2d-x JavaScript to IOS device.

I am attempting to overwrite the Chipmunk's Body.prototype.velocity_func. It works perfectly when viewing my game via HTML5 Canvas, but when I compile my Xcode project, the velocity_func is never called, and it seems to reverts to the default velocity_func logic.
I am guessing its a JSB issue.  If I am understanding this correctly, and it is an actual issue, I can try to help solve it, just need a little bit of info as to how to adjust / add this binding.

In fact, to overwrite a C++ class function with a JavaScript implementation is not natural in JSB.
As the velocity_func is invoked by C++ object, it doesn't know there is a JS child class implementation, because the inheritance in invisible from the scope of the C++ object.
So it won't invoke the child class' velocity_func. But it shouldn't revert the default logic neither, I'm not sure what's happening here.
However, if you are calling the function in JS code, then it will be taken account.
You just need to invoke this._super() in the function body to invoke the C++ original function.
This is a general problem of JSB, we have our own solution for cc.Node.prototype.update, onEnter, onExit etc, you can refer to their implementation. But I'm afraid it's too complicated and not very suitable for Chipmunk.

Thanks for the info!
A quick example:
// This runs in the HTML5 version of the app
// But does not run in the compile IOS version
  sprite.body.velocity_func = function() {
      console.log('updateVelocity');
  };

The ultimate goal here for me is to change the gravity of a body, without adding a new Space or changing the existing Space's gravity and allowing all the bodies in the space to still register collisions.
Maybe I need to think about this solution differently?

Maybe you should simply give the targeted sprite a supplemental force ?

Yes! Thank you.


Refactored storage service

Description
This PR includes the following proposed change(s):

Refactored the storage service

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Refactoring / Documentation

if your change is a breaking change, please add breaking change label to this PR
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[x] New and existing unit tests pass locally with my changes

[ERROR] /home/runner/work/jag-file-submission/jag-file-submission/src/backend/jag-efiling-api/src/test/java/ca/bc/gov/open/jagefilingapi/document/DocumentApiImplTest.java:[121,50] cannot find symbol


Matches with changes in Maliput: Lane::ToLanePosition.

Related to https://github.com/maliput/maliput/issues/496
Summary
Matches with https://github.com/maliput/maliput/pull/521
action-ros-ci-repos-override: https://gist.githubusercontent.com/francocipollone/b218a7671b9bb6b6be2c22ac19f85793/raw/8c1e3852f99a5ea730b12be37ac6c6205cf67a2a/maliput_malidrive.repos

@ros-pull-request-builder retest this please

@ros-pull-request-builder retest this please


Not all the packages are getting imported in Blackduck scanner

scann_outpu.txt
What happened:
I am trying to generate SBOM for my RHEL 7 custom image which is built using image builder. And I am executing the below command
#syft /root/isomount/input/liveimg.tar.gz  --select-catalogers "+sbom-cataloger" -o spdx-json=sbom.050524.json
Please correct me if the command and its parameters provided are wrong.
What you expected to happen:
While importing the SBOM generated using the above command out of 650 components only 58 are imported.
Error:
<EMAIL_ADDRESS>|   | Component Not FoundUnable to map scanned component version to Black Duck project version because no mapping is present for the given external identifier
Steps to reproduce the issue:
1)Generated an RHEL 8 image using the imaged builder.
2)Download the image from the image builder and generate the SBOM.
#syft /root/isomount/input/liveimg.tar.gz  --select-catalogers "+sbom-cataloger" -o spdx-json=sbom.050524.json
3)Import the SBOM in the Blackduck scanner.
Anything else we need to know?:
I have attached the scan logs,
Environment: x86_64

Output of syft version: syft 1.1.1
OS (e.g: cat /etc/os-release or similar): RHEL 8.8

Hi @Naranthiran, thanks for the report. Can you attach a copy of sbom.050524.json to this issue? It looks like there are a bunch of errors related to symlinks in the scan output. It would be helpful if we could also see the contents of the tar file. Could we have access to the tar file itself? If not, a complete file listing from the tar archive would be a good start. Thanks!

Hi Tim,
I have attached the SBOM.
sbom.050524.json
Regards
Naranthiran Duraisamy

Hi @Naranthiran, I checked out the SBOM and I see over 600 entries, about what I would expect. Running Grype against it reports a bunch of possible vulnerabilities. Can you explain in more detail the problem on the Syft side here? I am not familiar with Blackduck's scanning software and you might need to contact them for information about their tool. Thanks!

Hi Naranthiran, as far as I can tell, your method of calling Syft is fine, and I don't see anything out of the ordinary in the generated SBOM. It does look like Blackduck is expecting something different. It might be some sort of incompatibility between the tools but we would be happy to look. Would you be able to contact Blackduck and open a support ticket there? We would be happy to explore the problem. Thanks,
Tim

Hi Tim,
Since BlackDuck team does not have a separate to analyze the SBOM I was not able to give you an update.
But I have one more query regarding the SBOM generated using the syft tool.
I am using the below command to generate the SBOM. I have also attached the SBOM for your reference.
#syft dir:/home/RHEL7WORK/ -o spdx-json=071724minimalos.spdx.json
We have not able to get the supplier information in the SBOM generated. We are using SBOM editor for reviewing the SBOM.
Can you check SBOM and confirm what could be the issue with supplier information or it's available in SBOM and not visible only in the SBOM editor. And are there any tools to check the supplier information?
071724minimalos.spdx.json
Regards
Naranthiran Duraisamy


adding UnitProperty in metadta schema in sortineextractor interface

Motivation
The PR merge #230 did not take care of the ability to pass 'UnitProperty' metadata to any sortingextractorinterface. It was expecting any custom properties to exist in self.metadata["units"]=dict(prop1='desc', prop2='desc2'). The old way of doing this was self.metadata["Ecephys"]["UnitProperties"]= dict(prop1='desc', prop2='desc2').
This PR adds this back.
How to test the behavior?
The below, should run with a specific sortingextractorinterface
from jsonschema import validate

metadata = sortingextractorinterface.get_metadata()
metadata["Ecephys"] = dict(UnitProperties=[dict(name='prop_name1', description='description1'),
                                           dict(name='prop_name1', description='description1')])
validate(instance= metadata, schema=sortingextractorinterface.get_metadata_schema()) # this should run fine
sortingextractorinterface.run_conversion(nwbfile, metadata=metadata)

Checklist

[ ] Have you checked our Contributing document?
[ ] Have you ensured the PR description clearly describes the problem and solutions?
[ ] Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
[ ] If this PR fixes an issue, is the first line of the PR description fix #XXX where XXX is the issue number?

@CodyCBakerPhD thanks for pointing this out, glad that this was picked up so early after the PR merge!
The reason why this was not captured in tests: the sortingextractorinterfaces that we are testing out in test_gin.py are BlackrockSortingExtractorInterface and PhySortingInterface here which do not explicitly set any custom UnitProperties.
Its only CellExplorerSortingInterface that does this here but this is not in tests (the file does not exist in GIN either, maybe we can upload that?). So the absence of a schema supporting this did throw any error in the metadata validation stage that happens here

@Saksham20 Thanks so much for the quick fix! This is also pertaining to some fixes that might be needed specific to CellExplorer, so I'll branch from here to test out those changes and by so doing, ensure this works as well.
You are 100% right about the GIN data - it's been on the to-do list for some time now to add Neuroscope and CellExplorer Sorting data, but of all the formats CellExplorer is really the one that heavily utilizes UnitProperties.
I think we could add some artificial tests for adding such properties to what we have now until we get some added to GIN, though, I'd be happy to add those in tomorrow.

@CodyCBakerPhD I have added tests for this feature. I have created a custom sortingextractordatainterface for this.


ARM Compatibility (rpi4)

Hi,
Im using archlinux (aarch64) on the Raspberry pi 4.
Well, it compiles and everything looks fine, but after the compilation and installation, i get:
-bash: /usr/bin/nwg-dock: cannot execute binary file: Exec format error
Isn't that weird, because i compiled it on the pi4 itself?

As far as I know, @dlasky managed to run it on Pinephone. I'll ask him for help.

Thank You!
Let's see what he did 😂

hey so i actually havent BUILT on the pinephone. But i'm curious as to what OS/architecture you are running on rpi4 because it supports both 32/64 and perhaps the toolchain is confused about which you are actually running

You could have right, im using actually the official raspberry kernel, compiled for aarch64.
With Archlinux 64bit as base.
It's a bit hard to explain, the Raspberry team makes some sort of a 32 bit kernel, that can execute 64bit apps.
The whole problem is, that the native aarch64 vanilla archlinux kernel for the pi, doesn't has vc4 support (graphics). That's the whole reason behind this.
But thanks for the hint!
I will try to switch the kernel tomorrow and check and reply.
Cheers

i was actually thinking you may need to specify the goarch param on build to get something that will run correctly rather than swap out the kernel. ive just run into weirdness with the 32/64 issues on pis before.
try building with: GOOS=linux GOARCH=armel go build -o bin/nwg-dock
or failing that maybe specify aarch64 for goarch.
hopefully that helps!

Well, I was waiting for @Ramalama2 's response... @dlasky - many thanks. I have no experience with ARM, but I supposed something like this. Hope it's gonna help.

Just noticed: in the installation steps I skipped make build before sudo make install. If you followed them, you might have tried to install the binary built for x86_64. Sorry!

oh ha, i didnt even notice that you had the binary comitted

Sorry guys, i know you waited, but i have a big work-related project, that consumes all my time and nerves 🤦
So i wasn't able to test again, even to boot the pi since then 🤦
But i will test this week and give an update.
Sry again 🙈

no worries, life outside of open source ;)

Take your time. I have a lot of quite boring python code to write tonight.


Why not requeue when ReconcileIstioOperator reconcile failed

Why not requeue when err is not nil or status is v1alpha1.InstallStatus_ERROR?
https://github.com/istio/istio/blob/bfd87df8b8f5d30a9e261bfabb5ccfcfa24d9f6c/operator/pkg/controller/istiocontrolplane/istiocontrolplane_controller.go#L398

When ingressgateway pod cannot connect to istiod after 5 minutes, ingressgateway IstioOperator will be set v1alpha1.InstallStatus_ERROR forerver, even though ingressgateway connect to istiod in the future.

You can set the wait timeout to be larger than 5mins

https://github.com/istio/istio/blob/0c51455500c2c001402212327c8622fe91a21a1f/operator/pkg/helmreconciler/reconciler.go#L108-L121


Aggregate.replay cannot work with required attributes

In the documentation, you're using Hashie::Dash to build an aggregate and require the id property.
Something that I want too!
But this cannot work with the Aggregate.replay method since it initialize a new instance without any attributes: https://github.com/gregory/jouba/blob/master/lib/jouba/aggregate.rb#L59
Thus Hashie::Dash raises an exception ...
Aggregate.find has the same problem since it uses the replay method.
I'm wondering how you would solve this problem.
One option could be: we build the object with the first event in the stream and then replay all events: somehting like SomeAgg.new(SomeAgg.stream(uuid).first).replay(SomeAgg.stream(uuid))
But I'm wondering if an issue can arise if some procesing is done somewhere in created instance/class method or on_created...
Otherwise, if a cache is present, we can easily build the object from the last cache which has the required attributes.
My suggestion is to create a class method called rebuild(uuid) and start from there.

Thanks for input!
Could you post a Dummy use case to reproduce?
Something like:
class A
 include Jouba::Aggregate
end
class B; end

 A.foo # => Error

require 'jouba/aggregate'
class Customer < Hashie::Dash
  include Jouba::Aggregate.new(prefix: :on)

  property :uuid, required: true
  property :name

  def self.create(attributes)
    attributes[:uuid] = SecureRandom.uuid
    Customer.new(attributes).tap do |customer|
      customer.create(attributes)
    end
  end

  def create(attributes)
    emit(:created, attributes)
  end

private

  def on_created(attributes)
    update_attributes!(attributes)
  end
end

And you'll never be able to call Customer.find(uuid) nor Customer.replay(Customer.stream(uuid)) since it will call Customer.new and Dashie::Dash will raise an exception for not having uuid attribute set.

thx! i ll look into that in +9h, but the quick fix sounds like we could add hashie extension to ignore undefined attr.
thx for your input
Have a nice day! :)

Grégory Horion
Ruby Developer

web: http://gregory.io
skype: greg2502
linkedin: https://www.linkedin.com/in/gregoryhorion?locale=en_US
twitter: http://twitter.com/metakungfu
github: (for humans http://osrc.dfm.io/gregory) - http://github.com/gregory
stackoverflow: http://stackoverflow.com/users/1169468/metakungfu

On Fri, May 8, 2015 at 10:08 AM, diegodurs<EMAIL_ADDRESS>wrote:

require 'jouba/aggregate'
class Customer < Hashie::Dash
  include Jouba::Aggregate.new(prefix: :on)
  property :uuid, required: true
  property :name
  def self.create(attributes)
    attributes[:uuid] = SecureRandom.uuid
    Customer.new(attributes).tap do |customer|
      customer.create(attributes)
    end
  end
  def create(attributes)
    emit(:created, attributes)
  end
private
  def on_created(attributes)
    update_attributes!(attributes)
  end
end

And you'll never be able to call Customer.find(uuid) nor Customer.replay(Customer.stream(uuid)) since it will call Customer.new and Dashie::Dash will raise an exception for not having uuid attribute set.
Reply to this email directly or view it on GitHub:
https://github.com/gregory/jouba/issues/3#issuecomment-100300983

Had a second look and understood the issue now.
Specs passed cause i haven't require the field :)
Actually think that this is a bug in the Readme and that this kind of domain validation should happen outside the domain, ie in a form object or a command object.
Indeed, there is no way we could have data "integrity" enforcement when you base your data on events, like we could have in sql systems where you can add db constraints.
We could add some data coercion but input validation should be moved to Form objects or whatever you use to get the input of your data.
Something to keep in mind too though, is that your data input validation might change with the context.
ie: you might want to validate some stuffs at user creation and not validate those stuffs on user update: term of services and other fancy attributes.
This enforce the theory that it's a bug in the readme, not to say, that the specs are green :D
what do you think?

Here would be the fix:
class Customer::Create
  def self.call(form)
   Customer.create(form.attributes)if form.valid?
  end
end
class Customer::Create::Form < Reform::Form
  property :name
  validates :name, presence: true
end
require 'jouba/aggregate'
class Customer < Hashie::Dash
  include Jouba::Aggregate.new(prefix: :on)

  property :uuid
  property :name

  def self.create(attributes)
    attributes[:uuid] = SecureRandom.uuid
    Customer.new(attributes).tap do |customer|
      customer.create(attributes)
    end
  end

  def create(attributes)
    emit(:created, attributes)
  end

private

  def on_created(attributes)
    update_attributes!(attributes)
  end
end

Faire question would be: how can i enforce the fact that any user creation in my system will have those UUID?
Since this is event based, the only way to "create" a user is by emitting a create event from your Customer domain. So if you write a spec for that to make sure that that even has uuid, you should be safe.

Jouba allready requires the presence of an uuid :) https://github.com/gregory/jouba/blob/master/lib/jouba/aggregate.rb#L42
So I guess it's fair to not be able to requires attributes on initialization and decouple this by action as you shown.
I'm also wondering if it would make sense to validate some invariants after playing events.
Otherwise, someone could explicitely require mandatory entity/value-object/attribute in the initializer as this suggest: https://lostechies.com/jimmybogard/2010/02/24/strengthening-your-domain-aggregate-construction/


problem to running on ios

Hi, thanks for your amazing package dude. I try to run it on Ios but I couldn't and always I get many problems with the IOS version, could you please guide me because I try to add this amazing package a good UI Kit?

Please description details the problem you are having!

Thanks for your reply,  Unfortunately the new flutter version automatically update platform version from 9.0 to 11.0 .
When I changed all the 9.0 to 11.0 I get the below error:
`ode...
Running Xcode build...
Xcode build done.                                           11.6s
Failed to build iOS app
Error output from Xcode build:
↳
** BUILD FAILED **
Xcode's output:
↳
Writing result bundle at path:
/var/folders/xx/vpg2v8852m10wmfg9d0h_q5c0000gn/T/flutter_tools.
iwkxkg/flutter_ios_build_temp_dirkoJcM5/temporary_xcresult_bund
le
ld: building for iOS Simulator, but linking in dylib built for
iOS, file
'/Users/alireza/vsprojects/sipvoidp24/voip24h_sdk_mobile/example
/ios/Pods/linphone-sdk-novideo/linphone-sdk-novideo/apple-darwin
/Frameworks/bctoolbox.framework/bctoolbox' for architecture
arm64
clang: error: linker command failed with exit code 1 (use -v to
see invocation)
note: Building targets in dependency order
warning: Run script build phase 'Run Script' will be run during
every build because it does not specify any outputs. To address
this warning, either add output dependencies to the script
phase, or configure it to run in every build by unchecking
"Based on dependency analysis" in the script phase. (in target
'Runner' from project 'Runner')
warning: Run script build phase 'Thin Binary' will be run during
every build because it does not specify any outputs. To address
this warning, either add output dependencies to the script
phase, or configure it to run in every build by unchecking
"Based on dependency analysis" in the script phase. (in target
'Runner' from project 'Runner')

Result bundle written to path:
    /var/folders/xx/vpg2v8852m10wmfg9d0h_q5c0000gn/T/flutter_tools.
    iwkxkg/flutter_ios_build_temp_dirkoJcM5/temporary_xcresult_bund
    le

Error (Xcode): Building for iOS Simulator, but linking in dylib
built for iOS, file
'/Users/alireza/vsprojects/sipvoidp24/voip24h_sdk_mobile/example/ios
/Pods/linphone-sdk-novideo/linphone-sdk-novideo/apple-darwin/Framewo
rks/bctoolbox.framework/bctoolbox' for architecture arm64
Could not build the application for the simulator.
Error launching application on iPhone SE (3rd generation).`

and when I use the.  sdk not. your example excacttly I got the below error
Xcode build done.                                           36.9s
Failed to build iOS app
Error output from Xcode build:
↳
** BUILD FAILED **
Xcode's output:
↳
Writing result bundle at path:
/var/folders/xx/vpg2v8852m10wmfg9d0h_q5c0000gn/T/flutter_tools.
VRmCcw/flutter_ios_build_temp_dirzWptcs/temporary_xcresult_bund
le
ld: building for iOS Simulator, but linking in dylib built for
iOS, file
'/Users/alireza/vsprojects/sip/sip_project/ios/Pods/linphone-sdk
-novideo/linphone-sdk-novideo/apple-darwin/Frameworks/bctoolbox.
framework/bctoolbox' for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to
see invocation)
note: Building targets in dependency order
warning: Run script build phase 'Run Script' will be run during
every build because it does not specify any outputs. To address
this warning, either add output dependencies to the script
phase, or configure it to run in every build by unchecking
"Based on dependency analysis" in the script phase. (in target
'Runner' from project 'Runner')
warning: Run script build phase 'Thin Binary' will be run during
every build because it does not specify any outputs. To address
this warning, either add output dependencies to the script
phase, or configure it to run in every build by unchecking
"Based on dependency analysis" in the script phase. (in target
'Runner' from project 'Runner')
/Users/alireza/vsprojects/sip/sip_project/ios/Pods/Pods.xcodepro
j: warning: The iOS Simulator deployment target
'IPHONEOS_DEPLOYMENT_TARGET' is set to 9.0, but the range of
supported deployment target versions is 11.0 to 16.2.99. (in
target 'linphone-sdk-novideo' from project 'Pods')

Result bundle written to path:
    /var/folders/xx/vpg2v8852m10wmfg9d0h_q5c0000gn/T/flutter_tools.
    VRmCcw/flutter_ios_build_temp_dirzWptcs/temporary_xcresult_bund
    le

Error (Xcode): Building for iOS Simulator, but linking in dylib
built for iOS, file
'/Users/alireza/vsprojects/sip/sip_project/ios/Pods/linphone-sdk-nov
ideo/linphone-sdk-novideo/apple-darwin/Frameworks/bctoolbox.framewor
k/bctoolbox' for architecture arm64
Could not build the application for the simulator.
Error launching application on iPhone SE (3rd generation).

I have roughly understood the problem. Please try to build project with real device instead of iOS simulator.

But dear, How I can make build from my app to put it on app store? cause when I try to archive the project I have multiple problems too.

I try to build it but It gaves me an error so if you can please come to anydesk and help me to build it

I try to build it but It gaves me an error so if you can please come to anydesk and help me to build it

Please describe the error when you build the project

But dear, How I can make build from my app to put it on app store? cause when I try to archive the project I have multiple problems too.

Firstly, make sure your project has successfully integrated the flutter sdk. Next I need you to describe the error when archive your application

@Voip24h-Corp I try to create an archive in Xcode from the project but it gets an error, are you sure that you work with this application on iPhone too? Cause I cant build it at all.

@Voip24h-Corp I try to create an archive in Xcode from the project but it gets an error, are you sure that you work with this application on iPhone too? Cause I cant build it at all.

Yes, currently our partners are still successfully integrating

I try to build the app and it gaves me this errors (I try to build your example):
192 example % flutter build ipa
💪 Building with sound null safety 💪
Archiving com.voip24h.sdk...
Automatically signing iOS for device deployment using specified development team in Xcode project:
YACBQX3L7S
Running pod install...                                           2,588ms
Running Xcode build...
└─Compiling, linking and signing...                        218ms
Xcode archive done.                                         92.0s
Failed to build iOS app
Error output from Xcode build:
↳
ARCHIVE FAILED
Xcode's output:
↳
Writing result bundle at path:
/var/folders/xx/vpg2v8852m10wmfg9d0h_q5c0000gn/T/flutter_tools.9lcV7A/flutter_ios_build_temp_di
rvObfgH/temporary_xcresult_bundle
/Users/nima/Developer/flutter/.pub-cache/hosted/pub.dartlang.org/permission_handler_apple-9.0
.4/ios/Classes/strategies/PhonePermissionStrategy.m:50:18: warning: incompatible pointer types
initializing 'CTCarrier *' with an expression of type 'NSDictionary<NSString *,CTCarrier *> *
_Nullable' [-Wincompatible-pointer-types]
      CTCarrier *carrier = [netInfo serviceSubscriberCellularProviders];
                 ^         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/nima/Developer/flutter/.pub-cache/hosted/pub.dartlang.org/permission_handler_apple-9.0
.4/ios/Classes/strategies/PhonePermissionStrategy.m:50:37: warning:
'serviceSubscriberCellularProviders' is only available on iOS 12.0 or newer
[-Wunguarded-availability-new]
      CTCarrier *carrier = [netInfo serviceSubscriberCellularProviders];
                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In module 'CoreTelephony' imported from
/Users/nima/Developer/flutter/.pub-cache/hosted/pub.dartlang.org/permission_handler_apple-9.0
.4/ios/Classes/strategies/PhonePermissionStrategy.m:8:
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS16
.2.sdk/System/Library/Frameworks/CoreTelephony.framework/Headers/CTTelephonyNetworkInfo.h:105:78
: note: 'serviceSubscriberCellularProviders' has been marked as being introduced in iOS 12.0
here, but the deployment target is iOS 11.0.0
@property(readonly, retain, nullable) NSDictionary<NSString *, CTCarrier *>
*serviceSubscriberCellularProviders API_AVAILABLE(ios(12.0), watchos(5.0))
API_UNAVAILABLE(macos, tvos);
                                                                             ^
/Users/nima/Developer/flutter/.pub-cache/hosted/pub.dartlang.org/permission_handler_apple-9.0
.4/ios/Classes/strategies/PhonePermissionStrategy.m:50:37: note: enclose
'serviceSubscriberCellularProviders' in an @available check to silence this warning
      CTCarrier *carrier = [netInfo serviceSubscriberCellularProviders];
                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 warnings generated.
Project /Users/nima/vsprojects/sipvoidp24/voip24h_sdk_mobile/example built and packaged
successfully.error: unable to open dependencies file
(/Users/nima/Library/Developer/Xcode/DerivedData/Runner-fqydwlwntmngiyefwerakcimabvl/Build/In
termediates.noindex/ArchiveIntermediates/Runner/IntermediateBuildFilesPath/Runner.build/Release-
iphoneos/Runner.build/DerivedSources/.d) (in target 'Runner' from project 'Runner')
note: Building targets in dependency order
warning: Run script build phase 'Run Script' will be run during every build because it does not
specify any outputs. To address this warning, either add output dependencies to the script
phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the
script phase. (in target 'Runner' from project 'Runner')
warning: Run script build phase 'Thin Binary' will be run during every build because it does not
specify any outputs. To address this warning, either add output dependencies to the script

phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the
script phase. (in target 'Runner' from project 'Runner')
Result bundle written to path:
    /var/folders/xx/vpg2v8852m10wmfg9d0h_q5c0000gn/T/flutter_tools.9lcV7A/flutter_ios_build_temp_di
    rvObfgH/temporary_xcresult_bundle

Error (Xcode): unable to open dependencies file
(/Users/nims/Library/Developer/Xcode/DerivedData/Runner-fqydwlwntmngiyefwerakcimabvl/Build/Interm
ediates.noindex/ArchiveIntermediates/Runner/IntermediateBuildFilesPath/Runner.build/Release-iphoneos
/Runner.build/DerivedSources/.d)
Encountered error while archiving for device.

@nimaam you can try to change deployment target to 12.0 and rebuild

I made the change, and I got this error (scripts error)
Xcode's output:
↳
Writing result bundle at path:
/var/folders/xx/vpg2v8852m10wmfg9d0h_q5c0000gn/T/flutter_tools.bRYaup/flutter_ios_build_temp_di
rFxGFxN/temporary_xcresult_bundle
1 warning generated.
Project /Users/nima/vsprojects/sipvoidp24/voip24h_sdk_mobile/example built and packaged
successfully.error: unable to open dependencies file
(/Users/nima/Library/Developer/Xcode/DerivedData/Runner-fqydwlwntmngiyefwerakcimabvl/Build/In
termediates.noindex/ArchiveIntermediates/Runner/IntermediateBuildFilesPath/Runner.build/Release-
iphoneos/Runner.build/DerivedSources/.d) (in target 'Runner' from project 'Runner')
note: Building targets in dependency order
warning: Run script build phase 'Run Script' will be run during every build because it does not
specify any outputs. To address this warning, either add output dependencies to the script
phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the
script phase. (in target 'Runner' from project 'Runner')
warning: Run script build phase 'Thin Binary' will be run during every build because it does not
specify any outputs. To address this warning, either add output dependencies to the script
phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the
script phase. (in target 'Runner' from project 'Runner')

Result bundle written to path:
    /var/folders/xx/vpg2v8852m10wmfg9d0h_q5c0000gn/T/flutter_tools.bRYaup/flutter_ios_build_temp_di
    rFxGFxN/temporary_xcresult_bundle

Error (Xcode): unable to open dependencies file
(/Users/nima/Library/Developer/Xcode/DerivedData/Runner-fqydwlwntmngiyefwerakcimabvl/Build/Interm
ediates.noindex/ArchiveIntermediates/Runner/IntermediateBuildFilesPath/Runner.build/Release-iphoneos
/Runner.build/DerivedSources/.d)
Encountered error while archiving for device.

is there any way that I fix this part?

is there any way that I fix this part?
I found the solution, you can try it https://stackoverflow.com/questions/73045366/unable-to-open-dependencies-file-xcode-14swift-5

@nimaam thank you for your feedback, we will update the new feature in next version


CheckIn cards & interaction (EXPOSUREAPP-5410)

This PR aims to add:

CheckIn list behavior
Cards for active CheckIns + interaction
Cards for old CheckIns + interaction

The list displays dummy data and the menus/clicks don't do anything yet, this will come in a different PR.
The card for old check-ins currently says 21.01.2021, 18:01 - 18:26, without the Uhr, I will add this in a different PR after it is clear how we handle check-ins spanning multiple days.

It seems that the padding of the floating button on the right side slightly too big.


Best way to pass asnyc function property in html

I wanted to create my own autocomplete component and it has a function parameter where the items can be searched
Now I wanted to do the following:
<my-autocomplete optionsasnyc='${async function(e) { await new Promise(xxx); return e.searchtext; } } '><mw-autocomplete>
Now I defined the optionsasnyc parameter as type object and attribute=false, but the property always stays null
What is the best way to do this? Or is it not possible to define a (asnyc) function parameter in html? Do I need to do it in Javascript?

@MichaelPeter to set properties in lit-html you need to prefx the "attribute" name with a .: https://lit-html.polymer-project.org/guide/writing-templates#bind-to-properties
Property names are case-sensitive, so make sure that the property is really optionsasync, not optionsAsync. (you also had a mispelling in the name above, so check that).
html`<my-autocomplete .optionsasync='${async function(e) { await new Promise(xxx); return e.searchtext; } } '><mw-autocomplete>`

@justinfagnani: thank you very much for your answer, the missing '.' was what cost me half a day, now it works :) The uppercase was because I typed it on the phone after it kept me awake after work ;).

@MichaelPeter I'm glad that helped, but sorry you lost half a day.
I'd recommend using the lit-plugin extension if you use VS Code: https://marketplace.visualstudio.com/items?itemName=runem.lit-plugin or the lit-analyzer tool: https://www.npmjs.com/package/lit-analyzer
They can help catch invalid bindings.

Will try lit analyzer since I use normal visual studio, thanks!


rebase: use v0.17.0 of go-ceph library

new version of go ceph is available and this commit make use
of the same.
Ref # https://github.com/ceph/go-ceph/releases/tag/v0.17.0
This go-ceph version also bring changes to some APIs which is part of pre release tag of Ceph build quincy.
Enabling the tag ceph_pre_quincy for the same reason.
Signed-off-by: Humble Chirammal<EMAIL_ADDRESS>

@humblec CI is failing can you please check

The new APIs are causing the failure.. the go-ceph part of these APIs are "preview mode"
  internal/cephfs/core/metadata.go:86:12: fsa.RemoveMetadata undefined (type *"github.com/ceph/go-ceph/cephfs/admin".FSAdmin has no field or method RemoveMetadata) (typecheck)
	err = fsa.RemoveMetadata(s.FsName, s.SubvolumeGroup, s.VolID, key)
	          ^
internal/cephfs/core/snapshot_metadata.go:64:12: fsa.SetSnapshotMetadata undefined (type *"github.com/ceph/go-ceph/cephfs/admin".FSAdmin has no field or method SetSnapshotMetadata) (typecheck)
	err = fsa.SetSnapshotMetadata(s.FsName, s.SubvolumeGroup, s.VolID, s.SnapshotID, key, value)
	          ^
internal/cephfs/core/snapshot_metadata.go:83:12: fsa.RemoveSnapshotMetadata undefined (type *"github.com/ceph/go-ceph/cephfs/admin".FSAdmin has no field or method RemoveSnapshotMetadata) (typecheck)
	err = fsa.RemoveSnapshotMetadata(s.FsName, s.SubvolumeGroup, s.VolID, s.SnapshotID, key)

Looks like the CephFS metadata functions are only valid for pre-Quincy versions? Not sure if Quincy requires other functions, or how it is done there. Maybe @pkalever knows.

I think the reason we added those APIs as the preview was that the intended Ceph PRs introducing those metadata commands were still in master and not released in any Ceph release yet. Need to check if they were available in the latest release of Ceph and should move them to stable API sections in go-ceph.

Looks like the CephFS metadata functions are only valid for pre-Quincy versions? Not sure if Quincy requires other functions, or how it is done there. Maybe @pkalever knows.

Quincy and pre-quincy have the same commands and APIs, the original Quincy PRs are backported to the pacific and octopus.

As in https://github.com/ceph/ceph-csi/pull/3308#issuecomment-1217773138 one of the tags below should help
ceph_pre_{qunicy/pacific}
or
ceph_main

I think the reason we added those APIs as the preview was that the intended Ceph PRs introducing those metadata commands were still in master and not released in any Ceph release yet. Need to check if they were available in the latest release of Ceph and should move them to stable API sections in go-ceph.

Looks like these metadata commands are targeted for Ceph - v18.0.0, which is not out yet!, we still need to wait on this!

@nixpanic @pkalever as anticipated ceph_pre_quincy helps here. ptal .. thanks.

@Mergifyio rebase

Tests are stuck , rebasing due to the same reason .

/retest ci/centos/k8s-e2e-external-storage/1.22

/retest ci/centos/upgrade-tests-cephfs

/retest ci/centos/mini-e2e/k8s-1.24

/retest ci/centos/mini-e2e/k8s-1.24

/retest ci/centos/mini-e2e-helm/k8s-1.22

@mergifyio rebase


(transport/nio) Build NIO transport test jar so other projects can make use of testware…

...like TcpConnectorRule.

@cmebarrow where do you plan to use this dependency ? Then changing something (for e.g. TcpConnectorRule) in this artifact may break the component that uses this dependency.

@jitsni In enterprise.gateway, in two of the ITs for the jms service.

Closing to avoid Jitu's objection (introducing a test dependency on the way and forcing publishing of a test jar from gateway). Will duplicate TcpConnectorRule class instead.


Fix rowSpan on DecisionTable input and annotations sections. Also valid for DMN Runner table. (and future SceSim!)

This PR address rowSpan for decision table inputs and annotations in DMN expression editor.
The state of the DMN Runner table is unchanged comparing bee-reisizing-perf branch
I am open to naming suggestion for new API parts instead of currently introduced mergedHeaderGroups and MergedGroups.

I tried the logic also for simulated three levels of headers

@tiagobento please re-review

How are we with this one? As far as I remember there was an issue with the borders and selection of the <th>s with rowSpan > 1, right?

Manual Testing
LGTM, thank you @jomarko.
Just a couple of considerations
regarding the next steps (I guess you already considered them)

Output: Should we consider merging the cells, in case of a single output? (like the old BEE)

Left column headers: We should consider merging them as well, I would accept having that "O" in a two-level header, but with a multiple-level header is it  not nice to see, IMHO

Code reviewing is next.

Closing in favor of https://github.com/tiagobento/kie-tools/pull/89


Discussion: Reporting requirements

(Don't know if this is the best place/way to talk about it but lets do this for a start. Perhaps wiki or something else might be better?)
Let's have a place to collect and discuss our requirements for reporting.  This will drive whatever dev work we need to do to get these done. Feel free to edit / comment etc.
One thing is certain: there are different use case which may require different kind of reporting.
For now, briefly:

1. Ad-hoc runs for visual inspection of results
(current use case)

Run the benchmarks in ad-hoc manner;
See the results on screen;
Possibly copy/paste into some blog in Markdown format;
The main goal here is to compare results between each other on-screen.

Key here is:

Have results displayed so they are easily viewed on screen;
Numbers should be easily comparable;
Want to see what's faster/slower and by how much;
Compact Markdown-friendly form.

(this is catered by the current reporting, with some enhancements we could do there)

2. Spreadsheet analytics

Run lots of different benchmarks, possibly on multiple systems;
Collate all results;
Load into Excel whatever and analyse and chart there.

Key here is:

Output format friendly for Excel / other analytics tools, means probably CVS;
Comparison between results of the same benchmark on the same system;
Comparison between results from runs on different systems.

3. Fully automated runs, dashboards etc
This extends on "Excel" case and adds automation and scale.

Run many benchmarks on many systems;
Do this on regular basis;
The benchmarks themselves may be some code which changes over time;
The execution environments may change over time (patches, infrastructure changes etc);
The benchmarks are scheduled to run on regular basis in automated mode;
Results are collected and published to reporting/analytics systems (e.g. Splunk, PowerBI);
Dashboards are created to see trends over time, alerts for degradations etc.

Keys are:

Automation-friendly;
Collect and keep the results;
Timestamps in results are a must;
Friendly for ingestion to target analytics systems;
Friendly for dashboard-building;
Friendly for alerting;

These are probably the main ones for a start I can think of now.

@ppanyukov, thank you for your ideas. Of course, all kind of reporting are important. However, just for now I suggest to focus on ad-hoc runs for visual inspection of results, it is the most actual problem. After that, we can think in detail about export formats.

Yes I agree. We (or rather I) will improve the adhoc first :)
These are from the use cases I have in real life and are here to keep the big picture in mind and understand why certain reports need to have different formatting requirements. For example, why number alignment and using the same units in ad-hoc is important.

I agree with all the comments above, basically get 1 (Ad-hoc runs for visual inspection of results) sorted out first and then do 2 (Spreadsheet analytics) and 3 (Fully automated runs, dashboards etc)
The majoriy of work needed for 2 and 3 can be handled by allowing the results from a command line run to be exported to .csv, .json and/or .xml

Want to see what's faster/slower and by how much;

For this, maybe there could be a mode where the results are sorted, faster -> slowest, rather than in alphabetical order?

@mattwarren,

For this, maybe there could be a mode where the results are sorted, faster -> slowest, rather than in alphabetical order?

It is a good point, but I think that we should use the alphabetical order as a default because it allows to easily compare results in different environments. However, it would be great to create a command line argument for different display orders.

but I think that we should use the alphabetical order as a default

yeah that makes sense

@ppanyukov, @mattwarren, I have committed some stuff for the future reporting system, see https://github.com/PerfDotNet/BenchmarkDotNet/commit/e5f7484f4d0f7acd9a23d91cbcc6615c8fa8154b What do you think?

I just had a quick look at the code, looks good.
It's a nice way of seperating out the different behaviours csv, markdown etc. Should make it nice and easy to extend it in the future, for instance json
Will it be a configurable via a command-line argument?

Will it be a configurable via a command-line argument?

Yep, I will add the configuration support soon.

I had a look at the change on my phone :)
Broadly looks fine to me, with a couple of comments:

obviously, as was already mentioned, some command line options to specify output type(s) would be nice;

I understand that csv and md outputs are currently created regardless. Obvious concern is not everybody would want it. More subtly the whole thing may fail after running the for a while if there are no permission to write the file. Sort of brings us back to command line args. A workaround is to try create output file before we run any benchmarks and fail fast right then rather than at the very end. Probably something to think about even with command line options.

Regarding the command line args, ideally would be nice to specify multiple output types I guess. For example you might have:
Run.exe --mdOut foo.md --csvOut bar.csv

For parsing command line options I found this package which worked well for me: CommandLineParser.
You can see sample usage here: https://github.com/ppanyukov/WebReplay/blob/master/src/WebReplay/CommandLineOptions.cs
You can see the kind of options / help it produces here: https://github.com/ppanyukov/WebReplay/blob/master/readme.md
Sent from my iPhone

On 2 Sep 2015, at 13:41, Andrey Akinshin<EMAIL_ADDRESS>wrote:
Will it be a configurable via a command-line argument?
Yep, I will add the configuration support soon.
—
Reply to this email directly or view it on GitHub.

obviously, as was already mentioned, some command line options to specify output type(s) would be nice;

Ok, it will be done.

if there are no permission to write the file

Then we have a problem: BenchmarkDotNet generates whole projects and compiles it. Regardless defaults, command line args is a good idea.

Ah ok, ignore the permissions bit then. Although with users being able to specify arbitrary output paths the problem may return. A minor issue in the grand scheme of things.
Sent from my iPhone

On 3 Sep 2015, at 00:31, Andrey Akinshin<EMAIL_ADDRESS>wrote:
obviously, as was already mentioned, some command line options to specify output type(s) would be nice;
Ok, it will be done.
if there are no permission to write the file
Then we have a problem: BenchmarkDotNet generates whole projects and compiles it. Regardless defaults, command line args is a good idea.
—
Reply to this email directly or view it on GitHub.

@ppanyukov, I think, we have a nice reporting system now. It's flexible, we have a lot of standard exporters, you can also write you own classes which export benchmark results to any format. So, I close this issue. If you have some additional specific requests, please, create a new issue.