Do not display the add network screen in case the network already exists

Describe the bug
Do not display the add network screen in case the network already exists when user add network from dApp
Steps:

Go to chainlist.org
Connect wallet successfully
On the Chainlist page, click on "Add to wallet" button
Perform add a network to SubWallet successfully
Back to Chainlist page, click on "Add to wallet" button again
Observe the screen displayed

Actual: Do not show add network screen

Expect: Show the add network screen with message "The network already exists"

Hi @ I suggest you contact Chainlist UI developers on their web3chain website CHAINLIST SUPPORT for assistance right away. Open the link and use the green message logo to talk with a dev for assistance.

@saltict Please re-check: Still do not display the add network screen in case the network already exits
Version test: https://file.cdmteck.com/s/4oimk9zDJ8R5Aai/download?path=%2F&files=./upgrade-ui-pr-1259-build-1.0.2-1-2023-04-20T11-25-52UTC.zip

Version test: https://file.cdmteck.com/s/4oimk9zDJ8R5Aai/download?path=%2F&files=./upgrade-ui-pr-1259-build-1.0.2-1-2023-04-21T04-20-10UTC.zip
Validation passed.


chore: adjust dependabot config

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Python 3.5 Issue

Rasa version: 1.3.10
Python version: 3.5.6
Operating system (windows, osx, ...): OSX 10.15.4
Issue: Running rasa shell / rasa train (only tested these 2 cli commands, may include more) causes syntax errors.
My installation steps:

conda create -n py35 python=3.5
conda activate py35
export MACOSX_DEPLOYMENT_TARGET=10.9
pip install rasa

When installing on OSX 10.15.4, I had to set a variable before running pip install rasa in order for the build to run against libc++ as referenced here: https://stackoverflow.com/questions/56083725/macos-build-issues-lstdc-not-found-while-building-python-package
The variable set was export MACOSX_DEPLOYMENT_TARGET=10.9
Error (including full traceback):
rasa shell:
Traceback (most recent call last):
  File "/Users/shota/anaconda3/envs/py35/bin/rasa", line 11, in <module>
    sys.exit(main())
  File "/Users/shota/anaconda3/envs/py35/lib/python3.5/site-packages/rasa/__main__.py", line 76, in main
    cmdline_arguments.func(cmdline_arguments)
  File "/Users/shota/anaconda3/envs/py35/lib/python3.5/site-packages/rasa/cli/shell.py", line 101, in shell
    rasa.cli.run.run(args)
  File "/Users/shota/anaconda3/envs/py35/lib/python3.5/site-packages/rasa/cli/run.py", line 116, in run
    rasa.run(**vars(args))
  File "/Users/shota/anaconda3/envs/py35/lib/python3.5/site-packages/rasa/run.py", line 34, in run
    import rasa.core.run
  File "/Users/shota/anaconda3/envs/py35/lib/python3.5/site-packages/rasa/core/run.py", line 15, in <module>
    from rasa import server
  File "/Users/shota/anaconda3/envs/py35/lib/python3.5/site-packages/rasa/server.py", line 14, in <module>
    from sanic_jwt import Initialize, exceptions
  File "/Users/shota/anaconda3/envs/py35/lib/python3.5/site-packages/sanic_jwt/__init__.py", line 7, in <module>
    from .authentication import Authentication
  File "/Users/shota/anaconda3/envs/py35/lib/python3.5/site-packages/sanic_jwt/authentication.py", line 117
    **kwargs,
            ^
SyntaxError: invalid syntax

rasa train:
Traceback (most recent call last):
  File "/Users/shota/anaconda3/envs/py35/bin/rasa", line 11, in <module>
    sys.exit(main())
  File "/Users/shota/anaconda3/envs/py35/lib/python3.5/site-packages/rasa/__main__.py", line 76, in main
    cmdline_arguments.func(cmdline_arguments)
  File "/Users/shota/anaconda3/envs/py35/lib/python3.5/site-packages/rasa/cli/train.py", line 75, in train
    kwargs=extract_additional_arguments(args),
  File "/Users/shota/anaconda3/envs/py35/lib/python3.5/site-packages/rasa/train.py", line 40, in train
    kwargs=kwargs,
  File "uvloop/loop.pyx", line 1456, in uvloop.loop.Loop.run_until_complete
  File "/Users/shota/anaconda3/envs/py35/lib/python3.5/asyncio/futures.py", line 294, in result
    raise self._exception
  File "/Users/shota/anaconda3/envs/py35/lib/python3.5/asyncio/tasks.py", line 240, in _step
    result = coro.send(None)
  File "/Users/shota/anaconda3/envs/py35/lib/python3.5/site-packages/rasa/train.py", line 91, in train_async
    kwargs,
  File "/Users/shota/anaconda3/envs/py35/lib/python3.5/site-packages/rasa/train.py", line 175, in _train_async_internal
    kwargs=kwargs,
  File "/Users/shota/anaconda3/envs/py35/lib/python3.5/site-packages/rasa/train.py", line 210, in _do_training
    kwargs=kwargs,
  File "/Users/shota/anaconda3/envs/py35/lib/python3.5/site-packages/rasa/train.py", line 339, in _train_core_with_validated_data
    kwargs=kwargs,
  File "/Users/shota/anaconda3/envs/py35/lib/python3.5/site-packages/rasa/core/train.py", line 33, in train
    from rasa.core.agent import Agent
  File "/Users/shota/anaconda3/envs/py35/lib/python3.5/site-packages/rasa/core/agent.py", line 16, in <module>
    from rasa.core.channels.channel import InputChannel, OutputChannel, UserMessage
  File "/Users/shota/anaconda3/envs/py35/lib/python3.5/site-packages/rasa/core/channels/__init__.py", line 21, in <module>
    from rasa.core.channels.mattermost import MattermostInput  # nopep8
  File "/Users/shota/anaconda3/envs/py35/lib/python3.5/site-packages/rasa/core/channels/mattermost.py", line 2, in <module>
    from mattermostwrapper import MattermostAPI
  File "/Users/shota/anaconda3/envs/py35/lib/python3.5/site-packages/mattermostwrapper/__init__.py", line 1, in <module>
    from .wrapper import MattermostAPI
  File "/Users/shota/anaconda3/envs/py35/lib/python3.5/site-packages/mattermostwrapper/wrapper.py", line 89
    print(f"The post channel token is: {self.token}")
                                                   ^
SyntaxError: invalid syntax

Command or request that led to error:
rasa shell
rasa train

Content of configuration file (config.yml) (if relevant):
# Configuration for Rasa NLU.
# https://rasa.com/docs/rasa/nlu/components/
language: en
pipeline: supervised_embeddings

# Configuration for Rasa Core.
# https://rasa.com/docs/rasa/core/policies/
policies:
  - name: MemoizationPolicy
  - name: KerasPolicy
  - name: MappingPolicy

Content of domain file (domain.yml) (if relevant):
intents:
  - greet
  - goodbye
  - affirm
  - deny
  - mood_great
  - mood_unhappy

actions:
- utter_greet
- utter_cheer_up
- utter_did_that_help
- utter_happy
- utter_goodbye

templates:
  utter_greet:
  - text: "Hey {name}! How are you?"

  utter_cheer_up:
  - text: "Here is something to cheer you up:"
    image: "https://i.imgur.com/nGF1K8f.jpg"

  utter_did_that_help:
  - text: "Did that help you?"

  utter_happy:
  - text: "Great carry on!"

  utter_goodbye:
  - text: "Bye"

Attempted a fresh install in a new conda environment again and this time I was successfully installed rasa without the export MACOSX_DEPLOYMENT_TARGET=10.9. Not sure what the issue was with that. The issue above with rasa shell and rasa train is still present.

Thanks for raising this issue, @wochinge will get back to you about it soon✨
Please also check out the docs and the forum in case your issue was raised there too 🤗

@shotamakino Rasa Open Source is not compatible with Python 3.5. Please use Python 3.6 or Python 3.7.


DEP: Deprecate private namespaces in scipy.optimize

Reference issue

gh-14360
What does this implement/fix?

Additional information

cc: @rgommers

Also, CI is still broken.

there are still moduleTNC.so and minpack2.so left. Could you give those an underscore as well?

Ah! okay. No worries. I will do that.

I am fixing mypy errors. Will push after verifying locally.

The doc build is still broken, trying to use optimize.optimize

I get the following warning in docs,
docstring of _odrpack.odr:16: WARNING: py:obj reference target not found: ODR
docstring of _odrpack.odr:28: WARNING: py:obj reference target not found: ODR
/Users/czgdp1807/scipy_project/scipy/build/testenv/lib/python3.9/site-packages/scipy/optimize/_root.py:docstring of scipy.optimize._root.root:86: WARNING: py:obj reference target not found: nonlin
/Users/czgdp1807/scipy_project/scipy/build/testenv/lib/python3.9/site-packages/scipy/odr/__init__.py:docstring of scipy.odr:29:<autosummary>:1: WARNING: py:obj reference target not found: scipy.odr.ODR
/Users/czgdp1807/scipy_project/scipy/build/testenv/lib/python3.9/site-packages/scipy/optimize/__init__.py:docstring of scipy.optimize:396: WARNING: py:mod reference target not found: scipy.optimize.nonlin
release/0.11.0-notes.rst:85: WARNING: py:obj reference target not found: nonlin
release/1.6.0-notes.rst:47: WARNING: py:obj reference target not found: scipy.odr.ODR

And the following message,
build finished with problems, 14 warnings.
make: *** [html-scipyorg] Error 1
Traceback (most recent call last):
  File "/Users/czgdp1807/scipy_project/scipy/runtests.py", line 566, in <module>
    main(argv=sys.argv[1:])
  File "/Users/czgdp1807/scipy_project/scipy/runtests.py", line 215, in main
    subprocess.run(cmd, check=True)
  File "/Users/czgdp1807/mambaforge/envs/scipy-dev/lib/python3.9/subprocess.py", line 528, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['make', '-Cdoc', 'PYTHON="/Users/czgdp1807/mambaforge/envs/scipy-dev/bin/python"', 'html-scipyorg', 'latex', 'SPHINXOPTS="-j2"']' returned non-zero exit status 2.

Are they okay?

I think other test failures are unrelated?

I'll have a look, the docs warnings are slightly odd - unclear to me why the ODR ones are showing up now for example.

I think in release notes we use module names before this deprecation. Hence, now nonlin doesn't exist because it's converted to _nonlin. Should we update release notes as well?

I think in release notes we use module names before this deprecation. Hence, now nonlin doesn't exist because it's converted to _nonlin. Should we update release notes as well?

yes we should, just to avoid doc build warnings

Hmm, I fixed most things, but nonlin is a little annoying. While there is nothing in optimize.nonlin that is not also present in optimize, it had its own submodule docs for some reason: http://scipy.github.io/devdocs/reference/optimize.nonlin.html#module-scipy.optimize.nonlin.
I'd prefer to get rid of that, moving to _nonlin and merging the docs content with the main optimize docs. But I want to flag that and make sure we're okay with that. The alternative is to add optimize.nonlin to the list of public API modules in http://scipy.github.io/devdocs/reference/index.html#api-definition and revert some of the changes in this PR (and keep the duplicate exposing of functions in the two namespaces). Anyone have any objections to getting rid of the nonlin namespace @scipy/scipy-core-team?

Anyone have any objections to getting rid of the nonlin namespace @scipy/scipy-core-team?

None here, sounds like a good plan to me

Only thumbs up for not making nonlin public. Also, I realized after writing this that all functions in it are legacy, root(..., method='xxx') is recommended instead.
CI is green except for the expected linting complaints, so in it goes. Thanks @czgdp1807, all.


Refactor: Improve folder structure

We currently have a mess of files in the utils folder.
I think we should clean up this folder and move utilities to folders related to rules:
.
├── rules/
│   ├── sort-classes/
│   │   ├── some-class-utility.ts
│   │   └── types.ts
│   ├── sort-imports/
│   │   └── detect-import-type.ts
│   ├── sort-classes.ts
│   ├── sort-imports.ts
│   └── sort-exports.ts
├── test/
│   ├── rules/
│   │   ├── sort-classes/
│   │   │   └── types.test.ts
│   │   ├── sort-classes.test.ts
│   │   └── sort-imports.test.ts
│   └── utils/
│       └── compare.test.ts
└── utils/
    └── compare.ts

Common utilities should remain in the utils folder.

@azat-io

I think we should clean up this folder and move utilities to folders related to rules

👍 100% agree
What do you think about moving test files next to their source?
.
├── rules/
│   ├── sort-classes/
│   │   ├── some-class-utility.ts
│   │   ├── types.ts
│   │   └── types.test.ts
│   ├── sort-imports/
│   │   ├── detect-import-type.ts
│   │   └── detect-import-type.ts
│   ├── sort-classes.ts
│   ├── sort-classes.test.ts
│   ├── sort-imports.ts
│   ├── sort-imports.test.ts
│   ├── sort-exports.ts
│   └── sort-exports.test.ts
└── utils/
    ├── compare.ts
    └── compare.test.ts

@hugop95 I don't know, I think it would be cleaner if the tests were kept in a separate folder.
What do you think?

@azat-io I think there are pros and cons with each. Ultimately though, it's really a matter of personal preference.
Pros of having tests next to their source code

Easy to go to the tests of a given file, especially for bigger projects with a lot of nested folders (not necessarily the case here at the moment). Most IDEs make it easy to distinguish between files

Example

Cons

We have to switch from configuring things based on folders (rules vs tests) to configuring based on file suffix (.test.ts or not).

I just feel like there would be too many files in the rules folder and it would be a little harder to navigate if I wanted to read only the tests or only the source code of the rules.
Personally, I prefer a separate folder for tests.
I would like to hear other opinions.


Emissions data display in the quarterly view and hourly seems incorrect

The value displaying in the Quarterly Summary View is not matching with the value in the Summary Value table.
Example:

Import 2023 Q3 emissions from historical for oris 8906, CP30, 31RH, 31SH
Select Quarterly Summary View for 31RH then apply filter
The total op hours in the quarterly reported row should be 1507 not 1753.
The total op time hours should be 1502.41 not 1748.58

The hourly value seems incorrect.

Repeat step 1
Select Hourly NOx Rate CEMS View the apply filter
Date/Hour column display 7/17/2023 12:00 as the first row.  The first row should show 7/1/2023 00:00 as the first row.

Was not able to replicate issue by retrieving 2023 Q3 ORIS 8906 8906, CP30, 31RH, 31SH. Op hours/ op time totals were matching values from camdecmps.summary_value table and values in 1.0. I also looked at ORIS 3470, MS1, MS2, WAP8 and ORIS 3, 4 2023 Q3 emissions data which looked fine as well.

The total op hours value display in ECMPS test is 1753, total op time is 1748.58.  FACT, CAMPD, and the SUMMARY-VALUE table shows the same value,

Determined to not be an issue. Data were accurately different among environments


Links to gifs do not unfold

Hi guys,
Thanks for this cool step! :D
We were using it in its 2.1.0 version and were able to send gifs on succesful/failed builds.
Unfortunately, when updating to 2.3.0, the gifs do not unfold anymore :(
See below the difference: the two first messages were sent with 2.3.0 version of the step, and the two last with version 2.1.0. A green line has also been added in the body of the message (probably the cause of this :))

Yeah, I believe this is related to the change from raw text messages to Slack's attachment API in 2.2.0 and 2.3.0 - https://github.com/bitrise-io/steps-slack-message/releases - 2.2.0 had an option to use the raw text option, which was removed in 2.3.0
Do you know if link expansion can be enabled in Slack's attachment API? Or is it a text only option?

Looking into Slack's documentation on attachments, could it not be achieved by adding the image_url parameter to be editable?
Example:  example

That very well might work @simonmartyr - if you have the time feel free to test it & send a PR!

Thanks @simonmartyr for the PR!
Released in v2.4.0 (https://github.com/bitrise-io/steps-slack-message/releases/tag/2.4.0) - should be available on bitrise.io too, once the publish is accepted (~10-20 mins)!


Added Dropdown Basic Custom Hook

Entered a JS file with a Custom Dropdown Hook which can use in adding Dropdowns.
Hope it may help others

Yo @Ahsan-Ehtesham !
Thank you for your proposal but I'm not sure if I can accept to add your custom hook in captain-hook repository.
Because, it looks like more an UI component than a custom hook. I'm more interested about custom hook who handle logic without UI, if you see what I mean.
But again, thank you for your help. It's very kind of you :+1:

Okay Great!!!


Adding Ecobee via integration doesn't work

Home Assistant release with the issue:

.100 dev
Last working Home Assistant release (if known):
N/A
Operating environment (Hass.io/Docker/Windows/etc.):

Docker
Component/platform:

Ecobee
Description of problem:
I tried testing the new ecobee integration in my dev instance (fresh install, no ecobee in config.yaml) and every time I click the box to add the integration, i see a new window but it closes and i'm back at the integration menu. Tried in Chrome and Firefox. Adding it to config.yaml it worked fine.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

Traceback (if applicable):

Additional information:
This was the PR: https://github.com/home-assistant/home-assistant/pull/26634
@marthoc

I see the problem. @MartinHjelmare I will push a fix.


[Bug]: Sign Qtum transaction failed with Ledger

Impacted Library name
@ledgerhq/hw-app-btc
Impacted Library version
10.0
Describe the bug
The following error happens when trying to sign Qtum transaction failed with Ledger.
Error message:
'Something went wrong during signing: data.length exceed 256 bytes limit. Got: 271'
The error only happens when UTXO that was generated from Offline Staking smart contract is specified as input of the transaction.
Example UTXOs:
https://qtum.info/tx/3188b3302216d3c4bbb133df72dadddbd00854b590161383495386a05dbadecc
https://qtum.info/tx/72b7f31dc9b4acc06b57575ab9b9ed12887f62602a8eee9fc18d88dba746f95a
Expected behavior
he sign of Qtum transaction with Ledger should work no matter how the UTXO was generated.
Additional context
No response

@JoeGruffins visit the official page to initiate a chat with an agent on a live chat to report this error for review and for further assistance via Ledger Live


Add line wrapping or custom filetype

Hey! Love this plugin, it's minimalist approach fits my needs perfectly.
It would be great to have line wrapping, especially in split windows.
I have setlocal wrap linebreak nolist textwidth=0 for the markdown filetype, but it's currently working with FlyboyOpenVSplit.
A custom filetype in general might be useful, then you could also do specific Flyboy bindings, such as FlyboySendMessage once you're in a Flyboy window? As long as it still adopts the markdown syntax!

Hey, thanks for the issue!
I'm a little wary of using a custom filetype, I worry that people already have integrations set up for markdown that would break if there's a custom filetype. I don't want to be too prescriptive with a bunch of keybindings that people are just going to rebind either :thinking:
Could I fix this by having an on_open function hook in the setup? That might allow you to run specific things in the buffer opened by Flyboy.

IE even for myself I have a filetype markdown autoformatter. But maybe people should opt in to using that with flyboy buffers. I'll have to give it a bit more thought.


use await/async and skip useless extra work

save 1 useless Mongo read
refactor and use async/await
call sendRssFeedToCollections once per feed
limit max amount of articles to fetch to 1k

how do you know it works?

I ran rss_worker with increased logging and everything was working


Upgrade OpenTelemetry dependencies.

I am facing a peer dependency conflict in my monorepo project, which includes both a frontend and a backend app. Both apps use OpenTelemetry.
The frontend project uses @opentelemetry/auto-instrumentations-web: 0.36.0, which depends on:

@opentelemetry/instrumentation: 0.48.0.

On the other hand, the backend uses @honeycombio/opentelemetry-node: 0.7.0, which depends on:

@opentelemetry/sdk-node: 0.46.0. This, in turn, depends on:

@opentelemetry/instrumentation: 0.46.0.

I could use an older version of @opentelemetry/auto-instrumentations-web to match the @opentelemetry/instrumentation version, but @opentelemetry/instrumentation has this bug which needs to be fixed to be able to add web OpenTelemetry, it was fixed in version 0.47.0
Ideally, Honeycomb would upgrade all of its OpenTelemetry dependencies. I noticed there's already an open PR for this (https://github.com/honeycombio/honeycomb-opentelemetry-node/pull/286) , but it's failing on the smoke test step. It would be great if we could incorporate that PR into Honeycomb.
Thank you very much.

Thanks for reporting! Release v0.7.1 is now available that should help resolve this problem!


Set elisp lookups for helpful-mode

I often read the extracted source code in helpful. This would allow using
+lookup/documentation and co. in helpful, which saves a few key presses
compared to the ivy/helm stuff on SPC h f/v.

Should I also add helpful to the repl & eval handlers that are set for emacs-lisp?
Or maybe its an overkill, since you could just go to the linked source file at this point.

I think that'd be overkill. For now the lookup handlers are good enough.

Yeah, you are probably correct. Moved it to emacs-lisp/config.el.

Thanks!


Add namespace import

Example:
import * as foo from "foo";

will be transformed into:
const foo = __cjsInterop1__?.default?.__esModule
            ? __cjsInterop1__.default
            : __cjsInterop1__;
import __cjsInterop1__ from "foo";

Thank you for your contribution and taking the time to write tests 🎉
Merged and published as 1.1.0.


Added missing pluginbase reference to fix #64

Hi, saw the help wanted tag and decided to give it a shot. I'm not a Python dev, but I've tested locally and it seems to fix the problem.

@vegardvaage thanks for doing this!!  Of course we've been busy at Black Hat USA and DEFCON.  BTW we gave you a shout out for filing great issues in our Black Hat arsenal talk.  Keep 'em coming.


Metric check for "mongostat" utility

 mongotop utility provides useful collection and db level metrics that could be stored in a Graphite or other time series database. We could write a Sensu plugin that parses the JSON output of mongostat and construct metrics that can be relayed by Sensu handlers.
Once we've some inputs, I'd be happy to contribute in writing/testing a Python script to do the job.

I found a plugin to do exactly this, however getting an error.

Looks like you got that plugin working. Would be nice to have that one contributed the community plugins.


Bootstrap-table with x-Editable

Guys, here is the problem

We load multiple pages
We have a drop down on one column where user selects the REASON for their inquiry
But when user does back and forth(i.e. Change Page from x to y), values selected in dropdown are not retained.

Help is appreciated.

You need to make use of some sort of temporary storage functionality to retain information across page loads.

Use sessions and store data in it (PHP $_SESSION or equivalent in another language)
Use HTML5 localStorage (not suitable for older browsers)
Make use of Ajax so you don't have page loads

Thank you Allerion. That is what we happened to do it. However i was expecting something at Plug in level to "Update Client Side Data". We wanted to update all data not just the Page user is looking at. For example, if we have 7 pages of 10 records per page, we wanted to GLOBALLY UPDATE ONE FIELD's value on all the pages.
However I appreciate your reply and we exactly implemented what you mentioned. Thx.


Add check for complete pattern matching #21

Add a field to environment entries for data type declarations with the names of its constructors.
Add a compiler pass to the compiler pipeline that performs the check.
Add documentation and test cases for your compiler pass.

Right now, the check does not consider nested case expressions or case expressions that are used as another case expression's scrutinee.
For example, the check accepts the following definition:
data Foobar = Foo | Bar
f x = case x of
           Foo -> case x of
                           Foo -> Foo
           Bar -> Bar

As well as the following definition.
f x = case (case x of
                     Foo -> Foo) of
            Foo -> Foo
            Bar -> Bar


Wasm custom messages

Adds support for OsmosisMsg::Swap. `MintTokens will be a future PR.
Done: Implementations
Todo: Tests
Description

For contributor use:

[ ] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer

@ethanfrey I see you closed this without merging. Are there plans to handle wasm custom messages differently to this implementation? If so, could you point me to a branch?

We are working on this on our fork. When it is in a good state, we will rebase and make a pr on osmosis.
Since we work on a fork, I keep accidentally making prs on osmosis.

Expect a proper pr for osmosis to review sometime next week

wonderful! thanks for the quick reply :)


No way to modify input size

Hey,
Really nice plugin here, but I can't seem to find any way to change input size (input-lg, input-sm, input-xs). If I provide a "class" option to Form->input, it simply ignores it.

Latest commit should fix it.

Works like a charm! Thank you! Make sure to update the composer reference, so composer pulls the newest version.

Oh, sorry, I'm dumb, my composer just had it cached.

I updated packagist this morning after your comment, meaning it probably wasn't working before.


Git styleguide spanish translation

Despite my name, i live in spain and my language level is native. Please trust my translation 😃

👍

Nice job!

Thanks! :)


python setup.py bdist_wheel

(mypytorch) pengzhao@pengzhao:~/spconv$ python setup.py bdist_wheel
running bdist_wheel
running build
running build_py
running build_ext
Release
|||||CMAKE ARGS||||| ['-DCMAKE_PREFIX_PATH=/home/pengzhao/.conda/envs/mypytorch/lib/python3.6/site-packages/torch', '-DPYBIND11_PYTHON_VERSION=3.6', '-DSPCONV_BuildTests=OFF', '-DCMAKE_CUDA_FLAGS="--expt-relaxed-constexpr" -D__CUDA_NO_HALF_OPERATORS__ -D__CUDA_NO_HALF_CONVERSIONS__ -D__CUDA_NO_HALF2_OPERATORS__', '-DCMAKE_LIBRARY_OUTPUT_DIRECTORY=/home/pengzhao/spconv/build/lib.linux-x86_64-3.6/spconv', '-DCMAKE_BUILD_TYPE=Release']
-- The CUDA compiler identification is unknown
CMake Error at CMakeLists.txt:6 (project):
No CMAKE_CUDA_COMPILER could be found.
Tell CMake where to find the compiler by setting either the environment
variable "CUDACXX" or the CMake cache entry CMAKE_CUDA_COMPILER to the full
path to the compiler, or to the compiler name if it is in the PATH.
-- Configuring incomplete, errors occurred!
See also "/home/pengzhao/spconv/build/temp.linux-x86_64-3.6/CMakeFiles/CMakeOutput.log".
See also "/home/pengzhao/spconv/build/temp.linux-x86_64-3.6/CMakeFiles/CMakeError.log".
Traceback (most recent call last):
File "setup.py", line 99, in
zip_safe=False,
File "/home/pengzhao/.conda/envs/mypytorch/lib/python3.6/distutils/core.py", line 148, in setup
dist.run_commands()
File "/home/pengzhao/.conda/envs/mypytorch/lib/python3.6/distutils/dist.py", line 955, in run_commands
self.run_command(cmd)
File "/home/pengzhao/.conda/envs/mypytorch/lib/python3.6/distutils/dist.py", line 974, in run_command
cmd_obj.run()
File "/home/pengzhao/.conda/envs/mypytorch/lib/python3.6/site-packages/wheel/bdist_wheel.py", line 179, in run
self.run_command('build')
File "/home/pengzhao/.conda/envs/mypytorch/lib/python3.6/distutils/cmd.py", line 313, in run_command
self.distribution.run_command(command)
File "/home/pengzhao/.conda/envs/mypytorch/lib/python3.6/distutils/dist.py", line 974, in run_command
cmd_obj.run()
File "/home/pengzhao/.conda/envs/mypytorch/lib/python3.6/distutils/command/build.py", line 135, in run
self.run_command(cmd_name)
File "/home/pengzhao/.conda/envs/mypytorch/lib/python3.6/distutils/cmd.py", line 313, in run_command
self.distribution.run_command(command)
File "/home/pengzhao/.conda/envs/mypytorch/lib/python3.6/distutils/dist.py", line 974, in run_command
cmd_obj.run()
File "setup.py", line 40, in run
self.build_extension(ext)
File "setup.py", line 82, in build_extension
subprocess.check_call(['cmake', ext.sourcedir] + cmake_args, cwd=self.build_temp, env=env)
File "/home/pengzhao/.conda/envs/mypytorch/lib/python3.6/subprocess.py", line 311, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['cmake', '/home/pengzhao/spconv', '-DCMAKE_PREFIX_PATH=/home/pengzhao/.conda/envs/mypytorch/lib/python3.6/site-packages/torch', '-DPYBIND11_PYTHON_VERSION=3.6', '-DSPCONV_BuildTests=OFF', '-DCMAKE_CUDA_FLAGS="--expt-relaxed-constexpr" -D__CUDA_NO_HALF_OPERATORS__ -D__CUDA_NO_HALF_CONVERSIONS__ -D__CUDA_NO_HALF2_OPERATORS__', '-DCMAKE_LIBRARY_OUTPUT_DIRECTORY=/home/pengzhao/spconv/build/lib.linux-x86_64-3.6/spconv', '-DCMAKE_BUILD_TYPE=Release']' returned non-zero exit status 1.

when I run this step ,it get error as above .Is there anybody can help me ?I am confused about it

I have the same error I am not sure what to do


Add extension="xwalk-extensions" to tests.xml to enable automation te…

…sting
Impacted tests(approved): new 0, update 82, delete 0
Unit test platform: Crosswalk Project for Windows 20.49.525.0
Unit test result summary: pass 82, fail 0, block 0
BUG=CTS-1850

In fact, there's no test update in this PR. Pls. remove the update num.

LGTM


change(CLI): code style.

use 4 space instead of tab.
simple code style.
short length of source code.

@vkill if you have time, please take a look at this PR. ^_^


Reorganize sample datasets

Description
The project provides users with sample datasets that can be used to test the application. There is no metadata to accompany the data. The datasets are too large, each folder weighing between 20 and 40 MB.
Solution

Add metadata for each data set.
Move data sets outside this repository (e.g in a data repository like Zenodo)
Automate download of sample data sets using the data repository download API

Related to #2

The data has been extracted from the history of this repository using a git rebase operation. Since the datasets were added to the repo in the initial commit, all the commit hashes were changed. This means that all the commits in this repository now have different hashes than those in the original BitBucket repository
The datasets were moved to a separate repository: https://github.com/MurTree/murtree-data.


Add missing comparison to modulo operation

Otherwise i % 100000 evaluates to True 99999 out of 100000 times

Good catch! Thanks for submitting this. The main repository is actually on GitLab (https://gitlab.com/Plasticity/magnitude) and the GitHub is just a one-way mirror repository. So I won't merge this PR here, but I'll cherry pick this commit and merge it to the GitLab later. If you have a GitLab account and need this merged in faster, feel free to open a PR there instead.

It's not critical for me, just noticed this bug while reading the code. So feel free to merge whenever you want

Merged, Status Here: https://gitlab.com/Plasticity/magnitude/commit/65fbccf867d132b7031a54423f003a1eb1011675


Feature Request: Enable/Disable OSD Recording in goggles from TX

Ability to switch OSD Recording to files on goggles by a switch on the Open/Edge TX transmitter.
This would involve sending the signal through the ELRS Backpacks in a similar way to the VTX Channel change feature.
An important factor would be the ability to do this during flight. The idea being you can see the OSD on the screen whilst flying and be able to enable/disable the OSD recording when you go through an area which you want to record without OSD.
It would be useful to be able to see an indication on the display as to whether the feature is on/off.
An alternate option would be to have a mode where the OSD data is stored in a separate file from the Video data, similar to Walksnail.

I like this idea.
I turn Off OSD in Betaflight and Inav and was also thinking it would be nice to key goggle display state based on MSP display port state. So Goggle OSD would need three options: On / Off / Follow MSP.
-Does MSP display port data indicate when OSD has been set off?
-If not can we disable goggle OSD when MSP link data is detected and when MSP display port has no elements displayed excluding warning messages.


Is there a way to migrate parquet data and Rocks DB using flyway?

My data is stored in the form of parquet files and in rocks db. Is there any way to use flyway for their migration?

Hi. Flyway doesn't support RocksDB and since RocksDB doesn't currently have a JDBC driver it may be a while before we can. You can find a list of databases we do support under the Supported Databases section of our documentation.


Tagging a file programmatically

What's the Problem?
Currently, there is no way to tag a file with the new tagging system if not by using the UI. It would be very useful to implement a some sort of way to do that via command line.
Solution/Idea
For example it can be done through command line or, even better, by reading the already present metadata in windows that it uses  (for example implementing EXIF into the whole tag system, but that would be a little out of scope.
The simplest method it'd be to use the command line.
files -tag "C:\Path\To\File.txt" "Blue"
Alternatives
Currently there aren't really any alternatives to interact programmatically with the tag system in Files, none that I know of at least.
Files Version
No response
Windows Version
No response
Comments
No response

This issue should be resolved with #9115


Spi refactor

This PR supersedes #141 and #146.
This PR refactors the SPI API to remove the need to call open, close and chip_select functions directly. These are handled internally by the read/write/exchange functions.
It also implements 16-bit transactions.
With the new SPI C-API, using the SPI bus requires two steps:

Call SPI_configure() with an appropriate configuration struct.
Call SPI_exchange_byte or SPI_exchange_int.
SPI_exchange_* can be called repeatedly until the bus is reconfigured.

Note that the C-API does not provide functions to read or write more than a single byte or word at a time. This is because this is enough for most of the built-in SPI devices (oscilloscope PGAs and programmable power source). The SD-card needs the ability to write large blocks, but this is now implemented in sd_spi.c instead of being part of the general SPI C-API.
The new SPI C-API also uses boolean return codes for several functions, with true indicating successful execution and false indicating a problem.
The serial API is used thus:

Call SET_SPI_PARAMETERS, which takes a uint16_t corresponding to the SPI1CON1 register as its argument.
Call SEND/WRITE/READ_SPI8/SPI16_BURST

Unlike the C-API, the serial API only provides functions for reading or writing multiple bytes or words. This is because there is more overhead over the serial bus, so functions that only handle a single transaction at a time would be unsuitable. There is also no need to provide such functions in addition to the block functions, since those functions can be easily wrapped to create single transaction functions in the driver layer.
The serial API uses the FAILED acknowledge byte to indicate a problem, similar to the C-API's use to false.
Untested.

Additionally, this PR adds the macro V5_HW, enabled via a cmake option LEGACY_HARDWARE. This macro is used to enable/disable areas of code which differ between hardware versions.


Many file-type classes are not determinable by extension alone.

For example, GNU make by default uses a file called Makefile, and sometimes by convention, files with the .mk extension are used.
There are many other examples of this too, PKGBUILD recipes, CMakeList.txt files.
I submitted a pull request that adds the ability to search not just for extensions a while ago:
https://github.com/ggreer/the_silver_searcher/pull/619
Please give me some feedback on this.

Is it possible to get some feedback on this bug?


failed on amplify deployment

Before opening, please confirm:

[X] I have checked to see if my question is addressed in the FAQ.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

App Id
NEW_APP
AWS Region
us-east-1
Amplify Hosting feature
Deployments
Frontend framework
React
Next.js version
N/A
Next.js router
N/A
Describe the bug
I got failed while deploying my react app on both cli deployment and console deployment with github
"We are unable to process your request. Please reach out to your support representative."
Session Identifier: 5a9cd0f7-9a92-4247-85e8-173e62eec427
Expected behavior
Success on deployment or show me the details of the issue.
Reproduction steps

amplify init
Build Command:  yarn build
Start Command: yarn start
the access key of the profile is AKIA44FIG7U5Q26WAVP3

[personal_function]
aws_access_key_id=AKIA44FIG7U5Q26WAVP3

Build Settings
version: 1
frontend:
  phases:
    preBuild:
      commands:
        - yarn install
    build:
      commands:
        - yarn run build
  artifacts:
    baseDirectory: build
    files:
      - '**/*'
  cache:
    paths:
      - node_modules/**/*

Log output
The project is an empty react project
Additional information
The code repository is below, same as my local code,
git@github.com:guangyuxu/react-empty.git
And I got Error "App with id:<PHONE_NUMBER>55 not found" in below URL. But the auth looks good and the region is correct us-east-1
https://us-east-1.console.aws.amazon.com/amplify/home?region=us-east-1#/885116042555

Hi @guangyuxu 👋 , in order to further troubleshoot your issue please reach out to the AWS Support team: https://aws.amazon.com/support for additional assistance.


How to change size of an split area programmatically.

I want to resize an split area dynamically from typescript is there any way??

yes, check out the website, you have examples:
https://bertrandg.github.io/angular-split/
And the code is viewable here:
https://github.com/bertrandg/angular-split/tree/website-src

Actually i want to change size by px not %

You can't set it in pixel currently.

And now is it possible to set it in pixels ?


Fix zero division error reported by Dale

/opt/devel/pipeline/envs/deployment/lib/python3.6/site-packages/mnc/xengine_beamformer_control.py:321: RuntimeWarning: invalid value encountered in true_divide
cal = (1-flg)/norm_factors[iNCHAN_PIPELINE:(i+1)*NCHAN_PIPELINE,pol]
2024-10-08 14:12:05,760 - mnc.xengine_beamformer_control.Lwa352PipelineControl - ERROR - host lxdlwagpu01 (pipeline 1) failed to respond to etcd command!
2024-10-08 14:12:05,761 - mnc.xengine_beamformer_control - WARNING - Failed to command lxdlwagpu01 (pipeline 1)

I have not specifically tested the change, but it is a minor change anyway.

This looks ok, but probably worth a test. I'll install this to the development environment.


Edict looks like only has two option: 1 to 1, or average deliver. Is there a better way?

assume I want to send:
1-300 output: 100 UNCOMMONGOODS
301-500 output: 200 UNCOMMONGOODS
501-900 output: 600 UNCOMMONGOODS
then I should: (two options as I know)
1、put 3 transaction, each need only 1 edict but, each has 901 outputs, that's 3*901 size.
2、put 1 transaction, with 900 edicts:
{
id:840000:0
amount:100
output:1
}
...
{
id:840000:0
amount:600
output:900
}
which costs 900+901 size.
Just imagine another design:
{
id:840000:0
amount:100
output_new:300 // which means I send 100 to output 1 ~ 300
}
{
id:840000:0
amount:200
output_new:200 // which means I send 100 to output 301 ~ 301+200
}
{
id:840000:0
amount:600
output_new:400 // which means I send 100 to output 301+200 ~ 301+200+400
}
It uses only 3 edicts and 1 transaction, to make transfer minimal to 3+901 size.

I was wrong:
1、put 3 transaction, each need only 1 edict but, each has 901 outputs, that's 3901 size.
It should be:
1、put 3 transaction, each need only 1 edict but, each has 300 outputs, that's 3300 size.
So consider OP_RETURN only limit to 80 bytes, maybe the problem I said is not a big deal here.


Losing mod privileges doesn't remove (hide) moderation buttons

When you unmod yourself you can still see moderation buttons.

This is due to twitch not sending mod and unmod events properly (in irc)

Maybe there's a proper pubsub event? @pajlada

Not any documented one that I know of, no.
Only ways I know of doing this would be:
a) automatically call .mods every now and then (which sucks)
b) inspect any message that comes in that's from you (which would mean the moderation button only showing up if you type something in chat after being unmodded)
c) potentially do b) and also listen to error NOTICE/USERNOTICE messages that happen if you try to timeout someone but the timeout fails because you're not a mod?
the +o/-o MODE messages are really unreliable

This issue is out of scope of the Chatterino project.


WIP - Activities and distributed tracing

Figure out how to log deep links to diagnostics providers by default. cc @mkArtakMSFT \ @glennc \ @shirhatti

Closing. It's not clear what needs to be done here.


Version 1.3 replacement for $meteor.waitForUser()

The $meteor.waitForUser() is deprecated in versin 1.3 -  but I cannot find a Meteor’s API for this method.
If I use Meteor.user() it returns undefined, but if I wrap within a $meteor.waitForUser() it returns the users details.

If you look at the implementation you can see that this is because it's wrapped in an autorun.
There are 2 choices:

Simply copy that logic into your app
Create a package that does that and publish it for everyone to enjoy

If you choose option number 2, think if that package should be Angular Meteor specific or you create create something that the whole Meteor community can benefit from

@Urigo - this leaves me speechless - I am faced with hours and hours  of work changing and checking that my codes works in 1.3. To make major changes and to not provide complete documentation on how to make the changes is not right -
to reply "with look at the implementation"  is no help at at all - what are you taking about - where is the implementation?
It is bad enough having to makes these changes (I do not see any benefit I get from them) without having to hunt around to figure what to replace them with!

@JohnAReid I'm sorry, I mean, in 1.3 your old code still works so I can improve the docs and help you out.
What I meant in look at the implementation is this:
https://github.com/Urigo/angular-meteor/blob/master/packages/angular-meteor-data/modules/angular-meteor-user.js#L17-L28
As you can see, it's a reasonable code to write in your app without using a package.
I do get the benefit of using it as a prepared method, I just think it might be in a separate package.
I can create one and I probably will if no one will do that before me, I just think it's an easy opportunity for community people to contribute and get recognized.
Tomorrow I will add more docs on that matter, I would love to hear feedback on where and how would you want that to be

@JohnAReid from taking a quick look at the code  you can create it
this.waitForUser = function () {
var deferred = $q.defer();
if (!Meteor.loggingIn())
deferred.resolve(Meteor.user());
return deferred.promise;
};

this.waitForUser = function(){
      console.warn('[angular-meteor.waitForUser] Please note that this method is deprecated since 1.3.0 and will be removed in 1.4.0!');

      var deferred = $q.defer();

      $meteorUtils.autorun($rootScope, function(){
        if ( !Meteor.loggingIn() )
          deferred.resolve( Meteor.user() );
      });

      return deferred.promise;
    };

Thanks all - I think my real grip is documentation -  I expected waitForUser to be documented in the Meteor  documentation page and it was not!

I'm re-opening as I would love to think about a prepared solution, whether Angular specific or a general Meteor one

Added to the 1.3.1 milestone where we will bring back the functions from before, just in a separate package

@Urigo I could provide a PR for this, but what should happen with $meteorUtils?

+1
Love the leaner angular core but maintenance of old APIs through additional packages.
The 1.2 upgrade threatened to break my code but the angular-with-blaze saved me. This resolution of this issue similarly helps me to maintain my legacy code bases.
Break work @coreCommiters
—
Sent from mobile
On Sun, Dec 13, 2015 at 4:20 PM, Seba Kerckhof<EMAIL_ADDRESS>wrote:

@Urigo I could provide a PR for this, but what should happen with $meteorUtils?
Reply to this email directly or view it on GitHub:
https://github.com/Urigo/angular-meteor/issues/922#issuecomment-164299339

@Urigo what about:
-Split of meteorUtils to a separate package (e.g. angular-meteor-utils), remove deprecated messages
-Split of meteorCollection/meteorObject to a separate package which depends on the angular-meteor-utils package (e.g. angular-meteor-data-legacy), leave deprecated messages
-Split of meteorAccounts to a separate package which depends on the angular-meteor-utils package (e.g. angular-meteor-accounts), remove deprecated messages
-Create an umbrella package to imply 3 packages above (e.g. angular-meteor-legacy)
-Have angular-meteor-data depend on angular-meteor-legacy until 1.4
That way nothing changes for current 1.3 users, and for 1.4 people can choose which legacy parts to include.

@sebakerckhof that a good idea.
Hopefully by the end of the day we will have a separate accounts package and the rest later this week.
I will also love some help in that and maybe you can create the rest of the packages and pull request the angular to direct to that?

Okay, i'll look into that.

This worked for me until something official comes out.  Inject MeteorUserService and change $meteor to MeteorUserService for the promise returning methods.  Aside from these three the regular Meteor methods sufficed.
No warranty expressed or implied...
(function() {
    "use strict";

    angular.module('app').factory('MeteorUserService', ['$q', MeteorUserService]);

    function MeteorUserService($q) {

        return {
            requireValidUser: requireValidUser,
            waitForUser: waitForUser,
            requireUser: requireUser
        };

        function requireUser() {
            var deferred = $q.defer();

            Meteor.autorun(function(stoppable) {
                if (!Meteor.loggingIn()) {
                    if (Meteor.user() === null) {
                        stoppable.stop();
                        deferred.reject("AUTH_REQUIRED");
                    } else {
                        stoppable.stop();
                        deferred.resolve(Meteor.user());
                    }
                }
            });

            return deferred.promise;
        }

        function requireValidUser(validatorFn) {
            return requireUser().then(function(user) {
                var valid = validatorFn(user);

                if (valid === true)
                    return user;
                else if (typeof valid === "string")
                    return $q.reject(valid);
                else
                    return $q.reject("FORBIDDEN");
            });
        }

        //I see trouble... there is no timeout
        function waitForUser() {
            var deferred = $q.defer();

            Meteor.autorun(function(stoppable) {
                if (!Meteor.loggingIn()) {
                    console.log("stopping");
                    stoppable.stop();
                    deferred.resolve(Meteor.user());
                }
            });

            return deferred.promise;
        }

    }
})();

With the new 1.3.2 release you can use the new angular-meteor-auth package.
Add it to your project, here are the docs: http://www.angular-meteor.com/api/1.3.2/auth


[Bug][Manager] The configuration process cannot be triggered when a new sink is created under a successfully configured group

What happened
The configuration process cannot be triggered when a new sink is created under a successfully configured group.
What you expected to happen
Create a new sink under the successfully configured group.
The sink can successfully trigger the configuration process
How to reproduce
Create a new group and configure it successfully and create a new data store under the current group.
Environment
No response
InLong version
master
InLong Component
InLong Manager
Are you willing to submit PR?

[X] Yes, I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I will deal with this problem！


test: refactor tests

test: make table-drive tests
test: add test case for no option
test: extract wanted data to files

Codecov Report

Merging #5 (75c0ed3) into main (192de4a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #5   +/-   ##
=======================================
  Coverage   78.26%   78.26%
=======================================
  Files           1        1
  Lines          92       92
=======================================
  Hits           72       72
  Misses         13       13
  Partials        7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 192de4a...75c0ed3. Read the comment docs.

:tada: This PR is included in version 0.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


KryptonContextMenu losing edits

Hi folks, I'm having problems editing KryptonContextMenus in VS 2015. I've created an empty form, extending KryptonForm, and added a KryptonContextMenu to it. When I edit the Items property the Properties panel, I get the editor dialog shown, as expected. But when I add items to the menu, the property panel on the dialog doesn't populate, and when I OK the dialog, my changes aren't saved, so my context menus are always empty.

Am I missing something with context menus? Is there another way to edit them?

I've attached the CS files for my form, in case that helps. I've looked in the designer file, and can see my three menu items being added to the "items" object, but can't see the "items" being added to the context menu itself...
KForm2.cs.txt
KForm2.Designer.cs.txt


Rebuild image/file widget with Uppy

Is your feature request related to a problem? Please describe.
File uploads management should be handled by a dedicated tool, to bring good features and more resiliency.
Uppy seems appropriate as it is made to be integrated and is well maintained.
Describe the solution you'd like
As described in #2243, using a dedicated library to manage uploads would solve a bunch of main issues about file or images upload.
I think Uppy is a better candidate than Filepond, as its code is already divided in modules, so we could easily use @uppy/core with Netlify CMS UI.
Additional context
You can find screenshots and documentation on the Uppy website.

@owenhoskins already gave a chance to Uppy in #1032, but this was discontinued, any idea why?

Hi @vnourdin it looks like it hit a wall because some limitations we had with uploading and deleting multiple files in a single commit.
I believe those limitations don't exist anymore as our backend implementations now support that.
It would be great to pick up that work and open a PR for it.

Running into this "issue" as well. The feature would really be nice to have, as it is really time consuming to upload a bunch of images. Same goes for the selection for example, of the list widget. You need to add each image one by one

Allowing the ability to add multiple images at once would really help supercharge the ability to build shippable products on Netlify CMS, as currently I am more reluctant to provide a client with a product that only allows them to add images one by one.

Hi @patagoniapy, agreed. It would be great to have this functionality if someone is willing to submit a PR for it.

Hi all 👋  I've made an attempt to add an external media library based on Uppy.
You can see the branch here and the deploy preview.
Please note I tested that branch only with a local backend.
Unfortunately it doesn't look like Uppy is a good candidate yet. It's an amazing file uploader, but lacking features required to be a complete media library.
For example, loading existing files is not officially supported. I was able to do it based on this issue, but it adds existing files as already uploaded ones instead of being an integral part of a media library.
Also, it seems nested directories are not supported.
See also https://github.com/transloadit/uppy/issues/450.
I'm closing the issue, and will try to look at https://github.com/netlify/netlify-cms/issues/2243 as well.
If you have suggestions on making Uppy suitable for the CMS, please comment on the issue and we can re-open it.


supercontextmenu not IE  compatible

Hello, I was testing the code in IE Version 11.0.9000.18861 and the contextmenu is not shown when right clicking. Open demopage in IE and you will see the error https://www.jqueryscript.net/demo/Context-Menu-Plugin-jQuery-superContextMenu/
In my own application the contextmenu appears but the height of the element is too small. Looks like is missing the height. Pls can you check the compatibility for IE THX

Internet explorer is a bit problematic with flex boxes, but it is fixed now.

Thanks @pwnedgod


downgrade to 22.05

Stable branch hits less bugs than unstable.
Open to discussion

Hello, 22.05 is already outdated and no one brang the topic up for discussion since then.
IMO we can just keep the regular file with version declaration somewhere and before building .iso users can always just modify those few lines there and there to their liking, including NixOS's version which their RedNixOS will be based on.
Closing the PR, thanks for your contribution and waiting for more


fmridenoise.interfaces.bids.MissingFile: missing file(s)

When trying to run from docker the following errors comes up:

PS C:\Users\45027900> docker run -it --rm -v D:\Andrea\fov\BIDS:/BIDS -v D:\Andrea\fov\BIDS\derivatives\fmriprep:/derivatives fmridenoise compare /BIDS -d  /derivatives --MultiProc -t exp
/usr/local/lib/python3.8/dist-packages/numpy-1.16.4-py3.8-linux-x86_64.egg/numpy/ma/core.py:4466: SyntaxWarning: "is" with a literal. Did you mean "=="?
if self.shape is ():
201219-12:14:44,624 nipype.workflow INFO:
[Node] Setting-up "BidsValidate" in "/tmp/tmp287wv_of/BidsValidate".
201219-12:14:44,627 nipype.workflow INFO:
[Node] Running "BidsValidate" ("fmridenoise.interfaces.bids.BIDSValidate")
/usr/local/lib/python3.8/dist-packages/pybids-0.12.4-py3.8.egg/bids/layout/validation.py:46: UserWarning: The ability to pass arguments to BIDSLayout that control indexing is likely to be removed in future; possibly as early as PyBIDS 0.14. This includes the config_filename, ignore, force_index, and index_metadata arguments. The recommended usage pattern is to initialize a new BIDSLayoutIndexer with these arguments, and pass it to the BIDSLayout via the indexer argument.
warnings.warn("The ability to pass arguments to BIDSLayout that control "
201219-12:14:55,358 nipype.workflow WARNING:
Storing result file without outputs
201219-12:14:55,358 nipype.workflow WARNING:
[Node] Error on "BidsValidate" (/tmp/tmp287wv_of/BidsValidate)
Traceback (most recent call last):
File "/usr/lib/python3.8/runpy.py", line 194, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/usr/lib/python3.8/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/fmridenoise-src/fmridenoise/main.py", line 236, in
main()
File "/fmridenoise-src/fmridenoise/main.py", line 228, in main
compare(args)
File "/fmridenoise-src/fmridenoise/main.py", line 177, in compare
workflow = init_fmridenoise_wf(input_dir,
File "/fmridenoise-src/fmridenoise/workflows/base.py", line 455, in init_fmridenoise_wf
result = bids_validate.run()
File "/usr/local/lib/python3.8/dist-packages/nipype-1.6.0-py3.8.egg/nipype/pipeline/engine/nodes.py", line 516, in run
result = self._run_interface(execute=True)
File "/usr/local/lib/python3.8/dist-packages/nipype-1.6.0-py3.8.egg/nipype/pipeline/engine/nodes.py", line 635, in _run_interface
return self._run_command(execute)
File "/usr/local/lib/python3.8/dist-packages/nipype-1.6.0-py3.8.egg/nipype/pipeline/engine/nodes.py", line 741, in _run_command
result = self._interface.run(cwd=outdir)
File "/usr/local/lib/python3.8/dist-packages/nipype-1.6.0-py3.8.egg/nipype/interfaces/base/core.py", line 434, in run
runtime = self._run_interface(runtime)
File "/fmridenoise-src/fmridenoise/interfaces/bids.py", line 405, in _run_interface
entities_files, (tasks, sessions, subjects, runs) = BIDSValidate.validate_files(
File "/fmridenoise-src/fmridenoise/interfaces/bids.py", line 359, in validate_files
raise MissingFile(
fmridenoise.interfaces.bids.MissingFile: missing file(s) for {'subject': '05', 'task': 'exp', 'run': 5, 'extension': 'tsv', 'suffix': 'timeseries', 'desc': 'confounds'} (check if you are using AROMA pipelines)

this subject didn't have any run 5, and this is tru for other subjects. how can i solve this?
the same happens if i remove -t exp : i have another task ('loc') with only one run, but the bids validator is looking for 5 runs (it's wrongly assuming that the number of runs would be the same for loc and exp, maybe?)

It's 'wrongly' (I will call it 'as creators intended') assuming that if you provide e.g --run 1 2 3 4 5 as input it will look for data in all combinations of five runs, all task, all sessions and all subjects provided at input.
You may consider this as a flaw because it makes our tool not flexible enough.
There is idea for future release to make fmridenoise work with 'incomplete' (to some degree) datasets but this requires major rewiring of dataflow (basically splitting that into 4 separate workflows run one after other based on data aggregation joins).
I cannot estimate when flexibility will be introduced... we got limited time to develop fmridenoise.

Could a workaround be to run the tool on the two experiment separately to solve the problem with the two tasks, and to create a copy of some other run for the missing runs?
Get Outlook for iOShttps://aka.ms/o0ukef

From: Siegfried Wagner<EMAIL_ADDRESS>Sent: Sunday, December 20, 2020 12:05:29 AM
To: compneuro-ncu/fmridenoise<EMAIL_ADDRESS>Cc: Andrea Costantino<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [compneuro-ncu/fmridenoise] fmridenoise.interfaces.bids.MissingFile: missing file(s) (#77)
It's 'wrongly' (I will call it 'as creators intended') assuming that if you provide e.g --run 1 2 3 4 5 as input it will look for data in all combinations of five runs, all task, all sessions and all subjects provided at input.
You may consider this as a flaw because it makes our tool not flexible enough.
There is idea for future release to make fmridenoise work with 'incomplete' (to some degree) datasets but this requires major rewiring of dataflow (basically splitting that into 4 separate workflows run one after other based on data aggregation joins).
I cannot estimate when flexibility will be introduced... we got limited time to develop fmridenoise.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/compneuro-ncu/fmridenoise/issues/77#issuecomment-748472333, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOCXNCNBZXSF2Z4OPVVHHSLSVSQJTANCNFSM4VCIFSAQ.

I was thinking about it while you responded - there are no comparisons between task, sessions and runs (only between pipelines on groups of subjects), so you can run fmridenoise separately for each task, session and run combination (or any valid subset of those). Only disadvantage will be lots of separate reports instead of one.

Awesome. I’ll try that.
Thanks!
Get Outlook for iOShttps://aka.ms/o0ukef

From: Siegfried Wagner<EMAIL_ADDRESS>Sent: Sunday, December 20, 2020 12:28:05 AM
To: compneuro-ncu/fmridenoise<EMAIL_ADDRESS>Cc: Andrea Costantino<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [compneuro-ncu/fmridenoise] fmridenoise.interfaces.bids.MissingFile: missing file(s) (#77)
I was thinking about it while you responded - there are no comparisons between task, sessions and runs (only between pipelines on groups of subjects), so you can run fmridenoise separately for each task, session and run combination (or any valid subset of those). Only disadvantage will be lots of separate reports instead of one.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/compneuro-ncu/fmridenoise/issues/77#issuecomment-748474945, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOCXNCP5JZRWRAUD4PPJCWLSVSS6LANCNFSM4VCIFSAQ.

So, I tried to run fmridenoise on the loc task only, but the tool is still looking for loc run 2 (that does not exist):

C:\Users\45027900> docker run -it --rm -v D:\Andrea\fov\BIDS:/BIDS -v D:\Andrea\fov\BIDS\derivatives\fmriprep:/derivatives fmridenoise compare /BIDS -d  /derivatives --MultiProc -t loc
/usr/local/lib/python3.8/dist-packages/numpy-1.16.4-py3.8-linux-x86_64.egg/numpy/ma/core.py:4466: SyntaxWarning: "is" with a literal. Did you mean "=="?
if self.shape is ():
201220-00:53:35,168 nipype.workflow INFO:
[Node] Setting-up "BidsValidate" in "/tmp/tmpbbownsuf/BidsValidate".
201220-00:53:35,171 nipype.workflow INFO:
[Node] Running "BidsValidate" ("fmridenoise.interfaces.bids.BIDSValidate")
/usr/local/lib/python3.8/dist-packages/pybids-0.12.4-py3.8.egg/bids/layout/validation.py:46: UserWarning: The ability to pass arguments to BIDSLayout that control indexing is likely to be removed in future; possibly as early as PyBIDS 0.14. This includes the config_filename, ignore, force_index, and index_metadata arguments. The recommended usage pattern is to initialize a new BIDSLayoutIndexer with these arguments, and pass it to the BIDSLayout via the indexer argument.
warnings.warn("The ability to pass arguments to BIDSLayout that control "
201220-00:54:06,428 nipype.workflow WARNING:
Storing result file without outputs
201220-00:54:06,429 nipype.workflow WARNING:
[Node] Error on "BidsValidate" (/tmp/tmpbbownsuf/BidsValidate)
Traceback (most recent call last):
File "/usr/lib/python3.8/runpy.py", line 194, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/usr/lib/python3.8/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/fmridenoise-src/fmridenoise/main.py", line 236, in
main()
File "/fmridenoise-src/fmridenoise/main.py", line 228, in main
compare(args)
File "/fmridenoise-src/fmridenoise/main.py", line 177, in compare
workflow = init_fmridenoise_wf(input_dir,
File "/fmridenoise-src/fmridenoise/workflows/base.py", line 455, in init_fmridenoise_wf
result = bids_validate.run()
File "/usr/local/lib/python3.8/dist-packages/nipype-1.6.0-py3.8.egg/nipype/pipeline/engine/nodes.py", line 516, in run
result = self._run_interface(execute=True)
File "/usr/local/lib/python3.8/dist-packages/nipype-1.6.0-py3.8.egg/nipype/pipeline/engine/nodes.py", line 635, in _run_interface
return self._run_command(execute)
File "/usr/local/lib/python3.8/dist-packages/nipype-1.6.0-py3.8.egg/nipype/pipeline/engine/nodes.py", line 741, in _run_command
result = self._interface.run(cwd=outdir)
File "/usr/local/lib/python3.8/dist-packages/nipype-1.6.0-py3.8.egg/nipype/interfaces/base/core.py", line 434, in run
runtime = self._run_interface(runtime)
File "/fmridenoise-src/fmridenoise/interfaces/bids.py", line 405, in _run_interface
entities_files, (tasks, sessions, subjects, runs) = BIDSValidate.validate_files(
File "/fmridenoise-src/fmridenoise/interfaces/bids.py", line 359, in validate_files
raise MissingFile(
fmridenoise.interfaces.bids.MissingFile: missing file(s) for {'subject': '02', 'task': 'loc', 'run': 2, 'extension': 'tsv', 'suffix': 'timeseries', 'desc': 'confounds'} (check if you are using AROMA pipelines)

how can I tell to look just for run 1? and why is looking for run 2 if only task 'exp' has more than 1 run?

in fmridenoise compare --help you got all possible args to use (there are
more than are currently described in readme).
You can manually specify all runs, pipelines, tasks, sessions and subjects.
In case of runs it will be --run 1.
Especially check pipelines
https://github.com/compneuro-ncu/fmridenoise/tree/dev/fmridenoise/pipelines
because I am not sure if you have aroma files in your dataset (based on a
dummy you sent me yesterday).
Sorry for all the hassle. Docs is the last thing we have to finish before
merging to master and they are not finished yet.
niedz., 20 gru 2020 o 02:00 Andrea Costantino<EMAIL_ADDRESS>napisał(a):

So, I tried to run fmridenoise on the loc task only, but the tool is still
looking for loc run 2 (that does not exist):
C:\Users\45027900> docker run -it --rm -v D:\Andrea\fov\BIDS:/BIDS -v
D:\Andrea\fov\BIDS\derivatives\fmriprep:/derivatives fmridenoise compare
/BIDS -d /derivatives --MultiProc -t loc
/usr/local/lib/python3.8/dist-packages/numpy-1.16.4-py3.8-linux-x86_64.egg/numpy/ma/core.py:4466:
SyntaxWarning: "is" with a literal. Did you mean "=="?
if self.shape is ():
201220-00:53:35,168 nipype.workflow INFO:
[Node] Setting-up "BidsValidate" in "/tmp/tmpbbownsuf/BidsValidate".
201220-00:53:35,171 nipype.workflow INFO:
[Node] Running "BidsValidate" ("fmridenoise.interfaces.bids.BIDSValidate")
/usr/local/lib/python3.8/dist-packages/pybids-0.12.4-py3.8.egg/bids/layout/validation.py:46:
UserWarning: The ability to pass arguments to BIDSLayout that control
indexing is likely to be removed in future; possibly as early as PyBIDS
0.14. This includes the config_filename, ignore, force_index, and
index_metadata arguments. The recommended usage pattern is to initialize
a new BIDSLayoutIndexer with these arguments, and pass it to the BIDSLayout
via the indexer argument.
warnings.warn("The ability to pass arguments to BIDSLayout that control "
201220-00:54:06,428 nipype.workflow WARNING:
Storing result file without outputs
201220-00:54:06,429 nipype.workflow WARNING:
[Node] Error on "BidsValidate" (/tmp/tmpbbownsuf/BidsValidate)
Traceback (most recent call last):
File "/usr/lib/python3.8/runpy.py", line 194, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/usr/lib/python3.8/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/fmridenoise-src/fmridenoise/main.py", line 236, in
main()
File "/fmridenoise-src/fmridenoise/main.py", line 228, in main
compare(args)
File "/fmridenoise-src/fmridenoise/main.py", line 177, in compare
workflow = init_fmridenoise_wf(input_dir,
File "/fmridenoise-src/fmridenoise/workflows/base.py", line 455, in
init_fmridenoise_wf
result = bids_validate.run()
File
"/usr/local/lib/python3.8/dist-packages/nipype-1.6.0-py3.8.egg/nipype/pipeline/engine/nodes.py",
line 516, in run
result = self._run_interface(execute=True)
File
"/usr/local/lib/python3.8/dist-packages/nipype-1.6.0-py3.8.egg/nipype/pipeline/engine/nodes.py",
line 635, in _run_interface
return self._run_command(execute)
File
"/usr/local/lib/python3.8/dist-packages/nipype-1.6.0-py3.8.egg/nipype/pipeline/engine/nodes.py",
line 741, in _run_command
result = self._interface.run(cwd=outdir)
File
"/usr/local/lib/python3.8/dist-packages/nipype-1.6.0-py3.8.egg/nipype/interfaces/base/core.py",
line 434, in run
runtime = self._run_interface(runtime)
File "/fmridenoise-src/fmridenoise/interfaces/bids.py", line 405, in
_run_interface
entities_files, (tasks, sessions, subjects, runs) =
BIDSValidate.validate_files(
File "/fmridenoise-src/fmridenoise/interfaces/bids.py", line 359, in
validate_files
raise MissingFile(
fmridenoise.interfaces.bids.MissingFile: missing file(s) for {'subject':
'02', 'task': 'loc', 'run': 2, 'extension': 'tsv', 'suffix': 'timeseries',
'desc': 'confounds'} (check if you are using AROMA pipelines)
how can I tell to look just for run 1? and why is looking for run 2 if
only task 'exp' has more than 1 run?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/compneuro-ncu/fmridenoise/issues/77#issuecomment-748546938,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG2YJAYR6Z7I2DT27VMWNGLSVVEEBANCNFSM4VCIFSAQ
.

Thanks for your help. I will try and get back to you. In the meantime I got another problem, but I will open a separate issue for that.
Just a note about the bids selector and the AROMA files: I downloaded and built the new dev code on docker, but when I run fmridenoise compare it looks like (as you can see from the error above) it is looking for files with the AROMA correction, but I never specified that AROMA was applied.
My understanding is that fmridenoise should look for AROMA files only if speficied with the aroma flag in command line. In my case I didn't, so I suppose that the error comes up for something in the code that forces looking for AROMA files. I made some changes in the bids.py (I set True for the no_aroma boolean, and False for the aroma boolean) file, and these changes appear to solve the problem.

There are no aroma flags now. It looks for aroma files when there are
pipelines that process aroma files (as I said, I have to update docs....)
niedz., 20 gru 2020 o 08:45 Andrea Costantino<EMAIL_ADDRESS>napisał(a):

Thanks for your help. I will try and get back to you. In the meantime I
got another problem, but I will open a separate issue for that.
Just a note about the bids selector and the AROMA files: I downloaded and
built the new dev code on docker, but when I run fmridenoise compare it
looks like (as you can see from the error above) it is looking for files
with the AROMA correction, but I never specified that AROMA was applied.
My understanding is that fmridenoise should look for AROMA files only if
speficied with the aroma flag in command line. In my case I didn't, so I
suppose that the error comes up for something in the code that forces
looking for AROMA files. I made some changes in the bids.py (I set True for
the no_aroma boolean, and False for the aroma boolean) file, and these
changes appear to solve the problem.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/compneuro-ncu/fmridenoise/issues/77#issuecomment-748575013,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG2YJAYXZDVEVVXCW2PXLLLSVWTTHANCNFSM4VCIFSAQ
.

I am sorry, I am not sure I got you.
From the usage in the docs, I read that

--use-aroma             Run denoising pipelines based on ICA-AROMA, default False

are you saying that this is not up to date? if that's the case, how do I specify that I didn't use aroma (since it seems it is looking for aroma files)?
thanks

As I said, you have to pick pipelines without aroma:
--pipelines
pipeline-24HMP_8Phys_SpikeReg
pipeline-Null
pipeline-24HMP_8Phys_SpikeReg_4GS
pipeline-24HMP_aCompCor_SpikeReg
pipeline-24HMP_aCompCor_SpikeReg_4GS
The 'auto discover' option of fmridenoise - running fmrideonoise with zero
extra flags, is very optimistic in execution - program looks for all
possible subjects, runs, tasks and sessions that are present in a dataset
and tries to apply all pipelines to it. Based on your experience I think
about changing it...
niedz., 20 gru 2020 o 08:57 Andrea Costantino<EMAIL_ADDRESS>napisał(a):

I am sorry, I am not sure I got you.
From the usage in the docs, I read that
--use-aroma Run denoising pipelines based on ICA-AROMA, default False
are you saying that this is not up to date? if that's the case, how do I
specify that I didn't use aroma (since it seems it is looking for aroma
files)?
thanks
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/compneuro-ncu/fmridenoise/issues/77#issuecomment-748575907,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG2YJA2JC5FWGB7UEUGDTNTSVWU55ANCNFSM4VCIFSAQ
.

Got it. I will try!
thanks


Support Uber H3 in Sedona?

Expected behavior
Actual behavior
Steps to reproduce the problem
Settings
Sedona version = ?
Apache Spark version = ?
Apache Flink version = ?
API type = Scala, Java, Python?
Scala version = 2.11, 2.12, 2.13?
JRE version = 1.8, 1.11?
Python version = ?
Environment = Standalone, AWS EC2, EMR, Azure, Databricks?

@MoSarwat Can I pick this up ? We can use https://github.com/uber/h3-java as it is Apache-2.0 license. WDYT ?

@Imbruced Hi Pawel, @zongsizhang has been working on several Sedona H3 functions for a while. He will commit a PR in the next few days. But there are more to do with those H3 functions and you are welcome to help with that 😁


enlarge append recycle log threshold

This PR change the recycle log threshold from (purge_threshold / target_file_size) + 2 to (purge_threshold / target_file_size)*1.5 to avoid repeatedly creating and purging log files when tikv's log compaction has non-trivial latency.
Also changes the prefill_limit's semantic meaning, after this change, it will means the total log files threshold instead of recycle files threshold.

@LykxSassinator PTAL thanks~


⚠ Bofrost.at has degraded performance

In 33b6743, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1197 ms

Resolved: Bofrost.at performance has improved in 9d6c66e after 311 days, 9 hours, 9 minutes.


Using ngrok with Docker compose -- clarify need for host.docker.internal in ngrok.yml on Mac

Need to update "Using ngrok with Docker Compose" to clarify that the defined tunnels in agent config needs to also use the host.docker.internal hostname for upstream.
https://ngrok.com/docs/using-ngrok-with/docker/
In the "Using ngrok with Docker", we do call out you have to use host.docker.internal for MacOS
This also applies to the upstream addr: for the ngrok.yml when following the Docker Compose instructions on mac.

Note: for MacOS or Windows users, the --net=host option will not work. You will need to use the special url host.docker.internal as described in the Docker networking documentation.

Example:
tunnels:
  test:
    proto: http
    addr: http://host.docker.internal:80

This will allow docker to start, but returns ERR_NGROK_8012 (upstream error) when accessing the endpoint.
tunnels:
  test:
    proto: http
    addr: 80

Title says Mac, but this applies to windows too.


Replace Mutex with RWMutex

Please provide a description of this PR:
Replace Mutex with  RWMutex.

It's a mock for testing.. performance doesn't matter?


adding support for china regions

Adding support for China regions.
Use regional STS for worker ami by using new aws-iam-authenticator with '--region' flag.

WARNING: our current released binaries in amazon-eks bucket won't work with this change, we'll release new set of binaries which contains new aws-iam-authenticator which supports the --region parameter. Please don't build your own AMI from this commit(always use specific release of this repo)

Does this mean that the managed node group has been hitting the global sts endpoint the whole time? If so, anytime line as to when a new ami will be available to fix this?

@davidygs yes, it depends on aws-sdk-go's default setting. some region hits regional endpoint.
This change will force all region to use it's regional endpoint


GetReferences returns null although the project does reference other assemblies

Buildalyzer is a really nice OSS project, by the way. I'm just getting started with it, and am having a problem. Thanks in advance!
I've got a .NET Core 2.1 preview project whose .csproj looks like this:
<Project Sdk="Microsoft.NET.Sdk.Web">
  <PropertyGroup>
    <TargetFramework>netcoreapp2.0</TargetFramework>
  </PropertyGroup>
  <ItemGroup>
    <Folder Include="wwwroot\" />
  </ItemGroup>
  <ItemGroup>
    <PackageReference Include="Microsoft.AspNetCore.All" Version="2.0.3" />
  </ItemGroup>
  <ItemGroup>
    <PackageReference Include="FluentCommandLineParser" Version="1.4.3" />
    <PackageReference Include="Microsoft.Extensions.Logging.Log4Net.AspNetCore" Version="2.0.3" />
  </ItemGroup>
  <ItemGroup>
    <DotNetCliToolReference Include="Microsoft.VisualStudio.Web.CodeGeneration.Tools" Version="2.0.1" />
  </ItemGroup>
</Project>

My code to display references looks like this:
                AnalyzerManager manager = new AnalyzerManager();
                Buildalyzer.ProjectAnalyzer analyzer = manager.GetProject(projectFilename);
                Project proj = analyzer.Load();
                IEnumerable<string> references = analyzer.GetReferences();
                if (references == null)
                {
                    Console.WriteLine("No references found. Quitting.");
                    return;
                }

                foreach (var r in references)
                    Console.WriteLine(r);

It always returns null for references. Is this not supported for .NET Core 2.* yet?
Bob

Thanks for the report. Buildalyzer should be working under all .NET Core 2.x scenarios except preview SDKs. I'm working on the problem with previews, but as far as I can tell it should only appear on systems at runtime when a preview SDK is installed. Does this describe your situation? Typically this failure exhibits itself as compilation failures which can be seen in the Buildalyzer log output - are you able to confirm if you see any errors in the log (you can pass in a logger to Buildalyzer or grab the string log)?

I am using .NET Core 2.1 preview with the SDKs that come with it. For some reason, when I try to see the log output in a StringWriter (see below) I don't get anything. Even when I write it out in a finally clause.
            StringBuilder sb = new StringBuilder();
            StringWriter writer = new StringWriter(sb);
            AnalyzerManagerOptions options = new AnalyzerManagerOptions();
            options.LogWriter = writer;

Buildalyzer 1.0.0 was released to NuGet last night. Can you please try it out when you get the chance and let me know the status of this issue?
FYI - the Buildalyzer 1.0.0 API has changed significantly. Revised documentation is forthcoming, but I wanted to get the release out there ASAP. Hopefully you'll be able to figure out the differences, but if not the source code of the tests is a good place to look or wait until better docs are out next week.

@daveaglick I ran it again using Buildalyzer 1.0.0 and it worked! My only code change was from
IEnumerable<string> references = analyzer.GetReferences();

to
IEnumerable<string> references = analyzer.Build().GetReferences();

Note that I also tried
IEnumerable<string> references = analyzer.Build().GetProjectReferences();

but that returned an empty collection.

Great! I'll go ahead and close this then - feel free to open a new issue if you have any other problems.


bug: ion-input autofill does not work when input is nested within other Ionic components

Bug Report
Ionic Version:

[x] 4.x
Current behavior:

When attempting to use the username/password autofill prompt provided by the operating system (like iOS with Keychain or 1Password), if an ion-input element is nested within another Ionic component (like ion-item or ion-row), the autofill capability will not be provided to the user.
Expected behavior:

<ion-input> components should allow for autofilling regardless of whether or not they are nested (within reason) in other Ionic components.
Related code:

Repo: https://github.com/bryplano/UsernameRepro
Steps to reproduce:

See README.md on the included sample repository.
Short version:

Create an application that places two ion-input components - one for a username and one for a password - onto a single page app.
Run the app on an iOS device
Try to autofill the fields using a username/password autofill capability or app (iOS Keychain, 1Password, LastPass, etc.) by tapping on the username field and attempting to autofill via the keyboard shortcut
The Issue: Notice that if the ion-input components are nested as part of an ion-grid or an ion-list in some manner, the ion-input for username will not allow the user to autofill a value. Only the ion-input for password will autofill properly.

Other information:

Ionic info:

Ionic:

   Ionic CLI                     : 5.2.8
   Ionic Framework               : @ionic/angular 4.9.1
   @angular-devkit/build-angular : 0.801.3
   @angular-devkit/schematics    : 8.1.3
   @angular/cli                  : 8.1.3
   @ionic/angular-toolkit        : 2.0.0

Capacitor:

   Capacitor CLI   : 1.2.1
   @capacitor/core : 1.2.1

Utility:

   cordova-res : 0.6.0
   native-run  : 0.2.8

System:

   NodeJS : v10.16.3
   npm    : 6.9.0
   OS     : macOS Mojave

Did you find any solution for this?

I can confirm this.

It works in Safari on a Mac as expected (with Keychain)
On an iPhone, the input for the username doesn't even show the typical autofill button and is quite flaky. See screenshot below for more info. Tested on an iPhone XS Max with iOS 13.1.3

Update: When the Stencil app is loaded as a web app on a device in Safari, it actually works correctly. Somehow, the bug seems to happen when the app is run as a Capacitor app.

Update2: I tried to run a test app in a different kind of Webview environment. It's a simple wrapper app around the default iOS webview. The problem exists here too. So I guess it doesn't have anything to do with Capacitor, but could be a bug in the iOS webview?! Very weird...

Update3: I ran more experients (some attributes omitted for brevity):
Credentials autofill works for both fields in this case:
    <ion-list>

            <ion-label />
            <ion-input name="email" />

            <ion-label />
            <ion-input name="password" type="password" />

    </ion-list>

As soon as one of the divs is replaced by ion-item, the credentials autofill doesn't work for the email field. Even if the email field remains in a div.
However, if the divs are replaced by ion-card for example, autofill works again!
There seems to be something special about ion-item in a WKWebView environment (because it works without problems in iOS Safari).

FYI there is a Webkit bug out for this: https://bugs.webkit.org/show_bug.cgi?id=203299
Will have to wait for an Apple fix.

@bryplano Good find, thanks for pointing this out. In the meantime, I just redesign my login form to use ion-card as suggested above. This works pretty well. I guess this issue can be closed then.

No problem @cmaas! :)
Workaround: For folks who come across this issue, workarounds include un-nesting the ion-input, putting it in a div rather than nesting it beneath other ion- components or using another component (ion-card was suggested above).
Solution: Will need to be provided by Apple - Webkit bug is here: https://bugs.webkit.org/show_bug.cgi?id=203299

@bryplano I also opened an issue at the capacitor repo, because I thought it was related to it. I think it can be closed too: https://github.com/ionic-team/capacitor/issues/2211
(And I think it helps to have as few open issues as possible for trust reasons ;))


[0.3.6] brightness, sleepmode and alert screens not working

Hi,
I updated the node and now I see the following:

brightness adjustment does not work, I think it stays at the default brightness level.
when I inject sleepmode_on, the it does not go dark. It just stops and shows a still image (or at least it does not go to the next screen). In continues when I inject sleepmode_off.
My alertscreen, which scrolls a text, sometimes freezes. Sometimes it goes blank but a few pixels of the text stay on.

I restarted node-red, rebooted the pi and re-deployd the whole workspace.... no luck.

Hi,
I updated the node and now I see the following:

brightness adjustment does not work, I think it stays at the default brightness level.
when I inject sleepmode_on, the it does not go dark. It just stops and shows a still image (or at least it does not go to the next screen). In continues when I inject sleepmode_off.

Hi the issues are fixed in the next version I am about to release.

My alertscreen, which scrolls a text, sometimes freezes. Sometimes it goes blank but a few pixels of the text stay on.

This indicates that your PixelIt hangs, because the Node-Red part only generates a JSON which the PixelIt interprets and processes.
A too weak power supply or a missing capacitor could be the problem.

Hi,
thanks! I just figured out that the blank screen with the pixels on it was the result of a long string with html in it. It was generated by a weather warning flow. The idea was to output a warning as scrolling text, which never showed up / worked before.

Hi, I updated to 0.3.7. Brightness and sleep works fine again, scrolling works wenn set to "auto". Thanks for fixing it!
Scrolling does not work when set to "on", it displays a static text then. I am fine with the auto setting :)


Issue with half-supported native implementation

Some browser older versions include basic support for URLSearchParams but lack advanced features such as constructor USVString or init object support.
e.g. in Firefox v52 record as init object is not supported, but there is a native URLSearchParams constructor. This results in the polyfill not being used, but also the native implementation not working as intended.

I see, this looks like a duplicate of this one then: https://github.com/WebReflection/url-search-params/issues/28
would you be happy with this polyfill taking over/replacing global constructor in those cases?

Indeed it seems duplicate of #28 but I was not certain if that was the only problem with that issue.
I believe this would be the only solution in those cases, if they can be distinguished (not replacing native implementation on all cases).


Reconcile main and updates for the new GEOSadas-5_27_1_p2 tag coming to Git

The GEOSadas is immanently releasing the first Git tag as the transition to Git. We have created a branch with updates from CVS relative to the initial release of the GMAO_Shared repository (back when the reflected the identical CVS state).  I've tried merging the release/cvs/GEOSadas-5_27_1_p2 branch where these changes have been accumulated into main to see what issues we might have as part of my ongoing tests to see what is needed to advance the GEOSadas to new model versions when ready. Here are the results the results from the latest attempt in GMAO_Shared with the candidate version:
Changes to be committed:
	modified:   GEOS_Shared/GEOS_Utilities.F90
	modified:   GEOS_Util/post/era5_prs2eta.F
	modified:   GEOS_Util/post/g5fcst_stats.pl
	modified:   GEOS_Util/post/stats.F90
	modified:   GEOS_Util/pre/NSIDC-OSTIA_SST-ICE_blend/cube_BCs.pl
	modified:   GMAO_etc/Extract_config.pm
	modified:   GMAO_etc/PUBLICTAG
	new file:   GMAO_etc/Recd_State.pm
	modified:   GMAO_etc/Remote_utils.pm
	modified:   GMAO_etc/ana4dupd.pl
	new file:   GMAO_etc/arbitrary.pl
	modified:   GMAO_etc/check_obsysrc.py
	modified:   GMAO_etc/cmpdir.pl
	modified:   GMAO_etc/getsponsor.pm
	modified:   GMAO_etc/idcheck.pl
	modified:   GMAO_etc/jobIDfilter
	modified:   GMAO_etc/mptfix.pl
	new file:   GMAO_etc/obsys-nccs-arc.rc
	modified:   GMAO_etc/obsys-nccs.rc
	modified:   GMAO_etc/rndasfiles
	modified:   GMAO_etc/rst2rcyc
	modified:   GMAO_hermes/cnv2prs.pl
	modified:   GMAO_hermes/dyn2dyn.f90
	modified:   GMAO_hermes/dyn_iupd.F90
	modified:   GMAO_hermes/dyn_recenter.f90
	modified:   GMAO_hermes/dyndiff.f90
	modified:   GMAO_hermes/dynp.f90
	modified:   GMAO_hermes/m_const.f90
	modified:   GMAO_hermes/m_dyn.f90
	modified:   GMAO_hermes/m_set_eta.F90
	modified:   GMAO_hermes/m_vdc2vdc.F90
	modified:   GMAO_ods/CMakeLists.txt
	modified:   GMAO_ods/diag2ods
	new file:   GMAO_ods/m_obs_stats.F90
	modified:   GMAO_ods/m_ods.f90
	modified:   GMAO_ods/obimp_summary.pl
	modified:   GMAO_ods/ods_dcget.f
	modified:   GMAO_ods/ods_dconv.f
	new file:   GMAO_ods/ods_diagnc4.f90
	modified:   GMAO_ods/odslist.f
	modified:   GMAO_ods/odsmatch.rc
	modified:   GMAO_ods/odsmeta.h
	modified:   GMAO_ods/odsnxtime.f
	modified:   GMAO_ods/odsstats.f
	modified:   GMAO_ods/ozone-kx.readme
	modified:   GMAO_ods/radiance-kx.readme
	modified:   GMAO_perllib/GrADS/Grads.pm
	modified:   GMAO_transf/g4tog5.f90
	modified:   GMAO_transf/m_xform.f90

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   GEOS_Util/plots/fcst/setup_statd
	both modified:   GEOS_Util/plots/grads_util/closeness.gs
	both modified:   GEOS_Util/plots/grads_util/corcmpz_plot.gs
	both modified:   GEOS_Util/plots/grads_util/makezf
	both modified:   GEOS_Util/plots/grads_util/parea
	both modified:   GEOS_Util/plots/grads_util/plot.rc
	both modified:   GEOS_Util/plots/grads_util/rmscmpz_plot.gs
	both modified:   GEOS_Util/plots/quickstat
	both modified:   GEOS_Util/plots/res/zonal.gs
	both modified:   GEOS_Util/post/gcmpost.script
	both modified:   GEOS_Util/post/regrid.pl
	both modified:   GMAO_etc/esma_mpirun
	both modified:   GMAO_hermes/CMakeLists.txt
	both modified:   GMAO_hermes/m_dyn_util.F90
	both modified:   GMAO_hermes/m_interpack.F
	both modified:   GMAO_hermes/m_interpack_ad.F
	both modified:   GMAO_hermes/m_mapz_pert.F90

Note in particular the conflicts. These will have to be dealt with. I'm not sure who wins with the plots. The Hermes conflicts mostly do with the fact that on main those files now use the kind values (REAL32/REAL64) from the standard iso_fortran_env module rather than m_realkinds module. How, there appear to be some conflicts beyond just use the alternative definitions of the same kind.
For example in m_mapz_pert.F90 there is a routine mapz_pert_, in main the arguments are "real(kind=REAL64)", whereas on the cvs/adas branch these are plain "real", so for example should the real become "real(kind=32)" etc ...
In any case these conflicts will need to be resolved appropriately.

@bena-nasa thanks for taking a first crack at this. I will look more carefully at these files this evening when I have time. Off the cuff I would say that main/v1.3.8 has @lltakacs latest plot updates as of 2021-02-12 brought over from his sandbox. In most cases I suspect git would supersede cvs for these. I do not recall many PRs lately dealing with GMAO_hermes on the git side. So it is possible that cvs is more up-to-date for that but @rtodling would know better than I. It may require a little tkcvs history for those conflicted lines. I suspect @mathomp4 could speak better regarding esma_mpirun.

For these files, my guess is main here wins for plots, post, and pre (though we'd want to be careful). Pretty much everything else, is probably "newer" in the CVS ADAS save esma_mpirun which I'd keep Git's version.
Hermes is also mainly Ricardo's beat, so I'd trust his code, save for any places where (like Ben mentioned) we have a conflict due to type of argument!

This xtrnames argument is unique to the now GEOSadas version of GMAO_Shared, so beyond all the other issues, any GMAO_Shared used by the model will be incompatible with the das until the two are merged.
GMAO_hermes/m_dyn.f90
1770:                        ncf, pncf, xtrnames )                                ! optional
1785:  character(len=*), OPTIONAL, intent(in), pointer :: xtrnames(:) ! name of addition tracers

as something in one of the das applications calls with this argument.

I'm going to close this. I think we've done it.


test: 💍 [TableVirtualized] Fixed snapshot tests

Ensure table rows are rendered before testing snapshot
✅ Closes: #425

Hi @alessandrotilli I'm updating mosaic deps and disabled components db file.
Can I merge these changes into my branch? With this effort from you I think we can have test passing now.
Let me know, thanks

Hi @luciob , i forked the repo and made some test and it seems that playwright viewport setting affects snapshots test. Some sizes will make the tests pass, other ones (the default one for example) will fail.
Take a look at my fork's actions for reference).
At this point I don't know if is better ignore snapshot test for this component as you suggested o try using a working viewport.
What do you think?

:tada: This issue has been resolved in version 10.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Migrate e2e tests

In order to sync CI jobs with m/s and make code reusable
through components, actions scripts tests are migrated to prow scripts.

This PR has two uses:

Migrating all the tests, including the newest ones to prow which are not reflected in original PR.

After discussing the need or benefits of including infra as github actions or as shell scripts, reach an agreement to one of both choices. This PR keeps the infra code in github actions but it could be swiftly updated if needed.
Please cc/ @ybettan @qbarrand

I am not sure I understand the purpose of this PR:

Is this just another implementation of https://github.com/kubernetes-sigs/kernel-module-management/pull/159?
Why are we building the driver container in each job instead of just once?

We are building it just once and downloading it in all jobs, just like before.

Umm I see ./.github/actions/build-drivercontainer-image in every job. Am I missing something?
@qbarrand

/ok-to-test

Umm I see ./.github/actions/build-drivercontainer-image in every job. Am I missing something?

I stand here corrected, my apologies. We used to build both only once, but now it's only the operator image.
The reason is that not all GitHub Actions VMs run the same kernel; this caused issues because the kmod was built in a VM running kernel X, while another VM trying to load that kmod was running kernel Y.
Original fix PR: https://github.com/qbarrand/oot-operator/pull/72

Codecov Report
Base: 73.33% // Head: 73.33% // No change to project coverage :thumbsup:

Coverage data is based on head (cffca3e) compared to base (3cfe04b).
Patch has no changes to coverable lines.

:exclamation: Current head cffca3e differs from pull request most recent head 96643c4. Consider uploading reports for the commit 96643c4 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #166   +/-   ##
=======================================
  Coverage   73.33%   73.33%
=======================================
  Files          25       25
  Lines        2438     2438
=======================================
  Hits         1788     1788
  Misses        564      564
  Partials       86       86

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@ybettan I stand here corrected, my apologies. We used to build both only once, but now it's only the operator image.
The reason is that not all GitHub Actions VMs run the same kernel; this caused issues because the kmod was built in a VM running kernel X, while another VM trying to load that kmod was running kernel Y.
Original fix PR: https://github.com/qbarrand/oot-operator/pull/72

I see. In that case I would add a comment to explain it in the test, otherwise, anyone looking at it may just change it without understanding the problem.

What happened to all the files in the PR? Seems like there were all deleted...

What happened to all the files in the PR? Seems like there were all deleted...

Bad commit. Fixed yet.

/lgtm

/assign @ybettan


Document custom icon process and update hardcoded icons

[ ] Add icon contribution to our repo's docs, which is roughly:
[ ] If you need an icon or pictogram not offered through Carbon's packages, add it to this sketch file https://ibm.ent.box.com/folder/150662985481, in doing so, include attribution where required so we can do an open-source audit for all icons that didn't come from us
[ ] Size it at the intended size that it'll get rendered (might as well make sure it renders on the pixel grid for 1x displays if possible)
[ ] Ensure it's all black
[ ] Use a slice to export the SVG
[ ] Place in the icons package in monorepo
[ ] Run a build, then you'll be able to use the optimized SVG as a React component in the web app
[ ] Update the footer component with IBM SVG coming through our icons package (that doesn't get published to npm)

@alisonjoseph @andreancardona just an FYI our custom icon instructions to follow plus what we need to document (in better words) in our repo docs.

@alisonjoseph @andreancardona I moved that Sketch file in Box to Carbon > Platform Squad > Source https://ibm.ent.box.com/folder/158366227035


Consider using more compact storage of compression mode and quality

Idea from Peter:
"You may even consider encoding all of this information in a single 32-bit unsigned integer.  Maybe use a few bits (say, 4, for future proofing) for compression mode and remaining bits for a fixed-point number.  For the ranges above, 12 bits signed integer and 16 bits of fraction would work.  It's true that no one could manually "decode" such a representation in their head, but I feel equally confident that no one could interpret a binary double-precision value broken into two 32-bit integers either. ;-)"
"Both BPP and PSNR have reasonable ranges that can be encoded in 32-bit fixed point.  PWE > 0, so you may consider a fixed-point representation of -1074 <= log2(PWE) < 1024, rounded up (so you don't violate the tolerance)."
Another benefit of using 32 bits to store such information is that it's more resilient to byte swaps than using two 32-bit ints to store a 64-bit double. Consider the following example (again, from Peter)
"Suppose I do a memcpy() of a double to an unsigned int cd_vals array.  And for simplicity, let's say our double has 64-bit binary representation 0x0123456789abcdef.  On a little-endian machine, such a memcpy will result in the following byte sequence:
{0xef, 0xcd, 0xab, 0x89, 0x67, 0x45, 0x23, 0x01}
Because this is copied to an array of unsigned 32-bit ints, those two ints will be interpreted as
{0x89abcdef, 0x01234567}
Now suppose we're reading those two cd_vals on a big-endian machine.  As I understand, HDF5 will byte swap them for you as 32-bit integers, resulting in this byte-swapped sequence:
{0x89, 0xab, 0xcd, 0xef, 0x01, 0x23, 0x45, 0x67}
Those are interpreted as these two 32-bit integers (i.e., same as on the little-endian machine).
{0x89abcdef, 0x01234567}
We then copy those 8 bytes to a 64-bit double using memcpy and obtain as 64-bit binary representation
0x89abcdef01234567
This is not the same as 0x0123456789abcdef, because the 8 bytes were swapped not as a 64-bit type but rather as two 32-bit types.  I mean, HDF5 had no way of knowing that a pair of 32-bit integers were used to store a 64-bit quantity, so how could it correctly byte swap them?  How is this dealt with properly?  Or is it?"

Fixed by #4