Update links to help in the GUI Help Menu

In past GUIs, we provided a local copy

user's guide
tutorials
doxygen

The links in the menu pointed to the online versions first, and then local if the user isn't online. Given that people are almost always online we could provide perhaps just the tutorials and doxygen as local copies. The way we structure the links, the documentation associated with the release will be saved (i.e., when we release 5.0, the GUI will still link to the 4.0 documentation online).
Let me know your thoughts. @jimmyDunne @aseth1 @aymanhab @chrisdembia

We still distribute "user doxygen" with the GUI but I don't know if the GUI has been updated to find the location of this documentation.

Also need to update link to "Workshops and Events" (name changed) ... alternately I think each confluence page may have an id number that we could link to instead that might be robust to name changes. We also need to make sure that the links to Doxygen, Examples and Tutorials, and Documentation point to "OpenSim40"

All the links in the help dropdown and welcome page work for me when online.
When offline, the tutorials and doxygen local copies are accessible, as expected. Other links do not work.

The help buttons in the tools (Scale, etc.) are still pointing to 3.3 versions.
The help button for plotter, excitation editor, preferences, still points to 3.3
I will open a separate issue.

Will verify all but the dialog buttons as they're still in PR.

Installation Guide link on welcome page says only Windows Vista, XP, Windows 7!! I'm not sure we tested XP and Vista  😃

Will verify all but the dialog buttons as they're still in PR.

#902


Enable vscode tests gradle

Purpose
Enable vscode integration tests

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@0db712d). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #15089   +/-   ##
=========================================
  Coverage          ?   16.49%
=========================================
  Files             ?       43
  Lines             ?     1285
  Branches          ?      212
=========================================
  Hits              ?      212
  Misses            ?     1060
  Partials          ?       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0db712d...cf9c29c. Read the comment docs.


Is it possible to retrict the aspect ratio of the cropting area?

Hi
Is the possible to set a limitation for the aspect ratio (for example that only square images are accaptable) in addition to size limitations?

Look for aspect ratio, see https://github.com/ArthurHub/Android-Image-Cropper/wiki/FAQ#how-can-i-set-crop-shape-to-squarecircle.


[Tech debt] Move away from current splitter package

We should move away from the current split package(JS shim) as it has been removed from the flutter devtool's repository and is no longer supported.
Edit: We've now moved it to this repository, but could consider writing a Dart only version for better integration.

Closing as we now use package:split_view.


CRI-O: match version against openshift

@mrunalp @kargakis @stevekuznetsov PTAL this will fix https://github.com/openshift/origin/pull/17546 by pulling the correct image for the CRI-O system container
Signed-off-by: Antonio Murdaca<EMAIL_ADDRESS>

Tag mapping lives here for now: https://hub.docker.com/r/runcom/cri-o/tags/

Historically logic like this has a habit of breaking whenever something crazy happens with versioning. I think it may be better to have a switch-case and very explicit requirements?

You mean to not concatenate strings to build up the image string for the installer?  We can avoid that, but that requires us to update this repo every time a new release come up no? I think I'm missing something

Yes, it would require it to be updated. If you think releases are very frequent then maybe it's a bad idea. If it's once per release of Origin that's usually once every couple of months and totally OK. I would rather heave a static list/mapping we have to update than logic that fails in some weird edge cases or ends up installing something unexpected. Switch/case can have a well defined default

@stevekuznetsov added the case statement for the crio image PTAL (deployed to the CI as well for the crio jobs)

@ashcrow so I've fixed the image tag but now we have another issue https://ci.openshift.redhat.com/jenkins/job/test_branch_origin_extended_conformance_crio/185/consoleFull#54402166758b6e51eb7608a5981914356
which is not related to CRI-O

Are you starting the job manually? Use /test. The job expects many parameters to be set that were not provided in that run.

Are you starting the job manually? Use /test. The job expects many parameters to be set that were not provided in that run.

oh, I see, I'll just /test crio then

So it's failing again https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_extended_conformance_crio/427/consoleFull#-190934373858b6e51eb7608a5981914356
but this time it tries to restart CRI-O but it hasn't been installed, has something changed in openshift-ansible that now forgets to "atomic install" CRI-O?
@giuseppe @ashcrow

@runcom not that I'm aware of ... but looking at the code it doesn't look correct. It literally installed node items but didn't install the system container 😕.
I see that the docker role has been renamed container_runtime (which makes sense) ... I wonder if something slipped through the cracks.

I think this may be it but I'm not sure. The role used to require the docker role, but it no longer has a dependency.
@michaelgugino ^^ Thoughts?

Looks like it merged yesterday https://github.com/openshift/openshift-ansible/pull/6297

So that's another reason to test cri-o as well in openshift ansible ha

Docker has been renamed to container_runtime to more accurately reflect its purpose.
This must now be called from prerequisites.yml before calling byo/config.yml

@michaelgugino thanks. Was there a reason this wasn't called already or is it a bug from refactoring?

I have some patches here, I will push them shortly.
Another thing, we should enable container-engine in the system-containers tests.

@michaelgugino thanks. Was there a reason this wasn't called already or is it a bug from refactoring?

It's intentional. So we need to ensure those vars are set when calling prerequisites too before this PR will produce the desired outcome.

Any and all variables used with any and all of the plays must be used with prerequisites.yml.
In the case of container_runtime, that is all configured during prerequisites.yml.  prerequisites.yml configures all of the host-level settings for each container runtime.  In the case of system containers, this is when the runtime images are pulled and configured.
I highly recommend refactoring some of the tests to use a extra_vars file instead of passing most things via cli in the script.  This will help alleviate some of the issues in the future.

@michaelgugino Is that something which can be done in a follow-on PR?

@sdodson++

@sdodson Thanks!

@michaelgugino Does it look okay now with @sdodson commit?

I opened up https://github.com/runcom/cri-o-system-container/issues/1 to ensure that this is the image that is in @runcom's namespace. Pulling and looking at it I'm pretty sure it is.


BUG: New Badge does not recognize Npm Organizations

Describe the bug
There is bug that prevents register new projects that are belonging to an NPM organization
Reproduction steps
Steps to reproduce the behavior:

Enter in https://bestpractices.coreinfrastructure.org/en/projects/new

Try to submit the github repo (https://github.com/onebeyond/systemic-knex)

OR try to submit URL (https://www.npmjs.com/package/@onebeyond/systemic-knex
, https://github.com/onebeyond/systemic-knex)

Expected behavior
The project is valid and the urls are correct, but there is an issue with the regex used to manage the URLs https?:\/\/[A-Za-z0-9_][-A-Za-z0-9_.]*(\/([-A-Za-z0-9_.:\/\+!,#~]|%(20|[89A-Ea-e][0-9A-Fa-f]|[Ff][0-7]))*)? as does not include support for @, so refactoring to https?:\/\/[A-Za-z0-9_][-A-Za-z0-9_.]*(\/([-A-Za-z0-9_.:\/\@+!,#~]|%(20|[89A-Ea-e][0-9A-Fa-f]|[Ff][0-7]))*)? should work.
Additional context
I can create a PR with the changes needed but I am not sure where the code is located

I believe this is the repo to make the changes: https://github.com/coreinfrastructure/best-practices-badge
I will try to take a look at the bug Ulises!

Yeah @gabibguti! It is working now, I just submitted the app 👍


tiny_http sample

I seem to be the first one with the sample, so I am not entirely sure if I'm right with the code style etc, but the sample works perfectly!
pinging @cybergeek94 for review.

Awesome! My only major concern is the excessive use of .unwrap() which will cause a panic on error conditions, which is generally considered poor practice. Though usually excusable in short, one-off programs like this, a lot of these .unwrap() calls could be handled more pragmatically. Does that make sense?

@cybergeek94 wow, thanks for detailed review! I was not sure if I needed to handle all these Results since it's a small sample, but I'll handle them correctly.

Much appreciated.

@cybergeek94 reworked a sample with your comments in mind.

@White-Oak Looks good! Couple of final nits, but they're strictly non-blockers as the example looks fine otherwise. What I'll probably end up doing is adding a script to the CI configuration to build and test examples, but I'll test this manually for now.

It builds and runs for me just fine! Those nits aren't a problem, I'll take care of them when I'm putting the samples together.
Thanks for the hard work! If you'd like to try something else, there's still a couple more tasks available.


latest version not working in nuxt as  "^1.6.1" this version does work

I had installed the latest version vue-star-rating on "nuxt": "^2.14.0", but it throws window reference error from the
vue-star-rating.min.js file, then I had revert back to "vue-star-rating": "^1.6.1" this version the issue is solved for now.

Hello,
Version 2 of vue-star-rating is for Vue 3 installs. Nuxt is currently using Vue 2, so you will need to continue to use vue-star-rating Version 1. I'm still maintaining both versions and all new features are being added to both at the same time, so you won't miss out on anything by using Version 1.
I hope that helps.

When you say latest version, are you talking about Version 2.0? That's specifically for Vue 3 installs and Nuxt uses Vue 2.

In my case I had the same issue (window reference issue) when updating from 1.6.1 to 1.6.3. And in the JavaScript console I had this error:
Uncaught ReferenceError: Zepto is not defined

It works well with the 1.6.1 version, so I am restoring to this version for now.

When you say latest version, are you talking about vue-star-rating version 2.0? That's specifically for Vue 3 installs and Nuxt uses Vue 2.

I readdress the issue when I run  npm install vue-star-rating which install

1.6.3 version

throw an error while I uninstall run  npm uninstall vue-star-rating to uninstall and again npm install<EMAIL_ADDRESS>which install  vue-star-rating

1.6.1 version

by reverting back / doing this, solves the error in nuxt specifically :-
> "nuxt": "^2.14.0",
> "@nuxtjs/auth": "^4.9.1",
> "@nuxtjs/axios": "^5.12.0",
> "@nuxtjs/pwa": "^3.0.0-beta.20",

https://we.tl/t-sNBqsEaen6
have a look attached screenshot in link

Thanks for the info. I'll update the build process so that it outputs a separate CommonJS files for use with bundlers, which, honestly, I should have done before.

Same issue for us. It broke our SSR.

Sam issue for us.

OK, I've just released version 1.7.0 on npm where I've updated the build process which is now using the vue-cli-service to build  separate UMD and CommonJs files. I have tested this using the vue-cli to create a project and it all seems to work correctly, but I haven't tried it specifically in nuxt, so please let me know if you get any further issues.


Randrincorporated.com Update LICENSE

Bio-metric verification
Description
Please provide a detailed description of what was done in this PR.
(And mentioned if linked to an issue docs)
Changes include

[ ] Bugfix (non-breaking change that solves an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (change that is not backwards-compatible and/or changes current functionality)
[ ] Tests
[ ] Documentation
[ ] Other (for changes that might not fit in any category)

Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it.
Additional comments
Please post additional comments in this section if you have them, otherwise delete it.

Verify sponsorship please, thank you!

``

Coinbase<EMAIL_ADDRESS>Reclaim-deploy

Verify sponsorship please, thank you!  ``


Trojan virus found

https://www.virustotal.com/gui/file/7cfeeaef300793c03a54612ae648c23e4dc751237cf146637efcb44ba136ba58/behavior

Hi,
thanks for reporting this, but you can see by the finding descriptions that this is intended behavior:

That "Rising" Scanners match<EMAIL_ADDRESS>(RDML:qa6rh/NG4BN/gKY/Ujk3yg)

Seems to be some AI stuff getting triggered by the windows executable wrapper for the java application

Those two "Sigma Rule" matches:

"Potential Defense Evasion Via Binary Rename"

This is most likely the update function or savegame handling

"File Download From Browser Process Via Inline Link"

Again could be the updater, or any link to github or websites

If you don't want to use the Windows executable, you can also download the .jar file from the release page and launch that using your installed Java Runtime.


Crash observed when restarting HTTP after deploying an XPages WAR app

This showed up on the first HTTP request to the app after HTTP restart, after several messages, so it's not immediately on initializing Notes:
10908:000039-00007F419E1DA700] 06/08/2020 12:13:47 PM  WLP: [AUDIT   ] CWWKF0011I: The develop server is ready to run a smarter planet. The develop server started in 6.340 seconds.
[010908:000039-00007F419E1DA700] 06/08/2020 12:13:47 PM  WLP: [ODA] Starting the OpenNTF Domino API... Using notes.ini: /var/lib/domino/data/notes.ini
[010908:000039-00007F419E1DA700] 06/08/2020 12:13:47 PM  WLP: [ODA] OpenNTF API Version 0.0.0.unknown started
[010908:000039-00007F419E1DA700] 06/08/2020 12:13:47 PM  WLP: [err] Logging.logCfgFilePrecheck: File '/var/lib/domino/data/IBM_TECHNICAL_SUPPORT/org.openntf.domino.logging.logconfig.properties' not found
[010908:000039-00007F419E1DA700] 06/08/2020 12:13:47 PM  WLP: [err] Logging: Couldn't initialize from PropertyFile; activating fallback ...
[010908:000039-00007F419E1DA700] 06/08/2020 12:13:52 PM  WLP: [WARNING ] CLFAD0128W: The registry for the application 1 cannot depend on the library with id com.ibm.xsp.rcp.library, because there is no such library.

[006825:000129-00007F085BAF5700]  Thread=[006825:000129-00007F085BAF5700]
[006825:000129-00007F085BAF5700] Stack base=0x5BAF4FCC, Stack size = 21680 bytes
[006825:000129-00007F085BAF5700] PANIC: CheckTheProcesses - Process /opt/hcl/domino/notes/11000100/linux/jvm/bin/java (8044/0x1F6C) child of 0/0x0 has terminated abnormally

It's possible that the trouble is a lack of NotesTerm call from within the sub-process. If so, it would make sense to create a feature in the vein of CrossWorlds to handle this process.

This'll show up a little while after just stopping HTTP, so that lends more credence to the NotesTerm cleanup theory.

This was mitigated by a combination of adding a notesRuntime-1.0 feature and tweaking the running app to be careful with threads.


OpenVPN: API enable client export

(replace vpn_openvpn_export.php)
Some remarks on previous options while working on this:

"Host Name Resolution": replace with configurable (list of) hostname(s), strip logic and simplify things
"Verify Server CN": only keep non deprecated options
"Use Microsoft Certificate Storage instead of local files.": Remove for now, current option likely won't work
"Management Interface OpenVPN Manager": remove, current options aren't safe, we should likely leave a text field for specific options like it is now so you can wrap specials here.

close? :)


Add volatile flag to MemFlags

Add Volatile flag to MemFlags.
Benefit
When some optimization pass knows about load/store type (is it volatile or not?) then it's possible to do a lot of optimizations. One of it is memory to register promotion. I tried to implement mem2reg pass there cranelift-mem2reg and this pass works but in some cases it fails e.g this simple C code:
// compiled with rcc
typedef struct Foo {
    int x;
    int y;
} Foo;

int main() {
    Foo foo;
    foo.y = 42;
}

Message:  definition error: Compilation error: Verifier errors
note: while compiling function u0:0() -> i32 system_v {
    ss0 = explicit_slot 8

block0:
    v1 = iconst.i64 4
    v2 = iadd.i64 v0, v1
    v3 = iconst.i32 42
    store v3, v2
    v4 = iconst.i32 0
    return v4
}

All loads and stores might be marked as volatile and mem2reg will not optimize struct Foo into registers.
Volatile flag also can help in SRoA when it's possible to replace allocation on stack with single 32 or 64 bit register.
Implementation
Just add additional enum case in codegen/ir/memflags.rs and add 3 simple functions to MemFlags: volatile() -> Self,is_volatile() -> bool, set_volatile(&mut self).
Alternatives
I do not see any alternatives.
UPD: This might be useful for this issue: Support volatile store/loads

FYI I implemented something very similar to your mem2reg in cg_clif: https://github.com/bjorn3/rustc_codegen_cranelift/blob/169140506366d5aa96967a71b6af98563a9c2988/src/optimize/stack2reg.rs

UPD: This might be useful for this issue: Support volatile store/loads

Implementing that issue would almosy definitely be done by adding a volatile flag to MemFlags as this issue suggests.

@bjorn3 your implementation looks much better than mine, but issue still remains, it is impossible to do mem2reg pass safely without volatile loads and stores :(

I have been thinking if we should maybe make MemFlags some opaque number just like SourceLoc and then pass a MemoryModel to the compile function, that uses the number to determine what kind of optimizations are allowed around load and store. That MemoryModel is then responsible for aliasing, volatility, atomic orderings, ... Another similar way would be to pre-compute all memory dependencies and store that in the function, like @sunfishcode suggested in https://youtu.be/9OIA7DTFQWU beginning at 36:40.

Giving frontends a way to provide explicit memory dependencies, and using that to implement volatile semantics would be cool. If anyone's interested in a designing a system to do this, it'd be good to start with a design document so we can look at how it'll impact compile times in fast-compilation use cases, and other tradeoffs involved.
We may want to do something simpler for now that just addresses volatile, and I have a possible alternative. Traditional volatile flags on regular memory accesses turn out to be very error prone. The recommended solution is to transform volatile into a call or separate opcode, and optionally inline the call after all optimizations. It's now how it systematically eliminates a common class of volatile bugs, however it does add complexity in the backend. So instead, how about the following design:
Add new two instructions to the IR:

y = volatile_unary(x) - observe the value of x, do side effects, and return a new value
volatile_rmw(p) - observe the value of *p, do side effects, and then clobber *p.

At a very late stage, volatile_transform would be translated as if it were an identity operation, and volatile_rmw would be translated as if it were a no-op. With those, frontends could then translate a volatile load like this:
   volatile_rmw(p)
   x0 = load(p)
   x = volatile_unary(x0)

and a volatile store like this:
   x0 = volatile_unary(x)
   store(p, x0)
   volatile_rmw(p)

That is, we'd use plain load and store instructions, but boxed in with volatile operations, both in control flow and data flow, to prevent any code motion or redundancy elimination. It'll get chatty, especially in the volatile-atomic case, but volatile is rare so it seems like an ok tradeoff. This should let most of the compiler automatically do the right thing, at low cost in overall complexity. And, volatile_rmw and volatile_transform would be handy besides for crafting compiler unit tests :-).

The recommended solution is to transform volatile into a call or separate opcode, and optionally inline the call after all optimizations.

Sort of like a memory fence? It marks this load/store as unable to be removed? That sounds reasonable to me.
I can't quite run csmith yet, but as soon as I do I'm happy to test out the combination of mem2reg and volatile to make sure there's no misoptimization.

make MemFlags some opaque number just like SourceLoc and then pass a MemoryModel to the compile function

I don't know that I like the idea of more indirection. If Cranelift uses opaque IDs for these flags, it makes it much harder to find the intended purpose - it's in an entirely separate part of the documentation. I also don't see the benefit over normal MemFlags.

I also don't see the benefit over normal MemFlags.

The benefit is that the MemoryModel can assign arbitrary meanings to it, like this load can only alias with these other loads to prevent a stacked borrows violation. My proposal is that all properties of loads and stores are handled by the MemoryModel, so that you can easily switch between a C memory model, a Java memory model, stacked borrows and any other memory model without changing Cranelift itself.
Also note that I didn't mean to assign a property like volatile to a specific number, but instead let MemoryModel store a map between the number and any relevant properties.


Send an email when a dataset is live on the website

We need to send an email to inform the contributors that the dataset is online.

A problem with this is that we can't reveal emails in the datasets script. What do you think @AliOsm?


Move to rustfmt 0.4.1-stable

(the version packaged with Rust 1.26)
Fix for #37

No objections. I'm going to merge.


added createDF to Functions#cbrt

Don't know what I'm doing wrong :(

@lizparody - Check the commit I added to fix this 😄


⚠ Bofrost.be has degraded performance

In a4e99f9, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2026 ms

Resolved: Bofrost.be performance has improved in a5a2a4f.


Replace breakpoint mixin with breakpoint.scss

Using breakpoint simply for better practice
https://github.com/at-import/breakpoint

actually this doesnt apply now


Mark TestRaptorIntegrationSmokeTest.testCreateBucketedTable as flaky

Relates to https://github.com/prestosql/presto/issues/1977

maven checks fail


Handle network response in datamanager

DataManager does not need to implement ApiHelper. This removes unnecessary implementation of getApiHeader.
Helper methods to perform login can be extracted to a separate interface(LoginHelper) and implemented by datamanager.  Datamanager will delegate the login tasks to Apihelper.
Presenter only needs to know if login was successful or some error occurred. So I've just returned an emtpy observable in case of successful response.

@ISatya
Thank you. We highly appreciate your insights.
I have few concern in this approach.

The DataManager code will become huge and unmanageable when the entire application start to take shape.
If the presenter have to delegate the data from network to the view then there will be unnecessary interception by the DataManager. DataManager will do nothing with that data but to extract and then forward it to the presenter.
In the above implementation the DataManager is handling the business logic of whether to logout user or log in. The business logic should be only handled by the presenter. DataManager should only be responsible for handling the data as told by the presenter.

Thanks

If the entire application data is handled by a single DataManager then it will get bloated. DataManager should be split into multiple managers.
In current implementation, all tasks are implemented in a Single DataManager.
If we extract login related tasks to a separate manager - LoginDataManager and do the same with any new modules that are added, individual data managers will be small and manageable.

Agreed. But in this case, presenter is responsible for handling network response. This adds additional responsibility of forwarding response to DataManager.
If my understanding is correct, DataManager should be responsible of managing data. It should decide what to do with the response, whether to persist it or just pass it to the presenter or to convert it to a form required by the presenter. Presenter should not be forwarding network response. It should receive data from DataManager and use it to decide
what the view should show.

Presenter is the one initiating logout or login. Presenter tells DataManager to perform logout call and DataManager does the required network calls, updating user session locally and then inform presenter whether logout was successful or not.

@ISatya Agreed with most of your points. We will think on this and discuss.


DRAFT: How do we deal with JDMs / OEMs / ODMs?

Overview
In other sectors JDMs might make up a lot of the suppliers (at least in Tier 1) - how do we deal with these, who is the parent company, how are they disambiguated?
See HP list as example: https://h20195.www2.hp.com/v2/getpdf.aspx/c03728062.pdf

Ideation Discussion, May 18 -
Criteria to think about / possible solutions:

Possible series of logic for parent company / name display
Alert could be set up for moderation that could flag when we have parent company only profiles (could then be reviewed quarterly)
If the data quality of address is really good, it's not a problem that we only have the parent company name
You can still get to where you need to with only parent company name for remediation use cases

"biggest" problems:

How does it display when name AND parent company exist in the facility
Can name AND parent company be prioritized
Possible algo solutions to determine how it displays as well as how it factors into matching, for the use case when there is no name uploaded.

Overarching question: what is the minimum set of data points that enables identification / accountability?


The values in the dishwasher are not updated. (D1211-DW)

The values in the dishwasher are not updated.
Thank you.
smartthinq_sensors-식기세척기
kr

ThinQ Dishwasher Log.txt

Please attach diagnostics.

Entities are not updated.
There are no alarms.
Debug Data.txt
smartthinq_sensors-db1f65d34a8f04495f7a542898ddaa06-ìê¸°ì¸ì²ê¸°-6c431cbf92d1b1db67fa0ee8135e0bbf.json.txt

Please try last release, should fix this issue.

It changes very well.
Thank you very much.

sorry.
When I check again, the attribute value of the dishwasher is not updated.
I need dishwasher uptime and remaining time.

Did you try enabling the corresponding sensors? What attributes are not updated? Just the time or also others?

Initial_time, rest_time, and reserved_time attribute values are not updated.
Additionally, the Initial Time, Time Remaining, and Countdown Time sensors are disabled by default and their entities will not be updated when switched to enabled.
Where can I check the remaining time of my dishwasher?
smartthinq_sensors-db1f65d34a8f04495f7a542898ddaa06-ìê¸°ì¸ì²ê¸°-6c431cbf92d1b1db67fa0ee8135e0bbf.json-3.txt

Probably reading o wrong place. I'll check and let you know.


Updating the usage of self signed certificates

Based on the investigation from the SCM warehouse team

@MarkusFogelberg, can you review this?

We should remove IOS from this sentence: "(Please note self-signed certificates can only be used on Windows devices and not on Android and IOS)".
Otherwise it looks good and I approve the change.


mac_app_store_installer: fix flaky test, remove dead code.

@colindean @jacobbednarz I'm not convinced it's a good ROI filing more flaky failure issues. They take a while to debug, they aren't harming end-users and this is not a particularly flaky test suite in general.
Fixes https://github.com/Homebrew/homebrew-bundle/issues/664

I'm on the fence about ignoring flakey tests for exactly the reason you've mentioned. The test suite is currently pretty stable and when I'm looking at upgrades or introducing functionality, I lean very heavily on the existing test suite for confidence in the change and I wouldn't want that to go away for others because we started ignoring the stability.
Yes, they are difficult to debug and they don't always harm the end user but it can make maintainer life difficult if they do start creeping in.
Either way, appreciate you grabbing the two I raised :star2: I had intentions of getting back to it but unfortunately it slipped down the priority list and didn't get looked at.

I'm on the fence about ignoring flakey tests for exactly the reason you've mentioned.

I'm not suggesting "ignoring" as much as "don't submit issues".

Either way, appreciate you grabbing the two I raised 🌟 I had intentions of getting back to it but unfortunately it slipped down the priority list and didn't get looked at.

This is the thing I'm talking about mainly, I guess. I have zero objection to anyone who finds flaky tests submitting fixes for them. I do object a bit to issues being opened that end up falling on me to fix.


sphinx_lesson/directives: cssname vs get_cssname backwards compat

Some people deriving from this have already use .cssname(), so we
should make life easy and continue to support that.
Closes: #71
Review: general check

Looks great!


Arrays not supported

Related issue in reflectwalk: https://github.com/mitchellh/reflectwalk/issues/16

@mitchellh could you please review my pull request for this issue?

Fixed by you!


Sort the Projects

Arrange the projects in a sequential way ( The way they are shown in GitHub). Changes are needed to be made in style_links.json.

Hey @VidhiBhatt01
I can do this task efficiently.

@VidhiBhatt01 Hy, Please assign this task to me. I have read the source code already. I can do this easily. Thanks :)


iptables -P FORWARD ACCEPT persistence

Perhaps this is more of an ubuntu question than an microk8s bug, if so feel free to close this and redirect me elsewhere.
For my microk8s use case I need traffic forwarding to be enabled. microk8s.inspect suggests sudo iptables -P FORWARD ACCEPT as the way to enable it. And running that command works.
However after every reboot I have to re run the command. I'm running on a clean 18.04 (desktop) install, with microk8s 1.12/stable. I've installed iptables-persistent & netfilter-persistent and run sudo netfilter-persistent save (after enabling forwarding). Yet after each reboot forwarding is disabled (reloading netfilter-persistent works).
Am I missing something obvious here? Is microk8s doing something funky? Any other suggestions on how I can permanently enable forwarding would be great.

Hi @laurence-hudson-mindfoundry
Could you try the solution on this issue: https://github.com/ubuntu/microk8s/issues/266

Perfect, thank you, not sure how that issue slipped by my searching. Sorry about the duplicate.


[firebase_messaging] Dependency conflict between newest firebase_messaging: ^5.1.5 and google_maps_flutter: ^0.5.21

Describe the bug
Using newest pacakges firebase_messaging: ^0.1.2 and google_maps_flutter: ^5.1.5
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':app:preDebugBuild'.
> Android dependency 'android.arch.lifecycle:runtime:1.0.0' is set to compileOnly/provided which is not supported

To Reproduce
Steps to reproduce the behavior:

create new flutter project
add pubspec.yaml

dependencies:
flutter:
sdk: flutter
cupertino_icons: ^0.1.2
firebase_messaging: ^5.1.5
google_maps_flutter: ^0.5.21

Closing due to inactivity - please create a new issue following the template.
It's worth checking the latest versions of everything work together as there has been major changes since this issue was created.


NetworkException: cURL error 6: Could not resolve host: www.google.com

I'm trying to get a simple exchange rate but it fails with a cURL exception.
I have debugged it and copy the URL that is trying to connect to and I can access with the browser without problem. Also, I can ping to the servers query.yahoo.com, www.google.com.
I'm using:

florianv/swap 3.0.2
php-http/message 1.5.0
php-http/guzzle6-adapter 1.1.1

The code is:
<?php

require __DIR__ . '/../../../vendor/autoload.php';

use Swap\Builder;

// Create Swap with the provider
$builder = new Builder();
$swap = $builder
  ->add('yahoo')
  ->add('google')
  ->add('european_central_bank')
  ->build();

$rate = $swap->latest('USD/EUR');

var_dump($rate);

And the error is:
( ! ) Fatal error: Uncaught Exchanger\Exception\ChainException: The chain resulted in 2 exception(s): Http\Client\Exception\NetworkException: cURL error 6: Could not resolve host: query.yahooapis.com (see http://curl.haxx.se/libcurl/c/libcurl-errors.html) Http\Client\Exception\NetworkException: cURL error 6: Could not resolve host: www.google.com (see http://curl.haxx.se/libcurl/c/libcurl-errors.html) in /home/jabellota/Proyectos/wsAptana/PaginaPublica/web/areaprivada/vendor/florianv/exchanger/src/Service/Chain.php on line 66
( ! ) Exchanger\Exception\ChainException: The chain resulted in 2 exception(s): Http\Client\Exception\NetworkException: cURL error 6: Could not resolve host: query.yahooapis.com (see http://curl.haxx.se/libcurl/c/libcurl-errors.html) Http\Client\Exception\NetworkException: cURL error 6: Could not resolve host: www.google.com (see http://curl.haxx.se/libcurl/c/libcurl-errors.html) in /home/jabellota/Proyectos/wsAptana/PaginaPublica/web/areaprivada/vendor/florianv/exchanger/src/Service/Chain.php on line 66
Call Stack
#	Time	Memory	Function	Location
1	0.0002	384504	{main}( )	.../borrame.php:0
2	0.0021	500960	Swap\Swap->latest( )	.../borrame.php:15
3	0.0021	500960	Swap\Swap->quote( )	.../Swap.php:51
4	0.0022	503968	Exchanger\Exchanger->getExchangeRate( )	.../Swap.php:91
5	0.0022	503968	Exchanger\Service\Chain->getExchangeRate( )	.../Exchanger.php:54

It appears to be fixed by itself.
I don't know the cause but without changes in code or connections, it now run without problem.

I think this happen because of March 2017 Ubuntu DNS resolution issues.
For more details: https://www.digitalocean.com/community/questions/how-to-fix-the-march-2017-ubuntu-dns-resolution-issues


Fix tutorials

Fixed underscores in examples/tutorials for the Code field in Appbuilder, and removes some warnings in documentation build.

Hey @AngeloHulshout thanks for the contribution. These are greatly appreciated.


Add the customAttributes field to items and pages.

Not sure if this should go into a base class (e.g. Item) as we currently don't have any fields in it.

I do wonder if we should consider deprecating _unknown_fields_dict and instead mapping those into customAttributes. Although things could be problematic if an item has both, e.g. {"foo": "bar", "customAttributes": {"foo": "baz"}}.


Recipe Management

Description
Recipe Management:

Create, delete and edit Recipes in the Crafting System manager app
Add an ingredient option

with optional catalysts
with optional components

Delete an ingredient option
Add components to an ingredient option
Remove components from an ingredient option
Add a result option with components

I'm thinking of making validation configurable per system. For example, being able to create one crafting system that mandates all recipes must produce results (a checkbox in the details, perhaps) and another that allows recipes that only consume components.
Custom checks and hooks will come later.
Benefit(s)
Implements a core feature for crafting.
Potential Implementation(s)
In the Recipe tab in the Crafting System Manager. A browser that supports search should be the entry point, as with the component manager. Should have different behaviour for locked systems (as with Alchemist's supplies)
Additional Context
N/A

Implemented in 0.81 (Patron pre-release)


check tool improvements

I want to see if we can somehow add:

"is holding" check with an optional ent argument - if ent argument is given, check if you're holding that entity, otherwise if you're holding anything
"is looking at" with either a position or an ent argument.

I keep getting a relatively random desync where a cube won't always go through a portal in time even though position and angle checks pass.

"is holding" should be doable, I'll need to take a look
"is looking at" is more complex because of how we define "looking at"... right now we only know entities by their origin (see autoaim ent), which isn't in the middle. also needs epsilon.

just checked, "is holding" is super doable with optional ent argument


Deleting items from the repository doesnt work in some cases

Environment
No response
Reproduction
Please let me know if you need one. I dont have time right now but can make it later if desired
Describe the bug
This is a new problem since I updated piniaORM last week
I have a model with a parent and a child. Parent is called Location, child is called Feature. The relationship is ManyToOne
I am inserting Feature data for a specific Location using useRepo(Feature).insert(array). When inserting it, the instances dont have an id, so they get assigned a string ID by PiniaORM. They do have a locationId (also a string id)
NOTE: im noticing that:

if I inspect the data returned from the 'insert' call, the data has the string IDs
if I query the data at this point using (useRepo(Feature).query().where('locationId', locationId).get()) immediately after the insert, the ID's are now numbers.
I suspect this is the problem

Next, I want to delete the same data. I query for the features as follows: useRepo(Feature).query().where('locationId', locationId).delete()
When I verify that the data is gone, its not deleted: useRepo(Feature).query().where('locationId', locationId).get().
I also tried to query for the features and then mapping them to an array, and then calling useRepo(Feature).destroy(ids), which also doesnt work. I did notice though that the id's of the Features have number ID's now. I suspect this is the reason. I'm not sure where those number IDs come from
Additional context
The Feature model has a 'properties' attribute. Im noticing that whether this property is there influences the problem. If its not there, im not getting number IDs assigned. does that ring a bell?
Logs
No response

I had to roll back to 1.4.0 to make this go away

I resolved this issue. For anyone who finds this in the future...
It turns out newer versions of pinia-orm return the actual reactive object from queries, instead of a copy, which happened before.
In a different part of my code I was modifying data which then interfered with code like below (I changed id's etc)


Not be able to use path.join

After long time debugging, I found using path.join will cause the app to crash.
I also see the limitation has:

Any code depends on Function.prototype.toString function will break

Is this the root cause of not be able to use path.join?
If so, how come the app works fine on Windows but not on Mac. I keep getting undefined is not a function wherever I used path.join on Mac.

path.join works and always worked with no issues. It has nothing to do with the Function.prototype.toString limitation.
If you can create a minimal example that shows your error on mac, I will check and try to figure it out.

Here is the minimal example. I just clone the electron example, and upgrade to use electron 21.0.1.
electron-hello-world.zip
When you run rpm start, everything goes fine, but after run nom run build and open the binary, the following error shows:

From the console log result, I can see the issue happens when path.join is called.
I'm using Mac OS Version 12.0 with M1, and I'm using Rosetta Terminal to build.
Thanks!

For some reason, npm run build throws this error on my machine:
osama@Mac-mini electron-hello-world %
 npm run build

><EMAIL_ADDRESS>build /Users/osama/Desktop/Dev/electron-hello-world
> electron-builder --x64

Error: Cannot find module 'fs/promises'
.
.
.

The electron example in bytenode repo is quite old. I think it's better to try the current official quick example from electron website.
I'm a bit busy currently, but I will try to put a minimal example using electron-builder to figure out the issue.

Use Node v14+ to build should solve the issue @OsamaAbbas

I updated my node.js version to v18 and I was able to build the example.
However, I could not produce your error. Your app works fine whether it's npm run start or npm run build.
I'm using macOS Monterey (version 12.6) too, the default terminal though, and with node v18.12.1.

I was also able to build, I met the above error when I ran the binary that was built.

Yeah, I was able to run the app that was built.

I managed to have the M1 version built success. Still have some issues with the intel version, but it has nothing to do with bytenode. Thanks for your help! @OsamaAbbas .  Closing the issue.

The only thing that I may mention is that you have to build your app for each platform separately. The binaries that were built for Intel won't work for M1 and vice versa.
Good luck with your project.


Add: @emotion/jest

These snapshots look more stable and informative 🙂
We can probably go and do the same in Gutenberg.
I also deleted some stray package-lock files that seem to be leftovers. The project is using yarn, right?

I also deleted some stray package-lock files that seem to be leftovers. The project is using yarn, right?

Whoops! 🙈 . Yes indeed, this project uses yarn :)


Add vLLM support to DocSum Helm chart

Description
This continues Helm vLLM support added in https://github.com/opea-project/GenAIInfra/pull/610, by adding  vLLM support to DocSum Helm chart.
(Similarly to how it's already done for ChatQnA app + Agent component, there are tgi.enabled & vllm.enabled flags for selecting which LLM will be used.)
Type of change

[x] New feature (non-breaking change which adds new functionality)

Dependencies
opea/llm-docsum-vllm:latest image is currently missing from CI & DockerHub registries:
https://github.com/opea-project/GenAIComps/issues/961
(Although corresponding opea/llm-docsum-tgi:latest image for TGI, and opea/llm-vllm:latest vLLM text-generation images already exist.)
Tests
Manual testing with opea/llm-docsum-vllm:latest image built locally.

Setting as draft because the required image is still missing from DockerHub.

While CI "docsum, gaudi, ci-gaudi-vllm-values" test fails as expected, due to OPEA missing llm-docsum-vllm image...
There seems to be a bug in component unrelated to this PR, as also run "llm-uservice, xeon, ci-faqgen-values, common" CI test fails to a package missing from image:
[pod/llm-uservice20241218190439-5b9b7b79fd-r65l9/llm-uservice20241218190439]
...
   File "/home/user/comps/llms/faq-generation/tgi/langchain/llm.py", line 77, in stream_generator
     from langserve.serialization import WellKnownLCSerializer
   File "/home/user/.local/lib/python3.11/site-packages/langserve/__init__.py", line 8, in <module>
     from langserve.client import RemoteRunnable
   File "/home/user/.local/lib/python3.11/site-packages/langserve/client.py", line 24, in <module>
     from httpx._types import AuthTypes, CertTypes, CookieTypes, HeaderTypes, VerifyTypes
 ImportError: cannot import name 'VerifyTypes' from 'httpx._types' (/home/user/.local/lib/python3.11/site-packages/httpx/_types.py)

=> requirements.txt for llm-faqgen-tgi:latest image generation is not up to date in Comps repo?
@lianhao?

Rebased to main + dropped "draft" status, as the required OPEA image is now available in DockerHub!

CI still fails.
PR https://github.com/opea-project/GenAIInfra/pull/659 fixes DocSum issues with updates in other repos, includes the same model ID workaround as this one, and passed CI => better to merge that first & rebase this?

"docsum, gaudi, ci-gaudi-vllm-values" fails because CI registry is out of date.  Although required image has been at DockerHub for 4 days [1], fetching it still fails:
Normal   BackOff    4m47s (x18 over 9m42s)  kubelet            Back-off pulling image "<IP_ADDRESS>:5000/opea/llm-docsum-vllm:latest"
[1] https://hub.docker.com/r/opea/llm-docsum-vllm/tags
"docsum, xeon, ci-values" fails to connection failure:
[pod/docsum20241230125518-5599c984c6-dt5fc/docsum20241230125518] aiohttp.client_exceptions.ClientConnectorError: Cannot connect to host <IP_ADDRESS>:7066 ssl:default [Connect call failed ('<IP_ADDRESS>', 7066)]
...
testpod: Response check failed, please check the logs in artifacts!

"docsum, gaudi, ci-gaudi-tgi-values" fails to similar CI issue:
[pod/docsum20241230130614-d598c6674-qqhjf/docsum20241230130614] aiohttp.client_exceptions.ClientConnectorError: Cannot connect to host <IP_ADDRESS>:7066 ssl:default [Connect call failed ('<IP_ADDRESS>', 7066)]
...
testpod: Response check failed, please check the logs in artifacts!


First index of a number in array using java

Description

This code works properly.
This code is modular and flexible
I have commented some part of the code for better understanding
I have solved the issue using java

Fixes #1689
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Checklist:

[ ] My code follows the style guidelines(Clean Code) of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] My changes generate no new warnings
[ ] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works

@Himanshu-Shinde place it in proper folder


Synology: Can't access path/files

Hi. I've set the app on my NAS and it's running and accessible on port 5800. However, I can't actually use Handbrake because none of the directories where my files are are accessible to Handbrake. For example, when I click "Open Source", I get this:

I can go up a level and get this:

I set the Mount Path and a folder is created here instead of at the File/Folder location I set here:

I assumed that I should point Handbrake at a watch folder on my NAS, but the above path isn't checked and isn't used when I click "Open Source". So basically, Handbrake in it's Docker container can't access anything outside of it. Is there a setting here I'm missing?

Are you sure the container has read/write permissions to this folder?  Make sure you properly configured the USER_ID and GROUP_ID environment variables and/or the folder on Synology has the correct permissions/ownership.
Also, if you intend to use the folder as a watch folder, you are better to map it to /watch in the container.

Yes the USER_ID and GROUP_ID are correct.

I set it up based on this video: https://www.youtube.com/watch?v=E6HgHsxdWIo
Is there something not covered in that video I need to do?
Yes, I want to use that folder as a watch folder, but I don't see where in the container settings this is set.

To check if USER_ID and GROUP_ID are correct, you also need to check what is the ownership and permissions of Downloads/Handbrake.  You can run ls -lsd /volume1/Downloads/Handbrake for that.
If you want to use Downloads/Handbrake as a watch folder, you should map it to /watch instead of /Handbrake-Input under the Volume tab.

Yes, the user ID and group ID are correct. This is what I get when I check that directory:
0 drwxrwxrwx+ 1 admin users 60 Jun 27 08:15 Handbrake
I think I mapped the watch folder correctly:

What is the output of the following command:
docker exec <container name> ls -l /

Got permission denied while trying to connect to the Docker daemon socket at unix:///var/run/docker.sock: Get "http://%2Fvar%2Frun%2Fdocker.sock/v1.24/containers/jlesage-handbrake1/json": dial unix /var/run/docker.sock: connect: permission denied

You probably need to run the command with sudo:
sudo docker exec <container name> ls -l /

I've had similar issues with Docker in the past, try adding the "Everyone" group with Read permissions to the folder if it's still not displaying any contents.
Even though you have specified both IDs it just sometimes needs it.

Closing this issue.  Please re-open if needed.


Update compressx extension

Description
Update README.md so that the Overview section in https://www.raycast.com/hieudinh/compressx can be displayed
Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Really appreciated 🙏


DBZ-1076 Postgresql ARRAY support

DBZ-1076 Postgresql ARRAY support

@gunnarmorling and @jpechane can you help me with bug which leading to build fail in travis. I will be adding the other ranges on the basis of this. I think the changes that I have made are ok so please take a look at this whenever you are free. Thanks

@gunnarmorling I have added the support for int4range array and int8range array. It is good to merge now and ragrading the isuue I guess most of the types are covered now the only left one in range type  is numrange. I have added some part for numrange too but its commented for now as it was giving me some bugs in travis build.

@gunnarmorling Fine for me, applying. @ShubhamRwt Thanks!

We'd still need the doc update for that; @ShubhamRwt, would you be up for the task? Thanks a lot!

Yes sure @gunnarmorling. I will do that.

Thanks!

@gunnarmorling should I create a different section/table for the range types or should I add it in the data type table?


[Feature]: Add jest version to TransformOptions

🚀 Feature Proposal
Add current running jest major version to TransformOptions.
Motivation
https://github.com/facebook/jest/pull/12638 introduced a breaking change to the jest transformers API.
In general I think that this change does not worth it, and I would consider reverting it.
It has cupule awkward side effects:

Everyone must release a new major version of their transformers.
You must maintain two codebases* to support jest <27 and jest >28 for such a simple condition.

This proposal will provide a way to mitigated the bad effects by allowing the transformer author to take the jest version into consideration.
If TransformOptions would have the jest version (or the "transformers API version") one would able query what to return.
This way you will able to keep a single codebase to support both major versions.
This is the least amount of work I can think of from jest side.
*(entries | major versions | files)
Example
function createTransformer() {
  return {
    process(sourceText, sourcePath, options) {
      if (options.version > 27) {
        return {
          code: sourceText,
        };
      } else {
        return sourceText;
      }
    },
  };
}

Pitch
The transform system belongs to jest.

Actually I didn't notice when this feature introduced. for my use case only >2% of our projects uses older version then 22.
Now I just return the object. problem solved for me.
I still think it can be helpful to know in what version you are currently running, unfortunately I will not able to open PR soon.


Avoid deprecation warnings in User

There were still two calls to User#whois in User that caused deprecation warnings.

Thanks.


Clear the Cloudflare cache every time I push to main

Alternatively, just don't have the same caching policy on usdgal.ianj

Not necessary now that the project is hosted on own domain


Validate against draft 20

http://tools.ietf.org/html/draft-ietf-oauth-json-web-token-20
Not sure if contributions have kept us up to date, but we should double check and if it is update to date, the readme could use an update as to which spec it follows.

We have now all claims implemented and all algorithms. I think we can close this issue now. :)


[Feature Request:] Setting kubernetes context

Contact Details
<EMAIL_ADDRESS>Is your feature request related to a problem? Please describe.
A way to set kubernetes context as an argument in kubeshark CLI
Original Thread
No response
Describe the solution you'd like to see
Example:
kubeshark tap -A --set-context minikube
Provide additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I would like to work on this issue, @alongir

Sounds great! Adding @mertyildiran to chime in.

@26tanishabanik you can change the context using kubectl config set-context ref page. Kubeshark gets the context from the kubeconfig file. If you think there is a merit to change the context without altering the global setting then feel free to implement the option.

@26tanishabanik OK, feel free to open a pull request which adds that option.

@mertyildiran , can you please guide me for a starting point regarding this issue?


util: moving more cases to non-throwing unpackTo

Risk Level: low
Testing: updated tests
Docs Changes: n/a
Release Notes: n/a
https://github.com/envoyproxy/envoy-mobile/issues/176

ping!


Saving picture does not work on Firefox

Version: "Mozilla/5.0
(X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0"

For now, we should display to Firefox users that only Chrome is officially supported.

Fixed by commit 23d10ade1fc999e9bb7fb16ead13686a000ac77e


Conversation Support

This will most likely be an extension of this SDK.
Some references to consider from the community.

https://github.com/irazasyed/telegram-bot-sdk/issues/533

@irazasyed
Dialogs/Conversations develop as a separate package https://github.com/koot-labs/telegram-bot-dialogs (works on v3.1+) (I'm a maintainer)


Support the latest version of Factions.

Fix code-style.

 I've added you to the project so you can push directly in future :)
What is your Bukkitdev user so I can add you there?

@jastice my bukkitdev account is nikosgram17 :D


Create a non-compacting compaction as a way to move files

Is your feature request related to a problem? Please describe.
A compaction reduces many files to one. During this process the input files are read, an output file is created (maybe on a different volume), and the tablet metadata is updated appropriately. There is a case where a user may want to move files from one volume to another, and the compaction mechanism is the only way to do it. However, performing a compaction can be resource intensive depending on the iterators involved.
Describe the solution you'd like
Create a new major compaction-like task that performs the same overall process, but instead of reducing the input files, just copy the files input files to output files. Instead of being many to one operation, this would be a one to one operation. As an optimization, the copy could be done below the RFile level to just copy the underlying file from the Volume.

I can take a look at this


slack: 4.9.0 -> 4.10.0

Motivation for this change
Bump Slack to latest release: 4.10.0
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

can you please bump all of them?

can you please bump all of them?

There is no release for Linux yet, it is only MacOS

Linux 4.9.1: https://slack.com/intl/es-es/release-notes/linux
MacOS: https://slack.com/intl/es-es/release-notes/mac

@mmahut They have just released 4.10.0 for Linux too. I just updated the PR to update both :+1:

Thank you!
@GrahamcOfBorg eval

@mmahut version 4.10.3 is available. Do you want me to update this PR or open a new one?

@mmahut I just updated this PR to the latest 4.10.3 version

You rocks.
@GrahamcOfBorg build slack

@GrahamcOfBorg build slack


Nested link fix

links inside  weren't working, now they are.
e.g
link me
- was doing -> **link me**
- now doing -> **[link me](http://example.com)**

added a test case too.

oops, accidentally cluttered git history with bundle, I reverted it but can do a cleaner PR if it's a big deal

roger, will clean it up this evening!

Yeah sorry about the delay, was trying to get it over the line while waiting for a batch job to finish but got sucked back into it before i could finish, and my brain is currently mush for at least another day or so. Will complete asap. Love this lib btw, got a ton of other ideas to pitch you on. Expect more PRs :)

update: haven't forgotten, just swamped... might not be able to sit down with this until the weekend. In the spirit of honesty, claude wrote the initial PR because I just needed the problem solved and I'm using esm.sh pointed at my forked repo to unblock my work. I suppose this makes a good little case study on llm codegen being "technically correct" without regard for the bigger picture.

closing in favor of new pr


what is the lowest vram i can train flux lora?

Currently 24GB

i was reading on reddit that kohya_ss is supporting 12GB vram. what magic they did which you did not?

@jaretburkett

Probably text encoder embedding caching and 4bit quantization.

@jaretburkett  when are you doing all that?

It is not planned at this time. Please keep issues for bugs only, and move general discussions to the discord.

ok i will move to discord. but do this fast. asap. im from china, your code is very popular here. cant say the name, but big companies using it for actual products

@jaretburkett


[Bug]: Icons partially cut off

Checklist

[X] I have read the appropriate section in the contributing guidelines
[X] I believe this issue is a problem with polybar itself and not a misconfiguration on my part
[X] I have searched for other open and closed issues that may have already reported this problem
[X] I have checked the known issues page for this problem.
[X] I have followed the debugging guide to narrow down the problem to a minimal config.

Steps to reproduce
I am using Polybar on an Asus Vivobook Laptop, my wm is i3 and my platform is Arch.
I have installed the wm and polybar a couple month ago, and right from the beginning some of the icons appear cut off, showing practically only 50% of it. In the screenshot, the tiem icon is visibly cut  in half ... whereas the sound icon is unaffected.
It seems the icon are affected randomly...
Any idea how to solve this?

Minimal config
[colors]
background = #282A2E
background-alt = #373B41
foreground = #C5C8C6
primary = #F0C674
secondary = #8ABEB7
alert = #A54242
disabled = #707880

[bar/mybar]
width = 100%
height = 24pt
radius = 6

; dpi = 96

background = ${colors.background}
foreground = ${colors.foreground}

line-size = 3pt

border-size = 4pt
border-color = #00000000

padding-left = 0
padding-right = 1

module-margin = 1

separator = |
separator-foreground = ${colors.disabled}

font-0 = monospace;2

modules-left = xworkspaces xwindow
modules-center = pulseaudio pacman-updates
modules-right = filesystem  xkeyboard memory cpu wlan eth date

cursor-click = pointer
cursor-scroll = ns-resize

enable-ipc = true

; tray-position = right

; wm-restack = generic
; wm-restack = bspwm
; wm-restack = i3

; override-redirect = true

[module/pacman-updates]
type = custom/script
format-prefix = "UPDATES "
format-prefix-foreground = ${colors.primary}
exec = checkupdates | wc -l
label = %output%
label-background = ${colors.alert}
label-padding = 4
;label = updates %output%
; "content" has the same properties as "format-NAME"
content-background = #000
content-foreground = #fff
content-padding = 4

;type = custom/script
;exex = checkupdates | wc -l
;interval = 1000
;label-active = updates %output%
;format.foreground = ${colors.foreground}
;format.foreground = #453456
;
;format-prefix = "try"
;format-prefix-foreground = #ff0000

[module/xworkspaces]
type = internal/xworkspaces

label-active = %name%
label-active-background = ${colors.background-alt}
label-active-underline= ${colors.primary}
label-active-padding = 1

label-occupied = %name%
label-occupied-padding = 1

label-urgent = %name%
label-urgent-background = ${colors.alert}
label-urgent-padding = 1

label-empty = %name%
label-empty-foreground = ${colors.disabled}
label-empty-padding = 1

[module/xwindow]
type = internal/xwindow
label = %title:0:60:...%

[module/filesystem]
type = internal/fs
interval = 25

mount-0 = /

label-mounted = %{F#F0C674}%mountpoint%%{F-} %percentage_used%%

label-unmounted = %mountpoint% not mounted
label-unmounted-foreground = ${colors.disabled}

[module/pulseaudio]
type = internal/pulseaudio

format-volume-prefix = "VOL "
format-volume-prefix-foreground = ${colors.primary}
format-volume = <label-volume>

label-volume = %percentage%%

label-muted = muted
label-muted-foreground = ${colors.disabled}

[module/xkeyboard]
type = internal/xkeyboard
blacklist-0 = num lock

label-layout = %layout%
label-layout-foreground = ${colors.primary}

label-indicator-padding = 2
label-indicator-margin = 1
label-indicator-foreground = ${colors.background}
label-indicator-background = ${colors.secondary}

[module/memory]
type = internal/memory
interval = 2
format-prefix = "RAM "
format-prefix-foreground = ${colors.primary}
label = %percentage_used:2%%

[module/cpu]
type = internal/cpu
interval = 2
format-prefix = "CPU "
format-prefix-foreground = ${colors.primary}
label = %percentage:2%%

[network-base]
type = internal/network
interval = 5
format-connected = <label-connected>
format-disconnected = <label-disconnected>
label-disconnected = %{F#F0C674}%ifname%%{F#707880} disconnected

[module/wlan]
inherit = network-base
interface-type = wireless
label-connected = %{F#F0C674}%ifname%%{F-} %essid% %local_ip%

[module/eth]
inherit = network-base
interface-type = wired
label-connected = %{F#F0C674}%ifname%%{F-} %local_ip%

[module/date]
type = internal/date
interval = 1

date = %H:%M
date-alt = %Y-%m-%d %H:%M:%S

label = %date%
label-foreground = ${colors.primary}

[settings]
screenchange-reload = true
pseudo-transparency = true

Polybar log
No response
Expected behavior
Icon appear with their complete shape
Actual behavior
Icons are partially cut off
Window Manager and Version
i3
Linux Distribution
Arch with latest updates
Polybar version
polybar 3.6.3

Additional Context / Screenshots

This very much looks like a duplicate of #991.
Also, the config you posted is not the one used in the screenshot.

hi, it was indeed a problem with the nerd font ... changing it to Mono solved the problem


./build_all_linux.sh

Click to expand!
Issue Type
Bug
Source
source
Tensorflow Version
tf1.15
Custom Code
No
OS Platform and Distribution
ubuntu18.04
Mobile device
ubuntu18.04
Python version
python==3.6.13
Bazel version
0.26.1
GCC/Compiler version
7.5
CUDA/cuDNN version
CPU
GPU model and memory
CPU
Current Behaviour?
A bug happened!

tensorflow/contrib/makefile# ./build_all_linux.sh

  inflating: /tmp/tmp.8jIp3DIvsk/gemmlowp-12fed0cd7cfcd9e169bf1925bc3a7a58725fdcc3/test/ios/gemmlowp_test/AppDelegate.h
  inflating: /tmp/tmp.8jIp3DIvsk/gemmlowp-12fed0cd7cfcd9e169bf1925bc3a7a58725fdcc3/test/ios/gemmlowp_test/AppDelegate.mm
   creating: /tmp/tmp.8jIp3DIvsk/gemmlowp-12fed0cd7cfcd9e169bf1925bc3a7a58725fdcc3/test/ios/gemmlowp_test/Base.lproj/
  inflating: /tmp/tmp.8jIp3DIvsk/gemmlowp-12fed0cd7cfcd9e169bf1925bc3a7a58725fdcc3/test/ios/gemmlowp_test/Base.lproj/LaunchScreen.xib
  inflating: /tmp/tmp.8jIp3DIvsk/gemmlowp-12fed0cd7cfcd9e169bf1925bc3a7a58725fdcc3/test/ios/gemmlowp_test/Base.lproj/Main.storyboard
   creating: /tmp/tmp.8jIp3DIvsk/gemmlowp-12fed0cd7cfcd9e169bf1925bc3a7a58725fdcc3/test/ios/gemmlowp_test/Images.xcassets/
   creating: /tmp/tmp.8jIp3DIvsk/gemmlowp-12fed0cd7cfcd9e169bf1925bc3a7a58725fdcc3/test/ios/gemmlowp_test/Images.xcassets/AppIcon.appiconset/
  inflating: /tmp/tmp.8jIp3DIvsk/gemmlowp-12fed0cd7cfcd9e169bf1925bc3a7a58725fdcc3/test/ios/gemmlowp_test/Images.xcassets/AppIcon.appiconset/Contents.json
  inflating: /tmp/tmp.8jIp3DIvsk/gemmlowp-12fed0cd7cfcd9e169bf1925bc3a7a58725fdcc3/test/ios/gemmlowp_test/Info.plist
  inflating: /tmp/tmp.8jIp3DIvsk/gemmlowp-12fed0cd7cfcd9e169bf1925bc3a7a58725fdcc3/test/ios/gemmlowp_test/ViewController.h
  inflating: /tmp/tmp.8jIp3DIvsk/gemmlowp-12fed0cd7cfcd9e169bf1925bc3a7a58725fdcc3/test/ios/gemmlowp_test/ViewController.m
  inflating: /tmp/tmp.8jIp3DIvsk/gemmlowp-12fed0cd7cfcd9e169bf1925bc3a7a58725fdcc3/test/ios/gemmlowp_test/main.m
  inflating: /tmp/tmp.8jIp3DIvsk/gemmlowp-12fed0cd7cfcd9e169bf1925bc3a7a58725fdcc3/test/test.cc
  inflating: /tmp/tmp.8jIp3DIvsk/gemmlowp-12fed0cd7cfcd9e169bf1925bc3a7a58725fdcc3/test/test.h
  inflating: /tmp/tmp.8jIp3DIvsk/gemmlowp-12fed0cd7cfcd9e169bf1925bc3a7a58725fdcc3/test/test_allocator.cc
  inflating: /tmp/tmp.8jIp3DIvsk/gemmlowp-12fed0cd7cfcd9e169bf1925bc3a7a58725fdcc3/test/test_blocking_counter.cc
  inflating: /tmp/tmp.8jIp3DIvsk/gemmlowp-12fed0cd7cfcd9e169bf1925bc3a7a58725fdcc3/test/test_data.cc
  inflating: /tmp/tmp.8jIp3DIvsk/gemmlowp-12fed0cd7cfcd9e169bf1925bc3a7a58725fdcc3/test/test_data.h
  inflating: /tmp/tmp.8jIp3DIvsk/gemmlowp-12fed0cd7cfcd9e169bf1925bc3a7a58725fdcc3/test/test_fixedpoint.cc
  inflating: /tmp/tmp.8jIp3DIvsk/gemmlowp-12fed0cd7cfcd9e169bf1925bc3a7a58725fdcc3/test/test_math_helpers.cc
   creating: /tmp/tmp.8jIp3DIvsk/gemmlowp-12fed0cd7cfcd9e169bf1925bc3a7a58725fdcc3/todo/
  inflating: /tmp/tmp.8jIp3DIvsk/gemmlowp-12fed0cd7cfcd9e169bf1925bc3a7a58725fdcc3/todo/armv8-64bit-kernel-for-less-than-8-bit.txt
  inflating: /tmp/tmp.8jIp3DIvsk/gemmlowp-12fed0cd7cfcd9e169bf1925bc3a7a58725fdcc3/todo/error-diffusion-experiments.txt
  inflating: /tmp/tmp.8jIp3DIvsk/gemmlowp-12fed0cd7cfcd9e169bf1925bc3a7a58725fdcc3/todo/fast-gemv.txt
  inflating: /tmp/tmp.8jIp3DIvsk/gemmlowp-12fed0cd7cfcd9e169bf1925bc3a7a58725fdcc3/todo/less-than-8-bit-without-requantization.txt
  inflating: /tmp/tmp.8jIp3DIvsk/gemmlowp-12fed0cd7cfcd9e169bf1925bc3a7a58725fdcc3/todo/multi-threading-experiments.txt
  inflating: /tmp/tmp.8jIp3DIvsk/gemmlowp-12fed0cd7cfcd9e169bf1925bc3a7a58725fdcc3/todo/neon-depth-major-sources-packing.txt
  inflating: /tmp/tmp.8jIp3DIvsk/gemmlowp-12fed0cd7cfcd9e169bf1925bc3a7a58725fdcc3/todo/remove-default-template-param-values.txt
  inflating: /tmp/tmp.8jIp3DIvsk/gemmlowp-12fed0cd7cfcd9e169bf1925bc3a7a58725fdcc3/todo/x86-kernels.txt
downloading https://github.com/google/googletest/archive/refs/tags/release-1.8.0.tar.gz

gzip: stdin: unexpected end of file
tar: Child returned status 1
tar: Error is not recoverable: exiting now

Standalone code to reproduce the issue
tensorflow/contrib/makefile# ./build_all_linux.sh

gzip: stdin: unexpected end of file
tar: Child returned status 1
tar: Error is not recoverable: exiting now

Relevant log output
tensorflow/contrib/makefile# ./build_all_linux.sh

gzip: stdin: unexpected end of file
tar: Child returned status 1
tar: Error is not recoverable: exiting now

@KangChou We see that you are using the older version(1.15) of TF which is not actively supported.We recommend you to kindly upgrade to the latest TF versions(2.4 or later) and let us know if you still face any issue.
Could you please have a look at this link and refer the tested build configurations?
Please let us know if it helps?
Thanks!

@KangChou We see that you are using the older version(1.15) of TF which is not actively supported.We recommend you to kindly upgrade to the latest TF versions(2.4 or later) and let us know if you still face any issue. Could you please have a look at this link and refer the tested build configurations? Please let us know if it helps? Thanks!

hell0.    I have solved the problem by manually downloading the 3rd party. @sushreebarsa

@KangChou Glad it is working for you .
Could you please move this issue to closed status if it resolved for you?
Thanks!

@KangChou Glad it is working for you . Could you please move this issue to closed status if it resolved for you? Thanks!

OK.

Closing this issue as it is resolved. Please feel free to reopen the issue if you still have a concern. Thanks!


Fixed #32581 -- Prevented to_locale() from corrupting locale names.

@claudep Thanks :+1: I pushed extra assertions to a separate commit.

Fine!


Add shard field to ShardBlock

Issue
Per #1850 point 2, add shard to ShardBlock.
How did I solve it

Add add shard to ShardBlock and ShardBlockHeader.
Add verification in verify_shard_block_message.

/cc @terencechain

Looks good to me!


repo sync

@<!--
Thank you for contributing to this project! You must fill out the information below before we can review this pull request. By explaining why you're making a change (or linking to a pull request) and what changes you've made, we can triage your pull request to the best possible team for review.
See our CONTRIBUTING.md for information how to contribute.
For changes to content in site policy, see the CONTRIBUTING guide in the site-policy repo.
We cannot accept changes to our translated content right now. See the contributing.md for more information.
Thanks again!
-->
Why:

Closes [issue link]
What's being changed:

Check off the following:

[x] I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
[ ] For content changes, I have reviewed the localization checklist
[ ] For content changes, I have reviewed the Content style guide for GitHub Docs.

Please leave this repo-sync branch to the robots! 😊
I'm going to close this pull request now, but feel free to open a new issue or ask any questions in discussions!


Rewriten some stuff

please dm me if i got something wrong
i didnt add any images

why did you modify a bunch of other files


fix race condition

revert to original logic, with minor optimization to restart
message processing if atomic CAS succeeds

TY!


Conform

Transparency is key
Honesty is not a option when dealing with the laws of the United States

I don't see any HIPPA here


enable windows cuda test on vision

Fix #4006

@NicolasHug ,
what's the usage  of test_lol() in #4005?

Hi @mszhanyi , thanks for giving this a try! Definitely a tricky issue.
test_lol() is just a dummy test to check what torch.cuda.is_available()  returns. It should definitely be removed once we're sure everything is working properly! Currently, the unittest_windows_gpu check doesn't seem to have cuda still, so unfortunately the fix isn't working yet https://app.circleci.com/pipelines/github/pytorch/vision/9041/workflows/ccac1378-ce3a-41a3-b3f3-1b160aac418a/jobs/660219.

The progress are:

It looks that torch with cuda 11.1 can be installed successfully in nightly channel. but vision failed to build with cuda11.1 @NicolasHug
https://app.circleci.com/pipelines/github/pytorch/vision/9123/workflows/0825ab5a-2db6-4337-bf51-a2bd5d73a7c2/jobs/666795

With cuda10.2, there's always No CUDA Runtime is found,... when running python setup.py install.

There's some issue on https://github.com/pytorch/vision/blob/562b8463bcce05a958023cfe9c2e72185cb804d8/packaging/windows/internal/cuda_install.bat#L198 @peterjc123 @seemethere
It look all versions of cuda use the same gpu_driver_dlls.zip.  Nvidia-smi always show 10.2 if it works.
In fact, it did't work because overwriting mode (-aoa) wasn't added.

3. It look all versions of cuda use the same gpu_driver_dlls.zip.  Nvidia-smi always show 10.2 if it works.
In fact, it did't work because overwriting mode (-aoa) wasn't added.

This was an ancient workaround to fix the situation that the CUDA variant of PyTorch rejects to load itself on a CPU-only agent. We fixed that in PyTorch 1.6. Just feel free to remove that.

@NicolasHug
Why it is SKIPPED?
test/test_backbone_utils.py::test_lol SKIPPED (We're in a CircleCI G...)
https://app.circleci.com/pipelines/github/pytorch/vision/9185/workflows/d9b405fb-4661-4a60-ab39-be8ca4a66ccf/jobs/672271

Oh, that's good news, it means cuda.is_available() is True on Windows now.
Long story short: tests that don't require cuda are skipped on GPU CI machines to save computation resources. You can find more details at https://github.com/pytorch/vision/blob/master/test/conftest.py#L16
test_lol() doesn't need cuda, so it's skipped. To indicate that the test needs cuda you can do:
from common_utils import needs_cuda

@needs_cuda
def test_lol():
    ...

And it should be properly run on GPU machines. Note that this means that the test will actually be skipped on CPU CIs (because we also skip cuda tests on CPU-only machines), but that's fine.

@seemethere , I have to readd conda-forege because it always fail to install pytorch in CI though it can work on my local machine
https://github.com/pytorch/vision/blob/7b16be5a5cca467e368e6a09b42d37f7fd0ca5d4/.circleci/unittest/windows/scripts/install.sh#L29
https://app.circleci.com/pipelines/github/pytorch/vision/9201/workflows/e81a8161-78cf-4d30-bd20-759d6f543760/jobs/673629.

Thanks a lot @mszhanyi !!
The changes on the unittest side LGTM, but I'm wondering if we also need the changes on the binary_win jobs?
Also, it looks like the nvjpeg library isn't discovered by our setup.py on windows now, which is why the unittest_windows_gpu tests are failing.
This is how we currently try to guess whether nvjpeg is available, but it doesn't seem to work on windows:
https://github.com/pytorch/vision/blob/850491eb9c3daff887468718bfa1f90f94042d9d/setup.py#L319-L325
Would you know how to make this work?

@NicolasHug it should work now! https://app.circleci.com/pipelines/github/pytorch/vision/9251/workflows/e3fe3595-8b8e-4d7c-b4e0-00d2955449c1/jobs/677950

Hm, it seems like the failures on the binary_win_ jobs are related

@mszhanyi I wonder if the fix could be something as simple as what is done in https://github.com/pytorch/ignite/pull/2075/files, e.g. just install the new driver?

@mszhanyi I wonder if the fix could be something as simple as what is done in https://github.com/pytorch/ignite/pull/2075/files, e.g. just install the new driver?

No.
Besides installing the new driver, we need to set the right envs that code can find the right cuda.
But set envA=XXX only change the envs for current scripts.
https://github.com/mszhanyi/vision/blob/d297479d76e77e1bff1a77a075258ab0e4961946/packaging/windows/internal/cuda_install.bat#L195-L199.
The default system envs are still cuda10.1, installed in the circle CI image.
In your workflow, cuda_install, build and test are running as individual scripts, and save/restore cache might restore the default envs. So I have to redefine the cuda envs before python setup.py develop and test to ensure findpackage(cuda) get the right cuda. I don't plan to rewrite the whole workflow.
I write some nvidai-smi (check cuda driver version)and nvcc --version (cuda runtime version) in the script. If you're free, you could comment my set_cuda_envs to see which cuda version are used.

Correct me if I'm wrong, but this change PR seems to be superseded by https://github.com/pytorch/vision/pull/4145


Add plugin support for other templates languages

I've thought this through, and I think Roslyn C# script plugins make the most sense. (also to make it work with DLLs you'd have to publish OrchardCoreContrib.PoExtractor.Abstractions to NuGet as a separate library package - probably not worth the effort) I've included a unit test and sample plugin that hopefully gets the point across without being too niche. (The important change is in the Program.ProcessPluginsAsync method, the rest is just plumbing.)
Fixes #101

I just looked into the PR and noticed a dependency on Program.cs which is wrong for me. IMHO exposing the IProjectProcessor will make the tool extendable. I am still thinking if we need the -p or if we can make the tool open some possibilities for the others to add their own options
Let me hear your feedback on this

I just looked into the PR and noticed a dependency on Program.cs which is wrong for me.

If you mean the ScriptOptions.Default.AddReferences(typeof(Program).Assembly) here, I've only used Program to expose all the libraries to the script the tool has already loaded. As I see it, this is not a security application so we can be very permissive.
For example this way the script has access to OrchardCoreContrib.PoExtractor.DotNet.CS too, not just OrchardCoreContrib.PoExtractor.Abstractions. If someone wants to have a different take on one of the existing processors, this could be a way to have your own custom (more opinionated) solution without it affecting the main repo, while re-using the auxiliary classes that are already in those projects. I don't see the harm in it, so could you explain why it's wrong for you?

IMHO exposing the IProjectProcessor will make the tool extendable.

I think it's not possible to expose just one type, you have to expose its whole assembly. We can change the above linked code to only expose OrchardCoreContrib.PoExtractor.Abstractions instead of everything, but that feels unnecessarily restrictive.

I am still thinking if we need the -p or if we can make the tool open some possibilities for the others to add their own options.

Sorry, I don't really understand. This -p approach is the simplest way to add broad extensibility that I could think of, while being less maintenance in your code base. If you want something more elaborate without the need to use a command line switch we can discuss, but I'm not sure if it's really necessary.

Also by importing Program's assembly the plugin developer will have access to all the of external dependencies PoExtractor has already loaded. For example if I only included the OrchardCoreContrib.PoExtractor.Abstractions, then the example plugin will fail with the following error:

error CS0234: The type or namespace name 'Json' does not exist in the namespace 'System.Text' (are you missing an assembly reference?)

So now I'd have to include #r "nuget: System.Text.Json, 9.0.0"  at the start of the script, and NuGet may have to download this version if it gets out of sync from what the tool itself uses. This is annoying imo.

@hishamco Have you seen my replies? This is not super urgent yet but it would be good if we could have a solution before year's end, because we might need it next month.

I didn't look into the last comment, but the PR is opened in one tab, so I need to revise it today or tomorrow to proceed

Hi @hishamco , any news with this?

@sarahelsaig Sorry for the late, I revised the code one more time still worried about the impact of dynamic linking, so I'm thinking for two simple approaches:

Creating OrchardCoreContrib.PoExtractor.VueJs directly in the repo
Reference Lombiq.VueJs to OrchardCoreContrib.PoExtractor

While this repo is Orchard Core Contrib it SHOULD help any OC project, I might think the first option is better, but I need to hear your feedback. Also, I will think for the last time about dynamic linking and its drawbacks

Can you explain what is your worry about dynamic linking? What are the drawabacks? I don't see any impact unless you manually opt-in by using the command line switch. Otherwise I think it's safe with only very minimal overhead. I see it as a transparent improvement.

this repo is Orchard Core Contrib it SHOULD help any OC project

I fully agree with this sentiment. Note that since my original PR, I have seen other highly project-specific opportunities where this feature could be useful. In both of the cases below I could use a PoExtractor plugin to centralize other localization tech so OC can manage the actual localization and then serve it back to the associated tech. This will reduce the number of tools for the staff to learn to do the translations, and make complete translation management easier and safer.

We have a client project that uses OC as a headless server with a complementing node.js frontend. We could harvest the english l18n JSON files used by the frontend (similarly to the example plugin in this PR) and then serve back the other languages.
In the same project we also have to use a XSLT to generate some visualizations (it's a legal requirement). For now we manually maintain XML translation files for the languages we need in the MVP, but having a third localization tech in the project just for one small feature is very annoying.

I don't think we should create OrchardCoreContrib.PoExtractor.VueJs, not other OrchardCoreContrib.PoExtractor projects for the use-cases I mentioned above. This would quickly bloat your repo.

Reference Lombiq.VueJs to OrchardCoreContrib.PoExtractor

I'm not sure if I understand. If you mean using OrchardCoreContrib.PoExtractor as a library inside Lombiq.VueJs, your existing NuGet tool package doesn't make it possible. Even if you released a NuGet library package it would be pointlessly cumbersome to use in my opinion.


Sawtooth RFC for Docker Build and Execution in a Proxy Environment

Signed-off-by: danintel<EMAIL_ADDRESS>This PR submits the Docker proxy RFC after final reviews and modifications by everyone interested with the Google Doc:
https://docs.google.com/document/d/1Xux_qbx8edu5_bWYZsnfr7p5JoC3ZpPCaoDhhykChno/edit

I updated the RFC to use ~/.docker/config.json after testing it and getting it working.
The tricky part was making sure the Docker internal networks were included in noProxy.

I like where where this has gone--less proxy support within the docker files themselves, but specific information on how to setup the proxy configuration.
The majority of the RFC contains explanation on how to use docker, instead of changes we need to make with Sawtooth. The changes are to remove what we currently have for proxy support. Do we still want to move forward with the RFC (which would now be an RFC to not have explicit proxy support), or should we just move forward with PRs to simplify the files and document how to setup proxy (which could be derived from the text of this RFC).

Yes, I want to move forward as a RFC. The one part where (minor) changes are still needed is for key servers. The rest is good for informational reasons.
Follow-up would be removing unneeded proxy configuration/passthrough in Docker files, as they are found.
Dan
From: Shawn T Amundson<EMAIL_ADDRESS>Sent: Tuesday, July 2, 2019 10:04 AM
To: hyperledger/sawtooth-rfcs<EMAIL_ADDRESS>Cc: Anderson, Daniel<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [hyperledger/sawtooth-rfcs] Sawtooth RFC for Docker Build and Execution in a Proxy Environment (#45)
I like where where this has gone--less proxy support within the docker files themselves, but specific information on how to setup the proxy configuration.
The majority of the RFC contains explanation on how to use docker, instead of changes we need to make with Sawtooth. The changes are to remove what we currently have for proxy support. Do we still want to move forward with the RFC (which would now be an RFC to not have explicit proxy support), or should we just move forward with PRs to simplify the files and document how to setup proxy (which could be derived from the text of this RFC).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/hyperledger/sawtooth-rfcs/pull/45?email_source=notifications&email_token=AH26URIFM25GYCFEGBJRPP3P5OC7ZA5CNFSM4HZKS2IKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZB5YMI#issuecomment-507763761, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AH26URJHOY4FXRMQH7VMBG3P5OC7ZANCNFSM4HZKS2IA.

I like where where this has gone--less proxy support within the docker files themselves, but specific information on how to setup the proxy configuration.
The majority of the RFC contains explanation on how to use docker, instead of changes we need to make with Sawtooth. The changes are to remove what we currently have for proxy support. Do we still want to move forward with the RFC (which would now be an RFC to not have explicit proxy support), or should we just move forward with PRs to simplify the files and document how to setup proxy (which could be derived from the text of this RFC)?

That seems like a valid reason for an RFC.. here's the architectural pattern we've adopted across all of the components and repos. We can refer to it to avoid inadvertent bikeshedding. It may be a little lighter weight than some of the other RFCs, but all the better if we can move things along expediently.

Can I get approvals here for this Proxy RFC now that the issues are resolved? I see one approval from Dan M.

I am still skeptical that this is appropriate material for an RFC but I approve of the direction this is taking and I will not disagree if the consensus is to codify this here.

I addressed all comments above for the proxy RFC. Let me know if there are more issues or questions.

I addressed new issues raised in the current round of comments.  So please take a look here.

Can you double check my comments here? https://github.com/hyperledger/sawtooth-rfcs/pull/45#discussion_r307814343
Looks like you removed the backup keyserver but my other concerns weren't addressed.

@rbysse I checked all your comments and made some changes.  If there are any more issues, please let me know which ones.  Here is a list:

Please include the gnupg link above in the RFC.
Added a link around line 42.

I'd prefer that this link to the official docker documentation rather than try to duplicate it in case the process changes in the future.
I deleted the text and replaced it with a link under "Guide-level explanation"
around line 62.

Can you move the docker documentation link to this section instead? It's relevant in this section, but not to the one below.
Same as above.

Is "* Minimize Docker..." meant to be its own bullet point?
Yes.  Now a separate line on line 52.

s/forth/fourth
Fixed at line 124.

* _I am still skeptical that this is appropriate material for an RFC but I approve of the direction this is taking and I will not disagree if the consensus is to codify this here._
OK. The docker-compose/apt-key adv/gpg interaction isn't really documented properly.

*_Since this RFC is going to become the reference document, I'd like to see this section be more concise and readable.  If we're adding retries, I think we can dispense with the backup keyserver. RUN apt-get update && apt-get install -yq curl gnupg2
RUN curl --retry 3 -sSL 'https://keyserver.ubuntu.com/pks/lookup?op=get&search=0x8AA7AF1F1091A5FD' | apt-key add -_

I added the backup keyserver from an earlier suggestion. I removed it again and now there is just the `--retry`

*_Also, this doesn't work unless gnupg2 is installed._
Package gnupg2 is just documentation under /usr/share/doc and /usr/share/info
See a previous comment for gnupg2 package contents.  Perhaps you mean gnupg?  But, I removed both gnupg and gnupg2 and was able to install keys with `apt-key add` and `apt-key add`.

I'm not sure how you're testing this, but the example code you have in the RFC doesn't work in docker.
Trying to build the following dockerfile:
FROM ubuntu:bionic

RUN \
 apt-get update && apt-get install -yq curl && curl --retry 3 -sSL \
    'http://keyserver.ubuntu.com/pks/lookup?op=get&search=0x8AA7AF1F1091A5FD' \
    | apt-key add -

Exits with error:
E: gnupg, gnupg2 and gnupg1 do not seem to be installed, but one of them is required for this operation
(23) Failed writing body
The command '/bin/sh -c apt-get update && apt-get install -yq curl && curl --retry 3 -sSL     'http://keyserver.ubuntu.com/pks/lookup?op=get&search=0x8AA7AF1F1091A5FD'     | apt-key add -' returned a non-zero code: 255

The suggestion I provided is more readable, breaking up the two operations into logical steps and it works.

@rbuysse I have no problem running Sawtooth and apt-get and apt-key without explicitly installing gnupg/gnupg2/gnupg1.  I just tried it on Ubuntu 18.04 LTS, docker-compose 1.24.1.
I also notice that none of the sawtooth-core (and no sawtooth-* repo I checked) ever installs gnupg2 or gnupg1.  Repo sawtooth-core installs gnupg, but that is documentation only, no binary.
So if package gnupg2 (or gnupg1) is required, why is no Sawtooth Dockerfile installing it?
Also, installing a key is required in both proxy and non-proxy environments and properly should be documented separately. I also notice that the Sawtooth documentation does not mention installing gnupg2:
https://sawtooth.hyperledger.org/docs/core/releases/latest/sysadmin_guide/installation.html
But there is something different about your environment from all others, so I am adding package gnupg2 to the list. However, this (apt-key dependencies) is really a non-proxy issue.
I updated the RFC so please have a look and approve it. Thanks

What happens when your run a Docker file containing just this:
FROM ubuntu:bionic

RUN \
 apt-get update && apt-get install -yq curl && curl --retry 3 -sSL \
    'http://keyserver.ubuntu.com/pks/lookup?op=get&search=0x8AA7AF1F1091A5FD' \
    | apt-key add -

as @rbuysse suggested?

Hi Dan, Gnupg does need to installed for secure apt to work or apt won't be able to verify the signed package. Since Ubuntu Bionic gnupg is not installed by default in the Docker images. Gnupg was added to sawtooth-core here. The gnupg package depends on gnupg-utils and gpg 2 among others and installing it results in a complete installation of gnupg.

@peterschwarz  It fails, but works when I add gnupg2
My guess is the other Docker instances are using pre-built images with gnupg2 previously installed.
In any case, I already updated the docs to specify gnupg2
The existing Sawtooth documentation should also be updated to mention that  one of gnupg2/gnupg1/gnupg is required. That is not done anywhere.
Again this is not a proxy issue and I already updated this RFC.

@rberg2 The PR has no documention updates. So the Sawtooth user/administrator is never told to install gnupg2 (or gnupg or gnupg1).
In any case this RFC mentions gnupg2 and is now ready to be approved.

I created a separate PR in sawtooth-core to add missing documentation about installing gnupg2 when installing Sawtooth. Please see https://github.com/hyperledger/sawtooth-core/pull/2222

Also I'd still like to see the docker example code cleaned up as mentioned in this comment: https://github.com/hyperledger/sawtooth-rfcs/pull/45#discussion_r307814343

@rbuysse Reading between the lines, I assume the important part of your comment is having two RUN stanzas, not one.  I updated the RFC to have two RUN stanzas.

@rberg2 I removed the comment about two keyservers.

We should either be clear that this applies only to the specific Ubuntu versions, or we should make it more principle-based so that it would apply to CentOS/RHEL as well.

@vaporos Ubuntu is specifically mentioned under "Summary". It does not apply to CentOS/RHEL as they do not use APT, at least in general.
I could emphasize the restriction more.


joined table using eloquent returns soft deleted rows

Laravel Version: 5.3
PHP Version: 7.0.8
Database Driver & Version: Mariadb

Description:
When I try to fetch rows from multiple tables using eloquent query, it also returns the soft deleted rows from the second joined table. Is there any option which can results only the non-deleted rows for joined query?
Steps To Reproduce:

Please share a code example.

I am using eloquent as below:
$result = SubcontractorDepartment::join('subcontractors as sc','sc.id','subcontractor_departments.subcontractor_id')->get();
Its also returning the rows which are softdeleted in the subcontractors table. Its working fine for subcontractor_departments table.
Is there any solution without using whereNull('deleted_at') ?

Yes because while joining you're not applying Eloquent constraints, if you decide to use joins you need to adjust the query manually and not rely on eloquent.


bustle: 0.9.2 -> 0.10.0

No changelogs provided<!--
Tested
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

Add a :+1: reaction to pull requests you find important.

The interface between dbus-monitor and dbus should be an internal interface, so there is no stability guarantee. We should rely on the dbus-monitor that comes with the system with dbus enabled.


restructuring: true is ruing the css

Since the last versions, the restructuring of the css changes the way things are displayed on the screen. A good example for this is the UI-Grid. When using the css after minify things looks different without the minification (started in version ~3).

Would you be able to point me to a more distilled test case? Does it affect all browsers, etc?

Yes, all web browsers.
Will try to create a plnker with the 2 versions to demonstrate the problem

Would be great! :+1:

@ezraroi any updates?

sorry, I had few private issues in the last 2 weeks. Will update soon I hope

Sure, no sweat, just wanted to make sure it's still an issue.

yes, still an issue, broke my project until i turned it off

Sorry to hear, but let's fix it.

Original CSS Plunker: http://plnkr.co/edit/7lwoNsLZkHGZnJBsJ6fQ?p=preview
Minifed CSS Plunker: http://plnkr.co/edit/EtylR4dw5TUuZiWuuARx?p=preview
You can see that in the minifed version there are black borders between columns.
This how I minifed the css file:
var fs = require('fs');
var CleanCSS = require('./node_modules/clean-css');
var css = fs.readFileSync("ngGrid.css", encoding='utf8');
var min = new CleanCSS().minify(css).styles;
fs.writeFileSync("ngGrid.min.css", min, {encoding : 'utf8'});

@ezraroi thanks for sharing, I will give it a try and get back to you.

@jakubpawlowicz np

The problem is rule:
.ui-grid-cell {
  overflow: hidden;
  float: left;
  background-color: inherit;
  border-right: 1px solid;
  border-color: #d4d4d4;
  box-sizing: border-box;
}

.ui-grid-footer-cell {
  overflow: hidden;
  background-color: inherit;
  border-right: 1px solid;
  border-color: #d4d4d4;
  box-sizing: border-box;
  display: table-cell;
}

becomes:
.ui-grid-cell,.ui-grid-footer-cell{overflow:hidden;border-color:#d4d4d4}
.ui-grid-cell{float:left;background-color:inherit;border-right:1px solid;box-sizing:border-box}

Interesting things here is united rule for border-color:#d4d4d4 and border-right:1px solid; rule.
In first case (before minification) browser interprets border-right:1px solid; as:
    border-right-width: 1px;
    border-right-style: solid;
    border-right-color: rgb(212, 212, 212);

In second case (after minification) browser interprets border-right:1px solid; as:
    border-right-width: 1px;
    border-right-style: solid;
    border-right-color: initial;

I thing the problem is order of border-* rules.
In original ui-grid.css the rule border-color:#d4d4d4 is after border-right: 1px solid; rule but in minified css it appears before it.

@xak2000 Please use the latest 3.3 or 3.4 as it's fixed there.

I am using "version": "3.4.1". Not fixed.

You can download ui-grid.css and run cleancss ./ui-grid.css -b | grep .ui-grid-cell[,{] and you see 4th and 5th lines.

This is the correct test case:
.ui-grid-cell {
  overflow: hidden;
  border-right: 1px solid;
  border-color: #d4d4d4;
}
.ui-grid-cell:last-child {
  border-right: 0;
}
.ui-grid-footer-cell {
  overflow: hidden;
  border-right: 1px solid;
  border-color: #d4d4d4;
}

Fix is coming.

Sorry. Didn't know that .ui-grid-cell:last-child affect this. Tried only with full file.
Thanks for fixing!

@xak2000 no worries, fix is ready on 3.4 branch, to be released tomorrow

It's released as 3.4.2.

Thanks for helping out with narrowing it down @ezraroi and @xak2000!


I met the requirements and it still doesn't work for some reason :/

Is there any way to fix this?

It works now :D


Add support for T2w images

Should require minimal changes from the T1 workflow.

An intermediate step is #376