Feature request: set JS output indentation to 2 in next major release

Suggestion
Rather than make indention configurable per #4042 and #2768, this feature request is to change the default output of the TypeScript compiler to be 2 spaces, in the next major release.

This is not asking for a configuration option per #\4042 and #\2768, and hence not a duplicate of that feature request or that PR. Rather it is asking for TS to have sensible defaults in it's JavaScript output.
People do occasionally need to look at TypeScript output hence TypeScript output should look like JavaScript
2 spaces is a sensible default for JavaScript output because:

Most popular JavaScript style guides like Prettier, StandardJS use two spaces as well as many others like Google, npm, Node.js, Idiomatic, Felix. style guides.
Most JavaScript documentation for well known APIs, eg Stripe and Twilio, etc. use 2 spaces
The vast majority of npm modules uses 2 spaces. I can't find stats here but I'd be surprised if it was lower than 97%.

🔍 Search Terms
I searched for TS output indentation and came up with #4042 and #2768, which do not propose the same thing as this feature request, which is a sensible value in TS's output JS where 'sensible' is defined as looking like JavaScript.
✅ Viability Checklist
My suggestion meets these guidelines:

[❌] This wouldn't be a breaking change in existing TypeScript/JavaScript code. It's breaking. Hence next major release.
[✅] This wouldn't change the runtime behavior of existing JavaScript code
[✅] This could be implemented without emitting different JS based on the types of the expressions
[✅] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[✅✅✅✅✅] This feature would agree with the rest of TypeScript's Design Goals. Very much so! Specifically "Emit clean, idiomatic, recognizable JavaScript code.". Right now the JS output by the TS compiler is not idiomatic of recognisable.

⭐ Suggestion
Change the number from 4 to 2 so it matches JavaScript. Not asking for a configuration option. TS should have sensible defaults. Sensible defaults for JavaScript include looking like the vast majority of other JavaScript.
📃 Motivating Example
See the links above.
💻 Use Cases
I and many others (according to #4042 and #2768) often look at outputted JS. For example, right now I want to throw debugger into some dist JS in my node_modules folder to see why a third party library is behaving oddly. I have to read some very odd-looking JavaScript since the TS compiler doesn't use a sensible default for the indentation value.

See also #50855 #2306 (moderately relavent, in that the PR does most of this I believe).

Right now the JS output by the TS compiler is not idiomatic [or] recognisable.

I’m pretty sure emitting 4 spaces instead of 2 doesn’t make the code unrecognizable or even non-idiomatic. 🙄 Please don’t be overdramatic.

@fatcerberus as discussed in the feature request,  the vast majority of JavaScript uses two space indentation using four space indentation does not look like standard JavaScript. Calling other people dramatic for pointing that out is actively unhelpful.

I’ve seen lots of indent wars but I’ve never heard anyone claim code was “unrecognizable” as a particular language just because it used a different number of spaces.  That’s the part I was calling dramatic, and I stand by it.

I always recommend setting…

This is someone’s opinion and is openly presented as such.  I personally find 4 spaces more readable.  Neither opinion is more valid than the other.  So we’re ultimately just arguing whether we should paint the bikeshed blue or green.
I would also like to point this out:
https://github.com/rwaldron/idiomatic.js#i-do-not-intend-to-impose-my-style-preferences-on-other-peoples-code-or-projects-if-an-existing-common-style-exists-it-should-be-respected
idiomatic-js is a style guide.  It happens to be a well-known one and have “idiomatic” in its name.  It is explicitly not a mandate nor a standard like the ECMAScript specification that needs to be followed religiously, and using a different style doesn’t make the resulting code suddenly “not JavaScript”.
Anyway, I’ve said my piece.  I fully expect this issue to generate much more heat than light but I’ve been surprised before, so let’s see what happens.

@fatcerberus this isn't an indent war. This isn't a matter of preference, it's a matter of what recognizable, idiomatic JavaScript looks like.

idiomatic-js is a style guide. It happens to be a well-known one and have “idiomatic” in its name.

Yes I am aware of this. The point I was making was that since it also happens to be the name of a JavaScript style guide, it uses...surprise, 2 spaces.
The intro to this feature request Prettier, StandardJS, node style guide, Idiomatic JS, AirBnB style guide, MDN code style guide, and Google JavaScript Style Guide.

using a different style doesn’t make the resulting code suddenly “not JavaScript”.

Agreed. It does make the resulting code unusual-looking JavaScript though and that's what the request hopes to resolve.

I've added stats for the top 10 npm projects by downloads to the top of this post.

If your aim is to improve readability of the generated code, then it should be tabs instead of spaces, allowing users to configure their preferred display width (especially visually impaired people).

Have added codepen, jsfiddle and jsbin results to top of the PR.

Let say we have an .editorconfig with :
indent_style = space
indent_size = 2
end_of_line = lf

Our source code is formatted with the settings above obviously.
tsc allows us to set the EOL char in the emitted code via newLine, nice.
But it doesn't allow us to set the indent style in the emitted code, 😢.
Why would tsc arbitrarily impose 4 spaces indentation in the emitted files, regardless of the source code / editorconfig or whatever, while there is no tsconfig option to control/override this ?
The best would be imho to either :

let developers be able to override it (reopen #4042, review PRs), or,
at least keep it the same as in the source code, or,
at least impose the most used/popular preference.

Why not ?


Synchronization issues

When you rewind the timeline, the status does not change

YouTube

Thanks for your report. This is a known bug, but unfortunately i have no any ETA when it will be fixed.
This happens because internal app API doesn't emit ON_PLAYER_STATE when user seeks track manually. So to fix this i need to do deep reverse-engineering and remake some parts of the app. So when i do this the bug will be fixed.

I managed to implement some changes so the bug will be fixed it the next release.
https://github.com/TheKing-OfTime/YandexMusicModClient/assets/68960526/49617bbb-f362-4c23-a0f7-3369b498efea

Fix released


Added configuration for swagger-ui and jquery js external-load URLs.

This change allows new Flasgger config keys to specify the URL location where Swagger UI and jQuery javascript sources are loaded from, allowing them to be loaded from Flasgger's static copies (default), or any URL, including hosted sources.  This can allow any compatible version of those libraries to be loaded, allowing the latest Swagger UI to be loaded by Flasgger templates.
The new, optional config keys are:

swagger_ui_bundle_js
swagger_ui_standalone_preset_js
jquery_js

For example, the following can be used to load scripts from unpkg.com:
app = Flask(__name__)
app.config['SWAGGER'] = {
    'title': 'Colors API'
}
swagger_config = Swagger.DEFAULT_CONFIG
swagger_config['swagger_ui_bundle_js'] =<EMAIL_ADDRESS>swagger_config['swagger_ui_standalone_preset_js'] =<EMAIL_ADDRESS>swagger_config['jquery_js'] =<EMAIL_ADDRESS>Swagger(app, config=swagger_config)

As part of this change, template part flasgger/body_scripts.html was factored-out of index.html, making it easier to override and replace the body script load section entirely if desired.
Added a test/example.
This is somewhat inspired by discussions in #231, so I mention it here.
Questions

Is the colors example a good base for new test/example code?  That's what I copied for the test/example.  I wonder if we should have a canonical, minimal, template example app that forms the base for tests which need to exercise one function without testing unwanted features or copying a lot of example code.
I exposed three new config keys.  I was wondering if there was a more generic way of doing this, or allowing override, other than the addition of the factored-out body_scripts.html template.
Check config key names - I didn't include url in them.

Testing

Access the new colors_external_js example with a browser in developer mode and note where the scripts are fetched from.  The example is using a floating/latest ui3 mechanism, so there is a redirect involved.  This loads the latest Swagger UI 3.x, which currently loads 3.19.0.

TODO

I notice I need to externalise the CSS link too.

Coverage remained the same at 91.184% when pulling 265b3cd6fce67d7a44ceb31b2470463ea12843db on static-js-url-config into 6739622a9bb96dc38d459ebcf5833076c30fc0cf on master.

Is the colors example a good base for new test/example code? That's what I copied for the test/example. I wonder if we should have a canonical, minimal, template example app that forms the base for tests which need to exercise one function without testing unwanted features or copying a lot of example code.

This colors app is good for me, it is simple and uses some of the features, the ideal would be having a minimal app that uses most of the features but looks like impossible to have it. I am OK if you want to add a new example app with a more minimal implementation.

I exposed three new config keys. I was wondering if there was a more generic way of doing this, or allowing override, other than the addition of the factored-out body_scripts.html template.

I think the only ways are using the scripts + config variables, which is already in place, I cannot think of anything different than that. (for more customization, users will need to rewrite the whole template)

@rochacbruno thanks for the review.  I'm good with the colors example for now, and the variables seem OK too.
Let me know if you have any changes or will review further or are +ve or -ve on this sort of change.  I think it should make it fairly easy for flasgger users to choose updated Swagger UI versions.

@javabrett LGTM

For anyone interested, there's now a live example of this deployed to http://flasgger.pythonanywhere.com/colors_external_js/apidocs/ .  This loads the latest Swagger UI 3.x into Flasgger's UI, which at the time of this post is 3.19.5.


[Task]: Update Digital Ocean Video Tutorial on the Documentation

Problem Statement
Embedded video showcased on this page: https://docs.appsmith.com/getting-started/setup/installation-guides/digitalocean is no longer valid and needs an update; we just published the new video https://youtu.be/H4KDHWloSR4 . Please update and keep embedding this new video (do not just link to the video, embed it as the current one)
Use Cases / User query reference
Embedded video showcased on this page: https://docs.appsmith.com/getting-started/setup/installation-guides/digitalocean is no longer valid and needs an update; we just published the new video https://youtu.be/H4KDHWloSR4 . Please update and keep embedding this new video (do not just link to the video, embed it as the current one)
Audio/Video Recording
https://youtu.be/H4KDHWloSR4
Product Requirements Document
No response
Other Relevant Links
No response
Checklist

[X] Reviewed existing documentation to ensure this request is not duplicated.
[X] Attached relevant media or supporting materials like links to the PRD, feature recordings, Slack or Discord links, and any other relevant resources.

@kevinblanco - the documentation steps and video steps are different. Has the interface at Digital Ocean changed? Please confirm. If so. we will have to delay the video embed until we update the steps in the doc so that the video and steps are in sync.

The documentation needs updating based on the interface changes at Digital Ocean.


How to close "A block comment in between other elements on the same line is disallowed"

How to close the function: "A block comment in between other elements on the same line is disallowed"?
ktlint version: 0.45.2
My build.gradle file like this:
        ktlint(versions.ktlint)
                .setUseExperimental(true)
                .userData([
                        "android"       : "true",
                        "disabled_rules": "no-wildcard-imports,parameter-list-wrapping,experimental:block-comment-initial-star-alignment",
                ])
                .editorConfigOverride([
                        "max_line_length"                     : "off",
                ])

I do not understand your question. Please provide the code sample which is not handled correctly in your opinion.

I noticed the description in the documentation: experimental:block-comment-initial-star-alignment.
In my code, there is such a situation. When I run format code, the ktlint reports an error. The reason for the error is: “A block comment in between other elements on the same line is disallowed”.
My code sample like this:
@SuppressLint("UnsafeOptInUsageError")
private fun bindAnalysisUseCase() {
cameraProvider!!.bindToLifecycle(/* lifecycleOwner= */ this, cameraSelector, analysisUseCase)
}
I would like to be able to turn off this check so that my formatting can continue to run.


SA1601 not reported in this code

In classic StyleCop this would be an issue but in StyleCopAnalyzers it is not:
namespace OnlineGames.Workers.BattlesSimulator
{
    using System.ServiceProcess;

    public partial class Service1 : ServiceBase
    {
        public Service1()
        {
            this.InitializeComponent();
        }

        protected override void OnStart(string[] args)
        {
        }

        protected override void OnStop()
        {
        }
    }
}

My Rules.ruleset is here and my stylecop.json is here

You disabled rule SA1652 which has the following description:

The project is currently configured to not parse XML documentation comments; all diagnostics for documentation comments are disabled. Enable XML documentation output to enable these diagnostics.

I've observed that this is a recurring problem, which means people are missing this description before disabling the rule. Any ideas on how to correct it?

@NikolayIT Do you have any suggestions for how to handle this? I don't mind just linking people to the documentation, but if we had a way to prevent people from facing it in the first place it'd also be good to take it. :smile:

@sharwell, I didn't get the "linking people to the documentation" thing :grinning:
Anyway I think a message in Visual Studio error list will be informative for people who are expecting their code to produce documentation warnings with SA1652 disabled.

I would suggest that you emit a warning if there are any rules enabled that depends on the xml documentation being generated.

And the xml doc generation is not enabled of course 😏

@soerennielsen We do exactly that. The problem is people have been disabling the warning rather than fix it.


Implement private partition selection.

Description
Implement private partition selection.
How has this been tested?
Unit tests.
Checklist

[x] I have followed the Contribution Guidelines and Code of Conduct
[x] I have commented my code following the OpenMined Styleguide
[x] I have labeled this PR with the relevant Type labels
[x] My changes are covered by tests

Done, PTAL.


Remove unnecessary dependencies for xds_cluster_manager LB policy.

Looks like we missed these in #23659.

Fixed.

Known issue: #22181


Fixed toolchain tests blocking non-toolchain packages' tests.

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[X] The toolchain has been rebuilt successfully (or no changes were made to it)
[X] The toolchain/worker package manifests are up-to-date
[X] Any updated packages successfully build (or no packages were changed)
[X] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[X] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[X] All package sources are available
[X] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[X] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[X] All source files have up-to-date hashes in the *.signatures.json files
[X] sudo make go-tidy-all and sudo make go-test-coverage pass
[X] Documentation has been updated to match any changes to the build system
[X] Ready to merge

Summary

We have a bug in the PR check where a change to a toolchain package prevents ptest from being run for all non-toolchain packages. This change moves toolchain ptests to a separate job, so the original BuildAndTest will build and test only non-toolchain packages.
Requires #10392 to be merged first.
Does this affect the toolchain?

No.
Test Methodology

PR check.

Auto cherry-pick results:

3.0-dev :white_check_mark: -> https://github.com/microsoft/azurelinux/pull/10457

Auto cherry-pick pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=639975&view=results


[cephadm] Switch HA containers if a custom container registry is used

fix typo in a task name

As a pull request owner and reviewers, I checked that:

[x] Appropriate testing is done and actually running
[x] Appropriate documentation exists and/or is up-to-date:

[x] README in the role
[x] Content of the docs/source is reflecting the changes

@rebtoor Thank you for proposing the patch. I think this change needs to be proposed against ci-framework main branch. During va1 testing, we run ceph playbook standalone. So I think getting it in main would be good.

+1 to have this change applied to the main branch and backported where needed.

I'll close this PR and open new one against main branch.


How symbol composition works?

The following code:
x = mx.symbol.Variable('x')
y = mx.symbol.Variable('y')
a = x * 2
b = y + a
c = b(y=a)
If we run print(c.tojson()), we can find that there are two duplicate input variables named "x" in symbol c, and the expression a is computed twice. Is this the expected result?
The output of c.tojson() is:
{
"nodes": [
{
"op": "null",
"name": "x",
"inputs": []
},
{
"op": "_mul_scalar",
"name": "_mulscalar0",
"attr": {"scalar": "2"},
"inputs": [[0, 0, 0]]
},
{
"op": "null",
"name": "x",
"inputs": []
},
{
"op": "_mul_scalar",
"name": "_mulscalar0",
"attr": {"scalar": "2"},
"inputs": [[2, 0, 0]]
},
{
"op": "elemwise_add",
"name": "_plus0",
"inputs": [[1, 0, 0], [3, 0, 0]]
}
],
"arg_nodes": [0, 2],
"node_row_ptr": [0, 1, 2, 3, 4, 5],
"heads": [[4, 0, 0]],
"attrs": {"mxnet_version": ["int", 1101]}
}

This issue is closed due to lack of activity in the last 90 days. Feel free to ping me to reopen if this is still an active issue. Thanks!
Also, do please check out our forum (and Chinese version) for general "how-to" questions.


Change testInstrumentationRunner to use the AndroidX version

Pull Request Test Coverage Report for Build 122

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.412%

Totals

Change from base Build 121:
0.0%

Covered Lines:
76

Relevant Lines:
85

💛  - Coveralls


Does this support NUnit?

Does this support NUnit?
I have many unit test cases written in NUnit. Migration them seems difficult.

Not directly. But it doesn't directly support MSTest either and folks get by just fine with it. We only added Xunit-specific helpers very recently. Just review either xunit or mstest documentation and do the equivalent thing for NUnit. Once you figure it out, if you'd like to share back, I'd entertain a PR to add NUnit to our docs.

Follow https://github.com/microsoft/vssdktestfx/blob/main/doc/mstest.md, I successfully run all my cases with NUnit.
We may not really need to add separate attribute class. Manually adding AssemblySetup.MockServiceProvider.Reset() to the constructor or  [SetUp] section of every test class should also work.
Add this class to your test folder.
`
using Microsoft.VisualStudio.Sdk.TestFramework;
using NUnit.Framework;
namespace Application.Test
{
[SetUpFixture]
public class AssemblySetup
{
internal static GlobalServiceProvider MockServiceProvider { get; private set; }
    [OneTimeSetUp]
    public void RunBeforeAnyTests()
    {
        MockServiceProvider = new GlobalServiceProvider();
    }

    [OneTimeTearDown]
    public void RunAfterAnyTests()
    {
        MockServiceProvider.Dispose();
    }

}

}
`
Create a attribute class
using System; namespace Application.Test {     [AttributeUsage(AttributeTargets.Class)]     public class TestWithAttribute : Attribute     {         public TestWithUnityContainerAttribute()         {             AssemblySetup.MockServiceProvider.Reset();         }     } }
Add the attribute annotation to every test class
namespace Application {     [TestFixture]     [TestWithAttribute]     public class AnalysisTest      {        [Test]         public void Test()         {             Assert.AreEqual(1, 1);         }     } }

Thank you for sharing. Wanna send a PR that adds an nunit.md doc to the repo, @maysonchen-cs.


FOGL-3314: AssetTracker call missing in simple-python filter

FOGL-3314: AssetTracker add event entry is missing in plugin_ingest def for filter-simple-python plugin
sqlite> select * from asset_tracker;
7|randomwalk|Filter|Rand3|FogLAMP|Code1|2019-09-30 11:27:18.053
8|walk2|Filter|Rand2|FogLAMP|Fil2|2019-09-30 11:30:04.628

Looks good! It would be nice to have fix code snippet line with prefix b  for "Change datapoint value" in README.rst. Already mentioned in JIRA under NOTE section


Bugfix for handling Custom Platform Events in the framework - Filter …

…functionality does not apply and Id field does not exist.

Codecov Report
Base: 95.40% // Head: 95.48% // Increases project coverage by +0.07% :tada:

Coverage data is based on head (cbe6a8e) compared to base (e21a788).
Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head cbe6a8e differs from pull request most recent head b70eb35. Consider uploading reports for the commit b70eb35 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
+ Coverage   95.40%   95.48%   +0.07%
==========================================
  Files           7        8       +1
  Lines         283      288       +5
==========================================
+ Hits          270      275       +5
  Misses         13       13

Flag
Coverage Δ

Apex
95.48% <100.00%> (+0.07%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...e/main/default/classes/TriggerHandlerExtension.cls
97.24% <100.00%> (+0.07%)
:arrow_up:

unmanaged/main/default/classes/CPEHandler.cls
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


XA and XB must have the same number of columns (i.e. feature dimension.)

hello,
i am trying to implement your example with 2_1_cnn_mnist.py.
and i want to add some layers.
like this:
layer = conv_layer(x, params.conv[0])
layer = conv_layer(layer, params.conv[1])
layer = conv_layer(layer, params.conv[2])
layer = dense_layer(layer, params.dense)
logits = tf.layers.dense(inputs=layer, units=10)
conv = [
# Layer 1
hype.spec.new(
filter_num = hype.spec.choice([32]),
filter_size = [hype.spec.choice([5])] * 2,
activation = hype.spec.choice(ACTIVATIONS.keys()),
batch_norm = hype.spec.random_bool(),
dropout = hype.spec.uniform(0.0, 0.0),
),
# Layer 2
hype.spec.new(
filter_num = hype.spec.choice([32]),
filter_size = [hype.spec.choice([5])] * 2,
activation = hype.spec.choice(ACTIVATIONS.keys()),
batch_norm = hype.spec.random_bool(),
dropout = hype.spec.uniform(0.0, 0.0),
),
# Layer 3
hype.spec.new(
filter_num = hype.spec.choice([64]),
filter_size = [hype.spec.choice([5])] * 2,
activation = hype.spec.choice(ACTIVATIONS.keys()),
batch_norm = hype.spec.random_bool(),
dropout = hype.spec.uniform(0.0, 0.0),
),
]
i just add one layer and one params.con[]
so i got this issue:
Traceback (most recent call last):
File "/Users/dongyijie/Downloads/hyper-engine/hyperengine/examples/2_1_cnn_mnist_try.py", line 118, in
tuner.tune()
File "/Users/dongyijie/Downloads/hyper-engine/hyperengine/model/hyper_tuner.py", line 45, in tune
point = self._strategy.next_proposal()
File "/Users/dongyijie/Downloads/hyper-engine/hyperengine/bayesian/strategy.py", line 150, in next_proposal
return self._maximizer.compute_max_point()
File "/Users/dongyijie/Downloads/hyper-engine/hyperengine/bayesian/maximizer.py", line 41, in compute_max_point
values = self._utility.compute_values(batch)
File "/Users/dongyijie/Downloads/hyper-engine/hyperengine/bayesian/utility.py", line 132, in compute_values
mu, sigma = self.mean_and_std(batch)
File "/Users/dongyijie/Downloads/hyper-engine/hyperengine/bayesian/utility.py", line 64, in mean_and_std
k_star = np.swapaxes(self.kernel.compute(self.points, batch), 0, 1)
File "/Users/dongyijie/Downloads/hyper-engine/hyperengine/bayesian/kernel.py", line 57, in compute
dist = cdist(batch_x, batch_y, **self._params)
File "/Users/dongyijie/Downloads/hyper-engine/venv/lib/python3.7/site-packages/scipy/spatial/distance.py", line 2721, in cdist
raise ValueError('XA and XB must have the same number of columns '
ValueError: XA and XB must have the same number of columns (i.e. feature dimension.)
so how can i fix it?
thank you so much.

I think here's what happened: you let the example run for some time, then updated the spec and started it again. By default, it loads the state from disk and continues from there, but it can't do that if the dimensionality changed.
So either remove the state on disk or change the file name to start a brand new session.


Deployment 2017.03.14

Deployment 2017.03.14
Status: Planned
Planned production date: 03/14/2017
Focus: Signing of job binaries
Services to Deploy:

Service
DEV
INT
PROD

Jobs - ArchivePackages
[ ]
[ ]
[ ]

Jobs - HandlePackageEdits
[ ]
[ ]
[ ]

Jobs - Send API key expiration e-mails
[ ]
[ ]
[ ]

Jobs - Send support request notifications

[ ]

NuGet v3 - UpdateLicenseReports Job

[ ]

Jobs - CDN Stats - Aggregate CDN statistics
[ ]
[ ]
[ ]

Jobs - CDN Stats - Collect Logs
[ ]
[ ]
[ ]

Jobs - CDN Stats - Create Warehouse Reports
[ ]
[ ]
[ ]

Jobs - CDN Stats - Import Statistics
[ ]
[ ]
[ ]

Jobs - CDN Stats - RollUpDownloadFacts
[ ]
[ ]
[ ]

Jobs - Validation

[ ]

NuGet v3 - catalog2dnx
[ ]
[ ]
[ ]

NuGet v3 - catalog2lucenev3
[ ]
[ ]
[ ]

NuGet v3 - catalog2registrationv3
[ ]
[ ]
[ ]

NuGet v3 - feed2catalogv3
[ ]
[ ]
[ ]

Related blog posts/docs:

None

Deployed commit:
Deployment Process
Jobs

[ ] Deploy all jobs mentioned in the table above

Test Plan:

[ ] Run all functional tests
[ ] Smoke testing
[ ] Verify ArchivePackages is dropping .nupkgs in the archive container
[ ] Verify package edits are being applied (both to metadata and .nupkg)
[ ] Verify API expire emails are going out
[ ] Make sure license reports are being updated
[ ] Make sure download counts on a single package are going up (gallery and search service)
[ ] Make sure the total downloads on the front page are going up

Changes
- Jobs:
All .exe and .dlls have strong name signatures.

FYI checkbox in a table doesn't work without editing it.


I am unable to start my saved run.

It says the game content is different from content during save. I did not touch the mods. Does the game getting updates via Steam(if it did) prove to be a problem?

The update changed antlers internal name, so it counts as a new content and triggers the message, however not being able to load is a separate issue which is fixed with a new mod update


chore: fix release workflow permissions

bors r+

Codecov Report

Merging #22 (b0ba3ea) into master (a3cd4c7) will increase coverage by 12.67%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master      #22       +/-   ##
===========================================
+ Coverage   32.39%   45.07%   +12.67%
===========================================
  Files          20       20
  Lines        1562     1562
===========================================
+ Hits          506      704      +198
+ Misses       1056      858      -198

Impacted Files
Coverage Δ

server/src/server.rs
87.91% <0.00%> (+0.54%)
:arrow_up:

server/src/types.rs
6.54% <0.00%> (+0.93%)
:arrow_up:

server/src/connection.rs
32.08% <0.00%> (+2.61%)
:arrow_up:

server/src/request.rs
7.50% <0.00%> (+7.50%)
:arrow_up:

server/src/error.rs
8.51% <0.00%> (+8.51%)
:arrow_up:

server/src/websockets.rs
64.90% <0.00%> (+10.59%)
:arrow_up:

server/src/id_manager.rs
84.61% <0.00%> (+15.38%)
:arrow_up:

server/src/connection_list.rs
60.97% <0.00%> (+17.07%)
:arrow_up:

server/src/tcp.rs
52.02% <0.00%> (+40.87%)
:arrow_up:

server/src/router.rs
90.90% <0.00%> (+66.66%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3cd4c7...b0ba3ea. Read the comment docs.


PlayerBuff doesn't display accurately

The (mega) demodrug is wrongly displayed as (mega) armorskin while the (mega) armorskin is not displayed.

I made a PR fixing this: #31


Variable viewer: Accidental value="[object Object]" attribute?

Testing #10170
I'm guessing this was accidental on the open in data viewer button, might be what's causing the button not to work (https://github.com/microsoft/vscode-jupyter/issues/10229)?

No data viewer isn't supported in web yet. We haven't implemented it.


⚠ DesiTorrents has degraded performance

In 8d62ae9, DesiTorrents ($DST) experienced degraded performance:

HTTP code: 200
Response time: 2923 ms

Resolved: DesiTorrents performance has improved in c832850.


Add link to quick create forms and remove typos

@stjanovi Thanks for submitting this pull request but the topic is actually targeted to be removed. Below is the topic that has replaced it and a redirect has been put in place for the types-forms topic.
https://docs.microsoft.com/en-us/dynamics365/customer-engagement/customize/create-design-forms#type-of-forms


Add copy flag that enables a deep copy of the entire stream pipeline.

The flag introduced in this commit could be used to split a stream into multiple ones and use each branch independently. AbstractDataStream now accepts an optional flag copy which is False by default. When set to True, the DataIterator in the AbstractDataStream.get_epoch_iterator is always provided with a unique deep copy of the data stream.
In addition, Merge now accepts and forwards **kwargs to AbstractDataStream for compatibility reasons.
The following code demonstrates the unexpected behavior which could be avoided by using the copy=True flag. The code splits a stream of two variables into two independent streams. Then the streams are merged back into a single stream again. An expected behavior is that the resulting stream generates the same data as the original stream. However, this is not the case.
import pprint
import numpy as np

from fuel.streams import DataStream
from fuel.datasets import IndexableDataset
from fuel.transformers import FilterSources, Merge
from fuel.schemes import ShuffledScheme, SequentialScheme

def print_stream(data_stream, msg):
    print(msg)
    for d in data_stream.get_epoch_iterator(as_dict=True):
        pprint.pprint(d, width=1)
        print('')
    print('----------------------')

if __name__ == '__main__':
    num_examples = 10

    x = np.tile(np.arange(num_examples), (3, 1)).T
    y = np.tile(np.arange(num_examples) + num_examples, (2, 1)).T

    dataset = IndexableDataset({'x': x, 'y': y})
    stream = DataStream(dataset=dataset, iteration_scheme=SequentialScheme(batch_size=3, examples=dataset.num_examples))
    print_stream(stream, 'After stream creation:')

    stream = FilterSources(stream, ('x', 'y'))
    print_stream(stream, 'After innocent filter:')

    x_only = FilterSources(stream, ('x',))
    y_only = FilterSources(stream, ('y',))
    stream = Merge([x_only, y_only], x_only.sources + y_only.sources)
    print_stream(stream, 'After merge:')

It looks like a bug. So, the reason for it is that the get_data is called twice, right?

@dmitriy-serdyuk exactly, in this case twice. Originally I had multiple following split-merges which caused that get_data was called even more than twice.

Is it possible just to copy the request iterator? It should be sufficient.
And can you add a test?


gnu(8736)=11259

This took 10870.029 seconds to compute.

gnu(8736)=11259
GAP      4.8.3
GrpConst 2.5
Runtime: 8161407 ms
Isomorphic groups eliminated
Validated on Linux server (AMD Opteron 6376 1400 MHz processor, 512 GB RAM)


HTTP 0.7 support

There's a branch https://github.com/JuliaWeb/WebSockets.jl/tree/http0.7.0 for updating to support the current HTTP version. Since it's not fully working there's no pull request yet.
The current non-resolved issue on that branch is serving proper responses. For example, running examples/chat_explore.jl and opening in Chrome results in "xxx.xxx.0.x sent an invalid response. ERR_INVALID_HTTP_RESPONSE."
The server task simultaneously fails with error: "MbedTLS error code -29184: SSL - An invalid SSL record was received". Nothing is necessarily output to a console when the server task fails.
As proposed in PR #120, I currently don't see other options than defining structure ServerOptions too in this package. Specifically, in order to have:
.sslconfig::Union{HTTP.MbedTLS.SSLConfig, Nothing}

instead of:
.sslconfig::HTTP.MbedTLS.SSLConfig

After this change, things started to work. Made PR #122 for this work in progress.

We now reluctantly define ServerOptions, ServerWS and checkratelimit, which are not 'core' WebSockets functionality.
It falls naturally to go all the way so that the user don't need to deal with package HTTP directly. The functions and types from HTTP which are used internally are now imported. The user can thus access them through WebSockets and not necessarily import anything from package HTTP. This will provide a more fail-safe upgrade process in future, and a smaller interface to learn.


Fixed --tag-filter syntax

@normesta

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Looks good. I tested the update. Oddly, the previous version worked for me as well. Either way, I was able to validate. Thank you!
#sign-off

Maybe because you had an older version of a package on your system?
It was my first time using this command syntax, the one in the document
didn't work and it took me some time to figure out is the correct syntax.
The error message wasn't helpful btw...
Thanks for the approval ☺
On Fri, Nov 17, 2023, 19:29 Norm Estabrook @.***> wrote:

Looks good. I tested the update. Oddly, the previous version worked for me
as well. Either way, I was able to validate. Thank you!
#sign-off
—
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/pull/117061#issuecomment-1816818473,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMQGWUSKFHMW6DHMGQXEC5DYE6NIBAVCNFSM6AAAAAA7LEE25OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJWHAYTQNBXGM
.
You are receiving this because you were mentioned.Message ID:
@.***>


improved ice server filter

Description
improved ice server filter. Should make apprtc work but if you could test it before merging that would be great.

LGTM

Thanks fippo for the reply, so i can not use stun? must use turn for Edge?

Micosoft msdn said that they support stun.
https://msdn.microsoft.com/zh-cn/library/mt502501(v=vs.85).aspx

yet this still does not work and results in an InvalidAccessError:
var g = new RTCIceGatherer({iceServers:[{urls: "stun:stun.l.google.com:19302?transport=udp"}]})

hi fippo, I got this work on new RTCPeerConnection, but it dont get the correct public ip addr.
iceOptions.gatherPolicy= 'all';
iceOptions.iceServers = {urls: "stun:stun.l.google.com:19302"}; //not array but just object.

STUN is not supported so if you just supply a STUN server no ice servers will be used and you don't get a public ip. No way around this, use a TURN server.

Thanks a lot, I have gave up run webRTC on Edge.
By the way, I use sipjs (sipjs.com) and it works on chrome very well.


Fix the pipelining system to work properly with stylesheets

Currently, there are various issues related to pipelining and the paths we introduce for assets, like #4.
We should improve this, making sure it works properly (because it eats up time on projects) if we have to faff around with it a lot.
I had lots of issues on a recent project where I tried to include bower components like:

https://github.com/nicolafranchini/VenoBox
and font-awesome, of course

This also affects #3

This works very smoothly now that we're using the proper pipeline for Middleman assets and bower_components in 264362c8d7b288b77da160e5de966699c86ff60a
For obvious reasons, if a plugin doesn't use Sass and allow us to define a path. But TMK this is something that'll not be possible to resolve, and makes perfect sense, so I'll mark as closed here.


#3289 padding on implements

Closes #3289
Checklist

[x] I've added unit tests to cover both positive and negative cases
[x]  I've added the license header to any new files through ./gradlew licenseFormat
[x] I've used the IntelliJ IDEA auto-formatter on affected files

@AlexanderSkrock Thanks for the contribution!

Reverted again. Please see https://github.com/openrewrite/rewrite/issues/3289#issuecomment-1697365395.


[WIP] - VM Hardware: NICs and IPs management

#58

@rhtyd I've updated the async poll function to be inside a global plugin found in src/utils/plugins.js. If you're happy with that way of doing things let me know, and I can refactor the old methods to use this way.

Thanks @RitchieVincent, I'll review and test, and get back to you.

@RitchieVincent please ping me once you've fixed the conflicts and addressed the poll/refactorings

@RitchieVincent kindly follow the fixes, avoid passing response: json to API, which is handled centrally. Otherwise LGTM, made some fixes, will merge it now.


bug: Issue nesting controllers (ui freezes)

Type: bug
Platform: all
I have 3 controllers activitiesCtrl, ActivityCtrl and ActivityCommentCtrl
When my app starts it does so in the ActivitiesCtrl. This controllers gets a list of categories and iterates through them displaying categories and tying them to ActivityCtrl as so
<ion-view view-title="Activities" class="activities-page">
  <ion-content scroll="true">
    <ion-item ng-repeat="category in categories" style="padding:0px;" ng-controller="ActivityCtrl" ng-model="category">

    </ion-item>
  </ion-content>
</ion-view>

The activityTemplate then allows someone to comment on an activity by opening a modal as shown here.

      Comment

The ActivityCommentCtrl loads the following template and this is where things get weird
<ion-modal-view ng-controller="ActivityCommentCtrl" ng-model="category">
  <ion-header-bar align-title="left">

      <button class="button button-clear button-negative" ng-click="closeModal()">Cancel</button>

  </ion-header-bar>
  <ion-content>
    {{category.title}}
  </ion-content>
</ion-modal-view>

If I remove the ng-controller attribute above then closeModal() is never called and I get the warning commonly reported
'webkitMovementX' is deprecated. Please use 'movementX' instead.
if I leave the ng-controller attribute in there, then my app is unable to load completely and my CPU usage just stays at 100%. This happens both on safari and chrome so doesn't seem to be an issue with the browser.
I fairly new to angular (from backbone) so maybe there is something I am not setting up right in-terms of the angular app?

Greetings @hansgill!
My sensors indicate that you need to update your issue through our custom issue form. We are now requiring all issues to be submitted this way, to ensure that we have all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
I will have no choice but to close this issue if it is not resubmitted through the form. Please fill out the rest of the form, so that I may use my friendly robot powers to assist you.
Thank you!

This was a non issue. I was testing old code which somehow wasn't getting updated in my build process. So sorry.


muxc:NumberBox's all basic appearance customisation properties not working

Describe the bug

All basic appearance customisation properties like Height, BorderThickness, Background, Padding, etc..,  not working in muxc:NumberBox control.
Sample:
MUXC_NumberBox.zip
Steps to reproduce the bug

Steps to reproduce the behavior:

Extract the sample.
Run the sample.
See the NumberBox,  Height, BorderThickness,, Background, , Padding not applied.

Expected behavior

NumberBox sholud be apply the Height, BorderThickness,, Background, , Padding property values.
Screenshots

Version Info

NuGet package version:

[Microsoft.WinUI 3.0.0-preview4.210210.4]

Windows app type:

UWP
Win32

Yes

Windows 10 version
Saw the problem?

Insider Build (xxxxx)

October 2020 Update (19042)
Yes

May 2020 Update (19041)

November 2019 Update (18363)

May 2019 Update (18362)

October 2018 Update (17763)

April 2018 Update (17134)

Fall Creators Update (16299)

Creators Update (15063)

Device form factor
Saw the problem?

Desktop
Yes

Xbox

Surface Hub

IoT

Additional context

Wow, thats not great. It looks like this repro's in Winui2 as well..


Ignores rendererType

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

Environment:

OS: Raspbian/RaspberryOS 10.6
Browser: TorBrowser 10.0.4 (based on Mozilla Firefox 78.4.0esr) (64-bit)

I don't use TorBrowser, and it's not been officially supported by xterm.js.
To check if webgl is used on the context, call .getContext('webgl2') on the canvas element, it will return a WebGL2RenderingContext .


Help file doc/lualine.txt, "Starting lualine" section seems to be incorrect

lualine.txt has this content:
STARTING LUALINE                                      *lualine_starting_lualine*
>
    local lualine = require('lualine')
    lualine.status()
<

If I'm not misunderstanding something (likely as I'm new to lua+neovim), shouldn't this be the same as the startup instructions in README.md: require('lualine').setup{}?

Yes, you're right. The setup in README is correct . Thanks for reporting :) . It seems vimdocs are out of sync. @hoobrt you forgot about vimdocs again 😆

Yes, you're right. The setup in README is correct . Thanks for reporting :) . It seems vimdocs are out of sync. @hoob3rt you forgot about vimdocs again 😆

yikes, you are right. I will update it properly today

Thank you for taking a look, and for an cool plugin! Threw off the shackles of vim-airline today thanks to y'all.


Don't clean files after testsuite/mixed-domain

See comment in the diff for explanation.

retest this please


Ninject.ActivationException : Error activating IPresenter While Unit testing

I got the below error while writing unit testing with the help of Nunit. The below error occurred just after creating the instance of my derived class of MvvmNanoContentPage Class and assigning a ViewModel to it
Ninject.ActivationException : Error activating IPresenter
No matching bindings are available, and the type is not self-bindable.
Activation path:

Request for IPresenter

Suggestions:

Ensure that you have defined a binding for IPresenter.
If the binding was defined in a module, ensure that the module has been loaded into the kernel.
Ensure you have not accidentally created more than one kernel.
If you are using constructor arguments, ensure that the parameter name matches the constructors parameter name.
If you are using automatic module loading, ensure the search path and filters are correct.

The default Presenter is currently being registered in the application class (which implements MvvmNanoApplication). I guess this class isn't being used in before your test runs.
Workaround: Call MvvmNanoIoc.RegisterAsSingleton<IPresenter>(yourPresenter); before your test runs, where yourPresenter is an implemenation of IPresenter (could also be a mock by NSubstitute or some other mocking library).


Update download file

The download data file needs to be updated such that it also downloads the following data: Top 100 directors, via the link https://www.imdb.com/list/ls020777593/export?ref_=nmls_otexp.

The file was uploaded to the wrong part, so i have reopened the issue to do it right this time.


windows incompatible

  File "C:\Users\Jakub\python-video-silence-cutter\silence_cutter.py", line 26, in findSilences
    for i in range (len(words)):
                            ^^^^^
ValueError: could not convert string to float: '-2.08333e-05\\r'

cba

Thank you very much for reporting!
Can you possibly provide a video file?
I will need a while to fix this, as I'm too busy at the moment.

do not leave blank optional parameters when starting...

@kubinka0505
I'd like to analyze the problem. Could you please do the following:

Get the latest version of the script here on github.
Open silence_cutter.py, search for log_level = logging.ERROR and set it to log_level = logging.DEBUG.
Run the script on the video file inside testdata: python3 silence_cutter.py ./testdata/simple_video.mkv. In case the error does not occur with this file, could you use the file you had the error with?
Please share the silence_cutter.log file, that will be created

possibly related: https://github.com/DarkTrick/python-video-silence-cutter/issues/6


[TEP-0089] - Spire Package

Signed-off-by: pxp928<EMAIL_ADDRESS>
Changes
Spire package separated out from https://github.com/tektoncd/pipeline/pull/4759 as requested. It includes the spire interface with a mocked spire for testing. As requested by @afrittoli.
/kind feature
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[ ] Docs included if any changes are user facing
[x] Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Release notes block below has been filled in
(if there are no user facing changes, use release note "NONE")

Spire package that includes the controller and entrypointer API that is used in for [TEP-0089: Non-falsifiable provenance support](https://github.com/tektoncd/community/blob/main/teps/0089-nonfalsifiable-provenance-support.md). This is just the spire package. The phase 1 PR for the TEP is located here -> https://github.com/tektoncd/pipeline/pull/4759

/ok-to-test

Thanks @pxp928 for moving this to a separate PR!
I'm reviewing the PR, but I find the module structure and test strategy not 100% clear:
In my understanding this is the role of each module is:

spire.go: defines two interfaces, ControllerAPIClient and EntrypointerAPIClient. (NIT: maybe we call call this clients?)
controller.go: implements some of ControllerAPIClient, including type, constructor and some of the required method, except for VerifyTaskRunResults
verify.go: implements the rest of ControllerAPIClient, specifically VerifyTaskRunResults (NIT: maybe call this controller_verify?)
entrypointer.go: implements some of  EntrypointerAPIClient, including type, constructor and some of the required method, except for Sign
sign.go: implements the rest of EntrypointerAPIClient, specifically VerifyTaskRunResults, specifically VerifyTaskRunResults (NIT: maybe call this controller_verify?)esults` (NIT: maybe call this entrypointer_sign?)
spire_mock.go: defines a mock implementation of both interfaces. This bypasses most of the code in all the actual implementation, but it does invoke some of the actual functions, like verifyManifest and getResultValue
spire_mock_tests.go: unit tests for spire_mock.go. These tests verify the logic in the mocks and some private functions in the verify and sign modules, but I find this a bit problematic:

it's very opaque what is tested and what not by the unit tests. This will make changing the code in future a rather convoluted task as changing private functions might break mock unit tests that depend on them. We have a coding guideline of testing only exported functions, and this is doing the opposite
there is no unit test coverage at all for a lot of the code defined in the actual implementations

The structure I would expect for this is something like a mock client, that implements only functions that already exists in the original client, something like dial, close, get resource, list resources, create resource, delete resource. The ControllerAPIClient and EntrypointerAPIClient would only be responsible for implementing higher abstraction functions like  VerifyTaskRunResults and Sign. They would take a client as input, which would be the actual client at runtime, or the mock client at unit test time.
/cc @tektoncd/core-maintainers thoughts?

/kind feature

/retry

/retest

@vdemeester @afrittoli @wlynch Should be ready for another review. @lumjjb added the injection piece and I have added the fakeworkloadapi unit tests to test the spire "sign" and "verify" functionality. I have also added some missing pieces to the spire package that are needed for phase 2 (signed TaskRun). This will allow the other two follow on PRs to utilize all the functionality from the spire package for TaskRun results and status signing and verification.
Once the review is complete. I will squash all the commits into one before it gets merged.

/restest

@vdemeester @afrittoli @wlynch Should be ready for another review. @lumjjb added the injection piece and I have added the fakeworkloadapi unit tests to test the spire "sign" and "verify" functionality. I have also added some missing pieces to the spire package that are needed for phase 2 (signed TaskRun). This will allow the other two follow on PRs to utilize all the functionality from the spire package for TaskRun results and status signing and verification.
Once the review is complete. I will squash all the commits into one before it gets merged.

/retest

/retest

@afrittoli Also seems like we need your help to figure out how to initialize the context for client injection during initialization of the entrypoint, controller (cmd/entrypoint/main.go) etc.

/retest

/retest

/assign @vdemeester @jerop @pritidesai - assigning TEP approvers to the matching PR review :)

Is this a verbatim copy, or are we making modifications?

Yes the pkg/spire/test folder is a verbatim copy from the upstream project. No modification were made.

/retest

/retest

/retest

@wlynch @pritidesai changes made PTAL!

/retest

/retest

Hi @pritidesai we've made your requested! Can you take a look at the PR again - would like to get this across the line! Thanks!

Since this PR already has an LGTM from me and has been sitting without additional feedback for weeks, I'm going to go ahead and remove the hold to let this submit.
Nothing in this PR is a one-way door decision and is not wired up to the controller yet, so there's not much risk in submitting this even if there is additional feedback. Feel free to continue to leave feedback on this PR - we can follow up with additional PRs if needed!
/remove-hold

Great to see this moving forward! I'm sorry I wasn't able to re-review before, but I'm glad to see progress.


Embed Info.plist in binary and reference that for version.

This will embed the Info.plist into the binary itself, so that version can be maintained in the Xcode project's General > Version field rather than the swift file itself. This should cut down on accidental updates without modifying the version.
You can test that the Info.plist is successfully embedded in the binary with otool -P /path/to/dockutil or just test using the --version flag as it still works.
@kcrawford Thanks for the awesome work on this tool, it has been an asset of ours and the MacAdmins community for years.

I love it.  Thanks


kpng binaries for download

Please create binaries for linux, windows and darwin to make available for users download.
For windows specially, this can help https://github.com/kubernetes-sigs/sig-windows-dev-tools project. During the deploy of windows node, scripts can download kpng.exe from https://github.com/kubernetes-sigs/kpng/releases automatically and replace kube-proxy
Patch available for test here, fell free to send a new PR.
https://github.com/kubernetes-sigs/kpng/pull/219
See-also: https://github.com/kubernetes-sigs/kpng/issues/221

/good-for-the-first-issue
Helps integration with: https://github.com/kubernetes-sigs/sig-windows-dev-tools

/good-first-issue

/assign @rajaskakodar


Implemented OrderSelect

Here is a first beta of the order_select question (Discussed in [#13]), but i'ts not complete.
I still have to :

[x] implement the automatic test module, since I tested it manually

I intentionally not implemented many functions in the builder (choice, choice_with_default, separator, default_spearator, choice_with_default) for the following reasons :

Since the user will mix the order of the options in the list, separators aren't necessary,
"Choice" and "choice with default" don't seem necessary anymore to me, because the programmer can compose the list and set the order of the options before building the question.

Let me know if you want changes in the code.
Only tested on Windows 11.

For the testing i removed the ui::assert_backend_snapshot!(backend), since it will change the view in the terminal with the  and  keys

The implementation is now completed

Yeah, there is a ton of things to change. I'll do that in the next days.
Thanks for reporting things to change !

I'm not really sure the use of ChoiceList<Text<ListItem>> will be the best option here.
What's the advantage of using ChoiceList<Text<ListItem>> ? A Vec<ListItem> is easier to implement and we can still access the str.

Vec<T> doesn't implement the List trait which is required for Select to work (see this bound). Vec doesn't implement List as it cannot implement the functions page_size and should_loop. As for the the Text, it is to allow multiline text. If you look at the implementation of the Text widget, it is relatively expensive to compute the line breaks, so this computation is memoized. That is why a regular &str is single line only. I hope this answers your question

Ok i'll stick with ChoiceList then, however it's crate private.
Does it mind if i have to make it public ?

And also since it's a list of Choice enum, the user will have to unwrap the choices, which is a problem for the validate function since the user is dealing with a reference to the list.
The only option i see here is to not use the Choice enum at all. Since we do not allow the separators, we can remove it completely.

Yeah, getting a decent API surface is difficult here because of the internals, but I think I have a found a good solution.
I'm going to push a change that converts ChoiceList<T> to a more generic SelectList<T>. In SelectList<T> the choices field will be just a Vec<T> (as opposed to the Vec<Choice<T>> which was previously there). I would also like you to add the following struct to order_select/mod.rs and re-export it in requestty::question:
/// The representation of each choice in an [`OrderSelect`].
///
/// It is different from [`ListItem`](crate::answer::ListItem) due to an implementation detail.
#[derive(Debug)]
pub struct OrderSelectItem {
    index: usize,
    text: Text<String>,
}

impl OrderSelectItem {
    /// The index of the choice
    pub fn index(&self) -> usize {
        self.index
    }

    /// The content of the choice -- it is what is displayed to the user
    pub fn text(&self) -> &str {
        &self.text.text
    }
}

impl Widget for OrderSelectItem {
    fn render<B: Backend>(
        &mut self,
        layout: &mut ui::layout::Layout,
        backend: &mut B,
    ) -> io::Result<()> {
        self.text.render(layout, backend)
    }

    fn height(&mut self, layout: &mut ui::layout::Layout) -> u16 {
        self.text.height(layout)
    }

    fn cursor_pos(&mut self, layout: ui::layout::Layout) -> (u16, u16) {
        self.text.cursor_pos(layout)
    }

    fn handle_key(&mut self, key: KeyEvent) -> bool {
        self.text.handle_key(key)
    }
}

Then, instead of using ChoiceList<Text<ListItem>>, we can use a SelectList<OrderSelectItem>.
OrderSelectBuilder::new can be changed as follows:
    pub(crate) fn new(name: String) -> Self {
        Self {
            opts: Options::new(name),
            order_select: SelectList::new(|_| true),
        }
    }

After making these changes, validate can take &[OrderSelectItem] and filter can take Vec<OrderSelectItem>. How does this sound?

Alright i'll implement this right now

Is there any thing to change in the code ? Maybe i've missed something

Still have to implement integration tests

I know there is the implementation tests to implement, but otherwise it seems i did all the changes you requested

Also there is the gif to make. Can you make it while i'm implementing the missing tests ?

Sure, I will make the gif and add it when this PR is ready to merge

The conversion can be performed before filter call and using ListItem can make filter more consistent, so i don't see any problem by doing this

By the way, i don't think the snapshots folder should be visible here, they are only caches after all

By researching, i found that changing type back to ListItem is problematic because we have to convert from OrderSelectItem each time the display is updated because of the transform function
From a performance perspective i don't know if this is an issue or not

Or we can implement a Trait for this, so we can keep this consistency

What i was meaning was that instead of storing the snapshots on this repository, the developer can build the snapshots themselves before performing tests
That's why i suggested to add a category in README.md or another file, so the future developers know how to perform tests correctly

Also here how i'll implement back ListItem

I'll change ListItem into a new generic type GenericListItem so i can put Text struct into it
To keep compatibility i added a Type alias ListItem = GenericListItem<String>
Before calling validation, filter, and transform function, i convert this type back to ListItem

What do you think about this way ?

I feel like I didn't convey my point across properly. I do not want to change the types for validate and filter. I only want to change them for transform. Thus OrderSelect will change as follows:
#[derive(Debug)]
pub(super) struct OrderSelect<'a> {
    choices: SelectList<OrderSelectItem>,
    max_index_width: usize,
    moving: bool,

    transform: Transform<'a, [ListItem]>, // Only thing that changes
    validate: Validate<'a, [OrderSelectItem]>,
    filter: Filter<'a, Vec<OrderSelectItem>>,
}

And the Prompt impl for OrderSelectPrompt will change as follows:
 impl Prompt for OrderSelectPrompt<'_, '_> {
    // ...
    type Output = Vec<ListItem>;
    // ...
    fn finish(self) -> Self::Output {
        // ...
        c.into_iter()
            .map(From::from)
            .collect()
    }
    // ...
}

And the From<Vec<OrderSelectItem>> impl in answer.rs can be deleted. As you can see, this doesn't require the type to converted to ListItem every time, only at the end once the answer has been finalised.

What i was meaning was that instead of storing the snapshots on this repository, the developer can build the snapshots themselves before performing tests

The way snapshot tests work is as following:
When you first write the test, you run cargo snapshot and cargo snapshott (both need to be run). This will generate files in the form of *.snap.new in the crossterm-snapshots and termion-snapshots directories.
Then you run cargo review which gives you an interactive prompt to manually review that the snapshots generated are as expected. These will convert the files generated in the previous step from *.snap.new to *.snap.
Only after all of this is done, can the tests be run how they usually are. When running a test which contains ui::assert_backend_snapshot!(backend), it checks that the backend supplied to the macro matches the one present in the *.snap file. If it does not then the test fails.
I urge you to also read the content of the links here.
I hope you understand why the snapshots need to be stored in the repository. If you have any questions, please feel free to ask.

That's why i suggested to add a category in README.md or another file, so the future developers know how to perform tests correctly

Yes, I agree with adding documentation for how to run the tests correctly. This is definitely needed, but I will get to it after some time.

Maybe what you're trying to say here is that, in my way, the developer needs to accept each snapshot one after another, which can be tedious
But there is a command to accept them all at once : cargo insta accept
That's why is was suggesting to remove this folders, because the snapshots can be reconstructed with this series of command:

cargo snapshot
cargo snapshott
cargo insta accept

I hope you understand what i mean

Also for the implementation you suggested, i'm not very comfortable with the fact that there is different types for each functions of this builder, this can confuse the user
Yes, this can add consistency with the transform function of multi-select, but with the other functions of the same builder i think it will just do the opposite
Personally i would prefer to keep the same type for each function of the same builder here, to keep the consistency in the builder itself.
Also these function are usually configured at the same place, so if there is an inconsistency somewhere it will very noticeable
I hope you understand my point of view on this subject

I understand where you are coming from. The reason I suggested the change was that maintaining compatibility with multi-select's transform allows more code reuse as they have very significant overlap, both in type signature as well as purpose.
However, the point you raise is also valid. I leave the final decision of whether to change the type for transform up to you.

By the way, the snapshott command doesn't work on windows, termion is missing his sys crate Maybe i did a thing wrong

Yes, the termion library does not work on windows. It is a decision that the authors have made, and I have no control over it. That is one of the reasons why crossterm is the default backend.
Since you are running windows, don't worry about the termion snapshots, I will update them.

Maybe what you're trying to say here is that, in my way, the developer needs to accept each snapshot one after another, which can be tedious
But there is a command to accept them all at once : cargo insta accept
That's why is was suggesting to remove this folders, because the snapshots can be reconstructed with this series of command:
1. `cargo snapshot`

2. `cargo snapshott`

3. `cargo insta accept`

Yes, cargo insta accept does accept all the snapshots, but using it voids the purpose of the snapshot tests. The snapshot tests are meant to make sure that whatever is displayed on the screen is correct.
Take the following example. Let's say that through some change for a different purpose, accidentally in OrderSelect, the index being displayed is wrong (the error can be a lot more subtle than this, but this is just an example).
Currently as it is the snapshots are stored. They are checked to be correct when they are created and only then accepted. Then if the rendering changes by accident, the index in the test would not match the one in the snapshot, and so the test would fail.
If snapshots were not stored, and the 3 commands above were run, the snapshots created would include the wrong index as cargo insta accept accepts unconditionally. And so all tests would pass event though they shouldn't. The only way to prevent this is to check that every snapshot looks correct which would then convert the snapshot tests from being automated to manual. This would also prevent the snapshot checks in the CI from actually catching things that look wrong as it always accepts the snapshot as it is.

We can keep them if you want, it was just an important suggestion after all

We will keep them, but I feel it is important that you understand why we need to keep them

Since the only difference between OrderSelectItem and ListItem is the type of the text (Text<String> against String), what about modifying ListItem so it can accept any type T and not only String ?
This way both of our requirements are satisfied, you have the ListItem and i have the same type for the builder functions
Also OrderSelectItem implements the Widget trait to be rendered, but we can render it‘s text directly instead, so in theory we can use ListItem which contains it
The only con is that we need to access the text attribute of the text, so compared to ListItem there is a little inconsistency here. But compared to the difference between ListItem and OrderSelectItem in the ways to access data this is way less noticeable in my opinion

I prefer to keep OrderSelectItem as a separate thing instead of making ListItem generic.
The reason that OrderSelectItem has a different access pattern than ListItem is that exposing the Text struct in the requestty interface is something I really want to avoid.

Ok so OrderSelect should be ready now

Also now i understand for the snapshots folder, thanks for the explanation

Congrats, this PR has been merged!


Test the uniqueness of language ids

A new test for #3205 to check that language ids are unique. With this test I'm hoping to catch some of the incorrect additions of language_ids without using script/set-language-ids.

😻 thanks!


Feat accept request

i merged into feat-feed. we can pull into devel once either of those two is finished


How do I handle initial checked nodes ?

I don't see any prop to handle initial checked nodes.
I think it's a common feature for a tree component.
Am I missing something ?

Actually this project has not been released yet and is still in development. But we forgot to declare it in the README.
However, I will quickly integrate this feature you reminded me of. Thanks for your feedback.

You can use the v0.10.0 version. @matschik
Check docs: https://teamseodo.github.io/vue3-tree/guide/props.html#nodes

It's working like a charm !
Thank you so much 🙏
Amazing reactivity 🔥


Remove BatchQuery::is_prepared field

The is_prepared field is duplicating state from the subject field.

Thanks! That's another thing from the ancient times of original cdrs. It's hard to spot them all.


Add support to charset on Content-Type header

If I specify the header as Content-Type: application/x-www-form-urlencoded; charset=UTF-8 it breaks because of validation mismatch.

Try the newer version 3.0.0, it works (not only with URF-8 charset but with all)


Failed: Update autorest version to prerelease 3.0.0-alpha.20240517.9

Triggered from pull request: https://github.com/Azure/autorest.csharp/pull/4432

API change check
API changes are not detected in this pull request.


TextInput.State.currentlyFocusedField() retrun undefined when TextInput with  prop multiline=true

Environment
System:
OS: macOS High Sierra 10.13.5
CPU: x64 Intel(R) Core(TM) i7-5557U CPU @ 3.10GHz
Memory: 865.03 MB / 16.00 GB
Shell: 5.3 - /bin/zsh
Binaries:
Node: 10.1.0 - ~/.nvm/versions/node/v10.1.0/bin/node
npm: 6.1.0 - ~/.nvm/versions/node/v10.1.0/bin/npm
Watchman: 4.1.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 11.4, macOS 10.13, tvOS 11.4, watchOS 4.3
Android SDK:
Build Tools: 23.0.1, 25.0.2, 26.0.1, 26.0.2, 26.0.3, 28.0.0
API Levels: 23, 25, 26, 28
IDEs:
Android Studio: 3.1 AI-173.4819257
Xcode: 9.4.1/9F2000 - /usr/bin/xcodebuild
npmPackages:
react: 16.4.1 => 16.4.1
react-native: 0.56.0 => 0.56.0
npmGlobalPackages:
react-native-cli: 2.0.1
react-native-git-upgrade: 0.2.7
Description
TextInput.State.currentlyFocusedField() can not work once i add prop multiline=true on TextInput after i upgraded RN from 0.55.4 to 0.56.0

@wangshangming please remove the formatting from the environment description, so that the issue can be considered valid.

@canastro thanks for reminding

@janicduplessis did your commit: https://github.com/facebook/react-native/commit/b4b594cec1d91c38faac11a90a787ae692e35296 fixed this issue as well?

Some problem even if TextInput is not multiline. Any solution?

+1

b4b594c does fix this but has not made it into the 0.56 release, I requested a cherry pick in the next release but for now you can either use 0.57-rc or stay on 0.55 until it is cherry-picked.


Support Go Modules

Hello,
Please consider supporting Go Modules, the new packaging standard that will be adopted fully in Go 1.12.
Because this library is still below version 2 and is already using semver compatible tags, the go.mod file is fairly simple.
It should also be noted that I picked 1.5 as the version of the Go language being used because it was the earliest version that the CI config was testing against; this won't break compatibility with 1.5, but it won't be able to use the mod file and I'm not sure if the new tooling actually supports warning about using newer language features and APIs that far back. At worse though this is no different than today and nothing will be broken.
Thank you for your consideration.

Waiting for CI/CD.  I may want to rethink our use of goconvey in the future. .. it brings in a lot of additional dependencies, which most of the times we don't need (only for test).
Probably also I will want to bump the go version -- go versions below 1.9 won't see that file anyway, and I need to stop trying to support go versions that the go team have deprecated.

Sounds good; pushed a change to test/support Go 1.9+ instead.

I believe I've removed the dependency on goconvey.  Please do a go mod tidy to see if that clears it up.

LGTM; thanks!

Thanks for the merge! Any chance this can be tagged with a version I can pin too now? Thanks again.

Yes, I will do so momentarily.  I’m probably going to be making other changes to this code soon… I want to fix Windows terminal stuff for 256 color and there are some other PRs I really need to work on.

Garrett

Sent from Mail for Windows 10
From: Sam Whited
Sent: Thursday, December 20, 2018 3:18 PM
To: gdamore/tcell
Cc: gdamore; State change
Subject: Re: [gdamore/tcell] Support Go Modules (#249)
Thanks for the merge! Any chance this can be tagged with a version I can pin too now? Thanks again.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.


Move dynamodb session setup into per-request lifecycle

What is the context of this PR?
This removes the setup of the dynamodb session from the app setup as this is recommended to me per thread.
How to review

Check that question playback still functions

@nealedj can be squashed and we'll merge it after.

@shahi645 we don't use the "update" button as it causes messy commit history

ahh okay, my bad


Fix test class inheritance and absolute paths

Fixes #1 and fixes #2

Tests are broken because Reflection can not find Codeception\Test\Unit class... not sure how to fix that.

Thanks! I will take it from this point

@cebe Thanks! I fixed the autoloading of additional classes. Had to add 2 more reflection sources. Please update to 0.1.8 and check if it works for you.
I remember I couldn't get it working for nested classes but now with your help it actually works!


Stories/verilog2circuit

Fixes #
Describe the changes you have made in this PR -
Screenshots of the changes (If any) -
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

Coverage decreased (-0.1%) to 87.843% when pulling b660f3cfe5584954c412f57b3ac76e2b27f08b12 on stories/verilog2circuit into 7b3ecb4e6141c681cebf0c1533176fc2bb7e2ce9 on new_UI.


Receive Counts with Recursive Methods

Hi, running into an issue with the Receive Counts functionality in rspec-mocks, unsure if it's a bug or if it's misuse on my part. Assume I have a simple recursive method in a class:
class Bar
    def foo(i=5)
        puts "Foo"
        if i > 1
            foo(i-1)
        end
    end
end

I want to write a spec to ensure that it's recursing the correct number of times, so I thought this might be the correct spec to write:
...
# assume bar is an instance of Bar
expect(bar).to receive(:foo).exactly(5).times
bar.foo
...

This spec fails for me claiming that bar.foo is only getting called once. Any help is appreciated!

When you expect or allow a message it defines it as a no-op by default (rather than falling through to your logic). If you want it to fall through, tack on 'and_call_original'.

That did it! Thank you!


When open presentation, some bugs come.

Ohhh nice find, seams like rendering of slides in subfolders had a bug, will be fixed with 1.3.1

This issue should be fixed with 1.4.0, please retest


No curation ephys AND kilosort triggering

Fix #34
Fix #40
Fix #37

I suggest closing this PR, removing NWB export and issue a new PR.
As NWB export is implemented and PR'ed on #44 .
A fresh PR would also make it easier to review.
Thoughts @kabilar @CBroz1 ?

Hi @ttngu207,
Happy to review in this pull request or a new one.  You're right.  We should remove the NWB export from the pull request.    I will review this work next week.

Per discussion with @kabilar, I'm closing this PR, removing the NWB export, and reissue as new PR


How to use cmake option 'NANOPB_OPTIONS'

I am trying to force the option option (nanopb_msgopt).no_unions = true; to all my .proto files.
I noticed the cmake variable NANOPB_OPTIONS.
I tried: set(NANOPB_OPTIONS -s \(nanopb_msgopt\).no_unions:true) but got the error message:
google.protobuf.text_format.ParseError: 1:1 : Expected identifier or number, got ;.

I also tried: set(NANOPB_OPTIONS -s no_unions:true) but also got the error message:
google.protobuf.text_format.ParseError: 1:1 : Expected identifier or number, got ;.

I also tried through the command line: protoc --plugin=nanopb/generator/protoc-gen-nanopb '--nanopb_out=-s no_unions:true:.' --proto_path=../examples/test_simple/ --proto_path=nanopb/generator/proto  ../examples/test_simple/simple.proto
and I also have error:
Traceback (most recent call last):
  File "nanopb/generator/nanopb_generator.py", line 1871, in <module>
    main_plugin()
  File "nanopb/generator/nanopb_generator.py", line 1850, in main_plugin
    other_files[fdesc.name] = parse_file(fdesc.name, fdesc, options)
  File "nanopb/generator/nanopb_generator.py", line 1658, in parse_file
    text_format.Merge(s, toplevel_options)
  File "/home/olivier/.local/lib/python2.7/site-packages/google/protobuf/text_format.py", line 536, in Merge
    descriptor_pool=descriptor_pool)
  File "/home/olivier/.local/lib/python2.7/site-packages/google/protobuf/text_format.py", line 590, in MergeLines
    return parser.MergeLines(lines, message)
  File "/home/olivier/.local/lib/python2.7/site-packages/google/protobuf/text_format.py", line 623, in MergeLines
    self._ParseOrMerge(lines, message)
  File "/home/olivier/.local/lib/python2.7/site-packages/google/protobuf/text_format.py", line 638, in _ParseOrMerge
    self._MergeField(tokenizer, message)
  File "/home/olivier/.local/lib/python2.7/site-packages/google/protobuf/text_format.py", line 749, in _MergeField
    tokenizer.Consume(':')
  File "/home/olivier/.local/lib/python2.7/site-packages/google/protobuf/text_format.py", line 1101, in Consume
    raise self.ParseError('Expected "%s".' % token)
google.protobuf.text_format.ParseError: 1:10 : Expected ":".
--nanopb_out: protoc-gen-nanopb: Plugin failed with status code 1.

Sounds like the issue is passing : through protoc, which itself uses : as separator between plugin options and path.
I don't currently have time to dig through protoc source code for an answer to that.
You could try running in two steps, that makes passing nanopb options much easier:
protoc -ofoo.pb foo.proto
python nanopb_generator.py -s no_unions:true foo.pb

For later reference, I am using a old protoc (v3.0.0 from Ubuntu 18.04 LTS) - and I have not tried yet with a newer version.
And I have just tried passing an additional parameter to --nanopb_out and I have a new error:
protoc --plugin=nanopb/generator/protoc-gen-nanopb '--nanopb_out=-v,-s no_unions:true:.' --proto_path=../examples/test_simple/ --proto_path=nanopb/generator/proto  ../examples/test_simple/simple.proto
... PARAMS: -v,-s no_unions
Usage: Usage: protoc --nanopb_out=[options][,more_options]:outdir file.proto

nanopb_generator.py: error: no such option: -,
--nanopb_out: protoc-gen-nanopb: Plugin failed with status code 2.

I am happy to raise this issue to protoc after trying the latest version. But I have not found where it is documented protobuf extension support argument passing through .._out=list_args:OUT_DIR

I'm not sure if it is even documented on protoc side.

Hello @oliviermartin
You don't need any , to add options to --nanopb_out Juste let an empty space between and it should work.
protoc --plugin=nanopb/generator/protoc-gen-nanopb '--nanopb_out=-v -s no_unions:true:.' --proto_path=../examples/test_simple/ --proto_path=nanopb/generator/proto  ../examples/test_simple/simple.proto

I think this should work now in 0.4.0. Please reopen if there are still issues.

I'm trying to use '--nanopb_out=-v -s submsg_callback:true:.' and the same error appears
google.protobuf.text_format.ParseError: 1:16 : Expected ":".

I'm using protobuf version 3.13.

@bonastreyair Hmm yeah, the way it is fixed in CMake rules is using the (new, undocumented?) protoc option --nanopb_opt.
You can use it like this: ~/nanopb/generator/protoc '--nanopb_opt=-v -s submsg_callback:true' --nanopb_out=. test.proto

Thank you so much, it works!
I think that adding this information in the documentation would help a lot to other users. 😃


Prettier Github actions fails on kebab-case branches

The prettier action cannot checkout kebab-case branches. Maybe complete a pull request on the action repo?

I have put a bug label on this, thank you for raising 👍

I have put a bug label on this, thank you for raising 👍

#319 has a screenshot of the error.

Is this still an issue? Have made PRs with branches named like patch-1, but didn't got any failing action for the reason.


Python3Packages.pgsrip: init at 0.1.9

Description of changes

pgsrip: tool to rip PGS subtitles
trakit: guess additional information from track titles (dependency)
cleanit: command-line tool to clean subtitles (dependency)

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 316209 run on x86_64-linux 1

8 packages built:

cleanit (python311Packages.cleanit)
cleanit.dist (python311Packages.cleanit.dist)
pgsrip (python311Packages.pgsrip)
pgsrip.dist (python311Packages.pgsrip.dist)
trakit (python311Packages.trakit)
trakit.dist (python311Packages.trakit.dist)
python312Packages.trakit
python312Packages.trakit.dist

Result of nixpkgs-review pr 316209 run on x86_64-linux 1

12 packages built:

cleanit (python312Packages.cleanit)
cleanit.dist (python312Packages.cleanit.dist)
pgsrip (python312Packages.pgsrip)
pgsrip.dist (python312Packages.pgsrip.dist)
python311Packages.cleanit
python311Packages.cleanit.dist
python311Packages.pgsrip
python311Packages.pgsrip.dist
python311Packages.trakit
python311Packages.trakit.dist
trakit (python312Packages.trakit)
trakit.dist (python312Packages.trakit.dist)

12 packages built:

cleanit (python312Packages.cleanit)
cleanit.dist (python312Packages.cleanit.dist)
pgsrip (python312Packages.pgsrip)
pgsrip.dist (python312Packages.pgsrip.dist)
python311Packages.cleanit
python311Packages.cleanit.dist
python311Packages.pgsrip
python311Packages.pgsrip.dist
python311Packages.trakit
python311Packages.trakit.dist
python312Packages.trakit
python312Packages.trakit.dist

Moved pgsrip to be an application since we don't really need its module.

Result of nixpkgs-review run on x86_64-linux 1

10 packages built:

cleanit (python312Packages.cleanit)
cleanit.dist (python312Packages.cleanit.dist)
pgsrip
pgsrip.dist
python311Packages.cleanit
python311Packages.cleanit.dist
python311Packages.trakit
python311Packages.trakit.dist
python312Packages.trakit
python312Packages.trakit.dist

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 316209

x86_64-linux

:white_check_mark: 10 packages built:

cleanit (python312Packages.cleanit)
cleanit.dist (python312Packages.cleanit.dist)
pgsrip
pgsrip.dist
python311Packages.cleanit
python311Packages.cleanit.dist
python311Packages.trakit
python311Packages.trakit.dist
python312Packages.trakit
python312Packages.trakit.dist

@ofborg build pgsrip


Add table aws_s3_multi_region_access_point closes #1473

Integration test logs

Logs
N/A

Example query results

Results
> select
  alias,
  status,
  created_at
from
  aws_s3_multi_region_access_point;
+--------------------+--------+---------------------------+
| alias              | status | created_at                |
+--------------------+--------+---------------------------+
| m835bga7jp7rc.mrap | READY  | 2022-12-06T16:05:55+05:30 |
| mjhn6iw4rjacs.mrap | READY  | 2022-12-05T21:17:42+05:30 |
+--------------------+--------+---------------------------+

> select
  name,
  public_access_block ->> 'BlockPublicAcls' as block_public_acls,
  public_access_block ->> 'BlockPublicPolicy' as block_public_policy,
  public_access_block ->> 'IgnorePublicAcls' as ignore_public_acls,
  public_access_block ->> 'RestrictPublicBuckets' as restrict_public_buckets
from
  aws_s3_multi_region_access_point
where
  public_access_block ->> 'BlockPublicAcls'::text = 'true'
and
  public_access_block ->> 'BlockPublicPolicy':: text = 'true'
and
  public_access_block ->> 'IgnorePublicAcls':: text = 'true'
and
  public_access_block ->> 'RestrictPublicBuckets':: text = 'true';
+-------------------+-------------------+---------------------+--------------------+-------------------------+
| name              | block_public_acls | block_public_policy | ignore_public_acls | restrict_public_buckets |
+-------------------+-------------------+---------------------+--------------------+-------------------------+
| test46            | true              | true                | true               | true                    |
| test-multi-region | true              | true                | true               | true                    |
+-------------------+-------------------+---------------------+--------------------+-------------------------+

> select
  r ->> 'Bucket' as bucket_name,
  count(name) access_point_count
from
  aws_s3_multi_region_access_point,
  jsonb_array_elements(regions) as r
group by
  bucket_name;
+--------------------+--------------------+
| bucket_name        | access_point_count |
+--------------------+--------------------+
| redshift-test-logs | 1                  |
| test-delete90      | 1                  |
+--------------------+--------------------+

> select
  a.name,
  r ->> 'Bucket' as bucket_name,
  b.creation_date as bucket_creation_date,
  b.bucket_policy_is_public,
  b.versioning_enabled
from
  aws_s3_multi_region_access_point as a,
  jsonb_array_elements(a.regions) as r,
  aws_s3_bucket as b
where
  b.name = r ->> 'Bucket';
+-------------------+--------------------+---------------------------+-------------------------+--------------------+
| name              | bucket_name        | bucket_creation_date      | bucket_policy_is_public | versioning_enabled |
+-------------------+--------------------+---------------------------+-------------------------+--------------------+
| test46            | redshift-test-logs | 2022-09-28T19:24:36+05:30 | false                   | false              |
| test-multi-region | test-delete90      | 2022-09-21T11:44:06+05:30 | false                   | false              |
+-------------------+--------------------+---------------------------+-------------------------+--------------------+

@ParthaI Pls re-work on this to map the new changes in 0.93.0


Bring Microsoft.Bot.Schema to 100% code coverage (Part 1)

Fixes #5474
Write unit tests to bring Microsoft.Bot.Schema to 100% code coverage 🎊🥳🎉
Original Microsoft.Bot.Schema Coverage: 19.41%

Current Coverage: 100.00%

This is Part 1, unit test addition.
To be followed up with Part 2, code cleanup in .Schema.
Breaking up the 2 PRs, due to sheer number of tests that need to be added to bring coverage to 100% here

@mrivera-ms Broke the behemoth into Parts 1 and 2, and are ready for review, whenever you are.

Pull Request Test Coverage Report for Build 247909

0 of 0   changed or added relevant lines in 0 files are covered.
9 unchanged lines in 5 files lost coverage.
Overall coverage decreased (-0.04%) to 78.782%

Files with Coverage Reduction
New Missed Lines
%

/libraries/Microsoft.Bot.Builder/DelegatingTurnContext.cs
1
88.24%

/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Recognizers/EntityRecognizers/TextEntityRecognizer.cs
1
85.71%

/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/DatetimePrompt.cs
1
77.5%

/libraries/Microsoft.Bot.Builder/Adapters/TestFlow.cs
2
78.32%

/libraries/Microsoft.Bot.Builder.Dialogs/Memory/DialogStateManager.cs
4
78.76%

Totals

Change from base Build 247127:
-0.04%

Covered Lines:
18149

Relevant Lines:
23037

💛  - Coveralls


Modules opening firewall ports by default

Issue description
Certain NixOS modules open firewall ports by default. According to the Nixpkgs manual this is not desired behaviour, with an exception for sshd https://github.com/NixOS/nixpkgs/pull/75454#issuecomment-564573908.
This could break existing setups, so I would be interested to here from maintainers what the best mitigations would be e.g.

Recording the changed default in release notes
Warning at evaluation if open{Ports|Firewall} is not explicitly set for these services
Gating the new default behaviour behind a stateVersion check

Known offending modules:

[x] services/networking/unifi.nix
[x] services/video/unifi-video.nix
[ ] services/networking/avahi-daemon.nix
[ ] services/cluster/hadoop/hdfs.nix
[x] services/audio/snapserver.nix

Notify Maintainers
@erictapen @pennae (unifi)
@rsynnest (unifi-video)
@tobim (snapserver)

I think the evaluation warning makes the most sense, but it should mention some kind of deprecation window, so it can be removed in a year or so. Would be happy to review such a PR for services/networking/unifi.nix, but I'm afraid I have no time currently to implement it myself.

I agree with a deprecation warning, but we should also put it into the release notes. I'll try to fix snapcast by the end of the year.

Pings for the remaining modules based off git blame, sorry if it should have been somebody else!
@WilliButz (avahi) @illustris (hdfs).

Based on discussions here and on matrix we are leaning towards warning in 22.05 if not explicitly set and changing the default to false in 22.11.

Certain NixOS modules open firewall ports by default. According to the Nixpkgs manual this is not desired behaviour, with an exception for sshd #75454 (comment).

Also see #81490.


Build error !! - Add FIRApp configure.

Hello.
Spent a lot of time to build my project for IOS.
and I saved GoogleService-Info.plist in folder ( Project -> Resources )
I cannot find any reason why this would happen. Here is the code:
2020-07-09 09:53:20.006416+1200 pushtest[11839:871372] 6.27.0 - [Firebase/Core][I-COR000003] The default Firebase app has not yet been configured. Add [FIRApp configure]; (FirebaseApp.configure() in Swift) to your application initialization.

Hi,
Thanks, But I have a same error.
Please check below image file. It is your test sample.
Thanks


Can it work on other threads not only on the main thread?

Can it work on other threads not only on the main thread?
I'd like to populate the ObsevableCollection from background threads and have the map display the Pins whenever the collection gets changed. Is this possible to do so with the Map control like with lets say a Picker, or is this a limitation of the Map itself?
Thank you!

i just tested on main thread


Improve find by tracking actual rendered text

At a minimum, this should improve #9275.
Problem: The notebook find model used to use markdown cells' source with some heuristics to get the index for which element to highlight for find results in markdown cells. This causes find not to work for many notebooks.
This solution: The notebook find model needs to access the actual rendered innerText. As long as we use the same mapping array of html elements for finding ranges and doing the actual highlighting, we solve a whole host of issues. We store this rendered output array in the cell model, which is accessible for both the text cell component and the notebook find model.

As long as the tests are fixed, changes look good! Thanks Chris for improving this!


--manifest-path foo/fake works

$ cargo new test
$ cargo build --manifest-path test/fake
   Compiling test v0.1.0 (file:///home/huon/projects/test-rust/test)

This seems fairly peculiar. It looks a bit like it strips the last segment of the path without looking at it at all.

Sounds like it assumes the last path segment is Cargo.toml and pops it unconditonally, then it appends Cargo.toml back to the new path. It might as well just take the directory to search in if it's going to ignore the actual manifest path. Do we want to support manifest files named something other than Cargo.toml? If not, this should be changed to --manifest-dir and the value should be read as a directory.

This option has always confused me and it's been an endless source of confusion in terms of good error messages and such. I'm honestly not 100% sure what the original intention for the flag was, @wycats do you remember what the precise semantics of --manifest-path were supposed to be?

Soooo funny story... there's this comment on a similar issue that says "I believe this was fixed in #1182.", but #1182 is a pull request that was closed without merging....
I've just opened #1955 that is heavily influenced by #1158 and should also fix this issue :)

Holy cow, that would explain why I'm always so confused about why these issues come up, I could have sworn I fixed them! I'm... not sure what happened to #1182? Maybe I accidentally deleted the branch? Regardless #1955 is looking good to me!

Since #1955 got merged, I think this is fixed:
$ cargo new test
$ cargo build --manifest-path test/fake
the manifest-path must be a path to a Cargo.toml file

Sorry, I should have put a "Fixes #1773" in that issue :)

Thanks @carols10cents!


Migrate from tfenv to tenv

Hi! I saw that you're using tfenv in this repository. It's a really good tool, but it does not support OpenTofu and Terragrunt. My team designed a successor of tenv that support Terraform, Terragrunt and OpenTofu. It will be a good idea to migrate into it in due to the growing popularity of OpenTofu.
url: https://github.com/tofuutils/tenv

Hi @kvendingoldo !  Thanks for writing in.  We're actively working on replacing tfenv throughout the stack, you should see updates here shortly.  I believe the team has settled on mise as the replacement tool-installer of choice.


can't  resovle servicename in k8s

I find this problem in my kubernetes cluster :
wangdf@ubuntu-16:~/works/github.com$ k exec -it prometheus-0 -n monitoring sh
/prometheus $ nslookup kubernetes.default.svc
Server:         <IP_ADDRESS>
Address:        <IP_ADDRESS>:53
** server can't find kubernetes.default.svc: NXDOMAIN
*** Can't find kubernetes.default.svc: No answer
I think prometheus(busybox) container can't resolve service name in k8s.
I have tried other container , it was OK！
p
I think it is related to bosybox docker container, anyone will  help me ?😃

It makes more sense to ask questions like this on the prometheus-users mailing list rather than in a GitHub issue. On the mailing list, more people are available to potentially respond to your question, and the whole community can benefit from the answers provided.


Delay in receipt of new coords for some clients

Possibly due to the "await async" call in the server code?

Work in progress to convert from use of gRPC to UDP.

UDP working. This is no longer an issue.
Closing.


Language polishing

PR #s to be added

[x] * #1829 security / scopes
[x] * #2181 $ref siblings   [There has been no strong case made for other properties that should be allowed as sibilings.]

@MikeRalphson   Unless you feel strongly that we should consider adding other properties as potential siblings of $ref then I propose we defer adding more until later releases.

I don't understand 2181 - isn't v3.1 now supporting JSON Schema draft 2019-09 (which allows $ref to be a sibling to any other keyword)?

#2181 addresses $ref outside schema objects.