XSS in option name

Issue Summary
There is an XSS security issue as demonstrated in the below POC video
https://drive.google.com/file/d/1F4rGIsBkFnf7ENJC68ci2VfIpeGUaYHV/view?usp=sharing
django-oscar allows user to include JavaScript code on 'Option' feature.
Steps to Reproduce

Build your own django oscar shop like in this tutorial https://django-oscar.readthedocs.io/en/3.0.0/internals/getting_started.html#
Login as admin and create an option with name option <img src=A onerror=alert(document.cookie)>
Now create a product type and select the above option, see that the javascript code is executed and the page pops up with your cookies.
Now everyone who try to update this product or create a product with the option will be affected by the vulnerability.

The issue is submitted on huntr.dev platform, if you think the issue is valid, please mark it as valid here:
https://huntr.dev/bounties/c6ed0ec6-bcad-41a4-8f9a-5b0db7859db6/

Hi there, any update?

Hi @solarissmoke , would you mind mark the issue valid on huntr.dev?
https://huntr.dev/bounties/c6ed0ec6-bcad-41a4-8f9a-5b0db7859db6
Thank you.


Build: reduce size: enable production mode and minification for prod.

Enabled production mode: removed mode from webpack config as Webpack documentation says: "If mode is not provided via configuration or CLI, CLI will use any valid NODE_ENV value for mode."
Added fallback 'development' value for NODE_ENV in config.
Enabled minification for production.
Added yarn script serve-local-build for local testing of a production build without TLS certificates.
dist folder size reduction:
ODF: 14M ==> 2,6M
MCO:  6M ==> 1,2M

Signed-off-by: Alfonso Martínez<EMAIL_ADDRESS>

/assign @bipuladh

/test odf-console-e2e-aws

/approve

/lgtm


cmd/render: Infer etcd-servers from service-cidr for self-hosted etcd

Automatically set —etcd-servers to —service-cidr base IP + 15.
For example, if —service-cidr=<IP_ADDRESS>/24, —etcd-servers=http://<IP_ADDRESS>:2379.
Fixes https://github.com/kubernetes-incubator/bootkube/issues/329

ok to test

This patch should fix the issue as specified in https://github.com/kubernetes-incubator/bootkube/issues/329, but the implicit override would probably be confusing to a user if they also explicitly set the --etcd-servers option. May want to refactor that logic a bit.

Looks like the tests failed, but I don't have permission to view the test results, so not sure if it was flakiness, or legit problems?

rktbot run tests

@pbx0 RFR again.


Fixes#27837.making the   height of  compose  buttons  steady.

Fixes: #27837.
This PR  fixes the issue “Unsteady height of  compose  bar  buttons while scrolling down
through  the  stream names  having    language  other than English  like  Korean or Chinese”.
Cause of this  Issue:
Compose  bar  of  Zulip is a html  button  which is an  inline-element .It  adjust its  height as per  the  height of  elements within  it. Html button  is assigned with a  text box  by  default to  hold the text of the button .Whenever the text having  more than default  size is inserted in to the button[Korean text etc..] it increases  the height of the inner text box  making the button to  adjust its height.
Quick  solution :
For this issue  setting  fixed height of  button can  be  a  quick  solution but  it  not generic solution and it  affects the  responsive design of the application.
Strategy to find  the solution:
The best strategy to solve this problem would be to make the  inner text box of the button in such a way that  whenever the  text is inserted  no matter whether its   font-size  is more or less than the default size   it  is  converted to 1em.
Solution:
CSS  line-height  property is  used to set the  distance between the lines  of default  text box  of the button.when its  value is set as  1em . This  makes  every  incoming text  to be converted  to given font size(1em).

Before Changes:
https://github.com/zulip/zulip/assets/153224120/4a21ba94-6bfe-4deb-a63d-8aecab5cc53a
After Changes:
https://github.com/zulip/zulip/assets/153224120/2df318a8-c83f-4de0-8177-5037cb7155c2

I request  @timabbott  to  review my  PR and give  feedback.


feat(calendar): add visibleDate prop to RangeCalendar

Allows view to be adjusted when range is set outside
the currently displayed month/year.
Previously when new date range was set outside of the
displayed month the view wouldn't update, and the user
would need to manually change the view to find the
selected range.
This allows for the display to be set programatically and for the
user to navigate with the UI buttons.
This implementation Uses UNSAFE_componentWillReceiveProps
because it was not possible to use getDerivedStateFromProps without
breaking the previous/next month buttons. This method allows
for the display to be set programmatically while still allowing
the user to page forward/back.
First PR. / contribution to an open source project of any kind,
so please forgive any rookie mistakes.
Please read and mark the following check list before creating a pull request:

[x] I read and followed the CONTRIBUTING.md guide.
[x] I read and followed the New Feature Checklist guide.

Short description of what this resolves:
allows the view to be updated when the selected range is set programatically
outside of display on screen.

My fix to the issue I raised here: https://github.com/akveo/react-native-ui-kitten/issues/1222
(First-ever PR 🎉, so feedback appreciated.)

Thank you @trevor-coleman, we appreciate your work. We did some additional work and tests to prove that this is working and closed it in #1579. So I will close this PR in favor of mentioned.

Sweet, thanks!!


Restyle Comments

This Issue is related to #87 and https://github.com/inexor-game/code/wiki/Documentation
Some parts which are already documented probably needs some style fixes.
( See wiki page )

Hi all, this issue caught my eye and I was hoping to provide some assistance. As a side note, I am new to GitHub and have not been involved in an Open Source Project before, I hope that you guys can help me out and guide me to where and how I should begin.
Many thanks.

Hello @bobbybrot and welcome to Inexor! 🙌
Probably the best way is to

compile Inexor (if you need assistance with this, join us on Riot
study the source code in inexor
create a new branch via your git client (we recommend a graphical client, such as SmarGit or SourceTree)
commit and push your restyled changes
create a pull request
we will guide you through the process of creating, updating and making your PR ready

Hey there @bobbybrot! :)
On which platform are you?
Notes: There is currently a PR pending which moves a lot of code around: #455.
In order to simplify merging the changes you do, maybe it's best to start from that branch (remove_standalone2) and not from the master branch. (join in riot if you do not know how)
Additional/or in lieu of what Fohlen said you could start with generating the documentation and fixing the warnings which appear doing that.
To do that run doxygen inside the inexor-core folder (doxygen doxygen.conf is probably the command for that).
Sidenote: That command will generate the documentation in the folder doc/.
You could open doc/index.html afterwards to see the generated docs.

Hey @a-teammate & @Fohlen thanks for getting back to me. I am currently using Windows as my platform. I plan to use Visual Studio 2013 professional to do tasks that require looking into code.

Hi all, as an update I have finalized making the necessary changes to the commenting styles and warnings that were present when using doxygen, I shall be submitting a commit shortly. Unfortunately, there are a few warnings which needs the attention of someone who is more familiar with the code to be corrected. I have made a custom text file which contains all the final warnings that needed further looking into. In the meantime, I hope the commit changes are acceptable.

Documentation leftover.txt

Nice work!! Thanks for your contribution :+1:

@Fohlen I want to confirm with you if you have received my commit changes. I am being told by github the following

When clicking the 'Push origin' button on the very top

@bobbybrot you must fork  and make a pull request (probably the last link is easier).

https://github.com/inexorgame/inexor-core/pull/466
There we go, thanks for the help. I'll be keeping my eye out on my pull request to see if there is anything else that needs doing.
While that is underway, is there anything else that needs to be done to close this issue while the pull request is under way?
Many thanks.
B.Singh

@Fohlen

Even though more fixes have been made based on feedback and is now awaiting further review, there are still some functions that are not documented which will cause doxygen (the program used to create the documentation for us) to produce warning messages when run. I have attached a document to this comment which shows the remaining functions that need documenting (or commenting) by someone who is familiar with the code base.

Documentation.leftover.txt


Create a new repository.

You know how you accidentally leaked Sunday twice? Well, all commits are always visible, and you can see all the files of those commits, meaning anybody can look at the Sunday assets any time they want.
You don't HAVE to create a new repository for this, but it's just a suggestion.
Adding the Sunday files to the .gitignore won't solve the problem though, as the commit files can always be seen.

Forgot to say, creating a new repo gives you a chance to avoid leaking Sunday again and also avoids public leaks (unless you leak Sunday in the new repo too).

lets just hope people arent smart enough to do that for now
(and that people who are smart enough wont be dicks)

This also applies to removing the source code to the Sky mod.


to master

Coverage remained the same at 100.0% when pulling 627c677d8733210a3508f5a68de5c93b11a38dad on next into d50cbd27f270758a762f5b0a188f84b0761569ed on master.


spopt sub-sub modules not included on PyPI?

Currently the PyPI published v0.0.3 and v0.0.2 do not include region, locate, or transport. However, the PyPI publishedv0.0.1 and the GitHub releases do include them. This problem is causing the failure in conda-forge/staged-recipes#13708.
My first thought is that there is an issue with our release_and_publish.yml.
See also #118

Why do we have locate and transport if those do not yet have any functionality?

Why do we have locate and transport if those do not yet have any functionality?

They were part of the directory structure, albeit simply place holders with __init__.py files for the time being. Should we remove for the time being?

They were part of the directory structure, albeit simply place holders with __init__.py files for the time being. Should we remove for the time being?

I think it might confuse users and/or lead to installation mysteries of the kind we are currently trying to debug :->

I think it might confuse users and/or lead to installation mysteries of the kind we are currently trying to debug :->

Huh. I tried that same check yesterday and it worked, though I didn’t look to see which version. My best guess would be something related to manifest. Will keep digging today

Huh. I tried that same check yesterday and it worked, though I didn’t look to see which version. My best guess would be something related to manifest. Will keep digging today

Aspirational goals/plans should get moved into a roadmap document on the site

Aspirational goals/plans should get moved into a roadmap document on the site

I think it might confuse users and/or lead to installation mysteries of the kind we are currently trying to debug :->

OK. I will remove them from the directory and create an issue to add them back later.

I think it might confuse users and/or lead to installation mysteries of the kind we are currently trying to debug :->

OK. I will remove them from the directory and create an issue to add them back later.

Testing a local build, the tarball gets:
 ❯ tar xzvf spopt-0.0.4.tar.gz                                           [09:27:22]
spopt-0.0.4/
spopt-0.0.4/LICENSE.txt
spopt-0.0.4/MANIFEST.in
spopt-0.0.4/PKG-INFO
spopt-0.0.4/README.md
spopt-0.0.4/requirements.txt
spopt-0.0.4/requirements_dev.txt
spopt-0.0.4/requirements_docs.txt
spopt-0.0.4/requirements_tests.txt
spopt-0.0.4/setup.cfg
spopt-0.0.4/setup.py
spopt-0.0.4/spopt/
spopt-0.0.4/spopt/BaseClass.py
spopt-0.0.4/spopt/__init__.py
spopt-0.0.4/spopt.egg-info/
spopt-0.0.4/spopt.egg-info/PKG-INFO
spopt-0.0.4/spopt.egg-info/SOURCES.txt
spopt-0.0.4/spopt.egg-info/dependency_links.txt
spopt-0.0.4/spopt.egg-info/not-zip-safe
spopt-0.0.4/spopt.egg-info/requires.txt
spopt-0.0.4/spopt.egg-info/top_level.txt

so something is not correct in the setup.py?

Testing a local build, the tarball gets:
 ❯ tar xzvf spopt-0.0.4.tar.gz                                           [09:27:22]
spopt-0.0.4/
spopt-0.0.4/LICENSE.txt
spopt-0.0.4/MANIFEST.in
spopt-0.0.4/PKG-INFO
spopt-0.0.4/README.md
spopt-0.0.4/requirements.txt
spopt-0.0.4/requirements_dev.txt
spopt-0.0.4/requirements_docs.txt
spopt-0.0.4/requirements_tests.txt
spopt-0.0.4/setup.cfg
spopt-0.0.4/setup.py
spopt-0.0.4/spopt/
spopt-0.0.4/spopt/BaseClass.py
spopt-0.0.4/spopt/__init__.py
spopt-0.0.4/spopt.egg-info/
spopt-0.0.4/spopt.egg-info/PKG-INFO
spopt-0.0.4/spopt.egg-info/SOURCES.txt
spopt-0.0.4/spopt.egg-info/dependency_links.txt
spopt-0.0.4/spopt.egg-info/not-zip-safe
spopt-0.0.4/spopt.egg-info/requires.txt
spopt-0.0.4/spopt.egg-info/top_level.txt

so something is not correct in the setup.py?

there was no problem when I did the first manual release on PyPI or with the tagged releases here on GH. the problem was only introduced when I started using the release action and #129 may solve the problem.

there was no problem when I did the first manual release on PyPI or with the tagged releases here on GH. the problem was only introduced when I started using the release action and #129 may solve the problem.

Just to be clear, a python setup.py sdist is not grabbing any of the submodules, so I think that is part of the problem (orthogonal to the release actions)

Just to be clear, a python setup.py sdist is not grabbing any of the submodules, so I think that is part of the problem (orthogonal to the release actions)

solved in #131.

solved in #131.


Improve docs to avoid 'act' warning when using react-query in tests

This is sort of related to #270. Filing in case we can improve the docs to help others avoid this issue.
When running tests, I ran into this error:
console.error node_modules/react-dom/cjs/react-dom.development.js:88
    Warning: An update to _default inside a test was not wrapped in act(...).

Here's the test:
test('renders the component', async () => {
  await act(async () => {
    const { getByText } = render(<Component />);
    const linkElement = getByText(/Hello/i);
    expect(linkElement).toBeInTheDocument();
  });
});

And here's the component (simplified):
const getPing = async () => {
  const { data } = await axios.get<{ content: string }>(
    getRoutePrefix() + 'ping'
  );
  return data;
};

export default function () {
  const { status, data, error, isFetching } = useQuery('ping', getPing);

  return (
    <>

Hello!

{JSON.stringify(status)}

{JSON.stringify(data)}

Err: {JSON.stringify(error)}

{JSON.stringify(isFetching)}

    </>
  );
}

In #271 there was some cleanup logic added, however the error in my case appears to have been thrown before the cleanup call was fired.
I can fix the issue by adding to my tests at the end of each act call:
- import { render, wait } from '@testing-library/react';
+ import { render, wait, cleanup } from '@testing-library/react';

test('renders the component', async () => {
  await act(async () => {
    const { getByText } = render(<Component />);
    const linkElement = getByText(/Hello/i);
    expect(linkElement).toBeInTheDocument();
+   cleanup();
  });
});

Doing the cleanup outside the act does not help; that appears to be too late.
Is it necessary to add the cleanup call inside every act call? If so, can we update the react-query docs on how to test with jest + react-testing-library? I bet others will run into this issue as well and hoping to save some time as more users adopt the library.
Here's some screenshots with a debugger attached indicating the warning is originally caused by a call to refetch:

Versions:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

Here's a test that waits on react-query to load the data, forgot to include that when I filed the issue.
test('fetches data on load', async () => {
  await act(async () => {
    const { getByTestId } = render(<Component />);
    const loadingStatus = getByTestId('testdata');

    await wait(() =>
      expect(loadingStatus).toHaveTextContent('{"content":"pong"}')
    );
    cleanup();
  });
});

We don't see this issue in our own tests, so I'm not really sure what's going on with all of this. Are you using react-testing-library?

Yeah. Let me see if I can put up a codesandbox for this...
On Fri, May 1, 2020 at 10:52, Tanner Linsley<EMAIL_ADDRESS>wrote:

We don't see this issue in our own tests, so I'm not really sure what's
going on with all of this. Are you using react-testing-library?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tannerlinsley/react-query/issues/432#issuecomment-622491766,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHGCFXZPMGMMQ4LFXB53DTRPMD4TANCNFSM4MXGNR7Q
.

Alright here's the codesandbox: https://codesandbox.io/s/jovial-sanne-mhgb8?file=/src/app.test.js
You may have to run the tests a few times to get the warning to show up (screenshot)

Interesting. I have no idea why this should be required.

The state is trying to update due to the hook, but the component / test harness has already torn down which throws the warning.
You could also await waitFor -- to wait for query to be done -- IE wait for spinner to disappear

The query has already been completed; the codesandbox demonstrates that case. The problem seems to be isolated to the refetch timer not getting cleaned up before the test exits the ‘act’ scope. The cleanup call is still being made by react testing library, just outside of the act.
Order of events:

test enters act scope
query is made, schedules timer
query completes, state updates
assertion passes
test exits act scope
query refetch timer fires, react prints warning
react testing library calls cleanup, which is too late to cancel the pending refetch timer

Without manually calling cleanup I don’t see a way to prevent the state update from getting scheduled.

I'm seeing this and it looks like isStale changing from false to true sometimes after the test is completed: https://codesandbox.io/s/sad-gauss-uwptc (removed use of act but added logging to show renders after end of test)

I then reloaded the same test until I got the act warning because isStale changes after end of test:

I'm not sure what the right thing to do is, perhaps the test harness ReactQueryConfigProvider should set staleTime to Infinity ?  Perhaps @kentcdodds can chime in .
I'm also not sure if there should be two different configs for ReactQueryConfigProvider in the app context vs. the test context -- I would think it's better to use the same config for both.

I've definitely observed this same behavior in https://github.com/kentcdodds/bookshelf. I haven't had time to debug, but it definitely is annoying.
@dustinsoftware's analysis is consistent with what I assumed is happening. And I agree with @ilovett that we should use the same config for tests and production.
With that in mind, I'm not 100% certain of the best way to approach this. It's really hard to reproduce in a debugging environment.
Right now, the manual cleanup at the end of the test is the best workaround I can think of. Really wish that the afterEach hook was called synchronously after each test 😐

@kentcdodds I've also come across this issue too. It gets tricky to debug exactly which test is causing the the act error to display in the console, especially when a test file has multiple.
I'm going to make a ticket for this in the RTL repo, but I think this highlights a potential need to improve the error message to display exactly which test is causing the issue.
I'm curious whether it's possible to log out the first argument of the it function

Something interesting that seems to have worked for me is doing this:
render(<ComponentThatUsesReactQuery />)
await waitFor(() => {
  if (queryCache.isFetching) {
    throw new Error('The react-query queryCache is still fetching')
  }
})

If I stick that in my app's custom render function as default behavior then I don't have to worry about it anywhere (though it does force me to await all of my render calls, which is fine but a little annoying).

The trick here is that it doesn't allow you to test the loading state, so for those you'll probably want to make your assertions between the regular render call and the waitFor call.
Still trying to figure out the best way to do this, but that's one idea.

Okay, with the latest release, can we confirm that as long as queryCache.clear is called after the test that all is well?

@tannerlinsley With the latest release, I can't reproduce the issue even without calling queryCacheclear.
So for me, the problem appears to be resolved.

I'm definitely still experiencing this without calling queryCache.clear() (with the latest version). Still need to dig in a bit. Planning on doing that soon.

Unfortunately it's intermittent. Sounds like a race condition. If I'm able to figure out exactly what the problem is then I'll raise this issue again.

@kentcdodds You're right, it is intermittent now that I've been using the new version more. It's definitely better than the previous version.
@tannerlinsley @kentcdodds If there's something you want me to try with either library, let me know and I'd be more than happy to help.

I thought that this may be an issue with the afterEach not getting called immediately after the test (hence the race condition). However, that doesn't seem to be the case: https://repl.it/repls/YawningActiveCharacterset
let started = []

let testEnded = false
function start() {
  const interval = setInterval(() => {
    if (testEnded) {
      console.log('interval ran after test ended')
    }
  }, 0)
  started.push(interval)
}

afterEach(async () => {
  for (const interval of started) {
    clearInterval(interval)
  }
  testEnded = false
})

test('start 1', async () => {
  start()
  await new Promise(resolve => setTimeout(resolve, 10))
  testEnded = true
})

test('start 2', async () => {
  start()
  await new Promise(resolve => setTimeout(resolve, 10))
  testEnded = true
})

I assumed that I would see some logs, but in my testing, I do not.
This means something else fishy is going on. Still digging.

Ah! I figured it out. The reason this is happening is because the cleanup process actually includes flushing existing effects/etc. which involves waiting for the next tick of the event loop (via setImmediate). So it's more like this:
let started = []

let testEnded = false
function start() {
  const interval = setInterval(() => {
    if (testEnded) {
      console.log('interval ran after test ended')
    }
  }, 0)
  started.push(interval)
}

afterEach(async () => {
  await new Promise(resolve => setImmediate(resolve))
  for (const interval of started) {
    clearInterval(interval)
  }
  testEnded = false
})

test('start 1', async () => {
  start()
  await new Promise(resolve => setTimeout(resolve, 10))
  testEnded = true
})

test('start 2', async () => {
  start()
  await new Promise(resolve => setTimeout(resolve, 10))
  testEnded = true
})

And that does result in getting the logs.
Looks like there was already a PR to React Testing Library to address this issue: https://github.com/testing-library/react-testing-library/pull/632
I didn't really understand why it was necessary and ultimately @kamranayub created https://github.com/tannerlinsley/react-query/pull/332 to fix the underlying issue.
Come to think of it... It's been a while since I've seen act warnings so this might actually be fixed and I just confused myself (and used up a lot of time on this one 😅).
But, if anyone experiences act warnings from react-query, then the fix may be to merge https://github.com/testing-library/react-testing-library/pull/632 afterall...
Leaving this as-is right now though.

I am still facing this issue, can someone help and tell me what the fix is?

I'm working through this right now. The best solution to this I've found (but is not perfect) is to make sure you do queryCache.clear() after each test.  Part of the problem is that when queries unmount, they dispatch a garbage collection action that attempts to update the query state and rerender the component (which is now unmounted), but that's what triggers the act warning I believe. I'm also working on shipping some updates in v2 (next branch) that will make this easier to manage.

Thank you for the quick reply @tannerlinsley, just so I am clear does it mean I have to use a custom renderer to have access to queryCache.clear inside React Testing Library?

For anyone else looking for how to actually do this, all you have to do is import queryCache and call the clear method on it. No need for custom renderer.
import { queryCache } from "react-query";`

afterEach(() => {
  queryCache.clear();
});

@iamtekeste your trick worked for us with react-query v1, but after upgrading to v2, we had to change it to:
import { queryCache } from "react-query";`

afterEach(() => {
  queryCache.clear({ notify: false });
});

Otherwise, each test was failing with a timeout:
Error: Timeout - Async callback was not invoked within the 5000 ms timeout specified by jest.setTimeout.

@kachkaev thank you for sharing your solution, it will come in handy when I upgrade to v2.

I'm facing an issue which I suppose is related to this. I wanted to leave a comment here to aid those googling for it (I've stumbled upon this thread by sheer luck).
My problem:
After my tests finish running, I get an annoying
A worker process has failed to exit gracefully and has been force exited. This is likely caused by tests leaking due to improper teardown. Try running with --runInBand --detectOpenHandles to find leaks.

message from Jest. Moreover, in our CI/CD environment, the tests don't finish running until the timer for the cache garbage collection is executed (which delays our deploys by 5 min.. not terrible, but definitely annoying).
Solution
To avoid having to write queryCache.clear()  for each of my test files, I added
afterAll(() => {
  require('react-query').queryCache.clear();
});

to my jest.setup.js files and voilà, problem gone.
Thanks a lot to all of you who suggested using queryCache.clear() after the tests. 😃 😄

I keep getting the warning unless I use both queryCache.clear and the waitFor hack from https://github.com/tannerlinsley/react-query/issues/432#issuecomment-629546372.
I wrote a small utility function that wraps a render function with both:
export function getRenderWithQueryCache<TRenderArgs, TResult = RenderResult>(renderFunction: (args?: TRenderArgs) => TResult): TResult {
    afterEach(() => {
        queryCache.clear({ notify: false });
    });

    return async function renderWithQueryCache(...args) {
        const renderResult: TResult = renderFunction(...args);

        await waitFor(() => {
            if (queryCache.isFetching) {
                throw new Error('The react-query queryCache is still fetching');
            }
        });

        return renderResult;
    }
}

This is what we're doing currently. You may want to include queryCaches since there could be multiple caches available depending on how you're using react-query.
import { queryCaches } from 'react-query';

afterEach(async () => {

  // Clear all query caches (including the default)
  queryCaches.forEach(cache => cache.clear({ notify: false }));

  // Hack to wait for timers to avoid act warnings
  await waitFor(() => {});
});

We use the render function normally but the catch is you must use findBy* async methods to avoid the act warning immediately after rendering.

This did the trick for me when testing react hooks: (thanks @kentcdodds  https://github.com/tannerlinsley/react-query/issues/432#issuecomment-629546372)
async function afterHack() {
  const { waitFor } = renderHook(() => null);
  await waitFor(() => {
    if (queryCache.isFetching) {
      throw new Error('The react-query queryCache is still fetching');
    }
  });
}

beforeEach(() => {
    queryCache.clear({ notify: false });
  });
  afterEach(() => {
    afterHack();
  });

Hi @liorfrenkel , we are experiencing tones of warning, I am looking at your trick and I can't tell what is renderHook import. Can you tell?

Hi @liorfrenkel , we are experiencing tones of warning, I am looking at your trick and I can't tell what is renderHook import. Can you tell?

@kopax
import { renderHook } from '@testing-library/react-hooks';

Thanks for sharing. I still experience a tons of act warning even with that fix, is this working for you in<EMAIL_ADDRESS>This is the test that break: https://gist.github.com/kopax/69ea35181d55593f8b3a51938e359ef4#file-forgottenpassword-test-tsx-L30
This is my logs:
  console.error
    Warning: An update to ForgottenPassword inside a test was not wrapped in act(...).

    When testing, code that causes React state updates should be wrapped into act(...):

    act(() => {
      /* fire events that update state */
    });
    /* assert on the output */

    This ensures that you're testing the behavior the user would see in the browser. Learn more at https://fb.me/react-wrap-tests-with-act
        in ForgottenPassword
        in QueryClientProvider

      at printWarning (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:120:30)
      at error (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:92:5)
      at warnIfNotCurrentlyActingUpdatesInDEV (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:13729:7)
      at dispatchAction (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:6405:9)
      at node_modules/react-query/lib/react/useBaseQuery.js:48:9
      at node_modules/react-query/lib/core/queryObserver.js:436:13
      at notifyFn (node_modules/react-query/lib/core/notifyManager.js:13:3)

  console.error
    Warning: An update to ForgottenPassword inside a test was not wrapped in act(...).

    When testing, code that causes React state updates should be wrapped into act(...):

    act(() => {
      /* fire events that update state */
    });
    /* assert on the output */

    This ensures that you're testing the behavior the user would see in the browser. Learn more at https://fb.me/react-wrap-tests-with-act
        in ForgottenPassword
        in QueryClientProvider

      at printWarning (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:120:30)
      at error (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:92:5)
      at warnIfNotCurrentlyActingUpdatesInDEV (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:13729:7)
      at dispatchAction (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:6405:9)
      at node_modules/react-query/lib/react/useBaseQuery.js:48:9
      at node_modules/react-query/lib/core/queryObserver.js:436:13
      at notifyFn (node_modules/react-query/lib/core/notifyManager.js:13:3)

We are experiencing tons of those error and we would gladly want to know how to remove or at least disable them, Can anyone tell a fix that work in the latest react-query version?

@kopax it seems that your test is finished with that line 30,
if this is the case, the test ends when you press on a button, and I assume the button click is hooked to some ajax request?
you will need to wait for the action that is hooked to the button click in your test and then expect something to happen
also, you do not test a hook but a component, the hack that you are using is for testing hooks, try this one for he normal render of testing library:
async function afterHack() {
  await waitFor(() => {
    if (queryCache.isFetching) {
      throw new Error('The react-query queryCache is still fetching');
    }
  });
}

Yes the action is react-query, it fail when the code execute refetch from useQuery.
We already added in setupTests.js this logic:https://github.com/pass-culture/pass-culture-app-native/blob/master/src/tests/setupTests.js#L18, this was added in last December. I believe we already clear our cache with this.
We use the isFetching props on the button that we press which perform the request:
        <ButtonPrimary
          title={_(t`Valider`)}
          onPress={validateEmail}
          disabled={shouldDisableValidateButton || isFetching}
        />

I thought I could wait until this switch to true or false but the props are dispatched differently in the final components and getByTestId did not help wait for that props change, do you see another way to wait for event considering the cache is already cleared?

@kopax I believe the problem is in the test and not in react-query, basically the act warning that you get is right, something is happening after the test is finished and there is no check for it in the test, check this out act warning
try doing something like this:
it.only('should redirect to ResetPasswordEmailSent when password reset request is successful', async () => {
    const { getByPlaceholderText, findByText } = renderPage()
    const emailInput =<EMAIL_ADDRESS>    fireEvent.changeText(emailInput<EMAIL_ADDRESS>    const validateEmailButton = await findByText('Valider')
    fireEvent.press(validateEmailButton) // <==== line that break

  // pseudo code from here, we need to test the component state which is changing after the async call
   expect(the button).toBeDisabled()

  // and then a check that the button is not disabled after the query had finished
  await waitFor(() => expect(the button).not.toBeDisabled());
  })

Thanks for trying to help, I already tried to get the button state change and couldn't find a method to test the passed props (such as disabled) on the button. I also need to state that our button component will finally use the props disabled to configure internally and will not render a disabled state in the dom which cause me issue to identify the state change with the testing tool I known. Do you have another clue how I can test this component and fix this test ?
If you clone the code base and run yarn test, you'll see that we have tons of error like this we can't solve at the moment and they were all included by the usage of react-query in our components.
https://github.com/pass-culture/pass-culture-app-native/blob/PC-6434-2/src/features/auth/forgottenPassword/ForgottenPassword.tsx

@kopax i was able to do a useMutation hook test like this:
it('mutation', async done => {
    await waitFor(async () => {
      const nockScope = nock(api.defaults.baseURL as string)
        .post(
          `/api/order/${
            store.getState().dashboard.orderModal?.orderId
          }/complete`,
        )
        .reply(200, {
          ...store.getState().dashboard.orderModal,
          orderStatus: 1,
        } as OrderType);

      const completeOrderBtn = screen.getByTestId(
        `completeOrderBtn/${store.getState().dashboard.orderModal?.orderId}`,
      );
      fireEvent.press(completeOrderBtn);
      const completeLoader = screen.getByTestId('complete-loader');
      expect(completeLoader).toBeTruthy();
      await waitForElementToBeRemoved(() =>
        screen.getByTestId('complete-loader'),
      );
      nockScope.done();
      done();
    });
  });


Update descriptions of tags

With beneficiary tags being added, review the app and marketing website looking for tag descriptions which need to be updated.

 Beneficiary Tags

Updated marketing site in af2bb059199194cf36afc768f775396b836e3862


Release notes for 0.4.0.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (367e75d) 96.69% compared to head (57628eb) 96.69%.

:exclamation: Current head 57628eb differs from pull request most recent head 0f09662. Consider uploading reports for the commit 0f09662 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #12   +/-   ##
=======================================
  Coverage   96.69%   96.69%
=======================================
  Files           7        7
  Lines         303      303
=======================================
  Hits          293      293
  Misses         10       10

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Default ammo stamps

Setting up all the item stamps is a headache for everyone involved, there should be a command to add preset ammo stamps to streamline this process.

There also needs to be a way to use all ammo stores at once.

Resolved via commit a82933d21bb507b932af5f1d6891b5f6feb649f9.

Reopened, didn't see second part of issue.

Resolved via a55e106a3921e528cc318ee378cff70aa6725e3b.


Quote font names

Partial for #743
This PR adds quotes around font-family since apparently there are quite a few fonts that do not seem to work consistently without quotes.

https://mathiasbynens.be/notes/unquoted-font-family 🤯

@barklund Please re-review when you have time.


services/garage: init

Description of changes
This provides a module for https://garagehq.deuxfleurs.fr/, a S3-compatible object storage, simpler than MinIO.
I had the need for it when wanting to deploy Outline which requires a S3 Object Storage and MinIO was advised, wanted to offer a simpler solution.
It has a quite comprehensive test suite, which tests: bucket writes & bucket serving over HTTP in two setups: single-node and 3-nodes configuration.
I should try to kill a node maybe in the tests, but I think that's mostly upstream responsibility.
Maybe, it would be important to figure out an upgrade path strategy ? see #196195 for upgrade path.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[x] (Module addition) Added a release notes entry if adding a new NixOS module
[x] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1287

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/642


Comet Virtual Method Error

Hi all,
Has anyone run into problems running athena++ on SDSC's Comet?  When compiled with their intel compiler ( intel 2018.1.163) the code crashes after initialization with the following error:
pure virtual method called
terminate called without an active exception
It seems that this happens for any input file and configuration with the unedited public version.  When compiled with gcc the code runs fine.  Strangely, when using the same intel 2018.1.163 compiler on a different cluster the code also runs fine, so this seems to be a Comet-specific problem.  Also, the previous version of the code works well on Comet.

Known problem with certain Intel compilers from 2017 (and I guess early 2018) that affect versions of Athena++ after I rewrote the boundary values classes and added passive scalars. @tomidakn and I were the only ones to encounter it, I believe.

Is there a work around?
On Tue, Jul 7, 2020 at 6:16 PM Kyle Gerard Felker<EMAIL_ADDRESS>wrote:

Known problem with certain Intel compilers from 2017 (and I guess early
2018) that affect versions of Athena++ after I rewrote the boundary values
classes and added passive scalars. @tomidakn https://github.com/tomidakn
and I were the only ones to encounter it, I believe.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/PrincetonUniversity/athena-public-version/issues/55#issuecomment-655164742,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB6S4RT3LUFXHIVLSK3C22LR2ONB5ANCNFSM4OTWLHLQ
.

No. Newer Intel compiler.

Right, I hit this last year (#29) with Intel v18 and there was no issue with Intel v19.

Got it, thanks.  I'll probably just transfer the comet time since they only
have the one version.
On Tue, Jul 7, 2020 at 7:15 PM Tim Waters<EMAIL_ADDRESS>wrote:

Right, I hit this last year (#29
https://github.com/PrincetonUniversity/athena-public-version/issues/29)
with Intel v18 and there was no issue with Intel v19.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/PrincetonUniversity/athena-public-version/issues/55#issuecomment-655186998,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB6S4RWFNFYB5MLMM3U6VZTR2OUCPANCNFSM4OTWLHLQ
.


Add GitHub Actions Tagged Release

Only if you want to use this.
This will, upon a new push of a tag matching a semver format (v[0-9]+.[0-9]+.[0-9]+) then it will do its tests, lint, build, and generate a new GitHub release, adding in the ipaddr.min.js file as an attachment.  This only affect the GitHub Releases, which to this date shows 1.0.3 from 2015.
I've performed the test on my own repo, feel free to visit the forked repo and head into releases to see it.
As a side note, Not that there was anything wrong with putting that file at the root directory, but normally generated/minified files are not stored, and should be generated manually if they are cloning the repo as one may have forgotten to generate the minified build file with the added changes.  That way people will know that the released min.js file under releases will work.  We're humans, and sometimes what is committed to the master may not be working at all times.
Signed-off-by: Kenneth Tran<EMAIL_ADDRESS>

If you don't want this you can close it.  However I'd suggest at least updating the GitHub Releases as well to the latest.  It is currently sitting at 1.0.3 from 2015.

It is currently sitting at 1.0.3 from 2015.

I have no idea why there was a GH release for 1.0.3; I just deleted that.

I haven't used Node.js for many years so I'd rather not change anything radically.

I haven't used Node.js for many years so I'd rather not change anything radically.

It won't change anything at all - this just allows additional package publishing through github releases.

Also with your package having over 10 million downloads (at least on npm), you should consider updating the versions or letting somebody else assist you in that aspect as some of the bugs have been fixed through this repo.

Published 2.0.0.


Enable dependabot?

Anything else like this we should do? Does it do anything above rust advisory-db thing @dpc just added?

AFAIK dependabot is using the same source (RustSec) for alerts, and other than this just bumps versions.
Enabled, we'll see how it goes.


Setup Testing, CI and some automation

From @swashata on January 30, 2018 18:15
So I have been long absent on this and finally have enough time and experience to come back at it. But before we proceed with the issues and MRs, I think it would be better if we put up some sort of testing along with continuous integration and some grunt/gulp tasks to create dist files and set things up in package managers like yarn/npm etc.
I have very limited experience with javascript unit testing, but I am good with browser automation tests (acceptance tests) with http://codecept.io/
So @micc83 please suggest.
Copied from original issue: micc83/fontIconPicker#40

Hello @swashata , nice to hear from you. I'm glad you're back. I completely agree on doing some testing before doing any further development on the plugin. However, I'm still pretty busy and I wouldn't be able to follow the project as actively as I should. I think that having acceptance testing would be, for start, a great improvement on the dev workflow. If you feel like going deeper into Unit testing I guess you should probably go with QUnit or Karma.

From @swashata on January 31, 2018 16:44
Alright. Both QUnit and Karma seems to be good at what they do. But I think we need to change/refactor most of the codes for unit tests. Any existing project that you know of which can help me with this?

Hello @swashata check this one: https://github.com/jaysalvat/jquery.facedetection/tree/master/tests

From @swashata on January 31, 2018 17:22
Thanks @micc83. The tests looks more like integration tests but is huge help. I will get started with this. For CI/CD are you okay with travis? I personally use gitlab CI/CD but that won't be an option here.

I use gitlab CI too, but as we're hosted on github I guess we should go
with travis. It would also be cool adding styleci.
2018-01-31 18:22 GMT+01:00 Swashata Ghosh<EMAIL_ADDRESS>
Thanks @micc83 https://github.com/micc83. The tests looks more like
integration tests but is huge help. I will get started with this. For CI/CD
are you okay with travis? I personally use gitlab CI/CD but that won't be
an option here.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/micc83/fontIconPicker/issues/40#issuecomment-362005695,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABq1hGAI48Dc2gn9t3ikYRKx26EwLKLBks5tQKFHgaJpZM4Ryx4a
.

--
Alessandro Benoit
Cel: +39<PHONE_NUMBER>
Email<EMAIL_ADDRESS>

From @swashata on March 10, 2018 5:56
Just to let you know that I am not dead. I am just learning ES6 and stuff from WesBos. Once done I will first try my knowledge with this 👍


Nextflow: Grab workflow descriptions

Feature Request
It would be great if Dockstore could auto-populate a few extra fields from Nextflow workflows which are sometimes available in the config metadata.
Desired behaviour
Description: manifest.description (example)
Author (in table view): manifest.author (example)
Note that Workflow Path: /nextflow.config is a little confusing, as the workflow is in the main.nf file (default filename - can be defined with workflow.mainScript), and it's this that you execute, rather than the config file. I know I can change it manually, but if it's pulled by default somewhere.
Apologies if these already happen, it could be that I'm simply being too impatient after clicking refresh on my GitHub repos :)
Phil
┆Issue is synchronized with this Jira Story
┆Issue Number: DOCK-209

@ewels
Thanks for trying things out. I think the first two should happen, although there are config files that don't parse properly on our end but https://dockstore.org/workflows/github.com/nf-core/vipr:master?tab=info has an example where it does. We'll look into rnaseq
The workflow path is a little confusing, we can probably change the name to something more appropriate. But the workflow path is where we start looking for a workflow (maybe more relevant for languages that can often have more than one workflow in a repo).

We ended up calling out to Nextflow separately too
(it wasn't clear due to our lack of groovy expertise how to separate just what we needed and we didn't want to include all of Nextflow in our classpath)
May need to optimize later, but this should get us compatibility with descriptions, etc. from nf-core
Limitation: We can't use Nextflow to aid us in detecting what files are useful from a repo (i.e. in CWL, we start with the "entry"/primary descriptor and spider out to figure out what files in the repo are relevant)

Works on
DockstoreAPI - 1.6.0-rc.0
DockstoreUI - 2.3.0-rc.1


Support for these complex snippets should be a capability

Also, support for these complex snippets should be a capability. It seems that as soon as you declare support for snippets, you're binding yourself to implementing a potentially changing snippet specification.
Or at least, version the specification of snippets maybe ?
For example, in Vim there's no way to support JavaScript regexes without writing a JavaScript to Vim regex compiler
See https://github.com/microsoft/language-server-protocol/issues/363

It is also important, that many JS-compatible regex engines uses "plain NFA" wich can result with "regex of doom", example:
> console.time("regex"); /(a*)*b/.test((Array(20).fill("a").join(''))); console.timeEnd("regex");
regex: 34.394ms
undefined
> console.time("regex"); /(a*)*b/.test((Array(21).fill("a").join(''))); console.timeEnd("regex");
regex: 63.107ms
undefined
> console.time("regex"); /(a*)*b/.test((Array(22).fill("a").join(''))); console.timeEnd("regex");
regex: 114.081ms
undefined
> console.time("regex"); /(a*)*b/.test((Array(25).fill("a").join(''))); console.timeEnd("regex");
regex: 814.702ms
undefined

As you can see, with pretty innocent regex and pretty innocent string we can show exponential times of executing the regex. This can result with DoS from the untrusted LS.


[tidb-cdc]fix too many fields cause the value to be NULL

fix issues：https://github.com/ververica/flink-cdc-connectors/issues/1883

@mxd-321 Thanks for your contribution. Please format code by maven spotless:apply. Can you add unit test to check this fix is worked?

@GOODBOY008 Hi，I executed "mvn spotless:apply" and "mvn spotless:check"

@GOODBOY008 Hi，I executed "mvn spotless:apply" and "mvn spotless:check"

https://dev.azure.com/ververica/flink-cdc-connectors/_build/results?buildId=2691&view=logs&j=668ee87f-c790-5715-ed85-7ccae79a5a1f&t=24e740b6-f920-55b3-3442-aec852868a00&l=1117
@mxd-321 ,Maven checkstyle failed, you can run local util passed.

@GOODBOY008  Hi, there are still a few "ci" that have not passed. Can you help me take a look? And review the code. Thank you !

@GOODBOY008 Hi, there are still a few "ci" that have not passed. Can you help me take a look? And review the code. Thank you !

Unit test failed. https://dev.azure.com/ververica/flink-cdc-connectors/_build/results?buildId=2695&view=logs&j=7f9f9f19-4e92-50a8-2f68-2b1038ea61d1&t=a202a4b7-0f62-5127-83cb-4dfa74d97257&l=752


I think I have a formatting error in my config file but I can't seem to locate it.

Admittedly I'm new to this, but I had it working up up until I added the mi-light plug in. I added my platform in stages to make sure everything worked. I figure I'm missing a comma or something. Any help is appreciated!!

{
"bridge":{
"name":"Homebridge",
"username":"CD:22:3D:E3:CE:32",
"port":51826,
"pin":"031-45-156"
},
"description":"Homebridge",
"accessories":[
],
"platforms":[
{
"platform": "TplinkSmarthome",
"name": "TplinkSmarthome"
},
{
"platform": "Hue",
"users": {
"001788FFFExxxxxx": "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx",
"001788FFFEyyyyyy": "yyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyy"
},
"sensors": true,
"excludeSensorTypes": ["CLIPPresence", "Geofence"],
"lights": true,
"nativeHomeKit": false
},
{
        "platform":"MiLight",
        "name":"MiLight",
        "bridges": [
          {
            "ip_address": "<IP_ADDRESS>",
            "version": "v6",
            "lights": {"fullColor": ["Kitchen",null,"Bedroom","Hallway"],
                       "rgbw": ["Living Room", "Downstairs Bedroom"]},
            "repeat": 1,
            "delay": 100
          },
          {
            "ip_address": "<IP_ADDRESS>",
            "lights": {"white": ["Dining Room", "Den"],
                       "rgbw": ["Master Bedroom"]}
          }
]}

Looks like you’re missing a closing ]}.  Try https://jsonlint.com.

Thanks!


Ability to delete account infromation

User can delete their username and password since it's a file breaking the secret notes app.

Not a problem anymore.


Issues using Sample Site Template

Hello! This is my first time attempting to use docu-notion, and docusaurus in general, so please forgive me if I may be missing anything obvious.
What I've done
I created a repository using the docu-notion-sample-site template, skipping steps 4 and 5 for testing locally as I just wanted to see if I could get this up and running first.
I've duplicated the Notion sample site without making any personal customizations to it.
I've set my repository settings to configure the GitHub Pages Build and deployment Source to GitHub Actions.
I've tested setting the url field (line 11) in docusaurus.config.js to both my github username and the original one, as it wasn't specified in the README of the sample site template, but seemed off.
Issues

The farthest I've gotten in the process is to the Deploy to gh-pages step in the action.
This step returns Permission to repository/docu-notion-test.git denied to github-actions[bot].
Log: https://github.com/JustSleightly/docu-notion-test/actions/runs/6322938490/job/17169500962

This is only after setting the github repo visibility to public, as before that I got just as far but Write access to repository not granted instead. Is my docu-notion repository required to be public?
Log: https://github.com/JustSleightly/docu-notion-test/actions/runs/6322758127/job/17168975276

This seems to use the GITHUB_TOKEN instead of my Fine-grained personal access token, so it doesn't seem to be an issue with my token scope.

Prior to that, I was running into an error during the Pull from Notion step in the action.
This step returned Error: Notion page not found "6c46c1230f914d3080dca0bc2847af57"
This issue seems similar to https://github.com/sillsdev/docu-notion/issues/57 which was previously closed by OP, but in my case I haven't changed the sample site.
I got past this error only by publishing my notion page publicly to the web. Is my docu-notion site required to be public?
I don't see the same "Share" option to Invite my Notion Integration like your screenshot, and was only able to add the connection using these steps in Notion's documentation
Log: https://github.com/JustSleightly/docu-notion-test/actions/runs/6322476314/job/17168173721

Lastly, every other build run seems to sporadically encounter UnknownHTTPResponseError: Request to Notion API failed with status: 502 during the Pull from Notion step.
From google results, this one seems like it may just be a Notion API issue that began reoccurring recently.
Log: https://github.com/JustSleightly/docu-notion-test/actions/runs/6322846245/job/17169220332

I've updated the ReadMe to reflect the change in Notion UI for connecting integrations.

@hatton Thanks for your quick update!
I attempted a local pull using npx with v0.15.0 (as well as v0.13.2) and it seemed to pull from Notion fine.
I did notice, however, that multi-column layouts did not seem to be working like your sample site

Attempting to update the sample site repository/action (by replacing the version number in the package.json to v0.15.0) did not seem to work, despite confirming all my repository secrets are correct.
Log: https://github.com/JustSleightly/docu-notion-test/actions/runs/6332176519/job/17198155645

Perhaps the issues I've been having (other than the multi-column layout) are only specific to the sample site template?


Alternate Software to download twitch Sub Vods

Franiac Mention This:
I know there are some tools out there that still work in certain conditions and there are some workarounds that also make it possible to download sub-only content for a short period of time with older versions of Twitch Leecher.
Does anyone know what other software I can use to download sub only twitch videos?

Please understand that when I say the methods such tools use are "dirty and hacky" I refrain from recommending them. I am not saying they are bad, but I don't agree with what they are doing regarding sub-only videos.

can you please let me know where I can find it? I just want to test it to see how it works

hello?

@Franiac can you please tell me the name of softtware?

@Franiac waiting for ur response


Feature/shorten xunit names

This PR may close #116
Ive added some lua pattern methods to trim the names of methods in the list such that it is not as bloated.
The image below shows the result and it works as expected with nested classes as well.

Thanks for merging. Hope you had a merry Christmas. And wish you a happy new year


IGAPP-1173: Add poi filter modal native

This pull request belongs to an issue on our bugtracker.
You can find it there by looking for an issue with the key which is mentioned in the title of this pull request.
It starts with the keyword IGAPP.

TODOs:

[ ] Wait for https://github.com/digitalfabrik/integreat-cms/pull/2342 and remove TODOs
[ ] * Handle selected poi and filters
[ ] * Add tests

The icon_url field of the location categories is now delivered by the API.

Looks good so far, just a few styling things. Also, I can't select the category "Other".

Can't reproduce not being able to select "Other", do you have more infos on how to reproduce?

Can't reproduce it anymore either, so yay? I am newly getting a Network request failed when opening the filter modal but I can simply click it away.
https://github.com/digitalfabrik/integreat-app/assets/18513943/48feb502-e6eb-4358-9f0b-aea015205882

Can't reproduce it anymore either, so yay? I am newly getting a Network request failed when opening the filter modal but I can simply click it away.

Should be fixed with https://github.com/digitalfabrik/integreat-cms/issues/2340 and the removal of a fallback poi category on our side.


operator minio-operator-rhmp (5.0.14)

operator minio-operator-rhmp (5.0.14)
Signed-off-by: pjuarezd<EMAIL_ADDRESS>

closes https://github.com/minio/operator/issues/2050

/pipeline restart operator-hosted-pipeline


Do not use deprecated Fixnum class

In order to bring this project up to speed with Ruby 2.4 and Rails 5.x, I have replaced Fixnum with Integer and Fixnum || Float with Numeric.

Closing in favour of https://github.com/phatworx/devise_security_extension/pull/216


Update DWP availability error

Refactored the dwp_process service

it now has a result method that returns a json object with three attributes

success
dwp_check
message

The success should be true or false

The message is any error that can be trapped on return from
the downstream APIs

The dwp_check is the serialised object

[finishes #94226788]

Looks fine

Looks good


Add jenkins config files for running tests

This configures django-jenkins so that jenkins can run unit tests and generate reports.

@ibrechin do you mind?


Refs #32819 -- Added aria-describedby for help_text.

Ticket 32819
This adds aria-describedby functionality for help_text. We'll still need to think about errors but that seems a much more complex based on prior work. Would it be ok to approach this ticket in stages?

While working on another patch for the admin I checked this patch as well.

This patch will introduce issues with the admin as the input will get an aria-labelledby but the help text doesn't have the id.
@felixxm  -- shall I work on this as part of this PR (as a separate commit) or would you want to take it as a separate change?

This patch will introduce issues with the admin as the input will get an aria-labelledby but the help text doesn't have the id.

Can we fix this in advance? :thinking:

we fix this in advance? 🤔

Ah yes, I didn't think of that. 👍

Let's take https://github.com/django/django/pull/15241 first.

Updated in #16185.


CPPLINT.cfg root=setting is now relative to CFG file.

Also further improve the documentation and testing around --root.
Previously the root=setting in the CFG file was treated identically
to passing --root=setting on the command line, which seems undesirable
since it depends on were CPPLINT.cfg was invoked from (for relative
paths).
Judging on settings such as 'exclude_files' it seems within the spirit
to make the settings 'current working directory' contextual to the
same directory that CPPLINT.cfg is in.
This also makes execution consistent (picking up the "correct" settings)
regardless of the CWD when executing cpplint.py.
Example:
  echo 'root=..' >> /a/b/c/CPPLINT.cfg
  cd /
  cpplint.py /a/b/c/source_file.h
  # expects header guard of C_SOURCE_FILE_H_

However the old behavior would use '/../' = '/'
and incorrectly think the root was  'A_B_C_SOURCE_FILE_H_'.

Noticed root seems to be ignoring the directory of the CPPLINT.cfg so I uploaded this improvement:
@markmentovai
............................................................................................................................................................................
----------------------------------------------------------------------
Ran 172 tests in 0.683s

OK

Fixed line length. Also fixed tests (forgot to 'git add' a file).
@markmentovai


Review stryker api

We should use underscores in all module names
See if we need better option names. Discussion points:

testFiles+libs ==> otherFiles/files/additionalFiles

I think this one is fixed with our current setup of files and mutate.


Silex nginx template doesn't take PHP version into account

When using PHP 7.0 and the silex template, it will use the wrong PHP FPM version path.
fastcgi_pass   unix:/var/run/php5-fpm.sock;

should be in this case:
fastcgi_pass   unix:/run/php/php7.0-fpm.sock;

Not sure how you do that usually in other cases. Maybe the php-fpm role should define a variable on which path it is and the nginx template reads that?

The same way as the symfony template does:
    fastcgi_pass unix:{{ fpm_socket }};


feat: ability to specify if selfClosing element is a void element

Summary
That PR is about adding ability for users to not add a / at the end of specific void elements  (like <br>, <link> or <input> elements)
This change originally come from https://github.com/apostrophecms/sanitize-html/issues/51
What are the specific steps to test this change?
type SelfClosingOptions = Record<string, boolean | { voidTag: boolean }>

type MyIOptions = Omit<sanitizeHtml.IOptions, 'selfClosing'> & {
  selfClosing?: SelfClosingOptions | string[] | undefined
}

const sanitizationOptions: MyIOptions = {
  allowedTags: ['p', 'strong', 'em', 'u', 's', 'blockquote', 'ul', 'ol', 'li', 'br'],
  allowedAttributes: {},
  selfClosing: {
    br: {
      voidTag: true
    }
  },
}

const cleaned = sanitizeHtml(
  value,
  sanitizationOptions as sanitizeHtml.IOptions
)

What kind of change does this PR introduce?
(Check at least one)

[ ] Bug fix
[x] New feature
[ ] Refactor
[ ] Documentation
[ ] Build-related changes
[ ] Other

Make sure the PR fulfills these requirements:

[ ] It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
[ ] The changelog is updated
[ ] Related documentation has been updated
[x] Related tests have been updated

If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information:

I didn't change the documentation because I don't know where to write about voidElement because the section explaining selfClosing does not exist yet.


Feature/endpoints

Before making the Pull Request:
Implemented Controllers for survey, questions, and context. These are endpoints that are now accessible ( they are unrestricted ) and authorization annotations will sit on top of these later.

[ ] Is there a description to this pull request that points to a specific user story, feature, or bugfix?
[ ] Are there comments where the code may be unclear?
[x] Is all dead code, commented out code, etc. removed?
[ ] Are there tests written for these changes?
[x] Does the ReadMe need to be updated?

Before being merged by the TPL:

[ ] Has the pull request been reviewed by at least two team members?
[ ] Did they leave any comments or suggestions?
[ ] Were those suggestions acted on?
[ ] Are all tests passing?
[ ] Has the documentation been updated?

These controllers where merged into the deploy branch earlier this week.


imp: add report template according to guidlines

closes #113
Checklists taken from: https://hydra.nixos.org/build/123682220/download/1/nixpkgs/manual.html#chap-reviewing-contributions

Arguably, some review items are automated away by nixpkgs-review.
However, I'd suggest starting to put at least some list here and evolve from there.

Superseded by #115


change the allowed images/allowed items to come from a seperate JS bundle

currently, there are only 2 bundles:
BUNDLE A: for the npm modules like react, react-router, etc. and
BUNDLE B: for all of my components/logic.
There should also be another bundle which is just a list of items/images that the user is allowed to use/see. Because the idea is that this list of items/images should grow as more people submit item and image requests. As of right now, what would need to happen is I would have to rebundle the entire BUNDLE B even though I only added a few items, and that would cause all users to have to redownload a 200kb file every time theres new images or items...

Serve images over external CDN. Faster and no need for rebundling / redeploying.
Also make image request easier. It's a key part of the stories. Probably don't manually validate the image, but let users validate it. Else a path submission would be stuck until you validate the users image request.

So the images are served over a CDN, along with the js files, html, css, etc. The js bundles have the names of the images that the user is allowed to see. So image1.jpg, image2.jpg, etc. And when the component gets rendered, it simply sets image1.jpg as the image src, and the users browser loads the image over cloudfront. The bundle just tells the user which images they are allowed to use when creating a path object.
Also requesting additional images isn't integrated with the site because there's no way I'd be able to monitor every users image submission, and I want to avoid offensive content on the site. However, the path submissions don't get manually validated, they simply start a timer, and once the timer ends the one with the most votes wins. The image validation that I was referring to is via patreon. if a user wants to submit their own images to the site they become a patron, and then make a post on patreon with an image that they want added. and i verify that image before adding it to the site. Maybe in the future this will change, but for now I wanted to do it this way to prevent offensive images from being uploaded.


Contains doesn't appear to be working

I have the following filters:
            modelBuilder.Filter("ChmPeople_ChurchId",
                (IChurchDataPrivileged entity, int churchId) => entity.ChurchId == churchId,
                () => CurrentUser?.ChurchId ?? 0);

            modelBuilder.EnableFilter("ChmPeople_ChurchId", () => ShouldEnforcePermissions);

            builder.Filter("ChmPeople_NoteInstance",
                 (Note note, List<int> allowedNoteTypes) => allowedNoteTypes.Contains(note.NoteTypeId),
                 () => GetAllowedNoteTypes());

            builder.EnableFilter("ChmPeople_NoteInstance", () => ShouldEnforcePermissions);

            builder.Filter("ChmPeople_Note",
                (Note note, List<int> allowedNoteTypes) => allowedNoteTypes.Contains(note.NoteTypeId),
                () => GetAllowedNoteTypes());

            builder.EnableFilter("ChmPeople_Note", () => ShouldEnforcePermissions);

I am executing the following query:
var query = db.Individuals.Include(i => i.NoteInstances.Select(ni => ni.Note))
                    .Where(i => i.IndividualId == 635086);

The resulting SQL is as follows:
SELECT
    [Project1].[INDIVIDUAL_ID] AS [INDIVIDUAL_ID],
    [Project1].[CHURCH_ID] AS [CHURCH_ID],
    [Project1].[STATUS_ID] AS [STATUS_ID],
    [Project1].[STATUS_SELECTLIST_ID] AS [STATUS_SELECTLIST_ID],
    [Project1].[STATUS_DATE] AS [STATUS_DATE],
    [Project1].[STATUS_COMMENT] AS [STATUS_COMMENT],
    [Project1].[PREFIX] AS [PREFIX],
    [Project1].[LAST_NAME] AS [LAST_NAME],
    [Project1].[FIRST_NAME] AS [FIRST_NAME],
    [Project1].[MIDDLE_NAME] AS [MIDDLE_NAME],
    [Project1].[FORMER_NAME] AS [FORMER_NAME],
    [Project1].[SUFFIX] AS [SUFFIX],
    [Project1].[GENDER] AS [GENDER],
    [Project1].[DATE_OF_BIRTH] AS [DATE_OF_BIRTH],
    [Project1].[MARITAL_STATUS] AS [MARITAL_STATUS],
    [Project1].[FIRST_RECORD] AS [FIRST_RECORD],
    [Project1].[OCCUPATION_ID] AS [OCCUPATION_ID],
    [Project1].[OCCUPATION_DESCRIPTION] AS [OCCUPATION_DESCRIPTION],
    [Project1].[EMPLOYER] AS [EMPLOYER],
    [Project1].[SCHOOL_ID] AS [SCHOOL_ID],
    [Project1].[DENOMINATION_ID] AS [DENOMINATION_ID],
    [Project1].[FORMER_CHURCH] AS [FORMER_CHURCH],
    [Project1].[GOES_BY] AS [GOES_BY],
    [Project1].[DEFAULT_TAG_COMMENT] AS [DEFAULT_TAG_COMMENT],
    [Project1].[OTHER_USER_ID] AS [OTHER_USER_ID],
    [Project1].[LAST_UPDATE] AS [LAST_UPDATE],
    [Project1].[INDIVIDUAL_CODE] AS [INDIVIDUAL_CODE],
    [Project1].[UNIQUE_ID] AS [UNIQUE_ID],
    [Project1].[OLD_IND_ID] AS [OLD_IND_ID],
    [Project1].[PASSWORD_HASH] AS [PASSWORD_HASH],
    [Project1].[PASSWORD_SALT] AS [PASSWORD_SALT],
    [Project1].[PASSWORD_HINT] AS [PASSWORD_HINT],
    [Project1].[PASSWORD_ANSWER] AS [PASSWORD_ANSWER],
    [Project1].[LAST_MATCH_DATE] AS [LAST_MATCH_DATE],
    [Project1].[BAR_CODE] AS [BAR_CODE],
    [Project1].[CREATED_DATE] AS [CREATED_DATE],
    [Project1].[CREATED_BY_LOGIN] AS [CREATED_BY_LOGIN],
    [Project1].[CREATED_BY_USER_ID] AS [CREATED_BY_USER_ID],
    [Project1].[LAST_UPDATED_BY_LOGIN] AS [LAST_UPDATED_BY_LOGIN],
    [Project1].[LAST_UPDATED_BY_USER_ID] AS [LAST_UPDATED_BY_USER_ID],
    [Project1].[old_ind_id2] AS [old_ind_id2],
    [Project1].[MEMBER_ENV_CODE] AS [MEMBER_ENV_CODE],
    [Project1].[SALUTATION] AS [SALUTATION],
    [Project1].[TITLE] AS [TITLE],
    [Project1].[SOLICIT] AS [SOLICIT],
    [Project1].[THANK] AS [THANK],
    [Project1].[Individual_Name] AS [Individual_Name],
    [Project1].[MassActionID] AS [MassActionID],
    [Project1].[RDWAuditDate] AS [RDWAuditDate],
    [Project1].[PreferredPhoneTypeID] AS [PreferredPhoneTypeID],
    [Project1].[PreferredEmailTypeID] AS [PreferredEmailTypeID],
    [Project1].[UnsubscribeAllChurchEmail] AS [UnsubscribeAllChurchEmail],
    [Project1].[C1] AS [C1],
    [Project1].[NOTE_INSTANCE_ID] AS [NOTE_INSTANCE_ID],
    [Project1].[CHURCH_ID1] AS [CHURCH_ID1],
    [Project1].[NOTE_ID] AS [NOTE_ID],
    [Project1].[NOTE_TEXT] AS [NOTE_TEXT],
    [Project1].[HOUSEHOLD_ID] AS [HOUSEHOLD_ID],
    [Project1].[INDIVIDUAL_ID1] AS [INDIVIDUAL_ID1],
    [Project1].[ARCHIVED] AS [ARCHIVED],
    [Project1].[CREATED_DATE1] AS [CREATED_DATE1],
    [Project1].[CREATED_BY_USER_ID1] AS [CREATED_BY_USER_ID1],
    [Project1].[CREATED_BY_LOGIN1] AS [CREATED_BY_LOGIN1],
    [Project1].[LAST_UPDATED_DATE] AS [LAST_UPDATED_DATE],
    [Project1].[LAST_UPDATED_BY_USER_ID1] AS [LAST_UPDATED_BY_USER_ID1],
    [Project1].[LAST_UPDATED_BY_LOGIN1] AS [LAST_UPDATED_BY_LOGIN1],
    [Project1].[NOTE_ID1] AS [NOTE_ID1],
    [Project1].[CHURCH_ID2] AS [CHURCH_ID2],
    [Project1].[NOTE_TYPE_ID] AS [NOTE_TYPE_ID],
    [Project1].[ARCHIVED1] AS [ARCHIVED1],
    [Project1].[CREATED_DATE2] AS [CREATED_DATE2],
    [Project1].[CREATED_BY_USER_ID2] AS [CREATED_BY_USER_ID2],
    [Project1].[CREATED_BY_LOGIN2] AS [CREATED_BY_LOGIN2],
    [Project1].[LAST_UPDATED_DATE1] AS [LAST_UPDATED_DATE1],
    [Project1].[LAST_UPDATED_BY_USER_ID2] AS [LAST_UPDATED_BY_USER_ID2],
    [Project1].[LAST_UPDATED_BY_LOGIN2] AS [LAST_UPDATED_BY_LOGIN2],
    [Project1].[OLD_NOTE_ID] AS [OLD_NOTE_ID]
    FROM ( SELECT
        [Extent1].[INDIVIDUAL_ID] AS [INDIVIDUAL_ID],
        [Extent1].[CHURCH_ID] AS [CHURCH_ID],
        [Extent1].[STATUS_ID] AS [STATUS_ID],
        [Extent1].[STATUS_SELECTLIST_ID] AS [STATUS_SELECTLIST_ID],
        [Extent1].[STATUS_DATE] AS [STATUS_DATE],
        [Extent1].[STATUS_COMMENT] AS [STATUS_COMMENT],
        [Extent1].[PREFIX] AS [PREFIX],
        [Extent1].[LAST_NAME] AS [LAST_NAME],
        [Extent1].[FIRST_NAME] AS [FIRST_NAME],
        [Extent1].[MIDDLE_NAME] AS [MIDDLE_NAME],
        [Extent1].[FORMER_NAME] AS [FORMER_NAME],
        [Extent1].[SUFFIX] AS [SUFFIX],
        [Extent1].[GENDER] AS [GENDER],
        [Extent1].[DATE_OF_BIRTH] AS [DATE_OF_BIRTH],
        [Extent1].[MARITAL_STATUS] AS [MARITAL_STATUS],
        [Extent1].[FIRST_RECORD] AS [FIRST_RECORD],
        [Extent1].[OCCUPATION_ID] AS [OCCUPATION_ID],
        [Extent1].[OCCUPATION_DESCRIPTION] AS [OCCUPATION_DESCRIPTION],
        [Extent1].[EMPLOYER] AS [EMPLOYER],
        [Extent1].[SCHOOL_ID] AS [SCHOOL_ID],
        [Extent1].[DENOMINATION_ID] AS [DENOMINATION_ID],
        [Extent1].[FORMER_CHURCH] AS [FORMER_CHURCH],
        [Extent1].[GOES_BY] AS [GOES_BY],
        [Extent1].[DEFAULT_TAG_COMMENT] AS [DEFAULT_TAG_COMMENT],
        [Extent1].[OTHER_USER_ID] AS [OTHER_USER_ID],
        [Extent1].[LAST_UPDATE] AS [LAST_UPDATE],
        [Extent1].[INDIVIDUAL_CODE] AS [INDIVIDUAL_CODE],
        [Extent1].[UNIQUE_ID] AS [UNIQUE_ID],
        [Extent1].[OLD_IND_ID] AS [OLD_IND_ID],
        [Extent1].[PASSWORD_HASH] AS [PASSWORD_HASH],
        [Extent1].[PASSWORD_SALT] AS [PASSWORD_SALT],
        [Extent1].[PASSWORD_HINT] AS [PASSWORD_HINT],
        [Extent1].[PASSWORD_ANSWER] AS [PASSWORD_ANSWER],
        [Extent1].[LAST_MATCH_DATE] AS [LAST_MATCH_DATE],
        [Extent1].[BAR_CODE] AS [BAR_CODE],
        [Extent1].[CREATED_DATE] AS [CREATED_DATE],
        [Extent1].[CREATED_BY_LOGIN] AS [CREATED_BY_LOGIN],
        [Extent1].[CREATED_BY_USER_ID] AS [CREATED_BY_USER_ID],
        [Extent1].[LAST_UPDATED_BY_LOGIN] AS [LAST_UPDATED_BY_LOGIN],
        [Extent1].[LAST_UPDATED_BY_USER_ID] AS [LAST_UPDATED_BY_USER_ID],
        [Extent1].[old_ind_id2] AS [old_ind_id2],
        [Extent1].[MEMBER_ENV_CODE] AS [MEMBER_ENV_CODE],
        [Extent1].[SALUTATION] AS [SALUTATION],
        [Extent1].[TITLE] AS [TITLE],
        [Extent1].[SOLICIT] AS [SOLICIT],
        [Extent1].[THANK] AS [THANK],
        [Extent1].[Individual_Name] AS [Individual_Name],
        [Extent1].[MassActionID] AS [MassActionID],
        [Extent1].[RDWAuditDate] AS [RDWAuditDate],
        [Extent1].[PreferredPhoneTypeID] AS [PreferredPhoneTypeID],
        [Extent1].[PreferredEmailTypeID] AS [PreferredEmailTypeID],
        [Extent1].[UnsubscribeAllChurchEmail] AS [UnsubscribeAllChurchEmail],
        [Join1].[NOTE_INSTANCE_ID] AS [NOTE_INSTANCE_ID],
        [Join1].[CHURCH_ID1] AS [CHURCH_ID1],
        [Join1].[NOTE_ID1] AS [NOTE_ID],
        [Join1].[NOTE_TEXT] AS [NOTE_TEXT],
        [Join1].[HOUSEHOLD_ID] AS [HOUSEHOLD_ID],
        [Join1].[INDIVIDUAL_ID] AS [INDIVIDUAL_ID1],
        [Join1].[ARCHIVED1] AS [ARCHIVED],
        [Join1].[CREATED_DATE1] AS [CREATED_DATE1],
        [Join1].[CREATED_BY_USER_ID1] AS [CREATED_BY_USER_ID1],
        [Join1].[CREATED_BY_LOGIN1] AS [CREATED_BY_LOGIN1],
        [Join1].[LAST_UPDATED_DATE1] AS [LAST_UPDATED_DATE],
        [Join1].[LAST_UPDATED_BY_USER_ID1] AS [LAST_UPDATED_BY_USER_ID1],
        [Join1].[LAST_UPDATED_BY_LOGIN1] AS [LAST_UPDATED_BY_LOGIN1],
        [Join1].[NOTE_ID2] AS [NOTE_ID1],
        [Join1].[CHURCH_ID2] AS [CHURCH_ID2],
        [Join1].[NOTE_TYPE_ID] AS [NOTE_TYPE_ID],
        [Join1].[ARCHIVED2] AS [ARCHIVED1],
        [Join1].[CREATED_DATE2] AS [CREATED_DATE2],
        [Join1].[CREATED_BY_USER_ID2] AS [CREATED_BY_USER_ID2],
        [Join1].[CREATED_BY_LOGIN2] AS [CREATED_BY_LOGIN2],
        [Join1].[LAST_UPDATED_DATE2] AS [LAST_UPDATED_DATE1],
        [Join1].[LAST_UPDATED_BY_USER_ID2] AS [LAST_UPDATED_BY_USER_ID2],
        [Join1].[LAST_UPDATED_BY_LOGIN2] AS [LAST_UPDATED_BY_LOGIN2],
        [Join1].[OLD_NOTE_ID] AS [OLD_NOTE_ID],
        CASE WHEN ([Join1].[NOTE_INSTANCE_ID] IS NULL) THEN CAST(NULL AS int) ELSE 1 END AS [C1]
        FROM  [dbo].[INDIVIDUAL] AS [Extent1]
        LEFT OUTER JOIN  (SELECT [Extent2].[NOTE_INSTANCE_ID] AS [NOTE_INSTANCE_ID], [Extent2].[CHURCH_ID] AS [CHURCH_ID1], [Extent2].[NOTE_ID] AS [NOTE_ID1], [Extent2].[NOTE_TEXT] AS [NOTE_TEXT], [Extent2].[HOUSEHOLD_ID] AS [HOUSEHOLD_ID], [Extent2].[INDIVIDUAL_ID] AS [INDIVIDUAL_ID], [Extent2].[ARCHIVED] AS [ARCHIVED1], [Extent2].[CREATED_DATE] AS [CREATED_DATE1], [Extent2].[CREATED_BY_USER_ID] AS [CREATED_BY_USER_ID1], [Extent2].[CREATED_BY_LOGIN] AS [CREATED_BY_LOGIN1], [Extent2].[LAST_UPDATED_DATE] AS [LAST_UPDATED_DATE1], [Extent2].[LAST_UPDATED_BY_USER_ID] AS [LAST_UPDATED_BY_USER_ID1], [Extent2].[LAST_UPDATED_BY_LOGIN] AS [LAST_UPDATED_BY_LOGIN1], [Extent3].[NOTE_ID] AS [NOTE_ID2], [Extent3].[CHURCH_ID] AS [CHURCH_ID2], [Extent3].[NOTE_TYPE_ID] AS [NOTE_TYPE_ID], [Extent3].[ARCHIVED] AS [ARCHIVED2], [Extent3].[CREATED_DATE] AS [CREATED_DATE2], [Extent3].[CREATED_BY_USER_ID] AS [CREATED_BY_USER_ID2], [Extent3].[CREATED_BY_LOGIN] AS [CREATED_BY_LOGIN2], [Extent3].[LAST_UPDATED_DATE] AS [LAST_UPDATED_DATE2], [Extent3].[LAST_UPDATED_BY_USER_ID] AS [LAST_UPDATED_BY_USER_ID2], [Extent3].[LAST_UPDATED_BY_LOGIN] AS [LAST_UPDATED_BY_LOGIN2], [Extent3].[OLD_NOTE_ID] AS [OLD_NOTE_ID]
            FROM  [dbo].[NOTE_INSTANCE] AS [Extent2]
            LEFT OUTER JOIN [dbo].[NOTE] AS [Extent3] ON (([Extent3].[NOTE_TYPE_ID] = @DynamicFilterParam_000003) OR (@DynamicFilterParam_000004 IS NOT NULL)) AND (([Extent3].[NOTE_TYPE_ID] = @DynamicFilterParam_000005) OR (@DynamicFilterParam_000006 IS NOT NULL)) AND (([Extent3].[CHURCH_ID] = @DynamicFilterParam_000001) OR (@DynamicFilterParam_000002 IS NOT NULL)) AND ([Extent2].[NOTE_ID] = [Extent3].[NOTE_ID]) ) AS [Join1] ON ([Extent1].[INDIVIDUAL_ID] = [Join1].[INDIVIDUAL_ID]) AND (([Join1].[CHURCH_ID1] = @DynamicFilterParam_000001) OR (@DynamicFilterParam_000002 IS NOT NULL))
        WHERE (([Extent1].[CHURCH_ID] = @DynamicFilterParam_000001) OR (@DynamicFilterParam_000002 IS NOT NULL)) AND (635086 = [Extent1].[INDIVIDUAL_ID])
    )  AS [Project1]
    ORDER BY [Project1].[INDIVIDUAL_ID] ASC, [Project1].[C1] ASC

As you can see, the generated SQL has '([Extent3].[NOTE_TYPE_ID] = @DynamicFilterParam_000005)' instead of IN (values here).
Strangely enough, the results appear as if no filtering is happening at all on NoteInstance and Note, since all results come back even if the result from GetAllowedNoteTypes() contains no values or different values.
Am I doing anything wrong? (ShouldEnforcePermissions, CurrentUser and GetAllowedNoteTypes() are all static)

Values of an IEnumerable filter need to be done during the sql interception.  So the filter is actually created as as "prop = value".  That value is then dynamically replaced with either a single value or changed on-the-fly to an "in" condition if there are multiple values in the IEnumerable.  So, I would guess that in the case you captured, GetAllowedNoteTypes() contains a single value.  Try capturing it again with multiple values and you should see it change to an "in" expression.
As for it appearing as nothing is being filtered, I'm not sure.  I may need to see you models and some sample data that reproduces it.  But...the filters you created are identical to each other.  Is that intentional?  They both create the exact same filter on Note entities even though one of them is named "ChmPeople_NoteInstance" - did you mean that one to filter on NoteInstance entities?

" But...the filters you created are identical to each other. Is that intentional? They both create the exact same filter on Note entities even though one of them is named "ChmPeople_NoteInstance" - did you mean that one to filter on NoteInstance entities?"
You're amazing, yes that was the issue! Thanks!


[FEATURE] Provide detailed error messages for ext_emconf.php validation

This PR proposes a more fine-grained way of ext_emconf.php file validation. A new EmConfValidationError class is introduced (can be converted to a native enum once support for PHP < 8.1 is dropped) which provides a set of possible validation errors. These errors are collected in a new EmConfVersionValidator::collectErrors() method and will be displayed in VersionService instead of the previously used generic error message. This allows users to easily find and solve configuration mismatches in ext_emconf.php file.
Example:

Hi @o-ba, this branch is now also up to date. Would be great if you can take a look at this PR as well :)
Cheers, Elias


Add a bunch more custom emoji

Add URLs to this JSON map should be all that is needed to add new emoji.
We should be able to reference images hosted on our server in the "images" directory.


Some packages asked for are not in the package.json.

Using npm.
Sometime, it ask for some packages with 2 letters that are not present in the package.json like Enter risk level for package he.

It's the name used in the npm registry. Entries like that for sub-packages
   "node_modules/webpack-bundle-analyzer/node_modules/ws": {       "version": "7.5.9",       "resolved": "https://registry.npmjs.org/ws/-/ws-7.5.9.tgz",       "integrity": "sha512-F+P9Jil7UiSKSkppIiD94dN07AwvFixvLIj1Og1Rl9GGMuNipJnV9JzjD6XuqmAeiswGvUmNLjr5cFuXwNS77Q==",       "dev": true,       "engines": {         "node": ">=8.3.0"       },
Would be listed as ws only and not under the full webpack-bundle-analyzer/node_modules/ws.


search bar

Related Issuse

Info about Issue or bug

Closes: #[issue number that will be closed through this PR]
Describe the changes you've made
A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know!
Checklist:

[ ] My code follows the style guidelines of this project.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[ ] My changes generate no new warnings.

Screenshots

Original
Updated

original screenshot
updated screenshot

@mridulabatra Could you please add screenshots of the changes you made? The search bar is quite critical to the application, so we won't want to mess it up :smiley:
Also, there are some merge conflicts arising. See if you can resolve them. If you face any difficulties, feel free to ask! :smiley:

Okh sir

thank you sir


test xr_bitround on different input types

Yes, feel free to merge! Could you create an issue though that we make sure to test we support not only float32.
Originally posted by @observingClouds in https://github.com/observingClouds/bitinformation_pipeline/issues/21#issuecomment-1091321147

Should actually happen in the numcodecs PR


Fix #29478 cached_property decorator doesn't work with mangled method…

… names

There is already https://github.com/django/django/pull/10033.


Not understanding class IndexRanker()

Hi @okhat,
I'm having quite a hard time understanding what is being done in class IndexRanker() and I could really use your help.
It looks like doclens and strides play an important role in determining the output_scores here but I don't understand why we are taking doclens into consideration when calculating the scores of the retrieved pids.
Among some of my questions are:

Why are we calculating the strides?

Why do we need to compare the doclens of the retrieved pids with the strides?
assignments = (doclens.unsqueeze(1) > torch.tensor(self.strides).unsqueeze(0) + 1e-6).sum(-1)

Why did we create new views of the embeddings tensor and use some cumulative doclens values as indexes to select values from those new views of the embeddings tensor?

def _create_views(self, tensor):
        views = []
        for stride in self.strides:
            outdim = tensor.size(0) - stride + 1
            view = torch.as_strided(tensor, (outdim, stride, self.dim), (self.dim, self.dim, 1))
            views.append(view)
        return views
D = torch.index_select(input=views[group_idx], dim=0, index=group_offsets_uniq, out=D_buffers[group_idx][:D_size])
Thanks a lot!

Hey @tdieu29 !
These are all efficiency-oriented snippets of code. The document lengths don't matter for the actual modeling/scoring.
Nonetheless, the doclens are critical for batching the MaxSim score computations. Since each document has its own length, we can't store the index as a 3D tensor. Instead, we store a flattened 2D matrix that packs all documents. The cumulative doclens constitute the offset of each document in the 2D matrix. For instance, doc-0 starts at position zero, whereas doc-1 might start at position 90 if doc-0 has 90 embeddings.
Does this help?

Hi @okhat,
That totally makes sense! I think I was also able to answer all of my questions.


ios-deploy: Unable to locate DeviceSupport directory

Steps to Reproduce
flutter run in examples/flutter_gallery
Flutter Doctor
Paste the output of running flutter doctor here.
[✓] Flutter (on Mac OS X 10.12.5 16F73, locale en-US, channel master)
• Flutter at /Users/rmacnak/Flutter/flutter
• Framework revision 69679be528 (6 days ago), 2017-07-05 13:01:40 -0700
• Engine revision 8ad1576f27
• Tools Dart version 1.25.0-dev.4.0
[✓] Android toolchain - develop for Android devices (Android SDK 25.0.3)
• Android SDK at /Users/rmacnak/Library/Android/sdk
• Platform android-25, build-tools 25.0.3
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_112-release-b06)
[✓] iOS toolchain - develop for iOS devices (Xcode 8.3.3)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 8.3.3, Build version 8E3004b
• ios-deploy 1.9.1
• CocoaPods version 1.2.1
[✓] Android Studio (version 2.3)
• Android Studio at /Applications/Android Studio.app/Contents
• Java version OpenJDK Runtime Environment (build 1.8.0_112-release-b06)
[✓] Connected devices
• iPod touch • f73d01ae6367fbc7b50cad846bbc5735098c3276 • ios • iOS 10.3.2

Duplicate of #4326


WSL 2 not working with Acrylic DNS

Please use the following bug reporting template to help produce issues which are actionable and reproducible, including all command-line steps necessary to induce the failure condition. Please fill out all the fields! Issues with missing or incomplete issue templates will be closed.

Your Windows build number:  19041.264

What you're doing and what's happening:  After installing Acrylic DNS service the wsl would not work anymore.
This is what you after start Acrylic DNS and opening WSL terminal (You need to restart the system)

What's wrong / what should be happening instead:
WSL and terminal shoul works normally

Strace of the failing command, if applicable:  (If some_command is failing, then run strace -o some_command.strace -f some_command some_args, and link the contents of some_command.strace in a gist here).

For WSL launch issues, please [collect detailed logs]:
lxcore.zip

This seems to be an issue with Acryclic DNS binding to port 53 according to some other issues here. First encountered this after switch Docker Desktop's backend to WSL 2. Disabled Acryclic DNS and was able to start Docker Desktop with WSL 2 properly.

https://github.com/microsoft/WSL/issues/4364#issuecomment-866700145

I experienced this very recently (and so was watching this issue hoping for a fix..). So it seems to remain an issue.

I experienced this very recently (and so was watching this issue hoping for a fix..). So it seems to remain an issue.

Did you try the workaround

This stopped docker desktop from starting. I simply stopped the Acrylic DNs Proxy. Restarted wsl and docker started working, once they were up and running, I restarted  acrylic DNS and it worked fine.


[Bug] view column return value instead of null when left join a view with condition not met

Search before asking

[X] I had searched in the issues and found no similar issues.

Version
1.2.0
What's Wrong?
If condition is not met when left join a view, some of the view columns still return value instead of null
What You Expected?
If left join condition not met, all of the columns of the right table should be null
How to Reproduce?
create view public_holiday_view as
select rp.publicholidaydatetime, rp.publicholidayname, rp.companyid, rs.branchid, 1 IsPublicHoliday
from publicholidayconfigurations rp
inner join publicholidaylinks rp2 on rp.id = rp2.publicholidayid
left join sitegrouplinks rs on rs.sitegroupid = rp2.granularityid
select sd.__time, ph.* from store_data sd
LEFT JOIN public_holiday_view ph on ph.companyid = sd.companyid and ph.publicholidaydatetime = date(sd.__time)
__time             |publicholidaydatetime|publicholidayname|companyid|branchid|IsPublicHoliday|
-------------------+---------------------+-----------------+---------+--------+---------------+
2022-01-28 00:00:00|  2022-01-28 00:00:00|test1            |    123|   456|              1|
2022-01-29 00:00:00|                     |                 |         |        |              1|
IsPublicHoliday column in 2022-01-29 00:00:00 should be null instead of 1
Anything Else?
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Tested no issue in 2.0.0


validateRequest not validating request

Not sure if using wrong or just broken on OS X 10.10.5 and Meteor <IP_ADDRESS>
For me
UploadServer.init({
    // ..
    validateRequest:function(_request){
      return false;
    },
    // ..
});

still allows uploads and
UploadServer.init({
    // ..
    validateRequest:function(_request){
      return true;
    },
    // ..
});

results in a server error directly after uploading a file (client shows 503 service unavailable)
W20150927-18:14:32.033(2)? (STDERR) TypeError: first argument must be a string or Buffer
W20150927-18:14:32.036(2)? (STDERR)     at ServerResponse.OutgoingMessage.write (http.js:852:11)
W20150927-18:14:32.036(2)? (STDERR)     at ServerResponse.res.write (/Users/Me/.meteor/packages/webapp/.1.2.2.qij5pj++os+web.browser+web.cordova/npm/node_modules/connect/lib/middleware/compress.js:110:17)
W20150927-18:14:32.037(2)? (STDERR)     at Object.UploadServer.serve [as handle] (packages/tomi_upload-server/packages/tomi_upload-server.js:201:1)
W20150927-18:14:32.038(2)? (STDERR)     at next (/Users/Me/.meteor/packages/webapp/.1.2.2.qij5pj++os+web.browser+web.cordova/npm/node_modules/connect/lib/proto.js:190:15)
W20150927-18:14:32.038(2)? (STDERR)     at Function.app.handle (/Users/Me/.meteor/packages/webapp/.1.2.2.qij5pj++os+web.browser+web.cordova/npm/node_modules/connect/lib/proto.js:198:3)
W20150927-18:14:32.038(2)? (STDERR)     at Object.fn [as handle] (/Users/Me/.meteor/packages/webapp/.1.2.2.qij5pj++os+web.browser+web.cordova/npm/node_modules/connect/lib/proto.js:74:14)
W20150927-18:14:32.038(2)? (STDERR)     at next (/Users/Me/.meteor/packages/webapp/.1.2.2.qij5pj++os+web.browser+web.cordova/npm/node_modules/connect/lib/proto.js:190:15)
W20150927-18:14:32.038(2)? (STDERR)     at Object.WebAppInternals.staticFilesMiddleware (packages/webapp/webapp_server.js:331:1)
W20150927-18:14:32.039(2)? (STDERR)     at packages/webapp/webapp_server.js:625:1

The package is awesome though, thanks for setting it up!

Uff, sorry for such a long rsponse. I have published a newere version that dealt with this issue. IO hope it resolved your prroblem.

I'm still experiencing the same behavior with version 1.3.2 and latest Meteor version.

:+1:

Guys, I promise that newest version deals with this bug. Also make sure that you return Error mrssage in case of failed validation. I have also updated the documentation. Please check out the whole new section on Validations.