Please consider fixing issues detected by repository checker

Notification from ioBroker Check and Service Bot
Dear adapter developer,
I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter vis-homekittiles for common errors and appropiate suggestions to keep this adapter up to date.
This check is based the current head revisions (master / main  branch) of the adapter repository
Please see the result of the check below.
ioBroker.vis-homekittiles
   -
:thumbsup: No errors found
WARNINGS:

[ ] :eyes: [W040] "keywords" within package.json should contain "ioBroker"
[ ] :eyes: [W184] "common.main" is deprecated and ignored. Please remove from io-package.json. Use "main" at package.json instead.
[ ] :eyes: [W184] "common.noConfig" is deprecated for admin >= 5 at io-package.json. Please use property "adminUI.config":"none".

:thumbsup: No suggestions found
Please review issues reported and consider fixing them as soon as appropiate.
Warnings reported by repository checker should be reviewed. While some warnings can be ignored due to good reasons or a dedicated decision of the developer, most warnings should be fixed as soon as appropiate.
You may start a new check or force the creation of a new issue at any time by adding the following comment to this issue:
@iobroker-bot recheck
@iobroker-bot recreate
Please note that I (and the server at GitHub) have always plenty of work to do. So it may last up to 30 minutes until you see a reaction. I will drop a comment here as soon as I start processing.
Feel free to contact me (@iobroker-bot) if you have any questions or feel that an issue is incorrectly flagged.
And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.
your
ioBroker Check and Service Bot
@mcm1957 for evidence
Last update at Fri, 13 Sep 2024 14:14:44 GMT based on commit 9f7b23f62b8ccfd41577c20df98eca3c436befbf
ioBroker.repochecker 3.0.5

This issue has been updated by ioBroker Check and Service Bot
The following issues have been fixed
[E162] js-controller dependency missing. js-controller 4.0.24 is required as minimum, 5.0.19 is recommended. Please add to dependencies at io-package.json.
:thumbsup:Thanks for fixing the issues.

This issue has been updated by ioBroker Check and Service Bot
The following issues have been fixed
[W184] "common.main" is deprecated and ignored. Please remove from io-package.json. Use "main" at package.json instead.
:thumbsup:Thanks for fixing the issues.
The following issues are new and have been added
[W184] "common.main" is deprecated and ignored. Please remove from io-package.json. Executable is defined by entry "main" at package.json.


Display license and terms of service

Fixes #2326

Adds 2 new entries in the app drawer: "About" and "Terms of service"
Clicking on "About" opens a new screen with hyperlinks to apache license and other licenses
Clicking on "Terms of service" opens the original terms of service screen with checkbox and accept button hidden

license_tos.webm

@sufyanAbbasi @gino-m  PTAL?

wait are we not moving sign out to the profile icon? But yes, about and terms of service should be last on the list!

"Sign out" will be moved in a separate PR.

I'll move "settings" above "about"

LGTM from PM perspective. @sufyanAbbasi for eng stamp.


SendTrx reports an error when used

tronweb: "^6.0.0"
Shasta Testnet
const unsignedTxn = await tronWeb.transactionBuilder.sendTrx(             to,             amount,             from ); console.log(unsignedTxn)
report errors：
AxiosError: maxContentLength size of -1 exceeded

TransactionBuilder uses local build and the error is like a network error. So please check other parts of your code to locate the problem.

TransactionBuilder uses local build and the error is like a network error. So please check other parts of your code to locate the problem.

Error locating to this sentence, just upgraded Tronweb

Could you snapshot the error and upload?


improve snapshot uploading

This PR improves the snapshot uploading to our server drastically and uses sftp for file transfer.
10 lines of sftp commands are much simpler and easier to maintain than any Flask app.

[x] reenable travis test matrix
[ ] port to appveyor
[x] discuss folder structure and symlinks
[x] only keep the 10 most recent builds

closes #927
ref https://github.com/mitmproxy/release/issues/3

superseeded by using pysftp in mitmproxy/release repository.


chore: update java docs and add example

This PR does 3 things:

Update existing java examples to newer cdk8s version
Add new CRD example for java
Update the docs on the website

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@campionfellin Thanks!

@campionfellin Thanks!


Are you requesting a new package or reporting an issue on an existing one?
An existing one.
If reporting an issue on an existing one, what is the name of the package?
php81Extensions.gd
What changes are you requesting?
It fails to build since yesterday when performing a devbox update.
Additional context
This is the error message:
Installing package: php81Extensions.gd.

[1/1] php81Extensions.gd
error: builder for '/nix/store/ffjkswblam2qpx2yvcbgk0pc31y65dcp-php-8.1.27.drv' failed with exit code 2;
       last 10 log lines:
       >                                  xmlStructuredErrorFunc handler);
       >                                                         ^
       > /private/tmp/nix-build-php-8.1.27.drv-0/php-8.1.27/ext/libxml/libxml.c:1016:8: warning: assigning to 'xmlErrorPtr' (aka 'struct _xmlError *') from 'const xmlError *' (aka 'const struct _xmlError *') discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
       >         error = xmlGetLastError();
       >               ^ ~~~~~~~~~~~~~~~~~
       > 2 warnings and 1 error generated.

And this is in devbox.lock after the failed update:
    "php81Extensions.gd@latest": {
      "last_modified": "2024-01-27T14:55:31Z",
      "resolved": "github:NixOS/nixpkgs/160b762eda6d139ac10ae081f8f78d640dd523eb#php81Extensions.gd",
      "source": "devbox-search",
      "version": "8.1.27",
      "systems": {
        "aarch64-linux": {
          "store_path": "/nix/store/6i5x37a6341m7cnybpnrhbj3p4hwnv1y-php-gd-8.1.27"
        },
        "x86_64-linux": {
          "store_path": "/nix/store/q0jxg6vm96y0dgcmfymn9swh9sjqjczc-php-gd-8.1.27"
        }
      }
    }

This specific version did work:
"php81Extensions.gd@latest": {
      "last_modified": "2023-12-31T07:44:09Z",
      "resolved": "github:NixOS/nixpkgs/d44d59d2b5bd694cd9d996fd8c51d03e3e9ba7f7#php81Extensions.gd",
      "source": "devbox-search",
      "version": "8.1.27",
      ...
}

See also https://github.com/jetpack-io/devbox/pull/1731 and https://github.com/php/php-src/issues/12965 which mention this issue.

FYI I did solve it for now by specifying github:NixOS/nixpkgs/d44d59d2b5bd694cd9d996fd8c51d03e3e9ba7f7#php81Extensions.gd as the package in devbox.json instead of php81Extensions.gd@latest.


#809: Six new connector label positions

Proposal for adding new connector label positions.

Thanks for the PR, it seems to be well organised.
I have some minor comments:

AbstractDiagramConnectionFigure.java - remove the unnecessary import com.archimatetool.model.IProperty;
ArchiConnectionEndpointLocator - no need to change Connection to AbstractDiagramConnectionFigure
'ArchiConnectionEndpointLocator` the new constructor should be added rather than replacing the original one in case a third-party is using it (it's public)
The label strings are inconsistent - perhaps better would be "Source Above", "Source Center", "Source Below", "Middle Above", "Middle Center", "Middle Below", "Target Above", "Target Center", "Target Below".
The licence header in ArchiConnectionMiddleLocator should be as in AbstractDiagramConnectionFigure

ArchiConnectionMiddleLocator extends ConnectionLocator but we use ArchiConnectionEndpointLocator (replacement for ConnectionEndpointLocator) for some cases and I'm wondering why we use that special class, and if the new ArchiConnectionMiddleLocator might be missing something from it? @jbsarrodie ?

Hi,
(related to #809)
Well, before looking at this code proposal, I must admit that I'm not in favor of such change. Most of what you provide can be done by tuning the label expression (using some newlines or ${wordwrap} for example). So I think this new set of choices make it more complex for the user in fact. IMHO, we should either stay are we are now (start | middle | end) or implement the real thing (movable label).

Hi,
(related to #809)
Well, before looking at this code proposal, I must admit that I'm not in favor of such change. Most of what you provide can be done by tuning the label expression (using some newlines or ${wordwrap} for example). So I think this new set of choices make it more complex for the user in fact. IMHO, we should either stay are we are now (start | middle | end) or implement the real thing (movable label).

OK, that's a fair comment.

or implement the real thing (movable label).

As shared in some occasion, I think we could leverage note and label expression. It is already possible to create a note with transparent border and background, connect it to some concept, and use a label expression to display the name of the concept. We have almost all pieces needed to create movable labels. I think the only missing pieces are: being able to make the connection transparent, and have a way to reference the concept's label and not just the concept's name.

Thanks for the comments! My main driver was the Middle positioning because it's always on top of the connector, and effectively blocks the visibility of short connectors. Label expression doesn't help here (at least to my understanding) because the label has explicit background color instead of being transparent, so newlines will also hide the connector line.
I agree that my current proposal makes the drop-down menu too complex. What about having a separate drop-down menu just for vertical positioning? The current position menu would remain unchanged, and the new menu wouldn't need to be used at all if the default vertical positioning is ok. It could have options Default, Above, Center, and Below, for example.
Freely movable labels would be great, of course, but that's not something I'm able to implement.


Batch cue words.ComfyUI Error Report， KeyError：'context'，request help

ComfyUI Error Report
Error Details

Node Type: OllamaGenerateAdvance
Exception Type: KeyError
Exception Message: 'context'

Stack Trace
  File "E:\ComfyUI-aki-v1.4\execution.py", line 323, in execute
    output_data, output_ui, has_subgraph = get_output_data(obj, input_data_all, execution_block_cb=execution_block_cb, pre_execute_cb=pre_execute_cb)

  File "E:\ComfyUI-aki-v1.4\execution.py", line 198, in get_output_data
    return_values = _map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True, execution_block_cb=execution_block_cb, pre_execute_cb=pre_execute_cb)

  File "E:\ComfyUI-aki-v1.4\execution.py", line 169, in _map_node_over_list
    process_inputs(input_dict, i)

  File "E:\ComfyUI-aki-v1.4\execution.py", line 158, in process_inputs
    results.append(getattr(obj, func)(**inputs))

  File "E:\ComfyUI-aki-v1.4\custom_nodes\comfyui-ollama\CompfyuiOllama.py", line 248, in ollama_generate_advance
    return (response['response'], response['context'],)

System Information

ComfyUI Version: v0.2.4-16-g30c0c81
Arguments: E:\ComfyUI-aki-v1.4\main.py --auto-launch --preview-method auto --disable-cuda-malloc
OS: nt
Python Version: 3.10.11 (tags/v3.10.11:7d4cc5a, Apr  5 2023, 00:38:17) [MSC v.1929 64 bit (AMD64)]
Embedded Python: false
PyTorch Version: 2.3.1+cu121

Devices

Name: cuda:0 NVIDIA GeForce RTX 3080 Ti : cudaMallocAsync

Type: cuda
VRAM Total:<PHONE_NUMBER>0
VRAM Free:<PHONE_NUMBER>2
Torch VRAM Total: 0
Torch VRAM Free: 0

what version of ollama are you using? this was a bug in some versions that they omitted context from the response.

what version of ollama are you using? this was a bug in some versions that they omitted context from the response.

fixed now? this bug seems sometimes happen,i use ollama_generate_advance node more than 10times,when i change another ollama model, bug get


Is this library is not maintained?

I see issues that doesnt closed and some PRs that doesnt merged.
Is this library dead?

@Carsak , in case it's still relevant this is a great fork imo: https://github.com/renarsvilnis/apple-sign-in-rest

@Carsak , in case it's still relevant this is a great fork imo: https://github.com/renarsvilnis/apple-sign-in-rest


Update Typescript library

I think my fix for https://github.com/CosmWasm/ts-codegen/issues/90 might work for you as well.
Try removing the raw/ folder from each of these:
https://github.com/public-awesome/launchpad/tree/schema/contracts/sg-eth-airdrop/schema
https://github.com/public-awesome/launchpad/tree/schema/contracts/splits/schema
https://github.com/public-awesome/launchpad/tree/schema/contracts/whitelist-immutable/schema


Light Client Refactor Review

Did a full review of the new light-client code. It looks really great, especially all the linking to the spec, the separation of components, the clarity of the sequential list of predicates, and the overall completeness of everything. That said I have some concerns and a variety of feedback, which I'll just braindump here, roughly by section/concern.
And apologies for having not been able to review more frequently. I've gotten into a habit recently of dropping large reviews all at once after months of work, which probably isn't the best approach. I'm going to try and fix that moving forward.
ADR
At a meta/process level, we probably shouldn't have done this without a more complete ADR. That's my bad, I explicitly dismissed it at the time, but I think I was anxious about making progress on this and we seem to have underestimated how long this work would take (classic). It definitely would have helped to have it during the review and to codify why we did this refactor and how it compares to the previous versions. Some of the below concerns may have been properly addressed in an ADR, including a possible iterative plan to address them. It might even be worth still writing one.
Coupling to Tendermint types
The new crate seems heavily coupled to the tendermint crate. One of the original design goals was for the light-client logic to be decoupled from the tendermint types, and the previous version pretty much achieved this via the header/commit/validator etc traits. Is there some plan for how to address this?
My understanding was that the predicates would be closures, and would close over the specific types, so they wouldn't need to take those concrete types as arguments. Is that still the plan?
This decoupling isn't critical in the short term, and right now we need to focus on shipping this rather than more refactors, but I still think it matters, so we should have a plan for addressing down the road.
The traits in operations expose more or less the same set of methods that were exposed by the traits in the prior version, which suggests they'd need to be mocked out similarly, but my understand was that we wanted to get away from mocking data like that. Iirc, a big motivation for the refactor was supposed to be for improved unit tests by reducing the need to mock these kinds of traits. Meanwhile, we don't have any unit tests yet, which might be a bit concerning. My impression is that given the amount of coupling, unit testing eg. the Verifier::verify  method will require a lot of mocking, similar to the previous version of the code ...
Other High Level
We're using a lot of use::* - we should probably prefer explicit imports.
We should create issues for the TODO and FIXME in the code.
Bisection Tracing

Can we find a better name for trace_block? We're not really tracing here, we are marking something is on a trace. At least a better comment where it's called
Can we better document who get_trace is for (ie. IBC)

Store

What's with the secondary indices for the verification status? Don't we only have one header per height at a time?
If not, memory store doesnt seem to support more than one header per height?
In any case can we better document the need
What's the plan for implementing latest so we don't iterate over everything (ie. see the FIXME)

Light Client

In what case might get_or_fetch return an already verified header?
"If the trusted state is now at the height greater or equal to the target height," - how could we ever get to something greater than the target height?

Operations

Looks like we copied a lot of stuff in from the tendermint crate. Presumably these will get deduplicated?
voting_power_in: this function was already broken (#282), but in any case we may want/need two versions of it, one for when the validator set matches the commit (ie. when we're verifying +2/3 signatures for a block) and one for when we're checking the overlap between the signatures and our last trusted validators. This may become necessary especially if the ValidatorAddress is removed from the CommitSig, which is being contemplated upstream. Then we'll need access to both the current and last trusted validator sets for the verify_overlap computation.
 We should open an issue for that if we don't have already.

Predicates

is_within_trust_period:

I don't think this needs to be called each time, only once at the start of a bisection trace (the other calls should be redundant since we can't expire in there). Not a problem, just a note.
the header.time  < now check seems to be duplicated
the header.time <= now check should probably use header.time < now + delta, ie #137

header_matches_commit:

there was a recent discussion around possibly removing the commit.BlockID field (along with a bunch of other redundant data in Tendermint commits/blocks), since it's technically redundant. If that happens, this check would become implementation dependent.

verify_overlap

this should just check has_sufficient_validators_overlap but not has_sufficient_signers_overlap
the former is the actual overlap check we need for bisection. the latter is the full verification for the commit

has_sufficient_voting_power

this should be the full +2/3 verification that the validators correctly committed the block.
I believe it should be what is currently has_sufficient_signers_overlap

Verifier

the verify method is beautiful :)
but verify_overlap should only be called in the non-sequential case, ie. when light_block.height() != trusted_state_next_height. Otherwise verification would fail if the validator set changes significantly from one block to the next and we'd never be able to make progress. We should definitely have a JSON test for this, I'm a bit surprised if we don't already ...

Errors

InsufficientValidatorsOverlap - should we include the fraction and the threshold we were looking for? Maybe the fraction can just be part of the string display, but the threshold might be good to include.

Thanks for taking the time to do a thorough review. I agree with most of the concerns here. A few comments at the meta level before jumping into specific points. Even if I consider the refactor successful, I think we could have scoped it tighter. This have gotten it merged faster and made it easier to describe in a ADR. We had some key goals that were addressed but a lot of the value that we got from this work was peripheral and not negotiated in the original scope. We can definitely be more diligent here in the future. With that said I’ll focus of the process/architecture concerns.
ADR
Agree here and as mentioned above this would have been helped by better scoping. We kind of abused ADR-006 here to capture the evolution of our thinking but I sense that a lot of details got lost in the quick iterations. The process was dynamic and aligned with the English specification.  Most of this alignment was done via live code reviews in our weekly meeting. There were so many ideas flying around and being experimented with that it was difficult to capture intermediate thinking in writing.  The speed of the process was valuable but admit that it would be better/more inclusive if we kept a better record of our thinking and decisions. I think you’re right that it is worth describing the conclusion of this work in one or perhaps multiple ADRs.
Coupling Of Tendermint Types
Yes the intention is for the light client to use its own types which only have the fields the light client needs. But those types will most likely be constructed from the original Tendermint types for simplicity (or have From trait implementations). We haven’t gotten there yet as we wanted to merge this as soon as possible.
What we did de-couple is the crypto functions from their types by isolating the dependencies in the operations module as you mention. The idea here is to update Tendermint crate such that none of our core types depend on complex crypto functions. It will also allow us to inject simplified implementation of these operations during testing. So most likely the operations stuff will move into the main crate and provide mock implementations for testing. This way the simplified core types will not need to be mocked out in test, only the operations will. The current location of this code is an intermediate step in that direction.

Also a note about the scheduler. It's a bit hard to read the bisection logic out of it.

Can we use single word variable names like trusted, next, and target to make this more readable in cases like this where it's obvious we're dealing with heights and no other types?
The conditional block is hard to read. Can we clarify the cases somehow by relying on relationships that should always hold when verifying into the future, like (?) :

trusted <= next
trusted <= target
next <= target

If the above conditions are true, it's hard to understand that last branch of the conditional (it would never trigger?)
How to reconcile previous point with need to schedule into the past? Split the schedule function in two ?

@ebuchman Thanks for thorough review :)
I have answered some of your questions and tracking progress on your comments in https://gist.github.com/romac/fe0415aba0397bf14912b505d5eba785.

Can we confirm that the major points have been either addressed in (#284 #302 ) or broken out into follow up issues?

Closing for now. Feel free to open if something was missed.


Bug(?): icinga-director kickstart in fullstack playbook not working

The kickstart of the icinga-director cannot be executed in a single fullstack deployment.
The required state of Icinga 2 for the kickstart is created by the restart handler. The handler is executed at the end of all roles.
If you want to install and kickstart the icinga-director in order to have a complete setup, this will fail because the Icinga 2 handler was logically not yet running at this point.
There are workarounds:

run_kickstart: false and kickstart manually
Create a second play with icinga.icinga.icingaweb2 only, that is started afterwards.

In my opinion a fullstack deployment (including icinga-director kickstart) should work. It could be a idea to flush the handlers after the icinga2 role.
The best-practice from Ansible's point of view with handlers unfortunately collides with the functionality of the icinga components.

You can also use Flush Handlers
tasks:
   - shell: some tasks go here
   - meta: flush_handlers

Did you try to use flush_handlers in the playbook? Would this be a viable option to use?

Sorry for the late response.
Sure, flushing could "solve" this.
But in a deployment in which the roles are not called by includes within tasks, but only by roles: [...] this will not work.
I could be wrong here, but from my point of view it should be possible to execute a single playbook without additional tasks to include roles or flush handlers.

- hosts: domain.net
  become: yes
  tasks:
    - ansible.builtin.include_role:
        name: int.ntp
        apply:
          tags: icinga
      tags: always
    - ansible.builtin.include_role:
        name: int.env
    - ansible.builtin.include_role:
        name: int.apt
    # - { role: int.certbot, tags: ['certbot'] }
    - ansible.builtin.include_role:
        name: geerlingguy.mysql
        apply:
          tags: mysql
      tags: always
    - ansible.builtin.include_role:
        name: icinga.icinga.repos
        apply:
          tags: icinga
      tags: always
    - ansible.builtin.include_role:
        name: icinga.icinga.icinga2
        apply:
          tags: icinga
      tags: always
    - ansible.builtin.include_role:
        name: icinga.icinga.icingadb
        apply:
          tags: icinga
      tags: always
    - ansible.builtin.include_role:
        name: icinga.icinga.icingadb_redis
        apply:
          tags: icinga
      tags: always
    - ansible.builtin.include_role:
        name: icinga.icinga.monitoring_plugins
        apply:
          tags: icinga
      tags: always
    - meta: flush_handlers
      tags: icinga
    - ansible.builtin.include_role:
        name: icinga.icinga.icingaweb2
        apply:
          tags: icinga,icingaweb2
      tags: always

Results in the following error
TASK [icinga.icinga.icingaweb2 : Module Director | Run kickstart if required _raw_params=icingacli director kickstart run] ***********************************************************************************************************************************************************************************************
fatal: [domain.net]: FAILED! => {"changed": true, "cmd": "icingacli director kickstart run", "delta": "0:00:00.141587", "end": "2024-10-14 10:59:23.531171", "msg": "non-zero return code", "rc": 1, "start": "2024-10-14 10:59:23.389584", "stderr": "ERROR: RuntimeException in /usr/share/icingaweb2/modules/director/library/Director/Core/RestApiClient.php:149 with message: Unable to authenticate, please check your API credentials", "stderr_lines": ["ERROR: RuntimeException in /usr/share/icingaweb2/modules/director/library/Director/Core/RestApiClient.php:149 with message: Unable to authenticate, please check your API credentials"], "stdout": "", "stdout_lines": []}

I see the api credentials in /etc/icinga2/conf.d/api-users.conf

You are already using the flush_handlers but you need to use them after the icinga2 role.
As Icinga2 reads its new configuration, in this case the api-users before the reload and after the reload the configuration is active.
But I'll discuss this, I'm aware that the icinga2 core should be useable after the role is done.

I've placed the handler right after the icinga.icinga.icinga2 role now with the same result. But even running icingacli director kickstart run I get the same error. So there must be an error somewhere else I guess.
This should be the default director port right?
tcp                   LISTEN                  0                       4096                                                                     *:5665                                              *:*`

api-users.conf by ansible
object ApiUser "root" {
  password = "passapi"
  permissions = [ "*", ]
}

/etc/icingaweb2/modules/director/kickstart.ini
[config]
endpoint = domain.net
host = <IP_ADDRESS>
username = root
password = passapi

/etc/icingaweb2/modules/director/config.ini
[db]
resource = director_db

I've moved two tasks to handlers/. Handlers should be run in the same order they are notified in. Meaning role 'icinga2' -> "notify restart icinga2" -> role 'icingaweb2' -> "notify director migration/kickstart" -> "actual restart icinga2" -> "actual director migration/kickstart".
Does that fix the problem for you @tbauriedel?

@Donien that should work, thank you!


Update README.md

Description
Changes proposed in this pull request:

...
...
...

Related issue(s)

/test kyma-integration

/test kyma-integration

/test integration

/test kyma-integration

/test kyma-integration


test: add screenshot test

Closes:   https://github.com/styled-components/styled-components/issues/229
Introduces yarn test:integration task that will compare example site with saved screenshot. Eventual differences (on test fail) will be visible as png file created in integration-test/__image_snapshots__/__diff_output__.
To replace expected image: delete it from integration-test/__image_snapshots__ and run yarn test:integration which will recreate and save png.

Right, I wasn't sure what extras you would need so implementation is minimalistic. Of course, I'll add things you mentioned.

Remarks applied

Uhh, the screenshot is just white?

Uuuups, investigating ..., (global animation rule perhaps?)

Ach, Example requires external babel links. I removed external request block. We could add those URLs to whitelist and possibly update that whitelist after edits in the example, but I'm thinking: is there a harm in allowing external requests?

Added a regexp whitelist

I'm preparing video training with testing as one chapter and it would be really a value for me to understand, why we put these options in. @philpl, @morajabi Could you tell why not having these could break a test?
I tried to find out in docs, but man, I don't even understand what they do.  The screenshot will be all blue and test will pass.
--no-sandbox

Disables the sandbox for all process types that are normally sandboxed
https://peter.sh/experiments/chromium-command-line-switches/#no-sandbox

First thought: it will delete sandbox mode from your Minecraft. You will have more time to improve code quality and tests will pass more often.
--disable-setuid-sandbox

Disable the setuid sandbox (Linux only).
https://peter.sh/experiments/chromium-command-line-switches/#disable-setuid-sandbox

First thought: it will run GTA without a map. Not sure about impact on running tests.
deviceScaleFactor

 Specify device scale factor (can be thought of as dpr). Defaults to 1
https://github.com/GoogleChrome/puppeteer/blob/master/docs/api.md#pagesetviewportviewport

This one I almost understand. It's about avoiding image to be blurry on some devices, right? But why value 1 would prevent it?
Seriously, I'm clueless and would ❤ to learn something here.

I'll make the appropriate changes in a follow-up PR to enable the test on Travis.

Wait so this isn't running on Travis yet? I is confused

Probably we just need to add script: yarn test:integration to .travis.yml ... and set some env variables.

I think @philpl struggled with Travis a lot for the website. @mxstbr No?

@maciej-ka I’ll take care of the travisconfig changes; no worries 😬 it has been tricky to make it work reliably, but fortunately I’ll be able to move the website’s config changes over 1:1

Thanks a lot for contributing to styled-components! I've invited you to our organization, if you have any questions, let me know!

@maciej-ka I love this moment on Github! 😍  @mxstbr

WOW!


ModuleNotFoundError: No module named 'rotary_embedding_torch'

"/Personal/Codes/h-transformer-1d/h_transformer_1d/h_transformer_1d.py", line 6, in
from rotary_embedding_torch import apply_rotary_emb, RotaryEmbedding"
Seems there is a module that was not committed to the repo.

make sure you run pip install h-transformer-1d first! or pip install rotary-embedding-torch


Create a base plugin

Please add an AbstractSelfContained computable plugin that implements the output variable interface.
You can copy the RASCAL repo, strip out all process specific logic and create the base plugin from that template.

Complete with commit 9b56407


wfreedrp.exe does nothing on windows

Have tried downloading both cloud versions for windows and the latest stable nightly version #699.  I have tried running the executables as admin with both a windows 7 and windows 10 system.  Windows 10 is 1903 and I have checked firewalls and antivirus programs but there are no logs anywhere of anything blocking it.  I have created a text log detailing the current version of wfreerdp after nothing happens and it just says it isn't a recognizable batch or command, so it really is doing nothing.  I don't even see it doing anything from the system monitor.    Are there some prerequisites like Visual Studio that are required for this application to run?  I don't see anything in any documentation on needing to do special activities with the executable and I was hoping to avoid cloning the source and self-compiling.    Both systems are 64.

Please use the mailing list or irc for support.
As for wfreerdp, it is a command line app, you can create a lig with wfreerdp.exe  >log.txt 2>&1


Features/cart

I'm still unable to test because of Mysql connection issues, but npm compiles.
Added routes:
cart/add
cart/remove

I just cleaned up some of the routes and added a middle ware for checking for an open cart


Migrate the contract/[id] page to explored

Closed with https://github.com/SiaFoundation/web/pull/761, only API-related hanging issue is: https://github.com/SiaFoundation/web/issues/825


Can you make a Flask version?

I want to create a web application using AWS EC2 + Flask + ngrok, but I'm not a web application engineer, so I'm currently studying. I would appreciate it if you could also create a version of Flask if possible. Thank you.

Hello, sorry but I can't help with that because I no longer have access to
AWS. Unless I'm paid to help I can't.
On Thu, 31 Aug 2023, 06:40 Keiichi Kuroyanagi, @.***>
wrote:

I want to create a web application using AWS EC2 + Flask + ngrok, but I'm
not a web application engineer, so I'm currently studying. I would
appreciate it if you could also create a version of Flask if possible.
Thank you.
—
Reply to this email directly, view it on GitHub
https://github.com/Nneji123/AWS-EC2-Setup-for-FastAPI-and-Ngrok-Deployment/issues/2,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYH5RABD54OKNR7ZHKSAHMDXYAPUJANCNFSM6AAAAAA4FQNDTA
.
You are receiving this because you are subscribed to this thread.Message
ID: <Nneji123/AWS-EC2-Setup-for-FastAPI-and-Ngrok-Deployment/issues/2@
github.com>

Thank you for your comment.


Fix TreeDataGridPresenterBase Replace Regression

This fixes https://github.com/AvaloniaUI/Avalonia.Controls.TreeDataGrid/issues/265. The more efficient use of ItemsReplaced is kept when the old and new items have the same length. Otherwise, the previous behavior is used.
Note that https://github.com/AvaloniaUI/Avalonia/pull/13795 made the same change to VirtualizingStackPanel that was made to TreeDataGridPresenterBase which caused the issue. I haven't used the VirtualizingStackPanel before, so I can't test if it has the same issue.

I've updated this to resolve conflicts. I've also added a minimal reproducible example to https://github.com/AvaloniaUI/Avalonia.Controls.TreeDataGrid/issues/265. If anyone gets time to take a look, it would be much appreciated.


Change CRD domain to spinkube.dev

REF:
https://github.com/spinkube/skips/pull/5
https://github.com/spinkube/spin-operator/pull/271

@bacongobbler your eyeballs would be greatly appreciated in this general direction.

Since we release docs off the tip of main I've marked this PR as DO NOT MERGE until we release spin operator v0.4.0

force-pushed the commit to sign off on it


Move SwiftUI related from shortcut-foundation-ios

Amazing work @KhoiNguyenShortcut
Could we merge and draft the first release version?
We could start with 0.1.0 what do you think?

Sure, I can do it


[5.6] Add method to append data to JSON response

When building api you may come across occasion that you need to append data to difference json responses from multiple places. This pull request make that easier.
Let's say your application use JWT with short expiration. Every time user send a request to your application you process the request, create response, and attach new JWT to that response so the user won't have to login again too often.
Instead of attaching that JWT at the time you create the response, you can use after middleware to simplify your code. That middleware can be something like
class RenewJWT
{
    /**
     * Handle an incoming request.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \Closure  $next
     * @return mixed
     */
    public function handle($request, Closure $next)
    {
        $response = $next($request);

        $response->appendData(["jwt" => "New JWT!"]);

        return $response;
    }
}

This pull request create the appendData() method in Illuminate\Http\JsonResponse.

Typically, for scenarios that you're describing, I've seen other JWT libraries use the Authorization header to send updated JWTs back with the response. For instance, the tymon/jwy-auth RefreshToken middleware does this.

That's true, but this method is not specific to JWT. But, to be honest, I right now can't think of other scenario that this would be useful, either.

No plans to add this right now.


Review test_000049, test_000050, test_000052~test_000056

Hello ~
Issue 1： there are no demix mode parameters and recon gain parameters in bitstream, it seems that the encoder doesn't downmix channels follows https://aomediacodec.github.io/iamf/#iamfgeneration-scalablechannelaudio
Issue 2：L&R channels switch to SL&SR channels
for example: test_000049.textproto
audio_frame_metadata {
...
substream_id_ordering: [0, 1, 2, 3] # L/R, Ls/Rs, C, LFE
...
}
the channels order should be Ls/Rs, L/R, C, LFE,
please refer to the figure 21 in https://aomediacodec.github.io/iamf/#iamfgeneration-scalablechannelaudio-channelgroupgenerationrule

Issue 1: Section <IP_ADDRESS> seems to allow no demix mode parameters.
If demixing_info_parameter_data() is not delivered
* If the playback layout complies with loudspeaker layouts supported by [[ITU2051-3]](https://aomediacodec.github.io/iamf/#biblio-itu2051-3), use EAR Direct Speakers renderer ([[ITU2127-0]](https://aomediacodec.github.io/iamf/#biblio-itu2127-0)).
* Else if the playback layout is 3.1.2ch, use the static down-mix matrices specified in [§ 8.6.2 Static Down-mix Matrix](https://aomediacodec.github.io/iamf/#processing-downmixmatrix-static).
* Else, use implementation-specific renderer

My understanding is that the language for demixing parameters in section 9.2 should be informative as a way the stream could be encoded.

Issue 1: Section <IP_ADDRESS> seems to allow no demix mode parameters.
If demixing_info_parameter_data() is not delivered
* If the playback layout complies with loudspeaker layouts supported by [[ITU2051-3]](https://aomediacodec.github.io/iamf/#biblio-itu2051-3), use EAR Direct Speakers renderer ([[ITU2127-0]](https://aomediacodec.github.io/iamf/#biblio-itu2127-0)).
* Else if the playback layout is 3.1.2ch, use the static down-mix matrices specified in [§ 8.6.2 Static Down-mix Matrix](https://aomediacodec.github.io/iamf/#processing-downmixmatrix-static).
* Else, use implementation-specific renderer

My understanding is that the language for demixing parameters in section 9.2 should be informative as a way the stream could be encoded.

The demix mode parameter is used for reconstruction element stream， if the element only supports one channel layout, it doesn't need demix mode parameter, but if supports many channel layouts, i think it needs demix mode parameter which will be used to reconstruct element stream by loudspeaker layout. but it seems that the channels are not downmix in the scalable channel audio signal in test stream . it does not seem to follows 9.2. Scalable Channel Audio Encoding provides the Scalable Channel Audio encoding rules.
<IP_ADDRESS>. Rendering a channel-based audio element to loudspeakers describes rendering， not encoding and reconstruction.

Issue 1: I agree with @jingbo-marquis that it seems not to follow scalable channel encoding.
test_0000**_decoded_substream_0.wav should be Stereo L/R (L2/R2), not L / R channels of the input multi-channel audio.
Issue 2: I agree with @yeroro.

Issue 2: This is because of the scalable channel ordering, the first layer is Stereo, which already provides L/R. Then the second layer provides the rest, which are Ls/Rs, C, LFE.
Please refer to https://aomediacodec.github.io/iamf/#iamfgeneration-scalablechannelaudio-channelgroupgenerationrule and https://aomediacodec.github.io/iamf/#syntax-scalable-channel-layout-config on how scalable channel layout are organized.

The first layer is stereo, but it doesn't provide L/R of input multi-channels, it should be L2/R2 channels that mixed L/R and Ls/Rs, please refer to Figure 19, The second layer provides L/R, C, LFE, so i think the first layer provide Ls/Rs.

About Issue #2, I think we discussed in our F2F meeting with Samsung. @sunghee-hwang can you advise on whether @jingbo-marquis or I was right?

@jwcullen @yeroro @jingbo-marquis
Let me clarify this issues.
If 'num_layers > 1', Scalable channel audio encoding is required following according to 9.2. Scalable Channel Audio Encoding.
And, in this case, demixing_info_parameter_data() and recon_gain_info_parameter_data() may be present in the IA sequence. [IA Simple Profile] [IA Base Profile]
For non-scalable channel audio(num_layers = 1), demixing_info_parameter_data and recon_gain_info_parameter_data should not be present in the bitstream.
Please refer to 9.2. Scalable Channel Audio Encoding and 4. Profiles
Therefore, test_000049, test_000052~56 and etc should follow Scalable channel audio encoding.
Also, demixing_info_parameter_data() and recon_gain_info_parameter_data() shoud be present in the bitsteam.
As above, in the case of scalable channel audio encoding(num_layer > 1), substreams are composed of down-mixed audio channels. And ChannelGroup(CG)s are sets of the substreams.
Please refer to 9.2.2. Down-mix Mechanism and 9.2.3. Channel Layout Generation Rule
For example, in the case of test_000049, substreams and CGs should be set as below.
CG#0 - substream 0: L2/R2
CG#1 - substream 1: Ls5/Rs5
- substream 2: C
- substream 3: LFE
In the case of test_000050, substreams and CGs should be set as below.
CG#0 - substream 0: L2/R2
CG#1 - substream 1, 2, 3: Ltf3/Rtf3, C, LFE
CG#2 - substream 4, 5: Ls5/Rs5, Lss7/Rss7
CG#3 - substream 6: Ltf4, Rtf4
To make it clearer, the comments about substream channels in txtproto should be written as the channel names in Figure 19 IA Down-mix Mechanism like above.

About Issue #2, I think we discussed and agreed in our F2F meeting with Samsung. @sunghee-hwang can you advise on whether @jingbo-marquis or I was right?

@yeroro, it should be L2/R2. Jingbo is right.

@jwcullen @yeroro @jingbo-marquis Let me clarify this issues.
If 'num_layers > 1', Scalable channel audio encoding is required following according to 9.2. Scalable Channel Audio Encoding. And, in this case, demixing_info_parameter_data() and recon_gain_info_parameter_data() may be present in the IA sequence. [IA Simple Profile] [IA Base Profile]
For non-scalable channel audio(num_layers = 1), demixing_info_parameter_data and recon_gain_info_parameter_data should not be present in the bitstream.
Please refer to 9.2. Scalable Channel Audio Encoding and 4. Profiles
Therefore, test_000049, test_000052~56 and etc should follow Scalable channel audio encoding. Also, demixing_info_parameter_data() and recon_gain_info_parameter_data() shoud be present in the bitsteam.
As above, in the case of scalable channel audio encoding(num_layer > 1), substreams are composed of down-mixed audio channels. And ChannelGroup(CG)s are sets of the substreams. Please refer to 9.2.2. Down-mix Mechanism and 9.2.3. Channel Layout Generation Rule
For example, in the case of test_000049, substreams and CGs should be set as below. CG#0 - substream 0: L2/R2
CG#1 - substream 1: Ls5/Rs5 - substream 2: C - substream 3: LFE
In the case of test_000050, substreams and CGs should be set as below. CG#0 - substream 0: L2/R2 CG#1 - substream 1, 2, 3: Ltf3/Rtf3, C, LFE CG#2 - substream 4, 5: Ls5/Rs5, Lss7/Rss7 CG#3 - substream 6: Ltf4, Rtf4
To make it clearer, the comments about substream channels in txtproto should be written as the channel names in Figure 19 IA Down-mix Mechanism like above.

@kr728-kim
9.2.5. ChannelGroup Generation Rule
CG #i (as called DCG, i = 2, 3, …, n): This CG contains (Ci – Ci-1) number of channels. (Ci – Ci-1) channel(s) consists of as follows:
(Si – Si-1) surround channel(s) if Si > Si-1 . When S_set = { x | Si-1 < x ≤ Si and x is an integer},
If 2 is an element of S_set, the L2 channel is contained in this CG #i.
If 3 is an element of S_set, the Center channel is contained in this CG #i.
If 5 is an element of S_set, the L5 and R5 channels are contained in this CG #i.
If 7 is an element of S_set, the Lss7 and Rss7 channels are contained in this CG #i.
it should be L5/R5 instead of  Ls5/Rs5 in GC#i. L5/R5 are L/R in multi-channels.
test_000049
CG#0 - substream 0: L2/R2
CG#1 - substream 1: L5/R5 - substream 2: C - substream 3: LFE
test_000050
CG#0 - substream 0: L2/R2
CG#1 - substream 1, 2, 3: Ltf3/Rtf3, C, LFE
CG#2 - substream 4, 5: L5/R5, Lss7/Rss7
CG#3 - substream 6: Ltf4, Rtf4

@jingbo-marquis You're right. it should be L5/R5 instead of Ls5/Rs5.

As of AOMediaCodec/iamf#431 it is allowed to have them omitted to exercise default behavior. As of #40 these test vectors have been updated to utilize the default behavior and the ordering should now be accurate.
I'll close this issue in 1 week if there are no further complaints.


[decomp] yet even more res

Slowly gettigng there!

Pull Request Test Coverage Report for Build 913268982

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 69.506%

Totals

Change from base Build 912955451:
0.002%

Covered Lines:
36178

Relevant Lines:
52050

💛  - Coveralls


See if there is a way to improve performance

Possibilities

Write to an in-memory database, then attach the real one and copy the tables into it
Write data to a file in SQL format that is like what the SQLite CLI .dump creates, then import that
Use an INSERT statement with multiple VALUES clauses (like Python does)

In-memory database yields about a 30% improvement.  Not much, and I wonder if it is worth the memory usage.


Support for Protocol V65.

Current support is 64.
Relevant commit.
https://github.com/wolfpld/tracy/commit/41fc2930434bb2296cc8c255f82bcb731f8c0f06#diff-5879b3a569179bb49a8dc1064f461680a142313c3cc6358cbe9445d7f7b28605L9

This project closely follows upstream releases, and I don't see me making a change to said policy. You might have better success requesting upstream to make a release on their end.


Support per-component properties

This feature is needed before implementing loading/saving.

Closed as of b5ba83d4825d79cef05e00af521339f1c69a5a2d


LBRY 14.3 does not auto-upgrade on Ubuntu 16.04

The Issue
After following the instruction to upgrade, nothing happened, the version is still 14.2 and it keeps asking me every time to upgrade.
I then downloaded the 14.3 package from GitHub, and I installed it with apt-get, not with the gnome software centre (it does not work with that).
Steps to reproduce

Follow the link on the LBRY app first to dowload update, than to Upgrade
Nothing happens, until I manually close the LBRY window
Then, the gnome software centre starts, asking to install lbry 14.3
Nothing happens, except that gnome software centre restarts, asking to install 14.2
Click install, of course nothing happens, since 14.2 is already installed.
To successfully install 14.3, you need to use apt-get

Expected behaviour
I should click the upgrade botton in the application and it should work.
Actual behaviour
The window doesn't close automatically; after manually closing it, the gnome software centre does not install the new version correctly.
System Configuration

Not very relevant, I didn't take this details before being able to fix the issue myself; reported here are the details of the correctly manually upgraded LBRY.

LBRY Daemon version: 0.14.2
LBRY App version: 0.14.3
LBRY Installation ID: 5rHZHZt64BVaEs9b2yrya7aRNGo4G3vArDvjqJdGBfkq13ZkBYZZ5HnUSL2RC3o4cn
Operating system: Linux (Linux-4.4.0-89-generic-x86_64-with-Ubuntu-16.04-xenial)

Anything Else

Screenshots

I was able to confirm this.
Another way to upgrade is via the deb file/terminal:
dpkg -i /path/to/deb/file.deb

@tzarebczan can you try this again with the console open and see if the path to the deb is specified correctly?
The app calls xdg-open on this path to upgrade, so I suppose missing xdg-open could be the issue as well, but that should be on an Ubuntu install.

Actually, I think it is working correctly but the issue may lie in Ubuntu Software Center.  I've tried a couple VMs and I've had issues just installing the deb file through the software center.  While doing some research, I found this http://www.omgubuntu.co.uk/2016/04/ubuntu-16-04-deb-software-install-error and associated Bug reports - many users having the same issue installing 3rd party deb files. I think the issue was fixed at some time and was recently re-introduced.  On a clean Ubuntu 16.04 release it would not install and even after doing all the updates, it still would not. Same thing actually happens in 17.04 too.
I went back to an old VM I had previously installed LBRY on (maybe 2/3 months ago) where I knew the software center was operational.  I added the log statement and it looks like the installeprath is pointing the correct location and it opens the correct deb file in Software Center:
Checking for lbrynet daemon lbrynet daemon is already running Shutting down daemon Update downloaded to /tmp/fxiJP6/LBRY_0.14.3_amd64.deb The app will close, and you will be prompted to install the latest version of LBRY. After the install is complete, please reopen the app. Successfully stopped daemon via RPC call. Quitting. Launching upgrade installer at /tmp/fxiJP6/LBRY_0.14.3_amd64.deb
Software Center updates LBRY successfully after clicking install.
Best bet for those having trouble with the installer is to run the install using the terminal:
dpkg -i /path/to/deb/file.deb


DR8 MzLS failures that succeeded in DR6

An example is:
k4m_171124_041246_ooi_zd_v1.fits.fz
Which failed during DR8 zeropointing with the message:
AttributeError: 'NoneType' object has no attribute 'patch’
See also:
https://desi.lbl.gov/mailman/private/decam-chatter/2019-February/008474.html

The only other three examples that I found:
k4m_170127_091254_ooi_zd_v1.fits.fz
k4m_170426_050902_ooi_zd_v1.fits.fz
k4m_171008_093737_ooi_zd_v1.fits.fz

The listed files (and in fact all of the MOSAIC exposures) have completed the zero-point code for DR8 as of 9 April 2019.  Some of these cases may have been due to weird WCS in the image headers, see issue #41.  Closing this issue, should it re-surface we will track on the legacypipe product.


Add first-class support for SE(2) and SE(3) state spaces

We have SE(2) and SE(3) state spaces implemented in aikido::statespace, but they are not fully supported by the rest of Aikido (e.g. distance metrics, interpolation methods, DART conversions). We need to add this functionality to make them first-class citizens.
@aaronjoh, @lgw903, and I discussed this offline and concluded that it is not possible to represent SE(2) and SE(3) as CompoundStateSpaces of SO(2), SO(3), and a real vector space because the group operation differs. However, we may be able to gracefully handle both of these by implementing an AffineStateSpace or an semi-direct product space. We should investigate this idea further before proceeding with implementation.

TODOs

[ ] SE(2) distance metrics
[ ] SE(3) distance metrics
[ ] SE(2) interpolation methods
[ ] SE(3) interpolation methods
[ ] SE(2) DART conversions
[ ] SE(3) DART conversions

I've added unverified list of TODOs. :sweat_smile: Please feel free to update the list and let's track what needs to be done.

Archiving


Distance rate-Decimals are not supported for this currency yet entering dot is allowed

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.36-1
Reproducible in staging?: Y
Reproducible in production?: Y
Issue reported by: Applause Internal Team
Action Performed:

Go to https://staging.new.expensify.com/home
Go to profile icon --workspaces --workspace
Change workspace currency to ALL
Tap more features -- distance rate
Tap on rate
Enter decimal number with dot eg : 6.4
Tap save
Tap rate again

Expected Result:
Decimals are bit supported for this currency so user must not be allowed to enter dot.
Actual Result:
Decimals are not supported for this currency yet entering dot is displayed in distance rate page.
Workaround:
Unknown
Platforms:

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/77633941-6a95-4b64-8e52-d5d1b4db0737

View all open jobs on GitHub

@alexpensify  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal
Please re-state the problem that we are trying to solve in this issue.
Distance rate-Decimals are not supported for this currency yet entering dot is allowed
What is the root cause of that problem?
We are adding extra decimals prop here
https://github.com/Expensify/App/blob/2190f6279041ed8260752294d095bbdda76faebe/src/pages/workspace/distanceRates/CreateDistanceRatePage.tsx#L93
This causes allowing one decimal to any currency.
What changes do you think we should make in order to solve the problem?
We should remove that prop
What alternative solutions did you explore? (Optional)

@DylanDylann when you get a chance, can you review the proposals to address this Albanian currency issue? Thanks!

@daledah Interesting point. I will review this issue today

In the Submit Expense Page, we use the default number of decimal places for each currency (USD: 2, ALL: 0)

https://github.com/user-attachments/assets/083d78d1-35c3-43f8-b74b-520de39d17f9

In the Add distance rate, we have one more decimal compared to the default (USD: 3, ALL: 1)

I lean toward removing the extra decimal in the distance rate page as mentioned by @daledah
Anyway, I think we still need to confirm the expected first because the extra decimal is added a long time ago for the rate feature
🎀 👀 🎀 C+ reviewed

@Expensify/design @lakchote As the above comment, we have inconsistency in the number of decimals in the submit expense page and distance rate page. Is there any reason why we need to add one more extra decimal in the distance rate page? If not, should we remove extraDecimal to keep it consistent?

In the Submit Expense Page, we use the default number of decimal places for each currency (USD: 2, ALL: 0)

https://github.com/user-attachments/assets/083d78d1-35c3-43f8-b74b-520de39d17f9

In the Add distance rate, we have one more decimal compared to the default (USD: 3, ALL: 1)

I think that is on purpose, since a lot of government distance rates use three decimal places. cc @trjExpensify to fact check me there.

@shawnborton For the VND, ALL currency (there are no decimal in the submit expense page), Should we allow one decimal in the distance rate page?

@DylanDylann I have mentioned about removing that prop in my proposal. Any reason for selecting the other proposal

@BhuvaneshPatil Let's discuss the expectation first, I will come back to proposals later. Thanks

What do you mean by the VND?

Ah VND is a currency, ALL also be a currency

Hmm honestly I have no idea. I kind of think we can just always allow three decimal places no matter what the currency is to keep things simple? But would love someone more familiar with distance rates to fact check me, cc @twisterdotcom

@DylanDylann, are there more questions here, or are we good to move forward? Thanks!

### Proposal updated

added logic to have three decimals

I think we should just allow three everywhere. That's what we do on oldDot.

Distance rate decimals are to 4 aren't they, @twisterdotcom.

Waiting for @twisterdotcom to discuss more about the expect: https://github.com/Expensify/App/issues/49336#issuecomment-2368921168

Wow, I didn't even test adding another one. Okay, then sure, let's do 4 everywhere.

@daledah's proposal looks good to me
🎀 👀 🎀 C+ reviewed

Ahh, thanks for your reminder. I updated comment to explain my decision. Don't hesitate to tell me if you have any concern

Awesome, waiting for this one to go into Production.

Automation failed but this one went into production 2 days ago

Automation failed, I'll work on the payment process tomorrow.

Payouts due: 10-07-2024

[ ] Contributor: $250 @daledah
[ ] Contributor+: $250 @DylanDylann

Upwork job is here.

@daledah - I sent an offer via Upwork. Please accept, and then I can complete the payment process. Thanks!

All set here, I've completed the payment for @daledah!


(WIP) Upgrade webpack and other dependencies

Fixes #.
Electron Build
Changes proposed in this pull request:

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@binoy14 is electron building here yet? I might come by and check it out this weekend

@acao no, I couldn't get it to build. Help would be appreciated


Fix #26840 -- Move teardown_databases to django.test.utils.

Moved teardown_databases from a method on DiscoverRunner to a utility function. To be consistent with other testing utilities, this patch also moves setup_databases into django.test.utils..
This commit makes it easier to build custom test runners without having to rely on tricks with DiscoverRunner, i.e.:
https://github.com/pytest-dev/pytest-django/blob/def28820dd24283ee32650f2adb8ace21d05a0a1/pytest_django/fixtures.py#L58-L59

Looks good to me! Normally we require a Trac ticket to accompany a change of this size; I've created https://code.djangoproject.com/ticket/26840
Judging by past experience, @timgraham may have comments on this ;-) once you've passed his review, you'll want to squash this down to a single commit that observes our standard commit message format.

Thank you @carljm! 👍
I have squashed the commits and updated the commit message to include the ticket number.

Thanks for the review @timgraham.
I've addressed your comments and followed the deprecation guideline to the best of my knowledge. The commit is rebased and squashed to the latest master!

merged in e76981b43325da60b8a7475661df6cbfa7fda37e, thanks!

@timgraham Thanks for your patience and fixing up the last bits. 😃  👍


Problem with Dell Drivers

There seems to be a problem with downloading Dell Drivers at the moment.  I think this is to do with Dell changing their download location as per :
https://www.reddit.com/r/SCCM/comments/15ykm9e/help_with_modern_device_management/?rdt=62364
I have changed the links in the OEMLinks.xml to the following:

However, when I try to download Precision 5680 drivers, I receive the following error from the GUI.  Any ideas?

<Manufacturer Name="Dell" >
	<Link Type="DownloadList" URL="https://downloads.dell.com/published/Pages/index.html"></Link>
	<Link Type="DownloadBase" URL="https://downloads.dell.com"></Link>
	<Link Type="DriversList" URL="https://en.community.dell.com/techcenter/enterprise-client/w/wiki/2065.dell-command-deploy-driver-packs-for-enterprise-client-os-deployment"></Link>
	<Link Type="BaseURL" URL="https://en.community.dell.com"></Link>
	<Link Type="BIOSUtility" URL="https://downloads.dell.com/FOLDER08405216M/1/Ver3.3.16.zip"></Link>
	<Link Type="XMLCabinetSource" URL="https://downloads.dell.com/catalog/DriverPackCatalog.cab"></Link>
	<Link Type="CatalogSource" URL="https://downloads.dell.com/catalog/CatalogPC.cab"></Link>
</Manufacturer>

The op_Division error is related to Bits transfers being stuck in the queue.
Run PowerShell command Get-BitsTransfer to see any jobs and Remove-BitsTransfer to remove :
Get-BitsTransfer -AllUsers | Remove-BitsTransfer.


List Camel's endpoint in the integrations status

Requirement
List Camel's endpoint in the integrations status
Problem
The camel-k operator can project the status of the Camel context/routes/etc to the Integration' status by scraping the health endpoint so that tools can get the status of the routes without having to interact with the running process.
It would be nice to also have information about the endpoints registered with the Camel Context so as an example, advanced tools can draw a topology
Proposal
The Camel runtime could optionally expose some additional information, like those exposed by the camel-console  but in a production ready way (read only, minimal data).
This production ready console Could be integrated with Spring Boot actuators and Quarkus management interface.
The camel-k operator could then grab such data and project it to the integration status:
apiVersion: camel.apache.org/v2
kind: Integration
name: my-integration
spec:
  ...
status:
  endpoints:
    - url: "kafka:my-topic"
      parameters:
          broker: "my.kafka.broker.com"
    - url: "aws-s3:my-bucket"
      parameters:
          region: "eu"

Tools like HawtIO, OpenShift DevConsole could then be able to draw a topology of the existing integration and 3rd party systems.
Open questions
No response

@davsclaus ^^

@lburgazzoli I think this can intersect with the work I'm about to retake of https://github.com/apache/camel-k/pull/5096. Right now, using as an example reference the Quarkus runtime, the service is returning the following result:
			  {
			    "status": "DOWN",
			    "checks": [ {
			      "name": "camel-routes",
			      "status": "DOWN",
			      "data": {
			        "route.id": "route1",
			        "route.status": "Stopped",
			        "check.kind": "READINESS"
			      }
			    }]
			  }

Do you think can be this enough to start some development which may eventually be enhanced with any future work on Camel core?

I don't think this should be something to be included in the health endpoint but rather a dedicated endpoint

I don't think this should be something to be included in the health endpoint but rather a dedicated endpoint

Clear. What I mean is, while this is available on Camel core, should we start the development on the operator side? I guess that, when the new development is ready, then, we can easily change the endpoint to the new one. In the while, however, we'd be preparing all the required stuff on the operator side.

BTW, this I was meaning to include the info that are already on the health endpoint

I'd personally wait to see how/if things would be implemented in camel core

Relates to:

https://issues.apache.org/jira/browse/CAMEL-20798
https://issues.apache.org/jira/browse/CAMEL-18546


Make datasets-planned up to date

Replace:
https://waldronlab.github.io/curatedMetagenomicData/datasets-planned/
with what you are actually using for planning.

This now correctly links to a Google Spreadsheet.


Allow developers to browse source dependencies source code from Xcode IDE

For an external source dependency, Xcode can only autocomplete the symbols defined and exported through .swiftmodule file.
Expected Behavior
A developer should be able to jump to the source file defining a symbol from an external source dependency directly in Xcode

Isn't this basically the same as #130?

I added an end to the sentence: ...without the dependency been itself a Xcode projects.

Should also work for Visual Studio, updated the title to reflect this


Is it possible to keep the tooltip always visible?

probably duplicate of #88.

@whoisandy Hi, this feature is totally nice to have, or expose the current handle position could help.


Insufficient context information in PSI

The ktlint issue list contains a number of issues which can not be resolved as the PSI element do not contain enough context information which is required to resolve the issue.
When ktlint is linting and formatting a file, the files is being parsed with org.jetbrains.kotlin.com.intellij.psi.PsiFileFactory provided by the org.jetbrains.kotlin:kotlin-compiler-embeddable artifact. In this article it is explained that:

The PSI tree tells us how the code has been written by the end user, but not much else at this stage. This means that at this point, the compiler can only tell us how the code has been written, but it does not know if the code compiles or not.

Ktlint should not attempt to mimic the behavior of the compiler to obtain additional information which is not available in the PSI.
Issues which seem to be caused by this will be flagged with https://github.com/pinterest/ktlint/labels/insufficient-context-in-psi before being closed at a later moment.

The is a typo in the current link mentioned in the description. I think the intended link is https://medium.com/google-developer-experts/crash-course-on-the-kotlin-compiler-1-frontend-parsing-phase-9898490d922b

The is a typo in the current link mentioned in the description. I think the intended link is https://medium.com/google-developer-experts/crash-course-on-the-kotlin-compiler-1-frontend-parsing-phase-9898490d922b

Tnx, I have fixed the link.


Windows issue: Compilation as part of another program. Gflags stops it.

Trying to Compile a prog called Carabiner that can be found here:
https://github.com/brunchboy/carabiner
I get this basically:
Windows PowerShell
Copyright (C) Microsoft Corporation. All rights reserved.

PS C:\WINDOWS\system32> cd C:\Repo\carabiner\build
PS C:\Repo\carabiner\build> cmake -G "MSYS Makefiles" ..
-- The C compiler identification is GNU 6.3.0
-- The CXX compiler identification is GNU 6.3.0
-- Check for working C compiler: C:/MinGW/bin/gcc.exe
-- Check for working C compiler: C:/MinGW/bin/gcc.exe -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: C:/MinGW/bin/g++.exe
-- Check for working CXX compiler: C:/MinGW/bin/g++.exe -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for C++ include unistd.h
-- Looking for C++ include unistd.h - found
-- Looking for C++ include stdint.h
-- Looking for C++ include stdint.h - found
-- Looking for C++ include inttypes.h
-- Looking for C++ include inttypes.h - found
-- Looking for C++ include sys/types.h
-- Looking for C++ include sys/types.h - found
-- Looking for C++ include sys/stat.h
-- Looking for C++ include sys/stat.h - found
-- Looking for C++ include fnmatch.h
-- Looking for C++ include fnmatch.h - found
-- Looking for C++ include stddef.h
-- Looking for C++ include stddef.h - found
-- Check size of uint32_t
-- Check size of uint32_t - done
-- Looking for strtoll
-- Looking for strtoll - found
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - not found
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE
-- Check size of pthread_rwlock_t
-- Check size of pthread_rwlock_t - failed
-- Configuring done
-- Generating done
-- Build files have been written to: C:/Repo/carabiner/build
PS C:\Repo\carabiner\build> cmake --build .
Scanning dependencies of target gflags_nothreads_static
[  7%] Building CXX object gflags/CMakeFiles/gflags_nothreads_static.dir/src/gflags.cc.obj
In file included from C:/Repo/carabiner/build/gflags/include/gflags/config.h:115:0,
                 from c:/Repo/carabiner/gflags/src/gflags.cc:90:
C:/Repo/carabiner/gflags/src/windows_port.h: In function 'void setenv(const char*, const char*, int)':
C:/Repo/carabiner/gflags/src/windows_port.h:80:13: error: ambiguating new declaration of 'void setenv(const char*, const char*, int)'
 inline void setenv(const char* name, const char* value, int) {
             ^~~~~~
In file included from c:\mingw\lib\gcc\mingw32\6.3.0\include\c++\cstdlib:75:0,
                 from c:\mingw\lib\gcc\mingw32\6.3.0\include\c++\stdlib.h:36,
                 from C:/Repo/carabiner/gflags/src/windows_port.h:56,
                 from C:/Repo/carabiner/build/gflags/include/gflags/config.h:115,
                 from c:/Repo/carabiner/gflags/src/gflags.cc:90:
c:\mingw\include\stdlib.h:837:30: note: old declaration 'int setenv(const char*, const char*, int)'
 __cdecl __MINGW_NOTHROW  int setenv( const char *__n, const char *__v, int __f )
                              ^~~~~~
make[2]: *** [gflags/CMakeFiles/gflags_nothreads_static.dir/src/gflags.cc.obj] Error 1
make[1]: *** [gflags/CMakeFiles/gflags_nothreads_static.dir/all] Error 2
make: *** [all] Error 2
PS C:\Repo\carabiner\build>

It seems essentially the same prob as the issue below with the setenv() thing but it doesn't fix it if i copy paste what you said in that posts replies.
I'm using Powershell or Git Bash or Cmake GUI to the same effect. I have MinGW as the Compiler.
Thanks for your help in advance.
Robbie

If I copy and paste the files from the latest 2.2.1 stable release .zip I get 12% not 7% but it ignores pthreads in the files list which I presume is not helpful maybe? any way it looks like this for comparison with above:
PS C:\Repo\carabiner\build> cmake -G "MSYS Makefiles" ..
-- The C compiler identification is GNU 6.3.0
-- The CXX compiler identification is GNU 6.3.0
-- Check for working C compiler: C:/MinGW/bin/gcc.exe
-- Check for working C compiler: C:/MinGW/bin/gcc.exe -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: C:/MinGW/bin/g++.exe
-- Check for working CXX compiler: C:/MinGW/bin/g++.exe -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for C++ include unistd.h
-- Looking for C++ include unistd.h - found
-- Looking for C++ include stdint.h
-- Looking for C++ include stdint.h - found
-- Looking for C++ include inttypes.h
-- Looking for C++ include inttypes.h - found
-- Looking for C++ include sys/types.h
-- Looking for C++ include sys/types.h - found
-- Looking for C++ include sys/stat.h
-- Looking for C++ include sys/stat.h - found
-- Looking for C++ include fnmatch.h
-- Looking for C++ include fnmatch.h - found
-- Looking for C++ include stddef.h
-- Looking for C++ include stddef.h - found
-- Check size of uint32_t
-- Check size of uint32_t - done
-- Looking for strtoll
-- Looking for strtoll - found
-- Configuring done
-- Generating done
-- Build files have been written to: C:/Repo/carabiner/build
PS C:\Repo\carabiner\build> cmake --build .
Scanning dependencies of target gflags_nothreads_static
[ 12%] Building CXX object gflags/CMakeFiles/gflags_nothreads_static.dir/src/gflags.cc.obj
In file included from C:/Repo/carabiner/build/gflags/include/gflags/config.h:110:0,
                 from c:/Repo/carabiner/gflags/src/gflags.cc:90:
C:/Repo/carabiner/gflags/src/windows_port.h: In function 'void setenv(const char*, const char*, int)':
C:/Repo/carabiner/gflags/src/windows_port.h:80:13: error: ambiguating new declaration of 'void setenv(const char*, const char*, int)'
 inline void setenv(const char* name, const char* value, int) {
             ^~~~~~
In file included from c:\mingw\lib\gcc\mingw32\6.3.0\include\c++\cstdlib:75:0,
                 from c:\mingw\lib\gcc\mingw32\6.3.0\include\c++\stdlib.h:36,
                 from C:/Repo/carabiner/gflags/src/windows_port.h:56,
                 from C:/Repo/carabiner/build/gflags/include/gflags/config.h:110,
                 from c:/Repo/carabiner/gflags/src/gflags.cc:90:
c:\mingw\include\stdlib.h:837:30: note: old declaration 'int setenv(const char*, const char*, int)'
 __cdecl __MINGW_NOTHROW  int setenv( const char *__n, const char *__v, int __f )
                              ^~~~~~
make[2]: *** [gflags/CMakeFiles/gflags_nothreads_static.dir/src/gflags.cc.obj] Error 1
make[1]: *** [gflags/CMakeFiles/gflags_nothreads_static.dir/all] Error 2
make: *** [all] Error 2

Thanks again

Can you post the relevant code snippets from c:\mingw\lib\gcc\mingw32\6.3.0\include\c++\stdlib.h:36?
I'd consider this a duplicate of #228, though.


Unable to run R scripts

Hi everyone! I am trying to build a data pipeline using R in mage but while executing the code "FileNotFoundError: [Errno 2] No such file or directory: '/tmp/84842c48-c953-4155-9ae6-14447e19467e.r'" I am getting this error, I am just trying to use same code which was available in documentation "https://docs.mage.ai/guides/blocks/r-blocks" If anyone can help me on this it would be a great help thanks in advance. It's working in live but I am facing this issue in my system

Hi Zishan! Are you still facing this issue?

I have installed mage in my local windows and I have tried to build a sample pipeline through it,I was using the same sample codes which given in the documentation of mage ai however all the Python codes were working fine locally but when I tried to create a pipeline using R code its reflecting errors
https://github.com/mage-ai/mage-ai/assets/123532227/dfe2ad03-556a-4912-9638-f5c66c1fa4f7

Hi @Zishan-IA , the R block only works in docker right now.

do I need to install docker or what?? how do I resolve this @wangxiaoyou1993  any suggestion?

@Zishan-IA follow this doc to run Mage in docker: https://docs.mage.ai/getting-started/setup#get-mage

Thanks @wangxiaoyou1993


Priorities + plan

On Sunday I am starting work with the Waorani to enter their mapping information into this editor. Here are the priorities, in order, for getting things done by then.
Top Priority

[ ] Fix segfault on sync #18 - essential, right now I can't synchronize / replicate at all.
[ ] Import shp file #15 we don't necessarily need a UI, we just need to get one shapefile (a river dataset) into the database as a starting point.
[ ] Point localhost/tiles to folder in UserData and read imagery.json from there too #8. We can manually manage these without a UI for now.
[ ] Fix packaging, merge #13. In master we still see strange rendering funkiness which is fixed in packaged branch.
[ ] Get at least a folder picker dialog #6.

I'll deal with #7
Next week

[ ] Let's get a packaging script that creates a single installer.
[ ] Have a way to import a tar.gz of map tiles and modify imagery.json automatically #8

Later
https://github.com/digidem/ecuador-map-editor/milestones/later

[x] import shp file

You can do this by sending a PUT request directly to /import.shp:
$ curl -T 50m_physical.zip http://localhost:5000/import.shp

[x] folder picker dialog


Retry the database connection a few times before giving up

Currently the database storage drivers fail fast on connection errors. If the error is network related, we should retry the connection a few times (with backoff) before giving up.
https://github.com/cenkalti/backoff is a good candidate here because we use it elsewhere too.

Fixed by #1405


fix(goreleaser): use --clean instead of --rm-dist

Fixes the broken release CI (https://github.com/YaleUniversity/packer-plugin-goss/actions/runs/9383198273/job/25836269474) by removing the deprecated arg --rm-dist

@F21 can you review and approve?

I've reviewed and approved, but I don't have write access to the repo.

lmao, okay lets go


[Task]: Clean up Typescript Tests workflow

What needs to happen?
.github/workflows/typescript_tests.yml contains an Authenticate on GCP step that uses google-github-actions/auth@v1. Said step provides Google Cloud authentication using an outdated static credential pattern and can be removed. Notably the xlang and Dataflow tests have been broken for months. Removing the step could fix the Dataflow tests, though not the xlang Tests. See https://github.com/apache/beam/issues/33346 for a bug report about the xlang Tests.
Issue Priority
Priority: 2 (default / most normal work should be filed as P2)

https://github.com/apache/beam/pull/33354


task.json -> options.env not working of ${env:VAR} expansion

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.82.2 (abd2f3db4bdb28f9e95536dfa84d8479f1eb312d) arm64
OS Version: macOS 13.0 (darwin 22.1.0)

Steps to Reproduce:

use a task of type shell, say "echo ${env:HELLO}"
specify env variable HELLO in options.env

Update: options.env works as env normally, except for ${env:*} expansion.
p.s. I presume %VAR% works in Windows, and $var not — in posix os — for these are wrapped in single quotes.
{
  "type": "shell",
  "label": "test",
  "group": "build",
  "dependsOn": ["another"],
  "options": {
    "env": {
      "HELLO": "vscode!",
    }
  },
  "command": "echo",
  "args": [
    "Hi, \"${env:HELLO}\"",
  ]
}

Env var replacement works with existing env_vars like ${env:HOME}.
### Tasks

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.82.2. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

I think that this probably has never worked.


fix: missed design specifications

:tada: This PR is included in version 4.0.0-alpha.9 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-alpha.67 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0-alpha.6 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 4.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update and rename Get-SPOTenantRenameStatus to Get-SPOTenantRenameSta…

Renaming the file to include .md and some minor corrections.
Note that this the documentation of the new PowerShell cmdlets to support SPO Tenant Renames.
Please include this PR with the other files:

Start-SPOTenantRename.md
Stop-SPOTenantRename.md

Docs Build status updates of commit 5de9826:
:warning: Validation status: warnings

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Get-SPOTenantRenameStatus.md
:warning:Warning
View (sharepoint-ps)
Details

sharepoint/sharepoint-ps/sharepoint-online/Get-SPOTenantRenameStatus.md

Line 0, Column 0: [Warning-file-not-found] Invalid file link: 'Start-SPOTenantRename.md'.
Line 0, Column 0: [Warning-file-not-found] Invalid file link: 'Stop-SPOTenantRename.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


nixos/scrutiny: fix timer not auto-starting

Description of changes
The collector service timer was missing wantedBy = ["timers.target"]; and therefore didn't autostart.
To simplify the config a bit and prevent the footgun, use startAt on the service instead.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg test scrutiny


Missing from Component Store

This Component seems to be missing from the store. Any reason why?

@OpticNectar  For now i'm stop supporting this component.


cache.writeFragment and commutative updates

After upgrading from graphcache 2.2.2 problems with writeFragment and commutative updates started appearing again.
The behaviour is exactly the same as https://github.com/FormidableLabs/urql/issues/574 but not so often.
I think it has something to do with the change on 2.2.3 to include subscription also
What the component does is at a click of a button a mutation is executed and two responses arrive

One from the mutation result which updates an entity using writeFragment
And another from a subscription which also  updates another entity using writeFragment

Some background

It was working fine with 2.2.2
I tried all versions after 2.2.2

All changes now take precedence over subscriptions, which is our intended way of tackling commutativity; our assumption is that it’s unnecessary to handle subscriptions (or rather to deliver events to a client) where a mutation has made the modification.
So as long as both updates result in the same cache changes, you should be fine.
I’d be interested though in the exact case you’re running into so we can reevaluate our assumptions 👍

No its not the same changes.subscription updates one entity mutation result
updates another entity
On Tue, 17 Mar 2020, 23:09 Phil Plückthun<EMAIL_ADDRESS>wrote:

All changes now take precedence over subscriptions, which is our intended
way of tackling commutativity; our assumption is that it’s unnecessary to
handle subscriptions (or rather to deliver events to a client) where a
mutation has made the modification.
So as long as both updates result in the same cache changes, you should be
fine.
I’d be interested though in the exact case you’re running into so we can
reevaluate our assumptions 👍
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/FormidableLabs/urql/issues/633#issuecomment-600302577,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAV3YMI2TGDGG2PFTB7PGLRH7RILANCNFSM4LNYGR6A
.

Ok, we may need some details here, I just double checked your description and you do indeed say "updates an entity" and "updates another entity", so we may need some usage details, because I don't think we made any changes that would impact two completely unrelated entities to not update when they're created / written to at the same time.

Also it does not skip the update and then everything is fine
It acts exactly like the previous issue.No subsequent updates (mutation or
not) can update that entity again
On Tue, 17 Mar 2020, 23:28 Dimitris Zenios<EMAIL_ADDRESS>wrote:

No its not the same changes.subscription updates one entity mutation
result updates another entity
On Tue, 17 Mar 2020, 23:09 Phil Plückthun<EMAIL_ADDRESS>wrote:

All changes now take precedence over subscriptions, which is our intended
way of tackling commutativity; our assumption is that it’s unnecessary to
handle subscriptions (or rather to deliver events to a client) where a
mutation has made the modification.
So as long as both updates result in the same cache changes, you should
be fine.
I’d be interested though in the exact case you’re running into so we can
reevaluate our assumptions 👍
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/FormidableLabs/urql/issues/633#issuecomment-600302577,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAV3YMI2TGDGG2PFTB7PGLRH7RILANCNFSM4LNYGR6A
.

So a minor reproduction would be useful, but I don't believe it's the same issue as we're testing for that now.
Anyway, we had a hunch that it may be related to garbage collection. Could it be that you're writing to a fragment that is "dangling", meaning that there's no path from Query to the fragment inbetween your results?

If it was than then i assume it would happen every time.
It happens at a rate of 1 per 10

I have a reproduction
https://codesandbox.io/s/confident-surf-qu4nb
Instructions :)

Open the same sandbox in two tabs
On the first tab select from 0 to 1
On the second tab select from 1 to 0
Press send button of the first tab You will see both users 0 balance and users 1 balance to be updated. You will also see the sbuscription data arriving. Changes will be reflected on both tabs
Press send button on the second tab. Changes are only applied on the second tab even though the subscription data arrived on the first tab also

No its not the same changes.subscription updates one entity mutation result updates another entity
…
On Tue, 17 Mar 2020, 23:09 Phil Plückthun, @.***> wrote: All changes now take precedence over subscriptions, which is our intended way of tackling commutativity; our assumption is that it’s unnecessary to handle subscriptions (or rather to deliver events to a client) where a mutation has made the modification. So as long as both updates result in the same cache changes, you should be fine. I’d be interested though in the exact case you’re running into so we can reevaluate our assumptions  — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#633 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAV3YMI2TGDGG2PFTB7PGLRH7RILANCNFSM4LNYGR6A .

FYI It turns out that mutation updates both entities.
One that will also be updated from the subscription and the other which will be updated only through the mutation
So just to be clear
On the click of a button a mutation happens

Subscription arrives that will updateFragment of Entity A
Mutation result arrives that will updateFragment of Entity A and Entity B
updateFragment of both subscription and mutation for Entity A will contain the same data.

Hey,
I've been investigating your issue and there seems to be an issue in your application logic, both balances change but only one is sent back to the other tab.
However when this is the result of my operation on tab 1:
mutation {__typename: "User", id: "1", balance: 1}
mutation {__typename: "User", id: "0", balance: 0}

Then I see this subscription result on my second tab:
subscription {__typename: "User", id: "0", balance: -1}

Yes but it does not update the value of the balance when doing a
writeFragment
On Wed, 18 Mar 2020, 17:27 Jovi De Croock<EMAIL_ADDRESS>wrote:

Hey,
I've been investigating your issue and there seems to be an issue in your
application logic, both balances change but only one is sent back to the
other tab.
However when this is the result of my operation on tab 1:
mutation {__typename: "User", id: "1", balance: 1}
mutation {__typename: "User", id: "0", balance: 0}
Then I see this subscription result on my second tab:
subscription {__typename: "User", id: "0", balance: -1}
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/FormidableLabs/urql/issues/633#issuecomment-600688439,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAV3YPBBIE222B62JIXD33RIDR7ZANCNFSM4LNYGR6A
.

Once you click send on the first tab you will see vales updating in both
tabs
After than when you click send on the second tab you will see values
updating only on the second tab.the value arrives on the forst tab since
you can see it in the subscription result but the update fragment performed
does not update the entity
On Wed, 18 Mar 2020, 17:28 Dimitris Zenios<EMAIL_ADDRESS>wrote:

Yes but it does not update the value of the balance when doing a
writeFragment
On Wed, 18 Mar 2020, 17:27 Jovi De Croock<EMAIL_ADDRESS>wrote:

Hey,
I've been investigating your issue and there seems to be an issue in your
application logic, both balances change but only one is sent back to the
other tab.
However when this is the result of my operation on tab 1:
mutation {__typename: "User", id: "1", balance: 1}
mutation {__typename: "User", id: "0", balance: 0}
Then I see this subscription result on my second tab:
subscription {__typename: "User", id: "0", balance: -1}
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/FormidableLabs/urql/issues/633#issuecomment-600688439,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAV3YPBBIE222B62JIXD33RIDR7ZANCNFSM4LNYGR6A
.

We've got an idea what's going on and are actively working on a fix. Seems to be a problem with timing when results come in repeatedly, especially for subscriptions, which also get their state erased in some cases.

repeatedly you mean one mutation and one subcription like in the sandbox?

@zenios There's more details here: https://github.com/FormidableLabs/urql/pull/638/commits/cb0e557238ef2ef13dc5e1272cf8aecb615d4076
So it's hard to describe and figure out which edge-case the sandbox hits exactly... But we're trying to write some test cases. We're hitting impossible conditions here due to some small flaws in the order of layer calls, so it's hard to say which edge case (that were all supposed to not happen) you're hitting.
@JoviDeCroock has copied over your sandbox to the CodeSandbox packaged sandbox with the fixes from #638: https://codesandbox.io/s/recursing-pine-pvysc
And it seems to not suffer from these bugs anymore (?)

@zenios we’ve added some more tests and I’m quite sure we’ve fixed the issue(s). Sorry for making your life a little harder! I hope we won’t encounter more of these bugs.
But on the flip side, they really pave the way for eventually adding offline support! Thanks for having an eye on the library and testing out new versions! ♥🙌

No worries and thanks for your support. Urql is becoming the defacto graphql library
Will wait for the next release in order to test it and let you know.
Thanks again


fix: Non-space character in blockquote

@nschonni : Thanks for your contribution! The author, @Deland-Han, has been notified to review your proposed change.

We're reviewing this pull request.

Verified the updates; merging.


Keyword Tracking Intervals?

Is it possible to set custom interval scan times? If not, perhaps it can be added as a feature. Rather than it scanning my keywords every single day and using up my serp credits.
Like an option in the settings to select between daily, weekly, monthly auto scans.

@daninelson Will try to add this feature in next release. Thanks for the suggestion. It has been asked a few times.


Container name is not in the correct format.

Hi all,
I faced the issue with next error message:

Traceback (most recent call last):
File "delete.py", line 299, in
run()
File "delete.py", line 281, in run
recovery_backup_client)
File "delete.py", line 207, in delete_cmk_tenant_recovery_vault
protected_item_name=protected_item.name
File "/usr/local/lib/python2.7/dist-packages/azure/mgmt/recoveryservicesbackup/operations/protected_items_operations.py", line 259, in delete
raise exp
msrestazure.azure_exceptions.CloudError: Azure Error: BMSUserErrorContainerNameIncorrectFormat
Message: Container name is not in the correct format.

I cannot understand what name it requires from me.
By this link https://docs.microsoft.com/en-us/python/api/azure-mgmt-recoveryservicesbackup/azure.mgmt.recoveryservicesbackup.operations.protecteditemsoperations?view=azure-python#delete I found documentation information and wrote script for backup protected item deletion.
protected_items = recovery_backup_client.backup_protected_items.list(recovery_vault_name, group_name)
for protected_item in protected_items:
        logging.info("Deleting protected item: {}".format(protected_item.properties.friendly_name))
        recovery_backup_client.protected_items.delete(
            vault_name=recovery_vault_name,
            resource_group_name=group_name,
            fabric_name="Azure",
            container_name=protected_item.properties.friendly_name(also tried protected_item.properties.container_name/protected_item.name),
            protected_item_name=protected_item.name
)

@DheerendraRathor , can you help me, please?

Guys, please, give attention to this issue. I still can't resolve it.

@emelyanovVlad Sorry for missing documentation there. container_name will be f"iaasvmcontainer;{protected_item.properties.container_name}".

@DheerendraRathor it seems like it works. Thank you for your help
Also, I see that delete is asynchronous operation. What is the best way to wait operation's end? After which I will delete recovery-vault

Hi @emelyanovVlad, you can find the long running operation documentation here:
https://docs.microsoft.com/en-us/python/api/msrestazure/msrestazure.azure_operation.azureoperationpoller?view=azure-python
When waiting for an operation to complete you can call either:

poller.result(timeout=None) if you are expecting an Azure resource to be returned from the operation.
poller.wait(timeout=None) to wait until completion with no return value (e.g. for delete)

Where poller is the object returned by the operation, e.g.:
poller = recovery_backup_client.protected_items.delete(...)
Both are blocking calls with an optional timeout value.
Hope this helps!

Basically, my main goal is to delete recovery vault with all the data inside. Maybe there is some way to delete it with few operations?
Currently I'm trying to delete it with:
recovery_client.vaults.delete(group_name, recovery_vault_name)
but it throws and exception

msrestazure.azure_exceptions.CloudError: Azure Error: ServiceResourceNotEmptyWithContainerDetails
Message:  Vault cannot be deleted as there are existing resources within the vault. Please ensure there are no backup items, protected servers or backup management servers associated with this vault. Unregister the following containers associated with this vault before proceeding for deletion : recovery-vault-name
Unregister all containers from the vault and then retry to delete vault

@annatisch I tried your approach but my recovery_backup_client.protected_items.delete operation returns None. If I'm adding raw=True to delete operation it returns [ClientRawResponse](https://docs.microsoft.com/en-us/python/api/msrest/msrest.pipeline.clientrawresponse?view=azure-python) where output is None and response is  <Response [204]>
There is no operation Id or smth else which I can use in for getting ResultStatus :/

Thanks @emelyanovVlad - in that case the delete operation is not considered a long running operation.
This is potentially an error in the API specification if the operation does not in fact complete during the initial request.
Is this the operation you're calling?
https://github.com/Azure/azure-sdk-for-python/blob/master/azure-mgmt-recoveryservicesbackup/azure/mgmt/recoveryservicesbackup/operations/protected_items_operations.py#L194
@DheerendraRathor - could you comment on the service behavior here?

@annatisch yes this one but I found it in MS documentation here https://docs.microsoft.com/en-us/python/api/azure-mgmt-recoveryservicesbackup/azure.mgmt.recoveryservicesbackup.operations.protecteditemsoperations?view=azure-python#delete

Delete is long running operation. Currently we don't have support of long running operations in SDKs. It will be coming in upcoming releases.
For now operation id can be fetched from header Azure-AsyncOperation and then backup_operation_status.get can be used to get status.
Sample implementation:
https://github.com/Azure/azure-sdk-for-python/blob/master/azure-mgmt-recoveryservicesbackup/tests/recoveryservicesbackup_testcase.py#L226
https://github.com/Azure/azure-sdk-for-python/blob/master/azure-mgmt-recoveryservicesbackup/tests/recoveryservicesbackup_testcase.py#L352

@DheerendraRathor is there some easier way to delete recovery vault with backup items inside?

@DheerendraRathor I will try provided examples in a few hours. My delete request still returns 204 error :/

@emelyanovVlad All backed-up items must be manually deleted before vault deletion. That's by design and no shortcut is provided so that protected data is not lost when vault is deleted by mistake.
Also can you provide value of header "x-ms-client-request-id" for deletion calls where you're getting 204. I will analyze it from service side. You can get header value either by dumping headers (using raw response) or by using some middle layer tool like fiddler.

@DheerendraRathor and @annatisch thank you very much for your help. Today I found that I missed with container name. I was passing f"iaasvmcontainer;{protected_item.properties.friendly_name}" instead of f"iaasvmcontainer;{protected_item.properties.container_name}"
My issue is resolved. I really appreciate your help! <3


Templating for report graph

In mythril/analysis/callgraph.py:252 it states that you would be interested in using a templating system. I would be interested in quickly converting it to use jinja. Would that be an acceptable dependency to add to the program in your view?

For sure! I don't see a reason not to add it.

Great! I'm about halfway through an initial implementation. I've been seeing some issues with rendering the final graph that I will open if I can reproduce them.

Cool! Don't forget to include some awesome default templates :)