reasonable defaults for layouts?

Just a short list I'm keeping for reasonable defaults for different UI components.

[ ] UI::Button default height?
[ ] UI::Button default background and foreground color?
[ ] UI::View default flex/flow direction?
[ ] default fade in, fade out animations. Maybe this list?: https://daneden.github.io/animate.css/

My idea was to provide a default template implementing material design.

Only bring this up because I got tripped on on UI::Button on :tap wire up. I spun my wheels for a little bit because the tap event wasn't firing. It was because the UI::Button didn't have a height.

concerning this specific case we should make sure the button has at least the size of its intrinsic size (text, image)

Should work with this commit on iOS : https://github.com/HipByte/Flow/commit/79749c71b793f9014e3978741b498c7511920234


feat: don't emit SIGNED_IN events on visibility change

Each time a tab became visible, the SIGNED_IN event was emitted. Although this is normal, it's unnecessary overhead. In some implementations, it could result in unnecessary requests or UI re-renders.
Fixes #579

It would be fantastic to see this PR merged soon. I'm encountering the same issue in a React application. In React, it's a common practice to store the session object in the component state. Because of that, each time a SIGNED_IN event fires and updates the session, it triggers a re-render of the entire application, impacting performance.
As a workaround, I'm currently comparing the token field of the incoming and existing session objects before updating the state. While this approach mitigates the issue, it feels more like a patch than a proper solution. Addressing this behavior directly within the Supabase library would be a much cleaner and more efficient way to handle it.

Quick check: is this PR still relevant?


New parse tree

[x] New parse tree with better context support (#17 )
[x] Code cleanup/refactoring
[x] Data command

[x] data.<plugin-name>.<data-name> form
[x] highlight json

[x] Ctrl+C -cancelable context passed everywhere
[x] Removed potential data conflict warning from anonymous data refs; now only show warning when actual data confilct happens (one data ref value is overwritten by another)
[x] Use plugin.MapData instead of map[string]any in more places to prevent translating back and fourth between the types

Ready for review & merge!

looks good!


Any way to get the rotated file name?

Is there any way to get the rotated file name?

I've try to get the file name with time.Now().Format("2006-01-02T15-04:05.000")
But there seems to be some slight difference.


unable to install uvloop in windows (dependency)

Getting this error
pip install sglang[all]
Requirement already satisfied: sglang[all] in c:\users\keshav s\anaconda3\envs\llm-workspace\lib\site-packages (0.1.11)
Requirement already satisfied: requests in c:\users\keshav s\anaconda3\envs\llm-workspace\lib\site-packages (from sglang[all]) (2.31.0)
Requirement already satisfied: charset-normalizer<4,>=2 in c:\users\keshav s\anaconda3\envs\llm-workspace\lib\site-packages (from requests->sglang[all]) (3.3.2)
Requirement already satisfied: idna<4,>=2.5 in c:\users\keshav s\anaconda3\envs\llm-workspace\lib\site-packages (from requests->sglang[all]) (3.6)
Requirement already satisfied: urllib3<3,>=1.21.1 in c:\users\keshav s\anaconda3\envs\llm-workspace\lib\site-packages (from requests->sglang[all]) (2.1.0)
Requirement already satisfied: certifi>=2017.4.17 in c:\users\keshav s\anaconda3\envs\llm-workspace\lib\site-packages (from requests->sglang[all]) (2023.11.17)
Collecting anthropic (from sglang[all])
Using cached anthropic-0.15.0-py3-none-any.whl.metadata (15 kB)
Requirement already satisfied: numpy in c:\users\keshav s\anaconda3\envs\llm-workspace\lib\site-packages (from sglang[all]) (1.24.4)
Requirement already satisfied: openai>=1.0 in c:\users\keshav s\anaconda3\envs\llm-workspace\lib\site-packages (from sglang[all]) (1.6.1)
Requirement already satisfied: aiohttp in c:\users\keshav s\anaconda3\envs\llm-workspace\lib\site-packages (from sglang[all]) (3.9.1)
Requirement already satisfied: fastapi in c:\users\keshav s\anaconda3\envs\llm-workspace\lib\site-packages (from sglang[all]) (0.109.2)
Requirement already satisfied: psutil in c:\users\keshav s\anaconda3\envs\llm-workspace\lib\site-packages (from sglang[all]) (5.9.7)
Collecting rpyc (from sglang[all])
Using cached rpyc-5.3.1-py3-none-any.whl (74 kB)
Requirement already satisfied: torch in c:\users\keshav s\anaconda3\envs\llm-workspace\lib\site-packages (from sglang[all]) (2.1.2)
Collecting uvloop (from sglang[all])
Using cached uvloop-0.19.0.tar.gz (2.3 MB)
Installing build dependencies ... done
Getting requirements to build wheel ... error
error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> [15 lines of output]
Traceback (most recent call last):
File "C:\Users\Keshav S\anaconda3\envs\llm-workspace\lib\site-packages\pip_vendor\pyproject_hooks_in_process_in_process.py", line 353, in
main()
File "C:\Users\Keshav S\anaconda3\envs\llm-workspace\lib\site-packages\pip_vendor\pyproject_hooks_in_process_in_process.py", line 335, in main
json_out['return_val'] = hook(**hook_input['kwargs'])
File "C:\Users\Keshav S\anaconda3\envs\llm-workspace\lib\site-packages\pip_vendor\pyproject_hooks_in_process_in_process.py", line 118, in get_requires_for_build_wheel
return hook(config_settings)
File "C:\Users\Keshav S\AppData\Local\Temp\pip-build-env-xnl04q07\overlay\Lib\site-packages\setuptools\build_meta.py", line 325, in get_requires_for_build_wheel
return self._get_build_requires(config_settings, requirements=['wheel'])
File "C:\Users\Keshav S\AppData\Local\Temp\pip-build-env-xnl04q07\overlay\Lib\site-packages\setuptools\build_meta.py", line 295, in _get_build_requires
self.run_setup()
File "C:\Users\Keshav S\AppData\Local\Temp\pip-build-env-xnl04q07\overlay\Lib\site-packages\setuptools\build_meta.py", line 311, in run_setup
exec(code, locals())
File "", line 8, in
RuntimeError: uvloop does not support Windows at the moment
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> See above for output.
note: This error originates from a subprocess, and is likely not a problem with pip.

its clear enough. you cant use sglang on windows. Use WSL 2 instead

same here.... SGLang installation drop me today this line
RuntimeError: uvloop does not support Windows at the moment


Add SetState API Command.

Needed to create/set a state from a c# Project. Now, this is working for me :)

this... is a pull request, isnt it?

Oh, sorry @weltmeyer I actually thought I commented directly on the commit in your branch (here], I didn't realize it was already part of a PR!


nothing works

hi there, after running the script, i receive these notices:

Notice: Undefined index: X-Ratelimit-Remaining in C:\xampp\htdocs\sandbox\Instagram-PHP-API-master\Instagram.php on line 633

Notice: Undefined index: code in C:\xampp\htdocs\sandbox\Instagram-PHP-API-master\example.php on line 16

Notice: Undefined property: stdClass::$access_token in C:\xampp\htdocs\sandbox\Instagram-PHP-API-master\Instagram.php on line 737

Notice: Undefined property: stdClass::$user in C:\xampp\htdocs\sandbox\Instagram-PHP-API-master\example.php on line 19

Notice: Trying to get property of non-object in C:\xampp\htdocs\sandbox\Instagram-PHP-API-master\example.php on line 19
Your username is:

settings are:

require 'Instagram.php';

use MetzWeb\Instagram\Instagram;

$instagram = new Instagram(array(
    'apiKey'      => 'xxx',
    'apiSecret'   => 'xxx',
    'apiCallback' => 'http://localhost/sandbox/Instagram-PHP-API-master/callback.php'
));

$result = $instagram->getPopularMedia();

// grab OAuth callback code
$code = $_GET['code'];

///testing
$data = $instagram->getOAuthToken($code);
$instagram->setAccessToken($data);
echo 'Your username is: ' . $data->user->username;

Please see #182

hmm, i have changed it from false to true, and still the same?
Does it mean that instagram php api doesnt work anymore?

Please note that this library doesn't yet support their new updates.


Upserting a row with UUID as ID results in an error

First of all let me just say THANK YOU to everyone's involved in this project.
I extremely appreciate all of your work.

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
I use UUIDs (Google's package) as primary keys, for example:
func (Test) Fields() []ent.Field {
	return []ent.Field{
		field.UUID(`id`, uuid.UUID{}).Unique(),
		field.Int8(`count`).Min(0),
	}
}

If I insert new rows, everything works as expected without errors:
err = r.client.Test.
	Create().
	SetID(id).
	SetCount(1).
	Exec(r.context)

But, if I try to upsert rows, even new ones:
err = r.client.Test.
	Create().
	SetID(id).
	SetCount(currentCount + 1).
	OnConflictColumns(test.FieldID).
	UpdateCount().
	Exec(r.context)

I get the following error: interface conversion: driver.Value is string, not uuid.UUID
Expected Behavior 🤔
I expect a new row to be updated if the ID exists or inserted if the ID does not exist, without any error.
Steps to Reproduce 🕹
I think the above code should suffice to reproduce the issue.
Some Notes
I tracked the issue to a method called sqlSave in the generated file test_create.go, to the following lines:
if _spec.ID.Value != nil {
	_node.ID = _spec.ID.Value.(uuid.UUID)
}

I believe the issue is related to the combination of Ent's upsert and Google's UUID Value method.
When just inserting a new row (without OnConflictColumns) the type definition _spec.ID.Type is field.TypeUUID, or [16]byte as you defined it, and the actual type of _spec.ID.Value is uuid.UUID.
But when upserting a row, while the type definition _spec.ID.Type remains the same field.TypeUUID/[16]byte, the actual type of _spec.ID.Value is string.
It looks like the function sqlgraph.CreateNode is doing something to _spec, because before it is called, _spec.ID.Value's type is uuid.UUID, and after it's run the type changes to string.
Your Environment 🌎

Tech
Version

Go
1.17.1

Ent
0.9.1

Database
PostgreSQL

Driver
github.com/jackc/pgx/v4/stdlib

I hope I've been as helpful as possible, let me know if there's anything else I can do.

Thanks for reporting this @726b. I'll give it a look and update you.

Thanks again for reporting this. A patch was created to address this issue (see https://github.com/ent/ent/pull/1987) and should be land tomorrow.

Thank you @a8m for this package, again I extremely appreciate you and everyone else's work here.

Closed with https://github.com/ent/ent/pull/1987
Please update to the latest master version as follows:
go get entgo.io/ent@master

@a8m
I'm using ent v0.10.1, but it seems like this issue still remain when I use custom IDs as ID.
To give an example, I use ULIDs as primary keys.
func (Test) Fields() []ent.Field {
	return []ent.Field{
		field.String("id").
			GoType(ulid.ID("")).
			DefaultFunc(func() ulid.ID { return ulid.New() }),
	}
}

if I try to upsert rows,
err := client.Test.Create().OnConflict(sql.ResolveWithNewValues()).Exec(ctx);

I get the following error: unexpected Test.ID type: string


Cancelling inputlist() should always return 0

User's input should be discarded if the inputlist() call is cancelled, otherwise there is no way to discern if the input was confirmed or cancelled.

Should I be concerned about the failing build?
All the others builds succeeding leads me to believe it's a random failure.


Updated v2.1.10 release notes to include notes from backported commits

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/a662291a96839a4b5b1061c40bdf80f7c0f424e8/
Edited pages:

releases/v2.1.10.md


Fix #351

A fix for #351.  This is a different script from the same thread the original script is from that removes everything from the start menu.
I used it on my own machine and it worked.

Which thread is that?

Just found: https://superuser.com/questions/1068382/how-to-remove-all-the-tiles-in-the-windows-10-start-menu

This Thread
The link to this answer is also in my commit on the first line

Thanks so much.

I just tested here and it works well. However, I think it should also be updated in the GUI version, or maybe the others scripts as well.

I assumed that the GUI called the scripts. Thank you for pointing it out and I'll look into it more

Tested on a windows VM. Both scripts worked

Will check this later today. Thank you.
Sent from my iPhone

On Feb 11, 2021, at 3:33 AM, David<EMAIL_ADDRESS>wrote:

Tested on a windows VM. Both scripts worked
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


[EVOLUTION] - Store auth information on CrudRequest object

Hi.
First of all : thinks you for your fork ! ;-)

Subject :

CrudRequest object is pass between Controller and Service. But on this object we dont store any context informations as authenticate user for exemple : (this is nice to have auth user object on service (stored on native Request object))

Do you think it's possible to store extra informations on CrudRequest object and in particular auth. user?

Note :

Store native NestJs Request object is not possible : risk of producing strange case with singleton service (switch to Scope=Request by nestJs), but store auth user information seen to be possible.
Auth user can be found on native Request object with nesths-crud configuration auth. sample configuration ;

CrudConfigService.load({
      params: {
       [...]
      },
      auth: {
        property: 'user',
      },
[...]

* CurdRequest interface can became :

export interface CrudRequest {
    parsed: ParsedRequestParams;
    options: CrudRequestOptions;
    auth: any; // according to configuration
    extra: any; // any params for business logic
}

What is the use case for that?
Isn't it enough getting the user from the request object?

Sorry i think my issue is not very clear, i think there is 2 linkeds subjects :

Subject 1. Nestjs-crud ask to Map "auth.property". it's pity to dont use this informations for hydrate auth informations on CrudRequest.

Exemple of use case :
check some additional sécurité rules of AuthGuard directory on services.
add author informations on log on services
use this object to add some custom business rules (it's my principal let's motivation, i often add some business instructions on CrudRequest.option according to user'auth informations, as role for exemple)
Prevent/simplify nestjs pattern that remove singleton pattern on service

This feature give a usefulll "helper" for développer.

Subject 2 (linked with subject 1) : If i dont do a mistake all attributs on CrudRequest object is interpreted by nestjs-crud. That feature can be obvious if we need to pass some custom/business param for exemple (throw exception because this custom param is not know on entity ..). Exemple of use case (stupide case 😁 there is a lot of use case more interresting ) :

If i want to get my entity A and add some custom attribut on entity for count the number of relationship B, it's usefulll to add "extra.b.count" on request and do my custom request directly on service.

This feature give more flexibility on request process.

@zaro I created a decorator that may be of help if you are using passport-jwt (it certainly stores the current logged user within the http context when tokens are verified):
CurrentUser decorator
/* eslint-disable @typescript-eslint/no-explicit-any */
import { createParamDecorator, ExecutionContext } from '@nestjs/common'

import { User } from '@your-namespace/data'

export const getCurrentUser = (request: any): User | undefined => request.user || undefined

export const CurrentUser = createParamDecorator((_: unknown, context: ExecutionContext) =>
    getCurrentUser(context.switchToHttp().getRequest()),
)

Usage Example
// imports here...
@UseInterceptors(AuthorizeCrudInterceptor)
@Controller('payment-methods')
export class PaymentMethodController implements CrudController<PaymentMethod> {
  constructor(
    public service: PaymentMethodService,
    @InjectRepository(PaymentMethod) private repo: Repository<PaymentMethod>
  ) {
  }
  // ...
  @Override()
  async createOne(@CurrentUser() user: User, @Param() dto: CreatePaymentMethodDto): Promise<PaymentMethod> {
    return this.service.create(user, dto);
  }
  // ...
}

Hi, the PR is here for your code review https://github.com/gid-oss/dataui-nestjs-crud/pull/13
thx.


Fix typos in simple_rnn

I observed a  few typos in simple_rnn

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.59%. Comparing base (90d36dc) to head (6413b21).

:exclamation:  There is a different number of reports uploaded between BASE (90d36dc) and HEAD (6413b21). Click for more details.
HEAD has 6 uploads less than BASE

Flag
BASE (90d36dc)
HEAD (6413b21)

keras
4
1

keras-torch
1
0

keras-tensorflow
1
0

keras-jax
1
0

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #20636       +/-   ##
===========================================
- Coverage   82.55%   60.59%   -21.96%
===========================================
  Files         518      518
  Lines       48682    48682
  Branches     7592     7592
===========================================
- Hits        40188    29500    -10688
- Misses       6669    17403    +10734
+ Partials     1825     1779       -46

Flag
Coverage Δ

keras
60.59% <ø> (-21.80%)
:arrow_down:

keras-jax
?

keras-numpy
60.59% <ø> (+<0.01%)
:arrow_up:

keras-tensorflow
?

keras-torch
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Automated PR from brain-bican/models. models_py-autogen/new_model_2.py have been modified.

This was a PR generated while testing new push_to_bkbit workflow in brain-bican/models repo. This PR does not need to be merged.


Vercel onboarding not working

If I want to specify the commit and branch property on my <Monitoring /> component from react-scan/monitoring/next like it is done in the onboarding process I get this type error:
ts: Type '{ apiKey: string; url: string; commit: string | undefined; branch: string | undefined; }' is not assignable to type 'IntrinsicAttributes & { url?: string | undefined; apiKey: string; }'.
  Property 'commit' does not exist on type 'IntrinsicAttributes & { url?: string | undefined; apiKey: string; }'.

Code:
        <Monitoring
          apiKey=""
          url="https://monitoring.react-scan.com/api/v1/ingest"
          commit={process.env.NEXT_PUBLIC_VERCEL_GIT_COMMIT_SHA}
          branch={process.env.NEXT_PUBLIC_VERCEL_GIT_COMMIT_REF}
        />

Btw. I love react-scan ❤

@FleetAdmiralJakob please do not expose your API Key! even is a fake one. Please edit your description as soon as possible!
Thanks in advance :)

Did so. I was confused because the onboarding didn't suggest to put the API key in a env, probably because it's sent to the client anyway.


Failed to build chamferdist

Hello all,
Great work, and thank you for providing the source code publically.
I need help with building chamferdist. My system configuration is Ubuntu 22.04, Python = 3.10.13, Pytorch version is 2.1.0+cu121.
NVIDIA Driver version 525.125 and Cuda version 12.0.
The error is as follows.
Processing /home/gaurav/Desktop/ConceptGraphs/concept-graphs/conceptgraph/chamferdist
Preparing metadata (setup.py) ... done
Building wheels for collected packages: chamferdist
Building wheel for chamferdist (setup.py) ... error
error: subprocess-exited-with-error
× python setup.py bdist_wheel did not run successfully.
│ exit code: 1
╰─> [49 lines of output]
running bdist_wheel
running build
running build_py
running build_ext
Traceback (most recent call last):
File "", line 2, in
File "", line 34, in
File "/home/gaurav/Desktop/ConceptGraphs/concept-graphs/conceptgraph/chamferdist/setup.py", line 76, in
setup(
File "/home/gaurav/conda/envs/conceptgraph/lib/python3.10/site-packages/setuptools/init.py", line 103, in setup
return distutils.core.setup(**attrs)
File "/home/gaurav/conda/envs/conceptgraph/lib/python3.10/site-packages/setuptools/_distutils/core.py", line 185, in setup
return run_commands(dist)
File "/home/gaurav/conda/envs/conceptgraph/lib/python3.10/site-packages/setuptools/_distutils/core.py", line 201, in run_commands
dist.run_commands()
File "/home/gaurav/conda/envs/conceptgraph/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 969, in run_commands
self.run_command(cmd)
File "/home/gaurav/conda/envs/conceptgraph/lib/python3.10/site-packages/setuptools/dist.py", line 989, in run_command
super().run_command(command)
File "/home/gaurav/conda/envs/conceptgraph/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 988, in run_command
cmd_obj.run()
File "/home/gaurav/conda/envs/conceptgraph/lib/python3.10/site-packages/wheel/bdist_wheel.py", line 325, in run
self.run_command("build")
File "/home/gaurav/conda/envs/conceptgraph/lib/python3.10/site-packages/setuptools/_distutils/cmd.py", line 318, in run_command
self.distribution.run_command(command)
File "/home/gaurav/conda/envs/conceptgraph/lib/python3.10/site-packages/setuptools/dist.py", line 989, in run_command
super().run_command(command)
File "/home/gaurav/conda/envs/conceptgraph/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 988, in run_command
cmd_obj.run()
File "/home/gaurav/conda/envs/conceptgraph/lib/python3.10/site-packages/setuptools/_distutils/command/build.py", line 131, in run
self.run_command(cmd_name)
File "/home/gaurav/conda/envs/conceptgraph/lib/python3.10/site-packages/setuptools/_distutils/cmd.py", line 318, in run_command
self.distribution.run_command(command)
File "/home/gaurav/conda/envs/conceptgraph/lib/python3.10/site-packages/setuptools/dist.py", line 989, in run_command
super().run_command(command)
File "/home/gaurav/conda/envs/conceptgraph/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 988, in run_command
cmd_obj.run()
File "/home/gaurav/conda/envs/conceptgraph/lib/python3.10/site-packages/setuptools/command/build_ext.py", line 88, in run
_build_ext.run(self)
File "/home/gaurav/conda/envs/conceptgraph/lib/python3.10/site-packages/setuptools/_distutils/command/build_ext.py", line 345, in run
self.build_extensions()
File "/home/gaurav/conda/envs/conceptgraph/lib/python3.10/site-packages/torch/utils/cpp_extension.py", line 525, in build_extensions
_check_cuda_version(compiler_name, compiler_version)
File "/home/gaurav/conda/envs/conceptgraph/lib/python3.10/site-packages/torch/utils/cpp_extension.py", line 413, in _check_cuda_version
raise RuntimeError(CUDA_MISMATCH_MESSAGE.format(cuda_str_version, torch.version.cuda))
RuntimeError:
The detected CUDA version (11.7) mismatches the version that was used to compile
PyTorch (12.1). Please make sure to use the same CUDA versions.
  [end of output]

note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed building wheel for chamferdist
Running setup.py clean for chamferdist
Failed to build chamferdist
ERROR: Could not build wheels for chamferdist, which is required to install pyproject.toml-based projects

I am also getting the error when I am running the command.
python scripts/run_slam_rgb.py
--dataset_root /home/gaurav/Desktop/ConceptGraphs/concept-graphs/Datasets/Replica
--dataset_config /home/gaurav/Desktop/ConceptGraphs/concept-graphs/conceptgraph/dataset/dataconfigs/replica/replica.yaml
--scene_id room0
--image_height 480
--image_width 640
--stride 5
--visualize
The error is as follows.
[2023-10-08 04:49:34,322] [INFO] [real_accelerator.py:110:get_accelerator] Setting ds_accelerator to cuda (auto detect)
Traceback (most recent call last):
File "/home/gaurav/Desktop/ConceptGraphs/concept-graphs/conceptgraph/scripts/run_slam_rgb.py", line 12, in
from conceptgraph.dataset.datasets_common import get_dataset
File "/home/gaurav/Desktop/ConceptGraphs/concept-graphs/conceptgraph/dataset/datasets_common.py", line 26, in
from gradslam.datasets import datautils
File "/home/gaurav/Desktop/ConceptGraphs/concept-graphs/conceptgraph/gradslam/init.py", line 8, in
from . import odometry
File "/home/gaurav/Desktop/ConceptGraphs/concept-graphs/conceptgraph/gradslam/odometry/init.py", line 1, in
from .gradicp import *
File "/home/gaurav/Desktop/ConceptGraphs/concept-graphs/conceptgraph/gradslam/odometry/gradicp.py", line 7, in
from .icputils import point_to_plane_gradICP
File "/home/gaurav/Desktop/ConceptGraphs/concept-graphs/conceptgraph/gradslam/odometry/icputils.py", line 3, in
from chamferdist.chamfer import knn_points
File "/home/gaurav/Desktop/ConceptGraphs/concept-graphs/conceptgraph/chamferdist/init.py", line 1, in
from .chamfer import ChamferDistance
File "/home/gaurav/Desktop/ConceptGraphs/concept-graphs/conceptgraph/chamferdist/chamfer.py", line 12, in
from chamferdist import _C
ImportError: cannot import name '_C' from partially initialized module 'chamferdist' (most likely due to a circular import) (/home/gaurav/Desktop/ConceptGraphs/concept-graphs/conceptgraph/chamferdist/init.py)
Thank you

Hi @gauraviiita,
You should technically be able to run the entire package without needing the chamferdist package.
From your error message, I deduce you are trying to build the main branch of gradslam and not the conceptfusion branch? I just looked up the readme and there seems to be a typo on our end. Could you try running this instead?
git clone https://github.com/gradslam/gradslam.git
cd gradslam
git checkout conceptfusion
pip install -e .

It'd be great to know if this fix works (if it does, we will update the README)

Thank you for the quick reply. I am going to follow the instructions you gave and let you know soon.

Hello @krrish94
I followed the instructions given by I installed grandslam in the concept-graphs folder and then successfully checked it to conceptfusion branch.
After that, I run the command. As given below
python scripts/run_slam_rgb.py
--dataset_root /home/gaurav/Desktop/Robotics/concept-graphs/Datasets/Replica
--dataset_config /home/gaurav/Desktop/Robotics/concept-graphs/conceptgraph/dataset/dataconfigs/replica/replica.yaml
--scene_id room0
--image_height 480
--image_width 640
--stride 5
--visualize
And I am getting a similar error as earlier. Please let me know the next step to remove this error.
Also, I installed all the models GSAM, grandslam and LLaVa in the concept-graphs folder.
[2023-10-08 00:54:55,284] [INFO] [real_accelerator.py:110:get_accelerator] Setting ds_accelerator to cuda (auto detect)
Traceback (most recent call last):
File "/home/gaurav/Desktop/Robotics/concept-graphs/conceptgraph/scripts/run_slam_rgb.py", line 13, in
from dataset.datasets_common import get_dataset
File "/home/gaurav/Desktop/Robotics/concept-graphs/conceptgraph/dataset/datasets_common.py", line 26, in
from gradslam.datasets import datautils
File "/home/gaurav/Desktop/Robotics/concept-graphs/conceptgraph/gradslam/init.py", line 8, in
from . import odometry
File "/home/gaurav/Desktop/Robotics/concept-graphs/conceptgraph/gradslam/odometry/init.py", line 1, in
from .gradicp import *
File "/home/gaurav/Desktop/Robotics/concept-graphs/conceptgraph/gradslam/odometry/gradicp.py", line 7, in
from .icputils import point_to_plane_gradICP
File "/home/gaurav/Desktop/Robotics/concept-graphs/conceptgraph/gradslam/odometry/icputils.py", line 3, in
from chamferdist.chamfer import knn_points
File "/home/gaurav/conda/envs/conceptgraph/lib/python3.10/site-packages/chamferdist/init.py", line 1, in
from .chamfer import ChamferDistance
File "/home/gaurav/conda/envs/conceptgraph/lib/python3.10/site-packages/chamferdist/chamfer.py", line 12, in
from chamferdist import _C
ImportError: /home/gaurav/conda/envs/conceptgraph/lib/python3.10/site-packages/chamferdist/_C.cpython-310-x86_64-linux-gnu.so: undefined symbol: _ZN3c106detail14torchCheckFailEPKcS2_jRKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE

Hi @gauraviiita Have you tried building chamferdist package again? Did it build successfully?

Also, I would recommend installing gradslam in a different directory altogether, to mirror how things are setup on our internal tests

I tried the following commands on my machine and it builds successfully.
conda create -n cg-test
conda activate cg-test
conda install python=3.10
cd ..
cd chamferdist/
conda install pytorch torchvision torchaudio pytorch-cuda=12.1 -c pytorch -c nvidia
pip install .

@krrish94
Yes, I installed grandslam in a different directory, and now it is working.
python scripts/run_slam_rgb.py
--dataset_root /home/gaurav/Desktop/Robotics/concept-graphs/Datasets/Replica
--dataset_config /home/gaurav/Desktop/Robotics/concept-graphs/conceptgraph/dataset/dataconfigs/replica/replica.yaml
--scene_id room0
--image_height 480
--image_width 640
--stride 5
--visualize
I have successfully run this command.
Thank you very much.

Additionally, while building chamferdist,
git clone https://github.com/krrish94/chamferdist.git
cd chamferdist
pip install .

this error may occur: "#error C++17 or later compatible compiler is required to use PyTorch."
It can be solved by updating line 18 in chamferdist/setup.py
#extra_compile_args = {"cxx": ["-std=c++14"]}  # old
extra_compile_args = {"cxx": ["-std=c++17"]}  # new

Reference: https://github.com/open-mmlab/mmdeploy/issues/2529


Started making the code more maintainable

I ported over all Misskey API related code to it's own small wrapper to get things cleaner, as for the configurations I replaced all if statements with fallback values. I added some small comments when some optimizations could be used.
Furthermore, I also reformatted some of the code.
Likewise, the code needs to be split into more functions.
This is a WIP but is mergeable already

Hey and thank you very much! 😄
Do you want to continue working on this project? If so, I'll archive this repository and link to yours in the README.
Maintaining this isn't really an option for me since I don't know anything about python, I just fixed some stuff in the upstream code using trial and error 🥴
If you don't plan to work on this in the future I can merge your PR but I don't really want to continue working on this long-term. 🙂

Hiii :3, I don't know if I'll want to continue working on it either, for nyow it's like a side-hustle, but I tend to lose interest pretty fast. It would be cool if I could at least finish what I started and optimize it, it's really slow right meow~

Alright - don’t really have time to test it right now but looks good


pyinfra: 2.6 -> 2.6.1

Description of changes
Update pyinfra from version 2.6 to 2.6.1
Release notes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 208757 run on x86_64-linux 1

2 packages built:

pyinfra (python310Packages.pyinfra)
python39Packages.pyinfra


Update popup.css to add auto light/dark mode

Added auto light/dark mode
this is experimental, definitely confirm if it meets your design philosophy and standards locally before merging

Thanks.


Provide Introduction

Write a short introductory chapter.
Started on this, almost done.

Can you also link to the license? (`/license.html I guess). Also see https://github.com/delftswa/delftswa.github.io/pull/17

Fixed by #19 ?


Modified CMakeLists to add flags and fixed code flagging warnings.

Hopefully fixes #302
For all of the exercise CMakeLists.txt I've added /W4 (Level 4 warnings) and /WX (Warnings as errors). I've also gone through and fixed code which currently fails due to this addition. I've tested these changes in both VS2019 and VS2022 toolsets.
Note: currently don't have a working gcc/clang setup so will await CI to check the changes.
As per the thread, I didn't add /Wall as I believe this is somewhat heavy-handed for what is the desired outcome. I was toying with suggesting /permissive- however I kept strictly to the main point of the issue.
Warning Levels: https://docs.microsoft.com/en-us/cpp/build/reference/compiler-option-warning-level?view=msvc-160
WX Flag: https://docs.microsoft.com/en-us/cpp/build/reference/wx-treat-linker-warnings-as-errors?view=msvc-160

Thanks!
The CI failure is not related to this change, and is because we are using an old version of Ubuntu in our CI that is temporarily disabled in Github actions. I will rerun the CI in a few hours and most likely merge it in then. I expect the CI will pass when it actually runs.

From a human perspective: Is it really necessary to write static_cast<bool>(isalpha(...)) instead of isalpha(...)?
Personally I would hate that in my code because IMHO it just makes the code tedious to write and harder to read.

From a human perspective: Is it really necessary to write static_cast<bool>(isalpha(...)) instead of isalpha(...)?
Personally I would hate that in my code because IMHO it just makes the code tedious to write and harder to read.

I somewhat agree however as per cppref it would appear that this should probably be further modified to include not only the return type being static_cast<char> but also the input static_cast<unsigned char> (similar for all cctype functions - cctype is included via the string header). The first example in the notes section is a pretty good example of the use.

this should probably be further modified to include [...] input static_cast<unsigned char>

I agree completely, that's one of my pet peeves.

cctype is included via the string header

I don't think that's required by the standard.

Just to quickly clarify - there's nothing outstanding on this PR from my point of view?

Closing, this PR could well be out of date by now, I haven't checked.


Reorganize the README. Move personal access tokens (PATs) to the "Advanced Configuration Options" section.

We should not be recommended the use of personal access tokens (PATs) as a first resort.
The fact that PATs have access to all of your repos is a huge security problem.
SSH deploy keys are far more secure and should be the go-to option.
Really, the only reason anyone should use PATs for TagBot is if they absolutely need to use the pre-release hook functionality.
So this PR:

Moves the PAT stuff to the bottom of the README
Makes it clear that SSH deploy keys are the best option
Explain that if you really do need to use PATs, you should create a bot user account, not your main user account.

This is ready for review.
cc: @christopher-dG

Rebased and squashed.

I've also removed some superfluous text.

@christopher-dG What do you think?

@christopher-dG Any idea why tests are failing all of a sudden?

A flake8 release added a new lint rule, it would appear. Fixed + rebased.

@DilumAluthge good to go?

@christopher-dG Looks good to me. Take one last look, and then merge when you're ready.


Update CONTRIBUTING.md

Stop making suggestions that are unrelated to my pr, just open a new pr and do your edits


Update how we run tests for dev/ui/appservice packages

The VS Code team split the package vscode into @types/vscode and vscode-test. I based the new testing structure off of their latest hello-world extension samples. This is primarily to help reduce security vulnerabilities (still workin on that).

This is primarily to help reduce security vulnerabilities (still workin on that).

How is this related to security vulnerabilities?

The old vscode package (that I got rid of in favor of @types/vscode and vscode-test) had some dependencies of dependencies that were showing up in npm audit

Maybe it would be more accurate to say "Security vulnerabilities is what inspired me to do this" because obviously there are other benefits in terms of staying up to date with VS Code testing packages

The old vscode package (that I got rid of in favor of @types/vscode and vscode-test) had some dependencies of dependencies that were showing up in npm audit

Ah, thanks.


Added the customization for favicons

Customization for the favicons
Now we can customize the favicons of the website

Default is oscar/favicon.ico
Need to add OSCAR_FAVICON = path to the favicon in the settings.py

@ramanaditya thanks for this. I'm not convinced however that this is much easier than just overriding the block favicon in the template though - could you explain why you feel that is not sufficient?
The other point in this context is that .ico images are not really considered the best practice any more for HTML5 - we should instead be encouraging use of PNGs etc defined in multiple sizes. I would be more inclined to go that way than to further entrench the favicon.ico.

Also there is already a default favicon in the repository - we don't need another one for the sandbox.

@solarissmoke
Since we tend to use one favicon for the entire website. I thought of putting it in the settings and not uselessly override the existing block.
Yes, to support png or other types, we can add a type in the existing code. I mean I will have to update this PR.
The reason I made the changes in the sandbox folder is, I wanted to let people know. We can do this in this way as sandbox is the implementation of the app. Probably the better option would be to update the docs.
Once you find it relevant I will make the change in the docs as well.

I'm still not convinced by the use case here. There are two situations I can see:

You want a custom favicon in the same format that Oscar uses. In this case all you have to do is specify your own static asset for oscar/favicon.ico and this will be collected by collectstatic rather than the default. I still don't see why a setting is necessary to control the path specifically.

You want to completely replace the block and insert say a series of icons of different sizes - in that can you just override the template block which is already very easy to do.

I agree with @solarissmoke - template customization should do it.

In that case, we can close this issue.


Remove mac/ios agents and remove flaky flag from mac/ios on LUCI.

Mac/ios LUCI test beds and tests are now stable. We are removing the flaky flag to make them block the tree on failures and we are also removing the mac/ios agent configurations.
Bug: https://github.com/flutter/flutter/issues/73392
Pre-launch Checklist

[X] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[X] I read the Tree Hygiene wiki page, which explains my responsibilities.
[X] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[X] I signed the CLA.
[X] I listed at least one issue that this PR fixes in the description above.
[X] I updated/added relevant documentation (doc comments with ///).
[X] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
[X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Does any of this need to be investigated?  It's not inspiring confidence...

Does any of this need to be investigated? It's not inspiring confidence...

Yes, we need to validate why those entries do not exist in the data models.

Does any of this need to be investigated? It's not inspiring confidence...

Yes, we need to validate why those entries do not exist in the data models.

This is the bug tracking the problem with the metrics.

Landing for a subset of tests.


Fix Mako lexer's expressions spanning multiple lines

(Original issue 274 created by None on 2007-08-02T01:34:46+00:00)
This is the exact same issue fixed in Myghty's lexer earlier this year:
http://trac.pocoo.org/changeset/2657
An example of the problem:
http://pylonshq.com/pasties/384
Reported by guest

(Original issue was assigned to gbrandl)
(Original issue 274 last updated on 2007-08-07T09:45:46+00:00)
(Issue automaticaly closed due to status in Bitbucket: resolved)

(Original comment by gbrandl on 2007-08-07T09:45:46+00:00)
Fixed in r3839.


Could not load file or assembly 'mscorlib' on macOS

I'm setting up CI to ensure my assembly-based module (PsHosts) runs on Linux and macOS. The process builds on Appveyor/Windows since I'm targetting .NET 4.0 (for compat back to PS3) - the TravisCI builds then install the module from a MyGet feed and run the pester tests.
The Appveyor and Travis Linux builds are both fine, but on Travis macOS calling any of the Cmdlets inside the assembly throw an error:

Could not load file or assembly 'mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089'. Could not find or load a specific file. (Exception from HRESULT: 0x80131621)

Is this a known issue on macOS? Should I just hold off testing on macOS until a particular release/milestone?
I'm using PowerShell's install-powershell.sh to bootstrap PS in the Travis builds.
Links to build logs if you're interested:

Windows
Linux
macOS

I downloaded the v1.2.1 from https://github.com/richardszalay/pshosts/releases, and it works fine on my MacBook with beta.5:
PS:3> Import-Module /Users/usr/Downloads/PsHosts
PS:4> gmo

ModuleType Version    Name                                ExportedCommands
---------- -------    ----                                ----------------
Manifest   <IP_ADDRESS>    Microsoft.PowerShell.Management     {Add-Content, Clear-Content, Clear-Item, Clear-ItemProperty...}
Manifest   <IP_ADDRESS>    Microsoft.PowerShell.Utility        {Add-Member, Add-Type, Clear-Variable, Compare-Object...}
Binary     1.2.1      PsHosts                             {Add-HostEntry, Disable-HostEntry, Enable-HostEntry, Get-Host...
Script     1.2        PSReadLine                          {Get-PSReadlineKeyHandler, Get-PSReadlineOption, Remove-PSRea...

PS:5> $result = Add-HostEntry -Name "hostname" -Address "<IP_ADDRESS>"
PS:6> $result

Name                             Address                          Enabled
----                             -------                          -------
hostname                         <IP_ADDRESS>                      True

PS:7> Get-HostEntry

Name                             Address                          Enabled
----                             -------                          -------
broadcasthost                    <IP_ADDRESS>                  True
hostname                         <IP_ADDRESS>                      True

PS:8> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      6.0.0-beta
PSEdition                      Core
GitCommitId                    v6.0.0-beta.5
OS                             Darwin 16.0.0 Darwin Kernel Version 16.0.0: Mon Aug 29 17:56:20 PDT 2016; root:xnu-3789....
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

/cc @TravisEz13 maybe something with the install-powershell.sh script and the environment setup?

I created a clean macOS VM and installed PowerShell using install-powershell.sh and it also worked.

Strange. I'll try to follow it up with the Travis CI guys, but failing that I'll just have to list macOS as unsupported.

I went to try to run your CI to see if I can repro the problem but I cannot.  You don't seem to build your module in your CI (see Practices of CI).  You just get the module from a gallery here:
https://github.com/richardszalay/pshosts/blob/master/build/travis.ps1#L1
and the location isn't declared in the travis.yml
Perhaps there is a difference between the module in the releases section and in this gallery?

Conceptually there could be a difference as the MyGet version is built in AppVeyor (despite using the can't build process). I think I'm using the VS2017 image in order to get access to WM5 (to patch the version number with Update-ModuleManifest). Could that be related?
The strange thing is it all runs fine in Travis' Linux build.

(I can't build the module on Linux because I still support PS3, which is net40. I'll eventually drop that for a new major version)

What about having an AppVeyor build to build the net40 version and use their project NuGet feed as a PowerShell Gallery to host the dev version of the module?  Then you could make the URL of the feed public.  We do this in our PS DSC Resource repos.

I started in that direction but got blocked by the project feed being read only apart from automatically publishing .nupkg files, but no documented way of package a PS module as a nupkg (I dug through the PsGet source for an exported cndlet, but to no avail). If you can shoot me a link to docs or an example, I'm happy to do that instead.
Here's the public myget feed link if it helps: https://www.myget.org/F/pshosts

(eventually the appveyor build will trigger the Travis build via a web hook, buy I'm just trying to get everything working to start with)

just register-psrepository a local path and then publish-module to that repository.  Then you can just publish as artifacts all the nupkg's from that folder.

My understanding is that Appveyor won't let you do that, that you can only publish to the project feed by having a nupkg artifact from your build.

yes, do this during your build.

Will give it a go, though I'm still unsure how this will resolve the macOS issue. I'll let you know how it goes.

I'm not sure it will solve the macOS issue, but having a public CI definition means that I can run it and repro your problem.  BTW, I tried the MyGe feed and still wasn't able to repro the issue.  We also use Travis-ci for macOS testing.  So, I'm confused at where the difference is.

We are basically chatting here.  How about we close this issue and chat on gitter (preferred) or twitter.
Gitter:  https://gitter.im/TravisEz13/home
twitter: travisplunk

Root cause was found, and filed issue #4505

Confirmed that #4506 fixed the issue. Thanks Travis!


radare2 0.10.1 is missing lua file(s)

Installed radare2 from bottle (on 10.11.4):
radare2: stable 0.10.1 (bottled), HEAD
Reverse engineering framework
http://radare.org
/usr/local/Cellar/radare2/0.10.1 (658 files, 42.1M) *
  Poured from bottle
From: https://github.com/Homebrew/homebrew/blob/master/Library/Formula/radare2.rb
==> Dependencies
Build: xz ✔, pkg-config ✔, valabind ✘, swig ✔, gobject-introspection ✔
Required: gmp ✔, libewf ✔, libmagic ✔, lua51 ✔, openssl ✔, yara ✔

When starting r2, it complains about syntax errors and a missing file:
 % r2 -
syntax error: error in error handling
syntax error: error in error handling
status=6, cannot open /usr/local/Cellar/radare2/0.10.1/lib/radare2/0.10.1/radare.lua: No such file or directory

Im having this problem as well

CC @DomT4 for Lua skills.

It looks like radare2 0.10.2 (https://github.com/Homebrew/homebrew-core/pull/262) fixed the major part of this. It no longer complains about the missing radare2.lua file, which is now present in the lib directory.
It still gives me the two syntax error: error in error handling messages on startup, but starts up and appears to work: I can open files, dump code, and so on.
Did 0.10.2 take care of the "No such file" error for you? And is r2 working normally aside from those error messages?

Can confirm the described behaviour in 0.10.2.

Cool. How much are those "syntax error" messages bothering you? Can we close this out?

I don't really know what I'm missing because of the error? Maybe we can make a new ticket in the new repo.

Nah, let's just leave this one open for a bit. I'll look in to it some more.

If it works I think it's probably worth closing this out in favour of a PR later.

I filed an upstream bug asking for some info: https://github.com/radare/radare2/issues/4793
If there's no observable behavior problems, yeah, let's close this out until one crops up, or we hear from upstream that those errors are significant and/or how to fix them.
@zeha: If you run in to any issues or unexpected behavior that might be related to this, yes, please open a new ticket in the new repo. But aside from having more info like that, this might just be cosmetic, and I don't think there's anything we can do about it at this point.

After discussing with upstream a bit, this "error in error handling" looks like a harmless cosmetic problem with the Lua scripting that's used for the r2 REPL UI. Will continue looking in to it because it would be nice to clean up, but I don't think you have to worry about any functional problems here.

Cool, thanks for checking with upstream on that :)


image doesn't display, st + w3m

Description
I was trying to configure neofetch, so that it displays an image. I am using the simple terminal, for which I read, that it supports the w3m image backend, I installed w3m, changed the config to use w3m instead of ascii and ran neofetch. Instead of displaying my wallpaper, it displayed nothing, not even a blank space. Seeing this, I downloaded terminology and changed the backend to tycat, this worked now, but st still didn't.

[ ] Does this issue still occur in the master branch? (Required if issue)
It does

Neofetch version
7.1.0
Screenshot
https://imgur.com/a/9pbndt7
Config file
https://controlc.com/f0745a8b
Verbose log
https://controlc.com/460090c1

Run neofetch -vv 2> neofetchlog
Upload the contents of neofetchlog to pastebin, gist or equivalent.
when trying to append the output to a file, a file gets created, but it remains empty...
I have copied the output from the terminal, since that's the best I could do, sorry

#1392

Oh, I apparently didn't search well enough for other issues. Thank you a lot, I'm sorry for any inconveniences I've caused

No problem at all. :)


Upgrade from DBeaver 6.3 to 7.0.5 stopped postgres SSH tunnel from working

System information:

Operating system (distribution) and version macOS High Sierra 10.13.6
DBeaver version 7.0.5
Java version java version "1.8.0_181"
Additional extensions

Connection specification:

Database name and version
Driver name Postgres 10
Do you use tunnels or proxies (SSH, SOCKS, etc)? SSH

Describe the problem you're observing:
Basically, I was using DBeaver 6.3, connecting to a postgres DB through an SSH tunnel. This configuration had been working fine for many months, so configuration was all correct.
I upgraded to DBeaver 7.0.5, and the SSH tunnel no longer works:
Can't initialize tunnel
Cannot establish tunnel
Cannot establish tunnel
invalid privatekey: [B@6083da0a
invalid privatekey: [B@6083da0a
Steps to reproduce, if exist:
Setup DBeaver 6.3 to connect to a DB thrrough an SSH tunnel. Then upgrade to DBeaver 7.0.5
Include any warning/errors/backtraces from the logs

Can't reproduce.
Please check error/debug logs. I need error stacktrace to investigate this issue.
https://github.com/dbeaver/dbeaver/wiki/Log-files

there is not any update on issue for a long time. Ticket is closed.
If issue is still actual for you - feel free to reopen the issue with additional info


Train Error, error when load_dataset

An error occur when run function load_dataset,
         dataset = load_dataset(             args.dataset_name,             args.dataset_config_name,             cache_dir=args.cache_dir,         )
    dataset = load_dataset(   File "/opt/conda/envs/sd/lib/python3.10/site-packages/datasets/load.py", line 1810, in load_dataset     ds = builder_instance.as_dataset(split=split, verification_mode=verification_mode, in_memory=keep_in_memory)   File "/opt/conda/envs/sd/lib/python3.10/site-packages/datasets/builder.py", line 1128, in as_dataset     raise NotImplementedError(f"Loading a dataset cached in a {type(self._fs).__name__} is not supported.") NotImplementedError: Loading a dataset cached in a LocalFileSystem is not supported.

maybe here https://github.com/modelscope/facechain/issues/383#issuecomment-1780485263

I have encountered the same question, do you have any solutions for it?

@ginobilinie useful for me!

closed as solved.


API HTML return exposes internals of OPUS

Right now the HTML return is really only useful for the OPUS UI, because it has specific classes and templates that we use. It's not very generic and useful to third parties. We should either stop advertising HTML to the public, or supply prettier HTML to the public and reserve the specialized version for internal use using some magic flag to indicate it.

Test has been run against the dev server to check the actual supported return format for each API. Attached file is the log (The test would print out error message only when documented and actual supported format didn't matched.) I think we can remove zip format since none of API has valid response when return format is zip. For html, I think we could also get rid of it because some of return html is not very useful, like this one: http://dev.pds-rings.seti.org/opus/api/meta/range/endpoints/wavelength1.html?planet=Earth&target=Moon&limit=2, it would return blank dl tag of html which is not useful at all. If it's approved, I would update the return format in API document corresponding.
20181114_dev_return_format_testing_log.log

I agree about removing .zip as a valid format. We have to be more careful with HTML because some of the HTML returns are actually used by the OPUS UI. We need to figure out which ones are used, and which ones (if any) we want to continue to make public. Then we can remove the public ones we don't want while still supporting the internal ones.

HTML is now fixed for result_count, endpoints, mults, and metadata/opusid.

HTML is now fixed for api/data.html.
Remaining:
fields
image
images

Closing to consolidate API issues.


Use PyxCodeWriter in the dataclass TemplateCode

makes insertion points behave as they do elsewhere, adds the ability to track indentation (which I don't use here, but which I think will clear things up)

Branch "da-woods:dataclass-writer-2" continues this and https://github.com/cython/cython/pull/5048 to clean up the indentation in the dataclass code generation. (Note to self - create a PR when these two are merged)

Thanks for the cleanup.


Panic while backing up to S3 connection reset and broken pipe

I'm having trouble backing up some large NFS drives to S3 using restic.  AWS has a new EFS (Elastic File System) product that provides NFS as a service. Unfortunately there is no way to snapshot these drives so I was hoping to use restic.  These issues have blocked me from using it so I'm not evaluating other backup options.  I'll try to help get these resolved as the architecture and design of restic is preferable to other options I've found.  My go skills are a bit minimal but I may take a crack at a PR for the fix.
Output of restic version
Latest from master compiled on the machine. Last commit 4a51ddf741b58430b8c24db82b61ac4ce9c5f284
restic 0.4.0 (v0.4.0-71-g4a51ddf)
compiled with go1.6 on linux/amd64

Expected behavior
Restic should complete successfully when backing up large directories from NFS to AWS S3 bucket.
Actual behavior
Restic fails with a panic error during backup.
root@jobs-1:/proj/restic# ./backup_efs.sh
scan [/proj/source]
scanned 25667 directories, 1125384 files in 30:27
panic: client.PutObject: Put https://backup-efs-irl-pubfactory.s3-eu-west-1.amazonaws.com/restic/data/f5dcd03a553e4957901cf849b8cae6b1ca5a7ee379716d4858aeda9a3cf02a54: write tcp <IP_ADDRESS>:51111-><IP_ADDRESS>:4
43: write: broken pipe

goroutine 2028346 [running]:
panic(0xa72f60, 0xc8203b2780)
        /usr/lib/go/src/runtime/panic.go:464 +0x3e6
restic/archiver.(*Archiver).saveChunk(0xc8203dc410, 0x0, 0x3d9a5b, 0x174fb4be00000, 0xc827092000, 0x3d9a5b, 0x5ea000, 0xc8200d4000, 0x7f51c9174b80, 0xc84a84e0a8, ...)
        /tmp/restic-build-465106983/src/restic/archiver/archiver.go:163 +0x12b
created by restic/archiver.(*Archiver).SaveFile
        /tmp/restic-build-465106983/src/restic/archiver/archiver.go:237 +0x70f
scan [/proj/staticfiles]
scanned 1473 directories, 14947 files in 0:20
[4:41] 100.00%  47.601 MiB/s  13.063 GiB / 13.063 GiB  16420 / 16420 items  0 errors  ETA 0:00
duration: 4:41, 47.48MiB/s
snapshot c6c17143 saved
scan [/proj/env]
scanned 588 directories, 946821 files in 45:38
panic: client.PutObject: Put https://backup-efs-irl-pubfactory.s3-eu-west-1.amazonaws.com/restic/data/87ce82cac7736c2f58c1cd249d8dd1582a49b7a768e008cadf6b9cc344ad260f: write tcp <IP_ADDRESS>:60911-><IP_ADDRESS>:4
43: write: connection reset by peer

goroutine 344633 [running]:
panic(0xa72f60, 0xc8338763c0)
        /usr/lib/go/src/runtime/panic.go:464 +0x3e6
restic/archiver.(*Archiver).saveChunk(0xc8290a6a50, 0x399afe607, 0x800000, 0x8d412c900cafd, 0xc83ae82000, 0x800000, 0x936000, 0xc820194000, 0x7ff03be60b10, 0xc8201880e0, ...)
        /tmp/restic-build-465106983/src/restic/archiver/archiver.go:163 +0x12b
created by restic/archiver.(*Archiver).SaveFile
        /tmp/restic-build-465106983/src/restic/archiver/archiver.go:237 +0x70f

Steps to reproduce the behavior

Create an S3 bucket and IAM role with access.  If needed I can provide details on this.
Install go on Ubuntu 14.04 m4.large VM at AWS with 60GB EBS gp2 volume.

add-apt-repository ppa:ubuntu-lxc/lxd-stable
apt-get install golang

Check out latest master of restic and compile using build.go.
Mount 3 separate EFS volumes to the machine using NFS mounts. I can provide details if needed. Mounts are approximately 1.1TB, 14GB and 417GB
Run Backup using the following settings in a shell script, backup_efs.sh

#!/bin/bash

export AWS_ACCESS_KEY_ID="XXXXXXXXXXXX"
export AWS_SECRET_ACCESS_KEY="XXXXXXXXXXXXXXXXXXXXXXXXX"

export RESTIC_REPOSITORY="s3:s3.amazonaws.com/<bucket>"
export RESTIC_PASSWORD="XXXXXXXXXXXXXX"

# Before using this script there is a manual step to initialize the restic repository. I'm not sure
# how to make this step idempotent right now.
#
# restic init

./restic backup /proj/source
./restic backup /proj/staticfiles
./restic backup /proj/env

I apologize, I didn't do a thorough research job on this.  This issue may be a duplicate of issue #415

This is indeed a duplicate of #415, thanks for your comprehensive report though!


No connectivity between pods or services

I've installed flannel using the kube-flannel.yml provided (with CIDR modification), but it's failing to provide networking between pods (I cannot ping pod IPs nor curl Service IPs). I can ping between pods that are on the same host.

Your Environment

Flannel version: 0.9.0
Backend used (e.g. vxlan or udp): vxlan
Etcd version: 3.2.8
Kubernetes version (if used): 1.8.1
Operating System and version: Ubuntu 16.04
Link to your project (optional):

$ cat /etc/cni/net.d/10-flannel.conf
{
  "name": "cni0",
  "type": "flannel",
  "delegate": {
    "isDefaultGateway": true
  }
}

$ cat /run/flannel/subnet.env
FLANNEL_NETWORK=<IP_ADDRESS>/16
FLANNEL_SUBNET=<IP_ADDRESS>/24
FLANNEL_MTU=1450
FLANNEL_IPMASQ=true

kubectl -n kube-system logs kube-flannel-ds-rlhbr
I1025 09:24:48.082348       1 main.go:470] Determining IP address of default interface
I1025 09:24:48.082863       1 main.go:483] Using interface with name eth0 and address <IP_ADDRESS>
I1025 09:24:48.082950       1 main.go:500] Defaulting external address to interface address (<IP_ADDRESS>)
I1025 09:24:48.121591       1 kube.go:130] Waiting 10m0s for node controller to sync
I1025 09:24:48.121686       1 kube.go:283] Starting kube subnet manager
I1025 09:24:49.121948       1 kube.go:137] Node controller sync successful
I1025 09:24:49.121988       1 main.go:235] Created subnet manager: Kubernetes Subnet Manager - kube-master-1
I1025 09:24:49.121997       1 main.go:238] Installing signal handlers
I1025 09:24:49.122063       1 main.go:348] Found network config - Backend type: vxlan
I1025 09:24:49.122127       1 vxlan.go:119] VXLAN config: VNI=1 Port=0 GBP=false DirectRouting=false
I1025 09:24:49.232151       1 main.go:295] Wrote subnet file to /run/flannel/subnet.env
I1025 09:24:49.232177       1 main.go:299] Running backend.

 Please begin using a config file ASAP.
time="2017-10-25T13:46:39Z" level=warning msg="Running modprobe ip_vs failed with message: ``, error: exec: \"modprobe\": executable file not found in $PATH"
time="2017-10-25T13:46:39Z" level=error msg="Could not get ipvs family information from the kernel. It is possible that ipvs is not enabled in your kernel. Native loadbalancing will not work until this is fixed."
I1025 13:46:39.239858       1 server_others.go:117] Using iptables Proxier.
I1025 13:46:39.278735       1 server_others.go:152] Tearing down inactive rules.
E1025 13:46:39.337378       1 proxier.go:699] Failed to execute iptables-restore for nat: exit status 1 (iptables-restore: line 7 failed
)
I1025 13:46:39.352496       1 server.go:449] Running in resource-only container "/kube-proxy"
I1025 13:46:39.353164       1 conntrack.go:98] Set sysctl 'net/netfilter/nf_conntrack_max' to 131072
I1025 13:46:39.353498       1 conntrack.go:52] Setting nf_conntrack_max to 131072
I1025 13:46:39.353607       1 conntrack.go:98] Set sysctl 'net/netfilter/nf_conntrack_tcp_timeout_established' to 86400
I1025 13:46:39.353749       1 conntrack.go:98] Set sysctl 'net/netfilter/nf_conntrack_tcp_timeout_close_wait' to 3600
I1025 13:46:39.353919       1 config.go:202] Starting service config controller
I1025 13:46:39.353950       1 controller_utils.go:1041] Waiting for caches to sync for service config controller
I1025 13:46:39.354181       1 config.go:102] Starting endpoints config controller
I1025 13:46:39.354198       1 controller_utils.go:1041] Waiting for caches to sync for endpoints config controller
I1025 13:46:39.454146       1 controller_utils.go:1048] Caches are synced for service config controller
I1025 13:46:39.454325       1 proxier.go:962] Not syncing iptables until Services and Endpoints have been received from master
I1025 13:46:39.454376       1 controller_utils.go:1048] Caches are synced for endpoints config controller
I1025 13:46:39.454468       1 proxier.go:326] Adding new service port "kube-system/kube-dns:dns" at <IP_ADDRESS>:53/UDP
I1025 13:46:39.454546       1 proxier.go:326] Adding new service port "kube-system/kube-dns:dns-tcp" at <IP_ADDRESS>:53/TCP
I1025 13:46:39.454569       1 proxier.go:326] Adding new service port "default/kubernetes:https" at <IP_ADDRESS>:443/TCP
I1025 13:46:39.454588       1 proxier.go:326] Adding new service port "default/my-nginx:" at <IP_ADDRESS>:80/TCP
I1025 13:46:39.454997       1 proxier.go:978] Stale udp service kube-system/kube-dns:dns -> <IP_ADDRESS>
I1025 13:46:39.521926       1 proxier.go:1674] Opened local port "nodePort for default/my-nginx:" (:32023/tcp)
I1025 13:47:35.989520       1 proxier.go:978] Stale udp service kube-system/kube-dns:dns -> <IP_ADDRESS>

Also, there is no cni0 interface on master node where one is present on the "worker" node.

It looks like the issue was the option "--iptabales=false" on docker.service. After I've removed that, it started working properly.

@tadas-subonis hi! im interested on knowing how did you deployed that, can you clarify me this ?

are you using CNI with flannel plugin on the kubelet service configuration ?
after that, you are deploying the kube-flannel.yml so that it provides what cni needs ?
docker is configured as is ? (since i see you removed --iptables=false that is not the default)
so on you workers you have a docker0 and cni0 bridges, and flannel.1 interface right ?

after this clarifications, i think i can ask you more things.
thanks for you help

@acomisario
Basically, I was configuring a manual deployment using ansible.

Yes
Yes
Not really, here is the config:

[Unit]
Description=Docker Application Container Engine
Documentation=https://docs.docker.com
After=network.target docker.socket
Wants=docker.socket

[Service]
Environment=GOTRACEBACK=crash

Type=notify

ExecStart=/usr/bin/dockerd \
    {% for d in docker_dns_servers %}--dns {{ d }} {% endfor %} \
    {% for d in docker_dns_search_domains %}--dns-search {{ d }} {% endfor %} \
    {% for o in docker_dns_options %}--dns-opt {{ o }} {% endfor %} \
    --iptables=false \
    --insecure-registry={{service_cluster_ip_range}} \
    --log-opt max-size=50m \
    --log-opt max-file=5

ExecReload=/bin/kill -s HUP $MAINPID

LimitNOFILE=infinity
LimitNPROC=infinity
LimitCORE=infinity
TasksMax=infinity
TimeoutStartSec=0
TimeoutStartSec=1min
Restart=on-abnormal

Delegate=yes
KillMode=process

[Install]
WantedBy=multi-user.target

There is one worker and it has all the mentioned interfaces. The master node is/was missing flannel.1.

Basically, I was configuring a manual deployment using ansible.


[No QA] Add a special gesture on dev to open the test tool menu

Details

On dev only, you can now open a test tools modal by tapping with 4 fingers, making it easy to toggle force offline from any page.
Fixed Issues

$ https://github.com/Expensify/App/issues/16737
PROPOSAL: https://github.com/Expensify/App/issues/16737#issuecomment-1490199976
Tests

Mobile web (or a device with touchscreen):

Launch the app with dev environment
Login with expensifail account
Tap with 4 fingers anywhere in the app
Verify that a modal opens with the test tools
Toggle Force offline and verify that the app goes offline
Toggle Force offline and verify that the app goes back online
Close the modal by clicking outside of it
Repeat these steps on another page

Android and iOS:

Launch the app with dev environment
Login with expensifail account
Press 'd' in metro window to open React Native DevMenu. (If you are using a real device - shake it)
Choose 'Open DevMenu' option
Verify that a modal opens with the test tools
Toggle Force offline and verify that the app goes offline
Toggle Force offline and verify that the app goes back online
Close the modal by clicking outside of it
Repeat these steps on another page

[x] Verify that no errors appear in the JS console

Offline tests

N/A
QA Steps

No QA

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://user-images.githubusercontent.com/3872759/231089692-126cbe29-0cde-407a-a8fb-c9c1b996b873.mp4

Mobile Web - Chrome

https://user-images.githubusercontent.com/3872759/231094102-67eca8b4-2911-4529-b757-6e28776d9d1d.mp4

Mobile Web - Safari

Desktop

iOS

https://user-images.githubusercontent.com/3872759/231090836-41870538-3bbd-48d9-ac04-793e6b24f133.mov

Android

https://user-images.githubusercontent.com/3872759/231093618-732f3c71-0773-48fd-b4df-923bef7d203d.mp4

@neil-marcellini @mananjadhav One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@alexxxwork Is it ready for the second pass of the review?

Please update when it is ready for review. I think we should target to get this merged today. Thanks for the continuous updates.

Additionally I think we should split the Test steps for Web, Desktop separate from the Mobile App, where we have specific short cuts to open the Test modal with Debug menu?

Thanks for the input! Updated test steps.

@alexxxwork One last comment https://github.com/Expensify/App/pull/17253/files#r1164543320
@neil-marcellini Can you confirm the copy of the Dev menu? Currently the PR shows Open DevMenu. Let me know if this fine or needs to be on the lines of Open NewDot Test Menu ? Also, do we need any translation here?

I would like to make this menu look a bit better on Android, with some more space below the title.

The heading has style .mb2 (marginBottom = 8px) now and looks different for me. Should I change it to mb4?

The changes for the dev menu item name and the spacing on the modal title look great, thanks.

@neil-marcellini @mananjadhav All done

All you @mananjadhav

Currently testing this, I can't seem to get it working on Web. The numberOfActiveTaps count shows as 1 only. But I am separately struggling with iOS issues. So I'll need a day to close the testing for this one.

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[ ] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://user-images.githubusercontent.com/3069065/232894212-7739a177-305c-445b-8db7-a07a1392248d.mp4

Mobile Web - Chrome
https://user-images.githubusercontent.com/3069065/232894265-4fe0cca6-2429-4b99-b9d7-c8fd2155754e.mov

Mobile Web - Safari
https://user-images.githubusercontent.com/3069065/232894302-3a2f7955-9642-4e8c-996c-0bbd38e34e22.MP4

Desktop
NA

iOS

Android
https://user-images.githubusercontent.com/3069065/232894389-892d2532-960f-45fd-8816-d809c66a91c8.mov

@neil-marcellini yeah I attempted trying DevTools, couldn't get it working.
I am also blocked with iOS build errors. @neil-marcellini Could you help complete the iOS part for screencasting?

@neil-marcellini yeah I attempted trying DevTools, couldn't get it working.
I am also blocked with iOS build errors. @neil-marcellini Could you help complete the iOS part for screencasting?

Sure, it tests well for me on iOS, but note that I had to enter 'd' in the iOS simulator rather than the terminal window. Also, to build on iOS I had to update and follow the steps here. Hopefully that helps you.
https://user-images.githubusercontent.com/26260477/233179259-a2b6ad80-4fb4-463a-90dc-5986b0596a8d.mp4

Ok, I marked off the last part of the checklist and I marked this as No QA because the changes can only be tested on dev, and we already tested that. Merging!

Hmm @alexxxwork the jest unit tests are failing and it looks unrelated. Would you please try merging main?

@neil-marcellini jest coudn't render App because it couldn't find eact-native-dev-menu.
DEBUG [alrt] NewExpensify crash caught by error boundary - Cannot find module 'react-native-dev-menu' from 'src/components/CustomDevMenu/index.native.js'

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.3-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.3-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


[KOGITO-1256] Add json output format to the Kogito CLI

[KOGITO-1256] Add json output format to the Kogito CLI
Signed-off-by: David Ward<EMAIL_ADDRESS>Many thanks for submiting your Pull Request :heart:!
Please make sure that your PR meets the following requirements:

[ ] You have read the contributors guide
[ ] Pull Request title is properly formatted: [KOGITO-XYZ] Subject
[ ] Pull Request contains link to the JIRA issue
[ ] Pull Request contains description of the issue
[ ] Pull Request does not include fixes for issues other than the main ticket
[ ] Your feature/bug fix has a unit test that verifies it
[ ] You've tested the new feature/bug fix in an actual OpenShift cluster

@errantepiphany sorry being a PITA, but could you please check the PR requirements? Many thanks!

@errantepiphany sorry being a PITA, but could you please check the PR requirements? Many thanks!

@ricardozanini Yup, and no worries. Doing this today.

@spolti could you please take a second look?


Surah intros

I'm going to jump in on this too to help

cool, i'll gladly take your assistance -- i'll fix it up at whatever state
its at tomorrow morning in t minus 12 hours approximately insha allah :-)
On Wed, Apr 13, 2016 at 7:36 PM Mohamed El Mahallawy <
<EMAIL_ADDRESS>wrote:

I'm going to jump in on this too to help
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/quran/quran.com-frontend/pull/279#issuecomment-209557956

closing for #280


WinUI 2.8 broke its support contract

Describe the bug
As documented:

WinUI 2 works downlevel to Windows 10 Creators Update (Version 1703, OS build 15063).

This is no longer the case with WinUI 2.8, which apparently requires build 17763. This change makes it impossible to use WinUI 2.8 when targeting Windows 10 Mobile. Microsoft may not care about Windows 10 Mobile, but there is a non-zero number of developers that do.
Steps to reproduce the bug

Create a "Blank App (C++/WinRT)" project
Add a reference to the WinUI 2.8 NuGet package
Build the project from VS2022
Launch VS2017 and try to deploy the AppX to a Windows 10 Mobile device

The deploy will error out due to the AppX requiring an OS build number of 17763.
Retargeting the application for the latest supported Windows 10 Mobile OS (build 15063) will fail the build.
Expected behavior
The application should build against the documented minimum OS version (build 15063). I'm not asking to have the referenced documentation updated nilly-willy to reflect the current status. I'm specifically asking you to deliver on your support promise.
If a contract can be terminated unilaterally then that contract has no value. If that is indeed how you're planning to go about this moving forward, then please make sure to be unambiguously clear about this in your documentation. That at least gives us something to go off of when we need to pick or reject any particular UI system in the future.
Screenshots
No response
NuGet package version
Microsoft.UI.Xaml 2.8.0
Windows app type

[ ] UWP
[ ] Win32

Device form factor
No response
Windows version
No response
Additional context
No response

The documentation page lives in another repository.
Windows 10 Mobile itself is no longer supported as of December 10, 2019.
Reference documentation does not in any way imply a contractual promise.
Why are you targeting an unsupported operating system?

The documentation page lives in another repository.

Thanks for the profound insight.

Windows 10 Mobile itself is no longer supported as of December 10, 2019.

Same.

Reference documentation does not in any way imply a contractual promise.

Then what does?

Why are you targeting an unsupported operating system?

Because there is demand. If it helps you sleep better you may assume that I'm targeting HoloLens devices, that are still in support but also dropped below the WinUI 2.8 support baseline.

WinUI 2 is open-source, you can probably fix this yourself.

It is, except for the interesting parts: WebView2. Now even if I were able to fix this in an alternate universe, where do you suggest I push my changes to instruct the Microsoft Store to be a bit more lenient when it comes to WACK-certification of my binaries? There's more to software deployment than xcopy-ing binaries to my device.

WebView2 never supports ARM32, they have a stub implementation for ARM32. Retargeting to 15063 should be possible with this stub implementation.

@tim-weis So basically the support promise was baloney as you suggested. This is the same pattern used by Windows App SDK folks, so no shocker here.


replaced the dead link on tutorials

replaced the dead link on tutorials. The linked Heroku app is long-dead.
The linked presentation is same author, but updated on the same topic.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


GUI Content and Appearance

Mock up ideas for the GUI and what the user will actually be able to affect

Branch has been created and development began locally.
The branch will be updated asap.

Started development of Qt using the QtCreator IDE. This IDE will provide us with Header files, source files, html UI files as well as (if needed) a makefile.

Gui has been added to the rest of the program


fix the text placement for " no contract found"

Description
Been bugging me a lot, wanted to mention it in #174  but lol was merged already

Before
After

PS : Not that urgent and happy to take other approach

Hey @technophile-04.
Yep, now it looks better :)
There is a ToDo. Handle loading state on the ContractUI.tsx file. Rn, I get quick "Contract not found" splash when loading the page.... even if the contract exists. Could we have a loding state (spinner?) while it grab the contract and only showing "Contract not found" when the contract is not deployed.

There is a ToDo. Handle loading state on the ContractUI.tsx file. Rn, I get quick "Contract not found" splash when loading the page.... even if the contract exists. Could we have a loding state (spinner?) while it grab the contract and only showing "Contract not found" when the contract is not deployed.

+++, will look into it

Added a Skeleton UI for loading state
https://user-images.githubusercontent.com/80153681/219869065-915aec38-031b-417c-9bab-5ff314e0cd3a.mov
Happy to completely remove the Skeleteon UI component, since it's not minimal, and the loading will not take more time mostly
https://user-images.githubusercontent.com/80153681/219869434-95f12dd6-8441-4507-9654-18020f8af2f5.mov

hey @technophile-04 !

Happy to completely remove the Skeleteon UI component, since it's not minimal, and the loading will not take more time mostly

Agree with you, loading is fast, and the skeleton looks strange.

Could we have a loading state (spinner?) while it grab the contract and only showing "Contract not found" when the contract is not deployed.

Have you tried spinner? Sorry for that question, you spent time for a skeleton but maybe it's better.

Tysm @rin-st for a great review 🙌

Have you tried spinner? Sorry for that question, you spent time for a skeleton but maybe it's better.

No problem at all !! didn't spend much time and happy to remove it
With Spinner :
https://user-images.githubusercontent.com/80153681/219873768-e71f3e8a-21f0-400d-9a35-b26dd27b9512.mov
Both looks good to me, the spinner being more minimal on both UI and code side

I'd prefer a spinner. @carletex , what do you think?
Also, it's something wrong with the dark theme. It loads too slowly, but not sure how to fix it. Probably we need to create an issue or think about it later

Just noticed that if you set a target network to goerli or another network then there is a good loading and this is how it looks on goerli :
https://user-images.githubusercontent.com/80153681/219996497-d5f41e4e-f19b-4b07-8439-36d36a9a2ed2.mov

Thanks for this @technophile-04 and @rin-st!
This was a PR to fix the placement of a text in the screen, and it resulted in this :D

haha, we are a bunch perfectionist <3, but since we still have a couple of more critical DX issues going on, we should zoom out and not spend too much time on this kind of thing (for now!).
I'd say, let's go with the spinner for now (easier to review + more minimal). Sorry for this work you already put in, Shiv :/
I think I like the useDeployedContractInfo refactor, more aligned with the use of the wagmi hooks.

but since we still have a couple of more critical DX issues going on, we should zoom out and not spend too much time on this kind of thing (for now!).

💯💯💯

I'd say, let's go with the spinner for now (easier to review + more minimal). Sorry for this work you already put in, Shiv :/

No problem at all didn't spend much time on it  🙌
Updated with Spinner :
https://user-images.githubusercontent.com/80153681/220125544-c061794a-6d26-4cbc-90a7-69de84abaadc.mov


[Event-Request] New events "OnAfterPostServiceDoc" in C5980

Before logging a new issue please make sure to:

Read the FAQ
Search if there is an existing issue for what you want to log. If it's closed you can reopen it and add your comments.
Use the latest Developer Preview release both the server part and the AL Language extension in VS Code (listed on the repository home page)
If you're not using the latest released version (or are using a private build drop that is newer) please provide the version number in the issue

To help us reproduce the issue and find the root please try to:
A) Attach a minimal set of AL code that causes the issue
B) If the error occurs on the server - copy/paste the server stack trace from the Event Viewer

Can there be an Event after the Final Commit in Service-Post CU 5980 Similar to CU80 "OnAfterPostSalesDoc".
OnAfterPostServiceDoc(Rec,ServShptHeader."No.",ServInvHeader."No.",ServCrMemoHeader."No.",ServInvHeader,ServCrMemoHeader);
There would have to be a function to get the passed records from 5988 either before or after the finalize.


Quote fewer attribute keys, fix some bugs

I went and read the nix language grammar and came back with a better understanding of what to quote and not.
Also, quickcheck found some bugs. Oops.

Self-reviewed, looks fine to me.


[OHSS-14855] Using unified path on upgrade roles/operator-roles

Related issue: https://issues.redhat.com/browse/OHSS-14855
What
Removes option of having different paths on operator in regards to policies
Why
There was a design change on path task and this was a leftover from old design
After
./rosa upgrade roles -c st-path-1816 --mode auto --cluster-version=4.10.43
I: Ensuring account role/policies compatibility for upgrade
I: Starting to upgrade the policies
? Upgrade the 'demo-1816-st-Worker-Role' role policy latest version (4.11) ? Yes
I: Upgraded policy with ARN 'arn:aws:iam::xxx:policy/gdbsts/demo-1816-st-Worker-Role-Policy' to version '4.11'
? Upgrade the 'demo-1816-st-Support-Role' role policy latest version (4.11) ? Yes
I: Upgraded policy with ARN 'arn:aws:iam::xxx:policy/gdbsts/demo-1816-st-Support-Role-Policy' to version '4.11'
? Upgrade the 'demo-1816-st-Installer-Role' role policy latest version (4.11) ? Yes
I: Upgraded policy with ARN 'arn:aws:iam::xxx:policy/gdbsts/demo-1816-st-Installer-Role-Policy' to version '4.11'
? Upgrade the 'demo-1816-st-ControlPlane-Role' role policy latest version (4.11) ? Yes
I: Upgraded policy with ARN 'arn:aws:iam::xxx:policy/gdbsts/demo-1816-st-ControlPlane-Role-Policy' to version '4.11'
I: Ensuring operator role/policies compatibility for upgrade
? Upgrade each operator role policy to latest version (4.11)? Yes
I: Upgraded policy with ARN 'arn:aws:iam::xxx:policy/gdbsts/demo-1816-st-openshift-cloud-credential-operator-cloud-credentia' to version '4.11'
I: Upgraded policy with ARN 'arn:aws:iam::xxx:policy/gdbsts/demo-1816-st-openshift-image-registry-installer-cloud-credential' to version '4.11'
I: Upgraded policy with ARN 'arn:aws:iam::xxx:policy/gdbsts/demo-1816-st-openshift-ingress-operator-cloud-credentials' to version '4.11'
I: Upgraded policy with ARN 'arn:aws:iam::xxx:policy/gdbsts/demo-1816-st-openshift-cluster-csi-drivers-ebs-cloud-credentials' to version '4.11'
I: Upgraded policy with ARN 'arn:aws:iam::xxx:policy/gdbsts/demo-1816-st-openshift-cloud-network-config-controller-cloud-cre' to version '4.11'
I: Upgraded policy with ARN 'arn:aws:iam::xxx:policy/gdbsts/demo-1816-st-openshift-machine-api-aws-cloud-credentials' to version '4.11'
? Create the 'st-path-1816-q4n9-openshift-cloud-network-config-controller-clou' role? Yes
I: Created role 'st-path-1816-q4n9-openshift-cloud-network-config-controller-clou' with ARN 'arn:aws:iam::xxx:role/gdbsts/st-path-1816-q4n9-openshift-cloud-network-config-controller-clou'
I: Waiting for operator roles to reconcile

/lgtm