ARROW-8996: [C++] SSE runtime support for aggregate sum dense kernel

Add SSE intrinsic path for aggregate sum dense, sparse part will be a PR later.
Add build support to append the compiler flag for SIMD code file.
Register the SSE version at runtime as the CPU feature.
Also add a test case to cover the overflow on the data types which need a right shift
on the Accumulator type.

The sparse parts I will look into later as it need some additional to remove the invalid value before passing to the SIMD add operations, it need some shuffle op to replace the invalid value to zero.
Also the dense part can be speed up again if using AVX2/AVX512 which is a later job also.

@wesm Can you help to review the approach for runtime kernel path?
For the build part, I introduced some compiler option(GCC push_options or clang attribute push) to help build the SIMD code without a common SIMD flag defined in CXX flags.
For the SSE implementation, currently only dense part is implemented with intrinsic, I need more work for how to remove the invalid values.

@ursabot benchmark --suite-filter=arrow-compute-aggregate-benchmark

I'll try to review this in the next couple days

I'll look at this today

This looks generally quite complicated. If we need 500 additional lines of code to micro-optimize the Sum kernel for a single SIMD instruction set (nevermind that we may also want versions for AVX2, Neon, SVE, and whatnot), things will quickly get out of hand.
If we want to go the way of per-kernel SIMD optimizations, it may be useful to investigate SIMD helper libraries (such as libsimdpp, xsimd...).

@ursabot benchmark --suite-filter=arrow-compute-aggregate-benchmark --cc=clang --cxx=clang++

This looks generally quite complicated. If we need 500 additional lines of code to micro-optimize the Sum kernel for a single SIMD instruction set (nevermind that we may also want versions for AVX2, Neon, SVE, and whatnot), things will quickly get out of hand.
If we want to go the way of per-kernel SIMD optimizations, it may be useful to investigate SIMD helper libraries (such as libsimdpp, xsimd...).

libsimdpp says it has a runtime dispatch support based on function basic. But I don't know if the quality of these libs is perfect enough to use and it was qualified in every spec, it will make the debug things more hard for me if there's any bug there. Another concern is the performance, will the wrapper introduce extra cost? And usually the SIMD code/parameters is designed carefully for each architecture to get best performance, I suspect there's a common code can fit all target.

Certainly someone (or several people) would have to evaluate those libraries before deciding whether to integrate one. Preferably someone with an interest in SIMD optimizations (for example you and/or @cyb70289).
But saying we don't want to use a helper library because the code might be suboptimal performance-wise and it's better to rewrite it from scratch doesn't sound like good engineering practice to me. Daily Arrow maintenance is done by a small set of developers and we should refrain from creating too much burden.

Just find a document(https://dl.acm.org/doi/pdf/10.1145/3178433.3178435 PAGE 7, Table 6: Comparison of various SIMD wrappers.) Some SIMD helper(simdpp/xsimd) has performance issue  at least on some workload.
Another thing is most SIMD helpers has no runtime support, it means we still has to build same code(if we can find a common code path for one function) many times on arrow itself for the runtime capacity.
And I'm working on the sparse part for aggregate sum recently, the data flow is total different for AVX2/AVX512. AVX512 has _mm512_mask_add_pd (__m512d src, __mmask8 k, __m512d a, __m512d b) support that it can SIMD add the results directly on the valid bit map. For AVX2, it has to use a lookup table mask with SIMD and operation to zero the invalid values before passing to SIMD add. The difference is applied to other future SIMD func also as all arrow data represented with valid bit map.

Just find a document(https://dl.acm.org/doi/pdf/10.1145/3178433.3178435 PAGE 7, Table 6: Comparison of various SIMD wrappers.) Some SIMD helper(simdpp/xsimd) has performance issue at least on some workload.

Interesting comparison, thank you. But that is a single workload and we don't know what the issue was precisely.
By the way, this is what the paper says about the approach you're advocating:

The intrinsics or assembly approaches are non-portable, low-level solutions which target specific architectures. They offer maximum control to take advantage of instruction set specificities, and to fine tune register usage. However, it is quite difficult to develop and maintain a low-level code in the long run.

@ursabot benchmark --suite-filter=arrow-compute-aggregate-benchmark

@ursabot benchmark --suite-filter=arrow-compute-aggregate-benchmark

@ursabot benchmark --suite-filter=arrow-compute-aggregate-benchmark

@ursabot benchmark --suite-filter=arrow-compute-aggregate-benchmark

The numbers looks good for sparse part on the benchmark device also now, even though locally my device can get more better speed up thanks to bigger L2/L3 size. I don't know if it's a good direction considering compiler can do less things on the bitmap based.
@emkornfield And others, thoughts?

@jianxind please see my e-mail.  I think we should try to split this PR up into runtime dispatch using slightly tweaked version of the current code without intrinsics.  I will take a closer look at what is being done for sparse, but if you aren't using BitBlockCounter we should incorporate that as a first step, so most sums can delegate to Dense

I think we also need a way of setting max runtime instruction set for runtime dispatch (apologies if there is one and I missed it)

I think we also need a way of setting max runtime instruction set for runtime dispatch (apologies if there is one and I missed it)

Thanks, currently no. But it can easily supported by hooking into CpuInfo::Init(),  tweak hardware_flags_ while checking the user ENV settings, something like "ARROW_RUNTIME_SIMD_LEVEL=none make unittest".
For split PR without intrinsics, I will try to work this. Now I used some compiler pragma(clang attribute push or GCC push_options) to support the intrinsic API, it's defined to NULL for MSVC as MSVC supports directly using intrinsic API without compiler flag. Need find a new method for new ways without intrinsic, maybe something like set_source_files_properties can help here.

Close this one as reference of intrinsic. I will try to work out a new approach without intrinsic.


[HOPS-1152] Allow disabling Users/Groups Cache on the NN side

Make sure there is no duplicate PR for this issue

Please check if the PR fulfills these requirements

[x] Tests for the changes have been added and passed (for bug fixes / features)
[x] HOPS JIRA issue has been opened for this PR
[x] All commits have been squashed down to a single commit
[x] The commit message has the following format: [HOPS-XXX] message

Post a link to the associated JIRA issue
https://hopshadoop.atlassian.net/projects/HOPS/issues/HOPS-1152?filter=allopenissues

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:
hops layer also changed
https://github.com/hopshadoop/hops/pull/639
https://github.com/hopshadoop/hops-metadata-dal/pull/155
https://github.com/hopshadoop/hops-metadata-dal-impl-ndb/pull/193

Can one of the admins verify this patch?

Can you check org.apache.hadoop.hdfs.web.TestWebHdfsFileSystemContract

Can you check org.apache.hadoop.hdfs.web.TestWebHdfsFileSystemContract

the unit test testRenameDirectoryMoveToExistingDirectory is failing because of a change in HOPS-1113. The test also fails on the master branch.  The fix may require changing rename function, which should be done is a separate jira. I have created a new jira for it HOPS-1208

The test was not failing when the tests were run on HOPS-1113.
HOPS-1113 has been merged 14 days ago, since that the test has been run on master multiple times without failing.
I have tried to run this test several times on this pull request and it did not pass at all.

can you check org.apache.hadoop.fs.http.server.TestHttpFSServer

can you check org.apache.hadoop.fs.http.server.TestHttpFSServer

Fixed

tests: https://bbc1.sics.se/jenkins/job/hops-pull-manual/70/

tests: https://bbc1.sics.se/jenkins/view/pull-manual/job/hops-pull-manual/71/


image in feeds.py

I am getting an error when an thumbnail doesn't exist in the cache for an image used in a rss feed.
handler.addQuickElement(u"url", show.img_itunes_sm.url) from https://github.com/rizumu/django-podcasting/blob/master/podcasting/feeds.py
The error is triggerd in utils.py when calling img.save():
    ipdb> img
    <PIL.Image.Image image mode=RGB size=1000x1000 at 0x3A64290>
    ipdb> img.save(tmp, format, **kwargs)
    Suspension not allowed here
    *** IOError: encoder error -2 when writing image file

and the traceback
 Environment:

Request Method: GET
Request URL: http://snowprayers.net/feeds/podcasts/snowprayers/itunes/mp3/rss/

Traceback:
File "/home/deploy/.virtualenvs/snowprayers/lib/python2.7/site-packages/django/core/handlers/base.py" in get_response
  111.                         response = callback(request, *callback_args, **callback_kwargs)
File "/home/deploy/.virtualenvs/snowprayers/lib/python2.7/site-packages/newrelic-<IP_ADDRESS>/newrelic/hooks/framework_django.py" in __call__
  327.                     return self.__wrapped(*args, **kwargs)
File "/home/deploy/.virtualenvs/snowprayers/lib/python2.7/site-packages/django/contrib/syndication/views.py" in __call__
  39.         feedgen.write(response, 'utf-8')
File "/home/deploy/.virtualenvs/snowprayers/lib/python2.7/site-packages/django/utils/feedgenerator.py" in write
  214.         self.add_root_elements(handler)
File "/home/deploy/.virtualenvs/snowprayers/lib/python2.7/site-packages/podcasting/feeds.py" in add_root_elements
  39.         handler.addQuickElement(u"itunes:image", attrs={"href": show.img_itunes_lg.url})
File "/home/deploy/.virtualenvs/snowprayers/lib/python2.7/site-packages/imagekit/models.py" in url
  159.         self._create(True)
File "/home/deploy/.virtualenvs/snowprayers/lib/python2.7/site-packages/imagekit/models.py" in _create
  184.             img, content = self._process_content(self.name, fp)
File "/home/deploy/.virtualenvs/snowprayers/lib/python2.7/site-packages/imagekit/models.py" in _process_content
  135.                                   optimize=True)
File "/home/deploy/.virtualenvs/snowprayers/lib/python2.7/site-packages/imagekit/utils.py" in img_to_fobj
  18.     img.save(tmp, format, **kwargs)
File "/home/deploy/.virtualenvs/snowprayers/lib/python2.7/site-packages/PIL/Image.py" in save
  1439.             save_handler(self, fp, filename)
File "/home/deploy/.virtualenvs/snowprayers/lib/python2.7/site-packages/PIL/JpegImagePlugin.py" in _save
  471.     ImageFile._save(im, fp, [("jpeg", (0,0)+im.size, 0, rawmode)])
File "/home/deploy/.virtualenvs/snowprayers/lib/python2.7/site-packages/PIL/ImageFile.py" in _save
  501.                 raise IOError("encoder error %d when writing image file" % s)

Exception Type: IOError at /feeds/podcasts/snowprayers/itunes/mp3/rss/
Exception Value: encoder error -2 when writing image file

I'll attempt to figure it out over the weekend.

I should note I am using django-cumulus with rackspace cloudfiles.

@rizumu, would you mind trying with the latest master? There were some fixes related to writing to image files.

@bryanveloso the problem persists on master. What stands out most is that the other thumbnails works fine from the template, just not in the feeds.py

Oh wow, github automatically closed this when I committed dd7ae5a8e44fa581eba5c6047030c8cd32c536b9. That's…interesting.
Anyway, I did some research and it seems like the issue is just one with PIL and giant JPEGs (yours is apparently 1000x1000). I couldn't duplicate it myself, but based on what I'm reading, I'm fairly confident that increasing MAXBLOCK will take care of it for you.
Please let us know if this fixes it so we can (properly) close this issue.
My fix is based on this but it's made me rethink our approach to MAXBLOCK in models.py. Right now we're just setting it to an arbitrary number (512^2) and providing a django setting to change it. However any other library is just as likely to mess with MAXBLOCK, so our django setting could ultimately just be scrapped. So I'm thinking we should just remove that line entirely and maybe log a warning in the except clause I added saying something like "You might want to increase ImageFile.MAXBLOCK." That way we won't cause any problems for other libraries (which may set it to something higher), an image always gets produced, and we provide some feedback about avoiding the IOError in the first place. @bryanveloso Thoughts?

…or maybe we shouldn't even bother with the warning?

You said "fix ##" in your commit message, hence the closure. :)
The warning could be good to have in place for situations such as these, especially when the project mainly deals with large files. That way IK won't be switching between two MAXBLOCK values. Although it feels a bit more "automatic" if we just let that function work its magic on an image-by-image basis and not even worry about presenting a warning.
I could go either way.

Yes indeed, this solves the problem. Thanks for taking a look so quickly. Interestingly it was the image proportions, and had nothing to do with the feeds.py :)

@bryanveloso I figured that's what it was. Funny that I could say "doesn't at all fix #X" and close the issue!
I looked through the PIL source and it doesn't seem like switching MAXBLOCK has any cost at all, so we could certainly do that every time without warning. The IOError, on the other hand, is probably something that should be avoided. So logging a warning is probably good. (Unless I'm wrong and the IOError isn't costly.)
I'm thinking now that we should replace line 19 with this:
if ImageFile.MAXBLOCK < 256 * 2 ** 10:
    ImageFile.MAXBLOCK = 256 * 2 ** 10

That way people won't start getting new warnings for sizes that used to work, and we won't decrease the value another library has set.
If you agree, I'll try to get to it (and the warning) later today.

@matthewwithanm, looks good to me!

I decided to go with my original approach (removing line 19 entirely) and not log a warning. I think this is the least troublesome since it stays out of everybody's way—both the people like @rizumu who just want their big images to work, and the people/apps that are trying to set MAXBLOCK themselves. If anybody complains, we can reconsider (:
Check it out: 8911836b53c68fbca1656e6c8fafa1a0827d2e76

I'm still getting this error with 1.1.0

I'm still getting this error with 1.1.0

@andrewebdev I believe this commit is only in the develop branch. We'll try to get the next release together ASAP but until then, you can use the develop branch.

For the time being, I've reduce the image Quality down to 90 rather than 100. This seems to work for now, and the compromise isn't that big. I'll keep an eye out for the latest stable release :)
Thanks!


LPIX-3215 Fixing text gravity

Fixing the layout gravity to match the design in Figma

Judging by designs this tutorial is the same across the app, isn't it?

Ok, added an ability to change text gravity in the library


Core || Quantization || Develop the routines to perform binary quantization

Description
Acceptance criteria
Context

Checkpoint 28-Aug-2024
This is built and tested.


Allow opening remote URLs as well as uploading

It can be annoying to have to save a PDF, then upload it to the viewer. It would be convenient to make the viewer do an XHR and skip the intermediary step.

If you are using the extension you should be able to paste a url in your location bar and it should open up the pdf.js extension.  If you are referring to using the viewer on the demo site we do not plan to support this because of cross domain request restrictions.  There are ways around this but we won't be doing that for the demo site.  See #522 for more ideas.

I'm closing this for now, if it doesn't answer your question feel free to re-open.


Evaluate as candidate for maintenance

Summary
Per the plan to make this org's add-ons more consistent so it is simpler for org volunteers to maintain, evaluate repo to determine if it should continue to be maintained or archived.
Outcome
As a first step in the maintenance and upgrade project, the ember-cognito repository is marked for continued maintenance or archival.
Evaluation Criteria
Potential criteria for determining the value of continuing to maintain a repo are:

[ ] An existing champion / maintainer or well-maintained fork
[ ] Ember Inspector Reports
[ ] GitHub statistics: forks / stars / etc.
[ ] History of issues / ember discord messages requesting updates + bumps
[ ] External usage statistics (e.g. npm downloads, relative to comparable packages)

Acceptance Criteria
This issue is considered complete when:

[ ] Evaluation is commented in this issue
[ ] If recommended to archive, a PR is filed to recommend archive. Ensure README is included in PR with the updated information at the top of the file (don't delete the other content, in case folks are still using it and need to refer to the doc).
[ ] cc @adopted-ember-addons/admin and current primary maintaners for review.
[ ] If marked for continued maintenance, go into the ember-cognito maintenance and upgrade project and convert TODO drafts to issues.

Questions? Ask in the #adopted-ember-addons channel in Discord.

👋 @MelSumner I use this addon personally, so I definitely think we should keep it around.


Minor updates to 2022-12-13-host-process-containers-ga blog

Signed-off-by: Mark Rossetti<EMAIL_ADDRESS>
Here are some minor updates to the HostProcess Containers blog-post suggested in https://github.com/kubernetes/website/pull/37370
/assign @sftim @fsmunoz

/lgtm

If you're willing to, I wonder about also changing the title to reflect that the release has happened.
Eg: title: "Kubernetes 1.26: Windows HostProcess Containers Are Generally Available"
Anyway, /lgtm /approve
/hold OK to unhold if you're happy with it as it stands.

Updated

/lgtm

/unhold


Update index.js correct the addresses used in the Sepolia / Fuji sample

The addresses in the demo code for bridging USDC from Sepolia to Avax Fuji are mostly wrong.
This PR fixes them.

Thanks @kevin-pv01! Merged in https://github.com/circlefin/evm-cctp-contracts/pull/35


Needs Makefile to show which is the base format and how you generate the rest.

So what's the process to generate all the various formats and which is the base format you write in?  I assume it's .txt format?  Even just a README giving details would be good.  :-)

It was entirely manual.. I know.. I edit the ODT in LibreOffice and then manually save a txt, pdf and epub.
However, when I've tried to open the epub in Sigil it says it's corrupted.. so I don't have much faith it's actually generating a proper epub.
I've added a "buildall.sh" that just calls the soffice with the various arguments.
Trapped between writing in sigil.. so writing in a raw XHTML editor or writing in raw LaTeX and then generating..

"Tim" == Tim Keller @.***> writes:

It was entirely manual.. I know.. I edit the ODT in LibreOffice and
then manually save a txt, pdf and epub.  However, when I've tried to
open the epub in Sigil it says it's corrupted.. so I don't have much
faith it's actually generating a proper epub.

Maybe write in markdown and use the 'pandoc' tools to generate the
proper formats?

I've added a "buildall.sh" that just calls the soffice with the
various arguments.

Cool!

Trapped between writing in sigil.. so writing in a raw XHTML editor
or writing in raw LaTeX and then generating..

Dude, it's emacs all the way in org-mode!  :-)

The problem is one of this.. where do you want to spend your time fiddling.. with the plot or with the tools?

Since I'm such a sucky writer... the tools!  :-)


Create new development environment

To avoid confusion, I tore down the previous development enviro where we were prototyping. Now I need to re-setup Wordpress in a new place and get it running so that I can develop the theme and the plugin.

https://wordpress.virtuallearn.ca/


(Red Dog) Walk gif not named properly

Dog walking image is not showing

an s is missing after 8fp and just needs to be added

thanks @Harry-Hopkinson

No problem.


Remove substrings that match Discord's special message markdown in the text the users want the bot to say

SSIA. that's all I need to say
The code I want you to fix maybe in main.py or somewhere XD

FYI https://discordapp.com/developers/docs/reference#message-formatting


CalendarView IS NOT DISPLAYED with Android 7 (SDK 24)

Hi everyone,
I'm currently developping an app in which this great lib is used. The view works correctly on most of SDKs but I test today with the new version of Android (Nougat - 7 - SKD 24) and I can't see many things of the view : day numbers are not displayed at all and decorators are disturbed especially.
Im using the version 1.4.2.
Waiting for your responses,
Thank you for this lib!

Hi. I tested it with API 24 emulator two day ago and all works great. Did you try to change styles?

Works well here too on Nexus 5X with 7.1.1. Is there any style customization?

Yes it is, I have some decorators on the calendar

Is the problem persists after those decorators removed?

I tested by removing some decorators, the one which cause the issue is the follow one:
`class SelectionDecorator implements DayViewDecorator {
    @Override
    public boolean shouldDecorate(CalendarDay day) {
        return !UtilsCalendar.isSameDay(day.getCalendar(), Calendar.getInstance());
    }

    @Override
    public void decorate(DayViewFacade view) {
        try {
            Drawable drawable = ContextCompat.getDrawable(getContext(), R.drawable.selected_day_selector);
        /*Here, in order to have a circle selector, you have to take the tile width/height and reduce from it in order to obtain an equal value for both.
         For example, if you want to make a circle selector which has a scale of 30x30 dps where the tile width is 50dp and the tile height is 40dp, you
         are going to retire 20dp for the width (so 10dp from left and 10dp from right) and 10dp for the height(so 5dp from bottom and 5dp from top).
          */
            int horizontalMargin = (int) UtilsMeasure.pxFromDp((tileWidth - 30) / 2);
            int top = (int) UtilsMeasure.pxFromDp(2);
            int bottom = (int) UtilsMeasure.pxFromDp(8);

            InsetDrawable insetDrawable = new InsetDrawable(drawable, horizontalMargin, top, horizontalMargin, bottom);
            view.setSelectionDrawable(insetDrawable);
        } catch (Exception e) {
            e.printStackTrace();
        }
    }

}`

IN My case Calendar is not displaying fully its dispalying half only


Allow missing leading zeros in most integer modifiers

Closes https://github.com/hrzndhrn/datix/issues/11.

Pull Request Test Coverage Report for Build d2c43cf33a2203a597397c09125dae3aee01eb08-PR-12

22 of 22 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.004%) to 98.842%

Totals

Change from base Build 81eb24ffe723bacb593df57cfaacdb0518f69d80:
0.004%

Covered Lines:
256

Relevant Lines:
259

💛  - Coveralls


[ entropy_src, rtl ] Correct bucket health test test_cnt_o

The previous version of entropy_src_bucket_ht output a count of failing tests on test_cnt_o
This is not what is specified in the documentation. Rather this is supposed to output the
value of the most heavily weighted bin.
This commit calculates the maximum of the (2 ** RngBusWidth) histogram bins, by creating
a tree of comparators (RngBusWidth deep).
Fixes #9757
Signed-off-by: Martin Lueker-Boden<EMAIL_ADDRESS>

Hi Mark,
I took a stab at fixing this RTL bug, just to make sure that my environment was working.  It turned out to be a touch more involved than I thought.   Feel free to adopt this change or do something on your own.  Your choice.

@cindychip: This has a new module, entropy_src_comparator_tree, it occurs to me this could possibly be useful as a primitive, but I'm not sure. I'd like to get this in soon, and I don't know much about the DV formal requirements for primitives.   What do you think is the best approach?  If we do decide it is important to move it, could we maybe make that an issue to let it go in in entropy_src for now?
Regardless I'm happy to leave it here, if everyone else thinks that is okay.

See response to #9757. It is possible that the documentation could be improved.


fix shrug emoji rendering in markdown

also more common use is with round brackets, not square ones

side-note: the code for table-throw emoji somewhat dithers from documentation


Test SFML_USE_STATIC_STD_LIBS

Description
Yet another PR in my journey to testing all these configuration options we have. View the logs to see these flags being applied.
Something weird about this is that in the CI logs you only see this flag appear on the compilation of executables but not on all of SFML's .cpp files. Is that how this is supposed to work? I can't really tell. The other weird thing is that these -static flags appear twice in the examples. I believe the problem is that we call sfml_set_stdlib when compiling the core library and when compiling the examples. This function is not called when building the tests and the tests don't see this -static flag appear twice so that lines up.

Something weird about this is that in the CI logs you only see this flag appear on the compilation of executables but not on all of SFML's .cpp files. Is that how this is supposed to work?

Since you build static libraries, you don't really "link" the static standard library, until you create a tangible artifact such as an executable or DLL, so that sounds correct to me.


⚠ ClamAV has degraded performance

In 958dbc9, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 206 ms

Resolved: ClamAV performance has improved in ea63e09.


adding angular-gist-embed ref to readme

Hi Blair, I like your solution gist-embed and have been using it for long time. Recently I wanted to use it in an AngularJs project. As usual it worked brilliantly but needed to trigger gist() on newly rendered dom when used with dynamic templates.
So, I've created https://github.com/pasupulaphani/angular-gist-embed, to make it easy to use in angular projects.
If you are happy with the work please accept the pull request to reference angular-gist-embed in your README.md.
Kind regards,
Phani.

Thank you!


Issue#83: fix compatibility issue with go-redis v9.2.0

Also, update the dependency to be v9.2.0

any ETA ?

@ehsannm - I do not have merge privileges.

Thanks @bertold , until merge will handle by gomod replace to your repo . 👍🏽

I'm also waiting for this to be merged 🙂

Also waiting for this 👍

Also waiting for this. Could you please merge it?

I'm very sorry, I just received the email that Bertold sent to me. I don't know what went wrong with my GitHub subscription; it seems like it didn't notify me...I have simultaneously created a tag for version v9.2.0


P56

listenerFn(oldValues,newValues)
should be
listnerFn(newValues,oldValues);

I do not see the former anywhere - I think it has been fixed in an earlier version.


Export Charts in dataviewjs codeblock

When exporting a PDF of a page with a chart from the Charts plugin, the chart images don't show up. It's like the images are being ignored when within a dataviewjs codeblock.
Example:
Obsidian:

PDF:

Codeblock:
const current = dv.current();
const totalAulas = parseInt(dv.page("Educação alimentar - 7º ano A").total_aulas);
const comportamentoMau = parseInt(current.comportamento_mau);
const comportamentoMuitoMau = parseInt(current.comportamento_muito_mau);
const comportamento = Math.max(0, (((totalAulas - comportamentoMau - (comportamentoMuitoMau * 2)) / totalAulas) * 10).toFixed(1));
const faltas = parseInt(current.faltas);
const participacao = Math.max(0, ((totalAulas - faltas) / totalAulas) * 10).toFixed(1);
const n_atividades = parseInt(current.n_atividades);
const atividades_extras = parseInt(current.atividades_extras);
const total_atividades = parseInt(dv.page("Educação alimentar - 7º ano A").total_atividades);
const atividade = Math.min(10, ((n_atividades + atividades_extras) / total_atividades) * 10).toFixed(1);

const labelsWithValues = [
    `Comportamento (${comportamento})`,
    `Participação (${participacao})`,
    `Atividade (${atividade})`
];

dv.header(2, `Status`);

dv.paragraph(`\`\`\`chart
    type: radar
    labels: ${JSON.stringify(labelsWithValues)}
    series:
    - title: Atributos
      data: [${comportamento}, ${participacao}, ${atividade}]
      backgroundColor: 'rgba(255, 110, 110, 0.2)'
      borderColor: 'rgba(255, 110, 110, 1)'
    width: 70%
    labelColors: true
    legend: false
    fill: true
    beginAtZero: true
    bestFit: false
    bestFitTitle: undefined
    bestFitNumber: 0
\`\`\``)

Limited by the implementation mechanism of the plug-in, I need to clone the rendering result of the current page into the webview tag. In this process, the canvas image cannot be truly cloned, which has caused this problem. This issue is not easy to fix, I will try to solve it.

You can try version 1.7.3, which converts the canvas to PNG to display the image. There are just some optimizations that still need to be completed.

You can try version 1.7.3, which converts the canvas to PNG to display the image. There are just some optimizations that still need to be completed.

Problem solved. Thanks and congratulations on the plugin.

You can try version 1.7.3, which converts the canvas to PNG to display the image. There are just some optimizations that still need to be completed.

Problem solved. Thanks and congratulations on the plugin.

I also need to emphasize some unresolved issues:

In dark mode, there are color issues with exported images. You need to switch to light mode to export.
Since it's converted to an image, its style may differ from the normal canvas style. If you're concerned about this, you can address it by customizing the CSS snippet.


Implementing concurrent FASTA parsing

This is specifically in order to parse Uniprot's FASTA databases - they do not fit in RAM, so you need a way to concurrently parse the file while you are reading it. This PR implements that feature.
What it do
It can currently parse Uniprot Sprot in 3.1s, or at a speed of about 27.4mb/s (of a compressed GZ file). With that speed, it could parse Uniprot TrEMBL in 1678s, or about ~28 minutes (but maybe faster, idk, haven't tried it on TrEMBL).
Though, tbh, this isn't a lot faster than Biopython. I tested to see how fast Biopython was with the code below:
import gzip
from Bio import SeqIO
import time

tic = time.perf_counter()

with gzip.open("uniprot_sprot.fasta.gz", "rt") as handle:
    for record in SeqIO.parse(handle, "fasta"):
        name = record.id
toc = time.perf_counter()
print(f"Parsed Sprot in {toc - tic:0.4f} seconds")

"Parsed Sprot in 4.6871 seconds"
Though the Biopython code isn't concurrent, which may have consequences down the line when you actually want to do stuff with any data you're getting.
What I changed
I did not use the current FASTA reader at all, opting instead to reimplement it so that it works better on file streams. We should probably think about how to reconcile all that. In addition, I did NOT use the Sequence struct - I used a custom FASTA structure that was much simpler. How do we reconcile that? Do we want to only use Sequence structs, should we use a minimized version, or a function that can switch between the two?
What needs to be changed before pull
@TimothyStiles I'd like to know what you think about the code and how / where I should format it into (right now it just exists between the JSON and FASTA code blocks in io.go and io_test.go (didn't add it into FASTA block cause there is other code there)
Cheers,
Keoni

@Koeng101 how fast does this go compared to biopython exactly?

@TimothyStiles For the parsing of Uniprot Sprot:
Poly: 3.1s
Biopython: 4.6s

@TimothyStiles Your bot is bugged again. Just check out the codecov comment - inconsistent data.
Btw, there should be a full test for the smallfasta file that all parts are properly parsed and parsed once (had some errors where the start line would be two different objects). Would love to get some help writing that, since it is pretty simple.
We should also discuss what we want to do with the other fasta parsing functionality - it works, and it is fantastic we got a pull, but how do we separate that work and this work?

@TimothyStiles I code climate ain't telling me the 6 issues I need to fix, when I click on it it gives me 106 fixes that are from the prime branch.

Closing due to #113 being superior.


Add support to ViewPager

The idea of integrating ViewPager with TabLayout was adopted here

The BottomBar class was modified in a clean way
One of the examples was modified to demonstrate the usage.

Coverage decreased (-1.4%) to 61.922% when pulling cbc5b6a74f3348d2440ca6b0cae91a38d974b9b3 on IslamSalah:add-support-to-viewPager into 711fcafb35d1ba0bb1fb6a7b646110afa9824088 on roughike:master.


Update external contributor's PR

Opening a new PR to address the changes suggested in #4537
(The original PR was opened for 2.1 and is now outdated.)

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/b810397f1a511366cc6f22ce735b0e4809cb4b03/
Edited pages:

v19.2/authentication.md
v20.1/authentication.md


chore: removing apollo analytics (has been superseeded by opentelemetry)

related to https://github.com/GaloyMoney/galoy/pull/1811

Dev mode is not working at galoy stage consistently, might indicate an issue. Debugging.


Update japicmp plugin

This bumps japicmp to 0.13.1 which still doesn't contain the effectively-final fix, but at least provides compatibility with newer japicmp versions so that we can upgrade once that change is released.

So updating this checks the classfile version which is changing from 52 (Java 8) to 50 (Java 6). Changing Kotlin to target 1.8 bytecode produce references to missing methods like Long.hashCode in the bytecode which fails animal sniffer. These methods as generated by kotlinc will be desugared by R8 to all API levels, but unfortunately they forgot Long.hashCode. I added support for it this week into R8 but it won't be available in the canary for two weeks and not in stable until likely June-ish. Even then it will require that people be using AGP 3.5 and will otherwise silently fail at runtime on pre-API 24.
So... since there's no japicmp version with effectively-final yet (the primary motivation for updating the plugin), I'm going to punt on this for now and just leave things as is.

Oooh, that’s super annoying. Thanks for fixing R8.

Closing for now.


wine: no sounds in 32 bit games

Describe the bug
I can't get sound in any 32-bit apps running them with wine.
To Reproduce
Steps to reproduce the behavior:

use the following config

  sound.enable = true;
  hardware.pulseaudio.enable = true;
  hardware.opengl.driSupport32Bit = true;
  hardware.opengl.extraPackages32 = with pkgs.pkgsi686Linux; [ libva ];
  hardware.pulseaudio.support32Bit = true;
  ...
  environment.systemPackages = [ pkgs.wine ];

wine ./game.exe
enjoy no sound

Expected behavior
Sound working in game.
Additional context
Tried Among Us, Hades, Your Turn To Die (free game) a few old other old games
Notify maintainers
@avnik @7c6f434c @bendlas
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
 - system: `"x86_64-linux"`
 - host os: `Linux 5.8.16, NixOS, 20.09.1469.13d0c311e3a (Nightingale)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 3.0pre20201020_e0ca98c`
 - channels(root): `"nixos-20.09.1469.13d0c311e3a"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

winecfg

Hmm. I get similar errors, and it looks like under a fresh user both ALSA and PulseAudio work for me.
Does, say, pavucontrol show some resonable output device?

Hmm. I get similar errors, and it looks like under a fresh user both ALSA and PulseAudio work for me.
Does, say, pavucontrol show some resonable output device?

I actually don't have pavucontrol, if that matters (not sure)
I ran it from nix-shell, all looks good to me

Hmmm. I wonder if creating a fresh user, logging in as that, and rechecking would change anything (quite likely not, of course)

Hmmm. I wonder if creating a fresh user, logging in as that, and rechecking would change anything (quite likely not, of course)

That actually worked... o.0
I'm not sure why, I think that had to do something with wineprefixes.
I deleted ~/.wine on main user, launched the game, got my precious sound.
note: i was using wine-staging for Your Turn To Die (doesn't 'just work' on 5.0), perhaps wineprefixes got mangled or something?

Wine prefixes can accumulate quite a bit of hard-to-instpect state…
I am not any good at inspecting that state, so I often run things with freshly-created empty $HOME. (It's not just about Wine).
I guess if you no longer have any broken state directory, the issue can be closed?

Wine prefixes can accumulate quite a bit of hard-to-instpect state…
I am not any good at inspecting that state, so I often run things with freshly-created empty $HOME. (It's not just about Wine).
I guess if you no longer have any broken state directory, the issue can be closed?

yep!


Can't find where grunt is called from my mocha unit tests

When running my mocha unit tests (via web storm) , i keep getting a grunt error. I don't use grunt, and I removed all the references to grunt i could find and removed grunt from my .sailsrc file. If there are any suggestions, it would be appreciated.
/usr/local/bin/node --debug-brk=55975 /Users/user/Desktop/betatest-sails/node_modules/mocha/bin/_mocha test/bootstrap.test.js test/unit/**/*.test.js --timeout 259200000 --ui bdd --reporter /Applications/WebStorm.app/Contents/plugins/NodeJS/js/mocha-intellij/lib/mochaIntellijReporter.js /Users/matthewchung/Desktop/betatest-sails/test

Debugger listening on port 55983
error: Grunt :: Error: listen EADDRINUSE :::55983
    at Object.exports._errnoException (util.js:874:11)
    at exports._exceptionWithHostPort (util.js:897:20)
    at Agent.Server._listen2 (net.js:1234:14)
    at listen (net.js:1270:10)
    at Agent.Server.listen (net.js:1366:5)
    at Object.start (_debug_agent.js:21:9)
    at startup (node.js:70:9)
    at node.js:961:3

Did you add grunt: false in your hooks config?
For instance, what I do in my bootstrap.test.js:
before(function(done) {

  Sails.lift({
    hooks: {
      grunt: false // Here I disable Grunt hooks
    },
    models: {
      connection: 'test',
      migrate: 'drop'
    }
  }, function(err, server) {
    if (err) {
      return done(err);
    }

    // Load fixtures, etc.

    return done();
  });
});

I had not been but I am now. Thanks Jérémie!


suppport bigint nullable

Codecov Report

Merging #56 (7c5ff00) into develop (d3023d0) will decrease coverage by 1.10%.
The diff coverage is 28.57%.

@@             Coverage Diff             @@
##           develop      #56      +/-   ##
===========================================
- Coverage    89.71%   88.60%   -1.11%
===========================================
  Files            1        1
  Lines          389      395       +6
  Branches        19       19
===========================================
+ Hits           349      350       +1
- Misses          34       39       +5
  Partials         6        6

Impacted Files
Coverage Δ

src/avrotool.c
88.60% <28.57%> (-1.11%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3023d0...7c5ff00. Read the comment docs.


Bad C/C++ Comment Insertion

I've been running this plugin in NeoVim v0.6.1. When I run a license command (e.g. :Gpl) it does some strange insertions giving me something like this in my file buffer for C/C++ files:
 *  *  *  *  *  *  *  *  *  *  *  *  *  *  * /*
 *  *  *  *  *  *  *  *  *  *  *  *  *  *  * Copyright (C) 2022  Ortega Froysa, Nicolás<EMAIL_ADDRESS> *  *  *  *  *  *  *  *  *  *  *  *  *  *  * Author: Ortega Froysa, Nicolás<EMAIL_ADDRESS> *  *  *  *  *  *  *  *  *  *  *  *  *  *  *
 *  *  *  *  *  *  *  *  *  *  *  *  *  *  * This program is free software: you can redistribute it and/or modify
 *  *  *  *  *  *  *  *  *  *  *  *  *  *  * it under the terms of the GNU General Public License as published by
 *  *  *  *  *  *  *  *  *  *  *  *  *  *  * the Free Software Foundation, either version 3 of the License, or
 *  *  *  *  *  *  *  *  *  *  *  *  *  *  * (at your option) any later version.
 *  *  *  *  *  *  *  *  *  *  *  *  *  *  *
 *  *  *  *  *  *  *  *  *  *  *  *  *  *  * This program is distributed in the hope that it will be useful,
 *  *  *  *  *  *  *  *  *  *  *  *  *  *  * but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  *  *  *  *  *  *  *  *  *  *  *  *  *  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  *  *  *  *  *  *  *  *  *  *  *  *  *  * GNU General Public License for more details.
 *  *  *  *  *  *  *  *  *  *  *  *  *  *  *
 *  *  *  *  *  *  *  *  *  *  *  *  *  *  * You should have received a copy of the GNU General Public License
 *  *  *  *  *  *  *  *  *  *  *  *  *  *  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *  *  *  *  *  *  *  *  *  *  *  *  *  *  *
 */

I've tested with Java and Rust and it works how it is supposed to, but for some reason when the filetype is equal to c or cpp it gives me this.

I don't maintain this project anymore.
If you're interested, you can try to fix it and send a PR.

Unfortunately I'm not familiar with VimLisp (or Lisp at all). Any idea more or less what lines I could find this insertion code at?


adjust currency regex to match current messages

The original regex assumed messages would come in the form:
Hi, I would like to buy your 430 Chaos Orb for my 2 Divine Orb in Crucible. offer
The 'offer' at the end being optional. However, lately most messages in game come in the form:
Hi, I'd like to buy your 430 Chaos Orb for my 2 Divine Orb in Crucible
The regex would expect a period at the end of a trade offer so it could then search for the 'offer' group. Since new trade messages would not have a period, it would not match the PoeTradeCurrencyParser and instead try to match with PoeTradeItemParser. Leading to ??? appearing in the price window.
This change explicitely searches for 'offer' in a way that supports both message types.

Addresses issue #147

H, did you test that change? I could merge this one and prepare new release but not sooner than after this weekend

Yes, I have been playing with this change since posting.


x/vuln/cmd/govulncheck: doesn't report vulnerabilities for replaced modules

govulncheck version
Go: go1.21.11
Scanner<EMAIL_ADDRESS>DB: https://vuln.go.dev
DB updated: 2024-06-28 18:33:10 +0000 UTC
Does this issue reproduce at the latest version of golang.org/x/vuln?
Yes
Output of go env in your module/workspace:
GO111MODULE=''
GOARCH='amd64'
GOBIN=''
GOCACHE='/home/ivan/.cache/go-build'
GOENV='/home/ivan/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/home/ivan/.local/share/asdf/installs/golang/1.21.11/packages/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/home/ivan/.local/share/asdf/installs/golang/1.21.11/packages'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/home/ivan/.local/share/asdf/installs/golang/1.21.11/go'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/home/ivan/.local/share/asdf/installs/golang/1.21.11/go/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.21.11'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='/home/ivan/Code/Personal/etcd/etcd/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build879763449=/tmp/go-build -gno-record-gcc-switches'

What did you do?
At etcd-io/etcd, we recently had a vulnerability reported (GHSA-5x4g-q5rc-36jp / golang/vulndb#2952). Our govulncheck job didn't catch this report, as we're using a replace in our go.mod; we were notified by other projects that had our project as a dependency.
Running govulncheck at our repository yields no vulnerabilities:
$ govulncheck ./...
No vulnerabilities found.

What did you see happen?
As stated, it didn't report the vulnerability. If we remove the replace statements from go.mod (i.e., go mod edit -json | jq .Replace[].Old.Path -r | xargs -n1 go mod edit -dropreplace && go mod tidy):
diff --git a/go.mod b/go.mod
index 356ad3485..24231d411 100644
--- a/go.mod
+++ b/go.mod
@@ -4,19 +4,6 @@ go 1.21

 toolchain go1.21.11

-replace (
-       go.etcd.io/etcd/api/v3 => ./api
-       go.etcd.io/etcd/client/pkg/v3 => ./client/pkg
-       go.etcd.io/etcd/client/v2 => ./client/v2
-       go.etcd.io/etcd/client/v3 => ./client/v3
-       go.etcd.io/etcd/etcdctl/v3 => ./etcdctl
-       go.etcd.io/etcd/etcdutl/v3 => ./etcdutl
-       go.etcd.io/etcd/pkg/v3 => ./pkg
-       go.etcd.io/etcd/raft/v3 => ./raft
-       go.etcd.io/etcd/server/v3 => ./server
-       go.etcd.io/etcd/tests/v3 => ./tests
-)
-
 require (
        github.com/bgentry/speakeasy v0.1.0
        github.com/dustin/go-humanize v1.0.0

It does report the vulnerabilities.
I'm unsure if this is a limitation/expected behavior of govulncheck, or a bug. If it is a limitation of govulncheck, we'll need to find a workaround to automate a job that can detect vulnerabilities reported in vulndb for our own source code.
What did you expect to see?
$ govulncheck ./...

=== Symbol Results ===

Vulnerability #1: GO-2024-2527
    Etcd pkg Insecure ciphers are allowed by default in
    go.etcd.io/etcd/client/pkg/v3
  More info: https://pkg.go.dev/vuln/GO-2024-2527
  Module: go.etcd.io/etcd/client/pkg/v3
    Found in<EMAIL_ADDRESS>    Fixed in: N/A
    Example traces found:
      #1: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which eventually calls fileutil.CreateDirAll
      #2: contrib/raftexample/raft.go:275:20: raftexample.raftNode.startRaft calls fileutil.Exist
      #3: tools/etcd-dump-logs/main.go:111:9: etcd.main calls wal.WAL.Close, which eventually calls fileutil.Fdatasync
      #4: tools/etcd-dump-logs/main.go:110:42: etcd.main calls wal.WAL.ReadAll, which eventually calls fileutil.FileBufReader.FileInfo
      #5: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which eventually calls fileutil.Fsync
      #6: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which eventually calls fileutil.IsDirWriteable
      #7: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which eventually calls fileutil.LockFile
      #8: tools/etcd-dump-logs/main.go:106:27: etcd.main calls wal.OpenForRead, which eventually calls fileutil.NewFileBufReader
      #9: tools/etcd-dump-logs/main.go:106:27: etcd.main calls wal.OpenForRead, which eventually calls fileutil.NewFileReader
      #10: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which eventually calls fileutil.OpenDir
      #11: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which eventually calls fileutil.Preallocate
      #12: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which eventually calls fileutil.PurgeFileWithDoneNotify
      #13: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which eventually calls fileutil.PurgeFileWithoutFlock
      #14: contrib/raftexample/raft.go:282:21: raftexample.raftNode.startRaft calls wal.Exist, which calls fileutil.ReadDir
      #15: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which eventually calls fileutil.RemoveMatchFile
      #16: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which eventually calls fileutil.TouchDirAll
      #17: tools/etcd-dump-logs/main.go:106:27: etcd.main calls wal.OpenForRead, which eventually calls fileutil.TryLockFile
      #18: contrib/raftexample/raft.go:282:21: raftexample.raftNode.startRaft calls wal.Exist, which calls fileutil.WithExt
      #19: tools/etcd-dump-logs/main.go:110:42: etcd.main calls wal.WAL.ReadAll, which calls fileutil.ZeroToEnd
      #20: tools/etcd-dump-metrics/install_linux.go:27:2: etcd.init calls fileutil.init
      #21: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which eventually calls logutil.ConvertToZapLevel
      #22: contrib/lock/client/client.go:169:29: client.main calls client.New, which eventually calls logutil.CreateDefaultZapLogger
      #23: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which eventually calls logutil.MergeOutputPaths
      #24: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which eventually calls logutil.NewJournalWriter
      #25: tools/etcd-dump-metrics/etcd.go:27:2: etcd.init calls embed.init, which calls logutil.init
      #26: tools/etcd-dump-metrics/main.go:167:14: etcd.main calls zap.Logger.Panic, which eventually calls logutil.init
      #27: contrib/lock/client/client.go:157:13: client.main calls fmt.Printf, which eventually calls logutil.journalWriter.Write
      #28: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which eventually calls pathutil.CanonicalURLPath
      #29: dummy.go:21:2: etcd.init calls client.init, which calls pathutil.init
      #30: tools/etcd-dump-db/main.go:65:31: etcd.main calls cobra.Command.Execute, which eventually calls srv.GetClient
      #31: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which eventually calls srv.GetCluster
      #32: tools/etcd-dump-metrics/etcd.go:27:2: etcd.init calls embed.init, which calls srv.init
      #33: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which eventually calls systemd.DialJournal
      #34: tools/etcd-dump-metrics/etcd.go:27:2: etcd.init calls embed.init, which eventually calls systemd.init
      #35: dummy.go:24:2: etcd.init calls integration.init, which calls testutil.init
      #36: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which eventually calls tlsutil.GetCipherSuites
      #37: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which eventually calls tlsutil.GetTLSVersion
      #38: tools/etcd-dump-metrics/metrics.go:31:42: etcd.fetchMetrics calls transport.NewTimeoutTransport, which eventually calls tlsutil.NewCert
      #39: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which eventually calls tlsutil.NewCertPool
      #40: dummy.go:24:2: etcd.init calls integration.init, which calls tlsutil.init
      #41: tools/local-tester/bridge/bridge.go:219:22: bridge.main calls net.Listen, which eventually calls transport.Controls.Control
      #42: contrib/raftexample/raft.go:321:24: raftexample.raftNode.startRaft calls rafthttp.Transport.AddPeer, which eventually calls transport.IsClosedConnError
      #43: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which eventually calls transport.LimitListener
      #44: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which eventually calls transport.NewListenerWithOpts
      #45: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which eventually calls transport.NewTLSListener
      #46: tools/etcd-dump-metrics/metrics.go:31:42: etcd.fetchMetrics calls transport.NewTimeoutTransport
      #47: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which eventually calls transport.NewTransport
      #48: contrib/raftexample/raft.go:321:24: raftexample.raftNode.startRaft calls rafthttp.Transport.AddPeer, which eventually calls transport.NewTransport
      #49: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which eventually calls transport.SelfCert
      #50: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which calls transport.SocketOpts.Empty
      #51: tools/benchmark/cmd/util.go:100:34: cmd.mustCreateConn calls transport.TLSInfo.ClientConfig
      #52: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which eventually calls transport.TLSInfo.Empty
      #53: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which eventually calls transport.TLSInfo.ServerConfig
      #54: tools/etcd-dump-db/main.go:66:15: etcd.main calls fmt.Fprintln, which eventually calls transport.TLSInfo.String
      #55: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which eventually calls transport.WithSkipTLSInfoCheck
      #56: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which eventually calls transport.WithSocketOpts
      #57: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which eventually calls transport.WithTLSInfo
      #58: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which eventually calls transport.WithTimeout
      #59: contrib/lock/client/client.go:195:18: client.main calls bufio.Reader.ReadByte, which eventually calls transport.baseConfig
      #60: contrib/lock/client/client.go:195:18: client.main calls bufio.Reader.ReadByte, which eventually calls transport.baseConfig
      #61: contrib/lock/storage/storage.go:100:21: storage.main calls http.ListenAndServe, which eventually calls transport.baseConfig
      #62: tools/etcd-dump-metrics/metrics.go:25:2: etcd.init calls transport.init
      #63: contrib/lock/storage/storage.go:100:21: storage.main calls http.ListenAndServe, which eventually calls transport.keepaliveListener.Accept
      #64: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which eventually calls transport.limitListener.Accept
      #65: tools/etcd-dump-metrics/main.go:169:5: etcd.main calls embed.Etcd.Close, which eventually calls transport.limitListener.release
      #66: tools/etcd-dump-metrics/install_linux.go:39:2: etcd.install calls tls.Conn.Close, which calls transport.limitListenerConn.Close
      #67: contrib/raftexample/raft.go:321:24: raftexample.raftNode.startRaft calls rafthttp.Transport.AddPeer, which eventually calls transport.rwTimeoutDialer.Dial
      #68: contrib/lock/storage/storage.go:100:21: storage.main calls http.ListenAndServe, which eventually calls transport.rwTimeoutListener.Accept
      #69: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which eventually calls transport.setReuseAddress
      #70: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which eventually calls transport.setReusePort
      #71: contrib/lock/client/client.go:195:18: client.main calls bufio.Reader.ReadByte, which eventually calls transport.timeoutConn.Read
      #72: tools/etcd-dump-logs/main.go:354:18: etcd.listEntriesType calls io.WriteString, which calls transport.timeoutConn.Write
      #73: contrib/lock/storage/storage.go:100:21: storage.main calls http.ListenAndServe, which eventually calls transport.tlsKeepaliveListener.Accept
      #74: contrib/lock/storage/storage.go:100:21: storage.main calls http.ListenAndServe, which eventually calls transport.tlsListener.Accept
      #75: tools/etcd-dump-metrics/main.go:169:5: etcd.main calls embed.Etcd.Close, which calls transport.tlsListener.Close
      #76: tools/etcd-dump-metrics/main.go:169:5: etcd.main calls embed.Etcd.Close, which calls transport.unixListener.Close
      #77: contrib/raftexample/raft.go:321:24: raftexample.raftNode.startRaft calls rafthttp.Transport.AddPeer, which eventually calls transport.unixTransport.RoundTrip
      #78: tools/etcd-dump-metrics/main.go:169:5: etcd.main calls embed.Etcd.Close, which eventually calls types.ID.String
      #79: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which eventually calls types.IDFromString
      #80: tools/etcd-dump-metrics/metrics.go:55:11: etcd.getMetrics calls sort.Sort, which calls types.IDSlice.Len
      #81: tools/etcd-dump-metrics/metrics.go:55:11: etcd.getMetrics calls sort.Sort, which eventually calls types.IDSlice.Less
      #82: tools/etcd-dump-metrics/metrics.go:55:11: etcd.getMetrics calls sort.Sort, which eventually calls types.IDSlice.Swap
      #83: contrib/raftexample/raft.go:321:24: raftexample.raftNode.startRaft calls rafthttp.Transport.AddPeer, which calls types.NewURLs
      #84: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which eventually calls types.NewURLsMap
      #85: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which eventually calls types.NewUnsafeSet
      #86: tools/etcd-dump-metrics/metrics.go:55:11: etcd.getMetrics calls sort.Sort, which calls types.URLs.Len
      #87: tools/etcd-dump-metrics/metrics.go:55:11: etcd.getMetrics calls sort.Sort, which eventually calls types.URLs.Less
      #88: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which eventually calls types.URLs.Sort
      #89: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which eventually calls types.URLs.StringSlice
      #90: tools/etcd-dump-metrics/metrics.go:55:11: etcd.getMetrics calls sort.Sort, which eventually calls types.URLs.Swap
      #91: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which eventually calls types.URLsMap.Len
      #92: tools/etcd-dump-metrics/main.go:155:31: etcd.main calls embed.StartEtcd, which eventually calls types.URLsMap.String
      #93: tools/etcd-dump-metrics/metrics.go:55:11: etcd.getMetrics calls sort.Sort, which calls types.Uint64Slice.Len
      #94: tools/etcd-dump-metrics/metrics.go:55:11: etcd.getMetrics calls sort.Sort, which eventually calls types.Uint64Slice.Less
      #95: tools/etcd-dump-metrics/metrics.go:55:11: etcd.getMetrics calls sort.Sort, which eventually calls types.Uint64Slice.Swap
      #96: tools/etcd-dump-logs/main.go:33:2: etcd.init calls types.init
      #97: contrib/lock/storage/storage.go:100:21: storage.main calls http.ListenAndServe, which eventually calls types.unsafeSet.Add
      #98: contrib/lock/storage/storage.go:100:21: storage.main calls http.ListenAndServe, which eventually calls types.unsafeSet.Contains
      #99: contrib/lock/storage/storage.go:100:21: storage.main calls http.ListenAndServe, which eventually calls types.unsafeSet.Remove
      #100: contrib/lock/storage/storage.go:100:21: storage.main calls http.ListenAndServe, which eventually calls types.unsafeSet.Values

Your code is affected by 1 vulnerability from 1 module.
This scan found no other vulnerabilities in packages you import or modules you
require.
Use '-show verbose' for more details.

Related Issues

x/vuln: Does not use the correct GOPATH: Index(): mkdir /pkg: permission denied #57406 (closed)
x/exp/cmd/govulncheck: exclude (fixed) vulnerability info from the own project #48079 (closed)
x/vuln: govulncheck reports no vulnerabilities while deps.dev reports two vulns #54970 (closed)
x/vuln: json output always exits 0 #61704 (closed)
x/vuln: Govulncheck not detecting known vulnerability in Golang dependencies #58757 (closed)
x/vuln/cmd/vulncheck: adds entries to `go.sum` #65170 (closed)
x/vuln: incorrect version is suggested as a fixed version for a vulnerability with multiple packages #54913 (closed)
x/exp/vulndb/govulncheck: CVEs are not detected in GOPATH mode #51591 (closed)
x/vuln/cmd/govulncheck: v1.1.0: Fatal error when used in a workspace #66863
x/vuln: use govulncheck in bazel #61494

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

Replacements with file paths don't have versions and could be anything, which means they can't be matched against a vulnerability database.

perhaps the etcd repo would be better served by using a workspace rather than local replaces?

@golang/vulndb
Not sure there if there is a whole lot that can be done here given the way replace works, as others have pointed out.

Govulncheck uses the replacement module as the source of truth. If your replacement is a local directory, then govulncheck really does not know what that replacement is and what its version is.
We could use instead the module and version being replaced, but that could lead to incorrect results. I agree with the rest of the folks here, I am not sure if there is something we can do here.

Thanks for your answers and suggestions. It makes sense to introduce a Go workspace in the project. I'm closing this issue, as I understand the limitation that govulncheck can't check for vulnerabilities if we have a replace with local source code.


[fix] should allow force refresh when having charts under tab

Codecov Report

Merging #6181 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6181   +/-   ##
=======================================
  Coverage   76.91%   76.91%
=======================================
  Files          47       47
  Lines        9362     9362
=======================================
  Hits         7201     7201
  Misses       2161     2161

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60796da...cd4b6d6. Read the comment docs.


SMOS File Download

There has been trouble downloading the L03 files from https://gimms.gsfc.nasa.gov/SMOS/jbolten/FAS/L03/. We should try to find a way to download all the files in a timely and practical manner, probably by using FTP to ftp://gimms.gsfc.nasa.gov/SMOS/jbolten/FAS/.

I tried winSCP and got an error.

OK I have downloaded them all using wget:
wget -r --no-parent https://gimms.gsfc.nasa.gov/SMOS/jbolten/FAS/L03/

I'll send a download link via email.

P.S.:
FINISHED --2020-10-08 21:28:17--
Total wall clock time: 2m 55s
Downloaded: 2621 files, 1.2G in 1m 47s (11.1 MB/s)

Awesome! I'll put the files into my repo ASAP

Just don’t commit them! Too big.

From: Colin Wu<EMAIL_ADDRESS>Sent: Thursday, October 8, 2020 9:41:04 PM
To: 10aDing/daynight-Q10<EMAIL_ADDRESS>Cc: Bond-Lamberty, Benjamin<EMAIL_ADDRESS>State change<EMAIL_ADDRESS>Subject: Re: [10aDing/daynight-Q10] SMOS File Download (#23)
Awesome! I'll put the files into my repo ASAP
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHubhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2F10aDing%2Fdaynight-Q10%2Fissues%2F23%23issuecomment-705917479&data=02|01|BondLamberty%40pnnl.gov|a853cf3cc1194aafc23a08d86bf4666d|d6faa5f90ae240338c0130048a38deeb|0|0|637378044719710867&sdata=LELIWcZRf%2BYk0kRQ5E1rAfrFuzUxNnx0yu7fkkwKQTo%3D&reserved=0, or unsubscribehttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAO5U5AXTTKIZZ732YO4DR3SJZS3BANCNFSM4SJJKJMQ&data=02|01|BondLamberty%40pnnl.gov|a853cf3cc1194aafc23a08d86bf4666d|d6faa5f90ae240338c0130048a38deeb|0|0|637378044719720826&sdata=HuWbJKnZ7KEc9yZ5HhecufFjVtAD2jLyRvP6KK5EYrA%3D&reserved=0.

I found out how to download .grib files directly into the repo using "curl"! Now we don't need to download all the L03 files, my method directly downloads the requested files into the repo when the method is run!

Nice! Obviously cache the files though (only download as needed).
Anyway great, between wget and curl that's a useful skill to have learned I feel like.


CUDA backend

I made a lot of efforts in related topics, I want to confirm the most difficult part of the transfering backend from CPU to GPU. For eigs, I guess the problem is there is no native implementation of eig implementation GPU backend in JAX?
What I did in jaxeigs is to use pure_callback. In general, the eigensolver in the Krylov space is a CPU-friendly task.

Thanks for reaching out!
Sorry, but I am not sure I understand your point. Could you perhaps specify which issue you've encountered?

I am just wondering how matfree implement eigs on GPU(matrix free-eigensolver). It has been discussed for a long time. see, https://github.com/jax-ml/jax/issues/3112.
I checked the relative file in matfree but found no content? https://github.com/pnkraemer/matfree/blob/main/matfree/eig.py

Thanks for elaborating @qiyang-ustc!
Currently, there is no dedicated eigenvalue solver. There is a partial SVD, and partial eigenvalue solvers are planned for the future (but not with high priority unless someone explicitly asks for it).
As for CUDA, matfree currently does not distinguish between CPU and GPU code and leaves all such implementations to the JAX functions that are called. Does that help?

So, now one can simply combine Arnoldi decomposition(in matfree) with lax.linalg.eig to obtain an JITable, ADable, Krylov eigensolver in JAX!

Yes, this is what I had in mind for building eigendecompositions :) It's also how the partial SVD is currently implemented.
Do you think we should close this issue then? We can open a separate one for implementing a partial eigenvalue decomposition in matfree.eig if you want. What do you think?

I completely agree with you. Thank you, looking forward it!

The development of eig(h)_partial is tracked in #227. I'll close the present issue then; again, thanks for reaching out!


Bluetooth: tester: Fix include service attribute user data

GATT Server:
According to the API, include service declaration user data
points to the first service attribute to include.
bt_gatt_include structure is valid only for client role.
Signed-off-by: Mariusz Skamra<EMAIL_ADDRESS>Fixes: https://github.com/zephyrproject-rtos/zephyr/issues/3829

@Vudentz @jhedberg Please make a review


Give access to the ServiceLocator for power users

@henri-tremblay  can you please add an example of usage of this change ? thanks

My favorite example would be
StatisticsService stats = ((InternalCacheManager) cacheManager)
    .getServiceProvider().getService(StatisticsService.class);

It is currently impossible to retrieve the StatisticsService when using JSR107 to configure the CacheManager.

got it, thanks !

Isn't the real need here for a public statistics API? Not sure what the value is in having this as a stop-gap? I'd rather just solve the problem properly and leave the service locator as hidden as it currently is.  Doesn't this essentially risk having more users assuming they can rely on the internal details of classes to no change?  Not sure what upside it has as it stands.

Yes, a statistics API is a must. But having useful access to internal features with all the required red flags is a nice way to test and incubate features.


Support for Shield Advanced

Please up-vote if you want this feature. Do not submit a new feature request.

Upon further evaluation, we have decided not to add this feature in the immediate roadmap for the solution.


Regarding reproducing the code

can anyone please tell me how do i actually reproduce the code?

any updates?


Button not updated on multi-language page

Happens only in dev mode, so acceptable as long as there is no general issue.


OCPQE-20409 Phase II add API support for risk analysis

Add API support to query risk analysis

query risk analysis with job run id with get request
query risk analysis with payload json file with get request
analyze response data to determine whether the job run is risky

/assign @jianzhangbjz @kuiwang02 @ming1013

/lgtm

@jianzhangbjz var name is refined, can you review and lgtm, thx


Rkt docs

Moving the rkt installation/configuration doc from calico-rkt to calico-docker

If rkt is CNI-based, wouldn't it make sense to keep the this in CNI?  It seems odd to have rkt within a Docker-based directory.

@TrimBiggs Yes I suppose so, but the motive here is to have the rkt docs with all the rest of our documentation. We have a kubernetes directory, a mesos directory, ... why not a rkt directory?

Ah, I didn't realize we had directories for kube/mesos as well already.
LGTM!

What kind of discussion went into making this change? Is this part of a larger docs update?
Even though our more detailed docs all live in calico-docker, each repo still needs a README which explains what the repo is for.

@caseydavenport This is part of moving the calico-rkt repo to calico-cni with the goal to make that repo more generic.

I think it would be helpful to understand the rationale at a more strategic level.  i.e. What other repo re-org and docs re-org stuff is that part of?  If it's just an isolated individual item then what's the rationale for not just including all CNI related install stuff in this repo (rkt, runc, others in time)?

@lxpollitt the background here is that we're renaming calico-rkt => calico-cni, and so the single rkt doc no longer makes sense. When I suggested this move I was following the template that Tom set for libnetwork; the libnetwork repo contains dev instructions for e.g. how to build the plugin, and how to use it in general. The calico-docker repo contains the actual step-by-step guide of how to use Calico with libnetwork.
Analogously, I propose that the calico-cni repo has instructions for building and using the plugin, assuming you know how CNI works. This doc in calico-docker should contain step-by-step instructions for combining calico-cni with Calico to run rkt containers.

@L-MA Looks like this PR no longer has an owner.  Luke - is there anyone driving this to closure?

@robbrockbank There needs to be more discussion on how we're going to organize our documentation across all repos, which doesn't seem to be top priority at the moment. I am going to close this until we revisit the issue.


Add kochanek spline

@ajpmaclean : : Please review.

@ajpmaclean : No .txt file. Indentation fixed. Please review.

@chakravarthi589
FYI: You may come across situations where you need to create a color that is not in vtkNamedColors, look at CylinderExample for one way of doing this.

@ajpmaclean : Thank you for the information.


Use ko in deployment yaml

@mattmoor  I think this should fix the error we're seeing in the nightly build.

You are right @mattmoor

/lgtm


make wandb checkpoint upload optional, change mlp_expansion_ratio def…

…ault from 4 to 2
Changelogs

enumerate the changes of that PR.

Checklist:

[ ] Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
[ ] Add tests to cover the fixed bug(s) or the new introduced feature(s) (if appropriate).
[ ] Update the API documentation is a new function is added, or an existing one is deleted.
[ ] Write concise and explanatory changelogs above.
[ ] If possible, assign one of the following labels to the PR: feature, fix or test (or ask a maintainer to do it for you).

discussion related to that PR

The title says "change mlp_expansion_ratio default" but I don't see that here?


ell: 0.21 -> 0.22, iwd: 0.19 -> 0.20, add myself to maintainers

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @mic92 @dtzWill

cc @flokli @eliasp (from another iwd PR)

@dtzWill I might have taken care of those changes for you again :rofl:
(Though I do mutually benefit)
Tested with #68147, it's quick.

Thank you!
Sorry for not getting to these more promptly,
but I do appreciate and cherish your work seeing things through!
(And thanks for the review and suggestions, all!)
~Will
/me removes this from his TODO backlog xD
On Fri, 13 Sep 2019 18:09:11 -0700, worldofpeace<EMAIL_ADDRESS>wrote:

Merged #68063 into master.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/NixOS/nixpkgs/pull/68063#event-2633854554Non-text part: text/html


ADXL345 Missing Unittest Coverage

Should be possible to add with new trait architecture.

Deal with out of tree after moving device drivers to be built on embedded-hal.


Wiki request - rewrite and simplify explanation of Array.join()

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/join

This issue should be closed. Added this wiki page with commit 07b3e5e on wiki branch.

:+1:


Added german localisation class

Hi!
I came across with your module and though I could help with a small class for the german strings.

Thanks!


nrf-regtool 7.0.0 + nordic,access + J-Link scripts

manifest-pr-skip

Please update all to fromtree

The following west manifest projects have been modified in this Pull Request:

Name
Old Revision
New Revision
Diff

hal_nordic
https://github.com/zephyrproject-rtos/hal_nordic/commit/bc25c094a8cf3064f4f9c1e8060b46e1989edf95
https://github.com/zephyrproject-rtos/hal_nordic/commit/4a3ba8eaca8f5255f550db7bc54dc3e23212da64
<EMAIL_ADDRESS>

Note: This message is automatically posted and updated by the Manifest GitHub Action.

was there no sdk-nrf manifest PR for this change?

was there no sdk-nrf manifest PR for this change?

It's this one: https://github.com/nrfconnect/sdk-nrf/pull/17717


Durable Object support via crossws

Describe the feature

Referencing the issue from crossws – https://github.com/unjs/crossws/pull/54#issuecomment-2337663758

Creating this issue so it can be referenced while creating a PR.
Additional information

[X] Would you be willing to help implement this feature?

H3 will upgrade to a newer version of Crossws 0.3.x once ready.


How to open console in game?

Hi! Thank you for great job) I played about 100 hours on mac by you!!!
I had some troubles trying to open console. Could you please give some instructions for it?
Thank you

Hi! There's some suggestions about console usage in #20.

Closing due to inactivity, feel free to re-open if still an issue 😊


Polyline problem - rendering to infinity

Hello guys,
we have a problem on iOS platform and the problem is:
There are several geo points (markers) shown on the map and we connect them with polyline (source-code attached below).
<Polyline
    coordinates={this.props.list.map(item => {
        return {
            latitude: item.latitude,
            longitude: item.longitude,
        }
    })}
    strokeColor="rgb(0,0,255)"
    strokeWidth={3}
/>

The problem occur just after different zoom scales. If the map is zoomed-in enough, it works fine - all the points are connected with the polyline correctly (zoomed to ~ street level)
Rendered polyline starts and finishes in defined points

but if you zoom-out so the polyline starts from undefined point - kinda wrong calculation of the start or of the length of polyline and the polyline finishes in undefined point as well (zoomed to ~ state level).
Consider there is no other point on the map

another pict (zoomed to ~ continent level). As you can see the end of polyline is in undefined point

The problem occur only on iOS platform, it works well on Android platform at all.
Please, what is the issue? Can you help me how to fix it or prevent this problem?
Thanks!

Seems to be duplicate of https://github.com/lelandrichardson/react-native-maps/issues/248

Yes, it could be. I'm sorry, I haven't mentioned that.


Set unmarshallers early during signing

#Refs https://github.com/keep-network/keep-core/issues/3611.
This PR handles problems with unmarshallers not found errors during signing:
eep-libp2p	libp2p/channel.go:286	couldn't find unmarshaler for type [protocol_announcer/announcement_message]
keep-libp2p	libp2p/channel.go:286	couldn't find unmarshaler for type [tbtc/signing_done_message]

The solution is is to register the marshaller for those messages early, before the signing process begins.

I run the clients just fine, but I don't think I can hit the early signing stage before the sweep proposal on my local. System tests passed. Code looks good to me as well. Leaving the final approval to @lukasz-zimnoch or @pdyraga since they are more familiar with the flow.

It was decided that the full flow will be validated on the testnet with the keep clients that have this change. Otherwise, it is very tricky to hit the early signing stage before the sweep on the local env.


fix RNA Central export

As per Andrew's email
@afg1

I've fixed the RNAcentral export config by adding "lncRNA" to the list of types that are exported.  The file will be updated by the (UK) morning.

The file will be updated by the (UK) morning.

It's updated now: https://www.pombase.org/nightly_update/misc/rnacentral.json

Is sncRNA in too?

Is sncRNA in too?

Yep!  Everything except mRNA.


Pin to 3.1.0 maven-gpg-plugin in deploy script [skip ci]

Refer to: https://github.com/NVIDIA/spark-rapids/issues/10624
As latest maven-gpg-plugin has the issue "error 401 Unauthorized"
when deploy files onto Sonatype repo, we pin it to the
stable version 3.1.0 to unblock our release process.

build

3.1.0 maven-gpg-plugin  has the same "401  Unauthorized" now.
Draft this PR until we maven-gpg-plugin fixed the issue, or we need a work around for deploy.

3.1.0 maven-gpg-plugin has the same "401 Unauthorized" now.
Draft this PR until we maven-gpg-plugin fixed the issue, or we need a work around for deploy.

Seems like maven-gpg-plugin:3.1.0 or its dependency jars had intermittent errors, but now it works again!


Develop/print config type

In order to reconstruct an instance solely from logs, one need to know the type of a config class besides its parameters. In this commit, a config_type.json will be generated containing such information.

Codecov Report
Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (c7bf170) 67.56% compared to head (ec75e73) 66.34%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
- Coverage   67.56%   66.34%   -1.23%
==========================================
  Files          33       33
  Lines        1927     1961      +34
==========================================
- Hits         1302     1301       -1
- Misses        625      660      +35

Files
Coverage Δ

utilsd/fileio/config.py
89.55% <100.00%> (ø)

utilsd/experiment.py
20.66% <12.82%> (-2.82%)
:arrow_down:

... and 3 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


clipPath SVG element with transform rendered incorrectly

Description
Issue happens with SVG images with a <clipPath> element. If the children have a transform attribute, the rendering order seems to be wrong. This can result in SVG files having a black backgground.
See the following example from an SVG:
<clipPath id="myClip">
  <circle transform="scale(.9)" cx="40" cy="35" r="35" />
</clipPath>

If the transform attribute is skipped (or scale=1), then the bug doesn't occur.
If using the Web App, the output shows correctly in the document preview. But the downloaded PDF contains the bug. The bug also happens with the Windows compiler.
I noticed that the issue exists in Version 0.4.0 - 0.6.0 (current). In Version 0.3.0, the issue does not occur. I hope this helps for finding the issue.
Please have a look at the shared document. Make sure to download the PDF (the issue doesn't happen in the preview).
Thanks a lot!
Reproduction URL
https://typst.app/project/ro-8glg-79CJ_ekz6LCizG
Operating system
Windows
Typst version

[X] I am using the latest version of Typst

Yeah, the current svg conversion library doesn't deal with clip paths very well. The good news is that I'm currently trying to rewrite the library and your svgs look correctly in that case, but it might be a while until the rewrite is completely finished.
Could you add the svg label to this issue as well?

Will be fixed once this PR gets merged and upstreamed.


Able to see all the nightly run benchmarks

Currently only the last run is seen on the Macro page.
Need an option to compare with all the benchmark run properly tagged
can be show as
main..
if there is a performance regression we would be able to know when that happened.

Hey @frouioui is this issue still valid ?

It is still valid. Let me extend a bit more on this issue. Generally speaking, what is missing right now in arewefastyet is the ability to see what benchmarks ran. We can see all the different execution thanks to the status page, but that only tell us what was executed. If instead, we had a page that shows all the available benchmarks. We could have a filter per "source" (main, v19.0.3, release-19.0, v17.0.1, etc the list is long) and see a table sorted by execution time that shows all the commits that were benchmark. We could click on a commit and then it would show the workloads that were benchmarked (OLTP, TPCC, TPCC_FK, ...) and show the number of execution for this benchmark. Per commit we should have a link that allows us to see the results for that specific commit too.

This is recently fixed by @Jad31


[feature] reusable workflow to test examples.

This PR adds a reusable workflow to perform module example tests automatically.
Some of the modification to be done to this workflow later on include:

Add the remaining steps; terraform apply, terraform delete
statefiles management (Add statefiles to examples and supporting resources upon PR creation, Delete the statefiles once a PR has been pushed to main)

@hugoalmeida264  I have restricted this workflow to only run on test repos or ec2 repo.
Reason for choosing ec2 repo is because it has supporting resources and consumes all the steps in the Makefile.


[RESOLVED] Interface eth0(): High error rate (>2 for 5m)

Problem started at 11:33:29 on 2023.04.22
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Operational data: errors in: 0, errors out: 0
Original problem ID: 19869
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23483&eventid=19869

Problem has been resolved in 3m 0s at 11:36:29 on 2023.04.22
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Original problem ID: 19869


xfce theme is not Flatabulous

The xfwm4 (XFCE's window manager) theme included is the Numix theme.
Screenshot:  http://imgur.com/e1BIWNRl.png

any solution to this bug?

You should convert all window control buttons from unity/ or metacity-1/ to xpm format and then copy them to xfwm4/. After that you have to rename them.


adding a minor update for xcode14

This is to address the build break on xcode 14

Note that the StockpileMobile app doesn't actually pull from master, but "update-old-fix" branch


Add song information in the OS X bar controls

OS: OS X
I was wondering if song information could be added to the OS X bar controls menu:

I don't know if this qualifies as a dupe of #701.

I don't see how I could possibly fit song information inside that menu?

How about non-clickable rows containing:

That makes the menu quite large 😆
What's wrong with using the mini player if you want to see the song info?

I'm not opposed, I use the mpris menu in gnome in a similar way, but obviously that's not available on OS X.

Well, I find the mini player intrusive, but I guess it's just an opinion.

Also, I think the last part of rows could be dropped. I think Settings and Help (I don't know about Audio Device) are not used enough to justify the place there.

Maybe for you, but those are probably widely used by others, especially in other platforms.

That's true, I understand.

@chamini2 On platforms that aren't OS X the audio device menu is used a lot (I use it far too much on windows too switch between headphones and speakers).  Help is kind of a critical menu as well.
I think it's safe to say (IMO) that if you want to find out what song is playing and you are willing for the process to include a click (the menu would require a click).  Then you can just open the app from the dock 👍

I find annoying having to change desktop (music in another one) to get a song's name. But if you think it makes the menu too large, it's OK. Thanks for the discussion 😁.


FRR: Add confederation GUI options.

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:
[x] I have read the contributing guide lines at https://github.com/opnsense/plugins/blob/master/CONTRIBUTING.md
[x] I have searched the existing issues and I'm convinced that mine is new.
[x] When the request is meant for an existing plugin, I've added its name to the title.
Is your feature request related to a problem? Please describe.
Unable to use OPNsense with FRR in a BGP Confederation.
Describe the solution you'd like
Would like BGP Confederations options added to the UI since there is no custom/raw config options.
Describe alternatives you've considered
RAW/Custom config, but will not be added per https://github.com/opnsense/plugins/issues/1831
Additional context
Need 2 new fields in the GUI, hidden under advanced in the General Tab that control these 2 lines in the FRR config.
bgp confederation identifier <"External" ASN, used when connecting with non confed. peer.>
bgp confederation peers
I.e.:
bgp confederation identifier<PHONE_NUMBER>
bgp confederation peers<PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER>

Also, need an option to apply a route-map to a network statement.
Network: <IP_ADDRESS>/24  (add a 2nd dropdown to the right) Route-map: rm-no-export
Of Course the routemap will be the dropdown of Route-maps that are already specified.
Which would cause the config network statement to look like this:
network <IP_ADDRESS>/24 route-map rm-no-export

Also, need an option to apply a route-map to a network statement.
Network: <IP_ADDRESS>/24  (add a 2nd dropdown to the right) Route-map: rm-no-export
Of Course the routemap will be the dropdown of Route-maps that are already specified.
Which would cause the config network statement to look like this:
network <IP_ADDRESS>/24 route-map rm-no-export

The first one is easy, the second one will break as multiple networks are allowed to add, or so you need this for all?

The first one is easy, the second one will break as multiple networks are allowed to add, or so you need this for all?

By 2nd one are you talking about the route map for network statements. Because the reason I hit hide for that is because apparently it actually works already, I didn't expect it to. I simply added the subnet with the statement route map and the name of the route map and it adds into the config just as it should. But no validation which works exactly how I need it.
But right now route maps must be numbers when added in the GUI. Even though FRR can take a "name", which makes it MUCH easier to know what route map is what, since at least only refers to the route map number.
I'm mobile right now Ill try and add more helpful details tonight.
Also I found an issue in routes maps where they will not apply the set option unless you add a filter or something to it aswell, which again FRR does not require. Again I'll add more detail tonight.

By 2nd one are you talking about the route map for network statements. Because the reason I hit hide for that is because apparently it actually works already, I didn't expect it to. I simply added the subnet with the statement route map and the name of the route map and it adds into the config just as it should. But no validation which works exactly how I need it.
But right now route maps must be numbers when added in the GUI. Even though FRR can take a "name", which makes it MUCH easier to know what route map is what, since at least only refers to the route map number.
I'm mobile right now Ill try and add more helpful details tonight.
Also I found an issue in routes maps where they will not apply the set option unless you add a filter or something to it aswell, which again FRR does not require. Again I'll add more detail tonight.

Specify Route-map for network statement.

address-family ipv4 unicast
  network <IP_ADDRESS>/32 route-map rm-no-export
  network <IP_ADDRESS>/29 route-map rm-no-export
  network <IP_ADDRESS>/24 route-map rm-no-export
  network <IP_ADDRESS>/24 route-map rm-no-export
  network <IP_ADDRESS>/24 route-map rm-no-export
  no neighbor fda9:26a9:1c47::2 activate
 exit-address-family
 !
 address-family ipv6 unicast
  network ::/0 route-map rm-no-export
  network 2000::/3 route-map rm-no-export
  network 2001:470:****:1::/64 route-map rm-no-export
  network 2001:470:****:6::/64 route-map rm-no-export
  network 2001:470:****:1030::/64 route-map rm-no-export
  network fda9:26a9:1c47::40/124 route-map rm-no-export
  network fda9:26a9:1c47:1::/64 route-map rm-no-export
  network fda9:26a9:1c47:1030::/64 route-map rm-no-export
  neighbor fda9:26a9:1c47::2 activate
  neighbor fda9:26a9:1c47::2 next-hop-self
  neighbor fda9:26a9:1c47::2 default-originate
  neighbor fda9:26a9:1c47::2 prefix-list BlockDefaultIPv4 in
  neighbor fda9:26a9:1c47::2 prefix-list BlockDefaultIPv4 out
  neighbor fda9:26a9:1c47::2 route-map rm-no-export in
  neighbor fda9:26a9:1c47::2 route-map rm-no-export out
 exit-address-family

As you can see the the adding route map to a network statement worked perfectly.
Route-map requiring specifying a AS-Path List, Prefix List or a Community List before defining the set statement in the config.
As for the route-map issue of not adding a "set" statement if there if no list if defined is also a problem, there is no requirement in frr for any list/match statements, no match statement means match all.
Also note Route-map "ID" should be called Sequence, Order or Order ID or such, seems . ID to me implies the "Name".
Seems the different areas of the Plugin switch names calling basically the same thing either "ID", "Number" or "Sequence Number" depending on what page you are on.

!
route-map rm-no-export permit 10
!
route-map rm-no-export permit 20
!

Other General finds.
Multiple Lists:
Action is multi select, though input validation properly catches this, it should not be multi select.
AS path:
"Number" Should be "Name", especially since Route Maps seems to refer to it by the number/name and not the description.
Prefix List:
IP Version is multi select, though input validation properly catches this, it should not be multi select.
"Sequence" limited to 10-99, FRR supports 1 to<PHONE_NUMBER>
Route Maps:
ID limited to 10-99, FRR supports 1-65535, and name should change to Sequence or something common.

Specify Route-map for network statement.

address-family ipv4 unicast
  network <IP_ADDRESS>/32 route-map rm-no-export
  network <IP_ADDRESS>/29 route-map rm-no-export
  network <IP_ADDRESS>/24 route-map rm-no-export
  network <IP_ADDRESS>/24 route-map rm-no-export
  network <IP_ADDRESS>/24 route-map rm-no-export
  no neighbor fda9:26a9:1c47::2 activate
 exit-address-family
 !
 address-family ipv6 unicast
  network ::/0 route-map rm-no-export
  network 2000::/3 route-map rm-no-export
  network 2001:470:****:1::/64 route-map rm-no-export
  network 2001:470:****:6::/64 route-map rm-no-export
  network 2001:470:****:1030::/64 route-map rm-no-export
  network fda9:26a9:1c47::40/124 route-map rm-no-export
  network fda9:26a9:1c47:1::/64 route-map rm-no-export
  network fda9:26a9:1c47:1030::/64 route-map rm-no-export
  neighbor fda9:26a9:1c47::2 activate
  neighbor fda9:26a9:1c47::2 next-hop-self
  neighbor fda9:26a9:1c47::2 default-originate
  neighbor fda9:26a9:1c47::2 prefix-list BlockDefaultIPv4 in
  neighbor fda9:26a9:1c47::2 prefix-list BlockDefaultIPv4 out
  neighbor fda9:26a9:1c47::2 route-map rm-no-export in
  neighbor fda9:26a9:1c47::2 route-map rm-no-export out
 exit-address-family

As you can see the the adding route map to a network statement worked perfectly.
Route-map requiring specifying a AS-Path List, Prefix List or a Community List before defining the set statement in the config.
As for the route-map issue of not adding a "set" statement if there if no list if defined is also a problem, there is no requirement in frr for any list/match statements, no match statement means match all.
Also note Route-map "ID" should be called Sequence, Order or Order ID or such, seems . ID to me implies the "Name".
Seems the different areas of the Plugin switch names calling basically the same thing either "ID", "Number" or "Sequence Number" depending on what page you are on.

!
route-map rm-no-export permit 10
!
route-map rm-no-export permit 20
!

Other General finds.
Multiple Lists:
Action is multi select, though input validation properly catches this, it should not be multi select.
AS path:
"Number" Should be "Name", especially since Route Maps seems to refer to it by the number/name and not the description.
Prefix List:
IP Version is multi select, though input validation properly catches this, it should not be multi select.
"Sequence" limited to 10-99, FRR supports 1 to<PHONE_NUMBER>
Route Maps:
ID limited to 10-99, FRR supports 1-65535, and name should change to Sequence or something common.

Please reopen and assign to me

@mimugmail there you go


Ultrasonic Sensorv1.0 pic and name incorrect in the simulator

last week I just update the image of Ultrasonic Sensor and I haven't changed the config file.

what product identifier do you have in the tools?

This must be the firmware returning the wrong product id since it is registered in the catalog.

Thx~peli
I'll figure out why. My rp2040's ID was conflicting with the ultrasonic module's. I have made the modification.
Both devices are randomly generated through 'device registration' and normally they shouldn't duplicate!

I like the new name nanoscript better!


Discover and Get commands for Source Registry

Description
This pull request adds new commands to allow the developer to work with the api-mesh sources catalog through CLI.
API mesh Source is an entity that declares GraphQL schema and maps it to 3rd party APIs or Runtime Actions.API Mesh config that can be meshed into the user's Mesh schema.
The source is an entity that declares GraphQL schema and maps it to 3rd party APIs or Runtime Actions. GraphQL Mesh config that can be meshed into the user's Mesh schema. To learn more about how GraphQL API Gateway manages configs.
Motivation and Context

Related Issue

Motivation and Context
To learn more about api-mesh sources functionality, please check this wiki document. https://wiki.corp.adobe.com/display/dxdevx/API+mesh+connector(sources)+Customer+Experience

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Can we please have a general description of the feature and a few sentences for Motivation and Context section?

@of0x, I can't modify the description of the pull request. So, I added info in the comment.
Description
This pull request adds new commands to allow the developer to work with the api-mesh sources catalog through CLI.
API mesh Source is an entity that declares GraphQL schema and maps it to 3rd party APIs or Runtime Actions.API Mesh config that can be meshed into the user's Mesh schema.
The source is an entity that declares GraphQL schema and maps it to 3rd party APIs or Runtime Actions. GraphQL Mesh config that can be meshed into the user's Mesh schema. To learn more about how GraphQL API Gateway manages configs.
Motivation and Context
To learn more about api-mesh sources functionality, please check this wiki document. https://wiki.corp.adobe.com/display/dxdevx/API+mesh+connector(sources)+Customer+Experience
cc @VladimirZaets please update the pull request description.

@revanth0212 thank you for review, I updated all your suggestions, please look it again. Thanks!

@revanth0212 done! Thank you for review, please check my changes again!

Ready to Merge once functionality validation is confirmed


[Feature] Add option to change line height

Not sure if the options should be percentages rather than pixel values. I went with pixel values to maintain consistency with the font size.

Awesome! Thanks @BradEstey! 😄


Fix Lv95::new()

Fixes the constructor Lv95::new() and exposes Lv95::altitude like in Lv03.

Nice, thanks a lot :+1: