JsonType wrong param binding for mutation query

hibernate version: 6.1.6.Final
hibernate-types-60 version: 2.21.1
Steps to reproduce:

Annotate an entity field with @Type(JsonType.class).
Execute a mutation query to update the field, for example:

session
  .createMutationQuery("update MyEntity set jsonField = :jsonField")
  .setParameter("jsonField", new MyJsonType())
  .executeUpdate()

After some research I found a cause for this problem.
Class AbstractJdbcParameter contains the following fragment:
// If the parameter type is not known from the context i.e. null or Object, infer it from the bind value
if ( jdbcMapping == null || jdbcMapping.getMappedJavaType().getJavaTypeClass() == Object.class ) {
  jdbcMapping = guessBindType( executionContext, bindValue, jdbcMapping );
}

All your custom json types always return Object.class because they inherited from AbstractClassJavaType.
Temporarily workaround example:
public class CustomJsonJavaTypeDescriptor extends JsonJavaTypeDescriptor {
    private Class customType = Object.class;

    @Override
    public void setParameterValues(Properties parameters) {
        super.setParameterValues(parameters);
        customType = ((ParameterType) parameters.get(PARAMETER_TYPE)).getReturnedClass();
    }

    @Override
    public Class<Object> getJavaType() {
        return customType;
    }
}

public class CustomJsonType extends MutableDynamicParameterizedType<Object, JsonJdbcTypeDescriptor, CustomJsonJavaTypeDescriptor> {
    public CustomJsonType() {
        super(Object.class, new JsonJdbcTypeDescriptor(), new CustomJsonJavaTypeDescriptor());
    }
}

I propose following solution:

Don't extend from AbstractClassJavaType because it has private final Class<T> type and reimplement it logic.
Set type dynamically in setParameterValues method.

The JsonType is not auto-registered, so you have to provide the type explicitly when you bind it.
Son, instead of:
session
  .createMutationQuery("update MyEntity set jsonField = :jsonField")
  .setParameter("jsonField", new MyJsonType())
  .executeUpdate()

You need to use:
session
  .createMutationQuery("update MyEntity set jsonField = :jsonField")
  .setParameter("jsonField", new MyJsonType(), new JsonType(MyJsonType.class))
  .executeUpdate()

That's it!
Here are two test cases that show you this in practice:

GenericPostgreSQLJsonTypeTest
GenericMySQLJsonTypeTest

Thank you for so fast response!

Hibernate can detect a binding from the field, so you can bind a value without the third param. Actually it worked in hibernate-types-55.
Can you try to replace Location with a custom not serializable type (our case)? I see serialization exception in this case. This happens because hibernate picks wrong mutability plan from wrong JavaType.
If I replace JsonType with CustomJsonType from my example all works fine even without providing the JsonType explicitly.

Hibernate can detect a binding from the field, so you can bind a value without the third param. Actually it worked in hibernate-types-55.

Hibernate 6 changed the Type system significantly, and the auto-registration no longer works as before.

Can you try to replace Location with a custom not serializable type (our case)? I see serialization exception in this case. This happens because hibernate picks wrong mutability plan from wrong JavaType.

Yes, you can remove the Serializable from that Location class and it will still work just fine. The test cases are available in the project so you can validate this yoo.

If I replace JsonType with CustomJsonType from my example all works fine even without providing the JsonType explicitly.

It also works just fine with the JsonType and the explicit Type, as I have shown you. In fact, providing the Type explicitly for queries has been the default way of working for this library.
However, if you think you are better off using your CustomJsonType, then you shall use that one instead.

@belovaf Actually, as I explained in this article, there's another alternative via the TypedParameterValue.
This is a Hibernate constructor that was designed exactly for this use case:
session
  .createMutationQuery("update MyEntity set jsonField = :jsonField")
  .setParameter("jsonField", new TypedParameterValue<>(new JsonType(MyJsonType.class), new MyJsonType()))
  .executeUpdate()

@vladmihalcea, I debug mentioned by you test cases. I didn't notice that they use nativeQuery.
My issue is relevant only to hibernate mutation query (hql).
If you want, I can make a pull request which demonstrates the problem.

You are absolutely right about natives queries. One indeed need to provide a typed parameter for them. But when a hql query is used hibernate detects parameter type automatically from the corresponding field.

@belovaf For JPQL is even simpler. All you need is just register the Type, like this:
properties.put("hibernate.type_contributors",
    (TypeContributorList) () -> Collections.singletonList(
        (typeContributions, serviceRegistry) ->
            typeContributions.contributeType(locationJsonType)
    )
);

Once you do that, your query is as simple as:
entityManager.createQuery(
    "update Event " +
    "set location = :location " +
    "where id = :id")
.setParameter("id", _event.getId())
.setParameter("location", location)
.executeUpdate();

You can see the example in GenericMySQLRegisterJsonTypeTest.
The fact that this is not resolved automatically is a Hibernate issue for which you should open a Jira issue.

I created HHH-15953 for this.

@vladmihalcea, thank you very much!
Your involvement and reply speed are outstanding!

At Hypersistence, High-Performance is the normal velocity.

Thanks for this issue. I ran exactly into the same problem using the JsonBinaryType with Hibernate 6. Thanks for the good work!

@joshiste You're welcome. Stay tuned for more


websocket terminated at init callback, any change for the API?

terminated with reason: {cowboy_handler,[{class,error},{reason,undef},{mfa,{websocket_handler,init,2}},
My code is:
init(Req, Opt) ->
{Client,} = cowboy_req:peer(Req),
State = #state{client = Client, state = started},
lager:info("Connection from: ~p", [Client]),
{cowboy_websocket, Req, State, hibernate}.

Did you compile with the lager parse transform enabled?

No

if


Provide configuration option to hide the initial notification

Version: 1.49.0 (user setup)
Commit: e790b931385d72cf5669fcefc51cdf65990efa5d
Date: 2020-09-10T13:22:08.892Z
Electron: 9.2.1
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19041

"cmake.configureOnOpen": false,
"cmake.configureOnEdit": false,

"cmake.configureOnOpen": false,
"cmake.configureOnEdit": false,

It doesn't work.


Added Dixit

Submitting this PR means you have:

[x] searched the readme file and searched the open pull requests (no duplicates please)
[x] and will follow the desired format

Once your PR is created, it will trigger a build on Travis CI. This includes a formatter linting process, so if there are any issues with the build, please address them.
Do you have further questions? Check the contribution guidelines or open an issue.
When you're ready, check off the above acknowledgements and continue with your Pull Request... and thanks!

Thanks for contributing.


Build error: math.MaxUint32 overflows int

Go version:
go version go1.19.2 linux/arm
Build architecture:
armv7l
Problem:
I'm attempting to build go-sbot which relies on go-muxrpc (see https://github.com/ssbc/go-ssb/pull/180 for details). The build fails with the following error message:
../go/pkg/mod/github.com/ssbc/go-muxrpc/v2@v2.0.14-0.20221020091224-b09bdf60812f/codec/writer.go:27:15: math.MaxUint32 (untyped int constant<PHONE_NUMBER>) overflows int
Possible fix:
I believe this can be solved with the following change to codec/writer.go:27:15:
// cast `bodyLen` to uint
if uint(bodyLen) > math.MaxUint32 {

I tried this fix on a fork and it passes the tests. I wanted to retry the build of go-sbot with this change but I am utterly failing (no Go experience; don't know how to change the module dependency to pull from my fork).

@mycognosist
Amazingggg, try this in the go-ssb go.mod which assumes a locally hacked copy of go-muxrpc in ../ :crossed_fingers:
diff --git a/go.mod b/go.mod
index c4d475f..51c2757 100644
--- a/go.mod
+++ b/go.mod
@@ -6,6 +6,8 @@ module github.com/ssbc/go-ssb

 go 1.13

+replace github.com/ssbc/go-muxrpc/v2 => ./../go-muxrpc
+
 require (
        filippo.io/edwards25519 v1.0.0
        github.com/RoaringBitmap/roaring v1.2.1

Then the new go-sbot build should pull in the local go-muxrpc copy.

I tried this fix on a fork and it passes the tests.

Hmmmm I'm seeing test tests fail locally :thinking:
(go test -v ./... (requires running npm ci beforehand), more specifically go test -v ./codec -run TestWriteTooLarge)
These two seem to point to a deeper problem, the handling of int on different archs:

https://discuss.dgraph.io/t/cross-compiling-for-goarch-arm-int-overflow/10840/2
https://github.com/golang/go/issues/33388

I think what needs to be done is override NewWriter to return a WritePacket which is appropriate for the architecture... and WritePacket may need to be defined in a separate writer.go/writer_32bit.go file which has appropriate build tags (e.g. // go:build 386 arm armbe mips mipsle ppc s390 sparc) to choose at compile time... seems quite involved but basically the approach as highlighted in https://github.com/golang/go/issues/33388...
If you can confirm that this changes get you a functionality built go-muxrpc on a pi zero then I can take a run at the PR for the fix? Also if you wanna dive into doing that, please don't let me stop you :laughing:

Ah shoot, thanks for checking the tests and providing additional details. I only tried the basic go test on my Pi Zero and it passed. I should have known such a simple fix was too good to be true.

If you can confirm that this change gets you a working go-muxrpc on a pi zero then I can take a run at the PR for the fix?

Confirmed! It's working! Has now been running for 45 minutes without a crash. Message publishing is working. I am running legacy replication for the moment. I just followed my main ID and replication is underway.
If you'd like to take a run at a fix then I will cheer you on! Otherwise I can attempt to follow your breadcumbs and work on a fix during the week.

Confirmed! It's working!

Spectacular!

If you'd like to take a run at a fix

Hoping that https://github.com/ssbc/go-muxrpc/pull/15 might do it after all, much simpler :pray:


[BYOD] Automation to build and snapshot template docker image

https://docs.google.com/document/d/1DZ40-bFhQLR4b1pmkgyLtiA1brH46RsOJZhlrBD3WMc/edit
This PR create a script to automate the process of the SOP in the doc To run this script, one should have following tools installed 1) bazelisk # plan to remove this dependency soon
2) git # plan to remove this dependency soon
3) docker
4) aws
Before running the script, one should setup the credential from anyscale-dev-product account on AWS.
This script should run on both devbox and laptop, and devbox is recommended. follow this task to track progress of this project https://anyscale1.atlassian.net/browse/AE-529

All looks good to me - however I have some questions about whether this should be in this public repo or not. If so, we should at least decouple the magic strings/ids from the source.

After collecting and applying all comments from this PR, I'll create a new one in private repo and close this one.


Failed migration puts you in an error state

If you apply more than one migration at the same time, and the last one fails, the changes to the content model from the earlier ones will have been applied but no migration entries will have been created for them, so when you run cmp migrate again it will try (and fail) to re-apply them.

Oh, missed that! Thanks for the report, will check asap.
@jacobhallenborgprototyp did you see that?

Thanks @tonioriol! I haven't checked the code, but I guess you should create the "Contentful migration entry" after each successfully applied migration, instead of creating them all at the end. Or I'm missing something and the problem is something else entirely 😅

Would you prefer that than to rollback all from the batch?

I think so. I probably would want to just fix the failing one and run it again. Also, I can easily rollback the committed ones with the rollback command if I want to. What do you guys think?


Added port 443 to ES connection

Elasticsearch defaults to port 9200, however, AWS uses the regular web
ports for their instances of ES. Which means, port 80 for http, port 443
for https. I was running into an issue with this while trying to use this
blueprint.

You can generalize that by making it an environment variable.

Hi guys. Thanks @Viiderstorm for the PR.
However, it works out of the box for me by specifying the port in the endpoint as @eldos-dl mentioned.
So I don't think it is necessary.
@eldos-dl do you have some reference documentations about using an environment variable for the port?

Sorry, I'm a bit late to the thread. I don't check github extremely often.
I'm not exactly sure why, but it wasn't working right out of the box for me. When I would test the AWS Lambda function it would throw an error at line 37, where it's supposed to print the ES info. After digging into the error messages and trying to get a response with curl, I realized that I wasn't getting a response from port 9200. So I went to my AWS ES instance, followed the link, and Boom. I got response, over port 80 (since it was a web link). We also had an SSL/https URL, so I curl'd over 443, and that worked, but 9200 would never return anything.
I kind of pulled the idea from looking at the documentation on using Logstash to bulk load data into Amazon ES. I saw that if it was connecting with SSL it should use port 443, so I used that instead of the default since "use_ssl=True" and it worked fine.
However, If it works for others without adding the port, then it's probably just something wrong with the way my Amazon ES is setup. I just thought I'd make a pull request any way just in-case. It can be rejected later if it's not really necessary.

Did what @eldos-dl suggested and it works for me. So I guess I'll close this PR. Not sure why that thought never came across my mind.
Thanks for the help!


After configuring for the first time, sensors/commands cannot be added before restarting the service

A reboot also helps

Yeah, very weird behaviour prior to reboot (it appears as though no configuration values save, and can't add sensors. But reboot definitely helped.
Very minor, would be great to edit a sensor (e.g. change report frequency) without having to delete/re-add.


Misc inflate cleanup

Stop updating 'dmax' and 'sane' and remove the variables from 'inflate_state' unless the checks are compiled in.
Add a variable 'wsize_real' to track the real size of the window buffer, including padding. This allows chunkset code to spill garbage writes into the padding area if it is available. It is not available for inflateBack unfortunately.
Reorder the 'inflate_state' struct to improve cache-locality of the variables needed by inffast (reduced from 6 to 1 cacheline)
Also fills in some unnecessary holes.

On x86-64, default settings, inflate_state also shrinks from 9216 to 9152 bytes and now ends cleanly on a cacheline boundary.…ompiled in.

Summary by CodeRabbit

New Features

Enhanced control over inflation process behavior based on compilation flags.
Additional fields in the inflation state structure for improved memory management.

Bug Fixes

Streamlined handling of invalid distances to improve error management.

Refactor

Simplified control flow by removing conditional compilation paths and consolidating distance checks.

Documentation

Updated structure organization for clarity and optimized memory alignment.

x86-64 (i9-9900K) 2.2.2
Level   Comp   Comptime min/avg/max/stddev  Decomptime min/avg/max/stddev  Compressed size
1     54.185%      0.104/0.109/0.111/0.002        0.030/0.035/0.038/0.002        8,526,745
2     43.871%      0.198/0.203/0.204/0.001        0.032/0.036/0.038/0.002        6,903,702
3     42.390%      0.247/0.250/0.253/0.002        0.032/0.035/0.036/0.001        6,670,664
4     41.644%      0.275/0.280/0.282/0.002        0.031/0.034/0.035/0.001        6,553,205
5     41.215%      0.303/0.308/0.310/0.002        0.031/0.034/0.035/0.001        6,485,659
6     41.032%      0.348/0.355/0.359/0.003        0.029/0.033/0.035/0.002        6,456,912
7     40.778%      0.496/0.505/0.509/0.003        0.031/0.033/0.035/0.001        6,416,941
8     40.704%      0.613/0.619/0.624/0.003        0.032/0.033/0.035/0.001        6,405,249
9     40.409%      0.906/0.911/0.915/0.003        0.030/0.033/0.035/0.001        6,358,951

avg1  42.914%                        0.393                          0.034
tot                                106.189                          9.189       60,778,028

  text    data     bss     dec     hex filename
130774    1312       8  132094   203fe libz-ng.so.2

         5,521.85 msec task-clock:u                     #    1.000 CPUs utilized               ( +-  0.03% )
                0      context-switches:u               #    0.000 /sec
                0      cpu-migrations:u                 #    0.000 /sec
              144      page-faults:u                    #   26.078 /sec                        ( +-  0.39% )
   19,093,810,958      cycles:u                         #    3.458 GHz                         ( +-  0.03% )  (62.49%)
   35,726,573,927      instructions:u                   #    1.87  insn per cycle              ( +-  0.01% )  (74.99%)
    3,758,372,000      branches:u                       #  680.636 M/sec                       ( +-  0.02% )  (74.99%)
      174,901,372      branch-misses:u                  #    4.65% of all branches             ( +-  0.03% )  (74.99%)
    6,865,961,607      L1-dcache-loads:u                #    1.243 G/sec                       ( +-  0.02% )  (74.99%)
      233,340,453      L1-dcache-load-misses:u          #    3.40% of all L1-dcache accesses   ( +-  0.07% )  (75.01%)
       18,378,169      LLC-loads:u                      #    3.328 M/sec                       ( +-  1.58% )  (50.01%)
              144      LLC-load-misses:u                #    0.00% of all LL-cache accesses    ( +- 20.28% )  (50.00%)

x86-64 Inflate cleanup PR
 Level   Comp   Comptime min/avg/max/stddev  Decomptime min/avg/max/stddev  Compressed size
 1     54.185%      0.105/0.109/0.111/0.002        0.030/0.036/0.038/0.002        8,526,745
 2     43.871%      0.194/0.197/0.198/0.001        0.033/0.036/0.037/0.001        6,903,702
 3     42.390%      0.240/0.244/0.246/0.002        0.030/0.034/0.036/0.002        6,670,664
 4     41.644%      0.270/0.275/0.277/0.002        0.029/0.033/0.035/0.001        6,553,205
 5     41.215%      0.293/0.299/0.302/0.002        0.031/0.034/0.035/0.001        6,485,659
 6     41.032%      0.341/0.348/0.352/0.003        0.029/0.033/0.035/0.002        6,456,912
 7     40.778%      0.491/0.501/0.507/0.004        0.031/0.033/0.035/0.001        6,416,941
 8     40.704%      0.609/0.616/0.621/0.003        0.031/0.033/0.035/0.001        6,405,249
 9     40.409%      0.904/0.911/0.917/0.003        0.029/0.033/0.034/0.001        6,358,951

 avg1  42.914%                        0.389                          0.034
 tot                                104.973                          9.172       60,778,028

   text    data     bss     dec     hex filename
 130102    1312       8  131422   2015e libz-ng.so.2

          5,518.07 msec task-clock:u                     #    1.000 CPUs utilized               ( +-  0.02% )
                 0      context-switches:u               #    0.000 /sec
                 0      cpu-migrations:u                 #    0.000 /sec
               144      page-faults:u                    #   26.096 /sec                        ( +-  0.37% )
    19,068,549,752      cycles:u                         #    3.456 GHz                         ( +-  0.03% )  (62.47%)
    35,717,171,689      instructions:u                   #    1.87  insn per cycle              ( +-  0.01% )  (74.98%)
     3,758,323,631      branches:u                       #  681.094 M/sec                       ( +-  0.02% )  (74.98%)
       175,939,466      branch-misses:u                  #    4.68% of all branches             ( +-  0.06% )  (75.00%)
     6,864,926,063      L1-dcache-loads:u                #    1.244 G/sec                       ( +-  0.03% )  (75.02%)
       232,739,294      L1-dcache-load-misses:u          #    3.39% of all L1-dcache accesses   ( +-  0.07% )  (75.00%)
        18,475,946      LLC-loads:u                      #    3.348 M/sec                       ( +-  0.95% )  (50.00%)
               124      LLC-load-misses:u                #    0.00% of all LL-cache accesses    ( +- 24.54% )  (49.99%)

Rpi5b 2.2.2
 Level   Comp   Comptime min/avg/max/stddev  Decomptime min/avg/max/stddev  Compressed size
 0    100.008%      0.000/0.000/0.000/0.000        0.000/0.000/0.003/0.001       15,737,543
 1     54.185%      0.096/0.109/0.112/0.004        0.028/0.041/0.047/0.005        8,526,745
 2     43.871%      0.184/0.192/0.195/0.003        0.027/0.040/0.044/0.004        6,903,702
 3     42.390%      0.216/0.230/0.236/0.004        0.031/0.040/0.045/0.003        6,670,664
 4     41.644%      0.250/0.262/0.266/0.003        0.024/0.034/0.040/0.004        6,553,205
 5     41.215%      0.276/0.286/0.290/0.004        0.020/0.036/0.040/0.005        6,485,659
 6     41.032%      0.323/0.336/0.340/0.004        0.024/0.036/0.040/0.004        6,456,912
 7     40.778%      0.428/0.446/0.451/0.005        0.028/0.037/0.040/0.003        6,416,941
 8     40.704%      0.562/0.568/0.573/0.002        0.020/0.037/0.040/0.004        6,405,249
 9     40.409%      0.679/0.684/0.688/0.002        0.027/0.037/0.042/0.003        6,358,951

 avg1  48.624%                        0.311                          0.034
 avg2  54.026%                        0.346                          0.038
 tot                                124.488                         13.537       76,515,571

   text    data     bss     dec     hex filename
 109760    1504       8  111272   1b2a8 libz-ng.so.2

Rpi5b Inflate cleanup PR
 Level   Comp   Comptime min/avg/max/stddev  Decomptime min/avg/max/stddev  Compressed size
 0    100.008%      0.000/0.000/0.000/0.000        0.000/0.000/0.000/0.000       15,737,543
 1     54.185%      0.096/0.109/0.112/0.004        0.031/0.040/0.043/0.003        8,526,745
 2     43.871%      0.184/0.192/0.197/0.004        0.025/0.039/0.042/0.004        6,903,702
 3     42.390%      0.226/0.232/0.234/0.002        0.032/0.039/0.044/0.003        6,670,664
 4     41.644%      0.254/0.262/0.266/0.003        0.021/0.035/0.039/0.004        6,553,205
 5     41.215%      0.281/0.288/0.293/0.003        0.030/0.037/0.042/0.003        6,485,659
 6     41.032%      0.319/0.338/0.342/0.004        0.031/0.036/0.039/0.003        6,456,912
 7     40.778%      0.436/0.449/0.452/0.004        0.023/0.034/0.039/0.004        6,416,941
 8     40.704%      0.558/0.570/0.574/0.003        0.020/0.035/0.039/0.005        6,405,249
 9     40.409%      0.681/0.689/0.692/0.003        0.025/0.034/0.038/0.003        6,358,951

 avg1  48.624%                        0.313                          0.033
 avg2  54.026%                        0.348                          0.037
 tot                                125.146                         13.153       76,515,571

   text    data     bss     dec     hex filename
 109496    1504       8  111008   1b1a0 libz-ng.so.2

TLDR;
x86-64 deflatebench: 0.15% speedup
x86-64 perf: 0.069% speedup
Codesize reduced by 672 bytes
Aarch64 deflatebench: 2.83% speedup
Codesize reduced by 264 bytes
All in all it seems likely to be a minor speedup along with a slight reduction of codesize.
It should also make it easier to gain more speed from chunkset code improvements later.

PS: Betatesting coderabbitai, so far it does not seem too intelligent when it comes to these changes 😆

MSVC CI is failing due to warning C4324 (struct padded due to alignment). I don't really think that warning (especially as an error) provides us any benefit at all. The fact that the end of a struct is padded up to the next cacheline boundary is pretty much a non-issue.
@mtl1979 Perhaps we should just disable that warning entirely? It would end up failing if someone compiles with optional features anyway, and it also makes it harder to maintain since not everyone has access to MSVC.

@mtl1979 Perhaps we should just disable that warning entirely? It would end up failing if someone compiles with optional features anyway, and it also makes it harder to maintain since not everyone has access to MSVC.

Some warnings are safe to disable, disabling others can cause crashes or poor performance... We have line in CMakeLists.txt that disables useless warnings.

Some warnings are safe to disable, disabling others can cause crashes or poor performance... We have line in CMakeLists.txt that disables useless warnings.

Yeah, I meant to add a commit that disables that warning here, but instead I managed to push it directly into Develop. Can't force-push without it, so I think we'll just keep it rather than revert it and add it back by PR.


Prettify tasks (preliminary)

Pull Request Test Coverage Report for Build 306

0 of 4 (0.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 63.03%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/seedu/address/ui/TaskCard.java
0
1
0.0%

src/main/java/seedu/address/ui/TaskDetailsPane.java
0
3
0.0%

Totals

Change from base Build 300:
-0.02%

Covered Lines:
1635

Relevant Lines:
2594

💛  - Coveralls


ABAP examples of my Dutch SAP usergroup (VNSG) 2019 presentation

A lot of ABAP examples of new options in ABAP S/4HANA

check conflicts

Conflict resolved


Validation of Content-Type (for JSON requests)

If I have a POST endpoint that accepts JSON, and use webargs for the parsing and validation of that, it will give me an error that all args are missing if the content type of the request is not 'application/json'.
I believe this is incorrect. If I have decided that the endpoint should only accept JSON, I think a mime type error should be thrown if the correct content-type is not used. Otherwise, it is very confusing for the user what is wrong with the request. As a workaround I would do this validation myself within the controller, but since webargs throws the error before the code in the controller gets reached, that is a no-go. The only workaround atm would be to decorate the controller before webargs and check there.
I know this might be outside of webargs area, but I don't know how else to approach this problem (the decorator works but....I mean....so..many...decorators).
If the locations includes JSON, the request header should be checked. That's my opinion.

@fgblomqvist I recommend using a custom parser class. This will allow you to do validate against the request before the parsing is done.
Here is how you'd do it in Flask:
from flask import Flask, jsonify as J, abort
from webargs.flaskparser import FlaskParser, is_json_request
from webargs import fields

app = Flask(__name__)
app.debug = True

class StrictParser(FlaskParser):
    def _parse_request(self, schema, req, locations):
        # return error response if request is not JSON
        if 'json' in locations and not is_json_request(req):
            abort(415)
        return super()._parse_request(schema, req, locations)

parser = StrictParser()
use_args = parser.use_args

@app.route('/json', methods=['POST'])
@use_args({'name': fields.Str()}, locations=['json'])
def echo_json(args):
    return J(args)

@app.errorhandler(415)
def handle_unsupported_media_type(err):
    return J({
        'error': 'Unsupported Media Type'
    }), 415

I see. Looks like a simple enough workaround. What's your opinion on doing this validation by default in webargs? Or rather, what are the arguments against it?

Content-type validation woudn't really make sense when parsing multiple locations, which webargs does by default ('query', 'form', 'json').
parser.parse({'id': fields.Str(), 'page': fields.Int()}, locations=['json', 'query'])

But there will never (and can't) be data in both form and json at the same time, right? And having data in the query and JSON at the same time is allowed, which means that if you expect JSON data (whether you expect query data or not as well) the Content-Type should be set to a JSON one. Or is there a scenario that I am missing in which this is not true? In the scenario you described, the Content-Type should be application/json (or a content type that includes json).

@fgblomqvist Ah woops, I forgot to include form in the locations. Edited the snippet.
If Parser is passed multiple locations, webargs does not know which location will ultimately be used, so how will we know to validate Content-Type?

Ah I see what you're saying. I suppose one way to do it would be to check if locations only contains one item, and that item is json, and if it does, verify content-type. I am just trying to make it more sensible for REST APIs (which afaik do not allow the loose structure you're describing, where a parameter can be in different locations), but I understand if it is too much of an edge-case.
At least there is the workaround you posted earlier.

Yes, I recommend doing content-type validation outside of webargs.
An alternative to my workaround above would be to do the validation in a middleware or hook,  e.g. before_request in Flask:
from flask import Flask, jsonify as J, abort, request
from webargs.flaskparser import use_args
from webargs import fields

app = Flask(__name__)
app.debug = True

@app.route('/json', methods=['POST'])
@use_args({'name': fields.Str()}, locations=['json'])
def echo_json(args):
    return J(args)

# Require that all requests have a JSON Content-Type
@app.before_request
def require_json():
    if not request.is_json:
        abort(415)

@app.errorhandler(415)
def handle_unsupported_media_type(err):
    return J({
        'error': 'Unsupported Media Type'
    }), 415


[rviz_rendering] implement better default scene until we have display types

Right now the default scene is nothing really or not displaying correctly. It is implemented in this function which will probably go away in the future:
https://github.com/ros2/rviz/blob/7d939817a714ae3b6b4bfa3bf08b82c50cf440be/rviz_rendering/src/rviz_rendering/render_window_impl.cpp#L127-L159
We need to get that working and/or update it to have some more compelling content which we can use for debugging until we have some display types ported from rviz.

I tried inserting the grid from rviz into the scene.
The result looks like this:

I guess this should be enough for now?

Looks like we might want to do something with the lighting (not sure if the sphere is just that color or if it has no light), but otherwise, yeah it looks better.

not sure if the sphere is just that color or if it has no light

There is light in the scene, the sphere material just does not reflect it.
We will fix this and create a PR for the issue.


Add function to bulk add gift card information

This relates to #67 and #132
See this wireframe page as example: https://moqups.com/smartchicago/W9OgjlHV/p:a4288ea2a
We want to add gift card information for multiple testers at one time. This will be useful for both recent sign-up gift cards or test gift cards where we are adding information for many testers at one time.

The Mailed checkbox would be a confirmation for the submission and does not need to be stored in the database.

The Test Gift Cards section is mostly filled out before the test/event. After event if the person did not attend the gift card could be removed from the test+person association

This is done for sign-ups. Therefore, I am adding the "Waiting on Merge" label.
We need to think about the full structure of the test/event pages, which will be work that comes later.

For our current needs, this is working well. In the future, we will think more about adding gift cards for tests. I am closing this issue now.


Added ComponentDecomposer

Codecov Report

Merging #232 into master will increase coverage by 0.17%.
The diff coverage is 94.28%.

@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
+ Coverage   88.33%   88.50%   +0.17%
==========================================
  Files          16       16
  Lines        1714     1749      +35
==========================================
+ Hits         1514     1548      +34
- Misses        200      201       +1

Impacted Files
Coverage Δ

hybrid/decomposers.py
88.01% <94.28%> (+1.06%)
:arrow_up:

hybrid/flow.py
93.07% <0.00%> (+0.27%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3ff544...8205ddd. Read the comment docs.


Increase gradle logging to --info

Currently gradle is logging at the default level of lifecycle. Increasing to info will show more about what work gradle is doing, such as re-downloading dependencies vs checksumming them, etc.

Follow this checklist to help us incorporate your contribution quickly and easily:

[N/A] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[N/A] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.

[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Please also update https://github.com/apache/beam/blob/master/.test-infra/jenkins/job_beam_PreCommit_Go_GradleBuild.groovy

Done

run seed job

run java gradle precommit

Curiously, I'm not seeing a lot of the logging that I get locally - in particular on the cmdline I definitely see messages about which deps are cached and which are fetched. Hmm.

If this doesn't work, revert it?

It definitely works to get more info, just not all the info seemingly.


Add back interaction

This PR adds back in the chart interaction, with the goal of providing the name of the feature, its type (pool/flux/example), its volume/rate, an image and a definition. We may later also add in a link to WSS page, if available.
Initial plan:
Have a tooltip div that would be in a fixed location and would be populated and updated as you moused over the chart elements.
As I started to implement this I realized it would be pretty tedious to get it to fit on the page in a good position at all page sizes, and with varying amounts of content (e.g. definitions of different lengths, image or no image).
Adapted implementation:
I realized what might be best was using a card that would pop up and then could be closed. I found a youTube tutorial for creating dialogs in Vue, and figured if I could get a button set up so that it launched a dialog box within 20 minutes then I'd go ahead and see if I could get it to work for the interaction. The tutorial was great and it ended up being pretty straightforward to set up a dialog Vue component and then set up a function to customize the dialog card. I think this will be really easy to adapt and use for other projects.
The interaction is triggered when you click on fully transparent rectangles that span the full width of the chart (including y-axis labels).
It looks like this:

Not yet addressed

There needs to be some indication (visual or a text prompt) that the user can click on the chart elements to pull up additional information
Not all of the features have definitions currently - I only pasted in the first few
Not all of the features have images
The card needs to be styled

How are you envisioning the layout and functionality on mobile? That seems important to address now that the main components are all here.

Yes, mobile gets tricky. From an interaction standpoint I think the pop-up card works well on mobile - better even than a mouseover div would. I think the chart layout is more challenging. As is, the y-axis labels take up a bunch of the space, and the x-axis is pretty illegible :/

We could attempt something like this (but styled better):

I did chat w/ Elmera, Althea and Mandy a bit, and we figured that in school (but perhaps not outside of school) students would primarily be using tablets or laptops, so that may lower the importance of getting the mobile view perfect, at least for the MVP.

I like this adding the text to the chart directly to save space. I'm assuming this is mobile in browser view? It would be worth checking out to see how the text sizing ends up. If the chart takes the full screen then clicking to get a pop-up could make it hard to scroll, but at the same time, we don't really need anything other than the chart.

Yup this is just mobile in browser view -so might not be accurate. I am curious if it would be easy to inadvertently trigger a 'click' event when scrolling, or if the screens are calibrated to distinguish between those movements pretty well.


⚠ Bofrost.be has degraded performance

In bf7aa7b, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1072 ms

Resolved: Bofrost.be performance has improved in 76973ea after 6 minutes.


Add TSV, CSV types

Also some line ordering and whitespace cleanups.

Could you make those changes please? Not sure which spec and what the order would be with my additions.
From: Sean McArthur
Sent: zondag 8 oktober 2017 17:42
To: hyperium/mime
Cc: Sander Maijers; Author
Subject: Re: [hyperium/mime] Add TSV, CSV types (#63)
@seanmonstar commented on this pull request.
In src/lib.rs:

 TEXT_XML, "text/xml", 4;

TEXT_EVENT_STREAM, "text/event-stream", 4;

IMAGE_STAR, "image/*", 5;
IMAGE_JPEG, "image/jpeg", 5;
IMAGE_GIF, "image/gif", 5;
IMAGE_PNG, "image/png", 5;
IMAGE_BMP, "image/bmp", 5;

APPLICATION_JSON, "application/json", 11;
APPLICATION_WWW_FORM_URLENCODED, "application/x-www-form-urlencoded", 11;
APPLICATION_OCTET_STREAM, "application/octet-stream", 11;
APPLICATION_MSGPACK, "application/msgpack", 11;

MULTIPART_FORM_DATA, "multipart/form-data", 9;
The ordering here was actually just matching the order the types are in described in the spec... Can we leave it that way for now?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Merged manually in https://github.com/hyperium/mime/commit/2eea649b27e8c01cb29ebb60f689463908682e52.
Thanks!

@seanmonstar: I think you left out the test code, did you?

I did. It wasn't necessary to have tests matching on the contents of every constant (though, the macro does automatically add tests that the indices in the macro are correct). Those tests are just making sure case-insensitivity is used, and the existing tests already do that.


Test $apply implementation

Task Description

ONA plans to use $apply on a project and would like to review its readiness by accomplishing the following tasks:

Implementation Plan

[ ]  Test $apply using the examples provided by the SDK.
[ ]  Test $apply using the Measles content available on the [Smart Immunizations IG](https://github.com/WorldHealthOrganization/smart-immunizations/blob/cleanup/input/resources/plandefinition/IMMZ.DT.08.Measles.json).
[ ]  Write documentation that highlights the following items:

[ ]  Does $apply work with the example content in the SDK?

If not, where does it fail?

[ ]  Does $apply work with the content in the IG?

If not, where does it fail? What is the difference between the resources in the IG and the ones in the SDK examples?
[ ]  Does $apply generate the expected resources from the IG content? The expected resources are:

[ ]  CarePlan
[ ]  ImmunizationRecommendation

@f-odhiambo @jingtang10 @pld @fredhersch @litlfred

Next steps are to test the $apply with PlanDefs here


How do I get hid keyboard information

How to disable the output of information after obtaining it
An answer would be highly appreciated

How to disable the output of information after obtaining it
An answer would be highly appreciated

What exactly do you mean?


Switched to CMake build method; moved Boost files into separate folder

https://github.com/steamclock/internetmap/issues/447
Short story:
New version of Android Studio caused the project to "build symbols" for ~20 mins each time the project was opened / the C files were changed.
Fix

It is recommended that projects move from the old ndk build method, to using CMake. I believe I have managed to convert the .mk file over to a CMakeLists.txr file. While this sped up indexing a little, the project was still seeing ~12 min indexing times.
Android project is using the C++ Boost library; these header files were in the same folder as the Android-NDK project files and I believe that even though we could not see them in the project, they were still being indexed. I moved these files out to their own folder (Android-Boost), updated the build file and the project builds very quick now with a minimal indexing step.

I would like to push this forward so that moving on I do not have to wait 20 mins each time I open the project, however, I am nervous to change the build method right before shipping.
Your thoughts are appreciated!

Seems like a sensible change to me. I share the concern about switching th build process right before shipping, but I THINK that's unnecessary anxiety in this case, the build process does not seem like it's something that would subtly fail
RE: boost. From a quick look it looks like it's only used to get the shared_ptr class, which is SUPPOSED to be part of the C++ standard library. I assume that was done as a work around for some ancient version of the C++ standard library where that was missing or broken, so I strongly suspect that could be removed now. Not sure if you want to take that on as well at this point though, but maybe once v1 is out the door we should see if we can ditch boost.

For the record, this PR is blocked on being merged since the APKs it creates don't install on (at least some) supported devices. The buddybuild error was “The selected application variant/abi may not be available for download”

Perhaps this is a BuddyBuild issue. The log file for the "successful" build is empty. Maybe there is something different with their NDK setup.

Red herring!
Actually this appeared to be a keystore issue, not an NDK issue. I had recently updated BuddyBuild to use the "upload" keystore we have moved to using (allowing us to use the Google key signing method, where they hold onto our private keystore). I had apparently set this up incorrectly. Once I removed the duplicate key I had accidentally uploaded, the APK downloads from BB correctly.

Once I am back from vacation let's do a larger test on this branch and merge it in for the next iteration.

I have gone through and done another pass through buddy build with these changes and the APK is successfully downloaded and installed on my devices. The changes to the upload keystore appear to have solved the BuddyBuild issue.

Confirmed - can upload BB APK (which uses our upload key) to the Google Play store correctly.

Merged / squashed manually. Closing PR.


Prevent modal from being closed by clicking outside

Is there a way to prevent the modal from being closed by clicking outside of it?

Found that backdrop: 'static' option solves this.


[feature] Is it possible to make the fields of Range public?

⭐ Suggestion

I'm making an R binding to ast-grep that mimicks the Python API. For the range() function, I'd like to access the start and end values of the Range struct but apparently those two fields are private. Is it possible to make them public?
💻 Use Cases

To return the start and end values to R, I must be able to access them (I can't return the Range struct at once).

You can already access them via node.range()
Example code
https://github.com/ast-grep/ast-grep/blob/989f040efdb24ac4923f35e7e2b37b77b8033cd7/crates/pyo3/src/range.rs#L100-L112

Indeed, thank you and sorry for bothering

If you are integrating ast-grep into other programming language, the napi and pyo3 folders will be very helpful.
One particular thing you may need pay attention to is the text encoding. Tree-sitter returns a byte offset in utf8 or utf16, which is usually not how programming languages handle character offsets.

Another repo for reference https://github.com/Zheaoli/astgrep-java-unonfficial

Thanks for the hints, I'm definitely following the pyo3 implementation


Blank screen building a basic ionic 4 app

Hi, I'm trying to build my first app using PGB. I'm using a very basic app created by Ionic 4 . The debug apk, generated by ionic cordova commands, works fine when deployed on a mobile or on an emulator . When builded by PGB shows me only a blank page. I'm neither able to debug it by chrome inspector . I used pgb-cli but I also tried packaging manually the source code in a zip file.
Thank you in advance for your help
Dario

I solved. Simply my mistake in packaging the app.
Thank you
Dario


The punycode module is deprecated

The punycode module is deprecated, please fix it as soon as possible

Nothing to do with notion.

I'm getting a warning when using notion SDK
(node:30366) [DEP0040] DeprecationWarning: The punycodemodule is deprecated. Please use a userland alternative instead. (Usenode --trace-deprecation ... to show where the warning was created)

Looks like an issue with v20+ and older version of pnpm on my end. update of pnpm fixed it.

Yes the error pops on Node v20+ but it's due to whatwg-url dependency imported by node-fetch. The v3.x of node-fetch fix the problem. I will be good if notion can update this dependency.


CORS issue when running in Ionic/Cordova on iOS

Hi,
we are running into issues with the CORS preflight request when using the library in a Ionic/Cordova project on iOS.

As can be seen in the screenshot, Ionic uses a custom schema on iOS which does not pass the CORS preflight request on the MangoPay servers. Is there any way to bypass this error?
Thank you.

Im having a CORS issue as well when using registerCard method on ionic 4 on chrome preview.

Hi @raphaelstz and @andufratu
This issue is ongoing, we'll keep you updated,
Max

Hi @andufratu , @raphaelstz
Enacting changes to how our API, as well as that of banking partners, processes the origin header is not something we can easily enact.
This resources talks about a few solutions
https://fdezromero.com/cors-errors-in-ionic-apps/
We have prioritized this issue on our roadmap, but cannot give a delivery date at this stage.
Best,
Max

@mangomaxoasis, unfortunately those solutions can't be applied in this case, since the failing requests are made from the MangoPay library and we have no way to intercept them.

Hi ,
We are currently looking into a plugin for Cordova, but it's an ongoing subject.
Here is another solution, a bit more manual but still nice.
As the issue seems to be specific to IOS, for the card registration function (which is where the problem is, as it calls a banking partner from the front end)
Can you try replacing JS code with code from the IOS card reg kit in objC.
https://github.com/Mangopay/cardregistration-ios-kit/blob/master/mangopay/MPAPIClient.h
Cordova offers the option of adding in native code where appropriate.
As such the request will come from the device, not necessarily the browser.

HI Guys,
The inclusion of native code is what we deem the best solution in the medium term.
I'm closing this issue.
max


Add Vidyard

Is the "Get Help" button only available when you're logged in? Looking through that page, I don't see it.

It is visible in the bottom right-hand corner. Additionally, the "Submit a request" link in the header achieves the same action.

What information do they require to request account deletion?

I just provided the email address of the account. I couldn't login on their support page, only on their main page (apparently using different accounts) so I submitted my request without being logged in. In the whole process, they didn't even verify the request with a confirmation I'd have to send from my email address meaning I could have deleted someone else's account by providing their email address.

What follow-up occurs to that request?

Two mails from their side:

acknowledgment of receipt
deletion confirmation

Overall, the request was fulfilled within 48 hours. After that, a login returned Incorrect username or password, so I assume it has been fully deleted.

Thank you for your contribution, and for responding to feedback so promptly!


feat: add provider migrations

This PR implements provider migrations to allow for smooth transitions between major versions.
Changes

Add JoshProvider.Options#allowMigrations optional property
Add JoshProvider#resolveVersion() protected method
Add JoshProvider#version abstract method
Add JoshProvider#migrations property
Add functionality for migrations in the JoshProvider#init() method

This has been resolved by the @joshdb/provider package


UG-641 Remove neutron checksum workaround

The checksum addition using this method was very
unreliable, so in OSA it was added [1] in a more
robust way to the neutron role and removed from
run-playbooks [2].
RPC-O therefore inherits it and does not need
to do this any more. In fact it may interfere
with it so it's better not to use this hack.
[1] https://review.openstack.org/330405
[2] https://review.openstack.org/330389

recheck_cit_trusty_majorupgrade_ceph
recheck_cit_trusty_majorupgrade_swift


Do you plan to give the code for fine-tuning？

Hello,
I want to reproduce the VQA task, so do you have any plans to give code about fine-tuning?
Thank you!

+1, one more person also waiting the code :)

+1, one more person also waiting the code :)

what about using this https://github.com/mlfoundations/open_clip#fine-tuning-coca ? openclip implementation is based on this repo and has pretrained models + doc on how to fine tune

@yuzexing  @rom1504 what Romain said


camunda-modeler: 5.23.0 -> 5.25.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/camunda/camunda-modeler/releases.
meta.description for camunda-modeler is: An integrated modeling solution for BPMN, DMN and Forms based on bpmn.io
meta.homepage for camunda-modeler is: https://github.com/camunda/camunda-modeler
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 5.24.0 with grep in /nix/store/jrbpxqq0m8xzcl4z6wxv5ax4cwc8i8nm-camunda-modeler-5.24.0
found 5.24.0 in filename of file in /nix/store/jrbpxqq0m8xzcl4z6wxv5ax4cwc8i8nm-camunda-modeler-5.24.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

camunda-modeler

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/jrbpxqq0m8xzcl4z6wxv5ax4cwc8i8nm-camunda-modeler-5.24.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A camunda-modeler https://github.com/r-ryantm/nixpkgs/archive/f7d8b1d08d27ffe103b284e19c4da4822ccca560.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/f7d8b1d08d27ffe103b284e19c4da4822ccca560#camunda-modeler

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/jrbpxqq0m8xzcl4z6wxv5ax4cwc8i8nm-camunda-modeler-5.24.0
ls -la /nix/store/jrbpxqq0m8xzcl4z6wxv5ax4cwc8i8nm-camunda-modeler-5.24.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

camunda-modeler

Maintainer pings
cc @n0emis @vidister @johannwagner @yu-re-ka for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/camunda-modeler/versions.
meta.description for camunda-modeler is: An integrated modeling solution for BPMN, DMN and Forms based on bpmn.io
meta.homepage for camunda-modeler is: https://github.com/camunda/camunda-modeler
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 5.25.0 with grep in /nix/store/lmqgr5xyf36qj9bsjyrh0sgyd2whv9wv-camunda-modeler-5.25.0
found 5.25.0 in filename of file in /nix/store/lmqgr5xyf36qj9bsjyrh0sgyd2whv9wv-camunda-modeler-5.25.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

camunda-modeler

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/lmqgr5xyf36qj9bsjyrh0sgyd2whv9wv-camunda-modeler-5.25.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A camunda-modeler https://github.com/r-ryantm/nixpkgs/archive/91603e9ddd3e95b619d9450f820e3efd2e690405.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/91603e9ddd3e95b619d9450f820e3efd2e690405#camunda-modeler

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/lmqgr5xyf36qj9bsjyrh0sgyd2whv9wv-camunda-modeler-5.25.0
ls -la /nix/store/lmqgr5xyf36qj9bsjyrh0sgyd2whv9wv-camunda-modeler-5.25.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

camunda-modeler

Maintainer pings
cc @n0emis @vidister @johannwagner @yu-re-ka for testing.


chore(release): 1.0.0 [skip ci]

Summary
Updates version to 1.0.0
Checklist

[x] Does your PR title have the correct title format?
Does your PR have a breaking change?:  No

Did 1.0 release using semantic-release commit message instead.


Allow to set username and dbname when using Socket connexion

Allow to connect to pgsql with socket setting user and dbname.
Now, if you set host or port parameter it will use tcp connexion but without it will use socket connexion the same way pgsql does.
I also did some double assignment cleanup.

Hi,
Thank you for your patch.
Unfortunately, I'm afraid this could harm a lot of existing setups relying on this current default, consciously or not.
I kind of remember this default is set to localhost to be compatible with microsoft OS, when they were not supporting non-networking sockets.

Allow to connect to pgsql with socket setting user and dbname

This is still possible, but admittedly you have to give more arguments than with psql. Indeed, the -h arg is not for tcp-only remote host, you can use -h /path/to/socket/folder if you want to connect through unix socket:
$ perl -l check_pgactivity -s connection -h /tmp -p 15433
POSTGRES_CONNECTION OK: Connection successful at 2021-03-26 16:59:39.374157+01, on PostgreSQL 13.1 on x86_64-pc-linux-gnu, compiled by gcc (Debian 8.3.0-6) 8.3.0, 64-bit

$ ls -l /tmp/.s.PGSQL.15433
srwxrwxrwx 1 ioguix ioguix 0 mars  26 16:36 /tmp/.s.PGSQL.15433

Thanks for your reply, I didn't notice that -h could be used for a socket. I think that solve my problem.
I agree with you about the fact it could break existings setups. Too bad it can't use the same default as pgsql.


issue: changes made into S17-IR-2017

@dimitargnikolov
I made all the required changes. Some places I have introduced new sections and paragraphs to support or backup claims and have provided references for them. I have also added a disadvantages section as requested. Please let me know if any further changes are required to make this look better. I changed the conclusion but I am little not sure if it still needs improvement. Please let me know how can I improve that and I will work on that.
Thanks for showing my mistakes. Your comments were helpful when I was working on making the changes.
veera marni.
S17-IR-2017

@narayana1043, we were working on the second batch of papers, so I haven't been able to get to this yet. I will work on reviewing the edits to paper 1 this week, and will let you know if anything else is needed. Thanks!

Thanks!
veera


DevTools updates in Firefox 81

Acceptance criteria
The following bugs are dev-doc-complete, BCD is updated, an entry to Firefox release notes is added, experimental features page is updated, the content has been reviewed as needed.

[x] Debugger should show TypeScript icon for .TSX files — this is a very small update, probably just a line in the rel notes plus a small mention somewhere suitable in the debugger documentation.

[x] [ruleview] Implement the inline CSS compatibility warning in ruleview — probably fairly small, sounds like it is to do with a new compatibility tooltip in the rules view of the inspector. Needs further investigation.

[ ] Expose line-wrap as option in the debugger — Again, small, this is probably referring to the new Linewrap option in the debugger context menu and gear menu. Just needs a rel note, and a small bit of content adding to the debugger docs.

[ ] Fix color vision deficiency simulations — needs a bit of updating in the a11y inspector simulation page. comment 13 explains what is needed.

[x] Provide autocompletion when adding a new class to an element — Pretty small. Sebastian's comment at the top explains exactly what is being added, and it works fine, simple to test.

Estimated total: 1.5 days work.

@hamishwillee can I get you to have a look at these ones please?

[ ] Debugger should show TypeScript icon for .TSX files — this is a very small update, probably just a line in the rel notes plus a small mention somewhere suitable in the debugger documentation.

[ ] Release Note added

[ ] Docs update info on file type icons. Not going to do. This isn't mentioned anywhere and I don't see a need to add any either, as the meaning of the icons is completely obvious when you're in the context.

@chrisdavidmills This is just a release node. Ready for you to review.

[ ] [ruleview] Implement the inline CSS compatibility warning in ruleview — probably fairly small, sounds like it is to do with a new compatibility tooltip in the rules view of the inspector. Needs further investigation.

Review

Yes, this is a tooltip that should appear next to CSS rule that has incompatibility. See example

I can't reproduce this on FF81 or FF83 so waiting on more info here - in case it needs to be enabled somehow.
Not clear if this just reflects incompatible current version or specific version. Asked about that too.

As for documentation, will need:

[ ] Release note

[ ] Update to Examine and edit CSS - probably just update/new image to end of the the first section (Examine CSS rules)

So, this one is waiting on waiting on more info here](https://bugzilla.mozilla.org/show_bug.cgi?id=1649021#c12)

@chrisdavidmills I can't find a topic that says how to set a preference in firefox. What most people seem to do is just assume people know how to set preferences OR duplicate some text "open about:config in URL bar". Is there a topic? If not then propose I create a minimal one below https://wiki.developer.mozilla.org/en-US/docs/Tools and then link to this whenever we refer to a preference. Thoughts?

[ ] Expose line-wrap as option in the debugger — Again, small, this is probably referring to the new Linewrap option in the debugger context menu and gear menu. Just needs a rel note, and a small bit of content adding to the debugger docs.

[ ] Debugger UI Tour > Source pane added new section on the end (search "The source pane provides the following context menu options")

@chrisdavidmills Need info on two items that I don't know what are for (Jump to generated location, Show inline preview)

[ ] Debugger UI Tour > Source pane - updated image of current Settings and added line for info on the Wrap option.

[ ] Release note added

@chrisdavidmills Other than point above in Source Pane, this ready for review

[ ] Fix color vision deficiency simulations — needs a bit of updating in the a11y inspector simulation page. comment 13 explains what is needed.

[ ] Updated Color vision simulation

removed the three "omaly" simulations that are no longer in FF81.
Added note explaining that. I chose not to explain why they are not needed (essentially if the remaining simulations are the "worse case" of the condition described by the removed simulations - so if you design for the worse case it works for all cases).
Separate note about the source paper for the algorithms used.
Updated the example images.

[ ] Release note added

[ ] Open question on whether webrender needed

[ ] Provide autocompletion when adding a new class to an element — Pretty small. Sebastian's comment at the top explains exactly what is being added, and it works fine, simple to test.

[ ] Docs update to Examine and edit CSS > Viewing and changing classes on an element. In this case was already documented. All I did was add version info.

[ ] Release note added

@chrisdavidmills This one ready for review

"Debugger should show TypeScript icon for .TSX files " review — yup, looks absolutely fine.
"[ruleview] Implement the inline CSS compatibility warning in ruleview" review:

Content looks good; I tweaked the "Examine and edit CSS" page a bit a little bit, adding in a couple of headings to break up the content bit.
I removed the rel note from the 82 page, because it is not currently enabled by default. In such cases, we usually put an entry on the https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Experimental_features page. Can you add one please?

"Expose line-wrap as option in the debugger" review — yup, looks fine, apart form the two options we don't know the purpose of ;-)
Did you ping anyone about these?

"Fix color vision deficiency simulations" review — looks good. I just added a call to the toolssidebar macro on the main Color vision simulation page, so that it shows the main sidebar of the section.

"Provide autocompletion when adding a new class to an element" review — yup, looks fine.
I'm closing this one, as the bits left are very small.

"Expose line-wrap as option in the debugger" review — yup, looks fine, apart form the two options we don't know the purpose of ;-)

Did you ping anyone about these?
@chrisdavidmills No, I was hoping you might know - or know best person to ask :-).
They aren't related to the specific bugfix so didn't think it right to ask that developer.
Who would you ask?
Thanks for review. I'll chase the minor bits left.

"Expose line-wrap as option in the debugger" review — yup, looks fine, apart form the two options we don't know the purpose of ;-)

Did you ping anyone about these?
@chrisdavidmills No, I was hoping you might know - or know best person to ask :-).
They aren't related to the specific bugfix so didn't think it right to ask that developer.
Who would you ask?

No worries. I went into the DevTools Matrix room and asked for help, and Nicolas Chevobbe gave me some perfect descriptions, which I've filled in on the page. Problem solved.

@chrisdavidmills Thanks

Re "I went into the DevTools Matrix room and asked for help, and Nicolas Chevobbe gave me some perfect descriptions, which I've filled in on the page. Problem solved."

if you want me to be able to do this myself in future you're going to have to tell me where this room is, and get me access :-)
FYI Experimental features

Added update for "[ruleview] Implement the inline CSS compatibility warning in ruleview" review: bit
Also removed old section on compatibility view (got added "for real" in 77)

if you want me to be able to do this myself in future you're going to have to tell me where this room is, and get me access :-)

Sure thing! You'll find such rooms on the Mozilla Matrix server: https://wiki.mozilla.org/Matrix
Thanks for the other additions too.


Proxy event argument not updating as expected

On Edge (0.8.0). See fiddle: http://jsfiddle.net/kn5wuy34/
The button uses a proxy event on-click="testMe:{{current}}. After the second click of the button, I expect to see the argument update to the current value. (It works as expected on latest)

Thanks! now fixed


Concurrency: Look through l-value types in ActorIsolation::getActor()

When computing the actor type for an expression, be sure to look through l-value types to get the underlying type.
Resolves rdar://139470254.

@swift-ci please smoke test


Update nf-hidsdi-hidd_getproductstring.md

fix links

Thank you as always @DJm00n, this should be live in ~25 minutes


Key forcing the modal to jump up on IOS

Key forcing the modal to jump up on IOS

just use useKeyboardAvoidingView to false


Moving to a GitHub CMS

Here are my requirements for blogging platforms:

Should be easy and fast to update - no long or flaky build process
Should store images easily - as simple as a paste from my clipboard - anything else is unnecessary friction
Should be easily editable from mobile
(optional) should support comment system and different layout formats
(optional) wysiwyg markdown based editing - no funky blocks with lots of lockin

After thinking through local markdown, GraphCMS, Notion, Strapi, Directus, and so on, I've finally settled on using GitHub as a CMS.
I've long admired the OneGraph approach to blogging:

https://github.com/OneGraph/onegraph-blog
https://github.com/OneGraph/onegraph-changelog/issues?q=is%3Aissue+sort%3Aupdated-desc+is%3Aclosed+label%3APublish

However their use of Relay is a bit too high overhead for me. So I built my own using just the GitHub REST API.
The primary problem with GH's API is that it rate limits at 5000 requests an hour, which is dicey for a high traffic blog. So either you prerender at build, or you cache on request (we can also cache on build). Netlify's On Demand Builders are a partial solution to this - partial because content updates will not be respected. I think this is an acceptable tradeoff for all the other functionality github as a cms offers.
The PR for doing this is available here: https://github.com/sw-yx/swyxkit/pull/9
Edit: users may also want to explore using Utterances for authed comments https://github.com/utterance/utterances

this is a test comment

Lorem, ipsum dolor sit amet consectetur adipisicing elit. Corrupti fugiat quod non ipsum perspiciatis voluptatum pariatur explicabo enim, suscipit sapiente, quo perferendis amet sint voluptates. Quibusdam ullam voluptatibus expedita repudiandae quos tenetur, modi eligendi eos. Sit cum unde dolor assumenda error, suscipit earum, corrupti molestias vero quae incidunt enim aspernatur magni inventore reprehenderit esse rerum quas, at itaque? Autem repellendus cupiditate natus vero inventore sit! Excepturi expedita optio in! Sapiente rerum fuga dignissimos odit iure laboriosam earum non dolores obcaecati repellendus ipsum minus enim eum et, totam facere? Doloribus autem sed magni nobis aspernatur nulla officiis impedit nostrum obcaecati assumenda!

How long does it take for new reactions to come on the netlify rendered blog?

So I can't see my comment edits on the rendered blog because I think that is due to the edge caching you mentioned on netlify?
But before opening up the netlify site, I added some reactions to your comments and even those were not visible for me when I visited the site for the first time.

yeah because i cache the api response for 1min-1hr.
i think if you retry on incognito it will work
i have not implemented reactions on comments yet… pr welcome for that one haha

test comments for testing markdown rendering in comments
Snarkdown

Snarkdown is easy to use!
Here's an important anchor link.
Two newlines creates a line break.
Or, end a line with two spaces.
Just like that!
Code & Poetry
You can also indent
blocks to display
code or poetry.

Indented code/poetry blocks
can be hard-wrapped.

Or, wrap your code in three backticks:
function codeBlocks() {
    return 'Can be inser
}

Block Quotes

You can insert quotes by
preceeding each line with >.
Blockquotes can also contain line
breaks.

Lists

Unordered

Lists

Of mixed type

Ordered
Lists
Numbers are ignored

noice.

i fixed the buggy snarkdown rendering with the string replace recommended here https://github.com/developit/snarkdown/issues/69

This is really cool!

wow is amazing

Curious to see if it supports syntax highlighting for a given language
function veryCool() {
   console.log('awesome approach!')
}

haha no, because this is all rendered clientside and i didnt want to add extra js weight, but you should be able to add highlight.js easily

Hello
It will be awesome if this can work ;)

Hello
It will be awesome if this can work ;)

It would be a major security flaw if this would work ;)


After Upgrading NativeBase Unit Tests Fail to Render

Description
After upgrading Native Base to the latest version, Unit Tests fail to render and React is defined as being null
CodeSandbox/Snack link
private project
Steps to reproduce
I've added a basic setup below, by following the react-native testing library i've created a custom render function. However with the NativeBaseProvider component added I receive this error:

NativeBase Version
3.4.17
Platform

[X] Android
[ ] CRA
[ ] Expo
[X] iOS
[ ] Next

Other Platform
No response
Additional Information
Utils
import { render, RenderOptions } from '@testing-library/react-native';
import 'jest-styled-components/native';
import React from 'react';
import { theme as lightTheme } from 'src/themes/index';
import { ThemeProvider } from 'styled-components/native';
import { NativeBaseProvider } from 'native-base';

const inset = {
  frame: { x: 0, y: 0, width: 0, height: 0 },
  insets: { top: 0, left: 0, right: 0, bottom: 0 },
};

const WithThemeProviders: React.FC = ({ children }) => {
  return (
    <NativeBaseProvider initialWindowMetrics={inset}>
      <ThemeProvider theme={lightTheme}>{children} </ThemeProvider>
    </NativeBaseProvider>
  );
};

const customRender = (
  ui: React.ReactElement,
  options?: RenderOptions
): ReturnType<typeof render> =>
  render(ui, { wrapper: WithThemeProviders, ...options });

// re-export everything
export * from '@testing-library/react-native';
// override render method
export { customRender as render };

Badge Test
import Bagde from '@components/atoms/Bagde';
import React from 'react';
import { render } from '__tests__/utils';

describe('[Atom] Bagde', () => {
  beforeEach(() => {
    jest.resetModules();
  });

  it('should render', () => {
    const { getByTestId } = render(<Bagde value="new" />);
    const text = getByTestId('badge-text');
    expect(text).toHaveTextContent('new');
  });

});

Badge
import React from 'react';
import { View, Text } from 'react-native';

interface Props {
  value: string;
}

const Badge: React.FC<Props> = ({ value }) => {
  return (
    <View style={{ backgroundColor: 'blue' }}>
      <Text>{value}</Text>
    </View>
  );
};

export default Badge;

Hey @SirFitz , Thanks for reporting. We will look into it


Missing heading for _defacemask ?

In the current specification, it seems that we're missing a heading for the _defacemask suffix, or perhaps that the information was missed in a restructuring.
Specifically, looking here: https://bids-specification.readthedocs.io/en/stable/04-modality-specific-files/01-magnetic-resonance-imaging-data.html#the-rec-entity
It seems that the _defacemask suffix is only defined as part of the rec entity. It would make sense to either add a new heading here or consolidate it in the MRI modality label section: https://bids-specification.readthedocs.io/en/stable/04-modality-specific-files/01-magnetic-resonance-imaging-data.html#anatomy-imaging-data

Actually, the table immediately below describing ContrastBolusIngredient clearly belongs to the ce entity, so rec itself should be moved, along with the _defacemask suffix !


[API] rdp input scancodes mess

in current master df3737b085de8e907020faf7b9d6f0eee303f419  function freerdp_input_send_keyboard_event can't handle input code achieved from RDP_SCANCODE_LWIN, which returning 347 which failing  at WINPR_ASSERT(code <= UINT8_MAX); ( https://github.com/FreeRDP/FreeRDP/blob/master/libfreerdp/core/input.c#L301 ), this change introduced in 5fb59a23a9f25f5996d7b015e20dcb5ce31208fb
before this assert i have succesfully used this macros (RDP_SCANCODE_LWIN) and it worked properly.

casting to uint8_t seems works, i guess instead of assert, function signature should be changed to accept uint8_t type instead of uint16_t

Your code is wrong, see freerdp_input_send_keyboard_event_ex for correct usage of said API.

As for the ASSERT, it might be a good idea to change that to a warning log though.


Bring in latest changes

This PR is simply intended as an easy way to both (a) merge the latest changes from Au main into your PR, and (b) apply one small tweak to the variable name.
Right now, there are 4 commits.  Two of them are commits that have landed to the upstream main.  The third is a merge commit (which also takes care of resolving the logical merge conflict that arose).  The fourth just tweaks the variable name.
I believe the right steps would be:

Sync your fork's main with the upstream aurora-opensource/au main.
Merge this PR to your branch.

NOTE: I've never tried doing exactly this before, but it feels like it should work.  :sweat_smile:

We no longer need this PR, because the contributed commits have already now been merged to Au's main in a different PR.


Add host hook support

These hooks will run on the host rather than the app.
Host hooks are defined in deploy/host-pre-deploy and deploy/host-post-deploy.

Thansk @doctaweeks


When remove component : Null check operator used on a null value.

What happened?
      Non-fatal Exception: io.flutter.plugins.firebase.crashlytics.FlutterError: Null check operator used on a null value. Error thrown .
   at Component._remove.<fn>(component.dart:971)
   at Iterable.every(dart:core)
   at Component.propagateToChildren(component.dart:374)
   at Component._remove(component.dart:961)
   at Component.handleLifecycleEventRemove(component.dart:820)
   at ComponentTreeRoot.processLifecycleEvents(component_tree_root.dart:95)
   at FlameGame.updateTree(flame_game.dart:158)
   at FlameGame.update(flame_game.dart:152)
   at GameWidgetState.build.<fn>.<fn>.<fn>(game_widget.dart:387)
   at GameWidgetState._protectedBuild(game_widget.dart:228)
   at GameWidgetState.build.<fn>.<fn>(game_widget.dart:376)
   at _LayoutBuilderElement._layout.layoutCallback(layout_builder.dart:139)
   at BuildOwner.buildScope(framework.dart:2844)
   at _LayoutBuilderElement._layout(layout_builder.dart:173)
   at RenderObject.invokeLayoutCallback.<fn>(object.dart:2686)
   at PipelineOwner._enableMutationsToDirtySubtrees(object.dart:1097)
   at RenderObject.invokeLayoutCallback(object.dart:2686)
   at RenderConstrainedLayoutBuilder.rebuildIfNecessary(layout_builder.dart:248)
   at _RenderLayoutBuilder.performLayout(layout_builder.dart:331)
   at RenderObject._layoutWithoutResize(object.dart:2414)
   at PipelineOwner.flushLayout(object.dart:1051)
   at PipelineOwner.flushLayout(object.dart:1064)
   at RendererBinding.drawFrame(binding.dart:582)
   at WidgetsBinding.drawFrame(binding.dart:991)
   at RendererBinding._handlePersistentFrameCallback(binding.dart:448)
   at SchedulerBinding._invokeFrameCallback(binding.dart:1386)
   at SchedulerBinding.handleDrawFrame(binding.dart:1311)
   at SchedulerBinding._handleDrawFrame(binding.dart:1169)

What do you expect?
 void _remove() {
    assert(_parent != null, 'Trying to remove a component with no parent');

    _parent!.children.remove(this);
    propagateToChildren(
      (Component component) {
        component
          ..onRemove()
          .._unregisterKey()
          .._clearMountedBit()
          .._clearRemovingBit()
          .._setRemovedBit()
          .._removeCompleter?.complete()   // here is async func call. when exec, where jump other code and may change _parent value, it cause null pointer check error?
          .._removeCompleter = null
   //        .._parent!.onChildrenChanged(component, ChildrenChangeType.removed)  // error in here
          .._parent?.onChildrenChanged(component, ChildrenChangeType.removed)   // may use ? instead !
          .._parent = null;
        return true;
      },
      includeSelf: true,
    );
  }

How can we reproduce this?
on flame-1.17.0 and flutter 3.19.5
What steps should take to fix this?
No response
Do have an example of where the bug occurs?
No response
Relevant log output
No response
Execute in a terminal and put output into the code block below
Output of: flutter doctor -v
Affected platforms
Android
Other information
No response
Are you interested in working on a PR for this?

[X] I want to work on this

You're trying to remove a component that doesn't have a parent, if running in debug mode you would have hit the assertion in the top before this.
I'd suggest you look into where you're trying to remove an unmounted component.

@spydon OK, let me a try.

@pakeng did you find out anything more?


TypeError: instance is undefined

Hi,
TypeError: instance is undefined
instance.setFinalDate.call(instance, method);
I am getting above error in console when i added the code like
$(document).ready(function() {
$("#getting-started").countdown("2016/10/10", function(event) {
$(this).html(event.strftime('%D days %H:%M:%S'));
});
});
can anyone help
thanks in advance

Please be more descriptive, and even provide a JSFiddle with your problem, from the stack trace you described and your piece of code, I would infer that the problem is somewhere else.


Stream-based I/O examples/documentation

Great looking project!
The blog post [1] mentions "Google Cloud Platform–compatible stream-based I/O (stream indices from Google Cloud Services!)" as a feature.
As far as I can tell, the only mention in the Python docs of streaming I/O is the use of file-like objects for the save and load methods on Index [2,3]. Could we have specific GCP guidance? Is the recommendation to work with streaming upload/download objects from GCS? [4] From reading the GCP docs, I don't get the impression that that enables what I think the blog post suggests.
[1] https://engineering.atspotify.com/2023/10/introducing-voyager-spotifys-new-nearest-neighbor-search-library/
[2] https://spotify.github.io/voyager/python/reference.html#voyager.Index.save
[3] https://spotify.github.io/voyager/python/reference.html#voyager.Index.load
[4] https://cloud.google.com/storage/docs/streaming-downloads#storage-stream-download-object-python

Perfect - thank you!


Can't open with android studio.

I have this error when trying to open the project in android studio
Error:(3, 0) Cause: org/gradle/api/publication/maven/internal/DefaultMavenFactory

I have some problem. Hope, somebody help us.

This can be a problem with your gradle version, sometimes you have an installation of gradle in your machine and the project try to use another.. Try change your settings inside IDE preferences in: Build, Execution, Deployment > Build Tools > Gradle > Project-level settings to Use default gradle wrapper

@vitorprado Thanks I'll try it.

@EgyptianM @elkyzmich problem solved?

@vitorprado Yes, thanks a lot

@EgyptianM @florent37 can you close the issue? thanks.

Hello @vitorprado
I did what you said but unfortunately I have this error now
Error:(14, 0) Plugin with id 'io.fabric' not found.
Thank you for your efforts

@EgyptianM add to gradle
dependencies {
classpath 'io.fabric.tools:gradle:1.+'
}

@elkyzmich I added but this is what I got
Error:Could not find any version that matches io.fabric.tools:gradle:1.+.

@EgyptianM follow this: https://docs.fabric.io/android/fabric/integration.html
it's not a problem related to the lib.. it's another gradle problem.
I think you should close the issue.

OK thank you very much.


It would be nicer to have more logging.

For medium/ bigger size cubes, no logging is done between
Starting analysis for cube '***'
Original dimension order for cube '***' is

and
Completed analysis for cube '***'
Updated dimension order for cube '***' to [

Once they are hooked up for analysis it would be nicer to have logs written for every update_storage_dimension_order with the result.

Yeah, that's a fair point. I think we can add those log statements. I will add create a PR.
Thanks for bringing this up!


[QUESTION]  pod CrashLoopBackOff

Question

Error starting CSI manager: Failed to initialize Longhorn API client: Get "http://longhorn-backend:9500/v1

Environment:

Longhorn version:longhorn1.1
Kubernetes version:

Client Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.0", GitCommit:"af46c47ce925f4c4ad5cc8d1fca46c7b77d13b38", GitTreeState:"clean", BuildDate:"2020-12-08T17:59:43Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"linux/amd64"}

[root@oc02 ~]# kubectl get pod  -n longhorn-system -o wide
NAME                                       READY   STATUS             RESTARTS   AGE    IP                NODE   NOMINATED NODE   READINESS GATES
csi-attacher-5dcdcd5984-2h25v              1/1     Running            0          4h8m   <IP_ADDRESS>    oc02   <none>           <none>
csi-attacher-5dcdcd5984-btwgk              1/1     Running            0          4h8m   <IP_ADDRESS>    oc02   <none>           <none>
csi-attacher-5dcdcd5984-mqd2v              1/1     Running            0          4h8m   <IP_ADDRESS>    oc01   <none>           <none>
csi-provisioner-5c9dfb6446-nfwcv           1/1     Running            0          4h8m   <IP_ADDRESS>    oc01   <none>           <none>
csi-provisioner-5c9dfb6446-ql9xg           1/1     Running            0          4h8m   <IP_ADDRESS>    oc01   <none>           <none>
csi-provisioner-5c9dfb6446-w8w86           1/1     Running            0          4h8m   <IP_ADDRESS>    oc02   <none>           <none>
csi-resizer-54d484bf8-5tbmj                1/1     Running            0          4h8m   <IP_ADDRESS>    oc02   <none>           <none>
csi-resizer-54d484bf8-8px62                1/1     Running            0          4h8m   <IP_ADDRESS>    oc02   <none>           <none>
csi-resizer-54d484bf8-m9kj8                1/1     Running            0          4h8m   <IP_ADDRESS>    oc01   <none>           <none>
csi-snapshotter-96bfff7c9-gjd42            1/1     Running            0          4h8m   <IP_ADDRESS>   oc02   <none>           <none>
csi-snapshotter-96bfff7c9-pcvwt            1/1     Running            0          4h8m   <IP_ADDRESS>    oc02   <none>           <none>
csi-snapshotter-96bfff7c9-vs7l6            1/1     Running            0          4h8m   <IP_ADDRESS>    oc02   <none>           <none>
engine-image-ei-cf743f9c-4txh7             1/1     Running            0          4h9m   <IP_ADDRESS>    oc01   <none>           <none>
engine-image-ei-cf743f9c-8vtbb             1/1     Running            0          4h9m   <IP_ADDRESS>    oc02   <none>           <none>
instance-manager-e-cc0f605b                1/1     Running            0          4h9m   <IP_ADDRESS>    oc02   <none>           <none>
instance-manager-e-fc1b3bfe                1/1     Running            0          4h9m   <IP_ADDRESS>    oc01   <none>           <none>
instance-manager-r-1a32fd51                1/1     Running            0          4h9m   <IP_ADDRESS>    oc02   <none>           <none>
instance-manager-r-49a026f4                1/1     Running            0          4h9m   <IP_ADDRESS>    oc01   <none>           <none>
longhorn-csi-plugin-446fk                  2/2     Running            0          4h8m   <IP_ADDRESS>    oc01   <none>           <none>
longhorn-csi-plugin-glr28                  1/2     CrashLoopBackOff   8          21m    <IP_ADDRESS>   oc02   <none>           <none>
longhorn-driver-deployer-cdb7464c6-l5zfq   1/1     Running            0          4h9m   <IP_ADDRESS>    oc01   <none>           <none>
longhorn-manager-9zhkr                     1/1     Running            0          4h9m   <IP_ADDRESS>    oc02   <none>           <none>
longhorn-manager-lw8nm                     1/1     Running            2          4h9m   <IP_ADDRESS>    oc01   <none>           <none>
longhorn-ui-849c455d79-q54rv               0/1     CrashLoopBackOff   52         4h9m   <IP_ADDRESS>    oc02   <none>           <none>
[root@oc02 ~]#  kubectl logs pod/longhorn-csi-plugin-glr28 -c longhorn-csi-plugin -n longhorn-system
time="2021-06-01T06:41:47Z" level=info msg="CSI Driver: driver.longhorn.io csiVersion: 0.3.0, manager URL http://longhorn-backend:9500/v1"
time="2021-06-01T06:41:57Z" level=fatal msg="Error starting CSI manager: Failed to initialize Longhorn API client: Get \"http://longhorn-backend:9500/v1\": context deadline exceeded (Client.Timeout exceeded while awaiting headers)"
[root@oc02 ~]#
[root@oc02 ~]# free -m
              total        used        free      shared  buff/cache   available
Mem:           7141        4922        1156         221        1062        1917
Swap:             0           0           0

Hi! Can you provide more host/Kubernetes information as in the template? Please also attach support bundle if possible.  Based on the information currently provided, I suspect that there is resources shortage.  Since there are only two nodes, could set replica number to 2 instead of 3.

Hi! Were you able to resolve the issue?

already work.


Removing VS2012 XDK support

@jasonsandlin,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


problem synching state when using async onJoin

The scenario I'm having is:

onInit() is async. The state is set only after a timeout.
onJoin() is async. The state is mutated once it's ready.

The problem:

The first client doesn't receive the first state, and once it receives the first patch, an error occurs, since there's no first state to apply the patch.

fossil-delta.js:399 Uncaught TypeError: Cannot read property 'length' of undefined
    at Object.fossilDelta.apply

The workaround I've come up with is manually sending the first state when it's ready:
onInit () {
  this.whenStateIsReady = new Promise((resolve, reject) => {
    setTimeout(() => {
      this.setState({ foo: "bar" });
      resolve();
    }, 1000);
  });
}

async onJoin(client) {
  await this.whenStateIsReady;

  // this is required to prevent client-side error
  this.sendState(client);
}

Would be great if the framework can handle this situation internally.

I was having this issue last night - the onInit function was loading stuff from a database, but the onJoin was finishing before onInit was done, so the first client was getting an inconsistent state.  I'll have to use the above to solve my issue.
It would be great if the other events for a room were held until onInit was completed.

This would require this code to handle it being a promise, which would require the entire wrapping method to be async, which breaks API,
If they fix it, it will probably be for v1.0, but not before.
This is probably a right thing to do, usually you want to allow async code.


Erranous deprecation warning?

Hello again!
I think this deprecation warning is incorrect

I think it is due to the placement of this comment:

Just use import { PriorityQueue } from 'priority-queue-typescript';

import PriorityQueue  from 'priority-queue-typescript'; is not treeshaking friendly.

sorry i make a mistake. you can use 2.0.1 version with import { PriorityQueue } from 'priority-queue-typescript'

Tried the new version - something weird is happening to my WebStorm once I've upgraded the lib. WebStorm 'hangs' indefinately, only way I've been able to handle is via force quitting and restarting IDE.
Also, the import from 'priority-queue-typescript' does not seem to work - there is no such module.

Maybe you need to wait for WebStorm to complete indexing?

This is something other than reindexing, which happens in the background.
The whole IDEA freezes, and waiting for 2 minutes is not enough.

You can try version 2.0.3 again. I tried installing the previous versions and found that npm strangely didn't include the dist folder.

Sorry for all the inconvenience

It should work well now - I've thoroughly tested it. I thought this would be a simple change🥹.

no problem at all! glad to be a user and get fixes quickly!!


UnhandledPromiseRejectionWarning thrown when evaluating console.log messages

I'm using this with<EMAIL_ADDRESS>and it seems to be working fine, only for these warnings:
W20180425-12:22:09.984(2)? (STDERR) (node:5656) UnhandledPromiseRejectionWarning: Error: Protocol error (Runtime.callFunctionOn): Target closed.
W20180425-12:22:09.985(2)? (STDERR)     at Promise (/Users/tolga/Work/Paramander/poc-meteor-webshops/dashboard/node_modules/puppeteer/lib/Connection.js:200:56)
W20180425-12:22:09.985(2)? (STDERR)     at new Promise (<anonymous>)
W20180425-12:22:09.986(2)? (STDERR)     at CDPSession.send (/Users/tolga/Work/Paramander/poc-meteor-webshops/dashboard/node_modules/puppeteer/lib/Connection.js:199:12)
W20180425-12:22:09.986(2)? (STDERR)     at ExecutionContext.evaluateHandle (/Users/tolga/Work/Paramander/poc-meteor-webshops/dashboard/node_modules/puppeteer/lib/ExecutionContext.js:73:75)
W20180425-12:22:09.987(2)? (STDERR)     at ExecutionContext.evaluate (/Users/tolga/Work/Paramander/poc-meteor-webshops/dashboard/node_modules/puppeteer/lib/ExecutionContext.js:46:31)
W20180425-12:22:09.987(2)? (STDERR)     at Frame.evaluate (/Users/tolga/Work/Paramander/poc-meteor-webshops/dashboard/node_modules/puppeteer/lib/FrameManager.js:326:20)
W20180425-12:22:09.987(2)? (STDERR)     at <anonymous>
W20180425-12:22:09.988(2)? (STDERR)     at process._tickDomainCallback (internal/process/next_tick.js:228:7)
W20180425-12:22:09.988(2)? (STDERR)  => awaited here:
W20180425-12:22:09.989(2)? (STDERR)     at Function.Promise.await (/Users/tolga/.meteor/packages/promise/.<IP_ADDRESS>c2cbh.t9ga++os+web.browser+web.cordova/npm/node_modules/meteor-promise/promise_server.js:56:12)
W20180425-12:22:09.989(2)? (STDERR)     at Promise.asyncApply (packages/meteortesting:browser-tests/browser/puppeteer.js:36:14)
W20180425-12:22:09.990(2)? (STDERR)     at /Users/tolga/.meteor/packages/promise/.<IP_ADDRESS>c2cbh.t9ga++os+web.browser+web.cordova/npm/node_modules/meteor-promise/fiber_pool.js:43:40
W20180425-12:22:09.990(2)? (STDERR)  => awaited here:
W20180425-12:22:09.990(2)? (STDERR)     at Function.Promise.await (/Users/tolga/.meteor/packages/promise/.<IP_ADDRESS>c2cbh.t9ga++os+web.browser+web.cordova/npm/node_modules/meteor-promise/promise_server.js:56:12)
W20180425-12:22:09.991(2)? (STDERR)     at Promise.asyncApply (packages/meteortesting:browser-tests/browser/puppeteer.js:46:9)
W20180425-12:22:09.991(2)? (STDERR)     at /Users/tolga/.meteor/packages/promise/.<IP_ADDRESS>c2cbh.t9ga++os+web.browser+web.cordova/npm/node_modules/meteor-promise/fiber_pool.js:43:40
W20180425-12:22:09.992(2)? (STDERR) (node:5656) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
W20180425-12:22:09.992(2)? (STDERR) (node:5656) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

So a few of these console logs are throwing, but they are not being handled correctly.

Could you please try if you still get the same error when using<EMAIL_ADDRESS>Have you tried debugging which error message this happens with? Maybe this would reveal a hint ...

@SimonSimCity The error message is quite clear.
using await without a catch block will raise this warning.

Yeah I'll just close this for now, as I just downgraded to 1.2.0 and that's what the README seems to include.

@tolgap Not quite. I also had an error which could easily be blamed to have the same source as yours (see: https://github.com/meteortesting/meteor-browser-tests/pull/14) which actually was caused by something completely different.
Actually, I get a similar error as you here when using the test-reporter dot. My error sounds like the headless-browser is cleaning off it's resources while another task is trying to read the last entries of the console.log() calls.
If you can't reproduce yours in v1.4.0 of puppeteer, I'll try to fix the one I now got and ignore your report here.
FYI: The README advises you to use ^1.2.0 as package selector for puppeteer which allows npm to use any 1.x release that is equal or greater to 1.2.0 - which includes an update to 1.4.0 😉  If you did this pretty recently, chances are quite high that npm actually installed 1.4.0 for you. Could you have a quick look at your package-lock.json?


Add date interval validation rules

Updated the data validation code to include date interval checks.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

47 of 52 (90.38%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.1%) to 96.724%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/Rules/Cell/ComboDateInterval.php
47
52
90.38%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
2598

Relevant Lines:
2686

💛  - Coveralls


Add base and dev dependencies to pyproject.toml

Core libraries:

Geospatial

GeoPandas
Pandas (explicit versioning)
Numpy (explicit versioning)
Shapely (explicit versioning)
H3 (4.0 is in alpha, 3.7.4 is current version)

Utility

tqdm (alive-bar as alternative)

Test useful libraries for parallelization:

numba?
dask?
celery XD
ray
swifter
pandarallel

Optional dependencies:

Visualization

seaborn (optional)
leaflet

ML / AI - training

Scikit (?)
PyTorch
PyTorchGeo

OpenStreetMap (test what will be useful)

OSMPythonTools
osmnx

Development:

black
isort
flake8

Docs (select one):

sphinx
quattro
MkDocs (fastapi uses this one)
diagrams library (generating diagrams as a code)

Add useful libraries:

PyFunctional
more-itertools (add only when needed)

Progress bar: I'd suggest using alive-progress since it's more responsive and prettier than tqdm imo.

Progress bar: I'd suggest using alive-progress since it's more responsive and prettier than tqdm IMO. And it works with prints and logger out of the box.

Looks really good and I think we can try it. Just wondering how it cooperates with e.g. pandas, where with tqdm you can do just df.progress_apply(...) and it shows the progress bar right away.
My opinion is to try alive-progress (add as a dev dependency??) and if it doesn't meet our standards then we'll go back to tqdm


Fixed Typographical Errors In The Controller Chart's Readme

@dovholuknf I think I spotted a small error :)

@qrkourier Sure thing!
I just committed the change to the template. Would you like me to undo the change to the markdown file?

@qrkourier Ah, brilliant.
One of the workflows are failing, however:
cat: /tmp/miniziti-client.log: No such file or directory

One of the workflows are failing, however:

I see that, too. If you update your branch from main, you'll have a pinned version of the CI script before the bug was introduced. Then it should work.

@qrkourier All done :)


my pc shows this when i am trying to enter any song

Describe your bug here. Mind you, if you are modding, please try testing your bug in a clean version of the engine instead, this ensures the bug is actually caused by the engine itself. Also, if you're using an older version of JSE, please try the latest action build in the Actions tab or the latest release build. The issue has probably been fixed since that version.
my pc shows this when i am trying to enter any song and then crashes

i don't know why is that, but it started from v32 or v33 i don't remember and it is still here on v35! Pls fix
Command Prompt/Terminal logs (if existing)
No response
Have you identified any steps to reproduce the bug? If so, please describe them below in as much detail as possible. Use images if possible.
Enter ANY song (even tutorial works) in freeplay

Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
No only put few folders and a zipfile in mods
If you use 1.12.0 or earlier, did you have Optimized Chart Loading turned on?
None
Did you check for any similar issues to what you're reporting? Check, then come back here. If there is a similar issue, then do not report the issue, otherwise it will be marked as a duplicate.
Yes

you reported this in the rewrite repo, not the main repo


docs: remove stdout from pip install (for gymnasium)

Could add > /dev/null so it doesn't emit next time


branch refactoring

we have minimum two branches in Github.

[x] main branch (please rename master to this)
(only after review can be pushed here)
[x] integrity branch.
(only points to git commits of the main branch that become integrity tested. Integrity tests cost money since they create VMs on cloud providers and therefore commits to be integrity tested should be carefully selected)

Please add also a
27 branch that points to the release 27.0
and tag in there also the release 27.1
please protect the brances adequately.
Releases will be documented in RELEASE.md

integration test branch cfg + dummy script are there; still need to add the actual integration test execution, though (.ci/run_integration_tests)