cmake: Add user-defined APPEND_{CPP,C,CXX,LD}FLAGS

This PR implements the CMake WG design decision made during the call on 2024-04-18.
$ cmake -B build -LH 2>&1 | grep -B 1 -e EXTRA_
// Extra C compiler flags.
EXTRA_CFLAGS:STRING=
--
// Extra (Objective) C/C++ preprocessor flags.
EXTRA_CPPFLAGS:STRING=
--
// Extra (Objective) C++ compiler flags.
EXTRA_CXXFLAGS:STRING=
--
// Extra linker flags.
EXTRA_LDFLAGS:STRING=

To test this PR, I suggest to observe raw build logs using the --verbose command-line option.
The related https://github.com/hebasto/bitcoin/pull/93 is to be reworked on top of this PR.

The recent push to https://github.com/bitcoin/bitcoin/pull/29790 (the pr29790.21+cmake157 tag) demonstrates the new approach in CI scripts.

Rebased to resolve conflicts.

@vasild
Thank you for your review!

Approach ACK f77ab70
Would be nice to have:

Deduplicate the code from subtree_add_library and bitcoincore_add_library

Elaborate the comment at cmake: Add user-defined EXTRA_{CPP,C,CXX,LD}FLAGS #157 (comment)

Rename to APPEND_ or LATE_

Your feedback has been addressed.

FWIW, the Qt 6 uses a quite similar approach.
From Professional CMake: A Practical Guide 18th Edition:

Qt 6 provides more automated handling of Qt-specific aspects of target creation. Certain additional processing needs to occur after targets have been defined, but that processing is usually deferred to the end of the scope in which the target is created. This is called target finalization. It is usually deferred so that the project has an opportunity to modify target properties which affect finalization.
Qt sets up finalization of targets through wrappers around the standard add_executable() and add_library() commands. These wrappers are qt_add_executable() and qt_add_library(), which can be used as drop-in replacements for their corresponding built-in CMake counterparts.

Rebased.

Works as expected, except then linking -pthread ... appear after the append flags

This is expected as -pthread is a transitive link requirement of the bitcoin_util library: https://github.com/hebasto/bitcoin/blob/2dc63ca292e1681520a0564509b533e6794c377d/src/util/CMakeLists.txt#L45-L50

This is expected as -pthread is a transitive link requirement of the bitcoin_util library:

I think you'll need to explain this further. The point of these options is to always have the last say, so it's not at all expected that some options would still be added after these flags.

Works as expected, except then ... -fPIE -pie appear after the append flags...

Well, that's annoying.

Why is that?

This is because CMake treats Position Independent Code /Executable as abstractions with internal implementation of the logic for applying the related compile and linker flags.

It makes it impossible to append -fno-PIE.

I have no solution for that at the moment.

When -pthread is provided, it is required to resolve particular symbols, which makes CMake treat it as any other -l option. It is expected that a linker fails if any symbol remains unresolved. Therefore, overriding -pthread seems has no use cases.

This doesn't explain why it's appearing after our options on the link line? Wether or not overriding it may or may not have use is mostly irrelevant. The fact it's appearing on the line after our options points to this not completely working like we intend.

When -pthread is provided, it is required to resolve particular symbols, which makes CMake treat it as any other -l option. It is expected that a linker fails if any symbol remains unresolved. Therefore, overriding -pthread seems has no use cases.

This doesn't explain why it's appearing after our options on the link line?

"... which makes CMake treat it as any other -l option"
The -l option must appears after an object that uses symbols resolved in a following library. CMake lists objects/archives after other options when invoking a linker.
Again, this can be fixed, if there are reasons for that.

Works as expected, except then linking -pthread and -fPIE -pie appear after the append flags...

Please consider an alternative implementation in https://github.com/hebasto/bitcoin/pull/184.

Closing in favour of #184.


Firefox addon throwing Xray Vision error (especially on initial load)

In Firefox the addon sometimes fails to load. It reliably fails the first time a leaderboard should be loaded for the first time.
Reproduce
Steps to reproduce this bug:

Open Firefox with the add on installed
Go to https://adventofcode.com/2024/leaderboard/private
Open the developer tools, Storage tab, and clear al localStorage (leave dev tools open)
Click the "[View]" link to show your own private leaderboard

Expected result: leaderboard with the extension's graphs loaded
Actual result: no graphs or anything, and an error on the console

Relevant console output:
ℹ [app.js:1814:17] Loading via readyState = interactive
ℹ [app.js:1809:17] Going to construct App
ℹ [app.js:793:21]  Constructing App
ℹ [app.js:485:17]  Getting cache aoc-data-v1-/2024/leaderboard/private/view/277259
ℹ [app.js:618:25]  Found cache null
ℹ [app.js:632:25]  Loading data from url https://adventofcode.com/2024/leaderboard/private/view/277259.json
ℹ [app.js:490:17]  Updating cache
🛑 [app.js:265:17]  Error: Not allowed to define cross-origin object as property on [Object] or [Array] XrayWrapper
🛑                  Uncaught (in promise) InternalError: Promise rejection value is a non-unwrappable cross-compartment wrapper.

In a screenshot:

Details
At least reproducible on:

Ubuntu 24
Firefox 132.0.1 (64-bit), installed as a Snap
Addon version 7.0.0

Further resources
https://firefox-source-docs.mozilla.org/dom/scriptSecurity/xray_vision.html

I have a hunch, but not a clear idea of what's causing this issue, or how to properly solve it. I presume it is because I rely on mutating an object here:
https://github.com/jeroenheijmans/advent-of-code-charts/blob/1fa3ce574103704b557625a4ad1f0ce71806915a/src/js/app.js#L255-L270
Especially line 265 (where it crashes).
Perhaps the solution would be to clone the json before I start mutating it like that?
I don't feel much for including Firefox-specific code in the addon to battle this (something with "waiving xray stuff" seems an alternative otherwise).
At this particular moment I have no bandwidth to fix it myself, but would welcome a simple PR that would fix things.
Luckily it seems Firefox will load the addon after a single refresh.

Presuming this was fixed with #106 - release is pending at review stage with Mozilla. If it fails to solve things we'll reopen this issue.


list and preview shared charts

@DTAIEB adds a new menu to the admin console that lists and previews shared charts

@vabarbosa great addition thanks! we should think about adding pagination in the future


Ubuntu 22.04 Debian package missing dependency on libssh2

Contour Terminal version
<IP_ADDRESS>42
Installer source
GitHub: release page
Operating System
Ubuntu 22.04.3 LTS
Architecture
x86-64
Other Software
No response
Steps to reproduce
wget https://github.com/contour-terminal/contour/releases/download/v<IP_ADDRESS>42/contour-<IP_ADDRESS>42-ubuntu22.04-amd64.deb
sudo apt remove libssh2-1
sudo apt install ./contour-<IP_ADDRESS>42-ubuntu22.04-amd64.deb
contour
contour: error while loading shared libraries: libssh2.so.1: cannot open shared object file: No such file or directory
Expected Behavior
For libssh2 to be installed automatically as a dependency of the Debian package.
Actual Behavior
Contour won't launch unless I manually install libssh2-1.
Additional notes
No response

what if you include --fix-broken as apt argument, will it resolve this issue?

contour uses libssh2 when user specify remote server instead of shell and we can not make debian to install additional packages from inside package itself, thus i am closing this one


Supporte v6

Thank you for making this package available.
Do you already have plans to support version 6?
How can I work with you in this process?

Hey @cgslivre!
I'm currently working on the next version, which will certainly remove the need for the formRequest decorator. Stay tuned!
Unfortunately, I can't focus only on OSS, as I work and do a PhD.

If you need help, I'm here.


Running local-cluster using  make cluster-up fails when kind is not pre-installed

I encountered this issue when reviewing the PR
When I run make cluster-up I see the following
 🔆🔆🔆  Ensuring all tools are installed  🔆🔆🔆
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 🔔 installing all tools ...
 🔔 installing controller-gen with version: v0.12.1
go: downloading sigs.k8s.io/controller-tools v0.12.1
go: downloading github.com/spf13/cobra v1.7.0
go: downloading k8s.io/api v0.27.1
go: downloading k8s.io/apimachinery v0.27.1

But the command failed on a machine with no pre-installed kind
Starting kind with cluster name kind
 ❯ kind create cluster --name=kind -v6 --config=/home/parsingh/go/src/github.com/test-pr/kepler-operator/tmp/local-dev-cluster/tmp/kind/kind.yml

/home/parsingh/go/src/github.com/test-pr/kepler-operator/tmp/local-dev-cluster/lib/utils.sh: line 50: kind: command not found
make: *** [Makefile:120: cluster-up] Error 127

Shouldn't the make command ensures that we have kind pre-installed as well?
I will open a corresponding issue in the kepler-operator

For this, I believe we added a check in local-dev-cluster to validate whether kind is available or not but looks like the check didn't work as expected as I think it found kubectl to be available. Will work on fixing this

closing this as resolved by https://github.com/sustainable-computing-io/local-dev-cluster/pull/50


Some links in the docs need to be fixed

Describe the bug
Update broken links in the faer documentation for sparse matrices.
To Reproduce
Steps to reproduce the behavior:

Go to https://faer-rs.github.io/sparse.html
Click on SparseColMator its (mutable) reference variant

Expected behavior
The link should be updated to the following.
Screenshots

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Additional context
I couldn't find the source code that generates the doc, if you point me to it I can make a PR resolving this issue.

thanks! should be fixed now


Application Form - Communities and Household information

As a data team
I need the "communities and household count" data in one place
so that I can easily pull it into my GIS analysis
Currently the community and household count data is being collected in an xls  (template 9)

Form section name:
"Communities and Household Information"
Fields:
GeoName ID - Number
BC Geographic Name - text
Number of Households proposed to be served - Number

It may be early to have an issue for this since we're still exploring the options. Discussions on Figma, Mural, and meetings with NWBC & data team are still ongoing.

@elliottSlee  if we log this user story in the backlog then we can add to it whatever option we end up deciding on.  My priority here is to estimate the effort required for the solution we decide to implement.  I think the use story is true to our understanding just now.

Template 9 is also stored in Research files.
Note This can change and may not update this file. The source of truth is the one linked in the issue description above.

Split into:

uploading map & loading map into UI
creating list of communities


Elastic-Harvest should automatically generate collectionLookup object.

Previously, Elastic-Harvest needed users to manually generate a collectionLookup object that it would used to figure out which collections to search for associated documents. We want this collectionLookup object to be automatically generated.

https://github.com/agco-adm/elastic-harvest/commit/b1ae1f0060b0954a51db2cf76c425d99b959404c


Add support for .edn / EDN syntax (identical to Clojure)

Hello! I'm a Clojure programmer, and it seems like highlight.js could easily support EDN syntax highlighting by adding "edn" to the Clojure aliases. EDN is to Clojure what JSON is to JS. The syntax highlighting is equivalent. Is this reasonable? I use Gitea and the EDN files do not get any syntax highlighting.
https://github.com/highlightjs/highlight.js/blob/8358762bbf3f92bd45919a7893071944fc8574fd/src/languages/clojure.js#L146

Perhaps.  Is this an official part of Clojure or some 3rd party library? Please provide a link so I could learn more.
It's easy enough to add your own aliases though:
hljs.registerAliases(["end"],{ languageName: "clojure" })

Hi! Yes I can provide more info. I didn't know that about JSON syntax being way different from JS! Maybe not a good comparison at all. I was just trying to say it's a subset of Clojure syntax.
EDN is definitely an official part of Clojure. Here is the official specification from the core clojure team. Clojure has built in support for working with it. Here is the overview from the offical spec:

edn is an extensible data notation. A superset of edn is used by Clojure to represent programs, and it is used by Datomic and other applications as a data transfer format. This spec describes edn in isolation from those and other specific use cases, to help facilitate implementation of readers and writers in other languages, and for other uses.

At a glance it seems this is indeed a subset of Clojure so I think this is something we could do.  A PR would be welcome.


Problem with special characters in form select using materialize style

This line of code is problematic if you have special characters such as double quotes in your option name :
var $newSelect = $('<input type="text" class="select-dropdown" readonly="true" ' + (($select.is(':disabled')) ? 'disabled' : '') + ' data-activates="select-options-' + uniqueID +'" value="'+ label.html() +'"/>');
Since the html of the option is added directly as the value of the input, it breaks if there are double quotes.

When submitting some code, please provide in a complete format, otherwise somebody else will have to write the rest of it to test it. Also, as indicated in the contributing, it would be even better if a codepen is submitted with an example illustrating the issue.
In the example you are providing, unless I'm not understanding you incorrectly, your issue arises because you are creating a string to create an HTML element (I assume to then append to the DOM as inner HTML). If that is the case, then it's not really the Materialize framework that fails to sanitize the input, but the fact that you'd be adding data directly into a string without ensuring it is sanitised. If I am mistaken, could you provide a working example?

Sorry if that wasn't very clear. Here's a codepen showing the problem : http://codepen.io/anon/pen/MwPQwv
Basically, when you have double quotes in an  's text, even if they're written as entities ", it breaks when Materialize initializes the select and tries to put the option's text in the value attribute of its input text.
The line of code I was refering to is line 345 in forms.js where Materialize creates that input text with the value.
Here's a screenshot in the inspector. Hope that was more clear.

Right, I see now that the code posted was forms.js#L345 as you've pointed out, which isn't properly sanitising the data to be embed it into the html.

fixed in 1b92fb2


Move Trace exporters to Dapr core and add OpenTelemetry support

In what area(s)?

/area runtime
/area docs
/area test-and-release
Proposal
In https://github.com/dapr/dapr/issues/1080 we updated documentation using Local Forwarder to OpenTelemetry Collector. That opens the possibility to rely solely on OpenTelemetry Collector for our trace extensions and avoid maintaining an extension point for the exporter components since OpenTelemetry Collector already supports all trace backends that we currently support and several more.
Before OpenTelemetry is GA, however, we will keep supporting Zipkin protocol as it is well understood by many tracing backends. This will help ensure existing tracing setups documented in our samples continue to work without big changes. In addition to that, we will keep supporting Zipkin for some time even after OpenTelemetry is GA to allow time for backends to add direct support for OpenTelemetry GA and also time for our users to migrate.
Since supporting both Zipkin and OpenTelemetry we already have enough coverage, we will deprecate the exporter components and will move Zipkin & OpenTelemetry tracing support into Dapr core.
Required changes
Before OpenTelemetry GA

[x] Extend our Configuration CRD to support the new field tracing.zipkin.endpointAddress (https://github.com/dapr/dapr/issues/2521)

apiVersion: dapr.io/v1alpha1
kind: Configuration
metadata:
  name: tracing
spec:
  tracing:
    samplingRate: "1"
+   # new section to include Zipkin configurations. Currently we only need endpoint
+   # but going forward we may consider things like API key as well.
+   zipkin:
+     endpointAddress: "https://zipkin.default.svc.cluster.local:9411/api/v2/spans"

[x] Move the Zipkin trace exporter into dapr/dapr, consuming the new field tracing.zipkin.endpointAddress (https://github.com/dapr/dapr/issues/2522)

[x] Update Tracing section of Configuration (https://github.com/dapr/docs/issues/978)

[x] Update CLI to move default Zipkin component into default Configuration (https://github.com/dapr/cli/issues/534)

[x] Update Dapr diagnosis with tracing how-tos (https://github.com/dapr/docs/issues/967)

[x] Update Dapr Observability Quickstart (https://github.com/dapr/quickstarts/issues/336)

[x] Advertise/announce the deprecation of the trace exporter extension point, as well as new documents (https://github.com/dapr/docs/issues/967, https://github.com/dapr/java-sdk/issues/404)

[ ] Add an end to end tests that validate trace receipt (possibly through the logging exporter of OpenTelemetry collector)

After OpenTelemetry GA (blocked)

[ ] Extend our Configuration CRD to support the new field tracing.opentelemetry.endpointAddress. Add tracing implementation for OpenTelemetry.

apiVersion: dapr.io/v1alpha1
kind: Configuration
metadata:
  name: tracing
spec:
  tracing:
    samplingRate: "1"
+   # new section to include OpenTelemetry configurations
+   opentelemetry:
+     endpointAddress: "..."

[ ] Add samples to use OpenTelemetry protocol

cc @yaron2 @msfussell @youngbupark can you please help review?  Thanks

Very clear write up.
Re the "However, moving to OpenTelemetry Collector will require the installation of the OpenTelemetry Collector process (in self-hosted mode), or Pods (on Kubernetes). On Kubernetes, this moves the default installation from 5 Pods (dashboard, operator, placement, sentry, sidecar-injector) to 6 Pods. The gain in functionalities may justify this foot-print increase" - I agree with this decision. Operational telemetry and diagnostics are essential for any K8s deployment.
Feedback

Can you include a Prometheus example also for metrics? (Example should be a separate configuration)
Q: Should we enable more than one collector? e.g. Prometheus and OpenTelemetry? I see no reason to prevent this, although unusual.
The default for v.10 RC1 release will remain Prometheus for metrics. Later in v1.0 RC2 release we can change this.
Need to test to ensure that OT collector works with ZipKin and AppInsight
I think you missed that by default in the slef-hosted experience we would also install the OpenTelemetry collector for ZipKin to maintain parity. Or at leas make this clear in point 2 above on installation (both K8s and self-hosted)

Very clear write up.
Re the "However, moving to OpenTelemetry Collector will require the installation of the OpenTelemetry Collector process (in self-hosted mode), or Pods (on Kubernetes). On Kubernetes, this moves the default installation from 5 Pods (dashboard, operator, placement, sentry, sidecar-injector) to 6 Pods. The gain in functionalities may justify this foot-print increase" - I agree with this decision. Operational telemetry and diagnostics are essential for any K8s deployment.

Thanks!

Feedback

Can you include a Prometheus example also for metrics? (Example should be a separate configuration)

My understanding is that since Prometheus is a scraper, we don't need any Prometheus configuration on our side. Dapr sidecar exposes a port that speaks Prometheus and that's it (cc @yaron2 @youngbupark)

Q: Should we enable more than one collector? e.g. Prometheus and OpenTelemetry? I see no reason to prevent this, although unusual.

I think since they are sort of different model (Prometheus: pull, OpenTelemetry: push), so it may be a bit less unusual to have them both? (cc @youngbupark)

The default for v.10 RC1 release will remain Prometheus for metrics. Later in v1.0 RC2 release we can change this.

Since daprd will serve Prometheus metrics always when metrics is enabled, I think this point means that we will update docs to use OpenTelemetry for metrics post-RC1. This sounds good to me. Thanks for pointing out.

Need to test to ensure that OT collector works with ZipKin and AppInsight

Updated. Thanks for pointing out.

I think you missed that by default in the slef-hosted experience we would also install the OpenTelemetry collector for ZipKin to maintain parity. Or at leas make this clear in point 2 above on installation (both K8s and self-hosted)

Updated. Thanks

@msfussell I've put the work items into v1.0-rc1 and v1.0-rc2 parts. Since we have about 3 days left before code freeze for v1.0-rc1 I didn't put a whole lot of items in there. Let me know if this split looks good to you.

Feedback

Can you include a Prometheus example also for metrics? (Example should be a separate configuration)

My understanding is that since Prometheus is a scraper, we don't need any Prometheus configuration on our side. Dapr sidecar exposes a port that speaks Prometheus and that's it (cc @yaron2 @youngbupark)

The configuration for prometheus can be set by command flags now e.g. -metrics-port. I would keep these configuration as is. Prometheus is de facto metric backend. Most of CNCF projects use prometheus by default. If metric.enabled is true without opentelemetry, then prometheus will be an exporter for metric. it will not break the existing scenario.

Q: Should we enable more than one collector? e.g. Prometheus and OpenTelemetry? I see no reason to prevent this, although unusual.

I think since they are sort of different model (Prometheus: pull, OpenTelemetry: push), so it may be a bit less unusual to have them both? (cc @youngbupark)

To be clear, Prometheus is not a collector, but also metric backend. it has its own storage to aggregate and store metrics. Opentelemetry collector is just a collector.
So the answer is that it's up to user's infra. If user's existing infra uses prometheus for metrics, they still need prometheus even if they use opentelemetry collector.

The default for v.10 RC1 release will remain Prometheus for metrics. Later in v1.0 RC2 release we can change this.

Since daprd will serve Prometheus metrics always when metrics is enabled, I think this point means that we will update docs to use OpenTelemetry for metrics post-RC1. This sounds good to me. Thanks for pointing out.

For this, we need to listen to customer feedback before deprecating prometheus exporter for metric.

@tcnghia I think we need to think about how to handle control plane services' metrics.

The current implementation of the Azure Monitor exporter that talks to App Insights seems to support traces only.

The current implementation of the Azure Monitor exporter that talks to App Insights seems to support traces only.

This is true. We leverage otel collector exporter to emit trace to app insights. this exporter supports only trace.

I've updated the plan with new proposal. TL;DR: we want to keep Zipkin support as the main tracing format before we completely switch to OpenTelemetry. This ensures that most users are not affected, and also reduce the number of work items.

@tcnghia - Is this now complete and can this be closed?

@tcnghia - Is this now complete and can this be closed?

@msfussell we still need an E2E test (before 1.0) and the  OpenTelemetry migration (after 1.0)

@msfussell we still need an E2E test (before 1.0) and the  OpenTelemetry migration (after 1.0)

Since OpenTelemetry is not yet GA, we will push the move to OpenTelemetry post v1.0. I've updated the issue name to match.
cc @msfussell @yaron2


Az.LogicApp module not loaded in Azure CloudShell

Az.LogicApp module needs to be loaded to execute this script. Sometimes in Azure CloudShell this module not loaded at first and this script give error.
As a workaround please execute any command which loads the Az.LogicApp module implicitly like Get-AzLogicApp. After that execute this script to be successful.

The workaround is applicable if you are running the script from local machine.

The problem can be solved with the workaround, so closing this issue.

The workaround is fine but still a valid issue, so re-opening this.


HADOOP-18358. Update commons-math3 from 3.1.1 to 3.6.1.

JIRA. HADOOP-18358. Update commons-math3 from 3.1.1 to 3.6.1.
I found that commons-math3 can be upgraded from 3.1.1 to 3.6.1. Try to upgrade, local compilation and verification are correct.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 13s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+0 :ok:
shelldocs
0m  1s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 51s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
29m 13s

trunk passed

+1 :green_heart:
compile
26m 37s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
23m 48s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
mvnsite
21m 42s

trunk passed

+1 :green_heart:
javadoc
9m 37s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
8m  4s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
shadedclient
40m 49s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 31s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
25m  2s

the patch passed

+1 :green_heart:
compile
24m 54s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
24m 54s

the patch passed

+1 :green_heart:
compile
22m  1s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
22m  1s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
19m 46s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
javadoc
8m 28s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
7m 22s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
shadedclient
40m 36s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1009m 15s

root in the patch passed.

+1 :green_heart:
asflicense
2m  7s

The patch does not generate ASF License warnings.

1305m 35s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4619/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4619

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs

uname
Linux 410f37ba1ebb 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / be9ec53c2ae2a79852a577bca590e925454d338c

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4619/1/testReport/

Max. process+thread count
2035 (vs. ulimit of 5500)

modules
C: hadoop-project . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4619/1/console

versions
git=2.25.1 maven=3.6.3 shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@ayushtkn Can you help merge this pr into the trunk branch? Thank you very much!

@ayushtkn Thank you very much for your help reviewing the code!


"Trailing punctuation in heading" confuses emoji codes with punctuation

In header like:
# Header :heartpulse:

It can't detect where ":" is for emoji code or it is an unnecessary ":"

Emoji are not part of the CommonMark specification, but I'll look into this.

See #653 for markdown-it plug-in.


Lazy import cuSOLVER

This is a part of #7620.
I tried to softlink cuSOLVER as I did in NVRTC but found there is a native function calls to cuSOLVER in cupy_lapack.h where softlink doesn't work.
For cuSOLVER I'm thinking of using lazy-import instead of softlink.
Depends on ~#7840~ (merged).

What if I change to use dlopen in cupy_lapack.h? Would it help unify the style?

TBH, after working on this PR, I'm a bit surprised how it is simple to lazy-import cuSOLVER than I initially expected. Although I still think soft linking (or cuSOLVER/cuSPARSE/cuFFT/... support in CUDA Python) is something we will need to support "one CuPy package for all CUDA versions", this is not mandatory to achieve #7620 in v13.
For the modules listed in #7620, I'm currently assessing only Runtime & Driver require soft linking, and the remaining can be done just by lazy-importing. I'll next try lazy-importing cuSPARSE and see if my assumption is correct.
As Jitify and CUB modules also have C/C++ level dependencies to CTK, we will need lazy-importing for them anyway.

/test mini

For the modules listed in https://github.com/cupy/cupy/issues/7620, I'm currently assessing only Runtime & Driver require soft linking (which is imported/cimported from many places), and the remaining can be done just by lazy-importing. I'm thinking of next try lazy-importing cuSPARSE and see if my assumption is correct.
As Jitify and CUB modules also have C/C++ level dependencies to CTK, we will need lazy-importing for them anyway.

In light of #7727, I would suggest to always statically link to cudart and soft-link to driver/NVRTC. Then,

this eliminates completely cudart from the discussion
this follows CUDA Python's current approach
the CUB module no longer has external dependency (cudart is its sole dependency)

Is it safe to mix multiple versions of CUDA runtimes within the same process?

If you're referring to static linking to cudart, yes it is safe by design. As long as all DSOs see the same user-mode driver (libcuda), which is already upheld by design, it'd work just fine. Think of it as removing cudart from the dependency chain:
any CUDA library -> libcudart -> libcuda

(btw NVCC by default statically links to cudart, I suspect we don't see that for any CuPy modules because we use gcc instead of nvcc to link, which is also fine, just FYI)

Thanks for the clarification, Leo! Just submitted a PR to static link cudart to CUB (#7850)


TopNavigation's acessory prop problem in ui-kitten ^5

🐛 Bug Report
I'm trying to apply a ReactElement to my TopNavigation's accessoryLeft prop, but it wont accept it unless I make it a () => ReactElement though the node_modules says otherwise, even with this code error, it runs just fine.
Here's the code:

Here's the error:

Here's the node_modules:

Here's the same component, using () => ReactElement

Expected behavior
It should work fine using the ReactElement, just as it does with () => ReactElement
UI Kitten and Eva version

Package
Version

@eva-design/eva
^2.2.0

@ui-kitten/components
5.3.1

Environment information
System:
OS: Linux 6.9 Pop!_OS 22.04 LTS
CPU: (8) x64 Intel(R) Core(TM) i5-1035G1 CPU @ 1.00GHz
Binaries:
Node: 20.0.0 - ~/.nvm/versions/node/v20.0.0/bin/node
Yarn: 1.22.19 - /usr/local/bin/yarn
npm: 9.6.4 - ~/.nvm/versions/node/v20.0.0/bin/npm
npmPackages:
react: 18.3.1 => 18.3.1
react-native: 0.76.3 => 0.76.3

same problem here


Some states of imported clusters can show incorrect content in Config/Edit page

I created a cluster via the 'import' option
Not quite sure what went wrong under the hood with the import, but I could click on that cluster and get to the detail page
Clicking on the Config section showed the same create experience instead of the read-only edit page

This looks like a situation where the corresponding management cluster was never created, which "shouldn't" be happening anymore unless you can still reproduce this reliably @richard-cox .  Editing an imported cluster now goes to the Ember page (for upgrading k3s/rke2 cluster support).

Not able to reproduce this using v2.6.0-rc1
I was able to import an rke cluster using the  "Generic" option of "Import Cluster".
After adding cluster, Dashboard UI shows the page to import hosts:

Upon clikcing the "Config" tab, this page is shown:


Some edits

Add:
Magic Earth
Neo Launcher
Send
ProtonVPN
Remove:
ClearURLs, Decentraleyes, Cookie Autodelete, and Smart Refer (all of these are now included in mainstream browsers)

Hi, thank you. Send by Tim Visée is already on the list.
I will need to review the other suggestions!

I just looked into this as I still use ClearURLs, and it seems uBlock can do something similar, where filter lists can remove query parameters.
One example in the provided filter lists is: Privacy > AdGuard URL Tracking Protection
Is there an appropriate section for such suggestions, as I think only Firefox has made ClearURLs unnecessary and it's still useful on Chromium browsers.

@pluja any reason ProtonVPN isn't on the list?

@TalOrenshtein just added ProtonVPN

ClearURLs, Decentraleyes, Cookie Autodelete, and Smart Refer (all of these are now included in mainstream browsers)

I don't think that these are in all mainstream browsers and also don't think that is significant enough reason to remove them. Browsers can remove these features as easily as they added them.

magic earth should be added


FCM Options Support in WebpushConfig API

Adding the fcm_options parameter to the WebpushConfig type. Change ported from https://github.com/firebase/firebase-admin-node/pull/373
Resolves #203

Resolves #202


fix issue if card file was not qualified

closes https://github.com/IBM-Blockchain/ibm-container-service/issues/51
Signed-off-by: Dave Kelsey<EMAIL_ADDRESS>

Approved by Simon Stone!


New cop: enforce positive ifs

I would like to introduce a new IfPositive cop, which enforces to have positive conditions, present? instead or empty? for example, as they are equivalent just exchanging the if-else branches code and it is more readable as it is easier to think in positive. For example:
# bad
if name.empty?
  @show_table = false
  @name = "undefined"
else
  @name = name
end

# good
if name.present?
  @name = name
else
  @show_table = false
  @name = "undefined"
end

#bad
realname.empty? ? user.login : "#{realname} (#{user.login})"

#good
realname.present? ? "#{realname} (#{user.login})" : user.login

It's a good idea, but we either need to have some mapping of positive to negative mappings in the config of the cop or move this to rubocop-rails, if we're going to hardcode some Rails specific mappings there.

There are some similar cops that already exist to try to enforce positive forms Style/NegatedIf, Style/InverseMethods, Rails/Blank, and Rails/Present.
None of these cops cover the case of converting something.empty? to something.blank? or something.present? because empty? and blank? are not direct synonyms for each other. Although, I guess if the code is checking empty? it implies that the object won't be nil so blank? or present? would be safe to use (unlike checking nil?).
A few people commented on the work we did with safe navigation that they don't like safe navigation chaining because it can change implied behavior of code. If you know something can/will never be nil, don't use safe navigation because it implies the code can return nil. Because of this, I wouldn't want to convert empty? to blank? in all cases. Maybe there could be a configuration on Rails/Blank and Rails/Present to convert calls to empty?.

This is a very poor idea.
"Some string".present?

gives me a NoMethodError (undefined method present?' for "":String)` in Ruby 2.5.1
while
"Some string".empty?

does not.
Such a cop produces therefore tons of messages, which the developer can only stop by disabling the cop. The more such cops exist, the more cops must be disabled.
I think it is not a good idea to pollute rubocop with bad cops, because it encourages to disable cops as soon as possible.
And when I look at your examples: the ifs are "positive" as long as you do not use "not / !". If you have to cover both cases anywas your cop only makes a difference regarding the order of the code.
And last but not least: what is a better choice depends on the context. We already have a cop, which enforces the use of empty?. empty? is an alternative to length == 0. But it is not always a better alternative to length == 0. empty? refers to the state of a container, while length does this too, but the comparison, which is needed can also be seen, that it refers more to the elements of the container than the container itself.
Example:
I have in my project a container "@seen = []". As the name of the variable indicates, it is less important, that the variable is a container compared to the elements, it can contain.
So
if @seen.length == 0

is better than
if @seen.empty?

because I am not interested in the state of the container, because length serves my as an indicator of how many items have been seen. 0 therefore is a better answer to the question "How many?" than "The container is empty". Because from the latter one you have to make an extra step: "When the container is empty it means, that no items have been seen." This is complicated.
The empty? method exists for contexts, where empty? is better than length==0, which means, where the state of the container is in the focus of the code rather than its elements. But the Empty-Cop cannot understand the context, nor does it care, if a empty?-method exists. It just jumps onto the usage of length and does not care, what length means. If you have a class "Line" where the line can have a length, when you test against zero, the cops encourages you to test against empty?. But the method does not exist for good reasons: a line cannot be empty or full.
Therefore the empty-cop is a bad cop, because it pollutes rubocops output with error messages and it encourages to write less readable and less understandable code.

I interpret the rest of your comment as an argument that this cop should not be enabled by default.

I think, even in a rails app, the cop generates bogus messages. I understand the intent regarding ordinary rails models. But you can have much more than just rails models in your rails app. present? makes code more readable, where present? makes the code more understandable from a linguistic point of view. But even an empty string is a string and it is "present" and therefore confusing in some contexts, where length==0 is still better, eg. when counting things.
The cop cannot understand, what you are abstracting and which type of verbosity you need. You can see this also in her example: empty? is not the linguistic opposite of present?, but eg. absent? would be. The opposite of empty? is full? while there also is some state, which is neither empty? nor full?.
If you use "linguistic" method names, they should be used where it makes sense and not all over. But Rubocop encourages to use them all over, because it just spits out an error message which by the user can be seen as an recommendation for writing better code. In many cases the result will be the opposite: less readable code.
The reason for this is simple: for such a cop you need a decent amount of intelligence, because it must also understand the idea and the intent of your code and what you are abstracting about.
Then there is another issue:
"".present? # => false
nil.present? # => false
"".empty? # => true
nil.empty? # => NoMethodError (undefined method `empty?' for nil:NilClass)

And in order to implement a "IfPositive cop" - as suggested, which enforces to have positive conditions, it should test against the usage of a "not (!)" over the whole condition. But even this could be complicated since it should only fire, if the code without "not" is easier to understand.

You can see this also in her example: empty? is not the linguistic opposite of present?

Indeed, a poor choice was made in the original examples here. blank? is the opposite of present? in ActiveSupport.


Dataloader in ruby

If you port DataLoader to another language, please open an issue to include a link from this repository.

Sooo I've implemented a dataloader for ruby. It's not released yet, so I thought I could ask for feedback before it happens. Also ask where to post mentioned a link when the time comes :)
One confusing thing for me: what should happen when batch loader returns nil for some item? Should I reject promise? Or resolve with nil? Other than that, do you want suggest some more test cases? Thanks
https://github.com/sheerun/dataloader

hmm?

Not super familiar with the differences between dataloader and graphql-batch, could you elaborate?

dataloader is more general than graphql-batch (it is based on promises that can be chained together, just like in dataloader. you don't need to use graphql gem at all to use it), has additional configuration options (cache, max_batch_size), and mostly api-compatible this this repository.

Cool! I'm not working in Ruby ATM but I'll check it out next time I am.

no problem. could you post a link from this repository?

I'm not a contributor to dataloader, just an onlooker.

I had a very quick peek at your Ruby implementation. Looks nice. Feel free to submit a PR if you'd like us to add a link to it from the README (you'd need to add an "Other implementations" section near the bottom, after "Common Backends", I think).


signing certificate with Ed25519 key

Hello!
I am not sure if this is the place to put my problem but I either suck at searching the net correctly or there are absolutely no such code examples online. I am a Xamarin dev and we are supposed to create a CSR using Ed25519 keys to certify the app's users to follow the new security guidelines. I have no previous experience with cryptography and security.
The code I have so far is:
static void CreateCertificate()
{
    var serialNo = BigInteger.ProbablePrime(120, new Random());
    var keyPair = GetKeyPair();
    ISignatureFactory signatureFactory = new Asn1SignatureFactory("SHA1WITHECDSA", keyPair.Private, new SecureRandom());

    var certGenerator = new X509V3CertificateGenerator();
    certGenerator.SetIssuerDN(new X509Name(true, "CN=Issuer"));
    certGenerator.SetSubjectDN(new X509Name("CN=Subject"));
    certGenerator.SetSerialNumber(serialNo);
    certGenerator.SetNotAfter(DateTime.UtcNow.AddYears(1));
    certGenerator.SetNotBefore(DateTime.UtcNow);
    certGenerator.SetPublicKey(keyPair.Public);

    var cert = certGenerator.Generate(signatureFactory);
    var certOk = ValidateSelfSignedCert(cert, keyPair.Public);

    if (certOk)
        using (var f = System.IO.File.OpenWrite("ca.cer"))
        {
            var buf = cert.GetEncoded();
            f.Write(buf, 0, buf.Length);
        }
    else
        throw new Exception();
}

static AsymmetricCipherKeyPair GetKeyPair()
{
    var keyPairGenerator = new Ed25519KeyPairGenerator();
    keyPairGenerator.Init(new Ed25519KeyGenerationParameters(new SecureRandom()));
    var keyPair = keyPairGenerator.GenerateKeyPair();
    return keyPair;
}

static bool ValidateSelfSignedCert(X509Certificate cert, ICipherParameters publicKey)
{
    cert.CheckValidity(DateTime.UtcNow);
    var tbsCert = cert.GetTbsCertificate();
    var sig = cert.GetSignature();
    var signer = SignerUtilities.GetSigner(cert.SigAlgName);
    signer.Init(false, publicKey);
    signer.BlockUpdate(tbsCert, 0, tbsCert.Length);
    return signer.VerifySignature(sig);
}

Of course I get an exception when trying to run the Generate() method of the certificate because the private key is not an EC one since the algorithm string I used for the signature factory does not match. None of them in X509Utilities match.
So how can I sign a certificate with an Ed25519 key?
Thank you in advance!
Faye
Edit: After some more digging I came across the FIPS library for C#, so I added the bc-fips-<IP_ADDRESS>.dll to my references, set up its alias to use it independently and tried to use the examples of generating a custom signature factory given in paragraphs 11.3.1, 11.3.2 and 11.3.3 of the Bouncy Castle FIPS .NET API user guide (https://downloads.bouncycastle.org/fips-csharp/BC-FNA-UserGuide-1.0.1.pdf). It is from 2016 so I don't know if it is applicable now because the examples there do not work. The CryptoServicesRegistrar.CreateService() method requires a  type and the argument must be either a IBuilderServiceType, ICryptoServiceType or IFactoryServiceType with the same . From my efforts so far I haven't been able to create a signature factory using an Ed25519 key or any other key for that matter.

After testing myself, Ed25519 (and Ed448) were not supported by Asn1SignatureFactory. I've committed changes to fix this. So you would simply use "Ed25519" for the algorithm string in the Asn1SignatureFactory constructor.
FYI, serial numbers don't need to be prime, just use new BigInteger(120, random). Also, the certificate signature can be checked just using cert.Verify(publicKey).
We will probably release a 2.1.0 version around mid-February, if not earlier.

Thank you so much!


Support simple class with BodySerializationMethod.UrlEncoded

The param is required to implement IDictionary, https://github.com/canton7/RestEase#url-encoded-bodies e.g.
Task Collect([Body(BodySerializationMethod.UrlEncoded)] Dictionary<string, object> data);

Refit can do this, see: https://github.com/paulcbetts/refit#form-posts e.g.
Task Collect([Body(BodySerializationMethod.UrlEncoded)] Measurement measurement);
// Serialized as: v=1&tid=UA-1234-5&cid=d1e9ea6b-2e8b-4699-93e0-0bcbd26c206c&t=event

Are there any reasons why RestEase doesn't support this or is this just not implemented yet?
Nevertheless, this is an awesome lib! Keep up the good work!

This is the class in Refit which is responsible to convert an object to a Dictionary:
https://github.com/paulcbetts/refit/blob/master/Refit/FormValueDictionary.cs
It is used here:
https://github.com/paulcbetts/refit/blob/master/Refit/RequestBuilderImplementation.cs#L444
The field names are retrieved via Reflection and then inserted into the FormUrlEncodedContent class.

Todo list:

Write code to serialise an object to a set of query params.
Add a new attribute allowing a name to be given to a property in such a class
Add a new type of serialiser allowing this behaviour to be customised. Move the existing dictionary serializarion code into this serialiser. Make sure we allow custom cultures, etc.
Refractor RequestInfo so that QueryMap can accept any object, and pass that object to the Requester.
Update Requester so that it calls the serialiser for QueryMap and serialised request bodies.
Consider whether to allow a format string to be used when serializinf property values.
Consider what to do with nested objects. Do we just call ToString on them, or do we try and serialise them? Changing this later will be breaking behaviour.
Tests. Cover non-public properties, abstract, no getter, getter throws an exception, getter returns a collection, getter returns null, getter returns an object whose ToString method throws. Nested objects if appropriate.
Document it all.

A simple workaround could be:
public class MeasurementWrapper : Dictionary<string, object>
{
    public MeasurementWrapper(Measurement m)
    {
        Add("v", m.V);
        Add("id", m.Id);
    }
}

I had a look at this. Some notes on some of the complexity that needs to be worked through:

I want to make this work similarly for QueryMap and request bodies
With QueryMap, each of the values can be serialized as ToString or Serialized
a. ToString just calls ToString
b. Serialized goes through RequestQueryParamSerializer (the same as normal query parameters)
With request bodies, the object as a whole can be serialized as UrlEncoded or Serialized.
a. UrlEncoded invokes the current IDictionary behaviour, where each value is serialized using ToString, unless it is an IEnumerable, where each value therein is serialized using ToString.
b. Serialized puts it through RequestBodySerializer, which by default turns it into JSON

So, that issues are:

Members which are IEnumerable are currently handled differently
Query maps have an enum controlling how each individual value is serialized. Bodies have an enum controlling how the object as a whole is serialized.
Bodies may need to use the RequestBodySerializer


Create page drops error

See https://github.com/hugolpz/LiListsBot/issues/1

Thanks for this commando : )
I will npm update in few days.

It seems fixed now @  hugolpz/LiListsBot#1


perf: Mark SwiftCxx wrappers struct instead of class for better performance

struct has better performance than class, let's see if this actually works tho

nvm, we need inheritance here so we cannot use struct.


Refactor : Added URL constants

What

Replaced all the hardcoded links with constants throughout the application

Why

To keep all the url's in one place ( Stored in url.js )

Addresses Issue #350

@satyam73 Could you please have a look into this PR


use axios

Replace 'request' module to 'axios'.
If you bundle to browser, you get large file from node builtin shims with request about 2.2MB. Replacing request to axios, you can lose approx. 1.5kB.

x 1.5kB
o 1.5MB


Supervisor Comment

Can all supervisor get the email when a supervisor comment is added and be able to see supervisor comments?

Sure
Get Outlook for iOShttps://aka.ms/o0ukef

From: tea1677<EMAIL_ADDRESS>Sent: Wednesday, March 25, 2020 3:18:51 PM
To: kc9eye/UData<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [kc9eye/UData] Supervisor Comment (#88)
Can all supervisor get the email when a supervisor comment is added and be able to see supervisor comments?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/kc9eye/UData/issues/88, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB2C2ZWWVZPKLTPAGRXFWZTRJJRKXANCNFSM4LTXIVXA.

This is actually handled at the site Administration level and therefore does not have an associated code commit. This has been done.


Saving private key with ".pem" extension.

what

Add .pem extension to private key file

why

Fixes #4.

We're incorporating your change in a new PR: https://github.com/cloudposse/terraform-aws-key-pair/pull/7

Great, @osterman. I couldn't implement those suggested changes. Sorry. Your solution is better yet. Regards.


Compile xml2 extension

Describe your changes
xml2 extension is compiled with XML and XSLT functions support.
Issue ticket number and link
Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.
[ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
[x] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

LGTM, one thing to consider: https://www.postgresql.org/docs/current/xml2.html#id-<IP_ADDRESS>.4 But not a problem to add it if someone asked.


Change Chiconnect to Chimoney's Developer API on ReadMe

👋 Welcome!
Welcome to Chimoney's open-source community! This issue is specifically designed for first-time contributors, so if you're new to open source or haven't contributed to our codebase before, you're in the right place. We're here to help you take your first steps and guide you through the process of making your first contribution.
What You'll Need to Know
You don't need any prior knowledge or experience to work on this issue. We're here to support you every step of the way, so don't hesitate to ask questions if you're unsure about anything.
Problem
Chimoney's API is now called Developer API but the ReadMe section still has it referenced as Chiconnect. We need this updated to the current name.
📋 Step by Step

Claim this issue: Comment below to claim this issue. If someone else has already claimed it, feel free to ask if they've started working on it or if they need any help.

Update the code: In the ReadMe file, go to line 55 and change Chiconnect  to  Chimoney's Developer API.

Commit your changes: Once you've made the necessary updates, commit your changes and then submit a pull request so we can review your changes and merge them into the main codebase.

💬 Keep Us Updated
We encourage you to keep us updated on your progress. If you encounter any challenges or need assistance, don't hesitate to ask for help. We're here to support you throughout the process.
👥 Collaboration
If you see someone else working on this issue or if you'd like to collaborate with others, feel free to reach out and offer your assistance. Collaboration is key to our success as a community!
❓ Questions?
If you have any questions or need clarification on anything, please leave a comment below. We're here to help!

Hi @phyleria @Khadeeejah
can i work on this?

Can I work on this?

Hi @phyleria  assign me this

Hi @phyleria can I please work on this?

@phyleria assign me this.


Update on link to open in new tab for hacktoberFest page

🛠 Fixes Issue
👨💻 Changes proposed
links on hacktoberfest page open in a new page now
✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

@AmanAssassin Create a new PR and resolve conflicts.


start.bat fails to execute when space in path

When there is space in path for the %current_dir% it fails to run docker container.
FIX: by enclosing it in double quote eg:"%current_dir%" the space in path is catered for.
Same could be happening for linux / osX too. (start.sh ${PWD}).

applied fix.
done. release: 2.0.08242023


Improve aiken packages  / aiken add commands

What is your idea? Provide a use case.
Aiken provides commands for adding dependencies to a project (i.e. automatically edit aiken.toml). However, commands are a bit "clunky" at the moment and could be improved in the following ways:

[ ] The --version option on aiken add could be made optional; when not provided, the dependency will be added considering only the default branch
[ ] aiken add should verify that a given repository / project exists when adding it. Ideally, it should also check that a commit or branch given as --version also exists
[ ] Add a aiken remove command to easily remove a dependency
[ ] Support more providers than Github

Why is it a good idea?
These commands are seldom used at this stage because we don't yet have a large ecosystem and the stdlib comes pre-defined as dependency when running aiken new. However, the developer experience could still be made slightly better in anticipation and to prevent mistakes.
What is the current alternative and why is it not good enough?
Current alternative is not doing mistakes. It's very easy to mistype a branch name, and catching errors early is usually how we achieve good UX.

Should we include better version resolution so that projects can depend on libraries that depend on libraries?

Not in this task I believe. This is something we need to think a bit more about IMO.

Ok no problem

Could I try this task?

Sure thing!

@hadelive no problem, please make a draft PR as early as possible so we can provide feedback throughout the process if you get stuck. Also feel free to reach out on discord for help.

Hi! I added a branch to my fork to work on this and I am researching the issue.
I found a closed PR here.
why was it closed - what went wrong?
Can I reuse the code?
Can the PR's be made more granular (i.e. implementing the change as was planned in the issue above) with other changes following in other PR's?
packages is defined here and add is a member of packages, is that right?
Thanks!

why was it closed - what went wrong?  Can I reuse the code?

I think this is already pretty explicit from the PR comments? The suggested approach in the PR ended up being not ideal and the overall UX was deemed not good so it was abandoned.

packages is defined here and add is a member of packages, is that right?

Correct.

Add a aiken remove command to easily remove a dependency

should be more straightforward. Is it a better idea to implement it first?
thanks.

I've updated the original issue, providing more details on the items and clarifying a few interrogations.


Error instead of panic on timestamp overflow

I would have prefered either returning a null value or trying to encode as a non-nanosecond timestamp (sometimes possible if the ORC data does not use nanosecond-level precision), but this would require more significant changes to the code.

Great 👍 I'm going to merge this

Thanks for this :+1:


Saving model to HF broken _save_pretrained method doesn't exist

Describe the bug
Currently when trying to save a model to HF with the code in the main branch one would encounter this error:
AttributeError: 'Model' object has no attribute '_save_pretrained'

I believe this happens now since in this commit the PyTorchModelHubMixin class was removed, it turns out that we were using the _save_pretrained method from it in our base model save_pretrained method
So I think there are two ways this could be fixed:

Either by reintroducing the PyTorchModelHubMixin and inheriting from it
Or if the PyTorchModelHubMixin is unnecessary overhead just for that one method (I am assumed it isn't used elswhere) we could implement our own  '_save_pretrained' method to save model weights locally, wouldn't be too hard I think since the method HF uses looks quite straightforward, I tried just a torch.save() replacement but that seems to not quite work but hopefully not too much more complicated than something like that, @peterdudfield would be good to get your opinion as you probably have most context for the pros/cons of removing the PyTorchModelHubMixin class

Interesting, do you know wen this PytorchModelHubMixin was removed? and why?
I guess it was removed to make it cleaner? or there was some comptability issue?

@peterdudfield I think the commit with that change was created by yourself https://github.com/openclimatefix/PVNet/pull/238/files so I was hoping you may be able to shed some light on that part 😄

ah, not sure, my mistale for not testing it properly, is it easy to put back in?

Yep it is straight forward, just wanted to check there wasn't a specific reason we wanted to remove it since as I mentioned I think we could implement something ourself to avoid using it


[language][vm] move Rc<RefCell<>> into Container

Summary
This moves the Rc<RefCell<>>s into Container, allowing variant tags to be read without borrowing the cells. This also results in a more natural shared data ownership.
Test Plan
cargo test

@sblackshear, @emmazzz this is blocked by the problem Victor talked about in the slack channel

@bors-libra r=dariorussi

:pushpin: Commit 152a121 has been approved by dariorussi

@vgao1996: did you add a test that will catch the "forgot to mark the resource as dirty when performing vector ops on a vector it contains" problem? I think we probably shouldn't go forward with this until we're protected against that + related problems...

@bors-libra cancel

@sblackshear I'll add a few tests for this. Thanks for pointing this out!

@bors-libra r=dariorussi

:pushpin: Commit f2b3898 has been approved by dariorussi

@sblackshear I've added the tests.

:hourglass: Testing commit f2b389889dd21d36ec954f30321e5f107ebae583 with merge 6533dd6042dbfc28ee0454e6a47db3cfc71e6c64...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: dariorussi
Pushing 6533dd6042dbfc28ee0454e6a47db3cfc71e6c64 to master...


Stacktrace

What is your Quests version / build number (do not say "latest")?
Quests 3.9.3 b99
Describe the problem and how to replicate it. Any console errors to post using Pastebin.com?
Stacktrace
If applicable, can you provide an example quest from quests.yml using Pastebin.com?
https://pastebin.com/Dbnp8c2h

https://pastebin.com/yQvRNdxE

Use https://ci.codemc.io/job/PikaMug/job/Quests/101/


UI Issues - Round 2

Version - Master with current reskin

[ ] Authentication Alert - Yellow and text is a red color.  Hard to see.  Alert should probably have Red background with black text?

[x] "Adding your first host" text is not centered in box and too high

[ ] Can barely see the light grey text in the detail screens.  Example below but it's in all the detail screens.

[ ] The Close x icon for summary should be the circle x icon and be inside the tab.  If not it can look like it belongs to the Stack Names.

[ ] "Deactivating" in Summary View is getting cut off by the View Details button - I can't get a picture of this, it happens too fast!  But it basically happens when you stop a service from inside the summary view.

[ ] Running Process Search criteria is right aligned?  Shouldn't it be left aligned with the All/Running option the only thing left aligned.  It just looks weird having a huge white space on the left.

[ ] In Update Service, the text on the Right Start Behavior [] Start before Stop is squished together

Not sure which one is correct but I like the Adding your Host.  Adding your Service has more white space at top.  We should have them be consistent.  Especially since this is the first screen our customers will see.

Version - Master with reskin UI
Verified fixed


Feature request: provide link to latest report pdf which is guaranteed to open in browser

Currently, the "Latest report PDF: report.pdf" links point to the github.com/owner/repo/raw/ url. In some browsers (e.g. Firefox) that opens in the browser; in some it downloads the file (e.g. Chromium browsers, Safari). When I use a browser which will download the file, I have to click into the latest-report directory, and from there open the file. Not a big hardship, but I often forget, and click the README link, and trigger a download I don't want.
Links to github.com/owner/repo/blob/… will open in the GitHub browser UI. I'd like a second link in READMEs pointing to the blob URL. Then I'd get the same convenience in Chromium/Safari as I do in FF.

This is now 'done' via https://github.com/jgehrcke/github-repo-stats/pull/75, of course still needs a release.


Add DNS servers and DNS domain keys to the network_config.json

To accommodate some custom network configs, I need to add 2 new keys to the network_config.json file:
[
    {
        "network_name": "internal",
        "network_gateway": "<IP_ADDRESS>",
        "network_subnet": "<IP_ADDRESS>/24",
        "network_range_start": "<IP_ADDRESS>",
        "network_range_end": "<IP_ADDRESS>",
        "bridge_interface": "None",
        "apply_bridge_address": true,
        "dns_servers": ["<IP_ADDRESS>", "<IP_ADDRESS>"],
        "dns_domain": "custom.dns-domain.lan",
        "comment": "Internal Network"
    }
]

The change has been refused, in favour of this one:
{
    "public_vm_image_server": "https://images.yari.pw/",
    "backup_servers": [],
    "active_datasets": [
        "zroot/vm-encrypted",
        "zroot/vm-unencrypted"
    ],
    "dns_servers": [
        "${UPSTREAM_DNS_SERVER}"
    ],
    "host_dns_acls": [
        "${NETWORK_SUBNET}"
    ],
    "host_ssh_keys": [
        {
            "key_value": "${HOST_SSH_KEY}",
            "comment": "Host Key"
        }
    ]
}

In other words, host configuration file will include all of the upstream DNS servers.


folder path for Windows installer does not match version of download

Using the openrefine-win-with-java-installer-3.8.5.exe installer creates a folder named OpenRefine-v3.9-SNAPSHOT instead of OpenRefine-v3.8.5
To Reproduce
Steps to reproduce the behavior:

First, download OpenRefine 3.8.5 .exe installer for Windows
Then, choose to keep download (avoiding Windows Security - also accept that installer is safe to run)
Finally, notice during install and afterwards, that folder path created

Current Results
folder OpenRefine-v3.9-SNAPSHOT is created
Expected Behavior
folder OpenRefine-v3.8.5 should have been created
Screenshots

Versions

Operating System: Windows 11 Pro
Browser Version: Edge latest
JRE or JDK Version: included
OpenRefine: v3.8.5

Datasets

Additional context
Not 100% sure if perhaps #6878 might be an underlying part of this issue somehow?
Or during release, we (@tfmorris) somehow missed an important step that isn't documented well enough currently and needs to be documented so we don't skip that step in the next release?
But seems it might have been caused somewhere here with the MyAppVersion that is then used inside the openrefine.iss file? :
https://github.com/OpenRefine/OpenRefine/blob/550cc4e8f7929acd7fc21692a7124fd638425af6/.github/workflows/snapshot_release.yml#L351

Curious! I can't spot any glitch in the commit that set the version (https://github.com/OpenRefine/OpenRefine/commit/9227cfd30eaed6bfbfb62dfa8c5553ad5850e586). It would be worth checking if this applies to other versions too.


Add temp changes

Codecov Report

Merging #21 (2182248) into master (8a06559) will decrease coverage by 1.80%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage   99.06%   97.27%   -1.80%
==========================================
  Files           5        5
  Lines         107      110       +3
==========================================
+ Hits          106      107       +1
- Misses          1        3       +2

Impacted Files
Coverage Δ

declared_env/_environment_parser.py
92.85% <33.33%> (-7.15%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Template/triage

The build is broken due to theme related changes....

The build is broken due to theme related changes....

See #34


[BUG] color changes

When I want to copy the picture, its color changes
all model and cuda

Can you post two pictures as examples?

like this
1=orginal
2 =copy
3=And when you copy it again several times, the color becomes very bad. It is not visible on color screens, but it is very visible on black or white photos or manga.

Can you post two pictures as examples?

https://github.com/Sanster/lama-cleaner/issues/291#issuecomment-1521040690

like this 1=orginal 2 =copy 3=And when you copy it again several times, the color becomes very bad. It is not visible on color screens, but it is very visible on black or white photos or manga.

It does look bad, but I tried a few comic images and didn't notice a change in color. To help pinpoint the problem, there are a few questions I'd like to ask

If you don't use the copy (ctrl+c) operation, but instead use the download operation (clicking on the download button at the bottom), will there be any color issues?
Did you perform any operations during step 『2』-> 『3』 in your example image? Or did you just repeat pressing ctrl+c multiple times?
Can you send me the original files of the three images in your example picture to my email address? My email address is<EMAIL_ADDRESS>

like this 1=orginal 2 =copy 3=And when you copy it again several times, the color becomes very bad. It is not visible on color screens, but it is very visible on black or white photos or manga.

It does look bad, but I tried a few comic images and didn't notice a change in color. To help pinpoint the problem, there are a few questions I'd like to ask

If you don't use the copy (ctrl+c) operation, but instead use the download operation (clicking on the download button at the bottom), will there be any color issues?
Did you perform any operations during step 『2』-> 『3』 in your example image? Or did you just repeat pressing ctrl+c multiple times?
Can you send me the original files of the three images in your example picture to my email address? My email address is<EMAIL_ADDRESS>

hi that bug fixed  one of this get updated bug fixed

Python version: 3.10.11
torch: 2.ø.O+cu118
Pillow: 9.5.ø
diffusers: 0.14.ø
transformers: 4.27.4
opencv-python: 4.7.ø.72
xformers: 19
accelerate: ø.19.ø
lama-cleaner: 1.1.2


fix issues with ci worfklow for docker

Proposed changes
The github action is not correctly generating tags for the docker images. e.g. instead of generating 0.8.3 tag, generated release-0.8.3, and didn't tag it also as "latest".
Types of changes
What types of changes does your code introduce to the project?
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have run all the existing tests locally (not just those related to my feature) and there are no errors
[x] After the last push to the PR branch, I have run the lint script locally and there are no changes to the code base
[x] I have updated the RELEASE NOTES
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Further comments
N/A

@c0c0n3 checking at the actions outcomes, it seems that actually the issue was that the build failed.
anyhow, i have removed the creation of images linked to branches.
fix #624

great job! just one question. shouldn't this yaml at the top of the file
on:
  push:
    branches:
      - '**'
    tags:
      - '*.*.*'
      - '*.*'
  pull_request:
    branches:
      - 'master'

rather be something like
on: [release]

?

The workflow should run all the times to verify that a docker build actually works. That's why is not only on release.

The GitHub docs are quite terse (https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release) but if I think that should trigger the publishing of the Docker image only when we cut a release, i.e. when we publish a release on GitHub:

https://github.com/orchestracities/ngsi-timeseries-api/releases

But if we do this then we don't have the convenience of publishing images on a merge into master without having to cut a release. What do you think is best

Only push a docker image to DockerHub when we cut a release---possibly less images for our users to browse.
Also push when merging into master---convenient and we used it in the past.

I'm inclined to think (2) would be best, since users can easily filter out images on DockerHub that don't follow the semver pattern. If you agree, then I guess we can just merge this PR?

I think (and we are going to see now...) a new 'edge' tagged release is going to be created every time we merge something into master.

I think (and we are going to see now...) a new 'edge' tagged release is going to be created every time we merge something into master.

it turned out to be a wrong assumption... so I will have to fix


For all files, Fertifly readme.md need to be cleared on this repo.

That very important to make who fork or wont to Collaborate with your understand whatever you give some option.

thanks you for coming!


controller flashes when it vibrates

yeah i dont know what im doing but id like my controller to stop flashing when it vibrates how do i stop this lmao

Just as a heads up: This fork/version of DS4Windows is outdated. An improved version is being actively maintained by Ryochan7.

https://github.com/Ryochan7/DS4Windows/releases


Language Client: Integrate diagnostic levels with existing errors

Leverage the DiagnosticSeverity as documented in the language server protocol. This is important as the OCaml/Reason language service leverages this.

Fixed by #534


Not possible to invoke serialization/deserialization handlers for nested objects?

I have a simple object graph which I want to serialize across the wire to a java backend.
Consider the following:
class Put(NamedCacheRequest):
    def __init__(self, cache_name: str=None, key: K=None, value: V=None) -> None:
        super().__init__(cache_name)
        self.key = key
        self.value = value

    def flatten(self, obj, data):
        super().flatten(obj, data)
        data["key"] = obj.key
        data["value"] = obj.value
        return data

    def restore(self, obj):
        pass

In the above example, value can be a simple or complex type.  With simple types, it works fine.
However, here's the wrench (perhaps perceived):
class Person(object):
    def __init__(self, name: str, age: int, gender: str, friends: set):
        super().__init__()
        self.name = name
        self.age = age
        self.gender = gender
        self.friends = friends

    def __eq__(self, o: object) -> bool:
        if not isinstance(o, Person):
            return False

        return self.name == o.name and self.age == o.age and self.gender == o.gender and self.friends == o.friends

    def __ne__(self, o: object) -> bool:
        return not self.__eq__(o)

I have a handler registered for Person to deal with serialization of the set, however, the handler is never invoked.   Of course, if I pass a Person object directly to jsonpickle, then the handler is invoked as expected.
I can go into details on why I'm not letting jsonpickle encode the set, i.e., py/set in the stream, if desired.

Just curious, what was the solution?  If possible, I'd be happy to include a test case that mimics your use case.

@davvid I think once you use a handler you're in complete control of what is serialized and what isn't.   The jsonpickle runtime won't inspect the result of data to see if further serialization is required.
So for now, I've written my own internal flatten method that can be called to invoke any handlers found for that type.
So using the example above, with nested Person types, I have:
def flatten(self, obj, data):
        data["name"] = obj.name
        data["age"] = obj.age
        data["gender"] = obj.gender
        if obj.friends is not None:
            data["friends"] = [self.flatten_internal(i) for i in obj.friends]
        return data

@davvid Though that leaves the question on how to deserialize nested objects.
Consider the following:
friends = [Person("Aragorn", 90, "male"), Person("Gimli", 150, "male?")]
bilbo = Person("Bilbo", 111, "male", friends)
frodo = Person("Frodo", 33, "male", friends)

result = encode(bilbo)
b = decode(result)
self.assertEqual(bilbo, b)

I could go the hack route, and convert the dict back to string and call decode,  but there is probably a better way....

#davvid Disregard that last question.  Think I have that resolved now too.


multi-repository endpoints for high-availability (enhancement)

Output of restic version
$ restic version
restic 0.3.0 (v0.3.0-38-g505a209)
compiled at 2016-11-30 04:53:47 with go1.7.3 on darwin/amd64

$ restic version
restic 0.3.0 (v0.3.0-38-g505a209)
compiled at 2016-11-30 04:39:06 with go1.6.2 on linux/amd64

Actual behavior
The env variable RESTIC_REPOSITORY works just fine with Minio.
One can use it like this:
export RESTIC_REPOSITORY=s3:http://srv1.com:9001:
Expected behavior
It'll be great if we can extend the meaning of this env variable to use multiple endpoints instead of one. Something like:
export RESTIC_REPOSITORY="s3:http://srv1.com:9001":"s3:http://srv2.com:9002":"s3:http://srv3.com:9003"
In case of failure of the first endpoint s3:http://srv1.com:9001, restic will try with the second one s3:http://srv2.com:9002, then with the third one s3:http://srv3.com:9003, etc.
If all fail, then it can give up.
Minio distributed feature is already available. Restic can benefit from it and offer high-availability for endpoints (i.e. shares).

Hi, thanks for the suggestion. I think it's already possible to do this: When restic returns an error code, just run it again with the second repo, when that also fails with the third (e.g. in a shell script). What do you think?

Hey,
Sure, it's very doable to wrap it indeed.
The whole point is about usability. What you can do under Linux/Unix shell script maybe harder on other OSes.
It'll be fantasy if restic can simply check for "connection timeout", and apply this logic underneath.
Much cleaner, portable, and usable.
What do you think 😁?

Tread carefully. Seeing multiple repositories in the variable, I'd always first expect that restic would use them all, simultaneously, and unconditionally. IMHO, setting it like that would even be more useful. But, that's just my opinion. Anyways, if there are any semantic changes like this, do it carefully, it's much harder to unwind it later, when another great idea pops out, and is suddenly incompatible with the old one. :)

Zlatko: what do you suggest then?

I'll let @fd0 sort it out. 😆
I'm pretty sure I will get interested in parallel backup some time in the future, but not right now.

Heyho, do you have any update on this? I am highly interested in this feature and this would be one of the killer features for restic against borg.

I think this is feature creep for restic. This can already be done with a for loop, on every OS. And it's not confusing, whereas the ability to specify multiple repositories is too ambiguous.

I think this is feature creep for restic. This can already be done with a for loop, on every OS. And it's not confusing, whereas the ability to specify multiple repositories is too ambiguous.

Some people on the forums already had difficulties installing restic on Unix systems, hence I doubt that all restic users know how to write scripts.
IMHO, every good backup solution should be able to use an alterntive repository. But I'm unsure if this should be handled by restic itself or by a GUI.

I'm not sure if this feature would be good for restic or not, but for now there exist at least two different solutions (running restic multiple times in a row for each backend, or using rclone to mirror a repository somewhere else). So, overall we don't have a decision yet, and this is rather low on the todo list for restic.

How well, does running in it in a loop work? And will I have the same backup revision on all targets? What happens when I don't run it in a loop for a specific time and then decide to run it in a loop again. Will all backups have the same state?
There are a lot of open questions about "you can run that in a for loop". What I want to address is a reliable way to backup data to multiple different (like usb, S3 storage, remote server) endpoints. And what I want to have is the same backup on every of those endpoints. I was especially asking for this, because I know other solutions where it's proposed to be easy, but in the end they fail to keep the data identical, secure and distributed. Note: I am talking about data multiplication (Raid 1). I am not talking about clustered data for faster backups (Raid 0).

What I want to address is a reliable way to backup data to multiple different (like usb, S3 storage, remote server) endpoints. And what I want to have is the same backup on every of those endpoints.

Make a backup to one endpoint, then use rsync or rclone to mirror the files to the other endpoints. Make sure to include file deletes on the source endpoint, then you'll get a byte-identical copy of all snapshots and data in all endpoints. restic's file format for the repository supports this.

I also see an advantage in having restic put the same backup to multiple repositories, instead of the rclone/rsync or shell-script-looping - "hacks".
The improvement over the loop-it-with-a-script: if it was implemented in restic, there would be no looping of the same restic backup command. But rather for each file/block that restic looks at, it only needs to write it to multiple locations but not look at the same file twice.
Also you'd end up with identical backups in one run (nicer than the rsync/rclone-way).
I understand the concerns whether multiple repositories should be AND'ed or OR'ed and I think there could be a cli-switch along the lines of --mutli-repo-behaviour [all|at-least-one] with all being the default as it is the safer way.
If I meant at-least-one and all is the default, it will error on flakey locations and the user will be informed with an error; if it was the other way round it would silently error on one repo and not tell me, leading to possible data loss.

After thinking a bit about this issue, I don't think it is a good idea to implement it:

Trying different backup locations can easily be handled outside of restic. Specifying e.g. two different S3 repositories won't work anyways (at least for now).
Storing to multiple repositories at once is far more wasteful than it seems at first glance: we'd have to open all repositories (with a full copy of the index of each one!). All other steps of the backup pipeline, that is pack assembly and uploading, also have to be duplicated. It won't help if the individual repositories started as copies of each other as they can diverge over time. Oh, and using different repositories would only work if they use identical chunker parameters.

So this would only work together with some serious restrictions, and we haven't even spoken about other commands besides backup yet. In short: use the copy command instead or use a distributed repository storage.


Bug cannot open project Godot 4.3 its says my opengl need 3.0 but my opengl is 3.0

Tested versions
I tested on 4.3
intel core i3 4130
Intel Hd graphics 4300
System information
Windows 10 Godot 4.3 {compability Overriden) intel core i3 4130
Issue description
not just that  i cannot to try the project when i try the project its crash

Steps to reproduce
if you just want to open the project Just use cmd
Minimal reproduction project (MRP)
I dont know how to fix please help

There is no such GPU as Intel HD 4300, you must have made a typo

@HAITSAMPC can you try showing what error you have or uploading your project for ease of testing ? More often than not OpenGL errors can stem from old graphics drivers not being up to date.
The graphics chipset that comes with your processor is the Intel® HD Graphics 4400 for which the latest version is 15.40 so make sure you're up to that one too.


Enhancement: add mailerBuilder.withTransportModeLoggingOnly() as mailer API entry point

Without this, a user would be forced to start with a dummy SMTP server.

7.8.0 released, now SMTP server config can be omitted in case of withTransportModeLoggingOnly:
Mailer mailer = MailerBuilder
    .withTransportModeLoggingOnly()
    .(...)
    .buildMailer();


make velox compile at GCC 11.3

Fix issue when compile velox on gcc 11.3. https://github.com/facebookincubator/velox/issues/3713

Hi, @Yuhta there is a warning in "Facebook Internal - Builds & Tests ". Would you give me more information about it？ Or you can help me to fix it.

@zhejiangxiaomai No worry it's just some unrelated warning

@zhejiangxiaomai No worry it's just some unrelated warning

Thank you, Would you help me to fix it and merge this PR? @Yuhta


[DNM] Temp diff testing 1.x reads with 0.x branch

Change Logs
Testing viability of reading 1.x tables using 0.x timeline.
this patch only has changes in timeline related classes. I did not make changes to FSV/file group yet.
Impact
Describe any public API or user-facing feature change or any performance impact.
Risk level (write none, low medium or high below)
If medium or high, explain what verification was done to mitigate the risks.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

The config description must be updated if new configs are added or the default value of the configs are changed
Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the instruction to make
changes to the website.

Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

Closing this PR as we go with backwards compatible writer in Hudi 1.0 (HUDI-8076).


Cross-world persistent weather issue

I recently installed Multiverse to add a new Creative world but I seem to have run into a bug.
If it's raining in our main Survival world and we enter the Creative world by any means, it will also be raining there, non-stop, even commands will not stop the rain. Re-joining the server is the only fix and seems to be some sort of client-side bug?
I've tried every weather command from all of my plugins, but they don't work. Is this a Multiverse bug, or a client bug?
Details:
http://paste.enginehub.org/yz4Cd.report

Have you tried using /toggledownfall or using /mvm set weather false?

I have, yep. I went through literally every plugin I had, making sure I was checking the configs and commands for anything that affects weather but no-go.

Have you tried rebooting after using the weather setting?

Had the same issue. Issue is temp fixed with relog and is client side. I think this is a old optifine issue.

@NobleStrike I do not have any mods installed at all, purely a vanilla client
@TWSSYesterday Yep, sure have rebooted - several times

No worlds.yml, use the latest version then reply please :)

Where can i find the latest build?

http://dev.bukkit.org/bukkit-plugins/multiverse-core/

Im running Version: 2.5-b691    I do not see any other builds listed on the page. Am i missing something?

Hmm, I couldn't see your version for some reason. Using 1.8 Spigot?

Who me? Im running 1.8.3 spigot now and the issues is still happening.
Here is a full list of plugins updated every 24 hours
http://www.gametracker.com/server_info/ChristianCity.co:25565/server_variables/

Mind pastebining the entire log?

Debug for multiverse-core on https://www.dropbox.com/s/j832sb5jb97yi3m/2015-03-20-3.log.gz?dl=0
6 hour log. Not too many players on though.

Might have been patched with 1.8.3... Ill let you know

Issue still occuring?

We must assume this is no longer occurring due to a lack of further response, if the issue is still occurring, then I will re open the ticket. If it is, try updating to the latest build found on http://ci.onarandombox.com/view/Multiverse/


Added error checking

input - output = error (requires another program)
additional: having a system of programs (subtract, average, etc.) would be useful and should be its own repo.

Could be used for automatic error adjustment.


NTR mannose-ethanolamine phosphate phosphodiesterase

I'm looking for a term to describe this MF
mannose-ethanolamine phosphate phosphodiesterase
def?
GPI glycan remodeling by PGAP5 regulates transport of GPI-anchored proteins from the ER to the Golgi.
We subsequently used the GPI intermediate H8 as a substrate. H8 has structure EtNP-Man-(EtNP)Man-(EtNP)Man-GlcN-(acyl)PI, which is a complete precursor just before GPI attachment (Hirose et al., 1992). When [14C]Man-labeled H8 was incubated with HF-PGAP5, it was efficiently converted into H7 lacking the side-chain EtNP on Man2 (Figure 6B),
from
Cell. 2009 Oct 16;139(2):352-65
PMID: 19837036
Cdc1 removes the ethanolamine phosphate of the first mannose of GPI anchors and thereby facilitates the integration of GPI proteins into the yeast cell wall.
PMID: 25165136
I’m trying to annotate the human MPPE1 ortholog and S. cerevisiae CDC1  in pombe but I can't find an appropriate term in GO or an EC number for this. Maybe it has another name?

@deustp01
Let's look at this next week. I think we should work on this in the context of both GO and Reactome. It looks like there is no specific enzyme activity to describe MPPE1.

What I've found out so far: MPPE1 (human - Q53F39; mouse Q80XL7) - is also known as PGAP5, and that enzyme mediates step 14, Figure 4, in the process described in the Kinoshita & Fujita review. UniProt assigns GO:0008081 phosphoric diester hydrolase activity as its molecular function (both species) by inference from sequence or structural similarity (probably, the inference is from data from the mutant hamster cell line PMID:19837036).
So far, I've looked only at the earlier steps, 1-12 or thereabout, shown in Kinoshita & Fujita Figure 2. The latter get the PGI block synthesized and transferred onto a target protein; the former is one of several steps in which the block is modified further as the modified target protein moves through the Golgin apparatus towards the cell membrane.

@deustp01 @thomaspd @judyblake @vanaukenk
We should look at this on Monday when we meet. The authors who describe this enzyme give it a generic designation. Should we request the specific enzyme from EC? In the era of GO-CAM models, will it suffice to use the generic activity and then add specificity by extension?

It looks like this enzyme was characterized in PMID:19837036. That paper has been annotated as GO:0008081 and manganese ion binding. I think the best thing for us to do is to add this with the name 'GPI-mannose ethanolamine phosphate phosphodiesterase activity'. The authors demonstrate its substrate specificity.
Definition: A phosphoric diester hydrolase activity that removes the ethanolamine phosphate from mannose 2 of a GPI anchor.


Clarification of concurrency

The documentation clearly states:
KStateMachine is designed to work in single thread. Concurrent modification of library classes will lead to race conditions.
Does is also mean that the calls to processEvent()  must be done from the same thread ?
I understand that creating the state machine with its states, listeners and transitions is single-threaded. But may be  processEvent()  can be called from different threads ?

Hi, the short answer - yes.
Details:
If you are using StateMachine  instance created by  createStateMachine/createStateMachineBlocking functions (with CoroutineScope specified), then it is safe to call any suspendable library methods (including processEvent()) on such instance, from any CoroutineContext (driven by any thread), as all those methods switch the CoroutineContext internally to machines one.
But if you create StateMachine instance without coroutines support (by createStdLibStateMachine) then the answer is no, as internal context switching cannot be performed in such case.
See Coroutines section in docs, there was some explanation regarding this behaviour.

Thank you the the quick and descriptive answer !
I think it deserves to be in the docs instead of a very short and confusing statement.

I have updated the docs, and linked related sections.

@nsk90 may I ask you to add yet another sample to the ones provided inside the project with the way to properly create the Scope ?
Please don't forget that the CoroutineScope that you specify when creating a StateMachine instance sould be driven by single thread.


[Feature] Slide feature

The slide animation needs to be lowered down a little and the collision box updated in consequence

The collision boxes are updated (#30). The animation still can be lowered down as a future improvement


Package rather large due to static library linking

Solution to issue cannot be found in the documentation.

[X] I checked the documentation.

Issue
There are multiple large files in bin/ that statically link to libbmad.a.
The package could be smaller if you would produce a libbmad.dylib/.so and link against that :)
Installed packages
-

Environment info
-

@wolfv we are working with the package maintainers to check if the build system can be changed there to produce binaries linking to the shared libraries.

Cool!

This should be possible. The person who will be will be working on it says he will have time next week to look...

Update: Some of the basic build scripts have been modified and are in testing. Light is seen at the end of the tunnel...

Update:

we changed to build only shared libraries (.so and .dylib) for this package.
binaries were adjusted to link with shared libraries and reduce the overall size.

I am closing this issue but feel free to reopen it.


sbom resulting from simple gradle project seems not to be CycloneDX compliant

Just recognized, that parsing an sbom created by cdxgen 8.5.2 out of a flat gradle project (no multiple modules, just a single build.gradle) cannot be parsed by the org.cyclonedx:cyclonedx-core-java library.
It has the following validation viloation:
org.cyclonedx.exception.ParseException: $.metadata.component.qualifiers: is not defined in the schema and the schema does not allow additional properties

and parsing fails with:
Cannot deserialize value of type `org.cyclonedx.model.Component$Type` from String "jar": not one of the values accepted for Enum class: [application, container, device, library, file, framework, operating-system, firmware]

on path
0 = {JsonMappingException$Reference@11949} "org.cyclonedx.model.Bom["metadata"]"
1 = {JsonMappingException$Reference@11950} "org.cyclonedx.model.Metadata["component"]"
2 = {JsonMappingException$Reference@11951} "org.cyclonedx.model.Component["type"]"

generated sbom looks like
  "metadata": {
    "timestamp": "2023-06-12T13:58:33.668Z",
    "tools": [
      {
        "vendor": "cyclonedx",
        "name": "cdxgen",
        "version": "8.5.2"
      }
    ],
    "authors": [
      {
        "name": "Prabhu Subramanian",
        "email"<EMAIL_ADDRESS>      }
    ],
    "component": {
      "name": "my-app",
      "type": "application",
      "qualifiers": {
        "type": "jar"
      },

it's strange, as the referred path doesn't contain the wrong value, but probably it's just a wrong error message due to the previous validation issue.

@heubeck Could you send a PR?
I think this line needs to be deleted
https://github.com/CycloneDX/cdxgen/blob/master/index.js#L1190
Hardcode qualifiers: { type: "jar" }, in line 1199
https://github.com/CycloneDX/cdxgen/blob/master/index.js#L1199

Thank you @prabhu, that helped.
PR opened.

Thank you!


Could you please tell me who uses this module?

Hi, @winshining, the module has been running perfectly for me for some time!
I saw the release note of version 1.2.4 wrote that some vendors had used this module in production, could you please tell me who are them? Cause I plan to use it in my product.
Thanks!

I've ever asked a sponsor that if I could list the company name in my README, he refused. They provide network TV service, using HTTP-FLV.
Another vendor has used the module to provide CDN service for some live show vendors, using RTMP. But there is a problem has not been solved until now, you can see #30. Dynamically reload configuration file without reloading Nginx is too complex for me.
A program manager in HUAWEI told me in Apr. that they planned to use the module and they were intensively testing the module. But they have not contacted me since then, so I can't make sure that if they at last decided to use it.
The most of other vendors use the module in their surveillance systems.
At last, you can search in GitHub to see if it is used by someone.


As a student, I can create a new edX account using Google and Facebook

Add support for external providers. While doing this I started to build
up some basic infrastructure, particularly around styling. Also adds an
external service provider abstraction on top of our existing google and
facebook support. The hope is to eventually expose this so that it's
easier to plug in different authentication providers.
There's now a text style class, so we can stop referring to OpenSans by
name everywhere. By starting to adopt this class we can facilitate
theming support. The styles class is also slightly better set up for
that.
This doesn't have many tests yet, but I wanted to get the functionality out
for manual QA.
JIRA: https://openedx.atlassian.net/browse/MA-335

@hanningni please review.
@BenjiLee If you have the bandwidth, I always appreciate another set of eyes.

:+1:


Priorize provisioners alphabetically if multiple match

1. Issue, if available:
2. Description of changes:
@felix-zhe-huang brought up an odd behavior where unconstrained pods would schedule randomly if multiple provisioners were defined. Eventually I'd like to define a provisioner.spec.priority feature, but in the short term, we will just alphabetize to make this deterministic.
3. Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: link to issue
[ ] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Hi. Is that still how the selection is implemented?
I am asking (and didn't want to open an issue_, because in the docs:

Karpenter attempts to provision capacity only when there are unschedulable pods


Adjust Planetary network connector info

Situation
Planetary connector info in manual is not up to date
Todo
Remove or at least adjust info on planetary connector
https://manual.grid.tf/documentation/system_administrators/getstarted/ssh_guide/ssh_openssh.html#ssh-into-a-3node-with-the-planetary-network-on-windows

Complete when #511 is merged


Add a validtaion for rhel subscription in case the bifrost images are rhel based

In order to avoid lengthy build process and tons of misleading tracebacks.

cc @rhatdan

Sure, but do not know how to do this only in the case that user specifies a RHEL-bootc image.
Please open a PR.


Replace the current examples with better ones

You can copy a shapes demo implementation almost directly from here: https://github.com/jhelovuo/dds-rtps/tree/master/RustDDS
ROS2 turtle example should be completely rewritten with more or less the same functionality. The shapes demo could serve as a starting point. There should be no need for several modules, multiple threads, or internal communication channels. The current implementation is unnecessary convoluted because of earlier design mistakes (now fixed) in RustDDS and other obscure reasons.

Also doen for turtlesim demo.