ERROR (Mrsk::Utils::HealthcheckPoller::HealthcheckError): container not ready (unhealthy)

when running mrsk deploy, the precompile works and everything looks like it is deploying out correctly, but at the end I get this
  ERROR (Mrsk::Utils::HealthcheckPoller::HealthcheckError): container not ready (unhealthy)

this app I'm on is Rails <IP_ADDRESS> so I do not have an /up endpoint. do I patch one onto my Rails <IP_ADDRESS> app?

problem exists between chair and keyboard
I missed step 8:
Ensure your app responds with 200 OK to GET /up.

my Dockerfile does contain an apt-get for curl (cross-referencing @pabloC's answer on https://github.com/mrsked/mrsk/issues/276)
# Install packages need to build gems and node modules
RUN apt-get update -qq && \
    apt-get install -y build-essential curl default-libmysqlclient-dev git libpq-dev libvips node-gyp pkg-config python-is-python3

my full Dockerfile:
https://gist.github.com/jasonfb/592bf8484810aa09934727caa83b65e1

this is the result of mrsk deploy
https://gist.github.com/jasonfb/6b86fe48f79393d98626ab55b3ab9334

Were you able to deploy prior to upgrading to 0.12.0?
I added some healthcheck logging which was merged into 0.12.1 (#265). That may give you more detail on health of container and why it's not passing healthcheck.

this is all sandbox/new but I can try downgrading MRSK if you want

mrsk 0.12.1
same result, but with newly added logging content as @Jberczel promised above
Ensure app can pass healthcheck...
  INFO [4e1d1444] Running docker run --detach --name healthcheck-helios-panoptes-d0e63ff92735b901170f79037c36f251c31dbb6a --publish 3999:3000 --label service=healthcheck-helios-panoptes -e MRSK_CONTAINER_NAME="healthcheck-helios-panoptes" -e [REDACTED] --health-cmd "curl -f http://localhost:3000/up || exit 1" --health-interval "1s" jasonheliosdevshop/helios-panoptes:d0e63ff92735b901170f79037c36f251c31dbb6a on <IP_ADDRESS>
  INFO [4e1d1444] Finished in 1.587 seconds with exit status 0 (successful).
  INFO [25dd3012] Running docker container ls --all --filter name=^healthcheck-helios-panoptes-d0e63ff92735b901170f79037c36f251c31dbb6a$ --quiet | xargs docker inspect --format '{{if .State.Health}}{{.State.Health.Status}}{{else}}{{.State.Status}}{{end}}' on <IP_ADDRESS>
  INFO [25dd3012] Finished in 0.464 seconds with exit status 0 (successful).
  INFO container not ready (unhealthy), retrying in 1s (attempt 1/7)...
  INFO [6c639d86] Running docker container ls --all --filter name=^healthcheck-helios-panoptes-d0e63ff92735b901170f79037c36f251c31dbb6a$ --quiet | xargs docker inspect --format '{{if .State.Health}}{{.State.Health.Status}}{{else}}{{.State.Status}}{{end}}' on <IP_ADDRESS>
  INFO [6c639d86] Finished in 0.098 seconds with exit status 0 (successful).
  INFO container not ready (unhealthy), retrying in 2s (attempt 2/7)...
  INFO [1fab94c8] Running docker container ls --all --filter name=^healthcheck-helios-panoptes-d0e63ff92735b901170f79037c36f251c31dbb6a$ --quiet | xargs docker inspect --format '{{if .State.Health}}{{.State.Health.Status}}{{else}}{{.State.Status}}{{end}}' on <IP_ADDRESS>
  INFO [1fab94c8] Finished in 0.453 seconds with exit status 0 (successful).
  INFO container not ready (unhealthy), retrying in 3s (attempt 3/7)...
  INFO [0a8f9b5f] Running docker container ls --all --filter name=^healthcheck-helios-panoptes-d0e63ff92735b901170f79037c36f251c31dbb6a$ --quiet | xargs docker inspect --format '{{if .State.Health}}{{.State.Health.Status}}{{else}}{{.State.Status}}{{end}}' on <IP_ADDRESS>
  INFO [0a8f9b5f] Finished in 0.075 seconds with exit status 0 (successful).
  INFO container not ready (unhealthy), retrying in 4s (attempt 4/7)...
  INFO [c8407ddc] Running docker container ls --all --filter name=^healthcheck-helios-panoptes-d0e63ff92735b901170f79037c36f251c31dbb6a$ --quiet | xargs docker inspect --format '{{if .State.Health}}{{.State.Health.Status}}{{else}}{{.State.Status}}{{end}}' on <IP_ADDRESS>
  INFO [c8407ddc] Finished in 0.154 seconds with exit status 0 (successful).
  INFO container not ready (unhealthy), retrying in 5s (attempt 5/7)...
  INFO [c633a966] Running docker container ls --all --filter name=^healthcheck-helios-panoptes-d0e63ff92735b901170f79037c36f251c31dbb6a$ --quiet | xargs docker inspect --format '{{if .State.Health}}{{.State.Health.Status}}{{else}}{{.State.Status}}{{end}}' on <IP_ADDRESS>
  INFO [c633a966] Finished in 0.222 seconds with exit status 0 (successful).
  INFO container not ready (unhealthy), retrying in 6s (attempt 6/7)...
  INFO [6d60dfda] Running docker container ls --all --filter name=^healthcheck-helios-panoptes-d0e63ff92735b901170f79037c36f251c31dbb6a$ --quiet | xargs docker inspect --format '{{if .State.Health}}{{.State.Health.Status}}{{else}}{{.State.Status}}{{end}}' on <IP_ADDRESS>
  INFO [6d60dfda] Finished in 0.210 seconds with exit status 0 (successful).
  INFO container not ready (unhealthy), retrying in 7s (attempt 7/7)...
  INFO [8039a8dd] Running docker container ls --all --filter name=^healthcheck-helios-panoptes-d0e63ff92735b901170f79037c36f251c31dbb6a$ --quiet | xargs docker inspect --format '{{if .State.Health}}{{.State.Health.Status}}{{else}}{{.State.Status}}{{end}}' on <IP_ADDRESS>
  INFO [8039a8dd] Finished in 0.093 seconds with exit status 0 (successful).
  INFO [e0744065] Running docker container ls --all --filter name=^healthcheck-helios-panoptes-d0e63ff92735b901170f79037c36f251c31dbb6a$ --quiet | xargs docker logs --tail 50 2>&1 on <IP_ADDRESS>
  INFO [e0744065] Finished in 0.345 seconds with exit status 0 (successful).
 ERROR exec /rails/bin/docker-entrypoint: exec format error
 ERROR {
  "Status": "unhealthy",
  "FailingStreak": 0,
  "Log": [

  ]
}
  INFO [21805349] Running docker container ls --all --filter name=^healthcheck-helios-panoptes-d0e63ff92735b901170f79037c36f251c31dbb6a$ --quiet | xargs docker stop on <IP_ADDRESS>
  INFO [21805349] Finished in 0.257 seconds with exit status 0 (successful).
  INFO [3719e3a6] Running docker container ls --all --filter name=^healthcheck-helios-panoptes-d0e63ff92735b901170f79037c36f251c31dbb6a$ --quiet | xargs docker container rm on <IP_ADDRESS>
  INFO [3719e3a6] Finished in 0.154 seconds with exit status 0 (successful).
  Finished all in 722.5 seconds
Releasing the deploy lock
  INFO [18555426] Running /usr/bin/env rm mrsk_lock/details && rm -r mrsk_lock on <IP_ADDRESS>
  INFO [18555426] Finished in 0.088 seconds with exit status 0 (successful).
  ERROR (Mrsk::Utils::HealthcheckPoller::HealthcheckError): container not ready (unhealthy)

I don't think adding curl to the dockerfile to build the app is working as the healthcheck container is a different container than the one used to launch the app?

mrsk 0.11.0
same result:
  Deploy lock was not released
  ERROR (SSHKit::Command::Failed): Health check against /up failed to return 200 OK!

@34code - interesting, I'm no Docker expert, mostly just been a Docker user, and this experience is the most I've gotten my hands dirty with Docker. What you say makes sense. I was just following suggestion by from @PabloC's answer on https://github.com/mrsked/mrsk/issues/276 but I didn't modify my Dockerfile (which originally came from https://www.driftingruby.com/episodes/deploying-with-mrsk and is basically that but with some small modifications)
if I get the same error on mrsk 0.11.0, 0.12.0, ad 0.12.1, then it seems to rule-out those recent changes anyway
I wonder, what should I try next?

mrsk 0.11.0 same result:
  Deploy lock was not released
  ERROR (SSHKit::Command::Failed): Health check against /up failed to return 200 OK!

Try after releasing lock as follows: mrsk lock release
from docs (https://mrsk.dev/docs/locking)

oh shoot. but I think if the lock is actually in place, it stops way sooner (like right up front)
when I do this it says there was no lock
% mrsk lock release
  INFO [15ca4d80] Running /usr/bin/env rm mrsk_lock/details && rm -r mrsk_lock on <IP_ADDRESS>
There is no deploy lock

anyway I get the same result if I first release the lock, but thanks indeed.
"Do not try to bend the lock, just try to remember... there is no lock"
— the Matrix

This seems like an issue with your docker setup, not mrsk.
Your log says there's an issue with your docker-entrypoint.
 ERROR exec /rails/bin/docker-entrypoint: exec format error

Have you googled that error?  You could also try and remove entrypoint from Dockerfile and rebuild and try to run locally to troubleshoot.


Fix: Redundant cast to bool (psalm)

Q
A

Is bugfix?
✔

New feature?
❌

Breaks BC?
❌

Fixed issues

👍


Template Literal Type - Does not evaluate interpolated template strings against type definition

TypeScript Version:  4.1.2

Search Terms:
template literal type template string interpolation number pixel value
Code
const pixelValue: number = 22;

type PixelValueType = `${number}px`;

const pixelString: PixelValueType = `22px`;

// Error here
const pixelStringWithTemplate: PixelValueType = `${pixelValue}px`;

Expected behavior:
A template string should be evaluated to determine if it matches a template literal type.
Actual behavior:
The template string is evaluated to type string even though it can match the Template Literal Type
Type 'string' is not assignable to type '`${number}px`'.(2322)

Playground Link:
https://www.typescriptlang.org/play?#code/MYewdgzgLgBADgSwB4FMA2A1AhmgrigLhjFwFsAjFAJxgF4YAmBgbgChWoBPOFGABWTpseFABVuvegAMAJAG8SFagF84SKW1ahIsRKjQBlKFQRgA5kQH7h+cTzowpTNRq3ho8QYeOmzAdQQoAAtRFFI4NCwoQn4vGzEJB1k5PSEcfFV1NiA
Related Issues:

Related issues: #40707, #10676
From #40707, if you use a const assertion the compiler will give a template literal type to a template literal expression, resulting in your desired behavior:
const pixelValue: number = 22;
type PixelValueType = `${number}px`;
const pixelStringWithTemplate: PixelValueType = `${pixelValue}px` as const; // okay

Playground link
It looks like your desired behavior is for the compiler to always synthesize a template literal type for a template literal expression the way #10676 does for other literal types, so that as const is not necessary.

Related issues: #40707, #10676
From #40707, if you use a const assertion the compiler will give a template literal type to a template literal expression, resulting in your desired behavior:
const pixelValue: number = 22;
type PixelValueType = `${number}px`;
const pixelStringWithTemplate: PixelValueType = `${pixelValue}px` as const; // okay

Playground link
It looks like your desired behavior is for the compiler to always synthesize a template literal type for a template literal expression the way #10676 does for other literal types, so that as const is not necessary.

Why the ${pixelValue}px cannot be inferred to PixelValueType automatically? It seems nothing problem.

@ahejlsberg Seems like we should be providing a literal context here?

This is a duplicate of #41631.

Now implemented in #41891.


Running the sample bash scan118: TypeError: forward() got an unexpected keyword argument 'save_vis'

After the end of a successful finetune while it's trying to save the validation:
TypeError: forward() got an unexpected keyword argument 'save_vis'
seems the finetune trainer doesn't have this arg

It should be a bug. I will fix it. Thanks so much.


✨ Create generic command to execute a go template

Summary
This PR adds a utility command that simply executes a given go template with some given data.
It can be helpful in developing Helm charts, and can be used in preliminary development before there is an actual Helm chart.  It can remove the need to make many variants of one config file.
Related issue(s)
Fixes #

/cc @francostellari
/cc @waltforme
/cc @dumb0002
@KPRoche

I tried it. Just one small thing: Maybe we need a few newlines (e.g., at line 85) to make the stderr cleaner?
👉 kubestellar $ ./go-template-execute ~/tmp/todo.tmpl --data-json '{"User": "Jun"}' --data-field-yaml<EMAIL_ADDRESS><!DOCTYPE html>

    <title>Go To-Do list</title>

      To-Do list for user: Jun

          Task
          Done

              		Failed to execute template "/Users/junduan/tmp/todo.tmpl" on map[List:map[List:[map[Done:false Name:kill the bug] map[Done:no Name:fry the eggs]]] User:Jun]: template: todo.tmpl:18:23: executing "todo.tmpl" at <.Name>: can't evaluate field Name in type interface {}👉 kubestellar $ echo $?
80

The force-push to 88d384da adds some missing line terminators.

/lgtm
/approve


Wrong entity port?

Tafas,
I tried to use the regbank.py script to generate a register bank, but It seems the port declarantion in the entity is wrong. Here is an abstract of my script:
   myregbank = registerBank("ssvectors_reg","rtl",32,5)

    myregbank.add(0,"control")
    myregbank.reg[0].add("control_own_addr","ReadWrite",0,4)
    myregbank.reg[0].add("control_rx_buffer","ReadWrite",4,2)
    myregbank.reg[0].add("control_send_type","ReadWrite",6,4)
    myregbank.reg[0].add("control_state","ReadWrite",10,3)
    myregbank.reg[0].add("control_rsv","ReadWrite",13,19)

and I get the following entity declaration :
entity ssvectors_reg is

  generic (

    C_S_AXI_ADDR_WIDTH : integer := 3;

    C_S_AXI_DATA_WIDTH : integer := 32

  );

  port (

    S_AXI_ACLK : in std_logic;

    S_AXI_ARESETN : in std_logic;

    S_AXI_AWADDR : in std_logic_vector(C_S_AXI_ADDR_WIDTH-1 downto 0);

    S_AXI_AWPROT : in std_logic_vector(2 downto 0);

    S_AXI_AWVALID : in std_logic;

    S_AXI_AWREADY : out std_logic;

    S_AXI_WSTRB : in std_logic_vector((C_S_AXI_DATA_WIDTH/8)-1 downto 0);

    S_AXI_WVALID : in std_logic;

    S_AXI_WREADY : out std_logic;

    S_AXI_BRESP : out std_logic_vector(1 downto 0);

    S_AXI_BVALID : out std_logic;

    S_AXI_BREADY : in std_logic;

    S_AXI_ARADDR : in std_logic_vector(C_S_AXI_ADDR_WIDTH-1 downto 0);

    S_AXI_ARPROT : in std_logic_vector(2 downto 0);

    S_AXI_ARVALID : in std_logic;

    S_AXI_ARREADY : out std_logic;

    S_AXI_RDATA : out std_logic_vector(C_S_AXI_DATA_WIDTH-1 downto 0);

    S_AXI_RRESP : out std_logic_vector(1 downto 0);

    S_AXI_RVALID : out std_logic;

    S_AXI_RREADY : in std_logic;

    control_own_addr_o : out std_logic_vector(3 downto 0);

    control_rx_buffer_o : out std_logic_vector(1 downto 0);

    control_send_type_o : out std_logic_vector(3 downto 0);

    control_state_o : out std_logic_vector(2 downto 0);

    control_rsv_o : out std_logic_vector(18 downto 0);

    control_own_addr_o(3 downto 0) : out std_logic_vector(3 downto 0);

    control_rx_buffer_o(1 downto 0) : out std_logic_vector(1 downto 0);

    control_send_type_o(3 downto 0) : out std_logic_vector(3 downto 0);

    control_state_o(2 downto 0) : out std_logic_vector(2 downto 0);

    control_rsv_o(18 downto 0) : out std_logic_vector(18 downto 0)

  );

end ssvectors_reg;

Note how   the registers are doubled in the declaration. E.g.:
control_rx_buffer_o : out std_logic_vector(1 downto 0);
(...)
control_rx_buffer_o(1 downto 0) : out std_logic_vector(1 downto 0);
Is there a problem here in the script or did I misused it?
Cheers,
Tomas
`

Tafas, just some new info. The script output at the console does not have the duplicated ports. Only when it saves to the .vhd file.
Here is the console output:
entity ssvectors_reg is
  generic (
    C_S_AXI_ADDR_WIDTH : integer := 3;
    C_S_AXI_DATA_WIDTH : integer := 32
  );
  port (
    S_AXI_ACLK : in std_logic;
    S_AXI_ARESETN : in std_logic;
    S_AXI_AWADDR : in std_logic_vector(C_S_AXI_ADDR_WIDTH-1 downto 0);
    S_AXI_AWPROT : in std_logic_vector(2 downto 0);
    S_AXI_AWVALID : in std_logic;
    S_AXI_AWREADY : out std_logic;
    S_AXI_WSTRB : in std_logic_vector((C_S_AXI_DATA_WIDTH/8)-1 downto 0);
    S_AXI_WVALID : in std_logic;
    S_AXI_WREADY : out std_logic;
    S_AXI_BRESP : out std_logic_vector(1 downto 0);
    S_AXI_BVALID : out std_logic;
    S_AXI_BREADY : in std_logic;
    S_AXI_ARADDR : in std_logic_vector(C_S_AXI_ADDR_WIDTH-1 downto 0);
    S_AXI_ARPROT : in std_logic_vector(2 downto 0);
    S_AXI_ARVALID : in std_logic;
    S_AXI_ARREADY : out std_logic;
    S_AXI_RDATA : out std_logic_vector(C_S_AXI_DATA_WIDTH-1 downto 0);
    S_AXI_RRESP : out std_logic_vector(1 downto 0);
    S_AXI_RVALID : out std_logic;
    S_AXI_RREADY : in std_logic;
    control_own_addr_o : out std_logic_vector(3 downto 0);
    control_rx_buffer_o : out std_logic_vector(1 downto 0);
    control_send_type_o : out std_logic_vector(3 downto 0);
    control_state_o : out std_logic_vector(2 downto 0);
    control_rsv_o : out std_logic_vector(18 downto 0)
  );
end ssvectors_reg;

It seems to be a problem with function overloading (not sure if this is the correct name, I am not the best in OOP...). When the script calls the parent class writeFile() method, it will run the code() method, but as the object is a instance of RegisterBank, the code() method that will run is the one in class RegisterBank. This method adds the ports once again:
    def code(self):
        self.RegisterPortAdd()
        self.RegisterClearAdd()
        self.RegisterConnection()
        self.RegisterSetConnection()
        self.RegisterClearConnection()
        return vhdl.basicVHDL.code(self)

A possible fix is to remove the self.RegisterPortAdd() and call it before the first code().

no, readwrite ports are indeed getting duplicated. probably because the write function inside of it. I'm on it.

Problem was calling add port everytime code() was called. I devised a fast way to solve, but for more "interactive/wizard mode", if one is to be created in the future, the "generate_code" flag shall be cleaned "manually".


Make all Hadoop related IOs use the same version property

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[ ] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[x] Make sure tests pass via mvn clean verify.
[ ] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

Coverage decreased (-0.007%) to 70.633% when pulling affd54d582d0dcbd8dd04cbcb40a3c4bf745dce3 on iemejia:align-hadoop-version into 462335caf8d148eff8aee86fb00b53960fcd5895 on apache:master.

R: @dhalperi
CC: @jbonofre

Coverage increased (+0.01%) to 70.634% when pulling 41fdee1635ab0320fa250f49ecc574d2d181d945 on iemejia:align-hadoop-version into 0cba43ee26c00ae89f8e681f7fb1f0294aeadb0e on apache:master.

Retest this please

Coverage increased (+0.01%) to 70.634% when pulling 41fdee1635ab0320fa250f49ecc574d2d181d945 on iemejia:align-hadoop-version into 0cba43ee26c00ae89f8e681f7fb1f0294aeadb0e on apache:master.

Coverage increased (+0.01%) to 70.631% when pulling f955f6c82dbb24ca9de895dce4e5db6c061b25f6 on iemejia:align-hadoop-version into 0cba43ee26c00ae89f8e681f7fb1f0294aeadb0e on apache:master.

R: @jbonofre

Can you please rebase (to fix the conflict) ?

Retest this please

Coverage increased (+0.003%) to 70.848% when pulling bcd98f488342563e951df295df5b333ed6a9a170 on iemejia:align-hadoop-version into 5506be87dc3b8f4c4425a259cf255a168fd7b127 on apache:master.

Changes Unknown when pulling d8d8e1fe8ac15c0856bab810d5702f06828dc999 on iemejia:align-hadoop-version into ** on apache:master**.

Thanks, I'm taking a new look and waiting the end of Jenkins.

Coverage remained the same at 70.877% when pulling 3d88bab4951e83142da80912d40592db349f609f on iemejia:align-hadoop-version into 16f87f49f20796e29d01ed363a9097ea5420583c on apache:master.

Let me check why Jenkins fails (by the way, I'm fixing an issue on SpannerIOIT).

Coverage increased (+0.01%) to 70.887% when pulling 63cd02e45d295f0aa8767896e18e276588620470 on iemejia:align-hadoop-version into 16f87f49f20796e29d01ed363a9097ea5420583c on apache:master.

Can you rebase and fix the conflict in order to do a new Jenkins run ? Thanks !

Coverage decreased (-0.01%) to 70.847% when pulling 34aeeeb0bce292695d238e1ac5f90febfb2a00c4 on iemejia:align-hadoop-version into 893bf428a279e4c7f81accdd5e7eb7a4aaebb6b2 on apache:master.

Thanks, please take a look also at my other PR the one on JDK 9, it is quite simple and it would be nice if it also gets included for 2.1.0.


WFLY-6981 Upgrade Weld to 2.4.0.CR1

also remove the dependency on com.google.guava:guava
also remove unused WeldAnnotationDiscovery (http://docs.jboss.org/weld/reference/latest/en-US/html/ri-spi.html#annotationDiscovery)

https://issues.jboss.org/browse/WFLY-6981

Windows Build 5288 outcome was FAILURE using a merge of ab82f28249af8d67d961a20a058b75c407a9bed0
Summary: Tests passed: 761, ignored: 91; compilation error: Compiler (new) Build time: 00:10:33

The windows build fails with strange compilation error:

[org.wildfly:wildfly-weld] [ERROR] /C:/BuildAgent/work/a31d203e70e89f90/weld/src/main/java/org/jboss/as/weld/discovery/WeldAnnotationDiscovery.java:[36,31] package com.google.common.cache does not exist

Note that WeldAnnotationDiscovery class is removed in this pull request.

@stuartwdouglas Could you please review this PR? Thanks!

Looks good to me, other than the module comment above. If these modules are unused they should be removed.

@stuartwdouglas Thanks! Is there a way to detect unused modules?

No, I just happened to know that those two were only used by weld.

@mkouba This is what I use when checking that kind of thing:
taozi:wildfly bstansberry$ git grep ch.qos.cal10n | grep module.xml
feature-pack/src/main/resources/modules/system/layers/base/ch/qos/cal10n/main/module.xml:<module xmlns="urn:jboss:module:1.3" name="ch.qos.cal10n">
feature-pack/src/main/resources/modules/system/layers/base/ch/qos/cal10n/main/module.xml:        <artifact name="${ch.qos.cal10n:cal10n-api}"/>
feature-pack/src/main/resources/modules/system/layers/base/org/jboss/as/weld/main/module.xml:        <module name="ch.qos.cal10n" />
feature-pack/src/main/resources/modules/system/layers/base/org/jboss/weld/core/main/module.xml:        <module name="ch.qos.cal10n" />
feature-pack/src/main/resources/modules/system/layers/base/org/jboss/weld/probe/main/module.xml:        <module name="ch.qos.cal10n" />
feature-pack/src/main/resources/modules/system/layers/base/org/slf4j/ext/main/module.xml:        <module name="ch.qos.cal10n" />

However, ch.qos.cal10n is used by org.slf4j.ext and that module does not have the "private" jboss.api property in module.xml so removing it is a breaking change.

@bstansberry So it can't be removed, right?

@mkouba Correct; it should stay. If @jamezp wants to remove it he should work out how to properly do that; e.g. perhaps add jboss.api="deprecated" for a while.  Also. we're keeping the EAP 7.x branch and WF master in fairly close sync at the moment so for now at least any deprecation/removal plan should be based on upgrading to the next minor (EAP 7.1) as opposed to a major (WildFly 11).

AFAIK org.slf4j.ext was only added for weld. It is not added to the deployment as a dependency by any DUP's, so I think it not being marked private may have been an oversight.

The org.slf4j.ext module has been available since AS 7. I think it was likely not marked as private because org.slf4j was not and the versions should be aligned in most cases. However  org.slf4j.ext is not added to deployments. I don't know if users are adding dependencies to it so I think we would have to deprecate it first.
There is one place in core where the module is used, but we can remove that when we remove the module itself.

@stuartwdouglas @jamezp @bstansberry In any case, removing the modules is a different story - this PR is about Weld upgrade and subsystem cleanup. We're going to release 2.4.0.Final in a few days, so I can update this PR and rename the original issue (WFLY-6981).

Closing in favor of https://github.com/wildfly/wildfly/pull/9185


Getting started section

Body of the issue
https://github.com/inventree/inventree-docs/issues/166

Still important


Compute node restart when safekeeper flush_lsn > VCL

If we'll try to properly ask safekeepers about flush_lsn/VCL (https://github.com/zenithdb/console/issues/127) we can stuck in a basebackup from pageserver as there is no guarantee that pageserver is connected to the safekeeper with maximal VCL. Moreover, we don't have any code to replay piece of WAL between VCL and flush_lsn.
More discussion is in https://discord.com/channels/869525774699462656/877123107448565801/877123110904668161
Out of all the options we decided to use current wal_proposer in postgres to perform synchronization of safekeepers: properly acquire term/generation and commit all the WAL between VCL and flush_lsn on all (majory) safekeepers. After that we can start postgres (we also need to ensure that LSN didn't change in between). Current plan is to write one more separate main function that would call wal_proposer code.

This is how walproposer should be started before basebackup in tests to sync safekeepers:
    sh -c "cd zenith_tmp/compute && VCL=`PGDATA=zenith_tmp/compute postgres --sync-walkeepers` && psql -p6400 -hlocalhost -Xqtc 'basebackup ${TENANT_ID} ${TIMELINE} ${VCL}' | tar -x"


refactor: small project update

:tada: This PR is included in version 0.26.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


TS2454 - Variable is used before being assigned. (Variable is assigned in an always-true condition)

Bug Report

🔎 Search Terms

Variable 'x' is used before being assigned.
TS2454 - Variable is used before being assigned error
var causing TS2454 when flow explicitly sets the value of the var

🕗 Version & Regression Information

This is the behavior in every version I tried, and I reviewed the FAQ for entries about TS2454 - Variable is used before being assigned
The same behavior exists in the Nightly version

⏯ Playground Link

Playground link with relevant code
💻 Code

let condition = true;

if (condition) {

    var x = true;
}

console.log(x);

🙁 Actual behavior
TypeScript throws 'TS2454' "Variable 'x' is used before being assigned."
🙂 Expected behavior
No errors should be thrown since the flow explicitly assigns a value to variable 'x'

Either condition is actually always true, in which case this code is at best in a transient state, or it's not actually always true, in which case the error is correct. Or maybe it really is always true and you can move the console.log inside the block for clarity.

@RyanCavanaugh I appreciate your timely response.
I'm having some difficulty understanding the first part of your answer, could you elaborate on what you meant by the code being in a transient state? Thank you so much.

@thegreatzeus In other words it may be always-true now, but it’s not likely to stay that way—otherwise you wouldn’t have written the if.

Yeah, I use "transient" to mean "a person is in the middle of editing this code" and their likely next action is to either remove the if () { blocking, or change condition's initializer to something dynamic.

Thanks, @fatcerberus and @RyanCavanaugh. I understand the logic.
Have a good rest of your day!


New ROS2 messages for Spot SDK 3.3.2.

In this PR I converted all protobuf files from Spot SDK 3.3.2 into ROS2 messages.

Can you tag the 3.2 messages before committing this? We should make sure we maintain debs for both.

I tagged main with "v3.2.0".

Can you tag the 3.2 messages before committing this? We should make sure we maintain debs for both.

We have releases (amd and arm) for 3.2 and those all have tags associated with them.


sign crashes if key file contains trailing newline

Hi there. I just started playing with wasmCloud and it's going great so far. I started generating my own key files before realizing wash does this automatically if I don't have any, yet.
Anyway, my files ended with a trailing newline and that caused wash claims sign to crash with a syack overflow message:
$ wash claims sign ...
thread 'main' has overflowed its stack
fatal runtime error: stack overflow

You should be able to reproduce like this:
$ wash keys gen account -o json | jq '.seed' -r > account.nk
$ wash claims sign --issuer account.nk path-to-a-wasm-file.wasm --name dummy

What would be the correct behaviour for key files with a trailing newline?

Thanks for the issue @frigus02 🙂 This was actually a bug with the nkeys crate and merged into the main branch yesterday https://github.com/wasmCloud/nkeys/pull/8, so this will be patched very soon with wash. It will just take a version update, if you're compiling from source locally you can try updating your nkeys version in Cargo.toml:
nkeys = "0.0.12"

Regardless, I'll open up a PR for this today so we can get this fixed in the main branch

Thanks for the issue @frigus02 🙂 This was actually a bug with the nkeys crate and merged into the main branch yesterday https://github.com/wasmCloud/nkeys/pull/8, so this will be patched very soon with wash. It will just take a version update, if you're compiling from source locally you can try updating your nkeys version in Cargo.toml:
nkeys = "0.0.12"

Regardless, I'll open up a PR for this today so we can get this fixed in the main branch

To answer your question directly, key files with a trailing newline should not cause a stackoverflow 😄

To answer your question directly, key files with a trailing newline should not cause a stackoverflow 😄

Ha, nice. I did actually look at the nkeys repository but didn't see any open issues. Thanks for the quick response 👍

Ha, nice. I did actually look at the nkeys repository but didn't see any open issues. Thanks for the quick response 👍

wash also depends on wascap and provider-archive which will need to be updated to the newest versions too, I'll tag this issue once I get a PR in for wash but it appears that you'll need to hold on updating the dependency if you built from source. For now I'd just recommend checking your keyfiles for newlines, thanks for your patience @frigus02

wash also depends on wascap and provider-archive which will need to be updated to the newest versions too, I'll tag this issue once I get a PR in for wash but it appears that you'll need to hold on updating the dependency if you built from source. For now I'd just recommend checking your keyfiles for newlines, thanks for your patience @frigus02

No need to hurry. The files that wash creates itself are without newlines anyway. So that's not a big issue.

No need to hurry. The files that wash creates itself are without newlines anyway. So that's not a big issue.

Fixed by #69 , I can't reproduce after the nkeys fix was put into place. Let me know if you run into any other issues @frigus02 !

Confirmed. Works fine with and without trailing newline in v0.1.16 🎉


the api gxlu?email= of gmail no longer active

Sorry for this to say but after testing the api we all using for gmail unlimited account has been disable
its no longer return compass cookies
anyone know how to overcome this or we have to fallback to smtp

It seems to be not working


exp_iter_ratio to cleanly keep track of experiment progress

I briefly tested it, I think this should be functionally equivalent to the previous code... merging.


Ionic2 - banner not showing in production release

It's in my home.ts component.
The app has 2 pages with a side menu. In my android-debug.apk version of the app, when I start the app the banner is immediatly shown.
In the production release, when I first start the app no ads is shown. If I change page and return back to the first page, the ads are shown.
Any clue?
This is the code I'm running for showing the ads.
  ionViewDidEnter() {
    const bannerConfig: AdMobFreeBannerConfig = {
      id: '',
      isTesting: false
    };

    const interstitialConfig: AdMobFreeInterstitialConfig = {
      id: '',
      isTesting: false
    };

    this.admob.banner.config(bannerConfig);
    this.admob.banner.prepare().then(() => {
      this.admob.banner.show();
    })
      .catch(e => console.log(e));

    this.admob.interstitial.config(interstitialConfig);
    this.admob.interstitial.prepare();
 }

I am also experiencing the same issue, also if I show interstitial ads in production build they show test ads.
But there is a workaround if I load the same page again For Example in another tab if my app is having tabs and load admob again, the ads start working just fine.

Is there a way I could "refresh" the page so the ads loads?
On Jul 5, 2017 20:10, "AnuroopGambhir"<EMAIL_ADDRESS>wrote:

I am also experiencing the same issue, also if I show interstitial ads in
production build they show test ads.
But there is a workaround if I load the same page again For Example in
another tab if my app is having tabs and load admob again, the ads start
working just fine.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ratson/cordova-plugin-admob-free/issues/83#issuecomment-313182594,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADLdxX-f-StVaE46STmlf9aRGLtIStvyks5sK9GtgaJpZM4OOVmj
.

I don't know any way to do so, actually, i started to work on ionic for like a month ago. Before this, I used to work on native development with the Android studio.
Even I am finding a workaround for this problem.
I have not slept for like 24 hrs trying to solve this problem searched the whole internet and no results so far,
I accidentally got the workaround I discussed above, but it is also not sufficient. I tried to use AdmobPro also but it makes my app unresponsive.
https://play.google.com/store/apps/details?id=com.admireapps.petrolprices&hl=en
This the link to my app I made a few days ago and it suffers from the same problem, the banner ad is not shown at startup but if i return from another page it is shown.

The weird thing is that it happens only in production mode, at least in my
case. I guess we may try to force page navigation forward and backward.
I hope there's an API to navigate through pages.
On Jul 5, 2017 20:22, "AnuroopGambhir"<EMAIL_ADDRESS>wrote:

I don't know any way to do so, actually, i started to work on ionic for
like a month ago. Before this, I used to work on native development with
the Android studio.
Even I am finding a workaround for this problem.
I have not slept for like 24 hrs trying to solve this problem searched the
whole internet and no results so far,
I accidentally got the workaround I discussed above, but it is also not
sufficient. I tried to use AdmobPro also but it makes my app unresponsive.
https://play.google.com/store/apps/details?id=com.
admireapps.petrolprices&hl=en
This the link to my app I made a few days ago and it suffers from the same
problem, the banner ad is not shown at startup but if i return from another
page it is shown.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ratson/cordova-plugin-admob-free/issues/83#issuecomment-313185666,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADLdxcoyyOMSEcuqRWJdSwGiV9vhu-mXks5sK9R4gaJpZM4OOVmj
.

Same happens in my case too, only production mode is having this bug, debug mode works just fine.

@steoo As your case is to show the banner immediately after it's being prepared why don't you use the autoShow: true in the AdMobFreeBannerConfig? The code you have provided:
this.admob.banner.prepare().then(() => {
      this.admob.banner.show();
    })

I'm not really sure that promise will be resolved when the ad is really prepared - instead it resolves just after the internal admob call has finished.

I'll try but what is this promise provided for so?
On Jul 5, 2017 20:33, "Kamil Rykowski"<EMAIL_ADDRESS>wrote:

@steoo https://github.com/steoo As your case is to show the banner
immediately after it's being prepared why don't you use the autoShow: true
in the AdMobFreeBannerConfig? The code you have provided:
this.admob.banner.prepare().then(() => {
this.admob.banner.show();
})
I'm not really sure that promise will be resolved when the ad is really
prepared - instead it resolves just after the internal admob call has
finished.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ratson/cordova-plugin-admob-free/issues/83#issuecomment-313188424,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADLdxQVk5kMT6Vwc2uD43jVFcA2oUa66ks5sK9bhgaJpZM4OOVmj
.

I have tried that too, many of the times it shows nothing.
And there is already an open issue with the same topic.
https://github.com/ratson/cordova-plugin-admob-free/issues/74

i did have this issue, the problem was how the config was set for banner or interstitial ads.
Now is working.
This is my AdMob free services:
import { Injectable } from '@angular/core';
import { AdMobFree, AdMobFreeBannerConfig, AdMobFreeInterstitialConfig } from '@ionic-native/admob-free';
interface AdMobType {
banner: string,
interstitial: string
}
@Injectable()
export class AdMobService {
admobid: AdMobType;
private bannerPrepared: boolean = false;
private interstitialPrepared: boolean = false;
constructor(private adMob: AdMobFree) {

    if (/(android)/i.test(navigator.userAgent)) {
        this.admobid = {
            banner: 'ca-app-pub-xxx/xxx',
            interstitial: 'ca-app-pub-xxx/xxx'
        };
    } else if (/(ipod|iphone|ipad)/i.test(navigator.userAgent)) {
        this.admobid = {
            banner: 'ca-app-pub-xxx/xxx',
            interstitial: 'ca-app-pub-xxx/xxx'
        };
    } else {
        this.admobid = {
            banner: 'ca-app-pub-xxx/xxx',
            interstitial: 'ca-app-pub-xxx/xxx'
        };
    }
}

prepareBanner() {
    const bannerConfig: AdMobFreeBannerConfig = {
        id: this.admobid.banner,
        size: 'SMART_BANNER',
        autoShow: true,
        isTesting: false,
        bannerAtTop: false,
        overlap: false,
        offsetTopBar: false
    }
    this.adMob.banner.config(bannerConfig);
    this.adMob.banner.prepare().then(() => {
        this.bannerPrepared = true;
    }).catch((err) => {
       throw new Error(err);
    });
}
showBanner() {
    if (this.bannerPrepared) {
        this.adMob.banner.show().then(() => {
            this.bannerPrepared = false;
        }).catch((err) => {
            throw new Error(err);
        });
    }
}
hideBanner() {
    this.adMob.banner.hide().then(() => {
        this.bannerPrepared = true;
    }).catch((err) => {
        throw new Error(err);
    });
}
removeBanner() {
    this.adMob.banner.remove().then(() => {
        this.bannerPrepared = false;
    }).catch((err) => {
        throw new Error(err);
    });
}
prepareInterstitial() {
    const interstitialConfig: AdMobFreeInterstitialConfig = {
        id: this.admobid.interstitial,
        isTesting: false,
        autoShow: false
    };
    this.adMob.interstitial.config(interstitialConfig);
    this.adMob.interstitial.prepare().then(() => {
        this.interstitialPrepared = true;
    }).catch((err) => {
        throw new Error(err);
    })
}
showInterstitial() {
    if(this.interstitialPrepared) {
        this.adMob.interstitial.show().then(() => {
            this.interstitialPrepared = false;
        }).catch((err) => {
            throw new Error(err);
        });
    }
}

}

How showBanner is supposed to be called? Is it listening to some events?

@caciobanita Thanks, man you are a life saver, interstitial ads working fine now. But reward video ads not working yet.
@steoo You are supposed to call the method showbanner() and showinterstitial() when needed. For banner best place would be the constructor of the page.

What is the point of calling show() if autoShow is set to true?

well, in that case, you don't need to call, but in the example given be @caciobanita he didn;t set  autoShow to true .

Hello, Everyone, I found very simple solution for this :)
Just use the banner add in your root component i.e app.component.ts ( Remove banner ad from other pages of your app )
this.platform.ready().then(() => {
// Here you have to set banner ads :)
this.showBanAd();
this.splashScreen.hide();
});
Here is my app running banner ad : https://play.google.com/store/apps/details?id=com.fuelpriceindia.android&hl=en
Other ads like interstitial can in other components as per your app.

@rapiddevpro thanks, it works for me :)

@rapiddevpro
It worked for me too, it's a shame, I had to remove the intersticial


Style scan screen

styled scan screen and select language screen
Could you check the scan-screen in your android device as I'm not really sure if it's working well in my environment?

fixed variant
add change reflecting Adele's suggestion


Increase limits for CoreDNS + blackbox-exporter

What this PR does / why we need it:
We sometimes observe that the blackbox-exporter cannot properly report the API server availability as either itself gets CPU-throttled or CoreDNS gets CPU-throttled or its request times out (probably related to the CPU-throttling itself, but may also occur for shoots where the worker nodes are far away from the control plane).
This PR adapts the limits slightly and increases the timeout for the BBX. It should prevent false negative API reports from the BBX.
Special notes for your reviewer:

/cc @vlerenc
We are having a HorizontalPodAutoscaler for CoreDNS that scales between 2-5 replicas and for 80% target CPU average utilization. However, this seems to not work too well, so we should revisit this again.

Release note:

The CPU limits for the `coredns` and `blackbox-exporter` deployments in the shoot have been slightly increased to prevent false negative API server availability reports.

Thanks a lot @rfranzke. And also to you @ggaurav10.

/kind/bug


Update aws-core, http-client-spi, ... to 2.20.130

About this PR
📦 Updates

software.amazon.awssdk:aws-core
software.amazon.awssdk:http-client-spi
software.amazon.awssdk:netty-nio-client

from 2.20.120 to 2.20.130
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "software.amazon.awssdk" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #1229.


AndroidManifest.xml do not contains default_notification_icon tag when updated to firebase 6.15.0 and use UnityPackageManager

Please fill in the following fields:
Unity editor version: 2018.4.9f1
Firebase Unity SDK version: 6.15.0
Source you installed the SDK (.unitypackage or Unity Package Manager): Unity Package Manager
Firebase plugins in use (Auth, Database, etc.):Firebase Cloud Messaging
Additional SDKs you are using (Facebook, AdMob, etc.): none
Platform you are using the Unity editor on (Mac, Windows, or Linux): Mac
Platform you are targeting (iOS, Android, and/or desktop): iOS/Android
Scripting Runtime (Mono, and/or IL2CPP):Mono and IL2CPP
Please describe the issue here:
When I use firebase of ver6.5.0, it builds successfully.
Last week we had to update firebase to ver6.15.0 to resolve an error of Firebase.Messaging.FirebaseMessaging.SubscribeAsync("/topics/example").
After we update firebase to ver6.15.0(Unity Package Manager), it works again but show incorrect icon on Android.
Finally we found that
<meta-data android:name="com.google.firebase.messaging.default_notification_icon"
android:resource="@drawable/notification_icon" />

disappeared from AndroidManifest.xml after updated.
Assets/Plugins/Android/Firebase/AndroidManifest.xml and
Assets/Plugins/Android/AndroidManifest.xml  were deleted when update to Unity Package Manager.
I tried to restore Assets/Plugins/Android/AndroidManifest.xml but another build error occoured .
Please answer the following, if applicable:
Have you been able to reproduce this issue with just the Firebase Unity quickstarts (this GitHub project)?
I tried to do the same thing with this GitHub project and reproduced this issue.
What's the issue repro rate?  → 100%
AndroidManifest.xml.zip

Thanks for this bug report! does this occur if you don't use UPM as well?

Hi @square1983
I think the issue is that when you migrate Firebase to Unity Package Manager (UPM), EDM4U thinks Assets/Plugins/Android/AndroidManifest.xml and Assets/Plugins/Android/Firebase/AndroidManifest.xml are both part of the package (See Assets/Firebase/Editor/FirebaseMessaging_version-6.15.0_manifest.txt). What happen after the migration is

Both AndroidManifest.xml are removed from Assets folder
Once migration is done, Firebase.Editor.dll should be enabled and generate Assets/Plugins/Android/Firebase/AndroidManifest.xml again.
Firebase.Messaging.Editor.dll should also be enabled and generate Assets/Plugins/Android/AndroidManifest.xml as the one came with Firebase SDK.

About Assets/Plugins/Android/Firebase/AndroidManifest.xml, are you sure this file is not generated after migration?  Perhaps wait for a couple of seconds?
About Assets/Plugins/Android/AndroidManifest.xml, I think the best approach is to revert the changes with your version control tool.  We are thinking about a better way to modify AndroidManifest.xml instead of including it with the package.  Will let you know when the feature is finished.
If the problem is still not resolved, could you include the error message to this post?
Thank you,
Shawn

Thanks for this bug report! does this occur if you don't use UPM as well?

I have some troubles(build error or Unity Editor error occurs) when not use UPM.

Hi @square1983
I think the issue is that when you migrate Firebase to Unity Package Manager (UPM), EDM4U thinks Assets/Plugins/Android/AndroidManifest.xml and Assets/Plugins/Android/Firebase/AndroidManifest.xml are both part of the package (See Assets/Firebase/Editor/FirebaseMessaging_version-6.15.0_manifest.txt). What happen after the migration is

Both AndroidManifest.xml are removed from Assets folder
Once migration is done, Firebase.Editor.dll should be enabled and generate Assets/Plugins/Android/Firebase/AndroidManifest.xml again.
Firebase.Messaging.Editor.dll should also be enabled and generate Assets/Plugins/Android/AndroidManifest.xml as the one came with Firebase SDK.

About Assets/Plugins/Android/Firebase/AndroidManifest.xml, are you sure this file is not generated after migration? Perhaps wait for a couple of seconds?
About Assets/Plugins/Android/AndroidManifest.xml, I think the best approach is to revert the changes with your version control tool. We are thinking about a better way to modify AndroidManifest.xml instead of including it with the package. Will let you know when the feature is finished.
If the problem is still not resolved, could you include the error message to this post?
Thank you,
Shawn

Both of the two AndroidManifest.xml are not generated after migration in my case.
The inspector of that two dll is grayout.

@chkuang-g
I think I know why AndroidManifest.xml was not generated in my case.
I updated firebase unter Unity Platform iOS and the migration removes all the xml files as you said before. After migration I tried to build for iOS and it worked, so I thought the migration was over and commited the changes to github.And then I pulled the changes in another folder(because swtich platform to Android cost long time) and Unity generated AndroidManifeset.xml this time.Maybe the new generated xml files are different from the origin files causes the default_notification_icontag lost.
I think I know how to resolve this.
@chkuang-g  @patm1987
Thank you very much.


DocsArchive-<IP_ADDRESS>Auto archive content

Auto archive content from https://github.com/opstest2/docs-archive-test-source.git

Docs Build status updates of commit 07b254f:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


UI - Make Category/Acknowledgement info button grow on hover

To: @JackLeerson
Cc: @adamcogan @christianmorfordwaitessw
As per our conversation:

Update the info buttons on the Category/Acknowledgment sections to grow on hover.

Figure: Current on hover behaviour

AB#60099

To: @JackLeerson
Cc: @adamcogan @bradystroud
Done - button now grows with a 0.2s transition like the reactions.

Figure: icon has grown on hover.


Add selector hasAttribute method (closes #1045)

\cc @helen-dikareva @AlexanderMoskovkin

@testcafe-build-bot \retest

It looks like this never made it into the documentation.

@noderat you can find it here in Method section


Bubble sort implementation in C

#16 added the c implementation of bubble sort.

please check @ashwanisng

Great, thanks!
@all-contributors please add @sparkingdark for code.


Roll engine be973ea19612..72c7a7567228 (1 commits)

https://github.com/flutter/engine/compare/be973ea19612...72c7a7567228
git log be973ea19612..72c7a7567228 --no-merges --oneline
72c7a7567 Prepend [NSLocale currentLocale] for first locale on iOS to ensure countryCode exists. Allow language-only locales. (flutter/engine#6995)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/5949335508353024


create logs for tasks update and user update

There is a log endpoint that already exists, we need to create a log everytime a user updates the task or updates his user object

currently, I only need it for tasks and @ivinayakg has done this task in one of his PR, so closing this


[gRPC]Fix special character issue in generated code(master)

Purpose
Fix the error in the generated code when there is ballerina keyword
Fixes #23801
Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #24041 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #24041   +/-   ##
=======================================
  Coverage   14.59%   14.59%
=======================================
  Files          51       51
  Lines        1411     1411
  Branches      219      219
=======================================
  Hits          206      206
  Misses       1189     1189
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00fbf3d...8ee03c5. Read the comment docs.


[11.x] Add throttle method to LazyCollection

Allows throttling the values retrieved from a lazy collection:
LazyCollection::times(3)->throttle(seconds: 1)->each(function ($number) {
    dump($number); // Will dump each number, with a pause (sleep) of about a second in between each...
});

Note: The sleep will not be 1 second. That would be quite naïve. Instead, it includes the time it takes to process each retrieved value, and only sleeps for the remainder of the duration.

Especially useful when interacting with external APIs, which may have some rate limits. Can be used both for pulling data as well as for pushing data.
Pulling data example:
$userIds = collect([1, 2, 3])->lazy();

$users = $userIds
    ->throttle(1)
    ->map(fn ($userId) => API::fetchUser($id));

Or, if the external API supports fetching, say, 50 users at once:
$userIds = collect([1, 2, 3, /* ... */])->lazy();

$users = $userIds
    ->chunk(50)
    ->throttle(1)
    ->map(fn ($userIds) => API::fetchUsers($userIds))
    ->flatten();

Pushing data example:
$userIds = collect([1, 2, 3])->lazy();

$userIds
    ->throttle(1)
    ->each(fn ($userId) => API::deleteUser($id));

Here's a real-world use case, which would be vastly simplified after this PR:
DB::table('stock_sync')->cursor()->throttle(1)->map(function ($sync) {
    // Handle stock sync updates...
});

This is pretty sick.


lis3mdl: Fix check_calibration() output

The previous implementation returned OK when the sensor was not calibrated and vice
versa. This fixes
PREFLIGHT FAIL: MAG 1 SELFTEST FAILED

due to failed check_calibration().
@klopezal Can you verify this is correct?

Absolutely. Comes from confusion between, bool/int/OK/NOT OK from previous pull request.


Interactive plot_state() is missing the 'wigner' method

Informations

Qiskit Terra version: Latest master
Python version: Any
Operating system: Any

What is the current behavior?
The plot_state() function exposes a wigner method when running in mpl mode, but this not a valid method when using interactive mode.
Steps to reproduce the problem
Try to run plot_state() in jupyter with mode='interactive' and method='wigner'.
What is the expected behavior?
plot_state() exposes the same plotting methods between interactive and local mpl mode.
Suggested solutions
Either add it to interactive or remove it from plot_state. Depends on the result of #1106

@filemaster is this something you can support?

I will take a look... It will require to generate a new interactive visualization mode.

@ajavadia, I was taking a look to the Wigner method. It seems to work only with Tomography module and I tried to generate data from this module to populate the figure, but the Tomography module  seems to be broken.

closing as we are not supporting the standard version.


Enhanced SQLColumns interface to support view && Add view test cases

Fixed bug that causes errors while reading views after PowerBI updates

LGTM


Add Logging Support

Set up logging for some modules, to get a norm established for DEBUG logging, etc.
Maybe start with ops.py

The distributed package has a logger set up, so that's a start.  But, having a centralized standard approach to logging would be good.

From https://docs.python-guide.org/writing/logging/
"Best practice when instantiating loggers in a library is to only create them using the name global variable: the logging module creates a hierarchy of loggers using dot notation, so using name ensures no name collisions.
"Here is an example of the best practice from the requests source – place this in your init.py:
import logging
logging.getLogger(__name__).addHandler(logging.NullHandler())

And from https://docs.python.org/3/howto/logging.html#library-config
"When developing a library which uses logging, you should take care to document how the library uses logging - for example, the names of loggers used. Some consideration also needs to be given to its logging configuration. If the using application does not use logging, and library code makes logging calls, then (as described in the previous section) events of severity WARNING and greater will be printed to sys.stderr. This is regarded as the best default behaviour.
"If for some reason you don’t want these messages printed in the absence of any logging configuration, you can attach a do-nothing handler to the top-level logger for your library. This avoids the message being printed, since a handler will always be found for the library’s events: it just doesn’t produce any output. If the library user configures logging for application use, presumably that configuration will add some handlers, and if levels are suitably configured then logging calls made in library code will send output to those handlers, as normal.
"A do-nothing handler is included in the logging package: NullHandler (since Python 3.1). An instance of this handler could be added to the top-level logger of the logging namespace used by the library (if you want to prevent your library’s logged events being output to sys.stderr in the absence of logging configuration). If all logging by a library foo is done using loggers with names matching ‘foo.x’, ‘foo.x.y’, etc. then the code:
import logging
logging.getLogger('foo').addHandler(logging.NullHandler())

should have the desired effect. If an organisation produces a number of libraries, then the logger name specified can be ‘orgname.foo’ rather than just ‘foo’.
"Note It is strongly advised that you do not add any handlers other than NullHandler to your library’s loggers. This is because the configuration of handlers is the prerogative of the application developer who uses your library. The application developer knows their target audience and what handlers are most appropriate for their application: if you add handlers ‘under the hood’, you might well interfere with their ability to carry out unit tests and deliver logs which suit their requirements."

Discussion with @markcoletti and @lukepmccombs

It's easy to log too much when dealing with heavy algorithms like EAs... so we won't bother with trying to have a prolix DEBUG logging convention
For this issue, we need only add a few INFO logging to some high-level modules/functions (ex. algorithm begins, generation count), so a norm is in place.


FID problem

Hello, thank you for sharing the code of SeeSR! That's an amazing work indeed!
When I tried to calculate the metric FID using the code proposed in basicsr/metrics/fid.py, the result was quite confusing.
Here is how I calculate the metric FID. If any problem, feel free to point out.

First, I defined a function which outputs a list composed of all images.

Then, I processed SR images and GT images, respectively, using inception_v3 to extract features and calculating FID.
As for the results, when the param normalize_input set to False, I got FID =<PHONE_NUMBER>9991415.
And when the param normalize_input set to True, I got FID =<PHONE_NUMBER>351401.
Both of them are quite higher than the paper mentioned, this makes me realize which step seems to have gone wrong.
Could you please give me some advice? And whether the param normalize_input should be set to True or not?
Thanks a lot!

Hello, I use pyiqa for metrics calculating, please follow the instruction of IQA-PyTorch

BTW, I think the FID calculation on a small-scale dataset is not appropriate. ref


[Bug-Error]-creating-smart-account

Hello, I am following the steps to have a kernelClient so the users will be able to use my App but I am getting this error on my terminal when I add createKernelAccount abd reload the page. I use bun as package Manager
Create Account

If I added without refreshing the website, get this error but maybe because I can't do a writeContract function?

The method is on a separted folder where I handle web3Methods
import { signerToEcdsaValidator } from "@zerodev/ecdsa-validator"
import { createKernelAccount, createKernelAccountClient } from "@zerodev/sdk"
import { createPublicClient, Hex, http } from "viem"
import { privateKeyToAccount } from "viem/accounts"
import { polygonMumbai } from "viem/chains"

import { memeMulticallAbi } from "./abis/memeMulticall"
import { memeRouterAbi } from "./abis/memeRouter"
import { ADDRESS_ZERO, CONTRACTS } from "./constants"
const publicClient = createPublicClient({
  chain: polygonMumbai,
  transport: http(),
})

export const createMeme = async ({
  account,
  amount,
  name,
  symbol,
  uri,
}: {
  account: ADDRESS
  amount: bigint
  name: string
  symbol: string
  uri: string
}) => {
  const privateKey = process.env.NEXT_PUBLIC_API_KEY
  const signer = privateKeyToAccount(privateKey as Hex)

  const ecdsaValidator = await signerToEcdsaValidator(publicClient, {
    signer,
  })

  const accountClient = await createKernelAccount(publicClient, {
    plugins: {
      validator: ecdsaValidator,
    },
  })

  const kernelClient = createKernelAccountClient({
    account: accountClient,
    chain: polygonMumbai,
    transport: http(
      `https://rpc.zerodev.app/api/v2/bundler/${process.env.NEXT_PUBLIC_BUNDLE_ID}`
    ),
  })

  // Simulate the method that I want to call
  const { request } = await publicClient.simulateContract({
    address: CONTRACTS.memeRouter,
    abi: memeRouterAbi,
    functionName: "createMeme",
    args: [name, symbol, uri],
    value: amount,
    account,
  })
  console.log(request)
  const tx = await kernelClient.writeContract(request)
  console.log("tx ", tx)
}

If I install permissionless I got now this error
SyntaxError: The requested module 'permissionless' does not provide an export named 'walletClientToCustomSigner'
"permissionless": "^0.0.34",
"@zerodev/ecdsa-validator": "^5.0.2",
"@zerodev/presets": "^5.1.1",
"@zerodev/sdk": "^5.0.4",

Hi @nico-limo, can you update to the latest version of the SDK?


Update the vim modeline comment to not error

The currently suggested vim modeline formatting string to allow .livemd files to render as markdown on GitHub works, but confuses vim itself.
<!-- vim: syntax=markdown -->

When opening a .livemd file with the suggested modeline in vim it errors when it tries to parse --> as a modeline option.
e.g.
"2021/day2.livemd" 81L, 1616B
Error detected while processing modelines:
line    1:
E518: Unknown option: -->

The fix is to replace the suggested vim modeline
<!-- vim: syntax=markdown -->

With a modeline declaration format that indicates when the modeline options are complete, allowing vim to ignore the rest of the line.
<!-- vim: set syntax=markdown: -->

Reference

vim issue: https://github.com/vim/vim/issues/1648
especially this comment: https://github.com/vim/vim/issues/1648#issuecomment-296386153

Fixes #773

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Unused counter is a bit broken

Watching changes does not trigger lost matches!

Oops, false alarm - misread a bug.


Enable Additional Properties for specialist topic schema

This will allow us to set a flag to determine if a topic was
created as a duplicated Mainstream Browse page for the ongoing
merge and migration away from said Browse pages.
As per usual, the main change is the .jsonnet, with other changes
being automatically generated.
https://trello.com/c/kWnWyEji/857-add-a-mainstream-flag-for-the-specialist-topic-content-schema-type

Great stuff! My only thought atm is that these eventually wouldn't be a copy but I understand why we're trying to differentiate these from the other tree. Thoughts?

Great stuff! My only thought atm is that these eventually wouldn't be a copy but I understand why we're trying to differentiate these from the other tree. Thoughts?

I agree, but it depends on how we're handling these after the fact. Are we intending on removing them entirely (migrate content off them into existing and new specialist topics) or are we intending on "switching them on" at some point and make them visible. If the latter, then yes a new name for the field would be best. mainstream_browse_derived perhaps?

mainstream_browse_type is sensible, making the change now!

@chao-xian 🎉 CI runs passing


build: add exclusion for asoc false positive

This PR simply updates the appscan-config.xml file to add a new exclusion for request-wrapper.ts
Checklist

[ ] npm test passes (tip: npm run lint-fix can correct most style issues)
[ ] tests are included
[ ] documentation is changed or added

I'm going to hold off on merging this to see if the recently-opened ASOC issues end up being closed automatically.  I think all of our issues that were opened last night have an ASOC status = "Noise" (this is visible in the corresponding HTML report) which means a false positive.  I don't think these new git issues should have even been opened automatically.


Treat archive files and directories as resources?

I have a working design that extracts the archive and manages each file within as a separate resource, which ensures that changes to the extracted package are remediated during convergence. Is this a feature that could be accepted in this cookbook?

You mean for idempotence tracking? unfortunately that would be both slow and frustrating. Would be better to store stuff externally, like just keep the hashes in a JSON file or something. Seems like a low-benefit change though for very high complexity and adding structural invariants.
I purposefully structured this as non-idempotent except for the URL-based case. It's not perfect but I think it makes it a bit easier to understand at least.

😭

If you can show how to make it work without being a major perf impact or being brittle, I'm certainly open to look at it )

🍾


Stress test stopflow plan

As a user I would like assurance that the stopflow plan can reliably work at the max. framerate of the pilatuses.
This depends on https://github.com/bluesky/ophyd-async/issues/355
Exact test parameters to be defined:

Desired exposure time
Number of frames

Acceptance Criteria

Test(s) conducted
Results published in this issue

how would this testing go then?

We would simply run the plan with appropriate parameters such that the panda will trigger the pilatus(es) as fast as they can go, according to their specifications (exact speed TBC with the beamline).
This has required us to correct ophyd-async's understanding of the pilatus' readout time: https://github.com/bluesky/ophyd-async/pull/359
So that change should be released and we should wait until the beamline is available again, then this work can go ahead.

https://github.com/DiamondLightSource/i22-bluesky/issues/35#issuecomment-2165317015

Detector stalling issues should be fixed by: https://github.com/bluesky/ophyd-async/pull/401


Add set's icon to each set in the set combobox

Hello,
Some new players aren't may mix set name (e.g. Ravnica block). I think we could enhance the UI by adding set's icon to each set in the set combobox. What do you think?

It would take a bit more space though. It could be problematic.
related to https://github.com/Senryoku/MTGADraft/issues/8

IIRC I tried to do it but had some issues with vue-multiselect, or it was just to save space, I don't remember. Give it a try if you want!

https://github.com/Senryoku/MTGADraft/pull/42


rollback LeaseDurationSeconds code for backward compatible

see https://github.com/open-cluster-management/backlog/issues/5568

/assign @qiujian16

/approve
/lgtm


Fix bug that broke signatures

/cc @cardil @kvmware @BobyMCbobs
The change in #268 broke image signatures. I'm also copying the image refs and attestations to the artifacts folder for easy verification.
I need to write a tool a to easily check sigstore signatures on all the nightly jobs.

/retest

Thanks for the fix @upodroid!


How to generating voxelized models & rendering images from the ShapeNet v1 dataset?

I only found a preprocessed dataset download link in your repo, but I'm interested in how voxelization and rendering is done from the original ShapeNet v1 dataset. Can you shed light on how these 2 processes are done or are there any code that I can refer to? Thanks

Same question here. Do we need to "fake" camera intrinsic matrix?

I am also very interested in this.

totally agree, I have no idea about this issue. where can I find it ?

The author released the rendering script in this commit. After some sort of modification you can use it to render the view images by blender --python blender_render.py.(Install blender first)

As for rendering images, I modified the script (added some more features). I'll post a link to my repo when im finished.

@markuspaschi Could you kindly share your rendering script?

I modified the script and made it work on ShapeNet.v1/
Here are some hints (Working on Ubuntu 16.04):

If you install blender by apt install blender, the blender you got will be 2.76b and should have no numpy. You cannot easily install numpy for the python environment of blender.
You cannot import config even if it's in the same dir. Modify such import into a single blender_render.py instead.
Use for loop to render 24 views of each model
Use python.multiprocess or python.thread or blender -t to accelerate the whole process.

Optional: if you want to get the depth map as well, use OpenEXR first (thus blender's output format is OpenEXR) and then tranfer it into pngs you want.

@AlexsaseXie I have the same problem of the image generating.
Could you tell me how can I render the different-view image of models? There is something wrong that No module name bpy when I run the python script (blender_renderer.py) directly. Now I can do nothing with the script and feel confused.
Look forward to your reply. Thank you!

@AlexsaseXie  Could you share the modified script? I have the same problem on image rendering and try a lot. But it doesn't work.
Look forward to your reply. Thank you!!

Hi @AlexsaseXie ，how did you set the value of "cfg.RENDERING.MAX_CAMERA_DIST" in blender_renderer.py?
And could you please share anything else that need to be modified?

Hi @AlexsaseXie ，how did you set the value of "cfg.RENDERING.MAX_CAMERA_DIST" in blender_renderer.py?
And could you please share anything else that need to be modified?

That value is 1.75.
I got that from https://github.com/jgwak/McRecon/blob/b90acc3017ba2dbb99ef13bb2033be30059d7108/lib/get_projection.py#L72 which tells you have to generate camera matrix from the parameters of 3D-R2N2.

Thank you very much. @AlexsaseXie

I wrote a Master Thesis about 3D-Methods including Pixel2Mesh (in German). But my repository can be found here:
https://github.com/markuspaschi/ShapeNetTools
Go into DataSet_Tools/Renderer to find hints about how I used the blender renderer to create images.
I changed some parameters, its probably not perfect (but it may be a starting point for some people).

I modified the script and made it work on ShapeNet.v1/
Here are some hints (Working on Ubuntu 16.04):

If you install blender by apt install blender, the blender you got will be 2.76b and should have no numpy. You cannot easily install numpy for the python environment of blender.
You cannot import config even if it's in the same dir. Modify such import into a single blender_render.py instead.
Use for loop to render 24 views of each model
Use python.multiprocess or python.thread or blender -t to accelerate the whole process.

Optional: if you want to get the depth map as well, use OpenEXR first (thus blender's output format is OpenEXR) and then tranfer it into pngs you want.

Thanks for you sharing.
When i run blender_render.py, i have met some errors,
eg.
KeyError: 'bpy_prop_collection[key]: key "Lamp" not found'
AttributeError: 'BlendData' object has no attribute 'lamps'
I have no ideal about how to deal with these errors.

Thanks a lot.

This may be late but you are probably using a new blender api (2.91) which doesn't support these attributes. You should use version 2.79 of blender and blenderpy, the first one is easy to install but I am struggling but the second one (blenderpy).

This may be late but you are probably using a new blender api (2.91) which doesn't support these attributes. You should use version 2.79 of blender and blenderpy, the first one is easy to install but I am struggling but the second one (blenderpy).

Hi @AlexsaseXie, have you found how to generate voxelized models? I'm also interested in it.

Hi @AlexsaseXie @markuspaschi , do you know why the colors of the model in rendered images are different in ubuntu and windows though I have set the color_model to RGBA ?
The model in meshlab

In Ubuntu (blender 2.79)

In Windows (blender 2.79)

I modified the script and made it work on ShapeNet.v1/
Here are some hints (Working on Ubuntu 16.04):

If you install blender by apt install blender, the blender you got will be 2.76b and should have no numpy. You cannot easily install numpy for the python environment of blender.
You cannot import config even if it's in the same dir. Modify such import into a single blender_render.py instead.
Use for loop to render 24 views of each model
Use python.multiprocess or python.thread or blender -t to accelerate the whole process.

Optional: if you want to get the depth map as well, use OpenEXR first (thus blender's output format is OpenEXR) and then tranfer it into pngs you want.

Thanks for you sharing. When i run blender_render.py, i have met some errors, eg. KeyError: 'bpy_prop_collection[key]: key "Lamp" not found' AttributeError: 'BlendData' object has no attribute 'lamps' I have no ideal about how to deal with these errors.  Thanks a lot.

have you solved these problems? Could you share the methods?

This may be late but you are probably using a new blender api (2.91) which doesn't support these attributes. You should use version 2.79 of blender and blenderpy, the first one is easy to install but I am struggling with the second one (blenderpy).

Could you tell me how to download blenderpy2.79?


Bug in asset loading

Bevy version
Using git bisect show 57a175f54606434242bfcf5ee2aaef121bdb370a as the commit which introduced the issue.
cc @bushrat011899
What you did
Run my Bevy app.
What went wrong
Panic in asset on getting infos.
For me it seems to relate to loading things within a gltf model- if I add some more logging around the bad unwrap I see the asset path is stuff like a Mesh1 or Animation1 within one of my gltf models.
Additional information
Other discord users hit the same issue:
https://discordapp.com/channels/691052431525675048/749332104487108618/1176633456835428453
That backtrace points to: https://github.com/bevyengine/bevy/blob/57a175f54606434242bfcf5ee2aaef121bdb370a/crates/bevy_asset/src/server/info.rs#L196
which I have hit as well.
But I have also hit this one: https://github.com/bevyengine/bevy/blob/57a175f54606434242bfcf5ee2aaef121bdb370a/crates/bevy_asset/src/server/info.rs#L397
and the same discord user has hit this one:
https://github.com/bevyengine/bevy/blob/57a175f54606434242bfcf5ee2aaef121bdb370a/crates/bevy_asset/src/server/info.rs#L410

Found it.
Your mentioned PR added hashing the typeid next to the asset id for Handles: https://github.com/bevyengine/bevy/blob/main/crates/bevy_asset/src/handle.rs#L225-L226
But the typeid is already hashed inside AssetId: https://github.com/bevyengine/bevy/blob/main/crates/bevy_asset/src/id.rs#L118-L119
So we are hashing the typeid 2 times for a typed asset id.
I wonder how the tests, which should assert that typed and untyped are the same didnt fail

I'll start looking into this once I get home. That commit should only have a handful of observable changes that could even be the cause of any change in behavior.

Found it.
Your mentioned PR added hashing the typeid next to the asset id for Handles: https://github.com/bevyengine/bevy/blob/main/crates/bevy_asset/src/handle.rs#L225-L226
But the typeid is already hashed inside AssetId: https://github.com/bevyengine/bevy/blob/main/crates/bevy_asset/src/id.rs#L118-L119
So we are hashing the typeid 2 times for a typed asset id.
I wonder how the tests, which should assert that typed and untyped are the same didnt fail

The UntypedAssetId and handle should have the exact same hashing function as the typed version, including hashing the type twice. If that is the cause, I'm even more confused.

This looks like a race condition, likely the same one in #10688. Running alien_cake_addict multiple times in release mode (same binary) will produce anything from a crash on load, through to running the game correctly, through to not loading some of the models, etc.

Found it.
Your mentioned PR added hashing the typeid next to the asset id for Handles: https://github.com/bevyengine/bevy/blob/main/crates/bevy_asset/src/handle.rs#L225-L226
But the typeid is already hashed inside AssetId: https://github.com/bevyengine/bevy/blob/main/crates/bevy_asset/src/id.rs#L118-L119
So we are hashing the typeid 2 times for a typed asset id.
I wonder how the tests, which should assert that typed and untyped are the same didnt fail

The UntypedAssetId and handle should have the exact same hashing function as the typed version, including hashing the type twice. If that is the cause, I'm even more confused.

Really sorry to tell you:
https://github.com/bevyengine/bevy/blob/main/crates/bevy_asset/src/handle.rs#L395-L396
https://github.com/bevyengine/bevy/blob/main/crates/bevy_asset/src/id.rs#L283-L284
May the confusion be with you :>

Below is an example of one of the times alien_cake_addict ran, but clearly failed to load assets:


Go1.13 build fix: go.mod: go1.12 => go1.13

Using go1.13.7 for building my project (that uses github.com/y0ssar1an/q as a dependency) I got the error:
<EMAIL_ADDRESS>requires
<EMAIL_ADDRESS>requires
<EMAIL_ADDRESS>invalid version: unknown revision 2cefd77fef9b

I've cloned the repository, made local changes in go.mod (just set up go1.13)
index 86f936a..092e9a3 100644
--- a/go.mod
+++ b/go.mod
@@ -1,5 +1,5 @@
 module github.com/y0ssar1an/q

-go 1.12
+go 1.13

 require github.com/kr/pretty v0.2.0
(END)

used the 'replace' in my project's go.mod (from github.com/y0ssar1an/q to local copy) - and that helped.
At the same time, it works without any go.mod changes when I used go1.12.13 for the project build.
Also, after making these go.mod changes I stay able to build the project using go1.12.
It seems it could be better to use go1.13 in master to avoid problems like this one.

First, thank you very much for the PR!
<EMAIL_ADDRESS>requires
<EMAIL_ADDRESS>requires

Hmm, that's very strange. v1.0.8 shouldn't have any dependency on golangci-lint. This must be some modules weirdness that I don't understand. I know there were changes modules behavior from 1.12 -> 1.13.
Even though we don't have a root cause, I still want to merge this. Go 1.14 is about to land, and I only want to support the last two releases of the compiler. Thanks again for providing this fix!

I released v1.0.9, which contains this fix. I hope bumping the version solves your problem 👍


Create MimeType constants for the Attachments object

Issue Summary
Here is an example. The MimeTypes should be defined .in a new file /mail/AttachmentMimeType.php. Please use this list.

Hi @thinkingserious,
Should every MIME type on that page be included in the new class?
Thanks!

Hi @michaeljdennis,
Just not the deprecated types. Thanks!
With Best Regards,
Elmer

Closing as I don't see the value added.


Fixes for kubeconfig secret namespace and missing kubeadm CR label

Towards giantswarm/roadmap#320
Fixes 2 problems found while testing on ginger and adds missing RBAC rules for events.

Tested on ginger.


Only include result of Query in operation graph if published to triggers

Result of a query cannot activate a trigger if the result is not published to TOPIC_TRIGGERS and OperationGrapher should understand and reflect that.

Resolve by bb374a9b3a2cf21fe31b045af207e31d3fd75c89.
A publishTo field is now added to Query nodes generated by OperationGrapher. Activation relationships can now be filtered based on publishTo.


Prompt for password if it isn't passed in

It might be helpful for people who are paranoid about their bash history to have the option of entering their password interactively.
Additionally, it could detect if you passed an empty string and prompt for it in that case as well.
A workaround at the moment is to prefix your invocation of the command with a space which will cause bash (and maybe other shells?) to not log it in your history.

Fixed in https://github.com/weskerfoot/DeleteFB/pull/16


Gh 1236 matched vertex

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@fef4a74). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             develop   #1239   +/-   ##
=========================================
  Coverage           ?   64.7%
  Complexity         ?    1460
=========================================
  Files              ?     656
  Lines              ?   20805
  Branches           ?    2608
=========================================
  Hits               ?   13462
  Misses             ?    6260
  Partials           ?    1083

Impacted Files
Coverage Δ
Complexity Δ

...k/gov/gchq/gaffer/data/element/IdentifierType.java
100% <100%> (ø)
0 <0> (?)

...er/operation/data/generator/EntityIdExtractor.java
85% <100%> (ø)
8 <0> (?)

...ain/java/uk/gov/gchq/gaffer/data/element/Edge.java
74.76% <100%> (ø)
0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fef4a74...19716b4. Read the comment docs.


error: address overflow

Hi again --
I wrote a few months ago with a build error that we resolved (https://github.com/chrismaltby/gb-studio/issues/404). Many more months of more work done, always keeping my scripts within limits.
Just did a clean install of GBStudio on a brand new MacBook Pro, copied over my files from my old decrepit MacBook, and -- voila -- I'm getting a new error on build, likely related to issue #404. The strange thing is that the game file builds & runs fine on my old computer, but won't build on the new one.
Installing fresh GBStudio included downloading & installing latest Xcode from apple developer site, not sure if the bug is related to new Xcode build from Apple.
Describe the bug
Crashes on build (see screenshot).
To Reproduce
Steps to reproduce the behavior:

Click "build"
See error

Expected behavior
Build & test game locally.

It is imperative to provide the version of gbstudio you installed, as part of the bug report template.
If this is 1.2.1, the develop branch has fixes and improvements to be in legacy 1.2.2, such as dynamic and larger rom sizes.
2.0 beta also has dynamic rom sizes, but still has a minor migration issue with timer or attached scripts.

Hi Richard
1.2.1 was installed today.
I checked for updates but looked like everything is up to date (though the 1.2.1 build was back in Jan). Can you point to updates? Is there a 1.2.2 like, or should I move on to 2.0 beta?
thx
nick

1.2 development builds https://github.com/chrismaltby/gb-studio#development-builds
2.0 beta development builds https://github.com/chrismaltby/gb-studio/tree/v2beta#beta-builds
You would have been using a 1.2 dev build if you were over 64 banks in your project (130??? that's over a 2mb cart!)
The updater will only update to official builds, no use for development or betas.
If you make a copy of your project folder, and try a v2beta build, you may notice a lot of improvements and features like fade to black, but also need to test for any errors, might be best to stick with a 1.2 dev build until we add more options to attached scripts for compatibility.

Awesome, the latest 1.2 dev build has fixed the problem. Thx!
Yes, the project file is clocking in at 200mb right now. The final game file is only 2mb when it's done building, but it's safe to say there's a lot of data / game world. We might be going for the biggest retro rpg, when it's all done it will hopefully take players months if not years to get through the game.
In the meantime, spinning off the first mini-game shortly. Focussed on just the combat system, the mini-game is helping to really dig in and polish this aspect of the game.
Fun times, thanks again for the feedback. Closing the bug.


Displaying HTML Widgets?

Hi. I've been reading through the docs and trying out various functions, but can't get an html widget to display. Is it possible? This is the code I'm running for reference on R 4.2.1 on Ubuntu 20.04:
library(tickle)
library(diffr)

# I have two random text files that I supply here
file1 = file.choose()
file2 = file.choose()
diff = diffr(file1, file2, before = basename(file1), after = basename(file2))

happiness <- reactive_dbl(40)

col1 =   tic_col(
tic_slider(happiness),
tic_label(textvariable = happiness),
canvas_text(diff)
)

row = tic_row(col1)

ui_spec <- tic_window(title = "Hello World", row)
win <- render_ui(ui_spec)

PS: In tic_label(textvariable = happiness) how would I round the label to two decimal places?

Rounding a slider variable takes a bit of chicanery

Put the tic_slider into a reactive variable
Call a command every time the slider changes to round this vlue

library(tickle)

happiness <- reactive_dbl(40)

slider_func <- function(...) {
  happiness(round(happiness(), 2))
}

col1 =   tic_col(
  tic_slider(happiness, command = slider_func),
  tic_label(textvariable = happiness)
)

row = tic_row(col1)

ui_spec <- tic_window(title = "Hello World", row)
win <- render_ui(ui_spec)

On the other matter: I don't think there is a modern/supported HTML widget for tcl/tk.
Happy to be proved wrong!

Thanks.
It seems like html for tcl/tk is implemented in Python's tkinter (https://stackoverflow.com/a/48909932), but I don't know the details.

Python tkinterhtml is a wrapper around tkhtml3 which appears dead.
Summary: I can't see HTML widget support being added to tickleanytime in the near future.


KAFKA-7075: Allow Topology#addGlobalStore to add a window store

InternalTopologyBuilder#addGlobalStore has no tests for stores other than KeyValueStore. This PR adds a new unit test to show that a StoreBuilder can be used in InternalTopologyBuilder#addGlobalStore. This required creating two new mocks, MockWindowStore and MockWindowStoreBuilder, modelled on MockKeyValueStore and MockKeyValueStoreBuilder, respectively.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

retest this please

retest this please

retest this please

retest this please

retest this please

@bbejeck Note, that when adding a global store, user also provides the corresponding processor. This method is at Processor API level and it's the users responsibility to implement the Processor correctly. At DSL level, the API is still limited to accept KeyValueStore only.
Adding an integration test is always a good idea of course :)

that when adding a global store, user also provides the corresponding processor.

@mjsax hhanks for the clarification.  As soon as I read your comment I realized that I knew that, but it slipped my mind at the moment.
Personal confusion aside, I agree with you that an integration test is still worthwhile.

@mjsax @bbejeck thank you for your comments. I will add an integration test asap.

Hi, @lmontrieux are you still working on this PR?

Hi @bbejeck ,
Sorry for the delay, life got in the way. I expect to give this PR some attention over the weekend.

Hi @lmontrieux no need to apologize! Just checking in and thanks again for contributing!

@lmontrieux Are you still interested in working on this?

Actually, looking at the latest trunk, I think the enforced types have already been resolved, but we still need this PR for adding the shouldAllowAddGlobalStoreWithNonKVStore test to cover this call path.
@lmontrieux could you rebase your PR and then only leave the test / mocks in place, and run them to see if they pass? If yes, we can go ahead and review / merge this PR still.

@guozhangwang sure, I'll do that

Thank you!

Wow, I did something wrong. Will fix it.

Some warnings are causing the build to fail, I'll have a look

@lmontrieux Any updates on this PR?

@mjsax now all tests are passing. I'll update the PR description to reflect that this only adds unit tests.

\cc @mjsax for a second review

The original ticket claims, that it's not possible to add a non-kv-store as global store? This PR adds test that proof the ticket wrong? Or was it fixed with a different PR?

Seems this was fixed via https://github.com/apache/kafka/pull/5779
Should we close the ticket as "contained by" and merge this as MINOR PR instead?

Should we close the ticket as "contained by" and merge this as MINOR PR instead?

SGTM.
@lmontrieux can you respond to @mjsax's comments?

Seems this was fixed via #5779
Should we close the ticket as "contained by" and merge this as MINOR PR instead?

Yes, makes sense to me.

@lmontrieux what's status of this PR?  Once you address the latest comments we can get this merged.  Thanks!

@lmontrieux -- just cycling back to this PR. Are you still interesting? Seems the PR would need a rebase and there a some open comments to address.

Closing this old PR due to inactivity.


Make all ObjC tests intermediate files into /tmpfs

To resolve ObjC test failures complaining "no space left on device".
Fixes #16156 .

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,976,654      Total (=)      1,976,654

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,775,727      Total (<)     10,775,730

 No significant differences in binary sizes

[microbenchmarks] No significant performance differences

Only affects Mac tests; failures unrelated.


SONOFF iFAN03 WiFi Ceiling Fan&Light Controller

Is possible to make SONOFF iFAN03 WiFi Ceiling Fan&Light Controller?
https://www.amazon.com/dp/B07TRTG8PS/ref=cm_sw_r_cp_api_i_XbAWDbMRXFWCD

You can make for us?

No, I do not do that

Where you get the codes from?

I dream them myself


Update links and endpoints to v2 of the API

Links and endpoints on the documentation home page should be updated to reflect the new API version 2. The links for 1.17 and 1.17.1 should also be added.

Latest build shortcut links:

* [1.17.1](https://api.pl3x.net/v2/purpur/1.17.1/latest/download) builds 1256+
* [1.17](https://api.pl3x.net/v2/purpur/1.17/latest/download) builds 1172-1255
* [1.16.5](https://api.pl3x.net/v2/purpur/1.16.5/latest/download) builds 957-1171
* [1.16.4](https://api.pl3x.net/v2/purpur/1.16.4/latest/download) builds 809-956
* [1.16.3](https://api.pl3x.net/v2/purpur/1.16.3/latest/download) builds 751-808
* [1.16.2](https://api.pl3x.net/v2/purpur/1.16.2/latest/download) builds 711-750
* [1.16.1](https://api.pl3x.net/v2/purpur/1.16.1/latest/download) builds 608-710
* [1.15.2](https://api.pl3x.net/v2/purpur/1.15.2/latest/download) builds 398-606
* [1.15.1](https://api.pl3x.net/v2/purpur/1.15.1/latest/download) builds 348-397
* [1.15](https://api.pl3x.net/v2/purpur/1.15/latest/download) builds 339-346
* [1.14.x](https://api.pl3x.net/v2/purpur/1.14.4/latest/download) builds 337 and below

Downloads API endpoints:

 * List versions of Minecraft with builds available:
 `https://api.pl3x.net/v2/purpur/`
 * List builds for a version of Minecraft:
 `https://api.pl3x.net/v2/purpur/<version>`
 * Download a specific build of a specific version:
 `https://api.pl3x.net/v2/purpur/<version>/<build>/download`
 * Download the latest build for a version of Minecraft:
 `https://api.pl3x.net/v2/purpur/<version>/latest/download`


Panic with forge coverage --ir-minimum

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
No response
What command(s) is the bug in?
forge coverage
Operating System
None
Describe the bug
coverage crashes while analyzing contracts, because it relies on incorrect source maps produced by --ir-minimum. Panic occurs while indexing the sourcefile loaded in memory
$ forge coverage --ir-minimum --contracts src/

[⠒] Compiling...
[⠘] Compiling 63 files with 0.8.20
[⠃] Solc 0.8.20 finished in 12.01s
Compiler run successful!
Analysing contracts...
The application panicked (crashed).
Message:  byte index 13549 is out of bounds of `// SPDX-License-Identifier: MIT
pragma solidity ^0.8.20;

// rest of contract`

Hi James,
Looks like this has since been fixed
$ forge init counter
$ cd counter/
$ forge coverage --ir-minimum

Now yields
Warning! "--ir-minimum" flag enables viaIR with minimum optimization, which can result in inaccurate source mappings.
Only use this flag as a workaround if you are experiencing "stack too deep" errors.
Note that "viaIR" is only available in Solidity 0.8.13 and above.
See more: https://github.com/foundry-rs/foundry/issues/3357
[⠊] Compiling...
[⠊] Compiling 27 files with Solc 0.8.26
[⠆] Solc 0.8.26 finished in 2.92s
Compiler run successful!
Analysing contracts...
Running tests...

Ran 2 tests for test/Counter.t.sol:CounterTest
[PASS] testFuzz_SetNumber(uint256) (runs: 256, μ: 34765, ~: 35076)
[PASS] test_Increment() (gas: 35175)
Suite result: ok. 2 passed; 0 failed; 0 skipped; finished in 75.63ms (65.82ms CPU time)

Ran 1 test suite in 89.87ms (75.63ms CPU time): 2 tests passed, 0 failed, 0 skipped (2 total tests)
| File                 | % Lines       | % Statements  | % Branches    | % Funcs       |
|----------------------|---------------|---------------|---------------|---------------|
| script/Counter.s.sol | 0.00% (0/3)   | 0.00% (0/3)   | 100.00% (0/0) | 0.00% (0/2)   |
| src/Counter.sol      | 100.00% (2/2) | 100.00% (2/2) | 100.00% (0/0) | 100.00% (2/2) |
| Total                | 40.00% (2/5)  | 40.00% (2/5)  | 100.00% (0/0) | 50.00% (2/4)  |

If you are still running into this please re-open the ticket
For now marking as resolved

Realizing this may still be an issue but a known edge case with --ir-minimum, support is being tracked as part of https://github.com/foundry-rs/foundry/issues/3527

Same issue as https://github.com/foundry-rs/foundry/issues/8957.