File extension for TableTools.BUTTONS.xls is csv instead of xls

I think this is a regression from TT 1. Shouldn't this be .xls?
https://github.com/DataTables/TableTools/blob/RELEASE_2_0_1/media/js/TableTools.js#L2063

Hello, Has this been rewritten? How can I fix? I still see this issue 4 years later.

No not yet. It is in progress though.

I am facing the same issue. Is the issue fixed. This is the only issue which is stopping me from using DataTable plugin as exporting data is one of the main functionalities in my application.

TableTools has been replaced by the Buttons extension now. I would suggest using that, it does create an XLSX file. Development on TableTools has been halted and will not be progressed further.


Support developing iOS extension targets

Are they any docs on building an iOS extension using Flutter?

All you need can be found here "https://flutter.io/developing-packages/".
For specific iOS Api documentation you can refer to apples docs https://developer.apple.com/documentation/

I'm talikng about this https://developer.apple.com/library/content/documentation/General/Conceptual/ExtensibilityPG/index.html :D Not plugins.

I am also interested in this. Using FlutterViewController (and adding the Frameworks) in an extension leads to a crash.

@long1eu hi! Try to remove all the "Other Linker Flags" within the Target (your Extension) in "Build Settings" (see screen). This caused the linker problems in my project. Removing them, solved it! You don't have to touch the Podfile at all.

@long1eu and @ugoArangino hi! Try to remove all the "Other Linker Flags" within the Target (your Extension) in "Build Settings" (see screen). This caused the linker problems in my project. Removing them, solved it! You don't have to touch the Podfile at all.

Hi Andreas!
Did you actually manage to run Flutter in an App Extension? Or it is just a Flutter app + native App Extension?

I'm actively pursuing this in a project I'm currently working on. By using the Add-to-App method I've managed to start a Flutter view from within my extension.
However, the view is simply black, and connecting to the debugger from the observatory, I'm greeted by the following message:
Paused until embedder makes the isolate runnable.

I think I'm missing some important step that tells the Flutter isolate to start running, that is probably coming from the FlutterAppDelegate. (since this is an app extension, I don't have an app delegate, only a ViewController)
Will keep updating here as I try to move further with this...

Will keep updating here as I try to move further with this...

@LinusU Any updates on this?

I'm actively pursuing this in a project I'm currently working on. By using the Add-to-App method I've managed to start a Flutter view from within my extension.
However, the view is simply black, and connecting to the debugger from the observatory, I'm greeted by the following message:
Paused until embedder makes the isolate runnable.

I think I'm missing some important step that tells the Flutter isolate to start running, that is probably coming from the FlutterAppDelegate. (since this is an app extension, I don't have an app delegate, only a ViewController)
Will keep updating here as I try to move further with this...
my code:
import AuthenticationServices
import MobileCoreServices
import UIKit

import Flutter
import FlutterPluginRegistrant

@objc(CredentialProviderViewController)

class CredentialProviderViewController: ASCredentialProviderViewController {
    var flutterEngine: FlutterEngine!
    var flutterViewController: FlutterViewController!

    override func prepareCredentialList(for serviceIdentifiers: [ASCredentialServiceIdentifier]) {
        flutterEngine = FlutterEngine(name: "io.flutter", project: nil)
        flutterEngine.run(withEntrypoint: nil)

        GeneratedPluginRegistrant.register(with: self.flutterEngine)

        flutterViewController = FlutterViewController(engine: flutterEngine, nibName: nil, bundle: nil)!
        view.addSubview(flutterViewController.view)
    }
}

@LinusU Any updates on this?

Unfortunately not, at the moment our app extension is written using only native code and views 😞
Would love to have support for Flutter here though!

Even if add-to-app for app extensions worked and the extension lifecycle was hooked up, I believe it would be rejected from the App Store:
ld: warning: linking against a dylib which is not safe for use in application extensions: test_notification_extensions/flutterapp/.ios/Flutter/App.framework/App
ld: warning: linking against a dylib which is not safe for use in application extensions: test_notification_extensions/flutterapp/.ios/Flutter/engine/Flutter.framework/Flutter

https://clang.llvm.org/docs/ClangCommandLineReference.html#cmdoption-clang-fapplication-extension

We managed to run dart code from an extension by starting FlutterEngine and using the platform channel (binaryMessenger) to communicate. (We only wanted to reuse business logic in dart.) However, that only worked for a non-flutter app. Trying the same for a flutter app, CocoaPods complained about pods with the same name: Flutter.framework and App.framework. Using only a single Flutter.framework is possible, but the "App.framework" name is hardcoded in several places: xcode_backend.sh, pod helper.rb, .podspec, AppFrameworkInfo.plist (and maybe others we missed). Also the CFBundleIdentifier of both App.framework is hardcoded, while it must be unique per bundle.

We managed to run dart code from an extension by starting FlutterEngine and using the platform channel (binaryMessenger) to communicate. (We only wanted to reuse business logic in dart.) However, that only worked for a non-flutter app. Trying the same for a flutter app, CocoaPods complained about pods with the same name: Flutter.framework and App.framework. Using only a single Flutter.framework is possible, but the "App.framework" name is hardcoded in several places: xcode_backend.sh, pod helper.rb, .podspec, AppFrameworkInfo.plist (and maybe others we missed). Also the CFBundleIdentifier of both App.framework is hardcoded, while it must be unique per bundle.

Having two copies of Flutter and the App (compiled dart code) would make the app huge.  Probably the Flutter app and extension would need to import that once (two Podfile targets using the same pod) with different entry points into the App.framework.  I'm just thinking out loud--the Flutter tooling doesn't support this use-case at the moment.

Adding @matthew-carroll @xster for their thoughts.

Seems like an interesting use-case, but I'll defer to @jmagman on the technical feasibility as well as timeline.

https://github.com/flutter/flutter/issues/16092#issuecomment-475237976
@andreasunterhuber this is the solution to my problem that I've spent few hours on! Thank you!
Flutter team, I beg you to add this issue to some flutter.dev website on App Extensions. Adding firebase_* pub packages prevented my app with App Extension to compile. Removing the firebase_* flags with their corresponding -framework pair successfully resolved my problem.

@Albert221 I don't think you or @andreasunterhuber are talking about using Flutter in an extension, as @alcsan pointed out (and I missed when I last looked at this issue).

Did you actually manage to run Flutter in an App Extension? Or it is just a Flutter app + native App Extension?

And that's not really related to this feature request to use Flutter in an app extension.  I'd actually like to take a look at what you were seeing.  We want non-Flutter app extensions to be able to be added to Flutter apps without any project files workarounds like the one you figured out.
Would you mind filing a new issue with your original flutter build or run command with the --verbose flag, completely fill out the issue template, and @ me in it?  I'm wondering if part of your problem wasn't already fixed with https://github.com/flutter/flutter/pull/78592 in 2.0.4.

you can craete a duplicate of app. named "buildFlutterPKG", and then edit this app scheme , scheme -> build -> targets ->add (select the build flutterpkg sheme), and set the buildFlutterPkg to the first line. and then disable the "Parallelize build"
build the app
it's done

@jmagman Any updates on this issue? Is there a chance that it will be fixed soon if it was added to "iOS Developer Experience"?

No updates at this time.

you can create a duplicate of app scheme. named "buildFlutterPKG", remove all extension config of buildFlutterPKG and then edit this app scheme , scheme -> build -> targets ->add (select the build flutterpkg sheme), and set the buildFlutterPkg to the first line. and then disable the "Parallelize build" build the app it's done

Is it a way to use Flutter in an App Extension?

We developed Audanika, a serious music app in Flutter. Many of our customers are asking for AUV3 support. Is there someone here from Google, I could talk about?
https://medium.com/@audanika/help-us-to-implement-auv3-support-for-audanika-ea325870fa6a

@gatzsche Maybe I don't understand your use case, but why do you need to use Flutter in your AUv3 extension?  Open ios/Runner.xcworkspace and add your extension target as you would in a normal Xcode project.  If you need to present UI or subclass AUAudioUnit in your Flutter app, that could be a good use case for a Flutter plugin.

If you need to present UI or subclass AUAudioUnit in your Flutter app, that could be a good use case for a Flutter plugin.

That is exactly what I want to do. Based on this thread I had doubt that showing a Flutter View Controller in an extension might work. But I will try out.
@jmagman Is there some documentation? If not, how could I contribute to create some?

Based on this thread I had doubt that showing a Flutter View Controller in an extension might work.

I see, then you do what to use Flutter in your extension.  By "you need to present UI or subclass AUAudioUnit in your Flutter app, that could be a good use case for a Flutter plugin" I meant in YOUR app that already embeds Flutter and your dart code, not in the extension used by other apps.
You would need to link against and embed the Flutter frameworks in the extension, as well as the framework that contains your compiled Dart code.  The tooling doesn't support this and there's no docs, but it can be done manually.  As I said, I wrote an example of how to do this with App Clip extensions, though that exact use case didn't work because it hit the 10MB upload limit: https://docs.flutter.dev/development/platform-integration/ios-app-clip.
Your best bet is probably to break out of Flutter for this use case and implement your extension entirely in Swift/Obj-C in Xcode.

@jmagman Hi Jenn, thanks for your answer. Currently, it looks that Audio Unit Extensions might work with Flutter. The flutter code is executed and also the widget build functions are executed. The only thing: The FlutterViewController does not show the flutter content.
Would you mind checking out this example:
https://github.com/gatzsche/flutter-audio-unit-extension-experiments
At the end, you should see the flutter default app in the extension. But it is not shown. Also, no error is output.
Should I create a separate issue for that?

You should create a separate issue.  Or maybe someone can help on StackOverflow.

I've heard that there's memory limit (15-16mb), which is less than the memory required to even preload flutter engine (22mb)

@long1eu and @ugoArangino hi! Try to remove all the "Other Linker Flags" within the Target (your Extension) in "Build Settings" (see screen). This caused the linker problems in my project. Removing them, solved it! You don't have to touch the Podfile at all.

Isn't this breaking something else? I am working with flavors. in my main app & extension.

I can run DebugDev on my device without any problems.
I can't run DebugDev on my simulator
I can't run DebugAlpha, DebugBeta, DebugProd on my device/simulator

When I remove the Other linker flags it does work. But why are they added if they are not used? Isn't this breaking something else?

In case anyone is still interested, I was able to get a simple Flutter AUv3 running with some hacks to Flutter 🎉
I compiled Flutter from source with the -fappliation-extension clang flag to detect any code which can't be used in an app extension, and then removed all references to [UIApplication sharedApplication], which is forbidden in app extensions. I'm not sure if this was actually causing it to fail loading or not but would presumably fail the App Store checks – I still do get a warning about Linking against a dylib which is not safe for use in application extensions but it sounds like this can be shown even when the usage is actually safe. I'm hoping to submit a simple AUv3 to the App Store to see if it passes the real checks.
I was then was able to see an error in the console Failed to find assets path for "Frameworks/App.framework/flutter_assets" when loading the AUv3 – I'm not sure if this was only visible because my local build of Flutter was a debug build, or if the changes to remove sharedApplication references meant it could get further in loading. It turns out that if you are in an app extension, [NSBundle mainBundle] points to the .appex inside the bundle rather than the top level bundle, and so Flutter was not able to locate the assets here.
I added a hack into that bit of code to use the parent directory if we are in an app extension (from StackOverflow) and it seems to work! 🎉

I'll continue working on this and document how I get on, and will see if I can create a PR for Flutter with the changes that I had to make – if they're not suitable for merging as they are, they are fairly simple and minimal, so it should be possible for anyone interested to compile Flutter themselves locally with the changes applied.

In case anyone is still interested, I was able to get a simple Flutter AUv3 running with some hacks to Flutter 🎉
I compiled Flutter from source with the -fapplication-extension clang flag added to the gn config, to detect any code which can't be used in an app extension, and then removed all references to [UIApplication sharedApplication], which is forbidden in app extensions. I'm not sure if this was actually causing it to fail loading or not, but would presumably cause an app to fail the App Store API usage checks.
I still do get a warning about Linking against a dylib which is not safe for use in application extensions in the parent app, but it sounds like this can be shown even when the usage is actually safe. I'm hoping to submit a simple AUv3 to the App Store to see if it passes the real checks.
I was then was able to see a new error in the console, Failed to find assets path for "Frameworks/App.framework/flutter_assets", when loading the AUv3 – I'm not sure if this was only visible because my local build of Flutter was a debug build, or if the changes to remove sharedApplication references meant it could get further in loading. It turns out that if you are in an app extension, [NSBundle mainBundle] points to the .appex inside the bundle rather than the top level bundle, and so Flutter was not able to locate the assets here.
I added a hack into that bit of code to use the parent directory if we are in an app extension (from StackOverflow) and it seems to work! 🎉

I'll continue working on this and document how I get on, and will see if I can create a PR for Flutter with the changes that I had to make – if they're not suitable for merging as they are, they are fairly simple and minimal, so it should be possible for anyone interested to compile Flutter themselves locally with the changes applied.

Great discovery! Excited for more updates to this 👏

That is so good news. Cannot express how happy I'm to hear this. 🤩🤩🤩🤩🤩🤩

Hey @gatzsche, I was going to reach out to you about this as your repo for this was helpful in figuring out how to set up an AUv3 inside the runner app, so thanks for that :)
My plan here is to create an integration between JUCE and Flutter, so you can build a JUCE plugin with a Flutter UI, which I think would be a nice combo for a lot of of music software in terms of Flutter’s ease of building nice custom UIs etc. I’ve done a lot of work with JUCE and React Native and web UIs, so have some ideas how to make this work well. The core of the solution will be reusable without JUCE though.
The main hurdle I can see to getting support for this merged into Flutter is that my understanding is the Flutter.framework would need to contain no references to sharedApplication at all to pass the App Store checks - just not calling it at runtime isn’t enough - so this would mean a separate distribution of the framework for extensions. Not sure if there’s a precedent for this already? Maybe the Flutter team will have some ideas. In any case, compiling it locally is not too painful for now!

Hey, @tomduncalf thanks for that details.
Do I understand right, that Flutter.framework must not contain a reference to sharedApplication, but such a reference is needed to make an extension work?
Can you add some references so I can understand the problem better?

@gatzsche in order for the app extension to be accepted on to the App Store, my understanding is there can be no references to sharedApplication in the linked frameworks. Flutter uses this in various places to hook into various lifecycle events, device rotation, font size etc., but in an app extension context most/all of this is irrelevant anyway and it works fine with it commented out/otherwise removed.
However, I don't think that this is the cause of a Flutter app extension failing to start up, it's just something that needs to happen in order for an app built with it to be accepted – the cause of the app not starting is that the assets path is incorrect when running as an app extension, because [NSBundle mainBundle] returns the path of the .appex inside the bundle, rather than the top level bundle, so when Flutter constructs the assets path from this, it's incorrect. You can see the fixes I did here: https://github.com/tomduncalf/engine/pull/1/files
I will write this up in more detail when I find time, but it might not be for a few weeks so if you want to play around with it for now, you can compile Flutter from source using my branch. It works great, I've got a basic AUv3 plugin working with a Flutter UI and a JUCE backend, communcating between the two using channels!

@gatzsche in order for the app extension to be accepted on to the App Store, my understanding is there can be no references to sharedApplication in the linked frameworks. Flutter uses this in various places to hook into various lifecycle events, device rotation, font size etc., but in an app extension context most/all of this is irrelevant anyway and it works fine with it commented out/otherwise removed.
However, I don't think that this is the cause of a Flutter app extension failing to start up, it's just something that needs to happen in order for an app built with it to be accepted – the cause of the app not starting is that the assets path is incorrect when running as an app extension. This is because [NSBundle mainBundle] returns the path of the .appex inside the bundle, rather than the top level bundle, so when Flutter constructs the assets path from this, it's incorrect. You can see the fixes I did here: https://github.com/tomduncalf/engine/pull/1/files
I will write this up in more detail when I find time, but it might not be for a few weeks so if you want to play around with it for now, you can compile Flutter engine from source using my branch. It works great, I've got a basic AUv3 plugin working with a Flutter UI and a JUCE backend, communcating between the two using channels!

greet work....

@tomduncalf Do you happen to have some step-by-step documentation on how to implement an iOS extension in Flutter? I would really appreciate it.

hey @tomduncalf - thanks for the info so far. just wondering if you were able to ever write this up in the end? thanks!

@sophanox @kaciula
In https://github.com/gatzsche/flutter-audio-unit-extension-experiments you find steps to implement an app extension. In that code, the FlutterViewController did not show up. With https://github.com/tomduncalf/engine/pull/1/files @tomduncalf  shows how to fix that.
I did not yet apply @tomduncalf's solution to my code. But both together should give a running app extension.

Hi! Im working on some new docs and including the steps @tomduncalf mentioned. Tom - I was wondering if you can create a PR on the Flutter engine (we'll close it, but this will give us a stable link to use in the docs)?
Feel free to add comments to the docs PR if there are pieces missing that you would like included:
https://github.com/flutter/website/pull/8265

Hey all, I'm afraid I've not had time to revisit this since my original post, the project kind of fizzled out!
@leighajarett I'll see if I can find my changes and send them over!

@leighajarett you can see the changes I made to get flutter to compile here:
https://github.com/tomduncalf/engine/commit/581a4170717907c8ee882872190c4c2e3202c35a (this would need doing properly, I just commented out a load of stuff)
and
https://github.com/tomduncalf/engine/commit/d31c18b5ac0ed0441e7793347c5d87927dbc1dd0
Let me know if I can share anything else useful!

The Flutter Engine can be build to support extension starting from 3.16.0. There is also a Flutter.xcframework that supports extension under <path_to_flutter>/bin/cache/artifacts/engine/ios/extension_safe/Flutter.xcframework.
See this doc for an example on how to use such framework to build share extension with Flutter.
The guide document on flutter website will be available in the future after https://github.com/flutter/website/pull/9698 lands.


Stuck when decompiling class CustomWorldSettingsFinal

At the decompile net/minecraft/server/v1_8_R3/CustomWorldSettingsFinal task and it stuck 1,5 hour + doesn't continue, but the class file CustomWorldSettingsFinal.class is just 4KB(i extract from jar file), please fix :(
Image:

This is not the proper repository.
Please go to https://github.com/mstrobel/procyon
This an old copy that i still need.


Shared tensor stride is not set properly

Shared tensor stride is not reset but uses the original tensor stride which sometimes results in segmentation fault.

:octocat: cibot: Thank you for posting issue #816. The person in charge will reply soon.


TAG V3.1 - esp_wifi_scan_start() in STA mode (IDFGH-619)

Environment

Development Kit:      self made
Module or chip used:  ESP32-WROOM-32
IDF version:  v3.1 (tag)
Build System:         CMake
Compiler version: xtensa-esp32-elf-gcc (crosstool-NG crosstool-ng-1.22.0-73-ge28a011) 5.2.0
Operating System:     Linux
Power Supply:         external 5V

Problem Description
When we call esp_wifi_scan_start() in STA mode (connected to an acces point) we get this error:
W (167973) wifi: Now is connecting, user scan invalid now!
The result of esp_wifi_scan_start() is ESP_ERR_WIFI_TIMEOUT
The WiFi mode is: WIFI_MODE_STA
Expected Behaviour
The wifi scan must be started
Actual Behaviour
The wifi scan is not started and it returns the errors on the description
Questions
Is it possible to use this functions in STA mode (connected to an AP) ?

Hi @caipiblack, ESP32 supports two kinds of scan: the connecting scan which is triggered by esp_wifi_connect() and the user scan which is triggered by esp_wifi_scan_start(). The connecting scan has higher priority than the user scan, in other words, the esp_wifi_scan_start() will fail if the station now is connecting to the AP and following log will be displayed:

W (167973) wifi: Now is connecting, user scan invalid now!

So it's expected behavior.
The most simple way to handle this cause is to delay sometime and call esp_wifi_scan_start() again. However this method doesn't make sense in following scenario:

esp_wifi_connect() is called and ESP32 station is connecting to an non-exist AP.
WiFi disconnected event is raised because the AP is not found, the WiFi event handler simply calls esp_wifi_connect() to reconnect the non-exist AP.
step 1/2 is repeated again and again.
esp_wifi_scan_start() is called.

If this is your case, you need to call esp_wifi_disconnect() to stop WiFi connection before esp_wifi_scan_start() is called, otherwise, esp_wifi_scan_start() will always fails.
For the return value ESP_ERR_WIFI_TIMEOUT, I think it's not accurate, we need to modify it, maybe it's better to return ESP_ERR_WIFI_FAIL etc.
You can refer to: wifi_doc for more info about scan.
BTW, are you use the block scan: esp_wifi_scan_start(config, true)?

@caipiblack Hi, would you help share if any updates for the issue? @liuzfesp how is the modification of return ESP_ERR_WIFI_FAIL etc? Thanks.

@caipiblack Thanks for reporting the issue. Would you please help share if any updates for the issue? Has your issue been fixed? Thanks.

Thanks for reporting, the fix is available at https://github.com/espressif/esp-idf/commit/c05a39de0280f896d7fcd7a8852d7e760e850393, feel free to reopen if the issue still happens. Thanks.


testFFT times out

On the macosx Pharo 9.0 image testFFT times out:
[44193](https://github.com/PolyMathOrg/PolyMath/runs/6073183636?check_suite_focus=true#step:4:44193)
PMFFTTest
[44194](https://github.com/PolyMathOrg/PolyMath/runs/6073183636?check_suite_focus=true#step:4:44194)
 ✗ #testFFT (10382ms)
...
[44197](https://github.com/PolyMathOrg/PolyMath/runs/6073183636?check_suite_focus=true#step:4:44197)
  Executed 897 Tests with 0 Failures and 1 Errors in 49.27s.

It is worth keeping an eye on the main branch tests on a PR being merged.


perf: use plain iterator for payload unmasking

This tweaks unmask_easy logic in order to directly use an enumerating iterator. It allows the compiler to generate more optimal machine code by performing internal iteration directly on the input slice.

On my Linux laptop with AMD Ryzen 7, this shows a small but reliable micro-benchmark improvement:
Finished release [optimized] target(s) in 16.03s
Running benches/unmask.rs (target/release/deps/unmask-c8256fdf566f5dbf)

unmask2/unmask 64 << 20 time:   [2.3568 ms 2.3596 ms 2.3641 ms]
                        thrpt:  [26.437 GiB/s 26.488 GiB/s 26.519 GiB/s]
                 change:
                        time:   [-8.4860% -7.2746% -6.0839%] (p = 0.00 < 0.05)
                        thrpt:  [+6.4780% +7.8453% +9.2729%]
                        Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
  1 (1.00%) high mild
  5 (5.00%) high severe


fix climate zone calculation

Currently, instead of determining the climate zone of the user-provided lat/long, we determine the closest representative city and use its climate zone. This can lead to an incorrect zone being used. To fix this, we would want to do something similar to how we determine the AVERT region and would need new shape files that represent the zones not just the cities.

Was this addressed in the Cambium update here?  Can we close?

tagging @adfarth

tagging @adfarth

Woops sorry for the slow reply here! I do not believe this was addressed in the Cambium updates. I believe @hdunham is referring to the climate zone used for the CRB and corresponding load profiles (correct?)

lieve @hdunham is referring to the climate zone used for the CRB and corresponding load profiles (correct?)

Yeah my comment was about climate zones not emissions regions, so probably wouldn't have been addressed in the cambium updates.


Plan for yearly website review / maintenance

In brief, this might include:

Confirm that database backups are working correctly (actually test a backup)
Check the working version of all major components for security issues or end-of-life status

MySQL (all packages used, incl. multi-byte string handling)
PHP
Apache
PHPMyAdmin (if used)

Upgrade these as needed, check for compatibility issues and new bugs; fix as needed.

Depending on how the initial steps go, this might be pretty quick (less than a day) or more of a slog, esp. if bug fixes are needed. Hopefully a week of work at most, if the site needs major surgery. The most likely "worst case scenario" would be major security problems with PHP, forcing an upgrade to it and other components, and requiring related code changes in the FCDB site.

I would strongly recommend that the configuration and installation is automated and rather fully specified. For example, for supersmart we are using puppet to manage all dependencies (including downloading databases - as per #14), here is the puppet manifest we use: https://github.com/naturalis/supersmart/blob/master/conf/manifests/default.pp - it is run by travis/CI continuously. This makes replication much easier than all the textual install instructions, which will go out of sync.
(Also, it would be good to consider using a virtualization or container system, such as vagrant or docker, to package everything up.)


Add experienceable to ApplicationExperience

Context
This is part of allowing the user to edit its work experiences after submitting an application
Changes proposed in this pull request
Migration to add polymorphic column to ApplicationExperience
Things to check

[ ] If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
[ ] This code does not rely on migrations in the same Pull Request
[ ] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[x] If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
[ ] API release notes have been updated if necessary
[ ] If it adds a significant user-facing change, is it documented in the CHANGELOG?
[ ] Required environment variables have been updated added to the Azure KeyVault
[x] Inform data insights team due to database changes
[x] Make sure all information from the Trello card is in here
[x] Rebased main
[x] Cleaned commit history
[x] Tested by running locally
[x] Add PR link to Trello card

 Edit work experiences - Change db structure to accommodate work experience edits


Add a pre-release announcement blog post

This is mainly an ask for the readers of the blog to try out these
pre-releases.

Not sure why it's failing, it's not installing Lektor for some reason.

Add a config file may solve the build error (#84).

@pgjones try rebasing with @greyli's netlify config merged in now.


Remove plus_one_deps_mode

Description
We remove plus_one_deps_mode from the toolchain, as it has been superseded by dependency_checker_mode.
Motivation
We remove a deprecated construct since a sufficiently long period of time has passed.

@ittaiz any further issues?

Very sorry, completely forgot about this PR.
Corona times got me working in a few other additional jobs as a teacher, cook and other capacities for my kids :)


add count to proper set busy traitlets

This is the more direct cause of https://github.com/aiidalab/aiidalab-home/issues/100, rather than https://github.com/aiidalab/aiidalab/pull/349.
In the package, there is already a context manager _show_busy provide to hold the display before the operations are running. However, this context manager only set the self.busy to a bool, which will be overridden unexpectedly if the _show_busy is embedded in itself. This happened for install_app, updata_app and uninstall_app, they are supposed to use _show_busy to prevent information to be displayed, but inside these function also call refresh which have another _show_busy. I add a counter to properly set the busy traitlets. It is False (which means not busy) when it counts down to zero.

@unkcpz Thanks, this is a great catch!
The code looks okay, but I think we need a Lock to guard access to the self._busy_count to ensure it is accessed atomically in case there are more threads.
https://stackoverflow.com/a/40072999/3682277

The thread lock was added and the test was all good. You can easily test it by comparing branches with installing QeApp version 22.08.0 without a needed dependency installed e.g by uninstall the filelock.


Automatically trace outgoing requests for traced request

Hi,
If request to serviceA is being traced, I would expect the request from serviceA to serviceB should be also tracked without any other configuration.
when I tried and also read both docs and codes, there should be named httpClient to configure AddOutgoingGoogleTraceHandler docs
Was it done on purpose or is there something I missed?
Should we configure all httpClients one by one or do you have any other solution to work service wide and not need httpClient configurations?
I asked this because we have 4 project and each project has 40 services. :)
I thought to write a httpClient wrapper to send all HTTP requests on it. So I can detect that the request is traced add traceContext to header and move on. ref : https://github.com/googleapis/google-cloud-dotnet/issues/9856#issuecomment-1425617476

Hi Amanda,
You understand right, sory for my writing skill :)
I understand your point. Let me explain without projects :) If I fail then ill create minimal projects.
app1 sends req1 -> serviceA sends req2 -> serviceB
app1 has services.AddGoogleDiagnosticsForAspNetCore() on startup.cs
serviceA has services.AddGoogleDiagnosticsForAspNetCore() on startupc.s
serviceB has  services.AddGoogleDiagnosticsForAspNetCore() on startup.cs
When I click a button on app1 and send to req1 to ServiceA, trace list only shows req1 (app1 -> serviceA). Waterfall graph not shows chained request like req2.
So all project have Google.Cloud.Diagnostics.* and configured with "AddGoogleDiagnosticsForAspNetCore".
If you tell me "req2 must be listed on waterfall graph without any other configuration", means that I will create example project :)
OR
If I add a line to serviceA startup services.AddHttpClient("myHttpClient").AddOutgoingGoogleTraceHandler();
and use "myHttpClient" to send request to ServiceB, waterfall lists req2 too. This is what I wanted to see.
The question is here "should I only use myHttpClient to send request to ServiceB to see req2 on waterfall graph?"
This means; we must always configure named httpClient with AddOutgoingGoogleTraceHandler and use this to send requests at each service.

If I add a line to serviceA startup services.AddHttpClient("myHttpClient").AddOutgoingGoogleTraceHandler();
and use "myHttpClient" to send request to ServiceB, waterfall lists req2 too. This is what I wanted to see.
The question is here "should I only use myHttpClient to send request to ServiceB to see req2 on waterfall graph?"
This means; we must always configure named httpClient with AddOutgoingGoogleTraceHandler and use this to send requests at each service.

Yes, if you want your trace to propagate (so that all requests on the chain are included on the same trace and shown on the waterfall graph) you need to confgured the each relevant HttpClient with AddOutgoingGoogleTraceHandler.  What happens when you don't do that is that the trace from app1 is not propagated to serviceA, so when the request reaches serviceA a new trace is created, which is also not propagated to serviceB which itself creates a new trace. You can find this 3 traces if you use HttpClients that have not been configured with AddOutgoingGoogleTraceHandler.
Note that Google.Cloud.Diagnostics.* does not require you to use named HTTP clients. The example shows named HTTP clients for clarity, but from Google.Cloud.Diagnostics.* side of things, you can just use the basic HTTP client for all your requests.

Ok, I understand the way you go and clear for me.
Last question for basic HTTP client.
I want to apply AddOutgoingGoogleTraceHandler to all httpClient in serviceA. This method needs IHttpClientBuilder.
AddHttpClient() returns IServiceCollection -> ref : link
AddHttpClient("") returns IHttpClientBuilder  -> ref: link
Do you have a suggestion to apply this to all httpClients within the service?
Docs: link

You can configure the default client by adding and configuring a named client with the default name (see the Remarks section).
That means that your configuration code looks like:
services.AddHttpClient(Options.DefaultName).AddOutgoingGoogleTraceHandler();

but the code where you use the HTTP client doesn't need to request any specifically named clients.

ty, we will go on this way


Error when loading M4 training data

When trying to load the M4 training data, it generates the following error:
raining_values = np.array(
ValueError: setting an array element with a sequence. The requested array has an inhomoge
neous shape after 1 dimensions. The detected shape was (4227,) + inhomogeneous part.
Traceback (most recent call last):
  File "/data5/aamayuelasfernandez/Time-LLM/run_m4.py", line 133, in <module>
    train_data, train_loader = data_provider(args, 'train')
  File "/data5/aamayuelasfernandez/Time-LLM/data_provider/data_factory.py", line 46, in d
ata_provider
    data_set = Data(
  File "/data5/aamayuelasfernandez/Time-LLM/data_provider/data_loader.py", line 349, in _
_init__
    self.__read_data__()
  File "/data5/aamayuelasfernandez/Time-LLM/data_provider/data_loader.py", line 357, in _
_read_data__

I loaded the data separately and it gives the same error:
Cell In[3], [line 4](vscode-notebook-cell:?execution_count=3&line=4)
      [1](vscode-notebook-cell:?execution_count=3&line=1) import numpy as np
      [2](vscode-notebook-cell:?execution_count=3&line=2) seasonal_patterns = 'Hourly'
----> [4](vscode-notebook-cell:?execution_count=3&line=4) training_values = np.array(
      [5](vscode-notebook-cell:?execution_count=3&line=5)             [v[~np.isnan(v)] for v in
      [6](vscode-notebook-cell:?execution_count=3&line=6)              dataset.values[dataset.groups == seasonal_patterns]])  # split different frequencies

ValueError: setting an array element with a sequence. The requested array has an inhomogeneous shape after 1 dimensions. The detected shape was (414,) + inhomogeneous part.

I have debugged it a little and the files provided for M4 seem to have mixed lengths for a specific group/seasonal_pattern and therefore it cannot create the array.
Can you try to run it and M4 script and see if you run into the same issue?

I keep getting the very same error when I try to run the M4 script:
And the
train_data, train_loader = data_provider(args, 'train')
  File "/data5/aamayuelasfernandez/Time-LLM/data_provider/data_factory.py", line 34, in data_provider
    data_set = Data(
  File "/data5/aamayuelasfernandez/Time-LLM/data_provider/data_loader.py", line 335, in __init__
    self.__read_data__()
  File "/data5/aamayuelasfernandez/Time-LLM/data_provider/data_loader.py", line 343, in __read_data__
    training_values = np.array(
ValueError: setting an array element with a sequence. The requested array has an inhomogeneous shape after 1 dimensions. The detected shape was (48000,) + inhomogeneous part.
[2024-03-19 11:34:44,270] torch.distributed.elastic.multiprocessing.api: [ERROR] failed (exitcode: 1) local_rank: 0 (pid: 3176791) of binary: /data5/aamayuelasfernandez/miniconda3/envs/tst/bin/python

Traceback (most recent call last):
  File "/data5/aamayuelasfernandez/miniconda3/envs/tst/bin/accelerate", line 8, in <module>
    sys.exit(main())
  File "/data5/aamayuelasfernandez/miniconda3/envs/tst/lib/python3.10/site-packages/accelerate/commands/accelerate_cli.py", line 47, in main
    args.func(args)
  File "/data5/aamayuelasfernandez/miniconda3/envs/tst/lib/python3.10/site-packages/accelerate/commands/launch.py", line 1014, in launch_command
    multi_gpu_launcher(args)
  File "/data5/aamayuelasfernandez/miniconda3/envs/tst/lib/python3.10/site-packages/accelerate/commands/launch.py", line 672, in multi_gpu_launcher
    distrib_run.run(args)
  File "/data5/aamayuelasfernandez/miniconda3/envs/tst/lib/python3.10/site-packages/torch/distributed/run.py", line 803, in run
    elastic_launch(
  File "/data5/aamayuelasfernandez/miniconda3/envs/tst/lib/python3.10/site-packages/torch/distributed/launcher/api.py", line 135, in __call__
    return launch_agent(self._config, self._entrypoint, list(args))
  File "/data5/aamayuelasfernandez/miniconda3/envs/tst/lib/python3.10/site-packages/torch/distributed/launcher/api.py", line 268, in launch_agent
    raise ChildFailedError(
torch.distributed.elastic.multiprocessing.errors.ChildFailedError:

And the error seem to be when loading the training data from M4:
ValueError: setting an array element with a sequence. The requested array has an inhomogeneous shape after 1 dimensions. The detected shape was (48000,) + inhomogeneous part.
I have checked and the error seem to be coming from the training data and not the valid/test data.

I keep getting the very same error when I try to run the M4 script:
train_data, train_loader = data_provider(args, 'train')
  File "/data5/aamayuelasfernandez/Time-LLM/data_provider/data_factory.py", line 34, in data_provider
    data_set = Data(
  File "/data5/aamayuelasfernandez/Time-LLM/data_provider/data_loader.py", line 335, in __init__
    self.__read_data__()
  File "/data5/aamayuelasfernandez/Time-LLM/data_provider/data_loader.py", line 343, in __read_data__
    training_values = np.array(
ValueError: setting an array element with a sequence. The requested array has an inhomogeneous shape after 1 dimensions. The detected shape was (48000,) + inhomogeneous part.
[2024-03-19 11:34:44,270] torch.distributed.elastic.multiprocessing.api: [ERROR] failed (exitcode: 1) local_rank: 0 (pid: 3176791) of binary: /data5/aamayuelasfernandez/miniconda3/envs/tst/bin/python

Traceback (most recent call last):
  File "/data5/aamayuelasfernandez/miniconda3/envs/tst/bin/accelerate", line 8, in <module>
    sys.exit(main())
  File "/data5/aamayuelasfernandez/miniconda3/envs/tst/lib/python3.10/site-packages/accelerate/commands/accelerate_cli.py", line 47, in main
    args.func(args)
  File "/data5/aamayuelasfernandez/miniconda3/envs/tst/lib/python3.10/site-packages/accelerate/commands/launch.py", line 1014, in launch_command
    multi_gpu_launcher(args)
  File "/data5/aamayuelasfernandez/miniconda3/envs/tst/lib/python3.10/site-packages/accelerate/commands/launch.py", line 672, in multi_gpu_launcher
    distrib_run.run(args)
  File "/data5/aamayuelasfernandez/miniconda3/envs/tst/lib/python3.10/site-packages/torch/distributed/run.py", line 803, in run
    elastic_launch(
  File "/data5/aamayuelasfernandez/miniconda3/envs/tst/lib/python3.10/site-packages/torch/distributed/launcher/api.py", line 135, in __call__
    return launch_agent(self._config, self._entrypoint, list(args))
  File "/data5/aamayuelasfernandez/miniconda3/envs/tst/lib/python3.10/site-packages/torch/distributed/launcher/api.py", line 268, in launch_agent
    raise ChildFailedError(
torch.distributed.elastic.multiprocessing.errors.ChildFailedError:

And the error seem to be when loading the training data from M4:
ValueError: setting an array element with a sequence. The requested array has an inhomogeneous shape after 1 dimensions. The detected shape was (48000,) + inhomogeneous part.
I have checked and the error seem to be coming from the training data and not the valid/test data.

I have encountered the same problem. Could you tell me how can I solve it

I keep getting the very same error when I try to run the M4 script:
train_data, train_loader = data_provider(args, 'train')
  File "/data5/aamayuelasfernandez/Time-LLM/data_provider/data_factory.py", line 34, in data_provider
    data_set = Data(
  File "/data5/aamayuelasfernandez/Time-LLM/data_provider/data_loader.py", line 335, in __init__
    self.__read_data__()
  File "/data5/aamayuelasfernandez/Time-LLM/data_provider/data_loader.py", line 343, in __read_data__
    training_values = np.array(
ValueError: setting an array element with a sequence. The requested array has an inhomogeneous shape after 1 dimensions. The detected shape was (48000,) + inhomogeneous part.
[2024-03-19 11:34:44,270] torch.distributed.elastic.multiprocessing.api: [ERROR] failed (exitcode: 1) local_rank: 0 (pid: 3176791) of binary: /data5/aamayuelasfernandez/miniconda3/envs/tst/bin/python

Traceback (most recent call last):
  File "/data5/aamayuelasfernandez/miniconda3/envs/tst/bin/accelerate", line 8, in <module>
    sys.exit(main())
  File "/data5/aamayuelasfernandez/miniconda3/envs/tst/lib/python3.10/site-packages/accelerate/commands/accelerate_cli.py", line 47, in main
    args.func(args)
  File "/data5/aamayuelasfernandez/miniconda3/envs/tst/lib/python3.10/site-packages/accelerate/commands/launch.py", line 1014, in launch_command
    multi_gpu_launcher(args)
  File "/data5/aamayuelasfernandez/miniconda3/envs/tst/lib/python3.10/site-packages/accelerate/commands/launch.py", line 672, in multi_gpu_launcher
    distrib_run.run(args)
  File "/data5/aamayuelasfernandez/miniconda3/envs/tst/lib/python3.10/site-packages/torch/distributed/run.py", line 803, in run
    elastic_launch(
  File "/data5/aamayuelasfernandez/miniconda3/envs/tst/lib/python3.10/site-packages/torch/distributed/launcher/api.py", line 135, in __call__
    return launch_agent(self._config, self._entrypoint, list(args))
  File "/data5/aamayuelasfernandez/miniconda3/envs/tst/lib/python3.10/site-packages/torch/distributed/launcher/api.py", line 268, in launch_agent
    raise ChildFailedError(
torch.distributed.elastic.multiprocessing.errors.ChildFailedError:

And the error seem to be when loading the training data from M4:
ValueError: setting an array element with a sequence. The requested array has an inhomogeneous shape after 1 dimensions. The detected shape was (48000,) + inhomogeneous part.
I have checked and the error seem to be coming from the training data and not the valid/test data.

I have encountered the same problem. Could you tell me how can I solve it

It seems that the solution under this link can solve the problem.


Deploy Tempo into Monitoring-Central

Summary
For the PoC and initial stages of use (if PoC is successful), we will self-host Tempo within Monitoring-central with a GCP store backing it. As initially, an OTC instance will front the incoming traces, we do not require external access to the Tempo instance itself.
Checklist

Create necessary infrastructure requirements
Add Tempo charts to monitoring-central
Deploy charts
Test setup with tracegen

Deployed through https://github.com/gitpod-io/ops/blob/main/deploy/production/monitoring-central/argocd/tempo.yaml


There is line on the top of the discover page build 2.2.7

Can you upload your screenshot? @ThierryThevenet


Missing CVE info

Hello, why is this security issue still reserved? https://cve.mitre.org/cgi-bin/cvename.cgi?name=2018-14766 Version 2.6.2: https://github.com/IdentityServer/IdentityServer3/releases/tag/2.6.2

@leastprivilege is it possible to provide info?

No. I don't know what this is. Anybody can open CVEs.
That being said - IdentityServer3 has some security updates. We distribute them via the security maintenance program.
https://leastprivilege.com/2020/01/05/identityserver3-and-upcoming-samesite-cookie-changes-in-browsers/

Thanks for the reply!


Add AN-94, ISO, Dual Kodachis from Season 5

Add AN-94, ISO, Dual Kodachis from Season 5. I doesn't have exactly numbers for challenges so I gave "TBA" label and will update it later.

I took numbers for melee from kali sticks, for ISO from Uzi, for AN-94 is default. I also fixed aliases.


Update wget

Summary
Improve examples/wget

Enable URL from command line
It can be used with ifup command
Add HTTPS protocol

Impact
only wget
Testing
Tested by spresense:wifi

a competing PR: https://github.com/apache/incubator-nuttx-apps/pull/333

@yamt there is nxstyle warning need to fix.

@xiaoxiang781216 this is not my PR.

@yamt, sorry I make a mistake, #346 and #333 are modifing the same files. @SPRESENSE please add a new patch to address the style issue, thanks.

the system-global tls design in this patch doesn't work for my use cases, where i need to use a few types of tls sessions. (different set of credentials etc)
@SPRESENSE otoh, does https://github.com/apache/incubator-nuttx-apps/pull/333 work for your use case?

@yamt
Sorry too late.
I removed SSL support patch, because you already pushed.
However, I have some questions for your patch, maybe I'll comment on #333 later.
@xiaoxiang781216
Could you please review again?

LGTM.


Add Grid.Blazor component

Please consider adding Grid.Blazor to the Libraries section.

@gustavnavar I can't edit a private branch. Please make the suggested change on your branch :point_up:. I'll call for review right after that.

I think I deleted my private branch by mistake.
I will close this pull request and create a new one

Sure thing ... use that suggested text :point_up:.


Integrate model-explorer fork into tt-mlir

This is waiting on us having a tenstorrent repo for the fork. If this does not happen soon we will integrate https://github.com/madcampos/model-explorer/ directly.

Since we have the repo now, i'll get on this.


Analyzer regression between 0.27.2 -> 0.27.3-alpha.6: Files are no longer cleared

Repro steps:

Pull the dart-services repo (https://github.com/dart-lang/dart-services), pub get, dart tools/grind.dart test
(Passes)

Change the pubspec.yaml to analyzer: 0.27.3-alpha.6
pub upgrade
dart tools/grind.dart test
Tests now fail.
dart-services needs to clear files from the context between each usage. This is done by e.g.
(analyzer.dart, ln 127).
      // Delete the files
      changeSet = new ChangeSet();
      sourcesList.forEach((s) => changeSet.removedSource(s));
      _resolver.clear();
      _context.applyChanges(changeSet);
      _ensureAnalysisDone(_context, _MAX_ANALYSIS_DURATION);

This no longer seems to work. The verification tests fail as the analyzer is still reporting the old results.
 PASS: analyzer.dartdoc multi file missing import
  FAIL: analyzer.dartdoc multi file clean between operation
    Expected: empty
      Actual: [
      AnalysisIssue:error: Target of URI does not exist: 'bar.dart' [1],
      AnalysisIssue:warning: The function 'bar' is not defined. [4]
    ]

This will block our ability to upgrade dart-services.

I was able reproduce the problem.
The problem is caused by the incomplete StringSource implementation in dart-services.

The property uri is now required.
The property encoding is not what you think it is :-)  It should be encoded representation of the source, its ID. Content encoding, like UTF-8 is not needed at this level, because Source already provides the contents as String.

With these two problems fixed I see that all tests pass.
[cut]
  PASS: Summarizer Html and css detection

  All 108 tests passed.
  unittest-suite-success

finished in 60.842 seconds.

Thanks @scheglov
It looks like I can just defork our implementation of StringSource from the one in the Analyzer package - and that resolves it.


Get SharpZipBaseException when set ZipInputStream.Password to "000671"

Steps to reproduce

ZipInputStream s = new ZipInputStream(File.OpenRead("test.zip"));
s.Password = "000671";    //the correct password of test.zip is 123456
s.Read()

Expected behavior
Unhandled exception. ICSharpCode.SharpZipLib.Zip.ZipException: Invalid password
Actual behavior
Unhandled exception. ICSharpCode.SharpZipLib.SharpZipBaseException: Illegal rep dist code
at ICSharpCode.SharpZipLib.Zip.Compression.Inflater.DecodeHuffman()
at ICSharpCode.SharpZipLib.Zip.Compression.Inflater.Decode()
at ICSharpCode.SharpZipLib.Zip.Compression.Inflater.Inflate(Byte[] buffer, Int32 offset, Int32 count)
Version of SharpZipLib
Version="1.3.2"
Only this string(000671) will get SharpZipBaseException, Is it special?

Well, the way the password is checked is that it's checked against a 1-byte CRC:
https://p1k.se/appnote.md#s616-decrypting-the-encryption-header
That means that there is 1 in 255 chance of a wrong password is not detected. That means that the "decrypted" archive will just appear to be corrupted instead.

@piksel thanks

@piksel How to check a password is correct?


Allow overriding ipxe boot filename on DHCP static mappings

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[X] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[X] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Is your feature request related to a problem? Please describe.
So, the netboot filename can be overridden in a static mapping in DHCP settings, but this means if you want to set a specific IPXE script for that host, you would need to compile ipxe with the embedded script.
Describe the solution you like
The main netboot section in DHCP settings has an option to set the ipxe boot filename, this option should be added to the static mapping configuration as an override option too.
Describe alternatives you considered
The existing features already sort of allow this, but requires recompiling ipxe with a new embedded script every single change. Being able to just pass a new URL in the dhcp static mapping would be great.
Additional context
Add any other context or screenshots about the feature request here or links to relevant forum thread or similar

it might be better to check what would be needed in Kea (upcoming for ipv4 in 24.1), isc-dhcp is EOL and we should aim for at least a feature freeze.


As a game host I want to modify the game settings to play according to my preferences

Story: As a game host I want to be able to modify the game settings to customize the game for my lobby.
Acceptance criteria:
Hosts should be able to:

[x] #39

[x] #40

[x] #41

[x] #42

[x] #43

[x] #44

For linked commits see sub-tasks


Remove junk out of conf files

Coverage remained the same at 94.581% when pulling f97c3f6400a5c9a590e44bac25b1b30b1f438b67 on conf_fix into a0ace899e5a80127bb4090c8558a612ed1a3b60d on master.


VideoToolbox Encoder option not showing on Mac

As title says, on an M1 Mac, the option to use the VideoToolbox Encoder is not there in the list?

I believe that was added in 1.5.0 or somewhere around there and this is only on 1.4.2

I believe that was added in 1.5.0 or somewhere around there and this is only on 1.4.2

Do you know if/when this will be updated to a newer version?

This containers implements the Linux version of HandBrake.  I think the VideoToolbox encoder is Mac specific.

Closing this issue.  Please re-open if needed.


Conditional requirement feature

Added conditional requirement rule type along with related features and updated rule tests. @nmonga91 @bsweger

@jworcestBAH Finished reviewing (looks like a lot of the same code I reviewed for the file attributes PR). I have a to-do, which is to update the validation db init script in db-247-config to insert the new timing values (see note)


Need to change bootstrap-sass' icon-font-path to customize

Please provide us with the following information:

OS?

Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)

Ubuntu Xenial.
Versions.

Please run ng --version. If there's nothing outputted, please run in a Terminal: node --version and paste the result here:

angular-cli: 1.0.0-beta.22-1
node: 7.2.1
os: linux x64
Repro steps.

Was this an app that wasn't created using the CLI? What change did you do on your code? etc.

I can include bootstrap via angular-cli.json by styles:
"styles": [
  "../node_modules/bootstrap-sass/assets/stylesheets/_bootstrap.scss",
  "../node_modules/bootstrap-sass/assets/stylesheets/bootstrap/_theme.scss",
  "styles.scss"
]

But in this way I can't customize it (for example to change font-family-sans-serif). Then I removed the angular-cli.json bootstrap entries and put in styles.scss:
$icon-font-path: '../node_modules/bootstrap-sass/assets/fonts/bootstrap/';
$font-family-sans-serif: Tahoma;
$font-size-base: 8pt;

@import '../node_modules/bootstrap-sass/assets/stylesheets/_bootstrap.scss';
@import '../node_modules/bootstrap-sass/assets/stylesheets/bootstrap/_theme.scss';

The problem is that change to icon-font-path should not be needed but currently is.

Yeah you shouldn't need to specify the font path just because you're importing it from a scss file. Sounds like a bug.

I seem to remember from another issue that this is actually intended as per how SASS works.


Add unit tests

Refactor app to allow testing and add basic tests for the handling calls and message content.

Note: Relates to issue #2


python3Packages.sentry-sdk: 1.1.0 -> 1.2.0

Motivation for this change
Update to latest upstream release 1.2.0
Change log: https://github.com/getsentry/sentry-python/releases/tag/1.2.0
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 129549 run on x86_64-linux 1

1 package failed to build:

octoprint

8 packages built:

alerta-server
cura
gns3-gui
gns3-server
home-assistant
moodle-dl
python38Packages.sentry-sdk
python39Packages.sentry-sdk


Update vite.config.ts

Expose .mjs files like you do in other libs such as react-qwik
What is it?

[ ] Feature / enhancement
[x] Bug
[ ] Docs / tests

Description
This PR enables the exposure of .mjs as well as .cjs files.
Checklist:

[x] My code follows the developer guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] Added new tests to cover the fix / functionality

Thank you!!


Include the 5.x RMT driver headers

ESP-IDF 5.0 added a new RMT driver that deprecates the old driver. The new headers are required to access the new driver.

Yes please, I really want this. What's the reason this PR was closed?


Hide notification preview

There should be an option to hide the notification preview text

Why should there be an option for this?

when you are for example showing something on your computer to other people, you don't want them to see the conversation or when you use the app at work, and people  often come to you, its better to see an "You have a new message" than some private conversation :stuck_out_tongue:

I don't see this in any other app. You could use Mac OS's do not disturb function.

The Messages has it for example...

Oh wow, never seen that before. I didn't see any option for this in the documentation. Is this private API? Would appreciate any hints in this direction!

It's probably a private API since the only apps I have with that option in the notification center are Messages and Mail (haven't noticed this)
But a lot of IM apps implement this in their Settings, a good example its the Messenger app for iOS. I think Telegram is already using it too.

Looks like goofy has one now, whether it always did or it's new - is this resolved?

+1 to this, already had a couple bad experiences with messages being shown when I didn't want them to. My solution to this is: Close Goofy. (the "Do not disturb" mode removes ALL notifications and is hard to switch on)


ci: do not immediately remove the ok-to-test label

It seems that Mergify removes the ok-to-test label as soon as someone adds it. We don't want that, as it can trigger more CI runs than needed.

Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

/retest ci/centos/<job-name>: retest the <job-name> after unrelated
failure (please report the failure too!)
/retest all: run this in case the CentOS CI failed to start/report any test
progress or results

This needs manual merging, ideally when other PRs are not running any CI jobs yet.

Added ok-to-test`, no real CI work is running for this PR.


reject pemap/commap with duplicate or too few cpus

Original author: Jim Phillips (@jcphill)
Original issue: https://charm.cs.illinois.edu/redmine/issues/1039

Running, e.g., "+p16 +pemap 1-15" or "+pemap 0-4,4-8" is almost certainly an error and should be rejected.

Original date: 2017-04-04 17:42:53

Validation of the old command lines should be reconsidered when the binding substrate changes to hwloc.

Original date: 2018-01-23 22:43:09

The function responsible for parsing these parameters, search_pemap, is not amenable to quickly adding checks for these conditions.

Original date: 2018-01-31 15:46:14

I'd say we can close this issue or push it off to a future release. The new ++oneWthPer* routines should obviate the need for pemaps and commaps for most users


insomnia 2023.4.0 fail to start on windows 8.1

Expected Behavior
I expect to have the app working :smile:
Actual Behavior
installing the latest major release on windows 8.1 fails
Reproduction Steps
No response
Is there an existing issue for this?

[X] I have searched the issue tracker for this problem.

Additional Information
No response
Insomnia Version
2023.4.0
What operating system are you using?
Windows
Operating System Version
8.1
Installation method
exe
Last Known Working Insomnia version
2023.3.0

According to Changelog they upgraded Electron to version 23 and Nodejs to 18.12. Node 18

According to Changelog they upgraded Electron to version 23 and Nodejs to 18.12. Node 18

According to Changelog they upgraded Electron to version 23 and Nodejs to 18.12.

Node.js does not support running on operating systems that are no longer supported by their vendor. For operating systems where their vendor has planned to end support earlier than April 2025, such as Windows 8.1 (January 2023) and Windows Server 2012 R2 (October 2023), support for Node.js 18 will end at the earlier date.

Nodejs 18 Changelog

According to Changelog they upgraded Electron to version 23 and Nodejs to 18.12.

Node.js does not support running on operating systems that are no longer supported by their vendor. For operating systems where their vendor has planned to end support earlier than April 2025, such as Windows 8.1 (January 2023) and Windows Server 2012 R2 (October 2023), support for Node.js 18 will end at the earlier date.

Nodejs 18 Changelog

I use Node 18.15.0 on that specific computer, have no problem with it.  End of support doesn't mean that will stop working.

@br4instormer
electron v23 may be the problem, because vscode also stops providing updates for windows 8.1 this month.

Correct, vscode is also ending support for Windows 8.1
If chromium ends support then so does electron and therefore any electron app that is being actively maintained. You can still download previous versions of insomnia to use on out-of-support operation system versions.


"Real" full-screen

For my PDF hosting service, which provides an embed code for documents, I was looking to have a "real" full-screen mode - that is, displaying the regular viewer in full-screen, rather than a slimmed-down fit-to-page "presentation mode" (as this makes text-dense documents hard to read). Finding no such functionality in the default viewer, I decided to implement it myself...
While implementing this, I found that there are some problems with the way presentation mode works - most notably the assumption that "if I'm in full-screen, I must be in presentation mode" - that break 'regular' full-screen. I've more or less hacked around this in my implementation by setting a class on the <body> and a variable in the PresentationMode object when in presentation mode, but this is far from an ideal solution.
My suggestion would be to either implement a "real" full-screen mode, or to at least modify the behaviour of PresentationMode so that it doesn't assume that 'full screen' and 'presentation mode' are the same thing (making it easier for developers to implement their own variants of full-screen without breaking presentation mode).
Somewhat related to #3828.
EDIT: For completeness' sake, tthe implementation of full-screen I mean can be seen here (the right-most icon in the collapsed toolbar).

I have just encountered the same problem. Solved it by requesting full screen for the outer document (i.e. not the PDF.js iframe) and resizing the iframe to 100% width and height while full screen is activated.
Not an ideal solution though. Would be nice if pdf.js provided an option or even 2 buttons to choose from: One for presentation mode (no toolbars, no UI) and one for "reading mode" (fullscreen with regular controls).
I agree with @joepie91 that it would be reasonable to assume that landscape usually needs presentation mode and portraits are usually better to be displayed in reading mode.

[...] In its current state, it's hard to implement anything to do with full-screen, without first having to dig through a large amount of PresentationMode code, having to actually change the PresentationMode code to not interfere.

This should have been addressed as part of PR #5699, since the PDFPresentationMode implementation won't unconditionally attach fullscreenchange event listeners any more.
Hence this issue should be closed, since it's been stated repeatedly (see the issues referenced above) that a general fullscreen mode won't be implemented in the default PDF.js viewer. /cc @timvandermeij


Change asm! to llvm_asm!

asm! will soon stop working
this commit changes asm! macros to  llvm_asm! macros

Thanks! This was done in https://github.com/alexcrichton/dlmalloc-rs/pull/13 too, though, so I'm going to close.


TypeError: Cannot read properties of null (reading 'useState')

Can anyone help with this issue?

What kind of project setup are you using?
React/next.js/vite/custom?
Please create a repository where this issue could be reproduced.

It's a next.js project.
When I'm importing the component to my payment page it's showing this error.

I just used it on a nextjs project, did not face any issues
import { useBkash } from 'react-bkash';

export const Checkout = () => {
	const { error, loading, triggerBkash } = useBkash({
		onSuccess: data => {
			console.log(data); // this contains data from api response from onExecutePayment
		},
		onClose: () => {
			console.log('Bkash iFrame closed');
		},
		bkashScriptURL: 'https://scripts.sandbox.bka.sh/versions/1.2.0-beta/checkout/bKash-checkout-sandbox.js', // https://scripts.sandbox.bka.sh/versions/1.2.0-beta/checkout/bKash-checkout-sandbox.js
		amount: 1000,
		onCreatePayment: async paymentRequest => {
			return {
				paymentID: 'string',
				createTime: 'string;',
				orgLogo: 'string;',
				orgName: 'string;',
				transactionStatus: 'string;',
				amount: 'string;',
				currency: 'string;',
				intent: 'string;',
				merchantInvoiceNumber: 'string;',
			};
		},
		onExecutePayment: async paymentID => {
			// call your executePayment API here
			return await fetch('<your backend api>/execute/${paymentID}', {
				method: 'POST',
			}).then(res => res.json());

			// it doesn't matter what you return here, any errors thrown here will be available on error return value of the useBkash hook
		},
	});

	return (

loading: {String(loading)}

error: {error?.message || 'none'}

			{!loading && !error && <button onClick={triggerBkash}>click to pay</button>}

	);
};

this is my component and it works as expected.
I think the problem is being caused by somewhere else, please check if you have imported useState in all of your components that use state.
If it doesn't help, please provide an example repository that reproduces this error.

Thank you brother. I had some problem with react version. After updating react version this issue was fixed.


improve the default behavior of template fetching

The template fetching typically is customized by the hosting application, but it would be better, even if for quick prototyping only, if it was asynchronous. (https://github.com/zalando/tailor/blob/master/lib/fetch-template.js#L12)

Should port the template handling logic from zalando tailor here which is much matured and supports caching as well.


Torch GNN support

Current helper methods for GNNs are centered on tensorflow and keras. Create backend operations to abstract them so that they can also be implemented through torch. This needs to add a new test to make sure everything is working.
Related tests: tests.test_gnn.test_appnp

Split tests in two to differentiate between backends., provided native-looking implementations and implemented an abstraction on the core library.

GNN training is not integrated as part of the backend but as part of the benchmarks module, since it does not provide base operations.

In the future, creating a different module (or core submodule) to host more GNN operations can be considered.

Related tests: tests.test_gnn.test_appnp_tf, tests.test_gnn.test_appnp_torch


[SPARK-48403][SQL] Fix Lower & Upper expressions for UTF8_BINARY_LCASE & ICU collations

What changes were proposed in this pull request?
String lowercase/uppercase conversion in UTF8_BINARY_LCASE now works using ICU default locale, similar to how other ICU collations currently work in Spark.
Why are the changes needed?
All collations apart from UTF8_BINARY should use the same interface (UCharacter) that utilizes ICU toLowerCase/toUpperCase implementation, rather than mixing JVM & ICU implementations.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing unit tests and e2e sql tests.
Was this patch authored or co-authored using generative AI tooling?
No.

thanks, merging to master!


Revert "fix: fix "KBA fetch failed" error"

The "Related Knowledgebase article" part in Details page
keeps showing the "in loading state" progress bar instead
of real content. Revert this commit to fix this issue.
This reverts commit 837e3147933bb72650578a3fbeabbf8c8eec886d.

@chenlizhong , could you please help review the changes?


Fixes & Buildkite for Android

Buildkite build in progress here: https://buildkite.com/learningequality/kolibri/builds/1252#_


gcc version

GCC 4.8 will no longer be supported in the future(may be).
Since the default GCC of .el7 is 4.8, we need to consider using SCL.

Notable Changes
No additional commits.
Due to incorrect staging of the upgrade to the GCC 4.9.X compiler, the latest releases for PPC little endian were built using GCC 4.9.X instead of GCC 4.8.X. This caused an ABI breakage on PPCLE based environments. This has been fixed in our infrastructure and we are doing this release to ensure that the hosted binaries are adhering to our platform support contract.
Note that Node.js versions 10.X and later will be built with version 4.9.X or later of the GCC compiler, and it is possible that Node.js version 9.X may be built on the 4.9.X compiler at a later time as the stated minimum compiler requirement for Node.js version 9.X is 4.9.4.

node/CHANGELOG_V9.md at master · nodejs/node
https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V9.md

ref:
Red Hat Software Collections Product Life Cycle - Red Hat Customer Portal
https://access.redhat.com/support/policy/updates/rhscl

Node.js 10.0.0 has been released.
https://nodejs.org/en/blog/release/v10.0.0/

Supported toolchains
Depending on host platform, the selection of toolchains may vary.
Unix
GCC 4.9.4 or newer
Clang 3.4.2 or newer

https://github.com/nodejs/node/blob/master/BUILDING.md#supported-toolchains


Crash on Ubuntu 14.04 with nd4j-cuda-7.5 backend; works with native

When running dl4j using the CUDA backend I get a java.lang.NullPointerException.
When running with the native backend it works.
The output of the CUDA run is found here:
https://gist.github.com/Prechtig/ab03ed3b98e29c9d47563ce5ff97ff33
The output of deviceQuery
https://gist.github.com/Prechtig/484193f714bebe07b46fe94cb0a25c36
This is the nn layout
Builder builder = new NeuralNetConfiguration.Builder()
		.seed(98)
		.iterations(1)
		.regularization(true)
		.l2(0.0005)
		.learningRate(0.008)
		.weightInit(WeightInit.XAVIER)
		.activation("relu")
		.optimizationAlgo(OptimizationAlgorithm.STOCHASTIC_GRADIENT_DESCENT)
		.updater(Updater.NESTEROVS).momentum(0.9)
		.list()
		.layer(0, new ConvolutionLayer.Builder()
				.name("layer0")
				.kernelSize(4, 4)
				.nIn(3)
				.stride(2, 2)
				.nOut(20)
				.padding(1, 1)
				.dropOut(0.5)
				.activation("relu")
				.build())
		.layer(1,
				new SubsamplingLayer.Builder(SubsamplingLayer.PoolingType.MAX)
				.name("layer1")
				.kernelSize(2, 2)
				.stride(2, 2)
				.build())
		.layer(2, new ConvolutionLayer.Builder()
				.name("layer2")
				.kernelSize(3, 3)
				.nIn(20)
				.stride(1, 1)
				.nOut(20)
				.padding(1,1)
				.dropOut(0.5)
				.activation("relu")
				.build())
		.layer(3,
				new SubsamplingLayer.Builder(SubsamplingLayer.PoolingType.MAX)
				.name("layer3")
				.kernelSize(2, 2)
				.stride(2, 2)
				.build())
		.layer(4, new DenseLayer.Builder()
				.name("layer4")
				.activation("relu")
				.nOut(200)
				.build())
		.layer(5, new OutputLayer.Builder(LossFunctions.LossFunction.SQUARED_LOSS)
				.name("layer5")
				.nOut(featureCount)
				.activation("identity")
				.build())
		.backprop(true).pretrain(false)
		.setInputType(InputType.convolutionalFlat(height, width, 3));

height & width?

w=640 & h=360

and featureCount?

And iterator setup?

featureCount is 4
It's probably easier to browse our code.
We use this iterator https://github.com/Prechtig/FPSAgent/blob/master/SupervisedLearning/src/main/java/org/mma/imagerecognition/iterator/FileSystemIterator.java

Thanks

Issue is fixed, but will be merged to master a bit later, probably tomorrow.
Thanks for highlighting this issue.

Btw, jfyi:
native:
o.d.o.l.PerformanceListener - iteration 1; iteration time: 15485 ms; samples/sec: 4.133; batches/sec: 0.065; score: 0.34078801834659783;
o.d.o.l.PerformanceListener - iteration 2; iteration time: 15143 ms; samples/sec: 4.226; batches/sec: 0.066; score: 0.3325135345483285;
o.d.o.l.PerformanceListener - iteration 3; iteration time: 14176 ms; samples/sec: 4.515; batches/sec: 0.071; score: 0.33685200394798026;
o.d.o.l.PerformanceListener - iteration 4; iteration time: 14462 ms; samples/sec: 4.425; batches/sec: 0.069; score: 0.3402634256880396;
o.d.o.l.PerformanceListener - iteration 5; iteration time: 14112 ms; samples/sec: 4.535; batches/sec: 0.071; score: 0.33317638083040263;
o.d.o.l.PerformanceListener - iteration 6; iteration time: 14991 ms; samples/sec: 4.269; batches/sec: 0.067; score: 0.32988175542188564;
o.d.o.l.PerformanceListener - iteration 7; iteration time: 13873 ms; samples/sec: 4.613; batches/sec: 0.072; score: 0.3307708610296978;

cuda floats:
o.d.o.l.PerformanceListener - iteration 1; iteration time: 7838 ms; samples/sec: 8.165; batches/sec: 0.128; score: 0.3407881744795714;
o.d.o.l.PerformanceListener - iteration 2; iteration time: 3197 ms; samples/sec: 20.019; batches/sec: 0.313; score: 0.3325136526148267;
o.d.o.l.PerformanceListener - iteration 3; iteration time: 3407 ms; samples/sec: 18.785; batches/sec: 0.294; score: 0.33685216007911345;
o.d.o.l.PerformanceListener - iteration 4; iteration time: 3843 ms; samples/sec: 16.654; batches/sec: 0.260; score: 0.3402635434963399;
o.d.o.l.PerformanceListener - iteration 5; iteration time: 3235 ms; samples/sec: 19.784; batches/sec: 0.309; score: 0.33317649857846005;
o.d.o.l.PerformanceListener - iteration 6; iteration time: 3597 ms; samples/sec: 17.793; batches/sec: 0.278; score: 0.32988191133713207;
o.d.o.l.PerformanceListener - iteration 7; iteration time: 3851 ms; samples/sec: 16.619; batches/sec: 0.260; score: 0.3307709787997288;
o.d.o.l.PerformanceListener - iteration 8; iteration time: 3562 ms; samples/sec: 17.967; batches/sec: 0.281; score: 0.3310498854807775;
o.d.o.l.PerformanceListener - iteration 9; iteration time: 3392 ms; samples/sec: 18.868; batches/sec: 0.295; score: 0.3330261035624281;
o.d.o.l.PerformanceListener - iteration 10; iteration time: 3337 ms; samples/sec: 19.179; batches/sec: 0.300; score: 0.3307268088801962;

cuda halfs:
o.d.o.l.PerformanceListener - iteration 7; iteration time: 2868 ms; samples/sec: 22.315; batches/sec: 0.349; score: 0.3309114687442779;
o.d.o.l.PerformanceListener - iteration 8; iteration time: 2792 ms; samples/sec: 22.923; batches/sec: 0.358; score: 0.3309114687442779;
o.d.o.l.PerformanceListener - iteration 9; iteration time: 2676 ms; samples/sec: 23.916; batches/sec: 0.374; score: 0.3327864687442779;
o.d.o.l.PerformanceListener - iteration 10; iteration time: 2854 ms; samples/sec: 22.425; batches/sec: 0.350; score: 0.3309114687442779;
o.d.o.l.PerformanceListener - iteration 11; iteration time: 2821 ms; samples/sec: 22.687; batches/sec: 0.354; score: 0.33153646874427795;
o.d.o.l.PerformanceListener - iteration 12; iteration time: 2887 ms; samples/sec: 22.168; batches/sec: 0.346; score: 0.33216146874427793;
o.d.o.l.PerformanceListener - iteration 13; iteration time: 2887 ms; samples/sec: 22.168; batches/sec: 0.346; score: 0.33372396874427795;
o.d.o.l.PerformanceListener - iteration 14; iteration time: 2775 ms; samples/sec: 23.063; batches/sec: 0.360; score: 0.33716146874427794;
o.d.o.l.PerformanceListener - iteration 15; iteration time: 2566 ms; samples/sec: 24.942; batches/sec: 0.390; score: 0.32934896874427794;


Add trackers

Hello there!
Could you block this tracker?
http://cj.dotomi.com/links-t/7988357/type/dlg/sid/0d007952wvav/http://www.forever21.com/mx/
target url: http://www.forever21.com/mx/

Any examples of this in the wild? @DavidSelem


Account Creation

As a user, I want to be able to create an account so that I can use HoopLife
Need a view dedicated to create an account
Need a username input field
Need a password input field
Need a confirm password input field
Need an email input field
Need a first name input field
Need a last name input field
Fields need validation so improper values are not submitted
Need a “Create Account” button
Need a “Already have an account? Login” hyperlink that redirects to the login view
When I click submit, I am redirected to the login page.

There is currently an issue with preflight stuff. Fixing this will be part of our backlog for now.


feat(driverProvider) Adding browserstackProxy param in BrowserStack driverProvider

Adding browserstackProxy configuration param to enable users behind proxy to run their tests, example value for this config : "http://proxy.example.com:1234".

@qiyigg Can you please review this?

@qiyigg
Hi, can you please review this?

@qiyigg , Any comments on this? And can you re run the travis and circleci builds, as travis build ran successfully, when I ran it under my account from my repo.

merged, thanks


Modyfing GD's APK File

So I've been messing around decompiled gd apk files and found out that some of things in .so files are not encoded and you can freely edit them. And my question is how to change from boomlings servers to my servers. Because when i change http://www.boomlings.com to my url and then compile it just crashes after start. thanks for anwser

[ps. ik some of things can be encoded in base64]

The links must be the same length

Oh I see, thanks. I just wanna do things like some people do like custom buttons etc. [for example for social media or idk]

those can either be performed by a texture and url swap (which involves editing the so) or, if you want to add a button, hooking the so file to add your own code (along with adding a texture as well)
i don't think explaining something like this is within the scope of a gd documentation page unless you need help with something like the ccmenuitemspriteextra or the texture format

How can I hook .so file? I mean I know now how to edit server address, probably know how to modify some strings in .so file but how to hook file meaning what programs you recommend or something? It's something new for me but I can try to learn something new :)

That's a whole different step and I would genuinely suggest you do your research on what a so file even is before doing that. Also you don't decompile an APK you unpack it and a SO file isn't "encoded", the text you see is the .rotdata, the rest are compiled binaries which represent the assembly of the APK.

Also, I would like to ask you to join the GDP Discord server instead of using GitHub issues on a repository for your questions.


Undocumented julia-* config options?

I'm surprised to read only two configuration options on this repo's README, but I read from coc autocompletion in my coc-settings.json that julia.* yields many more config options.. are they really provided by this extension? Where are they documented?

only two configuration options on this repo's README

The two are not configuration options, they're command.

are they really provided by this extension?

Yes, they're provided by coc-julia, you can get them all from https://github.com/fannheyward/coc-julia/blob/master/package.json#L53.
I'm a little lazy to document them in README 😵💫, will update ASAP.


Add support in flutter tools for incremental compilation of sources using the new Dart Front End

Add support in flutter tools to do incremental compilation of flutter sources that have changed using the Dart Front end and push the incremental intermediate files (kernel files) to the device.
This will enable fast edit/refresh and the hot reload modes supported by the Dart VM.

https://fuchsia-review.googlesource.com/#/c/tonic/+/54888/ final CL which turns on hot reload functionality


Adds some  in DG

Codecov Report

Merging #327 (7f1a513) into master (6d8f78d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #327   +/-   ##
=========================================
  Coverage     74.12%   74.12%
  Complexity      687      687
=========================================
  Files            98       98
  Lines          2095     2095
  Branches        238      238
=========================================
  Hits           1553     1553
  Misses          475      475
  Partials         67       67

Impacted Files
Coverage Δ

.../java/seedu/address/logic/commands/AddCommand.java
100.00% <ø> (ø)

...seedu/address/logic/commands/DeleteTagCommand.java
97.82% <ø> (ø)

...java/seedu/address/logic/commands/EditCommand.java
96.38% <ø> (ø)

...java/seedu/address/logic/commands/FindCommand.java
69.23% <ø> (ø)

...java/seedu/address/logic/commands/RedoCommand.java
91.66% <ø> (ø)

...ava/seedu/address/logic/commands/ScrubCommand.java
88.88% <ø> (ø)

...java/seedu/address/logic/commands/UndoCommand.java
91.66% <ø> (ø)

...a/seedu/address/logic/parser/AddCommandParser.java
92.00% <ø> (ø)

...eedu/address/logic/parser/AddTagCommandParser.java
100.00% <ø> (ø)

.../seedu/address/logic/parser/AddressBookParser.java
91.52% <ø> (ø)

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7841248...7f1a513. Read the comment docs.


chore: bdd-spring-1576730311 to 0.0.1

chore: Promote bdd-spring-1576730311 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Change manifest type label

take changes on data type labels from #323 to this PR
Change labels of data types from "assay" & "clinical/biospecimen" to "file" & "record".

@milen-sage would you like me to change the default manifest_record_type from 'entity' to 'table' in the repo as well?

Since the front end changes has been done, I am going to merge it now.

🚀

@afwillia there is another demo coming up for INCLUDE this Fri, so let's postpone pulling in these changes in the INCLUDE app for now. We can coordinate with @lopierra to incorporate later, after the demo. @lopierra we can sync up on what this PR does  - no substantial changes are required on your end.
However, these changes could be pulled in the CSBC instance. @afwillia you can coordinate with @vpchung during your walkthrough for local development with her. It will require updating the config.json file.

@milen-sage yes, will do! If I understand correctly, the change to config.json is that type is now record or file?

If I understand correctly, the change to config.json is that type is now record or file?

@afwillia yep!


Update readme.md

What Changed
Why
Todo:

[ ] Add tests
[ ] Add docs
[ ] Add yourself to contributors (run yarn contributors:add))

@all-contributers add @scanbns for code

@all-contributors please add @scanbns for code

@all-contributors please add @scanbns for code

@all-contributors please add @scanbns for code


isBetween() produces false positive when this moment is in UTC and the fromValue and toValue were formatted string dates

Describe the bug
When the currentMoment is in UTC and the startDate and endDate are passed in as string, the result of the isBetween function is expectedly wrong.
To Reproduce
Steps to reproduce the behavior, try to execute the following.
const currentMoment = moment().year(2020).month(9).date(14).tz('UTC');
currentMoment.isBetween('2020-10-15', '2020-10-16', 'date', '[]')
Expected behavior
The result of the above will yield true, while the expected result is false. In plain English, the currentMoment of the date 2020-10-14 is NOT in between '2020-10-15' and '2020-10-16', yet the function responded as true.
Desktop (please complete the following information):

Browser: chrome
Version: 2.29.1

Moment-specific environment
(new Date()).toString(): Wed Oct 14 2020 15:19:38 GMT+0200 (Central European Summer Time)
toLocaleString(): 10/14/2020, 3:19:38 PM
getTimezoneOffset(): -120
userAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.75 Safari/537.36
version: 2.29.1

I'm more than happy to contribute a fix if this is recognized as a real bug.

const timeSlot = moment(slot.format('HH:mm'))
const twoHoursFromNow = moment(moment.tz("Europe/Istanbul").add(2, "hours").format('HH:mm'))
const isBeforeTwoHoursFromNow = timeSlot.isBefore(twoHoursFromNow, "hours")
This is my workaround solution to bug. Format all the times then change them into moment again before compare.

The first line uses UTC, for whatever reason, and the "time strings" don't have a timezone, so it's local time. Also the first instance has the time from your current time, and when you change the tz to UTC it can change the date. Just pass proper boundaries. There are moment constructors that can achieve it ergonomically.


How can I close an application ?

Hello,
Thanks to your job I'm able to open an application (an Excel file in my case).
Do you know something to close this Excel application after some processing that I need to do ?
Thank you,
Mathieu

What about cmd+q? Don't really understand your question...

More precisely, I need to know the PID of the process that I launch.
If I know this PID, I can close the application with womething like this : https://www.npmjs.com/package/taskkill

opn('http://sindresorhus.com').then(cp => {
  // PID
  console.log(cp.pid);

  // Close the app
  cp.kill();
});

Hi @sindresorhus,
Is this supposed to close the opened window when the node app is closed? If so, it's not working on windows at least. In fact, according to console.log(cp.pid), the PID doesn't even exist but the opened window remains open. Is this a windows bug or am I not understanding how it is supposed to work?

@mattcheah I second that, cp is the current process (the node process), not the one that has been spawn.
Therefore, killing it has no effect on the opened window.

Hello guys, I also am facing issue on this.  I get how to open a program but is there really no way to close it once it's opened?

as long as xdg-open is used I think it is not possible to know the pid of the child :(
https://stackoverflow.com/questions/60517108/how-to-kill-subprocess-of-xdg


Questions on Modelica.Mechanical.Rotational.Components.ElastoBacklash2

Hi,
We have a customer who has asked for some details on the ElastoBacklash2 implementation that I cannot answer. Can you help explain (the odd numbering below is due to additional questions already answered)?

Q1) tau_d
In both ElastoBacklash and ElastoBacklash2, you can see "tau_d = d*w_rel;"
But in the info layer, it says "if phi_rel - phi_rel0 < b/2 then tau_d = 0;"
Can you explain?
Q4) ElastoBacklash equation
--- ElastoBacklash ---
tau = if abs(b) <= bEps then
tau_c + tau_d
else if phi_diff > bMax then
smooth(0, noEvent(if tau_c + tau_d <= 0 then 0 else tau_c + min(tau_c, tau_d)))  <--
else if phi_diff < bMin then
smooth(0, noEvent(if tau_c + tau_d >= 0 then 0 else tau_c + max(tau_c, tau_d)))  <--
else 0;
--- ElastoBacklash2 ---
tau = if abs(b) <= bEps then
tau_c + tau_d
else if phi_diff > bMax then
(if tau_c + tau_d <= 0 then 0 else tau_c + tau_d)  <--
else if phi_diff < bMin then
(if tau_c + tau_d >= 0 then 0 else tau_c + tau_d)
else 0;
Is "tau_c + min(tau_c, tau_d)" and "tau_c + max(tau_c, tau_d)" correct?
Please explain the exact difference between the two equations.
Please explain the reason why they differ.
Q6) Difference between ElastoBacklash and ElastoBacklash2
I understand the difference between the two is "tau_c + min(tau_c, tau_d)" and "tau_c + max(tau_c, tau_d)" (shown as Q4)
Is my understanding correct?

Best regards,
Ulf

1dd9dde5a5dd19b159d7182327f6d22bc1ba309f introduced ElastoBacklash2 for MSL v3.2.2.

Q1 is addressed by #2357. Q4 and Q6 are support questions and may be also raised at Stack Overflow.

Q4: The goal is to guarantee that tau is continuous when entering/leaving the backlash region (for simplicity ignoring smooth(..) below):
When going from the backlash region to phi_diff > bMax we have
tau_c > 0, w_rel > 0, tau_d > 0

if tau_c > tau_d: min(tau_c,tau_d) = tau_d
-> tau = tau_c + tau_d

if tau_c < tau_d: min(tau_c,tau_d) = tau_c
-> tau = tau_c + tau_c -> at phi_diff = bMax, tau = 0 (since tau_c = 0)

When going from phi_diff > bMax into the backlash region we have tau_c > 0, w_rel < 0, tau_d < 0:
-> min(tau_c,tau_d) = tau_d
-> tau = if tau_c + tau_d < 0 then 0 else tau_c + tau_d and therefore tau is continuous and >= 0
This means the limitation of the damping term has only an effect when going from the backlash region to phi_diff > bMax and limits this term by the size of the spring torque.
Similar considerations hold at phi_diff < bMin.
Q6: Yes, your understanding is correct (the difference between the two is that in ElastoBacklash the damping term  is limited when going from the backlash into the elastic region in order that the torque is continuous. In ElastoBacklash2 the damping term is not limited in this case and therefore the torque changes discontinuously when going from the backlash into the elastic region).

Q1: Yes, the code is correct. But I believe the customer confusion comes from the different consideration of protected auxiliary variables tau_c and tau_d. In the comment
https://github.com/modelica/Modelica/blob/9d5bc998bbe08a153fd622622400e744704a4257/Modelica/Mechanics/Rotational.mo#L2676-L2692
and later in the documentation
https://github.com/modelica/Modelica/blob/9d5bc998bbe08a153fd622622400e744704a4257/Modelica/Mechanics/Rotational.mo#L2676-L2692
both tau_c and tau_d are considered the same way (and set to zero in backlash). However this is not reflected by the actual equation
https://github.com/modelica/Modelica/blob/9d5bc998bbe08a153fd622622400e744704a4257/Modelica/Mechanics/Rotational.mo#L2699-L2702


Create a UI for viewing/editing the new ImageFormat component

Blocked on:

https://github.com/rerun-io/rerun/pull/7083

Note this is really only useful if we implement compatible color models such as BGR.


Set up dev environment

Local env was set up (MongoDB: mongosh, DB, collection). Agreed to test script on the test node https://calibration.node.glif.io/archive/lotus/rpc/v0 to fetch a reasonable amount of data. Resulting script will be added here: https://github.com/glifio/filecoin-chart/blob/master/templates/sync-s3-marketdeals.yaml


Reader fn preview

Footnote preview for reader and footnotes model.

Codecov Report

Merging #575 into master will decrease coverage by 0.19%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master     #575     +/-   ##
=========================================
- Coverage   54.37%   54.17%   -0.2%
=========================================
  Files         210      211      +1
  Lines        5151     5170     +19
=========================================
  Hits         2801     2801
- Misses       2350     2369     +19

Impacted Files
Coverage Δ

src/reader/components/ReaderXrefComponent.js
0% <0%> (ø)
:arrow_up:

src/article/TextureArticleAPI.js
80% <0%> (-2.76%)
:arrow_down:

src/article/models/FootnotesModel.js
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8d77bd...bd455c9. Read the comment docs.


fix #227 uploads are not appended when sending in cached files

@jnicklas

Nice catch, and nice PR! Thank you!


Ignore MacOS system files and add .nvmrc

@nanek Some development setup improvement. The Node version was inferred from .travis.yml.

Upstream Prebid.js has this included yesterday :P


Assignment_1

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I made changes to my Assignment #1 according to the comments, I've checked all my commands. They worked properly.
What did you learn from the changes you have made?
Previously, I didn't move from the directories. Now, I added cd-commands.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Yes, I thought. Maybe, there is an approach when I can create all commands in one line.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Challenge now is a complicated instruction to the submitting assignment.
How were these changes tested?
I checked - all works properly.
A reference to a related issue in your repository (if applicable)
N/A
Checklist

[ Y] I can confirm that my changes are working as intended
Yes

Emma, I made changes to my assignment. I added cd-commands and I checked all commands. They work properly. But still I have red marks.


How to add a copy button next to markdown blocks?

Not an issue.
But lets say I wanted to add a copy button next to each code block that copies the text from that particular block, how could I do that?

After some studying on wkwebview, I figured you can pass messages from webview to swiftui using the userContentController like youre already doing


IMP: PacBio Phred Offset is Incorrectly Translated

Improvement Description
PacBio Phred offset is not in range of Phred33
Current Behavior
Currently PacBio sequences will import out of range
Proposed Behavior
Sequences will be imported in range resulting in improved analysis and readability of interactive quality plot
References
https://forum.qiime2.org/t/hifi-16s-analysis/30165/4
https://forum.qiime2.org/t/dada2-denoising-ccs-error-in-learning-error-rates/30188/11

Closed by qiime2/q2-demux#162


[Bug] imprecision in test function is_round_reached()

🐛 Bug Report
This bug does not affect mainnet.  It is a bug in a test function
that may cause false positives or negatives from the tests that use it.
However, there are other more complete test suites that
are being run and passed, so this bug is minor.
The bug is in this function:
    // Checks if at least 2f + 1 nodes have reached the given round.
    pub fn is_round_reached(&self, round: u64) -> bool {
        let quorum_threshold = self.validators.len() / 2 + 1;
        self.validators.values().filter(|v| v.primary.current_round() >= round).count() >= quorum_threshold
    }

There are 12 tests that use this test function permalink here, but this function is not doing what it claims.
I presume validators here are equal (not stake-weighted).
If there are N validators, f should be
(N - 1)/3 (where / means integer division rounding down),
and quorum threshold should. be N - f (not 2f + 1 as mentioned in the comment),
which can be computed from N as 2N/3 + 1 (same meaning of /, integer division).
For example:
For 4 validators, this function will return 3, which is correct.
For 5 validators, this function will return 3, which is incorrect.
When there are 5 validators, the quorum threshold should be 4.
See also the definition of quorum_threshold() in snarkVM
ledger/committee/src/lib.rs
permalink
(note the comment at the permalink still has 2f + 1, but that should be fixed with this PR.
The code does the correct calculation.

I've submitted a pull request to address this issue:
Fix: Correct quorum threshold calculation in is_round_reached() #3384

This PR updates the quorum threshold calculation to ensure proper Byzantine fault tolerance. The new implementation correctly calculates the quorum as N - f where N is the number of validators and f is the maximum number of faulty validators that can be tolerated.
The PR includes:

Updated implementation of is_round_reached()
Corrected comments explaining the Byzantine fault tolerance calculation
Comparison of results between the old and new implementations

Thanks
@bendyarm @d0cd

This bug does not affect mainnet. It is a bug in a test function
that may cause false positives or negatives from the tests that use it.
However, there are other more complete test suites that
are being run and passed, so this bug is minor.
The bug is in this function:

It is a bug in a test function that may cause false positives or negatives from the tests that use it.
However, there are other more complete test suites that are being run and passed, so this bug is minor.

It is a bug in a test function that may cause false positives or negatives from the tests that use it. However, there are other more complete test suites that are being run and passed, so this bug is minor.

Thank you for the feedback. I appreciate the context about the bug's impact and the existence of more comprehensive test suites. As I'm getting familiar with the codebase, I wanted to focus on addressing some smaller issues first. Will try to do more high impact PR's soon.