AADSTS90002: Tenant token not found.

I followed this example step by step but getting following error. Any Idea?
AADSTS90002: Tenant token not found. This may happen if there are no active subscriptions for the tenant. Check with your subscription administrator.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d02de0bf-09d7-a7fc-1b4a-213426e96b2d
Version Independent ID: 36f6c8fe-6bc1-6643-4b66-2c38bcd2e5f0
Content: Authenticate with Azure Active Directory to access blob and queue data from your applications (Preview)
Content Source: articles/storage/common/storage-auth-aad-app.md
Service: storage
GitHub Login: @tamram
Microsoft Alias: tamram

@mangeshparanjape Please help with the document on which this feedback is provided. Thanks.

Thanks Mohit. Please let me know when it’s fixed.
Thanks,
Mangesh
Sent from my iPhone

From: Adam-Smith-MSFT<EMAIL_ADDRESS>Sent: Monday, December 3, 2018 1:27 PM
To: MicrosoftDocs/azure-docs
Cc: mangeshparanjape; Mention
Subject: Re: [MicrosoftDocs/azure-docs] AADSTS90002: Tenant token not found. (#19593)
@mangeshparanjapehttps://github.com/mangeshparanjape This actually seems to be a possible bug on the AAD team. I will assign it to my colleague to follow up and close on this issue. @MohitGargMSFThttps://github.com/MohitGargMSFT
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/azure-docs/issues/19593#issuecomment-443815589, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AG99YyowXwLw9Wy3ndSmJDoy5gL1NaZIks5u1W0PgaJpZM4Y2F4I.

@mangeshparanjape Please confirm if you provided RBAC permission to the Azure AD application (service principal) created as part of Register your application with an Azure AD tenant on Azure Storage Account using the steps mentioned here Assign a role scoped to the storage account in the Azure portal.

Yes, rbac role is assigned as per documentation
Thanks,
Mangesh
Sent from my iPhone

From: Mohit Garg<EMAIL_ADDRESS>Sent: Monday, December 3, 2018 2:55 PM
To: MicrosoftDocs/azure-docs
Cc: mangeshparanjape; Mention
Subject: Re: [MicrosoftDocs/azure-docs] AADSTS90002: Tenant token not found. (#19593)
@mangeshparanjapehttps://github.com/mangeshparanjape Please confirm if you provided RBAC permission to the Azure AD application (service principal) created as part of Register your application with an Azure AD tenanthttps://docs.microsoft.com/en-us/azure/storage/common/storage-auth-aad-app#register-your-application-with-an-azure-ad-tenant on Azure Storage Account using the steps mentioned here Assign a role scoped to the storage account in the Azure portalhttps://docs.microsoft.com/en-us/azure/storage/common/storage-auth-aad-rbac?toc=%2Fazure%2Fstorage%2Fqueues%2Ftoc.json#assign-a-role-scoped-to-the-storage-account-in-the-azure-portal.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/azure-docs/issues/19593#issuecomment-443847596, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AG99Y8oCXnolPutofLBHLTY3k-itSwLeks5u1YGZgaJpZM4Y2F4I.

@mangeshparanjape Based on the error please confirm if you are providing correct value to Tenant (directory) ID in GetUserOAuthToken() menthod implementation mentioned here - Get an OAuth token from Azure AD.

Yes, the tenant id is also correct
Thanks,
Mangesh
Sent from my iPhone

From: Mohit Garg<EMAIL_ADDRESS>Sent: Tuesday, December 4, 2018 6:47 PM
To: MicrosoftDocs/azure-docs
Cc: mangeshparanjape; Mention
Subject: Re: [MicrosoftDocs/azure-docs] AADSTS90002: Tenant token not found. (#19593)
@mangeshparanjapehttps://github.com/mangeshparanjape Based on the error please confirm if you are providing correct value to Tenant (directory) ID in GetUserOAuthToken() menthod implementation mentioned here - Get an OAuth token from Azure ADhttps://docs.microsoft.com/en-us/azure/storage/common/storage-auth-aad-app#get-an-oauth-token-from-azure-ad.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/azure-docs/issues/19593#issuecomment-444303459, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AG99YyffJ3vYdpp7u-28hIg8p5X1asJCks5u1wmbgaJpZM4Y2F4I.

I have used GUID from Azure Active directory properties under "Directory
ID" label.
Is that correct?
On Tue, Dec 4, 2018 at 8:24 PM Hirsch Singhal<EMAIL_ADDRESS>wrote:

You've used "token" in place of a tenant ID (something.onmicrosoft.com or
a GUID). Check your code to ensure you aren't making a request with an
AuthenticationContext("token") or similar.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/19593#issuecomment-444322802,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AG99Y2SZeqMcrGqCyYU3IWIhs-6gZZXwks5u1yBggaJpZM4Y2F4I
.

--
--Mangesh Paranjape

Can you share a snippet of code? This is indicating that a request was made to login.microsoftonline.com/token/oauth2/token instead of login.microsoftonline.com/guid/oauth2/token

From: mangeshparanjape<EMAIL_ADDRESS>Sent: Tuesday, December 4, 2018 6:34:56 PM
To: MicrosoftDocs/azure-docs
Cc: Hirsch Singhal; Comment
Subject: Re: [MicrosoftDocs/azure-docs] AADSTS90002: Tenant token not found. (#19593)
I have used GUID from Azure Active directory properties under "Directory
ID" label.
Is that correct?
On Tue, Dec 4, 2018 at 8:24 PM Hirsch Singhal<EMAIL_ADDRESS>wrote:

You've used "token" in place of a tenant ID (something.onmicrosoft.com or
a GUID). Check your code to ensure you aren't making a request with an
AuthenticationContext("token") or similar.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/19593#issuecomment-444322802,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AG99Y2SZeqMcrGqCyYU3IWIhs-6gZZXwks5u1yBggaJpZM4Y2F4I
.

--
--Mangesh Paranjape
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F19593%23issuecomment-444336504&data=02|01|hirsin%40microsoft.com|ef6329c71aac497f2cb708d65a5a3ec9|72f988bf86f141af91ab2d7cd011db47|1|0|636795740981699564&sdata=Hd%2BVYF6UlUWZry7g8211MthXENA2gSW%2FKR5rcmaS99U%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABltO-kG-qcMwDyCtcvdZ6mTWy_Ucz22ks5u1zDQgaJpZM4Y2F4I&data=02|01|hirsin%40microsoft.com|ef6329c71aac497f2cb708d65a5a3ec9|72f988bf86f141af91ab2d7cd011db47|1|0|636795740981709569&sdata=oAnxWvEojx0xQBVvwGzyRm3RzvGN8Oo0gHszyk3hNoU%3D&reserved=0.

@mangeshparanjape Please update on above.

public static string GetUserOAuthToken()
{
string ResourceId = "https://storage.azure.com/";
string AuthEndPoint = "https://login.microsoftonline.com/{0}/oauth2/token";
string TenantId = "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx";
string ClientId = "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx";
string ClientRedirectURI = "https://login.microsoftonline.com/common/oauth2/nativeclient";
string accessToken = string.Empty;
        try
        {
            // Construct the authority string from the Azure AD OAuth endpoint and the tenant ID.
            string authority = string.Format(CultureInfo.InvariantCulture, AuthEndPoint, TenantId);
            AuthenticationContext authContext = new AuthenticationContext(authority);

            // Acquire an access token from Azure AD.
            AuthenticationResult result = authContext.AcquireTokenAsync(ResourceId,
                                                                        ClientId,
                                                                        new Uri(ClientRedirectURI),
                                                                        new PlatformParameters(PromptBehavior.Auto)).Result;

            accessToken = result.AccessToken;
        }
        catch (Exception ex)
        {
            Console.WriteLine("Error: " + ex.Message);
            //throw;
        }

        return accessToken;
    }

Thanks @mangeshparanjape .  Can you capture a correlation ID or request ID as well as a timestamp that comes with the error? That will help us check our logs to determine what's occurring on the backend.
@jmprieur - could you take a look at the code above and also verify that it's accurate? I believe it is but would like a library team member to also verify.

I'll also scrub through all the Azure docs to see if there are other code snippets that need to be fixed.

@mangeshparanjape Please confirm if your issue is now resolved.

@cbrooksmsft - FYI

Hi Mangesh,
I don't quite follow your report - "This code is giving Microsoft Sign-in message for login instead of giving token directly. I think, it is missing to specify actual user under which access token will be specified under the hood"
It's expected that the behavior here is to show a prompt to the user asking them to sign in. Are you trying to use SSO or some other silent sign in mechanism so that the user isn't asked to sign in?

@mangeshparanjape Please update on above else we will move ahead and close this thread. Thanks.

@mangeshparanjape We will now proceed to close this thread. Thanks.

@mangeshparanjape @hpsin
The issue is, indeed, in the code of the article: the constructor of AuthenticationContext requires an authority, whereas the code passed an endpoint (the token endpoint).
This is no longer accepted in ADAL.NET 4.x: See https://aka.ms/adalnet4-authority
Having said that the constructor should throw explicitly. I've raised a GitHub issue to improve the experience: ADAL.NET #1455
The following code will work with any version of ADAL.NET
string Instance = "https://login.microsoftonline.com/{0}";
string authority = string.Format(CultureInfo.InvariantCulture, Instance, TenantId);

I'll propose a pull request to fix this article.

@mangeshparanjape @hpsin
The issue is, indeed, in the code of the article: the constructor of AuthenticationContext requires an authority, whereas the code passed an endpoint (the token endpoint).
This is no longer accepted in ADAL.NET 4.x: See https://aka.ms/adalnet4-authority
Having said that the constructor should throw explicitly. I've raised a GitHub issue to improve the experience: ADAL.NET #1455
The following code will work with any version of ADAL.NET
string Instance = "https://login.microsoftonline.com/{0}";
string authority = string.Format(CultureInfo.InvariantCulture, Instance, TenantId);

I'll propose a pull request to fix this article.

Yes changing the way to give the authority instead of endpoint fixed the issue for me. the ADAL document needs to be improved specially for authentication improvements, or else i see lots of code breakage.


there is no image and pointcloud topic published ,after set param  camera: True

I found the solution. In the file walking_simulation.py you need to comment these lines:
self.cpp_gait_ctrller.set_robot_mode(self.__convert_type(1))
      for i in range(200):
         self.run()  # TODO: THIS IS BLOCKING!!
         print(i)
         p.stepSimulation
self.cpp_gait_ctrller.set_robot_mode(self.__convert_type(1))

As far as I understood these commands block the rest part of the script. I don't know the purpose of writing them by the author but the program works almost fine without them.


Errors on nodes

If node panics or returns a dataflow error, the message should be displayed on a dark-red/red background as in the new design:

In case of panics, the message should be read from "Panic" payload of expression update
In case of dataflow errors, the message should be read by attaching special "error" visualization.

For details, see GUI1 implementation.

i'm going to count fixing dataflow error diagnostics in the Code Editor as in scope for this PR, since the required functionality will need to be implemented here anyway.


feat(amet): Mount home on Linux using host UID/GID

So the syncing is officially kooky dukes. Now that my home folder is developed and large, the initial sync operation on container start takes over an hour. Occasionally the container will completely freeze when it has the scheduled sync back to host.
I'd like to find a better solution for this on Mac when I get back to testing local mac deployments, but while I'm still on a remote Linux box, here's my solution. It doesn't matter what we name the user or the primary group in the container. As long as we create that user/group under the active UID/GID numbers being used on the host, there's never an ownership or permission issue. The container will see the files owned by the container user, host will see it owned by the host user, no chmodding or chowning necessary, ever.
So on mac, we mount home to /sync. The entrypoint sees that /sync exists and runs the homesync script how it has been. On Linux, we mount home to /home/$username and don't run the rsync anymore. Boom.

I'm totally cool with this, the sync thing was driving me nuts as well. I feel like, personally, I'm just starting to give up on Docker for Mac being useful for just about anything. With an at-best 2x slow-down on filesystem i/o I feel like we're trying to fix something that just isn't going to work.


feat: update python to 3.11 and add build-arg

Update the default python 3 version to 3.11. Additionally, add a build arg for PYTHON_VERSION and WATCHDOG_VERSION so make it easy for developers to pin the python version that they need for their project.
The docs are updated with instructions about pinning the python version.
Motivation and Context

[ ] I have raised an issue to propose this change (required)
[ ] My issue has received approval from the maintainers or lead with the design/approved label
We were discussing this during a Community Call in the context of AWS lambda and their slow upgrade cycle for python. We realized we also needed to update our templates.

How Has This Been Tested?

This was manually tested and working with the default "echo" function for each template.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I've read the CONTRIBUTION guide
[x] I have signed-off my commits with git commit -s
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Looks really good, could we drop WATCHDOG_VERSION for this version please?

done


feat: SQLBlob API

TODO

Better API for openBlob?
Is the current SQLBlob API ok?

superseded by #26


Static Web App: Bad Credentials error

Does this occur consistently? Yes
Repro steps:

Right click Static Web Apps
Click Create Static Web App

Action: staticWebApps.createStaticWebApp
Error type: 401
Error Message: Bad credentials
Version: 0.12.2
OS: win32
OS Release: 10.0.19045
Product: Visual Studio Code
Product Version: 1.88.1
Language: en

Call Stack
extension.bundle.js:2:1688784extension.bundle.js:2:1688784

Could you provide more details? Are you logged into your GitHub account through VS Code? Maybe try signing out and signing back in since it seems like your credentials may be bad.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


wink door lock can't be controlled

I have a newly installed kwikset zwave lock connected through a wink hub. works fin in HA web interface. android app shows status only. cannot be locked or unlocked. another user has also tested and got the same results

Hello, is this still a problem, if so, can you create a new issue on: https://github.com/payano/homeassist-ng


If I use page.Sections, page.Pages is empty unless I print it

This is a weird one. Seems like a bug to me.
Try it yourself:

Download https://github.com/willfaught/paige, "sections" branch.
Run the exampleSite. The /series/ page is not empty.
Delete this line. Rebuild the exampleSite (you must kill hugo server and re-run it) and refresh the page. The /series/ page will be empty.
Remove mention of .Sections in layouts/partials/paige/subpages.html. Rebuild (re-run) the exampleSite and refresh the page. The /series/ page is not empty.

See https://discourse.gohugo.io/t/if-i-mention-page-sections-in-a-partial-invoked-for-taxonomy-html-page-pages-is-empty-unless-i-print-it/43522.
What version of Hugo are you using (hugo version)?

$ hugo version
hugo v0.111.3+extended darwin/amd64 BuildDate=unknown

Does this issue reproduce with the latest release?
Yes

So, I had a look at it, and while I can reproduce the described behaviour, I suspect that the "it works when I print" is just a symptom of a timing issue.
I tried to follow your template code, and I cannot pinpoint exactly, but I suspect the culprit lives in the subpages.html partial, and possibly in the paginator construct -- remember that for .Paginate, subsequent invocations will return the first result set.

I removed things from the example, and I don't think pagination has a role here.
If you invoke[^1] .Page.Pages before .Page.Sections you get the desired results. If you invoke .Page.Pages after .Page.Sections you do not get the desired results (i.e., it makes no difference).
[^1]: No need to print, just use noop ($noop := .Page.Pages)


DocsArchive-<IP_ADDRESS>Auto archive content

Auto archive content from https://github.com/opstest2/docs-archive-test-source.git

Docs Build status updates of commit cacc67a:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Can i deploy fusionjs app as static js file?

So i would like to deploy fusionjs app on Amazon S3 or Netlify. Is it possible and how? Thanks!

Unfortunately this isn't supported yet since SSR and server side code is such a big part of Fusion.js. I've filed an issue in fusion-cli where this may be implemented, let's track this here: https://github.com/fusionjs/fusion-cli/issues/484


gulp watch task improvements

We made changes to your watch task in the following ways that greatly speed it up:

Introduced a global firstRun flag that gets set to false in the watch task (which depends on all other tasks).
When firstRun is false, we don't run the bower task. This is better then the flag to simply turn off bower since you get to run it once during a watch. We also don't clean the dist directory when it is false.

We split up the watch task to watch different components of the app and update them individually. Here is the not-so-elegant code to do this:

gulp.task 'watch', ['build'], ->
    isFirstRun = false # don't cleanup the dist directory

    extensions = []
    .concat EXTENSIONS.VIEWS.COMPILED
    .concat EXTENSIONS.VIEWS.UNCOMPILED

    sources = [].concat ("**/*#{extension}" for extension in extensions)

    gulp
    .watch sources, {cwd: SRC_DIRECTORY, maxListeners: 999}, ['views']
    .on 'error', onError

    extensions = []
    .concat EXTENSIONS.SCRIPTS.COMPILED
    .concat EXTENSIONS.SCRIPTS.UNCOMPILED

    sources = [].concat ("**/*#{extension}" for extension in extensions)

    gulp
    .watch sources, {cwd: SRC_DIRECTORY, maxListeners: 999}, ['scripts']
    .on 'error', onError

    extensions = []
    .concat EXTENSIONS.STYLES.COMPILED
    .concat EXTENSIONS.STYLES.UNCOMPILED

    sources = [].concat ("**/*#{extension}" for extension in extensions)

    gulp
      .watch sources, {cwd: SRC_DIRECTORY, maxListeners: 999}, ['styles']
      .on 'error', onError

    gulp
      .watch 'index.html', {cwd: SRC_DIRECTORY, maxListeners: 999}, ['spa']
      .on 'error', onError

Unrelated to the above suggestion (or maybe related, because of the modifications we made)
I have an issue where the watch task dies intermittently during a clean like this:
[15:29:57] Starting 'clean:working'...

events.js:72
        throw er; // Unhandled 'error' event
              ^
Error: ENOENT, lstat '/Users/misha/Work/main-app/app/bower_components/_/vendor/angular-strap/scripts/dimensions.js'

Ive tried wrapping things in try catch statements but maybe I did it wrong? Either way, a clean shouldnt be to upset if it cant find a file to delete :)

As a part of #32, I am introducing this flag. I can include not going to bower as well.

Also, I think that it's a great idea to not spend time processing file types that are not being used. What if we include this as part of the configuration in config.coffee?

yep
On Mon, Mar 9, 2015 at 4:38 PM, Nachiket Mehta<EMAIL_ADDRESS>wrote:

Also, I think that it's a great idea to not spend time processing file types that are not being used. What if we include this as part of the configuration in config.coffee?
Reply to this email directly or view it on GitHub:
https://github.com/CaryLandholt/fatarrow/issues/23#issuecomment-77948800

@mkoryak sorry about the delay but your suggestions about running bower only the first time and the ability to only compile languages you use is in. Please let me know if you have any issues.


Support registering open generics

The Cake Frosting container registration does not support open generics. It throws an exception because the call to IsAssignableFrom fails on line 22 of RegistrationBuilder.
Open generic example:
services.RegisterType(typeof(Logger<>)).As(typeof(ILogger<>)).Singleton();
I have a simple work around at the moment where I just register everything explicitly as there is not that many registrations to do.
There are several examples online of code which claims to create an IsAssignableFrom that supports open generics. Would you accept a pull request that adds support for this?

Sure we would review such a PR.

@asalvo was this something that you were interested in contributing?


Fixes bugs in three tests listed in issue 41974

Re: #41974

Just as a heads up, your commits don't seem to be associated with your GitHub account. While this isn't technically a problem, you might care if you want more appropriate attribution. You can either make sure your GitHub account is associated with the email address that you're using for your commits, or rebase and amend your commits to fix the author name and email.


nodejs: 14.17.6 -> 14.18.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for nodejs is: "Event-driven I/O framework for the V8 JavaScript engine"
meta.homepage for nodejs is: "https://nodejs.org"
meta.changelog for nodejs is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

/nix/store/s1cc19ypzs09mnhzlyrvl6ml44nkx7yy-nodejs-14.18.0/bin/node passed the binary check.

/nix/store/s1cc19ypzs09mnhzlyrvl6ml44nkx7yy-nodejs-14.18.0/bin/npm passed the binary check.

/nix/store/s1cc19ypzs09mnhzlyrvl6ml44nkx7yy-nodejs-14.18.0/bin/npx passed the binary check.

3 of 3 passed binary check by having a zero exit code.

3 of 3 passed binary check by having the new version present in output.

found 14.18.0 with grep in /nix/store/s1cc19ypzs09mnhzlyrvl6ml44nkx7yy-nodejs-14.18.0

found 14.18.0 in filename of file in /nix/store/s1cc19ypzs09mnhzlyrvl6ml44nkx7yy-nodejs-14.18.0

directory tree listing: https://gist.github.com/1d4bdaad82369bb5596fb85d21bd13b5

du listing: https://gist.github.com/04ce1a10542811df6a3353e7a56e9ec6

Rebuild report (if merged into master) (click to expand)

2423 total rebuild path(s)

767 package rebuild(s)

767 x86_64-linux rebuild(s)
681 i686-linux rebuild(s)
324 x86_64-darwin rebuild(s)
651 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
adoptopenjdk-icedtea-web
airfield
amarok
amarok-kf5
angelfish
anki
ankisyncd
antora
apache-airflow
balanceofsatoshis
bat-extras.prettybat
bitwarden-cli
bs-platform
calamares
calibre
calligra
castnow
chromium
cjdns
cjdns-tools
clipgrab
code-server
commitizen
commitlint
cq-editor
create-cycle-app
cryptpad
csound-qt
csslint
cutter
deltachat-desktop
digikam
discourse
discourseAllPlugins
eagle
element-desktop
element-desktop-wayland
elmPackages.create-elm-app
elmPackages.elm
elmPackages.elm-analyse
elmPackages.elm-coverage
elmPackages.elm-doc-preview
elmPackages.elm-language-server
elmPackages.elm-live
elmPackages.elm-optimize-level-2
elmPackages.elm-review
elmPackages.elm-test
elmPackages.elm-upgrade
elmPackages.elm-verify-examples
elmPackages.elm-xref

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/s1cc19ypzs09mnhzlyrvl6ml44nkx7yy-nodejs-14.18.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A nodejs https://github.com/r-ryantm/nixpkgs/archive/f5a81c9e61902733bfcdbefbd8c9973cdfc44871.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/s1cc19ypzs09mnhzlyrvl6ml44nkx7yy-nodejs-14.18.0
ls -la /nix/store/s1cc19ypzs09mnhzlyrvl6ml44nkx7yy-nodejs-14.18.0/bin

Pre-merge build results
NixPkgs review skipped

Maintainer pings
cc @cillianderoiste @gilligan @cko @marsam for testing.

@GrahamcOfBorg eval

A lot of plasma rebuilds 🤔 Maybe staging wasn't so wrong, I am not sure tbh.


Android CI: regression on test_chroot::test_preference_of_userspec

Seems that happened after merging #3908 on Android CI

---- test_chroot::test_preference_of_userspec stdout ----
current_directory_resolved:
run: whoami
result.stdout = u0_a67

result.stderr =
current_directory_resolved:
run: id -g -n
result.stdout = u0_a67

result.stderr =
current_directory_resolved:
mkdir: /data/data/com.termux/files/usr/tmp/.tmpI6xNwk/a
run: /data/data/com.termux/files/home/coreutils/target/debug/coreutils chroot a --user fake -G ABC,DEF --userspec=u0_a67:u0_a67
thread 'test_chroot::test_preference_of_userspec' panicked at 'Program must be run first', tests/common/util.rs:152:19
zzz

Interesting, it's indeed this line that fails:
result.code_is(125);

which I added in that PR. But the it should definitely have run the program by that point. So I dug around and found this in the standard library on ExitStatus::code:

On Unix, this will return None if the process was terminated by a signal.

This suggests that the command was terminated by a signal and hence doesn't have an ExitCode, so I think this uncovered an issue rather than created one. We need to make sure that the command is not terminated prematurely.

Oh, this is expected on Android because of the seccomp filter, which will send a SIGSYS to any process that makes a chroot syscall, terminating it unless explicitly handled. See the "Seccomp restrictions" check box in this relevant comment. The correct solution here would probably be to skip that particular check on Android, or skip the test entirely (chroot should theoretically work in an appropriately configured Android development environment, but that's so rare we decided not to explicitly support it, just not intentionally break it).

Was disabled in #4005, I think this can be closed now.


An SPI addition to vertx to allow it to authorise senders sending to a receiver

Wishlist item

can you give example ?

I may suggest removing this I think we have moved on from when we were thinking about this and don't need it.


Added default-photo feature for CoreTeam section, both for male and female.

You have set alt instead of src.


Hide build from command palette option

This commit hides build command from command palette option.
ONE-vscode-DCO-1.0-Signed-off-by: yunjay-hong<EMAIL_ADDRESS>
For #839
After this PR, following commands are left in command palette.

@Samsung/one-vscode_committers could you please merge this PR? :smile:


3D group forward convolution solver

Enable the 3d group forward convolution support in miopen using the composable kernel.

Ping @JehandadKhan  before merging PR

@amberhassaan  and @iq136boy  Please address @atamazov review comments so we can merge this.

Plan to merge 08/11, ping @atamazov  @JehandadKhan

@junliume

Plan to merge 08/11, ping @atamazov @JehandadKhan

I am not going to block the merge (no correctness problems), but please be informed that actual performance of this solver may be worse than expected due to https://github.com/ROCmSoftwarePlatform/MIOpen/pull/2286#discussion_r1286007620.

@averinevg  Will update this PR to reflect the new problem description changes.

@atamazov thanks for the reviews! :)
@iq136boy please create a post-merge issue and deal with the latest review opinions in the next PR. Thanks!

@junliume @atamazov Based on the discussion with Jehandad, Amber will take over the following refactoring work for this PR.

@iq136boy

Based on the discussion with Jehandad, Amber will take over the following refactoring work for this PR.

Thanks for informing. Can you please clarify who will create a post merge issue?
/CC @amberhassaan @junliume @JehandadKhan

@iq136boy

Based on the discussion with Jehandad, Amber will take over the following refactoring work for this PR.

Thanks for informing. Can you please clarify who will create a post merge issue?
/CC @amberhassaan @junliume @JehandadKhan

@amberhassaan could you take on the post merge issue? recommendation:

First create a new issue referring to the review comments which are not resolved here. Label the urgency level.
Create a PR fixing the issue.

@junliume : acknowledging. Will create the issue and follow up PR.


Feature branch

Feature branch modificatons

Added form section in index.html file
Added styles to the form section in style.css
Added form section footer images to the images folder

@frank1738 Hello. I haven't understood the change required. I don't know the correct way to install and run the project locally

@frank1738 Hello. I haven't understood the change required. I don't know the correct way to install and run the project locally

[ ] You included steps on how to run a ruby on rails project yet this project does not include ruby on rails


Diona chirping & Nymph vocals

About the PR

(I accidentally deleted the other PR, sorry)
Diona and diona nymphs can chirp as a vocal emote.
Nymphs can scream and laugh like adult diona. They also have a speechSound now.
Why / Balance

Moth people can make mothroach sounds (chittering, squeaking), and arachnids can click and chitter like tarantulas. It would make sense for diona, who currently have no unique vocal emotes, to chirp like nymphs.
Sapient nymphs can talk so they should also be able to scream, laugh, etc. like their grown counterparts.
Technical details

Added audio path to speech_emote_sounds.yml
Added vocal component to chirping under speech_emotes.yml
Gave allowedEmotes component to diona and nymphs in diona.yml and animals.yml
Added UnisexDiona vocal sounds, and added the Alto speechSound, for nymphs in animals.yml
Media

https://github.com/user-attachments/assets/25535712-a560-4c63-bbe0-165c3862e4d6
https://github.com/user-attachments/assets/d4fce92b-f715-4795-b4b7-568d137155dc
Requirements

[X] I have read and am following the Pull Request and Changelog Guidelines.
[X] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

:cl: Pinkbat5

add: Diona and nymphs can now chirp.
add: Nymphs can scream and laugh like adult diona.

Looks good


[stable/fluend] add security context

What this PR does / why we need it:
It allows to set a securityContext witch is very usefull when PodSecurityPolicy is enabled
Which issue this PR fixes
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[X] DCO signed
[X] Chart Version bumped
[X] Variables are documented in the README.md
[X] title of the PR contains starts with chart name e.g. [stable/chart]

/assign rendhalver

/assign @Miouge1

/ok-to-test


allow TS Beta 4 without warn

Summary
I just tried and it works for me, but don't know if this is safe

Test plan

Does this PR introduce a breaking change?

[ ] Yes
[ ] No
[x] I don't know

Other information
https://devblogs.microsoft.com/typescript/announcing-typescript-4-0-beta/

hi, we only support final release, we don't take into account of pre-release versions.

OK, I understand, for now I edited in my node_modules, and can use my fork as reference, just using myusername/ts-jest didn't work.

#1821 offers a way to disable this warning message which will be available in the next version of ts-jest, potentially 26.2.
I will close this PR as #1821 will do it


[backport] Improve docs of sigmoid_cross_entropy

Backport of #3562

LGTM! The Travis failure should be fixed in the latest v3 branch.


feat(parser): add support for Lambda Function URL

Issue number: #1425
Summary
Changes
added envelope and model for lambda function url as described at https://github.com/awslabs/aws-lambda-powertools-python/issues/1425
fixed a bug in api gwv2 model where cognitoIdentity wasnt optional.
I was unable to fix the docs for the parser due to a linter bug, will open an issue.
User experience
Can now use an envelope for lambda function url or extend the model.

Is this a breaking change? No.
RFC issue number:
#1425
Checklist:

Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@heitorlessa  i wasnt able to push the docs update.
They pass the docs-linter stage but fail on the pre-commit on this error:
docs/utilities/parser.md:586 MD043/required-headings/required-headers Required heading structure [Context: "## Getting started"]

Hi @ran-isenberg.. I'm refactoring all examples and for now you can add this comment after the description line..

like this: https://github.com/awslabs/aws-lambda-powertools-python/commit/7be425e05f2c193a20c1558de867dc39b81cabb3#diff-aa083264efcaf3125cc0560e9b88cce2c69e4becd8ea39211057634ec3f56bd9R6

Thanks a lot @ran-isenberg !! As @leandrodamascena shared, this is the new doc linting to enforce a consistent style, you can ignore for now with that string at the top of the file since we're refactoring all of it (structure, snippets to be way more realistic, run as-is).
@leandrodamascena could you please fix that mypy issue by installing snappy as a dev dependency and ignoring the lack of types for snappy? We missed in the last PR as I accidentally didn't allow GH Actions to run (part of the new repo hardening)

Hi @ran-isenberg.. I'm refactoring all examples and for now you can add this comment after the description line..
<!-- markdownlint-disable MD043 -->
like this: 7be425e#diff-aa083264efcaf3125cc0560e9b88cce2c69e4becd8ea39211057634ec3f56bd9R6

Tried it but it doesnt work for me, cant commit. I added this linter to my own project and just removed this annoying check from the config :)

pushed the docs ;)

@heitorlessa  it failed on the snappy stuff. I updated from develop branch, hopefully it will work now

Yes it was fixed on #1446, my other PR was impacted and working after the
merge
On Fri, 12 Aug 2022 at 08:20, Ran Isenberg @.***> wrote:

@heitorlessa https://github.com/heitorlessa it failed on the snappy
stuff. I updated from develop branch, hopefully it will work now
—
Reply to this email directly, view it on GitHub
https://github.com/awslabs/aws-lambda-powertools-python/pull/1442#issuecomment-1212768337,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAZPQBGY3STSYALQBFFT4I3VYXUKFANCNFSM56IX7WWQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Codecov Report

Merging #1442 (ddf1dd1) into develop (0e20ee0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #1442   +/-   ##
========================================
  Coverage    99.89%   99.89%
========================================
  Files          121      123    +2
  Lines         5479     5496   +17
  Branches       627      629    +2
========================================
+ Hits          5473     5490   +17
  Misses           2        2
  Partials         4        4

Impacted Files
Coverage Δ

..._powertools/utilities/parser/envelopes/__init__.py
100.00% <100.00%> (ø)

.../utilities/parser/envelopes/lambda_function_url.py
100.00% <100.00%> (ø)

...bda_powertools/utilities/parser/models/__init__.py
100.00% <100.00%> (ø)

...mbda_powertools/utilities/parser/models/apigwv2.py
100.00% <100.00%> (ø)

...ols/utilities/parser/models/lambda_function_url.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rubenfonseca assigned it to you as you fixed the quirks of Function URL.
@ran-isenberg CI passed. Ruben is back on Monday from holidays and should get this reviewed and merged next week.
Thank you again

Just rebased with master before the review

Hi @ran-isenberg thank you for this! Just left two small suggestions. Let me know if it makes sense so we can merge.

Hi!! Just in case of better understanding of the project I did a double check and everything seems fine to merge. I ran these changes locally and it went fine.

@heitorlessa  waiting for the merge :)

@rubenfonseca will be merging ;) Thanks a lot everyone!!

Thanks again Ran! Can't wait to get this out soon :)


Add release tags

Please maintain consistent releases by also adding Git tags and pushing them to this repository.
Please consider using semantic versioning for release tags.
$ git checkout {some-release-commit}
$ git tag -a "v.0.1.0" -m "Short summary of the release."
$ git push -tags origin master

Done.

:+1:


Sign an Assembly with a Strong Name

Sign an Assembly with a Strong Name

pls..........sign...... thanks very much

[assembly: InternalsVisibleTo("ClearScriptV8-32")]
[assembly: InternalsVisibleTo("ClearScriptV8-64")]
[assembly: InternalsVisibleTo("ClearScriptTest")]

Hello @AtlantisDe,
The assemblies in the official NuGet package have strong names. If you're building ClearScript yourself, Section IV of this document outlines the procedure for enabling strong-named assemblies.
Good luck!

hello @ClearScriptLib
i am sure...the official Nuget package ...not have  strong names


Add translation wrapping nomenclature to READ.ME

{{ $t('Text') }}
What else is involved? Possible to automate in our tests or check that there are no missing translations?

Consider also documenting where to make content changes between frontend and app for newcomers?
https://github.com/cds-snc/resources-ressources/issues/108

Link to documentation: https://github.com/cds-snc/resources-ressources#how-to-do-translation-within-the-app
Also some documentation on the frontend folder: https://github.com/cds-snc/resources-ressources#what-is-the-frontend-folder


add loggamma float64

Bunch of things to still settle here but need this function for a couple routines and to avoid overflow.
Here's a plots of relative errors so far.

So there's a problem area right now that I need to work out. Here's a closer view

This algorithm uses recurrence to go between [2,3]. For args below 2 this leads to a bad subraction.. Essentially loggamma(1.9) = loggamma(2.9) - log(1.9) which get's pretty similar.
julia> loggamma(2.9)
0.6028696102493114

julia> log(1.9)
0.6418538861723947

Searching for a better way to handle that area. I'm also trying to improve that rational function. Remez giving me a little trouble but hoping to improve that approximation a little bit more.

Ok - I think I went with a Taylor expansion around x = 1 and then the issue at x = 2 can be handled stably using the expansion at x = 1. This brings the error down everywhere. There might be a better approach but I plan to do a minimax on that small interval (0.8<x<1.2) to improve those results further. Hopefully also decrease the number of terms. (and need to improve branches and conditions)


Generated campaign ID throws error on campaign submission

@jeroenooms - I'm trying to create a new campaign but I can't submit to server because of the generated campaignID.

duplicates #38


Pregel example type fix

Pregel example to express single source shortest path from https://spark.apache.org/docs/latest/graphx-programming-guide.html#pregel-api does not work due to incorrect type. The reason is that GraphGenerators.logNormalGraph returns the graph with Long vertices. Fixing val graph: Graph[Int, Double] to val graph: Graph[Long, Double].

Merged build triggered.

Merged build started.

LGTM

Test build #38541 has started for   PR 7695 at commit c269429.

Test build #38541 has finished for   PR 7695 at commit c269429.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

LGTM as well. Merging into master and branch-1.4. Thanks @avulanov !


read directory failing with 401 error

Hi, this is replicable whether I use llfuse or fuse3.  I have also tried renewing credentials.  I'm afraid I'm out of ideas.  Would be fantastic if this worked again, I rely on it quite heavily.
% rmfuse --version
0.2.3
% rmfuse -vv ~/lib/remarkable
DEBUG:pyfuse3:Initializing pyfuse3
DEBUG:pyfuse3:Calling fuse_session_new
FUSE library version: 3.10.5
DEBUG:pyfuse3:Calling fuse_session_mount
INFO:rmfuse.fuse:Mounting on /home/martinc/lib/remarkable
DEBUG:pyfuse3:pyfuse-02: No tasks waiting, starting another worker (now 2 total).
unique: 2, opcode: INIT (26), nodeid: 0, insize: 56, pid: 0
INIT: 7.35
flags=0x33fffffb
max_readahead=0x00020000
   INIT: 7.31
   flags=0x0040b039
   max_readahead=0x00020000
   max_write=0x00100000
   max_background=0
   congestion_threshold=0
   time_gran=1
   unique: 2, success, outsize: 80
unique: 4, opcode: GETATTR (3), nodeid: 1, insize: 56, pid: 55332
DEBUG:rmcl.api:Got 401 code; trying to renew token
DEBUG:rmcl.api:Renewing user token
ERROR:rmcl.api:Failed to decode JSON from bytearray(b'')
ERROR:rmcl.api:Response code: 401
DEBUG:pyfuse3:Calling fuse_session_unmount
DEBUG:pyfuse3:Calling fuse_session_destroy

Same here (same version of rmfuse):
% rmfuse -vv ~/remarkable
DEBUG:pyfuse3:Initializing pyfuse3
DEBUG:pyfuse3:Calling fuse_session_new
FUSE library version: 3.9.0
DEBUG:pyfuse3:Calling fuse_session_mount
INFO:rmfuse.fuse:Mounting on /home/ct/remarkable
DEBUG:pyfuse3:pyfuse-02: No tasks waiting, starting another worker (now 2 total).
unique: 2, opcode: INIT (26), nodeid: 0, insize: 56, pid: 0
INIT: 7.31
flags=0x03fffffb
max_readahead=0x00020000
   INIT: 7.31
   flags=0x0040b039
   max_readahead=0x00020000
   max_write=0x00100000
   max_background=0
   congestion_threshold=0
   time_gran=1
   unique: 2, success, outsize: 80
unique: 4, opcode: GETATTR (3), nodeid: 1, insize: 56, pid: 4844
DEBUG:pyfuse3:pyfuse-03: No tasks waiting, starting another worker (now 3 total).
unique: 6, opcode: GETATTR (3), nodeid: 1, insize: 56, pid: 4441
DEBUG:pyfuse3:pyfuse-04: No tasks waiting, starting another worker (now 4 total).
unique: 8, opcode: GETATTR (3), nodeid: 1, insize: 56, pid: 9067
DEBUG:pyfuse3:pyfuse-05: No tasks waiting, starting another worker (now 5 total).
unique: 10, opcode: GETATTR (3), nodeid: 1, insize: 56, pid: 9068
DEBUG:rmcl.api:Got 401 code; trying to renew token
DEBUG:rmcl.api:Renewing user token
ERROR:rmcl.api:Failed to decode JSON from bytearray(b'')
ERROR:rmcl.api:Response code: 401
DEBUG:pyfuse3:Calling fuse_session_unmount
DEBUG:pyfuse3:Calling fuse_session_destroy

Same I guess the API has been broken and this project isn't actively maintained :(


refactor!: upgrade modules to v0.50.7

What does this PR do?

[x] Upgrade app to v0.50.7
[ ] Upgrade x/claim

[x] Use autocli
[ ] Add depinject support
[ ] Add param migration

[ ] Upgrade x/mint

[x] Use autocli
[ ] Add depinject support
[ ] Add param migration

Wire new modules in app

How to test?

Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[ ] Include tests
[ ] Respect code style and lint
[ ] Update documentation (*.md) (if needed)

After checking what the modules did while upgrading them. Those modules do not align with the future of SPN.
I have checked on sourcegraph and no one imports those modules expect from SPN.
We can safely shut down /modules.
If we want to have eventually Ignite develop in house modules (which we want), we should do it in standalone repos per modules as well.


Can't overwrite keymap possibly due to loading order

In my which-key configuration which-key.lua I want to hide vg%
local wk = require("which-key")
wk.register({
  ["vg%"] = "which_key_ignore",
})

But it doesn't works. It is still there.

My g% is mapped by matchup, and I find it is loaded at the last when vim starts. Here is the configuration loading order returned by :scriptnames

I think this is the root cause: matchup is loaded at last and overwrite my configuration with the help of keymap detecting of which-key.
How to make my customized configuration about which-key loaded after all plugins? Is there any workroud? Thanks a lot!!
Environment: neovim 0.8.0 with Vim plug as plugin management.

You need to change g% for mode v instead. vg% is not an actual mapping

@folke
No. It doesn't work.
local wk = require("which-key")
wk.register({
  ["g%"] = {"which_key_ignore", mode = {"n", "v"}},
})

Nothing changes. Even if I change the label it is still the same.


12712 GMaps in builder

Fixes #12712

retest this, please

retest this, please

please retest this

retest this, please

retest this, please

retest this, please

🔴 in acceptance. This fails when the mapcap has to be created. Basically, the mapcap is created before applying the layer fix, so the mapcap is incorrect and causes problems. Mapcapping should be done after fixing the layers.

retest this, please

cc @ernesmb to be notified on merge


collect specific region

in the config file, is anyway we can run only specific region instead of list all region?
also we have received this error, any suggestion? missing describe from the policy?
An error occurred (AccessDeniedException) when calling the GetStages operation: User: arn:aws:iam::111111111:user/111111 is not authorized to perform: apigateway:GET on resource: arn:aws:apigateway:us-east-1::/restapis/d7316bv5ug/stages

There is not currently a way to collect data only for a specific region.  It would speed up the collection, but I think a common use case is just to start the collection and come back to later, since even for a single region it would take at least a minute to collect everything in it.
As for the error, there are some additional privileges I need to add to the instructions, or just stop collecting that info.  The data collected there is only used by the api_endpoints command, so it can likely be ignored for most use cases.

thanks for quick response --
we tried to prepare got zero built, any suggestion?
run:-
python cloudmapper.py prepare --account
then we got this:-
Building data for account <account_name> (123456789)

0 external CIDRs built
0 connections built

Check the "./account-data/" directory has files in it for that account name to ensure the collect command worked correctly and that the account names match between what was used for collect and what was used for prepare.

@0xdabbad00 thank you!

I'm closing this as I assume this solved your problem, and as for the concept of specifying a region for collection, I think it will just cause things to break right now if it were attempted, so I'm of the opinion that it's out of scope for work that would have enough benefit to be worth the effort.


Get parameter service

Is there an existing issue for this?

[X] I have searched the existing issues

I'm having the following issue:
Hello,
In HASS services the "get parameter" does not show up.
I  am using latest version of HASS
I have following devices connected:

[ ] ecoMAX 3xx series
[ ] ecoMAX 8xx series
[X] ecoMAX 9xx series
[ ] Expansion module B
[ ] Expansion module C
[ ] ecoSTER 200/ecoSTER Touch
[ ] ecoLAMBDA
[ ] ecoNET 300

I'm connecting to my devices using:
USB to RS-485 adapter
I'm seeing following log messages:
No response
My diagnostics data:
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi,
Since you didn't provide diagnostics, I must ask you just in case, did you update this integration to v0.3.11 and restarted HASS?

It worked after reboot. Restarting HASS din not provide the new services.
Thank You !
În sâm., 7 oct. 2023 la 11:31, Denis Paavilainen @.***>
a scris:

Hi,
Since you didn't provide diagnostics, I must ask you just in case, did you
update this integration to v0.3.11 and restarted HASS?
—
Reply to this email directly, view it on GitHub
https://github.com/denpamusic/homeassistant-plum-ecomax/issues/36#issuecomment-1751650650,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOJTIPQUFFLU3CL27KWHXE3X6EHONAVCNFSM6AAAAAA5WWMT2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJRGY2TANRVGA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Thanks for the heads up! That's strange... HASS restart should've really been enough, but I'm glad that a least you've got it working in the end.


IDS Apps (UC aware)

Should there be a chapter on topics that are being worked on or will be addressed soon, such as UC Aware Apps?

Closed by #193


PostgreSQL Collector does not send schema changes in scheduled run

If we get some schema changes in the source PostgreSQL database while the collector already works - we do not get updated information in the platform - but the timestamp of the ingest is new.
The restart of the collector catches up the changes.

Closed with #71


Add waitForTx for MicroBitLog

DO NOT MERGE
See https://github.com/lancaster-university/codal-microbit-v2/issues/167

This is an alternative proposal for:

https://github.com/lancaster-university/codal-nrf52/pull/41

For issue:

https://github.com/lancaster-university/codal-microbit-v2/issues/167#issuecomment-1052708890

@JohnVidler both options have advantages/disadvantages, but this is something we'll still need to prioritise in the future.


Need a "jump-to-mob" command

Description

/jumptomob "Entity name"
Tpto only takes entityid and that smelly, need an ui for too
Reproduction

Screenshots

Additional context

You could make this, but I don't see it being useful as multiple entities have the same name?
If you want to teleport to a player, there is a command for that if that's what you were getting at


Rendering enum of templates

Let's say I have the following pattern:
#[derive(TemplateOnce)]
#[template(path = "index.stpl")]
struct Index {
    page: Page,
}

enum Page {
    Index(PageHome),
    Stream(PageStream),
}

#[derive(TemplateOnce)]
#[template(path = "pages/home.stpl")]
struct PageHome {
    ...
}

#[derive(TemplateOnce)]
#[template(path = "pages/stream.stpl")]
struct PageStream {
    ...
}

What can I write in the template such that I am able to render page? As far as I can tell, I can't implement TemplateOnce for Page since it has a sealed supertrait, and I can't implement Render for it since in order to render the child I would have to consume its value. I additionally can't change page to be dyn TemplateOnce since TemplateOnce is Sized.
What's the best way to dispatch to different templates?

I think this can be done with a macro, if you still need this I'm open to try to create one @rhelmot


doc(headless commerce): fix commerce searchbox documentation generation

https://coveord.atlassian.net/browse/KIT-3371
Apparently the doc parser does not deal well with utility types such as Pick and Omit.
Commerce search box in parsed_doc.json before fix:
      {
        "initializer": {
          "kind": "function",
          "name": "buildSearchBox",
          "params": [
            {
              "kind": "primitive",
              "name": "engine",
              "isOptional": false,
              "desc": "The commerce headless engine.",
              "type": "CommerceEngine"
            },
            {
              "kind": "object",
              "name": "props",
              "isOptional": false,
              "desc": "The configurable `SearchBox` properties.",
              "type": "SearchBoxProps",
              "members": [
                {
                  "kind": "primitive-with-type-alias",
                  "name": "options",
                  "isOptional": true,
                  "type": "Pick<CoreSearchBoxOptions, 'id' | 'highlightOptions' | 'clearFilters'>",
                  "desc": "The `SearchBox` controller options."
                }
              ],
              "isTypeExtracted": false,
              "typeName": "SearchBoxProps"
            }
          ],
          "returnType": {
            "kind": "object",
            "name": "SearchBox",
            "isOptional": false,
            "type": "SearchBox",
            "desc": "The `SearchBox` headless controller offers a high-level interface for designing a common search box UI component with [highlighting for query suggestions](https://docs.coveo.com/en/headless/latest/usage/highlighting/).",
            "members": [],
            "isTypeExtracted": false,
            "typeName": "SearchBox"
          },
          "desc": "Creates a `SearchBox` controller instance."
        },
        "extractedTypes": [],
        "utils": [],
        "codeSampleInfo": {
          "githubInfo": {
            "owner": "coveo",
            "repo": "ui-kit",
            "ref": "v2.71.0"
          },
          "samples": {
            "react": {
              "class": [],
              "fn": []
            }
          }
        }
      },

Commerce search box in parsed_doc.json after fjix:
      {
        "initializer": {
          "kind": "function",
          "name": "buildSearchBox",
          "params": [
            {
              "kind": "primitive",
              "name": "engine",
              "isOptional": false,
              "desc": "The commerce headless engine.",
              "type": "CommerceEngine"
            },
            {
              "kind": "object",
              "name": "props",
              "isOptional": false,
              "desc": "The configurable `SearchBox` properties.",
              "type": "SearchBoxProps",
              "members": [
                {
                  "kind": "object",
                  "name": "options",
                  "isOptional": true,
                  "type": "SearchBoxOptions",
                  "desc": "The `SearchBox` controller options.",
                  "members": [
                    {
                      "kind": "primitive",
                      "name": "clearFilters",
                      "isOptional": true,
                      "type": "boolean",
                      "desc": "Whether to clear all active query filters when the end user submits a new query from the search box. Setting this option to \"false\" is not recommended & can lead to an increasing number of queries returning no results."
                    },
                    {
                      "kind": "object",
                      "name": "highlightOptions",
                      "isOptional": true,
                      "type": "SuggestionHighlightingOptions",
                      "desc": "Specifies delimiters to highlight parts of a query suggestion that e.g match, do not match the query.",
                      "members": [],
                      "isTypeExtracted": true,
                      "typeName": "SuggestionHighlightingOptions"
                    },
                    {
                      "kind": "primitive",
                      "name": "id",
                      "isOptional": true,
                      "type": "string",
                      "desc": "A unique identifier for the controller. By default, a unique random identifier is generated."
                    }
                  ],
                  "isTypeExtracted": false,
                  "typeName": "SearchBoxOptions"
                }
              ],
              "isTypeExtracted": false,
              "typeName": "SearchBoxProps"
            }
          ],
          "returnType": {
            "kind": "object",
            "name": "SearchBox",
            "isOptional": false,
            "type": "SearchBox",
            "desc": "The `SearchBox` headless controller offers a high-level interface for designing a common search box UI component with [highlighting for query suggestions](https://docs.coveo.com/en/headless/latest/usage/highlighting/).",
            "members": [
              {
                "kind": "object",
                "name": "state",
                "isOptional": false,
                "type": "SearchBoxState",
                "desc": "The state of the `SearchBox` controller.",
                "members": [
                  {
                    "kind": "primitive",
                    "name": "isLoading",
                    "isOptional": false,
                    "type": "boolean",
                    "desc": "Determines if a search is in progress."
                  },
                  {
                    "kind": "primitive",
                    "name": "isLoadingSuggestions",
                    "isOptional": false,
                    "type": "boolean",
                    "desc": "Determines if a query suggest request is in progress."
                  },
                  {
                    "kind": "object",
                    "name": "suggestions",
                    "isOptional": false,
                    "type": "Suggestion[]",
                    "desc": "The query suggestions for the search box query.",
                    "members": [],
                    "isTypeExtracted": true,
                    "typeName": "Suggestion"
                  },
                  {
                    "kind": "primitive",
                    "name": "value",
                    "isOptional": false,
                    "type": "string",
                    "desc": "The current query in the search box."
                  }
                ],
                "isTypeExtracted": false,
                "typeName": "SearchBoxState"
              },
              {
                "kind": "function",
                "name": "clear",
                "params": [],
                "returnType": {
                  "kind": "primitive",
                  "name": "returnType",
                  "type": "void",
                  "isOptional": false,
                  "desc": ""
                },
                "desc": "Clears the search box text and the suggestions."
              },
              {
                "kind": "function",
                "name": "selectSuggestion",
                "params": [
                  {
                    "kind": "primitive",
                    "name": "value",
                    "isOptional": false,
                    "desc": "The string value of the suggestion to select",
                    "type": "string"
                  }
                ],
                "returnType": {
                  "kind": "primitive",
                  "name": "returnType",
                  "type": "void",
                  "isOptional": false,
                  "desc": ""
                },
                "desc": "Selects a suggestion and calls `submit`."
              },
              {
                "kind": "function",
                "name": "showSuggestions",
                "params": [],
                "returnType": {
                  "kind": "primitive",
                  "name": "returnType",
                  "type": "void",
                  "isOptional": false,
                  "desc": ""
                },
                "desc": "Shows the suggestions for the current search box value."
              },
              {
                "kind": "function",
                "name": "submit",
                "params": [],
                "returnType": {
                  "kind": "primitive",
                  "name": "returnType",
                  "type": "void",
                  "isOptional": false,
                  "desc": ""
                },
                "desc": "Triggers a commerce search query."
              },
              {
                "kind": "function",
                "name": "updateText",
                "params": [
                  {
                    "kind": "primitive",
                    "name": "value",
                    "isOptional": false,
                    "desc": "The string value to update the search box with.",
                    "type": "string"
                  }
                ],
                "returnType": {
                  "kind": "primitive",
                  "name": "returnType",
                  "type": "void",
                  "isOptional": false,
                  "desc": ""
                },
                "desc": "Updates the search box text value and shows the suggestions for that value."
              }
            ],
            "isTypeExtracted": false,
            "typeName": "SearchBox"
          },
          "desc": "Creates a `SearchBox` controller instance."
        },
        "extractedTypes": [
          {
            "kind": "object",
            "name": "SuggestionHighlightingOptions",
            "isOptional": false,
            "type": "",
            "desc": "",
            "members": [
              {
                "kind": "object",
                "name": "correctionDelimiters",
                "isOptional": true,
                "type": "Delimiters",
                "desc": "Delimiters for substrings that are correction of the input",
                "members": [],
                "isTypeExtracted": true,
                "typeName": "Delimiters"
              },
              {
                "kind": "object",
                "name": "exactMatchDelimiters",
                "isOptional": true,
                "type": "Delimiters",
                "desc": "Delimiters for substrings that are exact match of the input",
                "members": [],
                "isTypeExtracted": true,
                "typeName": "Delimiters"
              },
              {
                "kind": "object",
                "name": "notMatchDelimiters",
                "isOptional": true,
                "type": "Delimiters",
                "desc": "Delimiters for substrings that do not match the input",
                "members": [],
                "isTypeExtracted": true,
                "typeName": "Delimiters"
              }
            ],
            "isTypeExtracted": false,
            "typeName": ""
          },
          {
            "kind": "object",
            "name": "Delimiters",
            "isOptional": false,
            "type": "",
            "desc": "",
            "members": [
              {
                "kind": "primitive",
                "name": "close",
                "isOptional": false,
                "type": "string",
                "desc": "Closing delimiter"
              },
              {
                "kind": "primitive",
                "name": "open",
                "isOptional": false,
                "type": "string",
                "desc": "Opening delimiter"
              }
            ],
            "isTypeExtracted": false,
            "typeName": ""
          },
          {
            "kind": "object",
            "name": "Suggestion",
            "isOptional": false,
            "type": "",
            "desc": "",
            "members": [
              {
                "kind": "primitive",
                "name": "highlightedValue",
                "isOptional": false,
                "type": "string",
                "desc": "The suggestion after applying any `highlightOptions`."
              },
              {
                "kind": "primitive",
                "name": "rawValue",
                "isOptional": false,
                "type": "string",
                "desc": "The suggestion text."
              }
            ],
            "isTypeExtracted": false,
            "typeName": ""
          }
        ],
        "utils": [],
        "codeSampleInfo": {
          "githubInfo": {
            "owner": "coveo",
            "repo": "ui-kit",
            "ref": "v2.71.0"
          },
          "samples": {
            "react": {
              "class": [],
              "fn": []
            }
          }
        }
      },

Should we handle this in the documentation generator instead? We have other types that use Omit that we would need to change as well, if not.

Good point...
The doc parser is a complicated little piece of code, but I'll see what I can do to make it work.

Its really not ideal indeed to have to "rewrite" those types manually. I understand however it's complicated to modify...
But, if I have to choose between "imperfect reference doc on the website" VS "types and interface that drift over time because they are not kept in sync and possibly affect projects", I think incomplete doc is a lesser of 2 evils ;)

I just tried something we could use as a pattern to ensure that interfaces don't drift apart and documentation is accurate and complete.
The idea is to use the satisfies operator to assert that the object returned by the buildSearchBox function matches the Omit<CoreSearchBox, 'submit'> & {submit(): void} interface. This way, if the SearchBox type or the CoreSearchBox types were to change, we'd get an error.
E.g., here I'm adding a newRequiredProperty on the CoreSearchBox interface:

and here I'm adding an extraProperty in the SearchBox interface, and adding it in the return statement:

Thoughts?

Its really not ideal indeed to have to "rewrite" those types manually. I understand however it's complicated to modify...
But, if I have to choose between "imperfect reference doc on the website" VS "types and interface that drift over time because they are not kept in sync and possibly affect projects", I think incomplete doc is a lesser of 2 evils ;)

I just tried something we could use as a pattern to ensure that interfaces don't drift apart and documentation is accurate and complete.
The idea is to use the satisfies operator to assert that the object returned by the buildSearchBox function matches the Omit<CoreSearchBox, 'submit'> & {submit(): void} interface. This way, if the SearchBox type or the CoreSearchBox types were to change, we'd get an error.
E.g., here I'm adding a newRequiredProperty on the CoreSearchBox interface:

and here I'm adding an extraProperty in the SearchBox interface, and adding it in the return statement:

Thoughts?

If the doc gen behave, lgtm
Some additional read on satisfies: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-9.html

I still feel like the satisfies solution solves the problem in the wrong place, but I'm not aware of how complex the doc gen is 🤷. I'd be ok with this solution.

After investigating for a while with our custom reference documentation generation tools, I decided to instead look into TypeDoc.
Initially, we wanted to use that tool to generate the Headless reference documentation, but back in the days, TypeDoc was unable to properly handle some of the more sophisticated types we had in the project, so we went the custom route.
I did a POC with TypeDoc, however, and @jpmarceau and I agree that it's a much better solution than what we have right now. It extracts everything we need, and offers lots of flexibility for organizing the documentation through tags in the comments. It also has theming, so we can integrate the output in the docs site.
@jpmarceau do you think I should close this Jira, or should we merge so that we at least have reference docs for the controller until we move on to TypeDoc?

I think I would close this, given that Typedoc is coming.
We can live without reference documentation for that component for a few weeks.
And if there's demand for something quick, I could always write the page manually 👍

As @jpmarceau said:

I think I would close this, given that Typedoc is coming.
We can live without reference documentation for that component for a few weeks.
And if there's demand for something quick, I could always write the page manually 👍

Closing this PR.


*) mod_ssl: when a proxy connection had handled a request using SSL…

…, an
 error was logged when "SSLProxyEngine" was only configured in the
 location/proxy section and not the overall server. The connection
 continued to work, the error log was in error. Fixed PR66190.

Merged in c2e15a4


add-security-contact-for-apache-httpcomponents-client-5-api

Description
I would like to propose our help with regards to security maintenance.
Our team at CloudBees will be able to react on security issue reports, by definition time-sensitive. This way we can be notified on the event of a security report to help on the resolution, collaboration with the security team, synchronization, etc.
We have done this already for a number of plugins:
https://github.com/jenkins-infra/repository-permissions-updater/search?q=foundation_security_members&unscoped_q=foundation_security_members
If anybody sees a problem with this, please let me know.
Thank you.
Repo implied: https://github.com/jenkinsci/commons-lang3-api-plugin
CC @timja for approval from an existing maintainer.
CC @daniel-beck as the security officer since this PR is changing security contacts.
Submitter checklist for adding or changing permissions
Always

[ ] Add link to plugin/component Git repository in description above

For a newly hosted plugin only

[ ] Add link to resolved HOSTING issue in description above

For a new permissions file only

[ ]  Make sure the file is created in permissions/ directory
[ ]  artifactId (pom.xml) is used for name (permissions YAML file).
[ ]  groupId / artifactId (pom.xml) are correctly represented in path (permissions YAML file)
[ ]  Check that the file is named plugin-${artifactId}.yml for plugins

When adding new uploaders (this includes newly created permissions files)

[ ]  Make sure to @mention an existing maintainer to confirm the permissions request, if applicable
[ ]  Use the Jenkins community (LDAP) account name in the YAML file, not the GitHub account name
[ ]  Make sure to @mention the users being added so their GitHub account names are known if they require GitHub merge access (see below).
[ ]  All newly added users have logged in to Artifactory at least once

Reviewer checklist (not for requesters!)

[ ]  Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
[ ]  Check that the $pluginId Developers team has Admin permissions while granting the access.
[ ]  In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
[ ]  If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.
There are IRC Bot commands for it

@strangelookingnerd you are one of the maintainers.  Are you willing to accept additional help from the Jenkins security team?
@Wadeck as Jenkins security officer, is this proposal OK for you as well?

Repo implied: https://github.com/jenkinsci/commons-lang3-api-plugin
CC @timja for approval from an existing maintainer.
CC @daniel-beck as the security officer since this PR is changing security contacts.

I think the PR text is misleading. If this is actually implying https://github.com/jenkinsci/apache-httpcomponents-client-5-api-plugin I sure am glad to accept help.

@vwagh-dev can you fixup the PR description please

The security contact part is fine with me, but @vwagh-dev are you sure you want to be the only maintainer of that instead of having more members from your team? :)

I'm not a maintainer of this and @daniel-beck is not the security officer
Sorry @timja 😊 I've updated the description.

Repo implied: https://github.com/jenkinsci/commons-lang3-api-plugin
CC @timja for approval from an existing maintainer.
CC @daniel-beck as the security officer since this PR is changing security contacts.

I think the PR text is misleading. If this is actually implying https://github.com/jenkinsci/apache-httpcomponents-client-5-api-plugin I sure am glad to accept help.

Sorry about that. I've corrected the description 😊

@vwagh-dev can you fixup the PR description please

It's done 👍

@strangelookingnerd Could you please reapprove the PR as it got close accidentally.


webrick is not part of the default gems since Ruby 3.0.0

seeing some runtime failure when running with ruby 3.3
  webrick is not part of the default gems since Ruby 3.0.0. Install webrick from RubyGems.
  <internal:/home/linuxbrew/.linuxbrew/Cellar/ruby/3.3.4/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:136:in `require': cannot load such file -- webrick (LoadError)

Did you install it? If so, did it work?

yeah, I have included webrick gem and seems passing the brew test
relates to https://github.com/Homebrew/homebrew-core/pull/179624


Elyra 2.2.x cannot process Pipelines that were created using 2.3.x

Describe the issue
See below
To Reproduce
Steps to reproduce the behavior:

Install Elyra 2.2.4
Follow the instructions in https://elyra.readthedocs.io/en/latest/user_guide/runtime-conf.html#verifying-runtime-configurations
Open the validate_python pipeline. (The pipeline was created using a later release!)
See validation errors

Screenshots or log output

Note that the same pipeline "passes" 2.3.x validation.
Expected behavior
No validation errors should be displayed
Deployment information
Describe what you've deployed and how:

Elyra version: 2.2.4

looks like the cpu/gpu/memory are strings so would fail the value > 0 check

If we used to persist cpu/gpu/memory as empty strings at some point we should probably bump the pipeline version to 4 and add a migration that purges empty strings and converts any strings that are supposed to be numbers to numbers

Oh misunderstood this is going from the new version to the old version. It looks like the component definition incorrectly sets the default value to an empty string

Yep, several options:

bump pipeline version (least desirable option because we'd have to maintain 2.2.x and 2.3.x example pipelines)
2.3.x sets those properties to something that 2.2.x can handle (change in 2.3 required)
2.2.5+ can handle 2.3 formatted inputs (change in 2.2.4 required)

2.3.x should be backward compatible in this scope.

yea, this should be an easy fix in 2.3 to use a default that is backwards compatible (it is a bug how it is currently handled in 2.3)

This will also need to be fixed in https://github.com/elyra-ai/elyra/pull/1620
FYI @marthacryan @kiersten-stokes

The linked PR replaces the existing (invalid) pipeline with a version that was created using Elyra 2.2.4. This way no user is blocked until the issue has been fixed in 2.3.0 and a new release was published.

We should add a test case that creates a pipeline, which includes inputs/outputs/env_vars and other node properties and validate against a valid pipeline


[FLINK-3173] Bump httpclient and httpcore to version 4.2.6 to solve bug in http client

The bug prevents the TwitterStream example from working.

Merging this...


hybrid algorithm

As discussed in today's meeting, a simple starter issue for getting more understanding of how polonius works is to create a "hybrid" algorithm that first tries the location-insensitive analysis and -- if there are errors -- falls back to datafrog-opt.

In the meeting we said that @matthewjasper would try to write up some mentoring instructions and @albins would try to fix this. =)

Zulip topic for discussing this issue here

To add a new pass first add a new variant to the Algorithm enum here: https://github.com/rust-lang/polonius/blob/ecafafba28e4903b9fe7a7df19b87d97541c3c62/polonius-engine/src/output/mod.rs#L20-L51
also use the new pass in Algorithm::variants and Algorithm::from_str.
Then the new algorithm can be implemented by adding another arm here: https://github.com/rust-lang/polonius/blob/ecafafba28e4903b9fe7a7df19b87d97541c3c62/polonius-engine/src/output/mod.rs#L116-L135
The pass just has to run the location insensitive pass, check if errors is non-empty, and if so run the optimized pass. It may be a good idea to have this in its own module so that it doesn't need to be moved when a more complicated hybrid algorithm is created.
Finally, the pass should be tested by adding a test here that runs that hybrid algorithm and asserts that it gets the same errors (only) as the naive algorithm:
https://github.com/rust-lang/polonius/blob/ecafafba28e4903b9fe7a7df19b87d97541c3c62/src/test.rs#L13-L51


add sqlite type for each column to _transicator_tables

We should propagate the sqlite type that transicator decided to convert the original PG type into, since that info is readily available during db construction time, and will save consumers the burden of inspecting the db for this metadata.  This info is necessary to construct the proper dml for changes.

@f1erro as we discussed -- if it turns out that we don't need this, let's hold off. Let me know if this is  necessary.


feat(ci): add ci in coverage

Pull Request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[x] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Add coverage in the ci

Does this introduce a breaking change?

[ ] Yes
[x] No

Other information

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@6df312d). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff           @@
##             main     #26   +/-   ##
======================================
  Coverage        ?   2.67%
======================================
  Files           ?      17
  Lines           ?     224
  Branches        ?       0
======================================
  Hits            ?       6
  Misses          ?     218
  Partials        ?       0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Script based extensions

Problem Definition
New extensions need to be created as a Java component and require a server startup.
Possible Solution
Introduce a mechanism to create extensions using a script in the runtime.

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


mismatch Version declared in the json (0.1.4) is different than the resolved one (0.1.5)

mismatch Version declared in the json (0.1.4) is different than the resolved one (0.1.5)

bower.json is out of sync with the version number 0.1.5


add detail dataset config feature by extra config file

README: https://github.com/fur0ut0/sd-yascripts/blob/feature/dataset_config/config_README-ja.md
Solve #58 #130
There are several major changes:

add config file feature by --config_file option

please check README for more detail

add subset feature for combining multiple directories into dataset

also enable configuration per subset

support multiple datasets

combine datasets into DatasetGroup and use it as pseudo dataset

add switch feature of inter-dataset shuffle by --bucket_shuffle_across_dataset

I'm wondering if I should make this behavior default

change metadata scheme for supporting multiple datasets and multiple subsets

I have conserved backward compatibility of current DreamBooth directory handling, which uses subdirectory structure for class tokens and the number of dataset repeat.
NOTE: Sorry for a bit messy history. Maybe squash merge would be better option.

Also, there is one big issue that error message about invalid config file is not user friendly enough. I'm considering how to fix this.
It would be nice if you can share some idea.

I agree that the error message is too simple. I'm not familiar to voluptuous, so I have no idea how to improve it. If there is a way to know where is wrong when an error occurs, it will be good...

I agree. I would like to let it show what option name causes an error.

I am wondering that where the shuffling of the buckets is done.
If the bucket indices are not shuffled, the members of each batch are fixed for each epoch. I don't think that is desirable.

BaseDataset.set_current_epoch() invokes bucket shuffling.
The index passed to __getitem__() will be random when we use torch.utils.data.DataLoader to enable inter-dataset shuffling. Thus, I have decided moving bucket shuffling feature from __getitem__() to set_current_epoch().

Caption/tag dropping in Textual Inversion training will cause unexpected results. Because if token string is not included in the caption, no weight will be trained. It will be better to show some warning message if caption/tag dropping options are specified in TI training.

Caption dropout is already disabled for textual Inversion. The arguments of ConfigSanitizer() controls which dataset feature will be enabled.
def __init__(self, support_dreambooth: bool, support_finetuning: bool, support_dropout: bool) -> None:

When we passed support_dropout=False, voluptuous does not parse options about caption dropout (caption_dropout_rate etc.). It will cause an error when an user passes these options.
As a result, the parameters such as caption_dropout_rate passed to BaseSubset will be default values (0.0) in this case.

I think it will be better that the metadata is same to previous if the dataset has only one subset for backward compatibility.

OK, I will preserve backward compatibility of metadata when there is single dataset.

Update:

conserve existing metadata entries when config file is not given
use json.dumps for storing value of new metadata entry ss_datasets
enable shuffle feature of data loader by default

delete --bucket_shuffle_across_dataset option from argparse

Oh, I had missed that too. It looks good! However if caption/tag dropping option is specified in TI training, it will be helpful to warn the user that dropping does not work.

Let me clarify the point.
In textual inversion, current implementation grants dropout options as unknown options, and passing these options via config file causes an error.
Error example: voluptuous.error.MultipleInvalid: extra keys not allowed @ data['general']['caption_dropout_rate']
This behavior is made by mimicking argparse behavior, because argparse also grants dropout options as unknown options.
Error example: train_textual_inversion.py: error: unrecognized arguments: --caption_dropout_rate=0.1
Do you mean you think we should ignore options instead of causing an error, or mean we should print additional message in these special cases and still cause an error?

I like this. One question I would like clarification on. When both CLI parameters are passed along the TOML config... which take precedence? My personal preference if that if a TOML file is used it sould always have precedence over the CLI options... That way on can override CLI options by setting config for specific dataset. I hope this is how it works.
Great work @fur0ut0 . This has been a pet peeve of mine sice I used kohya_ss sf-scripts. Finally there will be a way to easilly configure various dataset options.

@kohya-ss

I will take time to review and test :)

Thanks a lot! Please feel free to contact me if you have any other questions.
@bmaltais

When both CLI parameters are passed along the TOML config... which take precedence?

The config file options are always prioritized over CLI options.
README describes about this behavior, but only in Japanese. Sorry for not providing English README in the current state. I will update README in the near future.

Cool. I like that the old CLI is still available for training those simple one dataset models... And be able to use the config file for more complex ones. I think this missing feature was holding back some users from using kohya for large training

This toml file seems to cause an error: voluptuous.error.MultipleInvalid: extra keys not allowed @ data['datasets'][0]['subsets'][0]['metadata_file']
Maybe I am doing something wrong, any ideas?
[general]

# これは fine tuning 方式のデータセット
[[datasets]]
resolution = [768, 512]

  [[datasets.subsets]]
  # image_dir = 'D:\Work\SD\Diffusers-DB\data\ds_test\ft_train1\images'
  metadata_file = 'D:\Work\SD\Diffusers-DB\data\ds_test\ft_train1\ft1_lat.json'

  [[datasets.subsets]]
  metadata_file = 'D:\Work\SD\Diffusers-DB\data\ds_test\ft_train2\ft2_cln.json'

We need to provide image_dir for every subset.
However, this error message seems weird, right? This comes from error message of voluptuous only shows the first one when there are multiple errors.
In this case, it firstly tries to parse config as DreamBooth dataset. This time it causes extra key error because DreamBooth dataset does not support "metadata_file" option.
After that, it tries to parse config as fine tuning dataset. This time it causes required key error because there is no "image_dir" option.
I think adding another required config like is_dreambooth to dataset would improve this weird behavior because we can deterministically parse dataset config. What do you think?

I also wonder that matadata_file is required for fine tuning dataset, so it would be possible to parse as a fine tuning data set first. If there is no metadata_file, then it would be the DreamBooth dataset.

I'm afraid that simply swapping parsing order still causes the same issue because DreamBooth dataset also has distinct options, "is_reg" and "caption_extension".
However, checking whether metadata_file exists before parsing seems nice. I will try implementing deterministic dataset parsing feature.

Ah, I have found image_dir is not required for FineTuningDataset now when metadata file has absolute path information.
I think image_dir should be handled as optional in fine tuning dataset while handled as required in DreamBooth dataset. I will also fix this.

Update:

checking metadata_file existence before dataset parsing

This improves the confusing error message we have seen

update README

I would like to confirm one thing, is my understanding correct that we cannot mix subsets of DreamBooth and fine tuning as a subsets of a certain dataset?

You are right. These two subset types cannot be mixed into single dataset.
This is mainly because I have no idea how to compensate the number of regularization images when there are also fine tuning subsets. If you come up with some way, these different types of subsets might be able to mix together.
I have added description about this topic to README.


arcadia.linear/v4 functions buggy

(v4+ (v4 1 5 6 9) (v4 1 5 6 9))
;; #unity/Vector4 [18.0 2.0 10.0 12.0]

Expected #unity/Vector4 [2.0 10.0 12.0 18.0]. Looks like components are being swapped around.

This is a side-effect of the alphabetical field sorting in arcadia.literals. These functions actually work fine.
(v4+ (v4 1 5 6 9) (v4 1 5 6 9))
;; #unity/Vector4 [18.0 2.0 10.0 12.0]

(.x (v4+ (v4 1 5 6 9) (v4 1 5 6 9)))
;; 2.0

(.y (v4+ (v4 1 5 6 9) (v4 1 5 6 9)))
;; 10.0

(.z (v4+ (v4 1 5 6 9) (v4 1 5 6 9)))
;; 12.0

(.w (v4+ (v4 1 5 6 9) (v4 1 5 6 9)))
;; 18.0

Simpler examples illustrate this as well
(v4 1 2 3 4)
;; #unity/Vector4 [4.0 1.0 2.0 3.0]

(UnityEngine.Quaternion. 1 2 3 4)
;; #unity/Quaternion [4.0 1.0 2.0 3.0]

arcadia.literals needs to be resisted to see if this can be addressed. At the very least this confusing behavior needs to be documented.

seems like a non-issue


Clean requirements.txt

Looks like you may need to clean-up requirements.txt file some hard coded paths included

Any suggestins on how to run the project without hardcoded paths?


Output too noisy, particularly for monorepos

As an NPM admin, it is my job to review the dry-run output for a project in order to approve a release. However, the output for this action is too noisy. This is mainly due to the fact that +x is still enabled, but the output is also a bit disorganized. This is not a huge deal for libraries, but for monorepos, which could contain many packages, it makes review unnecessarily difficult.
Ideally, the output should make it very clear what actions are about to be performed (or not performed) and which packages are being published and which are not. And all actions should be grouped by package if possible instead of being divided up. Finally, the output should provide instructions to assist the reviewer.
Because this action has additional steps after the "Dry Run Output" step, perhaps it makes more sense to provide a step at the very end which summarizes what happened. This would allow us to create the output we want.

For a monorepo, it would be great if the output looked like this:
DRY-RUN MODE IS ENABLED. NO PACKAGES WILL BE PUBLISHED.

The following packages will be included in this release:

- `@metamask/network-controller` 22.0.0
- `@metamask/notification-services-controller` 0.12.0

== @metamask/network-controller ==

An archive has been generated which includes the list of files to be published.

Please review this list and let the release author know if there are any files that should be excluded from publishing (e.g. test files).

➤ YN0000: CHANGELOG.md
➤ YN0000: LICENSE
➤ YN0000: README.md
➤ YN0000: dist/NetworkController.cjs
➤ YN0000: dist/NetworkController.cjs.map
➤ YN0000: dist/NetworkController.d.cts
➤ YN0000: dist/NetworkController.d.cts.map
➤ YN0000: dist/NetworkController.d.mts
➤ YN0000: dist/NetworkController.d.mts.map
➤ YN0000: dist/NetworkController.mjs
➤ YN0000: dist/NetworkController.mjs.map
➤ YN0000: dist/constants.cjs
➤ YN0000: dist/constants.cjs.map
➤ YN0000: dist/constants.d.cts
➤ YN0000: dist/constants.d.cts.map
➤ YN0000: dist/constants.d.mts
➤ YN0000: dist/constants.d.mts.map
➤ YN0000: dist/constants.mjs
➤ YN0000: dist/constants.mjs.map
➤ YN0000: dist/create-auto-managed-network-client.cjs
➤ YN0000: dist/create-auto-managed-network-client.cjs.map
➤ YN0000: dist/create-auto-managed-network-client.d.cts
➤ YN0000: dist/create-auto-managed-network-client.d.cts.map
➤ YN0000: dist/create-auto-managed-network-client.d.mts
➤ YN0000: dist/create-auto-managed-network-client.d.mts.map
➤ YN0000: dist/create-auto-managed-network-client.mjs
➤ YN0000: dist/create-auto-managed-network-client.mjs.map
➤ YN0000: dist/create-network-client.cjs
➤ YN0000: dist/create-network-client.cjs.map
➤ YN0000: dist/create-network-client.d.cts
➤ YN0000: dist/create-network-client.d.cts.map
➤ YN0000: dist/create-network-client.d.mts
➤ YN0000: dist/create-network-client.d.mts.map
➤ YN0000: dist/create-network-client.mjs
➤ YN0000: dist/create-network-client.mjs.map
➤ YN0000: dist/index.cjs
➤ YN0000: dist/index.cjs.map
➤ YN0000: dist/index.d.cts
➤ YN0000: dist/index.d.cts.map
➤ YN0000: dist/index.d.mts
➤ YN0000: dist/index.d.mts.map
➤ YN0000: dist/index.mjs
➤ YN0000: dist/index.mjs.map
➤ YN0000: dist/logger.cjs
➤ YN0000: dist/logger.cjs.map
➤ YN0000: dist/logger.d.cts
➤ YN0000: dist/logger.d.cts.map
➤ YN0000: dist/logger.d.mts
➤ YN0000: dist/logger.d.mts.map
➤ YN0000: dist/logger.mjs
➤ YN0000: dist/logger.mjs.map
➤ YN0000: dist/types.cjs
➤ YN0000: dist/types.cjs.map
➤ YN0000: dist/types.d.cts
➤ YN0000: dist/types.d.cts.map
➤ YN0000: dist/types.d.mts
➤ YN0000: dist/types.d.mts.map
➤ YN0000: dist/types.mjs
➤ YN0000: dist/types.mjs.map
➤ YN0000: package.json
➤ YN0000: Package archive generated in<EMAIL_ADDRESS>➤ YN0000: Done in 0s 65ms

View the complete diff between `@metamask/network-controller` 21.0.0 (latest) and 22.0.0 (to-be-published):

https://github.com/MetaMask/core/actions/runs/11485936994/artifacts/2095263464

== @metamask/notification-services-controller ==

An archive has been generated which includes the list of files to be published.


[BUG] Bootstrap toolchain allows no trusted principals

The CLI command seedfarmer bootstrap toolchain allows the user to not pass in a trusted principal ARN, causing the toolchain template to fail.  There should be a trusted-principal ARN that is valid as a required field when making this call.

This validation should occur in the seed-farmer/seedfarmer/commands/_bootstrap_commands.py::bootstrap_toolchain_account to be sure that the ARN is a valid format.  There are times where this command is called w/o a principal passed in b/c the toolchain role is created and unchnaged, but the deployment role needs to be deployed (and the user is using the --as-target flag)

Just hit this issue, I don't think you would ever call it w/o needing a principal?

I would lean towards requiring the user to specifying the principal on every call to bootstrap, but I'll take a look and implement validation.

Added a proposed change @dgraeber above, lmk your thoughts.


Examples are correct?

In your examples you used:
1-
import { XlsxRead, XlsxTable, XlsxSheets, XlsxJson, XlsxWorkbook, XlsxSheet, XlsxDownload } from "../../dist/vue3-xlsx.cjs.prod.js";
that we ususally write:
import { XlsxRead, XlsxTable, XlsxSheets, XlsxJson, XlsxWorkbook, XlsxSheet, XlsxDownload } from "vue3-xlsx";
2-
imported: XlsxRead used: (in template) xlsx-read!!!
3- vuejs 3 use setup: wrong definition.
Thank you

https://joaomede.github.io/vue3-xlsx/guide/#example


Errors in numbers parsing

sajson does erroneously accept these contents as numbers, although they are not numbers according to RFC 7159 section 6. Numbers.
[-]
[-2.]
[0.e1]
[2.e+3]
[2.e-3]
[2.e3]
[-.123]
[1.]

Hi @nst!  Thanks for the bug report.  I'm back from vacation now, and the bug is fixed by https://github.com/chadaustin/sajson/commit/4376d1eb3bce2d597d71df97c8d83e1928254e00


Airport filter that does not allow me to find San Francisco

There is an issue with the airport filter that does not allow me to find San Francisco when I type san. This video is not a loop. As I delete letters down to san it auto-populates with San Diego.

Originally posted by @blackfalcon in https://github.com/AlaskaAirlines/auro-combobox/issues/90#issuecomment-1259004484

Reference: https://github.com/AlaskaAirlines/auro-combobox/pull/90

When interacting with this element, there is a clear issue with the fact that all the options values are lowercase. This is inconsistent with how the https://www.alaskaair.com/search-test/ data is structured and may be a why entering san automatically takes you to san diego international.
Typing in SAN produces a list, but then there is an issue with the arrow moving up/down the list. See the attached screen capture for all UI issues.


feat: add openedge-language-server

@mason-org/triage notify(Reason::NewPullRequest)
This comment ensures a notification is delivered to maintainers.
 🤖 This is an automated comment.    📖 Source code


Improve About page, especially mention Windows

I see that
http://healpix.readthedocs.io/en/latest/about.html
still exists, and it's referenced from the front page:
http://healpix.readthedocs.io/en/latest/index.html#about-this-package
Possibly that about page could be removed (moving essential info on docs front page), or updated.
Specifically, I think one important point to make is that this package fully supports Windows.
My understanding is that the HEALPix C++ library and healpy aren't fully supported on Windows, or don't work at all on Windows. E.g. healpy doesn't seem to have a Windows package on conda-forge:
https://github.com/conda-forge/healpy-feedstock#current-build-status
Pretty much all of the packages using Astropy and healpy (reproject, hips, gammapy, ... probably more ... ) would like to fully support Windows. So apart from the license and installation issues with healpy, Windows support is a huge selling point that everyone will understand why a new package even with a healpy-compatible API is needed.

@cdeil - I've tidied up the about page, which now also mentions windows. I also mentioned windows (and other OSes) on the installation page. I don't want to move everything in about to the front page otherwise it might be a bit overwhelming. Does the current page look good? If so, can you close this?

I'm closing this issue. We still have #10 and #47 open and I think the remaining discussion is mostly about names, so this extra issue doesn't help.


Command "Click for more information" button crashes UI

Clicking the more info button in the command pop up crashes the UI.
Environment: Window 10 20H2 with the bundled .NET 5.0 runtime

Thanks for creating an issue!
I probably forgot something so thank you for letting me know.

Thanks for creating an issue!
I probably forgot something so thank you for letting me know.

No worries. It's a great service, thanks for the work :)

No worries. It's a great service, thanks for the work :)