Blacklisted media still showing

Amazing extension chief
however blacklisting is not working for some reason
I blacklisted Mozilla Firefox, and YouTube. But it is still showing up in the player

Since you have not replied, I will close the issue.

i had the same problem, i blacklisted Google Chrome but it's still there, or i did it wrong.

i had the same problem, i blacklisted Google Chrome but it's still there, or i did it wrong.

The extension does not check for the name of the executable, instead it checks for the name in the desktop file. So just "chrome" should work.

i had the same problem, i blacklisted Google Chrome but it's still there, or i did it wrong.

The extension does not check for the name of the executable, instead it checks for the name in the desktop file. So just "chrome" should work.

Thanks, now it's working

Is there a way to put examples and instructions for using the "blacklist" feature on documentation or on the extension homepage somewhere? Having to search through the github issues for a main feature is kind of inconvenient

@cliffniff  What would be the blacklist string for "Microsoft Teams" application? Name in the .desktop file is Microsoft Teams - Preview. Player display name is Microsoft Teams Notification. Executable name is teams. None of the above worked for me.


Remove version: TeamViewer.TeamViewer version 15.59.3

No longer needed because of newer version
Microsoft Reviewers: Open in CodeFlow

URL: https://download.teamviewer.com/download/TeamViewer_Setup.exe
OK
(Automated message - build 923)

#190964


Gaps in morning lights when master off

Hall light turns om, but not off
Bathroom light stays off
Morning starts at 4:30 so obvious still dark and supposed to be sleeping 😅
Maybe also don't let morning start at 4:30

I suppose this is fixed, we'll see next time I have to go to the bathroom at 4:30AM


Fix the starter pack so it works up to the latest version of genie - DO NOT MERGE

(DO NOT MERGE)
Starter pack was very out of date and did not work with the latest genie dev work, it now works and is fully integrated with the new select and results screen.

No longer required, theme config, etc will auto copy from the core repo.


Logo - Fixed kerning between A and T

Re-centered logo after fixing kerning as it's a little less wide now

Thanks


OCL: fix bug 4006

create UMat from user allocated host memory using USE_HOST_PTR flag when create cl buffer)
http://code.opencv.org/issues/4006

@alalek @SergeySivolgin it seems there are some fails in OCL tests (might be caused by this commit, although on my system intel HD4400 tests are passed both in debug and release configuration).
BTW, why fails in tests treated as a warnings in buidbot?


Differences between ft_main.py and lora_main.py

In ft_main:
https://github.com/zjunlp/EasyEdit/blob/32c9b71ef2a47b3b03ac655be6b7a7cd90d37c18/easyeditor/models/ft/ft_main.py#L181
The input for the model is the prompt, then calculate loss(output, target)
In https://github.com/zjunlp/EasyEdit/blob/32c9b71ef2a47b3b03ac655be6b7a7cd90d37c18/easyeditor/models/lora/lora_main.py#L154
The input for the model is the prompt+target, then record the return.loss
Are these two formats the same? Why different formats for these two methods?
Also, in https://github.com/zjunlp/EasyEdit/blob/32c9b71ef2a47b3b03ac655be6b7a7cd90d37c18/easyeditor/models/lora/lora_main.py#L133
some codes are marked, and they are exactly where the inputs are prompts and then calculate loss(output, target).
Thanks~

Thanks


Add circular progress indicator for issue completion

Some folks can't call everyone at once, others only call a smaller selection of reps than what we send. It would be useful to provide a progress circle to let people know how far along they are if they haven't completed their reps.
At least partially implemented in #196 (and it looks like it might even be complete), it may be worthwhile to refactor this into its own PR.

As mentioned here: https://github.com/5calls/5calls/issues/415
We should adjust completion so skipping does not count towards finishing a set of calls. The indicator will be helpful in letting folks track how many calls they've completed if they did half.

This was fixed in #248


Editing xmodel files

Is there anyway to edit the weights of an xmodel? Alternatively, is there a way to load vai_c_tensorflow2 onto the petalinux running the DPU?

@Rellek72 your goal is to update the weights dynamically at runtime?  I believe that currently the only way to do this would be to swap in a new xmodel file.  The weights in the compiled xmodel are not consumable as they have been reordered and optimized for deployment.  Consider however that the ONNX Runtime implementation integrates the compiler into the runtime.  The implication is that the xcompiler runs on the target when you leverage ONNX Runtime.  Tell us more about your use case.

My overall goal is to deploy a design to an UltraScale+ SoC using the traditional Vitis AI flow, then be able to make small tweaks to the weights using transfer learning without leaving the SoC.
My thought was that I could use quantized .h5 output from vai_q_tensorflow2 to do a small amount of quantized training on the ARM core of the SoC. I was hoping to then either manually splice in the weights to the xmodel, or re-compile the xmodel locally on the board
I hadn't looked into the ONNX runtime before, that seems a more promising framework for what I'm trying to do, but I may need to get the vai_q_tensorflow2 running on the ARM core of the SoC.

@Rellek72 I have been a big proponent of the possibility of implementing Federated Learning on our edge devices, or perhaps the notion of on-device "light" re-training of the model.  For Edge applications, this has many potential applications and benefits.  Longer term I will continue to consider this and try to advocate for solutions.

@Rellek72 your goal is to update the weights dynamically at runtime? I believe that currently the only way to do this would be to swap in a new xmodel file. The weights in the compiled xmodel are not consumable as they have been reordered and optimized for deployment. Consider however that the ONNX Runtime implementation integrates the compiler into the runtime. The implication is that the xcompiler runs on the target when you leverage ONNX Runtime. Tell us more about your use case.

Not sure if you're still active, but I'm curious to know, if it's not possible to change the weights, is it possible to access them, as in only read the weights of a specefic layer, I'm working on a watermarking application which would requimre to check for a watermark in the weights in the board.
thank you


Missing editor error highlighting

Describe the bug
During https://github.com/kubeshop/monokle/pull/1571, we noticed the editor no longer shows error highlighting.
To Reproduce

Open a resource with an error.
The bug is that the error no longer is highlighted.

Expected behavior

The error should be highlighted.

Screenshots
If applicable, add screenshots to help explain your problem.
Additional context

This is a regression. It works in Monokle v1.5.0.

The missing highlighting seems to be related due to a dependency issue.
"monaco-editor-webpack-plugin": "4.2.0",
"monaco-yaml": "3.2.1",
"react-monaco-editor": "0.46.0", // monaco editor ^0.28.1

to
"monaco-editor-webpack-plugin": "4.2.0",
"monaco-editor": "0.31.1",
"monaco-yaml": "3.2.1",
"react-monaco-editor": "0.47.0", // monaco editor ^0.33.0

I suspect we added the peer dependency because of another problem. I’m quite sure we are not within the supported version matrix as seen here: monaco-editor >= 0.31.0 should use monaco-editor-webpack-plugin 7.*.*.The problem with upgrading is that we use an internal method that is no longer available.
// src/components/molecules/Monaco/editorHelpers.ts:4
import {getDocumentSymbols} from 'monaco-editor/esm/vs/editor/contrib/documentSymbols/documentSymbols';

update: I managed to downgrade with the following versions and now it works again. This confirms my hypothesis.
"monaco-editor-webpack-plugin": "4.2.0",
"monaco-editor": "0.28.1",
"monaco-yaml": "3.2.1",
"react-monaco-editor": "0.46.0",

Thanks for investigating this @WitoDelnat. Let's downgrade for now so we can have the highlighting working for 1.6.3 and keep this issue open so we know to properly to the upgrade for 1.7 or later.

Hello @remcohaszing 👋 Much appreciated for letting us know you found a solution. Also great work on monaco-yaml - it's working excellent for us!


vite-plugin-angular throws error after installing with yarn

Please provide the environment you discovered this bug in.
@analogjs/vite-plugin-angular : 1.9.4
Which area/package is the issue in?
vite-plugin-angular
Description
I am using the vite-plugin-angular to get my unit tests to work. I have been getting errors such as "Expected to be running in 'ProxyZone', but it was not found." and decided to investigate the plugin to overcome these. Now the ProxyZone errors are gone but now there is an issue with "@angular/build/private".
Please provide the exception or error you saw
Cannot find module '@angular/build/private'
Require stack:
-<EMAIL_ADDRESS>Error: Cannot find module '@angular/build/private'
Require stack:
-<EMAIL_ADDRESS>    at Module._resolveFilename (node:internal/modules/cjs/loader:1145:15)
    at Module._resolveFilename (C:\Users\joe.williams\Projects\Megatron\frontend\src\node_modules\tsconfig-paths\lib\register.js:103:40)
    at Module._load (node:internal/modules/cjs/loader:986:27)
    at Module.require (node:internal/modules/cjs/loader:1233:19)
    at require (node:internal/modules/helpers:179:18)
    at file:///C:/Users/joe.williams/Projects/Megatron/frontend/src/node_modules/@analogjs/vite-plugin-angular/src/lib/utils/devkit.js:37:87
    at ModuleJob.run (node:internal/modules/esm/module_job:222:25)
    at async ModuleLoader.import (node:internal/modules/esm/loader:316:24)
    at async loadConfigFromBundledFile (file:///C:/Users/joe.williams/Projects/Megatron/frontend/src/node_modules/vite/dist/node/chunks/dep-CB_7IfJ-.js:66691:15)
    at async loadConfigFromFile (file:///C:/Users/joe.williams/Projects/Megatron/frontend/src/node_modules/vite/dist/node/chunks/dep-CB_7IfJ-.js:66532:24)

Other information
No response
I would be willing to submit a PR to fix this issue

[ ] Yes
[X] No

You likely have direct imports from vitest like this: `import { describe, it } from vitest;'
angular tests require patched test hooks (it, describe etc) and when importing them from vitest you get the raw, unpatched ones. You must only use the global, patched functions provided by analog

Hi @AlexAegis thanks for your response. I have only just installed vitest in our project (we were previously using Jest) so there are no imports from vitest that could be causing this. This error seems to be more to do with accessing a directory that doesn't exist...

@joewIST what package manager are you using? The @analogjs/vite-plugin-angular package has peer dependencies, including @angular/build that should be handled by most package managers, with yarn being an exception.

Thanks @brandonroberts. That would explain it; we use Yarn. Is there a workaround for use with Yarn or is this just not supported yet? I couldn't see anything on the documentation but I may have missed something!

thanks guys, just had the same issue with new Angular app created using @nx/angular:application
Failed to process project graph. Run "nx reset" to fix this. Please report the issue if you keep seeing it.
      An error occurred while processing files for the @nx/vite/plugin plugin.
    - apps/ng-frontend/vite.config.mts: Cannot find module '@angular/build/private'
  Require stack:
  -<EMAIL_ADDRESS>      Error: Cannot find module '@angular/build/private'
      Require stack:
      -<EMAIL_ADDRESS>
No more issues after applying missing dependencies from https://github.com/analogjs/analog/issues/1458#issuecomment-2501498555

Great! That works and I don't get the dependency error.
However, I'm now getting the "Error: No test suite found in file" error and I can't seem to find any consistent fix other than downgrade to an earlier version of vitest. Can you help?

Check your tsconfig.spec.json configuration and make sure it matches the one from the docs
https://analogjs.org/docs/features/testing/vitest#setup-for-running-tests-for-node
Also try setting the tsconfig in the plugin inside the vite.config.mts
// vite.config.mts
import angular from '@analogjs/vite-plugin-angular';

//...
plugins: [
 angular({ tsconfig: `${__dirname}/tsconfig.spec.json` })
]

Thanks @brandonroberts that sorted it! Now I can enjoy faster tests and finally replace Jest.

Awesome


Design Proposal: Preview Deployment

Preview Deployment

Summary
Motivation

Goals
Non-Goals

Proposal

User Stories

Design Details

Summary
Improve Developer experience. This proposal makes a dedicated environment, deploy, and a custom URL dispatch per Pull Request. ref https://vercel.com/docs/concepts/git/vercel-for-github

Motivation
More and more environments are being built with Cloud Native on cloud services. Developers need to leverage cloud services to check and develop. Setting up cloud services is very time-consuming for teams to check and demo.
Goals

You can confirm with only one click
It can be checked under conditions similar to those of production.
Your teams can share and demonstrate.
and secure

Non-Goals

For public OSS(This proposal is for internal development)

Proposal
A developer creates a branch, writes code, and sends a pull request. At that time, this GitHub Action created a dedicated environment similar to the production environment. And, It creates a custom URL. Then, it comments on GitHub. we can confirm the browser. When this pull request is closed, the environment is deleted.

User Stories
Teams can demonstrate as a PoC
Design Details

Prepare azure container app

TBD

Set up GitHub Action

TBD

Revision v.s another azure container app

on: [push, pull_request]

name: Container Deployment Sample Workflow

jobs:
  build-and-deploy:
    runs-on: ubuntu-latest
    steps:
    # checkout the repo
    - name: 'Checkout GitHub Action'
      uses: actions/checkout@master

    - uses: actions/setup-node@v2
      with:
        node-version: '16.13.0'
        registry-url: 'https://npm.pkg.github.com'
    - run: npm install
    - run: tsc
    - name: 'Login via Azure CLI'
      uses: azure/login@v1
      with:
        creds: ${{ secrets.AZURE_CREDENTIALS }}
    - name: 'Deploy to Azure Container Apps'
      uses: ./
      with:
        resource-group: aca-sample-rg
        name: momosuke-container3
        location: 'East US'
        subscription-id: 'a4deccb1-a1f6-40cb-a923-f55a7d22c32d'
        managed-environment-name: 'momosuke-container-env'
        dapr-app-port: 3000
        dapr-app-protocol: 'http'
        dapr-enabled: true
        ingress-external: true
        ingress-target-port: 3000
        ingress-custom-domains-json: |
          [
          ]
        # ingress-custom-domains-json: |
        #   [
        #     {
        #       "name": "www.my-name.com",
        #       "bindingType": "SniEnabled",
        #       "certificateId": "/subscriptions/a4deccb1-a1f6-40cb-a923-f55a7d22c32d/resourceGroups/aca-sample-rg/providers/Microsoft.App/managedEnvironments/momosuke-container-env/certificates/527CAD9560BF6B5F95AE62E94BF7A7CA0EC5C294ACC77622A0CF24527936C63C"
        #     }
        #   ]
        # ingress-traffic-json: |
        #   [
        #   ]
        # ingress-traffic-json: |
        #   [
        #     {
        #       "label": "production",
        #       "revisionName": "yuhattor-container3--qpxyrnn",
        #       "weight": 100
        #     }
        #   ]
        # scale-max-replicas: 5
        # scale-min-replicas: 1
        # scale-rules-json: |
        #   [
        #   ]
        scale-rules-json: |
          [
            {
              "name": "httpscalingrule",
              "custom": {
                "type": "http",
                "metadata": {
                  "concurrentRequests": "30"
                }
              }
            }
          ]
        containers-config-json: |
          [
            {
              "name":"simple-hello-world-container",
              "image": "mcr.microsoft.com/azuredocs/containerapps-helloworld:latest",
              "probes":[
                 {
                    "type":"Liveness",
                    "httpGet":{
                       "path":"/health",
                       "httpHeaders":[
                          {
                             "name":"Custom-Header",
                             "value":"Awesome"
                          }
                       ],
                       "port":8080
                    },
                    "initialDelaySeconds":3,
                    "periodSeconds":3
                 }
              ]
            }
          ]

https://github.com/ry0y4n/aca-deploy/blob/main/.github/workflows/sample.yml

Here is a yaml file of the contents of containers.
https://docs.microsoft.com/en-us/rest/api/containerapps/container-apps/create-or-update?tabs=HTTP
Assuming that file names like this one as containers-config.yml will be written?
- name: acatest1
  image: repo/acatest1:v1
  args: "foo bar"
  command: "foo bar"
  env: "foo1=bar1, foo2=bar2"
  volumeMounts:
  - storageName: "string"
    name: "string"
    storageType:
    - AzureFile: "string"
      EmptyDir: "string"
  resources:
  - cpu: 0.5
    ephemeralStorage: "1Gi"
    memory: "250Mb"
  probes:
  - type: Liveness
    httpGet:
      path: "/health"
      httpHeaders:
      - name: Custom-Header
        value: Awesome
      port: 8080
    initialDelaySeconds: 3
    periodSeconds: 3
  - type: Liveness
    httpGet:
      path: "/health"
      httpHeaders:
      - name: Custom-Header
        value: Awesome
      port: 8080
    initialDelaySeconds: 3
    periodSeconds: 3
- name: acatest2
  image: repo/acatest2:v1
  probes:
  - type: Liveness
    httpGet:
      path: "/health"
      httpHeaders:
      - name: Custom-Header
        value: Awesome
      port: 8080
    initialDelaySeconds: 3
    periodSeconds: 3

[ ] revision handling
[ ] ppt
[ ] notification
[ ] sample app

Moved remain tasks to #65


Create stub for CoKleisli.agda

The associativity property is a game of assoc, refl⟩∘⟨ and ⟩∘⟨refl... More expert hands will fill the hole!

This is looking excellent. I'll figure out out to use stdlib-1.7 and merge this in.


Add quick toggle for gateway redirect/all functionality

Do something similar to IPFS Station (chrome extension), and include a toggle for gateway redirect in the main interface.
Possibly add a way to temporarily toggle all functionality of the extension (globally and/or per site), similar to how ublock does it.
I find that I spend a lot of time going to the extensions page and manually disabling and then re-enabling the extension when I want to cache a hash on a public gateway.

I think this is addressed in latest v2.x.x from Developer Channel.
Give it a try:
If you disable automatic mode in Preferences:

then you should  be able to manually toggle redirect:

You can also enable/disable redirect per site by adding/removing its hostname:

Feel free to reopen if you had something different in mind.

Yeah, I had a button like that in mind, and I didn't see this option due to automatic mode, but I think it should still be available even in automatic mode. Note that I cannot reopen this issue.
The Public Gateways Hosts setting could be better explained in the extension settings as well, the name isn't self-explanatory when it comes to what the option does.

Good points.
I see should could improve UX around it, perhaps something like this:

improve description of "public gateways hosts"
change browser action menu to always have item to "toggle redirect"

"automatic mode" would be disabled when user manually toggles redirect
(user would have to to re-enable it in preferences)

Does this take on UX sound good? Or maybe there is a simpler way to handle this?

Hm, I'm not sure that disabling automatic mode once the user toggles the gateway redirect setting is a good idea. My thoughts on this:
The extension (always) provides a "Disable/enable gateway redirect" button. When a user clicks on that button, the extension temporarily stops redirecting requests for IPFS resources.
Toggling gateway redirect twice should not cause any change in the configuration state/settings of the program. Imagine the gateway caching scenario in the first comment: The user disables redirect and makes a request to ipfs.io/ipfs/..., once the resource loads, the user re-enables redirect. It would be confusing if "automatic mode" was disabled after doing this.
I also believe that automatic mode should be on by default, but configurable as the common case is to only redirect if the user's IPFS daemon is online (the user expects things to "just work"), while rarely, some users might have weird setups that might not work well with /api/swarm/peers requests. This is a bit off topic, but it demonstrates that changing the setting is rarely what people would want when disabling redirect.
Improving descriptions of settings with a (?) icon with a tooltip for most settings might be a good idea.

FYI updated Preferences screen will look like this:


Write bindings for Page.pdf()

Page.pdf() needs an implementation similar to other several other functions that take options objects, like Puppeteer.launch(). This would involve creating a type Page.pdfOptions and a<EMAIL_ADDRESS>annotated external Page.makePDFOptions(). Like the other examples already implemented, we'll wanted to create another function with the same name to shadow the external Page.makePDFOptions. It will convert to JS types--in particular bool needs to be converted to Js.boolean. We can use the helper functions in our Util module for that.
Docs
The Typescript definitions are a good reference here. They list all the possible values of the string enum pdfFormat which we'll probably want to handle using<EMAIL_ADDRESS>Searching for "pdf" on that should lead to the relevant definitions.
Also, the Pdf module can be removed as we should just put this all in the Page module.

I would like to take care this issue.


Some changes to RawFdContainer

Fixes https://github.com/psychon/x11rb/issues/363

Methods are not provided at all on non-unix systems or when allow-unsafe-code is disabled. Trying to create a RawFdContainer when it is not available will cause a compile error instead of panicking at runtime.
RawFdContainer::new does not take the ownership of the FD anylonger. Instead, it creates a copy with the dup syscall.
FromRawFd is now implemented for RawFdContainer to take the ownership of the passed FD.
drop does not panic on failure. Instead, a close method is provided that allows the caller to check for errors.
From<T: IntoRawFd> is no longer implemented.
A try_clone method has been added. It allows to clone a RawFdContainer creating a new FD with dup.

* Methods are not provided at all on non-unix systems or when `allow-unsafe-code` is disabled.

Hmm, this is causing issues on windows + libxcb

Basically :+1: for the PR.
Ultimately, it feels to me like that raw fd stuff is something that is not well supported by Rust. That seems like the source of some of the problems we experience.
The old code was generic enough to "support anything". No idea how to easily preserve that. Or, as Travis puts it:
error[E0277]: the trait bound `x11rb::utils::RawFdContainer: std::convert::From<std::fs::File>` is not satisfied
   --> examples/shared_memory.rs:105:10
    |
105 |     conn.shm_attach_fd(shmseg, file, false)?;
    |          ^^^^^^^^^^^^^ the trait `std::convert::From<std::fs::File>` is not implemented for `x11rb::utils::RawFdContainer`
    |
    = note: required because of the requirements on the impl of `std::convert::Into<x11rb::utils::RawFdContainer>` for `std::fs::File`

Implementing conversion for "everything" by hand cannot really work. It would only ever cover stuff that is in std and would break for any new additions to std.

Hmm, this is causing issues on windows + libxcb

That does not seem too bad and can easily be fixed with some feature checks in xcb_ffi:
rror[E0599]: no function or associated item named `into_raw_fd` found for struct `utils::raw_fd_container::RawFdContainer` in the current scope
   --> src\xcb_ffi\mod.rs:220:71
    |
220 |             let mut fds: Vec<_> = fds.into_iter().map(RawFdContainer::into_raw_fd).collect();
    |                                                                       ^^^^^^^^^^^ function or associated item not found in `utils::raw_fd_container::RawFdContainer`
    |
   ::: src\utils.rs:182:5
    |
182 |     pub struct RawFdContainer(());
    |     ------------------------------ function or associated item `into_raw_fd` not found for this
error[E0599]: no function or associated item named `into_raw_fd` found for struct `utils::raw_fd_container::RawFdContainer` in the current scope
   --> src\xcb_ffi\mod.rs:220:71
    |
220 |             let mut fds: Vec<_> = fds.into_iter().map(RawFdContainer::into_raw_fd).collect();
    |                                                                       ^^^^^^^^^^^ function or associated item not found in `utils::raw_fd_container::RawFdContainer`
    |
   ::: src\utils.rs:182:5
    |
182 |     pub struct RawFdContainer(());
    |     ------------------------------ function or associated item `into_raw_fd` not found for this
error: aborting due to previous error
For more information about this error, try `rustc --explain E0599`.
error: could not compile `x11rb`.

Methods are not provided at all on non-unix systems or when allow-unsafe-code is disabled. Trying to create a RawFdContainer when it is not available will cause a compile error instead of panicking at runtime.

I think originally I wanted to have the RawFdContainer type only when it would actually work, but then code in src/generated/ related to FD passing failed to compile. Having the type panic at runtime seemed like the easiest way out.

Hmm, this is causing issues on windows + libxcb

You could add an explicit panic when XCBConnection receives an fd and allow-unsafe-code is disabled.

Hmm, this is causing issues on windows + libxcb

You could add an explicit panic when XCBConnection receives an fd and allow-unsafe-code is disabled.

In that case, XCBConnection would not be available at all.

I think originally I wanted to have the RawFdContainer type only when it would actually work, but then code in src/generated/ related to FD passing failed to compile. Having the type panic at runtime seemed like the easiest way out.

I was thinking adding something like a FdPassingConnection trait, that would be implemented for connections that support FD passing.
I don't have much time now, so I will continue to work on this later.

I was thinking adding something like a FdPassingConnection trait, that would be implemented for connections that support FD passing.

Hm. Such a change would carry through to all of the generated code (well, at least for those extension that have FD passing stuff). And it would make the return type of x11rb::connect depend on the enabled features (which is not notice and not easily possibly).
Also, I still want to make RustConnection support FD passing, so I am not sure if it makes much sense to spend a lot of time on it.
How about using the nix crate so that nix::unixstd::close and nix::unixstd::dup are accessible without using unsafe? This is basically the route I plan for FD passing on RustConnection. However, that would still not work on Windows.


Investigate flaky Java test failures

Description
Some of our backend tests are failing flakily. We need to investigate and figure out which tests are flaky and why.
Action requested

Retry tests automatically (depends on #3049 )
Look into the root causes of our flaky tests

Additional context
https://github.com/CDCgov/prime-simplereport/actions/runs/1965367265/attempts/1

Needed 2 retries to pass:
https://github.com/CDCgov/prime-simplereport/runs/5487318341?check_suite_focus=true

Example of flaky backend test: https://github.com/CDCgov/prime-simplereport/actions/runs/3062221733/jobs/4942953265
Example of flaky e2e tests: https://github.com/CDCgov/prime-simplereport/actions/runs/3061893121/jobs/4942389476

Export test occasionally fails; usually off by a few seconds.
We need to check and see if the other issues are still present after the Spring upgrade.


chore: disable access to grqphiql by default

Closes: #1016

Hva er endret?

Dokumentasjon / Storybook / testdekning

[ ] Dokumentasjon er oppdatert eller ikke relevant / nødvendig.
[ ] Ny komponent har en eller flere stories i Storybook, eller så er ikke dette relevant.
[ ] Det er blitt lagt til nye tester / eksiterende tester er blitt utvidet, eller tester er ikke relevant.

Skjermbilder eller GIFs (valgfritt)

Summary by CodeRabbit

New Features

Introduced a new environment variable, ENABLE_GRAPHIQL, allowing users to enable or disable the GraphiQL interface.
Conditional registration of the GraphiQL plugin based on the enable_graphiql configuration.
Enhanced Docker Compose configuration for the bff and bff-migration services with new environment variables for improved management.

Bug Fixes

Removed commented-out lines related to ENABLE_GRAPHIQL, clarifying its implementation status.

Should we enable this for dev / test, too, or rather change up the default to true instead, now at least with an opt-in to disable in prod? I find myself using it a lot tbh, but I don't think it has any public interest :D

Should we enable this for dev / test, too, or rather change up the default to true instead, now at least with an opt-in to disable in prod? I find myself using it a lot tbh, but I don't think it has any public interest :D

Make sense to me to have the console enabled in dev and disabled in prod.


Sticky states get reloaded unexpectedly

Hello christopher,
Say I have following states structure:
parent1: { sticky: true }
parent1.child1: { sticky: true }
parent1.child2: { sticky: false }

parent2: { sticky: false }
parent2.child1: { sticky: false }

When I do: parent1.child1 => parent2.child1 => parent1.child1, it works normally.
But when: parent1.child1 => parent2.child1 => parent1.child2 => parent1.child1, parent1.child1 gets reloaded.

@arthastft could you put this in a plunk for me?   I agree that behavior seems wrong

Of course, here: http://plnkr.co/edit/n4UEJ4qATykdUxEoez3v?p=preview.
I've found out a workaround that if I set all the states parallel to parent1.child1 to sticky, the problem goes away. Not ideal though.

Yes, I see how this is happening now.
https://github.com/christopherthielen/ui-router-extras/blob/master/src/stickyStateProvider.js#L180
"Deepest reactivate" is intended for when you directly reactivate a sticky state (without DSR), it should exit the children of that state.  For example, from parent1.child1 to parent1 should exit parent1.child.  Your use case causes deepestReactivate to be populated with your parent1 state, but then the logic for the use case above kicks in and removes parent1.child form the inactives list.  This will take a little bit of rework.

Hi christopher,
I'm afraid that the problem is still here.
I just updated the plunker to reference 0.0.13: http://plnkr.co/edit/n4UEJ4qATykdUxEoez3v?p=preview

@arthastft thanks for helping me fix a longstanding bug in ui-router-extras!
My unit tests don't currently catch your scenario (currently only a full integration test will, like your plunk)
Here is the analysis of the issue for future reference:

State A is inactivated
Another transition will reactivate State A, and enter State B
State B needs to be set up.  Part of this is loading resolves and calling $view.load() to retrieve template/controller, etc
$view.load() fires $viewContentLoading

ui-view responds to $viewContentLoading (and $stateChangeSuccess), and checks if it needs to update itself

It short circuits if the current locals object is the same reference as the previous locals
It looks at $state.$current.locals[viewname] to load previousLocals
Because the transition is in-procoess, $state.$current still has the fromState and its locals.
The fromState locals does not include the view for the state being reactivated, so the view reloads itself

In order to fix this, I had to provide the "view's locals for states being reactivated" during the transition.  I did this by defining another object and making it the prototype of __inactives.locals. The locals for states being reactivated are placed on that object, then removed when the transition is done.  Then, the ui-view for states being reactivated will short-circuit when $viewContentLoading is fired.

I created a modal with two tabs but the partials are not showing.
Here is the plunk: http://plnkr.co/edit/ukjUYS?p=info
Thanks in advance!


CloudUploadIcon color can only be primary

Typography and Button elements props are configurable, however the CloudUploadIcon color is fixed to primary.
Is there a way to override this with my own custom color?

Would you be able to send a PR?


Add focus-in event handling on the sb.input

This PR adds a focus-in handling for the sb.input.
Possible use-case is a data preloading before user started typing.

Thank you very much for this, but could you use {{select-box on-focus-in=preloadThings}}
That should work, although I need to document it.

Hm,
there is a weird thing:
on-focus-in=attrs.on-search throws an exception inside jQuery focus-in handler https://github.com/jquery/jquery/blob/c9935b6d2db9e1be4bed12f7419e98cdca45763e/src/event/focusin.js#L22
but working fine with on-focus-in=(action 'preloadThings')
Seems that problem is solved, but can you please give a little bit context behind the suggestion in the edit? I

For anybody interested the behaviour that @lessless required can be found here.
TLDR; You must preventDefault on mouseDown to if you don't want focus to be lost


[Feature proposal] Hability to use variables within svg when used as ReactComponent

Description
A new API that would allow us to pass variables in order to render a valid svg:
Why?
The hability of react to mount/unmount and rerender components depending on their props is efficient, but it still require a lot more tunning if you wish to render svg and you are a maintainer of svg libraries.
We are missing a feature to do the same with svg that is scalable for large project.
It would be basically the same as doing the mapping within a react component, except you don't have to write the react component and you only convert your svg using a JSX template.
Downside

A): Most of developers would simply just compute the svg using a custom react component and that would work.
B): There are no fallback within .svg for non-existing variables so the svg would become templated as it would be in react JSX. This could be introduced as an extension .svgr for svg react

Upside

C): It is done directly within .svg/.svgr, no need to write additional code.
D): Not only developer but graphic designer can work with it, all we need is to produce a sandbox UI tool for testing the rendering, and a CLI tool to convert .svgr to .svg
E): You will not have to maintain duplicate code for every of your svg. But you can still maintain any additional logic that calculates variables within casual react.

Regarding  (B):

meta-data could be introduced within the svg using comments such as: <!-- { width: 100, primaryColor: '#F00' } --> in order to render default instead if the missing props. (I have added this example in proposal 2). Missing props without comments declared would be automatically required by default.
A custom extension .svgr could also be used to detect such import.
This could also benefit for (D) to automatically generate the editing tool. We can add complexity to the meta-data for such purpose. import { metadata } from './logo'

Proposal
Proposal  1
Using props that are not reserved by svgr libs:
import { ReactComponent } from './logo.svg'

export default = () => (
  <ReactComponent
    title="Hello World"
    width={50}
    colorPrimary="#f07"
    config={config}
  />
);

Original svg
<svg>
  <path color={colorPrimary} />
  <path color={colorPrimary} width={`${width}`%} />
  <path color={config.darkColor} />
</svg>

Rendered svg
<svg>
  <title>Hello World</title>
  <path color="#f07" />
  <path color="#f07" with="50%" />
  <path color="#111" />
</svg>

Proposal 2
Using predifined props svgProps and comment default values.
import { ReactComponent, metadata } from './logo.svg'

const svgProps = {
  width: metadata.width * 2,
  config,
};

export default = () => <ReactComponent title="Hello World" svgProps={svgProps} />

Original svg
<svg>
   <!-- { width: 50, colorPrimary: '#0f9' } -->
  <path color={props.colorPrimary} />
  <path color={props.colorPrimary} width={`${props.width}`%} />
  <path color={props.config.darkColor} />
</svg>

Rendered svg
<svg>
  <title>Hello World</title>
  <path color="#0f9" />
  <path color="#0f9" with="100%" />
  <path color="#111" />
</svg>

Links / references

Following https://github.com/smooth-code/svgr/issues/96#issuecomment-392558783

+1

@neoziro thank you for the interest. We could save a lot more test and code with it.
We can mix up the two proposal in order to get a final spec for the new API, I thought you would do it because you have know the angles of the technical background.
What kind of format are you thinking to save the svg format?

Using comments is a good idea, I have to think about it 🧐

this is interesting, one of the reasons I built https://github.com/lifeiscontent/react-svg-injector

Thanks a lot for sharing this @lifeiscontent , maybe this can help neoziro to make a move.
@neoziro , we are impatient to use the next version of svgr in our rollup, do you have a release date scheduled?

SVGR is focused on transforming SVG created using tools, this is a little out of scope for now. Your proposition is not the common use case. I close it for now, but why not in future.

@neoziro I am so sad to read that. How do you recommend to programme the interaction with svg in react if you need to replace value within the svg?

@kopax Did you tried to use currentColor or css variables? They are not universal, but should work for styling.

currentColor doesn't allow much. CSS does not play well with JS programming (games) and advanced web programming. Resolving the ticket would turn the tool from great to excellent.
@neoziro is arguing it is out of scope but the scope remains delimited. I have no clue about svgr code. Is that big cost ?

It's about introducing custom syntax, not valid svg. It can be a big cost.
If you need to have more control on svg I recommend to keep it in js. svgr is about simple conversion static svg.

Ok I understand. svgr is a really good tool thanks a lot for doing it!


pipeline: return logs in --json mode

A pipeline run only returned logs in the StageFailed and
AssemblerFailed exceptions. Remove those and always return structured
data instead.
It only returns data for stages that actually ran (i.e., didn't come
from the cache). This is similar to the output in interactive mode.

Are the tests just failing because now we don't produce any output anymore? Maybe the result of the individual objects could be streamed, i.e. after each stage is finished it prints a json object with the result?

Update to fix the last failing test: osbuild now doesn't return the tree_id or output_id if they would be null. The test tried to unconditionally get them, resulting in a KeyError.

Are the tests just failing because now we don't produce any output anymore? Maybe the result of the individual objects could be streamed, i.e. after each stage is finished it prints a json object with the result?

We produce more output now, because instead of just returning json which looks like this { "tree_id": "foo", "output_id": "bar" }, it returns all logs per stage in that json. The problem was that we used subprocess.wait() on an osbuild process with a pipe connected to stdout. Once the pipe buffer was full, osbuild was blocked writing to it. I've changed that to use Popen.communicate(), which does the right thing.


Accessibility issue in the header

Description of the issue
The .govuk-skip-link in the template component is causing an accessibility issue that states page content is not contained by landmarks.
Steps to reproduce the issue
On the https://design-system.service.gov.uk/ if you inspect the page then --> go on Axe dev tools --> Scan page --> then you'll see something similar to the screenshot below. You can then highlight the issue by clicking on the All page content should be contained by landmarks and then clicking the highlight.

Actual vs expected behavior
I would expect there to be no accessibility issue.
Environment (where applicable)
The issue can be seen on the https://design-system.service.gov.uk/ webpage so it is on the latest one.
We found it happen when trying to add the cookie banner component into our project, it seemed to then expose this issue. We can see that this issue wouldn't happen if the govuk-skip-link was inside the header component rather than inside the template component.

Operating system:
Browser:
Browser version:
GOV.UK Frontend Version:

Thanks for the prompt response! Will have a read


Karpenter Should Show through kubectl get nodes when it has tainted Nodes

Description
What problem are you trying to solve?
Currently, Kubernetes uses the node.kubernetes.io/unschedulable taint and the spec.unschedulable field on the node to mark that a node is cordoned and may be about to be drained for maintenance or removal. This is visible through the printer columns that you get when you call kubectl get nodes like the following
NAME                                                    STATUS                     ROLES    AGE    VERSION
ip-192-168-10-60.us-west-2.compute.internal             Ready                      <none>   2d4h   v1.28.5-eks-5e0fdde
ip-192-168-125-1.us-west-2.compute.internal             Ready                      <none>   2d4h   v1.28.5-eks-5e0fdde
ip-192-168-9-118.us-west-2.compute.internal             Ready,SchedulingDisabled   <none>   2d4h   v1.28.5-eks-5e0fdde

The code for this handling can be seen in the printer columns logic for kubectl here.
This is nice visibility for users when Kubernetes is using this specific field; however, nothing is surfaced when Karpenter adds its taint and is actively draining the node since Karpenter doesn't update the spec.unschedulable field that the printer relies on to add the SchedulingDisabled section to the node.
It would be a really nice UX if we could add something similar to SchedulingDisabled (perhaps something like Disrupting or Terminating) to the node so that users get visibility through the printer that Karpenter is acting on the node.

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Also, as part of the alignment effort with Cluster Autoscaler, I imagine whatever change that we suggested should be made in upstream would also apply to Cluster Autoscaler. Perhaps aligning on the taint that we both want to use and proposing a way that that taint could have special logic built around it in the node printer columns is a change that we could try to get into upstream?
cc: @MaciekPytel

Also also, there was a discussion in the K8s Slack over whether Karpenter should be using the unschedulable field on the node to piggy-back on this logic or not. Practically, we have chosen to separate ourselves from the basic "cordon" handling for the following reasons:

We want to know that Karpenter was the one that initiated the tainting so that we can recover when we taint a node and the process gets killed (either due to crashing or upgrading)
We want to make sure that we can drain DaemonSets while draining the node if the user wants it (right now Kubernetes will add a tolerations to DaemonSets for the node.kubernetes.io/unschedulable taint by default)

I would like to note that other controllers are relying on the SchedulingDisabled-Taint to see if a node is shutting down or not.
The CloudNativePG operator for example has a PDB that disallows deleting the pod. If a node with a CNPG pod receives the SchedulingDisabled-Taint, the operator will start to migrate that pod itself. Since Karpenter does not use the taint, the node is stuck.

/remove-lifecycle stale

/remove-lifecycle stale

I understand and support the reasons for using the Karpenter specific taint, but it does break other things that look for the standard unschedulable taint. Would it be feasible to add both? So Karpenter would know it initiated the cordon, but also other controllers would be aware that the node has been cordoned and they should do what they need to do (failover, in the case of cloudnative-pg).

the operator will start to migrate that pod itself. Since Karpenter does not use the taint, the node is stuck

I think what we have seen in general is that these other operators support watching on the taint that the autoscaler supports. EBS CSI driver had done something similar since it was also hooking into knowledge that Karpenter was deleting the NodeClaim.
In general, I'm a little weary of things hooking into taints that can be added with a kubectl cordon from a user anyways since this might be added as a manual action and then you are going to get automation that's going to flywheel off of this


switch nginx proxy header Host

Nginx is acting as a reverse proxy. There it needs to take care to set/change some headers during the communication. I ran into an issue with LNbits that the port was stripped (while using IP2Tor). Changing the setting to use the $http_host should include both the hostname and the port from the initial request: https://stackoverflow.com/questions/15414810/whats-the-difference-of-host-and-http-host-in-nginx
This should not break any of the apps when using the Nginx port (either with or without Tor).
As mentioned in: https://github.com/rootzoll/raspiblitz/issues/1258#issuecomment-657225926

OK I think I ran into something similar with BTCPay Server ... it gave me this warning after I tried to login:

It fixed it :) hooray :D


Fix background colors for all screen

Criteria
Fix the background colors of all pages to match the content of that page.
Tasks

[x] Landing: adjust to correct yellow
[x] Canvas
[x] View Choodle page

Design Reference
Figma

confirmed ✅


chore: bump yaml version to v3.0.0

Purpose:

bump yaml.v3 version from v3.0.0-20220512140231-539c8e751b99 to v3.0.0

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
7 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.04%) to 77.185%

Files with Coverage Reduction
New Missed Lines
%

pkg/kusionctl/cmd/destroy/options.go
7
83.41%

Totals

Change from base Build<PHONE_NUMBER>:
0.04%

Covered Lines:
3745

Relevant Lines:
4852

💛  - Coveralls


Data format passes in TT-Forge

Data format passes aren't executing in the current TT-Forge -> MLIR. We should investigate and see how we want to handle data formats in the TT-Forge.

Closing this one as duplicate, more details explored in this issue:

https://github.com/tenstorrent/tt-forge-fe/issues/70


[BUG][brave-instrumentation-httpclient] TracingCachingHttpClientBuilder breaks http client caching

TracingCachingHttpClientBuilder's override of decorateMainExec fails to add a CacheExecution to the http client execution chain. This prevents http caching from working.
Here is a Wiremock test that reproduces the issue:
public class TracingCachingHttpClientBuilderTest extends ITHttp {

    @Rule
    public WireMockRule wireMockRule = new WireMockRule();

    private HttpTracing httpTracing= HttpTracing.create(tracingBuilder(Sampler.NEVER_SAMPLE).build());

    // Tracing builder breaks caching:
    @Test
    public void tracingCachingHttpClientShouldCacheResponse() throws Exception {
        String path = "/test/123";
        HttpClient httpClient = new TracingCachingHttpClientBuilder(httpTracing).build();

        stubFor(get(urlEqualTo(path))
                .willReturn(aResponse()
                        .withStatus(200)
                        .withHeader("Content-Type", "text/plain")
                        .withHeader("Cache-Control", "max-age=600, stale-while-revalidate=1200")
                        .withBody("Hello")));

        HttpGet httpGet = new HttpGet("http://localhost:8080" + path);

        httpClient.execute(httpGet);
        httpClient.execute(httpGet);

        verify(exactly(1), getRequestedFor(urlEqualTo(path)));
    }

    //Vanilla Apache builder is ok.
    @Test
    public void cachingHttpClientShouldCacheResponse() throws Exception {
        String path = "/test/123";
        HttpClient httpClient = CachingHttpClients.createMemoryBound();

        stubFor(get(urlEqualTo(path))
                .willReturn(aResponse()
                        .withStatus(200)
                        .withHeader("Content-Type", "text/plain")
                        .withHeader("Cache-Control", "max-age=600, stale-while-revalidate=1200")
                        .withBody("Hello")));

        HttpGet httpGet = new HttpGet("http://localhost:8080" + path);
        httpClient.execute(httpGet);
        httpClient.execute(httpGet);

        verify(exactly(1), getRequestedFor(urlEqualTo(path)));
    }
}

A simple fix like:
return new TracingMainExec(httpTracing, super.decorateMainExec(exec));
will lead to a span being started even when the request is served from the cache. If that's not desirable, then you'll probably need to subclass TracingMainExec, and avoid sending a span if HttpCacheContext.CACHE_RESPONSE_STATUS = CACHE_HIT.

Sure. What should we do if the response is served from the client's cache? Some options:

Add a tag, e.g. http.served_from_client_cache=true/false, that indicates that the response was served from the cache
Create a regular http client span (i.e. no cache tag)
Do not create a span

IMHO option 1 has the most utility. What rule do the other integrations follow?

I would create a child span but not mark it as a client span (kind = CLIENT)
On Mon, Feb 4, 2019, 8:51 AM Alex McCarthy<EMAIL_ADDRESS>wrote:

Sure. What should we do if the response is served from the client's cache?
Some options:

Add a tag, e.g. http.served_from_client_cache=true/false, that
indicates that the response was served from the cache
Create a regular http client span (i.e. no cache tag)
Do not create a span

IMHO option 1 has the most utility. What rule do the other integrations
follow?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/openzipkin/brave/issues/864#issuecomment-460157337,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD611DwuxYQZy9ZpdOa_lLcKdbHoeEGks5vJ-ZjgaJpZM4abkZD
.

What is the rationale for not setting the kind to Client? Is it because there is an expectation that every (successful) Client span has a corresponding Server span?
If the kind shouldn't be client, then what should it be? None of the others seem to fit. In the existing flow, TracingProtocolExec calls tracer.nextSpan(), which will create a new child span if a trace already exists - is this the child span that you were referring to? If so, then the HttpClientHandler will set the kind to Client at the same time as it starts the span. The kind cannot be set to null again at some point in the future (e.g. because we discovered that the response was served from the cache).

client is a remote span. span.kind clarifies the remote endpoint. so it
wouldnt make sense to pretend something we know is served locally is
actually remote.
it is possible that the code needs to be refactored to accommodate this.
On Tue, Feb 5, 2019, 3:42 PM Alex McCarthy<EMAIL_ADDRESS>wrote:

What is the rationale for not setting the kind to Client? Is it because
there is an expectation that every (successful) Client span has a
corresponding Server span?
If the kind shouldn't be client, then what should it be? None of the
others seem to fit. In the existing flow, TracingProtocolExec calls
tracer.nextSpan(), which will create a new child span if a trace already
exists - is this the child span that you were referring to? If so, then
the HttpClientHandler will set the kind to Client at the same time as it
starts the span. The kind cannot be set to null again at some point in the
future (e.g. because we discovered that the response was served from the
cache).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/openzipkin/brave/issues/864#issuecomment-460541522,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD61w7e2uTU5IpDkwxuFnihd4bfDENsks5vKTXPgaJpZM4abkZD
.

the implementation wasn't obvious so I spiked one here https://github.com/openzipkin/brave/pull/865


Make series creation scale better with number of cores

Adding a new user with ~15m series, saw the ingesters latency go through the roof.
Benchmarked series creation and saw it doesn't parallelise.   Made series creation scale better with number of cores (up to ~16 cores).
This is achieved by sharding many of the datastructures on the series creation path, such as the seriesMap, the inmemory index et
Graph of test run time vs parallelisation for 1 to 32 goroutines.  Test was run on a 32 vCPU-optimised droplet.

How did you pick the shard counts? Have you done any experimenting with tuning them?

A little thought, but not much:

metricCounterShards = 128 - only ever read or written by index, so little downside in having many
const indexShards = 32 - writes hit read on shards, reads all - so can't be too big or queries get bigger
const seriesMapShards = 128 - only ever  read or written by index, so little downside in having many

Thanks for the feedback @csmarchbanks!


Fix thickness problem with arc() and ellipse()

Fixes the problem when thickness is greater than 1, it occurs mainly with colors that have transparency.
The thickness of the Ellipse was being drawn inside, all other shapes are drawn in the center. If you think it is better to keep the thickness inside I can change it.
Before

After

Optimization of "border ()", without using "for ()".
The border can be drawn with a simple rectangle with thickness.
Uses less processing.

Thanks for your continued effort here. Just let me know when you're ready for this to be reviewed. 😄

Left
Right

Center
Justify

Leading +7
Leading -7

**Font Scriptina *
Font Queenstown Signature

Hello @claviska
The code is ready for review.
I have doubts about the best order for the parameters in the documentation.
As it got a little big, more than 200 lines, I thought it was better to separate the code in another file and use "trait". Can you tell me how you feel better.
/**
    * Adds text with a line break to the image.
    *
    * @param string $text The desired text.
    * @param array $options
    *    An array of options.
    *       - fontFile* (string) - The TrueType (or compatible) font file to use.
    *       - size (integer) - The size of the font in pixels (default 12).
    *       - color (string|array) - The text color (default black).
    *       - anchor (string) - The anchor point: 'center', 'top', 'bottom', 'left', 'right', 'top left', 'top right', 'bottom left', 'bottom right' (default 'center').
    *       - xOffset (integer) - The horizontal offset in pixels (default 0).
    *       - yOffset (integer) - The vertical offset in pixels (default 0).
    *       - shadow (array) - Text shadow params.
    *          - x* (integer) - Horizontal offset in pixels.
    *          - y* (integer) - Vertical offset in pixels.
    *          - color* (string|array) - The text shadow color.
    *       - $calcuateOffsetFromEdge (bool) - Calculate Offset referring to the edges of the image (default true).
    *       - width (int) - Width of text box (Default image width).
    *       - justify (string) - The justify: 'left', 'right', 'center', 'justify' (default 'left').
    *       - $leading (float) - Increase/decrease spacing between lines of text (default 0).
    *       - $opacity (float) - The opacity level of the text 0-1 (default 1).
    * @throws \Exception
    * @return \claviska\SimpleImage
    */

Only one thought: array_key_last() requires PHP 7 >= 7.3.0, but SimpleImage no.

@adaniello Thank you very much!!! I fixed it.


Create management command to "migrate" mappings

We'll need a system for aliases, and migrating to different indexes, and then updating the aliases.

This is done, it is sync_es.


fix(codegen): do not extract createVNode and Comment after hoist

Codegen was creating invalid code (redefinition of const) in function mode with hoists. Example of such code:
const _Vue = Vue
// _createVNode is extracted 👇 here
const _createVNode = Vue.createVNode

const _hoisted_1 = _createVNode("span", null, "hello world")

return function render() {
  with (this) {
    // It's extracted again 👇 here
    const { createVNode: _createVNode, createBlock: _createBlock, openBlock: _openBlock } = _Vue

    return (_openBlock(), _createBlock("div", null, [
      _hoisted_1
    ]))
  }
}

// Check the console for the AST

P.S. it's created from this code:

  hello world

with these options:

This should be kept, because the _createVNode inside the with block is faster (no with check to access it).

@yyx990803 isn't it a redefinition of variable?

It is, but the outer variable is only used for hoisted calls, and the inner is used by other non-hoisted calls. The inner variable still provides performance benefits for non-hoisted calls.

@yyx990803 won't it create an error?

It won't, it's just shadowing with the same function.


How to enable cors for /public

Environment
Nitro: v0.5.0
Node: 17.x.x
Production and Development
Reproduction
Fresh nitro project with one route and multiple public assets in /public dir
run dev or prod
Access the public asset using fetch in another FrontEnd project returns Access to fetch at https://xxxxx from origin https://xxx/img/test.svg has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.
Describe the bug
Cannot find any solution or documentation for this problem
Additional context
I've using this for adding cors support for all routes as below
// utils.ts

export const useHeaders = (res) => {
  appendHeader(res, 'Access-Control-Allow-Origin', '*')
  appendHeader(res, 'Access-Control-Allow-Headers', 'Content-Type')
  appendHeader(res, 'Access-Control-Allow-Methods', 'GET POST PUT DELETE OPTIONS')
  appendHeader(res, 'Access-Control-Allow-Credentials', 'true')
  appendHeader(res, 'Cache-Control', 'max-age=31536000, public')
}

// routes/index.get.ts

import { useHeaders } from '../utils'

export default eventHandler((event: CompatibilityEvent) => {
  useHeaders(event.res)
})

Logs
No response

Modify nitro.config.ts to enable CORS on development environment:
import { defineNitroConfig } from 'nitropack';
import { defineCorsEventHandler } from '@nozomuikuta/h3-cors'

export default defineNitroConfig({
  devHandlers: [{
    route: '/',
    handler: defineCorsEventHandler({})
  }],
});

You can use route rules to enabled cors (https://v3.nuxtjs.org/guide/concepts/rendering#route-rules)

It`s invalid with webpack builder.
------------------ 原始邮件 ------------------
发件人:                                                                                "unjs/nitro"                                                                                @.>;
发送时间: 2022年10月21日(星期五) 下午4:17
@.>;
<EMAIL_ADDRESS>主题: Re: [unjs/nitro] How to enable cors for /public (Issue #539)
You can use route rules to enabled cors (https://v3.nuxtjs.org/guide/concepts/rendering#route-rules)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

You can use route rules to enable cors: https://nitro.unjs.io/config#routerules

'/*': { cors: true, headers: { 'access-control-allow-methods': 'OPTIONS,POST' } },
it did not work.

@TangsWang There is an open issue with cors. In short: If you have a route that only has post/put/delete but no catch all handler (e.g. index.ts or products.ts), cors is not working because the router does not catch the preflight request.
https://github.com/nitrojs/nitro/issues/2340


recovery original style sheets

Description
crashed style sheets by issue #2266
so we restored the style sheet
restored 5 css files from commit 2e236028b to commit a8cb97f1b
discovery-frontend/src/assets/css/polaris.v2.component.css
discovery-frontend/src/assets/css/polaris.v2.layout.css
discovery-frontend/src/assets/css/polaris.v2.page.css
discovery-frontend/src/assets/css/metatron/polaris.metatron.page.css
discovery-frontend/src/assets/css/metatron/component/component.tag.css
Related Issue :
#2266
How Has This Been Tested?
check the pages of discovery-frontend globally
Need additional checks?
issue #2008 is affected.
we will be check it.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have added tests to cover my changes.

Additional Context

run build
deploy to 5


Gravatar http(s)

Gravatars are linked on http which ends up as ssl warnings in browser if https is used.
Would it be possible to add the protocol identification and use https://gravatar.com ... if ssl is used on site?

Done!
From now you can also access avatar url by using getAvatarUrl method of Profile model:
\Yii::$app->user->identity->profile->getAvatarUrl();
// or you can specify size of avatar
\Yii::$app->user->identity->profile->getAvatarUrl(150);

Thank you!


[doc] Small improvements to unit testing and precommit sections

As the title.

@pyansys-ci-bot LGTM


CI: Only install components when needed.

Nightly pipeline is failing on missing rustfmt, but we don't actually need it except for the beta version.

This change is

Feel free to ignore if you're not interested.
I noticed that the CI pipelines will fail when either clippy or rustfmt can't be installed on nightly, and this means you have to go look at why the pipeline failed on PRs and that's probably a bit annoying when it's just that rustfmt isn't available for nightly today. But the pipeline only actually uses clippy and rustfmt on the 'beta' toolchain, so missing those components on nightly is irrelevant.
So this moves the install of the rustfmt and clippy components into the pipeline step that needs them. I originally tried doing this by specifying the components with the matrix elements, but Azure variables can't be arrays so that doesn't work.
Anyway, not sure if this is something you want, but if so maybe it's handy for you.

Oh, yes, this is great, thank you!


🐛 [Bug] Torch-TensorRT do not support gpt2

Bug Description
ERROR: [Torch-TensorRT] - Unsupported operator: aten::where.self(Tensor condition, Tensor self, Tensor other) -> (Tensor)
/opt/conda/lib/python3.8/site-packages/transformers/models/gpt2/modeling_gpt2.py(206): _attn
/opt/conda/lib/python3.8/site-packages/transformers/models/gpt2/modeling_gpt2.py(336): forward
/opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py(1090): _slow_forward
/opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py(1102): _call_impl
/opt/conda/lib/python3.8/site-packages/transformers/models/gpt2/modeling_gpt2.py(395): forward
/opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py(1090): _slow_forward
/opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py(1102): _call_impl
/opt/conda/lib/python3.8/site-packages/transformers/models/gpt2/modeling_gpt2.py(890): forward
/opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py(1090): _slow_forward
/opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py(1102): _call_impl
/opt/conda/lib/python3.8/site-packages/transformers/models/gpt2/modeling_gpt2.py(1047): forward
/opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py(1090): _slow_forward
/opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py(1102): _call_impl
/opt/conda/lib/python3.8/site-packages/torch/jit/_trace.py(958): trace_module
/opt/conda/lib/python3.8/site-packages/torch/jit/_trace.py(741): trace
<stdin>(1): <module>

ERROR: [Torch-TensorRT] - Unsupported operator: aten::Int.Tensor(Tensor a) -> (int)

ERROR: [Torch-TensorRT] - Unsupported operator: aten::ScalarImplicit(Tensor a) -> (Scalar)

ERROR: [Torch-TensorRT] - Unsupported operator: aten::where.self(Tensor condition, Tensor self, Tensor other) -> (Tensor)
/opt/conda/lib/python3.8/site-packages/transformers/models/gpt2/modeling_gpt2.py(206): _attn
/opt/conda/lib/python3.8/site-packages/transformers/models/gpt2/modeling_gpt2.py(336): forward
/opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py(1090): _slow_forward
/opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py(1102): _call_impl
/opt/conda/lib/python3.8/site-packages/transformers/models/gpt2/modeling_gpt2.py(395): forward
/opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py(1090): _slow_forward
/opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py(1102): _call_impl
/opt/conda/lib/python3.8/site-packages/transformers/models/gpt2/modeling_gpt2.py(890): forward
/opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py(1090): _slow_forward
/opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py(1102): _call_impl
/opt/conda/lib/python3.8/site-packages/transformers/models/gpt2/modeling_gpt2.py(1047): forward
/opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py(1090): _slow_forward
/opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py(1102): _call_impl
/opt/conda/lib/python3.8/site-packages/torch/jit/_trace.py(958): trace_module
/opt/conda/lib/python3.8/site-packages/torch/jit/_trace.py(741): trace
<stdin>(1): <module>

ERROR: [Torch-TensorRT] - Unsupported operator: aten::Int.Tensor(Tensor a) -> (int)

ERROR: [Torch-TensorRT] - Unsupported operator: aten::ScalarImplicit(Tensor a) -> (Scalar)

WARNING: [Torch-TensorRT] - Input type for doing shape analysis could not be determined, defaulting to F32
WARNING: [Torch-TensorRT] - Truncating graph input type from at::kLong to at::kInt
WARNING: [Torch-TensorRT] - Truncating graph input type from at::kLong to at::kInt
WARNING: [Torch-TensorRT] - Truncating graph input type from at::kLong to at::kInt
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/opt/conda/lib/python3.8/site-packages/torch_tensorrt/_compile.py", line 115, in compile
    return torch_tensorrt.ts.compile(ts_mod, inputs=inputs, enabled_precisions=enabled_precisions, **kwargs)
  File "/opt/conda/lib/python3.8/site-packages/torch_tensorrt/ts/_compiler.py", line 119, in compile
    compiled_cpp_mod = _C.compile_graph(module._c, _parse_compile_spec(spec))
RuntimeError: The following operation failed in the TorchScript interpreter.
Traceback of TorchScript (most recent call last):
/opt/conda/lib/python3.8/site-packages/torch/nn/functional.py(2047): embedding
/opt/conda/lib/python3.8/site-packages/torch/nn/modules/sparse.py(158): forward
/opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py(1090): _slow_forward
/opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py(1102): _call_impl
/opt/conda/lib/python3.8/site-packages/transformers/models/gpt2/modeling_gpt2.py(833): forward
/opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py(1090): _slow_forward
/opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py(1102): _call_impl
/opt/conda/lib/python3.8/site-packages/transformers/models/gpt2/modeling_gpt2.py(1047): forward
/opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py(1090): _slow_forward
/opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py(1102): _call_impl
/opt/conda/lib/python3.8/site-packages/torch/jit/_trace.py(958): trace_module
/opt/conda/lib/python3.8/site-packages/torch/jit/_trace.py(741): trace
<stdin>(1): <module>
RuntimeError: Expected tensor for argument #1 'indices' to have one of the following scalar types: Long, Int; but got CUDAFloatType instead (while checking arguments for embedding)

To Reproduce
import torch
from transformers import GPT2Tokenizer, GPT2LMHeadModel
import torch_tensorrt

tokenizer = GPT2Tokenizer.from_pretrained('gpt2')
model = GPT2LMHeadModel.from_pretrained('gpt2', return_dict=False)
model.eval()

tokens=tokenizer('The cat is on the table.', return_tensors='pt')['input_ids']
traced_model = torch.jit.trace(model, tokens)

compile_settings = {
        "inputs": [torch_tensorrt.Input(
            # min_shape=[1, 3, 224, 224],
            # opt_shape=[1, 3, 512, 512],
            # max_shape=[1, 3, 1024, 1024],
            # For static size
            shape=[1, 7],
            dtype=torch.int32,# Datatype of input tensor. Allowed options torch.(float|half|int8|int32|bool)
        )],
        "truncate_long_and_double": True,
        "enabled_precisions": {torch.half}  # Run with FP16
    }
trt_model = torch_tensorrt.compile(traced_model, **compile_settings)

Expected behavior
No error
Environment
docker build --build-arg BASE=21.10 -f docker/Dockerfile -t torch_tensorrt:latest .

Torch-TensorRT Version (e.g. 1.0.0):
PyTorch Version (e.g. 1.0):
CPU Architecture:
OS (e.g., Linux):
How you installed PyTorch (conda, pip, libtorch, source):
Build command you used (if compiling from source):
Are you using local sources or building from archives:
Python version:
CUDA version:
GPU models and configuration:
Any other relevant information:

so do it really means torch_tensorrt not support gpt2 or I did something wrong ？

Is there anyone can help me ? many thanks

Response from the other thread since I am going to close it in favor of this one:

First thing I would try is to make sure your model is on GPU before compiling. These errors about op support may be misleading if partial compilation is enabled (which it is by default). But the Runtime error from PyTorch is caused by tensors not being on the same device. I think from there, you should be able to run, if not, we have dedicated support for some cases of aten::Int coming, as well as we can look at adding support for where.self

Response from the other thread since I am going to close it in favor of this one:

First thing I would try is to make sure your model is on GPU before compiling. These errors about op support may be misleading if partial compilation is enabled (which it is by default). But the Runtime error from PyTorch is caused by tensors not being on the same device. I think from there, you should be able to run, if not, we have dedicated support for some cases of aten::Int coming, as well as we can look at adding support for where.self

I make sure to put model on GPU and tokens as well, it still comes the same error, please help and check the demo below, many thanks!
import torch
from transformers import GPT2Tokenizer, GPT2LMHeadModel
import torch_tensorrt

tokenizer = GPT2Tokenizer.from_pretrained('gpt2')
model = GPT2LMHeadModel.from_pretrained('gpt2', return_dict=False).cuda()
model.eval()

tokens=tokenizer('The cat is on the table.', return_tensors='pt')['input_ids'].cuda()
traced_model = torch.jit.trace(model, tokens)

compile_settings = {
        "inputs": [torch_tensorrt.Input(
            # min_shape=[1, 3, 224, 224],
            # opt_shape=[1, 3, 512, 512],
            # max_shape=[1, 3, 1024, 1024],
            # For static size
            shape=[1, 7],
            dtype=torch.int32,# Datatype of input tensor. Allowed options torch.(float|half|int8|int32|bool)
        )],
        "truncate_long_and_double": True,
        "enabled_precisions": {torch.half}  # Run with FP16
    }
trt_model = torch_tensorrt.compile(traced_model, **compile_settings)

@Biaocsu I tried your setup and got the error:
RuntimeError                              Traceback (most recent call last)
Input In [36], in <cell line: 1>()
----> 1 trt_ts_module = torch_tensorrt.compile(
      2     traced_model,
      3     inputs=[torch_tensorrt.Input(
      4 #             min_shape=[1, 1],
      5 #             opt_shape=[1, 32],
      6 #             max_shape=[1, 64],
      7             shape=[1, 7],
      8             dtype=torch.int32,
      9         )],
     10     enabled_precisions={torch.half},
     11     truncate_long_and_double=True,
     12     torch_executed_ops=['aten::where'],
     13     require_full_compilation=False
     14 )

File /opt/conda/lib/python3.8/site-packages/torch_tensorrt/_compile.py:115, in compile(module, ir, inputs, enabled_precisions, **kwargs)
    110         logging.log(
    111             logging.Level.Info,
    112             "Module was provided as a torch.nn.Module, trying to script the module with torch.jit.script. In the event of a failure please preconvert your module to TorchScript"
    113         )
    114         ts_mod = torch.jit.script(module)
--> 115     return torch_tensorrt.ts.compile(ts_mod, inputs=inputs, enabled_precisions=enabled_precisions, **kwargs)
    116 elif target_ir == _IRType.fx:
    117     raise RuntimeError("fx is currently not supported")

File /opt/conda/lib/python3.8/site-packages/torch_tensorrt/ts/_compiler.py:116, in compile(module, inputs, device, disable_tf32, sparse_weights, enabled_precisions, refit, debug, strict_types, capability, num_min_timing_iters, num_avg_timing_iters, workspace_size, calibrator, truncate_long_and_double, require_full_compilation, min_block_size, torch_executed_ops, torch_executed_modules)
     89     raise ValueError(
     90         "require_full_compilation is enabled however the list of modules and ops to run in torch is not empty. Found: torch_executed_ops: "
     91         + torch_executed_ops + ", torch_executed_modules: " + torch_executed_modules)
     93 spec = {
     94     "inputs": inputs,
     95     "device": device,
   (...)
    113     }
    114 }
--> 116 compiled_cpp_mod = _C.compile_graph(module._c, _parse_compile_spec(spec))
    117 compiled_module = torch.jit._recursive.wrap_cpp_module(compiled_cpp_mod)
    118 return compiled_module

RuntimeError: [Error thrown at core/partitioning/shape_analysis.cpp:127] Unsupported input data type unsigned char

Seems like HF implementation uses byte datatype, which may not be supported?

@calclavia not sure.
I tried pytorch -> onnx -> tensorrt method , and find tensorrt do not support NonZero  operation
anyway, I do not success convert gpt2 by torch_tensorrt

I encountered the same error while testing nvcr.io/nvidia/pytorch:22.12-py3. Is this bug really fixed? @Biaocsu were you able to convert from gpt2 to torch_tensorrt?

Hi, I face the same issues when I try to compile the GPT2 into the tensorrt format.
The corresponding environments:
ubuntu 22.04

Driver Version: 515.65.01
CUDA Version: 11.7
GPU: rtx 3090

torch == 1.13.1+cu117
torch_tensorrt == 1.3.0
transformer == 4.25.1

The sample code to produce the error:
tokens=tokenizer('The cat is on the table.', return_tensors='pt')
for k in tokens.keys():
    tokens[k] = tokens[k].cuda()

tokenizer = GPT2Tokenizer.from_pretrained('gpt2')
gpt2_model = GPT2LMHeadModel.from_pretrained('gpt2', return_dict=False, torchscript=True)
gpt2_model.eval()
gpt2_model.cuda()

traced_gpt2_model = torch.jit.trace(gpt2_model, tokens["input_ids"])

trt_gpt2_model = torch_tensorrt.compile(traced_gpt2_model,
    inputs= [torch_tensorrt.Input(shape=[batch_size, 7], dtype=torch.int32)], # Input ids
    enabled_precisions= {torch.float32}, # Run with 32-bit precision
    workspace_size=2000000000,
    truncate_long_and_double=True
)

Can anyone compile the GPT2 successfully?


twister: ztest: harness: Fix missed TestCase statuses

Fix a problem of Ztest suite names not taken into account by Twister to identify a TestCase, so in some situations a Ztest test's status was not assigned to the proper TestCase and it remains 'None' whereas the actual status value lost, eventually the resulting total execution counters not correct.
The proposed solution extends Twister test case name for Ztest to include Ztest suite name, so the resulting identifier looks like:   <test_scenario_name>.<ztest_suite_name>.<ztest_name>
The above naming scheme now requires ztest_suite_name part to be provided for --sub-test command line option.
Testcase identifiers in twister.json and testplan.json will also include ztest_suite_name component.
The Twister Ztest(Test) Harness is improved to track all state changes known from the test application's log for Ztest suites and test cases, so now it parses log output from a Ztest application more scurpulously. Regular expressions to match log records are extended and optimized to compile them only once and, in some cases, fixed (suite summary).
The issue was observed in these situations:

Ztest application with multiple test suites having same test names.

for example, /scripts/twister -p native_sim -T ./tests/ztest
old:
testing.ztest.summary.shared_unit_test.foo                                  SKIPPED     ztest skip
testing.ztest.summary.shared_unit_test.foo                                  NONE
...
testing.ztest.error_hook.no_userspace.to_skip0                              PASSED
testing.ztest.error_hook.no_userspace.to_skip1                              PASSED
testing.ztest.error_hook.no_userspace.to_skip0                              NONE
testing.ztest.error_hook.no_userspace.to_skip1                              NONE

new:
testing.ztest.summary.shared_unit_test.suite2.foo                           SKIPPED     ztest skip
testing.ztest.summary.shared_unit_test.suite1.foo                           PASSED

testing.ztest.error_hook.no_userspace.fail_assume_in_setup.to_skip0         PASSED
testing.ztest.error_hook.no_userspace.fail_assume_in_setup.to_skip1         PASSED
testing.ztest.error_hook.no_userspace.fail_assume_in_before.to_skip0        PASSED
testing.ztest.error_hook.no_userspace.fail_assume_in_before.to_skip1        PASSED

Ztest suite is 'skipped' entirely on execution with all its tests.

for example, ./scripts/twister -p native_sim -T ./tests/drivers/can/api/ -s drivers.can.api
where get_transceiver - was skipped, others - the same situation as example 1
old:
drivers.can.api.get_transceiver                                             NONE
drivers.can.api.invalid_sample_point                                        PASSED
drivers.can.api.set_bitrate_too_high                                        PASSED
drivers.can.api.invalid_sample_point                                        NONE
drivers.can.api.set_bitrate_too_high                                        NONE

new:
drivers.can.api.can_transceiver.get_transceiver                             SKIPPED ztest skip
drivers.can.api.can_classic.invalid_sample_point                            PASSED
drivers.can.api.can_classic.set_bitrate_too_high                            PASSED
drivers.can.api.canfd.invalid_sample_point                                  PASSED
drivers.can.api.canfd.set_bitrate_too_high                                  PASSED

Twister documentation page update #80103

@arikgreen, do you still have any other objections for your -1 ?

@arikgreen, do you still have any other objections for your -1 ?

sorry, should be approved

rebase to resolve merge conflicts

The proposed solution extends Twister test case name for Ztest to include Ztest suite name, so the resulting identifier looks like: <test_scenario_name>.<ztest_suite_name>.<ztest_name>

ok, this is a rather very intrusive and disruptive change of a very well known problem that we pushed aside for a while now.
The main issue here is that we define suites on different levels, the outcome of transitioning from old ztest to macro based ztest.
We have the testsuite defined at the yaml level and then the suites in ztests, so when you have multiple suites in ztest resuing the same testcases, it faills apart, but that happens in a pair for tests we have right now, so it was easy to ignore.
Some changes in twister were introduced to address this, but never got to the final fix.
I am fine with the fix, the question if it is the right time for it or if we should wait and solicit more discussion and reviews to make sure this does not break someone's downstream.

a rather very intrusive and disruptive change of a very well known problem that we pushed aside for a while now.
.. the question if it is the right time for it or if we should wait and solicit more discussion and reviews to make sure this does not break someone's downstream.

well, although 'very intrusive and disruptive' sounds ominously, it is another old problem, like adjusting to hwmv2 board naming, which should be fixed. Why not to do it "sooner", at .0 minor version release ?

Dear reviewers, do you find any objections on this fix for a very well known old problem in Twister, preventing its solution in v.4.0 ?

@golowanow please post the list of tests that are showing this behaviour.

please post the list of tests that are showing this behaviour.

The known in-tree tests affected by the problem are now listed in #80706 (will be updated when we find more).
Other changes so far:

rebased to run CI tests with the latest Twister changes.
documentation from #80103 is now included into this PR as suggested in its review.

dear reviewers, ^ up to your attention.

@golowanow I meet some suspect issues with this pr. if I run
scripts/twister -p frdm_k64f -T samples -T tests

and I get a very long time in compare to the main branch code, and the log shows some warning
WARNING - Unexpected Ztest suite 'test_ipm'
WARNING - Already STARTED 'wdt_basic_test_suite':{'count': 1, 'repeat': 0}
WARNING - Already STARTED 'drivers.watchdog.wdt_basic_test_suite.wdt':{'count': 1}
WARNING - Already STARTED 'wdt_basic_test_suite':{'count': 2, 'repeat': 1}
WARNING - Already STARTED 'drivers.watchdog.wdt_basic_test_suite.wdt':{'count': 2}
WARNING - END  case 'crypto.tinycrypt.tinycrypt_test_cbc_sp_800_38a_encrypt_decrypt' without START detected
WARNING - END  case 'crypto.tinycrypt.tinycrypt_test_ccm_vector_8' without START detected
WARNING - END  case 'crypto.tinycrypt.verify_gf_2_128_double' without START detected
WARNING - END  case 'crypto.tinycrypt.verify_cmac_null_msg' without START detected
WARNING - END  case 'crypto.tinycrypt.verify_cmac_1_block_msg' without START detected
WARNING - END  case 'crypto.tinycrypt.verify_cmac_320_bit_msg' without START detected
WARNING - END  case 'crypto.tinycrypt.verify_cmac_512_bit_msg' without START detected

I meet some suspect issues with this pr. if I run
...
and I get a very long time in compare to the main branch code, and the log shows some warning
WARNING - Unexpected Ztest suite 'test_ipm'
WARNING - Already STARTED 'wdt_basic_test_suite':{'count': 1, 'repeat': 0}
WARNING - Already STARTED 'drivers.watchdog.wdt_basic_test_suite.wdt':{'count': 1}
WARNING - Already STARTED 'wdt_basic_test_suite':{'count': 2, 'repeat': 1}
WARNING - Already STARTED 'drivers.watchdog.wdt_basic_test_suite.wdt':{'count': 2}
WARNING - END  case 'crypto.tinycrypt.tinycrypt_test_cbc_sp_800_38a_encrypt_decrypt' without START detected
...

right, these warnings (from 3 tests) are good examples of how this PR allows to spot two kinds of problems not visible before:
1.1) crypto.tinycrypt - the test has a bug and I've created its fix already #80793
1.2) Unexpected Ztest suite 'test_ipm' - is another test's bug #81032 (I've mentioned it yesterday during the Testing WG meeting).
2) drivers.watchdog.wdt_basic_test_suite. - this Ztest is a bit unusual as it restarts its suite recursively so the improved Ztest harness counts that when it sorts out the sequence of START/END events in the log and detects some 'strange' situations.
I left these log records as warnings for now to make such situations visible. The proposed PR addresses the basic level of the Twister/Ztest problems, and the next step will be to improve Twister reporting to show the Suite/Case repetitions correctly.

rebased to resolve merge conflicts after #81129

^ @PerMac @nashif

@PerMac  @golowanow before we go forward with this i wanted to discuss enabling --no-detailed-test-id by default, this way we will change how test data is captured and named in one go.

i wanted to discuss enabling --no-detailed-test-id by default, this way we will change how test data is captured and named in one go.

yeah, it might be a next 'disruptive' change, and I can make a draft for it as a separate PR.
This fix has its scope intentionally reduced to focus on the problem it is targeting.
One aspect of detailed-id change to discuss might be to control TestSuite.id prefix presence in testcase.identifier as well.


Establish basic safeguards to ensure docs don't outdate too quickly

Since we still work on API changes in Java, fix the Python SDK, and modify the CLI, our separate system of docs using gitbook turns bad quicker than sushi on a warm summer day.
At least for the Python part of the docs I created a docs folder to host basic markdown files that can be synced with gitbook. Also, I'd like to propose to use doctest to do smoke tests on examples listed there, so that at least the API is up to date. with proper git tag management we could even ensure intact examples for different API versions etc.
https://github.com/KonduitAI/konduit-serving/tree/master/python/docs
the docs folder also gives us a place to structure our thoughts and collect what users really need to get started. I fear that otherwise we end up with a random collection of unrelated articles skil-style.

Maybe we can also utilize what Alex has created for dl4j for docs management. We can also make this part of our CI that triggers events like creating issues for outdated docs.

This has been implemented. @maxpumperla mind linking the fix? I will close this.

I think this was it: https://github.com/KonduitAI/konduit-serving/pull/83


add custom predictor example : gpu parallel inference

Proposed Changes

I added it because I thought it would be good to have an example of applying parallel inference to gpu.

Thanks @park12sj !
/lgtm
/approve


docs: use @zeabur/astro-adapter for SSR on Zeabur

Description (required)
Since Zeabur has announced our official adapter package for Astro, this PR updates the documentation to instruct developers on using @zeabur/astro-adapter for SSR on Zeabur.

Related issues & labels (optional)

Closes #
Suggested label:

First-time contributor to Astro Docs?
Yes
If you are a member of the Astro Discord, please add your username in the description so we can welcome you there!
yuanlin

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉
Here’s what will happen next:

Our GitHub bots will run to check your changes.
If they spot any broken links you will see some error messages on this PR.
Don’t hesitate to ask any questions if you’re not sure what these mean!

In a few minutes, you’ll be able to see a preview of your changes on Vercel 🥳

One or more of our maintainers will take a look and may ask you to make changes.
We try to be responsive, but don’t worry if this takes a few days.


Add Connor Dowson to Contributors list

@connordowson, I'm quite elated about your PR. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I merged it?


VIES by European Commission (Independent Publisher)

This is my first time I tried writing custom code, but it works! Please, let me know if its ok.
I had to do it, because VIES service works only via SOAP, so I had to create code that forwards request to SOAP and returns results.

When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)

[X] I attest that the connector works and I verified by deploying and testing all the operations.
[X] I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
[X] I attest that I have added response schemas to my actions, unless the response schema is dynamic.
[X] I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
[X] If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

[X] I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
[X] Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
[X] Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
[X] If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

[[certify-connector]]

Hi, what do you mean by "For example, for this method, you can create a simple connector for europa.eu and use the output from the connector in this field."? I can't find any information about endpoints available at europa.eu site :( and VAT validation is available only via SOAP.
Why weren't there any warnings/ error messages saying that web/http clients are not allowed? Code was validated successfully and all tests went fine.
Unfortunately I am can't build a self managed functions app, as this would mean I will be using my subscription to handle everyone's requests?
Finally, I'm not the owner of the backend API.
Does it mean this connector is going to be rejected?
Best regards,
Tomasz Poszytek
e-mail: @.***
tel: +48 603 993 372
www/ blog: https://poszytek.eu
twitter: @TomaszPoszytek

From: Srikanth Yenagandhula @.>
Sent: Wednesday, January 5, 2022 11:47:50 PM
To: microsoft/PowerPlatformConnectors @.>
Cc: Tomasz Poszytek @.>; Mention @.>
Subject: Re: [microsoft/PowerPlatformConnectors] VIES by European Commission (Independent Publisher) (PR #1307)
@sriyen-msft requested changes on this pull request.

In independent-publisher-connectors/VIES by European Commission/script.csxhttps://github.com/microsoft/PowerPlatformConnectors/pull/1307#discussion_r779188071:

}

private async Task HandleForwardOperation()
{

   HttpResponseMessage response;

   var requestBody = await this.Context.Request.Content.ReadAsStringAsync().ConfigureAwait(false);

   var data = JObject.Parse(requestBody);

   var countryCode = ((string)data["countryCode"]).Trim();

   var vatNumber = ((string)data["vatNumber"]).Trim().Replace(" ", string.Empty).Replace("-", string.Empty).Replace(".", string.Empty);

   var url = "http://ec.europa.eu/taxation_customs/vies/services/checkVatService";

   var xml = @"<s:Envelope xmlns:s='http://schemas.xmlsoap.org/soap/envelope/'><s:Body><checkVat xmlns='urn:ec.europa.eu:taxud:vies:services:checkVat:types'><countryCode>"+countryCode+"</countryCode><vatNumber>"+vatNumber+"</vatNumber></checkVat></s:Body></s:Envelope>";

   try

   {

       using (var client = new WebClient())

@tposzytekhttps://github.com/tposzytek I came to know this during preparing your connector for production deployment that - The creation of an HTTP client is not allowed in custom code in any form either using HTTPClient or WebClient. While we work to find a safe way to achieve some of the functionality, we ask you to explore alternate ways to achieve similar functionality. For example, for this method, you can create a simple connector for europa.eu and use the output from the connector in this field. Alternatively, you can either create a self-managed functions app to do the same. Thirdly, if you are the owner of the backend API you do similar work in your backend.
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/PowerPlatformConnectors/pull/1307#pullrequestreview-845135154, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMCPVG5EVSITGV2A5GNJ75TUUTDBNANCNFSM5JNH5VJQ.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID: @.***>

@tposzytek Apologies for the inconvenience, Since it security-related issue which we recently found in the platform, we are actively working on updating all the tools to block Webclient and HttpClient references in the connector artifacts.
As of now, we can not move forward with your submission, but we can keep your submission on hold and will explore if we find anything alternatives. Thank you so much.

Hey, thanks! In that case please out it on hold and let me know when there are any alternatives to make secure soap requests. Have a good day!
Best regards,
Tomasz Poszytek
e-mail: @.***
tel: +48 603 993 372
www/ blog: https://poszytek.eu
twitter: @TomaszPoszytek

From: Srikanth Yenagandhula @.>
Sent: Friday, January 7, 2022 2:21:34 AM
To: microsoft/PowerPlatformConnectors @.>
Cc: Tomasz Poszytek @.>; Mention @.>
Subject: Re: [microsoft/PowerPlatformConnectors] VIES by European Commission (Independent Publisher) (PR #1307)
@tposzytekhttps://github.com/tposzytek Apologies for the inconvenience, Since it security-related issue which we recently found in the platform, we are actively working on updating all the tools to block Webclient and HttpClient references in the connector artifacts.
As of now, we can not move forward with your submission, but we can keep your submission on hold and will explore if we find anything alternatives. Thank you so much.
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/PowerPlatformConnectors/pull/1307#issuecomment-1007063903, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMCPVGZK24AYP32HEW23YWTUUY5Z5ANCNFSM5JNH5VJQ.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID: @.***>

Dear partner,
We apologize for the delay you might be experiencing while we are working on a high volume of connector requests. Rest assured that we are doing everything we can to address this volume. We are taking measures like improving our processes and hiring additional team members to guarantee resolving your connector requests in a timely manner.
Please let us know if you have any questions in the meantime.

Hello @tposzytek,
I hope you are doing well.
Apologies for the delay in the process, we will move forward with the connector as is.
Congratulations, your connector is approved. We will move forward with the certification process. We are preparing your connector for production deployment and will queue up for the next deployment schedule. Once your connector onboards the next deployment schedule, it starts to deploy your connector in our production environments that typically takes 3-4 weeks.
Please let us know if you have any questions.
Thank you very much for working with us.

[[certify-connector]]

@tposzytek Congratulations! The deployment of your connector and documentation page is now complete, We have a short survey on the connector certification process that we would like for you to complete. Your feedback is appreciated and will help us improve the program, Thanks.


Restoration of a deleted location

Currently, one can still view the deleted location via Latest-list. There should be a restore feature instead of non-functioning Delete button.

Maybe there should also be an optional text field for the reason of deletion. The deletion will draw attention from other users and they will wonder why the location was deleted.


added suggested_key 'Alt+Shift+P'

Hi, I don't know why travis-ci fail, can you help me?
The message:

No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself.
The build has been terminated


Feature: Document how to determine a user ID

Summary
This PR adds a description about how one can find a user's ID.  We show how this can be done in three ways:

Through the System Console as a Mattermost admin

Using the API (is this possible?)

Using the mmctl

The place for where this was added is under Use Mattermost Connect And Collaborate Learn More About Mattermost Roles.
Ticket Link
Fixes #6592

Hello @TomerPacific,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@cwarnermm - It was kind of hard to understand from what you highlighted here what you wanted removed, so  I removed what seemed logical to me.


Fixing lucene gfsh bugs

If an index is created on an existing region, an exception is thrown, but the index is still stored in definedIndexMap. This is fixed by removing the index definition before the exception is thrown. Added a test to verify
Previously, the describe/search index gfsh command on definied indexes returned an exception. Changed the behavior to return a message. Added dunit test to verify
Changed Search index command to "search lucene" (previously "lucene search")

+1


set session variable to default

Is your feature request related to a problem? Please describe.
https://www.postgresql.org/docs/current/sql-set.html
dev=> show batch_parallelism;
 batch_parallelism
-------------------
 0
(1 row)

dev=> set batch_parallelism to 3;
SET_VARIABLE
dev=> show batch_parallelism;
 batch_parallelism
-------------------
 3
(1 row)

dev=> set batch_parallelism to default;
ERROR:  QueryError: Invalid value ["DEFAULT"] for ["BATCH_PARALLELISM"]
dev=> set batch_parallelism to 'default';
ERROR:  QueryError: Invalid value ["default"] for ["BATCH_PARALLELISM"]
dev=> set batch_parallelism to "default";
ERROR:  QueryError: Invalid value ["default"] for ["BATCH_PARALLELISM"]

Describe the solution you'd like
No response
Describe alternatives you've considered
No response
Additional context
No response

I feel that being able to revert to the previous configuration is also useful

#10786