SyntaxError: Named export 'parseCIDR' not found.

$ npm i @linode/api-v4

script.mjs:
#!/usr/bin/env node
import {setToken} from '@linode/api-v4';

Running script.mjs fails:
$ chmod 755 script.mjs
$ ./script.mjs
file:///home/laci/projects/ugl-scripts/node_modules/@linode/validation/lib/esm/index.js:219
import { parse as parseIP, parseCIDR } from "ipaddr.js";
                           ^^^^^^^^^
SyntaxError: Named export 'parseCIDR' not found. The requested module 'ipaddr.js' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from 'ipaddr.js';
const { parse: parseIP, parseCIDR } = pkg;

    at ModuleJob._instantiate (node:internal/modules/esm/module_job:123:21)
    at async ModuleJob.run (node:internal/modules/esm/module_job:189:5)
    at async Promise.all (index 0)
    at async ESMLoader.import (node:internal/modules/esm/loader:533:24)
    at async loadESM (node:internal/process/esm_loader:91:5)
    at async handleMainPromise (node:internal/modules/run_main:65:12)

I'm using @linode/api-v4 0.85.0 with node 16.17.1
Any ideas?

Thank you for submitting this issue. We are working on a solution.
This is related to and duplicates #8675

We have fixed this issue by publishing @linode/validation v0.17.1, which is a dependency of @linode/api-v4.


Add support for fuzz-testing

This PR bundles all the changes necessary to perform fuzz-testing.

It introduces a cmake and conan setting called WITH_FUZZING which switches the codebase into fuzzing-mode.
In fuzzing mode, all targets are compiled except OrbitQt (so it deviates from the WITH_GUI mode).
Some fundemental behaviour changes to the codebase have been necessary, so they are all guarded by #ifdef WITH_FUZZING.
Changes have been: The LOG macros don't output anything. The CHECK macros do throw instead of aborting.
Some APIs needed extra overloads to be able to read data from a buffer. This includes CaptureSerializer's and ElfFile's methods.
The OrbitService target was splitted into two targets OrbitService and OrbitServiceLib. OrbitServiceLib contains all the compilation units from the previous OrbitService excluding main.cpp. Thus the tcp-server fuzz test can link against OrbitServiceLib and instantiate OrbitAsioServer.

Please let me know if you think these changes are too intrusive at some point. I can try to make them less intrusive. Of course I'm open to suggestions here as well.

The changes to CaptureSerializer.cpp are hard to grasp due to white-space changes. Here is a diff generated with the --ignore-white-space option:
diff --git a/OrbitGl/CaptureSerializer.cpp b/OrbitGl/CaptureSerializer.cpp
index da592fe5..dc91280d 100644
--- a/OrbitGl/CaptureSerializer.cpp
+++ b/OrbitGl/CaptureSerializer.cpp
@@ -36,15 +36,9 @@ outcome::result<void, std::string> CaptureSerializer::Save(
     const std::string& filename) {
   Capture::PreSave();

-  std::basic_ostream<char> Stream(&GStreamCounter);
-  cereal::BinaryOutputArchive CountingArchive(Stream);
-  GStreamCounter.Reset();
-  Save(CountingArchive);
-  PRINT_VAR(GStreamCounter.Size());
-  GStreamCounter.Reset();
-
   // Binary
   m_CaptureName = filename;
+
   std::ofstream file(m_CaptureName, std::ios::binary);
   if (file.fail()) {
     ERROR("Saving capture in \"%s\": %s", filename, "file.fail()");
@@ -53,18 +47,31 @@ outcome::result<void, std::string> CaptureSerializer::Save(

   try {
     SCOPE_TIMER_LOG(absl::StrFormat("Saving capture in \"%s\"", filename));
-    cereal::BinaryOutputArchive archive(file);
-    Save(archive);
-    return outcome::success();
+    Save(file);
   } catch (std::exception& e) {
     ERROR("Saving capture in \"%s\": %s", filename, e.what());
     return outcome::failure("Error serializing the capture");
   }
+
+  return outcome::success();
+}
+
+void CaptureSerializer::Save(std::ostream& stream) {
+  cereal::BinaryOutputArchive archive(stream);
+  std::basic_ostream<char> Stream(&GStreamCounter);
+  cereal::BinaryOutputArchive CountingArchive(Stream);
+  GStreamCounter.Reset();
+  SaveImpl(CountingArchive);
+  PRINT_VAR(GStreamCounter.Size());
+  GStreamCounter.Reset();
+
+  SaveImpl(archive);
 }

 //-----------------------------------------------------------------------------
 template <class T>
-void CaptureSerializer::Save(T& archive) {
+void CaptureSerializer::SaveImpl(T& archive) {
+  CHECK(time_graph_ != nullptr);
   m_NumTimers = time_graph_->GetNumTimers();

   // Header
@@ -150,8 +157,17 @@ outcome::result<void, std::string> CaptureSerializer::Load(
   }

   try {
+    return Load(file);
+  } catch (std::exception& e) {
+    ERROR("Loading capture from \"%s\": %s", filename, e.what());
+    return outcome::failure("Error parsing the capture");
+  }
+}
+
+outcome::result<void, std::string> CaptureSerializer::Load(
+    std::istream& stream) {
   // Header
-    cereal::BinaryInputArchive archive(file);
+  cereal::BinaryInputArchive archive(stream);
   archive(*this);

   // Functions
@@ -191,7 +207,7 @@ outcome::result<void, std::string> CaptureSerializer::Load(

   // Timers
   Timer timer;
-    while (file.read(reinterpret_cast<char*>(&timer), sizeof(Timer))) {
+  while (stream.read(reinterpret_cast<char*>(&timer), sizeof(Timer))) {
     time_graph_->ProcessTimer(timer);
   }

@@ -200,11 +216,6 @@ outcome::result<void, std::string> CaptureSerializer::Load(
   GOrbitApp->AddSamplingReport(Capture::GSamplingProfiler);
   GOrbitApp->FireRefreshCallbacks();
   return outcome::success();
-
-  } catch (std::exception& e) {
-    ERROR("Loading capture from \"%s\": %s", filename, e.what());
-    return outcome::failure("Error parsing the capture");
-  }
 }

 //-----------------------------------------------------------------------------
diff --git a/OrbitGl/CaptureSerializer.h b/OrbitGl/CaptureSerializer.h
index 22870721..7b7fb95c 100644
--- a/OrbitGl/CaptureSerializer.h
+++ b/OrbitGl/CaptureSerializer.h
@@ -7,6 +7,7 @@
 #include <outcome.hpp>
 #include <string>
 #include <unordered_map>
+#include <iosfwd>

 #include "OrbitType.h"
 #include "SerializationMacros.h"
@@ -14,11 +15,12 @@
 class CaptureSerializer {
  public:
   CaptureSerializer();
+
+  void Save(std::ostream& stream);
   outcome::result<void, std::string> Save(const std::string& filename);
-  outcome::result<void, std::string> Load(const std::string& filename);

-  template <class T>
-  void Save(T& archive);
+  outcome::result<void, std::string> Load(std::istream& stream);
+  outcome::result<void, std::string> Load(const std::string& filename);

   class TimeGraph* time_graph_;
   class SamplingProfiler* m_SamplingProfiler;
@@ -30,4 +32,8 @@ class CaptureSerializer {
   int m_SizeOfTimer;

   ORBIT_SERIALIZABLE;
+
+ private:
+  template <class T>
+  void SaveImpl(T& archive);
 };

I am wondering if there is a way to avoid creating mirror method that operate with buffers in the api, the concern is that they are going to be used by fuzzing tests only.

Good point. I have to admit I mainly took this code from what Maciej has done for the security review. But I will have a look if we can protect this code against being missed in refactorings.

On linux we could use memefd... but it is my understanding that windows has completely different api for working with files and it will probably end up with a lot of ifdefs.

On linux we could use memefd... but it is my understanding that windows has completely different api for working with files and it will probably end up with a lot of ifdefs.

I also did a quick google search and it seems windows has no equivalent of memfd_create.

I can't deny that I'm not exactly a fan of adding more ifdefs and alike, but I guess it's how it is...

Trust me. I feel your pain. :-/
Anyways, thanks for looking at this.


ctor codesnippet for java using the wrong class for generating constructor

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
OS Version:

Steps to Reproduce:

Create a new Class called Customer
Add constructor using the code snippet (ctor)
Add a new class with name  Order in the same file
Try to add a constructor in the Order class using the code snippet (ctor)
It generates a constructor with the name  Customer

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines. If you don't know which extension is causing the problem, you can run Help: Start extension bisect from the command palette (F1) to help identify the problem extension.
Happy Coding!


about the model_best.model.pkl"

Hello, author
When I load the model_best.model.pkl", it occur: RuntimeError: Invalid magic number; corrupt file?
By the way, Could I use the checkpoint as my pretrained model?
Looking forward to your reply. Thanks.

There is no need to load model_best.model.pkl. The true checkpoint is the model_best.model. What is recorded in the pkl file is the record of the training process.
You can try , but it's not clear if it works.

Get it. Thank you so much.


[Request] Config to disable worldgen

Particularly the decorative blocks that spawn around certain hives like glowstone/redstone. It would be very nice if we could disable the extra blocks. For those making packs with very closely defined oregen they can mess with pack progression pretty badly and no way to deal with them currently other than removing the mod.

I'm looking for this exact addition to the config file. I would like to use the mod, but the lack of control over it is messing with the progression I'm trying to set up for the pack I'm working on.
I would like to see options for hives for what biome(s) they can spawn in and to be able to disable them if need be. The main option I would like to see is the ability to disable the blocks they generate.
Thank you and hope that these options will be available in the next update.


Could it be possible to apply semver to exports?

I'm maintaining PuPHPeteer, a bridge to use Puppeteer in PHP.
Sometimes I need to check if an object is an instance of Browser or Page. It works great but I had some issues in the past with some changements you made to your internal API, here's an example:
- module.exports = Page;
+ module.exports = {Page};

Could it be possible to apply a semver treatment on those exports? I know this is not a public API but it really is limitating, currently my project can only handle a specific version of Puppeteer because the exports can break at any moment.
Thank you 🙂

@nesk sorry for the long reply. Can you elaborate more on this - why would you need to check if object is Page or Browser?

Actually, I no longer need to check for the Browser objects. However, I check for Page objects to listen for console events, so I can pass them to the PHP logger.
Now that I'm thinking about it, if this is a real problem for you to apply semver to the exports, I may check the type of the objects by reading the .constructor.name property.

Now that I'm thinking about it, if this is a real problem for you to apply semver to the exports, I may check the type of the objects by reading the .constructor.name property.

constructor.name sounds good.
We might eventually introduce a nicer API for extensibility purposes that would help you:
const {Page, Browser} = require('puppeteer/Classes');
Page.prototype.myMethod = () => {
  // ...
}

But that will probably happen after we drop node6 support.

Great, thank you for your help. 🙂


added github actions and publish to ghcr step

Prior to merging this will require adding your github token as a secret under GITHUB_TOKEN

@jaydenrasmussen thanks for this, I'll have a closer look later in the week. is the Github registry preferred to the Docker one these days?

It's sort of personal taste honestly. I've found that more folks are willing to pull from the Github registry because they are more friendly to FOSS projects

Starting from your PR I've solved this in a slightly different way here. I decided to keep pushing to Docker Hub. arm64 builds fine and the pipeline is green.
Then again, I couldn't get the linux/arm/v7 image to build with the current BusyBox .config file so that might need some more love (probably the CONFIG_LINUX32 flag and maybe other things). Did you need arm/v7 or just arm64?


"panic: inappropriate ioctl for device" when stdin is reused

Bug reports
When a program reads input from stdin (i.e, piped in before initializing the prompt),  go-prompt attempts to reuse this same pipe to read user input interactively, resulting in a panic:
panic: inappropriate ioctl for device

goroutine 1 [running]:
github.com/c-bata/go-prompt.(*PosixParser).GetWinSize(0xc420102b90, 0x871ee0)
	/home/bradley/go/src/github.com/c-bata/go-prompt/input_posix.go:113 +0xdd

Expected Behavior
go-prompt should always open a fresh stdin descriptor when initialized
Current Behavior and Steps to Reproduce
Read from stdin before starting the prompt
Context

Operating System: Linux
Terminal Emulator: Terminator
tag of go-prompt or commit revision: aa7dc8bfd5983acb7cf8858d17b16b206a3d2f7d

Thanks you. It was really easy to understand 👍


returning "field_name" - integer out of range

Describe the bug
returning "_id" - integer out of range error after trying to add value to db using persistAndFlush
Stack trace
insert into "movie" ("_id", "adult", "country", "created_at", "description", "rating", "released_at", "title", "updated_at", "views") values ('j9p9ZpYUYQ', true, 'YE',<PHONE_NUMBER>128, 'Nullam porttitor lacus at turpis. Donec posuere metus vitae ipsum.', 4.4,<PHONE_NUMBER>128, 'Ghost Rider',<PHONE_NUMBER>128, 3504) returning "_id" - integer out of range

To Reproduce
Steps to reproduce the behavior:

Create application using Nest.js with orm
Create Entity with id field as PrimaryKey
Try to add value to db using persistAndFlush

Expected behavior
The value(data) is added without error
Additional context
I tried to use the default value and different data types for the _id field, but the result is the same.
Movie entity:
export class Movie {
  @PrimaryKey()
  _id: number;

  // ....
}

MovieService:
@Injectable()
export class MovieService {
  constructor(
    @InjectRepository(Movie)
    private readonly movieRepository: EntityRepository<Movie>,
    private readonly em: EntityManager,
  ) {}

  async add(movie: Movie) {
    const movieEntity = this.em.create(Movie, movie);
    await this.movieRepository.persistAndFlush(movieEntity);
}

Config:
const config: Options = {
  migrations: {
    path: './src/database/migrations',
    pattern: /^[\w-]+\d+\.[tj]s$/,
  },
  entities: [Movie],
  entitiesTs: ['src/entities'],
  dbName: '....',
  type: 'postgresql',
  port: ....,
  debug: !__prod__,
  logger: logger.log.bind(logger),
};

Versions

Dependency
Version

node
14.12.0

typescript
3.9.7

mikro-orm
4.2.3

This is not caused by MikroORM, its error thrown by postgres, because you are trying to store a number that is larger than maximum allowed one. And it has nothing to do with the returing clause, that is just end of the query that caused it, the error is just "integer out of range".
I would expect the numeric timestamps to be issue,<PHONE_NUMBER>128 definitely won't fit into integer.


CMake is required for installation from PyPI

On Ubuntu 22LTS, installation from PyPI failed with error:
error: [Errno 2] No such file or directory: 'cmake'
Include cmake as requirement in pyproject.toml?

Added cmake to the pyproject.toml build-system requirements.


bug: confusing error message about workspace name

Describe the bug
I tried creating a workspace with a funky name and it failed with a compound error message that:
(a) makes an incorrect English statement of what is allowed, and
(b) contains two different regular expressions describing what is allowed (these two regexes match different sets of strings).
(base) mspreitz@mjs12 kcp % kubectl ws create ab-.-cd-.-ef
Error: Workspace.tenancy.kcp.io "ab-.-cd-.-ef" is invalid: [metadata.name: Invalid value: "ab-.-cd-.-ef": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*'), metadata.name: Invalid value: "ab-.-cd-.-ef": metadata.name in body should match '^[a-z0-9]([a-z0-9-]{0,61}[a-z0-9])?$']

Then I tried creating a workspace with a different funky name, and it failed with a shorter error message that only asserted one regex.
(base) mspreitz@mjs12 kcp % kubectl ws create ab-w.w-cd-w.w-ef
Error: Workspace.tenancy.kcp.io "ab-w.w-cd-w.w-ef" is invalid: metadata.name: Invalid value: "ab-w.w-cd-w.w-ef": metadata.name in body should match '^[a-z0-9]([a-z0-9-]{0,61}[a-z0-9])?$'

Steps To Reproduce
Shown above.
Expected Behaviour
Consistency.
Additional Context
This was using commit 4506fdc0 .

Corollary nit: should not be capitalizing Workspace.tenancy...


Fix bug with student importer creating more risk level records

Addressing part of https://github.com/studentinsights/studentinsights/issues/1074.
I think there are two bugs here.  One is that the importer calls create_risk_level! for every row that's processed during import, even for Student records that already exist and are just being updated (or haven't changed at all).  The other is that the check for registration dates in the future only applies to the student.save! call, and so other actions like assigning a homeroom or creating a risk level would still run.  I don't think this is what we want based on my read of https://github.com/studentinsights/studentinsights/pull/987.

Did some rails consoling and confirmed that there are way more StudentRiskLevel objects in the database than we want/need:
irb(main):012:0> Student.count
=> 5845
irb(main):013:0> StudentRiskLevel.count
=> 570800

We only need one per student since we're not doing anything with historical student risk levels. Great catch @kevinrobinson.

I might be missing something, but I think this PR so only fixing one of the bugs: the one where database-affecting code still runs even when students are registered in the future.
To test the second bug, we'd need to run import multiple times in the spec to see if multiple student risk level records get created; this spec only runs import once.
I think we should merge in this code and then tackle the second bug (with creating multiple student risk level records) in a separate PR, happy to handle that one.

@alexsoble thanks for checking this closely! 👍
In https://github.com/studentinsights/studentinsights/pull/1075/files#diff-762dc5b20df365311d4f9b4535ea4956R60, I'm trying to create a record that is about to be imported, and then check that only three new records are created on import.  So I think that'll test what we want.
But running import twice is a simpler better idea!  I'll update that next week and deploy, or if you want to push this along sooner feel free to do that too.

@alexsoble I added the "run import twice" test case https://github.com/studentinsights/studentinsights/pull/1075/files#diff-762dc5b20df365311d4f9b4535ea4956R73, thanks!


Use minideb as initContainer to change volumes permissions

Signed-off-by: Carlos Rodriguez Hernandez<EMAIL_ADDRESS>In order to maintain the image up-to-date, with CVEs tracking and integrated on a tested pipeline I suggest replacing busybox image with minideb
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[X] DCO signed
[X] Chart Version bumped
[X] Variables are documented in the README.md

/lgtm


Add Ghostfolio

Thanks! Remember seeing Ghostfolio a few weeks back!
Feel free to add sections for Nest.js and Angular :)


Chrome extension unavailable in chrome web store

It says it's delisted and the link is dead.
https://extpose.com/ext/69112

WARNING: the extension from the link is COMPROMISED.


Improve Lighthouse scores

Feature description
The site should also serve as an example of a well-performing site, so investigate and make enhancements to get Lighthouse scores in the 90s.

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

FYI Here's the current Lighthouse score:

@derekherman @dero Do you know when latest merged changes will be visible on https://kinoweb.dev/?

@beaufortfrancois They are currently only on staging. I need to create a release to deploy to production. I’ll work on it later today.

Out of curiosity, what's the URL for staging?

@derekherman Please let me know when it's deployed on production so that we can compare scores. Thank you!

The latest has been deployed to production and the LH numbers are definitely improved.

They are! Woohoo!

That's awesome--thank you!
On Fri, Sep 24, 2021 at 12:38 AM François Beaufort @.***>
wrote:

They are! Woohoo!
[image: image]
https://user-images.githubusercontent.com/634478/134636604-7910e47c-ef62-442b-93ad-6f0581c2eb7c.png
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/GoogleChrome/kino/issues/142#issuecomment-926414022,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFZIHGRF7HG266W5D7MYOHDUDQTGJANCNFSM5C6OUVFA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Awesome work @beaufortfrancois thank you for all the enhancements. The scores look great!


Making cosimulation fifo asynchronous for faster draining

This fixes a potential issue where cosimulation buffers fill up and overflow. The case that could cause this is if there are a large number of nonblocking OOO operations such as integer divides or cache misses, several completed entries could enter the cosimulation fifo. If the FIFO is committing at 1 IPC, then it can only "catch up" to the processor on processor stalls. If there aren't any catchup cycles, eventually the fifo may overrun.
This PR makes the cosimulation clock much faster than the core clock, enable it to drain as soon as dependencies are met. Additionally, this provides additional safety in the context of multicore cosimulation.
Last, it provides a hook to wait on coherence operations to complete. This is essential for ordering commits of stores in the context of a cosimulated SC multicore.

How does it affect cosim performance?
On Wed, Sep 22, 2021 at 9:07 AM Dan Petrisko @.***>
wrote:

This fixes a potential issue where cosimulation buffers fill up and
overflow. The case that could cause this is if there are a large number of
nonblocking OOO operations such as integer divides or cache misses, several
completed entries could enter the cosimulation fifo. If the FIFO is
committing at 1 IPC, then it can only "catch up" to the processor on
processor stalls. If there aren't any catchup cycles, eventually the fifo
may overrun.
This PR makes the cosimulation clock much faster than the core clock,
enable it to drain as soon as dependencies are met. Additionally, this
provides additional safety in the context of multicore cosimulation.
Last, it provides a hook to wait on coherence operations to complete. This
is essential for ordering commits of stores in the context of a cosimulated
SC multicore.
You can view, comment on, or merge this pull request online at:
https://github.com/black-parrot/black-parrot/pull/933
Commit Summary

Making cosimulation fifo asynchronous for faster draining
https://github.com/black-parrot/black-parrot/pull/933/commits/d817fceedd57a691baa6fd57e1799d8d60203ad6

File Changes

M .gitlab-ci.yml
https://github.com/black-parrot/black-parrot/pull/933/files#diff-037ea159eb0a7cb0ac23b851e66bee30fb838ee8d0d99fa331a1ba65283d37f7
(1)
M bp_top/test/common/bp_nonsynth_cosim.sv
https://github.com/black-parrot/black-parrot/pull/933/files#diff-f2bed9fc4a9b1328f961a401eed57deee99b05bffe6e2fb41fa587309156ba1c
(169)
M bp_top/test/tb/bp_tethered/testbench.sv
https://github.com/black-parrot/black-parrot/pull/933/files#diff-f75ab32fd25198b67730b25cb71ceed03d5d4d3a7a3446bee0ad4c2c8b427b59
(37)

Patch Links:

https://github.com/black-parrot/black-parrot/pull/933.patch
https://github.com/black-parrot/black-parrot/pull/933.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/black-parrot/black-parrot/pull/933, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEFG5AAHMLBGXSCQVKM5MNDUDH5KJANCNFSM5ERVV7CQ
.

Good question! I’ll run some tests

On Sep 22, 2021, at 11:23 AM, taylor-bsg @.***> wrote:

How does it affect cosim performance?
On Wed, Sep 22, 2021 at 9:07 AM Dan Petrisko @.***>
wrote:

This fixes a potential issue where cosimulation buffers fill up and
overflow. The case that could cause this is if there are a large number of
nonblocking OOO operations such as integer divides or cache misses, several
completed entries could enter the cosimulation fifo. If the FIFO is
committing at 1 IPC, then it can only "catch up" to the processor on
processor stalls. If there aren't any catchup cycles, eventually the fifo
may overrun.
This PR makes the cosimulation clock much faster than the core clock,
enable it to drain as soon as dependencies are met. Additionally, this
provides additional safety in the context of multicore cosimulation.
Last, it provides a hook to wait on coherence operations to complete. This
is essential for ordering commits of stores in the context of a cosimulated
SC multicore.
You can view, comment on, or merge this pull request online at:
https://github.com/black-parrot/black-parrot/pull/933
Commit Summary

Making cosimulation fifo asynchronous for faster draining
https://github.com/black-parrot/black-parrot/pull/933/commits/d817fceedd57a691baa6fd57e1799d8d60203ad6

File Changes

M .gitlab-ci.yml
https://github.com/black-parrot/black-parrot/pull/933/files#diff-037ea159eb0a7cb0ac23b851e66bee30fb838ee8d0d99fa331a1ba65283d37f7
(1)
M bp_top/test/common/bp_nonsynth_cosim.sv
https://github.com/black-parrot/black-parrot/pull/933/files#diff-f2bed9fc4a9b1328f961a401eed57deee99b05bffe6e2fb41fa587309156ba1c
(169)
M bp_top/test/tb/bp_tethered/testbench.sv
https://github.com/black-parrot/black-parrot/pull/933/files#diff-f75ab32fd25198b67730b25cb71ceed03d5d4d3a7a3446bee0ad4c2c8b427b59
(37)

Patch Links:

https://github.com/black-parrot/black-parrot/pull/933.patch
https://github.com/black-parrot/black-parrot/pull/933.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/black-parrot/black-parrot/pull/933, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEFG5AAHMLBGXSCQVKM5MNDUDH5KJANCNFSM5ERVV7CQ
.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

Seems to be negligible.  All tests I ran were +-1s, with the async cosim being faster in some cases


Add support to enable EndpointStatus in Helm chart

This commit introduces a new Helm parameter to enable --endpoint-status option in Cilium.
endpointStatus.enabled is disabled by default and endpointStatus.status is required once enabled and suggesting status: policy, controllers, health, log, state.
This aims to activate the values in the columns present in kubectl get cep.

test-me-please

test-gke

merging since this is only changing helm and the CI failures might be flakes


New Service Support: Auto Scaling

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request

Tell us about your request
Add support for Auto Scaling
Additional context
Auto Scaling uses the AWS JSON 1.1 protocol

Auto Scaling support was added in v0.0.12-alpha.


[comments] comment button should not require text selection

it seems counterintuitive that we can't comment on a specific position - other tools don't require selections, specific positions are sufficient. Some tools automatically snap a selection around the nearest word, but I am not sure that's critical.

@wittjosiah, this directly conflicts with #7210?

@ZaymonFC yeah #7210 is interim fix, not having the button disabled and snapping to the nearest word (a la google docs) would be an improvement (this issue) but we chose to prioritize resolution first


Add check for security groups in Invalid AutoScaling Group filter

Deleting a Security Group referenced in a Launch Configuration causes the LC/ASG to become unusable.
Add a valid security group check to the asg resource type's invalid filter.

True, I omitted previously since sg are strongly referenced to their Enis which prevented deletion. If extant instances, if none are extant though that seems viable

I'm working on a fix - PR coming soon...

I'll also add a check for invalid key pairs while I'm at it.
Useful list of reasons an ASG could be invalid:

http://docs.aws.amazon.com/autoscaling/latest/userguide/ts-as-instancelaunchfailure.html


Show Device space | Available | Used

When the headset is connected it would be great to see the total space of the device, the available space, and the space used.

that is already visible on the installed apps page ..?

Can it be visible in the title bar or in the header if possible?

have added it to the browse page aswell now (these are the only 2 pages where it makes sense to see this info, no home or settings page.
is in dev branch, no release yet, since im doing some refactoring and not sure what i broke ;)
If you dont mind,   pull and run development branch

No problem. I'll do that now. Thank you!


Nllg error

org.bukkit.command.CommandException: Unhandled exception executing command 'nllg' in plugin NameLayer v2.5.25
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:46) ~[spigot.jar:git-Spigot-d97e08b-880a532]
at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:141) ~[spigot.jar:git-Spigot-d97e08b-880a532]
at org.bukkit.craftbukkit.v1_8_R3.CraftServer.dispatchCommand(CraftServer.java:641) ~[spigot.jar:git-Spigot-d97e08b-880a532]
at net.minecraft.server.v1_8_R3.PlayerConnection.handleCommand(PlayerConnection.java:1162) [spigot.jar:git-Spigot-d97e08b-880a532]
at net.minecraft.server.v1_8_R3.PlayerConnection.a(PlayerConnection.java:997) [spigot.jar:git-Spigot-d97e08b-880a532]
at net.minecraft.server.v1_8_R3.PacketPlayInChat.a(PacketPlayInChat.java:45) [spigot.jar:git-Spigot-d97e08b-880a532]
at net.minecraft.server.v1_8_R3.PacketPlayInChat.a(PacketPlayInChat.java:1) [spigot.jar:git-Spigot-d97e08b-880a532]
at net.minecraft.server.v1_8_R3.PlayerConnectionUtils$1.run(SourceFile:13) [spigot.jar:git-Spigot-d97e08b-880a532]
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_72-internal]
at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_72-internal]
at net.minecraft.server.v1_8_R3.SystemUtils.a(SourceFile:44) [spigot.jar:git-Spigot-d97e08b-880a532]
at net.minecraft.server.v1_8_R3.MinecraftServer.B(MinecraftServer.java:714) [spigot.jar:git-Spigot-d97e08b-880a532]
at net.minecraft.server.v1_8_R3.DedicatedServer.B(DedicatedServer.java:374) [spigot.jar:git-Spigot-d97e08b-880a532]
at net.minecraft.server.v1_8_R3.MinecraftServer.A(MinecraftServer.java:653) [spigot.jar:git-Spigot-d97e08b-880a532]
at net.minecraft.server.v1_8_R3.MinecraftServer.run(MinecraftServer.java:556) [spigot.jar:git-Spigot-d97e08b-880a532]
at java.lang.Thread.run(Thread.java:745) [?:1.8.0_72-internal]
Caused by: java.lang.NullPointerException
at vg.civcraft.mc.namelayer.command.commands.ListGroups.execute(ListGroups.java:78) ~[?:?]
at vg.civcraft.mc.namelayer.command.CommandHandler.execute(CommandHandler.java:87) ~[?:?]
at vg.civcraft.mc.namelayer.NameLayerPlugin.onCommand(NameLayerPlugin.java:69) ~[?:?]
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:44) ~[spigot.jar:git-Spigot-d97e08b-880a532]
... 15 more

@erocs Did you fix this?

rourke750 Testing new format 3d61e2c  29 days ago
Doesn't look like it.
On Mon, Jan 18, 2016 at 9:33 AM, rourke750<EMAIL_ADDRESS>wrote:

@erocs https://github.com/erocs Did you fix this?
—
Reply to this email directly or view it on GitHub
https://github.com/Civcraft/NameLayer/issues/152#issuecomment-172600600.

Is this still an issue?

Likely: https://github.com/Civcraft/NameLayer/blame/master/NameLayerMain/src/vg/civcraft/mc/namelayer/command/commands/ListGroups.java#L84
Group is never checked to be null; this is a classic NPE source.

Pretty sure this is no longer happening, so closing.


Add Assignment AND Operator Support

PR Description
This PR implements support for the Assignment XOR token in the CrossGL project .The token is now properly translated across the DirectX, Metal, and OpenGL backends.
Related Issue

Close #112
shader Sample

shader ANDShader {
vertex {
input vec3 position;
output vec2 vUV;
void main() {
vUV = position.xy * 10.0;
vUV.x &= 3.0;  // AND assignment operator
gl_Position = vec4(position, 1.0);
}
}
fragment {
input vec2 vUV;
output vec4 fragColor;
void main() {
float noise = perlinNoise(vUV);
float height = noise * 10.0;
height &= 2.0;  // AND assignment operator
vec3 color = vec3(height / 10.0, 1.0 - height / 10.0, 0.0);
fragColor = vec4(color, 1.0);
}
}
}
Checklist

[x] Have you added the necessary tests?
[x] Only modified the files mentioned in the related issue(s)?
[x] Are all tests passing?

@samthakur587 PTAL

hii @anshikavashistha can you please solve the merge conflict .


acme-client: DNS-01/nsupdate: doesn't allow FQDN in the name

when you put a FQDN in a certificate name request, you get: Should be a string between 1 and 255 characters.
if you remove all the special characters (INCLUDING PERIODS(!!)), it sends the unqualified name as the CN= to LE, and gets a 400 error:
[Sun Feb 5	00:00:07 CST 2017] new-authz error: {"type":"urn:acme:error:malformed","detail":"DNS name does not have enough labels","status": 400}
[Sun Feb 5	00:00:07 CST 2017] The new-authz request is ok.
This makes it IMPOSSIBLE to generate a certiificate.

Also, it is unclear what is supposed to go in the secret field of the validation request.  The whole key file, or just the secret or what.

Same problem, it is not possible to use a name like srv-1.example.com

Same issue when my FQDN contain a hyphen.

Thanks for the report, I'm preparing a fix.

A fix is included in PR #71.

Can you clarify the nsupdate secret key field?

@lrosenman: You need to put in the whole key file, see the example in my initial PR #66. I'll fix the help text, though.

@fraenki Thanks!

Thanks !

FYI, the fix will be available on thursday with OPNsense 17.1.1  :)


Changes related to Linux-based build.

Moved most of the NuGet-related tasks into src/.nuget/packageLoad.targets
Since NuGet.exe cannot process solutions on Linux created an option
to use dnu for project.json processing
Copy CoreRun to the output directory in Linux
Fixed a number of problems with test processes building NetCore configuration
Added a few generic functions to replace Window-specific ones
Updated some package versions

It still does not quite builds on Linux because linux runtime cannot be added project.json

Looks like the CI is failing: EXEC : warning : Unable to find version '1.0.25-prerelease-00098' of package 'Microsoft.DotNet.BuildTools'

I did notice that build failed. I think the source is missing, but it works both on my Windows and Linux systems (it might have found the source in a global config, or something). I'll see how I can repro the failure on one of them.

It definitely fails for me (Windows) after git clean -xdf.

Broke the changes up into two commits per Rainer's suggestion. Made some changes based on recommendations in the comments. Specifically, made some changes Windows-specific (such as task override and used Microsoft.Portable.CSharp.targets on Windows.

It looks like you've removed the NuGet.config in the repository root.  I think we should leave that one there, and remove the one in src\.nuget.  The reason for this is because NuGet will automatically walk up the parent directories of the project directory looking for NuGet.config files.  So for example if our NuGet.config is at the repo root, then the NuGet UI and package restore in Visual Studio will work with the feeds we've set up there.

I tried building your changes on Windows, and it looks like it's no longer downloading NuGet.exe if it's not found in the packages folder.

LGTM, modulo my comments about leaving NuGet.Config in the repo root and fixing the target which is supposed to download NuGet.exe.

Things still don't seem right here. Few things I've noticed running locally (on the 83883ee commit):

The build seems significantly slower than xplat tip (30% slower on command line, and noticeably in VS).
The CI build is failing about 1000 more tests than previous (but that could be just older branch).
Error in VS building (that don't appear in tip):

Couldn't find the required information in the lock file. Make sure you have  NETFramework,Version=v4.5.1/win7-x86 mentioned in your targets.

After build the following lock files are modified:

        modified:   Samples/PortableTask/project.lock.json
        modified:   src/Utilities/UnitTests/project.lock.json
        modified:   src/Utilities/project.lock.json
        modified:   src/XMakeBuildEngine/UnitTests/project.lock.json
        modified:   src/XMakeBuildEngine/project.lock.json
        modified:   src/XMakeCommandLine/UnitTests/project.lock.json
        modified:   src/XMakeCommandLine/project.lock.json
        modified:   src/XMakeTasks/UnitTests/project.lock.json
        modified:   src/XMakeTasks/project.lock.json
        modified:   src/nuget/Microsoft.Build.nuspec

At this point would it make sense to break things up a little so we can isolate them a bit more? The native code methods and of the minor changes look good so it would be great to get those in. I'd like to understand more the differences and if they're good or not before taking the others (sigh NuGet complexity...).

Moved NuGet.Config to the root
Changed all imports in dir.targets so that the import only happens when the target file exists
A few more changes to the project files

One must still do command line build before building in Visual Studio, but the build succeed.

@ValMenn This is merged, and I get fail in build:
D:\src\msbuild.fork\dir.targets(176,5): error MSB3073: The command "D:\src\msbuild.fork\packages\\xunit.runner.console.2.1.0-rc1-build3168\tools\xunit.console.x86.exe D:\src\msbuild.fork\bin\Windows_NT\Debug\Microsoft.Build.Tasks.UnitTests.dll -noshadow -parallel none -xml D:\src\msbuild.fork\bin\Windows_NT\Debug\Microsoft.Build.Tasks.UnitTests.dll_TestResults.xml -html D:\src\msbuild.fork\bin\Windows_NT\Debug\Microsoft.Build.Tasks.UnitTests.dll_TestResults.html > D:\src\msbuild.fork\bin\Windows_NT\Debug\Microsoft.Build.Tasks.UnitTests.dll_stdout.txt" exited with code 1.

Looking in that file:
xUnit.net Console Runner (32-bit .NET 4.0.30319.42000)
System.IO.FileLoadException: Could not load file or assembly 'xunit.core, Version=<IP_ADDRESS>68, Culture=neutral, PublicKeyToken=8d05b1bb7a6fdb6c' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)

Did this pass CI? Or work on your machine?

@AndyGerlicher looks like we broke tests for full framework in xplat at some point; I just saw this on my machine.  Rolling build for xplat seems as happy as ever: http://dotnet-ci.cloudapp.net/job/microsoft_msbuild_xplat/60/ (it only tests netcore).
I'll see what I can figure out.

@AndyGerlicher I'm stumped.  I can no longer repro, including on a clean VM.  Can you?  If so, can you try https://github.com/rainersigwald/msbuild/tree/revive-fullframework-tests and see if that helps?


Added JSON format.

Added JSON. Refactorize some argument methods, added try catch blocks.

Thanks :D Merged.


feature: support pulumi config

Hi,
When using Pulumi directly you have the ability to specify configuration (ref: https://www.pulumi.com/docs/concepts/config) in your Pulumi.yaml file like the following:
config:
  # Custom configuration goes here
  backend:apiPublicDomainName:
    type: string
    description: "The public domain name for the API"

  backend:frontendPublicDomainName:
    type: string
    description: "The public domain name for the frontend"

This allows to enforce that every Pulumi stack file contains the above configuration like so
config:
  backend:apiPublicDomainName: "api.backend.dev"
  backend:frontendPublicDomainName: "backend.dev"⏎

And finally enforcing the requirement to be there in the Pulumi code
const config = new pulumi.Config();
pulumi.log.info(config.require('apiPublicDomainName'));

Thus ensuring that apiPublicDomainName is always set

Translating this to ION it would mean you can add configuration per stage. On "development" stage my domain name would be "api.dev.backend.dev" vs on "production" it would be "api.backend.dev". A lot of times we need this kinda of configuration and right now I have no way to define this in ion (or SST).
The only option is to riddle your infra code with conditionals depending on stages but if an additional stage is provisioned (or even your local user stage during development) you suddenly have  to update everything and often forget / miss different pieces of configuration.
Finally since $app.stage is only evaluated in the run function having this as a global constant somewhere doesn't work:
export const API_PUBLIC_DOMAIN = $app.stage === 'production' ? 'api.backend.dev' : 'api.dev.backend.dev'

Typically we use this to configure: domains, certificates, external integrations configuration (everything which is not a secret for example, like external api urls, client ids and so on)
Terraform has the same concept called tfvars files (ref: https://developer.hashicorp.com/terraform/language/values/variables#assigning-values-to-root-module-variables)

need to think about this a bit more - my issue with the "config" concept is it's just another file that could have just been a typescript file so we haven't really seen many cases where people needed it
usually people will just put that configuration in their code - usually something like this:
const domain = (() => {
  if (stage === "production") return "example.com"
  if (stage === "stagomg") return "staging.example.com"
  return $app.stage + ".example.com"
})()

there's many ways in JS to accomplish different variations of this depending on how you want to organize things
run() {

Hi,
Thanks for the feedback and implementation example, right now I'm just using nested object so I can ensure that on staging / production I have the same keys.
My issue with rolling your own implementation is:

There are no runtime checks in case you are missing a config value (unless you run it your own)
Reimplementing something thats already available in Pulumi
You can only resolve the right config in the run function, meaning that I have to prop drill it everywhere (looking at a lot if different files being included in the run file)

I guess that poeple never encountered the issue YET since now they have the full power of Pulumi 😅 .
Regards,

think it's we'll only implement something opinionated and native for this until it becomes something a lot of people are handrolling themselves and we can see what patterns are common. i'm not sure if this will happen because although pulumi config concept is new, the patterns are roughly the same in sst2
note - you don't have to prop drill, you can just import the config as needed, wrap it in a function, wrap it in a getter, etc.  i can probably provide more specific examples but there's such a wide range of solutions that i'm not sure where to start

Allright fair enough 😉

will close this for now - if anyone els ehas additional thoughts feel free to reopen


Range request caching

We are using range requests on a project so as to stream linearised pdfs.
To do so, we provide pdf.js with our file serving api url.
Yet, by design, pdf.js does not allow the user to customise the serving url. This means the url used for range request will always be the same and will not contain, for instance, range begin/end parameters.
The consequence of this is that you cannot benefit from straightforward http cache control, since the browser does not know which portion was loaded. You could perhaps implement if-range headers, but that did not seem to work out when I looked into it.
any reason why pdf.js does not allow to either customise the pdf url or add range as url parameters rather than data? Range specific urls would entail easy http cache control. We’ve forked pdf.js to add parameters to the pdf url. I would happy to submit a PR for this.
Let me know your thoughts and do of course point out any misconception on my part.
Best,
Sam

any reason why pdf.js does not allow to either customise the pdf url or add range as url parameters rather than data?

The PDF.js library already support a fully custom data delivery mechanism, please note this getDocument parameter https://github.com/mozilla/pdf.js/blob/86a4ba55c56f735e51e29a7aa368bcdcce9d8a23/src/display/api.js#L127-L128 which takes an PDFDataRangeTransport-instance (which you create) that then handles the data fetching, see https://github.com/mozilla/pdf.js/blob/86a4ba55c56f735e51e29a7aa368bcdcce9d8a23/src/display/api.js#L549-L625
(Behind the scenes, this uses https://github.com/mozilla/pdf.js/blob/master/src/display/transport_stream.js)
This method is what the Firefox PDF Viewer uses, and some (admittely basic) usage examples can be found in these unit-tests: https://github.com/mozilla/pdf.js/blob/86a4ba55c56f735e51e29a7aa368bcdcce9d8a23/test/unit/api_spec.js#L2182-L2302

I would happy to submit a PR for this.

Given the existing PDFDataRangeTransport functionality, we don't want to add (from a general library perspective) essentially unused/untested code for a very specialized use-case to the multitude of built-in data fetching mechanisms that we support (fetch_stream.js/network.js/node_stream.js).

For future reference: Please remember to fill out the ISSUE_TEMPLATE when opening an issue.
In cases such as this it's also somewhat difficult to get a full picture of the problem with only a text description, hence please keep this in mind https://github.com/mozilla/pdf.js/blob/master/.github/CONTRIBUTING.md (emphasis mine):

If you are developing a custom solution, first check the examples at https://github.com/mozilla/pdf.js#learning and search existing issues. If this does not help, please prepare a short well-documented example that demonstrates the problem and make it accessible online on your website, JS Bin, GitHub, etc. before opening a new issue or contacting us in the Matrix room -- keep in mind that just code snippets won't help us troubleshoot the problem.


⚠ Bofrost.at has degraded performance

In 61d7f6a, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2101 ms

Resolved: Bofrost.at performance has improved in c177dcb after 6 minutes.


Flexible Route Registration

Is your feature request related to a problem? Please describe.
Managing decentralized routes can be pretty time consuming.
Describe the solution you'd like
More flexible route registration.
Describe alternatives you've considered
Registering routes using attributes on controllers and actions, or registering in Startup.cs.
Additional context
None

Documentation / Wiki will be added later

Unit Tests are poor, need to improve them


Needs publishing on Hex.pm.

Many of the recently merged PRs (including the one for Ethereum stuff) aren't in the latest version of Faker on Hex.pm.
It'd be nice to bump it.

https://hex.pm/packages/faker/0.13.0


Show images in preview

When a new image (png/jpg/etc) is added to a PR, clicking on it should show the image in vscode.
Currently it opens it up in a webpage (and that works), just no reason cannot preview this type of file.
Potentially add an extension point - where custom 'previewers' can be added for files (even to show a diff of modified images, etc)

Now seeing that clicking to open it will just throw an error, not open a webpage. (so #1461 has resurfaced)

Now seeing that clicking to open it will just throw an error, not open a webpage. (so #1461 has resurfaced)

This should be working now.


In included file: unexpected OpenMP directive

Having an openmp pragma in a header results in the following error shown on the include.

In included file: unexpected OpenMP directive '#pragma omp parallel for'clang(omp_unexpected_directive)
omp_header.hpp(4, 22): Error occurred here

Tested on the master from yesterday. Problem was already present in clangd 8.0.1 (no diagnostic is displayed, seen in the logs).
compile command clang++ -fopenmp main.cc
// header.hpp
#pragma once

void loop() {
#pragma omp parallel for
  for (int i = 0; i < 100; ++i) {
  }
}

// main.cc
#include "header.hpp"

int main() {
    loop();
}

The omp pragma seems to mess up the parsing of the header file somehow as I see some follow-up errors in the log:
V[14:12:23.340] Dropped diagnostic: /home/vogtha/tmp/omp_problem/main.cc: in included file: expected unqualified-id
V[14:12:23.346] index AST for /home/vogtha/tmp/omp_problem/main.cc (main=false):
  symbol slab: 1 symbols, 4456 bytes
  ref slab: 0 symbols, 0 refs, 136 bytes
  relations slab: 0 relations, 24 bytes
V[14:12:23.347] Built preamble of size 202656 for file /home/vogtha/tmp/omp_problem/main.cc
V[14:12:23.347] Dropped diagnostic: /home/vogtha/tmp/omp_problem/main.cc: in included file: extraneous closing brace ('}')
V[14:12:23.349] index AST for /home/vogtha/tmp/omp_problem/main.cc (main=true):
  symbol slab: 1 symbols, 4456 bytes
  ref slab: 1 symbols, 1 refs, 4256 bytes
  relations slab: 0 relations, 24 bytes

The problem was also reported here https://bugreports.qt.io/projects/QTCREATORBUG/issues/QTCREATORBUG-22225?filter=allissues (assuming they have clangd activated).

Could you provide a log line with the compile command?
Maybe it's missing -fopenmp...

It is there. If I remove -fopenmp from the compile_commands.json, no error is displayed as the pragma is properly ignored.
Updating file /home/vogtha/tmp/omp_problem/main.cc with command
[/home/vogtha/tmp/omp_problem]
/usr/bin/g++-7 --driver-mode=g++ -fopenmp -c /home/vogtha/tmp/omp_problem/main.cc -fsyntax-only -resource-dir=<...>/install/lib/clang/10.0.0

Yes, you are right. The problematic line is https://github.com/llvm/llvm-project/blob/f3ae951c09ef7ce98c62bd0941fb33cbb32f528b/clang/lib/Parse/Parser.cpp#L278
The body should be skipped, but parsing continues at the openmp pragma. Then the pragma is parsed as a pragma on a declaration which makes the parallel for invalid.
What's the reason for continuing parsing at openmp pragmas? Should it be kept?

It was added here https://github.com/llvm/llvm-project/commit/1d97d2a3d20e1490a72d3275c37ad57df3ede45c

cc @alexey-bataev

Unable to reproduce, for me, everything compiles without any problems.
clang++ -fopenmp main.cc does not produce any diagnostic

This issue is only in clangd, which tries to skip function bodies.

Then maybe clangd must be fixed? No idea, how to reproduce it with clangd.

I believe the fix has to be in Parser.cpp, but maybe only clangd is using that code path (via SkipFunctionBody()). I just thought you might have an idea how to improve the handling of the bug you fixed in the commit mentioned above. For skipping function bodies, exiting on an openmp pragma inside of the function looks too aggressive.

Are you skipping the body using Parser::SkipFunctionBody()? Or something else?

If you skipping the tokens using SkipUntil function, you need to call in a loop, something like while (!SkipUntil(...)), you can't just call it once. It returns true if the specified token is found and false otherwise. You need to call this function unless the return value is true.

Plus, maybe, you will need to check for tok::eof in case if the function was not terminated and you reached the end of the file.

I already tried this code snippet, but got stuck in an infinite loop.
I don't see where Tok==tok::annot_pragma_omp should get consumed. I see only two cases before the early exit, both in branches which don't apply.

Must be consumed here https://github.com/llvm/llvm-project/blob/f3ae951c09ef7ce98c62bd0941fb33cbb32f528b/clang/lib/Parse/Parser.cpp#L256, unless your flag is StopBeforeMatch. If the flag is StopBeforeMatch, call ConsumeAnyToken() in loop body, I think.

This is inside the branch where we matched the token https://github.com/llvm/llvm-project/blob/f3ae951c09ef7ce98c62bd0941fb33cbb32f528b/clang/lib/Parse/Parser.cpp#L252

Ah, missed this. Then yes, just call ConsumeAnyToken(); in the body. But add a check for possible tok::eof.

I did this but now I run into the other problem I was asking earlier:

couldn't I end up with an unmatched {? (I mean, in the case where the first call to SkipUntil skipped over a {, exited early (return false), then wouldn't the second call return on the wrong }.)

E.g. in the slightly modified case:
#pragma once

void loop() {
{ // <- skipped over this in the first call
#pragma omp parallel for
  for (int i = 0; i < 100; ++i) {
  }
} // <- skips until here
}

Just add a check for tok::annot_pragma_openmp and tok::annot_pragma_openmp_end before consuming the tokens.

Sorry, I don't get how it is related to my question. From my understanding exiting on openmp pragma just doesn't make sense in the case where we are trying to skip the function body (or more general in the case of SkipUntil(tok::r_brace)).
Maybe this is a conflict of interest between the clangd and the clang++ use-case, because in the latter it is used only for trying to recover from invalid code (if I am not mistaken), while in the former we try to skip valid code. Thought, not sure if my understanding is correct...

From my understanding exiting on openmp pragma just doesn't make sense in the case where we are trying to skip the function body.

SkipUntil does not distinguish between skipping function body and normal processing of the OpenMP pragmas. You need special processing of these tokens when trying to skip the function body.

(or more general in the case of SkipUntil(tok::r_brace)).
When we found some bugs during parsing of the OpenMP pragma, we need to skip the rest of the line until tok::annot_module_end is found. So, we need to stop when we see tok::annot_module_end. But if we skip tok::annot_module_begin, we have an unbalanced OpenMP directive begin-end and it leads to troubles when trying to parse the OpenMP pragmas.

Still don't get it. Are you suggesting to introduce a special handling in SkipUntil in case the call is originating from the SkipFunctionBody()? Under the assumption that the function body which we want to skip, won't have one of the problems for which the return on OpenMP pragma was introduced?

Are you suggesting to introduce a special handling in SkipUntil in case the call is originating from the SkipFunctionBody()?

This is one of the possible solutions. The second one is to use while loop with the checks for OpenMP tokens before calling ConsumeAnyToken().

I don't understand the second approach. Where would you put the while loop?

In the SkipFunctionBody() where you skipping the body of the function.

But the token in SkipFunctionBody will be the { of the function body, the next token can be anything. Only somewhere later in SkipUntil() we might eventually encounter the OpenMP pragma.

Can you try this:
while (!SkipUntil(...)) {
  if (Tok.is(tok::annot_openmp_begin) || Tok.is(tok::annot_openmp_end)
    ConsumeAnnotationToken();
}

?

The issue in this case is that I might have skipped an unmatched {. I would have to keep track how many unmatched { and then need to match it with the same number of SkipUntil() calls returning true.

That's what I meant with

(or more general in the case of SkipUntil(tok::r_brace)).

All calls to SkipUntil(tok::r_brace)) with an OpenMP pragma inside will have this problem, not only the SkipFunctionBody().

It means, that there is the same problem with modules, code completion token, and semicolon with StopAtSemi flag.

I’d argue that code completion and semicolon is ok, as there the early exit is driven by flags, I.e. the caller explicitly asks for it. For modules I am not sure, but maybe they cannot appear in parenthesis.

Possible solution is to add a new flag, similar to a flag for semicolon, and exit from SkipUntil for OpenMP if the flag is set. This flag should be set in all cases we parse OpenMP pragmas, otherwise the flag should not be set.

That makes sense. I'll try it.

I'm also experiencing this linting error any time I have -fopenmp compile flag enabled and have a #pragma omp parallel directive anywhere in the headers included. Just to clarify - is clangd incompatible with OpenMP as of today? Any ETA for a fix?

Any news on this?

Fixed in 8035bb4a6573f7d20f17044a68a1405691000525

Thanks Alexey! Closing this for now, patches to improve OpenMP (& OpenCL, Cuda, etc) always welcome!


fix(B92): add suspend & deepretn exit latency mechanism to avoid BLE disconn issue.

The following west manifest projects have been modified in this Pull Request:

Name
Old Revision
New Revision
Diff

hal_telink
https://github.com/telink-semi/hal_telink/commit/ec586d963cde41293340fd4b0697cf726afaf6a4
https://github.com/telink-semi/hal_telink/commit/54c4302c9038d2cf412348400bcd039f5674da91 (develop_dual,develop)
<EMAIL_ADDRESS>

Note: This message is automatically posted and updated by the Manifest GitHub Action.


Crash in AFURLSessionManager

I'm getting an assertion failure in AFURLSessionManager (line 332) when the delegate is getting set on a NSURLSessionUploadTask.
*** Assertion failure in -[AFHTTPSessionManager setDelegate:forTask:]
2013-11-14 00:18:09.755 app-staging[1049:c907] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Invalid parameter not satisfying: task
I'll do more digging, but wanted to see if anyone else has seen this issue. I've seen it happen about 5 times in the last few hours of testing.
Thanks!

set manager.operationQueue.maxConcurrentOperationCount = 1,
and
if ([[[UIDevice currentDevice] systemVersion] floatValue] >= 8.0) {
self.mutableData = nil;
}


Clarify ELF Reloc Type

"runtime relocation" is not a commonly used term. Use "dynamic relocation" instead.
"Runtime relocations can be resolved by both static and dynamic linkers" is inappropriate.
Rewrite the description.
RELATIVE can appear in an executable (usually PIE). Reword the description.
IRELATIVE can appear in an executable. Just remove "shared object" as
the previous paragraph has mentioned that "Dynamic" can be used in an executable.
Change "local ifunc symbol" to the more appropriate "non-preemptible ifunc symbol".

Fix #319

LGTM, though I'm not a right person to sign-off.

@rui314 Thanks for your review!
@MaskRay Thanks for tweaking those wording, tried to ask Google "dynamic relocation linker" vs "runtime relocation linker" which is 1,060,000 vs 298,000 :P


FilePicker Not Working Properly In Android and Web

Duplicate Check

[X] I have searched the opened issues and there are no duplicates

Describe the bug
When I Try To Get A File In Android And Web It Shows An Error. But Windows It Works Fine,
For Android ,It Show There Is No File Or Directory ;
Future exception was never retrieved

future: <Future finished exception=FileNotFoundError(2, 'No such file or directory')>
Traceback (most recent call last):
File "C:\Users\aarthi\AppData\Local\Programs\Python\Python312\Lib\concurrent\futures\thread.py", line 58, in run
result = self.fn(*self.args, **self.kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\aarthi\AppData\Local\Programs\Python\Python312\Lib\site-packages\flet_core\page.py", line 944, in wrapper
handler(*args)
File "C:\python_project\Sell_Any_Flet_App\main.py", line 2779, in pick_file_chat
with open(path,'rb') as fr:
^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: '/data/user/0/com.appveyor.flet/cache/file_picker/1728736726850/1000008325.jpg'
For Web , If I Select A FIle It Only Give The File Name , The File Path Is Set TO Be None ;
Future exception was never retrieved

future: <Future finished exception=TypeError('expected str, bytes or os.PathLike object, not NoneType')>
Traceback (most recent call last):
File "C:\Users\aarthi\AppData\Local\Programs\Python\Python312\Lib\concurrent\futures\thread.py", line 58, in run
result = self.fn(*self.args, **self.kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\aarthi\AppData\Local\Programs\Python\Python312\Lib\site-packages\flet_core\page.py", line 944, in wrapper
handler(*args)
File "C:\python_project\Sell_Any_Flet_App\main.py", line 2779, in pick_file_chat
with open(path,'rb') as fr:
^^^^^^^^^^^^^^^
TypeError: expected str, bytes or os.PathLike object, not NoneType
Code sample
Code
``...`

### To reproduce

...

### Expected behavior

_No response_

### Screenshots / Videos

Captures

[Upload media here]

### Operating System

Windows

### Operating system details

windows 11

### Flet version

0.24.1

### Regression

I'm not sure / I don't know

### Suggestions

_No response_

### Logs

Logs

```console
[Paste your logs here]

Additional details
No response

Can you please re-format your issue and provide some reproducible code?

Works for me on android, google tv streamer has issues however.


Wrong  auto-generation

Hi all,
when i'll try to create a new layout (example id: "foo") with yo liferay-theme:layout command, it's created a liferay-layout-templates.xml file with this content:
<layout-templates>
  <custom>
    <layout-template id="foo" name="foo">
      <template-path>\layouttpl\custom\foo-layouttpl/foo.ftl</template-path>
      <thumbnail-path>\layouttpl\custom\foo-layouttpl/foo.png</thumbnail-path>
    </layout-template>
  </custom>
</layout-templates>

If i deploy the layout, i see this error: [LayoutTemplateLocalServiceImpl:369] No content found at template path ...
This happens because <template-path> has backslashes (\) instead of slashes (/). I think it should be <template-path>/layouttpl/custom/foo-layouttpl/foo.ftl</template-path> (same for thumbnail-path).
If this is true, you could watch here the path.join function. It returns a normalized path but i don't know if in this case it could be always correct.
I'm using Liferay Portal CE 7.2 GA1 bundled with Tomcat on Windows.

What we might actually need there is path.posix.join(). If you wanted to test that out locally by making a sneaky edit to your installed copy of the generator could you let me know if that fixes it for you?

Yes, in my local copy this fix is correct. I tried to generate a new layout and i deployed it without errors.

Thanks for confirming, @Desperino.

v9.4.3 is now out with this fix.


feature/automapper tests

test(automapper): add mapping profile tests
test(automapper): add dependency injection integration tests

Codecov Report

Merging #2 (fe25836) into main (a5b9ea6) will increase coverage by 18.93%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main       #2       +/-   ##
===========================================
+ Coverage   72.72%   91.66%   +18.93%
===========================================
  Files           3       12        +9
  Lines          33      144      +111
  Branches        5       13        +8
===========================================
+ Hits           24      132      +108
- Misses          6        7        +1
- Partials        3        5        +2

Impacted Files
Coverage Δ

samples/FluentUtils.AutoMapper.Samples/Program.cs
100.00% <ø> (ø)

...r.Samples/Controllers/WeatherForecastController.cs
100.00% <0.00%> (ø)

...crosoft.DependencyInjection/DependencyInjection.cs
88.88% <0.00%> (ø)

src/FluentUtils.AutoMapper/MappingProfile.cs
96.29% <0.00%> (ø)

...es/Core/WeatherForecasts/Models/WeatherForecast.cs
100.00% <0.00%> (ø)

...Core/WeatherForecasts/Models/WeatherForecastDto.cs
100.00% <0.00%> (ø)

...Core/WeatherForecasts/Queries/GetForecastsQuery.cs
100.00% <0.00%> (ø)

.../Infrastructure/Services/WeatherForecastService.cs
100.00% <0.00%> (ø)

src/FluentUtils.AutoMapper/IMapFrom.cs
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eec082c...fe25836. Read the comment docs.


Showcase the latest released version

This showcases the latest released version, and links to dependency instructions.
Should we add it?

Sure. Thanks.


Tor browser is out of date

Version is 6.0.4, current is 6.0.7.

release https://github.com/sameersbn/docker-browser-box/releases/tag/1.0.1 now packages tor 6.0.8


Misspelled 'this.' property accesses don't trigger spelling correction fixes

class Thing {
    state: any;
    constructor(state) {
        this.state = state;
    }
    doStuff() {
        this.stat/**/;
    }
}

Expected: A quick fix to correct the spelling to 'state'.

Note that the error message gives the correct suggestion; it's just missing the quick fix.

Fix is up at #16844


feat: Ensure user's lists are not considered as a regular search

Hi everyone,
When the user searches for something, he can tap on the title to edit it.
But this same screen is also used for "Products I added, edited…" and in that case, the search is not editable.
This PR disables this feature in that particular case.

merging @g123k @M123-dev
Feel free to merge yourself if the PR is approved


schema update

complement of: https://github.com/Azure/azure-dev/pull/3155
To be merged on release-day to update schema

moved it to: https://github.com/Azure/azure-dev/pull/3330/files


Fix bug preventing one MDE rip error from bubbling up the async chain.

Without passing in an error object to the reject function, it is undefined and not caught. This leaves an output log of the following, and the Start Ripping button remains disabled. This requires killing DARE and establishing the output queue again to rip items.

Dynamic has no mesh data (D), skipping...
File extraction readied...
API rip done!
MDE exited with code 0
MDE exited with code<PHONE_NUMBER>

With the fix, the output log shows the following with the last line in red:

Dynamic has no mesh data (D), skipping...
File extraction readied...
API rip done!
MDE exited with code 0
MDE exited with code<PHONE_NUMBER>
Ripping failed: Error message: MDE failed with exit code:<PHONE_NUMBER>

And the Start Ripping button is re-enabled.
Also added the fix for when DCG fails. Observed with the recent light.gg DDOS protection issue where DARE is not in a re-enabled state after a DCG error.

Sorry about forgetting about this. Next time feel free to remind me more promptly.


Atomic Paths error in 2.3.4

Spec:
# spec/models/view_spec.rb
require "spec_helper"

class Account
  include Mongoid::Document

  #this is correct, account has many users, not has many views
  has_many :users, as: :account
end

class User
  include Mongoid::Document

  embeds_many :views
end

class View
  include Mongoid::Document

  embedded_in :user

  #this is correct, view belongs to account, not user belongs to account
  belongs_to :account , polymorphic: true
  attr_accessible :account, :account_id, :account_type
  validates :account, :presence => true
end

describe View do

  let!(:account) { Account.create! }
  let!(:user) { User.create! }
  let!(:view) do
    user.views.build(
      :account_id => account.id,
      :account_type => account.class.name
    )
  end

  it "works" do
    user.save!
  end

  it "works" do
    view.save!(:validate => false)
  end

  it "doesn't work" do
    view.save!
  end

end

Failure:
$ rspec spec -f d -b

View
  works
  works
  doesn't work (FAILED - 1)

Failures:

  1) View doesn't work
     Failure/Error: view.save!
     NoMethodError:
       undefined method `insert_modifier' for #<Mongoid::Atomic::Paths::Root:0x00000003aa9058>
     # mongoid-2.3.4/lib/mongoid/atomic.rb:71:in `atomic_insert_modifier'
     # mongoid-2.3.4/lib/mongoid/persistence/operations.rb:65:in `inserts'
     # mongoid-2.3.4/lib/mongoid/persistence/operations/embedded/insert.rb:34:in `block in persist'
     # mongoid-2.3.4/lib/mongoid/persistence/insertion.rb:26:in `block (3 levels) in prepare'
     # activesupport-3.1.3/lib/active_support/callbacks.rb:390:in `_run_create_callbacks'
     # activesupport-3.1.3/lib/active_support/callbacks.rb:81:in `run_callbacks'
     # mongoid-2.3.4/lib/mongoid/callbacks.rb:42:in `block in run_callbacks'
     # mongoid-2.3.4/lib/mongoid/callbacks.rb:67:in `call'
     # mongoid-2.3.4/lib/mongoid/callbacks.rb:67:in `run_cascading_callbacks'
     # mongoid-2.3.4/lib/mongoid/callbacks.rb:41:in `run_callbacks'
     # mongoid-2.3.4/lib/mongoid/persistence/insertion.rb:25:in `block (2 levels) in prepare'
     # activesupport-3.1.3/lib/active_support/callbacks.rb:390:in `_run_save_callbacks'
     # activesupport-3.1.3/lib/active_support/callbacks.rb:81:in `run_callbacks'
     # mongoid-2.3.4/lib/mongoid/callbacks.rb:42:in `block in run_callbacks'
     # mongoid-2.3.4/lib/mongoid/callbacks.rb:67:in `call'
     # mongoid-2.3.4/lib/mongoid/callbacks.rb:67:in `run_cascading_callbacks'
     # mongoid-2.3.4/lib/mongoid/callbacks.rb:41:in `run_callbacks'
     # mongoid-2.3.4/lib/mongoid/persistence/insertion.rb:24:in `block in prepare'
     # mongoid-2.3.4/lib/mongoid/persistence/insertion.rb:22:in `tap'
     # mongoid-2.3.4/lib/mongoid/persistence/insertion.rb:22:in `prepare'
     # mongoid-2.3.4/lib/mongoid/persistence/operations/embedded/insert.rb:30:in `persist'
     # mongoid-2.3.4/lib/mongoid/persistence.rb:44:in `insert'
     # mongoid-2.3.4/lib/mongoid/persistence.rb:149:in `upsert'
     # mongoid-2.3.4/lib/mongoid/persistence.rb:70:in `save!'
     # ./spec/models/view_spec.rb:47:in `block (2 levels) in <top (required)>'
     # ... rspec cli/runner methods ...

Finished in 2.68 seconds
3 examples, 1 failure

Failed examples:

rspec ./spec/models/view_spec.rb:46 # View doesn't work

This particular failure occurs for me with v2.3.3, v2.3.4 and master (888d153f35).
Gemfile is:
source 'http://rubygems.org'

gem 'rails', '3.1.3'
#gem 'mongoid', '2.3.3'
#gem 'mongoid', '2.3.4'
gem 'mongoid', git: 'https://github.com/mongoid/mongoid'
gem 'bson_ext'
gem 'rspec-rails'
gem 'database_cleaner'

My bad, I see what's happening here now...

Current workaround:
belongs_to :account , polymorphic: true, inverse_of: nil

The problem here is the relation definitions are all messed up... The as: :account on Account thinks it's the inverse of the belongs_to on the View because it's polymorphic on both and the names match... But no link between the User would ever get saved because it's not linked to the account in any way, and the Account model cannot link to the embedded View model directly - that's not allowed in Mongoid in this manner... Here's what it should be:
class Account
  include Mongoid::Document
  has_many :users
end

class User
  include Mongoid::Document
  belongs_to :account
  embeds_many :views
end

class View
  include Mongoid::Document
  embedded_in :user
  belongs_to :account , polymorphic: true
  attr_accessible :account, :account_id, :account_type
  validates :account, :presence => true
end

If you want to get to the view from the account, you cannot go direct if you embed the view under a user...


sets minimal version to 3.0

EOL of 2.7 is less than 2 months, and we're not staffed to GA before that, https://endoflife.date/ruby https://azure.microsoft.com/en-us/updates/rubysupport

@Ndiritu thanks for the callout, pushed a change here, we'll push on the others soon

Might this also need manual updating? https://github.com/microsoft/kiota-http-ruby/blob/feature/ruby-version-align/lib/microsoft_kiota_faraday/version.rb

@Ndiritu thanks for the callout, pushed a change here, we'll push on the others soon

Might this also need manual updating? https://github.com/microsoft/kiota-http-ruby/blob/feature/ruby-version-align/lib/microsoft_kiota_faraday/version.rb

no, we're not releasing yet, we'll release with the next set of changes


add language&voice settings to Main_control

Unity modify ongoing --- just bump to a later version in case of solving collision

LGTM


Add Debug impls for public structs in Parquet crate

Which issue does this PR close?
N/A
Rationale for this change
This caught me when working on https://github.com/influxdata/influxdb_iox/pull/7855
I had to manually derive a Debug impl for a structure because the ArrowWriter didn't
What changes are included in this PR?

Add Debug impls for public structs in Parquet crate

Note that PR quickly got out of hand, but since I was in here I figured I would simply bash it out
Are there any user-facing changes?
More Debug!

Could we just manually implement Debug for the public components, this seems like an inordinate amount of complexity that isn't really useful to print anyway?

Will make a new PR with just the debug impls I want

https://github.com/apache/arrow-rs/pull/4278


Multiple return types of yield are not detected if one of them is None

When trying to compile some code, I got an error message asking me to submit a bug report, so I am doing so. A minimal reproducer is:
import numba as nb

@nb.njit
def test():
	yield None
	yield 1

g = test()

I guess the only bug here is in the error message, since if I change None to (for example) 'a', I get a message saying that the return types of yield are incompatible. With the code quoted above, I get the error message
Traceback (most recent call last):
  File "/Users/ndv/Library/Python/3.6/lib/python/site-packages/numba/errors.py", line 617, in new_error_context
    yield
  File "/Users/ndv/Library/Python/3.6/lib/python/site-packages/numba/lowering.py", line 259, in lower_block
    self.lower_inst(inst)
  File "/Users/ndv/Library/Python/3.6/lib/python/site-packages/numba/lowering.py", line 308, in lower_inst
    val = self.lower_assign(ty, inst)
  File "/Users/ndv/Library/Python/3.6/lib/python/site-packages/numba/lowering.py", line 482, in lower_assign
    res = self.lower_yield(ty, value)
  File "/Users/ndv/Library/Python/3.6/lib/python/site-packages/numba/lowering.py", line 505, in lower_yield
    self.call_conv.return_value(self.builder, retval)
  File "/Users/ndv/Library/Python/3.6/lib/python/site-packages/numba/targets/callconv.py", line 351, in return_value
    (str(retval.type), str(retptr.type.pointee))
AssertionError: ('{i64, i1}', 'i64')

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "minrep.py", line 8, in <module>
    g = test()
  File "/Users/ndv/Library/Python/3.6/lib/python/site-packages/numba/dispatcher.py", line 367, in _compile_for_args
    raise e
  File "/Users/ndv/Library/Python/3.6/lib/python/site-packages/numba/dispatcher.py", line 324, in _compile_for_args
    return self.compile(tuple(argtypes))
  File "/Users/ndv/Library/Python/3.6/lib/python/site-packages/numba/compiler_lock.py", line 32, in _acquire_compile_lock
    return func(*args, **kwargs)
  File "/Users/ndv/Library/Python/3.6/lib/python/site-packages/numba/dispatcher.py", line 655, in compile
    cres = self._compiler.compile(args, return_type)
  File "/Users/ndv/Library/Python/3.6/lib/python/site-packages/numba/dispatcher.py", line 82, in compile
    pipeline_class=self.pipeline_class)
  File "/Users/ndv/Library/Python/3.6/lib/python/site-packages/numba/compiler.py", line 926, in compile_extra
    return pipeline.compile_extra(func)
  File "/Users/ndv/Library/Python/3.6/lib/python/site-packages/numba/compiler.py", line 374, in compile_extra
    return self._compile_bytecode()
  File "/Users/ndv/Library/Python/3.6/lib/python/site-packages/numba/compiler.py", line 857, in _compile_bytecode
    return self._compile_core()
  File "/Users/ndv/Library/Python/3.6/lib/python/site-packages/numba/compiler.py", line 844, in _compile_core
    res = pm.run(self.status)
  File "/Users/ndv/Library/Python/3.6/lib/python/site-packages/numba/compiler_lock.py", line 32, in _acquire_compile_lock
    return func(*args, **kwargs)
  File "/Users/ndv/Library/Python/3.6/lib/python/site-packages/numba/compiler.py", line 255, in run
    raise patched_exception
  File "/Users/ndv/Library/Python/3.6/lib/python/site-packages/numba/compiler.py", line 246, in run
    stage()
  File "/Users/ndv/Library/Python/3.6/lib/python/site-packages/numba/compiler.py", line 717, in stage_nopython_backend
    self._backend(lowerfn, objectmode=False)
  File "/Users/ndv/Library/Python/3.6/lib/python/site-packages/numba/compiler.py", line 666, in _backend
    lowered = lowerfn()
  File "/Users/ndv/Library/Python/3.6/lib/python/site-packages/numba/compiler.py", line 653, in backend_nopython_mode
    self.metadata)
  File "/Users/ndv/Library/Python/3.6/lib/python/site-packages/numba/compiler.py", line 1048, in native_lowering_stage
    lower.lower()
  File "/Users/ndv/Library/Python/3.6/lib/python/site-packages/numba/lowering.py", line 184, in lower
    self.genlower.lower_next_func(self)
  File "/Users/ndv/Library/Python/3.6/lib/python/site-packages/numba/generators.py", line 153, in lower_next_func
    entry_block_tail = lower.lower_function_body()
  File "/Users/ndv/Library/Python/3.6/lib/python/site-packages/numba/lowering.py", line 244, in lower_function_body
    self.lower_block(block)
  File "/Users/ndv/Library/Python/3.6/lib/python/site-packages/numba/lowering.py", line 259, in lower_block
    self.lower_inst(inst)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/contextlib.py", line 99, in __exit__
    self.gen.throw(type, value, traceback)
  File "/Users/ndv/Library/Python/3.6/lib/python/site-packages/numba/errors.py", line 625, in new_error_context
    six.reraise(type(newerr), newerr, tb)
  File "/Users/ndv/Library/Python/3.6/lib/python/site-packages/numba/six.py", line 659, in reraise
    raise value
numba.errors.LoweringError: Failed in nopython mode pipeline (step: nopython mode backend)
('{i64, i1}', 'i64')

File "minrep.py", line 5:
def test():
	yield None
 ^

[1] During: lowering "$0.2 = yield $const0.1" at minrep.py (5)
-------------------------------------------------------------------------------
This should not have happened, a problem has occurred in Numba's internals.

Please report the error message and traceback, along with a minimal reproducer
at: https://github.com/numba/numba/issues/new

If more help is needed please feel free to speak to the Numba core developers
directly at: https://gitter.im/numba/numba

Thanks in advance for your help in improving Numba!

(I thought this was a different problem at first - I have edited this post to give a better minimal reproducer.)

Thanks for the report. Type inference should have caught this to prevent attempting to lower to a generator with a types.Optional (None + some_type) type. #3782 fixes.


Large line widgets slow down the editor due to forced reflows

Here's a sandbox showing the issue: https://codepen.io/anon/pen/zQGJMM
If I create a line widget with a large number of DOM nodes, then the CodeMirror instance quickly becomes laggy due to forced reflows. This seems to be because of how CodeMirror measures the line height in functions like updateHeightsInViewport, where it calculates display.lineDiv.offsetTop (the line widget is inside the lineDiv).
In the sandbox I cranked it up to 100k nodes inside the LineWidget to make the problem really noticeable (each edit takes almost 1 second on my computer) but the problem is still noticeable for smaller numbers of DOM nodes.
Is there anything I can do about this? My main use-case is to have a max-height on the LineWidget, so intuitively the height should always be fixed at the maximum when there are large numbers of nodes, so it seems like this should be possible to make fast. Any help would be greatly appreciated.

Note: turning on the "Verbose" log level in Chrome is a good way to see error messages related to this: recent Chrome outputs messages like [Violation] Forced reflow while executing JavaScript took 883ms

The way selection works in CodeMirror requires at least one extra forced layout on every update (have to know the selection's position in order to draw it), so unless you can somehow prevent the reflows from recomputing the entire layout in the widget (maybe contain helps here? I'm not sure), I don't see a solution here, except for kludges like putting an empty widget in the editor and overlaying an absolutely positioned element over it.

Thanks for the quick response! That's cool, I didn't know about contain. Playing in the codepen I can't seem to make it help though.
Huh, so that forced layout is unavoidable? I was reading this article about how forced layout can sometimes be avoided in favor of regular layout, if you order reads and writes in the right way. Is the fundamental issue something like you type a character, then you need to immediately know how wide the character is so that you can place the cursor after it before the next frame?

about how forced layout can sometimes be avoided in favor of regular layout, if you order reads and writes in the right way.

The editor already does a lot of ordering to minimize the amount of reflows, but yes, that one to measure the cursor position isn't avoidable. At least, not in the current architecture—version 6 will treat selection differently and not have this problem.

(That being said, each edit will produce at least one reflow no matter what, so if your DOM makes reflows take hundreds of milliseconds, you're going to have a problem either way.)

Got it, thanks -- I guess it's time for virtual DOM tricks. Closing this now...

I recognize that this issue is marked as closed by the author, but I am also experiencing the same issues with the same symptoms (severe slowdown due to the offsetTop calculation). I'm using CodeMirror to display an API result, and 2 identified use cases return around 90,000 lines. With that calculation only taking a millisecond or two per line, at 90,000 lines, it slows the page to an apparent halt.

I will certainly begin testing with the CSS contain you mentioned earlier, but will this component be updated to address the issue natively? Thanks for your time.


Fix issues pointed by other users in github

Fixes #1 ,#3, #4, #5 and #7.

Can't comment on the script that generates the graph, the rest look good to me. Thanks for your help!

Note problem explained here:
https://github.com/CoderPat/structured-neural-summarization/issues/4#issuecomment-482386587

Can't comment on the script that generates the graph, the rest look good to me. Thanks for your help!

Have you finished the experiment?

What I see is that TF is not happy with dealing with None tensors, so a workaround may be necessary to pass in None as labels.


[ruff] re and regex calls with unraw string as first argument (RUF051)

Summary
Resolves #11167.
Test Plan
cargo nextest run and cargo insta test.

I don't disagree with this overall, but it does mean that it gives you false positives for e.g.
https://github.com/RasaHQ/rasa/blob/7807b19ad5fffab73ca1a04dc710f812115a9288/rasa/utils/io.py#L223-L230

So maybe that's specific to escape sequences. Python regex support all other common escape sequences (with the exception of \b, which maps to word bounderies). It's, therefore, not required to use a raw string for \n.

Oh, \U escape sequences are now also supported. I then agree that it should always flag.

Changed in version 3.3: The '\u' and '\U' escape sequences have been added.

Changed in version 3.6: Unknown escapes consisting of '' and an ASCII letter now are errors.

Changed in version 3.8: The '\N{name}' escape sequence has been added. As in string literals, it expands to the named Unicode character (e.g. '\N{EM DASH}').

I haven't studied this in depth, but it overall seems reasonable to me, both in concept and implementation.
I wondered if we needed to take account of this footgun to do with raw strings (they cannot end with an odd number of backslashes). But I think we should be fine, since that documentation states:

Raw strings were designed to ease creating input for processors (chiefly regular expression engines) that want to do their own backslash escape processing. Such processors consider an unmatched trailing backslash to be an error anyway, so raw strings disallow that. In return, they allow you to pass on the string quote character by escaping it with a backslash. These rules work well when r-strings are used for their intended purpose.


Nav styling is slightly different between home page and gitbook

Likely some gitbook styles we need to hunt down.

@kerrishotts putting you down as the owner since it's related to Gitbook :)


N7edPMiO: Improve MSA Logging

What
MSA logs don't contain a lot of useful information. It's hard to use them to identify what a problem is.
We should implement error logging changes to the MSA so that the full stacktrace is returned to the Verify Hub when an HTTP 500 error happens in the MSA.
There is some further background in Anshul's investigation into MSA 500 errors.
Original Zendesk ticket:
https://govuk.zendesk.com/agent/tickets/3651026
How
Rename flag returnStackTraceInResponse and set default to true
This will ensure that all MSAs will return stack trace to us unless we
explicitly ask them to set the flag to false in config.

 Improve MSA logging

Also needs updating here:
https://github.com/alphagov/verify-matching-service-adapter/blob/89eddd5df5c73be0609d95a364632a416343f519/configuration/example-lms-msa.yml#L59
And the acceptance tests at some point: https://github.com/alphagov/ida-hub-acceptance-tests/blob/2743909f441eedce06e39bf6c1b30d0933c61d97/configuration/test-rp-msa.yml#L67

Good point, well made ... new commit containing config file updates.


Wallet Connect only shows 'cancel' button when insufficient SOL

When connecting the Helium Wallet to a dApp, the current logic hides the Connect button if the user has insufficient SOL. Users should still be allowed to connect even if they do not have enough SOL.

This should be fixed in the latest release!

(on testflight right now, will go live soon)


ci: testing script changes for Kokoro ubuntu migration

Do not merge.
PR for testing script fixes needed for compatibility with kokoro ubuntu migration.

[ ] Todo: make similar changes in continuous scripts when presubmit issues are resolved

Docker container removal issue resolved.
Build now fails on javadoc warning:
> Task :jib-core:javadoc
...
Starting process 'command '/usr/lib/jvm/java-8-openjdk-amd64/bin/javadoc''. Working directory: /tmpfs/src/github/jib/jib-core Command: /usr/lib/jvm/java-8-openjdk-amd64/bin/javadoc @/tmpfs/src/github/jib/jib-core/build/tmp/javadoc/javadoc.options
Successfully started process 'command '/usr/lib/jvm/java-8-openjdk-amd64/bin/javadoc''
/tmpfs/src/github/jib/jib-core/src/main/java/com/google/cloud/tools/jib/configuration/BuildContext.java:556: warning - Tag @link: reference not found: RegistryClient.Factory

Re-opening to continue with testing.

In attempt to reach local registry through HTTP through registry container IP instead of localhost, an additional workaround is needed here, e.g. a way to add these ephemeral IPs as insecure registries. Otherwise the following error is encountered:
com.google.cloud.tools.jib.registry.ManifestPullerIntegrationTest STANDARD_ERROR
    Feb 09, 2023 3:24:17 PM com.google.cloud.tools.jib.registry.LocalRegistry waitUntilReady
    INFO: DockerHost: <IP_ADDRESS>
    Feb 09, 2023 3:24:17 PM com.google.cloud.tools.jib.registry.LocalRegistry waitUntilReady
    INFO: URL: http://<IP_ADDRESS>:5000/v2/_catalog

com.google.cloud.tools.jib.registry.ManifestPullerIntegrationTest > classMethod FAILED
    java.lang.RuntimeException: Command 'docker push <IP_ADDRESS>:5000/busybox' failed: Get "https://<IP_ADDRESS>:5000/v2/": http: server gave HTTP response to HTTPS client

Mapping the local registry container IP to localhost in /etc/hosts gets past the insecure registries issue, and presubmit is unblocked so far. On continuous, integration tests for Jib CLI also run into this problem when running the jar/war applications locally in docker:
com.google.cloud.tools.jib.cli.JarCommandTest > testSpringBootJar_packagedMode FAILED
    value of: getContent(...)
    expected: Hello world
    but was : null
        at com.google.cloud.tools.jib.cli.JarCommandTest.testSpringBootJar_packagedMode(JarCommandTest.java:298)

com.google.cloud.tools.jib.cli.WarCommandTest > testWar_customJettySpecified FAILED
    value of: getContent(...)
    expected: Hello world
    but was : null
        at com.google.cloud.tools.jib.cli.WarCommandTest.testWar_customJettySpecified(WarCommandTest.java:127)

After splitting up the test suite and testing locally, logging a couple more errors to resolve:
./gradlew clean build :jib-gradle-plugin:integrationTest --info --stacktrace

A number of docker login issue that could be similar to https://github.com/GoogleContainerTools/jib/pull/3598#issuecomment-1168720770

com.google.cloud.tools.jib.gradle.SingleProjectIntegrationTest > testBuild_dockerDaemonBase FAILED
    java.lang.RuntimeException: Command 'docker login localhost:5000 -u testuser --password-stdin' failed: Error response from daemon: login attempt to http://localhost:5000/v2/ failed with status: 401 Unauthorized
        at com.google.cloud.tools.jib.Command.run(Command.java:79)
        at com.google.cloud.tools.jib.registry.LocalRegistry.login(LocalRegistry.java:199)
        at com.google.cloud.tools.jib.registry.LocalRegistry.pullAndPushToLocal(LocalRegistry.java:188)
        at com.google.cloud.tools.jib.gradle.SingleProjectIntegrationTest.setup(SingleProjectIntegrationTest.java:168)

In SpringBootProjectIntegrationTest and WarProjectIntegrationTest, errors likely similar to ones from jib-cli above:

com.google.cloud.tools.jib.gradle.SpringBootProjectIntegrationTest > testBuild_packagedMode FAILED
    java.lang.AssertionError: expected:<Hello world> but was:<null>
        at org.junit.Assert.fail(Assert.java:89)
        at org.junit.Assert.failNotEquals(Assert.java:835)
        at org.junit.Assert.assertEquals(Assert.java:120)
        at org.junit.Assert.assertEquals(Assert.java:146)
        at com.google.cloud.tools.jib.gradle.SpringBootProjectIntegrationTest.testBuild_packagedMode(SpringBootProjectIntegrationTest.java:62)

com.google.cloud.tools.jib.gradle.WarProjectIntegrationTest > testBuild_jettyServlet25 FAILED
    java.lang.AssertionError: expected:<Hello world> but was:<null>
        at org.junit.Assert.fail(Assert.java:89)
        at org.junit.Assert.failNotEquals(Assert.java:835)
        at org.junit.Assert.assertEquals(Assert.java:120)
        at org.junit.Assert.assertEquals(Assert.java:146)
        at com.google.cloud.tools.jib.gradle.WarProjectIntegrationTest.verifyBuildAndRun(WarProjectIntegrationTest.java:66)
        at com.google.cloud.tools.jib.gradle.WarProjectIntegrationTest.testBuild_jettyServlet25(WarProjectIntegrationTest.java:49)

./gradlew clean build :jib-maven-plugin:integrationTest --info --stacktrace
BuildImageMojoIntegrationTest also encounters issue with docker login in setup step involving local registry
https://github.com/GoogleContainerTools/jib/blob/fa8cc958f4ddad55a9eba043fdfd7c32eddb49b6/jib-maven-plugin/src/integration-test/java/com/google/cloud/tools/jib/maven/BuildImageMojoIntegrationTest.java#L337-L339
com.google.cloud.tools.jib.maven.BuildImageMojoIntegrationTest > testBuild_dockerDaemonBase FAILED
    java.lang.RuntimeException: Command 'docker login localhost:5000 -u testuser --password-stdin' failed: Error response from daemon: login attempt to http://localhost:5000/v2/ failed with status: 401 Unauthorized
        at com.google.cloud.tools.jib.Command.run(Command.java:79)
        at com.google.cloud.tools.jib.registry.LocalRegistry.login(LocalRegistry.java:199)
        at com.google.cloud.tools.jib.registry.LocalRegistry.pullAndPushToLocal(LocalRegistry.java:188)
        at com.google.cloud.tools.jib.maven.BuildImageMojoIntegrationTest.setUp(BuildImageMojoIntegrationTest.java:382)

Though blocked on this early step, I suspect some tests here that make use of localhost through buildAndRunWebApp (and perhaps pullAndRunBuiltImage) will also need host IP workarounds similar to issues above.

Presubmit and continuous seem to be passing in the new environment as of https://github.com/GoogleContainerTools/jib/pull/3886/commits/6e1992ef7d86dc229a3cf31d2ac6d2e3685d511f! Will clean up the debug logging and code changes introduced to get this PR ready for merge.


Standard flake8 violation with prefix, e.g. ISC001

Looking at the code and confirming with a test, your plugin returns messages like this:
$ flake8 example.py
example.py:line:column implicit-str-concat implicitly concatenated string literals on one line

The flake8 select/ignore options assume an alpha-numeric naming prefix, here I would suggest ISC for implicit string concatenation for your plugin, thus ISC001 for this message:
$ flake8 example.py
example.py:line:column ISC001 implicitly concatenated string literals on one line

(Update: Fixed consistent typo - was autocorrect fighting me again?)

@peterjc can you create a PR for this please?

@peterjc where is this prefix format documented?

Here's some documentation:

http://flake8.pycqa.org/en/2.5.5/warnings.html

Here's another Flake8 plugin which has its own YTT prefix:

https://github.com/asottile/flake8-2020/

It's useful so you can do things like flake8 --select YTT.

@hugovk that's only for flake8 2, I only support flake8 3 which as far as I was aware dropped that limitation

python3 -m flake8 --select implicit-str-concat still works for me

Right you are.
http://flake8.pycqa.org/en/latest/plugin-development/registering-plugins.html shows examples of using error codes.
It's maybe not essential but would make it easier to use.

@hugovk easier to use in what way? I could introduce implicit-str-concat-oneline and implicit-str-concat-continuation later and both would be selected by python3 -m flake8 --select implicit-str-concat

Less typing, consistency with other plugins. But not a big deal :)

Consistency with A123 or the now recommended ABC123 pattern will also help with third party tools like editors and IDEs which support flake8.

@peterjc those IDEs and editors should be updated to support the full gamut of error IDs supported by flake8

Getting IDEs to adapt to ABC123 as well as A123 style which is a simple regex change has taken enough effort - complete free format is just making extra work for everyone. e.g. Doing summary statistics on a code base.

or the now recommended ABC123

there's currently no recommendation only a note of consideration

I've commented on the flake8 issue - I would much prefer the flake8 documentation were more explicit about recommending ABC123 style (to the point that were it my choice I'd make anything else an error in flake8).

See https://gitlab.com/pycqa/flake8/issues/597 following discussion on https://gitlab.com/pycqa/flake8/merge_requests/385 - an alphanumeric style is expected (although not necessarily as strict as ABC123 that remains the suggestion).

@peterjc  https://github.com/keisheiled/flake8-implicit-str-concat/pull/7
I really strongly prefer readable error codes like eslint and pylint perhaps flake8 4 can use a more inclusive regex

Personal taste in the end - and we clearly differ on this point - but best to confirm to the flake convention if writing a flake8 plugin.


Request being parsed before handler runs?

Hi,
In my application I'm taking a file upload from a user, which may be very large (GBs).
I'd like to do some operations before finally iterating over the request body in chunks (and writing to a file), however as far as I can tell the function I decorate with the endpoint does not seem to run until the upload is complete.
This seems counter to what I expect, given a lot of discourse online about streaming request data (what's there to stream if it's already been taken in/saved?).
Am I missing something, or does Flask (or the underlying werkzeug) always parse/read the data before running the function?
My request looks like this (in cURL format), I've included all headers there, however I'm fairly sure most are irrelevant
curl 'https://mysite.com/api/v1/upload?filename=blah\
  -H 'authority: mysite.com' \
  -H 'pragma: no-cache' \
  -H 'cache-control: no-cache' \
  -H 'accept: application/json' \
  -H 'x-requested-with: XMLHttpRequest' \
  -H 'user-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/73.0.3683.105 Safari/537.36' \
  -H 'content-type: multipart/form-data; boundary=----WebKitFormBoundary3xjJcHpMfz6sMB8p' \
  -H 'dnt: 1' \
  -H 'accept-language: en-US,en;q=0.9' \
  -H 'origin: https://mysite.com \
  -H 'sec-fetch-site: same-origin' \
  -H 'sec-fetch-mode: cors' \
  -H 'sec-fetch-dest: empty' \
  -H 'referer: https://mysite.com/' \
  -H 'cookie: session=eyJwcm9qZWN0LWlkIjoielVyTDl0Y3NKZGcyIn0.YMOC2w.Y1lZvTSczWPy6HAaNaZtAGz44LU' \
  --data-raw $'------WebKitFormBoundary3xjJcHpMfz6sMB8p\r\nContent-Disposition: form-data; name="file"; filename="blah"\r\nContent-Type: application/pdf\r\n\r\n\r\n------WebKitFormBoundary3xjJcHpMfz6sMB8p--\r\n' \

And here's the simple test application I'm using
@app.route('/', methods = ["POST"])
def hello_world2():
    print(f"test2 start {time_ns()}")

    with open("/tmp/fileoutput", "bw") as f:
        chunk_size = 4096

        while True:
            chunk = request.stream.read(chunk_size)

            if len(chunk) == 0:
                print(f"test2 end: {time_ns()}")
                break

            f.write(chunk)

    return ''

In such a case, I notice the inital print does not happen for a long time, where the length of time is dependant on the size of the file uploaded, so I assume it's reading it in some way.
Thanks

I can't reproduce this issue. "start" is printed immediately, and "end" is printed after writing out the stream. I tried with a 1.2GB body. Flask and the Werkzeug dev server do not buffer the input stream before handling the request.

Apologies, you were indeed correct.
If anyone ever finds this in the future, the issue was that I had Flask behind Nginx, which buffers requests.
The solution is to disable proxy_request_buffering

For others, that option exists for a reason, and some WSGI servers such as Waitress also have that behavior. Evaluate your project's needs before enabling or disabling the option.