tests, network: Test connectivity pre/post migration

What this PR does / why we need it:
Live migration is (partially) supported when using masquerade binding
on the primary network.
A new test is introduced, checking the VMI connectivity before and after
the migration.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Depends on #3883
Release note:
NONE

/cc @AlonaKaplan @phoracek

Needs more work, the ping is not working after the migration.
/hold

Changes:

Rebased over #3883
The ping is targetting the virt-handler (instead of the GW, e.g. the bridge at the virt-launcher).

Issues:
Based on the test results, post migration there is no connectivity.
This has been identified as a real problem due to the arp entry of the GW which still points to the source pod bridge mac address.

Issues:
Based on the test results, after the migration, there is no connectivity.
This has been identified as a real problem due to the arp entry of the GW which still points to the source pod bridge mac address.

In order to overcome this limitation, traffic is now generated towards the VM post migration (by the test).
This will need to be addressed by the production code as well at some point.

/retest

/topic network

/label topic/network

/sig network

/topic network

/label topic/testing

/label "topic/testing"

/topic testing

/label topic testing

/retest

It is flaky.
Use jobs instead of pods (now that the helpers got in).

/hold

/lgtm

/hold cancel

Wait for the dependent PR to get in.
/hold

/hold cancel

/lgtm cancel
https://github.com/kubevirt/kubevirt/pull/3871#discussion_r475453121

change: Just a rebase.

change: Do not specify Job TTL (only use the default) in the ping-app and make sure the job is cleaned by the test.

/lgtm

/sig network

/approve
/retest

/retest


Fineract-267 (Foreclosure Issue: Loan with Installment fee status is overpaid)

Please send PR https://github.com/apache/incubator-fineract. This repository is only for MifosX distributions.


Rename system_networkState to system_unstable_networkState

Renames this JSON-RPC function in order to make it clear that has never been intended to be stable nor long-term.
This is a breaking change. If you had an automatic script that is using system_networkState, which you weren't supposed to do in the first place, then it will break.
If you were using this function to get the local PeerId and listened addresses, then I invite you to use system_localPeerId and system_localListenAddresses instead.
cc https://github.com/paritytech/substrate/issues/5541

Nodes send this "network state" to the telemetry, which then shows it in the UI.
The telemetry however doesn't do any JSON-RPC call (unless you're talking about a different telemetry), so it's not affected.

Nodes send this "network state" to the telemetry, which then shows it in the UI.
The telemetry however doesn't do any JSON-RPC call (unless you're talking about a different telemetry), so it's not affected.

Could someone else approve this PR?

Thanks!

bot merge


Fixes and improvements to _consume_request.

In the case that a request has no Content-Length header, the changes in #15 to fix #12 cause _consume_request to still try to read up to read_max_on_auth_fail bytes from the socket. But that socket read call hangs when the client actually has no data to send until a timeout is reached (at which point the timeout exception is swallowed and processing continues).
Instead, when there is no Content-Length, revert to no longer even trying to read the request body even though this means not supporting Transfer-Encoding: chunked requests, since there is no good way to guarantee that the read call won't hang indefinitely. Ref: https://werkzeug.palletsprojects.com/en/1.0.x/request_data/#missing-eof-marker-on-input-stream

Only read at most io.DEFAULT_BUFFER_SIZE bytes at a time to limit buffering of discarded request data in memory.

Don't even try to read bodies of GET, DELETE, TRACE, OPTIONS, or HEAD
requests. Ref: https://specs.openstack.org/openstack/api-wg/guidelines/http/methods.html

@propertone, do these changes resolve any of the issues you saw with the changes in #15 that prompted you to open #27?

@propertone, do these changes resolve any of the issues you saw with the changes in #15 that prompted you to open #27?

Note, I've tested these changes both with the Werkzeug-based Flask development WSGI server and Gunicorn and confirmed this resolves the issues introduced in #15.

Note, I've tested these changes both with the Werkzeug-based Flask development WSGI server and Gunicorn and confirmed this resolves the issues introduced in #15.


zone.js:634 Uncaught TypeError: NativePromise.resolve is not a function

Description

Got the following error in the console.
zone.js:634 Uncaught TypeError: NativePromise.resolve is not a function
at Object.setNativePromise (zone.js:634)
at desc.set (zone.js:1028)
at module.exports (index.umd.js:23472)
at $export (index.umd.js:19423)
at Object.eval (index.umd.js:32227)
at webpack_require (index.umd.js:17700)
at Object.eval (index.umd.js:43285)
at webpack_require (index.umd.js:17700)
at exports.__esModule (index.umd.js:17743)
at eval (index.umd.js:17746)
setNativePromise @ zone.js:634
desc.set @ zone.js:1028
module.exports @ index.umd.js:23472
$export @ index.umd.js:19423
(anonymous) @ index.umd.js:32227
webpack_require @ index.umd.js:17700
(anonymous) @ index.umd.js:43285
webpack_require @ index.umd.js:17700
exports.__esModule @ index.umd.js:17743
(anonymous) @ index.umd.js:17746
webpackUniversalModuleDefinition @ index.umd.js:17673
map../af @ index.umd.js:17680
webpack_require @ index.umd.js:30
(anonymous) @ index.umd.js:4599
webpack_require @ index.umd.js:30
Object.defineProperty.value @ index.umd.js:16935
webpack_require @ index.umd.js:30
(anonymous) @ index.umd.js:16980
webpack_require @ index.umd.js:30
(anonymous) @ index.umd.js:76
(anonymous) @ index.umd.js:79
webpackUniversalModuleDefinition @ index.umd.js:3
(anonymous) @ index.umd.js:10
../../../../angular-handsontable/bundles/index.umd.js @ vendor.bundle.js:6
webpack_require @ inline.bundle.js:55
(anonymous) @ app.module.ts:4
../../../../../src/app/app.module.ts @ main.bundle.js:36
webpack_require @ inline.bundle.js:55
(anonymous) @ main.ts:4
../../../../../src/main.ts @ main.bundle.js:52
webpack_require @ inline.bundle.js:55
0 @ main.bundle.js:67
webpack_require @ inline.bundle.js:55
webpackJsonpCallback @ inline.bundle.js:26
(anonymous) @ main.bundle.js:1
Steps to reproduce

created a new app "ng new hot"
Edited the various files as recommended in the documentation.
ran "ng serve"
Got the error message listed above.
Note using Angular version 5.0.0

Demo
Your environment

Wrapper version: 0.34.4
Browser Name and version: Chrome Version 63.0.3239.84 (Official Build) (64-bit)
Operating System: Lubuntu 17.1

Ah! There is already a similar issue at https://github.com/handsontable/angular-handsontable/issues/34 Closing this issue and following the other one.


Fix focus outline oddly rendered for some action icons when panel is on the side

This PR fixes #117833

This looks good to me. However I would like if @misolori could also code review.
I have verified this indeed fixes the issue -> approved

Merging in and if @misolori has feedback I can tackle it after the merge


create an xml version of every html page

for example:
https://feed.bitcoinsearch.xyz/thread/bitcoin-dev/July_2023.html
and
the root https://feed.bitcoinsearch.xyz as well

Closing this as it refers to a previous flavor of the TLDR implementation.


Add a method to generate CachedCellImg< LabelMultisetType, ? > from n5 reader and dataset

Currently, there is no convenience method to open a LabelMultisetType dataset as a CachedCellImg< LabelMultisetType, ? >.
I suggest we introduce a LabelMultisets helper class that provides this method (and potentially more in the future). For reference, have a look at https://github.com/saalfeldlab/paintera/blob/fad335219e3c0c9089d69d0c467e578d34ecd8cb/src/main/java/org/janelia/saalfeldlab/paintera/N5Helpers.java#L669-L697:
		final N5CacheLoader loader = new N5CacheLoader( reader, dataset );
		final SoftRefLoaderCache< Long, Cell< VolatileLabelMultisetArray > > cache = new SoftRefLoaderCache<>();
		final LoaderCacheAsCacheAdapter< Long, Cell< VolatileLabelMultisetArray > > wrappedCache = new LoaderCacheAsCacheAdapter<>( cache, loader );
		final CachedCellImg< LabelMultisetType, VolatileLabelMultisetArray > cachedImg = new CachedCellImg<>(
				new CellGrid( attrs.getDimensions(), attrs.getBlockSize() ),
				new Fraction(),
				wrappedCache,
				new VolatileLabelMultisetArray( 0, true, new long[] { Label.INVALID } ) );
		cachedImg.setLinkedType( new LabelMultisetType( cachedImg ) );

We should have both a LabelMultisets.open and a LabelMultisets.openVolatile method as in n5-imglib2's N5Utils.
cc @axtimwalde

It seems to be already available here: https://github.com/saalfeldlab/n5-label-multisets/blob/master/src/main/java/net/imglib2/type/label/LabelUtils.java#L161-L167

Unfortunately, we will need more than that, as we cannot just user VolatileViews.wrapAsVolatile, even when opening via openVolatile.
We could adopt the way it's done in Paintera but maybe that (the code wraps as volatile and is independent of multiset types) could even go into imglib2, but that would require some careful considerations first

True.  I think it would be better to break API in n5-imglib2 and make open always use VolatileAccess, and make openAsVolatile return the VolatileType version, i.e. for primitive types using wrapAsVolatile, and for LabelMultisetType use the method from Paintera.  That way, N5Utils would support both primitive types and LabelMultisetType the same way, even if the path towards that goal is different.  If unification of that path seems appropriate it can happen behind that surface.

This is available in https://github.com/saalfeldlab/n5-imglib2/pull/10


Segmentation fault (core dumped) when doing nextpnr

I get the following error message during the bring-up make sequence:
nextpnr-ice40 --no-promote-globals --pre-pack data/clocks.py --seed 1
--up5k --package sg48
-l /home/ubuntu/testboard/pyfive-mpw1-postmortem/icebreaker/bringup/build-tmp/pyfive_test.pnr.rpt
--json /home/ubuntu/testboard/pyfive-mpw1-postmortem/icebreaker/bringup/build-tmp/pyfive_test.json
--pcf /home/ubuntu/testboard/pyfive-mpw1-postmortem/icebreaker/bringup/data/top-icebreaker.pcf
--asc /home/ubuntu/testboard/pyfive-mpw1-postmortem/icebreaker/bringup/build-tmp/pyfive_test.asc
../build/project-rules.mk:91: recipe for target '/home/ubuntu/testboard/pyfive-mpw1-postmortem/icebreaker/bringup/build-tmp/pyfive_test.asc' failed
make: *** [/home/ubuntu/testboard/pyfive-mpw1-postmortem/icebreaker/bringup/build-tmp/pyfive_test.asc] Segmentation fault (core dumped)
Do you know what the issue might be? I am on Ubuntu 18.04.5
Thank you
Armagan

You need to report that to nextpnr repo ... it shouldn't ever segfault no matter what.


[PAID] [$1000] Bug: Tooltip gets stuck on the page reported by @Puneet-here

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Decrease the screen size
Hover over any contact at chat navigator
When the tooltip appears open the chat
Hover at back button until the tooltip shows up then press back

Expected Result:
The tooltip should go away
Actual Result:
The tooltip should doesn't go away
Workaround:
unknown
Platform:

Where is this issue occurring?

Web
Desktop App

Version Number: 1.2.18-2
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/196830711-438ca9f7-1bbd-44df-80a2-3bf7e0b9ff01.mp4
https://user-images.githubusercontent.com/43996225/196830700-9a924829-e70f-4121-bd50-80e148d1fc91.mov
Expensify/Expensify Issue URL:
Issue reported by: @Puneet-here
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1666210802145239
View all open jobs on GitHub

looks like a solid external @chiragsalian ? can you do the honours pls :)

Yup, adding label.

https://www.upwork.com/jobs/~01a51c9760a2d3a8c8

not overdue, still looking for proposals

Price increased to $500

@rushatgabhane Let me first explain that I'm new here and I'm learning so I apologize ahead of time if I'm wrong. I looked at @Ollyws code and tested it locally. It does work for me. I'm not sure exactly how it could lead to a race condition like you suggested. Since setState is always called now and not wrapped in a conditional, it seems like a solid solution so I'm wondering what I am missing here. Thanks!

Bumped in Slack https://expensify.slack.com/archives/C01GTK53T8Q/p1667826775048499?thread_ts=1666210802.145239&cid=C01GTK53T8Q and set price to $1000

@mmarceau @Ollyws any further ideas yet?

It is quite interesting to see this detailed comment
https://github.com/Expensify/App/blob/c02031489b46200f95d19bfda1e0c048cb99bb45/src/components/Hoverable/index.js#L62-L67
What do we miss?
https://github.com/Expensify/App/blob/c02031489b46200f95d19bfda1e0c048cb99bb45/src/components/Tooltip/index.js#L187-L192
+ resetsOnClickOutside={true}

https://github.com/Expensify/App/blob/c02031489b46200f95d19bfda1e0c048cb99bb45/src/components/Hoverable/index.js#L71-L78
-     if (this.wrapperView && !this.wrapperView.contains(event.target) && this.props.resetsOnClickOutside) {
-         this.setIsHovered(false);
-     }
+        if ((this.wrapperView && !this.wrapperView.contains(event.target)) || this.props.resetsOnClickOutside) {
+           this.setIsHovered(false);
+       }

Result
https://user-images.githubusercontent.com/75031127/200337163-1ef1fbc0-f5ff-4986-807a-d22cadc27c75.mp4

Nice proposal, LGTM as well. Feel free to create the PR @getusha.

Thank you @chiragsalian @rushatgabhane for assigning me.
I will apply for the job on upwork now. the price is not up to date on UW hope it will get updated soon.

Applied.
Will submit the PR in short.

Offers out in Upwork for everyone with correct pricing

@laurenreidexpensify Thanks Accepted.

@laurenreidexpensify Wanted to make sure you have visibility on the regression in the linked PR. Let's wait for that to play out until the BZ checklist is filled out.

Caused this regression https://github.com/Expensify/App/issues/12685.

Updated BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@chiragsalian @rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@chiragsalian @rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@chiragsalian @rushatgabhane]  A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@laurenreidexpensify] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:
[ ] [@laurenreidexpensify] Applicable payments have been made. This potentially includes the issue reporter, the contributor that fixed the issue, and/or the contributor+ that helped on the issue.

@chiragsalian @rushatgabhane can you link the PR you think caused the regression in the comment above? Thanks

Regression test buddy check here https://expensify.slack.com/archives/C01SKUP7QR0/p1669220417075829

Updated the first two. Not sure what to do about the third. It was discussed on slack and not in expensify-bugs. So should we start a discussion in #expensify-bugs?

@Puneet-here @rushatgabhane @getusha payment has been issued in Upwork 👍

PR merged within 3 business days. so we're eligible for the 50% bonus?

@getusha @rushatgabhane bonus sent 👍🏽

It doesn't seem that #12572 fixed the issue completely. Issue reported again https://github.com/Expensify/App/issues/13947

@situchan this approach was overwritten here https://github.com/Expensify/App/issues/13146


How should we define bool columns?

I get a build error when I define a column as Boolean in the SQLite database. Something about Bool not conforming to MappedColumn.

Should be fixed in 1.0.14, it was really just lacking the necessary conformance. Added.

Amazing turn around, thanks!


Add IDEA templates. Dark themes look OK, light themes need improvements.

I added Intellij IDEA templates. They should look OK for all popular languages. Dark themes are all right while light themes mostly suffer from poor contrast.

Sorry to reopen this, but could you update the template? This does not work with newer versions of IDEA.


Double Tapping Options Row Navigating Twice Fix And Navigation Refactoring To Resolve It From Queueing When There’s Already a Navigation Is In Progress

Details

Part 1
Updating OptionRow so that it:

Refactoring selectRow function to return Promise which is waited to resolve before enabling TouchableOpacity.
Disables the TouchableOpacity in its onPress callback
Saves a reference to the value returned by props.onSelectRow.
Calls InteractionManager.runAfterInteraction, and in the callback to runAfterInteraction:
Checks if the value from 2.iii is a promise. If so, wait for the promise to resolve.
Then re-enables the TouchableOpacity (or rather, returns it to the value of props.isDisabled)

Part 2
Updating the Navigation lib:

Update canNavigate to:

First, to checks if isNavigating is true. If it is, it returns a new promise that resolves to false and logs a message.
Summary : The "isNavigating" variable in this function is used to prevent multiple executions of the promise that navigates to a new screen. It first checks if navigation is already in progress by checking the "isNavigating" variable, and if so, it resolves with "false" and logs a message indicating that the navigation failed because it was already in progress. If navigation is not in progress, it checks if the navigation reference is ready and if not, it resolves with "false" and logs a message indicating that the navigation failed because the reference was not yet ready. This ensures that only one navigation promise can be executed at a time.

If isNavigating is false, it returns a new promise that: uses the InteractionManager.runAfterInteractions() method to wait for any ongoing interactions to finish.
i.  checks if the navigationRef is ready and isNavigating is false.
ii. If both conditions are met, the promise resolves to true.
iii. If not, it logs a message and the promise resolves to false.

Update all canNavigate usage to resolve promise before executing navigation.

Fixed Issues

$ https://github.com/Expensify/App/issues/14258
PROPOSAL: https://github.com/Expensify/App/issues/14258#issuecomment-1396129497
Tests

Open a chat in the app
Tap on the "+" icon
Select "Send money" or "Request money"
Tap on the currency displayed to change it
From the list of currencies, double-tap on the desired currency to select it.
Verify that user is taken to the previous screen with the selected currency

[x] Verify that no errors appear in the JS console

QA Steps

Open a chat in the app
Tap on the "+" icon
Select "Send money" or "Request money"
Tap on the currency displayed to change it
From the list of currencies, double-tap on the desired currency to select it.
Verify that user is taken to the previous screen with the selected currency

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://user-images.githubusercontent.com/81307212/213588009-9fdcf7ef-7d42-42a4-ba35-8854e6011af1.mp4

Mobile Web - Chrome

https://user-images.githubusercontent.com/81307212/213588341-495d49d7-8c29-4d0c-a6ce-685b0db474ad.mp4

Mobile Web - Safari

https://user-images.githubusercontent.com/81307212/213588589-55b9cc3f-73d3-4a8e-9cb3-2c197e42c1e6.mp4

Desktop

https://user-images.githubusercontent.com/81307212/214315380-c59121c0-0a1c-49c7-9e24-01b4cac12caf.mp4

iOS

https://user-images.githubusercontent.com/81307212/213588984-a4125db2-9bb5-4e14-9ed0-94db51838179.mp4

Android

https://user-images.githubusercontent.com/81307212/213589710-73189fe0-6f40-4b6c-a1c2-b56a4099be35.mp4

@syedsaroshfarrukhdot Friendly reminder to either:

link the App issue correctly when you create the PR straight off
first make draft, fill in all the details and once the PR body is ready, mark it ready for a review.

Then the correct people will be assigned for a review 🙌 Thank you 🙇

@syedsaroshfarrukhdot Friendly reminder to either:

link the App issue correctly when you create the PR straight off
first make draft, fill in all the details and once the PR body is ready, mark it ready for a review.
Then the correct people will be assigned for a review 🙌 Thank you 🙇

Thank you for highlighting. It was my bad to not link issue correctly before making it as as draft. Will make sure next time this doesn't happen.

Thank you for highlighting. It was my bad to not link issue correctly before making it as as draft. Will make sure next time this doesn't happen.

No problem at all! Thanks for taking this into consideration 🙇

At this point, src/libs/onScreenTransitionEnd.js and src/libs/onScreenTransitionStart.js seem pretty useless. Let's just get rid of them and use navigation.addListener directly.

@roryabraham Like the below snippet as I was using before right ? If Yes, I also agree it make more sense to us navigation.addListener directly. Are we going waiting to discuss this or should I make changes  ?
this.unsubscribeTransitionStart = this.props.navigation.addListener('transitionStart', () => {}

this.unsubscribeTransitionEnd = this.props.navigation.addListener('transitionEnd', () => {}

@syedsaroshfarrukhdot, I agree with @roryabraham, let's just use listeners directly

@syedsaroshfarrukhdot, I agree with @roryabraham, let's just use listeners directly

That's great. Just pushed the latest code with navigation.addListener using it directly.

@syedsaroshfarrukhdot, I agree with @roryabraham, let's just use listeners directly

Done

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@syedsaroshfarrukhdot, please add the last step to testing steps: Verify that user is taken to the previous screen with the selected currency

There's a noticeable delay when you try to select a currency for the second and subsequent time.
https://user-images.githubusercontent.com/9059945/214374652-8fc5dbce-5356-4b89-a5d9-3f961fd4655c.mp4
But it doesn't seem to be the case for iOS and Android. Could it be the problem with InteractionManager for web?

There's a noticeable delay when you try to select a currency for the second and subsequent time.
Screen_Recording_20230124-200851_Chrome.mp4
But it doesn't seem to be the case for iOS and Android. Could it be the problem with InteractionManager for web?

Most probably it could be the issue with InteractionManager. For now I am stick with infinite loading with in our app. As soon as the infinite loading is resolved I would look for what can be done to fix delay on Web.

@eVoloshchak I wasn't able to reproduce delay on Web, mWeb/Safari and mWeb/Chrome.
https://user-images.githubusercontent.com/81307212/214452905-cb6c3cf0-0699-41b8-b5fb-01f176ca24dd.mov
https://user-images.githubusercontent.com/81307212/214452917-fa8042e4-89a1-41be-b496-08460c699e0b.mov
https://user-images.githubusercontent.com/81307212/214453848-d5dc3407-15da-4e7d-af2c-edae78c903fc.mp4

@syedsaroshfarrukhdot, I think I found solid steps to reproduce: you have to scroll the list before selecting a currency
https://user-images.githubusercontent.com/9059945/214578063-9400c312-a0f1-4942-a153-219980ad5d59.mov

@syedsaroshfarrukhdot, I think I found solid steps to reproduce: you have to scroll the list before selecting a currency
Screen.Recording.2023-01-25.at.15.38.27.mov

So According to my RCA this canNavigate function can add a delay when waiting for the promise to resolve. The function returns a promise that will be fulfilled with a boolean value indicating whether the navigation can proceed.
The InteractionManager.runAfterInteractions method is used to schedule the callback function to be executed after all interactions have completed. This means that if there are other interactions that have not yet completed, such as user input or animation frames, then the callback function will not be executed until those interactions have completed. This can add a delay in the time it takes for the promise to be resolved. So when we are scrolling the list it waits form animation frames to complete which is leading to a delay.
@eVoloshchak can you use the below canNavigate to check if that resolves the issue delay issue after scrolling.
  function canNavigate(methodName, params = {}) {
      if (isNavigating) {
          return new Promise((resolve) => {
              Log.hmmm(`[Navigation] ${methodName} failed because navigation is progress`, params);
              resolve(false);
          });
      }
      return new Promise((resolve) => {
              if (navigationRef.isReady() && !isNavigating) {
                  resolve(true);
              } else {
                  Log.hmmm(`[Navigation] ${methodName} failed because navigation ref was not yet ready`, params);
                  resolve(false);
              }
      });
  }

@syedsaroshfarrukhdot, I think I found solid steps to reproduce: you have to scroll the list before selecting a currency
Screen.Recording.2023-01-25.at.15.38.27.mov

So According to my RCA canNavigate function can add a delay when waiting for the promise to resolve. The function returns a promise that will be fulfilled with a boolean value indicating whether the navigation can proceed.
The InteractionManager.runAfterInteractions method is used to schedule the callback function to be executed after all interactions have completed. This means that if there are other interactions that have not yet completed, such as user input or animation frames, then the callback function will not be executed until those interactions have completed. This can add a delay in the time it takes for the promise to be resolved. So when we are scrolling the list it waits for scrolling animation frames to complete which is leading to a delay.
@eVoloshchak can you use the below canNavigate to check if that resolves the issue delay issue after scrolling.
  function canNavigate(methodName, params = {}) {
      if (isNavigating) {
          return new Promise((resolve) => {
              Log.hmmm(`[Navigation] ${methodName} failed because navigation is progress`, params);
              resolve(false);
          });
      }
      return new Promise((resolve) => {
              if (navigationRef.isReady() && !isNavigating) {
                  resolve(true);
              } else {
                  Log.hmmm(`[Navigation] ${methodName} failed because navigation ref was not yet ready`, params);
                  resolve(false);
              }
      });
  }

After removing InteractionManager. InteractionManager.runAfterInteractions from canNavigate.
https://user-images.githubusercontent.com/81307212/214618674-3e4ee484-0cda-4a5a-8a14-a2f344b2fac7.mov
https://user-images.githubusercontent.com/81307212/214624046-ad7d5b92-1a66-4cd2-9a44-2be270d66a9e.mov

Nice, it does resolve the issue.
We don't need InteractionManager as long as both transitionStart/transitionEnd events are fired accordingly, is that correct?

This is an edge case, but on web/desktop you can still double-click, and while it doesn't navigate you to the wrong screen, it still has a bug when double-clicking the currency will result in a misplaced tooltip and value highlighted. The mouse has to be in the center of the modal for issue to happen
https://user-images.githubusercontent.com/9059945/214641405-c15e9d55-19e5-40dd-b6da-456e87599928.mov
This bug was present before this PR, but since we're essentially getting rid of the ability to double-click while navigating, it seems weird to me that we still can

Nice, it does resolve the issue.
We don't need InteractionManager as long as both transitionStart/transitionEnd events are fired accordingly, is that correct?

Yes

This is an edge case, but on web/desktop you can still double-click, and while it doesn't navigate you to the wrong screen, it still has a bug when double-clicking the currency will result in a misplaced tooltip and value highlighted. The mouse has to be in the center of the modal for issue to happen
Screen.Recording.2023-01-25.at.19.44.01.mov
This bug was present before this PR, but since we're essentially getting rid of the ability to double-click while navigating, it seems weird to me that we still can

For this edge-case for Web/Desktop.
It sounds a race condition in the code when the onPress function of the OptionRow component is called. When this function is triggered, it appears to be disabling the option selection and navigating back to the previous screen. However, it seems that a second click is being registered on the IOUCurrencySelection screen, causing the value to be highlighted and the tooltip to be misplaced. It think that this issue is not related PR and existed before and should be addressed separately.
Thoughts ? @eVoloshchak @roryabraham

We are not getting rid of double-click while navigating we are just not queuing navigation when there is already navigation is in progress.

But we're disabling TouchableOpacity after the first click.
I'm leaning towards addressing this separately since this was present before this PR, @roryabraham, what are your thoughts on this?

I'm leaning towards addressing this separately since this was present before this PR

Yes I'm fine with this

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Everything else looks good, I'm finishing up the last checklist items.
Could you please merge main into your branch? I'm seeing a visual bug on your branch so tested with your changes applied to main

Everything else looks good, I'm finishing up the last checklist items.
Could you please merge main into your branch? I'm seeing a visual bug on your branch so tested with your changes applied to main

Just merged main in  my branch.

@roryabraham, a gentle bump on the above

I have merged main and resolved conflicts in Report.js.
@roryabraham a gentle bump to get it reviewed and merged.

Sorry for the delay on my part @syedsaroshfarrukhdot, unfortunately it looks like conflicts need to be resolved again.

Sorry for the delay on my part @syedsaroshfarrukhdot, unfortunately it looks like conflicts need to be resolved again.

@roryabraham Done, Conflicts Resolved In OptionRow.js

There is something weird happening on web, but it's not related to this PR
https://user-images.githubusercontent.com/9059945/215906036-0bf9454e-71cf-4db2-8c42-3b053b0b0681.mov
Retested all of the platforms, works well

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.2.64-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

This pull request caused a regression: https://github.com/Expensify/App/issues/14787
In hindsight, the fix should have been something we caught in code review: https://github.com/Expensify/App/pull/14791
Lesson for the future is that when migrating React.memo to shouldComponentUpdate:

The params are different
The boolean logic needs to be inverted (returning true in React.memo means don't re-render, but returning true in shouldComponentUpdate means do re-render)

This kind of thing is making me wish we could use hooks, because this change would've been much easier to make and review using hooks rather than converting to a class component.

🚀 Deployed to production by https://github.com/thienlnam in version: 1.2.64-7 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/thienlnam in version: 1.2.64-7 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/thienlnam in version: 1.2.64-7 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@parasharrajat Additional context can be found here and here. Hopefully that answers your questions.

This PR caused a regression here https://github.com/Expensify/App/issues/15963 due to missing some cases that should have been handled on shouldComponentUpdate.


Expose db memory address and path to libduckdb_java.so V2

This PR replaces #87!
Same idea, but:

using Java long instead of String to hold the memory address
based on top of main HEAD

I read that DuckDB uses pointer swizzling, which should break before there is problem with the uintptr_t -> jlong cast. This means it should be OK to use it on all supported platforms.

I ran make format and committed some unrelated files and lines with https://github.com/duckdb/duckdb-java/pull/115/commits/dc0833aeb3ad6a211e58b7d38aefbc4968b8eb14 ... seems like without much success.


How to solve "Single-Machine apply Contracts" problem?

hello, I am a dapp developer, and I saw EOS use a single thread to apply all contracts right now, but this cannot afford a lot of dapp above even though multi-thread in single machine, so how eos to solve this problem? thanks.

The problem of multiple distinct execution nodes is tricky for reasons of
trust and data contention.
We have 2 planned solutions, one of which is very close to reality and we
intend to prove that in the next testnet release.
The most naive solution is side chains which we have first class support
for.  DPoS sidesteps a lot of concerns about side chains and malicious
miners from the PoW world, all we need is the ability to prove finality and
retirement of actions for a remote blockchain to be able to accept our
transactions as native message.  This is done through
inter-blockchain-communication described here:
https://steemit.com/eos/@dan/inter-blockchain-communication-via-merkle-proofs-with-eos-io
A more efficient solution is achievable with some other source of trust.
We call this regions and it's a feature we have left doors open for but, is
not planned for the initial release.  In this solution, you use the same
producers and the same blockchain but you have completely isolated regions
of data and contracts.  Each of these regions can run on a new node giving
you horizontal scaling with in a producers cluster. This only works if
the producer can trust their whole cluster but is otherwise not much
different than the single node producer.  This is more efficient because
instead of trustlessly proving communication between regions, an producer
can implicitly trust their cluster of nodes (at least as much as they trust
their main node)
There are more nuances of course but these are the high level views of the
2 solutions at hand.
On Mar 1, 2018 5:08 AM, "Pengcheng Lv"<EMAIL_ADDRESS>wrote:

hello, I am a dapp developer, and I saw EOS use a single thread to apply
all contracts right now, but this cannot afford a lot of dapp above even
though multi-thread in single machine, so how eos to solve this problem?
thanks.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/EOSIO/eos/issues/1507, or mute the thread
https://github.com/notifications/unsubscribe-auth/ACYR4o90SMmMcdLoygUbdOHxyev-9CvTks5tZ8i5gaJpZM4SYDcT
.


knife-block not working

I get this following error when I try to run knife-block, I'm using master version of knife-block, here's the trace:
.chef|⇒ knife block list -VV
/Users/allaire/.rbenv/versions/2.0.0-p247/lib/ruby/gems/2.0.0/bundler/gems/knife-block-dc563985b564/lib/chef/knife/block.rb:18:in `get_config_file': undefined method `locate_config_file' for Chef::Knife:Class (NoMethodError)
	from /Users/allaire/.rbenv/versions/2.0.0-p247/lib/ruby/gems/2.0.0/bundler/gems/knife-block-dc563985b564/lib/chef/knife/block.rb:37:in `chef_config_base'
	from /Users/allaire/.rbenv/versions/2.0.0-p247/lib/ruby/gems/2.0.0/bundler/gems/knife-block-dc563985b564/lib/chef/knife/block.rb:74:in `check_block_setup'
	from /Users/allaire/.rbenv/versions/2.0.0-p247/lib/ruby/gems/2.0.0/bundler/gems/knife-block-dc563985b564/lib/chef/knife/block.rb:141:in `run'
	from /Users/allaire/.rbenv/versions/2.0.0-p247/lib/ruby/gems/2.0.0/gems/chef-11.6.2/lib/chef/knife.rb:466:in `run_with_pretty_exceptions'
	from /Users/allaire/.rbenv/versions/2.0.0-p247/lib/ruby/gems/2.0.0/gems/chef-11.6.2/lib/chef/knife.rb:173:in `run'
	from /Users/allaire/.rbenv/versions/2.0.0-p247/lib/ruby/gems/2.0.0/gems/chef-11.6.2/lib/chef/application/knife.rb:123:in `run'
	from /Users/allaire/.rbenv/versions/2.0.0-p247/lib/ruby/gems/2.0.0/gems/chef-11.6.2/bin/knife:25:in `<top (required)>'
	from /Users/allaire/.rbenv/versions/2.0.0-p247/bin/knife:23:in `load'
	from /Users/allaire/.rbenv/versions/2.0.0-p247/bin/knife:23:in `<main>'

I got this issue as well, after removing the gems directory (cleaning them all) and installing the gem again.
I got the same thing, "Exception: NoMethodError: undefined method `locate_config_file' for Chef::Knife:Class"
Ill fork the fix from the PR of woohgit :)
Ill try to fork the fix from the PR of

poop!
Still no luck...
[@ ]$ gem list | grep block
knife-block (0.0.9)
[@* ****]$ knife block list
ERROR: knife encountered an unexpected error
This may be a bug in the 'block list' knife command or plugin
Please collect the output of this command with the -VV option before filing a bug report.
Exception: NameError: undefined local variable or method `locate_config_file' for #Chef::Knife:0x00000003ae7010

This is because it has been already changed in the never versions, so you should locate the problem and fix it again :)

Tracking in https://github.com/knife-block/knife-block/issues/25


Fix repeated headers to be bounded properly

Previously, the field lookup occurred from the beginning of the line
so would repeated find the same line location if the same string or a substring
of a header was searched more than once.
Instead track the current end index of the previous field to base the search
state location on.

@neekey once you make a release, I'll update neekey/table-parser#12 to reference it


Add (opinionated) nix flake build

I wanted to add a nix flake setup which is my opinionated setup, but resembles a lot of other languages' structure. It makes compilation and dependency management very plug and play although more work is needed.

I have no clue what nix is good for :) What is this giving me? I feel that this project is in such an early and experimental stage that adding another way how to build it apart from just using lake build is the last thing we should worry about right now. On the other hand, I'm happy to be convinced of the opposite.

@lecopivo Well, if you are using a unix system nix provides a really nice and deterministic plug and play development environment. I use it for all my projects because it means I can build any project with zero configurations and the same result every time which is super nice when sharing code or dealing with many projects. So I recommend nix.

Sounds good, I should give it a try at some point. I'm happy to merge your changes, not sure though if I will be able to maintain them as I do not know nix and don't know when I will find the time to lean it.

Ahh I merged it, but then I have tried lake build and it does not work anymore. So a revert it. How do I reopen this pull request? Or just make a new one. Can you please make sure that lake build still workds?

Just a sec

@lecopivo  I think it should be enough to set srcDir := "src" to make it work. Turns out I had to do some fixes to make lake run on NixOS again so haven't tested yet.
https://github.com/yatima-inc/lake/


Create a To-Do List Application

Description
This project is a simple and interactive To-Do List application that helps users manage and organize their daily tasks efficiently. Users can add, edit, and delete tasks, as well as mark them as completed. The interface is designed to be user-friendly, ensuring easy navigation and task management.
Solution
I would like to implement this application using React.js and Material UI as they will provide a user-friendly UI/UX to the user and also help in easy navigation and task management
Screenshot of prototype

Tasks
Tasks to be done in this application are as followed

[ ] Adding a task
[ ] Editing a task
[ ] Deleting a task
[ ] Marking task as completed

Assign me this issue please


GNUsocial group name autocomplete

AndStatus already supports autocomplete for @mentions, and it does it really well.
What I'd like to see is autocomplete for GNUsocial !groups also.
I'm not sure there's any more detail I can give for this, but feel free to correct me on that!

There is even no notion of a Group in AndStatus yet. See similar request: https://github.com/andstatus/andstatus/issues/248
We will need to start from addition to the AndStatus data model a Group, as an Actor Type (in terms of https://www.w3.org/TR/activitystreams-vocabulary/#dfn-group ). Unfortunately, addressing a group in a note's text in GNU Social is not like user mentioning...

Unfortunately, addressing a group in a note's text in GNU Social is not like user mentioning...

@yvolk, I don't quite understand what you mean here. I'm worried that it might just be an artifact of misunderstanding what "groups" in GNU social even are? I've added a more detailed response to that at #248....


Add empty activationEvents to manifest

This fixes the vsce error encountered in https://github.com/argumentcomputer/lurk-vscode/issues/8 when following the instructions in the README. See my previous comment for rationale: https://github.com/argumentcomputer/lurk-vscode/issues/8#issuecomment-2458388411

Tagging @arthurpaulino for a review.


IOSimPOR diffusion tests

Currently, we don't yet have diffusion tests, but it would be good to have test which cover both outbound governor, e.g.

[x] "no fail" property test
[x] "no livelock" property test

The following inbound governor tests:

[x] prop_inbound_governor_valid_transition_order
[x] prop_inbound_governor_valid_transition_order

The following connection manager tests:

[x] prop_inbound_governor_valid_transition_order
[x] prop_inbound_governor_valid_transition_order

Other tests which would be interesting to have (just a dip of the iceberg):

[x] prop_timeouts_enforced
[x] prop_never_above_hardlimit

Done in: https://github.com/IntersectMBO/ouroboros-network/pull/4872


Unable to Update Foundry to Version 0.9.0 on MacOS - Error Occurs and Ongoing Campaign at Risk

I want to update and can't; I have an ongoing campaign and I'm afraid to uninstall and reinstall and lose the game world; Foundry recognizes that version 0.9.0 exists and that the system is installed, but when I try to update, this error occurs.
OS: MacOS

Major apologies! This should work in place now, if you retry the update. Let me know if it doesn't, I can bump the version by 1 fairly quickly.
On the plus side, if you uninstall a system, the worlds that rely on it don't get deleted, they just become unusable (until you reinstall the system).


Error when open large files with neovim in st

[taha@Latitude ~]$ st
erresc: unknown csi ESC[22;0;0t
erresc: unknown str ESC]11
X Error of failed request:  BadLength (poly request too large
 or internal Xlib length error)
  Major opcode of failed request:  139 (RENDER)
  Minor opcode of failed request:  20 (RenderAddGlyphs)
  Serial number of failed request:  4206
  Current serial number in output stream:  4668

i have this error when i open i3blocks config with neovim ( with voidrice dotfiles )
and crash st after this error

This is a known xlib error in st deriving from lack of unicode characters.
https://github.com/LukeSmithxyz/voidrice/issues/284


Feature/runner improvement

Description of change
Removing items from a runner when its in the middle of running should no longer break, or have weird side effects
An alternative to PR #5970!
Pre-Merge Checklist

[x] Documentation is changed or added
[x] Lint process passed (npm run lint)
[x] Tests passed (npm run test)

Once this builds will test the provided example...

Unit tests?

you need to do if (index !== -1) anyway.

@bigtimebuddy , unit tests are an excellent idea.. Will add them today.
@ivanpopelyshev , adding should have no effect as it get pushed onto the top and does not alter the structure of the array? Not a fan of coping each time, what to keep this as fast as possible.

Its not each time, its when it was modified inside a cycle if there is more than one element.

Codecov Report

Merging #5972 into dev will decrease coverage by 0.06%.
The diff coverage is 43.47%.

@@            Coverage Diff            @@
##             dev    #5972      +/-   ##
=========================================
- Coverage   70.4%   70.34%   -0.07%
=========================================
  Files        208      208
  Lines      10495    10516      +21
=========================================
+ Hits        7389     7397       +8
- Misses      3106     3119      +13

Impacted Files
Coverage Δ

packages/runner/src/Runner.js
76.78% <43.47%> (-23.22%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f7d1ad...dc9e7e6. Read the comment docs.

unit test added 👍

Closing in favor of #5975, confirmed with @GoodBoyDigital


rhash falls back to printing non-relative paths in output

why does the full path get printed intermittently ?
Is it because of special chars?
Why would it not output relative path?
>rhash --version
RHash v1.4.0

Command line is:
rhash --sha256 -r -o D:\logs\rhash_1.txt .\

c75d284885a232000001e9a567a1cd715188ec743687a67e6a303c3be72a7e9c  kleee\prio1\download\root\migrat1_2007_10_ende\$RECYCLE.BIN\S-1-5-21-123456789-4172760481-734191380-1001\$R0S6Y7T\472\4723\4723-Kundendaten\4700_Niet_Maxooo-10000001_V5P_00_1.sldprt
183ad36be29a890123422d20f58de0804ce49d5652f22c4f098fe5b978969b40  C:\backups\kleee\prio1\download\root\migrat1_2007_10_ende\$RECYCLE.BIN\S-1-5-21-123456789-4172760481-734191380-1001\$R0S6Y7T\472\4723\4723-Kundendaten\4700_Schraube M10 (aehnlich ISO 8677)-10000001_V5P_00_1.sldprt
367ab89a4902872e54664aff9d123456000006f6c68964c31846e290f11766ee  kleee\prio1\download\root\migrat1_2007_10_ende\$RECYCLE.BIN\S-1-5-21-123456789-4172760481-734191380-1001\$R0S6Y7T\472\4723\4723-Kundendaten\4700_Schweissmutter_M8-10000000_V0P_00_1.sldprt

Thank you for reporting this bug!
The problem was caused by incorrect handling of long paths on Windows, which require UNC prefix.
The bug is fixed in the master branch by commits 55301b8ddcd147b02bd1efd3f7bd2f5ce9843c3f and 824a520cef1efda01494e76e726aae9fa71fab6b.

The fix is included into RHash v1.4.1.

The fix is included into RHash v1.4.1.


[release-2.40.0] Fix RunInference example due to dill errror

Cherry picking https://github.com/apache/beam/pull/22001 to fix a dill-related issue in a RunInference example where there was a pickle error of a Python class because it was in the wrong scope.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Can one of the admins verify this patch?

Can one of the admins verify this patch?


accept a custom console parameter in runLocalCode

Would be nice to be able to mock the console, specially when running tests, to have a cleaner output. Could be used to make assertions also

Coverage remained the same at 97.512% when pulling e5aeb8390aa21bdfe4bad745a54be013df16018a on rafaeleyng:runLocalCode-console-parameter into 353b6122bb093e0ff80ad3146e4384b02debc17e on backstage:master.


Option to choose 'otherEntityField' and 'pagination'

Since last version where it only changes the models that we have changed in the XML everything is working very nice. But constantly I have to go to the json file to change the 'otherEntityField' name from id to something else and to add pagination. Once I do that, jhipster-uml detects that this json has been changed and any other change in the other entities make this one to be updated too. Can we have the option to set otherEntityField and pagination. Apparently it is the only thing missing now.

For the pagination we can do something similar as we did for the dto (with the option '-dto'). For the 'otherEntityField' I think we can do it without an option.

Yes, probably for the ‘otherEntityField’ something like constraints. And sure, I think pagination could be an option like –dto, choosing between all and ones that want to have pagination.
Badin, Marcelino G.
INDRA
Digital Systems Engineer
+55 11 3042 3150
+55 11 99279 3279 (mobile)
<EMAIL_ADDRESS>From: CarlKlagba
Reply-To: jhipster/jhipster-uml
Date: Monday, July 20, 2015 at 9:05 AM
To: jhipster/jhipster-uml
Cc: Marcelino Badin
Subject: Re: [jhipster-uml] Option to choose 'otherEntityField' and 'pagination' (#34)
For the pagination we can do something similar as we did for the dto (with the option '-dto'). For the 'otherEntityField' I think we can do it without an option.
—
Reply to this email directly or view it on GitHubhttps://github.com/jhipster/jhipster-uml/issues/34#issuecomment-122864542.

@marcelinobadin  I want to enable user to add  'otherEntityField' like this:

UML

JDL

relationship ManyToMany{
Owner{notOwner(<otherEntityField>)} to NotOwner{owner}
}
With <otherEntityField> the name you want for 'otherEntityField' .
Is it something intuitive for you? Do you have a better syntax in mind?
My guess is yours.

I think you solution is very cool and yes, it is intuitive. Thank you.

Ok thx ! Just have to do the impl.

The wiki wont be update for a while so this is the doc i made for the change.
Declare the field you want to use to display a relationship in AngularJS
To do that you must add the field name between (``) after the injected field name.
In a One-to-Many relationship you can add it in the 'Many' side of the relationship:

UML

JDL
relationship OneToMany{
  One{many(`<otherEntityField>`)} to Many{one}
}

In a Many-to-Many relationship you can add it in the owner side of the entity:

UML

JDL
relationship ManyToMany{
  Owner{notOwner(`<otherEntityField>`)} to NotOwner{owner}
}

Pagination
You can choose the pagination for your entities using -paginate.
jhipster-uml <your_file.xmi> [-db (sql | mongodb | cassandra)] [-paginate]

Cool. @CarlKlagba, I need a little help with Modelio.
These are my entities. One Map can have Many Positions.

Then, once I create the association I would like to know in which field I have to insert the map(name) according to association options in Modelio as in the picture below (Association name for the field under the yellow tip)

Thank you.

Simply put it in 'Role', like you would if you wanted to change the 'relationshipName'

Great! Thank you. It work very smoothly. I will take this opportunity to thank you for your work. This tool really saves me too many work hours!

We are very happy you like it, and that it saved you a lot of time!


Kmeans||

This is still WIP, for early review.
TODOs:

Make the algorithm work as expected.
Add proper tests.
Make the algorithm work with k-means.
Factor out operations.
Fix and rebase build-system.
Merge tSVD matrix with KmMatrix.

Above and tuning the algorithm described in #642
close #642

All tests for KmMatrix should pass.

I will at least get CMake part of the build system get merge. I will work on it as soon as I can see the jenkin report.

We can switch to doing some work on xgboost after you have dealt with the review issues until the continuous integration problem gets resolved.

@trivialfis @RAMitchell just had a quick glance, changes look really good! Will do a proper review over the weekend.
@RAMitchell by CI issues you mean @trivialfis not being able to see the logs? Would a log emailed when the build fails be sufficient? I remember adding that a long time ago but maybe someone changed it and need to add it back in.

@mdymczyk Thanks for spending extra time on this. I haven't receive any mail from the CI yet.


Broken link

https://docs.microsoft.com/en-us/dynamics365/field-service/booking-template#see-also link to 'Add custom resource attributes to the schedule board' is broken

@alex-mclachlan-silverbear - thank you! This has been fixed and will be live end of day.


[$500] Distance -  Map initially starts from "San Francisco" even if waypoints are available

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v1.3.81-6
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @krishna2323
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697039744048349
Action Performed:

Request money > Select distance tab
Select "Dhaka, Bangladesh" as start point
Select "Bangalore, Karnataka, India" as finish point
Press next & select any workspace
Observe map loads from "Dhaka"
Select "Distance" tab
Observe map initially loads from "San Francisco"

Expected Result:
The available waypoint should be the initial location if available.
Actual Result:
The initial location is always "San Francisco"
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/93399543/9b635414-be29-41dd-8610-d7aeef2490f8

Android: mWeb Chrome

https://github.com/Expensify/App/assets/93399543/a17fd81e-ef25-4bc6-a793-45c2c9a75ea8

iOS: Native

https://github.com/Expensify/App/assets/93399543/3c983431-da25-472c-a01a-984ba7878cea

iOS: mWeb Safari

https://github.com/Expensify/App/assets/93399543/686a84a8-4f3f-4d3c-b945-cc2379c20b58

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/93399543/63404b84-77bd-44f6-aaee-b3dabace5269

MacOS: Desktop

https://github.com/Expensify/App/assets/93399543/4f965bf5-a010-4126-a2a0-43cbddadec92

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01d6e45942a56ff196
Upwork Job ID:<PHONE_NUMBER>286824448
Last Price Increase: 2023-10-12

Proposal
Please re-state the problem that we are trying to solve in this issue.
Map initially starts from "San Francisco" even if waypoints are available
What is the root cause of that problem?
The initial location is always set to location: CONST.MAPBOX.DEFAULT_COORDINATE in DistanceRequestFooter.
What changes do you think we should make in order to solve the problem?
We should use lodashGet to get the location of waypoints if they are in state.
location: lodashGet(waypointMarkers, [0, 'coordinate'], CONST.MAPBOX.DEFAULT_COORDINATE)
Result

@Krishna2323 Thanks for the proposal. Your RCA is correct. The solution looks good to me 👍. Please comment and tag me again so you can be assigned.

https://github.com/Expensify/App/issues/29471#issuecomment-1760280379
🎀 👀 🎀 C+ reviewed
Link to proposal

@jasperhuangg https://github.com/Expensify/App/issues/29471#issuecomment-1760333537

The PR that introduced the bug has been identified: https://github.com/Expensify/App/pull/25161
The offending PR has been commented on: https://github.com/Expensify/App/pull/25161#discussion_r1366221788
A discussion in #expensify-bugs has been started: I don't think this is needed for this case
Determine if we should create a regression test for this bug: Yes

Regression Test Proposal

Request money > Select distance tab
Select "Dhaka, Bangladesh" as start point
Select "Bangalore, Karnataka, India" as finish point
Press next & select any workspace
Verify map loads starting from "Dhaka, Bangladesh"
Select "Distance" tab
Verify map loads starting from "Dhaka, Bangladesh"

Issue reporter: @Krishna2323 paid $50 via Upwork
Contributor: @Krishna2323 paid $750 via Upwork, inc. urgency bonus
Contributor+: @s77rt via Upwork, inc. urgency bonus
Regression Test - https://github.com/Expensify/Expensify/issues/330239
Thanks y'all!


Module support for Elasticsearch Enterprise

Will this module or a new module provide support for Elasticsearch Cloud or Elasticsearch Enterprise?
https://www.elastic.co/cloud/enterprise

@cdenneen I'd suggest bringing up topics of discussion for features/deployment for ECE on the Discourse forum for the product since it's a different animal than this Puppet module.
In addition to being able to hash out exactly what the user needs may be, various technical leads and PMs are there as well so everyone has better visibility into what's going on. Feel free to tag me directly on any Puppet discussions there (I'm @tylerjl there, too).


Bring the CI workflow in line with the fluent-kit setup

Sorry I missed this one! Did this on a separate branch already.


Fix playground build for Beam 2.55.0 change

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Playground PreCommit failed with Task :playground:backend:runLint FAILED
2024-03-25T18:08:43.0331811Z > Task :playground:backend:installLinter
2024-03-25T18:08:43.0333109Z golangci/golangci-lint info checking GitHub for tag 'v1.51.2'
2024-03-25T18:08:43.0334362Z golangci/golangci-lint info found version: 1.51.2 for v1.51.2/linux/amd64
2024-03-25T18:08:43.0335660Z golangci/golangci-lint info installed /home/runner/go/bin/golangci-lint
2024-03-25T18:08:54.6329834Z
2024-03-25T18:08:54.6330597Z > Task :playground:backend:runLint
2024-03-25T18:08:54.6331919Z ../../../../../../../opt/hostedtoolcache/go/1.21.8/x64/src/net/http/internal/chunked.go:79:14: undefined: max (typecheck)
2024-03-25T18:08:54.6333164Z 	cr.excess = max(cr.excess, 0)
2024-03-25T18:08:54.6333679Z 	            ^
2024-03-25T18:08:54.6334675Z ../../../../../go/pkg/mod/golang.org/x/net@v0.9.0/http2/server.go:2522:9: trailer declared and not used (typecheck)
2024-03-25T18:08:54.6335854Z 	for _, trailer := range rws.trailers {
2024-03-25T18:08:54.6336423Z 	       ^
2024-03-25T18:08:54.6337457Z ../../../../../go/pkg/mod/cloud.google.com/go/longrunning@v0.4.1/longrunning.go:27:2: "fmt" imported and not used (typecheck)
2024-03-25T18:08:54.6338627Z 	"fmt"
2024-03-25T18:08:54.6338964Z 	^
2024-03-25T18:08:54.6340175Z ../../../../../go/pkg/mod/cloud.google.com/go/longrunning@v0.4.1/longrunning.go:36:2: "google.golang.org/grpc/status" imported and not used (typecheck)
2024-03-25T18:08:54.6341636Z 	"google.golang.org/grpc/status"
2024-03-25T18:08:54.6342149Z 	^
2024-03-25T18:08:54.6343800Z ../../../../../go/pkg/mod/google.golang.org/grpc@v1.56.3/balancer/grpclb/grpclb_remote_balancer.go:306:12: s.Context undefined (type *balanceLoadClientStream has no field or method Context) (typecheck)
2024-03-25T18:08:54.6345860Z 		case <-s.Context().Done():
2024-03-25T18:08:54.6346342Z 		         ^
2024-03-25T18:08:54.6347723Z ../../../../../go/pkg/mod/google.golang.org/grpc@v1.56.3/credentials/oauth/oauth.go:42:19: ts.Token undefined (type TokenSource has no field or method Token) (typecheck)
2024-03-25T18:08:54.6349272Z 	token, err := ts.Token()

these go codes were all from depenencies. Should they be excluded from lint ?

PreCommit passed after disable goLint, which confirms the change does not introduce regression to PreCommit Playground, revert the last change and will mark as ready for review

assign set of reviewers

R: @damccorm


Transfers are identified by their secret hash

Description
I found that transfer are identified by their secret hash which is used to lock them. For me that raises the question if that is really save to do, or if there could be several outgoing transfers with the same secret hash that could cause problems. I did not find a problem with it, but it looks fishy to me.
Copied from the team repo
Acceptance criteria

Tasks

[ ]

Our thinking is that this shouldn't be an issue. If there's a conflict, it's most likely a retry, and we're stricter in not sending or not receiving a transfer with a secrethash collision, so at worst case, it'd prevent us from receiving said transfers. A little bit more thinking can be put here though. @hackaugusto do you see any drawback of the current way we do things, of uniquely identifying transfers by direction and secrethash?

I would fix this, the idea is that a payment may be split into multiple transfers, which would use the same secrethash  https://github.com/raiden-network/raiden/issues/3520 , ignoring multiple transfers with the same secrethash can lead to synchronization problems in the future.

@hackaugusto What then would be the ideal unique identifier/primary set of values for transfers, in your view?

I don't think there is any unique identifier for transfers.
I would group transfer as follows:

for the initiator target, payment_id
for the target initiator, payment_id
for a mediator just having a list of transfers instead of one transfer per secret hash is enough.

@hackaugusto I understand the grouping part for a payment, but for our logic, we really need to know something that represents uniquely a transfer, to have it as key in the state. Would the secrethash be a unique identifier per channel for a single transfer?

Would the secrethash be a unique identifier per channel for a single transfer?

I wouldn't assume this, there is nothing that guarantees that would be the case.

Yes, sure, theré s nothing that guarantees, besides protocol rules and implementation, and we write those. If we say (and implement) that another transfer with same secrethash on the same direction on a given channel should be unique, and a message should be rejected if it conflicts (or be replied with a Processed to confirm as a retry, or whatever), whoever doesn't follow will get theirselves out-of-sync.
AFAIK, this is already the case today with both implementation, since they always generate unique secrethashes which are used for single routes or fail. The LC's current implementation happen to also require it across channels, but since the python implementation unintendedly comply, this can be assumed, right?
This may not (yet) be written, but we could do it eventually, unless you see something explicit which would cripple some other part of the protocol by making this rule definitive.

Closing -> see https://github.com/raiden-network/light-client/issues/2067#issuecomment-674300319


[feature] research into containerd-shims when using Docker Desktop on WSL2

Using a WSL2 debug shell to log into the "root" CBL Mariner instance (wsl --debug-shell) gives access to the initial PID namespace. This is required in order to see all processes inside the WSL2 VM.
For instance, lxkns correctly detects the services.linuxkit/docker containerd container, not showing its containerd-shim-runc-v2 process -- because there's a container PID known from containerd.
Comparing the "unmatched" containerd shims based on their PIDs (in the initial PID namespace) to a process tree analysis then shows that these are related Docker containers.  The latter works as desired, based on the information queried from the Docker daemon.
The (parent process) shims now do not belong to the Docker realm, but "somehow" end up as separate "leader" processes, in lxkns parlance. The reason is that in the process hierarchy clustered by network namespaces the shims are in a different network namespace than their (container) child processes. At the same time, they're not the ealdorman process, so lxkns will dutifully identify them as additional leaders inside their shared network namespace.

[ ] new UI setting "show standalone containerd shims", defaulting to false/off/hide.
[ ] skip containees of type "running standalone process" with name (not: command line!) of containerd-shim if UI setting is to hide them.

A "fuller" ps --width 500 shows that the shims get passed the argument(s) -namespace moby.


Superset Show Detailed Error Message Instead of Custom Error Message

Hi,
I'm using superset Version: 1.2.0. When I access user listing page (/users/list/) and left some field blanks, it show a detailed error message. We are using superset version 1.2.0
This is the step to reproduce the issue :

Access user listing page (/users/list)
Click Filter List, choose :

Created By (Leave it Blank)

Changed By (Leave it Blank)

First Name (Input Garbage)

Last Name (Input Garbage)

Click Refresh

A detailed error message will be shown.

This also happen when accessing this path /superset/schemas_access_for_csv_upload?db_id=2
Is there any way to show a custom/common error page instead the detailed error page ? We have set the env to prod mode but the error message is still shown.

@Pajri thank you for reporting this issue, the first errors on users/list seems like a FAB bug with PG, I'll address that.
Still investigating the detailed error message and if it's possible to optionally make it less detailed .

Hi @Pajri the fix is ready on FAB, for superset you can disable this output by not running your app in debug more, see here: https://github.com/apache/superset/blob/master/superset/views/base.py#L414

Sounds like this thread is resolved, but it's also stale anyway. Holler if this needs to be revisited for any reason.


An inbuilt video player like Samsung or coc browser can  really help kiwi browser. Can it be implemented

or let us use external player, like vlc or mx player.


[need ticket] Terra UI tests: additional logging for troubleshooting test failures

Attempt to capture all errors and sources of errors; and write summary of all tests results to new tests-summary.json file. Because sometimes a UI test marked as failed but there was no failure messages in test log.
Example:
import-dockstore-workflow failed but failure messages field is blank in test log.
CircleCI
One tests-summary.json in every CirlcleCI VM:

I have one CircleCI link in PR description. Test was import-dockstore-workflow in integration-tests-alpha job.

Test failed due to 403 failed request. However, I think we should see failure stacktrace in test log but none exists for whatever reason unknown to me.


ACCUMULO-4375 Add missing byte[]-based Key constructors

@dlmarion I've deleted the old branch because rebasing was painful, I had too many conflicts for a very small patch. I've recreated the branch on top of 1.8 and created a new PR.

LGTM. @mjwall  - can we get this into the 1.8 release?

Tests are failing but on unrelated tests.

This cannot be merged as-is. The code does not work.

Wops, sorry for that. I had a look at the tests but they didn't look related. My mistake, I'll fix the PR. I'm going to --amend the commit.

Great! Feel free to ping me when you have things updated and I'll give you another review. The unit tests should always be passing reliably so feel free to use those as verification that your changes are working as expected.

@joshelser done. I don't know were my head was yesterday. I was so sure about getBytes and getLength behaviour that I simply didn't check.  Not my best "first contribution" to an OSS project :). I'll try to be more careful in future.

Haha, not worries @melrief! There are definitely no feelings of animosity for less-than-perfect contributions (don't google for mine ;)). Taking a look at your latest now.

I think aside from the minor javadoc request I had, this looks good. If you have time, feel free to throw that up; otherwise, I can just modify it on commit. LMK

@melrief, these changes also inspired me to create https://issues.apache.org/jira/browse/ACCUMULO-4376. We're getting to lots of constructors for Key. Mentioning it because I thought you may also be interested in helping out there.

@joshelser yes, I'm interested in helping with it. I do agree overloading the constructor of Key so many times can be confusing and not very maintainable or flexible.

Cool, this looks good to me, @melrief. Let me run it through some tests and will commit if it passes.

@melrief this looks good.  The behavior is consistent w/ the Text constructors, which is really nice.  Looking at the test and javadoc you added inspired me to open ACCUMULO-4377.  Adding the test for copy behavior is more general than this PR, since existing constructors do not have those test.
@melrief one additional thing thats needed is @since 1.8.0 tags.   Would you be interested in doing another PR to add those?

I opened ACCUMULO-4378 as subtask of ACCUMULO-4375 and made it blocker (just so we dont forget about it for 1.8).

@keith-turner sure, I'll do it tonight.


Click (touch) events blocked for a short time after swiping

Check that this is really a bug

[X] I confirm

Reproduction link
https://codesandbox.io/p/sandbox/swiper-react-default-forked-u7yty5?file=%2Fsrc%2FApp.jsx
Bug description
When quickly after swiping to change a slide, click events on elements not related to the swiper are not registered. This only happens when using touch input (emulated or real).
https://user-images.githubusercontent.com/37304664/217113994-b803b66c-4c4d-4a30-ac83-2e5f91843eee.mp4
NOTE: I opened the same issue (#6355) once, but after posting tried few things out in the codesanbox  like changing Swiper version to 7. When @nolimits4web reviewed my previous issue I forgot to revert those changes and my issue was closed (due to version 7 being used) without a solution or fix. I apologize for my mistake. The issue is still valid.
Expected Behavior
Click events on external elements should work as usual.
Actual Behavior
Click events on external are not triggered when clicking on them shortly after swiping the swiper.
Swiper version
9.4.0
Platform/Target and Browser Versions
Chrome 114.0.5735.110 (Windows 10)
Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
[X] Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

[ ] I'm willing to open a PR

Additional information: i used monitorEvents() to check what events are passed to the external element. Normally it looks like this:

but when i click (touch) quickly after swiping the swiper some are missing:

All of the events after touchEnd are not there.

Additional information: based on my debugging attempts, my touch gets captured by #document.touchstart (that's what Chrome Devtools says after breaking on touch event) and runs function dummyEventListener() {}. I guess(!) that's what stops propagation.

This problem doesn't occur with cssMode: true, but cssMode doesn't support many important features.

@kubagp1 did you find any workaround for this?

@kubagp1 did you find any workaround for this?

Nope. I'm using a different carousel library until this is fixed.

Not a Swiper bug, it is browser's bug or feature related to handling touch-action CSS prop. It can be replicated on any simple element such as
Test

Then why it's only present in Swiper? Any other library i tested didn't have this behaviour.


Generate binaries that run on V8

This change includes two major parts (and also includes #37, but that can be merged separately):

Changes to build.rs to fetch a build of the Wasm toolchain from https://wasm-stat.us on linux. This also caches the build number and only downloads a new version if its changed.
Binary output and exporting Rust functions.

mir2wasm now supports the -o option, which gives the name of a .wasm file to write the module to. You can then run this inside of the V8 shell, d8. It probably works with other VMs, but I haven't tested that.
This includes fact.rs and fact.js to demonstrate how this works. You can run this with the following steps, from the repo root:
cargo run -- rust-examples/fact.rs -o fact.wasm --crate-type=lib
./wasm-install/bin/d8 --expose_wasm fact.js

If all goes well, you should see the number 120 printed out to the console.
This doesn't yet make any attempt to run the test suite under V8, but we have a lot of the ground work in place to do that now.

OMG :sparkler:


fix warning for unused result

Fixed a compiler warning due to an unused result in SnapshotHelper.swift

I signed it!


hammer.js interfering with jQueryUI draggable. How to get them both working?

I've successfully implemented jQueryUI draggable, but as soon as I add hammer.js code, the draggable code no longer works.
It is not as soon as I include hammer.js, but as soon as I use the script.
Why is this? How can I get them both to work?
Both the draggable and hammer are applied to .dataCard and #main
The draggable code works fine here ( with hammer implementation commented out ): http://goo.gl/MO5Pde
Here is an example of the draggable code:
$('#main').draggable({
    axis:'y',
    revert:true,
    start: function(event, ui){
        topValue = ui.position.top;
    },
    drag: function(event, ui){
            if(pastBreakpoint === false){
                $('#searchInput').blur();
                if(topValue > ui.position.top) return false;
	        if(ui.position.top >= 161){
	            if(pastBreakpoint === false){
		        pastBreakpoint = true;
		            if($('.loadingRefresh').length === 0) $('#main').before('

');
		            else{
			        $('.loadingRefresh').remove();
		                $('#main').before('

');
		            }
		            $('.loadingRefresh').fadeIn();
		            $('#main').mouseup();
		            setTimeout(function(){
		               location.reload();
		            }, 1000);
		         }
	          }
	        }
        }
    });

Here is the hammer code uncommented and the draggable code not working: http://goo.gl/994pxF
Here is the hammer code:
var hammertime = Hammer(document.getElementById('main'), {
    transform_always_block: true,
    transform_min_scale: 0
});

var posX = 0,
    posY = 0,
    lastPosX = 0,
    lastPosY = 0,
    bufferX = 0,
    bufferY = 0,
    scale = 1,
    last_scale = 1;

hammertime.on('touch transform transformend', function(ev) {

    if ((" " + ev.target.className + " ").indexOf(" dataCard ") < 0) return;

    else manageMultitouch(ev, ev.target); });

    function manageMultitouch(ev, element) {

	    switch (ev.type) {
		    case 'touch':
			    last_scale = scale;
                                return;
		     case 'transform':
			    scale = Math.min(last_scale * ev.gesture.scale, 10);
			    break;
	        }

	        if(scale <= 0.5) $(element).hide('clip');

	        if(scale > 1.0) $(element).addClass('focused');

	        var transform = "translate(" + 0 + "px," + 0 + "px) " + "scale(" + 1 + "," + scale + ")";
	        var style = element.style;
	        style.transform = transform;
	        style.oTransform = transform;
	        style.msTransform = transform;
	        style.mozTransform = transform;
	        style.webkitTransform = transform;
     }

Closing this due to age and inactivity this is from V1 that said i work on the jQuery UI team if this is still an issue create a small test case and ill be happy to work on this.


GE crashes when attempting to get the /$metadata

Describe the bug
When attemtpting to call the /$metadata endpoint, GE seems to assume that's an invalid URL and crashes.
To Reproduce
Attempt to call https://graph.microsoft.com/v1.0/$metadata or https://graph.microsoft.com/beta/$metadata
Expected behavior

GE to understand the $metadata endpoint.
For invalid URLs, GE to throw an invalid URL error instead of crashing.

Screenshots

Desktop (please complete the following information):

OS: Windows 11
Browser Chrome

Additional context
N/A

Hi @FaithOmbongi ,
This has been resolved in #3062 and is awaiting deployment


FileNotFoundError when running benchcab v4.0.0

Running benchcab run with benchcab v4.0.0 fails to load resources from the package data directory and throws a FileNotFoundError:
$ benchcab run
Traceback (most recent call last):
  File "/g/data/hh5/public/apps/miniconda3/envs/analysis3-24.01/bin/benchcab", line 10, in <module>
    sys.exit(main())
  File "/g/data/hh5/public/apps/miniconda3/envs/analysis3-24.01/lib/python3.10/site-packages/benchcab/main.py", line 42, in main
    parse_and_dispatch(parser)
  File "/g/data/hh5/public/apps/miniconda3/envs/analysis3-24.01/lib/python3.10/site-packages/benchcab/main.py", line 32, in parse_and_dispatch
    func(**args)
  File "/g/data/hh5/public/apps/miniconda3/envs/analysis3-24.01/lib/python3.10/site-packages/benchcab/benchcab.py", line 368, in run
    self.checkout(config_path)
  File "/g/data/hh5/public/apps/miniconda3/envs/analysis3-24.01/lib/python3.10/site-packages/benchcab/benchcab.py", line 221, in checkout
    config = self._get_config(config_path)
  File "/g/data/hh5/public/apps/miniconda3/envs/analysis3-24.01/lib/python3.10/site-packages/benchcab/benchcab.py", line 136, in _get_config
    self._config = read_config(config_path)
  File "/g/data/hh5/public/apps/miniconda3/envs/analysis3-24.01/lib/python3.10/site-packages/benchcab/config.py", line 169, in read_config
    validate_config(config)
  File "/g/data/hh5/public/apps/miniconda3/envs/analysis3-24.01/lib/python3.10/site-packages/benchcab/config.py", line 58, in validate_config
    schema = bu.load_package_data("config-schema.yml")
  File "/g/data/hh5/public/apps/miniconda3/envs/analysis3-24.01/lib/python3.10/site-packages/benchcab/utils/__init__.py", line 56, in load_package_data
    raw = pkgutil.get_data("benchcab", os.path.join("data", filename)).decode("utf-8")
  File "/g/data/hh5/public/apps/miniconda3/envs/analysis3-24.01/lib/python3.10/pkgutil.py", line 639, in get_data
    return loader.get_data(resource_name)
  File "<frozen importlib._bootstrap_external>", line 1073, in get_data
FileNotFoundError: [Errno 2] No such file or directory: '/g/data/hh5/public/apps/miniconda3/envs/analysis3-24.01/lib/python3.10/site-packages/benchcab/data/config-schema.yml'

To reproduce:
module load conda/analysis3-unstable
cd /scratch/$PROJECT/$USER
git clone git@github.com:CABLE-LSM/bench_example.git bench_example_tmp
cd bench_example_tmp
benchcab run

I have also reproduced the error in a custom conda environment.

The uploaded tarball for benchcab v4.0.0 is missing the site-packages/benchcab/data directory (see https://anaconda.org/accessnri/benchcab/files).
Building the conda package locally on Gadi and installing it seems to include the data directory which is strange. Perhaps something specific to the automated deployment is broken.

I've managed to reproduce and fix the error in my personal fork of benchcab by replacing the include_package_data option in setup.cfg with the package_data option.
Hot fix release coming soon.

It might be possible that we are not testing the installed version of the package in our CI workflow. This is one of the major disadvantages in using a flat layout. It would be interesting to see if the CI fails to find the data directory when switching to a src layout.


docs: correct link to tinygo page

The link syntax in
hugo is different from GitHub markdown.
Signed-off-by: spacewander<EMAIL_ADDRESS>

thanks! guess we are also missing a link checker!


car: Fix typo with ParamManager variable

Introduced in https://github.com/sunnypilot/sunnypilot/pull/378

Fix confirmed by user.


HDDS-9888. Reduce log level for "not leader" log entries

What changes were proposed in this pull request?
HDDS-9888. Reduce log level for "not leader" log entries.
Reduced log level from warning to info for the messages logged on non-leader nodes to reduce the number of warning messages.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9888
How was this patch tested?
Manually checked log files.

Thanks @Cyrill for the fix!


JBPM-5158 - AppScopedEntityManager not clean up by TaskTransactionInt…

…erceptor

Merging based on test outcome that proved it fixes the issue


EVEREST-298: improve returned errors

EVEREST-298

Codecov Report

Merging #115 (8961432) into main (2a2047d) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #115   +/-   ##
=====================================
  Coverage   5.18%   5.18%
=====================================
  Files         10      10
  Lines       2756    2756
=====================================
  Hits         143     143
  Misses      2589    2589
  Partials      24      24

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more