Inset Mac OS traffic lights

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Docs
[x] New Binding issue tauri-apps/tauri#4789
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change?

[ ] Yes, and the changes were approved in issue #___
[x] No

Checklist

[x] When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
[ ] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
[x] I have added a convincing reason for adding this feature, if necessary

Other information
Important: There still exist artifacts when resizing the window because the traffic lights are set just after the window has already been drawn.

Thanks for this awesome PR! I had tried doing this only to fail at the "resize" artifacts: #494 Reading your solution made it clear. I should close that issue then.

This feature is fantastic!
However, I noticed a strange behavior: the hover effect still shows when I move the cursor to the "original" position of traffic lights. The electron implementation doesn't seem like have this behavior. I dug into its code but failed to find a solution.

Hi, me too. But I know really little about Tao. If this gets merged then we still have to implement it somehow into tauri.
Could someone review this please?

The implementation seems fine to me. But I'm not sure if it's good to merge now.
@amrbashir Do you think winit can accept this?
Btw you can get the raw window handle to change it yourself if you can't wait for it any longer.

there is a good chance they may not accept but lets go ahead and merge this and if they didn't accept it upstream, we can implement it directly in tauri

I'm sorry this has taken so long. I didn't really have time to work on this. I will document the function and delete the example these days. I hope it's not to late to merge?

Please rebase the PR to fix the conflicts and add a change file

I'll review this tomorrow, it's a super important imo and this or has been open wayy too long 😉 let's get this over the finish line

Maybe it's important to add that I couldn't test the changes since my MacBook broke 🥺. If one of you could do that it would be amazing

After testing this PR now, I feel LogicalSize makes no sense here, the way you currently call the method is as such
                                      // WTH means width here? and height?
.with_traffic_light_inset(LogicalSize { width: 10, height: 20 });

Okay a few other observations:

While this does successfully inset the traffic lights, it does not increase the draggable area size
When resizing the window, it looses the inset

The second one really is a dealbreaker right now, I guess we need to implement a delegate and stuff just like electron does as well

Okay a few other observations:
1. While this does successfully inset the traffic lights, it does not increase the draggable area size

2. When resizing the window, it looses the inset

The second one really is a dealbreaker right now, I guess we need to implement a delegate and stuff just like electron does as well

I don't know if you fixed it already in that commit, but when I tested it with my supplied example the inset was persistent during resizing of the window.

@amrbashir I added back the example, since it's indeed needed to use the method correctly (it's not enough to just call it once but it needs to be called after RedrawRequested)

My only question @haasal is why the with_traffic_light_inset method exists if it's not really doing what the user expects. This feels like misleading api design

I don't know how to implement it instead. This whole thing gave me big headaches because I couldn't find a way to set the inset without having to call the method in some weird way. If you have any idea how to do this without having to call the method after RedrawRequested it would be great!

I still don't see why the example is needed since tao should already handle that internally and not require users to keep calling it in RedrawRequested

I still don't see why the example is needed since tao should already handle that internally and not require users to keep calling it in RedrawRequested

then we should change it to behave that way

@haasal you need add an inset field on the ViewState struct here https://github.com/tauri-apps/tao/blob/c5d606dffeb1733ab06fd8c43eb3b9e7b2f553fe/src/platform_impl/macos/view.rs#L54 and your new function set_traffic_light_inset sets this field, then in draw_rect https://github.com/tauri-apps/tao/blob/c5d606dffeb1733ab06fd8c43eb3b9e7b2f553fe/src/platform_impl/macos/view.rs#L382  you have access to the state where you can read it and re-position the tarffic lights

But the with_traffic_light_inset() method should remain as the public API method for the user to call, right?
The user just shouldn't ever have to call set_traffic_light_inset() manually.

No, both methods should be public, both should modify the newly added state and triggers the traffic light positioning

Sorry for not contributing to this in the last weeks. In spite of what I said I noticed that I don't currently have the time to finish this. I would really appreciate if one of you could push this over the finish line.

Got a new mac and fixed it. I removed the set_traffic_light_inset() method because it wasn't really necessary anymore and would add unnecessary complexity. The with_traffic_light_inset() method on WindowBuilder should now work as expected.

Imho apart from minor refactoring (if you see required) this should be ready to merge. Could you maybe take a look at this @JonasKruckenberg @amrbashir?

@amrbashir ok, I implemented your feedback. I hope the LogicalPosition is ok

Thank you

Just waiting for @wusyong to test and approve as well.

@haasal looks like you didn't sign your commits and I can't merge the PR unless they are signed.

Oh god... I messed up didn't I?

You can squash all your commits into one and then merge with dev. This should be the easiest way to sign commit.

@wusyong I didn't do anything like this before and I don't want to mess up even worse. Do you mean pulling from upstream onto my dev branch and then merging with all of my contributions squashed into one commit? Wouldn't this negate all my commit messages?


OneHotEncoder incorrectly encodes -1 when use_cat_names is True

When use_cat_names is True, OneHotEncoder incorrectly encodes values that equal -1.
Here's a minimal example:
from category_encoders.one_hot import OneHotEncoder

encoder1 = OneHotEncoder(cols=[0], use_cat_names=False)
encoder2 = OneHotEncoder(cols=[0], use_cat_names=True)

a = encoder1.fit_transform([[-1]])
b = encoder2.fit_transform([[-1]])

print('a =', a.values)
print('b =', b.values)

This outputs:
a = [[1 0]]
b = [[0 0]]

I would expect b to have the same values as a.

Thank you. The treatment of missing values, which should be represented by -1, is truly broken.

There is a clash of generated names in get_dummies().
Specifically, when we have all the following:

handle_unknown == 'impute'
use_cat_names == True
the input contains -1

Then:

one column name with -1 suffix gets created because handle_unknown == 'impute'
and another column name with -1 suffix gets created because use_cat_names == True and the input contains -1

And DataFrame, quite understandably, does not support two columns with the same name.
Possible solutions:

find a sentinel value that can never appear in the input data and use it to mark imputed columns
write a function that generates unique column names (e.g.: We may keep adding '#' to the end of the name, until we generate a name that has not been observed before. This can be implemented with a reasonable overhead by using a set to keep track of the seen names.)

I am not particularly happy with either approach. Some opinions?

I was wrong. It is possible to create a DataFrame with duplicate column names:
    def test_one_hot_cat_names(self):
        # currently both these combinations will result into columns named 'Apple_A_1'
        X = pd.DataFrame({'Apple_A': ['1'], 'Apple': ['A_1']})
        enc = encoders.OneHotEncoder(use_cat_names=True)
        result = enc.fit_transform(X)

        self.assertEqual(len(result.columns.unique()), len(result.columns), 'Columns must have unique names')

It's just inconvenient to use the result (e.g.: indexing by name does not work).
So, I see two options:

return a DataFrame with duplicate column names
write a function, which generates unique names

I prefer the second approach. Go ahead.

Solved with #145


Drag & Drop download params double encoded

code-server version: 2.1698-vsc1.41.1 x84_64
OS Version: Amazon Linux

Description
Drag and Drop file from Browser to Desktop yield 404 error In chrome from MacOS.
Path query parameters are double escaped, and rejected with a 404.
I captured traffic packets to see the root cause:
 GET /vscode-remote-resource?path%3D%252Fhome%252Fec2-user%252Ftm-xx%252Flogs%252F2020-02-01-xx.log.gz%26tkn%3D HTTP/1.1
 Host: xxx
 Connection: keep-alive
 Referer: xxx/?folder=vscode-remote%3A%2F%2Fxx%3A8080%2Fhome%2Fec2-user%2Ftm-xx
 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.122 Safari/537.36
 Accept-Encoding: gzip, deflate
 Accept-Language: en-US,en;q=0.9,es;q=0.8
 Cookie: key=xxx

 HTTP/1.1 404 Not Found
 Date: Tue, 03 Mar 2020 16:56:55 GMT
 Connection: keep-alive
 Transfer-Encoding: chunked

Manually fixed with a curl request for testing:
curl -v "http://xxx/vscode-remote-resource?path=%2Fhome%2Fec2-user%2Ftm-xx%2Flogs%2F2020-02-01-xx.log.gz&tkn="

HTTP/1.1 200 OK
Content-Type: text/plain
Date: Tue, 03 Mar 2020 17:02:00 GMT
Connection: keep-alive
Transfer-Encoding: chunked

Steps to Reproduce

Drag file out
Observe empty file error

We don't currently have functionality for downloading files.
Will add!

Tracking here: https://github.com/cdr/code-server/issues/1386


Transfer ownership of files over ssh with sudo/su

This PR addresses #614 by using the SSH user to assign a read-only ACL to the uploaded file, before switching to the sudo/su user and copying the file to the intended destination rather than attempting to mv it.
This allows a file uploaded by an unprivileged user to be 'handed over' to another unprivileged user.
I've created this PR as a draft because there's a few issues worth discussing:

This approach relies on the ability to use filesystem ACLs. Most modern filesystems support this but not all of them do, so I wanted to make sure this fits with pyinfra's philosophy. We can always try this and fall back to another approach as well.
This introduces cp instead of mv when transferring the file out of the temp directory on upload, so for large files this could be a significant amount of extra storage consumed during the upload process.

I've also tried to update the tests, one of them updated ok but another is failing because it's asserting against the wrong call (it's using the setfacl call rather than the cp call). Happy to fix this up if I can get some assistance.

Ah, apologies I meant to create this as a draft PR and now don't seem to be able to change it

Cheers @Fizzadar!
I've been using this in my fork of pyinfra for a week or so now for standing up dev environments fairly heavily, and I haven't hit any issues yet.
I've also done some more investigation into the mv vs cp semantics that might help you in your investigation: The setfacl command demonstrated here actually does allow the other user to mv the file under normal circumstances. The problem is actually that the /tmp directory on most distributions has the sticky bit set. The mv command uses the rename syscall under the hood, and rename fails on directories with sticky bits set unless the uids match (see EPERM on this link). So, when using /tmp unfortunately I can't see any way around using cp.
The good news is that when the files are not on the same filesystem, rename doesn't work (see EXDEV in the link above), so mv actually does a copy and delete under the hood. Usually /tmp is mounted on its own filesystem, so in cases where a user is moving a file somewhere other than /tmp (which I would think would be most cases), and /tmp is just used as pyinfra's staging area, this change actually doesn't result in any change in behaviour provided we delete the temporary file after the cp operation.

@benridley that's incredibly helpful, thank you! I did recall there is actually already a note on the operation docs that it's not suitable for large files due to potential copying.
Given the semantics of mv/cp I think using cp is fine here, if we're on the same filesystem the sticky bit makes it problematic and if separate filesystems mv will copy the file anyway. Switching to cp only keeps things nice and consistent and makes it possible to solve this problem.

Hi @Fizzadar, I've just pushed some new changes. Now the file is removed after the cp operation by running outside sudo. I tested this on the environment I've been working on and so far it's working as inteded.
I also fixed up the test cases so they are all passing, but you're correct that now the assertions are against the setfacl command, and now I've added the rm one of the other tests is asserting against that.
If it's not too much pain would you mind assisting with adding the additional assertions? I'm happy to do so, but it might take me some time to get my head around it since I've not worked with pytest and mock etc before.
Take a look and let me know what you think, cheers!

@benridley thank you for updating this; I've just pushed updated tests for failures at each stage in https://github.com/Fizzadar/pyinfra/pull/616/commits/1a2f68640e073bbdd74df795e2d06b486222a04b.

Awesome! Thanks @Fizzadar. Anything further you'd like to see on this PR?


[Bug] Safety-rules refusing to sign round after crash

🐛 Bug
My validator crashed for other reasons, but after restarting safety-rules refuses to sign rounds. This is a 3 validator network.
DEBUG 2020-06-10 05:07:10 consensus/src/round_manager.rs:425 Planning to vote for a NIL block [id: 65dba7c3 (NIL), epoch: 1, round: 29445, parent_id: d62b2854]
DEBUG 2020-06-10 05:07:10 consensus/src/round_manager.rs:512 Success with NoWaitRequired { current_duration_since_epoch:<PHONE_NUMBER>.644293691s, early_duration:<PHONE_NUMBER>91s } for being able to vote
ERROR 2020-06-10 05:07:10 consensus/src/epoch_manager.rs:508 [RoundManager] SafetyRules Rejected [id: 65dba7c3 (NIL), epoch: 1, round: 29445, parent_id: d62b2854]

Caused by:
    Proposal at round 29445 is not newer than the last vote round 29445

https://fburl.com/everpaste/tb57yu74
https://fburl.com/everpaste/fem98d5m

This seems to be a normal feature of the algorithm: the validator issued a vote for round 29445, sees the same proposal again on restart, and refuses to sign it (validators sign in strictly increasing rounds). The network should be able to advance on >= 2 signatures (2 or 3 depending on whether the leader has received the fallen validator's initial vote) and move on to the next round.

see https://github.com/libra/libra/issues/4807, this refers to Consensus losing a vote and re-requesting for the same round

https://github.com/libra/libra/pull/4843


Added capability to display open radar charts

Hey Alvaro,
I appreciate you open sourcing this. It has been very helpful with a radar chart project my company is developing.
We needed to be able to display an open chart without having the line connect the last point back to the first point. This is because in our implementation of a radar chart our axes represent hours of the day (0-23) and we wanted to be able to show the progression of the line as it goes from one axis (or hour) to the next.
Please let me know what you think, I appreciate you considering my pull request!

I wanted to let you know that I wasn't sure how you preferred to minify your js code so I did not modify radar-chart.min.js in this pull request.

Atom text editor auto-formatted the code so I thought I'd let you know the real changes I made to the pull request.
In radar-chart.js config section I added an "open" setting which defines whether the graph will be open or not.
In radar-chart.js (line 222) I added the code
`var polygonType = 'polygon';
if (cfg.open) {
polygonType = 'polyline';
}`

Thanks!


Added ExpressibleByArrayLiteral to the Linked List and Tests

The Linked List data structure now conforms with the ExpressibleByArrayLiteral. For more details here

@kelvinlauKL this is the implementation for the linked only. Before I continue applying this feature to others DS, I think a review will be good for me to have an idea of the repo's standards.

Yep that looks fine. You've got ExpressibleByArrayLiteral in it's own extension, and I don't have a problem with your treatment with @discardableResult.
It's not clear whether anyone would want to subclass the linked list, but by marking the list as final you've guaranteed that all the methods in the Linked List to use static dispatch which should give some minor optimizations 👍
Looks good.


feat(build): add "vite:emit" output plugin

Run post-build hooks before the writeBundle phase
Allow post-build hooks to write assets by mutating the build.assets array
Empty the outDir after the build succeeds (right before the writeBundle phase)
Write the index.html in the writeBundle phase
Copy the public dir in the writeBundle phase
Respect emitAssets: true even if write is false
Respect emitIndex: true even if write is false

Fixes vite-plugin-legacy, which was broken by https://github.com/vitejs/vite/pull/957#issuecomment-717926853
Reverts https://github.com/vitejs/vite/commit/5e7c309baa16b78fbfdfbf3fffff7af775c26047, which I tacked onto another PR without understanding the emitIndex option's purpose, which is to prevent index.html rendering entirely, not just to prevent writing. (emit !== write)

Looks like the vite:emit plugin is running before others, eg: the CSS plugin. Fixing it...

Okay, I worked around the issue in my previous comment.
The Build.bundle property is replaced by the Build.options property, which configureBuild hooks can use to customize the input/output options of each build. Then we append the vite:emit plugin so it runs last.
LGTM 👍

Whacked the last few bugs

@yyx990803 I stubbed out a basic test for multi builds: https://github.com/vitejs/vite/pull/977/commits/55187131a0793b481f7ecd29306211e523076d26
No tests yet for:

mutating the config argument in configureBuild hook
pushing to build.assets in a post-build hook

I pushed a new commit with a bunch of changes: https://github.com/vitejs/vite/pull/977/commits/c894e2dcb2db61d895e235f24906f789d1775d85
The changes are listed in the commit message.
Testing them out now.

Pushed https://github.com/vitejs/vite/pull/977/commits/0032d93c3431cd194dc0bd0d4c66f70f7fb93fcf, which simplifies how the index.html output path is resolved by replacing the normalizeInput function I added earlier in this PR.

This PR seems break config.entry...


Updating JSON column doesn't work with integer values

Laravel Version: 5.3.19
PHP Version: 7.0.8
Database Driver & Version: Mysql 5.7.15

Description:
Laravel ignores updating model if there is a JSON attribute with integer value and doesn't throw any exception. So these lines of code do nothing:
Product::find(1)
    ->update([
        'status' => $request->status,
        'properties->base_price' => 5400,
        'properties->option_price' => 120,
        'price' => 5400+120,
    ]);

I have to convert values to string to update JSON properties and these lines of code works fine:
Product::find(1)
    ->update([
        'status' => $request->status,
        'properties->base_price' => strval(5400),
        'properties->option_price' => strval(120),
        'price' => 5400+120,
    ]);

Steps To Reproduce:
Try to update a JSON column object property with an integer value.

I would rather do it like this:
Product::find(1)
    ->update([
        'status' => $request->status,
        'properties' => [
            'base_price' => 5400,
            'option_price' => 120,
        ],
        'price' => 5400+120,
    ]);

I have same issue, rather it is not working like this
 User::find(1)->update([
                'settings->push_notifications->follow' => 0
            ]);

Also not even like this
        User::find(1)->update([
            'settings' => [
                'push_notifications' => [
                    'follow' => 0
                ]
            ]
        ]);

Fix submitted

@themsaid Update it is working fine for
        $user->update([
            'settings' => [
                'is_subscribed' => 0,
                'push_notifications' => [
                    'follow' => false,
                ]
            ],
        ]);

Is it possible to make it work like this as well.
        $user->update([
            'settings->is_subscribed'              => 0,
            'settings->push_notifications->follow' => true,
        ]);


Previews of posts when Discourse comments are used posts to Discourse

If you’re using Discourse to embed comments in Ghost https://docs.ghost.org/integrations/discourse/, if you preview a post, this post will get posted to Discourse.
Need to detect when a post is being previewed and not show the Discourse embed, which will then not trigger posting.
Note: will look at including a theme with Discourse comments included

Need to wrap this in context as per https://forum.ghost.org/t/disable-disqus-comments-on-preview/4683
Fixed in my fork of Casper https://github.com/bmann/Casper/commit/58e4d1a36decdc40fdef13b873a41b203ca5e23c


popup click event not working

error code
https://github.com/Semantic-Org/Semantic-UI/commit/096f44a1c78645e8e6457b4e097ddf52fbd5fb8c

$offsetParent is undefined

Can you provide a test case? There's a JSFiddle link to fork in readme.

JSFiddle link
http://jsfiddle.net/fx2y9t3w/4/

Fixed in next


EwsEditor url in Readme is wrong

EwsEditor points to https://ewseditor.codeplex.com/ which is defunct
it should point to https://github.com/dseph/EwsEditor

addressed by #352


Fix and enable R meta examples (and tests)

According to source code comments, this had to do with static calls which are not working.
I think I fixed that (when?), so enable the meta example and integration tests and see if travis likes it

@karlnapf I would like to work on the issue. How do I start?

@karlnapf I would like to work on the issue.How do I start?

Cool!
Currently, doing static calls via the swig r interface doesn't work. If
they would work this is solved. So check swig and r and how it works in
shogun. Nontrivial so only attempt if you know what you're doing
On Tuesday, 25 October 2016, Sourav Singh<EMAIL_ADDRESS>wrote:

@karlnapf https://github.com/karlnapf I would like to work on the
issue.How do I start?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/shogun-toolbox/shogun/issues/3466#issuecomment-256097670,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAqqv8a5bahf78-pQ1xaYLagfmVQqpc7ks5q3jdcgaJpZM4KeE-H
.

--
Sent from my phone

@karlnapf I found the patch which fixed the static calls here-https://github.com/shogun-toolbox/shogun/pull/3251 So I believe I need to enable meta examples one by one and check if they pass

Nope
I activated them in this commit in a feature branch
https://github.com/shogun-toolbox/shogun/commit/e9c079b91a134de642c3cbdf61b52e1ae0dc81e5
As you can see, travis and the r build failed.
You can check this out locally, enable r interface, and run the tests to
reproduce the error locally
On Wednesday, 26 October 2016, Sourav Singh<EMAIL_ADDRESS>wrote:

@karlnapf https://github.com/karlnapf I found the patch which fixed the
static calls here-#3251
https://github.com/shogun-toolbox/shogun/pull/3251 So I believe I need
to enable meta examples one by one and check if they pass
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/shogun-toolbox/shogun/issues/3466#issuecomment-256449810,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAqqvzaKPJPNnFaT4ryeMRLCVrgzhpdoks5q36ecgaJpZM4KeE-H
.

--
Sent from my phone

This has high priority as we are currently not executing any R bindings in any test (removed the modular examples)
@vigsterkr


Remove the RSS icon from indicator and dataset term view

For instance at  http://landportal.info/book/indicator/wb-lgaf2016-651

Maybe this could be useful


Smooth scrolling breaks over iframes

Hey there. Not sure if this is a conflict on my end. Is this a known or common issue? Love this script btw.

No it should work with iframes.
Sample page?

Sure! Thanks for the quick response.
This page has facebook comments loading in an iframe: https://www.nativeimaging.com/blog/seo-companies-the-good-the-bad-the-ugly/
Also, the home page has a video: https://www.nativeimaging.com/

I couldn't figure out the cause for the issue. Still no luck.

Yes this is since Chrome 51
See: https://www.chromestatus.com/feature/5678869528969216

I'll post an update but it'll only work if you load SmoohtScroll inside the iframes as well.
(cannot do anything about 3rd party iframes at the moment unfortunately)

this should be fixed now, closing

Any news guys?
@galambalazs

not fixed for you? are you loading SS in all your iframes?


question: set I/O's in test- node (c++ or python)

Hello,
I have a question regarding the driver: I know the driver supports setting I/O's.
I would like to test the I / O's with a simple node, but unfortunately I do not know how to start to program.
Does anyone have a test node in c++ or python to set the I / O's?
Thanks !

There is a (very) old script in ur_driver (here) that you could perhaps use as an inspiration. Note that it uses a Python module of ur_driver, so it's not immediately usable with ur_modern_driver.

As this is not an actionable issue with the package in this repository, I'm going to close it.
Please feel free to keep commenting on it of course.

@TSsimon it's easy to do this via the /URScript topic: just publish one message containing a string like "set_digital_out(8, True)" (obviously adjusting it to your needs) and that's all.

and that's all.

unless you want to use services. In which case using the urscript topic is not going to work.

unless you want to use services

true. One option to build a blocking call (at application level) for setting IOs and waiting until completion is to subscribe to the /ur_driver/io_states topic right after publishing the urscript message, and there block until the io you just set turns to the state you expect.

but since this question starts to be quite long and is unactionable as mentioned by @gavanderhoorn , it might be best if you post it to ROS answers instead.

@gonzalocasas: do you have any particular reason to not use the set_io service?

None except ignorance 😛
I had no idea the driver provides such a service, I didn't see it listed in the README.md nor the wiki, and wrongly assumed there was none provided.


Error on build

Steps to reproduce
pnpm build && pnpm start
Expected behavior
Build succeed
Current behavior
Hi there,
Thank you for this great boilerplate ! Been working on it all day yesterday, but had a quack when I tried to build the project.
I tried building from the repo without any modification and had the same issue.
Looks like an issue with PINO. I tried many things to fix it and made it with on of the following:

Change these dependencies version to "nestjs-pino": "^2", "pino": "^6.4", "pino-http": "^5.6.0", "pino-pretty": "^6"
Or simply by added NODE_ENV=production to script.start in package.json

Any better way to fix it ?
Thanks,
Tim
pnpm build && pnpm start

><EMAIL_ADDRESS>prebuild /Users/tim/Desktop/test
> rimraf dist

><EMAIL_ADDRESS>build /Users/tim/Desktop/test
> nest build --webpack --webpackPath ./webpack.config.js

webpack 5.76.2 compiled successfully in 7767 ms

><EMAIL_ADDRESS>start /Users/tim/Desktop/test
> node dist/main

node:internal/event_target:1010
  process.nextTick(() => { throw err; });
                           ^
Error: Cannot find module '/Users/tim/Desktop/test/dist/lib/worker.js'
    at Module._resolveFilename (node:internal/modules/cjs/loader:1075:15)
    at Module._load (node:internal/modules/cjs/loader:920:27)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at MessagePort.<anonymous> (node:internal/main/worker_thread:159:24)
    at [nodejs.internal.kHybridDispatch] (node:internal/event_target:735:20)
    at exports.emitMessage (node:internal/per_context/messageport:23:28)
Emitted 'error' event on Worker instance at:
    at [kOnErrorMessage] (node:internal/worker:290:10)
    at [kOnMessage] (node:internal/worker:301:37)
    at MessagePort.<anonymous> (node:internal/worker:202:57)
    at [nodejs.internal.kHybridDispatch] (node:internal/event_target:735:20)
    at exports.emitMessage (node:internal/per_context/messageport:23:28) {
  code: 'MODULE_NOT_FOUND',
  requireStack: []
}

Node.js v18.15.0
 ELIFECYCLE  Command failed with exit code 1.

Node.js version
18
In which operating systems have you tested?

[X] macOS
[ ] Windows
[ ] Linux

Other
No response

Thanks for the report, it should be a known issue and the reason is because of pino-pretty. I do not point out that in the README is because I expect we will not use pino-pretty in a production build, so I assume you have NODE_ENV=production in the .env or docker env by default. But for some reason if you still want to use pino-pretty in the production, use can use pino-webpack-plugin to solve this, just simply install it and add some lines the webpack.config.js.
pnpm install -D pino-webpack-plugin

// webpack.config.js
const { PinoWebpackPlugin } = require('pino-webpack-plugin');

module.exports = {
  ...
  plugins: [
    ...
    new PinoWebpackPlugin({ transports: ['pino-pretty'] }),
  ],
}

I tested in the v2.2.1, seems upgraded packages make the webpack version not sync and break the build, so I have to force override the version to make it work. No this step requires for v2.2.0.
// package.json
{
  ...
  "pnpm": {
    "overrides": {
      "webpack": "^5.78.0"
    }
  }
}

Maybe I will point out this in the README for the next release, Thanks.


[USM] Reduce new_dynamic_value_size

What does this PR do?
Reduce new_dynamic_value_size in order to decrease program size.

Motivation
The value of the new_dynamic_value_size can be used by only 16 bits.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

The issue of reducing the instruction limit was handled by https://github.com/DataDog/datadog-agent/pull/21627#pullrequestreview-1788774766


Using datepicker causes all lazily-loaded chunks' code to be duplicated in 0.chunk.js

Using Angular CLI beta.21 with Angular 2.2.1
Reproducible bug at repo https://github.com/aaronleeucla/angular-cli-lazy-load-bug-repro

I am afraid I will need help with this issue from angular cli team

I have seen similar behavior eventually
how did I fixed it
I have imported a datepicker only in lazy loaded module
and imported it from ng2-bootstrap/datepicker


Add Cava.Lib.VecConstEq

Implement an efficient constant equality for vectors #657
Currently we compare against nats, so the constants can be out of range (in
which case they're truncated). Eventually these should be replaced by
Fin 2^ns, which should prevent this.

Great! Can I change my mind and not have n and v implicit:
  Definition vecConstEq (n v : nat)
                        (inp: signal (Vec Bit n)) :
                        cava (signal Bit

For the tests you should be able to wrote:
Example ex1 : vecConstEq 8 42 (N2Bv_sized 8 42) = true.
Proof. trivial. Qed.

Also if you moved Local Open Scope N_scope. to just before your tests, you don't neet to qualify 0%nat.

For the tests you should be able to write:
Example ex1 : vecConstEq 8 42 (N2Bv_sized 8 42) = true.
Proof. trivial. Qed.

Hmm? N2Bv_sized 8 42 is a Bvector 8 and I need a signal (Vec Bit 8). I've rewritten the examples to be a bit more like that, though.

For the tests you should be able to write:
Example ex1 : vecConstEq 8 42 (N2Bv_sized 8 42) = true.
Proof. trivial. Qed.

Hmm? N2Bv_sized 8 42 is a Bvector 8 and I need a signal (Vec Bit 8). I've rewritten the examples to be a bit more like that, though.

The expression signal (Vec Bit 8) is Bvector 8 i.e. Vector.t bool 8 for the simulation/semantic interpretation.

Ah, so I can do that so long as they're outside the WithCava section, I see!

I don't have permission to merge into main!

I don't have permission to merge into main!

Please try now.


docs: Add a section about Expo Modules API

As discussed previously, this PR adds a section about Expo Modules API in the Native Development > Introduction section.
cc: @blakef @brentvatne

As discussed previously

Where was this previously discussed?

As discussed previously

Where was this previously discussed?

@cortinico, there are two references:

It was mentioned in the React Native Docs: New architecture Google doc by Brent to cross-reference it
It was also discussed with @blakef directly in a DM.

looks good given the suggestions above. one thing we may want to revisit on this page though is to add guidance from the rfc: https://github.com/react-native-community/discussions-and-proposals/blob/main/proposals/0759-react-native-frameworks.md#what-do-we-recommend-to-react-native-library-developers


Separate voices for genders/characters

Some sort of system that allows different voices to be saved and assigned to different genders, or maybe even characters.

Similar to #8

Gendered voiced is implemented, and character voices seem unnecessary, especially since there aren't that many voices to choose from. We can probably close this one.


Run backend tests with python3 exe

The backend tests currently check for pytest using pip but execute using pytest. On some platforms this can create a mismatch where pytest-xdist appears to be available but isn't found when called.

@jenkins-droid test this please

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@gongsu832 This was the cleanest solution I could come up with to handle the docker and not-docker scenarios. It is a behavioral change in that this won't capture changes to $NPROC made after generator time if you call make directly. I don't believe that will be an issue with the current docker scripts, but please let me know if we need a different solution.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@jenkins-droid test this please

Can one of the admins verify this patch?

@jenkins-droid test this please

Can one of the admins verify this patch?

Jenkins Linux amd64 Build #949 [push] Run backend tests with p... failed after 2 sec

Can one of the admins verify this patch?

Jenkins Linux s390x Build #947 [push] Run backend tests with p... failed after 1.6 sec

Jenkins Linux ppc64le Build #100 [push] Run backend tests with p... failed after 2 sec


vslideup overlap constraint

Hi
vslideup instruction has the constraint that source and destination vector register group cannot overlap even if LMUL = 1.
When debugger tries to fill scalar data into all 32 vector register files, the only way I know is use vslideup to move each scalar value. But one vector register can't be filled by vslideup under this constraint.
Is there any other method for debugger to write all 32 vector register?

vslidedown and vslide1down don't have this constraint, and there's a note addressing the debugging use case:
"The vslide1down instruction can be used to load values into a vector register without using memory and without disturbing other vector registers. This provides a path for debuggers to modify the contents of a vector register, albeit slowly, with multiple repeated vslide1down invocations."


Update node.lua

Because there is a missng IF statement, all departures >5 minutes disappear from the screen. So removing in the IF statement the condition for >5 min. it works.

@cstruck Any thoughts about this. I have no clue what this part of the code is supposed to do.

Yes that is a feature we've built-in for our setup where one of our stations was only reachable in >5min so we did not want to show arriving trains that we could not reach anymore. We can merge this.

Merged in 352d32f044dbeb7b275a8f3cffc787e341792342. Thanks.


Jira Collector fails when retrieving FeatureData

Hi, guys!
I'm facing an error when running the collector: ERROR c.c.d.c.s.FeatureDataClientSetupImpl - Unexpected error in Jira paging request of java.lang.NullPointerException.
The project name is displayed in the Jira dashboard configuration dropbox, but no other information is presented after I select one project.
This is my collector log:
2016-06-01 13:44:00,016 INFO  c.c.d.collector.FeatureCollectorTask - Starting Feature collection...
2016-06-01 13:44:00,054 INFO  c.c.d.c.team.TeamDataClientSetupImpl - Beginning collection of team data at Wed Jun 01 13:44:00 UTC 2016
2016-06-01 13:44:01,143 INFO  c.c.d.c.team.TeamDataClientSetupImpl - Process took :1.08712382 seconds to update
2016-06-01 13:44:01,150 INFO  c.c.d.c.p.ProjectDataClientSetupImpl - Beginning collection of project data at Wed Jun 01 13:44:01 UTC 2016
2016-06-01 13:44:02,040 INFO  c.c.d.c.p.ProjectDataClientSetupImpl - Process took :0.887490468 seconds to update
2016-06-01 13:44:02,045 INFO  c.c.d.c.s.FeatureDataClientSetupImpl - Beginning collection of feature data at Wed Jun 01 13:44:02 UTC 2016
2016-06-01 13:44:02,960 ERROR c.c.d.c.s.FeatureDataClientSetupImpl - Unexpected error in Jira paging request of java.lang.NullPointerException
[null]
This is my docker-compose Jira configuration:
hygieia-jira-feature-collector:
image: hygieia-jira-feature-collector:latest
container_name: hygieia-jira
volumes:

./logs:/hygieia/logs
links:

mongodb:mongo

hygieia-api
environment:

JIRA_BASE_URL=https://.atlassian.net/

JIRA_CREDENTIALS=xsxsxsxsxsxsxsxsxsxsxsxs

JIRA_DELTA_START_DATE=2016-01-01T00:00:00.000000

JIRA_MASTER_START_DATE=2016-01-01T00:00:00.000000

JIRA_PAGE_SIZE=50

JIRA_SCHEDULED_PRIOR_MIN=2

JIRA_DELTA_COLLECTOR_ITEM_START_DATE=2016-01-01T00:00:00.000000

JIRA_QUERY_ENDPOINT=rest/api/2/

JIRA_ISSUE_TYPE_ID=Story #also tried 10001
#{
#self: "https://.atlassian.net/rest/api/2/issuetype/10001",
#id: "10001",
#description: "gh.issue.story.desc",
#iconUrl: "https://.atlassian.net/images/icons/issuetypes/story.svg",
#name: "Story",
#subtask: false
#}

JIRA_SPRINT_DATA_FIELD_NAME=customfield_10017
#customfield_10017:["com.atlassian.greenhopper.service.sprint.Sprint@f33f15 ..."]

JIRA_EPIC_FIELD_NAME=customfield_10018
#customfield_10018: "JDOS-1" #My Epic Name

Thanks in advance,

@amp5208

@tabladrum:  Question regarding the Dockerfile configurations - can I assume that your team has tested environment variable additions through a Docker container to the Feature Collectors?  I ask because my code does not explicitly read system environment variable declarations, unless Java Springboot takes care of that for me.
@mmullerbr , Thank you for reaching out.  Pending @tabladrum's answer above, please confirm the following parts of your configuration:
JIRA_BASE_URL=[your jira url, assuming that your Java keystore is updated with your SSL cert for jira]
JIRA_CREDENTIALS=[jira credentials with the following access format, in base64:  user:password]

# Also, you are missing your Jira field mappings to one of the following internal statuses:  todo, doing, done.  Examples:
feature.todoStatuses[0]=Open
feature.todoStatuses[1]=Groom
feature.todoStatuses[2]=Selected for Development
feature.todoStatuses[3]=Backlog
feature.todoStatuses[4]=Grooming
feature.todoStatuses[5]=ToDo
feature.todoStatuses[6]=To Do
feature.todoStatuses[6]=Backlog1
feature.doingStatuses[0]=Validation
feature.doingStatuses[1]=Test
feature.doingStatuses[2]=In Process
feature.doingStatuses[3]=In Progress
feature.doingStatuses[4]=Awaiting Approval - 2
feature.doingStatuses[5]=Change Request - 2
feature.doneStatuses[0]=Awaiting Approval
feature.doneStatuses[1]=Done
feature.doneStatuses[2]=Resolved

Please check the above configurations and let me know if you are still having issues.

@jimzucker - Can you see this if you have time? Thanks

@amp5208 Yes the Env variables set in the docker file & docker-compose files pass thru correctly.  The spring classes are taking care of pulling them in and making them available internally.  If you have a specific issue let us know.

@amp5208 @tabladrum Yes the Env variables set in the docker file & docker-compose files pass thru correctly. The spring classes are taking care of pulling them in and making them available internally. If you have a specific issue let us know.

@jimzucker , Thank you for confirming.
In that case, @mmullerbr , please see my updated and simplified application properties configuration details at the following README fork; try providing ALL of the properties that are relevant and not commented out via Docker ENVs:  https://github.com/amp5208/Hygieia/blob/master/jira-feature-collector/README.md#sample-applicationproperties-file-with-minimum-overrides.  I also provided explanations for most properties.

Just saw this as I was going to issues page. I was able to get the most recent jira collector working today (built off of master). I ran into a similar issue and found that I was missing some properties. Try comparing the properties that are generated in the docker container to this (my ordering is a little different):
#Database Name
database=dashboard

#Database HostName - default is localhost
dbhost=<IP_ADDRESS>

#Database Port - default is 27017
dbport=27017

#Database Username - default is blank
dbusername=db

dbpassword=dbpass

#Collector schedule (required)
feature.cron=0 0/5 * * * *

#Page size for data calls (Jira maxes at 1000)
feature.pageSize=1000

#In-built folder housing prepared REST queries (required)
feature.queryFolder=jiraapi-queries

#Jira API Query file names (String template requires the files to have .st extension) (required)
feature.storyQuery=story
feature.epicQuery=epic
feature.projectQuery=projectinfo
feature.memberQuery=memberinfo
feature.sprintQuery=sprintinfo
feature.teamQuery=teaminfo
feature.trendingQuery=trendinginfo

#Jira Connection Details
feature.jiraProxyUrl=
feature.jiraProxyPort=

# Trending Query:  Number of days in a sprint (not-required)
feature.sprintDays=60

# Trending Query:  Length of sprint week (not-required)
feature.sprintEndPrior=7

#Scheduled Job prior minutes to recover data created during execution time (usually, 2 minutes is enough)
feature.scheduledPriorMin=2

#Delta change date that modulates the collector item task - should be about as far back as possible, in ISO format (required)
feature.deltaCollectorItemStartDate=2008-01-01T00:00:00.000000

#Jira Connection Details
feature.jiraBaseUrl=<not shown>
feature.jiraQueryEndpoint=rest/api/2/

#reference:  https://www.base64decode.org/

#feature.jiraOauthAuthtoken=sdfghjkl==
#feature.jiraOauthRefreshtoken=sdfagheh==
#feature.jiraOauthRedirecturi=uri.this.is.test:uri
#feature.jiraOauthExpiretime=234567890987

#Start dates from which to begin collector data, if no other data is present - usually, a month back is appropriate (required)
feature.deltaStartDate=2015-03-01T00:00:00.000000
feature.masterStartDate=2008-01-01T00:00:00.000000

# In Jira, general IssueType IDs are associated to various "issue"
# attributes. However, there is one attribute which this collector's
# queries rely on that change between different instantiations of Jira.
# Please provide a numerical ID reference to your instance's IssueType for
# the lowest level of Issues (e.g., "user story") specific to your Jira
# instance.  Note:  You can retrieve your instance's IssueType ID
# listings via the following URI:  https://[your-jira-domain-name]/rest/api/2/issuetype/
feature.jiraIssueTypeId=6

# In Jira, your instance will have its own custom field created for "sprint" or "timebox" details,
# which includes a list of information.  This field allows you to specify that data field for your
# instance of Jira. Note: You can retrieve your instance's sprint data field name
# via the following URI, and look for a package name com.atlassian.greenhopper.service.sprint.Sprint;
# your custom field name describes the values in this field:
# https://[your-jira-domain-name]/rest/api/2/issue/[some-issue-name]
feature.jiraSprintDataFieldName=customfield_10005

# In Jira, your instance will have its own custom field created for "super story" or "epic" back-end ID,
# which includes a list of information.  This field allows you to specify that data field for your instance
# of Jira.  Note:  You can retrieve your instance's epic ID field name via the following URI where your
# queried user story issue has a super issue (e.g., epic) tied to it; your custom field name describes the
# epic value you expect to see, and is the only field that does this for a given issue:
# https://[your-jira-domain-name]/rest/api/2/issue/[some-issue-name]
feature.jiraEpicIdFieldName=customfield_10006

#Core Artifacts
# These arrays of status mappings must be completed in order for custom source system statuses to be providable by
# Hygieia.  Currently, Hygieia only maps to the following 3 status mappings:  to do, doing, and done.  You can find
# all available issue status mappings by going to your instance's version of the following API call:
# http://fake.jira.com/rest/api/2/status/.  Your statuses are listed in the JSON response as "name."
feature.todoStatuses[0]=OPEN
feature.doingStatuses[0]=IN PROGRESS
feature.doingStatuses[1]=TEST
feature.doingStatuses[2]=TESTING
feature.doneStatuses[0]=DONE
feature.doneStatuses[1]=CLOSED

feature.jiraCredentials=<not shown>

logging.level.com.capitalone.dashboard.collector=DEBUG
logging.level.com.atlassian.jira=INFO
#logging.level.org.apache.http.impl.nio.client.DefaultHttpAsyncClient=DEBUG
logging.level.com.capitalone.dashboard=DEBUG
#logging.level.org.springframework=DEBUG

@MarkRx , Thank you for following up regarding this issue.  I also see some issues with your property configuration.  See the following for changes:
feature.jiraIssueTypeId=6 # --> Should be a string value that corresponds to the given ID, e.g., "Story" or "Epic"

# Leave the following blanked-out
feature.jiraOauthAuthtoken=
feature.jiraOauthRefreshtoken=
feature.jiraOauthRedirecturi=
feature.jiraOauthExpiretime=

# Comment these lines out if you have no proxy:
#feature.jiraProxyUrl=
#feature.jiraProxyPort=

# Reduce your page size:
feature.pageSize=100

Essentially, make your property configs/environment settings for Docker match that of the property configs on this README:  https://github.com/amp5208/Hygieia/blob/master/jira-feature-collector/README.md#sample-applicationproperties-file-with-minimum-overrides

@amp5208 I had originally commented out the proxy configuration but If I remember correctly that resulted in a NPE at FeatureDataClientSetupImpl:87:
	if (!this.featureSettings.getJiraProxyUrl().isEmpty()

Hi, Guys! Thaks for the feedback!
@amp5208, I have tried adding the fields mapping before, but this time I realized that after a docker restart (in order to restart the collector and get the properties) all changes made manually in the properties file are wiped out. (Is there a way to add more properties via docker configuration or should I open another issue for this?)
In order to work around this, I had to stop the collector process (killing it forces a Docker stop/start and consequently the additional properties are wiped out) and run a new collector process  (maybe I'm missing something, because I'm not a Linux expert).
By doing this the collector runs without errors.
nohup java -jar jira-feature-collector.jar --spring.config.location=hygieia-jira-feature-collector-new.properties &
2016-06-02 16:21:03,039 INFO  c.c.d.collector.FeatureCollectorTask - Feature Data Collection Finished
2016-06-02 16:22:00,000 INFO  c.c.d.collector.CollectorTask - Running Collector: Jira
2016-06-02 16:22:00,003 INFO  c.c.d.collector.FeatureCollectorTask - Starting Feature collection...
2016-06-02 16:22:00,015 INFO  c.c.d.c.team.TeamDataClientSetupImpl - Beginning collection of team data at Thu Jun 02 16:22:00 UTC 2016
2016-06-02 16:22:01,006 INFO  c.c.d.c.team.TeamDataClientSetupImpl - Process took :0.990285674 seconds to update
2016-06-02 16:22:01,012 INFO  c.c.d.c.p.ProjectDataClientSetupImpl - Beginning collection of project data at Thu Jun 02 16:22:01 UTC 2016
2016-06-02 16:22:01,979 INFO  c.c.d.c.p.ProjectDataClientSetupImpl - Process took :0.966078813 seconds to update
2016-06-02 16:22:01,998 INFO  c.c.d.c.s.FeatureDataClientSetupImpl - Beginning collection of feature data at Thu Jun 02 16:22:01 UTC 2016
2016-06-02 16:22:02,984 INFO  c.c.d.c.s.FeatureDataClientSetupImpl - Process took :0.986238778 seconds to update
2016-06-02 16:22:02,984 INFO  c.c.d.collector.FeatureCollectorTask - Feature Data Collection Finished
However, no data is being presented on the dashboard. Here follows my new properties file:
#Database
database=dashboard
dbhost=<IP_ADDRESS>
dbport=27017
dbusername=db
dbpassword=dbpass
feature.pageSize=100
feature.deltaStartDate=2016-03-01T00:00:00.000000
feature.masterStartDate=2016-03-01T00:00:00.000000
feature.deltaCollectorItemStartDate=2016-03-01T00:00:00.000000
feature.cron=0 * * * * *
feature.queryFolder=jiraapi-queries
feature.storyQuery=story
feature.epicQuery=epic
NO PROXY
feature.jiraProxyUrl=
feature.jiraProxyPort=
feature.jiraBaseUrl=https://myJira.atlassian.net
feature.jiraQueryEndpoint=rest/api/2/
feature.jiraCredentials=asasasasasasasasasas
OAuth is not fully implemented; please blank-out the OAuth values:
feature.jiraOauthAuthtoken=
feature.jiraOauthRefreshtoken=
feature.jiraOauthRedirecturi=
feature.jiraOauthExpiretime=
feature.jiraIssueTypeId=Story
feature.jiraSprintDataFieldName=customfield_10017
feature.jiraEpicIdFieldName=customfield_10018
feature.todoStatuses[0]=To Do
feature.doingStatuses[0]=In Progress
feature.doneStatuses[0]=Done
#[{...name:"In Progress"...},{... name: "Done" ...},{... name: "To Do" ...}]
Thanks in advance,

@MarkRx :  Did you receive this NullPointerException with the newest version on upstream master?  I ask because issues related to the proxy configuration were fixed in a previous issue/PR (https://github.com/capitalone/Hygieia/pull/322)
@mmullerbr :  There is, in fact, a different way to pass in the property file for Hygieia.  You may use the Docker -v [dockerhost dir]:[dockercontainer dir] to volume map to a local property file configuration from within the Docker container; more details can be found on the Docker official content page:  Volume Mapping.  Additionally, you may have to force a different CMD run option for the Docker container, so that it knows where to find your application.properties file; this can be done by adding a new java command at run time at the end of the docker run command:  java -jar jira-feature-collector.jar --spring.config.location=hygieia-jira-feature-collector-new.properties.  Please see below for a sample command / setup:
#!/bin/bash
docker run -d -p 8080:8080 -v $SRC_DIR/hygieia-jira-feature-collector-new.properties:$DOCKER_CNTR_DIR/hygieia-jira-feature-collector-new.properties $HYGIEIA_DOCKER_IMAGE_TAG:latest kill $(pgrep -o java) && java -jar jira-feature-collector.jar --spring.config.location=$DOCKER_CNTR_DIR/hygieia-jira-feature-collector-new.properties

@jimzucker :  Please verify my above statements and make corrections as needed.

I just submitted PR #614 will make using external custom configs easier.
@amp5208 Yes. Here is the stack trace:
2016-06-03 15:06:00,067 ERROR o.s.s.s.TaskUtils$LoggingErrorHandler - Unexpected error occurred in scheduled task.
java.lang.NullPointerException: null
        at com.capitalone.dashboard.client.team.TeamDataClientSetupImpl.updateObjectInformation(TeamDataClientSetupImpl.java:85) ~[jira-feature-collector.jar!/:2.0.2-SNAPSHOT]
        at com.capitalone.dashboard.client.team.TeamDataClientImpl.updateTeamInformation(TeamDataClientImpl.java:130) ~[jira-feature-collector.jar!/:2.0.2-SNAPSHOT]
        at com.capitalone.dashboard.collector.FeatureCollectorTask.collect(FeatureCollectorTask.java:99) ~[jira-feature-collector.jar!/:2.0.2-SNAPSHOT]
        at com.capitalone.dashboard.collector.FeatureCollectorTask.collect(FeatureCollectorTask.java:26) ~[jira-feature-collector.jar!/:2.0.2-SNAPSHOT]
        at com.capitalone.dashboard.collector.CollectorTask.run(CollectorTask.java:63) ~[core-2.0.2-SNAPSHOT.jar!/:2.0.2-SNAPSHOT]
        at org.springframework.scheduling.support.DelegatingErrorHandlingRunnable.run(DelegatingErrorHandlingRunnable.java:54) ~[spring-context-4.1.7.RELEASE.jar!/:4.1.7.RELEASE]
        at org.springframework.scheduling.concurrent.ReschedulingRunnable.run(ReschedulingRunnable.java:81) [spring-context-4.1.7.RELEASE.jar!/:4.1.7.RELEASE]
        at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) [na:1.8.0_74]
        at java.util.concurrent.FutureTask.run(Unknown Source) [na:1.8.0_74]
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(Unknown Source) [na:1.8.0_74]
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(Unknown Source) [na:1.8.0_74]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) [na:1.8.0_74]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) [na:1.8.0_74]
        at java.lang.Thread.run(Unknown Source) [na:1.8.0_74]

@mmullerbrhttps://github.com/mmullerbr - The standard docker pattern is to create a docker-compose.override.yml and change/define whatever you want there.  This will change what is defined in the config file after you run docker compose.
Here is the context of my file that I used for testing:
hygieia-github-scm-collector:
environment:

GITHUB_HOST=github.comhttp://github.com
GITHUB_CRON=0 * * * * *
GITHUB_COMMIT_THRESHOLD_DAYS=300
hygieia-jira-feature-collector:
environment:
DEBUG=1
JIRA_BASE_URL=https://iconsmartech.atlassian.net/http://atlassian.net/
JIRA_CREDENTIALS=XXXXXXXXXXXX
JIRA_ISSUE_TYPE_ID=10200
JIRA_SPRINT_DATA_FIELD_NAME=customfield_10007
JIRA_EPIC_FIELD_NAME=customfield_10008
hygieia-jenkins-build-collector:
environment:

- DEBUG=1

JENKINS_CRON=0 * * * * *
JENKINS_MASTER=http://<IP_ADDRESS>:9100
JENKINS_USERNAME=XXXXXXXXXXXX
JENKINS_API_KEY=XXXXXXXXXXXXX
hygieia-jenkins-cucumber-test-collector:
environment:
JENKINS_CRON=0 * * * * *
JENKINS_MASTER=http://<IP_ADDRESS>:9100
JENKINS_USERNAME=jaz
JENKINS_API_KEY=7f3dfa31d581b3455413d546c825954b
JENKINS_CUCUMBER_JSON_FILENAME=cucumber-report.json

ports:
- "62911:62911"
- "1898:1898"
hygieia-sonar-codequality-collector:
environment:

SONAR_URL=http://<IP_ADDRESS>:9000
SONAR_CRON=0 * * * * *

On Jun 3, 2016, at 6:59 AM, Arnold Pelka <notifications<EMAIL_ADDRESS>wrote:
@MarkRxhttps://github.com/MarkRx : Did you receive this NullPointerException with the newest version on upstream master? I ask because issues related to the proxy configuration were fixed in a previous issue/PR (#322https://github.com/capitalone/Hygieia/pull/322)
@mmullerbrhttps://github.com/mmullerbr : There is, in fact, a different way to pass in the property file for Hygieia. You may use the Docker -v [dockerhost dir]:[dockercontainer dir] to volume map to a local property file configuration from within the Docker container; more details can be found on the Docker official content page: Volume Mappinghttps://docs.docker.com/engine/userguide/containers/dockervolumes/. Additionally, you may have to force a different CMD run option for the Docker container, so that it knows where to find your application.properties file; this can be done by adding a new java command at run time at the end of the docker run command: java -jar jira-feature-collector.jar --spring.config.location=hygieia-jira-feature-collector-new.properties. Please see below for a sample command / setup:
#!/bin/bash
docker run -d -p 8080:8080 -v $SRC_DIR/hygieia-jira-feature-collector-new.properties:$DOCKER_CNTR_DIR/hygieia-jira-feature-collector-new.properties $HYGIEIA_DOCKER_IMAGE_TAG:latest kill $(pgrep -o java) && java -jar jira-feature-collector.jar --spring.config.location=$DOCKER_CNTR_DIR/hygieia-jira-feature-collector-new.properties
@jimzuckerhttps://github.com/jimzucker : Please verify my above statements and make corrections as needed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/capitalone/Hygieia/issues/610#issuecomment-223586056, or mute the threadhttps://github.com/notifications/unsubscribe/ANtPTzPSwlrCWHity26-uG8pBhbV6uihks5qIDM7gaJpZM4Irnpk.

@MarkRx , Thank you for following up with the stack trace, and thank you @jimzucker for the Docker compose expertise.
It seems that you are receiving the error likely because the proxy setting variables are, in fact null, not blank.  the line of code affected here is this:  https://github.com/capitalone/Hygieia/blob/master/jira-feature-collector/src/main/java/com/capitalone/dashboard/client/team/TeamDataClientSetupImpl.java#L85.  I will check this on my next commit and submit a PR if needed.  For now, setting proxy to blank.  i.e.:
feature.jiraProxyUrl=
feature.jiraProxyPort=

... should do the trick.  Let me know if you are still seeing odd behavior.

@jimzucker, the jira-properties-builder.sh is not prepared to receive and replace field mapping parameters in the properties file. I was able to modify it and get the collector up and running with the properties file presented below. However I will loose my changes every time a container recreation is needed - this is a problem for another day... :)
Unfortunately my dash board remains not presenting sprints and tasks information. Any other thoughts?
#Database
database=dashboard
dbhost=<IP_ADDRESS>
dbport=27017
dbusername=db
dbpassword=dbpass
feature.cron=0 * * * * *
feature.pageSize=100
feature.queryFolder=jiraapi-queries
feature.storyQuery=story
feature.epicQuery=epic
#Jira Connection Details
feature.jiraProxyUrl=
feature.jiraProxyPort=
feature.jiraBaseUrl=https://myJira.atlassian.net/
feature.jiraQueryEndpoint=rest/api/2/
feature.jiraCredentials=asasasasasasasa
#OAuth2.0 token credentials (currently not supported in this version)
feature.jiraOauthAuthtoken=
feature.jiraOauthRefreshtoken=
feature.jiraOauthRedirecturi=
feature.jiraOauthExpiretime=
feature.deltaCollectorItemStartDate=2016-01-01T00:00:00.000000
feature.deltaStartDate=2016-01-01T00:00:00.000000
feature.masterStartDate=2016-01-01T00:00:00.000000
feature.jiraIssueTypeId=Story
feature.jiraSprintDataFieldName=customfield_10017
feature.jiraEpicIdFieldName=customfield_10018
feature.todoStatuses[0]=To Do
feature.doingStatuses[0]=In Progress
feature.doneStatuses[0]=Done
#[{...name:"In Progress"...},{... name: "Done" ...},{... name: "To Do" ...}]

@mmullerbr I am not clear on the problem can you give me a simple example?

@mmullerbr , At this point, I will need some stack traces and/or UI console logs for further debug, as your property configurations appear correct at face-value.  Please provide those at your convenience.

Closed. Reopen if there are any problems. Use latest codebase and follow cleanup instructions provided in https://github.com/capitalone/Hygieia/pull/1137.


Merge riak debug fixes from 2.0 [RIAK-2314]

Fixes for riak-debug on solaris 10 - RIAK-2314.

Did not merge release notes as merging them using git/mergetool is horrible.

@kesslerm has +1ed in Hipchat - going to merge.


Changed all window titles to use the full app version string

Description

Replace "Chatterino" with Version::instance().fullVersion() in various window titles.
Fixes #4458.

4 other positions that might need to be changed
https://github.com/Chatterino/chatterino2/blob/168f346c81e0760ea2d5049ae154839073c8565b/src/common/Args.cpp#L22
https://github.com/Chatterino/chatterino2/blob/168f346c81e0760ea2d5049ae154839073c8565b/src/widgets/dialogs/ColorPickerDialog.cpp#L284
https://github.com/Chatterino/chatterino2/blob/168f346c81e0760ea2d5049ae154839073c8565b/src/widgets/Notebook.cpp#L500
https://github.com/Chatterino/chatterino2/blob/168f346c81e0760ea2d5049ae154839073c8565b/src/providers/liveupdates/BasicPubSubManager.hpp#L90-L94

I'm leaving the Args one and http User-Agent ones.

In-app these changes look very bad (window titles are too long and sometimes truncated).
My suggestion is to completely remove the version from the title as it is already present in the add new account window or in the Searching in channel window. The settings window itself looks fine.
Example: Instead of Chatterino Nightly 2.4.4 - streamlink not found just use streamlink not found as title.
What is your opinion?

Example: Instead of Chatterino Nightly 2.4.4 - streamlink not found just use streamlink not found as title.

Just noticed that a lot of software puts the product/version at the end of the title, so this should be Streamlink Not Found - Chatterino Nightly 2.4.4. Also, the titles should be in title-case.

I will make it the other way around to make truncation lose less important information

What's the point of cluttering every window title with the full version?
Simple short titles are much better, in my opinion, like add new account, that's what the user interests.
Besides, most windows are not big enough to display the full title anyway.


sim_control prototype

Here's a follow up from https://github.com/ApolloAuto/apollo/pull/11556.

Why we want to make this change?

Why we want to make this change?

This MR addresses https://github.com/ApolloAuto/apollo/issues/9321. It is meant to separate simulation logic from visualization backend. Once separated, this module could be used in isolation. For example, it allows for integration tests around planning and routing without a frontend.

Why we want to make this change?

This MR addresses #9321. It is meant to separate simulation logic from visualization backend. Once separated, this module could be used in isolation. For example, it allows for integration tests around planning and routing without a frontend.

ok, thanks.

Observed several issues when trying the new sim_control prototype:

Dreamview shows the following message when sim_control module is on. Any idea why @xiaoxq @Capri2014 ?

data/log/sim_control.INFO keeps printing the following errors:
E0826 16:15:31.122936 18703 sim_control_component.cc:325] Failed to calculate next point with perfect control model
E0826 16:15:31.132977 18701 sim_control_component.cc:361] First trajectory point is a future point!
even though ego-car can follow the route, it doesn't go forward smoothly, seems like the car is being dragged backward a little bit every sec.

For 2 and 3 I will bet on the time sequence mismatch, but can only verify if having a record. For 1, usually when it triggered the safetyMode it also recorded the detailed reasons, what is in it?

This pr has opened so long, maybe should be closed. you cloud reopen if necessary:)


New Contribution

Contributor: phatpigeon
SSH Public key: ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIB0JjZCB9r3BUq/0aOIDb4FHH/RJoQLVqfShXAFV4I3k
Attestation: [any form of attestation for contribution (e.g., signature) - Optional]

started

how do i resolve this ?:
[2024-06-10T09:18:53Z INFO  ceremony::check] > SRS Check #1 Succeded: srs uses hardcoded group generators
[2024-06-10T09:18:53Z INFO  ceremony::check] > SRS Check #2 Succeded: g2 and s_g2 have order r
[2024-06-10T09:18:53Z INFO  ceremony::check] > SRS Check #3 Succeded: the g vector has expected size
Killed

ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIB0JjZCB9r3BUq/0aOIDb4FHH/RJoQLVqfShXAFV4I3k


Tipping Resets Without Giving Tip

If you don't use the tip command like 100% correctly it won't tip the user (gives red x reaction y'know) but it still resets your cooldown. For example, if instead of @ ing the user you just type their username, or if you do the @ and it just..  doesn't @, the tip won't go through but it resets your cooldown. I also believe it does this if you simply put ~tip but it's been awhile since I last did that so I can't be 100% sure.

Updated, should only add cooldown if initial parameters are met

Should be resolved now, only once parameters are met and tip is given will the command go on cooldown


Segmentation fault (core dumped)

Hi:
I have install the environment now, but I have met an error. I use one GPU in the .yaml file. I have met the following error.

Segmentation fault (core dumped)
Have you ever met this error?
Best.

Can you report the error?

@X-Lai
Hi, This is my error. Thanks.
srun -p RTXA6Kq -n 1 -w node12 python train.py --config config/s3dis/s3dis_stratified_transformer.yaml
srun: error: node12: task 0: Segmentation fault (core dumped)

It seems that the error comes from srun. I am not sure whether it is caused by the python task. Can you see which line of the python code causes this error?

@X-Lai
No error line. When I run the command, this error occurs.

@X-Lai
Both the s3dis_stratified_transformer.yaml and s3dis_swin3d_transformer.yaml meet the "Segmentation fault" error when starting to run.

@X-Lai
I use srun because I run the code on a gpu cluster. My other programs can run with srun command, but when running your code this error occurs. I have no idea to solve this problem.

It seems the error does not come from the codes, since the code works on my side. It is hard to figure out where the error comes without any detailed error message.

@X-Lai
Hi, what GPU resource are you using?

@X-Lai
It seems that this error doesn't run within the python code.

@X-Lai
I have printed line by line, it seems that the error occurs with util.voxelize.py  from torch_geometric.nn import voxel_grid.
I have checked the version of torch_geometric, it is torch-geometric         1.7.2.

The version of torch-geometric is correct.

it seems you the torch-geometric haven't been installed successfully
>>> import torch_geometric
Segmentation fault


Update formatting-a-csv.md

Grammatical and formatting fixes
Description of the change:
Reason for the change:
Link to original source:

Closes #

Hello @xtineledlie,Thanks again for the PR! We appreciate your contribution and look forward to                                              continued collaboration. Thanks!                                             Team SendGrid DX


@conda-forge-admin, please add user @mxr-conda

[ ] I read the conda-forge documentation and could not find the solution for my problem there.

Issue:

Environment (conda list):

$ conda list

Details about  conda and system ( conda info ):

$ conda info

Hi! This is the friendly automated conda-forge-webservice.
I tried to added user @mxr-conda as requested, but the recipe already has maintainer @mxr-conda so no changes were made.


post webpage url with all locations?

does the repo have info for url as shown in the tutorial (i.e., global figure with markers)?

data.agu.org/open-ocean-science/
Found it


Access WriteStream of fs during runtime instead of include time

This adds compatibility with mock-fs, which overrides these methods and expects modules to access them thereafter. This is merely a suggestion, as I don't know if you support making changes in order to support such things. However, I find the mock-fs module to be incredibly useful and would love to have it supported.

See https://github.com/felixge/node-formidable/issues/412


Support Cabal <IP_ADDRESS>

Recently Cabal <IP_ADDRESS> and cabal-install <IP_ADDRESS> was released, bringing along the following relevant changes I could find:

Deprecation of old symbols in https://github.com/haskell/cabal/pull/6022
This change is relevant because the version of cabal-helper HIE is using still references these old symbols. upstream cabal-helper doesn't reference them anymore.
New-style builds are now the default, meaning cabal configure is not using old-style builds anymore. This is a problem because both cabal-helper and ghc-mod have the assumption that old-style builds are the default in that they use cabal configure and such, and not cabal v1-configure.
Relevant code in ghc-mod: https://github.com/alanz/ghc-mod/blob/910887b2c33237b703417ec07f35ca8bbf35d729/core/GhcMod/CabalHelper.hs#L192-L197.
Relevant code in cabal-helper: https://github.com/alanz/cabal-helper/blob/eafed5e8c1d82b8daa35775b52361132f2e70261/src/CabalHelper/Compiletime/Compile.hs#L452

As far as I can see, this results in HIE being broken for everybody using Cabal <IP_ADDRESS>
Possible solutions

Patch ghc-mod and cabal-helper to use v1- commands explicitly
One of

Patch cabal-helper to not use the deprecated symbols anymore, by looking at what upstream cabal-helper did to remove them. This might be simple or it might not be simple at all
Update cabal-helper to the upstream version, this is what https://github.com/haskell/haskell-ide-engine/pull/1245 tries to do, but there seems to be some problems
I also think hie-bios by @mpickering would solve this, though this doesn't look like it's going to be merged quickly

Ping @fendor @bubba @alanz @mpickering @DanielG
Related issues:

https://github.com/Infinisil/all-hies/issues/22
https://github.com/haskell/haskell-ide-engine/issues/1373
https://github.com/NixOS/nixpkgs/issues/67761

I'm afraid it still does not work with the current master:
$ cabal v2-run ./install.hs --project-file install/shake.project hie-8.6.5
Resolving dependencies...
Build profile: -w ghc-8.6.5 -O1
In order, the following will be built (use -v for more details):
 - fake-package-0 (exe:script) (configuration changed)
Configuring executable 'script' for fake-package-0..
Preprocessing executable 'script' for fake-package-0..
Building executable 'script' for fake-package-0..
[1 of 1] Compiling Main             ( Main.hs, /Users/ur20980/src/haskell-ide-engine/dist-newstyle/build/x86_64-osx/ghc-8.6.5/fake-package-0/x/script/build/script/script-tmp/Main.dyn_o )
Linking /Users/ur20980/src/haskell-ide-engine/dist-newstyle/build/x86_64-osx/ghc-8.6.5/fake-package-0/x/script/build/script/script ...
. . . . .
Installing   cabal-install-<IP_ADDRESS> (all, legacy fallback)
Completed    cabal-install-<IP_ADDRESS> (all, legacy fallback)
Symlinking 'hie'
Warning: Failed to build documentation for haddock-api-2.22.0 (which is
required by exe:hie-wrapper from haskell-ide-engine-<IP_ADDRESS> and exe:hie from
haskell-ide-engine-<IP_ADDRESS>).
Symlinking 'hie-wrapper'
Error when running Shake build system:
  at want, called at src/Development/Shake/Internal/Args.hs:81:69 in shk-0.17.8-b3e20d9c:Development.Shake.Internal.Args
* Depends on: hie-8.6.5
  at need, called at src/HieInstall.hs:90:37 in hie-install-<IP_ADDRESS>-inplace:HieInstall
* Depends on: cabal-hie-8.6.5
* Raised the exception:
/Users/ur20980/.local/bin/hie: copyFile:atomicCopyFileContents:withReplacementFile:copyFileToHandle:openBinaryFile: does not exist (No such file or directory)

Here's the full output:  cabal-v2-fail.txt
Before you ask - stack fails to build hie too:
$ stack -v ./install.hs hie-8.6.5 2>&1 | tee ~/stack-fail.txt

--  While building package hie-install-<IP_ADDRESS> using:
      /Users/ur20980/.stack/setup-exe-cache/x86_64-osx/Cabal-simple_mPHDZzAJ_<IP_ADDRESS>_ghc-8.6.5 --builddir=.stack-work/dist/x86_64-osx/Cabal-<IP_ADDRESS> build lib:hie-install --ghc-options ""
    Process exited with code: ExitFailure 1
$
$ /Users/ur20980/.stack/setup-exe-cache/x86_64-osx/Cabal-simple_mPHDZzAJ_<IP_ADDRESS>_ghc-8.6.5 --version
Cabal library version <IP_ADDRESS>
$

Versions:

MacOS 10.14.6
GHC-8.6.5 installed via current ghcup
Cabal-<IP_ADDRESS>
-Stack-2.1.3

$ ghc --version
The Glorious Glasgow Haskell Compilation System, version 8.6.5
$ cabal --version
cabal-install version <IP_ADDRESS>
compiled using version <IP_ADDRESS> of the Cabal library
$ stack --version
Version 2.1.3, Git revision 0fa51b9925decd937e4a993ad90cb686f88fa282 (7739 commits) x86_64 hpack-0.31.2
$ uname -a
Darwin xxxxxx 18.7.0 Darwin Kernel Version 18.7.0: Thu Jun 20 18:42:21 PDT 2019; root:xnu-4903.270.47~4/RELEASE_X86_64 x86_64
$

Current master does not supprot Cabal <IP_ADDRESS>.
However, the hie-bios branch does support Cabal <IP_ADDRESS>.
The current efforts to merge hie-bios into master are located in merge-hie-bios and will be merged as soon as regressions and tests work.

What would you recommend me to do? Pull a different branch?

Yes, please different issue. It may be stack and MacOS specific.

@mouse07410 see https://gitlab.haskell.org/ghc/ghc/issues/15769

We are supporting Cabal <IP_ADDRESS> from #1126 on!


[QUESTION] Multipart File

Please describe a problem.
Hi! I'm creating avatar uploader and I can't find anywhere solution or example how to convert file. Could I ask you how to convert my http.MultipartFile / File to List of Strings to send it?

@biongoo could you please share swagger file?

I will show that on public example: https://github.com/epam-cross-platform-lab/swagger-dart-code-generator/blob/master/example/lib/swagger_generated_code/pet_service_json.swagger.dart#L199. There is method "petPetIdUploadImagePost" and it has param "List? file,". I have file in type "File" or could have in type "http.MultipartFile" but how can I convert this to "List" to use that method?

I have the same problem. When is used multipart/form-data, last version of swagger-dart-code-generator generates for it object body with string field. And probably send it as simple json.

Hi @biongoo  @malaschitz , I'm not sure how to send image with multipart body. Possible, our generator generated body incorrectly. I will research, how to do this, fix generator and let you know

Hi all, @malaschitz , @biongoo !
I've checked how such fields should be generated, and looks like good option to generate List<int>, like described in this tipic. List<int> can be easely converted to and from Utf8List. Let me know in case of questions.


If the placeholder is a long string it can't be read entirely

⚠ Please verify that this bug has NOT been raised before.

[X] I checked and didn't find similar issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

Description
When adding a monitor if have a long string as placeholder (eg. Microsoft SQL Server) it cannot be scrolled until the end.
To read all the placeholder i must zoom out in the browser.
👟 Reproduction steps
Add new monitor -> Microsoft SQL Server
👀 Expected behavior
Use left and right arrow keys to scroll all the placeholder text.
😓 Actual Behavior
Using left/right arrow keys do nothing.
🐻 Uptime-Kuma Version
1.19.4
💻 Operating System and Arch
Windows Server 2019
🌐 Browser
Firefox 109.0
🐋 Docker Version
No response
🟩 NodeJS Version
16.14.2
📝 Relevant log output
No response

Yes, I think all database types are having this issue. Change to a description will be better.

Hello @louislam, pushed a workaround to this problem, you can check it out.

Resolved by https://github.com/louislam/uptime-kuma/commit/22f730499f6e83c4eae048763654322bc8a5caf4


Correct homepage in package.json

The current homepage results in a 404. This switches the homepage to be the same page as the repository information.

Thanks man


Implementing .aar libraries for extensions.

With this implementation it is possible to add an .aar type library in extension. Just use the existing annotation "@UsesLibraries (libraries ="library.aar ") and add the library to the dependencies, just like the .jar files.

Can one of the admins verify this patch?

@AppInventorWorkerBee ok to test

Can this change get staged for nb185?

@ShreyashSaitwal This won't go into nb185. We could consider it for nb186. The goal with nb185 is first and foremost to fix issues that cropped up in nb184.

We need to implement this so that we can solve the problem of building this extension: https://community.kodular.io/t/suggestion-for-building-an-extension/77477/15
Please add this in the next update🙏

Como usar a extensão para checar CNPJ?
Vi que foi incluído o trecho de tratamento para CNPJ entretanto não consigo a verificação. Está apenas para CPF mesmo?.
Muito bom o seu trabalho. Parabéns

Will the resources contained in the aar end up in the application ?  (as expected)

Note: I am using this patch on my compilation server, it works, I hope you will integrate it soon.

Note: I am using this patch on my compilation server, it works, I hope you will integrate it soon.

@ewpatton Any news regarding aar support ?

Any update on this project?


Rubocop: Turn on and address failures for Metrics/AbcSize

Description
One of the aspects of our codebase that makes it difficult to iterate on is the complexity of our methods. Rubocop provides a category of linters to identify complex areas of code. These linters are currently all disabled for the Ruby agent's codebase. Let's start enabling them with Metrics/AbcSize.
Link to Documentation for Metrics/AbcSize
Update:
Some progress has been made throughout the codebase (a focus on lib/*)with PR #1447
Acceptance Criteria

Rubocop Metrics/AbcSize is enabled for the lib directory and passes for all files

Design Consideration/Limitations

There are over 100 violations of this rule in our codebase
This might be a good task to have the whole team work on in tandem
If we work on this task in tandem, we'll need to devise a way to avoid stepping on each other's toes

Dependencies
None
Additional context

Rubocop todo files for this linter could be created and addressed on a smaller scale

Estimates
L

We had multiple devs working on this extensively recently. See all related closed PRs. Closing out the issue to produce a tangible chunk of work with a cut-off point. The remaining work is now obvious with the updates made to the .rubocop_todo.yml file, which has been updated to not only indicate the outstanding issues but also to prioritize work done outside of the test/ directory.


test: add contract interaction verify attestation test

Overview

Checklist

[ ] New and updated code has appropriate documentation
[ ] New and updated code has new and/or updated testing
[ ] Required CI checks are passing
[ ] Visual proof for any user facing features like CLI or documentation updates
[ ] Linked issues closed with keywords

what's the status of this PR? apologies for missing this review, I'll dig in first thing tmrw

Thanks. It's an optional PR, it just adds a test to the qgb-integration branch that we're deprecating. So, we can close it without merging or merge it without the CI passing, doesn't matter in my opinion

ahh I see, ok sounds good. lets merge just to save it


Minor Updates (n_train/val as percent, pre-commit, restart handling, warnings)

Description & Motivation and Context
This PR implements some minor updates to the code:

n_train/n_val can now be set as percentage strings. The behaviour of this is shown in the _parse_n_train_n_val function; in short, the floored int corresponding to the chosen percent is taken, and if the percent coverage sums to 100% but the flooring results in one frame being omitted, that n_train/n_val is increased by 1. e.g. for the test case of 8 frames in the full dataset, n_train = 70% = 5.6 frames, n_val = 30% = 2.4 frames, so final n_train is 6 and n_val is 2. Tests added for this, and example shown in full.yaml config. Also tested on HPCs.

Pre-commit fix (flake8 no longer on Gitlab) and formatting

In train.py, only attempt a restart when trainer.pth is present, not if the results folder exists (e.g. if training crashed during first epoch, during data loading (due to memory...), hitting walltime etc before model saved) – had a few different runs crash because of this.

Avoids an unnecessary and verbose e3nn JIT warning in nequip-train outputs

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds or improves functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation improvement (updates to user guides, docstrings, or developer docs)

Checklist:

[x] My code follows the code style of this project and has been formatted using black.
[x] All new and existing tests passed, including on GPU (if relevant).
[x] I have added tests that cover my changes (if relevant).
[ ] The option documentation (docs/options) has been updated with new or changed options. – I don't see this?
[x] I have updated CHANGELOG.md.
[ ] I have updated the documentation (if relevant).

@Linux-cpp-lisp one minor thing to flag (doesn't really matter now, just for whenever the next release is I guess).
For the changelog, it says it adheres to semantic versioning, which I think would make the next version 0.7.0 as functionality has been / is being added from this and other PRs. Just didn't want to change myself without checking as you may have other reasons for this!

@Linux-cpp-lisp I'm not totally sure what's causing the 2 test failures here. They all pass locally.
This seems to be the main issue for at least one of them:
self = CompletedProcess(args=['nequip-train', 'conf.yaml', '--warn-unused'], returncode=1, stdout=b'', stderr=b'/opt/hostedto...ate\n    raise RuntimeError(\nRuntimeError: Failed to build object with prefix `dataset` using builder `NpzDataset`\n')

    def check_returncode(self):
        """Raise CalledProcessError if the exit code is non-zero."""
        if self.returncode:
>           raise CalledProcessError(self.returncode, self.args, self.stdout,
                                     self.stderr)
E           subprocess.CalledProcessError: Command '['nequip-train', 'conf.yaml', '--warn-unused']' returned non-zero exit status 1.

/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/subprocess.py:4[60](https://github.com/mir-group/nequip/actions/runs/9699603663/job/26768963349?pr=438#step:7:61): CalledProcessError
---------------------------- Captured stderr setup -----------------------------
/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/nequip/utils/_global_options.py:95: UserWarning: Do NOT manually set PYTORCH_JIT_USE_NNC_NOT_NVFUSER=0 unless you know exactly what you're doing!
  warnings.warn(
Torch device: cpu
Using existing file aspirin_ccsd.zip
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.9.19/x[64](https://github.com/mir-group/nequip/actions/runs/9699603663/job/26768963349?pr=438#step:7:65)/lib/python3.9/site-packages/nequip/utils/auto_init.py", line 243, in instantiate
    instance = builder(**positional_args, **final_optional_args)
  File "/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/nequip/data/_dataset/_npz_dataset.py", line 81, in __init__
    super().__init__(
  File "/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/nequip/data/_dataset/_base_datasets.py", line 152, in __init__
    super().__init__(root=root, type_mapper=type_mapper)
  File "/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/nequip/data/_dataset/_base_datasets.py", line 43, in __init__
    super().__init__(root=root, transform=type_mapper)
  File "/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/nequip/utils/torch_geometric/dataset.py", line 88, in __init__
    self._download()
  File "/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/nequip/utils/torch_geometric/dataset.py", line 149, in _download
    self.download()
  File "/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/nequip/data/_dataset/_base_datasets.py", line 197, in download
    extract_zip(download_path, self.raw_dir)
  File "/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/nequip/utils/torch_geometric/utils.py", line 55, in extract_zip
    f.extractall(folder)
  File "/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/zipfile.py", line 1[65](https://github.com/mir-group/nequip/actions/runs/9699603663/job/26768963349?pr=438#step:7:66)4, in extractall
    self._extract_member(zipinfo, path, pwd)
  File "/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/zipfile.py", line 1704, in _extract_member
    os.mkdir(targetpath)
FileExistsError: [Errno 17] File exists: '/home/runner/work/nequip/nequip/benchmark_data/__MACOSX'

But not sure where the __MACOSX folder is coming from as the tests run on ubuntu and I don't see this in the test data zip file online

@kavanase  re semantic versioning, good catch on the CHANGELOG.  I've been sticking to a sort of "almost" semantic versioning where the middle digit gets incremented for backwards compatibility-breaking releases, and the final for other releases.  We should discuss whether this should be changed.

@kavanase re the failed test, I believe this occurs due to a race condition: the tests on GitHub actions are run in parallel on two (if I remember right) workers, and if they both try to unzip the downloaded data at the same time (instead of one first and the other using the cache) this can occur.  It should self resolve, I think the first time it came up it just wasn't worth dealing with since re-running the tests usually resolves it by chance.

@Linux-cpp-lisp ok cool!
For the failed test, was thinking it was something like that.
For the semantic versioning, that makes sense, though I think it differs a bit from the standard semver format (where compatiblity-breaking changes are meant for MAJOR versions).

Given a version number MAJOR.MINOR.PATCH, increment the:
MAJOR version when you make incompatible API changes
MINOR version when you add functionality in a backward compatible manner
PATCH version when you make backward compatible bug fixes

Tbh it's probably a fairly minor point and I don't think one has to stick to a given format, but I guess best to update the "this project adheres to Semantic Versioning" (2.0.0) statement in the CHANGELOG if using a different format, or swap to using it's format?

@Linux-cpp-lisp I think all the remaining issues with this have now been addressed


[Idea Plugin] Description message for json type when used in json:getString (json json, string jsonPath) should change

Currently as shown in the image, the pop up is giving a message without much meaning to the user. It has to be changed to a meaningful message, that indicates the actual usage.

This is due to using a Ballerina keyword as an variable name. Errors are thrown from ANTLR. So actual error might not be identified and shown in the intellij. Will check whether the error messages can be improved.


No valid cgroup base path found

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
I am deploying Cilium on a Talos Linux v1.4.4 based cluster in kube-proxy free mode as follows:
$ helm install cilium cilium/cilium \
  --version 1.13.4 \
  --namespace kube-system \
  --set ipam.mode=kubernetes \
  --set=kubeProxyReplacement=strict \
  --set=tunnel="disabled" \
  --set=ipv4NativeRoutingCIDR="<IP_ADDRESS>/16"
  --set=securityContext.capabilities.ciliumAgent="{CHOWN,KILL,NET_ADMIN,NET_RAW,IPC_LOCK,SYS_ADMIN,SYS_RESOURCE,DAC_OVERRIDE,FOWNER,SETGID,SETUID}" \
  --set=securityContext.capabilities.cleanCiliumState="{NET_ADMIN,SYS_ADMIN,SYS_RESOURCE}" \
  --set=cgroup.autoMount.enabled=false \
  --set=cgroup.hostRoot=/sys/fs/cgroup \
  --set=k8sServiceHost="<IP_ADDRESS>" \
  --set=k8sServicePort="6443"

The cgroup related settings come from the Talos Linux docs (https://www.talos.dev/v1.4/kubernetes-guides/network/deploying-cilium/#method-1-helm-install) and are mentioned also here: https://github.com/cilium/cilium/issues/21603#issuecomment-1453753820
The Cilium agent on all cluster nodes logs this warning during startup:
No valid cgroup base path found: socket load-balancing tracing with Hubble will not work.See the kubeproxy-free guide for more details.

According to https://docs.cilium.io/en/stable/network/kubernetes/kubeproxy-free/#observability this should not happen and should be reported.
I do not have the ability to run crictl, but here's what I can see inside one of the Cilium agent pods:
$ kubectl -n kube-system exec cilium-xcrpf -c cilium-agent -- find /sys/fs/cgroup/ -name pod*
/sys/fs/cgroup/kubepods/burstable/pod223e8377-dea2-4501-9eb2-224364fb45b7
/sys/fs/cgroup/kubepods/burstable/podeb41e277-d0b7-4b8d-a0d7-52c7afdff139
/sys/fs/cgroup/kubepods/burstable/pod4b5cbcf8-c8fe-4402-9c95-3b456078ecb2
/sys/fs/cgroup/kubepods/burstable/pod474a5505-f9eb-45be-af7c-b8f6afb78fa5
/sys/fs/cgroup/kubepods/besteffort/pod0ff1de47-b7e1-4693-adcd-3f0b48b297b6
/sys/fs/cgroup/podruntime

I would be happy to provide any additional information.
Cilium Version
cilium-cli: v0.14.7 compiled with go1.20.4 on linux/amd64
cilium image (default): v1.13.3
cilium image (stable): v1.13.4
cilium image (running): v1.13.4
Kernel Version
v6.1.28
Kubernetes Version
v1.27.1
Sysdump
cilium-sysdump-20230620-071311.zip
Relevant log output
level=warning msg="No valid cgroup base path found: socket load-balancing tracing with Hubble will not work.See the kubeproxy-free guide for more details." subsys=cgroup-manager

Anything else?
The same issue was present on Cilium v1.13.3.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Cc @aditighag


Denoify

I might still your idea of gathering all dependencies in a single deps.ts in denoify. It is very neat,  I hope you don't mind.
If you are interested I can let you push the commit so the feature is attributed to you?

Hey, thanks for telling me!
Don't worry about the attribution, I'm happy to "inspire" to other projects 😄

Thanks for your work. You rocks


Roll engine 1cada0a6dca6..f15cc3402938 (1 commits)

git@github.com:flutter/engine.git/compare/1cada0a6dca6...f15cc3402938
git log 1cada0a6dca6..f15cc3402938 --no-merges --oneline
2019-09-19<EMAIL_ADDRESS>Roll src/third_party/skia 18531cde2ab7..9a8b846baf43 (1 commits) (flutter/engine#12360)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/4613521855217664 , https://cirrus-ci.com/task/6654215436369920 , https://cirrus-ci.com/task/5528315529527296

Commit queue failed; closing this roll.


[TimePicker] Expose two TimePickerDialog style props

As a possible workaround for https://github.com/callemall/material-ui/issues/1261, allow people to set the TimePicker's Dialog body style. In particular, setting it's overflow to 'auto' will bring up a scroll bar for small screens.
With this change in place you can just do the following to get scroll bars on small screens:
<TimePicker
    dialogBodyStyle={{overflowY: 'auto'}}
/>

[x] PR has tests / docs demo, and is linted.
[x] Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
[x] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@oliviertassinari TimePicker's removed from the prop comments.

@nathantalewis That looks good to me. Could you squash down the commits?

@oliviertassinari Commits squashed. :+1:


Added Val::ZERO Constant

Objective

Fixes #9533

Solution

Added Val::ZERO as a constant which is defined as Val::Px(0.).
Added manual PartialEq implementation for Val which allows any zero value to equal any other zero value. E.g., Val::Px(0.) == Val::Percent(0.) etc. This is technically a breaking change, as Val::Px(0.) == Val::Percent(0.) now equals true instead of false (as an example)
Replaced instances of Val::Px(0.), Val::Percent(0.), etc. with Val::ZERO
Fixed bevy_ui::layout::convert::tests::test_convert_from test to account for Taffy not equating Points(0.) and Percent(0.). These tests now use assert_eq!(...) instead of assert!(matches!(...)) which gives easier to diagnose error messages.

CI Issues will be resolved by #9562

@jim-ec, want to toss a review on this for us? :)

Looks good to me.


Need to find way to log with a unique set of fields

I'm passing a slog::Logger around my code which contains a set of standard fields, including one for "subsystem". However, I've noticed that the slog fields are stored in a list. This is a problem for me because as I create new loggers from the parent one...
// existing_logger also contains a "subsystem" field
let logger = existing_logger.new(o!("subsystem" => "new"));

the log records from the new logger end up with multiple "subsystem" fields (one from the parent and one from the child). Is there an easy way to resolve this? I spotted the list() method, but it's not iterable and since there is no way that I can see to replace log fields, I'd need to use that list to create a new root logger (but that doesn't seem to be the correct approach?)
ftr, I'm using slog + slog_json crates.

You either have to pass yourself a logger without the subsystem key, or somehow implement custom removal of old value. Technically the list of list of values could be traversed, and the it could be possible to recover the partial list from Logger, but that is currently not implemented (at least I'm not aware of apis that would allow that). You could dig into internals and see if you can make it happen via some API, if you really need it.

You could also implement your own Logger type, encapsulating the slog::Logger, with the same API, so all the macros still work. And then add a method that returns some previous recorded intermediate Logger without that key. slog::Loggers are very tiny, so it wouldn't hurt the performance or anything.

Hi @dpc - thanks for the ideas! Since subsystem-b may get passed a logger from subsystem-a I don't think I can arrange for the subsystem field to be absent for subsystem-b easily.
I like the sound of implementing the custom Logger but I'm not entirely sure at this stage I follow how this would work. I'm assuming I'd need to implement:
pub fn root<T>(drain: D, values: OwnedKV<T>) -> MyLogger

Where MyLogger looks something like:
pub struct MyLogger {
    logger: slog::Logger,

    // key/value fields, including "subsystem"
    fields: HashMap<String, String>,
}

But wouldn't I also need to save the drain in MyLogger to allow me to force MyLogger::log() to call Mylogger.drain.log(record, values) ?

pub struct MyLogger {
    logger: slog::Logger,
  logger_without_subsystem: slog::Logger,
}

imp MyLogger {
    fn log(...); // the same signature as on normal `slog::Logger`
}

That code has now moved, so for anyone who wants to see the custom slog Drain, it's now here:

https://github.com/kata-containers/kata-containers/blob/master/src/agent/logging/src/lib.rs

@jodh-intel Thanks a lot for sharing it!
By the look of it, and the right observation here:
https://github.com/kata-containers/kata-containers/blob/22afde185051435680c7fa93390af044e75782ef/src/agent/logging/src/lib.rs#L61
It seems to me that the serializer could avoid HashMap and possibly only keep a HashSet of already serialized keys, write out everything to a destination direclty, and avoid serializing older KVs altogether, which might have much better performance.
Just a thought though. Especially with slog-async, it will probably not matter too much.


[SPARK-48104][INFRA] Run publish_snapshot.yml once per day

What changes were proposed in this pull request?
This PR aims to reduce publish_snapshot.yml frequency from twice per day to once per day.
Technically, this is a revert of

#45686

Why are the changes needed?
To reduce GitHub Action usage to meet ASF INFRA policy.

https://infra.apache.org/github-actions-policy.html

The average number of minutes a project uses in any consecutive five-day period MUST NOT exceed the equivalent of 30 full-time runners (216,000 minutes, or 3,600 hours).

Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual review.
Was this patch authored or co-authored using generative AI tooling?
No.

Could you review this, @yaooqinn ?

Thank you, @HyukjinKwon !