Can't get plantuml or mermaid to work

Am trying to put a docker image together that would always have the latest versions of all the tools that make up the I-D toolchain installed: https://github.com/larseggert/i-d-toolchain
As part of that, I made a short I-D that tries to execute all the different tools: https://github.com/larseggert/i-d-toolchain/blob/main/draft-i-d-toolchain-test.md
However, the plantuml and mermaid tests fail, and I don't know why?
The ~~ plantuml case fails with:
Traceback (most recent call last):
	14: from /usr/bin/kramdown-rfc2629:23:in `<main>'
	13: from /usr/bin/kramdown-rfc2629:23:in `load'
	12: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/bin/kramdown-rfc2629:398:in `<top (required)>'
	11: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-1.17.0/lib/kramdown/document.rb:117:in `method_missing'
	10: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-1.17.0/lib/kramdown/converter/base.rb:105:in `convert'
	 9: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:196:in `convert'
	 8: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:201:in `convert1'
	 7: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:957:in `convert_root'
	 6: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:213:in `inner'
	 5: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:206:in `inner_a'
	 4: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:206:in `map'
	 3: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:208:in `block in inner_a'
	 2: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:400:in `convert_codeblock'
	 1: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:301:in `memoize'
/usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:301:in `binread': No such file or directory @ rb_sysopen - .refcache/kdrfc-1_3_27-svg_tool_process-21c1b1b1e90827853ec99d7cc9cd3546ef018348.cache (Errno::ENOENT)
	16: from /usr/bin/kramdown-rfc2629:23:in `<main>'
	15: from /usr/bin/kramdown-rfc2629:23:in `load'
	14: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/bin/kramdown-rfc2629:398:in `<top (required)>'
	13: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-1.17.0/lib/kramdown/document.rb:117:in `method_missing'
	12: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-1.17.0/lib/kramdown/converter/base.rb:105:in `convert'
	11: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:196:in `convert'
	10: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:201:in `convert1'
	 9: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:957:in `convert_root'
	 8: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:213:in `inner'
	 7: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:206:in `inner_a'
	 6: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:206:in `map'
	 5: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:208:in `block in inner_a'
	 4: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:400:in `convert_codeblock'
	 3: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:300:in `memoize'
	 2: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:304:in `rescue in memoize'
	 1: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:304:in `call'
/usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:339:in `svg_tool_process': no implicit conversion of nil into String (TypeError)

The ~~~ mermaid case fails with:
Traceback (most recent call last):
	14: from /usr/bin/kramdown-rfc2629:23:in `<main>'
	13: from /usr/bin/kramdown-rfc2629:23:in `load'
	12: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/bin/kramdown-rfc2629:398:in `<top (required)>'
	11: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-1.17.0/lib/kramdown/document.rb:117:in `method_missing'
	10: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-1.17.0/lib/kramdown/converter/base.rb:105:in `convert'
	 9: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:196:in `convert'
	 8: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:201:in `convert1'
	 7: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:957:in `convert_root'
	 6: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:213:in `inner'
	 5: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:206:in `inner_a'
	 4: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:206:in `map'
	 3: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:208:in `block in inner_a'
	 2: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:400:in `convert_codeblock'
	 1: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:301:in `memoize'
/usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:301:in `binread': No such file or directory @ rb_sysopen - .refcache/kdrfc-1_3_27-svg_tool_process-fcda95417cbfb32c1f0fd75d8e46709ece053d16.cache (Errno::ENOENT)
	17: from /usr/bin/kramdown-rfc2629:23:in `<main>'
	16: from /usr/bin/kramdown-rfc2629:23:in `load'
	15: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/bin/kramdown-rfc2629:398:in `<top (required)>'
	14: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-1.17.0/lib/kramdown/document.rb:117:in `method_missing'
	13: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-1.17.0/lib/kramdown/converter/base.rb:105:in `convert'
	12: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:196:in `convert'
	11: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:201:in `convert1'
	10: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:957:in `convert_root'
	 9: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:213:in `inner'
	 8: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:206:in `inner_a'
	 7: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:206:in `map'
	 6: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:208:in `block in inner_a'
	 5: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:400:in `convert_codeblock'
	 4: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:300:in `memoize'
	 3: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:304:in `rescue in memoize'
	 2: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:304:in `call'
	 1: from /usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:333:in `svg_tool_process'
/usr/lib/ruby/gems/2.7.0/gems/kramdown-rfc2629-1.3.27/lib/kramdown-rfc2629.rb:333:in `read': No such file or directory @ rb_sysopen - /tmp/kramdown-rfc20210205-9-1cclenh.svg (Errno::ENOENT)

I need to improve those error messages :-)
@startuml and @enduml are added by kramdown-rfc, you need to leave these out (once I have fixed a bug in the plantuml processing; to be fixed in 1.3.27; workaround: use plantuml-utxt).
The remaining problem I get is
draft-i-d-toolchain-test.xml(334): Error: Invalid attribute rx for element polygon, at /rfc/middle/section[7]/artset/artwork[1]/*/*/*/*[4]/*[3]/*[1]
/Users/cabo/id/draft-i-d-toolchain-test.xml(13): Error: Invalid document before running preptool.
Unable to complete processing draft-i-d-toolchain-test.xml

which is some mermaid output I don't understand.

I think I got it working now, thanks!

So is there anything that the SVG smoother needs to do to handle the mermaid case?

It seems to just work with the current version of my testcase I-D. But mermaid is completely nuts in terms of dependencies, it requires Chromium for example.


Can you please customize it for the Wegame version?

Thank you for making Blish HUD, it is the best plugin I have ever used.
I am a Chinese GW2 player. there are two versions of GW2 in China, the reseller version and the Wegame version. Currently there are more players entering the world of GW2 with the Wegame version. But Blish HUD doesn't support Wegame version completely.
Can you please customize it for the Wegame version?

I am unfamiliar with the wegame version.  We've already made accommodations in the past for the other Chinese client, so I suspect we can accommodate this version as well.
Could you confirm what differences there are?

Is there the extra icon in the wegame version as there is in the other Chinese client?
Is the exe named something different (the other Chinese client is named KZW.exe)?
Are there other differences that you're aware of that affect compatibility?

@scldt where you able to find any of the above details for us to be able to move forward with providing support?


New files not being added during incremental build with require.context

My issue is similar to #556
I've got a webpack-dev-server setup to watch my files and inside my main app.coffee I have something like this:

loadContext = (contextRequire)->
  contextRequire.keys().forEach (mod)-> contextRequire(mod)

#load all module subfiles
loadContext require.context('./common', true, /.*/)
loadContext require.context('./envelopes', true, /.*/)
loadContext require.context('./home', true, /.*/)
loadContext require.context('./preferences', true, /.*/)
loadContext require.context('./reports', true, /.*/)
loadContext require.context('./workspaces', true, /.*/)

This works great for file changes, however if I try to add a new file within one of these directories or their subdirectories the webpack-dev-server re-runs the build but the new files are not included in the bundle.
I've tried setting the cache option to false but the problem still presents itself :disappointed:
Any tips or guidance would be much appreciated

This works for me... Wonder why it doesn't work for you...

I've created a repo to reproduce the bug
https://github.com/Whoaa512/webpack-repro

Thanks. I hope it's now fixed... :)

Yup it works for new files now! Thanks :)
It's not rebuilding if I try to delete the file though.

yep. But that not soo important... ;)

True :) I've gone ahead and added the updated modules to my production repo and it works like a charm.
Thanks again @sokra! :shipit:

@Whoaa512 Safe to close now?


Support for com.docker.network.container_iface_prefix driver label

This adds support for a custom interface prefix. Can be used to address issues such as docker/docker#20067. If the label is not used the default behaviour prevails.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:wnagele/libnetwork.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

All comments addressed now.

Thanks @wnagele , I only have one last comment about making the new option driver agnostic.

Thanks @wnagele
LGTM

Merge? :)

@wnagele
For most of the PRs we usually require two mantainers' LGTMs before merging.

Anybody else able to review this for a merge? @sanimej @mavenugo

Updated the title to include container_iface_prefix instead of container_interface_prefix (see https://github.com/docker/cli/pull/2984)


DB Port

Hello,
Is there any way to set custom db port ?
Thanks :)

You can now use DBPORT environment variable.

Big thank you ;)


Getting GPIO Error

When I try to upload I get this error
In file included from c:\Users\****\Documents\Arduino\libraries\TFT_eSPI\TFT_eSPI.h:48,
                 from c:\Users\****\Documents\Arduino\libraries\TFT_eSPI\TFT_eSPI.cpp:17:
c:\Users\****\Documents\Arduino\libraries\TFT_eSPI\Processors/TFT_eSPI_ESP32.c: In function 'void dc_callback(spi_transaction_t*)':
c:\Users\****\Documents\Arduino\libraries\TFT_eSPI\Processors/TFT_eSPI_ESP32.h:115:22: error: 'GPIO' was not declared in this scope
  115 |         #define DC_D GPIO.out_w1ts = (1 << TFT_DC)//;GPIO.out_w1ts = (1 << TFT_DC)
      |

in User_Setup.h I have
#define ILI9341_DRIVER
in User_Setup_Select.h I have
#include <User_Setups/Setup25_TTGO_T_Display.h>    // Setup file for ESP32 and TTGO T-Display ST7789V SPI bus TFT
Also for some reason the FactoryTest directory does exist, but Arduino never sees it
I tried looking around and using other setups, which will make the device work, but not the screen...

I am having this exact same issue.

I have fixed this by downgrading the esp32 board manager to version 2.0.17 (from 3.x) in the Arduino IDE:

I have also removed the TFT_eSPI library provided by this GitHub repo, and installed the stock version of the TFT_eSPI package via the Library Manager:

After installing the library, I edited ~/Documents/Arduino/libraries/TFT_eSPI/User_Setup_Select.h:

Commented out line #include <User_Setup.h>           // Default setup is root library folder
Uncommented line #include <User_Setups/Setup25_TTGO_T_Display.h>    // Setup file for ESP32 and TTGO T-Display ST7789V SPI bus TFT

downgrading to esp32 2.0.17 was enough for me. I need to choose ESP32 Dev Module as using lilygo T-Display there's some error with flags


Error handling updates in quota management usage

Small fixes around error handling inside the QM management initialisation path.

I am ok to approve this PR, a single test has failed due to resource jitter issues

fixes: #335

All quota management test pass, but there is still issues with MCAD resource jitter in tests. approving


Add a turn-based example game

How can Bevy's documentation be improved?
Turn-based games are popular and simple, but are surprisingly tricky to figure out how to architect in a framework designed around a game update loop like Bevy.
We should have a simple turn-based game in our examples to demonstrate a reasonable architecture.

Do you envision a simple but still fully playable game?
I'm currently thinking about something like 'tic tac toe' or '4 in a row', what are your thoughts?
I'd love to give it a try though

A tic tac toe or 4 in a row game wouldn't be bad to have as an example but normally you'd implement one as just a grid of buttons that when clicked the UI changes the state of another button in response, until someone wins. It wouldn't capture any of the complexity of a roguelike or rebelstar-style game.

I used to work on a 2d roguelike in bevy. This was ~2 years ago, before the current schedule system. Imo a simple roguelike would be ideal.
The biggest issue with a turn based game is the discrete nature of turns and game logic, mixed with the non-discrete nature of everything else. You still want the typical scheduler for things like rendering, animation ticking, sound effects and music, etc.
At the same time, you want to run game logic systems at a much slower pace, but also interspersed with the animations. So you'll want something like a spell that summons a poison cloud, which damages all nearby enemies, and then one of the enemies explode, which damages others, and then the turn finally switches. But that all needs to be run over multiple frames with animations running, and the animations need to be kept in sync and started and stopped by the game logic.
At the time, the way I did this was with a manually coded action queue, and passing &mut World around manually. Using events or the not-yet-implemented one-shot systems might be cleaner. I was even thinking of some kind of async system runner that would let you write synchronous gameplay logic in systems, and then run them over multiple frames.
So yeah TLDR; non-realtime logic systems are hard, and I think we might want some kind of async system runner for this kind of thing.
Curious to hear other people's thoughts.

Turn-based games are popular and simple, but are surprisingly tricky to figure out how to architect in a framework designed around a game update loop like Bevy.

Why is it tricky?
Turn-based games have a game loop - that's "turn". Which is naturally represented in Bevy with a custom schedule, that you manually run when user presses "end turn" button.

Turn-based games have a game loop - that's "turn". Which is naturally represented in Bevy with a custom schedule, that you manually run when user presses "end turn" button.

That is basically what I've presented here: https://gist.github.com/ItsDoot/c5e95258ec7b65fb6b2ace32fac79b7e

I tangled myself up in knots trying to recreate Advance Wars in Bevy, an example like this would've been invaluable.

With the new one-shot systems in place for Bevy 0.12.0, perhaps an example of setting up a simple turn queue for final fantasy type games would be helpful?


Multiple rules doesnt seem to work

Type

Bug

NLog version: 4.3.1
Platform: .Net 4.0 / .Net 4.5.2
Current NLog config:
<?xml version="1.0" encoding="utf-8" ?>
<nlog xmlns="http://www.nlog-project.org/schemas/NLog.xsd"
      xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
      xsi:schemaLocation="http://www.nlog-project.org/schemas/NLog.xsd NLog.xsd"
      autoReload="true"
      throwExceptions="false"
      internalLogLevel="Off" internalLogFile="c:\temp\nlog-internal.log" >
  <variable name="stdLayout" value="${longdate} [${uppercase:${level}}] : ${logger} : ${message}"/>
  <targets>
    <target xsi:type="File" name="fileLogger" fileName="${basedir}/logs/${shortdate}.log" layout="${var:stdLayout}" />
    <target xsi:type="ColoredConsole" name="consoleLogger" layout="${var:stdLayout}" />
  </targets>
  <rules>
    <logger name="NLogSandbox.ModuleA.*" minlevel="Error" final="true" writeTo="consoleLogger" />
    <logger name="NLogSandbox.ModuleB" minlevel="Info" final="true" writeTo="consoleLogger" />
    <logger name="*" minlevel="Debug" final="true" writeTo="consoleLogger" />
  </rules>
</nlog>

It looks like the Rules are not working when using multiple rules with wildcards
See attached example:
NLogSandbox.zip
I think that if i use final=true on the first 2 rules that on the last catch all rule these are not processed but it looks like it is always doing so.
Can you please tell me what i'm doing wrong or is this a bug inside NLog?

hi,
Can you give me an example of what isn't working? Please use the template; (what expected, current result)
Debugging a project is really a lot of work.

FYI,
the final=true works records that get matched for the rule. In this case name and minlevel. E.g. an ERROR on "NLogSandbox.ModuleA.test" will match only the first rule, and DEBUG on "NLogSandbox.ModuleA.test" will match only match the 3rd rule.

Closing this as we can't help without more info


[BUG]: Notices Issues contd.

Describe the bug

[x] Only post is getting displayed on Court Staff screen @nitish-beehyv
[x] When i click on Notice through Post the option comes as 'Send Email' @nitish-beehyv
[ ] I click on 'Mark as Sent' and go to the sent section, it comes up only when i play around with the number of listings. By default it is showing 6 day old notices and it is not the first set of notices

To Reproduce
https://drive.google.com/file/d/145NCp_YvVOeGrMzJSUii6EOXHYp73XK7/view?usp=sharing

First two issue is working fine in qa, qa will deployed to uat it will got fixed.
@Ramu-kandimalla

fixed the third issue for qa and develop, qa can test further
@Ramu-kandimalla

Hi @rajeshcherukumalli  Please verify in QA env

Hi @radheshjoshi1, I am blocked here to test this scenario,below I am providing reference for the issue:
reference:
#2031

Verified in QA [sol] env, ts working fine.
-url: https://dristi-kerala-qa.pucar.org/digit-ui/employee/orders/Summons&Notice
-reference link:

https://jam.dev/c/6c60a01d-f2e9-4064-8b12-0c08b936ddfb
https://jam.dev/c/3f275234-b93a-4456-a546-7c874a6b7061
-Test Scenario:
1.Verified all the Delivery Channels shown__post, email,sms,police, rpad.
2. verified Notice through Post the option comes as 'Proceed To Send’.
3.Verified task is shown as per first set of notices.
4. verified Issue Date field showing proper format.
5. Verified task is shown as per new task to old.
-Test case.
https://docs.google.com/document/d/1Qi97OUl2xxNfejRgpclhnSm-VOJ92uqHaSITwYiWVIs/edit?usp=sharing

Related issue:
#2021

Its working fine in UAT env.
https://jam.dev/c/3fe11b2c-1d8c-4f73-89b2-723183d91174


feat: add support for setting different secrets for environment variables.

add support of setting specific environment variables.
Making the env variables from secrets dynamic:
now variables allows setting in different ways:
example for api secrets
secrets:
  - name: terrakube-api-secrets
  - name: another-secret

TODO:
Update json spec of variables

Hello @Bart-vanDongen thank you for your contribution.
Can you help me updating the chart.yaml version please
https://github.com/AzBuilder/terrakube-helm-chart/blob/0079e88fe9fe10689b70b28530eb4c70f5568576/charts/terrakube/Chart.yaml#L18


No-publish the root

Pretty sure this fixes https://github.com/VirtusLab/scala-yaml/issues/177. The (empty) root project was being published with the same name as the core module, causing it to overwrite with an empty jar.

Thanks for looking into this. Unfortunately, I still see empty jars.
I have checked out your PR, and ran sbt clean +package. The jars present in target/scala* directories are still 318 bytes only.

I can't speak to your results. I ran publishLocal and it looks fine to me.

@gauravkumar37 are you looking in target/scala* or core/jvm/target/scala? The former is supposed to be empty, the latter is not.

Right, the problem was that the empty root target/ was overriding the core/jvm/target. No-publishing the root fixes that.

Thanks.
Off topic to this PR, I couldn't find any docs for scala 2.13 usage. The official guide is for scala 3 syntax.

Scala 2.13 was a later addition in https://github.com/VirtusLab/scala-yaml/pull/162, this project was originally built targeting Scala 3. I am sure a docs PR would be welcome :)

Thank you @armanbilge for tackling this, I couldn't find time to look at this myself.


Login via Facebook

Proposal
Supporting login via Facebook in Odin. Odin must validate facebook access tokens with facebook appID and secret before record to the database and return JWT to client
Implementation
modules opts/facebook

Create table facebook_credentials and facebook_credentials_ledger
Have trigger after insert to facebook_credentials_ledger to populate facebook_credentials table

Odin API
Odin view: odin.login.facebook
POST /odin/api/login-facebook
Payload
{"access_token": "<FACEBOOK_ACCESS_TOKEN>"}

Response minted JWT
Other

Odin must be able to config facebook_app_id and facebook_app_secret

Do we create a new column in the identity table for this? What happens if we get a request with a JWT already? I assume we don't yet do the linking?

Do we create a new column in the identity table for this?
Actually I meant to ask if we add a new row, I guess both questions are valid.

Do we create a new column in the identity table for this?
No, facebook_credentials should be one-to-one with identity
What happens if we get a request with a JWT already? I assume we don't yet do the linking?
This should be another feature. We have not supported the linking yet.

Do we create a new column in the identity table for this?

No, facebook_credentials should be one-to-one with identity

So we could add this as a new column to the credentials table?

I think we should treat Facebook the same as the credential table but I also wonder what happened when we are going to have applications concept in odin.


Update schema and sample val input to improve query generation

This PR updates the format of the schema and sample vals given in the prompt to correct mistakes like the following:
[UNRESOLVED_COLUMN.WITH_SUGGESTION] A column or function parameter with name `Written by, string` cannot be resolved.

[UNRESOLVED_COLUMN.WITH_SUGGESTION] A column or function parameter with name Written by, string cannot be resolved

What is the test case like? Is there a column Written by? I wonder if we should always wrap the column names with double backticks.


Readnoise mkrefs

These changes get the readnoise reffile code working with mkrefs. The following is what I changed:

added new readnoise section to the config file
added a 'D+' option to mkrefs since the readnoise code takes in a collection of darks and returns one readnoise file
added the mkrefs plugin script of the readnoise code mkref_readnoise.py
minor changes to the readnoise code (e.g. allowed option to save temporary files in case of crashes)

I've run different variations of mkrefs calls/options with this and everything looks good - for example, I get the same final results running the pipeline manually+then running the readnoise code directly on those calibrated files as I do running it through mkrefs with uncal files. I just wanted to give you the option to review it since it's my first time working with mkrefs, but the process of plugging it into mkrefs was very straightforward!

Yeah I doubt the saturation step is affecting the superbias/refpix steps at all (e.g. I don't think it's flagging refpix which would make them unused in the refpix step). But yes, I figured I might as well keep it for continuity just to be safe (and mkrefs not having to start from scratch for additional runs is another good point too)


Failure to run extension due to missing custom-mappings.txt file - workaround is to create one

(BTW, this is just the extension I needed when I did a big huge X/Y plot run to compare 50 some models. Running again.)
After I installed the extension, it would not run initially without creating a blank custom-mappings.txt file.
Can a blank one be created and installed by default?
Repro:

Install extension
Restart UI
I started an X/Y Plot that begins w/ the analog-diffusion model
Generate
Result:
Traceback error to command console saying that custom-mappings.txt was not found
Workaround:
Create a blank custom-mappings.txt file

Expanding the script extension area, too, and performing Save doesn't help. Performing Check gets an error.
Traceback:
Traceback (most recent call last):
File "C:\Users\Eric\repos\Stable-Diffusion\stable-diffusion-webui\venv\lib\site-packages\gradio\routes.py", line 337, in run_predict
output = await app.get_blocks().process_api(
File "C:\Users\Eric\repos\Stable-Diffusion\stable-diffusion-webui\venv\lib\site-packages\gradio\blocks.py", line 1015, in process_api
result = await self.call_function(
File "C:\Users\Eric\repos\Stable-Diffusion\stable-diffusion-webui\venv\lib\site-packages\gradio\blocks.py", line 833, in call_function
prediction = await anyio.to_thread.run_sync(
File "C:\Users\Eric\repos\Stable-Diffusion\stable-diffusion-webui\venv\lib\site-packages\anyio\to_thread.py", line 31, in run_sync
return await get_asynclib().run_sync_in_worker_thread(
File "C:\Users\Eric\repos\Stable-Diffusion\stable-diffusion-webui\venv\lib\site-packages\anyio_backends_asyncio.py", line 937, in run_sync_in_worker_thread
return await future
File "C:\Users\Eric\repos\Stable-Diffusion\stable-diffusion-webui\venv\lib\site-packages\anyio_backends_asyncio.py", line 867, in run
result = context.run(func, *args)
File "C:\Users\Eric\repos\Stable-Diffusion\stable-diffusion-webui\extensions\model-keyword\scripts\model_keyword.py", line 122, in check_keyword
entry = get_keyword_for_model(model_hash, model_ckpt, return_entry=True)
File "C:\Users\Eric\repos\Stable-Diffusion\stable-diffusion-webui\extensions\model-keyword\scripts\model_keyword.py", line 71, in get_keyword_for_model
hash_dict = load_hash_dict()
File "C:\Users\Eric\repos\Stable-Diffusion\stable-diffusion-webui\extensions\model-keyword\scripts\model_keyword.py", line 41, in load_hash_dict
modified = str(os.stat(default_file).st_mtime) + '_' + str(os.stat(user_file).st_mtime)
FileNotFoundError: [WinError 2] The system cannot find the file specified: 'C:\Users\Eric\repos\Stable-Diffusion\stable-diffusion-webui\extensions\model-keyword/custom-mappings.txt'

There was a bug in the old version. I've fixed the bug, but got in again while trying to add api support.
Thank you for the report.
Latest version will create the file if it's not available.


Use Click() in CheckByClick() and implement CheckByClickInput() using ClickInput()

This is an inconsistency in method names for a CheckBox.

Fixed in 4686bde702a8a0aaa6108e51ff14c2b1162109cb


Using Update Function throws occasional 412 errors when documents has inline attachments

I'm using javascript Update Functions to invoke server-side logic to update some individual fields in documents without first getting the latest revision as explained in: http://docs.couchdb.org/en/2.0.0/couchapp/ddocs.html?highlight=update handler.
My documents have inline attachments. The individual fields I'm updating are not the document _attachments. On occasions I'm getting 412 'Precondition Failed' error with message 'Invalid attachment stub in <doc_id> for <attachment_name>'.
The error seems false positive because when I inspect the document I see that it has the updated content and the _attachments part looks intact (see example).
"_attachments": {
"content": {
"content_type": "text/plain",
"revpos": 1,
"digest": "md5-H05fzZIvzFkyezESkSEwwQ==",
"length": 32,
"stub": true
}
}
Expected Behavior
Update function should consistetly return success code.
Current Behavior
Update function return success code on about 50% of executions.
The other times it throws 412 'Precondition Failed' error with message 'Invalid attachment stub in <doc_id> for <attachment_name>'. But the document is updated correctlly when inspected at the DB.
Possible Solution
?
Steps to Reproduce (for bugs)
Use couchdb v2.0.0 and nano js client to:

Create and store a document with an inline text attachment. Attachment size does not matter.
Create an update function that updates some document fields (not the attachment).
Call the the update function to update the doc.
On occasions, the nano client will throw error 412 'Precondition Failed' with message 'Invalid attachment stub in <doc_id> for <attachment_name>'.

Your Environment

Version used: couchdb v2.0.0
Browser Name and version: not relevant
Operating System and version (desktop or mobile): Linux

Hi @ArikShifer Are you able to test this against CouchDB master at all? We're finalising the list of bugs for fixing in 2.1 and need a reproducible test case for this against master if we're to consider this a blocker.

HI @wohali, unfortunately I cannot test against CouchDB master. My project is restricted to couchdb v2.0.0.

Hi
Same issue here (also with 2.0.0).
Do you have any updates ?
Regards,
Martinho MOREIRA

@moreiramarti We need a reproducible test case.

Closing for inactivity. Please reopen with a reproducible test case.


“Review” button does not get enabled when the user enters an amount less than 0.005 CELO in the “Amount(CELO)” field on the Buy CELO page.

Frequency: 100%
Repro on build version: Play store build V1.10.1, App store build V1.10.1
Repro on devices: Samsung Galaxy M31(10.0), Vivo V11 pro (10.0) , iPhone 5S(12.5.1), iPhone 6 + (12.4.5)
Does Not Repro On Devices: Samsung Galaxy J5 Prime (8.0)
Testing Account:<PHONE_NUMBER> / Backup Key
Pre-condition: Users should have at least $0.04 in account.
Repro Steps:

Launch the application & login with a test account.
Tap on CELO from “Hamburger Menu”.
Tap on the “Buy” button & tap on “Amount(CELO) field.
Now enter 0.005 CELO amount in the field.
Observed that,
Current Behavior:  Review button does not get enabled even if the user has sufficient balance.
Expected Behavior:  Review button should enable.
Investigation: We have not observed this issue for “Sell CELO” page.
Impact: Users are not able to send low balance.
Attachment: ReviewNotEnableEvenSufficientBalance.mp4

Hey @MuckT, We have verified this issue using Latest Android Internal Build V1.28.1, Test flight Release Build V1.28.1 & observe that the issue is fixed now.
"Review" button gets enabled when user enters an amount of 0.005 or less in "Amount (CELO)" field on buy CELO screen & able to complete buy CELO flow.
Hence we are closing this issue.
Devices: Google Pixel XL (10.0), iPhone SE 2020 (14.8.1)
Attachment: Review Button.mp4
Thanks..!!


Added support for all lifecycle events on iOS and Android

I've added support for all lifecycle events on iOS and Android and the plugin is sending up the exact lifecycle transition from each platform in case granular control of events by platform is required.

Could you tell me what is the use case of these additional events?
Also this will be a breaking change since PR seem to remove the existing foreground and background events. That is undesirable. The best I can think of is an additional getter platformEvents that streams all these.

This is great but seems android's onStart does not map to anything so it is reported as unknown.
According to the following lifecycle image, it might be report willEnterForeground

This PR is now almost 10 months old 🥲
Since I want to make this change non breaking, I will fork this PR and add these events into a different stream and a different factory constructor on the Widget to use these.


Fix api log file increases indefinitely

The manila-api pod uses a file between the manila-api service and a sidecar to pass the manila logs from the service to the stdout.
With the current code it will grow forever, which makes no sense, since the stdout from the pod itself is already being stored, under /var/log/pods and/or in a centralized logging service.
This patch makes the oslo.log service rotate the log file once it reaches 20MB in size.
Other projects like nova and glance set the limit to 50MB and they keep 5 rotated files, but I think that keeping rotated files is useless here and 50MB seems a bit much.
Unfortunately we need to at least keep 1 copy, or oslo.log will not do the right thing if set to 0.
We also need to redirect errors in the sidecar container that tails the log to /dev/null to prevent tail error messages whenever the file gets rotated.

/retest

I think we should update [1] to make kuttl pass.
[1] https://github.com/openstack-k8s-operators/manila-operator/blob/main/test/kuttl/tests/manila-tls/03-assert.yaml#L259


Remove need for explicit calc in dak.with_name

Usual meta patch-over with length_zero_array
@agoose77 FYI

Well, that's even weirder. I'm not sure why propagation of behaviors is being lost when I do this?
@agoose77 any idea?

This looks good to me. @lgray I'll merge if there's nothing else you'd like to add

Please go ahead - just taking care of warnings I see pop up!


services/horizon: Use new ingestion data in /accounts/{account_id}

PR Checklist
PR Structure

[x] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[x] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[x] This PR's title starts with name of package that is most changed in the PR, ex.
services/friendbot, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[x] This PR adds tests for the most critical parts of the new functionality or fixes.
[x] I've updated any docs (developer docs, .md
files, etc... affected by this change). Take a look in the docs folder for a given service,
like this one.

Release planning

[x] I've updated the relevant CHANGELOG (here for Horizon) if
needed with deprecations, added features, breaking changes, and DB schema changes.
[x] I've decided if this PR requires a new major/minor version according to
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.

Summary
This commit adds temporary code (to be removed in one of the future versions of Horizon) that compares account state in Stellar-Core and Horizon DB. If a difference is found it's logged with WARNING level.
Close #1766.
See #1726.
Known limitations & issues

It's possible that false alerts will happen because the old code does not use a DB transaction to get data from core DB. This means that new ledger can be applied during request is live.

shouldn't we check if expingestion is enabled before comparing results from both sources?

Good point, fixed and ready to review again.

Also can we use the new pattern so the new action is used only if exp-ingestion is turned on.

Not yet as we are still serving old data (and comparing with new data).

@abuiles great point about tests! I somehow though that I was using methods from #1835 but it's not true obviously.

@abuiles tests added. PTAL!


Row Selection Really slow

Row Selection really slow rendering
There is data who has 20 items , but while selection a row it is rendering very slowly. After I click  checkbox maybe after 1 second the checkbox is checked.

Tech
Version

Material-UI
4.2.1

MUI-datatables
2.14.0

React
16.8.6

browser
Opera

@huseyinbuyukdere I can't reproduce this on my end, can you open a codesandbox that demonstrates the issue?


[BUG] Default product-scroller skips tiles (desktop)

Summary

Go to: https://pwa-kit.mobify-storefront.com/ (on desktop with the width of the window larger than the boxed content on the home page)
Scroll to the product scroller / recommender
Click the right icon and observe the movement carefully:
The scroller scrolls four tiles but should only scroll three (you can also drag the scrollbar to see that one product is skipped)

The reason is that window.innerWidth returns a value that is too large thus scrolling to far. Replace it with scrollRef.current?.offsetWidth and it should work fine

Thanks for reporting this @ecRobertEngel. I captured what you are observing in a short clip
https://github.com/user-attachments/assets/278301f1-b05b-48d5-b5b8-291de3573b99

The fix has been merged into the PWA Kit develop branch.


Reorganize tests

Appveyor is still being unhappy

@Heather
Sorry for the delay. The latest failed test on linux(rust:beta) is caused by test_tail::test_follow_multiple stdout. Let's see if I can tackle this.
cc @mdsn BTW

@knight42 note travis build is buggy atm, sometimes it just needs the restart

:sweat: Anyway, they all got passed now.


Invalid password not cleared until we start VS Code

Root cause is the same as the  problem here (https://github.com/microsoft/vscode-jupyter/issues/13632)
Uri !== Uri

Should now be fixed


cmd/go/internal/fsys: panic: runtime error: slice bounds out of range [3:2]

What version of Go are you using (go version)?

$ go version
go version go1.17.8 linux/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE="auto"
GOARCH="amd64"
GOBIN="/home/zjx/workspace/gowork/bin"
GOCACHE="/home/zjx/.cache/go-build"
GOENV="/home/zjx/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/zjx/workspace/gowork/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/zjx/workspace/gowork"
GOPRIVATE=""
GOPROXY="https://goproxy.cn,direct"
GOROOT="/home/zjx/.local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/zjx/.local/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.17.8"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/zjx/workspace/gowork/src/go-fdg-exmaples/std/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build1878510231=/tmp/go-build -gno-record-gcc-switches"

What did you do?

I generated an unavailable data to parse as txtar.Archive, and it crashed.
package main

import (
	"cmd/go/internal/txtar"
)

func main() {
	input := "--\n-- --\n--"
	txtar.Parse([]byte(input))
}

This code needs to run in GOROOT/src
What did you expect to see?
It parses failed and returns nil
What did you see instead?
It crashed with
panic: runtime error: slice bounds out of range [3:2]

goroutine 1 [running]:
cmd/go/internal/txtar.isMarker({0xc000016083, 0x8, 0xd})
        /home/zjx/.local/go/src/cmd/go/internal/txtar/archive.go:127 +0x20b
cmd/go/internal/txtar.findFileMarker({0xc000016080, 0xb, 0x10})
        /home/zjx/.local/go/src/cmd/go/internal/txtar/archive.go:103 +0x86
cmd/go/internal/txtar.Parse({0xc000016080, 0xb, 0x10})
        /home/zjx/.local/go/src/cmd/go/internal/txtar/archive.go:81 +0x6c
main.main()
        /home/zjx/.local/go/src/cmd/go/internal/fsys/poc/main.go:9 +0x2c
exit status 2

Found by go-fuzz

The issue should have been fixed by https://github.com/golang/tools/commit/ebce39e5e3d61d0fe719fc8977959d0a14972ce6. See also #47193.


fix: change the type of GetContractEnv's 2nd arg from *Cache to Cache

Description
This PR changes the type of GetContractEnv's 2nd arg from *Cache to Cache
see #90 for detail.
closes #90
Types of changes

[x] Bug fix (changes which fixes an issue)
[ ] New feature (changes which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] ETC (build, ci, docs, perf, refactor, style, test)

Checklist

[x] I followed the contributing guidelines.
[ ] I have updated the documentation accordingly. (NOT NEEDED)
[ ] I have added tests to cover my changes. (NOT NEEDED)
[x] The PR title and commits are followed conventional commit form.

closed via
https://github.com/line/cosmwasm/issues/273
(getContractEnv will be removed)


[Website]Patch i18n enable

Refer issue #410   & issue #394 & PR #395  & PR #406
I add the i18n support with zh(Chinese) language.

Thanks so much for this PR @node!
I'd suggest to merge https://github.com/cncf/tag-app-delivery/pull/426 first, then make sure this PR isn't breaking anything


Create a cloud function to query by geolocation

The version of Firebase that our app is using - Firestore, does not allow geoqueries. I have created a workaround by creating a Realtime DB in Firebase just to store user locations so geoqueries can be performed. The filters are applied in the app.


TypeError: Cannot call a class as a function

Posts = new Mongo.Collection('posts')

Post = Astro.Class
  name: 'Post'
  collection: Posts

gives me this error
W20160526-14:34:44.791(2)? (STDERR) TypeError: Cannot call a class as a function
W20160526-14:34:44.792(2)? (STDERR)     at BabelRuntime.classCallCheck (packages/babel-runtime/babel-runtime.js:25:1)
W20160526-14:34:44.792(2)? (STDERR)     at Object.Class (packages/jagi:astronomy/lib/core/class.js:36:24)

Perhaps because I'm using Coffeescript... but Class is kind of reserved in javascript

Class.create instead Astro.Class
import { Class } from 'meteor/jagi:astronomy';
import { Mongo } from 'meteor/mongo';

const Posts = new Mongo.Collection('posts');

const Post = Class.create({
  name: 'Post',
  collection: Posts
});

export default Post;

As I said Class.create instead Class. The Class keyword is not reserved, the class keyword is.

I got this working as Astro.Class.create - works. However, I do notice that Astro class is not attached in this scenario:
post = new Post

post.set
   content: content

id = post.save()
post = Posts.findOne _id: id

console.log post

when I log this out (on server), it's not an Astro class attached, just the data.
And as a result, the afterFind event is not being triggered.
Could this be caused by using Astro.Class.create ?

Strangely, the beforeSave event does trigger

Nevermind, I figured it out.
Still need to get used to V2, I was on <v2 for a long time and the changes are very subtle!


Add testing script for faster model conversions debugging

What do these changes do?
This PR adds a small script that converts a model and saves the generated flatbuffer on disk. This enable easier debugging when developing new conversion features that need to be tested on a full model without the need to build the pip package or modify the end2end tests to write the file to disk (which I found myself manually doing quite often).
How Has This Been Tested?
Tested manually with quicknet.

Maybe in the usage example add a note that it should be used with absolute paths, because the working directory of the python script will be something like bazel-bin/larq_compute_engine/tests/convert_model.runfiles/ which is usually not where you want the result stored.

The command will print the absolute path of the saved model at the end, but I added a note to the help text in 2c05b37606661cecb6417f8ffe8a9cc52dd5b856

I think it makes sense to add convert_model.py to .gitignore to prevent accidental committing..

I'd prefer not to add it to .gitignore because one of the reasons why this script would be useful for me is to have a place to temporarily commit test models on long lived branches like we did for the int8 quantization without the risk of introducing merge conflicts when rebasing those branches.


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-2.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 442

Questions ?
Please refer to the Backport tool documentation


Creating my own WebRTC service

I am trying to use this library to create a minimalistic Java WebRTC implementation, however I am stuck at displaying the local video feed. It seems that I need to create a VideoView and use that as a sink for the VideoTrack but I can’t seem to figure out how to do it. I also don't know how to set the local view to mirror mode. Here is what I have so far:
`
package WebRTC;
import dev.onvoid.webrtc.*;
import dev.onvoid.webrtc.demo.javafx.control.VideoView;
import dev.onvoid.webrtc.media.MediaDevices;
import dev.onvoid.webrtc.media.audio.AudioOptions;
import dev.onvoid.webrtc.media.audio.AudioSource;
import dev.onvoid.webrtc.media.audio.AudioTrack;
import dev.onvoid.webrtc.media.video.*;
import javafx.application.Application;
import javafx.geometry.Insets;
import javafx.scene.Scene;
import javafx.scene.layout.VBox;
import javafx.stage.Stage;
import java.util.ArrayList;
import java.util.List;
import java.util.function.Consumer;
import static java.util.Objects.isNull;
public class Main extends Application implements PeerConnectionObserver {
private PeerConnectionFactory factory;

@Override
public void start(Stage primaryStage) throws Exception {

    VBox root = new VBox();
    root.setPadding(new Insets(10));
    root.setSpacing(8);

    VideoView remoteVideoView = new VideoView();
    remoteVideoView.setLayoutX(100);
    remoteVideoView.setLayoutY(100);

    root.getChildren().add(remoteVideoView);

    VideoView localVideoView = new VideoView();
    localVideoView.setLayoutX(100);
    localVideoView.setLayoutY(100);

    root.getChildren().add(localVideoView);

    factory = new PeerConnectionFactory();

    VideoDeviceSource videoSource = new VideoDeviceSource();
    videoSource.setVideoCaptureDevice(MediaDevices.getVideoCaptureDevices().get(0));
    VideoTrack videoTrack = factory.createVideoTrack("videoTrack", videoSource);

    // Don't know how to do this properly or set local view in mirror mode:
    videoTrack.addSink(localVideoView);

    AudioSource audioSource = factory.createAudioSource(new AudioOptions());
    AudioTrack audioTrack = factory.createAudioTrack("audioTrack", audioSource);

    RTCIceServer iceServer = new RTCIceServer();
    iceServer.urls.add("stun:stun.l.google.com:19302");

    RTCConfiguration config = new RTCConfiguration();
    config.iceServers.add(iceServer);
    config.bundlePolicy = RTCBundlePolicy.MAX_BUNDLE;
    config.rtcpMuxPolicy = RTCRtcpMuxPolicy.NEGOTIATE;
    config.iceTransportPolicy = RTCIceTransportPolicy.ALL;

    RTCPeerConnection peerConnection = factory.createPeerConnection(config, this);

    List<String> streamIds = new ArrayList<>();
    streamIds.add("stream-0");

    RTCRtpSender audioSender = peerConnection.addTrack(audioTrack, streamIds);
    RTCRtpSender videoSender = peerConnection.addTrack(videoTrack, streamIds);

    primaryStage.setTitle("WebRTC");
    primaryStage.setScene(new Scene(root, 300, 275));

    primaryStage.show();
}

@Override
public void onIceCandidate(RTCIceCandidate candidate) {

}

@Override
public void onDataChannel(RTCDataChannel dataChannel) {

}

@Override
public void onConnectionChange(RTCPeerConnectionState state) {
    if (state == RTCPeerConnectionState.CONNECTED) {

    }
}

public static void main(String[] args) {
    launch(args);
}

}
`

Hi @meeeee12
your code requires a bit more work to function properly. But let's start with the video source. To receive video frames from the VideoDeviceSource, you need to start it first, e.g.,
try {
	videoSource.start();
}
catch (Exception e) {
	e.printStackTrace();
}

To use the peer connection, you need to create an offer with it, if you want to initiate the connection setup, e.g,
RTCOfferOptions options = new RTCOfferOptions();

peerConnection.createOffer(options, new CreateSessionDescriptionObserver() {

	@Override
	public void onSuccess(RTCSessionDescription description) {
		peerConnection.setLocalDescription(description, new SetSessionDescriptionObserver() {

			@Override
			public void onSuccess() {
				// Send description as offer.
			}

			@Override
			public void onFailure(String error) {
				System.out.println("Set local RTCSessionDescription failed: " + error);
			}
		});
	}

	@Override
	public void onFailure(String error) {
		System.out.println("Create RTCSessionDescription failed: " + error);
	}
});

Setting the local session description will also trigger void onIceCandidate(RTCIceCandidate candidate). These candidates must also be sent to the remote peer. Eventually, you receive an answer (RTCSessionDescription) from the remote peer which can be set with peerConnection.setRemoteDescription()...

Thank you for your help, however I'm still having problems setting up the local video sink. The following line does not compile:
videoTrack.addSink(localVideoView);

That's because localVideoView as VideoView is not a VideoTrackSink. Please see the definition of VideoTrack.addSink. You should replace the line in question with:
videoTrack.addSink(localVideoView::setVideoFrame);

When I try to run it I receive:
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  EXCEPTION_UNCAUGHT_CXX_EXCEPTION (0xe06d7363) at pc=0x00007ffaf2a84ed9, pid=10400, tid=11364
#
# JRE version: Java(TM) SE Runtime Environment (15.0.1+9) (build 15.0.1+9-18)
# Java VM: Java HotSpot(TM) 64-Bit Server VM (15.0.1+9-18, mixed mode, sharing, tiered, compressed oops, g1 gc, windows-amd64)
# Problematic frame:
# C  [KERNELBASE.dll+0x34ed9]
#
# No core dump will be written. Minidumps are not enabled by default on client versions of Windows
#
# An error report file with more information is saved as:
# C:\Users\User\Desktop\WebRTC Simple JavaFX\hs_err_pid10400.log
#
# If you would like to submit a bug report, please visit:
#   https://bugreport.java.com/bugreport/crash.jsp
# The crash happened outside the Java Virtual Machine in native code.
# See problematic frame for where to report the bug.
#

I tried running on a different computer with java 11, with the same result.
My current code (stripped down to only display the local video feed):
package WebRTC;

import dev.onvoid.webrtc.*;
import dev.onvoid.webrtc.demo.javafx.control.VideoView;

import dev.onvoid.webrtc.media.MediaDevices;
import dev.onvoid.webrtc.media.video.*;

import javafx.application.Application;
import javafx.geometry.Insets;
import javafx.scene.Scene;
import javafx.scene.layout.VBox;
import javafx.stage.Stage;

public class Main extends Application {

    private PeerConnectionFactory factory;

    @Override
    public void start(Stage primaryStage) {

        VBox root = new VBox();
        root.setPadding(new Insets(10));
        root.setSpacing(8);

        VideoView localVideoView = new VideoView();
        localVideoView.setLayoutX(100);
        localVideoView.setLayoutY(100);

        root.getChildren().add(localVideoView);

        primaryStage.setTitle("WebRTC");
        primaryStage.setScene(new Scene(root, 300, 275));
        primaryStage.show();

        factory = new PeerConnectionFactory();

        VideoDeviceSource videoSource = new VideoDeviceSource();
        videoSource.setVideoCaptureDevice(MediaDevices.getVideoCaptureDevices().get(0));
        VideoTrack videoTrack = factory.createVideoTrack("videoTrack", videoSource);

        videoTrack.addSink(localVideoView::setVideoFrame);

        try {
            videoSource.start();
        }
        catch (Exception e) {
            e.printStackTrace();
        }
    }

    public static void main(String[] args) {
        launch(args);
    }
}

The line videoSource.start(); causes the crash.
For my setup I downloaded the github project, run mvn install and imported 4 jar files created as libraries into a new JavaFX project. Imported jar files:
webrtc-java-0.3.0-SNAPSHOT.jar
webrtc-java-0.3.0-SNAPSHOT-windows-x86_64.jar
webrtc-java-demo-api-0.3.0-SNAPSHOT.jar
webrtc-java-demo-javafx-0.3.0-SNAPSHOT.jar

For debugging purposes, could you please ommit this line and start the app again:
videoSource.setVideoCaptureDevice(MediaDevices.getVideoCaptureDevices().get(0));
Could something be wrong with the camera device selection. If you do not provide a video device, one will be selected by default.

Omitting that line does indeed prevent the crash, but the local video feed still isn't being displayed.

Hi @meeeee12
your code requires a bit more work to function properly. But let's start with the video source. To receive video frames from the VideoDeviceSource, you need to start it first, e.g.,
try {
	videoSource.start();
}
catch (Exception e) {
	e.printStackTrace();
}

To use the peer connection, you need to create an offer with it, if you want to initiate the connection setup, e.g,
RTCOfferOptions options = new RTCOfferOptions();

peerConnection.createOffer(options, new CreateSessionDescriptionObserver() {

	@Override
	public void onSuccess(RTCSessionDescription description) {
		peerConnection.setLocalDescription(description, new SetSessionDescriptionObserver() {

			@Override
			public void onSuccess() {
				// Send description as offer.
			}

			@Override
			public void onFailure(String error) {
				System.out.println("Set local RTCSessionDescription failed: " + error);
			}
		});
	}

	@Override
	public void onFailure(String error) {
		System.out.println("Create RTCSessionDescription failed: " + error);
	}
});

Setting the local session description will also trigger void onIceCandidate(RTCIceCandidate candidate). These candidates must also be sent to the remote peer. Eventually, you receive an answer (RTCSessionDescription) from the remote peer which can be set with peerConnection.setRemoteDescription()...

Hi , I have been looking at this sample but I seem not to trigger the void onIceCandidate(RTCIceCandidate candidate)  function I have tried server implementations , I wish o use this with janus server ,please can you help  ?


Feature Request - ignore some branches

Hello (again),
I'm working on a project consisting in a fork of another project. Our master branch is the one from the original repository we forked - we merge master with our own development branch from time to time to make sure we have the latest development of their end.
It is possible to set another branch as a base with the -b option - however, when setting our development branch as base, the --dry-run indicates that the master branch would be deleted (since it has been merged with our development branch). It is important for us to keep this master branch intact.
Could it be possible in the future to provide an option telling git-trim to ignore certain branches? So that, in our specific use case, the master branch would be preserved
Thanks for this project !

Have you tried a protected option? https://github.com/foriequal0/git-trim#git-config-trimprotected

git-trim is mainly intended for the github-flow like branch workflow. I didn't thought about dynamically changing the base branch setting. You also can set multiple base branches. I recommend you to use multiple bases master,develop, which is already a default.

Right, I did not see it was possible to include multiple base branches - I saw the protected option in --help but there was no help there. I did not think of reading the "Configurations" section neither

Well it works wonders that way. Thanks again!


Follower requests never complete - ModSecurity off

I've successfully set up<EMAIL_ADDRESS>- it appears on the Fediverse. But people can't follow it.
ModSecurity is set to "off" in my cPanel. As per #341 and https://blog.rac.me.uk/2022/11/10/activitypub-for-wordpress-how-to-fix-modsecurity-to-make-it-work/#adding-the-new-mod-security-rule that should fix it. But it doesn't.

Are there any tests I can run to see what the problem is?
Site Health shows:

Author URL is not accessible ActivityPub
Your author URL https://shkspr.mobi/blog/author/admin/ does not return valid JSON for application/activity+json. Please check if your hosting supports alternate Accept headers.

However, I am not using admin as the author; I've disabled the author in the settings and have a generic blog profile ID.

Yes, it seems to return only HTML!
You can check it with
## Request (23)
curl "https://shkspr.mobi/blog/author/admin/" \
     -H 'Accept: application/activity+json'

Have you enabled caching? Maybe the cache does not support content negotiation?

Interesting. If I do curl "https://shkspr.mobi/blog/@qwerty" I get
{"code":"activitypub_user_not_found","message":"User not found","data":{"status":404}}
But if I do curl "https://shkspr.mobi/blog/@blog" (which is the username) I get a 301 redirect to my blog's front page.
I had this as the setup:

I've excluded /author/ from the cache. And re-enabled the author profile type. But follow requests still aren't processed.

yes, it redirects if you do not add the application/activity+json Accept header. It is the blog user so you see all its posts on the main page :)
Have you also excluded the API and the @-urls? Because the blog-user has no author URL, it is a simple rewrite rule to an API endpoint.

OK, I think I've done all that - but I still can't accept followers.
<EMAIL_ADDRESS>appears on Mastodon.social and I can see the last few blog posts.
<EMAIL_ADDRESS>appears on Mastodon.social but there are no posts.
Following either of them doesn't work.
I've excluded the following URls from cacheing.
/.well-known/*
/wp-json/*
/author/*
/@blog

Are there any others which should be excluded?

shouldn't it be /blog/...?

I've disabled caching for tonight.

Okay, I'm a novice, but I can find my user account for my blog. The JSON for the account is listing:
{"@context":["https:\/\/www.w3.org\/ns\/activitystreams","https:\/\/w3id.org\/security\/v1",{"manuallyApprovesFollowers":"as:manuallyApprovesFollowers","PropertyValue":"schema:PropertyValue","schema":"http:\/\/schema.org#","pt":"https:\/\/joinpeertube.org\/ns#","toot":"http:\/\/joinmastodon.org\/ns#","webfinger":"https:\/\/webfinger.net\/#","litepub":"http:\/\/litepub.social\/ns#","value":"schema:value","Hashtag":"as:Hashtag","featured":{"@id":"toot:featured","@type":"@id"},"featuredTags":{"@id":"toot:featuredTags","@type":"@id"},"alsoKnownAs":{"@id":"as:alsoKnownAs","@type":"@id"},"discoverable":"toot:discoverable","sensitive":"as:sensitive","resource":"webfinger:resource"}],"id":"https:\/\/wyomingjarbo.com\/blog\/wp-json\/activitypub\/1.0\/users\/0\/inbox","generator":"http:\/\/wordpress.org\/?v=6.3.1","type":"OrderedCollectionPage","partOf":"https:\/\/wyomingjarbo.com\/blog\/wp-json\/activitypub\/1.0\/users\/0\/inbox","totalItems":0,"orderedItems":[],"first":"https:\/\/wyomingjarbo.com\/blog\/wp-json\/activitypub\/1.0\/users\/0\/inbox"}
How is "manuallyApprovesFollowers":"as:manuallyApprovesFollowers", being populated?

my blog is https://endeavr.de
my blog user is<EMAIL_ADDRESS>I can find the user on Mastodon. If I follow I encounter the same issue as per above.
if I do curl I get no result back:
$ curl<EMAIL_ADDRESS>$

@jarbochov I assume that there is an issue somewhere, that is caused by WordPress installations in sub-pathes. Currently I am checking if there is an issue with signature verification, because of a wrong generated URL/URI.

@blindi0815 works for me

Yes because shame on me I should've just RTFM. My blog is in installed in root. I followed
location ~* /.well-known {     allow all;     try_files $uri $uri/ /blog/?$args; }
from the plugin FAQ and made it to
location ~* /.well-known {     allow all;     try_files $uri $uri/ /?$args; }
Now I have
    location ~ ^/(.+/|)\.(?!well-known\/) {
deny all;
}
location ~* /.well-known {         allow all;         try_files $uri $uri/ /?$args;     }
and I am not sure if this is okay?

@pfefferle
Doesn't from my instance marctodon.marci.one - it is a plain mastodon instance hosted by myself. Is there anything that the instance must support?

@blindi0815 sorry, I have no idea! I have no experience in hosting a Mastodon instance!

Might be an issue with the Mastodon instance version. Mine is running on 4.1.7, yours and @jarbochov is running on 4.2.0 nightly build. I can see the access in the nginx logs and they all look the same. Just that my instance doesn't like the response. Oh well. Thank you anyways

@edent @jarbochov can you test if the PR fixes your issue?
https://github.com/Automattic/wordpress-activitypub/pull/438

site_url(): https://shkspr.mobi/blog
home_url(): https://shkspr.mobi/blog

That appears to have fixed it. Going to test to see if it pushes a post.

Post successful. Thanks for your quick turnaround this.

@edent do you have an update for us?

@pfefferle I now have 80+ follower and they seem to be receiving my posts 😃

Similar issue here for the blog id https://www.como1.it/@scout
Last version of the plugin and of WordPress.
No caching plugins are active. I've also tested the endpoint and the json file seems to be fine, but the blog cannot be followed.


Fix broken link to "Waiting for an Incoming Request" in assertions-and-results.md

Summary
See file diff.
Testing Guidance
Deploy and click on link.

Thank you @Shaumik-Ashraf!


Pulling in calendar data from the community-maintained events calendar

The calendar whose data we need currently lives at https://www.boost.org/community/index.html
We'll want to pull the data and use it:

On the homepage in succinct line item form
a. Using the same layout/functionality as the hardcoded "Schedule of Events" section currently on the new homepage or
b. If there is a suggestion or idea for something that might work better, we should discuss.

On a new page where it can be displayed more fully as it currently works at the old site (but looking nicer than how it looks on the old site - looked like the example shown during the 10/27 meeting would work)

We should check with the current primary maintainer of this calendar and determine if this calendar is only going to be a release schedule, or if there is a possibility of including community-contributed events (or, any non-release events no matter who is contributing that information).
a. If it will be strictly a release schedule, it makes sense that the page will live in the Releases section
b. If it will include other events, I think it makes sense for it to live in the Community section (and a link to it would be provided on the Releases page)

I'll look into the third item there to make a decision on where that page will live, in case that has any bearing on where in the site architecture any of the code would best live.
@frankwiles, let me know if there's any info you need.  If access to the calendar on Google is needed, for instance- if you don't already have it.  Thanks!

@sdarwin Lacey needs creds for this one.

See pull request 874

Note to self: events on the homepage need caching!

@4down @sdarwin @frankwiles This is done. The only remaining items are:

I'll look into the third item there to make a decision on where that page will live, in case that has any bearing on where in the site architecture any of the code would best live.

Currently, the events are on the homepage and on their own calendar page, but the calendar page isn't linked from anywhere. https://www.preview.boost.org/calendar/
Just let me know what else should change and then we can close the ticket!

@williln The homepage update looks and works great!
I'll take care of finding the calendar page its new home.  If no one else has anything to add on this, we can close it out.
Thanks!


BUG: Clients Feedback

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
Client Feedback cards have the same text in very card so I want to work over this issue and can give cards an impressive feedback.
https://github.com/user-attachments/assets/11ff3d71-f3bd-464b-aea4-fc5be7d2fb9e
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@himanshu-03 @RitiChandak @Anushkabh
Please assign this issue to me under GSSoC'24.
Thank You!


ElasticSearch does not support anchor operators, such as ^ (beginning of line) or $ (end of line)

React Query Builder version
v7.1.0
Platform
Chrome on Mac
Description
The conversion from Query Builder to ElasticSearch using formatQuery(_query, "elasticsearch") for endsWith creates the following result:
{
    "bool": {
        "must": [
            {
                "regexp": {
                    "email": {
                        "value": "gmail.com$"
                    }
                }
            }
        ]
    }
}

When we use the above generated DSL Query, ElasticSearch will not return any result. That's because in their documentation, they mentioned that
Lucene’s regular expression engine does not support anchor operators, such as ^ (beginning of line) or $ (end of line). To match a term, the regular expression must match the entire string.
Proposed solution
If we still want to support endsWith and beginsWith, we will need to modify formatQuery such that it'll use wildcard instead of anchor operators.
Using the same example above, we should produce this DSL query instead:
{
    "bool": {
        "must": [
            {
                "regexp": {
                    "email": {
                        "value": ".*gmail.com"
                    }
                }
            }
        ]
    }
}

Reproduction
Use the Query Builder to create a query with "endsWith" (example gmail.com), use formatQuery(_query, "elasticsearch") to convert it to DSL query. Feed that to ElasticSearch and it'll not return any result.
Now, create a query with "contains" (example .*gmail.com), use formatQuery to convert to DSL query. It will return some results.
Expected behavior
Should return DSL query that is supported by Lucene's Regular Expressions (used by ElasticSearch).
Additional information
Reference: https://www.elastic.co/guide/en/elasticsearch/reference/current/regexp-syntax.html

Can you try v7.6.0? I think @flieks fixed this in #733.

Thanks @jakeboone02 , I've tested v7.6.0 and it works very well. Cheers


Remove package-builder from packages/ as moving

Ref https://github.com/symplify/package-builder/pull/2

All checks have passed 🎉 @TomasVotruba let's merge ;)
For splitted package, Github action is not running, please activate github action there https://github.com/symplify/package-builder/pull/2


Return to root page fails.

Hi Michael,
I have a login page followed by menu page, menu page contains master detail page by using LoadMultipleNavigation where initially app starts with login page(without PageModel) below.
public App()  {
try   {
InitializeComponent();
MainPage = new NavigationPage(new LoginPageDetail(this));
}
catch (Exception ex)
{
}
}
After login i navigate to Menu page using LoadMultipleNavigation method(Freshmvvm starts from here)
it works fine but if logout i can't redirect to login screen. No errors but screen not redirected to login screen(await CoreMethods.PopToRoot(false)) Fails.
also i tried a another method in App.Xaml.Cs
public void NavigateRootLoginPage(){
MainPage = new NavigationPage(new LoginPageDetail(this));
} it also failed.

Yeah i'm also facing same issue;


VM table outputs

This PR focuses on the get/list/show commands.

LGTM. Feel free to merge once my comments are clarified.


$cordovaSQLite Mocks needed for Unit Testing.

Is there any roadmap where this will be implemented ?

Greetings @scripterkaran!
I've closed this issue because my sensors indicated it was old and inactive, and may have already been fixed in recent versions of Ionic. However, if you are still experiencing this issue, please feel free to reopen this issue by creating a new one, and include any examples and other necessary information, so that we can look into it further.
Thank you for allowing me to assist you.


Automatically bump version

Discuss in #public-issue-8--automatically-bump-version
We could build our own action or I'm sure there are ones available in the marketplace that we could use to automatically bump the version in package.json when we cut releases

does release-it let us do that?


Detached nodes after creation at different positions

Describe the bug
When a detached node is created, the position seems to be different on clients.
To Reproduce
Steps to reproduce the behavior:

Add a detached node
Compare position with different joined clients
After moving the node, positions are synced properly

Expected behavior
Position should be the same, even in the beginning.
Screenshots

Core issue seems to be this:
When a new detached node is created (for example based off of the root node), it's coordinates are set to 0,0 (x,y) in mmp.service.ts#221. The same method then calls addNode, which adds -80 to y coordinates at nodes.ts#620, presumably to prevent overlap. This is all done client-side. At this point, the node is saved server side and the other client receives it. However, the other client calls the same method at nodes.ts#620 and adds another -80 to y coordinates (again, to prevent overlap), causing the coordinates to be 0,-160 instead of 0,-80.


Re-update article "Use an Office 365 SharePoint site to authorize provider-hosted add-ins on an on-premises SharePoint site"

Category

[X] Content fix
[ ] New article

Related issues:

https://github.com/SharePoint/sp-dev-docs/pull/4199

What's in this Pull Request?
This is the follow-up of PR https://github.com/SharePoint/sp-dev-docs/pull/4199, to re-apply some of the changes on this article that were lost when PR was merged.
The specific changes I re-submit in this PR are:

Remove unnecessary prerequisites
Remove the replacement of the SharePoint STS certificate, unnecessary

I tested and validated all my changes on 2 separate environments, both provisioned using this template:

a SharePoint 2013 farm (Windows Server 2012 R2)
a SharePoint 2019 farm (Windows Server 2016)

@VesaJuvonen Can you please check this PR? Currently the article https://docs.microsoft.com/en-us/sharepoint/dev/sp-add-ins/use-an-office-365-sharepoint-site-to-authorize-provider-hosted-add-ins-on-an-on is in a pretty bad shape as it contains only half of the changes in my previous PR. It makes it very inconsistent.
This PR resolves this.

@VesaJuvonen this PR really needs your attention, article https://docs.microsoft.com/en-us/sharepoint/dev/sp-add-ins/use-an-office-365-sharepoint-site-to-authorize-provider-hosted-add-ins-on-an-on needs to be updated to fix the inconsistencies introduced with the previous PR

@Meenal9936 can you please help get this PR merged as soon as possible?
It is a shame we leave this article in such a bad state for so long, it was updated with some of the changes from previous PR #4199, but not all, which makes it very inconsistent.

@Yvand Sorry for the delay... can you please update the PR to address conflicts? Once that's done, we can review for merge.

@andrewconnell thank you for jumping in, I just fixed the conflict


add pigz to explicitly installed packages

Issue #, if available: N/A
Description of changes:
When Docker was installed it explicitly depends on pigz, however in 1.25+ without Docker it is no longer installed.
$ yum deplist docker | grep pigz
  dependency: pigz
   provider: pigz.x86_64 2.3.4-1.amzn2.0.1

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Testing Done
# Before
$ time ctr i pull docker.io/library/python:latest > /dev/null

real    0m14.779s
user    0m0.832s
sys     0m0.473s

# After (requires containerd restart)
$ time ctr i pull docker.io/library/python:latest > /dev/null

real    0m10.890s
user    0m0.768s
sys     0m0.507s

This is great, thanks @steved.
I don't see any way to force containerd to use only unpigz. Maybe we should add a check to scripts/validate.sh so we can at least fail the build if this isn't installed?

Sure! Let me know what you think of 4fb3469.

Perfect, thanks!


Introduce BlobId V3 and the idea of native and crafted ids

Introduce V3 of the BlobId.
Introduce a type for blobs. For V3:

'Native' blobs are those that are created by the router in the
context of a PUT operation.
'Crafted' blobs are those that are V3 blobs crafted outside of
the router, such as say, converted V2 or V1 ids.

Take the current active blob id version from a config setting in
RouterConfig to make enabling new versions easy.
Tests pass with the config value set to 2 as well as 3.

@cgtz @vgkholla Addressed comments. Will discuss some of the points in person. (Build failure is unrelated unfortunately, have initiated another one).

Codecov Report

Merging #803 into master will decrease coverage by 0.08%.
The diff coverage is 64.51%.

@@             Coverage Diff              @@
##             master     #803      +/-   ##
============================================
- Coverage     66.76%   66.68%   -0.09%
- Complexity     4098     4102       +4
============================================
  Files           353      353
  Lines         26789    26871      +82
  Branches       3374     3379       +5
============================================
+ Hits          17887    17919      +32
- Misses         7970     8007      +37
- Partials        932      945      +13

Impacted Files
Coverage Δ
Complexity Δ

...ithub.ambry/tools/perf/ServerWritePerformance.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...om.github.ambry/tools/admin/DirectoryUploader.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

.../com.github.ambry/store/IndexWritePerformance.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...ain/java/com.github.ambry/config/RouterConfig.java
100% <100%> (ø)
1 <0> (ø)
:arrow_down:

...ain/java/com.github.ambry.router/PutOperation.java
89.97% <100%> (-0.92%)
69 <0> (-2)

.../com.github.ambry/config/VerifiableProperties.java
50.58% <40%> (-0.67%)
20 <1> (+1)

...src/main/java/com.github.ambry.commons/BlobId.java
77.77% <94.11%> (-3.81%)
38 <16> (+7)

.../main/java/com.github.ambry.router/EncryptJob.java
92.3% <0%> (-7.7%)
2% <0%> (-1%)

...c/main/java/com.github.ambry.network/Selector.java
78.48% <0%> (-3.59%)
44% <0%> (-1%)

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ef1084...03bf724. Read the comment docs.

@vgkholla @cgtz Addressed your comments.

@pnarayanan changes LGTM. Have left a comment about a test I would like us to have. Please see if that is possible (i'm not sure)

@cgtz Addressed your comments.


feat: Added Tablet Landscape Icon.

Description

Added tablet landscape icon for this issue - https://github.com/appsmithorg/appsmith/issues/9321

Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Icons story.

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

@albinAppsmith I see that the tablet icon in design system repo is black but on the figma file under devices it is fill color is gray - https://www.figma.com/file/i80YbQLLs5mXthjIHclPpX/Appsmith-Design-System?node-id=4275%3A39215
Should I change this icon too, please check the Allicons story for tablet & tabletLandscape. Thanks


Update README.md

Q
A

Bug fix?
no

New feature?
no

API breaks?
no

Deprecations?
no

Related tickets
fixes #X, partially #Y, mentioned in #Z

License
Apache 2.0

What's in this PR?

Why?

Additional context

Checklist

[ ] Code meets the Developer Guide
[ ] User guide and development docs updated (if needed)
[ ] Related Helm chart(s) updated (if needed)

To Do

[ ] If the PR is not complete but you want to discuss the approach, list what remains to be done here

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

This looks like spam related to hacktoberfest (see https://blog.domenic.me/hacktoberfest/).

I suggest labelling this as invalid. According to the Hacktoberfest FAQ:

We dislike seeing spam pull requests just as much as you, so please give them an invalid label and close them. Pull requests with an invalid label won’t be counted toward Hacktoberfest.


Enhancement: Browse actions partial

Ability to include extra browse actions / html without having to override the whole browse template

We already have the voyager::bread.partials.actions partial which renders each action button. The actions are defined elsewhere and are dynamic.
I don't really understand what you expect to add with this new partial that isn't already possible.  I'll need more justification before I can consider merging this.

Closing due to lack of response.


[SPARK-28543][DOCS][WebUI] Document Spark Jobs page

What changes were proposed in this pull request?
New documentation to explain in detail Web UI Jobs page and link it to monitoring page. New images are included to better explanation

How was this patch tested?
This pull request contains only documentation. I have generated it using "jekyll build" to ensure that it's ok

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

ok to test

Thank you for your contribution, @planga82 .

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14066/
Test PASSed.

Test build #108999 has started for PR 25424 at commit 14fbad7.

Test build #108999 has finished for PR 25424 at commit 14fbad7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108999/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14122/
Test PASSed.

Test build #109058 has started for PR 25424 at commit 23d9fe7.

Thanks for the review @srowen , I have fixed all comments
About your first question, sure, it doesn't add too much. When I saw the Jira issue I thought about how to drive it. I think it's a good idea to have documentation  about the web UI but I don't know what kind of documentation. Do you think it's better to add some examples? or explain what is a Job... but I think it's not the best place to explain what is a Job. Any idea to improve it?

Test build #109058 has finished for PR 25424 at commit 23d9fe7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109058/
Test PASSed.

Yeah I don't know right now. Maybe OK to just get a basic page down in the docs.

@srowen  I had some offline discussion with @gatorsmile ,  and the expected doc seems to be something like
1, https://www.cloudera.com/documentation/enterprise/5-9-x/topics/operation_spark_applications.html#spark_monitoring
2, https://www.ibm.com/support/knowledgecenter/en/SS3H8V_1.1.0/com.ibm.izoda.v1r1.azka100/topics/azkic_c_webUIs.htm
the first step in my opinion is to add some basic explanation, example and figure for each tab, and we can refine it in the future.

Merged to master


Terminal version of GetWindowRect(GetConsoleWindow(), ...)?

My CUI app wants to know where the UI is.  That was pretty straightforward in a console, GetWindowRect(GetConsoleWindow(), ...).  Are there any suggestions for doing it when the host is Windows Terminal?

No, this is not (and will not be) supported. The remoting infrastructure Terminal is built on also supports SSH and other windowless use cases (like pty hosting for tmux, screen, etc.).
It is also unsuitable for tabbed or paned presentation: what is the window rect of a console hosted in a tab that is not currently visible? Can it be said to have a window?

Any heuristic we could suggest would be subject to the same limitation :smile:

Any heuristic we could suggest would be subject to the same limitation
Fine, suggest something.

Set the window title and then look it up by title. It’ll only tell you where the window containing the pane is, only when it’s active, and only on the same machine. If that’s fine-grained enough, that should work.

Done that.  It's fairly easy but has it's problems, as you noted.
If my app is the shell (i.e., was started by windowsterminal.exe) I can EnumWindows looking for the "CASCADIA_HOSTING_WINDOW_CLASS" window whose ProcessId matches that of my parent.  That's more heavy-handed and also not perfect.

I'd like to see WindowsTerminal in action doing something other than hosting my local command interpreters.  If I turn on my Win7-32bit machine, it will be networked.  Is there some server software for Win7/32 and client software for Win10/64 that will let me mess around with (say) SSH?

Yeah! Win32-OpenSSH ships a server that works down to Windows 7, and the client ships in-box on Windows 10.

Thanks.  Yup.  I was just fetching OpenSSH-Win32.zip and I found some install help.  What's the client (Win10) and how do I do it all with WindowsTerminal?

The client that ships with Windows is ssh.exe, and it should already be on your PATH.
You can set up a profile whose commandline is something like ssh me@OtherMachine, and with public key authentication you won’t even need a password.

That was easy enough.  So I've seen it work.  This (below), however, failed on the Win7 machine.  Any ideas?
G:\OpenSSH> .\ssh-keygen.exe -A
ssh-keygen: generating new host keys: RSA Could not save your public key in PROGRAMDATA\ssh/ssh_host_rsa_key.oWF6huZDVn: No such file or directory
ssh-keygen: generating new host keys: DSA Could not save your public key in PROGRAMDATA\ssh/ssh_host_dsa_key.i0FGCIuDpT: No such file or directory
ssh-keygen: generating new host keys: ECDSA Could not save your public key in PROGRAMDATA\ssh/ssh_host_ecdsa_key.F8esqlhL8V: No such file or directory
ssh-keygen: generating new host keys: ED25519 Could not save your public key in PROGRAMDATA\ssh/ssh_host_ed25519_key.7sgGF2SaAB: No such file or directory
That said, I do have these:
2020-09-06  16:35               6  sshd.pid
2020-09-06  16:25           2,297  sshd_config
2020-09-06  16:35           1,393  ssh_host_dsa_key
2020-09-06  16:35             613  ssh_host_dsa_key.pub
2020-09-06  16:35             513  ssh_host_ecdsa_key
2020-09-06  16:35             185  ssh_host_ecdsa_key.pub
2020-09-06  16:35             419  ssh_host_ed25519_key
2020-09-06  16:35             105  ssh_host_ed25519_key.pub
2020-09-06  16:35           2,610  ssh_host_rsa_key
2020-09-06  16:35             577  ssh_host_rsa_key.pub
That said, I am asked for a password. ... ?????


Support custom fields

Punt field widget stuff for later

[x] Test formatter is field_example_simple_text and is discoverable (should work)
[x] Test field_example_field_validate (needs to move to field list class I think)
[x] Test field_example_field_is_empty
[x] Probably need to decorate fields with \ArrayAccess
[x] Verify saving the entity works

@darrenoh I'm preparing to merge this, does that sound good? Then we can rebase your #59 PR against main and land that

Thank you!


Feature Detail Not Displaying Everything

The feature detail tab under analysis ID 16071 only shows 22 features when there are more than that.

This is an issue between the iframe in qiita and the iframe within the html from the Qiime2 html. Note that currently you can open in a new window, click on the blue button on top of the visualization, and you'll get the normal behavior.

This is a duplicate of https://github.com/biocore/qiita/issues/2499


Fixed: #16 - selected page is highlighted

Fixes issue #16
Changes: Highlighted the selected page
Screenshots for the change:

Codecov Report

Merging #20 into master will increase coverage by 0.5%.
The diff coverage is 15.38%.

@@          Coverage Diff           @@
##           master   #20     +/-   ##
======================================
+ Coverage   11.49%   12%   +0.5%
======================================
  Files           1     1
  Lines          87   100     +13
======================================
+ Hits           10    12      +2
- Misses         77    88     +11

Impacted Files
Coverage Δ

src/index.js
12% <15.38%> (+0.5%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6881864...d24fb28. Read the comment docs.


Incorrectly marked RESERVED pages

In some cases, AVD generator will generate a RESERVED page for a NVD CVE (along with vendor info) when the CVE might not actually be RESERVED anymore.
One example: https://nvd.nist.gov/vuln/detail/CVE-2021-3807 and https://avd.aquasec.com/nvd/cve-2021-3807/
Need to investigate why this happens.

Fixed by https://github.com/aquasecurity/avd-generator/commit/7dc578b9fc2f6398ba87a3c892ff4e9bc2df2ecc


Adds Standard

Resolves https://github.com/crypto-browserify/crypto-browserify/issues/120
Can't be merged yet as master is failing in the tests and I mostly used standard --format for this,  so manual review is needed.
@calvinmetcalf please ping when that is fixed.

and we are green!

:+1:


added to TM info

What does this PR (Pull Request) do?

[x] This PR is not related to any Issue

updated blueprint with more TM info
Which Traffic Control components are affected by this PR?

Documentation

What is the best way to verify this PR?

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

[x] This PR includes tests OR I have explained why tests are unnecessary
[x] This PR includes documentation OR I have explained why documentation is unnecessary
[x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
[x] This PR includes any and all required license headers
[x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
[x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

These changes aren't based on my branch, so it shows the entire file as added, making this very difficult to review.
Can you rebase on my branch, and make only your changes?


Refactor ECR utils

Description of changes:
This moves the ECR-related bits into their own package, does a bit of refactoring of the details, and caches the sandbox image container image reference in the Status field of the NodeConfig.
Also attempts to make the e2e test infra image build faster by removing go mod download since we're vendoring dependencies now.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

LGTM, but I need to resolve conflicts for the max pod calculation now 😢