Inline JavaScript is not enabled

HI
next-plugin-antd-less occurred in my environment
// https://github.com/ant-design/ant-motion/issues/44
.bezierEasingMixin();
^
Inline JavaScript is not enabled

package.json
"dependencies": {
    "@apollo/client": "^3.3.3",
    "antd": "^4.9.4",
    "deepmerge": "^4.2.2",
    "graphql": "^15.4.0",
    "next": "10.0.3",
    "react": "17.0.1",
    "react-dom": "17.0.1"
    "next-plugin-antd-less": "^0.1.4",
  },

Sorry, I can't reproduce your problem, can you put the code into this project https://github.com/SolidZORO/mkn and try?

I got the same error when I tried to add plugin in nx default next.js project.
@SolidZORO  Just out of curiosity - Did you ttry to use plugin in NX monorepo? Maybe it is not possible at all...

I know NX, but I feel that he is too complicated, do not want to try again, you can think of another way to put.

Your problem, which I encountered a long time ago, is that javascriptEnabled is not enabled, or that you are using the plugin in the wrong way?

Just stumbled upon this, as I am suffering from the same error message. I wanted to reproduce this cloning https://github.com/SolidZORO/mkn and working up from there, but this project currently does not build:
error - ./src/styles/global.less ((webpack)/css-loader/cjs.js??ref--5-oneOf-3-1!(webpack)/postcss-loader/cjs.js??ref--5-oneOf-3-2!(webpack)/resolve-url-loader??ref--5-oneOf-3-3!./node_modules/less-loader/dist/cjs.js??ref--5-oneOf-3-4!./src/styles/global.less) TypeError: this.getOptions is not a function
There might be something wrong

@Servellia  I just tested mkn's clone and it works. Can you show your package.json and node version?

the package.json should be identical to yours:
{
  "name": "mkn",
  "description": "make React project with Next.js and typescript",
  "version": "0.1.1",
  "license": "MIT",
  "author": "Jason Feng<EMAIL_ADDRESS>  "private": true,
  "scripts": {
    "-------------------------------- LINT ----": "----",
    "lint": "tsc --noEmit && eslint src/**/*.ts{,x}",
    "fix": "yarn run lint-js --fix",
    "tsc-check": "tsc -v && tsc --noEmit",
    "format": "prettier --write src/**/*.ts{,x}",
    "-------------------------------- TOOL ----": "----",
    "versionup": "standard-version -r patch",
    "versionup:minor": "standard-version -r minor",
    "versionup:major": "standard-version -r major",
    "versionup:init": "standard-version --first-release",
    "-------------------------------- DEV  ----": "----",
    "dev": "next dev",
    "-------------------------------- PROD ----": "----",
    "build": "next build",
    "start": "next start"
  },
  "dependencies": {
    "antd": "^4.11.2",
    "autoprefixer": "^10.2.4",
    "axios": "^0.21.0",
    "classnames": "^2.2.6",
    "css-loader": "^5.0.1",
    "less": "^4.1.1",
    "next": "10.0.6",
    "next-plugin-antd-less": "^0.2.0",
    "normalize.css": "^8.0.1",
    "react": "17.0.1",
    "react-dom": "17.0.1",
    "react-helmet-async": "^1.0.7",
    "react-icons": "^4.1.0",
    "react-use": "^17.1.0"
  },
  "devDependencies": {
    "@commitlint/config-conventional": "^11.0.0",
    "@types/classnames": "^2.2.11",
    "@types/eslint": "^7.2.6",
    "@types/eslint-plugin-prettier": "^3.1.0",
    "@types/node": "^14.14.22",
    "@types/prettier": "^2.1.6",
    "@types/react": "^17.0.0",
    "@typescript-eslint/eslint-plugin": "^4.14.2",
    "@typescript-eslint/parser": "^4.14.2",
    "babel-plugin-import": "^1.13.3",
    "babel-plugin-module-resolver": "^4.0.0",
    "commitlint": "^11.0.0",
    "eslint": "^7.19.0",
    "eslint-config-airbnb": "18.2.1",
    "eslint-config-airbnb-base": "^14.2.1",
    "eslint-config-airbnb-typescript": "^12.0.0",
    "eslint-config-prettier": "^7.2.0",
    "eslint-plugin-import": "^2.22.1",
    "eslint-plugin-jsx-a11y": "^6.4.1",
    "eslint-plugin-prettier": "^3.1.4",
    "eslint-plugin-react": "^7.21.5",
    "eslint-plugin-react-hooks": "^4.2.0",
    "husky": "^4.3.8",
    "less-vars-to-js": "^1.3.0",
    "lint-staged": "^10.5.3",
    "prettier": "^2.2.1",
    "pretty-quick": "^3.1.0",
    "typescript": "^4.1.2"
  }
}

❯ node --version v12.18.4
Win10 2004

@Servellia
I can't reproduce this problem, on my macOS mkn the project is working and can be deployed to vercel normally, maybe your environment or dependency version is not right, clean up the global installation of npm in try?

I also just ran into this in a new nextjs app. Oddly enough, logging my webpack config from within nextjs config shows that javascriptEnabled is set to true. @SolidZORO looking through your mkn repo, I can't find where you imported antd.less in the project. Can you shed some light on that also?

@khalibloo use Windows?

Yes. Windows 10 x64

@khalibloo
I tested on a new windows computer by going to nodejs.org and downloading the latest version 14, then downloading mkn and installing it, and both dev and prod worked fine.
So I don't know what's wrong with you.
Can you provide more information about the error?

sorry I wasn't clear previously. I'm running the mkn project just fine. But with a new nextjs app, I get the same javascript not enabled error. I was trying to understand how your mkn project was able to use antd styles without importing it. I was hoping that might give me a clue into the "javascript not enabled" error.

@khalibloo  missing this?
https://github.com/SolidZORO/mkn/blob/573038fd6f3fcd149cc742129d7190e15d1f6ad1/babel.config.js#L8

Nope, I already added that. So that's what babel is there for.

@khalibloo @Servellia
Check to see if this is the problem.  https://github.com/SolidZORO/next-plugin-antd-less/issues/20#issuecomment-774698410

Yes! That turned out to be the root cause<EMAIL_ADDRESS>uses<EMAIL_ADDRESS>Downgrading to 0.2.0 which uses<EMAIL_ADDRESS>fixed the issue for me. I noticed in your mkn project, you used 0.2.0 as well. Thanks for that hint. I can finally proceed.

For verification, I installed 0.2.2 on the mkn project and it also broke, though with a different but related error.

<EMAIL_ADDRESS>fixed.


Add ability to change the image data type

See this conversation

Fixed with #53

This is not fixed. It was only fixed for the Primary HDU on creation. We want to be able


feat: add --dart-define parameter to very_good test command

Description
This PR adds the --dart-define parameter to the test command.

--dart-define is used to define compile-time constants which are then available through the String.fromEnvironment, bool.fromEnvironment, int.fromEnvironment, and double.fromEnvironment constructors.
Tests relying on such compile-time constants can currently not be run with very_good test, because the command doesn't yet accept the --dart-define parameter.
An example where one would use a --dart-define compile-time constant is to switch between different environments or flavors of an app. E.g. --dart-define=APP_ENVIRONMENT=dev.
This is useful because code as the following is automatically deleted in an optimization step when building an app:
const environment = String.fromEnvironment('APP_ENVIRONMENT');
const isEnvironmentDev = flavorString == 'dev';

...

// the whole if-block is automatically deleted during optimization when APP_FLAVOR != dev
// because `isEnvironmentDev` is a compile-time constant
if(isEnvironmentDev) {
  final secretDataOnlyForDev = 42;
}

Type of Change

[x] ✨ New feature (non-breaking change which adds functionality)
[ ] 🛠 Bug fix (non-breaking change which fixes an issue)
[ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🧹 Code refactor
[ ] ✅ Build configuration change
[ ] 📝 Documentation
[ ] 🗑 Chore

FYI: It seems that the CI test task is a bit flaky. I got the following error on my first CI run. When I reran the CI task with the same code, it succeeded without any errors.
https://github.com/VeryGoodOpenSource/very_good_cli/runs/8308620438?check_suite_focus=true


Update core lib API docs to mention createStore deprecation and point to RTK

Per this comment on Stack Overflow, the core lib docs don't mention that createStore is deprecated, and they don't talk about RTK at all.
We should fix that.

Done!


fix(webpack): dont push to compilersWatching in callback

Types of changes

[x] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

Possible fix for #6442, maybe others.
The issue in webpack has been around for 10 months, but only until pause/resume was added in v2.9.2 it started showing issues as on every server watcher callback the watcher instance was again added to the compilersWatching array.
Unresolved issue
For me webpack doesnt properly reload after I add a new file:

start hello-world example in dev mode
add pages/test1.vue
grep -ir test1 examples/hello-world/.nuxt/

.nuxt/router.js:const _24ea789e = () => interopDefault(import('../pages/test1.vue' /* webpackChunkName: "pages/test1" */))
.nuxt/router.js:    path: "/test1",
.nuxt/router.js:    name: "test1"

touch examples/hello-world/.nuxt/router.js
works:

...
.nuxt/dist/server/client.manifest.json:    "pages/test1.js"
...

Tried to fix this, but router.js is properly updated before resumeWatch is called. Tried timeouts, nextTick, override resumeWatch by calling invalidate manually but nothing seemed to work.
Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly. (PR: #)
[ ] I have added tests to cover my changes (if not applicable, please state why)
[ ] All new and existing tests are passing.

Codecov Report

Merging #6448 into dev will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              dev    #6448      +/-   ##
==========================================
+ Coverage   95.61%   95.65%   +0.03%
==========================================
  Files          79       79
  Lines        2693     2693
  Branches      697      697
==========================================
+ Hits         2575     2576       +1
+ Misses        101      100       -1
  Partials       17       17

Flag
Coverage Δ

#e2e
100% <ø> (ø)
:arrow_up:

#fixtures
50.64% <33.33%> (ø)
:arrow_up:

#unit
92.35% <100%> (+0.03%)
:arrow_up:

Impacted Files
Coverage Δ

packages/builder/src/builder.js
99.64% <100%> (ø)
:arrow_up:

packages/webpack/src/builder.js
92.85% <100%> (ø)
:arrow_up:

packages/vue-renderer/src/renderer.js
94.3% <0%> (+0.81%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95e043f...5d591d7. Read the comment docs.


Handle edges on frontend incase burnentrypoint is executed.

There's no burn entry_point in the contract deployed on mainnet.


MelonLoader installing problem

Can you please check if I did everything correctly or not?

https://github.com/bbepis/XUnity.AutoTranslator/issues/299

I would not expect ReiPatcher to work with Genshin impact at all. I have not tried, however.
I would highly suggest using BepInEx of MelonLoader if they support this type of game.


Non-empty list client-side validation

I have this model that contains a list of strings that I want to represent with a multiselect control, generated with the ListBoxFor helper and I want to make sure it's not empty. It's easy enough to do server-side with AssertThat("List != null"), but that doesn't work client-side. Is there any way to make it work?

In this case you should probably use simple Required attribute. It's because AssertThat works for non-null fields, so it is not supposed to trigger in your case, even at server side, when list is null.
Mabye what you want is to check not for null, but for emptiness (not null but without elements) instead. In such case you could write a method for that, e.g. ArrayLength and use it (see web sample for similar case).

I think that html helper might be bugged. Required doesn't do anything client side and neither does the IsNotEmpty method I wrote for EA. There are supposed to be extra data attributes added to the element, right? Because I'm not seeing them. Did you ever test anything with ListBoxFor?

I cannot investigate this any further right now because my notebook has crashed. Untill I get the new one only advice I can give is to look how much   the rendered HTML differs from what DropDownListFor gives, and possible look at the ValueParser attribute (in particular check definition for ArrayParser in Home.cshtml page of sample project).

Just to confirm and close the question - for the list to be non-null, simple [Required] attribute is enough (no need to use EA):
[Required]
public string[] SelectedOptions { get; set; }

@Html.ListBoxFor(model => model.SelectedOptions, new SelectList(Model.Options, null), string.Empty)

If you need to assert that some specific amount of items needs to be selected, EA allows to do that in the following manner, e.g.:
[Required]
[AssertThat("ArrayLength(SelectedOptions) > 1")]
[ValueParser("ArrayParser")]
public string[] SelectedOptions { get; set; }

where ArrayLength is your custom method (either registered in toolchain or available within the model context):
Toolchain.Instance.AddFunction<string[], int>("ArrayLength", array => array.Length);

ea.addMethod('ArrayLength', function(array) {
    return array.length;
});

and ArrayParser is your custom parsing mechanism to extract field values:
ea.addValueParser('ArrayParser', function(value, field) { // provide your custom parsing mechanism of the field value at client side
                                                          // parameters: value - raw data string extracted by default from DOM element
                                                          //             field - DOM element name for which parser was invoked
    var array = $(':input[name="' + field + '"]').serializeArray();
    return array.length === 0
        ? null    // if array is empty, return null for RequiredIf to complain
        : array;  // otherwise - return array object for the ArrayLength method to work on
});


Display exec path of non-python kernels

For non-python kernels we were still displaying the interpreter paths instad of the paths of the executable.
E.g. if you have a java kernel installed as part of a conda envioronment, we'd display the path of the conda enviroment in the dropdown list, instead of displaying the path to the java executable.
Came across this bug in demo today, will add news entry and issue for this.

Codecov Report

Merging #7929 (d64306e) into main (fd1d6cb) will decrease coverage by 0%.
 Consider uploading reports for the commit 1e40ec6 to get more accurate results

@@          Coverage Diff          @@
##            main   #7929   +/-   ##
=====================================
- Coverage     70%     70%   -1%
=====================================
  Files        361     361
  Lines      22154   22156    +2
  Branches    3377    3379    +2
=====================================
- Hits       15660   15647   -13
+ Misses      5135    5133    -2
- Partials    1359    1376   +17

Impacted Files
Coverage Δ

src/client/datascience/jupyter/kernels/helpers.ts
72% <33%> (-1%)
:arrow_down:

...ent/datascience/jupyter/pythonVariableRequester.ts
64% <0%> (-6%)
:arrow_down:

src/client/datascience/raw-kernel/rawSocket.ts
82% <0%> (-2%)
:arrow_down:

...t/datascience/notebook/vscodeNotebookController.ts
77% <0%> (-2%)
:arrow_down:

...datascience/jupyter/liveshare/hostJupyterServer.ts
67% <0%> (-1%)
:arrow_down:

src/client/datascience/jupyter/kernels/kernel.ts
77% <0%> (-1%)
:arrow_down:

src/client/common/errors/types.ts
52% <0%> (ø)

src/client/datascience/telemetry/telemetry.ts
79% <0%> (ø)

...client/datascience/raw-kernel/rawJupyterSession.ts
72% <0%> (ø)

...ient/datascience/raw-kernel/rawNotebookProvider.ts
67% <0%> (ø)

... and 1 more


"Cannot read property 'line' of null" in node-debug2/chromeDebugAdapter

I'm not sure if this is the right place to raise this, but it looks very similar to #42162. It's not clear if it's the Chrome Debugger extension, or node-debug2, though as far as I know, nothing should be using the Chrome Debugger extension (I'm running a TypeScript VS Code extension).
I see it often in my debug console when I'm debugging the Dart VS code extension (it appears in the main VS Code instance, after I've been running the extension in the dev host).
******** Unhandled error in debug adapter - Unhandled promise rejection: TypeError: Cannot read property 'line' of null
    at NodeDebugAdapter.<anonymous> (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/ms-vscode.node-debug2/node_modules/vscode-chrome-debug-core/out/src/chrome/chromeDebugAdapter.js:792:62)
    at Generator.next (<anonymous>)
    at fulfilled (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/ms-vscode.node-debug2/node_modules/vscode-chrome-debug-core/out/src/chrome/chromeDebugAdapter.js:7:58)

#42162 was resolved as fixed over a year ago, so I don't know if it's the same issue or not.
@roblourens how did track down the issue last time? You can try running the Dart extension from source but it doesn't always seem to happen, so I can do some more digging if you can give me some pointers.

That means something is weird with sourcemaps. Can you share a log? Set "trace": true in your node launch config, and it will write the log path in the debug console.

Here's the full log: vscode-node-debug2.txt
It does contain some paths similar to the issue linked above, but not sure if they're the issue (wasn't really sure what to search for).
[06:48:57.189 UTC] Could not map start position for: ../node_modules/diagnostic-channel-publishers/dist/src sync ^.*/lib/Connection$
[06:48:57.189 UTC] Could not map start position for: ../node_modules/diagnostic-channel-publishers/dist/src sync ^.*/lib/Pool$
[06:48:57.189 UTC] Could not map start position for: ../node_modules/diagnostic-channel-publishers/dist/src sync ^.*/lib/Connection$
[06:48:57.189 UTC] Could not map start position for: ../node_modules/diagnostic-channel-publishers/dist/src sync ^.*/lib/Connection$

Why do people do things like this, haha. Does this break debugging for you or is it just a random error that shows up?

I don't know where the paths are coming from, so I'm not sure they're doing. Does look weird though. The lines I gave look like an MS package: https://github.com/Microsoft/node-diagnostic-channel
I haven't noticed anything broken during debugging, but I couldn't be certain. Though I don't expect I'll need to debug through that package above!

I have the same issue. My project is using electron-forge with webpack. The issue only shows up if I add "node_modules/**/*.js" to the skipFiles property of the launch config in vscode. I'm at a loss of where to go to try and help provide any additional information to try and help with this issue.

There is a null entry in the sourcesContent array of a sourcemap we ship. FYI @digeff you might want to check that case too.

Verification steps

Open an extension to debug
Add a skipFiles expression to the launch config like:

"skipFiles": [
            "<node_internals>/**"
],

Start debugging the extension
Open a JSON file
Check that the error does not show up in the debug console


Cancel button on Integrate tab too aggressive

Integrate tab Cancel button reverts back to far when pressed. E.g., make a change to a Table binding table name property, then hit cancel:

Rather than simply reverting the textbox change, it boots you all the way out of the binding UI:

By design


Fix signature of jQuery.Each.

It has an integer as the first argument and an Element as the second.

Well, is more than the title suggests, but here we are.

We are reviewing and testing both commits right now, and should be able to accept the pull request right away.
These should also make it into Bridge 1.8.0.

Thank you very much for the contribution! Do you just giving Bridge.jQuery a try or developing something? Just curios about any feedback on how Bridge.jQuery is useful so far.

I'm using it to create an interface for managing gaming servers using bootstrap and jquery with bridge.net. Nothing serious.

Cool. When you are done If you allow ho have a look on the result, it would be great. Making an online Bridge "demo" would be fantastic:)


How to assign default value to a property once the validation fails

Hi
I am stuck with one usecase. I have a class named as Test
public class Test
{
public string State {get; set;}
}
I want to validate State such that if it is null then I need to assign some default value like "AA" else whatever value is provided by user.
is it possible to do in FluentValidation ? If yes , please let me know how I can achieve it

Hi, FluentValidation only performs validation on a pre-populated object, it doesn't modify/change the values of properties. You could technically do this with a custom validator that does the work, but I wouldn't really recommend it.

Thanks..


fix(net): Payload Conversion Utilities

Description
https://github.com/paradigmxyz/op-rs/pull/74 updates the networking crate to use upstream alloy execution payload types, converting those types into kona's L2ExecutionPayload.
These conversions are upstreamed in a pr currently. It's failing though since alloy-rpc-types-engine uses the standard library. This issue is to attempt to convert the alloy-rpc-types-engine crate to the no_std environment.
Additional Context
https://github.com/paradigmxyz/op-rs/pull/74#discussion_r1740102121

@refcell Does it mean changes in alloy-rpc-types-engine repo and remove the reference std?

@refcell Is my understanding correct? Or can you explain more?


Switch to executing via binder

Here's a working demo of "switching" between executing notebooks on GitHub Actions (what currently happens in the main branch of this repo) and executing via binderbot.
All we have to do is set execute_notebooks: binder in the _config.yml file, and make sure we're pointing to an appropriate binderhub.

I will merge this to see if anything weird happens like in https://github.com/ProjectPythiaCookbooks/cmip6-cookbook/pull/27


Add some hooks and apply them with separate CI

Various hooks I find useful https://github.com/paddyroddy/python-template/
Much like what we did in https://github.com/quantumjot/BayesianTracker/pull/67
Here I've also just run the hooks whilst I was at it

those typing suggestions pass mypy but haven't manually verified myself

mypy wasn't actually working but is now!


Orion benchmark documentation clarifications

In the Orion benchmark documentation:
In the Arguments section:

The distributed argument is incomplete:

distributed (bool): Whether to use dask for distributed computing. If not given,

The default of test_split is not specified:

test_split (bool or float): Whether to use the prespecified train-test split. If float, then it should be between 0.0 and 1.0 and represent the proportion of the signal to include in the test split. If not given, use False

Underneath the Arguments section, is this referring to _summarize_results function (not _summarize_results) ?

And returns a pandas.DataFrame which contains the scores obtained with each scoring function accross all the signals for each pipeline, optionally, you can follow that output with a summarize_results to average the scores and produce the leaderboard.

Thanks for the notes @skyeeiskowitz.

Definitely dropped some text here
The default value is False but I will clarify the difference between bool and float inputs.
Actually I was meaning to extract _summarize_results out of orion.benchmark and include it in a separate utils.py file under benchmark where we keep the leaderboard results. Right now it does not make sense to be part of the orion.benchmark because it's a summary table used for a specific case. I will update this soon.


⚠ AtmoLive03 Server has degraded performance

In 9cc4c6b, AtmoLive03 Server ($ATMOLIVE03) experienced degraded performance:

HTTP code: 200
Response time: 10729 ms

Resolved: AtmoLive03 Server performance has improved in e6dd72d.


[GHSA-r84p-88g2-2vx2] Link to affected artifacts

Same as #1766

Hey @raboof, unfortunately this CVE is specifically about the documentation of the software, and not the actual software itself. Since there is no code vulnerability to be patched, there is nothing for us to recommend users upgrade to.

The motivation here is that the documentation was specific to this component, so anyone integrating this component at that point might not have been aware of the all risks associated with running over any untrusted network. Indeed upgrading would not be sufficient, they would also have to review their use of the code.
It seems useful to flag this as a potential problem for anyone using those versions of the component, but if it's GHSA policy not to link to artifacts in such cases that's OK by me as well - closing this PR.


Add PyCharm into .gitignore

This Pull Request add .idea project settings into .gitignore file

global .gitignore ftw

jenkins/superCI comment

Status: failure, return code = 1
Result url: https://da.gd/NI6n
Comment: This is testing CI


Reschedule points are currently undocumented

Zephyr has never been good about documenting its schedule points, where a call to z_swap() (via the z_reschedule family of internal utilities) can be made and a new thread can be selected to run.  This complicates user analysis, especially in the case of cooperative/non-preemptible threads, and can lead to surprising behavior (see for example #20802, where a priority change due to mutex release is not immediately honored by the scheduler).
We should be rigorous about this and document all the circumstances under which each API can reschedule.  For example:

k_sem_take() will swap only on an empty semaphore
k_sem_give() will always reschedule, even if no other threads were waiting
k_mutex_unlock() will not swap, even if the priority changes (#20802)
k_pipe_put() will not swap, except if an async message is queued

And lots more...
The lack of documentation here is blocking work on existing code, so we really need to get this fixed.

As I have noted elsewhere this behavior appears to be inconsistent with the described behavior of cooperative threads which appears to specifically disallow a context switch on a mutex release of a blocked higher-priority thread.
The architectural description of cooperative thread behavior must be done before individual API descriptions can be annotated as part of #18970.
Removing assignment and priority so this can be discussed in triage tomorrow.

k_sem_give() will always reschedule, even if no other threads were waiting

As  @pabigot notes, this seems to be inconsistent with the diagram he links to assuming in the diagram the ISR is using k_sem_give() to make Thread 2 ready. Thoughts @andyross ?

k_sem_give() will always reschedule, even if no other threads were waiting

As @pabigot notes, this seems to be inconsistent with the diagram he links to

I think it's fine.  "reschedule" doesn't mean "force a context switch".  See https://github.com/zephyrproject-rtos/zephyr/pull/20919#issuecomment-561139198
To discuss but I think this issue can be closed as redundant with #18970, unless it turns out we can't define the behavior in terms of standard feature sets, in which case we can address it then.

API 2020-07-07: Closing as duplicate of #18970 which is the centerpoint of current plans to document API expectations.


Error 403 when running the Azure DevOps OWASP Extention

Describe the bug
Azure DevOps pipeline gives an 403 on the download step using the OWASP extension.
Version of dependency-check used
6.0.2
Log file
Starting: Run OWASP dependency check
Task         : OWASP Dependency Check
Description  : Checks your dependencies for known vulnerabilities.
Version      : 0.9.0
Author       : Info Support
Help         : Uses the OWASP dependency check cli tool to scan for known vulnerabilities. View the extension on the marketplace
Started execution of OWASP Dependency Check task
Installing owasp-dependency-check executable
Downloading: https://github.com/jeremylong/DependencyCheck/releases/download/v6.0.2/dependency-check-6.0.2-release.zip
##[error]Unexpected HTTP response: 403
Finishing: Run OWASP dependency check
To Reproduce
Steps to reproduce the behavior:

Install Azure DevOps extension
In your yaml pipeline add the extension and configure all required variables.
Run pipeline

Expected behavior
Pipeline should complete and the OWASP report should be generated.

I think you'll need to talk to the people maintaining the Azure DevOps extension for your feature request, notably @emjohn20 and https://github.com/dependency-check/azuredevops as listed in the contributors on that page
BTW that file download without problems for me

@mprins this appears to be a different integration in azure devops, created by the IT company info support (https://www.infosupport.com/).
https://marketplace.visualstudio.com/items?itemName=InfoSupport.infosupport-owasp-dependecy-checker&ssr=false#overview
But I see on the Q&A page of it that @divbasson is already in contact with them on the issue.


Fortran snippets

Hello and thank you for the snippets!
Is it possible to add to your list snippets for Fortran? I found these:
https://github.com/Gimly/vscode-fortran/blob/master/snippets/fortran.json
(Haven't checked if they work)
Thanks in advance

Sure they were added and tested, all snippets are working in fortran files. Thanks for contributing!


Clarify to need packageurl-js in example

Update package.json with cd example && npm install packageurl-js
--
This PR might be just a question.
The example of this repository and https://github.com/actions/go-dependency-submission/blob/9bdff38f6874dc21e2c3eeeaad61922c1fb23f33/package.json#L47 uses PackageURL as an exported class of https://github.com/package-url/packageurl-js.
So writing *-dependency-submission actions always need it, is this correct understanding? 👀

Hi! Thanks for you contribution.
Yes, this was an oversight on our end. Thank you for correcting it.
We considered creating a small wrapper around PackageURL and exporting the wrapper. Then, packageurl-js will not be needed.
I'll approve this now and plan for the wrapper. Thanks!

Thank you for letting me know! 🙏


Add prow env for beta integration test

This commit adds the prow env for beta integration test
Changes
/kind feature
fixes #5734

Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[x] Has Docs included if any changes are user facing
[n/a] Has Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[x] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
Adds pull-tekton-pipelines-beta-integration-test

cc @dibyom

Thanks Chitrang, could you help elaborate what do you mean by pick up the new environment?

Thanks Chitrang, could you help elaborate more about what do you mean by pick up the new environment?
If it's about what's under the beta tests, we might want to wait for #5579 and its follow-up as in #5706. As right now there're still features that have not been updated as beta yet eg. #5540 (comment)

Sorry, I was under the impression that some script has to trigger that environment (ie. set those fields). I think the prow cluster does that for us so might point is probably not valid.

/hold
Needs #5579

/kind misc

/retest

/test check-pr-has-kind-label

/retest

/remove-kind misc

/kind misc

/test check-pr-has-kind-label

/unhold since #5579 is merged

/unhold

I think this can now be merged?
cc @abayer @XinruZhang

We may need to hold this until https://github.com/tektoncd/plumbing/pull/1256 gets merged (and stop using the permenant link when referring to the new unit test), see https://github.com/tektoncd/pipeline/pull/5737#discussion_r1028532106
/hold

We may need to hold this until tektoncd/plumbing#1256 gets merged (and stop using the permenant link when referring to the new integration test), see #5737 (comment)
/hold

I think it should be the other way around. Before we merge the plumbing PR, we should have this in place. Otherwise, if jobs are triggered, the prow config will not have anything to point to in the pipeline repo until this is merged.

We may need to hold this until tektoncd/plumbing#1256 gets merged (and stop using the permenant link when referring to the new integration test), see #5737 (comment)
/hold

I think it should be the other way around. Before we merge the plumbing PR, we should have this in place. Otherwise, if jobs are triggered, the prow config will not have anything to point to in the pipeline repo until this is merged.

I see, sounds good, then at least let's add the link referring to the new integration test after this PR and https://github.com/tektoncd/plumbing/pull/1256 both merged. (Simply because the current link is wrong)

Agree with @chitrangpatel also agree with fixing the broken link :D

/lgtm

@JeromeJu, @XinruZhang can we cancel the hold here?

@JeromeJu, @XinruZhang can we cancel the hold here?

/unhold


⚠ ClamAV has degraded performance

In 5ff94cb, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 67 ms

Resolved: ClamAV performance has improved in a31deed.


Left-Sidebar: Empty unread counts now hidden by visibiliy:hidden

Hiding empty counts currently uses "display: none," but this clashes with using "display: flex" to center the text in the unread count vertically. To avoid problems, I've changed "display: none" to "visibility: hidden" instead for empty or zero counts.
Fixes: #27567

Screenshots and screen captures:

Before
After

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

I haven't pulled this down yet to poke at it, but do we have need of selectors or JavaScript that sets these to visiblity: visible?

Also, this fixes only part of #26567, so please phrase it that way in your PR text...we don't want GitHub closing the issue, should this be merged.

Closing, as https://github.com/zulip/zulip/issues/27567 isn't really intended for contributors (but instead a TODO list task for planned refactoring by @karlstolley, and it's not clear to me how to quickly verify this is correct without doing the rest of the issue). Thanks for the work on this @nimishmedatwal!


Security issue: $interpolate / $parse allows access to constructor

https://github.com/angular/angular.js/blob/ff963de73ab8913bce27a1e75ac01f53e8ece1d9/src/ng/parse.js#L1792
// Translation key containing malicious code
scope.translationKey = "{{constructor.constructor('alert(document.cookie)')()}}"

{{ translationKey | translate }}

The best workaround I have found so far is $parseProvider.addLiteral("constructor", null) but this doesn't feel right to me.

It is the developer's responsibility to ensure that the content that ends up in Angular expressions (and thus parsed by the $parse service) is sanitized. There used to be an "expression sandbox" trying to prevent accidental access to arbitrary JavaScript code and to discourage business logic from appearing in templates, but it was never supposed (nor able) to be a full-proof security mechanism.
The Angular expression sandbox has been removed in v1.6; you can read more about it in this blog post and the security guide.


ADHD200 - mismatch between numbers of participants and participants.tsv

$ ls RawDataBIDS/*/sub-*/ses-?/anat/*T1w.nii.gz  | wc -l
     960

and if i get the participants.tsv and simply concatenate them
$ find . -name "participants.tsv" | xargs cat | wc -l
     574

suggesting that about 400 participants are not indexed in the participants.tsv.
i'm using datalad to get these files
cc/ @yarikoptic @dbkeator
@ccraddock - let us know who could fix these things assuming they are an issue.

which dataset are we talking about? ADHD200 seems to not carry participants.tsv and all split per site:
$> datalad ls s3://fcp-indi/data/Projects/ADHD200/RawDataBIDS/
Connecting to bucket: fcp-indi
[INFO   ] S3 session: Connecting to the bucket fcp-indi with authentication
Bucket info:
  Versioning: S3ResponseError: 403 Forbidden
     Website: S3ResponseError: 403 Forbidden
         ACL: S3ResponseError: 403 Forbidden
data/Projects/ADHD200/RawDataBIDS/Brown/
data/Projects/ADHD200/RawDataBIDS/KKI/
data/Projects/ADHD200/RawDataBIDS/KKI_1/
data/Projects/ADHD200/RawDataBIDS/KKI_2/
data/Projects/ADHD200/RawDataBIDS/NYU/
data/Projects/ADHD200/RawDataBIDS/NeuroIMAGE/
data/Projects/ADHD200/RawDataBIDS/OHSU/
data/Projects/ADHD200/RawDataBIDS/Peking_1/
data/Projects/ADHD200/RawDataBIDS/Peking_2/
data/Projects/ADHD200/RawDataBIDS/Peking_3/
data/Projects/ADHD200/RawDataBIDS/Pittsburgh/
data/Projects/ADHD200/RawDataBIDS/Pittsburgh_Test/
data/Projects/ADHD200/RawDataBIDS/WashU/
data/Projects/ADHD200/RawDataBIDS/du_1/
data/Projects/ADHD200/RawDataBIDS/mta_1/
data/Projects/ADHD200/RawDataBIDS/nyu_1/

there is a participants.tsv per site.

d'oh - didn't spot that there was find . for those files.

indeed no consistency between participants and sub- subdirectories for any site besides Peking_2,3:
$> for s in *; do echo $s; grep '^[0-9]' $s/part*.tsv | wc -l; /bin/ls -ld $s/sub-* | wc -l ;done
Brown
52
26
KKI
22
83
NeuroIMAGE
50
73
NYU
82
263
OHSU
68
113
Peking_1
102
136
Peking_2
67
67
Peking_3
42
42
Pittsburgh
18
98
WashU
61
60

FWIW, recrawled those subdatasets -- no changes in the bucket

in ADHD200 this is the only mprage file: ['RawData/Peking_3/1404738/session_1/anat_1/mprage.nii.gz'] that doesn't have a correspondence in RawDataBIDS.
the good news is that all participant ids match between BIDS and RawData. so the participants.tsv is simply missing a lot of info. we are going to pull the info the RawData phenotype files.

these phenotypic csv's for rawdata are missing from the s3 bucket
Peking_2_phenotypic.csv
Peking_3_phenotypic.csv


Michael/getting started

Expands README
Adds set up scripts
Adds example notebook

TODO:

This relies on the current implementation of the Census data

Plan is to refactor functions into another script
The getting started notebook will likely need modification upon this change

The readme and setup changes look good.
I'm not familiar with how Jupiter Notebook works. Does example.ipynb actually contain data or does it just point to data somewhere else?

It runs code in cells. Github actually displays the format pretty well on the file's page


Separate Repositories

Infra-Risk-Vis repository can be split into seperate repos for Backend API, UI and ETL.  This could have the following benefits amoungst others:

Easier to pickup for developers / PR's etc
Easier containerised builds
Potential for simpler deployment to AWS services directly from repos
Easier to integrate into CI/CD pipelines.

[x] irv-autopkg for extract API and workers
[x] irv-frontend for React/Typescript frontend and static server
[ ] irv-backend - to discuss: currently in containers/backend API over DB queries and serving raster tiles using terracotta as library
[ ] irv-vector-tileserver - to discuss: currently in containers/vector, container config building on tileserver-gl
[ ] ETL - to discuss: currently in etl, but with some related functionality in nismod/open-gira and irv-autopkg


ATF is unable to establish mobile connection in Remote mode

After merge of https://github.com/smartdevicelink/sdl_atf/pull/181 Remote Connection functionality became broken.
ATF is unable to establish mobile connection:
[11:24:40,588] Update_Preloaded_PT                                               [SUCCESS] (542 ms)
SDL started
HMI initialized
HMI is ready
Error: TCP Connection not established during 7000 ms
Operation now in progress
[11:24:43,256] Start_SDL__HMI__connect_Mobile                                    [FAIL] (12069 ms)

Closed via #194


Missing datasets in example

example/mem_test.py and all scripts in examples/real_data searches for datasets in <..>/Auto-PyTorch/datasets/ which are not there and thus fail.
FileNotFoundError: File b'/home/eggenspk/Work/git/Auto-PyTorch/datasets/classification/dataset_28_optdigits.csv' does not exist
This is not a critical problem, but the datasets could be downloaded automatically when run for the first time.

Hello! This problem has been fixed and our examples are rendering nicely in our web page here:
https://automl.github.io/Auto-PyTorch/development/examples/index.html
Thanks for reporting. I am closing this issue as it seems to be resolved.


Seeking views of administrators on proposal to expose audiobook keywords and promote exploration of our catalog via keyword hyperlinks

redrun has suggested to me that before creating any signifcant pull request, it would be a good idea if I were to put what I have in mind before administrators to get their views on whether the proposed change makes sense at all, or perhaps makes sense in principle, but requires modification. I think this is a most reasonable suggestion, but am not sure by what mechanism I should make any such approach.
I have attached a PDF file which I hope shows pretty clearly, at a GUI level at least, what I have in mind, with screenshots taken on my local development environment.
I'd be interested in the thoughts of all stakeholders. If nothing else, I've learned a hell of a lot by exploring this question. If this doesn't go anywhere, I've at least got that to hang onto!
Proposal to expose keyterms to catalog users 2024 03 19.pdf

Personally, I like this a lot.  As for consensus: discussion has just begun.  Public discussion here, and admins will probably have an internal discussion as well.
On a purely technical note (else I'd post it in the linked forum thread), I think we could benefit from counting up the projects that use each keyword with a cron job, just like we do with authors and genres.
It would grow our database, but I think it would still be much faster than cross-referencing and counting projects on page load.  Worth testing!

Thank you! This is a great example of why it’s good to get other people’s perspectives. I had not given any consideration at all to performance issues, and certainly not to this elegant potential solution.
I did a bit of hunting around today for some kind of off-the-shelf load testing application and came across locust, which seems to fit the bill nicely for this use case. Sadly, however, locust is unable to issue a successful GET to any page on my local Apache server because of the dreaded SSL certificate issue, which none of the workarounds I have read about online this afternoon seem to address successfully anymore. I can see locust’s requests in the Apache access log, where they all show up with a 301 return code, while locust itself reports the result of every GET as “SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self-signed certificate (_ssl.c:1007)'))”. That’s a pity, because it looks like locust is a really brilliant tool.
Best wishes,
Peter Dann

On 20 Mar 2024, at 3:27 am, redrun45 @.***> wrote:
Personally, I like this a lot. As for consensus: discussion has just begun. Public discussion here https://forum.librivox.org/viewtopic.php?p=2310123#p2310123, and admins will probably have an internal discussion as well.
On a purely technical note (else I'd post it in the linked forum thread), I think we could benefit from counting up the projects that use each keyword with a cron job, just like we do with authors and genres https://github.com/LibriVox/librivox-catalog/blob/master/application/controllers/cron/Project_status_stats.php.
It would grow our database, but I think it would still be much faster than cross-referencing and counting projects on page load. Worth testing!
—
Reply to this email directly, view it on GitHub https://github.com/LibriVox/librivox-catalog/issues/210#issuecomment-2007627314, or unsubscribe https://github.com/notifications/unsubscribe-auth/APUJ53H43FADGUF6KB74QIDYZBRONAVCNFSM6AAAAABE42RKFWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBXGYZDOMZRGQ.
You are receiving this because you authored the thread.

If you're writing your own 'locustfile' test specs, this might be of use.  Apparently, you can use the same options as this module.
Without trying it myself:
.get('https://librivox.org/<your query>', verify=False)
... ought to help with that SSL verification.

Suggestion from redrun45 proved to be a lifesaver. Tbank you!
I have now run load tests with locust against three scenarios:
Baseline (main branch, untouched)
Version of code that calculated keyword usage dynamically at runtime
Version of code that reads usage statistics from keywords table that are presumed to be updated by a cron job, but which I have, for now, updated manually using the same SQL that would be used in any putative cron job
I have attached in a zip file reports from all three runs, together with the locust file I used for these tests.
In brief, the results show the following average response times on my local machine under the test conditions I set up:
Baseline (no code changes): 491 ms
Precalculated statistics: 484 ms
Dynamically calculated statistics: 816 ms
At face value, anyway, this suggests to me that we could display keywords to catalog users with no discernible degradation of server performance provided we kept the keyword usage statistics updated with a cron job, rather than calculating them each time on the fly.
I'm no expert in load testing. If the test conditions I've used here do not appear to be sufficiently rigorous, please let me know.
locust file and load test reports.zip

That's a pretty massive hit for dynamic statistics. We could always go with the Cron job, but I'm curious what the SQL to calculate those was, and whether it can be made faster by adding foreign keys and/or indexes to our schema.

Good point.
I have used the following SQL for a dynamic count of the number of instances where a keyword is in use. As you can see, it performs a join involving project_keywords.keyword.id. This column, however, is not currently indexed in the database.
    SELECT keywords.id, keywords.value, sub.keyword_count
    FROM keywords
    JOIN project_keywords
    ON keywords.id = project_keywords.keyword_id
    JOIN (SELECT keyword_id,
           COUNT(project_id) AS keyword_count
           FROM project_keywords
           GROUP BY 1
           ) sub
    ON keywords.id = sub.keyword_id
    WHERE project_keywords.project_id = ?
    ORDER BY sub.keyword_count DESC'

It would certainly be a good idea to establish a foreign key relationship between project_keywords.keyword_id and keywords.id.
My first attempt to set one up was frustrated by the fact that there are 1910 instances where project_keywords.keyword_id = 0. I needed to delete these before I could set up a foreign key on this column. I then set up an index on. project_keywords.keyword_id.
Used the following SQL through these adventures:
SELECT keyword_id from project_keywords where keyword_id NOT IN (select id from keywords);
===
DELETE from project_keywords where keyword_id < 1;
===
ALTER TABLE project_keywords
ADD CONSTRAINT FOREIGN KEY (keyword_id) REFERENCES keywords(id)
ON DELETE CASCADE;
===
CREATE INDEX keyword_id
ON project_keywords(keyword_id);
After making these DB changes, I ran my version of the code that counts keyword instances at runtime (ie, no cron job updating required) I ran the same load test I used previously, and this time got an average response time of 546 ms.
I have attached this load test report.
05 load test using dynamically calculated counts of keyword usage after indexing previously unindexed column in project_keywords table.html.zip

After sleeping on it, realised that logically there should also be a foreign key relationship between project_keywords and projects table. Set this up:
ALTER TABLE project_keywords
ADD CONSTRAINT FOREIGN KEY (projects_id) REFERENCES projects(id)
ON DELETE CASCADE;
After making this further DB change, ran the same load test again, this time getting an average response time of 571 ms.
I have attached this load test report.
06 load test using dynamicallly calculated counts of keyworkd usage after additionaly settin up foreign key relationship between project_keywords and projects tables.html.zip

We've kicked this back and forth and not had any objections, other than to changing the 'keyword' term to 'keyterm'.  When the PR is ready, I'll be glad to test it, and we might also want this on the staging server for other admins.  😄


Hidding the footer?

loving this directive but i must be missing something simple here. how do i configure the footer to be hidden by default?

Exactly, but in case others might need the same answer, here is a solution:
CSS:
table.hide-footer > tfoot {
    visibility: hidden;
    display: none;
}

HTML:
<table tr-ng-grid class="hide-footer">


Continuous Integration (GitHub Action) is not doing what you think it is.

Describe the bug
Hey, just a random GitHub action enthusiast that stumbled on your codebase.
There's an incorrect reference in the node-version usage to your strategy.matrix causing it to silently fail and use the incorrect node version without any indication.
To Reproduce
Steps to reproduce the behavior:

Make a PR to main
Take a look at the GitHub action runner logs.

Expected behavior
I would expect the GitHub actions to run on all permutations of the provided matrix of operating systems and node versions (13/14).
Actual behavior
At the time of writing, this is the action I'm talking about: https://github.com/xlayers/xlayers/blob/9651446b8c4e501d92f47c563196f043bd86194c/.github/workflows/pr_on_development.yml
The node-version matrix is set, however, the action uses matrix.node and that's undefined, causing the setup of Node to always be in the wrong version.
Code Sample for reference - (L18 node-version is set, L20 & L23 (second reference) node is used.
https://github.com/xlayers/xlayers/blob/9651446b8c4e501d92f47c563196f043bd86194c/.github/workflows/pr_on_development.yml#L15-L23
This is also verifiable by seeing that a version is not applied in the name of the step, as the action is instructed to do.
https://github.com/xlayers/xlayers/blob/9651446b8c4e501d92f47c563196f043bd86194c/.github/workflows/pr_on_development.yml#L20
Screenshots
Node version 13.x should be set, but it is running on 14.x.

Additional context
Simply changing all strategy.matrix.node-version instances to strategy.matrix.node does the trick. BE CAREFUL THOUGH, you can't do a complete find-and-replace because the actions/setup-node@v1 input does expect node-version.

There's also another issue but I won't be checking the scope of this.
https://github.com/xlayers/xlayers/blob/9651446b8c4e501d92f47c563196f043bd86194c/.github/workflows/pr_on_development.yml#L70-L100
On your test job your final step is named Run lint rather than Run tests, I assume it's just an oversight from some quick code duplication.

Hi @pqt, thank you for pointing this out to us. I just created a draft PR #400 to handle this issue.
Thank you for creating this issue.

No problem! Love the way the steps were actually separated and I learned about the needs key in the process so thanks for that! It seemed only fair that I pointed out the issues I found when I put the action under the microscope.


ViewPropTypes deprecated react-native-hms-map

Description
ViewPropTypes deprecated react-native-hms-map.  Migrate to ViewPropTypes exported from 'deprecated-react-native-prop-types'.
Expected behavior
All good
Current behavior
Error
Screenshots
If applicable, add screenshots to help explain your issue
Logs
Error: Requiring module<EMAIL_ADDRESS>which threw an exception: Invariant Violation: ViewPropTypes has been removed from React Native. Migrate to ViewPropTypes exported from 'deprecated-react-native-prop-types'.
Environment
"@hmscore/react-native-hms-map": "^6.3.1-305",
"react-native": "0.69.3",
Other
Add any other context about the problem here

https://github.com/HMS-Core/hms-react-native-plugin/pull/243


Updates to the CLI commands reference

Since I was going to respond to a customer feedback given on LiveFyre who noticed an example using dotnet compile in our docs, I took the opportunity to also address the following issues for this set of topics which I've been wanting to do for a while now:

#1083
#808
formatting issues
changed the order of the example explanation
added missing options (such as --help for all commands, dotnet-publish was missing a bunch, and so forth)

/cc @blackdwarf @piotrpMSFT can one of you please help review this?

Open Publishing Build Service: The pull request content has been published and here are some changed files links of this time:

Docset 1 - core-docs
https://review.docs.microsoft.com/en-us/dotnet/articles/core/tools/dotnet-build?branch=pr-en-us-1129
https://review.docs.microsoft.com/en-us/dotnet/articles/core/tools/dotnet-install-script?branch=pr-en-us-1129
https://review.docs.microsoft.com/en-us/dotnet/articles/core/tools/dotnet-new?branch=pr-en-us-1129
Please see 7 more published files of this docset in report.

Status: SucceededWithWarning. Message: Warning occurred: Invalid file link:(~/docs/core/tools/project-json,md). Referenced by file: docs/core/tools/dotnet-build.md at line: 73...
Open Publishing Report.

Open Publishing Build Service: The pull request content has been published and here are some changed files links of this time:

Docset 1 - core-docs
https://review.docs.microsoft.com/en-us/dotnet/articles/core/tools/dotnet-build?branch=pr-en-us-1129
https://review.docs.microsoft.com/en-us/dotnet/articles/core/tools/dotnet-install-script?branch=pr-en-us-1129
https://review.docs.microsoft.com/en-us/dotnet/articles/core/tools/dotnet-new?branch=pr-en-us-1129
Please see 7 more published files of this docset in report.

Status: SucceededWithWarning. Message: Warning occurred: Invalid file link:(~/docs/core/tools/project-json,md). Referenced by file: docs/core/tools/dotnet-build.md at line: 73...
Open Publishing Report.

Open Publishing Build Service: The pull request content has been published and here are some changed files links of this time:

Docset 1 - core-docs
https://review.docs.microsoft.com/en-us/dotnet/articles/core/tools/dotnet-build?branch=pr-en-us-1129
https://review.docs.microsoft.com/en-us/dotnet/articles/core/tools/dotnet-install-script?branch=pr-en-us-1129
https://review.docs.microsoft.com/en-us/dotnet/articles/core/tools/dotnet-new?branch=pr-en-us-1129
Please see 7 more published files of this docset in report.

Status: Succeeded.
Open Publishing Report.

Thanks @svick. I appreciate the feedback. I believe I took care of all your comments except the link to NuGet version guidelines which I don't know yet if we have such a topic.

Open Publishing Build Service: The pull request content has been published and here are some changed files links of this time:

Docset 1 - core-docs
https://review.docs.microsoft.com/en-us/dotnet/articles/core/tools/dotnet-build?branch=pr-en-us-1129
https://review.docs.microsoft.com/en-us/dotnet/articles/core/tools/dotnet-install-script?branch=pr-en-us-1129
https://review.docs.microsoft.com/en-us/dotnet/articles/core/tools/dotnet-new?branch=pr-en-us-1129
Please see 7 more published files of this docset in report.

Status: Succeeded.
Open Publishing Report.

Open Publishing Build Service: The pull request content has been published and here are some changed files links of this time:

Docset 1 - core-docs
https://review.docs.microsoft.com/en-us/dotnet/articles/core/tools/dotnet-build?branch=pr-en-us-1129
https://review.docs.microsoft.com/en-us/dotnet/articles/core/tools/dotnet-install-script?branch=pr-en-us-1129
https://review.docs.microsoft.com/en-us/dotnet/articles/core/tools/dotnet-new?branch=pr-en-us-1129
Please see 7 more published files of this docset in report.

Status: Succeeded.
Open Publishing Report.

Open Publishing Build Service: The pull request content has been published and here are some changed files links of this time:

Docset 1 - core-docs
https://review.docs.microsoft.com/en-us/dotnet/articles/core/tools/dotnet-build?branch=pr-en-us-1129
https://review.docs.microsoft.com/en-us/dotnet/articles/core/tools/dotnet-install-script?branch=pr-en-us-1129
https://review.docs.microsoft.com/en-us/dotnet/articles/core/tools/dotnet-new?branch=pr-en-us-1129
Please see 7 more published files of this docset in report.

Status: Succeeded.
Open Publishing Report.

@BillWagner good to go?

Good to go.  :shipit: now.


One-shot methods

It makes sense to also provide plotting methods which internally construct the plotter and throws it away instantly, for convenience.

function Makie.convert_arguments(P::Type{<:SolutionPlot}, dh::{<:AbstractDofHandler}, u::Vector)
    return (MakiePlotter(dh,u),)
end

etc


GetAzureADMSGroup does not return MembershipRules in a dynamic group

According to the documentation in the link https://docs.microsoft.com/en-us/powershell/module/azuread/get-azureadmsgroup?view=azureadps-2.0, We can expect the below details when we use the Get-AzureADMSGroup command.
MembershipRule                :(Membership rule)
MembershipRuleProcessingState : On
But when I used the below command, I got the below mentioned result without any MembershipRule attribute/property. Is the below expected?
Command
$GroupData = Get-AzureADMSGroup -Id "(Id of the group from Azure AD)"
Write-Host $GroupData
Result
class MsGroup {
Id: (Id of the group from Azure AD)
OdataType:
Description:
OnPremisesSyncEnabled:
DisplayName: (Displayname of the group)
OnPremisesLastSyncDateTime:
Mail:
MailEnabled: False
MailNickname: (MailNickName)
OnPremisesSecurityIdentifier:
ProxyAddresses: System.Collections.Generic.List1[System.String]   SecurityEnabled: True   GroupTypes: System.Collections.Generic.List1[System.String]
Visibility:
CreatedDateTime: 3/12/2019 1:07:51 PM
RenewedDateTime: 3/12/2019 1:07:51 PM
}

MembershipRule is currently only supported in AzureADPreview module not the AzureAD module.  Thank you.


Reusable workflow

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-72.8%) to 0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-72.8%

Covered Lines:
0

Relevant Lines:
0

💛  - Coveralls


AppImage Build

Can be used to provide portability
Issue: https://github.com/aldelaro5/Dolphin-memory-engine/issues/80

Lastly, regarding

https://github.com/aldelaro5/Dolphin-memory-engine/issues/80
This is not actually related to #80, that is to add an extra option for User / System scope.
I didn't have an issue open for AppImage at the time.

FYI, pipeline failing. Let me know if you dont have access

Run .github/assets/appimage.sh
/home/runner/work/_temp/99cef56d-a49b-4256-a0cc-d88e96d18449.sh: line 1: .github/assets/appimage.sh: Permission denied
Error: Process completed with exit code 126.

I didn't have the exec bit set on appimage.sh, and I had pushed the fix, but guess it didn't take it. I can set it again and push all as a single commit,  or individually with the requested changes.

I didn't have the exec bit set on appimage.sh, and I had pushed the fix, but guess it didn't take it. I can set it again and push all as a single commit, or individually with the requested changes.

Either is fine, though generally I prefer single commits.

Now that it has a merge commit in it though, it may be hard to correct without redoing the changes or cherry-picking your specific commits. Sorry for the hassle, if you want I can just do this before merging.

Yes please fix,  I am on mobile for now. I can rebase properly when I have a chance.

Tested it, it looks like the icon does not work but everything else works.
You mentioned we should probably use ubuntu 20.04 as a builder. Does that increase compatibility with certain systems or something? If yes, I'm fine changing it.

The lower libc requirement increases compatibility, but after rethinking, there are 6 months left on that LTS, it is easier to leave on the current build image (22.04).
Will look at the icon.

Update, my mistake the icon is working with the final version merged.
Was my system cache.
Thanks for all your effort! @qurious-pixel

[...], there are 6 months left on that LTS, it is easier to leave on the current build image (22.04).

If we were talking about Ubuntu 20.04 LTS, official support ends in April 2025; that's 17 months from now. And then there is a period of security updates for another 5 years.
Unsure how easy it'd be to get Qt 6 on Ubuntu 20.04 in GitHub Actions, though.

If we were talking about Ubuntu 20.04 LTS, official support ends in April 2025; that's 17 months from now. And then there is a period of security updates for another 5 years.
Unsure how easy it'd be to get Qt 6 on Ubuntu 20.04 in GitHub Actions, though.

Yes, you are right, I had miscounted 4 years, instead of 5.
On the CI, I can get support for QT6 fairly easily. It will be more difficult with the package manager, because the backports are not often updated. Ubuntu 18.04 had an issue, because the precompiled used a later libc version that was incompatible, requiring 60GBs to compile the package.
Qt6 support, libc version, and old enough compiler (something available on the latest point release of the supported system) are usually the factors to consider.

If the official precompiled binaries from the Qt Online Installer are available for direct download (are they?), they should work with Ubuntu 20.04, which uses glibc 2.31; the precompiled binaries (GCC x64) in Qt 6.5.3 are compiled against glibc 2.28.

On the CI, I can get support for QT6 fairly easily. [...]

Are there APT-based repositories that could be used in Ubuntu 20.04? Or do you have another source in mind?

Ubuntu 18.04 was glibc 2.27, so it was not so easy to upgrade to Qt6.
Ubuntu Focal PPA:
sudo add-apt-repository ppa:rncbc/qt6.6-static-focal
sudo apt update

The CI could use a Github Action
    - name: Install Qt
      uses: jurplel/install-qt-action@v3
      with:
        aqtversion: '==3.1.*'
        version: '6.6.0'
        host: 'linux'
        target: 'desktop'
        arch: 'gcc_64'

I was hoping we would go as far as Ubuntu 20.04. Are you aiming for Ubuntu 18.04?


Create project component classes

Created a folder for project and added to it classes for project and its components.
Some notes: For now, Project has String for Client and Issue components but this should be edited later on. Unsure how to validate repository input. Please look through for me thanks.

Codecov Report

Merging #62 (d7331a3) into master (63f55e8) will decrease coverage by 1.82%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master      #62      +/-   ##
============================================
- Coverage     72.15%   70.33%   -1.83%
  Complexity      399      399
============================================
  Files            70       74       +4
  Lines          1232     1264      +32
  Branches        125      125
============================================
  Hits            889      889
- Misses          311      343      +32
  Partials         32       32

Impacted Files
Coverage Δ

...ain/java/seedu/address/model/project/Deadline.java
0.00% <0.00%> (ø)

...rc/main/java/seedu/address/model/project/Name.java
0.00% <0.00%> (ø)

...main/java/seedu/address/model/project/Project.java
0.00% <0.00%> (ø)

...n/java/seedu/address/model/project/Repository.java
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


docs: update Cloud API reference location

Fixes: https://github.com/googleapis/nodejs-pubsub/issues/1536

Still no idea on why that flaky test is flaky... it's like it's pulling a non-deterministic package.


Wrong Report: This Function is empty

As seen above, the function is considered as empty when it returns 'hello'.
This is not related to the async async, running it on:
// Hello.
//
// This is JSHint, a tool that helps to detect errors and potential
// problems in your JavaScript code.
//
// To start, simply enter some JavaScript anywhere on this page. Your
// report will appear on the right side.
//
// Additionally, you can toggle specific options in the Configure
// menu.

console.log(async dude => 'hello');

Gives the same report:
Metrics

There is only one function in this file.

It takes one argument.

This function is empty.

Cyclomatic complexity number for this function is 1.

Thanks for the report! It looks like the async keyword is a bit of a red herring. JSHint will report any arrow function with a "conise" body (asynchronous or not) as "empty," when it's more appropriate to say that it has one statement.
() => 0;

I'm marking this as low-priority because I doubt it's apparent beyond the graphical user interface of jshint.com. @Yash-Singh1 (or anyone else): if this is somehow interfering with your use of JSHint, then please say a little more, and we can re-prioritize.

Thanks for the report! It looks like the async keyword is a bit of a red herring. JSHint will report any arrow function with a "conise" body (asynchronous or not) as "empty," when it's more appropriate to say that it has one statement.
() => 0;

I'm marking this as low-priority because I doubt it's apparent beyond the graphical user interface of jshint.com. @Yash-Singh1 (or anyone else): if this is somehow interfering with your use of JSHint, then please say a little more, and we can re-prioritize.


release(xena): update snapcraft.yaml

Automated changes by create-pull-request GitHub action

closing, we should cleanup the stable branches first


The nDCG formula may not consistent between your paper and implementation?

Hello, I read your paper(TOIS) and your implementation.
I have a question about your implementation of the formula of nDCG.
In your paper, you write the formula of nDCG using log2 (logarithmic base is 2), but in your implementation I think you use np.log (logarithmic base is natural logarithm). (c.g., L209 or L303 in code/ENMF.py)
Should you use np.log2 in your implementation for consistency?
Anyway, thank you for putting together a good paper and implementation!

This is a very easy transformation:
logM N=loga M/loga N

opps, I understand. Thank you.


About the dataset

The Json file only mentions FFHQ as the training set and CelebaHQ as the verification set. For example, FFHQ 128 as the training set. Do we need to find the CelebaHQ 128 verification set by ourselves? What is the role of the CelebaHQ512 and 1024 you provided, and then for example 16 or 64 low-resolution images how to get it

There are only one image in CelebaHQ128 folder in this repo for model validation. I found this leads to unstable PSNR and maybe we need to prepare whole dataset by ourselves?

A picture in the folder is just an example. The validation set needs to be prepared according to the process in README.


Feature/minerl version drop

dropped version in conftest
updated observation space in wrappers and feature extraction layers
updated dockerfile


The comments part should not set the breakpoint in ps1 file

Open the ps1 file in PowerShell project.
Add some breakpoint in comments part

Expect: The comments part should not set some breakpoints.
Actual:

Thanks for reporting this, #75


how to test and run it for a newbie?

Make sure you can see the pwm board on your RPi. See the following page, section "Testing I2C":
https://learn.adafruit.com/adafruits-raspberry-pi-lesson-4-gpio-setup/configuring-i2c#testing-i2c-2724591-14
For example, running the command like: sudo i2cdetect -y 1
leon@leon-desktop:~$ sudo i2cdetect -y 1
[sudo] password for leon:
Error: Could not open file /dev/i2c-1' or /dev/i2c/1': No such file or directory
leon@leon-desktop:~$
Also, you are running the i2cpwmboard on the raspberry pi right? And not on your PC?
pi b3
roslaunch servo_move_keyboard keyboard_move.launch
...
setting /run_id to c3180844-941a-11eb-b0be-b827eb8897a3
process[rosout-1]: started with pid [3482]
started core service [/rosout]
process[servo_move_keyboard_node-2]: started with pid [3485]
[INFO] [1617412834.089777]: > Servos corrrectly initialized
[INFO] [1617412834.107231]: > Publisher corrrectly initialized
[INFO] [1617412834.116593]: Initialization complete
Servo Control Module for 12 Servos.
Enter one of the following options:
quit: stop and quit the program
oneServo: Move one servo manually, all others will be commanded to their center position
allServos: Move all servo's manually together
Keyboard commands for One Servo Control
q                y
f   g       j   k
z   x       b   n   m
q: Quit current command mode and go back to Option Select
z: Command servo min value
y: Command servo center value
x: Command servo max value
f: Manually decrease servo command value by 10
g: Manually decrease servo command value by 1
j: Manually increase servo command value by 1
k: Manually increase servo command value by 10
b: Save new min command value
n: Save new center command value
m: Save new max command value
anything else : Prompt again for command
CTRL-C to quit
Command?:
I don't know how to choose the server number or load the parameter.
Is there a link?

3 command total
No. 1:
roslaunch spot_micro_motion_cmd motion_cmd.launch run_standalone:=true
started roslaunch server http://leon-desktop:46693/
SUMMARY
PARAMETERS

/rosdistro: melodic
/rosversion: 1.14.10
/spot_micro_motion_cmd_node/LB_1/center: 306
/spot_micro_motion_cmd_node/LB_1/center_angle_deg: -0.4
/spot_micro_motion_cmd_node/LB_1/direction: -1
/spot_micro_motion_cmd_node/LB_1/num: 9
/spot_micro_motion_cmd_node/LB_1/range: 374
/spot_micro_motion_cmd_node/LB_2/center: 306
/spot_micro_motion_cmd_node/LB_2/center_angle_deg: 38.7
/spot_micro_motion_cmd_node/LB_2/direction: 1
/spot_micro_motion_cmd_node/LB_2/num: 8
/spot_micro_motion_cmd_node/LB_2/range: 392
/spot_micro_motion_cmd_node/LB_3/center: 306
/spot_micro_motion_cmd_node/LB_3/center_angle_deg: -73.9
/spot_micro_motion_cmd_node/LB_3/direction: 1
/spot_micro_motion_cmd_node/LB_3/num: 7
/spot_micro_motion_cmd_node/LB_3/range: 390
/spot_micro_motion_cmd_node/LF_1/center: 306
/spot_micro_motion_cmd_node/LF_1/center_angle_deg: -7.6
/spot_micro_motion_cmd_node/LF_1/direction: 1
/spot_micro_motion_cmd_node/LF_1/num: 12
/spot_micro_motion_cmd_node/LF_1/range: 389
/spot_micro_motion_cmd_node/LF_2/center: 306
/spot_micro_motion_cmd_node/LF_2/center_angle_deg: 38.6
/spot_micro_motion_cmd_node/LF_2/direction: 1
/spot_micro_motion_cmd_node/LF_2/num: 11
/spot_micro_motion_cmd_node/LF_2/range: 397
/spot_micro_motion_cmd_node/LF_3/center: 306
/spot_micro_motion_cmd_node/LF_3/center_angle_deg: -82.8
/spot_micro_motion_cmd_node/LF_3/direction: 1
/spot_micro_motion_cmd_node/LF_3/num: 10
/spot_micro_motion_cmd_node/LF_3/range: 387
/spot_micro_motion_cmd_node/RB_1/center: 306
/spot_micro_motion_cmd_node/RB_1/center_angle_deg: -4.4
/spot_micro_motion_cmd_node/RB_1/direction: 1
/spot_micro_motion_cmd_node/RB_1/num: 6
/spot_micro_motion_cmd_node/RB_1/range: 411
/spot_micro_motion_cmd_node/RB_2/center: 306
/spot_micro_motion_cmd_node/RB_2/center_angle_deg: -35.4
/spot_micro_motion_cmd_node/RB_2/direction: 1
/spot_micro_motion_cmd_node/RB_2/num: 5
/spot_micro_motion_cmd_node/RB_2/range: 396
/spot_micro_motion_cmd_node/RB_3/center: 306
/spot_micro_motion_cmd_node/RB_3/center_angle_deg: 85.8
/spot_micro_motion_cmd_node/RB_3/direction: 1
/spot_micro_motion_cmd_node/RB_3/num: 4
/spot_micro_motion_cmd_node/RB_3/range: 396
/spot_micro_motion_cmd_node/RF_1/center: 306
/spot_micro_motion_cmd_node/RF_1/center_angle_deg: -5.4
/spot_micro_motion_cmd_node/RF_1/direction: -1
/spot_micro_motion_cmd_node/RF_1/num: 3
/spot_micro_motion_cmd_node/RF_1/range: 396
/spot_micro_motion_cmd_node/RF_2/center: 306
/spot_micro_motion_cmd_node/RF_2/center_angle_deg: -27.6
/spot_micro_motion_cmd_node/RF_2/direction: 1
/spot_micro_motion_cmd_node/RF_2/num: 2
/spot_micro_motion_cmd_node/RF_2/range: 389
/spot_micro_motion_cmd_node/RF_3/center: 306
/spot_micro_motion_cmd_node/RF_3/center_angle_deg: 88.2
/spot_micro_motion_cmd_node/RF_3/direction: 1
/spot_micro_motion_cmd_node/RF_3/num: 1
/spot_micro_motion_cmd_node/RF_3/range: 372
/spot_micro_motion_cmd_node/alpha: 0.5
/spot_micro_motion_cmd_node/back_body_balance_shift: 0.005
/spot_micro_motion_cmd_node/beta: 0.5
/spot_micro_motion_cmd_node/body_length: 0.186
/spot_micro_motion_cmd_node/body_shift_phases: [1, 2, 3, 4, 5, 6...
/spot_micro_motion_cmd_node/body_width: 0.078
/spot_micro_motion_cmd_node/debug_mode: False
/spot_micro_motion_cmd_node/default_stand_height: 0.155
/spot_micro_motion_cmd_node/dt: 0.02
/spot_micro_motion_cmd_node/foot_height_time_constant: 0.02
/spot_micro_motion_cmd_node/fwd_body_balance_shift: 0.035
/spot_micro_motion_cmd_node/hip_link_length: 0.055
/spot_micro_motion_cmd_node/lb_contact_phases: [1, 1, 1, 1, 1, 0...
/spot_micro_motion_cmd_node/lf_contact_phases: [1, 1, 1, 1, 1, 1...
/spot_micro_motion_cmd_node/lidar_x_pos: 0.045
/spot_micro_motion_cmd_node/lidar_y_pos: 0.0
/spot_micro_motion_cmd_node/lidar_yaw_angle: 180
/spot_micro_motion_cmd_node/lidar_z_pos: 0.085
/spot_micro_motion_cmd_node/lie_down_foot_x_offset: 0.065
/spot_micro_motion_cmd_node/lie_down_height: 0.083
/spot_micro_motion_cmd_node/lower_leg_link_length: 0.13
/spot_micro_motion_cmd_node/max_fwd_velocity: 0.4
/spot_micro_motion_cmd_node/max_side_velocity: 0.4
/spot_micro_motion_cmd_node/max_yaw_rate: 0.35
/spot_micro_motion_cmd_node/num_phases: 8
/spot_micro_motion_cmd_node/num_servos: 12
/spot_micro_motion_cmd_node/overlap_time: 0.0
/spot_micro_motion_cmd_node/plot_mode: False
/spot_micro_motion_cmd_node/publish_odom: True
/spot_micro_motion_cmd_node/rb_contact_phases: [1, 0, 1, 1, 1, 1...
/spot_micro_motion_cmd_node/rf_contact_phases: [1, 1, 1, 0, 1, 1...
/spot_micro_motion_cmd_node/run_standalone: True
/spot_micro_motion_cmd_node/servo_max_angle_deg: 82.5
/spot_micro_motion_cmd_node/side_body_balance_shift: 0.015
/spot_micro_motion_cmd_node/stand_back_x_offset: -0.0
/spot_micro_motion_cmd_node/stand_front_x_offset: 0.015
/spot_micro_motion_cmd_node/standalone_mode: False
/spot_micro_motion_cmd_node/swing_time: 0.36
/spot_micro_motion_cmd_node/transit_angle_rl: 0.35
/spot_micro_motion_cmd_node/transit_rl: 0.06
/spot_micro_motion_cmd_node/transit_tau: 0.3
/spot_micro_motion_cmd_node/upper_leg_link_length: 0.1075
/spot_micro_motion_cmd_node/z_clearance: 0.05

NODES
/
spot_micro_motion_cmd_node (spot_micro_motion_cmd/spot_micro_motion_cmd_node)
auto-starting new master
process[master]: started with pid [3537]
ROS_MASTER_URI=http://localhost:11311
No. 2
On a computer:(ubuntu16 vm)
roslaunch spot_micro_keyboard_command keyboard_command.launch run_rviz:=true
dog display,but I don't know how to control to move, only know control interface.
qweasd  seem no function in command line
No. 3
roslaunch i2cpwm_board i2cpwm_node.launch
on pi 3B
from : http://bradanlane.gitlab.io/ros-i2cpwmboard/
PARAMETERS

/rosdistro: melodic
/rosversion: 1.14.10

NODES
/
i2cpwm_board_node (i2cpwm_board/i2cpwm_board)
auto-starting new master
process[master]: started with pid [3584]
ROS_MASTER_URI=http://localhost:11311
setting /run_id to fffe69ea-941c-11eb-b0be-b827eb8897a3
process[rosout-1]: started with pid [3595]
started core service [/rosout]
process[i2cpwm_board_node-2]: started with pid [3598]
sudo: no tty present and no askpass program specified
[i2cpwm_board_node-2] process has died [pid 3598, exit code 1, cmd sudo /home/leon/dog/devel/lib/i2cpwm_board/i2cpwm_board __name:=i2cpwm_board_node __log:=/home/leon/.ros/log/fffe69ea-941c-11eb-b0be-b827eb8897a3/i2cpwm_board_node-2.log].
log file: /home/leon/.ros/log/fffe69ea-941c-11eb-b0be-b827eb8897a3/i2cpwm_board_node-2*.log

If spot_micro_motion_cmd in standalone mode, you do not need to run the i2cpwm_board node.
I think you need to verify you can exchange communication between your ubuntu virtual machine and the raspberry pi.
They must be connected on the same network, or to eachother. You may need to modify network settings in the virtual machine software to get communication with the raspberry pi.
First verify you can ping the ip address of the raspberry pi from your ubuntu virtual machine. Find what ip address the raspbery pi has on it's wireless network interface through ifconfig.
On the virtual machine try pinging that ip address, example: ping 192.168.1.xx where xx is the last part of the address the pi has.
On your virtual machine you need to make sure you set some environment variables so nodes know the ROS master is on the pi. You may need to set ROS_MASTER_URI and ROS_IP. I have the following in my ~/.bashrc file. You'd have to replace http://ubunturospi.local with the ip address of your raspberry pi. You would also need to set ROS_IP to your virtual machine's ip address.
`export ROS_MASTER_URI=http://ubunturospi.local:11311 # Set IP of ros master, raspberry pi in this case
export ROS_IP=$(hostname -I | cut -f1 -d' ') # set own ros ip environment variable
alias rosinit="source /home/mike/catkin_ws/devel/setup.bash && export ROS_WORKSPACE=~/catkin_ws"
`
Before trying to run this software, I would make sure you can successfully run a ROS tutorial example, where one node is on the Rapsberry pi, and one node is on the virtual machine. For example, the simple publisher and subscriber: http://wiki.ros.org/ROS/Tutorials/WritingPublisherSubscriber(python)
The following video may help guide you as a basic ros tutorial for running stuff on a raspberr pu: https://www.youtube.com/watch?v=iLiI_IRedhI

Thanks for your reply!
My pc(win10) and pi are the same wifi network and I use ssh to control pi on win10. But my vm (on win10) has some problem.
Maybe I played the docker then vm ubuntu16 lost local network. At first,VM ubuntu 16 could not work then I close Hyper-V and vm rework.
I don't know how to fix it.
The robot should work on only one pi . Maybe more terminal. Then remote node control mode.
I bought 8g pi 4b on March 13, but  Amazon delay to next week.
At first, i2c servo should work. The servo rotate on my zynq 7010 system(Xilinx fpga) by direct pwm and i2c two way.
Or it should be simulate on a ROS and I understand Kinematics.
https://spotmicroai.readthedocs.io/en/latest/simulation/ seems a good site.

Hey! I didn't create a new topic. I hope you can help me.
I have a small problem and I cannot figure out where to look for a solution.
I have RPi4(ubiquityrobot), ubuntu 16.04 laptop, terminal with ssh. catkin_make is 100% assembled.
I use roslaunch spot_micro_keyboard_command keyboard_command.launch run_rviz:=true on laptop and roslaunch spot_micro_motion_cmd motion_cmd.launch run_standalone:=true on RPi.
After the command "stand" appears:
[ WARN] [1617730100.302570705]: Joint LF_2, Angle: 37.42
[ WARN] [1617730100.302659575]: Proportional Command below -1.0 was computed, clipped to -1.0
[ WARN] [1617730100.302758926]: Joint LF_3, Angle: -128.00
[ WARN] [1617730100.302853740]: Proportional Command above +1.0 was computed, clipped to 1.0
[ WARN] [1617730100.302923776]: Joint RB_3, Angle: 128.14
[ WARN] [1617730100.303019090]: Proportional Command above +1.0 was computed, clipped to 1.0
[ WARN] [1617730100.303093126]: Joint RF_3, Angle: 128.00
[ WARN] [1617730100.322427290]: Proportional Command below -1.0 was computed, clipped to -1.0
[ WARN] [1617730100.322514511]: Joint LB_3, Angle: -128.15
[ WARN] [1617730100.322585288]: Proportional Command above +1.0 was computed, clipped to 1.0
Angle values change. Joint numbers do not change.
In rviz, the image of the legs begins to twitch.
I really hope for your help!

Did you modify the configuration at all? This warning means an angle beyond the intended travel range was computed for some reason.
If the legs are twitching they may inadvertently be another node trying to command the leg servos.

Here is a screenshot of my table

Maybe you can see what's wrong

I reinstall ubuntu mate 16(pi) and vm ubuntu 16 (another pc)
pi ip: <IP_ADDRESS>
vm ip:<IP_ADDRESS>
but I don't know the remote publisher,
What should start in pi, and what should do on vm?
roslaunch servo_move_keyboard keyboard_move.launch
it seems to work well.
No error, and I know choose the servo number, and x,y,z show the angles.
Should the servo run to min,center,max, or only a config?
My servo did not run

roslaunch servo_move_keyboard keyboard_move.launch
it seems run ok as follow, but servo did not move, then logic analyzer check it. There is no wave.
From doc, it should control the servo move and there should be waves.
Which servo to control? Enter a number 1 through 12: 1
Enter command, q to go back to option select:
Servo  0 cmd:  520
Servo  0 cmd:  510
Servo  0 cmd:  500
Servo  0 cmd:  490
Servo  0 cmd:  480
Servo  0 cmd:  470
Servo  0 cmd:  460
Servo  0 cmd:  450
Servo  0 cmd:  440
Servo  0 cmd:  430
Servo  0 cmd:  420
Servo  0 cmd:  410
Servo  0 cmd:  400
Servo  0 cmd:  306
Servo  0 cmd:   83
Servo  0 cmd:  520
Servo  0 cmd:  520
Servo  0 cmd:  510
Servo  0 cmd:  500
Servo  0 cmd:  490
Servo  0 cmd:  489
Servo  0 cmd:  488
Servo  0 cmd:  487
Servo  0 cmd:  486
Key not in valid key commands, try again
Servo  0 cmd:  476
Servo  0 cmd:  466
Servo  0 cmd:  465
Servo  0 cmd:  464
Servo  0 cmd:  465
Servo  0 cmd:  466
Servo  0 cmd:  476
Servo  0 cmd:  486
Servo  0 cmd:  496

@liwenz you should first verify your VM can communicate with the raspberry pi. For example, try pinging the pi from your VM:
ping <IP_ADDRESS>
and vice versa from the raspberry pi. If not, you need to figure that out first.
Next, try running an example publisher and subscriber in ROS, where one node is running on the raspberry pi and the other on the VM, and see if you can get that to work: http://wiki.ros.org/ROS/Tutorials/WritingPublisherSubscriber(python)

@AlekseyErmolaev your config values look reasonable, or at least they don't have any obvious errors, but they are very different from my set, which is the default set on this repo. However the values are entirely dependent on the positions a servo is installed.
I would double check you followed the calibration directions. Try spot checking a few servos using your calibration table. For example, for the right front lower leg joint (the knee), according to your config table if you command it to a pwm value of 306, will the lower leg link be position truly at 0 degrees?

ping and netccat  from pi to vm are ok now.
Remote machine topic listed, but no data transmitted

Which topic?

I forgot, maybe turtle_cmd, I check it again.
publisher, the turtle move.

my test come from: http://wiki.ros.org/ROS/Tutorials/MultipleMachines
ssh hal
roscore
ssh marvin
export ROS_MASTER_URI=http://hal:11311
rosrun rospy_tutorials listener.py
py => rosrun turtlesim turtlesim_node
ssh hal
export ROS_MASTER_URI=http://hal:11311
rosrun rospy_tutorials talker.py
py=> rostopic pub -1 /turtle1/cmd_vel geometry_msgs/Twist -- '[2.0, 0.0, 0.0]' '[0.0, 0.0, 1.8]'
it could control the turtle move  in one pc or pi
but remote could not work
rpstopic list work well.
leon@leon:~$ rostopic list
/rosout
/rosout_agg
/turtle1/cmd_vel
/turtle1/color_sensor
/turtle1/pose
leon@leon:~$

roslaunch servo_move_keyboard keyboard_move.launch
the launch file includes:
  $

how to set "$(arg run_i2c_pwmboard)" ?
I think I did not start it, so i2cpwm_board did not start.

Not sure what to tell you, running your command works for me, specifically:
roslaunch servo_move_keyboard keyboard_move.launch run_i2c_pwmboard:=true
Note, however, the i2c_pwmboard node will only work correctly if run on a raspberry pi with the pwm board installed and with the i2c, power, and ground pins correctly connected.
Is your pca9685 board powered correctly?. The board requires power both for the board circuitry, and for the servo power. See the following diagram for example, note the top power input from an external 5v power source.
https://steemitimages.com/1280x0/https://res.cloudinary.com/hpiynhbhq/image/upload/v1518024645/eh21urwjil2ply3ay2gz.png
The pi alone probably will not supply enough power to allow the servos to move.

roslaunch servo_move_keyboard keyboard_move.launch run_i2c_pwmboard:=true
it works well. Now I could control  servo.
What's next? led display?
or  roslaunch spot_micro_motion_cmd motion_cmd.launch run_standalone:=false

Hi, I also have a problem, more.
I am attaching a picture. According to the possibility from the IT specialist at Ros, I had to install a version of melodic.
according to the instruction on the instructable "Rpi4 Lidar melodic Ros".
I can't run anything right now.
i2cpwm_board display reports error:
[FATAL] [1622811777.479435609]: Failed to open I2C bus (null)
spot_micro_motion_command reports an error:
RLException: [spot_micro_motion_cmdConfig-version.cmakerostopic] is neither a launch file in package [spot_micro_motion_cmd] nor is [spot_micro_motion_cmd] a launch file name
The traceback for the exception was written to the log file.
Although everything is in place, but the different versions without catkin have changed, and no one is able to tell me now how to run it?
ps: all the repair options I found and tried, either didn't help or decided the system so that I had to format the storage and reinstall everything.
Thanks for your instructions. There is no arduino in your spot? do you control the rpi servo-shield?
All the problems that, Arduino UNO, Rpi3b and Raspbian with ROS Melodic, contain with this mode, and there is no person who knows all three of these topics, so there is no help for me.
I'm trying to find a solution to combine Ros in such a way that it reads and writes everything to UNO just like the Arduino IDE and its SerialMonitor.
Any ideas to help?
Jacob

where could I find the geometry data, as leg lenth, the arm coordinate，angle.


Race Condition with ArgoCD deleting PVC

Hey,
i love your project, but i'm currently facing an issue when using it in combination with ArgoCD. When i delete a terraform CR via ArgoCD ArgoCD also instantly deletes the PVC that was created by the terraform-operator for the CR. This sometimes leads to the terraform operator instantly recreating the PVC, sometimes it leads to the terraform-operator getting stuck because the PVC is missing. I tried setting multiple ArgoCD annotations on the created PVC but to no avail. This seems like an ArgoCD bug, as somebody else is having a similar issue with StatefulSets https://github.com/argoproj/argo-cd/issues/13503 . Do you have a workaround for this problem or is this not happening for you? I tried with v0.17.0 of the terraform-operator and ArgoCD v2.10.9

It probably to do with the ownerReference that ties the PVC to the Terraform Resource in Kubernetes. When the Terraform resource is deleted, the PVC is deleted . Aside from that , the PVC should only be created if the Terraform resource still exists.
I've done manual deletions of the Terraform resource to clean up the PVC. But I have not observed the PVC getting recreated. I wonder what ArgoCD is doing differently.
Let me try to understand Argo a little better. If ArgoCD deletes a resource:

Does ArgoCD issue a "delete" request on the resource in the target cluster?
Does ArgoCD delete respect finalizers?
Does ArgoCD remove references manually via any kind of annotations?

For troubleshooting, can you confirm that deleting a terraform resource manually does not "recreate" the pvc?

It probably to do with the ownerReference that ties the PVC to the Terraform Resource in Kubernetes. When the Terraform resource is deleted, the PVC is deleted . Aside from that , the PVC should only be created if the Terraform resource still exists.

Yes, ArgoCD issues a delete to every resource which is owned by the Terraform CR. As the CR has a finalizer it is not fully deleted until the terraform-operator removes the finalizer, so the operator recreates the PVC sometimes, sometimes it throws an error that it can't find the PVC because Argo deleted it.

I've done manual deletions of the Terraform resource to clean up the PVC. But I have not observed the PVC getting recreated. I wonder what ArgoCD is doing differently.
Let me try to understand Argo a little better. If ArgoCD deletes a resource:
1. Does ArgoCD issue a "delete" request on the resource in the target cluster?

Yes and all resources associated with the CR, so PVC, CM, Secret, Pods, etc.

2. Does ArgoCD delete respect finalizers?

Yes, but i tried adding a finalizer to the PVC via the taskOptions script section. This leads to the PVC staying and only entering terminating state, but this does not solve the problem as a terminating PVC can't be bound to a pod and the delete pods get stuck in pending waiting for the PVC

3. Does ArgoCD remove references manually via any kind of annotations?

No

For troubleshooting, can you confirm that deleting a terraform resource manually does not "recreate" the pvc?

Yes deleting the terraform CR via kubectl works just as you'd expect.
My hacky workaround for now is removing the ownerReferences in the setup script for the PVC (and CM and Secret, as i have observed that there's the same race condition) and then deleting the resources via kubectl as last action in the apply-delete step.
All in all this is definitely a bug caused solely by ArgoCD and not your work, as ArgoCD is not even caring about its own annotations which i tried to use to prevent deletion of these resources. So i'm not sure if you want to tackle this issue, i could fully understand if you wouldn't want to.
But i noticed a bug with your work that would help me out if you could fix it: https://github.com/GalleyBytes/terraform-operator/issues/169
Thanks for your work!

ArgoCD should only delete resources that are marked with
metadata:
  labels:
    argocd.argoproj.io/instance: xxx

and the sub-resources of the terraform-operator resource are not marked with that.
IE, it should delete the terraform-operator resource, which will trigger the finalizers on that, which in turn will run the delete. And then when the finalizer code allows it it will be deleteable and the subresources will be marked as deleteable.

ArgoCD should only delete resources that are marked with
metadata:
  labels:
    argocd.argoproj.io/instance: xxx

and the sub-resources of the terraform-operator resource are not marked with that.
IE, it should delete the terraform-operator resource, which will trigger the finalizers on that, which in turn will run the delete. And then when the finalizer code allows it it will be deleteable and the subresources will be marked as deleteable.

I totally agree that it SHOULD be like that, but it isn't. The sub resources do not have the instance label (nor the tracking id annotation) still they get deleted by argocd because it knows the subresources through the ownerReferences

Did you forgot to setup ArgoCD to actually respect the tf run status?
https://tf.galleybytes.com/docs/getting-started/argo-cd/

No, i added the lua script and that works like a charm. Did you try to reproduce the problem?

No, it works perfectly for me:

tf is in deleted state (and stuck there because the script failed, and I haven't had time to fix it), and the pvc is still alive and well.

the PVC is not still alive it got recreated. Compare the deletion timestamp of the terraform CR with the creation timestamp of the PVC => The moment the terraform CR got deleted the original PVC got deleted too but the terraform operator recreated the PVC instantly hence the creationtimestamp equalling the deletion timestamp. In your picture the creation timestamp of the terraform CR is one month earlier and so should the creation timestamp of the PVC be


Elite nukie suit resprite

About the PR

Resprites the Elite nukie hardsuit to have the classic 4 red eyes
Why / Balance

Sometimes players confuse nukies with elite hardsuits for sec officers hardsuits
Technical details

Media

Requirements

[X] I have read and am following the Pull Request and Changelog Guidelines.
[X] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

:cl:

tweak: The Nukie Elite Hardsuit has been resprited to have the classic "four-eyes".

 Resembles the old elite suit sprite with a fresh updated look

@InfinityPandaRed can you instead pr the sprite from gaming rework (#659)?

@InfinityPandaRed can you instead pr the sprite from gaming rework (#659)?  whatever fits i just think that elite should have a somewhat different look from the bloodred, not just the color change

imo elite suit from this pr looks cooler

which you mean my pr?

resolve the conflicts @InfinityPandaRed


transforming JsxEditorProps

[x] I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
[x] I have read the documentation and cannot find an answer.

Describe the bug
Hey, i want to pass JsxEditorProps just like react props to my custom component but i am not familiar with mdast-util-mdx-jsx and mdast (i am guessing these are being used here for JsxEditorProps)
I could not find anything related to this in documentation and before implementing a proper solution i wanted to create an issue
here is a minimal example of what i am trying to achieve, i think something like transform should be available in the library
const jsxComponentDescriptors: JsxComponentDescriptor[] = [
  {
    name: 'Comment',
    kind: 'flow',
    source: './external',
    props: [
      { content : 'string' },
    ],
    Editor: (editorProps) => {
      const props = transform(editorProps)
      return <CommentComp {...props} />
    }
  },
  {
    name: 'CommentsContainer',
    kind: 'flow',
    hasChildren: true,
    Editor: (editorProps) => {
      const props = transform(editorProps)
      return <CommentsContainerComp {...props} />
    }
  },
]

const InsertCommentsContainer = () => {
  const insertJsx = usePublisher(insertJsx$)
  return (
    <Button
      onClick={() =>
        insertJsx({
          name: 'CommentsContainer',
          kind: 'flow',
        })
      }
    >
      Insert CommentsContainer
    </Button>
  )
}

export const Example = () => {
  return (
    <MDXEditor
      markdown={jsxMarkdown}
      onChange={console.log}
      plugins={[
        jsxPlugin({ jsxComponentDescriptors }),
        toolbarPlugin({
          toolbarContents: () => (
            <>
              <InsertCommentsContainer />
            </>
          )
        })
      ]}
    />
  )
}

and here is my very very sketchy implementation of transform function just for testing (could be recursive  and typed)
import * as mdxComponents from '@/mdx-components';

//here i only use it to transform children so editorProps.mdastNode.children
//is passed as props to this function
function transform(
  props: any
) {
  return props
    .map((item, i) => {
      if (item.type === 'paragraph') {
        return React.createElement('p', { key: i }, item.children[0].value);
      }
      if (!item.name) return;
      const props = item.attributes.reduce((attr, item) => {
        return Object.assign(attr, {
          [item.name]: item.value,
        });
      }, {});

      if (!props.children) {
        props.children = item.children?.map((child, i) => {
          if (child.type === 'paragraph') {
            return React.createElement(
              'p',
              { key: i },
              child.children[0].value
            );
          }
          const props = item.attributes.reduce((attr, item) => {
            return Object.assign(attr, {
              [item.name]: item.value,
            });
          }, {});
          const Comp = mdxComponents[child.name];
          return <Comp key={i} {...props} />;
        });
      }

      const Comp = mdxComponents[item.name];
      return <Comp key={i} {...props} />;
    })
    .filter(Boolean);
}

Expected behavior
There should be a way to transform ast to actual react props
As i said i am not familiar with mdast-util-mdx-jsx and mdast so i cannot think of a proper solution lmk if there is any
Thank you for taking the time to read

No idea what you're doing in the code above or why you want to do this.


dupli - option for less verbose output

Create a command line option for less verbose, easily parseable output

duplicate of issue #5 (github storage issue)


[stable/openvpn]: add support for connecting to istio services.

What this PR does / why we need it:
This PR adds support to openvpn to connect to istio protected services.
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/assign @jasongwartz

/ok-to-test

/retest

Please, add support for istio 1.7.3


[Design] Utilize IPv6 feature for EKS

Leverage IPv6 to avoid IP address exhaustion, minimize latency at scale, and simplify routing configuration moving forward.

cdk currently has no IPv6 support (to which I've raised an issue here); this may have to be custom resource creation in the mean time.

Currently the VPC CNI Addon does not support env variables such as IPV6 etc so we are working with support team on this. Once they support these vars as part of advanced features of VPC CNI addon. We will work on a a pattern too along with upgrading our VPC CNI addon.