Fix data races in TestAdsReconnectWithNonce and Discovery

racetest has been steadily failing since changes to push_context.go began modifying the VirtualService fields. The changes introduced a data race between these writes and Monitor's read of the same configs.
Example of failed racetest: https://k8s-gubernator.appspot.com/build/istio-circleci/racetest/168014
This PR is also fixing one more (unrelated) race errors I encounters in discover.go while testing the changes of this PR.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram
If they are not already assigned, you can assign the PR to them by writing /assign @rshriram in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ymesika: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test e2e-mixer-no_auth

prow/e2e-simpleTests.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test e2e-mixer-no_auth

prow/e2e-simpleTests.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test e2e-simple

prow/e2e-dashboard.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test e2e-mixer-no_auth

prow/e2e-simpleTests.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test e2e-simple

prow/e2e-dashboard.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test e2e-mixer-no_auth

prow/e2e-simpleTests.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test e2e-simple

prow/e2e-dashboard.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test e2e-mixer-no_auth

prow/e2e-simpleTests.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test e2e-simple

prow/e2e-dashboard.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test e2e-simple

prow/e2e-dashboard.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test e2e-mixer-no_auth

prow/e2e-simpleTests.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test e2e-mixer-no_auth

prow/e2e-simpleTests.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test e2e-simple

prow/e2e-dashboard.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
de892f592aadae19fccbd806a400c761368eefdb
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test e2e-mixer-no_auth

prow/e2e-simpleTests.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test e2e-simple

prow/e2e-dashboard.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test e2e-mixer-no_auth

prow/e2e-simpleTests.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test e2e-simple

prow/e2e-dashboard.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test e2e-simple

prow/e2e-dashboard.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test istio-unit-tests

prow/e2e-mixer-no_auth.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test e2e-simple

prow/e2e-dashboard.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test istio-unit-tests

prow/e2e-mixer-no_auth.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test istio-unit-tests

prow/e2e-mixer-no_auth.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test istio-unit-tests

prow/e2e-mixer-no_auth.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test e2e-simple

prow/e2e-dashboard.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
73445e1c1e718b14b6458faea8fa5f7fd50e89f5
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test istio-unit-tests

prow/e2e-mixer-no_auth.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test e2e-simple

prow/e2e-dashboard.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test istio-unit-tests

prow/e2e-mixer-no_auth.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test e2e-simple

prow/e2e-dashboard.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test e2e-simple

prow/e2e-dashboard.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
21a75346d1457b3b7bf89b637ac8cc89c2a107b0
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test e2e-mixer-no_auth

prow/e2e-simpleTests.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test e2e-simple

prow/e2e-dashboard.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
21a75346d1457b3b7bf89b637ac8cc89c2a107b0
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
21a75346d1457b3b7bf89b637ac8cc89c2a107b0
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test e2e-simple

prow/e2e-dashboard.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
fe82d2954995fe26f06a17622e97f6a6713eeacf
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
21a75346d1457b3b7bf89b637ac8cc89c2a107b0
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
21a75346d1457b3b7bf89b637ac8cc89c2a107b0
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
21a75346d1457b3b7bf89b637ac8cc89c2a107b0
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
21a75346d1457b3b7bf89b637ac8cc89c2a107b0
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
21a75346d1457b3b7bf89b637ac8cc89c2a107b0
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
21a75346d1457b3b7bf89b637ac8cc89c2a107b0
link
/test e2e-mixer-no_auth

prow/e2e-simpleTests.sh
21a75346d1457b3b7bf89b637ac8cc89c2a107b0
link
/test e2e-simple

prow/e2e-dashboard.sh
21a75346d1457b3b7bf89b637ac8cc89c2a107b0
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
21a75346d1457b3b7bf89b637ac8cc89c2a107b0
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
21a75346d1457b3b7bf89b637ac8cc89c2a107b0
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
21a75346d1457b3b7bf89b637ac8cc89c2a107b0
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
21a75346d1457b3b7bf89b637ac8cc89c2a107b0
link
/test e2e-mixer-no_auth

prow/e2e-simpleTests.sh
21a75346d1457b3b7bf89b637ac8cc89c2a107b0
link
/test e2e-simple

prow/e2e-dashboard.sh
21a75346d1457b3b7bf89b637ac8cc89c2a107b0
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
21a75346d1457b3b7bf89b637ac8cc89c2a107b0
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
21a75346d1457b3b7bf89b637ac8cc89c2a107b0
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
38c81210505586172d13e957463ea60406c65c75
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
21a75346d1457b3b7bf89b637ac8cc89c2a107b0
link
/test e2e-mixer-no_auth

prow/e2e-simpleTests.sh
21a75346d1457b3b7bf89b637ac8cc89c2a107b0
link
/test e2e-simple

prow/e2e-dashboard.sh
21a75346d1457b3b7bf89b637ac8cc89c2a107b0
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
21a75346d1457b3b7bf89b637ac8cc89c2a107b0
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
21a75346d1457b3b7bf89b637ac8cc89c2a107b0
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
38c81210505586172d13e957463ea60406c65c75
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
38c81210505586172d13e957463ea60406c65c75
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
21a75346d1457b3b7bf89b637ac8cc89c2a107b0
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
21a75346d1457b3b7bf89b637ac8cc89c2a107b0
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
21a75346d1457b3b7bf89b637ac8cc89c2a107b0
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
21a75346d1457b3b7bf89b637ac8cc89c2a107b0
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
38c81210505586172d13e957463ea60406c65c75
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
38c81210505586172d13e957463ea60406c65c75
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
38c81210505586172d13e957463ea60406c65c75
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
21a75346d1457b3b7bf89b637ac8cc89c2a107b0
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
21a75346d1457b3b7bf89b637ac8cc89c2a107b0
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
21a75346d1457b3b7bf89b637ac8cc89c2a107b0
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
38c81210505586172d13e957463ea60406c65c75
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
38c81210505586172d13e957463ea60406c65c75
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
38c81210505586172d13e957463ea60406c65c75
link
/test e2e-simple

prow/e2e-mixer-no_auth.sh
38c81210505586172d13e957463ea60406c65c75
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
21a75346d1457b3b7bf89b637ac8cc89c2a107b0
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
21a75346d1457b3b7bf89b637ac8cc89c2a107b0
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
38c81210505586172d13e957463ea60406c65c75
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
38c81210505586172d13e957463ea60406c65c75
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
38c81210505586172d13e957463ea60406c65c75
link
/test e2e-simple

prow/e2e-mixer-no_auth.sh
38c81210505586172d13e957463ea60406c65c75
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
38c81210505586172d13e957463ea60406c65c75
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
21a75346d1457b3b7bf89b637ac8cc89c2a107b0
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
38c81210505586172d13e957463ea60406c65c75
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
38c81210505586172d13e957463ea60406c65c75
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
38c81210505586172d13e957463ea60406c65c75
link
/test e2e-simple

prow/e2e-mixer-no_auth.sh
38c81210505586172d13e957463ea60406c65c75
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
38c81210505586172d13e957463ea60406c65c75
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
38c81210505586172d13e957463ea60406c65c75
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


AmazonServiceException: A WebException with status ReceiveFailure while running awsS3Root.Exists

We have a website that creates files in to s3 bucket. It is currently failing at this line

awsS3Root.Exists.

with exception AmazonServiceException when it tries to upload/create text file
This piece of code works fine when unit testing.
Code:
using (var awsS3Client = new AmazonS3Client(regionEndPoint))                     {                         var awsS3Root = new S3DirectoryInfo(awsS3Client, bucketName);                         if (awsS3Root.Exists)                         { try                             {                                 var file = awsS3Root.GetFile(filePath);
Error:
Amazon.Runtime.AmazonServiceException: A WebException with status ReceiveFailure was thrown. ---> System.Net.WebException: The underlying connection was closed: An unexpected error occurred on a receive. ---> System.Security.Cryptography.CryptographicException: The handle is invalid.
at System.Net.Security.SecureChannel.VerifyRemoteCertificate(RemoteCertValidationCallback remoteCertValidationCallback)
at System.Net.Security.SslState.CompleteHandshake()
at System.Net.Security.SslState.CheckCompletionBeforeNextReceive(ProtocolToken message, AsyncProtocolRequest asyncRequest)
at System.Net.Security.SslState.ProcessReceivedBlob(Byte[] buffer, Int32 count, AsyncProtocolRequest asyncRequest)
at System.Net.Security.SslState.StartReceiveBlob(Byte[] buffer, AsyncProtocolRequest asyncRequest)
at System.Net.Security.SslState.ProcessReceivedBlob(Byte[] buffer, Int32 count, AsyncProtocolRequest asyncRequest)
at System.Net.Security.SslState.StartReceiveBlob(Byte[] buffer, AsyncProtocolRequest asyncRequest)
at System.Net.Security.SslState.ProcessReceivedBlob(Byte[] buffer, Int32 count, AsyncProtocolRequest asyncRequest)
at System.Net.Security.SslState.StartReceiveBlob(Byte[] buffer, AsyncProtocolRequest asyncRequest)
at System.Net.Security.SslState.ProcessReceivedBlob(Byte[] buffer, Int32 count, AsyncProtocolRequest asyncRequest)
at System.Net.Security.SslState.StartReceiveBlob(Byte[] buffer, AsyncProtocolRequest asyncRequest)
at System.Net.Security.SslState.ProcessReceivedBlob(Byte[] buffer, Int32 count, AsyncProtocolRequest asyncRequest)
at System.Net.Security.SslState.StartReceiveBlob(Byte[] buffer, AsyncProtocolRequest asyncRequest)
at System.Net.Security.SslState.ProcessReceivedBlob(Byte[] buffer, Int32 count, AsyncProtocolRequest asyncRequest)
at System.Net.Security.SslState.StartReceiveBlob(Byte[] buffer, AsyncProtocolRequest asyncRequest)
at System.Net.Security.SslState.ForceAuthentication(Boolean receiveFirst, Byte[] buffer, AsyncProtocolRequest asyncRequest)
at System.Net.Security.SslState.ProcessAuthentication(LazyAsyncResult lazyResult)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
at System.Net.TlsStream.ProcessAuthentication(LazyAsyncResult result)
at System.Net.TlsStream.Write(Byte[] buffer, Int32 offset, Int32 size)
at System.Net.ConnectStream.WriteHeaders(Boolean async)
--- End of inner exception stack trace ---
at System.Net.HttpWebRequest.GetResponse()
at Amazon.Runtime.Internal.HttpRequest.GetResponse() in D:\Jenkins\jobs\v3-stage-release\workspace\AWSDotNetPublic\sdk\src\Core\Amazon.Runtime\Pipeline\HttpHandler_bcl\HttpWebRequestFactory.cs:line 118
at Amazon.Runtime.Internal.HttpHandler1.InvokeSync(IExecutionContext executionContext) in D:\Jenkins\jobs\v3-stage-release\workspace\AWSDotNetPublic\sdk\src\Core\Amazon.Runtime\Pipeline\HttpHandler\HttpHandler.cs:line 84    at Amazon.Runtime.Internal.RedirectHandler.InvokeSync(IExecutionContext executionContext) in D:\Jenkins\jobs\v3-stage-release\workspace\AWSDotNetPublic\sdk\src\Core\Amazon.Runtime\Pipeline\Handlers\RedirectHandler.cs:line 41    at Amazon.Runtime.Internal.Unmarshaller.InvokeSync(IExecutionContext executionContext) in D:\Jenkins\jobs\v3-stage-release\workspace\AWSDotNetPublic\sdk\src\Core\Amazon.Runtime\Pipeline\Handlers\Unmarshaller.cs:line 50    at Amazon.S3.Internal.AmazonS3ResponseHandler.InvokeSync(IExecutionContext executionContext)    at Amazon.Runtime.Internal.ErrorHandler.InvokeSync(IExecutionContext executionContext) in D:\Jenkins\jobs\v3-stage-release\workspace\AWSDotNetPublic\sdk\src\Core\Amazon.Runtime\Pipeline\ErrorHandler\ErrorHandler.cs:line 70    --- End of inner exception stack trace ---    at Amazon.Runtime.Internal.WebExceptionHandler.HandleException(IExecutionContext executionContext, WebException exception) in D:\Jenkins\jobs\v3-stage-release\workspace\AWSDotNetPublic\sdk\src\Core\Amazon.Runtime\Pipeline\ErrorHandler\WebExceptionHandler.cs:line 44    at Amazon.Runtime.Internal.ErrorHandler.ProcessException(IExecutionContext executionContext, Exception exception) in D:\Jenkins\jobs\v3-stage-release\workspace\AWSDotNetPublic\sdk\src\Core\Amazon.Runtime\Pipeline\ErrorHandler\ErrorHandler.cs:line 202    at Amazon.Runtime.Internal.ErrorHandler.InvokeSync(IExecutionContext executionContext) in D:\Jenkins\jobs\v3-stage-release\workspace\AWSDotNetPublic\sdk\src\Core\Amazon.Runtime\Pipeline\ErrorHandler\ErrorHandler.cs:line 76    at Amazon.Runtime.Internal.CallbackHandler.InvokeSync(IExecutionContext executionContext) in D:\Jenkins\jobs\v3-stage-release\workspace\AWSDotNetPublic\sdk\src\Core\Amazon.Runtime\Pipeline\Handlers\CallbackHandler.cs:line 46    at Amazon.Runtime.Internal.RetryHandler.InvokeSync(IExecutionContext executionContext) in D:\Jenkins\jobs\v3-stage-release\workspace\AWSDotNetPublic\sdk\src\Core\Amazon.Runtime\Pipeline\RetryHandler\RetryHandler.cs:line 88    at Amazon.Runtime.Internal.CallbackHandler.InvokeSync(IExecutionContext executionContext) in D:\Jenkins\jobs\v3-stage-release\workspace\AWSDotNetPublic\sdk\src\Core\Amazon.Runtime\Pipeline\Handlers\CallbackHandler.cs:line 46    at Amazon.Runtime.Internal.CallbackHandler.InvokeSync(IExecutionContext executionContext) in D:\Jenkins\jobs\v3-stage-release\workspace\AWSDotNetPublic\sdk\src\Core\Amazon.Runtime\Pipeline\Handlers\CallbackHandler.cs:line 46    at Amazon.S3.Internal.AmazonS3ExceptionHandler.InvokeSync(IExecutionContext executionContext)    at Amazon.Runtime.Internal.ErrorCallbackHandler.InvokeSync(IExecutionContext executionContext) in D:\Jenkins\jobs\v3-stage-release\workspace\AWSDotNetPublic\sdk\src\Core\Amazon.Runtime\Pipeline\Handlers\ErrorCallbackHandler.cs:line 44    at Amazon.Runtime.Internal.MetricsHandler.InvokeSync(IExecutionContext executionContext) in D:\Jenkins\jobs\v3-stage-release\workspace\AWSDotNetPublic\sdk\src\Core\Amazon.Runtime\Pipeline\Handlers\MetricsHandler.cs:line 40    at Amazon.Runtime.Internal.RuntimePipeline.InvokeSync(IExecutionContext executionContext) in D:\Jenkins\jobs\v3-stage-release\workspace\AWSDotNetPublic\sdk\src\Core\Amazon.Runtime\Pipeline\RuntimePipeline.cs:line 136    at Amazon.Runtime.AmazonServiceClient.Invoke[TRequest,TResponse](TRequest request, IMarshaller2 marshaller, ResponseUnmarshaller unmarshaller) in D:\Jenkins\jobs\v3-stage-release\workspace\AWSDotNetPublic\sdk\src\Core\Amazon.Runtime\AmazonServiceClient.cs:line 118
at Amazon.S3.AmazonS3Client.GetBucketLocation(GetBucketLocationRequest request)
at Amazon.S3.IO.S3DirectoryInfo.ExistsWithBucketCheck(Boolean& bucketExists)
at Amazon.S3.IO.S3DirectoryInfo.get_Exists()
at MyProject.S3FileIO.Create(String path, String contents)

This sounds like an issue with your IIS configuration. Are you able to make any SDK calls at all?

Hi. Sorry for the late response. The only change i made to IIS is to update the account of app pool to local system so that it can pick up credentials file from my user account. I made this change inorder to meet the requirement (Load access key and token from credentials file by specifying profile in config file). Will check now to see if i can make any SDK call?

Problem solved. Not sure what caused it initially to fail. Worked after restarting PC and resetting IIS. Guessing something to do with IIS
Question: How did you know in first place if its to do with IIS configuration or not?

Glad to hear you've got that resolved. Closing the issue.
The error you received isn't a very common one, though the few occurrences of it I saw online suggested that the code was executing under an account that didn't have access to certain certificates.

@PavelSafronov, which certificates are you talking about? I'm having the same issue. I'm being tempted to restart my PC but that's not a good remedy. We need to address this kind of issue accordingly.

This issue is a year old, so I don't quite remember all the details, but I think it may have been this StackOverflow thread discussing the client-side certificate issues that can come up if the framework you are using doesn't support TLS 1.2.

I have this issue now 403 forbidden, sometimes the file upload completes but most of the time I get 403. Amazon.S3.IO.S3DirectoryInfo.ExistsWithBucketCheck(Boolean& bucketExists) in D:\JenkinsWorkspaces\trebuchet-stage-release\AWSDotNetPublic\sdk\src\Services\S3\Custom_bcl\IO\S3DirectoryInfo.cs:209
Amazon.S3.IO.S3DirectoryInfo.get_Exists() in D:\JenkinsWorkspaces\trebuchet-stage-release\AWSDotNetPublic\sdk\src\Services\S3\Custom_bcl\IO\S3DirectoryInfo.cs:149


Configure CodeClimate for JS

@mistercrunch did you only want it for only JS specifically? or is the whole project ok?


[BUG] fit_surrogate does not handle objective values with failures "F"

Describe the bug
The CBO.fit_surrogate method does not treat failed objectives "F" but it should!

Resolved in 82e678cbedba6d164d78900185fc94bcb6ad727c


Fixes #758

Modifed get(Collection rowColumns) return type.

Going through to fix the @Override but this seem to be breaking a lot of other things.

For sure in way over my head on this..

For sure in way over my head on this..

Can you add something like #TODO fix everywhere there is a compile error?  Then push that change.  Then we can discuss those here in the PR.

These change look good, I squashed and merged them.  Thanks @cjmctague.


bug - oh no ntfy crashed on chromium 83

Ubuntu chrome says "uhoh e.replaceAll is not a function.  Note that stand alone server on an isolated network, returned a 404 error message, when trying to access /static/langs/en-US.json  Other browsers worked, so it could be a chromium quirk.  Chrome version 83, which is out of date.

Isn't Chrome at version >100 already. Looks like Chrome 83 is from 2020, though it's odd that e.replaceAll is not there. Sorry but I can't support outdated browers like that.

Closing this, but I'm happy to discuss further


Disable eslint when doing npm run build

Description
This is a fix for the issue where we are failing to build the Docker image for the client due to eslint throwing errors. See: https://github.com/Researchify/Researchify/runs/3763005968
This only happens when building the image and not locally for some reason, perhaps it's not copying over the .eslintrc.json or it can't find it, which is supposed to suppress the rules.
Type of change

[x] Bug fix
[ ] New feature
[ ] Refactoring
[ ] Documentation

Problem
See description
Solution description
Thanks to @kdav108 for providing the solution: https://stackoverflow.com/questions/55821078/disable-eslint-that-create-react-app-provides
To add DISABLE_ESLINT_PLUGIN=true to the build script.
Tests
Build the docker image in /client by running docker build . and it shouldn't throw eslint errors.
Relevant document/ link (if any)
N/A
Risk
Identity the risk level (low, medium, high) and indicate which component(s) will be affected if bugs exist.
Low

@aksh0001 @kdav108 Just curious, do we know if this is an issue for scholly/base when deploying to GH pages? Does it need to be added there as well?

@aksh0001 @kdav108 Just curious, do we know if this is an issue for scholly/base when deploying to GH pages? Does it need to be added there as well?

We're ignoring the eslint config for scholly/base via .dockerignore, so it shouldn't be copied over to the container and the building should be successful still if i'm not wrong. I'd like to look into this further though before merging because this was all working fine without any hacks a couple weeks ago :disappointed:
Also was wondering if we installed eslint correctly in the client and base?
https://github.com/airbnb/javascript/issues/2233#issuecomment-754316789
the docs say to use npx install-peerdeps --dev eslint-config-airbnb https://www.npmjs.com/package/eslint-config-airbnb

@aksh0001 So I did a bit more investigation and found out that we don't get the same behaviour in scholly/base because in that package.json, eslint-config-airbnb was not included in the eslintConfig.extends array. However, it is in the client package.json. I don't remember why I didn't include it in scholly/base at the time though, may have been reading a different tutorial that told me to set it up differently ... Additionally, after reading the eslint docs, .eslintrc.json takes precedence over what's in the package.json.
This would line up with how the deployments started breaking after the eslintrc.json files got ignored by Docker in main, because the rules its complaining should just be regular eslint complaining - which leaves the question why it's not complaining about how it can't find the airbnb config like from when scholly/base wouldn't build because it couldn't find the airbnb config to extend from, as it was a dev dependency.
I think the fix should be removing eslint-config-airbnb from the eslintConfig.extends array in package.json but I'm running  into another error when doing npm run build which I'm looking into at the moment.


editor: focus and hit testing enhancements

based on https://github.com/lockbook/lockbook/pull/2779

closing because not worthwhile to rebase; new effort on editor-focus branch


Update digital-media-video-content.md

I updated the links in this doc to the correct version of Azure Media Services.

Learn Build status updates of commit 9e39588:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/solution-ideas/articles/digital-media-video-content.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

#sign-off

@EdPrice-MSFT please review these changes.

@BryanLa I have made the edits that John requested.

Learn Build status updates of commit 6b7a1fb:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/solution-ideas/articles/digital-media-video-content.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@EdPrice-MSFT,
Can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Learn Build status updates of commit 7e3969c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/solution-ideas/articles/digital-media-video-content.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 959d857:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/solution-ideas/articles/digital-media-video.yml
:white_check_mark:Succeeded

docs/solution-ideas/articles/digital-media-video-content.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 959d857:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/solution-ideas/articles/digital-media-video.yml
:white_check_mark:Succeeded

docs/solution-ideas/articles/digital-media-video-content.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

#Sign-Off


How to use setSessionCallback?

Thanks for this library, your time is greatly appreciated!
Any example on how to use the setSessionCallback?  I was testing this with Laravel real quick, but I am unable to get $client->accessToken or $client->refreshToken to output.  If I switch to using PHP's start_session() it works, but the application I want to implement into uses its own session handler.
I assume I am doing the callback incorrect or missing something?
$client = new Client($apiKey, $secret, $redirectURI);

$client->setSessionCallback(function ($key, $value) use ($request) {
    $request->session()->put($key, $value);
    return $request->session()->get($key) ?? '';
});

$client->acquireAccessToken($_GET);

echo $client->accessToken . '
';
echo $client->refreshToken . '
';

dd($request->session()->all());`

Looks like you are not following the contact the callback expects. See
http://phpfui.com/?n=PHPFUI\ConstantContact&c=Client
Basically you need to delete the session variable if passed in a null
value, otherwise store it.
Let me know if that doesn't work.
On Thu, Feb 2, 2023, 5:52 PM pixelone @.***> wrote:

Thanks for this library, your time is greatly appreciated!
Any example on how to use the setSessionCallback? I was testing this with
Laravel real quick, but I am unable to get $client->accessToken or
$client->refreshToken to output. If I switch to using PHP's start_session()
it works, but the application I want to implement into uses its own session
handler.
I assume I am doing the callback incorrect or missing something?
$client = new Client($apiKey, $secret, $redirectURI);
$client->setSessionCallback(function ($key, $value) use ($request) {
$request->session()->put($key, $value);
return $request->session()->get($key) ?? '';
});
$client->acquireAccessToken($_GET);
echo $client->accessToken . '';
echo $client->refreshToken . '';
dd($request->session()->all());`
—
Reply to this email directly, view it on GitHub
https://github.com/phpfui/ConstantContact/issues/13, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABYW6S6LM4I2MXL3B6Q72Q3WVRJETANCNFSM6AAAAAAUPVZPXA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Yes, your new implementation looks correct now.
And yes, it should update the refresh token after the call.
On Thu, Feb 2, 2023, 8:03 PM pixelone @.***> wrote:

Thanks I sorted by looking at your method and with the following.
$client->setSessionCallback(function ($key, $value) use ($request) {
if (null === $value) {
$value = $request->session()->get($key) ?? '';
$request->session()->forget($key);
    return $value;
}

$request->session()->put($key, $value);

return $request->session()->get($key);

});`
Another quick question: When you call $client->refreshToken(); should the
refreshToken be updated right away? I call $client->refreshToken(), but not
seeing any changes to $client->refreshToken output.
—
Reply to this email directly, view it on GitHub
https://github.com/phpfui/ConstantContact/issues/13#issuecomment-1414756200,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABYW6S3PJJ7CSRFCCYWACC3WVRYRXANCNFSM6AAAAAAUPVZPXA
.
You are receiving this because you commented.Message ID:
@.***>


support pre-push merge request actions

Use case example: Execute unit tests, code formatting, etc... in local before opening a merge request.
User can provide a config in same repository with scripts to execute


Add copy to clipboard feature and editor configuration

A editor/husky

After change please describe how to use the feature you add, so that I can edit README and keep it documented.
Checklist:

[ ] Change your code
[ ] Provide description of your added feature (both in README with detail or in this PR comment in few words are OK)
[ ] Test (by @baobao1270)
[ ] Update version to 1.3.0 (by @baobao1270) and merge to master
[ ] Release new version to VSCode Marketplace

After change please describe how to use the feature you add, so that I can edit README and keep it documented.
Checklist:

[ ]  Change your code
[ ]  Provide description of your added feature (both in README with detail or in this PR comment in few words are OK)
[ ]  Test (by @baobao1270)
[ ]  Update version to 1.3.0 (by @baobao1270) and merge to master
[ ]  Release new version to VSCode Marketplace (by @baobao1270)

After change please describe how to use the feature you add, so that I can edit README and keep it documented.
Checklist:

[ ]  Change your code
[ ]  Provide description of your added feature (both in README with detail or in this PR comment in few words are OK)
[ ]  Test (by @baobao1270)
[ ]  Update version to 1.3.0 (by @baobao1270) and merge to master
[ ]  Release new version to VSCode Marketplace (by @baobao1270)

预览思维导图

在 VSCode 中新建或打开一个文件。
使用 Ctrl+Shift+P 快捷键打开命令面板，输入 Mind Map From File 命令。插件将提取文件中的 Markdown 标题文本，并按照标题层次构造思维导图，该导图显示在您编辑器右侧。
若您更改左侧源文件，停止修改后的2秒后，右侧的思维导图将同步更改。
您亦可使用鼠标滚轮随意缩放思维导图。

将 Markdown 标题写入到粘贴板

在 VSCode 中新建或打开一个文件。
使用 Ctrl+Shift+P 快捷键打开命令面板，输入 Copy Title From File 命令。插件将提取文件中的 Markdown 标题文本，将其写入到您的粘贴板中。
这些文本，您可将其粘贴到 .md 文件，使用 Xmind 导入，进行后期处理。


Avoid using cudf.read_parquet on the client process

While testing #1119, I realized that NVTabular is using the client process to read in parquet files in some places where either (1) a worker process would be better suited for the job, or (2) using the parquet metadata would suffice.
This PR uses delayed to move some read_parquet operations to the workers, and also uses parquet metadata in one place where the actual data is not necessary.
cc @jperez999

lgtm - thanks!

Oops - Looks like _reset_df_index is designed to mutate the categories argument. Fix on the way.


awscli2: 2.0.26 -> 2.0.36

Motivation for this change

API changes
bugfix for s3 cp

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 94635 1

1 package failed to build:
- awscli2

Result of nixpkgs-review pr 94635 1
1 package failed to build:

awscli2

Fixed the constraint on the cryptography package.

Result of nixpkgs-review pr 94635 1

1 package built:
- awscli2


Old Version on Google Hosted Libraries

Hi,
I’m just wondering why the latest version available on Google Hosted Libraries is 1.5.18 while the most recent version is 1.6.15. Is there any reason why the script on Google Hosted Libraries is that much older?

The Google CDN is controlled by Google, and as such it follows Google's release cycle. This means it is sometimes out of sync with the latest version in this repository. Apart from self-hosting the Web Font Loader, there's unfortunately not much we can do about it.


ESLint error for JsonObject

version: 0.15.0
export type Json = JsonValue

export type JsonArray = JsonValue[]

export type JsonObject = {
  [K in string]?: JsonValue
}

export type JsonPrimitive = boolean | number | string | null

export type JsonValue = JsonArray | JsonObject | JsonPrimitive

Error: ESLint: 'K' is defined but never used.(no-unused-vars)
How do I fix?
ESLint file:
{
  "env": {
    "browser": true,
    "es2021": true
  },
  "extends": ["eslint:recommended", "plugin:react/recommended", "next/core-web-vitals", "prettier"],
  "parserOptions": {
    "ecmaFeatures": {
      "jsx": true
    },
    "ecmaVersion": "latest",
    "sourceType": "module"
  },
  "plugins": ["react"],
  "rules": {
    "indent": ["warn", 2],
    "quotes": ["error", "single"],
    "semi": ["off"]
  }
}

Upvote & Fund

We're using Polar.sh so you can upvote and help fund this issue.
We receive the funding once the issue is completed & confirmed by you.
Thank you in advance for helping prioritize & fund our backlog.

Hey! I recommend you to exclude the generated file from your ESLint settings, and I very much recommend you to use @typescript-eslint/no-unused-vars instead of no-unused-vars as it doesn't work correctly for TypeScript code.
Regardless, to make it easier for future users (and legacy TypeScript users), the next version of kysely-codegen will switch to this equivalent syntax:
export type JsonObject = {
  [x: string]: JsonValue | undefined;
}

Thanks!

oh that's great; thanks so much!

Should be released in<EMAIL_ADDRESS>🚀


When doing npm install, the uninstall process is invoked, then all modules are deleted

Description
When I tried to npm install material-ui, the uninstall process is invoked and then I lost all node modules, why is this happening?
Please see the following log:

C:\project\react-boilerplate>npm install material-ui
><EMAIL_ADDRESS>uninstall C:\project\react-boilerplate\node_modules\pre-commit
> node uninstall.js
npm WARN gentlyRm not removing C:\project\react-boilerplate\node_modules\acorn-globals\node_modules.bin\acorn.cmd as it wasn't installed by C:\project\react-boilerplate\node_modules\acorn-globals\node_modules\acorn
npm WARN gentlyRm not removing C:\project\react-boilerplate\node_modules\acorn-globals\node_modules.bin\acorn as it wasn't installed by C:\project\react-boilerplate\node_modules\acorn-globals\node_modules\acorn
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^15.0.0 but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^15.0.0 but none was installed.

<EMAIL_ADDRESS>added 15 packages, removed 1163 packages and updated 47 packages in 33.132s

Versions

React-Boilerplate "version": "3.4.0",

C:\project\react-boilerplate>npm -v
5.0.3
C:\project\react-boilerplate>node -v
v8.1.2
C:\project\react-boilerplate>yarn -v
yarn install v0.24.6

...And yarn fixes my missing modules by this command, though I was just trying to see the version of yarn. Still, I'd like to know what triggered the uninstall process, otherwise I keep losing modules with every npm install.
Just for reference
The log of yarn fixing modules:

$ npm run npmcheckversion

<EMAIL_ADDRESS>npmcheckversion C:\d8\project\react-boilerplate
node ./internals/scripts/npmcheckversion.js

[1/4] Resolving packages...
[2/4] Fetching packages...
warning<EMAIL_ADDRESS>The platform "win32" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
[3/4] Linking dependencies...
warning<EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>|| ^2.1.0-beta || ^2.1.0".
warning<EMAIL_ADDRESS>has incorrect peer dependency "webpack@1 || ^2.1.0-beta".
warning<EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>[4/4] Building fresh packages...
success Saved lockfile.
$ npm run build:dll

<EMAIL_ADDRESS>build:dll C:\d8\project\react-boilerplate
node ./internals/scripts/dependencies.js

Building the Webpack DLL...
Hash: e1798f3d015c7553b0d0
Version: webpack 2.2.0-rc.3
Time: 7445ms
Asset     Size  Chunks                    Chunk Names
reactBoilerplateDeps.dll.js  4.54 MB       0  [emitted]  [big]  reactBoilerplateDeps
chunk    {0} reactBoilerplateDeps.dll.js (reactBoilerplateDeps) 3.76 MB [entry] [rendered]
[./node_modules/babel-polyfill/lib/index.js] ./~/babel-polyfill/lib/index.js 833 bytes {0} [built]
[./node_modules/core-js/index.js] ./~/core-js/index.js 639 bytes {0} [built]
[./node_modules/react-redux/lib/index.js] ./~/react-redux/lib/index.js 475 bytes {0} [built]
[./node_modules/react-router-redux/lib/index.js] ./~/react-router-redux/lib/index.js 1.97 kB {0} [built]
[./node_modules/react-router-scroll/lib/index.js] ./~/react-router-scroll/lib/index.js 512 bytes {0} [built]
[./node_modules/react-router/es/index.js] ./~/react-router/es/index.js 1.46 kB {0} [built]
[./node_modules/react/react.js] ./~/react/react.js 56 bytes {0} [built]
[./node_modules/redux-immutable/dist/index.js] ./~/redux-immutable/dist/index.js 390 bytes {0} [built]
[./node_modules/redux-saga/es/index.js] ./~/redux-saga/es/index.js 457 bytes {0} [built]
[2] dll reactBoilerplateDeps 12 bytes {0} [built]
[./node_modules/redux/es/index.js] ./~/redux/es/index.js 1.08 kB {0} [built]
[./node_modules/reselect/es/index.js] ./~/reselect/es/index.js 3.63 kB {0} [built]
[./node_modules/styled-components/dist/styled-components.es.js] ./~/styled-components/dist/styled-components.es.js 230 kB {0} [built]
[./node_modules/warning/browser.js] ./~/warning/browser.js 1.81 kB {0} [built]
[./node_modules/whatwg-fetch/fetch.js] ./~/whatwg-fetch/fetch.js 12.5 kB {0} [built]
+ 1017 hidden modules
Done in 65.54s.

No one else encounter this problem?

Yes i have this to. I use yarn now

@alexvandervegt thanks for replying. So I think this is kind of a bug? Some kind of inconsistency with the latest npm? Should it be fixed?

Nope its a command which is triggered in the package.json
But you can use yarn to install updates without a problem.

I think I'll use yarn instead of npm. But shouldn't npm to be working fine as well?
By "bug" I mean the "uninstall" command should not be triggered by a "npm install", which doesn't make sense.

@marsonmao, that definitely sounds like a bug, but I couldn't reproduce (I try everything on the dev branch)

I haven't got this issue before I upgraded to node 8 and npm 5, I guess it's due to these new versions.
Could you give me some hint how pre-commit's uninstall.js is being invoked right now? I can try to trace the cause.

Had same issue i used node v8.1.2 (current one) cloned repo
"npm install -g yarn"
"npm run setup"
"npm run start" (after i got good look around i stopped copied it in another dir for reference)
"npm run clean"
"npm run start"
New cmd shell.
"npm install --save react-bootstrap"
and it uninstalled around most of packages and installing bootstrap but leaving it in nonfunctional state.

I have had a very successful install of many Node versions (with tj/n). Installing npm v5 totally broke this setup (having nothing to do with RBP).
tj/n has an npm update script that installs the latest version of npm for all locally available versions of Node. This script reports success, but fails to install npm 5.
In my experience, npm 5 represents a major breaking change from earlier versions.
While npm 5 is included with latest Node, getting it to work with existing systems (e.g. RBP) appears to be a challenge.

Could you give me some hint how pre-commit's uninstall.js is being invoked right now

We don't call it manually, that's how pre-commit works (look at their package.json, uninstall script), as @gihrig said, npm 5 has some breaking changes and also a bunch of bugs: https://github.com/npm/npm/issues?q=is%3Aissue+is%3Aopen+label%3Anpm5

btw, it's not just RB, take a look at https://github.com/npm/npm/issues/17379

added 1 package and removed 643 packages in 9.524s

smart thinking, npm, why do you need so many packages, one should be clearly enough 😄

Captain Obvious here, but "fixing" RBP is clear not the right thing. 😁
Closing as not an RBP issue. Feel free to discuss...

Ok, so for anyone that getting this uninstall issue, just install packages by yarn instead of latest npm.

I have something similar to this, in my case, the solution was to use Yarn package manager and "upgrade" the typescript compiler (tsc) using this tool.

same here, using node v8.11.1 and when running
npm install --save reactstrap@next react react-dom
it delete all the node_modules item


State is ignored silently when extractor does not advertise state capability

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/2169
Originally created by @DouweM on 2020-07-14 20:27:33

When this happens, we should log a warning.

View 2 previous comments from the original issue on GitLab


This exercise don't have the link to bootstrap ->

Challenge http://www.freecodecamp.com/challenges/waypoint-mobile-responsive-images has an issue. Please describe how to reproduce it, and include links to screen shots if possible.

I am curious about this myself! It says they added it in already, but I am really curious about how to add it in myself for future reference.

What I think they mean by "automatically added it" is that, since FreeCodeCamp uses Bootstrap, it's already loaded in your browser, and you don't need to add it to the editor. I do believe it would be good to show the campers how it's done, and it really wouldn't be that hard.

Since the site overhaul, this is no longer an issue in http://www.freecodecamp.com/challenges/waypoint-make-images-mobile-responsive


TryFromSliceError?

TryFromSliceError is an obvious one for a map_res().  I think there is a trait that could be implemented for this type to ease things?

Duplicate of #1479


Add -blackbox flag to cutpoint pass

What are the reasons/motivation for this change?
Black/white boxes cannot be processed by sby, so they must be substituted by $anyseq cells.
Explain how this is achieved.
Adding a -blackbox flag to cutpoint.
If that flag is set, we find all modules that are black/white boxes, add their module names to the select pattern, and remove their black/whitebox attribute.
If applicable, please suggest to reviewers how they can test the change.

This approach won't work. extra_args can throw a message about invalid arguments, and the design must not be modified in any way prior to that. And given that the select argument is a stack-based sequence of instructions, appending something to the user-provided argument can have quite unpredictable and difficult-to-debug consequences. Please make a separate loop in the body of the pass that handles modifying the blackboxes directly.

Yes, I think the approach followed in https://github.com/YosysHQ/yosys/pull/4565 could be more succesful.
It takes care of not breaking passes that need to filter out blackboxes and at the same time enables blackbox selection when needed.


pep8: Fix E301 pep8 violations

Fix "E301: expected (1 or 2) blank line" pep8 violations.

Automated message from Dropbox CLA bot
@rafidaslam, it looks like you've already signed the Dropbox CLA. Thanks!

@rafidaslam, Looks great!  I am going to approve the task now, but I'll wait for @timabbott to actually merge this.

Merged, thanks @rafidaslam!

Congrats on your second pull request being merged :)


Malleable VIs...

I'm thinking that Remote Control should not be a VIM... Also the others?

Remote Client.vim

I've decided that Remote Client.vim will remain a malleable VI. There are several changes for the next release (v1.14):

Send and Receive.vi is no longer a malleable VI. I don't think that it made sense to be one.
no longer calls Local Client.vi(m). If you want a Local Client, don't call Remote Client.
there is now preprocessing inside Remote Client.vim (Validate API Method.vi) to determine if a valid command is being sent

Validate API method is called outside of the Error case structure. If the command is not supported Validate API method will return an error...
It is expected that child classes will override Get SMO Public API.vi with the list of API methods that they support.

Returns are processed with JSON-RPC.lvclass:JSON to LVtype.vim. This method is intended as a replacement for Instrument.lvclass:Variant to LV Data.vim

Local Client.vi

No longer a malleable VI. My philosophy is that Local Client will be used to handle internal messages (e.g. SMO to SMO). As such I would like to give greater control to the developer to handle formatting of their data. For example they may not want to format their payload as JSON because of the performance hit.
Notice that Local Client.vi is basically a fancy wrapper for Instrument.lvclass:sendMessageToProcess.vi with a mailbox for receiving message responses:

If you don't need or want a response then you can just call sendMessageToProcess.vi directly.

Remote Control.vim --> Remote Control.vi. Let the calling VI handle datatype....

Remote Control is no longer malleable.
Somewhere the spaces got removed, but now they are again Local Client.vi and Remote Client.vi.
Note that Client.vi is a new dynamic dispatch VI; the parent method selectively calls Remote Client or Local Client ()Issue #102)

Remove once and for all all malleable VIs directly owned by Instrument.lvclass:

Remote Client.vim: instead use Client.vi
Set Config.vim: instead use setConfiguration.vi
getAll.vim: instead use getAll.vi
Get All.vim: instead use getAll.vi


Loading of aggregation data into in-memory aggregation runtimes cause out of memory issue

Description:

Suggested Labels:

Suggested Assignees:

Affected Product Version:
2.6.0
OS, DB, other environment details and versions:
Steps to reproduce:
Related Issues:

Cannot reproduce and upgraded to the latest siddhi dependencies in Analytics 3.2.0.
Hence closing.


Question: how does your testing setup work?

Hi @andweeb !
I've been researching how folks approach testing Hammerspoon-related projects.  The process has been more challenging than expected: ki is one of the only Hammerspoon projects I've found with a substantial test setup.
Context
My project (https://github.com/AdamWagner/stackline) has grown to the point that the majority of development time is spent following-up on collateral damage caused by a (seemingly) small, unrelated change. Even when I catch it early, the side effects often ripple until I'm troubleshooting something several levels removed from the original intent. I need to add tests!
stackline makes heavy use of hs.window. Ideally, I would like to have a handful of fixtures, each representing the complete window state of a test scenario.
Questions about testing in ki
Mocking
How does https://github.com/andweeb/ki/blob/master/spec/mock-hammerspoon.lua work? It seems that most of the mocked methods are no-ops, and I don't understand why that is useful. But, I'm sure I'm missing something.
Not invented here (?)
It doesn't seem like you're using a test framework such as busted. Is that correct? Did you author all of the describe(…) functions that perform the actual tests? Is all of that source code in this repo?
Anything else you think could help
As you can see, my starting point is just past lua-noob, so anything you think might be helpful surely will be :-)

Hi @AdamWagner 👋 These are good questions! I did the same research while creating Ki and found there weren't many resources or conventions, at least at the time. So hopefully this helps!
Mocking
The mock-hammerspoon.lua file contains a hs object with a subset of its methods stubbed out (only the ones used in my project). This is basically what you would call a manual mock in Jest or a "hand-rolled" mock. It's not useful by itself, but you can see at the bottom of the file I expose a factory function to use in the test files to not only have a "default" Hammerspoon environment so tests don't break but also be able to mock a subset of the methods differently for individual test suites.
Not invented here (?)
I do use busted! You can see in my Makefile here I leverage their tagging system and use their framework in my tests, and use LuaCov with luacov-console for code coverage and console reporting.
Anything else you think could help
Just an FYI if you'll be using my tests as reference, in my unit tests I've adopted the convention of using table-driven tests, a popular model of testing in Go. Many of the conventions I used in this project are borrowed from outside of the realm of Lua, so I wouldn't consider my tests as the golden standard, but they've just worked well for me!
Let me know if you have any other questions, and/or suggestions too!

Thanks so much for the helpful response, especially since I probably should've been able to find the answers to a lot of these in the source (always obvious in hindsight :-)
The link to the Jest docs was quite helpful. I should have said that I'm not just a noob in lua, but in general; this will be my first time actually writing tests for a side project.
I really like the look of the table-driven tests. Easy to read. I'll definitely be using your work here as a model. Thanks!


Cannot ready property 'toString' of null

🐞 Bug report
Getting error toString of null while running command nx generate @scullyio/init:markdown --project=scully-hour
Description
I've created a nx-workspace base angular application with **nx** cli and **workspace.json**, and was adding the blog to the application, but while executing the command nx generate @scullyio/init:markdown --project=scully-hour it gives error toString of null.
🔬 Minimal Reproduction

Create an nx workplace with empty preset yarn create nx-workspace nx-office-hour. Select empty workspace and NX as default cli.
Install angular plugin yarn add -D @nrwl/angular.
Create Angular application with router module nx generate @nrwl/angular:application --name=scully-hour --style=scss --linter=eslint --prefix=scull-hour --routing.
Create a Home module and component add a route to the RouterModule in the app module.
Install Scully yarn add @scullyio/init .
nx g @scullyio/init:install -- --project=scully-hour.
Run blog command  nx generate @scullyio/init:blog

💻Your Environment
Angular Version:

10.0.0

Nx Version:

10.0.12

Scully Version:

    "@scullyio/init": "^1.0.0-beta.0",
    "@scullyio/ng-lib": "^1.0.0-beta.0",
    "@scullyio/scully": "^1.0.0-beta.0",

🔥 Exception or Error

$ nx generate @scullyio/init:markdown --project=scully-hour
? What name do you want to use for the module? blog
? What slug do you want for the markdown file? id
? Where do you want to store your markdown files? blog
? Under which route do you want your files to be requested? blog
    ✅ Update scully.scully-hour.config.ts
Cannot read property 'toString' of null

@navneetsharmaui Can you update your schematics to "@scullyio/init": "^1.0.0-beta.1",

@jorgeucano that resolved the issue but now it's not updating the routes array.


Localize most_severe_accidents_table Widget

Add translation dictionary to most_severe_accidents_table - and localize it
Translation needed: accident type ("type" field in widget)
All accident type can be found in accident_type table in DB (You can also see then in the Fields meaning google sheet)

Note that the CBS changed the Hebrew translation in the past (meaningless changes -התנגשות חזית אל צד VS  התנגשות חזית בצד) - That's way I suggest creating a dictionary containing the accident type code and not Hebrew translation
This dictionary might will be also used for additional Widgets as well.
Please use the translation that exists in this file and however if you think translation needs to be changed - don't hesitate.

Localize title.

Widget Example:
"name": "most_severe_accidents_table",
"data": {
"items": [
{
"accident_year": 2019,
"accident_severity": "severe",
"type": "התהפכות",
"date": "09/06/19",
"hour": "20:30",
"killed_count": 0,
"severe_injured_count": 1,
"light_injured_count": 0,
"injured_count": 1
},
{
"accident_year": 2017,
"accident_severity": "severe",
"type": "התנגשות חזית בצד",
"date": "27/06/17",
"hour": "15:00",
"killed_count": 0,
"severe_injured_count": 2,
"light_injured_count": 2,
"injured_count": 4
},
{
"accident_year": 2016,
"accident_severity": "severe",
"type": "התנגשות חזית בצד",
"date": "01/07/16",
"hour": "16:30",
"killed_count": 0,
"severe_injured_count": 1,
"light_injured_count": 2,
"injured_count": 3
},
{
"accident_year": 2020,
"accident_severity": "light",
"type": "התנגשות עם רכב חונה",
"date": "26/06/20",
"hour": "15:45",
"killed_count": 0,
"severe_injured_count": 0,
"light_injured_count": 1,
"injured_count": 1
},
{
"accident_year": 2020,
"accident_severity": "light",
"type": "התנגשות עם עצם דומם",
"date": "17/06/20",
"hour": "15:30",
"killed_count": 0,
"severe_injured_count": 0,
"light_injured_count": 3,
"injured_count": 3
},
{
"accident_year": 2020,
"accident_severity": "light",
"type": "התנגשות חזית בצד",
"date": "12/06/20",
"hour": "14:00",
"killed_count": 0,
"severe_injured_count": 0,
"light_injured_count": 5,
"injured_count": 5
},
{
"accident_year": 2020,
"accident_severity": "light",
"type": "התנגשות חזית באחור",
"date": "05/06/20",
"hour": "15:00",
"killed_count": 0,
"severe_injured_count": 0,
"light_injured_count": 2,
"injured_count": 2
},
{
"accident_year": 2020,
"accident_severity": "light",
"type": "התנגשות צד בצד",
"date": "09/05/20",
"hour": "11:30",
"killed_count": 0,
"severe_injured_count": 0,
"light_injured_count": 1,
"injured_count": 1
},
{
"accident_year": 2020,
"accident_severity": "light",
"type": "התנגשות צד בצד",
"date": "02/05/20",
"hour": "15:00",
"killed_count": 0,
"severe_injured_count": 0,
"light_injured_count": 1,
"injured_count": 1
},
{
"accident_year": 2020,
"accident_severity": "light",
"type": "התנגשות חזית באחור",
"date": "25/01/20",
"hour": "17:30",
"killed_count": 0,
"severe_injured_count": 0,
"light_injured_count": 4,
"injured_count": 4
}
],
"text": {
"title": "תאונות בסדר חומרה יורד במקטע צומת טבריה - צומת כפר נחום"
}
}
@idosavion  I created the following template to be used in the coming similar issues. Any thoughts?

duplicate of #1588


Bug: Union Type Results fails to Serialize/Deserialize

Problem
Currently, if I write:
import pydantic_xml as pyxml
from typing import Literal
from typing import Union

class Person(pyxml.BaseXmlModel):
	name: str = pyxml.attr()

class CEO(Person):
	position: Literal['CEO'] = pyxml.attr()

class CTO(Person):
	position: Literal['CTO'] = pyxml.attr()

class Company(pyxml.BaseXmlModel):
	employee_of_month: Union[CEO, CTO] = pyxml.wrapped('employee_of_month', pyxml.element(tag='person'), discriminator='position')

a = Company(employee_of_month=CEO(name='Vincent', position='CEO'))
print(a.to_xml(encoding='UTF-8').decode())

I get the error message: TypeError: Object of type CEO is not XML serializable.
I expect that this should not fail, since CEO is one of the valid options. Likewise the following XML should be successfully deserialized:
<Company>
  <employee_of_month>
    <person name="Vincent" position="CEO"/>
  </employee_of_month>
</Company>

However, it results in validation error: pydantic.error_wrappers.ValidationError: 4 validation errors for Company
Justification
This feature is supported by native pydantic:
a = Company(employee_of_month=CEO(name='Vincent', position='CEO'))
a_str = a.json()
a_str = a_str.replace('CEO', 'CTO')
b = Company.parse_raw(a_str)

This feature is desirable in the scenario that an extra field for certain people:
class CEO(Person):
	position: Literal['CEO'] = pyxml.attr()

class CTO(Person):
	position: Literal['CTO'] = pyxml.attr()

class PublicRelationsDirector(Person):
	position: Literal['PR'] = pyxml.attr()
	public_email: str = pyxml.attr(name='email')

Support for this will also allow for more robust deserialization. For example, consider the following XML:
<people>
	<person name='Steven' position='engineer'>
		<product>My App</product>
	</person>
	<person name='Phil' position='engineer'>
		<project>Infrastructure Upgrade</project>
	</person>
	<person name='Ryan' position='engineer'>
		<product>My App</product>
	</person>
</people>

With this feature, the discriminator could be used to sort between engineers working on internal infrastructure and user facing product.

@schang412 Hi,
Due to implementation details Union types are not yet supported.

Union type support implemented in version 0.6.0.


Resolve hostnames asynchronously

Resolves #6
Thanks for the tool, I love it!
So, in addition of resolving the hostnames in a thread pool I went for making it asynchronous. It should be more performant as we will not block the threads waiting for the response from the dns servers. Let me know if you like the approach.
I have doubts about some changes I made, I will leave some comments.

This looks great! I'll go over it in the next few days.

Hey, just a heads-up, I'm waiting for this issue to be solved. Tokio 0.2.0 was released two days ago and broke a bit the ecosystem, dependent crates are catching up.

Thanks for the update!

It seems that the issue I mentioned can't be fixed until next week because some dependency is blocking it. For the moment I've done as the author suggests and I'm using the branch that will be merged when the issue is solved.
We should either not merge this PR until the issue is solved or change the version in Cargo.toml as soon as a new one is available (remember that you can't cargo publish with a git dependency).
I think I've dealt with all the suggestions, let me know what you think!

Hey, just squashed and rebased on top of the new changes in master to solve the conflicts

You are extremely fast :D Still merging

The changes look great. I especially liked the naming (eg. dns_client), your solution with the cache method and the Lookup trait. Good stuff.
I also took it out for a spin and it works really fast!
About the trust-dns-resolver issue: I have managed in the past to publish to cargo with a git dependency. All it required was to add the version as well as the url to Cargo.toml (though that was a dev dependency, so I wonder if it will also work here pondering eomji). I wouldn't want to do that if it can be avoided though (because github is a mutable medium).
Let's give it a week until we merge and if it's not over by then, we'll think up another solution for it. Sounds okay?
Meanwhile I'm going to hold off on releasing the other changes in master.

Sounds good to me!

A new version of trust-dns was released :tada:


Support for storing images and 3D models

In few studies in qiita, there are 3D models and pictures that allow for vizualization in ili.  While the coordinates can be stored in qiita, the images cannot be atm.
It would be nice if the STL files or images could stored in qiita.  But should this be done?

I think the best solution here is to add ili as a plugin once the analysis part is moved to plugins. Then this objects will just be a type of artifact that ili needs to be able to run.

I think adding the possibility of adding "random" files to the study, something like attachments, will be useful. However, I would like to set some ground rules for those attachments but at the same time be open to add/link whatever. Something that comes to mind is simply limit to 4M the max size of the attachment. Note that this will mean that we will get rid of the extension check in the uploader ...

Is there an Ili plugin page this can be added to?

Closing in favor of: https://github.com/biocore/qiita/issues/2215


Issue #27: Add Twitter Scraping of fields created_at and member_since

CAUTION: The new date formatting could lead to problems in the ingestion! (Repo: ingestion-scripts; File: src/twitter_consumer.py; Line: 75)


Load configuration from file

Right now you have to add the configuration manually each boot.


Beats v6.3, along with a more distinguishable and maintainable docker image naming

All the awsbeats images look like s12v/awsbeats:${awsbeats_ver}-${beat_name}-${beat_ver}, so that you can decide the awsbeats version, beat name, and the beat version independently.
@s12v Perhaps this helps you to automate the docker image publishing using make targets like filebeat-image? :)

Codecov Report

Merging #37 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #37   +/-   ##
=======================================
  Coverage   63.63%   63.63%
=======================================
  Files           4        4
  Lines         132      132
=======================================
  Hits           84       84
  Misses         42       42
  Partials        6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e914bde...c826a64. Read the comment docs.


Disable wasm-env and livenet-env from Codeconv

I think you could disable wasm-env and livenet-env from Codeconv. You can do it by setting crates to test with -p.
cargo test -p odra -p odra-core ...

Originally posted by @zie1ony in https://github.com/odradev/odra/pull/342#pullrequestreview-1861853815
I think it will be better to try excluding it in .codecov.yml - Kuba

Go for it, if it is possible.


Sdl2TtfContext::load_font() shouldn't have a lifetime parameter for path?

The signature for load_font is: fn load_font<'a>(&'a self, path: &'a Path, point_size: u16) -> Result<Font, String>
As far as I can tell (though I did not do an EXHAUSTIVE search), there is no place in SDL2_ttf's Font object that actually stores a reference to the path.  So, this path doesn't actually need the lifetime parameter which demands that the Path has to live as long as the Sdl2TtfContext object.  Even if it does, the only sane thing to do here would be to make the load_font() function either take ownership of a Path or clone it, because the only alternatives are ridiculous.
  :/ )
Also, if you used AsRef<Path> instead of Path it makes it possible to feed strings and such directly into these sorts of functions.

Dang it, I had a nice answer but I actually discarded it by accident.
Long story short: yes to everything you said, AsRef should not break API, do you want to patch this ?

If we're sure that it actually is okay (which we should double-check, if you haven't already), then sure, I'll submit pull requests for both the Path lifetime and the AsRef<Path> thing.  Gimme a few days for, you know, Christmas and stuff.

Fixed in v0.27.3


refactor: small improvement for empty contracts

@carletex I cleaned it up a little and the empty contracts is now null, that way we no longer need to check Object.keys().length, which is a bit cleaner.

Looks clean !! Tested out and it works nicely 🙌

Amazing, thanks!!!


Impossible to save a package if installed previously

If you want to save a package that you have already installed with bowerphp install jquery-address.
It will fail because there is a check for that in bowerphp.php line 100.
Not sure what the best approach is in this case ?

Bower does just the same: if a package is already installed, it's not installed again.

It's right that it does not install it again but it should add it in the bower.json

No. There is no implicit adding in bower.json, you need to use -S flag

I know.
The problem is that it won't add it to the bower.json when using bowerphp install -S jquery-address , if that package has already been installed previously using bowerphp install jquery-address.
The bug is that the -S option doesn't work if the package is already installed.
Maybe the easiest/cleanest fix is just to check for the -S option before to try to install ?

The problem is that it returns on line 104 if the package is already installed with the same version. That's before it's checking for the -S option on line 116.

I have to check but I also have the impression that the version in bower.json file won't be updated if a package is updated.

Well my remark about the update command make no sense. As it will only update depending on the version requirements.


The dora stop uuid unable to delete a running dataflow

Describe the bug
The dora stop uuid unable to delete a running dataflow. The dora destroy command works, but an exception is reported, and the exception is not handled correctly
To Reproduce
Steps to reproduce the behavior:

Dora start daemon: dora up
then execute dora start graphs/tutorials/webcam_yolov5.yaml --attach

Screenshots or Video

Environments (please complete the following information):

System info: Linux jia 5.15.0-69-generic #76~20.04.1-Ubuntu SMP Mon Mar 20 15:54:19 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Dora version: 0.2.2

Thanks for reporting! Could you give us more details on how to reproduce this issue? The screenshot shows a different set of commands than you listed above. And I assume the dataflow you're referencing is https://github.com/dora-rs/dora-drives/blob/main/graphs/tutorials/webcam_yolov5.yaml?

Thanks for reporting! Could you give us more details on how to reproduce this issue? The screenshot shows a different set of commands than you listed above. And I assume the dataflow you're referencing is https://github.com/dora-rs/dora-drives/blob/main/graphs/tutorials/webcam_yolov5.yaml?

Yes! just do it

This problem, has been fixed in this commit a308c48f3e842cecd994a9b36a51750e008e63c1.
git show a308c48f3e842cecd994a9b36a51750e008e63c1


Favicon update Required

I would like to point out that the favicon for this website of  hacktoberfest 2022 😅 .

I would love to change it to the latest ones
Pls, assign this issue to me so that I can start working on this issue. @max-programming

Thanks for assigning. Will start working on it. 🚀


WIP Statistics

Implemented statistics for single populations. GAPopulationStats will store Raw and Fitness score sum, max, min, average, variance and standard deviation. The new GAPopulation::statistics() method will compute them and return a clone of the statistics, while storing one in the GAPopulation object. So all callers will obtain a separate copy of the statistics.
Global statistics (ga_statistics.rs) is still a very early WIP. I didn't respect galib's names for the members of GAStatistics, because they are confusing and use inconsistent naming. Here we can explore the use of existing statistics crates:

rust-stats: Implements all the basic statistical functions that we need.
R

@mrjackinc @Sysnett

galib's GAStatistics::updateBestIndividual() is expensive and the author admits it in the code comments. I'm currently writing code for it with another data structure, such that look ups are faster.

GAStatistics:: update_best() is implemented, but untested. It also needs refactoring: Same algorithm for LowIsBest and HighIsBest, only comparison signs change. Ideally, make T: GAIndividual implement also PartialOrd; but then the comparison also depends on the population's GAPopulationSortOrder; and then compared individuals belong to 2 different populations, in the case of update_best().

@mrjackinc Comments on this branch? GAPopulationStats is tested. GAStatistics::update_best() is still untested; might as well not review it yet.

It looks good in general. I'm not loving the code duplication due to SortOrder and SortBias, I feel we're misusing something as this should be cleaner, but I don't have anything solid on feedback.

Fixed bugs in update_best(). But broke the populations clone test.


Restrict extra props

Signed-off-by: Matthias Pichler<EMAIL_ADDRESS>
Please specify parts of this PR update:

[ ] Specification
[x] Schema
[x] Examples
[ ] Extensions
[ ] Use Cases
[ ] Community
[ ] CTK
[ ] Other

Discussion or Issue link:

What this PR does:

I added a lot of unevaluatedProperties: false to restrict extra props
Additional information:

I wonder if this PR isn't a bit too drastic (but it might not be).
An important feature of the spec is its extensibility. By restricting everything, we might lose a some of the flexibility.
For instance (as I commented earlier before deletion), the document could be extended by some runtime with metadata (e.g.: author, tenant, group, ...).
The author of a workflow also have access to very powerful variables, namely $workflow and $task. Therefore, he can define custom properties (e.g. $task.with.params.$filter or $workflow.constants.someKey) that could be used/remapped in some custom functions.
I'm not sure how to verify we didn't restrict the author too much here. At a glance, I think it's quite ok but it's not a very empirical approach ^^'

I wonder if this PR isn't a bit too drastic (but it might not be).
An important feature of the spec is its extensibility. By restricting everything, we might lose a some of the flexibility.
For instance (as I commented earlier before deletion), the document could be extended by some runtime with metadata (e.g.: author, tenant, group, ...).
The author of a workflow also have access to very powerful variables, namely $workflow and $task. Therefore, he can define custom properties (e.g. $task.with.params.$filter or $workflow.constants.someKey) that could be used/remapped in some custom functions.
I'm not sure how to verify we didn't restrict the author too much here. At a glance, I think it's quite ok but it's not a very empirical approach ^^'

Very good points here, however I feel like I have to counter with the fact that I came across the issue because some example workflows behaved differently than expected 😅 After updating the schema I had to fix 3 examples in the repo and none of us caught these errors. So on behalf of authors I would advocate for better feedback from tooling which need a schema.
Maybe we could introduce a dedicated field for metadata similar to JSON API 🤔

I agree with @JBBianchi that we should preserve extensibility, without however, as pointed out by @matthias-pichler-warrify, loosing (schema-based) validation features.

Maybe we could introduce a dedicated field for metadata similar to JSON API 🤔

Maybe we could reintroduce that property in specific places, indeed. Maybe even everywhere? I don't really have a strong opinion on that subject, so I'll leave it up to you guys 😉

Maybe we could reintroduce that property in specific places, indeed. Maybe even everywhere? I don't really have a strong opinion on that subject, so I'll leave it up to you guys 😉

@cdavernas what I also thought of just now:
alternatively we could enforce a prefix for custom/meta fields? Something like $, @ or _?
document: {}
do:
  - getPet:
       call: http
       with: {}
       $foo: bar

no preference for any given prefix

alternatively we could enforce a prefix for custom/meta fields?

Why not? Good idea, even though I personally am not a huge fan of it, as I think it would "dirty" the definition. But again, no strong opinion here anyways.
@JBBianchi @fjtirado @ricardozanini What fo you guys think?

I think we might add a "custom" key in those places where we think implementors might add custom stuff.
For example
document: {}
do:
  - getPet:
       call: http
       with: {}
       custom:
         alternativeBaseURI: www.alternative.com

@fjtirado

I think we might add a "custom" key in those places where we think implementors might add custom stuff.

Yeah so custom, meta or similar. (name is still open I think). However this would be for authors not implementors

@matthias-pichler-warrify Sure authors would use them and implementors might implement it ;)

I think the callTask shouldn't be restricted, otherwise it clashes with custom functions, doesn't it ?

@JBBianchi is this portion of the schema are you referring too?

- title: CallFunction
        $ref: '#/$defs/taskBase'
        type: object
        unevaluatedProperties: false
        required: [ call ]
        properties:
          call:
            type: string
            not:
              enum: ["asyncapi", "grpc", "http", "openapi"]
            description: The name of the function to call.
          with:
            type: object
            additionalProperties: true
            description: A name/value mapping of the parameters, if any, to call the function with.

If so, I think it's correct. It's the with property that requires any object and the schema seems to allow it.
A way of validating this PR is to add an example that breaks the rule on purpose. We should always add examples/test cases to PRs that change the schema. I'll try to reinforce that in the CI.

@JBBianchi is this portion of the schema are you referring too?
- title: CallFunction
        $ref: '#/$defs/taskBase'
        type: object
        unevaluatedProperties: false
        required: [ call ]
        properties:
          call:
            type: string
            not:
              enum: ["asyncapi", "grpc", "http", "openapi"]
            description: The name of the function to call.
          with:
            type: object
            additionalProperties: true
            description: A name/value mapping of the parameters, if any, to call the function with.

If so, I think it's correct. It's the with property that requires any object and the schema seems to allow it.

You're absolutely right.

Is there anything else needed to merge this?

@matthias-pichler-warrify Not that I know of. Merged, thanks for the reminder!