react/jsx-indent-props false positive in ternary operator

Since 7.21.4 I get a react/jsx-indent-props false positive when using props in a ternary operator. I thought issue I'm having is the same as https://github.com/yannickcr/eslint-plugin-react/issues/2828 and thus would be fixed in 7.21.5, but it looks like https://github.com/yannickcr/eslint-plugin-react/issues/2828 is fixed in 7.21.5 and this is not. 7.21.3 works fine. See below for eslint config.
Error

Code
import { h } from "preact";

const Component = (props) => {
  return props.prop
    ? <input
      type="email"
    />
    : "";
};

export default Component;

eslint-Config
{
  "env": {
    "browser": true,
    "commonjs": true,
    "es6": true,
    "jest": true
  },
  "globals": {
    "Atomics": "readonly",
    "SharedArrayBuffer": "readonly"
  },
  "parserOptions": {
    "ecmaVersion": 2020,
    "sourceType": "module"
  },
  "extends": [
    "standard",
    "eslint:recommended",
    "standard-react"
  ],
  "plugins": [
    "react-hooks",
    "jsx-props-no-empty-lines"
  ],
  "settings": {
    "react": {
      "pragma": "h",
      "version": "16.3"
    }
  },
  "rules": {
    "indent": [
      "error",
      2
    ],
    "linebreak-style": [
      "error",
      "unix"
    ],
    "quotes": [
      "error",
      "double"
    ],
    "semi": [
      "error",
      "always"
    ],
    "no-unused-vars": [
      "error", {
        "vars": "all",
        "args": "after-used",
        "ignoreRestSiblings": false
      }
    ],
    "eqeqeq": ["error"],
    "no-redeclare": ["error"],
    "no-empty": ["error"],
    "vars-on-top": ["error"],
    "no-eq-null": ["error"],
    "no-extra-boolean-cast": ["error"],
    "no-label-var": ["error"],
    "no-undefined": ["error"],
    "no-use-before-define": ["error"],
    "no-mixed-requires": ["error"],
    "camelcase": ["error"],
    "no-mixed-spaces-and-tabs": ["error"],
    "no-multi-assign": ["error"],
    "no-const-assign": ["error"],
    "no-var": ["error"],
    "prefer-const": ["error"],
    "operator-linebreak": ["error", "before"],
    "no-console": ["error"],
    "react-hooks/rules-of-hooks": "error",
    "react-hooks/exhaustive-deps": "warn",
    "jsx-props-no-empty-lines/no-empty-lines": "error",
    "jsx-quotes": ["error", "prefer-double"],
    "react/jsx-pascal-case": "error",
    "react/prop-types": [0],
    "react/jsx-closing-bracket-location": [0],
    "react/jsx-closing-tag-location": [0],
    "react/jsx-handler-names": [0],
    "react/jsx-indent-props": [
      "error",
      2
    ]
  }
}

This looks like a correct error to me, the code should be:
const Component = (props) => {
  return props.prop
    ? <input
        type="email"
      />
    : "";
};

@ljharb Thanks for the tip. But I wonder why the indentation convention you are using is the correct one. Is this convention enforced by the jsx-indent-props rule?
I'm asking because if I adapt my styling the way you suggest, then this is against eslint's own indent rule and eslint remarks that the indentation is now too high:

If this is not a bug but a fix, then it seems to me that two contradicting styling conventions for multi-line expressions inside a ternary operator are tried to be enforced, and I wonder how I can adjust the settings of both rules to follow one consistent approach.

hmm, interesting. Personally, I surround all multiline jsx in parens, like this:
const Component = (props) => {
  return props.prop
    ? (
      <input
        type="email"
      />
    ): "";
};

which i believe would pass indent just fine. If you're not willing to do that, then I'm not sure off the top of my head how to make all the rule configs coexist, but I'm open to suggestions.

Yes, this works for me and passes both rules. Thank you. I don't prefer any convention over the other so basically I'm happy to adapt my codebase.
But in the end I think it is a matter of taste. The rule configs did coexist before 7.21.4. The change resulting in the error I'm getting was proposed in https://github.com/yannickcr/eslint-plugin-react/issues/647 and introduced with https://github.com/yannickcr/eslint-plugin-react/pull/2808
My suggestion is to allow the user the decision if the indent level should be increased by a preceding ? or : operator in the line above. Maybe this could be achieved via an additional setting called "increaseByTernaryOperator" or something like that. It could have a default setting of true.
I'm not a versed eslint developer but I could try to create a PR if you like.

I think a PR that adds an additional option that controls, in a multiline ternary, whether the ?  and :  are counted as part of the indentation would be reasonable.

I've created a PR: https://github.com/yannickcr/eslint-plugin-react/pull/2846

Facing same issue.


remove prebuilt cache

it increases the closure size and limits the system we support
in the future we can implement this better in the script

I think the builtin index DB is quite useful and increases the UX of comma a lot as users can just install and use the tool without extra steps that involve learning about the nix-index tool etc.
We could just allow the builtin index to be null and set it null whenever it's not available for a system.

The builtin index should be handled outside of nix in the script because it is quite large

The builtin index should be handled outside of nix in the script because it is quite large

Sounds like a good idea. I think this should be implemented by the current PR. Then we won't lose that feature.

i merged this now so he users who couldn't install comma now can install it
i'll start working on implementing it in the script now

actually, that feature should be implemented in nix-index itself

actually, that feature should be implemented in nix-index itself

I'm not sure if I would agree.  Next time it would be nice if you would check what others think about it, before deciding about such change.
Why do I think this feature is important?

Earlier you could just do a nix shell nixpkgs#comma and have a fully featured comma quickly.
This capability is now broken through that PR.


[Feature Request]: Enhancement of the website

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
the text in white boxes is not visible so I will change the interface according to website theme
https://github.com/Recode-Hive/Stackoverflow-Analysis/assets/155231566/432d06c8-d4eb-4961-bd5f-6935c09c1496
Use Case
this feature would improve the look of website.
please assign this issue to me.
additionally, I would like to add items in Nav bar of the website
Benefits
No response
Priority
High
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC contributor
[X] I want to work on this issue
[X] I'm willing to provide further clarification or assistance if needed.

I have to look at this, because there is another person working on the similar issue

Is this issue solved? If not I would like to work on it

yes this has been done, you can work on the

adding more years code is available in ipynb file.create a new issue if you would like to work


web infrastructure is not all under W3C's scope

I like the characterization of W3C's mission to be focused on web infrastructure; but the current articulation in the introduction makes it sound like all web infrastructure is under W3C's scope.
This document focuses specifically on revising the governance structure of W3C - which is fine, but it should be made clearer (if only because there may be a useful broader conversation to be had in managing that infrastructure across different governance systems)

I agree that the use of 'infrastructure' here is likely to be confusing to many.

I've clarified that the W3C is only working on some of that infra, that only part of the infra is under the community's current remit. LMK what you think.


Get the first deployment done

@tewen did really good work here and I've been remiss in actually using it. That needs to end and for that to happen, I need to deploy his cloudformation work to AWS. Let's see how it goes....

The process here was pretty smooth. I already had sam installed, I didn't bother with the IDE stuff, and I mostly just ran the guided installation, which resulted in this:
↪ sam build --use-container
Starting Build inside a container
Building codeuri: /home/mlissner/Programming/awscloud/cl/recap_email runtime: python3.8 metadata: {} architecture: x86_64 functions: ['RecapEmailFunction']

Fetching public.ecr.aws/sam/build-python3.8:latest-x86_64 Docker container image..........................................................................................................................................................................................................................................................................................................................................................................................................................................
Mounting /home/mlissner/Programming/awscloud/cl/recap_email as /tmp/samcli/source:ro,delegated inside runtime container

Build Succeeded

Built Artifacts  : .aws-sam/build
Built Template   : .aws-sam/build/template.yaml

Commands you can use next
=========================
[*] Invoke Function: sam local invoke
[*] Test Function in the Cloud: sam sync --stack-name {stack-name} --watch
[*] Deploy: sam deploy --guided

Running PythonPipBuilder:ResolveDependencies
Running PythonPipBuilder:CopySource
(awscloud) 04:21:18::mlissner@gabbro::~/Programming/awscloud/cl
↪ sam deploy --guided

Configuring SAM deploy
======================

	Looking for config file [samconfig.toml] :  Not found

	Setting default arguments for 'sam deploy'
	=========================================
	Stack Name [sam-app]: recap-dot-email
	AWS Region [us-east-1]: us-west-2
	#Shows you resources changes to be deployed and require a 'Y' to initiate deploy
	Confirm changes before deploy [y/N]: y
	#SAM needs permission to be able to create roles to connect to the resources in your template
	Allow SAM CLI IAM role creation [Y/n]: y
	#Preserves the state of previously provisioned resources when an operation fails
	Disable rollback [y/N]:
	RecapEmailFunction may not have authorization defined, Is this okay? [y/N]:
Error: Security Constraints Not Satisfied!
(awscloud) 04:31:58::mlissner@gabbro::~/Programming/awscloud/cl
↪ sam deploy --guided

Configuring SAM deploy
======================

	Looking for config file [samconfig.toml] :  Not found

	Setting default arguments for 'sam deploy'
	=========================================
	Stack Name [sam-app]: recap-dot-email
	AWS Region [us-east-1]: us-west-2
	#Shows you resources changes to be deployed and require a 'Y' to initiate deploy
	Confirm changes before deploy [y/N]: y
	#SAM needs permission to be able to create roles to connect to the resources in your template
	Allow SAM CLI IAM role creation [Y/n]: y
	#Preserves the state of previously provisioned resources when an operation fails
	Disable rollback [y/N]: n
	RecapEmailFunction may not have authorization defined, Is this okay? [y/N]: y
	Save arguments to configuration file [Y/n]: y
	SAM configuration file [samconfig.toml]:
	SAM configuration environment [default]:

	Looking for resources needed for deployment:
	Creating the required resources...
	Successfully created!
	 Managed S3 bucket: aws-sam-cli-managed-default-samclisourcebucket-vc7oy5nsaht1
	 A different default S3 bucket can be set in samconfig.toml

	Saved arguments to config file
	Running 'sam deploy' for future deployments will use the parameters saved above.
	The above parameters can be changed by modifying samconfig.toml
	Learn more about samconfig.toml syntax at
	https://docs.aws.amazon.com/serverless-application-model/latest/developerguide/serverless-sam-cli-config.html

Uploading to recap-dot-email/5eb21e209010f18b072ca2ae762ece48  459150 / 459150  (100.00%)

	Deploying with following values
	===============================
	Stack name                   : recap-dot-email
	Region                       : us-west-2
	Confirm changeset            : True
	Disable rollback             : False
	Deployment s3 bucket         : aws-sam-cli-managed-default-samclisourcebucket-vc7oy5nsaht1
	Capabilities                 : ["CAPABILITY_IAM"]
	Parameter overrides          : {}
	Signing Profiles             : {}

Initiating deployment
=====================
Uploading to recap-dot-email/07cd54bc04ff37481fbe67c87aa350d2.template  1232 / 1232  (100.00%)

Waiting for changeset to be created..

CloudFormation stack changeset
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Operation                                      LogicalResourceId                              ResourceType                                   Replacement
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
+ Add                                          RecapEmailFunctionRecapEmailPermissionProd     AWS::Lambda::Permission                        N/A
+ Add                                          RecapEmailFunctionRole                         AWS::IAM::Role                                 N/A
+ Add                                          RecapEmailFunction                             AWS::Lambda::Function                          N/A
+ Add                                          ServerlessRestApiDeployment1d6c579a39          AWS::ApiGateway::Deployment                    N/A
+ Add                                          ServerlessRestApiProdStage                     AWS::ApiGateway::Stage                         N/A
+ Add                                          ServerlessRestApi                              AWS::ApiGateway::RestApi                       N/A
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Changeset created successfully. arn:aws:cloudformation:us-west-2:xxx:changeSet/samcli-deploy-xxx/xxx-66ab-41d1-8d50-xxx

Previewing CloudFormation changeset before deployment
======================================================
Deploy this changeset? [y/N]: y

2022-01-04 16:36:06 - Waiting for stack create/update to complete

CloudFormation events from stack operations
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
ResourceStatus                                 ResourceType                                   LogicalResourceId                              ResourceStatusReason
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
CREATE_IN_PROGRESS                             AWS::IAM::Role                                 RecapEmailFunctionRole                         -
CREATE_IN_PROGRESS                             AWS::IAM::Role                                 RecapEmailFunctionRole                         Resource creation Initiated
CREATE_COMPLETE                                AWS::IAM::Role                                 RecapEmailFunctionRole                         -
CREATE_IN_PROGRESS                             AWS::Lambda::Function                          RecapEmailFunction                             -
CREATE_IN_PROGRESS                             AWS::Lambda::Function                          RecapEmailFunction                             Resource creation Initiated
CREATE_COMPLETE                                AWS::Lambda::Function                          RecapEmailFunction                             -
CREATE_IN_PROGRESS                             AWS::ApiGateway::RestApi                       ServerlessRestApi                              -
CREATE_IN_PROGRESS                             AWS::ApiGateway::RestApi                       ServerlessRestApi                              Resource creation Initiated
CREATE_COMPLETE                                AWS::ApiGateway::RestApi                       ServerlessRestApi                              -
CREATE_IN_PROGRESS                             AWS::Lambda::Permission                        RecapEmailFunctionRecapEmailPermissionProd     Resource creation Initiated
CREATE_IN_PROGRESS                             AWS::ApiGateway::Deployment                    ServerlessRestApiDeployment1d6c579a39          -
CREATE_IN_PROGRESS                             AWS::Lambda::Permission                        RecapEmailFunctionRecapEmailPermissionProd     -
CREATE_IN_PROGRESS                             AWS::ApiGateway::Deployment                    ServerlessRestApiDeployment1d6c579a39          Resource creation Initiated
CREATE_COMPLETE                                AWS::ApiGateway::Deployment                    ServerlessRestApiDeployment1d6c579a39          -
CREATE_IN_PROGRESS                             AWS::ApiGateway::Stage                         ServerlessRestApiProdStage                     -
CREATE_IN_PROGRESS                             AWS::ApiGateway::Stage                         ServerlessRestApiProdStage                     Resource creation Initiated
CREATE_COMPLETE                                AWS::ApiGateway::Stage                         ServerlessRestApiProdStage                     -
CREATE_COMPLETE                                AWS::Lambda::Permission                        RecapEmailFunctionRecapEmailPermissionProd     -
CREATE_COMPLETE                                AWS::CloudFormation::Stack                     recap-dot-email                                -
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

CloudFormation outputs from deployed stack
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Outputs
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Key                 RecapEmailApi
Description         API Gateway endpoint URL for Prod stage for Free Look function
Value               https://xxx.execute-api.us-west-2.amazonaws.com/Prod/recap-email/

Key                 RecapEmailFunction
Description         Free Look Email Lambda Function ARN
Value               arn:aws:lambda:us-west-2:xxx:function:recap-dot-email-RecapEmailFunction-xxx

Key                 RecapEmailFunctionIamRole
Description         Implicit IAM Role created for the Free Look Email function
Value               arn:aws:iam::xxx:role/recap-dot-email-RecapEmailFunctionRole-xxx
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Successfully created/updated stack - recap-dot-email in us-west-2

Sorta seems like it worked. @tewen, what next? I don't think it's sensitive, but I'll slack you the API endpoint. It comes returns an error, but that's sort of to be expected, I think.

OK, @tewen sent me this video explaining that the next step was to create a recipient ruleset in AWS SES, so I did that. It went pretty well, but:

The console complained that I needed to verify domain ownership, but that was already done.

When I tried to create the ruleset, it had a permissions error that I had to fix via this link. That link told me to put my user account's information into the S3 buckets permissions, which was pretty weird, but when I did it, it worked. Hm.

The last part I haven't yet done is activate the ruleset. When I start doing so, I get the warning that:

Set default-rule-set as the active rule set for your account in US West (Oregon)? Only one receipt rule set can be active at a time.

I worried a bit that if I made this active, it would start applying to all of my emails, not only those sent to recap.email, but the docs seem to indicate that it'll be fine, so I enabled it. They say:

If the recipient of an incoming email matches a recipient specified in the conditions for the receipt rule, then Amazon SES performs the actions specified in that receipt rule.

Which implies that if the recipient doesn't match, then the usual stuff is done with it.

Yes, I think that is the case. Since the recap.email domain is separate, maybe it will only be for this use case.


how to handle asyn commands?

Hello, nice lib. I'm trying to add do/redo functionallity, the only issue I have is that some of my commands (do/redos) are async, so it turns into rare behavior when I click "ctrl+z" pretty fast, because the last undo call is not waiting for the firsts calls. Is there a way to handle this ?
thanks.

+1

@xeii's approach will work if you're willing to ignore ctrl+z commands while an async undo is in progress (and you also need a similar guard on isUndoing when the user is performing a redo() operation). Also, you may need to add a check whether there is anything on the undo/redo stack, because the UndoManager does not call the callback if the undo/redo operation is a noop.
If you want to queue up undo/redo operations (i.e. the second ctrl+z is executed after the first one is finished) you'll need to do something along this line:
var pending = [];

undoManager.setCallback(handleNext);

// Add undo/redo to queue of pending operations
function enqueueOperation(callback) {
   pending.push(callback);
   if (pending.length === 1) {
      handleNext();
   }
}

// Perform the next undo/redo operation
function handleNext() {
   if (pending.length) {
      pending.unshift()();
   }
}

function whenUndoIsCalled() {
   enqueueOperation(function() {
      if (undoManager.hasUndo()) {
         undoManager.undo();
      } else {
         handleNext();
      }
   );
}

function whenRedoIsCalled() {
   enqueueOperation(function() {
      if (undoManager.hasRedo()) {
         undoManager.redo();
      } else {
         handleNext();
      }
   );
}

Thank you for your reply. I got it working now.
On Thu, Jan 7, 2016 at 8:08 PM Stepan Riha<EMAIL_ADDRESS>wrote:

@xeii https://github.com/xeii's approach will work if you're willing to
ignore ctrl+z commands while an async undo is in progress (and you also
need a similar guard on isUndoing when the user is performing a redo()
operation). Also, you may need to add a check whether there is anything on
the undo/redo stack, because the UndoManager does not call the callback if
the undo/redo operation is a noop.
If you want to queue up undo/redo operations (i.e. the second ctrl+z is
executed after the first one is finished) you'll need to do something
along this line:
var pending = [];
undoManager.setCallback(handleNext);
// Add undo/redo to queue of pending operations
function enqueueOperation(callback) {
pending.push(callback);
if (pending.length === 1) {
handleNext();
}
}
// Perform the next undo/redo operation
function handleNext() {
if (pending.length) {
pending.unshift()();
}
}
function whenUndoIsCalled() {
enqueueOperation(function() {
if (undoManager.hasUndo()) {
undoManager.undo();
} else {
handleNext();
}
);
}
function whenRedoIsCalled() {
enqueueOperation(function() {
if (undoManager.hasRedo()) {
undoManager.redo();
} else {
handleNext();
}
);
}
—
Reply to this email directly or view it on GitHub
https://github.com/ArthurClemens/Javascript-Undo-Manager/issues/17#issuecomment-169659076
.


Add rescript.settings.platformPath and correctly determine its default value

This introduces the setting rescript.settings.platformPath and fixes the algorithm to find it if the setting is not specified. This should fix formatting in monorepos, which relies on bsc.exe.
Fixes #572

I tested it on my monorepo and it did fix my autoformatting issue! Thanks @Minnozz!

Tried it on two monorepo projects. I had no issues before, but also did not find any regression with this build.

@Minnozz I'm inclined to merge this since it seems to fix setups that recently broke.
Would you be available to help fix unforeseen issues that might come from this? Not necessarily thinking there will be any issues, but a lot of the ad hoc monorepo fixes we've merged has broken someone else's monorepo setup. Hence my question.

@zth Yes, I'll do my best to fix any issues

@zth Yes, I'll do my best to fix any issues

Thank you!


Pltfrs 8945 - New stacks step 1

Refer to this link for build results (access rights to CI server needed):
https://jenkins.airvantage.io/job/av-sched-pull-requests/158/
Integration build result

Commit: 2d322d1efc58eeef14e3079094796aec951e3341
Status: FAILURE :-1;

Refer to this link for build results (access rights to CI server needed):
https://jenkins.airvantage.io/job/av-sched-pull-requests/159/
Integration build result

Commit: 141042bb27d25c09dc1b434ca10e534c382b5f9b
Status: FAILURE :-1;

Refer to this link for build results (access rights to CI server needed):
https://jenkins.airvantage.io/job/av-sched-pull-requests/160/
Integration build result

Commit: e21ee1b34b7c7485383f7cbd24501935f3bd55da
Status: FAILURE :-1;

Refer to this link for build results (access rights to CI server needed):
https://jenkins.airvantage.io/job/av-sched-pull-requests/161/
Integration build result

Commit: 17a6d9afade9625ad184832ffc7a2b8d8679dfc7
Status: FAILURE :-1;

Refer to this link for build results (access rights to CI server needed):
https://jenkins.airvantage.io/job/av-sched-pull-requests/162/
Integration build result

Commit: c9d4684c4c3a87bfbc939ee9b48537cd2c1b671f
Status: FAILURE :-1;

Refer to this link for build results (access rights to CI server needed):
https://jenkins.airvantage.io/job/av-sched-pull-requests/163/
Integration build result

Commit: ee7111e934acae3b523de23842212ea56a37383f
Status: FAILURE :-1;

Refer to this link for build results (access rights to CI server needed):
https://jenkins.airvantage.io/job/av-sched-pull-requests/164/
Integration build result

Commit: 1bf962a4022cf44ce26a9acec921a0a4b81a26e5
Status: FAILURE :-1;

Refer to this link for build results (access rights to CI server needed):
https://jenkins.airvantage.io/job/av-sched-pull-requests/165/
Integration build result

Commit: a3d0549b8ca8bc2805e96926bed4bef71702322f
Status: FAILURE :-1;

Refer to this link for build results (access rights to CI server needed):
https://jenkins.airvantage.io/job/av-sched-pull-requests/166/
Integration build result

Commit: 65a920105311c5997d6d9d2e6beef195c2cb602a
Status: FAILURE :-1;

Refer to this link for build results (access rights to CI server needed):
https://jenkins.airvantage.io/job/av-sched-pull-requests/167/
Integration build result

Commit: 954d1108bb4ef42b3a71f1d3c3e31ad0241b790b
Status: SUCCESS :+1:

Refer to this link for build results (access rights to CI server needed):
https://jenkins.airvantage.io/job/av-sched-pull-requests/168/
Integration build result

Commit: 374274e7ea08fc62cee2a116143cf2c2ae152c6c
Status: SUCCESS :+1:

Refer to this link for build results (access rights to CI server needed):
https://jenkins.airvantage.io/job/av-sched-pull-requests/169/
Integration build result

Commit: d5229d582ce5a7ab374f26ab2601cad5ce81ee71
Status: SUCCESS :+1:

Refer to this link for build results (access rights to CI server needed):
https://jenkins.airvantage.io/job/av-sched-pull-requests/172/
Integration build result

Commit: 4c04eb49ea3ab4eced49cc1df4433c4bb15e3e82
Status: SUCCESS :+1:

Refer to this link for build results (access rights to CI server needed):
https://jenkins.airvantage.io/job/av-sched-pull-requests/173/
Integration build result

Commit: cfaad27531459568c21c736b1ebe33b5e85845d6
Status: SUCCESS :+1:

Refer to this link for build results (access rights to CI server needed):
https://jenkins.airvantage.io/job/av-sched-pull-requests/174/
Integration build result

Commit: edd5a45f8a5027c136dffb08fe2583059ff16a2d
Status: SUCCESS :+1:


additional container node information

@simon3z please review

@miq-bot add_label providers/containers

@Fryguy @zakiva ok so:

ContainerNode already has_one :computer_system, and ComputerSystem already has_one :operating_system, so I expect that we can fill the information into operating_system pretty easily.

collect osImage (typical value: CentOS Linux 7 (Core)) into distribution in operating_system

add a column kernel_version (string) in operating_system and collect kernelVersion in that column

:container_runtime_version is ok as it is (don't touch anything)

@Fryguy actually I am in favor of using kubernetes_ prefixes for kubernetes-specific information (we may move these out in another table in the future). In fact :kube_proxy_version and :kubelet_version are valid only for kubernetes (not relevant for amazon). Bottom line I only propose to make them more consistent using the column names: :kubernetes_proxy_version and :kubernetes_kubelet_version

Sounds good @simon3z

Thanks @zakiva can you also add the spec tests in vmdb/spec/models/ems_refresh/refreshers/kubernetes_refresher_spec.rb. Check that all the values are correctly parsed and saved.

added tests and display information in the UI, additions are marked (not sure about the labels):


New Smart Hose Timer API

Any possibility for this to work with your plugin in the future?
https://rachio.readme.io/reference/smart-hose-timer-data-objects

I was planning on it, but I don't have a timer to develop against at this time.

I did order a unit. This should be a fairly easy thing to add in.

V1.3.0 beta no supports the hose timer. Let me know how this works for you.

Amazing--just installed the beta and see them showing up exactly as expected!


chore: update dependencies

(...all of them, except for react-scripts.)

@grant-davidson (I should have noted here too.)
This breaks the saving to localStorage feature. Do you know how to fix?

Thaaaanks!


small Confusion with number of layers of DCRNN/ Cells

https://github.com/liyaguang/DCRNN/blob/master/model/dcrnn_model.py#L48
Multiplying a 'cell' object will lead to num_rnn_layer cells but they hava the same weight.
Is this the expected behavior?

This is the intended behavior that different layers share the weights to reduce the number of parameters. One example can be found in the tensorflow tutorial: https://github.com/tensorflow/tensorflow/blob/0.6.0/tensorflow/g3doc/tutorials/recurrent/index.md
You can also use different parameters for each layer with:
encoder_cells = [DCGRUCell(rnn_units, adj_mx, max_diffusion_step=max_diffusion_step, num_nodes=num_nodes, filter_type=filter_type) for _ in range(num_rnn_layers)]


Jesse: Watch hobarttaxicabs.com.au

Jesse requests the watch of the watch_keyword hobarttaxicabs\.com\.au. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Approved by Spevacus in Charcoal HQ

hobarttaxicabs\.com\.au has been seen in 1 true positive, 0 false positives, and 0 NAAs.


TRSv2-576: Upgrade redis

Codecov Report
Patch coverage: 33.60% and project coverage change: -0.33 :warning:

Comparison is base (a9ad475) 36.94% compared to head (d8e00dc) 36.61%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #241      +/-   ##
===========================================
- Coverage    36.94%   36.61%   -0.33%
===========================================
  Files          102      103       +1
  Lines         3841     4200     +359
  Branches       644      710      +66
===========================================
+ Hits          1419     1538     +119
- Misses        2422     2662     +240

Impacted Files
Coverage Δ

trade_remedies_caseworker/cases/views.py
20.38% <ø> (ø)

...ases/v2/views/organisation_verification_process.py
43.65% <11.11%> (-2.12%)
:arrow_down:

...rker/organisations/v2/views/merge_organisations.py
24.21% <24.21%> (ø)

trade_remedies_caseworker/core/views.py
50.20% <39.17%> (-7.23%)
:arrow_down:

trade_remedies_caseworker/core/urls.py
85.71% <66.66%> (-14.29%)
:arrow_down:

...rade_remedies_caseworker/organisations/v2/forms.py
80.48% <83.33%> (+4.01%)
:arrow_up:

trade_remedies_caseworker/config/base_views.py
45.45% <100.00%> (+1.01%)
:arrow_up:

trade_remedies_caseworker/config/settings/base.py
95.74% <100.00%> (+0.04%)
:arrow_up:

trade_remedies_caseworker/organisations/urls.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


its still not working in ie 11

I saw your commit and tried do it on localhost, because you didnt update npm package, but problem still exists
SCRIPT1002: Syntax error
vendor.bundle.js (71,1)

I'll look into it. It's working on my version of IE11, may need a metatag to turn on Edge compatibility mode.

i was open your demo and see this meta, but in my ie its not working http://prntscr.com/inme3l
http://prntscr.com/inme8z

in edge its working, but ie needs for me(

I have released 0.2.3 targeting ES5. Can you give it a try in IE now?

yep, its work now, thanks for a quick response. Works without "meta" too


Add CONTRIBUTORS.md file to provide guidelines for project contributions

This PR introduces a CONTRIBUTORS.md file that outlines the contribution guidelines for the BitBox project. It includes steps for setting up the project, coding standards, and how to raise issues or submit pull requests. This document aims to streamline the onboarding process for new contributors, ensuring a clear understanding of how to contribute effectively to the project. Thank you for considering this addition!

Well Done!

@GUNJESH843  can please add labels and level for this issue?


Huge performance issue when using PageView with blur in each page

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
I was going to check if impeller have fixed in issue I file a while ago https://github.com/flutter/flutter/issues/89585 and apparently it just got a lot worse as it seems impeller made it very stuttery.

Create a page view widget
Add children with BackdropFilter(filter: ImageFilter.blur(sigmaX: 20, sigmaY: 20), child: ...)
Swipe around

Expected results
Pages change smoothly
Actual results
Very stuttery
Code sample
Code sample
import 'package:flutter/material.dart';
import 'dart:ui';

void main() {
 runApp(App());
}

class App extends StatelessWidget {
 @override
 Widget build(BuildContext context) {
   return MaterialApp(
     home: Scaffold(
       backgroundColor: Colors.black,
       body: PageView.builder(
         itemBuilder: (context, index) {
           return Stack(
             children: [
               Container(color: Colors.white),
               Positioned(
                 child: Container(
                   clipBehavior: Clip.hardEdge,
                   decoration: BoxDecoration(),
                   child: BackdropFilter(
                     filter: ImageFilter.blur(
                       sigmaX: 20,
                       sigmaY: 20,
                     ),
                     child: Center(
                       child: Text(
                         'Page #${index + 1}',
                         style: TextStyle(
                           fontWeight: FontWeight.bold,
                           fontSize: 32,
                         ),
                       ),
                     ),
                   ),
                 ),
               ),
             ],
           );
         },
       ),
     ),
   );
 }
}

Screenshots or Video

Video with impeller
https://github.com/flutter/flutter/assets/29712386/747643b0-4c0d-432f-87a8-fe68e2df01e9

Video without impeller (--no-enable-impeller)
https://github.com/flutter/flutter/assets/29712386/2d45d1a6-7fe8-404e-a5a7-4e346ad46425

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.13.2, on macOS 14.0 23A5337a darwin-arm64, locale en-US)
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
[✓] Xcode - develop for iOS and macOS (Xcode 15.0)
[✓] Chrome - develop for the web
[!] Android Studio (version unknown)
    ✗ Unable to determine Android Studio version.
[✓] Android Studio (version 2022.2)
[✓] VS Code (version 1.81.1)
[✓] VS Code (version 1.82.0-insider)
[✓] Connected device (3 available)
[✓] Network resources

! Doctor found issues in 1 category.

@darshankawar the difference is that I apply blur to each child and that issue has it outside but I'd say it's most likely same issue.

Thanks for the feedback @mattermoran
I do believe the root-cause is same as the linked issue and once that is fixed, you may run your scenario on latest master to confirm whether the issue persists or not. You may subscribe to the linked issue to get updates on it. I'll close this in favor of the linked issue. If you disagree, write in comments and I'll reopen it.


docs/middleware: minor improvement

I think this better summons up Middlewares in redux

Thanks, but it reads better as "between".


Remove cutover time

cc @robskillington @martin-mao

Coverage increased (+0.006%) to 78.947% when pulling d852f972a5645b62beb4807d9fc0e7eaa11a7b61 on xichen-remove-cutover into 8dd05c718b6c94e07964e38beef68343a7c8d16b on master.

Coverage increased (+0.006%) to 78.947% when pulling d852f972a5645b62beb4807d9fc0e7eaa11a7b61 on xichen-remove-cutover into 8dd05c718b6c94e07964e38beef68343a7c8d16b on master.


Per rule evaluation duration metric

Proposal
Currently we provide metrics (duration and success) at a rule-group level. But a group can have 10s of rules inside it. If a rule_group is skipping iterations, then its likely caused by a few rules inside the group. Today, we can easily find the culprit rules by looking at the UI.
Having said that, we are seeing some groups slowly creeping up in evaluation duration and knowing the historical evaluation duration for each rule would be quite helpful. This would basically be adding prometheus_rule_group_rule_last_duration_seconds which has an index of the rule being evaluated as a label.
A workaround to this is to write an exporter which queries the API and exposes the metrics, but I'd like to avoid that if possible.

This seems like something for the query_log > loki.
A label with the rule ID would just be too much cardinality here. As you say, you can have 10s of rules inside a group.
Note that you would probably not need to write an exporter, you could simply use the json_exporter.

This seems really expansive in terms of metrics we are exposing. It sounds like events. This looks like something that can be extracted from the query log or the traces we have in PromQL.

Interrested for keep track of rules duration evalution and alert on it

Hello from the bug scrub.
Nothing has happened here in almost 3y. We are closing it, but if anyone has concrete plans of working on this (and an idea how to make it efficient enough), please follow up so that we can reopen.


More control over toolbox (prefilled fields in the blocks)

What are the requirements for the project?
Content creator should be able to control the default values of blocks in the toolbox of tutorials.  We should also let students choose (toggle?) between the culled toolbox and the full toolbox, even inside of a tutorial.
(For that matter, the "Search" box should return for the tutorial toolbox.
Is there a deadline or date this is needed by?
ASAP
Please share any existing references, screenshots, links, etc. here that will help us better understand your requirements

When trying to present ideas slowly to reduce cognitive load, it would be great to have these blocks pre-filled in the toolbox instead of having to walk them through each field. Takes too long to get them to something that's fun to play.

Prefilled blocks is implemented.


[BUG] freelist_create - Changing max_entries breaks the freelist tests

Describe the bug
Changing the max_entries from
u64 max_entries = total_size / sizeof(void*);

to
u64 max_entries = total_size / (sizeof(void*) * sizeof(freelist_node));

makes the unit tests fail.
Screenshots

Desktop

OS: Windows 10

Heh, good catch. Thanks for reporting it. I'm actually unsure how I didn't catch this before now.

Fixed.


Added grep feature and updated readme

Added the grep feature and updated the README with how to use.

Thanks for your work on this!


Did the ad collector stop working with the new update of Chrome (v66)?

I get no ads detected as of yesterday when I updated Chrome to version 66. Running with Swedish language settings. If there is a simple way to debug detection I would be happy to help out.

Looking into it I think Facebook may have changed some of the class names for ad html which means the query selector don't match ads anymore. Tried both swedish and english language setting (in FB) and no ads are detected.

You were right, I think, as discussed via email. Fixed in https://github.com/propublica/facebook-political-ads/commit/b65421c76e99dd8a41f1168fc20cccbddb8a67b3


errors in seekr2 test

Dear Seekr2 team,
I finally got access to a GPU in my new location and tried to install seekr2, but I'm getting the following failed, error and warning messages in the testing phase.  The installation seems to have been completed without a noticeable error or major warnning.
It seems like some input files were not found in the expected location.
Please point me to a location where these might be available so that I can copy and try to rerun these tests.
Since it has been almost a year since I last tried seekr2, I may have forgotten something that you told me earlier.
Please have a look and suggest if I can proceed with the trypsin-benzamidine tutorial?
Thank you and best regards,
Vaibhav
seekr2/tests/test_run.py::test_run_planar
/home/niperg/Downloads/seekr2/seekr2/modules/check.py:239: UserWarning: Empty mmvt trajectories were found in anchor: 1.
warnings.warn("Empty mmvt trajectories were found in "\
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
===================================================================================== short test summary info =====================================================================================
FAILED seekr2/tests/test_common_analyze.py::test_browndye_run_compute_rate_constant - subprocess.CalledProcessError: Command 'compute_rate_constant < /home/niperg/Downloads/seekr2/seekr2/tests...
FAILED seekr2/tests/test_common_prepare.py::test_move_add_delete_input_anchors - AssertionError: Problem running make_apbs_input - APBS input files not found: receptor*.in
FAILED seekr2/tests/test_common_prepare.py::test_modify_model - AssertionError: Problem running make_apbs_input - APBS input files not found: receptor*.in
FAILED seekr2/tests/test_common_sim_browndye2.py::test_make_and_run_apbs - AssertionError: Problem running make_apbs_input - APBS input files not found: receptor*.in
FAILED seekr2/tests/test_run.py::test_choose_next_simulation_namd - AssertionError: Problem occurred running namd: results file(s) was not generated.
FAILED seekr2/tests/test_run.py::test_normal_run_namd - AssertionError: Problem occurred running namd: results file(s) was not generated.
FAILED seekr2/tests/test_run.py::test_normal_restart_namd - AssertionError: Problem occurred running namd: results file(s) was not generated.
FAILED seekr2/tests/test_runner_namd.py::test_cleanse_anchor_outputs - AssertionError: Problem occurred running namd: results file(s) was not generated.
ERROR seekr2/tests/test_common_analyze.py::test_Data_sample_parse_browndye_results - AssertionError: Problem running make_apbs_input - APBS input files not found: receptor*.in
ERROR seekr2/tests/test_common_base.py::test_model_get_type - AssertionError: Problem running make_apbs_input - APBS input files not found: receptor*.in
ERROR seekr2/tests/test_common_base.py::test_model_get_timestep - AssertionError: Problem running make_apbs_input - APBS input files not found: receptor*.in
ERROR seekr2/tests/test_common_converge.py::test_analyze_bd_only - AssertionError: Problem running make_apbs_input - APBS input files not found: receptor*.in
ERROR seekr2/tests/test_common_cv.py::test_assign_state_points_hostguest - AssertionError: Problem running make_apbs_input - APBS input files not found: receptor*.in
ERROR seekr2/tests/test_common_sim_openmm.py::test_create_openmm_system - AssertionError: Problem running make_apbs_input - APBS input files not found: receptor*.in
ERROR seekr2/tests/test_common_sim_openmm.py::test_add_platform_cuda - AssertionError: Problem running make_apbs_input - APBS input files not found: receptor*.in
ERROR seekr2/tests/test_converge.py::test_converge_default_bd_only_mmvt - AssertionError: Problem running make_apbs_input - APBS input files not found: receptor*.in
ERROR seekr2/tests/test_converge.py::test_converge_default_bd_only_elber - AssertionError: Problem running make_apbs_input - APBS input files not found: receptor*.in
ERROR seekr2/tests/test_elber_base.py::test_create_elber_model - AssertionError: Problem running make_apbs_input - APBS input files not found: receptor*.in
ERROR seekr2/tests/test_elber_sim_openmm.py::test_elber_sim_openmm_amber - AssertionError: Problem running make_apbs_input - APBS input files not found: receptor*.in
ERROR seekr2/tests/test_mmvt_base.py::test_MMVT_anchor_id_from_alias - AssertionError: Problem running make_apbs_input - APBS input files not found: receptor*.in
ERROR seekr2/tests/test_mmvt_base.py::test_MMVT_anchor_alias_from_id - AssertionError: Problem running make_apbs_input - APBS input files not found: receptor*.in
ERROR seekr2/tests/test_mmvt_base.py::test_MMVT_anchor_alias_from_neighbor_id - AssertionError: Problem running make_apbs_input - APBS input files not found: receptor*.in
ERROR seekr2/tests/test_mmvt_base.py::test_MMVT_anchor_get_ids - AssertionError: Problem running make_apbs_input - APBS input files not found: receptor*.in
ERROR seekr2/tests/test_mmvt_base.py::test_check_openmm_context_within_boundary - AssertionError: Problem running make_apbs_input - APBS input files not found: receptor*.in
ERROR seekr2/tests/test_mmvt_sim_openmm.py::test_mmvt_sim_openmm_amber - AssertionError: Problem running make_apbs_input - APBS input files not found: receptor*.in
ERROR seekr2/tests/test_mmvt_sim_openmm.py::test_check_if_state_in_anchor - AssertionError: Problem running make_apbs_input - APBS input files not found: receptor*.in
ERROR seekr2/tests/test_run.py::test_choose_next_simulation_browndye2 - AssertionError: Problem running make_apbs_input - APBS input files not found: receptor*.in
ERROR seekr2/tests/test_runner_browndye2.py::test_make_browndye_input_xml - AssertionError: Problem running make_apbs_input - APBS input files not found: receptor*.in
ERROR seekr2/tests/test_runner_browndye2.py::test_make_browndye_reaction_xml - AssertionError: Problem running make_apbs_input - APBS input files not found: receptor*.in
ERROR seekr2/tests/test_runner_browndye2.py::test_modify_variables - AssertionError: Problem running make_apbs_input - APBS input files not found: receptor*.in
ERROR seekr2/tests/test_runner_browndye2.py::test_runner_browndye2_b_surface_mmvt - AssertionError: Problem running make_apbs_input - APBS input files not found: receptor*.in
ERROR seekr2/tests/test_runner_browndye2.py::test_runner_browndye2_b_surface_elber - AssertionError: Problem running make_apbs_input - APBS input files not found: receptor*.in
ERROR seekr2/tests/test_runner_namd.py::test_search_for_state_to_load - AssertionError: Problem running make_apbs_input - APBS input files not found: receptor*.in
ERROR seekr2/tests/test_runner_namd.py::test_Runner_namd_default - AssertionError: Problem running make_apbs_input - APBS input files not found: receptor*.in
ERROR seekr2/tests/test_runner_namd.py::test_Runner_namd_load_state - AssertionError: Problem running make_apbs_input - APBS input files not found: receptor*.in
ERROR seekr2/tests/test_runner_namd.py::test_Runner_namd_save_states - AssertionError: Problem running make_apbs_input - APBS input files not found: receptor*.in
ERROR seekr2/tests/test_runner_namd.py::test_Runner_namd_save_states_until_all_bounds - AssertionError: Problem running make_apbs_input - APBS input files not found: receptor*.in
ERROR seekr2/tests/test_runner_openmm.py::test_saveCheckpoint - AssertionError: Problem running make_apbs_input - APBS input files not found: receptor*.in
ERROR seekr2/tests/test_runner_openmm.py::test_Runner_openmm_default - AssertionError: Problem running make_apbs_input - APBS input files not found: receptor*.in
ERROR seekr2/tests/test_runner_openmm.py::test_Runner_openmm_default_cuda - AssertionError: Problem running make_apbs_input - APBS input files not found: receptor*.in
ERROR seekr2/tests/test_runner_openmm.py::test_Runner_openmm_load_state - AssertionError: Problem running make_apbs_input - APBS input files not found: receptor*.in
ERROR seekr2/tests/test_runner_openmm.py::test_runner_openmm_elber - AssertionError: Problem running make_apbs_input - APBS input files not found: receptor*.in
ERROR seekr2/tests/test_runner_openmm.py::test_runner_openmm_save_states - AssertionError: Problem running make_apbs_input - APBS input files not found: receptor*.in
ERROR seekr2/tests/test_runner_openmm.py::test_runner_openmm_save_states_until_all_bounds - AssertionError: Problem running make_apbs_input - APBS input files not found: receptor*.in
ERROR seekr2/tests/test_runner_openmm.py::test_mmvt_swarm - AssertionError: Problem running make_apbs_input - APBS input files not found: receptor*.in
========================================================== 8 failed, 117 passed, 4 skipped, 18 warnings, 37 errors in 441.12s (0:07:21) ===========================================================
(base) [niperg@kaberi seekr2]$

It's working after adding browndyne2 in the path. I'll analyse the results
and get back to you in case of any queries. Thank you
On Fri, Jun 17, 2022, 06:33 Lane Votapka @.***> wrote:

Are you sure that you've installed Browndye2, not Browndye? You need to
also have your path variable containing the Browndye2 bin/ directory, so
that you can run the program "make_apbs_input" from your path.
—
Reply to this email directly, view it on GitHub
https://github.com/seekrcentral/seekr2/issues/13#issuecomment-1158359893,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJ6WMI7ML7JNPXAFMXPJRHDVPPFFJANCNFSM5Y6KVLDQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Glad it worked.


14974 use variable assets

Description
#14974

Creates sym link to vets-website generated files on yarn dev.
Adds in some visual assets that were missing on local.
Points script tags to prod when not on local
Dependent on this PR https://github.com/department-of-veterans-affairs/vets-website/pull/25539
Updates readme with instructions to install vets-website in same parent directory

Testing done
Local testing
Screenshots

QA steps
What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?
- [ ] Automated tests have passed
- [ ] Tugboat environment was generated without errors

Merging this because I previously approved it here: #160


Error displaying repo with 0 files

An error occurs (see image below) when the repo is initialized with zero files. I created a public repo - test to confirm this was not only caused for private repos(I found the problem while opening a private repo). The error is caused by fetchContributors. For example: https://api.github.com/repos/shreyas1599/test/stats/contributors does nothing. Does not even return an error message. I tried using the debugger and it returned an exception on this line of github.dart of SpinlockLabs.
I'm thinking there's no response and jsonDecode is throwing an error because nothing is returned by the request. Could this be the error or am I missing something?

I'm thinking there's no response and jsonDecode is throwing an error because nothing is returned by the request

Yeah, it seems so. Perhaps we should manually catch this error in this case.


ART-2589: Adapt to Pulp hostname change

pulp.dist.prod.ext.phx2.redhat.com -> rhsm-pulp.corp.redhat.com

The CI error doesn't seem to be related to my PR.

The CI error doesn't seem to be related to my PR.


APP-1702 - Fixed comment webhook to support new Jira payload

Build triggered. sha1 is merged.

Build started sha1 is merged.

Build finished.

Codecov Report

Merging #125 into dev will increase coverage by 0.01%.
The diff coverage is 87.5%.

@@            Coverage Diff            @@
##              dev    #125      +/-   ##
=========================================
+ Coverage   88.88%   88.9%   +0.01%
=========================================
  Files          36      36
  Lines         819     820       +1
  Branches       87      88       +1
=========================================
+ Hits          728     729       +1
  Misses         59      59
  Partials       32      32

Impacted Files
Coverage Δ

...ion/jira/webhook/parser/v2/JiraMetadataParser.java
89.62% <100%> (+0.04%)
:arrow_up:

.../jira/webhook/parser/v2/CommentMetadataParser.java
84.61% <80%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cc58b6...cd78725. Read the comment docs.


feat/search-passenger-active

Please review before merging.

:tada: This PR is included in version 1.24.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


README.adoc linked as README.md

The package has a symlink called README.md that actually points to README.adoc which in turn results in garbage being displayed: https://queue.stage.build2.org/libnng
I would just use the README.md file that you have in the root of the repository.

Thanks, new revision published :+1:


Generate a Live report on main thread and symbolicate it?

I want to build a  debug  tool to watch the fps of main thread and notify  the dev with symbolicated backtrace.
Most time only need the main thread backtrace.
Should I use the lower API to achieve this?
I already read the docs about how to generate a Live report and symbolicate it.

Yes, best to use the lower API for this kind of thing.


Love Live! School idol paradise Vol.1 Printemps [PCSG00422]

App summary

App name: Love Live! School idol paradise Vol.1 Printemps
App serial: PCSG00422
App version: 1.0

Vita3K summary

Version: v0.1.5
Build number: 2647
Commit hash: https://github.com/vita3k/vita3k/commit/d2e99945
CPU backend: Dynamic

Test environment summary

Tested by: othmanead
OS: Windows 11
CPU: Intel i5-10300H
GPU: RTX 3060 mobile
RAM: 16 GB

Issue:

Game plays with no issues

Screenshots:

Log
vita3k.log
Recommended labels

Playable

Test environment summary

OS: Windows 10
CPU: Intel i7-4790
GPU: GTX 1070
RAM: 16 GB

Vita3K summary

Issue

Error when load in-game

Test environment summary

OS: Windows 11
CPU: AMD 5800H
GPU: NVIDIA Laptop 3060
RAM: 16 GB

Vita3K summary

Version: v0.1.6
Build number: 3091
CPU backend: Dynamic
Backend Renderer: Vulkan

When selecting the stage, the background has some graphics bugs.

During performance, sometimes the game works perfectly, but sometimes 1% low FPS is low.
In rare cases, there're some graphics bugs. But it happens randomly.
(the leg of the central left charater)

Vita3K summary

Version: v0.1.9
Build number: 3501
Commit hash: https://github.com/vita3k/vita3k/commit/d24f1a7c
CPU backend: Dynarmic
GPU backend: Vulkan

works perfectly
Screenshots

vita3k.log

how to download this


EasyRPG Support

EasyRPG is an open Source engine that runs RPG Maker 2000/2003 games.
Page: https://easyrpg.org/
Source Code: https://github.com/EasyRPG/
Retroarch Lib: https://store.steampowered.com/app/1222638/RetroArch__EasyRPG/
It has an web player:

https://easyrpg.org/play/

The Player is also used on Niconico gaming, the japanese youtube-equivalent page:

https://game.nicovideo.jp/atsumaru/search/tag/RPGツクール2003?link_in=gamepage_tag

People can find scrape details and even direct links on the RMarchiv page:

https://rmarchiv.de/games/1860

There is even a project that transforms the Single Player webengine into a MMO engine:

https://gaming.yumeboo.ru/2kki/ or https://ynoproject.net/2kki/

Interesting, I will definitely check this out. Thanks a lot for submitting.


UUID! @id mongo

Describe the bug
when you use an existing model with UUID it doesn't work properly
To Reproduce
Steps to reproduce the behavior:

Create new project
Use existing database with UUID
Go to http://localhost:4466 and launch query
See error

{
  "data": null,
  "errors": [
    {
      "message": "Whoops. Looks like an internal server error. Search your server logs for request ID: local:ck6jq94lb000x0781jn3l2orh",
      "path": [
        "otcms"
      ],
      "locations": [
        {
          "line": 2,
          "column": 3
        }
      ],
      "requestId": "local:ck6jq94lb000x0781jn3l2orh"
    }
  ]
}

datamodel.prisma
type Otcm @db(name: "otcm") {
  id: UUID! @id(strategy: NONE)
  rawType: String
}

Error
Deploying service `default` to stage `default` to server `local` 124ms

Errors:

  Otcm
    × The field `id` is marked as id must have one of the following types: `ID!`.

Deployment canceled. Please fix the above errors to continue deploying.
Read more about deployment errors here: https://bit.ly/prisma-force-flag

Expected behavior
query with result
Versions :

Connector: [MongoDB]
Prisma Server: [e.g. 1.34.10]
OS: [e.g. Windows 10, ]

Having the same problem with this, when changing to:
type User @db(name: "users") {    _id: ID! @id(strategy: NONE)   name: String!  }
I get the error:
{ Error: You provided an ID that was not a valid MongoObjectId: dfa3f0cd-3337-4e34-b152-4d6b8aa32b85     at BatchedGraphQLClient.<anonymous> (/Users/motonstron/Documents/test/node/microservices/prisma/node_modules/http-link-dataloader/src/BatchedGraphQLClient.ts:74:13)     at step (/Users/motonstron/Documents/test/node/microservices/prisma/node_modules/http-link-dataloader/dist/src/BatchedGraphQLClient.js:40:23)     at Object.next (/Users/motonstron/Documents/test/node/microservices/prisma/node_modules/http-link-dataloader/dist/src/BatchedGraphQLClient.js:21:53)     at fulfilled (/Users/motonstron/Documents/test/node/microservices/prisma/node_modules/http-link-dataloader/dist/src/BatchedGraphQLClient.js:12:58)     at process._tickCallback (internal/process/next_tick.js:68:7) result: { data: null, errors: [ [Object] ], status: 200 } }


There is an extra action 'Get Shared Access Signature…' for services attached to emulator

Storage Explorer Version: 1.9.0
Branch: master
Build: 20190725.2
Emulator Version: V5.9.0
Platform/OS: Linux Ubuntu/macOS High Sierra/Windows 10
Architecture: ia32/x64
Regression From: Not a regression
Steps to reproduce:

Make sure Storage Emulator(v5.9.0) has been started.
Click 'Open Connect Dialog' -> Select 'Attach to a local emulator' -> 'Next' -> 'Connect'.
Expand local-1(key) node -> Blob Containers -> Create a new blob container.
Check the blob container's context menu.

Expect Experience:
There is no action 'Get Shared Access Signature…' for the blob container.
Actual Experience:
There is an extra action 'Get Shared Access Signature…' for the blob container.
More Info:

This issue also reproduces for one table / queue.
2.Pop up an error when trying to attach the blob container using sas attached.

Close this bug due to the fixed bug 2975.


Add FlowContainer wrap options for center alignment.

Adds a property to set a wrap alignment option that determine the wrapping behavior of the last unfilled row or column when the FlowContainer alignment is set to ALIGNMENT_CENTER.
This is needed because a common desired behavior of a centered flow container of tiles, is for the last row to fill in from the left, rather than per the current default behavior of filling in centered.
The PR includes CENTER_WRAP_BEGIN, CENTER_WRAP_CENTER, and CENTER_WRAP_END options, and also works when the flow container has vertical enabled.
The default center_alignment_wrap is CENTER_WRAP_CENTER which preserves backward compatiblity.

@Calinou
Can you advise on what's triggering the format complaint in the static check?

It was an errant TAB :( - all good now...

It was an errant TAB :( - all good now...

I recommend configuring your editor to trim trailing whitespace by default to avoid this in the future :slightly_smiling_face:

Found the setting! Thanks!

Could you amend the commit message? It currently says "Doc fix." which is not an accurate description for what this PR does (see PR workflow).

Commit message amended...

The implementation looks good. The feature has no proposal though.

I hadn't known about the proper process - is a proposal in this case required?

I hadn't known about the proper process - is a proposal in this case required?

Yes: https://github.com/godotengine/godot-proposals

There is a linux doc complaint that looks incorrect, because the default value is indeed 1 for the new property. Nothing changed in the docs - how should this be handled?

Run --doctool and just push the result. Doc strings outside description should not be edited manually.

How often do you want to align the whole grid one way, but the last row of items another way?

If you are using FlowContainer as a grid, then all the time. You would want to maintain a grid arrangement, regardless of alignment. You could think of this enhancement as adding a center-aligned grid container with auto-flow.
A common example is browsing a collection of image tiles or icons.
I think that it's a rare instance where you would ever want to break the grid and have the last row or column mis-aligned with the prior row or column. If there wasn't a backward-compatibility issue, I would opt to have the center align option default to filling in from the left per this enhancement.

Why is it limited to the central alignment only? IMO it makes more sense to allow it with any alignment and default to some INHERIT option that aligns the last row according to the alignment option.

This could be done, but I think it would be rare to want that behavior, per my prior comment on preserving a grid arrangement regardless of alignment choice.

That said, I'm not entirely sure how useful this is as it can be implemented with an extra container.

You would have to move children in and out of an extra container or use a GridContainer to get the behavior of this enhancement. The issue is there is no script access to alignment_ofs, which a separate container or script needs to respond to to maintain the grid alignment with the prior row or column.
			switch (alignment) {
				case ALIGNMENT_CENTER: {
					if (current_line_idx != 0 && center_wrap != CENTER_WRAP_CENTER && !line_data.is_filled) {
						if (center_wrap == CENTER_WRAP_END) {
							alignment_ofs = line_data.stretch_avail - (lines_data[current_line_idx - 1].stretch_avail * 0.5);
						} else { // Is CENTER_WRAP_BEGIN
							alignment_ofs = lines_data[current_line_idx - 1].stretch_avail * 0.5;
						}
					} else {
						alignment_ofs = line_data.stretch_avail * 0.5;
					}
				} break;
				case ALIGNMENT_END: {
					alignment_ofs = line_data.stretch_avail;
				} break;
				default:
					break;
			}

Please use the "Edit" button instead of multiposting.

You would have to move children in and out of an extra container

No, the way you can set it up is to have a parent container and a FlowContainer with a left-side alignment. The in the FlowContainer you would use size flags to position it within the parent container however you want. You would need to give your FlowContainer a min size, but that's already the case here.
Of course, that may not work exactly as you desire if you want FlowContainer to be resizable at runtime. Then this double-alignment system makes sense as a solution. But then I don't see why it must be limited to the center alignment only. It won't change the implementation much, it would just remove an artificial limitation from the new option.

Please use the "Edit" button instead of multiposting.

Roger about multiposting...

Of course, that may not work exactly as you desire if you want FlowContainer to be resizable at runtime. Then this double-alignment system makes sense as a solution. But then I don't see why it must be limited to the center alignment only. It won't change the implementation much, it would just remove an artificial limitation from the new option.

Yes, I presume requiring resizing at runtime. I concede the point and will remove the limitation, which is sensible and simplifies the docs...

Okay, this push makes the last wrap alignment work with any AlignmentMode, and defaults to LAST_WRAP_ALIGNMENT_INHERIT, which continues to preserve backward-compatibility.
I admit I was slightly skeptical of the usefulness for the other alignment modes, but after playing with it, I found it cool and I'm certain there will be many good uses for it.

Sorry for kicking this around. Let's make sure we merge it once 4.3 dev cycle starts (I still would like to review though).

Can this be merged now into 4.3?

It's marked for 4.3 so it just awaiting final decision and merger

Thanks!


For a multilingual website with an inner folder set as navigation root, the logic for the Contents breadcrumb is incorect

If I have the following content tree structure:
/en/navroot/something

the whole logic in this component collapses, because the store breadcrumbs.items would be just a single item, rooted in the navigation root.
https://github.com/plone/volto/blob/f92880ee4e4c3b88c7cea18c717dd30ecb1e61fa/packages/volto/src/components/manage/Contents/ContentsBreadcrumbs.jsx#L61

can you plz explaiin to reproduce this issue ?

"Hey, @tiberiuichim! I'm interested in addressing this issue, but I'm having trouble understanding your perspective. Could you please provide a detailed explanation? This will help me grasp the problem better and work towards a solution."

"I'm new to Plone, but I'm passionate about ReactJS and eager to contribute to issue resolution. Could you please explain how I should approach solving this? This would mark my first pull request in React. Thank you!"
@tiberiuichim

@gawandeabhishek if the author of the bug report needs to explain the bug and how to fix it, it means that you are not ready to fix this issue. If you are curious about learning about the framework, there is documentation available, training videos on Youtube and of course the source course at your disposal for studying.
There is very little to gain in trying to fix bugs for a product that you haven't worked with and you don't know.
If you want to learn something there are tutorials that you can follow and toy projects that you can build but this is a real product with real bugs that need to be fixed by real people that know how to fix them.

In my case, I fixed it by:

making a physical-breadcrumbs endpoint, https://github.com/eea/eea.climateadapt.plone/commit/ae977c947a1aa2a02e68f84b890b652d1272d073
customize the ContentsBreadcrumb: https://github.com/eea/volto-cca-policy/commit/a0592aa17b24eb51c8ee146d337094a6cfd37646

Test of locking a conversation, and limiting conversation only to people with write access.

Wouldn't be this fixed if we use the @navroot information to build the breadcrumbs?

@erral no, as far as I could see the navroot gives you the content of the ancestor INavigationRoot item (correct me if I'm wrong). The @breadcrumbs endpoint already has a root field with the path of the navigation root.
I've discussed this with @sneridagh and they had a customized ContentsBreadcrumbs that uses subsite information, probably to fix this exact problem.


Error connecting to WebSockets on Azure app service running on Linux container

I added support for WebSockets in my app and it works fine but connecting to it over Azure and I get this error. I have three settings enabled on my App Service and I'm running on Linux container

 WebSocket connection to 'wss://hostURL' failed: Error during WebSocket handshake: Unexpected response code: 503

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a3b0cac1-adc7-434c-d867-6e28e39bdae7
Version Independent ID: 762efeed-010e-f422-03d0-22d6681b2851
Content: WebSockets support in ASP.NET Core
Content Source: aspnetcore/fundamentals/websockets.md
Product: aspnet-core
Technology: aspnetcore-fundamentals
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Hello! Thanks for contacting us. This sounds like a general question about using ASP.NET Core. While we try to look at and respond to all issues, for questions like this we recommend posting to a community support group like Stack Overflow with the asp.net-core tag.

Stack Overflow
ASP.NET Core Slack
ASP.NET Gitter

Potential bugs in the ASP.NET Core framework and product feedback can be reported at dotnet/aspnetcore issues (include full repro steps and cross-link to a repro project in GH when appropriate). For Visual Studio, use the Report a Problem gesture or Suggest a Feature gesture within VS, which open internal issues for the VS team. For Visual Studio Code, you can open an issue at microsoft/vscode issues.


Az artifacts universal download failed

If the issue is to do with Azure CLI 2.0 in-particular, create an issue here at Azure/azure-cli

Extension name "artifacts universal download"
Description of issue `An error occurred on the service. A potentially dangerous Request.Path value was detected from the client (:)``
I have a colon in my package name and when I run the command , I got this message
An error occurred on the service. A potentially dangerous Request.Path value was detected from the client (:)
Can you have a look?
Regards

Was this issue related to Azure CLI or Azure CLI extensions ?

Hi @udossOpenValue  ,
What type of package are you trying to download ? Is it a universal package?
Since, they can't contain colon in their names.
Refer Azure/azure-devops-cli-extension#806.
If you are still facing the issue, kindly raise a bug in this repo : https://github.com/Azure/azure-devops-cli-extension/

Closing this issue as per above comment.
Please feel free to file an issue in the extension repo -  https://github.com/Azure/azure-devops-cli-extension if required.


Improve tests when errors are received in the consumer thread

This PR improves the logs in RealtimeSegmentDataManager. Specifically:

If an error is thrown in the consumer thread, it will be logged.
In two other cases, the exception trace was not printed (due to overloaded logging methods being incorrectly used)

@swaminathanmanish

Codecov Report

Merging #11858 (d25b29f) into master (7051e46) will decrease coverage by 48.56%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master   #11858       +/-   ##
=============================================
- Coverage     62.97%   14.41%   -48.56%
+ Complexity     1141      201      -940
=============================================
  Files          2367     2367
  Lines        127938   127937        -1
  Branches      19744    19744
=============================================
- Hits          80570    18445    -62125
- Misses        41642   107928    +66286
+ Partials       5726     1564     -4162

Flag
Coverage Δ

custom-integration1
?

integration
?

integration1
?

integration2
?

java-11
14.41% <0.00%> (-48.48%)
:arrow_down:

java-21
?

skip-bytebuffers-false
14.41% <0.00%> (-48.51%)
:arrow_down:

skip-bytebuffers-true
?

temurin
14.41% <0.00%> (-48.56%)
:arrow_down:

unittests
14.41% <0.00%> (-48.56%)
:arrow_down:

unittests1
?

unittests2
14.41% <0.00%> (-0.03%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

...a/manager/realtime/RealtimeSegmentDataManager.java
0.00% <0.00%> (-50.67%)
:arrow_down:

... and 1535 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Dropdown has some style issues in IE11

As pointed out by @joshblack in #1269
Looks great! Noticed a couple style quirks (potentially):

In IE11, it looks like the background color bleeds down. This could be a remnant of the previous implementation, in which case might be better to file as a bug ticket that we could fix separately. Also noticed it in the disabled styles:

Hello, @tw15egan . Is this still an issue? Would love to help.

I believe this was addressed in https://github.com/IBM/carbon-components/pull/1994 and https://github.com/IBM/carbon-components/pull/2181
testing in https://the-carbon-components.netlify.com/?nav=dropdown on IE11


Add Teams recommendation about WebSocket traffic

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

Copy review fixes committed, thanks for your help 🙂

@SerdarSoysal  PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

@SerdarSoysal PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

@dstrome can you help maybe?
(I apologize for a random mention, I just picked someone more potent with closing PRs from history)
This has been open for a long time and we would like to point customers to this info in the official docs.
Thank you

@tiburd Hi Tina! Hope all is well. Could you please help here? Thanks!


Glyph3d mapper same as #647 after rebase

Glyph3d mapper same as #647 after rebase

NB: from old PR closed https://github.com/medInria/medInria-public/pull/647

@mathildemerle yes it solve #640 tbut he rendering is less smart in 3D. But It do not think that it is relevant to watch it in 3D. (but at least there is no crash)

I use regularly 3D directions in 3D (through the tensor orientations in the diffusion workspace) to check the transmural changes of cardiac fibres, so the rendering of vectors is also relevant in 3D.

Indeed, at Rennes for exemple 3D is also regularly used for brain tensors applications.

The issue might not be from the this solution but from the 3D view. I have just opened a mesh (created from a mask) but that is thin (like this vector field) and it is difficult to watch it on 3D without another loaded 3D data. Maybe if you load this 2 vector field after the load of a full 3D data, you don't have this pb.

I tried this Pull Request with the "Gradient.mha" data you sent us @nbaraka on 28/04/2020, there is no crash switching in 3D, but there is no displayed data in the view. If you rotate the view, you can see a thin layer, but i don't think your data should looked like that. And if you continue the rotation, medInria crash.
I put this PR on invalid for now, just to be sure not to merge it yet :)

The original issue is solved in #706


apps that open to a set space don't tile

Possibly related to https://github.com/koekeishiya/chunkwm/issues/179. If you have a space set for an app via Dock, opening it from a different space causes it to not be tiled. I use the Dock's version rather than chunkwm rules because it will switch to the appropriate space while launching. I know we can't replicate that behavior with rules, but is there a way to solve the tiling issue?

The issue seems to be that the window gets created before the space transition is completed. When an app takes longer to open than the transition time, the window is properly tiled when it spawns.

I can partially reproduce that. Using finder for instance, I notice the new window getting tiled on the desktop that it is opened on, and then macOS moves it to the assigned desktop, but it also gets tiled properly there for me.
I don't really know how to fix that. For what it's worth though, I could add a 'follow-focus' modifier probably to the chunkwm rules, that will move the window and make the space transition happen.

I added a modifier to the window-rules, that will specify the rule to switch to the appropriate desktop after moving the application there.
e.g: chunkc tiling::rule --owner Spotify --desktop 5 --follow-desktop
I have tested this briefly with a couple of different applications and it seemed to work fine, both with a single monitor and with an external monitor connected.
You could try and see if this works for your use-case and use that instead of the macOS way of doing it. At least until we figure out a way to deal with the issue at hand, if possible.


Scroll issue in 'Debug Console'

VS Code Version:
OS Version:
Version: 1.55.2
Commit: 3c4e3df9e89829dce27b7b5c24508306b151f30d
Date: 2021-04-13T09:36:32.643Z
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 19.5.0

Steps to Reproduce:

Clearing the DEBUG CONSOLE area.
Running npm run debug.
Expected: The DEBUG CONSOLE scrolls down until the end.
Actual:  The DEBUG CONSOLE scrolls down a bit and then stops, without any intervention by me, forcing me to scroll all the way to the bottom manually by myself to see the last line.
This causes me not to know whether or not the build process is done or not.

Does this issue occur when all extensions are disabled?: Yes

The project is a Typescript Node project.
These are the relevant line from the package.json file:
"scripts": {
"task:tslint": "tslint -c tslint.json -p tsconfig.json --fix",
"task:typescript": "tsc -sourcemap",
"task:typeORM_run_migrations": "typeorm migration:run",
"build": "npm-run-all task:tslint task:typescript task:typeORM_run_migrations",
}

Dup of https://github.com/microsoft/vscode/issues/117674


Cannot set property 'patches' of undefined

Hey, I'm using ember-cli which uses this library. During the build, I suddenly have this stacktrace (works before). Any idea?
The Broccoli Plugin: [Funnel: Funnel: index.html] failed with:
TypeError: Cannot set property 'patches' of undefined
    at Funnel.processFilters (/app/tmp/cache/node_modules/broccoli-funnel/index.js:308:33)
    at Funnel.build (/app/tmp/cache/node_modules/broccoli-funnel/index.js:233:10)
    at /app/tmp/cache/node_modules/broccoli-plugin/read_compat.js:61:34
    at tryCatch (/app/tmp/cache/node_modules/rsvp/dist/rsvp.js:538:12)
    at invokeCallback (/app/tmp/cache/node_modules/rsvp/dist/rsvp.js:553:13)
    at publish (/app/tmp/cache/node_modules/rsvp/dist/rsvp.js:521:7)
    at flush (/app/tmp/cache/node_modules/rsvp/dist/rsvp.js:2373:5)
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickCallback (internal/process/next_tick.js:98:9)
The broccoli plugin was instantiated at:
    at Funnel.Plugin (/app/tmp/cache/node_modules/broccoli-plugin/index.js:7:31)
    at new Funnel (/app/tmp/cache/node_modules/broccoli-funnel/index.js:57:10)
    at EmberApp.index (/app/tmp/cache/node_modules/ember-cli/lib/broccoli/ember-app.js:641:15)
    at EmberApp.toArray (/app/tmp/cache/node_modules/ember-cli/lib/broccoli/ember-app.js:1603:10)
    at EmberApp.toTree (/app/tmp/cache/node_modules/ember-cli/lib/broccoli/ember-app.js:1626:30)
    at module.exports (/tmp/build_261851e7af050fd916277787d1c1c44c/ForestAdmin-forestadmin-ea054b32b7621ae713614798a568b506d70f08a4/ember-cli-build.js:83:14)
    at CoreObject.module.exports.Task.extend.setupBroccoliBuilder (/app/tmp/cache/node_modules/ember-cli/lib/models/builder.js:74:19)
    at CoreObject.module.exports.Task.extend.init (/app/tmp/cache/node_modules/ember-cli/lib/models/builder.js:54:10)
    at CoreObject.superWrapper [as init] (/app/tmp/cache/node_modules/core-object/lib/assign-properties.js:32:18)
    at CoreObject.Class (/app/tmp/cache/node_modules/core-object/core-object.js:32:33)
 !     Push rejected, failed to compile Ember CLI app.
 !     Push failed

Add Comment

It's due to a recent heimdalljs update (0.2.1 works fine, 0.2.2 doesn't).

Just started seeing this as well. @msvanvertloo any ideas on how to resolve this?

I was able to get around this by just specifying "heimdalljs": "0.2.1" in the package.json, for whatever that's worth

Awesome @mikebarr58 thanks for confirming that this is indeed the problem, I have a PR ready, just need someone to approve or merge.

see https://github.com/ember-cli/ember-cli/issues/6435
tl;dr v0.2.2 is a bad release, fixed with v0.2.3 release


February example3 working with an old libstreaming export: no callback buffer error

In libstreaming-example-master of February 21th 2014, the example works correctly with the libstreaming-4.0.jar in libs directory. If I try the same example code with the last libstreaming-master.zip code, I've always the 'Callback buffer was too small !'
I need to use the libstreaming-master.zip because of some edits I did on it... so can't use the old .jar file in my project.
I really don't know where's the issue...

+1


proposal: build tags dependency exclusion

Description
When building my Go binary, I tried using build tags (a, b) to decrease the size of my binary. But the binary size stayed the same, even though i wasn't using the library in the build 'a'.
So I wanted to make a proposal for optimizing builds to not include the dependencies that are not in use; similar to how test dependencies can be excluding from binaries when that are in a different module.
Use Case
I have a binary which will have a bunch of features/integrations (~10 different options for now). And some clients might not need all, if any. So that could decrease the binary size by 50MB. This may be more or less depending on the libraries.

This should already work. Files excluded using build tags should not even be compiled, let alone included in a binary.
Can you show us a complete example of what you are doing?
Taking out of proposal, this is either a bug or a misunderstanding of how build tags work.

please provide a reproducer to demonstrate the issue

Sure, hold on.


Adding a md to bootstrap filter

Is someone working on a Lua filter to convert md to bootstrap?
I thought of something like this: https://github.com/fxpar/Pandoc-Lua-Markdown-Bootstrap

Trying a fork https://github.com/fxpar/lua-filters/tree/master/md-to-bootstrap if someone wants to work on this

Personally, I would not put it into a Lua-Filter, but instead use a custom output template for HTML.
Here are some related projects:
https://git.tpi.uni-jena.de/dg/notes/-/tree/main/md/pandoc-bootstrap-template
https://github.com/ashki23/pandoc-bootstrap (I tweaked this for my personal needs)
You could also try to reuse the work from the Quarto project, which internally uses Pandoc, afaik.

Thanks @mfhepp
Unfortunately these projects succeed in including the markdown content into a bootstrap environment (with navbar, sidebar, toc...) , but they do not convert the content into bootstrap components.
What I am looking for is a way to turn the content into cards, carousel, accordion...
A Lua filter seemed a good option to achieve this.
Here is where I got with lots of help from @tarleb :  https://github.com/fxpar/lua-filters/tree/master/md-to-bootstrap#header-block-jumbotron

Manubot does this for the HTML output, see here.
For examples of the resulting HTML, see the Manubot catalog or e.g. this one here.
While the standard Manubot output is not based on Bootstrap, you could follow the same route.
You might want to use a filter for adding Bootstrap CSS classes to Pandoc elements or to modify some aspects of the document. But I would strongly advise not to bypass Pandoc for creating the HTML output.
By the way, AFAIK, all additional classes from Markdown will be passed to the resulting HTML elements, so you can actually specify Bootstrap classes directly in Markdown.
As said, https://github.com/ashki23/pandoc-bootstrap  is basically a skeleton for your needs, IMO.

Thank you very much @mfhepp for pointing me in direction of Manubot, which I didn't know.
I will investigate the possibilities.
In the meanwhile, here is a demo of the conversion for teachers. You can see how quickly a quiz can be created.
Thanks again for the link.

Here is a first version of the Markdown to Bootstrap filter.
Still a lot of work to do, but the first result looks really promising:
https://github.com/fxpar/markdown-to-bootstrap-pandoc-lua-filter
Thanks a lot to @tarleb for his coding help and @mfhepp for the advice.

Very cool! I've tweeted about it to get the word out.

Thanks for your effort! However, I still think that the approach you take can be made much more sustainable, in particular for Markdown documents that shall be converted to multiple output formats (e.g. Web page, lecture notes, Beamer slides).
Basically, I am not convinced that replacing the fenced divs by HTML inline directly is a good technique.
Your approach works as a quick hands-on solution, but it has caveats:

Your dedicated new HTML template has to be kept in sync with changes in the official Pandoc HTML template and the HTML writer; avoid that if possible by rather using

--include-in-header
--include-before-body
--include-after-body

either in a defaults file or in the YAML meta-data of the document or a meta-data file.
The WWW is full of historical tweaks of the Pandoc HTML and LaTeX templates that fixed a problem back then but won't work with the current Pandoc version.
2. The Markdown will be unavailable or not look nice in other output formats without another filter. Ideally, a format-specific feature will not hurt standard output formats. This will make your content files much harder to maintain and reuse (e.g. for a later textbook, Beamer slides, ...).
3. The manual generation of HTML snippets may break when handling special characters, Unicode, unexpected content, etc. That is similar to generating XML with print statements - it works at first, but will bite you later on.
4. The order of executing filters will matter, because you the original Markdown will not be available for subsequent filters (think of spell-checkers etc.).
Note that is is straightforward in Pandoc Markdown to attach CSS classes and attributes to fenced divs in a way that they will be

preserved by the standard Pandoc HTML template,
accessible for other filters and formats, and
do not harm for output formats that do not need them.

Just add curly brackets to the opening fence and add a dot in front of class names.

Pandoc will generate HTML like so

A simple primary alert—check it out!

A simple secondary alert—check it out!

A simple success alert—check it out!

A simple danger alert—check it out!

A simple warning alert—check it out!

A simple info alert—check it out!

A simple light alert—check it out!

A simple dark alert—check it out!

See attached image.

hi @mfhepp
Thank you taking time to write a detailed answer.
POC
Indeed, my filter is more a "proof of concept" to show that teachers, without any html or css knowledge, can easily output complex bootstrap material like tabs, carousel and accordion for elearning production. I hope that some people with better understanding of Lua will undertake the challenge of rewriting the code in some efficient way, especially to easily maintain it and keep up with pandoc evolution. Unfortunately, this is beyond my competences... I already bothered Tarleb enough.
Expert subject matter on ipads
The use of complex syntax like curly brackets, dots, double quotes, equal sign, in front of attributes is, for some people I work with (subject matter experts in HR, law or litterature), far out of reach and should be avoided as much as possible. Often they type or update content using ipads or phones, and the accessibility of characters like square brackets or curly brackets make writing very error prone. Even typing the code for an image in markdown is a pain on a phone, requiring to get the url in one window, copying it, coming back to the editor which often reloads and loses previous typing, finding the exclamation mark...
Simplification
The repetition of attributes in bootstrap (three times "alert" in the the css) should also be handled by the filter to relieve the typing. That's why I opt for ::: success  rendering as
 without the necessity for content editor to know anymore about bootstrap than the type of the div.
The concern you express about unicode or content breaking the output is of course what any programmer dreads when intput is not sanitized enough... for now I don't have solution, and I hope someone will answer to get some directions on this.
Thank you again for your engagement and support in my project.
F

I appreciate your effort, but frankly “Premature optimization is the root of all evil” - hard-coding functionality that circumvents the official architecture will make your solution brittle and hard to maintain. If you are aiming at a quick fix, that's fine. For a lasting contribution, it will backfire sooner or later.
If you want to free users from knowing the Bootstrap classes etc., then why not simply write a LUA filter that replaces simpler, custom class identifiers to the required ones for Bootstrap, and then pass all further processing to the regular Pandoc workflow and components (HTML exporter etc.)?
Like so
User writes:
:::{.bootstrap_alert}
A simple primary alert—check it out!
:::

or, simpler (when you do not need additional classes or attributes attached to the fenced div):
::: bootstrap_alert
A simple primary alert—check it out!
:::

Filter will translate to:
:::{.alert .alert-primary role="alert"}
A simple primary alert—check it out!
:::

I've added the filters and template mentioned here to https://github.com/pandoc-ext/info, the repository where I'll collect this kind of information for now.
Closing this issue, as we won't add new filters to this repository.


Can you merge the quote fix in dev branch?

What do you want?

Can you merge the quote fix in dev branch?
Why do you want this?

Binding commands with arguments doesn't work due to mishandled quotes.
Who else would benefit from this?

Everyone.
How should it work?
Given this situation:

When I perform these steps:

Then I expect this to happen:

@IhsanGunay Done.


Fix issue#11 - input becomes black-on-black when replying to a thread

@widget- Thanks so much for merging, and thanks for such great work on this theme! :)


Misspelling Fixed

Just fixed the spelling on line 64.

Thank you! Even though PowerBot is no longer hosted, any improvements still help a lot! As some people may be selfhosting it :) Merged!


Allow users to merge accounts

Is your feature request related to a problem? Please describe.
Users may sign in twice and now have two accounts.
Describe the solution you'd like
If a user signed up twice accidentally, allow them to merge accounts.
Describe alternatives you've considered
N/A
Additional context
Probably not to be done initially but so we don't forget it.

fastapi-users can be configured accordingly


Shorten README.md and add FAQ

Description of changes: this change reduces significantly the size of the README.md by keeping mostly an install section, a small getting-started section and links to extra references. A FAQ have been created which contains the information that was previously in the README.md (how to setup AWS, what output is available etc).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

PS: the FAQ section has been written offline with @mseeger.


NoMethodError: undefined method `inspec_gem' for cookbook: audit, recipe: inspec :Chef::Recipe

Cookbook version
6.0.1
Chef-client version
14.1.21
Platform Details
AWS EC2 Centos 7.5.1804
Scenario:
I'm trying to run the audit cookbook's default recipe.
Steps to Reproduce:
I have a compliance cookbook which depends on audit. It sets up some compliance info based on the platform and includes the audit cookbook.
Expected Result:
Successful convergence.
Actual Result:
Fails with undefined method.
================================================================================
Recipe Compile Error in /hab/svc/chef-base/data/cache/cache/cookbooks/compliance/recipes/default.rb
================================================================================

NoMethodError
-------------
undefined method `inspec_gem' for cookbook: audit, recipe: inspec :Chef::Recipe
Did you mean?  inspect

Cookbook Trace:
---------------
  /hab/svc/chef-base/data/cache/cache/cookbooks/audit/recipes/inspec.rb:20:in `from_file'
  /hab/svc/chef-base/data/cache/cache/cookbooks/audit/recipes/default.rb:30:in `from_file'
  /hab/svc/chef-base/data/cache/cache/cookbooks/compliance/recipes/default.rb:22:in `from_file'

Relevant File Content:
----------------------
/hab/svc/chef-base/data/cache/cache/cookbooks/audit/recipes/inspec.rb:

 13:  #
 14:  # Unless required by applicable law or agreed to in writing, software
 15:  # distributed under the License is distributed on an "AS IS" BASIS,
 16:  # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 17:  # See the License for the specific language governing permissions and
 18:  # limitations under the License.
 19:
 20>> inspec_gem 'inspec' do
 21:    version node['audit']['inspec_version']
 22:    source node['audit']['inspec_gem_source']
 23:    action :nothing
 24:  end.run_action(:install)
 25:

System Info:
------------
chef_version=14.1.21
platform=centos
platform_version=7.5.1804
ruby=ruby 2.4.2p198 (2017-09-14 revision 59899) [x86_64-linux]
program_name=/hab/pkgs/chef/chef-client/14.1.21/20180521162341/bin/chef-client
executable=/hab/pkgs/chef/chef-client/14.1.21/20180521162341/bin/chef-client

Whoop, just me being a tool. 😞


Bonus DPS mod (MOD_DPS_ADD) calculation not consistent with original YouTD

DPS mod uses current attack speed which is inconsistent with original YouTD that used base attack speed. It is also annoying when playing knowing that your attack speed bonuses 'work against' your damage per hit (after I've discovered that).
https://github.com/Praytic/youtd2/blob/48ce2674c62e3e008b9370aae3e5f920bb23efc0/src/towers/tower.gd#L1113-L1118
Another layer of inconsistency is that resulting bonus damage from DPS * base_attack_speed calculation was added to "damage add" originally so it was affected by "damage add %" bonuses, while here it is not affected.
Here's example of DPS mod and damage add % on a tower: 450 dps add * 1.6 base attack speed = 720 damage add. And +5% from damage add % also applied on top of it which is confirmed by calculating ((1076*0.91) + 720) * 1.05 ~= 1784.

In order to replicate original functionality that code could look like:
        var dps_bonus: float = get_dps_bonus()
        var attack_speed: float =  get_base_attack_speed()
	var dps_mod: float = dps_bonus * attack_speed

	var overall_base_damage: float = (base_damage + base_bonus) * base_bonus_percent
	var overall_damage: float = (overall_base_damage + damage_add + dps_mod) * damage_add_percent

I'm not aware of other places in the code that would need to be modified. All this is relevant unless that change is intentional. If it is intentional - it feels sort of wrong for someone who played YouTD for years.
Thanks for your time!

This is not intentional, it's a mistake. The goal is to have same combat logic as original YouTD.

DPS mod uses current attack speed which is inconsistent with original YouTD that used base attack speed.

Confirmed, check JASS code from original game below.
function Xcv takes integer D0,integer P6,real k5 returns nothing

...

if(P6==5)then
// k5 is value of MOD_DPS_ADD
// dC[cL[D0]] is base attack cooldown
set P6=3
set k5=k5*dC[cL[D0]]
endif

Another layer of inconsistency is that resulting bonus damage from DPS * base_attack_speed calculation was added to "damage add" originally so it was affected by "damage add %" bonuses, while here it is not affected.

Confirmed.
MOD_DPS_ADD

...

// km = base damage and MOD_DAMAGE_BASE and MOD_DAMAGE_BASE_PERC
// sL[SL[D0]+3] = MOD_DAMAGE_ADD and "dmg bonus from MOD_DPS_ADD"
// sL[SL[D0]+4] = MOD_DAMAGE_ADD_PERC
set Km=R2I((km+sL[SL[D0]+3])*(1+sL[SL[D0]+4])-km)
call vLv(bL[D0],0,vm[xm[D0]+3],Km)
set vm[xm[D0]+3]=Km

Frozen Root, max upgrade, Short Sword (+5% damage add), Tooth Trophy (+450DPS), 0.75 attack cooldown
Before fix:
1132->1526
1132 * 1.05 + 450 * 0.75 = 1188,6 + 337.5 = 1526

After fix:
1132->1543
(1132 + 450 * 0.75) * 1.05 = 1132 + 337.5 = 1543

Closed by 0d3aea604ca775c50d16934b0cffac3c878d7764 and fcfbcf6d6c331d144d8525955bdf2ce594c02d79

Thank you for such quick fix!
One more point to look for (idk how current build works): the multiboard for tower could show damage add (flat) coming from DPS increases - as it is the case in original game (the screenshot with Skilled Witch that I provided) and I suspect that it will not be the case given the scope of those updates (I assume it will use only "damage_add" property from tower and not "damage add" + "DPS add * base attack speed").

I just thought about it and maybe even this part could be removed from damage calculation:
https://github.com/Praytic/youtd2/blob/b879e2edeea954bfb94a82cf9b4c4fa8ed59482f/src/towers/tower.gd#L1113-L1115
and become a part of this function (it would combine "static" damage add and DPS damage add):
https://github.com/Praytic/youtd2/blob/b879e2edeea954bfb94a82cf9b4c4fa8ed59482f/src/unit/unit.gd#L1771
or a similar function i.e. "get_total_damage_add".
It then could possibly correctly display in the multiboard too I assume.
That's just a suggestion, thanks again for you time!

Thank you for such quick fix!
One more point to look for (idk how current build works): the multiboard for tower could show damage add (flat) coming from DPS increases aswell - as it is the case in original game (the screenshot with Skilled Witch that I provided) and I suspect that it will not be the case given the scope of those updates (I assume it will use only "damage_add" property from tower and not "damage add" + "DPS add * base attack speed").

Oh yeah, you're right. Original game does display "Damage add" stat as "damage add" + "bonus from MOD_DPS". Will fix that.


[IOTDB-1259] upgrade libthrift from 0.12.0/0.13.0 to 0.14.1 and updated related classes or files

The former related pr is https://github.com/apache/iotdb/pull/2935

There are some UT still failed, I'm trying to fix this, if all the UTs are fixed, I'll approve this PR.

The CI[1] failed is due to the 0.14.1 thrift use the OpenSSL lib[3] while the CI's workflow does not install the OpenSSL, It can be fixed in the next PR.
The CI[2] failed is not introduced by this PR, so I'd like to merge this PR and resolved the failed CI in the next PR.
[1] https://github.com/apache/iotdb/pull/3163/checks?check_run_id=2583170722
[2] https://github.com/apache/iotdb/pull/3163/checks?check_run_id=2583171026
[3] https://github.com/apache/thrift/blob/0.14.1/lib/cpp/src/thrift/transport/TWebSocketServer.cpp#L24