fix: ddp bug

PR Description
This PR updates the metric computation step to ensure that all returned metrics (map and related values) are moved to the GPU device before logging. Without this change, calls to pl.log would trigger runtime errors by attempting distributed reductions (all_reduce) on CPU tensors under the nccl backend in multi-GPU training environments.

Yes, if the output metrics are stored on the device's CPU

Let's test this out and include the fixes for others as well under this PR in that case


Set version to 0.1.3.

The previous version 0.1.3-0 breaks the built application upon loading because the jupyter-js-widgets-labextension external package specifies that it needs JupyterLab version ^0.1.0. While 0.1.3-0 is a legitimate semver version, it does not satisfy the ^0.1.0 constraint because the -0 substring makes it a provisional release. In fact, these substrings are typically meant for things like -alpha, -beta, -rc.1, -rc.2 and should not be necessary for a simple patch release like this one.
Because it is a runtime error, the automatic build process does not catch it.

This is a helpful site for determining semver constraint matching: http://jubianchi.github.io/semver-check/
In general, I think the liability that is raised by having jupyter-js-widgets-labextension capable of breaking JupyterLab for all users checking out master is something we need to address. One solution is to have some sort of sanity check. Another is to fold in the widgets extension into JupyterLab. A third idea is to not include widgets by default. But one way or another, we should try to create a process that prevents this from happening.
cc: @jasongrout @blink1073

Ahh. Yet again! You're right.

In general, I think the liability that is raised by having jupyter-js-widgets-labextension capable of breaking JupyterLab for all users checking out master is something we need to address. One solution is to have some sort of sanity check. Another is to fold in the widgets extension into JupyterLab. A third idea is to not include widgets by default. But one way or another, we should try to create a process that prevents this from happening.

I think until we have full 3rd party extension support, we should go ahead and fold it back in to the code base. When we have 3rd party extension support, we'll try separating it again.

we'll try separating it again.

and not including it by default, just like the current notebook.

In fact, these substrings are typically meant for things like -alpha, -beta, -rc.1, -rc.2 and should not be necessary for a simple patch release like this one.

The rationale is that after releasing a version, we bump to the dev number of the next version, so that the package version reflects the current dev state. But apparently this doesn't play well with semver.

Since we won't know whether the next release will be a patch or minor (or even major), I think preemptively updating the release number is less straightforward than it seems. I would propose keeping the same version as the current release until it's time to actually publish a new version. Otherwise, we'll have "false" versions in the master branch that may never come to fruition.


DrawState: ValidateBarriers reports errors for image subresources when using VK_REMAINING* to select subresource

Hi,
ValidateBarriers of the DrawState validate will report errors for invalid ranges of images for image barriers for the cases when the mip range is VK_REMAINING_MIP_LEVELS and/or the array range is
VK_REMAINING_ARRAY_LAYERS.

Can you please provide more information as to which errors you are seeing?

The tests at https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/blob/master/layers/draw_state.cpp#L6784 : if ((mem_barrier->subresourceRange.baseArrayLayer + mem_barrier->subresourceRange.layerCount) > arrayLayers)
and
https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/blob/master/layers/draw_state.cpp#L6792 : if ((mem_barrier->subresourceRange.baseMipLevel + mem_barrier->subresourceRange.levelCount) > mipLevels)
do not check if the count is the corresponding VK_REMAINING*

Submitted MR 154 to address this.

Fix merged to master


typescript@next (and 2.9.x) outputs node_modules relative path to imports

Related to issue #24599 , where @mhegazy specifically asks to create a separate ticket with more information when using latest typescript@next (^3.0.0-dev.20180630")
Imports get's node_modules added, which breaks Library conventions.
It's easy to replicate.
import ex. a library like @material-ui, which you have as a dependency.
Using a tsconfig file like
"compilerOptions": {
    "baseUrl": "./",
    "rootDir": "src",
    "outDir": "dist",

    "declaration": true,

    "module": "commonjs",
    "target": "es5",
    "lib": [ "es6", "dom" ],
    "sourceMap": true,
    "moduleResolution": "node",

    "jsx": "react",
    "forceConsistentCasingInFileNames": true,
    "noImplicitReturns": true,
    "noImplicitThis": true,
    "noImplicitAny": false,
    "strictNullChecks": true,
    "suppressImplicitAnyIndexErrors": true,
    "noUnusedLocals": false,
  },
  "exclude": [
    "node_modules"
  ]

Will take a .tsx file like:
import * as React from 'react';
import { WithStyles } from '@material-ui/core';
import { withStyles } from '@material-ui/core/styles';
import formBasicsStyles from "./../../../theme/formBasics";

interface IFileUploadProps extends WithStyles{

}

export const FileUpload = withStyles(formBasicsStyles)(
    class extends React.Component<IFileUploadProps> {
        constructor(props: IFileUploadProps){
            super(props);
        }

        public render() {
            const { classes } = this.props;

            return (
                <div>

                </div>
            );
        }
    }
);

And output a d.ts file like:
import * as React from 'react';
import { WithStyles } from '@material-ui/core';
interface IFileUploadProps extends WithStyles {
}
export declare const FileUpload: React.ComponentType<import("node_modules/@material-ui/core").Overwrite<IFileUploadProps, import("node_modules/@material-ui/core/styles/withStyles").StyledComponentProps<string>>>;
export {};

In the output d.ts file one would
expect<EMAIL_ADDRESS>but result is<EMAIL_ADDRESS>Hope information is sufficient.

https://github.com/Microsoft/TypeScript/issues/25186

looks like a possible duplicate of https://github.com/Microsoft/TypeScript/issues/25338

@mhegazy I'd wager it's much more likely another expression of #25186.

Should be fixed by #25364, please try again with typescript@next.


backfeed reviews & ratings from iTunes to original podcast posts

@martymcguire noted that he would like to get backfeed from iTunes of the ratings and reviews that people leave there, sent back to his original podcast posts on his site.

interesting! definitely one of the more exotic silo requests so far. any idea if they have an API, or would we have to use something like https://www.appannie.com/ ?
obligatory, instructions for adding a new silo: https://github.com/snarfed/bridgy/#adding-a-new-silo


MudDataGrid - Scrolling right and click filter not showing up the filter

Bug type
Component
Component name
MudDataGrid
What happened?
On a lengthy datagrid, scrolling to the right and hitting the filter button not showing up the filter popup.

Expected behavior
On a lengthy datagrid, scrolling to the right and hitting the filter button show show up the filter popup.
Reproduction link
https://try.mudblazor.com/snippet/QEQIYQPxAwGuvviy
Reproduction steps

Go to the link "https://try.mudblazor.com/snippet/QEQIYQPxAwGuvviy"
scroll right to the last column
click the filter button on the last column
...

Relevant log output
No response
Version (bug)
6.15.0
Version (working)
No response
What browsers are you seeing the problem on?
Chrome
On what operating system are you experiencing the issue?
Windows
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi @henon ,
I've encountered this issue that I believe could be resolved by appropriately setting the "margin-left" property. However, I'm currently facing challenges in determining the correct values to use. Could you possibly assist me with this, or direct me to someone who can? Any guidance would be greatly appreciated.
Thank you for your time and assistance.
                                    <MudPopover Open="@_filtersMenuVisible" Paper="true" Class="filters-panel pa-2" OverflowBehavior="OverflowBehavior.FlipAlways" AnchorOrigin="Origin.TopLeft"                                                 TransformOrigin="Origin.TopLeft" Elevation="4" Style="width:700px;max-width:700px;z-index:13;" MaxHeight="400">

I have posted the question in the contrib team discord channel. Hopefully someone will find the time to help out.

Wouldn't setting left instead of margin-left be better? Also, the same situation applies when scrolling vertically so defining the top may be required as well.

Thanks for the help @Anu6is ,  let me check that

By the way, when applying margins always use LTR/RTL-invariant margins (start instead of left and end instead of right), see our margin classes ml-* vs ms-*.

Hi @Anu6is , this is working perfectly on the sample. but in the real app, we may have sidebar and app bar, we cannot place them on vh, vw right? shouldn't be relative to the datagrid? What do you think?

Yes, that makes sense. The issue there would be finding the position of the datagrid. The mud popover provider is the actual parent for the filter, not the datagrid

Understood, Can you think of anything that will help us to get to the datagrid? I couldn't find the parent (or) any relevant accessor.

Maybe you can do it differently, like in datagrid observe the scrolling and move the popup accordingly?

Okay. Thanks for the help. Let me take a closer look on the popovet
provider and MudPopover.js.
On Wed, 21 Feb, 2024, 00:40 Anu6is, @.***> wrote:

Understood, Can you think of anything that will help us to get to the
datagrid? I couldn't find the parent (or) any relevant accessor.
Took a closer look at how the popover provider works. The MudPopover.js
should actually correctly associate the popover to the to the table that
the data grid uses. So the table becomes the parent. The issue is that when
scrolled, the table columns are still present offscreen and that popover
uses the table start as its left which means it is also offscreen.
—
Reply to this email directly, view it on GitHub
https://github.com/MudBlazor/MudBlazor/issues/8173#issuecomment-1954888668,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADDXXQAZFZ3JU6RF3O5F5UDYUTYJZAVCNFSM6AAAAABDG4UCVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJUHA4DQNRWHA
.
You are receiving this because you authored the thread.Message ID:
@.***>

has any one found a solution to this issue? is there a work around?

I'm having the same problem here. I noticed that only when I use<MudDataGrid FilterMode="DataGridFilterMode.Simple" ... >  the problem happens, with other FilterMode it is working. However, for my application it is essential that I use DataGridFilterMode.Simple.
Maybe we can check how the other types of filters were positioned to understand how to solve it.

Fixed by PR #10089 and #10106


Respect wildignore setting

Ideally, vimcomplete should respect the wildignore setting and filter out all matching entries.

Path completion behaves similar to <c-x><c-f>. Vim's ins-completion does not use path (or wildignore).
CTRL-X CTRL-F		Search for the first file name that starts with the
			same characters as before the cursor.  The matching
			file name is inserted in front of the cursor.
			Alphabetic characters and characters in 'isfname'
			are used to decide which characters are included in
			the file name.  Note: the 'path' option is not used
			here (yet).


docs: fixed typo in vercel preset

📚 Description
Pretty sure thats a typo and it should be vercel-edge rather than vercel_edge.

🔗 Linked issue

❓ Type of change

[x] 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

Hi thanks for PR. It is not a typo and both are acceptable (also vercelEdge). FYI, we use https://scule.unjs.io to normalize cases.


Tutorial error in creating new table and no information on how to create new table

Superset version
latest develop version
Expected results
New table "testTable" created
Actual results
Table [testTable] could not be found, please double check your database connection, schema, and table name
Stack:
File "/usr/local/lib/python2.7/dist-packages/superset/models.py", line 1176, i                   n get_sqla_table_object
return self.database.get_table(self.table_name, schema=self.schema)
File "/usr/local/lib/python2.7/dist-packages/superset/models.py", line 835, in                    get_table
autoload_with=self.get_sqla_engine())
File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/sql/schema.py", line 4                   16, in new
metadata._remove_table(name, schema)
File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/util/langhelpers.py",                    line 60, in exit
compat.reraise(exc_type, exc_value, exc_tb)
File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/sql/schema.py", line 4                   11, in new
table._init(name, metadata, *args, **kw)
File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/sql/schema.py", line 4                   84, in _init
self.autoload(metadata, autoload_with, include_columns)
File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/sql/schema.py", line 4                   96, in autoload
self, include_columns, exclude_columns
File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/engine/base.py", line                    1972, in run_callable
return conn.run_callable(callable, *args, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/engine/base.py", line                    1477, in run_callable
return callable(self, *args, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/engine/default.py", li                   ne 364, in reflecttable
return insp.reflecttable(table, include_columns, exclude_columns)
File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/engine/reflection.py",                    line 571, in reflecttable
raise exc.NoSuchTableError(table.name)
NoSuchTableError: testTable
Steps to reproduce
In your tutorial:
"
Once your database has been added, it’s time to add your table. Navigate using the navigation bar at the top to Sources -> Tables and click the plus (+) sign there (similar to the one ).
ow enter the name of the table in the Table Name textbox, and select the database you just created in the Database dropdown, hit save. At this moment, Superset fetched the column names, their data types and tries to guess which fields are metrics in dimensions
"
Follow this step and use "testTable" as new table name. All others not touched.

Do you have a testTable in your database? If not the tutorial is correct. Tables are added to superset metadata, they are not created in the database.

I don't have  testTable in database. I guess your're right. So do you mean that these tables should be created out side of superset? Like I should have another program that creates this database and using superset to view those data?

Yes, superset is for exploring and visualizing data you already have.

Thanks. Please add one comment in tutorial so it would be clear. My original thought is that you can create .db by URI, I would expect tables could be created too but yes, it's not like that. One sentence would save some efforts though :)

Sorry me i have already created database and its table, but i have no created a schema yet, i try ,to connect that table but its bring the error
Table [students] could not be found, please double check your database connection, schema, and table name

Same error. Test connection shows up the tables, but add tables (with public schema, admin user) throws the error: Table [sh_events] could not be found, please double check your database connection, schema, and table name

Same error. Test connection shows up the tables, but add tables (with public schema, admin user) throws the error: Table [sh_events] could not be found, please double check your database connection, schema, and table name

i got the same error please have u got found a solution for it please ?

Getting Table[trail] could not be found error even after creating table, Schema and database connection.
Please help us to fix this issue.

@EeshanChatterjee @stardev24 were you able to fix this?


Figure out why omero metadata might be within multiscales[0] rather than at root level of .zattrs

Vitessce is expecting the "omero" property to be in the root of the .zattrs dict, but it is within multiscales for some reason
(Perhaps this was always a valid location for it, or perhaps it changed in a newer version of the OME-Zarr specification).
Reference: https://github.com/vitessce/vitessce/blob/cf48564ff115f1260b20a5dfd1958aaa7048ac3e/packages/file-types/zarr/src/ome-loaders/OmeZarrLoader.js#L34C13-L34C18
For now, we can manually copy the value to the root of the dict so that it is where Vitessce expects.
with open(zattrs_path, "r") as f:
    zattrs = json.load(f)

zattrs["omero"] = zattrs["multiscales"][0]["omero"]
with open(zattrs_path, "w") as f:
    json.dump(zattrs, f)

Update: seems like a bug https://github.com/ome/ome-zarr-py/issues/260

Related: we do specify the ome-zarr version in https://github.com/vitessce/vitessce-python/blob/main/pyproject.toml#L66
But perhaps it is not respected when installing other packages at the same time like:
pip install vitessce[all] jupyterlab

(similar to #254 issue)


[Guide] Data Structures: Create a Queue Class

Added Data Structures: Create a Queue Class method, solution and references.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

@ezioda004 Nice work!


Update omnisharp-roslyn submodule so omnisharp-roslyn build scripts work

When executing the build scripts for omnisharp-roslyn, there were errors on the Test task.
========================================
Test
========================================
Executing task: Test
An error occured when executing task 'Test'.
Error: Could not find file 'C:\src\omnisharp-vim\omnisharp-roslyn\.tools\xunit.runner.console\tools\xunit.runner.utility.desktop.dll'.

Xunit changed the naming scheme for their DLLs, which was fixed in commit 339ed00 of omnisharp-roslyn, so I updated to that commit.
I was going to update to their latest release tag, but that doesn't include the fix.

I am sorry I did not reply.
I did not have time to confirm this, but I got a report from #299.
I merged. Thank you!


Publish release helm chart through release.sh

If you don't mind, I will close this in favor of https://github.com/infracloudio/botkube/issues/584 🙂


updated to add the affy 500k as well, include platform-entrez.bed fil…

…es in repo

SNP-to-Gene.ipynb had changes that couldn't automatically be merged. I also reorganized the repo so some files were misplaced.
Therefore I manually added your changes, rather than trying to merge.


can't install onefuzz-2.10

Information

Onefuzz version:2.10
OS: Ubuntu 20

Provide detailed reproduction steps (if any)
1.cd src/cli ; sudo python3 setup.py install
2.
3.
Expected result
What is the expected result of the above steps?
Actual result
Running pycparser-2.20/setup.py -q bdist_egg --dist-dir /tmp/easy_install-1ctq8r7c/cryptography-3.3.2/temp/easy_install-57haap5y/pycparser-2.20/egg-dist-tmp-_876y376
warning: no previously-included files found matching 'setup.pyc'
warning: no previously-included files matching 'yacctab.' found under directory 'tests'
warning: no previously-included files matching 'lextab.' found under directory 'tests'
warning: no previously-included files matching 'yacctab.' found under directory 'examples'
warning: no previously-included files matching 'lextab.' found under directory 'examples'
zip_safe flag not set; analyzing archive contents...
=============================DEBUG ASSISTANCE=============================
If you are seeing a compilation error please try the following steps to
successfully install cryptography:
1) Upgrade to the latest pip and try again. This will fix errors for most
   users. See: https://pip.pypa.io/en/stable/installing/#upgrading-pip
2) Read https://cryptography.io/en/latest/installation.html for specific
   instructions for your platform.
3) Check our frequently asked questions for more information:
   https://cryptography.io/en/latest/faq.html
=============================DEBUG ASSISTANCE=============================

Traceback (most recent call last):
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 157, in save_modules
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 198, in setup_context
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 255, in run_setup
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 285, in run
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 253, in runner
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 47, in _execfile
File "/tmp/easy_install-1ctq8r7c/cryptography-3.3.2/temp/easy_install-57haap5y/pycparser-2.20/setup.py", line 35, in
description="Onefuzz Client Library for Python",
File "/usr/lib/python3.8/distutils/core.py", line 148, in setup
dist.run_commands()
File "/usr/lib/python3.8/distutils/dist.py", line 966, in run_commands
self.run_command(cmd)
File "/usr/lib/python3.8/distutils/dist.py", line 985, in run_command
cmd_obj.run()
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/command/bdist_egg.py", line 209, in run
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/command/bdist_egg.py", line 245, in zip_safe
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/command/bdist_egg.py", line 355, in analyze_egg
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/command/bdist_egg.py", line 392, in scan_module
ValueError: bad marshal data (unknown type code)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 157, in save_modules
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 198, in setup_context
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 255, in run_setup
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 285, in run
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 253, in runner
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 47, in _execfile
File "/tmp/easy_install-1ctq8r7c/cryptography-3.3.2/setup.py", line 44, in
install_requires=requirements,
File "/usr/lib/python3.8/distutils/core.py", line 108, in setup
_setup_distribution = dist = klass(attrs)
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/dist.py", line 317, in init
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/dist.py", line 369, in fetch_build_eggs
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/pkg_resources/init.py", line 846, in resolve
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/pkg_resources/init.py", line 1118, in best_match
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/pkg_resources/init.py", line 1130, in obtain
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/dist.py", line 440, in fetch_build_egg
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/command/easy_install.py", line 674, in easy_install
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/command/easy_install.py", line 700, in install_item
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/command/easy_install.py", line 881, in install_eggs
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/command/easy_install.py", line 1120, in build_and_install
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/command/easy_install.py", line 1106, in run_setup
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 258, in run_setup
File "/usr/lib/python3.8/contextlib.py", line 131, in exit
self.gen.throw(type, value, traceback)
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 198, in setup_context
File "/usr/lib/python3.8/contextlib.py", line 131, in exit
self.gen.throw(type, value, traceback)
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 169, in save_modules
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 144, in resume
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/pkg_resources/_vendor/six.py", line 685, in reraise
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 157, in save_modules
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 198, in setup_context
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 255, in run_setup
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 285, in run
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 253, in runner
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 47, in _execfile
File "/tmp/easy_install-1ctq8r7c/cryptography-3.3.2/temp/easy_install-57haap5y/pycparser-2.20/setup.py", line 35, in
description="Onefuzz Client Library for Python",
File "/usr/lib/python3.8/distutils/core.py", line 148, in setup
dist.run_commands()
File "/usr/lib/python3.8/distutils/dist.py", line 966, in run_commands
self.run_command(cmd)
File "/usr/lib/python3.8/distutils/dist.py", line 985, in run_command
cmd_obj.run()
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/command/bdist_egg.py", line 209, in run
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/command/bdist_egg.py", line 245, in zip_safe
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/command/bdist_egg.py", line 355, in analyze_egg
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/command/bdist_egg.py", line 392, in scan_module
ValueError: bad marshal data (unknown type code)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "setup.py", line 32, in
setuptools.setup(
File "/usr/lib/python3.8/distutils/core.py", line 148, in setup
dist.run_commands()
File "/usr/lib/python3.8/distutils/dist.py", line 966, in run_commands
self.run_command(cmd)
File "/usr/lib/python3.8/distutils/dist.py", line 985, in run_command
cmd_obj.run()
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/command/install.py", line 67, in run
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/command/install.py", line 117, in do_egg_install
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/command/easy_install.py", line 411, in run
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/command/easy_install.py", line 655, in easy_install
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/command/easy_install.py", line 702, in install_item
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/command/easy_install.py", line 746, in process_distribution
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/pkg_resources/init.py", line 846, in resolve
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/pkg_resources/init.py", line 1118, in best_match
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/pkg_resources/init.py", line 1130, in obtain
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/command/easy_install.py", line 674, in easy_install
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/command/easy_install.py", line 700, in install_item
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/command/easy_install.py", line 881, in install_eggs
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/command/easy_install.py", line 1120, in build_and_install
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/command/easy_install.py", line 1106, in run_setup
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 258, in run_setup
File "/usr/lib/python3.8/contextlib.py", line 131, in exit
self.gen.throw(type, value, traceback)
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 198, in setup_context
File "/usr/lib/python3.8/contextlib.py", line 131, in exit
self.gen.throw(type, value, traceback)
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 169, in save_modules
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 144, in resume
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/pkg_resources/_vendor/six.py", line 685, in reraise
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 157, in save_modules
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 198, in setup_context
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 255, in run_setup
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 285, in run
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 253, in runner
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 47, in _execfile
File "/tmp/easy_install-1ctq8r7c/cryptography-3.3.2/setup.py", line 44, in
install_requires=requirements,
File "/usr/lib/python3.8/distutils/core.py", line 108, in setup
_setup_distribution = dist = klass(attrs)
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/dist.py", line 317, in init
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/dist.py", line 369, in fetch_build_eggs
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/pkg_resources/init.py", line 846, in resolve
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/pkg_resources/init.py", line 1118, in best_match
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/pkg_resources/init.py", line 1130, in obtain
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/dist.py", line 440, in fetch_build_egg
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/command/easy_install.py", line 674, in easy_install
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/command/easy_install.py", line 700, in install_item
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/command/easy_install.py", line 881, in install_eggs
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/command/easy_install.py", line 1120, in build_and_install
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/command/easy_install.py", line 1106, in run_setup
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 258, in run_setup
File "/usr/lib/python3.8/contextlib.py", line 131, in exit
self.gen.throw(type, value, traceback)
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 198, in setup_context
File "/usr/lib/python3.8/contextlib.py", line 131, in exit
self.gen.throw(type, value, traceback)
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 169, in save_modules
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 144, in resume
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/pkg_resources/_vendor/six.py", line 685, in reraise
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 157, in save_modules
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 198, in setup_context
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 255, in run_setup
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 285, in run
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 253, in runner
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/sandbox.py", line 47, in _execfile
File "/tmp/easy_install-1ctq8r7c/cryptography-3.3.2/temp/easy_install-57haap5y/pycparser-2.20/setup.py", line 35, in
description="Onefuzz Client Library for Python",
File "/usr/lib/python3.8/distutils/core.py", line 148, in setup
dist.run_commands()
File "/usr/lib/python3.8/distutils/dist.py", line 966, in run_commands
self.run_command(cmd)
File "/usr/lib/python3.8/distutils/dist.py", line 985, in run_command
cmd_obj.run()
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/command/bdist_egg.py", line 209, in run
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/command/bdist_egg.py", line 245, in zip_safe
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/command/bdist_egg.py", line 355, in analyze_egg
File "/usr/local/lib/python3.8/dist-packages/setuptools-33.1.1-py3.8.egg/setuptools/command/bdist_egg.py", line 392, in scan_module
ValueError: bad marshal data (unknown type code)

Have you installed the prerequisite from the requirements file before deploying ?
Could your python installation be corrupted (see) ?

@chkeita ah, forgot to add, doing pip install -r requirements.txt in the clif folder gives me this error:
ERROR: Exception:
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/pip/_internal/cli/base_command.py", line 186, in _main
status = self.run(options, args)
File "/usr/lib/python3/dist-packages/pip/_internal/commands/install.py", line 357, in run
resolver.resolve(requirement_set)
File "/usr/lib/python3/dist-packages/pip/_internal/legacy_resolve.py", line 177, in resolve
discovered_reqs.extend(self._resolve_one(requirement_set, req))
File "/usr/lib/python3/dist-packages/pip/_internal/legacy_resolve.py", line 333, in _resolve_one
abstract_dist = self._get_abstract_dist_for(req_to_install)
File "/usr/lib/python3/dist-packages/pip/_internal/legacy_resolve.py", line 282, in _get_abstract_dist_for
abstract_dist = self.preparer.prepare_linked_requirement(req)
File "/usr/lib/python3/dist-packages/pip/_internal/operations/prepare.py", line 515, in prepare_linked_requirement
abstract_dist = _get_prepared_distribution(
File "/usr/lib/python3/dist-packages/pip/_internal/operations/prepare.py", line 95, in _get_prepared_distribution
abstract_dist.prepare_distribution_metadata(finder, build_isolation)
File "/usr/lib/python3/dist-packages/pip/_internal/distributions/sdist.py", line 38, in prepare_distribution_metadata
self._setup_isolation(finder)
File "/usr/lib/python3/dist-packages/pip/_internal/distributions/sdist.py", line 96, in _setup_isolation
reqs = backend.get_requires_for_build_wheel()
File "/usr/share/python-wheels/pep517-0.8.2-py2.py3-none-any.whl/pep517/wrappers.py", line 160, in get_requires_for_build_wheel
return self._call_hook('get_requires_for_build_wheel', {
File "/usr/share/python-wheels/pep517-0.8.2-py2.py3-none-any.whl/pep517/wrappers.py", line 265, in _call_hook
raise BackendUnavailable(data.get('traceback', ''))
pip._vendor.pep517.wrappers.BackendUnavailable: Traceback (most recent call last):
File "/tmp/tmp3ong6c95", line 86, in _build_backend
obj = import_module(mod_path)
File "/usr/lib/python3.8/importlib/init.py", line 127, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 1014, in _gcd_import
File "", line 991, in _find_and_load
File "", line 973, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'setuptools.build_meta'
I've upgraded my pip, setuptools, etc nothing worked

it looks like your installation is missing setuptools try installing it first with
sudo apt-get install python3-setuptools

@adrian-rt, please share how you created the virtualenv, as well.
After activating the virtualenv, you may want to try upgrading to a newer (virtualenv-local) copy of setuptools, e.g.:
python3.7 -m venv vev
. venv/bin/activate
pip install --upgrade setuptools
# ... continue from here

@ranweiler  I didn't create one, I tried to follow somewhat the instructions from https://github.com/microsoft/onefuzz/blob/main/docs/getting-started.md but I guess maybe those are a bit outdated?
now after I have setup the enviroment and upgraded setuptools I get the followin errors:
If I do pip3 install -r requirements in the cli folder:
ERROR: Could not find a version that satisfies the requirement onefuzztypes==0.0.0 (from -r requirements.txt (line 20)) (from versions: 1.0.0, 1.1.0, 1.2.0, 1.3.0, 1.3.1, 1.3.2, 1.3.3, 1.3.4, 1.4.0, 1.5.0, 1.6.0, 1.7.0, 1.8.0, 1.9.0, 1.10.0, 1.11.0, 2.0.0, 2.1.0, 2.1.1, 2.2.0, 2.3.0, 2.4.0, 2.5.0, 2.6.0, 2.7.0, 2.8.0, 2.9.0, 2.10.0)
ERROR: No matching distribution found for onefuzztypes==0.0.0 (from -r requirements.txt (line 20))
I have modified the requirements to change the version for onefuzztypes to 2.10.0 and then get this error:
ERROR: Command errored out with exit status 1:
command: /home/adrian/Downloads/tools/onefuzz-2.10.0/src/cli/vev/bin/python3 -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-lf3ncfih/future/setup.py'"'"'; file='"'"'/tmp/pip-install-lf3ncfih/future/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(file);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, file, '"'"'exec'"'"'))' bdist_wheel -d /tmp/pip-wheel-kyj8v9u9
cwd: /tmp/pip-install-lf3ncfih/future/
Complete output (6 lines):
usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
or: setup.py --help [cmd1 cmd2 ...]
or: setup.py --help-commands
or: setup.py cmd --help
error: invalid command 'bdist_wheel'
ERROR: Failed building wheel for future
I tried to do pip3 install -r requirements.txt and it worked without any error, however when I do sudo python3 setup.py install
I get the bad marshall data error agian.
I ran the find /usr -name '*.pyc' -delete but still doesn't work.

ps: I think I found an easy solution with pip3 install onefuzz :)

Generally comment: our instructions actually indicate using pip to install in the first place, whereas it looks like you were initially using python3 directly against the setup.py for the CLI package. It doesn't look like you installed the onefuzztypes package first, which may have been one your problems.
But first, let's validate the existing Getting Started instructions. I confirmed that to install the OneFuzz CLI, the following works on a fresh Ubuntu 20.04 VM, using OneFuzz release 2.10.0:
# Sync apt repo
$ sudo apt update
# WARNING: optional, will upgrade all system packages, but I did this step
$ # sudo apt upgrade
# install the `venv` module: https://docs.python.org/3/library/venv.html
$ sudo apt install python3-venv
# create a virtualenv named `venv`
$ python3 -m venv venv
# Activate the virtual env in your shell session.
$ . venv/bin/activate
# Check that we have the latest `onefuzz-...whl` and `onefuzztypes...whl` packages downloaded.
(venv) $ ls onefuzz*.whl
onefuzz-2.10.0-py3-none-any.whl  onefuzztypes-2.10.0-py3-none-any.whl
# Install them.
(venv) $ pip install onefuzz*.whl
# Check that the `onefuzz` CLI is now in the path, because it was installed to our virtualenv
(venv) $ which onefuzz
/home/joe/venv/bin/onefuzz
# Check the version
(venv) $ onefuzz --version
onefuzz 2.10.0

I did not install any Ubuntu Python packages other than what is listed above (python3-venv). Small modifications might be needed for different versions or distros.
The virtual environment is not essential, but I strongly recommend it to isolate dependencies, avoid conflicts with other applications, and enable easy upgrades. If you really want to install the CLI more globally, you should install python3-pip (as you observed), and do:
$ sudo apt install python3-pip
# Assumes both the `onefuzz` and `onefuzztypes` wheels are in the current dir, as above.
$ pip3 install onefuzz*whl
# Binaries get installed by `pip` to `$HOME/.local/bin`
$ ./local/bin/onefuzz --version
onefuzz 2.10.0

Second, @adrian-rt, OneFuzz is a system primarily designed to orchestrate fuzzing in Azure. The CLI tool really just makes HTTP calls to various endpoints. These CLI- and SDK-facing endpoints (+ orchestration logic and the resources they manage) are contained in a single Azure Resource Group, which you must deploy. This is described in the Getting Started Guide, and is exactly what it means to "deploy an instance of OneFuzz".
I've created #745 to capture ways we can add more documentation for specific installation scenarios, perhaps using some of my above commentary as a starting point. I believe this issue is resolved, so please open a new one if you have trouble deploying using the Getting Started guide. I recommend using a virtualenv for the deploy script, too.


Testing

new notation compatible with the work of thers

Some general remarks:

Tests should be in tests not src/tests
Why do we need so many instances in testing?
NO BINARY OUTPUT FILES IN THE REPO!!! PLEASE REMOVE THEM WITH AN APPROPRIATE HISTORY REWRITE!!!


Add toToml template function

This pr adds a toToml template function that is modeled on toYaml and toJson.

TOML IS BACK!!!!
(I first wanted to encode chart value files in TOML because I think it's much prettier than YAML.)
Ought we also do a fromToml function? I guess that's probably of limited value, since charts tend not to have base TOML data, but I could imagine users wanting to do something like this: {{ $params := .Files.Get "my.toml" | fromToml }}. If that's a lot of work, we can punt until later.

@technosophos I thought about it but as you mention the usage would be limited. Also the two main TOML libraries (BurntSushi, naoina) require struct tags for the unmarshall which looked difficult to implement so I avoided it.

Alright, in spite of what GitHub is reporting, CircleCI is indeed passing the tests. So I am merging this.


GitLab support on KIE Sandbox

Allow users to import individual files from GitLab like we do with GitHub
Assuming that an authentication mechanism is already provided
Allow users to create repositories on GitLab like we do with GitHub
Allow users to import private repositories from GitLab, like we do with GitHub
Allow KIE Sandbox to configure with private instances of GitLab, not only gilab.com

This required creating a new AuthProvider type "gitlab" and configuring its UI on the Accounts modal

Any news about this feature?

Hi @vicclavijo, we still didn't have an ETA for this task, I think we can reconsider its priority in the next few months, as we received a lot of requests to implement it. Please follow this ticket for updates.
//cc @tiagobento

We are also interested in this feature. Hope you guys can manage!
Thanks a lot for your effort

I am also interested and looking forward to have the gitlab support with kie-sandbox.

Hi Team,
Any news about this feature?


Number is incopatible with type "0" from example

function sum(...numbers: Array<number>) {
  return numbers.reduce((a, b) => a + b, 0); // Error here
}

sum();             // 👌!
sum(1);            // 👌!
sum(1, 2);         // 👌!
sum(1, 2, 42);     // 👌!
sum(1, 2, 42, 14); // 👌!
// ...

Type "number" is incompatible with type "0"

Playground
Example from Rest Argument

very interesting bug!
problem is that number literal 0 is assumed to be U in reduce (wrong)
and then number literal is not assignable to number (this part is correct)
so if you annotate U as number anywhere it will work
void [1].reduce((a, b) => a + b, 0); // Error

void [1].reduce<number>((a, b) => a + b, 0); // Ok
void [1].reduce((a: number, b) => a + b, 0); // Ok
void [1].reduce((a, b): number => a + b, 0); // Ok

const num: number = 0// use type casting in variable declaration since inline type casting is not supported

void [1].reduce((a, b) => a + b, num); // Ok

this is type definition of reduce
interface Array<T> {
  // ...

  reduce<U>(
    callbackfn: (
      previousValue: U,
      currentValue: T,
      currentIndex: number,
      array: T[]
    ) => U,
    initialValue?: U
  ): U;

  // ...
}

packages/typings/standard/index.d.ts#L286-L294
possible solution would be to try super type of inferred type if original inferred type does not work (walking up to the chain until reaching root type or finding something that works)

@thecotne, Yes, the problem is in the type inference and unification algorithm. I'm thinking about the solution.


Unable to read clients from configuration when a client has one or more claims.

If I load clients from asp.net core configuration file, and the client has one or more claims, the configuration binder throws an exception because it cannot create instances of type Claim. This is not the expected behavior, but anyway is a Configuration Binder limitation, which cannot create instances of classes which does not have a public parameterless constructor.
At the moment we cannot expand Configuration Binder because it does not support custom deserializers.
Maybe the property Claims of class Client can be replaced with a collection of a custom class type as item, with parameterless constructor. Alternatively we can use a bridge class to load from configuration, or we can add a phantom (code editor hidden) property used to load configuration from its setter to the real property.
To reporoduce the exception:

Add this snippet to appsettings.json:

  "identityServer": {
    "clients": [
      {
        "clientId": "client1",
        "clientName": "Client 1",
        "allowedScopes": [ "openid", "offline_access" ],
        "claims": [
          {
            "type": "role",
            "value": "somerole"
          }
        ]
      }
    ]
  }

Configure the indentity server to load clients in memory from configuration:
services.AddIdentityServer().AddInMemoryClients(_configuration.GetSection("identityServer:clients")

Try to use the clients from a mvc controller (obtain them from constructor, invoking DI/Configuration logic):

public class HomeController : Controller {
  IEnumerable<Client> _clients;
  public HomeController(IEnumerable<Client> clients) {
    _clients = clients;
  }

  public IActionResult Index() {
    return View();
  }
}

No logs for this bug because the project crashes at startup.

I had a brief look - I cannot re-produce the crash. But the claims are not getting properly bound. IOW the claims list is empty.
This seems to indicate that you can use a type descriptor
https://stackoverflow.com/questions/42007114/custom-configuration-binder-for-property
But I didn't get it to work in the limited time I had.
Do you want to give that a try? Or suggest a different non-breaking solution (maybe as a PR as a basis for discussion).

any update? @totalprogrammi

Sorry, for now i have no time, maybe at January.

Try adding new converter for claims:
class ClaimConverter : JsonConverter
    {
        public override bool CanConvert(Type objectType)
        {
            return objectType == typeof(Claim);
        }

        public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
        {
            JObject jo = JObject.Load(reader);
            string type = jo.GetValue("type", StringComparison.OrdinalIgnoreCase)?.Value<string>();
            string value = jo.GetValue("value", StringComparison.OrdinalIgnoreCase)?.Value<string>();
            string valueType = jo.GetValue("valueType", StringComparison.OrdinalIgnoreCase)?.Value<string>();
            string issuer = jo.GetValue("issuer", StringComparison.OrdinalIgnoreCase)?.Value<string>();
            string originalIssuer = jo.GetValue("originalIssuer", StringComparison.OrdinalIgnoreCase)?.Value<string>();
            return new Claim(type, value, valueType, issuer, originalIssuer);
        }

        public override bool CanWrite
        {
            get { return false; }
        }

        public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer)
        {
            throw new NotImplementedException();
        }
    }

you can either use it directly or put it default settings:
JsonConvert.DefaultSettings = () => new JsonSerializerSettings
            {
                Converters = new List<JsonConverter> { new ClaimConverter() }
            };

Have you actually tried that? It needs to plug into the asp.net core config system...

I've tried your solution, but without success.
I think it cannot work because the configuration mechanism of Microsoft.Extensions.Configuration does not use json to map configuration. In other words, Newtonsoft.Json is used by Microsoft.Extensions.Configuration only to read data into key-value pairs, but not for binding data to objects.
I'm trying TypeConverter..
P.S. my nickname is changed from totalprogrammi to frabe1579

I've downloaded the source code of Microsoft.Extensions.Configuration.Binder, added a unit test to debug Claim serialization, and I came to the conclusion than the binder does not support any mechanism than public parameterless constructor for custom types. TypeConverter is used only for single values, so it cannot be used for complex types. There is a silent exception catch in the method that tries to construct the custom object (the Claim), and this is the reason that no exception is raised (the error is ignored and the item is not added to the collection).
At this point, i think that the only solution is to rewrite the configuration loading using POCO classes mapped to model classes (maybe using Automapper), but this require doubling the code for the model.
There is an open issue for Immutable types, that maybe will resolve our problem with .net core 3.0:
#https://github.com/aspnet/Extensions/issues/608, but for now seems no code change is present for that.
Personally, i've resolved using Entity Framework, so for me this is no more a direct problem.
This is the line where the exception is catched and ignored, and this is the method that throws that instance
This is the simple test used:
public class ClaimBindingTest
{
    [Fact]
    public void ReadClaim()
    {
        var configuration = new ConfigurationBuilder()
            .AddJsonFile("appsettings.json")
            .Build();
        var cc = new ConfigClass();
        configuration.GetSection("config").Bind(cc);

        Assert.NotNull(cc.Claims);
        Assert.NotEmpty(cc.Claims);
        Assert.Equal(2, cc.Claims.Count);
    }

    class ConfigClass
    {
        public IList<Claim> Claims { get; set; }
    }
}

And this is the appsettings.json file
{   "config": {     "claims": [       {         "type": "sub",         "value": "abcd"       },       {         "type": "iss",         "value": "1234"       }     ]   } }

That's what I thought. We cannot easily do that right now because it would be a breaking change.
Did you open an issue with Microsoft?

I've added a comment #https://github.com/aspnet/Extensions/issues/608#issuecomment-487143413, with a back-reference, on an already open issue.
There are some references to IdentityServer4 by Microsoft, like this so maybe there are other people potentially involved in this issue, but i don't know how to contact them (and if they can help us).

Any update on this?

No. We need to move away from the Claims type for config - it's very serialization unfriendly.

Will introduce a ClientClaim class with a type/value property

PR merged and thus done.


Preventing Animation Model Rotation

When using PlayerAnimatorAPI to play animations, I want to ensure that the animated model does not rotate with the player's view.
How can I achieve this? (in 1.21 neoforge)
Does PlayerAnimatorAPI support this feature? If not, would it be possible to consider adding it?
I have tried subscribing to the 'RendererPlayerEvent.Pre' event and making some adjustments, but the results were not satisfactory. Although the animation plays, the body position animation no longer functions correctly.
I look forward to your response. (I am using translation software.)

What I did was like this
@EventBusSubscriber(modid = HugMe.MODID, value = Dist.CLIENT, bus = EventBusSubscriber.Bus.GAME)
public class RenderPlayerEventHandler {
    private static final Minecraft client = Minecraft.getInstance();
    private static final Map<UUID, UUID> playerLockMap = new HashMap<>();
    private static final Map<UUID, Boolean> playerLockState = new HashMap<>();

    @SubscribeEvent
    public static void onRenderPlayer(RenderPlayerEvent.Pre event) {
        Player player = event.getEntity();
        PlayerRenderer renderer = event.getRenderer();
        float partialTicks = event.getPartialTick();
        PoseStack poseStack = event.getPoseStack();
        MultiBufferSource buffer = event.getMultiBufferSource();
        int packedLight = event.getPackedLight();

        if (player instanceof AbstractClientPlayer clientPlayer) {
            UUID playerId = player.getUUID();
            if (playerLockMap.containsKey(playerId)) {
                UUID targetPlayerUUID = playerLockMap.get(playerId);
                if (targetPlayerUUID == null) return;
                if (client.level == null) return;
                AbstractClientPlayer targetPlayer = (AbstractClientPlayer) client.level.getPlayerByUUID(targetPlayerUUID);
                if (targetPlayer == null) return;
                float targetYaw = calculateYawToTarget(clientPlayer, targetPlayer);

                poseStack.pushPose();

                poseStack.mulPose(Axis.XP.rotationDegrees(180.0F));
                poseStack.translate(0, -1.5, 0);
                poseStack.mulPose(new org.joml.Quaternionf().rotationY((float) Math.toRadians(targetYaw)));
                renderPlayerModel(renderer, clientPlayer, partialTicks, poseStack, buffer, packedLight);

                poseStack.popPose();
                event.setCanceled(true);
            }
        }
    }

    private static void renderPlayerModel(PlayerRenderer renderer, AbstractClientPlayer entity, float partialTicks, PoseStack poseStack, MultiBufferSource buffer, int packedLight) {
        PlayerModel<AbstractClientPlayer> model = renderer.getModel();
        model.young = entity.isBaby();

        if (entity == client.player && client.options.getCameraType() == CameraType.FIRST_PERSON) {
            model.head.visible = false;
        }

        model.setupAnim(entity, 0.0F, 0.0F, 0.0F, 0.0F, 0.0F);
        RenderType renderType = RenderType.entityCutoutNoCull(renderer.getTextureLocation(entity));

        model.renderToBuffer(poseStack, buffer.getBuffer(renderType), packedLight, OverlayTexture.NO_OVERLAY, -1);
    }

    private static float calculateYawToTarget(AbstractClientPlayer fromPlayer, AbstractClientPlayer toPlayer) {
        double deltaX = toPlayer.getX() - fromPlayer.getX();
        double deltaZ = toPlayer.getZ() - fromPlayer.getZ();
        return (float) Math.toDegrees(Math.atan2(deltaZ, deltaX)) - 90.0F;
    }

    public static void lockPlayers(AbstractClientPlayer player1, AbstractClientPlayer player2) {
        playerLockMap.put(player1.getUUID(), player2.getUUID());
        playerLockMap.put(player2.getUUID(), player1.getUUID());
        playerLockState.put(player1.getUUID(), true);
        playerLockState.put(player2.getUUID(), true);
        HugMe.LOGGER.debug("Locked " + player1.getName().getString() + " and " + player2.getName().getString());
    }

    public static void unlockPlayers(AbstractClientPlayer player1, AbstractClientPlayer player2) {
        playerLockMap.remove(player1.getUUID());
        playerLockMap.remove(player2.getUUID());
        playerLockState.remove(player1.getUUID());
        playerLockState.remove(player2.getUUID());
        HugMe.LOGGER.debug("Unlocked " + player1.getName().getString() + " and " + player2.getName().getString());
    }

    public static boolean isPlayerLocked(AbstractClientPlayer player) {
        return playerLockState.getOrDefault(player.getUUID(), false);
    }
}


dart2js crashes when compiling deep_nesting2_negative_test.dart

FAILED: dart2js-d8-checked release_ia32 language/deep_nesting2_negative_test
Expected: Pass
Actual: Crash
Unexpected compile-time error.
CommandOutput[dart2js]:
stdout:
tests/language/deep_nesting2_negative_test.dart:260:15:
Error: Stack overflow
if (x == 0) {
^
tests/language/deep_nesting2_negative_test.dart:9:1:
Internal Error: The compiler crashed when compiling this element.
main() {
^^^^
The compiler is broken.
....

Note: this crash only happens when dart2js rungs in checked mode.

Marked test as crashing.
https://codereview.chromium.org/2668983002/


Unable to install mysql on ubuntu 14.04

Cookbook version - 6.1.3
Chef-client version- 12.9.38
Platform Details - Ubuntu 14.04 running on Microsoft azure
Scenario:
I am trying t0 install Mysql 5.5 as one of the requirements for sonarqube
Steps to Reproduce: My recipe
``
mysql_service 'default' do
port '3306'
version '5.5'
initial_root_password 'root'
end
mysql_service 'default' do
action :start
end
``
Expected Result:
Installation of Mysql with default root user.
Actual Result:
``
* bash[default :create initial records] action run
  ================================================================================
  Error executing action `run` on resource 'bash[default :create initial records]'
  ================================================================================

  Mixlib::ShellOut::ShellCommandFailed
  ------------------------------------
  Expected process to exit with [0, 1, 2], but received '127'
  ---- Begin output of "bash"  "/tmp/chef-script20160419-2339-qutf92" ----
  STDOUT:
  STDERR: /tmp/chef-script20160419-2339-qutf92: line 18: warning: here-document at line 6 delimited by end-of-file (wanted `EOSQL')
  cat: /run/mysql-default/mysqld.pid: No such file or directory
  /tmp/chef-script20160419-2339-qutf92: line 6: DELETE: command not found
  ---- End output of "bash"  "/tmp/chef-script20160419-2339-qutf92" ----
  Ran "bash"  "/tmp/chef-script20160419-2339-qutf92" returned 127

  Resource Declaration:
  ---------------------
  # In /var/chef/cache/cookbooks/mysql/libraries/provider_mysql_service_base.rb

  145:         bash "#{new_resource.name} :create initial records" do
  146:           code init_records_script
  147:           returns [0, 1, 2] # facepalm
  148:           not_if "/usr/bin/test -f #{parsed_data_dir}/mysql/user.frm"
  149:           action :run
  150:         end
  151:       end

  Compiled Resource:
  ------------------
  # Declared in /var/chef/cache/cookbooks/mysql/libraries/provider_mysql_service_base.rb:145:in `block in <class:MysqlServiceBase>'

  bash("default :create initial records") do
    action [:run]
    retries 0
    retry_delay 2
    default_guard_interpreter :default
    command "default :create initial records"
    backup 5
    returns [0, 1, 2]
    code "        set -e\n        rm -rf /tmp/mysql-default\n        mkdir /tmp/mysql-default\n\n        cat > /tmp/

mysql-default/my.sql \n\t\t<<-EOSQL DELETE FROM mysql.user ; \n\t\tCREATE USER 'root'@'%' IDENTIFIED BY 'root' ; \n\t\tG
RANT ALL ON . TO 'root'@'%' WITH GRANT OPTION ; \n\t\tFLUSH PRIVILEGES; DROP DATABASE IF EXISTS test ; \n\t\tEOSQL \n
n       mysql_install_db --defaults-file=/etc/mysql-default/my.cnf --datadir=/var/lib/mysql-default\n       /usr/bin/mys
qld_safe --defaults-file=/etc/mysql-default/my.cnf --init-file=/tmp/mysql-default/my.sql &\n\n       while [ ! -f /run/m
ysql-default/mysqld.pid ] ; do sleep 1 ; done\n       kill cat /run/mysql-default/mysqld.pid\n       while [ -f /run/m
ysql-default/mysqld.pid ] ; do sleep 1 ; done\n       rm -rf /tmp/mysql-default\n"
interpreter "bash"
declared_type :bash
cookbook_name "mysql"
not_if "/usr/bin/test -f /var/lib/mysql-default/mysql/user.frm"
end
  Platform:
  ---------
  x86_64-linux

================================================================================
Error executing action `create` on resource 'mysql_service[default]'
================================================================================

Mixlib::ShellOut::ShellCommandFailed
------------------------------------
bash[default :create initial records] (/var/chef/cache/cookbooks/mysql/libraries/provider_mysql_service_base.rb line

had an error: Mixlib::ShellOut::ShellCommandFailed: Expected process to exit with [0, 1, 2], but received '127'
---- Begin output of "bash"  "/tmp/chef-script20160419-2339-qutf92" ----
STDOUT:
STDERR: /tmp/chef-script20160419-2339-qutf92: line 18: warning: here-document at line 6 delimited by end-of-file (wanted `EOSQL')
cat: /run/mysql-default/mysqld.pid: No such file or directory
/tmp/chef-script20160419-2339-qutf92: line 6: DELETE: command not found
---- End output of "bash"  "/tmp/chef-script20160419-2339-qutf92" ----
Ran "bash"  "/tmp/chef-script20160419-2339-qutf92" returned 127

Resource Declaration:
---------------------
# In /var/chef/cache/cookbooks/mysql/recipes/default.rb

  1: mysql_service 'default' do
  2:   port '3306'
  3:   version '5.5'
  4:   initial_root_password 'root'
  5:   end
  6:

Compiled Resource:
------------------
# Declared in /var/chef/cache/cookbooks/mysql/recipes/default.rb:1:in `from_file'

mysql_service("default") do
  action [:create]
  updated true
  updated_by_last_action true
  retries 0
  retry_delay 2
  default_guard_interpreter :default
  declared_type :mysql_service
  cookbook_name "mysql"
  recipe_name "default"
  port "3306"
  version "5.5"
  initial_root_password "root"
  instance "default"
  run_user "mysql"
  run_group "mysql"
  charset "utf8"
end

Platform:
---------
x86_64-linux

Running handlers:
[2016-04-19T14:21:38+00:00] ERROR: Running exception handlers
[2016-04-19T14:21:38+00:00] ERROR: Creating JSON exception report

Chef::Handler::JsonFile
Running handlers complete
[2016-04-19T14:21:38+00:00] ERROR: Exception handlers complete
Chef Client failed. 37 resources updated in 09 minutes 23 seconds
[2016-04-19T14:21:39+00:00] FATAL: Stacktrace dumped to /var/chef/cache/chef-stacktrace.out
[2016-04-19T14:21:39+00:00] FATAL: Please provide the contents of the stacktrace.out file if you file a bug report
[2016-04-19T14:21:39+00:00] ERROR: mysql_service[default] (mysql::default line 1) had an error: Mixlib::ShellOut::ShellC
ommandFailed: bash[default :create initial records] (/var/chef/cache/cookbooks/mysql/libraries/provider_mysql_service_ba
se.rb line 145) had an error: Mixlib::ShellOut::ShellCommandFailed: Expected process to exit with [0, 1, 2], but receive
d '127'
---- Begin output of "bash"  "/tmp/chef-script20160419-2339-qutf92" ----
STDOUT:
STDERR: /tmp/chef-script20160419-2339-qutf92: line 18: warning: here-document at line 6 delimited by end-of-file (wanted
`EOSQL')
cat: /run/mysql-default/mysqld.pid: No such file or directory
/tmp/chef-script20160419-2339-qutf92: line 6: DELETE: command not found
---- End output of "bash"  "/tmp/chef-script20160419-2339-qutf92" ----
Ran "bash"  "/tmp/chef-script20160419-2339-qutf92" returned 127
[2016-04-19T14:21:39+00:00] FATAL: Chef::Exceptions::ChildConvergeError: Chef run process exited unsuccessfully (exit co
de 1)
``

There's been a lot of changes to the version logic.  Can you give this a try on the 7.X release and let me know if you're still having issues.  I'm going to close it for now, but feel free to open it back up.


clarified comment for author.stackoverflow value in _config.yml

Initial Situation

The author.stackoverflow variable was commentet with # http://stackoverflow.com/users/123456/username, which led me to the conclusion that I should add the whole url as value.
The stackoverflow combination of numeric id / username isn't self-explanatory.

Proposed Change
Change the comment to explicit state the requested value "123456/username" and append the whole demo url to show where the needed value can be found.

Thanks. Merged into develop and will push with the next theme release.
ref: https://github.com/mmistakes/minimal-mistakes/commit/d3ac1123da4a2e6b2b75d8de0d46a36c57bda576


How to pre-process the original graph .npz data?

From the filenames contained in the data directory, I used the following statement to process the original citeseer.npz file (from https://github.com/abojchevski/graph2gauss)
g = utils.load_dataset(str(Path('data', 'citeseer.npz')))
A, X, z = g['A'], g['X'], g['z']

utils.save_sp('data/', 'A', A)
utils.save_sp('data/', 'X', X)
np.save(Path('data', 'z.npy'), z)

train_ones, val_ones, val_zeros, test_ones, test_zeros = \
    utils.train_val_test_split_adjacency(A, p_val=0.1, p_test=0.1)
np.savez(Path('data', 'data_arrays_link.npz'), train_ones,
         val_ones, val_zeros, test_ones, test_zeros)

But the resulting file size is different from the one you provided, is there any other pre-processing operation I can do? Or did I make an error in my operation?

I found that I may have used the wrong raw graph file, and now I can generate the same A and X file. But how do I generate the corresponding data_arrays_link file, because if I call the train_val_test_split_adjacency function directly, it will be broken due to the assert not np.any(A.sum(0).A1 + A.sum(1).A1 == 0) # no dangling nodes . And I had to comment this statement and use every_node=False to run the function.
However, this processing of the dataset will greatly reduce the effectiveness of the experiment, and the results for CiteSeer will be reduced to  AUC: 0.7552, AP: 0.7946

Hi,
I cannot find the preprocess file right now because it was a work about 2 years ago, and most of my current work uses the edge list like Pytorch Geometric directly. I will try to find the file, but I am not sure if I have deleted it while cleaning the server.
Also, using another preprocessing method doesn't matter, because the input file and matrices are really simple.
Take A_sp.npz as an example,  it simply contains three sparse matrices, which are the adjacency matrix (A), feature matrix (X) and the label information (z) (this is not used in this work). Moreover, it is very easy to convert an edge list to an adjacency matrix if you use another dataset.
For your codes, I think the reason is that the input node features are incorrect if you use the get_X() in the utils.py. Actually, this is for another extension work. I'm sorry that I didn't have the time to clean the codes. You can use the node features provided by the original dataset directly. I will try to add more comments and clean the codes in the future.
Hope this can help.
Cheers,
Yu

Thank you very much for your reply. After my comparison, the preprocessing file I wrote gives me the same A and X as the corresponding file provided. The main problem I find with the drop in experimental results is that val_zeros and test_zeros are somewhat different from what is provided.
The generation of a zeros collection in the train_val_test_split_adjacency function is different from that provided by G2G.

DEAL code and G2G code

Other nodes that can be reached by triple-hopping between the nodes used by zeros in DEAL, I think there may be a mistake here. After I replaced this code with the original G2G code, the results returned to normal.

Hi Nick,
Glad to hear that the codes work. Thanks for your information.
The train_val_test_split_adjacency function in the released reversion may be changed due to the extension work I mentioned before.
Cheers,
Yu

@gu18168  Hi Nick!
Can you help me on preprocessing my own graph, to use with this model?
Any help would be appreciated.

@FatemeMirzaeii Unfortunately, I can't find the code I had at the time because it's been a bit long. I hope you can find a clue to the processing in the comment.

@FatemeMirzaeii Unfortunately, I can't find the code I had at the time because it's been a bit long. I hope you can find a clue to the processing in the comment.

Thanks for your quick reply!
I don't need the exact code, because absolutely it would be different in my case,
I have a raw graph in networkx format. If you can remember and explain to me what input files represent, I would be very grateful. for example dist data, data_array_links or nodes_keep, ind_train and etc.


Event sourcing

complete event sourcing

Coverage decreased (-6.8%) to 89.901% when pulling 84e94646c56b09bb38bff47ed4d04912e83ca73f on event-sourcing into 8d127721c9fd0b7dee6e20879fb69dbcde43458b on master.

Coverage decreased (-6.2%) to 90.515% when pulling 303a5983156396134de232990e171cdec34df7d0 on event-sourcing into 8d127721c9fd0b7dee6e20879fb69dbcde43458b on master.

Coverage decreased (-3.7%) to 92.979% when pulling 5692296d3801d10e09384c898612e93337202352 on event-sourcing into 8d127721c9fd0b7dee6e20879fb69dbcde43458b on master.

Coverage decreased (-3.7%) to 92.979% when pulling 47896e5c3b4837c5b931d8080e4678553dbc540f on event-sourcing into 8d127721c9fd0b7dee6e20879fb69dbcde43458b on master.

Coverage decreased (-3.7%) to 92.979% when pulling d88b0820f078eb1ce18b8c985559f8b352bc846e on event-sourcing into 8d127721c9fd0b7dee6e20879fb69dbcde43458b on master.

Coverage decreased (-3.7%) to 92.979% when pulling 21a6b017d348d88e6e752e905991795bf9d6a8fd on event-sourcing into 8d127721c9fd0b7dee6e20879fb69dbcde43458b on master.

Coverage decreased (-3.7%) to 92.979% when pulling 9538fa4e4d101360076fd6af517ec0e7961e3bae on event-sourcing into 8d127721c9fd0b7dee6e20879fb69dbcde43458b on master.

Coverage decreased (-3.7%) to 92.979% when pulling 4ef6d7271c44a62af1a2f0ea21d88ac68d2f37e1 on event-sourcing into 8d127721c9fd0b7dee6e20879fb69dbcde43458b on master.

Coverage decreased (-3.05%) to 93.612% when pulling c41550b3a95f2fc8a1f3aa7efe384ce504ef529d on event-sourcing into 8d127721c9fd0b7dee6e20879fb69dbcde43458b on master.

Coverage decreased (-3.04%) to 93.626% when pulling 64b6853a9beaf43fbfdb7de646168e9fc57803a2 on event-sourcing into 8d127721c9fd0b7dee6e20879fb69dbcde43458b on master.

Coverage decreased (-3.03%) to 93.64% when pulling 25f1cf0baf6ccbd72ab557a97347ff61931b0145 on event-sourcing into 8d127721c9fd0b7dee6e20879fb69dbcde43458b on master.


Rails/HttpPositionalArguments fixes

I used this cop today to upgrade a Rails application to Rails 5 and it proved to be very useful. However, two deprecation warnings went unnoticed. This PR should fix both of them.

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Used the same coding conventions as the rest of the project.
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] All tests are passing.
[x] The new code doesn't generate RuboCop offenses.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

There's some unrelated documentation changes that come from updating the cops documentation. I wonder why that gets out of sync.

👍 Thanks!

👍 Thanks!

Thanks to you! :)

Thanks to you! :)


deploy: revert deploy template changes for release-3.5

This commit revert the template changes brought in for release-3.5
and making it refer to canary.
Signed-off-by: Humble Chirammal<EMAIL_ADDRESS>

Looks like released helm charts are still pointing to canary version  https://github.com/ceph/ceph-csi/blob/43182b39fee7bb1a6bf408b0be3cc09faa572cd8/charts/ceph-csi-rbd/values.yaml#L111-L113

Looks like released helm charts are still pointing to canary version
https://github.com/ceph/ceph-csi/blob/43182b39fee7bb1a6bf408b0be3cc09faa572cd8/charts/ceph-csi-rbd/values.yaml#L111-L113

Looks like , that commit got dropped somehow, tagging it now.

changes are done for 3.5.0 in helm charts #2784 reverting is missing in this PR. make 3.5.1 release and then revert the changes?

yeah, have to release 3.5.1 and then revert or get this PR refereshed on top of 3.5.1

@Madhu-1 as discussed, considering the chart is auto refreshed, this pr refreshed accordingly and good to go. ptal.

helm chart changes are still missing?

@Madhu-1 forgot to push :) , should be there now.. thanks.. ptal.

changes are not done in minikube.sh https://github.com/ceph/ceph-csi/blob/release-v3.5/scripts/minikube.sh#L286-L287

ptal.

@Mergifyio rebase

@Mergifyio refresh

/retest ci/centos/mini-e2e-helm/k8s-1.21

/retest ci/centos/mini-e2e/k8s-1.23

/retest ci/centos/mini-e2e/k8s-1.22

/retest ci/centos/mini-e2e/k8s-1.21

/retest ci/centos/mini-e2e-helm/k8s-1.23

ci/centos/mini-e2e-helm/k8s-1.22

/retest ci/centos/mini-e2e-helm/k8s-1.22


Missing path ParameterSetName on Id

Added Path as ParameterSetName to the id field to allow exporting specific file.

@jagger can you help me out with why i can't run these workflow tests?

@delineaKrehl can you assist here?

@MrM1y4g1 we will be merging these changes in and releasing it shortly.


Set: Implement toString and fromString methods

As seen in #2498, Set!T is formatted as an AA. This is both hard to read and extremely wasteful.
Now, Set is formatted as an array, using the updated toString and newly implemented fromString methods.
e.g. a Set!string such as "_set":{"Hello":true,"world":true}
will now be formatted as ["Hello", "world"].
Fixes #2499

Rebased to the latest commit.


Support useDefineForClassFields configurable

I'm building a library for automatic modeling, and a feature needs to turn off useDefineForClassFields option. I found that this configuration cannot be configured in this plugin. Can I provide a configuration that is turned off?
I saw your reply, but I need to provide this library for others to use, so I can't patch this line of code in every development environment.

I'm not sure to understand your need, are you using Vite in library mode? In that case patching in your workflow and publishing the compiled code should work.
If your library requires users to use this outdated spec instead of the new one, I think my point stands that this is not something that should be too easy to do nowdays.

@ArnaudBarre
In fact, my need is to read the decorator information of the prototype of the subclass in the parent class, and then model the attribute in the parent class in advance according to special rules. But if useDefineForClassFields is turned on, the attribute definition in the subclass will assign me to the coverage in the parent class. So I have been looking for a way to turn off useDefineForClassFields before. In fact, I have found another solution. Just use the declaration in the subclass attribute. In this way, the attribute declaration will be wiped out during compile, and then coverage will not occur. Like this.
Before compile
class A {
  normalAttr: string
  declare declareAttr: string // Like this.
}

After compile
class A {
  constructor() {
    this.normalAttr = undefined // useDefineForClassFields cause normalAttr to still exist
    // declare cause declareAttr to be wiped
  }
}


Added api.partner.microsoft.com scope

Maybe I'm missing a curtial part of the documentation.
But I didn't find any reference how to setup the authentication with app source.
There were 2 issues I had.

The scope to use for the authentication
The way to authorize an app registration against the partner center.

This change helps with 1. addtionally it might be helpful to mention it here as well https://github.com/microsoft/AL-Go/blob/main/Scenarios/settings.md#appsource-specific-advanced-settings
If you tell me where to document the 2. issue I will do that.

Ok... I guess I was missing the right information.
Is there a rss feed for your blog?

my blog is wordpress - I think https://freddysblog.com/feed/ would work.
Based on this error - I think I will also test whether scopes is correct in New-AlGoAppSourceContext - and give an error if not.

Thanks the feed is great.
Wouldn't it be better to throw that error before the actual request? Or maybe do the request and show a warning that the scope might be wrong if you get an 401 response. Because the way you describe it in the AppSourceContext Setting I think lots of people will just write the context manually. (that's what I did at first.)

You mean adding a check to the invoke-IngestionAPIRestMethod function - good idea.


fix data race on MockLocalAdmissionController

What problem does this PR solve?
Issue Number: close #7965
Problem Summary:
What is changed and how it works?
Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-all-tests

/run-all-tests

/run-integration-test

/approve

/hold

/hold cancel

/approve

/run-unit-test

/run-integration-test

/run-integration-test


Fix race conditions in PhysicsServers wrappers

When Physics runs in a separated thread, a race condition may occur in GodotCollisionObjectXD::_update_shapes(), causing two nodes of the same shape to be created in BVH tree.
This PR solves this by adding PhysicsServerXDWrapMT::physics_server_xd->body_test_motion() in the PhysicsServerXDWrapMT::command_queue, avoiding _update_shapes() to run in the main thread.
Fixes #70491

I agree the current code is unsafe.
Now, I have a couple of thoughts:

I don't get why keeping limiting caller threads to the main one, now the method is totally thread-safe.
I wonder why these methods were excluded from being queued in the first place. Maybe the forced sync was too big an enemy of the intended performance gains of threaded physics?

I don't get why keeping limiting caller threads to the main one, now the method is totally thread-safe.

Good question, I've tracked the origin of  ERR_FAIL_COND_V(main_thread != Thread::get_caller_id(), false); and it is there since the creation of the file (9df77d276593ef7).
Maybe this is to ensure the function is only called by the gdscript.

I wonder why these methods were excluded from being queued in the first place. Maybe the forced sync was too big an enemy of the intended performance gains of threaded physics?

My guess is the author of 9df77d276593ef7 didn't manage to make FUNC3R()  call   ERR_FAIL_COND_V(main_thread != Thread::get_caller_id(), false);.
bool body_test_motion(RID p_body, const MotionParameters &p_parameters, MotionResult *r_result = nullptr) override {
	ERR_FAIL_COND_V(main_thread != Thread::get_caller_id(), false);
	return physics_server_2d->body_test_motion(p_body, p_parameters, r_result);
}

My guess is the author of 9df77d2 didn't manage to make FUNC3R() call ERR_FAIL_COND_V(main_thread != Thread::get_caller_id(), false);.

I'm not very fond of that hypothesis. First of all, the author is @reduz, to whom I'm assume enough skills to do so. Second, that check would be pointless with FUNC3R(), since, as discussed above, the call would be thread-safe.
That said, I can't think of any reasonable alternative approach to fixing this issue that what this PR does. However, the thread check (i.e., all the WRITE_ACTION stuff) is not needed.

@RandomShaper You promised to approve on your part? 🙃 Is everything like you think it should be now?

This may not be safe to call outside the main physics thread (or main thread). I'm not familiar with the code but it looks as though it calls a query on the BVH, which by default is not compiled thread safe (as far as I remember in master).
This probably needs double checking by a physics guy.
The race condition is that if it calls a query on the BVH while another thread is changing the BVH, it is undefined behaviour. There may also be race conditions outside BVH.

This needs a proper fix, as this this function is eventually intended to work multithreaded, hence this won't do.
Need to discuss with other physics maintainers how to properly implement this functionality.

I had a similar issue and tested this fix, which did stop the crashing, but it absolutely killed performance.
I ended up restructuring the system to not rely on multi threaded physics but this change seemed to have a massive impact which shouldn't be overlooked.
Sorry I don't have a repro or numbers on hand, I can dig through Git if anyone needs.

New thoughts:

Should maybe these functions have the same constraint as body_get_direct_state()?, that is, make it only usable from physics process. That way, the fact that the command queue has to be flushed is known.
In case we want to keep the fast path of running it without a flush, we could do the following (but is that what we want?):

A) In safe threading mode, just run the query, pretty much as it's happening with the current code. (By the way, I have a PR I'm working on that will remove the queue for single-safe threading.)
B) In separate thread mode, add some mechanism to stop the thread, run the query and re-start the thread.

Not directly related, but  I'm wondering if MotionParameters should be RefCounted to avoid potentially expensive copies.


Update to AmberTools 19.10 (AmberTools 19 patch level 10)

AmberTools 19 recently released patch level 10, which adds IOD set for TIP3P water from Li et al., JPCB, 2015, 119, 883.
This PR bumps the version build to 19.10 (AmberTools 19 patch level 10).

Checklist

[x] Used a fork of the feedstock to propose changes
(N/A) Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Thanks @jchodera!


KeyVault deployment issue due to the BaseResourceName value is longer than 24 characters.

Hi Team,
Can you please advise, which line in the Deploy.PS1 file I must edit to hardcode the KeyVaultname to mitigate the 24 characters limitations?
I have already edited the $keyVaultName variable in the 3x lines to be:
$keyVaultName = 'cc-keyvault'
However, when I retry to execute the .\deploy.ps1 file, I always stuck in the below error:
ERROR: {
    "status": "Failed",
    "error": {
        "code": "DeploymentFailed",
        "target": "/subscriptions/GUID/resourceGroups/CompanyCommunicator-RG/providers/Microsoft.Resources/deployments/azuredeploy",
        "message": "At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-deployment-operations for usage details.",
        "details": [
            {
                "code": "VaultNameNotValid",
                "message": "The vault name 'mycompanynamecommunicatorvault' is invalid. A vault's name must be between 3-24 alphanumeric characters. The name must begin with a letter, end with a letter or digit, and not contain consecutive hyphens. Follow this link for more information: https://go.microsoft.com/fwlink/?linkid=2147742"
            }
        ]
    }
}

Your help is greatly appreciated.
Thank you.

Hi @albert-widjaja,
Thanks for raising the query.
Could you please confirm us on the base resource name length. If it is less than 24 characters, then here is a possible resolution.
While doing the "Deploy to Azure subscription" step i.e., 4th step mentioned in GitHub deployment guide, please do the following -
•	Click on Edit Template
•	Go to line No: 305 having KeyvaultName as a parameter and replace the highlighted line with the below (refer to the screenshot)
"keyvaultName" : "[variables('botAppName')]"

•	Validate the template
•	Click on “Review & Create”
Once the deployment is successful, then you can proceed with remaining steps as mentioned in the migration guide.
Please let us know if it helped in the solving the issue.

@gsv022 ,
yes, that works and solves the issue. thank you for the reply.

Closing out the issue as the query has been responded


Greenkeeper/keycloak connect 4.1.0

Pull Request Test Coverage Report for Build 157

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.308%

Totals

Change from base Build 156:
0.0%

Covered Lines:
21

Relevant Lines:
22

💛  - Coveralls


Menu logo

The logo is so nice and cute.
It is a good idea to include it in menu-left so that many user can spot our logo. GOOD!


Failed to update from 0.10.2 to 0.10.3 on Windows 10

Attempting to update code today gave me the following error during the installer run.
---------------------------
Error
---------------------------
C:\Program Files (x86)\Microsoft VS Code\code.exe

An error occurred while trying to replace the existing file:

DeleteFile failed; code 5.

Access is denied.

Click Retry to try again, Ignore to skip this file (not recommended), or Abort to cancel installation.
---------------------------
Abort   Retry   Ignore
---------------------------

My version of code before upgrade.

Version 0.10.2
Commit 7cc0c602a2b802b09a3f56b68a1a61ee9e8f0066
Date 2015-11-25T08:42:02.138Z
Shell 0.34.1
Renderer 45.0.2454.85
Node 4.1.1

Well a good old restart of Windows seems to have at least worked around the issue I was having. Not ideal but after the restart I was able to successfully apply the update when prompted.


ci.tensorflow.org is now deprecated.  Where can I get nightly builds for pi-zero AND regular pis when I only have a pi3?

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):Raspbian Stretch 9
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:Raspberry Pi 3 Model B
TensorFlow installed from (source or binary):latest pi-zero nightly binary that was on jenkins.
TensorFlow version (use command below):1.9.0 (ultimately not relevant so this should be good enough)
Python version:3.5.3
Bazel version (if compiling from source):N/A
GCC/Compiler version (if compiling from source):N/A
CUDA/cuDNN version:N/A
GPU model and memory:VideoCore IV
Exact command to reproduce:
pip3 install tf-nightly

Describe the problem
Describe the problem clearly here. Be sure to convey here why it's a bug in TensorFlow or a feature request.
Now, that ci.tensorflow.org is gone.  I'm struggling to find an easy way to view changelogs between nightly builds AND download both pi-zero and regular raspberry pi nightly builds.  The reason why this is useful is because recently #21198 armv7 optimizations interferred with the tflite interpreter.  The current most practical work around was to go to ci.tensorflow.org and grab the pi-zero binary instead of the default one you get when installing tf-nightly or tensorflow on the raspberry pi.  I can see how this wouldn't be a problem for other tensorflow versions that only have one binary that works for only that specific machine.  I understand that you can use the 2.7 tensorflow vs 3.n tensorflow on other machines, but those you can do pip install tensorflow or pip3 install tensorflow.  This isn't possible with the raspberry pi as far as I can tell, or at least it's not documented clearly anywhere that I can.  Furthermore, it was great being able to roll back a couple of days and just download the .whl from yesterday with ease.  I saved many hours by just playing around with the available .whl's instead of having to cross-compile each one.
tl;dr I miss ci.tensorflow.org.  Please let me choose whether to install the tf nightly binaries of either pi-zero or regular raspberry-pi by choice since they both work on the raspberry pi.
Source code / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached. Try to provide a reproducible test case that is the bare minimum necessary to generate the problem.

This should be easy now with the latest effort to make raspberry pi officially supported?
Does this address your needs? (not sure if it makes it easy to get the nightly?)
https://medium.com/tensorflow/tensorflow-1-9-officially-supports-the-raspberry-pi-b91669b0aa0

No, there are two ways to compile for Raspberry Pi Non-zeroes (I'm talking 2,3,3b,3b+ etc):

tensorflow/tools/ci_build/ci_build.sh PI tensorflow/tools/ci_build/pi/build_raspberry_pi.sh PI_ONE
CI_DOCKER_EXTRA_PARAMS="-e CI_BUILD_PYTHON=python3 -e CROSSTOOL_PYTHON_INCLUDE_PATH=/usr/include/python3.4"
tensorflow/tools/ci_build/ci_build.sh PI-PYTHON3 tensorflow/tools/ci_build/pi/build_raspberry_pi.sh

These commands are taken directly from the official tensorflow on raspbian webpage.  The 2nd one has armv7 optimizations that currently break tflite's python interpreter_wrapper.  The 1st one which is what I believe ci.tensorflow.org used to compile for their nightly pi-zero build does not have those optimizations and thus can use tflite's interpreter.  Let's be honest, there really is no point to pip install tensorflow on the raspberry pi other than to use tflite.  Regular tensorflow is just way too bulky; you're better off just running it over wifi.
tl;dr: ci.tensorflow.org offered two DIFFERENT binaries for raspberry pis: one without optimizations and one with.  Currently, optimizations do not work.  I could grab no optimization version as a prebuilt binary off of ci.tensorflow.org.  ci.tensorflow.org is down.  pip and github don't give me clear ways to pick and choose the binaries I need.
ps.  I lost Jenkins once, I can't lose him a second time :crying_cat_face: my heart can't take it.

@gragundier if TF Lite related stuff compiled with optimization flags is what you need, I think something like
bazel build --config opt \
--local_resources 1024.0,0.5,0.5 \
--cxxopt=-mfpu=neon-vfpv4 \
--cxxopt=-ftree-vectorize \
--cxxopt=-funsafe-math-optimizations \
--cxxopt=-ftree-loop-vectorize \
--cxxopt=-fomit-frame-pointer \
//tensorflow/contrib/lite/tools/benchmark:benchmark_model

on your Pi devices works. Building the whole TensorFlow pip package on natively on Pi devices is painful. But building only TF Lite related code should be fine.

@gragundier I guess NO for TF Lite code. When building the pip package of TF natively on RPI 3, I found that some kernels, e.g., concat, use tf_kernel_library(), which takes --copt but not --cxxopt.

The changes are about to be pushed to github.
We will have these under the README in the repository root.

Hello, could anyone please provide the current URL for TF nightly builds, unrelated to raspberry PI?
Thank you!

Please see the README.md page at the repository root, as recommended above.

thank you!


Library update and another EJC/OpenJDK cast incompatibility

My turn to curse git - the libraries did not 'make it'
There is another EJC vs OpenJDK compiler incompatibility fix too

jline is/was used by the shell, I don't remember exactly how.

never mind, looks like the german students added that library, but then never used it

Hmm – I thought it was in use – for line editing, so I upgraded it  to the latest version in any case.
You are right, of course – it is not in use – serves me right for being so jar-happy
Dave.
From: Peter Lin @.>
Sent: 04 June 2021 13:59
To: woolfel/morendo @.>
Cc: DaveWoodman @.>; Author @.>
Subject: Re: [woolfel/morendo] Library update and another EJC/OpenJDK cast incompatibility (#5)
jline is/was used by the shell, I don't remember exactly how.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/woolfel/morendo/pull/5#issuecomment-854705544 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ADPI6UBGSEFH6V2YBOOXIT3TRDEYVANCNFSM46AODHTA .  https://github.com/notifications/beacon/ADPI6UAH4PGQAFEO3JJRSNLTRDEYVA5CNFSM46AODHTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGLY4LCA.gif


The result of CAM

Hi! Thank you for your wonderful project! Could you release the code for the CAM picture? I want to learn more about visualization.

Hi! Thank you for your wonderful project! Could you release the code for the CAM picture? I want to learn more about visualization.

Hi there,
We just do not want to keep repo too complicated. There are lots of resources on the internet about CAM or grad-CAM and you are able to get instructions there then use them with our models.

Thanks~


plugin_not_installed Ionic2 RC

Hi,
When I tried "ionic run android", I got the error below:
Native: tried calling AppVersion.getVersionNumber, but the AppVersion plugin is not installed. main.js:74377 Install the AppVersion plugin: 'ionic plugin add cordova-plugin-app-version' main.js:3602 EXCEPTION: Uncaught (in promise): plugin_not_installedErrorHandler.handleError @ main.js:3602 main.js:3607 ORIGINAL STACKTRACE:ErrorHandler.handleError @ main.js:3607 main.js:3608 Error: Uncaught (in promise): plugin_not_installed
I got the latest version of ionic-native and I installed the necessary plugin.
Is that an issues of Ionic2 RC or I was doing Something wrong?

Move to repo ionic-native 😉
Thanks

This issue was moved to driftyco/ionic-native#688

Hello all! Since this was an issue with Ionic Native and not the framework i have moved this issue to the ionic-native repo. Thanks!

@jgw96  hey, when i run my ionic app with ionic-view ap i get the error "plugin_not_installed".
(it's just a simple app of login to facebook).
when i run my app in emulator or chrome://inspect it works fine.. why is that?


#238: fix process argument logging

fixes process argument logging that I broke (1st arg omitted) in PR #238.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 58.907%

Files with Coverage Reduction
New Missed Lines
%

com/devonfw/tools/ide/os/MacOsHelper.java
1
76.71%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
4046

Relevant Lines:
6619

💛  - Coveralls


🪲 Bug Report - Some AFW ARG queries return inaccurate/incorrect results for VWAN secure hubs

Describe the bug
The following AFW ARG queries return results for VWAN associated AFWs in secure hubs, and should not:
https://azure.github.io/Azure-Proactive-Resiliency-Library-v2/azure-resources/Network/azureFirewalls/#deploy-azure-firewall-across-multiple-availability-zones
https://azure.github.io/Azure-Proactive-Resiliency-Library-v2/azure-resources/Network/azureFirewalls/#configure-ddos-protection-on-the-azure-firewall-vnet
To Reproduce
Steps to reproduce the behaviour:

Deploy VWAN and a VWAN secure hub with AFW
Run either wara-arg-runner.ps1 or wara_collector.ps1 and wara_data_analyzer.ps1 against this sub
Note the results for the above ARG queries.

Expected behaviour
The queries should not return results for AFWs in a VWAN secure hub
Screenshots 📷
N/A
Additional context
Anything else we should know to help us troubleshoot this bug?

cc @JefferyMitchell

Hey @JefferyMitchell, assigned to you for the time being but feel free to reassign when you have CSA allocated.

Closing this out. The DDOS APRL guidance has been removed. The ARG query for the following has already been updated to exclude virtual hubs:
https://azure.github.io/Azure-Proactive-Resiliency-Library-v2/azure-resources/Network/azureFirewalls/#deploy-azure-firewall-across-multiple-availability-zones


add python 3.8 testing

What does this PR do?
Fixes #910. I have run CI for 3.8 and it seems that not all packages are ported to 3.8 yet, e.g. torchvision Which comes we shall drop torchvision even from test dependencies #859 #942 #986
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

@Borda how's this going

lets keep this for future, lightning in its installation does not depend on torchvision the solution to this are:

install torchvision from source/git
wait till torchvision is available on pip for py3.8
having own MNIST dataset #942

@Borda is this dead?

no, just resumed, it was blocked by #986 which was merged right now...

seems that PyTorch 1.1 does not exist for py3.8 is, the minimal version is 1.2