Does the colossalAI support to train conditional model based on image condition rather than text?

Hello!
Does the colossalAI support to train conditional model based on image condition rather than text?
@Fazziekey
The configs in colossalAI  are based on text to image, but i want to train a new model based on image.

It‘s ok to train from image condition,  but you need to config the right model and input

It‘s ok to train from image condition, but you need to config the right model and input

Ok  can you share the  example config  with  me?

It‘s ok to train from image condition, but you need to config the right model and input

@Fazziekey

sorry, I don't have an example, but welcome to contribute a example for us


Duplicate headers being send to token endpoint when using oauth2 flow on a HttpSender resulting in bad request error from token endpoint

While implementing oauth2 flow on a HttpSender, we ran into a vague bad request error from configured Microsoft token endpoint. After adding some custom code to get more information, we noticed that the Content-Type header was present twice in the outgoing request.
According to the HTTP spec it is not allowed to have multiple occurrences of a header, except for when it is a comma-separated value that is mergable. This is not the case here.
The issue might be isolated to requests using oauth2 . Our custom code workaround added a duplicate check to fix the issue here: https://github.dev/frankframework/frankframework/blob/2844695d4a4e97514dde6e618f30b3198355c8bc/core/src/main/java/org/frankframework/http/authentication/OAuthAccessTokenManager.java#L170-L201
Reporter
M. Lenterman
To Reproduce
Steps to reproduce the behavior:

Use a HttpSender and configure a tokenEndpoint
Set a common header like Content-Type
Check request object after being converted in OAuthAccessTokenManager.convertToApacheHttpRequest
See duplicate headers

Screenshots
If applicable, add screenshots to help explain your problem.
Configuration
<HttpSender
	name="CatalogiReadHttpSender"
	methodType="POST"
	authenticatedTokenRequest="false"
	scope="..."
	clientAlias="dataverse"
	contentType="JSON"
	tokenEndpoint="..."
	/>

Environment
FF! 7.9-20230905.223421: Openforms2bpel 1.0.0
Running on 6954f3acfcaf using Apache Tomcat/8.5.90
Java Version: OpenJDK Runtime Environment (<IP_ADDRESS>+1)
Heap size: 985M, total JVM memory: 1406M
Free disk space: 210GB, total disk space: 251GB
Up since: 2024-01-16 11:35:31 (2m)

The error message from the Microsoft token endpoint was: the request has an invalid header name

The class OAuthAccessTokenManager.java always added the Content-Type header on POST messages, even though it might already exist. Added a check to conditionally add it. That should fix this issue.
Other headers were not already there or being added, so likely this is the only header that caused the issue.


Angular 6?

Most support forums (Gitter, StackOverflow) say to 'just use node' or 'why are you using aspnet core'?
Which are terrible answers.
How to do I get Angular 6 installed on an existing project?  I like the server-side rendering, using webpack, and having SignalR - but my stuff is no longer compiling because of the error
NodeInvocationException: Uncaught (in promise): ReferenceError: XMLHttpRequest is not defined
ReferenceError: XMLHttpRequest is not defined

Which pretty much breaks all of the development I've done in the past week.  I've tried to add a service (SignalR injectable), 4 models, and 2 components.  I suspect it has to do with the project using Angular 4 and Angular has passed it up a long time ago, with most blogs at the very least at v5.

Have you gotten this to work with asp.net core outside of Service Fabric? Usually the problem is getting the packaging and bundling to play nice with the rest of the SF/.NET Core build process in Visual Studio with  these massive JavaScript frameworks. If you can get it working with just a standalone ASP.NET Core application, you're 99% of the way there, then it's just a matter of making sure your SF application package build output matches what you had working in your standalone ASP.NET Core application.


Implement boolean negation '!' operator for filter expressions

I didn't see a way to negate e.g. the match of a regex, so I implemented full negation of expressions.

Awesome!  This will immediately double the size of the results domain of filter expressions! ;-)
But, seriously, I've been waiting for this a long time.
Thank you.

Looking good! Could you please add some tests that verifies expected behaviour?

Any news about this PR? Looking for this functionality and it would save a lot of time!

I believe it is held up because I never submitted tests. Unfortunately I am
extraordinarily busy and this has not been a priority for me. If someone
would like to jump in and add tests then this could likely get merged soon.
On Feb 21, 2017 8:36 AM, "epacke"<EMAIL_ADDRESS>wrote:

Any news about this PR? Looking for this functionality and it would save a
lot of time!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jayway/JsonPath/pull/283#issuecomment-281398947, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AHYSEpcsd4vWCZlbGiCfkHOm_NpA3CNmks5rexKigaJpZM4LAnp_
.

I see. If I knew how I would do it, but I'm pretty much still in the "Hello world" phase. Hope you'll be less busy soon for your own sake if not for this PR. Thank you for replying! :)

If you need this functionality in the meantime, you can use the release I
put on my fork:
https://github.com/arifogel/JsonPath/releases/tag/2.2.1-SNAPSHOT-arifogel
On Feb 21, 2017 10:16 AM, "epacke"<EMAIL_ADDRESS>wrote:

I see. If I knew how I would do it, but I'm pretty much still in the
"Hello world" phase. Hope you'll be less busy soon for your own sake if not
for this PR. Thank you for replying! :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jayway/JsonPath/pull/283#issuecomment-281429558, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AHYSEt6DzNdwqiAR-2ttUvReDV_7NPcWks5reynjgaJpZM4LAnp_
.

Thank you Ari!

Yaye! :)


IdToken is not available when doing Google OAuth

I am trying to migrate from cordova-plugin-googleplus. In the previous plugin the response I was getting from logging in with google included an idToken which I sent to my server and obtained a refresh_token and the issuer additionally to all the other info I am getting now if I sent just the access_token that is returned from using this plugin.
Plugins.OAuth2Client.authenticate(
      {
        appId: this._appConfig.thirdPartyAPIs.googleOAuth.clientId,
        authorizationBaseUrl: 'https://accounts.google.com/o/oauth2/auth',
        accessTokenEndpoint: 'https://www.googleapis.com/oauth2/v4/token',
        scope: 'email profile',
        resourceUrl: 'https://www.googleapis.com/userinfo/v2/me',
        web: {
          redirectUrl: 'http://localhost:4200',
          windowOptions: 'height=600,left=0,top=0'
        },
        android: {
          appId: 'xxxx.apps.googleusercontent.com',
          responseType: 'code', // if you configured a android app in google dev console the value must be "code"
          customScheme: 'com.example.android:/'
        },
        ios: {
          appId: 'xxxx.apps.googleusercontent.com',
          responseType: 'code',
          customScheme: 'com.example.app:/'
        }
      }
    )

The response I get contains these fields:
  email: string;
  name: string;
  family_name: string;
  given_name: string;
  verified_email: boolean;
  picture: string;
  locale: string;
  id: string;
  access_token: string;

This plugin does not support OpenID, but I created a task to check if it is really just a layer/convention on top of oauth2.
I cannot give you a timeframe until when I will be able to start working on the task, because I have very little sparetime for OSS right now.
See #49

Starting with v2.0.0 of the plugin you have access to the id_token, if you provide no resourceUrl. The id_token includes the resource parameters anyway.

If I remove the resourceUrl I am not getting the email, name, and profile related things. Would you please help me to get both id_token and profile info? Thank you.

@kulkarniswapnil please create a new task for this.


Migrate to facies

Closes #20

Changes Unknown when pulling 20aec99ec0e4264d4c692533148921524dc90b2e on 20-UseFacies into ** on ReleaseCandidate-2.0.0**.


[postgres] Change config option slot.name to be required

Change config option slot.name to be required, see #1386.

@GOODBOY008 Do you have time to help to review this PR ?


Adding PostgreSQL support to Rust Dev Container

Work Item ID
Description

This PR adds:

New Database and Language pair for Rust and PostgresDB.
Tests to verify that the Database is running and accepts commands from the Rust container.
Supporting documentation for running and editing the containers locally

PR Checklist

Use the check-list below to ensure your branch is ready for PR.  If the item is not applicable, leave it blank.

[x] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] My code follows the code style of this project.
[x] I ran the lint checks which produced no new errors nor warnings for my changes.
[x] I have checked to ensure there aren't other open Pull Requests for the same update/change.

Does this introduce a breaking change?

[ ] Yes
[x] No

If this introduces a breaking change, please describe the impact and migration path for existing applications below.

Testing

Instructions for testing and validation of your code:

What OS was used for testing.
MacOS 12.1 Monterrey.
Which test sets were used.
Login to the rust container and performing multiple cargo cli calls:

cargo -V
cd test-project
cargo build
cargo run
cargo test

Description of test scenarios that you have tried.
Integration testing with database:

Test access to the Postgres container on the default database port.
Perform a query to the database to retrieve the default database name.

All these is covered using test-project/test.sh
Other information or known dependencies

Use of lld linker instead of default ld to build test examples (main.rs and db_test.rs) to improve building times. See Dockerfile and .cargo/config.toml for more details.

Closing this PR since now it was 'moved' to upstream/main for review.


Implement @nobarrier

Based on the Attribute Priority branch.

This branch does not fix __syncthreads placement to match that of OCCA.

Fixes #112


Update rabbitmq configs

Codecov Report

Merging #113 (a5c6bb0) into main (c59c148) will increase coverage by 0.73%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
+ Coverage   77.83%   78.57%   +0.73%
==========================================
  Files           3        3
  Lines         406      406
==========================================
+ Hits          316      319       +3
+ Misses         90       87       -3

Files Changed
Coverage Δ

src/SimulationService.jl
71.42% <50.00%> (+1.26%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Update config-settings.rst

Needs one approval to merge

@esethna I submitted the session length docs to master branch so these can be merged before tomorrow.

/check-cla


Update our usage of cellxgene-schema to match 2.0.0 changes

During the upload process, we need to now call cellxgene-schema with the following arguments to support the application of human-readable labels:
cellxgene-schema validate --add-labels <OUTPUT FILE>
Please coordinate with @pablo-gar
Definition of Done

Replace our existing cellxgene-schema with updated call
Continue down processing path with the resulting output file
Clean up output file and original H5ad at the end of processing
Fix any broken tests
Handle any possible failure paths resulting from the call
Remove any of our redundant h5ad validation from H5ADDataFile

@leslieypark @metakuni @danieljhegeman @blrnw3 Hey team! Can you please add your planning poker estimates with ZenHub

Since we're running up against our Sept 10th deadline, let's descope these pieces:

Fix any broken tests
Handle any possible failure paths resulting from the call
Remove any of our redundant h5ad validation from H5ADDataFile

Closing per conversation with @maniarathi


⚠ RPC server - Avalanche has degraded performance

In 4f02952, RPC server - Avalanche ($AVALANCHE_RPC_URL) experienced degraded performance:

HTTP code: 0
Response time: 0 ms

Resolved: RPC server - Avalanche performance has improved in cf6a358.


PUT request getting blocked by CORS

I have a route that was getting blocked by CORS when it was set as a PUT method, but worked as a POST. My fix was to add the following header into the get_access_control_headers method of the CORSConfig class:
"Access-Control-Allow-Methods": "GET, POST, PUT, DELETE, PATCH, OPTIONS"

Putting it manually into a headers kwarg for the route did not work.

The cors standard A CORS-safelisted method is a [method](https://fetch.spec.whatwg.org/#concept-method) that is `GET`, `HEAD`, or `POST`. (https://fetch.spec.whatwg.org/#methods) which is why the PUT was not working.
And it would not work on the method manually, since CORS happens on a preflight OPTIONS request.
I will add ability to pass in Access-Control-Allow-Methods dynamically as well as any other headers, so it is easier to customize in the future.


not working with current TL

Hi,
I know this is a quite bad title for the issue but I have no idea what the reason is. It seems like unicode-math is broken with a current TeX Live (I guess due to some changes in L3).
The following MWE won’t compile.
% !TeX program = xelatex
\documentclass{article}
\usepackage{unicode-math}
\begin{document}
Test
\end{document}

I’m using an up-to-date TeX Live 2017 and get several errors about undefined control sequences, e.g. \g__um_named_ranges_seq or \__um_log:nx.

no problem with my up-to-date TL2017
 *File List*
 article.cls    2014/09/29 v1.4h Standard LaTeX document class
  size10.clo    2014/09/29 v1.4h Standard LaTeX file (size option)
unicode-math.sty    2017/11/18 v0.8i Unicode maths in XeLaTeX and LuaLaTeX
   expl3.sty    2017/12/05 L3 programming layer (loader)
expl3-code.tex    2017/12/05 L3 programming layer
l3xdvipdfmx.def
  xparse.sty    2017/12/05 L3 Experimental document command parser
l3keys2e.sty    2017/12/05 LaTeX2e option processing using LaTeX3 keys
fontspec.sty    2017/11/09 v2.6g Font selection for XeLaTeX and LuaLaTeX
fontspec-xetex.sty    2017/11/09 v2.6g Font selection for XeLaTeX and LuaLaTeX
 fontenc.sty
   tuenc.def    2017/04/05 v2.0i Standard LaTeX file
fontspec.cfg
ucharcat.sty    2015/11/19 v0.03 ucharcat for luaLaTeX (DPC)
  fix-cm.sty    2015/01/14 v1.1t fixes to LaTeX
  ts1enc.def    2001/06/05 v3.0e (jk/car/fm) Standard LaTeX file
filehook.sty    2011/10/12 v0.5d Hooks for input files
unicode-math-xetex.sty    2017/11/18 v0.8i Unicode maths in XeLaTeX and LuaLaTeX

That’s strange … I can’t even get a file list …
However I checked manually and the versions are the same as yours and tlmgr doesn’t show any updates at the moment. And as far as I can tell there’s nothing in my user texmf tree that can have an effect on this.
I attach the log file of this MWE
% !TeX program = xelatex
\listfiles
\documentclass{article}
\usepackage{unicode-math}
\begin{document}
Test
\end{document}

log file: um-bug.log

It seems that you have put unicode-math-xetex.sty in your working directory, but this file is not up-to-date and may not be compatible with the current unicode-math.

You are using a local file:
`(./unicode-math-xetex.sty
should also be
(/usr/local/texlive/2017/texmf-dist/tex/latex/unicode-math/unicode-math-xetex.sty

Damn … that’s the problem when using a cluttered temp folder for tests … thanks!


Feat(2024): Adding Achievement Section

GATE & CAT
 1. name: Aditya Raj Sharma, rank: GATE AIR 242'
 2. name: Vatsal Adhiya, rank: GATE AIR 313
 3. name: Kuldeep Soni, rank: GATE AIR 669
 4. name: Aditya Raj Singh, rank: CAT 99.72%

Achivers
 1. name: Ashish Soni, achievements: C4GT'24, GSoC'23 Tor
 2. name: Sankalp Pareek, achievements: GSoC'24 GFOSS
 3. name: Dhairya Majmudar, achievements: GSoD'24 JSON Schema, SoK'24 KDE
 4. name: Tarsh Swarnkar, achievements: Amazon ML Summer Camp.
 5. name: Aaryan Singh, achievements: Amazon ML Summer Camp
 6. name: Lakshita Saxena, achievements: Amazon ML Summer Camp
 7. name: Srishti Singh, achievements: Google WE Scholar'24
 8. name: Anishka Verma, achievements: Google WE Scholar'24
 9. name: Pranam Srivastava,  achievements: Infosys SpringBoard'24

Thank you @DhairyaMajmudar for new achievement section.


Can't open app on Mac/Linux if GitHub API call fails

The Issue
GitHub was down for a few minutes and someone reported not being able to access the app. Add additional error checking for the GitHub API call (https://github.com/lbryio/lbry-desktop/blob/e1210f78051e984f26905c01f5d7eac454adad01/src/main/index.js#L184) so that it doesn't prevent app startup if GitHub is down.
There is an uncaught Json error called on startup for Mac/Linux or on the help page for Windows. (don't have a screenshot). Probably occurring here: https://github.com/lbryio/lbry-desktop/blob/e1210f78051e984f26905c01f5d7eac454adad01/src/main/index.js#L197
System Configuration

LBRY Daemon version:
LBRY App version:
LBRY Installation ID:
Operating system:

Anything Else

Screenshots

This was fixed in https://github.com/lbryio/lbry-desktop/commit/6126eb1bf4248206aff119f2ec2f2a72d0f63ea7


missing 1 required positional argument: 'image_dims'

Hello.  Working on a project that current plugs into roboflow and getting the following exception.
File "/home/intellisite/.local/lib/python3.8/site-packages/roboflow/models/classification.py", line 68, in predict
  return PredictionGroup.create_prediction_group(
TypeError: create_prediction_group() missing 1 required positional argument: 'image_dims'
Exception : create_prediction_group() missing 1 required positional argument: 'image_dims'

This is with latest version, 0.2.32, on a jetson.  I am not however sure about the version of the inference server running in a docker container.  Perhaps they are out of sync in some way.  Does anybody recognize this exception, how should I proceed?  Thanks!

Some additional info.  The code I am trying to run supposedly works on another machine, which has the 0.2.25 py module installed.  Have there been breaking changes to the API between 0.2.25 and 0.2.32 that would explain this behavior?

I think it was fixed long time ago, probably by this commit: https://github.com/roboflow/roboflow-python/commit/1eded918ac89cf0828830a8c5a568bf598eb3cbe
Thanks for the report!


Dataset issue

Could you please check dataset? When i want to extract dataset i get error while extracting.

Could you please explain in detail where the error occurs?

Where can I get the  under


Merge pull request #4 from AlexBosca/master

Updated Jenkinsfile, development and test properties files to use Jenkins credentials.

Task linked: CU-85zrt8xa4 Add credentials using in Jenkinsfile


Move correct generated file

Goal
Rename the correct directory with all the generated HTML for Dokka task

#1246  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bidetofevil and the rest of your teammates on  Graphite

Merge activity

Aug 14, 12:13 AM EDT: @bidetofevil started a stack merge that includes this pull request via Graphite.


log when 0-RTT keys become available

Codecov Report

Merging #2274 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2274      +/-   ##
==========================================
+ Coverage      86%   86.01%   +<.01%
==========================================
  Files         108      108
  Lines        8074     8076       +2
==========================================
+ Hits         6944     6946       +2
  Misses        852      852
  Partials      278      278

Impacted Files
Coverage Δ

internal/handshake/crypto_setup.go
67.51% <100%> (+0.15%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07d76c5...8183104. Read the comment docs.


Delta Mode

Provide a way to enable delta mode where applicable.

enigma.js opts into this by default, with a global setting to opt out. You can also write request interceptors to do selective opt ins/outs
RxQ can do something similar. I am leaning towards default opt out of delta mode, with options to opt in across the board as well as define overrides for qType & method combinations. I'm thinking an API within the config like:
const config = {
  // ...usual config stuff,
  delta: true / false,
  deltaOverrides: [
    {
      qType: "GenericObject",
      includeDelta: ["GetProperties", "GetLayout"]
      // alternatively, excludeDelta
    }
  ]
}

First step is to add in the ability to even handle delta mode though. It seems most (all?) calls use it -> need to investigate further

done in https://github.com/axisgroup/RxQ/tree/v1.1.0
the API is slightly different from above, will have to update docs


Can the maintainer please add these TWO VERY SIMPLE patches from ungoogled-chromium

Exactly what the title says
Links for the patches pull requests
https://github.com/ungoogled-software/ungoogled-chromium/pull/1978
https://github.com/ungoogled-software/ungoogled-chromium/pull/1591

Yes.
In fact, I plan to eventually add all ungoogled-chromium flags eventually, given that so many users request them, directly or indirectly, if only to compensate for ungoogled-chromium not supporting NT 5.x/6.x/GDI rendering/whatever old features I will keep that are out of ungoogled's scope. This would include an option to prevent involuntary connections to Google.


Corridor URLs in atlas-enriched-dataset-graph return 404

file properties lead to https://cns-iu.github.io/hra-cell-type-populations-supporting-information/data/corridors/RUI_LOCATION_ID.glb but the corridors do not live there anymore. Currently, they are at https://github.com/x-atlas-consortia/hra-pop/tree/main/deprecated-corridors

This will be fixed in next run (v0.6).

Update 4/9/24: corridors will be on hra-kg (LOD server): https://lod.humanatlas.io/
Also, @bherr2 will add corridor-cache

Update 4/23/24:
corridor-cache will be added in v0.10.2.

Will be fixed with 0.10.2.


Fix autoOk option

[x] I have changed my target branch to develop :facepunch:

Description
Fixes #116
ModalWrapper's togglePicker method was removed, but it is still used by PickerBase
This PR adds open and close convenience methods to ModalWrapper and changes PickerBase to use wrapper.close instead of wrapper.togglePicker method.

Ops, This was my fault 😅. Thanks for the fix 👍 👍


proposal: cmd/vet: check for iterator variable reference

Hi,
I wanted to make a feature request as this happens way too often and results in strange errors which are hard to debug: The iterator variable reference (https://github.com/golang/go/wiki/CommonMistakes#using-reference-to-loop-iterator-variable) should be reported by go vet.
I think this would increase code quality a lot if those errors could be reported by analyzing the code.

Dup of #16520.


AssertionError: Error: all query identities do not appear in gallery

Hi,
Thank you for providing this code.
I have a question:
In https://github.com/NirAharon/BoT-SORT/blob/main/fast_reid/fastreid/data/datasets/mot20.py:
Line 50: self.query_dir = osp.join(self.data_dir, 'query')
Line 52: self.extra_gallery_dir = osp.join(self.data_dir, 'images')
Line 65: query = lambda: self.process_dir(self.query_dir, is_train=False)
Line 66: gallery = lambda: self.process_dir(self.gallery_dir, is_train=False) +  (self.process_dir(self.extra_gallery_dir, is_train=False) if self.extra_gallery else [])
Line 73: img_paths = glob.glob(osp.join(dir_path, '*.bmp'))
What are these query and images folders?

Only two folders bounding_box_train and bounding_box_test are generated by https://github.com/NirAharon/BoT-SORT/blob/main/fast_reid/datasets/generate_mot_patches.py

Hence, https://github.com/NirAharon/BoT-SORT/blob/main/fast_reid/fastreid/evaluation/rank.py always throw assertion error in Line 90 and 154:
AssertionError: Error: all query identities do not appear in gallery
Becasue num_valid_q is indeed zero.

Hello, I also encountered this problem, may I ask if you have solved it

I am also facing same issue, please someone help me to resolve this

I encountered the problem, too. It seems to be a common problem.

I also met this problem. Have you solved it?I also met this problem. Have you solved it?

Hi, I met the same problem. Have you solve it and may I get some suggestion from you? Thank you


⚠ Jenkins Plugins Artifactory has degraded performance

In adf09d7, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1285 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 53dfc74 after 1 hour, 10 minutes.


"Stack"->"Region" functionality isn't working

Platform where was tested: MacBook Air, OS X 10.11.3.
Browsers where was tested: Chrome 49, Safari 9.0.3.
Tools page release: v.0.13.5.
Steps to reproduce:

Go to Mountain chart.
Try to switch between "Stack"->"World" and "Stack"->"Region".

Actual result:
Nothing happens on switching.
Expected result:
Borders between countries inside region should disappear.

related to #1605

Retested. Fixed.


Add documentation and doc tests for account.rs ** Simplify import paths

make ran successfully.

Great! Thank you!


bug(#699): fixed crashing app on clicking on request result in runner

Fixes bug #699 introduces in #622
FYI: @Its-treason
Contribution Checklist:

[x] The pull request only addresses one issue or adds one feature.
[x] The pull request does not introduce any breaking changes
[x] I have added screenshots or gifs to help explain the change if applicable.
[x] I have read the contribution guidelines.
[x] Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Nice @martinsefcik !
Thanks for taking care of this.
Merged!


Keras symbolic input/outputs and layer_names issue

Hello,
I'm trying to train a model and use Keract to display the feature maps which are applied while training, but I ran into a problem. The model I'm trying to train is depicted in the snippet below.
def build_model2():
    model = Sequential()
    model.add(Conv2D(75, (3, 3), strides = 1, name = "conv1", padding = 'same', activation = 'relu', kernel_initializer = "he_normal", input_shape = (28,28,1)))
    model.add(BatchNormalization(name = "batchnorm1"))
    model.add(MaxPooling2D((2, 2), strides = 2, padding = 'same', name = "maxpool1"))
    model.add(Conv2D(50, (3, 3), strides = 1, name = "conv2", padding = 'same', activation = 'relu', kernel_initializer = "he_normal"))
    model.add(Dropout(0.1, name = "dropout1"))
    model.add(BatchNormalization(name = "batchnorm2"))
    model.add(MaxPooling2D((2, 2), strides = 2, name = "maxpool2", padding = 'same'))
    model.add(Conv2D(25, (3, 3), strides = 1, name = "conv3", padding = 'same', activation = 'relu', kernel_initializer = "he_normal"))
    model.add(BatchNormalization(name = "batchnorm3"))
    model.add(MaxPooling2D((2, 2), strides = 2, name = "maxpool3", padding = 'same'))
    model.add(Flatten(name = "flatten"))
    model.add(Dense(512, name = "dense1", activation = 'relu'))
    model.add(Dropout(0.15, name = "dropout2"))
    model.add(Dense(25, name = "dense_output", activation = 'softmax'))
    model.compile(optimizer = 'adam', loss = 'categorical_crossentropy', metrics = ['accuracy'])
    model.summary()
    plot_model(model, to_file = "model_enhanced.png", show_shapes = True)
    return model

If I try to run the following snippet, I get the following error, although I think I don't have any input/output layers:
first_input = test_X[0]
activations = get_activations(model, first_input, auto_compile = True)
display_activations(activations, cmap = "gray", save = False)

TypeError: Keras symbolic inputs/outputs do not implement `op`. You may be trying to pass Keras symbolic inputs/outputs to a TF API that does not register dispatching, preventing Keras from automatically converting the API call to a lambda layer in the Functional Model.

A bigger issue is that if I try to get only the activation map for a single layer, I get another error, as such
first_input = test_X[0]
activations = get_activations(model, first_input, layer_names = "conv1", auto_compile = True)
display_activations(activations, cmap = "gray", save = False)

KeyError: 'Could not find a layer with name: [conv1]. Network layers are [conv1, batchnorm1, maxpool1, conv2, dropout1, batchnorm2, maxpool2, conv3, batchnorm3, maxpool3, flatten, dense1, dropout2, dense_output]'

Do you have any idea why this happens?

@razvanw0w I'll have a look tomorrow. In the meantime make sure your imports are from tensorflow and not from keras. import tensorflow.keras instead of import keras.

@razvanw0w I'll have a look tomorrow. In the meantime make sure your imports are from tensorflow and not from keras. import tensorflow.keras instead of import keras.

Done, I ruled this out. Libraries aren't the problem.

@razvanw0w so good news I don't have any problem and I can run your code perfectly.
import numpy as np
from tensorflow.keras import Sequential
from tensorflow.keras.layers import BatchNormalization
from tensorflow.keras.layers import Conv2D, MaxPooling2D, Dropout, Flatten, Dense
from tensorflow.python.keras.utils.vis_utils import plot_model

from keract import get_activations, display_activations

def build_model2():
    model = Sequential()
    model.add(
        Conv2D(75, (3, 3), strides=1, name="conv1", padding='same', activation='relu', kernel_initializer="he_normal",
               input_shape=(28, 28, 1)))
    model.add(BatchNormalization(name="batchnorm1"))
    model.add(MaxPooling2D((2, 2), strides=2, padding='same', name="maxpool1"))
    model.add(
        Conv2D(50, (3, 3), strides=1, name="conv2", padding='same', activation='relu', kernel_initializer="he_normal"))
    model.add(Dropout(0.1, name="dropout1"))
    model.add(BatchNormalization(name="batchnorm2"))
    model.add(MaxPooling2D((2, 2), strides=2, name="maxpool2", padding='same'))
    model.add(
        Conv2D(25, (3, 3), strides=1, name="conv3", padding='same', activation='relu', kernel_initializer="he_normal"))
    model.add(BatchNormalization(name="batchnorm3"))
    model.add(MaxPooling2D((2, 2), strides=2, name="maxpool3", padding='same'))
    model.add(Flatten(name="flatten"))
    model.add(Dense(512, name="dense1", activation='relu'))
    model.add(Dropout(0.15, name="dropout2"))
    model.add(Dense(25, name="dense_output", activation='softmax'))
    model.compile(optimizer='adam', loss='categorical_crossentropy', metrics=['accuracy'])
    model.summary()
    plot_model(model, to_file="model_enhanced.png", show_shapes=True)
    return model

if __name__ == '__main__':
    test_X = np.random.uniform(size=(2, 28, 28, 1))
    first_input = test_X[0:1]
    m = build_model2()
    print(m.predict(first_input).shape)
    activations = get_activations(m, first_input)
    display_activations(activations, cmap="gray")

It's likely a dep problem. Upgrade your tensorflow version.
 pip list | grep tensorflow
tensorflow               2.3.0
tensorflow-estimator     2.3.0

Had the same issue. It turns out a tensorflow dependency probem. get_activations() doesn't work on tf 2.4.0, after I downgrade tf to 2.3.0, it works!

The dependency fix did the work. I had TF 2.4.0 and downgrading did the work. I will close the issue.
SOLVED!

I'm going to add the TF<=2.3.0

Tensorflow keeps changing their compatibility at every version..

I pushed a new version 4.3.4 that solves the compatibility with TF 2.4.0


Rook 1.5.9

Test grid is failing. Will fix

I added a log function to the common.sh but this isn't available in the testgrid pr. This brings up the bigger question of whether or not an add-on should be fully self-contained but that is a question for another day.


$PASSWORD_STORE_DIR expansion creates unintended directory structure when using fscopy

Summary

Encrypting a file to the password store via path expansion of $PASSWORD_STORE_DIR, creates a directory structure of the expanded path from password store dir root.
Steps To Reproduce

cd ~
touch ./test-file.txt
gopass fscopy ./test-file.txt $PASSWORD_STORE_DIR/test-file.txt

Results (on mac) in: $PASSWORD_STORE_DIR/Users/<user>/path/to/password-store/test-file.txt.gpg i.e., $PASSWORD_STORE_DIR/Users/<user>/$PASSWORD_STORE_DIR/test-file.txt.gpg
Expected behavior

Creates an encrypted file of ~/test-file.txt at $PASSWORD_STORE_DIR root. i.e., $PASSWORD_STORE_DIR/test-file.txt.gpg
Environment

macos 13.5
OS Version: Darwin tjex-lappy 22.6.0 Darwin Kernel Version 22.6.0: Wed Jul  5 22:22:05 PDT 2023; root:xnu-8796.141.3~6/RELEASE_ARM64_T6000 arm64
gopass Version: gopass 1.15.11 go1.21.4 darwin arm64
Installation method: brew

Additional context

Additionally, it would be great if gopass could also handle an empty target filename.
e.g: gopass fscopy ./test-file.txt $PASSWORD_STORE_DIR should result in a file named test-file.txt.gpg at $PASSWORD_STORE_DIR.
Currently what happens is similar as the behaviour as above, but the password store root folder is used as the file name.
$PASSWORD_STORE_DIR/Users/<user>/path/to/password-store/password-store-folder-root-name.gpg

This is certainly not intentional but I wonder if it's worth a workaround. I think you're using gopass wrong. Neither input nor output should contain $PASSWORD_STORE_DIR. In fact you should usually not mess with the contents directly (or at least not using gopass to target anything in there).

I'm not actually typing in $PASSWORD_STORE_DIR. It was for clarities sake... But very clear how misleading that is.
I'm navigating as usual, but it still sounds like an expansion issue, as I'm using ~ on mac to navigate from home.
version: gopass 1.15.11 go1.21.4 darwin arm64
I made an asciinema recording of the issue:
https://asciinema.org/a/4Ly7KK729pDh3YWFGtNndfmci


fix(plugin-http): ensure no leaks

Which problem is this PR solving?

respect events order
closes #397

Short description of the changes

add WeakSet in order to check if span is already ended
listen to close event
remove userAgent attribute if not defined (instead of empty string) (spec)
add _closeHttpSpan which is responsable to end the span (like the existing _startHttpSpan which is responsable for getting a new span)
add tests
remove setSpanOnError from utils

Codecov Report

Merging #398 into master will decrease coverage by 1.26%.
The diff coverage is 90.62%.

@@            Coverage Diff             @@
##           master     #398      +/-   ##
==========================================
- Coverage   98.33%   97.06%   -1.27%
==========================================
  Files          59       25      -34
  Lines        1677     1773      +96
  Branches      118      193      +75
==========================================
+ Hits         1649     1721      +72
- Misses         28       52      +24

Impacted Files
Coverage Δ

...-plugin-http/test/functionals/http-package.test.ts
95.45% <100%> (ø)

...y-plugin-http/test/functionals/http-enable.test.ts
95.57% <100%> (ø)

packages/opentelemetry-plugin-http/src/http.ts
97.25% <84.21%> (ø)

...ges/opentelemetry-exporter-zipkin/src/transform.ts
100% <0%> (ø)
:arrow_up:

...entelemetry-exporter-zipkin/test/transform.test.ts
100% <0%> (ø)
:arrow_up:

.../opentelemetry-exporter-zipkin/test/zipkin.test.ts
100% <0%> (ø)
:arrow_up:

...s/opentelemetry-core/test/context/B3Format.test.ts

packages/opentelemetry-core/src/platform/index.ts

.../opentelemetry-core/test/metrics/NoopMeter.test.ts

...metry-core/src/trace/instrumentation/BasePlugin.ts

... and 66 more

Looks like I addressed all comments. Please let me know


Too many active WebGL contexts

I'm building an app integrated with React which loads several individual experiments, in pixi.js, three.js etc. Because I can't use an iframe to load the experiments, I need to clean after myself.
Every time there is a navigation to a new experiment, I'm checking if the a renderer exists, or not, and if it does I'm destroying it).
dummy code
if renderer
    renderer.destroy(true);
    renderer = null

renderer = new PIXI.autoDetectRenderer ......

It seems that I'm correctly cleaning my webgl renderer, however after 16 pages get loaded, I get the warning saying WARNING: Too many active WebGL contexts. Oldest context will be lost. This shouldnt be a problem on desktop as we only have a warning, but on the ipad it crashes the browser and a message appears: X A problem occurred with this web page, so it was reloaded..
I was looking at threejs and how they implement a solution for this, and they have the following code
Am I doing anything silly?

@andrevenancio
I'm no expert in Pixi seeing as I've only been using it since monday or tuesday, however. If you are having multiple renderers and canvases due to many experiments(like this) in an idea of only one needs to be accessed at one time, I would have a global renderer or another, and keep the experiments in an array. Then when you need to display it, just pass the stage from each experiment into the renderer.
var renderer = PIXI.autoDetectRenderer({blah});
var experiments = [];
experiments.push(experiment1);
experiments.push(experiment2);
experiments.push(experiment3);

var currentExperiment = $('#experminetSelector').val();
renderer.render(experiments[currentExperiment]);

This way you're only making the renderer once and just passing it the stage from each experiment. Though this only works if you're trying to only render one page and have all the experiments on it rather than having a lot of different experiment pages.
DISCLAIMER: I'm new to pixi, and didn't try this out, your mileage may vary. Also it still sounds as if you found some kind of bug that maybe the devs would want to look into or give some guidance to.

Having a single renderer and multiple scenes should be fine. 1 renderer === 1 canvas element.

Hey guys, thanks for your feedback. @samuraiseoul What you're suggesting isnt silly at all, and that's how I would normally proceed to have several experiments in one framework... however, I will need to make another solution as the experiments can de done using pixi.js threejs or plain webgl. Also, on top of that, because of the type of the transitions already defined in the react structure, at a point you will see the old experiment, and the new experiment at the same time, rendering simultaneously, so the idea of one renderer won't work....
Plus.... this is a work around for the problem, not a solution itself... If the .destroy() method actually doesn't destroy the reference to the webgl context... what's the point? :(

Yo buddy! Totally agree that the destroy function is not exactly doing what its supposed to if the contexts are not being destroyed :)
I wander, are you using autodetectRenderer ? It could be that the test context we create to detect if the browser is webGL capable is not being destroyed.

I think we remove the references we hold, and optionally remove the canvas element (which is required for context cleanup) but then it is up to the browser to do the clean. It is possible that contexts are leaking, or that they are being created faster than the browser wants. Honestly I'm not sure.
Do dev tools indicate leaks around contexts like this? Maybe that can help?

This is why I still love iframes no matter what.
@GoodBoyDigital I'm using the autodetectRenderer like this
@renderer = new PIXI.autoDetectRenderer canvas.width, canvas.height, { view: canvas, antialias: false, backgroundColor: 0xffffff }

I'm parking this for now, will let you guys know what the solution is when I found one.. I was just thinking that forcing that context lost, would maybe force the garbage collection to clean it.. but not sure of it either :)

I'm having the same issue. What I am building requires that Pixi be destroyed and rebuilt quite often and I'm concerned about the memory implications. Each WebGL instance is quite small at the moment, but it will get much much larger as we continue to build this out.
Any progress?

To be clear, I'm using Phaser, but it seems to be calling Pixi's renderer.destroy method.

no luck yet. If you can either use one global renderer and you just render different scenes into it, or, just load content through an iframe and that disposes properly of whatever is hanging.

Hey peeps, yes this is a bit of a tricky one really. As far as I can see we do everything we can to destroy a context. So all textures / programs arraybuffers ect are destroyed. What we could do is maybe pool the contexts once they are destroyed so that we reuse them rather than create a new one each time?

hey @GoodBoyDigital in my case i had an animation in/out so i would always needed 2 contexts... that's the problem with integrating with React and not making it full pixi... anyway, not sure this is a bug you can fix per say.. I think its more like the browser manages the contexts... don't even know if this hack from three.js works... maybe give it a go on ur V4 and try to open 16+ tabs with pixi https://github.com/mrdoob/three.js/blob/master/src/renderers/WebGLRenderer.js#L289
Otherwise no worries mate, I already changed the architecture of my app... iframe FTW :)

Good stuff man! I will definitely look into adding the three.js trick too.

I would love to use one global rendered. In fact, that's my ultimate goal. However, I'd need a way to stream code into the existing context.
In other words, the user is writing the code. It's not pre-written.

I think I found a good solution. This allows me to have map overlay React components that don't have to know about each other and allow's React to own the DOM.
It uses this technique to force the context loss:
gl.getExtension('WEBGL_lose_context').loseContext();

Here's a full example:
var document = require('global/document');
var PIXI = require('pixi.js');

// I want to keep this canvas / renderer around. For example, this might be a bottom layer PIXI / React map overlay.
var canvas1 = document.createElement('canvas');
document.body.appendChild(canvas1);
createRenderer(0xff0000, canvas1);

function createRenderer(color, canvas) {
  canvas = canvas || document.createElement('canvas');
  var renderer = new PIXI.WebGLRenderer(800, 600, {view: canvas});
  var stage = new PIXI.Container();
  var graphics = new PIXI.Graphics();
  graphics.beginFill(color, 0.5);
  graphics.drawCircle(0, 0, 200);
  graphics.endFill();
  stage.addChild(graphics);
  renderer.render(stage);
  return {renderer: renderer, stage: stage, graphics: graphics};
}

// Simulate frequent adding / removing of lots of PIXI / React map overlays on top.
for (var i = 0; i < 16; i++) {
  var canvas = document.createElement('canvas');
  document.body.appendChild(canvas);
  var scene = createRenderer(0x00ff00, canvas);
  // Uncomment to see that the original canvas isn't removed.
  /* scene.renderer.currentRenderTarget.gl
      .getExtension('WEBGL_lose_context').loseContext(); */
  scene.renderer.destroy();
  scene.stage.removeChild(scene.graphics);
  document.body.removeChild(canvas);
}

Maybe PIXI should add this to its own "destroy" method?

That makes sense if we own the context, which I think right now we assume we do (v3).

In the function isWebGLSupported() (source/core/utils/index.js) replacing
            return !!(gl && gl.getContextAttributes().stencil);
with
                       var success = !!(gl && gl.getContextAttributes().stencil);             gl.getExtension('WEBGL_lose_context').loseContext();             gl = undefined;             return success;
fixed the problem for me. It was most prominent in Google Chrome - Firefox worked either way. As I'm a bit of a WebGL noob I'd be really grateful for comment on this approach.

Good call losing the context forcibly when checking, that is a great idea since we know (100%) that we own that context.

Did this get merged ? We are having the same problem.

ping @englercj i think this can be closed now

gl.getExtension('WEBGL_lose_context').loseContext() may suppress the warning but the spec says it merely simulates losing the context, until WEBGL_lose_context.restoreContext() is called - which can restore the context only if it wasn't truly lost in the first place.

This might be useful:   lose_context() is only a simulation (according to the spec) but in this thread (Public WebGL: WEBGL_lose_context we learn (from mozilla developer Jeff Gilbert) that in Firefox loseContext() is a byword for "release this context and its
resources" .
The problem is that other browsers handle this differently. There are comments from a Google developer (Ken Russell) recommending : Please use the explicit delete* APIs on the WebGLRenderingContext to release GPU resources that your application is no longer using.

I have to admit I haven't experimented with any of this but it looks like any solution is going to be browser specific.

Interesting FF implementation note. Indeed, Ken's advice about deleting individual resources looks like the standard way to go, FF is but one among the many popular browsers and even FF behavior might change without notice. I also haven't tested per browser because of not wanting to rely on implementation detail and fakeable user agent string or browser sniffing and additional code paths when there's an alternative.

I was doing some testing for my app today on iOS and ran into this error. Is there a known workaround? My pixi view is a subcomponent of a screen on my app, so it gets destroyed when the user navigates away from that page. I was thinking, would it work to somehow detach/reattach the same renderer to the view's canvas to work around the issue?

The workaround is to not create multiple contexts. Just reuse ones you have.

Hmm, so how would I go about reusing a context? I'm using angularJS, so I'm working within a templating framework. Like, could I detach the canvas element from the DOM and store it, then when the user comes back to the page, reattach it to its place in the page? It'd be great if there was a way within PIXI to say "use this existing renderer + context and attach them to this new canvas", but I don't understand how it happens under the hood.

Saving the instance of your PIXI.Application/PIXI.WebGLRenderer/PIXI.CanvasRenderer will also save the instance of your canvas element. For instance, in PIXI.Application, you can get the view property which is the HTMLCanvasElement. You can insert this canvas element and remove it from your AngularJS/React app. In PIXI you can tell the Renderer which canvas element to use by passing it as an option, however, you shouldn't use this. Instead, allow PIXI to create it's own canvas element internally and just appendChild to some DOM container.

// maintain the reference to this Application even as your SPA view gets destroyed
const app = new PIXI.Application();

// Insert in the DOM or whatever the equivalent is in Angular
document.querySelector("#pixi-container").appendChild(app.view);

Ok, thanks, I'll give that a try. Doesn't look bad at all actually.

Alright, detaching and reappending the view instead of destroying it solved my issue, thanks for the help guys.


Documentation issues

fix #442

The PR attempts to fix all issues brought up in #442

Please add these grammatical rules to doc/javadoc.hpp at the top so I can learn and apply them. This PR looks good!

Needs to be squashed though


Add New CSS Technical Question: What is CSS and what is it's purpose?

ISSUE TYPE

[ ] Typo
[ ] Bug
[x] Feature

WHERE / WHAT

Help flesh out technical questions page by adding categories not already represented.
EXPECTED BEHAVIOR

Give quick and simple "What is CSS" and give some general info on how it can be useful in web design.
REPRODUCTION STEPS

Add document what-is-css.html
Update link in technical.html to direct to new question page.

I'll take this one and have a PR up by the end of the day.

Is it still open for contribution!


Allow white/black list to be configured

This will be very useful, add some blocks to be no tracked.

This would be interesting and useful for many reasons. Could help with performance in some cases, will save storage space, make viewing data easier, and enable server users to disable tracking of certain blocks that cause problems.
I'm planning to work on some changes to configuration and I'll make sure to look into this as well.


feat: Restart ceilometer-agent-compute after nova-compute upgrade

Fix: #427

hypervisors

Can you provide more details here? I am not sure which test function need to change from this comment.

I realized that for some reason the new post upgrade steps are not showing into the mocked_plans, hypervisors and core unit tests. Probably you need to add ceilometer subordinate units.
You also need to include the subordinates new field into the string representation of OpenStackApplication so in the future we can get this new information and replicate into mocked tests. I'm ok not updating on all mocked plans now, but I would like to see at least one changed and working as expected.

Can you provide more details here? I am not sure which test functions need to change here.

Hi @gabrielcocenza , can I get your review again? All the comments from you are been addressed.


po2json for new Jed format

Hey Jed folks! A couple of us were having a discussion about the new Jed format downstream at mikeedwards/po2json#32 . We're trying to figure out what the best output for something like this:
msgid "one product"
msgid_plural "%d products"
msgstr[0] "jeden produkt"
msgstr[1] "%d produkty"
msgstr[2] "%d produktów"

We were outputting (correctly or not):
         "one product": [
            "%d products",
            "jeden produkt",
            "%d produkty",
            "%d produktów"
         ],

Would it be like this now that the zeroth element is being lopped off?
         "one product": [
            "jeden produkt"
         ],
         "%d products": [
            "jeden produkt",
            "%d produkty",
            "%d produktów"
         ]

Hey all. I just released po2json 0.4.1, and I've removed that first element so that it conforms to Jed as it now stands. Should I close this issue? Or do you think there might be revisions to the Jed format?

Hi @mikeedwards
saw that yesterday, going to do a lot of tests with Jed 1.1 today & tomorrow, I'll keep you posted if I notice something wrong.

@mikeedwards for what I could test, this seems fine to me. I dont have specifics domain nor context, so I cant tell for this part, but plurals are fixed.

Great, thanks for testing!


Login error code auth:2

🧐 Have you read the FAQ and viewed similar issues?

[X] I have read the FAQ
[X] I have checked older issues, open and closed
[X] I did a clean install of SpotX as described in the FAQ

Сountry of your account
Germany | Austria
What is your Spotify Plan?
Free
Do you have Spicetify installed?
No
ℹ Computer information
- Spotify: <IP_ADDRESS>6.g22820f93
- Windows: 7 Ultimate 64-Bit, Version 6.1 (Build 7601:Service Pack 1)
- PowerShell: 5.1.14409.2001

📝 Description
NET Framework 4.8 <<<< First installation step.
WMF 5.1 <<<< Second Istallation step.
Reboot your PC <<<< Third step.
https://raw.githack.com/amd64fox/SpotX/main/Install_Old_theme.bat <<<< Last installations step.
📸 Screenshots

Spotx does not affect authorization, make sure you enter your login and password correctly, or reset your current password

P.S.
other users also reported a similar error, but now manual login is working again, maybe it was a temporary glitch on the spotify servers


⚠ SolarOscp has degraded performance

In 814139f, SolarOscp ($SOLAROSCP_URL) experienced degraded performance:

HTTP code: 200
Response time: 284 ms

Resolved: SolarOscp performance has improved in f9a7c49 after 11 minutes.


Issue with Run Selection (F8)

Issue Type: Bug
If i use the Run Selection button or F8 system get a weird behavior, seems to but the break before the command is ran rather than after.  This issue only happening on Insider version of VS Code.
The 'Run Selected Text' works fine. Not sure if it is system or application configuration issue, moving to regular VS Code as this is critical feature.
https://ufile.io/f70wyxyh
VS Code version: Code - Insiders 1.64.0-insider (7b9e5c32a053669d4e72f998e4fa217090c32f59, 2021-12-22T05:15:28.225Z)
OS version: Windows_NT x64 10.0.22000
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz (8 x 2112)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.92GB (1.61GB free)

Process Argv
--crash-reporter-id 99fbcfbe-38f1-4f32-ab6d-15aaf52f2ecc

Screen Reader
no

VM
0%

Extensions (14)

Extension
Author (truncated)
Version

spellright
ban
3.0.60

armview
ben
0.4.5

terminal
for
0.0.10

azure-pipelines
ms-
1.195.0

python
ms-
2021.12.1559732655

vscode-pylance
ms-
2021.12.2

jupyter
ms-
2022.1.1001614873

jupyter-keymap
ms-
1.0.0

jupyter-renderers
ms-
1.0.4

remote-wsl
ms-
0.63.13

azure-account
ms-
0.9.11

powershell-preview
ms-
2021.12.0

spellchecker
swy
1.3.0

armviz
yte
0.0.9

A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492:30256197
pythontb:30258533
pythonvspyt551:30291412
pythonptprofiler:30281269
vsdfh931:30280409
vshan820:30294714
pythondataviewer:30285072
vscod805cf:30301675
pythonvspyt200:30323110
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
pythonvs932:30404738
vscop804:30404766
vscop453:30404998
vsclayoutctrc:30405799
py55gd98:30408621
vscexrecpromp3t1:30407758
azactmsalcf:30409288

What language are you trying to run?

What language are you trying to run?

Language is Powershell

Language is Powershell

/extPowershell

/extPowershell


THRIFT-5515: Oneway requests can stuck in TNonblockingServer with TSSLSocket.

TConnection::workSocket reads all pending oneway requests.
In this way it is possible to avoid that situation when the openssl reads all data, potentially contain more requests, from the socket receive buffer and the workSocket() won't be triggered again after the first request is processed.

Agree with @RandyAbernethy .
An additional comment: With the loop, the variables int got, left, sent and uint32_t fetch are not initialized again. I did not double-check that this is fine. @tkovacs-2 , did you check that they are always initialized to useful values in the loop? Otherwise, to be sure, move the declaration and initialization inside the loop?

Thank you for the comments.
The variables are my mistake, I put back them into the loop. Anyway they initialized later with valid values, so they would be ok even outside.

@RandyAbernethy @emmenlau
I have modified the PR according to your comments. Could you please review again?

LGTM


Build and upload package to PyPI on release

This pull request adds the GitHub Actions job to build and upload a source and binary distribution to PyPI. This is taken directly from the FLORIS repository. It runs after a GitHub Release is published. Note that this does not publish to conda-forge. However, users who leverage conda in their Python workflows can easily install from PyPI, but this is not true the other way around.
This functionality requires someone to be the admin of the PyPI listing. In order for this to complete successfully, the admin must provide their PyPI login information (username and password) via the GitHub Actions secrets.
This pull request addresses #19.

thank you, I'm happy to merge it asap!

I'm the PyPI admin


Make adjustments to cards components' designs

[ ] Add eyebrow to graphic promo card
[ ] Add hover state to multilink card. It's implemented but not documented in the designs: https://ilo-ui-twig.netlify.app/?path=/docs/components-cards-multilink-card--multilink-card
[ ] Do we need to document in the Components file how some components look and behave on mobile? This is related to this task: https://github.com/orgs/international-labour-organization/projects/2/views/4?pane=issue&itemId=46484833
[ ] Align cards components naming with Storybook

Everything is done @inesdgomes

Thanks @beatrizmartinmartins All good. Closing this ticket


UI: Tooltips

User feedback is important in a lot of areas of the app.
We could use tooltips just about everywhere that explain certain things, or show more relevant information.
For example:

[ ] Explain candidates, participants on creation
[ ] Let user know what ens isn't resolved on creation
[ ] What strategies are
[ ] Amount being distributed in wei (on TBD distribution view)
etc

Tooltip comments need to match the online documentation: taxonomy and verbiage.
Are candidates and participants, vote recipients and voters respectively?
Any text locations, in addition to https://hackmd.io/Vey-449hSdqNTPn2zQZaLQ

For clarity:
On Candidates, Participants:

Participants are voters (will be renamed to Voters)
Candidates are those that are being voted on
A candidate is not automatically a participant(voter)

Do I have to implement the tooltips that show messages on hover (demo) or the onboarding guide like here

On hover, outlined here: https://chakra-ui.com/docs/overlay/tooltip


TaxonomyPicker is hiding children when parent is Available for Tagging == false

Category
[ ] Enhancement
[x] Bug
[ ] Question
Version
3.15.0
Expected / Desired Behavior / Question
I have a term group:

Manufacturing is not available for tagging, as it is just a logic grouping, not an actual department
I would expect all terms to be displayed, and Manufacturing should be not-selectable
Observed Behavior
The terms under Manufacturing are not loaded/displayed
Steps to Reproduce
Find a 3 or more level term set, and toggle the Available For Tagging field on one of the not-leaf terms
Perhaps the code be updated to check if the term is a leaf before hiding it?

Can confirm that I have the same problem. Any updates on this issue?

@kasperbolarsen I changed and use ModernTaxonomyPicker instead and then it will work as expected

Hi @kasperbolarsen & @vofflan,
Did you get the chance to test with latest version (3.17.0)? I tried it and it's working as expected if I'm not wrong.
Configuration at site collection level:

Behavior of the TaxonomyPicker:

Behavior of the native column in a list:

Can you confirm on your side?

Hey Michael, I just checked and as far as I can tell the issue have been resolved :-)


bug

Request type

[x] Please close this issue, I accidentally submitted it without adding any details
[x] New documentation
[x] Correction or update

Details

Good


more shapes

Hi,
Can you also add more shape like:

square rounded
hexagon
pentagon
rhombus

Message for anyone also interested on this:
Please share some thoughts on this (implementations and valid uses cases)

Seems like this would be out of scope. If you decide to be the first person in the world that uses a rhombus shape for your avatars, you could always add an '.avatar-rhombus' class to it via the customStyling prop and then create your rhombus (or pentagon, or hexagon) shape via that css class in your stylesheet. I am not sure it needs to be hardcoded into the codebase.
I could see rounded square however, that one makes sense and is fairly common. But again, that can be done with css.


Unable to redirect SC4S:probe sourcetype in splunk_metadata.csv

The SC4S start-up HEC test outputs are sent to the sourcetype 'SC4S:probe' which by default goes to the main index.
The re-routing option to add the source key to splunk_metadata.csv, for example 'sc4s_probe,index,sectools' did not work, with the events just disappearing.

it doesn't seem to be fixed. I'm trying it right now with the latest version and I still can't get that data out of main.

i've been trying to redirect the probe log without success. I'm using "splunk_sc4s_probe,index,sc4s_logs" but it's not quite working. I'm using brand new v3.23.0 released just yesterday. What am I doing wrong?


Ruin Pokemon are immune to their own Ruin effects

It works correctly in PS, but isnt implemented in the damage calc. See this post https://www.smogon.com/forums/threads/pokémon-showdown-damage-calculator.3593546/post-9625220
This is my first time trying this, thankie in advance.

Thanks!


RDLC report paths in Mac OS vscode

Please include the following with each issue:
1. Describe the bug
Due to different symbol (backslash/forward slash) used for paths in Mac/Linux vs Windows - system doesn't recognize the path to report layout properly
2. To Reproduce
a) Create new extension in Windows environment.
b) Create folder Layouts in root folder
c) Create new report in root folder
d) Add reference to rdl: RDLCLayout = 'Layouts\MySuperReport.rdl';
e) Compile extention so default layout is automatically generated
f) Open same project in MacOS vscode and compile
3. Expected behavior
Should recognize path depending on environment and not creating additional layouts in root folder
Thank you

Use forward slash for directory separator to get cross platform compatibility.

The fix for this issue has been checked in to the master branch. It will be available in the bcinsider.azurecr.io/bcsandbox-master Docker image starting from platform build number 40066 and VS Code Extension Version 10.0.620088.
If you don’t have access to these images you need to become part of the Ready2Go program: aka.ms/readytogo
For more details on code branches and docker images please read:
https://blogs.msdn.microsoft.com/nav/2018/05/03/al-developer-previews-multiple-releases-and-github/
https://freddysblog.com/2020/06/25/working-with-artifacts/


notebook

jupyter notebook created, python script created, local development set, networkx installed

Should I make a new pull request?

Closing this as contribution period is over. Thanks!


Error on build, state is undefined

Hello!
First and foremost, thanks for this resource!
I've implemented this in my app and it's been working great while in development, but now when I try to build my project I'm having some troubles.
  53 |
  54 |   return (
> 55 |     <Menu state={state} menuNavigation={state.menuNavigation}>
     |                                               ^
  56 |       <Inner>
  57 |         <MenuLocal />
  58 |         <MenuGlobal />

  WebpackError: TypeError: Cannot read property 'menuNavigation' of undefined

Any idea for a fix?

Ok, so seems like passing initialState with usage of context is a quick and dirty fix
const state = useContext(GlobalStateContext) || { menuNavigation: 'closed' }
As per: https://github.com/gatsbyjs/gatsby/issues/12104#issuecomment-549983311


The recent change in the storage format of cache-manager-ioredis-yet may cause inconsistent behavior across different versions.

Describe the bug
See this commit: https://github.com/jaredwray/cacheable/commit/9647acf6669d1cf3ac6b446a70fbc6babddf50bc
In case of storing data in previous version of cache manager and retrieving data in newer version, the storage format is different and you get the wrong result.
This change might break the apps that uses this dependency and should be treated as a breaking change.
I suggest to revert this change. I don't know why there's v in the first place, but that's how it is right now, so we need to keep it. Especially if you're planning to deprecate it in a couple of months.
I'll stick to the older version for now.
How To Reproduce (best to provide workable code or tests!)

Install 2.0.3 version of cache-manager-ioredis-yet
Store a value using cacheManager.set()
Upgrade to 2.1.1
Retrieve a value using cacheManager.get()

It gives you a value in this format: {"v": <value>}.

If you don't mind, I'll create a new pull request for it.

@turastory thanks so much for the detailed bug report before you do the pool request. One thing I do want to let you know is that we will be switching over to using the keyv storage adapters in the near future, which might solve that issue completely.

Going to close this out and focus on this: https://github.com/jaredwray/cacheable/issues/766


hasRoot / isRoot crashes app

Hi! I've adapted example app to handle deeplink, but app crashes when trying to get current coordinator:
final class AppCoordinator: NavigationCoordinatable {
    var stack: Stinsen.NavigationStack<AppCoordinator>

    @Root var unauthenticated = makeUnauthenticated
    @Root var authenticated = makeAuthenticated

    init() {
        let user = User() // obtaining user from persistent store
        stack = NavigationStack(initial: \AppCoordinator.authenticated, user) // this is also handled by auth state listeners
    }

     func makeUnauthenticated() -> NavigationViewCoordinator<UnauthenticatedCoordinator> {
        NavigationViewCoordinator(UnauthenticatedCoordinator())
    }

    func makeAuthenticated(param user: User) -> NavigationViewCoordinator<MainCoordinator> {
        NavigationViewCoordinator(MainCoordinator(user: user)) // MainCoordinator is a simple navigaion view coordinator
    }

    func handleDynamicLink(_ url: URL) {
        guard let coordinator = self.hasRoot(\.authenticated) else { // <-- Crashes here.  self.isRoot(\.authenticated) causes the same crash
            return
        }
    }
}

Crash in NavigationCoordinatable.swift, line 661, col 21
Thread 1: Fatal error: Unexpectedly found nil while implicitly unwrapping an Optional value
Printing description of route:
<ReferenceWritableKeyPath<AppCoordinator, Transition<AppCoordinator, RootSwitch, User, NavigationViewCoordinator>>: 0x280687280>
Printing description of inputItem: nil
((input: App.User, comparator: ())?) inputItem = nil
Printing description of self:
<AppCoordinator: 0x283d59500>

App and coordination logic works perfectly, but this check on AppCoordinator level causes the crash.
It looks that unwraping
var root: NavigationRoot!
from NavigationStack (NavigationStack.swift, line 29) causes the crash. What is the reason for this crash and how to solve it?
Stinsen (2.0.7)
MacOS 12.6, XCode 14 Release, iOS 15-16

Hi, any updates here? Maybe there are other ways to check if we're currently presenting this screen? Or mark some routes as exclusive (may be showed only once at a time)


tensorflow 2.1 build error

Please make sure that this is a build/installation issue. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:build_template
System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): ubuntu 18.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: N/A
TensorFlow installed from (source or binary):  source 2.1
TensorFlow version: 2.1.0
Python version: 3.7.6
Installed using virtualenv? pip? conda?: N/A
Bazel version (if compiling from source): 0.29.1
GCC/Compiler version (if compiling from source): 7.4.0
CUDA/cuDNN version:  10.2/ 7.6.5
GPU model and memory: RTX2080Ti GDDR6 11GB

Describe the problem
Provide the exact sequence of commands / steps that you executed before running into the problem
bazel build //tensorflow/tools/pip_package:build_pip_packagee
Any other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.
ERROR: /home/wmind/repo/tensorflow/tensorflow/python/BUILD:1270:1: C++ compilation of rule '//tensorflow/python:_op_def_registry.so' failed (Exit 1)
In file included from bazel-out/k8-opt/bin/external/local_config_python/python_include/pybind11/pytypes.h:12:0,
                 from bazel-out/k8-opt/bin/external/local_config_python/python_include/pybind11/cast.h:13,
                 from bazel-out/k8-opt/bin/external/local_config_python/python_include/pybind11/attr.h:13,
                 from bazel-out/k8-opt/bin/external/local_config_python/python_include/pybind11/pybind11.h:44,
                 from ./tensorflow/python/lib/core/pybind11_status.h:21,
                 from tensorflow/python/framework/op_def_registry.cc:20:
bazel-out/k8-opt/bin/external/local_config_python/python_include/pybind11/detail/common.h:302:12: error: multiple definition of ‘enum class pybind11::return_value_policy’
 enum class return_value_policy : uint8_t {
            ^~~~~~~~~~~~~~~~~~~
In file included from external/pybind11/include/pybind11/pytypes.h:12:0,
                 from external/pybind11/include/pybind11/cast.h:13,
                 from external/pybind11/include/pybind11/attr.h:13,
                 from external/pybind11/include/pybind11/pybind11.h:49,
                 from tensorflow/python/framework/op_def_registry.cc:16:
external/pybind11/include/pybind11/detail/common.h:302:12: note: previous definition here
 enum class return_value_policy : uint8_t {
            ^~~~~~~~~~~~~~~~~~~
In file included from bazel-out/k8-opt/bin/external/local_config_python/python_include/pybind11/pytypes.h:12:0,
                 from bazel-out/k8-opt/bin/external/local_config_python/python_include/pybind11/cast.h:13,
                 from bazel-out/k8-opt/bin/external/local_config_python/python_include/pybind11/attr.h:13,
                 from bazel-out/k8-opt/bin/external/local_config_python/python_include/pybind11/pybind11.h:44,
                 from ./tensorflow/python/lib/core/pybind11_status.h:21,
                 from tensorflow/python/framework/op_def_registry.cc:20:
bazel-out/k8-opt/bin/external/local_config_python/python_include/pybind11/detail/common.h: In function ‘constexpr int pybind11::detail::log2(pybind11::size_t, int)’:
bazel-out/k8-opt/bin/external/local_config_python/python_include/pybind11/detail/common.h:355:29: error: redefinition of ‘constexpr int pybind11::detail::log2(pybind11::size_t, int)’
 inline static constexpr int log2(size_t n, int k = 0) { return (n <= 1) ? k : log2(n >> 1, k + 1); }
                             ^~~~
In file included from external/pybind11/include/pybind11/pytypes.h:12:0,
                 from external/pybind11/include/pybind11/cast.h:13,
                 from external/pybind11/include/pybind11/attr.h:13,
                 from external/pybind11/include/pybind11/pybind11.h:49,
                 from tensorflow/python/framework/op_def_registry.cc:16:
external/pybind11/include/pybind11/detail/common.h:355:29: note: ‘constexpr int pybind11::detail::log2(pybind11::size_t, int)’ previously defined here
 inline static constexpr int log2(size_t n, int k = 0) { return (n <= 1) ? k : log2(n >> 1, k + 1); }
                             ^~~~
In file included from bazel-out/k8-opt/bin/external/local_config_python/python_include/pybind11/pytypes.h:12:0,
                 from bazel-out/k8-opt/bin/external/local_config_python/python_include/pybind11/cast.h:13,
                 from bazel-out/k8-opt/bin/external/local_config_python/python_include/pybind11/attr.h:13,
                 from bazel-out/k8-opt/bin/external/local_config_python/python_include/pybind11/pybind11.h:44,
                 from ./tensorflow/python/lib/core/pybind11_status.h:21,
                 from tensorflow/python/framework/op_def_registry.cc:20:
bazel-out/k8-opt/bin/external/local_config_python/python_include/pybind11/detail/common.h: In function ‘constexpr pybind11::size_t pybind11::detail::size_in_ptrs(pybind11::size_t)’:
bazel-out/k8-opt/bin/external/local_config_python/python_include/pybind11/detail/common.h:358:32: error: redefinition of ‘constexpr pybind11::size_t pybind11::detail::size_in_ptrs(pybind11::size_t)’
 inline static constexpr size_t size_in_ptrs(size_t s) { return 1 + ((s - 1) >> log2(sizeof(void *))); }
                                ^~~~~~~~~~~~

error message is too long so I couldn't copy/paste all

no problem with windows 10 build...

is there any way I can get rid of k8-py2-opt compile? since I don't need py2....

Just to confirm, did you run configure.py with python3? Can you also make sure that you are building from the latest commit on r2.1 (the v2.1.0 tag)?

@mihaimaruseac
of course I've been doing this everytime rc come out...

I am seeing a very similar error to the one reported here, this time on macOS 10.15 with Xcode 11.3 clang
  exec env - \
    APPLE_SDK_PLATFORM=MacOSX \
    APPLE_SDK_VERSION_OVERRIDE=10.15 \
    PATH=/opt/local/bin:/opt/local/sbin:/bin:/sbin:/usr/bin:/usr/sbin \
    XCODE_VERSION_OVERRIDE=<IP_ADDRESS>C29 \
  external/local_config_cc/wrapped_clang '-D_FORTIFY_SOURCE=1' -fstack-protector -fcolor-diagnostics -Wall -Wthread-safety -Wself-assign -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG '-std=c++11' -iquote . -iquote bazel-out/host/bin -iquote external/com_google_absl -iquote bazel-out/host/bin/external/com_google_absl -iquote external/nsync -iquote bazel-out/host/bin/external/nsync -iquote external/eigen_archive -iquote bazel-out/host/bin/external/eigen_archive -iquote external/local_config_sycl -iquote bazel-out/host/bin/external/local_config_sycl -iquote external/com_googlesource_code_re2 -iquote bazel-out/host/bin/external/com_googlesource_code_re2 -iquote external/gif -iquote bazel-out/host/bin/external/gif -iquote external/libjpeg_turbo -iquote bazel-out/host/bin/external/libjpeg_turbo -iquote external/com_google_protobuf -iquote bazel-out/host/bin/external/com_google_protobuf -iquote external/farmhash_archive -iquote bazel-out/host/bin/external/farmhash_archive -iquote external/fft2d -iquote bazel-out/host/bin/external/fft2d -iquote external/highwayhash -iquote bazel-out/host/bin/external/highwayhash -iquote external/zlib_archive -iquote bazel-out/host/bin/external/zlib_archive -iquote external/local_config_python -iquote bazel-out/host/bin/external/local_config_python -iquote external/pybind11 -iquote bazel-out/host/bin/external/pybind11 -iquote external/mkl_darwin -iquote bazel-out/host/bin/external/mkl_darwin -iquote external/mkl_dnn -iquote bazel-out/host/bin/external/mkl_dnn -iquote external/bazel_tools -iquote bazel-out/host/bin/external/bazel_tools -isystem external/nsync/public -isystem bazel-out/host/bin/external/nsync/public -isystem third_party/eigen3/mkl_include -isystem bazel-out/host/bin/third_party/eigen3/mkl_include -isystem external/eigen_archive -isystem bazel-out/host/bin/external/eigen_archive -isystem external/gif -isystem bazel-out/host/bin/external/gif -isystem external/com_google_protobuf/src -isystem bazel-out/host/bin/external/com_google_protobuf/src -isystem external/farmhash_archive/src -isystem bazel-out/host/bin/external/farmhash_archive/src -isystem external/zlib_archive -isystem bazel-out/host/bin/external/zlib_archive -isystem external/local_config_python/python_include -isystem bazel-out/host/bin/external/local_config_python/python_include -isystem external/pybind11/include -isystem bazel-out/host/bin/external/pybind11/include -isystem external/mkl_darwin/include -isystem bazel-out/host/bin/external/mkl_darwin/include -isystem external/mkl_dnn/include -isystem bazel-out/host/bin/external/mkl_dnn/include -isystem external/mkl_dnn/src -isystem bazel-out/host/bin/external/mkl_dnn/src -isystem external/mkl_dnn/src/common -isystem bazel-out/host/bin/external/mkl_dnn/src/common -isystem external/mkl_dnn/src/cpu -isystem bazel-out/host/bin/external/mkl_dnn/src/cpu -isystem external/mkl_dnn/src/cpu/gemm -isystem bazel-out/host/bin/external/mkl_dnn/src/cpu/gemm -isystem external/mkl_dnn/src/cpu/xbyak -isystem bazel-out/host/bin/external/mkl_dnn/src/cpu/xbyak -MD -MF bazel-out/host/bin/tensorflow/python/_objs/_pywrap_transform_graph.so/transform_graph_wrapper.d -D__CLANG_SUPPORT_DYN_ANNOTATION__ -DEIGEN_MPL2_ONLY '-DEIGEN_MAX_ALIGN_BYTES=64' '-DEIGEN_HAS_TYPE_TRAITS=0' '-frandom-seed=bazel-out/host/bin/tensorflow/python/_objs/_pywrap_transform_graph.so/transform_graph_wrapper.o' -isysroot __BAZEL_XCODE_SDKROOT__ '-mmacosx-version-min=10.15' -g0 '-march=x86-64' -g0 '-std=c++14' -fexceptions '-fvisibility=hidden' -no-canonical-prefixes -Wno-builtin-macro-redefined '-D__DATE__="redacted"' '-D__TIMESTAMP__="redacted"' '-D__TIME__="redacted"' -c tensorflow/python/util/transform_graph_wrapper.cc -o bazel-out/host/bin/tensorflow/python/_objs/_pywrap_transform_graph.so/transform_graph_wrapper.o)
Execution platform: @bazel_tools//platforms:host_platform
In file included from tensorflow/python/util/transform_graph_wrapper.cc:22:
In file included from ./tensorflow/python/lib/core/pybind11_status.h:21:
In file included from bazel-out/host/bin/external/local_config_python/python_include/pybind11/pybind11.h:44:
In file included from bazel-out/host/bin/external/local_config_python/python_include/pybind11/attr.h:13:
In file included from bazel-out/host/bin/external/local_config_python/python_include/pybind11/cast.h:13:
In file included from bazel-out/host/bin/external/local_config_python/python_include/pybind11/pytypes.h:12:
bazel-out/host/bin/external/local_config_python/python_include/pybind11/detail/common.h:302:12: error: redefinition of 'return_value_policy'
enum class return_value_policy : uint8_t {
           ^
external/pybind11/include/pybind11/detail/common.h:302:12: note: previous definition is here
enum class return_value_policy : uint8_t {
           ^
In file included from tensorflow/python/util/transform_graph_wrapper.cc:22:
In file included from ./tensorflow/python/lib/core/pybind11_status.h:21:
In file included from bazel-out/host/bin/external/local_config_python/python_include/pybind11/pybind11.h:44:
In file included from bazel-out/host/bin/external/local_config_python/python_include/pybind11/attr.h:13:
In file included from bazel-out/host/bin/external/local_config_python/python_include/pybind11/cast.h:13:
In file included from bazel-out/host/bin/external/local_config_python/python_include/pybind11/pytypes.h:12:
bazel-out/host/bin/external/local_config_python/python_include/pybind11/detail/common.h:355:48: error: redefinition of default argument
inline static constexpr int log2(size_t n, int k = 0) { return (n <= 1) ? k : log2(n >> 1, k + 1); }
                                               ^   ~
external/pybind11/include/pybind11/detail/common.h:355:48: note: previous definition is here
inline static constexpr int log2(size_t n, int k = 0) { return (n <= 1) ? k : log2(n >> 1, k + 1); }
                                               ^   ~
In file included from tensorflow/python/util/transform_graph_wrapper.cc:22:
In file included from ./tensorflow/python/lib/core/pybind11_status.h:21:
In file included from bazel-out/host/bin/external/local_config_python/python_include/pybind11/pybind11.h:44:
In file included from bazel-out/host/bin/external/local_config_python/python_include/pybind11/attr.h:13:
In file included from bazel-out/host/bin/external/local_config_python/python_include/pybind11/cast.h:13:
In file included from bazel-out/host/bin/external/local_config_python/python_include/pybind11/pytypes.h:12:
bazel-out/host/bin/external/local_config_python/python_include/pybind11/detail/common.h:358:32: error: redefinition of 'size_in_ptrs'
inline static constexpr size_t size_in_ptrs(size_t s) { return 1 + ((s - 1) >> log2(sizeof(void *))); }
                               ^
external/pybind11/include/pybind11/detail/common.h:358:32: note: previous definition is here
inline static constexpr size_t size_in_ptrs(size_t s) { return 1 + ((s - 1) >> log2(sizeof(void *))); }
                               ^
In file included from tensorflow/python/util/transform_graph_wrapper.cc:22:
In file included from ./tensorflow/python/lib/core/pybind11_status.h:21:
In file included from bazel-out/host/bin/external/local_config_python/python_include/pybind11/pybind11.h:44:
In file included from bazel-out/host/bin/external/local_config_python/python_include/pybind11/attr.h:13:
In file included from bazel-out/host/bin/external/local_config_python/python_include/pybind11/cast.h:13:
In file included from bazel-out/host/bin/external/local_config_python/python_include/pybind11/pytypes.h:12:
bazel-out/host/bin/external/local_config_python/python_include/pybind11/detail/common.h:366:18: error: redefinition of 'instance_simple_holder_in_ptrs'
constexpr size_t instance_simple_holder_in_ptrs() {
                 ^
external/pybind11/include/pybind11/detail/common.h:366:18: note: previous definition is here
constexpr size_t instance_simple_holder_in_ptrs() {
                 ^
<snip>

issue appears to be due to two different locations for pybind11 being used.

successfully build image with latest master, closing


New activity class predict

This update is somewhat of a hybrid of both @daweidu's updates to the UHO module as well as my integration of it's use into the ROS2 node that makes use of it.

@daweidu Could you please take a look at what I've done in the prediction.py function predict? I would like you to tell me if what I am doing there is sensible or if there is anything that I am doing blatantly wrong. I think discovered some things that could be introspected from the network but I would like your insight of if what I am doing is inherently dangerous or something.


Add tests for gradle samples

Need to add a new check for samples using gradle to build.

Is it means that whenever we add an example we should add 2, one for maven and the other for gradle build?


Git Hygiene

Summary

Status: draft
RFCs: $\emptyset$
Categories: misc

Proposes CODEOWNERS and PR.md for git hygiene.
Core Software Components
N/A
Ancillary Software Components
N/A
Testing
N/A
Outstanding Issues

Any other templates we want to include? Issue template?

Updated. See if that's more to your liking.

I think you mean RD.

Pretty tough libssl linking bug. Starting to keep track of attempted solutions.

Generally, nix openssl.dev doesn't seem to work for Ubuntu x86_64. This messes up the client tests presumably because of the dynamic linking in Rust openssl-sys from the Aptos client.
Ultimately, I might need to do this to the nix flake: https://nixos.wiki/wiki/Rust
Current, I'm working off of this thread: https://github.com/sfackler/rust-openssl/issues/1663

@mzabaluev @musitdev @andyjsbell Going to merge to get a template in since we have a lot of activity at the moment.


Add tooling for rearranging the graph

[x] Inserting nodes on an edge (splitting an edge into two with a node in-between). Consider whether the existing edge properties should be mirrored to the two replacement edges, or if new values should be used.
[ ] Removing nodes - we can currently remove children nodes one-by-one, but I want to be able to specify a particular node and remove it, potentially with various strategies for how to handle its associated edges

[ ] 1. simply delete, potentially leaving a gap
[ ] 2. weld if there is only one parent and one child edge
[ ] 3. delete, and cascade-delete downward
[ ] 4. Others?

[ ] Moving the start/end of an edge to another node, with circular check
[ ] Copy a section of the graph

Also keen to be able to move nodes around and change relationships


rclone -m downloads.rclone.org: Add bin_dir to PATH if necessary

Closes #138.

I merged other PRs, could you please rebase so we could see clean CI run?

@yarikoptic Rebased.

appveyor remains red due to mac... pushed a commit to switch to macos-monterey, let's see

green -- let's proceed!


shadows-of-the-empire

Fixed Shadows Of The Empire Gamte Text

Thanks a ton for all of these fixes!  This is awesome!


The diff view does not currently support selecting source code files

I think it would be nice for the diff view to support selecting source code files. That way you can show two diffs side-by-side, one of the source, and one of the machine code generated. Otherwise you have to show two windows for the source file, and readers have to manually perform a diff.

See also #1211


GitHub Style Emoticons

Having been playing around with the GitHub emoticons on a project and work, Dan and I think these little graphical quirks of the interwebz adds a personality to otherwise dull communications.

Cleaning up old feature requests since this project is now unmaintained.


Loses focus when switching from another window

OS: OS X 10.11.1
Atom version: 1.1.0
Terminal-plus version: 0.14.0
Shell: fish 2.20
The bug:
Given I have a terminal-plus terminal opened and focused
when I switch to another window using cmd+tab
and I switch back to atom
then the focus is lost (I type in the keyboard and only the first character appears)

Fixed this. Expect it to work in the next release. You will have to restart Atom to see the change take effect.

Do you mean release 15? Do you have an idea of when to launch it?

Thanks for this good Atom package btw.

It will be in a patch (0.14.1) sometime soon after I fix several of the other issues that came up today.

Fixed as of v0.14.1


DeserializeFromFile and SerializeToFile

Would it be possible to have methods that accept a path to a file in order to serialize/deserialize to/from the file directly, or alternatively passing a Stream as a parameter...
It seems natural to me to have this on something that does serialization :)

Definitely... for v2 we actually have the serializer methods accept a stream.  Will that be sufficient?  Or do you think you'll need an extension method for file as well? I think the best approach is to keep it open to stream, and allow consumers to fill in implementation details such as file.  But definitely open to feedback around this. :)

For my purposes, that's plenty. Though I would suggest maybe keeping it inline with what XmlSerializer offers: Stream, TextReader/TextWriter and XmlReader/XmlWriter.

Getting an XmlWriter would make modifying the XML much easier for example. It's what I'm currently using to do the indentation.

Ah ok... TBH I am still confused between all the options in how XmlSerializer allows you to initialize.  I tried to dig into it but it seems as if they really do use all 3 of those.  If you know of any resources that explain why there are 3 (or know outright) I would be happy to check it them out.
We could create a Using(XmlWriter) method to the ConfigurationAPI.  Or maybe Using(()=>XmlWriter) as a new XmlWriter is created for each serialization.  The same could also be used for XmlReader, too.

OK with v2 mostly complete we can revisit this again.  We currently use stream, but the ask here is for text/xml reader/writer.  We do use a factory for creating xmlreader and xmlwriters.  You can see that here.
It would be easy enough to create a new serializer extension that creates a new implementation via use of the stream or otherwise.
So something like:
class XmlFactoryExtension : ISerializerExtension
	{
		public IServiceRepository Get(IServiceRepository parameter) => parameter.Register<IXmlFactory, MyFactory>();

		void ICommand<IServices>.Execute(IServices parameter) {}
	}

	class MyFactory : IXmlFactory
	{
		public IXmlWriter Create(Stream stream, object instance)
		{
			...
		}

		public IXmlReader Create(Stream stream)
		{
			...
		}
	}

Then using it as such:
var serializer = new ExtendedConfiguration().Extend(new XmlFactoryExtension()).Create();

I am hesitant to add more API surface than is required, as I myself find the different ways of creating a document/instance very confusing, but I am open to feedback as always.
How does this suggested approach look/work for everyone?

The ask here was for Serialize and Deserialize methods to accept other parameter types (namely those that are already supported by the default XmlSerializer - TextReader/TextWriter and XmlReader/XmlWriter).
Maybe I misunderstood it, but I think that what you suggested goes in a different direction and is more complicated to use than creating simple overloads for Serialize/Deserialize which accept those parameter types?

What kind of function I can do with it? I don't know if it is useful for users. There is some real example?

OK so it seems that this all really hinges on my ignorance around the connections between Xml/Text* and Stream, so you'll have to forgive me here.  Taking another peak, it appears you can create a System.Xml.XmlWriter by either a stream or TextWriter.  I think what I got caught up in was trying to find the actual implementation to where the stream was used (different matter altogether).
In any case, our current design is suboptimal.  It is currently as such:
public interface IExtendedXmlSerializer
{
	void Serialize(Stream stream, object instance);

	object Deserialize(Stream stream);
}

When it sounds like it should be this:
public interface IExtendedXmlSerializer
{
	void Serialize(System.Xml.XmlWriter stream, object instance);

	object Deserialize(System.Xml.XmlReader reader);
}

and a set of extension methods as such:
public static class Extensions
{
	public static void Serialize(this IExtendedXmlSerializer @this, Stream stream, object instance)
		=> @this.Serialize(System.Xml.XmlWriter.Create(stream), instance);

	public static void Serialize(this IExtendedXmlSerializer @this, TextWriter writer, object instance)
		=> @this.Serialize(System.Xml.XmlWriter.Create(writer), instance);

	public static object Deserialize(this IExtendedXmlSerializer @this, Stream stream)
		=> @this.Deserialize(XmlReader.Create(stream));

	public static object Deserialize(this IExtendedXmlSerializer @this, TextReader reader)
		=> @this.Deserialize(XmlReader.Create(reader));
}

How does that look, @FaustoNascimento?   That actually would not be too much work and I appreciate your patience/persistence in helping me to see this.  Especially since this could be a breaking change it's better to do it now before we actually release anything to Nuget. :)

@wojtpl2 this is actually a fundamental issue with the design as the lowest common denominator here is the System.Xml.XmlWriter/Reader.  It is sort of complicated by the fact that I originally designed it with it being format-agnostic, but I think it's pretty clear at this point that is something that is probably better for v3.
So something like this:
public interface ISerializer<TReader, TWriter>
{
	void Serialize(TWriter writer, object instance);

	object Deserialize(TReader reader);
}

public interface IExtendedXmlSerializer : ISerializer<System.Xml.XmlReader, System.Xml.XmlWriter> {}

Careful with creating a XmlWriter from a TextWriter - if I'm not mistaken, you cannot easily change the encoding used by the TextWriter and it defaults to UTF16, so the header of the XML will state it's encoded using UTF16, as oppose to UTF8 (I found this out the hard way, when I was trying to create an extension method for EXS to Serialize directly to file).
Instead of having extension methods, would it not be easier to create overloads?

Ah, it's definitely open to discussion, even for v3.  I will share my perspective and I would like to hear your thoughts on it.
From my view, my concern is always about exposing surface for any component that I write.  Not just for me, but for any consumers of that component.  Here is a good thread about this very issue that was encountered during the development of v2 (see point 2).
In that case we're talking about ~30 methods that can boiled down to a great deal less.  Here we're talking about the same thing, except in the opposite direction.  It's still taking from 2 to 6, but that means every implementor of that interface will have to create an implementation for each and every one of those methods each and every time.
Now in the case of some specialized knowledge of ensuring correct instantiation of objects, then that might change things a bit, but I would probably err on encapsulating that in a factory which is then called by the extension method.
I so guess the point is that for every method on the interface, maximum effort should be made to ensure that it isn't overlapping with other methods on that interface.  I am definitely open to discussion on this and would like to hear your thoughts about it.
Also, if you have any finalized code that you are using that you would suggest in instantiating an XmlWriter, I would be interested in that.  In fact I believe I saw some bug reports on the new Roslyn CPS project system for Visual Studio that was talking about the UTF16 issue.

I see, that makes sense.
About the code, what I've got is something very simple for my specific use case, just needed something quick and dirty, but you can gladly have it:
        public static void ToFile(this XmlDocument doc, string path)
        {
            using (var xmlTextWriter = new XmlTextWriter(path, new UTF8Encoding(false)))
            {
                xmlTextWriter.Formatting = Formatting.Indented;
                xmlTextWriter.IndentChar = '\t';
                xmlTextWriter.Indentation = 1;

                doc.Save(xmlTextWriter);
            }
        }

        public static T DeserializeFromFile<T>(this ExtendedXmlSerializer xmlSerializer, string path)
        {
            var xml = File.ReadAllText(path);
            return xmlSerializer.Deserialize<T>(xml);
        }

        public static void SerializeToFile(this ExtendedXmlSerializer xmlSerializer, object o, string path)
        {
            var xml = xmlSerializer.Serialize(o);
            var xmlDocument = new XmlDocument();

            xmlDocument.LoadXml(xml);
            xmlDocument.ToFile(path);
        }

Great!  I will look into it and let you know.

Alright, I have been checking this out.  A few questions for you, @FaustoNascimento:

Is there a reason for using new XmlTextWriter vs. System.Xml.XmlWriter.Create?
Are you aware of File.Create?  Using this, you could write to a file without the need of using XmlDocument.  Additionally, this is supported by .NETStandard1.6 while XmlTextWriter oddly isn't.
Looks like the code here is using a XmlTextWriter here and not a TextWriter, and wanted to verify.  I am interested in knowing if there was anything you landed on with the utf8 vs utf16 as a solution.  Or maybe you just ended up ditching TextWriter altogether?

After spending more time than I expected here, I'd also like to reiterate the drive/desire for simplicity.  I basically took about an hour (again LOL) of my time to try to wrap my mind around all the ways you can create an XmlWriter, and the associations/connections between all the components.  For instance, proper closing/disposing of each item (and wrapped item) and additionally with how XmlWriterSettings plays in with this (it doesn't when you use a new XmlTextWriter).
I think this was also another goal achieved by simply using Stream. Nonetheless, I see the value in exposing the root denominator here, especially if we have a strategy for keeping things simple via the proposed methods above.

Yes, it's called dumbness. Or as prefer to label it for myself... "lack of sleep". Not sure anyone will buy that though...
I think the reason why I used the XmlDocument here was simply because I was already using the XmlTextWriter so it sort of just fit in nicely.
If I recall correctly, I started with a TextWriter, but that's when the encoding issues occurred, so I just ditched it altogether.

There's no doubt that the code above can be improved, as I said not quite sure just how much of that is usable.

Ha, sounds good, @FaustoNascimento.  Thanks again for your contribution. 👍
So I went ahead and got in the extension methods.  You can now use Stream/Xml/Text/Writer/Reader with ExtendedXmlSerializer. 🎉
Unfortunately (or fortunately depending on your perspective), it did cover some issues with performance.  I will make a new issue for this.  Hopefully we can release a new pre-release soon so that you can try this out.  I will be closing this issue for now.  Please feel free to re-open/open a new issue if you have trouble with the features as designed.

Ah @FaustoNascimento looks like the latest version is deployed for better or for worse here if you'd like to try it out:
https://www.myget.org/feed/wojtpl2/package/nuget/ExtendedXmlSerializer


TAPAS finetune.

When TAPAS is fine-tuned, are the parameters of Bert fixed?

No, every parameter is tuned.

If I fix the parameters of Bert when TAPAS is fine-tuned,  how the dev accuracy should be on WTQ?

No idea, but probably very low since most of the parameters are in the Bert model (there is only one additional matrix for the token logits).

Thanks!


Added dotfiles in working directory

Official Documentation:
https://mercurial.selenic.com/wiki/FileFormats#Files_in_the_working_directory
https://mercurial.selenic.com/wiki/Subrepository
The specification for the .hg/ folder is simplified, see:
https://stackoverflow.com/a/15057742

@damadmai this all seems straight-forward. Thanks for the additional links!