Inhibit the dismissal of the popover when a select option is clicked.

The pointer event point is 0,0 when a select option contained within the popover is clicked.  Inhibit the dismissal of the popover based on this.

+1


Fix archival config for docker

Coverage decreased (-0.04%) to 69.861% when pulling bf41f2a8ed8acef14e9e78c43c00d1d7b796a921 on yycptt:fix-archival-docker into a2ff1e2ccd355df3b2d52003e6a194dcaddb700b on uber:master.


Remove version: Bitnami.Drupal version 9.4.7-0

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://downloads.bitnami.com/files/stacks/drupal/9.4.7-0/bitnami-drupal-9.4.7-0-windows-x64-installer.exe
OK
(Automated message - build 910)

Version still available.


Lacks an option to choose the column on which the table join will be based.

Lacks an option to choose the column on which the table join will be based in the Aggregate tool.
This option may be added by adding a "base table" where the column on which the table join will be based or asking for this column when the Aggregate button is hit.

The column name can be selected through a dialog after clicking the aggregate button (see #23 ).


HPACK test case 5.2.3 is wrong

Please correct me if I'm wrong, but I believe that test is not sending an EOS anywhere.
It sends a HEADERS frame with the following header representation in it:
"\x00\x85\xf2\xb2\x4a\x87\xff\xff\xff\xfd\x25\x42\x7f"

That decodes as:

0x00 - Literal Header Field Representation without Indexing - New Name
0x85 - Header name has 5 octets and is Huffman encoded
(0xf2, 0xb2, 0x4a, 0x87, 0xff) decodes as "x-tes9". More specifically:

x      -      t     e    s     9      *
11110010 10110010 01001010 10000111 11111111

Where * marks the beginning of padding.
So nothing wrong in the header name (except that it decodes as "x-tes9" instead of "x-test" as it says in the comment.
Moving on to the header value, it is encoded as a Huffman-encoded 622462-octet sequence, which is clearly incomplete.
I think the sequence "\xff\xff\xff\xfd" in the input data was meant to encode the EOS symbol, but that's not what's happening in that test.

This is the test description:
Desc:        "Sends a Huffman-encoded string literal representation containing the EOS symbol",
Requirement: "The endpoint MUST treat this as a decoding error.",

Looks like it should be sending an (invalid) EOS and checking the server signals an error.

Ah, sorry, I see what you mean now. It seems the name length is wrong.

Thank you for the report!
You are correct. This encoded string is wrong and fixed in ce109b0.


fix: add some spaces after pageinfo

What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area documentation
What this PR does / why we need it:
This PR fixes the rendering of some yaml blocks
Which issue(s) this PR fixes:
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Andreagit97
Once this PR has been reviewed and has the lgtm label, please assign vjjmiras for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

content/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, jasondellaluce
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

content/OWNERS [jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: b5c4daec0c9e070cbee616be5e2d0a556b305304


Plugin serverless-pre-function function不可编辑

Plugin serverless-pre-function function不可编辑

It's caused by unset value type, welcome PR.

related issue https://github.com/apache/incubator-apisix-dashboard/issues/36

would be fixed #188


Add support for commitCharacters property

Is your feature request related to a problem? Please describe.
Currently all snippets auto-expanded. This is useful. But sometimes I do not need expansion, for example:
object.my_function(argument1, argument2);

If I want to change my_function I can't use completion because it will be expanded automatically and I will have something like the following:
object.another_function(snippet_argument1, snippet_argument2)(argument1, argument2);

Describe the solution you'd like
So, I suggest to make this behavior more smart. For example, do not expand function if next symbol is not a space. This is how it works in most IDE's. The LSP spec has the CompletionItem#commitCharacters that is the same concept. I have a discussion with @hrsh7th an he says that such thing need to be implemented in completion or LSP engine.
Describe alternatives you've considered
There was an attempt for a manual check for a next character, but it causes conflicts with autopair-like plugins :(

Hmm I've looked into it and it might be harder to implement this than I initially thought, cause If the snippets are not expand it's just a bunch of junk words ( like object.my_function(v:argument1, v:argument2). So if I want to support this I should trim words in the completion stage.

Maybe snippet plugin should provide an API to access to unexpanded words?

I'll try doing that in #131. Hopefully we can get a good solution:)

You meant #132, not #131, right?
Looks very cool! Let me test it :)

Ah yeah sorry for the mistype😥😥

@Shatur95 Do you know which lsp have commitCharacter support? I try to check with several lsp I know but seems most of them doesn't support that.

It looks like this feature was added to clangd recently. But If I understand correctly, this will be available only in nightly version :(

Hm... I searched the server that supports commitCharacters but found the few servers only.
I can provide disable_automatic_expansion flag to vsnip.
The completion-nvim handle CompleteDone by itself so when this flag enabled, the snippet will be expanded only when the user press <CR>.

But completion-nvim has already removed vsnip-integ's autocmd, so it should be....

@hrsh7th That's already the expected behavior in completion-nvim because I think if I handle completeDone by myself i don't need the autocommands.
@Shatur95 That's fine, I'll look into the nightly version.

@hrsh7th I do have something I wanna ask you, is there a way to get the word without snippets placeholders in LSP? For example I want to get object.my_function instead of object.my_function(v:argument1, v:argument2). Right now I manually trims the snippets placeholder but it doesn't seem very smart.

In my knowledge, Many LSP client does it via trimming insertText.
So I think current approach is not bad.
But my own solution is different a bit (Actually, I have my own LSP client 😅.
My solution is using CompletionItem.label as v:completed_item.word when CompletionItem's insertTextFormat is snippet.
Sorry, I don't know which solution is reasonable in LSP spec.

My solution is here.
coc.nvim's solution is maybe here.

@hrsh7th That's very helpful! Thanks a lot for the information😉

I think this problem exists only in vim because VSCode has no inserting v:completed_item.word when the user chooses a candidate.
So we have to consider how to solve it by ourselves maybe...

Another question here, so the commitCharacters is the characters that will allow snippets expansion, am I correct? Cause when I look into the allcommitCharacters in clangd it's defined as allCommitCharacters = " \t()[]{}<>:;,+-/*%^&#?.=\"'|". I don't think it help solving @Shatur95 issue if it is....

Strange...
Maybe the commitCharacters is the characters that use smart expansion?..
In QtCreator window->a|() (where | is cursor) becomes window->addWidget(|) after completion.

Hmm then that make the " " and "\t" a little weird...Also I look at the spec here but still not quite get what's the purpose of it..

Oh, I'm sorry. I think that commitCharacters not related to my suggestion. This is just a characters that will trigger completion when pressed. Here is the explanation.

Okay then I think I can make a custom option for that, something like completion_expandCharacters and you can define it as " \t)>}", it should resolve this issue.

Yes, I think this will be the best way.

Closed by #151.


[2.11] "Oberved a panic" on Upgrade to 2.10.0

forwardport of #48180

Verified on v2.11-head ID: 9b44650 ✅
Test Cases (All are upgrades from v2.9.3 -> v2.11-head and were run on docker single node and HA clusters):

Basic Auth | Regular ASCII Characters ✅
Basic Auth | Non-ASCII Characters ✅
SAML | Regular ASCII Characters ✅
SAML | Non-ASCII Characters ✅
OAuth | Regular ASCII Characters ✅
OAuth | Non-ASCII Characters ✅

The PR only made changes to local auth from the looks of it, but I went ahead and tested SAML and OAuth just to be sure that other providers aren't affected.


Buzoesti village from Buzoesti is not found in Arges county

Precondition
SOLR: http://zimbor.go.ro/solr/#/romania/query
browser: Chrome
Steps to Reproduce:

Step
Action
Expected
Status

1
open SOLR in browser
SOLR UI is loaded without any errors
Pass

2
type one by one in the q field all the list of the components of every village in Arges county found in test data
you are able to type one by one in the q field  all the list of the components of every village in Arges county found in test data
Pass

3
type judet: Arges in the fq field
you are able to type judet:Arges in the fq field
Pass

4
click on Execute Query button
Verify that all the list of the components of every village in judet:Arges form the test data are displayedTest data.xlsx
Fail

Actual Results:
Buzoesti village from Buzoesti is not found in Arges county

https://orase.testquality.com defect D36.


Border-Color properties acting strangely based on the amount of CSS properties on the element.

glamorous version: 1.0.1

Relevant code or config. Or even better, [a reproduction][help-pen]
https://codesandbox.io/s/48EKDv5wg
What you did:
Was testing compatibility with polished (polished.js.org) and came across a strange bug with border-colors.
Problem description:
It seems to only set one of the directional properties properly while setting the remaining to initial.
As seen here: http://d.pr/i/7ng6/53ZbyvnT
Adding properties after the border-color properties affects which property is set properly, until adding enough eventually means all are set to initial. Move the border-color declarations to the top and they all work.
This happens with both the camelCased versions of the property names as well as the hyphenated versions, with or without polished.

Thanks for this! Is this an issue with glamor? Or is it just glamorous with this issue?

Possibly related: https://github.com/threepointone/glamor/issues/226

Same issue if you just use glamor alone. See here: https://codesandbox.io/s/qY3G75453

Thanks @paulmolluzzo. Considering this is a glamor issue and not glamorous-specific, I'm going to go ahead and close this in favor of that issue. Thanks for bringing it up. I hope we can work together to get it resolved. Interesting discussion going on threepointone/glamor#226


https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Your_first_WebExtension

Request type

[ ] Please close this issue, I accidentally submitted it without adding any details
[ ] New documentation
[x] Correction or update

Details

PAGE:
Your first extension
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Your_first_WebExtension
TEXT:
Create a new directory and navigate to it:
mkdir borderify
cd borderify
PROBLEM:
This page doesn't tell the reader, where to type these two commands. Is it inside the browser's address bar? No one knows, and there seems to be no other page that has that important key information. I want to learn to write extensions, but this missing information makes it impossible, for now.

They are common terminal/command line commands. I've updated the test to make this clear.


Fix text formatting in guide

Capitalized a letter in a section title to match surrounding formatting and added a missing "is".

[x ] I have read freeCodeCamp's contribution guidelines.
[x ] My pull request has a descriptive title (not a vague title like Update index.md)
[x ] My pull request targets the master branch of freeCodeCamp.
[x ] None of my changes are plagiarized from another source without proper attribution.
[ x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

@3CatMax Thanks for your patience. These all look like solid improvements.
There are a lot of merge conflicts here - could you fix them and open a new pull request? Also, there are a lot of commits here - including commits by other contributors. Could you make fewer commits to keep it a little easier to understand the file history?


Any idea why this URL won't work?

https://pointieststick.com/feed
It's valid xml but it's sent as a file I guess by WordPress.

Add a trailing "/" to your feed url, i.e. "https://pointieststick.com/feed/". Without the trailing "/", the site is returning a 301-redirect response to https://pointieststick.com/feed/

Please do a git pull, and try again. I've now added basic support to handle 301/302 responses (it'll try the redirected-to url instead).

Working now with the / I think the redirect still had some issues. But adding the / solved it.


Indexing prior history

Prior to installing hishtory, my zsh history was stored in $HISTFILE. Is there an existing tool to do a one time index of that into hishtory.db?

Yes! Just do cat $HISTFILE | hishtory import to import it. This generally happens by default, but if you have a non-standard HISTFILE it currently won't work (though I will fix that).

Just checked, and it should have respected HISTFILE for zsh, did it not? Though I realized that it didn't respect it for bash which I fixed in 6ded150.

Marking as closed. Please reopen if you're still running into this or have any other issues.

@ddworken I appreciate the details and added documentation,  but it still doesn't work, even after the manual import. See the following screenshot:

Any suggestions on how to debug?

Can you execute PRAGMA journal_mode = WAL; in sqlite and then re-run the SELECT count(*) FROM history_entries? I suspect that the history entries were imported, but they just weren't ever checkpointed. If that doesn't show all of them, can you run hishtory export | wc -l?

No luck unfortunately

re: importing: Thanks! I'm still looking into this.
re: ZDOTDIR: Thank you for pointing this out! I filed #29 to track this and will absolutely get this fixed.

@ddworken Do you have any updates regarding indexing prior history?


FkuentD/td-agent as Log Aggregator in active-active configuration for 2, 3,.. nodes is possible?

fluentd or td-agent version.
td-agent-2.3.6-0.el7.x86_64

Environment information, e.g. OS.
CentOS Linux release 7.3.1611 (Core)

Your configuration.

Your problem explanation. If you have an error logs, write it together.

Is there a way of configuring 2 nodes as log aggregators with FluentD in active-active configuration?

https://docs.fluentd.org/v1.0/articles/high-availability may help you.
And don't use github issue for quesiton. Please follow guideline.
Please consider to send your question into community slack or Mailing List first.

Already did this, thank you and sorry.


Fix function comments based on best practices from Effective Go

Hi, we updated some exported function comments based on best practices from Effective Go. It’s admittedly a relatively minor fix up. Does this help you?

Small but useful PR, guess these functions got renamed at some point and the comments didn't get changed to match. Thank you :)


chore: release main

:robot: I have created a release beep boop
biblo: 0.4.5
0.4.5 (2022-11-28)
Bug Fixes

Build example (80b2046)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/larsmunkholm/biblo/releases/tag/biblo-v0.4.5 :sunflower:


fix: remove hardcoded provider version in module

Learned about moving the provider outside the module.
Provider version is now controlled by the consumer.
See examples.

:tada: This PR is included in version 1.0.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Currency format for trailing zeros?

Is it possible to add trailing zeros for a currency such as GBP?
If I use this mask:
const mask = createNumberMask({
prefix: ["£", " "],
delimiter: ",",
separator: ".",
precision: 2,
});
With a value of £12 I want it to be displayed as £12.00
How do I go about changing the mask or creating my own to do this?

@zaura-payments try this: https://github.com/CaioQuirinoMedeiros/react-native-currency-input

@zaura-payments try this: https://github.com/CaioQuirinoMedeiros/react-native-currency-input

This is great thanks! Is there any way I can shift the blinking indicator over to the left more? Even if I have to change the code directly?

It's not possible with that component


How to implement  this solution

i want to implement you solution to my BBB server to protect the recordings from being accessed without permission  but im new in this field, can you walk me through how to implement it, where to put the files ?

I currently do not really have the resources to provide consulting. But I will put "Update documentation" on my todo, and will also throw in some more pointers to reading resources etc.; Probably somewhen later today.

Hi IchDasIch,
Approximate guideline/instructions how to implement your solution would be amazing!
Thank you for your time & helping out hundreds of users who are concerned about security.

Git clone the latest greenlite IchDasIch fork
git clone -b custom-v26a https://github.com/ichdasich/greenlight.git

Compile it with docker / run it - follow the Customize install instructions from BBB page

Git clone rec-perm
git clone https://github.com/ichdasich/bbb-rec-perm

Install fcgiwrap if it's missing
apt-get install fcgiwrap

Install bcrypt
apt-get install python3-bcrypt

If you are using out of the box bbb without scalelite - you only need auth-passwd-bbb.py (rename it to auth.py)
Edit the auth.py script as suggested by anrxc in the other issue posted.
Edit you postgresql password to reflect .env file in /root/greenlight/ - out of the box "password" with lower case.

  Forwards requests
  # to Red5 on port 5080
  location ~ (/open/|/close/|/idle/|/send/|/fcs/) {
      proxy_pass         http://<IP_ADDRESS>:5080;
      proxy_redirect     off;
      proxy_set_header   X-Forwarded-For   $proxy_add_x_forwarded_for;

      client_max_body_size       10m;
      client_body_buffer_size    128k;

      proxy_connect_timeout      90;
      proxy_send_timeout         90;
      proxy_read_timeout         90;

      proxy_buffering            off;
      keepalive_requests<PHONE_NUMBER>;
  }

  # Handle desktop sharing tunneling.  Forwards
  # requests to Red5 on port 5080.
  location /deskshare {
       proxy_pass         http://<IP_ADDRESS>:5080;
       proxy_redirect     default;
       proxy_set_header   X-Forwarded-For   $proxy_add_x_forwarded_for;
       client_max_body_size       10m;
       client_body_buffer_size    128k;
       proxy_connect_timeout      90;
       proxy_send_timeout         90;
       proxy_read_timeout         90;
       proxy_buffer_size          4k;
       proxy_buffers              4 32k;
       proxy_busy_buffers_size    64k;
       proxy_temp_file_write_size 64k;
       include    fastcgi_params;
   }

   # BigBlueButton landing page.
   location / {
      root   /var/www/bigbluebutton-default;
      index  index.html index.htm;
      expires 1m;
    }

    # Include specific rules for record and playback
    include /etc/bigbluebutton/nginx/*.nginx;

    #error_page  404  /404.html;

    # Redirect server error pages to the static page /50x.html
    #
    error_page   500 502 503 504  /index.html;
    location = /index.html {
            root   /var/www/html/bbb-rec-perm/error-page/;
    }

ssl_certificate /etc/letsencrypt/live/subdomain.domain.com/fullchain.pem; # managed by Certbot
ssl_certificate_key /etc/letsencrypt/live/subdomain.domain.com/privkey.pem; # managed by Certbot
include /etc/letsencrypt/options-ssl-nginx.conf; # managed by Certbot
ssl_dhparam /etc/letsencrypt/ssl-dhparams.pem; # managed by Certbot

location = / {
return 307 /b;
}
}
server {
if ($host = subdomain.domain.com) {
return 301 https://$host$request_uri;
} # managed by Certbot
listen   80;
listen [::]:80;
server_name subdomain.domain.com;
server_name localhost;
return 404; # managed by Certbot

root /var/www/html;

location /gl-auth/auth.py {
            gzip off;
            root  /var/www/html/gl-auth;
            fastcgi_pass  unix:/var/run/fcgiwrap.socket;
            include /etc/nginx/fastcgi_params;
            fastcgi_param DOCUMENT_ROOT  /var/www/html/gl-auth/;
            fastcgi_param SCRIPT_FILENAME  /var/www/html/gl-auth/auth.py;
 }

}
`

Replace BBB.nginx files in /etc/bigbluebutton/nginx
cp /bbb-rec-perm/nginx-conf/etc/bigbluebutton/nginx/* /etc/bigbluebutton/nginx

Edit your path to error page in these files

Thank you for the great script!

uhm, whatever you do, do not use the custom-26a/custom-changes; These have changes specific to my infrastructure/setup. ;-)
You should use https://github.com/ichdasich/greenlight/tree/rec_restrictions and merge that with the current upstream branch you want to use. I will update that branch to the current tag in a bit.
Apart from that: Mind if I use the documentation you just wrote in README.md?

Sure, go ahead.

Added documentation. Closing this. Thanks again!


[BUG] Memory issues with large video datasets

When working on the deepfake blog post I loaded a dataset of around 400 videos each a few seconds long.
Everything ran smoothly at first but after applying a few filters and loading a couple of different views in the app, the memory usage of FiftyOne kept increasing up to the limit of my laptop. It was using about 13 of my 16 gb of RAM.
I'm assuming video examples in the grid view are being loaded into memory and never removed. Whatever it is, it made it really difficult to work with the data because I had to restart FiftyOne every few minutes to clear my memory.

I can certainly reproduce this. Beginning my investigations...

Resolved in part by #681, specifically https://github.com/voxel51/fiftyone/commit/16f5887458ae855aa664f1533e9170394f3591f0.
Updating the view or dataset will now "clear out" the memory usage. Though, I think this issue should not be closed until the grid is virtualized and it is not within the users control to cause memory issues (by continuing to scroll).

Any news about this? I'm having a similar problem with a large image dataset.
The app is running on a remote server, images are pretty big (3k resolution on average) and there are about 1500 samples. The app works ok at first, but after applying even just one filter and scrolling a bit the browser the memory usage of increases up to the limit (16 GB in this case as well), giving an out of memory error.

Hi @diegochine. I want resolve this in the next week or two.

This was resolved by Flashlight. See #1459 for issues with large media (dimensions).


Corrige build

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 30.079%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1762

Relevant Lines:
5858

💛  - Coveralls


add devcontainer config

Please add a short guide in the READ.me how to install the Remote Development extension pack and how to use it.
After that we can merge this PR.


Add spending logic

Add circuit and smart contract logic for spending reputation. This should be a single proof that updates two leaves in the epoch tree. (adding negRep to the spender, adding posRep/negRep to the receiver).

@vimwitch is this issue duplicated from the V2 epic?

@vimwitch @ChialiT @vivianjeng
Hi,I would like to work on this issue.
So could you tell me detail about "spending reputation"?

@vimwitch @ChialiT @vivianjeng Hi,I would like to work on this issue. So could you tell me detail about "spending reputation"?

There is an epoch tree that stores hash(epochKey, data)
and spend reputation is to make one epoch key data increases and another epoch key data decreases
e.g.
A want to spend rep 3 and give it to B
we need to compute

A has data[0]-data[1] >= 3 rep
A's epoch key is epk_A
epk_A has data_A in epoch tree
epk_B has data_B in epoch tree
compute the previous epoch tree root
update data data_A[0]-3, data_B[0]+3
compute the updated epoch tree root

and if epk_A and epk_B is not in epoch tree before, then insert a new leaf in the epoch tree
then the smart contract should check that epk_A and epk_B are really not in the epoch tree

@vivianjeng
OK, Thank you for your polite response !
I'll try this !

@sorag20 thank you as well~
In this case, I think you will need a verifierHelper to verify the spend rep proof
e.g. https://github.com/Unirep/Unirep/pull/549 (still WIP)
the verifier helper should be able to read the Unirep.sol and check if the state is correct

@vivianjeng
I understand. thank you!


There is no way to apply config to implicit code

When a text paragraph is indented, it is implicit code. The code language is Raku, which is the default for implicit code.
There is no way to apply a config statement to implicit code, eg. to change the default to RakuDoc.
I suggest defining a builtin block 'implicit-code'. This behaviour is consistent with defining a =para block to have the same effect as an unmarked paragraph of text. But it allows for a =config to be applied.
Here is normal text
    This is implicit code

=implicit-code This is the same as implicit code above

=para This is normal paragraph defined with a block

Afaik an implicit code block doesn't have any config, so no :lang<raku>.  A renderer however may decide to assume :lang<raku>.

So an alternative to my suggestion here would be to make it explicit that any config
for code is applied to implicit code in the block scope.

This would be my strong preference.
I always envisaged that an implicit indented block
was exactly equivalent to an explicit code block.
So it makes sense to me that any active =config code
should apply equally to all implicit code blocks as well.
If we want anything other than that, then we should probably
stop calling them "implicit code blocks".

I'll raise a PR to make it explicit that =config code affects all implicit code within the block scope

changed with commit 804d3f4. Closed as resolved


Fix go mod

Current go mod file does not compile #688 (I am actually unsure how it managed to get merged in the first place, maybe caused by our CI being 1.20 rather than 1.22).
Latest experimental package requires golang.org/x/tools v0.16.0, which removed a module required by govulncheck.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b2e8e85) 78.86% compared to head (4698b3a) 78.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #691      +/-   ##
==========================================
- Coverage   78.86%   78.34%   -0.53%
==========================================
  Files          84       84
  Lines        5943     5943
==========================================
- Hits         4687     4656      -31
- Misses       1054     1084      +30
- Partials      202      203       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


pretrained SceneFlow model

Hi,
Please if can provide me the pretrained SceneFlow checkpoint file " pretrained.ckpt".
I will be very thankful to you.
Thanks in advance.

Updated.

Thank you so much.


pythonPackages.datasette: init at 0.27

Motivation for this change
Inspired by pycon talk about web server for sqlite databases
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build python3Packages.datasette python3Packages.csvc-to-sqlite

nix review passes
Result of nix-review pr 61085 1

12 package were build:

csvs-to-sqlite (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
datasette (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
python27Packages.csvs-to-sqlite (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
python27Packages.httptools (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
python27Packages.py-lru-cache (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
python27Packages.pytest-sugar (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
python37Packages.httptools (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
python37Packages.py-lru-cache (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
python37Packages.pytest-sanic (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
python37Packages.pytest-sugar (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
python37Packages.sanic (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
python37Packages.uvloop (python37Packages.csvs-to-sqlite ,python37Packages.datasette)

Would you be able to shuffle the order of the commits so that the dependent packages come after their dependencies? This way there aren't any "broken" intermediary commit states, which makes bisecting nicer for everyone.

(nox-review builds for me, executables basically work, non-nixos linux x86_64)

Sorry for the delay, looks good. Thanks @costrouc, @risicle


Added link to the official documentation in the README

Included a link to the official documentation page in this repo's README, and it contains a brief note on what the documentation contains. (I'm not sure if this is necessary, ofc feel free to remove if needed).
Thanks! :D

The new navbar looks like this:

I tried adding a GitHub config name as repo_url to the mkdocs.yml but it only seems to link to the documentation of the repo, not the repo itself, as shown in the RHS below:

Let me know what you think :D

@silvia-odwyer I am good with the first one.
mkdocs theme is updated so now adding repo_url add a link to edit the repo's documentation.

@silvia-odwyer Thank you


[Feature] Add comment detail

Description
Add comment detail
Are you aware of any blockers that must be resolved before implementing this feature? If so, which? Link to any relevant GitHub issues.
No response
Some information to help us out

[X] Tick this box if you plan on implementing this feature yourself.
[X] I have searched the issue tracker to make sure this issue is not a duplicate.

Solve comment detail

Hey @LuckyToFortune
Could you add a bit more context about what you mean?
Thanks


CI: enabling link checker

Please ensure your pull request adheres to the following guidelines:

[x] For first time contributors, read Submitting a pull request
[ ] All code is covered by unit and/or runtime tests where feasible.
[x] All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.
[x] If your commit description contains a Fixes: <commit-id> tag, then
please add the commit author[s] as reviewer[s] to this issue.
[x] All commits are signed off. See the section Developer’s Certificate of Origin
[x] Provide a title or release-note blurb suitable for the release notes.
[ ] Are you a user of Cilium? Please add yourself to the Users doc
[ ] Thanks for contributing!

Enabling the link checker for the CI.

There is know issue of warning: Circular inclusion in the include directive example: WARNING: circular inclusion in "include" directive. Not able to find the circular inclusion in the docs files. There is an open issue on the same : https://github.com/sphinx-doc/sphinx/issues/10951
myst not able to parse the #anchor in the Documentation. example: 'myst' reference target not found. This has been disabled using the ref.myst in the suppress_warning for sphinx.
Note: This is dependent on merge of PR: https://github.com/cilium/cilium/issues/10601 to make sure CI passes

ci: Enable link checker to ensure that all links in documentation are valid

Fixes: #10601

The change looks good, now we need to see how it looks like in practice in the CI:

How long does the workflow take to run (I can already notice it's longer than usual, it's becoming one of the longest among workflows that are triggered automatically)
How well does it work, in particular, can it validate all links or does it hit some rate limiting (which is likely, especially if several instances of the workflow run in parallel on different PRs)
How stable it is, meaning, does it fail often to validate a link because of external error - We'll need to run the workflow several times to get an idea.

Turning to draft given it's blocked on https://github.com/cilium/cilium/pull/26880 for now.

Documentation workflow took 11 minutes to complete. I hope it gets faster once more links are fixed and it doesn't have to wait for timeouts.

@qmonnet Need some help regarding fixing the issue:
warning: Circular inclusion in the include directive example: WARNING: circular inclusion in "include" directive. " I don't see any circular inclusion.

I went through the issues in the docutils and found this: https://sourceforge.net/p/docutils/bugs/459/ . It seems to have been resolved in version 0.18 of docutils  and only exixts in version 0.17.
I tried upgrading the version of docutils and see if the relevant packages dependencies could be resolved, but the pip -r time out due to maxdepth reached while resolving dependencies.

I'm not sure we can update to Docutils 0.18 yet, last time I checked we were still stuck with some dependencies on 0.17 somewhere. Possibly for the theme, I don't think we've rebased our fork on top of https://github.com/readthedocs/sphinx_rtd_theme/pull/1304 yet.
If it's just dependent on 0.17, let's filter out this warning with a comment in the script telling to remove it after we've upgraded to a newer docutils version?

@qmonnet So i updated the PR.

Enabled the link checker: Had to make tls_verify as false since the SSL certificates verification for a one site was failing. We might need to add cert as a part of other PR.
Fixed few broken links as a part of different commit.

The issue which is happening is 429 too many request error from the requests. As we would be running this a lot(for each PR) the chances of throttling increases(current failure in the checks).

@qmonnet So i updated the PR.
1. Enabled the link checker: Had to make `tls_verify` as false since the SSL certificates verification for a one site was failing. We might need to add cert as a part of other PR.

OK, I think we can live with that. Out of curiosity, what link is it?

2. Fixed few broken links as a part of different commit.

Cool, thanks!

The issue which is happening is 429 too many request error from the requests. As we would be running this a lot(for each PR) the chances of throttling increases(current failure in the checks).

That's annoying :confused:.  Although it will be painful if the workflow takes too long.
Thinking again about the checks, I'm not sure it makes sense to run it on every PR. When authors add new links, the links are (presumably) valid, or it's easy enough to check them during the PR review. Detecting broken links unrelated to the PR doesn't really makes sense in the PR context; this is something that we might just want for pushes to the main branch (the current workflow does that, in addition to running on PRs). This would still make quite a lot of requests, especially when someone merges several PRs in a row. There are probably ways to rate-limit it further, we could look into it.
Another thing that could be interesting: Do you know if the rate-limiting on GitHub happens to authenticated users as well? I see we can pass headers to the probes, so maybe checking the links by passing a GitHub token would be less impacted? I honestly don't know.
Unrelated: Can we raise linkcheck_retries to 2 or 3 (doc says the default is 1), to make the checks a bit more resilient in case a request is lost on the network?

I think we can live with that. Out of curiosity, what link is it?

https://netdevconf.info

Maybe we should just run it on a given schedule.]

I think this can help us to limit the number of runs and address the issue of 11 mins or so for each PR check.
I did try linkcheck_rate_limit_timeout. with the linkcheck_retries as 2 and timeout as 15.0 ( Can experiment more on this)
Not sure about the rate-limiting on github - will take a look.

@qmonnet  I played around with the linkcheck_rate_limit_timeout but didn't help much.
I found the -Q(https://www.sphinx-doc.org/en/master/man/sphinx-build.html#cmdoption-sphinx-build-Q)  flag for sphinx that suppress warning. I removed the -W( which I added) that made each warning an error.
Wondering if we should take this PR as a step forward towards enabling the linkchecker only for errors and create an issue for handling the warnings ?
Also regarding the time for the check in the PR, it took 8 mins earlier. But seems like it is taking more now. Let me know if enabling it for each PR is the path we want to go forward with. I can make a small PR to update the check to run on a given schedule

@qmonnet I played around with the linkcheck_rate_limit_timeout but didn't help much.

Too bad, but thanks a lot for trying!

I found the -Q(https://www.sphinx-doc.org/en/master/man/sphinx-build.html#cmdoption-sphinx-build-Q) flag for sphinx that suppress warning. I removed the -W( which I added) that made each warning an error.

Can you please remind me what are the warnings that we observe? Are the rate-limit events displayed as warnings? Is there anything else?
I've got no objection to ignoring warnings (and removing -W) for now, but adding -Q is maybe too much - I'd rather keep these warnings in the logs, if they don't make the workflow fail.

Wondering if we should take this PR as a step forward towards enabling the linkchecker only for errors and create an issue for handling the warnings ? Also regarding the time for the check in the PR, it took 8 mins earlier. But seems like it is taking more now. Let me know if enabling it for each PR is the path we want to go forward with. I can make a small PR to update the check to run on a given schedule

This is probably something we need to discuss with the folks who focus on the CI. I can raise this at today's Community meeting (feel free to join). My feeling is that we'd be better off running it as a cron task only, rather than on all PRs. I see Tetragon does both (https://github.com/cilium/tetragon/tree/main/.github/workflows, check-links-*.yaml), but their docs are smaller with fewer links I suppose.
We'll need to make the linkchecker run in check-build.sh optional anyway, because we also don't want to spend 10 minutes checking all links when running it to validate doc changes locally. I wonder if we could just reuse the existing sphinx-build -M "${target}" ... from this script, by passing linkcheck as a target, without having to otherwise modify the script? :thinking: Depends on the options we've got to pass I suppose, it would probably not work if we use different options for different targets

@qmonnet  Sorry for the delayed response( was busy with other stuff)

Can you please remind me what are the warnings that we observe? Are the rate-limit events displayed as warnings? Is there anything else?

The warnings were related to 429 errors.( throttling due to too many request)
Sure will make the appropriate changes and move it to a different script.
Do we want to enable the script in the github workflow in the same PR OR we should keep them separate ?

@qmonnet Thanks for the review. I updated the script with the changes and modified the commits as well. Have couple of question related to workflow:

I tried adding the step of link checker in the workflow but it failed with timeout. ? How can I test the script works in the workflow.
Regarding the cron job, what should be the timing for the cron job ? Also, do we need to add the code similar to Tetragon in terms of creating the github issue on link failure ? (Same question, how can I check that the workflow is working as intended, if the permission issue exists.)

@qmonnet Thanks for the review. I updated the script with the changes and modified the commits as well. Have couple of question related to workflow:

Thanks!

I tried adding the step of link checker in the workflow but it failed with timeout. ? How can I test the script works in the workflow.

You don't have to do anything to test this workflow, given that it runs on the code from the pull request (that's the pull_request trigger at the top; it would be different if the workflow used pull_request_target instead).
Currently it fails with: ./Documentation/check-links.sh: Permission denied. This is likely because the script doesn't have the right permissions: try running chmod +x Documentation/check-links.sh and amending your commit.

Regarding the cron job, what should be the timing for the cron job ?

Good question. It's probably OK to check that links are still valid every few days, let's say once per week?

Also, do we need to add the code similar to Tetragon in terms of creating the github issue on link failure ?

Yes please. We can probably reuse most of the existing code in https://github.com/cilium/tetragon/blob/main/.github/workflows/check-links-cron.yaml.

(Same question, how can I check that the workflow is working as intended, if the permission issue exists.)

Another good question, I see no secret being used in that workflow, so presumably nothing required? Cc @mtardy, would you know?

Another good question, I see no secret being used in that workflow, so presumably nothing required? Cc @mtardy, would you know?

In the Tetragon one, we use the secrets.GITHUB_TOKEN to avoid a ban from the github.com domain after polling all those URLs. You can technically do without but since we have a lot of github.com URLs, we would be banned instantly. Maybe it's different when you run from GitHub runners, I didn't try.

@qmonnet Sorry for not making it a draft earlier. I was actually testing the workflow, that is why there were few unrelated code segments in the PR.
I have added the code but I am still not able to create the warning.txt in the workflow whereas locally it gets created.
Also, the amount of time it takes to run the check links is very less. I wonder if it is actually running?(Given we have no warning.txt getting created)

/test

I can reproduce the link checker issue locally and dump the logs, but that's not super useful. Looks like a Sphinx bug (we recently bumped the version and updated the docs-builder image). I'd like to check if this happens with the latest version, but I think we're stuck to the current one because of some dependencies :disappointed:.
$ docker run --workdir /github/workspace --rm --entrypoint "./Documentation/check-links.sh" -v $PWD:"/github/workspace" quay.io/cilium/docs-builder:9eb38bbec80e56a8a498b0cac42456e42cfe7f04@sha256:9936a2f648cb25cad6cf1fe5772ad1a5800d0033eb88b0dce77ad70a083661d

Logs from Sphinx
# Platform:         linux; (Linux-6.2.0-33-generic-x86_64-with)
# Sphinx version:   7.1.2
# Python version:   3.11.5 (CPython)
# Docutils version: 0.18.1
# Jinja2 version:   3.1.2
# Pygments version: 2.16.1

# Last messages:
#   gettingstarted/hubble_intro
#

#   reading sources... [ 58%]
#   gettingstarted/hubble_setup
#

#   reading sources... [ 58%]
#   gettingstarted/k8s-install-default
#

# Loaded extensions:
#   sphinx.ext.mathjax (7.1.2)
#   alabaster (0.7.13)
#   sphinxcontrib.applehelp (1.0.4)
#   sphinxcontrib.devhelp (1.0.2)
#   sphinxcontrib.htmlhelp (2.0.1)
#   sphinxcontrib.serializinghtml (1.1.5)
#   sphinxcontrib.qthelp (1.0.3)
#   myst_parser (2.0.0)
#   sphinx.ext.ifconfig (7.1.2)
#   sphinx.ext.githubpages (7.1.2)
#   sphinx.ext.extlinks (7.1.2)
#   sphinxcontrib.httpdomain (unknown version)
#   sphinxcontrib.openapi (0.8.1)
#   sphinx_tabs.tabs (unknown version)
#   sphinxcontrib.googleanalytics (0.3)
#   sphinxcontrib.spelling (8.0.0)
#   versionwarning.extension (1.1.2)

# Traceback:
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/sphinx/cmd/build.py", line 290, in build_main
    app.build(args.force_all, args.filenames)
  File "/usr/local/lib/python3.11/site-packages/sphinx/application.py", line 351, in build
    self.builder.build_update()
  File "/usr/local/lib/python3.11/site-packages/sphinx/builders/__init__.py", line 290, in build_update
    self.build(to_build,
  File "/usr/local/lib/python3.11/site-packages/sphinx/builders/__init__.py", line 310, in build
    updated_docnames = set(self.read())
                           ^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/sphinx/builders/__init__.py", line 417, in read
    self._read_serial(docnames)
  File "/usr/local/lib/python3.11/site-packages/sphinx/builders/__init__.py", line 438, in _read_serial
    self.read_doc(docname)
  File "/usr/local/lib/python3.11/site-packages/sphinx/builders/__init__.py", line 494, in read_doc
    publisher.publish()
  File "/usr/local/lib/python3.11/site-packages/docutils/core.py", line 217, in publish
    self.document = self.reader.read(self.source, self.parser,
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/sphinx/io.py", line 104, in read
    self.parse()
  File "/usr/local/lib/python3.11/site-packages/docutils/readers/__init__.py", line 78, in parse
    self.parser.parse(self.input, document)
  File "/usr/local/lib/python3.11/site-packages/sphinx/parsers.py", line 80, in parse
    self.statemachine.run(inputlines, document, inliner=self.inliner)
  File "/usr/local/lib/python3.11/site-packages/docutils/parsers/rst/states.py", line 170, in run
    results = StateMachineWS.run(self, input_lines, input_offset,
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/docutils/statemachine.py", line 240, in run
    context, next_state, result = self.check_line(
                                  ^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/docutils/statemachine.py", line 452, in check_line
    return method(match, context, next_state)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/docutils/parsers/rst/states.py", line 3018, in text
    self.section(title.lstrip(), source, style, lineno + 1, messages)
  File "/usr/local/lib/python3.11/site-packages/docutils/parsers/rst/states.py", line 327, in section
    self.new_subsection(title, lineno, messages)
  File "/usr/local/lib/python3.11/site-packages/docutils/parsers/rst/states.py", line 393, in new_subsection
    newabsoffset = self.nested_parse(
                   ^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/docutils/parsers/rst/states.py", line 281, in nested_parse
    state_machine.run(block, input_offset, memo=self.memo,
  File "/usr/local/lib/python3.11/site-packages/docutils/parsers/rst/states.py", line 196, in run
    results = StateMachineWS.run(self, input_lines, input_offset)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/docutils/statemachine.py", line 240, in run
    context, next_state, result = self.check_line(
                                  ^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/docutils/statemachine.py", line 452, in check_line
    return method(match, context, next_state)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/docutils/parsers/rst/states.py", line 2779, in underline
    self.section(title, source, style, lineno - 1, messages)
  File "/usr/local/lib/python3.11/site-packages/docutils/parsers/rst/states.py", line 327, in section
    self.new_subsection(title, lineno, messages)
  File "/usr/local/lib/python3.11/site-packages/docutils/parsers/rst/states.py", line 393, in new_subsection
    newabsoffset = self.nested_parse(
                   ^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/docutils/parsers/rst/states.py", line 281, in nested_parse
    state_machine.run(block, input_offset, memo=self.memo,
  File "/usr/local/lib/python3.11/site-packages/docutils/parsers/rst/states.py", line 196, in run
    results = StateMachineWS.run(self, input_lines, input_offset)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/docutils/statemachine.py", line 240, in run
    context, next_state, result = self.check_line(
                                  ^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/docutils/statemachine.py", line 452, in check_line
    return method(match, context, next_state)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/docutils/parsers/rst/states.py", line 2352, in explicit_markup
    nodelist, blank_finish = self.explicit_construct(match)
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/docutils/parsers/rst/states.py", line 2364, in explicit_construct
    return method(self, expmatch)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/docutils/parsers/rst/states.py", line 2101, in directive
    return self.run_directive(
           ^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/docutils/parsers/rst/states.py", line 2151, in run_directive
    result = directive_instance.run()
             ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/sphinx_tabs/tabs.py", line 103, in run
    self.state.nested_parse(self.content, self.content_offset, node)
  File "/usr/local/lib/python3.11/site-packages/docutils/parsers/rst/states.py", line 281, in nested_parse
    state_machine.run(block, input_offset, memo=self.memo,
  File "/usr/local/lib/python3.11/site-packages/docutils/parsers/rst/states.py", line 196, in run
    results = StateMachineWS.run(self, input_lines, input_offset)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/docutils/statemachine.py", line 240, in run
    context, next_state, result = self.check_line(
                                  ^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/docutils/statemachine.py", line 452, in check_line
    return method(match, context, next_state)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/docutils/parsers/rst/states.py", line 2354, in explicit_markup
    self.explicit_list(blank_finish)
  File "/usr/local/lib/python3.11/site-packages/docutils/parsers/rst/states.py", line 2379, in explicit_list
    newline_offset, blank_finish = self.nested_list_parse(
                                   ^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/docutils/parsers/rst/states.py", line 318, in nested_list_parse
    state_machine.run(block, input_offset, memo=self.memo,
  File "/usr/local/lib/python3.11/site-packages/docutils/parsers/rst/states.py", line 196, in run
    results = StateMachineWS.run(self, input_lines, input_offset)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/docutils/statemachine.py", line 240, in run
    context, next_state, result = self.check_line(
                                  ^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/docutils/statemachine.py", line 452, in check_line
    return method(match, context, next_state)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/docutils/parsers/rst/states.py", line 2657, in explicit_markup
    nodelist, blank_finish = self.explicit_construct(match)
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/docutils/parsers/rst/states.py", line 2364, in explicit_construct
    return method(self, expmatch)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/docutils/parsers/rst/states.py", line 2101, in directive
    return self.run_directive(
           ^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/docutils/parsers/rst/states.py", line 2151, in run_directive
    result = directive_instance.run()
             ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/sphinx_tabs/tabs.py", line 220, in run
    node = super().run()
           ^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/sphinx_tabs/tabs.py", line 197, in run
    self.state.nested_parse(self.content[1:], self.content_offset, panel)
  File "/usr/local/lib/python3.11/site-packages/docutils/parsers/rst/states.py", line 281, in nested_parse
    state_machine.run(block, input_offset, memo=self.memo,
  File "/usr/local/lib/python3.11/site-packages/docutils/parsers/rst/states.py", line 196, in run
    results = StateMachineWS.run(self, input_lines, input_offset)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/docutils/statemachine.py", line 240, in run
    context, next_state, result = self.check_line(
                                  ^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/docutils/statemachine.py", line 452, in check_line
    return method(match, context, next_state)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/docutils/parsers/rst/states.py", line 2352, in explicit_markup
    nodelist, blank_finish = self.explicit_construct(match)
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/docutils/parsers/rst/states.py", line 2370, in explicit_construct
    nodelist, blank_finish = self.comment(match)
                             ^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/docutils/parsers/rst/states.py", line 2297, in comment
    self.document.include_log.pop()
IndexError: pop from empty list

Looks like a bug caused by the bump of docutils from 0.17.1 to 0.18.1 - bisecting shows it is introduced by https://repo.or.cz/docutils.git/commitdiff/93dc79108625a3af6be11a3eb85e50be59b2c910?hp=0515f37ca519ecfde133040425a06b6e4887aea0.
Not sure how to handle this, though :thinking:

Ping, anything we can do to move this along?

Thanks Timo. I must admit I'm a bit stuck here. I talked with @zacharysarah about this PR, and we don't see a good path forward.
This bug in the link checker is clearly an issue. We know the cause, but it's tricky to address.

We can't just ignore the bug if we enable the link checker, because it won't run at all, this is not a warning we could just skip.

We could report or try to fix the bug upstream. However, we're already behind on docutils versions: we're limited to 0.18.1 because of the sphinx-tabs extension, when 0.20.0 is out already. This means that even if the issue is fixed upstream, we won't be able to pull it immediately, likely not before a few years. Even if sphinx-tabs got updated quickly, there's still an issue with Netlify not being aware of the latest versions of Sphinx and dependencies in its repo, forcing us to stay a few versions behind. So I don't see the fix available from upstream before a couple years at least.

We could revert to a working version of docutils, but this would mean downgrading Sphinx and several other add-ons - in other words, reverting all the recent version changes, and this may get us stuck with older versions until the bug is fixed upstream - which will take a while, as explained above. I don't really expect security vulnerabilities in Sphinx or its add-ons to be exploitable, but being stuck on old versions does not sound great.

The bug itself is easy to “fix” (although I'm not sure this is the right fix). We could use a fork of docutils to add a fix, which is not difficult to do but means more work for future upgrades.

Add to that that there are internal discussions about moving away from Sphinx in the future (but nothing decided yet), so there's little appetite for long-term commitments/solutions at the moment.
Maybe the simplest option for now would be to drop the CI workflow (sorry Vipul :cry:), and try to merge check-links.sh with the accompanying config update and doc fixes. Possibly adding an echo at the beginning of the script to print a warning about the fact it may be broken, and link to this discussion?

I can remove the workflow and update the  script, if that is the suggested path forward. Let me know.

/test

Thanks for the contribution, merged!


Temporarily disable region-click events

Thanks for this great library. I'm using the regions plugin, and I've added a button on the region itself to play it, however, immediately after my callback, the callback of 'region-click' is fired. Is there a way to temporarily disable click events on a region?
wavesurfer.on('region-created', function(reg) {
    const regElem = $('region[data-id="' + reg['id'] + '"]')[0];
    const playRegion = regElem.appendChild(document.createElement('i'));
    playRegion.className = "glyphicon glyphicon-play";
    playRegion.addEventListener('click', function() {
      wavesurfer.play(reg['start'], reg['end']);
    });
}

@dimidd you can do the following
wavesurfer.on('region-click', function(e) {
    e.stopImmediatePropagation();
    // other code here
});

Works great, thanks!


detect simulator crashes in integration test harness

Currently a crash in the simulator won't be detected unless the test itself fails. It's best to detect a failure in the simulator and make this evident in the test logs.

resolved in #148


Adding a few new Sensor features

Took a stab at covering Sensor features. Let me know if this organization makes sense.

Closing and reopening, see https://github.com/web-platform-dx/web-features/issues/1320.


Changelog is not up to date

I noticed that the changelog is out of sync with the releases:
https://github.com/BranchMetrics/cordova-ionic-phonegap-branch-deep-linking-attribution/blob/master/CHANGELOG.md
https://github.com/BranchMetrics/cordova-ionic-phonegap-branch-deep-linking-attribution/releases

should be there now, sorry!


Analysis 0.3 restart on watchdog failure

Set Restart=on-failure is systemd unit file to restart the service
on watchdog failure.
Improve logging, remove double negations like "no_systemd == False"

Now it's running regularly and generating https://mon.ooni.nu/grafana/d/0NwR3eUWz/fastpath?orgId=1


Remove password request from removing connection

The Chore
It feels like overkill to request your password when you remove a connection, the dialogue alone should be enough of a "are you sure" step.
Tasks

[ ] What do we need to do first
[ ] and then what?
[ ] Etc.

Sketch

Additional details / background info

This needs:

https://github.com/vegaprotocol/vega/issues/7223


Heroku-GitHub integration

Could Heroku-GitHub integration make the installation process easier?
https://devcenter.heroku.com/articles/github-integration

Hi Jordan. That integration you linked to is for deploying the app to Heroku once it has already been installed. You would have to turn on the integration yourself in your own Heroku account with your own GitHub repo.
As an example, here is how this works with this repo and the demo site at https://ohana-web-search-demo.herokuapp.com/:

I have this repo installed locally on my machine
I created a new ohana-web-search-demo app on my Heroku account
I pushed the code to this new app with git push heroku master
I then went to the Heroku web site, and clicked on the ohana-web-search-demo app, and turned on GitHub integration and enabled automatic deploys of the master branch and checked the "Wait for CI to pass before a deploy" checkbox.
This means that every time I merge a pull request into master, Heroku automatically updates the demo site with the new code.

As for the installation process itself, what do you find hard about it? I'm always looking for ways to make it easier. Which parts specifically do you think can be easier?


HA/SNO leader election config

Hi there, the purpose of this PR is to configure leader election to be driven by some conventions that allow for better behavior on SingleNode environments as well as normal HA clusters.
Currently leader election is defaulting to the Kubernetes defaults which are leaseDuration: 15s renewDeadline: 15s and a retryPeriod: 2s. On a typically well suited machine this is not much of a problem and cheap. However as resources become strapped this cadence starts to show some flaws and in situations where the api-server is down for longer than usual due to limited CPU bandwidth then the inability to get a response from the api-server consecutively will cause a restart. The new defaults allow for a more generous down time tolerance of (78s) and a more reasonable retry cadence of (26s) that keeps things well behaved in both respects of responsiveness during roll out and  stability.
The second path is for SingleNode situations, in those environments you are typically only running a single machine with much more strapped resources. Furthermore in stricter situations, like edge deployments, management workloads can be pinned down to a limited number of cores, and anything to lesson traffic against the api-server becomes a win. The config changes for those situations follow the same as HA environments but with a (270s) lease duration and a retry cadence of (60s) this gives us a much higher tolerance for api-server downtime at (180s).
Any and all feedback welcome, thanks!

/test-all

general question. we already support a single node in the operator for both k8s and ocp can you just add a function under https://github.com/k8snetworkplumbingwg/sriov-network-operator/blob/master/pkg/utils/cluster.go and use the already existing function to understand if it's a single node cluster?
I don't think we need to import a package (ocp/api) just to use one function there.
Last point why the ocp/api doesn't have a function that returns the timer? this way if in the future there is a need to change the timer we just need to bump the package version and not change anything else on any project using this package.

general question. we already support a single node in the operator for both k8s and ocp can you just add a function under https://github.com/k8snetworkplumbingwg/sriov-network-operator/blob/master/pkg/utils/cluster.go and use the already existing function to understand if it's a single node cluster?

That's a great idea, moved the logic there and used @zshi-redhat suggestion of checking against the CLUSTER_TYPE env for openshift and k8s clusters

I don't think we need to import a package (ocp/api) just to use one function there.

I agree, I wasn't sure how best to approach this, to avoid any future mistakes figured it was best to pull in ocp/api and use the shared Infrastructure object.

Last point why the ocp/api doesn't have a function that returns the timer? this way if in the future there is a need to change the timer we just need to bump the package version and not change anything else on any project using this package.

Correct me if I misunderstood your question @SchSeba , right now the functionality that returns default leader election timers for both regular and SNO clusters is part of openshift/library-go, we could pull in that pkg but that will force more dependency changes. The intent here was to keep this simple and copying those values seemed more manageable for this PR.

@eggfoobar just a general question, is the access to the OCP API request any change in the operator RBAC's?

@eggfoobar just a general question, is the access to the OCP API request any change in the operator RBAC's?

Thank you! Yes, I missed that. I updated the RBAC in the in the deployments where it seemed to be located.

@eggfoobar Could you squash the commits before we merge it?

@pliurh Sure thing, squashed it into two commits, is that okay or would you rather it be one?

two is ok.

/test-all

/lgtm

/test-all

/lgtm


Fix small typo in readme: icp-channel -> ipc-channel

oh man, you mean they got rid of the Insane Clown Posse Channel crate???

I thought the exact same thing haha


Don't use 'is' operator with integer literals (== preferred).

Python 3.10 helpfully emits the following warning:
/path/to/spydrnet-tmr/spydrnet_tmr/transformation/replication/organ_insertion.py:664: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if start_index is -1:

The current code does work as intended, but relies on small-number singletons ("interning") that are a Python implementation detail. For example:

>>> a =<PHONE_NUMBER>
>>> b =<PHONE_NUMBER>
>>> a is b
False

>>> c = -1
>>> d = -1
>>> c is d
True

So, this pull request should not alter behaviour - it just makes the code correct-er.

Thanks for bringing this to our attention. The change has been made.


Vulnerability roundup 85: foomatic-filters-4.0.17: 2 advisories [7.3]

search, files

[ ] CVE-2015-8560 CVSSv3=7.3 (nixos-20.03)
[ ] CVE-2015-8327 (nixos-20.03)

Scanned versions: nixos-20.03: a84b797b28e. May contain false positives.

20.03 is Frozen and EOL.
As such, issue is closed.


Apply the change for fit the syle of the standard

This PR is related the style of the standard of nuget publishing.
The related issue is : https://github.com/Azure/azure-functions-kafka-extension/issues/66
I change the csproj  file to fit the standard.
This is the example of the standard.
https://github.com/Azure/azure-functions-eventgrid-extension/blob/dev/src/EventGridExtension/EventGridExtension.csproj
On the issue, it said that, we need strong name for our library, however, it is not mandatory (recommended) and we have 3rd party library which we need strong name library as well.
We have 2 library which is not support strong name.

Confluent.Kafka
Confluent.SchemaRegistry.Serdes

We can use Confluent.Kafka.StrongName instead, however, not for Confluent.SchemaRegistry.Serdes.
So I decide go without strong name sign.

The strong name sign was a requirement that came from @paulbatum  and @fabiocav when we spoke to them about onboarding to their build and publish systems, and for when we publish to NuGet.
If we don't strong name sign the assembly, will we be able to publish the package to NuGet?

Yes. We can publish it. It is not mandatory but recommended. (I heard it from @fabiocav ).
FYI, this is the Libraries which is missing strong name. We have Confluent.Kafka.StrongName but I can't find for others.  We can ask the request to create a strong name version for Confluent. However, it might take time. (If you have a connection, we should ask them. ) Until then, we can do without strong name and once they implement it, switch to the strong name one. The procedure is not difficult.

We have Confluent.Kafka.StrongName

what's interesting is our guidance explictly says do not create two different versions of the same assembly.
❌ DO NOT publish strong-named and non-strong-named versions of your library. For example, Contoso.Api and Contoso.Api.StrongNamed.

Interesting. Confluence did it. :)

Yeah, that approach goes against the guidance.
One thing to note is that we can't really start signing the assemblies after releasing them without it being a breaking change, as that would change assembly identities.


Move recipe search to 5.0

https://github.com/elastic/examples/issues/54

Closed with https://github.com/elastic/examples/pull/73


OAK-10265 | Refresh the index def after lane revert in oak-run out of…

… the band reindex import

@thomasmueller  - sure. I added assertions to an already existing test to verify this change.


logs should just refresh when we toggle prefix or timestamp

Is your feature request related to a problem? Please describe.
when toggling timestamp and prefix on logs view, the view should not close and reopen:
https://github.com/Ramilito/kubectl.nvim/blob/b65294533ba0e82db637b23e87d20f914dddef3f/ftplugin/k8s_pod_logs.lua#L41-L42
we can just call logs again with --since=1s and keep the same buffer, just as we do when we follow.
This will improve times for pods with very high amount of log lines
just like tail, we should
Describe the solution you'd like

Describe alternatives you've considered

Additional context

To do that we need to solve another thing, when running view.Logs(), in the buffer.lua file, we are creating a window each time. So if we don't have the vim.cmd.close(), we will end up with multiple windows on top of each other. You can test it by:

removing the close
open logs
toggling prefix
then pressing q once, you will see it requires two taps.

Not saying we should keep the close, just mentioning that we need to not create a new window.

yeah I see. what about just saving the log lines and know how to split the timestamp and prefix so you can easily add them using an in-memory table?
or that could be too heavy

If we don't solve the window thing then that would definitely be an option! But I feel that we would get a lot of stability if we didn't recreate the window

Started some work on this in #297

I split the change up from #297 to #298 to make a smaller PR since the event handler approach might take some more time.

thanks @Ramilito
it seems toggling the options still refreshes the entire float buffer. maybe it's the same window but the logs command just retriggers, which is a heavy operation if you have many many logs in a container/pod

Oh now I understand what you meant before...I don't think parsing the logs would be feasible in both directions, removing a timestamp could be fine but adding it back would be quite the effort.
How about this instead, adding a limit with a low default, say 200 rows that we can change?


Fix mistake : i18n is internationalization

I replace everywhere localization by internationalization (i18n).
i18n : internationalization
l10n : localization

LGTM

:)


Cannot connect to Azure OpenAI deployment

I am unable to connect gptscript to Azure's implementation of OpenAI.
I have a gpt 3.5 turbo deployment on Azure OpenAI named, coincidentally enough, gpt-35-turbo.
It is reachable with:
curl https://<endpoint>.openai.azure.com/openai/deployments/gpt-35-turbo/completions?api-version=2023-05-15 -H "Content-Type: application/json"   -H "api-key: <key>"   -d "{
  \"prompt\": \"Once upon a time\",
  \"max_tokens\": 5
}"

and returns, for example:
{"id":"cmpl-8uobBPlV6d0UDqVFPwQdKEkZJaGgl","object":"text_completion","created":1708551561,"model":"gpt-35-turbo","choices":[{"text":" on a small island,","index":0,"finish_reason":"length","logprobs":null}],"usage":{"prompt_tokens":4,"completion_tokens":5,"total_tokens":9}}

With gptscript, I am running:
.\main.exe "https://get.gptscript.ai/echo.gpt" --input 'Hello, World!' --openai-api-key '<key>' --openai-api-type 'AZURE' --openai-base-url 'https://<endpoint>.openai.azure.com/openai/deployments/gpt-35-turbo/completions' --openai-api-version '2023-05-15'

and getting:
16:45:22 started  [main] [input=--input Hello, World! --openai-api-key <key> --openai-api-type AZURE --openai-base-url https://<endpoint>.openai.azure.com/openai/deployments/gpt-35-turbo/completions --openai-api-version 2023-05-15]
16:45:22 sent     [main]
         content  [1] content | Waiting for model response...2024/02/21 16:45:22 error, status code: 404, message: Resource not found

I can reproduce the same on Linux:
export OPENAI_API_KEY="<key>"
export OPENAI_API_TYPE="AZURE"
export OPENAI_BASE_URL="https://<endpoint>.openai.azure.com/openai/deployments/gpt-35-turbo/completions"
export OPENAI_API_VERSION="2023-05-15"
gptscript "https://get.gptscript.ai/echo.gpt" --input 'Hello, World!' --debug

Gets:
16:51:33 started  [main] [input=--input Hello, World! --debug]
16:51:33 sent     [main]
         content  [1] content | Waiting for model response...2024/02/21 16:51:33 error, status code: 404, message: Resource not found

Closing this in favor of #43, Azure support is WIP


Waiting for unpkg.com in chrome

I have implemented component using lit-element and currently my import like this
import {   LitElement,   html,   css } from "https://unpkg.com/@polymer/lit-element@latest/lit-element.js?module";
initally was working fine but now unfortunately its saying waiting fot unpkg.com in chrome

unpkg seems to be having some issues currently. https://twitter.com/mikethefuture/status/1144049912159637508

i wonder if you could use import maps, via es-module-shims, and define fallbacks to unpkg (like [unpkg, jsdelivr]), such that if unpkg doesn't load, the browser should fall back to the secondary cdn
i assume it won't wait a full 60 second timeout before attempting the fallback, that would defeat the purpose of the feature..

@abraham, thanks for pointing out that unpkg was having some problems at the time this was posted. The URL listed in the issue seems to be working now, so I'm going to close.


[follow-up] Delete hdfs shuffle data files using proxy user

What changes were proposed in this pull request?
Delete shuffle data files stored on secured hdfs using proxy user

Why are the changes needed?
In previous PR #53, we introduce the proxy user for shuffle server to write shuffle data to HDFS.
But I ignored that the shuffle server should also delete these files by the way of proxy user.

Does this PR introduce any user-facing change?
No

How was this patch tested?
Manual tests on kerberos HDFS cluster, and unit tests.

Codecov Report

Merging #170 (4584f67) into master (abb9215) will decrease coverage by 1.29%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##             master     #170      +/-   ##
============================================
- Coverage     58.25%   56.96%   -1.30%
+ Complexity     1261     1184      -77
============================================
  Files           158      149       -9
  Lines          8397     7902     -495
  Branches        779      749      -30
============================================
- Hits           4892     4501     -391
+ Misses         3253     3160      -93
+ Partials        252      241      -11

Impacted Files
Coverage Δ

...he/uniffle/server/storage/MultiStorageManager.java
37.50% <0.00%> (ø)

...storage/handler/impl/HdfsShuffleDeleteHandler.java
0.00% <0.00%> (ø)

...e/storage/handler/impl/LocalFileDeleteHandler.java
0.00% <ø> (ø)

.../org/apache/uniffle/server/ShuffleTaskManager.java
64.60% <100.00%> (ø)

...che/uniffle/server/storage/HdfsStorageManager.java
92.68% <100.00%> (ø)

...he/uniffle/server/storage/LocalStorageManager.java
61.53% <100.00%> (ø)

...storage/handler/impl/DataSkippableReadHandler.java
81.25% <0.00%> (-3.13%)
:arrow_down:

...che/spark/shuffle/writer/BufferManagerOptions.java

...pache/spark/shuffle/writer/WriteBufferManager.java

...ava/org/apache/spark/shuffle/RssShuffleHandle.java

... and 7 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

PTAL @jerqi @colinmjj


Fix map distortion due to high latitudes

Describe problem solved by this pull request
Current formula used for distance in the rally point calculations didn't take map distortion into account.
Describe your solution
Use a local correction for the longitude compression
Describe possible alternatives
Use the 'real' geo library distance. However this is slow, and overkill IMO

I think I'd still personally prefer leaning on the geo library for low frequency work like this, but whichever you prefer.
I'll merge as soon as flash is available.

I think the worry is that we might have a whole bunch of rally points (maybe from a database?), so despite it running infrequently it still causes a big pause. I guess this was the concern of @sfuhrer in just using the lat/lon directly. Otherwise we could add this method to the geo library as a _squared_fast variant (maybe similar to fast trig approximations), but then it won't share the cos(lat) call across the points.


Removed skip-if-no-diff from release Workflow UI

Current dependencies on/for this PR:

main

PR #72   👈

This comment was auto-generated by Graphite.


Find an available port.

Dynamically choose an available port.
This probably isn't needed when run in a container.

Thanks @ryanlovett. One comment, then good to go!

Done, thanks!

I tested this (with repo2docker .) and it fails with:
<IP_ADDRESS> - - [06/Nov/2019 21:34:45] "GET /websockify HTTP/1.1" 101 -
<IP_ADDRESS> - - [06/Nov/2019 21:34:45] <IP_ADDRESS>: Plain non-SSL (ws://) WebSocket connection
<IP_ADDRESS> - - [06/Nov/2019 21:34:45] <IP_ADDRESS>: Path: '/websockify'
<IP_ADDRESS> - - [06/Nov/2019 21:34:45] connecting to command: '/srv/conda/envs/notebook/lib/python3.7/site-packages/jupyter_desktop/share/tigervnc/bin/vncserver -verbose -xstartup /srv/conda/envs/notebook/lib/python3.7/site-packages/jupyter_desktop/share/xstartup -geometry 1024x768 -SecurityTypes None -rfbunixpath /tmp/tmp7kppt3fb/vnc-socket -fg :0' (port 41657)

New 'd11d75896232:1 (yuvipanda)' desktop is d11d75896232:1

Creating default config /home/yuvipanda/.vnc/config
Starting applications specified in /srv/conda/envs/notebook/lib/python3.7/site-packages/jupyter_desktop/share/xstartup
Log file is /home/yuvipanda/.vnc/d11d75896232:1.log

Killing Xvnc process ID 38
<IP_ADDRESS> - - [06/Nov/2019 21:34:47] <IP_ADDRESS>:41657: Target closed connection
<IP_ADDRESS> - - [06/Nov/2019 21:34:47] <IP_ADDRESS>:41657: Closed target
Xvnc seems to be deadlocked.  Kill the process manually and then re-run
    /srv/conda/envs/notebook/lib/python3.7/site-packages/jupyter_desktop/share/tigervnc/bin/vncserver -kill :1
to clean up the socket files.
Wrapped command exited (or daemon). Returned 0
In exit
Closing socket listening at :5900

If I open the log file mentioned there,
uvipanda@d11d75896232:~$ cat ~/.vnc/d11d75896232\:1.log
_XSERVTransmkdir: ERROR: euid != 0,directory /tmp/.X11-unix will not be created.
(WW) Failed to open protocol names file /usr/lib64/xorg/protocol.txt

Xvnc TigerVNC 1.9.0 - built Jul 16 2018 14:18:04
Copyright (C) 1999-2018 TigerVNC Team and many others (see README.rst)
See http://www.tigervnc.org for information on TigerVNC.
Underlying X server release 11400000, The X.Org Foundation

Initializing built-in extension VNC-EXTENSION
Initializing built-in extension Generic Event Extension
Initializing built-in extension SHAPE
Initializing built-in extension MIT-SHM
Initializing built-in extension XInputExtension
Initializing built-in extension XTEST
Initializing built-in extension BIG-REQUESTS
Initializing built-in extension SYNC
Initializing built-in extension XKEYBOARD
Initializing built-in extension XC-MISC
Initializing built-in extension XINERAMA
Initializing built-in extension XFIXES
Initializing built-in extension RENDER
Initializing built-in extension RANDR
Initializing built-in extension COMPOSITE
Initializing built-in extension DAMAGE
Initializing built-in extension MIT-SCREEN-SAVER
Initializing built-in extension DOUBLE-BUFFER
Initializing built-in extension RECORD
Initializing built-in extension DPMS
Initializing built-in extension X-Resource
Initializing built-in extension XVideo
Initializing built-in extension XVideo-MotionCompensation
Initializing built-in extension GLX

Wed Nov  6 21:34:44 2019
 vncext:      VNC extension running!
 vncext:      Listening for VNC connections on /tmp/tmp7kppt3fb/vnc-socket
              (mode 0600)
 vncext:      created VNC server for screen 0
(EE) AIGLX error: dlopen of /usr/lib64/swrast_dri.so failed (/usr/lib64/swrast_dri.so: cannot open shared object file: No such file or directory)
(EE) GLX: could not load software renderer
(II) GLX: no usable GL providers found for screen 0

Wed Nov  6 21:34:45 2019
 Connections: accepted: /tmp/tmp7kppt3fb/vnc-socket
 SConnection: Client needs protocol version 3.8
 SConnection: Client requests security type None(1)
 VNCSConnST:  Server default pixel format depth 24 (32bpp) little-endian rgb888
 VNCSConnST:  Client pixel format depth 24 (32bpp) little-endian rgb888
xfce4-session: Cannot open display: .
Type 'xfce4-session --help' for usage.

Wed Nov  6 21:34:47 2019
 Connections: closed: /tmp/tmp7kppt3fb/vnc-socket (Server shutdown)
 EncodeManager: Framebuffer updates: 2
 EncodeManager:   Tight:
 EncodeManager:     Solid: 1 rects, 786.432 kpixels
 EncodeManager:            16 B (1:196609 ratio)
 EncodeManager:   Total: 1 rects, 786.432 kpixels
 EncodeManager:          16 B (1:196609 ratio)
 ComparingUpdateTracker: 0 pixels in / 0 pixels out
 ComparingUpdateTracker: (1:-nan ratio)

Ultimately for xfce4-session: Cannot open display: . maybe?

Interesting, it should equate to the same args. Will take a look and fix.

Note as an aside:
<IP_ADDRESS> - - [06/Nov/2019 21:34:45] connecting to command: '/srv/conda/envs/notebook/lib/python3.7/site-packages/jupyter_desktop/share/tigervnc/bin/vncserver -verbose -xstartup /srv/conda/envs/notebook/lib/python3.7/site-packages/jupyter_desktop/share/xstartup -geometry 1024x768 -SecurityTypes None -rfbunixpath /tmp/tmp7kppt3fb/vnc-socket -fg :0' (port 41657)
I think the (port 41657) is due to https://github.com/yuvipanda/jupyter-desktop/issues/7 and can be ignored (websockify always picks a random port to remap to)

Closing because I haven't researched this well enough.


Dl21 for pyserini

since qrels not publicly available yet.  only adding dl21 topics for pyserini

Codecov Report

Merging #1749 (1926a4c) into master (9ea3159) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #1749   +/-   ##
=========================================
  Coverage     57.58%   57.58%
  Complexity     1032     1032
=========================================
  Files           173      173
  Lines          9781     9782    +1
  Branches       1344     1344
=========================================
+ Hits           5632     5633    +1
  Misses         3675     3675
  Partials        474      474

Impacted Files
Coverage Δ

...in/java/io/anserini/search/topicreader/Topics.java
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ea3159...1926a4c. Read the comment docs.


[C# 6] #485 lost ** delimiters in §<IP_ADDRESS> Identical simple names and type names

In draft-v6, §<IP_ADDRESS> Identical simple names and type names contains an example with public Color Color.  Below the code sample, there is a paragraph:

Within the A class, those occurrences of the Color identifier that reference the Color type are delimited by **, and those that reference the Color field are not.

However, none of the occurrences are delimited by **. The delimiters were deleted in https://github.com/dotnet/csharpstandard/pull/485.

Rex, do you have time to look at this and make a proposal for next week's meeting?

Back in V5, when the spec was maintained in Word format, the 4 instances that were being called out here were highlighted by being underlined. At some point during the conversion to md, this got turned into pairs of "*" delimiters. Rather than go back to underlining, which requires embedded HTML that the converter would have to understand, I propose that we use chevron delimiters instead, as follows:

Example:
struct Color
{
    public static readonly Color White = new Color(...);
    public static readonly Color Black = new Color(...);
    public Color Complement() {...}
}

class A
{
    public «Color» Color;              // Field Color of type Color

    void F()
    {
        Color = «Color».Black;         // Refers to Color.Black static member
        Color = Color.Complement();  // Invokes Complement() on Color fld
    }

    static void G()
    {
        «Color» c = «Color».White;       // Refers to Color.White static member
    }
}

For expository purposes only, within the A class, those occurrences of the Color identifier that reference the Color type are delimited by «...», and those that reference the Color field are not.
end example

Note that, ordinarily, we use such delimiters to call out grammar rule names inside of code blocks, but as we explain the usage here, I think it's OK. Besides, we know that these delimiters are handled correctly by the Word converter, as they are simply "just another pair of Unicode characters," and they render correctly in GitHub.

That sounds like an excellent compromise to me.

PR was merged to draft-v6. Can this be closed now?


1.7.10 ore block unique identifiers

I can't seem to find what the unique identifiers for the Mekanism ores are. I assumed that they are Mekanism:OreBlock.<OreName>, for example, for Osmium Ore, it would be Mekanism:OreBlock.OsmiumOre. But this does not exist in the item registry (yes, my mod is loading after Mekanism). What are the names for the ore blocks so that I can reference them?

And this question also follows for dusts, ingots, clumps, etc... I can't figure out these multi-id items. I will edit the title for clarification.

Using mod tweaker is useful. Type /mt hand and it should give you the name and meta data you need.

@bookerthegeek Thanks for the help. I got this result from that command while holding a block of Osmium Ore:

What does this mean by "is in"?

Mekanism:OreBlock is the id of the block itself.
ore:oreOsmium is the ore dictionary entry that the block is in.
You would probably want to use the ore dictionary entry in case another mod also adds osmium ore.

Yep. The "is in" can have multitude of entries as items can have multiple ore dictionary entries


CICD automation fails with "node:internal/streams/readable:705" due to lack of stdin

Hi,
We are using the webpack5 plugin, and build's run fine locally, as well as locally in docker image, but when running via bitbucket cloud automation we get the below error.    Ive spent a huge amount of time trying to debug this issue to no avail.  It may have something to do with the std out/err or maybe file system, but its a bit of a black block.
as an aside ive tried webpack (4) as well as parcel, but i cant get either to work locally for other unrelated reasons.
ℹ [0003] Finding the version of "piral-native,piral,piral-core,piral-base" in "/app".
ℹ [0003] Finding the version of "piral-native,piral,piral-core,piral-base" in "/app".
ℹ [0003] Used versions: "0.15" and "0.15".

Starting emulator build ...
ℹ [0003] Removing the directory "/app/dist/emulator" ...
ℹ Bundle emulator ...
node:internal/streams/readable:705
dest.end();
^
TypeError: dest.end is not a function
at onend (node:internal/streams/readable:705:10)
at process.processTicksAndRejections (node:internal/process/task_queues:77:11)
Node.js v18.12.1
error Command failed with exit code 1.

Is there a MWE? Otherwise, we cannot look into this.

[Y] Can you reproduce the problem in a MWE?
see here: https://bitbucket.org/PvHIvz/piralmwe/pipelines/results/1/steps/{32b7886c-62a8-4af8-a667-71d9e2b0645b}

[Y] Are you running the latest version?
see package versions here: https://bitbucket.org/PvHIvz/piralmwe/src/main/package.json

[Y] Did you perform a search in the issues?

[Package Version, OS, Browser, ...]
Interestingly, it works when building locally using docker image, but not when building from cloud...
Description
With a shell Piral application I am able to build locally but not via CICD pipeline in the cloud, get an odd error, which looks like it may be related to something specific with the streams, perhaps stdin being piped?
You can view the exact logs here: https://bitbucket.org/PvHIvz/piralmwe/pipelines/results/1

Fixed with a patch:
https://bitbucket.org/PvHIvz/piralmwe/commits/0593647fba67f37f60e1932ec720da4f390036c2
https://bitbucket.org/PvHIvz/piralmwe/src/0593647fba67f37f60e1932ec720da4f390036c2/patches/piral-cli+0.15.5.patch
prob a better way then just commenting out since that will break other stuff i'm sure on desktop, but needs a think about how to put this into the piral-cli tooling.

Yes, thanks for the MWE, the investigation, and the proposed fixed. Indeed, it seems that under certain circumstances stdin (or other streams) might be undefined.
The fix in the referenced repo works on this condition, e.g., they do
child.stdin && child.stdin.pipe(process.stdin);
child.stdout && child.stdout.pipe(process.stdout);

I think we should do the same.

Hi I think there is a missing check stdin here, as I just upgraded our CI, and encountered it again:
https://github.com/smapiot/piral/blob/develop/src/tooling/piral-cli/src/build/bundler-calls.ts#L118

Right - it was only changed in the dynamic part which is used, e.g., for debugging (there, actually, it is quite unlikely to occur anyway).
Build is currently running - you can then check with the preview version of piral-cli in 0.15.7 (will be available via next tag on npm).

Giving next a try as I also saw the same from Jenkins...
21:52:48  Step 2/25 : COPY . .
21:52:48   ---> c4d63a1d7c79
21:52:48  Step 3/25 : RUN npm install && npx piral build
21:52:48   ---> Running in 50e312f05b41
21:52:48
21:52:48  ><EMAIL_ADDRESS>postinstall
21:52:48  > piral declaration
21:52:48
21:52:48  🦋  piral-cli v0.15.7-beta.5146
21:52:48  - Reading configuration ...
21:52:48  - Bundling declaration file ...
21:52:48  - Writing declaration file ...
21:52:48  ✔ Declaration created successfully in "./dist"!
21:52:48
21:52:48  added 557 packages in 11s
21:52:48
21:52:48  66 packages are looking for funding
21:52:48    run `npm fund` for details
21:52:48  🦋  piral-cli v0.15.7-beta.5146
21:52:48  - Reading configuration ...
21:52:48  - Starting emulator build ...
21:52:48  ℹ Bundle emulator ...
21:52:48  node:internal/streams/readable:705
21:52:48      dest.end();
21:52:48           ^
21:52:48
21:52:48  TypeError: dest.end is not a function
21:52:48      at onend (node:internal/streams/readable:705:10)
21:52:48      at process.processTicksAndRejections (node:internal/process/task_queues:77:11)
21:52:48
21:52:48  Node.js v18.12.1
21:52:48  The command '/bin/sh -c npm install && npx piral build' returned a non-zero code: 1

Seems like issue still prevails.

Likely the problem is that from a CI server, there is no TTY, and so the stdin fails.
I was able to workaround by:
FROM node as BUILD-ENV
COPY . .
RUN npm install
RUN echo yes | npx piral build --type release

Not sure how much user input is required in CLI outside of selecting the bundler, but most will probably configure from local and package-lock.json retains user selection for CI.  Still though, IMHO a CLI shouldn't ever require TTY.

Please make sure you indeed use the next version. If your patch worked beforehand, then the real next has to work, otherwise either your patch did not work either or you indeed do not use next.

@FlorianRappl I am not the OP here, but just jumping on a thread for having the same issue.  From above, isn't piral-cli v0.15.7-beta.5146 in the log evidence of next?
`

@gitisz My comment is quite independent of that - it essentially states that either the next version is not correctly applied or the patch posted by the OP is not working. If you know for sure that the current version was applied then the latter must be the case (simple logic).
Independent of that we still require a reproducible of the issue. There is a new preview version out, but without a reproducible it will be hard to verify the fix.

Hi, sorry been super buys, I can confirm that using the next version solves the issue for us. @gitisz if it does not for you make sure you are pulling the latest version, also check your lock files to be sure they are not pinned.  Also make sure you have one and only one bundler there, otherwise it fails back to the CLI input, which for obvious reasons will not work through automation.
P

Closing for now as the OP issue seems to be resolved - if we get a reproducible / this happens again in another environment we should have a new / separate issue for tracking purposes.


STG87 Beta Release

Description
Beta release for STG87 features.

API change check
API changes are not detected in this pull request.


Performance Issue - Suggest typescript peer dependency

Description
This problem made my development environment practically unusable until I was able to narrow it down to this package. Intellisense and tsserver updates would lag 9-16 seconds!
I'm not sure what exactly is the cause, but something about the d.ts files from parse-env don't play nice with typescript 4.4.3. Updating to 4.5 or newer fixed the issue.
I just started using this package and it seems really awesome. I just felt it was worth creating an issue for in case anyone else has similar problems. Hopefully I can spare someone else a headache or two.
Reproduction
I made a more tangible example of this with running tsc: https://stackblitz.com/edit/node-j7okci?file=README.md&view=editor
In this environment, I installed znv<EMAIL_ADDRESS>and ran npx tsc and it takes 10s to build.
Running npm install<EMAIL_ADDRESS>and npx tsc takes only 1s to build.
Suggestion
My recommendation for this project would be to specify a peerDependency for this project on<EMAIL_ADDRESS>It won't force people to use that version, but some package managers (like yarn) will raise a warning... plus it should serve as an indicator for the minimum typescript version this project supports/recommends.

Thanks for the report! That's unfortunate, I'm not too sure what's happening...
I'm not too sure it would be a good idea to add a peerDependency on<EMAIL_ADDRESS>since then running npm/yarn/pnpm install with NODE_ENV set to production (or using the --production flag) would yield warnings or errors (or in npm's case might cause typescript to be erroneously installed).
It might be better to just document the performance degradation in the README instead. What do you think?

Hi there, looks like<EMAIL_ADDRESS>(released in December) had introduced some perf issues that were only just fixed with the 3.21.0 release a few days ago. Any idea if this could be related to your performance issues?

Yeah that's definitely related. I forked the stackblitz repro I originally linked https://stackblitz.com/edit/node-cjrnba?file=README.md&view=editor there's notes in the README.md there, but it basically uses<EMAIL_ADDRESS>with<EMAIL_ADDRESS>and the performance issues goes away.
So it seems that installing either<EMAIL_ADDRESS>or<EMAIL_ADDRESS>fix the issue! Sounds like a case closed to me :)


Counter examples should wrap

Counter examples are WAY too long.
And interacting with them is difficult.
Every = should be in its own line.
As well as every @n.
Instead of
foo:Other.Thing.Foo = SOME_LONG_CONSTANT_NAME bar:More.Long.Type.Name = Name(with := @0, lots := @1, and := @2) @0:Lots.Of.Information @1:That.Is.Very @2:Hard.To.Read

I suggest
foo:Other.Thing.Foo = SOME_LONG_CONSTANT_NAME
bar:More.Long.Type.Name = Name(with := @0, lots := @1, and := @2)
@0:Lots.Of.Information
@1:That.Is.Very
@2:Hard.To.Read

Alternatively (or in addition), a way to send this information to the clipboard :)

I've seen this problem too. That's why I've started experimenting with an alternative approach in #52. At this time, I didn't continue working on it because I was envisioning better support for reference types. Nevertheless, I could integrate the current version as I believe it's more practical than the inline view. Or do you think your clipboard approach would be more useful in your case?
Moreover, you've started a great discussion in #75 for a big picture on how to deal with verification and counterexamples. However, this is probably some long-term work.

I think that having it be more readable will always be better.
In combination with the language server, having been given a counter example, I would love to be able to "pin" parts of it.
So if it is nicely flattened so I can read it,
then maybe I could also interact with it.
And ask, well, if I pin @0 == 5 for example, can Dafny still find a counter example?

1 on line breaks, and it would be pretty nice if one could select the text, say, to copy it.

I had other opinions which I summarized here: https://github.com/dafny-lang/dafny/issues/2280

I'm closing this issue, as it's now possible to copy in the clipboard the counter-examples.
Although it's not pretty, it's always better than the statu quo .We can't wrap counter-examples because that would be too disrupting on the user experience; however, we can - and we have some plans for that - to make a counter example visualization. @dijkstracula  was thinking of that.


TE-9191: FileManager dependencies upgrade

Developer(s): @yaroslav-spryker

Ticket: https://spryker.atlassian.net/browse/TE-9191

Release Group:

PR Overview:

merge: squash

Release Table

Module
Release Type
Constraint Updates

Minubo
major
FileManager: ^2.0.0, FlysystemAws3v3FileSystem: ^2.0.0

Module Minubo
Change log
Improvements

Adjusted composer.json in order to allow version ^2.0.0 for spryker/file-manager
Adjusted composer.json in order to allow version ^2.0.0 for spryker/flysystem-aws3v3-file-system
Adjusted code to use FileSystemServiceInterface::write() instead of outdated  FileSystemServiceInterface::put()

Ideally uses new CI approach as per https://github.com/spryker-eco/payone/pull/72
also, you should fix up all Spryker CI issues here

Please check errors found in QA