Updates to campaign resource for new index listing.

Fixes #4541
This PR wraps up shifting over both the /campaigns and /campaigns/:id endpoints and standardized JSON response.
The index listing of campaigns include all pagination data in same format as that of the reportbacks/reportback-items index views. It also provides the following parameters to filter by:

ids (string; csv)
count (default is 25)
staff_pick (boolean)
mobile_app (boolean)
term_ids (string; csv)
random (boolean)
page (integer)

Example request:
/api/v1/campaigns.json?&count=2&page=2

Example response:
{
  pagination: {
    total: 15,
    per_page: 2,
    current_page: 1,
    total_pages: 8,
    prev_uri: null,
    next_uri: "http://dev.dosomething.org:8888/api/v1/campaigns.json?&count=2&page=2"
  },
  retrieved_count: 2,
  data: [
    {
      id: "1261",
      title: "1 in 3 of Us",
      tagline: "This is a sandbox campaign.",
      created_at: "1404323239",
      updated_at: "1430407941",
      time_commitment: 2,
      status: "active",
      cover_image: {
        default: {
          uri: "http://dev.dosomething.org:8888/sites/default/files/styles/300x300/public/images/square_image_JK8675309.jpg",
          sizes: {
            landscape: {
              uri: "http://dev.dosomething.org:8888/sites/default/files/styles/1440x810/public/images/landscape_image_JK8675309.jpg"
            },
            square: {
              uri: "http://dev.dosomething.org:8888/sites/default/files/styles/300x300/public/images/square_image_JK8675309.jpg"
            }
          },
          type: "image",
          dark_background: true
        }
      },
      staff_pick: true,
      facts: {
        problem: "In the United Kingdom, people drink tea.",
        solution: "Experts agree that drinking at 3 cups of coffee per day prevents all sleepiness-related disasters.",
        sources: [
          {
            formatted: "
Clark, Barry. "A Treatise on The Motherland", British Royal Archives, 2009.
 "
          },
          {
            formatted: "
Lorch, Julie. "Coffee Sure Is Great", Royal Academy of Coffee (2010)
 "
          }
        ]
      },
      solutions: {
        copy: {
          raw: "Be American! Drink coffee to stay awake! DoSomething.org recommends 3 or more cups per day.",
          formatted: "
Be American! Drink coffee to stay awake! DoSomething.org recommends 3 or more cups per day.
 "
        }
      },
      causes: {
        secondary: [
          {
            id: "19",
            name: "mental health"
          },
          {
            id: "5",
            name: "physical health"
          }
        ]
      },
      action_types: {
        primary: {
          id: "3",
          name: "face to face"
        },
        secondary: [
          {
            id: "3",
            name: "face to face"
          },
          {
            id: "8",
            name: "improve a space"
          },
          {
            id: "9",
            name: "make something"
          },
          {
            id: "18",
            name: "share something"
          }
        ]
      },
      issue: {
        id: "490",
        name: "coffee"
      },
      tags: [
        {
          id: "491",
          name: "coffee"
        },
        {
          id: "492",
          name: "maxwell watson"
        },
        {
          id: "493",
          name: "birch"
        },
        {
          id: "494",
          name: "beans"
        },
        {
          id: "495",
          name: "aeropress"
        },
        {
          id: "496",
          name: "chemex"
        }
      ]
    },
    {
      id: "1617",
      title: "Another Test Campaign",
      tagline: "testing the pre-signup/signup script",
      created_at: "1422907938",
      updated_at: "1422911103",
      time_commitment: 0,
      status: "active",
      cover_image: {
        default: {
          uri: "http://dev.dosomething.org:8888/sites/default/files/styles/300x300/public/square_image_GH4yP13s.jpg",
          sizes: {
            landscape: {
              uri: "http://dev.dosomething.org:8888/sites/default/files/styles/1440x810/public/landscape_image_GH4yP13s.jpg"
            },
            square: {
              uri: "http://dev.dosomething.org:8888/sites/default/files/styles/300x300/public/square_image_GH4yP13s.jpg"
            }
          },
          type: "image",
          dark_background: false
        }
      },
      staff_pick: true
    }
  ]
}

@aaronschachter @jonuy
CC: @angaither @DFurnes

Looks ok to me except for question..

:+1:


octodns-sync --continue

I'm not sure how it works with multiple workers, but when you only have one, any error in applying any record will stop octodns-sync. Most of the time I would perfer the worker to continue its job, apply what it could, and report the different errors it encountered at the end. Is it a feature you would be interested in? Would a --continue flag make sense for this?

Not opposed to the idea, but it may be pretty complicated to implement safely in practice, especially with the providers that support dynamic records that involve many api calls to modify.
In general providers try and do their best to make changes in safe order, e.g. add a new "pool" of IPs to a dynamic record before modifying the "rules" so that we won't remove rules that point to valid existing pools if we failed to create a new "pool"
There are possibly similar, though less involved, cases like that with non-dynamic records.

What I'm proposing is to jump to the next record, not to the next API call. If we can't create a new pool, we wouldn't try to modify the rules, just record the error and forget that record. Am I missing something obvious?

Some providers have APIs that support batch/group changes of records so there's not a clear boundary between records when they're making changes. E.g. Route53 fails the whole batch if any one change isn't valid/going to be applied in which case the code would have to figure out which change set item(s) were causing problems and try the others.

I see. That means we would have to implement, for each provider that uses batches, a mechanism to find out which record is faulty when an error happens, and then to rebuild the batch request without that record. Right?


Optional lazy loading of C dependencies

A common source of questions in gitter and issues here are people who write cargo install diesel_cli and don't have all the backends installed. This was less of an issue when we only supported 2 backends. It's becoming a bit more of an issue with 3 (though I still think the situation is better than the alternative of having cargo install diesel_cli not work, and require backends to always be specified).
What I'd like to do is optionally allow our C dependencies to lazily load the dylibs, and not need to be present for linking. That means that you'd only see an error about mysql if you tried to run CLI with a MySQL URL (and we can probably provide a better error message than the linker is providing). I'd like to keep the footprint on this small, as I don't expect anybody to use this functionality besides Diesel CLI.

I think this is one of the bigger 1.0 blockers. I can figure this out if needed, but if there's someone with more experience in this space we would love a PR for this

Just talked to @skade who's now searched for and found the cargo install diesel-cli --no-default-features --features "postgres" incantation three times. I was about to open an issue to add some info on diesel-cli's feature flags to its Readme file, but it turns out they are just to enable backends (or clippy) and this issue here will make these docs useless anyway.

Would it also be possible to also ship diesel cli as a binary? For example, half of my hefty heroku build times are just building the CLI.

@skade Are you using https://github.com/sgrif/heroku-buildpack-diesel ? If so just add a .diesel-version file to the root of your repo and the CLI build will be cached.

This isn't happening for 1.0


chore: use gha to publish to npm

Codecov Report

Merging #21 (609d2c2) into develop (66dbc63) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff            @@
##           develop      #21   +/-   ##
========================================
  Coverage    94.01%   94.01%
========================================
  Files           11       11
  Lines          117      117
========================================
  Hits           110      110
  Misses           7        7


Missing dll on windows

When I run an example, I get errors which said that :

libgcc_s_seh-1.dll is missing
libwinpthread-1.dll is missing
libstdc++-6.dll is missing

I also have the following error in the python shell :
grpc._channel._Rendezvous: <_Rendezvous of RPC that terminated with:         status = StatusCode.UNAVAILABLE         details = "failed to connect to all addresses"         debug_error_string = "{"created":"@1564499126.880000000","description":"Failed to pick subchannel","file":"src/core/ext/filters/client_channel/client_channel.cc","file_line":3528,"referenced_errors":[{"created":"@1564499126.879000000","description":"failed to connect to all addresses","file":"src/core/ext/filters/client_channel/lb_policy/pick_first/pick_first.cc","file_line":399,"grpc_status":14}]}"
I run the script on python 3.7 with mavsdk 0.1.0 installed with pip3 install.
I tried on windows 10 and windows 7 with the same issue.

Building with Visual Studio? Would you have an idea what is missing in our CMakeLists for this to work correctly?

I installed the package from pip. But there is no need to build the package from source ?
Anyway I will try to see if it changes something

I installed the package from pip.

Right, sorry I missed that part. It's an issue at the mavsdk_server level: we are apparently not building it such that it runs standalone on Windows (because it relies on those DLLs you mention).
Let me transfer that to the MAVSDK repo.


[release/v0.4][UI]Ingress schema is not matched in steve

Refer to https://github.com/cnrancher/kube-explorer/issues/55
in v0.4 branch, ingress page also does not work.

fixed in v0.4.1-rc2 after bump ui version to v2.8.5


Call of Duty Mobile Garena Login Problem

Energized Protection - block ⚡

Let's make an annoyance free, better open internet, altogether!

Issue Submit Form

  Provide the following info properly, which will help us to resolve your issue quickly.

Issue(s):
Type x in between [ ] and make sure there isn't any space between brackets. Example; for Your Selected Issue(s), type like this - [x]
You can select more than one category of issues if you need to!

[ ] Whitelist
[ ] Blacklist
[ ] App Broken
[x] Website Broken
[ ] Request
[ ] Other Issue

Pack(s):
Write the name of the pack(s) you are using.

Pack(s) Name: Basic Protection

Extension(s):
Also name the extension(s) if you are using any. If you don't then leave it blank.

Extension(s) Name:

Domain(s):
If you are submitting this issue for whitelist/blacklist issue, send us the domain(s) for whitelisting/blacklisting here. Kindly use the Code Tag to prevent tracking.

Domain(s):

https://sso.garena.com

Your Config:
Just to ensure there is no issues or conflicts with other app/software/magisk module/extension/source list.
Make sure you are running Energized Protection Service only.

Client: Magisk Module

Version: 1.3.6 (Version: 6.32.08<IP_ADDRESS>1.09 Build Version: 22.10.301.09 Version Code: 3010905)

Detail:
Write us a lil bit more about your issue or query. You can attach any screen shot or log of the issue or advert, this will help to highlight it.

Your Issue Detail:
My issue is that I can't login on this website or through the application, namely CODM. here it says "Please enable cookies, refresh page and retry" after I uninstall energizedprotection and I tried to login, it worked. And I've made sure that the cookies permissions in my browser are active, I am also sure that my username and password are correct because I use google autofill. So please find out why that is and please fix this problem thanks.

Thank you for making Energized Protection great, with your kind help!
A project by Ador with ❤

I don't know what the version instructions mean so i put all the version, and i didnt use any blacklist or whitelist feature so i leave it blank and here the message i mean


Fix position:fixed in header

There's an extra position: fixed in the header class that is causing the logo to run off the side, and the header to overlap content. I ran webpack and it made a BUNCH of changes in the bundle...not entirely sure what's going on with that...I had to update my node-sass module so it may have just rearranged everything. I tested on my local branch with my fork after that bundling and things seem to be fine though.
I also removed views/geotix/node_modules from the tree.

Something weird apparently happened with bundle.css because looking back at commits to that file, there are some large ones from Derek that then aren't included in the history.


Adding nightly run feature,  fixing CloudWatch Log spelling & adding solution architecture overview

*Issue #, if available: Fixes #75 #59 #47 *
Description of changes:

Have added solution diagram for Issue #75
Have updated spelling mistake (related) for #59
Have added nightly run feature #47 . Nightly run feature (if enabled) will run at 23:00. It will determine if there are any deviations between the SSO Configuration and the solution (what is found in Amazon Dynamo DB). 2 remediation modes have been created to either automatically remove additional permission sets/account assignments and revert any changes made outside of the solution. The other mode is to notify a user of these changes.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@vpegg  , any issues with pushing the changes we've discussed last week?

LGTM, @jmejco  / @tamara-h  to do secondary validation with local deployment


get Location

Even though the bug was fixed i am still getting location doesnt exist exception. I have checked every possible way to resolve it. The set location is working fine and locations for documents are correctly set. When i try to retrieve these locations i get the previously mentioned exception. I used:
implementation 'com.github.imperiumlabs:GeoFirestore-Android:v1.5.0'
Firestore connection is checked, everything is working fine, this is a large scale app.
Please help me :)

I gave up on relying on this library for getting a location, despite the fact that location setting is still working. Instead I'm just getting the value manually as such (example in Kotlin)
fsDB.collection("LocationCollection").document("locationKey").get().addOnSuccessListener {
val geoPoint = it.data!!["l"] as GeoPoint
val locationOnMap = LatLng(geoPoint.latitude, geoPoint.longitude)}


fix(loader): work with escaped characters

We will now parse and escape the stringified .feature file when putting it in the template literal -
otherwise the escaped characters got parsed and we were getting syntax errors
fix #106

:tada: This PR is included in version 1.16.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

Hum. This is is THE breaking change I was looking for!
Actually I have lot of non-breaking spaces strings in my app.
So until now, we tested them with the \u00A0 character.
Example: 134\u00A0212\u00A0€.
All my tests are failing following the update.
Do you know how I can test my special characters now?
Thanks!

I'd be happy to take a look. Could you make a small repro and a separate issue?


Rename 2018-02-23-welcome-to-jekyll.md to 2018-02-23-welcome-to-testi…

checking for both

Deploy preview for nervous-mccarthy-41011b processing.
Building with commit f7f97917093203dc849de2739b1b284c4dee81dd
https://app.netlify.com/sites/nervous-mccarthy-41011b/deploys/5c956f5f20a0fe0007b2b8c0


[GSK-830] Business names

The user should :

Add business names to the dataset columns (asked by Malakoff)
Add business names to the categories of categorical columns (asked by Etam)

This can be an additional argument in the Dataset object where the user provides a list of mappings
From SyncLinear.com | GSK-830

ok

@jmsquare What do you think about a display in parenthesis for the business names in the UI:

To provide in the API, we should simply have an optional dictionary I guess, something like this:
business_names = {
'Content': 'mail body'
}

category_business_names = {
  'days': {
    '1': 'Monday',
    ...
    '7': 'Sunday'
  }
}

Dataset(df, ...., business_names=business_names, category_business_names=category_business_names)

For editing in the UI I'm not sure where to put, maybe an edit in the datasettab add a setting icon that open a modal to setup business names(⚙):

let's keep it for the last moment in case there's time. Test part is more important


drivers: dma: Add GD32 DMA driver

Add support for GD32 DMA
Signed-off-by: TOKITA Hiroshi<EMAIL_ADDRESS>I verified ths PR with tests/drivers/dma/loop_transfer with GD32VF103(longan_nano board).

For gd32f4xx series, only dma1 support m2m, and should use multi-data mode.
I will try to create a patch to fix it tomorrow.

Hi, @nandojve , @teburd
Thank you for your review.
It's been a long review, but it's not the last.
Please also  #47504. 😃


feat: web3 signin

Codecov Report
Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (649ffba) 13.11% compared to head (fdedcc0) 13.32%.

Files
Patch %
Lines

rust/decentraland-godot-lib/src/auth/mod.rs
53.84%
30 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
+ Coverage   13.11%   13.32%   +0.20%
==========================================
  Files         106      107       +1
  Lines       13057    13123      +66
==========================================
+ Hits         1712     1748      +36
- Misses      11345    11375      +30

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Segfault when calling super at top-level with no arguments.

If enclosingClass is null, we can't proceed with compilation since we don't have its name.

Great job finding this bug!

Is that what you were thinking?

Perfect, thank you!


Delete all linked report when clearing optimistic chat and transaction error

Details

Clearing transaction error doesn't delete the report. This PR fix it by deleting all linked report of the transaction and its chat report.
Fixed Issues

$ https://github.com/Expensify/App/issues/43481
PROPOSAL: https://github.com/Expensify/App/issues/43481#issuecomment-2189292535
Tests

Same as QA Steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps
QA Steps

Go offline
Submit an expense to a new user
From another device, send a message to the user from step 2
Back to the main device, go online. The chat report of the new user will have a RBR.
Open the chat report and press the money request preview
Clears the error message
Verify you are navigated to concierge chat
(small screen) Go back and verify you land on LHN
Verify the chat and transaction report is gone from LHN

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/50919443/33159b67-9083-44cd-826e-6353d17323d3

Android: mWeb Chrome

https://github.com/Expensify/App/assets/50919443/eefe3ad6-e2b4-4b81-8de1-44cff1533469

iOS: Native

iOS: mWeb Safari

https://github.com/Expensify/App/assets/50919443/e12e2c79-c683-4c62-a48a-240205b007b4

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/50919443/925c7f38-5949-44e4-9bb2-faa0b3b7358c

MacOS: Desktop

https://github.com/Expensify/App/assets/50919443/a8cfad19-cc72-4f71-aba2-96eaf8c9f0b2

Having a problem with iOS native, really lagging.

Reviewing today. @bernhardoj Meanwhile, can you please fix the lint error?

Fixed.

Whoops, another lint.

Everything should be fixed now

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/user-attachments/assets/f4982b8a-1c81-434d-a7bb-a2dd9fa04d46

Desktop
https://github.com/user-attachments/assets/45393209-1fea-44c0-962f-c19a3eac42f3

iOS
https://github.com/user-attachments/assets/d8e71c9e-e44c-45ff-8224-36b2d9bd7aae

Android
https://github.com/user-attachments/assets/9ba4cb2b-b6ff-4409-a3f5-105357d907d7

Mobile Web - Chrome
https://github.com/user-attachments/assets/78b836f6-84b6-4988-8e7d-7a847e25a1ba

Mobile Web - Safari
https://github.com/user-attachments/assets/169a1246-bde0-49ab-8e15-5994c790089e

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/dae02539-d827-4b99-98ce-1ef8a7c6f1e5

MacOS: Desktop
https://github.com/user-attachments/assets/e9b9a4e1-5a49-45d4-99f2-837489cb93f2

Android: Native
https://github.com/user-attachments/assets/0c75cc63-9256-4def-9a4b-4ee50ea5b7f8

Android: mWeb Chrome
https://github.com/user-attachments/assets/b2e30fe7-0991-476f-8517-dc7354c9b805

iOS: Native
https://github.com/user-attachments/assets/4dc8889a-ed3c-484e-8336-d5ace334c73c

iOS: mWeb Safari
https://github.com/user-attachments/assets/389cd024-7d36-442e-993e-92408a176e53

@bernhardoj The recent changes seem not to work as the navigation to concierge chat fails. Please have a look at the test video below.
https://github.com/user-attachments/assets/a8067754-49fe-48a8-8498-2833868a4d20

It works fine for me even though it redirects to the concierge chat instead of the concierge chat itself, but that's another bug of navigateToConciergeChat.
https://github.com/user-attachments/assets/c3d6f10d-769a-4842-bb09-ade4955415cd

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.0.7-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 9.0.7-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.7-8 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.8-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Chrome tests don't run if it's not the last environment

Fixed in https://github.com/Neft-io/neft/commit/9718f19824e330252e2685e2c3601affae1de1a6


Get  [?] when unicode Chinese "一"

Many thanks for your junidecode lib!
But I get garbled output when I try to unicode Chinese one ("一").
System.out.println(net.gcardone.junidecode.Junidecode.unidecode("一"))
The output is as follow. It should be "yi".
[?]
Is it a bug？ is there a workaround?
Thanks again

Please fix it.


chore: upgrade tektoncd pipeline module to 0.32.4

Signed-off-by: ankitm123<EMAIL_ADDRESS>Also upgrades go version to 1.18

/retest

/retest

/retest

/approve

/hold

/hold cancel

Killed the jobs manually, as they had passed before.

related to https://github.com/jenkins-x/jx/issues/8283


docs(@angular/cli): add handling environment variables

add instructions on handling environment variables

Closing in favour of this PR


MAX_SIZE

I have deployed your Salt channel protocol on TCP on Windows and Linux and I am also working on deploying RS232. In the program, I use a TCP channel with a Salt channel, so the server provides a chat room service, where each client connected to the server can send data and the server forwards it to clients that are connected to the server. I use the salt channel protocol to create a handshake and to encrypt and decrypt the data. I started testing the program and everything went well until I started playing with the size of the transferred data. If I use the maximum size of the data to transfer, as you specified in the example (UINT16_MAX * 4), everything is OK, even larger sizes still work fine, but if I set a much larger data size, the salt_write_next function returns an error. I want to ask, is the protocol limited by the size of the transmitted data? If I want to transfer a lot of size of data, would it be better if I divided the input data into blocks of size X and forwarded those blocks through the channel?

I work in block mode, where I use the select function to search for sockets that are ready for reading or writing.


Multiverse-Core breaks some P3 permissions

I know P3 is dead, I'm about to change to PEX soon aswell (I'm late and lazy), so don't judge.
Without Multiverse installed, my users can use /spawn and WorldEdit compass just fine. However, when I install the latest Multiverse-Core like normally, these two features (and /warp) stop working. It doesn't matter if I use the AB or a dev build, same result, yet different files.
However, if I change my permissions to theirs and reload my Permissions config, I can do these commands just fine. I still cannot do the commands I do not have permissions for (for example, kick). I'm also an OP, the others aren't. I just recently turned off opfallback to false.

I've created a new issue where you can discuss the actual issue at hand here (since this has nothing to do with P3 as it would turn out.) New issue is here: https://github.com/Multiverse/Multiverse-Core/issues/188


Unable to resolve path to module 'zoomist/css'.

Having the issue with css - import 'zoomist/css';
The above results with:
Cannot find module 'zoomist/css' from 'src/components/organisms/Component1.tsx'.
If I disable the error it works in storybook, but jest tests fail. Any idea?

For jest used the https://www.npmjs.com/package/jest-css-modules which sorted the issue.
Linter still complains about import 'zoomist/css';, but it does work.


[FLINK-4155] [kafka] Move partition list fetching  to open() for Kafka Producers

The fetched partition list from Kafka in open() is sorted by partition id
so that subtasks will have the same list across failures. To compensate the original
use of a KafkaProducer instantiation in the constructor to eagerly
ensure that required producer configs are provided, we check that at least
the bootstrap servers are set.
This change also includes:

Relocated tests in AtLeastOnceProducerTest to FlinkKafkaProducerBaseTest along with some other new tests for a more complete suite.
Directly instantiate a FlinkKafkaProducerBase in the Kafka table sink tests, instead of mocking (had to be mocked before because of the KafkaProducer in the constructor).

Looks good to me. I think it would be good if @rmetzger also had a look.
Concerning the Table sink tests and the mocking of the producer: Do these tests need a Kafka cluster running at all? They are just a think layer on top of the producer, which should be covered with Unit tests and not need a Kafka cluster.

@StephanEwen I think it makes sense to convert the table sink / source tests to unit tests that simply check they are using the Kafka consumer / producers correctly. Will include as part of this PR.

Did you refactor the table tests? If not, we can also merge this PR as is and file a follow up JIRA.
One other thing I thought about while looking over the PR: We need the partition list only for the partitioner.
So we actually need to do the getPartitions() call only if a partitioner has been set.
The PR is +1 to merge. Its up to you if you are doing the getPartition() call conditional with the PR, or whether we do it in a separate PR.

Thanks for the review @rmetzger.
No, actually I haven't refactored the table tests yet. I'll file up the follow-up JIRAs mentioned in the comments, and merge the PR as is.

Cool, thx.

Actually, IIRC, @twalthr already converted the table tests to unit tests in https://issues.apache.org/jira/browse/FLINK-4745. So, right now the table tests are already unit tests without running a Kafka cluster.
The only change regarding the table tests in this PR is that on the producer side (table sink), the producer had to be mocked because of the previous partition fetching in the constructor; this PR merely changes the mocking to directly instantiating.

Follow-up JIRA for conditional partition fetching:
https://issues.apache.org/jira/browse/FLINK-5128


TableSet.AddOrUpdate(IEnumerable) does not throw an exception on error

If there is an error while adding some record, AddOrUpdate method just exists silently without reporting an error. Is it expected behaviour?

I've also encountered this issue recently and have found the cause of it. In my call to TableSet.Add(IEnumerable<TEntity> entities) (or any other batched operation) I'm not interested in the returned entities so I simply call it like so
Table.Add(toAdd);

Unfortunately, because Add returns an un-executed IEnumerable and that I'm not evaluating it myself then the underlying execution never actually occurs.
From a client code perspective the solution is to just evaluate the result of the call, e.g.
var results = Table.Add(toAdd).ToArray();

However, I can see many people falling into this trap as you often don't care about getting the entity back after an add. To solve this, the simple fix of evaluating the execution of the batches in TableRequestSequentialExecutor does the trick
Old
return from batch in batches
    from result in _cloudTable.ExecuteBatch(batch)
    select _entityConverter.GetEntity((DynamicTableEntity)result.Result);

New
return from batch in batches
    from result in _cloudTable.ExecuteBatch(batch).ToArray()
    select _entityConverter.GetEntity((DynamicTableEntity)result.Result);

I'll submit a pull request for this fix soon.


Sidecar stopped submitting stats to StackDriver after prometheus eviction on GKE

We had stackdriver-prometheus-sidecar working on our GKE cluster without issues for a few days until the prometheus pod where the server and this sidecar resided was evicted. The pod was relocated automatically by the scheduler and Prometheus continued collecting data without issues. However, the sidecar stopped submitting data to StackDriver. We can manually query the data from Prometheus without issues, there's no discernible missing data.
Versions:
prom/prometheus:v2.6.1
gcr.io/stackdriver-prometheus/stackdriver-prometheus-sidecar:release-0.3.1
Prometheus Logs:
level=info ts=2019-01-26T15:28:19.524238548Z caller=main.go:243 msg="Starting Prometheus" version="(version=2.6.1, branch=HEAD, revision=b639fe140c1f71b2cbad3fc322b17efe60839e7e)"
level=info ts=2019-01-26T15:28:19.524313035Z caller=main.go:244 build_context="(go=go1.11.4, user=root@4c0e286fe2b3, date=20190115-19:12:04)"
level=info ts=2019-01-26T15:28:19.524350038Z caller=main.go:245 host_details="(Linux 4.15.0-1019-gcp #20-Ubuntu SMP Wed Aug 29 09:24:47 UTC 2018 x86_64 prometheus-server-c64fd76c-msmv5 (none))"
level=info ts=2019-01-26T15:28:19.524380622Z caller=main.go:246 fd_limits="(soft=1048576, hard=1048576)"
level=info ts=2019-01-26T15:28:19.524485977Z caller=main.go:247 vm_limits="(soft=unlimited, hard=unlimited)"
level=info ts=2019-01-26T15:28:19.525637533Z caller=main.go:561 msg="Starting TSDB ..."
level=info ts=2019-01-26T15:28:19.527003933Z caller=web.go:429 component=web msg="Start listening for connections" address=<IP_ADDRESS>:9090
level=info ts=2019-01-26T15:28:19.574606943Z caller=repair.go:48 component=tsdb msg="found healthy block" mint=1548244800000 maxt=1548266400000 ulid=01D1Y8722N7PQF05HFZWCSFMK2
level=info ts=2019-01-26T15:28:19.599054445Z caller=repair.go:48 component=tsdb msg="found healthy block" mint=1548266400000 maxt=1548331200000 ulid=01D2060M2RPVQJBJ53YRAQNRV6
level=info ts=2019-01-26T15:28:19.601827225Z caller=repair.go:48 component=tsdb msg="found healthy block" mint=1548331200000 maxt=1548396000000 ulid=01D223SQDT2MRJR8E8XMKXJ3BE
level=info ts=2019-01-26T15:28:19.621762297Z caller=repair.go:48 component=tsdb msg="found healthy block" mint=1548396000000 maxt=1548460800000 ulid=01D241K5Z5ZM6GHAJ6QFZX8PJY
level=info ts=2019-01-26T15:28:19.622993701Z caller=repair.go:48 component=tsdb msg="found healthy block" mint=1548460800000 maxt=1548482400000 ulid=01D24P696MFWW21CJZJGNEC14Q
level=info ts=2019-01-26T15:28:19.635275773Z caller=repair.go:48 component=tsdb msg="found healthy block" mint=1548504000000 maxt=1548511200000 ulid=01D25ASCGQ3N7HAHP75Q15SRVX
level=info ts=2019-01-26T15:28:19.636098417Z caller=repair.go:48 component=tsdb msg="found healthy block" mint=1548482400000 maxt=1548504000000 ulid=01D25ASDY6Y1S5K0AJZSCYB6GR
level=info ts=2019-01-26T15:28:39.425314438Z caller=main.go:571 msg="TSDB started"
level=info ts=2019-01-26T15:28:39.425436903Z caller=main.go:631 msg="Loading configuration file" filename=/etc/config/prometheus.yml
level=info ts=2019-01-26T15:28:39.683670989Z caller=kubernetes.go:201 component="discovery manager scrape" discovery=k8s msg="Using pod service account via in-cluster config"
level=info ts=2019-01-26T15:28:39.734034519Z caller=kubernetes.go:201 component="discovery manager notify" discovery=k8s msg="Using pod service account via in-cluster config"
level=info ts=2019-01-26T15:28:39.735718748Z caller=main.go:657 msg="Completed loading of configuration file" filename=/etc/config/prometheus.yml
level=info ts=2019-01-26T15:28:39.735774879Z caller=main.go:530 msg="Server is ready to receive web requests."

Sidecar Logs
level=info ts=2019-01-26T15:28:18.633697598Z caller=main.go:256 msg="Starting Stackdriver Prometheus sidecar" version="(version=0.3.1, branch=release-0.3.1, revision=12aa811802effd7a93b6b7d83d72bf381f1179b9)"
level=info ts=2019-01-26T15:28:18.633825024Z caller=main.go:257 build_context="(go=go1.11<EMAIL_ADDRESS>date=20190103-20:48:32)"
level=info ts=2019-01-26T15:28:18.633857706Z caller=main.go:258 host_details="(Linux 4.15.0-1019-gcp #20-Ubuntu SMP Wed Aug 29 09:24:47 UTC 2018 x86_64 prometheus-server-c64fd76c-msmv5 (none))"
level=info ts=2019-01-26T15:28:18.633878294Z caller=main.go:259 fd_limits="(soft=1048576, hard=1048576)"
level=info ts=2019-01-26T15:28:18.646053105Z caller=main.go:463 msg="Web server started"
level=info ts=2019-01-26T15:28:18.646116703Z caller=main.go:444 msg="Stackdriver client started"
level=warn ts=2019-01-26T15:28:21.653132839Z caller=main.go:525 msg="Prometheus not ready" status="503 Service Unavailable"
level=warn ts=2019-01-26T15:28:24.652898547Z caller=main.go:525 msg="Prometheus not ready" status="503 Service Unavailable"
level=warn ts=2019-01-26T15:28:27.651712449Z caller=main.go:525 msg="Prometheus not ready" status="503 Service Unavailable"
level=warn ts=2019-01-26T15:28:30.652042511Z caller=main.go:525 msg="Prometheus not ready" status="503 Service Unavailable"
level=warn ts=2019-01-26T15:28:33.652120435Z caller=main.go:525 msg="Prometheus not ready" status="503 Service Unavailable"
level=warn ts=2019-01-26T15:28:36.652012708Z caller=main.go:525 msg="Prometheus not ready" status="503 Service Unavailable"
level=warn ts=2019-01-26T15:28:39.652032741Z caller=main.go:525 msg="Prometheus not ready" status="503 Service Unavailable"
level=info ts=2019-01-26T15:29:42.652116635Z caller=manager.go:150 component="Prometheus reader" msg="Starting Prometheus reader..."

We can see through docker stats that the CPU activity on prometheus and the sidecar is around 800m each. If we remove the sidecar, Prometheus drops to 5-10m.
I'm guessing that this may be related to the repair.go messages on Prometheus' logs so we let the sidecar work. However, after a few hours there's still no progress or logs. Our data dir is around 600mb, it shouldn't take that long so it seems that it's stuck.
We have added   --log.level=debug to the sidecar but there's no difference except during the shutdown phase that shows a "Stopped resharding":
level=warn ts=2019-01-26T16:39:23.977263853Z caller=main.go:392 msg="Received SIGTERM, exiting gracefully..."
level=info ts=2019-01-26T16:39:23.977387876Z caller=main.go:432 msg="Stopping Prometheus reader..."
level=info ts=2019-01-26T16:39:23.97741396Z caller=queue_manager.go:233 component=queue_manager msg="Stopping remote storage..."
level=debug ts=2019-01-26T16:39:23.977513514Z caller=queue_manager.go:441 component=queue_manager msg="Stopped resharding"
level=info ts=2019-01-26T16:39:23.977599116Z caller=queue_manager.go:241 component=queue_manager msg="Remote storage stopped."

Here's the information you requested:
targets.json.txt
prometheus.yml.txt
Please let me know if you need anything else.

Hi @lkoba,
we've likely identified the issue and will push a fix soon. Once it's in, you might want to give this another shot.

Thanks! Just let me know when, and I'll test it.

Hi @lkoba,
We've identified an issue that negative cache in targets doesn't work as we expected, and it may make sidecar keep querying targets API and block the traffic. We fixed this issue with #91.
We've released a new release v0.4.0 including #91, and you may want to try it out.
Thanks again for reporting the issue!

Hi @lkoba,
Just want to follow up on this thread. If you ever test the new image, let us know whether you encounter any issue. My team will be happy to hear your feedback!


[neon] Optimize sgemv 2.0

This PR includes:

Optimize sgemv transpose with partial summation

50% faster sgemv_transpose in case of large scale Tensors
Support every column length (bugFix)

Optimize sgemv noTrans with more variables

20% faster sgemv in case of large scale Tensors

:octocat: cibot: @skykongkong8, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2331-202310161110070.92925405502319-6ca2264547f6ea831bacdd443b1c43a51c915e89/.


docs: request for triager role for jake32321

I have read and understood the project's Contributing guide.
I also have read and understood the process and best practices around Express triaging.
I request for a triager role for the below orgs:
jshttp
express

🥇 Welcome! 🥇
To make sure we get all the clean merges we want, I have decided to wait until tomorrow to merge all of these.  I have not sent the invites yet, but I will when we merge.
cc @expressjs/triagers

Roles added and merged in 4eeccb6c.


Make compilation of SnarkyJS inductive rules type-safe

This PR reworks the conversion between SnarkyJS rules and Pickles' Inductive_rules.t. This now uses a GADT to hide the type variables that are unneeded.
Checklist:

[ ] Modified the current draft of release notes with details on what is completed or incomplete within this project
[ ] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[ ] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[ ] All tests pass (CI will check this if you didn't)
[ ] Serialized types are in stable-versioned modules
[ ] Does this close issues? List them

Rebased onto develop, since technically this doesn't need to depend on #11319, and it would be better to land sooner rather than later.


chore: add @middy/core v6 as peer dependency

Summary
Changes

Please provide a summary of what's being changed
This PR adds @middy/core v6 as a peer dependency

You can not use @powertools-lambda-typescript and @middy/core v6

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number:
Closes 3367

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

ok - have changed it so that only one test is changed to use middy v6

Thank you for addressing the comment.
Tomorrow morning (EU time) I'll run some more in depth manual tests and familiarize myself with the changes in v6.
If there's no blocker and CI is green I'll merge this PR so that the change can land in the next release.


Change "tcp" to "http" for L7 LB

I think the intent is to have the last example use the layer 7 LB.  Shouldn't that then read "http" and not "tcp"?

Good catch, thanks!


Improper extraction

Hello.
I have an extracted DV stream, that when i convert with -m 2, seems to behave improperly.
I can provide you the extracted stream on my ftp server, contact me at<EMAIL_ADDRESS>

Seems to behave improperly? What does it do?

The progress stop at 34%, and the output file created is obviously too small.

An error on the HDD is not something you think/expect, anyway, redone the extract and everything was fine, so i close.
And big thanks for the tool !


Allow zero response options in the topic/prompt

Some prompts may not ask participants to click and select an item from list. They may just say "please discuss this topic". If there are no response items listed, the prompt should still display.
Need to update the validation in server/src/callbacks.js so that it doesn't fail, and also the topic.jsx so that it displays correctly.

closed by https://github.com/Watts-Lab/deliberation-empirica/pull/298


pullapprove: Don't require doc team sign-off for vendor docs.

Change the pullapprove config to ignore vendored documentation files.
Signed-off-by: James O. D. Hunt<EMAIL_ADDRESS>

Coverage decreased (-0.3%) to 74.863% when pulling 063cb313f6bc8314cec03b743bb8d40223a70726 on jodh-intel:ignore-vendor-doc-changes into 8b2978d044f5efce201d5f2977fcc51b89e742c0 on clearcontainers:master.

lgtm


Incorrect DTW path for Euclidean distance?

I'm struggling understanding a very simple example. I boiled it down to the following test:
from fastdtw import fastdtw
from scipy.spatial.distance import euclidean, sqeuclidean
def test_euclidean_distance():
    q=[0,1,2,3,4,5,6,7,8]
    r=[1,2,3,4,5,6,7,8,0]
    distA, pathA = fastdtw(q, r, radius=2, dist=euclidean)
    distB, pathB = fastdtw(q, r, radius=2, dist=sqeuclidean)
    assert all([a==b for a,b in zip(pathA, pathB)])
    assert distA*distA == distB   # 9*9 == 65 fails

Since the paths are the same I would expect to that also the distances are the same. The correct Euclidean distance should be sqrt(65) (only first and last elements of the input vectors contribute). Since it is 9 it looks like the Manhattan distance is used instead of the Euclidean distance.
I have the feeling that I miss something simple. But could someone give me a hint?

The path is the same for both dtws.  When you look at the errors, you can see they come from the first element q[0]=0, p[0]=1, and the last element q[8]=8, p[8]=0.
The euclidean distance is abs(p[0]-q[0]) + abs(p[8]-q[8]) = 1 + 8 = 9
The square euclidean is (p[0]-q[0])(p[0]-q[0]) + (p[8]-q[8])(p[8]-q[8]) = 1 + 64 = 65
So the outputs are correct.  The second assert is wrong.  The second distance value is the sum of the squares of each individual euclidean element, not the square of the sum of euclideans.


listener: add optional stat_prefix to use instead of listener address

Commit Message:
Additional Description:
Risk Level: Low
Testing: Added unit test
Docs Changes: added
Release Notes: added
Platform Specific Features: none
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

/retest


Updated explanation when maximum timeout will be used

Hey @nsuma8989, can you tell me a bit more about where this came from? Was there a support case relating to this?

@mbelton-buildkite yep, we've had a couple of folks ask for clarity on this this week

@mbelton-buildkite As @mcncl mentioned we got few customers reaching out for clarification on this so that was the reason behind this PR. Please let me know how we want to proceed on this

Two small issues to fix, then all good :)

Thank you. I applied those changes.

Looks good! Merge when you're ready :)


Crash on non-patient node selection

The patient data is changed when a node is selected. Currently, there is a crash when a node other than a patient (like city) is selected.
Also, we need a better handler for different node selections.

I think you're referring to the crash on the 'City' filter? Yes, that has to be fixed, but I'm fairly sure it's an issue with the data, and I've taken it up with the Ops team on Telegram.

I pushed a fix for this


Setting up jestrunner.jestPath option also for folder.

I am setting up schematic for nx to create a svelte application with tests. So I am setting the option jestrunner.jestPath to point to the jest executable in the node_modules folder in the file .vscode/settings.json. This option is only available in a per user or per workspace setting. When the nx workspace is created as a folder in a vscode workspace, then this folder setting is ignored in a folder level. Therefore I have to set this setting in the vscode workspace settings. It would be nice for the user experience, if this setting would also be recognized as a folder setting, which I can generate automatically with nx schematics.

Hey @floratmin
not really understanding what u are trying to achieve, could explain it in more detail? or maybe post a picture of your repo?
vscode-jest-runner should detect jest bin / folder automatically based on the jest.config.js location.

@floratmin could you check 0.4.29 there was a bug in 0.4.28 which could have caused your issue?

with the newest version jest runner automatically pics the nearest jest binary from the hierarchy which may also fix your issue,
please re-open a new issue, if you still have problems.


Can not run Jawset Postshot with ZLUDA

Running Postshot with ZLUDA just closes cmd after few seconds.
Anything i could try, or debug this?

yeah same


chore: set beelocal branch to update-k3s-0.30.3 and go 1.23 upgrade

Checklist

[ ] I have read the coding guide.
[ ] My change requires a documentation update, and I have done it.
[ ] I have added tests to cover my changes.
[ ] I have filled out the description and linked the related issues.

Description

Updated Go version to 1.23.
Upgraded K3s version to 0.30.3.
Updated golangci-lint version to 1.61.0

Open API Spec Version Changes (if applicable)

Motivation and Context (Optional)

Related Issue (Optional)

Screenshots (if appropriate):

Please take a moment to carefully review the following commit: f8dee190.
Some comments are in the code, and some comments are in the commit itself.

Also it seems that ScalarMult is also deprecated, but linter doesn't report the issue. Here is one of the the function calls


feat(ui-context): Add selected theme to user context

add theme to userContext defined to light or dark

@Noha-ElAbrouki the Theme should be exported from the index.ts file from ui-context.
I also suggest that we rename it into UserTheme so that it dosen't conflict with the existig theme that we have in centreon-ui


Allow use of static or dynamic linked libjnitests

Allow use of a static or dynamically linked libjnitests based of file extension.
Allow functionality for Windows or Linux based file extensions by using the "os.name" property.

Can't. 'Permission denied'
I have no objection to you making the change.

If you push the commit to your own fork it should be added here

I did. Changes aren't showing up here

@paddy74 Can you try resubmitting a PR? Thanks

Done. See PR #10

Thank you!


Need help in pointing to Workspace file

Hello, I have modified our project structure and after that, Xcode test step is no more able to find Workspace file. Basically, we have moved everything inside a folder named ios
Previous settings:
Environment variable Workspace paths resolves to : App.xcworkspace

New settings:

I have just changed path the workspace as ios/app.xcworkspace.
Also I have changed $BITRISE_SOURCE_DIR to $BITRISE_SOURCE_DIR/ios

Xcode test steps fails saying can not file the workspace file

closing this as I had a typo in my path

Thanks for reporting @Abdul-Hannan and glad to hear you found the solution! :)


Get rid of schema compare double scrollbar

This removes the double scrollbar by setting the overflow of the splitview container to hidden.
Before with double scroll bar:

Now:

Also keeps the tool bar visible at all times!! :)


"Table Valued Parameters" function bindings does not work as documented.

The code given at
https://github.com/MicrosoftDocs/sql-docs/blob/live/docs/relational-databases/native-client-odbc-how-to/use-table-valued-parameters-odbc.md
has a function called demo_variable_TVP_binding.
On line 795:
SQLPutData(hstmt, &Qty, sizeof(SQLINTEGER));
This does not capture the return value, but the next line apparently wants to test the return value.
Thus guarantees that the function will always fail without accomplishing its intended function because r is guaranteed to be SQL_NEED_DATA by the surrounding while loop.
If we fix this line by adding "r = " to be beginning of this line, the function still doesn't work, because despite the calls to tell the driver no more rows ( r = SQLPutData(hstmt, SQLPOINTER(1), 0); on line 782, the SQLParamData function on line 804 keeps returning SQL_NEED_DATA and asking for another row with the code as written here, which seems like it has not been tested. I can't make the function work.
This is the same result I got in my own coding attempts from the reference, it keeps asking for more rows despite there being no more rows. I really need an example program that works with specification of minimum driver versions that make it work (if that might be the second problem).
I have tried it with the latest drivers even though these were created long after this document was written.
There has been no success getting anyone at Microsoft support to even look at the issue or even identifying the right support team that would look at it. They take my money and give me the URL of the incorrect documentation. Everyone is content to keep publishing false documentation. But someone should be responsible for this documentation being wrong and how to make the functionality work.
Or give me a document certifying the obvious to my managers, that Microsoft is an unsupported OS and database and give me a refund of the support incident that you encouraged me to open.

@RayWhitmer - thank you for resubmitting this issue. I'm tracking down appropriate and authoritative responses.
CC: @rwestMSFT , @rothja

@RayWhitmer  please look at the docs again; we believe the page you refer to has been corrected.

The correction does seem to solve the problem of the infinite loop (I would characterize this as the most significant issue with an erroneous API call, which resembles a nearly-magic incantation gone wrong).
You should also fix the problem on line 795 that I mentioned first in the report (add "r =") or the example fails out without even reaching the previous infinite loop now fixed to terminate correctly, because r continues to hold SQL_NEED_DATA which got it to this point in the logic, which causes it to exit as an error because it was not updated with the (successful in this case) result of the call.

"Closed again" but not complete without the fix on line 795.

I failed to say, v-chojas, thanks for the fix. It completely unblocks me.
Fixing line 795 would give your documentation a code snippet that works, which seems like a win for you.

@RayWhitmer -- Ray, thank you for your follow-up.  I am updating line 795.

@RayWhitmer -- Ray, this update is already in the live article:  https://github.com/MicrosoftDocs/sql-docs/blob/live/docs/relational-databases/native-client-odbc-how-to/use-table-valued-parameters-odbc.md
I am closing this issue now.  You are welcome to @ mention me for any followup.  We hope to hear from you again.