Protoss War Council rebalance checklist

Creating a checklist for the war council rebalance sheet here: https://docs.google.com/spreadsheets/d/1hObgY0_T7O94AOJ6wVCElEex-sE6JKQmIMsQO2oshpA/edit
Some upgrades are already implemented as default tech in the AP_Triggers_giveProtossDefaultTech() action, I'll try and capture them here. @MadiMadsen would be nice if you could confirm what you implemented already, I see Zealot, Centurion, Sentinel, Void Ray, Phoenix, etc. I also notice some Supplicant and Slayer upgrades that seem unrelated. I am also unsure what the recommended testing configuration is, I'm hoping to shift things over to a client option soon.

I used the unit test map and basically tested the unit until I had the proper rebalanced version and then I gave it a research trigger and turned it on and to make sure the upgrade worked properly.
And for organization sake I put all these upgrades to be on by default in archipelago triggers together I did not worked on anything above the comment so I cannot validate that those are fully functional.

small correction: it looks like the changes i made to supplicant were undone
one of zik's recent commitments undid the upgrades given to supplicants by default for the purposes of this rebalance.

Noting some feedback and ideas that I won't be able to implement during the first half of holiday time:
Resource efficiency

Resource Efficiency upgrades are very invisible; consider adding icons to the unit command cards
Several people have said Centurion resource efficiency feels way too punishing

Consider reducing the nerf to 25 gas
Consider replacing the nerf with one to charge (stun isn't very touchable as that's what distinguished centurions from other zealots)

"I don't think I've ever bought a full price instigator LOL" / "instinctually I look at the price of the instigator and write it off unless I don't have another option (which hasn't happened yet!)" --Venat, 2024-12-19

Maybe change the nerf to a movespeed nerf? Could encourage more blink usage

Sentinel RE feels good; no need to rework beyond maybe a command-card icon

Scout

The scout will get a buff-style war council upgrade (ie don't nerf the baseline)
Scouts are powerful units with very good anti-air and disappointing ground, but at a bad price-point. They do well vs armoured air and when massed up
There is a possibility of remapping an already-implemented scout upgrade to be the war council upgrade

Candidates are RE, movespeed, or anti-ground damage
With discussion on RE above, that doesn't seem the best route forward

phaneros: could lean into Scout identity as the most bulky basic flyer and give them a +health/shields upgrade

I believe that removing the gas cost from Centurions entirely is a terrible misunderstanding of why the Sentinel WC upgrade works.
Zealots serve three purposes, and they've served these purposes since SC1:

They have no gas cost, allowing them to be used as a mineral dump.
They have high durability for their cost, making them effective at dying in place of more valuable units.
They are Protoss's best answer to light units until T3

I think players forget that third one; I did, until I tried playing through the Prophecy and early LotV missions with pure Stalker.  Even in situations where the player doesn't have leftover minerals, Zealots are so much more effective against Zerglings, Hydralisks, Marines, and Protoss Gateway units than Stalkers are.  The only units with similar or better effectiveness against Light have a high gas cost and high tech requirements.
WC Sentinels are balanced with vanilla Zealots because they cost 60% more and do 0% more damage.  If the player is against a large amount of units that aren't Armored (or specialize in killing armored units) and they don't have the gas or unlocks to support Colossi, Zealots are a superior choice over Sentinels.  If light units are solved by other methods, Sentinels are a better tank.
Removing Shadow Charge from the Centurion does not make them significantly worse at any of the three strengths of Zealots.  The still have no gas cost, they still have high durability, and they only do slightly less DPS against light units at the start of the battle.  In exchange for having virtually no drawbacks, they get one of the strongest CC tools in the game?  That's ludicrous.
We can reduce the gas cost to 25, maybe, but I can't envision any non-gas nerf to the Centurion that would make the player consider Zealots over them.  Even if Darkcoil were removed (and it shouldn't be) they're still a direct upgrade over vanilla Zealots due to Shadow Charge being a straight upgrade over Charge.

Reducing Instigator movespeed could be interesting, though!


Filter

Hello,
Can I try to filter it from the body?
I tried to filter after OS, but I am always getting bad requests.

Hey Claudiu
OS filtering is not supported for that report
https://learn.microsoft.com/en-us/mem/intune/fundamentals/reports-export-graph-available-reports#devices-report


Fix: Moesif Plugin Version Support and Support

@lena-larionova We see the categories were removed after some customers mentioned they couldn't find the Moesif Kong plugin due to this PR. Moesif is a Kong Tech partner and already has contracts in place, joint customers, and validation, so it shouldn't be marked as "unsupported".
Description

Fix categories for Moesif plugin

Testing instructions
Preview link:
Checklist

[X ] Review label added
[ ] Conditional version tags added, if applicable.

For example, if this change is for an upcoming 3.6 release, enclose your content in {% if_version gte:3.6.x %} <content> {% endif_version %} tags (or if_plugin_version tags for plugins).
Use any of the following keys:

gte:<version> - greater than or equal to a specific version
lte:<version> - less than or equal to a specific version
eq:<version> - exactly equal to a specific version

You can do the same for older versions.

@d19dotca merged upstream


Example 2 misleading

The believe the second example on this page:
https://docs.microsoft.com/en-us/powershell/module/exchange/set-mailboxautoreplyconfiguration?view=exchange-ps#example-2
is misleading as:
Set-MailboxAutoReplyConfiguration -Identity<EMAIL_ADDRESS>-AutoReplyState Enabled -InternalMessage "Internal auto-reply message." -ExternalMessage "External auto-reply message."
Will only work if the -ExternalAudience parameter had already been provided in a previous command against the mailbox, and set to Known or All, as indicated by the details of the -ExternalMessage parameter:
The value of this parameter is meaningful only when both of the following conditions are true:
The AutoReplyState parameter is set to Enabled or Scheduled.
The ExternalAudience parameter is set to Known or All.
I suggest it be replaced with this:
Set-MailboxAutoReplyConfiguration -Identity<EMAIL_ADDRESS>-AutoReplyState Enabled -InternalMessage "Internal auto-reply message." -ExternalMessage "External auto-reply message." -ExternalAudience All
With the description being updated to:
This example configures Automatic Replies for Tony's mailbox to be sent and includes an internal and an external message, and specifies the external message be sent to any external address.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 47db52ff-7c4b-3051-5414-3e1288216c1e
Version Independent ID: 0e49597f-47e8-ec2a-9e1b-46bc465643cb
Content: Set-MailboxAutoReplyConfiguration (ExchangePowerShell)
Content Source: exchange/exchange-ps/exchange/Set-MailboxAutoReplyConfiguration.md
Service: exchange-powershell
GitHub Login: @chrisda
Microsoft Alias: chrisda

And I'm also realizing how many times I've probably set the external message with powershell and not specified that 🤦

@pstakuu, done.
Thanks for the feedback.
Closing.


separate json and protobuf message

Codecov Report

Merging #172 (d41ac99) into main (318bb13) will decrease coverage by 0.02%.
The diff coverage is 88.57%.

@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
- Coverage   77.74%   77.71%   -0.03%
==========================================
  Files          15       15
  Lines        1640     1719      +79
  Branches      492      518      +26
==========================================
+ Hits         1275     1336      +61
- Misses        349      367      +18
  Partials       16       16

Impacted Files
Coverage Δ

src/integration-tests/serialization/message.pb.ts
83.75% <84.00%> (-2.19%)
:arrow_down:

src/autogenerate/index.ts
96.20% <96.12%> (-0.54%)
:arrow_down:

src/runtime/compatCheck.ts
100.00% <100.00%> (ø)

src/runtime/server/index.ts
44.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 318bb13...d41ac99. Read the comment docs.


Adding LINK and UNLINK

LINK and UNLINK have been accepted as allowed method.
http://tools.ietf.org/html/draft-ietf-httpbis-method-registrations-12
http://www.chmod777self.com/2013/08/sigh.html

Any news?


Null or undefined fragments throw a weird error

Posted originally by @deoqc at https://github.com/apollostack/react-apollo/issues/143

I tried to use fragments but got error undefined is not an object (evaluating 'definition.kind') in line 46 of getFromAST.js.

We should identify invalid fragments earlier and throw a better error.

We no longer deal with fragments directly, so I don't think this should be apollo-client's job any more.


Aria Roles on Phosphor Menu Widgets

Problem:  Roles missing
Proposed Solution:

Add a method for adding roles in widget class
Add roles in the menu/item classes.

General strategy, just to make sure we're on the same page.

High level div containing the whole menu gets role="menubar"
Individual children that instantiate menus e.g. file, edit, run, etc. get role="menuitem" not role="menu" (this is critical)
The ul for a "file" or "edit" or "run", then gets role="menu"
Children at any level get role="menuitem", so the link that says "file" and then individual children of "file" all get role="menuitem".
If something like file has children, which it does, it gets aria-haspopup="true" to indicate it has children e.g. that it is a submenu.
If something is a parent, again like "file", "edit", "run", etc. then they also need an aria-expanded="false" when they are collapsed and aria-expanded="true" on it being expanded. Note please, that the initial state needs to have aria-expanded="false" and then JS can togle these states back and forth. Often times the initial value of aria-expanded is left off.


feat: add OutgoingRequestInterface

Description
See #6573

add OutgoingRequest
add OutgoingRequestInterface
CURLRequest extends OutgoingRequest
Request extends OutgoingRequest
RequestInterface extends OutgoingRequestInterface

http://www.plantuml.com/plantuml/uml/ZP1TQWCX58NVNSKX2-XJ5n38IuMKbf0kGEoTGUhFLAzGADrxnQOIbCpaRPXpplUf-yGgSdPMB4f_g9cmEyZ77Ru501ZF52Ub2S-KKadb_uykViay1-Fd4trcIjnge2yc_vwszhTsDy6Y0hHLgR5Xt6B9aUTHrze3iPb6oYWVQJsbcrpJrguWlGvkE5JRrAOFJE2m84nzl-Q0yZ2N0F52caB4q_dy-b0x1Levr-x3KTwhRTKjOock2DzEnurtwyrrCwZ3twYfE-MFs9VlxEml
@startuml
package "CI4" {
    interface MessageInterface
    interface OutgoingRequestInterface extends MessageInterface
    interface RequestInterface extends OutgoingRequestInterface

    class Message implements MessageInterface
    class OutgoingRequest extends Message implements OutgoingRequestInterface
    note top of OutgoingRequest
      an outgoing request.
    end note

    class Request extends OutgoingRequest implements RequestInterface

    class IncomingRequest extends Request
    note top of IncomingRequest
      an incoming request for HTTP.
    end note

    class CLIRequest extends Request
    note top of CLIRequest
      an incoming request for CLI.
    end note

    class CURLRequest extends OutgoingRequest
}
@enduml

Checklist:

[x] Securely signed commits
[ ] Component(s) with PHPDoc blocks, only if necessary or adds value
[ ] Unit testing, with >80% coverage
[x] User guide updated
[x] Conforms to style guide

I'm not sure if you implemented it this way because of the restrictions in our current HTTP layer, but the inheritance path for requests is confusing. What is restricting us from making Request a common base for both Incoming and Outgoing, and those not being in the same path?

PSR-7: MessageInterface > RequestInterface (outgoing) > ServerRequestInterface (incomming)
This PR: MessageInterface > OutgoingRequestInterface (outgoing) > RequestInterface (incomming)

What is restricting us from making Request a common base for both Incoming and Outgoing

CI4's Request is incomming request.

 TIL an incoming request is actually an outgoing request with some extra methods.
So next question... why the new class? If we already have Message > Request > IncomingRequest, what is stopping us from making Request into the equivalent of OutgoingRequest? (sorry if this is obvious, it is very hard to flip between interfaces on mobile)

what is stopping us from making Request into the equivalent of OutgoingRequest?

The reason for adding the new class is to make as few changes as possible.
RequestInterface is incoming request in CI4.
If we change Request to outgoing request, it seems better to change RequestInterface to outgoing request.
Then we need to add  IncommingRequestInterface.
Do you mean like this?
MessageInterface -> Message
OutgoingRequestInterface -> Request
RequestInterface -> IncommingRequest

I'm with you now, took me a little bit. The structure and names are confusing, but that's not your fault. I would like to look at this one more time on desktop, but generally I think it is a good direction and you should feel free to proceed with the docs.

Added changelog.


does kingfisher support image encryption ?

I am starting switching to Kingfisher and I have a question regarding to the security issue. Can cached images be encrypted ?

You could do that by implementing your own CacheSerializer. Please read the cheat sheet in wiki for more on it.

From the cheat sheet in wiki, I created my own CacheSerializer named NewSerializer like below
struct NewSerializer: CacheSerializer
{
    public func data(with image: Image, original: Data?) -> Data? {
        return RNCryptor.encrypt(data: original!, withPassword: "123456789")
    }

    func image(with data: Data, options: KingfisherOptionsInfo?) -> Image?
    {
        var image = Image()
        do {
            image = try UIImage(data: RNCryptor.decrypt(data: data, withPassword: "123456789"), scale: 1)!
        }
        catch{

        }
        return image
    }
}

For the first method, I'm currently using RNCryptor for encryption and decryption.
From the sample code, I am doing:
_ = (cell as! CollectionViewCell).cellImageView.kf.setImage(with: resource, placeholder: nil, options: [.cacheSerializer(serializer)], progressBlock: nil, completionHandler: { image, error, cacheType, imageUrl in
            print("\(cacheType, indexPath.row): Finished")
        })

I am facing an issue :
From the cache folder located at :../Library/Caches/com.onevcat.Kingfisher.ImageCache.default/,  some of the images are still be previewed.

Any thoughts about this.

Just took a look at the RNCryptor and tried your code. It works perfect for me and all images are encrypted and decrypted without problem. None of them could be previewed:

Are these images you could preview downloaded before you apply the encrypting cache serializer? You could try a ImageCache.default.clearDiskCache() to clean your disk cache and have another try.

@onevcat: I figured it out. The reason I am able to preview some of them is because prefetching image process which is currently using default serializer. In order to encrypt, I have to pass my own serializer to ImagePrefetcher like following
ImagePrefetcher(urls: urls, options: [.cacheSerializer(serializer)]).start()
and then everything works like expectation.


add script requirements

These are the dependencies I ran the most recent deletion with.

Is the requirements.in file meant to be empty?

Is the requirements.in file meant to be empty?

Whoops! The pitfall of two-stage commit, an IDE, and a person not paying enough attention


Implement sort by interview feature

Resolves #113

Codecov Report

Merging #117 (43446be) into master (87a4aa1) will increase coverage by 2.85%.
The diff coverage is 97.36%.

@@             Coverage Diff              @@
##             master     #117      +/-   ##
============================================
+ Coverage     59.42%   62.28%   +2.85%
- Complexity      512      544      +32
============================================
  Files            99      100       +1
  Lines          1878     1901      +23
  Branches        226      231       +5
============================================
+ Hits           1116     1184      +68
+ Misses          701      647      -54
- Partials         61       70       +9

Impacted Files
Coverage Δ

src/main/java/seedu/application/model/Model.java
50.00% <ø> (ø)

...ain/java/seedu/application/model/ModelManager.java
85.47% <96.15%> (+0.56%)
:arrow_up:

...plication/logic/commands/SortByCompanyCommand.java
100.00% <100.00%> (ø)

.../application/logic/commands/SortByDateCommand.java
100.00% <100.00%> (ø)

...ication/logic/commands/SortByInterviewCommand.java
100.00% <100.00%> (ø)

...lication/logic/commands/SortByPositionCommand.java
100.00% <100.00%> (ø)

...du/application/logic/parser/SortCommandParser.java
100.00% <100.00%> (ø)

...edu/application/model/application/Application.java
65.62% <100.00%> (+14.04%)
:arrow_up:

...ion/model/application/interview/InterviewDate.java
75.00% <0.00%> (ø)

...ation/model/application/UniqueApplicationList.java
60.71% <0.00%> (+8.33%)
:arrow_up:

... and 5 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


crash out

just 3 second after open bat file it will be close!

Same here in Windows

This issue needs to be addressed with your pool operator / mining software developer


Implement struct: histogram

Histogram data structure.

I migrated the data::Histogram type during the migration of the data module in 7d65745ec2ad879a57a778cf052f6917328bb627. All that we require now is to document and provide unit tests for it. This is also a part of issues #16 and #17.

Merged into main as part of PR 21 (https://github.com/aetherus-wg/Aetherus/pull/21) on 2022-01-10. Closing issue.


Add Support for AWS::EC2::FlowLog

VPC FlowLog was added in most recent update to CloudFormation:
Documentation

Hi,
Can this be closed please and merged into master branch? Need this asap for a client's project.
Cheers.

This was added in https://github.com/cloudtools/troposphere/pull/507 so it's already in the master branch.
@dnarwani I assume you mean that  you need a new release?

See https://github.com/cloudtools/troposphere/pull/507

#507 merged


KONFLUX-1611: Add labels, licenses & user to Dockerfile

Description

Add labels
Add default user
Add licenses under /licenses/

Requirements come from https://docs.redhat.com/en/documentation/red_hat_software_certification/2024/html-single/red_hat_openshift_software_certification_policy_guide/index#additional_resources and would prevent us from releasing an image (we have an exception for "based_on_ubi image")
How was this code tested?

Assignees

/cc @rccrdpccl
/cc @adriengentil
Links

Checklist

[x] Title and description added to both, commit and PR
[x] Relevant issues have been associated
[x] Reviewers have been listed
[x] This change does not require a documentation update (docstring, docs, README, etc)
[x] Does this change include unit tests (note that code changes require unit tests)

/retest


[Bug]: End of response stream is of type 'NoneType' using OpenAILike model, resulting in an TypeError

Bug Description
When generating a response stream (i.e. with print_response_stream()), i get an TypeError as the generation of the response concludes. The response is fully generated at that point, but I still get

TypeError: can only concatenate str (not "NoneType") to str

For details see the logs below.
I'm using Llama-Index with LocalAI, but not sure if thats related.
These are the models I used:
https://huggingface.co/TheBloke/em_german_leo_mistral-GGUF
https://huggingface.co/TheBloke/Mixtral-8x7B-Instruct-v0.1-GGUF
Version
0.10.10
Steps to Reproduce
from llama_index.llms.openai_like import OpenAILike
from llama_index.core import VectorStoreIndex, SimpleDirectoryReader, Settings

LOCALAI_DEFAULTS = {
    "api_key": "localai_fake",
    "api_type": "localai_fake",
    "api_base": f"http://localhost:8080/v1",
}

documents = SimpleDirectoryReader("data").load_data()
Settings.llm = OpenAILike(model="<model>", timeout=60.0, **LOCALAI_DEFAULTS)
index = VectorStoreIndex.from_documents(documents)
query_engine = index.as_query_engine(streaming=True)
response = query_engine.query("<Insert a question>")
response.print_response_stream()

Relevant Logs/Tracbacks
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
Cell In[20], line 3
      1 query_engine = index.as_query_engine(streaming=True)
      2 response = query_engine.query("<Here stands a question>")
----> 3 response.print_response_stream()

File ~/chatbot/chatbot-env/lib/python3.11/site-packages/llama_index/core/base/response/schema.py:122, in StreamingResponse.print_response_stream(self)
    120 if self.response_txt is None and self.response_gen is not None:
    121     response_txt = ""
--> 122     for text in self.response_gen:
    123         print(text, end="", flush=True)
    124         response_txt += text

File ~/chatbot/chatbot-env/lib/python3.11/site-packages/llama_index/core/llms/llm.py:71, in stream_completion_response_to_tokens.<locals>.gen()
     70 def gen() -> TokenGen:
---> 71     for response in completion_response_gen:
     72         yield response.delta or ""

File ~/chatbot/chatbot-env/lib/python3.11/site-packages/llama_index/core/llms/callbacks.py:224, in llm_completion_callback.<locals>.wrap.<locals>.wrapped_llm_predict.<locals>.wrapped_gen()
    222 def wrapped_gen() -> CompletionResponseGen:
    223     last_response = None
--> 224     for x in f_return_val:
    225         yield cast(CompletionResponse, x)
    226         last_response = x

File ~/chatbot/chatbot-env/lib/python3.11/site-packages/llama_index/llms/openai/base.py:441, in OpenAI._stream_complete.<locals>.gen()
    439 else:
    440     delta = ""
--> 441 text += delta
    442 yield CompletionResponse(
    443     delta=delta,
    444     text=text,
    445     raw=response,
    446     additional_kwargs=self._get_response_token_counts(response),
    447 )

TypeError: can only concatenate str (not "NoneType") to str

lame, why is localai sending None in deltas during streaming lol
will need to update the OpenAI LLM class to fix

@logan-markewich I am still suffering from this with OpenAI-Like with LiteLLM--Ollama--Mixtral:8x7B today, and thus with this change https://github.com/run-llama/llama_index/pull/14365.


Tooltip/popover - change the default value for fallbackPlacements

The default value for fallbackPlacements has been changed already in #32405 and here are the remaining things to do.
What this PR does:

Remove null from fallbackPlacements types
Change the default value for fallbackPlacements
Update docs for the tooltip/popover

Why to remove null from fallbackPlacements types and keep array:

The default value was previously (in v4) 'flip' that can be achieved by passing the single value in the array, like — [oppositePlacement]. Keeping null also sets the fallbackPlacements to [oppositePlacement] (Default value in Popper)
It's better to have clockwise (['top', 'right', 'bottom', 'left']) fallback options so that tooltip/popover can be placed to another side even if the opposite placement doesn't fit.

BTW #32384 is caused because the default value for fallbackPlacements is [oppositePlacement] in Popper and if you check the issue on a bit larger screen, it is not reproduced.
As per Popper's documentation:

If the fallback placement doesn't fit, it reverts back to the original placement.

Not enough space on right (That's why did not flip)
Enough space on right (Flipped)
After setting clockwise fallback placements in #32405

All SS are from v5.0.0-beta1
This PR probably completes the third todo of #32354: Update docs after #32405
Preview: https://deploy-preview-32437--twbs-bootstrap.netlify.app/docs/5.0/components/popovers/#example

Should we mention this in migration notes @rohit2sharma95 ?

Mentioning it would be better because now the default fallback placement has been changed.


[bug]   use additional_browser_args

Describe the bug
how to use additional_browser_args in the fn main()?
fn main() {
    tauri::Builder::default()
        .setup(|app| {
            let window = tauri::WindowBuilder::new(app, "label", tauri::WindowUrl::App("index.html".into()))
              .with_additional_browser_args("--disable-features=msWebOOUI,msPdfOOUI,msSmartScreenProtection")
              .build()?;
            Ok(())
        })
        .invoke_handler(tauri::generate_handler![])
        .run(tauri::generate_context!())
        .expect("error while running tauri application");
}

it's not work,
Reproduction
No response
Expected behavior
No response
Platform and versions
Environment
  › OS: Windows 10.0.22621 X64
  › Webview2: 110.0.1587.63
  › MSVC:
      - Visual Studio Enterprise 2022
  › Node.js: 18.14.2
  › npm: 9.5.0
  › pnpm: 7.27.1
  › yarn: 1.22.19
  › rustup: 1.25.2
  › rustc: 1.67.1
  › cargo: 1.67.1
  › Rust toolchain: stable-x86_64-pc-windows-msvc

Packages
  › @tauri-apps/cli [NPM]: 1.2.3

Stack trace
No response
Additional context
No response

Please always post the whole output of tauri info. The important stuff is missing.
additional_browser_args is not yet released so you either need to wait for tauri 1.3 or use tauri from git https://tauri.app/v1/guides/faq#how-can-i-use-unpublished-tauri-changes


Feature request - Drop down lists: choose item with first letter

Firstly, thank you very much for this software. I was able to move smoothly from VimFX for modern Firefoxes.
Coming from VimFX, I miss one thing: the ability to select an item in a drop down list by typing the first letter.
Example:
Let be this list in a web form:

foo
bar
baz
qux
quux

The first item is selected by default. Let's say I want to select 'baz'. Pressing 'b' selects 'bar', pressing 'b' again selects 'baz'.
I guess this is the usual behavior of Firefox, but Saka Key seems to override it.
Thanks,

I should mention this doesn't seem like a feature request; it's actually a bug, as it's essentially blocking an accessibility feature every browser have. One can even consider this a regression, as it reduces the ability to use the browser only with your keyboard.


NSFS should return content-type application/x-directory for dirs

Environment info

NooBaa Version: 5.12
Platform: OpenShift 4.12

Actual behavior

Currently dirs return applicaiton/octet-stream like any other file.
This fails with presto trying to validate it - https://github.com/prestodb/presto/blob/6306290fb92223c51185efdc694f7dcaeb9ff020/presto-hive/src/main/java/com/facebook/presto/hive/s3/PrestoS3FileSystem.java#L377
This related PR added the ability to set/get content-type using xattr - #7390 - but this will not work if the directories are created from the FS or replicated from somewhere else.

Expected behavior

Directories should report content-type application/x-directory.

Steps to reproduce

npm run nsfs .
mkdir logs
aws --endpoint http://localhost:6001 s3 cp --content-type applicaiton/x-directory /dev/null s3://logs/dir/
aws --endpoint http://localhost:6001 s3api head-object --bucket logs --key dir/

More information - Screenshots / Logs / Other output

we suspect many customers will have already existing data on some s3 bucket somewhere (on-prem or in cloud).  and in order to query this existing dataset, lakehouse admin/user need to create an external table to point to this existing data.
unfortunately this is often enough and running into this issue is painful and tedious.  its not impossible but the steps required to resolve the issue makes it unfriendly.
it would be great if we can prioritize this issue


feat(native_filter_migration): add transition mode

SUMMARY
As part of Superset roadmap and SIP-64, by the end of this year 2021, Superset will not support filter_box anymore. This PR is to create a transition mode for dashboards with only filter_box (and without filter component):  when feature flag ENABLE_FILTER_BOX_MIGRATION is enabled,  dashboard will automatically convert filter_box to dashboard native filter component in front-end only, so that user can review the converted dashboard, then save or abandon change in case any issues found.
This PR is mostly designed for airbnb users who used dashboard for many years, and had large dashboards with many charts, tabs, and scoped filters. Manually convert filter_box to filter component for us will be a nightmare. This PR is to make sure our heavy dashboards can go through a smooth transition to the next state. For dashboards that have mixed filter_box and filter components, we assume the size of dashboard is pretty small and the number of filter_box must be manageable, the dashboard owner should convert their filter_box manually.
At the end of transition time, we will run db migration which hard converts all filter_box into filter component in dashboard.
Note:  The major goal for this PR is to define different dashboard and filter_box behavior during transition time. I may need to add a few small UI change PR to improve, but don't want to make this PR too big to review.
During transition time, this is dashboard and filter_box status under different state:
Existing dashboard:

Creating new dashboard:

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before

After

For users having filter_box and enabled ENABLE_FILTER_BOX_MIGRATION feature flag:

For users having filter_box but without ENABLE_FILTER_BOX_MIGRATION feature flag:

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[ ] Has associated issue:
[x] Required feature flags:
[x] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[x] Introduces new feature or API
[ ] Removes existing feature or API

@kgabryje @michael-s-molina Just rebased with master and added fixes for 2nd review. Thanks!

Thanks!  @jinghua-qa  i will focus my tests with enabled feature flag ENABLE_FILTER_BOX_MIGRATION.

Sure, i will post the test result once i finished.

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_DASHBOARD_NATIVE_FILTERS_SET=true FEATURE_DASHBOARD_FILTERS_EXPERIMENTAL=true

@michael-s-molina @jinghua-qa i found a small issue during my test (still about dashboard left margin) and pushed extra fix. You probably have to test with latest build. thanks!

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_DASHBOARD_NATIVE_FILTERS_SET=true FEATURE_DASHBOARD_FILTERS_EXPERIMENTAL=true

I have completed the Native Filter manual test with migration FF off, did not see major issue, LGTM.
Here is the test run I executed:
https://docs.google.com/spreadsheets/d/1qqwd5qiyHN306tdBjd-e5G3t4czB7q1FdWSVrAg-_Y8/edit#gid=1933521616


fix: bump edge-runtime to 1.62.2

What kind of change does this PR introduce?
Bump edge-runtime to 1.62.2
Changes
1.62.2 (2024-11-13)
Bug Fixes

sb_ai: Sessions are dropped while still in use (#443) (e522925) (@kallebysantos)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 59.649%

Totals

Change from base Build<PHONE_NUMBER>0:
0.0%

Covered Lines:
6386

Relevant Lines:
10706

💛  - Coveralls


cargo nextest --version's output seems wrong?

$ cargo nextest --version
cargo-nextest-nextest 0.9.66
$ ~/.cargo/bin/cargo-nextest --version
cargo-nextest 0.9.66

The output of cargo nextest --version is cargo-nextest-nextest 0.9.66, I think this is not right?

This is an artifact of how cargo-nextest is invoked: via a cargo-nextest binary that has a nextest subcommand. I guess it's worth fixing.

This is now fixed as of 0.9.79:
% cargo nextest -V
cargo-nextest 0.9.79 (ec7861ab7 2024-10-02)

% cargo nextest --version
cargo-nextest 0.9.79 (ec7861ab7 2024-10-02)
release: 0.9.79
commit-hash: ec7861ab7c27a63f036eca5fb3bbe67bbe1c0dd1
commit-date: 2024-10-02
host: x86_64-unknown-linux-gnu


fingerprinting

I want to address this reddit post
First of all, test sites like Panopticlick etc are flawed, especially when returning entropy. I'm not knocking the sites or what they do to raise awareness etc, just providing some context that almost everyone I see commenting on reddit and elsewhere get completely wrong. The information returned is all you should be concerned about - i.e: see what is returned by the browser. Generally speaking, the data sets are

not real-world (that's not the test site's fault, that's the nature of providing such a site)

the tests attract those interested in the topic, and are instantly biased/compromised

e.g Firefox in many of these tests is up as high as 35-40%

users trying to lower their entropy score (tiny changes, repeat tests)

this pollutes the data set

repeated tests of the above users

this lowers the entropy of some metrics

it is a self fulfilling prophecy: let's take for example that canvas (unaltered) is always a unique value. This instantly makes every user unique, and it will always be the highest entropy item. This makes users research, ask questions and leads them to blocking their canvas, or using RFP (or random spoofing) - with repeated tests. Now we have the situation where RFP canvas is (from memory) about 1 in 30. This is INSANE. I call BULLSHIT that 3.3% of the world uses RFP. Are you seriously saying that of the 6% of users worldwide who use Firefox/Tor Browser... that over half of them have RFP enabled? Come on! (note: this is not a perfect example, because other browsers and extensions can also return the same 10x10 white canvas that RFP does, but I bet it's insignificant)
UPDATE 30th Jan 2019: now that Panopticlick is back up and running, they have reset their dataset. The RFP 10x10 white canvas hash of a273d6a847f0e2a57fa0161158f12fed is tracking at 1 in 7 (actually lower than that and coming down every day, it was 7.5 a few days ago, now its 6.75). Yeah right! See previous bullet point.

not current

they incorporate old data e.g. real world metrics on UA suffers
some sites allow a time range, others (I think Panopticlick did this) reset their data set

not relevant

they could use real world metrics such as 6% are Firefox, and extrapolate from that

small (especially if you were to filter results for a recent time frame)
limited (some tests need upgrading, others need to be introduced)

I was going to provide some examples but cannot get Panopticlick to finish loading the results. I did a few days ago, but it's playing up again/
I'm too busy to find the link, but there was (details from memory) a real world study done approx a year ago  in France, using millions of visitors on a popular site(s). This is how you get metrics. The results showed up a lot of flaws in people's thinking IMO.
Use math and science, as the Tor Uplift and Tor Project do, and you'll find the real world metrics fall into line. The real world test above validated this IMO. I should find the paper for you.

This comment needs addressing

Absolutely useless. The whole user.js thing makes you more unique and as thus easier identifiable (imagine how many people use that specific user.js over people who "just" have a Tor fingerprint).
You achieve privacy by looking like everybody else not by changing as much as possible. The more you change the more unique you actually become. That is why I am saying just toggle RFP, Container tabs and disable webgl and nothing else. That is also why Tor says to not change the defaults.
Afaik RFP should make FF identical to Tor for websites (though not sure need a dev verification here). If you trust Tor then it is enough. If you don't trust Tor then there is literally no escape for you.

Let me start by saying that FP'ing is overrated - but becoming more mainstream since the rise of adblockers in the last few years - e.g reddit now includes a first party version of fpjs2. You control FP'ing by controlling what you allow to run in your browser. 95% of the FP attack surface is third parties and a couple of FP items (e.g canvas - because it's so easy to drop in, and it makes you unique). The tracking industry are the ones who drive this in the wild, and they have so much lower hanging fruit, that it is not worth their time and effort to use many metrics (not that we shouldn't keep them in mind and build defenses against them).
Also, looking at things such as mixed content (which can be controlled on a site by site basis) are pretty much useless metrics from a tracking perspective. So are x,y screen / window / inner window position metrics, so are cookie & persistent storage permission metrics, so are permission metrics (geo, notifications etc - prompt/block) and I could name more. They just aren't consistent enough.

Absolutely useless [subsequent post: Though keep in mind I am talking about that specific user.js.]

To the author of that comment: I sincerely hope you didn't mean the user.js, because if you did, then I think you have completely misunderstood the purpose of this user.js. If you were replying to the strategy of using RFP and falling back to Canvas Blocker in fake mode, then I fail to see how that is useless. It's very valid. If you are using RFP then you need to look like the set of the RFP users, and this strategy allows you to use sites that need canvas to work but still not uniquely FP you.

The whole user.js thing makes you more unique and as thus easier identifiable

Every single browser (except Tor Browser, I'll address that later) is unique when you do nothing. The user.js is can't do everything. It's limited in scope. First and foremost you want anonymity, privacy and security (don't confuse what these are). That means a trade-off. By blocking for example SSL Session IDs - you are already in a super tiny uber small group of users, should that be used as a metric.  So it's a question of : do you value anonymity over the possible tracking of you by linking various web activities? SSL Session IDs is a server side tracking rather than a FP, but it still a metric, so maybe not the best example of a FP metric. But the main point stands - that anonymity, privacy and security come first. FP'ing doesn't necessarily damage these either, but is of course addressed where possible. It's always about trade-offs.
Control what happens client side. For myself (uMatrix) I only allow first party css and images - I think gorhill calls it nightmare mode. Even so, just using uBO with default filters kills a lot of this stuff.
We explicitly tell users to use extensions in the user.js and provide a wiki and suggest extensions, and rules, and so on.

The more you change the more unique you actually become ...

Do almost nothing to your browser except turn on RFP. You are still unique (or extremely close to it). I can detect your real FF version via feature detection, I can get your font fingerprint including if you disable sites using their own fonts, and disable JS (I can grab them via CSS, and a lot of them). I could go on.
Everyone (Firefox) is already unique (or very close to it) regardless of what you do - IF sites and trackers wanted to get that - hence .. reduce the attack surface is your best defense, and have some fallbacks - the user.js here actually doesn't disable or change a lot of things for this reason eg we don't disable gamepads because it is a metric, we don't disable geo (which is behind a prompt) because that's another bit of entropy, and so on.

That is why I am saying just toggle RFP, Container tabs and disable webgl and nothing else

RFP is not enough in Firefox. It is no where near being complete. You are still unique. Containers do nothing for FP'ing. WebGL helps .. but OMG .. you are now in a super tiny percentage worldwide: FF users with no WebGL .. now add RFP to that and you are even more unique .. now let me get some more metrics you didn't think of .. you ARE unique (still)
You will not defeat FP'ing (if it really wanted to) in Firefox (yet). Control what happens client side. Reduce the attack surface.

You achieve privacy by looking like everybody else not by changing as much as possible

You have to change shitloads in order to look like everybody else .. no wait a minute .. everybody else is unique - there is no "everyone else". What you are trying to do is lower entropy and that only works when you enforce a set of users - such as Tor Browser and Firefox RFP users (in the user.js we actually MAKE SURE that people don't change prefs that affect the RFP fingerprint - see section 4600). RFP is no-where near finished.
Also, this really has nothing to do with privacy. The word you are looking for is anonymity, although it's more tracking than anything else (you may have never leaked you real ID in this particular setup). Please don't mix these up. Anonymity means never linking back to the real you. Privacy means no-one else but the sending and receiving party can read it. And tracking is all about linking activities together (which can break your anonymity).

over people who "just" have a Tor fingerprint

Only Tor Browser (TB) users have a Tor fingerprint, and there are a few of them because not everything can be spoofed. You cannot mask this. It is easily detectable no matter what you do. TB is not trying to hide the fact that it is TB, and FF is not trying to hide the fact that it is FF, even with RFP - and no matter what you do or change to look like TB, you will always be FF, and easily spotted. So now you are in a super extraordinarily tiny minuscule group if not actually unique (again, since you were n a default FF even with RFP on).
Again, TB is a set where all the rules can be enforced, so the entire set of users look the same (as much as possible, e.g you can still easily detect the platform with a simple 3 font check - so there will always be some fragmentation). RFP on Firefox is not "enforced" (yet), e.g some prefs will alter the fingerprint.
The user.js actually says, at the top (and in our short readme here at GitHub), to consider using TB if it meets your needs. This user.js is not trying to be the Tor Browser sans Tor protocol.

Afaik RFP should make FF identical to Tor for websites

Not even close - years to go. And that is not the purpose of Tor Uplift. TB can enforce things, FF can't. TB can disable APIs, FF can't because it is a mainstream browser that needs to work with standards. For this reason, RFP can only do so much (for now) - sure, they could make RFP disable WebGL, disable Audio API, and so on - but then there would be no uptake by FF users when they give it a UI presence - and that damages the numbers - you need a sizeable set of users with the same FP in those metrics covered by RFP, in order for RFP to be effective.
I think I've typed enough for today (understatement of the week)

I should find the paper for you.

https://hal.inria.fr/hal-01718234/document

We analyze 2,067,942 browser fingerprints collected from one of the top 15 French websites. The observations made on this novel dataset shed a new light on the ever-growing browser fingerprinting
domain

That's the paper, I'm sure. I'm going to re-read it

^^ I'll have yet to re-read it (e.g evaluate what FP metrics they looked at), but... right at the start [emphasis mine]

The key insight is that the percentage of unique fingerprints in this dataset is much lower than what was reported in the past: only 33.6% of fingerprints are unique by opposition to over 80% in previous studies. We show that non-unique fingerprints tend to be fragile. If some features of the fingerprint change, it is very probable that the fingerprint will become unique

IMO, lowering entropy is the ONLY way to go. Raising entropy thru frequent randomization is a loser's game :trollface: trollface specially for @KOLANICH :)
I'll also point at this: https://hal.inria.fr/hal-01717158/document <- which is a little old, and they used RAS as an example (which is pre Quantum), but it shows that inconsistencies and the lies that are told by the extension were easy to spot. I can do the same to a lot of chameleon's spoofing, such as screen and timezone. And all that does is make you more unique.
Once again, all the experts (that I can find) have been saying for the five years or so I've been reading them ... to lower entropy. It's not quite that simple, but I'm not here to write a book (I think)

If some features of the fingerprint change, it is very probable that the fingerprint will become unique

IMHO not a problem, since the fake fingerprint is useless for linking profiles.

but it shows that inconsistencies and the lies that are told by the extension were easy to spot.

Is there any papers where the lies were generated by a neural net?

Is there any papers where the lies were generated by a neural net?

I don't know what you mean by that. Can you elaborate?

IMHO not a problem, since a fake fingerprint is useless for linking profiles.

Did you read the paper? Of course, each item would need to be looked at in isolation, so I don't want to speak in generalizations. What I'm getting at is two fold
First: When you lie and get caught, that in itself is more entropy. That's OK if everyone in the group lies the same way - e.g TB users fibbing that their browser and screen are the same as the inner window. But take UA (JS navigator and HTTP headers), and lets say you lie about the browser (in your randomness) and claim to be chrome or safari - the lie is easily detected and you have more entropy. You will be one of a very very very very very very small group of FF users who randomize their UA, same with canvas (as you rightly point out, random faking on each request is a dead giveaway: whereas RFP is up front and everyone always looks the same). And I could go on, but each metric needs evaluation within it's own right.
Second: that when lying, it starts to get complicated. RFP patches get complicated too, when new features or APIs get added, e.g Intl.DateFormat. They're still trying to hide the real OS as much as possible. It's in the tor design doc somewhere. Patches that lower entropy but are plausible are so much  less work to maintain.
That said, there is nothing wrong in theory with randomizing constantly. It;s the same as lowering entropy - it needs large numbers ... AND ... you still need to mask the real values from other vectors.
What the paper says is that if someone changes a metric, they are more likely to become unique - i.e there are a small subset of various results that encompass most users: you know what I mean - e.g 10% of the fingerprints catered for 90% of the users. Fiddling with those in anyway would most likely make you unique - e.g see the example (from memory) of the accept header : change Windows8.1 FF to WIndows8.1 Chrome, but then you need to also change the http header.
They didn't say anything about randomizing it - I did, and that was probably the wrong way to put it.

 Or MacOS? Or MacOS X?
If you do, can you go to my test page and paste me the results for math.cos() - don't forget to say the droid version :)
This set of values can determine OS. They're stable across ESR60, FF60-to-FF66, so test with any FF version you like. Definitely after some newer android version results and mac stuff (not iOS cuz thats the shitty webkit thing)

^^ in case it's not clear, that just the last three digits that change

FYI: https://antoinevastel.com/browser fingerprinting/2019/02/19/canvas-fingerprint-on-the-web.html - aint read it yet . getting naked and drunk AF

hows everyone's BS entropy going?
Here's mine: FF66

and here's TB8.0.9

Guess who's actually less FP'able?

Here's mine: FF66 macOS

Excellent BS there @seanob86 ... I see you have your toolbar toggled on (height is fubared by a few pixels). Interesting font selection.

OK thanks for the feedback regarding the toolbar. I've now disabled it and regarding the fonts I had in my overrides the following
user_pref("browser.display.use_document_fonts", 1);
user_pref("gfx.downloadable_fonts.woff2.enabled", true);
If I disable the above overrides and just use what's in the user.js file I now get the following

No need to change your toolbar being on/off. It's a bug: everyone else will be the same as you on Mac with a default toolbar density (and at least one bookmark)

Here's some more BS for you guys

On the left is someone who uses the ghacks user.js and they posted it as an image on some forum
On the right is me: I always block cookies: and the entropy for that is 6.29 and overall I am 1 in just over 4K with 11.9 entropy.

I noticed that this was the one thing that stood out as being higher. So I cleared all data, allowed a session cookie for panopticlick, and redid it = the pic below, on the right
In every single metric, my entropy is lower (except cookies where I am 0.01 higher, and language which is the same).
However, overall OP is 10.63, and I am 14.7. Look, overall entropy isn't adding up all the individual numbers (kinda, but not really). But linux (op) vs win32 (me) .. and 1000x900 (tor sizes) vs 1600x900 (pretty common screen res) - I mean come on.


Jacoco action

Test.

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@6d3c7c7). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop       #1   +/-   ##
==========================================
  Coverage           ?   26.06%
  Complexity         ?      658
==========================================
  Files              ?      186
  Lines              ?     5704
  Branches           ?      606
==========================================
  Hits               ?     1487
  Misses             ?     4085
  Partials           ?      132

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d3c7c7...78e86e3. Read the comment docs.


[Bug]: Invalid type checking for stream:reduce with a stream with error as the completion type

Description
$title.
Steps to Reproduce
type Employee record {|
    int id;
    string name;
    decimal salary;
|};

public function main() {
    stream<Employee, error> stm = new stream<Employee, error>(new EmployeeStreamImplementor());

    // No compile-time error even though the completion type is error.
    // RHS type should be decimal|error
    decimal _ = stm.reduce(
        function (decimal total, Employee employee) returns decimal =>
                    total + employee.salary, 0d);
}

class EmployeeStreamImplementor {
    public isolated function next() returns record {|Employee value;|}|error {
        return error("err!");
    }
}

Affected Version(s)
2201.9.0
OS, DB, other environment details and versions
No response
Related area
-> Compilation
Related issue(s) (optional)
No response
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

Panics at runtime.
error: {ballerina}TypeCastError {"message":"incompatible types: 'error' cannot be cast to 'decimal'"}
        at test:main(test.bal:12)


Settings menu item doesn't work with installed version

It opens a new file, that cannot be saved, because the plugin is inside a .sublime-package and not unzipped. Need to change the settings command correspondingly. While on  it, consider adding a user specific settings file, and a project specific settings file.

When you create a folder named BrowserIntegration alongside the other settings folders, you can open the config through Sublime and save it. I pasted the following in there:
https://raw.githubusercontent.com/apiad/sublime-browser-integration/master/BrowserIntegration.sublime-settings
It's a workaround as long this issue is not fixed.


Revert "[MLAS] add the initial implementation of MLAS backend"

Reverts webmachinelearning/webnn-native#179

Now CI failure is not because of pulling onnxruntime, but because of linking execution.

[235/241] LINK ResNet.exe ResNet.exe.pdb
FAILED: ResNet.exe ResNet.exe.pdb
ninja -t msvc -e environment.x64 -- ....\third_party\llvm-build\Release+Asserts\bin\lld-link.exe /nologo -libpath:....\third_party\llvm-build\Release+Asserts\lib\clang\12.0.0\lib\windows "-libpath:C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\ATLMFC\lib\x64" "-libpath:C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\lib\x64" "-libpath:C:\Program Files (x86)\Windows Kits\NETFXSDK\4.8\lib\um\x64" "-libpath:C:\Program Files (x86)\Windows Kits\10\lib\10.0.19041.0\ucrt\x64" "-libpath:C:\Program Files (x86)\Windows Kits\10\lib\10.0.19041.0\um\x64" /OUT:./ResNet.exe /PDB:./ResNet.exe.pdb @./ResNet.exe.rsp
LLVM ERROR: IO failure on output stream: no space on device


Developing Guidance & Documentation for clim-recal

https://squidfunk.github.io/mkdocs-material/
@RuthBowyer could you please add some links to the Markdown files here?
Guidance: what you should do
Documentation: what you did

Before we go into creating a nice looking website using mkdocs, I would like to start by mapping out the individual elements in terms of guidance & documentation more closely by reworking the README. I suggest that the README contains some guidance (and links to further info where it gets too deep) and this guidance should be clearly split into different user groups, eg non-climate scientist and more expert researchers, because they will have different goals when interacting with the project. Here is a draft, maybe we can discuss this later today together
Structure

Intro (what is it, for whom)
ToC
Quick start guide (download repo, install dependencies & run small-scale example)
small-scale example as notebook
Guidance

For non-climate scientists (why BC, which BCs brief taxonomy viz, how to decide/flowchart)
For expert researchers (detailed technical guides, eg code examples & BC tutorials; how to contribute)

Documentation (divided into python & R pipelines?)

Installation & setup
Where to get data from & data format
functions docstrings
FAQs

Research (review, references)
License & contributors

Resources for good README

Turing Way best practices on Landing Page
example projects with guidance and documentation in readme

The part about downloading data from zure is only for internal info right? Or will this be outward facing info?
https://github.com/alan-turing-institute/clim-recal#accessing-the-pre-downloadedpre-processed-data

The part about downloading data from zure is only for internal info right? Or will this be outward facing info? https://github.com/alan-turing-institute/clim-recal#accessing-the-pre-downloadedpre-processed-data

Yes, this is for internal info and could be moved to another readme file or somewhere else, possibly with a link to it from the main readme.

I think this could be useful for our partners if this is how we share the data with them (which I think is still tbc?) jic you were unaware (see issues 37 and 38

The overview you've drafted looks great, @aranas!
Two additional example resources I'd add as README reference points for us are BIG-bench and EleutherAI's lm-evaluation-harness. These are two examples of creating standardised resources for evaluating and comparing LLMs on a range of tasks. I think BIG-bench is better documented atm and probably the better source of inspo for us, but the eval-harness is also going through a major refactor atm.
Beyond the README, another useful reference point is how they document tasks in a summary table for Big-Bench and task-table for the eval-harness. I recommend we add that as a priority so we (and any users!) have a standard map/naming we can use to refer to our different BC methods.

another example of a benchmark style repo but closer to home: https://github.com/duncanwp/ClimateBench

@gmingas prioritisation feedback: Guidance (e.g. step by step) of how to use the pipeline via CLI or notebook
@RuthBowyer feedback: we're still trying to figure out who the users are

@RuthBowyer atm according to the anlysis flowchart the Cropping_Rasters_to_three_cities.R script takes the resampled files and extracts data for three cities before passing on to further preprocessing (splitting into test & validate and eventually applying bias correction).
For me to include this into the pipeline walk-through could you provide the relevant R specs, e.g version, environment files specifying packages?

@RuthBowyer, I am wondering should we host the shapefiles on the GitHub repo to make this more accessible? they don't seem very big.

For the analysis walk-through I will provide shell commands to execute full pipeline end to end for one. I think it would suffice to illustrate this with one metric, one city, one run, rather than including the loops.
Would you agree or should the walk-through include the loops?

For the analysis walk-through I will provide shell commands to execute full pipeline end to end for one. I think it would suffice to illustrate this with one metric, one city, one run, rather than including the loops. Would you agree or should the walk-through include the loops?

Totally agree, just one combination is enough. And the script with the loops will be available in the codebase too.

@RuthBowyer, I am wondering should we host the shapefiles on the GitHub repo to make this more accessible? they don't seem very big.
Else, I will need the source for this shapefile: NUTS_Level_1_January_2018_FCB_in_the_United_Kingdom_2022_7279368953270783580 -- this shapefile used for defining regions and cutting, also London -- this one also used for chopping up LCAT data

I would support including them in the repo if there are no licensing issues.

Yep sounds good - all downloaded from OA sources but might need to double check the licenses on the sites

I've added ticket #42 for configuring how the documentation is rendered and maintained.

Hey all. I've added some screenshots from using quarto in #42. Great to get a sense if people like that option (and sorry I think I commented on #56 thinking it was this one, my bad).

Yep sounds good - all downloaded from OA sources but might need to double check the licenses on the sites

I will create a new issue for this @RuthBowyer

I think I have now written all the sections that I wanted to complete, so I will open PR for review. Please feel free to comment / fix / close while I am on A/L this week.
Some open questions / comments from my side:

R version specs need to be added to requirements
(line 123 in guidance) currently R script logic at this point quite different from python scripts, as all paths and variables are hardcoded in script. Either I adjust this in the guidance by instructing to either change paths in R script or paste R code with dummy paths directly into guidance or we adjust the Cropping R script.

for simplicity in guidance I chose to remove some flags that had defaults and were not crucial conceptually for the analysis (eg multiprocessing option), but feel free to add those back in if you think they are needed

As discussed today: @RuthBowyer when you are back could you please have a look at this and add the documentation parts relevant to the R pipeline e.g. R packages list.

@aranas to talk to @griff-rees to decide on easiest approach for merging the quarto and guidance branches (quarto branch already has merged main branch, which was challenging)

@gmingas the merge was managed in https://github.com/alan-turing-institute/clim-recal/pull/72


exist_user_prayers.py:23: Перенести классы в отдельные...

The puzzle 899-85af8aa4 from #899 has to be resolved:
https://github.com/blablatdinov/quranbot-aiogram/blob/09501ab93db1439392aad3a717cfe1776e9d97ec/src/srv/prayers/exist_user_prayers.py#L23-L23
The puzzle was created by Ilaletdinov Almaz on 09-Jun-24.
role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

All classes moved #899


Refactor SpotData CLI to change usage of forecast times

Issue: #217
Testing:

[x] Ran tests and they passed OK
[x] Added new tests for the new feature(s)

@carolinejjones , I think I've corrected the problems with the CLI tests now, and I've moved the test data centrally, so that you can run the CLI tests without pointing to my local copy of the CLI test data. The spot-extract CLI tests now run successfully for me, as I've removed the trailing slash as you've recommended, and I've corrected the names of the files that are being removed at the end of the CLI, as previously these names were incorrect and causing the CLI tests to fail. The only changes that I've made to the test data is to rename orography.nc to highres_orog.nc, and to update nearest_diagnostics.json and model_level_diagnostics.json.

All the tests now run through correctly.


Make specifiable command-line-args to user-defined command builder and runner

WHY
WHAT
REF

Codecov Report

Merging #26 into master will increase coverage by 2.39%.
The diff coverage is 92.3%.

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   20.05%   22.45%   +2.39%
==========================================
  Files          34       34
  Lines        1007     1020      +13
==========================================
+ Hits          202      229      +27
+ Misses        790      775      -15
- Partials       15       16       +1

Impacted Files
Coverage Δ

pkg/grapicmd/cmd/build.go
0% <0%> (ø)
:arrow_up:

pkg/grapicmd/cmd/user_defined.go
85.18% <100%> (+85.18%)
:arrow_up:

pkg/grapicmd/internal/module/script/script.go
80.95% <100%> (+12.53%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 265d140...c91e505. Read the comment docs.


Sign up - App freezes after logging in with a new Expensifail account

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.44-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Action Performed:

Go to staging.new.expensify.com
Log in with a new Expensifail account.

Expected Result:
App will not freeze after logging in with a new Expensifail account.
Actual Result:
App freezes after logging in with a new Expensifail account.
Workaround:
Unknown
Platforms:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/ddec9eb6-9ec5-4745-bffe-fd0d93c21cd0

View all open jobs on GitHub

Able to reproduce, trying to see where this came from. Pretty sure this is going to be backend but looking

@luacmartins @hannojg Do you think this could be fixed by https://github.com/Expensify/App/pull/50143?

Do you think this could be fixed by https://github.com/Expensify/App/pull/50143?

Hm, this is only occurring for expensifail accounts, not other accounts. So I don't think it's the search router?

Sometimes logging in just freezes, and other times, logging in returns to the login screen after briefly flashing the inbox screen. In the second case, the OpenApp response is session expired:

@srikarparsi Do you think it has to do with the expensifail domain room being so large?

I'm honestly not sure yet. I just tried reproducing it on dev with the expensifail domain and it's not reproducible (so maybe it is that?):

But I'm going to look at code changes that occurred recently in Web E and Auth and see if there's anything that stands out. I also think we can remove the DeployBlockerCash label (because it's not reproducible on dev and there's no mentions of expensifail other than test accounts in App). What do you think?

Do you think it has to do with the expensifail domain room being so large?

I just tested on production and there's weird behavior on there as well. It doesn't freeze like it does on staging but anything past the LHN screen size doesn't load and I also see the #social chat which I regularly don't see in expensifail

When you were reproducing here were you just signing in with your existing expensifail account or creating a new one?

This comment was fixed by logging out and logging back in. So since it occurs in staging and not prod, I don't think it's something to do with the domain being too big but rather a code regression I believe

Hmm not able to reproduce with my expensifail account on staging.

Removing all deploy blocker labels via what I said above.

I've tried signing out and signing back in 3 times already and haven't been able to reproduce it. Could it be account specific?

Very interesting, I'm not able to reproduce this either anymore (Tried twice)

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

Removing all deploy blocker labels via what I said above.

Sounds good, thank you for the help!

Maybe it was the search router? The PR I mentioned above hit Web 17 minutes ago

Yeah could be, I'm still not able to reproduce it.

Closing this as it can't be reproduced.


Remove link to deleted tweet

name: :memo: Documentation Fix
about: Fixing a problem in an existing docs page
Checklist

[ ] Is there an existing issue for this PR?
[ ] Have the files been linted and formatted?

What docs page needs to be fixed?

Section: When should I learn Redux?
Page: Redux FAQ: General

What is the problem?

Link points to a deleted tweet

What changes does this PR make to fix the problem?

Removes the link

Thanks!


Work around solution for getting actual temporary key values from the entity's tracking information failed for non-foreign key column.

As in our application, we have a situation where we used to insert data-parallel in two table and finally save changes of the context at the end and faced problem due to this breaking changes in EF Core 3.0 as mention here (https://docs.microsoft.com/en-us/ef/core/what-is-new/ef-core-3.0/breaking-changes#temporary-key-values-are-no-longer-set-onto-entity-instances). However we resolve this problem by applying for the suggested workaround solution to get the temporary key values from the below query, which returns the "Id", primary column temporary value for "books" table
var  tempIdValue = context.Entry(books).Property(e => e.Id).CurrentValue
This solution works fine when two tables have foreign key references relation whereas it failed and inserted the actual temporary value (i.e. long negative numbers) in the column if they don’t have foreign key references.
For Example,
Let us consider Books and Students are two master tables for library-related applications and when track books borrowed from the library by a student in the "StudentBookMapper" table.
Database Schema:

Table Name - Students

Columns:
Id
Name
Place
Country
Note: Id is the Primary Key

Table Name - Books

Columns:
Id
Name
Category
Author

Table Name - StudentBookMapper

Columns:
Id
UserId
BookId
IsActive
Here "BookId" column is a foreign key reference of the "Books" table with the "Id" column similarly "UserId" column is a foreign key reference of the "Students" table with "Id". When we try to insert a new entry in "Students" and along the "StudentBookMapper" table using the above temporary value query everything works fine. But now we got a situation where we need to keep the PG Student book borrowed details in the same table and hence removed the foreign key reference.
Henceforth, the column "UserId" corresponds to both the "Students" table and "PGStudents" table with a differentiate column "IsPGStudent" in "StudentBookMapper".
Modified Table Scheme for Table - StudentBookMapper
Columns:
Id
UserId
BookId
IsPGStudent
IsActive
In this scenario when we try the above temporary value query to insert the details in "Students" and "StudentBookMapper" table (i.e. "UserId" column is not foreign key referenced with "Students" table) we get a result where the actual temporary value (i.e. long negative value) inserted whereas the expected value to be inserted is "Primary column" value of "Students" table.
Note: We do save changes of the context once the data added to both the tables not once added to.
Kindly let me know is this an issue or anything wrong in our approach.
Further technical details
EF Core version: 3.1
Database provider: Microsoft.EntityFrameworkCore.SqlServer
Target framework: .NET Core 3.1
IDE: Visual Studio 2019 16.4.1

@Nivitha-Gopalakrishnan While I appreciate the detailed description it is still hard to follow exactly what is going on. It would be much more useful to get a small, runnable project or code listing that demonstrates the behavior you are seeing so that we can investigate.

EF Team Triage: Closing this issue as the requested additional details have not been provided and we have been unable to reproduce it.
BTW this is a canned response and may have info or details that do not directly apply to this particular issue. While we'd like to spend the time to uniquely address every incoming issue, we get a lot traffic on the EF projects and that is not practical. To ensure we maximize the time we have to work on fixing bugs, implementing new features, etc. we use canned responses for common triage decisions.


Using specific data attributes for Sketch

This is an amazing tool. Haven't run it yet, but I have been wanting to build this myself. What would be amazing is to have control over some Sketch specific properties by passing those props through data attributes.
As an example imagine the following component:
<div data-sketch-ignore>
  <div data-sketch-symbol="SearchInput">
    <input class="SearchInput" data-sketch-resize="stretch" data-sketch-layer-name="name" />
  </div>
</div>

I can think of some props like:

data-sketch-layer-style
data-sketch-link-object

Haven't thought it through all the way, but I could see it be helpful to have some control of the Sketch output.

Some stuff in here that might be nice to be able to control:
 return {
      '_class': this._class,
      'do_objectID': this._objectID,
      'exportOptions': {
        '_class': 'exportOptions',
        'exportFormats': [],
        'includedLayerIds': [],
        'layerOptions': 0,
        'shouldTrim': false
      },
      'isFlippedHorizontal': false,
      'isFlippedVertical': false,
      'isLocked': false,
      'isVisible': true,
      'layerListExpandedType': 0,
      'name': this._name || this._class,
      'nameIsFixed': false,
      'resizingConstraint': this._resizingConstant,
      'resizingType': 0,
      'rotation': 0,
      'shouldBreakMaskChain': false,
      style: this._style ? this._style.toJSON() : undefined,
      layers: this._layers.map(layer => layer.toJSON())
    };

I realized there is ways to customize the output: https://github.com/brainly/html-sketchapp-style-guide/blob/master/src/styleguide2asketch.js

Yeah, exactly - this project aims to be a generic library that allows to do custom stuff like html-sketchapp-style-guide. While I agree that things like data-sketch-layer-style would be useful, I think it's not a good fit for html-sketchapp.


Failed to install cpprestsdk arm64-windows

Hi,
I am getting an issue when trying to install cpprestsdk:arm64-windows (it fails to build boost). Here is the output:

I've also done the updating so I am not sure where this issue is coming from.

Nevermind, it turns out that boost context does not support arm64-windows.


[1.10] Bump Mesos to 1.4.x 5f6d4cd

High-level description
This is a routine bump to the latest Mesos and mesos-modules.
Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:

DCOS_OSS- Foo the Bar so it stops Bazzing.

Checklist for all PRs

[ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
[x] Read the DC/OS contributing guidelines
[x] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[x] Change log from the last version integrated (this should be a link to commits for easy verification and review<EMAIL_ADDRESS>[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

@mesosphere-mergebot bump-ee

@mesosphere-mergebot label ready for review

@mesosphere-mergebot check status


Fixes #10388

The cmd.Lookup should be "-attach" and not "attach", as seen in
docker/docker/runconfig/parse.go
Signed-off-by: André Martins<EMAIL_ADDRESS>

@aanm fix looks like the right one. Could you add a testcase for this?  I see several tests in integration-cli for "-a" but none for "--attach" - but it should be easy enough to just dup one.

Can you add
Fxed #10388
or
Closes #10388
to yor original comment so github will close the issue automatically?

Also commits look weird. Could you squash-rebase pls?

@duglin Done
@LK4D4 Sorry about that, let me know if everything is alright now

@aanm Could you give next time more descriptive commit message title?
LGTM

LGTM


Copy of (#19712) VstsAzureHelpers_: Write-Host output hashtable content and not object type

Task name: AzurePowerShellV4, AzurePowerShellV5
Description: clone of https://github.com/microsoft/azure-pipelines-tasks/pull/19712
Documentation changes required: (Y/N)
Added unit tests: (Y/N)
Attached related issue: (Y/N)
Checklist:

[ ] Task version was bumped - please check instruction how to do it
[ ] Checked that applied changes work as expected

/azp run

@v-mohithgc : So seems to have to bump dependent task for the change even with the previous PR: #19752 merged having already done it as it changed something in the same place. Good to know for later.
Seems to be the day of strange pipeline errors, that was not there in the last runs we had that passed through.

@v-mohithgc : So seems to have to bump dependent task for the change even with the previous PR: #19752 merged having already done it as it changed something in the same place. Good to know for later.
Seems to be the day of strange pipeline errors, that was not there in the last runs we had that passed through.

yes, pipeline errors are due to the recent changes in node version I guess, I have raised this issue to concerned folks, hoping to be fixed soon.


add command to force a syntastic check

This allows a particular file type to be disabled but still be checked when desired.
I disable the puppet file type because it takes too long to syntax check.  It makes vim hang.  However, I do want to be able to force a check.

Hey, I have pulled your commit. But then i went insane and wrote this --> https://github.com/scrooloose/syntastic/commit/78fbd7fa13f5565cbdf584fd42ea2cfc33befb35.
The commit log explains it pretty well. This level of control should be highly superior - and possibly even less lines of code than the current system.


Add TFLite benchmarks for formerly TF models

These benchmarks align very well with the existing TF source benchmarks
but don't involve going through our less-well-supported TF source
integration or storing unstable MLIR artifacts.
I did a comparison of benchmarks before and after on my Pixel 4 dev
phone, manually rewriting the model source in the former so that a
direct comparison was possible with existing tooling. No benchmarks
have significant changes:
https://gist.github.com/GMNGeoffrey/bce029bf4697f9b3deda3bb217b0c6b3

Seems the benchmarking isn't very fault-tolerant:
[2021-11-12T18:13:19Z] I ../iree/tools/utils/vm_util.cc:185] Creating driver and device for 'vulkan'...
--
  | [2021-11-12T18:13:24Z] ../iree/hal/vulkan/serializing_command_queue.cc:271: INTERNAL; VK_ERROR_DEVICE_LOST; vkQueueSubmit; while invoking native function hal.ex.submit_and_wait; while calling import;

That's a transient error, I'm pretty sure. Probably we should add retry logic and also make output incremental, so we still get results even if one benchmark fails. I'm going to retry the step on buildkite for now

Seems the benchmarking isn't very fault-tolerant:
[2021-11-12T18:13:19Z] I ../iree/tools/utils/vm_util.cc:185] Creating driver and device for 'vulkan'...
--
  | [2021-11-12T18:13:24Z] ../iree/hal/vulkan/serializing_command_queue.cc:271: INTERNAL; VK_ERROR_DEVICE_LOST; vkQueueSubmit; while invoking native function hal.ex.submit_and_wait; while calling import;

That's a transient error, I'm pretty sure. Probably we should add retry logic and also make output incremental, so we still get results even if one benchmark fails. I'm going to retry the step on buildkite for now

The error was not transient. It has to do with the kernel-execution method of making giant dispatches that was going over the timeout for a single dispatch. Fixed and added a comment about this pitfall.

This is marked as draft and still have failures but I see you requested review. Is it ready for review now or not? :)

This is marked as draft and still have failures but I see you requested review. Is it ready for review now or not? :)

Argh. My intent was that it was ready, but looks like we've still got a failing benchmark :-( I thought there was something funky with my local device, since I'm pretty sure these had worked previously
[2021-11-17T02:56:29Z] cmd: adb shell cd /data/local/tmp/iree-benchmarks/TFLite/MobileBertSquad-fp32/iree-vulkan__GPU-Adreno__kernel-execution,experimental-flags && taskset 80 /data/local/tmp/iree-benchmarks/normal-tools/iree-benchmark-module --flagfile=flagfile --benchmark_repetitions=10 --benchmark_format=json
--
  | [2021-11-17T02:56:29Z] I ../iree/tools/utils/vm_util.cc:185] Creating driver and device for 'vulkan'...
  | [2021-11-17T02:56:44Z] ../iree/hal/vulkan/serializing_command_queue.cc:271: INTERNAL; VK_ERROR_DEVICE_LOST; vkQueueSubmit; while invoking native function hal.ex.submit_and_wait; while calling import;
  | [2021-11-17T02:56:44Z] [ 1]   native hal.ex.submit_and_wait:0 -
  | [2021-11-17T02:56:44Z] [ 0] bytecode module.main:320498 /usr/src/github/iree/build-host/benchmark_suites/TFLite/mobilebertsquad.tflite.mlir:2:3
  | [2021-11-17T02:56:44Z] Aborted
  | [2021-11-17T02:56:45Z] Traceback (most recent call last):
  | [2021-11-17T02:56:45Z]   File "build_tools/benchmarks/run_benchmarks_on_android.py", line 553, in <module>
  | [2021-11-17T02:56:45Z]     main(parse_arguments())
  | [2021-11-17T02:56:45Z]   File "build_tools/benchmarks/run_benchmarks_on_android.py", line 519, in main
  | [2021-11-17T02:56:45Z]     results, captures = filter_and_run_benchmarks(
  | [2021-11-17T02:56:45Z]   File "build_tools/benchmarks/run_benchmarks_on_android.py", line 415, in filter_and_run_benchmarks
  | [2021-11-17T02:56:45Z]     run_results = run_benchmarks_for_category(
  | [2021-11-17T02:56:45Z]   File "build_tools/benchmarks/run_benchmarks_on_android.py", line 329, in run_benchmarks_for_category
  | [2021-11-17T02:56:45Z]     resultjson = adb_execute_in_dir(cmd, android_relative_dir, verbose=verbose)
  | [2021-11-17T02:56:45Z]   File "build_tools/benchmarks/run_benchmarks_on_android.py", line 143, in adb_execute_in_dir
  | [2021-11-17T02:56:45Z]     return execute_cmd_and_get_output(cmd, verbose=verbose)
  | [2021-11-17T02:56:45Z]   File "/var/lib/buildkite-agent/builds/IREE-LAB-RPI4-PIXEL4-ubuntu-1/iree/iree-benchmark/build_tools/benchmarks/common/benchmark_definition.py", line 44, in execute_cmd_and_get_output
  | [2021-11-17T02:56:45Z]     return subprocess.run(args,
  | [2021-11-17T02:56:45Z]   File "/usr/lib/python3.8/subprocess.py", line 516, in run
  | [2021-11-17T02:56:45Z]     raise CalledProcessError(retcode, process.args,
  | [2021-11-17T02:56:45Z] subprocess.CalledProcessError: Command '['adb', 'shell', 'cd', '/data/local/tmp/iree-benchmarks/TFLite/MobileBertSquad-fp32/iree-vulkan__GPU-Adreno__kernel-execution,experimental-flags', '&&', 'taskset', '80', '/data/local/tmp/iree-benchmarks/normal-tools/iree-benchmark-module', '--flagfile=flagfile', '--benchmark_repetitions=10', '--benchmark_format=json']' returned non-zero exit status 134.

That's a GPU timeout again, right? For some reason I thought I'd already fixed it. I'll get everything working and then mark ready for review. Sorry for the noise

Ok had to remove the mobile bert kernel benchmark and now we're good to go

Also, with this we need to update docs here and here. But again, can happen later. :)

out of curiosity, is there an easy way to get the MLIR artifacts from these without needing to build tf? I'm really excited to not have the unstable MLIR artifacts as a source, but not excited to need to build iree-import-tflite and construct command lines to repro benchmarks locally (or do random colab hacking or python release shenanigans). Is there a script that could fetch them from somewhere or at least automate the build + convert step for local use?

for reference, yesterday I clicked the tgz link in the CMakeLists.txt and had a .mlir I could immediately pass to the compiler to repro - not expecting something that easy but something closer to that then "hope you have something in your bash history from the last time you did this a month ago and spend an hour building tf" :P

The iree-benchmark-suites target is meant for both the CI and local use. It should download all necessary stuff from the cloud and generate all artifacts. I think we can relax the following a bit:
https://github.com/google/iree/blob/66b8d7aaae8dc7fdb6e648a3116e7d237aeda872/build_tools/cmake/iree_benchmark_suite.cmake#L136-L139
To let it also look at where iree-improt-tfilte is typically installed via pip so that you can install it via pip?

that'd be useful! it still requires pip stuff and an up-to-date release, but I feel like the tflite layer changes relatively infrequently so it'd probably be fine if that's all it needs from the package and can use the rest (iree-translate/etc) from the local build

@benvanik you can use the IREE tools from snapshot releases to generate them from the TFLite flatbuffers

The iree-benchmark-suites target is meant for both the CI and local use. It should download all necessary stuff from the cloud and generate all artifacts. I think we can relax the following a bit:
https://github.com/google/iree/blob/66b8d7aaae8dc7fdb6e648a3116e7d237aeda872/build_tools/cmake/iree_benchmark_suite.cmake#L136-L139
To let it also look at where iree-improt-tfilte is typically installed via pip so that you can install it via pip?

You'd still want to set IREE_BUILD_TFLITE_COMPILER here, just point it to the place where the pip install is (this is true of all the stuff with the TF binaries.
The benchmark runs also upload artifacts. They currently exclude .mlir files (https://github.com/google/iree/blob/c3505092c2ec709c86e9cfe73fc68b06d730c70e/build_tools/buildkite/cmake/android/arm64-v8a/benchmark2.yml#L13), but we could have them included (in fact, we should probably be excluding .tflite files there!). Then the most up to date could be downloaded from the latest benchmark run

You'd still want to set IREE_BUILD_TFLITE_COMPILER here, just point it to the place where the pip install is

not familiar with this stuff, but isn't that a boolean flag? how do I point it at things? (I'd assume if I said IREE_BUILD_TFLITE_COMPILER=ON it would build the tflite compiler, which is what I want to avoid?)
I think it's mostly about the process - needing to do a bunch of commands that may fail to then type out a bunch of commands that may fail and run them in turn all sucks, but it sounds like if we can make the target work it'll be pretty nice. It'll also be useful for people who want to run the benchmarks locally on their own hardware!

The benchmark runs also upload artifacts. They currently exclude .mlir files (
https://github.com/google/iree/blob/c3505092c2ec709c86e9cfe73fc68b06d730c70e/build_tools/buildkite/cmake/android/arm64-v8a/benchmark2.yml#L13
), but we could have them included (in fact, we should probably be excluding .tflite files there!). Then the most up to date could be downloaded from the latest benchmark run

Good catch! That should be fixed. Yeah. That works too. But I always have the tarball size concern, esp. this is uploading stuff each commit.. Do you know how much they total? I'd assume ~100MB?

I think it's mostly about the process - needing to do a bunch of commands that may fail to then type out a bunch of commands that may fail and run them in turn all sucks, but it sounds like if we can make the target work it'll be pretty nice. It'll also be useful for people who want to run the benchmarks locally on their own hardware!

Yup. That's the original intent behind  the iree-benchmark-suites target. I basically use it locally for development.

You'd still want to set IREE_BUILD_TFLITE_COMPILER here, just point it to the place where the pip install is

not familiar with this stuff, but isn't that a boolean flag? how do I point it at things? (I'd assume if I said IREE_BUILD_TFLITE_COMPILER=ON it would build the tflite compiler, which is what I want to avoid?)

Yeah that one's a boolean flag. There's also IREE_TF_TOOLS_ROOT which tells CMake where to look for the already-built binaries (https://github.com/google/iree/blob/c3505092c2ec709c86e9cfe73fc68b06d730c70e/integrations/tensorflow/iree_tf_compiler/CMakeLists.txt#L7). Yeah that option name is a bit confusing... Probably should be "enable" instead. I think the name may be a holdover from when Stella put Bazel inside of CMake, so this actually controlled doing a Bazel invocation :fearful: Now it hooks in the binary (https://github.com/google/iree/blob/c3505092c2ec709c86e9cfe73fc68b06d730c70e/integrations/tensorflow/iree_tf_compiler/CMakeLists.txt#L30) and switches on TF stuff, including building the Python bindings (https://github.com/google/iree/blob/c3505092c2ec709c86e9cfe73fc68b06d730c70e/CMakeLists.txt#L61-L74). Probably we should decouple the python bindings from that. Not really sure why those need to be coupled.

Good catch! That should be fixed. Yeah. That works too. But I always have the tarball size concern, esp. this is uploading stuff each commit.. Do you know how much they total? I'd assume ~100MB?

Looking at my local artifacts, they're 286MB uncompressed, 155MB in a tar.gz. At some point we could get fancy and upload in such a way that we only reupload if they've changed. Right now I think the option is on or off though :-)

Could you please update the documentation at https://github.com/google/iree/blob/main/benchmarks/README.md and https://github.com/google/iree/blob/main/benchmarks/dashboard.md following this change? The TensorFlow/ folder no longer exists, and .tflite files are used as input instead of .mlir files.
(I'd also like to see the discussion from last night about big core vs little cores and other benchmarking methodology written down, perhaps in https://github.com/google/iree/blob/main/benchmarks/dashboard.md#benchmarking-philosophy, but that's a separate topic)


cabal.project refers to things on local filesystem

is this necessary?
[chessai@chessai-kudu:~/development/kafka-client]$ cat cabal.project
packages: . ../sockets ../castagnoli

source-repository-package
  type: git
  location: https://github.com/haskell-primitive/primitive-slice
  tag: 554f1f0cf00d0c445b4210ce8367be5269e6ce64

source-repository-package
  type: git
  location: https://github.com/andrewthad/posix-api
  tag: 6344f841b969cb70195e49093be1504b4a84f7c5

I think those local filesystem dependencies can be pulled from github instead. I'll fix that.

Fixed by ca516ec.


clk_and_reset

Here we are the modules examples of the clk_and_reset code

[ ] #79

Example of the Module - clk and reset
1.Here we developed code the(UUT File) by using a module.
module rtl();

endmodule

2.and then the design logic by using the module and Verilog extension code.(like my_modul.v)
and even we have another file which is the also Verilog extension here they developed the logic by using the MODULE PORT MAPPING BY NAME  like my_module_name dut ( .a(a), .b(b),  .ab(ab));) and file name called rtl_unit_test.sv

3.Using the runSVUnit -s questa command for running the file.

4.see the below output for better understanding.

2.and then the design logic by using the module and Verilog extension code.(like my_modul.v)
and even we have another file which is the also Verilog extension here they developed the logic by using the MODULE PORT MAPPING BY NAME  like my_module_name dut ( .a(a), .b(b),  .ab(ab));) and file name called rtl_unit_test.sv

3.Using the runSVUnit -s questa command for running the file.

4.see the below output for better understanding.

2.For generating the unit_test_template_file we are using below command
create_unit_test.pl rtl.v

see the below output for better understanding.

The same code now we're executing the EDA Playground


After updating a pre-release extension to a newer pre-release, extension is no longer running as pre-release

Issue Type: Bug

Publish an extension.

Publish a pre-release with a higher minor version.

Switch to using the pre-release.

Build a new pre-release with a higher maintenance version.

Publish it.

In VS Code check for updates. See that a newer pre-release is offered.

Install it, then click the Reload button.

:bug: after reload you are no longer running the pre-release. You have to opt in to pre-release again.

VS Code version: Code - Insiders 1.64.0-insider (f67a8b753f55e452f38b61497662839c4691fb12, 2021-12-16T05:15:05.411Z)
OS version: Windows_NT x64 10.0.19044
Restricted Mode: No

This seems to happen when auto updates are disabled.

Not sure why author verification bot didn't run here, but @gjsjohnmurray can you verify this?

Verified by disabling updates, downgrading to an older prerelease, then upgrading and ensuring it remained as prerelease.


Added support for configuration by environment variable

This is a functional first pass, with a readme rewrite

@lacaulac could you enable issues on this repo please?

@ChipWolf Done! Sorry for the delay. Nice work, I really like how you've changed the README file too!

And docs are linked: https://github.com/itzg/docker-rcon-web-admin#environment-variables


Query simplifications, edits in table explanations, some code refactoring

Also fix query

Thanks @tdincer.  Please also update version and changelog.  After this pull request is merged, please push a tag to upstream so that it can be released and published.

Hi @CBroz1, would you please review and merge this pull request.  @tdincer can explain the context.  Thanks!

@kabilar I appended the query cleanings to this PR.

Why was this closed?

@tdincer If these changes will not be used by the Lu Lab, then we can close and reopen when we have a user requesting the use of FISSA or other post processing.  Thank you.

@kabilar  I'll try to finalize this PR today.

Dear all - please review the changes as soon as possible. There are some critical bug fixes in this PR.

Thanks @tdincer.  It is not clear how FISSA is implemented with these changes.  From what I understand from our conversations, the FISSA component is in the workflow for the Lu Lab.  Perhaps we could implement one of the following suggestions to resolve this issue:

Add the FISSA implementation within the element make function.
Document how one would use these changes to implement FISSA.
Rename the imaging_fissa.py module to a more generic name.

Minor suggestion, but the imaging modules do not all have the same changes.

Thanks for clarifying in person.  That was my mistake.  Everything looks good.

Everything looks good to me as well, suggesting we merge @kabilar


Update gost-engine commit to match EVP_MAC renaming

[extended tests]
Depends on #12121

@paulidale, should this PR be labeled as urgent?

I'd suggest changing "gost-engine commit" to "gost-engine submodule" in the commit message.  That is, after all, what you're doing...

The OpenSSL side is urgent since it is build breaking in two ways.  I suspect that this should also be urgent since it addresses one of the breaks.
Unfortunately, I can't set labels on this repo.

I mean this PR. Your PR to gost-engine is already merged, so I want to update the commit for openssl extended tests

Need to re-run tests when #12121 is merged.

@paulidale , Travis is happy

Ping @paulidale

Oops, this slipped past.

Merged to master.


Connection reset by peer - SSL_connect on Jenkins

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I have read the Contribution Guidelines

Issue Description
I am having similar issue to https://github.com/fastlane/fastlane/issues/6553. I tried all the solutions from the thread but nothing works. I get Connection reset by peer - SSL_connect on Jenkins when running fastlane with match. If I remove match from my lane then it works.

Solved the issue. I tried installing ruby several times. The issue was related to something on my git server. Apparently there was some ssl issue with the git url.
https://github.com/fastlane/fastlane/issues/6553#issuecomment-266495167


Improvements on creation of geometry and meshing by GMSH

This pull request will improve the geometry and mesh generation through gmsh. The code has been rewritten to use OCC kernel instead, and this allows to perform boolean operations for the better creation of surfaces in the air gap. The sliding band is being drawn in such a way that is compatible with the magnetics solvers in Elmer fem.
Additionally, this pull request will allow to create and mesh almost all the example geometries available in the database:
pyleecan/Data/Machine .
There will be future improvements to support outer rotor topologies. Currently, the outer rotor geometries can be drawn without sliding band.
I am also trying to identify and fix some of the boundary condition settings that seems to be inconsistent with how those are currently treated in pyleecan.
GUI has a button to create gmsh file and default to sym=1, it would be good that defaults to is_sliding_band=False and is_airbox=False too.

Thank you for your contribution, this looks very interesting :) Starting from next week I should have more time for pyleecan (we are about to release the next version of our commercial software). I will try to review your PR (and the other pending one) by then. @SebGue Do you think you can take a look as well ?
Best regards,
Pierre

Hello,
I'm currently reviewing this PR and I find few things to correct but otherwise its a great step forward thank you :)
I miss clicked and merge the PR a bit too fast. I will open another PR with my modifications to carry on the discussions if needed.
Best regards,
Pierre


Git's autocrlf-true interacts badly with cargo rewriting the lockfile

If git has core.autocrlf=true (a reasonable thing on Windows) it checks out Cargo.lock with CRLF line endings. The next time cargo touches the file, it changes the line endings to LF making git think that it has changed.
Some possible solutions/remedies:

preserve the line endings in Cargo.lock (perhaps not exactly preserve but detect the kind from the first line);
in cargo new --bin create .gitattributes with the line Cargo.lock eol=lf;
document this issue somewhere.

I'm still a little baffled about why this is coming up sometimes and not others, perhaps you can help me clear this up? The git documentation seems to indicate that you should set autocrlf to true on Windows if you're also working with non-Windows developers, but I've never done this on the Rust repo and I've never had problems. I also haven't ever had problems working with any of my other repos without having autocrlf to true, so why is it necessary sometimes?
I'd prefer to avoid .gitattributes as it probably just indicates that there's something else wrong somewhere, and otherwise I'll also cc #1722

Given that the problem is predicated on core.autocrlf=true being set are you wondering why someone would do that? Because editors and other utilities are all different I guess.
A smart editor (like vim) will just work and probably preserve the line endings style so you won't notice any discrepancies.
An archaic editor (nvi) will show ^M symbols when given a CRLF file and will insert LF when you press enter, introducing inconsistencies.

The advice to set autocrlf=true is aimed to make all of them happily ignore the other convention.

I have a quick and dirty patch for preserving CRLF line endings but it keeps failing my own test :disappointed:

Ok, I think I'm convinced that we should move forward with this, feel free to submit a PR @gkoz!

This is a thing I run into myself sometimes. Definitely having Cargo try to preserve the line ending type would be convenient.

I'm going to submit a PR shortly but I'd appreciate someone taking a look a the patch above to help me figure out why the test fails.

It could be because I don't have a slightest idea what p.cargo() and p.cargo_process() actually do... :confused:

Oh huh I thought I commented on that awhile back, sorry about that! In short, the first command should use cargo_process as that function will delete the project tree and recreate it, and then future calls to cargo should use p.cargo() as they'll just use the existing tree.
Feel free to open a PR, however, and I can try to help debug through travis as well


Test integration IOS

Thanks for share this project!
Do you know how to integrate RN with native swift?

This is the doc for Integration RN with existing apps, it contains the swift related method.


Automate packaging for new releases

Seeing as this project utilizes Poetry, the ability to automate building wheels and tarballs for each new release with Github Actions is possible. There are several ways to implement this, but would like to hear thoughts before attempting to do so.

Closing, as the project has moved away from Poetry in order to support other workflows


New version: SequenceTokenizers v0.0.3

Registering package: SequenceTokenizers
Repository: https://github.com/mashu/SequenceTokenizers.jl
Created by: @mashu
Version: v0.0.3
Commit: f76ec36ed26e895186fc610ee3bfd175077289d3
Reviewed by: @mashu
Reference: https://github.com/mashu/SequenceTokenizers.jl/commit/f76ec36ed26e895186fc610ee3bfd175077289d3#commitcomment-145323207
Description: Character level tokenizers for sequence data
Release notes:

- onehot_batch returns Float32 type by default
- onecold_batch uses more relaxed AbstractArray now

stop