Support for Stylus CSS in Grav

Is there a way to install Stylus in Grav? I found this library that render Stylus in PHP. I wonder if someone can point me to a way to implement it correctly within Grav. I read the docs, but the plug in tutorial is too complex for my current knowledge of Grav, I'm also checking out this plugin and would appreciate any guidance on the process.
I need to use Stylus in order to move a project made in roots.cx to Grav
Many thanks

Really all this plugin does is load the PHP library to make it available for other plugins. Also it provides a simple CLI command to manually compile.
However, you don't need a plugin to use SCSS, or Stylus for that matter.  Just install stylus according to the docs: http://stylus-lang.com/#get-styling-with-stylus
And then configure it so your compiled CSS goes into css-compiled/ folder or something, and then have your theme point to that.  Sure you will have to compile offline, but this is pretty normal.  Antimatter has SCSS source files, but ships with compiled CSS files, and uses those from the theme.

That is a good point: I was thinking on a way to make it easier to develop the theme within Grav.


First draft of the migration guide

What
First draft at a structure for the migration guide. Assume there will be more incremental cleanups.
Checklist

[x] I have read and agree to Contributor Guide and the Code of Conduct
[x] I've included a screenshot or gif (if applicable)
[x] I have tested demo.rerun.io (if applicable)

PR Build Summary
Docs preview
Examples preview
Recent benchmark results
Wasm size tracking

Nice!


Font: Fix to have correct fonts

Note: Please transform - [ ] into - (NA) in the description when things are not applicable
Related issues
Fixes #1950.
Description
Change breakpoints of application to better fit design rules.
Change font sizes depending on the breakpoint to better suit design.
Update the doc to better convey information.
In "Applying the type styles" DSM section, we can see that the values for <h3>, <h5> and <h6> are not the same as the one proposed in Boosted atm.
Currently, we have:
`<h3>`: Desktop(24px) / Tablet(18px) / Mobile(16px)
`<h5>`: Desktop(18px) / Tablet(16px) / Mobile(16px)
`<h6>`: Desktop(16px) / Tablet(16px) / Mobile(16px)

But based on the DSM, they should be:
`<h3>`: Desktop(24px) = Subtitle 2 / Tablet(24px) = Subtitle 1 / Mobile(18px) = Subtitle
`<h5>`: Desktop(18px) = Body 3 / Tablet(18px) = Body 2 / Mobile(16px) = Body 2
`<h6>`: Desktop(18px) = Body 4 / Tablet(18px) = Body 2 / Mobile(16px) = Body 2

⚠ <h2> and <h3> will have the same size on tablet and mobile. <h5> and <h6> will have the exact same size everytime.
Dear a11y experts and designers, please check that the titles of the live preview below are fine (please resize your screen to fully check the styles). Make sure to also check the breakpoints that have been changed too.
Motivation & Context
Wrong display atm.
Types of change

Bug fix (non-breaking which fixes an issue)

Live previews

https://deploy-preview-2053--boosted.netlify.app/docs/content/typography

Checklist
Contribution

[x] I have read the contributing guidelines

Accessibility

[x] My change follows accessibility good practices; I have at least run axe

Design

[x] My change respects the design guidelines defined in Orange Design System
[x] My change is compatible with responsive display

Development

[x] My change follows the developer guide
(NA) I have added JavaScript unit tests to cover my changes
(NA) I have added SCSS unit tests to cover my changes

Documentation

[x] My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

[x] My change introduces changes to the migration guide
(NA) My new component is added in Storybook
(NA) My new component is compatible with RTL
[ ] Manually run BrowserStack tests
[ ] Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
[ ] Code review
[ ] Design review
[ ] A11y review

After the merge

[ ] Manually launch Percy tests

a11y checked, OK

Good catchs!
Corrections are done via last commit.
For instance, impacts I could get on the doc:

Stickers that are using class="h3"
List-group headings that are out of DSM
Carousel slide labels that are out of DSM

The remaining seems to be already overrided or directly linked to the documentation (footer, cards, offcanvas, modals, .
This PR could lead to resolve some of the issues we had such as #786, .modal-title, offcanvas-title and maybe more?

For stickers, we must check with the designers.
For stuff not described in the DSM, default rendering for <h*>s should be OK.

This PR could lead to resolve some of the issues we had such as https://github.com/Orange-OpenSource/Orange-Boosted-Bootstrap/issues/786, .modal-title, offcanvas-title and maybe more?

If there are no regressions in the PR, let's not modify them yet because, with the new tokens, we will need to modify them again right after. With your modification, does it have an impact or does it stay with the same rendering?

There is no regression because we override the style in those classes, but I wanted to mention that we could think of ease our styles due to these changes. However, you're right and we should wait for tokens.

Reverted the change of breakpoints as it could be potentially breaking.

@MewenLeHo A lot of modifications happened since your first review regarding the stickers. Could you please take a look at what's been done to see if you agree with this new way of handling the stickers? No need to check in detail, I'll do it. Just talking about the principle to rely on classes not embedded in the framework.

@MewenLeHo A lot of modifications happened since your first review regarding the stickers. Could you please take a look at what's been done to see if you agree with this new way of handling the stickers? No need to check in detail, I'll do it. Just talking about the principle to rely on classes not embedded in the framework.

I am honestly not in favor of this solution.
Boosted's goal is to give users 'reusable prebuild components' so for me all component's related styles must be embbed in the framework.

Boosted's goal is to give users 'reusable prebuild components' so for me all component's related styles must be embbed in the framework.

The issue here is that it works "well" for these examples, but the sizes won't ever be the same depending on the use cases: content, internationalization, etc. So we can't predict the font size values and all the combinations.
Do you have another approach to suggest here?

Font sizes
Values for <h3>, <h5> and <h6>. These values will also need to be updated in the DSM.
`<h3>`: Desktop(24px) / Tablet(24px) / Mobile(18px)
`<h5>`: Desktop(18px) / Tablet(18px) / Mobile(16px)
`<h6>`: Desktop(16px) / Tablet(16px) / Mobile(16px)

The implementation of the Stickers all looks good. No issues.

@louismaximepiton https://github.com/Orange-OpenSource/Orange-Boosted-Bootstrap/pull/2053/commits/2fb489db93b864269eafd7e9f76f23c993519f60 is a proposal to use scss-docs to handle .sticker-fs-* classes in Sticker documentation. It'll avoid maintenance if those values evolve in the future since we'll have to update them only in the CSS used for the docs. Can be reverted if you think this is not OK.


chore: move hop-helper logic to selectors

Description
Move useHopHelper logic into selectors where appropriate.
Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[x] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)
Closes https://github.com/shapeshift/web/issues/4792
Risk
Small - all functionality contained behind a feature flag.
Testing
Engineering
Ensure flagged UI still displays as expected.
Operations
N/A
Screenshots (if applicable)

Current dependencies on/for this PR:

develop

PR #4782

PR #4793   👈

This comment was auto-generated by Graphite.


cmd/compile: internal compiler error: value v132 still has 1 uses when GOARCH=arm

What version of Go are you using (go version)?

$ go version
go version go1.17.2 linux/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="arm"
GOBIN="/home/.go/bin"
GOCACHE="/home/.cache/go-build"
GOENV="/home/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.17.2"
GCCGO="gccgo"
GOARM="5"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="0"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -marm -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build3247440742=/tmp/go-build -gno-record-gcc-switches"

What did you do?

$ export GOARCH=arm
$ go build main.go

main.go is the following:

package main

func main() {
}

type dummy struct {
	num int64
}

func foo(vs map[dummy]struct{}, d dummy) error {
	_, ok := vs[d]
	if !ok {
		return nil
	}

	switch d.num {
	case 0:
	case 1:
	case 2:
	case 3:
	case 4:
	case 5:
	case 6:
		var num float64
		if num != 0 {
			return nil
		}
	}

	return nil
}

What did you expect to see?
Program compiled successfully.
What did you see instead?

# command-line-arguments
./main.go:12:2: internal compiler error: 'foo': value v132 still has 1 uses

Please file a bug report including a short program that triggers the error.
https://golang.org/issue/new

Mh, I can't reproduce this:
$ go version
go version go1.17.2 windows/amd64

$ export GOARCH=arm
$ go build test.go
# no error

cc @randall77

I can reproduce this on darwin/arm64, both with 1.17 and tip:
$ GOARCH=arm go tool compile x.go
x.go:12:2: internal compiler error: 'foo': value v138 still has 1 uses

I can reproduce on linux/amd64:
$ go version
go version go1.17.2 linux/amd64

$ GOARCH=arm go build main.go
# command-line-arguments
./main.go:12:2: internal compiler error: 'foo': value v132 still has 1 uses

Has something to do with softfloat, also fails for
GOOS=linux GOARCH=mips GOMIPS=softfloat go build main.go

but not
GOOS=linux GOARCH=mips go build main.go

Here's a recent issue for which a deadcode pass after prove would help:
https://github.com/golang/go/issues/48882#issuecomment-939322932


Adds Laravel 11 support

This pull request adds support for Laravel 11.

Thanks @thecyrilcril - We've added Laravel 11 support in a separate PR, but thank you for contributing! Please let us know if you have any compatibility issues.


Update Maesh logo

Pre-submission checklist:
Please check each of these after submitting your pull request:

[x] Are you only including a repo_url if your project is 100% open source? If so, you need to pick the single best GitHub repository for your project, not a GitHub organization.
[x] Is your project closed source or, if it is open source, does your project have at least 300 GitHub stars?
[x] Have you picked the single best (existing) category for your project?
[x] Does it follow the other guidelines from the new entries section?
[x] Have you included a URL for your SVG or added it to hosted_logos and referenced it there?
[x] Does your logo clearly state the name of the project/product and follow the other logo guidelines?
[x] Does your project/product name match the text on the logo?
[x] Have you verified that the Crunchbase data for your organization is correct (including headquarters and LinkedIn)?
[x] ~5 minutes after opening the pull request, the CNCF-Bot will post the URL for your staging server. Have you confirmed that it looks good to you and then added a comment to the PR saying "LGTM"?

Deploy preview for landscape ready!
Built with commit e65fd6882c63665ee07988231345d3b7b48179c2
https://deploy-preview-1405--landscape.netlify.com

Hello!
Some information are incorrect about Containous in https://raw.githubusercontent.com/cncf/landscape/master/processed_landscape.yml. I understood that this file is generated and should not be edited. I fixed the info on Crunchbase. How/when is the file generated? Am I supposed to do something?
Thanks :)

It pulls the latest info from Crunchbase once a day (around 9 PM ET). Please write LGTM and I'll merge.
Congrats on your launch and, relatedly, this tweet cracked me up: https://twitter.com/spara/status/1169261481990512641

LGTM


Delay: Don't rely on EH traits

File in question: https://github.com/rust-embedded/cortex-m/blob/1a4e09646aa37c3408d69fe4452265f405400593/src/delay.rs#L32
Typically, HALs implement their own Delay. Given it only uses cortex-m peripheral, there's no reason HALs need to keep this; this cortex-m library includes a delay.
However, it's dependent on embedded-hal::Delay. Can we make the implementation native, and add EH as an optional add-on? This way, you don't need to import the trait, or include it in your project. I'll do a PR if approved.

In case it helps, the use case is this:

I have a STM32 HAL library that implements its own Delay (In a similar way to other cortex-m-based HAL libraries). It uses the cortex_m systick peripheral, and no stm32-specific peripherals. I think this, and other HALs can delete their Delay modules, and direct users to use the one here, in cortex_m instead.

I don't think user code should rely on embedded-hal traits; their main use case is in writing generic drivers. Currently, I'm unable to delete the Delay module and defer to the cortex-m crate, since it would require user code to import embedded-hal, since cortex_m::delay::Delay requires it.

I still don't get why cortex-m Delay driver shouldn't rely on embedded-hal while HALs can rely on embedded-hal for the same delay driver.

HALs shouldn't IMO. Generic drivers should.

Yes, and which crate should provide these DelayMs/DelayUs implementations for generic drivers?

The HALs provide them. The drivers use them, and import the trait.
User code that flashes to an MCU doesn't need them.
@Rahix  has a good write up here

So you suggest that cortex-m has a Delay driver, but DelayMs/DelayUs should be provided by HALs? I don't understand why it should work like this. What if I have a generic Cortex-M (FPGA) core and no HAL?

No - I'm suggesting cortex-m supply a native impl, and an EH impl - as in the PR. And HALs delete their Delay module.

Ohh, I forgot that now we have fallible-only Delay* traits. Now it makes sense.


Any plugin for Light weight editor.

Any plugin for Light weight editor. Like Sublime text ,Atom or something for linux user.

@basarat can help you more with the atom typescript plugin.
There should be a sublime text sublime plugin coming out soon as well. stay tuned :)

@vinaymavi let us know if you have any issues with atom

There are vim, emacs, and sublime plugins based on https://github.com/clausreinke/typescript-tools
Master branch is a bit behind, as TS v1.5 has not reached stable/npm registry yet, but the testing_ts1.4 branch supports TS  v1.5.

In addition to the other recommendations we have a pre-alpha version of a Sublime plugin in the repo here https://github.com/Microsoft/ngconf2015demo. Forgive the hacky acquisition process, would love to get more feedback on it as we move towards a real release for it. There're also a couple existing Sublime plugins you can find in Package Control.

Now available https://packagecontrol.io/packages/TypeScript


Repo sync for protected CLA branch

The pull request is created from main637922919102682800 to main to fix git push error for protected CLA branch

@ghogen : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Docs Build status updates of commit 3a5b0d9:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: GitBranchDeletedOrForcePushed] Cannot sync git repo to specified commit because branch main637922919102682800 has been deleted or has been force pushed

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 3a5b0d9:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: GitBranchDeletedOrForcePushed] Cannot sync git repo to specified commit because branch main637922919102682800 has been deleted or has been force pushed

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Add support for android subscription switching

The Cordova plugin uses the oldSku to allow users to change subscriptions. Even though this package has the struct for this functionality unfortunately it's not being used.

Hey @SergenN thanks for the feedback i'm not sure to understand what you mean, could you point me to the code or the doc of the cordova one  ?

oh, ok thanks! i added it !


Modus Navbar - Add button not opening pop-up menu on Enter key press

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have read the contributing guidelines

Describe the issue
It looks like pressing ENTER key on icons added from buttons prop not opening the menu pop-up
Reduced test cases
No response
What operating system(s) are you seeing the problem on?
Windows
What browser(s) are you seeing the problem on?
Chrome
What is the issue regarding ?
@trimble-oss/modus-web-components
What version of npm package are you using ?
No response
Priority
High
What product/project are you using Modus Components for ?
modus
What is your team/division name ?
modus
Are you willing to contribute ?
None
Are you using Modus Web Components in production ?
No response

Plan:

Support both SPACE and ENTER to open/close
ESC can also close

@ElishaSamPeterPrabhu can you check if the issue is fixed in the Navbar. It looks like Enter is handled, but Space and Escape key is not working as expected.

@ElishaSamPeterPrabhu can you check if the issue is fixed in the Navbar. It looks like Enter is handled, but Space and Escape key is not working as expected.

The behavior is added for buttons added dynamically
export interface ModusNavbarButton {
  id: string;
  icon: string;
  orderIndex: number;
  hideMenu?: boolean;
  tooltip?: ModusNavbarTooltip;
}
buttons: ModusNavbarButton[];

for buttons like help and profile which have boolean properties for their visibility the behavior is not set

@ElishaSamPeterPrabhu can you check if the issue is fixed in the Navbar. It looks like Enter is handled, but Space and Escape key is not working as expected.

The behavior is added for buttons added dynamically
export interface ModusNavbarButton {
id: string;
icon: string;
orderIndex: number;
hideMenu?: boolean;
tooltip?: ModusNavbarTooltip;
}
buttons: ModusNavbarButton[];
for buttons like help and profile which have boolean properties for their visibility the behavior is not set.

Since the expected behavior this as discussed with @enowak1031 am closing the issue


BG task spark polling needs improvement

Using the library polling to poll Spark when tasks are complete from bg tasks.
Currently, waiting for available from response headers, and polling infinitely.  This seems to work so far, given even an error in a Spark job returns available.   But there are likely edge cases like Spark goes down or is reset, which would return something different.  Need to figure these out and handle.

Not an issue with Celery anymore (or at least changed).


The column break no longer seems to work

I used to be able to use  2 rows of 3 back ticks To start a new column but it no longer works.
Additional Details
http://homebrewery.naturalcrit.com/share/SkbdVD4uNz
or
Brew code to reproduce : Click to expand

the only 2 places with column breaks are just before # headings, which always start a new section anyway so they have no effect. What are you trying to get it to do?

Not seeing issue in shared brew. Closing.


Don't include PR number in commit link in same PR

Description
Currently, if you paste a commit link like https://github.com/refined-github/refined-github/pull/6145/commits/c71e0bc631a1e27ec75044fc95cc2b4b4839258a into a comment on my PR and use refined-github's "Fix link" feature, it includes the PR number like this: c71e0bc (#6145).
I propose that this feature should dynamically include/omit the PR number from the link's text depending on whether you are commenting in that same PR, in which case the PR number seems redundant.
So, using the same link as above…

OUTSIDE REPO (OUTSIDE PR) — currently supported ✅
commenting elsewhere outside of the repo, it would replace the link with:
refined-github/refined-github@c71e0bc (#6145)

INSIDE REPO, OUTSIDE PR — currently supported ✅
commenting in the same repo, but outside the PR, it would replace the link with:
c71e0bc (#6145)

INSIDE REPO, INSIDE PR — currently supported ❌
commenting in the PR, it would replace the link with:
c71e0bc

Screenshot
After pasting link

After clicking "Fix link" in "Write" mode

After clicking "Fix link" in "Preview" mode

Example URLs
https://github.com/refined-github/refined-github/pull/6145/commits/c71e0bc631a1e27ec75044fc95cc2b4b4839258a

If we don't include the PR number, I think we should still mention "PR commit" or else, like GitHub, a commit link will be indistinguishable from a PR commit link

https://github.com/refined-github/refined-github/commit/c71e0bc631a1e27ec75044fc95cc2b4b4839258a
c71e0bc

This should be fixed in:

https://github.com/refined-github/refined-github/blob/71c16f38d5d7853e57bd3e36852175b30eed89c3/source/github-helpers/prevent-link-loss.ts

I'm not sure why the feature wasn't implemented using https://github.com/refined-github/shorten-repo-url, which has this specific logic already (although probably doesn't support this exact type of link)
Similar request:

https://github.com/refined-github/refined-github/issues/6057


Add support for skin tones

This pull request adds skin toned emoji to the map

Hm, not sure if this is the best way to handle skin tones, to be honest, as the file size increases from 40KB to 100KB.
Perhaps we can have a different file that contains a list of the emojis that support skin tones?
We could still have a setting for adding each individual one to the main JSON file - but it'd be off by default.

I'd be happy with a separate file, this pull request is mostly to resolve the auto-complete on the Emoji extension for Flarum (which supports tones, but can't auto-complete with tones) so if we add via a separate file and then upgrade the Flarum extension to load that new file I'd be pretty happy with that result.

Yeah I think the separate file is better - a file that only has a list of the emojis that support it, so then when parsing it can be looped like in the code you added here.
Though actually, some emojis support more than just 5 tones (since v12 - https://milesj.gitbook.io/emojibase/spec#v-12-0) so... not sure how to handle that with just a simple list. Perhaps simply have an object with the list of possible tones? Something like this:
{
  "<shortcode>": [1, [1,2], [1,3], ..., 2, ..., 5]
}

The extra skin tones are already in the short code, for example holding_hands_people_tone1-4 is two gender neutral people holding hands, first person being tone1 and the second person being tone4

i just remembered this PR exists

The tones are now in a separate file, they aren't exported though, not sure how you want to handle that. Further it's just a list of short-codes and the respective emoji.

Merged this, not sure if I'll release because I think having a relationship between shortcodes & skin tones would be useful too. And not just skin tones necessarily, perhaps variants too. Not a priority though.

The variants do exist here, things like families with multiple skin tones are supported by the PR. It's probably not the most efficient thing though.


Merge xunit to xplat

This is the great merge of all of the master xunit conversion into xplat.
Current status is that it builds for full framework (with some errors like xunit/xunit#587, including in the command-line nuget restore).  I haven't tried building for CoreCLR yet, but since that was broken before . . .
The merge was big and very ugly.  Hopefully things are doing ok.

@dsplaisted any ideas about avoiding the
Some packages are not compatible with DNXCore,Version=v5.0 (win7-x86). (TaskId:206)

error?

@rainersigwald Try adding an imports element in project.json under dnxcore50 like this:
    "dnxcore50": {
      "dependencies": {
        "Microsoft.NETCore": "5.0.0",
        "Microsoft.NETCore.Portable.Compatibility": "1.0.0",
        "System.Console": "4.0.0-beta-23123",
        "System.Runtime": "4.0.20",
        "System.Runtime.InteropServices.RuntimeInformation": "4.0.0-beta-23213",
        "Microsoft.NETCore.Runtime": "1.0.0",
        "Microsoft.NETCore.TestHost-x86": "1.0.0-beta-23123",
        "xunit.console.netcore": "1.0.2-prerelease-00092"
      },
      "imports": "portable-net451+win81"
    }

I got offline LGTMs from @AndyGerlicher and @ValMenn in our internal status meeting today.


Issue with recognizing Zinc finger

For the CTCF cohort
https://github.com/monarch-initiative/gpsea-cs/blob/develop/notebooks/CTCF/CTCF_gpsea.ipynb
the "normal" way of showing the Protein structure with UniProt API does not show the Zinc finger domains.
from gpsea.model.genome import GRCh38
from gpsea.model import ProteinMetadata
from gpsea.preprocessing import configure_default_protein_metadata_service, VVMultiCoordinateService
from gpsea.view import ProteinVisualizer
import matplotlib.pyplot as plt

txc_service = VVMultiCoordinateService(genome_build=GRCh38)
pms = configure_default_protein_metadata_service()
tx_coordinates = txc_service.fetch(mane_tx_id)
protein_meta = pms.annotate(mane_protein_id)

ctcf_fig, ax = plt.subplots(figsize=(15, 8))
visualizer = ProteinVisualizer()
visualizer.draw_protein_diagram(
    tx_coordinates,
    protein_meta,
    cohort,
    ax=ax,
)
ctcf_fig.tight_layout()

However, using this works
protein_meta = ProteinMetadata.from_uniprot_json(protein_id=mane_protein_id, label="CTCF",
                                                 uniprot_json="P49711.json",
                                                 protein_length=727)

I recently made a PR to add Zinc finger to the recognized domains, not sure why this is not working for both.

Also this:
File ~/GIT/gpsea-cs/venv/lib/python3.12/site-packages/gpsea/model/_protein.py:144, in FeatureType.from_string(category)
    [142](https://file+.vscode-resource.vscode-cdn.net/Users/robin/GIT/gpsea-cs/notebooks/SLC32A1/~/GIT/gpsea-cs/venv/lib/python3.12/site-packages/gpsea/model/_protein.py:142)     return FeatureType.ZINC_FINGER
    [143](https://file+.vscode-resource.vscode-cdn.net/Users/robin/GIT/gpsea-cs/notebooks/SLC32A1/~/GIT/gpsea-cs/venv/lib/python3.12/site-packages/gpsea/model/_protein.py:143) else:
--> [144](https://file+.vscode-resource.vscode-cdn.net/Users/robin/GIT/gpsea-cs/notebooks/SLC32A1/~/GIT/gpsea-cs/venv/lib/python3.12/site-packages/gpsea/model/_protein.py:144)     raise ValueError(f'Unrecognized protein feature type: "{category}"')

ValueError: Unrecognized protein feature type: "Topological domain"

(SLC32A1 cohort)

I removed the FeatureType enum in #369 and I expect the new code to resolve this issue. Please reopen if the issues persist.


Sort Table is adding the rows instead of refresh

Team,
Not sure Its problem in my code or not, When i click on sort on a column the DataTable is appending the new rows to the existing rows. Can you please guide..
Page loading

After click on sort button of county column

The pagination's sizePerPage is limited to '5' records
Thanks in advance

Is key field unique ? I had similar problem when filtering and it turned out the keyField I used is not unique.

Is key field unique ? I had similar problem when filtering and it turned out the keyField I used is not unique.

Sure Rita Zhao i will try and let you know the result

Thank you  Rita Zhao tried and its working as expected now ...


Upgrading gax, grpc, opencensus

It looks like something changed with the behavior of retries in gax

I'm guessing the issue is:
https://github.com/googleapis/gax-java/pull/712


hasRole method for an array or alternative method

Can you support one of multiple methods hasRoleOf type Array? If its a dynamic Role ID, I want to support an array so one of n number of role types. If not, can we have a lookup function that gets any number of roles and does a for loop from the database based on some type of criteria?

I will check it today.


Jumping modal in Agree with ID - Add comment

When clicking on the "Agree with ID" button and then on Add comment the comment modal keeps jumping up and down.
https://github.com/inaturalist/iNaturalistReactNative/assets/17345891/e5c84a7b-bb45-42d8-8591-fb39273763db

I'm struggling to reproduce this one too. Could you add some more detail? Like are you on Explore or MyObs?


Unit test/build pipeline steps and email notifications

Separated out build stages to include a unit test stage to capture test metrics. Added email notifications

@ALRubinger the build pipeline step was refactored to mvn install. Please review

bc2128ef4993ebd188bf33414d7c1257533fa295


Group By does not support complex expression

Summary of Bug
The group by operation does not support complex expression as the group by key. For example, group by (case when column1 is null)...
Version
Reproducible on all versions.
Steps to Reproduce
select  case when column1 is null then 'null_value' else column end, max(column2) group by case when column1 is null then 'null_value' else column1 end
Reasons
I tried to find out the behind reason. An exception was thrown at Utils.scala:1464. The serializer treefold the CASE WHEN expression and tried to look for column1 in the output list of the sub-executor and it failed.
Finally, I found the root cause is at strategies.scala:177-234. When the optimizer generates the plan for encrypted SQL, it generates multiple executors for one AGG executor. And it simply passes the group by key of the original AGG executor to other nodes. As such, for some of the generated executors, the serializer failed to find the input of the executors from the sub-executor's output.

@xlxie I just took a look, and it does seem that our aggregates do not support complex expressions as group keys for that exact reason. Would you be interested in submitting a PR with the fix? Happy to help debug, offer advice, and review!

No problem. Please allow me to spend some time to learn about how to contribute to this project.


Improve markers visibility

How to make markers in dense clusters more visible (clustering? link1, link2).
How to bind markers together? E.g. show boss and associated dungeon and the drop (e.g. blueprint) together.

Maybe make all markers small and represent group/category and show detailed image and information in marker popup.


can not verify for raspberry pi pico board

I tried to use ls100 for raspberry pi pico but i can not verify the sketch

https://github.com/Legion2/CorsairLightingProtocol#create-a-lighting-node-pro-for-a-raspberry-pi-pico-with-tinyusb

i tried it but i do not see tinyUSB anywhere in the example list and neither in corsair protocol example list

the version with tinyUSB is not released jet #267

I release it in 0.15.0, it will take an hour to be available in the Arduino IDE.


Allow usage with generic RSS feeds

With some minor changes I was able to get it working with an existing generic RSS feed.
Cheers!

If we want to go generic we should do it well though :) We should only show the "Launch ShowRSS" menu item if the user has a showrss feed configured, and rename the box in the preferences from "ShowRSS Feed" to just "Feed", in all localizations.
This would take us half of the way towards #4. Do you want to tackle this?

Ya that shouldn't be too bad.
Btw it looks like it works fine with sandboxing enabled, any reasons not to enable it?

See #36

Wow, great job!
One nitpick: in MenuController.swift, could you have it subscribe to Defaults.changedNotification (and call refreshMenuContents()) as well? This is because semantically the reason it needs to refresh is the preferences change rather than the feed check happening.
Other than that, LGTM!

@mipstian Oh yeah good catch, fixed. Cheers!

Perfecto. Thanks @chrisballinger !

I've put out a prerelease with your change, in case you want to run a signed, optimized build :) https://github.com/mipstian/catch/releases/tag/2.0-alpha4

Awesome thank you!


Updated Packer and Ansible to support the new Kali Linux AMI

This works against the real host, but the Molecule container is having issues starting Docker itself.


⚠ Bofrost.lu has degraded performance

In 20b66a9, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2015 ms

Resolved: Bofrost.lu performance has improved in e1aa987 after 6 minutes.


Incorrect scroll behavior when scrolling nested ListViews using two finger scrolling on a touchpad

Steps to Reproduce

Create nested ListViews, that is to say a ListView with vertical scroll axis that has other ListViews (with horizontal scroll axis) as children.
Try to scroll in the vertical direction and try scrolling in the horizontal direction using two finger scrolling on a touch pad. In the horizontal direction, the scroll axis is properly locked but it isn't in the vertical direction. Try scrolling vertically slowly with two fingers held down and scroll up and down without picking up your fingers rather than a quick flick. The quick flick seems to work properly.

Here's the code to reproduce the error. I've only tested this on a MacBook in Flutter Web:
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        body: ListView.builder(
          itemBuilder: (context, index) => Container(
            height: 210,
            child: ListView.builder(
              scrollDirection: Axis.horizontal,
              itemBuilder: (context, index) => Box(),
            ),
          ),
        ),
      ),
    );
  }
}

class Box extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Container(
        height: 200,
        width: 200,
        padding: EdgeInsets.all(10),
        child: Container(
          color: Colors.grey,
        ));
  }
}

Expected results:
The desired result is that when you begin scrolling vertically, the scroll direction is "locked" and you will not accidentally scroll horizontally as is the case when you scroll by dragging the mouse (or via touch screen);
Actual results:
Instead scrolling vertically is very buggy and it switches back and forth between horizontal and vertical scrolling.
Here is a video of the behavior:
bug video.zip

Logs

flutter run --verbose
[ +163 ms] executing: [/Users/jonathanaird/developer/flutter sdk/flutter/] git -c
log.showSignature=false log -n 1 --pretty=format:%H
[  +73 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[        ] 198df796aa80073ef22bdf249e614e2ff33c6895
[        ] executing: [/Users/jonathanaird/developer/flutter sdk/flutter/] git tag --points-at HEAD
[  +28 ms] Exit code 0 from: git tag --points-at HEAD
[   +1 ms] 1.23.0-18.1.pre
[  +20 ms] executing: [/Users/jonathanaird/developer/flutter sdk/flutter/] git rev-parse --abbrev-ref
--symbolic @{u}
[  +20 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[        ] origin/beta
[        ] executing: [/Users/jonathanaird/developer/flutter sdk/flutter/] git ls-remote --get-url
origin
[  +14 ms] Exit code 0 from: git ls-remote --get-url origin
[        ] https://github.com/flutter/flutter.git
[  +86 ms] executing: [/Users/jonathanaird/developer/flutter sdk/flutter/] git rev-parse --abbrev-ref
HEAD
[  +26 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[        ] beta
[   +9 ms] executing: sw_vers -productName
[  +48 ms] Exit code 0 from: sw_vers -productName
[   +1 ms] Mac OS X
[   +1 ms] executing: sw_vers -productVersion
[  +28 ms] Exit code 0 from: sw_vers -productVersion
[        ] 10.15.7
[        ] executing: sw_vers -buildVersion
[  +27 ms] Exit code 0 from: sw_vers -buildVersion
[        ] 19H2
[        ] executing: uname -m
[   +7 ms] Exit code 0 from: uname -m
[        ] x86_64
[  +75 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[   +9 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[  +13 ms] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[ +150 ms] executing: /Users/jonathanaird/Library/Android/sdk/platform-tools/adb devices -l
[  +13 ms] executing: /usr/bin/xcode-select --print-path
[  +13 ms] Exit code 0 from: /usr/bin/xcode-select --print-path
[        ] /Library/Developer/CommandLineTools
[   +2 ms] executing: /usr/bin/xcodebuild -version
[   +5 ms] Exit code 1 from: /usr/bin/xcodebuild -version
[        ] xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory
'/Library/Developer/CommandLineTools' is a command line tools instance
[        ] Xcode not found. Run 'flutter doctor' for more information.
[   +2 ms] executing: /usr/bin/xcodebuild -version
[   +7 ms] Exit code 1 from: /usr/bin/xcodebuild -version
[   +1 ms] xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory
'/Library/Developer/CommandLineTools' is a command line tools instance
[  +74 ms] List of devices attached
[   +7 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[   +9 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +46 ms] executing: /usr/bin/xcodebuild -version
[   +5 ms] Exit code 1 from: /usr/bin/xcodebuild -version
[   +1 ms] xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory
'/Library/Developer/CommandLineTools' is a command line tools instance
[  +70 ms] Multiple devices found:
[ +225 ms] Web Server (web) • web-server • web-javascript • Flutter Tools
[   +1 ms] Chrome (web)     • chrome     • web-javascript • Google Chrome 86.0.4240.183
[   +2 ms] [0]: Web Server (web-server)
[        ] [1]: Chrome (chrome)
[   +2 ms] Please choose one (To quit, press "q/Q")
[        ] :

No issues found! (ran in 3.1s)

[✓] Flutter (Channel beta, 1.23.0-18.1.pre, on Mac OS X 10.15.7 19H2 x86_64, locale en-US)
    • Flutter version 1.23.0-18.1.pre at /Users/jonathanaird/developer/flutter sdk/flutter
    • Framework revision 198df796aa (3 weeks ago), 2020-10-15 12:04:33 -0700
    • Engine revision 1d12d82d9c
    • Dart version 2.11.0 (build 2.11.0-213.1.beta)

[!] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/jonathanaird/Library/Android/sdk
    ✗ Flutter requires Android SDK 29 and the Android BuildTools 28.0.3
      To update the Android SDK visit
      https://flutter.dev/docs/get-started/install/macos#android-setup for detailed instructions.
    • All Android licenses accepted.

[✗] Xcode - develop for iOS and macOS
    ✗ Xcode installation is incomplete; a full installation is necessary for iOS development.
      Download at: https://developer.apple.com/xcode/download/
      Or install Xcode via the App Store.
      Once installed, run:
        sudo xcode-select --switch /Applications/Xcode.app/Contents/Developer
        sudo xcodebuild -runFirstLaunch
    ✗ CocoaPods installed but not working.
        You appear to have CocoaPods installed but it is not working.
        This can happen if the version of Ruby that CocoaPods was installed with is different from
        the one being used to invoke it.
        This can usually be fixed by re-installing CocoaPods. For more info, see
        https://github.com/flutter/flutter/issues/14293.
      To re-install CocoaPods, run:
        sudo gem install cocoapods

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 3.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 33.3.1
    • Dart plugin version 182.5215
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)

[✓] VS Code (version 1.50.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.16.0

[✓] Connected device (2 available)
    • Web Server (web) • web-server • web-javascript • Flutter Tools
    • Chrome (web)     • chrome     • web-javascript • Google Chrome 86.0.4240.183

Hi @jonaird
Thanks for the filing the issue, I can reproduce on web and desktop
Preview

code sample
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        body: ListView.builder(
          itemBuilder: (context, index) => Container(
            height: 210,
            child: ListView.builder(
              scrollDirection: Axis.horizontal,
              itemBuilder: (context, index) => Box(),
            ),
          ),
        ),
      ),
    );
  }
}

class Box extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Container(
        height: 200,
        width: 200,
        padding: EdgeInsets.all(10),
        child: Container(
          color: Colors.grey,
        ));
  }
}

multiple flutter doctor -v
[✓] Flutter (Channel beta, 1.23.0-18.1.pre, on Mac OS X 10.15.7 19H15 x86_64,
    locale en-GB)
    • Flutter version 1.23.0-18.1.pre at /Users/tahatesser/Code/flutter_beta
    • Framework revision 198df796aa (4 weeks ago), 2020-10-15 12:04:33 -0700
    • Engine revision 1d12d82d9c
    • Dart version 2.11.0 (build 2.11.0-213.1.beta)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/tahatesser/Code/sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_HOME = /Users/tahatesser/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.2)
    • Xcode at /Volumes/SanDisk/Xcode-beta.app/Contents/Developer
    • Xcode 12.2, Build version 12B5044c
    • CocoaPods version 1.10.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.51.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.16.0

[✓] Connected device (4 available)
    • Taha’s iPad (mobile)       • 00008020-000255113EE8402E            • ios
      • iOS 14.2
    • iPhone 12 Pro Max (mobile) • 0A159C14-BF48-4DD7-8D91-F45A387EE4B2 • ios
      • com.apple.CoreSimulator.SimRuntime.iOS-14-2 (simulator)
    • Web Server (web)           • web-server                           •
      web-javascript • Flutter Tools
    • Chrome (web)               • chrome                               •
      web-javascript • Google Chrome 86.0.4240.183
    ! Error: Taha’s iPad is busy: Copying cache files from device. Xcode will
      continue when Taha’s iPad is finished. (code -10)

• No issues found!

[✓] Flutter (Channel master, 1.24.0-8.0.pre.149, on Mac OS X 10.15.7 19H15
    darwin-x64, locale en-GB)
    • Flutter version 1.24.0-8.0.pre.149 at
      /Users/tahatesser/Code/flutter_master
    • Framework revision 8e7748e74c (5 hours ago), 2020-11-08 20:32:04 -0800
    • Engine revision 0f7cdca65f
    • Dart version 2.12.0 (build 2.12.0-27.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/tahatesser/Code/sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_HOME = /Users/tahatesser/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.2)
    • Xcode at /Volumes/SanDisk/Xcode-beta.app/Contents/Developer
    • Xcode 12.2, Build version 12B5044c
    • CocoaPods version 1.10.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.51.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.16.0

[✓] Connected device (5 available)
    • Taha’s iPad (mobile)       • 00008020-000255113EE8402E            • ios
      • iOS 14.2
    • iPhone 12 Pro Max (mobile) • 0A159C14-BF48-4DD7-8D91-F45A387EE4B2 • ios
      • com.apple.CoreSimulator.SimRuntime.iOS-14-2 (simulator)
    • macOS (desktop)            • macos                                •
      darwin-x64     • Mac OS X 10.15.7 19H15 darwin-x64
    • Web Server (web)           • web-server                           •
      web-javascript • Flutter Tools
    • Chrome (web)               • chrome                               •
      web-javascript • Google Chrome 86.0.4240.183
    ! Error: Taha’s iPad is busy: Copying cache files from device. Xcode will
      continue when Taha’s iPad is finished. (code -10)

• No issues found!

@jonaird @TahaTesser I can only reproduce this on a MacBook. What device / touchpad did you use to reproduce it?
I cannot reproduce it on a ThinkPad (even if I try) - the scroll seems to be correctly locked there.

Just tried on a MacBook. Could be that on the Thinkpad the locking happens at the driver/OS level?

Happens to me on both the built in and the external Apple trackpad :)

@jonaird 👍
Seems to be also happening on Magic Trackpad.

/cc @Piinks Would you have time to take a look at this? (Desktop Triage)

/cc @Piinks Would you have time to take a look at this? (Desktop Triage)

/cc @Piinks Would you have time to take a look at this? (Desktop Triage)

Sure! I'll add it to my queue. :)

/cc @Piinks Would you have time to take a look at this? (Desktop Triage)

Sure! I'll add it to my queue. :)

The right way to solve this is most likely by adding official support for trackpads. I've seen a few mentions of trackpad behaviors in a couple of issues recently.. I am not sure what it will take to complete currently, and I have a few other scrolling issues of higher priority that will probably precede work here.
Also, cc @goderbauer since the application above is an example of 2D scrolling. When 2D scrolling is also supported officially this may not be an issue anymore.

I am not actively working on implementing trackpad support, so I am going to remove my assignment for now. Per https://github.com/flutter/flutter/issues/70046#issuecomment-775298491 there is work underway on 2D scrolling that may also provide a solution.

Any news? This issue still persists @gspencergoog @TahaTesser I'm having this issue while scrolling on Flutter Web

I've tried this on the master branch today and found that the errant behavior described above is now fixed.
When using two finger scrolling on trackpad, the axis that is not scrolling is locked, eliminating the stutter behavior in the above videos.
Many thanks to @moffatman! 🎉


Set internal SG state to Init for missing cloud SG

In case, nephe created resource in cloud is explicitly removed, the sync content will be NULL and internal SG state might be set to CREATED. Explicitly resetting the state to INIT, to re-create all the missing resources like SG, rules etc.
Signed-off-by: Rahul Jain<EMAIL_ADDRESS>

/nephe-test-e2e-kind, /nephe-test-e2e-eks, /nephe-test-e2e-aks


Wrong file extension name shown in logs

It shows .apk instead of .apkm:
https://github.com/user-attachments/assets/e6e0df84-6bcf-4700-8bed-a7ed6fb245ce

This is not a bug, it's showing where the merged file will be saved, including the filename of that merged file


Regression for authority host resolution since June 3rd 2022

Core Library
MSAL Node (@azure/msal-node)
Core Library Version
1.9.0
Wrapper Library
Not Applicable
Wrapper Library Version
None
Description
Since June 2nd, for @azure/identity package live tests are failing with the error - CredentialUnavailableError: endpoints_resolution_error: Error: could not resolve endpoints. Please check network and try again. Detail: ClientConfigurationError: untrusted_authority: The provided authority is not a trusted authority. Please include this authority in the knownAuthorities config parameter.
We hadn't made any changes to our code or dependencies during that time.  Were there any recent changes (from June 2nd) that were made to the authority host format in the msal JS library? The authority host that we have is of the form https://login.microsoftonline.com/<tenant-id>
We are facing this issue with all the credentials - Client Secret, Client Certificate, Username Password, Environment Credential
I am facing issues even with the latest versions of msal libraries:
@azure/msal-node 1.10.0 and @azure/msal-common 7.0.0
and with the previous versions as well @azure/msal-node 1.9.0 and @azure/msal-common 6.3.0
Error Message
CredentialUnavailableError: endpoints_resolution_error: Error: could not resolve endpoints. Please check network and try again. Detail: ClientConfigurationError: untrusted_authority: The provided authority is not a trusted authority. Please include this authority in the knownAuthorities config parameter.
Msal Logs
CredentialUnavailableError: endpoints_resolution_error: Error: could not resolve endpoints. Please check network and try again. Detail: ClientConfigurationError: untrusted_authority: The provided authority is not a trusted authority. Please include this authority in the knownAuthorities config parameter.
MSAL Configuration
auth: {
        clientId,
        authority,
        knownAuthorities: [authorityHost],
        clientCapabilities: ["cp1"],
      },
      system: {
        networkClient: this.identityClient
      },

Relevant Code Snippets
const credential = new ClientSecretCredential(
      env.AZURE_TENANT_ID!,
      env.AZURE_CLIENT_ID!,
      env.AZURE_CLIENT_SECRET!
    );
   const scope = "https://vault.azure.net/.default"
   const token = await credential.getToken(scope);

Reproduction Steps

Use @azure/identity 2.1.0-beta.2
Create an .env file and run the above code snippet
The test snippet above will fail with the error -
CredentialUnavailableError: endpoints_resolution_error: Error: could not resolve endpoints. Please check network and try again. Detail: ClientConfigurationError: untrusted_authority: The provided authority is not a trusted authority. Please include this authority in the knownAuthorities config parameter.

Expected Behavior
Should authorize and the authority host url should resolve.
Identity Provider
Azure AD / MSA
Browsers Affected (Select all that apply)
None (Server)
Regression
No response
Source
Internal (Microsoft)

On further investigation, found that this issue was caused due to a workaround for recorder configuration options added in the tests for @azure/identity SDK.  The workaround was getting triggered for live tests also, which shouldn't have happened. Removing of this workaround, solves the issue, we were facing in the live tests. No work required from MSAL and no customers were affected.


Feature/bugfix return codes

With this pull request i want to change the exit codes of stack_master for apply and delete, because they are 0 at the moment(everything ok) even if apply can't find parameters and delete can't find the stack to delete.
Now the exit code of this commands will return 1 if they fail.
We need this for using stack_master in cicd pipelines. At the moment the pipeline state is ok/green, even if some commands failed.
This belongs to issue https://github.com/envato/stack_master/issues/235

Does this PR solve the issue? https://github.com/envato/stack_master/pull/276

I think this is fixed in #280


symbiflow-vtr-gui: Stick to GCC <11

Tool's build scripts haven't been adapted to the latest GCC yet.
Co-authored by: Maciej Dudek<EMAIL_ADDRESS>

The job has been making the whole CI fail since 5th of August.
GCC 11.1 was used in all of these failing builds and the latest successful one used GCC 9.
In the CI GCC 10.3.0 was used successfully so the problem seems to be strictly related to the GCC 11.


update tika-parsers, jackson and jsoup

Description

This PR updates dependencies to fix open security warnings.
Motivation and Context

update jackson to 2.13.1 (https://github.com/FasterXML/jackson-databind/issues/3328) and set to same version as tika-parsers
update jsoup to 1.14.3 (CVE-2021-37714) and same version as in tika-parsers too
tika-parsers to 1.28, fixes dependent jsoup as well as

commons-compress (CVE-2021-36090, CVE-2021-35517,CVE-2021-35516, CVE-2021-35515)
jdom2 (CVE-2021-33813)

Question - the changes.xml mentions direct dependency updates only i think. Shall these indirect dependency updates for commons-compress and jdom2 also get an entry there or mention update of tika-parsers only is enough?
How Has This Been Tested?

run gradlew check and used updated libs in our installation for some days.
Screenshots (if appropriate):
Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] My code follows the code style of this project.
[x] I have updated the documentation accordingly.

Codecov Report

Merging #695 (09d0386) into master (85580b4) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #695   +/-   ##
=========================================
  Coverage     55.59%   55.59%
- Complexity    10336    10337    +1
=========================================
  Files          1059     1059
  Lines         65050    65050
  Branches       7401     7401
=========================================
+ Hits          36163    36165    +2
+ Misses        26337    26336    -1
+ Partials       2550     2549    -1

Impacted Files
Coverage Δ

...a/org/apache/jmeter/timers/PoissonRandomTimer.java
78.37% <0.00%> (+5.40%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85580b4...09d0386. Read the comment docs.

Shall these indirect dependency updates for commons-compress and jdom2 also get an entry there or mention update of tika-parsers only is enough?

That is a good question.
I guess we might want to "autogenerate" the set of differences based on something like https://github.com/apache/jmeter/blob/85580b49ee2f06505129ebccac5d382e412c58e2/src/dist/src/dist/expected_release_jars.csv
In other words, I would prefer to highlight the diff of all the dependencies (including transitive ones) shipped as a part of the default binary distribution.
However, I am fine with proceeding with any approach for now.

Thanks for the PR.
@vlsi autogenerating would be fine, but I am fine with current status, too :)


Check if form.$form is undefined in utils\get-field-from-state

Prevents throwing "TypeError: Cannot read property 'model' of undefined" on line 24 when using typescript with combined forms

Thank you!


Installation not working on Rails 6.0 stable

I'm getting an error when I try to install it with Rails 6.0.0 stable.
With gem 'acts-as-taggable-on', '~> 6.0' on the Gemfile I get this error:

I fixed changing to this line in the Gemfile:
gem 'acts-as-taggable-on', git: 'https://github.com/mbleigh/acts-as-taggable-on'
And I get the output:
Using acts-as-taggable-on 6.0.1 (was 5.0.0) from https://github.com/mbleigh/acts-as-taggable-on (at master@fbf2b60).
Bundle completed, no error present.
Any idea of why is this occurring? It's safe to use 6.0.1 in production?

@tolesco you installed the gem from the master branch which is in development. So I would not recommend using that in production I think you could better wait for version 6.1 to be released.
I would like to upgrade the project I'm currently working on to Rails version 6.0 so I hope version 6.1 will be released soon.

@sandergroen thanks for the tip, I'll wait for version 6.1 as you told me: D

ping @mbleigh

Any news on this?

@seuros I see that the PR has been merged. Is there a plan to publish the release to rubygems soon? Thanks!


refactor: change templateUrl and styleUrls to use absolute paths

Current behavior:

With this change, the tab labels become CSS and HTML as usual, instead of the file paths and also the stackblitz folder structure will be correct.

Yeah, agreed. The paths should be normalized in the docs site, or at minimum in the example module generation (see tools/example-module folder).

I agree with you, but almost all of the paths in the repo are not relative, these here are outside the rule. I think the best thing to do now is to fix the broken examples and then try to change the document generation or anything else.
Anyway, let me know the path you would want proceed with this PR.

I think it's totally fine using either ./my-file.css or my-file.css. Both are relative paths starting with the directory that contains the declaring component file. Updating the docs to deal with non-normalized paths shouldn't be any slower than making the examples use non-enforced path conventions.

I'd personally prefer closing this PR and just fixing this in the docs site. Happy to accept a PR if you'd like to take a look there. Thanks anyway for trying to fix this (even with this PR).

+1 to @devversion, the urls here are valid, even if our other tooling has issues; I'd rather focus on fixing the tooling

No problem guys. When I have some time left, I take a look at document generation.


Feature branch

Hello @levy002,
I have tried to fix the issue of git-flow to my maximum limit but failed. Please tell me how can I fix that?


Validate num_workers

build

@wbo4958 looks like the build errors can be fixed with this code

build

@wbo4958 looks like the build errors can be fixed with this code

Oops, I should run all the tests. Thx @leewyang for the help

build


ulp_s_sources is not working as expected in CMakeList.txt (IDFGH-2635)

Environment

Development Kit: Any [ESP32-Wrover-Kit|ESP32-DevKitC|ESP32-PICO-Kit|ESP32-LyraT|ESP32-LyraTD-MSC|none]
Kit version (for WroverKit/PicoKit/DevKitC): Any [v1|v2|v3|v4]
Module or chip used: Any [ESP32-WROOM-32|ESP32-WROOM-32D|ESP32-WROOM-32U|ESP32-WROVER|ESP32-WROVER-I|ESP32-WROVER-B|ESP32-WROVER-IB|ESP32-SOLO-1|ESP32-PICO-D4|ESP32]
IDF version (run git describe --tags to find it):
v4.0-rc
Build System:       CMake idf.py
Compiler version (run xtensa-esp32-elf-gcc --version to find it):
xtensa-esp32-elf-gcc (crosstool-NG esp-2019r2) 8.2.0
Operating System:     Windows
(Windows only) environment type: ESP Command Prompt.
Using an IDE?: No
Power Supply: External 3.3V

Problem Description
I'm migrating to CMake a project that I used to run in 3.x from IDF. After solving all compilation issues so far, I'm now facing one that seems to me is a ESP-IDF issue. I'm trying to add multiple .S files into the CMakeList.txt, in the "set(ulp_s_sources" area and seems to only add the first file, which in this case is "ulp/BatteryCharger.S"
#
# ULP support additions to component CMakeLists.txt.
#
# 1. The ULP app name must be unique (if multiple components use ULP).
set(ulp_app_name ulp_${COMPONENT_NAME})
#
# 2. Specify all assembly source files.
#    Files should be placed into a separate directory (in this case, ulp/),
#    which should not be added to COMPONENT_SRCS.
set(ulp_s_sources ulp/BatteryCharger.S ulp/BatteryGauge.S ulp/HallSensor.S ulp/i2c.S ulp/i2c_BMI160.S ulp/i2c_LC709203F.S ulp/main.S ulp/stack.S)
#
# 3. List all the component source files which include automatically
#    generated ULP export file, ${ulp_app_name}.h:
set(ulp_exp_dep_srcs "main.c")
#
# 4. Call function to build ULP binary and embed in project using the argument
#    values above.
ulp_embed_binary(${ulp_app_name} ${ulp_s_sources} ${ulp_exp_dep_srcs})`

I noticed it because after compiling it (either clean or dirty), the ulp_main.h file generated have only variables declared extern from "ulp/BatteryCharger.S" and not also from the others files.
Expected Behavior
To generate "ulp_main.h" with all the variables inside the files listed in "set(ulp_s_sources"
Actual Behavior
Just generating "ulp_main.h" with variables from the first file listed which makes my compilation to fail because is not able to find variables I have in main from the other .S files.
Steps to reproduce

Create a project that makes use of ULP
Make sure your project uses at least 2 assembly files with global variables each.
List them inside CMakeList.txt in main folder.
Compile and look for "ulp_main.h" inside "yourprojectname\build\esp-idf\main\ulp_main\ulp_main.h"

I got an issue similar to yours, I hope they solve that asap

@sch0bert Thanks for reporting and thanks @AeyrtonVillalobos for updates. We will look into this and provide feedback when available. Thanks.

Hi @sch0bert,
This is an embarassing oversight for me, but adding quotes "" around ${ulp_s_sources} should make it work.
The examples work because ulp_s_sources and ulp_exp_dep_srcs contain only one file. We should probably update them and the docs.

Hello @renzbagaporo,
Well I don't know if what you mean is from what I currently have:
set(ulp_s_sources ulp/BatteryCharger.S ulp/BatteryGauge.S ulp/HallSensor.S ulp/i2c.S ulp/i2c_BMI160.S ulp/i2c_LC709203F.S ulp/main.S ulp/stack.S)
change it to this way:
set(ulp_s_sources "ulp/BatteryCharger.S ulp/BatteryGauge.S ulp/HallSensor.S ulp/i2c.S ulp/i2c_BMI160.S ulp/i2c_LC709203F.S ulp/main.S ulp/stack.S")
Because I did it and it behaves the same way, it doesn't add any of the global variables from the others files (apart ulp/BatteryCharger.S) to ulp_main.h
How is the right way to make it to work?

Hi @sch0bert ,
Any updates on your issue? I am also experiencing the same thing.
Thanks.

Not yet @iMazstick I'm still waiting for their reply and resolution :(

Hello guys, 8 days have passed since my last message. Any one looking at this?

What I meant was to change to:
ulp_embed_binary(${ulp_app_name} "${ulp_s_sources}" "${ulp_exp_dep_srcs}")

You should keep
set(ulp_s_sources ulp/BatteryCharger.S ulp/BatteryGauge.S ulp/HallSensor.S ulp/i2c.S ulp/i2c_BMI160.S ulp/i2c_LC709203F.S ulp/main.S ulp/stack.S)

as is.

This is not fixing the issue, it behaves the same even with your modification.

I can confirm what @sch0bert is saying. This does not resolve my issue either.

Hello guys, I'm also stuck on that problem, I've also tried what @renzbagaporo post, but yet same issue without any fix... Please help...

I noticed I'm not the only one still getting this issue...

@sch0bert @AeyrtonVillalobos @hectorMtz017 @iMazstick Thanks for feedback, we will look into, thanks.

@Alvin1Zhang Any update? I also have the same issue and the fix from @renzbagaporo does not solve it.
This issue seems to have been around for a while and there is some additional information available here: https://esp32.com/viewtopic.php?t=12273

I haven't tried that workaround yet but this could help the ESP guys to find a way to fix it quicker, I hope they make an official solution for this soon. It has been for so long...

@sch0bert Very sorry for the delay, the fix for this issue has been submitted for review and will be merged shortly.

I've update today and I am still unable to compile. Only the first assembly file is compiled.

Hi @iMazstick, can you post the log of the build? @sch0bert has created an issue https://github.com/espressif/esp-idf/issues/4906, do you have the same experience?

Hi @renzbagaporo, I have attached the log from the terminal as requested. I have also attached my CMake list file.
CMakeLists.txt
esp32_idf_4.2_comp_8.2.0_multiple_assembler_build_log.txt

Replacing
set(ulp_s_sources "ulp/i2c.S" "ulp/i2c-adc.S" "ulp/i2c-util.S" "ulp/main.S" "ulp/stack.S" "ulp/adc.S")
with
set(ulp_s_sources "ulp/i2c.S ulp/i2c-adc.S ulp/i2c-util.S ulp/main.S ulp/stack.S ulp/adc.S")
seems to help.
Essentially, all ulp files need to be declared within the two quotes.

@iMazstick, this is somewhat equivalent to the initial practice of placing ${ulp_s_sources} arg to ulp_embed_binary in quotes:
https://github.com/espressif/esp-idf/issues/4713#issuecomment-591195749
The docs and examples have also been updated to do it like this: bb639bb

I can confirm that I've tried everything in this thread and the only thing that worked was back-porting the changes mentioned in 07a7152 into my local copy of 4.0.
Will this fix be back-ported into 4.0 or do we need to wait for 4.1?

Yes this will be backported @jgcjoec.

Yes this will be backported @jgcjoec.

Any idea when is it going to be ported? I'm asking because my code used to compile with 4.0 version and now does not work with 4.2 due this issue: https://github.com/espressif/esp-idf/issues/4906


trouble with policy list

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az policy assignment list
Errors:
APIVersion 2019-09-01 is not available
Traceback (most recent call last):
python3/dist-packages/knack/cli.py, ln 206, in invoke
    cmd_result = self.invocation.execute(args)
cli/core/commands/__init__.py, ln 608, in execute
    raise ex
cli/core/commands/__init__.py, ln 666, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
cli/core/commands/__init__.py, ln 659, in _run_job
    six.reraise(*sys.exc_info())
lib/python3/dist-packages/six.py, ln 703, in reraise
    raise value
...
azure/cli/core/__init__.py, ln 493, in default_command_handler
    return op(**command_args)
cli/command_modules/resource/custom.py, ln 1393, in list_policy_assignment
    result = policy_client.policy_assignments.list()
mgmt/resource/policy/_policy_client.py, ln 141, in policy_assignments
    raise NotImplementedError("APIVersion {} is not available".format(api_version))
NotImplementedError: APIVersion 2019-09-01 is not available

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az policy assignment list

Expected Behavior
Environment Summary
Linux-5.11.0-41-generic-x86_64-with-glibc2.29
Python 3.8.10
Shell: bash

azure-cli 2.0.81

Extensions:
interactive 0.4.5
azure-devops 0.17.0

Additional Context

azure-cli 2.0.81 is not the official distribution. Please see https://github.com/Azure/azure-cli/issues/19640.


Rename "save proportions"

Save proportions is a bit of an ambuigous term, it is not clear that this will export the proportions to a file. When going through it we had the first impression we should press it after manual/automatic proportions to apply them.
Renaming this button to "Export proportions" or similar might help clarify this.

I agree with this change


Transfer labels

From @lfunkhouser on October 3, 2017 17:20
From @lfunkhouser on October 3, 2017 17:19
From @lfunkhouser on October 3, 2017 17:19
From @lfunkhouser on October 3, 2017 17:1
From @lfunkhouser on October 3, 2017 17:0
From @lfunkhouser on October 3, 2017 16:48
From @lfunkhouser on October 2, 2017 15:24
This issue is used to transfer issues to another repo
Copied from original issue: Esri/solutions-grg-widget#119
Copied from original issue: Esri/solutions-geoevent-java#79
Copied from original issue: Esri/military-feature-toolbox#27
Copied from original issue: Esri/military-features-data#272
Copied from original issue: Esri/coordinate-conversion-addin-dotnet#432
Copied from original issue: Esri/distance-direction-addin-dotnet#455
Copied from original issue: Esri/visibility-addin-dotnet#232

This issue was moved to ArcGIS/solutions-erg-widget#8

This issue was moved to Esri/solutions-geoevent-java#78


firefox: 81.0.2 -> 82, firefox-esr: 78.3.1esr -> 78.4.0esr

Motivation for this change
https://www.mozilla.org/en-US/firefox/82.0/releasenotes/ (https://www.mozilla.org/en-US/security/advisories/mfsa2020-45/) & https://www.mozilla.org/en-US/firefox/78.4.0/releasenotes/ (https://www.mozilla.org/en-US/security/advisories/mfsa2020-46/)
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS

[X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

I'm currently rebasing this.


Eliminate bare excepts

It's generally good practice not to have them as they interfere with interrupt handling.

👍  Thanks


Implement show popup when reset code

When an exercise code is reset, create a submission with empty data


Use legal include guard names

Fixes #102

I checked out the PR and used grep to confirm that was the only one left, so it looks good to merge after that change.

@patricksjackson all fixed


API for server side

[
   {
      "job_id":"4042261.pbsserver",
      "Job_Name":"run_make_hpc.sh",
      "job_state":"R",
      "Resource_List":{
         "mem":"16gb",
         "walltime":"23:59:00"
      },
      "resources_used":{
         "mem":"530652kb",
         "walltime":"00:09:16"
      }
   },
   {
      "job_id":"4042269[].pbsserver",
      "Job_Name":"cmq7144",
      "job_state":"B",
      "array ":"True",
      "array_state_count ":"Queued:44 Running:6 Exiting:0 Expired:0 ",
      "array_indices_submitted ":"1-50",
      "array_indices_remaining ":"7-50",
      "Resource_List":{
         "mem":"4gb",
         "walltime":"23:59:59"
      },
      "resources_used":{

      }
   },
   {
      "job_id":"4042269[1].pbsserver",
      "Job_Name":"cmq7144",
      "job_state":"R",
      "array_id ":"4042269[].pbsserver",
      "array_index ":"1",
      "Resource_List":{
         "mem":"4gb",
         "walltime":"23:59:59"
      },
      "resources_used":{
         "mem":"0b",
         "walltime":"00:00:13"
      }
   }
]

TODO: Tidy the above up, just figured I should document it

Most important fields:

job_id,
job_Name,
job_state,
Resource_List,
resources_used

For arrays:
array_index
Unused:

array_id
This would be very helpful for relating subjobs back to their parent array, except that it is not stable between queued, running, and expired subjobs.
For expired subjobs, the field is missing (Thanks I guess PBS) , so instead we have to use regex to pull out the parent job_id from the subjobs' job_id.


Update OCP logo, move to footer

Fixed by #55

@aguilerapy I think maybe the CSS changes for the footer color weren't committed?


Test DELETE submission

Test that a submission can be deleted with the Python client.
Metriq client method is here: https://github.com/unitaryfund/metriq-client/blob/3504b73e282864671e7227ad5796468872d1844d/metriq/client.py#L56
Controller route is here: https://github.com/unitaryfund/metriq-api/blob/d22472555de79112fe21ae4fd7ff529ef1e7a22d/metriq-api/controller/submissionController.js#L82
Service route is here: https://github.com/unitaryfund/metriq-api/blob/d22472555de79112fe21ae4fd7ff529ef1e7a22d/metriq-api/service/submissionService.js#L107

Works.
{'message': 'Successfully deleted submission.'...


Mitigate long classpath on Windows for JavaExec

Expected Behavior

JavaExec (task and inline method) can execute without any special handling on Windows as it does on Linux and macOS.
Current Behavior

Windows has a limit in term of long path and command-line arguments size. Given a really long classpath, a JavaExec task would typically succeed on macOS and fail on Windows. This causes a lot of pain to users and requires to use house-made solution or rely on 3rd party plugins.
Context

Possible Solutions
Solution 1: Modify JavaExecHandleBuilder to always pass all argument as arg file (JDK 9+)
Pro

Seemlessly work for Windows out of the box

Con

Sensitive information passed as command-line arguments are now in a file on-disk
The process command-line will only contain the arg file
Induce a performance hit for Linux and macOS where long command-line isn't an issue

Note

Care must be taken to make sure no arg file is already present on the command line

Solution 2: Modify JavaExecHandleBuilder to always pass only the classpath as arg file (JDK 9+)
Pro

Address the most common scenario for Windows
All arguments of interest are still on the process command-line

Con

Induce a performance hit for Linux and macOS where long command-line isn't an issue

Note

Care must be taken to make sure no arg file is already present on the command line

Solution 3: Modify JavaExecHandleBuilder as noted in the previous solutions but only for Windows (JDK 9+)
Pro

Narrow the fix to only Windows

Con

Given Windows will behave differently than the other system, other issues may arise from such as adding an arg file on Linux would work but not on Windows

Solution 4: Modify JavaExecHandleBuilder as noted in the previous solution but enable through a flag (JDK 9+)
Pro

User will control the behaviour as required

Con

Requires user interaction for proper configuration on Windows

Solution 5: Provide methods to compose the intended behaviour
Provide a method like argFile(Object... args) or pathingJar(FileCollection) that can be passed as arguments or as classpath respectively to generate the arg file and pathing Jar as well as providing the right argument or classpath to enable the feature.
Pro

User will control the behaviour as required
The solution fits nicely to address the issue with argument files as well as pathing Jar

Con

Requires user interaction for proper configuration on Windows

Solution 6: Use Windows long path notation (e.g. \?)
Need to confirm if this works with Java
Pro

Solve the issue without the negative effect of the arg file and pathing Jar

Con

Only newer Windows version can benefit from this technique
Changing the path notation may have an unexpected effect on the runtime.

Open Questions
Do we care about solving the issue for JDK 8?
Most of the solution rely on JDK 9 feature. We could expand by using the pathing Jar trick but may have a negative effect in certain use cases. Allowing users to decide how to solve the issue composing the behaviour as noted in solution 5 would help.
Is modifying the JavaExecHandleBuilder too wide?
JavaExecHandleBuilder is used in numerous places in Gradle and may impact more than what we are seeing at the moment. At the same time, solving the issue just for JavaExec task would be a poor decision as Project#javaexec is equally important. At the same time, we already handle arg files for worker API. Another one-off solution feels like a bad approach.

Possible DSLs could look like this:
Use arg file or pathing Jar for classpath
As a flag:
project.javaexec {
    classpath = configurations.runtime
    useArgFileClasspath() // or usePathingJarClasspath()
}

tasks.withType(JavaExec).configureEach {
    useArgFileClasspath() // or usePathingJarClasspath()

or, as a composable method
project.javaexec {
    classpath = asArgFile(configurations.runtime) // or asPathingJar(configurations.runtime)
}

tasks.withType(JavaExec).configureEach {
    classpath = asArgFile(classpath) // or asPathingJar(classpath)
}

Modeling arg file
project.javaexec {
    argumentProviders.add(argFile('some', 'argument', 'that', 'will', 'be', 'in', 'argument', 'file'))
}

tasks.withType(JavaExec).configureEach {
    argumentProvider.add(argFile('some', 'argument', 'that', 'will', 'be', 'in', 'argument', 'file'))
}

@lacasseio FYI Eclipse JDT has a few tricks to shorten the classpath, some of which work with older Java versions: https://git.eclipse.org/c/jdt/eclipse.jdt.debug.git/tree/org.eclipse.jdt.launching/launching/org/eclipse/jdt/internal/launching/ClasspathShortener.java

I think the best solution is to change the behavior only on Windows and change the classpath only if it's too long (to prevent performance issues when the classpath is not that long).
Also, why do we need to change the DSL? Can't we just convert the long classpaths (to a classpath-only jar for instance) behind the scenes when necessary?

It may have some impact and I guess some users may not want the "new default" we would be pushing. It would be good if there was a way to disable it if they prefer another way to shorten the classpath.

+1 for doing this transparently.  I think this should work for any version of Java we would support via JavaExec/javaexec, but this can be delivered in increments (just argfile, then manifest jar).
I would open this up to not just too long of a classpath, but too long of a command-line, since it would manifest itself as the same sort of problem and we need to know if the full command-line is too long and not just the classpath.  It looks like even Linux/macOS have limits: https://git.eclipse.org/c/jdt/eclipse.jdt.debug.git/tree/org.eclipse.jdt.launching/launching/org/eclipse/jdt/internal/launching/ClasspathShortener.java#n267
So some increments could be...

If the command-line is too long, we need to fail with a useful error.   Add coverage for several versions of Java with JavaExec and javaexec.
If the command-line is too long and we're only Java 9+, generate an argfile. We can still fail on <Java 9

If there is already an argfile in the arguments, we need to honor it/preserve the order.
We need to make sure we follow the rules for generating an argfile properly: https://docs.oracle.com/javase/9/tools/java.htm#JSWOR-GUID-4856361B-8BFD-4964-AE84-121F5F6CF111
If we're worried about leaving behind the contents of the command-line, we could delete the argfile after the command finishes.

If the command-line is too long and we're only <Java 9, we should attempt to shorten the classpath with a manifest jar.

If shortening the classpath still doesn't put the command-line under the limit, we should fail with a useful message.
I think generating the manifest jar in the same location as the argfile is OK.

I think this limits the changes to only builds where the java command would have failed already.  I think this should be done in a cross-cutting way so all forked Java executions take advantage of this change, but it's out of scope to try to fix this in the Scala/Groovy/Kotlin compilers (if they're forking java).
Here's another source to pull inspiration from: https://github.com/microsoft/vscode-java-debug/pull/532/files

Then here is what I propose as the next steps:

[ ] Detect when the JavaExec and javaexec would fail on each major operating system and provide a useful error message (from Gradle instead of coming from the OS).
[ ] For JDK 9+, when no argfile are already in use and the limit is attained, push only the classpath to an argfile if it would bring the command within the OS limit, else fail. We will leave the other argument on the command line at this stage given those may be more important for identifying the command.
[ ] For JDK 8-, use a pathing Jar if it would bring the command within the OS limit, else fail. This should provide the same behaviour as the previous step.
[ ] For JDK 9+ with an argfile already in use, use a pathing JAR only if it would bring the command within the OS limit, else fail.
[ ] (Optional, for optimization purpose) If the classpath is within environment variable OS limit and the CLASSPATH environment variable is not in use, pass the classpath via the environment variable.
[ ] (Optional, for exec with lots of args) If removing the classpath still doesn't bring the command line within the OS limit, we are using JDK 9+ and no argfile are used, push classpath and arguments to an argfile. This would be quite disruptive in term of observation of the process command line and should be used as a last resort.

@big-guy On OS where we don't know the limit, should we assume the most restrictive known limit?

Actually, I will scope the usage of the environment variable in and use that first before the pathing Jar, the side effect of the pathing Jar is quite troublesome for the users.

Recently, I started developing a new Grails web application using the newly released Grails 4.0.0, which depends on Gradle 5.1.1.
When I added the Elasticsearch 2.4.2 dependency, I ran into the issue:
Caused by: java.io.IOException: Cannot run program "C:\Program Files\Java\jdk1.8.0_74\bin\java.exe". CreateProcess error=206, File name too long.
I have searched and tried several workarounds offered by many, but all has failed so far, with Grails 4, Grade 5 and JDK 8 on Win10 (IntelliJ).
Is there a possible temporary workaround for the stack / environments that I am using, while we wait for this issue to get resolved?

A better error message detection will be provided for Windows in Gradle 6.0. We are rolling out command line shortening via CLASSPATH environment variable on Windows. The fixes will be localized only for Windows, please comment if you are seeing the same issue on Linux and macOS. Both of those OS have a really high limit so we see no need to address them in the near term.

Just want to ask, regarding this solution: is there a way to force the creation of the pathing jar? I find that I run into this problem when the %APP_HOME% environment variable in the Windows installDist start scripts expands to something long at run-time. So the class-path is short enough, but if someone copies the app to a folder with a long name, then tons of %APP_HOME%/lib/something.jars blow it up.

That is a very good point, we addressed the issue strictly for JavaExec and project.javaexec. We didn't change anything regarding the distribution plugin and the start script. Could you open an issue for that?

Tried Gradle V 6.0 and still facing this issue for the kotlin compiler in windows.
The absolute paths of the transformed JAR files are sent in the classpath.
2019-10-21T17:35:08.036+0530 [DEBUG] [org.gradle.api.Task] Using ':app:kaptGenerateStubsDebugKotlin' logger
2019-10-21T17:35:08.036+0530 [DEBUG] [org.gradle.api.Task] [KOTLIN] Kotlin compiler class: org.jetbrains.kotlin.cli.jvm.K2JVMCompiler
2019-10-21T17:35:08.037+0530 [DEBUG] [org.gradle.api.Task] [KOTLIN] Kotlin compiler classpath: C:\Users\Ranjith\.gradle\caches\modules-2\files-2.1\org.jetbrains.kotlin\kotlin-compiler-embeddable\1.3.41\6b1d4385d65894e07a0d14a5949f5417a408f0b7\kotlin-compiler-embeddable-1.3.41.jar, C:\Users\Ranjith\.gradle\caches\modules-2\files-2.1\org.jetbrains.kotlin\kotlin-reflect\1.3.41\8fb58b8954661de666e321478bf4178c18ce8018\kotlin-reflect-1.3.41.jar, C:\Users\Ranjith\.gradle\caches\modules-2\files-2.1\org.jetbrains.kotlin\kotlin-stdlib\1.3.41\e24bd38de28a326cce8b1f0d61e809e9a92dad6a\kotlin-stdlib-1.3.41.jar, C:\Users\Ranjith\.gradle\caches\modules-2\files-2.1\org.jetbrains.kotlin\kotlin-script-runtime\1.3.41\bcc3380041bbba171119c22d7024961b60da69e0\kotlin-script-runtime-1.3.41.jar, C:\Users\Ranjith\.gradle\caches\modules-2\files-2.1\org.jetbrains.intellij.deps\trove4j\1.0.20181211\216c2e14b070f334479d800987affe4054cd563f\trove4j-1.0.20181211.jar, C:\Users\Ranjith\.gradle\caches\modules-2\files-2.1\org.jetbrains.kotlin\kotlin-stdlib-common\1.3.41\2ecf4aa059427d7186312fd1736afedf7972e7f7\kotlin-stdlib-common-1.3.41.jar, C:\Users\Ranjith\.gradle\caches\modules-2\files-2.1\org.jetbrains\annotations\13.0\919f0dfe192fb4e063e7dacadee7f8bb9a2672a9\annotations-13.0.jar, C:\Program Files\Java\jdk1.8.0_201\lib\tools.jar
2019-10-21T17:35:08.038+0530 [DEBUG] [org.gradle.api.Task] [KOTLIN] Kotlin compiler args: -Xallow-no-source-files -classpath E:\official\work\product_root\product\scanlibrary\build\intermediates\compile_library_classes\debug\classes.jar;C:\Users\Ranjith\.gradle\caches\transforms-2\files-2.1\0f75e58d3f16ee100bc9ce124a00a7b3\jetified-signature-pad-1.2.1\jars\classes.jar;.....

This case seems to be related to the Kotlin compiler, I suggest you raise the issue with JetBrains to they use ExecOperations service to work around the issue, if the compiler is a Java process. In the event where it wouldn't be a Java process, they would have to handle this case by themselves.

Just want to ask, regarding this solution: is there a way to force the creation of the pathing jar? I find that I run into this problem when the %APP_HOME% environment variable in the Windows installDist start scripts expands to something long at run-time. So the class-path is short enough, but if someone copies the app to a folder with a long name, then tons of %APP_HOME%/lib/something.jars blow it up.

@arihunta, see https://github.com/gradle/gradle/issues/1989#issuecomment-550192866 for a work-around that does not require a pathing JAR.

That is a very good point, we addressed the issue strictly for JavaExec and project.javaexec. We didn't change anything regarding the distribution plugin and the start script. Could you open an issue for that?

@lacasseio isn't that already tracked as part of https://github.com/gradle/gradle/issues/1989?

My workaround is to create an argument file:

            def argFile = getTemporaryDir().createTempFile("gradle-test-arg-file", "")
            argFile.withWriter{ out ->
                testArgs.each {out.println it}
            }

            jvmArgs =<EMAIL_ADDRESS>            classpath = files()


fix compile error for Spark 3.2.0 and 3.2.1

Which issue does this PR close?

Closes #601
What changes are included in this PR?

JvmArg -Dspark.version=${sparkVersion} was added into scala-maven-plugin,
and some compilation condition were added to avoid compilation error.
mvn clean package -DskipTests -Prelease -Pspark-3.2 -DsparkVersion=3.2.0
mvn clean package -DskipTests -Prelease -Pspark-3.2 -DsparkVersion=3.2.1

Are there any user-facing changes?

No

could we have a solution without specifying the spark minor version?

could we have a solution without specifying the spark minor version?

Yes, I have updated this pr according to https://github.com/kwai/blaze/issues/601#issuecomment-2404368125 .

@XorSum, could you add test case for this compatibility bugfix?

@XorSum, could you add test case for this compatibility bugfix?

i advise we add a CI workflow to check whether the modified code works on all minor versions. but currently the CI workflow is running too slow. we should fix it in another issue.


Remove ss.options._centralized

Interesting for academic purposes, but shouldn't really be needed any more and would simplify parts of the code.

Or reimplement to be more user-friendly if big performance benefit

Need to do the performance evaluation, and likely investigate an intermediate option that uses separate streams but not slotting.


r plot history multiselect support

Please briefly describe what you were doing that led to the issue, if applicable:
I find ability to scrub specific plots from r plot history view [ of "ide" graphics device ] very helpful as opposed to entering the dev.off() command in r interactive window approach that drops everything. Currently r plot history view doesn't support range multiselect, using shift+click, and arbitrary set selection, using ctrl+click, gestures for selecting set of plots to delete in one step. No idea whether enabling that involves use of some boiler plate UI code or complex view pane specific addition. Either way if others also feel it would be a nice addition to variable explorer interactions then perhaps worth considering.
If you have any screenshots demonstrating the issue, please include them as well to help us diagnose it better.
Additional information:
OS Information
Version:       Microsoft Windows NT 10.0.15063.0
RTVS Information:
Assembly: Microsoft.VisualStudio.R.Package, Version=1.1.30523.1233, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a
Active R URI:
R 3.3.2: C:\Program Files\R\R-3.3.2

https://github.com/Microsoft/RTVS/commit/85238e4dd8a124f39674a19a60075d7b10da00bc

thanks, look forward to trying this out when next update is pushed with this change in it.


That can be another PR right?


Settings: AddOrUpdateValue always returns true (Android)

Bug
Version Number of Plugin: 2.1.0
Device Tested On:
Simulator Tested On: Nexus 4 (KitKat)
Expected Behavior
Should only return true if the setting value was added or was actually different than the previous value
Actual Behavior
Always returns true
Steps to reproduce the Behavior
update a settings value that already exists and observe the return value of AddOrUpdate.

It does not evaluate a change in the value, only if successful.


chore: add deployer name for AW testnets

chore: add deployer name for AW testnets
did a pass on all chains, seems only recent testnets were affected

should this be required by CI?

we disabled it originally because throwing up metadata-only PRs without addresses is valid, and we wouldn't want to force a deployer to be defined for that
could probs update the test to only check if there's a mailbox set

merging to get a patch release out to update docs


Web- Room - Hitting enter on create room generates space on the composer

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to staging dot on web chrome
Click on + icon . Click on new room
3.Type a room name and fill every details
Now hit enter to create a room and notice that extra line of space is seen on the composer
While hitting enter, only a room should have been created. But it also generates a line of extra space on the composer

Expected Result:
Hitting enter on create room should not generate space on the composer
Actual Result:
Hitting enter on create room generates space on the composer
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: yes
Reproducible in production?: yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/f78decaa-405a-4ead-96fc-8532ba37b1c2
https://github.com/Expensify/App/assets/93399543/bd51a443-e40a-4355-9131-a6b958d57c06
Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685526899395409
View all open jobs on GitHub

I think this is the dupe of this issue.

Yes, missed this duplicate

Due to dupe and this comment https://github.com/Expensify/App/issues/19771#issuecomment-1569396127, closing


perf: parallel search partitions in subindex

V1 baseline
Running query with nprobes: 1, refine_factor: 0
Time: 652.877µs

Running query with nprobes: 10, refine_factor: 0
Time: 818.418µs

Running query with nprobes: 50, refine_factor: 0
Time: 1.406433ms

Running query with nprobes: 100, refine_factor: 0
Time: 1.747243ms

Running query with nprobes: 512, refine_factor: 0
Time: 5.754752ms

V3 after fix
Running query with nprobes: 1, refine_factor: 0
Time: 667.621µs

Running query with nprobes: 10, refine_factor: 0
Time: 707.589µs

Running query with nprobes: 50, refine_factor: 0
Time: 1.213155ms

Running query with nprobes: 100, refine_factor: 0
Time: 1.559892ms

Running query with nprobes: 512, refine_factor: 0
Time: 5.597119ms

cc: @erikml-db @ankitvij-db

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.61%. Comparing base (8cf899b) to head (ffbf547).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3060      +/-   ##
==========================================
+ Coverage   77.57%   77.61%   +0.03%
==========================================
  Files         240      240
  Lines       78636    78639       +3
  Branches    78636    78639       +3
==========================================
+ Hits        61001    61032      +31
- Misses      14495    14497       +2
+ Partials     3140     3110      -30

Flag
Coverage Δ

unittests
77.61% <100.00%> (+0.03%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


8540: Support Tagging Participant and Time Point Columns in Sample Types

Rationale
Bump @labkey/components version, which will allow for ‘VisitDate’ and ‘VisitID’ Data Types on domain fields for Sample Types. This will support the larger integration of Sample Types with Study.
Related Pull Requests

https://github.com/LabKey/labkey-ui-components/pull/460
https://github.com/LabKey/biologics/pull/811
https://github.com/LabKey/sampleManagement/pull/502

Changes

Bump @labkey/components version

Note that the version bump in List is purely so it's possible to verify that the two new dropdown options don't exist in a non-sampleType domain, with the new package.
@cnathe Is it good style to do a version bump in all places the Designers surface (the set of package.jsons touched in the previous Field Editor PRs)?

Note that the version bump in List is purely so it's possible to verify that the two new dropdown options don't exist in a non-sampleType domain, with the new package.
@cnathe Is it good style to do a version bump in all places the Designers surface (the set of package.jsons touched in the previous Field Editor PRs)?

Yes, in all most all cases for develop when we bump the components package version in platform, we will want to bump it for all 7 of the modules within platform that use it. The main case where we often will bump only specific platform modules is for a patch fix to a release branch where the fix is only needed (or only applies) in a subset of modules.


pre-commit: check more file types for trailing whitespace

Description
This PR checks more file types for unneeded trailing whitespace.
Trailing whitespace is just extra data that we don't need.
This hook when run locally will automatically trim the trailing whitespace.

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[X] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI
[ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

How did you try to break this feature and the system with this change?

@blueorangutan package

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 10297