Add switch to choose listkeys or fold_objects in storage calclation

Cleaner version of https://github.com/basho/riak_cs/compare/ku-optimize-storage-calc . Maybe the default value can be true as it doesn't affect performance.
Eshell V5.10.3  (abort with ^G)
(riak-cs@<IP_ADDRESS>)1> timer:tc(fun() -> riak_cs_storage:sum_bucket(<<"junk">>) end).
{2771516,
 {struct,[{<<"Objects">>,58457},{<<"Bytes">>,2784575686}]}}
(riak-cs@<IP_ADDRESS>)2> application:set_env(riak_cs, use_2i_for_storage_calc, true).
ok
(riak-cs@<IP_ADDRESS>)3> timer:tc(fun() -> riak_cs_storage:sum_bucket(<<"junk">>) end).
{2756002,
 {struct,[{<<"Objects">>,58457},{<<"Bytes">>,2784575686}]}}

This experiment was with vanilla Riak - so it doesn't yet have improvement. This needs another optimization like https://github.com/basho/riak_kv/compare/2.0...ku-optimize-mapred-listkeys .

https://github.com/basho/riak_kv/pull/1072 was merged but this won't be released as 2.0.x as 2.0.6 won't be out any more.
[posted via JIRA by Kota Uenishi]

Rebased version (#1089) supersedes.

CS 2.1.0 will be based on Riak 2.1.
[posted via JIRA by Kota Uenishi]

Release note: a MapReduce optimisation in fetching Riak objects was introduced in Riak 2.1 and Riak CS 2.1 has introduced an option to use that optimisation in storage calculation. It can be used by turning on use_2i_for_storage_calc as true in advanced.config. It is also off by default. This reduced 50% of I/O in leveldb.
[posted via JIRA by Kota Uenishi]


CNV-39793: Refactor disk modal dialog

📝 Description
Refactor includes:

Unify DiskModal and EditDiskModal to use the same component. (New component is still names DiskModal)
remove all state and relevant boilerplate code and use react-hook-form
Re-structure of file hierarchy and locations.

TODO in next PR:

Redesign disk source dropdown according to this UX document

please add jira ticket

/lgtm


Implement Error Injection in the NOCSR Request Command

Problem
Need an error injection mechanism to support negative testing of NOCSR Request Command.
Specifically, some test cases are described in TC-DA-1.4,TC-DA-1.6 but not limited to:

Invalid NOCSR Information
CSR is not of the type OCTET string
CSRNonce is OCTET string of length > 32
NOCSRElement size is greater than RESP_MAX
AttestationSignature is not an octet string

Proposed Solution
Add error injection logic in the SDK

@emargolis how were you intending to inject these errors from a YAML standpoint?


Bump nlu ontology

Description:

bump snips-nlu-ontology to 0.62.0

Codecov Report

Merging #705 into develop will decrease coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #705      +/-   ##
===========================================
- Coverage    88.88%   88.85%   -0.03%
===========================================
  Files           65       65
  Lines         3777     3777
  Branches       709      709
===========================================
- Hits          3357     3356       -1
  Misses         313      313
- Partials       107      108       +1


[tokenomics] Estimator for non-linear operations

No linear operations, particularly Move calls are not easy to estimate because they require
This can be attempted in multiple ways:

Flat cost: we return a fixed number regardless of the function being called
Execution-based cost: here we actually run the function and observe the gas used

We have chosen to go with a variant of version 1 for simplicity for now

Will use https://github.com/MystenLabs/sui/issues/4967


closes #953: make SyntaxHighlighter test independent from highlight.js version

Thank you for opening a pull request and contributing to AsciidoctorJ!
Please take a bit of time giving some details about your pull request:
Kind of change

[ ] Bug fix
[ ] New non-breaking feature
[ ] New breaking feature
[ ] Documentation update
[x] Build improvement

Description
What is the goal of this pull request?
Fix https://github.com/asciidoctor/asciidoctorj/issues/953 by making the test do not depend on Asciidoctor highlight.js version.
How does it achieve that?
Test each file against the version used in each SyntaxHighlighterAdapter, and then test against real Asciidoctor but striping the version numbers,
Are there any alternative ways to implement this?
Maybe test don't need to match agains a real Asciidoctor conversion?
Are there any implications of this pull request? Anything a user must know?
No.
Issue
If this PR fixes an open issue, please add a line of the form:
Fixes #Issue
Release notes
Please add a corresponding entry to the file CHANGELOG.adoc

Thank you! 🎉


[WIP] Update to EAC contracts 1.0.0-beta-4

Opening this, to watch the comparison state between both branches

Pull Request Test Coverage Report for Build 1084

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 77.134%

Totals

Change from base Build 1069:
0.4%

Covered Lines:
509

Relevant Lines:
625

💛  - Coveralls


MDBottomNavigation miss-arrangement

Description of the Bug
each time i use MDBottomNavigation widget within a Screen it stacks it self to the right. If i expand the window a little bit, it goes back to normal and it does the same thing when i compile it into an apk.
Moreover, the ScreenManager is my root widget and the Screen widget is a child of ScreenManager
Screenshots

here is the run of the code..

here is the code
Add images to explain us this bug. Paste urls here.
Remove this section if no images here
Versions

OS: Linux
Python: 3.7
Kivy:
KivyMD:

@kengoon Duplicate - https://github.com/HeaTTheatR/KivyMD/issues/271


Crash when running most games inside gamescope

I'm using the GE-Proton version of the AppImage (continuous build from commit 7ee1fce)
I'm trying to run a game inside gamescope with the following command:
env WINEPREFIX="/var/mnt/Games/ROMs/windows/wine" gamescope -f -- "../wine-staging_ge-proton.AppImage" "./Sonic and the Fallen Star.exe"
Which fails with the following messages in the console:

ATTENTION: default value of option vk_khr_present_wait overridden by environment.
ATTENTION: default value of option vk_khr_present_wait overridden by environment.
ATTENTION: default value of option vk_khr_present_wait overridden by environment.
ATTENTION: default value of option vk_khr_present_wait overridden by environment.
ATTENTION: default value of option vk_khr_present_wait overridden by environment.
ATTENTION: default value of option vk_khr_present_wait overridden by environment.
ATTENTION: default value of option vk_khr_present_wait overridden by environment.
ATTENTION: default value of option vk_khr_present_wait overridden by environment.
ATTENTION: default value of option vk_khr_present_wait overridden by environment.
ATTENTION: default value of option vk_khr_present_wait overridden by environment.
ATTENTION: default value of option vk_khr_present_wait overridden by environment.
ATTENTION: default value of option vk_khr_present_wait overridden by environment.
ATTENTION: default value of option vk_khr_present_wait overridden by environment.
ATTENTION: default value of option vk_khr_present_wait overridden by environment.
ATTENTION: default value of option vk_khr_present_wait overridden by environment.
../subprojects/vkroots/vkroots.h:16579: void vkroots::tables::CreateDispatchTable(PFN_vkGetInstanceProcAddr, PFN_GetPhysicalDeviceProcAddr, VkInstance): Assertion `res == VK_SUCCESS' failed.
0548:err:seh:NtRaiseException Exception frame is not in stack limits => unable to dispatch exception.
gamescope: children shut down!
gamescope: ../src/backend.cpp:60: virtual gamescope::CBaseBackendFb::~CBaseBackendFb(): Assertion `!HasLiveReferences()' failed.
(EE) failed to read Wayland events: Broken pipe
./Sonic and the Fallen Star.sh: line 6: 42584 Aborted                 (core dumped) env WINEPREFIX="/var/mnt/Games/ROMs/windows/wine" gamescope -f -- "../wine-staging_ge-proton.AppImage" "./Sonic and the Fallen Star.exe"

This happens with most games I've tried, but not all (I haven't been able to identify a common factor). The same games work fine doing this with either system wine or bottles-cli, but trying to accomplish this with the Wine AppImage consistently leads to a crash.
Only issue I've had so far with these AppImages, so I hope it can eventually be resolved! More than happy to respond to questions or help with debugging.
EDIT: This issue seems absent in the base wine-staging AppImage, so it's probably exclusive to the GE-Proton one.

Thing is wine-ge-custom not updated anymore from GE since feb so it is missing lot of fixes.


A sprite that changes image when an arrow is pressed

Describe your problem here.
I'm trying to create a script that detects when an arrow is pressed a sprite changes to the image corresponding to the color of the arrow, but each light sprite is separated into png's (like the cassette girl light), does anyone know a script that can do this?
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No response

Maybe try editing the change character on key press thing from the wiki and maybe try to change the character names to the bg image names
https://github.com/ShadowMario/FNF-PsychEngine/wiki/Lua-Script-API
https://cdn.discordapp.com/attachments/866856727621795850/880169101891342366/ChangeCharacterScript.lua
It may not work but its worth a shot

If you mean when you press a note then:

Make the sprites' filename end with 1, 2, 3, 4, example: spriteName1, spriteName2, spriteName3, spriteName4
For the image to appear, put the last numbers in the file name based on this:
1 = Left Arrow | 2 = Down Arrow | 3 = Up Arrow | 4 = Right Arrow

--4 is the sprites for each direction. if you want more sprites change 4 to other value.
--change SpriteFile to the sprites name, without the last number
--change X, Y, object camera, and other things as you like.

local definedSpr = 0

function onCreate()
     for i=1,4 do
          makeLuaSprite('spriteName'..i, 'spriteName'..i, 0, 0)
          setObjectCamera('spriteName'..i, 'other') --for showing over the hud
          addLuaSprite('spriteName'..i)
          setProperty('spriteName'..i..'.alpha', 0)
     end
end

function goodNoteHit(id, direction, noteType, isSustainNote)
         if not isSustainNote then
             definedSpr = (direction + 1)
             setProperty('spriteName'..definedSpr..'.alpha', 1)
             doTweenAlpha('fadeAway'..definedSpr, 'spriteName'..definedSpr, 0, 0.5, "linear") --remove this if you don't want it to fade away
         end
end

It worked! Thank you!


Error: Expected property "1" of type Satoshi, got Number<PHONE_NUMBER>0000000

Hi all,
I am trying to get Fabcoin supported by Z-nomp, after I  did 'npm start', got this error
Error: Expected property "1" of type Satoshi, got Number<PHONE_NUMBER>0000000
Seems something wrong with 'blockReward' at line 26 of 'blockTemplate.js' in startum-pool.
After days research, still have no clue how to fix it. I set the blockReward to a smaller number, such as '25 * 100000000', no error reported at the pool side, but the block seems got rejected. Below is what in the coin daemon debug:
2018-07-15 15:47:28 CreateNewBlock(): nHeight=123174 total size: 664 block weight: 2548 txs: 1 fees: 3155 sigops 408
2018-07-15 15:47:39 ERROR: AcceptBlockHeader: Consensus::ContextualCheckBlockHeader: 00000000c36e644ee0cdbf9e7c83aab078bed889c2283ff6e56036ec00d382a3, bad-height, incorrect block height (code 16)
2018-07-15 15:47:39 ERROR: ProcessNewBlock: AcceptBlock FAILED
Any idea how to set the blockReward? Thanks.

fixed

@rlinxy  Did you solved the problem ? I met the same problem.

@rlinxy Fabcoin. I set rpcData.miner to 25 , pool run success. But the log show : Share rejected:"error":"job not found".  Do other files need to be modified? Cloud you give me your pool_configs files ?


heretic changes part 4

About the PR

apparently you only pick 3 out of 5 targets so i made the check a bit more forgiving
also made heretig blades go shonk :goberserk:
no cl

what is this test fail !?!?

fair play editing my comment.... fair play....


Reproject output to EPSG:4326 by default.

I really love shp2json (and avoiding the massive dependency that is GDAL), but the fact it doesn't support reprojection is often a pain. (Particularly when you write a script that assumes that all your shapefiles will be EPSG:4326, then one arrives in a different projection and now you have to switch to OGR2OGR or something.)
Mike addressed the issue, saying " This is just a Shapefile parser, so it wouldn’t be the right place to implement coordinate system transformations."
I would like to argue against this :)
First, it's not just a Shapefile parser. shp2json is clearly a Shapefile->Geojson converter. And currently, it's producing GeoJSON that doesn't comply with the RFC. If a library or tool is producing GeoJSON as output, it should produce that GeoJSON in EPSG:4326  by default (and maybe allow retaining the original projection with some special flag).
Secondly, it definitely seems like the job of this library to parse the .prj file if there is one, at least.
Sure, it's possible to use workarounds to get around this limitation, but they're not convenient, particularly when you're dealing with a Shapefile whose projection you don't know ahead of time. That makes this kind of command line hard to write:
shp2json foo.shp | reproject --to=EPSG:4326 --from=...what?

(Supporting reprojection to arbitrary CRS's would definitely be beyond the scope of the library, otoh.)

I’m not adding reprojection to this library. That would be a significant undertaking and I want this library to be small. Sorry!


count distinct reference.md

adding reference to Count distinct

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

adding distinct

Thanks for contributing @MUSSONT, could you elaborate a little about what count distinct is? Or maybe provide an example how to use it?

Thank you for your contribution.  At this time we have decided not to merge your pull request.  We welcome future pull requests from you.
Reason: Please provide additional information if introducing new concepts/commands in a guide.  If you would like to update your PR, please let me know and I can reopen this request; otherwise, feel free to open a new PR.
Happy Coding!


[SPARK-21680][ML][MLLIB]optimzie Vector coompress

What changes were proposed in this pull request?
When use Vector.compressed to change a Vector to SparseVector, the performance is very low comparing with Vector.toSparse.
This is because you have to scan the value three times using Vector.compressed, but you just need two times when use Vector.toSparse.
When the length of the vector is large, there is significant performance difference between this two method.
How was this patch tested?
The existing UT

Test build #80473 has started for PR 18899 at commit 5dc5c89.

Test build #80473 has finished for PR 18899 at commit 5dc5c89.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80473/
Test PASSed.

This isn't what was proposed in the JIRA?

Yes, I just concern if add toSparse(size) we should check the size in the code, there will be no performance gain. If we don't need to check the "size" (comparing size with numNonZero) in the code, add toSparse(size) is ok.
Thanks.

Check what? you're just saving the extra call to numNonZeroes. Change the declaration like so:
  def toSparse: SparseVector = toSparse(numNonzeros)

  private[linalg] def toSparse(nnz: Int): SparseVector

Then make the implementations override the new private method and use the given nnz arg, and change compressed to pass the nnz value it has already computed.

Thanks @srowen.

The user can't call toSparse(nnz). It will be private.

Test build #80485 has started for PR 18899 at commit cebe600.

Test build #80485 has finished for PR 18899 at commit cebe600.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80485/
Test FAILed.

Test build #80487 has started for PR 18899 at commit d4f9e51.

Test build #80487 has finished for PR 18899 at commit d4f9e51.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80487/
Test PASSed.

First suggestion is that there must be unit tests :)

This approach doesn't feel right to me. The goal of the change is to avoid making a pass over the values to find out if there are any explicit zeros that need to be eliminated, which is fine. Instead of allowing the user to specify how man non-zero elements there are, we should instead allow them to specify a Boolean value on whether or not we should bother removing explicit zeros. Here's a small example to demonstrate why:
val v = Vectors.dense(1, 2, 3)
val sv = v.toSparse(2)

This raises a java.lang.ArrayIndexOutOfBoundsException. Since I incorrectly specified the number of non-zero elements. If instead we use the boolean like removeExplicitZeros then when that is false we can just make the values array the size of the dense values in the dense case, and just return this` in the Sparse case. So I'm suggesting a method like:
def toSparse(removeExplicitZeros: Boolean): SparseVector

That won't work anyway because of ambiguous reference compile errors (another reason unit tests are so important). I ran into that problem before, and never found a good solution, and so you'll have to come up with a way around that.

Btw, I think the compile error is because v.toSparse(2) could resolve to either v.toSparse(nnz = 2) OR v.toSparse.apply(2).

The new method is private. Certainly the user is not intended to call it and supply nnz. This change shouldn't alter any semantics or functionality. It's just trying to avoid calculating nnz twice: to figure out if the vector is sparse, and then to convert it to sparse.

Ok, yes, I see it now. Though, the point remains but to a lesser degree. We still have a method, albeit private, that indexes the array at potentially unsafe locations. It's probably ok, but at the very least we need a unit test to document the behavior.

Test build #80517 has started for PR 18899 at commit 4404b10.

Hi @sethah , the unit test is added.  Thanks

Test build #80517 has finished for PR 18899 at commit 4404b10.

This patch fails PySpark pip packaging tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80517/
Test FAILed.

Merged build finished. Test FAILed.

retest this please

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80523/
Test FAILed.

retest this please

In theory there's no new functionality here so nothing new to test, but more tests never hurt.
This seems OK. Is there any other call site where nnz is already known?
It is a nontrivial bit of change though. How much does this speed things up, do you have any benchmark, for the record?

For PR-18904, before this change, one iteration is about 58s, after this change, one iteration is about:40s

Hi @srowen; how about using our first version? though duplicate some code, but change is small.

No, duplicate code like that is bad.

@mpjlu sorry which benchmark are you referring to? PR 18904 doesn't seem to benchmark just this in isolation. I just want to be sure the gain is significant

I did not only test this PR. Only work for PR 18904 and find this performance difference.

Test build #80529 has started for PR 18899 at commit 4404b10.

I think there is new functionality, a new method that needs its functionality defined. One specific example, we need a test like:
  test("toSparseWithSize") {
    val dv = Vectors.dense(1, 2, 3)
    withClue("toSparseWithSize fails on the wrong number of non-zeros") {
      intercept[java.lang.ArrayIndexOutOfBoundsException] {
        dv.toSparseWithSize(2)
      }
    }
  }

This is evidence to future developers that the potential failure of this method is known and intended.  Also, we need a test for when we specify it incorrectly the other way. i.e. what is the expected outcome of:
val dv = Vectors.dense(1, 2, 3)
val sv = dv.toSparseWithSize(6)

Right now, I get the error java.lang.IllegalArgumentException: requirement failed: You provided 6 indices and values, which exceeds the specified vector size 3. These behaviors are undesirable IMO, but should at least be tested.
I don't believe there's any way to find a better solution without at least adding an O(nnz) operation. Honestly, some more specific performance results would be great to have here.

This isn't a public method though. The dv.toSparseWithSize(2) error will never come up unless Spark causes it, and there's no contract for its behavior in that case. It's probably over-specifying things to require it to throw AIOOBE, for example; nothing depends on that nor should.
It doesn't hurt to unit test though and the additional test seems fine.

Ok, it's fairly safe since it's limited to private[linalg]. The confusion for me is that this method introduces all sorts of edge cases which have behavior that is not at all obvious or clear. If we don't think we need to test all of these edge cases, I'd like to at least be very explicit in the method doc, e.g.:
  /**
   * This method is used to avoid re-computing the number of non-zero elements when it is
   * already known. This method should only be called after computing the number of non-zero
   * elements via [[numNonZeros]]. e.g.
   *   {{{
   *     val nnz = this.numNonZeros
   *     val sv = toSparse(nnz)
   *   }}}
   *
   * If `nnz` is under-specified, a [[java.lang.ArrayIndexOutOfBoundsException]] is thrown.
   */

Test build #80529 has finished for PR 18899 at commit 4404b10.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80529/
Test PASSed.

OK maybe include some of this text in the scaladoc for it, to make it clear it is always intended to be called with the value of numNonZeroes.

Thanks @sethah @srowen . The comment is added.

Test build #80600 has started for PR 18899 at commit d50de99.

Test build #80600 has finished for PR 18899 at commit d50de99.

This patch fails to generate documentation.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80600/
Test FAILed.

Test build #80602 has started for PR 18899 at commit 83ac893.

Test build #80602 has finished for PR 18899 at commit 83ac893.

This patch fails to generate documentation.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80602/
Test FAILed.

Test build #80606 has started for PR 18899 at commit 7ab264d.

Test build #80606 has finished for PR 18899 at commit 7ab264d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80606/
Test PASSed.

Merged build finished. Test PASSed.

I have tested the performance of toSparse and toSparseWithSize separately.  There is about 35% performance improvement for this change.

merged to master


When high load on API server: confirm screen stays open while transaction is already broadcast

First the confirm screen shows with a faded confirm button but does not close as usually.

After minutes an error appears in the confirm screen but the transaction is broadcast normally and visible in the "activities" tab of the web extension:

This gives the idea to the user that the transaction failed. Another error when displayed usually also does send the transaction:

Causing the user to send the transaction again (possibly with the same nonce).

This is related to #1991
I think these issues are causing transactions to be broadcasted with the same nonce.
Which in turn causes this, a mempool that looks rather full, with a relatively high number of transactions that cant be mined:

Sometimes the error thrown is different but the effect is the same: The transaction is still send to the mempool as intended.


HLG read_gbq WIP (test_read_gbq failing)

Attempt to implement HLG for read_gbq when partition_field=None still having problems due to the format of the function bigquery_arrow_read but I'm not sure how to solve it.
Currently, this implementation fails when running the test_read_gbq with the following error:
FAILED test_core.py::test_read_gbq - NotImplementedError: Please specify either `partition_field` or `stream_name`.

I also tried specifying partition_field=None when creating the layer, like
layer = DataFrameIOLayer(
                output_name,
                meta.columns,
                [stream.name for stream in session.streams],
                bigquery_arrow_read(
                    make_create_read_session_request=make_create_read_session_request,
                    project_id=project_id,
                    timeout=read_timeout,
                    partition_field=None,
                ),
                label=label,
            )

but this still gives
FAILED test_core.py::test_read_gbq - NotImplementedError: Please specify either `partition_field` or `stream_name`.

cc: @jrbourbeau @bnaul @mrocklin for visibility

Thank you @jrbourbeau for the tweaks, I took this for a spin and things work. I read a copy of the table bigquery-public-data.covid19_public_forecasts.county_14d which for reference has 132888 rows × 20 columns and is a partitioned table on BigQuery.
ddf = read_gbq(
        project_id="dask-bigquery",
        dataset_id="covid19_public_forecasts",
        table_id="county_14d",
    )

%%time
ddf.compute()

CPU times: user 641 ms, sys: 90.1 ms, total: 731 ms
Wall time: 5.86 s

The task stream looks like:

I tried also experimented with partitions and partition_fields and this works, but is a bit slower for the case I was trying, compared to reading the whole data set. For example:
partitions = ["Teton", "Loudoun"]

ddf = read_gbq(
        project_id="dask-bigquery",
        dataset_id="covid19_public_forecasts",
        table_id="county_14d",
        partition_field="county_name",
        partitions=partitions,
        fields=[],
    )

%%time
ddf.compute()

CPU times: user 1.11 s, sys: 102 ms, total: 1.22 s
Wall time: 10.5 s

Which has only two partitions (one per county_name passed in partitions)
>>> ddf.map_partitions(len).compute()
0     42
1    126
dtype: int64

and results in this dataframe when computed.

Which has as index the entries passed in partitions, I'm not sure this the is a behavior we want. I'd be curious what @bnaul had in mind with this approach.
One last thing I tested was using  partitions, partition_fields and fields with data that pushed with pandas, and this functionality works too, what makes me think that we can modify the test_read_gbq_partitioning to use data that we pushed with pandas and not rely on a copy of a public dataset. But we might want to wait for this until we decide if the behavior shown in the dataframe screenshot is what we are looking for.


Added Food Recipe App React Project

Closes:  #801

Title: Food Recipe Website
Name: Diksha Jain
Idenitfy yourself: GSSOC-EXT , Hacktoberfest

Describe the add-ons or changes you've made 📃
Screenshots 📷

Type of change ☑

What sort of change have you made:

[X] New feature (non-breaking change which adds functionality)

Checklist: ☑

[X] My code follows the Contributing Guidelines & Code of Conduct of this project.
[X] This PR does not contain plagiarized content.
[X] I have performed a self-review of my own code.
[X] I have commented my code, particularly wherever it was hard to understand.
[X] My changes generate no new warnings.

Note to reviewers 📄

Done, I have enlisted the project in the React-JS project readme file


A decent tutorial?

At the risk of sounding stupid, how do I use this? I'm running Arch linux build 231, updated regularly, and have satisfied the dependencies. Thinking I would have need for more than one instance I created a directory named "sandbox" in my home directory, and inside that another directory named "h265" after the video codec I'll be using.
Following the example I entered "pacstrap -cd h265" in terminal (open in sandbox, of course) and received a notice that pacstrap was not installed.
I'm obviously in over my head here. Can anyone direct me to a comprehensive tutorial? I'm sure you're probably too busy to hold my hand on this.

@emotionally-exhausted FWIW, pacstrap is supplied by the extra/arch-install-scripts package so you should install that.


[vm] fix gas metering of Bytecode::LdFalse

Motivation
Fix gas metering of Bytecode::LdFalse
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
cargo xtest
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/libra/website, and link to your PR here.)

Looks good to me. Thanks for the PR!
@bors-libra r=tzakian

:pushpin: Commit 22ffcab has been approved by tzakian

:hourglass: Testing commit 22ffcabe63c46406107f99020c15da2f5fba2a92 with merge 902294e4a61aa552fa3599f3702fe4c285c15f9c...

:broken_heart: Test failed - checks-circle_commit_workflow

:hourglass: Testing commit 22ffcabe63c46406107f99020c15da2f5fba2a92 with merge f2ae4613d8d4f962a04243a813c9a382ade3a3e3...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: tzakian
Pushing f2ae4613d8d4f962a04243a813c9a382ade3a3e3 to master...


Unavailable in HACS

Hello,
This add-on looks very nice. I would love to get it but it does not appear when I am trying to add it from HACS.
Am I doing something wrong?

I was not aware that I need to install HACS first.
Installing HACS as described on hacs.xyz  solved the issue.


Stack check

Fix #2156
when generic context coroutines are used, the stack_remaining number reported in the threads API is wrong. Here's a fix, plus a check that when recursively calling a function the stack space decreases as we go deeper.
Note. when I run this test, it hangs on exit. Not sure why.

LGTM

Looks good to me except for the missing license, but inspect will tell you anyways ;) Thanks!

OK. fixed the inspect checks. Hope it passes cleanly now.


Organelles

Description of feature
Should be one complete allele?

Where is this information saved?

GRIT should know that. Otherwise, I'd expect it's in the assembly report I get from the NCBI: it distinguishes the nuclear genome from the mitochondrial genome, and I expect the other organelles will be listed as well


take method ordering in sort-comp as an option

Also simplifies the logic. I originally based it off https://github.com/yannickcr/eslint-plugin-react/blob/master/lib/rules/sort-comp.js, but it doesn't need to be nearly as complex because it doesn't have to give useful error output.

this is awesome! Thank you so much :)


Removed globals and added configuration options

You can now configure if sequelize should be exposed globally. By default this is set to default.
To disable:
config/globals.js add sequelize: false
It also respects the globals configuration for models.
I had to remove the ENUM column in the test fixture model UserGroup.

I have no idea why the test is failing on travis. The test is green locally:

The tests are failed because it search Sequalize globally and can't find:
https://travis-ci.org/festo/sails-hook-sequelize/builds/85950018
Not all of your cahnges are approved by me, but I can understand the importance of global and not global part ... but untill the test are failed, I won't merge this request.

The problem was that i tried to require 'Sequelize' instead of lowercased 'sequelize' module. So now it should be fine to merge that.
I also added some npm run scripts to initialize the needed postgres user and database for the tests. You can now run npm run db:init. This will create a local postgres datadir and start the postgres server. This way it is easier to develop and contribute :)

Can i do something to help you to merge this?

Why this is still not landed?

Any progress on the PR?

@festo, ping

Hi @thomasfr and all! I think it's a good idea! Can you sync your codebase with last changes and update PR?
By the way, I took on the role of a maintainer, so don't let the project die! :)

Also, it would be cool, if you update docs with examples of new possible configuration!

Hi @thomasfr! I've implemented this sort of feature a little bit differently. Feel free to check, test, comment and edit! :)


Nagle's algorithm adds 40ms delay to trace_processor_shell queries on old Linux kernels

Using the local trace_processor_shell binary on an old Linux distribution like CentOS 7 results in very slow loading since many queries are performed in serial and each takes ~40ms rather than <1ms. This is the classic 40ms bug which affects older Linux kernels.
I've confirmed locally that setting the TCP_NODELAY socket option fixes this, although I did it in a hacky way for testing rather than putting it properly in the base socket abstraction.
I'm not sure which kernel version fixed the issue and if there's any Linux distributions supported by Perfetto that are affected by this. In order to build Perfetto on CentOS 7 I had to do some tinkering with the hermetic builds to create/find versions which didn't used GLIBC 2.18 which is too new for CentOS 7.

Thanks a lot fo the report.
Just to confirm does it go away just by adding TCP_NODELAY to the listening socket in trace_processor_shell?

@trishume  can you try  https://android-review.googlesource.com/c/platform/external/perfetto/+/1492639 and confirm it fixes for you?

Thanks! I haven't had a chance to test out your exact commit yet but that looks very similar to the working code I used so I suspect it does. I used SOL_TCP but a cursory internet search suggests IPPROTO_TCP does the same thing and is maybe the more correct one.


Changing state to prevState

In the second form of setState() that accepts a function, the first argument to the function is the previous state. In the code example though, it is called state which is counter intuitive to beginners. function(prevState, props) makes more sense IMHO.
I'm new by the way and don't know your rules and conventions. I apologize in advance if I should have proceeded differently.

This hasn't turned out to be a problem in practice. Thank you for your PR!


AuthenticationService doesn't implement hashCode/equals

Describe the bug
To me it looks like as if the authentication service is missing an implementation to hashCode/equals, but the change validation makes use of equals:
https://github.com/EnMasseProject/enmasse/blob/18948435b1be1defed135697bdecec6943c918d4/api-server/src/main/java/io/enmasse/api/v1/http/HttpAddressSpaceService.java#L180
https://github.com/EnMasseProject/enmasse/blob/18948435b1be1defed135697bdecec6943c918d4/address-model-lib/src/main/java/io/enmasse/address/model/AuthenticationService.java#L15-L53

This makes it impossible to update the resource:
Error from server (Bad Request): error when replacing "/tmp/oc-edit-t91r3.yaml": Cannot change authentication service of address space default from io.enmasse.address.model.AuthenticationService@7724473f to io.enmasse.address.model.AuthenticationService@3ff0dc56

PR merged


drilldown bug

First of all thanks a lot for this react lib.
Unfortunately, I encountered a bug, which didn't let me implement the drilldown chart like here:
http://jsfiddle.net/6LXVQ/97/
Here the code of the bug:
https://github.com/schmittr/react-highcharts-drilldown
Would be nice to have this fixed soon. Maybe it's an issue of the highcharts version used by react-highcharts?
Kind regards,
Raphael
EDIT: I just found out, that when I move the window the diagram is in, such that it's kinda redrawn, the colors adjust.. weird thing. Still one Element is keeping there though..

@scheiblr as for the expanding of the pie chart on click on one of the labels just define a size key in the both of the series.

Thanks. A much cleaner solution to me was to download and import the drilldown extension manually (not by the npm package).


$ExpectType did not unwrap the type alias

This is just a minimal repro, the real use case is for types/npm-ramda to generate DT compatible tests so that we could put them on DT, but we got problems.
Is there any reason we can't pass the enclosingDeclaration parameter to typeToString in the expect rule?
Code
(index.d.ts)
export type Or<T, U> = T | U;

(something-tests.ts)
import * as something from 'something';

declare const result: something.Or<string, number>;

// $ExpectType string | number
result;

Expected
no errors
Actual
ERROR: 6:1   expect   Expected type to be:
  string | number
got:
  Or<string, number>

Or even more ridiculous:
ERROR: 299:1  expect                      Expected type to be:
  'Point'
got:
  "Point"

The solution being to change single quotes to double quotes.
The root issue here is that dtslint just does a comparison on the string representation of the types:https://github.com/Microsoft/dtslint/blob/4539c93657ea93e96eff84aa835422f6eed3e3b7/src/rules/expectRule.ts#L297-L304
The solution is to change the check to use the type relationships API. It should at least be isIdenticalTo rather than a string comparison.


Release of Landrush 1.0.0

@bexelbie, @ahpook, @fh, @strzibny, @phinze, @njam - any objections if I cut a 1.0.0 release

Are there any pending PRs you want to include?

Are there any pending PRs you want to include?

Not for now. Both open pull requests are still under discussion

+1 for 1.0 with current code and no additional PRs .. if PRs land that is OK too.  Do you need help with this?

sgtm!

:+1:

Cool. I do it once I get access to RubtGems


Small fixes for LLVM AOT backend on Windows.

Found while testing https://github.com/google/iree/pull/3757

Errors on CI (e.g. in layers_dynamic_batch_tests__layer__Dropout__target_backends__iree_llvmjit) but I can't tell from the logs if they are related to these changes...

yeah I think the base PR has the same failures on the CI - I have no idea why because the logs are useless and we have no artifacts - it's why I haven't made any progress on that :)


Update CODEOWNERS to match documentation

Once #1167 merges, we'll finally have an automatic system for notifying submodule maintainers.
We can remove the maintainers from each subpackage README so as not to duplicate work on PRs. Will also want to modify the contribution instructions.

@failure-to-thrive Are you interested in maintaining some modules?

@failure-to-thrive Are you interested in maintaining some modules?

Sure!

@failure-to-thrive Are you interested in maintaining some modules?

Sure!

Good! I have two modules for you.

maxout and optical_flow. You could submit a pull request.

maxout and optical_flow. You could submit a pull request.

Without any doubt, I'm very happy to submit pull requests! :smile:  However, as of this particular case, I'm not quite sure what and where I should modify. I think the project maintainers know the best. I'm ready to provide required info on their request.

maxout and optical_flow. You could submit a pull request.

Without any doubt, I'm very happy to submit pull requests! 😄 However, as of this particular case, I'm not quite sure what and where I should modify. I think the project maintainers know the best. I'm ready to provide required info on their request.

Yeah, I mean that you could submit a pull request to transfer the maintainership.
As I'm lack of time and energy. I could transfer it to you.

Yeah, I mean that you could submit a pull request to transfer the maintainership.

I meant the same. Sorry, I'm just unfamiliar with those aspects of GitHub and the project's workflow. Do you want me to update .github/CODEOWNERS? That's all?

There is a bot reading the CODEOWNERS file and dropping messages when someone is opening a pull requests that modifies the files you're responsible of.


Problem with AreaChart

Have a look at the two screenshots below. The first one draws a line chart, the second one an area chart with exactly the same data. Problem: the area chart does not draw properly.

The data is an array of about 256 atmospheric pressure values rising from 978.9 to 996 in small steps. Why does the area chart not draw properly?
Thanks for this cool library which makes life really a LOT easier! Keep up the brilliant work! 🥇

I just noticed that in the area chart the y-axis starts at 0. That's the problem as that makes the resolution change. Is there any way to make the y-axis start at the same level as in the line chart?

You can  try to change the AAChartTypeArea to be AAChartTypeAreaspline,may be it can help deal with this.

AAPropStatementAndFuncStatement(assign, AAChartModel, BOOL,       yAllowDecimals);//是否允许 y 轴显示小数
AAPropStatementAndFuncStatement(strong, AAChartModel, NSArray  *, yPlotLines);//y 轴基线的配置
AAPropStatementAndFuncStatement(strong, AAChartModel, NSNumber *, yMax);//y 轴最大值
AAPropStatementAndFuncStatement(strong, AAChartModel, NSNumber *, yMin);//y 轴最小值（设置为0就不会有负数）
AAPropStatementAndFuncStatement(strong, AAChartModel, NSArray  *, yTickPositions);//自定义 y 轴坐标（如：[@(0), @(25), @(50), @(75) , (100)]）

the yMin meaning the y axis mini value

And this is the official lib of Highcharts,It might help you too.
https://github.com/highcharts/highcharts-ios

But I donnot like the official lib ,because it is too huge and complicated to use.
postscript:And my lib is five months earlier than the official lib of Highcharts.😝😝😝

y max and min might help. Thanks! :o)


contrib: Install OVS Cloudbase beta MSI by default

Currently, a custom version of OVS is being installed by default
by the ansible playbooks.
This commit changes the default OVS installer to the Cloudbase beta
MSI instead of using the custom one.
Signed-off-by: Alin-Gheorghe Balutoiu<EMAIL_ADDRESS>Signed-off-by: Alin Gabriel Serdean<EMAIL_ADDRESS>Co-authored-by: Alin Gabriel Serdean<EMAIL_ADDRESS>

Closed in favor of #450


cli: Add --pretend option

Along with an option parser. Requires Bash 4.0 or greater for associative arrays. My guess is that by now everybody is using it?
This really helped my diagnose bitpocket syncing issues where files were not synced properly. It displays everything on the output and creates the diff files in the .bitpocket/tmp folder, but it does not actually sync anything and it does not update the state files. This is better that the list command because it shows what would be synchronized by bitpocket in both directions without actually doing it.
(Actually, macOS hasn't made it to bash 4.0 yet)

Bash 4.0 was released in 2009(!). I vote against any legacy support of older Bash versions.

Ok, I rebased it so it works with bash v3. I'm trying to get bitpocket to work on macOS, and that what it uses ...

This has been merged into the master branch and released in https://github.com/sickill/bitpocket/releases/tag/v0.2


Add support for watch_port on ActionProfileGroup members

This change exposes the newer watch_port field on ActionProfileGroup members to the shell. The deprecated watch field remains supported, but is not set to 0 by default anymore, as that would set the now oneof type watch_kind field.

The problem of setting a oneof field, even to 0, is that it sets the case to that specific field. If somebody checks which field is set, or that one at all are set, this will result in incorrect values returned from this call: https://developers.google.com/protocol-buffers/docs/reference/cpp-generated#oneof-embedded-message-fields


proxmox qemu vm resource gets assigned incorrect "ssh_host" and "ssh_port" values when there is only and ipv6 cloud-init configuration

I am using this provider to create VMs which only have an IPv6 address and no IPv4 address. The provider makes the incorrect assumption that the first ip address it finds in the cloud-init definition is an ipv4 address.
The culprit code is here: https://github.com/Telmate/terraform-provider-proxmox/blob/4403acf4b236b8f2d19c351e578fbb3729b74103/proxmox/resource_vm_qemu.go#L1057
For example, my VM has "ipconfig0": "ip6=2607:fa48:6c16:81b4::100:1/64,gw6=2607:fa48:6c16:81b4::1" in its terraform file and the provider incorrectly assigns the following attributes on the vm resource. This causes provisioning to fail because the provisionner cannot connect to the server :
"ssh_host": "2607",
"ssh_port": "fa48",

I also need ipv6 support

@starcraft66 do you have a idea to fix this issue?


Acronyms in F32

In Fedora 32 I cannot see acronyms. I got the list of 'Notation' and the 'Greek letters' but then nothing.
It gets solved by doing a sudo dnf install perl-Env ncurses-compat-libs...

Thank you, I think this issue will be very useful to someone having the same problem! I close it since it is already solved.


Added Basic Claims Configurations and Role configurations

Purpose
Here I have added Basic Claims Configurations and Role configurations, if you are not adding these configuration we will get below error after login to Developer portal using Facebook.
Error 403 : Forbidden
The server could not verify that you are authorized to access the requested resource.

@akurathimohan, isn't this fix applicable to master (3.2.0) as well?

Yes

@chanaka3d , can you please confirm this fix and also whether this fix needs to added in 3.2.0 and 4.0.0 docs


unable to read insomnia.json

I have an insomnia.json file, its about 3198 lines long.  Is there a limit to the size of the json file?  I tested with 2 other json exports from the same Insomnia and they had no issues displaying.
thanks

Hello! Do you see any error in the browser's console?

I found this, but makes no sense:
SyntaxError: JSON.parse: expected ',' or '}' after property value in object at line 6 column 23 of the JSON data
I parse the insomnia.json file using python -m json.tool and it did not report any errors, and this happens when I pull a fresh export from insomnia.
Any suggestions?

my insomnia file is 137kb in size, not sure if that matters or not

Does your file contain comments by any chance?

So thinking about your suggestion to look for Comments, I didn't find any, I did export multiple times until I narrowed it down to a single folder and in the ones that I excluded from export was one that was causing my issues.
I found the issue, it was on a duplicate api post call I had created, it had double quotes in the JSON body.  IE:
{
  "test1": "me",
  "test2": "you",
  "error": "here is my problem"",
  "end": "end"
}

Thank you for the guidance this issue can be closed out.

That's kinda weird tbh because Insomnia should escape quotes when exporting... or not even Insomnia but the JSON serializer itself. It's also weird that json.tool thinks it's ok.

the export showed
{
  \"test1\": \"me\",
  \"test2\": \"you\",
  \"error\": \"here is my problem\"\",
  \"end\": \"end\"
}

As soon as I changed it by removing the second escaped quote, your software rendered the page properly.
{
  \"test1\": \"me\",
  \"test2\": \"you\",
  \"error\": \"here is my problem\",
  \"end\": \"end\"
}
```

It is proper json output, but I guess it was just enough for the bundle.js to not be able to render properly.

I hope this issue can help others that might see or have a similar issue.

Ah that's fair enough then because Insomnia Documenter is trying to format those individually (indentation, syntax highlighting, etc.). So when it tried to parse that block, it failed because it's not valid JSON. I should probably make the error message be a little less vague.


Make Demos show fancier

I added code so if you hide demo in editor it will hide it and reposition active demos instead of keeping them on positions. Teleporters also got is active checkbox/property.

A hidden teleporter still has it's physics collision enabled, and it's possible to walk over to an invisible teleporter and stand on its still-physical base.

@Malcolmnixon is that good?

I should probably add check if it is not a tool...

It seems like it should work (and supports both Godot 3 and 4), but I need to check when I get home this evening - there's some odd verbiage in the documentation about CollisionShape3D - "IMPORTANT: this is an Editor-only helper to create shapes" but it doesn't exactly say what the ramifications are.

It seems like it should work (and supports both Godot 3 and 4), but I need to check when I get home this evening - there's some odd verbiage in the documentation about CollisionShape3D - "IMPORTANT: this is an Editor-only helper to create shapes" but it doesn't exactly say what the ramifications are.

It likely means this class is only included in editor builds, could break on runtimes

@Malcolmnixon is that good?

Not a fan, should expose a "disabled" property on the teleporter itself that nicely disables it's own collision shape.

Not a fan, should expose a "disabled" property on the teleporter itself that nicely disables it's own collision shape.

I agree - the teleporter should take on some of the responsibility. I'm also planning on moving the teleport-ring logic to its own node at some point - other scenes may want to have their own set of teleporters, or we may want to group similar functionality into different "areas" of the main scene - for example a ring dedicated to "movements" and a different one for "interactions".

ok I moved collision disabling code to other place

Looks good to me and works correctly with the collision shapes being removed.


Liquibase-core includes a shaded jackson-databind

Environment
Liquibase Version: 4.4.0
Liquibase Integration & Version: spring boot 2.4.5
Liquibase Extension(s) & Version: 4.4.0
Database Vendor & Version: Postgres 10.6
Operating System Type & Version: Linux (container)
Description
We use liquibase-core as part of a Java spring boot application and it's working fine functionally. We run Black Duck SCA scans to check for vulnerabilities in third party/open source software included in our application. This scan identified that liquibase-core jar includes a shaded copy of jackson-databind (possibly jackson 2.2.3). See attached screenshots. It seems to be inside `liquibase/pro/packaged" package.
The problem with shaded dependencies is that if a vulnerability is identified, we cannot force a newer version by explicitly declaring it in our build.gradle to mitigate the vulnerability. We operate in regulated environments and have mandates for fixing vulnerabilities very quickly. We don't have the luxury of waiting for third party components to update dependencies.
I would like to request that a variant of liquibase-core be published that doesn't include shaded jackson but simply declares the dependency in maven pom.
Steps To Reproduce
Run Synopsis Black Duck SCA analysis on liquibase-core-4.4.0.jar.
Actual Behavior
liquibase-core contains shaded dependency jackson-databind
Expected/Desired Behavior
liquibase-core doesn't contain shaded dependency. Dependencies are declared in maven pom
Screenshots (if appropriate)

Additional Context
N/A

Hi @kmurthy0 Thanks for alerting us to this issue.  We will add it to the list of issues we are processing.

We have a couple options we're looking into.

We need jackson-databind for the library we use for liquibase pro license key management. Longer term, we may use something different but for now we need to keep the jackson-databind dependency. We have it shaded in, since it's a commonly used library and we don't want our version to be conflicting with what else may be in an application.
We've updated the version we use so that it's not something that gets flagged as an insecure version as of around 4.5.0.

@nvoxland May I know the detail version of jackson-databind used in liquibase-core v4.4.0? With the detail version, we can add some comment in relevant scan result.


feat: HeadersWithUnderscoreActions on ClientTrafficPolicy

What type of PR is this?
Adds configuration to ClientTrafficPolicy to support overriding the default for HeadersWithUnderscoreActions in common HTTP protocol options.
What this PR does / why we need it:
Envoy defaults have headers_with_underscores_action set to ALLOW while Envoy Gateway defaults to REJECT_REQUEST despite the underscore character being allowed in header names by RFC-7230. This may be an ok default for EG to be more strict out of the box, but it breaks compatibility with preexisting API client configurations which send underscores in header names.

looks like a rebase is needed @davidalger

/retest


the sectioning should be based on knitr::spin markdown syntax

Ie. main sections should be indicatable with #' #, subsection with #' ##, and so on.

spinning is too specific. won't fix


Add validation status support to Dropdown

Description
The dropdown should support the standard validation statuses: error, warning, success.
Tasks
### Checklist
- [ ] Density (HD, MD, LD, TD)
- [ ] Mode (Light, Dark)
- [ ] Fill (Primary, Secondary, Tertiary)
- [ ] State (Default, Hover, Selected/Active, Disabled, Read-only, Other)
- [ ] Controlled API
- [ ] UITK accessibility parity (screen reader + keyboard interactions)

### Deliverables
- [ ] Characteristics spec
- [ ] Interactions spec, where necessary
- [ ] In Code & Figma (Component + Guide)
- [ ] Supporting site documentation

Closed by #3131


chore(deps): updated practically all dependencies

Modernizing
I started out using this boilerplate over two months ago. As I gradually improved my own project, I decided it would be a good idea to send some of those changes back. So, after days of testing... I have made a handful of improvements with the aim to modernize this boilerplate.
Improvements

Got rid of warnings during yarn install by being explicit about dependencies Eslint & Jest

Edit: this will come in another pull request along with an upgrade to yarn v3.

Updated 46 dependencies in package.json & template.json

I did not simply update to the newest version, but the version which best fits with the other dependencies. This results in a much more optimized dependency graph. This is why the yarn.lock file is 119 lines shorter than before, despite loads of new dependencies. It will get even smaller when the boilerplate is upgraded from yarn v1.

Updated react-router from v5 to v6, bringing its new syntax. This change required updating the snapshot for Jest & updating the documentation.

Added Windows support to internal scripts by opting for platform independent syntax.

Removed the use of Redux-Toolkit's deprecated getDefaultMiddleware(), which has been replaced by the modern syntax, introduced in v1.4.0 (June 2020)

Removed vs code workspace recommendations for deprecated chrome debugger & deprecated npm

This functionality has been built-in since VS Code v1.46 (May 2020)

Added a workspace recommendation for styled-components to replace the deprecated (now removed) extension.

Dependencies

I tested a huge amount of versions for every dependency before settling on these. I think these are the best for now, although many of these dependencies will work just fine on newer versions. I think newer is not necessarily better.

An upgrade to yarn v3 will be required to avoid some of the warnings that users experience on each yarn install. This is probably necessary and should come soon.

Testing
Please take a look at src\app\pages\HomePage\Features\GithubRepoForm\__tests__\index.test.tsx. This test gave me some trouble, but it appeared to be broken already before I made any changes.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.678%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
249

Relevant Lines:
249

💛  - Coveralls

does this check say its not building? Its building for me...

https://github.com/react-boilerplate/react-boilerplate-cra-template/runs/7897720487?check_suite_focus=true
eslint fails ?

https://github.com/react-boilerplate/react-boilerplate-cra-template/runs/7897720487?check_suite_focus=true
eslint fails ?

I see... I will investigate further later today, but the build is still working correctly on my computer.

hey @CrunchyCat great work here! thanks for sharing.
I would only kindly suggest to update the docs/building-blocks/routing.md file, accordingly to the new version of react-router-dom

The Usage part would be something like:

To add a new route, simply import the Route component and use it standalone or inside the Switch component (all part of
RR5 API):
      <Route path="/" element={<HomePage />} />

Top level routes are located in src/app/index.tsx.

And the Child Routes part would be like:

AboutPage/index.tsx
import { Switch, Route } from 'react-router-dom';
export function AboutPage() {
  return (
    <Routes>
      <Route path="/about/our-team" />
    </Routes>
  );
}

Thanks again for the amazing work and best regards!

https://github.com/react-boilerplate/react-boilerplate-cra-template/runs/7897720487?check_suite_focus=true
eslint fails ?

Okay, I believe I've fixed it. The problem is with the way that yarn v1 resolves eslint as a direct dependency & a dependency of react-scripts. I strongly recommend that we switch the project to yarn v3 for a host of benefits, including having fewer dependencies, more readable & verbose output, and having fewer warnings caused by the somewhat janky way we are avoiding using yarn v3.

@Can-Sahin @Markkos89 Would you two take a look at this PR? I'm all done for now and excited to see it merged.

LGTM. If the checks pass, I'll merge and release

'yarn test' fails with weird errors and it logs so much to the console.
I googled a bit and literally, nothing comes up. It scares me :)
I also copy pasted the older versions of packages and still same error weird enough.

that’s so strange ): I have no idea why that would be happening. as before, the build works correctly for me. 😔

This cookie error happens in my local computer too. Are you testing after creating a CRA app from the template?
yarn create:cra-app creates the app and you should test those actually. Are you doing the same?

This cookie error happens in my local computer too. Are you testing after creating a CRA app from the template?
yarn create:cra-app creates the app and you should test those actually. Are you doing the same?
like: yarn create:cra-app -> mv generated-cra-app ~/somewhere outside the repo -> cd generated-cra-app -> yarn test -> all tests fail

Yes, I am doing this also. As before, the exact same tests which used to fail before any changes, are the only ones that fail now. Everything works perfectly. What version of Node are you using to test? Maybe there is some kind of strange difference for an older version of Nodejs?

My node is 16. Also CI tests run on various node versions.
Non of the tests were giving this error before. Literally all of them fail now and I cannot find anything online. There must be something super small and weird. I ll try to apply each update one by one and run tests in between to see which one causes this problem

My node is 16. Also CI tests run on various node versions.
Non of the tests were giving this error before. Literally all of them fail now and I cannot find anything online. There must be something super small and weird. I ll try to apply each update one by one and run tests in between to see which one causes this problem

Okay. thank you. When I get a chance, I will test on Nodejs 14. I still have no idea what the problem could be.

Thanks for the effort 👍 I want to merge it as well, but I need to figure out what's wrong. It's weird. Because as soon as I merge I will publish a new version and I don't want to deal with 10s of people coming back saying it doesn't work, because who knows what environment settings they have :)

I am merging this. Are you finished? I see some commits recently.

I am merging this. Are you finished? I see some commits recently.

but didn’t you say it’s causing you errors?

They are gone. It fails in node 17 in CI/CD but I cannot figure out why. Most of them disappeared and I assume it was a bug in some packages used. Its the biggest problem with CRA. It fails randomly because the versions are not fixed. If some super deep packages publishes a faulty release everything is failing.

All green now. You also could add yourself to the contributors list ;)


500 template rendering errors masking underlying exceptoins

Been going through a whole bunch of Sentry errors recently and our 500 templates can't be rendered properly if an exception happens in the view code. In this case the template is rendered without a context, but the base.html refers to config in multiple places. So the root exception is masked behind a fairly large stack trace beginning with: VariableDoesNotExist: Failed lookup for key [config] in [{'True': True, 'False': False, 'None': None}].
Should we get create a new bare-bones base template for 500 errors where we just statically render everything without trying to name or style the page based on the various configurations?

Yes, this used to be what base_plain was for until I overrode it with stuff for the about pages. A single template with no calls to variables at all is probably best.

I switched this out just before the 0.9 release so it's now a very plain template indeed.


Specify custom (non-default) schemas for streams?

I'm currently using the "transferwise" target-postgres variant's schema_mapping setting to load data from different source dbs into their own schemas. This has been useful to keep data well-organized in the target postgres db.
I'm interested in switching to this variant, but don't see this option mentioned in the docs or in plans for future support. Would it be possible to add this functionality?

@bdewilde  clarified that what he wants here is to be able to push all data from a tap like tap-mysql to one schema. Right now the target stripes the databasename-streamname , databasename- is filtered out automatically

@bdewilde clarified that what he wants here is to be able to push all data from a tap like tap-mysql to one schema. Right now the target stripes the databasename-streamname , databasename- is filtered out automatically

Code from the SDK that does this is here https://github.com/meltano/sdk/blob/main/singer_sdk/sinks/sql.py#L73-L81

Requested in Slack: https://meltano.slack.com/archives/C01TCRBBJD7/p1699541259229359

Indeed that would be great. We have around 800 tables in our backend DB (spread over 10 to 15 schemas) and being able to map source_schema to target_schema would be a blessing.
Right now, our workaround is to split the tap in several sub-taps, all needing to be individually scheduled - it's a pain, but I didn't find a better way. Toy example:
plugins:
  extractors:
  - name: tap-postgres--prod
    inherit_from: tap-postgres
    config:
      host: xx
      port: 5432
      database: xx
    load_schema: backend
    select:
      - "*.*"
      # Ignored tables
      - "!public-activity.*"
      - "!public-pg_*.*"
      # Ignored schemas
      - "!auth-*.*"
      - "!misc-*.*"
    metadata:
      "*":
        replication-method: LOG_BASED
  - name: tap-postgres--prod-auth
    inherit_from: tap-postgres--prod
    load_schema: backend_auth
    select:
      - "auth-*.*"
    metadata:
      "*":
        replication-method: LOG_BASED
  - name: tap-postgres--prod-misc
    inherit_from: tap-postgres--prod
    load_schema: backend_misc
    select:
      - "misc-*.*"
    metadata:
      "*":
        replication-method: LOG_BASED


Perifocal frame and plotter set_frame

This is a proof of concept of how a *Plotter.set_frame could work. I am not very happy with the implementation, but to be honest working with Astropy frames is a little bit hacky at times :) Before merging this, I would like to:

[ ] Test the Geocentric Solar Ecliptic (GSE) frame that @shreyasbapat implemented a while ago to reproduce these beautiful plots
[ ] Add more image tests (now that we know how they work) to make this robust in the face of redraws
[ ] Clean the implementation
[ ] Evaluate a better name? Perhaps we can use get_pqw or get_pqw_frame instead of get_perifocal_frame. Thoughts?
[ ] Translate functionality to interactive plotters for consistency
[ ] Deprecate orbit.pqw

Oh wow, I can't even imagine how I started implementing this without doing #876 first.

The poliastro.plotting code is horrible, hopefully #876 addresses that a bit
This is still coupled with Orbit.from_body_ephem, which we intend to remove
The get_perifocal_frame code is horrible because... well, Astropy magic

I'm closing this, and hope I can address it... by the end of this year.


Minor Fixes

Hi,
this merge request fixes some minor issues.
It was created with help of Feram.
If it helped to improve this repository,
please consider to star Feram's repo to show some love! 😊
PS:
The Feram team is currently working on making this technology
available for everyone. If you want to be one of the first to use it,
please sign up up for the newsletter on feram.co.

Please do not spam repos to promote your tool.


[Feature Request] Google Drive or Plain Text support

More backup destination choices.

sorry, no new features planned.
https://github.com/jberkel/sms-backup-plus#can-you-add-feature-x-

+1


[WIP] Changes to support multi-account usage

This PR introduces a bunch of changes to support multi-account usage:

creates a Config struct with everything required to do requests to Twilio API.
move the old behavior to ExTwilio.Config.Env, so all changes can be backward compatible and doesn't require any code changing for people moving from older versions.

Reasoning for all the changes:

stop using application configuration(recommended in the Library Guidelines.)
allows multi-account usage
allows testing with bypass or other means once you can provide the desired url for the subdomains(either by setting it with application configuration or by using the actual config struct).

I've done just a small change in ExTwilio.UrlGenerator just as an example on how it can be used throughout the codebase. Most probably it's better to inject the Config.new() default config earlier as possible, to avoid it being called multiple times for a single request.

@danielberkompas can you please take a look to make sure that I'm in the right direction, I'd like to finish adjusting the code to use the config struct.


Create odd-even-linklist.cpp

Next time make sure to create a issue first. Read the Contribution guidelines.


Add support for reading image digests from a file

Description
Tools like kaniko have support for writing the published digest to a file to support results in systems like Tekton.
Signing these digests is awkward currently because you need to use shell functionality to read the result file:
    - name: sign-result
      image: gcr.io/projectsigstore/cosign:v1.4.0
      env:
      - name: COSIGN_EXPERIMENTAL
        value: "1"
      command: [/busybox/sh, -c]
      args: ["/ko-app/cosign sign $(cat /tekton/results/IMAGES)"]

I propose adding support for reading these from a file.  A (straw-person) pattern for this would be to use @filename, which would shorten this to:
    - name: sign-result
      image: gcr.io/projectsigstore/cosign:v1.4.0
      env:
      - name: COSIGN_EXPERIMENTAL
        value: "1"
      args: ["sign", "@/tekton/results/IMAGES"]

Maybe this would be a good opportunity to switch to signing descriptors. @sudo-bmitch had some ideas here too. If we start signing descriptors we'll need more than just the digest (mostly size) so this file should support that too.

I was leaning towards the index.json file format from the OCI Layout spec. In addition to the size, we need the media type to avoid CVE-2021-41190.

WDYT @mattmoor? index.json seems like it would work, although it can contain multiple images. But then again, cosign can also sign multiple at a time.

we need the media type to avoid CVE-2021-41190.

Really only if the manifest referenced by digest doesn't include one, which I'd wager the vast majority of images/indices (still using docker media types) do, no?
That said... Honestly I care very little about the schema of the file, so long as it aligns with what Tekton Chains would expect in such a file, so I can basically pass in the IMAGES or DESCRIPTORS or whatever the result file is.
Although as I mentally tug on this thread...  We then also need every tool to start adding support for emitting / augmenting these files, so we'd also need kaniko, ko, buildpacks, ... to support adding emitted image digests to this file.

we need the media type to avoid CVE-2021-41190.

Really only if the manifest referenced by digest doesn't include one, which I'd wager the vast majority of images/indices (still using docker media types) do, no?

For the vast majority of images, yes. I'm thinking of possible malicious intents. Perhaps a security check is run to validate the image before signing it (maybe not a vulnerability scan since those change over time, but some kind of static compliance check), and it only sees the image descriptor and checks that. The attacker then uses that signature to deploy the index with a malicious image to prod on a different registry.
My thought for the OCI Layout is that it makes a nice way to pass an image between steps in a CI pipeline, only pushing to the registry near the end of the pipeline when your ready to deploy, rather than the beginning while you're still validating the result. It will probably be a while before the tooling gets to that point, but I'm pushing for baby steps in that direction (while updating my own tooling for the same reasons).


onchange of select

I have a dropdown of country list. I set a function which get call at onChange event and console the current selected value. When I type IN then its getiing called two times
so console show Iceland and India, general dropdown dont do so

Moreover, the change event is generated when the item which is already selected is selected again. Native selects do not behave this way.
See the code:
onSelect: function() {
this.refresh();
		if (this.realElement.prop('multiple')) {
			this.repositionDropdown();
		} else {
			this.hideDropdown();
		}

		this.fireNativeEvent(this.realElement, 'change');
	},

'change' event is triggered even if we don't change the selection. This must be fixed by checking the selected item before triggering the event here.


update zh-rTW translation

Refer wiki, Microsoft UI, EhViewer,etc.

Refer wiki, Microsoft UI, EhViewer,etc.

btw,thx for the big fix


Convert audio into mp4a-latm

Can you help me to convert audio file into mp4a-latm format in rtp? thank you very much.

You can simply use ffmpeg or gstreamer to stream file over rtsp. It is not a requirement now to use mp4a-latm. Almost all HE AAC payloads are supported


Create new PayID account when user registration has completed

Once the user has completed their registration create a payid account for them.

Completed


Adds .gitignore in generator for quilt_rails

Description
Fixes (issue #)

Type of change

[ ]  Patch: Bug/ Documentation fix (non-breaking change which fixes an issue or adds documentation)
[ ]  Minor: New feature (non-breaking change which adds functionality)
[ ]  Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[ ] I have added a changelog entry, prefixed by the type of change noted above

@cartogram still working on this?

@lemonmade It's close, but I am not actively working on it right now. Will close convert to an issue reopen when I have some time to wrap this up.


[pom] Rework checkstyle override to use parent override logic

cleaner propery based only based off logic originally applied here.

Coverage remained the same at 100.0% when pulling 4e4a878bae320003287564711d94ee95f28038ad on hazendaz:master into 95801d07eeeaedb24f2e3a06ae2b6453e8012a11 on mybatis:master.


addon not working anymore

can somebody please update it.
many thanks

To be honest, I had no idea there was still any interest in this. Let us test it, and then we will update it to work on the new version of the game.

The plugin is now available for FINAL FANTASY XIV users on Patch 6.5x.


Run the interactive ssh through Net::SSH

This PR replaces shelling out to system ssh with a pure-ruby Net::SSH solution. This way the bastion host stuff and proxy_command etc are used automatically.

Rubocop says no.

Now handles screen resizing


Allow primative values in responses only

from https://github.com/ethereum/lahja/issues/89
What was wrong?
It is cumbersome to define a response event for things that have a primative singular value.
How can it be fixed?
We can allow the following primative types to be sent across the wire but only as a response to a request.

int
float
bytes
str

We can still package them up in an internal event like this:
class _PrimativeValue(BaseEvent):
    value: Union[int, float, bytes, str]

On the sending side, we only allow sending if the event is accompanied by a BroadcastConfig that defines filter_event_id and filter_endpoint.
On the receiving side, we unwrap the value if these conditions are met.  This looks like this will require unwrapping in _process_item which means our various queues and things will have to have flexible type hints for the mechanisms where we're sending things to subscription handlers, futures, etc.

I think this will require a re-architecture to move origin and request_id onto the Broadcast and to convert all places where we pass around item: BaseEvent to instead expect a Broadcast instance since we'll no longer be able to assign extra meta-data values onto the value being broadcast.


feat: add download-data API (w/o verification of redeem receipt)

Implementation of download-data API without verification of redeem receipt part.
In download handler, the below things are done:

get all the data from storage

used downloader of s3 storage. It also use getObject internally and the downloader provide concurrent download.

decrypt the data with AES256
re-encrypt the data with redeemer's public key

As I mentioned in the comment, we may have to be given tokenID(which is redeemed) or redeemReceiptID in request of this API. Since the buyer can have multiple DataPasses and the validator have to know which redeem receipt is used to request download-data.
TODO)

add redeem receipt verification
test code
pipelining

The new PR(#75) is opened so I close this PR


[5.7] Migrate to python3

release/5.7 swift project moved to python3, moving swiftpm build tools to
python3 to match.
(cherry picked from commit c0d5daa8fb43d87a6043a79c3cd132987eb40623)
To support Ubuntu 22.04 for Swift 5.7, we need to cherry-pick changes to support Python3.

@swift-ci smoke test


Also warn for bugs without the regression keyword but has "Has Regression Range=yes"

Seems that it is pretty common:
https://mzl.la/2KN89EH

Maybe in these cases we should actually add "regression"? It seems we can't be wrong if we do it.

@marco-c not sure, see https://bugzilla.mozilla.org/show_bug.cgi?id=1461027
https://bugzilla.mozilla.org/show_bug.cgi?id=1461034

https://bugzilla.mozilla.org/show_bug.cgi?id=1461027 is a regression, see comment 4 and 5.
https://bugzilla.mozilla.org/show_bug.cgi?id=1461034 might be a regression too, see comment 2.

Sure, it is a crash, it should a be a regression anyway.
I just meant that we don't have a regression range in these bugs.


Vehicle parameter identification failed

2017 Toyota Corolla
resetting calibration did not solve the issue

After I reboot the system it works fine for a minutes until this message shows up.

Can you fill out the bug report template? We need the logs to look into this.

Device: [e.g. EON/EON Gold/comma two]
Dongle ID: [e.g. 77611a1fac303767, can be found in Settings -> Device -> Dongle ID or my.comma.ai/useradmin]
Route: [e.g. 77611a1fac303767|2020-05-11--16-37-07, can be found in my.comma.ai/useradmin]
Timestamp: [When in the route the bug occurs (e.g. 4min 30s into the drive)]
Version: [commit hash when on a non-release branch, or version number when on devel or release2 (e.g. 0.7.6)]
Car make/model: [e.g. Toyota Prius 2016]

Hi thanks for the reply!
I’m not too familiar with coding, is there anywhere I can get more
information regarding getting the log?
Thanks
Bowen
On Sun, Apr 25, 2021 at 2:14 PM Willem Melching @.***>
wrote:

Can you fill out the bug report template? We need the logs to look into
this.

Device: [e.g. EON/EON Gold/comma two]
Dongle ID: [e.g. 77611a1fac303767, can be found in Settings ->
Device -> Dongle ID or my.comma.ai/useradmin]
Route: [e.g. 77611a1fac303767|2020-05-11--16-37-07, can be found in
my.comma.ai/useradmin]
Timestamp: [When in the route the bug occurs (e.g. 4min 30s into the
drive)]
Version: [commit hash when on a non-release branch, or version
number when on devel or release2 (e.g. 0.7.6)]
Car make/model: [e.g. Toyota Prius 2016]

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/commaai/openpilot/issues/20746#issuecomment-826366010,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AT2N2BXDUWHGFF5PDLFYIL3TKRLXDANCNFSM43RO4ICA
.

Just fill out the template with all the required information (dongle id, route, version) and we can find the correct logs.

Device: comma two
Dongle ID: 308441ee81a066a4

Route: my.comma.ai/useradmin I went on this link and this is what I
see, I can’t find information for route number.
Timestamp: [When in the route the bug occurs (e.g. 4min 30s into the
drive)]

Version: release2 v0.8.3
Car make/model: 2017 Toyota Corolla

On Sun, Apr 25, 2021 at 2:32 PM Willem Melching @.***>
wrote:

Just fill out the template with all the required information (dongle id,
route, version) and we can find the correct logs.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/commaai/openpilot/issues/20746#issuecomment-826369137,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AT2N2BX2HRGE6AWLAMCCRH3TKRN5VANCNFSM43RO4ICA
.

Can you connect your device to wifi to make sure the full logs are uploaded?

Looking at the low resolution logs (qlogs), it seems like the angle sensor on your steering wheel indicates ~10 degrees when going straight, which is outside of the acceptable range for openpilot to work. Does your steering wheel look straight when driving straight?

That might be the exact problem, it might be an alignment issue. Or because
the car was rebuilt, it was hit at the rear frame but it’s drives pretty
straight.
My steering does appear to be towards the left when it’s driving straight,
and open pilot does an awesome job keeping the vehicle right in the center
of the lane.
When the Error Message comes up, if I disengage, it will not engage again
without rebooting. But if I keep it engaged with the error message, it
drives perfect.
Is there any way to bypass that acceptable range for the angle sensor
boundaries?
On Mon, Apr 26, 2021 at 12:57 PM Willem Melching @.***>
wrote:

Looking at the low resolution logs (qlogs), it seems like the angle sensor
on your steering wheel indicates ~10 degrees when going straight, which is
outside of the acceptable range for openpilot to work. Does your steering
wheel look straight when driving straight?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/commaai/openpilot/issues/20746#issuecomment-826997266,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AT2N2BR7VDBGBV4GXM2RJL3TKWLRPANCNFSM43RO4ICA
.

Is there anything i can do to help on my end?
Thanks
Bowen
On Mon, Apr 26, 2021 at 1:05 PM Bowen Huang @.***>
wrote:

That might be the exact problem, it might be an alignment issue. Or
because the car was rebuilt, it was hit at the rear frame but it’s drives
pretty straight.
My steering does appear to be towards the left when it’s driving straight,
and open pilot does an awesome job keeping the vehicle right in the center
of the lane.
When the Error Message comes up, if I disengage, it will not engage again
without rebooting. But if I keep it engaged with the error message, it
drives perfect.
Is there any way to bypass that acceptable range for the angle sensor
boundaries?
On Mon, Apr 26, 2021 at 12:57 PM Willem Melching @.***>
wrote:

Looking at the low resolution logs (qlogs), it seems like the angle
sensor on your steering wheel indicates ~10 degrees when going straight,
which is outside of the acceptable range for openpilot to work. Does your
steering wheel look straight when driving straight?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/commaai/openpilot/issues/20746#issuecomment-826997266,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AT2N2BR7VDBGBV4GXM2RJL3TKWLRPANCNFSM43RO4ICA
.

The 10 degree limit is here: https://github.com/commaai/openpilot/blob/master/selfdrive/locationd/paramsd.py#L141
But there might be other subtle issues due to the asymmetry in your car. I would recommend to get it aligned.

Thank you very much!
How do I access those coding and change that limit on my device?
On Wed, Apr 28, 2021 at 5:30 AM Willem Melching @.***>
wrote:

Closed #20746 https://github.com/commaai/openpilot/issues/20746.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/commaai/openpilot/issues/20746#event-4655640597, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AT2N2BTMRSDN5CNECGSAEELTK7ISRANCNFSM43RO4ICA
.


Add Arm64EC to the list of architectures to check

The arm64ec-pc-windows-msvc target has been promoted to tier 2, so now that there is a prebuilt standard library available for it add it to the list of architectures to check during CI.

do note that where you added it just runs cargo clippy on it, if you wanted to actually run tests, you'll need to add it to the cross section

do note that where you added it just runs cargo clippy on it, if you wanted to actually run tests, you'll need to add it to the cross section (edit: nevermind, those are for linux)

GitHub just got ARM64 runner support, so we may want to start running the Windows and Linux ARM64 tests on native hardware instead of using cross.
But, yes, for now just adding this to the list of arches to run clippy.


[Android] Failure to initialize in emulator / Windows Subsystem for Android

It seems media_kit fails to initialize video surfaces/codecs when used in an emulator.
Also, I've submitted my app to the Amazon App Store to target, among others, Windows 11 devices (via WSA). They had accepted previous versions of Aves that used a different video engine, but this time the app got rejected because video playback fails on WSA with media_kit. I don't have Windows so I can't test this myself, but Amazon testers were kind enough to provide logs.
Here are filtered logs for the emulator case, and the more thorough logs for the WSA case.
Package versions:
media_kit: "1.1.7"
media_kit_libs_android_video: "1.3.3"
media_kit_native_event_loop: "1.0.7"
media_kit_video: "1.1.8"

We already fallback to S/W rendering in emulators, that's the best we will do here.

Falling back to SW rendering is fine. But what I'm reporting is that it fails.

My bad, I got mistaken, it does not fail all the time. I got some videos to work on an Android 13 emulator. I thought all videos were failing but I guess only some codecs were badly handled.
Want me to close this issue?

Hi!
Apologies, not very active these days. In most cases (with last update), S/W fallback works very well on Android.
On emulators, I simply use following to enforce S/W rendering:
https://github.com/media-kit/media-kit/blob/8fd22cc5b11035ac22fd2a0f930056a18fc69095/media_kit_video/android/src/main/java/com/alexmercerind/media_kit_video/Utils.java#L12-L37
I believe it's good that way. I think WSA is not being handled by above.


Editorial Changes

@ejmaginn @drroe @jrelliottoh @dcarls0n
Our manuscript has officially been accepted. The editor has requested the following changes before final publication:

The title should be in the form: (title) [Article v1.0]
In the other resources section, in the introduction, put titles in italics in references, or otherwise set them apart, additionally, it probably makes sense to list just the name of person for class notes (I'm open to other suggestions).
Figures should have their first sentence rephrased as the conclusion that the figure shows, so that the point the figures make is self-contained. For example, in figure 5, Figure 5: rephrase the first sentence as a conclusion, such as "viscosity obtained with the Green-Kubo relationship is only weakly dependent on system size in the range studied".
Generally, the figures should be examined to ensure they are self-contained. In may cases, the figures refer to the paper the figure came some itself, which is acceptable for the data on how the figures are generated, but the meaning of the figures should be self-contained in the caption. Also, thanks for seeing out permission to use those figures.
Figure 1: MD and YH not defined in caption.
Figure 2: This is a bit confusing, as the linear fits are to points that appear to be outside the graph. Red dotted line does not have a label. The notation Etors is not explained.
Figure 8: the inset is not described as such.
Table 1: Variables (such as gamma and xi) should be explicitly define in the table, not just in the context.
Section 5.4 and 6.4: Suggest something more specific than "special topics"
ACS style guide says do not leave a space between a number and a percent; this happens a number of times in the article.
Acknowledgements should be updated to include anyone who has contributed (other than the author and the editors) to improve the paper.
Reference 23 has an improperly formatted DOI.
Preference is that citations are abbreviations, but the regardless style must be consistent; there are citations that are both abbreviations and full journal entries.
For references 14-17, see if there is a way to split the html without losing the link (check href package options?)

@ejmaginn @drroe @jrelliottoh @dcarls0n
Most of these changes are pretty simple. I have almost finished implementing comments: 1, 2, 5, 6, 7, 9, 10 11, 12, and 13.
For the remaining comments 3, 4, and 8, I would appreciate some feedback from the team.

Personally, I dislike starting figure captions with a conclusion. But if the journal requires this I guess we need to modify all of our figure captions. If you would like to do this, let me know.

I would appreciate if someone would go back through every figure and make sure they are self-contained.

I don't really know how to define gamma and xi. They are basically defined in the Equations in the text. Suggestions?

@ejmaginn @drroe @jrelliottoh @dcarls0n
OK, I have finished all of the edits. I went through and modified all of the figure captions so that the first sentence is a conclusion statement. I believe all the figures are sufficiently self-contained. And I defined gamma and xi (along with other previously undefined symbols in Table 1).
I would appreciate if everyone read over all of the figure captions, since that is the largest change that was made. Could you make sure that the first sentence presents the main conclusion of the figure and that the caption is sufficient without needing context from the main text?
Thanks! This is the final leg! The finish line is in sight!

@ramess101 Looks great - thanks for handling that. I made some minor fixes but didn't change anything major.
Regarding 5.4, we could just change that to 'Considerations for membrane systems' since that's all that section really covers. And for 6.4 we can change that to something like 'Force Field Effects on Viscosity'. What does everyone think?

@drroe Thanks!
As for 5.4 and 6.4, I think the idea was for those sections to be placeholders for other future topics. Although they currently only discuss those two issues, I still think we kind of want a miscellaneous section. I would vote for us to leave the section title "Special topics" and then have 5.4.1 and 6.4.1 with the titles you suggested. I know this doesn't satisfy the editorial comment, but I don't think that is a mandatory change.

@ramess101 this looks great! I found two small issues:
Caption fig 1: Yem-Hummer should be Yeh-Hummer
Caption fig 11: I think Ethanol should be ethanol (it  is not a proper noun)

@drroe @ejmaginn
OK, I implemented Ed's corrections. I also included subheaders for Sections 5.4.1 and 6.4.1 titled "Considerations for membrane systems" and "Considerations for cut-off length". If you have any other issues, let me know before the end of the day. I will resubmit to LiveCoMS this evening.

@jrelliottoh
Thanks, but the manuscript has already been resubmitted. I don't think we have any citation information just yet.


update pull request template in contributing - .github to latest version

We can close this, template is updated. No need to make a change.


bug:  expand("%p") returns empty on first file restored after vscode restart

Check the following:

[X] I have checked the behavior after setting "vscode-neovim.neovimClean" in VSCode settings.
[X] I have read the vscode-neovim docs.
[X] I have searched existing issues.

Neovim version (nvim -v)
NVIM v0.9.4
Operating system/version
Windows 11
Describe the bug
expand("%p") doesn't work properly, which makes some plugins failed.
Steps To Reproduce

Create an empty folder, for example, called test
Create two files a.txt, b.txt in the directory test
Right click on test, choose open with vscode
Open the two files a.txt and b.txt, and make a.txt as the current tab.
Close vscode.
Reopen vscode, then the last session is restored, and a.txt is the current tab.
Type : echo expand("%p"), and we get nothing.
Change to b.txt, and type : echo expand("%p"), and we get the wsl path of b.txt

Expected Behavior
echo expand("%p") should print path of the current file, however, nothing printed. See the following link.
https://www.youtube.com/watch?v=IyQTBKg8Im4

6. Reopen vscode, then the last session is restored, and a.txt is the current tab

Seems much narrower than the more general problem of "expand doesn't work"? Does expand("%p") work otherwise (i.e. without close-and-restart vscode)?

Can't reproduce

Can't reproduce

One more thing: I use wsl version(ubuntu 24.04) nvim, and I can always reproduce this issue.

It seems to be a local environment issue. I'll close this issue for now.
There are several methods for reference:

Use variables b:vscode_uri and b:vscode_uri_data
Use vscode.eval to obtain document information.


Split inline bash code into own script(s)

Discussed in #19
Even with other alternative ideas, it seems like a safe first step is to copy+paste the code into its own .sh file. In the future, maybe use a JS action or a Docker thing or some other technique. Who knows 🤷

In the future, maybe use a JS action or a Docker thing or some other technique.

I'll say now that, if we decide that a composite action isn't enough, I'd want to make a JS action.
Pros

Can be used with jobs that run on Windows
Docker actions are often slow (it builds from the Dockerfile each run) unless the docker image is published (technically a Docker con, not a JS pro)

btw as proof (for me at least; id never seen this) you CANNOT run a Docker container-based image on Windows (at least not right now)

Yeah, AFAIK it's a licensing issue. As it is, GH either can't or doesn't want to use docker on Windows commercially.


Avatar component has imgProps marked as deprecated but the suggested alternative does not work

Steps to reproduce
Steps:

Create an avatar component whose image is served from an external source that requires the cross origin property to be set
Use the slotProps / img settings to specify the crossOrigin setting
The request will fail and you will see this error in the console net::ERR_BLOCKED_BY_RESPONSE.NotSameOrigin
Replace slotProps with the old but deprecated imgProps property with the same settings and see how the request now works.

Current behavior
Requests will fail with  net::ERR_BLOCKED_BY_RESPONSE.NotSameOrigin
Expected behavior
Requests should not fail
Context
We upgraded our code using the suggested command npx @mui/codemod@latest deprecations/all <path> which updated the code correctly but raised this issue.
Your environment

npx @mui/envinfo

  System:
    OS: Linux 5.15 Ubuntu 22.04.4 LTS 22.04.4 LTS (Jammy Jellyfish)
  Binaries:
    Node: 20.11.1 - /usr/local/bin/node
    npm: 8.19.4 - ~/Projects/_2024/oly-web-client/node_modules/.bin/npm
    pnpm: Not Found
  Browsers:
    Chrome: 131.0.6778.71
  npmPackages:
    @emotion/react:  11.11.1
    @emotion/styled:  11.11.0
    @mui/core-downloads-tracker:  6.1.5
    @mui/material: 6.1.5 => 6.1.5
    @mui/private-theming:  6.1.5
    @mui/styled-engine:  6.1.5
    @mui/system:  6.1.5
    @mui/types:  7.2.18
    @mui/utils:  6.1.5
    @mui/x-internals:  7.21.0
    @mui/x-tree-view: ^7.21.0 => 7.21.0
    @types/react: 18.0.20 => 18.0.20
    react: 18.2.0 => 18.2.0
    react-dom: 18.2.0 => 18.2.0
    typescript: 5.3.2 => 5.3.2

Search keywords: Avatar imgProps

Please provide a reproducible sandbox. What's the result you see in the devtool?

The attribute I am concerned with is crossOrigin, but I don't believe any of the attributes from slotProps:img are being applied.
The attributes available for slotProps:img are the same as those for imgProps
        crossOrigin?: "anonymous" | "use-credentials" | "" | undefined;
        decoding?: "async" | "auto" | "sync" | undefined;
        height?: number | string | undefined;
        loading?: "eager" | "lazy" | undefined;
        referrerPolicy?: HTMLAttributeReferrerPolicy | undefined;
        sizes?: string | undefined;
        src?: string | undefined;
        srcSet?: string | undefined;
        useMap?: string | undefined;
        width?: number | string | undefined;```

Code sandbox example here:
https://codesandbox.io/p/sandbox/avatar-imgprops-demo-7jdnp5

Thanks, I will fix it asap.


@releng - mentions the Content Fragment Component in the Core Compone…

…nts README.md

Mentions the Content Fragment Component in README.md and adds sub note on it being an extension.
Orders page authoring components alphabetically.
Removes superfluous "component" label from page authoring components.

Codecov Report

Merging #164 into development will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             development     #164   +/-   ##
==============================================
  Coverage          82.52%   82.52%
  Complexity           743      743
==============================================
  Files                 71       71
  Lines               2415     2415
  Branches             434      434
==============================================
  Hits                1993     1993
  Misses               170      170
  Partials             252      252

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2abe7ae...211c04b. Read the comment docs.


Serious regression: ISO Word documents are now all in ARIAL font

Version 1.3.27 worked. Version 1.4.0 broke the fonts.

PresentationXML lack of fonts is making the default font assignment stick to the hash of isodoc options being passed around the loop of isodoc generations in metanorma gem. Fixed by resetting each time, which is the right thing to do anyway.