H5ad write failing to cast types properly

[x] I have checked that this issue has not already been reported.
[x] I have confirmed this bug exists on the latest version of scanpy.
[x] (optional) I have confirmed this bug exists on the master branch of scanpy.

Hi there, recently installed a fresh conda env as described on the scanpy page. Suddenly having the issue below. Minimal example provided. I saw old issues with a similar error but they appear to be closed and fixed. Thanks for your help.

import anndata
import scanpy as sc
import pandas as pd
import scvelo as scv
import numpy as np

sc.logging.print_versions()

X=np.array([[0,1,0],[0,1,0],[0,1,0]])
obs=pd.DataFrame([['red',1,0.22222],['blue',0,np.nan],['orange',1,0.1]])
var=pd.DataFrame([['yes',1,2],[np.nan,0,np.nan],['no',1.1,0.1]])
adata=anndata.AnnData(X=X,obs=obs,var=var)
adata.write('/wynton/home/ye/mschmitz1/test.h5ad')

(scanpy) [mschmitz1@dev2 misc]$ python TestH5write.py
... storing 0 as categorical
Traceback (most recent call last):
  File "/wynton/home/ye/mschmitz1/utils/miniconda3/envs/scanpy/lib/python3.9/site-packages/anndata/_io/utils.py", line 209, in func_wrapper
    return func(elem, key, val, *args, **kwargs)
  File "/wynton/home/ye/mschmitz1/utils/miniconda3/envs/scanpy/lib/python3.9/site-packages/anndata/_io/h5ad.py", line 247, in write_dataframe
    col_names = [check_key(c) for c in df.columns]
  File "/wynton/home/ye/mschmitz1/utils/miniconda3/envs/scanpy/lib/python3.9/site-packages/anndata/_io/h5ad.py", line 247, in <listcomp>
    col_names = [check_key(c) for c in df.columns]
  File "/wynton/home/ye/mschmitz1/utils/miniconda3/envs/scanpy/lib/python3.9/site-packages/anndata/_io/utils.py", line 109, in check_key
    raise TypeError(f"{key} of type {typ} is an invalid key. Should be str.")
TypeError: 0 of type <class 'int'> is an invalid key. Should be str.

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/wynton/home/ye/mschmitz1/code/macaque-dev-brain/misc/TestH5write.py", line 11, in <module>
    adata.write('/wynton/home/ye/mschmitz1/test.h5ad')
  File "/wynton/home/ye/mschmitz1/utils/miniconda3/envs/scanpy/lib/python3.9/site-packages/anndata/_core/anndata.py", line 1905, in write_h5ad
    _write_h5ad(
  File "/wynton/home/ye/mschmitz1/utils/miniconda3/envs/scanpy/lib/python3.9/site-packages/anndata/_io/h5ad.py", line 111, in write_h5ad
    write_attribute(f, "obs", adata.obs, dataset_kwargs=dataset_kwargs)
  File "/wynton/home/ye/mschmitz1/utils/miniconda3/envs/scanpy/lib/python3.9/functools.py", line 877, in wrapper
    return dispatch(args[0].__class__)(*args, **kw)
  File "/wynton/home/ye/mschmitz1/utils/miniconda3/envs/scanpy/lib/python3.9/site-packages/anndata/_io/h5ad.py", line 130, in write_attribute_h5ad
    _write_method(type(value))(f, key, value, *args, **kwargs)
  File "/wynton/home/ye/mschmitz1/utils/miniconda3/envs/scanpy/lib/python3.9/site-packages/anndata/_io/utils.py", line 212, in func_wrapper
    raise type(e)(
TypeError: 0 of type <class 'int'> is an invalid key.  It currently renders me unable to do analysis using scanpy as I can't save intermediates in analysis on large datasets without going through each column type and manually casting column values to the correct dtype.

So, we can currently only save columns which are numpy dtypes, all strings, or pandas categoricals. In the near future we are looking to support more pandas dtypes. In particular we are looking at nullable strings and integers.
There was a previous issue where columns with object dtype would silently be converted to strings, and then written. Our ability to infer whether those columns values are actually all strings has improved with pandas.
For your current problem:
From the limited view I see here, the column adata.obs['latent_cell_probability'] should probably be float64. Do you know why it's not?
It would be helpful if you could share how these objects are being created. It's possible there are some factors in that I'm not considering.

Hey, I worked on this for a while, and I've figured out it has to do with some weird interaction of mixed numeric, nan and string columns which occurred  because the more recent version of pandas isn't correctly inferring the dtype anymore when reading files through pandas directly (not the standard cellranger pipeline).
import anndata
import scanpy as sc
import pandas as pd
import scvelo as scv
import numpy as np

sc.logging.print_versions()

X=np.array([[0,7,7],[1,7,0],[0,1,0]])
#This line causes error
obs=pd.DataFrame([['red',1,0.22222],['blue',0,str(np.nan)],['orange',1,0.1]])
#This line does not cause error
#obs=pd.DataFrame([['red',1,0.22222],['blue',0,np.nan],['orange',1,0.1]])
var=pd.DataFrame([['yes',1,2],[np.nan,0,np.nan],['no',1.1,0.1]])
adata=anndata.AnnData(X=X,obs=obs,var=var)
adata.obs.columns = adata.obs.columns.astype(str)
adata.var.columns = adata.var.columns.astype(str)
sc.pp.filter_cells(adata,min_genes=1)
print(adata.obs)
adata.write('test.h5ad')

I can at least get it to save by passing anndata through this function until this is fixed.
def sanitize_types_for_h5(adata):
    adata.var=adata.var.convert_dtypes()
    adata.obs=adata.obs.convert_dtypes()

    for c,t in zip(adata.obs.columns,adata.obs.dtypes):
        adata.obs[c]=adata.obs[c].to_list()
        if t == object:
            print(c,t)
            adata.obs[c]=pd.to_numeric(adata.obs[c], errors='coerce')

    for c,t in zip(adata.var.columns,adata.var.dtypes):
        adata.var[c]=adata.var[c].to_list()
        if t == object:
            print(c,t)
            adata.var[c]=pd.to_numeric(adata.var[c], errors='coerce')

    if adata.raw is not None:
        adata.raw.var.columns = adata.raw.var.columns.astype(str)
        for c,t in zip(adata.raw.var.columns,adata.raw.var.dtypes):
            adata.raw.var[c]=adata.raw.var[c].to_list()
            if t == object:
                adata.var[c]=pd.to_numeric(adata.raw.var[c].fillna(np.nan), errors='coerce')

    adata.obs=adata.obs.fillna(np.nan)
    adata.var=adata.var.fillna(np.nan)
    adata.var.columns = adata.var.columns.astype(str)
    adata.obs.columns = adata.obs.columns.astype(str)
    return(adata)

@ivirshup  I admit my input is a bit unusual-- I pass kallisto outputs with both exons and introns through cellbender, then read the h5 files in using this function:
def readCellbenderH5(filename,include_obs=True,transcript_names=False):
    import h5py
    import scanpy as sc
    import scipy
    f = h5py.File(filename, 'r')
    mat=f['matrix']
    if include_obs:
        cols=['latent_cell_probability','latent_RT_efficiency']
        obsdict={x:mat[x] for x in cols}
        obs=pd.DataFrame(obsdict,index=[x.decode('ascii') for x in mat['barcodes']])
    else:
        obs=pd.DataFrame(index=[x.decode('ascii') for x in mat['barcodes']])

    ad=sc.AnnData(X=scipy.sparse.csr_matrix((mat['data'][:],
                                          mat['indices'][:],
                                          mat['indptr'][:]),
                                        shape=(mat['shape'][1],mat['shape'][0])),
              var=pd.DataFrame(dict(mat['features'])),
              obs=obs,
              uns={'test_elbo':list(mat['test_elbo']),'test_epoch':list(mat['test_epoch'])})
    if transcript_names:
        ad.var.index=[x.decode('ascii') for x in ad.var['id']]
    else:
        ad.var.index=[x.decode('ascii') for x in ad.var['name']]
    introng=np.array(['__I' in x for x in ad.var.index])
    uadata=ad[:,introng].copy()
    sadata=ad[:,~introng].copy()

    uadata=sum_duplicate_var(uadata)
    sadata=sum_duplicate_var(sadata)

    uadata.var.index=[re.sub('__I','',x) for x in uadata.var.index]
    sadata=sc.AnnData.concatenate(sadata,uadata,join='outer')

    uadata=sadata[sadata.obs['batch']=='1',:].copy()
    sadata=sadata[sadata.obs['batch']=='0',:].copy()

    sadata.obs.index=[re.sub('-[0-9]','',x) for x in sadata.obs.index]
    uadata.obs.index=[re.sub('-[0-9]','',x) for x in uadata.obs.index]
    sadata.obs=sadata.obs.drop('batch',axis=1)

    sadata.layers['unspliced']=uadata.X
    sadata.layers['spliced']=sadata.X
    sadata.layers["ambiguous"] = scipy.sparse.csr_matrix(np.zeros(sadata.X.shape))
    return(sadata)

Would you be able to share one of the output files from CellBender? I might be able to see if there's anything obvious we can do there.
At the moment I suspect the best thing we can do here is have more informative errors.

in case you're still interested in this  - whenever that happens I write the adata.obs to a csv, then import that csv and set the index, (the dtypes solve themselves magically), set that as adata.obs and then write h5ad.
In my case this happens whenever Im filling any Nans, then pandas gets confused about dtypes, and manually fixing dtypes never works.
adata.obs.to_csv(directory+"temporary.csv")
    metada = pd.read_csv(directory+ "temporary.csv")
    metada.set_index("cellID", inplace = True)
    adata.obs = metada
    adata.write_h5ad(directory+o+".h5ad")

maybe that helps someone whos googling for the same error

in case you're still interested in this - whenever that happens I write the adata.obs to a csv, then import that csv and set the index, (the dtypes solve themselves magically), set that as adata.obs and then write h5ad. In my case this happens whenever Im filling any Nans, then pandas gets confused about dtypes, and manually fixing dtypes never works.
adata.obs.to_csv(directory+"temporary.csv")
    metada = pd.read_csv(directory+ "temporary.csv")
    metada.set_index("cellID", inplace = True)
    adata.obs = metada
    adata.write_h5ad(directory+o+".h5ad")

maybe that helps someone whos googling for the same error

This didn't work for me sadly :(

in case you're still interested in this - whenever that happens I write the adata.obs to a csv, then import that csv and set the index, (the dtypes solve themselves magically), set that as adata.obs and then write h5ad. In my case this happens whenever Im filling any Nans, then pandas gets confused about dtypes, and manually fixing dtypes never works.
adata.obs.to_csv(directory+"temporary.csv")
    metada = pd.read_csv(directory+ "temporary.csv")
    metada.set_index("cellID", inplace = True)
    adata.obs = metada
    adata.write_h5ad(directory+o+".h5ad")

maybe that helps someone whos googling for the same error

as someone who's googling for the same error, your solution worked great!

@cdpolt
isnt it the simple thing that if you have NaNs then the column is categorical? both column names and column values hav e to be strings - sometimes asomething as simple as this:
adata.obs = adata.obs.astype(str)
adata.var = adata.var.astype(str)
will fix all issues. You cannot have a categorical dtype - and as soon as you have 1 NaN thats a category column in pandas., so you have to change it one way or another?


Dev Home not "updateing" starting, stuck at 90% for hours - 2 different machines

Dev Home version
No response
Windows build number
22621.2428
Other software
No response
Steps to reproduce the bug
I discovered yesterday "dev home" in my start menu :-). So i clicked on in.
But the process stalls at 90% - after an hour i shut down my pc. This was on my Desktop PC at home. Today i tried the same on my Working Laptop and here i observe the same:

Is there a way to fix this? i am really eager to try dev home.
Expected result
The update finishes, dev home starts.
Actual result
stall at 90%
Included System Information
No response
Included Extensions Information
No response

Had this issue just minutes ago. I closed the app and restarted it, download resumed and everything went fine.

Same issue here, 90% forever... No CPU nor DISK activity.

Same here. It just stucked at the "dev home needs and update message". It doesn't even starts the update.

someone get a fix ?

Stuck on 77% on UniGetUI !!!
Starting package install...
The installer will request to run as administrator, expect a prompt.
Successfully installed
Successfully verified installer hash
Starting package install...

███████████████████████▒▒▒▒▒▒▒  77%

Buongiorno.
Sono assente, rientrerò in ufficio il giorno 07/01/2025.
Franco Perana
Ufficio Sviluppo PC

Hossam Gamal Mostafa @.***> 25/12/2024 15:55 >>>

Attenzione: Questa email arriva da un mittente insolito.
Attenzione: Assicurati che sia qualcuno di cui ti fidi.
Stuck on 77% on UniGetUI !!!
Starting package install...
The installer will request to run as administrator, expect a prompt.
Successfully installed
Successfully verified installer hash
Starting package install...

******************************  77%

--
Reply to this email directly or view it on GitHub:
https://urlsand.esvalabs.com/?u=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fdevhome%2Fissues%2F1682%23issuecomment-2561919516&e=145a206a&h=43c73c21&f=y&p=y
You are receiving this because you commented.
Message ID: @.***>
STUDIO CENTRO SRL - Soluzioni e Servizi - www.studiocentro.it
Sede: 36100 Vicenza - Via Luigi Boccherini, 13 Tel. 04<IP_ADDRESS> Fax 04<IP_ADDRESS> email: @.***
Certificazione ISO/IEC 27001:2013 del 27/12/2018 N°.<PHONE_NUMBER>-AIS-ITA-ACCREDIA


Proper use of Path.Join

Fix test failure on Linux by removing backslash.
Message was:
System.IO.FileNotFoundException : Could not find file 'charls-native-dotnet/bin/Debug\DataFiles\t8c0e0.jls'.

@vbaderks I split PR #2 . Could you please merge this trivial fix ? thanks


Text truncated in FK input

In recordedit, when a FK value is selected and the value is longer than the input box, the content flows down to the next line outside of the input box.
See image below:

This issue has been fixed by allowing the FK input box to grow if the selected value spans multiple lines.


Load ~10e6 bundles with recent metadata versions

Need

As a UX researcher for the Query Service
I want some real-life bundle metadata in the system
so that I can show non-trivial use cases to users.

Approach

[x] Query some recent metadata (Tabula Muris, SpaceTx, the preview datasets) from DSS
[x] Load them with the ETL module into the database
[x] Make the credentials available to @GenevieveHaliburton and test users
[ ] Reach significant scale to understand performance characteristics

Currently loaded: 103632 bundles from the CBeta test datasets

The remainder of this work is duplicated by https://app.zenhub.com/workspaces/dcp-5ac7bcf9465cb172b77760d9/issues/humancellatlas/query-service/19
Closing this.


Ability to trigger calendarChanged from external widget

Hi, It would be very nice if calendar support change month or date from external ( maybe calendar controller that provide this function )
I develop a widget need to trigger an event that change the calendar to a specific month.
BTW, many thank it's one of the best calendar widget

@kakakhang Hi! Thank you for bringing up the issue. I don't quite understand how would you like our plugin to become. Could you be a little more specific?

Hi @hyochan,
For instance: I have a button in my widget and I want to change the calendar to the next month or previous month by clicking on my button.
CalendarCarousel(
calendarController: _controller,
}
The calendarController hold a set of your widget public api.
On my button:
onPress() {
_controller.changeMonth(DateTime(2020,01,01)) // targetmonth
// or something like that
_controller.goToNextMonth();
}
Thank you!

What if changing targetDate as in example?

@hyochan  Thanks for your help. Now it works well.
The last couple of day,  I had tried with targetDateTime and I got the error because I didn't specify the minSelectedDate, maxSelectedDate ( I did not realize the relationship between these params )
The getter 'year' was called on null.
Receiver: null
Tried calling: year


[Bug]: The dark:border-dark-200 class name is not work

Version
In the current repo.

Details
The dark:border-dark-200 class name is not work:

Reproduce link
https://github.com/web-infra-dev/rspress
Reproduce Steps

cd packages/document
pnpm run dev

it seems like the dark color variant is not missing in both tailwind.config.ts and vars.css
I would like to make a PR for it if I have design tokens for dark color.

I have

it seems like the dark color variant is not missing in both tailwind.config.ts and vars.css
I would like to make a PR for it if I have design tokens for dark color.

I think it's neccessary to add dark color in design tokens too.Thank you.

it seems like the dark color variant is not missing in both tailwind.config.ts and vars.css
I would like to make a PR for it if I have design tokens for dark color.

I think it's neccessary to add dark color in design tokens too.Thank you.

Well, it's kinda design based issue, I will leave it for you guys, Thanks for the reply.

I have fix the problem in current main branch.


Find a Designer

I'm posting this here as it's an open issue for Warehouse, and to try and get some visibility to hopefully find someone who is willing to help. The criteria to close this is basically, finding a designer who can help us!
Essentially the problem here is that I am not a designer, however Warehouse needs a designer. Ideally what I would like to find is someone who can act as a sort of "Lead" Designer kind of role and has the requisite skills to really make Warehouse something great.
If I'm able to find the right person, I'd like to give them carte blanche over the design of Warehouse. This includes tooling, the process, and the actual design itself as long as it works within the general constraints of Warehouse itself. This will not be any sort of design by committee or where you'll need to get approval for each little thing done, the buck will stop with you!
If you're someone who is interested, you can come into the process at any time. Right now there's some basic framework done for some parts of Warehouse but there isn't all of the functionality or pages it's going to need. If you want to jump in and evolve the design as Warehouse progresses, then now is the time to do that. Alternatively if you want to wait until it's mostly feature complete for the deployment to production, and then come in and work from there, we can do that as well!
Sadly, there isn't anything in the form of compensation easily available here. Warehouse is primarily being driven forward by me right now, and I'm just some guy. I don't personally have the funds to pay for someone's time. However, if you're the right person, I'm totally willing to help craft a proposal to the PSF to ask for a grant to see if they'd be willing to fund a grant for this work as well. Beyond that, the best I can offer is some good feelings on helping to make what will become PyPI look great.
I'm going to lock the comments on this thread, because I don't want people to volunteer on a public issue tracker. Instead if you'd be willing to email<EMAIL_ADDRESS>so I can privately look over anyone who offers to volunteer and decide if they match what I'm looking for and discuss things with them that would be great!

I'm going to go ahead and close this since a designer has joined the team now and has started to take a look at and figure out how to make Warehouse great! Thanks to everyone who reached out to contact me :)


Reduce type constraints

This PR fixes the same issue that #231 was addressing. The PR didn't properly fix the issue.
The underlying problem was that TypeScript now requires an index signature for object types as currently used in the type constraint for ValidEventMaps.
The PR relaxes the type constraint to allow arbitrary object types. The event emitter will recognise all keys K of the object type T as event names.
The existing behaviour does not change: If the type T[K] is an array type, it is used as the type of the event args. If it is a function type, the parameter type of the function becomes the type of the event args.
The new behaviour is that for keys where T[K] is neither a function nor an array type, the argument type for the event K now becomes any[].
This fixes the bug and the relaxation should offer an acceptable compromise.

Here's an example:
import eventemitter3 from "eventemitter3";

interface MyEventMap {
  anEvent: () => void;
  anotherEvent: (a: number, b: string) => void;
  yetAnotherEvent: [string, number, boolean];
  invalid: string;
}

const ee = new eventemitter3.EventEmitter<MyEventMap>();

ee.emit("anEvent");
ee.emit("anotherEvent", 1, "");
ee.emit("yetAnotherEvent", "", 0, true);
ee.emit("invalid"); // works, but will suggest any[] for the event args
ee.emit("string"); // throws type error

const ee2 = new eventemitter3.EventEmitter<string>();
ee2.emit("anything"); // allows any event name and set of args

const ee3 = new eventemitter3.EventEmitter<"anEvent" | "anotherEvent">();
ee3.emit("anEvent"); // allows the "anEvent" event and any[] set of args
ee3.emit("anotherEvent"); // allows the "anotherEvent" event and any[] set of args
ee3.emit("invalid"); // throws type error

alternatively (using patch-package):
diff --git a/node_modules/eventemitter3/index.d.ts b/node_modules/eventemitter3/index.d.ts
index 769b427..5519d4c 100644
--- a/node_modules/eventemitter3/index.d.ts
+++ b/node_modules/eventemitter3/index.d.ts
@@ -94,7 +94,7 @@ declare namespace EventEmitter {
   export type ValidEventTypes =
     | string
     | symbol
-    | { [K in string | symbol]: any[] | ((...args: any[]) => void) | undefined };
+    | object;

   export type EventNames<T extends ValidEventTypes> = T extends string | symbol
     ? T
@@ -113,7 +113,7 @@ declare namespace EventEmitter {
     K extends EventNames<T>
   > = T extends string | symbol
     ? (...args: any[]) => void
-    : (...args: ArgumentMap<Exclude<T, string | symbol>>[K]) => void;
+    : (...args: ArgumentMap<Exclude<T, string | symbol>>[Extract<K, keyof T>]) => void;

   export type EventArgs<
     T extends ValidEventTypes,

I don't use TypeScript so I don't know which one is better. I'll wait until tomorrow to keep discussion going. I would like to reach consensus on a single fix.

Here's my cleaner version, which doesn't go through ArgumentMap to get a single event's parameters https://github.com/primus/eventemitter3/compare/master...forivall:fix/index-type-error-again

@forivall can you open a PR?

Thank you.


KOGITO-1756 + KOGITO-1779 - Support for Parallel State and fix for SubFlow state support

I cannot cherry-pick to 0.9.x (which is much needed) before https://github.com/kiegroup/kogito-runtimes/pull/435 is merged


set golangci-lint for 15 minutes to be same as jobset

What type of PR is this?

What this PR does / why we need it
Lint is failing on PRs.
Which issue(s) this PR fixes

Fixes #
Special notes for your reviewer
Does this PR introduce a user-facing change?

NONE

/lgtm
/approve

/hold
want to confirm "verify" job first.

/hold cancel


Add sttp to related project

The latest sttp release, 0.0.6, contains a circe extensions module.

Codecov Report

Merging #723 into master will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #723      +/-   ##
==========================================
+ Coverage   86.59%   86.67%   +0.08%
==========================================
  Files          71       71
  Lines        2267     2267
  Branches       91       88       -3
==========================================
+ Hits         1963     1965       +2
+ Misses        304      302       -2

Impacted Files
Coverage Δ

...rc/main/scala/io/circe/numbers/BiggerDecimal.scala
92.35% <0%> (+0.58%)
:arrow_up:

...re/shared/src/main/scala/io/circe/KeyDecoder.scala
100% <0%> (+2.7%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96d4196...315a152. Read the comment docs.

Thanks, @adamw, this is great!


Add code documentation.

The code is poorly documented. This will be resolved soon.

Yet need Unity and AI4UPE documentation.


Update Set-OrganizationConfig.md

Error in Example 6, this is a sting and to have the time set it need :

Docs Build status updates of commit 6fa306d:
:clock10: Full build: the average full build time is 14 min(s) 1 sec(s), this is based on the last 393 build(s) for this repository.

Docs Build status updates of commit 6fa306d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/organization/Set-OrganizationConfig.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit efd6cfd:
:clock10: Full build: the average full build time is 14 min(s), this is based on the last 398 build(s) for this repository.

Docs Build status updates of commit efd6cfd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/organization/Set-OrganizationConfig.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit bcbe017:
:clock10: Full build: the average full build time is 14 min(s), this is based on the last 401 build(s) for this repository.

Docs Build status updates of commit bcbe017:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/organization/Set-OrganizationConfig.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Failed restore

./inferius -d iPhone9,1 -i 12.4 -f iPhone_4.7_P3_12.4_16G77_Restore_custom.ipsw -r
verifying version
extracting restore.plist
extracting buildmanifest.plist
[ERROR] This FutureRestore cannot be used with Inferius. Exiting...

As per the README, you need to use a build of futurerestore that has been compiled with my fork of img4tool. Also, an iPhone 7 downgrade to 12.4 won't work anyways.


Add gen-stringify-test.go

After looking at the coverage details here: https://codecov.io/gh/google/go-github/tree/master/github
and noticing that the String methods account for a non-trivial percentage of uncovered code, I decided to write some.
Then, after writing a couple tests by hand, I realized that this is another great opportunity for go generate to write this mundane code for us and put it in a test file that nobody needs to care or worry about (github-stringify_test.go).
Getting these trivial functions out of the way, I believe that the coverage details will now have more meaning and we can more clearly identify and focus our attention on methods that need better test coverage.

friendly ping @gauntface

Thank you, @gauntface!
Merging.


Fix routing

Accessing an external source like RFD and then use browser's history arrows to go to the previous page is not working properly

Finish cleaning up internal routing


Upgrade Argo >= 3.5

Is your feature request related to a problem? Please describe.
It would be great to upgrade the Argo Models to >= 3.5 version as we need to use pod_gc with deleteDelayDuration field which exist only in >= 3.5 version.
Describe the solution you'd like
We wanted to leverage deleteDelayDuration feature in pod_gc which is available in >= 3.5 version.
Ref link - https://github.com/argoproj/argo-workflows/blob/main/examples/pod-gc-strategy-with-label-selector.yaml
Describe alternatives you've considered
Currently I don't have any alternative.
Additional context
Add any other context or screenshots about the feature request here.

I was about to create a ticket when I ended up finding this open ticket. I too wanted to use "deleteDelayDuration" and found it wasn't part of the model yet.

I think I misunderstood the nature of this issue. Do we need a new issue to update the PodGC model to support the "deleteDelayDuration" field?
https://github.com/argoproj-labs/hera/blob/5.15.0/src/hera/events/models/io/argoproj/workflow/v1alpha1.pyi#L521


Adds opt plotter for opt mode

Pull Request Description
What issue does this change request address?
Closes #93
What are the significant changes in functionality due to this change request?
Adds an optimization path plotter to opt mode cases.

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[x] 1. Review all computer code.
[x] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[x] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[ ] 4. Automated Tests should pass.
[x] 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large tes.
[x] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync.
[x] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[x] 8. If an analytic test is changed/added, the the analytic documentation must be updated/added.
[x] 9. If any test used as a basis for documentation examples have been changed, the associated documentation must be reviewed and assured the text matches the example.

Job CentOS 8 on 510ed94 : invalidated by @dylanjm
Looks like fetch timed out -- Restarting test

Tests passed on this one now, FYI. There was a fetching bug before.


mnist cnn on vision kit

hi, it's possible to train and deploy a "homemade" cnn to run on the vision kit?
i have trained a model like this: https://github.com/tensorflow/docs/blob ... /cnn.ipynb
the bonnet compile return me this error:
2019-03-17 19:53:04.396130: I external/org_tensorflow/tensorflow/contrib/lite/toco/graph_transformations/graph_transformations.cc:39] Before Removing unused ops: 31 operators, 48 arrays (0 quantized)
2019-03-17 19:53:04.396533: I external/org_tensorflow/tensorflow/contrib/lite/toco/graph_transformations/graph_transformations.cc:39] Before general graph transformations: 31 operators, 48 arrays (0 quantized)
2019-03-17 19:53:04.396601: F external/org_tensorflow/tensorflow/contrib/lite/toco/graph_transformations/propagate_fixed_sizes.cc:347] Check failed: output_depth == input_depth * op->depth_multiplier (1 vs. 0)input/output depths and depth_multiplier don't match
what i can do?
does the vision kit only support the mobilenet model? is the only way to retrain the mobilenet and transfer learning?
thanks

Please see the detailed documentation at https://aiyprojects.withgoogle.com/vision/#makers-guide--tensorflow-model-compiler regarding the limitations that bonnet_model_compiler has.

hi, it's possible to train and deploy a "homemade" cnn to run on the vision kit?
i have trained a model like this: https://github.com/tensorflow/docs/blob ... /cnn.ipynb
the bonnet compile return me this error:
2019-03-17 19:53:04.396130: I external/org_tensorflow/tensorflow/contrib/lite/toco/graph_transformations/graph_transformations.cc:39] Before Removing unused ops: 31 operators, 48 arrays (0 quantized)
2019-03-17 19:53:04.396533: I external/org_tensorflow/tensorflow/contrib/lite/toco/graph_transformations/graph_transformations.cc:39] Before general graph transformations: 31 operators, 48 arrays (0 quantized)
2019-03-17 19:53:04.396601: F external/org_tensorflow/tensorflow/contrib/lite/toco/graph_transformations/propagate_fixed_sizes.cc:347] Check failed: output_depth == input_depth * op->depth_multiplier (1 vs. 0)input/output depths and depth_multiplier don't match
what i can do?
does the vision kit only support the mobilenet model? is the only way to retrain the mobilenet and transfer learning?
thanks

Have you solved the problem? Exactly the same problem here


Import newest go-etcd

The etcd team fixed the lib and it now reports better errors instead of everything being "501 attempted to connect to each peer twice".  We should import that ASAP

I'll hack a crack at this. Given my penchant for breaking things I assume I am the ideal candidate.


[FLINK-36521][runtime] Introduce TtlAwareSerializer and TtlAwareSerializerSnapshot

What is the purpose of the change
Introduce TtlAwareSerializer and TtlAwareSerializerSnapshot to resolve the compatibility check between ttlSerializer and original serializer
Brief change log
(for example:)

Add serializer-snapshot and test-data for TtlAwareSerializerUpgradeTest
Introduce the implementation of TtlAwareSerializer and TtlAwareSerializerSnapshot
Introduce the implementation of TtlAwareSerializerSnapshotWrapper

Verifying this change
This change added tests and can be verified as follows:

Added Unit Test in TtlAwareSerializerTest
Added Unit Test in TtlAwareSerializerTtlMigrationTest
Added Unit Test in TtlAwareSerializerUpgradeTest
Added Unit Test in TtlAwareSerializerSnapshotWrapperTest

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: yes
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no

@flinkbot run azure

@flinkbot run azure

@Zakelly hi, all comments have been resolved. Would you kindly take a look when you have time?


lang: Consider removing associated keyword

We should consider removing the associated keyword. I'm a little worried the automagic of adding the __nonce field will cause problems when upgrading account layouts. For example, if one were to add fields to an account, then it's possible one overwrites the __nonce field.
Instead of removing, we can also consider adding a header to the account layout to store such metadata. For example, discriminator || metadata || borsh(struct) or some variant.
Note that seeds can do everything associated can, although it requires manual nonce management/storage. So it's recommended to use seeds until the future of associated is decided.

We need to change JS api. Is it ok to left associatedAddress but change the returned value to Promise<[PublicKey, number]> or we need to create a new method?

We need to change JS api. Is it ok to left associatedAddress but change the returned value to Promise<[PublicKey, number]> or we need to create a new method?
seed instead associated need add b"anchor".as_ref() each time to the seed, should we add it magically in generated code?

No need to create a new api. We can just remove the associated apis from the js client and use the standard PublicKey.findProgramAddress and PublicKey.createProgramAddress from @solana/web3.js.
This isn't necessary because seeds = [<>] in the program doesn't add any seeds. Note that associated = <> added b"anchor" as a prefix to seeds for domain separation, so that seeds wouldn't conflict in the event that one accidently used both associated and seeds in the same program. If we remove associated this is no longer required. Domain separation should be done explicitly, if needed.

Seems fine to me to remove the associated macro.
I do think the most annoying part about using PDAs is dealing with the bump seed, which just seems awkward to pass through. I like the idea of including space for the bump seed in the account header, perhaps for all accounts since its just one byte. That way for account initialization, anchor could use findProgramAddress based on the provided seeds and store the bump inside the header, then for post-init constraint checks it could use createProgramAddress and refer back to the bump seed stored in the account header.


Spotting players from a far distance that they are not wearing seatbelts.

I'm not getting any errors but yesteday i spotted my friend not wearing a seatbelt when he was far away from me, and he spotted me too from far distance. Not sure if its because we are using bliptags, /duty.

What is your server build version?
Which OneSync are you using?
Can you estimate the distance?

Server build

Onesync is just set to onesync on
Can't estimate distance

That's the game build, not your server build.


test/gst-vaapi/vpp: don't use deprecated properties

The width, height and format properties are being
deprecated.  Use a caps filter instead.
See https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/289
NOTE: this also removes explicit width and height usage
for deinterlace cases.  Removing those parameters exposes
a possible issue with mpeg2 deinterlace that needs further
triage.
Signed-off-by: U. Artie Eoff<EMAIL_ADDRESS>

It looks good to me!


[SPARK-32581][CORE] update duration property for live ui application list and application api

What changes were proposed in this pull request?

"duration" property in response from application list and application APIs of live UI is always "0". we want to let these two APIs return correct value, same with "Total Uptime" in live UI's job page.
before change:

after change:

Why are the changes needed?

Let application list api and application api of live UI return same duration value with UI job page.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

tested manually.
updated UT.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

ok to test


Keep existing button items from current UINavigationItem

Previously SlideNavigationController replaced any bar button items of the presented view controllers navigation item.
I find that it would be better to add the menu buttons left and right of the existing buttons. (As an addition and not a replacement).

Closing and reopening a pull request with a different branch name, as I need to integrate other changes on the master branch of my fork


🐛 Bug Report - Country Search doesn't support locale changes

Bug description
When changing the locale, the country search does't work according to the language.
Code example
<ConfigProvider locale={locale('ptBR')}>
      <PhoneInput
        enableSearch
        onChange={onChange}
      />
</ConfigProvider>

Reproduction
No response
Browsers
Firefox, Chrome, Safari, Microsoft Edge, Opera
OS
Windows, Linux, Mac

@DougsSc, thanks for reporting the issue. It is fixed in the latest release.


Include all keptn versions in integration tests markdown report

There have been a few integration test runs where not all keptn version are displayed in the markdown report (both in the action run and in the related issues, for example:
this issue and the  related run do not include anything about the 0.17.0 release and prerelease runs.
All keptn version we test against should be displayed in the report regardless if they are "static" versions or dynamically discovered latest release and prerelease.

Just double checked, and it's because the 0.17 tests have failed too early during installation, and did write
{"Test": "TestGitHub Pipeline", "Action": "fail"}

into the test report, intead of an actual log. I guess that this case is not handled very well.


Data race

Hi
thank you for making this package.
I've been using it for a month or so now, and i noticed that i get data race error from  time to time
Fatal error: concurrent map writes

WARNING: DATA RACE
Write at 0x00c0007fa1e8 by goroutine 335:
  aidanwoods.dev/go-paseto.(*Token).Set.func1()
      C:/Users/m_ben/go/pkg/mod/aidanwoods.dev/go-paseto@v1.5.2/token.go:67 +0x7b
  aidanwoods.dev/go-result.Match[go.shape.struct { aidanwoods.dev/go-result.value aidanwoods.dev/go-result.Option[go.shape.interface {}]; aidanwoods.dev/go-result.err aidanwoods.dev/go-result.Option[error] },go.shape.[]uint8]()
      C:/Users/m_ben/go/pkg/mod/aidanwoods.dev/go-result@v0.1.0/result.go:105 +0xfd
  aidanwoods.dev/go-result.AndThen[go.shape.[]uint8,go.shape.interface {}]()
      C:/Users/m_ben/go/pkg/mod/aidanwoods.dev/go-result@v0.1.0/result.go:120 +0xe4
  aidanwoods.dev/go-result.ApplyToResult[go.shape.interface {},go.shape.[]uint8].AndThen()
      C:/Users/m_ben/go/pkg/mod/aidanwoods.dev/go-result@v0.1.0/chaining.go:14 +0x132
  aidanwoods.dev/go-paseto.(*Token).Set()

i solved it by using sync.mutex, but i don't know if that's the right solution or whether will it affect my backend performance.
i don't know if implementing syncmap.Map{} will fix this issue.

(Hey! I'm not the maintainer, just a user who saw your issue:)
This library neither uses Goroutines nor does any synchronization for you. The interface is therefore not thread-safe, which is why your application correctly trips the race detector.
If you call .Set() on a token from multiple Goroutines, then you need to explicitly synchronize access to it, just like with any other datastructure in Go. This is not an issue in this library. Using sync.Mutex is the right way to do that. Another way would be to structure your application so that only a single Goroutine constructs the token.

(Hey! I'm not the maintainer, just a user who saw your issue:)
This library neither uses Goroutines nor does any synchronization for you. The interface is therefore not thread-safe, which is why your application correctly trips the race detector.
If you call .Set() on a token from multiple Goroutines, then you need to explicitly synchronize access to it, just like with any other datastructure in Go. This is not an issue in this library. Using sync.Mutex is the right way to do that. Another way would be to structure your application so that only a single Goroutine constructs the token.

Hi
Thank you for your reply.
I already used sync.Mutex and i still get the same error.
I reverted back to o1egl/paseto package since it didn't have this problem.
I hope this issue get solved.

Please post a reproducer code snippet. We're a heavy user of this lib too so I'm interested in it having no critical bugs, would investigate it based on your code. The tests of the lib pass fine under the Go race checker in the environments I have here (Ubuntu 24.04 amd64, macOS 14.7 arm64).

I'll second the request for a repro snippet, ideally showing how you're using sync.Mutex to set properties on a token.
This library (like Go's own data structures such as map[_]_) isn't designed to handle data races transparently. Instead if you're using multiple goroutines to write to a single token, it would be up to you to impose locks to ensure concurrent writes don't happen.
Outside of race safety with the underlying data structures, concurrent writes may also cause issues (e.g. if two processes write to the same key, the order of writes would changes the end result). For this reason, I'm not sure it's possible for this library to make general promises about race safety (since there are logic problems that can occur, rather than just data structure related ones).

My codebase is quite large, so I'll work on producing a minimal code snippet when I get the chance. It might take a little while, as I'm tied up with other tasks at the moment, but I'll get back to you when I can.


Missing abstracts

If a titel and/or abstract is missing include a sentence like “No abstract available for this article”

@J535D165  this will be implemented in next release, right?

Closed in #210


Create new release tag

Hi,
Can you create a new release tag since the last one is from 2019? Thanks!

good idea, @polastre! just tagged v1.7.0


BigTable Float values incompatible with BigQuery?

Hi,
As recommended in issue 2614, I stored a timestamp in BigTable rows using the following python code:
row = table.row(some_key)
timestamp =<PHONE_NUMBER>.35388
byte_data = struct.pack('>d', timestamp)
row.set_cell(column_family.encode('utf-8'), # column_family
                    column_name.encode('utf-8'),  # column
                    byte_data                                    # value
                    )
row.commit()

It works fine and I am able to retrieve the value and unpack it.
However, I use BigQuery to query the same table - and the values encoded this way completely prevent querying the table, although the column names in question are not even part of the table definition:
SELECT * FROM `my_project.my_dataset.the_bigtable_table` LIMIT 1000

Error: Error while reading table: my_project.my_dataset.the_bigtable_table, error message: Invalid utf-8 encoding found At row:f68001aa9c573a1e920a4f908d27bb03392ea3cf, column_family:metadata, column:P1_end_walltime
The only workaround I could find is to scan all rows containing these columns, unpack them, convert them to string and re-encode them as utf-8. (Hope this will work)
Is that a bug or am I doing something wrong?
Thanks!

Per https://cloud.google.com/bigquery/external-data-bigtable#value_encoding BigQuery assumes two types, either text or HBase Bytes.toBytes(). From the error, it seems BigQuery is trying to interpret this column as strings.

Very clear, I missed that, thanks!


mm/kasan: replace load/store methods to macro

Summary
mm/kasan: replace load/store methods to marco
Impact
N/A
Testing
ci-check

Guys, although this is a good example where macro can be used to create code in a smarter way, I don't know if this is a good move. Have you seen "how NASA writes space-proof code": https://www.youtube.com/watch?v=GWYhtksrmhE
They have basically 10 rules (called "The Power of Ten") and one of those rules is to avoid using complex macro that makes code difficult to use with static analyze software.
No strong opinion about it, since we don't follow most of those 10 rules, but just to raise our awareness about it.

No strong opinion about it, since we don't follow most of those 10 rules, but just to raise our awareness about it.

@acassis Thanks for your suggestion. Actually this is the practice in the linux kernel. The macro expansion of kasan just removes the relevant redundant functions, which will be more clear for developers read the code.
https://github.com/torvalds/linux/blob/master/mm/kasan/generic.c#L238-L260


Bug: Should not focus on root element

Lexical version:
Steps To Reproduce

Open Playground
Remove all text and type ``` and space key
Type some text like 11111
Press Arrow Up Key multiple times

https://github.com/facebook/lexical/assets/16633962/25e84327-c799-4e6a-a178-0455c8520f82

The current behavior
You'll notice that the selection switches back and forth between the text node and the root node
The expected behavior
Just focus the text node only

Hi!
Thanks for noticing this. IMO it actually shall stick to root and stay there. Why? How else can you insert something before that code block? :)
Also cursor shall be placed before code block

It's turely work when we want to add text before code block, but it doesn't clear to tell user "now we can insert text before code block!" when focus the root element.
Because it seems exactly the same.
In my situation, my solution is then user press up, it will insert a paragraph before directly.
https://github.com/facebook/lexical/assets/16633962/f577fb46-cbef-4a32-a017-9307aa96c3ab
Speaking of which, why do I raise this question? It's to ensure that the focus can be correctly disengaged at the beginning of my editor (not the application shown in the video above).
Example
It's like we have a form, which has input , and a lexical editor, I want the user to be able to navigate between them by pressing the up arrow key.
However, the behavior differs when we focus on the code block, quote and offset is set to 0, it will make the code I write become complex, I believe this is an area that could be improved.
So I suggest, the selection can not be switch to the root element.


Enter input

big yikes
closes #12

:100:
I think this is a pretty big milestone. Aside from potential edge-case bugs, I think the typing behavior (codeWrapper) is pretty much good for now.
Gotta think about what we want to add next. Stats? Language selector & actually pass real code snippets (from our repo as a starter)?

I think passing code snippets from a random repo would be the next step


Try simplify

finally aim is to fix workaround because of this:
https://github.com/burn-rs/burn/issues/686

just revert this https://github.com/open-spaced-repetition/fsrs-rs/pull/26


Small typo in the GitHub website link

The 'l' and 'a' are around the wrong way.

Corrected, thank you!


Shortcodes not behaving the same with --minify flag than without

What version of Hugo are you using (hugo version)?

$ hugo version v0.83.1

Does this issue reproduce with the latest release?
Yes, my website has been deployed with GitHub Actions using 'latest' for the Hugo version, so I assume it used v0.85.0, which is the latest version right now and the problem occured there too.
The problem briefly explained
Building my site with the --minify flag makes my shortcodes behave slightly different. Precisely, there is no space between the word before the content wrapped into the shortcode layout and this content.
Without using --minify, the same Markdown yields different result (with a normal space, as expected).
See The problem in detail, Example 1 and Example 2 for further information and examples to reproduce the issue.
The problem in detail
I noticed that my shortcodes don’t behave the same in the deployed site (hosted with GitHub Pages, deployed with GitHub Actions as described in the official documentation) as in a local build (built locally with hugo server or hugo server -D, localhost).
In my locally built site, the shortcode behaves as expected. It’s a simple shortcode formatting the content of it. The only problem is, that even though I actually added a space between the text and the declaration of the shortcode (see examples below), it doesn’t add a space in the deployed site on GitHub Pages, whereas it behaves as expected in a locally built site.
After a conversation with @bep on the Hugo forum, we came to the conclusion that it's most likely an issue with the built-in minifier in Hugo, because I never used --minify in my local builds, whereas the action deployed the page with GitHub pages using --minify. That's why I'm creating this issue. Going even further, I tried to use --minify for my local build (hugo server --minify in the command line) and I managed to reproduce the issue on a local build too.
Example 1

Markdown content (inside a simple block of text):

Apart from the {{<link `index.html` `_blank`>}}official API reference{{</link>}}

Shortcode link.html:

{{ $p0 := .Get 0 }}
{{ $p1 := .Get 1 }}
{{ $inner := .Inner }}
{{$inner}}

Without --minify (expected result, with space):

With --minify (unexpected result, without a space between the and official API reference):

Example 2

Markdown content (inside a simple block of text):

The {{<codeline>}}[SerializeField]{{</codeline>}} attribute makes sure that the field is exposed to the inspector

Shortcode codeline.html:

{{ .Inner }}

Without --minify (expected result, with space):

With --minify (unexpected result, no space between The and [SerializeField]):

First,  does not belong here. It must be the first child of the  element.
See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/head.
Second,

official API reference

You have a


Upgrade to latest lpc845-pac release

Blocked until next version is release. See https://github.com/lpc-rs/lpc-pac/pull/45.

(excluding the git dependency thing, of course)

Removed the Git dependency. Merging.


Issue 49 remove exists forall

Proposed changes
Regarding the issue #49 following changes were made to remove/deprecate the functions exists and forall functions from the codebase.

Remove exists and forall functions from quinn/functions.py.
Remove import statements for exists and forall from quinn/__init__.py.
Remove tests related to exists and forall functions from tests/test_functions.py.

Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Further comments

Hope this helps with one step towards the v1.0 plan for quinn.

@SemyonSinchenko - I have created this PR pointing to the planning-1.0 branch. Please let me know your thoughts?

Are you able to merge this PR @SemyonSinchenko ?


Can't use the lib in nodejs

Hello, I'm trying to run my code on nodejs to test in a terminal but I got this error :
ReferenceError: Worker is not defined
Is it possible to use the package web-worker ? Will try it on a fork.
https://github.com/developit/web-worker
https://github.com/KnicKnic/WASM-ImageMagick/blob/master/src/magickApi.ts#L190-L193
Thanks :)

Currently facing the same issue on Node.js, is there any workaround for this?

wasm-imageMagick's example codes on npm are still not working on node environment. Anybody solved this issue yet?

This should work:
// Expose Worker threads to globals
import { Worker } from "worker_threads";

// Expose Worker globally
declare const globalThis: any;
class NWorker extends Worker {
  constructor(path: string, options?: any) {
    super(
      path.replace("/wasm-imagemagick/src/", "/wasm-imagemagick/dist/"),
      options
    );
  }
}
globalThis.Worker = NWorker;

export async function RunCommand(url: string) {
  const ImageMagick = await import("wasm-imagemagick");
  const res = await ImageMagick.call(
    [await ImageMagick.buildInputFile(url, "icon")],
    ["identify", "-verbose", "icon"]
  );
  return res;
}


Update tests for redis and email urls

django-cache-url and dj-email-url recently partially changed their behavior.
We should update our tests to reflect the changes.
In detail, the following changes have been made:

django-cache-url now uses djangos native redis backend for django>4
dj-email-url added support for the EMAIL_TIMEOUT setting which defaults to None

Ping.


Cinnamon desktop: cannot install or update user-installed applets, desklets, extensions, ...

Describe the bug
I have user-installed Cinnamon applets, desklets, extensions, themes, which have been installed in the home folder by a different OS (as far as i remember). Many of them work under NixOS (some do not: #129963). However, i cannot update them. When i try, i get the message:

No such file or directory: 'msgfmt'

The same happens if i try to install a new applet.
Steps To Reproduce
Steps to reproduce the behavior:

Set up Cinnamon desktop on NixOS and log in.
Try to install an applet.

Expected behavior
Should be able to install and update user-installed applets, desklets, extensions, themes.
Screenshots

Additional context
I am just beginning to switch over to Cinnamon from GNOME 3 (having been fed up with GNOME, especially under NixOS).
Notify maintainers
@mkg20001
Metadata
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.10.110, NixOS, 21.11 (Porcupine)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.3.16`
 - channels(alexey): `""`
 - channels(root): `"nixos-21.11.337053.2f06b87f64b"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Installing gettext that provided msgfmt solved the issue. Shouldn't gettext then be a dependency of Cinnamon desktop then?


Proceed or precede?

Did you mean the word "preceding" rather than "proceeding" in the following sentence: " This level (and all proceeding levels) of peer associated hubs behaves the same way as the first level. "
To me, the word "preceding" suggests that the levels 1 and 2 sites will be included in search scopes when searching in levels 1, 2, or 3. The word "proceeding" suggests that levels beyond 1, 2, and 3 (i.e., 4, 5, and so on) will be included in search scopes, but as the follow-up sentence in the article says, that's not the case.
If the word "proceeding" is actually correct, could you clarify what's meant by "behaves"? Thank you! - tom

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: c98d42c3-a275-25a1-efbf-03a383c511c1
Version Independent ID: 7de4ec5f-4a1d-651f-1ace-6d3f62cbf89a
Content: Associate a hub site to another hub site in the SharePoint admin center - SharePoint in Microsoft 365
Content Source: SharePoint/SharePointOnline/hub-to-hub-association.md
Service: sharepoint-online
GitHub Login: @MattEEvans
Microsoft Alias: matteva

Thanks for the feedback. I think it should say "preceding" as Tom suggested.


Make TensorRT convert_nodes.cc C++11 conforming, fixing build under GCC 8

Make TensorRT convert_nodes.cc C++11 conforming, fixing build under GCC 8.
GCC 8 (correctly) complains that lambdas are not literals in C++11 and therefore cannot be "constexpr". Fix is trivial.
Elided GCC 8 diagnostics follow.
tensorflow/compiler/tf2tensorrt/convert/convert_nodes.cc:3960:3: error: the type '...::<lambda(nvinfer1::ITensor*, bool)>' of 'constexpr' variable 'get_matrix_op' is not literal
};
^
...because:
[](nvinfer1::ITensor* in, bool transpose) -> nvinfer1::MatrixOperation {
^
cc1plus: note:   ...::<lambda(nvinfer1::ITensor*, bool)>' is a closure type, which is only literal in C++17 and later

Quick note: This one-line change cannot possibly affect the "Ubuntu Python2" build.


 This causes repressurisation to be almost impossible and require player intervention to manually unlock vents.
Reproduction

Somewhat difficult to reproduce reliably but it seems to occur after 'large' explosions (ranging from meteors to syndiebombs at the edges of the station), which will cause lockouts in a much larger radius. Needs further testing to check air alarms and pressure readings.

Its partially caused by very high lockout pressure(like 20% loss already can lock most vents) but also by maps lack of airlocks to protect the atmos, little bit of spacing and half of station atmos are gone at times, bonus points if there is no power for some reason and the smart spessmen do not lock maints as usual.
If nearby sets of airlocks were connected to eachother and set to close they could greatly reduce atmos drain while still not slowing crew too much as they go on their daily lives and spacing station via maints.
Then we have firelocks that often are poorly placed, on door or literally adjacent to door so you can't create small pocket to open from without spacing bigger parts of station. 1-3 tiles of space between firelock and airlock/another firelock set would save stations a lot of atmos and lockouts.

Really vent lockouts should be tied to firelocks and checking if the room is airtight before unblocking

As AI, I could not agree more. Perhaps it should even bolt while in fill mode as safety measure.

After discovering how this system works myself, I fully agree it is really, REALLY bad for station operation unless you have an insanely cracked Atmospherics Technican running around manually repressurizing everything
The vent lockout should definitely be set MUCH lower so only rooms which are either obviously spaced or next to a breach don't get refilled. It's not normal that a few people quickly forcing a firelock causes the entire hallway to become permanently depressurized
It's also a bit weird that the only way to fix this is to intentionally set the air alarm to Fill or screwdriver the vent repeatedly. You really have to be VERY aware to see the yellow vent or know what it means, and nowhere are you told that screwdrivering the vent allows you to refill the room if you can't access the alarm. It doesn't even tell you what you did when do end up screwdrivering it!

It's also a bit weird that the only way to fix this is to intentionally set the air alarm to Fill or screwdriver the vent repeatedly. You really have to be VERY aware to see the yellow vent or know what it means, and nowhere are you told that screwdrivering the vent allows you to refill the room if you can't access the alarm. It doesn't even tell you what you did when do end up screwdrivering it!

So, what exactly screwdriving does? Forces fill for X seconds? Till air alarm changes it again?

It's also a bit weird that the only way to fix this is to intentionally set the air alarm to Fill or screwdriver the vent repeatedly. You really have to be VERY aware to see the yellow vent or know what it means, and nowhere are you told that screwdrivering the vent allows you to refill the room if you can't access the alarm. It doesn't even tell you what you did when do end up screwdrivering it!

So, what exactly screwdriving does? Forces fill for X seconds? Till air alarm changes it again?

I was literally just told this by a developer, and apparently it disables the lockout for like 10 seconds maximum. But it allows someone without air alarm access to manually refill their room

it's intentionally set high, without this the vent just never becomes space and keeps voiding air even if there's a breach nearby

Okay PR #29504 explains why lockout occurs so easily - it's because the threshold is 80 kPa

theres an ancient pr to make lockout smarter

Can you link it

ye ancient PR #29493


Consider enabling Maxicode optimal encoding by default

Just adding a feature request to justify #279 ;-)

I think we're done here?

Done in 414be1e.


resample.c: remove unused variable

minor change to remove an unused variable

Thanks for the patch!  This file (and everything in src/speex) is imported from the upstream speexdsp project (https://github.com/xiph/speexdsp), so I'd prefer not to merge this as-is.  Two options to consider:

Submit your fix upstream and then update cubeb's import once the fix is merged.
Change cubeb's build system to disable warnings for src/speex.

Oh word. Thanks for pointing me the right way I'll head over there!

Thanks!  I've imported your fix from upstream via a8460cb504506e3c0e7dc4224d8993a8e64c0367.


Typo

[Enter feedback here]
It should be 'your' instead of 'you'.
"If you data or the clients are placed in multiple regions, you can create separate workspaces in different regions co-located with your data and clients."

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8a819f2a-490b-0cdd-7d95-21139a20f4ff
Version Independent ID: 181a621d-0e83-af7d-cb8a-7e63f3195604
Content: Quickstart: Get started - create a Synapse workspace - Azure Synapse Analytics
Content Source: articles/synapse-analytics/get-started-create-workspace.md
Service: synapse-analytics
Sub-service: workspace
GitHub Login: @saveenr
Microsoft Alias: saveenr

Thanks for the feedback and bringing this to our notice. At this time we are reviewing the feedback and will update the document as appropriate.


Tooltips: don't replace spaces at the start of a line with \xA0

Get rid of the hack https://github.com/JetBrains/resharper-fsharp/pull/286#discussion_r667197766
This also fixes the following issue
Before

After

@saul Thanks again for pointing!


upper triangles is missing and lit shader issue at unity 2022

Hi. Good plugin but there are few issues(i use unity 2022.3.7f1):
geometric shader doesn't create Upper(usually) triangles. Probably it is intended behaviour(cardboard look) but i fixed it locally
there are fixes if someone is looking for it:
[maxvertexcount(24)] //chnaged from 18 to 24
void geom_standard(triangle v2g IN[3],inout TriangleStream<g2f_standard> triStream)

and added to the end of method:
    //Draw Cardboard Side
    v.pos = UnityObjectToClipPos(v2);
    v.texcoord = float3(v1dtex0,1);
    triStream.Append(v);

    v.pos = UnityObjectToClipPos(v1);
    v.texcoord = float3(v0dtex0,1);
    triStream.Append(v);

    v.pos = UnityObjectToClipPos(v1 + normal);
    v.texcoord = float3(v0dtex1,1);
    triStream.Append(v);

    triStream.RestartStrip();

    v.pos = UnityObjectToClipPos(v1 +  normal);
    v.texcoord = float3(v0dtex1,1);
    triStream.Append(v);

    v.pos = UnityObjectToClipPos(v2 + normal);
    v.texcoord = float3(v1dtex1,1);
    triStream.Append(v);

    v.pos = UnityObjectToClipPos(v2);
    v.texcoord = float3(v1dtex0,1);
    triStream.Append(v);

    triStream.RestartStrip();

shadow casting works fine
lit shader doesn't work at all. just show nothing. changing Tags {"LightMode"="Deferred"} to Tags {"LightMode"="UniversalGBuffer"} doesn't help. if i change to forward rendering i have grey mesh
using frag_lit instead of  frag_deffered_lit seams ok for me(at least front and back) but no shadow receiving

Tags {"LightMode"="UniversalGBuffer"} + dereffered in urp settings give white texture


THRIFT-3746 JSON protocol left in incorrect state on read errors

This is related to THRIFT-3735, but the problem was not fully addressed
there. The JSON protocol's read buffer needs to be reset to avoid being
put in an invalid state on read errors.
This also changes how the writer is reset to match what we do with the
reader for consistency.

LGTM
@Jens-G any concern for this ?

It seems that this change makes corss tests for Go server with JSON protocol + Buffered transport flaky.
A normal RPC call right after oneway call sometimes fails to respond.
@tylertreat-wf do you have any idea how this happens ?

@nsuke Interesting, I'm not entirely sure why this would be happening. I would expect the writer reset to be a safe operation to perform on WriteMessageBegin.


Reverting "Updating swagger-ui to the latest version #10902"

Reverting #10902 to fix the OOM issues: https://github.com/GoogleCloudPlatform/kubernetes/issues/11852
Revert "Merge pull request #10902 from nikhiljindal/gh-pages"
This reverts commit 3020fe8ebfbb9ee0a1f76fd9afb09b8d577e420e, reversing
changes made to de15703af096cad38d40361d696e236d197895cf.

@satnam6502 thanks for pumping the priority on merging this one. It bites me today too. :-)


Fatal error: Cannot declare class OpenAI, because the name is already in use in E:\Xampp_8.2\htdocs\ia\vendor\openai-php\client\src\OpenAI.php on line 8 [Bug]:

Description
Installing and testing the repo I get this error: Fatal error: Cannot declare class OpenAI, because the name is already in use in E:\Xampp_8.2\htdocs\ia\vendor\openai-php\client\src\OpenAI.php on line 8
Steps To Reproduce
using the example code on home page i get this error
OpenAI PHP Client Version
v0.8.5
PHP Version
8.2
Notes
No response

I have the same issue, and I couldn't find the answer yet.

My issue was that I used use OpenAI\OpenAI;
Fixed with use OpenAI;


Remove alternate image extraction from SMK, fix foreign landing URL

Fixes

Fixes #875 by @AetherUnbound
Description

This PR accomplishes two changes for SMK:

Removes the extraction of alternative images - see #875 for the rationale
Fixes an issue where the constructed foreign landing URL had a space in it

For the latter case, many of these URLs must have a space in them it turns out! But I'm not sure how everything downstream would handle a URL that's technically a valid URL if you paste it into a browser (since most convert spaces these days) but doesn't use the correct encoding. The new change will explicitly encode them so they're in a valid state throughout our datastream.
Example data before:
+------------------------------------------------------+------------------------------------------------------------------------------+
| foreign_landing_url                                  | url                                                                          |
|------------------------------------------------------+------------------------------------------------------------------------------|
| https://open.smk.dk/en/artwork/image/KKS7055 verso   | https://api.smk.dk/api/v1/thumbnail/0386f6f1-f6b6-4b02-af0d-62242df35d0d.jpg |
| https://open.smk.dk/en/artwork/image/KKS9203 verso   | https://api.smk.dk/api/v1/thumbnail/040c1cb6-1923-4238-a71c-08ff13ac616a.jpg |
| https://open.smk.dk/en/artwork/image/KKS6537 verso   | https://api.smk.dk/api/v1/thumbnail/00aa9d7a-a17e-4721-9ce8-56c921879d1c.jpg |
| https://open.smk.dk/en/artwork/image/KKS7819 verso   | https://api.smk.dk/api/v1/thumbnail/011dcedd-106d-4206-ad23-6b0a3895c9dc.jpg |
| https://open.smk.dk/en/artwork/image/KKS7081/2 verso | https://api.smk.dk/api/v1/thumbnail/00975050-5950-4b6b-802f-44f9d0e020d8.jpg |
| https://open.smk.dk/en/artwork/image/KKS7829 verso   | https://api.smk.dk/api/v1/thumbnail/00383e3a-54b1-499c-a5de-7671ddc87860.jpg |
| https://open.smk.dk/en/artwork/image/KMSB 36 101.7   | https://api.smk.dk/api/v1/thumbnail/00699228-b5aa-45b6-9329-f3861a9b731b.jpg |
| https://open.smk.dk/en/artwork/image/KKSgb4576 verso | https://api.smk.dk/api/v1/thumbnail/007cdf70-872a-4f47-b554-2b3fdaf598bf.jpg |
| https://open.smk.dk/en/artwork/image/KMSB 15         | https://api.smk.dk/api/v1/thumbnail/012931bc-01d4-48a3-b258-8d5710580583.jpg |
| https://open.smk.dk/en/artwork/image/KKS7445k verso  | https://api.smk.dk/api/v1/thumbnail/013ac45e-3d6e-48ba-b979-d32c8cdcc3f8.jpg |
+------------------------------------------------------+------------------------------------------------------------------------------+

Example data after:
+---------------------------------------------------------+------------------------------------------------------------------------------+
| foreign_landing_url                                     | url                                                                          |
|---------------------------------------------------------+------------------------------------------------------------------------------|
| https://open.smk.dk/en/artwork/image/KKS7829%20verso    | https://api.smk.dk/api/v1/thumbnail/00383e3a-54b1-499c-a5de-7671ddc87860.jpg |
| https://open.smk.dk/en/artwork/image/KMSB%2036%20101.7  | https://api.smk.dk/api/v1/thumbnail/00699228-b5aa-45b6-9329-f3861a9b731b.jpg |
| https://open.smk.dk/en/artwork/image/KKSgb4576%20verso  | https://api.smk.dk/api/v1/thumbnail/007cdf70-872a-4f47-b554-2b3fdaf598bf.jpg |
| https://open.smk.dk/en/artwork/image/KKS7081/2%20verso  | https://api.smk.dk/api/v1/thumbnail/00975050-5950-4b6b-802f-44f9d0e020d8.jpg |
| https://open.smk.dk/en/artwork/image/KKS6537%20verso    | https://api.smk.dk/api/v1/thumbnail/00aa9d7a-a17e-4721-9ce8-56c921879d1c.jpg |
| https://open.smk.dk/en/artwork/image/KKS7819%20verso    | https://api.smk.dk/api/v1/thumbnail/011dcedd-106d-4206-ad23-6b0a3895c9dc.jpg |
| https://open.smk.dk/en/artwork/image/KMSB%2015          | https://api.smk.dk/api/v1/thumbnail/012931bc-01d4-48a3-b258-8d5710580583.jpg |
| https://open.smk.dk/en/artwork/image/KKS7445k%20verso   | https://api.smk.dk/api/v1/thumbnail/013ac45e-3d6e-48ba-b979-d32c8cdcc3f8.jpg |
| https://open.smk.dk/en/artwork/image/KMSB%20150         | https://api.smk.dk/api/v1/thumbnail/01507fa2-9be8-473c-b455-44d83a171eef.jpg |
| https://open.smk.dk/en/artwork/image/KMSB%2038%20102.11 | https://api.smk.dk/api/v1/thumbnail/01aa3f8f-2630-47aa-9b48-56332f00d215.jpg |
+---------------------------------------------------------+------------------------------------------------------------------------------+

Once this is merged and deployed, we'll want to delete the existing SMK records and re-enable the DAG.
Testing Instructions

Check out main
Disable any ingestion limits you have set up for dev (SMK is really quick, thankfully)
Run the DAG, verify that there are about 58k results loaded, and run the following SQL (using just db-shell) to see the malformed foreign landing URLS: select foreign_landing_url, url from image where provider='smk' and foreign_landing_url ilike '% %' limit 10.
Check out this branch
Run the DAG, and verify that there are now about 39k results loaded. The following SQL should now show the same records as before, except with the appropriate (now clickable!) foreign landing URLs: select foreign_landing_url, url from image where provider='smk' and foreign_landing_url ilike '%\%20%' limit 10

Checklist

[x] My pull request has a descriptive title (not a vague title like
Update index.md).
[x] My pull request targets the default branch of the repository (main) or
a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[x] I added or updated tests for the changes I made (if applicable).
[x] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible
errors.
[x] I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

I think I'd like to do those steps as a fast-follow to merging this PR, so I'd rather wait to merge it and do it all at once if that's okay!

Good catch on that of the URL with random spaces! Was it purely lucky to find those spaces in a few rows while querying? Or how did you find it? I believe it would be nice to add that extra check to the MediaStore class (or something more refined for URLs in general).

It was luck alone, but that's a good idea! Normally I would consider spaces in a URL to be a sign of something wrong with the data but it appears to be perfectly valid here so perhaps MediaStore validation would be the best plan 🙂 I'll add that!

All changes look good to me here. However, I was thinking if there is a way to preserve the links of the canonical images. Do you think we could use the watermarked column temporarily for that? It's set to False by default for all rows so we can make it True here and after a run of this DAG we can clean the "non-watermarked" images as those should be the alternative images we don't want anymore. It will require coming back and modifying this DAG to remove that flagging but it's a tiny change, and I believe it's worth it to preserve the links.

Do you mind elaborating on this a bit more? What do you mean by canonical images in this case?

What do you mean by canonical images in this case?

I mean just the images we want to preserve, the ones that SMK itself shows on the landing page (not the pretty similar ones). What I mean at the end with coming back to the DAG is to remove the watermark flagging after the duplicated images are deleted. It would be only a temporary trick.

Ahhh, okay I see what you mean! Instead of running a deletion, we alter the DAG to set watermarked=true for all images that get processed. Then we would delete the ones with watermarked=false after the run. That's brilliant! I'll get working on that change, any objections to that approach @stacimc?

No objections from me! Nice alternative to deleting everything and repopulating.

@AetherUnbound I was thinking more about checking whether the URLs contain spaces, and raising an exception if that happens. It's probably better to let each provider handle that, but the validation doesn't need to happen here! We can leave that improvement for a separate PR as well. I was just mentioning the idea that came to my mind 💡

Ahh, got it! Great idea! I've made an issue to encapsulate that 😄 https://github.com/WordPress/openverse-catalog/issues/1022

Confirmed that we have no watermarked images presently in the catalog:
deploy@localhost:openledger> select count(*) from image where provider='smk' and watermarked=true;
+-------+
| count |
|-------|
| 0     |
+-------+
SELECT 1
Time: 11.104s (11 seconds), executed in: 11.099s (11 seconds)

Going to merge this, then kick the SMK DAG off!

Oh dear, it seems like this had the opposite effect and instead duplicated all of our results 😳
deploy@localhost:openledger> select count(*) from image where provider='smk' and watermarked=true;
+-------+
| count |
|-------|
| 38527 |
+-------+
SELECT 1
Time: 0.228s
deploy@localhost:openledger> select count(*) from image where provider='smk' and watermarked=false;
+-------+
| count |
|-------|
| 69744 |
+-------+
SELECT 1
Time: 0.193s
deploy@localhost:openledger> select count(*) from image where provider='smk';
+--------+
| count  |
|--------|
| 108271 |
+--------+
SELECT 1
Time: 0.129s

I'm looking into this now, worst case we just drop the non-watermarked images which was the original plan anyway 😅

Sorry, I should have checked one other place, apparently we have 108k SMK results in the API database as well! So I guess that's expected, here's the current response from https://api.openverse.engineering/v1/images/stats/:
    {
        "source_name": "smk",
        "display_name": "National Gallery of Denmark (SMK)",
        "source_url": "https://open.smk.dk/",
        "logo_url": null,
        "media_count": 108067
    }

So I suppose it worked as intended! We just have a lot more alternate images than primary ones 🙂 Proceeding with the delete.

Ran the following to prep the deletion:
deploy@localhost:openledger> create temporary table smk_deleted_2023_03_15 as select * from image where provider='smk';
SELECT 108271
Time: 0.428s
deploy@localhost:openledger> \copy smk_deleted_2023_03_15 to '/tmp/smk_deleted_2023_03_15.csv' DELIMITER ',' CSV HEADER;
Time: 5.323s (5 seconds), executed in: 5.323s (5 seconds)

Uploaded the latest data to s3://openverse-catalog/image/smk/smk_deleted_2023_03_15.csv
Ran this command to delete the non-watermarked images:
deploy@localhost:openledger> delete from image where provider='smk' and watermarked=false;
DELETE 69744
Time: 1.493s (1 second), executed in: 1.493s (1 second)

Then, to prevent misbehavior with the API, I set all the remaining watermarks to false:
deploy@localhost:openledger> update image set watermarked=false where provider='smk';
UPDATE 38527
Time: 6.351s (6 seconds), executed in: 6.351s (6 seconds)

This is complete! I'll have a follow up PR to address #1020 shortly.


Request/Question: KUAL or MRPI implementation

Are there any plans on implementing this project as a KUAL extension or an MRPI package?
Thanks.

I'm sorry but why?

Like sure it's possible and quite easy but why.

Ease of acsses probably


Implement opt-in unsigned requests for clients.

This change makes it possible to override the signature version at client
creation time using a parameter. It also introduces the concept of an
advanced configuration object for clients:
import botocore
from botocore.client import Config

config = Config(signature_version=botocore.UNSIGNED)
s3 = session.create_client('s3', config=config)

This does not move any existing parameters into the advanced
configuration object, and thus is not yet a breaking change. It
does include the following:

Adds botocore.UNSIGNED as a sentinel to disable signing
Updates botocore.handlers.disable_signing to use botocore.UNSIGNED
Adds a botocore.client.Config object to store signature version
Modifies client creation to use this new config
Updated / new unit tests

cc @jamesls @kyleknap

Coverage remained the same at 94.22% when pulling 50e044d34deb04f216f440c3e537aa877173f0b6 on anon-clients into a61109f80c72501bc2e271550dac263da0660ffb on develop.

Coverage remained the same at 94.22% when pulling 50e044d34deb04f216f440c3e537aa877173f0b6 on anon-clients into a61109f80c72501bc2e271550dac263da0660ffb on develop.

Coverage remained the same at 94.22% when pulling 50e044d34deb04f216f440c3e537aa877173f0b6 on anon-clients into a61109f80c72501bc2e271550dac263da0660ffb on develop.

Coverage remained the same at 94.22% when pulling ac0df2d7c9edc6505abd5f7c9d8c3c5cc24ba6d0 on anon-clients into a61109f80c72501bc2e271550dac263da0660ffb on develop.

@jamesls @kyleknap please have another look :+1:

This looks good to me. :ship: If the integration test that I pointed out does fail, a subsequent pull request will have to be made to change None to UNSIGNED when using the --no-sign-request option.

@kyleknap good call. I've created an associated pull request with the CLI for this. After it's been reviewed I'll merge in both.

Looks good, just a couple small things.  :shipit:


2 more query functions

query(conn, "anyofterms", "name", "VI")
query(
        conn,
        "anyofterms",
        "name",
        "VI",
        "uid name release_date starring { name }"
      )

removed: import_starwars_sample() from mutation_test setup (double mutation)

Pull Request Test Coverage Report for Build 63

6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.2%) to 81.633%

Totals

Change from base Build 62:
1.2%

Covered Lines:
80

Relevant Lines:
98

💛  - Coveralls

Hey,
I am not sure if this is the way to go since queries can become pretty complex. I think we should first discuss a good way to model GraphQL+ queries in Elixir before going down a specific route or implementing specific query functions for certain types of GraphQL+ functions.
Take this example from Manish Rai Jains talk

So I had a look at your PR again. Thank you! I think having more query functions is in general a good idea. But there are a couple of issues.

There are still IO.inspect calls in the code
Your implementation puts object always in quotes, assuming that it is always a string. This will not work with some functions (eq(), gt(), lt(), etc.)
The display parameter should have a default value
It is not possible to select multiple predicates that should be returned (if I'm not mistaken)
Some query functions don't have an arity of 2, for example uid()
It doesn't support pagination like me(func: has(director.film), first: 5)
It doesn't support sorting

This might seem like much. But I don't want people to start using a function and then suddenly change the API and break their application. So I would rather try to go for a more complete integration.
What do you think?

I think a good way to handle this is this client: https://github.com/elbow-jason/dgraph_ex

And @Fulnir can we please have a discussion on here first before you submit a PR?

To avoid new commits appearing here, I closed the pull request.


doc: Consider listing/promoting the various project health dashboards in the documentation

It feel like I'm discovering new hidden gems every day in terms of publicly accessible dashboards that put the spotlight on some interesting metrics that can help people evaluate Zephyr's overall "health".
I don't think these are advertised anywhere (or are they?), so I would like to use this issue as a way to 1/ list them and 2/ eventually come with a right place to add them more prominently in the documentation so that folks evaluating Zephyr, and anyone really, can easily browse them.
Here's what I'm aware of, others should feel free to jump in:

https://stats.zephyrproject.org: bug stats, footprint stats
https://app.codecov.io/gh/zephyrproject-rtos/zephyr: code coverage

@kartben Here is another Dashboard: https://kibana.zephyrproject.io
This one is WIP and was published not long ago in the discord testing channel(https://discord.com/channels/720317445772017664/733037944922964069/1069647539621597275)
As far as I understood, this dashboard shall be the central one for zephyr in the future.

As far as I understood, this dashboard shall be the central one for zephyr in the future.

Correct. It will be eventually replacing stats.zephyrproject.org.


Add GitHub actions to run unit tests

We've been dealing with a bunch of issues with committing to the project without having working code, so this will make sure that before it gets to main, it'll get tested and if there's any issues, they'll need to be resolved before pushing to main.

This can potentially be expanded later to also run unit tests within Unity but for now we just need to test Core

They refuse to test the actions before merging, but honestly the expected value of merging blindly is still positive

remember to squash merge!


Need to add unit tests for pfCanvas and pfCanvasEditor components

There are extensive unit tests here and here
These existing 'blueprint canvas' unit tests would need to be updated to work with the generalized a-pf pfCanvas component.

@dtaylor113 would you like to help with this issue?

@amarie401, yes :-)


Issue with html when appending speech

http://jsfiddle.net/v7gdmc4a/

:+1:
I noticed the same thing when implementing TheaterJS for my blog. Line breaks, for some reason, render before the current line and not at the designated position.

Thanks for confirming this issue @afaqurk, I plan to release a fix soon ;)

than you for this amazing js. but please check theater.js to work fine with jshint. :)

Thanks @farhadyousefi ;) I am currently rewriting TheaterJS in ES6 and looking into standard, not exactly jshint but I guess it'd do the work too.

@afaqurk @farhadyousefi  this issue is now fixed thanks to v2, here is a working jsFiddle: http://jsfiddle.net/v7gdmc4a/1/
I also added standard to the workflow ;) If you're interested in migrating from v1 to v2, have a look at the guide and let me know if you're having any trouble.


Review ui.elements.modal

Modal must not have close button if not defined in constructor.
Modal must not have header if not defined in constructor.
Modal must not have inline styles if not defined in constructor.
Modal should take size from content.
Modal should be movable within the context of the parent.
A target in which the modal will be positioned absolute must be defined.
A header is optional. Can be provided as string or html element.
Close is optional. A close button will be displayed in the top right corner.
Default position is top: 0, left: 0.
Content must be provided to calculate the offset width and height.
mapp.ui.elements.modal({
  target: retailplaceMapview.target,
  header: 'Foo',
  close: true,
  top: 20 // pixel, default 0
  right: 20 // pixel, default left: 0
  content: layerSwitch,
  css_style: 'padding: 10px;',
  contained: true,
  //containedCentre: true
})

With the contained:true flag the modal bounds can not be shifted outside the target bounds.
With the containedCentre:true flag the centre of the modal can not be shifted outside the target bounds.

@RobAndrewHurst The issue with close method should be fixed now.

@RobAndrewHurst The issue with close method should be fixed now.

Lekker!

@RobAndrewHurst  Changing the theme will now remove the closest modal to the legend.

@RobAndrewHurst Changing the theme will now remove the closest modal to the legend.

Very nice! Thanks @dbauszus-glx working well!

@simon-leech The behaviour is still likely to change as we still need to review how legends should work.

@dbauszus-glx  Noticed a little bug.

If you add a modal to a style - hit pop out for the modal, then close the modal, then collapse the style - the modal button remains on top of the style element rather than being closed with the style.

The allowModal option has been removed.


Fix race condition on mkdir and symlink under parallel tests

This PR fixes a race condition that we experienced because we run rspec-puppet tests parallelized. Without this fix we were periodically running into cases where this would happen:

process 1 would notice that a directory is missing
process 2 would notice that a directory is missing
process 1 would create the directory ✅
process 2 would create the directory and get Errno::EEXIST 🚫

The change here disregards the Errno::EEXIST for directories and symlinks, when the directory or symlink that's being created already exists and is proper.

Changes Unknown when pulling b69001dc81039f12d8ce31bef03ba8fc9c29e310 on kpaulisse:kpaulisse-safer-mkdir into ** on rodjek:master**.

Thanks for the patch! I'll see if there are any other issues in 2.6.1 that come in today and then push out a 2.6.2 release with this tonight.

Cool thanks. Hope you're doing well.

rspec-puppet 2.6.2 pushed to rubygems


AHOYAPPS-531: Dynamic sender settings

https://issues.corp.twilio.com/browse/AHOYAPPS-531

Dynamically update frame rate based on number of participants when video codec is VP8 simulcast.
Was trying to be surgical because this area of code is kind of hard to change and we were not expecting to spend a lot of time on this.

Dynamically update frame rate based on number of participants when video codec is VP8 simulcast.

I will leave a more detailed review tomorrow, but I wanted to comment on this point. Simulcast is meant for multi-party Group Rooms, but dynamic sender settings should be used to optimize unicast for 1:1 vs multi-party scenarios in either Peer-to-Peer or Group Rooms.

I think I may have read some instructions incorrectly from Chris earlier and made mistake to apply dynamic sender settings to simulcast instead of non-simulcast. It may be as easy to fix as switching a boolean. But I'm not feeling great about this PR.

I had assumed adjusting capture configuration would be pretty easy but it was not and so this was rushed because it was not team's main priority.
I think I should have written down comprehensive capture requirements somewhere, maybe a spreadsheet, so that we could be sure everyone was on same page.
There's too many if statements to follow. In the future I think we either need:

Completely separate capture logic for each capture method even if it means some duplicate code so that it is easy for us to understand and easy for customers to simply pick what implementation they want.
Or at least abstract things like frame rate, bitrate, and resolution to a config struct or something.
Or maybe we should keep MultiPartyExample.

If this PR is pretty close maybe we just continue forward but certainly open to other options.

Talked offline and decided not to add dynamic sender settings to video app.


ci: automate floorist image tag updates

Look up latest commit hash of floorist tool, check floorist image tag
existence from shortened commit, and apply it as a default
FLOORIST_IMAGE_TAG parameter.
RHICOMPL-3319

Let's see if this would work.


About Install Stray Command Line Tool and Stray Studio

Thanks so much for the great software of stray command toolkit, however I installed this tool using the following shell command
"curl --proto '=https' --tlsv1.2 -sSf https://stray-builds.ams3.digitaloceanspaces.com/cli/install.sh | bash"
After installed, nothing works, I can't use stray command, I don't know the reason and how to make it works. So I'm looking for your kind help. My system is Linux.
Is it because that I don't have a STRAY_LICENSE_KEY=key? and how can I get this key? or some other reason else.
I want use stray command toolkit to make a 3D reconstution pipeline based RGB-D sequences acquired by IPhone 12 pro device.

Replied in an other thread.


Restore --missing-as-empty

In hg, adding a new file otherwise leads to:
No such file: repo.abcdef/path/to/file.txt

This only seems to affect diffing directories.


[Feature, Request] Select  should  support  auto  select  all?

Existing Component
是
Component Name
Select
Description
Why not Select component support select-all by one click in options list?

No plan to support this.


arkserver docker image has sudo security issue CVE2021-3156 - please provide new image

Description of Issue
CVE-2021-3156 means sudo is exploitable - this is fixed in xenial, but arkserver/steamcmd image has to be rebuild/republished for fix to be included ...
https://ubuntu.com/security/CVE-2021-3156

I haven't gotten any luck getting response to anything for a while. I forked and have fixed a few of the outstanding issues.
https://github.com/jkread/arkserver

Sorry for the delay here @maecki-maecki. Do you have a link to the description of that CVE for posterity? Happy to re-open and address the issue but I wasn't able to find any specifics when I searched for that CVE number.

https://ubuntu.com/security/CVE-2021-3156 https://ubuntu.com/security/CVE-2021-3156
Stefan

Am 19.03.2021 um 20:34 schrieb Thomas Hoag @.***>:
Sorry for the delay here @maecki-maecki https://github.com/maecki-maecki. Do you have a link to the description of that CVE for posterity? Happy to re-open and address the issue but I wasn't able to find any specifics when I searched for that CVE number.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/thmhoag/arkserver/issues/32#issuecomment-803066132, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE24PCVEEIJI6EU2VOAGR3DTEORLTANCNFSM4WZSKCQA.

Thanks @maecki-maecki, all good. I'm re-opening this, should be a pretty straight-forward fix with an update to the base image.
Linking the base image for posterity: https://github.com/thmhoag/steamcmd

I updated the base image and build pipeline on my fork, if this is still relevant to you @maecki-maecki .
https://github.com/Gornoka/arkserver


ion-floating-menu issue on Android 4.3

hi
I have implemented ion-floating-menu in my IONIC-Cordova App.
It works well in 5.1 or 6.0 Android devices. However on 4.3 device (Samsung Galaxy S3) its having issues
When I click on the menu button to open, it opens. I mean it changes to open state. But the implemented floating buttons inside it do not come up. They seem to stay b behind open menu item.
Also the text labels remain to get overlapped one on top of the other.
cordova 6.4
cordova-android android 5.1.1
Please advice. Let me know what additional information you need I will try to provide.

I am having this same issue for Android 4.4.4. But it runs ok on 5 and above.
Anyone manage to resolve this?

We solved it. Give me a day or 2 and will share the fix.
Get Outlook for Androidhttps://aka.ms/ghei36
On Sun, Jan 22, 2017 at 10:12 PM +0530, "razmans" <notifications<EMAIL_ADDRESS>wrote:
I am having this same issue for Android 4.4.4. But it runs ok on 5 and above.
Anyone manage to resolve this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/pregiotek/ion-floating-menu/issues/41#issuecomment-274341990, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AQMBoyngeO-hqfsIL0KYkLu6bN8130dhks5rU4bkgaJpZM4LVcKJ.


chore: Clean up unused dependencies

What
Upgrade Storybook dependency + configuration.
Removes dependencies:

@emotion/styled
@emotion/core
@rebass/forms
gatsby-plugin-portal
react-collapse
rebass
prop-types
@medusa/medusaj-js
@popperjs/core
jsonwebtoken
react-dropzone
react-tooltip
react-multi-select-component

Removes all theme files related to Emotion
Note: Used npm utility depcheck to find unused dependencies

Building storybook seems to fail, not entirely sure where the issue is coming from. Did we upgrade any of our dependencies in a previous PR?

Seems to be an issue with a version mismatch between Gatsby and Storybook. As per Gatsby's recommendation, I've updated Storybook and its configuration to the latest version.