Play and Pause Option

Work so far on this needed option for external media playback in our halls is much appreciated
Not really a fault issue but the need to be able to play and leave the final frame on screen by pausing after playback. VLC is currently being used as this offers this option but users find VLC complicated. We would like to use this option for HLC training videos that work by leaving an image on screen for a seamless presentation. The simplicity this software offers is much appreciated by end users.
Since Soundbox development was finished I never bothered to request the option but at this early stage in development of OnlyM it seems opportune to request this option we need in training with HLC material.
regards Robin

@Roblinproductions thanks for feedback. The final frame of a video is often empty, so I'd welcome some thoughts about what the basic requirement is. Thanks, Antony

@omaha4 - when I use the sign language app and set a video to "freeze" it does indeed stop on the last frame of the video which is empty - a black screen. How does this differ from what OnlyM already provides (the ability to revert to a black backdrop when the video finishes)?

Ahh, lets say after paragraph 2 of the watchtower, or some other Sign language pub, there is a picture that is bookmarked, and in our group without cameras I need to hold on that picture and talk about it, I can do just that with freeze. Its like having an extra person, the freeze command was set before the meeting. To Robinproductions point, if his HLC training videos are not black on the last frame of the video, and indeed, have a picture on it, and they need to discuss it, then freezing, or pausing it would be the option they select, for that video. VLC can do this, but it is so deep in the options, you wouldn't know about it if you didn't read the branch's instructions, and even then, it is a universal option, not a case by case option. Remember, not all videos are going to be blank on the last frame.

Thanks, that's useful. If I understand correctly, some videos (specifically some jw sign-language videos and perhaps some HLC videos) are designed to conclude with a still image (presumably shown in the last few frames) where the intent is that the video should be frozen at that point while further discussion continues. Furthermore, it's important to be able to specify in advance whether a particular video should be frozen at the end or allowed to conclude normally. Right?

That's the main point. Sign Language videos have bookmarks that allow for complex customization in the playlist, but that is a topic for another day. But there are videos out there, hearing and deaf, that don't black out on the last frame ( I seem to remember this very subject almost burnt me in VLC a while back). It is for these videos, that being able to individually select, pause or stop, would be useful to some.

Thanks. There are 2 sets of similar requirements here (HLC and Sign Language). Sadly, both are edge cases as far as the core purpose of OnlyM is concerned, and adding support for them risks feature creep (support for bookmarks, freeze to a specific frame, etc). I want to keep OnlyM simple and recognise that this will limit its application in some scenarios. I may add a per-video "freeze" option to allow the video to pause on the final frame, but that's as far as I think it will go. Thank for your valuable input.

Indeed, I was using sign language as an example as an example of what could be done.  JW Sign language is doing an awesome job of filling our needs ( it actually took 4 years of patiently waiting for the customizable playlist feature to make it to JWSL :) ). If you use VLC for your videos, remember to have the

Appreciate you considering the option. A per video freeze function would solve our issue. Thank you

#17 implemented


Add FRED

Add FRED to the list of companies.

Sounds awesome @alfredbaudisch 👍

Thanks @doomspork ! We are growing really fast and for that reason we are hiring Brazilian Elixir devs!


Improve exception handling

[ ] Introduce a specific type for each throw site
[ ] Catch and log all exceptions in one place (new middleware)

Errors collected from logs

[ ] Cannot read property 'getElementsByTagName' of undefined needs more logging to get the problematic DOI or XML
[ ] Network errors from doi.org/data.crossref.org
[ ] Network errors (504 Gateway Time-out) for doi.org/data.crosscite.org

Proceeding outside-in, got to the point of making the infrastructure module get-disqus-post-count implement the two port errors from article-page and article-search-page. Two problems arising:

the single exception thrown in that module cannot simultaneously be the class owned by the two pages ports. There is no implements for multiple inheritance in JavaScript, checking what TypeScript provides.
get-disqus-post-count actually throws an exception for a port that it doesn't implement, as it is always wrapped into get-biorxiv-comment-count.

Note that:
   class GetCommentCount extends Error
        implements GetCommentCountErrorFromArticlePage, GetCommentCountErrorFromArticleSearchPage {}

doesn't do what you think it does: as far as I understand it treats the classes as interfaces and merges them to say that GetCommentCount should have (for example) a name property. But since all exceptions generally have the same properties and methods, it's practically equivalent to:
   class GetCommentCount extends Error

Options:

adapt the exception being thrown into page-level adapters. Verbose, but keeps the top of the A-shape encapsulated where these levels are created. Doesn't solve the nested infrastructure module problem.
Either types. Make errors explicit everywhere, more similar to C error codes than to exceptions.
standard library of exceptions e.g. Recoverable, Permanent, Temporary etc. defined by a cross-page Domain Model like for Doi that everyone depends on.

SO just use a single exception type, shared by the two ports?
On Mon, Jun 29, 2020 at 2:57 PM Giorgio Sironi<EMAIL_ADDRESS>wrote:

Note that:
class GetCommentCount extends Error
implements GetCommentCountErrorFromArticlePage, GetCommentCountErrorFromArticleSearchPage {}
doesn't do what you think it does: as far as I understand it treats the
classes as interfaces and merges them to say that GetCommentCount should
have (for example) a name property. But since all exceptions generally
have the same properties and methods, it's practically equivalent to:
class GetCommentCount extends Error
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/libero/prc/issues/77#issuecomment-651139332, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAFV6REQUL77HZ5JVYLBTDRZCMVRANCNFSM4ND6X63A
.

--
Kevin Rutherford
+44 7973 563521
<+44%207973%20563521>
http://rutherford-software.com http://xpsurgery.com

Going for the standard library option then.

@timestamp,log
2020-06-19 13:10:25.338,"2020-06-19T13:10:23.462Z app:server:response HTTP/1.1 404 Not Found

  Error: getaddrinfo EAI_AGAIN data.crossref.org
      at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:64:26)

"
2020-06-19 13:10:01.892,"2020-06-19T13:10:01.366Z app:server:response HTTP/1.1 404 Not Found

  Error: getaddrinfo EAI_AGAIN doi.org
      at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:64:26)

"
2020-06-18 04:18:37.195,"2020-06-18T04:18:34.271Z app:server:response HTTP/1.1 404 Not Found

  TypeError: Cannot read property 'getElementsByTagName' of undefined
      at getElement (/app/build/api/fetch-article.js:13:63)
      at /app/build/api/fetch-article.js:19:33
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (internal/process/task_queues.js:97:5)
      at async /app/build/api/fetch-article.js:56:26
      at async Promise.all (index 3)
      at async /app/build/home-page/render-recent-activity.js:16:22
      at async /app/build/home-page/render-recent-activity.js:60:55
      at async /app/build/home-page/render-page.js:29:15
      at async /app/build/home-page/index.js:12:29

"
2020-06-16 06:28:04.233,"2020-06-16T06:28:04.193Z app:server:response HTTP/1.1 404 Not Found

  ServiceUnavailableError: Article temporarily unavailable. Please try refreshing.
      at /app/build/article-page/middleware/fetch-reviews-for-article-page.js:23:19
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (internal/process/task_queues.js:97:5)
      at async Promise.all (index 1)
      at async /app/build/article-page/middleware/convert-article-and-reviews-to-article-page.js:4:32
      at async /app/build/article-page/middleware/fetch-reviews-for-article-page.js:27:5
      at async /app/build/article-page/middleware/fetch-article-for-article-page.js:20:5
      at async /app/build/article-page/middleware/validate-biorxiv-doi.js:16:5
      at async /app/build/article-page/middleware/validate-doi-param.js:18:5
      at async /app/node_modules/koa-mount/index.js:52:26

"
2020-06-16 06:28:04.193,"2020-06-16T06:28:04.193Z app:middleware:fetch-reviews-for-article-page Failed to load reviews for article 10.1101/642017: (FetchDatasetError: Received a 504 Gateway Time-out for https://data.crosscite.org/10.5281%2Fzenodo.3833746)
"
2020-06-15 14:37:34.233,"2020-06-15T14:37:32.935Z app:server:response HTTP/1.1 404 Not Found

  Error: connect ETIMEDOUT <IP_ADDRESS>:443
      at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1141:16)

"
2020-06-12 14:31:11.142,"2020-06-12T14:31:08.990Z app:server:response HTTP/1.1 404 Not Found

  Error: Received a 504 Gateway Timeout for https://data.crossref.org/10.1101%2F718031
      at /app/build/api/fetch-dataset.js:34:19
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (internal/process/task_queues.js:97:5)
      at async /app/build/api/fetch-article.js:50:23
      at async Promise.all (index 3)
      at async /app/build/home-page/render-recent-activity.js:16:22
      at async /app/build/home-page/render-recent-activity.js:60:55
      at async /app/build/home-page/render-page.js:29:15
      at async /app/build/home-page/index.js:12:29
      at async /app/node_modules/koa-mount/index.js:52:26

"

Next up: puts a try/catch around https://github.com/libero/prc/blob/master/src/infrastructure/fetch-crossref-article.ts#L111-L117 to log problematic DOIs and XML that we cannot parse.

Ok, found some cases looking at the logs around that error:

http://prc.libero.pub/articles/10.1101/2<IP_ADDRESS>5660 (breaks the page but DOI exists https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>5660v1)
http://prc.libero.pub/articles/10.1101/226092 (two reviews by PeerJ but no abstract or title)
http://prc.libero.pub/articles/10.1101/845081 (review by PREreview but no abstract or title)

Either types. Make errors explicit everywhere, more similar to C error codes than to exceptions.

@davidcmoulton and I have just spiked using the Result and Maybe types from the true-myth library, and it seems pretty positive. We looked at the infrastructure level returning Results (i.e. the expected value, or a defined error type), then turning into Maybes for the components to use (as they generally don't care what the error was).
We used true-myth rather than the more popular fp-ts library as it a lot simpler to get started with, and only includes the parts we're interested in.

Current decision: write ADR in the mob and push back the rest in the backlog.


[HAC-1465] Fix query params and encode label selector correctly

Issue: HAC-1465
I tested this against hac-core https://prod.foo.redhat.com:1337/beta/hac/testK8s by first creating a few Application resources, adding a label test-label=test-value to one of them and then changing the watchedResource as follows on https://github.com/openshift/hac-core/blob/main/frontend/src/Routes/testK8s/HookTest.tsx#L16:
  const watchedResource: WatchK8sResource = {
    isList: true,
    groupVersionKind: {
      group: 'appstudio.redhat.com',
      version: 'v1alpha1',
      kind: 'Application',
    },
    namespace,
    selector: {
      matchLabels: {
        'test-label': 'test-value',
      },
    }
  };

also tested with fieldSelector:
  const watchedResource: WatchK8sResource = {
    isList: true,
    groupVersionKind: {
      group: 'appstudio.redhat.com',
      version: 'v1alpha1',
      kind: 'Application',
    },
    namespace,
    fieldSelector: 'metadata.name=test'
  };

Codecov Report

Merging #109 (fede3cd) into main (a046dae) will decrease coverage by 0.08%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
- Coverage   18.27%   18.18%   -0.09%
==========================================
  Files          35       35
  Lines        1297     1303       +6
  Branches      342      344       +2
==========================================
  Hits          237      237
- Misses       1060     1066       +6

Impacted Files
Coverage Δ

packages/lib-utils/src/app/redux/actions/k8s.ts
25.86% <14.28%> (-0.93%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a046dae...fede3cd. Read the comment docs.

/lgtm


[5.9] Diagnose attempts to reabstract variadic function types in unimplementable ways

5.9 version of #67368.

@swift-ci Please test


Fix Crashing GetExistingTags

Before this update, any execution of the GetExistingTags method will hard error the script. I ran into this while testing releases for the new docs ci updates.

The code as-is legitimately won't work. To test, here's a version that has apiUrl substituted.
(Invoke-WebRequest -Method "GET" -Uri "https://api.github.com/repos/Azure/azure-sdk-for-python/git/refs/tags"  -MaximumRetryCount 3 -RetryIntervalSec 10) | % { $_.ref.Replace("refs/tags/", "") }
Execute that, notice that it errors. We can't directly use Content either. It's much easier to just use Invoke-RestMethod and get the content back ready for action.
(Invoke-RestMethod -Method "GET" -Uri "https://api.github.com/repos/Azure/azure-sdk-for-python/git/refs/tags"  -MaximumRetryCount 3 -RetryIntervalSec 10) | % { $_.ref.Replace("refs/tags/", "") }
Notice the only shift is from Invoke-RestMethod to Invoke-WebRequest
@Azure/azure-sdk-eng

/check-enforcer override


bugfix:修改sla超时判断和服务选中批量操作

Codecov Report

Merging #193 (a4f6cb7) into v2.6.x_develop (ec0e911) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           v2.6.x_develop     #193   +/-   ##
===============================================
  Coverage           29.33%   29.33%
===============================================
  Files                   3        3
  Lines                  75       75
===============================================
  Hits                   22       22
  Misses                 53       53

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec0e911...a4f6cb7. Read the comment docs.


dnf repo: download is atrociously slow

Describe the issue
Downloading VScode from the repo that MS offers for RHEL/CentOS/Fedora/etc is very slow.
The download speed goes up slowly, but always starts at 300~ KB/s.
My connection maxes out at 6MB/s.
When did the issue occur?
Forever, only now I've decided to report it.
If applicable, what package did you attempt to install, and from which repo?
VScode, from its repo in the guide for linux, RHEL/CentOS/Fedora.
Steps to Reproduce

do the steps listed in the guide
see how code download goes

Actual Result
Very slow download.
Expected Result
A fast download.
Screenshots

Additional context

Hello @stereomato, thank you for bringing this to our attention. We are aware that slow download speeds have been an ongoing concern. Please know that we are actively working on this issue and should have a fix that will mitigate this problem soon.
I am also closing this issue out as a duplicate to a similar open issue. Will recommend following that thread for any further updates. Thank you for your patience!
#50


Wrong SRV check

I am launching a dnscheck and I am getting this:
SRVConf
error: Missing SRV record "submissions.tcp.test.mydomain.me"
error: Missing SRV record "submission.tcp.test.mydomain.me"
error: Missing SRV record "imaps.tcp.test.mydomain.me"
error: Missing SRV record "imap.tcp.test.mydomain.me"
error: Missing SRV record "pop3.tcp.test.mydomain.me"
error: Missing SRV record "pop3s.tcp.test.mydomain.me"
According to RFC2782:

Proto
The symbolic name of the desired protocol, with an underscore
(_) prepended to prevent collisions with DNS labels that occur
in nature.  _TCP and _UDP are at present the most useful values
for this field, though any name defined by Assigned Numbers or
locally may be used (as for Service).  The Proto is case
insensitive.

Then the record must be:
"submissions. tcp.test.mydomain.me" instead that "submissions.tcp.test.mydomain.me"

Could it be github has modified the underscores in your text? I'm seeing it as if there was a lookup for _submissions_.tcp.test.mydomain.me. Mox should be doing lookups for _submissions._tcp.test.mydomain.me.
See rfc 6186 for some concrete examples for the email services.

In the mean time I've had a report of an email client that used the SRV records to configure itself. So the SRV records look correct. I'll close the issue. Please reopen if you find a case where a client should support autoconfig with SRV records, but it doesn't work.


Tiles creation in PHP or imagic

I am working in a web application. where user can upload 360 images and it can be seen on another page with 360 viewer. now for 360 viewer i want to use marzipano as i think its the best 360 viewer.
but i am stuck with the tiles creation. from the marzipano tools, when we export a project , the tiles are already created. they are doing in from krpano tools (i still don't know how they do it in server automatically).
so as per my project requirements, i need to do it in my server as automation process. so i wanted to if marzipano has something which can be used do create the tiles automatically in my server. like with PHP or with imagic.
also if possible let me know how to use krpano tools to create tiles in the server for automation.
Thanks in advance.

Check this code, it is python but does the job https://stackoverflow.com/questions/41856394/script-for-creating-marzipano-scenes

@ai-tushar @thriskel We're faced the same issue, so i've made a [simple library]](https://packagist.org/packages/ama-team/projection-framework). It still sucks (very slow, mapping is not done correctly, no antialiasing - hope this will come in future releases), but does the job with some artifacts.
For everyone else who stumble upon this: having server-side tile creation is good, but the proper way is to create tiles directly in the browser - it's quite rare for server to have GPU on board, while nearly every desktop has one (even if it's buried in CPU), and such processing takes lots of resources (and can bring your website down due to CPU starvation). Marzipano Tool does it that way (in browser) and i found this quite too late, otherwise i'd implement same thing in JS/WebGL.

Closing since it's not a bug. You are welcome to continue the discussion in our forum at https://groups.google.com/forum/#!forum/marzipano.


cannot install tiktoken using pip

I tried to install tiktoken using pip install tiktoken in my server.
But this was the output.
bash-4.1$ python -m pip install tiktoken
Collecting tiktoken
  Using cached tiktoken-0.3.3.tar.gz (25 kB)
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Collecting regex>=2022.1.18
  Using cached regex-2023.3.23-cp38-cp38-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_12_x86_64.manylinux2010_x86_64.whl (691 kB)
Requirement already satisfied: requests>=2.26.0 in /home/synaziqd/virtualenv/doxplore-backend/3.8/lib/python3.8/site-packages (from tiktoken) (2.28.2)
Requirement already satisfied: urllib3<1.27,>=1.21.1 in /home/synaziqd/virtualenv/doxplore-backend/3.8/lib/python3.8/site-packages (from requests>=2.26.0->tiktoken) (1.26.15)
Requirement already satisfied: certifi>=2017.4.17 in /home/synaziqd/virtualenv/doxplore-backend/3.8/lib/python3.8/site-packages (from requests>=2.26.0->tiktoken)(2022.12.7)
Requirement already satisfied: idna<4,>=2.5 in /home/synaziqd/virtualenv/doxplore-backend/3.8/lib/python3.8/site-packages (from requests>=2.26.0->tiktoken) (3.4)
Requirement already satisfied: charset-normalizer<4,>=2 in /home/synaziqd/virtualenv/doxplore-backend/3.8/lib/python3.8/site-packages (from requests>=2.26.0->tiktoken) (3.1.0)
Building wheels for collected packages: tiktoken
  Building wheel for tiktoken (pyproject.toml) ... error
  error: subprocess-exited-with-error

  × Building wheel for tiktoken (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [37 lines of output]
      running bdist_wheel
      running build
      running build_py
      creating build
      creating build/lib.linux-x86_64-cpython-38
      creating build/lib.linux-x86_64-cpython-38/tiktoken
      copying tiktoken/__init__.py -> build/lib.linux-x86_64-cpython-38/tiktoken
      copying tiktoken/model.py -> build/lib.linux-x86_64-cpython-38/tiktoken
      copying tiktoken/core.py -> build/lib.linux-x86_64-cpython-38/tiktoken
      copying tiktoken/load.py -> build/lib.linux-x86_64-cpython-38/tiktoken
      copying tiktoken/registry.py -> build/lib.linux-x86_64-cpython-38/tiktoken
      creating build/lib.linux-x86_64-cpython-38/tiktoken_ext
      copying tiktoken_ext/openai_public.py -> build/lib.linux-x86_64-cpython-38/tiktoken_ext
      running egg_info
      writing tiktoken.egg-info/PKG-INFO
      writing dependency_links to tiktoken.egg-info/dependency_links.txt
      writing requirements to tiktoken.egg-info/requires.txt
      writing top-level names to tiktoken.egg-info/top_level.txt
      reading manifest file 'tiktoken.egg-info/SOURCES.txt'
      reading manifest template 'MANIFEST.in'
      warning: no files found matching 'Makefile'
      adding license file 'LICENSE'
      writing manifest file 'tiktoken.egg-info/SOURCES.txt'
      copying tiktoken/py.typed -> build/lib.linux-x86_64-cpython-38/tiktoken
      running build_ext
      running build_rust
      error: can't find Rust compiler

      If you are using an outdated pip version, it is possible a prebuilt wheel is available for this package but pip is not able to install from it. Installing from the wheel would avoid the need for a Rust compiler.

      To update pip, run:

          pip install --upgrade pip

      and then retry package installation.

      If you did intend to build this package from source, try installing a Rust compiler from your system package manager and ensure it is on the PATH during installation. Alternatively, rustup (available at https://rustup.rs) is the recommended way to download and update the Rust compiler toolchain.
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for tiktoken
Failed to build tiktoken
ERROR: Could not build wheels for tiktoken, which is required to install pyproject.toml-based projects

How to resolve this?

Your best bet is to install from wheel, not sdist. Common reasons why you're not installing from wheel include:

You're using an ancient version of pip
You're shooting yourself in the foot by e.g. using --no-binary flag or env var to pip
You're running on some niche architecture (in which case, see the FAQ)

If you must install from sdist, do what the error message says and install a Rust compiler


Handle null string in CSV decoder

Currently, users can specify custom null values in CSVRecordReader but the same is missing from CSVDecoder. The PR fixes this discrepancy.

Codecov Report

Merging #9340 (1f14978) into master (0af226d) will decrease coverage by 48.30%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master    #9340       +/-   ##
=============================================
- Coverage     63.59%   15.28%   -48.31%
+ Complexity     4756      168     -4588
=============================================
  Files          1823     1823
  Lines         97505    97505
  Branches      14911    14911
=============================================
- Hits          62005    14901    -47104
- Misses        30941    81478    +50537
+ Partials       4559     1126     -3433

Flag
Coverage Δ

unittests1
?

unittests2
15.28% <ø> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

 Learn more


fixed babel-node compile error

fixed babel-node compile error

Thanks for the contribution! However, this is a read-only mirror. please read the contribution guide. Also, feel free to join us on chat!


Fixed Rate Borrow UI/UX & Reqs

wireframes ✅
empty/error states (90%)
hover states (40%)
Product Requirements Doc - PRD (40% -> 80% June 14)
high fidelity mocks (70% -> 100% June 19)
prototype (start June 20)
product strategy
user testing w/prototype
GTM planning kick-off w/Charles & Cash

Product/Eng artifacts:
https://www.notion.so/delv-tech/Fixed-Rate-Borrow-75a5fe70e62143feacc4a9cd39b905e9?pvs=4

wireframes ✅
empty/error states ✅
hover states ✅
PRD (40%)
high fidelity mocks (90%)
prototype (start June 20)
product strategy
user testing w/prototype
GTM planning kick-off w/Charles & Cash

Product/Eng artifacts:
https://www.notion.so/delv-tech/Fixed-Rate-Borrow-75a5fe70e62143feacc4a9cd39b905e9?pvs=4

wireframes ✅
empty/error states ✅
hover states ✅
Product Requirements Doc (PRD) 🚧 in progress 🚧
high fidelity mocks ✅
prototype 🚧 in progress 🚧
product strategy
user testing w/prototype
GTM planning kick-off w/Charles & Cash

wireframes ✅
empty/error states ✅
hover states ✅
Product Requirements Doc (PRD) 🚧 in progress 🚧
high fidelity mocks ✅
prototype ✅
product strategy 🚧 in progress 🚧
user testing w/prototype ✅
GTM planning kick-off w/Charles & Cash


action masking with masked_epsilon_greedy, 'dict' object has no attribute 'shape' error

Hey guys, i'm trying to add illegal action masking to my dqn agent using masked_epsilon_greedy. I changed the observation as dict like recommended but now i'm getting 'dict' object has no attribute 'shape' error.
Can someone indicate what is the correct way to update the network to use 'observation["your_key_for_observation"]' rather than 'observation' pls ?

Adding
lambda inputs: inputs["your_key_for_observation"]
to the network did the trick for me


Show attribution in the map

Hi @putteabrahamsson!
First of all thank you for your work.
I am trying to use your repo in my expo/react native project and I would like to be able to show the attribution at the bottom-right corner of the view, as in other libraries like this one: https://github.com/pavel-corsaghin/react-native-leaflet.
I think at the current stage it is not possible with your library. If this is the case, I would suggest considering adding this feature.
In the meantime, could you give me some hint on how to do it myself?
Thank you!

im looking into this now. sorry for the delay.
what exactly do you want to show? @marcodemutti

Added now, will push soon.


Small Display

under splitted panes the display gets to small to be useful.
Improvement suggestions include:

remove colorbar
improve matplotlib usable area
remove buttons

Is this fully done now?

Although this is not 100%, I dont see anything coming soon on this point, so I'm closing.


Possibility of Supporting GitLab?

The more we know about your system and use case, the more easily and likely we can help.
Environment info

OS:
App Version (Command/Ctrl + ,):

Description of the problem / feature request / question:
If possible, provide a sample gist or screenshot:
If possible, provide the log files

Mac: ~/Library/Application Support/Lepton/logs
Windows: C:\Users\<username>\AppData\Roaming\Lepton\logs
Linux: ~/.cached/Lepton/logs

The debug mode is recommended when producing the logs.
You can send your log file to<EMAIL_ADDRESS>if don't want to post it here.

@gooddadmike
I don't have a plan to support GitLab. If you are interested, feel free to send a PR:)

Our company is switching to GitLab now.  If it requires Gist, then we cannot use it unless GitLab support Gist.   Has anyone successfully installed Lepton on GitLab?   What's missing for this to happen?

GitLab Code Snippets feature is different enough from GitHub Gists that it would likely make more sense for a fork to be created that was based on GitLab, rather than integrating the feature into Lepton directly.

https://github.com/GitJournal/GitJournal takes a more abstract approach by using a git repo itself as storage, which may have some benefits
I've also filed a similar enhancement for https://github.com/taniarascia/takenote/issues/301

There is an interesting solution described here.
https://handsomeliuyang.github.io/2019/06/05/Lepton支持gitlab的改造路程/


Allow setting a custom node.kubernetes.io/instance-type node label

Is your feature request related to a problem? Please describe.
I'd like to set a custom node.kubernetes.io/instance-type node label in k3s agents or servers, but it gets overwritten with k3s. Is there any technical reason behind it, why that isn't supported? A related issue could be #1916
# /etc/rancher/k3s/config.yaml
...
node-label:
  - "node.kubernetes.io/instance-type=s-8vcpu-16gb"

Describe the solution you'd like
The node.kubernetes.io/instance-type=k3s label should only be used as fallback if no node.kubernetes.io/instance-type label is present.
Edit: I just tested setting beta.kubernetes.io/instance-type=s-8vcpu-16gb, which properly sets both variables. So the code could just use another condition or getter to not overwrite values passed.

K3s has an internal cloud provider that is used to set node external IPs. This is required because nodes are not allowed to set this field for themselves. The code for this is at https://github.com/k3s-io/k3s/blob/master/pkg/cloudprovider/instances.go#L50, and returns k3s as the cloud provider name.
If you want to have nodes show up with the correct metadata and cloud provider ID, you should disable the K3s cloud provider (with --disable-cloud-controller) and deploy the correct out-of-tree cloud provider for wherever you're running K3s.

I'll use the cloud provider in my specific case, but there are some customers which can't.
But it's still quite weird that setting beta.kubernetes.io/instance-type=s-8vcpu-16gb will configure both labels... Maybe a kubernetes thing.


Bypass phone verification

Hey devs, need some help.
while login, Sometimes its asking to verify this was me, how to bypass it?

I think this iş not possibile with this library yet. Of you find any solution, PLEASE let me know it.

Was this fixed?

There is no way to baypass it. Also it's illegal.

There is no way to baypass it. Also it's illegal.

What do you mean it is illegal?
Bypass is illegal and impossible, but logging in by using Two Factor Authentication is possible.

Was this fixed?
Not yet brother,
Seems they stopped working on this library


Minimax algorithm

static evaluation heuristics
alpha-beta pruning
genetic selection of evaluation weights

All test pass locally but not on CLI for some reason.

Before continuing the realization of the genetic tournament, we will need to significantly improve the code optimization.
With the current code, we have those performances:

depth
play_match() performance (s)

1
9.43

2
21.79

3
70.41

For an $N_{population}$ size population, we will need to run $2 * N_{population}$ match in order to compute all the fitness scores.
In that case, a population of 100 chromosomes will result in a computation approximating $2 * 100 * 21.79 = 4358$ seconds, or almost 1 hour and 13 minutes.

I tried JIT compiling with Numba, but some functions are not supported yet.
I tried tom implement workarounds but cannot make it work.


Friendly tab routes, with back button support

Fixes #717

Loading any tab populates a query param in the address bar, yielding a unique link for every sub tab (for sharing and external linking)
query param displays user friendly word rather than numerical tab index
manually intercepts back button and force refreshes the page; this hack to compensate for react router not recognizing changes in params as actual page changes.
adds keys to mapped arrays to fix react warnings

Is there any way you could get the forward button working?

I didn't have any luck enabling forward. I also realized there are tabs on the "data methodology page" so I'll need to add those.

closing for now; refresh isn't great and forward functionality not working. Either need to replicate what is happening in the "explore data" page, or potentially choose full url routes for the tabs (eg healthequitytracker.org/faq)


feat(ansible): add lidar_transfusion artifacts

Description

lidar_tranfusion artifacts (3D detection component). Related to https://github.com/autowarefoundation/autoware.universe/pull/6890
Tests performed

Not applicable.
Effects on system behavior

Not applicable.
Interface changes

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

After merging https://github.com/autowarefoundation/autoware.universe/pull/6890, I will accept.

@youtalk merged 👍🏻


Pull Request Labeler - Use a released version

[ ] Closes #xxxx
[ ] Tests added
[ ] User visible changes (including notable bug fixes) are documented in whats-new.rst
[ ] New functions/methods are listed in api.rst

No need to use a release version now that #7667 is merged.
Might be a good idea to use the next release version though.


Render pass attachments now hold the load and store operators, as the…

… image layout.
RenderPassState has been removed.
Render subpass attachment and state have been simplified accordingly.

Solves Issue #37


Update XML docs for ManagedIdentityCredential GetToken methods

Fixes https://github.com/Azure/azure-sdk-for-net/issues/30635
Now that the credential type has token caching, let's ensure the XML docs are accurate.

API change check
API changes are not detected in this pull request.


Add proof block height verification

Closes https://github.com/lightninglabs/taproot-assets/issues/387

In agreement with previous comments - seems like we should have a negative test in the itests? Or as a unit test, not sure how easy it is to reorg under itest.

@jharveyb I've updated this PR with an additional negative unit test orientated around block height. Oli mentioned that the re-org work is planned for 0.3.0. Perhaps after that work is complete we can revisit itests for proof block fields?


prefetch.i Implementation of RVA22 Mandatory Extension Zicbop

In RVA22 profile, it requires that the Zicbop extension must be implemented. And there is a prefetch.i instruction defined in Zicbop extension. Therefore which of the following implementations can be declared fully compatible with RVA22:

Can we implement the prefetch.i instruction as NOP? or
Can we implement the prefetch.i instruction as prefetch the desire cache block into L2 cache instead of L1I cache?

Thanks.

Either of those options is valid, because prefetches are not architecturally visible. But, for future reference, I would not describe this as a profile-related question: it is really a question about the definition of Zicbop. The profiles don’t impose any requirements beyond mandating Zicbop.

Thanks, I appreciate the clarification.


Properly delete all related google drive resources

Description

Delete google drive associated resources.
Risk

Deploy Plan

Are we sure they are all indexed?

Yes

Are we sure they are all indexed?

Yes

Will do in a follow up PR, struggling with Sequelize.


Docs Enhancement - Duplicate imports on examples - #1483

Overview: What does this pull request change?

Removed duplicate import.

Motivation and Explanation: Why and how do your changes improve the library?

Checked all the docstrings of the files in /manim that makeup reference manual. Removed the only redundant import. The other duplicate mentioned in the issue is necessary for the decorator @animation_override. There were no other unnecessary imports found.
Links to added or changed documentation pages

Example Tree
Further Information and Comments

Reviewer Checklist

[ ] The PR title is descriptive enough for the changelog, and the PR is labeled correctly
[ ] If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
[ ] If applicable: newly added functions and classes are tested

I went through the references manual again checking for duplicates.
The other multi-line imports are either for imports from multiple modules or
of the following nature.
 from manim import *
 import manim

So, the changes proposed in the issue have been made.

@Darylgolden Hello, the change requested is already in the desired form of a  function instead of the lambda expression in the latest update.


no response from mic

Hi Mike, any ideas why microphone doesn't pickup keyword, says ready, no issues with pocket sphinx, tried MAGIC MIRROR & HELLO LUCY, just continues to say ready, choose a mode.

also what did you use for the sound files to create my own personal greeting?

Keyword is set in config. When you say the keyword the mic icon and "Ready, shoose a mode" should change to a flashing icon and the word "Voice." Then you can issue commands. If it doesn't change you can try changing the microphone: number in config.
I'd prefer if you create a topic on the forum where you can post your config. I only just saw this issue. Sorry about that


Allow using existing conventions as part of custom regexp

I think it would be great if you could use something like __::upper_snake::__ as a convention.

Sorry for late reply! That would be cool. I will try that out :D


[DO NOT MERGE] Revamp KV Secrets README

Simplifies KV Secrets README as a POC.

API change check
API changes are not detected in this pull request.


Image encoding issue

Hi @christianrauch
I noticed that published image has encodings that don't match any of the following
16UC1 / mono16, 8UC1 / mono8, 8UC3 / rgb8 / bgr8, 8UC4 / bgra8, bayer_rggb8, bayer_bggr8, bayer_gbrg8, bayer_grbg8
I tried to use Kalibr to calibrate my stereo camera, but it failed because the image topic has unsupported encoding. Here is the error I get
RuntimeError: Exception during multithreaded extraction: Unsupported Image Encoding: 'yuv422_yuy2'

Is it possible to map the encodings to the supported ones such as 16UC1 / mono16, 8UC1 / mono8, 8UC3 / rgb8 / bgr8, 8UC4 / bgra8, bayer_rggb8, bayer_bggr8, bayer_gbrg8, bayer_grbg8 ?

The supported image encodings are listed here:
https://github.com/christianrauch/camera_ros/blob/47eea6d63d21c3d179c377a87b87e7b5bb57d762/src/format_mapping.cpp#L16-L38
Since the node does not convert between pixel formats to avoid memory copies, the camera has to support the pixel format of the ROS message and vice versa.
If you want to use yuv422_yuy2, then your camera has to support YUYV. But if your camera supports XRGB8888 (a.k.a. XR24) for example, you can use the ROS format bgra8.
If you need the message in a format that is not supported by the camera natively, you would have to convert from the camera to your target format.

Thanks!


Fix variable names for clippy

Latest version of wasm-bindgen fixed the variable name casing issue so we can re-enable those warnings.
Fixed the issues where we caused it as well.

Can't wasm-bindgen actually be removed from mutiny-core?

Can't wasm-bindgen actually be removed from mutiny-core?

Not yet, we still use it for the local storage and indexeddb stuff


<EMAIL_ADDRESS>is currently published as latest

$ npm info fetch-mock version
8.0.0-alpha.14

I just want to let you know about it, it does not look like it was intended? Did you mean to publish it using an @alpha dist-tag?

This is surprising, but npm info isn't documented in the cli https://docs.npmjs.com/cli-documentation/, so I'm not really sure what that command even aims to provide.
But this is a bit alarming. I'm not sure when npm introduced a prerelease dist tag as an additional requirement on top of, y'know, having a version which, by the semver standard, is already defined as being a prerelease!!!
I am quite annoyed at npm for introducing this behaviour, but grateful to you for reporting 😄 . I will release a no-change version from master to make sure nobody else gets accidentally opted in to the alpha.

Now resolves to 7.7.3 (although the npmjs.com page for it is yet to update)

I can confirm that it's fixed now 👍
by default, npm publishes to the @latest dist-tag, no matter what you put into the version.
When you publish alpha versions, you can do so with
npm publish --tag alpha

People installing with npm install fetch-mock won't get the version, they have to explicitly do npm install fetch-mock@alpha, which is great for alpha testers.
You can also add a `"publishConfig" property to your package.json while you are working on the alpha version, then you won't forget it by chance
{
  "publishConfig": {
    "tag": "alpha"
  }
}

None of this was recently introduced, it's been there for as long as I remember :)

btw, you can just use npm dist-tag add to overwrite a tag, instead of publishing a new version


Onboard Duration Cadl-ranch test

Onboard Duration Cadl-ranch test

resolved in https://github.com/Azure/autorest.csharp/pull/3563


fix(tab-label-container): Letting it slide will give users a very good experience.

It's useless to say, and apply it to your own project.
Fixed containers make people feel stiff so much, especially when labels are many!

@jelbourn hi, can you take a look at it?

After testing, it seems that there are some problems. I temporarily turn off the pr.


Upgrade to Spock 2.3 to simplify AbstractMultiTestInterceptor

We can now remove hacks to parameterize a non-parameterized Spock test, since Spock has this capability out of the box.

@bot-gradle test and merge

OK, I've already triggered a build for you.


fix: os.getlogin() failed to startup in wsl.

Met OSError: [Errno 2] No such file or directory when calling the os.getlogin() in WSL.
Reference:
https://github.com/initstring/uptux/issues/1

Wow! Didn't know this! Does the script run fine in windows?

I tested this change in WSL and it work well. According to the reference, it should work in other platforms. Please try it in native linux OS if you have time.

Hi @Weissle, I tested it out on my Linux machine and it seems to run just fine :smile:

Hmm...tried in windows. It failed with the error os has no attribute 'getuid'

Can you maybe add an if check using hasattr for getlogin and fallback to getuid if the condition is false? :smile:

I have updated my commit and tested it in WSL and windows10. Please check it.
BTW, what python version do you use? For me, error occurs when I use python3.8 or python3.9 to execute dooit.
Python3.10 works normally. Maybe this line should be updated.

Hi @Weissle, Thanks for the PR!

BTW, what python version do you use?

On my personal PC, I'm currently using 3.10

For me, error occurs when I use python3.8 or python3.9 to execute dooit

Hmm.... Can you explain this a bit? Is this related to getlogin() or getuid()?

Hmm.... Can you explain this a bit? Is this related to getlogin() or getuid()?

It is irrelevant to getlogin() or getuid()
I have created a issue about this https://github.com/kraanzu/dooit/issues/99


PP-864 search payments by email

Public api now returns email in the response for search payments, get
payment by ID
Payments search can be filtered on email address.
with @PauloPortugal

Reviewed.


ore bag magnet pickup prediction is evil

Description
it will always predict based on where client thinks you are but pickup is based on server position so you have to slowly move around everything in long straight paths, since if you just move around normally client will predict picking it up then change direction and server doesnt think they could pick it up anymore
possible fix is having client say what ores get picked up with some lag compensated extended radius or a capsule, technically could be abused by malf client but better to have  it than meme magnet
possible bandaid just remove misprediction until better solution exists, that way you at least wont get juked and have to do a double take (or disable prediction just to have usable ore bag)

YESSSS


Release failed Security insights plugin

Security insights release fail
Build link

The release for the fix of security insights plugin has failed.
Maybe something to look at

This is fixed


Issue when dragging window to a second monitor with different resolution

Hi, I'm on MacOS (M1 Pro Macbook Pro). When I drag the window from one screen to another, there are weird render artefacts that can only be fixed by restarting the app and making it open on the other screen. Is there a way to fix this?

Can you be a bit more specific, what kind of artifacts? Maybe post a screenshot. Also, which app are you talking about, is it a problem with the examples?

I first noticed the issue occur in an app I'm building, but it also seems to happen for the examples. When I drag the three-d window from a higher resolution screen (my macbook screen) to a lower resolution screen (a 1080p monitor) the view goes from this:

to this:

The inverse of the issue also occurs when I drag from the lower resolution screen to the higher resolution (the view becomes larger). I've since realised that the issue can be fixed by resizing the window (because that forces the camera to set its viewport). So thinking about it, this could be solved by somehow making the camera update its viewport when the window is dragged to a different screen. How would this be done?

Thanks for the detailed report 👍 It looks like it's the device pixel ratio, which would make a lot of sense. Are you by any change testing on the latest release (0.15)? I think the issue might be fixed on the master branch. So can I get you to test it on master as well?


Generate scheduling information statistics on right-click+drag

When selecting a time window in the capture view, in devmode only,
we can now see a detailed breakdown of scheduling information in the
"Debug" tab, under "Selection Summary". This includes core occupancy
information as well as system-wide process and thread on-core time
statistics.

Thanks for the comments @karupayun , I will implement the suggestions.


Fix path to default config

Since v1.3, goaccess will install default config to /etc/goaccess/goaccess.conf:
https://github.com/allinurl/goaccess/blob/b43934e4a383070de936f513a06e45f424691223/Makefile.am#L119
But when goaccess is run after installation, it will look at old location, /etc/goaccess.conf instead.
This change fixes default config file lookup to match installed location.
Without the change, on a fresh install:
goaccess --dcf
No default config file found.
You may specify one with `-p /path/goaccess.conf`

strace reveals:
lstat("/etc/goaccess.conf", 0x7ffe8846a0e0) = -1 ENOENT (No such file or directory)

After the change, on a fresh install:
goaccess --dcf
/etc/goaccess/goaccess.conf

Merged. Thank you very much for submitting this PR!

I confirm this problem existed:
# cat total-access.log | goaccess
GoAccess - version 1.3 - Nov 22 2018 23:57:25
Config file: No config file used

# dpkg -L goaccess
/.
/etc
/etc/goaccess
/etc/goaccess/browsers.list
/etc/goaccess/goaccess.conf
...

Unfortunately there is no update available yet. When will you release a new revision?
apt policy show goaccess
goaccess:
  Installed: 1:1.3
  Candidate: 1:1.3
  Version table:
 *** 1:1.3 500
        500 https://deb.goaccess.io bionic/main amd64 Packages

Temporary fix:
if [ ! -f /etc/goaccess.conf ]
then
  ln -s /etc/goaccess/goaccess.conf /etc/goaccess.conf
fi

@ottok thanks for confirming and posting this. I do plan to push out a new revision however, it will probably be at the end of the month as I don't have access to my machine now. Please stay tuned.

Any updates on the schedule of the next release? All new installs currently fail to work without the symlink fix..

@ottok just in case you’re using CentOS (RHEL) 7, you can install this packaged 1.3 release patched with the fix: https://extras.getpagespeed.com/redhat/7/x86_64/repoview/goaccess.html

Any plans to release 1.3.2 or 1.4 in 2020 so this and other fixes can be rolled out?

@ottok Yes, as we speak, I'm 2/3 into replacing tokyo cabinet which has caused some issues on the past and it's long overdue. So I hope to finish that this month and release v1.4 either at the end of March or early Apr.

the update is really necessary, but the error is still present in development
goaccess --dcf
No default config file found.


Raise an error when “only” tests are found in CI

I think it’s far too easy to mark a test as “only” and forget to remove the modifier when committing and pushing.
It may be a good idea to fail by default is a test is marked as “only” and isCI is true.
This can probably be made overridable in the suite, in case someone wants to turn it off.

Good idea, we should implement this 💪


Adjust Color Scheme for Improved Readability

It's difficult to read text when brighter colors are used, and the color choices for the menu make it hard to read as well. Could you please adjust the colors for better readability?
Edit: Only active theme loaded
Reference Images:

Yeah, originally for selected buttons the text color is more close to black. What happened is that Discord probably updated something that broke this.
Lately I'm very occupied with work, but I'll try to address this and some other problems in the next few days.

also, is the last image for light theme? currently, Smooth theme hss no support for light theme.

not relevant to this issue but there is a small tearing in the bottom

hey @mizu-048, yes I've noticed those problems, they're not actually the colors fault, but Discord that updated the class names again (😢). I did not had time to look into it yet, but the problem is that the theme styles aren't being applied due to changes in Discord itself.
That said, I've plans to use wildcards for those class names when updating this theme, that way this same problem will probably not happen in a while. I'll update you here when I've anything.

alright, thank you, good luck with whatever you're busy with

8 months later...

@DaRandomCube
might try jab at it later this month
for now i use this

8 months later...

this happens when you get hired 🙃
anyway, I'll have some time this end of the year, so I'll try to fix this the way I said I would, so sorry I didn't have as much time as I'd like to work on the theme

Just to update: started doing some work on it here: #16. Not sure when will be ready tho.


Set a WebProxy

Hi guys,
I didn't read any info about the chance to add a web proxy as a configuration in order to let Telly to connect to remote channels through it.
Any idea if is it possible? It would be perfect.
Thanks.

Do you mean that the buffering will go through Telly, instead of Telly just redirecting Plex to the stream?

Proxy support is in the next version of telly!

@AndreAga In the ALPHA 1.5.0 you can now set the URL of a proxy to use for a given request, as indicated by the environment variables HTTP_PROXY, HTTPS_PROXY and NO_PROXY (or the lowercase versions thereof). HTTPS_PROXY takes precedence over HTTP_PROXY for https requests.
The environment values may be either a complete URL or a "host[:port]", in which case the "http" scheme is assumed. An error is returned if the value is a different form.
More info here.


Master branch obsolete

Link to doc page in question (if any):
https://docs.streamlit.io/streamlit-cloud/get-started/deploy-an-app
Name of the Streamlit feature whose docs need improvement:
In "Your app URL" section the documentation seem to be outdated
What you think the docs should say:
The name of the branch should be main not master. See https://github.com/github/renaming Maybe this is the reason why the link https://share.streamlit.io/streamlit/demo-self-driving is not working

Thanks for reporting the issue @aframosp! We'll rename the default branch in the docs from master to main.


Issue with discrete nat coeffects

$ cat examples/broken/reuse-bounds.gr
-- With correct operator precedence, n should be of type Int |4=|
n : Int |1+1*2+1 : Nat=|
n = |1|

quad : Int |4=| -> Int
quad |x| = x + x + x + x

main : Int
main = quad n
$ gr examples/broken/reuse-bounds.gr
Granule v<IP_ADDRESS>
gr: Can't compile a coeffect: 4= {CNat Discrete 4} of kind Nat
CallStack (from HasCallStack):
  error, called at source/Checker/Constraints.hs:297:4 in granule-<IP_ADDRESS>-2vhdhHAc490E9xAMFBgLfD:Checker.Constraints

A simple fix.
However, at the moment, : binds more tightly than any arithmetic operator. So the correct way to write the above is:
n : Int |(1+1*2+1) : Nat=|
n = |1|

quad : Int |4=| -> Int
quad |x| = x + x + x + x

main : Int
main = quad n

Perhaps we should change the precedence here?

Done. f4a313d


Update terminology

Purpose
Companion to https://github.com/Concordium/concordium-ledger-app/pull/15.
Changes
Updates views that interact with ledger and adjust wording to match the updates on the ledger.
Removes parameters in account creation and identity issuance, which are no longer shown.
Uses alternative command to export PRF key in recovery.
Checklist

[x] My code follows the style of this project.
[x] The code compiles without warnings.
[x] I have performed a self-review of the changes.
[x] I have documented my code, in particular the intent of the
hard-to-understand areas.

When trying to create a new account I get the following warnings:
react-dom.development.js:89 Warning: validateDOMNesting(...): <p> cannot appear as a descendant of <p>.
    in p (created by DisplayHexString)
    in div (created by DisplayHexString)
    in DisplayHexString (created by PublicKeyDetails)
    in PublicKeyDetails
    in p
    in div
    in span (created by LedgerStatus)
    in div (created by LedgerStatus)
    in LedgerStatus (created by LedgerView)
    in div (created by LedgerView)
    in div (created by Card)
    in Card (created by LedgerView)
    in LedgerView (created by Ledger)
    in Ledger (created by SimpleLedgerWithCreationKeys)
    in SimpleLedgerWithCreationKeys (created by


Disable IISExpress tests

Trying to unblock PR checks.

@jkotalik suggest closing this in favour of #9122

I'm going to let both of these run to completion.

Yeah there are a few more tests that failed too.


Add ECDSA sign-to-contract module

This is a backport and rebase of https://github.com/bitcoin-core/secp256k1/pull/669

Redid the whole API. I think I addressed all comments except to add ctime tests, which I will do in another commit.

Note (no need to do this in this PR, I just want to write it down):
I think we could add synthetic nonces to this scheme. Sure this will break its determinism, and then the HW needs to keep state. But I think there’s no need for secure storage. HW could simply draw some aux_rand, add it to the nonce derivation and store it. Then in the second round, look up aux_rand and recompute the nonce.

remaining todo

[ ] update docs for what to do in case of failure
[ ] make anti_klepto functions for all steps, even if they are just wrappers (or almost-wrappers) around s2c
[ ] add example code

tACK 374d944. I used this branch to add support for the anti klepto protocol when signing a transaction in the BitBox02, including successful host verification in the bitbox02 client libraries. Thanks again for picking up my original PR.

Okay, I think we're actually good to go now.

Fixes look good.
I think this one is still open:
https://github.com/ElementsProject/secp256k1-zkp/pull/111#discussion_r543138109 (change the comment)
And not sure if you overlooked that one or delibaretly choose to keep the current version:
https://github.com/ElementsProject/secp256k1-zkp/pull/111#discussion_r543140968

@jonasnick sure, cherry-picked your commit. I have a mild preference for just documenting that the function won't work, since all of our usage avoids the point at infinity, but since you took the time to implement this and add a test and fix the ctime tests, I might as well take your complete work :).
@real-or-random ok changed the comment. It was unclear to me from your earlier comment that you actually wanted me to make a change there.

Thought that the ec_commit functions will be useful in other contexts where it isn't as clear that there is no point at infinity. PR looks good. Are you going to squash this?

Yep, give me 10 minutes to squash.

Heh, took more than ten minutes. But there you go.

@apoelstra is this PR ready to be merged? I have a bit of downtime to work on the downstream integration.

I think so. @real-or-random  @jonasnick can you merge this?

Awesome. Thanks everyone!

Awesome. Thanks everyone!


feat: add Bicep support

This PR adds basic support for the Bicep language.
https://github.com/PrismJS/prism/issues/2816
Snapshots generated with npm run test:languages -- --language=bicep --update

Tests should now be fixed I hope

Thank you for contributing @johnnyreilly!

Thanks for the help with the regex!


Description text on MS App ID is inaccurate

The text under Project Settings > Development Resources says the following:

A Microsoft App ID is required for your local Azure resources. If you’ve created an App ID already, you can add here. If not, your App ID and secret will be created when you provision resources for this bot. Learn more.

This is incorrect. An App ID is not required for all bots to run locally, but only for bots that need Authentication and/or include Skills. Bots without these two things can be run locally without an app ID

Shiproom - @lauren-mills can you get this merged today, with Marieke's copy from above?  thanks


Adding describe_include_subcolumns to REQUEST_SETTINGS

Summary
Adding describe_include_subcolumns to REQUEST_SETTINGS
Checklist
Delete items not relevant to your PR:

[ ] Unit and integration tests covering the common scenarios were added
[ ] A human-readable description of the changes was provided to include in CHANGELOG
[ ] For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

Will it be a settings method for this setting or will keep it not exposed?


Proper Field Names and Field Data Types from JSON to HTML

Regarding #20 , fields are coming according to the JSON but not properly rendered(or post cannot work without field names.)

Now the names and fields are coming properly.


../../packages/core/framework7-bundle.min.js missing

I downloaded the code from github and tried to run the kitchen sink, but ../../packages/core/framework7-bundle.min.js was not in the ZIP file.

you can download it from NPM or CDN


Color picker won't appear when on fullscreen mode on an element.

 I think it would show if parent element of the picker popping up is the element that is going full screen.
Here is the plnkr but you must "Launch the preview in a separate window" by pressing the icon shown in the image below.
To test:
1 - Visit the plnkr:  http://plnkr.co/edit/fWNUq3moPsyxfv7ushy2?p=preview
2 - Launch the preview in a separate window
3 - Click on Go Full Screen button
4 - Click on the picker
How to launch the preview in a separate window (see image below):

I just noticed that we can pass a jquery selector to appendTo option, which solves this problem.
Thanks for the great lib!!


Error starting up business partner agent demo

Forked the repo and tried to startup the demo (on latest master branch) as per the quick start here:
https://github.com/hyperledger-labs/business-partner-agent/tree/master/scripts#quickstart
DID registration was successful, startup up using docker compose I get the following error in the bpa process:
scripts_bpa_1 exited with code 1
bpa_1       | 16:31:45.896 [main] ERROR Micronaut - Error starting Micronaut server: Error loading service [io.micronaut.views.model.security.$BeanConfiguration]: edu/umd/cs/findbugs/annotations/Nullable
bpa_1       | java.util.ServiceConfigurationError: Error loading service [io.micronaut.views.model.security.$BeanConfiguration]: edu/umd/cs/findbugs/annotations/Nullable
bpa_1       | 	at io.micronaut.core.io.service.DefaultServiceDefinition.lambda$load$0(DefaultServiceDefinition.java:71) ~[business-partner-agent.jar:?]
bpa_1       | 	at java.util.Optional.map(Optional.java:258) ~[?:?]
bpa_1       | 	at io.micronaut.core.io.service.DefaultServiceDefinition.load(DefaultServiceDefinition.java:67) ~[business-partner-agent.jar:?]
bpa_1       | 	at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:195) ~[?:?]
bpa_1       | 	at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:177) ~[?:?]
bpa_1       | 	at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625) ~[?:?]
bpa_1       | 	at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484) ~[?:?]
bpa_1       | 	at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474) ~[?:?]
bpa_1       | 	at java.util.stream.ReduceOps$ReduceTask.doLeaf(ReduceOps.java:952) ~[?:?]
bpa_1       | 	at java.util.stream.ReduceOps$ReduceTask.doLeaf(ReduceOps.java:926) ~[?:?]
bpa_1       | 	at java.util.stream.AbstractTask.compute(AbstractTask.java:327) ~[?:?]
bpa_1       | 	at java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:746) ~[?:?]
bpa_1       | 	at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290) ~[?:?]
bpa_1       | 	at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1016) ~[?:?]
bpa_1       | 	at java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1665) ~[?:?]
bpa_1       | 	at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1598) ~[?:?]
bpa_1       | 	at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:183) ~[?:?]
bpa_1       | Caused by: java.lang.NoClassDefFoundError: edu/umd/cs/findbugs/annotations/Nullable
bpa_1       | 	at io.micronaut.inject.annotation.AnnotationMetadataSupport.<clinit>(AnnotationMetadataSupport.java:56) ~[business-partner-agent.jar:?]
bpa_1       | 	at io.micronaut.inject.annotation.DefaultAnnotationMetadata.registerAnnotationDefaults(DefaultAnnotationMetadata.java:1297) ~[business-partner-agent.jar:?]
bpa_1       | 	at io.micronaut.views.model.security.$BeanConfiguration.<clinit>(Unknown Source) ~[business-partner-agent.jar:?]
bpa_1       | 	at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:?]
bpa_1       | 	at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:64) ~[?:?]
bpa_1       | 	at jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[?:?]
bpa_1       | 	at java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500) ~[?:?]
bpa_1       | 	at java.lang.reflect.Constructor.newInstance(Constructor.java:481) ~[?:?]
bpa_1       | 	at io.micronaut.core.io.service.DefaultServiceDefinition.lambda$load$0(DefaultServiceDefinition.java:69) ~[business-partner-agent.jar:?]
bpa_1       | 	... 16 more
bpa_1       | Caused by: java.lang.ClassNotFoundException: edu.umd.cs.findbugs.annotations.Nullable
bpa_1       | 	at jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:606) ~[?:?]
bpa_1       | 	at jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:168) ~[?:?]
bpa_1       | 	at java.lang.ClassLoader.loadClass(ClassLoader.java:522) ~[?:?]
bpa_1       | 	at io.micronaut.inject.annotation.AnnotationMetadataSupport.<clinit>(AnnotationMetadataSupport.java:56) ~[business-partner-agent.jar:?]
bpa_1       | 	at io.micronaut.inject.annotation.DefaultAnnotationMetadata.registerAnnotationDefaults(DefaultAnnotationMetadata.java:1297) ~[business-partner-agent.jar:?]
bpa_1       | 	at io.micronaut.views.model.security.$BeanConfiguration.<clinit>(Unknown Source) ~[business-partner-agent.jar:?]
bpa_1       | 	at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:?]
bpa_1       | 	at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:64) ~[?:?]
bpa_1       | 	at jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[?:?]
bpa_1       | 	at java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500) ~[?:?]
bpa_1       | 	at java.lang.reflect.Constructor.newInstance(Constructor.java:481) ~[?:?]
bpa_1       | 	at io.micronaut.core.io.service.DefaultServiceDefinition.lambda$load$0(DefaultServiceDefinition.java:69) ~[business-partner-agent.jar:?]
bpa_1       | 	... 16 more

I just merged a pull request that fixes that. Can you pull again?

@etschelp thanks for the quick reply!  FYI I now get the following error on startup, however I'm able to connect to the app (http://localhost:8080) and login with the default "admin" id:
bpa_1       | 17:38:09.089 [scheduled-executor-thread-5] ERROR TaskExecutors - Error occurred executing @Async method [void signVP(List vcs)]: Read Timeout
bpa_1       | io.micronaut.http.client.exceptions.ReadTimeoutException: Read Timeout
bpa_1       | 	at io.micronaut.http.client.exceptions.ReadTimeoutException.<clinit>(ReadTimeoutException.java:26) ~[business-partner-agent.jar:?]
bpa_1       | 	at io.micronaut.http.client.netty.DefaultHttpClient$12.exceptionCaught(DefaultHttpClient.java:2296) ~[business-partner-agent.jar:?]

I have a few other questions about the app, do you have an id on Hyperledger Rocketchat?

The project's Rocket Chat channel is @business-partner-agent.

Thanks!

@etschelp thanks for the quick reply! FYI I now get the following error on startup, however I'm able to connect to the app (http://localhost:8080) and login with the default "admin" id:
bpa_1       | 17:38:09.089 [scheduled-executor-thread-5] ERROR TaskExecutors - Error occurred executing @Async method [void signVP(List vcs)]: Read Timeout
bpa_1       | io.micronaut.http.client.exceptions.ReadTimeoutException: Read Timeout
bpa_1       | 	at io.micronaut.http.client.exceptions.ReadTimeoutException.<clinit>(ReadTimeoutException.java:26) ~[business-partner-agent.jar:?]
bpa_1       | 	at io.micronaut.http.client.netty.DefaultHttpClient$12.exceptionCaught(DefaultHttpClient.java:2296) ~[business-partner-agent.jar:?]

This happens when the controller can not communicate with aca-py. The UI will generally work, but functionality will be greatly reduced. Is it working now? If not how did you start the stack?

Ok figured it out. We use acapy's json-ld endpoint to sign the public profile. aca-py does some context validation and tries to access: https://www.w3.org/2018/credentials/v1 this site currently returns 404 and signing fails. So this affects only the controllers "none aries" capabilities.

Is it working now? If not how did you start the stack?

I managed to load the UI and the swagger page but I didn't get any further because I wasn't sure what to do next.  I gather I have to install multiple of these in order to have multiple business partners to communicate with each other?

A good place to start is the demo scenario. If you did not change the configuration everything runs against our demo environment where you can also connect to other agents. You can find the respective did's in the description. Otherwise yes, you would need more than one.

Nice!  Thanks for the link.


Use early return in DependencyValues

This is just a minor cleanup of of DependencyValues.swift to use early return and factor out the warning in order to make it easier to understand the logic of how values get returned.
I hope this sort of PR would be ok. I was browsing the source just because I found this project interesting. I'm not actually using it atm.😅

@timothycosta Thanks for sharing!
I think we personally are a bit more comfortable with the existing guards that we're using and how the compiler enforces returns on those code paths, and I think merging a change here would make it a lil harder on us as maintainers to follow. Because of this, I'm going to close the PR for now, but I do think it's always worth looking at and considering alternatives, so thanks again!


Lines go off the viewport without showing scrollbars

You should see scrollbars if the svg is off the viewport.
Viewbox = auto sounds like it might fix it but doesn't work... Draw everything on a massive canvas?

Just use the max X and max Y of the line points and use as the size, simple!


Remove --disable-ha

/area API
/kind cleanup
We should also cleanup references in docs etc.
Before this work is done, we should ensure nobody is still throwing this flag, but this is criteria for GAing this feature.
cc @vdemeester @lionelvillard @vaikas @yanweiguo @pmorie

We are using this flag due to https://github.com/knative/pkg/issues/1979

We are using this flag due to https://github.com/knative/pkg/issues/1979

/reopen


uninitialized constant Cucumber::RbSupport::RbLanguage::LanguageSupport (NameError)

When trying to implement the cucumber plan from the examples I get the following error:
<class:RbLanguage>': uninitialized constant Cucumber::RbSupport::RbLanguage::LanguageSupport (NameError)

@aesnyder This is a year late, but is this still a problem? can you provide a simpler reproduction setup?

:/ not sure... I'm not sure which app I was even trying to use this with. I'll let you know if I come across it again, feel free to close.


[Feature Request] Add release notes of components in the system manager

Show the release notes for the selected update file. Can be pulled from github.

Solved with 3.0.8


Remove default filter for testnets

this leads to confusion an discriminates testnets - think this filter should be opt-in

@ligi Do you mean testnets should be shown by default? And be opt-out?


Add dotnet3 pipeline template for Kubernetes Deployment

Part of JIRA SRVKP-564
Changes:
Add pipeline template to Kuberentes Deployment for dotnet-3
Signed-off-by: Savita Ashture<EMAIL_ADDRESS>

/approve
/lgtm


make clean: add rnnlm.o

This is too trivial for a pull request:
Currently, the "clean" target only deletes rnnlm and $(OBJ_FILES). However, rnnlm.o is not contained in OBJ_FILES.
Therefore, it would be great to add rnnlm.o:
clean:
    rm -f rnnlm rnnlm.o $(OBJ_FILES)

Thanks for providing faster-rnnlm!

Fixed. Thanks!


Verify configuration on FOD servers is same as on MOD servers

General:

[x] LocalSettings.php
[ ] php.ini
[ ] others?

Specifics:

[x] pcre.backtrack_limit should be increased from the default

The settings from LocalSettings.php (that are now spread between DefaultSettings.php, ExtensionsSettings.php, and ComposerExtensionSettings.php) have been verified. The fod2 branch of Meza1Settings has been updated. The fod2 branch of MediaWiki-JSCMOD awaits a pull request in order to have DefaultSettings.php up-to-date. Once that is merged, we can propagate these changes to all the wikis.
Do we have access to php.ini or can we otherwise verify those settings are what we expect?
Are there any other settings that we need to verify?

Change to MediaWiki-JSCMOD has been merged. Should that repository be moved to the FodWikis organization? Maybe not, since that org has a lot of non-developers. Maybe, for lack of a better org, it should be within EMW? So either of these:

FodWikis/FodWikiSettings
EnterpriseMediaWiki/FodWikiSettings

If we were to do this, it would mean deleting MediaWiki-JSCMOD. It would also be good to get rid of Meza1Settings if we can, since it seems we won't be using that for Meza(1)

I prefer to move MediaWiki-JSCMOD to EnterpriseMediaWiki/FodWikiSettings. Then we can move ExtensionSettings.php from Meza1Settings into this new repo so it's all collocated.


Need typings outdated and typings update command, like NPM

Currently, the only way to find out is running typings install and then reinstalling every typing that is marked as deprecated one-by-one. There should be a command to show outdated typings and a command to update them all and persisting the new reference to typings.json.

Duplicate of #109

That issue is slightly different, it just talks about how your package versions should be synced with your typings versions. But I just want a command that updates all the typings.

@felixfbecker That issue is about updating typings and showing outdated. I'm going to close it in favour of that issue. It's actually quite a simple feature to build, really - you just read/parse typings.json dependencies, check the latest from the API, run install on the ones that are newer. I just haven't been prioritising typings features with #600.


Often PR are closed instead of merged

@vrv In the majority of the cases seems that your are following this merging process. This alter the github pulse and other stats. Is there a way in your process to let this PRs result as merged?

Are you merging something via web interface and other things with command line?

We're using a command line, not the green button, and it inconsistently reports some as merged and some as closed, using the same set of command lines on different PRs.  This seems like a github bug to me, unless someone can tell me what github uses to tell whether something is merged.

It's really infuriating -- any advice would be appreciated. I'd much prefer
if we could have reliable statistics on merged vs. closed, but I also want
the power our scripts give us.
On Wed, Jan 20, 2016 at 1:20 PM Vijay Vasudevan<EMAIL_ADDRESS>wrote:

We're using a command line, not the green button, and it inconsistently
reports some as merged and some as closed, using the same set of command
lines on different PRs. This seems like a github bug to me, unless someone
can tell me what github uses to tell whether something is merged.
—
Reply to this email directly or view it on GitHub
https://github.com/tensorflow/tensorflow/issues/822#issuecomment-173362529
.

I don't know your script X and what git commands executes but I see the Y effects. E.g. When merged I see:
vrv merged commit 9d5d3d0 into tensorflow:master 6 hours ago

When closed I see:
vrv closed this in 90fb80a 6 hours ago

So seems to me that the second case was closed only by commit message special syntax like "Closing".

Interestingly, all the PRs merged via script have that message (Closes #XXX). Sometimes they show up closes and sometimes merged. May be a race condition what process first does the close/merge. I'll remove the "Closes ..." from the message to see if that fixes it.

Then the PR sometimes remains open. Give it a shot though

I repeat I don't know you exact git command sequence execution but @vrv declared that the sequence was always the same. So I suspected the race condition.

I just merged #826 without the "Closes #826" part and that seemed to work.
I hope we don't get PRs staying open this way again.
On Wed, Jan 20, 2016 at 4:14 PM bhack<EMAIL_ADDRESS>wrote:

I repeat I don't know you exact git command sequence execution but @vrv
https://github.com/vrv declared that the sequence was always the same.
So I suspected the race condition.
—
Reply to this email directly or view it on GitHub
https://github.com/tensorflow/tensorflow/issues/822#issuecomment-173409660
.

@martinwicke If you are interested this is an opensource customizable little Kanban style project board for Github Tensorflow https://waffle.io/tensorflow/tensorflow

Thanks! That looks useful.
On Thu, Jan 21, 2016 at 2:46 AM bhack<EMAIL_ADDRESS>wrote:

@martinwicke https://github.com/martinwicke If you are interested this
is an opensource customizable little Kanban style project board for Github
Tensorflow https://waffle.io/tensorflow/tensorflow
—
Reply to this email directly or view it on GitHub
https://github.com/tensorflow/tensorflow/issues/822#issuecomment-173534271
.

This has worked but have the "Closes" syntax in the commit message: https://github.com/tensorflow/tensorflow/pull/832

Yeah, I was using a stale script, I've updated since then.  I'm about to
merge another change so we'll see if that removes the race.
On Thu, Jan 21, 2016 at 11:36 AM, bhack<EMAIL_ADDRESS>wrote:

This has worked but have the "Closes" syntax in the commit message: #832
https://github.com/tensorflow/tensorflow/pull/832
—
Reply to this email directly or view it on GitHub
https://github.com/tensorflow/tensorflow/issues/822#issuecomment-173684773
.

https://github.com/tensorflow/tensorflow/commit/b11337ea5719a8799f279a41c2cd5c9e75a8acf7
Didn't merge the PR.  Sigh.

My guess is that because we rebase, it doesn't think we merged the PR.  When the existing PR is already synced to current HEAD, it will say "Merged".  I don't see a way around this -- basically github expects you to click their merge button.  I'd rather have the PRs automatically closed: at least their closing statement mentions the commit it was in.

Agreed. We'll have this script do more things in the future (like
squashing, upon request, and testing), so the merge button just won't cut
it. Sad for record-keeping, but otherwise shouldn't be a big problem.
On Thu, Jan 21, 2016 at 11:46 AM Vijay Vasudevan<EMAIL_ADDRESS>wrote:

My guess is that because we rebase, it doesn't think we merged the PR.
When the existing PR is already synced to current HEAD, it will say
"Merged". I don't see a way around this -- basically github expects you to
click their merge button. I'd rather have the PRs automatically closed: at
least their closing statement mentions the commit it was in.
—
Reply to this email directly or view it on GitHub
https://github.com/tensorflow/tensorflow/issues/822#issuecomment-173687973
.

Generally other projects ask to rebase and squash to the contributor before merging. If this will be the policy I think the merge by script will be safe. What do you think?

We do ask contributors to squash, but if we require our clients to rebase, every time we accept another PR we'll have to ask the client to re-rebase :).  Since we own the merging process, it makes more sense for us to do the rebasing.

What do you think of http://stackoverflow.com/questions/27740369/pull-requests-merged-manually-after-a-rebase-dont-show-as-merged-on-github?

And also http://blog.differential.com/best-way-to-merge-a-github-pull-request/

Yup, the section under "Catch Feature Up with Master by Rebasing, then merge --no-ff" is exactly what our script is doing.  The point is that we're the ones doing that, rather than the author.
It seems the best solution would be for github to have special magic like "Closes #PR" but for "Merges #PR".

@vrv It seems someone have contacted github support https://github.com/nodejs/node/issues/4176

@vrv Found the (half)official ticket https://github.com/isaacs/github/issues/2.

Thanks for finding that!  Doesn't lend confidence in that getting implemented any time soon though. :/


Parent selectors resolve to different rules due to hash classnames

I think I found a possible missbehaviour when using props and siblings . (Or probably just the className placeholder in general).
Version
1.0.5
Reproduction
https://www.webpackbin.com/bins/-Kjc_PkTewh0QoJ0kJNn
Steps to reproduce
Create a component with the sibling syntax that use some props for it's rules.
Expected Behavior
The sibling rules would be applied to all props class variants
Actual Behavior
The component get's styled with the sibling rules on the prop specific class.

Interesting. This wouldn't happen if the & selector used the sc--prefixed className that doesn't change based on props, but not sure if this would have other side effects.

Will take a look on this prefix and let you know. It may be at least a workaround for this specific case.
If this is indeed a missbehaviour I would be glad to make a PR with tests in the near future

This is not misbehaviour but intended.
Imagine a case where you'd write this:
const Button = styled.button`
  color: black;

  ${p => p.addHover && css`
    &:hover {
      color: violet;
    }
  `}
`

<Button />
<Button addHover />

What you're referring to with the sc-* classes are classes based on the component id. The button has a single component id, and its sc-x class refers to all its variations.
In the above example, if we'd target this sc-x class instead for the parental selector (i.e. ampersand selector), then both buttons would suddenly have the above pseudo class.
I'd suggest you to just avoid using this selector altogether while altering the classes. Don't forget that two components, with different props, rendering different CSS, will also be decoupled from each other. By this thinking, this behaviour does make sense ;)

I get the rationale that each component with a prop would be it's own thing.
I didn't quite got this "sc-" part. Can I leverage it to get this behaviour of the same rule for all siblings even if they use different props?

I'd suggest you to just avoid using this selector altogether while altering the classes.

By that quote You are meaning sibling selectors?

This is not misbehaviour but intended.

Let's say it's intended misbehaviour then. ;)
I've always thought that generating an entirely new CSS class for each variation was kind of inelegant.
Ideally styled-components would (somehow) smartly split all the CSS rules for a given component into dynamic & static bits and assign each bit its own hashed className (and add all of these classes to the rendered component). Similar to how you'd write classes and modifier classes in a methodology like BEM.
This way static rules (which don't change based on props) would apply to all instances of a component, and the dynamic bits would all have their own dedicated "modifier" classes.
This would also make working with styled-components in browser dev tools much nicer.

I didn't quite got this "sc-" part. Can I leverage it to get this behaviour of the same rule for all siblings even if they use different props?

Not really. One workaround would be manually adding a component-specific static className which you can then target in your CSS, like this:
const Parent = styled.span.attrs({
  className: 'self'
})`
 color: ${(props) => props.isBlack? 'black' : 'palevioletred'};
 border: 2px palevioletred solid;
 .self + & {
   margin-left: 3em;
   color: tomato;
  }
`

If you were planning to do this in more than one component, you should prevent potential conflicts by randomising the className.

Yeah the sc- is kind of a placeholder for the moment. Hoisting the static styles into another class is definitely doable, but you do run into a few potential difficulties when it comes to rule order. At the moment, we duplicate everything because it's safer. In the future, we might do something like extract every rule that is above the first function interpolation. It's sort of low on my priority list but I'd happily look at a PR for it.

We basically just have to differentiate between dynamic and non-dynamic selectors. Which sounds easy, but is in fact tricky during runtime. Especially since we'd need to go through stylis.
One feasible solution is, before we resolve the nested interpolations (functions), we can replace all the parental selectors & with the sc- classname.

@geelen I can do the PR soonish. I would appreciate if you could point me to the part on the code where this thing is being made. Also just for me to get the correct problem enunciation, would you say that this would be fixed with:

Separating the rules that leverage props from the rules that don't use it and keep these rules on the root class and the props on the child generated classes?

@geelen @drFabio

Separating the rules that leverage props from the rules that don't use it and keep these rules on the root class and the props on the child generated classes?

Sounds to me like it's the exact same code, as the static css extraction, that I already primed on the babel plugin.
https://github.com/styled-components/babel-plugin-styled-components/blob/static-css-extraction/src/css/staticExtractionUtils.js
This is giving me a crazy idea! What if we use "preprocessing" every time we create a component e.g. styled.div. By moving the preprocessing to the runtime we can achieve 100% reusability with the babel plugin, ensure that the logic stays the same, AND use the code that I've already written for the static CSS extraction

Great @drFabio! Definitely work against the v2 branch, and ComponentStyle.js is the file that will most need to change. A good start would be to create a branch and add a bunch of failing tests that describe exactly what output you're expecting. Then if you raise a PR at that point we can have a look and make sure it won't lead to any unexpected output, and point you in the right direction for the implementation as well.

Oh wow @philpl that might be a much more promising option!

Ok @geelen thanks. I will keep that in mind and make a branch on the next couple of days.

if you raise a PR at that point

Are you meaning to make a PR while with the tests still failing just to get feedback?

Just for the record, you can do what @drFabio originally wanted using an interpolation. This is the real reason for sc-, to allow a component to override another:
const X = styled.div`
  > ${ Button } {
    color: red;
  }
`

Renders .hashed-x > .sc-button { color: red; }
Here we can do the same thing but we have to use a function interpolation to delay the value until render time, because Parent isn't defined while it's still being created.

Thanks @geelen  will workaround with that for today and make the PR soon

Are you meaning to make a PR while with the tests still failing just to get feedback?

Yep exactly. Good luck!

@geelen Since you're here soon, we might be able to plan this out in person and start to move the preprocessing + extraction logic to SC :smile: It'd be great to have a momentary solution on v2 for now, @drFabio, since this preprocessing + extraction sounds like sth that'll need some time to stabilise (v3?).

Definitely. Compile time extraction is the big thing for v3 I think.

I made a PR with the failing tests here.
I mostly definetely have this rule wrong but I think the intent is clear.
I tested enzyme to get the className and couldn't found the previously mentioned 'sc-' prefixed hash. I assume that since this is not a reliable feature it is not on the styled used for tests.
I can't quite see a way to do it without adding a ".root" hash and test upon it.

Rounding up my previous conversations with @geelen:

v3 will aim to have preprocessing styles built into the core library, so that the babel plugin just has to execute the same code at build time
v3 will also include static CSS extraction in the same manner, which a webpack plugin can extract into external files (by using the/a babel plugin internally)
This will give us the necessary "breathing room" to solve this issue. Other than that, I wouldn't go ahead with solving this now, as the stylis code will just accumulate cruft :/

Hey, are there any benchmarks on the performance impact of unique classes being generated for lists of items where every item is considered unique due to non-sc props being passed to the underlying element?
I guess this question is somewhat related to #439 since it's about s-c not being able to know which props are actually relevant to styling.
Why I'm asking:
I just noticed that in a big list of items that contain styled Link and img components where each item has unique href/to and src attributes, styled-components will actually create a unique (but identical in content) class for each instance of these components. The list can easily consist of hundreds of items, so I imagine this could cause some problems, but I didn't look into it very far yet. (The whole page isn't very optimised yet (aka it's slow anyway), so it would be hard to reliably measure its performance at the moment.)
Do you have any insights about this to keep my premature optimisation muscle from acting on its itch to replace all of these styled links and images with plain elements & styling them via descendent selectors on a parent component? 😁

@diondiondion the hashes are driven by the content of the CSS and the styled component ID. At least, they should be. So they should all have the same CSS if they are the same SC with the same CSS (regardless of the props generated).
Can you post a reproduction? You're not defining the SC inside a render method or loop or something, are you?

the hashes are driven by the content of the CSS and the styled component ID. At least, they should be.

And they are, mea culpa. I failed to notice a pseudo element with differing background images in it that caused the hashes to differ for my links; then rashly attributed it to the wrong thing, sorry. 🙈

No worries. I'll close this issue now in favour of #784.


Confusion about the comment in the sampling method

I am confused with the below setences... In train/utils/loss_mask.py Line67
    # It is crucial to calculate uncertainty based on the sampled prediction value for the points.
    # Calculating uncertainties of the coarse predictions first and sampling them for points leads
    # to incorrect results.
    # To illustrate this: assume uncertainty_func(logits)=-abs(logits), a sampled point between
    # two coarse predictions with -1 and 1 logits has 0 logits, and therefore 0 uncertainty value.
    # However, if we calculate uncertainties for the coarse predictions first,
    # both will have -1 uncertainty, and the sampled point will get -1 uncertainty.

Why the two coarse predictions with -1 and 1 logits has 0 logits, and therefore 0 uncertainty value.  Is the bilinear upsample caused?

Hi，this function comments explain the point sampling strategies when computing mask losses. It is "a sampled point between two coarse predictions with -1 and 1 logits has 0 logits", '0 logits' indicates most uncertain point thus it achieves maximal value for function -abs(logits).

So, Why a sampled point between two coarse predictions with -1 and 1 logits has 0 logits ? Is the bilinear upsample caused?


Search: please add url and ID search in the JDA home page.

Please add the url & ID search in the JDA home page search.  Adding the url & ID search makes the collection making processs a lot easier for the web harvesting team.

Hi Koko, do you mean that, by typing the URL or ID into the search box, you want the item from our database to appear in the search results? I think this is what you mean, I just want to be positive! thanks.

Yes.  I am sorry it wasn't clear.  Thank you very much for working on  a lot of issues lately.  I am very grateful that the IT Crowd has been very helpful to our web harvesting team.


Source of truth on markets

This library is awesome! Can we update the README to indicate that this file should be treated as an up-to-date source of truth for markets and coins?
https://github.com/project-serum/serum-js/blob/master/src/tokens_and_markets.ts
So that users of pyserum don't show up to bat and only see deprecated markets :)

Added clarification in README.


Add RES8 repos to mirror

What does this PR change?
Adds missing repos to support CentOS 8 minions/clients using the centos8o image with a mirror.

@srbarrios please take a look and feel free to just merge. Your option to test this in isolation.


allow simultaneous query and ref skips in map merging

Also removes the kmer canonicality check in mash distance in wflign.

This will also resolve #28, using a more direct solution.


Document F12 for Bicep Registry

https://learn.microsoft.com/en-us/azure/azure-resource-manager/bicep/private-module-registry?tabs=azure-cli#publish-files-to-registry: mention it is now possible to publish Bicep modules with source code. Commands:
ps: Publish-AzBicepModule -FilePath ./storage.bicep -Target br:exampleregistry.azurecr.io/bicep/modules/storage:v1 -DocumentationUri https://www.contoso.com/exampleregistry.html -WithSource
az cli: az bicep publish --file {bicep_file} --target "br:{registry}/{module_path}:{tag}" --documentationUri {documentationUri} --with-source

Document F12 in https://learn.microsoft.com/en-us/azure/azure-resource-manager/bicep/visual-studio-code?tabs=CLI#restore-bicep-modules. If a module is published with source code to a registry, you can use F12 (Go to Definition) to see the Bicep Code. Note that if the Bicep module references a module in a Private Registry, the ACR end point will be visible. To hide the full end point, you can configure an alias for the private registry.

Related to https://github.com/Azure/bicep/issues/13782

NOTES:
THe first article (Create private registry for Bicep module - Azure Resource Manager | Microsoft Learn) goes into how the files look in the ACR.  We should probably show what it looks like if it has source code published (there's another layer in the manifest containing the source.tgz file, which will also end up in the local registry cache when the module is restored).

Document F12 in https://learn.microsoft.com/en-us/azure/azure-resource-manager/bicep/visual-studio-code?tabs=CLI#restore-bicep-modules. If a module is published with source code to a registry, you can use F12 (Go to Definition) to see the Bicep Code. Note that if the Bicep module references a module in a Private Registry, the ACR end point will be visible. To hide the full end point, you can configure an alias for the private registry.

Example:  Suppose the module you're publishing is named 'module1' and it references a separate, private module 'module2' eg:
module module2 'br:myregistry.azurecr.io/myrepo/mymodule2:v1' = {
  name: 'module2'
}

If module1 is published with source, then clients that reference module1 will be able to F12 to see module1's source.  Thus they will see the string br:myregistry.azurecr.io/myrepo/mymodule2:v1 which contains the registry ID.  If they don't like that, they can add an alias to the bicepconfig.json file, e.g.:
{
  "moduleAliases": {
    "br": {
      "myprivatereg": {
        "registry": "myregistry.azurecr.io",
        "modulePath": "myrepo"
      }
    }
  }
}

and then instead reference module2 like this:
module module2 'br/myprivateregistry:mymodule2:v1' = {
  name: 'module2'
}

The bicepconfig.json is not published with the sources, so clients of module1 will not be able to see module2's registry id.
Note however that they will be able to F12 and see module's compiled JSON source (it will be part of module1's compiled JSON so can't be hidden).  This is not new, it's always been like this.
Also, if module2 was published with source as well, then clients of module1 can theoretically see module2's registry ID because it's required in order for module1 clients with access to module2's registry to be able to F12 on module2 and see its source.  The registry ID will be located in the __metadatafile file inside the source.tgz file.
Feel free to set up a meeting for questions.

NOTE: the experimental flag has been removed, so --with-source will officially ship as part of 0.27

@puicchan, @StephenWeatherford - I have a module published with two different versions, one with WithSource and the other without the WithSource switch. I am able to see the source by clicking F12 from VSCode for both versions.

@mumian, did you see Bicep code for both versions? You should see Bicep code only for the version published with (Bicep) source, else you see the compiled JSON.

@puicchan - I realize 0.27 is not released yet.  Also, do you know what versions of the Azure PowerShell and Azure CLI support the withSource switch?

@StephenWeatherford, @puicchan - If you hover over a symbolic name, it gives the context menu where you can click "View Documentation".  Are you going to do the same for "Go to definition"?


[MINOR][DOC] Add an up-to-date description for default serialization during shuffling

What changes were proposed in this pull request?
This PR aims to make the doc up-to-date. The documentation is generally correct, but after https://issues.apache.org/jira/browse/SPARK-13926, Spark starts to choose Kyro as a default serialization library during shuffling of simple types, arrays of simple types, or string type.
How was this patch tested?
This is a documentation update.

Test build #66185 has started for PR 15315 at commit 3dfa0d9.

Test build #66185 has finished for PR 15315 at commit 3dfa0d9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66185/
Test PASSed.

Thank you for reviewing and approving, @srowen !

I've merged this in master/2.0.

Thank you, @rxin and @srowen .


Support for pulling images from private registry

We want to build Tekton pipelines but the container images are hosted on private registry. Previously we set ImagePullSecrets in PodSpec to do it.

Nvm. We can use service account.


expand: Continue work when one of given files doesn't exist

Should fix https://github.com/uutils/coreutils/issues/5872
I also added the unit test.

Thanks for your PR :)


Clear from Least recently used

The option, --order asc, has been already added, so close this issue.


How to download image?

Based on my understanding of craw4ai, it seems there's no direct way to download images using Playwright. Do I have to make a new request? That seems like redundant work.

@xxxspy Thx for trying our library. Crawl4ai returns links to internal and external images, along with relevance scores and textual information. You can then handle downloading the images yourself and use the textual information for applications like information retrieval or image classification. We prioritize generating links to images quickly, and downloading can be done separately using a custom implementation.
However, I think it's a good idea to add an optimized downloader to our library, which could offer parameters for output resolution size. This is a useful suggestion, and I'll consider adding it to our backlog. Thx for the suggestion


Add some color to the site

Due to overuse of the default Bootstrap look-and-feel, the site looks blandly white, like a hard-boiled egg. It'd be nice to get a red/white/black color-scheme in there (i.e., Pokeball colors).

Fixed (or close enough) by commit 1f816cd6aff74380abec62deafd1fb7f40e2df38