Compile issues by gcc-13

Hi everyone
I meet a issues when using grasp, which compiled by gcc-13.
The server of my teammate was recently upgraded from Fedora 37 to 39. In Fedora 39, the default GCC compilation is gcc-13. We were able to successfully compile Grasp; however, we noticed some discrepancies between the example in the manual (6.5. Fifth Example: The Study of Energy Spectra for Ni XIV, Obtaining Unique Labels) and our own results.
1. rcsfinteract
We get different results from rcsfinteract with same command:

the result get from gcc-11 version, which is the same with the manual

 RCSFinteract: Determines all the CSFs (rcsf.inp) that interact
               with the CSFs in the multireference (rcsfmr.inp)
               (C)  Copyright by G. Gaigalas and Ch. F. Fischer
               (Fortran 95 version)               NIST  (2021).
               Input files: rcsfmr.inp, rcsf.inp
               Output file: rcsf.out

 Reduction based on Dirac-Coulomb (1) or
 Dirac-Coulomb-Breit (2) Hamiltonian?
2
 Loading Configuration Symmetry List File ...
 There are 16 relativistic subshells;
  Block    MR NCSF   Before NCSF   After NCSF
    1            8         1664         1047
    2           11         2837         1862
    3           10         3271         2112
    4            5         2972         1537
    5            2         2264          801

 Wall time:
        1 seconds

 Finish Date and Time:
   Date (Yr/Mon/Day): 2023/12/13
   Time (Hr/Min/Sec): 19/30/02.690
   Zone: +0800

 RCSFinteract: Execution complete.

the result get from gcc-13 version

 RCSFinteract: Determines all the CSFs (rcsf.inp) that interact
               with the CSFs in the multireference (rcsfmr.inp)
               (C)  Copyright by G. Gaigalas and Ch. F. Fischer
               (Fortran 95 version)               NIST  (2021).
               Input files: rcsfmr.inp, rcsf.inp
               Output file: rcsf.out

 Reduction based on Dirac-Coulomb (1) or
 Dirac-Coulomb-Breit (2) Hamiltonian?
2
 Loading Configuration Symmetry List File ...
 There are 16 relativistic subshells;
  Block    MR NCSF   Before NCSF   After NCSF
    1            8         1664         1142
    2           11         2837         2058
    3           10         3271         2362
    4            5         2972         1770
    5            2         2264          909

 Wall time:
        1 seconds

 Finish Date and Time:
   Date (Yr/Mon/Day): 2023/12/13
   Time (Hr/Min/Sec): 19/32/43.439
   Zone: +0800

 RCSFinteract: Execution complete.

2. rmchdf and rci
I applied the identical procedure as that of manual operation and obtained the following outcome:
1.the result get from gcc-11 version, which is the same with the manual
------------------------------------------------------------------------------------------
No  Pos  J   Parity  Energy Total  Levels          Splitting     Configuration
                      (a.u.)        (cm^-1)         (cm^-1)
------------------------------------------------------------------------------------------
1   1  3/2     -    -1443.2224318       0.00            0.00    2s(2).2p(6).3s(2).3p(3)4S3_4S
2   2  3/2     -    -1443.0055953   47590.12        47590.12    2s(2).2p(6).3s(2).3p(3)2D3_2D
3   1  5/2     -    -1442.9699841   55405.86         7815.74    2s(2).2p(6).3s(2).3p(3)2D3_2D
4   1  1/2     -    -1442.8231291   87636.81        32230.95    2s(2).2p(6).3s(2).3p(3)2P1_2P
5   3  3/2     -    -1442.7718374   98894.05        11257.25    2s(2).2p(6).3s(2).3p(3)2P1_2P
6   1  5/2     +    -1441.7819193  316155.95       217261.89    2s(2).2p(6).3s_2S.3p(4)3P2_4P
7   1  3/2     +    -1441.7163490  330546.97        14391.02    2s(2).2p(6).3s_2S.3p(4)3P2_4P
8   1  1/2     +    -1441.6893375  336475.31         5928.35    2s(2).2p(6).3s_2S.3p(4)3P2_4P
9   2  3/2     +    -1441.4303647  393313.26        56837.95    2s(2).2p(6).3s_2S.3p(4)1D2_2D
10  2  5/2     +    -1441.4141226  396877.99         3564.73    2s(2).2p(6).3s_2S.3p(4)1D2_2D
 .........

the result get from gcc-13 version

rlevels Ni_even_n4.cm Ni_odd_n4.cm
 nblock =            5   ncftot =         8241   nw =           16   nelec =           15
 nblock =            3   ncftot =         1352   nw =           16   nelec =           15

 Energy levels for ...
 Rydberg constant is<PHONE_NUMBER>9
 Splitting is the energy difference with the lower neighbor
------------------------------------------------------------------------------------------
 No Pos  J Parity Energy Total    Levels     Splitting     Configuration
                      (a.u.)      (cm^-1)     (cm^-1)
------------------------------------------------------------------------------------------
  1  1  5/2 +   -1521.6305278        0.00        0.00    2s(2).2p(6).3s_2S.3p(2)3P2_4P.3d(2)3P2_6D
  2  1  7/2 +   -1521.5555329    16459.47    16459.47    2s(2).2p(6).3s_2S.3p(2)3P2_4P.3d(2)3P2_6D
  3  1  3/2 +   -1521.3337119    65143.56    48684.09    2s(2).2p(6).3s_2S.3p(2)3P2_4P.3d(2)3P2_6P
  4  1  1/2 +   -1520.1621637   322268.67   257125.11    2s(2).2p(6).3s_2S.3p(2)3P2_4P.3d(2)3P2_4P
  5  2  5/2 +   -1519.9963675   358656.72    36388.05    2s(2).2p(6).3s_2S.3p(2)3P2_4P.3d(2)3P2_4D
  6  2  7/2 +   -1519.8619203   388164.47    29507.76    2s(2).2p(6).3s_2S.3p(2)3P2_4P.3d(2)3F2_4G
  7  2  3/2 +   -1519.7382993   415296.15    27131.67    2s(2).2p(6).3s_2S.3p(2)3P2_4P.3d(2)3F2_6F
  8  1  9/2 +   -1519.4806089   471852.64    56556.49    2s(2).2p(6).3s_2S.3p(2)3P2_4P.3d(2)3F2_6G
  9  3  5/2 +   -1516.9624557  1024523.40   552670.76    2s(2).2p(6).3s_2S.3p(2)3P2_4P.3d(2)3F2_6F
 10  2  1/2 +   -1514.9211333  1472541.88   448018.48    2s(2).2p(6).3s_2S.3p(2)3P2_4P.3d(2)3F2_6F
 .........

The "energy total" of the second result obtained for calculation is significantly lower than the value indicated in the manual. Conversely, when using the same rcsf.inp file (first result) for performing the identical calculation, the outcome remains incorrect.
I want to know what the problem is and how to fix it.
Thank you for taking the time to read my question, and I would appreciate it if you could give me a little help.
Have a nice day!

Hi,
Generally, if the code compiles successfully, the problem you described is not expected. Could you please make sure that:

The script/command/input files are exactly identical for your two runs.
Make sure you did a fresh compile from the very beginning(start a new compilation with make clean), which means you didn't not mix any of the existing object files (.o files from the old version of gcc, etc) as well as mod file (mod) within the build. AFAIK, if that happens it might lead to your problem.  Also, beware of the existing libraries such as LAPACK/BLAS, if they are not proper upgrade, things would occurs, either.

Best,
wx

Dear Jinzhe
Thank you for reporting these problems.
To deal with them, you should go to the librang90 library and make the changes in diaga1 to diaga5 (see below)
so that IAT has the intent(inout)
Make these changes and recompile the full package and try your reported cases again.
Please let us know if this solved your problems or if there are remaining issues.
Best wishes
Gedimnas Gaigalas and Per Jönsson
librangular:

DIAGA1

  INTEGER, INTENT(INOUT)      :: IAT

DIAGA2

  INTEGER, INTENT(INOUT)      :: IAT

DIAGA3

  INTEGER, INTENT(INOUT)      :: IAT

DIAGA4

  INTEGER, INTENT(INOUT)      :: IAT

DIAGA5

  INTEGER, INTENT(INOUT)      :: IAT

From: JinzheZhang @.>
Sent: Wednesday, December 13, 2023 3:42 PM
To: compas/grasp @.>
Cc: Subscribed @.***>
Subject: [compas/grasp] Compile issues by gcc-13 (Issue #112)
Hi everyone
I meet a issues when using grasp, which compiled by gcc-13.
The server of my teammate was recently upgraded from Fedora 37 to 39. In Fedora 39, the default GCC compilation is gcc-13. We were able to successfully compile Grasp; however, we noticed some discrepancies between the example in the manual (6.5. Fifth Example: The Study of Energy Spectra for Ni XIV, Obtaining Unique Labels) and our own results.

rcsfinteract

We get different results from rcsfinteract with same command:

the result get from gcc-11 version, which is the same with the manual

RCSFinteract: Determines all the CSFs (rcsf.inp) that interact
with the CSFs in the multireference (rcsfmr.inp)
(C)  Copyright by G. Gaigalas and Ch. F. Fischer
(Fortran 95 version)               NIST  (2021).
Input files: rcsfmr.inp, rcsf.inp
Output file: rcsf.out
Reduction based on Dirac-Coulomb (1) or
Dirac-Coulomb-Breit (2) Hamiltonian?
2
Loading Configuration Symmetry List File ...
There are 16 relativistic subshells;
Block    MR NCSF   Before NCSF   After NCSF
1            8         1664         1047
2           11         2837         1862
3           10         3271         2112
4            5         2972         1537
5            2         2264          801
Wall time:
1 seconds
Finish Date and Time:
Date (Yr/Mon/Day): 2023/12/13
Time (Hr/Min/Sec): 19/30/02.690
Zone: +0800
RCSFinteract: Execution complete.

the result get from gcc-13 version

RCSFinteract: Determines all the CSFs (rcsf.inp) that interact
with the CSFs in the multireference (rcsfmr.inp)
(C)  Copyright by G. Gaigalas and Ch. F. Fischer
(Fortran 95 version)               NIST  (2021).
Input files: rcsfmr.inp, rcsf.inp
Output file: rcsf.out
Reduction based on Dirac-Coulomb (1) or
Dirac-Coulomb-Breit (2) Hamiltonian?
2
Loading Configuration Symmetry List File ...
There are 16 relativistic subshells;
Block    MR NCSF   Before NCSF   After NCSF
1            8         1664         1142
2           11         2837         2058
3           10         3271         2362
4            5         2972         1770
5            2         2264          909
Wall time:
1 seconds
Finish Date and Time:
Date (Yr/Mon/Day): 2023/12/13
Time (Hr/Min/Sec): 19/32/43.439
Zone: +0800
RCSFinteract: Execution complete.

rmchdf and rci

I applied the identical procedure as that of manual operation and obtained the following outcome:
1.the result get from gcc-11 version, which is the same with the manual

No  Pos  J   Parity  Energy Total  Levels          Splitting     Configuration
(a.u.)        (cm^-1)         (cm^-1)
1   1  3/2     -    -1443.2224318       0.00            0.00    2s(2).2p(6).3s(2).3p(3)4S3_4S
2   2  3/2     -    -1443.0055953   47590.12        47590.12    2s(2).2p(6).3s(2).3p(3)2D3_2D
3   1  5/2     -    -1442.9699841   55405.86         7815.74    2s(2).2p(6).3s(2).3p(3)2D3_2D
4   1  1/2     -    -1442.8231291   87636.81        32230.95    2s(2).2p(6).3s(2).3p(3)2P1_2P
5   3  3/2     -    -1442.7718374   98894.05        11257.25    2s(2).2p(6).3s(2).3p(3)2P1_2P
6   1  5/2     +    -1441.7819193  316155.95       217261.89    2s(2).2p(6).3s_2S.3p(4)3P2_4P
7   1  3/2     +    -1441.7163490  330546.97        14391.02    2s(2).2p(6).3s_2S.3p(4)3P2_4P
8   1  1/2     +    -1441.6893375  336475.31         5928.35    2s(2).2p(6).3s_2S.3p(4)3P2_4P
9   2  3/2     +    -1441.4303647  393313.26        56837.95    2s(2).2p(6).3s_2S.3p(4)1D2_2D
10  2  5/2     +    -1441.4141226  396877.99         3564.73    2s(2).2p(6).3s_2S.3p(4)1D2_2D
.........

the result get from gcc-13 version

rlevels Ni_even_n4.cm Ni_odd_n4.cm
nblock =            5   ncftot =         8241   nw =           16   nelec =           15
nblock =            3   ncftot =         1352   nw =           16   nelec =           15
Energy levels for ...
Rydberg constant is<PHONE_NUMBER>9
Splitting is the energy difference with the lower neighbor
No Pos  J Parity Energy Total    Levels     Splitting     Configuration
(a.u.)      (cm^-1)     (cm^-1)
1  1  5/2 +   -1521.6305278        0.00        0.00    2s(2).2p(6).3s_2S.3p(2)3P2_4P.3d(2)3P2_6D
2  1  7/2 +   -1521.5555329    16459.47    16459.47    2s(2).2p(6).3s_2S.3p(2)3P2_4P.3d(2)3P2_6D
3  1  3/2 +   -1521.3337119    65143.56    48684.09    2s(2).2p(6).3s_2S.3p(2)3P2_4P.3d(2)3P2_6P
4  1  1/2 +   -1520.1621637   322268.67   257125.11    2s(2).2p(6).3s_2S.3p(2)3P2_4P.3d(2)3P2_4P
5  2  5/2 +   -1519.9963675   358656.72    36388.05    2s(2).2p(6).3s_2S.3p(2)3P2_4P.3d(2)3P2_4D
6  2  7/2 +   -1519.8619203   388164.47    29507.76    2s(2).2p(6).3s_2S.3p(2)3P2_4P.3d(2)3F2_4G
7  2  3/2 +   -1519.7382993   415296.15    27131.67    2s(2).2p(6).3s_2S.3p(2)3P2_4P.3d(2)3F2_6F
8  1  9/2 +   -1519.4806089   471852.64    56556.49    2s(2).2p(6).3s_2S.3p(2)3P2_4P.3d(2)3F2_6G
9  3  5/2 +   -1516.9624557  1024523.40   552670.76    2s(2).2p(6).3s_2S.3p(2)3P2_4P.3d(2)3F2_6F
10  2  1/2 +   -1514.9211333  1472541.88   448018.48    2s(2).2p(6).3s_2S.3p(2)3P2_4P.3d(2)3F2_6F
.........
The "energy total" of the second result obtained for calculation is significantly lower than the value indicated in the manual. Conversely, when using the same rcsf.inp file (first result) for performing the identical calculation, the outcome remains incorrect.
I want to know what the problem is and how to fix it.
Thank you for taking the time to read my question, and I would appreciate it if you could give me a little help.
Have a nice day!
—
Reply to this email directly, view it on GitHubhttps://github.com/compas/grasp/issues/112, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADDLFVENK3MZIPA2SQHJ6NLYJG5DVAVCNFSM6AAAAABATJANDKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAZTSOBVGY4DENI.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

Dear Per,
Dear Jinzhe,
Please find the subroutines which you need to substitute the old ones with in the librang90 (directory GRASP-2018\src\lib\librang90).
In this case we will not have any problems with gfortran V13, too.
Best wishes,
Gediminas
From: Per Jönsson @.>
Sent: Wednesday, January 3, 2024 3:55 PM
To: compas/grasp @.>; compas/grasp @.>
Cc: Gediminas Gaigalas @.>; Wenxian Li @.***>
Subject: Re: [compas/grasp] Compile issues by gcc-13 (Issue #112)
Dear Jinzhe
Thank you for reporting these problems.
To deal with them, you should go to the librang90 library and make the changes in diaga1 to diaga5 (see below)
so that IAT has the intent(inout)
Make these changes and recompile the full package and try your reported cases again.
Please let us know if this solved your problems or if there are remaining issues.
Best wishes
Gedimnas Gaigalas and Per Jönsson
librangular:

DIAGA1

  INTEGER, INTENT(INOUT)      :: IAT

DIAGA2

  INTEGER, INTENT(INOUT)      :: IAT

DIAGA3

  INTEGER, INTENT(INOUT)      :: IAT

DIAGA4

  INTEGER, INTENT(INOUT)      :: IAT

DIAGA5

  INTEGER, INTENT(INOUT)      :: IAT

From: JinzheZhang<EMAIL_ADDRESS>Sent: Wednesday, December 13, 2023 3:42 PM
To: compas/grasp<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [compas/grasp] Compile issues by gcc-13 (Issue #112)
Hi everyone
I meet a issues when using grasp, which compiled by gcc-13.
The server of my teammate was recently upgraded from Fedora 37 to 39. In Fedora 39, the default GCC compilation is gcc-13. We were able to successfully compile Grasp; however, we noticed some discrepancies between the example in the manual (6.5. Fifth Example: The Study of Energy Spectra for Ni XIV, Obtaining Unique Labels) and our own results.

rcsfinteract

We get different results from rcsfinteract with same command:

the result get from gcc-11 version, which is the same with the manual

RCSFinteract: Determines all the CSFs (rcsf.inp) that interact
           with the CSFs in the multireference (rcsfmr.inp)

           (C)  Copyright by G. Gaigalas and Ch. F. Fischer

           (Fortran 95 version)               NIST  (2021).

           Input files: rcsfmr.inp, rcsf.inp

           Output file: rcsf.out

Reduction based on Dirac-Coulomb (1) or
Dirac-Coulomb-Breit (2) Hamiltonian?
2
Loading Configuration Symmetry List File ...
There are 16 relativistic subshells;
Block    MR NCSF   Before NCSF   After NCSF
1            8         1664         1047

2           11         2837         1862

3           10         3271         2112

4            5         2972         1537

5            2         2264          801

Wall time:
    1 seconds

Finish Date and Time:
Date (Yr/Mon/Day): 2023/12/13
Time (Hr/Min/Sec): 19/30/02.690
Zone: +0800
RCSFinteract: Execution complete.

the result get from gcc-13 version

RCSFinteract: Determines all the CSFs (rcsf.inp) that interact
           with the CSFs in the multireference (rcsfmr.inp)

           (C)  Copyright by G. Gaigalas and Ch. F. Fischer

           (Fortran 95 version)               NIST  (2021).

           Input files: rcsfmr.inp, rcsf.inp

           Output file: rcsf.out

Reduction based on Dirac-Coulomb (1) or
Dirac-Coulomb-Breit (2) Hamiltonian?
2
Loading Configuration Symmetry List File ...
There are 16 relativistic subshells;
Block    MR NCSF   Before NCSF   After NCSF
1            8         1664         1142

2           11         2837         2058

3           10         3271         2362

4            5         2972         1770

5            2         2264          909

Wall time:
    1 seconds

Finish Date and Time:
Date (Yr/Mon/Day): 2023/12/13
Time (Hr/Min/Sec): 19/32/43.439
Zone: +0800
RCSFinteract: Execution complete.

rmchdf and rci

I applied the identical procedure as that of manual operation and obtained the following outcome:
1.the result get from gcc-11 version, which is the same with the manual

No  Pos  J   Parity  Energy Total  Levels          Splitting     Configuration
                  (a.u.)        (cm^-1)         (cm^-1)

1   1  3/2     -    -1443.2224318       0.00            0.00    2s(2).2p(6).3s(2).3p(3)4S3_4S
2   2  3/2     -    -1443.0055953   47590.12        47590.12    2s(2).2p(6).3s(2).3p(3)2D3_2D
3   1  5/2     -    -1442.9699841   55405.86         7815.74    2s(2).2p(6).3s(2).3p(3)2D3_2D
4   1  1/2     -    -1442.8231291   87636.81        32230.95    2s(2).2p(6).3s(2).3p(3)2P1_2P
5   3  3/2     -    -1442.7718374   98894.05        11257.25    2s(2).2p(6).3s(2).3p(3)2P1_2P
6   1  5/2     +    -1441.7819193  316155.95       217261.89    2s(2).2p(6).3s_2S.3p(4)3P2_4P
7   1  3/2     +    -1441.7163490  330546.97        14391.02    2s(2).2p(6).3s_2S.3p(4)3P2_4P
8   1  1/2     +    -1441.6893375  336475.31         5928.35    2s(2).2p(6).3s_2S.3p(4)3P2_4P
9   2  3/2     +    -1441.4303647  393313.26        56837.95    2s(2).2p(6).3s_2S.3p(4)1D2_2D
10  2  5/2     +    -1441.4141226  396877.99         3564.73    2s(2).2p(6).3s_2S.3p(4)1D2_2D
.........

the result get from gcc-13 version

rlevels Ni_even_n4.cm Ni_odd_n4.cm
nblock =            5   ncftot =         8241   nw =           16   nelec =           15
nblock =            3   ncftot =         1352   nw =           16   nelec =           15
Energy levels for ...
Rydberg constant is<PHONE_NUMBER>9
Splitting is the energy difference with the lower neighbor

No Pos  J Parity Energy Total    Levels     Splitting     Configuration
                  (a.u.)      (cm^-1)     (cm^-1)

1  1  5/2 +   -1521.6305278        0.00        0.00    2s(2).2p(6).3s_2S.3p(2)3P2_4P.3d(2)3P2_6D
2  1  7/2 +   -1521.5555329    16459.47    16459.47    2s(2).2p(6).3s_2S.3p(2)3P2_4P.3d(2)3P2_6D
3  1  3/2 +   -1521.3337119    65143.56    48684.09    2s(2).2p(6).3s_2S.3p(2)3P2_4P.3d(2)3P2_6P
4  1  1/2 +   -1520.1621637   322268.67   257125.11    2s(2).2p(6).3s_2S.3p(2)3P2_4P.3d(2)3P2_4P
5  2  5/2 +   -1519.9963675   358656.72    36388.05    2s(2).2p(6).3s_2S.3p(2)3P2_4P.3d(2)3P2_4D
6  2  7/2 +   -1519.8619203   388164.47    29507.76    2s(2).2p(6).3s_2S.3p(2)3P2_4P.3d(2)3F2_4G
7  2  3/2 +   -1519.7382993   415296.15    27131.67    2s(2).2p(6).3s_2S.3p(2)3P2_4P.3d(2)3F2_6F
8  1  9/2 +   -1519.4806089   471852.64    56556.49    2s(2).2p(6).3s_2S.3p(2)3P2_4P.3d(2)3F2_6G
9  3  5/2 +   -1516.9624557  1024523.40   552670.76    2s(2).2p(6).3s_2S.3p(2)3P2_4P.3d(2)3F2_6F
10  2  1/2 +   -1514.9211333  1472541.88   448018.48    2s(2).2p(6).3s_2S.3p(2)3P2_4P.3d(2)3F2_6F
.........
The "energy total" of the second result obtained for calculation is significantly lower than the value indicated in the manual. Conversely, when using the same rcsf.inp file (first result) for performing the identical calculation, the outcome remains incorrect.
I want to know what the problem is and how to fix it.
Thank you for taking the time to read my question, and I would appreciate it if you could give me a little help.
Have a nice day!

Reply to this email directly, view it on GitHubhttps://github.com/compas/grasp/issues/112, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADDLFVENK3MZIPA2SQHJ6NLYJG5DVAVCNFSM6AAAAABATJANDKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAZTSOBVGY4DENI.
You are receiving this because you are subscribed to this thread.Message ID<EMAIL_ADDRESS>

Dear Gedimnas Gaigalas and Per Jönsson:
 Thank you for your reply.According to your description, I made changes to the librang90 library and modified diaga1 to diaga5 so that IAT has the intent(inout). Then, i recompiled twice using gfortran-13, with each compilation process using the system’s original LAPACK, BLAS library (3.11.0-5), and MKL library (version 2024), respectively. Before each compilation, i used the make clean command to clean the compilation environment. Finally, i ran the compiled program according to the example in the manual (6.5. Fifth Example), but the results were still the same as before.

Dear Wenxian,
Thank you for your response. Based on your comment, i can confirm that the script/command/input files were exactly identical for both runs. Additionally, i did use the make clean command before compiling, and during the previous compilation process, i consistently used the LAPACK/BLAS library (3.11.0-5). Later, i modified the librang90 library and changed diaga1 to diaga5 so that IAT has the intent(inout). After that, i recompiled twice using gfortran-13, with each compilation process using the system’s original LAPACK/BLAS library (3.11.0-5), and MKL library (version 2024), respectively. Before each compilation, i used the make clean command to clean the compilation environment. Finally, i ran the compiled program according to the example in the manual (6.5. Fifth Example), but the results were still the same as before.

Dear Gedimnas Gaigalas and Per Jönsson,
I'm glad to receive your reply! That helps me a lot.
According to your description, I made changes to the librang90 library and modified diaga1.f90 to diaga5.f90 and diaga1_I.f90 to diaga5_I.f90 so that IAT has the intent(inout). Then, I used the make clean command to clean the compilation environment and recompiled the package. Finally, I got exactly the same result as in the manual.
With best regards,
Jinzhe

Dear Wenxian,
Thank you for your reply.
I made changes to the librang90 library and modified diaga1.f90 to diaga5.f90 and diaga1_I.f90 to diaga5_I.f90 so that IAT has the intent(inout). Then, I got exactly the same result as in the manual.
With best regards,
Jinzhe

@jinzhezhang020 Great！Glad to know the problem is solved.


trivial-gray-streams

An attempt at replacing some of the implementation-dependent code with trivial-gray-streams, as per issue #4.

The last commit is for issue #6.


Do not show links bar if no links are present on the project

We want to avoid this situation (see second grey - empty - div):

This should be as simple as wrapping the div in an if statement checking that links exist.

This was not easy for a new contributor, but maybe I'm just denser than most. I had to dig into the actual Python code and add a new filter one, unless I missed something. Anyway, I learned something 👍
Check out #1352

Thanks @controversial -- if you see any other issues that you perceive to be not very easy for new contributors, please feel free to flag them via a comment!

Ok @brainwane. Thanks!


Error: undefined method 'connect' for TCPSocket.class

In lib/durian/src/durian/extra/http/client.cr:26:15
26 | TCPSocket.connect hostname, @port, resolver, @connect_timeout
^------
Error: undefined method 'connect' for TCPSocket.class
crystal: 0.35.1

durian:
    git: https://github.com/636f7374/durian.cr.git
    version: 0.1.4

Sorry, there may be some problems with my email, I did not receive your notification to open Issue, say sorry.
This problem has been fixed by d1c66fe, thanks for your feedback.
..., And I just added a new feature to Durian :)


Add alphanum_combinations

Issue #2

Great work! Glad you enjoyed it!
I really like how you did the recursion on substitutes, exactly what I was looking for.
I'm going to delete the binary file, and make it so incrementing n_words passes back to the main function,  and a few other small changes before I merge. I've also realised the spacing in messed up throughout the file.. So ill fix that up later in another commit.
Thanks for being a part of my first Gitcoin bounty.

Hi @nickfarrow, Thank you, that's very kind of you. I'm glad that you liked my work :)
Been a while since I coded in c, But I really enjoyed it.
btw, I really liked the project! I'd be glad to contribute more in the future!


who is cimi?

cimi? who is that. i see your code contains his mark..

The author of the open source project "EaseInterpolator" .
https://github.com/cimi-chen/EaseInterpolator


TLorentzVector ValueError in repr

Using from_ptetaphim to create a TLorentzVector if you pass a large value for eta then pz and e will be np.inf because of the exponential behaviour of sinh with eta. This isn't too much of an issue but if you try to print the TLorentzVector the __repr__ function gives a ValueError because for format code 'g' is unknown for np.inf.
TVector3 should suffer with a similar issue.
Error:
File "uproot_methods/classes/TLorentzVector.py", line 336, in __repr__
    return "TLorentzVector({0:.5g}, {1:.5g}, {2:.5g}, {3:.5g})".format(self._fP._fX, self._fP._fY, self._fP._fZ, self._fE)
ValueError: Unknown format code 'g' for object of type 'str'

No, there's something weirder going on: it's not complaining that numpy.inf can't be formatted by "g", it's complaining that a string (str) can't be formatted by "g".
I'm pretty sure that numpy.inf can be formatted with "g", though it's worth testing. (numpy.nan, too.) However, we've got to figure out why the infinity turns into a string.
Are you persisting it (pickle or something) and then reconstituting it? JSON doesn't accept numpy.inf and numpy.nan, so I turn these into strings for JSON— and hopefully turn them back upon deserialization. I don't see how that applies here because only the metadata gets JSON'ed when picking, etc., not the values in the arrays.
Hmmm.

hmm...true. Just checked and np.inf and np.nan work fine with the 'g' formatter.
I think I understand the cause a bit better now. I can reproduce the error with the following code:
import uproot_methods as um
import awkward as awk

pt = awk.JaggedArray.fromiter([[1.0]])
eta = awk.JaggedArray.fromiter([[1.0]])
phi = awk.JaggedArray.fromiter([[1.0]])
mass = awk.JaggedArray.fromiter([[1.0]])
p4 = um.TLorentzVectorArray.from_ptetaphim(pt, eta, phi, mass)
print(p4)

The issue is passing the JaggedArrays (or even nested lists). First of all, am I using this as intended? The goal is to take the 4 jagged arrays (pt, eta, phi, mass - this is how they're stored in the TTree) and created a jagged array of TLorentzVectors.

I didn't foresee passing JaggedArrays into that constructor, but that means it needs either a better error message or maybe this case should be handled outright.
What's probably happening is that the JaggedArray is being converted into a Numpy object array (because some intermediate step requires a Numpy array) and then there's some error displaying that object array. We should be avoiding the conversation into Numpy object arrays as much as possible— it's a performance bottleneck that makes indexing features fail.
The way this was intended to work, you'd pass flat content arrays into the constructor and then make those the content of a JaggedArray by using the starts and stops of the old array. You probably want that new JaggedArray to have Lorentz vector methods like .mass, etc., so you'd have to construct a JaggedArray with Lorentz methods type
JaggedArrayWithTLorentzVector = awkward.Methods.mixin(uproot_methods.classes.TLorentzVector.ArrayMethods, JaggedArray)
a = JaggedArrayWithTLorentzVector(starts, stops, newcontent)

(to the best of my memory— the arguments could be backward).
This interface wasn't meant for end-user physicists, but a few other people have hit it, too. We'll need some high-level interface to make this sort of thing easy.

Fixed by PR #11.


Install gevent when running on travis, so that gevent transport tests will run, too

@awestendorf, I noticed that gevent transport tests weren't running on Travis, so I submitted this PR to make sure those tests run. The stock gevent doesn't build on pypy at the moment, so the gevent is installed only on the non pypy python versions.

thank you :+1:


Difficult to tell which tests ran in the test observability report.

As a developer working on a project that uploads multiple junit reports to test observability server, I want to see which dashboard data corresponds to which junit report, so that I can debug failure and be certain tests are running correctly
The ably-go SDK  (https://github.com/ably/ably-go) currently uses the test observability server.
On this project three different junit reports are generated. The test observability dashboard shows an Upload ID would it also be possible to show the upload file name? We run the same tests twice (once for json protocol and once for msgpack protocol) at the moment it's very difficult to identify which data is for which protocol.

The server doesn't currently accept a filename - the JUnit test report is just submitted as a Base64-encoded blob inside a JSON object. We'd need to add a field for filename / some other sort of identifier.

Can I suggest getting the web UI to link to the specific workflow run? It looks like we already send the run_id as part of the upload. It still wouldn't be helpful in the case of uploading multiple reports from a single run, but ably-go doesn't do this anymore so might be an easier way to get the behaviour we want?


How I can continue training?

Hi! I to want continue training my Neural Network from the same place where he finished his past training. How doing this?
I did try doing that:
var net = new brain.recurrent.LSTM();

var json = JSON.parse(fs.readFileSync('data.json', 'utf-8'));
net.fromJSON(json);
var data = JSON.parse(fs.readFileSync('dialogs.json', 'utf-8'));

net.train(data, {
	errorThresh: 0.005,  // error threshold to reach
	iterations: 4,   // maximum training iterations
	log: true,           // console.log() progress periodically
	logPeriod: 1,       // number of iterations between logging
	learningRate: 0.3    // learning rate
});

But training starting with start. Can you help me?
P.S. Sorry for my bad English

Duplicate of: https://github.com/harthur-org/brain.js/issues/82


snowswap custom domain

Hi! What is your PR about?

[x] Add images for your space
[x] Add custom domain for your space
[x] Add alias for migrate your space
[ ] Add or edit a skin
~Edit your space with GitHub?~ (deprecated) Please migrate your space to ENS https://docs.snapshot.page/spaces/migrate
~Create your space with GitHub~ (deprecated) Create your space with ENS instead https://docs.snapshot.page/spaces/create

Closing this PR for now, feel free to open it again once you've done the changes.
We have a new method to insert your images without creating a Pull Request. You can now use the Avatar field as your space settings.


relaunch build when pull request is reopened

Hi, first of all thank you for this library.
** Please describe which feature you have a question about? **
automatic building of pull requests on github
** Provide additional details**
When you decide to automatically build pull requests with github the fact of closing the pull request closes the build, but the build doesn't reappear when the pull request is reopened, sadly it seems that misclicks on the close pull request button happen on our code base.

Hi @belgac, thank for reaching out! Currently reopening a closed PR will not start a new build. A workaround would be to duplicate the PR you wanted to re-open. I'll note this as a feature request for now. Thanks!

I believe we have seen this issue when a pull request based off of a feature branch (vs main branch) was rebased against master (after the feature branch was merged, github automatically rebased it). It did not generate a build/deploy for the secondary pull request. (Actually, I'm not sure why a preview build/deploy wasn't created in the first place for that feature-branch-derivative pull request...)

is there any timeline on implementing this feature?


Example Eviction Policies

Hi this is not bug, i just confused about Eviction Policies 😅
Can you give me example for how to using Eviction Policies ?
I want to using FifoEvictionPolicy and then i have added FifoEvictionPolicy in evictionPolicy parameter, but is not work.
Thanks

Hi, you need to set the maxEntries or the eviction is not activated, see an example here on the test harness
I believe this is documented as well in the is documentation paragraph:

Note that the eviction policy is only applied if maxEntries is specified


File upload status is failed

Hi
I'm trying to finetune a model, but got stuck at file upload. The file status always becomes failed after upload. I tried everything including the exact same sample here
When I try to retrieve the status of the uploaded file,
    train_status = openai.File.retrieve(training_id)["status"]
it shows the status of the file is "failed". I still can't find ways to get detailed error messaging. Any support would be great.

@sorinsuciu-msft, any thoughts?

Did you ever solve this issue?
Apologies I couldn't help.

The Azure fine-tuning guide has been updated. Let us know if you're still hitting the same problem.

I see no upload. The file is 2mb. I've tried PDF and TXT and it doesn't upload:


OAuth needed

Asking for GitHub credentials is not acceptable.

This is the way how Travis API v2 was implemented. The app itself doesn't store any credentials, only tokens.
There is a plan to migrate to API v3 and hopefully we don't need to have GitHub credentials anymore.

@Artanicus Could you please confirm if #47 is the same as your request?

Duplicate of #47


ask

can i use direct mp4 url ? i mean like http://examle.com/video.mp4 .

You should be able to, yes. I have in the past - at least for VoD.
If it's a live stream then you may instead want to fetch with something else and write into a named pipe, that way your variants should stay in sync


Question: Implementing Custom Tile Source

I'm new to  OpenSeadragon and have been trying to implement a custom tile source implementation.  We  have our own service that will cut up images into tiles and return them in a json format.
I discovered that if I set the tileSources to the json request url then the getImageInfo method is called.   But I am getting an error that the No TileSource was able to open this request.
Here's my request:
      var viewer = OpenSeadragon({                 id: "openseadragon1",         toolbar: "toolbarDiv",                constrainDuringPan: true,                visibilityRatio: 1,                prefixUrl: "/scripts/images/",            showRotationControl: true,                tileSources: tile_json_request       });
How would I be able to set the TileSource data type?   I have an implementation of TileSource that I think may work but when the code hits my "supports" method the data type is null.   How would I set that data type in the above situation?    Or am I trying to implement this incorrectly?
I've also tried to implement my own TileSource and initialize it like this:
var viewer = OpenSeadragon({         id: "openseadragon1",     toolbar: "toolbarDiv",         constrainDuringPan: true,         visibilityRatio: 1,         prefixUrl: "/scripts/images/",     showRotationControl: true,      tileSources: [{         type: 'nbtileservice',         width: srcWidth,             height: srcHeight,             tilesUrl: tile_json_request      }] });
And I was able to get the 'supports' and 'configure' to fire but the 'getImageInfo' request would not fired.   If this is the path I should take to make this work then I will focus on that and post that code.
Thanks for any help you can offer.
Susan

Have you considered using this: http://openseadragon.github.io/examples/tilesource-custom/ ?
You would just need to implement the proper getTileUrl function.
@iangilman & @ConnerMan  With the new non square tiles support, has the tileSize parameter be changed to tileWidth and tileHeight in this use case? I believe the doc will need to be updated if that is the case.

Yes I have used getTileURL and that works okay but since your documentation suggests other solutions that appear cleaner, I would like to implement them that way.  Meaning instead of making our ajax request outside of the OpenSeadragon setup, I would like to implement it as is described here: https://openseadragon.github.io/docs/OpenSeadragon.TileSource.html

@susanmonnelly To have your "supports" method called, you have to have made a class that extends TileSource and that is attached to the OpenSeadragon namespace with a name that ends in "TileSource", e.g. OpenSeadragon.MyCoolTileSource. Have you done this? If so, and your "supports" method is getting called with null data, sounds like there is something happening with the retrieval code in getImageInfo. I'd be happy to take a look if you want to post a link to your project.
@avandecreme good point about that example page. With the new code, using tileSize as a parameter will still work, but we might as well add mention of tileWidth/tileHeight. I've started a ticket for this:
https://github.com/openseadragon/site-build/issues/76

Thanks @iangilman.
Here's my TileSource implementation.  I've put console.log statements in the code as you can see and I am not seeing the getimageinfo fire or the gettileurl.   'supports' and 'configure' are fired.
I kind of stole it from the OSD code where the TmsTileSource is defined:
(function( $ ){

  /**
   * @class NBTileSource
   * @classdesc A tilesource implementation for NewsBank.
   *
   * @memberof OpenSeadragon
   * @extends OpenSeadragon.TileSource
   * @param {Number} width - the pixel width of the image.
   * @param {Number} height
   * @param {Number} tileSize
   * @param {String} tilesUrl
   */
  $.NBTileSource = function( width, height, tileSize, tilesUrl ) {
    var options;
    console.log('NBTileSource function ');

    if ( $.isPlainObject( width ) ){
        options = width;
    } else {
      options = {
        width: arguments[0],
        height: arguments[1],
        tileSize: arguments[2],
        tilesUrl: arguments[4]
      };
    }

    numTiles= new Object();
    numTiles.x = srcWidth % options.tileSize == 0 ? srcWidth/options.tileSize : Math.floor(srcWidth/options.tileSize) + 1 ;
    numTiles.y = srcHeight % options.tileSize == 0 ? srcHeight/options.tileSize : Math.floor(srcHeight/options.tileSize) + 1 ;

    options.width = numTiles.x*options.tileSize;
    options.height = numTiles.y*options.tileSize;
    options.maxLevel = 1;
    options.tileSize = 256;

    console.log('NBTileSource this ' + this);
    console.log('NBTileSource options.tilesUrl ' + options.tilesUrl);
    $.TileSource.apply( this, [ options ] );

  };

  $.extend( $.NBTileSource.prototype, $.TileSource.prototype, /** @lends OpenSeadragon.NBTileSource.prototype */{

    /**
     * Determine if the data and/or url imply the image service is supported by
     * this tile source.
     * @function
     * @param {Object|Array} data
     * @param {String} optional - url
     */
    supports: function( data, url ){
      console.log('NBTileSource supports ' + data.type);
      return ( data.type && "nbtileservice" == data.type );
    },

    /**
     *
     * @function
     * @param {Object} data - the raw configuration
     * @param {String} url - the url the data was retreived from if any.
     * @return {Object} options - A dictionary of keyword arguments sufficient
     *      to configure this tile sources constructor.
     */
    configure: function( data, url ){
      console.log('NBTileSource configure ' + data.tilesUrl);
      return data;
    },

    /**
     * @function
     * @param {Number} level
     * @param {Number} x
     * @param {Number} y
     */
    getTileUrl: function( level, x, y ){
      console.log('NBTileSource getTileUrl ');
      id =  'tile_' + x + '_' + y + '_' + (level);
      console.log('id' + id);
      console.log('tileLocations[id.toUpperCase()] ' + tileLocations[id.toUpperCase()]);
      return tileLocations[id.toUpperCase()];
    },
    // /**
    //  * @function
    //  * @param {Number} level
    //  * @param {Number} x
    //  * @param {Number} y
    //  */
    getImageInfo: function (data) {
      console.log('NBTileSource getImageInfo ' + data);
      $.ajax({
        url: data.tilesUrl,
        dataType: "json",
        async: true,
        success: function(data, text) {
          for (var tile in data.tiles) {
            tileLocations[tile] = data.tiles[tile];
          }
        },
        error: function(request, status, error) {
          alert("Error : " + request.responseText + "\n" + status + "\n" + error);
        }
      });
    }
  });
}( OpenSeadragon ));

Looks reasonable to me. After "supports" you should get the "NBTileSource function" log...is that happening?

Yes - it is.
When I look at the OSD code,  it looks like the getImageInfo method will only fire when the first argument is a string.   Here's the code from version 1.2
console.log(arguments[ 0 ]);
    if( 'string' == $.type( arguments[ 0 ] ) ){
        //in case the getImageInfo method is overriden and/or implies an
        //async mechanism set some safe defaults first
        this.aspectRatio = 1;
        this.dimensions  = new $.Point( 10, 10 );
        this.tileSize    = 0;
        this.tileOverlap = 0;
        this.minLevel    = 0;
        this.maxLevel    = 0;
        this.ready       = false;
        //configuration via url implies the extending class
        //implements and 'configure'
        this.getImageInfo( arguments[ 0 ] );

    } else {

That indicates that the tileSources parameter needs to be a string in order for getImageInfo to fire.
How is that accomplished in this scenario?

You don't need getImageInfo to fire on your NBTileSource...the way the system works is when you pass in a URL to the tileSources option, a generic TileSource is created with that URL and its getImageInfo is called to load the data. Once that data is loaded it's passed through the supports of all the available TileSource subclasses (including NBTileSource), and when a match is found, a new object is created (in this case an NBTileSource) and the data is passed into it.
Do you have this code running anywhere I can look at?

interesting  -  I have a console.log statement in the getimageinfo in the OSD code and I don't see that happening.   From what you are saying the getImageInfo method is called before supports.   I will debug the OSD code to see if I can find the issue.     I can't make the code available because we are developing behind a firewall.

That's assuming you're still using tileSources: tile_json_request and that tile_json_request is a URL to some data. At any rate, that's my reading of https://github.com/openseadragon/openseadragon/blob/master/src/tilesource.js#L409-L431

I'm somewhat confused now.   If I define tileSources as you describe, then I how do I define the 'type' for supports ?  This is how 'supports' was passing.
	    tileSources: [{
	    	type: 'nbtileservice',
	      width: srcWidth,
        height: srcHeight,
        tilesUrl: tile_json_request
	    }]

I can hardcode my 'supports' method to return true to get around that issue.
So if getImageInfo is used by setting TileSources to the json request, why doesn't getTileUrl fire?

Gotcha. Sure, you can specify the data directly, and then you don't need to worry about getImageInfo. If you did go the getImageInfo route (by specifying a JSON URL), the JSON that gets returned would have to include the type property in order for supports to work.
At any rate, I think we're on the same page now...sorry for the confusion. So the remaining mystery is why doesn't getTileUrl fire. Unfortunately everything looks good to me, so I'm not sure why it isn't. Have you tried swapping in something like a dzi tilesource (there are some sample files in the OpenSeadragon repository) to make sure it's loading?
I suppose one way to look is to start from where getTileUrl is called and figure out why the code isn't getting there:
https://github.com/openseadragon/openseadragon/blob/master/src/tiledimage.js#L988
Of course you can also take a look at the resulting tiled image and make sure it's properly positioned in the viewport and that the contents of its source property look like the NBTileSource you're looking for.
Sorry this is proving to be challenging! We don't get a lot of people writing new tile sources...

So with the help of a colleague,  we have solved the issue for our custom tile source implementation.
We set tileSources in the OpenSeadragon declaration to be my custom TileSource object like this:
var myTileSource = new OpenSeadragon.NBTileSource(srcWidth, srcHeight, tileSize, tile_json_request);

var viewer = OpenSeadragon({
        id: "openseadragon1",
	toolbar: "toolbarDiv",
        constrainDuringPan: true,
        visibilityRatio: 1,
        prefixUrl: "/scripts/images/",
  	showRotationControl: true,
	tileSources: myTileSource
     });
  });

Then in the constructor of my TileSource, I  explicity calling getImageInfo.
  $.NBTileSource = function( width, height, tileSize, tilesUrl ) {
    var options;
    console.log('NBTileSource function ');

.... do some other stuff here ...

    this.getImageInfo( tilesUrl );
    $.TileSource.apply( this, [ options ] );

  };

It seem like  OpenSeadragon should allow getImageInfo to be triggered in this kind of situation.  It appears that getTileURL and getImageInfo are mutually exclusive.   But perhaps I'm misunderstanding  the use of these methods.

Ah! I'm sorry I didn't see this before...you're overriding getImageInfo, so of course it's not behaving the way I expect it to. configure, supports, getTileUrl are all expected to be overridden, but getImageInfo is not.
It looks like part of the confusion is that you have potentially two files that you need to load? One for the width/height/tilesize and one with the tile locations? Can those be combined into a single call to the server? If not, what you're doing seems to work, so you can run with it. You might want to change the name of your getImageInfo because its purpose is different than the built in getImageInfo (i.e. yours gets secondary info, whereas the built in one is for getting primary info).
Anyway, glad you found something that works; apologies for not noticing the issue sooner!

Well I wasn't overriding getImageInfo before.  This is what I was required to do in order for things to work.  As I said in my last comment, when I set tileSources: "url_string" then getImageInfo would fire but getTileUrl would not.   Is there something else I need to send back in the json request for getTileUrl to fire when using getImageInfo ?

Well, if what you've got works, you can just run with it. That said, if you want to try to get to the bottom of this, I'm happy to help.
If you don't override getImageInfo, then it should do the sequence I outlined in https://github.com/openseadragon/openseadragon/issues/690#issuecomment-126391633. The data it fetches needs to be whatever you're going to need for your tilesource, including whatever identifying information your supports will need to know that it's the right kind of tilesource. If you then need to make an additional call for additional information, you can write your own helper function for that (that doesn't override getImageInfo). This all assumes you're creating the OpenSeadragon viewer with tileSources: someDataUrl.
Am I correct in thinking that you have to make two calls to the server to get the info you want? If you have any control over that, it would be great to get it down to one call.
For that matter, I generally find being able to load the data myself however I need (perhaps batched with other images or with metadata) and then pass that into OpenSeadragon, much like you are with your latest, is actually quite a good way to go.
Anyway, it's a pretty flexible system, so I'd say the solution you have is reasonable, assuming it's just for use in your project. If you were planning on publishing this tilesource as an OpenSeadragon plugin, I'd probably want to clean its API up a little so people can be flexible about how they use it.

I would like to get to the bottom of the problem and I appreciate the help.
I did try what you suggested and I could not get the getTileUrl to fire.   I only need to make one request to the server to get the data which is using that 'tiles_json_request'.  It brings back the data looking like this:

{"imageserver":{"tiles":{"tile_0_0_0":"http://ihw10.newsbank.com/cache/ean/display/105661d58ddc5fd5/tile_105661d60a0f265a_0_0_0.5_256.jpg","tile_1_0_0":"http://ihw10.newsbank.com/cache/ean/display/105661d58ddc5fd5/tile_105661d60a0f265a_512_0_0.5_256.jpg","tile_0_0_1":"http://ihw10.newsbank.com/cache/ean/display/105661d58ddc5fd5/tile_105661d60a0f265a_0_0_1_256.jpg","tile_0_1_1":"http://ihw10.newsbank.com/cache/ean/display/105661d58ddc5fd5/tile_105661d60a0f265a_0_256_1_256.jpg","tile_1_0_1":"http://ihw10.newsbank.com/cache/ean/display/105661d58ddc5fd5/tile_105661d60a0f265a_256_0_1_256.jpg","tile_1_1_1":"http://ihw10.newsbank.com/cache/ean/display/105661d58ddc5fd5/tile_105661d60a0f265a_256_256_1_256.jpg","tile_2_0_1":"http://ihw10.newsbank.com/cache/ean/display/105661d58ddc5fd5/tile_105661d60a0f265a_512_0_1_256.jpg","tile_2_1_1":"http://ihw10.newsbank.com/cache/ean/display/105661d58ddc5fd5/tile_105661d60a0f265a_512_256_1_256.jpg","tile_3_0_1":"http://ihw10.newsbank.com/cache/ean/display/105661d58ddc5fd5/tile_105661d60a0f265a_768_0_1_256.jpg","tile_3_1_1":"http://ihw10.newsbank.com/cache/ean/display/105661d58ddc5fd5/tile_105661d60a0f265a_768_256_1_256.jpg"}}}

And I can add more data to that request as needed so I could add the supports info to it if that is what is needed.   But you can see I have the tile paths for each zoom level and each tile location which I then calculate in the getTileURL function like so:
    getTileUrl: function( level, x, y ) {
      id =  'tile_' + x + '_' + y + '_' + (level);
      return this.tileLocations[id];
    }

Clearly I'll need to access the data structure differently than this function is with the tileLocations array but I'm not even getting far enough to see getTileUrl to fire.    But you say it should just happen correct?

Well, I played with the code in this thread to see what I could make happen. I don't know the details of your format, and the URLs you gave don't seem to work (at least outside your network), but I got all the right things to fire.
I went with specifying the data directly, rather than loading from JSON, since it's more flexible and potentially more efficient. Here is the data I used:
var data = {
  type: 'nbtileservice',
  width: 1000,
  height: 1000,
  tileLocations: {
    tile_0_0_0: 'http://ihw10.newsbank.com/cache/ean/display/105661d58ddc5fd5/tile_105661d60a0f265a_0_0_0.5_256.jpg',
    tile_1_0_0: 'http://ihw10.newsbank.com/cache/ean/display/105661d58ddc5fd5/tile_105661d60a0f265a_512_0_0.5_256.jpg',
    tile_0_0_1: 'http://ihw10.newsbank.com/cache/ean/display/105661d58ddc5fd5/tile_105661d60a0f265a_0_0_1_256.jpg',
    tile_0_1_1: 'http://ihw10.newsbank.com/cache/ean/display/105661d58ddc5fd5/tile_105661d60a0f265a_0_256_1_256.jpg',
    tile_1_0_1: 'http://ihw10.newsbank.com/cache/ean/display/105661d58ddc5fd5/tile_105661d60a0f265a_256_0_1_256.jpg',
    tile_1_1_1: 'http://ihw10.newsbank.com/cache/ean/display/105661d58ddc5fd5/tile_105661d60a0f265a_256_256_1_256.jpg',
    tile_2_0_1: 'http://ihw10.newsbank.com/cache/ean/display/105661d58ddc5fd5/tile_105661d60a0f265a_512_0_1_256.jpg',
    tile_2_1_1: 'http://ihw10.newsbank.com/cache/ean/display/105661d58ddc5fd5/tile_105661d60a0f265a_512_256_1_256.jpg',
    tile_3_0_1: 'http://ihw10.newsbank.com/cache/ean/display/105661d58ddc5fd5/tile_105661d60a0f265a_768_0_1_256.jpg',
    tile_3_1_1: 'http://ihw10.newsbank.com/cache/ean/display/105661d58ddc5fd5/tile_105661d60a0f265a_768_256_1_256.jpg'
  }
};

...and I just passed it into the viewer upon creation like so:
  tileSources: data

Here is my version of the NBTileSource code (with comments removed for brevity):
OpenSeadragon.NBTileSource = function( options ) {
  console.log('NBTileSource function ');

  options.tileSize = 256;
  options.maxLevel = 1;

  var numTiles= {};
  numTiles.x = options.width % options.tileSize == 0 ? options.width/options.tileSize : Math.floor(options.width/options.tileSize) + 1 ;
  numTiles.y = options.height % options.tileSize == 0 ? options.height/options.tileSize : Math.floor(options.height/options.tileSize) + 1 ;

  options.width = numTiles.x*options.tileSize;
  options.height = numTiles.y*options.tileSize;

  console.log('NBTileSource this ' + this);
  console.log('NBTileSource options.tilesUrl ' + options.tilesUrl);
  OpenSeadragon.TileSource.apply( this, [ options ] );
};

OpenSeadragon.extend( OpenSeadragon.NBTileSource.prototype, OpenSeadragon.TileSource.prototype, {
  supports: function( data, url ){
    console.log('NBTileSource supports ' + data.type);
    return ( data.type && "nbtileservice" == data.type );
  },

  configure: function( data, url ){
    console.log('NBTileSource configure ' + data.tilesUrl);
    return data;
  },

  getTileUrl: function( level, x, y ){
    console.log('NBTileSource getTileUrl ');
    id =  'tile_' + x + '_' + y + '_' + (level);
    console.log('id' + id);
    console.log('tileLocations[id] ' + this.tileLocations[id]);
    return this.tileLocations[id];
  }
});

Btw, what's the deal with numTiles and changing the width/height? Because it needs to be an even multiple of tiles?

Thanks Ian.
It looks like we have a bit of a disconnect.    You created the  structure that contains the JSON data.   I was hoping that OpenSeadragon would make the JSON request to retrieve the data with its getImageInfo method and then call the supports, configure and getTileUrl methods like you have defined.    Perhaps that is not how things work and I'm trying to do something that's not possible.
The deal with numTiles is that our Tile service returns the tiles in even numbered tiles based on the tile size requested.  So it fills in the edges of an image with a background color when those tiles are not the exact  size of the tile.   Does that make sense?   We probably need to adjust our Tile service to send back the odd sized tiles on the edges since OpenSeadragon will handle that scenario.
Also the reason those images are not available is because we create the tiles dynamically when the JSON request is made and they are  cached them for about three days.   We have a very, very large number of historical documents so this is most efficient for us.

The code above should be able to handle the JSON request version as well, assuming the result from the JSON request matches the contents of the var data above, then you would just initialize your viewer with:
  tileSources: 'http://foo.com/data.json'

...or whatever. Otherwise no change needs to be made to the NBTileSource.
Thanks for explaining the numTiles thing. If your service can produce partial tiles, OSD is fine with that. If you need to go with the padding, that's fine too, and OSD can even crop it on the client side if you want (though you'll have to do some math).

@iangilman you mentioned in the previous comment that "OSD can even crop it on the client side".   How would I do that with OSD?   These are tiles that are padded on the image edges to create even sized tiles and I need to undo that.

Take a look at the clip parameter for Viewer.addTiledImage():
http://openseadragon.github.io/docs/OpenSeadragon.Viewer.html#addTiledImage
You can also use the same parameter in Viewer.open() or in the tileSources option when creating the Viewer.

Is there any back-end source code, or is there no need for back-end source code?

@linruicheng1997 OSD does not require any backend... You can use it on a purely static site. The DZI format is just XML and standard image tiles (often JPG), so any web server should be able to serve them.


docs(README): add documentation for directives

As per the title

:tada: This PR is included in version graphql-gene-v1.0.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fix: NPE if messageId not present on create-sub admin-api call

Motivation
Right now, while creating subscription if user doesn't pass message-id then broker doesn't handle it properly which gives NPE and gives internal-server error to user.
Message: null

Stacktrace:

java.lang.NullPointerException
        at org.apache.pulsar.broker.admin. PersistentTopicsBase.internalCreateSubscription(PersistentTopicsBase.java:885)
        at sun.reflect.GeneratedMethodAccessor199.invoke(Unknown Source)

Modifications

take earliest-message id while creating subscription if user doesn't provide message-id.

retest this please

run cpp tests


Cannot run the QuickStart

from nl2ltl import translate
from nl2ltl.engines.rasa.core import RasaEngine
from nl2ltl.engines.gpt.core import openai
from nl2ltl.filters.simple_filters import BasicFilter
from nl2ltl.engines.utils import pretty
engine = RasaEngine()
#engine = openai.Engine()
filter = BasicFilter()
utterance = "Eventually send me a Slack after receiving a Gmail"
ltlf_formulas = translate(utterance, engine, filter)
pretty(ltlf_formulas)

ImportError                               Traceback (most recent call last)
File ~/.local/lib/python3.9/site-packages/rasa/engine/graph.py:112, in GraphSchema.from_dict(cls, serialized_graph_schema)
109 try:
110     serialized_node[
111         "uses"
--> 112     ] = rasa.shared.utils.common.class_from_module_path(
113         serialized_node["uses"]
114     )
116     resource = serialized_node["resource"]
File ~/.local/lib/python3.9/site-packages/rasa/shared/utils/common.py:36, in class_from_module_path(module_path, lookup_path)
35 module_name, _, class_name = module_path.rpartition(".")
---> 36 m = importlib.import_module(module_name)
37 klass = getattr(m, class_name, None)
File /usr/lib/python3.9/importlib/init.py:127, in import_module(name, package)
126         level += 1
--> 127 return _bootstrap._gcd_import(name[level:], package, level)
File :1030, in _gcd_import(name, package, level)
File :1007, in find_and_load(name, import)
File :986, in find_and_load_unlocked(name, import)
File :680, in _load_unlocked(spec)
File :850, in exec_module(self, module)
File :228, in _call_with_frames_removed(f, *args, **kwds)
File ~/.local/lib/python3.9/site-packages/rasa/graph_components/validators/default_recipe_validator.py:12
11 from rasa.nlu.extractors.regex_entity_extractor import RegexEntityExtractor
---> 12 from rasa.nlu.extractors.crf_entity_extractor import (
13     CRFEntityExtractor,
14     CRFEntityExtractorOptions,
15 )
16 from rasa.nlu.extractors.entity_synonyms import EntitySynonymMapper
File ~/.local/lib/python3.9/site-packages/rasa/nlu/extractors/crf_entity_extractor.py:18
17 from rasa.engine.storage.storage import ModelStorage
---> 18 from rasa.nlu.test import determine_token_labels
19 from rasa.nlu.tokenizers.spacy_tokenizer import POS_TAG_KEY
File ~/.local/lib/python3.9/site-packages/rasa/nlu/test.py:34
33 import rasa.shared.utils.io
---> 34 import rasa.utils.plotting as plot_utils
35 import rasa.utils.io as io_utils
File ~/.local/lib/python3.9/site-packages/rasa/utils/plotting.py:8
7 from typing import Any, Callable, List, Optional, Text, TypeVar, Union, Tuple
----> 8 import matplotlib
9 from matplotlib.ticker import FormatStrFormatter
File ~/.local/lib/python3.9/site-packages/matplotlib/init.py:109
107 # cbook must import matplotlib only within function
108 # definitions, so it is safe to import from it here.
--> 109 from . import _api, _version, cbook, docstring, rcsetup
110 from matplotlib.cbook import MatplotlibDeprecationWarning, sanitize_sequence
File ~/.local/lib/python3.9/site-packages/matplotlib/rcsetup.py:27
26 from matplotlib.cbook import ls_mapper
---> 27 from matplotlib.colors import Colormap, is_color_like
28 from matplotlib.fontconfig_pattern import parse_fontconfig_pattern
File ~/.local/lib/python3.9/site-packages/matplotlib/colors.py:51
50 import re
---> 51 from PIL import Image
52 from PIL.PngImagePlugin import PngInfo
File /usr/lib/python3/dist-packages/PIL/Image.py:89
83 try:
84     # If the _imaging C module is not present, Pillow will not load.
85     # Note that other modules should not refer to _imaging directly;
86     # import Image and use the Image.core variable instead.
87     # Also note that Image.core is not a publicly documented interface,
88     # and should be considered private and subject to change.
---> 89     from . import _imaging as core
91     if version != getattr(core, "PILLOW_VERSION", None):
ImportError: cannot import name '_imaging' from 'PIL' (/usr/lib/python3/dist-packages/PIL/init.py)
The above exception was the direct cause of the following exception:
GraphSchemaException                      Traceback (most recent call last)
Cell In[3], line 7
4 from nl2ltl.filters.simple_filters import BasicFilter
5 from nl2ltl.engines.utils import pretty
----> 7 engine = RasaEngine()
8 #engine = openai.Engine()
9 filter = BasicFilter()
File ~/Documents/nl2ltl/nl2ltl/engines/rasa/core.py:42, in RasaEngine.init(self, model)
37 def init(
38     self,
39     model: Path = None,
40 ):
41     """Rasa NLU Engine initialization."""
---> 42     self._load_model(model)
44     self._check_consistency()
File ~/Documents/nl2ltl/nl2ltl/engines/rasa/core.py:50, in RasaEngine._load_model(self, model)
48     self.agent = Agent.load(model)
49 else:
---> 50     self.agent = Agent.load(_get_latest_model(path=MODEL_OUTPUT_PATH))
File ~/.local/lib/python3.9/site-packages/rasa/core/agent.py:345, in Agent.load(cls, model_path, domain, generator, tracker_store, lock_store, action_endpoint, fingerprint, model_server, remote_storage, http_interpreter)
333 """Constructs a new agent and loads the processer and model."""
334 agent = Agent(
335     domain=domain,
336     generator=generator,
(...)
343     http_interpreter=http_interpreter,
344 )
--> 345 agent.load_model(model_path=model_path, fingerprint=fingerprint)
346 return agent
File ~/.local/lib/python3.9/site-packages/rasa/core/agent.py:352, in Agent.load_model(self, model_path, fingerprint)
348 def load_model(
349     self, model_path: Union[Text, Path], fingerprint: Optional[Text] = None
350 ) -> None:
351     """Loads the agent's model and processor given a new model path."""
--> 352     self.processor = MessageProcessor(
353         model_path=model_path,
354         tracker_store=self.tracker_store,
355         lock_store=self.lock_store,
356         action_endpoint=self.action_endpoint,
357         generator=self.nlg,
358         http_interpreter=self.http_interpreter,
359     )
360     self.domain = self.processor.domain
362     self._set_fingerprint(fingerprint)
File ~/.local/lib/python3.9/site-packages/rasa/core/processor.py:105, in MessageProcessor.init(self, model_path, tracker_store, lock_store, generator, action_endpoint, max_number_of_predictions, on_circuit_break, http_interpreter)
103 self.on_circuit_break = on_circuit_break
104 self.action_endpoint = action_endpoint
--> 105 self.model_filename, self.model_metadata, self.graph_runner = self._load_model(
106     model_path
107 )
109 if self.model_metadata.assistant_id is None:
110     rasa.shared.utils.io.raise_warning(
111         f"The model metadata does not contain a value for the "
112         f"'{ASSISTANT_ID_KEY}' attribute. Check that 'config.yml' "
(...)
116         UserWarning,
117     )
File ~/.local/lib/python3.9/site-packages/rasa/core/processor.py:142, in MessageProcessor._load_model(model_path)
140 with TempDirectoryPath(get_temp_dir_name()) as temporary_directory:
141     try:
--> 142         metadata, runner = loader.load_predict_graph_runner(
143             Path(temporary_directory),
144             Path(model_tar),
145             LocalModelStorage,
146             DaskGraphRunner,
147         )
148         return os.path.basename(model_tar), metadata, runner
149     except tarfile.ReadError:
File ~/.local/lib/python3.9/site-packages/rasa/engine/loader.py:26, in load_predict_graph_runner(storage_path, model_archive_path, model_storage_class, graph_runner_class)
9 def load_predict_graph_runner(
10     storage_path: Path,
11     model_archive_path: Path,
12     model_storage_class: Type[ModelStorage],
13     graph_runner_class: Type[GraphRunner],
14 ) -> Tuple[ModelMetadata, GraphRunner]:
15     """Loads a model from an archive and creates the prediction graph runner.
16
17     Args:
(...)
24         A tuple containing the model metadata and the prediction graph runner.
25     """
---> 26     model_storage, model_metadata = model_storage_class.from_model_archive(
27         storage_path=storage_path, model_archive_path=model_archive_path
28     )
29     runner = graph_runner_class.create(
30         graph_schema=model_metadata.predict_schema,
31         model_storage=model_storage,
(...)
34         ),
35     )
36     return model_metadata, runner
File ~/.local/lib/python3.9/site-packages/rasa/engine/storage/local_model_storage.py:95, in LocalModelStorage.from_model_archive(cls, storage_path, model_archive_path)
89 logger.debug(f"Extracted model to '{temporary_directory_path}'.")
91 cls._initialize_model_storage_from_model_archive(
92     temporary_directory_path, storage_path
93 )
---> 95 metadata = cls._load_metadata(temporary_directory_path)
97 return (cls(storage_path), metadata)
File ~/.local/lib/python3.9/site-packages/rasa/engine/storage/local_model_storage.py:154, in LocalModelStorage._load_metadata(directory)
148 @staticmethod
149 def _load_metadata(directory: Path) -> ModelMetadata:
150     serialized_metadata = rasa.shared.utils.io.read_json_file(
151         directory / MODEL_ARCHIVE_METADATA_FILE
152     )
--> 154     return ModelMetadata.from_dict(serialized_metadata)
File ~/.local/lib/python3.9/site-packages/rasa/engine/storage/storage.py:194, in ModelMetadata.from_dict(cls, serialized)
178 """Loads ModelMetadata which has been serialized using metadata.as_dict().
179
180 Args:
(...)
184     Instantiated ModelMetadata.
185 """
186 from rasa.engine.graph import GraphSchema
188 return ModelMetadata(
189     trained_at=datetime.fromisoformat(serialized["trained_at"]),
190     rasa_open_source_version=serialized["rasa_open_source_version"],
191     model_id=serialized["model_id"],
192     assistant_id=serialized.get("assistant_id"),
193     domain=Domain.from_dict(serialized["domain"]),
--> 194     train_schema=GraphSchema.from_dict(serialized["train_schema"]),
195     predict_schema=GraphSchema.from_dict(serialized["predict_schema"]),
196     training_type=TrainingType(serialized["training_type"]),
197     project_fingerprint=serialized["project_fingerprint"],
198     core_target=serialized["core_target"],
199     nlu_target=serialized["nlu_target"],
200     language=serialized["language"],
201     # optional, since introduced later
202     spaces=serialized.get("spaces"),
203 )
File ~/.local/lib/python3.9/site-packages/rasa/engine/graph.py:121, in GraphSchema.from_dict(cls, serialized_graph_schema)
118             serialized_node["resource"] = Resource(**resource)
120     except ImportError as e:
--> 121         raise GraphSchemaException(
122             "Error deserializing graph schema. Can't "
123             "find class for graph component type "
124             f"'{serialized_node['uses']}'."
125         ) from e
127     nodes[node_name] = SchemaNode(**serialized_node)
129 return GraphSchema(nodes)
GraphSchemaException: Error deserializing graph schema. Can't find class for graph component type 'rasa.graph_components.validators.default_recipe_validator.DefaultV1RecipeValidator'.

Hi @Huangmao1208,
thanks for reaching out! I think the problem is that you're using python 3.9, which is not supported by rasa==3.5.11. As written in the README, the support is only for python 3.8.
However, I'm currently working on an update of the package, which will update rasa to the latest version and it will support from python 3.8 to python 3.10.
Stay tuned as there will be a new release pretty soon (few hours)...

Hi @Huangmao1208,
thanks for reaching out! I think the problem is that you're using python 3.9, which is not supported by rasa==3.5.11. As written in the README, the support is only for python 3.8.
However, I'm currently working on an update of the package, which will update rasa to the latest version and it will support from python 3.8 to python 3.10.
Stay tuned as there will be a new release pretty soon (few hours)...

Great! Thanks for the help!!!

Hey @francescofuggitti
i have tried to use python3.8, it gives me an error as
ModuleNotFoundError: No module named 'zoneinfo'
And I have searched online, it says I have to use from backports.zoneinfo import ZoneInfo, but I cannot overwritten File [/usr/lib/python3/dist-packages/pytz/__init__.py:16]
Did you ever face this problem before?

@Huangmao1208, this error is a weird one. I've never encountered it. It seems related to one of your packages installed in the environment. Are you using a virtual environment with dependencies only?

this error is a weird one. I've never encountered it. It seems related to one of your packages installed in the environment. Are you using a virtual environment with dependencies only?

Hey @francescofuggitti
Yes, I use the virtual environment with python3.8

I am not sure if I misunderstand things, what I did is run the quickstart code below in jupyter notebook.
from nl2ltl import translate
from nl2ltl.engines.rasa.core import RasaEngine
from nl2ltl.filters.simple_filters import BasicFilter
from nl2ltl.engines.utils import pretty
engine = RasaEngine()
filter = BasicFilter()
utterance = "Eventually send me a Slack after receiving a Gmail"
ltlf_formulas = translate(utterance, engine, filter)
pretty(ltlf_formulas)

Ok, what are the steps you used to install the package?
In a fresh environment, can you try to install it from source with git clone ..., then cd nl2ltl and then run pip install -e .?

Ok, what are the steps you used to install the package?
In a fresh environment, can you try to install it from source with git clone ..., then cd nl2ltl and then run pip install -e .?

Yes, I have done this. These steps didn't have any error

Mmmh, then I really don't know how I can help you. All tests and workflows are working and they are isolated builds...
FYI, I've made a new release v0.0.5, where rasa is made optional (as rasa has several conflicts with other packages). You can try to install nl2ltl with pip install -e . (pay attention to the -e flag) and then use the GPTEngine as follows:
from nl2ltl import translate
from nl2ltl.engines.gpt.core import GPTEngine
from nl2ltl.filters.simple_filters import BasicFilter
from nl2ltl.engines.utils import pretty

engine = GPTEngine()
filter = BasicFilter()
utterance = "Eventually send me a Slack after receiving a Gmail"

ltlf_formulas = translate(utterance, engine, filter)
pretty(ltlf_formulas)

I'll close this issue as the new version 0.0.5 has been release and all tests are passing


404 detection broken, causing application crashes (500 Internal Server Error)

The detection of missing files is broken. Every path that is only part of an existing path is assumed to be valid, which leads to application crashes because the corresponding file can not be found.
 $ curl -I https://www.ruby-lang.org/en/downloads
     # -> 302 Found: ok (existing path)

 $ curl -I https://www.ruby-lang.org/down
     # -> 500 Internal Server Error: WRONG (should be 404)
     #    non-existing path that is part of an existing one

 $ curl -I https://www.ruby-lang.org/dOWn
     # -> 404 Not Found: ok (non-existing path)

The bug is caused by lib/rack/jekyll.rb lines 67 and following:
  @files = ::Dir[@path + "/**/*"].inspect if @files == "[]"
  if @files.include?(path_info)
    # tries to open file -> Errno::ENOENT: No such file or directory @ rb_sysopen
  else
    # handles 404's
  end

This checks whether the request path is part of a string that contains all filenames in the _site dir!
The test doesn't work properly and assumes that paths are valid in many cases where it shouldn't.

Is there a way to patch this bug manually on Heroku until the fix is on the main branch?

You mean generally? Sure:
fork the repo and create a branch that fixes the bug; then specify your repo and branch in the Gemfile,
see https://github.com/ruby/www.ruby-lang.org/blob/master/Gemfile#L8 for an example (my fork fixes a different problem of rack-jekyll, though, and might be removed anytime we find a better solution, so don't use it).

PS. It seems maintenance of rack-jekyll is rather dead, so I don't expect a quick fix.

duplicate of #23

Update: This is now WIP targeted for the next release.

Fixed with a9eb164d6c1ec548aa1ce3fc18e6f9f209d01487.


Add Carroll & Raul to GKE

Description
Adds @raul-arabaolaza & @car-roll to https://github.com/jenkinsci/google-kubernetes-engine-plugin
E.g. https://github.com/jenkinsci/google-kubernetes-engine-plugin/pull/257 where we are already helping.
cc @donmccasland

Submitter checklist for adding or changing permissions

Always

[x] Add link to plugin/component Git repository in description above

For a newly hosted plugin only

[ ] Add link to resolved HOSTING issue in description above

For a new permissions file only

[ ] Make sure the file is created in permissions/ directory
[ ] artifactId (pom.xml) is used for name (permissions YAML file).
[ ] groupId / artifactId (pom.xml) are correctly represented in path (permissions YAML file)
[ ] Check that the file is named plugin-${artifactId}.yml for plugins

When adding new uploaders (this includes newly created permissions files)

[x] Make sure to @mention an existing maintainer to confirm the permissions request, if applicable
[x] Use the Jenkins community (LDAP) account name in the YAML file, not the GitHub account name
[x] Make sure to @mention the users being added so their GitHub account names are known if they require GitHub merge access (see below).
[x] All newly added users have logged in to Artifactory at least once

Reviewer checklist (not for requesters!)

[ ] Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
[ ] Check that the $pluginId Developers team has Admin permissions while granting the access.
[ ] In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
[ ] If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

Merging as one of the declared releasers already.


Delete resources in the sink DB and FHIR server

Description of what I changed
Delete the FHIR resources in the Sink DB and Sink FHIR servers during export.
E2E test
Relied on e2e tests.
TESTED:
Manually tested by deleting the resources from the source FHIR server and verifying the same from the sink systems.
Checklist: I completed these to help reviewers :)

[x] I have read and will follow the review process.

[x] I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review Java and Python style guides.

[x] My IDE is configured to follow the Google code styles.
No? Unsure? -> configure your IDE.

[x] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)

[x] I ran mvn clean package right before creating this pull request and added all formatting changes to my commit.

[x] All new and existing tests passed.

[x] My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command git pull --rebase upstream master

Codecov Report
Attention: Patch coverage is 30.43478% with 16 lines in your changes missing coverage. Please review.

Project coverage is 51.90%. Comparing base (5692966) to head (bb7b831).

Files with missing lines
Patch %
Lines

.../com/google/fhir/analytics/JdbcResourceWriter.java
20.00%
7 Missing and 1 partial :warning:

...a/com/google/fhir/analytics/ConvertResourceFn.java
0.00%
6 Missing :warning:

.../java/com/google/fhir/analytics/FhirStoreUtil.java
71.42%
1 Missing and 1 partial :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1183      +/-   ##
============================================
+ Coverage     51.80%   51.90%   +0.09%
- Complexity      710      714       +4
============================================
  Files            95       95
  Lines          5837     5857      +20
  Branches        773      778       +5
============================================
+ Hits           3024     3040      +16
- Misses         2523     2525       +2
- Partials        290      292       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@bashir2 Sorry for the delay in addressing the review comments. Please have a look at my recent changes.


newtoflattened branch: JVM Crash on Sum of Large Array

Using branch newtoflattened on both nd4j and libnd4j, the JVM crashes with this code:
package com.example;

import org.nd4j.linalg.factory.Nd4j;

public class App {
    public static void main(String... args){
        System.out.println(Nd4j.ones(Integer.MAX_VALUE).sumNumber().intValue());
    }
}

hs_err_pid4688.log.txt

With current master this doesn't crash any more.


Expose AuditLog export API

There might be use-cases where we need to programmatically extract the audit log directly from the transaction, just like the error string. Transaction's public interface should export something like AuditLog()
It will also provide audit log for the playground

Could you please list some of the might be use-cases to do the tradeoffs
about this case?
On Wed, Feb 15, 2023 at 8:15 AM Juan Pablo Tosso @.***>
wrote:

There might be use-cases where we need to extract the audit log directly
from the transaction, just like the error string. Transaction's public
interface should export something like AuditLog()
—
Reply to this email directly, view it on GitHub
https://github.com/corazawaf/coraza/issues/648, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXOYASMOCKIIB35PAEF4F3WXR7A7ANCNFSM6AAAAAAU4PFEOM
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

For example, for the playground issue we can easily plug a writer in the audit log which can be read later.


Untouched missions marked as completed, NATO agro growing

Version: 1.1.3
Mods: none
Environment: MP dedi.
.rpt attatched? NO (no trace of issue)
have you edited the missionfile?: No
Issue:
We keep getting notifications about unassigned, untouched missions getting completed, the faction receives the money and the agro grows. I'm not sure but it's probably every mission that times out comes up as completed.

Thanks but lacks of lot of info.


Unable to read package.json

Hey, It doesn't seem like "--dir" is not working with actions or am I using it wrong?
The package file is at swagger/generator/package.json
Action:
    - name: Publish
      uses: primer/publish@master
      env:
        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
        NPM_AUTH_TOKEN: ${{ secrets.NODE_AUTH_TOKEN }}
        args: "--dir=swagger/generator"

I have tried to put --dir=../../swagger/generator too but it doesn't do any difference.
Action Logs:
/usr/bin/docker run --name HIDDEN--label 04bb81 --workdir /github/workspace --rm -e GITHUB_TOKEN -e NPM_AUTH_TOKEN -e args -e HOME -e GITHUB_REF -e GITHUB_SHA -e GITHUB_REPOSITORY -e GITHUB_ACTOR -e GITHUB_WORKFLOW -e GITHUB_HEAD_REF -e GITHUB_BASE_REF -e GITHUB_EVENT_NAME -e GITHUB_WORKSPACE -e GITHUB_ACTION -e GITHUB_EVENT_PATH -e RUNNER_OS -e RUNNER_TOOL_CACHE -e RUNNER_TEMP -e RUNNER_WORKSPACE -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/e-commerce-backend/e-commerce-backend":"/github/workspace" HIDDEN
user.email=HIDDEN
user.name=erictuvesson
core.repositoryformatversion=0
core.filemode=true
core.bare=false
core.logallrefupdates=true
remote.origin.url=https://github.com/erictuvesson/e-commerce-backend
remote.origin.fetch=+refs/heads/*:refs/remotes/origin/*
gc.auto=0
[publish] options: {
  "dir": ".",
  "$0": "/primer-publish/cli.js"
}
[publish] npm args: []
/primer-publish/src/context.js:17
    throw new Error(`Unable to read package.json in ${path.join(process.cwd(), dir)}!`)
    ^

Error: Unable to read package.json in /github/workspace!
    at getContext (/primer-publish/src/context.js:17:11)
    at publish (/primer-publish/src/publish.js:15:10)
    at Object.<anonymous> (/primer-publish/cli.js:29:1)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:831:12)
    at startup (internal/bootstrap/node.js:283:19)
##[error]Docker run failed with exit code 1

I'm seeing the same error without passing --dir. Did you solve it?

I never solved it unfortunately.

The same problem.

I was able to get the --dir option set in Workflows v2 using the with.args option.
      - name: Publish
        uses: primer/publish@master
        with:
          args: '--dir=dist'
        env:
          NPM_AUTH_TOKEN: ${{ secrets.npm_token }}
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

However now I'm running into a problem where it thinks I'm not authenticated even though it has my token...
npm notice
npm ERR! code E401
npm ERR! 401 Unauthorized - PUT https://registry.npmjs.org/python-rencode - You must be logged in to publish packages.

npm ERR! A complete log of this run can be found in:
npm ERR!     /github/home/.npm/_logs/2019-12-25T06_42_02_845Z-debug.log
{ Error: Command failed: npm publish dist --tag canary --access public
    at makeError (/primer-publish/node_modules/execa/index.js:174:9)
    at Promise.all.then.arr (/primer-publish/node_modules/execa/index.js:278:16)
    at process._tickCallback (internal/process/next_tick.js:68:7)
  code: 1,
  stdout: null,
  stderr: null,
  failed: true,
  signal: null,
  cmd: 'npm publish dist --tag canary --access public',
  timedOut: false,
  killed: false }

I think you guys are missing the checkout step
name: publish
on:
  push:
    branches:
      - '*'
jobs:
  publish-job:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v1
      - uses: primer/publish@master
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_ACCESS_TOKEN }}
          NPM_AUTH_TOKEN: ${{ secrets.NPM_AUTH_TOKEN }}
          args: '--dry-run'


Missing dependencies when converting ckpt files

As explained in this README the custom model converter needs 3 additional dependencies:
pip install omegaconf safetensors pytorch_lightning
Each time I clear the venv, I have to manually reinstall them, this could also be confusing for newcomers.
More over, don't we risk to miss them in executable release bundles ?
Knowing than most users will convert ckpt files, wouldn't it be more practical to add them in the default requirements ?
Thanks.

Hi @drumicube,
Thanks for raising this issue! We agree this was an overkill and have now addressed that with one exception -> pytorch-lightning is needed only for a few HuggingFace models' .ckpt files as metioned here.
@powderluv

Thank you !

added most of them. I still wan't to try and avoid pytorch-lightning because of one model.


Server 2022 content

[Enter feedback here]
please add relevant info about an in-place upgrade to Server 2022

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 505fe07b-6fdd-4887-3c8b-15405c5d8308
Version Independent ID: 25645df2-0ffb-4cc3-a8d2-5466edd309fb
Content: Overview of Windows Server upgrades
Content Source: WindowsServerDocs/upgrade/upgrade-overview.md
Product: windows-server
Technology: upgrade
GitHub Login: @RobHindman
Microsoft Alias: robhind

well it should be more than a request, when a new OS RTMs at least a minimum of documentation should be available

#label:"docs-enhancement"

Hi @DSPatrick
Thanks for your dedication to our documentation.  I appreciate it is frustrating we haven’t been able to provide this information sooner, I apologise for the delayed response and thank you for your patience. We've submitted a documentation change based, and the updated article should be live by tomorrow. Please let us know if there's anything more we can do for you. If you need to follow up on this issue, leave us a comment with an @mention.
#assign:robinharwood
#please-close


Error Payload

Hi,
I tried out the demo for Firebase Storage. Whenever, I uploaded a file, I saw this message on the clipboard: firebase.js:486 Uncaught FirebaseError: Firebase Storage: An unknown error occurred, please check the error payload for server response.
How do I go about rectifying this? Thank you!

I haven't seen this error before, are you still facing this issue? Typically this is either a temporary issue with our backend or an error for which we are not surfacing a proper error type.
The best is to open your developer's console in your browser, make the error happen again and then have a look at the Network tab. Try locating the request that returns the error from our backend and the payload should contain an error message (in JSON) with hopefully some kind of error message about the issue.

I will check it again.
Thanks,
Girri
On Tue, Jul 19, 2016 at 11:14 PM, Nicolas Garnier<EMAIL_ADDRESS>wrote:

I haven't seen this error before, are you still facing this issue?
Typically this is either a temporary issue with our backend or an error for
which we are not surfacing a proper error type.
The best is to open your developer's console in your browser, make the
error happen again and then have a look at the Network tab. Try locating
the request that returns the error from our backend and the payload should
contain an error message (in JSON) with hopefully some kind of error
message about the issue.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/firebase/quickstart-js/issues/40#issuecomment-233665099,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMOtR8JJojEdITLViQ2W5SPAM4CfpQ6Xks5qXOnEgaJpZM4JN5NN
.

--
Palaniyapan

Hi I am actually doing a project on update and I too receive this error. Can I know what could this means ?
Thanks :)

@shirleycharlin same request please: if you are getting this error could you please have a look at the failing request in the Networks tab of the Chrome dev tools and paste the full error message here? There is likely more details in the full response of the HTTP request.

This is stale. Closing!

Hi all.
Thanks for all of the comments. Really appreciated and have learnt a lot!
Yours Sincerely,
*Shirley *
Blog: www.shirleycharlin.blogspot.sg
http://www.shirleycharlin.blogspot.sg
*I am a Youth.sg Campus Correspondent, representing NYP *
*https://www.youth.sg/Our-Voice/Campus-Blogs/ShirleyCharlin
https://www.youth.sg/Our-Voice/Campus-Blogs/ShirleyCharlin *
On Tue, Oct 25, 2016 at 3:03 PM, Nicolas Garnier<EMAIL_ADDRESS>wrote:

This is stale. Closing!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/firebase/quickstart-js/issues/40#issuecomment-255953831,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQ-T06Tj0t_vOP-TvtukwEqvBpxJtZKhks5q3anbgaJpZM4JN5NN
.


Merge latest changes - add license

Merge latest changes from original repository. Use the LICENSE that has been added.
Only conflict was in completion.js

:+1:

:+1:


Failed to resolve: com.dropbox.mobile.store:store4:4.0.0-alpha07

Looks like v4.0.0-alpha07 is not accessible through gradle yet.
EDIT: https://search.maven.org/artifact/com.dropbox.mobile.store/store4/4.0.0-alpha06/jar

Yep. Maven repository contained only alpha06 on the top

working on it, had a few release issues :-) hang tight

@digitalbuddha Any ETA?

We pushed it up, will propagate in few hrs


Reduce Z height of active show?

Is it possible to make the active show less 'raised'. Currently the thumbnail is casting a shadow on the title of the show. Not sure how much control we have over this.

(sorry for the sketchy picture, don't think you can screenshot on the TV)

Ugh, not sure why it is upside down either, clicking on it flips it though

Nope, no official control alas :-1:
I will look into faking it though.

I guess the other option is just to increase padding so the shadow doesn't hit the text

For the artworks I move the artwork metadata left and down in the same animation cycle to make it work

https://forums.developer.apple.com/thread/22150

This is not gonna happen, threw some time at it today and got nowhere.


no task scheduler is created when deploy on IIS server

I am setting task scheduler from a button inside a update panel.
when I run my project locally, everything is working very fine, but when I deploy my web app to IIS server and I create task scheduler from a button inside a update panel, the tasks wont be able to create.
I have no idea about it because there is no error or anything.
Originally posted: 2013-04-26T02:28:29

Please look at other discussions for hints regarding how to get IIS permissions set so that local and remote tasks can be managed. This is very likely a permissions problem.
Originally posted: 2013-04-27T10:48:10

Hi Dahall,
I found my solution already. The problem is that I only implement that locally not on a remote methodology.
Thank you so much for your response.
--
Sincerely Yours,
Sereyboth Van
Originally posted: 2013-05-02T20:36:33


Update TFL_MINIMUM_OS_VERSION

Updated TFL_MINIMUM_OS_VERSION to 10.0 from 9.0 and update the library file in CMakeLists.txt.
Related issues: https://github.com/tensorflow/tensorflow/issues/55322
https://github.com/tensorflow/tensorflow/issues/56250

One of the changes I made is already having a PR associated with it, I'm closing this PR and creating a new PR.

https://github.com/tensorflow/tensorflow/pull/56336


Add implementation for Azure Destroy Server Group pipeline stage

@JargoonPard @rguthriemsft PTAL

LGTM

thank you; I will go ahead and create/submit the PR to spinnaker master


Third button does not show content

No matter what I'm trying, the only argument that gets used from the third button (blue in this example) is the background color. Neither the image nor the text gets displayed.
iOS 10.3.1, Xcode 8.3.3, BGTableViewRowActionWithImage 0.4.1.

Sorry, this was an issue in my specific setup. Please ignore.


Manage repository with cruft

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.50%. Comparing base (61dde29) to head (e51fdd0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #667   +/-   ##
=======================================
  Coverage   93.50%   93.50%
=======================================
  Files          20       20
  Lines        2125     2125
=======================================
  Hits         1987     1987
  Misses        138      138

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Conform to Protobuf's Usage of six Dependency under Bazel

This PR is based on https://github.com/grpc/grpc/pull/21590 and changes our usage of six to accommodate the breaking change introduced by the protobuf repo in https://github.com/protocolbuffers/protobuf/pull/6310. Please see the final commit in the series for my specific changes. The crux of the issue is that we needed to remove our bind to //external:six.
@jtattermusch Feel free to cherrypick or supersede as desired.

Thanks! I've cherrypicked the changes into #21590 as there be a few more fixes needed (for unrelated problems)


Unexpected Input Echo in Output When Using pty

I encountered an issue when using the github.com/creack/pty library to create a pseudo-terminal. Below is the relevant code snippet:
cmd := exec.Command("/system/bin/sh")
// Allocate a pseudo-terminal for the subprocess
ptyMaster, err := pty.Start(cmd)
if err != nil {
return ErrPkg.NewErrD("Failed to start shell: " + err.Error())
}
When I send a command (e.g., ls followed by Enter) to the subprocess through the pseudo-terminal and then read the output, the output includes not only the command's execution result but also the command input itself. For example:
Input: ls
Output: ls\n + the actual command output

This behavior results in the output containing the input content, which is unexpected. I expect to receive only the command's execution result without the input echoed back.
Could you clarify if this behavior is intentional or if there's a way to avoid this echo in the output?

This is indeed expected and has to do with the terminal, no directly the pty library.
If you take a look at the README, there is an example of a shell, the key part you are looking for is
        // Set stdin in raw mode.
        oldState, err := term.MakeRaw(int(os.Stdin.Fd()))
        if err != nil {
                panic(err)
        }
        defer func() { _ = term.Restore(int(os.Stdin.Fd()), oldState) }() // Best effort.

That will pass through the terminal management to the underlying process.
If you only want to disable the output showing the input you can just disable ECHO and/or ICANON termios


Add EVP_MAC_CTX getter for block size

While porting CPython to the new MAC API I noticed that EVP_MAC_CTX is missing a getter to retrieve the block size of MAC for HMAC. The block size is part of Python's HMAC API. For OpenSSL 1.1.1 and earlier CPython uses
    const EVP_MD *md = HMAC_CTX_get_md(self->ctx);
    return PyLong_FromLong(EVP_MD_block_size(md));

to get the block size.

A function EVP_MAC_block_size(EVP_MAC*) would also work for me if you would include a method to get an EVP_MAC from a context EVP_MAC * EVP_MAC_CTX_get_mac(EVP_MAC_CTX*).
Also see #11320

EVP_MAC_get_ctx_mac() to get the EVP_MAC from the EVP_MAC_CTX.  Yes, it's a changed API pattern, which is currently being disputed on openssl-project (although the dispute has currently gone stale, it seems): https://mta.openssl.org/pipermail/openssl-project/2020-June/002056.html

Bring this up for OTC decision.  There is a gap in functionality with respect to 1.1.1.  Specifically, there are things we can no long determine via the EVP_MAC API.
Should we accept this breaking change or add some additional getters?  The original example of being able to grab the underlying digest and querying that isn't going to work generally.

It cannot be EVP_MAC_block_size(EVP_MAC *) as the block size might be determined by further parameters of the MAC algorithm.
So this getter would have to be on EVP_MAC_CTX *.

OTC: We're ok with a solution for this going in, but the dev team won't be working on it for 3.0.

OTC: We're ok with a solution for this going in, but the dev team won't be working on it for 3.0.

I can contribute a solution. Could you give me a short description and function signature definition of your preferred solution?

First it needs to be a gettable ctx parameter on EVP_MAC_CTX. Then there could be a convenience function EVP_MAC_CTX_get_block_size() that calls EVP_MAC_CTX_get_params() to get the value for this parameter.
The parameter should be named "blocksize" with an OSSL_MAC_PARAM_BLOCK_SIZE define to align with the cipher and md blocksize parameters.


feat: make Object.keys type strict

Makes Object.keys type strict, while still allowing devs to opt out if they want to.
Currently the following code
interface User {
    email: string
    name: string
}

const martin: User = {name: martin, email<EMAIL_ADDRESS>
const keys = Object.keys(martin)

would end up in keys being of type string[] instead of ('email' | 'name')[], which usually leads to unnecessary type castings afterward.
This solution sill allows people to keep the previous behaviour by explicitly setting the types
const keys = Object.keys<User, string>(martin) // string[]

just realised of tests/cases/compiler/noObjectKeysToKeyofT.ts


publish a new version

Hi,
could you please tag a new version with the latest fixes and publish it?
It's not urgent or anything, just more convenient for our project dependencies to go through npm rather than a github commit link. (we need the fix for #26 especially)
Thanks!

npm published 0.3.0
sorry for the wait :)

Wow fast, many thanks!


Add password protection support

There is a fork of this which has the feature but I will add it to the main app. For now you could use Windows Hello


Zigbee2MQTT Adapter Settings Docs

Closes #24
Additional docs for Zigbee Adapter settings for Zigbee2MQTT

Ping me if you are happy with your PR. It's ready to merge from my side.


Fix compilation failure with RDMA+GDR

This fix tries to address the issue raised in #21696 where
tensorflow failed to compile when both RDMA and GDR are on.
The issue is that the memory allocator of GDR used the same
name as RDMA.
This fix fixes #21696.
Signed-off-by: Yong Tang<EMAIL_ADDRESS>

@byronyi: thoughts?

@yongtang @poxvoculi LGTM


Nipoppy tutorial

Tutorial from Seb.

@dnkennedy Nipoppy.  Updated title.

Content at https://docs.google.com/document/d/1opySPBU72gnEOx98TjvhEfD5OR8QRvYcHIGXFC7bAc8/edit?tab=t.0#heading=h.q6gqw9g6emk

Okay to add to site.

Resolved by #127.


Correction for raw affiliation Université de Paris-Est et Caphi

Correction needed for raw affiliation Université de Paris-Est et Caphi
raw_affiliation_name: Université de Paris-Est et Caphi
new_rors: 05f82e368;059ynac98
previous_rors: 05f82e368
works_examples: W3104147704
contact: 3327c7d629f44073388d0e55060a728e:b2a0b6501c01e830aaff4feebc5341 @ univ-nantes.fr

This issue was accepted and ingested by the OpenAlex team on 2024-10-10. The new affiliations should be visible within the next 7 days.