Controller Spawner couldn't find the expected controller_manager ROS interface.

Hi,everyone,
when i do:
"roslaunch husky_gazebo husky_playpen.launch ",there are something wrong on the terminal:
" waitForService: Service [/gazebo/set_physics_properties] has not been advertised, waiting...
Controller Spawner couldn't find the expected controller_manager ROS interface".
i have tried my best to sove this problem,but didn't work.(i have already installed ros-kinetic-gazebo-control).
could someone can help me?thanks

Hi~
I have similar problems when i just install the package and "roslaunch husky_gazebo husky_empty_world.launch". The specific manifestation of the error is that the node gazebo is not linked to the velocity command node.
It bothers me a lot. If there is a solution , let me know please . Thanks a lot

A few questions:

Are you using Melodic or Kinetic?
Did you install husky_gazebo from-source or from the .deb package?
Have you installed all available updates on your system?

A few questions:

Are you using Melodic or Kinetic?
Did you install husky_gazebo from-source or from the .deb package?
Have you installed all available updates on your system?
hi
*Melodic
*from source i think . i cloned package from here.
*sorry im not sure about what you mean.
Thanks in advance!

@civerachb-cpr
Thanks a lot. It is available after i update many packages.

Glad you got it working.
I'll leave this ticket open for now in case @numb0824 can provide more information.

I have the same problem. Unfortunately I tried a lot but useless. When I run "roslaunch husky_gazebo husky_empty_world.launch" it worked but when I run "roslaunch husky_gazebo husky_playpen.launch" it didn't. I'm using ros melodic on ubuntu 18.04. Neither from-source nor from-deb can work.

I have the same problem. Unfortunately I tried a lot but useless. When I run "roslaunch husky_gazebo husky_empty_world.launch" it worked but when I run "roslaunch husky_gazebo husky_playpen.launch" it didn't. I'm using ros melodic on ubuntu 18.04. Neither from-source nor from-deb can work.

@illuSION-crypto are you seeing the same ROS output as the original poster?
waitForService: Service [/gazebo/set_physics_properties] has not been advertised, waiting...
Controller Spawner couldn't find the expected controller_manager ROS interface

Or are you seeing something different?

@illuSION-crypto are you seeing the same ROS output as the original poster?
waitForService: Service [/gazebo/set_physics_properties] has not been advertised, waiting...
Controller Spawner couldn't find the expected controller_manager ROS interface

Or are you seeing something different?

@illuSION-crypto are you seeing the same ROS output as the original poster?
waitForService: Service [/gazebo/set_physics_properties] has not been advertised, waiting...
Controller Spawner couldn't find the expected controller_manager ROS interface

Or are you seeing something different?

yes, just as you say

@illuSION-crypto are you seeing the same ROS output as the original poster?
waitForService: Service [/gazebo/set_physics_properties] has not been advertised, waiting...
Controller Spawner couldn't find the expected controller_manager ROS interface

Or are you seeing something different?

yes, just as you say

If you've installed from source, please make sure to run:
rosdep install --from-paths /path/to/src --ignore-src -r -y

Once that's done, or if you installed via apt and not from source, please run:
sudo apt-get update
sudo apt-get dist-upgrade

If you've installed from source, please make sure to run:
rosdep install --from-paths /path/to/src --ignore-src -r -y

Once that's done, or if you installed via apt and not from source, please run:
sudo apt-get update
sudo apt-get dist-upgrade

If you've installed from source, please make sure to run:
rosdep install --from-paths /path/to/src --ignore-src -r -y

Once that's done, or if you installed via apt and not from source, please run:
sudo apt-get update
sudo apt-get dist-upgrade

I tried both but still don't work. I check the log and find it is the same problem:
[rosout][INFO] 2021-01-19 00:07:00,063: Controller Spawner: Waiting for service controller_manager/load_controller
[rospy.internal][INFO] 2021-01-19 00:07:00,268: topic[/rosout] adding connection to [/rosout], count 0
[rospy.internal][INFO] 2021-01-19 00:07:02,177: topic[/clock] adding connection to [http://lenovo-ThinkPad-E575:33995/], count 0
[rosout][WARNING] 2021-01-19 00:07:30,307: Controller Spawner couldn't find the expected controller_manager ROS interface.
[rospy.core][INFO] 2021-01-19 00:07:30,311: signal_shutdown [atexit]
[rospy.internal][INFO] 2021-01-19 00:07:30,318: topic[/rosout] removing connection to /rosout
[rospy.internal][INFO] 2021-01-19 00:07:30,319: topic[/clock] removing connection to http://lenovo-ThinkPad-E575:33995/
[rospy.impl.masterslave][INFO] 2021-01-19 00:07:30,320: atexit
[rospy.internal][WARNING] 2021-01-19 00:07:30,321: Unknown error initiating TCP/IP socket to lenovo-ThinkPad-E575:56797 (http://lenovo-ThinkPad-E575:33995/): Traceback (most recent call last):
File "/opt/ros/melodic/lib/python2.7/dist-packages/rospy/impl/tcpros_base.py", line 563, in connect
self.local_endpoint = self.socket.getsockname()
AttributeError: 'NoneType' object has no attribute 'getsockname'

If you've installed from source, please make sure to run:
rosdep install --from-paths /path/to/src --ignore-src -r -y

Once that's done, or if you installed via apt and not from source, please run:
sudo apt-get update
sudo apt-get dist-upgrade

I tried both but still don't work. I check the log and find it is the same problem:
[rosout][INFO] 2021-01-19 00:07:00,063: Controller Spawner: Waiting for service controller_manager/load_controller
[rospy.internal][INFO] 2021-01-19 00:07:00,268: topic[/rosout] adding connection to [/rosout], count 0
[rospy.internal][INFO] 2021-01-19 00:07:02,177: topic[/clock] adding connection to [http://lenovo-ThinkPad-E575:33995/], count 0
[rosout][WARNING] 2021-01-19 00:07:30,307: Controller Spawner couldn't find the expected controller_manager ROS interface.
[rospy.core][INFO] 2021-01-19 00:07:30,311: signal_shutdown [atexit]
[rospy.internal][INFO] 2021-01-19 00:07:30,318: topic[/rosout] removing connection to /rosout
[rospy.internal][INFO] 2021-01-19 00:07:30,319: topic[/clock] removing connection to http://lenovo-ThinkPad-E575:33995/
[rospy.impl.masterslave][INFO] 2021-01-19 00:07:30,320: atexit
[rospy.internal][WARNING] 2021-01-19 00:07:30,321: Unknown error initiating TCP/IP socket to lenovo-ThinkPad-E575:56797 (http://lenovo-ThinkPad-E575:33995/): Traceback (most recent call last):
File "/opt/ros/melodic/lib/python2.7/dist-packages/rospy/impl/tcpros_base.py", line 563, in connect
self.local_endpoint = self.socket.getsockname()
AttributeError: 'NoneType' object has no attribute 'getsockname'

It looks like the issue is actually somewhere deeper inside ROS and/or gazebo, not with Husky itself.  The fact that self.socket is apparent None is worrying.
Could you please try running
sudo apt-get install ros-melodic-gazebo-ros-control

It looks like the issue is actually somewhere deeper inside ROS and/or gazebo, not with Husky itself.  The fact that self.socket is apparent None is worrying.
Could you please try running
sudo apt-get install ros-melodic-gazebo-ros-control

It looks like the issue is actually somewhere deeper inside ROS and/or gazebo, not with Husky itself. The fact that self.socket is apparent None is worrying.
Could you please try running
sudo apt-get install ros-melodic-gazebo-ros-control

Actually I already install it. Just now I found after I disconnect from the internet this problem disappear and there is a empty world in gazebo.

So I wonder whether models is being downloaded when ros running ?

It looks like the issue is actually somewhere deeper inside ROS and/or gazebo, not with Husky itself. The fact that self.socket is apparent None is worrying.
Could you please try running
sudo apt-get install ros-melodic-gazebo-ros-control

Actually I already install it. Just now I found after I disconnect from the internet this problem disappear and there is a empty world in gazebo.

So I wonder whether models is being downloaded when ros running ?

OK I just solved this problem, when gazebo start it accesses a url which can't reach. I just accesses it using a http proxy

OK I just solved this problem, when gazebo start it accesses a url which can't reach. I just accesses it using a http proxy

Glad you got it working!

Glad you got it working!


Tile map didn't show tile maps?

It seems like no matter how I include the base url with zoom 19, it doesn't show the map.
It doesn't show any errors. but shows blank image.
https://github.com/swri-robotics/mapviz/assets/13714992/7939b306-71a4-4e85-a3f5-0a61ce974622
I used this map proxy to provide an offline google maps.
https://github.com/danielsnider/MapViz-Tile-Map-Google-Maps-Satellite

Hey having the same issue, any results on this topic?

Usually this is a result of either a bad key or otherwise invalid map data, or something like the TF tree being invalid or GPS fix not being valid.


map file URI to multiroot scheme if provided

Description
Fixes https://github.com/flutter/flutter/issues/66095

FYI @chingjun /  @mehmetf  , if this accomplishes what is needed I can finish it up and land it

Thanks Jonah!
I don't understand this code well enough to comment on it. @chingjun likely has a better grip.
From my brief look:

You removed KernelCompilerFactory which does not seem to be used anywhere. We also don't override it in g3. Not sure why it was created in the first place.
There's a FuchsiaKernelCompiler which seems completely different. Does that need to change as well?
Do we need to make any changes to internal tooling code for this? The only place I see KernelCompiler being used is in common.dart and the params are hardcoded.


Build for MacOS

Related to #51

Build server for MacOS
Build electron for MacOS
electron/main.ts: normally kill subprocess
local_files.py: use MacOS file location

Closing - won't do.
It's not difficult, but neither pyinstaller nor electron-builder support cross-platform build.
I'd have to use a MacBook everytime I build, or spend considerable effort dockerizing the build process 🙉
I assume very few people, if any, would use VLizard on MacOS, so it's not worth the effort!


Typo fix

The description of powder remove has a typo: 'depreciated' should be 'deprecated'. This commit fixes that.

thanks!


Custom Achivements 0.5

Describe your problem here.
Im new to code and i cant find any tutorial on how to code achivements in 0.5 so yeah help
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
no

This a same as 4.2


UX Polish: Update Back to Questionnaire on questionnaire collapsed

This is a nice-to-have issue
Currently this page reads "UPDATE MY RECOMMENDATIONS - Go back to questions" with a right-facing arrow. Ideally we would simplify this and write "Back to questionnaire" with a left-facing arrow on both the BC and MB Questionnaire Collapsed pages.
BC Page: https://zpl.io/VkwQ5rv
MB Page: https://zpl.io/brGl5wX

Solved as part of #1539


Can't browse the site using a different date

If I'm using the API, then I can change the date to see what the message is for different days. However, this doesn't work for the site: https://shouldideploy.today/api?date=2023-11-08 correctly tells me I can deploy, but https://shouldideploy.today/?date=2023-11-08 still tells me not to deploy because of Christmas

The web interface doesn't handle the date parameter from the URL query string like the API does. I need to think about this a little more PR's are welcome


Left column contains too little information

In the list based views (e.g. overview-incoming-requests), the items of the left side should contain the counterpart's creationDate, the description and a red dot if the connection is associated with an unread event.
See WON-mockup20160404-clickdummy.pdf:p5 for an example.

no longer relevant


Use docker API instead of exec docker commands

Call commands are less safe than call the docker API. In long time docker-cli may change contract and should broken the app, the API of docker is versioned and avoid break changes.
References:
https://docs.docker.com/engine/reference/api/docker_remote_api/
https://github.com/softprops/tugboat

is this meant in the sense of the invoker using API calls instead of CLI?

Looking at recent optimizations in the Invoker (introducing Futures and more typing) this could make a lot of sense to encapsulate the docker commands naturally, without the need to think about managing resources for the blocking docker calls.

Of course @perryibm is going below docker commands. @perryibm comment?


wrong key id

I found this line: https://github.com/VirtualCable/openuds/blob/8046add26edc6f5abdfb5f5dabfdb2087e694cd2/client-py3/full/linux/udsclient-appimage-x86_64.recipe#L33
It looks like to verify buster not bullseye

Fixed with the default key location for debian packages:
https://github.com/VirtualCable/openuds/commit/2f6132ec56c969c3f65f5e890f8f267f7d25c8b2
Also, fixed on master


Full SD? What to delete?

Hello.
I have been running my node for over one year, but I noticed the SSD has little free space.
If I want to clear a little of space, what could I safely delete ?
Thanks,
f.

According to your list above, no external drive is mounted. This can have many reasons, like filesystem corruption, which you might be able to see from the error message you get when manually mounting all drives in /ect/fstab with sudo mount -a.
Please check if your mountpoint (either /mnt/hdd or /mnt/ext) is active:
$ mountpoint /mnt/hdd

If it's not a mountpoint (my guess), all applications probably wrote directly into that directory (which is on the SD card), instead onto the external drive, which is meant to be accessed on this mountpoint. You then need to stop all services (bitcoind, lnd etc.) and delete everything in that directory.
Do this only if this is not a mountpoint:
$ ls -la /mnt/hdd
$ rm -rf /mnt/hdd/*

Next, you need to figure out how to mount this (or a replacement) drive sucessfully to the mountpoint again.

I took the long and safe way.
I did all from scratch. I didn't erase anything from the HD, of course, so I hads already all the blockchain downloaded and verified on the HHD. And I started directly from mainnet.
The result is not so satyisfing, as  the result is this
IMAGE LINK
I think the HDD is correctly mounted:
`
bitcoin@Raspibitcoin:~ $ ls -la
total 28
drwxr-xr-x 3 bitcoin bitcoin 4096 Feb  6 23:09 .
drwxr-xr-x 5 root    root    4096 Feb  5 00:13 ..
-rw------- 1 bitcoin bitcoin  783 Feb  8 01:01 .bash_history
-rw-r--r-- 1 bitcoin bitcoin  220 Feb  5 00:13 .bash_logout
-rw-r--r-- 1 bitcoin bitcoin 3523 Feb  5 00:13 .bashrc
lrwxrwxrwx 1 bitcoin bitcoin   16 Feb  6 00:04 .bitcoin -> /mnt/hdd/bitcoin
lrwxrwxrwx 1 bitcoin bitcoin   12 Feb  6 23:09 .lnd -> /mnt/hdd/lnd
drwxr-xr-x 3 bitcoin bitcoin 4096 Feb  6 00:05 .local
-rw-r--r-- 1 bitcoin bitcoin  807 Feb  5 00:13 .profile
`
How can I fix it?

Can you run the following commands and post thre results here? If you use three backticks (```), you can create a nice code block like in the edited post above.
$ df -h
$ mountpoint /mnt/hdd

Everything looks pretty good. Both / and /boot have plenty of space, and the external drive uses about 40% of capacity.
Is there anything left to fix?

Yes.
Welcome screen displays little space on the disk.
Posting screengrab tomorrow, when back to base.

Well, your microSD card has plenty of space, so it's likely an issue with the welcome script, not with the underlying system.
This is the part responsible for getting the values:
https://github.com/Stadicus/RaspiBolt/blob/94dd65660dba56c52b4c6da7c53e6c65cbea8e1b/resources/20-raspibolt-welcome#L41-L48
For me, the calculation gives the following values. Can you try replicating it?
admin@raspibolt:~ $ df -h
/dev/root        15G    5.2G  8.6G   38% /
...
...
admin@raspibolt:~ $ df | grep "/$" | awk '{ print $4/$2*100 }'
59.8183
admin@raspibolt:~ $ df -h | grep '/$' | awk '{ print $4 }'
8.6G

Ah, now I get that you are referring to the external drive. The latest version of the guide uses the mountpoint /mnt/ext instead of /mnt/hdd.
Can you try to change that to ext_hdd="/mnt/hdd" in the script here?
#Set to mount point of blockchain volume. This is used to calculate USB HDD usage %
ext_hdd="/mnt/ext"

Did that work out for you?

Closing this issue due to inactivity. Feel free to reopen it if further assistance is required.


dangerouslySetInnerHTML error

So I've tried to use the component. But I get the error about the wrong usage of the property dangerouslySetInnerHTML.
I've setup an app showing this.
You can just follow the README to fire it up and see the error in the browser's console.
Any idea what might be wrong?

Here, apparently feeding a null value to the editor was triggering the assertion.
I've defaulted that to an empty string. This should fix your issue, but let me know if otherwise.


Fix build issue with Node 10

This PR bumps firebase version to be compatible with the latest node.

@armiol, PTAL


Fix pressing keys on a hardware keyboard showing the software keyboard

Closes https://github.com/ppy/osu/issues/17561
Closes https://github.com/ppy/osu/issues/6282

can't repro, but not returning null and forcing OnCheckIsTextEditor() => true is the probable cause

By default, Android will show the software keyboard while text input is active even if a hardware keyboard is connected. And since we were always returning a valid IInputConnection, Android would "conveniently" show the software keyboard when any hardware keys are pressed.
Pressing keys will (re)focus the current view and probe OnCreateInputConnection() to see if the input method is to be activated.
The docs specify to return null when input methods are not supported by a specific View. Since we have only one View, returning null here means to disable text input for the time being (until a textbox is focused and AndroidTextInput is activated).

Probably best to get a second check on this one, looks okay code-wise though.


--until not working with checkpoints

Hello,
I cannot use --until for rules between a checkpoint and the rule where the aggregation happens. If I use --until, it says Nothing to be done. If I do not use --until, everything works perfectly fine.
Here is a minimal example, where snakemake --cores all --until r2 does not work, even after running rule r1 beforehand.
rule all:
    input:
        'agg'

checkpoint r1:
    output:
        directory('B')
    shell:
        'mkdir -p B && touch B/1 && touch B/2 && touch B/3'

rule r2:
    input:
        'B/{i}'
    output:
        'C{i}'
    shell:
        'touch {output}'

def aggregate_input(wildcards):
    checkpoint_output = checkpoints.r1.get(**wildcards).output
    exp = expand('C{i}', i=glob_wildcards( 'B/{i}').i)
    return exp

rule r3:
    input:
        aggregate_input
    output:
        'agg'
    shell:
        'touch {output}'

I hope you can help me. Thank you very much in advance!
Khoa

can confirm and reproduce this

Thank you for your answer

Thank you for your answer! Still, would it be possible to add this functionality to --until somehow?

I'm not sure. But if you figure out how to fix this, you should open a PR!


Ethan: Watch tiffany49983315

Ethan requests the watch of the watch_keyword tiffany49983315. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

tiffany49983315 has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by cocomac in Charcoal HQ


[hpx] Adding support for HPX release v1.9.1

[x] Changes comply with the maintainer guide
[x] SHA512s are updated for each updated download
[x] The "supports" clause reflects platforms that may be fixed by this new version
[x] Any fixed CI baseline entries are removed from that file.
[x] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

@hkaiser, Thanks for your PR, this is error, please take look:
CMake Error at ports/hpx/portfile.cmake:94 (file):
  file RENAME failed to rename

    D:/packages/hpx_x64-windows/bin/hpxrun.py

  to

    D:/packages/hpx_x64-windows/tools/hpx/hpxrun.py

  because: The system cannot find the file specified.

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

This should be fine now. Thanks!

@hkaiser, There is one more bug that needs to be fixed:
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\thread_pools\include\hpx\thread_pools\scheduled_thread_pool.hpp(107): note: see the first reference to 'hpx::threads::policies::shared_priority_queue_scheduler<std::mutex,hpx::threads::policies::concurrentqueue_fifo,hpx::threads::policies::default_shared_priority_queue_scheduler_terminated_queue>::get_thread_count' in 'hpx::threads::detail::scheduled_thread_pool<hpx::threads::policies::shared_priority_queue_scheduler<std::mutex,hpx::threads::policies::concurrentqueue_fifo,hpx::threads::policies::default_shared_priority_queue_scheduler_terminated_queue>>::get_thread_count'
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\schedulers\include\hpx\schedulers\queue_holder_thread.hpp(767): warning C4244: 'return': conversion from 'int64_t' to 'size_t', possible loss of data
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\schedulers\include\hpx\schedulers\queue_holder_thread.hpp(772): warning C4244: 'return': conversion from 'int64_t' to 'size_t', possible loss of data
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\schedulers\include\hpx\schedulers\queue_holder_thread.hpp(777): warning C4244: 'return': conversion from 'int64_t' to 'size_t', possible loss of data
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\schedulers\include\hpx\schedulers\queue_holder_thread.hpp(784): warning C4244: 'return': conversion from 'int64_t' to 'size_t', possible loss of data
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\concurrency\include\hpx\concurrency\detail\tagged_ptr_pair.hpp(96): error C2672: 'hpx::bit_cast': no matching overloaded function found
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\type_support\include\hpx\type_support\bit_cast.hpp(34): note: could be 'enable_if<sizeof(To)==sizeof(From)&&std::is_trivially_copyable_v<From>&&std::is_trivially_copyable_v<To>,To>::type hpx::bit_cast(const From &) noexcept'
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\concurrency\include\hpx\concurrency\detail\tagged_ptr_pair.hpp(96): note: Failed to specialize function template 'enable_if<sizeof(To)==sizeof(From)&&std::is_trivially_copyable_v<From>&&std::is_trivially_copyable_v<To>,To>::type hpx::bit_cast(const From &) noexcept'
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\concurrency\include\hpx\concurrency\detail\tagged_ptr_pair.hpp(96): note: With the following template arguments:
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\concurrency\include\hpx\concurrency\detail\tagged_ptr_pair.hpp(96): note: 'To=Right *'
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\concurrency\include\hpx\concurrency\detail\tagged_ptr_pair.hpp(96): note: 'From=uint64_t'
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\concurrency\include\hpx\concurrency\detail\tagged_ptr_pair.hpp(93): note: while compiling class template member function 'Right *hpx::lockfree::tagged_ptr_pair<hpx::lockfree::deque_node<T>,Right>::extract_right_ptr(hpx::lockfree::tagged_ptr_pair<hpx::lockfree::deque_node<T>,Right>::compressed_ptr_pair_t) noexcept'

@hkaiser, There is one more bug that needs to be fixed:
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\thread_pools\include\hpx\thread_pools\scheduled_thread_pool.hpp(107): note: see the first reference to 'hpx::threads::policies::shared_priority_queue_scheduler<std::mutex,hpx::threads::policies::concurrentqueue_fifo,hpx::threads::policies::default_shared_priority_queue_scheduler_terminated_queue>::get_thread_count' in 'hpx::threads::detail::scheduled_thread_pool<hpx::threads::policies::shared_priority_queue_scheduler<std::mutex,hpx::threads::policies::concurrentqueue_fifo,hpx::threads::policies::default_shared_priority_queue_scheduler_terminated_queue>>::get_thread_count'
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\schedulers\include\hpx\schedulers\queue_holder_thread.hpp(767): warning C4244: 'return': conversion from 'int64_t' to 'size_t', possible loss of data
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\schedulers\include\hpx\schedulers\queue_holder_thread.hpp(772): warning C4244: 'return': conversion from 'int64_t' to 'size_t', possible loss of data
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\schedulers\include\hpx\schedulers\queue_holder_thread.hpp(777): warning C4244: 'return': conversion from 'int64_t' to 'size_t', possible loss of data
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\schedulers\include\hpx\schedulers\queue_holder_thread.hpp(784): warning C4244: 'return': conversion from 'int64_t' to 'size_t', possible loss of data
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\concurrency\include\hpx\concurrency\detail\tagged_ptr_pair.hpp(96): error C2672: 'hpx::bit_cast': no matching overloaded function found
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\type_support\include\hpx\type_support\bit_cast.hpp(34): note: could be 'enable_if<sizeof(To)==sizeof(From)&&std::is_trivially_copyable_v<From>&&std::is_trivially_copyable_v<To>,To>::type hpx::bit_cast(const From &) noexcept'
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\concurrency\include\hpx\concurrency\detail\tagged_ptr_pair.hpp(96): note: Failed to specialize function template 'enable_if<sizeof(To)==sizeof(From)&&std::is_trivially_copyable_v<From>&&std::is_trivially_copyable_v<To>,To>::type hpx::bit_cast(const From &) noexcept'
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\concurrency\include\hpx\concurrency\detail\tagged_ptr_pair.hpp(96): note: With the following template arguments:
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\concurrency\include\hpx\concurrency\detail\tagged_ptr_pair.hpp(96): note: 'To=Right *'
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\concurrency\include\hpx\concurrency\detail\tagged_ptr_pair.hpp(96): note: 'From=uint64_t'
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\concurrency\include\hpx\concurrency\detail\tagged_ptr_pair.hpp(93): note: while compiling class template member function 'Right *hpx::lockfree::tagged_ptr_pair<hpx::lockfree::deque_node<T>,Right>::extract_right_ptr(hpx::lockfree::tagged_ptr_pair<hpx::lockfree::deque_node<T>,Right>::compressed_ptr_pair_t) noexcept'

@JonLiu1993 what compiler is that happening with?

@hkaiser: VS2022 targeting x86.

@hkaiser: VS2022 targeting x86.

We currently do not really support 32bit builds (in particular on Windows). Is there a way to disable this on vcpkg? I have however opened a ticket (https://github.com/STEllAR-GROUP/hpx/issues/6323) to have a look at this for the next release.

add "supports": "!(windows & x86)" to the manifest

@hkaiser, if this PR is ready for review please let me know.

@hkaiser, if this PR is ready for review please let me know.

@JonLiu1993 Yes, this is ready to go (at least the tests pass now). Thanks!

@hkaiser, When I tested the usage by hpx:x64-windows I get this error, could you please take a look:
1> CMake generation started for configuration: 'x64-Debug'.
1> Command line: "C:\WINDOWS\system32\cmd.exe" /c "%SYSTEMROOT%\System32\chcp.com 65001 >NUL && "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\CMake\bin\cmake.exe"  -G "Visual Studio 17 2022" -A x64  -DCMAKE_CONFIGURATION_TYPES:STRING="Debug" -DCMAKE_INSTALL_PREFIX:PATH="C:\Users\test\source\repos\usageTest\out\install\x64-Debug" -DCMAKE_TOOLCHAIN_FILE=F:/Feature-test/vcpkg/scripts/buildsystems/vcpkg.cmake "C:\Users\test\source\repos\usageTest" 2>&1"
1> Working directory: C:\Users\test\source\repos\usageTest\out\build\x64-Debug
1> [CMake] -- Selecting Windows SDK version 10.0.22621.0 to target Windows 10.0.19045.
1> [CMake] CMake Error at F:/Feature-test/vcpkg/scripts/buildsystems/vcpkg.cmake:855 (_find_package):
1> [CMake]   By not providing "FindHPX.cmake" in CMAKE_MODULE_PATH this project has
1> [CMake]   asked CMake to find a package configuration file provided by "HPX", but
1> [CMake]   CMake did not find one.
1> [CMake]
1> [CMake]   Could not find a package configuration file provided by "HPX" with any of
1> [CMake]   the following names:
1> [CMake]
1> [CMake]     HPXConfig.cmake
1> [CMake]     hpx-config.cmake
1> [CMake]
1> [CMake]   Add the installation prefix of "HPX" to CMAKE_PREFIX_PATH or set "HPX_DIR"
1> [CMake]   to a directory containing one of the above files.  If "HPX" provides a
1> [CMake]   separate development package or SDK, be sure it has been installed.
1> [CMake] Call Stack (most recent call first):
1> [CMake]   usageTest/CMakeLists.txt:5 (find_package)
1> [CMake] -- Configuring incomplete, errors occurred!
1> 'C:\WINDOWS\system32\cmd.exe' '/c "%SYSTEMROOT%\System32\chcp.com 65001 >NUL && "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\CMake\bin\cmake.exe"  -G "Visual Studio 17 2022" -A x64  -DCMAKE_CONFIGURATION_TYPES:STRING="Debug" -DCMAKE_INSTALL_PREFIX:PATH="C:\Users\test\source\repos\usageTest\out\install\x64-Debug" -DCMAKE_TOOLCHAIN_FILE=F:/Feature-test/vcpkg/scripts/buildsystems/vcpkg.cmake "C:\Users\test\source\repos\usageTest" 2>&1"' execution failed with error: ''C:\WINDOWS\system32\cmd.exe' '/c "%SYSTEMROOT%\System32\chcp.com 65001 >NUL && "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\CMake\bin\cmake.exe"  -G "Visual Studio 17 2022" -A x64  -DCMAKE_CONFIGURATION_TYPES:STRING="Debug" -DCMAKE_INSTALL_PREFIX:PATH="C:\Users\test\source\repos\usageTest\out\install\x64-Debug" -DCMAKE_TOOLCHAIN_FILE=F:/Feature-test/vcpkg/scripts/buildsystems/vcpkg.cmake "C:\Users\test\source\repos\usageTest" 2>&1"' returned with exit code: 1'.

Usage:
The port hpx provides CMake targets:

    find_package(HPX REQUIRED)
    target_link_libraries(main PRIVATE HPX::hpx)

CMakeLists.txt:
cmake_minimum_required (VERSION 3.8)

project(test)

find_package(HPX REQUIRED)

add_executable (test "usageTest.cpp")

target_link_libraries(test PRIVATE HPX::hpx)

usageTest.cpp:
#include <stdio.h>

int main()
{
    printf("%s\n", "HELLO WORLD");
    return 0;
}

CMakeSettings.json:
{
  "configurations": [
    {
      "name": "x64-Debug",
      "generator": "Visual Studio 17 2022 Win64",
      "configurationType": "Debug",
      "inheritEnvironments": [ "msvc_x64_x64" ],
      "buildRoot": "${projectDir}\\out\\build\\${name}",
      "installRoot": "${projectDir}\\out\\install\\${name}",
      "cmakeCommandArgs": "-DCMAKE_TOOLCHAIN_FILE=F:/Feature-test/vcpkg/scripts/buildsystems/vcpkg.cmake",
      "buildCommandArgs": "",
      "ctestCommandArgs": ""
    }
   ]
}

@JonLiu1993 According to the file list: hpx:x64-windows:/share/hpx/HPXConfig.cmake there should be a config. Are you sure you have the correct triplet selected? (consider using manifest mode for usage testing.)


Icon colour in notification is black

Hi all,
For the notification icon, I have a PNG with a white icon and transparent background. The background of the icon is set with defaultColor and that works fine, but the icon is black even though the image is white?

Does anyone have any idea why this is happening? Note: this has only been tested on Android 12 so far.

Has anyone else encountered this issue? I haven't been able to solve it yet.

Hi! Sorry for taking so long to respond to your issue on GitHub. I was focused on releasing the new 0.7.0 version of awesome_notifications and awesome_notifications_fcm and i didn't had time enough to do both. But now I can answer all your questions.
So now i'm asking you to recreate this topic using the new issue template. There's a lot of missing informations that i need to understand your problem, and all the instructions are already in the new issue template. Also, remember to check beforehand if your issue was posted by another user.
So I will automatically close all previous issues so far.
Sorry for the inconvenience and i will be waiting for your new issue request.
Thank you so much for your support!


Should a deeper-nested style specification inherit the colors/style of its parent?

I have question related to jQuery Terminal
This may be a bug, or it may be a bug in my expectations.  I would expect that a string like this:
[[;green;black]This text is green but [[u;;]this text is green and underlined] and this is green]
Would produce text that is all green/black, with an underlined section in the middle.  However, the underlined text is the default text color.
Is this working as intended?

Yes, you're right, the middle text should be green, the nested_formatting that is responsible for this is very simple.
This is something that can be fixed.

This is the fix:
$.terminal.nested_formatting = function nested_formatting(string) {
    if (!$.terminal.have_formatting(string)) {
        return string;
    }
    var stack = [];
    var re = /((?:\[\[(?:[^\][]|\\\])+\])?(?:[^\][]|\\\])*\]?)/;
    var format_re = /(\[\[(?:[^\][]|\\\])+\])[\s\S]*/;
    var format_split_re = /^\[\[([^;]*);([^;]*);([^;\]]*)/;
    function get_inherit_style(stack) {
        var style = ['','',''];
        if (!stack.length) {
            return style;
        }
        for (var i = stack.length; i--;) {
            var formatting = stack[i].match(format_split_re);
            for (var j = 0; j < style.length; ++j) {
                var value = formatting[j + 1].trim();
                if (value && !style[j]) {
                    style[j] = value;
                }
            }
        }
        return style;
    }
    return string.split(re).filter(Boolean).map(function(string) {
        if (string.match(/^\[\[/)) {
            var formatting = string.replace(format_re, '$1');
            var is_formatting = $.terminal.is_formatting(string);
            string = string.replace(format_split_re, '');
            stack.push(formatting);
            var style = get_inherit_style(stack).join(';');
            if (!is_formatting) {
                string += ']';
            } else {
                stack.pop();
            }
            string = '[[' + style + string;
        } else {
            var pop = false;
            if (string.match(/\]/)) {
                pop = true;
            }
            if (stack.length) {
                var style = '[[' + get_inherit_style(stack).join(';') + ']';
                string = style + string;
            }
            if (pop) {
                stack.pop();
            } else if (stack.length) {
                string += ']';
            }
        }
        return string;
    }).join('');
};
$.terminal.nested_formatting.__meta__ = true;
$.terminal.nested_formatting.__no_warn__ = true;
$.terminal.defaults.formatters = [$.terminal.nested_formatting];

I will also need to write unit tests and I'm not sure but I think this should be behind some kind of option.
See Demo

Yes I think an option will be useful, specifically to not inherit.  If that option were 'x', you could say something like:
[[g;blue;black]Awesome glowing, then [[x;;]unstyled] then more awesome glowing]
Is that what you mean by behind an option?

In terms of my use case, I am messing with a color/style utility for producing styled strings for jquery.terminal, that works like kleur (or chalk, ansi-colors, etc) does for ansi escape codes.

By option I'm more like:
$.terminal.nested_formatting.__inherit__ = true;

Take this line for example: "The quick brown fox".  How would you style that, since there is no way to remove the italics, if nested formatting inherits?
And if you can't drop specific things like italics, glow, bold, etc....then nested inheritance is not entirely useful.  It's almost like you need a - (too bad ! is already used) operator, to say things like [[bu;;]blah blah][[-b;;]blah blah]]

This is not good example, because you can very easy create this yourself, you don't need nesting in this case:
$.terminal.defaults.formatters.push(
    [/_([^_]*)_/g, '[[u;;]$1]']
);

Demo

I am enlightened! Thank you.

Inherit nested formatting will be disabled by default so it don't break existing code. To enable it you need to use:
$.terminal.nested_formatting.__inherit__ = true;

Removing bug, because it was meant to work this way, there where even test that confirm that.

You can now use this:
[[bu;#fff;]hello [[u-b;;] world] from js]

it will be converted to (by nested formatting):
[[bu;#fff;]hello ][[u;#fff;] world][[bu;#fff;] from js]

and remove bold from text " world", and " from js" will be bold.

Excellent, thanks for that

released in 2.8.0


2019.311f1

[Enter feedback here]
The app when deployed on Hololens doesn't launch as Hololens app but more like a widows app.
This only happns in unity 2019.3 and not in 2018.
any ideas?

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 62d386bb-3f93-d434-e7b3-28c58ea673e9
Version Independent ID: a1a9b02f-66a0-feb0-7a08-9a8d2cf398d1
Content: Getting started tutorials - 2. Initializing your project and first application - Mixed Reality
Content Source: mixed-reality-docs/mrlearning-base-ch1.md
Product: mixed-reality
Technology: mr-dev
GitHub Login: @jessemcculloch
Microsoft Alias: jemccull

@laylagordon-666, because you are using Unity 2019.3, it's possible that Unity disabled legacy VR in your project (in favor of the new XR Plugin Management system) without your knowledge. You can follow the Configure the Unity project for Windows Mixed Reality instructions to check.
Issue https://github.com/MicrosoftDocs/mixed-reality/issues/2198#issuecomment-626984298 might also be of help.

I have enabled legacy VR but Unity compains that Built-in VR must be disabled prior to using XR plug-in Management. Also the instructions in that link are for unity 2018?

it says above that legacy XT is incompatibe with XR SDK

The tutorial should stress that it does NOT work with Unity 2019.3.X.
It took me hours to find out that using the newest version of Unity was the reason for not getting anything to run on Hololens2.
Now tried Unity 2019.2.21f1 and it works.

I'm glad you say that. Mine works perfcetly on 2019.2 too but NOT on 2019.3
can you please conofirm this is official line?
its wasted me so much time trying to get it working

@laylagordon-666 and @kkroesl, sorry for the wasted time.
__

I have enabled legacy VR but Unity compains that Built-in VR must be disabled prior to using XR plug-in Management. Also the instructions in that link are for unity 2018?

Those are for Unity 2019.2 and should generally also work for Unity 2018 LTS, but will not work with Unity 2019.3 if you accept Unity's  'Built in VR Detected' and 'Built in VR Enabled' prompts as that will disable built-in/legacy VR and remove Windows Mixed Reality SDK.
If instead you close those two popups you should be able to deploy to HoloLens using built-in/legacy VR.
If you want to try Unity's new XR Plugin Management system, you can refer to the Getting started with MRTK and XR SDK.
__

it says above that legacy XR is incompatibe with XR SDK

You can't use built-in/legacy VR with the new XR Plugin Management system. To re-enable built-in/legacy VR you can try to run the MRTK Project Configurator again, if that doesn't work, you probably need to first uninstall the XR Plugin Management package (using Package Manager).
__

The tutorial should stress that it does NOT work with Unity 2019.3.X.
It took me hours to find out that using the newest version of Unity was the reason for not getting anything to run on Hololens2.
Now tried Unity 2019.2.21f1 and it works.

Thanks for the feedback. There is an 'Important' note in the Prerequisite section of this tutorial series:

but we will consider making it more explicit.
__

The tutorial should stress that it does NOT work with Unity 2019.3.X.
It took me hours to find out that using the newest version of Unity was the reason for not getting anything to run on Hololens2.
Now tried Unity 2019.2.21f1 and it works.

I'm glad you say that. Mine works perfcetly on 2019.2 too but NOT on 2019.3
can you please conofirm this is official line?
its wasted me so much time trying to get it working

The tutorials officially supports Unity 2019.2, not Unity 2019.3, however, it is possible to deploy to HoloLens using Unity 2019.3 with built-in/legacy VR or the new XR Plugin Management system as outlined above.

I like to get the new XR SDK working with 2019.3 and deploy tp HL2.
I've tried using that link you just posted before and I get an error. But I just gave it another go.
I have set the profile to the defaultXRSDK one and I'm skipping the steps for "To migrate an existing profile to XR SDK, the following services and data providers should be updated" as I'm not porting an existing profile?
I've attached the screenshot of the error I get just by pressing play in unity on the scene

@laylagordon-666, first thing I would do is to upgrade/use the latest Unity 2019.3 patch version which is 2019.3.14 as the XR packages will be updated as well.

also I#m not getting thr the diagnostic widget and  hand joint service. Even before I pause the scene (which is when I get the error) nothing happens in the scene where as with the one on the left you get a bigger list

I updated the XRSDK to the latest version in my 2019.3.11f1 but just following your suggestion I'm now downloading 2019.3.14f1

@laylagordon-666, thought you might wanted to know that MRTK 2.4.0 was just released, so if you want to use the new XR Pluging Management system, you might have better luck with that version of MRTK. But please note that the tutorials are made for MRTK 2.3.0 and Unity 2019.2.

Thanks, will give that a go :)

so the app launches inside a window with unity logo and i can see my blank scene but it doesn't behave like a Hololens app with the optimizer, spatial perception and the hand cause the widgets ddon't exist under the defaultXRSDKconfiguration profile. do I need to add those seperatly? I'm guessing I can't use the Hololens ones or the other mixedreality default one.

ok, so progress is that the app npw launches fine and I have my hands as a holographic objects being tracked and spatial mesh in the room. Just need to add the profiler I guess. I'm using defaultXRSDK. And ARM64 at the time of deployment. The profiler seemed to be part of the DefaultMixedRealityToolkitConfigurationProfile, can I add it seperately? (the one that shows the FPS info)

actually just figured out the diagnostic tool was disabled in that profile. I think its all working now

could you just point me towards  when in play mode in unity with the other default profiles, you see the two hands with touch pointer, how can I add those to the defaultXRSDK one?

fixed above with using ARM64.
Still getting these warnings as attached, however I cant see where the depth buffer sharing is set to 24 as I've setthe one in the XR plugin managemnt to 16.
the menu item its suggesting I use to change it, doesn't exist.

fixed the warnings by installing tools. but still getting yhat error after I pause the play button

@hferrone, FYI, this issue is not related to the tutorials because the tutorials clearly states they are for Unity 2019.2 as earlier mentioned in this thread, i.e. the tutorials do not support Unity 2019.3.X nor Unity's new XR pipeline.

Thanks @martinwilter I'm going to close this one.


builtins: add num_nulls, num_nonnulls builtins

PR: https://github.com/cockroachdb/cockroach/pull/51515
From release notes:

Added the num_nulls and num_nonnulls builtin functions, which count the number of arguments that are passed to them which are NULL or non-NULL, respectively. [#51515][#51515] {% comment %}doc{% endcomment %}

This is already documented.


Disable pointer events on messages

This enables opening the menu etc when there is a success message. caniuse.com/pointer-events

The respond.css file is produced as a part of the gulp build, so we cannot directly change this file (as it will get overwritten).  I think the file we want to change is css/src/messages.css.

@madoublet it seems removing the width altogether fixes the problem. I'm not sure about browser support though. I'll make another pull request if you want.


Spring Cloud Config | Git Based | Not working on windows machine

Hitting the URL on my browser http://localhost:{configServerPort}/{appName}/default gives expected result on a linux machine buts fails on windows machine.
InsideNativeEnvironmentRepository#clean() method, around line 153, normal.startsWith(pattern) condition fails because of '/' (forward slash) and '' (backward slash) mismatch on a Windows machine. Same thing seems to be working fine on a linux machine.
Spring Cloud version 1.0.1.RELEASE
SOF:- http://stackoverflow.com/questions/30524202/spring-cloud-config-git-based-not-working-on-windows-machine

Looks like it was fixed here: https://github.com/spring-cloud/spring-cloud-config/commit/641d5b40e861e5750393a6f57c26d8124c214083

I'm still hitting this problem even on 1.0.3.BUILD-SNAPSHOT. The string compare fails because the 'normal' var has backslashes. I'm running on Windows (through cygwin to be simplify the ssh access to our git repo) and experience the same issue. It seems as though the same change to normalise the string may need to be applied to NativeEnvironmentRepository at line 136?
From:
normal = new File(normal.substring("file:".length()))
.getAbsolutePath();
To:
normal = StringUtils.cleanPath(new File(normal.substring("file:".length()))
.getAbsolutePath());

@james-appfoundry I'm looking at NativeEnvironmentRepository line 136 from 641d5b40e861e5750393a6f57c26d8124c214083 and it has the StringUtils.cleanPath call.  Can you make sure you are using the latest code?  If you still have issues, please open a new issue.

Apologies, yes, in my rush to leave the office last night I'd missed the fact that 1.0.3.BUILD-SNAPSHOT of the cloud starter was using 1.0.2.BUILD-SNAPSHOT of the config server. Cleaned my cache and pulled down the latest 1.0.2.BUILD-SNAPSHOT build and I've picked up the change. Thanks.


Environment variable interpolation does not work as expected

Given the following pipeline:
env:
  ECR_REPO: "my_ecr_repo.dkr.ecr.us-east-1.amazonaws.com/repo"

steps:
  - name: ":docker: build web"
    agents:
      queue: builders
    plugins:
      docker-compose-buildkite-plugin#v1.1:
        build: web
        config:
          - docker-compose.yml
          - docker-compose.ci.yml
        image-repository: "${ECR_REPO}"

When this runs, the BUILDKITE_PLUGINS environment variable does not include an image-repository key for the plugin.
Instead, I'm forced to add the literal to the config, like so:
steps:
  - name: ":docker: build web"
    agents:
      queue: builders
    plugins:
      docker-compose-buildkite-plugin#v1.1:
        build: web
        config:
          - docker-compose.yml
          - docker-compose.ci.yml
        image-repository: "my_ecr_repo.dkr.ecr.us-east-1.amazonaws.com/repo"

This is non-ideal because ECR_REPO is referenced in multiple subsequent steps throughout the pipeline. Is there a way to avoid the repetition with environment variables, or am I misunderstanding how the environment variable interpolation works?
A slightly different issue occurs when attempting to use the commit as the image-name. Given the following configuration:
steps:
  - name: ":docker: build web"
    agents:
      queue: builders
    plugins:
      docker-compose-buildkite-plugin#v1.1:
        build: web
        config:
          - docker-compose.yml
          - docker-compose.ci.yml
        image-repository: "my_ecr_repo.dkr.ecr.us-east-1.amazonaws.com/repo"
	image-name: "${BUILDKITE_COMMIT}"

The image that is pushed has a tag of HEAD. It appears that at the time of pushing, HEAD has not been resolved to an actual hash. However, under the environment tab, BUILDKITE_COMMIT does show up as a hash. If I trigger a build with a specific commit, the issue does not occur.

Thanks for the detailed issue report @dalberto. Looks like there are two different issues here, for the first one:
The top-level env block will provide env variables to all steps in your file, but it doesn't make those values available for variable interpolation in the actual pipeline.yml. Variable interpolation is for ENV variables that are already set. What you could do is set BUILDKITE_PLUGIN_DOCKER_COMPOSE_IMAGE_REPOSITORY as a top-level env, and then omit the image-repository config entirely. I believe this will have the effect you are after.
For the second issue, I'll defer to @toolmantim.

@lox Thanks for the insight. Regarding the first issue, any tips on using the plugin for multiple images in a single pipeline? My real pipeline actually has 3 image builds (e.g. frontend, backend, etc). I suppose I can build multiple pipelines, but I'm wondering if there are easier alternatives, especially because at deploy-time there are dependencies amongst the 3 images (so it's easier to think about it as a single pipeline).

Do you mean how would you vary the image repository for different steps based on a common repository prefix?

I mean, I actually have 3 completely different ECR repos and I'm trying to build the 3 images in one pipeline, like so:
steps:
  - name: ":docker: build web"
    agents:
      queue: builders
    plugins:
      docker-compose-buildkite-plugin:
        build: web
        config:
          - docker-compose.yml
          - docker-compose.ci.yml
        image-repository: my_ecr.dkr.ecr.us-east-1.amazonaws.com/REPO_A
        image-name: "${BUILDKITE_COMMIT}"

  - name: ":docker: build client"
    agents:
      queue: builders
    plugins:
      docker-compose-buildkite-plugin:
        build: client
        config:
          - docker-compose.yml
          - docker-compose.ci.yml
        image-repository: my_ecr.dkr.ecr.us-east-1.amazonaws.com/REPO_B

  - name: ":docker: build nginx"
    agents:
      queue: builders
    plugins:
      docker-compose-buildkite-plugin:
        build: nginx
        config:
          - docker-compose.yml
          - docker-compose.ci.yml
        image-repository: my_ecr.dkr.ecr.us-east-1.amazonaws.com/REPO_C

  - wait

As I understand it, setting up a single BUILDKITE_PLUGIN_DOCKER_COMPOSE_IMAGE_REPOSITORY env var wouldn't work with this pipeline.

Ah yup, right. You could pass in an env of ECR_REPO=my_ecr.dkr.ecr.us-east-1.amazonaws.com to your builder step and then use variable interpolation like in your first example.

@lox sorry, I don't completely follow. Where should I set ECR_REPO?

@dalberto I think @lox means in your buildkite-agent pipeline upload step defined in the Buildkite web UI, in the environment variables section, you could set ECR_REPO=my_ecr.dkr.ecr.us-east-1.amazonaws.com. Then in your pipeline YAML you'll be able to do this:
steps:
  - name: ":docker: build web"
    agents:
      queue: builders
    plugins:
      docker-compose-buildkite-plugin:
        build: web
        config:
          - docker-compose.yml
          - docker-compose.ci.yml
        image-repository: "${ECR_REPO}/REPO_A"
        image-name: "${BUILDKITE_COMMIT}"

As for not being able to use BUILDKITE_COMMIT in your pipeline.yml file for HEAD builds, that should be considered a bug I think. I just filed buildkite/agent#456 for you. Some workaround ideas in the meantime:

Make sure the buildkite-agent pipeline upload command isn't the first step in the pipeline. For example, you could add a echo 'Finding out commit' and a wait before the pipeline upload
Calculate the git commit yourself?

@toolmantim Thanks for the clarification. This makes sense. I will define interpolated variables via the UI.


bugfix: KerberosTime throws ParseException if times with fractions ar…

…e found in directory
The class "org.apache.directory.shared.kerberos.KerberosTime" states that the time used never uses fractions. The implementation follows this assumption but the assumption is not right. Kerberos uses generalized time (RFC 4517) which can use fractions.
The consequence of the wrong assumption is that a ParseException is thrown if I use for example the Kerberos implementation kerby to generate principals which can have fractions.
In my changes I used the generalized time implementation that is already available in the LDAP client implementation: "org.apache.directory.api.util.GeneralizedTime". I tried to change as few as possible. Therefore I dropped the fractions in internal handling as the old class did but I made it possible that the class now is able to parse Kerberos time that has been written by other tools which can use fractions.

Fix merged by @elecharny


Don't wait for user input

Hi, this script worked fine but after this lines of codes was added, my script is waiting to confirm manually and I can't do that because it's running automatically on cron job, how can be always confirmed by default? I added 1, -a, or -A at the end of line but no go
/etc/dns/cf-dns.sh -d example com -t AAAA -n mail -c $ipv6 -l 300 -x n 1 -a -A
                    read -p "Type $(for((x=1;x<=$i;++x)); do printf "'%s', " $x; done | rev | cut -c3- | sed 's/ ,/ ro /' | rev) to update an existing record, 'A' to add a new record or 'Q' to quit without changes and then press enter: " ANSWER
                    case $ANSWER in
                        [1-$i])
                            DNS_ID=$(sed -n $ANSWER'p' < $TMPFILE | cut -d ',' -f1 | cut -d ':' -f2);
                            break;;
                        [aA])
                            unset DNS_ID;
                            break;;
                        [qQ])
                            exit
                            ;;
                        *)
    #                        echo "Please enter a valid option."
                            ;;
                    esac
                done```

@TeHashX
User interaction is required because of the way the script finds matching DNS records. See How the Script Works. In short, when using the script to add a new DNS record or update an existing DNS record the script may be unsure if it needs to add or update.
A possible work-around is to have 2 cron jobs. The first to delete an existing DNS record  rather than update it (-Z for delete, -a to suppress the prompt asking to confirm deletion):
/etc/dns/cf-dns.sh -d example com -t AAAA -n mail -Z -a
The second to add a new DNS record:
/etc/dns/cf-dns.sh -d example com -t AAAA -n mail -c $ipv6 -l 300 -x n
Regards, Steve.

@TeHashX use yes
https://github.com/tech-otaku/cloudflare-dns/issues/7#issuecomment-1958841566


Need your approval for derived work / copyrights check

Lukas, I would like to re-use your work in the form of the modified sources. My library goal is to provide true blocking / IO-bound CompletionStage implementations these are cancellable - i.e. corresponding blocking code may be interrupted. Unfortunately, I can't re-use your code in the binary form -- my tasks requires different execution model. Believe me, I tried my best to extend your classes but give up and re-did core functionality my way, but using your design as a blueprint. So my questions are:
First, and foremost, can you get your explicit permit for this?
Second, is the following copyright notice is sufficient in the related files:
CallbackRegistry.java - CallbackRegistry in your project
PromiseAdapter.java - CompletionStageAdapter in your project
AbstractCompletableTask.java - SimpleCompletionStage in your project
Or please provide your version of the header for the aforementioned files.

Hi, no problem, it's licensed under Apache 2 which is quite permissive. I am quite happy that it's useful so feel free to use it however you wish.

Thank you!


Add Flow to all Gestalt test files

Adds flow type checking to all gestalt Jest test files and fixes any errors that Flow uncovered.

Deploy preview for gestalt ready!
Built with commit 6bfe6df47072b348a9cbb4d5ac06e8b8f6acd332
https://deploy-preview-184--gestalt.netlify.com

Deploy preview for gestalt ready!
Built with commit 3dae7dfb0c1c129b592b6ffba34fe41155f363eb
https://deploy-preview-184--gestalt.netlify.com


Add Bengali language translation i18n

Is your feature request related to a problem? Please describe.
Currently there is only English and Hindi version of i18n available for the simulator
Describe the solution you'd like
Also add support for Bengali with i18n
Describe alternatives you've considered
Suggestions are welcome
Additional context

Are you working on this? (Yes)

@Arnabdaz I also want to add Marathi and Gujarati language shall I go ahead?

@Arnabdaz @DhairyaMajmudar I like the idea of more languages support by Dhairya. I also want to add Telugu and Malayalam languages support. This will help students from south india. So shall I go ahead ?

i think we would be having something similar to https://www.transifex.com/ we can discuss regarding the same on circuitverse slack channel


Bower.json should be at root level folder not inside src

Is such a pain to cd in src do bower install then cd out of there again.
With a .bowerrc file at root level we can specify it to install the bower plugins in the src folder as well but then its more convenient to both install npm packages as well as bower packages in the root level folder.

Good Idea!


Let user decide logging.properties level

Problem
The project keeper rewrites the level of logging.properties to ALL:
java.util.logging.ConsoleHandler.level=ALL
com.exasol.level=ALL
Sometimes we want to have another level there. It would be nice if the keeper doesn't rewrite them.

:+1:

Not sure if it is a good idea to change this. This file enforces ALL log messages so that in the test all closures are captured by jacoco. As far as I can see it would be good to have this for all projects.
Maybe you could simply use a diffrent file for testing with UI?
Or is there a specific reason why you need a different config?

I think I mixed that up with the messages the testcontainer produces. I always set those back to info, since except for debugging all they produce is clutter. And those have no impact on test coverage.
I agree with your statement about test coverage for regular log messages our code produces. Which are the ones in question in this issue.


Add ColorAnimationExtensions

Documentation added for .NET MAUI Community Toolkit proposals:

[Proposal] ColorAnimationExtensions https://github.com/CommunityToolkit/Maui/issues/88

Docs Build status updates of commit c59c20b:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

docs/maui/alerts/index.md
:x:Error

Details

docs/maui/extensions/index.md
:x:Error

Details

docs/maui/views/index.md
:x:Error

Details

docs/maui/alerts/index.md

Line 12, Column 1: [Error: include-not-found] Invalid include link: 'includes/preview-note.md'.

docs/maui/extensions/index.md

Line 12, Column 1: [Error: include-not-found] Invalid include link: 'includes/preview-note.md'.

docs/maui/views/index.md

Line 10, Column 1: [Error: include-not-found] Invalid include link: 'includes/preview-note.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit a42bbf3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/maui/TOC.yml
:white_check_mark:Succeeded
View

docs/maui/alerts/index.md
:white_check_mark:Succeeded
View

docs/maui/behaviors/index.md
:white_check_mark:Succeeded
View

docs/maui/extensions/color-animation-extensions.md
:white_check_mark:Succeeded
View

docs/maui/extensions/index.md
:white_check_mark:Succeeded
View

docs/maui/views/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

PRMerger Results

Issue
Description

Added File(s)
This PR contains added files. New files require human review.

Yaml File(s)
This PR includes changes to .yml file(s) owned by another author.

File Change Percent
This PR contains file(s) with more than 20% file change.

Index File
This PR contains a change to the index file.

Docs Build status updates of commit 1b0e84e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/maui/TOC.yml
:white_check_mark:Succeeded
View

docs/maui/alerts/index.md
:white_check_mark:Succeeded
View

docs/maui/behaviors/index.md
:white_check_mark:Succeeded
View

docs/maui/extensions/color-animation-extensions.md
:white_check_mark:Succeeded
View

docs/maui/extensions/index.md
:white_check_mark:Succeeded
View

docs/maui/views/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

PRMerger Results

Issue
Description

Added File(s)
This PR contains added files. New files require human review.

Yaml File(s)
This PR includes changes to .yml file(s) owned by another author.

File Change Percent
This PR contains file(s) with more than 20% file change.

Index File
This PR contains a change to the index file.

Should you include a little note about adding the right using statement to use this extension method?  That is always the hard part about extension methods I feel.

Docs Build status updates of commit 6c1b5ed:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/maui/TOC.yml
:white_check_mark:Succeeded
View

docs/maui/alerts/index.md
:white_check_mark:Succeeded
View

docs/maui/behaviors/index.md
:white_check_mark:Succeeded
View

docs/maui/extensions/color-animation-extensions.md
:white_check_mark:Succeeded
View

docs/maui/extensions/index.md
:white_check_mark:Succeeded
View

docs/maui/views/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Should you include a little note about adding the right using statement to use this extension method? That is always the hard part about extension methods I feel.

Good call! I have added something

Docs Build status updates of commit 4990fc6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/maui/TOC.yml
:white_check_mark:Succeeded
View

docs/maui/alerts/index.md
:white_check_mark:Succeeded
View

docs/maui/behaviors/index.md
:white_check_mark:Succeeded
View

docs/maui/extensions/color-animation-extensions.md
:white_check_mark:Succeeded
View

docs/maui/extensions/index.md
:white_check_mark:Succeeded
View

docs/maui/views/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

PRMerger Results

Issue
Description

Added File(s)
This PR contains added files. New files require human review.

Yaml File(s)
This PR includes changes to .yml file(s) owned by another author.

File Change Percent
This PR contains file(s) with more than 20% file change.

Index File
This PR contains a change to the index file.


@vlsav, thanks for reporting this issue! Have you tried running conda install gcc_linux-64 gxx_linux-64 (as suggested)?

@vlsav, thanks for reporting this issue! Have you tried running conda install gcc_linux-64 gxx_linux-64 (as suggested)?
Originally posted by @tuelwer in https://github.com/pymatting/pymatting/issues/37#issuecomment-731645867

I have tried conda install gcc_linux-64 gxx_linux-64，but i still cant import pymattting and report the sanme info

Does this code also fail? If yes, then it is an issue with the Numba library and you can report it here: https://github.com/numba/numba/issues
from numba.pycc import CC

cc = CC("my_module")

# Produce useful error message (cc.verbose does not)
cc._toolchain._compiler.verbose = True

@cc.export("foo", "f8(f8)")
def foo(x):
    return 2.0 * x

cc.compile()

from my_module import foo

# Should print "2.0"
print(foo(1.0))

I tried installing PyMatting with the latest Fedora docker image and the following steps worked:
sudo dnf -y update
sudo dnf -y install gcc-c++ python3-pip python3-devel
pip install pymatting
python -c 'import pymatting'

I am closing this issue since there have not been any new comments, so I guess it is solved. If not, feel free to comment and I'll reopen this issue.


feat(model): #14 pendulum

[x] Pendulum

[x] Add package scipy
[x] Module pendulum.py
[x] Documentation

[x] Tests
[x] Tutorial
[ ] PR review
[ ] changelog and bump version via commitizen

@emptymalei could you help me check poetry run pytest on mac?

poetry run pytest

Exception has occurred: AssertionError
X and Y are not equal to 32 ULP (max is 33)
  File "/Users/leima/git/github/kausalflow/hamiltonian_flow/tests/test_models/test_pendulum.py", line 57, in test_transf
    assert_array_almost_equal_nulp(theta_terms, sin_u, 32)
AssertionError: X and Y are not equal to 32 ULP (max is 33)

I think assert_allclose is easier to interpret. Spacing is way too fundamental for a test like ours.

PR Preview Action v1.4.7
🚀 Deployed preview to https://kausalflow.github.io/hamilflow/pr-preview/pr-22/
on branch gh-pages at 2024-03-20 22:00 UTC

Looks like the rendered tutorial is a bit off in formating.
https://kausalflow.com/hamilflow/pr-preview/pr-22/tutorials/pendulum/
Maybe it is related to the jupytext plugin in mkdocs. Will investigate later.

I think the physics makes sense. We can call it a go once we resolves the comments.
Supporting Experiments
I tested a few initial conditions and compared to a naive cos curve. The results make sense.

In the above figure, naive is a cosine curve with the corresponding naive frequency, small, medium, and large represents different initial angles.
For small initial angles, the curves are almost the same as a cosine curve. This is what we expected since the force that is responsible for the pendulum to restore to its original position is almost a harmonic oscillator. For larger initial angles, medium and large, we observe increased deviations from the naive cosine curve. This also matches our expectations due to over estimation of restoring force in the naive case.


Publish package:web

.

[x] I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

See our contributor guide for general expectations for PRs.
Larger or significant changes should be discussed in an issue before creating a PR.
Contributions to our repos should follow the Dart style guide and use dart format.
Most changes should add an entry to the changelog and may need to rev the pubspec package version.
Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

what's our story here, friends? We've made a few changes since this PR went out.

what's our story here, friends? We've made a few changes since this PR went out.

Forgot about this! Thanks for the ping.

It took me a little while for some of the latest changes to roll into Flutter/google3 due to the monorepo, but that's done. A couple PRs opened up in the interim that I'm trying to land before publishing. Most of them have landed, but I'd ideally like to land https://github.com/dart-lang/web/pull/291 (just verifying some testing), update g3 (this should be trivial), and then publish sometime tomorrow/Wednesday. If it's really important we publish this ASAP, I can publish another minor release later.

@srujzs – I think it's cool for you to land


Remove BULLETTRAIN_DIR_CONTEXT_SHOW since there is a CONTEXT segment

Also remove an extra space in go segment ("go 1.7" instead of "go  1.7")

I use this particular segment as it can be copied directly to ssh/scp. Why are we removing it?

As a matter of fact I think the recent attempts at refactoring/cleaning up the code base are a step backwards rather than forwards. I vote we stop trying to fix what isn't broken and focus on implementing new functionality rather than removing features.

I updated to latest version and found duplicates between "context" segment and "dir_context" in "dir" segment.
Good call on copying to scp.


Blog post GraphQL & OpenTelemetry

Hi! I'm the author of this blog post about OpenTelemetry and GraphQL: https://tyk.io/blog/observing-graphql-errors-with-opentelemetry/
I'd like to submit it to be published on the opentelemetry blog.
Would that be ok? Happy to work on the pull request if so.
thanks in advance!
Sonja

Hey @SonjaChevre,
thanks for checking in before raising a PR for the blog post. It's good to discuss this first. We had a blog post around GraphQL in the past (https://opentelemetry.io/blog/2023/end-user-q-and-a-01/) already, but in general I don't see an issue with picking this topic up once again.
Reading through your blog post, I stumbled upon 2 things:
First:

Unfortunately, when using the GraphQL instrumentation library for node.js, GraphQL errors are not reported automatically. If you look at the distributed trace for that transaction, it doesn’t contain any information about that error.

I would assume that this is something the OpenTelemetry JS community is able to fix upstream, have you checked if there is an open issue with https://github.com/open-telemetry/opentelemetry-js-contrib/ to fix this? If not, please raise one and maybe even provide a PR for it?
Second:

Lucky for us, the OpenTelemetry projects make it very easy to generate RED metrics from OpenTelemetry traces by configuring the span metrics connector on the OpenTelemetry collector.

I don't see any configuration for that in your blog post, can you share them please? I am also curious what is special around GraphQL in this context?

hey @svrnm - thanks for the quick answer!
First:
about the GraphQL errors not being reported, I thought this might need to be discussed at the semantic conventions level and already opened an issue to get better semantic conventions for GraphQL here: https://github.com/open-telemetry/semantic-conventions/issues/182
Any recommendation from your side? Happy to enter something specific for the javascript instrumentation.
Second:

I don't see any configuration for that in your blog post, can you share them please?

Happy to add the configuration for that in the blog post version to be published on the OTel blog.

I am also curious what is special around GraphQL in this context?

In that specific example, there is nothing that special - just a reminder for people that are unaware of the span metrics connector that it is very helpful to generate metrics from your traces. As I do find most people that get started with OTel don't know about it.
But this deserves a follow up for GraphQL (maybe another blog post): it is not enough to generate RED metrics for the GraphQL server. As a GraphQL server is like a database, its performance depends highly on the queries that user are sending to you. Some users might overload your server by sending them "bad" queries. So it might be more helpful to monitor RED metrics based on your queries (if small number of different queries - because it is only been used by 1 internal application), by API client (if your GraphQL endpoint is available externally) or even by resolver (function that determines how to retrieve the data for a specific field in a GraphQL query and maps it to the corresponding data source).
Actually this topic was mentioned today on the cncf slack in the opentelemetry channel: https://cloud-native.slack.com/archives/CJFCJHG4Q/p1689916250365829

hey @svrnm - thanks for the quick answer!
First:
about the GraphQL errors not being reported, I thought this might need to be discussed at the semantic conventions level and already opened an issue to get better semantic conventions for GraphQL here: open-telemetry/semantic-conventions#182
Any recommendation from your side? Happy to enter something specific for the javascript instrumentation.

Since the main use case in the blog post is error reporting, I would suggest that you check how far you get with existing semantics for errors&exceptions:
https://github.com/open-telemetry/semantic-conventions/blob/main/docs/exceptions/README.md
Apply those changes to the Node.JS implementation and bring it to the JavaScript community.

We have only tried the Node.js instrumentation so far, but noticed that this library doesn’t respect the semantic conventions.

Apparently there is also some work that needs to be done here.
Don't get me wrong, the current blog post on the Tyk website adds values to end-users of OpenTelemetry and this is appreciated, as it calls out a deficit with the current implementation and how you can fix it yourself easily. But since this is the OpenTelemetry blog by the OpenTelemetry community we should rather fix this deficit and then have a blog post about what otel can do for GraphQL.

Second:

I don't see any configuration for that in your blog post, can you share them please?

Happy to add the configuration for that in the blog post version to be published on the OTel blog.

Thanks.

I am also curious what is special around GraphQL in this context?

In that specific example, there is nothing that special - just a reminder for people that are unaware of the span metrics connector that it is very helpful to generate metrics from your traces. As I do find most people that get started with OTel don't know about it.

Fair point, but then it might be worthwhile to put it into the collector documentation somewhere.

But this deserves a follow up for GraphQL (maybe another blog post): it is not enough to generate RED metrics for the GraphQL server. As a GraphQL server is like a database, its performance depends highly on the queries that user are sending to you. Some users might overload your server by sending them "bad" queries. So it might be more helpful to monitor RED metrics based on your queries (if small number of different queries - because it is only been used by 1 internal application), by API client (if your GraphQL endpoint is available externally) or even by resolver (function that determines how to retrieve the data for a specific field in a GraphQL query and maps it to the corresponding data source).
Actually this topic was mentioned today on the cncf slack in the opentelemetry channel: cloud-native.slack.com/archives/CJFCJHG4Q/p1689916250365829

Why not have all of that in one blog post? The current blog post is very sparse and what you outlined here is what I would find interesting to learn: all those things that are special for GraphQL.

All good feedback, appreciate the thoughtful comments and explanations.
The reason the blog post is very sparse is because most of our users come from the API/GraphQL world and OTel is still very new to them. Don't want to overwhelm them.
But I get your point that OTel blog post readers are a different audience and will have different expectations.
Let me sit on your feedback for a couple of days and come back with a new proposal.

@SonjaChevre I will close this issue now, feel free to open a new one or bring a PR with a blog post if you still want to continue on this topic


Improve CI infrastructure

This PR improves a bit our CI infrastructure, adds Makefile with the most common operations and enforces proper style-guide with JuliaFormatter.
Thanks to @Nimrais

Codecov Report

Merging #111 (59c5ca1) into master (b4445a4) will decrease coverage by 0.72%.
The diff coverage is 71.74%.

:exclamation: Current head 59c5ca1 differs from pull request most recent head 9504235. Consider uploading reports for the commit 9504235 to get more accurate results

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
- Coverage   74.18%   73.45%   -0.73%
==========================================
  Files         175      175
  Lines        6019     5963      -56
==========================================
- Hits         4465     4380      -85
- Misses       1554     1583      +29

Impacted Files
Coverage Δ

src/ReactiveMP.jl
50.00% <ø> (ø)

src/approximations/gausslaguerre.jl
0.00% <0.00%> (ø)

src/approximations/importance.jl
0.00% <0.00%> (ø)

src/approximations/laplace.jl
0.00% <0.00%> (ø)

src/approximations/optimizers/adam.jl
0.00% <0.00%> (ø)

src/approximations/sphericalradial.jl
0.00% <0.00%> (ø)

src/constraints/form/form_fixed_marginal.jl
0.00% <0.00%> (ø)

src/constraints/prod/prod.jl
0.00% <ø> (ø)

src/constraints/prod/prod_analytical.jl
40.00% <0.00%> (ø)

src/distributions/gamma_shape_likelihood.jl
0.00% <0.00%> (ø)

... and 219 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4445a4...9504235. Read the comment docs.


fix: types to support canvas or image ref

Previously the types could not be consumed properly in our application. The return type wanted to be the same as the return type of useRef and accept the generics of either HTMLCanvasElement or HTMLImageElement.
This PR makes that fix so that the proper return type is given, making the TypeScript compiler happy. 🍍

@Bunlong Would you be willing to review this?

@jaredscheib I just see it. Okay, I will merge it as soon as possible. I will let you know when it done. Thanks!

Thanks, @Bunlong. I can merge  it if it becomes approved after you review it. Thank you again!

Thanks @Bunlong, but actually I'm unable to merge from my end. Likely due to repository permissions. If you'd like to enable that, I'd be happy to merge!

@jaredscheib you are invited as collaborator pls confirm.

Done -- thank you, @Bunlong! 🙏🏼  Feel free to remove me as collaborator if you'd like :) ありがとうございました！ 🍍

@jaredscheib it's fine. I keep you as collaborator so you can improve it any time.  ありがとうございました :bowing_man:


The IDE shows error

Hello! I am using PHPStorm IDE and installed your library. Now it shows error on the blade page, the doctype is underlined by red:
@use(App\Models\Menu)

<!DOCTYPE html>
...

Also, when i write smth like:
{{ Menu::buildMenu($menu) }}
in the code below, there is no smart help of IDE as if i write the full path:
{{ \App\Models\Menu::buildMenu($menu) }}
in the 2nd before method is called - ide shows a list of possible methods.
Can this problems be somehow fixed?
Thanks.

Not directly here, it would need to be a PhpStorm plugin. I will take a look at what's possible when I get some time


Remove unnecessary build scripts.

Stick with ipk_create.sh and ipk_deploy.sh only.

Did this while working on Issue #61 but still need to check that nothing was broken when building for SEPP environment.


support for spring cloud dalston?

Hi guys, do you know if 0.x would also work with Dalston? Or is Edgeware a "hard" requirement? Thanks!

I don't see why it wouldn't as there are no explicit Edgware features used. However, I have never used or tested it with Dalston. Please give it a go and let me know if it works.


Update lazy docs (add link to upstreamed version)

PyTorch 1.8 is out, and some Lazy modules are now part of the official PyTorch release!
This PR adds links to the upstream docs.
Also fixes the issue that LazyBatchNorm is not documented.
(FYI, it is already upstreamed and will be released as PyTorch 1.9. https://github.com/pytorch/pytorch/pull/51862)

/test

Test passed.


Client Error on network_access_policy_set module with nested conditions due to missing dictionaryName

When creating a Policy Set with nested conditions, TF throws a Client Error due to missing dictionaryName values. The values exist in the YAML, but the terraform plan does not show the 'dictionary_name' or 'dictionary_value' attributes.
Depending on the dictionary and condition being configured, the dictionary_value is not always null.
Example YAML code
ise:
  network_access:
    policy_sets:
      - name: Wired MM
        description: Wired Monitor Mode
        condition:
          type: ConditionAndBlock
          children:
          - type: ConditionAttributes
            dictionary_name: Radius
            attribute_name: NAS-Port-Type
            operator: equals
            dictionary_value: null
            attribute_value: Ethernet
          - type: ConditionAttributes
            dictionary_name: DEVICE
            attribute_name: Deployment Stage
            operator: equals
            dictionary_value: null
            attribute_value: Deployment Stage#Monitor Mode
        service_name: MAB_Dot1x

Plan & Client Error
Terraform will perform the following actions:

  # module.ise.ise_network_access_policy_set.network_access_policy_set_0["Wired MM"] will be created
  + resource "ise_network_access_policy_set" "network_access_policy_set_0" {
      + children            = [
          + {
              + attribute_name  = "NAS-Port-Type"
              + attribute_value = "Ethernet"
              + condition_type  = "ConditionAttributes"
              + is_negate       = false
              + operator        = "equals"
            },
          + {
              + attribute_name  = "Deployment Stage"
              + attribute_value = "Deployment Stage#Monitor Mode"
              + condition_type  = "ConditionAttributes"
              + is_negate       = false
              + operator        = "equals"
            },
        ]
      + condition_is_negate = false
      + condition_type      = "ConditionAndBlock"
      + description         = "Wired Monitor Mode"
      + id                  = (known after apply)
      + is_proxy            = false
      + name                = "Wired MM"
      + service_name        = "MAB_Dot1x"
      + state               = "enabled"
    }

Plan: 1 to add, 0 to change, 0 to destroy.
module.ise.ise_network_access_policy_set.network_access_policy_set_0["Wired MM"]: Creating...
module.ise.ise_network_access_policy_set.network_access_policy_set_0["Wired MM"]: Still creating... [10s elapsed]
module.ise.ise_network_access_policy_set.network_access_policy_set_0["Wired MM"]: Still creating... [20s elapsed]
╷
│ Error: Client Error
│
│   with module.ise.ise_network_access_policy_set.network_access_policy_set_0["Wired MM"],
│   on .terraform/modules/ise/ise_network_access.tf line 311, in resource "ise_network_access_policy_set" "network_access_policy_set_0":
│  311: resource "ise_network_access_policy_set" "network_access_policy_set_0" {
│
│ Failed to configure object (POST), got error: HTTP Request failed: StatusCode 400, Message: , {
│   "message" : "condition.children[1].dictionaryName, must not be null, condition.children[0].dictionaryName, must not be null",
│   "code" : 400
│ }

Example TF code
resource "ise_network_access_policy_set" "ps_wired_mm" {
  name                = var.ps_wired_mm_name
  description         = "Wired Monitor Mode"
  rank                = 0
  service_name        = ise_allowed_protocols.mab_dot1x.name
  state               = "enabled"
  is_proxy            = false
  condition_is_negate = false
  condition_type      = "ConditionAndBlock"
  children = [
    {
      condition_type  = "ConditionAttributes"
      is_negate       = false
      dictionary_name = "Radius"
      attribute_name  = "NAS-Port-Type"
      operator        = "equals"
      attribute_value = "Ethernet"
    },
    {
      condition_type  = "ConditionAttributes"
      is_negate       = false
      dictionary_name = "DEVICE"
      attribute_name  = ise_network_device_group.ndg_deployment_stage.root_group
      operator        = "equals"
      attribute_value = "Deployment Stage#Monitor Mode"
    },
  ]
}

When testing the Device Admin policy set config, I found the example of defining the dictionary_name in the attribute_name. I confirmed that this method works in my Network Access Policy Set block.
The documentation should make it clear how to define these settings.
Example updated code
    policy_sets:
      - name: Wired MM
        description: Wired Monitor Mode
        condition:
          type: ConditionAndBlock
          children:
          - type: ConditionAttributes
            attribute_name: Radius:NAS-Port-Type
            operator: equals
            attribute_value: Ethernet
          - type: ConditionAttributes
            attribute_name: DEVICE:Deployment Stage
            operator: equals
            attribute_value: Deployment Stage#Monitor Mode
        service_name: MAB_Dot1x

Confirmed fixed with the separation of the dictionary_name attribute in the latest branch


Need support for SecurityGroupRule

What resource do you need?
SecurityGroupRule
https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_SecurityGroupRule.html
What is your use case?
There doesn't appear to be a way to specify a SecurityGroup which has egress/ingress rules that reference itself.
With the following Composition.spec.resources.base[0]:
  - base:
       apiVersion: ec2.aws.crossplane.io/v1beta1
        kind: SecurityGroup
        metadata: {}
        spec:
          forProvider:
            description: placeholder
            egress:
              - ipProtocol: tcp
                fromPort: 6380
                toPort: 6380
                userIdGroupPairs:
                - description: Allowing Cache port Outbound Access
                  groupIdSelector:
                    matchControllerRef: true
            groupName: placeholder
            ingress:
              - ipProtocol: tcp
                fromPort: 6380
                toPort: 6380
                userIdGroupPairs:
                - description: Allowing Cache port Inbound Access
                  groupIdSelector:
                    matchControllerRef: true
            region: placeholder
            tags: []
          providerConfigRef:
            name: placeholder
          writeConnectionSecretToRef:
            name: placeholder
            namespace: placeholder
          deletionPolicy: Delete

I'm getting an error where the groupId is being filled out with the groupName instead of the groupId:
  Warning  CannotObserveExternalResource  9s (x11 over 51s)  managed/securitygroup.ec2.aws.crossplane.io  failed to describe SecurityGroup: api error InvalidGroupId.Malformed: Invalid id: "crossplane-poc-rediscluster" (expecting "sg-...")

Full describe:
lekonia:aws-provider{(ff21156...)} branche$ kubectl describe securitygroup crossplane-poc-7ccrk-ns5zx
Name:         crossplane-poc-7ccrk-ns5zx
Namespace:
Labels:       crossplane.io/claim-name=crossplane-poc
              crossplane.io/claim-namespace=branche-crossplane-poc
              crossplane.io/composite=crossplane-poc-7ccrk
Annotations:  crossplane.io/external-name: crossplane-poc-rediscluster
API Version:  ec2.aws.crossplane.io/v1beta1
Kind:         SecurityGroup
Metadata:
  Creation Timestamp:  2022-05-20T22:09:43Z
  Generate Name:       crossplane-poc-7ccrk-
  Generation:          12
  Managed Fields:
    API Version:  ec2.aws.crossplane.io/v1beta1
    Fields Type:  FieldsV1
    fieldsV1:
      f:metadata:
        f:annotations:
          .:
          f:crossplane.io/external-name:
        f:generateName:
        f:labels:
          .:
          f:crossplane.io/claim-name:
          f:crossplane.io/claim-namespace:
          f:crossplane.io/composite:
        f:ownerReferences:
          .:
          k:{"uid":"e83e4115-c3a4-4ee3-a4c5-bc76eafee546"}:
            .:
            f:apiVersion:
            f:controller:
            f:kind:
            f:name:
            f:uid:
      f:spec:
        .:
        f:deletionPolicy:
        f:forProvider:
          .:
          f:description:
          f:groupName:
          f:region:
        f:providerConfigRef:
          .:
          f:name:
        f:writeConnectionSecretToRef:
          .:
          f:name:
          f:namespace:
    Manager:      crossplane
    Operation:    Update
    Time:         2022-05-20T22:10:25Z
    API Version:  ec2.aws.crossplane.io/v1beta1
    Fields Type:  FieldsV1
    fieldsV1:
      f:spec:
        f:forProvider:
          f:egress:
          f:ingress:
      f:status:
        .:
        f:atProvider:
          .:
          f:ownerId:
          f:securityGroupID:
        f:conditions:
    Manager:    crossplane-aws-provider
    Operation:  Update
    Time:       2022-05-20T22:10:25Z
  Owner References:
    API Version:     awsblueprints.io/v1alpha1
    Controller:      true
    Kind:            XRedisCluster2
    Name:            crossplane-poc-7ccrk
    UID:             e83e4115-c3a4-4ee3-a4c5-bc76eafee546
  Resource Version:  451258114
  UID:               f3d15440-7580-45ef-9e30-8c5efb13676e
Spec:
  Deletion Policy:  Delete
  For Provider:
    Description:  SecurityGroup for crossplane-poc RedisCluster
    Egress:
      From Port:    6380
      Ip Protocol:  tcp
      To Port:      6380
      User Id Group Pairs:
        Description:  Allowing Cache port Outbound Access
        Group Id:     crossplane-poc-rediscluster
        Group Id Ref:
          Name:  crossplane-poc-7ccrk-ns5zx
        Group Id Selector:
          Match Controller Ref:  true
    Group Name:                  crossplane-poc-rediscluster
    Ingress:
      From Port:    6380
      Ip Protocol:  tcp
      To Port:      6380
      User Id Group Pairs:
        Description:  Allowing Cache port Inbound Access
        Group Id:     crossplane-poc-rediscluster
        Group Id Ref:
          Name:  crossplane-poc-7ccrk-ns5zx
        Group Id Selector:
          Match Controller Ref:  true
    Region:                      us-east-1
  Provider Config Ref:
    Name:  aws-provider
  Write Connection Secret To Ref:
    Name:       crossplane-poc-rediscluster-sg
    Namespace:  branche-crossplane-poc
Status:
  At Provider:
    Owner Id:
    Security Group ID:
  Conditions:
    Last Transition Time:  2022-05-20T22:09:46Z
    Message:               observe failed: failed to describe SecurityGroup: api error InvalidGroupId.Malformed: Invalid id: "crossplane-poc-rediscluster" (expecting "sg-...")
    Reason:                ReconcileError
    Status:                False
    Type:                  Synced
Events:
  Type     Reason                         Age                From                                         Message
  ----     ------                         ----               ----                                         -------
  Warning  CannotObserveExternalResource  9s (x11 over 51s)  managed/securitygroup.ec2.aws.crossplane.io  failed to describe SecurityGroup: api error InvalidGroupId.Malformed: Invalid id: "crossplane-poc-rediscluster" (expecting "sg-...")

This appears to be because the groupId is not fully filled out in the resource before calling to the API (and correctly, because it can't be from what I can tell).

In our CloudFormation templates, it appears that we are creating a SecurityGroup separate from the SecurityGroupRules:
    "Resources": {
...
        "MicroSgsAckSystemRdsRule4fca11743abee7038e08e969a481b39c": {
            "Properties": {
                "Description": "proteus-aws-operator Ingress",
                "FromPort": 3306,
                "GroupId": {
                    "Ref": "MicroSgsGroupAckSystemRds"
                },
                "IpProtocol": "tcp",
                "SourceSecurityGroupId": {
                    "Ref": "MicroSgsGroupAckSystemRds"
                },
                "ToPort": 3306
            },
            "Type": "AWS::EC2::SecurityGroupIngress"
        },
        "MicroSgsAckSystemRdsRulef85d29f00c6348f44a71be2b2f583ed8": {
            "Properties": {
                "Description": "proteus-aws-operator Egress",
                "DestinationSecurityGroupId": {
                    "Ref": "MicroSgsGroupAckSystemRds"
                },
                "FromPort": 3306,
                "GroupId": {
                    "Ref": "MicroSgsGroupAckSystemRds"
                },
                "IpProtocol": "tcp",
                "ToPort": 3306
            },
            "Type": "AWS::EC2::SecurityGroupEgress"
        },
...
        "MicroSgsGroupAckSystemRds": {
            "Properties": {
                "GroupDescription": "proteus-aws-operator access for RDS",
                "SecurityGroupEgress": [],
                "SecurityGroupIngress": [],
                "Tags": [
                    {
                        "Key": "Name",
                        "Value": "micro-preview-useast1-sgs-ack-system-rds"
                    }
                ],
                "VpcId": {
                    "Ref": "VpcId"
                }
            },
            "Type": "AWS::EC2::SecurityGroup"
        },

Would you be willing to contribute it using code generator?
I would likely need some help to get the groupIdSelector.matchControllerRef working properly on the SecurityGroupRule code generation.

FYI there's a PR which will support self-referencing groups without SecurityGroupRule objects:
https://github.com/crossplane/crossplane-runtime/pull/328

I can confirm self referencing SG rules works after the pull request mentioned above.
- description: test
  groupIdSelector:
    matchControllerRef: true
    policy:
      resolution: Optional
      resolve: Always

Possible since #1361 was merged - will be included in v0.29.0 release


Eliminate compiler warnings (and code error)

Fixed a few compiler warnings.  One of these is actually a code error where the statement following the if is always executed due to the semicolon at the end of the if statement:
if(prov->propattr.properties != NULL);
 	nclistfreeall(prov->propattr.properties);

Merging into 4.6.2 release branch, will percolate into master shortly.


Allow configuration of grpc channel

Currently we allow passing in a user-constructed channel, but do not allow passing in settings to configure the channel.

Fixed - we accept a grpc transport config: https://github.com/googleapis/gax-php/blob/master/src/ApiCore/GapicClientTrait.php#L195