Is LuaSnip supported on FreeBSD?

The reason I ask because it fails to build - for nvim(1) does not matter if I use BSD make(1) or GNU make(1).
BSD make(1) error:

GNU make(1) error:

Regards,
vermaden

I will try to make 'gcc' link to 'gcc13' ...

Hey, could you try the non-gcc-makefile-branch?
As long as gmake is used, it should work
AFAICT for adapting to bsd-make, we'd need to maintain two makefiles, one that uses bsd-if-syntax, another with gnu-if.

Hi,
its probably not what I meant :)
using GNU make is more then OK - it would just need some 'check' to use/require gmake instead of make on FreeBSD.
IMHO its pointless to create another BSD make compatible Makefile as You already have created and tested GNU make one.

the issue is, how to invoke make. On linux & MacOS, gmake === make. On *BSD, make is bsd make, so we need to call gmake.

I am not a Makefile expert - but I was thinking about something like that.
OS := $(shell uname)

ifeq ($(OS),FreeBSD)
    MAKE=gmake
endif

Oh, I was under the impression that this is exactly what $(MAKE) is for (https://www.gnu.org/software/make/manual/html_node/MAKE-Variable.html)
Does, for example gmake install_jsregexp, not work currently?

Like I said - I am not a Makefile expert :)

:D
I'd assumed that did not work and was a bit surprised :)
Could you try if it works without any further changes on non-gcc-makefile?

Just did that.
Seems to work OK I suppose?
~/_LUA % unzip LuaSnip-non-gcc-makefile.zip

~/_LUA % ls -l
drwxr-xr-x vermaden vermaden  19 B  2024/04/02 23:05  LuaSnip-non-gcc-makefile
.rw-r--r-- vermaden vermaden 384 KB 2024/04/02 23:02  LuaSnip-non-gcc-makefile.zip

~/_LUA % cd LuaSnip-non-gcc-makefile

~/_LUA/LuaSnip-non-gcc-makefile % make
make: "/home/vermaden/_LUA/LuaSnip-non-gcc-makefile/Makefile" line 37: Invalid line type
make: "/home/vermaden/_LUA/LuaSnip-non-gcc-makefile/Makefile" line 42: Invalid line type
make: Fatal errors encountered -- cannot continue
make: stopped in /home/vermaden/_LUA/LuaSnip-non-gcc-makefile

~/_LUA/LuaSnip-non-gcc-makefile % gmake
# fetch current master and 0.7.0 (the minimum version we support) and 0.9.0
# (the minimum version for treesitter-postfix to work).
git clone --bare --depth 1 https://github.com/neovim/neovim deps/nvim_multiversion
Cloning into bare repository 'deps/nvim_multiversion'...
remote: Enumerating objects: 3533, done.
remote: Counting objects: 100% (3533/3533), done.
remote: Compressing objects: 100% (3208/3208), done.
remote: Total 3533 (delta 312), reused 1336 (delta 237), pack-reused 0
Receiving objects: 100% (3533/3533), 12.08 MiB | 603.00 KiB/s, done.
Resolving deltas: 100% (312/312), done.
git -C deps/nvim_multiversion fetch --depth 1 origin tag v0.7.0
remote: Enumerating objects: 3387, done.
remote: Counting objects: 100% (3387/3387), done.
remote: Compressing objects: 100% (1891/1891), done.
remote: Total 2001 (delta 1122), reused 357 (delta 53), pack-reused 0
Receiving objects: 100% (2001/2001), 3.77 MiB | 576.00 KiB/s, done.
Resolving deltas: 100% (1122/1122), completed with 1058 local objects.
From https://github.com/neovim/neovim
 * [new tag]         v0.7.0     -> v0.7.0
git -C deps/nvim_multiversion fetch --depth 1 origin tag v0.9.0
remote: Enumerating objects: 3361, done.
remote: Counting objects: 100% (3361/3361), done.
remote: Compressing objects: 100% (1208/1208), done.
remote: Total 1343 (delta 1091), reused 207 (delta 115), pack-reused 0
Receiving objects: 100% (1343/1343), 1.26 MiB | 323.00 KiB/s, done.
Resolving deltas: 100% (1091/1091), completed with 1049 local objects.
From https://github.com/neovim/neovim
 * [new tag]         v0.9.0     -> v0.9.0
# create one worktree for master, and one for 0.7.
# The rationale behind this is that switching from 0.7 to master (and
# vice-versa) requires a `make distclean`, and full clean build, which takes
# a lot of time.
# The most straightforward solution seems to be too keep two worktrees, one
# for master, one for 0.7, and one for 0.9 which are used for the
# respective builds/tests.
git -C deps/nvim_multiversion worktree add worktree_master master
Preparing worktree (checking out 'master')
HEAD is now at d9235ef refactor(lsp): move workspace folder logic into the client
git -C deps/nvim_multiversion worktree add worktree_0.7 v0.7.0
Preparing worktree (detached HEAD 333ba65)
HEAD is now at 333ba65 NVIM 0.7
git -C deps/nvim_multiversion worktree add worktree_0.9 v0.9.0
Preparing worktree (detached HEAD 040f145)
Updating files: 100% (3123/3123), done.
HEAD is now at 040f145 NVIM v0.9.0

~/_LUA/LuaSnip-non-gcc-makefile % ls -ltra
drwxr-xr-x vermaden vermaden   4 B  2024/04/02 23:05  ..
drwxr-xr-x vermaden vermaden   4 B  2024/04/02 23:05  .github
drwxr-xr-x vermaden vermaden   3 B  2024/04/02 23:05  Examples
drwxr-xr-x vermaden vermaden   3 B  2024/04/02 23:05  doc
drwxr-xr-x vermaden vermaden   3 B  2024/04/02 23:05  ftplugin
drwxr-xr-x vermaden vermaden   3 B  2024/04/02 23:05  lua
drwxr-xr-x vermaden vermaden   4 B  2024/04/02 23:05  plugin
drwxr-xr-x vermaden vermaden   3 B  2024/04/02 23:05  syntax
drwxr-xr-x vermaden vermaden  19 B  2024/04/02 23:05  .
drwxr-xr-x vermaden vermaden   8 B  2024/04/02 23:05  tests
drwxr-xr-x vermaden vermaden   6 B  2024/04/02 23:06  deps
.rw-r--r-- vermaden vermaden  12 KB 2024/04/01 22:52  README.md
.rw-r--r-- vermaden vermaden 3.7 KB 2024/04/01 22:52  Makefile
.rw-r--r-- vermaden vermaden  11 KB 2024/04/01 22:52  LICENSE
.rw-r--r-- vermaden vermaden 142 KB 2024/04/01 22:52  DOC.md
.rw-r--r-- vermaden vermaden   6 B  2024/04/01 22:52  .styluaignore
.rw-r--r-- vermaden vermaden 111 B  2024/04/01 22:52  .stylua.toml
.rw-r--r-- vermaden vermaden 166 B  2024/04/01 22:52  .gitmodules
.rw-r--r-- vermaden vermaden 122 B  2024/04/01 22:52  .gitignore

Looks correct so far, could you also try gmake install_jsregexp? That's the one where the compiler matters

(ping)

Oh, sorry, forgot, gonna try that in a moment.

I got that:
~/_LUA/LuaSnip-non-gcc-makefile % gmake install_jsregexp
git submodule init
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
gmake: *** [Makefile:47: jsregexp] Error 128

That was quick, thanks!
Ah, is it possible you extracted a tar of luasnips source? I think install_jsregexp needs the cloned repo, could you try that?

Sure, but please paste me here the git clone command to clone the non-gcc-makefile repo please.

Oh, yeah sure:
git clone git@github.com:L3MON4D3/LuaSnip.git && git c origin/non-gcc-makefile

A typo?
% git clone git@github.com:L3MON4D3/LuaSnip.git && git c origin/non-gcc-makefile
Cloning into 'LuaSnip'...
remote: Enumerating objects: 12925, done.
remote: Counting objects: 100% (2174/2174), done.
remote: Compressing objects: 100% (504/504), done.
remote: Total 12925 (delta 1728), reused 1866 (delta 1571), pack-reused 10751
Receiving objects: 100% (12925/12925), 7.50 MiB | 459.00 KiB/s, done.
Resolving deltas: 100% (7862/7862), done.
git: 'c' is not a git command. See 'git --help'.

The most similar commands are
        clone
        commit
        gc

Ha, srry, I have a alias setup, s/c/checkout :sweat_smile:

Thank You.
Seems it worked OK?

~/_LUA % git clone git@github.com:L3MON4D3/LuaSnip.git
Cloning into 'LuaSnip'...
remote: Enumerating objects: 12925, done.
remote: Counting objects: 100% (2174/2174), done.
remote: Compressing objects: 100% (504/504), done.
remote: Total 12925 (delta 1728), reused 1868 (delta 1571), pack-reused 10751
Receiving objects: 100% (12925/12925), 7.50 MiB | 500.00 KiB/s, done.
Resolving deltas: 100% (7862/7862), done.

~/_LUA % cd LuaSnip

~/_LUA/LuaSnip % git checkout origin/non-gcc-makefile
Note: switching to 'origin/non-gcc-makefile'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 939d52b default jsregexp-CC to system-CC.

~/_LUA/LuaSnip % ls -la
drwxr-xr-x vermaden vermaden  20 B  2024/04/16 19:58  .
drwxr-xr-x vermaden vermaden   3 B  2024/04/16 19:57  ..
drwxr-xr-x vermaden vermaden  13 B  2024/04/16 19:58  .git
drwxr-xr-x vermaden vermaden   4 B  2024/04/16 19:58  .github
drwxr-xr-x vermaden vermaden   5 B  2024/04/16 19:58  deps
drwxr-xr-x vermaden vermaden   3 B  2024/04/16 19:58  doc
drwxr-xr-x vermaden vermaden   3 B  2024/04/16 19:58  Examples
drwxr-xr-x vermaden vermaden   3 B  2024/04/16 19:58  ftplugin
drwxr-xr-x vermaden vermaden   3 B  2024/04/16 19:58  lua
drwxr-xr-x vermaden vermaden   4 B  2024/04/16 19:58  plugin
drwxr-xr-x vermaden vermaden   3 B  2024/04/16 19:58  syntax
drwxr-xr-x vermaden vermaden   8 B  2024/04/16 19:58  tests
.rw-r--r-- vermaden vermaden 122 B  2024/04/16 19:58  .gitignore
.rw-r--r-- vermaden vermaden 166 B  2024/04/16 19:58  .gitmodules
.rw-r--r-- vermaden vermaden 111 B  2024/04/16 19:58  .stylua.toml
.rw-r--r-- vermaden vermaden   6 B  2024/04/16 19:58  .styluaignore
.rw-r--r-- vermaden vermaden 142 KB 2024/04/16 19:58  DOC.md
.rw-r--r-- vermaden vermaden  11 KB 2024/04/16 19:58  LICENSE
.rw-r--r-- vermaden vermaden 3.7 KB 2024/04/16 19:58  Makefile
.rw-r--r-- vermaden vermaden  12 KB 2024/04/16 19:58  README.md

~/_LUA/LuaSnip % gmake
# fetch current master and 0.7.0 (the minimum version we support) and 0.9.0
# (the minimum version for treesitter-postfix to work).
git clone --bare --depth 1 https://github.com/neovim/neovim deps/nvim_multiversion
Cloning into bare repository 'deps/nvim_multiversion'...
remote: Enumerating objects: 3548, done.
remote: Counting objects: 100% (3548/3548), done.
remote: Compressing objects: 100% (3185/3185), done.
remote: Total 3548 (delta 343), reused 1233 (delta 275), pack-reused 0
Receiving objects: 100% (3548/3548), 12.15 MiB | 539.00 KiB/s, done.
Resolving deltas: 100% (343/343), done.
git -C deps/nvim_multiversion fetch --depth 1 origin tag v0.7.0
remote: Enumerating objects: 3635, done.
remote: Counting objects: 100% (3635/3635), done.
remote: Compressing objects: 100% (2002/2002), done.
remote: Total 2142 (delta 1225), reused 392 (delta 83), pack-reused 0
Receiving objects: 100% (2142/2142), 3.86 MiB | 883.00 KiB/s, done.
Resolving deltas: 100% (1225/1225), completed with 1129 local objects.
From https://github.com/neovim/neovim
 * [new tag]         v0.7.0     -> v0.7.0
git -C deps/nvim_multiversion fetch --depth 1 origin tag v0.9.0
remote: Enumerating objects: 3406, done.
remote: Counting objects: 100% (3406/3406), done.
remote: Compressing objects: 100% (1240/1240), done.
remote: Total 1365 (delta 1108), reused 199 (delta 105), pack-reused 0
Receiving objects: 100% (1365/1365), 1.27 MiB | 457.00 KiB/s, done.
Resolving deltas: 100% (1108/1108), completed with 1064 local objects.
From https://github.com/neovim/neovim
 * [new tag]         v0.9.0     -> v0.9.0
# create one worktree for master, and one for 0.7.
# The rationale behind this is that switching from 0.7 to master (and
# vice-versa) requires a `make distclean`, and full clean build, which takes
# a lot of time.
# The most straightforward solution seems to be too keep two worktrees, one
# for master, one for 0.7, and one for 0.9 which are used for the
# respective builds/tests.
git -C deps/nvim_multiversion worktree add worktree_master master
Preparing worktree (checking out 'master')
HEAD is now at 20b3867 feat(defaults): use ripgrep (rg) for 'grepprg' if available
git -C deps/nvim_multiversion worktree add worktree_0.7 v0.7.0
Preparing worktree (detached HEAD 333ba65)
HEAD is now at 333ba65 NVIM 0.7
git -C deps/nvim_multiversion worktree add worktree_0.9 v0.9.0
Preparing worktree (detached HEAD 040f145)
HEAD is now at 040f145 NVIM v0.9.0

~/_LUA/LuaSnip % gmake install_jsregexp
git submodule init
Submodule 'deps/jsregexp' (git@github.com:kmarius/jsregexp) registered for path 'deps/jsregexp'
Submodule 'deps/jsregexp005' (git@github.com:kmarius/jsregexp) registered for path 'deps/jsregexp005'
git submodule update
Cloning into '/home/vermaden/_LUA/LuaSnip/deps/jsregexp'...
Cloning into '/home/vermaden/_LUA/LuaSnip/deps/jsregexp005'...
Submodule path 'deps/jsregexp': checked out 'b5a81e21d0875667ba2458ac8ae903afd5568698'
Submodule path 'deps/jsregexp005': checked out 'dd65498ae2c29b882d6c02c0a30577b08d660b94'
gmake "CC=cc" "INCLUDE_DIR=-I'/home/vermaden/_LUA/LuaSnip/deps/lua51_include/'" LDLIBS="" -C "deps/jsregexp"
gmake[1]: Entering directory '/home/vermaden/_LUA/LuaSnip/deps/jsregexp'
cc -I'/home/vermaden/_LUA/LuaSnip/deps/lua51_include/' -O2 -fPIC -c jsregexp.c -o jsregexp.o
cc -I'/home/vermaden/_LUA/LuaSnip/deps/lua51_include/' -O2 -fPIC -c cutils.c -o cutils.o
cc -I'/home/vermaden/_LUA/LuaSnip/deps/lua51_include/' -O2 -fPIC -c libregexp.c -o libregexp.o
cc -I'/home/vermaden/_LUA/LuaSnip/deps/lua51_include/' -O2 -fPIC -c libunicode.c -o libunicode.o
cc -shared jsregexp.o cutils.o libregexp.o libunicode.o  -o jsregexp.so
gmake[1]: Leaving directory '/home/vermaden/_LUA/LuaSnip/deps/jsregexp'
gmake "CC=cc" "INCLUDE_DIR=-I'/home/vermaden/_LUA/LuaSnip/deps/lua51_include/'" LDLIBS="" -C "deps/jsregexp005"
gmake[1]: Entering directory '/home/vermaden/_LUA/LuaSnip/deps/jsregexp005'
cc -I'/home/vermaden/_LUA/LuaSnip/deps/lua51_include/' -O2 -fPIC -c jsregexp.c -o jsregexp.o
cc -I'/home/vermaden/_LUA/LuaSnip/deps/lua51_include/' -O2 -fPIC -c cutils.c -o cutils.o
cc -I'/home/vermaden/_LUA/LuaSnip/deps/lua51_include/' -O2 -fPIC -c libregexp.c -o libregexp.o
cc -I'/home/vermaden/_LUA/LuaSnip/deps/lua51_include/' -O2 -fPIC -c libunicode.c -o libunicode.o
cc -shared jsregexp.o cutils.o libregexp.o libunicode.o  -o jsregexp.so
gmake[1]: Leaving directory '/home/vermaden/_LUA/LuaSnip/deps/jsregexp005'
# remove old binary.
rm "/home/vermaden/_LUA/LuaSnip/lua/luasnip-jsregexp.so" || true
rm: /home/vermaden/_LUA/LuaSnip/lua/luasnip-jsregexp.so: No such file or directory
# there is some additional trickery to make this work with jsregexp-0.0.6 in
# util/jsregexp.lua.
cp "/home/vermaden/_LUA/LuaSnip/deps/jsregexp/jsregexp.lua" "/home/vermaden/_LUA/LuaSnip/lua/luasnip-jsregexp.lua"
# just move out of jsregexp-directory, so it is not accidentially deleted.
cp "/home/vermaden/_LUA/LuaSnip/deps/jsregexp/jsregexp.so" "/home/vermaden/_LUA/LuaSnip/deps/luasnip-jsregexp.so"

~/_LUA/LuaSnip % echo $?
0

Nice, yeah that looks good :)
It's using cc by default, but that can be changed via export CC=gcc/clang/whatever, so fine :)
Thanks for testing :D

Welcome. Happy to help. Regards :)


How to add a unique index to a collection that already exists?

I see that you can add a unique index to a collection on creation
var db = new Loki('test');
db.addCollection('abc', {indices:['_id']});

But how would I add a permanent unique index to a collection that already exists?
Thanks

I just made a bunch of databases then realized that I forgot to set it on all of them lol

for that matter how does one also change collection settings like: autosaveInterval after the collection exists?


Trained resolution and memory requirements

What resolution were these models trained at? I tried 1920x1080 images and this results in OOM even on 80gb A100. Is this far higher than expected resolution?

Hi morgankohler,
I think for training, 1920x1080 images will likely go OOM. We use 64x64x16 (WxHxT) as input for training, where the gt is of size 256x256x16. 1920x1080 will results in 500 times more memory.
You can crop the image into smaller patches and use them for traning.
Regrads,
Kai


Endianness issue in encode_decode.c

encode_decode.c contains the code
*(uint64 *)salt = *(uint64 *)salt ^ sequence_number;
where salt is an array of bytes. This is interpreted differently on big-endian and little endian architectures. Need to use shifts and bitmasks to perform this operation in an endianness-agnostic manner.

This has been subsumed by https://github.com/DMTF/libspdm/issues/276


Fixed optional odometer for wondex protocol and exclusion for 0.0 odometers

Only wondex has optional odometer.
Anyway I've added check if both odometer values are zero they are not used to calculate distance.
There are a lot of "0.0" odometers in unit tests in different protocols. I think it is not rare case that it is zero.

Merged, thanks.


Saturation issues

Thank you for the fantastic plugin my pages load so gracefully now.
I have noticed a slight issue with image saturation/vividness of colors are. It seems imageset is making the slightly muted as you can see in the attached thumbnail. I'm not sure whether this is a bug or bad implementation of the plugin by me. Any help would be greatly appreciated.

Template Code

Imageset

    <?php if($image = $page->thumbnail()->toFile()):?>
        <?= $image->imageset([
                '160-1280,6', 'sizes' => '(min-width: 640px) 100vw, 50vw'
            ], [
                'class'       => 'awesome-image',
                'placeholder' => 'color',
            ]) ?>
    <?php endif; ?>

Default

    <?php if($image = $page->thumbnail()->toFile()):?>
        <img style="width: 100%;" src="<?= $image->url() ?>" />
    <?php endif; ?>

This looks like a color space issue. Can you compare the color profiles of your source and thumbnail images? Try to convert your source image to sRGB and see if that fixes it...

Hi, the color change is probably happening inside of Kirby’s thumb driver (which ImageSet is relying on). As far as I know, the default driver does not preserve color profiles. The best way to get around this issue, is probably to override the built-in driver with a custom solution bases on ImageMagick, as it offers more options than GD:
Source code:
https://github.com/getkirby/kirby/blob/master/vendor/getkirby/toolkit/lib/thumb.php#L272
Tutorial for writing custom thumb drivers:
https://getkirby.com/docs/developer-guide/toolkit/thumb-driver
Docs for ImageMagick:
https://www.imagemagick.org/script/command-line-options.php

Thank you so much for the help. Following @foxacid's advice I was able to determine that the problem is the lack of an sRGB color profile. Following the the links of @fabianmichael it seems it's as simple as copying the template of Imagemagick to a custom driver and then adding the line:
$command[] = '-colorspace sRGB';

And setting c::set('thumbs.driver', 'pd'); in the config. However, the colors are still muted when the thumbnail is made. Is there something I am missing?


Allow nested secrets in secrets.json

Prior to this change, if secrets.json had nested secrets (example) we would see this error:
sops-install-secrets: Manifest is not valid: secret jenkins-nix-ci/cachix-auth-token/description in /nix/store/wxm763za3rbrpiijfbgss9g5ll0sd29z-secrets.json is not valid: Key 'jenkins-nix-ci' does not refer to a dictionary

The reason happens to be that introspecting the map key to be interface fails, when it is in fact a string. This PR makes it so that we always expect the key to be a string (what else could it be?). It also improves the error message, by telling the user what the actual value type is.

Huh, this is causing the yaml processing to regress.

I am trying to write the test for this. Here's how the nixos-test.nix looks:
nested-json = makeTest {
    name = "sops-nested-json-secrets";
    nodes.server = {
      imports = [ ../../modules/sops ];
      sops = {
        age.keyFile = ./test-assets/age-keys.txt;
        defaultSopsFile = ./test-assets/secrets.json;
        secrets."nested/test/file" = { };
      };
    };

    testScript = ''
      start_all()
      server.succeed("cat /run/secrets/nested/test/file | grep -q 'another value'")
    '';
  } {
    inherit pkgs;
    inherit (pkgs) system;
  };

Expected: testScript should fail with Key 'nested' does not refer to a dictionary
Actual: Test passes
On the other hand, if I try to run nix build .#nixosConfigurations.actual.config.system.build.toplevel on @srid 's nixos-config with sops-nix.url pointing to github:Mic92/sops-nix, I am able to reproduce the same error.
@Mic92 Is there something that's happening under-the-hood in nixos-test.nix that I might be missing?


Forge 1.20.1 crashes on loading screen

I'm using version 0.4.10 of the mod, here logs: latest.log

In short, weird ass mixin issue

Also same issue with the same version, mixin issue. The one mod I wanted to work didnt work.

I am unable to reproduce this issue. What Forge version are you using (only 47.1.3 and NeoForge are supported)? Have you tried with just World Host and no other mods?

Since I am unable to reproduce this, I will close this issue.


Change widgets in NamespaceOverview

Description
Changes proposed in this pull request:

changed widgets look in NamespaceOverview
removed tooltips for Pods and Deployments card

Related issue(s)

/test all

/delete all

/test all

/test all

/retest


Support multiple deployments per cognitive service

Fixes https://github.com/dotnet/aspire/issues/3409
Microsoft Reviewers: Open in CodeFlow

@JoshLove-msft is that something that could be made public, or in the opposite not used?
By that I mean this PR uses private reflection to access Resource.AddDependency().

Yeah this can be made public.

@JoshLove-msft is that something that could be made public, or in the opposite not used?
By that I mean this PR uses private reflection to access Resource.AddDependency().

Yeah this can be made public.

https://github.com/Azure/azure-sdk-for-net/pull/43257

Should the AOAI demo in the playground folder be expanded to have multiple model deployments so there's an implementation

@joperezr I wonder whether it would help to retrain the labeler bot

although these things on the hosting side that are specific to a component, I'm not sure what to label

Update with public method and tried it with one and two deployments successfully.

/backport to release/8.0


0 exposure time uses Bias type.

Additionally, changed exposure number and time to be number input fields instead of text. Also, exposure number and time are checked to be at least 1 and 0 respectively.

merge after it has been put onto main


Using a type for which a map is the underlying type

Hello!
First and foremost, thanks for this great project!
We use goja at Conduit to support transformations in data pipelines. As I'm documenting certain use cases, I'd like to ask the following:
We have the following type:
type StructuredData map[string]interface{}

Let's say I'm writing a JS function to operate on an instance of  StructuredData. Is it possible at all to use the bracket syntax to set keys? i.e. can I have this in my JS code:
function transform(data) {
    data["metadata"] = something;
    return data;
}

Yes, but only as long as StructuredData does not have any exported methods. See https://pkg.go.dev/github.com/dop251/goja#hdr-Maps_with_methods for more details.

@dop251 Thanks for the quick reply, that helps a lot. In this case, StructuredData does have exported functions, so it looks like we'll go with the getter approach.


New lines in text areas.

Hi, really love using Comfy, thanks for all the hard work.
Just wondering if there was a way to preserve the newlines in the text areas. I would love to have multiple paragraphs in the same areas, without opening up the option of rich text.
Thanks,
Tom.

Sorry, I realised that  tags get preserved in text areas. Thanks.


TypeError: Cannot read property 'vm' of undefined when using vue-router and inlined template

I may be dense, but when trying to use your component with vue-router I get TypeError: Cannot read property 'vm' of undefined when trying to use the filter function. Sorting and layout both work before trying to filter, but after they break with the same error.
Here is a live example of the issue. In this case there's a router.js and main.js and the template for the isotope router-view is inline in the router file. Any idea what's going wrong?

Hello @bornytm , It seems that in presence of jQuery the isotope component sends event with diferrent parameters. Coudl you please to remove the jquery tag script and see if the problem still hapens?

@bornytm , could please use isJQueryFiltering=false in the isotope option and tell me if this resolve the issue?

Both using isJQueryFiltering=false in the options and removing jquery entirely seems fixes the issue. Thanks!

@bornytm cool! I will release a version where isotope component forces isJQueryFiltering=false. Untill I release this version, you can set isJQueryFiltering=false manually.

Fixed in version 2.1.0


Rename fatman to job

Yes, the reason it's sitting here semi-stale is because I didn't figure out how to test it properly and promptly forgot about it. If you can test it on your end and it works, it's ready to merge.


[Go Live][Nov 16]

Push to live

Docs Build status updates of commit bd5832a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/TOC.yml
:white_check_mark:Succeeded
View

msteams-platform/assets/images/bullhorn.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/month-update.png
:white_check_mark:Succeeded
View

msteams-platform/mstdd-landing.yml
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


New make theme

[x] New theme - 'Make'
[x] Hashtag navigation system
[x] create a core set of functions (incorporated into both hckr & make themes)
[x] background image from account settings

Partly works towards #11  but needs more thought


Use zig standard library deflate implementation

With https://github.com/ziglang/zig/pull/6277 merged there is no need for a separate deflate implementation.

I've looked into doing this, and there are a few issues:

This issue is blocked until the spurious error.EndOfStream in zlib std is fixed: https://github.com/ziglang/zig/issues/6847
Currently, zigimg's deflate implementation can accept chunks of data at a time, while the std implementation requires all data to be known beforehand

This means that we have to assemble all the separate IDAT chunks into a single buffer before reading any pixels

Neither of these seem like deal breakers, but std zlib not allowing partial reads will be an issue if zigimg wants to support streaming.

Currently, zigimg's deflate implementation can accept chunks of data at a time, while the std implementation requires all data to be known beforehand

sounds like a feature to add to the std lib :)

Fixed in 30848b94969f78294b184245ac1ca783e704fa98


GEODE-3141: GetRegion Operation implemented

Added OperationHandlerJUnitTest.java as parents class of all OperationHandler tests.
General clean up of all public static final fields
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[x] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[x] Is your initial contribution a single, squashed commit?

[ ] Does gradlew build run cleanly?

[x] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>@galen-pivotal @hiteshk25 @bschuchardt @WireBaron @pivotal-amurmann

Looks like Spotless is failing in CI.


server error 500 No command specified

i got this error while downloading the docker-ios-notificaiton.
any idea what happened ?

As the error suggests, there are 'no command specified' in the Dockerfile:
https://registry.hub.docker.com/u/cloudspace/docker-ios-notification/dockerfile/
If you look at the registry information a command is required before the container can be created:
https://registry.hub.docker.com/u/cloudspace/docker-ios-notification/
Unfortunately there isn't an easy way for Kitematic to detect this, but it's something on the feature request.

@edwardIshaq It could also be because a network connection timed out.


bug: Check if window is available before use

Checked if window is available before use in app bar, slider component and ripple service, However window is used in following files as well but I could not fix all. There is closed issue for this problem at https://github.com/trimox/angular-mdc-web/issues/33

[x] app-bar.ts
[x] slider.ts
[x] ripple.service.ts
[ ] notched-outline.ts => line 40
[ ] tab-bar.ts => line 111
[ ] tab-scroller.ts => line 56

document uses without check at following files

[x] menu.ts
[x] drawer.ts
[x] ripple.service.ts
[x] snackbar.component.ts
[ ] list.ts => line 162
[ ] menu.ts => line 206
[ ] portal.service.ts => line 22

This is my 1st PR on Github, so if anything is wrong with this please let me know.

@JeetChaudhari Sorry about the broken server rendering for those components! Wow, original issue was from the beginning of the repo, memories.. 😄
Much appreciate the work! 💎 and congrats on your first PR 🥇 on GitHub!
Soon as you're ready for review or hit a snag, just ping me. We'll get this merged for a v0.38.x release.

@trimox I have fixed all problems which caused window is not defined errors, Please review these changes and If you need anything changed in this then do let me know. Also, I noticed on Angular SSR some other random errors also occur with all these components, I will soon add issues for them as well as set up the repo to reproduce those random errors.

@trimox Thanks for reviewing the changes, I have made corrections that you asked for. Thank You

Thanks! 💎 I'll finish reviewing today, and we'll give it a test run.

@trimox Thanks for pointing out changes, I will get this tomorrow, it would be soon night here in India.

It's no problem! Sorry for delay on review, been tied up with upcoming MDC v0.39.0 changes..

Also, I'd recommend holding off on merging master if you're testing still. I began merging v0.39.0 features today.

@trimox All required changes completed.

LGTM! Don't worry about the merge conflicts, I'll take a look.
Also, I've discovered the root cause of the random errors you mentioned on some components. I'll create an issue tomorrow, but it's related to the way TypeScript preserves type information of methods with decorators (e.g.: @HostBindings and @HostListener).

Thank You

I'm slowly but surely incorporating changes reporting conflicts with the major changes in v0.39.1. We're getting there..

And implementing the additional recommended fixes for other areas reporting issues for server rendering - reference #1268

@trimox No issues. For #1268 I do not understand what actual changes you intend to do by the configurable directive, If you can show me an example of one component, I am willing to help. Actually, I was a PHP developer since 2012, but from last year I started using only javascript lang in my company for so many issues and save costing instead of multiple programming langs, so still don't have much experience with all this javascript.

@JeetChaudhari Don't fret about these merge conflicts, they are expected since the upcoming v0.39.x release had a ton of adapter improvements upstream. I've tried to incorporate your PR fixes as I progressed with the updates. So far it's looking good!
Directive configuration example,
https://github.com/trimox/angular-mdc-web/blob/master/packages/menu/menu.ts#L74

Phew, since v0.39.x got published I'll work on merging into v0.38.2 tag as separate branch..

@trimox Can we please merge this into master and later sort out other issues (#1268 )? Merging this would make SSR build work for at least other components which are not affected by #1268
Thank You

Closing. Created #1381 off this PR


[Issue-212] Support ORDINALS•RUNES

🚀 Deployed on https://pr-213--papaya-melba-f5c160.netlify.app


Can’t set a static IP when using WiFi

When I try to set a static IP configuration on the wlan0, it does not connect to the access point. This is kind of problematic when you want to use the device as a server with a static IP.
Expected behaviour
You should be able to set the method to :dhcp or :static like with wired interfaces.

@ConnorRigby I see you’ve already patched this in 315e4037705c0cc195ce46ded13c71fd9ac616bb. Why isn’t this merged on master? Anyway, I’ve checked the history and cherry-picked this commit in a branch on my fork. I don’t have a target with Wi-Fi at home to try this, but I’ll do on Monday morning at work.

@fhunleth have you had a chance to check this out?

As far as I understand, all commits from allow_static_wifi_config have been rebased on master, except the last one effectively allowing the static config.

Have you tested it out? It's been a while since I worked in this repo, but I believe it is ready for a minor release

@ConnorRigby No, the Raspberry Pi I have at home does not handle WiFi, so I can’t right now. I’ll do this on Monday, I have a Nerves app that works on a Raspberry Pi 3 at work —and I need a static IP on Wi-Fi, that’s why.

@ConnorRigby Sorry, I'm not maintaining nerves_network so I wasn't even paying attention. Your change looks fine at a glance. Assuming that you and @ejpcmac are good with it, then I think that you should merge it to master and make a new release.

There is an issue with the ipv4_* parameters being passed to wpa_supplicant, that does not seem to enjoy their presence. I’ll patch this, try, and let you know.

@ejpcmac let me know if you hit any issues. I've been away for about 3 weeks, and am just now getting back to work, and this is near the top of my list to take care of.

@ConnorRigby I’ve done a pull request #56, all works as expected now. I’ve tried to configure the wlan0 interface without any ipv4_*, then with the DHCP method and static. Both options work.

Okay cool. I actually have a number of things on that branch where you found that commit that i want to pull in. I'm working on that right now, then i will make sure to address #56

@ConnorRigby Weren’t theese commits rebased on master already? Compare the author dates on both branches, there seems to be lots of identical commits.

You're right. Thanks for saving me loads of merge commits!

Okay i just merged that #56 Thanks for the help!

You’re welcome! Thanks for Nerves, I want to use more of this. There are great ideas there.


Allow me to Deploy using Docker Compose/Swarm YAML

I'd like to take a Docker Compose or Docker Swarm YAML file and deploy it to multiple container apps.

I'd like any features that are not supported to be configurable via a series of environment variables.
There should not be any features that are not configurable and no downsides to this approach.
Docker Compose/Swarm easily connects up containers to each other and gives them simple DNS names to facilitate this. I'd like container apps to be given equally simple DNS names, so they can talk to each other internally without me having to re-configure my app in any way or to give my app any knowledge that its hosted by container apps.

This is currently not part of the Azure Container Apps roadmap but we definitely appreciate the insight and will keep watching for use cases here.


Any changelog?

Is there any updated changelog? In gitHub releases I see last release 3.9.0 but on npm last package version is 5.0.1. And I don't see any changelog or history file. What changes were between this versions? Look like major version was updated. Does it  mean that api was changed? Any other breaking chagnes?

There are also changes that were merged months ago that still haven't had a release cut:
https://github.com/pushtell/react-bootstrap-date-picker/issues/114
Seems like the author may have gone dark.


When trying to paste "Export to CIVAS" from clipboard into the CIVAS sheet, data is in the wrong orientation

Load data on Datacore that has a recalling voyage.
Go to Voyage.  Click Export to CIVAS.
Open your CIVAS sheet.  Locate the correct Primary / Secondary pair and find go to an empty column.
Paste.

The data comes out horizontally.
Note: I have tried pasting transposed but nothing happens.
Environment: Chrome for Windows 102 and 103, Chrome for Android, latest version.  Also tested by obtaining clipboard data from Edge (Chrome) 103.

CIVAS recently got a big update, see here: https://docs.google.com/spreadsheets/d/1edSWAoaqFMK4S9CSI7Qk21iNSWKExZGeySp06CW1B4c/edit?usp=sharing
DataCore's voyage calculator has been updated to be more compatible with the (horizontal) format of the new version.

Guess I better look at the new version.  Hadn't caught up with it, yet.  Just realized it even existed about 2 days ago.  Thanks!


Reboot resilience

Description of the new feature / enhancement
I'd like to have WinGet be resilient to reboots.
Some packages require a reboot when they are updated. If I was in the middle of a winget import packages.json or winget install <package 1> <package 2> <package 3> or installing a package with a dependency that triggered a reboot, I'd like WinGet to be able to pick up where it left off.
Related to:

#163

Proposed technical implementation details
No response

have winget after parsing input, create a temp a file in %temp% should an intaller restart the system, have winget run at startup to verify that all packages in the temp file have been instlled. if there are pacages left, resume install if not, exit


I am interested in using your game on my website. Could you add a license file like the MIT one in this pull request so I know how you want your software used?

Sure, go for it.

Thanks


Load image from url link

Please support load image from url link. Thanks.

you can use glide for such task


Fix ISO building on F39

lklug-fonts is no longer available on F39, thus the first commit drops that (while updating the test repos). The second commit does a bit of clean-up without any functional changes. Finally, the test manifests are regenerated.
The lklug-fonts fix was cherry-picked from #3282
This pull request includes:

[ ] adequate testing for the new functionality or fixed issue
[ ] adequate documentation informing people about the change such as

[ ] submit a PR for the guides repository if this PR changed any behavior described there: https://www.osbuild.org/guides/

Thanks for the fix! Do we need to pull in another fonts package for Sinhala?

No idea to be honest. We were thinking of removing the package first to unblock the builds, and then finding a proper fix.


gitlab: Support Puma webserver

Project description
The default webserver in GitLab 12.9+ is no longer Unicorn, but Puma. Support for Unicorn is expected to be dropped dropped by Gitlab 14 (May 2021)
We should support Puma.
https://docs.gitlab.com/ee/administration/operations/puma.html

It's now using puma https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/services/misc/gitlab.nix#L1253-L1259


Bump lodash version

@redonkulus
Bump lodash to 4.0

@roderickhsiao build failed because an internal dependency was in the package.json. I've opened a new PR to update lodash. https://github.com/yahoo/atomic-style/pull/2


Don't link to deprecated terminal.integrated.automationShell.* settings (#156481)

This PR fixes #156481
Result of the PR:

Can this be merged now?


Feature: Integrate with GSM Module for Duplicate Subjects

Feature Details

Example Code

Possible Implementation

Additional Comments

Closing until we have details sorted. Please add comments in #1514 for now


Deadlink / missing tool: FOCA (under Metadata)- link redirected

Under "Metadata", the FOCA link (https://www.elevenpaths.com/labstools/foca/index.html) redirects to https://cybersecuritycloud.telefonicatech.com.

Updated to their github. Thanks for the heads up.


Allow user to use a component wrapper server side only

Use case : I want to use react-helmet and I need to wrap my component with the Html structure server-side only

@bulby97 can you give an example?


Breaking change is missing spaces in description

Describe the bug
In the case of a "breaking change", the description is missing a space between the line breaks:
### ⚠ BREAKING CHANGE

* Titles, footers, actions, and selectable actions all can't behandled by the Card object directly anymore and need to be delegated to the
more specific classes.

### ⚠ BREAKING-CHANGE

* Those type aliases helped with the migrate. From nowone please use the new type names.
* The legacy version of the Select component isdeprecated in PF5. You need to upgrade to the newer components.

Note the behandled,  nowone, and isdeprecated (which is the line break in the commit).
To Reproduce
Steps to reproduce the behavior:

Clone 'https://github.com/patternfly-yew/patternfly-yew'
Run convco ...
See error ...

Expected behavior
When lines are concatenated, there should be a space.
System (please complete the following information):

OS: fedora, ubuntu,
Version: 39, 22.04

Additional context
Add any other context about the problem here.

It was not the goal to concatenate the multi line footers. see #223


async local io

Async local io
this does not really make too much sense right now, but will become part of the workspace once the iroh crate split is done.

This is already published. Here are the docs: https://docs.rs/iroh-io/0.1.0/iroh_io/

Looks good overall. I haven't reviewed the details of the impl, just general structure.

The impls are as simple as possible. There is an entire big can of worms called buffering that I will need to add. But not in this PR


Docker crashes whenever I try to send a message or edit the settings

How are you running AnythingLLM?
Docker (local)
What happened?
I can't get AnythingLLM to work on my Ubuntu 24.04 running on intel Xeon. Connected to Ollama running on the local machine.
I get the following error in the logs:

/usr/local/bin/docker-entrypoint.sh: line 7:   123 Illegal instruction     (core dumped) node /app/server/index.js

The full log dump:

Collector hot directory and tmp storage wiped!
Document processor app listening on port 8888
Environment variables loaded from .env
Prisma schema loaded from prisma/schema.prisma
✔ Generated Prisma Client (v5.3.1) to ./node_modules/@prisma/client in 496ms
Start using Prisma Client in Node.js (See: https://pris.ly/d/client)
import { PrismaClient } from '@prisma/client'
const prisma = new PrismaClient()

or start using Prisma Client at the edge (See: https://pris.ly/d/accelerate)
import { PrismaClient } from '@prisma/client/edge'
const prisma = new PrismaClient()

See other ways of importing Prisma Client: http://pris.ly/d/importing-client
Environment variables loaded from .env
Prisma schema loaded from prisma/schema.prisma
Datasource "db": SQLite database "anythingllm.db" at "file:../storage/anythingllm.db"
20 migrations found in prisma/migrations
No pending migrations to apply.
┌─────────────────────────────────────────────────────────┐
│  Update available 5.3.1 -> 5.15.0                       │
│  Run the following to update                            │
│    npm i --save-dev prisma@latest                       │
│    npm i @prisma/client@latest                          │
└─────────────────────────────────────────────────────────┘
[TELEMETRY ENABLED] Anonymous Telemetry enabled. Telemetry helps Mintplex Labs Inc improve AnythingLLM.
prisma:info Starting a sqlite pool with 13 connections.
fatal: not a git repository (or any of the parent directories): .git
getGitVersion Command failed: git rev-parse HEAD
fatal: not a git repository (or any of the parent directories): .git
[TELEMETRY SENT] {
event: 'server_boot',
distinctId: '9c10440f-e20f-43c9-b27f-062c6f731e19',
properties: { commit: '--', runtime: 'docker' }
}
[CommunicationKey] RSA key pair generated for signed payloads within AnythingLLM services.
Primary server in HTTP mode listening on port 3001
OpenAIError: The OPENAI_API_KEY environment variable is missing or empty; either provide it, or instantiate the OpenAI client with an apiKey option, like new OpenAI({ apiKey: 'My API Key' }).
at new OpenAI (/app/server/node_modules/openai/index.js:53:19)
at openAiModels (/app/server/utils/helpers/customModels.js:59:18)
at getCustomModels (/app/server/utils/helpers/customModels.js:29:20)
at /app/server/endpoints/system.js:929:41
at Layer.handle [as handle_request] (/app/server/node_modules/express/lib/router/layer.js:95:5)
at next (/app/server/node_modules/express/lib/router/route.js:149:13)
at validatedRequest (/app/server/utils/middleware/validatedRequest.js:18:5)
[Event Logged] - update_llm_provider
[Event Logged] - update_embedding_engine
[Event Logged] - update_vector_db
[TELEMETRY SENT] {
event: 'workspace_created',
distinctId: '9c10440f-e20f-43c9-b27f-062c6f731e19',
properties: {
multiUserMode: false,
LLMSelection: 'ollama',
Embedder: 'native',
VectorDbSelection: 'lancedb',
runtime: 'docker'
}
}
[Event Logged] - workspace_created
[TELEMETRY SENT] {
event: 'onboarding_complete',
distinctId: '9c10440f-e20f-43c9-b27f-062c6f731e19',
properties: { runtime: 'docker' }
}
[NativeEmbedder] Initialized
/usr/local/bin/docker-entrypoint.sh: line 7:   123 Illegal instruction     (core dumped) node /app/server/index.js

I tried to search the closed issues and landed on https://github.com/Mintplex-Labs/anything-llm/issues/1265 which I guess is a similar situation but I'm new to linux and can't wrap my head around the solution
Are there known steps to reproduce?
No response

Same as the pinned issue https://github.com/Mintplex-Labs/anything-llm/issues/1331#issuecomment-2153414982

Thank you, the lancedb_revert image worked like a charm. I think I'll have to work with that for now until I can upgrade my CPU.


Use host networking

NB: based on feat/hostport as that is required for host networking.
Uses host networking to avoid MPI errors and give better network performance.
Using host networking means the pod's hostname = k8s node name, e.g. sbtest-worker-a438ab51-c69dx. This isn't "slurm hostlist expression compatible" so e.g. sinfo can't contract the nodenames. This PR uses the downward API to inject the pod name (which is hostlist expression compatible e.g. slurmd-0 as using a StateFullSet) into the container's environment vars, and explicitly sets the slurm'd nodename on startup using slurmd -N <nodename>.
Example of performance changes on arcus using portal-internal network (i.e. not RoCE), showing 0-byte, max bandwidth max message size values from srun-launched IMB-MPI1 pingpong using openmpi in image:
Default CNI :
       #bytes #repetitions      t[usec]   Mbytes/sec
            0         1000        43.03         0.00
...
      1048576           40      5046.30       207.79
...
      4194304           10     24296.99       172.63

Host networking:
       #bytes #repetitions      t[usec]   Mbytes/sec
            0         1000        34.75         0.00
...
      2097152           20      5929.08       353.71
      4194304           10     12546.33       334.31

(note in both cases the K8s node VMs are on the same hypervisor host).

Manually ran image build at this commit

@sd109 checked OOD dashboard and jobs etc work anyway.


Fix broken ref link in deploying app tutorial

Reference to another tutorial was broken, issue identified and fixed.
QA steps: checked rendered output to check that ref/link is working.
No related task tracking info, minor fix.
PR Template and Checklist
Please complete as much as possible to speed up the reviewing process.
Readiness and adding reviewers as appropriate is required.
All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.
Readiness

[x] Merge (pending reviews)
[ ] Merge after date or event
[ ] Draft

Overview
Why merge this PR? What does it solve?
Checklist

[ ] Run spelling and grammar check, preferably with linter.
[x] Avoid changing any header associated with a link/reference.
[ ] Step through instructions (or ask someone to do so).
[ ] Review for wordiness
[ ] Match tone and style of page/section.
[ ] Run make linkcheck.
[x] View HTML in a browser to check rendering.
[ ] Use semantic newlines.
[x] follow best practices for commits.

[x] Descriptive title written in the imperative.
[x] Include brief overview of QA steps taken.
[x] Mention any related issues numbers.
[x] End message with sign off/DCO line (-s, --signoff).
[x] Sign commit with your gpg key (-S, --gpg-sign).
[x] Squash commits if needed.

[x] Request PR review by a technical writer and at least one peer.

Comments
Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.

Docs for 4fbed612e0a598bed241509ee37ad814d961e115 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2688/docs/artifacts/html/index.html


Revert "[release-0.20] Bump metallb/metallb to latest release"

Reverts aws/eks-anywhere-build-tooling#3481

/approve

/lgtm
/approve


Continuation operator needed in sky130/Makefile.in

Every line is run in a new shell by make, so need a continuation operator there.

Ah, thanks for catching and testing that.  Pulled and merged.


Add tests to LoadingRouterContext

Coverage increased (+1.02%) to 80.143% when pulling d826111dd195c48598954a72dd63b06cfda2f28f on briansteffens:preload-testing into ab5e879f7fe2b23911b1bd3eca90d1d82d9e3bd5 on linode:master.

Coverage increased (+1.005%) to 80.133% when pulling 231828d7ab13bf58a856b3d274edfa484128c3d4 on briansteffens:preload-testing into ab5e879f7fe2b23911b1bd3eca90d1d82d9e3bd5 on linode:master.

👎 I like this pr


macOS deployment via TravisCI and Github Releases

This adds testing and deployment via GitHub Releases for macOS builds. Releases will only be deployed whenever a tag is pushed. Hopefully in the future we will be able to tar the separate binaries together.
Please squash this!

I will refactor this to use the stages we had before, so that we can avoid the 50 minutes time limit

@lorenzo over to you


Timm version

Hi @noahzn,
I am trying to train the model, so I followed the procedure from monodepth2. I created the conda environment with the right packages and versions, but when I run the training, it get an error saying that timm is missing. I tried to install a few different versions, but it keeps throwing errors. I also tried it with pytorch 1.0, since that is also possible according to the monodepth2 page, but that doesn't work neither.
Can you tell me which timm package I need and if I should use the same package versions as monodepth2.
Thanks in advance!

Hi @noahzn ,
Thank you for your reply! I got it working now.
I am setting up a google VM, so I installed all the newest version of the packages. However, I got some error about 30 seconds after I started the training about the dataloader, because I used pytorch 2.0 (at least that is what I found after some research on stackoverflow). Unfortunately, I cannot remember the exact error.
So I tried to install the version mentioned on the monodepth2 github, but these were to old to be compatible with timm. With the versions you provided, I got it working. I guess its just a rookie mistake, so thanks for the help!

Good to know! Please let me know if you have more questions. I now close this issue.


Don't fail when ptrace::detach returns ESRCH.

ESRCH indicates that the thread has disappeared while we had it stopped. We don't consider this an error.
Closes #29.

Note that we could probably add a test to cover this case; let me know if that's desirable (the existing tests fail on my local machine sometimes, I am going to look into that).

If you have time to write a test that's always welcome! Also it seems that recent versions of clippy are complaining about redundant casts, could you address it in a separate commit within this PR? Thanks for your contribution!

I fixed the clippy issues after merging your PR, I didn't want to waste your time on them given they were trivial. As for the test I thought about it and it's a lot of work for little benefit: it's a scenario we routinely hit in production and we have a dedicated path for handling errors. If it doesn't work as expected we'll see it in production, if it works then the error will be gone and we get more minidumps. So there's no downsides to not having test coverage.


Failed to validate prompt for output

I don't know if its because the admotiondirector isnt updated but i have a new problem now there it is:
got prompt
Failed to validate prompt for output 26:

ADMD_TrainLora 24:

Return type mismatch between linked nodes: trigger_input, ADMDPIPELINE != VHS_FILENAMES
Required input is missing: admd_pipeline
Output will be ignored
Failed to validate prompt for output 14:

ADMD_TrainLora 12:

Return type mismatch between linked nodes: trigger_input, ADMDPIPELINE != VHS_FILENAMES
Required input is missing: admd_pipeline
Output will be ignored
Failed to validate prompt for output 64:

ADMD_TrainLora 32:

Return type mismatch between linked nodes: trigger_input, ADMDPIPELINE != VHS_FILENAMES
Required input is missing: admd_pipeline
Output will be ignored
Failed to validate prompt for output 34:
Output will be ignored
Failed to validate prompt for output 11:

ADMD_TrainLora 8:

Return type mismatch between linked nodes: trigger_input, ADMDPIPELINE != VHS_FILENAMES
Required input is missing: admd_pipeline
Output will be ignored
Failed to validate prompt for output 30:

ADMD_TrainLora 28:

Return type mismatch between linked nodes: trigger_input, ADMDPIPELINE != VHS_FILENAMES
Required input is missing: admd_pipeline
Output will be ignored
WARNING: ADMD_CheckpointLoader.IS_CHANGED() got an unexpected keyword argument 'ckpt_name'
Some weights of the model checkpoint were not used when initializing CLIPTextModel:
['text_model.embeddings.position_ids']
using DDIMScheduler for training
load motion module from G:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-AnimateDiff-Evolved\models\v3_sd15_mm.ckpt

G:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-ADMotionDirector\animatediff\utils\util.py:117: FutureWarning: You are using torch.load with weights_only=False (the current default value), which uses the default pickle module implicitly. It is possible to construct malicious pickle data which will execute arbitrary code during unpickling (See https://github.com/pytorch/pytorch/blob/main/SECURITY.md#untrusted-models for more details). In a future release, the default value for weights_only will be flipped to True. This limits the functions that could be executed during unpickling. Arbitrary objects will no longer be allowed to be loaded via this mode unless they are explicitly allowlisted by the user via torch.serialization.add_safe_globals. We recommend you start setting weights_only=True for any use case where you don't have full control of the loaded file. Please open an issue on GitHub for any issues related to this experimental feature.
motion_module_state_dict = torch.load(motion_model, map_location="cpu")
load domain lora from G:\ComfyUI_windows_portable\ComfyUI\models\loras\v3_sd15_adapter.ckpt
G:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-ADMotionDirector\animatediff\utils\util.py:170: FutureWarning: You are using torch.load with weights_only=False (the current default value), which uses the default pickle module implicitly. It is possible to construct malicious pickle data which will execute arbitrary code during unpickling (See https://github.com/pytorch/pytorch/blob/main/SECURITY.md#untrusted-models for more details). In a future release, the default value for weights_only will be flipped to True. This limits the functions that could be executed during unpickling. Arbitrary objects will no longer be allowed to be loaded via this mode unless they are explicitly allowlisted by the user via torch.serialization.add_safe_globals. We recommend you start setting weights_only=True for any use case where you don't have full control of the loaded file. Please open an issue on GitHub for any issues related to this experimental feature.
domain_lora_state_dict = torch.load(adapter_lora_path, map_location="cpu")
Processing interrupted
Prompt executed in 24.88 seconds

so i tried the suggested pytorch 2.2.0 cu1.2.1 since i have the newest  2.4.1cu124 but its not working either

Is this repo still alive? Its been 3 week without  response. I still have the same issue! And i don't even know what causing this! Probably an dependencies maybe ?

I've been getting the same error as well. It looks as though the input on the ADMD TrainLora Node have chaged but tried updating the repo, uninstalling reinstalling and can't seem to get it going. Frustrating because it was working fine just a few weeks ago

I got it to work! First, moved the pipeline connection from 'trigger input' to 'admd pipeline' then right clicked 'recreate node' which makes the steps input appear. Then you can relink the steps to that input and the workflow runs

I got it to work! First, moved the pipeline connection from 'trigger input' to 'admd pipeline' then right clicked 'recreate node' which makes the steps input appear. Then you can relink the steps to that input and the workflow runs

Yeah that was another thing.. I hadn't updated the example workflows for the input order change, I did do that with the update now though.


Move from Dict->Keyword. Update Docs

Looks like the Dict module is deprecating. https://hexdocs.pm/elixir/Dict.html Changed usage from Dict to Keyword
Updated the Readme to link to hex docs (solves #11)
Updated the def input @doc to include another example that passes class to the input field.

:shipit:


Wrong color for successful snapshot creation?

Line 20 in tugboat/lib/tugboat/middleware/snapshot_droplet.rb states:
say "Snapshot successful!", :red

shouldn't that rather be:
say "Snapshot successful!", :green

Good point, should be quick to fix, will get a release out soon! :+1:


[C#] Migration Docs

Write a document outlining how developers can migrate their Bot SDK application to Teams AI Library app.
Areas

How to migrate the activity handlers from BF SDK over to Teams AI.
[Potential] Flow diagram that explains how an incoming request is routed. From the turn context being created, to state being loaded all the way to running the activity handler method/ai module to the point where state is stored back to the state. (i.e the OnTurnAsync method)
[Potential] Diagram for how the AI module works (i.e the ChainAsync method)

Partners building complex applications on top of the SDK will need clarity on the inner workings outlined in points 2 & 3.

https://github.com/microsoft/teams-ai/pull/357/files


Patch 1

Updated the url of an EMNLP2018 paper "The Importance of Being Recurrent for Modeling Hierarchical Structure" from an indirect websit to direct
Added a rejected(by ICLR2019) but insightful paper about Low-resource translation

Hi! Sorry for the late reply.
For 1: Thanks for noticing! I'll correct it soon;
For 2: Thanks for pointing out! Currently, however, we are inclined to add officially published papers only. I've read the rejected paper you mentioned, and I do think that it'll be accepted by some top conference in future. Let's wait it to be further improved; we'll add it as soon as it's accepted.
Again thanks for your support! Feel free to recommend more papers~

I'll open an issue to follow this ICLR2019 paper. Welcome to discuss it and recommend more papers there~ I'm closing this pull request now.


Mouse doesn't seem to work

The mouse was working then i made koko.yml and it stopped working.
app:
  scrollback-limit: 20000
  root-channel-name: '$'

user:
  nick: octocat
  username: octocat
  realname: octocat

servers:
  - name: Mozilla
    host: irc.mozilla.org
    port: 6667
  - name: Freenode
    host: irc.freenode.net
    port: 6667
~

Mouse interactions are not supported for the time being. I'll mark it as an enhancement.


Custom webpack.config linting

Has anyone had any using eslint-loader in the custom webpack.config? I have the following set up, however eslint-loader is not running
const path = require('path')

module.exports = {
  module: {
    preLoaders: [
      {
        test: /\.js$/,
        loader: 'eslint-loader',
        include: path.resolve(__dirname, '../'),
        exclude: path.resolve(__dirname, '../node_modules/')
      }
    ],
    loaders: [
      {
        test: /\.css?$/,
        loaders: [ 'style', 'raw' ],
        include: path.resolve(__dirname, '../')
      }
    ]
  }
}

May be it cant read the .eslintrc this way. See if you can can pass that in a different way.

@stewartduffy you can try passing the .eslintrc location explicitly
module.exports = {
  eslint: {
    configFile: '../.eslintrc'
  },
  module: {
    preLoaders: [
      {
        test: /\.js$/,
        loader: 'eslint-loader',
        include: path.resolve(__dirname, '../'),
        exclude: path.resolve(__dirname, '../node_modules/')
      }
    ],
  etc...

OK so looks like it is an issue with webpack preLoaders rather than eslint-loader.
This config works:
const path = require('path')

module.exports = {
  module: {
    loaders: [
      {
        test: /\.js$/,
        loaders: [ 'eslint-loader' ],
        include: path.resolve(__dirname, '../components/'),
        exclude: /node_modules/
      },
      {
        test: /\.css?$/,
        loaders: [ 'style', 'raw', 'eslint-loader' ],
        include: path.resolve(__dirname, '../')
      }
    ]
  }
}

this config does not work:
const path = require('path')

module.exports = {
  module: {
    preLoaders: [
      {
        test: /\.js$/,
        loaders: [ 'eslint-loader' ],
        include: path.resolve(__dirname, '../components/'),
        exclude: /node_modules/
      }
    ],
    loaders: [
      {
        test: /\.css?$/,
        loaders: [ 'style', 'raw', 'eslint-loader' ],
        include: path.resolve(__dirname, '../')
      }
    ]
  }
}

Looked into this more, can confirm that ti does not support preLoaders. Have made a PR https://github.com/kadirahq/react-storybook/pull/107 to add support for this.


Improved Auto Chooser

Improved the auto chooser with the following changes:

Added the ability to directly add commands to the chooser(implicitly calls factory.commandAsAutoRoutine())
Added the autoCmd() getter: which fetches a deferred command that runs the auto routine.  This allows the auto chooser to be easily used with RobotModeTriggers.autonomous(), like so:

AutoChooser chooser = ...
public Robot() {
    autonomous().whileTrue(chooser.autoCmd());
}

Can AutoFactory.commandAsAutoRoutine() be removed? As far as I know it is only provided to expose the functionality this PR adds to AutoChooser.

sry fps u probably have to run format; javaFmt still refuses to work on my computer for some reason

What is the status on this? Looking to wrap up #994 soon and this is currently blocking, unless we want to defer this PR till after the docs rewrite is merged.

Looks like the unit tests need fixing.

Looks like the unit tests need fixing.

im like almost done w/ them; NetworkTableEntry is being weird tho and idk why

Btw @calcmogul u probably have to re-enable auto-merge since new changes have been pushed


any example on xamarin.forms?

Note: for support questions, please ask on StackOverflow: https://stackoverflow.com/questions/tagged/reactiveui . This repository's issues are reserved for feature requests and bug reports.
Do you want to request a feature or report a bug?
What is the current behavior?
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem
What is the expected behavior?
What is the motivation / use case for changing the behavior?
Which versions of ReactiveUI, and which platform / OS are affected by this issue? Did this work in previous versions of ReativeUI? Please also test with the latest stable and snapshot (http://docs.reactiveui.net/en/contributing/snapshot/index.html) versions.
Other information (e.g. stacktraces, related issues, suggestions how to fix)

There are several examples in #687 including some very complete applications. Workout Wotch was a valuable resource for me personally. I'd also recommend this routing sample.

Try this one https://github.com/aalmada/reactive-dev-days-lab

Hopefully those samples are enough to get you going @koo9. We've also got more samples in the works, so stay tuned for them.


Fix tests

Thanks for this lib. Unfortunately I encountered errors while building. They are generated from the tests:
In file included from /Users/davidszakallas/Projects/demucs.cpp/vendor/eigen/unsupported/Eigen/CXX11/Tensor:133:
/Users/davidszakallas/Projects/demucs.cpp/vendor/eigen/unsupported/Eigen/CXX11/src/Tensor/Tensor.h:208:74: error: non-constant-expression cannot be narrowed from type 'unsigned long' to 'long' in initializer list [-Wc++11-narrowing]
    return operator()(array<Index, NumIndices>{{firstIndex, secondIndex, otherIndices...}});
                                                                         ^~~~~~~~~~~~
/Users/davidszakallas/Projects/demucs.cpp/test/test_layers.cpp:1566:28: note: in instantiation of function template specialization 'Eigen::Tensor<float, 3>::operator()<unsigned long>' requested here
                    xt_fake(i, j, k) = -1.0;
                           ^
/Users/davidszakallas/Projects/demucs.cpp/vendor/eigen/unsupported/Eigen/CXX11/src/Tensor/Tensor.h:208:74: note: insert an explicit cast to silence this issue
    return operator()(array<Index, NumIndices>{{firstIndex, secondIndex, otherIndices...}});
                                                                         ^~~~~~~~~~~~
                                                                         static_cast<long>( )
13 warnings and 1 error generated.

On my toolchain (AppleClang <IP_ADDRESS>00100 / arm64), size_t is unsigned long and cannot be narrowed to long as the error message says.

Thanks for the contribution! I'll be able to take a look soon and merge it.

lgtm!


feat: Define AnalyticManifold as a charted space compatible with analyticGroupoid

We already have the definition of analyticGroupoid, but not the corresponding manifold variant.  In finite dimensions these are equivalent to SmoothManifoldWithCorners, so an alternative option is to leave this out and prove the necessary correspondence via Osgood's theorem.
I also moved the definition of analyticGroupoid into the new AnalyticManifold file, since it's not used by SmoothManifoldWithCorners (or apparently anything else in Mathlib yet).

To foreshadow, the next thing I need to define is manifold-analytic maps.  Currently I have these defined at https://github.com/girving/ray/blob/be98efd5d2fb6dad741c905262a93bb9aa6eaf49/Ray/AnalyticManifold/AnalyticManifold.lean#L248 only in the boundaryless case, which means analytic in charts.
We’ll need to choose how to extend this to the boundaries.  The natural thing following analyticGroupoid is analytic on interior points and smooth at boundary points.  If we think that’s the right definition and do the refactor and make a follow up PR, but I’ll wait for discussion first.

I have to say that I don't really understand why we use this definition of analytic groupoid instead of the more direct definition "analytic at every point, including the boundary". Do you understand what the more complicated definition buys us?

No, I don't understand what the more complicated definition buys us.  I haven't seen it elsewhere in mathematics: it's common to want "analytic inside, continuous at the boundary", but smooth I haven't seen (and I think analytic inside, continuous at the boundary is better named something else).
If we want to do analytic at the boundary we need some additional definitions, though, since we don't have AnalyticAtWithin.  Though that is straightforward to write down: it's just "has a power series which matches the function within", or equivalently "is locally the restriction of an analytic function.  In either case, the definition would be downstream of AnalyticAt in a separate file.
I'd be happy to make that change if people think it's the right thing.

Here's the PR where it was added: https://github.com/leanprover-community/mathlib4/pull/6386.  I don't see discussion there of the smoothness part, but I may have just failed to expand the right comment thread.  Cc @michaellee94.

Thanks for the ping, @girving. I seem to recall having some difficulty with the pregroupoid definition when I tried to extend analyticity to the boundary (this was only my second PR, so I'm still a mathlib neophyte). If you have a working implementation, would love to take a look.

The sphere is https://github.com/girving/ray/blob/main/Ray/AnalyticManifold/RiemannSphere.lean, and any reasonable subset of an AnalyticManifold should be a submanifold (including the interval, for real analytic).
So from your perspective, if I can make AnalyticGroupoid work up to the boundary, that change is fine?

The sphere is https://github.com/girving/ray/blob/main/Ray/AnalyticManifold/RiemannSphere.lean

Very nice!

So from your perspective, if I can make AnalyticGroupoid work with analytic at the boundary, that change is fine?

Certainly

I've updated definition to require analyticity including on the boundary.  There are two main warts:

AnalyticWithinOn is an annoying name, but unfortunately it's not the same as the current AnalyticOn.
It is convenient in many of the proofs about analyticity within to use equivalence to a local extension being analytic.  But unfortunately this is only true if the space is complete, so a lot of the lemmas require completeness unnecessarily.

@grunweg https://github.com/leanprover-community/mathlib4/pull/13784 splits out the isolated lemmas.

The dependent PRs have been merged - I presume a good next step is to PR just AnalyticWithin (or perhaps split into even smaller chunks, if you think this is sensible).

@grunweg https://github.com/leanprover-community/mathlib4/pull/13971 is in, so this main PR should be unblocked! I think it's now small enough to not warrant splitting further into smaller sub-PRs.

@grunweg Sorry for the delay merging those; I missed the notification somehow.

@grunweg Are you still up for reviewing this, or we find a different reviewer?

Most comments addressed! I'll await replies to the last two.

@grunweg I fixed the commit message.


Support Snap CI

Hi. I've implemented #471.
Snap CI is
https://snap-ci.com
Thanks.

Thanks for contributing!
I'm not a big fan of SVG scraping, as changing the image asset can break this, so if you can improve on this by asking Snap CI to provide an API, it would be great!
Just to be clear, I will merge this once you've answered the review.

Thanks review! I'll fix these problem point.

I'm not a big fan of SVG scraping, as changing the image asset can break this, so if you can improve on this by asking Snap CI to provide an API, it would be great!

Exactly, I looked for Snap CI API but not found. I want to use Snap CI API too!

@espadrine Fix indicated points by PR. Thanks!

@espadrine Fix indicated points, and merged upstream/master. Thanks!

Thanks a lot for contributing!

Thanks!!


[stable/external-dns] invalid value for spec.clusterIP on 0.5.3 upgrade

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
BUG REPORT
Version of Helm and Kubernetes:
Helm 2.8.1 and k8s 1.9.6/1.7.3 (same error, different clusters)
Which chart:
external-dns
What happened:
Without changing any user defined values, upgrading from 0.5.2 to 0.5.3 fails with this when the service.clusterIP setting is not customised:
Error: UPGRADE FAILED: Service "external-dns" is invalid: spec.clusterIP: Invalid value: "": field is immutable

What you expected to happen:
Upgrade from 0.5.2 to 0.5.3 to succeed when values set by the user have not changed.
How to reproduce it (as minimally and precisely as possible):

Install external-dns chart 0.5.2 without customising service.clusterIP
Try to upgrade to 0.5.3 with the same options, upgrade fails

Anything else we need to know:
v0.5.3 changed this in https://github.com/kubernetes/charts/pull/4377. I think that PR might resolve going from a set value back to default (empty string) but something might be validating a different situation of empty string to not set?
Workaround:
Pin version to 0.5.2 for now.

I have the same issue with chart version 0.6.0

And 0.6.1

We continue to have this issue as well.  We cannot update external-dns and must purge and re-deploy.

Getting this again upgrading from chart v0.5.2 to v1.0.2. I do not have anything set for service.clusterIP, k8s v1.11.4 and Helm 2.9.1.

Tried with Helm 2.11.0 but same result. A rollback also fails with the same error now it's in that state. The only way to get out of that situation appears to be running helm upgrade with the --force flag.

Also weirdly after successfully upgrading with --force, running the exact same upgrade command again but without the force fails with the spec.clusterIP error.
That led me to think perhaps the Tiller state was somewhat inconsistent or causing the failure. So I deleted the install with helm delete external-dns-master --purge and then re-installed. Now the same upgrade command as before consistently succeeds. So it seems that theory about the Tiller store state affecting this was accurate.
Summary - if you are having this problem I recommend to delete/purge this chart install and reinstall.


Error when trying to import shouldUpdate

Hey,
I'm getting the following error when trying to import shouldUpdate:
Failed to compile.

Error in ./~/incompose/dist/withLifecycle.js
Module not found: 'inferno-create-element' in /Users/.../node_modules/incompose/dist

 @ ./~/incompose/dist/withLifecycle.js 14:28-61

Any ideas?
Thanks

Hi @gilesbutler
Yes, this is an unmet dependency which i have to fix.
Pls run npm install --save inferno-create-element or yarn add inferno-create-element.
This should fix it.
Sry for the inconvinience!

Great thanks @zanettin

Thanks for the super fast response too ;)

you're welcome 😄  happy incomposing 👍

@gilesbutler just launched v.0.0.10 which should fix this issue. can you please upgrade to the latest version, remove inferno-create-element from your package.json and run rm -rf node_modules && npm i on your app root?
if you're using yarn and working on a demo app, pls remove also the yarn.lock file 👍


feat: add sources

This was a PoC but we decided to get source information from the chart repo and the chart.yaml


Cannot be started minimized on Windows

I would like to start Joal Desktop minimized at Windows startup but it seems not possible.
I am currently using the joal CLI application with this command.
Start-Process "java.exe" -ArgumentList "-jar `"$env:LOCALAPPDATA\Programs\joal\jack-of-all-trades-2.1.24.jar`" --joal-conf=`"$env:LOCALAPPDATA\Programs\joal\joal-conf`" --spring.main.web-environment=true --server.port=9080 --joal.ui.path.prefix=`"aaabbbcccdddeee`" --joal.ui.secret-token=`"abcde`"" -WindowStyle Minimized

But it would be great to make this possible for the desktop application as well. ;)

Nice idea indeed.
I'll try to implement that for the next version

Any update on @anthonyraymond

@rajeevverma076 i'm rewriting the program from scratch, but i will take some time :)

Will be a great improvement. Thanks


⚠ Mobitopup has degraded performance

In 07edaf8, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 4376 ms

Resolved: Mobitopup performance has improved in 90e5d79 after 51 minutes.


Extend caching and pooling for better performance

Implement cache for MemberWrappers
Implement object pool pattern for child YAXSerializers
Rename TypeWrappersPool to UdtWrapperCache (that's what it actually is)
Re-use a cached instance for ICustomSerializers instead of invoking a new instance repetitively. This could also increase usability of customer serializers

Cool stuff. But is there a max cache size? Or what happens if there is a memory shortage?

Yes otherwise you could get  memory leaks or out of memory issues.

Ah, yeah, didn't consider this. I'll take a deeper look. My first idea was a First-in/First-out when reaching max. size.
(Existing type cache is also implemented as simple dictionary.)

Just ported https://github.com/NLog/NLog/blob/dev/src/NLog/Internal/Collections/MruCache.cs - looks good. I think I'm gonna go for that😉

@304NotModified Just checked the number of recursions that happen across all unit tests and using method YAXSerializer.NewInternalSerializer
With every counted recursion, a new YAXSerializer is created and later discarded (set to null) in FinalizeNewSerializer.
A YAXSerializerPool might bring a gain in speed and less GC pressure, wouldn't it?
Group             Count
9 Recursions =   110168
8 Recursions =      326
7 Recursions =     2293
6 Recursions =      126
5 Recursions =      963
4 Recursions =       26
3 Recursions =       52
2 Recursions =      168
1 Recursion  =     1106

Total Count  =   115228

Got it working with an YAXSerializer object pool.
Results are promising - about 6x faster with 6x less GC pressure compared to the current v4 branch:
|                    Method |    N |      Mean |    Error |   StdDev |     Gen 0 | Allocated |
|-------------------------- |----- |----------:|---------:|---------:|----------:|----------:|
| NoPool_NoWrapperCache_V4  |  500 |  83.19 ms | 0.941 ms | 0.834 ms | 4000.0000 |     35 MB |
| NoPool_NoWrapperCache_V4  | 1000 | 164.48 ms | 1.682 ms | 1.573 ms | 8000.0000 |     71 MB |
|-------------------------- |----- |----------:|---------:|---------:|----------:|----------:|
| With_Pool_WrapperCache    |  500 |  14.12 ms | 0.281 ms | 0.438 ms |         - |      6 MB |
| With_Pool_WrapperCache    | 1000 |  28.84 ms | 0.561 ms | 0.690 ms | 1000.0000 |     13 MB |

Cache and Pool both have limits in size now. Actually, the pool is rather small: only 12 items across all unit tests, but used with a high frequency.


Showing Text on BeyondAr Object

Is it possible to show content (Text), instad of an image?
I am Woring on a google glass project. BeyondAr objects are loaded successfully, however i want to show as default(not when i click/touch beyondAr Onject) some content (ex: name or title of the object) instead of an image. How can i achieve that?

You could attach a view or convert a view to an image.
See https://github.com/BeyondAR/beyondar/blob/master/android/BeyondAR_Examples/src/com/beyondar/example/AttachViewToGeoObjectActivity.java
https://github.com/BeyondAR/beyondar/blob/master/android/BeyondAR_Examples/src/com/beyondar/example/StaticViewGeoObjectActivity.java


print alias of a repo during "cm repo list"

Fixed https://github.com/octoml/cm/commit/c584321d3827315f66f7bcef287ebd900c345f52


Issue/17 fix timezone issues

Description
The helper to get actions from the server wasn't compatible with older version of the orchestrator (if the orchestrator or the client was still using timezone unaware datetime objects).
This is now fixed.
Closes #17

It looks like you committed differently than the normal procedure. Don't forget to add the release tag manually when you merge.


⚠ Bofrost.es has degraded performance

In dcf66d2, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1475 ms

Resolved: Bofrost.es performance has improved in 3b07eac after 14 minutes.


Support minimum array length constraint

What are the steps to reproduce this issue?

open api spec with this parameter:

- in: query
        name: ids
        schema:
          type: array
          minItems: 1
          items:
            type: string

run orval on the spec

What happens?
The minItems length constraint is not enforced in any way.
What were you expecting to happen?
I was expecting there to be some way to enforce that minimum length. Orval could possibly generate something like this to enforce the typing:
type arrMin1Str = [string, ...string[]]; // The minimum is 1 string.
Any logs, error output, etc?
…
Any other comments?
…
What versions are you using?
Operating System: MacOS Ventura 13.2.1
Package Version: 6.16.0
Browser Version: 114.0.5735.106

This is handled with Zod validation in the next release with this PR: https://github.com/anymaniax/orval/pull/1052


Fixes issues where schemaless tagging component was permanently uneditable

v1

Previously, editing was done with a wizard, but we moved to allowing each component in dataset compliance tab to be individually editable. However, this change did not incorporate the scenario in which a dataset was schemaless.
We now give this component the same UX as the purge policy or export policy edits
Also taking the chance to isolate most functionality in the component rather than depending on the parent dataset-compliance complex component.

ember test results
1..507
# tests 507
# pass  500
# skip  7
# fail  0

# ok

Codecov Report

Merging #1371 into master will increase coverage by 0.2%.
The diff coverage is 85.71%.

@@            Coverage Diff            @@
##           master    #1371     +/-   ##
=========================================
+ Coverage    58.9%   59.11%   +0.2%
=========================================
  Files         181      181
  Lines        3840     3852     +12
  Branches      853      857      +4
=========================================
+ Hits         2262     2277     +15
+ Misses       1578     1575      -3

Impacted Files
Coverage Δ

...-web/app/components/datasets/schemaless-tagging.ts
83.87% <85.71%> (-16.13%)
:arrow_down:

wherehows-web/app/utils/api/datasets/schema.ts
83.33% <0%> (-16.67%)
:arrow_down:

wherehows-web/app/utils/api/datasets/compliance.ts
68.42% <0%> (-5.27%)
:arrow_down:

...mponents/datasets/containers/dataset-compliance.ts
37.86% <0%> (+1.94%)
:arrow_up:

wherehows-web/app/utils/array.ts
81.48% <0%> (+33.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67ccb31...5942256. Read the comment docs.

Coverage remained the same at 23.111% when pulling<PHONE_NUMBER>1a7139161951310b94a2ab51c88f9b on cptran777:schemaless-tagging-fix into 67ccb31c652b5670f29ca8f7138e8e7190e79650 on linkedin:master.


[dontmerge] Debug Info: Encode Archetype names in DWARF

Currently LLDB calls into ide::getDeclFromMangledSymbolName() to get
to this information and we would like to get rid of this call.
rdar://problem/47798056

@swift-ci test

Sorry for the inconvenience but do you mind rebasing this on top of https://github.com/apple/swift/pull/22252 ? We really only need names for top-level generic parameters; dependent member type names are part of the mangling and don't need to be recorded here.

Build failed
Swift Test Linux Platform
Git Sha - 587ada2aa631477ef805b8a9d976db3e24da8ed9

Build failed
Swift Test OS X Platform
Git Sha - 587ada2aa631477ef805b8a9d976db3e24da8ed9

test with https://github.com/apple/swift-lldb/pull/1318
@swift-ci test

@slavapestov I think rebasing this on #22252 or vice versa shouldn't be hard at all so the order in which we land these probably doesn't matter too much.

Build failed
Swift Test OS X Platform
Git Sha - 3b7353a2a71f21887341cc829b7645f0bee32549

test with https://github.com/apple/swift-lldb/pull/1318
@swift-ci test

Build failed
Swift Test Linux Platform
Git Sha - 3b7353a2a71f21887341cc829b7645f0bee32549

Linux test failed because a Foundation test failed, which is likely unrelated to this patch.

test with https://github.com/apple/swift-lldb/pull/1318
@swift-ci test


Support for compiling own (test) code with Groovy 4.0

Expected Behavior
Gradle should allow to use Groovy 4 to compile Groovy code (just compile my code, NOT to use Groovy 4 to build Gradle).
Current Behavior
Due to changing the groupId in Groovy 4 from org.codehaus.groovy to org.apache.groovy, Gradle is not able to properly find and use Groovy 4 JARs.
Context
As a Spock developer, I would like to be able to check if Spock 2 works properly with Groovy 4 (even with just 4.0.0-SNAPSHOT) to provide feedback for the Groovy team. Unfortunately the compilation is not possible due to limitations in Gradle:
> Task :compileGroovy FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileGroovy'.
> Could not resolve all files for configuration ':detachedConfiguration1'.
   > Could not find org.codehaus.groovy:groovy:4.0.0-SNAPSHOT.
     Searched in the following locations:
       - https://repo.maven.apache.org/maven2/org/codehaus/groovy/groovy/4.0.0-SNAPSHOT/maven-metadata.xml
       - https://repo.maven.apache.org/maven2/org/codehaus/groovy/groovy/4.0.0-SNAPSHOT/groovy-4.0.0-SNAPSHOT.pom
       - https://oss.jfrog.org/artifactory/oss-snapshot-local/org/codehaus/groovy/groovy/4.0.0-SNAPSHOT/maven-metadata.xml
       - https://oss.jfrog.org/artifactory/oss-snapshot-local/org/codehaus/groovy/groovy/4.0.0-SNAPSHOT/groovy-4.0.0-SNAPSHOT.pom
     Required by:
         project :
   > Could not find org.codehaus.groovy:groovy-ant:4.0.0-SNAPSHOT.
     Searched in the following locations:
       - https://repo.maven.apache.org/maven2/org/codehaus/groovy/groovy-ant/4.0.0-SNAPSHOT/maven-metadata.xml
       - https://repo.maven.apache.org/maven2/org/codehaus/groovy/groovy-ant/4.0.0-SNAPSHOT/groovy-ant-4.0.0-SNAPSHOT.pom
       - https://oss.jfrog.org/artifactory/oss-snapshot-local/org/codehaus/groovy/groovy-ant/4.0.0-SNAPSHOT/maven-metadata.xml
       - https://oss.jfrog.org/artifactory/oss-snapshot-local/org/codehaus/groovy/groovy-ant/4.0.0-SNAPSHOT/groovy-ant-4.0.0-SNAPSHOT.pom
     Required by:
         project :
   > Could not find org.codehaus.groovy:groovy-templates:4.0.0-SNAPSHOT.
     Searched in the following locations:
       - https://repo.maven.apache.org/maven2/org/codehaus/groovy/groovy-templates/4.0.0-SNAPSHOT/maven-metadata.xml
       - https://repo.maven.apache.org/maven2/org/codehaus/groovy/groovy-templates/4.0.0-SNAPSHOT/groovy-templates-4.0.0-SNAPSHOT.pom
       - https://oss.jfrog.org/artifactory/oss-snapshot-local/org/codehaus/groovy/groovy-templates/4.0.0-SNAPSHOT/maven-metadata.xml
       - https://oss.jfrog.org/artifactory/oss-snapshot-local/org/codehaus/groovy/groovy-templates/4.0.0-SNAPSHOT/groovy-templates-4.0.0-SNAPSHOT.pom
     Required by:
         project :

It seems that Gradle has org.codehaus.groovy hardcoded that this causes that even there is org.apache.groovy:groovy:4.0.0-SNAPSHOT as a dependency, it tries to find org.codehaus.groovy:groovy:4.0.0-SNAPSHOT (also groovy-ant and groovy-template) with wrong groupId which doesn't exist.
Sample configuration from generated Gradle project (in Kotlin to do not complicate with Groovy as the DSL language :) ):
plugins {
    groovy
    `java-library`
}

repositories {
    mavenCentral()
    maven { url = uri("https://oss.jfrog.org/artifactory/oss-snapshot-local/") }
}

dependencies {
//    implementation("org.codehaus.groovy:groovy:3.0.4")
    implementation("org.apache.groovy:groovy:4.0.0-SNAPSHOT")

    testImplementation("org.spockframework:spock-core:2.0-M3-groovy-3.0") {
        exclude(group = "org.codehaus.groovy")  //to eliminate "old" 3.x groovy.jar
    }
}

tasks {
    withType<Test>().configureEach {
        useJUnitPlatform()
    }
}

(it is expected to have this failing due to Spock and Groovy version mismatch, but it is possible to disabled the check with -Dspock.iKnowWhatImDoing.disableGroovyVersionCheck=true, so this has a chance to work - once Gradle will be able to find Groovy 4 with its changed groupId).
GitHub: https://github.com/szpak/code-examples-and-poc/blob/master/groovy4-gradle-kotlin/build.gradle.kts
As I was talking with Paul King recently, there are no plans to change also package for Groovy 4 (which would be even more problematic).
Tested with Gradle 6.5.

Thanks for the report. Would be nice if Groovy as part of this change adopted Gradle Module Metadata, because it would allow users to be notified if they use both Groovy at old coordinates and new coordinates in a single graph, but that's off topic.

This issue should be something pretty self contained and to be fixed in a few classes only. So it is a good issue to pick if you are interested in contributing to Gradle.

GroovyJarFile might be a good starting point for such an investigation

Mind if I give this one a go?

For me, feel free to take it. It would be a great to have it implemented before the first Groovy 4 (alpha) version is tagged and published.

Thanks @Miehau!

@melix Don't you think, it would be good to mention it to the "Fixed issues" section in the release notes for Gradle 4.7?
(I don't see it for 6.7-rc-2, maybe the tag is missing).

Thanks for noticing and asking. I have added the tag reference to this issue. It will show up in the 6.7 fixed issue list.


Dynamically change language on composer bot based on user input in multilingual bot

I am creating a multilingual bot but i need to change language based on user input , i am displaying him the choices of language in which he can chat. My bot is deployed on Microsoft Teams
Things i have tried:-

I tried setting turn.activity.locale = es (spanish) but this works only for one turn.
If i change the Teams interface language to spanish from settings then it work s fine in spanish .
But i don;t want user to change language of interface every time they want to speak to bot in their native language.

Describe the solution you'd like
Be able to dynamically select the language in chatbot based on user input.

Describe alternatives you've considered
Things i have tried:-

I tried setting turn.activity.locale = es (spanish) but this works only for one turn.
If i change the Teams interface language to spanish from settings then it work s fine in spanish .
But i don;t want user to change language of interface every time they want to speak to bot in their native language.

Additional context

Hi @tushaar9027 --  Thanks, looking into this issue.

Hi @tushaar9027
thanks for your patience, we do not currently have a composer sample demonstrating dynamically change language based on user input.
I found this issue in regards to translation in composer middleware pipeline to possibly achieve this.
Hopefully this helps. https://github.com/microsoft/BotFramework-Composer/issues/3514
I am closing this one for now. If further assistance is required, please direct usage questions to Stack Overflow with the #botframework tag: https://stackoverflow.com/questions/tagged/botframework


Would it please be possible to tag/release new versions?

Hello,
The latest tag here on Github is 0.9. The latest version, from the CMakeLists.txt file, however is 2.1.0. Would it please be possible to tag/release the new versions? It just makes it easier for us to package nmodl downstream at NeuroFedora.
Cheers,

I try to push tag following CMakeLists.txt but dates are weird: https://github.com/BlueBrain/mod2c/tags

Thanks, the dates indeed are odd---perhaps the git history was a bit messed up?

@sanjayankur31  : we stopped tagging releases on this repo because this is now used as submodule inside CoreNEURON (and not supposed to be installed independently).
We are moving to new code generation framework https://github.com/BlueBrain/nmodl and hence very little changes to this repository.

@pramodk : yes, I noticed that. The issue with the submodule system, at least with Github, is that they're not included in the Github generated release/tagged tars (or weren't the last time I'd checked). This means that all downstream users have to manually download the tars from the different sub-module projects and then extract them in the right places, and it just makes it easier if tagged versions are used in CoreNeuron so that users can go fetch them without having to figure out what commit of the sub-module is used and fetch that from GitHub etc.
Is nmodl also similar then, and only to be used with CoreNeuron, and not as a standalone tool/library?

I think that we always build after a clone (maybe shallow), and never from a tarball. That's why we didn't see this problem.

@alkino  is right!

Is nmodl also similar then, and only to be used with CoreNeuron, and not as a standalone tool/library?

NMODL is generic purpose tool and used outside CoreNEURON. So definitely we will releases regularly (new one soon).


Request to update versions of hibernate-core & org.apache.httpcomponents:httpclient for Dropwizard v1.3.25

Hi,
In order to absorb fixes for CVE-2019-14900 and CVE-2020-13956, could you please upgrade the versions of below dependencies for Dropwizard version 1.3.25 and release a patch?

hibernate.core to 5.3.18/5.4.18

org.apache.httpcomponents.httpclient to 4.5.13

My organization is still on Dropwizard version 1.3.25 and is not ready yet for a major version upgrade to Dropwizard version 2.0.13 that uses 5.4.18 version of hibernate-core.
Note: Dropwizard version 2.0.13 still uses org.apache.httpcomponents.httpclient version 4.5.12 which is vulnerable

@sagarkal Thanks for reporting this!
We can do a version bump for Apache HttpClient in the Dropwizard 1.3.x version line to address CVE-2020-13956.
However, we won't do an upgrade to Hibernate 5.3.x or 5.4.x in Dropwizard 1.3.x and we're already on the latest Hibernate 5.2.x release (5.2.18), so if you want to get a resolution for CVE-2019-14900, you either have to upgrade to Dropwizard 2.0.x or fork Dropwizard Hibernate 1.3.x and upgrade the version of Hibernate yourself.

Hi Josh,
Thanks. I'll discuss about migrating to Dropwizard 2.0.x in that case. Do you plan to do a version bump for Apache HttpClient in Dropwizard 2.0.x as well?

Do you plan to do a version bump for Apache HttpClient in Dropwizard 2.0.x as well?

Yes, the next release of Dropwizard 2.0.x will contain the latest version of Apache HttpClient 4.5.x.
Closing this ticket since the update has been addressed in #3516.

Ok thanks, any estimate date on the next release of Dropwizard 2.0.x?

@sagarkal v2.0.14 was released earlier this morning, which includes the update to Apache HttpClient


chore: change skeleton text for partners so as to not refer to a specific gallery

Description
I noticed when loading a partner screen in Android the text Gagosian Gal flash up for 2-3 seconds until the actual gallery name populated. That would annoy me greatly if I was a gallery. As a user it was merely confusing. This just changes the placeholder text to not refer to a specific gallery.

Warnings

:warning:

❌ An error occurred while validating your changelog, please make sure you provided a valid changelog.

  Generated by :no_entry_sign: dangerJS against 8413e4316620ecea7130896ef7d15a64719bfa13


Extend date range to cover "end/beginning/middle of $year" in English

Modified LaterEarlyPeriodRegex in English to also match years;
Added clauses to BaseDatePeriodParser to resolve correctly;
New test specs.

PS: in this PR, model don't support "since/from the end of $Year"


[bug report] add failing tests that call 2-arg str() in USDT

This is rather a bug report with failing tests instead of a patch to fix problems.
Environment

Ubuntu 20.04.1 / Kernel 5.4.0-58-generic
bpftrace 0f7cd742cb2f71426e07d21f27d550e6a12c2387 (latest as of Jan 8 2021)

Problems
str(arg0, arg1) does not work in USDT, where arg0 is const char* and arg1 is size_t in the target C program.
To be exact, given const char* s = "..." and size_t s_len = strlen(s) in the C program, emitting an event with DTRACE_PROBE2(test, probe1, s, s_len), and the bpftrace script is something like this:
usdt:./testprogs/usdt_call_str_2:test:probe1 {
  printf("<%s>\n", str(arg0, arg1));
  exit();
}

It results in <>, where it is expected to be <hello> (NAME "usdt call 2-arg str()" ).  If the second arg is converted to int in the C program, it passes (NAME "usdt call 2-arg str() with int" ).
Also, printf("<%s>\n", str(arg0, (int32)arg1)); fails with assertion failure, as the test script includes (NAME "usdt call 2-arg str() with cast" ).
How to reproduce this problem
See the diff in the PR.

Hi, thanks for the report. We prefer to keep the PRs to reviewable code so I've copied the issue into https://github.com/iovisor/bpftrace/issues/1672 .

Hi, thanks for the report. We prefer to keep the PRs to reviewable code so I've copied the issue into https://github.com/iovisor/bpftrace/issues/1672 .

Sorry for bothering you, and thanks.

Sorry for bothering you, and thanks.


Updated Repo for Compatibility w/ DANDI

Fixes #18

This PR should now address all the best practice critical/violations/suggestions from nwbinspector EXCEPT

check_roi_response_series_link_to_plane_segmentation but see nwbinspector Issue
check_single_row for fluorophores and photodetectors, but there's only 1 fluorophore and 1 photodetector used in these experiments so I think it's fine.

I also moved the example nwbfile to inside this github repo.  I know it's generally better practice to keep large data files separate, but this one session is only ~3MB, and it seems handy to have a version-controlled example file for inspection.

I also moved the example nwbfile to inside this github repo. I know it's generally better practice to keep large data files separate, but this one session is only ~3MB, and it seems handy to have a version-controlled example file for inspection.

Please remove that and continue to share it outside the repo
If email is too inconvenient, we can use either a shared Google Drive, Dropbox, or the 'catalystneuro-processing' S3 bucket (which I believe you have credentials to access?), or TBH at this point we are good to upload any draft files to the actual DANDI set
Reason: The current size of the entire datta-lab-to-nwb history is 2.6 MB by my calculation, with the largest file by commit being ~10 KB. The point is not that the literal size of the file is only 3 MB (though that is also excessive to more than double a repository size just for that), but rather the bad practice is the precedence for establishing version control for that item in the first place, which would inflate the repo size by that file size multiplied by the number of individual commits changing that file.
The only files we've ever made an exception for in that regards are NWB files that are on the order of single-double digit KB and so are practically indistinguishable from the text files they live next to
With regards to your ideas for a CI - the action itself would handle data transfer from source to cache, which is fine because those logs are not version controlled and are even cleared automatically every couple of months
Note to self: do not forget to squash this PR so that it gets purged from the history

Ok, I removed the nwbfile, so this should be good to merge now.  I will look into some of the alternative solutions we discussed (ex. CI streaming from DANDI) when I get a chance, but probably not until after 6/26/23.

Note to self: do not forget to squash this PR so that it gets purged from the history
Don't forget!