[AST] NFC: Rename getOrBoundGeneric to be clearer and shorter

The get*OrBoundGeneric* methods are, in practice, simple getters that extract a Decl node. Let's rename the APIs accordingly and make them shorter at the same time. This is similar to the DeclContext changes made by Jordan Rose in: 537954fb9338951ce94dbe8549bbc7f0e2b1395f

getNominalOrBoundGenericNominal -> getNominalDecl
getStructOrBoundGenericStruct -> getStructDecl
getClassOrBoundGenericClass -> getClassDecl
getEnumOrBoundGenericEnum -> getEnumDecl

This is purely a mechanical change.

@swift-ci please smoke test

Oh, of course LLDB needs an update. How does one tell CI to test two pull requests together again?

@davezarzycki I think you can do it like this:
[apple/swift-lldb#<NUMBER>](https://github.com/apple/swift-lldb/pull/NUMBER)
@swift-ci Please smoke test

Hm. The distinction between getNominalDecl and getAnyNominal is way too subtle at this point, but I don't know if we actually care about treating unbound generic types differently either. Maybe we can unify those. @DougGregor, @slavapestov, thoughts?
Stepping back, getClassDecl seems a little weird to me when we don't know that the Type is a class-related type at all yet, but I'll probably be able to live with that.
Suyash is correct about cross-repo testing, though GitHub will automatically link anything in the org/repo#PRNUM format, so you don't have to write the link yourself.

P.S. I only bring up the getAnyNominal / getNominalDecl thing because it affects naming. Right now those names are too similar for my tastes; if we can just drop one of them then everything's fine, but if we want to keep both then I'm concerned about us not being consistent. (We're probably already not consistent.)

Hi @jrose-apple – As it turns out, only two tests and one fixed compiler crasher regressions occur when all uses of getNominalDecl are replaced with getAnyNominal. This seems like the path to pursue. I'll try and break this into two commits. One mechanical search and replace, and then one that deals with the subtle difference between the two APIs (where unbound generic decls are ignored or not).
As a tangent, why did you drop the word "as" from the API names in 537954fb9338951ce94dbe8549bbc7f0e2b1395f? To me, getExample and getAsExample read very differently. The former retrieves a value, whereas the latter is a dyn_cast wrapper.

https://github.com/apple/swift-lldb/pull/1324
@swift-ci please smoke test
@jrose-apple – I've addressed your concern. :-)

https://github.com/apple/swift-lldb/pull/1324
@swift-ci please smoke test

https://github.com/apple/swift-lldb/pull/1324
@swift-ci please test platform

As a tangent, why did you drop the word "as" from the API names in 537954f? To me, getExample and getAsExample read very differently. The former retrieves a value, whereas the latter is a dyn_cast wrapper.

Most of those are not dyn_cast wrappers, because they work on extensions too. That's why the "Self" is in the names. Maybe it should have been getSelfTypeClassDecl instead of just getSelfClassDecl, but (a) that's longer for not that much extra benefit, and (b) there was a getAsTypeOrTypeExtensionContext to rename, and that would have turned into getSelfTypeTypeDecl. getAsDeclOrDeclExtensionContext did go to getAsDecl.
I do still want someone else's opinion on whether the unbound thing is significant.

This sounds good. Ideally we would unify FooType and BoundGenericFooType though. There's no reason to have the distinction at all.

This sounds good. Ideally we would unify FooType and BoundGenericFooType though. There's no reason to have the distinction at all.

I think that unification is well beyond the scope of this pull request though.

Poke. Might somebody review this? In particular, @jrose-apple has a concern about the subtle difference between getAnyNominal and getNominalOrBoundGenericNominal being lost. In practice, only one caller needed updating, but the concern is reasonable.

As someone who is relatively new to this source base, I find that the longer method names help me learn the code. So, I would not favor this change, unless the current names are inaccurate.

Hi @davidungar – I never cared much for the getFooOrBoundGenericFoo. To me, it either reads like it is returning a pointer union of Foo and BoundGenericFoo (which it does not), or it reads like "please return a Foo, and if necessary, do the work to bound up a generic one" (which is also not the case). If one doesn't mind a mouthful of an API name, then getFooDeclIfFooTypeOrBoundGenericFooType would be accurate.

Ping? Any review would be nice. Thanks!

@DougGregor, @rjmccall, @slavapestov, @jrose-apple – Ping.
I had hoped that the precedented clean up in 537954fb9338951ce94dbe8549bbc7f0e2b1395f by @jrose-apple would make this a simple thumbs up / thumbs down review. Should I just abandon this change? If so, then why?

@slavapestov, was your response an actual "it's okay to unify getNominalOrBoundGenericNominal with getAnyNominal", or are you still waiting for someone else to confirm that?
(I think "the planned names here increase the chances of confusion in an already confusing space because of the existence of getAnyNominal; we should get rid of that first if possible" is a valid line of reasoning. But someone needs to confirm or deny that "possible".)

@davezarzycki Sorry I didn't see your comment to me before! I like the longer names you suggested: such as getFooDeclIfFooTypeOrBoundGenericFooType, but I'm sure I'm in a minority here. Is there some deeper purpose to these functions that would yield an intension-revealing name?

@slavapestov, was your response an actual "it's okay to unify getNominalOrBoundGenericNominal with getAnyNominal", or are you still waiting for someone else to confirm that?

@jrose-apple – I was waiting for someone to click "reviewed".

(I think "the planned names here increase the chances of confusion in an already confusing space because of the existence of getAnyNominal; we should get rid of that first if possible" is a valid line of reasoning. But someone needs to confirm or deny that "possible".)

Right. From the commit message and comments in this thread, I think I addressed this. Now both getNominalOrBoundGenericNominal and getAnyNominal are replaced with getNominalTypeDecl.

@davidungar – I don't think there is any deep purpose to these methods. They're just convenience methods so that do one or two dynamic casts and then a "getDecl" call if the dynamic cast succeeds, therefore "getClassDecl" (etc) are reasonably apt names.

@davezarzycki Thanks. OK, sigh... The name issue is probably a symptom of a potential clean-up in the architecture. Anyway, it looks like they can return null.
How would you feel about a name ending in IfAny? It could maybe prevent a radar in the future. (I realize that DOxygen comments should also mention this fact, but a name is visible without an extra action.)

Hi @davidungar – What problem does the IfAny suffix solve? Where is the precedent?

@slavapestov, was your response an actual "it's okay to unify getNominalOrBoundGenericNominal with getAnyNominal", or are you still waiting for someone else to confirm that?

@jrose-apple – I was waiting for someone to click "reviewed".

Sorry, this was a question for Slava, not you.

@davezarzycki The "IfAny" suffix alerts the reader, or the user of the method that the result may be null. It's a poor man's substitute for those lovely optional types in Swift, which were one of the reasons I fell in love with Swift. We have llvm::Optional for values, but for pointers tend to follow the old way of just leaving the distinction between may-be-null and will-never-be-null implicit.
I would like it even more if we used llvm::Optional for pointer values which may be null. That would be even better. Swift incorporates many ideas which help make large programs more maintainable and this is one. I have noticed that our code base seems to be less accessible and more brittle (at least to me) than I would have hoped, and I believe that, now that the project is mature it is time to move the needle a bit in favor of maintainability and malleability. For example, I recently learned that we have four different implementations of name lookup, none of which is completely correct. I have also seen micro-optimizations that diffuse the invariants for little gain. In general--and I am as guilty of this as the next person--there seems to be too much "what" and not enough "why" in our code.
Folks who've grown up with llvm and the Swift compiler (as I assume you have) might have a hard time realizing what it is like to bring someone new onboard to the point where the newbie can confidently make changes and enhancements. But we need to be able to do that.  I like to think that because I am not familiar with the code base, but have other experience with fairly large systems and language implementations, I can offer a perspective that can be useful.
I like to think of the four-in-the-morning test: anything a language or IDE can do to help you keep being productive at 4 am is a good thing. Maybe that idea helps explain why I favor more informative, intention-revealing function names.

@davidungar There is such a thing: https://github.com/apple/swift/blob/master/include/swift/Basic/NullablePtr.h

Hi @davidungar – I'm sympathetic your points, but as the author of this pull request I'm not looking to change Swift compiler conventions (which largely follow LLVM conventions, which largely follow C/C++ conventions). I just want shorter/clearer names, and I wouldn't have proposed anything if I hadn't seen @jrose-apple rename a bunch of wordy DeclContext APIs.
Also, I am more recently new to the swift compiler code than you might think, despite having joined the Swift project from its inception at Apple. (At the time, I focused on the runtime/stdlib bootstrap, management of a team, and I only dabbled in compiler source changes, often the lexer/parser.) As a C/assembly programmer without formal education, I also found many parts of LLVM/Swift source to be overwhelming — but that would be true of joining any large project and any education. To the credit of LLVM and derived projects like Swift, I think they make a valiant effort to be approachable given the complexity of the subject area. Nevertheless, learning the various subsystems and conventions of any large project simply takes time and there aren't any serious shortcuts (other than being able to walk down a hallway and ask a question directly from an expert).
In any case and as I wrote above, I'd like to limit the subject of this pull request to a simple, non-convention changing rename. Thanks for understanding.

Thanks, @davezarzycki . Sorry I didn't see your response sooner; my email filtering is flawed. I understand your reluctance to (as I see it) improve the culture. (Others will surely disagree with me, anyway.)  Anyway, since I'm not a reviewer, I don't have to go on record one way or the other! There are a few "ifAny"s in the compiler already, probably all mine. Would love to sit down with you sometime over coffee and brainstorm ways to improve the accessibility of this code base. Good luck with this PR!

Ping. Hi @slavapestov – I'm still waiting for your input and response to @jrose-apple's question here: https://github.com/apple/swift/pull/22853#issuecomment-473985059

@gottesmm Thanks! I will be using NullablePtr.h as I move forward with my own code.

Closing due to lack of the interest/responses by the reviewers.


Sof 856/kommentator view not triggering shortcuts

Instantiates a TriggersHandler when having onlyShelf.
Shelf component listens for soft take.

Codecov Report

Merging #131 (64ea071) into staging (4704de9) will increase coverage by 33.26%.
The diff coverage is n/a.

:exclamation: Current head 64ea071 differs from pull request most recent head 9283be4. Consider uploading reports for the commit 9283be4 to get more accurate results

@@              Coverage Diff              @@
##           staging      #131       +/-   ##
=============================================
+ Coverage    66.73%   100.00%   +33.26%
=============================================
  Files          267         2      -265
  Lines        18752        46    -18706
  Branches      4038        16     -4022
=============================================
- Hits         12514        46    -12468
+ Misses        6195         0     -6195
+ Partials        43         0       -43

Impacted Files
Coverage Δ

meteor/server/security/peripheralDevice.ts

meteor/server/logging.ts

meteor/server/api/profiler.ts

meteor/server/api/playout/infinites.ts

meteor/server/migration/migrations.ts

meteor/lib/collections/TriggeredActions.ts

meteor/server/api/lib.ts

meteor/lib/globalStores.ts

meteor/server/api/ingest/commit.ts

...r/server/api/blueprints/context/watchedPackages.ts

... and 255 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4704de9...9283be4. Read the comment docs.


Discrepancy between docs and implementation for secrets destination file in Kamal 2

Kamal 2 docs currently mention that if you are using destinations, secrets will be read from .kamal/secrets-<DESTINATION> if it exists.[1] [2]
But the code currently reads from .kamal/secrets.<DESTINATION>:
https://github.com/basecamp/kamal/blob/8c32e6af07356031ffbad2e8eb60169904bc5e52/lib/kamal/secrets.rb#L10
So either the docs should be changed to mention .kamal/secrets.<DESTINATION> (https://github.com/basecamp/kamal-site/pull/108), or the code should read from .kamal/secrets-<DESTINATION> (https://github.com/basecamp/kamal/pull/983).

Fixed by https://github.com/basecamp/kamal-site/pull/106.


[FEATURE REQUEST] FaceID implementation

Add FaceID for more security.
Simply FaceID when not matched Popup iPhone Pun request

Added new Section Security in the app
Available in update 1.3.0

release 1.3 in review

App is now live


Quarkus reactive programming support

Quarkus proposes a neat reactive programming model (which can be used side by side with the imperative model).
The objective is to propose to the user to choose the programming model and generate the according templates.

I can do this.

The jhister cli already provides a reactive option.. we have only to add related templates for the generic app (for data layer we have to refer to the other issues)

You right, is 100% templates.
Couple of pointers:
https://quarkus.io/guides/reactive-routes
https://quarkus.io/guides/reactive-sql-clients
Quarkus "reactivity" relies on Vert.x but there is a "callback-free" API for the Web layer so I propose to focus on this one first.
Ping me if you need help, I have couple of contacts.

@danielpetisme @joewhite101
I suggest to remove this feature from the 1.0.0 milestone. The effort needed seems to be too high.
For me, it makes sens to have a first release without reactive programming and define a plan for next version, adding this feature step by step.

Moving to reactive is a major step.
Where web and service are quite easy to migrate, data is way more tricky.
As for now, Quarkus does not provide a "reactive" ORM. This means for the application developer to write the CRUD SQL statements manually and for a code generator like JHipster... well to actually generate those queries (which is basically the job of the ORM 🤔 ).
You get my +1 to postpone reactive to a post-1.0 realease. IMHO, concerning database access we should definitively wait for a native support from Quarkus or give a very high bounty.

I'm totally aligned with that, let's remove from 1.0.0.

feel free @vivekmore
I think @danielpetisme already prepare the field by creating partials. Anyway, we should avoid the mess we have on the official JHipster project mixing reactive and not in the same templates (as most as possible).

Hi,
I started a long time ago but I crash my machine and lost the code (yes it happens in real life...).
Anycase, feel free to progress on this one.
A couple of advice:
1- isolate the imperative and reactive code in separate partials. I would recommend to isolate in a per method granularity (like list_imperative.ejs and list_reactive.ejs it's way easier to debug.
2- For now, do not try to have ordered imports, let the first prettier Java execution trigger at the code generation handle that for you
3- When using mutiny, queries are composable. I would suggest to made small human-readable queries and then compose them. JHipster Spring reactive tend to have a huge block that is hard to troubleshoot, please break down in smaller blocks.
4- Mutiny has no Uni implicit null filtering. If you want to prevent NPE, you need to eagerly filter the null value and throw the exception to fail fast.
Let me know if you need more guidance, I would do my best to help you.

Thank you 👍🏻
These are great advice and starter points!
I'll start looking at the blueprint code and Quarkus.
I feel I should also declare that, I'm mostly familiar with JHipster generator code and Spring and am new to Quarkus framework.


[core] update root package version

As far as I know, the version of the docs reads from root package JSON.

[x] I have followed (at least) the PR section of the contributing guide.

Yes, we missed it :\

Actually, this is on me 🥲. I revert the release in the previous PR run yarn release:version again because it was easier to pick the version from the terminal, but forgot to update root package version.

This value is shown at

so I added the docs label 😁


Property 'on' does not exist on type 'IJitsiMeetExternalApi'

addEventListener and addEventListeners are deprecated and the comment suggests to use on instead but it is not exported from IJitsiMeetExternalApi, which leads to error in title (ts2339).

Could you please tell me when does this error show up? I can't seem to reproduce it. The IJitsiMeetExternalApi should inherit the on method from the EventEmitter class.

The error used to show up on VSCode but it seems I'm not able to reproduce it anymore. I have just opened the project where it used to show up and now it works fine. Hovering on on even shows me the JSDocs. I didn't change anything so it's pretty weird, but I guess the issue can be closed. Sorry for the useless issue.


New version: BitemporalPostgresDDL v0.1.4

Registering package: BitemporalPostgresDDL
Repository: https://github.com/Kaeptenblaubaer/BitemporalPostgresDDL.jl
Created by: @Kaeptenblaubaer
Version: v0.1.4
Commit: 8028d16a88b3beec3bcf6d728788c37842cbc212
Reviewed by: @Kaeptenblaubaer
Reference: https://github.com/Kaeptenblaubaer/BitemporalPostgresDDL.jl/commit/8028d16a88b3beec3bcf6d728788c37842cbc212#commitcomment-67047808

[noblock]

@Kaeptenblaubaer would you like this pull request to be manually merged even if it's skipping some version numbers? That's OK but we need your confirmation.
[noblock]

Please close, I will publish the contents in another package.
Thank You
Mosè Giordano @.***> schrieb am Di., 22. Feb. 2022,
11:00:

@Kaeptenblaubaer would you like this pull request to be manually merged
even if it's skipping some version numbers? That's OK but we need your
confirmation.
[noblock]
—
Reply to this email directly, view it on GitHub
https://github.com/JuliaRegistries/General/pull/54985#issuecomment-1047621514,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC6Y2UQQDXVCTFHW7QZRU73U4NNDFANCNFSM5O2YEMRQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


Readme: include example of passthrough option for mocking.

When mocking a common requirement is for the mock to retain all other
functions in the original module. The README has been updated to include
information and an example of how this can be achieved.

Thanks for this! Meck options are in fact provided by default but I had forgotten to state it in the documentation. Support for :passthrough is really important though, maybe it would be cool to add a spec that formalises the behaviour. What do you think?

From what I can see the only Meck option that is passed through by default is :no_link. So you do need to manually pass the :passthrough option from your tests if you want to retain all other functions of the module in the mock. I'm happy to add a spec that demonstrates this if you like?

Oh, yeah, I wasn't saying that you didn't have to pass it in, I was just saying it would be great to have a test that shows that passing :passthrough indeed makes retains all other original functions. The spec is just a way to formalise the contract so that future changes to the code don't break this behaviour.

Ok cool, yeah totally agree a test is necessary! I'll update the pull request tonight.

Thanks a lot!

@inf0rmer I've added some tests to formalise the behaviour, and updated the commit message.

Fantastic, this looks great! Thanks a lot.


5.0.2 Release

Changelog
Bug fix

When logging a null exception, the stack trace included in the Crash Report sent to Raygun will now correctly be the code execution stack up to the point where the log statement was made. This is functionality that was added in the previous version, but was erroneously using the code execution stack of a background thread.

@nblumhardt When you get a chance, please review (and merge if approved) this new release that contains a single bug fix. As you'll see, the build script has failed due to being unable to push the dev build to NuGet.

Thanks @nblumhardt, I've made the namespace change and pushed the new 5.0.2 version with this bug fix. I needed to edit the release from "v88" to "v5.0.2", so not sure if that's normal. I also changed the version of the dev branch to 5.0.3, but this pushed a pre release version to NuGet. Should that have been committed straight to the dev branch instead of through a PR?

Direct to dev and a PR have the same effect - I think appending [skip ci] to the commit message sometimes/usually avoids publishing anything.

Yeah, I did have [skip ci] in the commit to my branch at least.


Publish to chromatic from beta candidate branch

Why
Storybook deployment for bug bashing.
How Tested
Prayers.
Process & policy checklist

[ ] I have updated the project documentation to reflect my changes if necessary.
[ ] I have read the CONTRIBUTING documentation.

Is this a breaking change?

[ ] This change causes current functionality to break.

The idea is to land this, and then cherry-pick the PR to beta-candidate. If all goes well, merging the cherry-pick PR into beta-candidate will trigger a publish-chromatic workflow and give us a storybook to play with.

Quick experiment I didn't follow up on.


Extracting images and text

So I have an in memory byte-stream representation of the .pptx file. Wondering if there is any way to extract all images and text content from this byte-stream using the library ?

https://python-pptx.readthedocs.io/en/latest/user/presentations.html
The documentation shows you can open a presentation as a byte-stream. From there on, just iterate through each slide and each shape in slide to find if shape is image or text and save it somewhere.


Add force-sourcemap to embed inline sourcemaps

This allows a flag to be added to force the embedding of an inline sourcemap to the file. This resolves issues with webpack not outputting sourcemaps for tools like remap-istanbul to function.
I have published this separately at https://www.npmjs.com/package/sourcemap-istanbul-instrumenter-loader if you want to test

@zakhenry do you perhaps have an example repo that contains typescript with webpack and coverage like this?

@TheLarkInn yea this is used in https://github.com/ubiquits/toolchain/blob/master/cli/tasks/test.js and yes remap istanbul is required. Note that the setup isn't trivial though as I merge two coverage reports from two sources (frontend and backend unit tests)

@deepsweet Is there any way we can get you to take a look at this pull request? I don't think the logic needs to be behind a flag/property, but this issue is preventing instrumented transpiled code from being able to be remapped back to the original code via remap-istanbul.

@bryanforbes, @deepsweet seems to be active on github as he has activity, probably notifications turned off or something. Anyway I tweeted him as I need this as well! https://twitter.com/samvloeberghs/status/773126385074311168

hey guys. I'll merge https://github.com/deepsweet/istanbul-instrumenter-loader/pull/28 later today.


Remove "Description" word at the beginning of each event description

Every conference has the "Description" word at the beginning of the description text. Please remove it.

Done.


Replace inctimer package with time.After

Go version ≥ 1.23 no longer has the issue of not garbage-collecting unstopped
time.Timers and thus time.After can again safely be used in loops. Also see
https://go.dev/doc/go1.23#timer-changes and
https://cs.opensource.google/go/go/+/refs/tags/go1.23.2:src/time/sleep.go;l=196-201 for details.
This PR pulls in the linter change which skips the corresponding timeafter check on Go version ≥ 1.23^1, converts all uses of the inctimer package back to time.After and removes the inctimer package.
See individual commit messages for details.

/test

/test

/test


15092 add relationships to full restoration

Issue #: /bcgov/entity#15092
Adding the relationship question for limited to full restorations.

This shared component includes some whitespace that I'd like to remove in a separate PR to bcrs-shared-components.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

Closing.  I will create a new PR without the outdated comments.


Upgrade egui & eframe to 0.28

Closing this because egui 0.28 is supported as of e8709eb. You can enable the egui28 feature to use egui v0.28:
catppuccin-egui = { version = "5.3", default-features = false, features = ["egui28"] }


Add test fixtures to create non-inheritting test DataTree object with duplicated variable, coord, and dim names

The goal of this addition is to provide test capability for HDF5/NetCDF4 dataset with groups that follow ADCIRC model input dataset convention NWS13.

[x] Create a pytest fixture to create the test DataTree
[x] Test added for opening with open_datatree without errors
[x] Other tests?

Let me know if I should rebase or make any other changes


Add Gremlin "Except" and "Retain" filtering methods

Along with requisite "Aggregate" method as described here:
https://github.com/tinkerpop/gremlin/wiki/Except-Retain-Pattern
This'll allow much better query support and output.

Moved this over to feature requests as it seems to have been sitting here without much implementation for a long time, maybe over there it will generate some new excitement: https://discourse.cayley.io/t/add-gremlin-except-and-retain-filtering-methods/239


Crash on split confirm

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

This is a follow up issue from https://github.com/Expensify/App/pull/17349#issuecomment-1537823597
Action Performed:
Open a split confirm deep link
Expected Result:
Split confirm page should open
Actual Result:
The app crashes
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/96077027/236749210-e6132003-424b-4610-ba35-dbea8fe2ccbf.mov
Expensify/Expensify Issue URL:
Issue reported by: @aimane-chnaif
Slack conversation:
View all open jobs on GitHub

@jczekalski please comment on the issue so I can assign you

@amyevans

@amyevans I pulled the changes from the latest version of main and started looking into this. If I quickly open the Send Money page using slow 3G network throttling or deep link into the page (http://localhost:8080/send/new) I get these errors:
tNumberFormatUnitOptions.js:18 Uncaught TypeError: currency cannot be undefined

The above error occurred in the <TextInputWithCurrencySymbol> component:

Uncaught (in promise) TypeError: Cannot read properties of null (reading 'style')
   at eval (index.js:11:1)

https://github.com/Expensify/App/assets/39824924/fc5a71cc-943a-44a4-940c-19949dca0ec4
So I can't get to the confirmation screen without the app crashing. In the video you uploaded, the Send Money page works fine and the errors in the console are different (the app crashes when the confirmation page is opened). It looks like these are new issues, do you know if they've been reported?

We have over 1,000 open issues in the repo, so I don't know off the top of my head if they've been reported yet haha. Could you post them in the #expensify-bugs Slack channel? Our QA team is better at spotting duplicates, and if they aren't dupes they will create new issues for them.

We have over 1,000 open issues in the repo, so I don't know off the top of my head if they've been reported yet haha. Could you post them in the #expensify-bugs Slack channel? Our QA team is better at spotting duplicates, and if they aren't dupes they will create new issues for them.

Good point! Sorry, I'm still getting used to this setup :) I posted the bug in the #expensify bugs channel.

Update: I approved the PR which fixes the bug I mentioned above (crash on Send money / Request money / Split bill), so we should be able to work on this issue once it has been merged.

I'm from Software Mansion, I'd like to work on this job.

Greg and I both just spent some time attempting to reproduce as well and weren't able. I'm going to close. Thanks guys!

Okay thanks, reproduced and wrote up some clearer steps - let me know if they can be tweaked for clarity:
https://github.com/Expensify/App/assets/7277067/857bdb25-c2c2-43a8-93be-84f52fb75628

(Precondition) Have the desktop app open but not logged in; throttle your network
Log in to web
In a 1:1 DM, select Send money
Copy the URL from the address bar
Modify the URL so that it's a deep link (replace http with new-expensify) and open it
Follow the deep link prompt to open it in desktop
Enter an amount to split

FYI: I'll be OOO tomorrow and Monday.

Okay, nice, the new reproduction steps look better/clearer for sure

@kowczarz - mind taking another stab at reproducing? If you can are you still available to action this?

Yep, I managed to reproduce the issue, I'm working on proposal.

Proposal
Please re-state the problem that we are trying to solve in this issue.
App crashes on money request confirmation
What is the root cause of that problem?
The app wants to read property of value that can be undefined here
https://github.com/Expensify/App/blob/ec9bc04108992ff400b3fb86d8a31091d727310e/src/components/MoneyRequestConfirmationList.js#L293
What changes do you think we should make in order to solve the problem?
Before accessing payPalMeAddress of recipient, we need to ensure that the recipient is not undefined and has a value.
To do so I would extract the boolean cast to a separate constant and before the cast I'd use _.isUndefined to ensure if the recipient exists.
What alternative solutions did you explore? (Optional)
NA

@aimane-chnaif I've just updated it.

Looks like we're awaiting @amyevans to return tomorrow for confirmation

PR is up!

PR review is very nearly complete

Merged, awaiting deploy to prod

Added the label to create an Upwork job, sorry for pings

Sent an offer to @aimane-chnaif

Last step is the checklist @aimane-chnaif!

All right. Thanks for running through it. Paid out. Going to close.


TypeError: hardhat_1.ethers.getContract is not a function

Hi - love all your work! It has been really helpful.
I just tried migrating from buidler, and I'm pretty sure I have everything set up correctly in the config, but I'm getting this error:
TypeError: hardhat_1.ethers.getContract is not a function
...ethers exists, but getContract doesn't.
package.json dev dependencies:
  "devDependencies": {
    "@ethereum-waffle/chai": "^3.0.2",
    "@ethersproject/bignumber": "^5.0.5",
    "@ethersproject/bytes": "^5.0.3",
    "@ethersproject/solidity": "^5.0.2",
    "@ethersproject/wallet": "^5.0.2",
    "@nomiclabs/hardhat-ethers": "^2.0.0",
    "@types/chai": "^4.2.11",
    "@types/mocha": "^8.0.2",
    "@types/node": "^14.10.2",
    "chai": "^4.2.0",
    "creaton-common": "../common-lib",
    "cross-env": "^7.0.2",
    "dotenv": "^8.2.0",
    "ethers": "^5.0.19",
    "hardhat": "^2.0.2",
    "hardhat-deploy": "^0.7.0-beta.18",
    "hardhat-deploy-ethers": "^0.3.0-beta.5",
    "mocha": "^8.1.1",
    "solidity-coverage": "^0.7.10",
    "ts-node": "^9.0.0",
    "typescript": "^3.8.3"
  },

imports in hardhat.config.ts:
import 'dotenv';
import 'hardhat/config';
import 'hardhat-deploy';
import 'hardhat-deploy-ethers';
import '@nomiclabs/hardhat-ethers';

Any ideas?

The dependencies indicate that you do not have any of the plugin installed.
Can you provide a more complete example
You can also see here an example project that got both hardhat-deploy and hardhat-deploy-ethers used : https://github.com/wighawag/template-ethereum-contracts

oops, sorry - I pasted the wrong dependency list. I just fixed it.
Line 26 of this file is where the failure is happening: (TypeError: hardhat_1.ethers.getContract is not a function)
https://github.com/Aeroxander/creaton/blob/dev2/contracts/scripts/seed.ts

Could you try with the latest version of both hardhat-deploy and hardhat-deploy-ethers

same result - I also tried wiping node_modules, package-lock.json, and reinstalled

oh, I see, I did not spotted first time
you are using both import '@nomiclabs/hardhat-ethers'; and import 'hardhat-deploy-ethers
you need to use only import 'hardhat-deploy-ethers

that did the trick - thank you!


davinci-assembly_3.0.1-0.3.0-SNAPSHOT-dist-beta.4  start-server.sh  error

Error querying database.  Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is com.alibaba.druid.pool.DataSourceClosedException: dataSource already closed at Tue May 28 17:15:07 CST 2019
The error may exist in edp/davinci/dao/CronJobMapper.java (best guess)
The error may involve edp.davinci.dao.CronJobMapper.getStartedJobs
The error occurred while executing a query
Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is com.alibaba.druid.pool.DataSourceClosedException: dataSource already closed at Tue May 28 17:15:07 CST 2019
2019-05-28 17:15:07.236  INFO 19296 --- [main] edp.davinci.runner.CronJobRunner         : Load cron job finish

email is null

email is null


Support pushing docker images to quay.io from github actions

If this works we can revert #1139 as this approach is better i think.
We can push whatever tags we want using this approach, and we're already building the CI artifacts.
I've tested on my personal fork of bpftrace, and tried to make it work seamlessly for iovisor/bpftrace. We won't know for sure until we see something merged to master (including this PR).
The result of this should be the following artifacts:

An image tagged with SHA-NAME for all Release builds. This will let us very surgically reference specific builds, even if another build has been pushed to a given tag/branch.
An image tagged with BRANCHNAME-NAME for all Release builds. This will let us keep a floating reference of the latest build of a given type for a branch name
An image tagged with BRANCHNAME for the vanilla+glibc2.7 image type. This will let us keep a floating reference to the default release image for a given branch name, as well as have tagged releases
An image tagged with :latest if the branch is master.

Note that for tags, it will do one build each for the branch and the tag.
Since tagging is just a book-keeping thing, this only actually builds one image (even though it may push multiple tags).

I ran this test against my own repo, did a tag and also pushed to dalehamel/bpftrace master branch.
I was able to verify that it pushed the tags as expected. I think this is ready to go.

@danobi please take a look when you have the chance!


Fixing datetime output in csvs

Already testing on the server
Adding timezone info to the datetime that is output in the csv breaks the dashboards ability to read it. Since we're trying to output the same format, this should do it
This now outputs the exact same format that the historical csvs output
Fixing s3 upload after 7pm Eastern since that also was using UTC when eastern makes more sense

Currently running on gobble prod right now, looking good. The s3 uploads started again.
If we want to switch to timezone encoded timestamps we should update the dashboard first imo


[feature request] Function to set NDKUser for NDKNip07Signer

Every time I refresh a page NDK loses state and I have to approve sharing my public key again. But after sharing my pub key once, it can be stored somewhere else with persistence and upon refreshing the page:

I check my storage for the presence of a public key
If present: I create a new NDKUser using the pub key and set it to the NDKNip07Signer, so I don't have to prompt the user again
If not present: I prompt the user to share his pub key

I think that this is less an NDK concern and more of a concern of your app since each app handles persistence differently. Happy to hear more thoughts on this though.

Closing as stale.


Memory leak in streamsOutbound

Description
There are items inside streamsOutbound exist with the same size in 2 heap snapshots (one was taken 1 day after another)

there are 55 OutboundStream instances

however there are only 50 items inside Gossipsub peers set

it means that when a peer is disconnected from node, it was removed from Gossipsub peers set but not streamsOutbound map. This is root cause of #6129 and only happen since Lodestar v1.12

the only way a peer was removed from peers set but not in streamsOutbound is outboundStream?.close() throws error. It was fixed here https://github.com/ChainSafe/js-libp2p-gossipsub/pull/471/files#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80R855
the fix is included in release 10.1.1 of gossipsub, will try to test it in lodestar


Date timestamp base confusion

I am trying to convert a vapor 2 app to vapor 3 and am hitting problems with dates in forms.
Using the new #date( event.date, "yyyy-MM-dd" tag in my leaf file correctly displays the value<PHONE_NUMBER>.9163451 as 2018-12-27. However, using the suggestion from the style guide page to use javascript to convert the human-friendly date back into a timestamp runs into problems. It took me a while to work out that the timestamp<PHONE_NUMBER>.9163451 is relative to 1970, but when you are going the other way, it is relative to 2001-01-01, so all my dates stored back into the database are 31 years in the future.
If I pass a timestamp of 0 from the form back into vapor, it creates the 2001-01-01 date, so I am fairly sure I am right.

If I put a 'correction' of 978307200 (being the number of seconds between 1970 and 2001) then I get the correct date.


[Feature]: update tolerance-values

Feature
Description
The current solution for the tolerance of synapses is a bit bad. The value of the tolerance-change of 1.2 was used after try-and-error with the MNIST-case only. It is not really universal, which has to be changed.

Acceptance Criteria

better tolerance-value for synapses was found

Additional Information

Blocked by

How to test

the synapse-tolerance doesn't change anymore over time. The new way provides slightly better results, but is also a bit slower.


GH-44974: [Dev] Fix minor issue handling

GitHub Issue: #44974

Not sure how to test this before it reaches git main @raulcd

This is not going to fix the issue, it still requires this commit to be included:
https://github.com/raulcd/arrow/commit/c2970257d5caba25107d50e9b7295a93edd979cb

Oh, sorry. I checked only changes. I should have also checked affected file names.


WIP (DO NOT MERGE) MBP-381 Move GitOps prefs to a ConfigMap

Add fake argoCD Clientset vendor files
Extract gitops config from pattern CRD: * The contents of the gitops config are now fetched at bootup time from a optional configmap mounted on the manager container. * The configmap contains a single file named gitops-config.json whose contents follow the subscription's spec in a JSON format. * When the configmap is not available, the controller will default to the same configuration that is provided already.
Updated cluster service version
WIP: configmap add gitops-config/config.json
Adding current impl for config map work
Added installplans rbac generate directive
Adding GitOps Config Map file
Updating volume mount
Adding CM to main.  Removing CM from manager.
Fix issue with ConfigMaps.Get
New common package for constants
Added use contants from common package
Added default GitOps constants
Moved common package to controllers
Removed common. Updated reference to common const
Moved common to rop level. Adding gen'ed files.

@beekhof and @mbaldessari Draft PR for us to work through.

@beekhof I have implemented all of your suggestions.  I need to work on the pattern tests now.  Should have something soon on the test.  Please review at your earliest and I really appreciate the feedback!

/lgtm


Make option names of 'app permission add' plural

The following command has some options that according to our naming convention should have names in the plural form:
applicationPermission and delegatedPermission should be renamed to applicationPermissions and delegatedPermissions

Good catch. Could we introduce an alias for the time being with a deprecation message and then drop the singular in the next major version?

We can, but I'm personally doubting whether it's worth the effort.

Since we have v8 branch we may now start working on it!
Let's get this 🚢
and Let's put CLI to the 🚀🌙

Can I work on it?

Can I work on it?

All yours

merged to v9


Make example functions in Challenge seed unique

Pre-Submission Checklist

[X] Your pull request targets the staging branch of FreeCodeCamp.
[X] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[X] You have only one commit (if not, squash them into one commit).
[x] All new and existing tests pass the command npm run test-challenges. Use git commit --amend to amend any fixes.

Type of Change

[x] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[x] Tested changes locally.
[x] Closes currently open issue (replace XXXX with an issue no): Closes #9456

Description

…vaScript with Functions, Passing Values to Functions with Arguments, and Return a Value from a Function with Return.

I'm confused by camperbot. I could have sworn the instructions said TO put "closes #XXXX" in the commit. In fact I amended my commit to do so.

Looking at the details of the failing check, it doesn't seem to be anything I did that is failing, so I am confused by that too.

Also it would be great if you could make the changes to Challenges mentioned in the original issue.
Refer : https://github.com/FreeCodeCamp/FreeCodeCamp/issues/9456#issuecomment-229705986
Thanks a lot for this PR.
 I'm a little confused by your other issue, since I'm relatively certain that is exactly what I did. Could you elaborate?

@ChadKreutzer from the original issue:

Yeah, it seems that ourFunction for the example and a unique function name for the user is also used in Use Conditional Logic with If Statements.
Maybe in all such cases it would be clearer to use the unique function name prefixed with our for the example, and without it for the user's function, i.e. ourReusableFunction / reusableFunction for this challenge and ourTrueOrFalse / trueOrFalse for the Conditional Logic challenge linked above.
Or maybe that camel case variation is confusing :)
Edit: there's at least one other challenge that asks the user to create a new function with the same name as the example function, Passing Values to Functions with Arguments, which could definitely benefit from this kind of change!

Could you update these names at all such places, similarly?

Okay. I see what your meaning now. I will get that fixed. :-)

I had changed the ones mentioned, but I had not followed the suggested pattern and instead had followed the pattern of "ourFuncton()/uniqueFunction()" I have now changed all the applicable challenges. (I did not change the ones that followed the ourX/myX pattern, because they seemed to make sense and be consistent within their series.)

@ChadKreutzer could you hit us up in the Contributors Chat room.

@erictleung I am supposing you might have a look as well.

@ChadKreutzer see comments above. Also, this line needs to be changed to ourRandomRange(1, 9).
Please make or address the comments above and then we can merge your PR. Thanks for the PR nonetheless!

Thanks for the QA Eric, I was yet to do the same. Just got back from work.

I did change the ourRandomRange line that I missed, though.

@erictleung @raisedadead Alright. hopefully this is good :smiley:

@ChadKreutzer thanks this LGTM,
@atjonathan @erictleung should be good I guess?

LGTM :+1:

@ChadKreutzer LGTM! 👍  Thanks for your contribution to FreeCodeCamp! ✨ 🎉 ✨


Update the description of Connect Excel to Power BI online

Based on the test on the latest version of Power BI Online and Excel 2016, when use the option "Connect, manage and view Excel in Power BI", Power BI Online will automatically create a dateset for the connected Excel workbook. But the current docs said "no dataset is created in Power BI". This is incorrect description, so i want to update it.

@jessica-seiya : Thanks for your contribution! The author, @davidiseminger, has been notified to review your proposed change.


Explore if snapshot implementation should follow the interfaces exposed by volume

Is this a BUG REPORT or FEATURE REQUEST?
FEATURE REQUEST
Why is this required ?

Volume interface exposes various volume specific operations:

https://github.com/openebs/maya/blob/master/volumes/provisioner/volume.go

This issue will explore if this is a good design to follow for volume snapshot as well
The current snapshot implementation does not follow the volume interface.

A details design for creating snapshots and clone of OpenEBS (Jiva) Volumes is available at: https://docs.google.com/document/d/1okB86blZsFhrCkJQXnpN40UH6bucc6nDbtkv-ejyxAE/edit#


Y24 473 generalize multiple source identifier filtering logic

Closes https://github.com/sanger/traction-service/issues/1490
Changes proposed in this pull request
Added the SourceIdentifierFilterable concern, thereby generalizing the code to apply multiple source_identifiers, which can be called from both Pacbio::LibraryResource and Pacbio::RequestResource.
https://github.com/sanger/traction-service/pull/1488#pullrequestreview-2454409961
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

Looks really good. With plenty of documentation.
I will have a proper look later. Are there any specific filters I can use if I run locally to test it?
Thanks.
Yes, it is for the 'source' filter. To test it, we need to select 'Source' in the Libraries and Samples page within the 'Filter Results' panel, using multiple values of source separated by commas.


error after installing latest version

Hi,
I'm getting this:
travisthetechie.write-good-linter] write_good_1.default is not a function: TypeError: write_good_1.default is not a function
	at lines.forEach (/Users/dotan.nahum/.vscode/extensions/travisthetechie.write-good-linter-0.0.6/out/src/extension.js:32:47)
	at Array.forEach (native)
	at doLint (/Users/dotan.nahum/.vscode/extensions/travisthetechie.write-good-linter-0.0.6/out/src/extension.js:31:11)
	at context.subscriptions.push.vscode_1.workspace.onDidChangeTextDocument.event (/Users/dotan.nahum/.vscode/extensions/travisthetechie.write-good-linter-0.0.6/out/src/extension.js:13:13)
	at e.invoke (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:28:57

Any idea why?

Hmm, no, it's not clear why this is happening for you. The stack makes be believe it's happening on https://github.com/TravisTheTechie/vscode-write-good/blob/v0.0.6/src/extension.ts#L44 and not the loop below; which is a bit troubling. I'll take a look.

I think it points to the compiled code. From what I gathered later, requiring write-good came up with nothing. I'll see if I can get some more information.

This might be the problem:
https://github.com/TravisTheTechie/vscode-write-good/commit/bd322c912f3bbeae279e63e6b7233505b5366879#diff-45327f86d4438556066de133327f4ca2L5
Moving to module system makes it look for .default as part of the module system, and write-good might not be compiled for that. I removed this locally in my extension and it's back to life.

Upgrading so VSCE would run did break things, have a fix in https://github.com/TravisTheTechie/vscode-write-good/commit/f7f270dca9a15f7d34c18fdeae5265e118fcf021 that has been published. If you update it should be working for you. Please reopen if this doesn't fix it for you.


feat(DNS) add Fastly CNAME records

Follow up of #113 and #115 this PR imports the existing DNS records in the jenkins.io for Fastly-served websites.
The 5 existing DNS records points to the same destination hence the for_each form.

Job disabled
Imported 5 records
Ran a terraform plan which shows only TTL and tags are to be changed on existing records:

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # azurerm_dns_cname_record.jenkinsio_fastly["pkg"] will be updated in-place
  ~ resource "azurerm_dns_cname_record" "jenkinsio_fastly" {
        id                  = "/subscriptions/dff2ec18-6a8e-405c-8e45-b7df7465acf0/resourceGroups/proddns_jenkinsio/providers/Microsoft.Network/dnsZones/jenkins.io/CNAME/pkg"
        name                = "pkg"
      ~ tags                = {
          + "purpose"    = "Website to download Jenkins packages"
          + "repository" = "jenkins-infra/azure-net"
          + "scope"      = "terraform-managed"
        }
      ~ ttl                 = 3600 -> 300
        # (4 unchanged attributes hidden)
    }

  # azurerm_dns_cname_record.jenkinsio_fastly["plugins"] will be updated in-place
  ~ resource "azurerm_dns_cname_record" "jenkinsio_fastly" {
        id                  = "/subscriptions/dff2ec18-6a8e-405c-8e45-b7df7465acf0/resourceGroups/proddns_jenkinsio/providers/Microsoft.Network/dnsZones/jenkins.io/CNAME/plugins"
        name                = "plugins"
      ~ tags                = {
          + "purpose"    = "Website to browse and download Jenkins plugins"
          + "repository" = "jenkins-infra/azure-net"
          + "scope"      = "terraform-managed"
        }
      ~ ttl                 = 3600 -> 300
        # (4 unchanged attributes hidden)
    }

  # azurerm_dns_cname_record.jenkinsio_fastly["stories"] will be updated in-place
  ~ resource "azurerm_dns_cname_record" "jenkinsio_fastly" {
        id                  = "/subscriptions/dff2ec18-6a8e-405c-8e45-b7df7465acf0/resourceGroups/proddns_jenkinsio/providers/Microsoft.Network/dnsZones/jenkins.io/CNAME/stories"
        name                = "stories"
      ~ tags                = {
          + "purpose"    = "Website with Jenkins User stories and testimonies"
          + "repository" = "jenkins-infra/azure-net"
          + "scope"      = "terraform-managed"
        }
      ~ ttl                 = 3600 -> 300
        # (4 unchanged attributes hidden)
    }

  # azurerm_dns_cname_record.jenkinsio_fastly["way.the.is"] will be updated in-place
  ~ resource "azurerm_dns_cname_record" "jenkinsio_fastly" {
        id                  = "/subscriptions/dff2ec18-6a8e-405c-8e45-b7df7465acf0/resourceGroups/proddns_jenkinsio/providers/Microsoft.Network/dnsZones/jenkins.io/CNAME/way.the.is"
        name                = "way.the.is"
      ~ tags                = {
          + "purpose"    = "Old alias for stories.jenkins.io"
          + "repository" = "jenkins-infra/azure-net"
          + "scope"      = "terraform-managed"
        }
      ~ ttl                 = 3600 -> 300
        # (4 unchanged attributes hidden)
    }

  # azurerm_dns_cname_record.jenkinsio_fastly["www"] will be updated in-place
  ~ resource "azurerm_dns_cname_record" "jenkinsio_fastly" {
        id                  = "/subscriptions/dff2ec18-6a8e-405c-8e45-b7df7465acf0/resourceGroups/proddns_jenkinsio/providers/Microsoft.Network/dnsZones/jenkins.io/CNAME/www"
        name                = "www"
      ~ tags                = {
          + "purpose"    = "Jenkins official website"
          + "repository" = "jenkins-infra/azure-net"
          + "scope"      = "terraform-managed"
        }
      ~ ttl                 = 3600 -> 300
        # (4 unchanged attributes hidden)
    }

Apply complete! Resources: 0 added, 5 changed, 0 destroyed.


Kubernetes on DigitalOcean

Control Plane
VPN mesh for node infrastructure
Private networking
Ubuntu

@jcruz2us I wanted to make sure you knew about this

Still sorting out the VPN mesh for the nodes - but I have the control plane up and running! Just need some downtime, and will be wrapping this up shortly!

Update: Sorry I have been swamped at work and still trying to write a book at the same time on all this stuff! I promise we will have k8s on digital ocean + VPN private network ASAP.. it's coming.. it's coming!

This is very promising! I've been fiddling with this for the past day or so and here are my findings. By running
kubicorn create --name myfirstk8s --profile do
kubicorn apply --name myfirstk8s

I get the following on digitalocean...

an operational master node
a worker node that boots up but never joins the cluster

The logs for kubelet.service on the worker node showed
Jul 20 22:21:17 myfirstk8s-node kubelet[3479]: error: failed to run Kubelet: invalid kubeconfig: stat /etc/kubernetes/kubelet.conf: no such file or directory
Jul 20 22:21:17 myfirstk8s-node systemd[1]: kubelet.service: Main process exited, code=exited, status=1/FAILURE
Jul 20 22:21:17 myfirstk8s-node systemd[1]: kubelet.service: Unit entered failed state.
Jul 20 22:21:17 myfirstk8s-node systemd[1]: kubelet.service: Failed with result 'exit-code'.
Jul 20 22:21:22 myfirstk8s-node systemd[1]: Stopped kubelet: The Kubernetes Node Agent.

I verfied /etc/kubernetes/kubelet.conf and ran systemctl start kubelet.service on the worker node. The node joined the cluster and I was able to verify it with kubectl get nodes.
With the worker node as part of the cluster, I launched  a simple nginx container and exposed  it to the internet via a node port!!
A little hiccup but this is looking great! Thank you and let me know if I can be of any help.

The last push I made should fix all the kubelet concerns
Now I am just working on setting up a VPN mesh so that private networking is actually "private"

should have this in by the end of the night sans tests - meaning it will be ready to run (and therefor break) tomorrow

Alright folks.. here goes nothing


Docusaurus Document Loader

Feature request
I propose the integration of a Docusaurus Document Loader for the LangChain Python repository. By integrating a Docusaurus Document Loader, we can extend the documentation capabilities of LangChain and provide a more comprehensive resource for developers who use Docusaurus (similar to ReadTheDocs).
Motivation
My motivation for this feature request is to enhance and extend the document loading functionalities of LangChain. Currently, LangChain integrates with ReadTheDocs, and while this is a powerful tool, incorporating a Docusaurus Document Loader can offer an alternative loader. Plus, LangChain docs (Python and JavaScript) are already hosted on Docusaurus.
Your contribution
As the one initiating this feature request, I am willing to help by creating this issue and providing initial suggestions for the implementation of the Docusaurus Document Loader.

this is a great idea! would love to see this

The ingest pipeline of chat-langchain already uses SitemapLoader to load HTML from Docusaurus.
As a result, Docusaurus document loader would make a meaningful impact on LangChain and unlock new doc-focused workflows.
As a result, I'm re-opening this issue.

Merged via https://github.com/langchain-ai/langchain/pull/9138