Docs4Doge: update of gitian builder script + documentation (follow #2396)

Related to Docs4Doge initiative, based on & following PR #2396.
Following @micaelmalta work, I reused a good part of his script and edited gitian-builder.sh to fit in a single script, like it was. This is mainly an update of contrib/gitian-build.sh and his documentation doc/gitian-building.md (see it to try the script).
A lot of deleted files are coming from previous documentation images.
It's having Docker available for sure, and maybe LXC & KVM aren't so far if you're able to use/configure them (with some tests I weren't).
Pending PRs on devrandom/gitian-builder
It relies on 2 PR on devrandom/gitian-builder repository. https://github.com/devrandom/gitian-builder/pull/254, already merged, and https://github.com/devrandom/gitian-builder/pull/253 to get --disable-apt-cacher option.
There is some interest in the PR, I suppose it will be merged before we finish to work on this.
For now, to try the script with those features, you can replace inside gitian-build.sh the line with
git clone https://github.com/devrandom/gitian-builder

by a branch of my gitian-builder repository :
git clone https://github.com/abcsxyz/gitian-builder --branch gitian-test

Improvement in mind
It could be used like that, but some possible improvement are also possible before merging. I think I will investigate about the following from @patricklodder comment :

Make a GH Actions (since this is targeting 1.14) script outputting hashes, that triggers on changes to:

./depends
./contrib/gitian-descriptors
./contrib/gitian-builder (this set of scripts)

Any automated initialization should never touch pgp secret keys, so without those, it'd be fine to include. There's a section about external signing in the gitian doc and that should imho be the best practice anyway as this allows for keeping secrets in a protected environment while allowing a build machine to just connect freely and download things. (i.e. from a security p.o.v. there are different requirements to secure pgp secrets vs the gitian builder itself.)

+ Possibility to configure apt-cacher (@patricklodder may apt-cacher be useful for CI or something else, even personally ?) ?
P.S. : Sorry for parallel PR with #2396, I had the choice between PR @micaelmalta's repo to include my changes or create a new PR to Dogecoin Core repo. Thought it was more appropriate to do it that way.

External signing enabled. What would be the file to check to verify hashes of depends/, gitian-descriptors/ & gitian-build.sh with GitHub action ?

Just added --enable-apt-cacher option to use an apt-cacher server.

Get a response from devrandom, gitian-builder repository is going in maintenance mode because bitcoin is switching to guix build process. Did you already plan to switch to guix with 1.21 ?

Did you already plan to switch to guix with 1.21 ?

Not to my knowledge. I'd say we'd need to run both in parallel for a while. We can always fork gitian-builder and maintain what we need until we no longer need it.
Can we build something on the CI without removing apt-cacher? yes I think so. Question to you: what's the impact of not removing it to the success of this PR?

Or a patch ? If it needs only this change, imo the fork doesn't worth it.
At first, would you like to keep this feature to enable gitian without apt-cacher ? Easy to remove, but may be great to facilitate signing, even more if we keep it for a while.

At first, would you like to keep this feature to enable gitian without apt-cacher ?

Maybe we should break it up into 2 steps:

Make it work without patching anything so that the script and documentation are up-to-date
Find the smallest possible patch to enable direct building.

The change in descriptor names from signer to signed is undocumented and incompatible with the current state of 1.21

If undo this change, I go with signer. It was not introduced by me, but it looks like it was done to make executables names consistent with gitian descriptor.
Fixed comments, using only apt-cacher.

If undo this change, I go with signer.

Yes, I think signer is good because that's what it has been since forever? I'd just edit the commit, I'll anyway request a squash on the first 2 commits, so may as well just rename back and --amend.

We can't build signed binaries now, right ?

We can. We're just not doing it. At least for Windows. For macOS we're doing it but with the new Apple requirements it's a bit more complicated than what we have right now.

I saw some comments where you were working on signatures.

Correct. I went into a bit of a rabbit hole to also figure out how to do the signed submissions to Apple to get rid of the security warning there. I hope to have a complete picture of what needs to get done over the next week, otherwise we should first fix Windows and then worry about macOS.

I propose to remove KVM support from this script if this is not documented

I'm not sure what should be strategy for KVM support. You suggest removing references within the script (your current suggestions are cleaning it for the documentation, not the script) ?
It's possibly not so far from working, I wasn't able to use LXC & KVM to test it (mysterious error where I did no investigated too long, never used this tools), but I hope it's designed to (almost) work for someone who know it.
What I had in mind is to keep KVM support as incomplete and state it as incomplete in the expectation someone will try & fix it. It has less opportunity to happen if we remove all content related to kvm.
From Karl Fogel - Producing Open Source Software How to Run a Successful Free Software Project :

Label the areas where the documentation is known to be incomplete. By showing the readers that you are aware of its deficiencies, you align yourself with their point of view. Your empathy reassures them that they don't face a struggle to convince the project of what's important. These labels needn't represent promises to fill in the gaps by any particular date —it's equally legitimate to treat them as open requests for volunteer help

Are you sure you want to remove KVM (personally, I'm in favor of keeping it) ?

I'm okay with keeping it but could you then please document how far you got with it? What errors did you run into?

I wasn't able to use LXC & KVM

As for LXC, the gitian-builder side definitely works because since #2501 I build it, so it's on my todo to test end-to-end with this script and we'll get that done.

KVM
First, on debian the installation of kvm required to find manually package, I possibly used the wrong one. I used python-vm-builder 0.12.4, python-cheetah 2.4.4, ubuntu-keyring 2<IP_ADDRESS>(?).
When building the base vm for bionic, it's throwing the following error:
VMBuilder.exception.VMBuilderUserError: Invalid suite: "bionic". Valid suites are: dapper gutsy hardy intrepid jaunty karmic lucid maverick natty oneiric precise quantal raring saucy trusty utopic vivid wily xenial

I tried with trusty, modified the gitian-descriptor to fit this, but on gbuild the container do not start/can't be connected. It gets an ssh error:
--- Building for trusty amd64 ---
Stopping target if it is up
Making a new image copy
qemu-img: warning: Deprecated use of backing file without explicit backing format (detected format of qcow2)
Formatting 'target-trusty-amd64.qcow2', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=13957595136 backing_file=base-trusty-amd64.qcow2 backing_fmt=qcow2 lazy_refcounts=off refcount_bits=16
Starting target
Checking if target is up..............................
ssh: connect to host localhost port 2223: Connection refused

LXC
I'm able to build base image, to start gbuild step. I'm having trouble with apt sources. Not able to find packages during install steps, configuration issue with apt-cacher:
abcsxyz:~$ ./gitian-build.sh  --setup --build --lxc -o l 1.14.5
pdating apt-get repository (log in var/install.log)
Installing additional packages (log in var/install.log)
Traceback (most recent call last):
        6: from ./bin/gbuild:334:in `<main>'
        5: from ./bin/gbuild:334:in `each'
        4: from ./bin/gbuild:336:in `block in <main>'
        3: from ./bin/gbuild:336:in `each'
        2: from ./bin/gbuild:341:in `block (2 levels) in <main>'
        1: from ./bin/gbuild:120:in `build_one_configuration'
./bin/gbuild:23:in `system!': failed to run on-target -u root -e DEBIAN_FRONTEND=noninteractive apt-get --no-install-recommends -y install curl g++-aarch64-linux-gnu g++-7-aarch64-linux-gnu gcc-7-aarch64-linux-gnu binutils-aarch64-linux-gnu g++-arm-linux-gnueabihf g++-7-arm-linux-gnueabihf gcc-7-arm-linux-gnueabihf binutils-arm-linux-gnueabihf g++-7-multilib gcc-7-multilib binutils-gold git-core pkg-config autoconf libtool automake faketime bison bsdmainutils ca-certificates python3 >> var/install.log 2>&1 (RuntimeError)

install.log:
mesg: ttyname failed: Inappropriate ioctl for device
Err:1 http://<IP_ADDRESS>:3142/archive.ubuntu.com/ubuntu bionic InRelease
  Could not connect to <IP_ADDRESS>:3142 (<IP_ADDRESS>). - connect (113: No route to host)
Err:2 http://<IP_ADDRESS>:3142/security.ubuntu.com/ubuntu bionic-security InRelease
  Unable to connect to <IP_ADDRESS>:3142:
Err:3 http://<IP_ADDRESS>:3142/archive.ubuntu.com/ubuntu bionic-updates InRelease
  Unable to connect to <IP_ADDRESS>:3142:
[....]
 I've the good hope that people who understand those tools are able to use the script 😅

I am not happy with Paxful. After depositing some funds to my paxful account, they prompted me to send my ID for verification. I did and they rejected my ID for verification of my account and also Froze My Paxful account. I had a huge some of amount in that account and it was almost a month with no response from them until a colleague recommended JimFundsRecovery at Consultant dot Com, within few days they recovered all funds and logins to my paxful account, really appreciate

@QuentinFlores - reported again for scam posts.

I've got this to work with LXC (and with apt-cache), but gitian-builder is broken for creating non-docker ubuntu base images so I had to patch things up. I've done a PR on devrandom's repo to fix that, so that I can test this end-to-end without patching anything.
Looking at the issues we're running into, perhaps we should pin to a gitian-builder commit in the script by default. I'll propose that separately after we merge this one.

The PR on gitian-builder has been merged, so this should now work for both Docker and LXC base images again. Will test this over the weekend.

Hi, are you able to do it on your own ? I deleted my fork, as I do not expect to work anymore on Dogecoin, just leaving my work/PRs to be reused.

Even better, I can do it for you.
Am sad to hear that, but thank you for everything you have done! ❤

Merged with #2973! Many thanks! ❤


mvc: dashboard: Logging a lot of firewall rules impacts dashboard performance on default layout

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
Using the default dashboard and triggering the logging of many firewall rules can impact dashboard performance up to the point of freezing the client side browser window.
It is only a client side browser issue. Restarting the browser fixes this.
To Reproduce
Steps to reproduce the behavior:

Create a firewall rule that has logging enabled
The Firewall widget has to be present on the dashboard
Use hping to send lots of packets that trigger the prior created rule: hping3 -S -p "$TARGET_PORT" --flood "$TARGET_IP"
Have the dashboard open at the same time, the dashboard will slow down and freeze and the RAM the browser uses will steadily increase

Expected behavior
The firewall live-log widget and the dashboard continues to work even though a lot of rules are logged.
Environment
OPNsense 24.7.6 (amd64)

https://github.com/opnsense/core/commit/2e50dc12de082624844aff65932a994ed458d39f should be enough to address the issue on the short term, longer term a solution is needed to increase accuracy of the event count without introducing a lot of complexity

I have tested this and it indeed prevents the dashboard from freezing up.

I have tested this and it indeed prevents the dashboard from freezing up.

I jealous of you, I have the same issue, it hangs after a couple dozen seconds.

I jealous of you, I have the same issue, it hangs after a couple dozen seconds.

@tribalRu Is this still the case for you on the latest community (24.7.7)? Otherwise I'll close this ticket.

Looks like it's working. ;)


Onboarding flow  :Signing in with secret key

The user  is testing version v3.2.0

An user signs in with a secret key
Upon receiving the password screen, the user realized that it was a wrong account
User selects the back arrow and it landed on "Back up your secret key page" instead of the "Sign in with your secret key page"

Attaching screen recording for perusal
https://user-images.githubusercontent.com/38872890/156217576-e4c9e116-b4e4-4527-9630-2abbd594618c.mov
The issue was found by @andresgalante hence reporting it accordingly.

Good catch. This is unexpected behavior and a possible security issue, because the key is shown in plain text on the previous screen, which might be exposed inadvertently upon going back.


[ComboBoxListItemPicker] defaultSelectedItems not working

Category
[ ] Enhancement
[x] Bug
[ ] Question
Version
Please specify what version of the library you are using: [ 3.3.0 ]
Expected / Desired Behavior / Question
defaultSelectedItems should select default dropdown options
Observed Behavior
Property not working
Steps to Reproduce
Pass a key to defaultSelectedItems property

Hey @joelfmrodrigues, real glad too see that you've spotted and fixed this, just ran into it. Do you know when this might be deployed?
And while I'm at it, might I ask the same question about #936?
P.s. Sorry for bugging you like this, but I've got a project waiting for both 😇

@joelfmrodrigues - could you please specify the version when it was fixed?

@Katli95 this should be available since 3.4.0.
I'm sure it's working now as I worked on a project this week where it's being used


Update README.md to warn of API restriction that break functionality

LinkedIn has heavily restricted there API so much of this repo's functionality is now broken. I found out the hard way but this repo should really now have a warning to new users.
Cheers

Specifically, these are the only functionalities currently supported, based on the TNW article:
From May 12, LinkedIn will limit its open APIs to just four uses:

allowing members to represent their professional identity via their LinkedIn profile using our Profile API.
enabling members to post certifications directly to their LinkedIn profile with our Add to Profile tools.
enabling members to share professional content to their LinkedIn network from across the Web leveraging our Share API.
enabling companies to share professional content to LinkedIn with our Company API.

This means that the following functionalities listed on readme.md are no longer supported without being a Linkedin Partner:

get_connections  api
search api
group api
company api
jobs api
network api
invitation api


Feature coinjoin prepare

Issue being fixed or feature implemented

Prepare for coinjoin:

add a DIP9 type derivation path for coinjoin keys (used after mixing)
Add coinjoin keychain to Wallet and some helper methods
Add many classes and methods that to coinjoin

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have made corresponding changes to the documentation

For repository code-owners and collaborators only

[ ] I have assigned this pull request to a milestone

before merging the feature-coinjoin branch should be rebased to master.


Make it remeber previous tabs

hi, i'm using your excellent extension and would like to request a new feature. Currently, when switching between files, the extension reprocesses them, which can be time-consuming.
To enhance the user experience, could you implement a feature that remembers the highlights of files until they are closed? This would significantly reduce the time required for file switching and improve overall performance.

The commit https://github.com/MickaelBlet/highlight-regex/commit/df9059a4a5863b68c8e1d5de246ccce787ca3f10  solved the issue.


Support for Asus Tinkerboard

I have added a new function, Toggle()
I have also added support for Asus Tinkerboard and Asus Tinkerboard S
Maybe you want to add a switch statement so support can be offered for both OS in 1 file.
This pull request is in case you like any of my changes.

How can I see if there are other nodes other than tinker_mcu_bl ?
I only know about this one from https://tinkerboarding.co.uk/forum/thread-2048-post-8814.html#pid8814
When I tried all the variables you had set, none worked. How to get a list of other nodes like power?

How can I see if there are other nodes other than tinker_mcu_bl?

la -al sys/devices/platform/ff150000.i2c/i2c-3/3-0045/

Here is the output. Please let me know next steps.

Sorry, I missed a leading slash there:
ls -al /sys/devices/platform/ff150000.i2c/i2c-3/3-0045/

Thanks for making many of the requested changes already!

That's weird. Is there really a space here? If so, try removing it:
                           ↓
ls -al /sys/devices/platfor m/ff150000.i2c/i2c-3/3-0045/

That's weird. Is there really a space here? If so, try removing it:
                           ↓
ls -al /sys/devices/platfor m/ff150000.i2c/i2c-3/3-0045/

root@TinkerBoardS2:/sys/bus/i2c/drivers/tinker_mcu # ls -al /sys/devices/platform/ff150000.i2c/i2c-3/3-0045/
total 0
drwxr-xr-x 3 root root    0 Apr  6 20:56 .
drwxr-xr-x 6 root root    0 Apr  6 20:56 ..
-r--r--r-- 1 root root 4096 Apr  6 20:56 modalias
-r--r--r-- 1 root root 4096 Apr  6 20:56 name
lrwxrwxrwx 1 root root    0 Apr  6 20:56 of_node -> ../../../../../firmware/devicetree/base/i2c@ff150000/tinker_mcu@45
drwxr-xr-x 2 root root    0 Apr  6 20:56 power
lrwxrwxrwx 1 root root    0 Apr  6 20:56 subsystem -> ../../../../../bus/i2c
-rw-r--r-- 1 root root 4096 Apr  6 20:56 uevent

I've added an initial switch statement based on OS. Haven't tested it yet. Can you just sanity check it before I do a polish pass, make sure it's what you want?

That looks great, thanks a lot! It's super late here (UK), I'll add a few suggestions tomorrow - basically, instead of this:
if MODE=="TINKERBOARD":
    return int(_get_value("tinker_mcu_bl"))
elif MODE=="PI":
    return int(_get_value("actual_brightness"))

let's do this:
MODE_TINKERBOARD = "TINKERBOARD
MODE_RPI = "RPI"

if MODE == MODE_TINKERBOARD:
    return int(_get_value("tinker_mcu_bl"))
elif MODE == MODE_RPI:
    return int(_get_value("actual_brightness"))

Also, in Python

if something == True:
if something == False:
if something == None:

shouldn't be used. Instead, use

if something is True:
if something is False:
if something is None:

The preferred, pythonic versions are

if something:
if not something:
if something is None:

elif MODE == MODE_RPI:

Thanks! I actually recently taught myself Python, so thanks for these tips. I've made these changes. I will test now.

I realized my mistake earlier.
Here is the answer you were looking for. power is a FOLDER. Cannot be echoed to.
root@TinkerBoardS:/home/linaro/rpi-backlight # ls -al /sys/devices/platform/ff150000.i2c/i2c-3/3-0045/
total 0
drwxr-xr-x 3 root root    0 Apr  6 23:16 .
drwxr-xr-x 6 root root    0 Mar 14 20:00 ..
lrwxrwxrwx 1 root root    0 Apr  6 20:30 driver -> ../../../../../bus/i2c/drivers/tinker_mcu
-r--r--r-- 1 root root 4096 Apr  6 20:30 modalias
-r--r--r-- 1 root root 4096 Apr  6 20:30 name
lrwxrwxrwx 1 root root    0 Apr  6 20:30 of_node -> ../../../../../firmware/devicetree/base/i2c@ff150000/tinker_mcu@45
drwxr-xr-x 2 root root    0 Apr  6 20:30 power
lrwxrwxrwx 1 root root    0 Mar 14 20:00 subsystem -> ../../../../../bus/i2c
-rw-rw-rw- 1 root root 4096 Mar 23 13:55 tinker_mcu_bl
-rw-r--r-- 1 root root 4096 Mar 14 20:00 uevent
root@TinkerBoardS:/sys/devices/platform/ff150000.i2c/i2c-3/3-0045/power # ls
async                 runtime_active_kids  runtime_status
autosuspend_delay_ms  runtime_active_time  runtime_suspended_time
control               runtime_enabled      runtime_usage

I've made a few changes
On, Off, Toggle, now support smooth and duration
Smooth is default to True
I wasn't able to make the constants work so I used global variables.
Why is minimum brightness 10 for RPI? And not 0?

Please revert your recent changes! Let's keep the focus of this PR to adding support for Asus Tinkerboard and please don't make any changes breaking the current API (renaming functions, changing default parameters). Think of users of this library, once they update their installation it would break their code.

I've renamed the function
I figured with the new set_brightness_value it would be more consistent to have get_brightness_value

Did you have a chance to review this? See what this power control is?
root@TinkerBoardS:/home/linaro/rpi-backlight # cd /sys/devices/platform/ff150000.i2c/i2c-3/3-0045/
root@TinkerBoardS:/sys/devices/platform/ff150000.i2c/i2c-3/3-0045 # ls -al
total 0
drwxr-xr-x 3 root root    0 Apr  7 14:20 .
drwxr-xr-x 6 root root    0 Apr  7 14:20 ..
lrwxrwxrwx 1 root root    0 Apr  7 14:20 driver -> ../../../../../bus/i2c/drivers/tinker_mcu
-r--r--r-- 1 root root 4096 Apr  7 14:20 modalias
-r--r--r-- 1 root root 4096 Apr  7 14:20 name
lrwxrwxrwx 1 root root    0 Apr  7 14:20 of_node -> ../../../../../firmware/devicetree/base/i2c@ff150000/tinker_mcu@45
drwxr-xr-x 2 root root    0 Apr  7 14:20 power
lrwxrwxrwx 1 root root    0 Apr  7 14:20 subsystem -> ../../../../../bus/i2c
-rw-rw-rw- 1 root root 4096 Apr  7 14:17 tinker_mcu_bl
-rw-r--r-- 1 root root 4096 Apr  7 14:20 uevent
root@TinkerBoardS:/sys/devices/platform/ff150000.i2c/i2c-3/3-0045 # ls -al powertotal 0
drwxr-xr-x 2 root root    0 Apr  7 14:20 .
drwxr-xr-x 3 root root    0 Apr  7 14:20 ..
-rw-r--r-- 1 root root 4096 Apr  7 14:20 async
-rw-r--r-- 1 root root 4096 Apr  7 14:20 autosuspend_delay_ms
-rw-r--r-- 1 root root 4096 Apr  7 14:20 control
-r--r--r-- 1 root root 4096 Apr  7 14:20 runtime_active_kids
-r--r--r-- 1 root root 4096 Apr  7 14:20 runtime_active_time
-r--r--r-- 1 root root 4096 Apr  7 14:20 runtime_enabled
-r--r--r-- 1 root root 4096 Apr  7 14:20 runtime_status
-r--r--r-- 1 root root 4096 Apr  7 14:20 runtime_suspended_time
-r--r--r-- 1 root root 4096 Apr  7 14:20 runtime_usage
root@TinkerBoardS:/sys/devices/platform/ff150000.i2c/i2c-3/3-0045 #

Anything else need changing for pull?

Yes - https://github.com/linusg/rpi-backlight/pull/13#issuecomment-480551493

Yes - #13 (comment)

I added the constants in and fixed the trues

Yes - #13 (comment)

Fixed

Thanks! I'll do a final review this evening and then hopefully we can merge this. Thanks for bearing with me!
I'll make a few other, unrelated changes (like normalizing the input of set_brightness to 0-100) and then this will most likely make it into a 2.0.0 release, so we don't have to worry about backwards compatibility that much.

Thanks for putting up with my noobiness.
Pls re-review changes.

@linusg Hi, any plan to incorporate this support for the Asus TinkerBoard?

Hi @p1r473, I'm afraid this won't be possible with this PR as it's based on the old v1 source code. If you still want to add support for the Asus TinkerBoard, please open a new PR (this one is quite big already) which I'd be happy to merge!
The implementation could be quite simple, just add something like a Board.RASPBERRY_PI, Board.TINKER_BOARD enum (that feels a bit cleaner than the MODE_* constants), and instead of having to make this global state we can just add a board parameter to the Backlight constructor and use that for wrapping something like self._set_value("bl_power", int(not on)) in a condition.


Fix the generator_inputs optimization.

DO NOT SUBMIT: For testing only.
If it improves builds (it does for me locally), we'll release a 4.1 and update angular_compiler.
To try it, clone/fetch this PR, and add the following:
dependency_overrides:
  angular:
    path: ../angular/angular
  angular_compiler:
    path: ../angular/angular_compiler

When running pub serve -v you should see something like:
Avoiding a lookup on angular|lib/src/core/security.dart (matched generator_inputs)
... many many times.
/cc @kevmoo

No speed improvement as far as I can see...

@kevmoo Could you share your pub serve -v?

Abandoned for now.


Add Selectionsort algorithm

Hello , I want to contribute to add sorting algorithm Selectionsort.

@ShraddhaDevaiya I think Selection Sort algorithm is already available. Please have a check.

Sorry ,yeah  it is available. can you suggest any other one if possible?

@ShraddhaDevaiya , you may run through the entire codebase once, in order to learn which algorithms can be added.


Incorrect date format when in response object

Q
A

Bug or feature request?
Bug

Which Swagger-Core version?
2

Which Java version?
8.0

Demonstration API definition
From my API I'm returning a DTO which looks like below
class ResponseDTO  {
     Date CreatedOn;
     Date ModifiedOn;
}

If I look on the swagger UI, I see this

Here, the actual response sent by the server is in long format (number of milliseconds since 1970). But the swagger is showing Date format as "ModifiedOn": "2018-02-20T17:23:58.907Z". Which is kind of misleading.
Expected Behavior
"ModifiedOn": "1519147559685"
Or something like this

That's what 'date' is defined as. If you need it to be in a long format, you need to specify it using the annotations.

I tried that using writing annotations
	@ApiModelProperty(value = "Start time of launch", required=true, dataType = "long")
	private Date createdOn;

I'm getting the same output as above.
Am I missing something?

Which version of swagger-core do you use?

Bump: this is also showing up in the java-jersey2-resourceinit sample (2.0 branch).
Steps to reproduce

Run said sample as per instructions
Go to Swagger-UI at http://localhost:8002
Check example value for route GET /sample/store/order/{orderId}:

Check that schema says that the type for shipDate is a date-time string:

Make a sample request for order 1
The API returns a long value for shipDate, breaking spec:

Suggested fix
In my opinion, either java.util.Date should be mapped to int64 on the spec or it should somehow be output in RFC 3339 format to be spec compatible.

in Swagger Core 2.x there are a few alternatives (sample has been updated with option 3):

annotate your property with @Schema(type = "integer", format = "int64")
customize swagger by adding the following in any bootstrap code

PrimitiveType.customExcludedClasses().add(Date.class.getName());
PrimitiveType.customClasses().put(Date.class.getName(), PrimitiveType.LONG);

depending on the environment, configure its serialization of requests and responses not to use timestamps, e.g. in jersey2:

@Provider
    public class ObjectMapperContextResolver implements ContextResolver<ObjectMapper> {

        private final ObjectMapper mapper;

        public ObjectMapperContextResolver() {
            this.mapper = createObjectMapper();
        }

        @Override
        public ObjectMapper getContext(Class<?> type) {
            return mapper;
        }

        private ObjectMapper createObjectMapper() {
            ObjectMapper mapper = new ObjectMapper();
            mapper.configure(SerializationFeature.WRITE_DATES_AS_TIMESTAMPS, false);
            return mapper;
        }
    }

register(new ObjectMapperContextResolver());

closing ticket, please reopen if you're still experiencing issues

Thanks! Please consider making that default behaviour.


[ISSUE #4767] Refactor Admin server http handler.

Fixes #4767
Motivation
Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.
Modifications
Describe the modifications you've done.
Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

HttpCommand will be deprecated, we will only use requestURI method for http request, no need to add the requestURI for HttpCommand, you can add the @Deprecated annotation for HttpCommand. @karsonto

In addition to the admin server, HttpCommand is also used in the Processor of the http server. This class should not be deprecated. @xwm1992

So HttpCommand shall be deprecated or not?

In addition to the admin server, HttpCommand is also used in the Processor of the http server. This class should not be deprecated. @xwm1992

why not use HttpRequest URL instead of HttpCommand ?

Because in addition to the HttpRequest URL , HttpCommand also wraps other information such as http method header. @xwm1992

Any more problems with the usage of HttpCommand?

Codecov Report
Attention: Patch coverage is 0% with 605 lines in your changes are missing coverage. Please review.

Project coverage is 16.20%.  Consider uploading reports for the commit 57d0c04 to get more accurate results

Files
Patch %
Lines

...ventmesh/runtime/admin/handler/MetricsHandler.java
0.00%
49 Missing :warning:

...esh/runtime/admin/handler/AbstractHttpHandler.java
0.00%
47 Missing :warning:

...ntmesh/runtime/admin/handler/TCPClientHandler.java
0.00%
42 Missing :warning:

...tmesh/runtime/admin/handler/GrpcClientHandler.java
0.00%
39 Missing :warning:

...e/admin/handler/RedirectClientByIpPortHandler.java
0.00%
31 Missing :warning:

...tmesh/runtime/admin/handler/HTTPClientHandler.java
0.00%
29 Missing :warning:

...ime/admin/handler/RedirectClientByPathHandler.java
0.00%
29 Missing :warning:

...dmin/handler/RedirectClientBySubSystemHandler.java
0.00%
27 Missing :warning:

...ime/admin/handler/RejectClientByIpPortHandler.java
0.00%
27 Missing :warning:

.../admin/handler/RejectClientBySubSystemHandler.java
0.00%
26 Missing :warning:

... and 18 more

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #4768       +/-   ##
=============================================
+ Coverage          0   16.20%   +16.20%
- Complexity        0     1711     +1711
=============================================
  Files             0      856      +856
  Lines             0    30898    +30898
  Branches          0     2684     +2684
=============================================
+ Hits              0     5007     +5007
- Misses            0    25424    +25424
- Partials          0      467      +467

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@xwm1992 @Pil0tXia I have revised it according to your suggestion.

@Pil0tXia All the issues mentioned previously have been resolved.


Refactors in controllers with many responsibilities

Summary

Refactor several controllers to have controllers with crud methods

Nice refactor! 👍


fixes #2389

truncating expert param storage for checkpointing

@clumsy please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

Contributor License Agreement

@microsoft-github-policy-service agree [company="Amazon"]

@tjruwase Could you please help me identify why some of these unit tests fail? It's mostly related to sparse attention which is seemingly unrelated to my change. And there are also 2 tests (but not all) failing with CUDA out of memory for MoE checkpointing which I didn't get for my device.

@clumsy We were seeing problems with our self-hosted CI runners yesterday. I believe they are resolved now. I have re-run the failing jobs, and they should pass this time.

Oh, that makes sense. Thanks, @mrwyattii! It looks like all but one check passed now. And the one that failed - looks like it failed the same way in a seemingly unrelated to my change place. Do we need to rerun it again?

Let me take a closer look at this today - not sure why it's failing

Looks like tests are passing, with exception of one inference test that is getting OOM error. It's unrelated to any changes in this PR, so I'll merge it anyway


clamav: 1.3.1 -> 1.4.0

The previous version, 1.3.1, has recently stopped building due to some certifications used in the tests are out of date.
Fixes https://github.com/NixOS/nixpkgs/issues/334852
Description of changes
Update which version is fetched and the corresponding hash.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Pinging maintainers as well @robberer @qknight @globin

Please update commit message to clamav: 1.3.1 -> 1.4.0

Apparently the three are silently retired.

I'll merge if CI is happy

I'm not sure those darwin passthroughs are ever gonna finish...


Credits

Hello, will be great if you add a section on your readme giving credits from where you get the code.
Regards

Hello @Krato , I have done this 👍


Snap effect when transitioning out of a component.

I am trying to have an animation every time the picture component gets changed. The first animation when the page loads , is fine.  I don't understand why this snap effect is happening. How do i fix this ?
https://codesandbox.io/s/wn6jp23vxl

it's easier to think of spring as a value interpolator, it doesn't do magic. if you want two elements on top of one another in css you need to position them absolutely. you can do this in plain css classes or even in the spring definition, for instance from: { position: 'absolute', ...

I tried giving 'absolute' property for the component which I am animating but no luck :(

Can u please post what I can fix on that codesandbox i shared  ?


istioctl validate doesn't validate open api spec

$ ~/istio/istio-1.6.0/bin/istioctl validate -f /tmp/bad.yaml
"/tmp/bad.yaml" is valid
$ kubectl apply -f /tmp/bad.yaml
error: error validating "/tmp/bad.yaml": error validating data: ValidationError(VirtualService.spec): unknown field "bad" in io.istio.networking.v1alpha3.VirtualService.spec; if you choose to ignore these errors, turn validation off with --validate=false

config:
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: route
spec:
  hosts:
  - alpine
  http:
  - route:
    - destination:
        host: alpine
  bad: foo

cc @esnible

$ go run ./istioctl/cmd/istioctl analyze  /tmp/bad.yaml
Error [IST0101] (VirtualService route.repro /tmp/bad.yaml:1) Referenced host not found: "alpine"
Error: Analyzers found issues when analyzing namespace: repro.
See https://istio.io/docs/reference/config/analysis for more information about causes and resolutions.
exit status 79

Analyze also doesn't catch it

🥳


e2e density failed on Mkdir

While debugging #8918, density test failed due to failure of Mkdir. cc @jayunit100
Density
[Performance suite] should allow starting 3 pods per node
/go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/density.go:184
[BeforeEach] Density
/go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/density.go:65

testContext.KubeConfig: /usr/local/google/home/dawnchen/.kube/config
[AfterEach] Density
/go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/density.go:92
STEP: Destroying namespace for this suite e2e-tests-density-54fc1e5e-f0bb-4721-a780-fb7854dd4e57

• Failure in Spec Setup (BeforeEach) [0.448 seconds]
Density
/go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/density.go:186
[Performance suite] should allow starting 3 pods per node [BeforeEach]
/go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/density.go:184
Expected error:
<*os.PathError | 0xc2086b9140>: {
Op: "mkdir",
Path: "a78fb485-0e35-11e5-9a26-24be050deb0e",
Err: 0xd,
}
mkdir a78fb485-0e35-11e5-9a26-24be050deb0e: permission denied
not to have occurred

Looking into this now

@dchen1107 heres what is happening.
If you launch without the --e2e-output-dir option, it will write to /tmp.  Like this...
[jay@rhbd kubernetes]$ _output/local/bin/linux/amd64/e2e.test --provider=local --host=http://<IP_ADDRESS>:8080 --ginkgo.focus="Density" --kubeconfig=/opt/kube-creds

Which results in something like:
$> ls /tmp/797b81bd-0e43-11e5-91bf-3c970e4b8bbd/
block_before.txt
goroutine_before.txt
heap_before.txt
metrics_before.txt
pod_states.csv
threadcreate_before.txt

Is this fixable via a simple chmod ?

I've just run density.go from head, works for me... modifying a couple parameters to make it run faster, i got...
_output/local/bin/linux/amd64/e2e.test --provider=local --host=http://<IP_ADDRESS>:8080 --ginkgo.focus="Density" --kubeconfig=/opt/kube-creds  --e2e-output-dir=./

results in...
Quantile:0.99 Latency:13.43ms}

• [SLOW TEST:39.240 seconds]
Density
/home/jay/gopath/src/github.com/GoogleCloudPlatform/kubernetes/_output/local/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/density.go:187
  [Performance suite] should allow starting 5 pods per node
  /home/jay/gopath/src/github.com/GoogleCloudPlatform/kubernetes/_output/local/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/density.go:185
------------------------------
SSSSSSSSSSSSSSSSSSSSSSSSS
------------------------------
Density
  [Skipped] [Performance suite] should allow starting 1 pods per node
  /home/jay/gopath/src/github.com/GoogleCloudPlatform/kubernetes/_output/local/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/density.go:185
[BeforeEach] Density
  /home/jay/gopath/src/github.com/GoogleCloudPlatform/kubernetes/_output/local/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/density.go:66
>>> testContext.KubeConfig: /opt/kube-creds
INFO: Waiting up to 2m0s for service account default to be provisioned in ns e2e-tests-density-a7967130-42bf-41c4-8431-5242f1cfef55
INFO: Get service account default in ns e2e-tests-density-a7967130-42bf-41c4-8431-5242f1cfef55 failed, ignoring for 5s: serviceaccounts "default" not found
INFO: Service account default in ns e2e-tests-density-a7967130-42bf-41c4-8431-5242f1cfef55 found. (5.005975645s)
[It] [Skipped] [Performance suite] should allow starting 1 pods per node
  /home/jay/gopath/src/github.com/GoogleCloudPlatform/kubernetes/_output/local/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/density.go:185
STEP: 2015-06-08 21:56:06.142897471 -0400 EDT Creating replication controller density1-b0c66b5a-0e4a-11e5-8be3-3c970e4b8bbd
INFO: 2015-06-08 21:56:06.146343456 -0400 EDT Created replication controller with name: density1-b0c66b5a-0e4a-11e5-8be3-3c970e4b8bbd, namespace: e2e-tests-density-a7967130-42bf-41c4-8431-5242f1cfef55, replica count: 1
STEP: Making sure all 1 replicas of rc density1-b0c66b5a-0e4a-11e5-8be3-3c970e4b8bbd in namespace e2e-tests-density-a7967130-42bf-41c4-8431-5242f1cfef55 exist
INFO: 2015-06-08 21:56:07.146524111 -0400 EDT Controller density1-b0c66b5a-0e4a-11e5-8be3-3c970e4b8bbd: Found 0 pods out of 1
INFO: 2015-06-08 21:56:08.146816813 -0400 EDT Controller density1-b0c66b5a-0e4a-11e5-8be3-3c970e4b8bbd: Found 1 pods out of 1
INFO: 2015-06-08 21:56:08.146881501 -0400 EDT Controller density1-b0c66b5a-0e4a-11e5-8be3-3c970e4b8bbd in ns e2e-tests-density-a7967130-42bf-41c4-8431-5242f1cfef55: Found 1 pods out of 1
STEP: 2015-06-08 21:56:08.146900674 -0400 EDT Waiting for all 1 replicas to be running with a max container failures of 1
INFO: Pod States: 0 running, 0 pending, 0 waiting, 0 inactive, 0 unknown
INFO: Pod States: 0 running, 1 pending, 0 waiting, 0 inactive, 0 unknown
INFO: Pod States: 0 running, 1 pending, 0 waiting, 0 inactive, 0 unknown
INFO: Pod States: 0 running, 1 pending, 0 waiting, 0 inactive, 0 unknown
INFO: Pod States: 1 running, 0 pending, 0 waiting, 0 inactive, 0 unknown
INFO: E2E startup time for 1 pods: 5.004807699s
STEP: Waiting for all events to be recorded
INFO: Found 7 events
INFO: - reason: successfulCreate, source: replication-controller -> 1
INFO: - reason: scheduled, source: scheduler -> 1
INFO: - reason: pulled, source: kubelet -> 1
INFO: - reason: created, source: kubelet -> 2
INFO: - reason: started, source: kubelet -> 2
[AfterEach] Density
  /home/jay/gopath/src/github.com/GoogleCloudPlatform/kubernetes/_output/local/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/density.go:93
STEP: Cleaning up the replication controller
STEP: Deleting replication controller density1-b0c66b5a-0e4a-11e5-8be3-3c970e4b8bbd in namespace e2e-tests-density-a7967130-42bf-41c4-8431-5242f1cfef55
INFO: Deleting RC took: 2.016810706s
STEP: Destroying namespace for this suite e2e-tests-density-a7967130-42bf-41c4-8431-5242f1cfef55
INFO: Top latency metric: {Verb:LIST Resource:pods Quantile:0.99 Latency:17.287ms}
INFO: Top latency metric: {Verb:LIST Resource:nodes Quantile:0.99 Latency:17.253ms}
INFO: Top latency metric: {Verb:PUT Resource:replicationcontrollers Quantile:0.99 Latency:15.84ms}
INFO: Top latency metric: {Verb:PUT Resource:pods Quantile:0.99 Latency:14.959ms}
INFO: Top latency metric: {Verb:POST Resource:pods Quantile:0.99 Latency:13.43ms}

• [SLOW TEST:22.173 seconds]
Density
/home/jay/gopath/src/github.com/GoogleCloudPlatform/kubernetes/_output/local/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/density.go:187
  [Skipped] [Performance suite] should allow starting 1 pods per node
  /home/jay/gopath/src/github.com/GoogleCloudPlatform/kubernetes/_output/local/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/density.go:185
------------------------------
SSSSSSSSSSS
Ran 4 of 72 Specs in 134.827 seconds
SUCCESS! -- 4 Passed | 0 Failed | 0 Pending | 68 Skipped PASS
[jay@rhbd kubernetes]$ git log | head -1
commit b68e08f55f5ae566c4ea3905d0993a8735d6d34f
[jay@rhbd kubernetes]$ git log head -2
fatal: ambiguous argument 'head': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
[jay@rhbd kubernetes]$ git log head -3
fatal: ambiguous argument 'head': unknown revision or path not in the working tree.
 I believe that
<*os.PathError | 0xc2086b9140>: {
Op: "mkdir",
Path: "a78fb485-0e35-11e5-9a26-24be050deb0e",
Err: 0xd,
}

means that there's no --e2e-output-dir set.
You're running slightly too old version. You need to sync up to 640c40d which fixes this problem by adding /tmp in front of UUID, or cherrypick mine (#9316) or @jayunit100 (#9351) PR that fixes this problem.

I synced to HEAD, and the issue is fixed. Thanks!


TypeError: Could not load virtual:#sitemap/global-sources.mjs (imported by node_modules/@nuxtjs/sitemap/dist/runtime/nitro/sitemap/urlset/sources.mjs): Converting circular structure to JSON     --> starting at object with constructor 'Array'     --- index 4 closes the circle

Hello, I am getting this error after adding @nuxtjs/sitemap in nuxt.config.ts.
Version of @nuxtjs/sitemap  = ^5.1.5.
export default defineNuxtConfig({
...
    sitemap: {
        urls: generateSitemap,
    },
...
})

and generateSitemap async function returns array of objects for sitemap.

Can you post a sample of the data output? I don't think it's outputting the expected data.


Can't update WSL2

Windows Version
Microsoft Windows [Versión 10.0.22623.1325]
WSL Version
unkown
Are you using WSL 1 or WSL 2?

[X] WSL 2
[ ] WSL 1

Kernel Version
unknown
Distro Version
any distro
Other Software
No response
Repro Steps
I try to run any wsl command in Power Shell or CMD.
E.g.
$ wsl
$ wsl --version
$ wsl --update
$ wsl --update --rollback
etc.
Expected Behavior
It should perform the corresponding operation
Actual Behavior
I get in the terminal:
"
WSL is finishing an upgrade...
Update failed (exit code: 1603).
Error code: Wsl/CallMsi/E_ABORT
"
Diagnostic Logs
WslLogs-2023-09-21_18-15-02 (2).zip
WSL2 was working perfectly fine yesterday.
Today I got the error described in Actual Behavior. The odd thing is that I can create a new Windows account and run wsl --install and everything is fine; but as soon as I run wsl --update, I get the above error, and furthermore, I cannot use any wsl command.
The last build I had is: 22623.1 (gotten from running (gcm wsl).Version in Power Shell)
The last kernel I had is: Linux <IP_ADDRESS>-microsoft-standard-WSL2 (gotten from running wslfetch in my Ubuntu 20.24 instance)
Also I do have the wsl component turned on and the virtual machine features. And just in case I ran again:
dism.exe /online /enable-feature /featurename:VirtualMachinePlatform /all /norestart
dism.exe /online /enable-feature /featurename:Microsoft-Windows-Subsystem-Linux /all /norestart
from the wsl install manual

This is a known issue if you run wsl --update in a non elevated terminal. This will be fixed in the next release.
In the mean time, running this command as administrator should fix the issue.

I tried running the terminal as an administrator, and from that terminal I ran the command does that count as running as administrator? or is there a command like sudo in Windows?
Anyhow, the problem was solved by itself after a day. Thank you a lot for your time!

I am also experiencing this, even on an administrative terminal, But I have the cause!
Product: Windows Subsystem for Linux -- Error 1406. Could not write value Name to key \SOFTWARE\Microsoft\Terminal Server Client\Default\OptionalAddIns\WSLDVC_PACKAGE.  System error .  Verify that you have sufficient access to that key, or contact your support personnel.

I have discovered a fix for you administrative issue in this regards, go into regedit and navigate to \HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Terminal Server Client\ then select the DEFAULT key and take ownership via setting permissions, then delete it and re-create it.
WSL should proceed to allow you to install and update. This has not bricked my PC but please do note that playing with registry values is very risky and can brick your machine. I only do this because I have specific recovery software I can use. So please be cautious.
Have a nice day! 😄

I am also experiencing this, even on an administrative terminal, But I have the cause!
Product: Windows Subsystem for Linux -- Error 1406.
Could not write value Name to key \SOFTWARE\Microsoft\Terminal Server Client\Default\OptionalAddIns\WSLDVC_PACKAGE.  System error .
Verify that you have sufficient access to that key, or contact your
support personnel.

Oh that's interesting. @NotConspicuous could you share the complete install log file ?

I am also experiencing this, even on an administrative terminal, But I have the cause!
Product: Windows Subsystem for Linux -- Error 1406.
Could not write value Name to key \SOFTWARE\Microsoft\Terminal Server Client\Default\OptionalAddIns\WSLDVC_PACKAGE.  System error .
Verify that you have sufficient access to that key, or contact your
support personnel.

Oh that's interesting. @NotConspicuous could you share the complete install log file ?

Not really, this error originates on the event logger and no installer logs are left behind. This is as much as I can get. Some details here, It occurs because the user nor the system cannot edit the key \SOFTWARE\Microsoft\Terminal Server Client\Default due to some error reading it; not even regedit can add or view values inside the key (Possibly corruption? Cannot confirm.)
The error originates from the MSInstaller Service.

At least, no logs are left behind to what I can see.

Ok I see. You'd need to collect MSI logs manually.
Could try to downloading the MSI and install it via (elevated cmd.exe):
msiexec.exe /i <path-to-msi> /L*V C:\wsllogs.txt
and then share C:\wsllogs.txt

Ok I see. You'd need to collect MSI logs manually.
Could try to downloading the MSI and install it via (elevated cmd.exe):
msiexec.exe /i <path-to-msi> /L*V C:\wsllogs.txt
and then share C:\wsllogs.txt

This may be harder to reproduce since I have fixed the registry key, so I'd need to find a way to reproduce it again. Also, I doubt it's in control of the WSL project since it's more windows related.
I'll reproduce the settings by removing the permissions for TrustedInstaller to see it.

Here's the best I can give you, now I need to forcefully delete this key. AGAIN.
wsllogs.txt

Unfortunately based on the logs it looked like the MSI was already installed so the logs don't actually show the registry error.
Can you try to completely remove the WSL from the control panel (there might be two installed packages, remove all of them), and collect logs again ?

Unfortunately based on the logs it looked like the MSI was already installed so the logs don't actually show the registry error.
Can you try to completely remove the WSL from the control panel (there might be two installed packages, remove all of them), and collect logs again ?

Right, I'll create a windows VM to recreate the issue.

@OneBlue Successfully reproduced perfectly on a clean VM.
wsllogs.txt
This is reproducing a lack of permissions error I described by removing all perms to the key, also may be known as error 1603. Notice the identical Event Viewer Log.

Thanks a lot @NotConspicuous. I see the permission issue indeed:
MSI (s) (50:10) [02:49:37:851]: Executing op: RegOpenKey(Root=-2147483646,Key=SOFTWARE\Microsoft\Terminal Server Client\Default\OptionalAddIns\WSLDVC_PACKAGE,,BinaryType=1,ControlRegistryReflection=0,)
MSI (s) (50:10) [02:49:37:851]: Executing op: RegAddValue(Name=Name,Value=C:\Program Files\WSL\WSLDVCPlugin.dll,)
MSI (s) (50:10) [02:49:37:851]: Note: 1: 1401 2: HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Terminal Server Client\Default\OptionalAddIns\WSLDVC_PACKAGE 3: 5

Can you share a screenshot of the current permissions of that key ? The thing I'm trying to figure out is why this hits on your machine specifically.

Thanks a lot @NotConspicuous. I see the permission issue indeed:
MSI (s) (50:10) [02:49:37:851]: Executing op: RegOpenKey(Root=-2147483646,Key=SOFTWARE\Microsoft\Terminal Server Client\Default\OptionalAddIns\WSLDVC_PACKAGE,,BinaryType=1,ControlRegistryReflection=0,)
MSI (s) (50:10) [02:49:37:851]: Executing op: RegAddValue(Name=Name,Value=C:\Program Files\WSL\WSLDVCPlugin.dll,)
MSI (s) (50:10) [02:49:37:851]: Note: 1: 1401 2: HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Terminal Server Client\Default\OptionalAddIns\WSLDVC_PACKAGE 3: 5

Can you share a screenshot of the current permissions of that key ? The thing I'm trying to figure out is why this hits on your machine specifically.

Sadly I cannot reproduce the specific key's permissions or state beforehand for I don't know what they were in the first place. I'd assume Administrator not having the perms would cause this.

I've had the same issues as above, relating to the same key. Interestingly, the key doesn't actually exist on my machine. I can't create it either, as I get a 'Cannot create a stable subkey under a volatile parent key.' error.

Okay so it turns out that 'have you tried turning it off and back on again' really is the right answer! 😄 After posting the above comment, I rebooted my system. Post-reboot, the WSL upgrade completed successfully, and the previously missing registry key now exists.

Okay so it turns out that 'have you tried turning it off and back on again' really is the right answer sometimes! 😄 After posting the above comment, I rebooted my system. Post-reboot, the WSL upgrade completed successfully, and the previously missing registry key now exists.

Sadly, that wasn't the solution for me, but it does seem that there is a general issue with the key for some reason.

I have the same issue. Note that I upgraded wsl with wsl --update --pre-release many times before from normal pwsh without issue. But somehow this time it didn't work. The log "C:\Users\thegi\AppData\Local\Temp\wsl-install-logs.txt" here:
wsl-install-logs.txt
Then From a administrator pwsh, I tried the same command. It says updated successfully, but afterwards wsl --version still shows <IP_ADDRESS>. Tried twice, same issue.
Then run downloaded the msi from github release and run
msiexec.exe /i C:\Users\thegi\Downloads\wsl.<IP_ADDRESS>.x64.msi /L*V C:\wsllogs.txt

It showed a warning regarding WSL.lnk, but installed succesfully. And wsl --version now shows <IP_ADDRESS>.
Heres: wsllogs.txt

Thank you for reporting this @sarim. I could reproduce the issue and find its root cause. This will be fixed in the next release ! (although you will only see the fix in two releases, since the code that's "upgrading" needs to be fixed)

Thanks, glad to hear the issue has been identified :) So I need to download msi file manually and install it that way for next two releases?

Thanks, glad to hear the issue has been identified :) So I need to download msi file manually and install it that way for next two releases?

Either that, or installing via the store should work starting with the next release

I had trouble with <IP_ADDRESS> & <IP_ADDRESS>: this comment fixes the problem https://github.com/microsoft/WSL/issues/10560#issuecomment-1739355815

Fixed with 2.0.3

im getting a  bunch of problems with wsl2,so much that im planning to change to a live usb with puppy linux on it ...

I'm having the same problem. I'm trying to use WSL on Windows 10 pro. It keeps saying WSL is finishing an upgrade...
After that, it just don't respond to any command I do. If I try to open the ubuntu through the app icon, it asks to press any key. As soon as a press any key, the terminal just closes. I've tried all the supposedly solutions, but nothing worked.

Hi, I was having the same problem.
What worked for me was installing the WSL without a distribution
wsl --install --no-distribution
It installed the WSL, after that, I rebooted my computer
As soon as I logged in, it was already installing ubuntu and it worked fine.

Fixed with 2.0.3

No you didn't. Idk wtf is going on, not even 2.0.14 fixes anything

My issue was that I didn't have have the lastest 21H2 and 22H2 patches. At some point microsoft threw in windows 11 upgrade as an option. This actively blocks you from updating windows to the later patches. More information on versions: https://learn.microsoft.com/en-us/windows/release-health/release-information
This following reg script will set your max upgrade level to 22H2.

Note: This does mean you won't get any updates past.

Windows Registry Editor Version 5.00

[HKEY_LOCAL_MACHINE\SOFTWARE\Policies\Microsoft\Windows\WindowsUpdate]
"TargetReleaseVersion"=dword:00000001
"TargetReleaseVersionInfo"="22H2"

Open windows update (reopen if its already) it should look like this except there is an asterisk and it will want to update to windows 11.

Pause and resume windows updates. This will trigger an update search and windows 11 will not come back. Simply update as normal. It took me a couple of restarts. I already had the latest wsl2 installed and could use it as normal.
WSL version: <IP_ADDRESS>
Kernel version: <IP_ADDRESS>-1
WSLg version: 1.0.59
MSRDC version: 1.2.4677
Direct3D version: 1.611.1-81528511
DXCore version: 10.0.25131.1002-220531-1700.rs-onecore-base2-hyp
Windows version: 10.0.19045.3803

I had 2.0.1. Tried to update to latest just now several times from elevated powershell. Didn't work. wsl --version still shows the old one. Then I removed Windows subsystem for linux from add remove programs. then tried to wsl --install --no-distribution --web-download. It shows error.  Later I just downloaded latest msi from github release and installed it. From changelog I see fixes related to upgrade, those will affect future upgrades I guess.

PowerShell 7.4.2
PS C:\Users\xxxx> wsl --update
Checking for updates.
Updating Windows Subsystem for Linux to version: 2.1.5.
The handle is invalid.
Error code: Wsl/UpdatePackage/0x80070006

Fixed with 2.0.3

I tried various fixes and running the installed for "<IP_ADDRESS>" is the only one that worked. Manually installing the latest version (<IP_ADDRESS> as of today) or running wsl --update breaks things. So I guess I will try to stay with this version as long as possible.

The same #1603 issue:
Could not write value InstallLocation to key \SOFTWARE\Microsoft\Windows\CurrentVersion\Lxss\MSI.   Verify that you have sufficient access to that key, or contact your support personnel.
Update failed (exit code: 1603).
Error code: Bash/CallMsi/Install/ERROR_INSTALL_FAILURE
Please help anyone who can fix it :>


Constant timeouts and download resilience issues, specially with slower hosts such as fabricmc

Describe the problem
Downloading mods, from anywhere but north america, seems tough because of the tight read timeouts and retry policy in the mc-image-helper tool?
[mc-image-helper] 03:47:48.799 WARN  : [8478f765-1, L:/<IP_ADDRESS>:37918 - R:meta.fabricmc.net/<IP_ADDRESS>:443] The connection observed an error

We're getting constant timeouts here :-) And it would seem the timeouts are set quite low as default, and no retry.
Container definition
services:
  mc:
    image: itzg/minecraft-server
    ports:
      - "25565:25565"
    environment:
      EULA: "true"
      MOD_PLATFORM: AUTO_CURSEFORGE
      CF_API_KEY: xxxxxx
      CF_PAGE_URL: https://www.curseforge.com/minecraft/modpacks/prominence-2-rpg
      MEMORY: 4G
      CF_OVERRIDES_SKIP_EXISTING: true
    volumes:
      - ./mc-data:/data
      - ./downloads:/downloads

Container logs
[mc-image-helper] 03:47:48.799 WARN  : [8478f765-1, L:/<IP_ADDRESS>:37918 - R:meta.fabricmc.net/<IP_ADDRESS>:443] The connection observed an error

I don't recognize that log at all:
[8478f765-1, L:/[<IP_ADDRESS>:37918](http://<IP_ADDRESS>:37918/) - R:[meta.fabricmc.net/<IP_ADDRESS>:443](http://meta.fabricmc.net/<IP_ADDRESS>:443)] The connection observed an error

My guess is it's coming from lower in the JVM.

from anywhere but north america,

I live in North America and the downloads have worked fine for me for this whole time. So I don't agree with that generalization 😄

seems tough because of the tight read timeouts and retry policy in the mc-image-helper tool

How did you determine the timeout value from that cryptic log?
30 second timeouts seem pretty lenient to me, but you can always increase those with the respective environment variable:
https://github.com/itzg/mc-image-helper/blob/master/src/main/java/me/itzg/helpers/http/SharedFetchArgs.java#L20-L35

I stand corrected. I am presently seeing the same issues. I am wondering if one of the CDN providers is having issues right now.

...and now it's working fine 🤷

Ah, yeah, it would seem the fabricmc part had a way less than 30 second timeout btw :-)... if I run the docker container interactively, it would timeout in what feels more like 2 seconds. I may be totally wrong here, but that's only from what I can observe.
Thank you for looking at least :-)

Some more context, and time stamps
mc-1  | [mc-image-helper] 13:58:24.307 INFO  : Mod file ./mods/indrev-1.16.5-BETA.jar already exists
mc-1  | [mc-image-helper] 13:58:29.583 WARN  : [66991987-1, L:/<IP_ADDRESS>:55728 - R:meta.fabricmc.net/<IP_ADDRESS>:443] The connection observed an error
mc-1  | io.netty.handler.timeout.ReadTimeoutException: null

So, it can't be DNS that times out, because it looks like ithe IP there is the correct cloudflare IP... so I'm curious if there's some other timeout in the java HTTP client? Or maybe cloudflare just doesn't like me 😂 (I'll try warp+ or some VPN here in a minute)


Error with login via instaloader.

Describe the bug
A clear and concise description of what the bug is.
Fatal error: Login: Checkpoint required. Point your browser to https://www.instagram.com/challenge/29704744066/CRz61vM0ua/ - follow the instructions, then retry.

To Reproduce
Steps to reproduce the behavior:
(e.g. Instaloader command line)
Expected behavior
every time i try to login to download anything via instaloader. I'm having this issue, and i followed the instruction in the URL above, then after trying to log in again, the same error occurs, (like a loop).
any help appreciated.
thanks.
A clear and concise description of what you expected to happen (even if it seems obvious).
Error messages and tracebacks
If applicable, add error messages and tracebacks to help explain your problem.
Instaloader version
instaloader --version output.
4.5.3

Additional context
Add any other context about the problem here.

I have had the same error, but no luck in resolving it...

Have a look at the documentation: https://instaloader.github.io/troubleshooting.html#login-error

The same issue even after loading cookies. Next Triying to deactivate & activate my account in 24 hours, maybe this could help.

I never had the problem, that my account was blocked/in challenge required state after grabbing cookies from firefox. I hope you all use the latest version of instaloader. What happens if you open your profile just in this firefox session which is used for grabbing the cookies?
Next question is: are you sure, that your cookie file gets replaced with the new one?

Given that these questions remain unanswered, I guess this is resolved. Please comment if the problem still persists.

Given that these questions remain unanswered, I guess this is resolved. Please comment if the problem still persists.

@aandergr No it is still an issue, at least on the windows standalone.
I'm on the latest version and get stuck in the loop.
The link above that @Showmaster3000 posted is kind of out of my league (that's why I'm using the standalone in the first place :wink:) so can this be done manually?
I see all the values from the cookie in FF but how do I edit the session file? It's in a format I don't know how to edit corrrectly, tried just changing the values in Notepad+ but that didn't work.

@aandergr No it is still an issue, at least on the windows standalone.
I'm on the latest version and get stuck in the loop.
The link above that @Showmaster3000 posted is kind of out of my league (that's why I'm using the standalone in the first place :wink:) so can this be done manually?
I see all the values from the cookie in FF but how do I edit the session file? It's in a format I don't know how to edit corrrectly, tried just changing the values in Notepad+ but that didn't work.


Addresses issue #10846

@abose @peterflynn (apologies it isn't solely related to #10846 - it felt sensible to combine into one PR)
Fold states are now persisted using viewState (state.json)
Added copyright text into foldcode.js and foldgutter.js
Removed strings.js file
Removed latex-fold helper
Removed menu item for custom region folding
Disable custom region folding by default

Code folding is enabled in all files by default, and in some files like txt files it looks a bit odd.
Would it be a good thing to enable code folding in only HTML,XML,js Etc. and disabled in all other file types?

@abose I suspect the fold marks are appearing in a txt file due to indentations. A suggestion would be to disable the alwaysUseIndentFold option so that only files with registered mode helpers for code-folding have fold markers?

@thehogfather This looks great overall, thanks for posting this update so quickly!  I added a few comments above.
One other note: this fixes bug #10848 for the "enabled" preference, but the other preferences still seem to need a restart or close/reopen file to take effect.  Did you want to wait for another PR to fix those other prefs?

@thehogfather Fyi, I've opened PR #10859 with some UI changes as well as a few code tweaks.  Some of it duplicates change you've made here (I started working on it before you posted this), so once your PR is merged I'll rebase mine on top of your changes.  But please take a look and see if there's anything else there you'd be concerned about.

@thehogfather Now that region fold support is removed, fold helper - region-fold.js could also be removed.

@abose @peterflynn I think this should be closer to ready than before. Cleaned up the strings and removed custom-region folding completely. Now over to you. Happy to help with anything else you direct my way.

Looks like minFoldSize and alwaysUseIndentFold still require close & reopen to take effect.  Do you want to spin that off as a separate bug?

Hmm, it also looks like folds are no longer remembered when you close & reopen a file, even with a completely clean slate of prefs.  Seems like something is broken with the view-state storage changes here...

WRT minFoldSize and alwaysUseIndentFold lets file a separate bug with steps to reproduce. When I test it I get the effects immediately within the brackets.json file being edited (after saving).

Btw, it's still a ways off but it will be interesting to think about what having the same document visible in two split panes will mean for code folding.  Should collapsing a section in one pane automatically collapse it in the other?  Seems like that would feel weird, but otoh if each editor has its own expand/collapse state for the same document, how will that be persisted?  Which one "wins" if you close both views?  Etc.
I'll add a note to that Trello story so we can think about it more when the time comes.

Loos good now; Merging this PR.
@peterflynn brackets/pull/10859 can now be merged.

@peterflynn It's the same issue for selections/cursors, having two states in one document is weird anyway.

@abose Wait, why did you merge this already?  See my comments above -- https://github.com/adobe/brackets/pull/10850#issuecomment-91371932 and https://github.com/adobe/brackets/pull/10850#discussion_r28110161 -- code folding persistence is completely broken in master now because of this PR.  We should have waited before fixing that blocker before merging...
I'll file a high-priority bug to track it.


Catch exception generated during sudden disconnection of the serial port

Happens when serial port disconnects suddenly, leading the console to be stuck in a indefinite exception loop.

This is actually an issue with pytelemetrycli not this repo. Closing


Setting up a unit test in F#

Description
I am unable to setup a F# unit test using asp.net core with attribute routing
To Reproduce
Steps to reproduce the behavior:

Using this version of ASP.NET Core '2.2.2'
Run this code

module Tests

open System
open Xunit
open Microsoft.AspNetCore.Builder
open Microsoft.AspNetCore.Hosting
open Microsoft.AspNetCore.Mvc
open Microsoft.Extensions.DependencyInjection

type Startup ()  =
    member  __.ConfigureServices(services: IServiceCollection) =
        services.AddMvc().SetCompatibilityVersion(CompatibilityVersion.Version_2_2) |> ignore

    member __.Configure(app: IApplicationBuilder, env: IHostingEnvironment) =
        app.UseMvc() |> ignore

[<Route("api")>]
[<ApiController>]
type TestController() =
    inherit ControllerBase()

    [<HttpGet("testGet")>]
    member __.TestGet() =
        121221

    [<HttpPost("testPost")>]
    member __.TestPost() =
        String.Empty

let buildHost(baseAdress:string) =
    Microsoft.AspNetCore.WebHost
                .CreateDefaultBuilder()
                .UseStartup<Startup>()
                .UseUrls(baseAdress)
                .Build()

[<Fact>]
let ``My test`` () =
    let baseAdress = "https://localhost:9000"
    use host = buildHost(baseAdress)
    host.RunAsync() |> ignore
    let client = new System.Net.Http.HttpClient(BaseAddress = new System.Uri(baseAdress))
    let result = client.GetAsync("api/testGet").Result
    Assert.Equal(System.Net.HttpStatusCode.OK, result.StatusCode)
    Assert.True(result.IsSuccessStatusCode, result.Content.ReadAsStringAsync().Result )

here is the fsproj
<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <TargetFramework>netcoreapp2.2</TargetFramework>

    <IsPackable>false</IsPackable>
    <GenerateProgramFile>false</GenerateProgramFile>
  </PropertyGroup>

  <ItemGroup>
    <Compile Include="Tests.fs" />
  </ItemGroup>

  <ItemGroup>
    <PackageReference Include="Microsoft.AspNetCore.App" Version="2.2.2" />
    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.2.0" />
    <PackageReference Include="Microsoft.NETCore.App" Version="2.2.2" />
    <PackageReference Include="xunit" Version="2.4.0" />
    <PackageReference Include="xunit.runner.visualstudio" Version="2.4.0" />
    <PackageReference Include="coverlet.collector" Version="1.0.1" />
  </ItemGroup>

</Project>

See error
The test failes with with the following
Message:
Assert.Equal() Failure
Expected: OK
Actual:   NotFound

Expected behavior
The test should succeed
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
here is linqpad version (using linqpad 6 ) of the same code. It shows That none of the route are being registered.

Thanks for contacting us, @chkeita.
Can you try to set the <PreserveCompilationContext>true</PreserveCompilationContext> in the <PropertyGroup> section?

Asp.net core is currently ignoring controllers from a module.
See full detail here.
I guess it should be possible to customize to use ConfigureApplicationPartManager to add an Feature provider that allows modules.
I would be nice if this would work out of the box for module

Keeping this open for now so it could be considered a feature request

Glad you got this working @chkeita. Given that there's a workable solution to this, we don't plan on adding new features for this.


Unexpected crash > dts-gen -d node-red -m node-red

Hi. I am trying to generate typings for Node-RED.
I get a crash. Here is the printout -
andersa@Kubuntu:~/nodejs$ dts-gen -d node-red -m node-red
Deprecated use of RED.app - use RED.httpAdmin instead
Deprecated use of RED.app - use RED.httpAdmin instead
Deprecated use of RED.app - use RED.httpAdmin instead
Deprecated use of RED.app - use RED.httpAdmin instead
Unexpected crash! Please log a bug with the commandline you specified.
/home/andersa/.npm-global/lib/node_modules/dts-gen/bin/lib/run.js:130
        throw e;
        ^

Error: ENOENT: no such file or directory, mkdir 'types/node-red'
    at Object.fs.mkdirSync (fs.js:892:18)
    at Object.writeDefinitelyTypedPackage [as default] (/home/andersa/.npm-global/lib/node_modules/dts-gen/bin/lib/definitely-typed.js:24:14)
    at Object.<anonymous> (/home/andersa/.npm-global/lib/node_modules/dts-gen/bin/lib/run.js:92:35)
    at Module._compile (module.js:624:30)
    at Object.Module._extensions..js (module.js:635:10)
    at Module.load (module.js:545:32)
    at tryModuleLoad (module.js:508:12)
    at Function.Module._load (module.js:500:3)
    at Function.Module.runMain (module.js:665:10)
    at startup (bootstrap_node.js:201:16)

I have found the cause of this.
The error occurs in lib/definitely-typed.ts.
export default function writeDefinitelyTypedPackage(
		indexDtsContent: string, packageName: string, overwrite: boolean): void {
	const packageDir = joinPaths("types", packageName);

	// Check for overwrite
	if (!overwrite) {
		if (existsSync(packageDir)) {
			console.log(`Directory ${packageDir} already exists and -overwrite was not specified; exiting.`);
			process.exit(2);
		}
	}

	if (!existsSync(packageDir)) {
		mkdirSync(packageDir); <<-- Can't create nested directories (on linux).
	}

	run(indexDtsContent, packageName, packageDir).catch(e => {
		console.error(e);
		process.exit(1);
	});
}

The code expects dts-gen to be run from the DefinitelyTyped root directory, so it expects that the types directory already exists, when it doesn't, mkdir fails because it can't create nested directory structures.
I don't think this is the best assumption to make. From my perspective, trying to create my first type definition file and just testing things out, I probably do not want to mess with the entire DefinitelyTyped repository yet. I just want a directory with the necessary files created.
For now, I can work around this by creating the types directory manually and running the command from the directory above.

Anyone know a workaround? I'm trying to make my first types package for a pre-existing lib and cannot for the life of me figure out how to get it to work: @DefinitelyTyped/issues/30208 is where I put my first issue regarding this.

I am doing this. I have same concern as @kylegoetz .
Any suggestions , how do I do it for the local node_modules directory ?


Use named pipes for shim logs

Closes #2606
When waiting for a golang cmd to exit, golang will block exiting on all of its process streams being closed. Currently, the containerd server is configuring each shim processes output (stdout/stderr) to redirect to the server’s stdout/stderr. When running the containerd restart tests, these do not get closed - and waiting for the server process to finish hangs.
Since restarting the containerd server does not restart the shim processes, the shims output streams could still be outputting logs, never to be closed. The aim of this PR is to let the shim instead log to named pipes.

When a new task is created, the server:
creates a new named pipe (one for stdout and one for stderr).
assigns the start shim command stdout/err to the write ends of these pipes
schedules a go routine to copy from the pipes’ read end to os.Stdout/os.Stderr, thus capturing the shim’s logs
When the shim process starts it opens the stout and stderr pipes in read-only mode in order to keep the pipes open even if the server process goes down
Note that the shim process never reads from the pipes, it just keeps them open
When a containerd server comes back and restores its tasks:
it opens the pipes that have been already created
is schedules a goroutine to copy the pipes contents to os.Stdout/os.Stderr, thus capturing the logs of an already running shim processes
When shim debugging is off shim processes stdout/stderr are set to nil i.e. the server does not capture shim logs

In order to be able to test the change we:

Enabled shim debugging for all tests as the containerd server lifecycle and its settings are managed globally in TestMain
In order to be able to verify that the server connects to existing shim processes stdio we had to make the server output available to tests. Initially we attempted to read from the stdio buffer from the test but because the buffer is shared accross all parallel tests we go a d
ata race. Therefore we sent the server output to a temporary file which tests can use to check the output without data races.

We noticed that there is something similar implemented for v2, however we do not really understand how to use and run tests against it. It seems in v2, it creates a single pipe for both stdout and stderr rather than one for each stream and the server does not reconnect to those pipes when restoring running tasks. We could fix it for v2 if we knew how!
cc @ostenbom

@danail-branekov for v2. You can use it via ctr run --runtime io.containerd.runc.v1. I feel like it should work as we already use a named pipe but I havn't testing your reproduction case yet.

My question was more about how to test v2 in an automated manner. Is that possible?
Running the very same integration tests against v2 does make sense to me, still the Makefile does not provide that capability.

Ahh, the CI does run both runtimes.
You should be able to set TEST_RUNTIME=io.containerd.runc.v1 and run the tests locally

I have rebased the PR onto master and made the TestDaemonReconnectsToShimIOPipesOnRestart test verify that containerd reconnects to the shim log after restart for both v1 and v2. As a matter of fact this capability was already there for v2.
There are however some discrepancies between v1 and v2 logging:

v1 has separate log files for stdout and stderr that are located in /<root-dir>/io.containerd.runtime.v1.linux/<namespace>/<id>
v2 has a log file for stderr only located in /<state-dir>/io.containerd.runtime.v2.task/<namespace>/<id>

Do we need need to address these discrepancies and always put files in either root-dir or state-dir? I was also tempted to make v2 have separate log files for stdout/stderr but I saw that v2 uses stdout to communicate between the service and the task manager e.g. here.

@danail-branekov ya, i see what you are talking about.  Let me look at the code again and see what would be a good solution.
Also don't worry about the windows tests, we have a PR to fix the gcc issue that poped up over night.

V2 shim logging is done via a Fifo on Linux and Named Pipe on Windows. It does not use stdout, stderr so this should not affect the V2 runtimes at all.

@jterry75 Actually, v2 would forward stderr to the named pipe and would use stdout to return the shim address. This PR does pretty much the same for v1, except that the PR would forward both stdout and stderr to named pipes.
And yes, this PR does not affect v2 (unless we decide to unify named pipes implementation) except for introducing a test relevant to both v1 and v2 that verifies that a) the server reconnects to the named pipe on restart and b) shim logs are forwarded to the server log if debug is enabled.

@crosbymichael Has that GCC windows issue been resolved? If so we can force push to our fork to trigger CI again.

@BooleanCat - Yes it has been fixed for some time now.

@danail-branekov We tried rebasing on master and we still need windows failures. Let's take a deeper look at this.

Codecov Report

Merging #2631 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2631   +/-   ##
=======================================
  Coverage   43.72%   43.72%
=======================================
  Files         100      100
  Lines       10734    10734
=======================================
  Hits         4693     4693
  Misses       5311     5311
  Partials      730      730

Flag
Coverage Δ

#linux
47.39% <ø> (ø)
:arrow_up:

#windows
40.89% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44b90df...1d4105c. Read the comment docs.

The windows failures were because we introduced a file with unix imports and had not disabled the build on windows (// +build !windows). This is resolved now, so we should be good to go.
bump @crosbymichael

LGTM

LGTM


enable rbac test for auth/e2e_pilotv2

Enable rbac + mtls test for pilot v2
This is to verify that mtls between mixer and envoy works.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sebastienvas
Assign the PR to them by writing /assign @sebastienvas in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mandarjog: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
5c3f339a582c049711a5327358a8ef3740121d87
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandarjog: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
5c3f339a582c049711a5327358a8ef3740121d87
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
5c3f339a582c049711a5327358a8ef3740121d87
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandarjog: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
5c3f339a582c049711a5327358a8ef3740121d87
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
5c3f339a582c049711a5327358a8ef3740121d87
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
5c3f339a582c049711a5327358a8ef3740121d87
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

fixes #5331


selected option in typedInput is not remembered when hasValue == false

What are the steps to reproduce?
Add a typed input with options and hasValue = false
    let _types = {
        value: "type",
        label: "Type",
        showLabel: true,
        hasValue: false,
        options: [
            { value: "byte", label: "byte" },
            { value: "int8", label: "int8" },
            { value: "uint8", label: "uint8" },
            { value: "int16le", label: "int16 (le)" },
            { value: "int16be", label: "int16 (be)" },
            //... snip for brevity
            { value: "ucs2", label: "ucs2" },
            { value: "latin1", label: "latin1" },
            { value: "binary", label: "binary" },
            { value: "buffer", label: "buffer" },
        ]
    }

    let row1_1 = $('<div/>', { style: "display:flex;", class: "buffer-parser-row-item" }).appendTo(row1);
    let typeField = $('<input/>', { class: "node-input-item-property-type", type: "text", width: "165px" })
        .appendTo(row1_1)
        .typedInput({ types: [_types] })

What happens?
Selected item is not highlighted/remembered when clicking the RH dropdown

If I change this code from this...
                    if (opt.hasValue) {
                        this.optionValue = o.value;
                        this.input.trigger('change',[this.propertyType,this.value()]);
                    }

to this...
                    this.optionValue = o.value;
                    if (opt.hasValue) {
                        this.input.trigger('change',[this.propertyType,this.value()]);
                    }

... then this.optionValue gets set and the selection is remembered...

However I do not have enough knowledge to know the ramifications of setting this.optionValue for a typedInput when hasValue = false.
What do you expect to happen?
The chosen/set item to be highlighted/selected
Please tell us about your environment:

[ ] Node-RED version: <= V1.33 and V2.0.0-beta.1
[ ] Node.js version: 14.16.1
[ ] npm version: 6.14.12
[ ] Platform/OS: Win 10
[ ] Browser: Chrome latest

I think this was fixed a few days ago by https://github.com/node-red/node-red/commit/23a5cb1917fa6f7fd80e8cae8d04c753c76eecbb#diff-3856852af6b22821b9da448a6a510bd2342bf80111ff1efe7b1c5675f39c8a79

Hi Nick, I can confirm that does indeed fix it.
I missed this due to being on dev branch at the moment.
Sorry for the noise.
Thanks.


Implement platform channel response handling in macOS embedding

https://github.com/flutter/engine/pull/9655 added the necessary APIs to add the missing handling of responses when calling from native to Dart.

This was fixed in https://github.com/flutter/engine/pull/9953


Tagging a sequence of sentences

Is it possible to use a sentence as the unit of labeling (tagging a sequence of sentences as opposed to words)? Would the code consider the embedding of each word and construct a sentence embedding?

Hi @preetraga, though I haven't tested that, I'm pretty sure that would work without any changes to the code. You could just format the data file so that the first tab-separated item is a sentence instead of a token.

@epwalsh thanks! I did try that with the sample data in the test folder. Although the code runs without errors, I see that it seems to be mapping anything longer than a single word to "unk" in the embedding in vocab.py. I tested this with hi and hello and tokens on different lines that get mapped to 1843 and 6328 in the word_idx lookup. However, if "hi hello" is the input sentence, it gets mapped to the "unk" id. So I am assuming that to process a sentence, one would have to read the each word's embedding in the sentence and combine them in some manner before creating the tensor?

@preetraga I think you're right, at least if you're using the GloVe (or any other) pretrained embeddings


Fix invalid resolution after entry

When entering an invalid resolution, upon entry (commit), fix it

FIxed.


p5.sound.min.js.map

I get the following error in the Safari console Failed to load resource: the server responded with a status of 404 () and https://cdn.jsdelivr.net/npm/p5/lib/addons/p5.sound.min.js.map and in the Chrome console DevTools failed to parse SourceMap: https://cdn.jsdelivr.net/npm/p5/lib/addons/p5.sound.min.js.map
p5.js version 0.10.2
p5.sound version: 0.3.12

@joepdooper can you please list from where you got those links to  Map files..?.
I mean is it there on p5.org?.

@joepdooper can you please list from where you got those links to Map files..?.
I mean is it there on p5.org?.

I don't understand your question. You mean the website that creates this error? This is the website at the moment: http://199907a4.ngrok.io/

The p5.js package from https://p5js.org/download/ yields this error.

@joepdooper @tpltnt  what i can see that there is only this
<EMAIL_ADDRESS>as name of CDN links

For some reason the error has disappeared… I'll close this issue if the error doesn't reappear.

I get the exact same error.

me too, same problem.
In my case, I´m working on a little game and I am running all locally on my machine . I downloaded the libraryes from p5js.org
At the first, I wrote all the code (loops, interations, classes, etc) and test it..... All good.....
Then I started to work with sounds effects. I just included a ref to 'p5.sound.min.js' on head session of the html page and got the error:
"DevTools failed to parse SourceMap: http://localhost:3000/lib/p5/p5.sound.min.js.map"
I am using Sublime editor and running the page on Chrome (using Sublime "Browse Sync" package).

@zuppao Thank you! I downloaded the "Source code" zip file from https://github.com/processing/p5.js-sound/releases and indeed inside the 'Lib' folder it has the .map file! Great!

Hi, how do you fix this error please? I am getting it when using the files included in the 'Downloaded' link on the p5.js Web site. This is my first time using Processing.
Could not read source map for file:///p5.sound.min.js:

Hi, how do you fix this error please? I am getting it when using the files included in the 'Downloaded' link on the p5.js Web site. This is my first time using Processing.
Could not read source map for file:///p5.sound.min.js There is no p5.sound.min.js.map in the downloaded zip file

@RichardJECooke buddy you need to download the missing files (.map) from the official github rep in https://github.com/processing/p5.js-sound/tree/master/lib then you will be abke to add it to your project (sorry for the delay on answer)

I fixed the first error with your answers, but now I get this error: "DevTools failed to load source map: Could not parse content for https://itzlarz.dev/p5.sound.js.map: Unexpected token < in JSON at position 6"
Why is it trying to parse an HTML file as a JSON file?


Update @codler/react-native-keyboard-aware-scroll-view to version 1.0.1

When the keyboard is open console is throwing out an error currentlyFocusedField is deprecated and will be removed in a future release. Use currentlyFocusedInput
Native Base is using 1.0.0 version for @codler/react-native-keyboard-aware-scroll-view To resolve this issue it needs to update to the 1.0.1 version.
└─┬<EMAIL_ADDRESS>  └──<EMAIL_ADDRESS>
I create PR for this issue #https://github.com/GeekyAnts/NativeBase/pull/3305

PR for this has been merged and release in v2.15.0


Dynamic import support?

Issue

Because ts-jest overrides module to commonjs in thetsconfig.json no tests can be written with the new dynamic import('./myModule') syntax. You get either 'import' and 'export' may only appear at the top level or a Syntax error.

Expected behavior

Dynamic imports should work.

Link to a minimal repo that reproduces this issue

Just type import('./myModule') in your test or implementation. That's enough.

This is a new feature in TypeScript, right?
I haven't tested this yet but I'm marking it as a bug.

Yes, it is a new feature 😉

@screendriver I've added a test that seems to be passing
Can you see if the test covers this issue?
If it does, then I'm not sure why it isn't working for you. Did you test with the latest typescript version?

Oh. You are right. In my little test repository it is working as well 😳
But: if you enable "allowSyntheticDefaultImports": true the error occurs that I get currenlty in my real project.

can you try setting skipBabel to false (docs)
(this will prevent hoisting of mocks, though)

I've added a test for dynamic imports with allowSyntheticDefaultImports set to true. If you don't need babel, the solution is to skip it (see my previous comment).
If you need babel, you might have to add the right plugin and update your .babelrc (this is conjecture - I haven't tested this)

If if set skipBabel to true I get a lot of like TypeError: Cannot read property 'Nothing' of undefined or jest.fn() value must be a mock function or spy. If I set skipBabel to false everything works but dynamic imports.
By the way: I don't use Babel in my project. There is only TypeScript (and webpack). Nothing more.

I'm not sure what's going on. Can you do one of the following:

create a minimal repo that reproduces this
add a test in the new branch here that reproduces this. I've already added two tests. You can add more to replicate this issue

?

I created for you a minimal repository where you can reproduce the error.
tsc runs fine (and it works in the browser as well)
jest fails with errors.
I added
"ts-jest": {
  "skipBabel": true
}

and allowSyntheticDefaultImports to true. If you set skipBabel to false you get the import syntax error.

So when you set skipBabel to true, does it work for you?

If if set skipBabel to true I get a lot of like TypeError: Cannot read property 'Nothing' of undefined

This doesn't look like a ts-jest issue. I've sent a PR to the minimal repo of a version which works fine. It's got something to do with how Maybe is imported

on second thoughts, hang on. This might be an issue with ts-jest

yeah, I've just tested this without ts-jest and the way Maybe is imported needs to change for this to work. Here's a repo that demonstrates this without ts-jest

Thank you 👍
I ended up in fixing the type definition (because it was wrong. There is no default export) and disabled allowSyntheticDefaultImports in general. Now everything works fine 😎

Just a little update @kulshekhar : could you try it with target: "es2015" in your tsconfig.json? I'm getting errors again when I change target to es5 to es2015. This time a Unexpected token

Jest needs to be fed the es5 version, either directly from typescript or via babel. That's probably what's causing this issue. It's most likely not related to dynamic imports

Ah ok. So no matter if I have Node 8.* installed and can use almost every shiny new JavaScript language feature I still have to transpile everything down to ES5? If yes: this results in slower transpilation and runtime. If we could use ES2015 as target for example, TypeScript has to transpile almost nothing and Node could run the code almost as it was written (except the imports and type definitions) => faster transpilation, faster runtime.

It's just the module resolution part I think. Natively, node doesn't understand 'import'

except the imports and type definitions

as I said 😁

Hi @screendriver, @kulshekhar so if I am correct then at the moment you cannot have allowSyntheticDefaultImports: true and have dynamic import work?

i can confirm that's correct at least as far as i've experienced things....every time i try with it enabled, jest fails...
 FAIL  src/lib/localizations/LocalizationManager.spec.tsx
  ● Test suite failed to run

    /Users/Gabe/Sites/roastlogger-web/src/lib/docs/index.tsx: Unexpected token (6:18)
        4 | const Loader = props => React.createElement('div', props);
        5 | const Docs = loadableVisiblity({
      > 6 |     loader: () => import('./container'),
          |                   ^
        7 |     loading: Loader
        8 | });
        9 | export { actions, actionTypes, KEY, reducer };

@gabeweaver I actually have it working however then I had to bring in react-loadable using require() syntax instead of import.

I'm not quite sure why this doesn't work - would love a PR with a fix.

Would also like a fix for this.

Maybe we should re-open this issue? At the moment I have to enable allowSyntheticDefaultImports together with the new esModuleInterop and now my tests are failing again because of import() 🤔

Please add a minimal repo to help take this forward

Any news regarding this issue?

++++
test failing to run
component: () => import(/* webpackChunkName: 'group-app' */ '@/views/Dashboard.vue'),
^

I think I ran into the same problem as you guys and I made a minimal repro repo here so that the maintainers can figure out what's wrong. Steps to reproduce:

Clone and run yarn.
git checkout ea5ea730.
Run npm test. Tests fail because of the dynamic import in src/addAndMultiply.ts.
git checkout df062207.
Run npm test. Tests pass because of this change.

@screendriver does the change that worked for @huy-nguyen work for you?

Hi @kulshekhar,
unfortunately not because @huy-nguyen just disable allowSyntheticDefaultImports for it's tests and that's it. That means that your code with third party dependencies (like import moment from 'moment' and so on) will not compile anymore when you run tsc.
I already have two tsconfig.json files:

one for my production application code
one for my tests (where I set "module": "commonjs")

In my CI build I run tsc and after that tsc -p tests. When I enable allowSyntheticDefaultImports in the first tsconfig.json and disable that in in the test specific second tsconfig.json the build will fail. If I would disable the second build step tsc -p tests and just rely on jest and only would run the jest tests without compilation I get a lot of failing tests because for example Warning: React.createElement: type is invalid because TypeScript emits wrong / no files.

I upgraded to version 22.4.5 now and nothing changed 🤔

I enabled that now (I oversight that flag...) but the tests are now really slow (4 tests are running in 30 seconds 😳) and I'm getting different errors now:
    TypeError: Cannot read property 'text' of undefined

      at transpileViaLanguageServer (node_modules/ts-jest/dist/transpiler.js:61:21)
      at Object.transpileTypescript (node_modules/ts-jest/dist/transpiler.js:10:16)
      at process (node_modules/ts-jest/dist/preprocessor.js:27:41)
      at Object.process (node_modules/ts-jest/index.js:8:51)

Yeah it's definitely slower. Thanks for trying it out.

The issue still persists in the 22.4.6 version.
I've created a small repo with steps to reproduce the issue.

@noblica this is a different issue. You just have to define
{
  "extends": "./tsconfig",
  "compilerOptions": {
    "module": "commonjs"
  }
}

in your tsconfig.jest.json as mentioned in the docs 😉

@screendriver I did, but the error persisted.
But then I removed the enableTsDiagnostics flag, and it works, for some reason?
Also leaving the enableTsDiagnostics flag, and setting the allowSyntheticDefaultImports to false also makes the tests work, so I'm not sure what's going on.

In your repo I see "module": "esnext" and no "module": "commonjs" as I wrote so it can't work in your demo repository

I did a pull request and it works now in your repository.
https://github.com/noblica/ts-jest-dynamic-imports/pull/1

Hi i've tried out the above solution with a separate jest tsconfig however i'm still getting the same error.
The only difference to add is that I'm in a mixed TS project (js enabled). Could this be the cause?

In case this helps anyone in the future, I got this working by configuring .babelrc to add dynamic import support as indicated in the Jest docs:
{
  "presets": [["env", {"modules": false}]],

  "plugins": ["syntax-dynamic-import"],

  "env": {
    "test": {
      "plugins": ["dynamic-import-node"]
    }
  }
}

Note you may need to run jest --clearCache to clear your Jest cache to get this to work.
If you don't use babel for your project normally, you will still need to add a .babelrc file and devDependencies on these two plugins just for this use case.

Thanks @christophercurrie ! jest --clearCache is the tricky part!! After add dynamic-import-node please remember to clear cache first. It took me a hour to figure out!

tested with repo, #626 will address the caching part as well as the dynamic import()

fixed in 23.1.2

In case someone still struggles with this problem, what helped for me was changing Jest preset from
ts-jest/presets/js-with-babel to ts-jest/presets/js-with-ts. I guess it had something to do with the fact that in our codebase we use mix of js and ts files and our tests are written in TS while the tested file with dynamic import was still JS.


test: solve bring coverage greater then 85%

Ref. issue #8
Reviewer:
@micheleriva

@aleattene awesome job!!