Error when deleting last remaining language in Locale admin

Found a bug? Please fill out the sections below. 👍
Issue Summary
I get an error when trying to delete the last locale (English is the default language, probably not relevant):

when clicking the 'Yes, delete', the error will occur.
Steps to Reproduce
Internal Server Error: /admin/locales/2/delete/
Traceback (most recent call last):
  File "C:\Work\virtual_env\lib\site-packages\django\db\backends\utils.py", line 84, in _execute
    return self.cursor.execute(sql, params)
psycopg2.errors.NotNullViolation: null value in column "locale_id" violates not-null constraint
DETAIL:  Failing row contains (1, 0001, 1, 0, Root, root, t, f, /, , f, , null, null, f, 1, null, f, null, null, null, null, Root, null, null, 2ac624bf-c27c-4f38-8328-55abe117d0dc, null, null).

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "C:\Work\virtual_env\lib\site-packages\django\core\handlers\exception.py", line 47, in inner
    response = get_response(request)
  File "C:\Work\virtual_env\lib\site-packages\django\core\handlers\base.py", line 179, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "C:\Work\virtual_env\lib\site-packages\django\views\decorators\cache.py", line 44, in _wrapped_view_func
    response = view_func(request, *args, **kwargs)
  File "C:\Work\virtual_env\lib\site-packages\wagtail\admin\urls\__init__.py", line 127, in wrapper
    return view_func(request, *args, **kwargs)
  File "C:\Work\virtual_env\lib\site-packages\wagtail\admin\auth.py", line 193, in decorated_view
    return view_func(request, *args, **kwargs)
  File "C:\Work\virtual_env\lib\site-packages\django\views\generic\base.py", line 70, in view
    return self.dispatch(request, *args, **kwargs)
  File "C:\Work\virtual_env\lib\site-packages\wagtail\admin\views\generic.py", line 45, in dispatch
    return super().dispatch(request, *args, **kwargs)
  File "C:\Work\virtual_env\lib\site-packages\django\views\generic\base.py", line 98, in dispatch
    return handler(request, *args, **kwargs)
  File "C:\Work\virtual_env\lib\site-packages\django\views\generic\edit.py", line 218, in post
    return self.delete(request, *args, **kwargs)
  File "C:\Work\virtual_env\lib\site-packages\wagtail_localize\locales\views.py", line 172, in delete
    return super().delete(request, *args, **kwargs)
  File "C:\Work\virtual_env\lib\site-packages\wagtail\admin\views\generic.py", line 242, in delete
    response = super().delete(request, *args, **kwargs)
  File "C:\Work\virtual_env\lib\site-packages\django\views\generic\edit.py", line 213, in delete
    self.object.delete()
  File "C:\Users\AppData\Local\Programs\Python\Python37\lib\contextlib.py", line 74, in inner
    return func(*args, **kwds)
  File "C:\Work\virtual_env\lib\site-packages\wagtail\core\models.py", line 392, in delete
    root_page_with_this_locale.update(locale=new_locale)
  File "C:\Work\virtual_env\lib\site-packages\django\db\models\query.py", line 784, in update
    rows = query.get_compiler(self.db).execute_sql(CURSOR)
  File "C:\Work\virtual_env\lib\site-packages\django\db\models\sql\compiler.py", line 1522, in execute_sql
    cursor = super().execute_sql(result_type)
  File "C:\Work\virtual_env\lib\site-packages\django\db\models\sql\compiler.py", line 1156, in execute_sql
    cursor.execute(sql, params)
  File "C:\Work\virtual_env\lib\site-packages\django\db\backends\utils.py", line 98, in execute
    return super().execute(sql, params)
  File "C:\Work\virtual_env\lib\site-packages\django\db\backends\utils.py", line 66, in execute
    return self._execute_with_wrappers(sql, params, many=False, executor=self._execute)
  File "C:\Work\virtual_env\lib\site-packages\django\db\backends\utils.py", line 75, in _execute_with_wrappers
    return executor(sql, params, many, context)
  File "C:\Work\virtual_env\lib\site-packages\django\db\backends\utils.py", line 84, in _execute
    return self.cursor.execute(sql, params)
  File "C:\Work\virtual_env\lib\site-packages\django\db\utils.py", line 90, in __exit__
    raise dj_exc_value.with_traceback(traceback) from exc_value
  File "C:\Work\virtual_env\lib\site-packages\django\db\backends\utils.py", line 84, in _execute
    return self.cursor.execute(sql, params)
django.db.utils.IntegrityError: null value in column "locale_id" violates not-null constraint
DETAIL:  Failing row contains (1, 0001, 1, 0, Root, root, t, f, /, , f, , null, null, f, 1, null, f, null, null, null, null, Root, null, null, 2ac624bf-c27c-4f38-8328-55abe117d0dc, null, null).

I have confirmed that this issue can be reproduced as described on a fresh Wagtail project: yes

Hi @Warqus - did you test this on a project without wagtail-localize installed? (For projects without wagtail-localize, this should have already been fixed in #6553.)

@gasman Thanks for your reaction. I see it is indeed only occurring when using wagtail-localize. I will report it at the wagtail-localize repository.


feat: let_projs tactic, recursively adding projections of hypotheses

let_projs adds let bindings for all projections of local hypotheses, recursively.
It's probably rarely useful interactively, but may be useful as a preprocessing step for tactics such as solve_by_elim.

I'm inclined to not surface this as a user-facing tactic at all, and just have a MetaM tactic for it. This introduces more API surface area which we have to avoid breaking later, without a compelling use case.

Good idea. I mostly wrote the syntactical frontend so I could test it. I've moved the syntax into the test file, and added a note that it is not useful otherwise.

Is there no worry that eagerly adding all projections is going to blow up in some cases, with large or deeply nested structures? Or is this only going to be used in places where the user expects to wait a bit longer (interactive exact? maybe)? Or is this simply a normal approach?

Is there no worry that eagerly adding all projections is going to blow up in some cases, with large or deeply nested structures? Or is this only going to be used in places where the user expects to wait a bit longer (interactive exact? maybe)? Or is this simply a normal approach?

@joehendrix's suggestion is that when other tactics are using this, if it is a user-called tactic it's okay to do something potentially expensive like this, but tactics called by other tactics should not.


You can transfer money between accounts with different currencies

It is possible to transfer money from one account to another account despite the two accounts having different currencies.

Duplicate of https://github.com/nlogozzo/NickvisionMoney/issues/144


[Build] Android sample app

Build issue(s)

Compiling the connectedhomeip/examples/android code failed

All of the CHIP imports are not resolved. Sample imports are:
import chip.devicecontroller.ChipDeviceController import chip.devicecontroller.ClusterIDMapping.* import chip.devicecontroller.InvokeCallback import chip.devicecontroller.ReportCallback import chip.devicecontroller.ResubscriptionAttemptCallback import chip.devicecontroller.SubscriptionEstablishedCallback import chip.devicecontroller.model.ChipAttributePath import chip.devicecontroller.model.ChipEventPath import chip.devicecontroller.model.InvokeElement import chip.devicecontroller.model.NodeState import chip.tlv.AnonymousTag import chip.tlv.ContextSpecificTag import chip.tlv.TlvWriter
Extra information: I am using Windows 10 laptop
Steps I did:
Clone connectedhomeip
Open connectedhomeip/examples/android/CHIPTool in Android Studio
Install latest NDK (Side by Side) - 25.2.9519653
Install latest Command Line Tools
Install SDK 26
Add ANDROID_HOME and ANDROID_NDK_HOME into my Environment Variables
Add JAVA_HOME will following value "C:\Program Files\Android\Android Studio\jre"
Execute scripts/bootstrap.sh
Next I tried the "Building Android CHIPTool from scripts" step but the cmd provided there is not working, so I change to "python scripts\build\build_examples.py --target android-arm64-chip-tool build" but I am getting error:
Traceback (most recent call last):   File "C:\xxx\AndroidStudioProjects\connectedhomeip\scripts\build\build_examples.py", line 22, in <module>     import click ModuleNotFoundError: No module named 'click'
But I assume this cmd would create an APK file, right? So, I return to Android Studio and try to run the examples/android/CHIPTool code, but still the CHIP import is not resolve and when I go ahead with "Run" the app, I got this:
Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make field private final java.lang.String java.io.File.path accessible: module java.base does not "opens java.io" to unnamed module @d1886a8
Sorry if my question here shouldn't create an issue, but I had been stuck here for few days and still couldn't figure it out how to get this code working on my machine. I would like to Debug/Run this app so that I could put breakpoint etc to understand the flow better.
Platform
android
Anything else?

@dzulhafiz-at
I didn't try android ChipTool build in windows environment.
If you load the SDK's example App (example/android/ChipTool) in android studio without library copy, I think this error appears because the library is not built.

From this connectedhomeip source code, is there a way for me to import the code into Android Studio so I could play around with the Matter commissioning and sending cluster command etc from my Android phone?

@joonhaengHeo

I didn't try android ChipTool build in windows environment.

Do you recomand to use Linux system to build the Android sample app?

You can find android build guide below URL. https://github.com/project-chip/connectedhomeip/blob/master/docs/guides/android_building.md

Actually this is the guide that I am referring too. I did mentioned in "Steps I did:" above what I had done but having issue at  "Building Android CHIPTool from scripts" step. A bit busy now, will try again next week in Mac if able to proceed

You can try the below,
docker run -it -v ~/workspace/connectedhomeip:/connectedhomeip ghcr.io/project-chip/chip-build-android:1
git config --global --add safe.directory /connectedhomeip
git config --global --add safe.directory /connectedhomeip/third_party/pigweed/repo
source scripts/bootstrap.sh
./scripts/build/build_examples.py --target linux-x64-java-matter-controller build
./scripts/build/build_examples.py --target linux-x64-all-clusters build
./scripts/build/build_examples.py --target linux-x64-chip-tool build

@dzulhafiz-at Hello brother, has this problem been solved？

Hello everyone. After proceeding with all the steps described at https://github.com/project-chip/connectedhomeip/blob/master/docs/guides/android_building.md I cannot build the CHIPTool app for android. I have kotlin Kotlin version 1.7.21-release-272 and did not touch the CHIPTool's files so the gradle version is gradle-7.1.1 and gradle plugin is classpath 'com.android.tools.build:gradle:4.2.0' . But I got this error:
> Task :app:compileDebugKotlin FAILED
FAILURE: Build failed with an exception.
28 actionable tasks: 20 executed, 8 up-to-date

* What went wrong:
Execution failed for task ':app:compileDebugKotlin'.
> A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction
   > Compilation error. See log for more details

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 32s

I don't know where I did wrong. Is there anyone who was able to build CHIPTool app? Thanks

@dzulhafiz-at Hello brother, has this problem been solved？

Sorry for the late reply. There was a adjustment on our solution for the app and I had some catching up to do to update the app based on new design. So, I had not revisit this ever since. I couldn't confirm if it works.

Unable to make field private final java.lang.String java.io.File.path accessible: module java.base does not "opens java.io"
i am facing similar error. How to resolve this any idea?


Temporarily disable MultiSpoutsMultiTasks test

continue investigation in #1687

👍
Would you please rename #1687 to something like "Fix and re-enable MultiSpoutsMultiTasks test"


[MSTeams] SPFx TeamsPersonalApp doesn't load in mobile client, showing SP error page

Category

[x] Bug

Describe the bug
We have created an SPFx application running as TeamsPersonalApp in MS Teams.
This works as expected in the web and desktop clients, but does not load in the mobile client.
An error message is shown:

Steps to reproduce

Create an SPFx webpart with supportedHosts: ["TeamsPersonalApp"]
Add the SPFx webpart as a personal app in MS Teams
Try to open the App in the Mobile client (iOS)

Expected behavior
The application should open in the mobile client as well, without showing an application error.
Environment details (development & target environment)

OS: iOS
Target Environment: SharePoint Online / MS Teams

@NickSevens I'm hitting the same error this morning (and other users have been facing this issue for the last week too). Like you, app works correctly in Desktop and web view but not in iOS or Android teams clients - both in Developer Preview and not.

our users are experiencing the same issue , it´s working ok for android users but not for IOS.


Reference app crashed on launch

Describe the bug
App is crashing after launched
Component
Core library, reference app
To Reproduce
Steps to reproduce the behavior:
In android-fhir-master project,

change the BASE_URL in HapiFhirService.kt file to http://local:system:ip:8080/fhir/ for a phone.
In FhirPeriodicSyncWorker.kt, remove NAIROBI so your sync-data looks like  mapOf("address-city" to "").Incase you need all observations or other resources, just add them to the map like ResourceType.Observation to mapOf("subject" to "Patient/1") to get observations for a particular patient or ResourceType.Observation to mapOf() to get all observations in the server. Just remember that it might take a long time to sync everything in case the server has a lot of data.
In PatientListViewModel.kt comment-out code inside private fun filterCity(search: Search) so that we don't just search for patients from "NAIROBI".
private fun filterCity(search: Search) {
search.filter(
Patient.ADDRESS_CITY,
{
//        modifier = StringFilterModifier.MATCHES_EXACTLY
//        value = "NAIROBI"
}
)
}
network_security_config.xml add the following line with appropriate ip for your local server. local:system:ip
Run reference App
Observe App Launch in device

Expected behavior
App should not crashed.
Smartphone (please complete the following information):
Device: Lenovo Tab
Android version: 10
Build number: TB-8505X-S320017_210427_BMP

Can you share the log?

@anita-vadverao
Can you please check whether issue is still reproducible at your end and also can you please share the log?
Actually, I am trying to reproduce it but do not see any crash..

Issue is not seen on the latest build beta 03.


Modification on function TWebsocketClient.DoHandshake(ASocket: TInetSocket): Boolean;

Hello,
I have added 'upg.ToLower' to the code below
ResponseData.Headers.Parse(HeaderStr.TrimRight);
    if not ((ResponseData.StatusCode = 101)
      and ResponseData.Headers.TryGetData('Connection', conn)
      and ResponseData.Headers.TryGetData('Upgrade', upg)
      and ResponseData.Headers.TryGetData('Sec-WebSocket-Accept', respKey)
      and (conn.ToLower = 'upgrade') and (upg.ToLower = 'websocket')
      and (B64Trim(respKey) = B64Trim(ExpectedResponseKey))) then
    begin
      // Read content if possible

Why?
Because when I connect to the debugging port of Chrome, it sends me back "WebSocket".
And the handcheck doesn't work because "WebSocket" is not equal to "websocket".
Thanks for your great job... Thierry

Hi, I have the same issue. But the code is not update.

Is fixed now


feat: crud example in trpc+prisma templates

Closes https://github.com/t3-oss/create-t3-app/issues/1079
✅ Checklist

[x] I have followed every step in the contributing guide (updated 2022-10-06).
[x] The PR title follows the convention we established conventional-commit
[x] I performed a functional test on my final commit

Changelog

adds a crud example (create + getAll) to projects that are initiated with trpc and prisma (plus any other combination of packages)
some minor index refactoring to make it easier to edit multiple of them - everything that's specific to certain packages now lives in separate components
we now have 10 index.tsx files. i'm so sorry

original version of this was built by @jdevries3133 - i ended up writing this from scratch because working from current next was easier, but would be good to include as a collaborator on the pr

Screenshots

💯

Played around with this, ends up requiring 12 (?) index.tsx files and similar situation for a few other files. I don't think it's worth the additional complexity for now. If someone has a better idea and wants to give this another try, feel free :)


I am unable to use Demo Generator

What type of ADO permission will provide me with the ability to Create a New Project so I can utilize the Demo/Training for Test Plan in ADO.

This shows you don't have sufficient permission to perform complete operations like creating projects, teams, service connections, and pipelines.
Please check with Organization Administrator to extend the required access or create a new organization and try to provision the project.


removed unused param

Pull Request Type

[ ] Feature
[ ] Bug Fix

Link to Notion Task or Github Issue

Summary of Feature(s)

Summary of Bug Fix(es)
Previous Behaviour
Description of the bug and it's impact
New Behaviour
Description of the bug fix and it's impact
Other details

Dependencies

need release notes


leam-base.joda-time.mid-2253.idx-177221.5.mutant

This is an edit in the format in the MutableInterval file.

LGTM 👍


Move window to another virtual desktop

Description of the new feature / enhancement
It should allow to move the active window to the next and previous or some virtual desktop using a keyboard shortcut or a new context menu option when you right-click the application in the taskbar.
Scenario when this would be used?
The current flow to move one windows to another desktop requires to open the Task View and drag and drop the desired window from one desktop to another and that is not efficient.
Supporting information
No response

Tracked with #16


Fix error spamming for 2d skeleton modifications

bone_id cannot be less than zero
Fixes https://github.com/godotengine/godot/issues/76712

Hey, thanks for opening the PR! I'm not expert in animation, but this doesn't seem to be the correct fix. The value of -1 is normally used to initialize such fields and is supposed to mean "no value". It's likely the issue that causes spam is elsewhere.

We cannot initialize an invalid bone to the first bone.
The problem needs to be fixed in SkeletonModification2DTwoBoneIK, and SkeletonModification2DLookAt.

@YuriSizov  @fire thanks for the feedback!
Updated the commit


vCheck-Tools in config-gui branch

I was playing with this Thursday, trying to get it to work and was getting an XAML error.  I figured out that line 29 was trying to store the path with "\vCheck" appended to the end of the path.  When I run this tool, I am in the directory that contains the vCheck.ps1, so there is no sub-directory under that named "\vCheck".  When I removed the part that appends "\vCheck" to the ScriptPath variable, the script worked fine for me.

Yep, good catch. Was a pretty quick commit just to merge the code into the one repo. Will fix it up now


Add new features: Safe LoRA

Hello,
We have published a paper called Safe LoRA (https://arxiv.org/abs/2405.16833).
This work focuses on improving the safety of well-trained LoRA models.
Additionally, I have provided an example implementation in the model.py file to illustrate how to apply the Safe LoRA approach effectively.

Thanks for proposing this PR to add the Safe LoRA method to PEFT. I have only skimmed the code and paper, so this is not an in-depth review yet.
Based on what I saw, this is my high level understanding. As a user, I start out by training a LoRA adapter on my dataset using an aligned model as the base model. Next, I want to restore safety which may be reduced after training. For this, I take my trained LoRA model, the base model, and the aligned model, Then Safe LoRA will create a new adapter that "injects" the alignment back into my LoRA adapter. Please correct me if my understanding is incorrect.
Implementation-wise, I wonder if we really need a SafeLoRA class. Here is a proposal for a different user API, LMK what you think:
peft_model = ...  # my trained LoRA model

# apply_safe_lora is a new function that does what SafeLoRA currently does
# additional arguments like select_layers_type are option args for apply_safe_lora
aligned_model = apply_safe_lora(peft_model, base_model_id, aligned_model_id)

# persist the new safe LoRA adapter
aligned_model.save_pretrained(...)

IMO, this would be a simpler API and it would achieve the same thing at the end.
In this example, the aligned_model could actually be the same peft_model as initially, just with a new LoRA adapter loaded which is the Safe LoRA adapter.
Another concern I saw when I read the code is that it looks like it will require a lot of memory. IIUC, we need to have the PEFT model, a copy of the PEFT model, the base model, and the aligned model in memory all at once. Even on CPU RAM, this could be difficult to achieve for many users. I wonder if it would be possible to load the weights from the base model and the aligned model one at a time, at least as an option.
I have already implemented something like this for another use case. Here is the code:
https://github.com/huggingface/peft/blob/ccc350151f95a9ff95da046bae5671da75eab52f/src/peft/utils/loftq_utils.py#L263-L411
It only works for safetensors, because pickle does not allow to load the weights lazily, but I still think it could be a nice addition.
Also, do we really need a full copy of the PEFT model? Would it be sufficient to only copy the LoRA weights? Ideally, I would like to see a solution that works even if the user has less than twice the memory required for the base model. If this doesn't work, it's also okay, but it would greatly reduce the number of users who can use the method.

Thank you for taking the time to read the code and the paper.
Yes, your understanding is correct.
Since SafeLoRA is not a new training method for LoRA, but rather a process that enhances the safety of a well-trained LoRA model through certain operations, it may not be necessary to have a separate SafeLoRA class.
The most CPU memory-intensive operation here is likely when executing get_aligned_matrix(), as it requires loading both the base model and the aligned model. If it were possible to implement lazy loading for both models simultaneously, allowing for the subtraction of weights in the same position to obtain the aligned matrix, it could potentially be a solution.
Regarding your last question, my current code in projected_weighted() does load the complete PEFT model (aligned model + LoRA). However, it is indeed possible to operate only on the LoRA weights without needing to load the weights of the aligned model as well. Once the user has obtained the new LoRA weights, they can then add them to the original aligned model.

Thanks for confirming and further explaining. Would you be willing to make the suggested changes? I think it would help a lot with user adoption of the new method.

Yes, I will make the changes you suggested.
I would like to ask if SafeLoRA is modified into the form of a function like apply_safelora instead of being a safeLoRA class, should it still be placed under tuners/, or somewhere else?

Yes, I will make the changes you suggested.

Great, thanks.

I would like to ask if SafeLoRA is modified into the form of a function like apply_safelora instead of being a safeLoRA class, should it still be placed under tuners/, or somewhere else?

Good question, I think it should be placed elsewhere. I don't have a strong opinion, how about utils/safelora.py?

@chiayi-hsu do you still plan on working on this?

Yes, I’ll update the new version this week.
Thanks!
Benjamin Bossan @.***>於 2024年10月28日 週一，18:39寫道：

@chiayi-hsu https://github.com/chiayi-hsu do you still plan on working
on this?
—
Reply to this email directly, view it on GitHub
https://github.com/huggingface/peft/pull/2098#issuecomment-2441217354,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AS67YGV2JRHZNJTO6DFGBFLZ5YA6FAVCNFSM6AAAAABO3KQJSKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBRGIYTOMZVGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hello,
I have changed the SafeLoRA```` class into the apply_safelorafunction in thepeft/utils/safelora.py````. For loading the base and aligned models, based on your suggestion, I now use safetensors to load the weights.
Additionally, regarding the projected weights, I originally loaded the weights of both the complete base model and the PEFT model, but I have now modified it to only load the weights of the PEFT model. I think this should be more memory-efficient for the user's GPU/CPU.
If you have any suggestions, please let me know.
Thank you!

Sorry for the inconvenience. The pull request was closed due to syncing with the latest version of PEFT. I have resubmitted the PR.


Publish docker images based on NVIDIA CUDA images.

This would be a really solid differentiator for postgresml

Fix #681


Lambdas

The current implementation doesn't implement the lambda functions as per the mustache spec.

[x] Lambda functions as data values for Interpolation tags and so treated as an arity 0 function.
[x] Lambda functions used as a section tag should be treated as an arity 1 function and invoked, passing the unprocessed section contents.

The return of both should be rendered against the current delimiters and then interpolated.

All spec tests succeed. Currently a hack in place due to accessing of global variables from DynamicExpresso delegates as it copies the state when the delegate is created.

Released in version <IP_ADDRESS>


Setting Up and Running Functional Tests

Refresh with multiple testing options/tools (Selenium/Playwright/Azure Pipelines how to run).

Just checking in.


keep_ar has wrong output, does not match crop_resize script

example
wrong = vskernels.Catrom.scale(clip, width=1920, height=804, src_height=1606, src_top=277, keep_ar=True)
correct = crop_resize(clip, width=1920, height=804, src_height=1606, src_top=277)

fixed by https://github.com/Irrational-Encoding-Wizardry/vs-kernels/commit/23de3877a27fd3fe877f14059c3a6121ff168ac2

for the record, was just preferring shift parameter over kwargs


Silence and Stuttering

When running this, one thing that has been noticed is that the audio will play fine for a few seconds, and then silence, and maybe bits and pieces in between.
It is able to determine what is playing.
Is this an issue with streaming? What could be done?

This issue happens to me on every device I've tried except my Pixel 2 XL; even on devices that are only a couple years old, like my Nexus 6P.

I refactored the app to use better/faster/stronger native audio APIs using the Android Oboe library. Performance seems much improved on the different devices I'm able to test on (Pixel 3, Nexus 6, Nexus 5C).
Check out v1.0.0 in the Releases section and re-open an issue if you're still seeing problems.


chore: upgrade dependencies

Pre-flight checklist

[ ] I have read the Contributing Guidelines on pull requests.
[ ] If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
[ ] If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation
Due to the shear number of dependencies needing update, this PR only does minor/patch updates. All major updates go into a separate PR to avoid breaks as much as possible.
Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs

cc @shortcuts We are getting these type checking failures:
Error: ../node_modules/@algolia/autocomplete-preset-algolia/dist/esm/types/algoliasearch.d.ts(7,74): error TS2339: Property 'liteClient' does not exist on type 'typeof import("/home/runner/work/docusaurus/docusaurus/node_modules/algoliasearch/lite")'.
Error: ../node_modules/@algolia/autocomplete-preset-algolia/dist/esm/types/algoliasearch.d.ts([8](https://github.com/facebook/docusaurus/actions/runs/3878383730/jobs/6614488154#step:6:9),75): error TS2339: Property 'searchClient' does not exist on type 'typeof import("/home/runner/work/docusaurus/docusaurus/node_modules/@algolia/client-search/dist/client-search")'.
Error: ../node_modules/@algolia/autocomplete-preset-algolia/dist/esm/types/algoliasearch.d.ts(20,23): error TS26[9](https://github.com/facebook/docusaurus/actions/runs/3878383730/jobs/6614488154#step:6:10)4: Namespace '"/home/runner/work/docusaurus/docusaurus/node_modules/algoliasearch/lite"' has no exported member 'LegacySearchMethodProps'.
Error: ../node_modules/@algolia/autocomplete-preset-algolia/dist/esm/types/algoliasearch.d.ts(24,23): error TS2694: Namespace '"/home/runner/work/docusaurus/docusaurus/node_modules/algoliasearch/lite"' has no exported member 'SearchForFacetValuesResponse'.
Error: ../node_modules/@algolia/autocomplete-preset-algolia/dist/esm/types/algoliasearch.d.ts(28,23): error TS2694: Namespace '"/home/runner/work/docusaurus/docusaurus/node_modules/algoliasearch/lite"' has no exported member 'SearchResponse'.
Error: ../node_modules/@algolia/autocomplete-preset-algolia/dist/esm/types/algoliasearch.d.ts(32,23): error TS2694: Namespace '"/home/runner/work/docusaurus/docusaurus/node_modules/algoliasearch/lite"' has no exported member 'HighlightResult'.
Error: ../node_modules/@algolia/autocomplete-preset-algolia/dist/esm/types/algoliasearch.d.ts(36,23): error TS2694: Namespace '"/home/runner/work/docusaurus/docusaurus/node_modules/algoliasearch/lite"' has no exported member 'SnippetResult'.

Does that look like a bug in the Algolia code base?

oops it seems to be an upstream update that wasn't detected on the DocSearch side by renovate 🤔 releasing the update in 3.3.2

update: fixed in 3.3.2

Thank you—that was really helpful!


[fontInfoView] BlueValues lost when number of values is odd

In Robofont Version 4.1b (build<PHONE_NUMBER>) I encountered the following problem which according to @typemytype might be related to the functionality of fontInfoView (or how Robofont interacts with it).
Steps to reproduce
In a new font: Open Font Info, go to the Postscript sheet and enter 2 values into BlueValues. Hit okay. Go back to the Postscript Sheet and add a third value (one shouldn’t, I know) and click okay again. Open the Postscript sheet in the font info another time and all BlueValues entries are gone.

a NumberSequenceFormatter marks the input as invalid is its uneven so the EditText returns None.
I dont know if it should return a invalid string.


Format math functions (minor fix)

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

VBA/Language-Reference-VBA/articles/math-functions.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

VBA/Language-Reference-VBA/articles/math-functions.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

All content in this repository has been migrated to a new repository (https://github.com/MicrosoftDocs/VBA-Docs). The changes in this PR have been applied in the new repository, so this PR is being closed. The changes will be published to the live docs soon. Thank you for your contribution!


Footer

What needs to be in the footer?

Brought to you by Drupal4Gov
Site map?

Here's the one from Drupalcon LA

No idea. On the old site we just had the COD credit. Maybe for now we don't need anything else?

In case you want to look at the old site here is google cache: http://webcache.googleusercontent.com/search?q=cache:ScsGAzQp4KcJ:2014.capitalcampandgovdays.com/+&cd=1&hl=en&ct=clnk&gl=us

I think minimal is good.  Maybe like... a link to D.O and maybe to
Twitter/G+/GDO...?
On Mar 15, 2015 11:38 PM, "Tim Wood"<EMAIL_ADDRESS>wrote:

No idea. On the old site we just had the COD credit. Maybe for now we
don't need anything else?
[image: image]
https://cloud.githubusercontent.com/assets/91050/6660283/5f1830f8-cb6c-11e4-88ca-ed319a7365bf.png
In case you want to look at the old site here is google cache:
http://webcache.googleusercontent.com/search?q=cache:ScsGAzQp4KcJ:2014.capitalcampandgovdays.com/+&cd=1&hl=en&ct=clnk&gl=us
—
Reply to this email directly or view it on GitHub
https://github.com/Drupal4Gov/Drupal-GovCon-2015/issues/44#issuecomment-81383374
.

I have a super basic page up at drupal4gov.us
Think we can link to that, or would you prefer it look nicer before we do?

Oh, cool. Didn't know anyone was working on that. I mean, I vaguely remember you mentioning it Jess. By the way, did you know the domain www.drupalforgov.org is owned by someone and DNS is pointing to and Acquia is configured for in the CapCamp acquia site?

James King also suggested repeating the main menu in the footer, which isn't such a bad idea.

From a UX/IA perspective, having the main menu in the footer gives the user more options for navigation, which is never a bad thing.
Sent from my iPhone

On Mar 19, 2015, at 11:54 PM, Tim Wood<EMAIL_ADDRESS>wrote:
James King also suggested repeating the main menu in the footer, which isn't such a bad idea.
—
Reply to this email directly or view it on GitHub.

I've added the default main menu block to the footer and set all the top level menu items with sub-items to show expanded. It ends up looking like the screenshot below (desktop and then mobie). If everyone is okay with it, I'll commit an update hook to enable this block on the live site.

Could we update the styling so it looks like the Drupalcon LA site? It's just cleaner and easier to read.

Will leave that up to @jonraedeke

Committed some basic styling.

Much better!


apiv2 with openapi spec, generator, regression, sdk

Exos-X API v2
The main focus of this pull request is to use an auto-generated MC OpenAPI specification to generate a library that is used by API v2. A common set of types and functions is used to make the transition from v1 to v2 smoother.
Some changes are required to the CSI Driver and any other users of API v1.

Use "github.com/Seagate/seagate-exos-x-api-go/pkg/v1" for exosx v1

Use "github.com/Seagate/seagate-exos-x-api-go/pkg/v2" for openapi v2

Switch to use common API types and functions

The API no longer returns XML objects, only common Go structs

New items and folders developed for v2

/api containing MC OpenAPI YAML specification (auto-generated)
cmd/api-regression for automated v1 and v2 testing
internal/generator - generates MC OpenAPI YAML specification
internal/validator - simple MC OpenAPI client validation
/pkg/client - generated Go library from MC OpenAPI specification
/pkg/common - type definitions common to v1 and v2
/pkg/v1- v1 API with minimal changes to coordinate with v2
/pkg/v2- v2 API with same functions as v1 to make transition smoother
/pkg/regression - main function and Ginkgo test specifications

api-regression testing v1 and v2

provides regression testing for API v1 and API v2 (requires live controller)
leverages custom test main, Ginko, and Gomega
pkg/regression for v1_ and v2_ test specifications
test specifications for login, system, volumes, host mapping, and snapshots
v2 testing is consistently 4 times faster
Use --ginkgo.focus "v1" or --ginkgo.focus "v2"
./api-regression -debug 4 -config i1.conf --ginkgo.v --ginkgo.fail-fast --ginkgo.focus "v1"

Ran 20 of 40 Specs in 59.556 seconds
SUCCESS! -- 20 Passed | 0 Failed | 0 Pending | 20 Skipped

./api-regression -debug 4 -config i1.conf --ginkgo.v --ginkgo.fail-fast --ginkgo.focus "v2"

Ran 20 of 40 Specs in 12.285 seconds
SUCCESS! -- 20 Passed | 0 Failed | 0 Pending | 20 Skipped

Removals

/test - old test folder was removed
/mock - old simple test mock server removed

Additional work is required to properly handle the copy volume API call and that will be handled in follow on pull requests.


Y axis unit and range

Feature request.
It would be a great feature if we could setup a unit and range of the Y axis.
At the moment Cachet is not displaying scale on the Y axis and it is impossible to set a range for the graph. As a result of that if the values are very close to each other, drop by -1 look like this:

Which suggest there is an issue as it looks like there is a significant drop of values, while the drop is only marginal.

@joecohens do you think we can safely set the Y-axis to display in most circumstances?

@jbrooksuk We will have to take a look, but I'm thinking it's possible :)

In 2.0 the y axis will show the labels.

Will it have range too ?

It's self-calculating.

Backporting to 1.2.

I understand it's at the moment, but that causes problems when the values are very consistent and there is a minimum variation from time to time, so it would be beneficial to be able to set range manually.
Also, as in my original post it would be grate to be able to set the number of decimal places to be displayed.


Write connection on startup doesn't always work

Describe the bug

When starting chatterino I sometimes am not able to send messages in chat and if I restart chatterino it might fix it. I get history messages and whatever, but am not able to send messages, waiting some time does not resolve this.
To reproduce

Open chatterino.
Try to write in chat -> doesn't send anything.
Chatterino version

This happens on basically latest using arch linux as well as Chatterino Nightly 2.2.2 (commit 3be62c929, ) on windows.
Operating system

Windows 8.1 and arch linux.
Additional information

Related #1831, #2612

Without investigating, one thing that might be able to break this is if a user sends a message on the write connection before it has been fully connected/authenticated

can confirm that is also the case, but even waiting some min before sending it doesn't work

Duplicate of #2425

Duplicate of #2356
Oops wrong issue sorry

Accidently linked wrong issue... Sorry.


[Question] Why Sticky children is now a function ?

Hi,
First of all, nice work here.
A question regarding 6.0.0 breaking change, why is it not possible anymore to pass a single element as a child ? The 6.0.0 makes the code less readable (in my opinion) when using the default behavior.
e.g. my layout component is a StickyContainer and my context / navigation bar is a Sticky component in it.

So this change has been a long time in the works - at least mentally....
Since version 3 or so, many issues have been created as a direct result of the inflexibility inherent to the single-child declarative API.  In hindsight, I now realize that the source of these issues was that "stickyness" isn't really structural, it's more of an aspect. The new approach circumvents this inflexibility by going functional - giving the implementer direct access to the nuts and bolts of sticky state management and letting them choose how to respond - with sane defaults for the most common use cases.
The drawback here is that readability definitely suffered, but readability wasn't the priority - flexibility was. That said, with decorator support coming in the next release, I think these (valid) concerns of yours will be mitigated.


Dashboard "Most Frequent Note"-Bug

Sometimes most frequent note on dashboard gets "15"

most_frequent_note on all results is 15!


Staking support in SDK 0.38

Describe the bug
Staking support seems not to be working. I'm using SDK 0.38.1.
I do not have a problem to stake with big-dipper master branch and SDK 0.37.6
To Reproduce
Merged agoric-labs:validatorStatus0 into forbole:kwun/sdk-v0.38.x.
Transfer stake to my ledger account
Logged in to ledger via big-dipper
Opened validator, and clicked delegate
Received error Cannot read property '0' of undefined

Thanks for reporting.

Not sure where you guys are on this, but I'm working with big-dipper on sdk 0.38.3 - took me a few changes, which you can see on my fork. Feel free to take a look if you didn't get around to it yet

Do you know if staking is working?

Delegating is working. Looking at it I found a bug with withdrawing rewards though, so I'll have to take a look at that

Thanks @Cashmaney ! We have a PR for that issue but haven't organize all of them yet.

Just tested it yesterday! Works perfect!


Beta testing?

Now that we have >2000 active installs, I'm wondering if we should consider some form of beta testing to reduce the chances of us pushing broken code in a release. What do you guys think, would it be useful or should we not bother until we have more active users? If it's a good idea, how should the beta testing be carried out?

Good idea!
And possibly set Github to push to beta at every commit to master:
https://github.com/codepath/android_guides/wiki/Automating-Publishing-to-the-Play-Store
On Tue, Mar 7, 2017 at 7:31 PM, Josephine Lim<EMAIL_ADDRESS>wrote:

Now that we have >2000 active installs, I'm wondering if we should
consider some form of beta testing to reduce the chances of us pushing
broken code in a release. What do you guys think, would it be useful or
should we not bother until we have more active users? If it's a good idea,
how should the beta testing be carried out?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/commons-app/apps-android-commons/issues/403, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAGFBks9IoeMMocsMcJ5gZOgc59ZWcW_ks5rjTICgaJpZM4MVTW6
.

@nicolas-raoul so the beta on Google Play will technically be a separate app, right? Do we need to get WMF permission to do so?

Google Play can have several versions of the same app (release/beta/alpha).
No need to have several apps.
People who subscribe to a special Google Group get the betas.
On Tue, Mar 7, 2017 at 7:40 PM, Josephine Lim<EMAIL_ADDRESS>wrote:

@nicolas-raoul https://github.com/nicolas-raoul so the beta on Google
Play will technically be a separate app, right? Do we need to get WMF
permission to do so?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/commons-app/apps-android-commons/issues/403#issuecomment-284685525,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGFBlVwa45cu0bujl90UGV87EY5nSw3ks5rjTQjgaJpZM4MVTW6
.

Great, thanks. Will try to set it up ASAP.

IRC Cloud shows it like this in the settings which I think is very transparent. It then routes you to a Google login where you can switch to the Beta testing. How is this done for FDroid?

What do we want to use as the feedback channel for our beta? I was initially thinking they could just open issues here with BETA in the title (and we could add a tag), but it would get unwieldy pretty quickly.
What other options are there?

Also, I can't publish an APK in beta with the same version number as the release APK. Ideally we would just always push to beta and then switch the same APK to release once it's proven to be stable, but that wouldn't always be feasible. E.g. if we have a hotfix that really needs to go straight to release. Or if we need to make changes to the beta, and then we want to push a release without having anything new that needs to go to beta yet. Seems like there'd be a lot of superfluous version numbers just to cater to the "no two APKs with same version number" rule in Google Play?

Reporting here is the best, I think.
Some reported issue will probably be found to exist also in the stable
version.
Also, having a separate place would force the developers to look at two
places.
On Thu, Mar 9, 2017 at 5:16 PM, Josephine Lim<EMAIL_ADDRESS>wrote:

What do we want to use as the feedback channel for our beta? I was
initially thinking they could just open issues here with BETA in the title
(and we could add a tag), but it would get unwieldy pretty quickly.
What other options are there?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/commons-app/apps-android-commons/issues/403#issuecomment-285284390,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGFBm8Hmf3sbk-QQLWe-kQMB2vROsq_ks5rj7VdgaJpZM4MVTW6
.

Do we want to have a "beta" branch here, with "master" being used for the live version?

I would suggest switching to this versionCode numbering:
Mmmmhh
M: Major version number
mmm: Minor version number
hh: Hotfix number
Examples:
200500 for the original 2.5
200501 for the first hotfix to 2.5
705613 for the 13th hotfix to 7.56

If not urgent, always release as beta
After 2 days in beta, if there are no complains, just click the button in Google Play to move that release to production
If an urgent fix is needed for the production-released 2.5 (for instance), then create a branch "2.5-hotfix" from the release commit, implement the fix, and release as 2.5.1 directly in production

Beta branch: The best solution would probably be (or gitflow) but I suggest we wait until we have at least 30 beta testers. How many beta testers do we have now?

Thanks @nicolas-raoul ! I haven't released the beta signup URL yet, because I've been trying to figure out how to set the system up. If we don't use a beta branch or gitflow, should we just use master for everything?

Using master for everything (except hotfixes) is probably the easiest for
now, yes.
On Thu, Mar 9, 2017 at 5:54 PM, Josephine Lim<EMAIL_ADDRESS>wrote:

Thanks @nicolas-raoul https://github.com/nicolas-raoul ! I haven't
released the beta signup URL yet, because I've been trying to figure out
how to set the system up. If we don't use a beta branch or gitflow, should
we just use master for everything?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/commons-app/apps-android-commons/issues/403#issuecomment-285291943,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGFBt1zWN-qg7aObkG9mJBVJGjz1llUks5rj75DgaJpZM4MVTW6
.

So... under the versionCode numbering that you suggested, we would use 200001 for the current release, right?

Yes!
I suggest writing a small script that increases version code and name
automatically, to avoid mistakes. Could be in the vein of this one:
https://github.com/ankidroid/Anki-Android/blob/develop/tools/release.sh#L32
On Thu, Mar 9, 2017 at 6:02 PM, Josephine Lim<EMAIL_ADDRESS>wrote:

So... under the versionCode numbering that you suggested, we would use
200001 for the current release, right?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/commons-app/apps-android-commons/issues/403#issuecomment-285293910,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGFBuhdtwSNmtzaSsya0uUCZH3Qdzgoks5rj8A-gaJpZM4MVTW6
.

Oh okay. I guess I'll just carry on with the standard numbering first, until we can get the script ready. Otherwise 1 mistake could throw the whole thing off since we need to upload sequentially, lol.

I've pushed the first beta release! Opt-in at https://play.google.com/apps/testing/fr.free.nrw.commons .
Would appreciate it if folks here could opt in and see if it works for them. If everything is okay, I'll announce the opt-in link on our forums and WMF mailing lists.
I think we might also want a link in the app like @tobias47n9e suggested. I guess it would just be a straightforward addition of a link in our Settings.

Does the beta work for anyone else? I'd like to announce the opt-in URL on mailing lists etc soon if possible. :)

@misaochan Beta works perfectly. It is listed with other Beta-Apps in the Play store. Can we ping someone that is using FDroid?

Thanks @tobias47n9e ! @nicolas-raoul , do you use F-Droid?

F-Droid does not allow beta versions, so I get Commons from Play beta.
On 12 Mar 2017 21:18, "Josephine Lim"<EMAIL_ADDRESS>wrote:

Thanks @tobias47n9e https://github.com/tobias47n9e ! @nicolas-raoul
https://github.com/nicolas-raoul , do you use F-Droid?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/commons-app/apps-android-commons/issues/403#issuecomment-285940852,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGFBmmPIYuc5zWUQAonBt59keGwuI-gks5rk-KngaJpZM4MVTW6
.

Ah, okay, that's fine then. Will announce soon. :)

Re: the version names, I think I will probably use 2.x.0 for major changes and 2.x.y for minor changes? Granted, the line between 'major' and 'minor' is pretty subjective, but since the version name is largely "for display" anyway, I figure that shouldn't be too bad? The next patch with the beta link and potential UI improvements sounds like it should be a major change for instance, so 2.1.0. I don't think it will be feasible for us to hold on to 2.0.y all the way up to Vienna. :)

I would suggest using 2.x.0 for any enhancement, even minor; and 2.x.y only
for hotfixes to version 2.x
Of course 2.0 is quite significant PR-wise so this "rule" can be put aside
for 2.0.
On Mon, Mar 13, 2017 at 2:54 AM, Josephine Lim<EMAIL_ADDRESS>wrote:

Re: the version names, I think I will probably use 2.x.0 for major changes
and 2.x.y for minor changes? Granted, the line between 'major' and 'minor'
is pretty subjective, but since the version name is largely "for display"
anyway, I figure that shouldn't be too bad? The next patch with the beta
link and potential UI improvements sounds like it should be a major change
for instance, so 2.1.0. I don't think it will be feasible for us to hold on
to 2.0.y all the way up to Vienna. :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/commons-app/apps-android-commons/issues/403#issuecomment-285961567,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGFBsEWMvR_ZOospUyXjgphyvykyXO2ks5rlDFEgaJpZM4MVTW6
.

Ah okay, that does make sense. Thanks nicolas!

Will close this since beta testing has been set up, and will create new issues for further beta testing enhancements.


Stx not sending

Hello dear team i have sent my STX token to other wallet its been 30minuts but i still have not received my tokens in my wallet there is still pending even i have paid Higher Fee
Transaction ID 0x377b1fd6bb4ef4760c4d1fbc81e99d31a8d3ca723cfff4f2958e9543e1b6ba37
Address SP2R309V8FY2PQB4A8PWZY5E4EAWP3XAJE5PARJW0
Block#  pending
Time stamp
Pending
*

Device: [Tecno Spark5 pro]
version [10]
Browser [Xverse Wallet]

Closing as the tx was finally cancelled https://explorer.stacks.co/txid/0x377b1fd6bb4ef4760c4d1fbc81e99d31a8d3ca723cfff4f2958e9543e1b6ba37?chain=mainnet


workspace.asRelativePath doesn't work for path outside workspace

From verifying #10446
(on Linux, 1.5.0-insider, Commit d2c04e3789757413ae1ebfda9d88896686b6d006)
let input = "/home/aeschli/frr/samples/docker";

console.log("root: " + workspace.rootPath);
console.log("input: " + input);
console.log("output: " + workspace.asRelativePath(input));

Output:
root: /home/aeschli/workspaces/samples/docker
input: /home/aeschli/frr/samples/docker
output: /home/aeschli/frr/samples/docker
If this expected then maybe this we could add it to the doc.

@aeschli Like so: https://github.com/Microsoft/vscode/blob/master/src/vs/vscode.d.ts#L3580

Ok, now I see it. Just not very intuitive, this API. asRelativePath returns an absolute path.
'when the path is not a child of that folder, the input is returned.'
Then, this is then actually a bug:
root: /home/aeschli/workspaces/samples/docker
input: /home/aeschli/workspaces/samples/docker
output:

Let me know if you want a separate issue.

Yup - i'll use this issue

just not very intuitive, this API. asRelativePath returns an absolute path.

The idea is that you can use that function to show workspace relative paths in the UI. that's how the funny default came in - cos then you wanna see the full path


Fix dig bug for Array

I've fixed #373 bug. Issue was caused by trying to convert strings to integers. Default ruby implementation doesn't support it. So my approach is make an attempt to convert string and in case of failure just leave unconverted value to be handled by default #dig method. By doing this we save conversion feature while staying close to original implementation. Made it explicit block to be sure which exception could we catch.

Perfect, thanks @sazor.


Swap - Grouped fixes for the release

Since most of the tasks are small and don't require a new pr to test them, I'm grouping them here to make it easier for @Arnaud97234 to test. I'll link to the individual tasks that are addressed and you can check the boxes for those that are ok.
Tasks addressed

[ ] LL-3563 Wordings, all-in-one

Check that no wording is broken while doing the other checks
Match against the ticket to be extra sure I didn't miss something.

[x] LL-3562 Drop the Add account list footer since it's not on the design

Go to swap flow
Select currency
Make sure the Add Account CTA is not present, not on the FROM flow, not on the TO flow.

[x] LL-3584 Sync styles for tab navigation with Buy feature

Go to swap flow (before accepting the KYC checkbox)
Make sure the disclaimer footer text does not overflow to the right, in particular on an iPhone 7 according to the issue.

[x] LL-3585 Sync styles for tab navigation with Buy feature

Go to swap flow
Make sure the tab navigation styles match the Buy feature (Capital casing, and semibold)

[x] LL-3527  Introduce the swap banner replacing the buy banner

Launch the app
Make sure the Buy banner is not visible, and the Swap banner is visible. Banner CTA should go to swap, and be dismissible

[ ] LL-3570 Auto update swap status on history/op details

Either manually modify the app state to have a pending swap, or create a new swap.
Go into the swap history
Go into the swap details for that swap
Wait until the swap status changes to finished.

[ ] LL-3588 Add disclaimer to the pending operation screen

Make a swap
Check that the pending screen doesn't break
Check that it shows a disclaimer and the disclaimer has the name of the provider

[ ] LL-3592 Add styles to provider name link on the operation details

Go to the swap history
Open a swap operation details screen
Check that the provider "Changelly" is blue, shows the little icon and opens the changelly url.

Type
Bug Fixes, Features, Code Quality Improvements, UI Polishes

great desc. thanks @juan-cortes


On new instrument and new auction page, the claims tree for a newly created instrument is not displayed

To reproduce, create and issue an instrument (I did a variable rate bond). Go to http://localhost:3000/#/app/distribution/new/auction and select your instrument. The claims tree is not rendered. For the pre-existing instruments the claim tree is rendered correctly.

Error is:
"FAILED_PRECONDITION: DAML_INTERPRETATION_ERROR(9,704c8f15): Interpretation error: Error: Unhandled Daml exception: DA.Exception.GeneralError:GeneralError@86828b98{ message = "Missing observable"USD/LIBOR/6M" at time 2023-01-17T12:00:00Z" }. Details: Last location: [unknown source], partial transaction: root node NodeId(0): Exercise(ContractId(00862716ab8f07ac23899962425037355f3830c99eca7f29f8aff0ca7a339801f1ca001220399a3104fcb2f29b1aa680cb0c08ccb77fa3ea5a5acbf4ece25404f2bf8b1f9a),c3480c177dc8eb5fb4eca155bcfd3bc90f9c649c79ecff28d4d0bb4644f9e0c0:Daml.Finance.App.Lifec..."
Issue can be resolved by amending line 41 of util.ts to:
  { value: "USD-LIBOR-6M", display: "USD Libor 6M" },
ie replace the '/'s with '-'s

Actually probably preferable to amend lines 104, 105 of Default.daml to:
    libor3M = "USD/LIBOR/3M"
    libor6M = "USD/LIBOR/6M"

Fixed in pr #90


Port doesn't seem to disconnect properly when app closes

The application works fine for me when I run it the first time. I can connect several clients to the server without any issue. But when I close the server and open it again, it doesn't work anymore. The port is not available, I get this error in the console:
Unchecked runtime.lastError while running socket.listen: Could not listen on the specified port.
at Object.callback (chrome-extension://caaahhaifmadednjncngiplcbafblklm/http.js:257:14)reportIfUnchecked @ extensions::lastError:133
extensions::uncaught_exception_handler:8 Error in response to socket.accept: Error: Invocation of form socket.read(undefined, function) doesn't match definition socket.read(integer socketId, optional integer bufferSize, function callback)
I need to kill all chrome processes in task manager to make it work again.

Which app are you running?

Oooops sorry forgot to say... It's the websocket-server.

Also forgot to say... The previous behaviour I described happens in Windows 10. On a Mac computer (OS 10.10.1) the app also runs normally the first time, but when we close it and open again it crashes all chrome windows.

Can you open chrome://crashes, find the crash report corresponding to the time when you encountered the issue and file a bug?

Ok... Is this what you need?
report_id:2e63469424036cfa

Yes, thank you. I'm taking a look.


GPIO configuration bug

It appears that in some cases, the order of pinMode calls affects the pin configuration.
For example, a test program containing the following two lines
pinMode(GPIO0_2, OUTPUT, 0)
pinMode(GPIO0_20, INPUT, 0)
works as expected. Specifically, in the pins file we find
pin 84 (44e10950) 00000007 pinctrl-single
pin 109 (44e109b4) 0000002f pinctrl-single
pin number 84 corresponds to GPIO0_2 and 109 corresponds to GPIO0_20.
However, if you reverse the order of the two pinMode calls, you get
pin 84 (44e10950) 00000007 pinctrl-single
pin 109 (44e109b4) 00000007 pinctrl-single
That is, both signals are configured as outputs.

Followup to my post. I have just discovered that while the pins file is not correct, it appears that the exported configuration in /sys/class/gpio is correct. In particular, the value of /sys/class/gpio/gpio_20/direction is "in", even though the pins file shows that signal as an output. ARGH!!!
So, it now appears that the bug may actually be in the Linux kernel. Or perhaps I am mistaken my understanding of the pins file.
If anyone out there understands what's going on, please enlighten me.

Hit the wrong button. This issue is not closed.


Update licenses for 41 casks

Most of these are pretty straightforward, any rationales are in the commit message.  I would, however, greatly appreciate double-check of intel-power-gadget, since I can't actually install it on my machine.  I believe it's :gratis but a second eye from someone who can even install it would be nice.

Seems like you’re correct regarding intel-power-gadget. Also can’t install on my machine, though.
Calling on @ahbeng, @brendanjerwin, and @halilim for confirmation.

Seems :gratis to me: https://gist.github.com/halilim/c319e12d5ff3e1e0786b (copied from the install dialog) :+1:

Thanks @halilim!

Excellent, thanks.


Release 1.0.0 rc.3

Pull Request Test Coverage Report for Build 677290124

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 79.186%

Totals

Change from base Build 677211386:
0.0%

Covered Lines:
547

Relevant Lines:
656

💛  - Coveralls


config.fish being reloaded at random times

To test, add this to config.fish:
echo "reloading"
and open a new shell and cd to a git repo, press Enter many times, the shell will output reloading seemingly randomly.
This is causing an issue for me with another plugin (adambrenecki/virtualfish#98).
Tested on OS X El Capitan.

If you add to config.fish:
echo "reloading" %self

you will see that config of current shell is not reloaded. First "reloading" message created by current shell. And next messages created by child fish processes.
 Unfortunately there is no better ways to perform asynchronous tasks in fish.
The only solution I can propose is to make asynchronous updates optional. In synchronous mode there will be no child fish processes but prompt will render much slower.

Also you can just suppress stderr output like this
eval (python -m virtualfish auto_activation compat_aliases projects ^ /dev/null)

or stderr and stdout output like this
eval (python -m virtualfish auto_activation compat_aliases projects > /dev/null ^&1)

Is it possible to set a variable/flag in the child process that's running? This way I can wrap my config.fish file in an if condition and only run it if that variable is not set.

It is possible, but I am not sure it'll help.
I believe fish executes config.fish at the very beginning of lifecycle. It
may be executed before flag is set.
Anyway, lets try. I'll give you updated version shortly.
On Чт, 4 авг. 2016 г. at 10:16, Mohamed Akram<EMAIL_ADDRESS>wrote:

Is it possible to set a variable/flag in the child process that's running?
This way I can wrap my config.fish file in an if condition and only run it
if that variable is not set.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/vkovtash/pure/issues/3#issuecomment-237472419, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABNXMdSHpdQw64HB2i_FrmO1tnJttitOks5qcZHDgaJpZM4JbxE0
.

Checkout that branch https://github.com/vkovtash/pure/tree/feature/PURE-3.
PURE_ASYNC_TASK variable is set for all child fish instances created by pure prompt.

That works great, thanks!


Querying root node returns an incorrect type name

Current behavior
When querying against the root node type, the __typename of the result is different from the actual type of the node. I'm also unable to query type-specific fields of node by creating a fragment for a specific type - I get no results.
Reproduction
I copied over my SDL to a new project and reproduced the error there as well.

GraphQLBin link to show incorrect queries: https://graphqlbin.com/v2/Xo6Esn
Repo with SDL : https://github.com/kgoggin/prisma-node-bug

Also worth noting I initially encountered the error while working with a local PostgreSQL DB, so it doesn't seem tied to local vs. remote or MySQL vs. Postgres.
Expected behavior?
Querying the node with an Id should return the associated node with the correct type name. Should be able to query node with inline fragments for expected type and get a result.

Thanks reporting this. I can reproduce it and am looking into this

The fix is available in stable now.