🐛 Bug: Empty input message is sent when pressing "Enter"

♻ Reproduction Steps

Add the <CopilotChat> React UI component.
On the browser, press Enter without an input message.
Get the following response:❌ An error occurred. Please try again.

✅ Expected Behavior
When input is empty both send button and keyboard events (Enter) must be disabled.
❌ Actual Behavior
Enter key-down event always triggers the send() function, even when the send button is disabled. https://github.com/CopilotKit/CopilotKit/blob/75ee220546841fbc183aa5d1c0438621d6d88fc6/CopilotKit/packages/react-ui/src/components/chat/Input.tsx#L64-L69
𝌚 CopilotKit Version
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>
📄 Logs (Optional)
Error getting response: [Error: 400 Message content must be non-empty.]

@quest-bot embark

can i solve this issue

@eliaskoromilas @NathanTarbert would love to work on this

i have pushed some modified code is it correct ?

@eliaskoromilas, which example or demo are you using to reproduce the error?
I'm not getting an error if the message is empty and I press submit.

It appears when using the OpenAI Assistant adapter.

Ok, thanks for the additional context.
Have you tested any other adapters?

@eliaskoromilas Thanks for reporting this behavior. I wasn't exactly get the repro. I get appropriate response from LLM if i submit empty response.

Are you suggesting we don't submit empty response all together?
@mme what do you think of this? I think its reasonable to have prevent empty messages.

I also see no error when using OpenAIAdapter but in any case this behavior is not consistent with the send button.
https://github.com/CopilotKit/CopilotKit/blob/75ee220546841fbc183aa5d1c0438621d6d88fc6/CopilotKit/packages/react-ui/src/components/chat/Input.tsx#L83


build(logs): remove console logs from prod builds

This PR resolves []
Description
Removes console logs from production builds. We keep the console.errors for sentry though - might need to revisit if we use for sentry console.log instead of console.error in some places. Will probably do it on a follow up commit in the same PR.
We expect to see really minor performance improvements from this one but not sure how to measure it.
It's an industry standard though so we should do this.

PR Checklist

[x] I have tested my changes on iOS and Android.
[x] I hid my changes behind a feature flag, or they don't need one.
[x] I have included screenshots or videos, or I have not changed the UI.
[x] I have added tests, or my changes don't require any.
[x] I added an app state migration, or my changes do not require one.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

remove console logs from prod builds - gkartalis

Need help with something? Have a look at our docs, or get in touch with us.

This PR contains the following changes:

Dev changes (remove console logs from prod builds - gkartalis)

  Generated by :no_entry_sign: dangerJS against e6b4ed187cc06fce221b7f805d67468336e5f469


Install TagBot as a GitHub Action

You're receiving this pull request because the now-deprecated Julia TagBot GitHub App is installed for this repository. This pull request installs TagBot as a GitHub Action.
If this PR does not belong in this repository for any reason, feel free to close it.
See this Discourse thread for more details and to ask questions.
Please do not comment on this pull request, because it is unlikely that I (@christopher-dG) will see it.

Codecov Report

Merging #7 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #7   +/-   ##
=======================================
  Coverage   83.48%   83.48%
=======================================
  Files           5        5
  Lines         430      430
=======================================
  Hits          359      359
  Misses         71       71

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 215e05d...d703190. Read the comment docs.


Roll Flutter Engine from 59acb5362098 to 3b60e3c3b2f1 (1 revision)

https://github.com/flutter/engine/compare/59acb5362098...3b60e3c3b2f1
2023-03-23<EMAIL_ADDRESS>Roll Skia from fc95eca74604 to 6ce91944f834 (1 revision) (flutter/engine#40560)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Fix code scanning alert - SQL query built from user-controlled sources

Tracking issue for:

[ ] https://github.com/Flask-Tenants/flask-tenants/security/code-scanning/1

Fixed in Leviticus release


ZeroDivisionError: division by zero

I followed your instruction and trained the model again, but when i run it as a demo, it always shows such an error.

Traceback (most recent call last):
File "inference.py", line 192, in
generate_output(input_files, mode)
File "inference.py", line 162, in generate_output
image = run_inference(image_orig, model, sess, mode, sign_map)
File "inference.py", line 77, in run_inference
boxes = nms(y_pred_conf, y_pred_loc, prob)
File "E:\Masterarbeit\SSD_Project\model.py", line 248, in nms
iou = calc_iou(box[:4], other_box[:4])
File "E:\Masterarbeit\SSD_Project\data_prep.py", line 28, in calc_iou
iou = intersection / union
ZeroDivisionError: division by zero

@tony9378 ,
Have you figured out to this issue? I face the same problem with you. Everytime I finished training my network, I load the new model.ckpt and this error arose.

I think I have figured out why the error might be happening.
Can someone tell me the size of their data_prep_400x260.p.
Is it 514 MB? Or is it something less?

@YashBansod ,
My data_prep_400x260.p is 514MB (514,001,478 bytes to be precise)

The Div by Zero occurs for one of the two reasons (atleast the ones I have found):

If your data_prep_400x260.p is not made properly. (Verify that it is around 514 MB in size)
If you model was not trained for sufficient number of epochs (i.e. your model must have converged to a certain extent. Maybe value of some variable is very small ~= 0 at the time you ended your training).
To avoid the first problem, just redo the data prep process properly
To avoid the second from happening, change the learning rate to at least 0.01 (its set at 0.001 in the code) and train it for at least 20 Epochs. Your model won't converge much at this point but at least you won't get the Div by Zero Error.

Could you please tell me why my data_prep_400x260.p is 2.1GB? Besides, It will cost 900s or so to train one epoch(I have tried to set learning rate at 0.01). I'll appreciate it if you give some advice.

@YashBansod @sudonto My data_prep_400x260.p is 2.1GB, and the result after running inference.py is not good. I followed your steps to do run data_prep.py. Could you tell me why?

@sudonto @YashBansod  My data_prep_400x260.p is 2.1GB, and the result after running inference.py is not good. I have followed your steps to run data_prep.py. Could you tell me why?

@DRosemei there is something wrong that you are doing before executing data_prep.py.
Please follow the pre-processing instructions (all the steps before executing python data_prep.py ) and your data_prep_400x260.p should be around 514 MB.
Also, can you try plotting the cost function and see that it was at it's least when you ended your training. For me, it started to rise after certain epochs in one experiment.
Anyway, It has been a long time since I worked on this and the code is really not good if you plan to just use it for any sort of benchmarking. Try the original implementations for that.
Rather my purpose was for understanding an implementation of SSD in TF and this seemed to be more readable than other. The inference may not be optimal, as the model overfits the data.

@YashBansod My data_raw_400x260.p is 1.4M. But there was no "error" tip. What's wrong with my code?? PS : I downloaded the full dataset, and tackled it.

Sorry to reply late. Thank you for your reply. I have done pre-processing
instructions carefully for several times, but the size dosen't change. By
the way, my data_raw_400*260.p is 921.7kb. Is it right?
Besides, when I ran inference.py by restoring the model author gave, the
result is not good. Only a few boxes are right.
As for plotting the cost function, I'm sorry I just start learning DL, so I
can't help you.
If possible, would you mind sending me a copy of your code because I have
wasted a lot of time on it. Thank you again.
2018-04-09 19:39 GMT+08:00 Jasonsun1993<EMAIL_ADDRESS>
@YashBansod https://github.com/YashBansod My data_raw_400x260.p is
1.4M. But there was no "error" tip. What's wrong with my code?? PS : I
downloaded the full dataset, and tackled it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/georgesung/ssd_tensorflow_traffic_sign_detection/issues/23#issuecomment-379722882,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AambUjn_vnBEBV4MsaxlXtlEqEFYFh7wks5tm0iKgaJpZM4Q-nJR
.

Hi @DRosemei , @Jasonsun1993
The size of data_raw_400x260.p should be around 514MB. Please read  this. Particularly, please pay attention the answer from YashBansod dated 26 Feb.
@DRosemei , in my case, the model can correctly detect all the signs in the sample images.

@sudonto Thanks for your reply. I have already read #29, it saves me a lot of time. After running create_pickle.py, I got data_raw_400x260.p(921.7KB) and resized_images_400x260(2,600 items, totalling 139.0 MB). After running data_prep.py, I got data_prep_400x260.p (2.1GB). Could you please tell me where I made mistakes?
Besides, my detection on sample images is like this.

Thank you again.

@DRosemei , have you checked what the content of your mergedAnnotations.csv is? Can you confirm that only stop sign and pedestrian cross  is in that file?

@sudonto Thank for your reply. My mergedAnnotations.csv is the same as allAnnotations.csv, because as you said in #29, there  is a line of code that filters out the annotation tag other than the desired signs.But I find it in create_pickle.py, not in data_prep.py. Here is the code:
sign_name = fields[1]
if sign_name != 'stop' and sign_name != 'pedestrianCrossing':
continue  # ignore signs that are neither stop nor pedestrianCrossing signs
Besides, could you tell me how to make a mergedAnnotations.csv that only contains stop and pedestrian signs?

Ah, If those files are the same then this causes data_prep_400x260.p to have over 514M in size. You could create CSV file to have only the desired signs by deleting manually in Excel (sorting its column tag first then delete the rows) although the provided python file (the one that comes from the dataset) can do that.
Yes, I mistype the filename :)

@sudonto Thanks. Could you tell me the result after running create_pickle.py?  I got data_raw_400x260.p (921.7KB) and resized_images_400x260(2,600 items, totalling 139.0 MB). So I can check whether to recreate CSV file.
I also find that there are stop or pedestrain signs in other pictures like keepRight, but this may not be so important.
The problem that puzzles me a lot is that I can't get good results by using the restored model the author gave as I mentioned above.

I will re-run the project again. Will tell you the result later. So strange that the original model cannot predict the signs accurately.

The dependencies of the project https://github.com/georgesung/ssd_tensorflow_traffic_sign_detection#dependencies clearly state python3.5+.

@sudonto did you train the whole data set or extend this code to more traffic sign classes? If you did, please tell me about the results. Thx!

@YashBansod Thanks. I have noticed that before, so I make some changes to the code.Now I am going to install python 3.5 to solve the problem.

@sudonto My data_prep_400x260.p is 514M now. Thanks for your help. :)

Hi, @tony9378 @sudonto @YashBansod @DRosemei @Jasonsun1993
Have you all executed this program ? I just want to add a sentence into the file 'create_pickle.py' and it always always gets the error " IndentationError: unindent does not match any outer indentation level",  my data_raw_400x260.p is 0, and I don't know why .
If possible, would you mind telling me why or just sending me a copy of your code. My email address is<EMAIL_ADDRESS>Thank you.

@DRosemei How do you make the data_prep_400x260.p being 514M? I followed #29 , but failed.

@youthM I don’t know where exactly you fail. First, you should make sure your environment is the same as the author’s. I guess you may have trouble in “create_pickle.py”, you may find answers in #21


More flexible charts filter and option

Is your feature request related to a problem? Please describe.
1.I have some statistics that require time zone conditions, but the time conditions use the service time zone by default
2.When I switch the time granularity in the dashboard, I cannot reset Comparison Period Lag
Describe the solution you'd like
1.Add timezone option to Filter Box and Charts.
2.The Big Number with Trendline option Comparison Period Lag

timezone setting is highly requested lately and is something we are committed to implement in Q2-Q3. @amuluowin please help us by providing detailed use cases. thanks!

OK


add -Wformat-signedness when gcc > 5

Fixes #3478
Signed-off-by: okhowang(王沛文<EMAIL_ADDRESS>Notes:

Pull requests cannot be accepted until the PR follows the contributing guidelines. In particular, each commit must have at least one Signed-off-by: line from the committer to certify that the contribution is made under the terms of the Developer Certificate of Origin.
This is just a template, so feel free to use/remove the unnecessary things

Description
A few sentences describing the overall goals of the pull request's commits.
Status
READY
Requires Backporting
Yes
Migrations
NO
Additional comments
Todos

[ ] Tests
[ ] Documentation
[ ] Changelog updated
[ ] Backported

Steps to test or reproduce
Outline the steps to test or reproduce the PR here.

CI is only failing on Mbed OS.


Is it possible to restrict authorization scopes to provider tenant only?

Hi colleagues,
It's a consulting issue.
We developed some admin functions in SaaS service, and these admin functions are to be used by ourselves (should only be used in provider tenant and can't be accessed by customers). In case we don't want to split these functions to a separate service, is it possible to use xsuaa to authorize these functions to be used on provider tenant only? I tried and it seems scopes in xsuaa are always propagated to consumer tenant by saas registry service, thereby can't be hidden from customers.
Please let me know if any solution for above scenario. Thanks a lot!
Zhongjie

HI @frankfangcn
thanks for your request!

Which client lib do you make use of?
Your request seems to be similar to this one. Is that right?

Thanks and best regards,
Nena

@torsten-sap @kayuweschmidt
If you like, you can follow up on that feature request...

Hi @frankfangcn
so its like that, you have these two options:

In the admin endpoints check the call is for your paas xsuaa tenant
Hide the roles by defining the scopes in the subscribed xsuaa instance and the corresponding role template in another (not subscribed) xsuaa service instance.

Best regards,
Nena


Further limit draining faucet

Describe the feature you would like
I’d like a way to further limit draining of testnet faucet.
One idea is to require GitHub auth via Social Connect to further limit abuse.
Additional context
No response

Thanks for raising this @ericnakagawa 👍
I checked, the faucet address (0x22579CA45eE22E2E16dDF72D955D6cf4c767B0eF) is indeed low on tokens.

faucet.celo.org also display a message that the faucet is low on tokens:

Eric is hosting a hackathon this weekend and needs the faucet to be accessible to devs.

It looks like the current faucet balance is:

cREAL: ~0.8
cUSD: ~1.2
cEUR: ~824,264
CELO: ~0.3

Source: https://alfajores.celoscan.io/address/0x22579ca45ee22e2e16ddf72d955d6cf4c767b0ef

Checking how much the faucet distributes at the moment.
From here
https://github.com/celo-org/faucet/blob/c95522ef6f9f77a627d16ce0a769c2f8fbbe93cf/apps/firebase/src/database-helper.ts#L205-L222
we know it's the amounts set here
https://github.com/celo-org/faucet/blob/c95522ef6f9f77a627d16ce0a769c2f8fbbe93cf/apps/firebase/src/config.ts#L3-L12
Checking what the amounts are set to.
Following the setup instructions in readme.md:
$ cd apps/firebase
$ yarn dlx firebase-tools@latest logim
# ...
$ yarn install

From firebase/README.md, we get the config values with:
$ yarn cli config:get --net alfajores
{
  // ...
  "authenticated_stable_amount": "5000000000000000000",
  "authenticated_gold_amount": "5000000000000000000",
  "faucet_gold_amount": "500000000000000000",
  "faucet_stable_amount": "500000000000000000",
  // ...
}

Converting from wei to ethers
# authenticated
$ cast from-wei<PHONE_NUMBER>000000000 ether
5.000000000000000000

# not authenticated
$ cast from-wei<PHONE_NUMBER>00000000 ether
0.500000000000000000

Ideas to avoid faucet being empty:

lower unauthenticated amount even more,

Ideas to fill the faucet by the weekend:

wait for validator rewards to come in
convert a portion of ~824,264 cEUR into CELO
Eric to fill faucet with tokens he has

[ ] Confirm that faucet is getting replenished

The faucet is currently only getting replenished
$ celocli network:parameters --node alfajores
...
EpochRewards:
  carbonOffsetting:
    factor: 0.25
    partner: 0x22579CA45eE22E2E16dDF72D955D6cf4c767B0eF
...

Asked for help to make a short-term transfer to the faucet for the weekend hackathon.

This address 0x9803c7f37f26E3E4521f1d1B2a845Ae51e580aA0 seems to be getting 5 CELO from the faucet repeatedly.

Source:  https://alfajores.celoscan.io/address/0xb8c3475d736ab7c587b3fcf6a4e2d55136d4968f
It then seems to be sending them on to 0x90C68A26B792814e99Ac8E337F5b1BB47136F9FF

Source: https://alfajores.celoscan.io/address/0xb8c3475d736ab7c587b3fcf6a4e2d55136d4968f
That address 0x90C68A26B792814e99Ac8E337F5b1BB47136F9FF has a 11,190 CELO balance.

Source: https://alfajores.celoscan.io/address/0x90c68a26b792814e99ac8e337f5b1bb47136f9ff

The faucet balance has been drained by 100,000 CELO in 10 days. From Mar 19 to Mar 29, the balance dropped from 100,460 to near 0.

Source: https://explorer.celo.org/alfajores/address/0x22579CA45eE22E2E16dDF72D955D6cf4c767B0eF/coin-balances?block_number=23258880&items_count=50#address-tabs

It might be necessary to limit the amount of CELO that can be sent out, whether the user is authenticated or not.

The faucet seems to be funded by carbon offsetting rewards once per epoch (= day):

Source: https://explorer.celo.org/alfajores/block/23241600/epoch-transactions

The funding amount fluctuates with use, because carbon offset rewards depend on network usage. In recent days it's around ~900-1,000 CELO per day, but not sure what it looks like before:

Source: https://explorer.celo.org/alfajores/block/23241600/epoch-transactions

Source: https://explorer.celo.org/alfajores/block/23224320/epoch-transactions

Source: https://explorer.celo.org/alfajores/block/23207040/epoch-transactions

Other ideas to limit abuse:

Adjust the amount that is sent based on the recipient's balance (if CELO balance high, send less)
Check reCaptcha is required when user is Github authenticated (seems like a bot is making 5 CELO requests repeatedly)

The faucet used be funded every hour:

https://github.com/celo-org/faucet/pull/47

This address 0xb8c3475d736ab7c587b3fcf6a4e2d55136d4968f seems to be running an automated process.
Eric briefly funded the faucet with 25 CELO and the address above automatically started making 5 CELO requests until the faucet was empty:

Source: https://explorer.celo.org/alfajores/address/0x22579CA45eE22E2E16dDF72D955D6cf4c767B0eF

Hi @arthurgousset ! Thanks for the explanation.
Do we know what authentication method is the draining bot using?

This address 0xbabe97E806Ae3a153A94F2ee564cD8cCeA1Dc913 is also "attacking" the faucet and sending to the same address as above

Hi @arthurgousset ! Thanks for the explanation.
Do we know what authentication method is the draining bot using?

Yes, the bot is using a Github authenticated account to request 5 CELO instead of 0.5 for unauthenticated accounts.
But, more importantly, we have a mechanism in place that doesn't fund any address that has more than 20 CELO. But, there was a bug that prevented that from working.
It's fixed here:

https://github.com/celo-org/faucet/pull/167

Whenever the bot's balance is above 20, the faucet doesn't send tokens as expected 👍
Here 0xbabe97E806Ae3a153A94F2ee564cD8cCeA1Dc913 has 21.25 CELO. So requests stop until the bot sends CELO away and the balance drops below 20.

Source: https://explorer.celo.org/alfajores/address/0xbabe97E806Ae3a153A94F2ee564cD8cCeA1Dc913/coin-balances#address-tabs

0xbabe97E806Ae3a153A94F2ee564cD8cCeA1Dc913 is sending tokens to 0x6FF76397c1d9aAFD63DFdB63C0C701d061d3d822, which currently has a balance of 10,828 CELO

Source: https://explorer.celo.org/alfajores/address/0x6FF76397c1d9aAFD63DFdB63C0C701d061d3d822/transactions#address-tabs

Source: https://explorer.celo.org/alfajores/address/0x6FF76397c1d9aAFD63DFdB63C0C701d061d3d822/token-transfers#address-tabs

(for future reference)
Javi topped the faucet up with 50,000 CELO

We also sent @ericnakagawa 50,000 CELO as a short-term fix for the weekend. That way he can top up the faucet independently, if he has a short-term need, and the faucet is still affected by the abuse.

I'm closing this issue as it pertains to the hackathon weekend.
I'll open a new issue and PR for longer-term changes to prevent abuse.


typo: fix typo randondb to radondb #266

What type of PR is this?

Which issue(s) this PR fixes?

Fixes #
What this PR does?
Summary:
Special notes for your reviewer?

LGTM


Generate and provide an SSH config file to shell script being run

Currently, shell scripts being invoked have no way of finding what machine is being provisioned, or what are the connection informations to use. Trying to invoke vagrant ssh-config in the inline script is not possible because Vagrant locks the machine.
This commit generates an "ssh-config" file (similar to the ssh-config target) as a temporary file and provides the path to it in the VAGRANT_SSH_CONFIGFILE environment variable.

@phinze Are you still active on the project? We really need this feature :) Really help us bypassing Vagrant locking mechanism while resolving vm ips dynamically.


fix(trino): Disallow alias to source column

SUMMARY
The Presto connector has allows_alias_to_source_column = False which was not replicated in the Trino connector. This is required to resolve issues when the same column name is used in both the inputs and outputs, i.e.,
SELECT
    foo
FROM
    ...
GROUP BY
    foo
ORDER BY
    MAX(foo)

as it isn't evident which foo the MAX(foo) is referring to. This results in the Trino error,
Invalid reference to output projection attribute from ORDER BY aggregation

TESTING INSTRUCTIONS
CI and tested locally.
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

This will be reverted in https://git.musta.ch/airbnb/superset-internal/pull/1713 which contains the identical change from Apache Superset via a cherry-pick.


Get proxy URL for request

I'd like to know which proxy URL was used with which request so that on errors I can automatically remove proxies that return repeated errors or timeouts. Ideally it would be a property, like Request.ProxyURL. It doesn't look like there's any way to do that currently, though.
I'm happy to contribute a PR, but I'm not seeing an obvious way to get at that except by keeping a map[string]string ledger which is less than ideal. Thoughts?

@matthew-noken yes, this is definitely a valid use-case and currently it isn't possible to retrieve the proxy URL in callbacks.
I'd extend the Request struct with a Proxy() string member function, because Request is accessible from all the callbacks. What do you think?

I think that's good, but I'm trying to figure out how to get at the proxy URL for a particular request.
The call flow looks like this:

User passes a ProxyFunc (such as the return value of proxy.RoundRobinProxySwitcher()) to colly.Collector.SetProxyFunc()
colly.Collector.SetProxyFunc() assigns ProxyFunc to http.Transport.Proxy
http.Transport.RoundTrip() calls http.Transport.connectMethodForRequest()
http.Transport.connectMethodForRequest() calls http.Transport.Proxy() (our ProxyFunc).

The return value of connectMethodForRequest(), though—the proxy URL itself—is ephemeral. It lives and dies in http.Transport.RoundTrip().
Ultimately the proxy URL used needs to be assigned to a Request somewhere, so the question is where? As I see it, because the request is passed to the ProxyFunc, the best option is to embed http.Request in colly.Request and pass it to http.Client directly. Add a ProxyURL property. Modify proxy.roundRobinSwitcher.GetProxy to set colly.Request.ProxyURL (and change the name to something like SelectProxyURL, since it has side effects). This can retain public interface backwards compatibility.
I can create a PR if this sounds good.

@matthew-noken you are right, this solution seems valid to me. I'd appreciate a PR. Thanks!

(I've been super busy, but I do still plan to do this in the next 2-3 weeks.)

Well it seems like possible too, but even less obvious. I've decided to go with extending of http.Transport wrapping the RoundTrip() method and customising Proxy func property. It is totally transparent solution and can be used with any http.Client..

Sorry to hijack , what if the proxy is not responsive, does it skip the job or try another proxy on the list

@rainbowhat That call times out.
I still haven't had any time to do this yet, unfortunately.

@matthew-noken ok, noted with thanks!

@matthew-noken pls submit this PR.. thanks

Merged #222 but leaving this open until we can support all ProxyFuncs by capturing the proxy in the http client as mentioned earlier https://github.com/gocolly/colly/issues/110#issuecomment-371517557

I think you should close the issue, because it is done in https://github.com/gocolly/colly/blob/master/request.go#L52

Apologies for being unable to complete this. We never did end up prioritizing this for development, despite wanting to make time. I'm glad that someone else was able to finish it.
Given that this satisfies the original use case I described (accessing the proxy URL in OnError, then handling as appropriate), I agree with @mazhigali. I'm closing the ticket. If you'd like to support deeper functionality, I think it would be best to create a new one that's more targeted to the specific need.

I think you should close the issue, because it is done in https://github.com/gocolly/colly/blob/master/request.go#L52

I am trying to use this. But requests do not go through a proxy
c.OnRequest(func(r *colly.Request) {         r.ProxyURL = rand_proxy })


localazation schema does not reference the languageTag field

Shouldn't this be a required field? It is in the example provided by @akinolugbade

It is not required since the manifest file tells us the language tag -> language file


[FAB-17529] Reduce and clarify errors in pkg/config

Signed-off-by: Tiffany Harris<EMAIL_ADDRESS>Type of change

Improvement (improvement to code, performance, etc)

Description
This change focuses on removing/rewording overly descriptive error messages
Related issues
FAB-17529

Agreed - there is a follow up work to rename profile to something more appropriate.


Remove redundant code from all the custom Exception classes

We're setting Detail to ProblemDetail object twice which is redundant.
ProblemDetail problemDetail = ProblemDetail.forStatusAndDetail(HttpStatus.BAD_REQUEST, message);
and
problemDetail.setDetail(message);
Either use ProblemDetail.forStatus(HttpStatus.BAD_REQUEST) or remove problemDetail.setDetail(message)

PR merged
https://github.com/kdhrubo/db2rest/pull/125


sched: sched: Remove sched_tasklistlock.c for SMP

Summary

sched_tasklistlock.c was introduced to stabilize NuttX SMP
However, the current SMP implementation is stable by recent fixes
So I decided to remove the file finally

Impact

SMP only

Testing

Tested with ostest with the following configurations
spresense:smp
spresense:wifi_smp (NCPUS=2 and 4)
sabre-6quad:smp (QEMU)
esp32-core:smp (QEMU)
maix-bit:smp (QEMU)
sim:smp
lc823450-xgevk:rndis

@xiaoxiang781216 @patacongo
At last I removed the file.


Feature/provision list

Q
A

Bug fix?
no

New feature?
yes

New sample?
no

What's in this Pull Request?
This change to the React Basic Todo sample adds a Property Pane Button which only appears if there are not Task lists found when the web part onInit fires. Clicking this button creates a new task list and refreshes the Property Pane.

Hi @gavinbarron, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

Thx Gavin, we'll process this during upcoming days.

thx Gavin for this. We do appreciate this submission and it does provide value for the example in certain scenarios. There's however one fundamental issue with this, which is that it requires high permissions for the end users to be able to execute the code for the site. I think you and Chaks had a discussion around this during Redmond SP user group event and agreed on this conclusion as well.
Technically your code is nice extension for showing additional capabilities and it would be fine in the context of other samples in the repository, but we want to keep this particular sample as clean and based on recommendations as possible, so will decline this submission.
We are working on updated guidance and article around the different options to provision site assets as part of the web part deployment / execution. We'll certainly call this option out as well, but also it's caveats. There are also other options, which do not require permissions - but each of them have advantages and disadvantages.
thx for your submission and looking forward on additional ones.


[Support request]: Yabai not tiling windows properly after update to ver 3

Yabai is making single windows take up the full screen fine, but opening new windows via skhd seems to have broken some time after updating to version 3. The second windows are opening either in the top quarter (with blank space below), or bottom quarter (blank above), or sometimes in the middle of the screen. Openign a 3rd window puts it in the blank quarter, but off-center. Running yabai -m space --balance with 2 windows will sometimes mode the quartered window to the center the first time, then to full half-screen the second time.
Sometimes the second window opens fine, but when I open a 3rd, the second window moves to quarter correctly, but the 3rd window opens in the same quarter, again misaligned.
This even happens if I restart with no yabairc. Persisting across restarts.
Downgrading back to 2.4.3 also hasn't helped.
Are there some caches I could look at clearing to help reinstall?

New self-signed certificate used to sign the released binaries because the previous one expired at april 21th, 2020. You will have to re-enable accessibility permissions after this install. Sorry about that.

I had to change the certificate for the 3.x.x release so you probably got hit by some accessibility nonsense. Try to first stop the yabai service, uninstall, then remove the yabai entry from the accessibility list. Do a system reboot, install yabai, and accept the accessibility permission followed by an application restart.

I got prompted by accessibility when I updated, and gave it permission again. And occasionally yabai does work as intended, for one window. Yabai definitely can move windows around. And I get the notification that the scriping addon loads properly.

Yes, it should still help. The issues you describe sound very much like an inconsistency with the accessibility permission where the system sometimes think you have access, and sometimes it thinks you don't. I don't exactly know the details of why it happens, but I did experience these symptoms a long time ago when I first started doing these things.

Closing this. My previous comment should resolve the issue for you.

I hadn't gotten around to restarting, but I just went through the steps you gave. Still happening, but I noticed the scripting addon gave a warning about an out-of-date payload. Small and easy thing to miss, might be worth making more obvious/documenting somewhere, or even prompting to auto-reinstall. I'm going to reinstall the scripting addon now and see if it fixes it

Nope, didn't work, even after multiple restarts and no yabairc. Is there anything else I can clear?

Spamming balance eventually gets the spacing right, btw, but almost always takes more than one balance (if that helps you identify possible causes)

I have no clue. There has not been any changes related to how tiling is performed in a long time.

On 24 May 2020, at 01:41, BlueDrink9<EMAIL_ADDRESS>wrote:
Spamming balance eventually gets the spacing right, btw, but almost always takes more than one balance (if that helps you identify possible causes)
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub https://github.com/koekeishiya/yabai/issues/524#issuecomment-633154635, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPDZVY3XEFGVYQ2VFYTM2DRTBNMFANCNFSM4NCUARMQ.

I'm not suggesting it's a bug, but does Yabai store any other settings/data that I could remove?

There shouldn’t be, no. Accessibility access and the config file is pretty much everything. There are lock files and socket files in /tmp/yabai_.socket/lock, but that does not seem relevant to your issue.

On 24 May 2020, at 02:31, BlueDrink9<EMAIL_ADDRESS>wrote:
I'm not suggesting it's a bug, but does Yabai store any other settings/data that I could remove?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub https://github.com/koekeishiya/yabai/issues/524#issuecomment-633159136, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPDZV4J5YZOFPKRHAOJRBTRTBTHTANCNFSM4NCUARMQ.

Bother. Maybe I'll try on a different user and see if it's a software conflict. I'm on Mojave atm.

On a new user with no rc, kitty seemed to tile fine, but finder, chrome don't tile well at all.

Seems to be working fine again after uninstalling and re-installing the scripting addition, updating catalina, zapping the PRAM, and running manually instead of as a brew service. No idea which part fixed it. However, the scripting addition isn't loading, but I definitely ran csrutil enable --without debug --without fs in recovery mode. Currently, (and immediately after that command) csrutil status returns enabled, but I assume that's the expected behaviour for OSX 10.14 and above?

Although now windows are tiling veery slowly (iterating size and position about once every 0.5 seconds). Any thoughts on what might be causing that?

Is this on v3.1.1 or the master branch? If so, likely fixes to #16 … god damnit

On 9 Jun 2020, at 00:34, BlueDrink9<EMAIL_ADDRESS>wrote:
Although now windows are tiling veery slowly (iterating size and position about once every 0.5 seconds). Any thoughts on what might be causing that?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub https://github.com/koekeishiya/yabai/issues/524#issuecomment-640922830, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPDZVZDT6YWMQLSHSQZT6LRVVRQ5ANCNFSM4NCUARMQ.

3.1.1

Try the latest version please. I undid the changes to #16. Hoping that was the issue, otherwise I am running empty on ideas.

On 9 Jun 2020, at 01:02, BlueDrink9<EMAIL_ADDRESS>wrote:
3.1.1
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub https://github.com/koekeishiya/yabai/issues/524#issuecomment-640931611, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPDZV2HQ4W3MUWAE3WJZK3RVVUZ5ANCNFSM4NCUARMQ.

Yup, back to normal speed. Thank you for your help and work!
All of this stopping and restarting yabai has narrowed it down as a factor in a more serious issue I have been having (since version 3.10). Switching to new windows sometimes crashes windowserver (manifesting as a black screen, then the login screen shows). Focussing the system preferences window for the first time as it opens seems to be a factor, but if it is opened without yabai running then switched to once yabai has started, it seems to be fine.
I'll test with a minimal rc and see if it keeps happening.

Update: 3.1.12 seems to have reverted my issue with windows not tiling properly.

The crash is likely #277
You need to set window_opacity_duration to 0 (macOS Catalina bug, nothing I can do to fix it).
I find it weird that going from 3.1.1 to 3.1.2 make things not tile properly. All I changed was remove a potential bug that could result in looped movement/resize.
Do you have this issue for specific applications or all of them? What about Terminal.app or Safari? (both of these work perfectly for me).
Sent from my iPhone
On 9 Jun 2020, at 01:35, BlueDrink9<EMAIL_ADDRESS>wrote:

Update: 3.1.12 seems to have reverted my issue with windows not tiling properly.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHubhttps://github.com/koekeishiya/yabai/issues/524#issuecomment-640941853, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABPDZVZNGEC3IEJ64KM6SELRVVYTJANCNFSM4NCUARMQ.

Maybe 3.1.1 didn't fix the bug, but it seemed to for the brief period of time I used it.
Thanks for pointing out 277. For some reason googling "yabai" + "crash" or "black screen" or "windowserver crash" didn't bring it up.
I've been testing with finder, chrome and kitty. I'll test with terminal and safari.

Safari and terminal were both fine. I wonder if it has to do with finder, chrome and kitty all being started by skhd (which in turn was started by yabai)

I got fed up with this again so went on a deep dive fixing things. New user with most things copied = worked. My user with ~/Library renamed = worked.
I think now it is finally fixed, thanks to deleting a bunch of folders in ~/Library/application support/com.apple.*, mostly to do with accessibility (I think com.apple.TCC was the main one). Complete list:
com.apple.CommerceKit.AskPermissionExtension
com.apple.cloudphotosd
com.apple.CloudPhotosConfiguration
com.apple.CloudDocsDaemon.StorageManagement
com.apple.CloudDocs.MobileDocumentsFileProvider
com.apple.ClassKit.diagnosticextension
com.apple.calculator
com.apple.BKAgentService
com.apple.AuthKitUI.AKFollowUpServerUIExtension
com.apple.AuthKitUI.AKAppSSOExtension
com.apple.archiveutility
com.apple.AquaAppearanceHelper
com.apple.AppStoreDaemon.ASDAskPermissionExtension
com.apple.AppSSOKerberos.KerberosExtension
com.apple.AppleMediaServicesUI.SpyglassPurchases
com.apple.AppleMediaServices.FollowUpExtension
com.apple.appkit.xpc.LegacyExternalColorPickerService
com.apple.appkit.xpc.ColorSampler
com.apple.AMPDeviceDiscoveryAgent
com.apple.AMPArtworkAgent
com.apple.amp.devicesui
com.apple.AmbientDisplayAgent
com.apple.AirPlayUIAgent
com.apple.AddressBook.UrlForwarder
com.apple.AddressBook.ContactsAccountsService
com.apple.AddressBook.ABPersonViewService
com.apple.AddressBook
com.apple.accessibility.mediaaccessibilityd
com.apple.accessibility.heard
com.apple..NowPlayingWidgetContainer.NowPlayingWidget
com.apple..NowPlayingWidgetContainer
com.apple.AMPLibraryAgent
com.apple.backgroundtaskmanagementagent
com.apple.TCC

Happened again after a recent restart. Just removing com.apple.TCC and logging out didn't fix it, but removing com.apple.* and logging out did.

I have identified the cause of this as a clash with a Hammerspoon script.
Removing the above files affected hammerspoon being set or not set to auto-open on login.
Running with just hammerspoon was fine, but when loading dbalatero/VimMode.spoon and reloading the config, this issue occurs again.
I have opened https://github.com/dbalatero/VimMode.spoon/issues/45 to hopefully shed some light on this.


FFmpegWrapper error during long registration

Hi, I am using sdk in my project and I am experiencing an error. I initially thought it was something related to the modifications I made to the sdk, so i tested your example app, but the problem still persists.
The problem is that the index*.ts file stops being written and is not uploaded until the stop recording button is pressed.
To reproduce the bug leave the device recording for at least 40 minutes.
This is the resulting logcat (from Sony SGP611 on 5.0.2, I have another Logcat from Galaxy Camera 2 EK-GC200 with 4.3)
06-17 15:31:58.632  17126-17208/io.kickflip.sample E/FFmpegWrapper﹕ av_interleaved_write_frame video: 0 pkt: 64440 size: 565 error: Invalid argument
06-17 15:31:58.655  17126-17208/io.kickflip.sample E/FFmpegWrapper﹕ av_interleaved_write_frame video: 1 pkt: 64441 size: 25775 error: Invalid argument
06-17 15:31:58.668  17126-17208/io.kickflip.sample E/FFmpegWrapper﹕ av_interleaved_write_frame video: 0 pkt: 64441 size: 564 error: Invalid argument
06-17 15:31:58.691  17126-17208/io.kickflip.sample E/FFmpegWrapper﹕ av_interleaved_write_frame video: 1 pkt: 64442 size: 9889 error: Invalid argument
06-17 15:31:58.693  17126-17126/io.kickflip.sample I/MicrophoneEncoder﹕ stopRecording
06-17 15:31:58.693  17126-17126/io.kickflip.sample I/CameraEncoder﹕ stopRecording
06-17 15:31:58.705  17126-17223/io.kickflip.sample I/MicrophoneEncoder﹕ Exiting audio encode loop. Draining Audio Encoder
06-17 15:31:58.725  17126-17208/io.kickflip.sample E/FFmpegWrapper﹕ av_interleaved_write_frame video: 1 pkt: 64443 size: 9106 error: Invalid argument
06-17 15:31:58.737  17126-17217/io.kickflip.sample I/CameraEncoder﹕ Sending last video frame. Draining encoder
06-17 15:31:58.753  17126-17208/io.kickflip.sample I/FFmpegMuxer﹕ Forcing Shutdown
06-17 15:31:58.753  17126-17208/io.kickflip.sample I/FFmpegWrapper﹕ finalizeAVFormatContext
06-17 15:31:58.753  17126-17228/io.kickflip.sample D/HlsFileObserver﹕ Event 8 at index214.ts ext ts
06-17 15:31:58.754  17126-17228/io.kickflip.sample I/S3Manager﹕ Queueing upload ies_test/jo2lta8i5u6q/ad8145c8-0114-40d4-8e01-3029c65cd6cd/index214.ts
06-17 15:31:58.755  17126-17228/io.kickflip.sample D/HlsFileObserver﹕ Event 8 at index.m3u8.tmp ext tmp
06-17 15:31:58.755  17126-17228/io.kickflip.sample D/HlsFileObserver﹕ Event 128 at index.m3u8 ext m3u8
06-17 15:31:58.764  17126-17228/io.kickflip.sample I/MainActivity﹕ onBroadcastStop
06-17 15:31:58.766  17126-17126/io.kickflip.sample I/CameraEncoder﹕ onHostActivityPaused
06-17 15:31:58.767  17126-17228/io.kickflip.sample I/S3Manager﹕ Queueing upload ies_test/jo2lta8i5u6q/ad8145c8-0114-40d4-8e01-3029c65cd6cd/index.m3u8
06-17 15:31:58.778  17126-17228/io.kickflip.sample I/S3Manager﹕ Queueing upload ies_test/jo2lta8i5u6q/ad8145c8-0114-40d4-8e01-3029c65cd6cd/vod.m3u8
06-17 15:31:58.863  17126-17223/io.kickflip.sample W/FFmpegMuxer﹕ Dropping frame because Muxer not ready!
06-17 15:31:58.863  17126-17223/io.kickflip.sample W/FFmpegMuxer﹕ Dropping frame because Muxer not ready!
06-17 15:31:58.864  17126-17223/io.kickflip.sample W/FFmpegMuxer﹕ Dropping frame because Muxer not ready!
06-17 15:31:59.010  17126-17126/io.kickflip.sample I/StreamListFragment﹕ Loading more streams
06-17 15:31:59.102  17126-17126/io.kickflip.sample I/Timeline﹕ Timeline: Activity_idle id: android.os.BinderProxy@3ef42551 time:14529623
06-17 15:31:59.115  17126-17217/io.kickflip.sample I/CameraEncoder﹕ handleRelease
06-17 15:31:59.115  17126-17217/io.kickflip.sample D/Texture2dProgram﹕ deleting program 45
06-17 15:32:00.160  17126-17126/io.kickflip.sample I/API﹕ request succeeded io.kickflip.sdk.api.json.StreamList@3d6fb1f2
06-17 15:32:00.239  17126-17126/io.kickflip.sample I/StreamListFragment﹕ Loading more streams
06-17 15:32:00.645  17126-17126/io.kickflip.sample I/API﹕ request succeeded io.kickflip.sdk.api.json.StreamList@3e788e87
06-17 15:32:00.713  17126-17126/io.kickflip.sample I/StreamListFragment﹕ Loading more streams
06-17 15:32:01.458  17126-17126/io.kickflip.sample I/API﹕ request failed A Kickflip server error occurred
06-17 15:32:02.690  17126-17500/io.kickflip.sample I/S3Manager﹕ Uploaded 2289.276 KB in 3930ms (582.512 KBps)
06-17 15:32:02.701  17126-17498/io.kickflip.sample I/S3Manager﹕ Upload complete.
06-17 15:32:02.883  17126-17500/io.kickflip.sample I/S3Manager﹕ Uploaded 0.244 KB in 178ms (1.37 KBps)
06-17 15:32:02.885  17126-17500/io.kickflip.sample I/MainActivity﹕ onBroadcastLive @ https://kickflip.io/ad8145c8-0114-40d4-8e01-3029c65cd6cd
06-17 15:32:02.887  17126-17498/io.kickflip.sample I/S3Manager﹕ Upload complete.
06-17 15:32:03.084  17126-17500/io.kickflip.sample I/S3Manager﹕ Uploaded 6.582 KB in 194ms (33.927 KBps)
06-17 15:32:03.096  17126-17498/io.kickflip.sample I/S3Manager﹕ Last Upload complete.
06-17 15:32:03.096  17126-17498/io.kickflip.sample I/S3Manager﹕ Shutting down
06-17 15:34:11.020  17126-17136/io.kickflip.sample I/art﹕ Debugger is no longer active
06-17 15:35:22.067  17126-17126/io.kickflip.sample I/StreamListFragment﹕ Loading more streams
06-17 15:35:23.288  17126-17136/io.kickflip.sample W/art﹕ Suspending all threads took: 6.570ms
06-17 15:35:23.340  17126-17126/io.kickflip.sample I/API﹕ request succeeded io.kickflip.sdk.api.json.StreamList@c9cf43
06-17 15:35:23.417  17126-17126/io.kickflip.sample I/StreamListFragment﹕ Loading more streams
06-17 15:35:23.427  17126-17126/io.kickflip.sample I/Timeline﹕ Timeline: Activity_idle id: android.os.BinderProxy@3ef42551 time:14733948
06-17 15:35:23.802  17126-17126/io.kickflip.sample I/API﹕ request succeeded io.kickflip.sdk.api.json.StreamList@156193aa
06-17 15:35:23.873  17126-17126/io.kickflip.sample I/StreamListFragment﹕ Loading more streams
06-17 15:35:23.889  17126-17126/io.kickflip.sample I/Muxer﹕ Created muxer for output: /storage/emulated/0/MySampleApp/107335b8-cd8b-4e79-b06e-4078dc43b2b3/index.m3u8
06-17 15:35:23.897  17126-17126/io.kickflip.sample I/Timeline﹕ Timeline: Activity_launch_request id:io.kickflip.sample time:14734418
06-17 15:35:24.001  17126-17126/io.kickflip.sample I/BroadcastFragment﹕ Recreating BroadcastFragment
06-17 15:35:24.013  17126-13298/io.kickflip.sample I/OMXClient﹕ Using client-side OMX mux.
06-17 15:35:24.031  17126-13298/io.kickflip.sample E/OMXMaster﹕ A component of name 'OMX.qcom.audio.decoder.aac' already exists, ignoring this one.
06-17 15:35:24.035  17126-13298/io.kickflip.sample D/MediaCodec﹕ MediaCodec[kWhatConfigure]: video-output-protection: 00000000, audio-output-protection: 00000000
06-17 15:35:24.054  17126-17126/io.kickflip.sample I/Kickflip﹕ Clearing SessionConfig
06-17 15:35:24.067  17126-17126/io.kickflip.sample W/CameraRelease﹕ Didn't try to open camera onHAResume. rec: false mSurfaceTexture ready?  no
06-17 15:35:24.188  17126-13307/io.kickflip.sample D/CameraSurfaceRenderer﹕ onSurfaceCreated
06-17 15:35:24.193  17126-13307/io.kickflip.sample D/Texture2dProgram﹕ Created program 3 (TEXTURE_EXT)
06-17 15:35:24.197  17126-13307/io.kickflip.sample D/Texture2dProgram﹕ Created program 6 (TEXTURE_2D)
06-17 15:35:24.199  17126-13307/io.kickflip.sample D/CameraSurfaceRenderer﹕ onSurfaceChanged 1920x1200
06-17 15:35:24.199  17126-13307/io.kickflip.sample I/CameraSurfaceRenderer﹕ setTexSize on display Texture
06-17 15:35:24.203  17126-13325/io.kickflip.sample I/OMXClient﹕ Using client-side OMX mux.
06-17 15:35:24.229  17126-17126/io.kickflip.sample I/API﹕ request failed A Kickflip server error occurred
06-17 15:35:24.248  17126-17126/io.kickflip.sample I/Timeline﹕ Timeline: Activity_idle id: android.os.BinderProxy@33c013e5 time:14734769
06-17 15:35:24.290  17126-13324/io.kickflip.sample D/MediaCodec﹕ MediaCodec[kWhatConfigure]: video-output-protection: 00000000, audio-output-protection: 00000000
06-17 15:35:24.292  17126-13325/io.kickflip.sample E/ACodec﹕ [OMX.qcom.video.encoder.avc] storeMetaDataInBuffers (output) failed w/ err -2147483648
06-17 15:35:24.293  17126-13325/io.kickflip.sample W/ACodec﹕ do not know color format 0x7fa30c04 =<PHONE_NUMBER>
06-17 15:35:24.293  17126-13325/io.kickflip.sample W/ACodec﹕ do not know color format 0x7f000789 =<PHONE_NUMBER>
06-17 15:35:24.301  17126-13325/io.kickflip.sample I/ACodec﹕ [OMX.qcom.video.encoder.avc] setupVideoEncoder succeeded
06-17 15:35:24.302  17126-13325/io.kickflip.sample W/ACodec﹕ do not know color format 0x7f000789 =<PHONE_NUMBER>
06-17 15:35:24.303  17126-13325/io.kickflip.sample D/ACodec﹕ Found video-output-protection flags set to 00000000

This always happened during writing of index214.ts (approximately 1.5 GB of data written), on Sony SGP611 5.0.2, Galaxy Camera 2 EK-GC200 with 4.3 and HTC ONE M7 5.0.2.
Hope this is enough, I can provide more info on different devices if you need, just tell me.
Keep up the good work.
P.S. I removed most of the FFmpegWrapper because they added nothing useful and made the logcat less readable.

Just a small update, I have made more tests and can now exclude that the size of the data written (1.5GB) or the number of .ts files are the culprit; all registration stopped at approximately 40 minutes, as before.
Since it is a problem with FFMPEG, I will try to compile the newer version and go ahead from there.

I updated FFMPEG to version 2.7.1, no differences encountered.

@OnlyInAmerica Have you got a chance to look into this?

@Arlem I am having a hard time building FFMPEG 2.7.1 with rtmp. WOuld you be able to help? I want to use the native rtmp instead of librtmp.
I am able to separately build ffmpeg, openssl (using a different method than guardianproject's). I am not able to build librtmp. I am looking for a script that can build librtmp with my generated openssl. Any help would be appreciated

@Arlem I have also encountered this problem.Have you solved it?

08-27 23:58:05.158: E/FFmpegWrapper(28230): av_interleaved_write_frame video: 1 pkt: 60493 size: 8892 error: Invalid argument

@gouravd Sorry, I am using hls and haven't tried to build FFMPEG 2.7.1 with rtmp.
@JajuanWang No solution found, do you have any guess?

@Arlem https://github.com/OpenWatch/FFmpegWrapper-Android/blob/master/FFmpegWrapper/jni/FFmpegWrapper.c   on line 413 //packet->pts = av_rescale_q(packet->pts, *videoSourceTimeBase, (outputFormatContext->streams[packet->stream_index]->time_base));I was going to comment this line，because i need not to adjust the time base,I guess the problem is caused by the this.I have tried to verify it，but recompile the .so files failed

@Arlem  and you can see the link http://www.ffmpeg.org/doxygen/2.0/mathematics_8c_source.html on line 130 int64_t av_rescale_q(int64_t a, AVRational bq, AVRational cq),I just known it is used to adjust the time base

@JajuanWang It fails when you run ndk-build.sh or build_ffmpeg_for_android.sh?

@JajuanWang I solved (this) problem! Open FFmpegWrapper.c, go to line 420 and modify the code from:
packet->pts = (int) jPts;
to:
packet->pts = (int64_) jPts;
I've done registration for more than 1 hour with this change.
I have checked that the error originates from jPts being a jlong, which overflow when casted to int, this happens at around 35-40 minutes.
I don't know why it was casted to int, since pts is int64_t (as described by https://ffmpeg.org/doxygen/2.8/structAVPacket.html).

I have FFmpegWrapper.so and cant view or edit it. what would be the solution in this case. Thank you.

@Arlem can you please share the corrected and updated.  .so files. Thank you

This is my .so file of the FFmpeg wrapper (for armeabi and armeabi-v7a).
libFFmpegWrapper.zip
Tell me if you need the other FFmpeg library also.
By the way, have you seen this project? https://github.com/OnlyInAmerica/FFmpeg-Android you might need to recompile on your own in the future.

Thank you. I believe I do need the others. Im getting this crash now when I try and start a stream:
04-13 22:43:33.562 25102-25102/com.peekatucorp.thePartyStarter I/Muxer: Created muxer for output: /storage/emulated/0/MySampleApp/1fd9e0d2-92de-45b1-883f-192b7a2554a0/index.m3u8 04-13 22:43:33.564 25102-25102/com.peekatucorp.thePartyStarter E/art: dlopen("/data/app/com.peekatucorp.thePartyStarter-1/lib/arm/libFFmpegWrapper.so", RTLD_LAZY) failed: dlopen failed: library "libavformat-57.so" not found 04-13 22:43:33.564 25102-25102/com.peekatucorp.thePartyStarter D/AndroidRuntime: Shutting down VM 04-13 22:43:33.565 25102-25102/com.peekatucorp.thePartyStarter E/AndroidRuntime: FATAL EXCEPTION: main                                                                                Process: com.peekatucorp.thePartyStarter, PID: 25102                                                                                java.lang.UnsatisfiedLinkError: dlopen failed: library "libavformat-57.so" not found                                                                                at java.lang.Runtime.loadLibrary(Runtime.java:371)                                                                                at java.lang.System.loadLibrary(System.java:988)                                                                                at net.openwatch.ffmpegwrapper.FFmpegWrapper.<clinit>(FFmpegWrapper.java:43)                                                                                at io.kickflip.sdk.av.FFmpegMuxer.<init>(FFmpegMuxer.java:72)                                                                                at io.kickflip.sdk.av.FFmpegMuxer.create(FFmpegMuxer.java:101)                                                                                at io.kickflip.sdk.av.SessionConfig$Builder.<init>(SessionConfig.java:225)                                                                                at com.peekatucorp.io.kickflip.sample.Util.create720pSessionConfig(Util.java:58)                                                                                at com.peekatucorp.thePartyStarter.MainActivity.configureNewBroadcast(MainActivity.java:2141)                                                                                at com.peekatucorp.thePartyStarter.MainActivity.startBroadcastingActivity(MainActivity.java:2134)                                                                                at com.peekatucorp.io.kickflip.sample.fragment.StreamListFragment$4.onClick(StreamListFragment.java:241)                                                                                at android.view.View.performClick(View.java:4786)                                                                                at android.view.View$PerformClick.run(View.java:19897)                                                                                at android.os.Handler.handleCallback(Handler.java:739)                                                                                at android.os.Handler.dispatchMessage(Handler.java:95)                                                                                at android.os.Looper.loop(Looper.java:135)                                                                                at android.app.ActivityThread.main(ActivityThread.java:5300)                                                                                at java.lang.reflect.Method.invoke(Native Method)                                                                                at java.lang.reflect.Method.invoke(Method.java:372)                                                                                at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:904)                                                                                at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:699) 04-13 22:43:33.566 25102-25102/com.peekatucorp.thePartyStarter D/AppTracker: App Event: crash

These are the ones I am actually using.
ffmpeg+wrapper.zip


Handle well selection with mixed ingredients

Acceptance criteria:

If a user selects well(s) that all contain the same ingredient (and ingredient attributes), then the ingredient editor should be pre-populated with the ingredient and ingredient attributes
If a user selects well(s) that have different ingredients or different ingredient attributes, then the ingredient editor should be blank by default
If a user selects additional wells while the ingredient editor is open, treat the combined selection as a new selection (ingredient editor is blank if selection contains different ingredients or ingredient attributes)
Saving ingredient editor should overwrite ingredients and ingredient attributes
--If you are overwriting existing wells and hit save, then you get a confirmation modal to make sure you meant to overwrite existing information

Designs:
n/a

Related to #1609


Question about external JSON

I see that you said Yes, a pack author has the ability to configure DS behavior using external JSON config files, including turning on weather for a dimension. I just want to know is there any documentation to shows me how to use external JSON to enable weather for a dimension?

Thanks :)

Closing out the issue.  If you have further questions just ask. :)


Multi-agent MultiLoopScenario RL actions issues

I'm trying the multiloop scenario, currently set the NUM_RING = 1 and the action is box(1, ) type.
Then I added more than 1 RL vehicles, take 3 RL vehicles as an example:
in multiagent_envs/loop/wave_attenuation.py: _apply_rl_actions:
the RL action mapped to each RL vehicle is a vector with the length of the total number of RL vehicles instead of a vector with length = 1, so that the action (acc) cannot be implemented.
Here is an example:
rl_actions =  {'rl_0_0': array([ 0.72494316,  0.50378126, -1.        ], dtype=float32), 'rl_0_1': array([-1.        ,  0.45251432, -1.        ], dtype=float32), 'rl_0_2': array([-1.       ,  0.6811293,  0.7003129], dtype=float32)}

Not sure if I describe my problem clear enough. I'll appreciate it if I can get some guidance on how to change it. Thank you!

I kept the common policy graph so all rl vehicles update a common policy if this makes more sense.

hi @nancyhwr trying to reproduce the bug now. Will get back to you once I have a fix.


this app can't run on you pc

ℹ Computer information

PowerToys version: 0.25
PowerToy Utility:
Running PowerToys as Admin: yes
Windows build number: [run "winver"] 19041.572

📝 Provide detailed reproduction steps (if any)

Download powetoys from github release page.
Install the app

✔ Expected result
Should successfully install
❌ Actual result
It prompts a dialog saying : This App can't run on you PC
📷 Screenshots

Which architecture are you using?
Search for "About your PC":

this is the architecture of your PC:

Ah, yes I didn't check that on this PC.
It's a 32 bit system, and the installation package is 64bit.
So this is not a bug. Sorry about that.
Ideally the error dialog could report that "The app requires 64 bit OS"

@joejoint That dialog is form windows and so we can't modify it.

@Aaron-Junker That's the wrong resolution. PowerToys does not support 32-bit systems: see this

dup #602

@joejoint You can subscribe to #602

Its sometimes difficult to add the right label because it could be more than one.

But Resolution-Duplicate is the right one because there exists an issue for this already: #602


Nested delete doesn't work with onDelete: Restrict

Bug description
When using { delete: true } with an optional relation configured with onDelete: Restrict, the query fails with Foreign key constraint failed on the field even if the current updated record is the only reference to the deleted entity
How to reproduce
Use { delete: true } during an update on an optional relation with onDelete: Restrict
(no action also doesn't work)
Expected behavior
The column is set to null and the relation is deleted.
Looking at queries, I think the first update in the transaction should explicitly set the column to null instead of relaying on a default SET NULL behaviour.
Prisma information
  hint       Label?            @relation("hint", fields: [hintUuid], references: [uuid], onDelete: Restrict)

Environment & setup

OS: Mac OS
Database: PostgreSQL
Node.js version: v17.8.0

Prisma Version
prisma                  : 3.12.0
@prisma/client          : 3.12.0
Current platform        : darwin
Query Engine (Node-API) : libquery-engine 22b822189f46ef0dc5c5b503368d1bee01213980 (at<EMAIL_ADDRESS>Migration Engine        : migration-engine-cli 22b822189f46ef0dc5c5b503368d1bee01213980 (at node_modules/@prisma/engines/migration-engine-darwin)
Introspection Engine    : introspection-core 22b822189f46ef0dc5c5b503368d1bee01213980 (at node_modules/@prisma/engines/introspection-engine-darwin)
Format Binary           : prisma-fmt 22b822189f46ef0dc5c5b503368d1bee01213980 (at node_modules/@prisma/engines/prisma-fmt-darwin)
Default Engines Hash    : 22b822189f46ef0dc5c5b503368d1bee01213980
Studio                  : 0.459.0

Use { delete: true } during an update on an optional relation with onDelete: Restrict (no action also doesn't work)

This is expected behavior. You're telling the database that any delete of referenced side is supposed to fail, the optionality that Prisma introduces here on the relation doesn't matter, because the behavior of Postgres supersedes that here. An optional relation basically gives you that onUpdate: Cascade (or SetNull) and onDelete: SetNull work as referential actions, but you actually have to use them in order to get the desired effect.
Side note: Restrict and NoAction on SQL connectors have almost always the same behavior with nuances in the underlying semantics for the database implementations, bar some exceptions.

My goal is to prevent delete -> set null, but I still want to do set null then delete in one "prisma call".
I currently use { disconnect: true } and then use another prisma call to delete the previously referenced row.
If the update statement set the relation column to null (like with disconnect), then the delete statement sent just after will work.

And that's the correct way of solving it, you will need to do two separate calls, the current queries are not designed to solve this magically because it would be unexpected (and frankly, incorrect) for the majority of users.


Ability to left only text messages

Thank you for the amazing package.
Is your feature request related to a problem? Please describe.
I need to have different chats in my app:

Messanger: chat that contains almost all features: text messages, audio, photo, reactions, etc.
Simplified feedback chat: chat that has only text and photo messages
Super simple chat for commenting photo: chat that has only text messages and smiles

There is ability to disable audio messages SendMessageConfiguration(allowRecordingVoice: false), but I couldn't find ability to disable photo and reactions.
Describe the solution you'd like
It would be good to have simple options to disable photo messages and reactions. Something like that:
SendMessageConfiguration(allowPhotoMessages: false)

An illustration what I mean:

Hi @DenisAnkh, could you please update to the latest version? We've added the feature for disabling photos.
sendMessageConfig: SendMessageConfiguration(
             enableCameraImagePicker: false,
             enableGalleryImagePicker: false,
)

And for disabling the reaction please check featureActiveConfig
featureActiveConfig: const FeatureActiveConfig(
          enableReactionPopup: false,
          enableDoubleTapToLike: false,
        )

Hi @jaiminrana05, it is working!  Thank you!


windows/lib/libeay64.lib and others built with VS2010

I've been trying to build yara-python with submodule 74734418a256c5304ccaf1d322c57e305ff75362 yara (v3.5.0) on Python 3.5 (Anaconda3) amd_64 with the Microsoft Visual C++ Build Tools 2015 (aka Visual Studio 14.0, but only the command line)
The linker complains:
   Creating library build\temp.win-amd64-3.5\Release\yara.cp35-win_amd64.lib and
 object build\temp.win-amd64-3.5\Release\yara.cp35-win_amd64.exp
libeay64.lib(cryptlib.obj) : error LNK2001: unresolved external symbol _vsnwprintf
libeay64.lib(cryptlib.obj) : error LNK2001: unresolved external symbol vfprintf
libeay64.lib(cryptlib.obj) : error LNK2001: unresolved external symbol __iob_func
build\lib.win-amd64-3.5\yara.cp35-win_amd64.pyd : fatal error LNK1120: 3 unresolved externals
error: command 'C:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\BIN\\x86_amd64\\link.exe' failed with exit status 1120

According to http://stackoverflow.com/questions/30412951/unresolved-external-symbol-imp-fprintf-and-imp-iob-func-sdl2, this is caused by having parts compiled with different versions of Visual Studio.
I can't see how to rebuild windows/lib/libeay64.lib, but I can see that this one was built with Visual Studio 10.0. (strings libeay64.lib | grep cl.EXE).
I downloaded the VS14.0-precompiled 1.0.1t from http://www.npcglib.org/~stathis/blog/precompiled-openssl/, and overwrote libeay64.lib with the openssl-1.0.1t-vs2015.7z\openssl-1.0.1t-vs2015\lib64\libeay32MT.lib
This worked (it's the 64-bit version since it is in lib64, even though it's named eay32) and yara-python is happy with the results.  (There is one failure in setup.py test: testCompare fails on data['constants']['foo'], but I can't imagine how that could be related to this lib)
If useful, I can try to put together a pull request to add the right windows\lib\vsXXXX into the /LIBPATH variables and move libeayXX.lib there, or to just replace the current file in its current location.

There was a lot of push back to checking in the new VS2015 binaries. Ended up settling on a nuget package that contained the binaries. See #414
It looks like the current binaries are out of date as of July 1 when OpenSSL was updated in this project.

The VS 2010 project is not supported anymore and the VS 2015 project has been revamped to make use of NuGet.


Specific PDF makes duplicate fields for final checkbox

However many checkboxes I deleted, the last checkbox in the document seemed to get a duplicate field and cause an 'index out of range' error. Could not recreate it in another pdf document. They were _yes checkboxes that did not have a corresponding _no, but that worked fine in a different document. I also tried copying checkboxes from this broken document to another document and that document then still worked fine.
I have a video I can post somewhere if this is something we want to try to troubleshoot.
PDF in question:
ma_seal_criminal_records.pdf
Variables on the page where there's a duplicate field for the last checkbox:
duplicate_checkboxes.txt
Duplicate field means that in the weaver, when assigning readable labels to fields, one variable has directly under it two fields for writing the label and two dropdowns for choosing the type of the field.

It looks like there is an unnamed checkbox field (with no label) in the document.
Here is the full debug info: (”, ‘No’, 1, [272.176155, 78.000022, 280.632118, 89.626976], ‘/Btn’, ‘Yes’)
I'm not able to edit or delete this unnamed checkbox inside Adobe Acrobat X, but I can see it:

This is correctly caught by the most recent version of the weaver.

It sounds like you already worked around this issue. If you haven't, a solution to try is to see if it can be fixed with qpdf, and if not, to print it to PDF again and then re-add the fields.

Does this not get caught by the most recent weaver?

Does this not get caught by the most recent weaver?

It is caught in current master branch


Cannot read property 'days' of undefined

Is the error produced when using the demo code provided in the README.md
As demonstrated here https://codepen.io/foobar2000/pen/LYYvxQN?editors=1112
Am I missing something ?

var tickets_activity_data = [{
		date: new Date(2019, 10, 10),
		count: 5
	}];

	var tickets_activity_chart = calendarHeatmap()
		.data(tickets_activity_data)
		.selector('#tickets_activity_chart')
		.colorRange(['#D8E6E7', '#218380'])
		.tooltipEnabled(true)
		.onClick(function (data) {
			console.log('onClick callback. Data:', data);
		});

	tickets_activity_chart();

My bad, I misread :

As long as new Date() can parse the date string it's ok.


CO-2727_Announcement_menu_action_fetches_announcement_of_a_different_CO

The current change fixes the index view for announcements (e.g. /registry/announcements_widget/co_announcements/index/co:2 ), but it does not correct the issue in the dashboard widget itself.
To reproduce the problem in a dashboard widget,

add a dashboard to a different CO
add an announcement widget to that dashboard but do not set the announcement channel
make the dashboard the default dashboard (in CO Settings), unless you have multiple
view the dashboard widget as rendered in the dashboard

The current change fixes the index view for announcements (e.g. /registry/announcements_widget/co_announcements/index/co:2 ), but it does not correct the issue in the dashboard widget itself.
To reproduce the problem in a dashboard widget,
* add a dashboard to a different CO

* add an announcement widget to that dashboard but _do not set the announcement channel_

* make the dashboard the default dashboard (in CO Settings), unless you have multiple

* view the dashboard widget as rendered in the dashboard

@spartanicus i updated the PR with the changes required.


Add samples for loading CSV from GCS

These samples are intended to appear in the documentation at https://cloud.google.com/bigquery/docs/loading-data-cloud-storage-csv
See the samples at https://cloud.google.com/bigquery/docs/loading-data-cloud-storage-json for similar work in other languages.

[x] Tests and linter pass - I couldn't get even the existing tests to pass. It seems ava is not getting any output from the samples sometimes. (Maybe it is not waiting for the sample to finish running?)
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

/cc @jmdobry @ace-n

Note: I removed the assert on the number of rows after the insertAll (streaming) call, because that is flakey. Rows first go to the streaming buffer, where they don't appear in row listings.

Ready to merge?

Published! https://cloud.google.com/bigquery/docs/loading-data-cloud-storage-csv


Can't import the library

Receiving this error:
Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: No "exports" main defined in C:\Users\kewyn\Documents\projects\bot\node_modules\thermal-printer-encoder\package.json
at new NodeError (node:internal/errors:393:5)
at throwExportsNotFound (node:internal/modules/esm/resolve:292:9)
at packageExportsResolve (node:internal/modules/esm/resolve:546:7)
at resolveExports (node:internal/modules/cjs/loader:529:36)
at Module._findPath (node:internal/modules/cjs/loader:569:31)
at Module._resolveFilename (node:internal/modules/cjs/loader:981:27)
at Module._load (node:internal/modules/cjs/loader:841:27)
at Module.require (node:internal/modules/cjs/loader:1061:19)
at require (node:internal/modules/cjs/helpers:103:18)
at Object. (C:\Users\kewyn\Documents\projects\bot\index.js:1:35) {
code: 'ERR_PACKAGE_PATH_NOT_EXPORTED'
}
let ThermalPrinterEncoder = require('thermal-printer-encoder');

let encoder = new ThermalPrinterEncoder({
  language: 'esc-pos',
  width:      48,
  wordWrap:   true
});

let result = encoder
    .initialize()
    .codepage('auto')
    .text('The quick brown fox jumps over the lazy dog')
    .italic(true)
    .newline()
    .barcode('3130630574613', 'itf', 60)
    .encode();

console.log(result);

Node.js v19.0.0
Npm 9.6.1

I'm encountering the same issue, I can't get it to work


chore: changelog for 0.8.12

/deploy

You can access the deployment of this PR at https://renku-ci-nb-634.dev.renku.ch


[BUG] Soundness bug introduced by refactoring

The commit de3120967adf1cedb43b48b7da7062eaadb243df broke the following spec. Ironically, this commit is about refactoring.
------------ MODULE Bug20201118 ---------------------------
EXTENDS Integers
VARIABLES p, error

AccountIds == { "", "A", "B" }

Data == [
  amount: 0..3
]

Packets == [
  sender: AccountIds,
  data: Data
]

WellFormed(packet) ==
  /\ packet.sender /= ""
  /\ packet.data.amount > 0

Pre(packet) ==
  LET data == packet.data IN
  WellFormed(packet)

Init ==
  /\ p \in Packets
  /\ error = FALSE

Action(packet) ==
  \/ /\ error' = FALSE
     /\ Pre(packet)
  \/ /\ error' = TRUE
     /\ ~Pre(packet)

Next ==
  /\ p' \in Packets
  /\ Action(p')

Inv == (error = TRUE) =>
        (p.data.amount <= 0 \/ p.sender = "")
===========================================================

Well, it boils down to the trivial spec:
------------------------- MODULE Fix333 -----------------------------------
VARIABLES error

Init ==
    error = FALSE

Next ==
    \/ error' = FALSE
    \/ error' = TRUE

Inv ==
    ~(error = TRUE)
===========================================================================

The reason is that the new simplifier has simplified the two bootstrapping assertions (assert (not $C$0)) and (assert $C$1) to (assert true) and (assert true).

Fixed


Don't add gu-transit class until after delay.

The gu-transit class is currently being added on start before the delay. This causes the element to flicker when a user is only clicking on the element. The gu-transit class should only be added when the element is actually in transit.

Ah, nice!


python/task/twosum.py

Complete the task here:-
https://leetcode.com/problems/two-sum/
and provide the screenshot of the code and output on the path referenced to by the title of the issue.

Assign this to me

Can you please assign this issue?

@Kunal-Garg-12 assigned, you may work on it


Fix subclassing OpenAIEmbeddings

Fix subclassing OpenAIEmbeddings

Fixes #4498
Before submitting

Problem: Due to annotated type Tuple[()].
Fix: Change the annotated type to "Iterable[str]". Even though tiktoken use Collection[str] type annotation, but pydantic doesn't support Collection type, and Iterable is the closest to Collection.

Who can review?
Community members can review the PR once tests pass. Tag maintainers/contributors who might be interested:
@shibanovp
@hwchase17

seems like we use Collection elsewhere (e.g. langchain/llms/openai.py)

Iterable is more generic than Collection and openai types as Collection, so probably don't want to do that. could we do Set[str] and Sequence[str]? probably covers anything people would want to use

It's reasonable, I have updated accordingly.

seems to work for me but im not actually able to reproduce original error (on python 3.11), let me know if it works for you

I confirmed. The original bug happens in Python 3.9 but doesn't happen in Python 3.10/3.11

thanks @trducng!


Move home banner to a flowblock

Fixes #14

create home-banner flowblock
add a slidershow to home-banner
add class atribute to slidershow

LGTM, ready for merge?

LGTM,  ready for merge?

yes :smile:


How to do enrichement of fields using lambda task in netflix conductor. Does netflix conductor provides input to be auto generated

@Priena Can you provide more details about what you're trying to achieve please. An example would be helpful too.


regarding requirements

hey @antoine77340 , thanks for this work it's really intersting .!
i am trying to run the code , it's not really working for me and i guess that the problem with the csv file i provided .
i think i have  some issues with the  content of it .
can you provide an example for the csv file ?

thank you

Hello @khaled26
All your paths should be full like this, here is an example.

Hello @khaled26 All your paths should be full like this, here is an example.

Excuse me, could you give advice on how to process videos on windows?


NIFI-4962 FlattenJson processor add unexpected backslash after flatten

Upgrade json flatten library version to newest one to deal with StringEscapePolicy.
Add unit test code to verify solution.
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit?

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

[WARNING] src/main/java/org/apache/nifi/processors/standard/FlattenJson.java:[21,8] (imports) UnusedImports: Unused import - com.github.wnameless.json.flattener.CharSequenceTranslatorFactory.
[WARNING] src/main/java/org/apache/nifi/processors/standard/FlattenJson.java:[25,8] (imports) UnusedImports: Unused import - org.apache.commons.text.translate.CharSequenceTranslator.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 04:39 min
[INFO] Finished at: 2018-03-13T17:43:28+01:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (check-style) on project nifi-standard-processors: You have 2 Checkstyle violations. -> [Help 1]

+1
took care of the checkstyle issue and merged to master, thanks @yjhyjhyjh0


[Core] Remove entry in changelog

Remove entry with no items in Changelog for release

API change check
API changes are not detected in this pull request.


Determine latest component versions automatically

Signed-off-by: Paul S. Schweigert<EMAIL_ADDRESS>Changes

Update Knative component versions automatically at build time, similar to the logic used by the client in https://github.com/knative/client/pull/1625

Fixes #12
/assign @dsimansk @rhuss

/lgtm
/approve


Possibility to add a hidden option on contextmenu items

Hi,
is it possible to add a hidden option to the menu items of a context menu, based on boolean/closure ?
Eg:
{
  label: "Label 1",
  disabled: false,
  hidden: true,
  hidden: function (data) {
       return false;
  },
  separator_before: true,
  separator_after: false,
  action: function (data) {
      // do something
  }

No, this is not possible but the whole contextmenu option can be set to a function - in that case you can control which items are shown depending on which node was selected - that should be more than enough for what you need.


tests: Unix domain sockets

Description
The purpose of the test is to compare the performance of unix domain sockets in lind and native linux. There are two types of tests uds_send_recv.c and uds_test.c; in the first one we have the child and parent processes exchanging data between each other i.e. both processes send and recv data via domain sockets whereas in the second one the data transfer is one-way i.e. the parent is sending data while the child is receiving that data.

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[X] Tests (test scripts for unit testing or benchmarks)
[ ] This change requires a documentation update

How Has This Been Tested?

uds - lind_project/tests/ipc_performance_tests/uds

Checklist:

[X] My code follows the style guidelines of this project
[X] I have commented my code, particularly in hard-to-understand areas
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[ ] Any dependent changes have been added to a pull request and/or merged in other modules (native-client, lind-glibc, safeposix-rust)

@RusherRG remove any svg files here (as well as any executables or any other generated data if there is any)

@RusherRG remove any svg files here (as well as any executables or any other generated data if there is any)

Removed them.


[qt5-webengine] Fix apply patch failed

Fixes #23449
Fix pld patches of qt5-webengine.

When can i pull this pr from master branch?

@TaylorShi Click command line instructions in this github page.

@TaylorShi Click command line instructions in this github page.

Thank u, I'm trying building it.


Downloading images without a completion block is not pointless

I want to cache a few, small images for later use (I'm expecting them to be about to be downloaded, and want them cached before the user needs to see them). I tried downloading them with an empty completion block, but it looks like the library asserts against a nil completion block.

Invoking this method without a completedBlock is pointless

I feel like this is a mistake; the method in question has side-effects, side-effects which can be relied upon by outside code. Is there some other reason this is a bad idea?

How about https://github.com/rs/SDWebImage/blob/master/SDWebImage/SDWebImagePrefetcher.h ?

Obviously not the most elegant use case, but you get the idea
func prefetch() {
        prefetcher.prefetchURLs(fetchedObjects?.map {
            return ($0 as! Post).url
        })
    }

Oh very cool, thanks! Maybe supplement the existing comment with a pointer to use this? 😻

@ashfurrow  there are some caveats to this bad boy though, let me try and save you some headaches

If you used the shared instance, it's not FIFO, as soon as you send in urls it will cancel your entire last batch
Because it uses NSOperation NSURLSessions are out of the question (no support for NSURLSession priorities etc)
Make sure you check the defaults on max concurrent connections and don't forget to factor in your already existing  SDWebImage  operations
If you are working with large images make sure you use HEAD,  and set false for shouldDecompressImages else your devices (especially arm64) will shutdown from memory pressure in minutes. This should be the default by the framework, but it's not :confused:

Example defaults
SDImageCache.sharedImageCache().maxCacheSize = 300 * 1024 * 1024
SDImageCache.sharedImageCache().shouldDecompressImages = false
SDWebImageDownloader.sharedDownloader().shouldDecompressImages = false
SDWebImageDownloader.sharedDownloader().maxConcurrentDownloads = 4

Super helpful – thanks @rromanchuk !


Push 0.19.0 to crates.io with the updated dependencies

The current valid version on crates.io (0.18) has a dependency on an outdated version of sdl2-sys (0.8.1), which results in a dependency error when using other SDL libraries.
It looks like the version here on github has the correct dependencies set, so the only required change should be bumping the version in the cargofile :).
The dependency can be seen here.
For reference, the error I get is this:
error: native library `SDL2` is being linked to by more than one version of the same package, but it can only be linked once; try updating or pinning your dependencies to ensure that this package only shows up once

  sdl2-sys v0.19.0
  sdl2-sys v0.8.1

It seems like the current version on crates.io has a similar problem. It depends on sdl2 0.19 but the github version depends on 0.20 but still has the version 0.19. If you try to use this:
[dependencies] sdl2 = "0.20" sdl2_image = "0.19"
you will get an error about
src\main.rs:23:28: 23:40 error: no method named load_texture found int the current scope src\main.rs:23     let texture = renderer.load_texture(png).unwrap();
The same problem as #50. Can be fixed by referencing the repository directly.


dotnet test hangs when running integration tests with UseWebpackDevMiddleware in Azure DevOps

Description
Running the dotnet test task in Azure DevOps Pipelines on a test assembly that is running integration tests (via Microsoft.AspNetCore.Mvc.Testing) while also using UseWebpackDevMiddleware causes the test run to hang forever.
To Reproduce

Create a new ASP.NET Core SPA website (which uses UseWebpackDevMiddleware)
Create a unit test project that uses Microsoft.AspNetCore.Mvc.Testing to execute an integration test
Create an Azure DevOps Pipeline that builds and runs tests via dotnet build and dotnet test (I am using the Visual Studio 2019 on Windows 2019 build agent)
Run the pipeline and notice that when it gets to dotnet test, the test run hangs after logging the following:

Starting test execution, please wait...
info: Microsoft.AspNetCore.DataProtection.KeyManagement.XmlKeyManager[0]
      User profile is available. Using 'C:\Users\VssAdministrator\AppData\Local\ASP.NET\DataProtection-Keys' as key repository and Windows DPAPI to encrypt keys at rest.
info: Microsoft.AspNetCore.DataProtection.KeyManagement.XmlKeyManager[0]
      User profile is available. Using 'C:\Users\VssAdministrator\AppData\Local\ASP.NET\DataProtection-Keys' as key repository and Windows DPAPI to encrypt keys at rest.
info: Microsoft.AspNetCore.DataProtection.KeyManagement.XmlKeyManager[58]
      Creating key {5653a870-1f93-4b30-b7d2-29fd94a34191} with creation date 2019-05-23 17:34:18Z, activation date 2019-05-23 17:34:18Z, and expiration date 2019-08-21 17:34:18Z.
info: Microsoft.AspNetCore.DataProtection.KeyManagement.XmlKeyManager[58]
      Creating key {02253cc1-903b-43b6-909a-61faccc67c88} with creation date 2019-05-23 17:34:18Z, activation date 2019-05-23 17:34:18Z, and expiration date 2019-08-21 17:34:18Z.
info: Microsoft.AspNetCore.DataProtection.Repositories.FileSystemXmlRepository[39]
      Writing data to file 'C:\Users\VssAdministrator\AppData\Local\ASP.NET\DataProtection-Keys\key-5653a870-1f93-4b30-b7d2-29fd94a34191.xml'.
info: Microsoft.AspNetCore.DataProtection.Repositories.FileSystemXmlRepository[39]
      Writing data to file 'C:\Users\VssAdministrator\AppData\Local\ASP.NET\DataProtection-Keys\key-02253cc1-903b-43b6-909a-61faccc67c88.xml'.

Expected behavior
The test run should not hang due to the use of UseWebpackDevMiddleware.
Additional context

I am using Azure DevOps Pipeline
I am using version 2.2.300 of the dotnet SDK
All of my packages are up to date (with no prerelease packages being used)
The test run executes fine via Visual Studio and CLI locally
I have tried using an agent hosted on a VM and the issue still occurs

Thanks for contacting us, @ChristopherHaws.
The repro here is quite complicated. Please provide something very minimal, reduced to something self-contained, so there are no dependencies. If, however, you feel that this is no really a code issue on our end, but something related to Azure DevOps or some other external system, consider filing an issue through the respective feedback channel.

@mkArtakMSFT Thanks for the reply. I took our solution and removed everything from it except the necessary code to repro this issue. Once piece of information that I missed in the inital report is that you need to create two test classes in order to repro the issue. I created a AzDo repository and yaml pipeline that reproduces the issue.
Repo: https://dev.azure.com/chaws/_git/webpack-issue
Build: https://dev.azure.com/chaws/webpack-issue/_build/results?buildId=19&view=results
Let me know if you need any more info.

@javiercn can you please look into this? Thanks!

There must be something here between test server and the webpack dev middleware that doesn't play well. @Tratcher might know more.
I don't think there is anything specific to Microsoft.AspNetCore.Mvc.Testing here.

Any way to capture a dump of the hung process and see the active call stacks?

I have the same issue. My test solution with xUnit integration tests works on local enviornment: both on linux and windows.
After series of experiments I can say that on Azure DevOPS

running dotnet build goes fine.
Running dotnet test --no-build hangs on the first test executed (sometimes it executes several tests, but still hangs)

I do not remember where I found it but does the following solution help?
Adding to the .csproj file the following element:
 <ItemGroup>
        <None Update="xunit.runner.json">
            <CopyToOutputDirectory>Always</CopyToOutputDirectory>
        </None>
    </ItemGroup>

And the file xunit.runner.json in the test project:
{
  "parallelizeTestCollections": true,
  "maxParallelThreads": -1
}

also watch out for Wait(); on Task


Change in exploitation rate calculation for Table 22

Shannon pointed out to me that the exploitation rate by age in Table 22 seems really high, such as 40.32% for fully selected (age 6+) fish in 2017.
Checking on that table, it is based on catch at age divided by biomass at age in the middle of the year. I'm sure I supported this calculation when we made the table, but in hindsight it would be more representative to switch that to beginning of year biomass.
Using beginning of year biomass instead of middle year brings the 40.32% down to 29.71% for age 6+ in 2017, which matches what you get if you take catch-at-age values from Table 24 and divide them by biomass-at-age values in Table 21.
I accidentally folded this simple fix to tables-age.r into my previous commit to the timeseries tables b2b2d93f794ea87d06f4645096704e113e2c8bf6 but if anyone disagrees with the change it's easy to change it back.

Agree - makes more sense to use biomass at start of year (I'd assumed it was). We should mention this in our talk, yes? Plus the other table.
Need to show the rebuilt document anyway for the bubble plots (and presumably your new column in the other table). So no need to add to the beamer (tables get squished anyway), we can just jump to the pages in the updated document.

Should check the text where this is referenced to see if it needs changing, then can close.

yes, agree also.

I don't see any references to Table 22 in the text other than the SRG request to add it.
I just changed the caption "Table 22. Estimated exploitation-rate-at-age for each year from the base model (MLE; percentage of age class removed by fishing)." Which seems sufficient. Close if you agree.


login and signup improvement

Closes
Closes #1567

Description

Screenshots

Note to reviewers

Checklist:

[ ] I have linked the PR to the correct issue.
[ ] I have read the Contribution Guidelines
[ ] I have built and tested the changes, and they do not break or show any errors.

@Vaishnavi-Patil2211 @Divesh2003 can you please merge my pr?


docs: Improve karpenter discovery tags example

Fixes #3096

This PR is included in version 20.20.0 :tada:


[Bug] Fix Editing of Newly Added Cards

Description
login as an admin -> add a new card -> navigate to the new card in the library page -> try editing the card (i.e criteria)
Once you click on save changes, it doesn't actually edit the card. Make sure that newly added cards can be edited just like other cards!
Before clicking Save Changes

After clicking Save Changes

[ ] newly added cards can be edited just like normal cards

Other Notes

Pointers, tips, and links to pieces of code or resources that might help in solving this ticket.

I tried testing a bit. Looks like handleSubmit() doesn't get called for the newly added cards. I'm not sure why? this might be an issue with the new cards not being fully integrated with react-final-form but idk try to debug more.


How can I create more WAM-Vs

May I ask how can I create two or more WAM-Vs on different positions
and my systen is
ROS2 Humble
Gazebo Garden

You could do it by modifying vrx_gz/launch/competition.launch.py:
+++ b/vrx_gz/launch/competition.launch.py
@@ -43,10 +43,15 @@ def launch(context, *args, **kwargs):
         with open(config_file, 'r') as stream:
             models = Model.FromConfig(stream)
     else:
-      m = Model('wamv', 'wam-v', [-532, 162, 0, 0, 0, 1])
+      m1 = Model('wamv1', 'wam-v', [-532, 162, 0, 0, 0, 1])
       if robot_urdf and robot_urdf != '':
-          m.set_urdf(robot_urdf)
-      models.append(m)
+          m1.set_urdf(robot_urdf)
+      models.append(m1)
+
+      m2 = Model('wamv2', 'wam-v', [-530, 160, 0, 0, 0, 1])
+      if robot_urdf and robot_urdf != '':
+          m2.set_urdf(robot_urdf)
+      models.append(m2)

After recompiling and launching, you should see two WAM-Vs now with their own set of topics:

/wamv1/joint_states
/wamv1/pose
/wamv1/pose_static
/wamv1/robot_description
/wamv1/sensors/acoustics/receiver/range_bearing
/wamv1/sensors/cameras/front_left_camera_sensor/camera_info
/wamv1/sensors/cameras/front_left_camera_sensor/image_raw
/wamv1/sensors/cameras/front_left_camera_sensor/optical/camera_info
/wamv1/sensors/cameras/front_left_camera_sensor/optical/image_raw
/wamv1/sensors/cameras/front_right_camera_sensor/camera_info
/wamv1/sensors/cameras/front_right_camera_sensor/image_raw
/wamv1/sensors/cameras/front_right_camera_sensor/optical/camera_info
/wamv1/sensors/cameras/front_right_camera_sensor/optical/image_raw
/wamv1/sensors/cameras/middle_right_camera_sensor/camera_info
/wamv1/sensors/cameras/middle_right_camera_sensor/image_raw
/wamv1/sensors/cameras/middle_right_camera_sensor/optical/camera_info
/wamv1/sensors/cameras/middle_right_camera_sensor/optical/image_raw
/wamv1/sensors/gps/gps/fix
/wamv1/sensors/imu/imu/data
/wamv1/sensors/lidars/lidar_wamv_sensor/points
/wamv1/sensors/lidars/lidar_wamv_sensor/scan
/wamv1/shooters/ball_shooter/fire
/wamv1/thrusters/left/pos
/wamv1/thrusters/left/thrust
/wamv1/thrusters/right/pos
/wamv1/thrusters/right/thrust
/wamv2/joint_states
/wamv2/pose
/wamv2/pose_static
/wamv2/robot_description
/wamv2/sensors/acoustics/receiver/range_bearing
/wamv2/sensors/cameras/front_left_camera_sensor/camera_info
/wamv2/sensors/cameras/front_left_camera_sensor/image_raw
/wamv2/sensors/cameras/front_left_camera_sensor/optical/camera_info
/wamv2/sensors/cameras/front_left_camera_sensor/optical/image_raw
/wamv2/sensors/cameras/front_right_camera_sensor/camera_info
/wamv2/sensors/cameras/front_right_camera_sensor/image_raw
/wamv2/sensors/cameras/front_right_camera_sensor/optical/camera_info
/wamv2/sensors/cameras/front_right_camera_sensor/optical/image_raw
/wamv2/sensors/cameras/middle_right_camera_sensor/camera_info
/wamv2/sensors/cameras/middle_right_camera_sensor/image_raw
/wamv2/sensors/cameras/middle_right_camera_sensor/optical/camera_info
/wamv2/sensors/cameras/middle_right_camera_sensor/optical/image_raw
/wamv2/sensors/gps/gps/fix
/wamv2/sensors/imu/imu/data
/wamv2/sensors/lidars/lidar_wamv_sensor/points
/wamv2/sensors/lidars/lidar_wamv_sensor/scan
/wamv2/shooters/ball_shooter/fire
/wamv2/thrusters/left/pos
/wamv2/thrusters/left/thrust
/wamv2/thrusters/right/pos
/wamv2/thrusters/right/thrus

very appreciate it for replying my question,it has help me very much.orz

But when I drive the wamvs,how can I  obtain the wamv's real-time position


shortcut as Text with multiple lines and support HTML.

Description of the new feature / enhancement
shortcut as Text with multiple lines and support HTML.
Scenario when this would be used?
when make body content of web or page support html
Supporting information
No response

Be more specific please.

Sounds like #5074 to me
/needinfo

okay, here my example when I press Alt+0 will print "Subject, Body, Sign" then I press enter from keyboard to addnew  blank lines
"Subject
Body
Sign"
I didn't find way to make it possible added blank lines as I need, Even i tried to add /n

Here my real example, "Name:  |  Date:   |   Issue:" then I press the Alt+1 and PowerToys will print it like this "Name:  |  Date:   |   Issue:" then I edited it to be like this
Name:
Date:
Issue:
and fill it to be like this
Name:  Yousef
Date:   2024-6-9
Issue: WiFi won't work .
I hope you understand me

Yes, this is basically the same as the other issue. Something like AutoHotkey would be nice for this.

Yes, this is basically the same as the other issue. Something like AutoHotkey would be nice for this.

Scan AutoHotKey in VirusTotal... Not good.

/dup https://github.com/microsoft/PowerToys/issues/5074