That was wrong regexp for stripping up to an opening curly bracket, wasn't it?

Sorry, I don't see that your change work, could you please include in the description what cases doesn't work the actual regex ?
So I can make tests for this expression if required but I see a good expression there.

To say truth, I don't understand how the original regex (.*({.*)) was supposed to work at all. It just matches everything till the end of line. For example, for
@media all and (max-width:768px){.builder {font-size:20px}
ul.list_custom-icon {margin-top:-0.16em}
}

(assuming that @media all and  is already read) it will match (max-width:768px){.builder {font-size:20px} (with {.builder {font-size:20px} as 1st capture group).
But { (not the LF) should be the criterion.

BTW, my original sugesstion was also not 100% correct.
I originally suggested
pattern = re.compile('.*?[{]')

but it should be
pattern = re.compile('(?s:.)*?[{]')

or
pattern = re.compile('.*?[{]', re.DOTALL)

Are any additional details needed?

Implemented on 0.2.9.

IMHO, the addition described in the comment<PHONE_NUMBER> is still not implemented.


TypeError: '<' not supported between instances of 'dict' and 'dict'

Python 3.6.5
Fiona==1.8a1
networkx==1.11
scipy==0.19.1
Shapely==1.6.1
g is a Shapely Polygon.
>>> get_centerline(g)
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-31-9094808c574c> in <module>()
----> 1 get_centerline(g)

~/.local/lib/python3.6/site-packages/label_centerlines-0.1-py3.6.egg/label_centerlines/_src.py in get_centerline(geom, segmentize_maxlen, max_points, simplification, smooth_sigma)
     78             raise CenterlineError("Polygon has too few points")
     79         logger.debug("get longest path from %s end nodes", len(end_nodes))
---> 80         longest_paths = _get_longest_paths(end_nodes, graph)
     81         if not longest_paths:
     82             logger.debug("no paths found between end nodes")

~/.local/lib/python3.6/site-packages/label_centerlines-0.1-py3.6.egg/label_centerlines/_src.py in _get_longest_paths(nodes, graph, maxnum)
    165                 continue
    166     return [
--> 167         x for (y, x) in sorted(_gen_paths_distances(), reverse=True)
    168     ][:maxnum]
    169

TypeError: '<' not supported between instances of 'dict' and 'dict'

Same error occurs if I try the CLI tool with ne_110m_land.shp.

PEBKAC. I did not expect python-networkx in Archlinux being 1.x so my system did not satisfy the requirement of networkx>=2.1. Works just fine after installing an appropriate version. :)


Fix CORS

in
yaml
OR
middelware
OR
change mustarje(?) template and regenerate

Seems to be missing support for verb OPTIONS for endpoints


Adding a new simulated device resets the reported properties of all existing devices to default values

Type of issue

[x] Bug
[ ] New feature
[ ] Improvement

Description
Adding a new simulated device resets the reported properties of all existing devices to default values.
Steps to reproduce
1. First step
Update latitude and longitude properties of a chiller.
Devices tab -> select a chiller (chiller-01.0)-> jobs -> reconfigure -> change latitude and longitude -> apply.
Once done confirm the same in IoT hub device twin.
2. Second step
Create a new simulated device.
Devices tab -> New device -> Simulated, 1 , Chiller -> apply
3. Third step
Once the new simulated device is created & started sending telemetry, go to IoT hub and check  latitude and longitude reported properties of the old device (chiller-01.0) which is wrongly reset back to default after creation of the new device.
Expected behavior
Adding a new simulated device should not reset the reported properties of all existing devices to default values.
Current behavior
Adding a new simulated device resets the reported properties of all existing devices to default values.

@avanikp - I assigned this to you.

This is a known issue - adding a simulated device will result in updating simulation record in the db and will restart simulation, hence all devices will be reset.
This issue is addressed with the Add/Delete API for adding/deleting specific simulated devices. With this change the service will not cause restart of simulation and should preserve existing device properties. The issue should be resolved once remote monitoring starts consuming these APIs.


How to deploy and stay under AWS Lambda size limits?

Thanks for your work to date on this great project. Everything is working well running locally. However, when I try to deploy, I continually get size issues: RequestEntityTooLargeException: Request must be smaller than 69905067 bytes for the UpdateFunctionCode operation
What's the secret to successful deplooyment?

Hi @bluepeter,
Yes.. keeping under the size limit is a bit frustrating<EMAIL_ADDRESS>included this feature which should make it easier to keep devDependencies out of the function artefacts when using Serverless. However if you're not using Serverless, and/or are using the @serverless-chrome/lambda package directly, you have to take care to not include the devDependencies on your own. Also, be sure to deploy by uploading the artefact to S3, rather than directly. This seems to increase the allowed artefact size.
Some things to omit from your bundle:

chrome-launcher
lighthouse
any tooling like babel, or eslint

Currently, @serverless-chrome/lambda has a dependency on chrome-launcher which itself has a dependency on lighthouse. The chrome-launcher is used for local-development support. However, it brings the lighthouse dependency which is huge. I'll soon push an update which makes chrome-launcher an optional dependency—which should make it easier to deploy out of the box. Additionally, I'm going to include #26 in v1.0.

Thank you for the very detailed response. I also noticed that using S3 is another good option from your other thread here https://github.com/adieuadieu/serverless-chrome/issues/4#issuecomment-308738001 ... did you ever test the true upper bounds of maximum size of a Lambda deployed this way?

@bluepeter The direct-upload limit is 66.66MB (technically, just a bit over that.) The limit for the S3 route seems to be the 250MB code/dependency-size limit described here. I've managed to upload a zip that large, containing 250MB from /dev/urandom. In other words, your zip file can be as large as you want, as long as the total size of it's extracted contents don't exceed 250MB. In practical terms this probably means a zip somewhere around 100MB. Not sure if different regions have different limits. I tested in eu-west-1. The trade-off here is probably that, the larger the S3 package is, the longer the function will take on a cold-start.. not sure about that, though.


Address the dependency issues

We have some dependency issues preventing us from upgrading other dependencies in downstream projects.

We have decided to prioritize  #116 since Lerna is deprecated and we should spend our efforts on replacing that before we go down the path of trying to sort out deps on something that is already deprecated


fix isObject function for null value

isObject function threw Uncaught TypeError: Cannot read property 'constructor' of null(…) for null arg value.

This is not the correct fix. Should probably be val && Object == val.constructor.
It also needs a test IMO.

sorry, I was in a hurry). also would write a test respectively

There's no need for this fix, according to actual isObject fn usage
function toPromise(obj) {
  if (!obj) return obj; // !null === true, so null is returned
  //...
  if (isObject(obj)) return objectToPromise.call(this, obj);
}


No schema for encoding

Perceived Problem
I am trying to remove the need for runtime schema (whole or optimized specialty indexes of e.g. just custom scalar input paths) until absolutely needed for a feature. Example of such a feature is custom scalars or result field schema errors.
Ideas / Proposed Solution(s)
In our encoder we use the schema to differentiate strings from enums. This is because we use strings to input both of them. If we remove this use-case we can infer encoding for all other standard scalar types reasonably based on their JS runtime input without the need for a runtime schema. In fact there is very little encoding to do: ID and String just get quoted and both can be seen as strings in JS, Float and Int can receive JS numbers as is, same for Boolean, List, Input Object (we just recurse into them).
So it seems worthwhile to remove the one basic use-case for enum.
Steps we need to take:

Generate an enum proxy. Have it typed as if it were not a proxy. Near zero cost from a bundle size point of view, and surely a trivial performance cost?
Note: Later we can easily offer a generation option that replaces proxy with real runtime (objects) if people ask
To continue supporting custom scalars we need to offer a function that will be called whenever a scalar is encoded along with what the path to it is. Then, people can opt-in to using the schema to encode them. The path received by the callback can be compared to an index in the schema and if a customer scalar is declared to be there then we look up its encoder and apply it.

Applying enums to inputs will be a bit more annoying than just flowing with strings because now an import will be needed. But I think we can make it pretty painless.
pokemon.mutation.addPokemon({
  $: {
    name: 'foobar',
    type: Pokemon.PokemonType.grass
  }
})

Another solution might be to support a enum constructor that has a type variable that will allow us to autocomplete. I will test this:
pokemon.mutation.addPokemon({
  $: {
    name: 'foobar',
    type: Enum('grass')
  }
})

We could play with the function name:
pokemon.mutation.addPokemon({
  $: {
    name: 'foobar',
    type: $('grass')
  }
})

pokemon.mutation.addPokemon({
  $: {
    name: 'foobar',
    type: _('grass')
  }
})

Alternatively we could play with the key name using something that is not valid in GraphQL to allow our encoder to transform it into enum that way:
pokemon.mutation.addPokemon({
  $: {
    name: 'foobar',
    $type: 'grass'
  }
})

pokemon.mutation.addPokemon({
  $: {
    name: 'foobar',
    type$enum: 'grass'
  }
})

Decided to go with the $ prefix approach on keys for now. Maybe we can open up options/alternatives if people need it.


GCC 4.8.4 Issues - Startup failure and Script Variable Resets

Since switching from GCC 4.7 to 4.8.4 there is an issue with variables in the nsh startup scripts being reset causing script and startup failure. Additionally, at least on PX4 FMU/IO setups the system will not boot correctly if the RC is switched on before booting.

Script Variables
At some point during script execution a limit of some kind seems to be reached (at least that is how it behaves) and when a variable is defined a previously defined one will be reset. A workaround for the moment seems to be resetting unused variables.

Startup with RC On
Currently only tested with a PX4 but the above issue with script variables is triggered when powering on when the RC is already on. Required variables get reset and the script fails to complete. If the RC is left off during startup everything starts and the RC can then be turned on without any issues.

Workarounds
As mentioned for script variables, unsetting variables no longer needed can help but is only a short term solution. What prevents the RC issues, which in turn prevents variable resetting, is placing a 2 second sleep in the rcS script right after the "commander start" line. It appears that something in the commander is clobbering something while it completes in parallel (thread?). This needs closer investigation. Of course the other "workaround" is to stay with 4.7 for now ;)

Testing with the latest NuttX might be worthwhile.

Ah yes. This has been messing with my head a lot. Good to have someone else confirm this problem :+1: . I guess I will just have to revert back to 4.7 for now!

Might want to re-confirm with master. I think we got a few resource constraints there now under control, and are continuing to fix access and string stuff.

I presume this is resolved?


Tested by Section needed

https://github.com/Seagate/cortx/blob/main/doc/Community-Build/Building-CORTX-From-Source-for-SingleNode.md
Needs a tested-by section.  @TechWriter-Mayur , can you please do the needful?

Sure @johnbent, let me add the tested by section.

Issue has been addressed, hence closing


Add Connectivity Metrics to MAD httpPostSinkActor

Did a manual testing for the change and got all the new metrics in Metrics Portal.

Change very similar to "Add Connectivity metrics to CAGG"


Bug

Where is the transformer/config.json when sh t2v.sh

Where is the transformer/config.json when sh t2v.sh

Please download text_encoder, tokenizer, transformer,  vae, and model_index.json from https://huggingface.co/PixArt-alpha/PixArt-XL-2-512x512/tree/main into one folder. As for transformer, only config.json is required.

After I download, t2v can not generate the results as the demonstration, can you give me more help


This document references a feature that is not implemented.

Is there a date for this feature's implementation? Another page listed June, but June is nearly over. When will this living document reference the released feature?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 33dbe714-4b2a-d075-432d-ed335d2d8f5c
Version Independent ID: 6e320d60-5629-bb9b-c49b-92a1fa5ba56d
Content: Deployment history deletions - Azure Resource Manager
Content Source: articles/azure-resource-manager/templates/deployment-history-deletions.md
Service: azure-resource-manager
Sub-service: templates
GitHub Login: @mumian
Microsoft Alias: jgao

@bunkrur Thanks for your comment! We will review and provide an update as appropriate.

The note has been changed.

#please-close

Is there an ETA on this features release?

@tfitzmac is there an ETA on this feature?


feat: provide protocol version in epoch info query

Issue being fixed or feature implemented

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
[ ] I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

[ ] I have assigned this pull request to a milestone

I've added query asserts to existing version upgrade tests


fix(curriculum): improve tests and instructions for Expense Tracker project

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #52722
Closes #53135
Closes #53463
Closes #52580

I have reviewed the project. Provided that match/ case have not been introduced in the curriculum, I think this project can incorporate that in place if if..elif statements used to create the menu.
@ilenia-magoni, @fhsinchy, @Dario-DC What do you think?

This is the first time that elif is used. Personally, I'd keep the current code.

Everything good, other than: I have doubts on the last step. We never introduce how to work with multiple fails, so it's kind of suddend and a bit of a whiplash to have if __name__. I would totally want to have it taught, but I would see it in a proper multifile project.

I'm okay with removing that step from this project. The password generator is the the first project in which we import something, and probably it makes sense to not use if __name__ == '__main__' before we explain how to import a module. In my opinion, if we decide to remove it, we should remove it from the case converter, too.
What do you think? @ilenia-magoni @zairahira @fhsinchy @larymak @ihechikara

To maintain clarity and ensure a smooth learning curve, I'm in favor of removing the if __name__ == '__main__' step from both the password generator and case converter projects for now. So this will mean entirely getting rid of the respective steps and introducing a new approach right?

To maintain clarity and ensure a smooth learning curve, I'm in favor of removing the if __name__ == '__main__' step from both the password generator and case converter projects for now. So this will mean entirely getting rid of the respective steps and introducing a new approach right?

My proposal is to remove it from the expense tracker and the case converter. And keep it in the password generator, since we talk about importing modules in that project.
If we remove it, we should simply delete the step in which we create if __name__ == '__main__' and keep the function call which is currently inside it.

The improvements in the project overall are looking great 👍
This is ready to be merged, but I think the sync needs to be run again:

The title will be changed by crowdin I think, the sync script does the minimum to avoid errors


enhance DROP statement

Added:
DROP DATABASE
DROP USER
DROP VIEW
DROP DICTIONARY (clickhouse only)
DROP QUOTA (clickhouse only)
https://dev.mysql.com/doc/refman/8.0/en/drop-database.html
https://dev.mysql.com/doc/refman/8.0/en/drop-view.html
https://dev.mysql.com/doc/refman/8.0/en/drop-user.html
https://docs.oracle.com/cd/B19306_01/server.102/b14200/statements_9008.htm
https://clickhouse.tech/docs/en/sql-reference/statements/drop/

Coverage decreased (-0.3%) to 98.05% when pulling e534661dde6e881672637e3030087ba3ce66a706 on gleb-kov:drop-support into 40d78852a31a4d5f5eeef8859b907a7a0d5e0129 on kayak:master.


added wallrunning

added wallrunning the "karlson way"..

It does not work for me, when I hit a wall it just stops the and i cant move anymore.

It does not work for me, when I hit a wall it just stops the and i cant move anymore.

Could you upload a minimal version of your project somewhere? Should be something simple to figure out

I just tried this.

I just tried this.

Upload a minimal version of your project somewhere. Else i can't figure out whats wrong.


charts/sonarqube: uses deprecated PostgreSQL Chart

ISSUE:
Sonarqube depends on deprecated PostgreSQL Chart
https://github.com/Oteemo/charts/blob/a91016dac868ea589afa736e01e1f87a902a7949/charts/sonarqube/requirements.yaml#L1-L5

I'll work on moving over to: https://hub.helm.sh/charts/bitnami/postgresql

Fixed in #67


JedisConnectionException: Could not get a resource from the pool

I use spring-data-redis but it have a problem
<dependency>             <groupId>redis.clients</groupId>             <artifactId>jedis</artifactId>             <version>2.7.3</version>         </dependency>         <dependency>             <groupId>org.springframework.data</groupId>             <artifactId>spring-data-redis</artifactId>             <version>1.6.4.RELEASE</version>         </dependency>
Cannot get Jedis connection; nested exception is redis.clients.jedis.exceptions.JedisConnectionException: Could not get a resource from the pool redis.clients.jedis.exceptions.JedisConnectionException: Could not get a resource from the pool at redis.clients.util.Pool.getResource(Pool.java:50) at redis.clients.jedis.JedisPool.getResource(JedisPool.java:99) at redis.clients.jedis.JedisPool.getResource(JedisPool.java:12) at org.springframework.data.redis.connection.jedis.JedisConnectionFactory.fetchJedisConnector(JedisConnectionFactory.java:155) at org.springframework.data.redis.connection.jedis.JedisConnectionFactory.getConnection(JedisConnectionFactory.java:251) at org.springframework.data.redis.connection.jedis.JedisConnectionFactory.getConnection(JedisConnectionFactory.java:58) at org.springframework.data.redis.core.RedisConnectionUtils.doGetConnection(RedisConnectionUtils.java:128) at org.springframework.data.redis.core.RedisConnectionUtils.getConnection(RedisConnectionUtils.java:91) at org.springframework.data.redis.core.RedisConnectionUtils.getConnection(RedisConnectionUtils.java:78) at org.springframework.data.redis.core.RedisTemplate.execute(RedisTemplate.java:178) at org.springframework.data.redis.core.RedisTemplate.execute(RedisTemplate.java:153) at org.springframework.data.redis.core.AbstractOperations.execute(AbstractOperations.java:86) at org.springframework.data.redis.core.DefaultValueOperations.get(DefaultValueOperations.java:43)
i config is
redis.pool.maxTotal=500 redis.pool.maxIdle=200 redis.pool.minIdle=10 redis.pool.maxWait=6000 redis.pool.testOnBorrow=false redis.pool.testOnReturn=false

@andyzty how are you using the JedisPool?

@andyzty  Did you mange to resolve it ?

Closed due to inactivity.

I am getting a below issue, any idea to resolve this issue.
Redis version 3.2.4
Cannot get Jedis connection; nested exception is redis.clients.jedis.exceptions.JedisConnectionException: Could not get a resource from the pool

@gowrisankar22 seems like Jedis can't reach your redis server. JedisConnectionExceptions are for connection problems between Jedis and your Redis instance. Can you check if you can reach the server using the redis CLI?

@marcosnils Yes, connection to redis cli works perfectly fine.
Please check this thread with the details,
https://github.com/xetorthio/jedis/issues/1405#issuecomment-253189148

same problem holds for me as well.
I have 3 masters and 3 slaves running in docker. But unable to connect to the redis server from my java program.
I did Port forward using kubectl to port 7000.
 kubectl port-forward redis-0-334270214-fd4k0 7000:7000
Exception:
> Exception in thread "main" redis.clients.jedis.exceptions.JedisConnectionException: Could not get a resource from the pool
> 	at redis.clients.util.Pool.getResource(Pool.java:53)
> 	at redis.clients.jedis.JedisPool.getResource(JedisPool.java:226)
> 	at redis.clients.jedis.JedisSlotBasedConnectionHandler.getConnectionFromSlot(JedisSlotBasedConnectionHandler.java:66)
> 	at redis.clients.jedis.JedisClusterCommand.runWithRetries(JedisClusterCommand.java:116)

@gowrisankar22 were you able to fix this ?
If yes then please share the solution.
Thanks in advance!

spring.redis.host=<IP_ADDRESS>
#usually localhost, but can also be on a LAN
spring.redis.port =6379
#usually 6379, but settable in redis.conf
When I configured my application.properties with above setup, it worked.

I'm also starting to face this issue using the default config, no solution as of yet. I installed redis through Brew if it makes any difference

getting this issue , how to find this issue all configurations are done properly , and i verified that am able to reach the redis server , but still the issue is comming ,
spring:
redis:
host: trclx2001.hq.target.com
port: 6379
maxActiveConnections: 10
do i need to increase the number of maxActiveConnections ?


Support shared volumes on NFS datastores provisioned to the managed plugin.

@govint Can you write-up a quick proposal on user experience to use shared NFS volume and high level design?

Would like to read the the design proposal for this when its out. So tagging myself @BaluDontu.

Sorry, missed posting the spec to this issue, will update the spec and post it here with comments addressed. Missed that I'd not published here after the review over mail.

Closing per discussion. There isn't a need to support NFS (or rather, non-vSphere storage) in the plugin or even as a separate plugin. There's little value add to have this capability when multiple options exist already to use NFS and more network based storage with Docker.


rails test results in sprockets error

Note: For general questions and feature requests please leave a message
on Gitter: https://gitter.im/comfy/comfortable-mexican-sofa
Expected behavior
Running rails test or bundle exec rails test to run tests.
Actual behavior
A sprockets error is generated:
```/Users/someuser/.rvm/rubies/ruby-2.5.1/lib/ruby/gems/2.5.0/gems/sprockets-rails-3.2.1/lib/sprockets/railtie.rb:105:in block in <class:Railtie>': Expected to find a manifest file in app/assets/config/manifest.js` (Sprockets::Railtie::ManifestNeededError)
But did not, please create this file and use it to link any assets that need
to be rendered by your app:
Example:
//= link_tree ../images
//= link_directory ../javascripts .js
//= link_directory ../stylesheets .css
and restart your server```
Steps to reproduce

Clone the repository and cd into it
Run gem install bundler
Run bundle exec rails test

System configuration
Rails version: 5.2.3
CMS version: n/a
Ruby version: 2.5.1p57

This is caused by changes in sprockets 4, so an app/assets/config/manifest.js file is required (see sprockets/UPGRADING.md). Creating an empty manifest.js solves the issue.


[Timestampable] Fields remain null when using entity managers detach and merge methods

I had a feeling that I have missing some configuration somewhere which is causing this issue, but after spending 2 hours debugging getting no where I'm starting to wonder if it's a bug or expected behaviour.
To keep this example as simplified as possible, I'm creating an Address entity, detaching from the entity manager then merging it back into the entity manager. In the actual app I'm detaching, storing it in the session, then merging it back into the entity manager a few requests later to save it (attempt to reduce DB writes due to low conversion rate). But doing so results in Doctrine trying to write null values to createdAt and updatedAt.
Here are two examples
Working example
$address = new Address();
$address
    ->setLine1('Line 1')
    ->setCity('City')
    ->setPostcode('AB1 2CD');

$em->persist($address);
$em->flush();

SQL Executed on DB:
INSERT INTO addresses (line1, city, postcode, createdAt, updatedAt) VALUES ('Line 1', 'City', 'AB1 2CD', '2015-02-25 14:54:23', '2015-02-25 14:54:23')

Failure when detaching and merging
$address = new Address();
$address
    ->setLine1('Line 1')
    ->setCity('City')
    ->setPostcode('AB1 2CD');

$em->detach($address);

$newAddress = $em->merge($address);
$em->persist($newAddress);
$em->flush();

Resulting SQL:
INSERT INTO addresses (line1, city, postcode, createdAt, updatedAt) VALUES ('Line 1', 'City', 'AB1 2CD', NULL, NULL)

Entity config
Namespace\Entity\Address:
  type: entity
  table: addresses
  id:
    addressId:
      type: integer
      options:
        unsigned: true
      generator:
        strategy: AUTO
  fields:
    line1:
      type: string
      length: 45
    city:
      type: string
      length: 45
    postcode:
      type: string
      length: 45
    createdAt:
      type: datetime
      gedmo:
        timestampable:
          on: create
    updatedAt:
      type: datetime
      gedmo:
        timestampable:
          on: update

Doctrine extensions config (Symfony2)
stof_doctrine_extensions:
  orm:
    default:
      timestampable: true
      softdeleteable: true
      sluggable: true

Anyway I have dug into the code and believe it's to do with this line as it's not had it's property changed:
https://github.com/Atlantic18/DoctrineExtensions/blob/master/lib/Gedmo/Timestampable/TimestampableListener.php#L187

this is interesting, most probably in merged state it behaves differently. Will try to find some time to investigate

Thanks so much for this :) now all working perfectly :+1:

Once again thanks for this, could you advise when this will be in a tagged release?
Can't quite bring myself to deploy an app with dev-master in the composer file :fearful:

Do you have plan to fix this problem ? As the commit is reverted.
Or do we have some workaround ?
Thx

well, I cannot make a fix if it introduces other bugs, could not find any usable workaround.

hmmm this bug is still there. What issues did the fix introduce? Is there a workaround?

Have the same problem.

Problem still exists - merge does not set the fields automatically, even with the annotation. What was the reason this wasn't fixable?


fetchData function

Should retrieve all of the data for use in TypeScript/JavaScript

https://github.com/hypercerts-org/oss-directory/pull/10


As a manager, I can search for customers by phone number

...so I can quickly access customer profiles during phone orders.

Search my phone number via find command completed


.Net4 version throws "Argument types do not match"

Hi
I've made a version build with .Net4 as i need this for some SSIS stuff
I made a few tweaks to the code to adapt to .net4, but nothing major.
Now i get the following error "Argument types do not match"
The error is thrown no matter which expression i give it...
So now i wonder if there were a reson the .net4 support were removed? We used to use version 1.3, and that worked without problems

Hello @larsmarkussen ,
It was removed just for portability to .NET core... But not a technical reason. Also because at that time I was not very export on multi targeting...
If you are able to create a pull request I can try to investigate.


Improve support for AVR and MSP430 custom targets

Fix build error when not using portable_atomic_unsafe_assume_single_core cfg on AVR and MSP430 custom targets.
Since 0.3.11, atomic CAS was supported without the cfg on AVR and MSP430 builtin targets, but that change was not applied to custom targets.

bors r+

FYI @notgull as you seem to have run into this issue.


Default to type=error for entries?

Often makers do not define a type for errors.
Should we default to "error" in that case?
Or rather fix the makers that do not do so, e.g. autoload/neomake/makers/ft/lua.vim?
The signs module defaults to using the error sign for it already.

as a precendent, syntastic assumes Warn, and it is configured for that checker in particular: https://github.com/scrooloose/syntastic/blob/master/syntax_checkers/lua/luacheck.vim#L56
Better to set a default on individual makers

What about a default g:neomake_default_error_type setting (defaulting to 'E'), and allow to override it per maker (although the latter should be probably just fixed by adjusting the errorformat)?


Fix Windows panic on exit from thread_local Client.

The reqwest client is now initialized with once_cell.
See https://stackoverflow.com/questions/66081474

Rebased onto #7 because of failing tests.


Error messages do not help to fix issues

hs@hark-21546:~/Downloads [1] % brew upgrade
Warning: Calling 'depends_on :python3' is deprecated!
Use 'depends_on "python3"' instead.
/usr/local/Homebrew/Library/Taps/rene-dev/homebrew-sigrok/libsigrokdecode.rb:12:in `<class:Libsigrokdecode>'
Please report this to the rene-dev/sigrok tap!

==> Upgrading 49 outdated packages, with result:
lame 3.100, homebrew/nginx/openresty <IP_ADDRESS>, libuv 1.19.1, mame 0.194, python 2.7.14_3, p7zip 16.02_1, redis 4.0.8, par2 0.8.0, boost 1.66.0, openjpeg 2.3.0, gtksourceview3 3.24.6, maven 3.5.2, carthage 0.28.0, dbus 1.12.4, binutils 2.30, webp 0.6.1, libxmlsec1 1.2.25, libgcrypt 1.8.2, xctool 0.3.4, platformio 3.5.1, libav 12.2_1, libvpx 1.7.0, asciidoc 8.6.10_1, vtk 8.1.0, gawk 4.2.0_1, librsvg 2.42.2, gcc@6 6.4.0_1, jbig2dec 0.14, netcdf 4.6.0, libtasn1 4.13, oniguruma 6.7.1, sip 4.19.7_1, py2cairo 1.16.1, x264 r2854, crosstool-ng 1.23.0_1, doxygen 1.8.14, faac <IP_ADDRESS>, node 9.5.0, libzip 1.4.0, openmotif 2.3.8, poppler 0.62.0, sdl2 2.0.7, imagemagick 7.0.7-22, p11-kit 0.23.9, ruby 2.5.0, pyqt 5.10, git 2.16.1, gnutls 3.5.17, packer 1.2.0
==> Upgrading packer
==> Downloading https://homebrew.bintray.com/bottles/packer-1.2.0.high_sierra.bo
==> Downloading from https://akamai.bintray.com/ad/ad2106a8f12ecadacb7cc2fbfaa2d
######################################################################## 100.0%
==> Pouring packer-1.2.0.high_sierra.bottle.tar.gz
==> Caveats
zsh completions have been installed to:
  /usr/local/share/zsh/site-functions
==> Summary
🍺  /usr/local/Cellar/packer/1.2.0: 7 files, 86.4MB
==> Upgrading homebrew/nginx/openresty
==> Downloading https://openresty.org/download/openresty-<IP_ADDRESS>.tar.gz
Already downloaded: /Users/hs/Library/Caches/Homebrew/openresty-<IP_ADDRESS>.tar.gz
Error: Formulae found in multiple taps:
       * denji/nginx/openresty-openssl
       * homebrew/nginx/openresty-openssl

Please use the fully-qualified name e.g. denji/nginx/openresty-openssl to refer the formula.
hs@hark-21546:~/Downloads [1] %   brew untap denji/nginx/openresty-openssl
  Error: Invalid tap name 'denji/nginx/openresty-openssl'
hs@hark-21546:~/Downloads [1] %

This is not helpful.
Why the untap based on output does not work?

Please note we will close your issue without comment if you delete, do not read or do not fill out the issue checklist below and provide ALL the requested information. If you repeatedly fail to use the issue template, we will block you from ever submitting issues to Homebrew again.


Selenium Test for User Registration

Write a selenium test to verify a user can register. Only test the happy path.

The base framework for automation test cases has been established and basic registration success flow test scenario has been covered and completed.


Migration component timeout.coffee

Any italic text should be deleted from the final Pull Request text, including this line
Description
This pull request has been created with a markdown document for the component "timeout.coffee" by reviewing the project task migration timeout. coffee.
This allows all users to notify they have been distracted from the system for specific time and allows them to take actions regarding their purposes.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as
expected)
[x] Documentation (update or new)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have requested a review from ... on the Pull Request

@TedWang will be reviewing this


shotcut: move to by-name, reformat, add wl support

Description of changes

shotcut: move to by-name
shotcut: nixfmt
shotcut: add wayland platform support

fixes #296172

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 333721 run on x86_64-linux 1

1 package built:

shotcut


consider dropping nc wrapper

This wrapper was created for a change of nc(1)'s -N behaviour in FreeBSD 10
Given that FreeBSD 10 has been EOL for some time now, perhaps we can drop that now.

Sure. It's not harming anything though.


feat: get app version and display in header

Get the version of the app and of Knora and display them somewhere.

There's an issue with reading the header information from Knora api....

 Kuirl: server infos


[SPIR-V codegen] Fix vectorization condition for generic op

I forgot to mention this in the review, but maybe we need a test here to catch regression?

I forgot to mention this in the review, but maybe we need a test here to catch regression?

Yeah I was thinking about that. We don’t have much test for the kernel configuration right now, most likely we would need some pipeline test. There was already vectorization tests but they wouldn’t catch this case as it is coming from the shape information being lost during compilation. I think adding a pipeline test might make sense, I’ll look at it


updated a small info about docker

Why:
Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

the information that's being added is about what docker is

Check off the following:

[*] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
[ *] For content changes, I have completed the self-review checklist.

@DUMBANIKET Thanks for submitting a PR! Would you mind adding a bit more information to your post? Such as, why do you feel this addition is beneficial to the article? Any additional context will be helpful during the review! ✨

The contribution was a bit small but I think contribution means just contributing your part on what you can
So basically the change i did was in the docker documentation where the details about what docker actually is was missing , i just added a small information about what docker is the ,

Merge the pr :)


Prevent click events from slider item if the user is only dragging

I have a slider with clickable items, when i try to drag the slider the click event is triggered immediately, can you please fix it ?

@sholzer Are you using the latest version?

yes i'm using v1.9.1

Just noticed that it only occurs on the first and last item:
https://codesandbox.io/p/sandbox/blaze-slider-link-test-ngstwb?file=%2Fsrc%2FApp.vue


Do not exit script until Relocating MOOV atom is complete

I'm using sickbeard_mp4_automator with SABnzbd to manually convert MKV to MP4 files using a custom postprocess script that calls on manual.py. I have Completed Download Handling turned on in Radarr to process the file. I find that this is more reliable than than having sickbeard_mp4_automator call Radarr to process the file. However, I notice that Relocating MOOV atom is occurring, the script exits. Radarr then thinks the file processing is complete and attempts to import the file before Relocating MOOV atom is complete.
Is there anyway to not exit the script until Relocating MOOV atom is complete?

Script should not be exiting while the moov atom move is taking place. What makes you say it's exiting?
Sent from my iPhone

On Feb 21, 2017, at 00:13, scoopydude2002<EMAIL_ADDRESS>wrote:
I'm using sickbeard_mp4_automator with SABnzbd to manually convert MKV to MP4 files using a custom postprocess script that calls on manual.py. I have Completed Download Handling turned on in Radarr to process the file. I find that this is more reliable than than having sickbeard_mp4_automator call Radarr to process the file. However, I notice that Relocating MOOV atom is occurring, the script exits. Radarr then thinks the file processing is complete and attempts to import the file before Relocating MOOV atom is complete.
Is there anyway to not exit the script until Relocating MOOV atom is complete?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I did some more testing and you're right. I had some issues with Radarr importing movies that I thought it was related to this. But the script is working as expected. Thanks!


Black Icons become gray in Ubuntu

Describe the bug
I'm using the Avalonia.IconPacks package to add some icons to my buttons. In windows, the icons are black, but in Ubuntu, they become gray without changing anything in the code.
To Reproduce

Add the icons package
Add a button with an icon as the content
Run in Windows & Ubuntu and see the difference

Expected behavior
The icons should stay black.
Screenshots
Windows:

Ubuntu:

Desktop (please complete the following information):

OS: Windows 10 & Ubuntu 21.04 Desktop (on VirtualBox)
Version [latest]

My buttons are simply:
<Button Classes="Rounded"
        Width="48"
        Height="48"
        Click="ShowAccountsWindow">
  <avalonia:MaterialIcon Kind="Accounts" Width="60" Height="25" />
</Button>

The Rounded style only adds a border radius.

Another problem is with brushes:
Windows:

Ubuntu:

This is while I'm using:
var obstacleCellBrush = new ImmutableSolidColorBrush(Colors.Gray)

Also, this looks like a transparency issue. Ubuntu has a much higher transparency. Perhaps the byte ordering is incorrect somewhere.


fix message structure from intent

Fixes https://github.com/flutter/flutter/issues/23148

@pepegich Thanks you for your contribution. I'd like to merge it, but first I need you to agree to the Contributor License Agreement (CLA). Could you please do that? Thanks!

I signed it!

@pepegich Thanks you for your contribution. I'd like to merge it, but first I need you to agree to the Contributor License Agreement (CLA). Could you please do that? Thanks!

@collinjackson I do it!

By reading the changelog of this breaking change, I though that the message structure of the onMessage map has changes but by looking at the code it is the other way round.

Breaking Change Update message structure for onMessage to match onLaunch and onResume

This was a little bit misleading since we only use the onMessage callback and we didn't see any change after updating to this release. Could you please check if the changelog is correct?

@grundid seems need change log to:

Breaking Change Update message structure for onResume and onLaunch to match onMessage

I'm still having #23148 problem, isnt fixed yet?

This PR was merged awhile ago -- please file a new issue with steps to reproduce if you're seeing problems.


Cleanup 0.6

Just refactoring of the library files to tidy up a bit the code base and allow more deep refactor/rework in next versions.

Can we merge this?

@lucagiove looks good to merge to  me.


Mega pull request (Modnotes, Modmail, and wiki)

I'm coallescing my pull requests into a single request, as It's at the point where I'm having to reimplement the same thing several times. I'd also like to push forward with creating unit tests, which may require some additional dependencies. To see any previous discussions, see #83 , #87 , #94 .
Features

New modmail controller that exposes the following

modmail.getConversations( subreddit, after?, limit?, sort?, state? ), to fetch an array of recent conversations. These are minimally detailed.
modmail.createNewConversation
modmail.getConversation( conversationID, markRead), to fetch a modmail conversation in detail. This makes use of an extended class to add these extra details
modmail.approveParticipant( conversationID )
modmail.archiveConversation( conversationID )
modmail.disapproveParticipant( conversationID )
modmail.highlightConversation( conversationID )
modmail.unhighlightConversation( conversationID )
modmail.muteParticipant( conversationID, duration )
modmail.tempBanParticipant( conversationID, duration)
modmail.unarchiveConversation( conversationID )
modmail.unbanParticipant( conversationID )
modmail.unmuteParticipant( conversationID )
modmail.getSubreddits( )
modmail.markAsRead
modmail.markAsUnread
modmail.getUnreadCount

A ModmailConversation class to handle these new functions, along with data sent back by reddit
A ModmailConversationDetailed class to handle conversations where extra details have been fetched, including messages, moderator actions, etc. This class extends ModmailConversation
New Modnote controller that exposes the following

modnote.deleteNote( id, subreddit, user )
modnote.getNotes( subreddit, user, filter?, limit? before? ) for fetching notes made on a user
modnote.createNote( subreddit, user, note, label?, redditID?) for creating a note
modnote.getRecent()
modnote.getSubreddit utility function
modnote.getUser utility function
modnote.getOperator utility function
modnote.getContent utility function

The ModeratorNote class for dealing with individual moderator notes OOP.
New Wiki controller that exposes the following

wiki.addEditor
wiki.removeEditor
wiki.editPage
wiki.toggleVisibility
wiki.revertPage
wiki.getPages
wiki.getRecentChanges
wiki.getRecentChangesForPage
wiki.getSettings
wiki.changeSettings
wiki.getPage

A Wiki class for dealing with individual wiki pages OOP
Listing classes for wiki revisions

Not yet implemented

[ ]  modmail.replyToConversation.

Weird stuff
For the life of me, I can't seem to get the api/mod/bulk_read API endpoint to return anything other than Error 404. It remains implemented in modmail.bulkMarkRead, but as far as I can tell, this endpoint no longer exists.
Hope to get some feedback on this. Seems to be taking ages to get this pull requests looked at though.

Non-breaking change
Added dotenv and dotenv-expand as development dependencies to allow for unit tests to be published without exposing secrets.

Non-breaking change
Implement modmail.highlightConversation( conversationID )

Please do not create mega pull requests. If you are implementing multiple features they should each have their own PR. The larger a PR is the harder it is to review and adjust. If you need to use some base changes in multiple of your PRs then create one base PR with those common changes, and have your other PRs branch off of that.

Additionally, regarding commit messages:

Please do not use [skip ci] unless absolutely necessary (it virtually never is).
Please only use feat:, fix:, and perf: for changes that are exposed to the user of this package. For example, Gateway::delete() is an internal method, so adding it isn't a new feature. It should be a chore.

Skipped CI because of the new unit tests I added not having secrets loaded, and didn't wish to get spammed with emails. It's a shame this is closed, as I feel I had added a good chunk to the library, but I understand if you would rather not merge someone else's work.

Other reason for the bundling of the PR was my merging into my own main branch changing the already-made pull requests that seemingly hadn't had much attention. I don't know how to undo this, so I remade this one, which made sense. I'm not going to spend any time trying to separate out these commits into different branches.

I understand if you would rather not merge someone else's work.

I'm absolutely fine with merging other people's work, but I do this in my free time, of which I have precious little. Large PRs like this one are way harder to review properly, which means they take more of my time, and thus are far less likely to be reviewed and approved in a timely manner.

Skipped CI because of the new unit tests I added not having secrets loaded, and didn't wish to get spammed with emails.

Unit tests shouldn't needs secrets, and e2e tests are currently blocked by trying to figure out a way to do it without running into the rate limit (see #11).

I'm not going to spend any time trying to separate out these commits into different branches.

That's a shame. If you are able to open smaller PRs I'd happily merge them. If not, would you be willing to let me do so? I'm perfectly happy to split the commits myself, provided I can also make any small tweaks that are needed to fit the project's goals. You'd be credited, of course.

I can also see how that last reply seems to conflict with the first, so let me explain: reviewing a PR of this size is hard, because if I find any changes that need to be made (code, docs, commits, etc.) I need to:

identify that a change needs to happen
identify what the change is
determine if it's worth asking the contributor to do, or it can be merge as-is and fixed later
find a way to communicate the desired change to the contributor
wait for them to make the change
review the new changes, starting over at step 1
repeat until there are finally no more pending changes

The feedback loop on that is slow and imprecise. It works fine for simple changes, so smaller PRs are totally fine, but on a PR of this size it's quite slow, which is a drag for both of us—we both want it to be merged, after all!
Doing the work myself though, using your work as a starting point means I can replace steps 3-7 with just "make the change myself", which is way faster.

I'm absolutely fine with merging other people's work, but I do this in my free time, of which I have precious little. Large PRs like this one are way harder to review properly, which means they take more of my time, and thus are far less likely to be reviewed and approved in a timely manner.

I understand, however, the merging of these pull requests was in part due to the fact that the smaller ones were not looked at.

Unit tests shouldn't needs secrets, and e2e tests are currently blocked by trying to figure out a way to do it without running into the rate limit (see https://github.com/thislooksfun/snoots/issues/11).

Regardless of the name you want to call it by, that's the reason for the [skip ci] tag on those commits. As you didn't want to talk on discord, I had no way to ask you about it.

That's a shame. If you are able to open smaller PRs I'd happily merge them. If not, would you be willing to let me do so? I'm perfectly happy to split the commits myself, provided I can also make any small tweaks that are needed to fit the project's goals. You'd be credited, of course.

There were smaller PRs open, which weren't happily merged. Equally, what is the difference between you doing the changes yourself and keeping the pull request open? Keeping the pull request open would be much more transparent, surely.

I can also see how that last reply seems to conflict with the first, so let me explain: reviewing a PR of this size is hard, because if I find any changes that need to be made (code, docs, commits, etc.) I need to:

The other pull requests can easily be found by following the links in the first comment, or in the "closed" tab on the pull requests screen. They are smaller.

The feedback loop on that is slow and imprecise. It works fine for simple changes, so smaller PRs are totally fine, but on a PR of this size it's quite slow, which is a drag for both of us

Again, this pull request contains the same commits as those previously. You would be reviewing the same quantity of code.

we both want it to be merged, after all!

I'm genuinely not so sure. I tried to get in touch with you in several different ways and have heard nothing.

Doing the work myself though, using your work as a starting point means I can replace steps 3-7 with just "make the change myself", which is way faster.

Please see comments on transparency made above

I understand, however, the merging of these pull requests was in part due to the fact that the smaller ones were not looked at.

Again, I have limited time where I am both not engaged with some other commitment and have the focus and motivated needed to review PRs. I am a software developer for my full-time job, so when I get off work usually the last thing I want to do is more code review. Because of that I usually review longer PRs (like all of the ones listed) on the weekends, when I have more motivation. #83 and #87 were last updated 4 days ago, and #94 was created yesterday. I was planning to start reviewing them today, but they were all closed before I got a chance to do so.

Regardless of the name you want to call it by, that's the reason for the [skip ci] tag on those commits. As you didn't want to talk on discord, I had no way to ask you about it.

Talking to me on Discord has nothing to do with this. The fact that those commits were breaking tests should have been the signal that they were not a good fit to be merged.

There were smaller PRs open, which weren't happily merged. Equally, what is the difference between you doing the changes yourself and keeping the pull request open? Keeping the pull request open would be much more transparent, surely.

I detailed the difference in my last message. Since you seem to be so focused on getting things done quickly, I thought you would appreciate the quicker solution. If you really want to go down the single giant PR route, I will re-open this and review it properly, but there's a good chance it will take several review sessions, which means it will likely take several weeks to get merged.

The other pull requests can easily be found by following the links in the first comment, or in the "closed" tab on the pull requests screen. They are smaller.

Yes, and since you closed them I now can't review them in that smaller form.

Again, this pull request contains the same commits as those previously. You would be reviewing the same quantity of code.

Overall it's the same quantity, yes, but the portioning matters. There's a difference between eating an entire cake in one sitting vs eating it one slice at a time over several days.

I'm genuinely not so sure. I tried to get in touch with you in several different ways and have heard nothing.

You mentioned me in a couple places within a day or two of creating the PR in the first place. That's not "several different ways", and in the world of free open source software, that's a really short turnaround time. Again, I am doing this in my spare time because I want to. I have no obligations to update this (or any of my other projects), and no hard timelines to stick to, so I take my time with them to make sure they are done right while preventing me from burning out. I get that it's frustrating to not have your PRs merged instantly, but unless a project is being worked on full-time, it's gonna take a few days (at least) sometimes.

I'll need a few days as I'll need to recreate the PR. In meantime, please do check your email, or chat on discord. Would make all of this easier.


Better CI test results

Testing some azure stuff for better CI test results. Mainly:

I don't like why pytest-azurepipelines does with warnings
I'd like to have test coverage

Azure's is a bit meh (no diffs), maybe we should use codecovs (example usage)

I like having the test results be easy to read

I think I'll leave codecov to a separate PR, since this immediately improves test reporting.

I think I'll leave codecov to a separate PR, since this immediately improves test reporting.


Add Tags Expression

I would like to use Tag Expression. The old way with coma is now deprecated.
https://docs.cucumber.io/tag-expressions/

I can do it, will you accept me the pull request or should i fork this project? It seems to be a death?

Pull request is prepared... i will close this issue immediately after the release.


Generate XCode style UUIDs

Context 🕵♀
We are using XCodeGen to generate projects.
We are also using the famous sort script from apple to keep our project file sorted and reduce the chances of merge conflicts.
What 🌱
After generating a project using XCodeGen, we ran the sort scripts and found it failed on line 171. The UUID was not found on a line.
Tracking this down, it looks like this is because XCodeProj generates UUIDs of the format AAA_123456789123_1 (where AAA is an acronym for the portion of the project file the reference is being generated for and the final _1 is if a reference is already taken).
Proposal 🎉
Please generate UUIDs in the same format that XCode does in order to keep other tools that make assumptions about the format of UUIDs working. Or provide an option to generate as XCode would.
To achieve this, I imagine you could perform a 24 or 32 byte hash operation on the reference variable, here: https://github.com/tuist/xcodeproj/blob/b1f131b8614a1846b165baa02d7162a3c949ba21/Sources/xcodeproj/Utils/ReferenceGenerator.swift#L299

Closing - completely our fault, we are on old XCodeGen and therefore old XCodeProj. Appologies for the noise!

Actually, updating XCodeGen (which uses the latest XCodeProj) we still are getting UUIDs that look like "AAA_123456789". Is that expected?

cc @yonaskolb

Closing this one in favor of https://github.com/tuist/xcodeproj/issues/392


Revert "feat(pointcloud_preprocessor): use point_cloud_msg_wrapper"

Reverts autowarefoundation/autoware.universe#1276

What is the reason for reverting this change?

I see it's for https://github.com/autowarefoundation/autoware.universe/issues/2306

I think it's ok, it's better to add point_cloud_msg_wrapper feature once we finalize the point types architecture in here and allow different point types too.


3rd party review or self-assessment?

Is this model meant to be a self-assessment? Or a third-party assessment? If it's a self-assessment, a lot of this language could be alienating.

This language was originally used by the digital service as part of a discovery sprint but was openly shared with the partner agency as the work was completed. There was additional context and explanation surrounding this table that may help deliver it in a constructive format. It could also be self-assessment, but that wasn't the original intent.


Add filtering functionality and refactor the codebase

Pull Request Template
Description
Add filtering functionality and refactor the code.
Mainly includes the following:

[x] use dynamic arrays to store vmem areas and symbols
[x] fix the plt stub address problem when using clang or musl-gcc
[x] support filtering observed functions based on name, libname (glob format), stack depth and consumed time
[x] fix the problem of stack recording in multi-thread environment by utilizing thread local storage
[x] add a flat format
[x] add more error handers and refactor the codebase

Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
$ cat test/strcpy.c
#include <stdlib.h>
#include <string.h>
int main() {
  char *s = "Hello!";
  char *t = malloc(15 * sizeof(char));
  int m = strlen(s);
  memcpy(t, s, m);
  int n = strlen(t);
  int ss = strlen(s) + strlen(t);
  memset(t, 0, n);
  free(t);
  t = malloc(12 * sizeof(char));
  free(t);
  return 0;
}
$ clang test/strcpy.c -o test/strcpy
$ sudo build/utrace -c test/strcpy --flat > /dev/null
Tracing...
==============================
→ [0] main
↔ [1] malloc [350.504 us]
↔ [1] strlen [62.300 us]
↔ [1] memcpy [43.500 us]
↔ [1] strlen [47.900 us]
↔ [1] strlen [40.101 us]
↔ [1] strlen [40.400 us]
↔ [1] memset [41.500 us]
↔ [1] free [43.001 us]
↔ [1] malloc [39.600 us]
↔ [1] free [40.600 us]
← [0] main [+1.286 ms]
==============================
Detaching...
$ sudo build/utrace -c test/strcpy -f "m*" -f "strlen" --libname --time-filter 20ns > /dev/null
Tracing...
==============================
  DURATION  |   FUNCTION CALLS
            | main() {
 230.801 us |   malloc@libc.so.6();
  39.300 us |   strlen@libc.so.6();
  27.900 us |   memcpy@libc.so.6();
  26.100 us |   strlen@libc.so.6();
  25.901 us |   strlen@libc.so.6();
  26.300 us |   strlen@libc.so.6();
  27.000 us |   memset@libc.so.6();
  26.100 us |   malloc@libc.so.6();
 732.503 us | } /* main */
==============================
Detaching...

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

我在之后的PR中再完善README、代码注释以及测试套件。

后面尽量小 pr 提交，大 pr review 起来很费力

明白


Support GCE Persistent SSD for root/data disks

This allows using Persistent SSD disks for either root or data disks and is supported in the current version of fog used in the plugin.

Minor indentation issue that can be ignored, otherwise LGTM.


runtime: SIGABRT with while fuzzing

What version of Go are you using (go version)?
1.9
Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
GOOS=darwin
GOARCH=amd64
What did you do?
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
Running the following through go-fuzz
package fuzz

import (
	"fmt"

	"github.com/ericlagergren/decimal"
)

func Fuzz(data []byte) int {
	runtime.SetTraceback("all")

	d := new(decimal.Big)
	d.Context.OperatingMode = decimal.GDA
	d, ok := d.SetString(string(data))
	if !ok {
		if decimal.Regexp.Match(data) && d.Err() == nil {
			panic(fmt.Sprintf("should work: %q", data))
		}
		return 0
	}
	d2 := new(decimal.Big)
	d2.Context.OperatingMode = decimal.GDA
	d2, ok = d2.SetString(d.String())
	if !ok {
		panic(fmt.Sprintf("SetString(%q) == nil, false"))
	}
	if d.Cmp(d2) != 0 {
		panic(fmt.Sprintf(`
got   : %#v (%q)
wanted: %#v (%q)
`, d2, d2, d, d))
	}
	if !decimal.Regexp.Match(data) {
		panic(fmt.Sprintf("got: %q", data))
	}
	return 1
}

What did you expect to see?
Program run normally.
What did you see instead?
program hanged (timeout 10 seconds)

SIGABRT: abort
PC=0x105265b m=0 sigcode=0

goroutine 0 [idle]:
runtime.mach_semaphore_wait(0x803, 0x0, 0x7fff5fbff340, 0x102044a, 0x120dc20, 0x1206a40, 0x7fff5fbff348, 0x104d093, 0xffffffffffffffff, 0x0, ...)
	/var/folders/t8/1vtf9x6j6sg1hpxpzhgfkflm0000gn/T/go-fuzz-build498706011/goroot/src/runtime/sys_darwin_amd64.s:445 +0xb
runtime.semasleep1(0xffffffffffffffff, 0x0)
	/var/folders/t8/1vtf9x6j6sg1hpxpzhgfkflm0000gn/T/go-fuzz-build498706011/goroot/src/runtime/os_darwin.go:413 +0x52
runtime.semasleep.func1()
	/var/folders/t8/1vtf9x6j6sg1hpxpzhgfkflm0000gn/T/go-fuzz-build498706011/goroot/src/runtime/os_darwin.go:432 +0x33
runtime.systemstack(0x7fff5fbff370)
	/var/folders/t8/1vtf9x6j6sg1hpxpzhgfkflm0000gn/T/go-fuzz-build498706011/goroot/src/runtime/asm_amd64.s:360 +0xab
runtime.semasleep(0xffffffffffffffff, 0x7fff00000000)
	/var/folders/t8/1vtf9x6j6sg1hpxpzhgfkflm0000gn/T/go-fuzz-build498706011/goroot/src/runtime/os_darwin.go:431 +0x44
runtime.notesleep(0x1207050)
	/var/folders/t8/1vtf9x6j6sg1hpxpzhgfkflm0000gn/T/go-fuzz-build498706011/goroot/src/runtime/lock_sema.go:167 +0xe9
runtime.stopm()
	/var/folders/t8/1vtf9x6j6sg1hpxpzhgfkflm0000gn/T/go-fuzz-build498706011/goroot/src/runtime/proc.go:1670 +0xe5
runtime.findrunnable(0xc420020000, 0x0)
	/var/folders/t8/1vtf9x6j6sg1hpxpzhgfkflm0000gn/T/go-fuzz-build498706011/goroot/src/runtime/proc.go:2125 +0x4d2
runtime.schedule()
	/var/folders/t8/1vtf9x6j6sg1hpxpzhgfkflm0000gn/T/go-fuzz-build498706011/goroot/src/runtime/proc.go:2245 +0x12c
runtime.exitsyscall0(0xc420000180)
	/var/folders/t8/1vtf9x6j6sg1hpxpzhgfkflm0000gn/T/go-fuzz-build498706011/goroot/src/runtime/proc.go:2809 +0x10e
runtime.mcall(0x7fff5fbff550)
	/var/folders/t8/1vtf9x6j6sg1hpxpzhgfkflm0000gn/T/go-fuzz-build498706011/goroot/src/runtime/asm_amd64.s:286 +0x5b

goroutine 1 [runnable]:
math/big.nat.norm(0xc4a92cc000, 0xa6b7, 0xa6bb, 0xc4a91da000, 0xa6b6, 0x1e004)
	/var/folders/t8/1vtf9x6j6sg1hpxpzhgfkflm0000gn/T/go-fuzz-build498706011/goroot/src/math/big/nat.go:43 +0xfa
math/big.nat.mulAddWW(0xc4200186f0, 0x1, 0x5, 0xc4a91da000, 0xa6b6, 0x1e004, 0x497cc8fe5aa45962, 0x0, 0x0, 0x103b5f7, ...)
	/var/folders/t8/1vtf9x6j6sg1hpxpzhgfkflm0000gn/T/go-fuzz-build498706011/goroot/src/math/big/nat.go:179 +0x209
math/big.nat.mul(0xc4200186f0, 0x1, 0x5, 0xc4a91da000, 0xa6b6, 0x1e004, 0xc4200186f0, 0x1, 0x5, 0x1, ...)
	/var/folders/t8/1vtf9x6j6sg1hpxpzhgfkflm0000gn/T/go-fuzz-build498706011/goroot/src/math/big/nat.go:402 +0xca3
math/big.nat.mul(0xc4200186f0, 0x1, 0x5, 0xc4200186f0, 0x1, 0x5, 0xc4a91da000, 0xa6b6, 0x1e004, 0x0, ...)
	/var/folders/t8/1vtf9x6j6sg1hpxpzhgfkflm0000gn/T/go-fuzz-build498706011/goroot/src/math/big/nat.go:398 +0xd5b
math/big.(*Int).Mul(0xc42000a160, 0xc42000a160, 0xc420071d00, 0xa6b6)
	/var/folders/t8/1vtf9x6j6sg1hpxpzhgfkflm0000gn/T/go-fuzz-build498706011/goroot/src/math/big/int.go:156 +0xa0
github.com/ericlagergren/decimal/internal/arith/checked.MulBigPow10(0xc42000a160, 0xc4000c8bc8, 0x0)
	/var/folders/t8/1vtf9x6j6sg1hpxpzhgfkflm0000gn/T/go-fuzz-build498706011/gopath/src/github.com/ericlagergren/decimal/internal/arith/checked/checked.go:105 +0x147
github.com/ericlagergren/decimal.(*Big).Cmp(0xc46f98bf80, 0xc46f99c000, 0xc8bdb)
	/var/folders/t8/1vtf9x6j6sg1hpxpzhgfkflm0000gn/T/go-fuzz-build498706011/gopath/src/github.com/ericlagergren/decimal/decimal.go:434 +0xa98
github.com/ericlagergren/decimal/fuzz/SetString.Fuzz(0x12c7000, 0x1a, 0x200000, 0x3)
	/var/folders/t8/1vtf9x6j6sg1hpxpzhgfkflm0000gn/T/go-fuzz-build498706011/gopath/src/github.com/ericlagergren/decimal/fuzz/SetString/SetString.go:25 +0x195
go-fuzz-dep.Main(0x1158318)
	/var/folders/t8/1vtf9x6j6sg1hpxpzhgfkflm0000gn/T/go-fuzz-build498706011/goroot/src/go-fuzz-dep/main.go:49 +0xad
main.main()
	/var/folders/t8/1vtf9x6j6sg1hpxpzhgfkflm0000gn/T/go-fuzz-build498706011/gopath/src/github.com/ericlagergren/decimal/fuzz/SetString/go.fuzz.main/main.go:10 +0x2d

rax    0xe
rbx    0x1206f40
rcx    0x7fff5fbff2e8
rdx    0x7fff5fbff370
rdi    0x803
rsi    0x1
rbp    0x7fff5fbff320
rsp    0x7fff5fbff2e8
r8     0x0
r9     0x0
r10    0x0
r11    0x286
r12    0x44fa88b64bbd
r13    0x4811b1b19080
r14    0x14e7ce67a988fa00
r15    0x71
rip    0x105265b
rflags 0x286
cs     0x7
fs     0x0
gs     0x0
exit status 2

I've a feeling this has to do with allocating too much memory, but I just wanted to make sure. I get this with some regularity while fuzzing, usually while creating a large (ish) decimal like<PHONE_NUMBER>648829282e822216, but that's not to say there aren't even larger decimals created at other times during the fuzzing.

We need more information.  I don't see a bug here; I see a program that running normally but was killed because it ran for more than 10 seconds.  Are you saying that the program should have terminated sooner?

Right, this issue gave me pause enough to create an issue here. What more information is needed to determine whether this is an actual bug or just an overreaction on my part?

The fuzzer doesn't really use the runtime much.  It just calls your function with different inputs.  So the first step would be to figure out which input the fuzzer is passing to your code.  Then figure out what your code is doing with that input.  Why did it take more than 10 seconds?  It should be possible to recreate the problem without the fuzzer being involved at all.


Fix paths on windows

Hey there! Thanks for providing this preset. Couldn't help but notice that it currently does not work well (or well, at all) on windows as

the moduleName is not correctly parsed on windows
imports aren't correctly converted to posix paths on windows.

Will create a pr in a minute or so, hope that helps to enable windows users to use this preset as well.

Hello, do you mind trying this alpha version and letting me know if it fixes your problems:
yarn add -D @eddeee888/gcg-typescript-resolver-files@pr67-run91-1

If you get any unexpected errors, please post what you get vs what you expect here :)

Hi @JustusFluegel , is this still an issue in later versions? :)

@eddeee888 I just started using this plugin and I'm on windows atm and haven't seen any issues.

Awesome, thanks for confirming @RichiCoder1 ! I'll close this for now.
We now have tests in CI for windows too so we'll catch Windows issues earlier 🙂


Steam store page 'About game' translation

Currently, Steam text on the Store page is always on English. This can be addressed to support at least same languages as in the game.
Example:

Translated the about page in all supported languages on steam

Only thing that isn't translated is the images which still have english text, but this could be it's own seperate issue


[wasm] Define CMake options for stdlib explicitly for Darwin host build

The stdlib build for wasm target is failing on Darwin host due to default values of some CMake options on Darwin host. We need to explicitly define these options to make the build pass.

@swift-ci smoke test

@swift-ci test WebAssembly


Little issue (Line 419 (item) in tradebot script not defined)

topic
screenshot: http://i.epvpimg.com/YHQJh.png

Am I missing something here? This isn't related to node-steam and seems to be a personal project of yours, go post on stack overflow or something, this isn't a helpdesk.

Annnddddd @seishun beat me to it.


Скласти таймлайн

Скласти список всіх (важливих) життєвих подій, визначних дат, досягнень, періодів, що дали приємний і неприємний досвід, тощо. В цьому конкретному випадку довгих списків не буває, натомість бувають погано згорнуті, тому пакуємо сюди все підряд, а про "лишні" події можна буде промовчати пізніше. Список повинен бути систематизованим і посортованим в такий спосіб, щоб читач швидко зрозумів "паттерн" і міг легко орієнтуватись в просторі і часі цього резюме.

Donald John Trump (born June 14, 1946) is the 45th and current president of the United States. Before entering politics, he was a businessman and television personality.
Trump was born and raised in Queens, a borough of New York City, and received a bachelor's degree in economics from the Wharton School. He took charge of his family's real-estate business in 1971, renamed it The Trump Organization, and expanded its operations from Queens and Brooklyn into Manhattan. The company built or renovated skyscrapers, hotels, casinos, and golf courses. Trump later started various side ventures, mostly by licensing his name. He produced and hosted The Apprentice, a reality television series, from 2003 to 2015. As of 2020, Forbes estimated his net worth to be $2.1 billion.[a]
Trump entered the 2016 presidential race as a Republican and defeated 16 other candidates in the primaries. His political positions have been described as populist, protectionist, and nationalist. Despite not being favored in most forecasts, he was elected over Democratic nominee Hillary Clinton, although he lost the popular vote. He became the oldest first-term U.S. president,[b] and the first without prior military or government service. His election and policies have sparked numerous protests. Trump has made many false or misleading statements during his campaign and presidency. The statements have been documented by fact-checkers, and the media have widely described the phenomenon as unprecedented in American politics. Many of his comments and actions have been characterized as racially charged or racist.
During his presidency, Trump ordered a travel ban on citizens from several Muslim-majority countries, citing security concerns; after legal challenges, the Supreme Court upheld the policy's third revision. He enacted a tax-cut package for individuals and businesses, rescinding the individual health insurance mandate. He appointed Neil Gorsuch and Brett Kavanaugh to the Supreme Court. In foreign policy, Trump has pursued an America First agenda, withdrawing the U.S. from the Trans-Pacific Partnership trade negotiations, the Paris Agreement on climate change, and the Iran nuclear deal. During increased tensions with Iran, he ordered the killing of Iranian general Qasem Soleimani. He imposed import tariffs triggering a trade war with China, recognized Jerusalem as the capital of Israel, and withdrew U.S. troops from northern Syria to avoid Turkey's offensive on American-allied Kurds.
A special counsel investigation led by Robert Mueller found that Trump and his campaign welcomed and encouraged Russian foreign interference in the 2016 presidential election under the belief that it would be politically advantageous, but did not find sufficient evidence to press charges of criminal conspiracy or coordination with Russia. Mueller also investigated Trump for obstruction of justice, and his report neither indicted nor exonerated Trump on that count. A 2019 House of Representatives impeachment inquiry found that Trump solicited foreign interference in the 2020 U.S. presidential election from Ukraine to help his re-election bid and then obstructed the inquiry itself. The House impeached Trump on December 18, 2019, for abuse of power and obstruction of Congress. The Senate acquitted him of both charges on February 5, 2020.


fatal error: 'portaudio.h' file not found

need help

sudo apt-get install portaudio19-dev

On 28-Dec-2016, at 3:32 PM, theRocc<EMAIL_ADDRESS>wrote:
sudo apt-get install portaudio19-dev
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/HackerHouseYT/AI-Smart-Mirror/issues/23#issuecomment-269455040, or mute the thread https://github.com/notifications/unsubscribe-auth/AUBjXx2HecMfm80yF52S7_p6e_mNFCOOks5rMjOygaJpZM4LUOqR.

thank you
but i figured it out and program is running very god except the weather api
and i wanted help about home automation using raspberry pi without using womo like products more like a wifi accessed relay or somthing and accessing it over voice commands of amazon alexa or our magic mirror AI commands like mirror turn on the lights  plz help .. its kind of mini project for college
thank you

Hi - whats the work around for this issue?
Collecting pyaudio
Downloading PyAudio-0.2.11.tar.gz
Installing collected packages: pyaudio
Running setup.py install for pyaudio ... error
Complete output from command /Users/Yogi/Downloads/AI-Smart-Mirror-master/hhsmartmirror/bin/python -u -c "import setuptools, tokenize;file='/private/tmp/pip-build-6JQRPe/pyaudio/setup.py';f=getattr(tokenize, 'open', open)(file);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, file, 'exec'))" build_ext -I/usr/local/include -L/usr/local/lib install --record /tmp/pip-grk5rN-record/install-record.txt --single-version-externally-managed --compile --install-headers /Users/Yogi/Downloads/AI-Smart-Mirror-master/hhsmartmirror/include/site/python2.7/pyaudio:
running build_ext
building '_portaudio' extension
creating build
creating build/temp.macosx-10.12-intel-2.7
creating build/temp.macosx-10.12-intel-2.7/src
cc -fno-strict-aliasing -fno-common -dynamic -arch x86_64 -arch i386 -g -Os -pipe -fno-common -fno-strict-aliasing -fwrapv -DENABLE_DTRACE -DMACOSX -DNDEBUG -Wall -Wstrict-prototypes -Wshorten-64-to-32 -DNDEBUG -g -fwrapv -Os -Wall -Wstrict-prototypes -DENABLE_DTRACE -arch x86_64 -arch i386 -pipe -DMACOSX=1 -I/usr/local/include -I/System/Library/Frameworks/Python.framework/Versions/2.7/include/python2.7 -c src/_portaudiomodule.c -o build/temp.macosx-10.12-intel-2.7/src/_portaudiomodule.o
src/_portaudiomodule.c:29:10: fatal error: 'portaudio.h' file not found
#include "portaudio.h"
^
1 error generated.
error: command 'cc' failed with exit status 1

thank you very much ghost

thank you ghost!!

@ghost thank you!


Feature Request: Add Healthchecks to the Grafana Dashboard

It would be quite useful if the Grafana Dashboard shows health status of different components of a database cluster and the operator.
At minimum the following should be covered:

CPU
Memory
Connections
Storage
Number of Ready replicas
Backups
Operator status

Closed as completed in https://github.com/cloudnative-pg/grafana-dashboards.


fix(@angular/cli): Refactor skip git flat into schematics

related to angular/devkit#167

This is more than just related to PR 167 in devkit, it's dependent upon it. Once that PR is merged and released this PR must go in.


Icon request: Travala.com

URL for the brand / site / app
https://www.travala.com/
Logo resources for the icon
https://drive.google.com/drive/folders/1OtKia23_1_QOwFfckJbjer5nBxx08ypc
Anything else?
Proof of 2FA: https://blog.travala.com/explaining-how-the-travala-wallet-functions/
See "2. Set up Google 2 Factor Authentication (2FA)"
Confirmation

[X] I have read and followed the issue guidelines.

Here you go!
https://github.com/aegis-icons/aegis-icons/blob/master/SVG/Travala.com.svg

:question: How to add icon(s) to Aegis?
:star: Support this project by giving a star! Just adding like to this comment is also appreciated.


installation error on windows: WindowsError: [Error 193] %1 is not a valid Win32 application

Hi,
I am installing xgboost on windows (Windows 7-64bit) following the instructions given in: http://stackoverflow.com/questions/33749735/how-to-install-xgboost-package-in-python-windows-platform/35480673#35480673 and http://xgboost.readthedocs.org/en/latest/build.html#building-on-windows.
It does the process correctly, generating the "xgboost.exe" file on the xgboost folder and the  "libxgboost.dll" in the xgboost\lib folder. Python installation also presents no errors during the process.
However, when I try to import on python I get the following error:
Traceback (most recent call last):
  File "<pyshell#0>", line 1, in <module>
    import xgboost
  File "C:\Python27\lib\site-packages\xgboost-0.4-py2.7.egg\xgboost\__init__.py", line 11, in <module>
    from .core import DMatrix, Booster
  File "C:\Python27\lib\site-packages\xgboost-0.4-py2.7.egg\xgboost\core.py", line 83, in <module>
    _LIB = _load_lib()
  File "C:\Python27\lib\site-packages\xgboost-0.4-py2.7.egg\xgboost\core.py", line 77, in _load_lib
    lib = ctypes.cdll.LoadLibrary(lib_path[0])
  File "C:\Python27\lib\ctypes\__init__.py", line 443, in LoadLibrary
    return self._dlltype(name)
  File "C:\Python27\lib\ctypes\__init__.py", line 365, in __init__
    self._handle = _dlopen(self._name, mode)
WindowsError: [Error 193] %1 is not a valid Win32 application

I am using MinGW-64 as compiler and Cygwin shell to define the istructions. Any suggestions?

The same for me on windows 10 x64, git x64 and mingw x64.
Compilation runs without errors.

hmm, seems this also happens for @thirdwing  when doing mxnet installations. Let us wait and see if we can progress on https://github.com/dmlc/xgboost/pull/893 to get a MSVC build back

same problem like @egallego . I used mingw-64 and git bash . Is there any solution for windows user. :(

I'm having the same issues, the installation seems to have run fine. Everything is where it should be however I'm getting "WindowsError: [Error 193] %1 is not a valid Win32 application"

@egallego @ShashkovS @tqchen @Towhid1 @tommycon
Hi, there. I have the same issues and I solve it by install the python 64bit version. Now I can successfully import xgboost. You can try this way. =)

msvc is added #1327

@linjinjin123  Thanks a lot haha you made my day!!


FIRInstallations: use lazy initialization

installations requests auth token on init. We would not like to request it before FirebaseApp has been configured. Let's use FIRInstantiationTimingLazy. We need to consider updating our components system to provide an App Configured call back.

Even with Eager, it should only be instantiated after FIRApp is configured. Were you running into something where this wasn't the case?


Inconsistency in base cnt and call cnt when switching 2 VCFs as base and call files in truvari bench

Version :
Truvari v3.1.0
Describe the bug :
I used 2 VCFs (tool1_out.vcf.gz and tool2_out.vcf.gz) as the input for truvari bench.
The commands are as followed:
"""
#Tool 1 as truthset
truvari bench -b tool1_out.vcf.gz
-c tool2_out.vcf.gz
-f $fasta
--pctsize 0
--refdist 1000
-o ${outdir}/tool1_as_truthset
#Tool 2 as truthset
truvari bench -b  tool2_out.vcf.gz
-c tool1_out.vcf.gz
-f $fasta
--pctsize 0
--refdist 1000
-o ${outdir}/tool2_as_truthset
summary_1=${outdir}/tool1_as_truthset/summary.txt
summary_2=${outdir}/tool2_as_truthset/summary.txt
"""
I expected the "base cnt" from summary_1 to be equal with the "call cnt" from summary_2, and vice versa.
However, the number of "base cnt" from summary_1 was 1 call fewer than the "call cnt" from summary_2.
I have tried with 24 couples of VCFs and only 10 out of them had this problem.

Hello,
Unfortunately I'm unable to recreate this error.
python3 -m pip install truvari==3.1.0
call1=call_one.vcf.gz
call2=call_two.vcf.gz
ref=GRCh38_1kg_mainchrs.fa

truvari bench -b $call1 -c $call2  -f $ref --pctsize 0 --refdist 1000 -o one_on_two
truvari bench -b $call2 -c $call1  -f $ref --pctsize 0 --refdist 1000 -o two_on_one

one_on_two summary:
{
    "TP-base": 4460,
    "TP-call": 4460,
    "FP": 5750,
    "FN": 4176,
    "precision": 0.43682664054848186,
    "recall": 0.5164427975914775,
    "f1": 0.47330998620396897,
    "base cnt": 8636,
    "call cnt": 10210,
    "TP-call_TP-gt": 3026,
    "TP-call_FP-gt": 1434,
    "TP-base_TP-gt": 3026,
    "TP-base_FP-gt": 1434,
    "gt_concordance": 0.6784753363228699
}

two_on_one summary:
{
    "TP-base": 4460,
    "TP-call": 4460,
    "FP": 4176,
    "FN": 5750,
    "precision": 0.5164427975914775,
    "recall": 0.43682664054848186,
    "f1": 0.47330998620396897,
    "base cnt": 10210,
    "call cnt": 8636,
    "TP-call_TP-gt": 3026,
    "TP-call_FP-gt": 1434,
    "TP-base_TP-gt": 3026,
    "TP-base_FP-gt": 1434,
    "gt_concordance": 0.6784753363228699
}

Are you sure there were no other parameters (e.g. --includebed) and that the VCFs have consistent header ##contig definitions? Those are the only things I can think of.

Hi,
Thanks for your reply.
I attached the VCFs to this email. Please have a look at them.
Thanks,
Trang
On Tue, Mar 15, 2022 at 12:07 PM Adam English @.***>
wrote:

Hello,
Unfortunately I'm unable to recreate this error.
python3 -m pip install truvari==3.1.0
call1=call_one.vcf.gz
call2=call_two.vcf.gz
ref=GRCh38_1kg_mainchrs.fa
truvari bench -b $call1 -c $call2  -f $ref --pctsize 0 --refdist 1000 -o one_on_two
truvari bench -b $call2 -c $call1  -f $ref --pctsize 0 --refdist 1000 -o two_on_one
one_on_two summary:
{
"TP-base": 4460,
"TP-call": 4460,
"FP": 5750,
"FN": 4176,
"precision": 0.43682664054848186,
"recall": 0.5164427975914775,
"f1": 0.47330998620396897,
"base cnt": 8636,
"call cnt": 10210,
"TP-call_TP-gt": 3026,
"TP-call_FP-gt": 1434,
"TP-base_TP-gt": 3026,
"TP-base_FP-gt": 1434,
"gt_concordance": 0.6784753363228699
}
two_on_one summary:
{
"TP-base": 4460,
"TP-call": 4460,
"FP": 4176,
"FN": 5750,
"precision": 0.5164427975914775,
"recall": 0.43682664054848186,
"f1": 0.47330998620396897,
"base cnt": 10210,
"call cnt": 8636,
"TP-call_TP-gt": 3026,
"TP-call_FP-gt": 1434,
"TP-base_TP-gt": 3026,
"TP-base_FP-gt": 1434,
"gt_concordance": 0.6784753363228699
}
Are you sure there were no other parameters (e.g. --includebed) and that
the VCFs have consistent header ##contig definitions? Those are the only
things I can think of.
—
Reply to this email directly, view it on GitHub
https://github.com/ACEnglish/truvari/issues/102#issuecomment-1067568786,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUUAQC3YIXRJJHRXIEXEAYLVAALJHANCNFSM5QXP6XCA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

There's nothing attached. Github will screen email attachments with 'suspect' file extensions

I attached those files to the reply email, but they did not appear here. Please check those file I attached here.
Thanks,
Trang
tool1.vcf.gz
tool2.vcf.gz

This isn't a problem. It can be replicated and explained.
tl;dr - See Wiki for details
call1=tool1.vcf.gz
call2=tool2.vcf.gz
ref=/users/u233287/scratch/insertion_ref/msru/data/reference/grch38/GRCh38_1kg_mainchrs.fa

rm -rf one_on_two
rm -rf two_on_one

truvari bench -b $call1 -c $call2  -f $ref --pctsize 0 --refdist 1000 -o one_on_two  --debug
truvari bench -b $call2 -c $call1  -f $ref --pctsize 0 --refdist 1000 -o two_on_one  --debug

vimdiff <(grep -v "#" one_on_two/tp-base.vcf | cut -f 1,2 | sort) <(grep -v "#" two_on_one/tp-call.vcf | cut -f 1,2 | sort)
# Found the difference in two_on_one/tp-call.vcf
# chr13   32912300

bcftools query -f "%CHROM\t%POS\t%SVLEN\t%MatchId\n" two_on_one/tp-call.vcf | grep -w 32912300
# chr13   32912300        46      21.0.0

# This call is smaller than --sizemin but larger than --sizefilt
# It matches to 21.0.0
bcftools query -f "%CHROM\t%POS\tID\n"  two_on_one/tp-base.vcf -i "MatchId=='21.0.0'"
# chr13   32912300        rs886038095-rs397507695

# and that call in one_on_two/ is a false positive
grep -w rs886038095-rs397507695 one_on_two/*.vcf
# one_on_two/fp.vcf:chr13 32912300        rs886038095-rs397507695

So the variant being shorter than than --sizemin is why the counts are different. If you'd like them to be consistent, use
--sizemin 0 -sizefilt 0
Note, I think I used 3.2.0-dev. But I'm pretty confident that the same thing is happening in the current release.

Note: I reworded the wiki entry a little to add more clarity

I got it. Thanks for your help.


fix: Updated math.h function calls to cmath equivalents

Changed NAN from math.h to std::nanl("") from cmath.
Changed isnan(...) from math.h to std::isnan(...) from cmath.

This code is perfect @NickHAnderson019 , but open a PR into the main repo's master branch. Have you done that?

Now I have. I wasn't sure where to open the PR to.


Fix IP address of a service is published on all network interfaces

Registering a service with a fixed IP address might not work as expected because the IP address is announced on all multicast network interfaces. But the IP address might not be accessible from all network interfaces.
Instead a fixed IP address should be specified for a specific network interface.

With commit 91c1c03 you can now include the network interface(s) when registering a new service with the flag -Interface.


Adding Multus CNI NetworkAttachmentDefinition CRD

I identified that Multus NAD CRD's schema was missing in this repository, so I open this PullRequest to add it. I have obtained the schema by executing the python script called openapi2jsonschema.py over the NAD YAML file obtained from Multus CNI official repository.

@GuillermoCarreto you will need to update the dir path to be k8s.cni.cncf.io/networkattachmentdefinition_v1.json because the naming convention is {group}/{kind}_{apiVersion} :)


Remove latent references to SimpleReduceHandler and expand changelog

Ref #200.

Sweet.  Would you mind rebasing?  It looks like the previous merge caused conflicts here.

Nevermind, I was able to resolve the merge.  Please double-check my merge in case I goofed it.  Thanks


Implementing more Models

Note: If additions are good, please don't auto merge, want to build several models up, then add unit tests where some models have composite fields.

okay @FiniteReality all tests for models should be good for now. I'm done with commits for this PR

entity inheritance should be good now


Got Rid of Unnecessary AJAX Requests

I made the following changes:

Added images to Firebase database by clearing the database and calling Contest_Judging_System.sync() with my own version of ka_api.js (NOTE: In order for this to keep working, you have to add my code in ka_api.js to the Node.js bot. Don't worry; it's literally two lines of code, one of which is a comment.)
Got rid of AJAX requests in main.js and contest.js by instead using the Firebase database to get the info.
Updated comments in Contest_Judging_System.sync() with info about bot
Warned user about "View all Entries" taking a long time to load (as it does on my computer)

Thanks for the PR; merged!


Compatibility issues with MarkdownSharp

There are a few other compatibility issues, but not as impacting as #75 .

Transform in the MarkdownSharp code base returns the string with a trailing \n, whereas this one does not.
AllowEmptyLinkText defaults to false whereas I think it needs to default to true to keep matching behaviour.

1). I cant find nothing about this in md spec. There are good reasons to add it ?
2). It makes sense (but I do not like that you can create a hidden link). Create PR or I'll do it but later.

I'm more thinking more from a in-place replacement point of view rather than whether its a good idea or not :)
If i get a chance I'll create the PR, but as there's a workaround its not as high on the priority list.

@matt-richardson AllowEmptyLinkText currently = true
61e1fa6


Allow users to change reference currency

Right now the coin values are all in USD. The API supports many reference currencies, so adding at least some simple support for some world currencies would be a really nice enhancement.
AC:

A control to change the reference currency should be added
Changing the reference currency should initiate a new API request, and the interval request should continue onward with the new currency.
A reference currency must be selected
Defaulting to USD is fine, although being smart about it would be really cool too.

Other things to consider if possible:

Refresh time (maybe add an animation too, and get rid of the spinny wheel unless a certain amount of time has passed?
Change time window (currently at 24 hours)
Dark/Light theme?


USB Reattach fixes + Specify reset time remaining + secrets != 0xFF

This is desired with the pico2w release (with #664 ) to improve user first run experience

@brentru this one updates haltError to use an optional time argument, and parameterises the timeouts


OSD-6272 Enable build CI with osd-container-image boilerplate convention

Since https://github.com/openshift/boilerplate/pull/210 was merged, the osd-container-image is in an MVP state where it contains build/push make targets for app-interface to build/push the image.
I've subscribed this repo to it as well as created a new home for this repo in https://quay.io/app-sre/osd-cluster-ready as well as created the necessary CI for app-interface to automatically build and push this image on PR merges (see story for more details).
I validated make osd-container-image-build, make osd-container-image-push, and make deploy and updated the README with the corresponding instructions.

This work takes care of half of the story, as linting and maybe a test build (since currently there are no tests to run go test) should be added to this repo for prow CI checks. Likely those same prow CI checks should then be upstreamed to the osd-container-image boilerplate convention.

Everything outside of ./boilerplate/ looks good and the incoming convention has already been reviewed.
/lgtm


Use execute to call rake tasks, not invoke

@tlunter
If a parameterized task is invoked multiple times, it will only execute
the task with the first set of arguments. To work around this, use
execute for to dynamically call parameterized rake tasks.

:+1:

@nahiluhmot Just documenting that we spoke about my concerns regarding execute not running a task's dependencies.


allow per-message compression option

When permessage-deflate is negotiated on a stream, It should be possible to control whether compression is enabled on a per-message basis.

Has this been enabled yet (as of boost 1.68)?
If not, when is message compression used in a Beast WebSocket client?

It certainly does. If I got this correctly, by default, a Beast WS client stream has compression (per-message deflate) enabled, pending other conditions (server negotiation).
Thanks.

Sorry to resurrect this old issue, but it's still open.
After the three conditions are met the server and client "can" exchange compressed messages. But it seems to be no way to specify, for a specific message if I want to compress it or not.
It seems to me that beast suppose that if permessage_deflate is enabled I want to compress all the messages.
In my case there are some messages that I need to leave uncompressed for speed reason, the time spent in deflate is not acceptable, but I want to compress all the other messages.
I don't see in the write methods any way to specify if that specific message need to be compressed or not.

@pscamodio
From the height of my ignorance, doesn't this work?
// Disable compression
websocket::permessage_deflate pmd;
ws.get_options(pmd);
pmd.client_enable = false;
pmd.server_enable = false;
ws.set_options(pmd);
// Use the was stream
ws.read(/* ... */); // or whatever operation
// Enable compression
ws.get_options(pmd);
pmd.client_enable = true;
pmd.server_enable = true;
ws.set_options(pmd);

If this does work, then it might not be a huge problem, although this is probably verbose enough to justify some wrapper function.

I like your thinking here, but the meaning of "enable" is just that it is allowed as a negotiation option during handshake. Whether or not compression is actually enabled is a property of the stream. See:
https://github.com/boostorg/beast/blob/develop/include/boost/beast/websocket/impl/stream_impl.hpp#L100

Yes. I was looking at
https://github.com/boostorg/beast/blob/00293a6adb5383fe14217a8916dd7ff79a857483/include/boost/beast/websocket/impl/stream_impl.hpp#L227-L228
right now, and trying to find a solution to this issue and https://github.com/boostorg/beast/issues/227.
So this issue is just a matter of agreeing on the API to enable/disable wr_compress_opt, while #227 is just a matter of including an extra min size condition at the line above.

The minimum size should be configurable, with a reasonable default (see what other libs do, like uWebsockets)


Provided Script doesn't work if first time using nuget

Line 10 of the script needs to include a source in case this is the first time using nuget on a device or it fails.
like this:
./nuget install Microsoft.CrmSdk.XrmTooling.PluginRegistrationTool -Source "https://api.nuget.org/v3/index.json" -O .\Tools

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9d7d5f36-11fc-9ac5-778b-c03823bbb072
Version Independent ID: 814e151a-2018-285a-697f-f929a73957d4
Content: Download tools from NuGet (Developer Guide for Dynamics 365 Customer Engagement)
Content Source: ce/customerengagement/on-premises/developer/download-tools-nuget.md
Product: d365ce-op
GitHub Login: @JimDaly
Microsoft Alias: jdaly

Should be fixe with PR above


Visual C++ with NANODBC_USE_UNICODE ... L"literals" to u"literals"... now fails to link

(I am not sure if is related to #133.)
The older code that once worked stopped to compile after using the newer nanodbc sources. The project defines the NANODBC_USE_UNICODE in preprocessor definitions, and the minimized failing version is:
#include "nanodbc.h"
int main()
{
    nanodbc::connection conn(L"Driver=ODBC Driver 11 for SQL Server;Server=MYSERVER\\SQL2014;Database=test;Uid=sa;Pwd=myPassword");
    return 0;
}

The error points to the L"..."
1>------ Rebuild All started: Project: nanodbcSelect, Configuration: Debug Win32 ------
1>  nanodbcSelect.cpp
1>d:\tmp\nanodbcunicodebug\nanodbcselect.cpp(4): error C2664: 'nanodbc::connection::connection(const nanodbc::connection &)': cannot convert argument 1 from 'const wchar_t [97]' to 'const nanodbc::string_type &'
1>  d:\tmp\nanodbcunicodebug\nanodbcselect.cpp(4): note: Reason: cannot convert from 'const wchar_t [97]' to 'const nanodbc::string_type'
1>  d:\tmp\nanodbcunicodebug\nanodbcselect.cpp(4): note: No constructor could take the source type, or constructor overload resolution was ambiguous
1>  nanodbc.cpp
1>  Generating Code...
========== Rebuild All: 0 succeeded, 1 failed, 0 skipped ==========

After some testing and manual bisecting, I have discovered it stops to work for the commit e6059ff3a7 (2016-01-31 19:01 by lexicalunit):
Converts usages of `wstring` and `wchar_t` to `u16string` and `char16_t`.

    - Functions like `swprintf()`, `wcsftime()`, `wcsncmp()` can not be used
      with `u16string` types. Instead, prefers to narrow unicode string to
      work with them, and then widen them after work has been completed.
    - String literals also change from `L"..."` to `u"..."`.
    - `stringstream` is not implemented for `u16string` so its use is
       proscribed. Migrates existing code to use `basic_string::append()`.

Looking at the comment I have noticed that the L"..." string literal should be changed to u"..." literals. So I did. The simplified example now compiles, but it fails to link.
1>------ Rebuild All started: Project: nanodbcSelect, Configuration: Debug Win32 ------
1>  nanodbcSelect.cpp
1>  nanodbc.cpp
1>  Generating Code...
1>nanodbc.obj : error LNK2001: unresolved external symbol "__declspec(dllimport) public: static class std::locale::id std::codecvt<char16_t,char,struct _Mbstatet>::id" (__imp_?id@?$codecvt@_SDU_Mbstatet@@@std@@2V0locale@2@A)
1>D:\tmp\nanodbcUnicodeBug\Debug\nanodbcSelect.exe : fatal error LNK1120: 1 unresolved externals
========== Rebuild All: 0 succeeded, 1 failed, 0 skipped ==========

Is it a bug on my side, or is it caused by nanodbc on Windows?
Thanks,
Petr

Check, if the "newer nanodbc sources" include this patch #125

Well, it seems to be my double fault. I have just cloned the nanodbc from fresh and copied the new sources to my project. But it not solved, yet. The bug (may be my bug) moved probably to the nanodbc::result::get. Here is my minimal example:
#include <iostream>
#include <string>
#include "nanodbc.h"
using namespace std;
int main()
{
    nanodbc::connection conn(u"Driver=ODBC Driver 11 for SQL Server;Server=myserver\\SQL2014;Database=test;Uid=sa;Pwd=mypassword");
    nanodbc::result row = nanodbc::execute(conn, u"SELECT * FROM dbo.table1");

    for (int i = 1; row.next(); ++i)
    {
        wcout << i << L": "
            << row.get<std::wstring>(1)
            << endl;
    }
    return 0;
}

Now the linker shows
1>nanodbcSelect.obj : error LNK2019: unresolved external symbol "public: class std::basic_string<wchar_t,struct std::char_traits<wchar_t>,class std::allocator<wchar_t> > __thiscall nanodbc::result::get<class std::basic_string<wchar_t,struct std::char_traits<wchar_t>,class std::allocator<wchar_t> > >(short)const " (??$get@V?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@@result@nanodbc@@QBE?AV?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@F@Z) referenced in function _main
1>D:\tmp\nanodbcUnicodeBug\Debug\nanodbcSelect.exe : fatal error LNK1120: 1 unresolved externals

When I comment out the row.get<std::wstring>(1) in the for loop, it links fine.
The SQL table uses nvarchar columns, and it was created by
    CREATE TABLE test.dbo.table1(
        id int IDENTITY(1, 1) NOT NULL,
        createdby nvarchar(99) NULL,
        note nvarchar(400) NULL
        )
    )

Since the change #96, you need to do row.get<nanodbc::string_type>(1).
Inconvenient, especially on Windows where a typical Unicode-aware application built with Visual Studio relies on wchar_t and std::wstring as de-factor standard Unicode strings.
Hence, my #133 proposal.

I see. But before accepting #133, how should I convert the result of row.get<nanodbc::string_type>(1) to the standard output?

http://en.cppreference.com/w/cpp/locale/wstring_convert

Can we close it?

Yes, definitely. The problem of unicode strings in C++ is rather difficult to solve the way when everyone is happy. :)