[Commands] Bugs to be fixed down the road.

These was already reported from https://github.com/DecoraterBot-devs/DecoraterBot/issues/7
This issue basically moves all of the currently completed / incomplete bugs I have to fix in the commands from that issue to this one. However some things are kept in that issue as some of them can also apply to the Core as well.
Changes related to this issue that I would like fixed:

[x] Add command to report issues to bot development Discord Server in case the reporter does not have github.
[x] Disallow discord.gg discord invite links from being used on the game command (This gives free advertising of servers if I do not do it).
[x] Allow use of moderation commands in ignored channels.

[x] Bug in game command randomly where it for some reason does not work correctly despite the file not having the thing it errors on...

exception in command game:
Command raised an exception: AttributeError: '<class 'DecoraterBotCore.Core.BotClient'>' object has no attribute 'bot_prefix'

[x] When purge_from fails send if the bot has no permissions to prune messages or if the messages are over 14 days old.
[x] Ability to log kicks and bans in a server if it has a channel named mod-log. (plugins/logs.py) (Bot also needs permission to send in the channel as well)
[x] Fix the bug where I have to use ::remgame to show the Type ::commands for info status message that shows as streaming on the bot upon starting the bot (Something to do with voice channel rejoin or something erroring).
[x] Make the givecredits command in the credits.py plugin cog transfer credits instead of give 5m fee credits.
[ ] Make the credits command only work 1 time in an 24 hour period for users. (and for it to still be able to know when it will be able to be used again in case bot loses connection and logs out in an cache json file that also stores their balance (need to somehow generate an datetime object of the future (24 hours into the future) to store or and then compare and see if it has elapsed).
[x] Use webhooks for all commands per channel if configured. With this change the current send message using bot account itself would be a fallback when no webhook is configured for the channel) (The configuration would be in an webhooks.py plugin cog).
[x] Optimize commands some to maybe shorten some steps the bot does a bit or a lot? (eventually) (Voice plugin rework should cover this, see issue #1.)
[ ] Fix warn and mute commands. (eventually)
[ ] Move to latest discord.py rewrite and work on getting the cogs to work on the rewrite.

Some of these fixes I could probably do on my own. The others I would definitely need help or a team to do it.

To keep this for later: http://discordpy.readthedocs.io/en/rewrite/migrating.html


pika support codis slot migrate

support all codis slot migrate command in pika
add switch for supporting codis slot migrate, could configure in configuration file or from redis-cli config set /get slotmigrate yes/no
add command slotsreload for loading keys into slot keys and slotsreloadoff for forced stop reloading keys
info command display wether in slotsreloading status or not
dbsize could show keys number precisely and without delay if slotmigrate is yes

pika is one terrific database product ,compatible with redis protocal and commands, but right now from my point of view, it does not have cluster resolution?  hope this pr could help provide one approach, pika as codis servers. as writed above, if switch is off ,it is all the same with the official version~


Update travis node versions

Remove Node.js v5
Require tests to pass on Node.js v6

Fixes https://github.com/pelias/pelias/issues/401
Connects https://github.com/pelias/pelias/issues/334

:shipit:

LGTM


Feature/cypress private policy

What does this pull request aim to achieve? 💯
Please be concise and link any related issue(s):

[X ] I have checked that no one else is working on similar changes.
[X] I have read the latest README and understand the development workflow.
[X ] The name of this branch is: feature/<branch_name>, or hotfix/<branch_name> if this is a hotfix, where <branch_name> briefly describes the issue(s) resolved and is prefixed with the issue number(s) (e.g. 1127-1130-update-git-branching-model). The branch is created in a cloned version of this repo, not a forked repo.
[X ] This branch is rebased/merged with the latest staging (or the latest production if it is a hotfix).
[X ] There are no merge conflicts.
[X ] There are no console warnings and errors.
[X ] On the right hand side of this PR, I have linked the appropriate issue(s) under "Issues" and added a project progress under "Projects".
[X ] The title describes the issue(s) being addressed using format: <issue_numbers> - <brief_issue_description> (e.g. #1127/#1130 - Update Git Branching Model)

HI All, this is my first draft for the privacy-policy page. Please review and give me suggestion.

hey @adorapham please see comments. How come there are two privatePolicyContent.json files?
@jessica-lau ,only one needed it  first I named it privatePolicyContent.json file. then later I change to privacyPolicyContent.json file.  I will delete one next commit and change the name correct on privacyPolicy.spec.js also. I thought I rename but it seems creating a new file instead :). Thank you

@adorapham @jessica-lau
I don't know if it's necessary to write tests for all paragraphs. Maybe it will be better to choose the most important ones and most of all check links? I'm thinking about keeping the time of test execution as small/fast as possible.

@adorapham @jessica-lau
I don't know if it's necessary to write tests for all paragraphs. Maybe it will be better to choose the most important ones and most of all check links? I'm thinking about keeping the time of test execution as small/fast as possible.

@galeza @jessica-lau , we don't want any missing paragraphs as well as incorrect format and links but i have a suggestion :
-check one item in each paragraph to make sure it is existing
-check number of bold items (strong ) in the page together  as expected ( we counted and put the number  in the date, similar like the rest), not content
-check number of list item (OL) in the page, not content
-check number of LI items in the page (not content)
-check number of Underline items in the page (not content)
-check number of table /table head /table body (not content)
-check number of links on the page and each link much be response to click event
so this case ,we don't need to check everything and it move faster

@adorapham @galeza @TimeaKovacs86 yea I don't think there's a need to check each paragraph word for word as the content will possibly change overtime. If the test checks listed items/underline items, this may also fail the tests if an item is added or removed from the list. I think checking short key phrases (like a sentence or phrase) in each paragraph and checking that all links clickable is sufficient enough.

Hi @adorapham ! I am just wondering, if it is necessary to check out the paragraphs one by one, or wouldn't it be easier if the test would be about if the json file is loaded, because the content of the privacy policy may change with time, or just some update come up, then the test will fail. The question is for everyone in this review... let me know what you think? Or if I am wrong..

@adorapham @galeza @TimeaKovacs86 yea I don't think there's a need to check each paragraph word for word as the content will possibly change overtime. If the test checks number of listed items/underline items, this may also fail the tests if an item is added or removed from the list. I think checking short key phrases (like a sentence or phrase) in each paragraph and checking that all links are clickable is sufficient enough.

@jessica-lau @galeza @TimeaKovacs86, let stick with this one to make it simple :)  Thank you for all the comments and suggestion s

@adorapham
You don't need to close a PR. You can work on it and make changes :) You can keep it open.
I remember that you mentioned that it was difficult to traverse a DOM. There is a cypress method children() that can help you:
https://docs.cypress.io/api/commands/children.html#Syntax
you can call children(), next(), first()or within() methods.

re-open the pull request

hey @adorapham looks like some codes were removed in the files. Did you do a git fetch then git merge from staging to pull latest updates?

hey @adorapham looks like some codes were removed in the files. Did you do a git fetch then git merge from staging to pull latest updates?

Yes,I try to commit only my files but since i pull the latest codes from staging and re-base with the feature/ypress-private-policy and do the git merge, it gets a lot of unnecessary files that makes hard to review.   @jessica-lau , can you please help me to get back to this first commit https://github.com/FightPandemics/FightPandemics/pull/1768/commits/4710b55aca3a75b00c618702525d64f84bda625c,  so i will skip the staging pull over on Nov 7  Cypress add logs for failed tests (#1762) …and Nov 9 (validations for forgot password (#1764) …, . after that i only commit my updated files without the need to pull the latest codes from the staging.

Hi @adorapham ,
Could you open a new branch and cherry-pick your commits? Or copy your code?
I still see other commits on your branch and I think that revert didn't clean it.
Thank you.

Close the pull request due with above reason


Feature Exposure calculation

I was just wondering why your feature exposure calculations are different from that specified in the forums at https://forum.numer.ai/t/model-diagnostics-feature-exposure/899 ?

Thanks for using numereval
The forum post uses older calculation for feature exposure
def feature_exposure(df):
    return np.sqrt(np.mean(np.square(feature_exposures(df))))

While the calculation used for evaluation metrics is maximum exposure to any single feature.
# Check the feature exposure of your validation predictions
feature_exposures = validation_data[feature_names].apply(lambda d: correlation(validation_data[PREDICTION_NAME], d),
                                                         axis=0)
max_per_era = validation_data.groupby("era").apply(
    lambda d: d[feature_names].corrwith(d[PREDICTION_NAME]).abs().max())
max_feature_exposure = max_per_era.mean()
print(f"Max Feature Exposure: {max_feature_exposure}")


Release 1.3.0 version

In the 1.3 branch everything is prepared for the 1.3.0 release that's compatible with the (patched) 7.4.0 camunda BPM platform.
Since it can only be tested with a self-compiled version 7.4.0 I don't think that this task has to wait for #33 since the tests will turn red anyways.

https://github.com/camunda/camunda-bpm-platform-osgi/releases/tag/1.3.0


[Add to Settings] An option to toggle Highlight the current tab

Sorry man. I don't want to mess with CSS. I don't want you to change your default settings, either. But please add an option to toggle Highlight the current tab in Settings. Thank you.

As I mentioned in the other issue, this must be done at the theme level, because Highlight the current tab would need to somehow override the theme rules (whichever was used) and do some logic over the colors of that theme (and think the case where the theme already had high contrast), this is simply a bad idea. Correct solution is providing more themes by default so users can select themes with more contrast. Initially I could add a more "contrast-y" theme based on the default one. Also current tab is already highlighted, IDK why you can't see it.
For the moment I'll do an small change to the current theme that might help some people with the contrast issue (non-selected tab text will be in a slightly shaded color, as many editors and browsers do).
This is how it looks (it's available in the nightlys):

It's even worse. I can't tell the difference between the tabs at all. I will try the CSS.

For the moment I'll do an small change to the current theme that might help some people with the contrast issue (non-selected tab text will be in a slightly shaded color, as many editors and browsers do).
This is how it looks (it's available in the nightlys):

Should this temporary workaround be removed?

For the moment I'll do an small change to the current theme that might help some people with the contrast issue (non-selected tab text will be in a slightly shaded color, as many editors and browsers do).
This is how it looks (it's available in the nightlys):

Should this temporary workaround be removed?

I'm not sure, I actually like the change for the moment, I might increase the brightness of the inactive tab font color a little bit though.
Most popular editors do shade the font color too (from top to bottom: vscode, zed, sublime_text, kate), so I'm not crazy at least:

Also added Kate because it's probably what it would be best for your case. I don't particularly like it, I think that highlighting elements should be reduced at the very minimum because it's distracting, I only want the code to excel and avoid distraction.

The background between the active tab and inactive tabs are still the same.
p/s: OK. If I try my best I can see the color of the backgrounds of the inactive tabs is shaded, too. But the difference is too small to notice (at least for me).

This is for sure a color accuracy of your monitor unless you're color blind (which is an absolutely valid reason to complain about it). That's why I think providing a high contrast version would be useful for these cases. But for me is very visible (like I really don't have to do any "effort" to see the difference).


[BUG] PodSecurity causes depoyment failure

What happened?
oc create deployment nginx --image=nginxinc/nginx-unprivileged:stable-alpine
results in (see: oc get events):
3m59s       Warning   FailedCreate        replicaset/nginx-7465574dbf   Error creating: pods "nginx-7465574dbf-p56fr" is forbidden: violates PodSecurity "restricted:latest": allowPrivilegeEscalation != false (container "nginx-unprivileged" must set securityContext.allowPrivilegeEscalation=false), unrestricted capabilities (container "nginx-unprivileged" must set securityContext.capabilities.drop=["ALL"]), runAsNonRoot != true (pod or container "nginx-unprivileged" must set securityContext.runAsNonRoot=true), seccompProfile (pod or container "nginx-unprivileged" must set securityContext.seccompProfile.type to "RuntimeDefault" or "Localhost")
What did you expect to happen?
no error
How to reproduce it (as minimally and precisely as possible)?

oc create deployment nginx --image=nginxinc/nginx-unprivileged:stable-alpine
oc get events

Anything else we need to know?
This seems to be a known bug with OpenShift, see
https://access.redhat.com/solutions/6976583
https://access.redhat.com/solutions/6983715
Environment

MicroShift version (use microshift version):
MicroShift Version: 4.12.0-0.microshift-2022-11-17-084702-untagged
Base OCP Version: 4.12.0-0.nightly-2022-11-07-181244

Hardware configuration:
X86, 2CPU, 4GB, 200GB disk

OS (e.g: cat /etc/os-release):
NAME="Red Hat Enterprise Linux"
VERSION="8.7 (Ootpa)"
ID="rhel"
ID_LIKE="fedora"
VERSION_ID="8.7"
PLATFORM_ID="platform:el8"
PRETTY_NAME="Red Hat Enterprise Linux 8.7 (Ootpa)"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:redhat:enterprise_linux:8::baseos"
HOME_URL="https://www.redhat.com/"
DOCUMENTATION_URL="https://access.redhat.com/documentation/red_hat_enterprise_linux/8/"
BUG_REPORT_URL="https://bugzilla.redhat.com/"

REDHAT_BUGZILLA_PRODUCT="Red Hat Enterprise Linux 8"
REDHAT_BUGZILLA_PRODUCT_VERSION=8.7
REDHAT_SUPPORT_PRODUCT="Red Hat Enterprise Linux"
REDHAT_SUPPORT_PRODUCT_VERSION="8.7"

Kernel (e.g. uname -a):
Linux flail1.fyre.ibm.com 4.18.0-372.32.1.el8_6.x86_64 #1 SMP Fri Oct 7 12:35:10 EDT 2022 x86_64 x86_64 x86_64 GNU/Linux

Others:

Relevant logs

@peterw-ibm, thank you for reporting this.
As mentioned in the 6976583 and 6983715 solution articles, this is a known issue with OpenShift using Kubernetes v1.25. MicroShift will benefit from the fix in the OpenShift code when it is released.
/close


Fix: correctly escapes double quotes when converting ux.table to csv

modify replace with replaceAll as mentioned in this issue : https://github.com/oclif/core/issues/944#issue-2126189996

Thanks for your review, I've just added a new test case.
I have one more question for the future: should the check for escaping quotes be done line by line (as it is now) or value by value? The latter would produce slightly cleaner CSVs, but at some performance cost.


Modal creation

Support the generation of modals from python, ie:

The modals should support leva panels and markdown.

Implemented in #72


Include licence in pypi release

Would it be possible to include the licence in the pypi release? It is causing issues with a conda build.

In case you want to do want to do a release, please consider also to add also tests.py. It can be used during package checking in the distro.

Yes, please include  the license in the pypi release. Thanks a lot!


Requested support for shouldSelectItem(at index: Int) in ListSectionController

New issue checklist

[X] I have reviewed the README and documentation
[X] I have searched existing issues and this is not a duplicate

General information

IGListKit version: 3.1.1
iOS version(s): iOS 11

A ListSectionController has a didSelectItem method, but no shouldSelectItem method.  Is there a reason for that?  We have a need to determine if an item should be selectable and it seems like a natural addition.  If desired, I could take a stab at it.

Sounds like a great idea to me!

This would be great!
If you haven't gotten around to implementing this yet, I will gladly take the time to add it and throw up a PR.

Almost 2 years after last comment. Do you have any news?!


Game Request

Muse Dash
Fall Guys
The Stanley Parable: Ultra Deluxe
Game Builder Garage
Crunchyroll
Twitch
Asphalt 9: Legends
All of the Jackbox Party Packs
Just Shapes and Beats
Untitled Goose Game
Little Nightmares
Little Nightmares II
Portal
Portal 2
Danganronpa: Trigger Happy Havoc
Danganronpa 2: Goodbye Despair
Baba is You
Sky: Children of the Light

my oh my... that's a lot. heads up, some of those games are already added, some won't be added (because they're small games or apps), and the rest will be added. i'll get into a more detailed response later


[Sec:4 subsection] reproducibility:

There is a subsection in sec:4 on reproducibility that hasn't been filled in. Can @davidlmobley or @jmichel80 or both of you have a look at it? That would be fantastic. It shouldn't be more than a paragraph that is needed.

wrote a rough paragraph that could do with a bit of polishing

Thank you!

This looks good to me, made a few tweaks on Overleaf but marking as resolved.


A bug in CNV.focal

Hi,
CNV.focal reports an error,
Error in h(simpleError(msg, call)) :
error in evaluating the argument 'x' in selecting a method for function 'split': object 'x' not found
which might be associated with the following two lines:
348: cgenes.ratio <- sapply(split(x@fit$ratio[d2[, "probe"],i], d2[, "gene"]), median, na.rm = TRUE)[values(cgenes)$SYMBOL]
349: cgenes.ratio <- cgenes.ratio - x@bin$shift[i]
I think "x" must be replaced by "object".
In addition, gene annotations created in CNV.create_anno by using UCSC_RefGene_Name_450k are not matched with
probe order.
probes450k <- minfi::getLocations(IlluminaHumanMethylation450kanno.ilmn12.hg19::IlluminaHumanMethylation450kanno.ilmn12.hg19)
probes450k$genes <- UCSC_RefGene_Name_450k
Thanks,
Katsuhito

Hi Katsuhito,
thank you so much for your comment! I revised the code by replacing "x" with "object".
Concerning the probe order, the probes from the 450k and EPIC arrays are sorted subsequently. It is ensured that the gene annotation for each probe is correct.
Your comment is very helpful for improving the package. Please do not hesitate to contact me in case you encounter further issues.
Thanks,
Bjarne

Hi Bjarne.
It appears that the correction has not been reflected.
I'm looking forward to using CNV.focal.
Thanks,
Katsuhito


Documentation: Add content to how to modify data in a multi index table section

Add content to how to modify data in a multi index table section
https://github.com/EOSIO/eosio.cdt/blob/docs/starter/docs/06_how-to-guides/02_multi-index/how-to-modify-data-in-a-multi-index-table.md

This has been addressed


wrong color in chart

Describe the bug
in the chart not the selected color is used
To Reproduce
Steps to reproduce the behavior:

Go to https://int.visualize.admin.ch/create/new?from=VUSAeguRbG3t
See error

Expected behavior
use the very same color as selected
Screenshots or video

Environment (please complete the following information):

Visualize environment and version: INT v3.20.0 (84a65f2)

@bprusinowski can you hot fix this asap / before PROD (will be next wednesday) ?
cc @zellersabine @sosiology @adintegra

Hi @Rdataflow, yes, I am taking a look now 👀

The fix is ready in #1069 – the root cause of the problem was that we were showing values that shouldn't be shown, because they were not present in the chart. If the chart actually used the "Keine Angabe" value, it would have the correct color 👍


Amplify cli not detecting lambda changes

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
16.18.0
Amplify CLI Version
10.8.1
What operating system are you using?
Mac
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
I did not make any manual changes to the cloud resources.
Describe the bug
I have two amplify environments, uat and prod.  I created a lambda function in the uat environment using the amplify cli amplify add function.  After running amplify status I see the new lambda function.    Then I checkout the amplify prod environment.  Then I merge in the git uat branch.  I expect to see the new lambda function waiting to be created/pushed to my amplify prod environment, but it is simply missing.
I uploaded a YouTube video that perfectly shows the issue here: https://youtu.be/ZN5gjIKdoCY
Sorry for the white box that jumps all around.  I was hiding my api key.
Expected behavior
After merging in the amplify changes in git to my amplify prod environment, I expected amplify status to result in detecting the new lambda function, which would then allow me to push it to prod.
Reproduction steps

In amplify uat environment, create a new lambda function
Git commit amplify changes.
Switch to prod branch/environment
Merge in amplify changes
Erroneously see that the new lambda function is not waiting to be created/pushed.

Project Identifier
84ad6fe6bf78f11c3b7a2443d1da93b0
Log output

# Put your logs below this line

Additional information
No response
Before submitting, please confirm:

[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

After you do the merge, you might try running the amplify env checkout prod command again.  I don't think that amplify cli recognizes the change to backend-config.json when the file is changed through the git merge, but usually (for me), running env checkout command remedies that.

Wow, that seemed to work.  Thanks!
The process that I followed (using git merge) was from the amplify documentation here: https://docs.amplify.aws/cli/teams/overview/.  See the 3rd image and the verbiage around it.
So that leads me to two quick questions.

Is there a better way?
Is this expected to work more consistent in version 11 of the amplify-cli?

I don't know of a better way.  This issue has been around since we started using amplify cli (version 4 or so).

Hey @scottmanny :wave: thanks for raising this and apologies for the delay! This appears to be a duplicate of https://github.com/aws-amplify/amplify-cli/issues/8090, where we are required to run amplify env checkout <target-env before and after git merge. This will populate the backend-config with the new Function to the gitignored amplify-meta.json file and the function will then be recognized in the target environment (more in-depth instructions can be found here https://github.com/aws-amplify/amplify-cli/issues/9790#issuecomment-1045258462)

closing due to inactivity and in favor of tracking #8090

Hey @scottmanny 👋 thanks for raising this and apologies for the delay! This appears to be a duplicate of #8090, where we are required to run amplify env checkout <target-env before and after git merge. This will populate the backend-config with the new Function to the gitignored amplify-meta.json file and the function will then be recognized in the target environment (more in-depth instructions can be found here #9790 (comment))

Is this in the docs already. Can't directly found it and haven't seen it yet. But I might have overlooked it.
If not, we should add it.


Fix: Add hidden SheetTitle to Sidebar for improved accessibility

This PR addresses the accessibility issue in the Sidebar component where a SheetTitle was missing, causing screen reader accessibility problems.
Changes made:

Added a visually hidden SheetTitle to the Sidebar component
Used Radix UI's VisuallyHidden component to ensure the title is accessible to screen readers while remaining visually hidden

This solution improves upon the previously suggested fix (adding a hidden class) by using semantic HTML and following best practices for accessibility.
Comparison with Existing Pull Request #5553:
While PR #5553 addresses the issue by adding className="hidden", I believe this approach is less ideal from an accessibility standpoint. Using VisuallyHidden ensures that the title is semantically correct and better supports screen readers and assistive technologies.
Fixes: #5474

Hey, I've already made a PR few days ago about this but using sr-only instead of adding a component https://github.com/shadcn-ui/ui/pull/5553

Hey, I'm the author of PR https://github.com/shadcn-ui/ui/pull/5553 and I've added sr-only not hidden which seems best to me instead of adding another component you have to maintain.

I apologize @Medaillek. For some reason I confused your pull request with #5572, which addresses the issue by adding I hidden title like I described on this PR.


After applying the plugin, I see no "set build name" section in my pipeline.

Jenkins and plugins versions report

Environment

Plugin version 2.2.0

What Operating System are you using (both controller, and any agents involved in the problem)?
Ubuntu 18.04
Running on Docker image jenkins/jenkins:lts
Running version Jenkins 2.319.1
Reproduction steps

Download the latest plugin from here , version 2.2.0
Installed the plugin manually.
Went to my job, configure settings, I see no "set build name" section anywhere.

Expected Results
After I install the plugin I should see "set build name" section.
Actual Results
There is no "set build name" section.
Anything else?
No response

Did you try sample code https://github.com/jenkinsci/build-name-setter-plugin ?

@damianszczepanik, I did not put any of the pipline code in my Jenkinsfile. Its not clear if I needed to or not, is this a requirement? I thought I could just load the plugin and the "set build name" setting would show up in the job settings. Is this not the case?

Readme file provides how to configure this with pipeline and classic job. I have checked now and both are still there

Based on the error it works for change triggered by Gerrit but not when you run it manually

Based on the error it works for change triggered by Gerrit but not when you run it manually

Ok, I suppose "Gerrit" is some plugin that the example in the README is using that I am not using.
I changed that parameter to "This is a test" and that displayed in the Jenkins pipeline's history as expected. But I am unsure of what variable I can use to show the branch name for the current branch being tested. What variable can I use to display the Branches name for "buildName"?

Then this looks like problem with plugin or configuration - your code looks good enough to work

@damianszczepanik, I did not put any of the pipline code in my Jenkinsfile. Its not clear if I needed to or not, is this a requirement? I thought I could just load the plugin and the "set build name" setting would show up in the job settings. Is this not the case?

Same problem with you that cannot see the section with "set build name", have you gotten it fixed? I could also change the build name after the build start, but cannot set the build name to desired one when the build is still in the queue.
thanks!

Then this looks like problem with plugin or configuration - your code looks good enough to work

Do this plugin support Pipeline project?


Task -Browse Nomenclature - Original combination search

Search box does not find taxon name if I search using the original combination of the taxon.

duplicates #604

I still cannot search for the original combination

I think this is fixed now.


helm/exporter-node: Change from deamonset.yaml to daemonset.yaml

Change file name deamonset.yaml to daemonset.yaml at helm/exporter-node

@atoato88 could you read the guide explaining how to do a PR on helm and send the changes again?

Thanks for reply.
I’ll check it.

lgtm, thanks @atoato88


mainnet-fork with multiple upstream providers

Overview
Provide a simple overview of what you wish to see added. Please include:

What you are trying to do

I would like to be able to do the following:
ape test --network ethereum:mainnet-fork:hardhat:geth
...

and
ape test --network ethereum:mainnet-fork:hardhat:alchemy

Why Ape's current functionality is inadequate to address your goal
This makes it easier for one to use their local node for local tests and CICD tests with alchemy

Specification
Describe the syntax and semantics of how you would like to see this feature implemented. The more detailed the better!
Remember, your feature is much more likely to be included if it does not involve any breaking changes.
ape-config.yaml would allow more flexbility in choosing upstream provider for mainnet-fork, if one could set up their configurations in the following manner:
plugins:
  - vyper
  - alchemy
  - hardhat

ethereum:
  default_network: mainnet-fork
  mainnet_fork:
    default_provider: hardhat

hardhat:
  default_upstream_provider: geth
  geth:
    fork:
      ethereum:
        mainnet
  alchemy:
    fork:
      ethereum:
        mainnet

geth:
  ethereum:
    mainnet:
      uri: http://localhost:9090

Dependencies
Include links to any open issues that must be resolved before this feature can be implemented.
I don't foresee any open issues blocking this, but it looks like a breaking change to me.

This is one idea we had but in a slightly different way, basically provide fail-over functionality with how providers are chosen, so instead of one default that it tries to use or fails, you describe a preference order and it will keep trying for a connection down your preference list until it gets one (or times out)
This way, you can spend less time configuring your providers, and just describe what networks you want to connect to instead. For fork mode, upstream providers would be a subset of that list for it to cycle through.
How does this sound?

This is a pretty good idea. Makes CICD and local development with a hosted node seamless. Can you point me to the modules that need to be changed to implement this feature?

This is a pretty good idea. Makes CICD and local development with a hosted node seamless. Can you point me to the modules that need to be changed to implement this feature?

It would be more on the config classes for each ecosystem/network, and some more extensive work to NetworkManager and likely ProviderContextManager as well (since that actually implements the switching logic)

Hmm so I imagine the config would look something like this:
plugins:
  - vyper
  - alchemy
  - hardhat

ethereum:
  default_network: mainnet-fork
  mainnet_fork:
    default_provider: hardhat

hardhat:
  port: auto
  fork:
    ethereum:
      mainnet:
        upstream_provider: geth
        upstream_provider: alchemy

geth:
  ethereum:
    mainnet:
      uri: http://localhost:9090

Ape first tries geth. if connection borks, then ape tries alchemy.

More accurate:
hardhat:
   port: auto
   fork:
    ethereum:
      mainnet:
         upstream_provider:
           - geth
           - alchemy


Update oauth_app.py

Updating oauth_app.py to reflect the actual database table names that are created.
This is a nit pick fix to an example. It aligns the names of the database in the SQL query with the actual database tables that are created.
Category (place an x in each of the [ ])

[ ] slack_bolt.App and/or its core components
[ ] slack_bolt.async_app.AsyncApp and/or its core components
[ ] Adapters in slack_bolt.adapter
[x] Document pages under /docs
[x] Others

Requirements (place an x in each [ ])
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

[x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've run ./scripts/install_all_and_run_tests.sh after making the changes.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

Merging #163 (cd92710) into main (67e0286) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #163   +/-   ##
=======================================
  Coverage   91.79%   91.79%
=======================================
  Files         149      149
  Lines        4340     4340
=======================================
  Hits         3984     3984
  Misses        356      356

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67e0286...cd92710. Read the comment docs.


Show all privileges granted on a specific MySQL schema object

Is your feature request related to a problem? Please describe.
Would like to have the option to see all users with a specific privilege on a specific object: table, column, view, procedure, function.
Describe the solution you'd like
Add a "Privileges" vertical tab to the properties window of the objects listed above which will display users with their privileges on the object.
Double clicking on a user will open the user "Schema privileges" screen, focused on the line of that object, ready for modification.
Describe alternatives you've considered
Using these queries:
SELECT concat('`',user,'`@`',host,'`'),table_priv,column_priv FROM mysql.tables_priv tp WHERE Db='xxx' AND Table_name ='yyy'

SELECT concat('`',user,'`@`',host,'`'),Proc_priv FROM mysql.procs_priv pp WHERE Db='xxx' AND Routine_name='zzz'

Yes.

Ok, thanks for the idea.


Fix JujuMachine getting stuck after cluster not ready

Quick fix for a case I hit that prevented my kubernetes-worker machine from coming up.
This will hit the exponential backoff as is. @stonepreston did you get a chance to look into changing the exponential backoff limit to something more reasonable? Should I change this to a requeueAfter?

yeah requeue after is probably a better bet, but it wont make too much of a difference since there are other requeue: True calls that happen.
I did find that its possible to configure a custom backoff as part of controller creation: see [here](return ctrl.Result{RequeueAfter: requeueTime}, nil) and this blog post for some details. I plan on implementing this in my upcoming status PR, but for now have simply converted all my requeues to requeueAfters in the meantime.

Cool, thanks for the info and the suggestion. I've committed the change so this should be good to go.


Image should not take bc.max() when only width bounded.

Currently the Image widget takes bc.max
This means what when you want to have images in a scroll-able horizontal list, the height of the images is +inf .
This means that the images are not displayed at all.
When the image is width bounded the image should take into consideration the width/height of the image itself and calculate the correct height from that.
The same should probably be done to height constrained image widgets.

I could probably implement this, its not that hard.
If this is accepted I will start working on it.

Without looking at it hard I 100% believe you're correct, bc.max() is rarely the correct constraint.

I redid the calculations for the size, I tried making a test for this but the problem is that I need to set the size to +inf.
But the harness makes a creates an bitmap with the given size. Since we cannot make a bitmap with infinite size this obviously fails.
A possible solution would be to only create the bitmap after the layout has been done.
I will test this in an actual application, if that works I will create a PR.
I tried looking into the harness code, but it seems to be tightly integrated with the root window, so maybe that is left for someone who knows more about this.

I managed to get the test working using just scroll as the root widget.


Google clone

Describe the project you want to add with tech stack

Expected behavior

Screenshots (mandatory)

Additional context (Mandatory )

[x] I am a contributor in OSEN open source programme

@gva-cse welcome to METAVERSE!!!!!!!
Please go through contributing.md before contributing

@gva-cse Please attach a SS of your project

@apu52 is this project still ongoing or closed?

@apu52 is this project still ongoing or closed?

This issue is still open. You can work on it. But please try to raise another fresh ossue in this topic.


WIP - New distributions for 1.3.0.rcX

Combine the tools into the distribution so there is a single tar to unzip (a la accumulo, kafka, spark, hadoop, everyone else)
Create separate distributions/tools tarballs for accumulo, kafka, hbase, etc.
Create separate tarballs for kafka 08/09 distros
Rename kafka artifacts to 08

TODO:

Remove tarballs from maven build profile and have them upload to static website space instead of plopping them into nexus
Provide a make distribution script or something to allow user to bundle accumulo/hadoop/kafka jars (for specific versions) with the tools/distribution similar to spark (also allows provided)

SEE TICKET for more info: https://geomesa.atlassian.net/browse/GEOMESA-1283

I have a few questions/comments posted here, but this looks good to me.  Thanks very much, @jahhulbert-ccri !

I have some kafka 08/09 stuff coming

do you think it makes any sense to re-organize by distro? so have a layout like:
geomesa-accumulo/
geomesa-accumulo/geomesa-accumulo-datastore
geomesa-accumulo/geomesa-accumulo-distributed-runtime
geomesa-accumulo/geomesa-accumulo-gs-plugin
geomesa-accumulo/geomesa-accumulo-tools

I'm conflicted between keeping things under functional groups or distro groups...

@elahrvivaz this is what it would look like moving things around...what do you think?

@jahhulbert-ccri i like it

@elahrvivaz sounds good the rest are coming. hopefully  jhugs won't mind :)

@jnh5y i moved the gs plugins back...i need to verify that the dists are happy and have all the correct jars for tools and stuff i'm going to compare them to the old dists from 1.2.6


Transmitting output stream in RTSP or HTTP

Hello,
As documentation explains only RTP transmittingg is possible.
(https://github.com/dusty-nv/jetson-inference/blob/master/docs/aux-streaming.md#rtp)
And it works fine using VLC player.
But at my end point (https://www.home-assistant.io/integrations/generic) I am able to capture/grab only from RTSP or HTTP streams.
Are there any plans to make such broadcasting or do you have any advice here how to implement existing RTP stream?
Thank you.

You might want to try for some external program that can convert RTP -> RTSP.  Otherwise, I'm afraid I don't have a simple solution.   GStreamer doesn't include RTSP server support by default, that is only included in another library found here:
https://github.com/GStreamer/gst-rtsp-server
I'm not sure if maybe that could be used to convert RTP -> RTSP.   Maybe you could install that gst-rtsp-server, and run a pipeline on it that got the RTP stream and served RTSP instead.
I haven't planned integrating this gst-rtsp-server with jetson-inference itself, because it appears pretty complex to use programatically.   But perhaps you could modify one of the samples that comes with gst-rtsp-server to accomplish what you desire.


Window cycling stops working with FancyZones when switching virtual desktops.

Microsoft PowerToys version
0.83.0
Installation method
WinGet
Running as admin
No
Area(s) with issue?
FancyZones
Steps to reproduce
#16620 is closed as fixed, this might be a regression
#26546 refers to the canvas feature specifically.
I experience the same issue on the latest version (0.83.0) and I'm using a grid.
Repro

I take two windows snap them to the same zone and windows + pageup/pagedown works.
I switch virtual desktops with ctrl+windows+right (then back with ctrl+windows+left) and the windows + pageup/pagedown cycling stops working.
I then re-snap the two windows to the same place they've been before and cycling starts again.
Then when I switch virtual desktops with ctrl+windows+arrows it stops working again and I have to re-snap them again.

✔ Expected Behavior
Cycling to keep working
❌ Actual Behavior
Cycling doesn't work
Other Software
Windows 11 Home Version 23H2
OS build	22631.3880

/dup https://github.com/microsoft/PowerToys/issues/26546


Support nmstate to configure networking for the host being provisioned

Spike card to explore how nmstate could be integrated in Elemental and check which are the supported configurations from nm-state.

A little comment on this topic. I was wondering the same for the CAPI project, this is the related issue.
My proposal is to consume the IPAM Provider API. Since this is an API, then it should be possible to implement providers for different IPAM solutions as we see fit.
An in-cluster reference implementation can be found here.
This is currently part of CAPI, but my understanding is that (at least in recent Rancher versions) this should be available for the elemental-operator to consume.

For reference https://pretalx.com/devconf-cz-2024/talk/XZSYXW/

The natural introduction of Elemental Declarative Networking would involve extending https://github.com/rancher/yip to support (declarative) network configuration. The syntax could be the cloud-config one or the one from nmstate, since we would anyway support only NetworkManager as the network configuration tool on the registering hosts.
In both the cases,  nmstate would be the ideal backend renderer.
At present, complex network configuration can be achieved creating NetworkManager configuration through cloud-config customization.
What is missing is providing a convenient way to assign IP addresses when DHCP is not available on the network, something that nmstate nor cloud-config provide.
For this reason, the networking enhancements in Elemental will be on IP address management (IPAM) solutions (see https://github.com/rancher/elemental/issues/1459).


Allow item metadata to be expressed as attributes on the item element instead of child Xml elements

Resolves #708

Looks good so far, I like the approach! I'd like to see some more tests before we commit. Especially around adding elements that can't really be attributes (need to be escaped, etc.).

I've added some more tests and fixed some minor things.  I still need to add more tests around error cases, and we may need to add APIs to the project model in addition to the construction APIs.

I've added more tests and fixed some issues.  I think this is ready for review now.

:shipit:

Anyone else want to review this one, or shall I go ahead and merge it?

I'll look this morning

I think this PR is fine without the error rainersigwald brought up. MSBuild already supports 2 children of the same tag, taking the last one as the evaluated result. I think in this scenario the attribute can be considered before the child, so the a child metadata will win over an attribute.
For example, MSBuild supports this in the project file with anything being the result of m1:
<i1 Include="I">
  <m1>v1</m1>
  <m1>anything</m1>
</i1>

On a side note, this is a bit interesting. With the duplicate metadata you can retrieve the ProjectItem for that element, remove the v1 metadata, and the project item will no longer have that metadata, but the ProjectItemElement does! So when you re-evaluted, the 1st metadata comes back to the project item. This is inconsistent, and either the remove should remove both metadata, or the project item should report the 1st metadata after the 2nd is removed without a re-evaluation. But this is a separate issue I feel.

As far as having a metadata attribute with the same name as a metadata element, I'd like to disallow it... but we'd have to add the check in several places (adding an attribute, changing its name, changing whether it's expressed as an attribute, parsing the XML).  It could potentially affect the perf.
So since this is a rare scenario where we already have some funky behavior, I'm leaning towards saying it's not worth adding the checks.

Should the following construction APIs be update as well?

ProjectItem.SetMetadata
ProjectRootElement.CreateMetadataElement

@cdmihai

Should the following construction APIs be updated as well?

ProjectItem.SetMetadata
ProjectRootElement.CreateMetadataElement

I don't think they need to be.  ProjectRootElement.CreateMetadataElement returns a ProjectMetadataElement, which you can set the ExpressedAsAttribute property on.  Likewise, ProjectItem.SetMetadata returns a ProjectMetadata, which has an Xml property of type ProjectMetadataElement, which you can set the ExpressedAsAttribute property on.

@rainersigwald yes this is fine for CPS.


Make GetShopwareVersionConstraint compatible with Apps manifest.xml

Please describe the feature you would like to see implemented.
Currently, it's not possible to set the minimum ‘Version compatibility’ from within the .shopware-extension.yml.
By default, Shopware 6.4 is used. See https://github.com/FriendsOfShopware/shopware-cli/blob/main/extension/app.go#L241
Only plugins can detect the minimum constrained for the composer.json. For Apps we need a constraint in the manifest.xml to fetch the minimum Shopware compatibility.
Ticket Shopware issue tracker: https://issues.shopware.com/issues/NEXT-26748
Discussed in Slack: https://shopwarecommunity.slack.com/archives/C014X4KR2C8/p1679666193359859

https://github.com/FriendsOfShopware/shopware-cli/issues/181 fixes the asset compilation. However, this issue is not fixed yet. The new shopwareVersionConstraint in the .shopware-extension.yml is not available when uploading a zip because the whole file is added to the defaultNotAllowedPaths and so not available in the zipped extension. See: https://github.com/FriendsOfShopware/shopware-cli/blob/main/extension/zip.go#L40

AHH yes. and this is related to #191
https://github.com/FriendsOfShopware/shopware-cli/commit/9dc37c70d872d3b0e6c77cf32e719484fe19925a


Tag 0.11.0 Can not instantiate zhuravljov\yii\queue\Queue with PHP 7.0.9

Hi @zhuravljov,
wenn i run my codecept test i get this error.
 [yii\di\NotInstantiableException] Can not instantiate zhuravljov\yii\queue\Queue.
/data/vendor/yiisoft/yii2/di/Container.php:154

Show me your config please.

Here is my config
<?php

$params = require(__DIR__ . '/params.php');
$rabbit = require(__DIR__ . '/rabbit.php');

$config = [
    'id' => 'basic',
    'basePath' => dirname(__DIR__),
    'bootstrap' => ['log', 'queue'],
    'language'=>'de-DE',
    'components' => [
        'queue' => $rabbit,

<?php

return [
    'class' => \zhuravljov\yii\queue\Queue::class,
    'driver' => [
        'class' => \zhuravljov\yii\queue\amqp\Driver::class,
        'host' => 'RABBIT_HOST',
        'port' => 'RABBIT_PORT',
        'user' => 'RABBIT_USER',
        'password' => 'RABBIT_PASS',
        'queueName' => 'RABBIT_QUEUE',
    ],
];

Version 0.11.0 breaks backward compatibility. For details see UPGRADE.md.
You need to update config:
[
    'class' => \zhuravljov\yii\queue\amqp\Queue::class,
    'host' => 'RABBIT_HOST',
    'port' => 'RABBIT_PORT',
    'user' => 'RABBIT_USER',
    'password' => 'RABBIT_PASS',
    'queueName' => 'RABBIT_QUEUE',
]

Did my answer help you?

Hi @zhuravljov yes now it works. Thank you


Asyncify is not resolved/rejected when not signed in.

Promise (Asyncify) fields such as UnifiedUserData.account are in a pending state if the user is not signed in.
In the pending state, it is not possible to determine whether the user is not signed in or whether the user data is being loaded.

That's as designed: when the account is unknown, it is unknown. It is just pending until it resolves, when the account is known.
To determine the state of the sign in process, an actual data property is not the way to find it: that is either not yet there, or the full cycle is completed and the data is there.
Can you elaborate on the user flow? Are you looking to build an indicator that either mentions:

Not logged in [Sign in] (button)
Signing in...
Signed in: account: ...

Or is it something else?

There is no problem during the sign-in process.
The problem is when the browser is reloaded after signing in.
If the sign-in status is only determined by whether the user information has been resolved, the flow is as follows
reload→not logged in→(resolve)→signed in
(This causes UI flickering in the browser.)
The flow I want is
reload→(loading)→(resolve)→signed in

Perfect, I understand. I'll add a property to detect this :)

Un the SDK today based on your input: two new events:

retrieving to indicate that it's retrieving the state of an existing sign in (JWT flow)
ready to indicate that everything is ready: retrieving a potential sign in, signing the user in, etc. (or not, in which case it's still ready but then you'll know you have to sign in the user first)

The 'ready' event is not executed when the browser and unsigned in.
The 'ready' event requires all readyPromises to be resolved.
In the case of the browser, the 'success' or 'retrieved' event must be executed because the readyPromises contain the following code parts
https://github.com/XRPL-Labs/Xumm-Universal-SDK/blob/af8a05f04a562a0ece08d666d2df841ce907bc45/src/index.ts#L537-L548
The 'ready' event should be executed even if the 'success' or 'retrieved' event is not executed.

Thank you! Nice catch.
Fixed & deployed as v1.1.11

If the Promise of pkceRetrieverResolver is present,
It should be processed in the order of success→ready, but it is processed in the order of ready→success.
In the sign-in state
(load) → success → ready
In the non-sign-in state
(load) → ready
The flow of "ready" is considered to be appropriate.
It may be difficult because there does not seem to be a process to reject in the Promise process at present.

That's not how I designed it; "ready" means that the SDK is ready potentially picking up on existing sign in state, it doesn't mean the actual sign in is ready.
So:
(load) » retrieving » ready (with potential retrieving)
Is the proposed different order required, or a nice to have?

I don't think it is required, but it is necessary to eliminate component flickering on reload.
(Also for future developers).
It would be great if this could be addressed in future updates.

Clear, makes sense. Thanks. I'll add it ASAP.

Fixed in v1.1.12
With:

https://github.com/XRPL-Labs/XummPkce/commit/cad4f2d91fd9397ddffeec9b41a4e083bf243b09
https://github.com/XRPL-Labs/Xumm-Universal-SDK/commit/62a9061310f551d87aa3cbaec4e29562cd6561a0

Thank you for your response!
I ran the sample html and it seems that the 'ready' event is not working when the browser (b-flow) is not signed in.
This is because "loggedout" is emitted in the XummPKCE constructor process,
https://github.com/XRPL-Labs/XummPkce/blob/1231580ed1dd80f5ca8408e952e57e05bd527974/src/index.ts#L183
https://github.com/XRPL-Labs/XummPkce/blob/1231580ed1dd80f5ca8408e952e57e05bd527974/src/index.ts#L497
and, it seems that the emit is done before the "loggedout" event is detected at this point.
https://github.com/XRPL-Labs/Xumm-Universal-SDK/blob/932a393e991d32e91eee7e6de95dc5171f077177/src/index.ts#L681
The original emit should be on("loggedout",***)→this.emit("loggedout"), but here I think it's the other way round.

@develoQ I tested this thoroughly, both flows. Also in browser and non-signed in flow, this works for me.
I don't understand what you mean with the last part of your message. It's the PKCE class that emits the loggedout event, also if there's nothing to log in (so the state is, indeed, loggedout).
It's the Universal SDK picking up on that to resolve to ready.

Oh, I'm sorry.
It was an error on our part.
The sample code is working correctly.

Awesome, super happy to hear that.
You did identify the event being sent in the constructor flow. While in this case the logout method is in the next event loop, just to make sure it won't cause any future trouble I just published universal SDK v1.1.13 based on PKCE lib v2.7.5 forcing the event to the next tick with a setTimeout 0; https://github.com/XRPL-Labs/XummPkce/commit/6f04d9843adf4c56cf50e62f2bec803f263a0fca


Width and Depth in tracer - optimized algorithm

Updated documentation to match current algorithm
Referenced whitepaper.

Docs Build status updates of commit 677e3b0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/user-guide/machines/resources-estimator.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 677e3b0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/user-guide/machines/resources-estimator.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


upstream update

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 5 committers have signed the CLA.:x: timbeiko:x: mkrielza:x: rain-on:x: jframe:x: joshuafernandesYou have signed the CLA already but the status is still pending? Let us recheck it.


Add terraform plan to deployment process

Currently, SimpleReport runs an automatic terraform apply -auto-approve as part of its deployment to environments in the pipeline. While this is great for continuous innovation, it risks any manual changes that have been made in Azure being overwritten.
A deployment on 20 December caused our database to scale itself down in size because manual Azure SKU changes were not reflected in TF.
We should explore the use of terraform plan during the deployment process. This could be run against PROD as part of the PR process, or run at deployment time and manually gated.

Going to discuss with wider eng team; Rin working on a preliminary PR to add terraform plan to our GH actions.

The referenced PR for this has been merged. Based on today's engineering sync, I think we can close at @emmastephenson 's discretion! We might want to consider a broader policy announcement to keep an eye on the new check, and/or enforce any infrastructure changes needing to be made through code.

I'm happy to close this for now! Let's see how this does in the wild for a few weeks and if we need to revisit we can open a new ticket. Thanks Rin!


SQLModel: Many-to-many relationship data dropped when paginating

This is similar to https://github.com/uriyyo/fastapi-pagination/issues/294
However, when using SQLModel the relationship data is dropped. I'm always getting null for tags in my FastAPI response.
The queries seem fine. If I remove pagination, a simple unpaginated List of CustomerViews contains the tags.  Maybe I'm doing something wrong with the model setup?
Excuse typos / weirdness. I had to pull this out of a large project and pare it down to make it readable.

# Relevant schema classes ----------------------------------------------

class CustomerViewToTagBase(SQLModel, TimeStampMixin):
    customer_view: int = Field(foreign_key="customer_view.id", primary_key=True)
    tag: int = Field(foreign_key="tag.id", primary_key=True)

class CustomerViewToTag(CustomerViewToTagBase, table=True):
    __tablename__ = "customer_view_to_tag"

class TagBase(SQLModel):
    name: str

class Tag(TagBase, table=True):
    __tablename__ = "tag"
    id: Optional[int] = Field(default=None, primary_key=True)
    customer_views: List["CustomerView"] = Relationship(back_populates="tags", link_model=CustomerViewToTag)

class CustomerViewBase(SQLModel):
    __tablename__ = "customer_view"
    name: Optional[str] = Field(default=None)

class CustomerView(CustomerViewBase, table=True):
    id: Optional[int] = Field(default=None, primary_key=True)
    tags: List["Tag"] = Relationship(back_populates="customer_views", link_model=CustomerViewToTag)

# For FastAPI
class CustomerViewWithTag(CustomerViewBase):
    id: int
    tags: Optional[List[Tag]]

    # I have no idea if this is necessary, I added it based on the linked issue above #294
    class Config:
        orm_mode = True

# Router ------------------------------------------------------------------------

@router.get("/withtags", response_model=Page[CustomerViewWithTag], status_code=200)
async def get_customer_views_with_tags(
        db_session: AsyncSession = Depends(get_db_session),
        params: Params = Depends(),
        filter: Optional[str] = None
    ):
    async with db_session as db:
        customerviews_query = select(CustomerView).order_by(CustomerView.id).options(selectinload(CustomerView.tags))

        if filter is not None:
            customerviews_query = customerviews_query.filter(
                    CustomerView.name.ilike('%' + filter + '%')
            )

        # Switching the response_model to a List and the following code makes the relationship work properly
        # res = await db.execute(customerviews_query)
        # return res.scalars().all()
        return await paginate(session=db, query=customerviews_query, params=params)

Hi @thebleucheese,
I will take a closer look

Hi @thebleucheese,
I will take a closer look

Thanks!
I'll try to dig into it some more this weekend to see if I can find a fix unless you beat me to it.
PS - I love the project, it's helped a lot with my first foray into using FastAPI

Hi @thebleucheese,
It will be great if you can provide a minimal working example that I can locally. Currently, I can't help with code that you provided(

Hey, here's an example. You can see the difference between the List and Page endpoints.
pyproject.toml
[tool.poetry]
name = "fastapi_sqlmodel_pagination_dbg"
version = "0.1.0"
description = ""
authors = ["thebleucheese <thebleucheese@wedgesalad>"]
license = "MIT"

[tool.poetry.dependencies]
python = "^3.8"
fastapi = "^0.78.0"
# NOTE: known SQLModel bug in latest SQLAlchemy with relationships, hardcode older dep ver
SQLAlchemy = "1.4.34"
sqlmodel = "^0.0.6"
# no idea what I'm doing with these extras but this seems to work
fastapi-pagination = {extras = ["SQLAlchemy", "SQLModel", "Async_SQLModel", "Async_SQLAlchemy"], version = "^0.9.3"}
uvicorn = "^0.17.6"

[tool.poetry.dev-dependencies]

[build-system]
requires = ["poetry-core>=1.0.0"]
build-backend = "poetry.core.masonry.api"

main.py
import os
from typing import List, Optional

from fastapi import FastAPI, Depends
from sqlmodel import Field, Relationship, Session, SQLModel, create_engine, select
from sqlalchemy.orm import selectinload

from fastapi_pagination import Page, Params
from fastapi_pagination.ext.sqlmodel import paginate

class CustomerViewToTagBase(SQLModel):
    customer_view: int = Field(foreign_key="customer_view.id", primary_key=True)
    tag: int = Field(foreign_key="tag.id", primary_key=True)

class CustomerViewToTag(CustomerViewToTagBase, table=True):
    __tablename__ = "customer_view_to_tag"

class TagBase(SQLModel):
    name: str

class Tag(TagBase, table=True):
    __tablename__ = "tag"
    id: Optional[int] = Field(default=None, primary_key=True)
    customer_views: List["CustomerView"] = Relationship(back_populates="tags", link_model=CustomerViewToTag)

class CustomerViewBase(SQLModel):
    __tablename__ = "customer_view"
    name: Optional[str] = Field(default=None)
    description: Optional[str] = Field(default=None)

class CustomerView(CustomerViewBase, table=True):
    id: Optional[int] = Field(default=None, primary_key=True)
    tags: List["Tag"] = Relationship(back_populates="customer_views", link_model=CustomerViewToTag)

# For FastAPI
class CustomerViewWithTag(CustomerViewBase):
    id: int
    tags: Optional[List[Tag]]

if os.path.exists("database.db"):
  os.remove("database.db")
sqlite_file_name = "database.db"
sqlite_url = f"sqlite:///{sqlite_file_name}"

engine = create_engine(sqlite_url, echo=True)

def create_db_and_tables():
    SQLModel.metadata.create_all(engine)

def create_data():
    with Session(engine) as session:
        view_recruiter = CustomerView(name="Recruiter", description="Interviewer view")
        view_interviewer = CustomerView(name="Interviewer", description="Recruiter view")
        view_manager = CustomerView(name="Manager", description="Manager view")

        tag_resume = Tag(name="Resume",
            customer_views=[view_recruiter, view_interviewer],
        )
        tag_salary = Tag(name="Salary",
            customer_views=[view_recruiter],
        )

        session.add(view_recruiter)
        session.add(view_interviewer)
        session.add(view_manager)
        session.commit()

        session.refresh(view_recruiter)
        session.refresh(view_interviewer)
        session.refresh(view_manager)

        print("Recruiter:", view_recruiter)
        print("Recruiter tags:", view_recruiter.tags)
        print("Interviewer:", view_interviewer)
        print("Interviewer tags:", view_interviewer.tags)
        print("Manager:", view_manager)
        print("Manager tags:", view_manager.tags)

app = FastAPI()

@app.on_event("startup")
def on_startup():
    create_db_and_tables()
    create_data()

@app.get("/views/")
def read_views():
    with Session(engine) as session:
        views = session.exec(select(CustomerView)).all()
        return views

@app.get("/views_with_tags_list/", response_model=List[CustomerViewWithTag], status_code=200)
def read_views_with_tags_as_list():
    with Session(engine) as session:
        views = session.exec(select(CustomerView).order_by(CustomerView.id).options(selectinload(CustomerView.tags))).all()
        return views

@app.get("/views_with_tags_paginated/", response_model=Page[CustomerViewWithTag], status_code=200)
def read_views_with_tags_paginated(
         params: Params = Depends()
    ):
    with Session(engine) as session:
        customerviews_query = select(CustomerView).order_by(CustomerView.id).options(selectinload(CustomerView.tags))
        result = paginate(session=session, query=customerviews_query, params=params)
        return result

run with uvicorn main:app

@uriyyo
There's a really simple work-around to get this working.  If you convert the pagination result to a dict before returning from the route, it works:
@app.get("/views_with_tags_paginated/", response_model=Page[CustomerViewWithTag], status_code=200)
def read_views_with_tags_paginated(
         params: Params = Depends()
    ):
    with Session(engine) as session:
        customerviews_query = select(CustomerView).order_by(CustomerView.id).options(selectinload(CustomerView.tags))
        result = paginate(session=session, query=customerviews_query, params=params)
        return dict(result)

I have a feeling this is a FastAPI issue, but I'm not familiar enough with FastAPI's internals to make a definitive call. The problem appears to be related to FastAPI's jsonable_encoder function. I've described some testing and debugging below.
It could be related to this or some of the other similar issues:
https://github.com/tiangolo/fastapi/pull/4923/commits/d79c13dd16a9f2e699af12b20f45d11d1c255736
...
Debugging Method (For posterity, in case anyone cares)
I debugged this by locally checking out the fastapi-pagination project and adding it as a local dev dependency so I could step-through or modify fastapi-pagination easily and test changes. I verified that nothing in the Page object creation was acting strangely.
I then moved over to my sample code, where I converted result to a dict and printed debug statements in the FastAPI router. At this point I was stumped and didn't find any issues, so I went looking through FastAPI and SQLModel issues and saw references to jsonable_encoder when working with nested objects. The problems didn't exactly match what I was seeing but there's a note at the bottom of this page: https://fastapi.tiangolo.com/tutorial/encoder/?h=jsonabl which states that jsonable_encoder is used internally.
I figured this function may be used to generate FastAPI json output so I tested by including from fastapi.encoders import jsonable_encoder and calling jsonable_encoder on result. I then print outputted the json encoded result object and noticed it was dropping my tags - exactly the problem I saw when directly returning the paginate function's Page object with nested SQLModel relationship objects.

@thebleucheese Thanks for such a detailed investigation. I will close this ticket. Please, reopen it in case you still have some issues.


Selecting the "Restart from word # 1" resulted in app SSKR Check freezing.
2nd attempt :
I made a selection mistake on word #28, missed the restart, and ended up in word #29 entry.  Scrolling right from the confirm byteword entry in #29, it only lets me restart from #24 and below, I can't restart from #28.  Selecting restart from #24 the app still says "Enter Share#1 Word#29".
Entering here my 24th word here results in SSKR Check moving on to "Enter Share#2 Word#1"
Issues :

Restart from word # doesn't work
Making a error is hard to fix, if I accidentally selected the wrong byteword for #28, when entering #29 it would be nice for there to always be a backspace added to the alphabet entry, if the user chose backspace on the 1st letter of a given word, it should go back to entry of the prior word.

I've deleted v1.3.2 with ledgerblue, and installed my debian VM built v1.4.0 (from cloning the latest github repo)

Running Enter SSKR recovery phrase -> Enter Share#1 Word#...6, I chose Restart from word # 1  -> App freezes

Regarding the "backspace" option, it is only in the alphabet from the 2nd letter entry of a byteword, it would be ideal if it were there from the 1st character entry, and by selecting it, it would go backwards to the word prior

I spent ages entering SSKR share # 1 and # 2 in my NanoS, only for it to say invalid.  It would be ideal if the user could go an review what bytewords were entered to determine which word is incorrect, rather than having to start all over from scratch

Do SSKR shares have a checksum ? And if so does you app check them ? Most likely. I entered a byteword incorrectly but if you be bad luck if I entered 1 word of a share wrong yet still had a valid checksum.

Hi @InfiniteQE,
I agree that the app SSKR Check needs a bit more 'polish' when dealing with situations where users enter incorrect phrases. Most of the testing to date was to ensure that when a user enters correct input the app generates valid SSKR byte words. This is critical so that users do not lose funds. The functionality and tests for when a user enters incorrect phrases is a bit clunky at the moment but should still be usable.
My defensive logic is that if a user is being serious about protecting their funds they will then take the time to make sure they are typing the correct phrases. :-)
Also, adding extra functionality could be tricky as the size of the app is almost at the limit of a Nano S.


Tune CADD output size

Is your feature request related to a problem? Please describe.
At the current compression, the rocksdb for CADD clocks in at 426GB. The bgzip-ed TSV files only have 252GB. This is clearly too much.
Describe the solution you'd like
Consider other encoding strategies.
Describe alternatives you've considered
N/A
Additional context
N/A

The size goes down from 426GB to 358GB (bgzip-ed is 252GB). This is still a 40% increase in data. I'll merge #58 for now but keep this ticket open.

Re-opening as compression does not work well enough yet.


option for single file reload

based on my experience with https://github.com/Varriount/NimLime/issues/115#issuecomment-436120327 where the simple
import sublime_plugin
sublime_plugin.reload_plugin('NimLime.core.commands.nimcheck')

worked whereas using package_reloader_reload did not, how about adding a command which would call sublime_plugin.reload_plugin on the current module (eg: mypkg.foo.bar), where mypkg.foo.bar is inferred automatically from view.file_name()
that would be pretty useful in cases where either package_reloader_reload doesn't work (as in NimLime), as well as in cases where reloading all modules in a package is somehow undesirable ; the user would be in control by letting him choose the single module reload vs whole package reload.
The question is: do you know a simple way to go from file name view.file_name()  to  mypkg.foo.bar ?
this could be maybe as simple as:
iterate over parent dir dir until there's no dir/__init__.py
so that pathToModule("/pathto/foo/baz/mypkg/foo/bar.py") = "mypkg.foo.bar"
EDIT
I tried, it works fine:
def fileToMod(path):
  assert os.path.splitext(path)[1] == ".py"
  mod = ""
  while True:
    (head, tail) = os.path.split(path)
    if tail == '':
      return mod
    name = os.path.splitext(tail)[0]
    if mod == "":
      mod = name
    else:
      mod = name + '.' + mod

    initF = os.path.join(head,'__init__.py')
    if not os.path.exists(initF):
      return mod

    path = head

[EDIT]
based on this discussion https://github.com/Varriount/NimLime/pull/121#issuecomment-436159603 it appears __init__.py is not required so I guess I can try alternative approach for fileToMod suggested here https://github.com/Varriount/NimLime/pull/121#issuecomment-436159603 ; @randy3k let me know if you have any comments on  existance of top-level  __init__.py
[EDIT]
ok, i implemented the alternative approach which doesn't require top-level __init__.py and it works

This already seems to be implemented - I can call "Reload Current Package" while looking at any file in NimLime and have the package reloaded. The relevant code is implemented here.
Or do you mean, reload an individual file in a Sublime Text plugin?

yes, I mean reload an individual file in a Sublime Text plugin ; because it's useful in some cases when Reload Current Package isn't desirable as I mentioned in top post

I don’t think we should reload only the file being edited. The edited file may have been imported as a dependence by other files.

Only reloading the fule being edited is highly volatile and the fact that it works in your case is more or less coincidence (or well, not really, since the behavior is to be expected, but it's not proper). The reason being that now every command is defined twice (once in the surface plugin, the one in the package root, and once by directly loading the module where the commands are defined), but the latter takes precedence. If you were to do this with event listeners, you'd have two of them active.
The plugin system is not designed to be used this way. Plugin classes that interface with the sublime_plugin API must be exposed in a root plugin module, otherwise they will be ignored. Attempting to circumvent this by calling sublime.reload_pluign manually will create all sorts of shadow bugs and issues that you may or may not encounter during your dev session and will most likely leave you agonizing due to weird issues.
The best way to reload a package's plugins is still to unload and reload all its modules.


Worker/etcd nodes stuck in registering state in a custom cluster

Rancher versions:
rancher/server:Master
Steps to Reproduce:

Create a custom cluster with 1 etcd node, 1 control node and 3 workers
etcd and cluster node come up fine. Worker nodes are stuck in registering state

Server logs:
2018/04/02 17:26:02 [INFO] cluster [cluster-6z6xg] provisioning: [addons] Setting up user addons
2018/04/02 17:26:02 [INFO] cluster [cluster-6z6xg] provisioning: [addons] no user addons defined
2018/04/02 17:26:02 [INFO] cluster [cluster-6z6xg] provisioning: Finished building Kubernetes cluster successfully
2018/04/02 17:26:02 [INFO] Provisioned cluster [cluster-6z6xg]
2018/04/02 17:26:05 [INFO] Handling backend connection request.
2018/04/02 17:26:15 [INFO] Handling backend connection request.
E0402 17:26:24.958664       1 streamwatcher.go:109] Unable to decode an event from the watch stream: json: cannot unmarshal string into Go struct field dynamicEvent.Object of type v1.NamespaceStatus
E0402 17:26:24.967222       1 streamwatcher.go:109] Unable to decode an event from the watch stream: json: cannot unmarshal string into Go struct field dynamicEvent.Object of type v1beta2.DaemonSetStatus
E0402 17:26:24.974648       1 streamwatcher.go:109] Unable to decode an event from the watch stream: json: cannot unmarshal string into Go struct field dynamicEvent.Object of type v1beta2.StatefulSetStatus
2018/04/02 17:26:25 [ERROR] Failed to update cluster [cluster-6z6xg]: Operation cannot be fulfilled on clusters.management.cattle.io "cluster-6z6xg": the object has been modified; please apply your changes to the latest version and try again
2018/04/02 17:26:25 [INFO] Handling backend connection request.
2018/04/02 17:26:25 [INFO] Handling backend connection request.
2018/04/02 17:26:26 [INFO] Handling backend connection request.
2018/04/02 17:26:36 [INFO] Handling backend connection request.
2018/04/02 17:26:46 [INFO] Handling backend connection request.
2018/04/02 17:26:56 [INFO] Handling backend connection request.
2018/04/02 17:27:06 [INFO] Handling backend connection request.
2018/04/02 17:27:16 [INFO] Handling backend connection request.
2018/04/02 17:27:26 [INFO] Handling backend connection request.
2018/04/02 17:27:36 [INFO] Handling backend connection request.
2018/04/02 17:27:46 [INFO] Handling backend connection request.

I see similar issue issue with etcd node stuck in registering state as well in a 8 node cluster with following setup:
2 control nodes
3 etcd nodes
3 worker nodes
only 1 etc node got to "Active" state and other 2 are stuck in "registering" state "waiting to register with Kubernetes" .Worker nodes are also stuck in the same state.

sorry bu its still there
2018/07/07 20:36:15 [INFO] cluster [c-6q7q9] provisioning: [reconcile] host [<IP_ADDRESS>] is active master on the cluster
2018/07/07 20:36:15 [INFO] cluster [c-6q7q9] provisioning: [reconcile] Reconciled cluster state successfully
2018/07/07 20:36:15 [INFO] cluster [c-6q7q9] provisioning: [certificates] Deploying kubernetes certificates to Cluster nodes
E0707 20:36:16.109606       1 streamwatcher.go:109] Unable to decode an event from the watch stream: json: cannot unmarshal string into Go struct field dynamicEvent.Object of type v1beta1.CronJobStatus
E0707 20:36:16.160708       1 streamwatcher.go:109] Unable to decode an event from the watch stream: json: cannot unmarshal string into Go struct field dynamicEvent.Object of type v1.ReplicationControllerStatus
E0707 20:36:16.162401       1 streamwatcher.go:109] Unable to decode an event from the watch stream: json: cannot unmarshal string into Go struct field dynamicEvent.Object of type v1beta2.StatefulSetStatus


Add admin log messages for gamerule addition and end

About the PR

Adds admin log messages for adding and ending gamerules, capturing the player issuing the commands to do so if possible.
Additionally logs the rule chosen during the secret game mode.
Why / Balance

Per admin request on #19761.
Technical details

Adds admin LogType GameRule
Adds admin log messages to AddGameRule, EndGameRule, AddGameRuleCommand, and EndGameRuleCommand methods in GameTicker.GameRule
Adds admin log messages to the PickRule method in SecretRuleSystem

Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

N/A
Changelog

:cl: tday
Admin:

add: Added admin log messages for adding and ending game rules, and for the commands to do so.
add: Added admin log messages for secret mode rule selection.

"Unknown" should only appear in the logs if there isn't a player associated with the console session. As far as I can tell that should only happen if its run via the server cli. Please let me know if there is a different way you'd like that represented, or if there is additional information you'd like added to the logs if that is the case.
I also know there is discussion ongoing about the large number of LogTypes, please let me know if you would like these consolidated into an already existing category.

Shifted logs to be in EventRan and EventStopped as recommended above, and pulled out the addition of the GameRule LogType.
I agree that further coalescing / re-categorizing of logs is likely needed, but that should likely be its own effort, and an effort that is carefully managed by some of the more experienced contributors/maintainers.


Hide crossreferences block on the front end if no crossreferences are present

@bryklaus writes:

The only minor tweak that might be considered would be to modify /app/src/static/js/crossRefBlock.js so that the Cross Ref block doesn’t display if there are no cross reference entries, to prevent something like this from happening

Actually this causes a downstream error:
Error: TypeError: result is null
Triggered:
https://github.com/bryklaus/glpc_related-entries/blob/34323f7964aa233ca52e941ef4e5636ffd07cbc3/app/src/static/js/crossRefBlock.js#L152
Caught:
https://github.com/bryklaus/glpc_related-entries/blob/34323f7964aa233ca52e941ef4e5636ffd07cbc3/app/src/static/js/crossRefBlock.js#L160

I think the following code should resolve the downstream error:
if (result.list) { // Check if result.list is not null
   relatedEntriesDiv.appendChild(result.list);
}

I think the following code should resolve the downstream error:
if (result.list) { // Check if result.list is not null
   relatedEntriesDiv.appendChild(result.list);
}

Although, now that I think about it, I'm not sure this will prevent the rest of the Cross Ref Block from displaying.


Update solution.md

Updated correct behavior on pac solution import with specifying when SolutionPackageType is Both

Updated correct behavior on pac solution import with specifying when SolutionPackageType is Both

@JimDaly thanks and noted. I submitted another PR remark file instead. Cheers!

Closing this in favor of #2685


App Crash while using writeAsBytes to write pdf to it.

It is working fine in debug mode.
but crash in a release.
I'm facing this problem now. I'm using Flutter master branch. 2 months ago it is working fine in release mode.
I also tried
flutter run --no-shrink

and also tried after flutter clean
      String documentPath = documentDirectory.path;
      filepath = "$documentPath/doc.pdf";
      File file = File(filepath);
      await file.writeAsBytes(pdf.save());
      _pdfdoc = await PDFDocument.fromFile(file);

nothing works. I'm facing this issue in release mode only.
app crash at --> file.writeAsBytes(pdf.save());

Hi @anandsubbu007,
Please provide flutter doctor -v , pubspec.yaml, crash log and a minimal complete reproducible code sample that shows the issue.
Thanks.

May I know how to get crash log in release mode?

[√] Flutter (Channel dev, 1.22.0-1.0.pre, on Microsoft Windows [Version 10.0.19041.508], locale en-IN)
    • Flutter version 1.22.0-1.0.pre at C:\Flutter Components\Flutter
    • Framework revision ce40de69b7 (5 weeks ago), 2020-08-20 07:31:50 -0700
    • Engine revision 81027ab0cc
    • Dart version 2.10.0 (build 2.10.0-45.0.dev)

[√] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at C:\Users\anand\AppData\Local\Android\Sdk
    • Platform android-29, build-tools 29.0.3
    • ANDROID_HOME = C:\Users\anand\AppData\Local\Android\Sdk
    • Java binary at: C:\Flutter Components\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Android Studio (version 3.6)
    • Android Studio at C:\Flutter Components\Android Studio
    • Flutter plugin version 48.1.1
    • Dart plugin version 192.8052
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)

[√] VS Code (version 1.49.1)
    • VS Code at C:\Users\anand\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.14.1

[√] Connected device (3 available)
    • Web Server (web) • web-server • web-javascript • Flutter Tools
    • Chrome (web)     • chrome     • web-javascript • Google Chrome 85.0.4183.102
    • Edge (web)       • edge       • web-javascript • Microsoft Edge 85.0.564.51

version: 1.0.0+13

environment:
  sdk: ">=2.7.0 <3.0.0"

dependencies:
  flutter:
    sdk: flutter

  cupertino_icons: ^0.1.3
  provider: ^4.0.5+1
  getflutter: ^1.0.11
  csv: ^4.0.3
  file_picker: ^1.9.0+1
  path_provider: ^1.6.8
  googleapis: ^0.55.0
  googleapis_auth: ^0.2.11+1
  sqflite: ^1.3.0+1
  image_picker: ^0.6.0+9
  ext_storage: ^1.0.3
  firebase_auth: ^0.16.0
  cloud_firestore: ^0.13.5
  firebase_core: ^0.4.4+3
  firebase_analytics: ^5.0.11
  google_sign_in: ^4.4.6
  permission_handler: ^5.0.0+hotfix.6
  pdf: ^1.11.2
  multiselectchipgroup: ^0.1.3
  grouped_checkbox: ^1.0.0
  flutter_xlider: ^3.4.0
  flutter_typeahead: ^1.8.3
  carousel_pro: ^1.0.0
  flutter_secure_storage: ^3.3.3
  flutter_plugin_pdf_viewer: ^1.0.7
  open_file: ^3.0.1
  upi_india: ^2.1.2
  flutter_email_sender: ^3.0.1
  wc_flutter_share: ^0.2.2
  flutter_downloader: ^1.4.4
  connectivity: ^0.4.8+6
  image_cropper: ^1.2.3
  in_app_review: ^0.2.0+4
  rate_my_app: ^0.7.2

dev_dependencies:
  flutter_test:
    sdk: flutter

flutter:

  assets:
    - assets/
    - assets/Open_Sans/

Thanks @anandsubbu007 for details. Would also need a minimal reproducible code sample that we can copy paste and run to see the issue. Also, you earlier mentioned, on master it worked fine, but your flutter doctor shows you are on latest dev.

Sorry, I mentioned it wrong. I'm using dev

@anandsubbu007 building a release app on dev version is generally not a good idea, because that is constantly updated everyday and may break things, it's like a working copy.
Please try your code on latest stable (1.20.4) and see if it works for you.
Thanks

Thanks, it is working fine in stable & beta version.


Get history transactions endpoint

Coverage: 82.759% (-2.1%) from 84.905% when pulling 9e5d8480735574d1158fff6654fcaa3995be2e0f on get_history_transactions_endpoint into ebdd8bb02b65b3f0610c1f917374178c1a3af04f on main.


Icon for workbench panel

VS Code introduced a setting that allows to change the labels in workbench panel to icons. This extension has no icon displayed

Thanks to @pvlzh it will be released soon.

Thanks a heap! Looking forward to the release :)


sometimes submission parts are not workflows since they lacked some i…

…nput...so they do not have a workflowId
This is a tiny PR to protect against that.
I'm not sure how to setup a test for it, but woudl be happy to if someone pointed me in the right direction

This seems explanatory enough without adding a test.


Flip text when clicking to view all applications

Description of change

This works, but I think I'd prefer not to duplicate those lines of code to get out of not doing the if statement twice? What was your thinking on that?

This works, but I think I'd prefer not to duplicate those lines of code to get out of not doing the if statement twice? What was your thinking on that?

I could create a helper but thought this was more readable so the helper wasn't justified just to avoid repeating two lines of code (writing more code to avoid 2 lines of code seemed like overkill?)

My proposal was:

      <% if exclude_others? %>
        Your planning applications
      <% else %>
         All planning applications
      <% end %>

      <%= current_user.name %>, <%= role_name %>

      <%= link_to "Add new application", new_planning_application_path %>

    <% if exclude_others? %>

<%= link_to "View all applications", planning_applications_path, class: "govuk-button" %>

    <% else %>

<%= link_to filter_text, planning_applications_path(q: "exclude_others"), class: "govuk-button" %>

    <% end %>


[nri-bundle][pixie-chart] unable to deploy the chart

Hi,
Am facing the below error while deploy nri-bundle/pixie-chart on Kubernetes cluster (AWS EKS) with helm version 4.3.2
Error: template: nri-bundle/charts/pixie-chart/templates/00_olm.yaml:1:41: executing "nri-bundle/charts/pixie-chart/templates/00_olm.yaml" at <lookup "operators.coreos.com/v1" "OperatorGroup" "" "">: error calling lookup: unable to get apiresource from unstructured: operators.coreos.com/v1, Kind=OperatorGroup: the server could not find the requested resource
please suggest

I get the same error on GKE clusters, tried up to 4.4.8 with no success.
This seems related to missing the CRDs for the Pixie operator. I recall their installation was required and documented previously, but the new Pixie installation docs do not mention this at all, presumably because the Helm 3 only version of the charts were supposed to install them? (but apparently don't )

Also running into this issue with a customer when upgrading from a non-pixie to a pixie environment. Using AWS EKS and helm version 3.4.1. I think we'll have them uninstall and reinstall with Pixie.
lookup_func.go:111: [ERROR] unable to retrieve resource list for: [operators.coreos.com/v1](http://operators.coreos.com/v1) , error: the server could not find the requested resource

lookup_func.go:85: [ERROR] unable to get apiresource from unstructured: [operators.coreos.com/v1](http://operators.coreos.com/v1), Kind=OperatorGroup , error the server could not find the requested resource

Error: UPGRADE FAILED: template: nri-bundle/charts/pixie-chart/templates/00_olm.yaml:1:41: executing "nri-bundle/charts/pixie-chart/templates/00_olm.yaml" at <lookup "[operators.coreos.com/v1](http://operators.coreos.com/v1)" "OperatorGroup" "" "">: error calling lookup: unable to get apiresource from unstructured: [operators.coreos.com/v1](http://operators.coreos.com/v1), Kind=OperatorGroup: the server could not find the requested resource

Helm 3 includes the ability to bundle CRDs into a chart (in the crds directory), but, it handles management of CRDs very poorly; in particular, CRDs are only ever touched during helm install (or helm upgrade --install if it's acting as an install rather than an upgrade, e.g., the helm release containing the CRDs was not previously present). This brings with it a couple of limitations:

If a chart updates their CRDs, helm upgrade will just leave the old versions in place and you'll never get any updates
If you uninstall a release, the CRDs will remain (this, at least, is arguably the right call)
If a chart containing CRDs is used as a subchart of an umbrella chart (as in the case of nri-bundle bundling pixie-operator-chart), and a flag is used to control whether the subchart is installed (such as pixie-chart.enabled), then, on initial installation of the umbrella chart, the CRDs from the subchart will only be installed if the subchart itself is installed; if, at a later time, the umbrella chart is upgraded and the flag is changed, the subchart will now be installed for the first time... but this is still considered an "upgrade" by Helm, so the CRDs in the crds folder are skipped entirely (as they always are for upgrades).

For these reasons, a lot of projects that need CRDs seem to opt to package the CRDs as regular resources in the templates folder, but in a dedicated <project>-crds chart, allowing them to be installed before the main chart, upgraded when needed, left in-place when the main chart is uninstalled (to avoid data loss), still uninstalled via helm if you're really sure you don't need them any more, etc.
Ultimately, I think the solution will have to involve packaging the Pixie CRDs in their own chart, pixie-crds or pixie-operator-crds or similar; and then, unfortunately, asking the user to install the pixie-crds chart before installing the nri-bundle chart (because, as noted here by the KEDA project, subchart dependency ordering is not possible in Helm, so if you made pixie-crds a dependency of pixie-operator or nri-bundle, helm would still try to validate the parent chart before installing the CRD chart).


SkipUntil : Add test, fix implementation

~Fix a part of #649~
Fork of #660
SkipUntil called MoveNext after sequence end

How is this related to #649?

It is not, sorry I copy paste to quickly. I updated the first comment..
It's a re-call MoveNext on sequence end

So this is the fix for issue #664?

So this is the fix for issue #664?

Indeed, I forgot to mention it :confused:

A squash merge may reduce my shame


Added a front end debug panel for inspecting useful page metadata

In preparation for final testing before merging https://github.com/SwiftPackageIndex/SwiftPackageIndex-Server/pull/3078, I wanted a way to check canonical URLs against the current browser window URL quickly and efficiently, without needing to locate the canonical in the web inspector manually each time.
While I was building this console, I thought it’d be a good place for some of the other data we currently hide in HTML comments, like package ID and score.
This console is hidden from end-users completely and must be switched on manually from the JavaScript console:
localStorage.setItem('spiDebug', 'true');

Once shown, it can be temporarily hidden with the “Hide” button, if it’s blocking something at the bottom of the page, or completely disabled with the “Disable” button. After disabling it would need switching back on with the console command above.
This PR also introduces shared styling and JavaScript between the main site and the Vue DocC renderer through new shared.css and shared.js files.

Dark mode:


fix: Update default supported Aurora serverless engine version

Resolves #16

Closing this for now as we moved to RDS support in the current terraform module and running cloudquery on EKS with helm charts. Might add back in the future .


Implementation of AWS SNS Queue causes an error when updating settings.

Updating any of the following fields (after settings have first been set) causes an issue with SNS.
    accessKey: settings.amazonSimpleEmailServiceAccessKey,
    secretKey: settings.amazonSimpleEmailServiceSecretKey,
    region: settings.region,
    email: settings.email

Settings are still updated, but we should delete or update the old queue first to ensure this isn't thrown.
{ QueueAlreadyExists: A queue already exists with the same name and a different value for attribute DelaySeconds
    at Request.extractError (/Users/root1/Desktop/other/nonprofit-email-service/node_modules/aws-sdk/lib/protocol/query.js:47:29)
    at Request.callListeners (/Users/root1/Desktop/other/nonprofit-email-service/node_modules/aws-sdk/lib/sequential_executor.js:105:20)
    at Request.emit (/Users/root1/Desktop/other/nonprofit-email-service/node_modules/aws-sdk/lib/sequential_executor.js:77:10)
    at Request.emit (/Users/root1/Desktop/other/nonprofit-email-service/node_modules/aws-sdk/lib/request.js:682:14)
    at Request.transition (/Users/root1/Desktop/other/nonprofit-email-service/node_modules/aws-sdk/lib/request.js:22:10)
    at AcceptorStateMachine.runTo (/Users/root1/Desktop/other/nonprofit-email-service/node_modules/aws-sdk/lib/state_machine.js:14:12)
    at /Users/root1/Desktop/other/nonprofit-email-service/node_modules/aws-sdk/lib/state_machine.js:26:10
    at Request.<anonymous> (/Users/root1/Desktop/other/nonprofit-email-service/node_modules/aws-sdk/lib/request.js:38:9)
    at Request.<anonymous> (/Users/root1/Desktop/other/nonprofit-email-service/node_modules/aws-sdk/lib/request.js:684:12)
    at Request.callListeners (/Users/root1/Desktop/other/nonprofit-email-service/node_modules/aws-sdk/lib/sequential_executor.js:115:18)
    at Request.emit (/Users/root1/Desktop/other/nonprofit-email-service/node_modules/aws-sdk/lib/sequential_executor.js:77:10)
    at Request.emit (/Users/root1/Desktop/other/nonprofit-email-service/node_modules/aws-sdk/lib/request.js:682:14)
    at Request.transition (/Users/root1/Desktop/other/nonprofit-email-service/node_modules/aws-sdk/lib/request.js:22:10)
    at AcceptorStateMachine.runTo (/Users/root1/Desktop/other/nonprofit-email-service/node_modules/aws-sdk/lib/state_machine.js:14:12)
    at /Users/root1/Desktop/other/nonprofit-email-service/node_modules/aws-sdk/lib/state_machine.js:26:10
    at Request.<anonymous> (/Users/root1/Desktop/other/nonprofit-email-service/node_modules/aws-sdk/lib/request.js:38:9)
  message: 'A queue already exists with the same name and a different value for attribute DelaySeconds',
  code: 'QueueAlreadyExists',
  time: 2017-07-13T00:24:11.804Z,
  requestId: 'd9159551-f3be-5883-be8d-c4b14c5593f0',
  statusCode: 400,
  retryable: false,
  retryDelay: 31.90656214508958 }

This was because one of the attributes of my own SQS queue was different to recent values. It should work fine.