aries_cloudagent.transport.outbound.manager ERROR

Down load the latest code, there is a ERROR when run the ./manage start , so what's the problem and  how to solve。
vcr-api_1      | Indexing 0 addresss
vcr-api_1      | Indexing 0 credentials
vcr-api_1      | Indexing 0 names
vcr-api_1      | Indexing 0 topics
vcr-agent_1    | 2020-09-01 09:20:03,344 aries_cloudagent.transport.outbound.manager ERROR >>> Error when posting to: http://vcr-api:8080/agentcb/topic/connections/; Error: (<class 'aiohttp.client_exceptions.ClientConnectorError'>, ClientConnectorError(ConnectionKey(host='vcr-api', port=8080, is_ssl=False, ssl=None, proxy=None, proxy_auth=None, proxy_headers_hash=None), ConnectionRefusedError(111, "Connect call failed ('<IP_ADDRESS>', 8080)")), <traceback object at 0x7f0ff6745748>); Re-queue failed message ...
vcr-api_1      | ======== Running on http://<IP_ADDRESS>:8080 ========
vcr-api_1      | (Press CTRL+C to quit)
vcr-api_1      | >>> YES updating cred type timestamp
vcr-api_1      | >>> YES create detail claims for credentials

in addtion，indy-node version is 1.12.3

That looks like a startup timing issue.  The API had not fully started when the call was made from the agent.  Startup timing can be adjusted in the https://github.com/bcgov/aries-vcr/blob/master/docker/docker-compose.yml.  You'll see a sleep in the startup command for each service.
The very first time you start aries-vcr there can be delays in the initialization of the various containers (database initialization, schema creation, etc).  Most of the time running a ./manage stop followed by ./manage start following such issues will result in things starting up in the expected order.

I have tried by running a ./manage stop followed by ./manage start，but still ERROR  exception .
vcr-api_1      | Indexing 0 topics
vcr-api_1      | ERROR 2020-09-02 01:17:43,534 base_events 7<PHONE_NUMBER>24096 Task exception was never retrieved
vcr-api_1      | future: <Task finished coro=<connect_agent() done, defined at /home/indy/vcr_server/utils/boot.py:73> exception=ConnectionError(MaxRetryError("HTTPConnectionPool(host='vcr-agent', port=8024): Max retries exceeded with url: /connections?alias=credential-registry-self (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7fb0c9f38588>: Failed to establish a new connection: [Errno 111] Connection refused',))",),)>
vcr-api_1      | Traceback (most recent call last):
vcr-api_1      |   File "/home/indy/.pyenv/versions/3.6.8/lib/python3.6/site-packages/urllib3/connection.py", line 160, in _new_conn
vcr-api_1      |     (self._dns_host, self.port), self.timeout, **extra_kw
vcr-api_1      |   File "/home/indy/.pyenv/versions/3.6.8/lib/python3.6/site-packages/urllib3/util/connection.py", line 84, in create_connection
vcr-api_1      |     raise err
vcr-api_1      |   File "/home/indy/.pyenv/versions/3.6.8/lib/python3.6/site-packages/urllib3/util/connection.py", line 74, in create_connection
vcr-api_1      |     sock.connect(sa)
vcr-api_1      | ConnectionRefusedError: [Errno 111] Connection refused
vcr-api_1      |
vcr-api_1      | During handling of the above exception, another exception occurred:
vcr-api_1      |
vcr-api_1      | Traceback (most recent call last):
vcr-api_1      |   File "/home/indy/.pyenv/versions/3.6.8/lib/python3.6/site-packages/urllib3/connectionpool.py", line 677, in urlopen
vcr-api_1      |     chunked=chunked,
vcr-api_1      |   File "/home/indy/.pyenv/versions/3.6.8/lib/python3.6/site-packages/urllib3/connectionpool.py", line 392, in _make_request
vcr-api_1      |     conn.request(method, url, **httplib_request_kw)
vcr-api_1      |   File "/home/indy/.pyenv/versions/3.6.8/lib/python3.6/http/client.py", line 1239, in request
vcr-api_1      |     self._send_request(method, url, body, headers, encode_chunked)
vcr-api_1      |   File "/home/indy/.pyenv/versions/3.6.8/lib/python3.6/http/client.py", line 1285, in _send_request
vcr-api_1      |     self.endheaders(body, encode_chunked=encode_chunked)
vcr-api_1      |   File "/home/indy/.pyenv/versions/3.6.8/lib/python3.6/http/client.py", line 1234, in endheaders
vcr-api_1      |     self._send_output(message_body, encode_chunked=encode_chunked)
vcr-api_1      |   File "/home/indy/.pyenv/versions/3.6.8/lib/python3.6/http/client.py", line 1026, in _send_output
vcr-api_1      |     self.send(msg)
vcr-api_1      |   File "/home/indy/.pyenv/versions/3.6.8/lib/python3.6/http/client.py", line 964, in send
vcr-api_1      |     self.connect()
vcr-api_1      |   File "/home/indy/.pyenv/versions/3.6.8/lib/python3.6/site-packages/urllib3/connection.py", line 187, in connect
vcr-api_1      |     conn = self._new_conn()
vcr-api_1      |   File "/home/indy/.pyenv/versions/3.6.8/lib/python3.6/site-packages/urllib3/connection.py", line 172, in _new_conn
vcr-api_1      |     self, "Failed to establish a new connection: %s" % e
vcr-api_1      | urllib3.exceptions.NewConnectionError: <urllib3.connection.HTTPConnection object at 0x7fb0c9f38588>: Failed to establish a new connection: [Errno 111] Connection refused
vcr-api_1      |
vcr-api_1      | During handling of the above exception, another exception occurred:
vcr-api_1      |
vcr-api_1      | Traceback (most recent call last):
vcr-api_1      |   File "/home/indy/.pyenv/versions/3.6.8/lib/python3.6/site-packages/requests/adapters.py", line 449, in send
vcr-api_1      |     timeout=timeout
vcr-api_1      |   File "/home/indy/.pyenv/versions/3.6.8/lib/python3.6/site-packages/urllib3/connectionpool.py", line 727, in urlopen
vcr-api_1      |     method, url, error=e, _pool=self, _stacktrace=sys.exc_info()[2]
vcr-api_1      |   File "/home/indy/.pyenv/versions/3.6.8/lib/python3.6/site-packages/urllib3/util/retry.py", line 439, in increment
vcr-api_1      |     raise MaxRetryError(_pool, url, error or ResponseError(cause))
vcr-api_1      | urllib3.exceptions.MaxRetryError: HTTPConnectionPool(host='vcr-agent', port=8024): Max retries exceeded with url: /connections?alias=credential-registry-self (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7fb0c9f38588>: Failed to establish a new connection: [Errno 111] Connection refused',))
vcr-api_1      |
vcr-api_1      | During handling of the above exception, another exception occurred:
vcr-api_1      |
vcr-api_1      | Traceback (most recent call last):
vcr-api_1      |   File "/home/indy/vcr_server/utils/boot.py", line 82, in connect_agent
vcr-api_1      |     headers=settings.ADMIN_REQUEST_HEADERS,
vcr-api_1      |   File "/home/indy/.pyenv/versions/3.6.8/lib/python3.6/site-packages/requests/api.py", line 76, in get
vcr-api_1      |     return request('get', url, params=params, **kwargs)
vcr-api_1      |   File "/home/indy/.pyenv/versions/3.6.8/lib/python3.6/site-packages/requests/api.py", line 61, in request
vcr-api_1      |     return session.request(method=method, url=url, **kwargs)
vcr-api_1      |   File "/home/indy/.pyenv/versions/3.6.8/lib/python3.6/site-packages/requests/sessions.py", line 530, in request
vcr-api_1      |     resp = self.send(prep, **send_kwargs)
vcr-api_1      |   File "/home/indy/.pyenv/versions/3.6.8/lib/python3.6/site-packages/requests/sessions.py", line 643, in send
vcr-api_1      |     r = adapter.send(request, **kwargs)
vcr-api_1      |   File "/home/indy/.pyenv/versions/3.6.8/lib/python3.6/site-packages/requests/adapters.py", line 516, in send
vcr-api_1      |     raise ConnectionError(e, request=request)
vcr-api_1      | requests.exceptions.ConnectionError: HTTPConnectionPool(host='vcr-agent', port=8024): Max retries exceeded with url: /connections?alias=credential-registry-self (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7fb0c9f38588>: Failed to establish a new connection: [Errno 111] Connection refused',))
vcr-api_1      | ======== Running on http://<IP_ADDRESS>:8080 ========
vcr-api_1      | (Press CTRL+C to quit)

Just pulled the latest code and ran ./manage build, ./manage start with a clean docker environment.  The application stated up without error.
A successful startup looks like this:
aries-vcr-startup.log
It looks like you are still having startup timing issues.  In your latest log the api (vcr-api_1) has started up before the agent (vcr-agent_1) and it can't establish a connection:
vcr-api_1 | requests.exceptions.ConnectionError: HTTPConnectionPool(host='vcr-agent', port=8024): Max retries exceeded with url: /connections?alias=credential-registry-self (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7fb0c9f38588>: Failed to establish a new connection: [Errno 111] Connection refused',))

Without the whole log I can't tell when or if the agent is starting.  Compare my log with your's and try to identify where the startup timing is out of sync or if there is an error starting up one of the other services.  Then you can adjust the startup timing in the docker-compose file if needed.

There is also error " [Errno 111] Connection refused" in your log file.
Now，i have fallback version，no error occurred when run startup。
Thank you very much！

The [Errno 111] Connection refused errors in my log file are for rabbitmq (the connection from the workers to the rabbitmq server).  The workers will continue to attempt to connect to the server until the server is fully running and they are able to connect successfully.  You'll see this near the end of the log file.  This is normal.
The [Errno 111] Connection refused errors in your log snippet above is between the api and agent which causes issues.


Finetuning code for sequence classification, NLI task ?

Please provide. a script for finetuning the supervised contrastive models for sentence classification and NLI task.
Is Lora Finetuning required or AutoModelforSequenceClassification can be used to train ?

Closing as it is stale. Feel free to re-open if the issue still persists.


noise value gives temperature values

Hi,
when query for noise, it return the temperature.
irb(main):027:0> station_data.devices.first.noise
=> #<Netatmo::DashboardData::Temperature:0x00005646ba885048 @time=2020-09-03 18:44:58 +0200, @value=26.7, @min=23.7, @max=31.0, @min_date=2020-09-03 12:21:54 +0200, @max_date=2020-09-03 16:03:41 +0200, @trend=#<Netatmo::Util::TempTrend:0x00005646ba884f80 @value=0>, @unit="°C">
irb(main):028:0>
thanks!

Thanks @lecabel for reporting this bug! I've released 0.1.3 which should fix this issue.
Please reopen this issue if there is still something wrong! 😊


Add monochrome icon

Please add the Android 13 "Themed App Icons" feature.

Thanks 🙏

#12 will fix this

Thanks 🙏


Editorial nits (worth discussing Thursday?)

why aren't Input Descriptor Field Entries defined in the Terminology? there are dead links to that term throughout (and, to be honest, I found this terminology a little confusing throughout)
should Martin's and Gabe's affiliations be updated in the frontmatter?
Should the status object to be so opinionated/normative when there is a status object registered in the VC extensions registry, and nothing there would support this? It feels like the wrong place to be specifying how status checks work! I didn't update the example of Driver's License Revocation because I was confused about how to proceed, but did update the example LD VC to use a Revocation-List-2020 status object as mentioned in #187.
Forgive me for being that guy, but should hub:// URIs be changed to something that exists today? I feel like using a URI protocol/handler that isn't specified today is needlessly confusing to implementers looking at the spec. One particularly confusing instance of this is the example URIs about passport schemata. Wouldn't it be more logical to assume passport schemata would be hosted on a government schema reference over HTTP for the foreseeable future, the way other USCIS semantics are hosted as part of the current SVIP sandbox ? The example makes it sound like an arbitrary DID is hosting government schemata on a hub, which seems to make a lot of assumptions about USCIS infrastructure that seem distracting and untenable given what I know about federal IT policies...

I fixed the Input Descriptor Field Entries links in my terminology clean up PR #192

May be good to add a line or two clarifying that status may be encoded different ways.

was discussed during the PE call today. No problem with hub:// URLs in examples, but it may be good to add a reference to the hub spec and mention that the URL may not be quite dereferencable just yet.

3 & 4 addressed in this commit in pull #187

This was resolved by #187


Kickoff Planning Meeting

@LSSTScienceCollaborations/stack-club-organizers
Now that Stack Club planning underway, let's schedule a meeting next week to look over these plans and give feedback. Alex @kadrlica, Greg @Madejski , @SimonKrughoff and I can talk you through our initial thinking, including:

a proposed set of seed notebooks for the Phase 1 participants to work on
a plan for the Phase 1 club sessions, and
the cloud-based computing model.

It would be really good to get your feedback on all these things! We can also look at a list of already-expert-or-otherwise-highly-motivated people we think would be good to be involved in Phase 1 - if you can bring some suggestions of your own that would be great.
Here's a doodle for us to fill out!  Looking forward to meeting up - if you prefer to keep chipping in on these issues or the #dm-stack-club Slack channel instead, that's fine too :-)

Hi all,
Thanks for all your replies to the doodle poll! We'll meet at 1400 PDT on Thursday, April 12. I've put our agenda into the notes section of this planning document, which contains our collected thoughts so far on the Stack Club project. On Thursday let's aim to discuss the following things:

The basic plan (goals, phases, schedule, from above)
DM Stack Club Seed Notebooks, proposed as the set that the Phase 1 participants to work on.
How to design the Phase 1 Stack Club sessions
Our computing model (from above).
A list of already-expert-or-otherwise-highly-motivated people we think would be good to be involved in Phase 1.

Hope this sounds good to you!
Cheers
Phil

Really good to see you all last Thursday - I'm extracting action items from our notes, and will be issuing them in the next half hour or so. And I'll probably try to close some old issues first - so all in all, expect a minor flood of GitHub notifications, and watch out for mentions! We said we'd meet up again next Thursday at the same time, but I'll issue that meeting separately.


driver updated to NX-OS when entering cXR shell

From ASR9K cXR, when trying to enter shell, condoor updated the driver to NX-OS and then things got bad.
Session logs are sent through email.

QNX has never been supported. Enhancement.


Update the default image and add environment info

We want to pass the environment information to Qodana Docker Image to check the plugin usages.
Also, this MR changes the default image to jetbrains/qodana-jvm-community and bumps some dependencies.
And a few fixes to README, given that we switched from Slack to GitHub Discussions and other things 🙃

One more thing: this MR also adds an issue template, so you can enable the repository issues back: users won't be able to report the issue to GitHub, but they will see the link to our YouTrack when click on "new issue", try it here – https://github.com/JetBrains/qodana-action/issues/new/choose


api.ai does not send the intent in the correct format

api.ai sends the intent name in
body_.result.metadata.intentName
but the actions-on-google/api-ai-app.js library looks for the intent in:
body_.result.action
... which causes an Action Error: Missing intent from request body error.

Can you confirm that your API.AI intent action value is filled in and you are not using the intent name in your fulfillment instead.

Just for some context, https://api.ai/docs/actions-and-parameters

Ok. My fault. Just realised that I only had the intent in the name and not in the action field.
Thanks guys.
Closing issue.


Can you just use GetIt syntax?

As your package uses GetIt, would it still work if we registered dependencies using the GetIt syntax?
For example:
final getIt = GetIt.instance;

void setup() {
  getIt.registerSingleton<AppModel>(AppModel());
}

I only ask because if I'm being honest, I think the cubes syntax is less readable than the standard GetIt syntax with the use of the type parameter. In addition, it looks like your missing a few features from the standard GetIt syntax such as Scopes and the ability to unregister a dependency.
I think cubes would be much more popular if instead of creating your own abstraction you simply let people use the GetIt syntax or even simply created a global variable called cubes like the 'getit' variable in the example above so that our code would look like this:
// global variable defined in the cubes package
final cubes = GetIt.instance;

// use in our code
void setup() {
  cubes.registerSingleton<AppModel>(AppModel());
}

It’s a good point. I'll improve this syntax. But i thing that not necessary de possibility of the create a global variable.
Thanks so much!


Fix "save" when hitting cancel

when I try to save the file and hit cancel it throws an error and terminates. The if-clause will prevent it.

Thanks!


IPLD Resolver: Check if Kademlia protects against address reuse

The eclipse attack paper has countermeasures to only allow a certain number of addresses form the same subnet, which should make it more difficult for an adversary to launch an attack from bots running on the same machine.
At the very least we should make sure that we do not accept multiple peers to identify themselves to us with different peer IDs from the same address.
Here's a reference implementation: https://github.com/input-output-hk/scalanet/pull/109

It doesn't look like it does, and neither does Identify.


Deployment Failed

When deploying the followin error appears:
There were errors in your deployment. Error code: DeploymentFailed.
2019-08-12T15:38:00.3083919Z ##[error]At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-debug for usage details.
2019-08-12T15:38:00.3095359Z ##[error]Details:
2019-08-12T15:38:00.3095887Z ##[error]BadRequest: {
"error": {
"code": "InternalServerError",
"message": "There was an unexpected InternalServerError.  Please try again later.  x-ms-correlation-request-id: 352eddc3-c619-4ca6-b197-cb6273dfda7f"
}
} undefined

Deployment-Microsoft.Template.zip

Which lab is this for? What step does it fail at?

This is from: azuredevopslabs/labs/vstsextend/github-azurepipelines/
Step: 26. Select Create to start a new release
When I deploy the release it fails.

I could solve the problem.
Seems that there is a missing step on the lab. It should say that before you deploy the app you have to create an App Services Tier on Azure with the domain as it appears on the lab: githubci-web-$(environment).
Best regards.


Create A New Welcome Card - Welcome Card not created

Hello,
Tutorial Link: https://developers.sap.com/tutorials/cp-mobile-cards-welcome.html
Creation of a Welcome Card results in an error while using Boosters.
Steps to follow:
Click on Boosters in your trial account(US region)
Search for the booster 'Build a Micro App for SAP Mobile Cards'
Click 'Start'
Click 'Next' under 'Check Prerequisite'
Select 'Trial' for the SubAccount and 'Dev' as the Space
Click on 'Initialize Mobile Card' to make the Mobile Card Kit Available(if this is not yet initialized)
Click ' Next'
Select 'Welcome Card Template - Single Instance'
Click 'Next'
Provide a valid name for the Welcome Card
Click Next'
Click 'Finish'
After step 12, A message appears which says ' Some cards were not created successfully '?
Please see the Screen capture attached with this ticket.
https://github.com/sap-tutorials/Tutorials/assets/105277535/33e4911c-1c2b-4b50-bf97-815702fcf46a
Thanks & Best Regards,
Ranjish

It was observed that this issue does not crop up anymore, when tested during the current test validation cycle (CW23-24)


Fix the anchor for [Google Stackdriver Logging]

The anchor is broken due to a typo, I'm trying to fix that.

Thanks!


⚠ Bofrost.lu has degraded performance

In c923b27, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1922 ms

Resolved: Bofrost.lu performance has improved in b3946fb after 8 minutes.


Socket::Addrinfo::Error.new No Longer Works in 1.1.0

Bug Report
The following works in 1.0.0:
raise Socket::Addrinfo::Error.new(LibC::EAI_NONAME, "No address found", "foobar.com") # => raises "Hostname lookup for foobar.com failed: No address found (Socket::Addrinfo::Error)"

In 1.1.0 this fails to compile
raise Socket::Addrinfo::Error.new(LibC::EAI_NONAME, "No address found", "foobar.com")
...
...
 66 | Socket::ConnectError.new(message, **opts)
                           ^--
Error: no argument named 'domain'

It looks like the change may have been introduced in https://github.com/crystal-lang/crystal/pull/10761.
I am using this in a networking mock in test code—definitely open to better approaches if that's the problem as long as they don't hit the networking stack.
I am currently testing Crystal 1.1.0 on MacOS 10.14.6.

Indeed, it seems one of the initialize was transformed to a new and then deprecated. I think it broke because changing initialize to new doesn't always work. So we should probably revert that for 1.1.1

new vs initialize is not at fault here. The complex initialization logic of SystemError makes it a bit hard to pinpoint the exact issue.
The issue is Addrinfo::Error.new_from_os_error expects all optional named args to be present. But the deprecated .new overload just uses domain. It should fill the others with default values to make sure the appropriate overloads match.

thanks all!


Depend on openmpi instead of nci-openmpi

Requires: https://github.com/ACCESS-NRI/spack-packages/pull/66
Requires: https://github.com/ACCESS-NRI/spack-config/pull/26

This change was triggered by https://github.com/ACCESS-NRI/spack-packages/issues/61 .

!bump minor

Pre-release deployment is reporting

/bin/bash: line 5: /g/data/vk83/prerelease/apps/spack/0.20/spack-config/spack-enable.bash: No such file or directory

Despite this change
https://github.com/ACCESS-NRI/build-cd/pull/31/files
Seems that on gadi it is still called spack-start.sh
$ ls /g/data/vk83/prerelease/apps/spack/0.20/spack-config/
LICENSE  README.md  spack-start.bash  tools  v0.20

Might need to check the version tagged in config/versions.json in the morning - is it spack-enable.bash in that tag? Or spack-start?

!bump major

We shouldn't merge until we have done some performance testing, confirming the impact is minimal

Good point @aidanheerdegen - I've requested changes so it shouldn't be able to merge

Seems the pre-release build is still using nci-openmpi
$ grep openmpi /g/data/vk83/prerelease/apps/spack/0.20/spack/var/spack/environments/access-om2-2024_03_0-4/spack.lock
          "name": "nci-openmpi",
          "name": "nci-openmpi",
      "name": "nci-openmpi",
        "path": "/apps/openmpi/4.0.2",
          "openmpi/4.0.2"
          "name": "nci-openmpi",
          "name": "nci-openmpi",
          "name": "nci-openmpi",
          "name": "nci-openmpi",
          "name": "nci-openmpi",

What does this mean, exactly...?

@harshula

@harshula The openmpi thing was fixed - we hadn't tagged the nci-openmpi->openmpi fix in spack-config.

Hi @CodeGat , Is there anything else we need to do?

I assume some kind of performance testing of some kind before proper deployment


The "Not yet supported" message is crashing chrome

In parse.js there is a console.log("Not yet supported: " + nodeName) line, which feeds chrome's log buffer until it crashes. I had to comment that line to keep cloud9 usable. For me it prints these two:

Not yet supported: TemplateLiteral
Not yet supported: Super

Maybe, if you really want to keep that message, it would be nice to log each unsupported node type just once?

BTW to show how severe it is - I get 10 copies of the message per every keystroke, you can imagine how many messages I get after 20-30 minutes of editing.


Running two vite servers with middleware mode prints websocket error

Describe the bug
When running two Vite servers with server.middlewareMode: true, then Vite prints WebSocket server error: Port is already in use to stderr.
Looking at the source code, I don't see a nice way to bypass that with a config. I see that we can define hmr.port, but for our use case (Vitest) hmr is disabled. Even more, we don't need this WS server at all.
Reproduction
https://stackblitz.com/edit/node-enw9th?file=index.mjs,index.html
Steps to reproduce
node index.mjs

System Info
stacbkblitz

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

I have run into this as well. If we could configure turning off the websocket server completely that'd be great, but at least an option to not log the error would be nice too.

I got this warning message while running two differents vite apps based on react.
When I receive this warning message on my second app, hmr does not work properly, because the websocket server is not working on the second app.
There is any way to fix that issue please ?
Any help will be appreciated

A workaround for this issue is to manually specify the port via the server.hmr.port option.
Ideally, a fix could be implemented to select a port automatically, mirroring the behaviour of the primary port selection process.

For vitest, one may configure a custom logger:
import { createLogger } from "vite";

const customLogger = createLogger();
const customLoggerError = customLogger.error;
customLogger.error = (msg, options) => {
  // vitejs/vite#14328
  if (msg.includes("WebSocket server error: Port is already in use")) return;
  customLoggerError(msg, options);
};

Oof, this one caught me by surprise. In my case it turned out that Vitest VS Code extension was taking whichever port my Vite dev middleware server was trying to use.
@markacola's solution worked, thankfully, thanks! https://github.com/vitejs/vite/issues/14328#issuecomment-1898150902

@bluwy #16219 doesn't solve this problem. I would like for hrm to be able to pick a free port when port in HRM options are undefined

I agree. Why can't the middleware mode server act the same way as CLI does in that regard?


Only NO2 channel seems to work

After doing testing with various gases and various environments, I usually get this output:
The concentration of NH3 is 0.99 ppm
The concentration of CO is 1.20 ppm
The concentration of NO2 is 1.18 ppm
The concentration of C3H8 is 1000.04 ppm
The concentration of C4H10 is 999.98 ppm
The concentration of CH4 is 2991.14 ppm
The concentration of H2 is 1.09 ppm
The concentration of C2H5OH is 1.40 ppm
It seems that other than the NO2 output, the rest of the output stays as the default values and does not vary with increase or decrease of concentration of those gases.  Is this a hardware issue or a firmware issue?

No answer but only close ?

Hello, sorry just made a mistake to close all of the issue of this library.
Please try calibrate the sensor in the fresh air again.
Are you sure the are around you contains the gas that didn't active?
Thanks.


Create CLI commands for Azure Functions Premium plan scale out

As part of the Azure Functions premium plan, I'd like to provide support for a few management commands when managing your plan.
Operations on the app
az functionapp ideally would have a config or similar option that would let me set how many "pre warmed instances" the app has.  This is a setting that enables you to keep your app always warm on a certain number of instances.
You can do this today via az resource like below:
az resource update --resource-type Microsoft.Web/sites -g <resource_group> -n <function_app_name>/config/web --set properties.reservedInstanceCount=<desired_prewarmed_count>

though note that the property is being renamed to preWarmedInstanceCount instead of reservedInstanceCount
Operations on the plan
az functionapp plan would have the ability to control the scale.  There are 2 settings specifically

Minimum instances - this is the plan size, the minimum number of instances you always have reserved.  Can be a value between 1-20
Maxiumum burst instances - this is set currently by modifying the maximumElasticWorkerCount.  This is how many instances your app can scale up too.  Today the limit is 1-20, but plan is to make it 1-100 in coming weeks.    Can currently do today with az resource like below:

az resource update --resource-type Microsoft.Web/serverfarms -g <resource_group> -n <premium_plan_name> --set properties.maximumElasticWorkerCount=<desired_max_scale_out>

/cc @dariagrigoriu as an FYI

@jeffhollan for the Plan operations, I am assuming that at creation time there will be 3 values (exact names TBD)
--number-of-workers  <-- already there
--min-worker-count
--max-worker-count
Do we also need an update command? az functionapp plan update to update the min/max-worker-count

Would you know what site property refers to --min-worker-count? For an app service plan, I see a maximum_number_of_workers, number_of_sites and target_worker_count.
Or if you already know a way to change min worker count, I can look at that too.

Plan only has 2 properties.  Min instance count (which is really just number of workers.. in the UX for premium we just call it minimum instances), and the maximum instances.  This maps to the plan property properties.maximumElasticWorkerCount

Thanks @jeffhollan for the clarification.
From what I got, these are the commands and restrictions I am creating-
New Commands:

az functionapp config --reserved-instance-count
az functionapp plan create --number-of-workers/--min-elastic-worker-count --max-worker-count
az functionapp plan update --number-of-workers/--min-elastic-worker-count --max-worker-count
az functionapp plan list and az functionapp plan delete because those seem to be missing.

Restrictions:

--max-worker-count on create and update only if --sku Premium (or Elastic Premium?)
--max-worker-count and --min-worker-count need to be between 1 and 20.
[question] Any restriction on --reserved-instance-count? Or do we allow modifying this setting on any function app?

@ahmedelnably / @jeffhollan / @alexkarcher-msft , I would love it if you could have a quick look and verify or add on any additional commands/flags needed.

Correct.  A few notes:

Should be --prewarmed-instance-count instead of --reserved-instance-count
Restriction is accurate - sku I believe is ElasticPremium and sizes are EP1 EP2 and EP3
prewarmed instance count must be <= 20

Thanks Jeff, wasn't sure if we wanted to start with --prewarmed-instance-count. Makes sense.

Discussed offline with @alexkarcher-msft and @ahmedelnably , calling the params --max-burst and --min-instances consistent with the portal.
Also, adding a check for --pre-warmed-instances <= plan.properties.maximumElasticWorkerCount

@jeffhollan
Hi Jeff.. Do we have any updates on the max prewarmed instance count?? I see from your earlier comment that there was a plan to make it 1-100. But when I tried setting the --max-burst to more than 20 through Azure CLI, I get this error:
Usage error: --max-burst is expected to be between 0 and 20
Any help would be appreciated. Thanks!


issue in installing phonopy via cmd

(base) jovyan@6adbda8d79ca:~/work$ phonopy_setup
Traceback (most recent call last):
File "/home/jovyan/.local/bin/phonopy_setup", line 5, in
from phonopy_setup import install_phonopy
ModuleNotFoundError: No module named 'phonopy_setup'

Also, we need to be sure where phonopy is. not done automatically but hard coded, not good


Relative entry

This is a temporary fix, this should be improved in the CDK

@markusl just to let you know that this temporary workaround is not need anymore now that https://github.com/aws/aws-cdk/pull/11729 is released.

Thanks @jogold ! This seems to be working now :)

@jogold unfortunately it still does not work. The following error is received when I try to use the module in another project:
Cannot find entry file at project/node_modules/cdk-ecr-image-scan-handler/lib/teams.handler.ts
Any ideas what is the problem?

Any ideas what is the problem?

Yes, you need to completely remove the entry prop so that the construct will look it up based on the id: email.ts with a NodejsFunction with id handler will look for email.handler.ts or email.handler.js automatically.
Automatic entry finding has been fixed for your use case in aws/aws-cdk#11729 but if you specify entry it is taken as-is.


rebuild for openssl 1.1.1,3

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_c6bye_9w8q/clone/recipe/meta.yaml:24: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_c6bye_9w8q/clone/recipe/meta.yaml:25: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
ERROR: build.sh:10: pip_install_args: pip install should be run with --no-deps and --no-build-isolation.
Errors were found


Auto rank integration

Created output table in db\bcfishpass\tables\wcrp.sql for barrier rankings
Created 1 script per watershed to populate the output table in db\bcfishpass\reports

The only change is in the condition specifying the watershed so it could probably all go in one script.
I am wondering then, was it better to have all the where clauses for each wcrp commented out and then when it needs to be run, the user uncomments the clause for the wcrp they want to rank, or is there a more user-friendly way to selectively run the script for a specific watershed?

It depends on the potential study area. If ranking is always within a given watershed, input parameters like watershed code / local code (or blue_line_key / downstream_route_measure) could be used.
If reporting on full watershed groups, this breaks down because they are not all watersheds - particularly coastal but there are other exceptions too. I think most existing WCRPs are fine though.
But I should look more closely at the queries, I haven't familiarized myself with what they are doing yet.
Another thing to keep in mind is that these do not need to be pure sql - a python script would work fine and R should work too (R would require more setup but may be handy given the number of R users).

Sounds good, I will make some changes and put it into one script

One more comment - for crossings in the Elk River watershed you'll want to use the various wct columns for stats, not the salmon (ch_cm_co_pk_sk) columns.


Camera with support (isa.camera.hlc6) not show any stream

Device model / 设备型号
isa.camera.hlc6
Component version / 插件版本
0.7.5
HA core version / HA版本
2023.1.7
Integrated mode / 集成方式
Automatic (自动模式)
The problem / 问题详情
I have a camera and I add it with success
The problem I do not see anything in the stream section and I did not have any idea what the problem
Entity attributes / 实体属性
entity_picture: /api/camera_proxy/camera.isa_hlc6_d3b8_camera_control?token=8039ffd9aca01196b5c663965dd9eb8f3fd34454c2bf339c890d06cef*****
friendly_name: Video camera round Camera Control
supported_features: 3
access_token: 8039ffd9aca01196b5c663965dd9eb8f3fd34454c2bf339c890d06cef*****
model_name: isa.camera.hlc6
brand: isa
frontend_stream_type: hls
model: isa.camera.hlc6
lan_ip: <IP_ADDRESS>
mac_address: E4:AA:EC:20:E3:B8
entity_class: MiotCameraEntity
miot_type: urn:miot-spec-v2:device:camera:0000A01C:isa-hlc6:1
miot_action_result:
did: '373037493'
miid: 0
siid: 5
aiid: 1
code: -706010002
description: 'remote error code : -4'
exe_time: 0
withLatency: 0

miot_action_error: -706010002 Service does not exist
stream_address:
expire_at: 2023-01-26 10:26:34.311472
camera_control.on: true
camera_control.image_rollover: 0
camera_control.night_shot: 0
camera_control.time_watermark: true
camera_control.recording_mode: 2
state_updater: lan
sub_entities: camera_control-2.on-1, motion_event

Home Assistant Logs / 系统日志
Setup of select platform xiaomi_miot_raw is taking over 10 seconds.
10:25:59 AM – (WARNING) Select - message first occurred at 10:16:25 AM and shows up 12 times
Setup of fan platform xiaomi_miot_raw is taking over 10 seconds.
10:25:59 AM – (WARNING) Fan - message first occurred at 10:16:25 AM and shows up 12 times
Video camera round(isa.camera.hlc6): camera events is empty. {'result': 'ok', 'retriable': False, 'code': 0, 'data': {'thirdPartPlayUnits': [], 'nextTime':<PHONE_NUMBER>000, 'isContinue': True}, 'description': '成功', 'ts':<PHONE_NUMBER>868}
10:25:29 AM – (WARNING) Xiaomi Miot Auto (custom integration) - message first occurred at 10:17:34 AM and shows up 9 times
Request xiaomi api: v2/message/v2/typelist {} failed, response: None
10:22:25 AM – (WARNING) Xiaomi Miot Auto (custom integration) - message first occurred at 10:18:21 AM and shows up 5 times
Request xiaomi api: miotspec/action {'params': {'did': '373037493', 'siid': 5, 'aiid': 2, 'in': []}} failed, response: None
10:22:19 AM – (WARNING) Xiaomi Miot Auto (custom integration) - message first occurred at 10:21:05 AM and shows up 2 times
Get xiaomi message for<PHONE_NUMBER> failed: {}
10:21:55 AM – (WARNING) Xiaomi Miot Auto (custom integration) - message first occurred at 10:18:21 AM and shows up 2 times
Platform xiaomi_miot_raw not ready yet: None; Retrying in background in 30 seconds
10:16:45 AM – (WARNING) Select - message first occurred at 10:16:45 AM and shows up 2 times
Platform xiaomi_miot_raw not ready yet: None; Retrying in background in 30 seconds
10:16:45 AM – (WARNING) Fan - message first occurred at 10:16:45 AM and shows up 2 times
custom_components.xiaomi_miot_raw.number::MiotNumberInput is overriding deprecated methods on an instance of NumberEntity, this is not valid and will be unsupported from Home Assistant 2022.10. Please report it to the custom integration author.
10:16:15 AM – (WARNING) Number

Live video streaming is not supported.


Parse top level $xref

I want to copy whole YAML and apply changes to it. But if $xref is in top level, it is correctly parsed but the result is ignored and the $xref stays unchanged. Seemd like a bug to me, or is there a reason to not parse top level $xref?

Looks good, will merge it in.
Thanks :)

Released v2.0.3 with the fix

Released v2.0.3 with the fix

Thank you so much :)


Add nix flake

@tothtamas28 Do we want to set up CI as well?

Do we want to set up CI as well?

Yes, the Nix package should be tested in a workflow.


How to attach requestHook while the cucumber bdd is integrated with testcafe

Are you requesting a feature or reporting a bug?
I would like the intercept HTTP call and i have integrated with Cucumber bdd BDD
What is the Current behavior?
i am trying to attach requestHook to a test function
What is the Expected behavior?
i can get the results without integration with cucumber bdd ..i should link my hooks to cucumber functions as well.
How would you reproduce the current behavior (if this is a bug)?
My Code is below
Then('I Verify the Landline phone number', async function () {
const currentPage = ClientFunction(() => document.location.href);
const urlApi = 'https://www.mycompany.com/api/xyz/v1/service/1234';

const logger = RequestLogger(
  {
    url: urlApi,
    method: 'get'
  },
  {
logResponseHeaders: true,
logResponseBody: true,
logRequestBody: true,
}

);
class MyRequestHook extends RequestHook {
constructor() {
super();
}
onRequest(event) {
event.requestOptions.headers['x-api-key'] = '111111111111',
event.requestOptions.headers['Content-Type'] = 'application/json',
event.requestOptions.headers['Accept'] = 'application/json'

}
onResponse(responseEvent) {
if (responseEvent.statusCode === 200) {
}
}
}
const rhook = new MyRequestHook(urlApi);
//fixture test api
// .page(urlApi)
// .requestHooks(rhook)
test.requestHooks(rhook)('test api', async testController => {
try {
await testController
.addRequestHooks(logger)
.expect(logger.contains(r => r.response.statusCode === 200)).ok();
//debuggr;
const logRecord = logger.requests[0];
const jsonObject = JSON.parse(logRecord.response.body);
const contactDetails = jsonObject.solrResultPayload[0].contactInfoDto;
const contactDetailsLandline = contactDetails.filter( contact => contact.contactTypeDisplayName === "Land Line");
const expectedPhone = contactDetailsLandline.filter(contactExp => Number(contactExp.contactPriority) === 1 )[0].contactDetail;
console.log( "Expected Phone number ::" +expectedPhone);
} catch (e) {
console.log(e);
}
});
});
Provide the test code and the tested page URL (if applicable)

This below code works fine without cucumber BDD
import { RequestLogger } from 'testcafe';
import { RequestHook } from 'testcafe';
const { ClientFunction } = require('testcafe');
const currentPage = ClientFunction(() => document.location.href);
const urlApi = 'https://www.sample.com/api/nhsd/v1/service/33333';
const logger = RequestLogger(
{
url: urlApi,
method: 'get'
},
{
logResponseHeaders: true,
logResponseBody: true,
logRequestBody: true,
//  stringifyRequestBody: true,
//  stringifyResponseBody: true
}
);
class MyRequestHook extends RequestHook {
constructor() {
// No URL filtering applied to this hook
// so it will be used for all requests.
super();
}
onRequest(event) {
event.requestOptions.headers['x-api-key'] = '78833f',
event.requestOptions.headers['Content-Type'] = 'application/json',
event.requestOptions.headers['Accept'] = 'application/json'
}
onResponse(responseEvent) {
if (responseEvent.statusCode === 200) {
// console.log('event.headers ===> ', event, event.headers);
//console.log('the body in the repsonse is:  '+JSON.stringify(responseEvent));
//console.log(event.logResponseBody['Content-Type']);
//throw new Error('Anu getting error -- Not implemented');
}
}
}
const rhook = new MyRequestHook(urlApi);
fixturetest
.page(urlApi)
.requestHooks(rhook)
test.requestHooks(logger)('test api', async testController => {
try {
await testController
.expect(logger.contains(r => r.response.statusCode === 200)).ok();

//testController.debug();

debuggr;
const logRecord = logger.requests[0];
console.log(logRecord.userAgent);           // Chrome 63.0.3239 / Windows <IP_ADDRESS>
console.log(logRecord.request.url);         // http://api.example.com
console.log(logRecord.request.method);      // get
const jsonObject = JSON.parse(logRecord.response.body);
// console.log(JSON.stringify(jsonObject.solrResultPayload[0].orgInfo.orgName)); // 304
debugger;
const contactDetails = jsonObject.solrResultPayload[0].contactInfoDto;

console.log("COntact details:"+ contactDetails)
const contactDetailsLandline = contactDetails.filter( contact => contact.contactTypeDisplayName === "Land Line");
console.log("Landline"+contactDetailsLandline);
const expectedPhone = contactDetailsLandline.filter(contactExp => Number(contactExp.contactPriority) === 1 )[0].contactDetail;
console.log( "Expected Phone number" +expectedPhone);

} catch (e) {
console.log(e);
}
});
Your Environment details:

testcafe version:                 0.22.0
node.js version:                  v10.12.0
command-line arguments:   example: npm test"
browser name and version: example: chrome
platform and version:          example: "macOS 10.14
other:                                   any notes you consider important

Hi @AnuradhaChannappa
To understand the cause of the problem, I need a web application in which you run tests.
Would you please provide a small example that contains a web application and tests?
It's comfortable to create a separate repository on GitHub and put in here all necessary files.

Sure i will check with my manager if i can expose the details and provide you the git repo details.

I will close the issue because no activity has been encountered for a long time.
Feel free to reopen the issue if you can provide an example to reproduce it.


[dv:sv_lib] disable scoreboard in environment

the AES CSR tests are failing because the scoreboard sees the register writes and assumes a message is inbound- but that never arrives.
so in order to make the tests pass I need to disable the scoreboard.
I see there is an option in the base configuration to disable the scoreboard
en_scb
but It seem it does not do exactly what I expect.
is the goal of this option not to exclude the scoreboard from the environment?
if so I think there is a bug.

cip_base_scoreboard supports on-the-fly enable/disable
just need to set en_scb = 0 before you send that register write, and then scb will drop the item
LMK if this doesn't work for you.
 virtual task process_tl_a_chan_fifo();
    tl_seq_item item;
    forever begin
      tl_a_chan_fifo.get(item);
      if (!cfg.en_scb) continue;
      if (predict_tl_err(item, AddrChannel)) continue;
      process_tl_access(item, AddrChannel);
    end
  endtask

  virtual task process_tl_d_chan_fifo();
    tl_seq_item item;
    forever begin
      tl_d_chan_fifo.get(item);
      if (!cfg.en_scb) continue;
    ...
    end
  endtask

looks like this relates to #2259. I copied my comment from that PR.

The failure of csr test is reported in check_phase in scb. scb run_phase is gated by scb_en, but you add some check in check_phase. you can either add scb_en to skip the check_phase or set cfg.num_messages = 0 for csr test.

@weicaiyang I did consider that. but it feels more like a workaround than a fix.
should we consider adding a general disable of the scoreboard in the build/connect phase

@rasmus-madsen
current scb has to be created as it also monitors the reset and it updates env_cfg for seq to skip checking when reset occurs
the easiest way would be just to skip check_phase if en_scb == 0 in your scb

Hi @weicaiyang
I already implemented this workaround it in the code in PR https://github.com/lowRISC/opentitan/pull/2259
I guess this is the best way to handle it in the current state of the DV.
I will close my question


Otterspace - adding network support for Sepolia

Fixes # .
Changes proposed in this pull request:

add sepolia subgraph support

Hey @grp06 The PR should be coming from the otterspace-xyz repo, or @rahulrumalla can confirm?

Hey @grp06 The PR should be coming from the otterspace-xyz repo, or @rahulrumalla can confirm?

Confirming. Thanks. Will ensure it comes from our fork the next time


Upgrade rightfont

Add depends_on stanza

Thank you for the contribution. It was merged directly as 6e9e4802c4378a02bac60fc4e347aea9d44db8b1 to keep commit history cleaner. Your contribution is still credited to you.


add  UpdateChannel method to Endpoint

Description

closes: #3984
Commit Message / Changelog Entry
type: commit message

see the guidelines for commit messages. (view raw markdown for examples)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against the correct branch (see CONTRIBUTING.md).
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards and Go style guide.
[ ] Wrote unit and integration tests.
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/).
[ ] Added relevant godoc comments.
[ ] Provide a commit message to be used for the changelog entry in the PR description for review.
[ ] Re-reviewed Files changed in the Github PR explorer.
[ ] Review Codecov Report in the comment section below once CI passes.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (310a4bd) 81.49% compared to head (fc2bc79) 81.51%.
Report is 7 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5725      +/-   ##
==========================================
+ Coverage   81.49%   81.51%   +0.02%
==========================================
  Files         199      199
  Lines       15203    15225      +22
==========================================
+ Hits        12389    12411      +22
  Misses       2348     2348
  Partials      466      466

Files
Coverage Δ

modules/core/04-channel/keeper/keeper.go
90.84% <100.00%> (+0.06%)
:arrow_up:

modules/core/04-channel/keeper/upgrade.go
92.52% <100.00%> (+0.21%)
:arrow_up:


Static analysis labs

Content of course has not changed, just split into multiple modules so I could add the two labs
Labs are brand new and need to be reviewed

Removing until needed


commandArgs?

Is there a reference for what it is expecting in the msg.commandArgs for the different commands?

You can look at the docs for the TeslaJs library (where this node is based on). But the list is not long so here it is:
navigationRequest: commandArgs.subject, commandArgs.text, commandArgs.locale
remoteStart: commandArgs.password
scheduleSoftwareUpdate: commandArgs.offset
seatHeater: commandArgs.heater, commandArgs.level
setValetMode: commandArgs.pin
speedLimitActivate: commandArgs.pin
speedLimitDeactivate: commandArgs.pin
speedLimitClearPin: commandArgs.pin
speedLimitSetLimit: commandArgs.limit
steeringHeater: commandArgs.level
sunRoofControl: commandArgs.state
sunRoofMove: commandArgs.percent
windowControl: commandArgs.command
All other commands don't have any arguments.
I'll put it in the readme on next update :)

thanks, I couldn't find it.


Instancer storage rework

Implements region localised storage of instancer transforms.
todo: fill out the rest of this description
See discussion
https://github.com/TokisanGames/Terrain3D/discussions/524

[x] 1. Embed vertex_spacing in transforms, relative to local region.
Add vertex_spacing to Terrain3DRegion.
Only change vertex_spacing of transforms on load/set_vs().

[ ] 2. Split MM data down to 32x32 storage
append_location -> append_region -> append_cell -> storage in 32x32

[ ] 3. Change MM/MMI generation off of new data structure

[ ] 4. Add region container in tree / instancer

[ ] 5. Support changing region size

[ ] 6. Upgrade old data

Good start. I'll work on 4, placement in the tree by region.

Great!
It occurs to me that each cell will need its own internal location relative the region.
Doing updates would need to place each mmi cell by (region_size * location + 32 * cell_location) * vertex scaling.
The vertex scaling update will have to operate locally per cell rather than region too.
The cell dictionary should be keyed by cell location relative to the region i belive.
Probably need another pass to fix the access / updates etc to so its relative to cells rather than regions once cells are in.

I have this to return cell location.
#define CELL_SIZE 32
Vector2i Terrain3DInstancer::get_cell(const Vector3 &p_global_position) {
	int region_size = _terrain->get_region_size();
	real_t vertex_spacing = _terrain->get_vertex_spacing();
	Vector2i cell;
	cell.x = (UtilityFunctions::floori(p_global_position.x / vertex_spacing) % region_size) / CELL_SIZE;
	cell.y = (UtilityFunctions::floori(p_global_position.z / vertex_spacing) % region_size) / CELL_SIZE;
	return cell;
}

I'm still just poking around the edges. I'm going to build up _instances simultaneously w/ _multimeshes so it doesn't break the old until I know the new works.

Thinking about it more, I think the transforms in each cell should be relative to the region still.

The last commit is the first intrusive change to the data structure. It works a little bit, with a lot broken. I'm done for the day in case you want to review it or take a crack and it. I'll start looking again in 10-12 hours.
It works enough to paint foliage on the ground at the 0, 0 cell of any region. Outside of that first cell, the height starts to increase linearly. I'm accumulating height somewhere.
Undo sort of works, but doesn't fully remove everything, which means destroy and/or destroy_by_location aren't 100%.
That's about it. Not much else works. Lots of bugs.
If you click the Demo node, there is a dump_tree bool you can click to print the Terrain3D tree and see the MMIs.

Added a 3rd modified value to the tuple (making it a triple now i guess?) allows much more targeted updates, especially when there are a lot of cells & transforms present.
update vertex spacing and update transforms are now both working.
removes instances ive started on, but it has issues, only seems to work in region 0, and causes the entire region to clear / suddenly have blank arrays.
i didnt touch undo, some issues persist.

When I loaded up my previous data it crashed when there was no tuple, so I fixed it. Also it was very slow to add. I removed, which cleared them all, then it stopped giving me so many problems by starting with new data.
Issues:

Foliage used to stay in it's region and not be allowed to create transforms outside it. Now you can add transforms outside your region. They may also be going outside their grid.

I'm crashing a lot on closing the editor. MSVC doesn't point to any of our code. It's likely in the allocation/deallocation.

Sometimes I'm not able to reach some areas

After this I clicked around, changed vertex scaling a few times, then was able to paint here.

Before my comits last night, cell mmis were being translated to their cell positions, which would have required offsetting the transforms per cell rather than per region. Keeping transforms per region makes things easier all around.
However loading the current iteration with old data would mean it makes assumptions about the location of the mmis when updating.
For now i suggest we test with fresh data comit until things are stable and everything is working. Then look at converting old data.

https://github.com/TokisanGames/Terrain3D/pull/523/commits/ed06faf1c8dc9e2e6ca3ccb7f130bc00f46e9b87 does fully clear when removing, but causes crashes if adding afterwards?
I think we need a better way to remove the mmi for a cell once its empty.

Things are a bit of a mess atm with the nested for loops. Vertex spacing is broken still for remove/update.
Rather than looping every cell, a similar lookup method to get_region_loc(), would make it possible to calculate the potential cell ids needed, and then check if they exist, bringing the worst case of 16k cells for 2k regions checked per mesh to only cells in the size of the area checked.

I spent all day banging my head on the crash on close and don't have much to show for it, except that it is an engine bug.
It crashes in Resource::GDClass because Godot frees the GDExtension first, then asks a Resource what class it is. It has a non-null _extension pointer which triggers the conditions to trigger it.
I can't tell what class it is, other than a Resource. I've done extensive testing trying to tell, printing out instance IDs from all Objects and Resources we're creating, but haven't found anything yet.

One note is that after painting instances and saving. Closing crahes. But loading it up again, closing again doesn't crash. It only does if more instances are added. This suggests the trigger is in the add_instances chain rather than the load_region/update_mmi chain. Or maybe something to do in the replacement of the MMI data in update_mmi.

The problem sometimes occurs on main. I was able to reproduce it, then seemingly fix it, then I couldn't reproduce the original anymore. Since the problem object is a Resource, I attempted to unref the MultiMesh before deleting the MMI, which seemed to fix the crash on main, but later when testing undoing the fix, I couldn't get it to crash on main anymore. In the PR, I tried unreffing the MM before deleting and to the old one anytime a new one was created and assigned to the MM, but it doesn't help the PR.

Other issues:

Can't add to cells that have been reloaded from disk.

Even if I close the scene and say don't save, Godot often saves foliage inside the region files. It doesn't seem to save the sculpting, unless it crashes, then it could be either way.

outside of upgrading old data, everything should be working now, and needs testing.
there is a strange issue when repeatedly changing region size without saving between, that causes instancer data to just vanish for some regions.

Lots of good stuff here. Things are coming along well. Most things are working including undo and storing data within the regions.
Bugs

I still get crashes on close pretty frequently. It's interesting that it doesn't crash after loading saved data, only add_instances or update_transforms.
hand removing instances doesn't fully delete regions from tree. MMI/Region_00-00 still exists even if empty. I don't know about cleaning up the dicts. _delete_by_location has everything needed to clean up now so can be an example.
Reducing region size did not reorganize the MMI children attached to the tree. I went to 512, which created a (0,-4) region. The regions appear to have the correct instances. However there is no MMI/Region_00-04 attached to the tree
update transforms isn't accurate at 0.5 vertex spacing. The first click often leaves foliage floating and doesn't update the cell until you keep operating.
Changing region size twice (1024-512-1024) prevented me from removing instances. I could add. Changing again made some regions worth of instances go away.
This was an issue, then it wasn't, so I'm not sure now: Godot saves instances to disk even if we say don't save. If it crashes, it only saves partially. This is the biggest concern w/ crashing: corrupted data. So far I haven't found a definitive example of losing data after I've saved.

Usage

remove_instances operates much faster than add_instances now. Before they operated at the same speed so you could thin out instances. If you wanted quick removal you could increase the speed. Now it is only fast.
Removal slope filter being smaller than the add slope filter is an annoyance we should address. Just pressing alt is an easy workaround.
It would be good to offset the MMIs to the center of their cell location so we can expose visible distance.

Crash on close seems nullified if instancer::_backup_region() isn't called. It will crash if there is some instance data, and it's backed up via instancer or editor. It could be that Godot is freeing Terrain named resources (eg Terrain3DRegion) from the undo data after unloading the GDExtension. I was able to get the crash on the main branch. I think the current setup has aggravated the situation. Maybe we can manually free the editor data on scene close or something.
I found another crash. Add some instances, change vertex_spacing to 2, add more, reset to 1. If it doesn't crash then change spacing a bit more and it will crash in _destroy_mmi_by_location() calling _destroy_mmi_by_cell(). access violation. **cell_pair** was 0x10. Likely update_mmis is inserting a null somewhere that is triggered by set_vertex_spacing. I'm not sure how to check if the cell_pair iterator is null.
Fixed: Labels and MMI visibility do not turn off with the Terrain3D node.

Slope improvement is great.

Vertex spacing is really solid now.

Sparse removal doesn't work. It's not possible to thin out a large area with an even distribution. Instead, it produces hot spots in a grid shape. Moderately cover a large area, then try to evenly, lightly remove at 10%.

Solving that removal problem is going to need some work
Density per cell needs reducing by the ratio of (cell area inside the radius of the ring : full cell area)

The original went:

Grab the transforms data
For the quota, if there's a Transform in the ring, drop it

This goes:

for each cell

Get the xforms (for that cell)
Remove the quota (from that cell)

What about:

for the quota

while something not removed or processed a random order of each cell in the circle

remove an instance within the circle

There's a crash in remove_instances. If one selects CTRL+SHIFT to remove all and the region does not have all N mesh types in  the asset dock, it will crash on the bottom line with an invalid index.
int mesh_count = _terrain->get_assets()->get_mesh_count();
for (int r = 0; r < region_queue.size(); r++) {
	Ref<Terrain3DRegion> region = data->get_region(region_loc);
	_backup_region(region); // Note: region hasn't changed yet and might not. Move lower
	Dictionary mesh_inst_dict = region->get_instances();
	Array mesh_types = mesh_inst_dict.keys();
	if (mesh_types.size() == 0) {
		continue;
	}
	// For this mesh id, or all mesh ids
	for (int m = (modifier_shift ? 0 : mesh_id); m <= (modifier_shift ? mesh_count - 1 : mesh_id); m++) {
		int mesh_id = mesh_types[m]; // Crash

Your last fix did pretty well to fix the crash and being able to remove other non-selected meshes. Continuing to test things went well until I CTRL+SHIFT removed a selection of 5 mesh types. As I got to the end of the instances this warning popped up many times for all of the mesh ids.
WARNING: Terrain3DInstancer#5838:remove_instances: Region at: (0, 0) has instance dictionary for mesh id: 4 but has no cells.
It did remove the instances properly. However running the dump_data function I see the mesh_inst_dicts are still present, though they have no cells. They need to be erased from the parent instances dict. Though I do see a check for it in the code, but apparently it's not happening (or being done to a copy).
I updated swap_ids and removed some other functions we don't need. We're getting close.

More testing on the crash on close:

The object it's crashing on is a Terrain3DRegion. It's an engine bug, attempting to call is_class() on it after freeing the library.
It has no issue with the first three loaded demo regions. Upon creating backups the questionable instance is either the first (original duplicate) or second (redo duplicate) created.
I also figured out how to clear the undo history on exit but that doesn't solve the issue.
I nullified region::duplicate() and even renamed it in case it was calling the base class, but no change.
The crashing code is only supposed to run if --verbose is specified, in the section printing out leaked instances. If you run from the command line it shouldn't crash. However I run with the msvc debugger, and though I don't specify --verbose, it does trigger the specific code.
I've narrowed down the circumstance that initiate the crash down to a single line:

void Terrain3DEditor::_store_undo() {
	IS_INIT_COND_MESG(_terrain->get_plugin() == nullptr, "_terrain isn't initialized, returning", VOID);
	if (_tool < 0 || _tool >= TOOL_MAX) {
		return;
	}
	LOG(DEBUG, "Finalize undo & redo snapshots");
	Dictionary redo_data;
	// Store current locations; Original backed up in start_operation()
	redo_data["region_locations"] = _terrain->get_data()->get_region_locations().duplicate();
	// Store original and current backups of edited regions
	_undo_data["edited_regions"] = _original_regions; // ** causes latent crash **
	redo_data["edited_regions"] = _edited_regions;

I can return right before that line or comment it out and it won't crash. If I return right after or leave it uncommented it will crash.

_original_regions and _edited_regions are both TypedArray.
_undo_data and redo_data are both dictionaries, but the first one is a class member.

Alternatively, clearing the dictionary rather than reassigning it also prevents the crash. However it breaks our undo/redo. Still this suggests maybe the issue is in GDExtension instead of Godot.
void Terrain3DEditor::start_operation(const Vector3 &p_global_position) {
	IS_DATA_INIT_MESG("Terrain isn't initialized", VOID);
	LOG(INFO, "Setting up undo snapshot");
	_undo_data.clear();
	//_undo_data = Dictionary(); // New pointer instead of clear

I'm bug reporting now, then will attempt to figure out a solution to make a new data pointer without triggering the bug.

Using the default values of 20m/33% I made the following shapes. Then I found I could not remove any at 20m/33%, 100%, nor 1000%.

I bumped it up to 100m/100% and found I could start to remove some instances if I centered the cursor in the red area so the edge of the circle was brushing the instances. It's still difficult to remove those that remain. It takes a lot of scrubbing on the edge of the ring, then it gradually removes more and more.

should be working better now.
the remove rate decreasing as there are fewer and fewer instances remaining insiide the ring is invevitable with a low % strength, personally i find that more desirable for the most part, as over-shooting remove means undo or repaint.
I think its tollerable given the option to just use a higher strength value.
could also tweak the threshold a bit if wanted, currently its 0.15, but maybe 0.2 or even 0.225 could be ok, tho likley too fast compared to add instances rate.


Flush gave 6-cards combination for standard game

For hand Jd, Ac, Ad, 7d, Qd, 4d, Td i get this result. You can notice there is 6 cards in the result combination.


Test Java 16

Test if SecHub works with Java 16.

This depends on: #609

Tried it with AdoptOpenJDK 16 Hotspot, build failure:
Could not open settings generic class cache for settings file '/user/sechub/settings.gradle' (/user/.gradle/caches/6.9/scripts/2nvsf65n6lje61vw61ev2vjc1).
> BUG! exception in phase 'semantic analysis' in source unit '_BuildScript_' Unsupported class file major version 60

For more details see: https://github.com/gradle/gradle/issues/13481
Gradle 7.0 is required to be able to support Java 16. Test it again after #495 is closed.

Can be closed as Java 17 is already released and Java 17 is a long term support version.


Keep User Logged In

Related Issue

Fixes #174 .

Proposed Changes

Change 1 Use Stream Builder
Change 2

Additional Information

Any additional information about the change

Checklist

[x] Tested
[x] No Conflicts
[x] Change In Code
[ ] Change In Documentation
[x] Follows linting rules

Screenshots

Before this PR
After this PR

** Original Screenshot **
** Updated Screenshot **

Okay
On Wed, 7 Apr, 2021, 3:11 pm HIMANSHU SHARMA, @.***>
wrote:

@.**** requested changes on this pull request.
In lib/main.dart
https://github.com/himanshusharma89/relic_bazaar/pull/181#discussion_r608500556
:

@@ -45,27 +48,45 @@ class MyApp extends StatelessWidget {
}
},
child: MaterialApp(

   builder: (BuildContext context, Widget child) {

You removed this configuration also, pull the code again and rebase your
code.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/himanshusharma89/relic_bazaar/pull/181#pullrequestreview-629802786,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANSA7LJ66LHDD2L2BTRHUJTTHQSC3ANCNFSM42PII23A
.


Correct case of candidate names

Background
There is a case inconsistency across candidate records that should be corrected so that they appear uniformly on the platform, in panel packs, etc.
User Story
As JAC, I would like the case of candidates' names to be correct so that they appear uniformly across the platform.
Feature(s) Description

[ ] Apply: however candidates enter content into the fields - title, first name, middle name(s), last name, suffix, previous known name(s), and professional name - the following should apply:
First letter of each word is capitalised and the rest are lower case
If names include a '-', the letter after the '-' should be capitalised
[ ] Admin: run a script on the candidate database that corrects candidate names as above
[ ] DP: is any activity required on DP?

Acceptance Criteria
It's done when candidate names display consistently across the platform as described above.
Definition of Done

[ ] User stories/acceptance criteria met
[ ] Internal reviews passed (feedback actioned)
[ ] User testing passed
[ ] Relevant technical documentation updated
[ ] User guidance updated
[ ] Deployed and merged without errors

User Testing Steps
Specify for users what is being tested (but not how to test it.)
Feature Champion
Nick

Hey team! Please add your planning poker estimate with Zenhub @drieJAC @HalcyonJAC @tomlovesgithub @warrensearle

Perhaps we should consider returning names exactly as candidates input them - its not considered good practise to make assumptions about names.


Add note about details handling for Opsgenie

With the merge of https://github.com/prometheus/alertmanager/pull/2276 all common labels are included in the OpsGenie details by default.

Thanks.
@simonpasquier Should this be merged now, or on the next release?

That should wait.

Moved to https://github.com/prometheus/alertmanager/pull/2305


Adhearsion does not detect DTMF on Asterisk 12

Adhearsion currently expects DTMF events with Start and End attributes. Asterisk 12 (AMI v2) provides DTMFStart and DTMFEnd events.

With Punchblock 2.7.0 it now does. See https://github.com/adhearsion/punchblock/issues/245.


MSID: 87719 Version: 2 DOI: 2<IP_ADDRESS>2720

[PLACE MANUSCRIPT AND EDITOR DETAILS HERE WHEN AVAILABLE] See step 3
[PLACE PDF URL HERE WHEN AVAILABLE] See step 7
Step 1. Inform bioRxiv
Who can help: @QueenKraken, @nlisgo, @scottaubrey

[x] Manuscript is in data hub index (https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=87719)

Step 2. Create preview of manuscript
Who can help: @fred-atherden, @nlisgo, @scottaubrey

[ ] Manuscript is available for preview (https://prod--epp.elifesciences.org/preview/87719/v2)

[ ] Trigger import for staging: https://prod--epp.elifesciences.org/import
[ ] Sync data folder with s3://prod-elife-epp-data/data
[ ] Trigger import for staging: https://staging--epp.elifesciences.org/import
[ ] Sync data folder with s3://staging-elife-epp-data/data
[ ] Pull request created to enhanced-preprint-data
[ ] Post link to pull request below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-manuscript
Step 3: Awaiting public reviews and QC
Who can help: Production team

[ ] QC passed or QC not needed

Who can help: Editorial team

[x] Public reviews available on sciety (https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>2720)
[ ] Manuscript and editor details at the top of this issue (Supplied by Editorial team)
[ ] Reviews returned by EPP - https://prod--epp.elifesciences.org/api/reviewed-preprints/87719/v2/reviews

Example
"msas": "Genetics and Genomics", "Neuroscience"
"msid": "84628"
"version": "1"
"preprintDoi": "10.1101/2<IP_ADDRESS>4241"
"articleType": "Reviewed Preprint"
"status": "Published from the original preprint after peer review and assessment by eLife."

"Reviewed Preprint posted": "2023-01-02"
"Sent for peer review": "2022-10-28"
"Posted to bioRxiv": "2022-11-21" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>4241v1")

Editors:
Reviewing Editor
Michael B Eisen
University of California, Berkeley, United States
Senior Editor
Michael B Eisen
University of California, Berkeley, United States

Step 4: Modify manuscripts.json (no PDF)

[ ] Reviewed preprint is published to EPP (https://elifesciences.org/reviewed-preprints/87719)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[ ] Request that a doi be registered

[ ] Post link to #enhanced-preprint comment below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]

Instructions to modify manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/publish-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/334/files
Once the pull request is merged in it should be available a few minutes later.

Request that a doi
Post the following in #enhanced-preprint:
@Fred can you register a doi for https://elifesciences.org/reviewed-preprints/87719

Step 5: Awaiting search reindex

[ ] Reviewed preprint is avaliable on journal homepage (https://elifesciences.org)

The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.

Additional info
If needed, the jenkins pipeline to reindex search can be triggered sooner.
https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 6: Published! Request PDF generation

[ ] Post the link to the PDF url at the top of the issue

[ ] Post link to #enhanced-preprint comment below

#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]
Post the following to the #enhanced-preprint on slack:
@Ryan Dix-Peek please can you generate a PDF for https://elifesciences.org/reviewed-preprints/87719

Step 7: Introduce PDF to data folder and git repo

[ ] PDF is avaliable at https://github.com/elifesciences/enhanced-preprints-data/raw/master/data/87719/v2/87719-v2.pdf

Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-pdf
Step 8: Add PDF url to manuscripts.json

[ ] Reviewed preprint PDF is available for download (https://prod--epp.elifesciences.org/reviewed-preprints/87719)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[PLACE LINK TO PULL REQUEST HERE]

Instructions to add PDF url to manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/add-pdf-url-to-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/397/files
Once the pull request is merged in it should be available a few minutes later.

Step 9: Done!

[ ] Kettle is on!

elocations missing from references.


Is a pre-built JWKTL database dump available?

Hi, sorry to post this as an issue, but I figured this would be the best form of communication. I'm wondering whether there are any dumps of the scraped data available which I can play around with? I'd really love to use this project, but am hesitant to learn Java and troubleshoot my way to creating my own database without knowing whether it'll be useful for my purposes.
Thanks for your team's work on this!

Unfortunately, there are currently no public dumps. However, the dumps are using a quite specific data format anyway, so it is highly recommended to access it with the API - and having the API running should make it easy to parse a dump as well, just make sure to set enough memory.


Add send/receive url collector stream message and testcode

Fixes https://github.com/aicers/giganto-client/issues/87

Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (72f17ed) 33.48% compared to head (659695f) 35.21%.

Files
Patch %
Lines

src/publish.rs
94.73%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##              tis      #89      +/-   ##
==========================================
+ Coverage   33.48%   35.21%   +1.72%
==========================================
  Files          13       13
  Lines         654      673      +19
==========================================
+ Hits          219      237      +18
- Misses        435      436       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

가능하시다면 다음 브랜치들은 작업 브랜치명을 tis/xxx 요렇게 해주시면 감사하겠습니다. (현 PR은 이대로 괜찮습니다)


add db icon

Any idea why this icon got removed in the first place?

Any idea why this icon got removed in the first place?

I don't remember removing it, but I think I was the last person to mess with prime icons.  Apologies, I may have accidentally fat fingered/deleted it.


ts2fable generates incorrect import directives

Description
If I run ts2fable on an input file with exports the
[<Import()>]

statement has only one string, but Import now requires two
Repro steps

Pick a valid .ts.d file ( I used the one from moment.js in npm )
Run ts2fable on this file

Expected behavior
Generated code should be valid for use within a project with statement like
    type [<Import("*","moment")>] Globals =

Actual behavior
type [<Import("moment")>] Globals =

Known workarounds
Edit the statements in the generated code to add the missing value.
Related information

Operating system Windows 10
.NET Runtime, CoreCLR or Mono Version 4.6

Actually this was already fixed but I forgot to update the npm package, sorry! I've published a new version numbered 0.1.14, can you please try that?
In any case the TypeScript parser needs (almost) a full rewrite using the TS type checker. I'm waiting until TS 2.0 is released as the compiler services are expected to change quite a bit. In the meantime, if you want to parse a definition file please tell me and I can give you a hand if necessary. We can also add it to the repo and npm for other users as well.

Tried 0.1.14 and confirmed fixed. Thanks


Allow integrating with Krant app news

Provide api for plugins to register news items to be added to the
configured news collection.
See https://github.com/codevise/krant

Coverage increased (+0.001%) to 99.205% when pulling 3eb152d68f5aa955bffd178878e560cc72fe23db on tf:krant into 99143f6a81ad743a6dd1102db8a6d7918305660b on codevise:master.

Coverage increased (+0.001%) to 99.205% when pulling 9bd43c30cd5f744a6c8a7ff9b68cc8d6e0145027 on tf:krant into 25b166eab8461415e03ebbe1affc42e2c7e1b461 on codevise:master.

Coverage increased (+0.001%) to 99.205% when pulling 9bd43c30cd5f744a6c8a7ff9b68cc8d6e0145027 on tf:krant into 25b166eab8461415e03ebbe1affc42e2c7e1b461 on codevise:master.


Recolor all labels in dark theme

Description

Updated all colours of the labels in dark theme to be white for visibility purposes
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Code quality improvements

How to test

Checklist

[ ] I have tested this code
[ ] I have updated the documentation

Codecov Report

Merging #202 (d0ee662) into master (99ea82f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #202      +/-   ##
============================================
+ Coverage     67.68%   67.69%   +0.01%
  Complexity      767      767
============================================
  Files           117      117
  Lines          2692     2693       +1
  Branches        286      286
============================================
+ Hits           1822     1823       +1
  Misses          753      753
  Partials        117      117

Impacted Files
Coverage Δ

src/main/java/seedu/address/storage/ThemeList.java
88.23% <100.00%> (+0.73%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99ea82f...d0ee662. Read the comment docs.


Rename boot services' memset to set_mem

In boot.rs we see there is an unsafe function named memset. This function has a signature different than memset(3), but has a name different than that in the edk2 sources. This is confusing and will lead to bugs in a very unsafe function when people mix up the order of the value and the size.
We should name the function set_mem and give it the signature from EFI_SET_MEM.
uefi-rs/src/table/boot.rs
Line 529 in 948464c
 pub unsafe fn memset(&self, buffer: *mut u8, size: usize, value: u8) {

See #232

Note that I made this PR entirely through the web UI to see how useful that workflow is, and have not run the tests locally. I am relying on travis CI to catch bugs.

Also, I have elected to rename the function set_mem. It's possible to hardcode two integers in both the value and size arguments of the old memset which would be wrong but still valid. I.e.
memset(ptr, size: 255, val: 255) -> memset(ptr, val: 255, size: 255)

If we rename the function this silent breakage can't happen.

@iankronquist I think some tests failed since they have to be updated to the function's new API.

I think I fixed it but Travis doesn't seem to be checking in with GitHub. This new GitHub checks feature seems more brittle than it was a few years ago?

I think I fixed it but Travis doesn't seem to be checking in with GitHub.

Yeah, it's a minor security change GitHub made :sweat_smile: the CI doesn't run automatically for first time contributors of a project, I have to manually approve running the flows after you make some changes.

Thanks for contributing. I've pulled the latest changes from master and merged the PR.


SDK 0.9.6 js:DataGridPercentageView/ bead work only on header DataGrid, not on cells

Hi,
Let't take this code
<js:Application xmlns:fx="http://ns.adobe.com/mxml/2009"
			   xmlns:js="library://ns.apache.org/royale/basic"
               applicationComplete="ev_applicationComplete()" >

	<js:valuesImpl>
		<js:SimpleCSSValuesImpl />
	</js:valuesImpl>

    <js:initialView>
        <js:View>
            <js:DataGrid id="mydg" width="100%" height="400" rowHeight="40">
                <js:beads>
                    <js:DataGridPercentageView/>
                </js:beads>
                <js:columns>
                    <js:DataGridColumn label="label" dataField="label" columnWidth="50" />
                    <js:DataGridColumn label="value" dataField="value" columnWidth="50" />
                </js:columns>
            </js:DataGrid>
        </js:View>
    </js:initialView>

	<fx:Style>
		@namespace js "library://ns.apache.org/royale/basic";

		.DataGridColumnList .StringItemRenderer {
			border-style: solid;
			border-color: #CCCCCC;
			border-width: 1px;
			background-color: #ffffff;
			line-height: 40px;
			padding: 2px;
		}

		.DataGridColumnList .DataItemRenderer {
			border-style: solid;
			border-color: #CCCCCC;
			border-width: 1px;
			background-color: #ffffff;
			line-height: 40px;
			padding: 2px;
        }

	</fx:Style>

    <fx:Script>
    <![CDATA[
        private var ar:Array = ["Bob", "Joe", "Frank", "Sally"];

        private function ev_applicationComplete():void {
            mydg.dataProvider = ar;
        }

    ]]>
    </fx:Script>
</js:Application>

Here is the result

Here is to help you correct the SDK

In the DataGridPercentageView function handleInitComplete
...
      if (!isNaN(dgc.columnWidth)) {
        list.width = NaN; // <= we set NaN to width but it doesn't work
        list.percentWidth = Number(colWidth);
      }
...

I think the issue is here in UIbase.js
org.apache.royale.core.UIBase.prototype.setWidth = function(value, noEvent) { // Enter in function with value = NaN
  noEvent = typeof noEvent !== 'undefined' ? noEvent : false;
  if (this.org_apache_royale_core_UIBase__width !== value) {
    this.org_apache_royale_core_UIBase__width = value;
    this.positioner.style.width = value.toString() + 'px'; // <== HERE when value = NaN this.positioner.style.width is unchanged
    if (!noEvent)
      this.dispatchEvent(new org.apache.royale.events.Event("widthChanged"));
  }

I believe that in UIbase function setWidth , this.positioner.style.width sould be set to NaN and not value + "px" if value is NaN

Hi Fred, I'm not familiar with Basic DataGrid and that bead, so the following is just a guess.
A bead use to affect to the strand, in this case the DataGrid, but columns and cells will be in this case sub components in the DataGrid tree. So tho affect those internal components the bead should have logic to access the subcomponents and its views. Don't know if the problem is the bead does not implement that logic or was doing until now but has a bug now... hope that helps to find the problem, or maybe others can give you more help on this.

Hi Carlos,
Thanks for your comments. I think the bug is easy to fix, as describled in my previous post.
The bead override handleInitComplete function and discard width style to set percentwidth
Unfortunaly to discard width style the following line doesn't work because of setWidth in BaseUI doesn't handle NaN value.
list.width = NaN; // <= doesn' work
If modfify this function (setWidth  in BaseUI.as) to handle NaN then it should be working
this.positioner.style.width = value.toString() + 'px';  //must be replace by something like
if (value == NaN){
this.positioner.style.width = ''; // I'm not sure if need null or empty or removeStyle
}else{
this.positioner.style.width = value.toString() + 'px';
}

By the way I wanted to try to patch SDK but I don't know how to build it. I read some docs on it. Do you know the easier mathod (maven or ant) ?

Hi Fred,
I recommend you Maven and ANT to develop the SDK. I have a shell script that builds compiler, then typedefs and finally framework with Maven from latest source code. Then I pass ANT to build SDK (this is because SDK creation with Maven is not currently working). The SDK is created in the royale-asjs repo folder and I use it in my IDE. The ANT pass is not needed most of the times, but doing it you can try the SDK on an IDE an ensure all is ok from all points of view. @greg-dove has the same shell script than me for Windows, while I have it for Mac, depending on your platform we can share it in a Gist

Hi,
I dig a little more on this bug.
The issue is that the DataGridPercentageView handle only InitComplete event by modify element width and set it in %. So all is right, but after there is the layoutNeeded event wich is fired. And the issue is because that event is handle by DataGridLayout function layout(). That function iterate over columns but doesn't know if column width is px or % and handle like if it's px and set width like this :
columnList.width = columnWidth;
So it overwrite width settings and so DataGridPercentageView is useless.
For now, as I don't know well SDK architecture , I suppose that  DataGridPercentageView must override DataGridLayout 's layout function to handle properly column width ?
@carlosrovira could you tell me your opinion ? Who know the best this part of SDK ? Thanks

Hi Fred,
I must admit DataGrid component is still uncovered by me. At some time I should create a Jewel DataGrid, but since I really don't need it and is more a fun exercise for me, my current interest is more on continue documentation needs, and other support/help needs to make Royale more "round" tech.
While hope others like @aharui, @yishayw or @piotrzarzycki21 that are more close to that piece of code, I only can give some opinion that could not be accurate.
I don't understand why a DataGridPercentageView bead exists, since the layout bead should be capable to manage width changes in exact pixels and percentages. To solve the issue  you can try to fix the layout (trying to get rid of DataGridPercentageView) and see if that's possible. Sorry to not be of much help here, as you dig into the code and debug it I'm sure you could get to problem's core.

Hi Carlos,
Thanks for your help. I have issue after about 2 hours (Too many files
with unapproved licence : 548 see RAT report), but I don't have done all
steps because I only want to compile SDK 0.9.6 and use bin for other
tools (it seems to me easy but I'm perhaps wrong). If I run again
D:\dev\Royale\apache-royale-0.9.6-bin-js\royale-asjs>mvn -s
settings-template.xml clean install -Pgenerate-swcs-for-swf I have same
issue after 20seconds
If you agree, I will open a topic on SOF of our discuss, and detail what
I have done, this could be more useful for futur Guys who attemps to
compile SDK ?
Le 18.10.2019 11:20, Carlos Rovira a écrit :

Hi Fred,
I recommend you Maven and ANT to develop the SDK. I have a shell script that builds compiler, then typedefs and finally framework with Maven from latest source code. Then I pass ANT to build SDK (this is because SDK creation with Maven is not currently working). The SDK is created in the royale-asjs repo folder and I use it in my IDE. The ANT pass is not needed most of the times, but doing it you can try the SDK on an IDE an ensure all is ok from all points of view. @greg-dove [1] has the same shell script than me for Windows, while I have it for Mac, depending on your platform we can share it in a Gist
--
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub [2], or unsubscribe [3].

Links:
[1] https://github.com/greg-dove
[2]
https://github.com/apache/royale-asjs/issues/519?email_source=notifications&email_token=ABUIW2O6I7WA77HIG6IPLSTQPF5VTA5CNFSM4JB7ZUJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBTQZFA#issuecomment-543624340
[3]
https://github.com/notifications/unsubscribe-auth/ABUIW2PFWZAGZS3EHMBT5RLQPF5VTANCNFSM4JB7ZUJQ

Hi Fred, I think SOF is maybe more suited for end users that need to know some topic that is always the same for all. In this case is more about to know what is failing in your current config that could be something just for your case, and maybe less important as a "general rule".
The problem:
Too many files with unapproved licence : 548 see RAT report

is because we have setup in Maven the RAT maven plugin that checks all files has the Apache license header. You can see the RAT report generate in target folder to see what files does not have it. Usually this files are new files you created.
HTH
Carlos

One more thing. I think you can build only SDK with ANT if is what you want. In that case I think you need to first do a "ant super-clean". Check my Gist since there I have all ANT instructions needed to clean each repo. Since I always run first Maven and then ANT for the SDK, right now can't ensure if you can create just SDK with ANT without ruining Maven first. My advice is that you try the steps in my Gist since are the best way to work ensuring things will not blow up when you submit a PR to us. For example, RAT is not present in ANT. If you forgot the license header, the build will blow up when we integrate your PR, and a fix adding it will be needed.

Hi Carlos,
Thanks for your patience, I'm a totaly newbie on SDK building, so a lot
of questions, if you could clarify some, it would be great.

I think SOF is maybe more suited for end users that need to know some topic that is always the same for all

I understand. Perhaps I could open a newtopic on issues on github ?
that's because this discuss is about SDK building. Following is what I
would to ask :
As a newbie on SDK building,  I ask myself several questions that
https://github.com/apache/royale-asjs/wiki/Build-Apache-Royale-with-Maven
doesn't answer. I lack of a global view of process

I believe it's easier to download and compile fixed official version
(0.9.6 from
https://www.apache.org/dyn/closer.lua/royale/0.9.6/binaries/apache-royale-0.9.6-bin-js.zip
) than trunk branch from git because I'm sure to be able to compile SDK
without any errors. I'm right ?

I believe I can (re)compile only SDK without royale-compiler and
royale-typedefs (because they are already in_
apache-royale-0.9.6-bin-js\royale-asjs\js\bin_ folder) and output of SDK
re-compile would be in apache-royale-0.9.6-bin-js\royale-asjs\js\libs.
Right ? (or apache-royale-0.9.6-bin-js\royale-asjs\target ?)

(if right on 2) => On
https://github.com/apache/royale-asjs/wiki/Build-Apache-Royale-with-Maven
can I skip step 2,3,4 ? And do I need Flash Player projector content
debugger if I want js only SDK ?

To do step 2 I go directly in
apache-royale-0.9.6-bin-js\royale-asjs folder and run_ mvn -s
settings-template.xml clean install -Pgenerate-swcs-for-swf_

I saw some lines showing "0.9.7" when doing 4) . So I'm not rebuild
0.9.6 doing 4) ?

At the end of process of 4) I have issue 548 Unknown Licenses like

examples/royale/TourDeJewel/bin/js-debug/AdvancedListPlayGround.js
examples/royale/TourDeJewel/bin/js-debug/AdvancedListPlayGround.js.map
examples/royale/TourDeJewel/bin/js-debug/AlertPlayGround.js
....So, I think I'm totaly wrong on my process to rebuild only SDK 0.9.6
from
https://www.apache.org/dyn/closer.lua/royale/0.9.6/binaries/apache-royale-0.9.6-bin-js.zip
?
Le 21.10.2019 13:33, Carlos Rovira a écrit :

Hi Fred, I think SOF is maybe more suited for end users that need to know some topic that is always the same for all. In this case is more about to know what is failing in your current config that could be something just for your case, and maybe less important as a "general rule".
The problem:
Too many files with unapproved licence : 548 see RAT report
is because we have setup in Maven the RAT maven plugin that checks all files has the Apache license header. You can see the RAT report generate in target folder to see what files does not have it. Usually this files are new files you created.
HTH
Carlos
--
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub [1], or unsubscribe [2].

Links:
[1]
https://github.com/apache/royale-asjs/issues/519?email_source=notifications&email_token=ABUIW2IFDV4F4VI5OX3CDBTQPWHR5A5CNFSM4JB7ZUJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB2AGKY#issuecomment-544473899
[2]
https://github.com/notifications/unsubscribe-auth/ABUIW2NAQPFT4MI2LYDU5DDQPWHR5ANCNFSM4JB7ZUJQ

Hi Fred,

SDK or "binaries" is what we finally expect final user to download and use, since is the code "released". For that reason "nightly-builds" or actual code in develop branch use not to be what Apache want us to promote, since that code is not "release" and due to change at some point.
Being said that, we always try to have "develop" branch stable and compiling. If we need to do a new feature, that should happen in other branch and when stable merged back to develop. So you should always be able to compile develop without problem.

A year ago, you need to work from develop, since there was many changes daily. Today it starts to be ok to work from a release (like 0.9.6), since Royale is now usable. We expect that very soon (maybe from current 0.9.6), users not need to be in develop as the past year.

Don't think so. That will only work if changes in asjs are not related to others in compiler or typedefs. Is better to be always aligned.

3-4) You need to follow step by step that guide and report if something is not going ok in some step. You can't left one, since that will produce problems. If you find something not working, then stop and report that.
5 - 6). If you build from develop, you should only see 0.9.7 artifacts in your .m2 folder. paths like this: TourDeJewel/bin/js-debug, means you mixed things. Maven always compiles to "target" folders. And you always need to clean all before re run all. For this reason I created the Gist, since in that Gist the steps are:
1.- clean compiler, build compiler with maven
2.- clean typedefs, buid typedefs with maven
3.- clean asjs, buid asjs with maven
4.- build SDK in asjs with ANT
if you try to build with maven without clean, maven will fail since you'll have things builded from a older try and the process will fail when find that files.
If you have a shell script you can pass it daily as you start your day to ensure you're working with latest code. The whole process in my macbookpro is about 7' 21'' that I use to do early in the morning.
HTH

Hi Carlos,
Thanks a lot for your message and to correct my thinks about building SDK.
So, I will try step by step and report if there is an issue
Regards


Binary data not shown in kubectl describe configmap

To reproduce:
Create a config map from 2 files: one file is text, the other is a png. The text file will become a key in data field, whereas the png will become a key in binaryData field (this partially answers #20849).
Example:
$ kubectl create cm test-bin --from-file vimrc=.vimrc --from-file binary.png=/var/lib/docker/.../screenshots/basic-usage-with-colors.png
configmap/test-bin created
$ kubectl get cm test-bin -o json | jq '.data | keys'
[
  "vimrc"
]
$ kubectl get cm test-bin -o json | jq '.binaryData | keys'
[
  "binary.png"
]

The kubectl describe cm only shows data, not binaryData:
$ kubectl describe cm test-bin
Name:         test-bin
Namespace:    default
Labels:       <none>
Annotations:  <none>

Data
====
vimrc:
----
set expandtab
...
set paste

Events:  <none>
$

Proposed Solution:
How about I submit a PR that updates https://kubernetes.io/docs/concepts/configuration/configmap/#configmap-object:

I would indicate that describe does not currently (as of 1.20) show binaryData
I would fix the describe command so it shows a binaryData section, with key names and the number of bytes of each value (the actual bytes does not have much practical value)

I suggest deleting:

How about I submit a PR that updates https://kubernetes.io/docs/concepts/configuration/configmap/#configmap-object:

from this issue. This repository is for issues about the kubectl code more than about its docs.

I suggest deleting:

How about I submit a PR that updates https://kubernetes.io/docs/concepts/configuration/configmap/#configmap-object:

from this issue. This repository is for issues about the kubectl code more than about its docs.

@sftim deleted

@sftim deleted

@schollii Would be happy to have you work on this!
/triage accepted
/priority backlog

@schollii Would be happy to have you work on this!
/triage accepted
/priority backlog

@eddiezane I can try to take a look at this
/assign


visual-studio-code.rb: add bin

The tests are failing with:
1: stanza groups should be separated by a single empty line

Merged as 8bbd2cf736dccdb8e9e5793cdf5974c488cfe37b.


Fix API docs for adding property

Small mistake.

@ktuite is the content type for adding properties and datasets really supposed to be / and not application/json? https://github.com/getodk/central-backend/blob/master/docs/api.yaml#L10002