make patterns the first arg?

This is a major breaking change, and it's probably a bad idea given that minimatch has gotten everyone used to passing patterns as the second arg, but I've always strongly disliked it and found it confusing.
I'm curious if anyone else agrees with this.
This is the current signature, with pattern(s) usually the second arg:
mm(['a/b/a.md', 'a/b/b.md', 'a/b/c.md', 'a/b/d.md', ], '**/*.md');

I think it makes more sense like this:
mm('**/*.md', ['a/b/a.md', 'a/b/b.md', 'a/b/c.md', 'a/b/d.md']);

This signature makes using the lib more consistent when arguments are partially applied to create matching functions, like var isMatch = matcher('foo/*.md'); which returns a function that could be passed to Array#filter for example.
Also, passing the pattern first feels more natural when regex is used instead of a glob pattern.
mm(/\.md$/, ['a/b/a.md', 'a/b/b.md', 'a/b/c.md', 'a/b/d.md']);

:+1:

:+1: for the primary API, but you should continue to provide methods that accomplish drop-in equivalency with matching signatures such as mm.multimatch(array, pattern) and mm.minimatch(string, glob)

Hmm, interesting. So actually add methods to provide parity? like a "minimatch" mode or "multimatch" mode?

Yeah, well at least just for the main functions. I think it would help people migrate, you'd just drop micromatch. in front of the existing minimatch calls.

Hm yea, interesting idea, but if someone is going to add micromatch in front of minimatch/multimatch its better to replace them with micromatch.isMatch() or/and mm() constructor.
Jon, one idea from yesterday - micromatch.base(string/array) - for getting the base path of glob(s), like base in .expand().tokens.base. Use case - I dont want to use whole expand to only get the base and dont want to require one more dependency - glob-base.

better to replace them directly with micromatch.isMatch() or/and mm() constructor

But now if this change is implemented they'll also have to change arg order. And maybe there will be other differences in the future. The thought behind my suggestion is reducing friction for adoption of this lib as a replacement for those well-established alternatives. The further micromatch deviates from what people are used to, the more friction there will be.

The further micromatch deviates from what people are used to, the more friction there will be.

Agreed, for this reason I think this is a bad idea. For my own tastes that's kind of a bummer, but it is what it is... closing

Anyone preferring the other order does already have the option of doing mm.matcher(pattern)(path), which is reasonably close.

true. and really, if I cared about it so much for my own projects I guess I could wrap it in a function and revers the args lol.

I did pretty much the same thing here https://github.com/es128/progeny/commit/9706276b4c36c0e05de1b68de54ac3e3609785c1 when I decided I needed args reversed to improve future cases but still needed to maintain compatibility with the original consumer.

great minds think alike! except mine thought it like 6 months later... takes me a while sometimes


Outdated de-serialization of topic response

When I run a request for a topic, the response is not deserialized properly. This is b/c the received JSON looks like this:
{
   "data":{
      "_id":"655b65b487e0d9949d7b4b70",
      "_environmentId":"655353e41bf45431ece3fddd",
      "_organizationId":"655353e31bf45431ece3fdd7",
      "key":"83f89d49-1c47-4217-a10c-26386e701bf4",
      "name":"Topic for 1963bc86-945b-4a9c-9728-4b03e752397c",
      "subscribers":[]
   }
}

, but the struct GetTopicResponse doesn't expect data but the inner item:
type GetTopicResponse struct {
	Id             string   `json:"_id"`
	OrganizationId string   `json:"_organizationId"`
	EnvironmentId  string   `json:"_environmentId"`
	Key            string   `json:"key"`
	Name           string   `json:"name"`
	Subscribers    []string `json:"subscribers"`
}

I can imagine this also applies to other requests I did not stumble upon. I could create a PR for GetTopicResponse, but I'm not sure whether that's the way to go or whether you're generating your SDKs from another place. :)

Same problem as with this issue #69 .

Same problem as with this issue #69 .

I got the impression that the whole SKD is heavily outdated. I found more and more situations where it was firing wrong requests. Additionally, it's often enough hiding errors and failure reports from responses. I guess one shouldn't really use it atm.
I hope they will opt for a solution where they generate the client based on the underlying data modell or API, instead of maintaining it manually. This would not solve the issue with swallowed errors, but at least keep the SKD up to date.  :/


Deploy protocol contracts on new chains

Deploy protocol contracts on the following chains:

boba-ethereum
boba-avalanche
boba-bnb
boba-moonbeam
arbitrum-nova
sx-network
sx-network-testnet
aurora
aurora-testnet
godwoken
godwoken-testnet

Use deterministic deployment whenever possible

documentation task here #1175


Make better use of loading indicators

I noticed that while the UI is waiting for data, whether it be my tools, my workflows, or search, instead of showing a loading indicator/icon we don't show anything.  It would make sense to just have a loading indicator and not even show the 'Add Tool' button until the my tools have been retrieved.
Another example is with the tools page. When datatable is loading the tools, you see the table header but then the rest is just blank. A loading icon here would be good.
┆Issue is synchronized with this Jira Story
┆Issue Type: Story
┆Fix Versions: Dockstore 2.X
┆Issue Number: DOCK-324

Duplicates #893

Interesting reading https://developers.google.com/speed/pagespeed

Loading indicators are present now


[HELP] Is it normal for the emote icon to not follow the theme color scheme?

What's your problem
I'd like to know if the emote icon in the box where one writes messages is it supposed to follow the theme color scheme or not
Additional context

Adding screenshot for clarity, emote menu icon is gray and different compared to the others

Known issue. It's not a svg and changes on hover, so it's hard to color. I'll change it to a static one.

Thank you for the info!
Great theme btw!
Going to close the issue :D

done


d3.extent() not returning true maximum and minimum of set for strings

Hello, it took me a little while to isolate it, but I'm pretty confident the bug is to do with this method.  Here is my test:
function extent_test()
{
test_set_numeric = [2.43, 12.113, 2.564, 6.9, 4.237, 1.779, 1.446, 1.526, 3.401, 11.204];
console.log(test_set_numeric);
console.log(d3.extent(test_set_numeric, function(d) { return d; }));
console.log("end test");
test_set_string = ["2.43", "12.113", "2.564", "6.9", "4.237", "1.779", "1.446", "1.526", "3.401", "11.204"];
console.log(test_set_string);
console.log(d3.extent(test_set_string, function(d) { return d; }));
console.log("end test");
}
And here is the console output through chrome's debugger on version 51.0.2704.63:

This behavior seems just quirky enough to be looked into as it appears not to follow the normal logic for sorting a string and seems like a potential pitfall for people reading their data in from jsons which have a tendency to stringify everything.

This is the expected and documented behavior and specifically what is meant by “natural order”. When computing the minimum, maximum or extent, the values are compared using JavaScript’s < and > operators. For strings this results in a lexicographic ordering:
"6.9" < "12.113" // false
6.9 < 12.113 // true

If you want numbers, you must coerce your values to numbers first:
var values = ["2.43", "12.113", "2.564", "6.9", "4.237", "1.779", "1.446", "1.526", "3.401", "11.204"];
d3.max(values); // "6.9"
values = values.map(function(d) { return +d; });
d3.max(values); // 12.113

You could use an accessor to do this, too, but it’s not recommended:
var values = ["2.43", "12.113", "2.564", "6.9", "4.237", "1.779", "1.446", "1.526", "3.401", "11.204"];
d3.max(values, function(d) { return +d; }); // 12.113

If you have JSON data, then you should probably be storing your values as numbers rather than strings, since JSON is typed. If you are using another format, such as CSV, then the best thing to do is using a row accessor to coerce the data as it is loaded. That way you won’t forget to do it later and cause problems downstream. Use a typed format or coerce to types as early as possible!

Alrighty!  My apologies for bringing up a documented behavior.  Thank you for the clarification.

No problem. Also forgot to mention that another reason it is implemented this way is to allow computing the min and max of objects that implement object.valueOf, such as Date objects.


Unrecognized function or variable 'kernelCenter'

I download this git Repo and then run source code by MATLAB R2021.
But I have some problems....

How can I solve this problem?

Have you installed the GPmat toolbox? That needs to be in the path for the code to work.


Add lotType to blacklist

Coverage remained the same at 82.441% when pulling 798ea89366acde9049adcf3cc65badee2a510eff on oleksiyVeretiuk:fix_roles into 610cddaacbe915f8df9d0c33dcfba23b7f22417e on openprocurement:master.

Coverage remained the same at 82.441% when pulling 798ea89366acde9049adcf3cc65badee2a510eff on oleksiyVeretiuk:fix_roles into 610cddaacbe915f8df9d0c33dcfba23b7f22417e on openprocurement:master.


Check for minimum Zsh version

Is your feature request related to a problem? Please describe.
Check for Zsh version for compatibility with prompt.
Describe the solution you'd like
autoload -Uz is-at-least && if ! is-at-least 5.2; then
  print "ERROR: You're using zsh version ${ZSH_VERSION}, and versions < 5.2 are not supported. Update your zsh." >&2
  return 1
fi

Is this still open? For future support, it would be a good idea to accept an argument for the min acceptable version, but default to a specific level if not provided.


Use consistent style of command description

Keep consistent style and use imperative mood in command description.

Ooh.. didn't know that one. Learned something new today, thanks @alexesprit ! Merged


Update XML from upstream

Do not merge yet. I think we have a new method to add to the Socket proxy.

Why did this branch before your CI fix? Strange.

It did not, I sneakily added a 'fix'.
Unfortunately it does not seem to fix anything..
The error messages looked like this:
No XML path provided and default XML path not found. Current dir: "/home/runner/work/atspi/atspi/atspi-common"

Setting the environment variable to "../xml" broke things in more interesting ways. Not sure what is going on.
It cannot find the directory and I see other problems pop-up that do not make sense at all since all other CI tests succeed.
Do you understand this better?

TODO: implement Get/Set TextSelections for Document.


Hide Show-action-list options when disabled via editorTheme

Current Behavior

settings.js

editorTheme: {
        menu: {
             "menu-item-action-list": false
        }
}

Expected Behavior
Need to hide Show-action-list options and disable [ctrl+shift p] shortcut key.

Steps To Reproduce
No response
Example flow
No response
Environment

Node-RED version: v4.0.2
Node.js version: v20.9.0

Thanks for highlighting. I'll review all the menu actions and see what else needs handling.

I've updated PR #4869 to include a fix for this one.


Add 26 Jan Seminar

@jimmychu0807 please do not merge until we get approval from @dastanbeksamatov.
cc @EmilyOstbo

@danforbes So I will just approve first, you confirm the date and merge it.

@danforbes So I will just approve first, you confirm the date and merge it.

I have no idea why I closed this PR and deleted the branch 😅

I have no idea why I closed this PR and deleted the branch 😅


Removing entity from engine removes its components from memory, even if shared

This code doesn't work. Once the box is removed from the engine, adding it again doesn't render it:
const box = new Entity();
box.addComponent(new BoxShape());
box.addComponent(new Transform({position:new Vector3(8,0.11,8)}));
engine.addEntity(box);
engine.removeEntity(box);
engine.addEntity(box);

Something similar happens if I tried to use the shape that was previously used by a removed entity on a new entity. It seems like when removing from engine, the shape component is no longer available.
Here we should see the box2 entity, but it can't find a shape to be rendered with.
const shape = new BoxShape();

const box1 = new Entity();
box1.addComponent(shape);

engine.addEntity(box1);
engine.removeEntity(box1);

const box2 = new Entity();
box2.addComponent(shape);
engine.addEntity(box2);

In this other scene we see something that's surely related, and might throw more light into this:
When clicking box 1 you toggle box 2 on and off, but at the 3rd attempt, all boxes disappear.
add-remove-bug.zip
Weird fact:  If I add two more cubes to the scene (that don't do anything), I have to toggle the cube two more times to have it all break. It seems like we're losing one of the BoxShape components every time we remove the cube, and as long as at least one exists in memory the scene can work things out, until we run out of them.

It looks like the second example, the one in the attached zip, is no longer happening, that's fixed.
But the first problem, is still happening:
const box = new Entity();
box.addComponent(new BoxShape());
box.addComponent(new Transform({position:new Vector3(8,0.11,8)}));
engine.addEntity(box);
engine.removeEntity(box);
engine.addEntity(box);


[fontconfig] Build error on wasm32-emscripten

Operating system
MacOS 14.4.1 (Intel) and Windows 10
Compiler
em++
Steps to reproduce the behavior
`vcpkg install fontconfig:wasm32-emscripten`

Failure logs
Computing installation plan...
The following packages will be built and installed:
<EMAIL_ADDRESS>Detecting compiler hash for triplet wasm32-emscripten...
Compiler found: /Users/mattiamontanari/repos/emsdk/upstream/emscripten/em++
Restored 0 package(s) from /Users/mattiamontanari/.cache/vcpkg/archives in 13.4 us. Use --debug to see more details.
Installing 1/1<EMAIL_ADDRESS>Building<EMAIL_ADDRESS>/Users/mattiamontanari/repos/vcpkg/triplets/community/wasm32-emscripten.cmake: info: loaded community triplet from here. Community triplets are not built in the curated registry and are thus less likely to succeed.
-- Found Python version '3.11.7 at /opt/anaconda3/bin/python3'
-- Using meson: /Users/mattiamontanari/repos/vcpkg/downloads/tools/meson-1.6.0-ac58a9/meson.py
-- Using cached fontconfig-fontconfig-2.15.0.tar.gz.
-- Cleaning sources at /Users/mattiamontanari/repos/vcpkg/buildtrees/fontconfig/src/2.15.0-0e63e07859.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source /Users/mattiamontanari/repos/vcpkg/downloads/fontconfig-fontconfig-2.15.0.tar.gz
-- Applying patch no-etc-symlinks.patch
-- Applying patch libgetopt.patch
-- Applying patch fix-wasm-shared-memory-atomics.patch
-- Using source at /Users/mattiamontanari/repos/vcpkg/buildtrees/fontconfig/src/2.15.0-0e63e07859.clean
-- Found external ninja('1.12.1').
-- Configuring wasm32-emscripten-dbg
-- Getting CMake variables for wasm32-emscripten
-- Configuring wasm32-emscripten-dbg done
-- Configuring wasm32-emscripten-rel
-- Configuring wasm32-emscripten-rel done
-- Package wasm32-emscripten-dbg
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:127 (message):
Command failed: /usr/local/bin/ninja install -v
Working Directory: /Users/mattiamontanari/repos/vcpkg/buildtrees/fontconfig/wasm32-emscripten-dbg
Error code: 1
See logs for more information:
/Users/mattiamontanari/repos/vcpkg/buildtrees/fontconfig/package-wasm32-emscripten-dbg-out.log
Call Stack (most recent call first):
installed/x64-osx/share/vcpkg-tool-meson/vcpkg_install_meson.cmake:33 (vcpkg_execute_required_process)
ports/fontconfig/portfile.cmake:41 (vcpkg_install_meson)
scripts/ports.cmake:196 (include)
error: building fontconfig:wasm32-emscripten failed with: BUILD_FAILED
See https://learn.microsoft.com/vcpkg/troubleshoot/build-failures?WT.mc_id=vcpkg_inproduct_cli for more information.
Elapsed time to handle fontconfig:wasm32-emscripten: 1.1 min
Please ensure you're using the latest port files with git pull and vcpkg update.
Then check for known issues at:
https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+fontconfig
You can submit a new issue at:
https://github.com/microsoft/vcpkg/issues/new?title=[fontconfig]+Build+error+on+wasm32-emscripten&body=Copy+issue+body+from+%2FUsers%2Fmattiamontanari%2Frepos%2Fvcpkg%2Finstalled%2Fvcpkg%2Fissue_body.md
Additional context
No response

Possible duplication of 42463

#42463 is for an older version of fontconfig, failing during configuration.
This issue is for the current version of fontconfig, failing during build.
I can fix the build by disabling thread supprt, but then it still fails after the build because vcpkg_copy_tools doesn't know how to handle the wasm artifacts. (And I don't know either, in particular as they come in pairs of .js+.wasm.)

Oh wait, we can disable the tools.


Stuck card glitch?

Seed for this deck:
_3410814848879608485

I was trying to move the [9 √] (bat?) off the [squid] but the [squid] moved up from under the 9 leaving an empty space. The 9 is now hovering and can't be moved.

I was able to clear the two pirates...

... and two more cards...

... but this is what I'm left with. Nothing will move by dragging or double tap.

The End

I just played the deck again but could not replicate the glitch. :/


Better way to eliminate prefix in TMUX???

So I'm trying to think of an ideal way this could act as a proper plugin.
I'd want the user to be able to just add it and have all of their bindings now not have a prefix and just use some specified meta key to be able to control tmux with?
These settings work but they're sort of hacky and not very portable?
I tried thinking through a way to organize it so I didn't have to use the unbind -a but the issue is that I'm essentially doing that if I put in verbatim the unbind calls next to the new bind -n keys for the user to "Opt-in" to but the real heart of the issue is that TMUX operates with a prefix key? Wouldn't it be better to find or build a TMUX feature that gives you better control of how TMUX responds to the control/meta keys?
@bruno- Any thoughts???

Hey,
If you yourself are using these bindings then I think your plugin is fine.
Also it's really hard to fight tmux and its prefix. I encourage you to think about these bindings as an extension, not a replacement to what already exists.
Maybe you wanna "position" this plugin so that others can try it, without loosing the bindings they are already used to? If they find these bindings are better (or maybe just some of them are better), maybe they can gradually switch over.
A suggestion coming from this: do not force users to unbind all the keys. Just leave them as-is. From what I know existing bindings do not clash with the ones you are defining?


Improve regexp usage by reusing compiled regular expression objects

This is also thread-safe [0]
[0] https://pkg.go.dev/regexp#Regexp

Thank you @matiasinsaurralde!


feat(spanner): lifo order in sessions pool

IPR 9392

Currently sessions are handed out from the session pool in FIFO order. Least recently used sessions are unlikely to be in backend caches, and the transactions associated with them are likely to aborted due to idleness.
Solution
The session pool should hand out sessions in LIFO order.

@mf2199, I've run all the tests after changing the order - they are okay. In fact, in test no one had been checking the order at all. So, I believe, it wasn't meaningful until now


[doc] Split Earlgrey spec into Datasheet and Specification

This splits the design specification and datasheet portions into separate files, and adds a link to the datasheet on the documentation landing page here: https://docs.opentitan.org/.
Signed-off-by: Michael Schaffner<EMAIL_ADDRESS>

Added separate sections for the Overview and the Detailed Specification that points to the toplevel spec and dv doc.


issue #25 - create, delete calendar event for conference

Please review the commit.
Thanks,

I was trying hound on this. thats why closed and re opend this PR :)

Can you rebase branch with latest master? We have added hound.yml

@arunagw @raysrashmi
How to remove this violation   trailing Whitespace Violation: Line #179 should have no trailing whitespace ?

Is it because of newline is a whitespace?

xcode -> preferences -> text editing  has two tabs, Editing and Indentation.
I think i might be missing some settings.

@ihemantd Sorry to reply so late. I am using same 7.1.1 xcode version. thats strange you get these errors

@raysrashmi no problem.

@ihemantd Hey, howz it going? Do you need any help on this? Actually we are planning to release a new version soon. so let us know if you need help from us

This PR has become too confusing for me with all the violation/commits/conflicts.
Can I submit fresh PR discarding this one. It Would be easy for me.

@ihemantd Yup totally fine with us. Create new PR


App category changes

Description

Move index pattern from Management/Dashboards management to Library

Issues Resolved

Screenshot

Testing the changes

Check List

[ ] All tests pass

[ ] yarn test:jest
[ ] yarn test:jest_integration
[ ] yarn test:ftr

[ ] New functionality includes testing.
[ ] New functionality has been documented.
[ ] Update CHANGELOG.md
[ ] Commits are signed per the DCO using --signoff

Codecov Report

Merging #187 (35a1129) into workspace-pr-integr (d7d712e) will decrease coverage by 31.63%.
The diff coverage is 5.88%.

@@                   Coverage Diff                    @@
##           workspace-pr-integr     #187       +/-   ##
========================================================
- Coverage                66.49%   34.87%   -31.63%
========================================================
  Files                     3408     1882     -1526
  Lines                    65149    36347    -28802
  Branches                 10431     6512     -3919
========================================================
- Hits                     43323    12676    -30647
- Misses                   19237    22844     +3607
+ Partials                  2589      827     -1762

Flag
Coverage Δ

Linux_1
?

Linux_2
?

Linux_3
?

Linux_4
34.87% <5.88%> (-0.01%)
:arrow_down:

Windows_1
?

Windows_2
?

Windows_3
?

Windows_4
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

...on/index_patterns/index_patterns/index_patterns.ts
1.40% <0.00%> (-54.93%)
:arrow_down:

...terns/index_patterns/redirect_no_index_pattern.tsx
6.66% <0.00%> (ø)

...ugins/data/public/search/errors/painless_error.tsx
0.00% <0.00%> (-50.00%)
:arrow_down:

...lugins/data/server/saved_objects/index_patterns.ts
25.00% <0.00%> (ø)

.../plugins/index_pattern_management/public/plugin.ts
7.14% <0.00%> (-2.86%)
:arrow_down:

...lic/components/getting_started/getting_started.tsx
85.71% <ø> (ø)

...ment_section/objects_table/saved_objects_table.tsx
67.98% <100.00%> (ø)

... and 2330 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


migrate setup and black

migrate setup.py to setup.cfg
migrate to use black as opinionated auto formater
add .git-blame-ignore-revs
fix docs compatibilty problem with Sphinx>=5.0.0
move check_manifest configuration to setup.cfg.
increase minimal python version to 3.7
global: clean test infrastructure

@lnielsen  please check if the DB_VERSIONING=False fix is a good idea


Using app token for test in PR workflow

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#2663  👈
#2660
#2653
#2635
#2632
#2625
#2624
#2623
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatChen and the rest of your teammates on  Graphite

Merge activity

May 26, 1:41 AM EDT: @CatChen started a stack merge that includes this pull request via Graphite.


Add "Work View" Button on Worksite Edit View (Replace Pencil with Briefcase)

Description
On the "Work View" of a case, there is a yellow edit pencil at the top of the page:

However, when you click the edit pencil and enter edit view, there is no way to get back to the Work View:

Tasks
Solution: Add a "Work" Briefcase icon where the pencil icon goes, in the worksite edit view:

in progress have ui button for it, but having issues with states on worksites


MacBook Air M1 Error

Hello!
I'm following the cloning instructions from the README file (I tried the direct Mac release but only shows a blank screen once you hit 'Load Input Display'). When I run the 'yarn install' command I get the following error:
error /Users/jay/Documents/nincid/node_modules/electron: Command failed.
Exit code: 1
Command: node install.js
Arguments:
Directory: /Users/jay/Documents/nincid/node_modules/electron
Output:
HTTPError: Response code 404 (Not Found) for https://github.com/electron/electron/releases/download/v9.4.4/electron-v9.4.4-darwin-arm64.zip
    at EventEmitter.<anonymous> (/Users/jay/Documents/nincid/node_modules/got/source/as-stream.js:35:24)
    at EventEmitter.emit (node:events:527:28)
    at module.exports (/Users/jay/Documents/nincid/node_modules/got/source/get-response.js:22:10)
    at ClientRequest.handleResponse (/Users/jay/Documents/nincid/node_modules/got/source/request-as-event-emitter.js:155:5)
    at Object.onceWrapper (node:events:642:26)
    at ClientRequest.emit (node:events:539:35)
    at ClientRequest.origin.emit (/Users/jay/Documents/nincid/node_modules/@szmarczak/http-timer/source/index.js:37:11)
    at HTTPParser.parserOnIncomingClient [as onIncoming] (node:_http_client:631:27)
    at HTTPParser.parserOnHeadersComplete (node:_http_common:128:17)
    at TLSSocket.socketOnData (node:_http_client:494:22)

Any ideas? 😅
Thank you!

Update:
So I changed the Electron dependency in package.json from 9.4.0 to 11.0.1 and now I can get yarn install and yarn start working.
But there's no options in the Select Port drop down?
In the stand alone version (Mac) there was an option of "tty.usbserial-1130" in the Select Por menu which is my controller, but that doesn't seem to appear in Electron.
Do I need to update anything else?

I've not been able to ever test on a Mac due to access (though there is some basic updating I need to do). If you're doing it from source, maybe try uncommenting this line and see if there are any more details in the console there.

Okee dokee! So I've just done that and this is what the consoles sayings:
Unable to load preload script: /Users/jay/Documents/nincid/main/preload.js
and
Error: The module<EMAIL_ADDRESS>was compiled against a different Node.js version using
NODE_MODULE_VERSION 93. This version of Node.js requires
NODE_MODULE_VERSION 85. Please try re-compiling or re-installing
the module (for instance, using `npm rebuild` or `npm install`).
    at process.func [as dlopen] (electron/js2c/asar_bundle.js:5)
    at Object.Module._extensions..node (internal/modules/cjs/loader.js:1203)
    at Object.func [as .node] (electron/js2c/asar_bundle.js:5)
    at Module.load (internal/modules/cjs/loader.js:992)
    at Module._load (internal/modules/cjs/loader.js:885)
    at Function.f._load (electron/js2c/asar_bundle.js:5)
    at Module.require (internal/modules/cjs/loader.js:1032)
    at require (internal/modules/cjs/helpers.js:72)
    at bindings (/Users/jay/Documents/nincid/node_modules/bindings/bindings.js:112)
    at Object.<anonymous> (/Users/jay/Documents/nincid/node_modules/@serialport/bindings/lib/darwin.js:2)
(anonymous) @ electron/js2c/renderer_init.js:91
/Users/jay/Documents/nincid/node_modules/bindings/bindings.js:121 Uncaught Error: The module<EMAIL_ADDRESS>was compiled against a different Node.js version using
NODE_MODULE_VERSION 93. This version of Node.js requires
NODE_MODULE_VERSION 85. Please try re-compiling or re-installing
the module (for instance, using `npm rebuild` or `npm install`).
    at process.func [as dlopen] (electron/js2c/asar_bundle.js:5)
    at Object.Module._extensions..node (internal/modules/cjs/loader.js:1203)
    at Object.func [as .node] (electron/js2c/asar_bundle.js:5)
    at Module.load (internal/modules/cjs/loader.js:992)
    at Module._load (internal/modules/cjs/loader.js:885)
    at Function.f._load (electron/js2c/asar_bundle.js:5)
    at Module.require (internal/modules/cjs/loader.js:1032)
    at require (internal/modules/cjs/helpers.js:72)
    at bindings (/Users/jay/Documents/nincid/node_modules/bindings/bindings.js:112)
    at Object.<anonymous> (/Users/jay/Documents/nincid/node_modules/@serialport/bindings/lib/darwin.js:2)

Part of the cloning instructions address this:
# If there is an error about bindings and node versions after starting
rm yarn.lock && rm -rf node_modules/serialport node_modules/@serialport
yarn install
./node_modules/.bin/electron-rebuild # For Linux/Mac

Done that, but still no joy in the drop down. Here's the new errors from the apps' console:
electron/js2c/renderer_init.js:91 Error:

<EMAIL_ADDRESS>1): no suitable image found.  Did find:

<EMAIL_ADDRESS>mach-o, but wrong architecture

<EMAIL_ADDRESS>mach-o, but wrong architecture
    at process.func [as dlopen] (electron/js2c/asar_bundle.js:5)
    at Object.Module._extensions..node (internal/modules/cjs/loader.js:1203)
    at Object.func [as .node] (electron/js2c/asar_bundle.js:5)
    at Module.load (internal/modules/cjs/loader.js:992)
    at Module._load (internal/modules/cjs/loader.js:885)
    at Function.f._load (electron/js2c/asar_bundle.js:5)
    at Module.require (internal/modules/cjs/loader.js:1032)
    at require (internal/modules/cjs/helpers.js:72)
    at bindings (/Users/jay/Documents/nincid/node_modules/bindings/bindings.js:112)
    at Object.<anonymous> (/Users/jay/Documents/nincid/node_modules/@serialport/bindings/lib/darwin.js:2)

(anonymous) @ electron/js2c/renderer_init.js:91

/Users/jay/Documents/nincid/node_modules/bindings/bindings.js:121 Uncaught Error<EMAIL_ADDRESS>1): no suitable image found.  Did find:

<EMAIL_ADDRESS>mach-o, but wrong architecture

<EMAIL_ADDRESS>mach-o, but wrong architecture
    at process.func [as dlopen] (electron/js2c/asar_bundle.js:5)
    at Object.Module._extensions..node (internal/modules/cjs/loader.js:1203)
    at Object.func [as .node] (electron/js2c/asar_bundle.js:5)
    at Module.load (internal/modules/cjs/loader.js:992)
    at Module._load (internal/modules/cjs/loader.js:885)
    at Function.f._load (electron/js2c/asar_bundle.js:5)
    at Module.require (internal/modules/cjs/loader.js:1032)
    at require (internal/modules/cjs/helpers.js:72)
    at bindings (/Users/jay/Documents/nincid/node_modules/bindings/bindings.js:112)
    at Object.<anonymous> (/Users/jay/Documents/nincid/node_modules/@serialport/bindings/lib/darwin.js:2)

Here is some errors/warnings from the termianl:
jay@Jays-MacBook-Air nincid % rm yarn.lock && rm -rf node_modules/serialport node_modules/@serialport
jay@Jays-MacBook-Air nincid % yarn install
yarn install v1.22.18
info No lockfile found.
[1/4] 🔍  Resolving packages...
warning electron-builder > dmg-builder ><EMAIL_ADDRESS>Disk image license agreements are deprecated by Apple and will probably be removed in a future macOS release. Discussion at: https://github.com/argv-minus-one/dmg-license/issues/11
warning electron-rebuild > node-gyp ><EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142
warning electron-rebuild > node-gyp > request ><EMAIL_ADDRESS>this library is no longer supported
warning electron-rebuild > node-gyp > request ><EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 🔨  Building fresh packages...
success Saved lockfile.
✨  Done in 8.99s.
jay@Jays-MacBook-Air nincid % ./node_modules/.bin/electron-rebuild
✔ Rebuild Complete
jay@Jays-MacBook-Air nincid % yarn start
yarn run v1.22.18
$ electron .
(node:21809) electron: The default of contextIsolation is deprecated and will be changing from false to true in a future release of Electron.  See https://github.com/electron/electron/issues/23506 for more information


[bug fix] add code files for load_dataset and oracle_collapsed generation

Features

xx
yy

Feature Docs

Influence

Result

Other

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.68%. Comparing base (a712c61) to head (f26a5cd).
Report is 3 commits behind head on swebench_di.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##           swebench_di    #1077   +/-   ##
============================================
  Coverage        81.68%   81.68%
============================================
  Files              246      246
  Lines            13724    13724
============================================
  Hits             11210    11210
  Misses            2514     2514

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lgtm


analogous_to_modules

I'm not waiting for the branch build to finish since the pr build finished.  BTW, you get duplicate builds like this when you push a branch on the main repo and not your fork.

Please resubmit this PR and fix the coverage.  I've reverted it for now with #363

The lines that are not covered would be compiled and run by Myia in the examples, so I think it is probably sufficient to add a # pragma: no cover comment for the corresponding functions.


Add limit feature

With this PR, I am trying to add a limit feature that will trim the rows until a certain limit (if defined, otherwise it will work as usual).
Our use-case is a monorepo, in where many people work, and the table grows quite big.
Added test-case and ran the build action (which introduces changes that I did not make but were previously in the master branch).

Hi @escudero89
Thanks for your contribution! changes are now available in v2.1.0.

Hi @manuelmhtr, I think I introduced a bug though with the feature 😢 . Could it be that the number of totalReviews are being shorten? I don't quite know why by just reading the code. Or is it working correctly?
Also a nice feature would be to not add the table if it finds that the # Pull reviewers stats text is already in the description (because otherwise it keeps replicating the table, e.g. by opening and closing the PR)

Hi @escudero89 that's true. I didn't see the bug either, no problem. Since it only happens when the limit option is enabled it won't happen a lot (for now). I'll fix it as soon as possible.
About the table being replicated, indeed that's the intended behavior. However, there was a bug, when the PR description was empty the table is printed up to 2 times. That was fixed before but as you noticed some changes were not included in the build. It should be fixed in v2.1.0 now.

Hey @escudero89 the bug is fixed now in v2.1.1. Thanks for reporting it!

Gracias Manu :)


Add multi-threaded memcpy to kvikIO

Currently kvikIO is focused on file IO, but sometimes we ingest pageable host buffers that include the full byte range of a binary format like Parquet, or a pageable host buffer that includes text data in CSV/JSON format. In libcudf we ingest this data using a HOST_BUFFER data source and a single threaded pageable HtoD memcpy. Instead, we should use a multithreaded memcpy through small pinned host buffers.
We may add extensions to this feature to cover DtoH transfers as well.
When reading from a pageable host buffer data source on x86-H100, libcudf performs a single-threaded Memcpy HtoD. This pattern brings poor PCIe RX utilization of ~17% and throughput of ~8 GB/s.

After more research, it appears that the best way to improve PCIe utilization on pageable memcpy is likely to be with cudaHostRegister or madvise with MADV_HUGEPAGE (link). I will close this issue for now


Line chart is not rendered properly (dots are off line)

Description
Our line charts got screwed up after upgrade to 3.50.0 from 3.49.2
Steps to Reproduce

create a simple data set and try to render as line chart
you'll see the line is rendered properly, but the dots are far away from the line

Expected Behavior
It should be rendered like

Actual Behavior
It's rendered like

Screenshots

Reproduction Link

no reproduction link provided.


ViewModel lifecycle and @Serializable error

Hello, I have this code:
@Destination @Composable fun CollectionDetailScreen(     navigator: DestinationsNavigator? = null,     collectionDetailViewModel: collectionDetailViewModel = viewModel() )
which is working, everything compile fine.
But I want to make my view model serializable to be able to pass it as a parameter of my navigator.
When I add @Serializable to my view model, I have this error when building the app:
CollectionDetailScreenDestination.kt: (27, 18): Functions which invoke @Composable functions must be marked with the @Composable annotation
I'm not sure it is a bug or me doing something wrong.
Any help? Thanks!
PS: if I removed the = viewModel() and let @Serializable, it works fine but I want to handle lifecycle of my view model by adding = viewModel()

Hi @IssaMansour!
So you want to pass your CollectionDetailViewModel as a navigation argument?! I've never heard of such a crazy idea 😝
I don't know what exactly you want to achieve, but this is not the way. ViewModels are not passed as navigation arguments. You want to pass only data objects which have no logic. Remember that arguments get serialized so the instance you receive on the other end is not the same (even though all fields have the same content).
Think about a small part of the ViewModel which is the actual data you want to send to the other destination and use that as a navigation argument.
Let me know if this helped!

No problem, glad it helped!


mdrun crashes with GPU settings on a machine with GPU

Hello,
I am trying to run MD using the quay.io/biocontainers/biobb_md:3.7.2--pyhdfd78af_0 docker with GPU settings on a machine with 4 GPUS, but it crashes with the following error:
Fatal error:
Cannot run short-ranged nonbonded interactions on a GPU because there is none detected.

I would be grateful for any insight you can provide.
Thank you,
Nazanin

Hi @ndonyapour,
As far as I know: "The Docker engine doesn’t natively support NVIDIA GPUs as it uses specialized hardware that requires the NVIDIA driver to be installed.".  Even thought, there are some methods to allow docker containers access the system's GPUs link here we do not support them.
However, If you want to use the GPUs I recommend installing, the last version of biobb_gromacs (biobb_md is deprecated)  and a GPU enabled GROMACS (gromacs==2022.3=nompi_cuda_ha81c2ac_0) preferably using Anaconda.
Regards,
Pau

Hi @PauAndrio
Thank you for your response. I believe we can run MDs with GPU-enabled docker containers, and here shows an example of running MD on GPUs with containers. I tried nvcr.io/hpc/gromacs:2021 Gromacs container, and it worked on my machine.
Thank you!
Nazanin


always force galaxy to install collections

ansible-galaxy 2.16 will always look in system paths, even if using
ANSIBLE_COLLECTIONS_PATH.  So if you have the ansible package installed,
galaxy will not install the collections used by the role in the .tox path
if the collections are provided by ansible.  Use --force-with-deps if
supported by ansible-galaxy, otherwise, use --force.
Signed-off-by: Rich Megginson<EMAIL_ADDRESS>

@spetrosi not sure if you have run into this, but this is required on fedora 39 with ansible-galaxy 2.16

I didn't bump into this yet, I have ansible-core-2.15 installed. Thanks for the fix


SIMD: Add i64x2.all_true, i64x2.eq, i64x2.ne

See https://github.com/WebAssembly/simd/pull/381, https://github.com/WebAssembly/simd/pull/411, https://github.com/WebAssembly/simd/pull/415. These have been accepted into the spec.
TODO:

[ ] binary encodings for i64x2.eq and i64x2.ne

atm selecting 0xfd c0 for "i64x2.eq" (based on the code in binaryen), and 0xfd c2 for "i64x2.ne"

atm selecting 0xfd c0 for "i64x2.eq" (based on the code in binaryen), and 0xfd c2 for "i64x2.ne"

Should merging hold off though until the upstream opcodes are assigned numbers?

Probably. I think 0xfd c0 will stay, not sure about other one. @lars-t-hansen ?

Should merging hold off though until the upstream opcodes are assigned numbers?

Probably. I think 0xfd c0 will stay, not sure about other one. @lars-t-hansen ?

i64x2.all_true also appears to be a mess: https://github.com/WebAssembly/simd/pull/415#issuecomment-768677362, a consequence of insisting on "logical" blocks of instructions while not setting aside large enough open spaces, combined with a bug in V8 that disallows opcodes > 255.

i64x2.all_true also appears to be a mess: https://github.com/WebAssembly/simd/pull/415#issuecomment-768677362, a consequence of insisting on "logical" blocks of instructions while not setting aside large enough open spaces, combined with a bug in V8 that disallows opcodes > 255.

Well in any case y'all are much more up-to-date on simd than I am anyway, so I'm happy to merge whenever y'all are comfortable about the opcodes.

Well in any case y'all are much more up-to-date on simd than I am anyway, so I'm happy to merge whenever y'all are comfortable about the opcodes.

encoding from https://chromium.googlesource.com/v8/v8.git/+/refs/heads/master/src/wasm/wasm-opcodes.h#350


Rotating a NxN 2D array in 90 degrees anticlockwise.

💥 Proposal
Hi, I want to contribute a code for Rotating an NxN 2D array in 90 degrees anticlockwise direction. I will be using C++.
Have you read the Contributing Guidelines on Pull Requests?
yes.

/assign

Please check my pr @HarshCasper @siddharth25pandey @anushkrishnav I think it's ready to be merged.


Regex is hard constraining projects to iOS 11.3.x and above

Named Capturing Groups that is being used in the following regex is causing Microsites to break on  iOS versions below 11.3.x
https://github.com/KeiserCorp/Keiser.Metrics.SDK/blob/1a1d95aba36e93c08d73fdf46412030f3c9f6ab1/src/lib/time.ts#L1

@Mravuri96, the library is designed for targeting ES2017 and above. Can you confirm this is the only part of the codebase that's preventing supporting back to iOS 11.0?

Not sure that's if this is the only error that's breaking on iOS 10, since that's the first error its getting hung on.


Adjust react template to be initial mockup

Feature Description
Remove unnecessary files and code from the starting react template and update them to become the starting point of Typefaceoff.
Reason for Change
Improve code quality for future maintenance.
Where are the changes needed?
On necessary files within the src folder.
Code Snippets
No response
Anything Else?
No response

Go ahead 👌


Private RSA key leak

Hello there,
I was searching for leaks using scanners and yours popped up..
I can't mention the location of the same.. But there's a key leak which can allow an attacker to get plaintext from a cipher text..
Please consider an alternative way of storing the key
Thanks

The default key is only for local development. We don't treat it secure.

This server designed to work for local development only. For public web server consider to use nginx.

Thanks for clarification.. 🙂


[add]

I separated kuro.py by module.

I already have the QMS module inside qulee.py. Also I have the matplotlib tools in mpls.
We also need to put signal processing tools in a separate module (i.e. smoothing, filtering).
Also functions and classes need to have a docstring.
I will work on this when I have a chance. You can also help.


Stop requests stacking up when responses are slow

When a response takes more than 2 seconds (the polling time), we won't trigger any other requests to the same endpoint. This means we don't end up with lots of pending requests.

Fixes https://github.com/tobytwigger/laravel-job-status/issues/65


[do not merge] - test

DO NOT MERGE

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.8 out of 10 committers have signed the CLA.:white_check_mark: onematchfox:white_check_mark: kayano:white_check_mark: mayocream:white_check_mark: chronolaw:white_check_mark: flrgh:white_check_mark: ADD-SP:white_check_mark: nowNick:white_check_mark: oowl:x: Murillo Paula:x: HansK-pMurillo Paula seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


flaky test: TestForkFinder_FindFork_Permutation

Description

https://github.com/spacemeshos/go-spacemesh/actions/runs/3520291379/jobs/5901072490
not able to reproduce :(
=== FAIL: syncer TestForkFinder_FindFork_Permutation (0.01s)
    find_fork_test.go:146:
        	Error Trace:	/home/runner/work/go-spacemesh/go-spacemesh/syncer/find_fork_test.go:146
        	Error:      	Received unexpected error:
        	            	peer mesh changed mid session
        	Test:       	TestForkFinder_FindFork_Permutation

no longer observed


Can't pip install TorchIntegral after cloning the repository

See screenshot below

You are already in the TorchIntegral folder, so use pip install ./


It's (beyond) time to sunset the *-star protocols 🌅

Long story short for context:

Back in 2016, we created two shortcuts to enable js-ipfs to connect to other Browsers quickly, these were: https://www.npmjs.com/package/libp2p-webrtc-star & https://www.npmjs.com/package/libp2p-websocket-star.
The star in the name comes from the fact that what they were doing was a pure mesh in which everyone listening to on that transport, would dial to everyone else in that transport.
These were created in a time where there was no circuit-relay, delegated routing and dht implementation.
These were never designed to be long term solutions, in fact, they were designed to be quick tools for demos. They have design flaws and worse, they end up re-implementing a lot of what libp2p already does (connection authentication, peer discovery, circuit-relay and rendezvous)

Proposal: Let's sunset the *-star protocols 🌅
To clarify:

A) https://github.com/libp2p/js-libp2p-websocket-star && https://github.com/libp2p/js-libp2p-websocket-stardust are equivalent to listening in a circuit-relay address for dialing, and rendezvous protocol for discovering
B) https://github.com/libp2p/js-libp2p-websocket-star-multi is equivalent to listening in multiple circuit-relay addresses
C) https://github.com/libp2p/js-libp2p-webrtc-star/ is the same as A), but uses that connection to establish a WebRTC connection (SDP exchange)

Direct benefits:

By cutting of the *-star transports, we would be saving the time from reinventing the wheel and also reduce the confusion from the users.
Any IPFS node could then be the rendezvous or the relaying address (meaning that we can use the go-libp2p to handle with even more clients). More

We avoid spending time creating custom instrumentation and use instead the instrumentation that IPFS & libp2p have.
Any security, perf improvement or memory leak fix will be directly on libp2p and/or IPFS rather than external "temporary" code.

People would not have to rely on a centralized of custom built infrastructure, instead, they could use it with any IPFS node.

Candidate Roadmap:

Milestone 1: Sunset any variation of the websocket-star (star, stardust, multi, and so on)

[ ] Verify that https://github.com/libp2p/js-libp2p-rendezvous is complete and well tested
[ ] Remove any trace of *-star transport from js-libp2p (examples, docs)
[ ] Remove any trace of *-star transport from js-ipfs (examples, docs, base config)
[ ] Upgrade PeerPad to use rendezvous & circuit-relay to find other peers (dropping webrtc-star)
[ ] Make it default with js-ipfs

Milestone 2: Sunset webrtc-star (easier, if the above is done first)

[ ] Create webrtc-circuit-relay-exchange (for lack of better name for now) that uses the Circuit Relay to exchange the SDP offer.
[ ] Test it with PeerPad
[ ] Make it default on js-ipfs

I suggest to make this effort implementation independent. That should make it fairly straightforward to adapt libp2p/go-libp2p-webrtc-direct and get webrtc working between the browser and Go clients.
cc libp2p/go-libp2p-webrtc-direct#14

I'm 👍 on this. Maybe I'm missing something but I think there's a piece missing...
Right now, websocket-star is the most reliable way for JS IPFS nodes in the browser to discover and communicate with each other. It kinda works because we don't have the whole of the IPFS network using it, and it cannot be discovered by the rest of the IPFS network (or used since there's no Go impl). This makes it great for demos, development and testing.
In the proposal , we'd be taking this resource away from the community without providing a replacement. Can we setup some circuit relays that JS IPFS nodes can use for demos, development and testing but the rest of the network doesn't discover and use on a day to day basis? I'm not familiar with how you'd go about doing that, it's possible right? I imagine it's something application developers would really need also.

In the proposal , we'd be taking this resource away from the community without providing a replacement.

Not the case, let me clarify. The proposal is to:

Deploy one or more IPFS nodes that are relays specifically for this purpose and not for the entire network (equivalent to the rendezvous/signalling point for any -star transport)
Have js-ipfs nodes by default advertising those relay addresses
Set up a node with the rendezvous protocol on and register every new js-ipfs node in that rendezvous

This is a direct replacement that will be transparent. In fact, users might see things getting faster and more reliable as they will be able to use go-libp2p (more performant) as a circuit relay. This way everything is a libp2p node, no custom pieces that reimpl the same thing.

Milestone 1: Sunset any variation of the websocket-star

https://github.com/libp2p/js-libp2p-rendezvous should be close as the initial spec didn't deviate much but needs to be updated and heavy testing still needs to be done. It doesn't have any federation at this point, but we don't need that to replace the star servers. Federation will need to be added in the future to better support decentralization of the node.
I have been thinking through the flow for doing connection upgrades for WebRTC signaling over the circuit. Part of that potentially uses the DHT (local or delegate) as a means of finding services instead of Rendezvous. This would allow us to spend more of our effort improving that, instead of fragmenting our focus. Here are my notes on how that flow could/would look:
Connection flow

Node 1 discovers Relay r

How does node 1 discovery Relay r?

This could be hard coded as a "Bootstrap" node
A DHT query could be made to find relays, assuming the Relay has registered as a provider of the relay protocol
The relay could use a Rendezvous server to find relays
...?

Node 1 connects to Relay r
Once connected, node 1 adds Relay r as a Priority Peer, so that it can maintain this connection for listening.
Node 1 adds the Relay r, /p2p-circuit relay address to its list of advertised addresses.
Node 1 performs an Identify Push update to all its connected peers to inform them of the address change.
Node 1 advertises its purpose/support/content (such as telling the network it's a Peer Pad node)

How does this advertisement happen?

It could register with a Rendezvous server using the Rendezvous protocol.
It could register as a Peer Pad "provider" via the DHT.
...?

Node 8 joins the network and looks for other Peer Pad nodes.

How does it find them?

The same as process as Node 1 uses to discover Relay r as detailed above

Node 8 discovers Node 1 and its advertised /p2p-circuit address.
Node 8 connects to Relay r, to connect to Node 1
Node 8 and Node 1 are connected via Relay r
Both nodes start a Connection Upgrade (such as WebRTC)

How is this handled?

We need a way to determine available upgrade transports
Once we agree on the transport we need to begin the WebRTC SDP exchange, or another upgrade process for the decided transport

The nodes establish a direct connection to one another over the WebRTC (or other) transport

What happens if this fails? Should the nodes continue to leverage the Relay to exchange data? If so, it may be expensive for the relay node. If not, how can the nodes talk to one another?

If there was a distinction between nodes behaving as only "signaling relays", and nodes behaving as "data exchange relays", nodes could potentially be customized to support high/low connections or high/low bandwidth.

Node 8, as the dialer, requests a disconnect of the relayed connection
Node 1, ACKs the disconnect and disconnects the relayed connection

Node 1 must maintain its direct connection to Relay r, as it is using it as a listen address

Node 1 and 8 are now free to exchange data over their direct connection

@p-shahi with /webrtc and /webrtc-direct, can we close here?

Yes closing this, we're deprecating them here: https://github.com/libp2p/js-libp2p/pull/1488


Disable rendering doc examples for experimental branch

The MANIM_SKIP_EXAMPLES env variable might be a nicer approach than the usual O=-tskip-manim make html for skipping the examples when rendering. We'll see whether this works as intended for this branch.

❤ THANK YOU SO MUCH ❤


Is the cheat sheet updated (2021)?

Hi there, great work! Is the cheat sheet updated or are there commands that have been deprecated/modified/added?

Hi there,
unfortunately this wasn't updated in a while, so depending on the ROS 2 distro you are using you may encounter some differences.
Overall it should still be relevant.
I'll look at updating it whenever possible :+1:


parallelize logic where possible with dask

There are several spots where Pandas DataFrame operations can be parallelized with Dask

Currently working on this


No module named decorator

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az webapp config container show
Errors:
No module named 'decorator'
Traceback (most recent call last):
python3/dist-packages/fabric/connection.py, ln 5, in <module>
    from invoke.vendor.six import StringIO
ModuleNotFoundError: No module named 'invoke.vendor.six'

...

python3/dist-packages/fabric/connection.py, ln 10, in <module>
    from decorator import decorator
ModuleNotFoundError: No module named 'decorator'

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az webapp config container show -i{} {}

Expected Behavior
Environment Summary
Linux-<IP_ADDRESS>-microsoft-standard-WSL2-x86_64-with-glibc2.29
Python 3.8.10
Shell: bash

azure-cli 2.0.81

Extensions:
azure-devops 0.17.0

Additional Context

Was 2.0.81 which came with Ubuntu and which is advised against. After removal and installing the latest version, everything worked like a charm 👍


Improve evaluation of method call

If a java method is called which is overloaded then in certain cases it can happen that more than one compatible is found. Both methods get the same match-value. But actually they are distinguishable.
The example is JAI.create(...)
Called from Python:
JAI.create("filestore", image, 'image.png', 'PNG')
If image is a RenderedImage everything works, but if it is a BufferedImage jpy can't decide which method to call.
This create-method exist in two flavours (actually but only two are of interest).
JAI.create(String, RenderedImage, Object, Object) --> match-value 100, 90,10,10 for BufferedImage
JAI.create(String, Object, Object, Object) --> match-value 100, 90,10,10 for BufferedImage
Here the first method should be used because RenderedImage come first in the hierarchy.
If the image is cast to a RenderedImage first then it works.
RenderedImage = jpy.get_type('java.awt.image.RenderedImage')
rendered_image = jpy.cast(image, RenderedImage)
JAI.create("filestore", rendered_image, 'image.png', 'PNG')

I have this problem a lot when trying to subset products.

@MarkWilliamMatthews could you please provide the code you use to create the subset. The more test cases we have for the issue, the better.


Cannot build code containing debug.SetGCPercent() for Android ARM

What version of Go are you using (go version)?

$ go version
go version go1.17 darwin/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/evan/Library/Caches/go-build"
GOENV="/Users/evan/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/evan/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/evan/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.17"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/evan/dev/esbuild/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/j6/np400cw17sz0n5ljd67byrzw0000gn/T/go-build3774117208=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

I tried to build the following program for Android ARM:
package main

import "runtime/debug"

func main() {
	debug.SetGCPercent(-1)
}

This is a reduced test case from a real program: https://github.com/evanw/esbuild. I am able to cross-compile this program for all platforms except for Android ARM. More context is here: https://github.com/evanw/esbuild/pull/1578.
What did you expect to see?
I expected the build to succeed.
What did you see instead?
The build fails with a cgo-related error. The build also fails if cgo is enabled:
$ GOOS="android" GOARCH="arm" go build main.go
# command-line-arguments
loadinternal: cannot find runtime/cgo
/usr/local/go/pkg/tool/darwin_amd64/link: running clang failed: exit status 1
ld: unknown option: -z
clang: error: linker command failed with exit code 1 (use -v to see invocation)

$ CGO_ENABLED=1 GOOS="android" GOARCH="arm" go build main.go
# runtime/cgo
clang: error: argument unused during compilation: '-marm' [-Werror,-Wunused-command-line-argument]

Building the same program for Android ARM64 works fine:
$ GOOS="android" GOARCH="arm64" go build main.go && file main
main: ELF 64-bit LSB pie executable, ARM aarch64, version 1 (SYSV), dynamically linked, interpreter /system/bin/linker64, Go BuildID=alvXLw57shg5zRLjPYoO/GyVC8TDUJ07MNhoXCsu-/nzi6B7uKoZ53M53L4eR-/0JYttdF-za9eeF0oEvPR, not stripped

To cross compile, you need to set CC to a C cross compiler targeting Android ARM.
Currently we support internal linking for Android ARM64, but not for Android ARM(32). So you'll need a C toolchain to build. Thanks.


Add new version for testing v9

It appears we have a solid test in
"firebaseui": "^0.600.0-rc.0",

I would like to be able to test this version of the UI with React.
https://github.com/firebase/firebaseui-web/issues/837#issuecomment-902565759

Now available in 6.0.0!


Add default type bindings

Changed

Updated container to create type bindings for unbound types.

Codecov Report

Merging #80 (8205e1a) into master (ff65136) will decrease coverage by 0.47%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   95.74%   95.26%   -0.48%
==========================================
  Files          80       71       -9
  Lines        1293     1162     -131
  Branches      141      142       +1
==========================================
- Hits         1238     1107     -131
  Misses         53       53
  Partials        2        2

Flag
Coverage Δ

cuaktask
92.72% <ø> (ø)

iocuak
93.98% <100.00%> (+0.06%)
:arrow_up:

porygon
?

porygon-typeorm
100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...duleTask/utils/convertToContainerModuleMetadata.ts
100.00% <100.00%> (ø)

...kages/iocuak/src/metadata/decorators/injectable.ts
100.00% <100.00%> (ø)

...rc/metadata/utils/domain/getDefaultBindingScope.ts
100.00% <100.00%> (ø)

...src/metadata/utils/domain/lazyGetBindingOrThrow.ts
100.00% <100.00%> (ø)

...uak/src/task/models/cuaktask/CreateInstanceTask.ts
100.00% <100.00%> (ø)

...uak/src/task/modules/DirectTaskDependencyEngine.ts
100.00% <100.00%> (ø)

.../src/crud/modules/domain/DeleteEntityInteractor.ts

...c/crud/modules/iocuak/DomainCrudContainerModule.ts

...rc/crud/modules/domain/ReadManyEntityInteractor.ts

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 445500e...8205e1a. Read the comment docs.


Better access control

Hello everyone,
either I am missing a huge point here or maybe I don't understand how the authentication was intended, but isn't there a way to set authentication credentials when hosting a taskchampion sync server instance?
Currently I'm hosting a instance via a docker container on a server of mine. My clients .taskrc now has the following entries:
sync.server.origin=<redacted>
sync.server.client_id=<redacted>
sync.encryption_secret=<redacted>

I can now sync my stuff with the server. But I can't tell the server to only accept tasks from clients with a specific id. So in theory, as soon as someone knows that a specific URL hosts a taskchampion sync server it can be flooded with spam, that I'm not even able to read because I don't know the encryption key of the attacker.
Do I have to set up an authentication myself?
Thanks in advance!

This functionality is not currently implemented in taskchampion-sync-server. It's needed, though!

I don't have any specific designs in mind for fixing this. This is one of the reasons this is a "reference" implementation.
A short-term fix might be a command-line flag to control whether new client-ids are allowed. Then you could enable that for your first sync, and then disable it thereafter.

I don't have any specific designs in mind for fixing this.

Might I suggest looking at how sync is done with the atuin tool? It's also written in rust and the sync server is little more than an encrypted blob storage tool. To keep blobs separate, a simple user/password auth is needed but that auth only permits access to the blobs, not the content of the blobs.

#61 limits access to a list of client-id in the reference server. I think this is sufficient for one-off services. Those interested in running a more sophisticated service, such as one that provides public sync functionality, will want to build their own, more sophisticated implementation.


Add passHref Prop

This is in response to https://github.com/zeit/next.js/issues/1271 to add in the ability to force passHref when you may have an anchor element below but wrapped as a component or otherwise.

Attempted to add tests except I didn't see any unit tests on Link and only saw integration tests for clicking the about link in the nav. If you could point me in the right direction I'd be happy to add something.

at this point wouldn't it be better to just replicate the href ?

In my case I am doing a Hapi server with slugging. So most of my URLs look like
<Link
                            href={`/courses/course?id=${course.id}&slug=${slugify(title)}&sectionId=${item.meta.id}`}
                            as={`/courses/${course.id}/${slugify(title)}/${item.meta.id}`}>
</Link

Not sure if you looked at #1271 but this could be used with rendering any sort of component that could be just a simple <a> tag as a Component but would only ever get passed the onClick.
I would rather not do this, and would rather be able to pass props to <Link> directly and have them be passed along with the React.cloneElement but apparently there was a decision to not do that.

I honestly am not a fan of this solution but with not being able to style Link, and using Styletron so the <a> is masked as <NavAnchor>. Not sure about easy choices.

Yeah let's think about this one some more.

I'll close this in favor of the Issue


Issue template

Please edit! This is just to get it started...

In particular, I'm not sure of the best way (if there is one way?) to have someone describe their environment.

Output of `pyver python holoviews bokeh matplotlib notebook

ipython datashader pandas xarray conda TODO (pip install pyver`
if you do not already have it) ? or pip freeze or `conda env
export + conda info?` or ?

jupyter-notebook instead if ipython?

I probably meant ipykernel, not ipython (I already listed notebook). I'm not sure if there's one package you can use to get enough info about someone's jupyter system (any ideas, anyone?).
But really that was just a list that came to my fingers as I typed, as a demo of a specific list of packages to ask about. I'm not sure if it's best to ask for the versions of specific packages that matter for holoviews, or just to ask for the whole environment - and I'm not sure of the best way to ask for either of those things!

I think we should aim to keep this template short to encourage contribution. Maybe we can link to a wiki page for suggestions but I would keep the main message focused as possible. The main ones I think of is to 1) suggest gitter for general questions 2) request short reproducible examples for bug reports.

Sure, but asking for a list of at least some versions is crucial for things to be reproducible, and it also helps people realize that they are using old versions, thereby fixing their own problems.

Sure, three things then! I would just avoid front-loading too much text and point to the wiki for details.

Just some thoughts:

I totally agree about keeping it as short as possible, and that the proposal is currently too long. However, I also think that pointing to a wiki is probably pointless (most people will not read it).

Obviously it's up to you how you want to provide support (thanks for providing support!), so if you prefer to interactively interrogate on gitter rather than request that users do certain things before reporting, that's your choice. I personally would be able to answer some questions if only more information were provided up front, but obviously what you prefer is more important as you are the main providers of support! I also think github is a better (more visible, more easily searchable) record.

A short reproducible example is still something you (or other/future viewers of the issue) would have to run, while a screenshot/cast can often save you from that.

... I also think that pointing to a wiki is probably pointless (most people will not read it).

I think that is also true of an overlong template! (most people not reading it)

I think we can shorten it much further:
+  * What went wrong, or what were you unable to do?
 +
 +  * What did you expect or hope to happen?

To me, these questions are so general they don't mean much but maybe that is because I am used to filing issues! Even so, I have rarely encountered an issue where the person hasn't expressed these things.
+  * A screen shot, short screen cast, or sketch.

Helpful, I agree. The next two sections are also helpful but I don't think they need to be sections.
I would be happy with just two paragraphs:

Please consider including a screenshot or short screencast when describing your issue and include any relevant Python tracebacks and/or warnings. If you don't see a clear Python error, please report any warnings/error messages you see in your web browser's developer tools console. [LINK here?]

In order for us to address the issue, we need to be able to reproduce the problem. Ideally, please include a minimal, self-contained example that illustrates the issue you are encountering. Finally, please include the holoviews, matplotlib and/or bokeh version you are using as well as your operating system version and browser.

If the holoviews/bokeh/mpl versions are reported as requested, I'm sure we can address most issues without filling up the issue with  reams of conda env export, conda info and  pip freeze output.

Any chance we can finish this up soon? I agree we should make it shorter, @jlstevens do you want to take this over?

I was wondering if we should ask people only to report bugs against tagged versions, especially now we plan to tag and build a lot more frequently. That said, PRs should only be merged with passing tests so master should be kept in a good state which means we do want bug reports against master that can be at any point in the history.
Anyway template would be a good place to ask for the version and point people to the install instructions so that pip users use pip + git clone and not archive. Note that this would be recommended even if we were using that other versioning approach (that I shall not name!).

Seems like we want bug reports against latest release or against master, to me.  Both those are useful; any other version from the past seems less useful.

Sometimes it is nice to get feedback from users willing to check out a PR though...but that should normally be comments on the PR as opposed to a new issue. So I agree with that...

Going to close, issue templates can now be created via the GitHub UI. @jsignell will likely add the same templates used by bokeh in our triaging session over the next couple of weeks.


CI for MacOS Catalina

As in #2313 and #2691 , we should be testing macOS Catalina (10.15) in CI. Travis doesn't support it as of this writing, but when it does we should turn it on.

This could be done with Github Actions; but on the flipside Github Actions only supports macos-latest -- so, currently, 10.15 -- and nothing else.
But that reflect's Apple's policy of aggressively forcing updates on their users. Maybe it's not unreasonable for us to follow that, and instead of testing 10.12, 10.13, 10.14, *only test 10.15.

But that reflect's Apple's policy of aggressively forcing updates on their users. Maybe it's not unreasonable for us to follow that, and instead of testing 10.12, 10.13, 10.14, *only test 10.15.

Hum... the reality is that many of our users do not follow Apple's policy so i would be inclined to continue testing for "old" releases

@kousu looks like catalina on travis is out: https://docs.travis-ci.com/user/reference/osx/


Feature/lenses

Added tests for lenses.Test rays are launched against lenses. Hit point and angle of incidence are compared to the expected values.
Construction of Biconvex, PlanoConvex and Meniscus lenses changed to avoid unspecified behaviour.
Meniscus lens does not pass the tests yet. Problems are raised by the barrel surface close to the edge of the back surface.
Passing of argumens in test methods might be still changed to allow more versatility.

Thanks for the PR. I'm having a look through and I've noticed a some potential issues relating to numerical accuracy of the ray intersections. I'm going to need to spend a little more time to go through these to properly understand the edge cases. I think I'll merge these into a side branch and make one or two edits before merging into development.


Migrate to AndroidX

itshappening.gif
TODO:

[x] Make sure all deps are latest version
[x] Some manual QA
[x] Make sure tests pass
[x] Figure out what's up with Email Credential

Was there a reason not to upgrade arch components to Androidx?
(Sorry if this is answered somewhere already :) )

@willgurht Nope, we made a mistake. My B for not catching it. See #1681


Add realm-level settings to control inline image/open graph previews

Currently, we have two server-level settings in zproject/settings.py:

INLINE_URL_EMBED_PREVIEW (controls open graph previews).
INLINE_IMAGE_PREVIEW (controls inline image previews).

We'd like to make controlling these available as be realm-level settings, since I suspect some organizations will want these features enabled or disabled for their organization.  The actual flag can be done inside Bugdown without too much trouble -- we already pass in a bunch of realm metadata when constructing the markdown object, so the main work here is actually creating a setting.
We can keep the existing server-level settings (I can imagine some server administrators not wanting these features available on their server at all); if the server-level setting is disabled, we'd just hide the option from realm administrators.
I've tagged this as bite-size because even though it's a moderately sized project, it doesn't require any knowledge not covered in the "new application feature" tutorial and markdown docs on RTD.
(We'll perhaps want to have a user-level setting to control this, but that would be at the display layer, not the markdown layer).

@timabbott i would like to work on issue.


Improve naming of Accept headers setting

In the settings page, Accept headers can be chosen from two dropdown lists.  These are currently labeled "SELECT" and "Graph".  I suggest renaming the former to "ASK / SELECT" and the latter to "CONSTRUCT / DESCRIBE", since these are the SPARQL methods that are supported by the options in the respective lists.

done!


IHaskell isn't respecting "--ghclib" argument

I have a global stack config with a resolver that specifies GHC 7.8.4. However, IHaskell's stack.yaml file causes it to be build with GHC 7.10.2. This means that when I run e.g. ihaskell kernel {connection_file} within the cloned IHaskell project folder, it works. But if I run it outside that folder (for example, the way the kernel.json connection file specifies) then I get an error. I put a bunch of putStrLns in IHaskell and determined that this happens close to the runGHC command in Evaluate.hs.
Run from outside a project, using implicit global config
GOING TO SERVE PROFILE. libdir: "/Users/tomm/.stack/programs/x86_64-osx/ghc-7.10.2/lib/ghc-7.10.2"
Heartbeat port: 56291
Did runGhc with this libdir: "/Users/tomm/.stack/programs/x86_64-osx/ghc-7.10.2/lib/ghc-7.10.2"
Sandbox packages: Nothing
About to getSessionDynFlags
Just did getSessionDynFlags
ihaskell: /Users/tomm/.stack/programs/x86_64-osx/ghc-7.8.4/lib/ghc-7.8.4/package.conf.d/package.cache: GHC.PackageDb.readPackageDb: inappropriate type (not a ghc-pkg db file, wrong file magic number)

For reference, here's how kernel.json is telling IPython to invoke the kernel:
{"display_name":"Haskell","argv":["/Users/tomm/.local/bin/ihaskell","kernel","{connection_file}","--ghclib","/Users/tomm/.stack/programs/x86_64-osx/ghc-7.10.2/lib/ghc-7.10.2"],"language":"haskell"}

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/26410998-ihaskell-isn-t-respecting-ghclib-argument?utm_campaign=plugin&utm_content=tracker%2F332399&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F332399&utm_medium=issues&utm_source=github).

This is on purpose – IHaskell uses whatever config is provided by stack at the current directory it's run in.
That said, it is confusing with the --ghclib argument...
Without doing this, IHaskell would forever be locked to the resolver it uses. If you wanted to use it to help develop another project in another resolver, you would be unable to.
The downside is that if you use it outside the ihaskell directory, you have to install the ihaskell support display libraries in whatever snapshot you're running it in.

Not sure I understand what you mean by "help develop another project in another resolver." The way I see it, the purpose of the installed ihaskell binary is to be used as a kernel by Jupyter console, notebook, etc. So it should work when invoked with a command like ihaskell notebook, no matter what  directory you're in when you type the command. That's what the intent of the --ghclib argument in kernel.json appears to be.
(I don't think this particular problem has anything to do with the support display libraries being installed or not; I'm not even getting to that point because it's trying to use an incompatible GHC package database.)

This is a tricky issue.
For example: I am developing some project A.  So I have a Stack snapshot and stack.yaml in directory A.
I install IHaskell. IHaskell comes with a stack.yaml, so to install it I use a separate Stack snapshot. Now I have two snapshots. If IHaskell is unaware of Stack, it will always use the IHaskell snapshot. There will be no way to use the packages related to A in IHaskell.
What exists right now is an attempt to fix this issue: if IHaskell is run somewhere where there is a stack.yaml, it will use stack to initialize it's environment, as if it is being run with stack exec ihaskell.
We still call runGhc with the libdir specified on the command line.
In your case, it seems like the issue is that there are multiple GHC versions in play. I haven't really encountered this before, which should explain why it failed; it was simply unforeseen.
The issue may actually be the opposite of what you are saying. We do respect the libdir specified on the command line, but this is a problem, because the libdir is GHC 7.10.2 whereas the environment is GHC 7.8. Perhaps if the libdir also specified GHC 7.8 it would work. Can you try that? Switch the libdir flag in kernel.json to specify the GHC 7.8 libdir.
If that indeed fixes things, then we can expand from just querying stack for the environment to also using stack to figure out a proper libdir.

This is now behind the --stack flag. The behaviour described above is no longer the default.


Weird linechart render with VisualMap only in Chrome

Version
5.1.2
Steps to reproduce
This is only occur in Chrome (Version 90.0.4430.93 (Official Build) (64-bit))
Create a line chart with has line color defined in visualMap.
After the xAxis is updated with new value, echarts rerender with weird line (attached image in later comment).
What is expected?
No weird render
What is actually happening?
Chart with linechart is rendered strangely.


Refine buffered output debugging

Shouldn't change much, but a refinement of #1008

use since when fetching late logs to reduce duplicated output (does not eliminate it due to required integer-second rounding of timestamps; requies UTC timestamp parsing not in the Python stdlib. :sigh:)
demote late logs to debug-level, since they may not include any new output at all, and always include redundant output
use capfd to capture output in test_env for easier debugging

@minrk happy to merge if you resolve the merge conflicts

Rebased

@minrk the test failures seem related...


Some Old Luas In 1.1.1 Don't Work

Describe your bug here.
In 1.1.0 Almost all the old luas worked, Something that no longer works in 1.1.1, example: "Chromatic Abberation" or some lua shaders like that, don't work at all. (in 1.1.0 they worked perfectly) And some other luas
Crash Log or logcat logs (if existing)
No response
Are you modding a build from source or with Lua?
Lua
What is your build target?
Android
Did you edit anything in this build? If so, mention or summarize your changes.
No, its normal version of 1.1.1

Try replacing version at option

I already try it, and it's not fixed :[

Oh wait, i reset the Game and it's now fixed, thank you so much

Yes... some work but Others only fill my screen with red messages, in 1.1.0 it reproduced the Sscrips better, example: "Sscript it's a unknown variable" some things like that.

use hscript version,But I seem to have messed up the hscript version

Hi

是的......有些工作，但其他人只用红色消息填充我的屏幕，在 1.1.0 中它更好地再现了 Sscrips，例如：“Sscript 这是一个未知变量”之类的东西。

The code has been returned to v1.1.0

Kk!, thanks you


Use conductor API to bypass p2p syncing of unsafe head

P2P gossip channel has undetermined latency for broadcasting unsafe head to the builders. Conductor API has an admin method to receive unsafe head via http request.

on auth: "jwt auth, from what i recall there is not but should not be hard to add. if you dont want to modify the code there, you can think to wrap/unwrap via a simple reverse proxy. otoh its not hard to had there as well, just add the middleware and protect only that rpc method example. honestly id go with the nginx+sidecar approach."


fix: action permissions and tagging (shas)

Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/main/CONTRIBUTING.md.
[x] I am not the sole author or employee of a company who created either the topic I am modifying/adding or the collection entry I am modifying/adding.

Which change are you proposing?

[ ] Suggesting edits to an existing topic or collection
[ ] Curating a new topic or collection
[x] Something that does not neatly fit into the binary options above

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[ ] Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
[ ] Content (and my changes are in index.md)

This will help with some security notifications on the repo

Curating a new topic or collection

[ ] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[ ] My folder contains a *.png image (if applicable) and index.md
[ ] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Please replace this line with an explanation of why you think this topic or collection should be curated.

Something that does not neatly fit into the binary options above

[x] My suggested edits are not about an existing topic or collection, or at least not a single one

[x] My suggested edits are not about curating a new topic or collection, or at least not a single one

[x] My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

[x] ensure all dependent actions are tagged with SHAs

[x] yaml formatting

[x] update dependenbot config to run daily but group minor/patch updates

[x] add .tool-versions (asdf) to .gitignore

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

@kenyonj pinging you directly on the review due to dependabot config changes.  Want to ensure covering any concerns.


Put prefix to fix timeout issue

I'm looking over the analysis() class and I'm not sure if it's the best way to approach this or not. I still stand by what I said about making a tool to automate these, but maybe cramming all the scripts into one class isn't the best idea. We might also want to leave a bit of freedom with the code, and I think this makes it a little tough.

I thought it over a bit, and I thought we might turn make the scripts more like advanced utilities, that could be run with an automate.py script, which will contain code to run the script over all the subjects and runs. I'll upload an example in a bit.

I agree, there's definitely some issue when travis is running all 16 subjects in a class. I'm going to temporarily remove make_analysis.py for now to let the coverage go back, so that I can commit other changes.


1092: Skip checking properties unnecessary for image upload are set if the provisioner only does the upload image action

Skip checking properties unnecessary for image upload are set if the provisioner only does the upload image action
Use the Action variable as a way to check if uploadimage is being performed
Skip checks for unneeded variables if this is the action set
Set TEST_PROVISION to yes if the action is only uploadimage
Fixes #1092
Signed-off-by: Tia Shah<EMAIL_ADDRESS>

Note - we don't have to put the issue number of the PR comments because its in the commit info already, as the Fixes: #<issue_number> line.

I am unable to merge this as I do not have write access to the repository. Is there someone I can ask to merge / get the access required for this?
Thanks


[[CHORE]] Improve reporting in project test suite

Previously, the project's test suite generated error messages which
included formatting directives related to text rendering. These
directives no longer modify the style of the text rendered to the
terminal; instead, they only introduce additional noise in the failure
reports.

Remove the formatting directives to improve the readability of error
reports
Expand the logic that generates error messages to improve the
readability of the test suite's source code
Suppress test title in cases where it is not specified
Consistently report expected character position

This has bugged me for years. For the longest time, I assumed that the noise in
the test suite's error reports was due to a misconfiguration in my system. I
imagine that contributors either made the same assumption or simply did not
want to dig in to the problem here.
I've previously bisected the project history, and I can't find any point where
the formatting directives produced the intended effect. My best guess is that
the functionality was built around some chance interaction between modules that
overrode built-in functions.
In any event, the noise is very distracting. Here's an example of what test
suite ouput looks like for a failure, prior to applying this patch:
✖ instanceOfLiterals

Assertion Message:
  TestRun: [bold]{undefined}
  [yellow]{Errors defined, but not thrown by JSHINT}
 [bold]{Line 1, Char undefined} A made up error.
  [yellow]{Errors thrown by JSHINT, but not defined in test run}
  [bold]{Line 1, Char 13} Expected an assignment or function call and instead saw an expression.
  [yellow]{Errors with wrong line number}
  [bold]{Line 1} Expected an identifier and instead saw ';'. [red]{not in line(s)} [bold]{2}
  [yellow]{Duplicated errors}
  [bold]{Line 1, Char 14} Missing semicolon.
  [bold]{Line 1, Char 14} Missing semicolon.

And here is the report as generated with this patch applied:
✖ instanceOfLiterals

Assertion Message:
  Errors defined, but not thrown by JSHint:
    {Line 1, Char undefined} A made up error.
  Errors thrown by JSHint, but not defined in test run:
    {Line 1, Char 13} Expected an assignment or function call and instead saw an expression.
  Errors with wrong line number:
    {Line 1, Char 13} Expected an identifier and instead saw ';'. {not in line(s)} {2}
  Duplicated errors:
    {Line 1, Char 14} Missing semicolon.
    {Line 1, Char 14} Missing semicolon.

Coverage remained the same at 97.764% when pulling 4cb4aba93041de46622e51569ff98294d9e2c3ae on jugglinmike:improve-error-reporting into 9fe8c94b37f8e35fac532bba71f4566d26bf210b on jshint:master.

Excellent cleanup—definitely a marked improvement in readability.


Fix hmmrank

PR checklist

[ ] This comment contains a description of changes (with reason).
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] If you've added a new tool - have you followed the pipeline conventions in the contribution docs
[ ] If necessary, also make a PR on the nf-core/metatdenovo branch on the nf-core/test-datasets repository.
[ ] Make sure your code lints (nf-core lint).
[ ] Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
[ ] Usage Documentation in docs/usage.md is updated.
[ ] Output Documentation in docs/output.md is updated.
[ ] CHANGELOG.md is updated.
[ ] README.md is updated (including new tool citations and authors/contributors).

I don't know what went wrong in tests -- missing containers? Merging anyway.


require pycddlib<3.0.0

Pycddlib is getting a big revamp to properly support type hints, and as a result the API is going to change quite a bit. To prevent users installing your package to experience problems, I suggest explicitly specifying pycddlib<3.0.0 in dependencies now, prior to pycddlib getting its new release out of beta, until PWAS has migrated to the new pycddlib API.
More info here: https://pycddlib.readthedocs.io/en/latest/changes.html

Thank you!

Fantastic, thanks so much!


Change Joi.assert() to Joi.validate()

I am implementeng the CLI right now and found some issues due to current behavior of webpack-validator.
Joi.assert() throws errors. As you can see in the screenshot of the readme the callstack gets printed. I think this is bad because as a user I'd think that I hit a bug. Joi.assert stops asserting after the first error, so you never get the real validation result. All remaining values are untested...
Switching to Joi.validate would fix this behavior and would make things ways more easier for the CLI which basically just calls webpack-validator. I have to make weird error catching and reformating the messages...
This would be a breaking change in terms of no more throwing errors.
@jonathanewerner If this change is ok for you I'd make a pull request
EDIT: I would make throwing errors configurable

Mh. I do like that Joi.validate allows customizing via options ({abortEarly: false}). I haven't found a way to get the nice toString output, where it shows you where the error occurs in your supplied object (as can be seen in the screenshot) -- that's the original reason i went for .assert. I have not investigated deeply, though.
I don't think error throwing should be optional for the webpack-validator package, as throwing errors is pretty essential here because else the build would just continue and you might not even notice. (This is especially important in CI contexts, where you don't even look at the console out most of the time.)
For webpack-validator-cli it's a different story as you might use it interactively and will notice the possible error even if no error is thrown. So making it configurable here seems sensible (i think opting out makes more sense though).

I'll make a PR according to your mentions. I think discussing based on code is easier

Btw I think we don't don't need to throw the error for CI. Setting the correct exit code should be enough afaik

As discussed in the PR we will restructure the project so this change is no longer needed.


Missing codemirror.js in lib for version 5.20

Hello,
Thanks for such great product. One thing I notice, in the new codemirror version 5.20.0 there is no codemirror.js in the lib folder any more ?
Would you please take a look?
Thanks

See #4328


ST+DMENU wide character spacing FYI

With new ttf-inconsolata 1:3.000-1, there is problem with wide character spacing.
The same applies to dmenu.
Here is official issue to ttf-inconsolata guys to have in mind:
https://bugs.archlinux.org/task/65932?project=5&string=ttf-inconsolata
Changing from Inconsolata to i.e. "Liberation Mono" solves issue, but it looks badly.

Duplicate of https://github.com/LukeSmithxyz/LARBS/issues/186
This is an upstream issue.


Display deprecation msg for istioctl manifest apply

As per the suggestion from @ostromart in https://github.com/istio/istio.io/pull/7396#pullrequestreview-421110570, Display deprecation msg for istioctl manifest apply.
It needs to be cherry-picked for 1.6.
Related:
https://github.com/istio/istio/pull/22563
https://github.com/istio/istio.io/pull/7336
[X] Installation
[X] User Experience

@shamsher31: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
4230bffe353a25751d3e8fbf72eeb877d69087c5
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio

@shamsher31: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
4230bffe353a25751d3e8fbf72eeb877d69087c5
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

The test failure are not related to this PR.

/retest

Can you modify operator/cmd/mesh/manifest-apply.go to change the short message to something like (apply has graduated. Use 'istioctl install') similar to how the graduated commands appear when you do istioctl experimental?

If that sounds good, definitely I can replace it. So it will look like this
! istioctl manifest apply has graduated. Use istioctl install instead.

Is this looks Ok @esnible ?

Updated, @esnible PTAL.

@shamsher31: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
43354fc669edad09f72ac4143379e67463c021cb
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@shamsher31: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
43354fc669edad09f72ac4143379e67463c021cb
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
50686aac99a42368bc0674b87f697b290d6bc576
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-multicluster-k8s-tests_istio

@howardjohn @esnible Any plan to merge this, if not we can close it ?

@shamsher31: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
64c8e02b57066a38829898e61b4b73bf190bc17c
link
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn PTAL ?

@esnible Not sure if it's still relevant, closing it now.


add support to includePath with nodesass

as discussed in #55

Working on a launch and can't spare energy to test this yet. But I'll test it sometime next week.


Testing

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

4 of 7 (57.14%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.8%) to 94.34%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

subA/py/compute_a.py
1
4
25.0%

Totals

Change from base Build<PHONE_NUMBER>:
-1.8%

Covered Lines:
150

Relevant Lines:
159

💛  - Coveralls


Part - get_price

@SchrodingersGat  get_price currently just returns None when called with a quantity lower than the lowest pricebreak.
2 questions:

intentional?
should the automatic calculation when a part is added warn if there if that results in no price added?

Not "intentional", perhaps it should just return the lowest quantity price break in this situation?

Changing the default behaviour creates a lot of problems, I will not poke this hornets-nest further.

@matmair What kind of problems? Would be nice to have it return the lowest quantity unit price and calculate for the requested quantity.

#1178 was related. I think we should find a solution to this problem

@eeintech stuff broke in a lot of places and I could not find out why everywhere.
I think it makes sense that you can set a minimum order quantity just by starting the price-breaks at the minimum quantity. But correct me if you think otherwise.

In the core functions (purchase-orders, pricing information) it does but I get a wired error when deleting stock - which hinders me from getting rid of stock. Will investigate further and submit my findings.

Weird indeed, I just checked and I don't have this kind of error. Have you tried the same thing with master on your setup?

I have reset the deployment in which I got the error, seems to run fine now.


CronJob conversion error, many pages show nothing

What steps did you take and what happened:

Installed Octant (via Homebrew)
Authenticated to cluster in Google Cloud
Ran octant
Many pages (Workload overview, cron jobs, namespaces, etc) just spin and show nothing. Got errors on console:

2022-08-17T12:43:11.298-0400	ERROR	api/content_manager.go:159	generate content	{"client-id": "xxxx-xxxx-xxxx-xxxx", "err": "generate content: scheme convert: converting (v1.CronJob) to (v1beta1.CronJob): unknown conversion", "content-path": "overview/namespace/default/workloads"}

What did you expect to happen:
Able to see Workload overview, cron jobs, namespaces, etc
Anything else you would like to add:
Environment:

Octant version (use octant version):

$ octant version
Version:  0.25.1
Git commit:  f16cbb951905f1f8549469dfc116ca16cf679d46
Built:  2022-02-24T21:59:56Z

Kubernetes version (use kubectl version):

Client Version: v1.24.2
Kustomize Version: v4.5.4
Server Version: v1.21.12-gke.2200
WARNING: version difference between client (1.24) and server (1.21) exceeds the supported minor version skew of +/-1

OS (macOS 10.15, Windows 10, Ubuntu 19.10 etc): MacOS 12.2, M1 Max

There is PR for this issue pending merge.