LuckPermsBungeeCord v <IP_ADDRESS>

I could not get luckperms to load into bungeecord. BungeeCord would not crash but not configs were created.
Here is the log file. I used an older version and everything seems to be working fine, but I wanted to bring this to you all's attention. I was using the latest version of bungeecord and I also tried waterfall, both provided same outcome.
Logfile: https://hastebin.com/pinevafexi.md

Further information:
LuckPerms would not load correctly on BungeeCord with version 4.2.31 (errors in hastebin link above).
I suggested to try an older version that I know works on BungeeCord (4.2.22) and it seems to work fine. Not sure which version in between that has broken compatibility with Bungee.
tmoflash said they are running the latest version of BungeeCord.

Possibly 4.2.30 that breaks it
https://i.imgur.com/d0sSzQN.png

4.2.30 also broke Sponge. Test your stuff mate :P

Test your stuff mate :P

testing is overrated

Thanks for reporting, should be fixed in the latest release :)


[FEATURE] Add Python 3.13 support

Is your feature request related to a problem? Please describe.

Hello, I'd like to upgrade my app to python 3.13 but I can't due to argilla not supporting 3.13. What's the roadmap and timeline for this ?
Describe the solution you'd like

Argilla supports 3.13
Describe alternatives you've considered

Removing argilla from my app
Additional context

@frascuchon @jfcalvo Do you have any insights about this?

That would be rad !

Hello, the argilla available on pypi still doesn't support 3.13, even though the PR #5652  added the support.
What's the timeline to publish the update package to pypi ?

Hi @Jeerhz. The 3.13 support will be added in the upcoming release (https://github.com/argilla-io/argilla/pull/5706). It will be published during the next days.


404 while trying to download pre-trained models

Getting following output while running the download script for pre-trained models
(pix2pix3d) PS D:\ml\pix2pix3D> bash checkpoints/download_models.sh
checkpoints/download_models.sh: line 1: cd: $'checkpoints\r': No such file or directory
--2023-02-21 14:07:40--  http://cs.cmu.edu/~pix2pix3D/release.tar%0D
Resolving cs.cmu.edu (cs.cmu.edu)... <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>
Connecting to cs.cmu.edu (cs.cmu.edu)|<IP_ADDRESS>|:80... connected.
HTTP request sent, awaiting response... 302 Found
Location: http://www.cs.cmu.edu/~pix2pix3D/release.tar%0d [following]
--2023-02-21 14:07:41--  http://www.cs.cmu.edu/~pix2pix3D/release.tar%0d
Resolving www.cs.cmu.edu (www.cs.cmu.edu)... <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>
Reusing existing connection to cs.cmu.edu:80.
HTTP request sent, awaiting response... 404 Not Found
2023-02-21 14:07:41 ERROR 404: Not Found.

tar: release.tar\r: Cannot open: No such file or directory
tar: Error is not recoverable: exiting now
rm: cannot remove 'release.tar'$'\r': No such file or directory

Hi, this is probably because you're using Windows and PowerShell. You can directly type the cmd in checkpoints/download_models.sh, i.e.,
cd checkpoints
wget http://cs.cmu.edu/~pix2pix3D/release.tar
tar -xvf release.tar


🛠 Tooling: Rename to template-typescript-package

Bug Report Checklist

[X] I have tried restarting my IDE and the issue persists.
[X] I have pulled the latest main branch of the repository.
[X] I have searched for related issues and found none that matched my issue.

Overview
It's a simpler name and the "node" part is irrelevant.
Additional Info
No response

Fixed by 84e297d.

Oh, that's already taken on npm 😢 never mind...

Reverted in 488e0076.


New back to top button optional properties - issue and questions?

Have just committed back to top button optional properties for the Bootstrap template https://github.com/thexerteproject/xerteonlinetoolkits/commit/24c4b33aa32388920351c2c330764ad5fd85bb17 but there's an issue that I can't spot why and also some questions:

Option to hide the back to top button - works fine. Keeping this at LO level for all pages for now.

Option to change to a circle with an up arrow rather than the word Top - works fine. Have kept this quite small so it's unobtrusive - do you think the size is ok?
Do you think the default styling is ok?
Once the issue is resolved (see below) will had some tweaking to some of the themes e.g. the Dark: Black & Grey theme at least.

Have styled the circle by adding a new .top-round class so as not to impact existing projects that have custom styled btn-mini. Can't see any reason this would be a problem and seems better to do it this way. Any reason not to do it this way?

Issue: Have added this in application.js where the default back to top button got added but when the optional property group is added and change to a circle selected and then custom colours chosen for some reason this changes all the buttons except the last one and I can see why. Can anyone spot why and resolve this? @JohnSmith-LT @torinfo @FayCross any ideas?

Hi @ronm123 does that fix it for you?
That section runs every time a section is added so your code was running 15 times in my test (15 sections). That's fine but your selector $(".top-round") was equally running for that section and every one that went before so it was changing 1, then 2, then 3, all the way to end... still not sure why that was an issue though.
I've rewritten to create the button, apply your code only to that one button, then add the button. Not the ideal way to do it - ideally we'd just attach the handlers once, using $(".top-round") after the loop is exited but I can't see the best place to do this off the top of my head. I think that file could do with a bit of restructuring but maybe now isn't the best time too start that...

You could also create two new css rules for the optional colours and then just add or remove the two css classes to show the two states.

@JohnSmith-LT thanks John I can see that at least changes all the buttons now and so works but yes I wasn't sure where to put this and it would probably be better to split it up so that the check whether to hide the button and so not add it, use the default button or change to a circle is where it is now but the style of the circle is moved elsewhere. I just couldn't work out the best place.

Yeah, I had a quick look @ronm123 and couldn't see straight away off the top of my head where best to put it. I'll take another look later if you want and relocate it.

@JohnSmith-LT if any of it needs changing feel free. It obviously needs to run on page load and page change and initially tried where I thought that should be but then it wasn’t picking up the optional properties and probably something I was doing wrong. Also I did think about adding additional classes for the hover colours etc but looked at how we were already dealing with optional hover colour on the nav bar and so followed the same method with jquery .hover etc.

@JohnSmith-LT thanks for your help with this. I've just committed a change https://github.com/thexerteproject/xerteonlinetoolkits/commit/04ef266e999ece8dbfb94cb1d97a9e8c0bcae24f with the description:
improve the efficiency of the optional back to top button code e.g. only check if the button is hidden or set to round in the loadSection function, then apply the additional optional styling at the end of the loadPage function, so after all the sections have been created.
That seems like it's likely to be more efficient to me because the extra styling is then only happening  on page load or on page change but I may be mistaken?

@ronm123 a minor thing but should there be some extra space beneath each section when the back to top button is hidden? The titles end up being closer to the section text above than the section text it's the title for

@FayCross I'm sure both those things can be resolved. Let's discuss at 4pm.
Re the extra space needed if the button is hidden. I didn't actually add anything to hide the button it's just that we wrapped what was already there in a condition that checked for not being hidden and in the original button code there is a  around the button that now doesn't exist if the condition isn't met. Will probably have to look at adding that  back in if the button is hidden.
I wonder about whether the text is needed for screen reader users and in fact the link should be hidden for screen reader users?

@ronm123 I'm closing this as I can't see any outstanding issues in comments above. Please reopen if there's still some outstanding work to do


Comptime Int not getting automatically promoted in function calls

This fails, but it should compile:
fn foo(a: Int) {}

foo(0);

Debris should promote the compile time zero to a runtime integer.

Fixed in 8119d704db737f4a964d41300d161323e4ba108a


Includes apex package from CRAN

This is starting to be used in some popgenInfo vignettes.
Fixes #7.

Passes Docker hub build.


Draft initial copy for home page

Content team to drat initial mock up - due 11 Nov

[ ] Rufaro and Mitch

8 Nov - reach out to Rufaro and Mitch for update


Complex Enums raises TypeError

Initial Checks

[X] I have searched Google & GitHub for similar requests and couldn't find anything
[X] I have read and followed the docs and still think this feature is missing

Description
json schema enum types are json documents - or "Any", this includes array and object types.
short demo of this using jsonschema:
from jsonschema.exceptions import ValidationError
from jsonschema.validators import validate

schema = {
    "type": "array",
    "items": {
        "type": ["object"],
        "properties": {
            "A": {"type": "string"},
            "B": {"type":"integer"}
        },
        "enum": [
            {"A": "test", "B": 5},
            {"A": "test", "B": 4}, ]
    },
    "enum": [
        [{"A": "test", "B": 5}]
    ]
}

validate(instance=[{"A": "test", "B": 5}], schema=schema)

try:
    validate(instance=[{"A": "test", "B": 4}], schema=schema)
except ValidationError:
    pass

Currently it is not possible with pydantic to map complex enums
Example using a simple object:
from typing import Literal
from pydantic import BaseModel

class A(BaseModel):
    b: Literal[{"a":1}]

pydantic_core._pydantic_core.SchemaError: Error building "model" validator:
  SchemaError: Error building "model-fields" validator:
  SchemaError: Field "b":
  SchemaError: Error building "literal" validator:
  TypeError: unhashable type: 'dict'

This could raise something better than TypeError.
Affected Components

[ ] Compatibility between releases
[X] Data validation/parsing
[ ] Data serialization - .model_dump() and .model_dump_json()
[X] JSON Schema
[ ] Dataclasses
[ ] Model Config
[X] Field Types - adding or changing a particular data type
[ ] Function validation decorator
[ ] Generic Models
[ ] Other Model behaviour - model_construct(), pickling, private attributes, ORM mode
[ ] Plugins and integration with other tools - mypy, FastAPI, python-devtools, Hypothesis, VS Code, PyCharm, etc.

Selected Assignee: @Kludex

This could raise something better than TypeError.

What do you expect from that? It's not even a valid Python syntax. 🤔

As I said - just proposing to raise better than TypeError.
I do not expect pydantic to support this … gem.

Given that this isn't even valid python syntax, I'm going to close this as not planned.


[Bug] Fix the sun position calculations

Copy the proposed fix from the original repository:

PR 152: https://github.com/AitorDB/home-assistant-sun-card/pull/152
Author: @avataar - https://github.com/avataar

PR  description:

Fix the sun position calculations:

Use now() as a basis for normalizing all next_xxx values from Home Assistant and locat date/time attributes insteod of UTC (since it should be from the viewpoint of the HA setup)
Use a single source for now() so it's consistent in all the calculations
Also fixed the readTime test as it was sensitive to the time zone of the test environment
This works well for the entire 24h span - I checked by hacking the now value to loop the entire day and "tomorrow" (i.e. simulating today past midnight).

Hey @edwardtfn, we're reviving the project here: https://github.com/rejuvenate/lovelace-sun-card. You're welcome to join. I plan to rework this PR and do some more tests before I resubmit it there.

That's awesome.
I will cancel my PR on HACS then and will work on this repo you are indicating.


MAINT: differential_evolution accepts np.random.Generator

differential_evolution accepts np.random.Generator.

Updated PR to deal with merge conflict.

This should be a fairly straightforward PR to review. Pinging anyone.

Added skipif suggestions. Rebased to fix some merge conflicts

@andyfaff sorry, I should've been more clear here. The pytest at the top of the file aren't importing all of pytest so the testing cannot find the annotations (I think this is why). I ran this PR locally and fails in python runtests.py -v -s optimize as currently written. I made this change to get it to pass:
(scipy-dev) Lucass-MacBook:scipy rlucas$ git add -p .
diff --git a/scipy/optimize/tests/test__basinhopping.py b/scipy/optimize/tests/test__basinhopping.py
index b3b3236a8..6dbb21549 100644
--- a/scipy/optimize/tests/test__basinhopping.py
+++ b/scipy/optimize/tests/test__basinhopping.py
@@ -7,6 +7,7 @@ import copy
 from numpy.testing import assert_almost_equal, assert_equal, assert_
 from pytest import raises as assert_raises
 import numpy as np
+import pytest
 from numpy import cos, sin

 from scipy.optimize import basinhopping, OptimizeResult
Stage this hunk [y,n,q,a,d,e,?]? n

that will give the tests the ability to 'see' the annotations.

All green, nice! Thanks @andyfaff, all my comments are addressed and clarified, marking approved, LGTM.
Hopefully one of the core devs w/commit rights can give another look and a merge.

@andyfaff I noticed np.random.Generator is mentioned in the release notes for scipy.stats, but not for this. Do you think it's worth including?

Done
On Thu, 7 May 2020, 15:28 Matt Haberland<EMAIL_ADDRESS>wrote:

@andyfaff https://github.com/andyfaff I noticed np.random.Generator is
mentioned in the release notes for scipy.stats, but not for this. Do you
think it's worth including?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/scipy/scipy/pull/11397#issuecomment-625037031, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFLTVVIKPBJKTWOPRLR6HTRQJBHZANCNFSM4KJQKMBQ
.


fix of issue #10

prevents UnicodeEncodeError when a json-key contains non-ascii characters

Hey @hugojanruiter,
Thanks for the patch! It would be great if you could provide the input and its output for the fix you mentioned.

Hi @softvar,
Code and input:
# -*- coding: utf-8 -*-
from json2html import *

foo = {'àbc': 'test'}

print(json2html.convert(json=foo))

Output without the patch:
Traceback (most recent call last):
  File "test.py", line 6, in <module>
    json2html.convert(json=foo)
  File "/Users/hugojanruiter/Sites/jsontest/venv/lib/python2.7/site-packages/json2html/jsonconv.py", line 52, in convert
    return self.iterJson(ordered_json)
  File "/Users/hugojanruiter/Sites/jsontest/venv/lib/python2.7/site-packages/json2html/jsonconv.py", line 121, in iterJson
    convertedOutput = convertedOutput + ''+ str(k) +'	'
UnicodeEncodeError: 'ascii' codec can't encode character u'\xe0' in position 0: ordinal not in range(128)

Output with the patch:

àbc	test

Thanks @hugojanruiter
I'll try to run the code once, kinda busy. Will review/merge it ASAP for sure.

Ok, perfect. Hope you will find some time soon.

Thanks @hugojanruiter


introduce pkg/fieldpath for processing field paths

In attempting to implement the nested field path support for different
source and target field Go types, I realized I needed a support package
that made working with field paths easier, including taking a field path
and finding a ShapeRef within an Output shape that matched the field
path.
This patch introduces a new pkg/fieldpath package with a simple Path
struct containing a variety of utility methods, as shown in this example
Go code snippet:
import (
        "fmt"

	awssdkmodel "github.com/aws/aws-sdk-go/private/model/api"
        "github.com/aws-controllers-k8s/code-generator/pkg/fieldpath"
        "github.com/aws-controllers-k8s/code-generator/pkg/sdk"
)

...

p := fieldpath.FromString("Crawler.Schedule.ScheduleExpression")

// Will print "true"
fmt.Println(p.Contains("Crawler.Schedule"))

// Will print "false"
fmt.Println(p.Contains("crawler.Schedule"))

// Will print "true"
fmt.Println(p.ContainsFold("crawler.Schedule"))

// Will print "ScheduleExpression"
fmt.Println(p.Back())

// Will print "Crawler"
fmt.Println(p.Front())

// Find the shape within the GetCrawlerResponse shape that contains the
// field referred to by the path...
helper := sdk.NewHelper("/path/to/apis", genCfg)
api := helper.API("glue")
crawlerOutputShape := api.Shapes["GetCrawlerResponse"]

schedExpressionShape := p.ShapeRef(crawlerOutputShape)
// Will print "ScheduleExpression"
fmt.Println(schedExpressionShape.ShapeName)

Note that we support list and map type field paths using a single-dot
notation since we are only looking at field types and not values
within the list or map.
Signed-off-by: Jay Pipes<EMAIL_ADDRESS>Related: aws-controllers-k8s/community#1078
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.

Hey @jaypipes ! FYI, we have been using the fieldpath package that can work with arbitrary JSONs from crossplane-runtime for a long while now whenever we need this functionality. It has support for indexed accesses as well, like Object.AField[0].AnotherField. It could be helpful here 🙂

Hey @jaypipes ! FYI, we have been using the fieldpath package that can work with arbitrary JSONs from crossplane-runtime for a long while now whenever we need this functionality. It has support for indexed accesses as well, like Object.AField[0].AnotherField. It could be helpful here slightly_smiling_face

Hi @muvaf! Yes, I actually looked at CP's fieldpath package as well as k8s.io/structured-merge-diff/fieldpath package for inspiration here! :)
I ended up going this route for the field definition paths. In the code generator, we don't need to refer to the values that exist in the fields. Rather, we just need to refer to the field definitions. I may very well use the CP fieldpath package for referencing those field's values from within ACK's runtime repo (which has a pkg/compare/path.go file that could likely be replaced with CP's fieldpath package.

/test ecr-controller-test

@jaypipes ecr-controller tests might be failing in the upcoming hours, @vijtrip2 and I are trying to fix an issue with release/soak tests for ecr-controller. Sorry for the inconvenience

/retest

/lgtm


Global Role Edit

Hello, I have a question.
I really need to add some custom global role into the rancher.
This can be empty without any privileges. I need that to indicate that something can be done. But I don't wanna use existing roles because every role is giving some privileges and I don't want to grant them to this particular "special" user.
Any ideas?

See https://github.com/rancher/rancher/issues/16216#issuecomment-434140610


Calendar on window focus

Hi, I'm getting a strange behavior when using the calendar:
When selecting or opening the calendar input, it shows the calendar, if closed and if I minimize the window or change tabs and open the tab again (without having to click again) the calendar appears.
http://d.pr/v/qdBY
This also happens on the demo site:
http://materializecss.com/forms.html
Any ideas on how to fix this?

This is caused by the focus which opens the picker.
Search through closed issues: https://github.com/Dogfalo/materialize/issues?q=is%3Aissue+picker+tab+is%3Aclosed


Colab Notebook ignores ITERATIONS form input by default

from tqdm import trange
from IPython.display import Image, display

from deep_daze import Imagine

TEXT = 'an apple next to a fireplace' #@param {type:"string"}
NUM_LAYERS = 32 #@param {type:"number"}
SAVE_EVERY =  20#@param {type:"number"}
IMAGE_WIDTH = 512 #@param {type:"number"}
SAVE_PROGRESS = False #@param {type:"boolean"}
LEARNING_RATE = 1e-5 #@param {type:"number"}
ITERATIONS = 1050 #@param {type:"number"}

model = Imagine(
    text = TEXT,
    num_layers = NUM_LAYERS,
    save_every = SAVE_EVERY,
    image_width = IMAGE_WIDTH,
    lr = LEARNING_RATE,
    iterations = ITERATIONS,
    save_progress = SAVE_PROGRESS
)

for epoch in trange(20, desc = 'epochs'):
    for i in trange(1000, desc = 'iteration'): # Should respect `ITERATIONS` here instead of 1000
        model.train_step(epoch, i)

should be
for epoch in trange(20, desc = 'epochs'):
    for i in trange(ITERATIONS, desc = 'iteration'):

oops, fixed!

oops, fixed!


After scale , position is wrong.

Hello!
my page after a zoom, drag the slider position is wrong.What way can solve this problem。
Scaling method:
this.$refs.contentPage.style.transform =
"scale(" + this.scale.x + "," + this.scale.y + ")";
this.$refs.contentPage.style.transformOrigin = "0 0";

The exceptions is stated in the documentation.
Add this.$nextTick(() => this.$refs.slider.refresh()) after scale

Hi, I have the same problem.
I'm using css3 scale transform to scale a div that contains the slider, and the slider's position is wrong.
What way can I solve this problem.

The exceptions is stated in the documentation.
Add this.$nextTick(() => this.$refs.slider.refresh()) after scale

Hi, I have the same problem.
I'm using css3 scale transform to scale a div that contains the slider, the slider's position is wrong.
What way can I solve this problem.

@a22773889g
Updated v3.2.10 to add zoom parameter to support zoomed scenes. For more details, see the documentation.
https://nightcatsama.github.io/vue-slider-component/#/api/props?hash=zoom

@NightCatSama Thanks for your help. You saved my life.

appreciate your effort, this issue cause really big issue to our business. after updated, problem solved smoothly. I'm grateful for your kind assistance.


Add swati9450's file

I have: created a branch, created a file and made a commit, and opened a pull request

Done


updating readmes and makefiles for model_servers

/cc @sallyom
/cc @cooktheryan
/cc @MichaelClifford
These changes have been tested on Darwin

I noticed the code-generation llm was running extreemly slow, it took me about 5 minutes to get a response on  getting a python script with the openshift-client module to get all configmaps in ns test running on 128 gigs of RAM. I would consider that unsuable for your average person.

@Gregory-Pereira This needs a rebase.

Needs a rebase.

I think tackling everything at once is not efficient. I will break this into 1 pr per componnt

Didnt get to splitting this today, still have been slammed with productization work. I still plan to seperate these changes per component.

LGTM

@MichaelClifford Yes, Ive just been held up by productization work. Happy to close this and il get to it whenever i can


RunIde command fix

Corrected the command to launch Idea in development mode as it caused a huge misunderstanding due to different command naming similarities

Closed, will make a PR on neueda master directly


Bugfix: shape error in DiffractionPattern for RSM

nomad.datamodel.results.DiffractionPattern.intensity quantity requires the shape to be ['*']. On the other hand, nomad-measurement.xrd.XRDResultRSM.intensity has the shape ['*','*'].
When adding the diffraction pattern in the structural properties, we populate the prior one with the latter one. This generates an error on the latest nomad dev because of the stricter shape checks.
Fix this by:

[x] If the intensity is 2D, only use its first row to populate the diffraction pattern class

@hampusnasstrom One of the Pytests puts an assert on populated parsed_archive.results.properties.structural.diffraction_pattern.
If we skip populating this for RSM, the test fails.
Another quick fix could be:

populating the DiffractionPattern, but only with the first row of the RSM results (similar to what we had before we implemented RSM).

Hrmm, I see. Couldn't we just add the same shape check in the test? Not sure just the first row makes any sense.

@hampusnasstrom Let's do that. Making these changes.


Integration tests use hardcoded URIs

Hardcoded URIs should be replaced with GET calls to fetch existing resources by name. Otherwise nobody but the person who created the test can run the integration tests (or someone on the same OV instance)
Problem Files:

[x] enclosure/create_spec.rb
[ ] logical_interconnect_qos.json
[ ] storage_pool.json
[ ] volume_template.json
[ ] Others?

This SDK has limited support and will not be actively developed for the foreseeable future.


Fix outdated links in Formatter

Q
A

Is bugfix?
❌

New feature?
❌

Breaks BC?
❌

Fixed issues

👍🏻


reformatting of the whole library

The creation of the branch develop

Actually miss understood git instruction, this pull request as been reverted.....


Fix eager includes of skip navigations

Same as #90 but for skip navigations (turns out GetNavigations() does not return them).

Thanks!


[Coverage] integration coverage fix

Adds coverage package list to account integration coverage

Codecov Report

Merging #187 (5f81746) into master (0e419c0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #187   +/-   ##
=======================================
  Coverage   27.93%   27.93%
=======================================
  Files          92       92
  Lines        3863     3863
=======================================
  Hits         1079     1079
  Misses       2698     2698
  Partials       86       86

Flag
Coverage Δ

integration
?

unittests
27.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e419c0...5f81746. Read the comment docs.


fix(cloudmon):add cloudpods metric GetDelayDuration

What this PR does / why we need it:
add cloudpods metric GetDelayDuration
Does this PR need to be backport to the previous release branch?:
<!--
If no, just write "NONE".

If don't know, write "UNKNOWN", and let the reviewer decide.

If yes, write the release branches name in the below format and submit the related cherry-pick PR:
- release/3.9

/cc @ioito

/lgtm


Fix requirement to use MAX_INT message ID to "Get latest N messages"

One the ugliest warts in the Zulip API right now is that fetching the last N messages requires passing a super large integer as the anchor.  @arpith suggested the reasonable solution of making anchor optional, and if it is not specified, having get_old_messages_backend just do this for you.  It'd certainly be a lot cleaner API.
@showell do you see any problems with making that API change?  We already effectively support not passing anchor in the event that the user passed the use_first_unread option (in that we ignore the anchor value passed in in that case).
A few notes on executing this:

We'd want a check that num_after must not be set to a nonzero value in that case
We should write fairly careful tests for the relevant validation code in test_narrow (there are already a few similar ones related to user_first_unread).

This seems like a good idea to me.

I would also suggest that num_after just be ignored in this case (when an anchor is not specified) without throwing an error.
This would simplify the API from a user's perspective.

On 23-Sep-2016, at 7:31 PM, showell<EMAIL_ADDRESS>wrote:
This seems like a good idea to me.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Yep, that sounds good.

We recently fixed this with the new anchor="latest" option scheduled for Zulip 2.2.


x/pkgsite:cannot request documentation

What is the URL of the page with the issue?
https://pkg.go.dev/github.com/and3rson/telemux
What is your user agent?
User-Agent | Mozilla/5.0 (X11; Linux x86_64; rv:89.0) Gecko/20100101 Firefox/89.0
Screenshot
Just a message saying:
"github.com/and3rson/telemux" could not be found.

What did you do?
Tried to browse documentation for my project.
What did you expect to see?
Documentation for my project.
I can still download it via<EMAIL_ADDRESS>I can also fetch<EMAIL_ADDRESS>and<EMAIL_ADDRESS>My repo has go.mod, go.sum, LICENSE, README and docstrings.
Also, my package doesn't seem to be present here - https://index.golang.org/index - is it OK?
What did you see instead?
Error message (see screenshot).

Fixed.


Warning in .Net 6/7

This is very practical, can it enhance compatibility?

I just ran AesEncryption.cs in .Net6, without any compiler warnings. Could you give me more details? Also, I'm not sure what you mean by "enhance compatibility", please clarify that

Warning	SYSLIB0022	'RijndaelManaged' is obsolete: 'The Rijndael and RijndaelManaged types are obsolete. Use Aes instead


Exclude transit gateway resources from nuking job

There appears to be a bug in the implementation of the transit gateway nuking job that causes our account nuking CI job to fail. See this failing build for example.
Note that it does not appear to be IAM permission related, as the transit gateway related IAM permissions are all nested under ec2, which our CI user has full access to.
This PR disables nuking those resources until we can find a resolution.

Thanks for review! Going to merge this in so we can get nuking going again.

Looks like it has to do with the availability of the service within the region:
$ aws --region us-west-2 ec2 describe-transit-gateway-vpc-attachments
{
    "TransitGatewayVpcAttachments": []
}
$ aws --region ap-northeast-3 ec2 describe-transit-gateway-vpc-attachments

An error occurred (InvalidAction) when calling the DescribeTransitGatewayVpcAttachments operation: The action DescribeTransitGatewayVpcAttachments is not valid for this web service.


[FancyZones] Place log files in subfolders with the version number

Create a subfolder with the version number for logs instead of writing directly to PowerToys\FancyZones\FancyZonesLogs.

This is a subtask of https://github.com/microsoft/PowerToys/issues/804


TypeError: Cannot read properties of undefined (reading 'value')

I started the project, added the currency MXN, applied that in the region settings, then I went to create a new product, and clicked the "add price" button:
addPrice C:/dev/medusa-admin/src/domain/products/new/index.js:243
240 | {
241 |   edit: true,
242 |   region: "",
243 |   currency_code: currencyOptions[0].value.toLowerCase(),
244 |   amount: "",
245 |   sale_amount: "",
246 | },
handleClick C:/dev/medusa-admin/src/components/button/index.js:18
15 | }) => {
16 |   const handleClick = e => {
17 |     if (!loading && onClick) {
18 |       onClick(e)
19 |     }
20 |   }

This is fixed in the new admin site.


chore: add an example showcasing OT vs different OTel setups

Todo

[x] Add README

Description
This adds an example instrumenting a toy express app and sending traces to Splunk APM without a collector in the middle.

APMI-1923

Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

[x] Tested manually
[ ] Added automated tests

Checklist:

[ ] Changelogs have been updated
[ ] Unit tests have been added/updated
[ ] Documentation has been updated

Codecov Report

Merging #212 (713d5cd) into main (40d2874) will decrease coverage by 18.45%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             main     #212       +/-   ##
===========================================
- Coverage   84.51%   66.05%   -18.46%
===========================================
  Files          14       19        +5
  Lines         297      380       +83
  Branches       69       80       +11
===========================================
  Hits          251      251
- Misses         46      129       +83

Impacted Files
Coverage Δ

examples/collectorless/client.js
0.00% <0.00%> (ø)

examples/collectorless/server.js
0.00% <0.00%> (ø)

examples/collectorless/tracer.js
0.00% <0.00%> (ø)

examples/collectorless/tracer.opentracing.js
0.00% <0.00%> (ø)

examples/collectorless/utils.js
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40d2874...713d5cd. Read the comment docs.

@theletterf, I just jotted down everything that the readme should, in my opinion, minimally include. I'm open to restructuring it or any other kind of feedback you might have.

@Rauno56 So I'm wondering if we shouldn't have separate directories side-by-side for OpenTelemetry vs. OpenTracing. As a newcomer, would I be able to quickly understand which line of code belongs to which system?

@Rauno56 So I'm wondering if we shouldn't have separate directories side-by-side for OpenTelemetry vs. OpenTracing. As a newcomer, would I be able to quickly understand which line of code belongs to which system?

Not sure what would we gain by separating them if they are actually exactly the same - only thing changes is the file we require before running our app.
I think is beneficial to see that in fact, the two solutions are effectively enabled the same way to be convincing in encouraging people to migrate.

it would be a burden to keep them in sync.


dist/html2canvas.min.js says it is still version beta-3, not 4... has it been updated?

/*
html2canvas 0.5.0-beta3 http://html2canvas.hertzen.com
Copyright (c) 2016 Niklas von Hertzen
Released under  License
*/
is the header on the current minified dist file. Is it wrong, or has it not been updated?
Same for the non minified file...

The file is correct, header is wrong

thanks! figured, since it said updated 5 days ago, wanted to be sure though.


Could you explain more details about how to run make_lmdb.sh?

I tried to edit the make_lmdb.sh file as following:
../../build/tools/convert_driving_data /media/aquarius/Backup/VPGNet/caltech-lanes-dataset/cordova1/ /media/aquarius/Backup/VPGNet/caltech-lanes-dataset/cordova1/list.txt LMDB_train
../../build/tools/compute_driving_mean LMDB_train ./driving_mean_train.binaryproto lmd
../../build/tools/convert_driving_data /media/aquarius/Backup/VPGNet/caltech-lanes-dataset/cordova2/ /media/aquarius/Backup/VPGNet/caltech-lanes-dataset/cordova2/list.txt LMDB_test
but it seem doesn't work.
Here is my output:
./make_lmdb.sh
E1227 16:49:05.001368  4610 convert_driving_data.cpp:73] argv[1]: /media/aquarius/Backup/VPGNet/caltech-lanes-dataset/cordova1/
E1227 16:49:05.001581  4610 convert_driving_data.cpp:74] argv[2]: /media/aquarius/Backup/VPGNet/caltech-lanes-dataset/cordova1/list.txt
E1227 16:49:05.264470  4610 convert_driving_data.cpp:145] Total to be processed: 0.

Could you explain to me more details about this process? I am a newbie in caffe so it took me more than 3 days to fix this and nothing happened.
Thank you in advance.

The backend is lmdb ,the 'b' is absent .
./../build/tools/compute_driving_mean LMDB_train ./driving_mean_train.binaryproto lmd

@daixiaogang Thank you for pointing out that mistake, but my problem happens before that line of code so I still get stuck at this step.

the following is my code:
../../build/tools/convert_driving_data /home/swjtu/daixiaogang/VPGNet/caltech-lanes-dataset train_list.txt LMDB_train
../../build/tools/compute_driving_mean LMDB_train ./driving_mean_train.binaryproto lmdb
../../build/tools/convert_driving_data /home/swjtu/daixiaogang/VPGNet/caltech-lanes-dataset test_list.txt LMDB_test
train_list.txt and test_list.txt are in the same folder with make_lmdb.sh the img root=arg[1]+line[i].first where the line is in the *.txt file.Maybe  the '/' is the reason ,because the line in the *.txt like:
/cordova1/f00000.png  111  41 297 48 304 1  49 289 56 296 1  49 297 56 304 1  57 289 64 296 1  65 281 72 288 1  65 289 72 296 1

@daixiaogang  now i see the problem. The list file which I downloaded from the Caltech dataset is not the same as your file. Mine is: "cordova1/f00000.png", and there is no location points. Could you give me your list file to test it? Thank you for helping me a lot

@aquariusnk ，how should I give this file to you ？

@daixiaogang Sorry that I forget to give you my email. Could you send your file to this address<EMAIL_ADDRESS>

@aquariusnk ,check your email.

@daixiaogang May I have a issue? the network's output of Multi-label task is 60x80x64, what does the "64"mean? the number of different types? but, in the paper it is 17, and this make me confused.
Hope for your reply!

@daixiaogang thank you so much!!! Your files have solved my problem perfectly!

@ln-scau The number of channel 64 for the multi-label task includes auxiliary classes. Basically, you can set it as the number of your target classes such as 17.

@daixiaogang @aquariusnk Hello, I also meet the same problem of make_lmdb.sh.
And my email is<EMAIL_ADDRESS>

@chengm15 ,you shuould delete the LMDB_train and LMDB_test dir before you run this bash.

@daixiaogang Thanks for response!
I have delete LMDB_train and LMDB_test. Right Now, the code is the following:
../../build/tools/convert_driving_data /home/chengming/chengming/VPGNet/caltech-lanes-dataset cordova1.txt
../../build/tools/compute_driving_mean ./driving_mean_train.binaryproto lmdb
../../build/tools/convert_driving_data /home/chengming/chengming/VPGNet/caltech-lanes-dataset cordova2.txt
However, it still have the problem below.
**convert_driving_data: Convert a set of images to the leveldb/lmdb
format used as input for Caffe.
Usage:
convert_driving_data [FLAGS] ROOTFOLDER/ LISTFILE DB_NAME
No modules matched: use -help
F1229 14:04:38.750690 36167 compute_driving_mean.cpp:58] Check failed: mdb_env_open(mdb_env, argv[1], 0x20000, 0664) == 0 (2 vs. 0) mdb_env_open failed
*** Check failure stack trace: ***
@     0x7fd1af4c2daa  (unknown)
@     0x7fd1af4c2ce4  (unknown)
@     0x7fd1af4c26e6  (unknown)
@     0x7fd1af4c5687  (unknown)
@           0x402816  main
@     0x7fd1ae47ff45  (unknown)
@           0x402e16  (unknown)
@              (nil)  (unknown)
./make_lmdb.sh: line 22: 36167 Aborted                 (core dumped) ../../build/tools/compute_driving_mean ./driving_mean_train.binaryproto lmdb
convert_driving_data: Convert a set of images to the leveldb/lmdb
format used as input for Caffe.
Usage:
convert_driving_data [FLAGS] ROOTFOLDER/ LISTFILE DB_NAME
No modules matched: use -help**

@chengm15 ， you should read the error message when you meet it . There should exsit blankspace between each parameter.Just like:
../../build/tools/convert_driving_data  /home/chengming/chengming/VPGNet/caltech-lanes-dataset cordova1.txt

@SeokjuLee Thanks very much, your work is awesome!. As you said, can i set  the number of channel 64 to 3? Because in the caltech lanes dataset, the list files generated by 'caltech-lanes-dataset/vpg_annot_v1.m
has only 3 types.

@ln-scau Yes of course, but make sure the total number of classes is 3+1, which includes the background type.

@daixiaogang Thank you very much! I have solved this problem and the problem is that I need to write down the absolute dir of LMDB_train

@SeokjuLee If i set the number of classes is 4，should i change the output of Conv7 in Multi-label task from 15x20x1024 to 15x20x64? Or just to change the tiling layer's param form tile_dim: 4  to tile_dim: 16 ?

@ln-scau Yes good point. you need to tune the depth of the branched Conv layer (the last one, maybe 8th?) when you change the number of types. However the tiling parameter is dependent on the output spatial size (width & height), so you don't need to change it.

@daixiaogang meet the same issue  too. could you please send me another copy of train_list.txt and test_list.txt? my email is<EMAIL_ADDRESS>Thanks a lot!

@chenyiman see and run vpg_annot_v1.m, then you'll get ***.list as required.

@chengm15 I try your code like this:
../../build/tools/convert_driving_data /home/VPGNet-master/caltech-lanes-dataset /home/VPGNet-master/caltech-lanes-dataset/cordova1.txt LMDB_train
../../build/tools/compute_driving_mean LMDB_train ./driving_mean_train.binaryproto lmdb
../../build/tools/convert_driving_data /home/VPGNet-master/caltech-lanes-dataset /home/VPGNet-master/caltech-lanes-dataset/cordova2.txt LMDB_test
my cordova1.txt like this:
/cordova1/f00134.png  43  153 361 160 368 3  161 353 168 360 3  161 361 168 368 3  169 345 176 352 3  169 353 176 360 3  177 329 184 336 3  177 337 184 344 3  177 345 184 352 3  185 321 192 328 3  185 329 192 336 3  185 337 192 344 3  193 313 200 320 3  193 321 200 328 3  193 329 200 336 3  201 305 208 312 3  201 313 208 320 3  201 321 208 328 3  209 297 216 304 3  209 305 216 312 3  217 297 224 304 3  409 297 416 304 2  409 305 416 312 2  417 305 424 312 2  417 313 424 320 2  417 321 424 328 2  425 313 432 320 2  425 321 432 328 2  425 329 432 336 2  433 329 440 336 2  433 337 440 344 2  433 345 440 352 2  441 337 448 344 2  441 345 448 352 2  441 353 448 360 2  449 353 456 360 2  449 361 456 368 2  457 361 464 368 2  457 369 464 376 2  457 377 464 384 2  465 369 472 376 2  465 377 472 384 2  465 385 472 392 2  473 385 480 392 2
/cordova1/f00135.png  0
/cordova1/f00136.png  0
/cordova1/f00137.png  0
/cordova1/f00138.png  0
/cordova1/f00139.png  0
/cordova1/f00140.png  38  177 233 184 240 2  185 233 192 240 2  193 225 200 232 2  193 233 200 240 2  201 225 208 232 2  209 217 216 224 2  209 225 216 232 2  217 217 224 224 2  225 217 232 224 2  233 209 240 216 2  233 217 240 224 2  241 209 248 216 2  249 209 256 216 2  257 201 264 208 2  257 209 264 216 2  265 201 272 208 2  265 249 272 256 3
but there almost the same wrong output: Check failed: Check failed: mdb_cursor_get(mdb_cursor, &mdb_key, &mdb_value, MDB_FIRST) == 0 (-30798 vs. 0)
I am new,I don't know how to solve,problem,

@fanqi1996 , maybe you need to specify the absolute path of LMDB_train and LMDB_test.

Just like the following:
`../../build/tools/convert_driving_data /home/cardwing/Downloads/VPGNet-master/caltech-lanes-dataset /home/cardwing/Downloads/VPGNet-master/caltech-lanes-dataset/cordova1.txt /home/cardwing/Downloads/VPGNet-master/caffe/models/vpgnet-novp/LMDB_train
../../build/tools/compute_driving_mean /home/cardwing/Downloads/VPGNet-master/caffe/models/vpgnet-novp/LMDB_train ./driving_mean_train.binaryproto lmdb
../../build/tools/convert_driving_data /home/cardwing/Downloads/VPGNet-master/caltech-lanes-dataset /home/cardwing/Downloads/VPGNet-master/caltech-lanes-dataset/cordova2.txt /home/cardwing/Downloads/VPGNet-master/caffe/models/vpgnet-novp/LMDB_test `

@cardwing Hi I encountered the same problem as @fanqi1996 did. The error message is:
(after running ./make_lmdb.sh)
'''
E0730 17:49:56.138350 86589 convert_driving_data.cpp:73] argv[1]: home/simteam/VPGNet/caltech-lanes-dataset/cordova1
E0730 17:49:56.138882 86589 convert_driving_data.cpp:74] argv[2]: home/simteam/VPGNet/caltech-lanes-dataset/cordova1.txt
E0730 17:49:56.673770 86589 convert_driving_data.cpp:145] Total to be processed: 0.

Do you have any thoughts?
Many thanks!

okay turns out I dropped the "/" sign before "home", making absolute path a relative path. And now it looks fine.

@daixiaogang It's been a year and a half, My file is "cordova1/f00000.png". There is no location points... could you please send me your list file? I really really really appreciate it.  My email is<EMAIL_ADDRESS>Thank you!!

I recommend other lane detection models, i.e., LaneNet, SCNN-Tensorflow and SCNN-Torch.

Thank you so much for sending mail !!My other team is building SCNN-Touch.My teams is building vpg-net.Is there any reason to recommend a model like SCNN-Touch rather than vpg-net?
---------- 원본 메일 ----------
보낸사람: "HOU Yuenan"<EMAIL_ADDRESS>받는사람: "SeokjuLee/VPGNet"<EMAIL_ADDRESS>
참조: "Hwang Jung Pyeong"<EMAIL_ADDRESS>"Comment"<EMAIL_ADDRESS>
날짜: 2019-05-13 (월) 14:16:16
제목: Re: [SeokjuLee/VPGNet] Could you explain more details about how to

run make_lmdb.sh? (#6)
I recommend other lane detection models, i.e., LaneNet, SCNN-Tensorflow and SCNN-Torch.

—You are receiving this because you
commented.Reply to this email directly, view it on GitHub, or mute the thread.

SCNN has a message passing module which works extremely well in long-continuous object detection like lane detection. However, since message passing module accounts for around 30% of the total feedforward time, it is not ideal to select SCNN if you want real-time lane detection. In this condition, I recommend our light-weight model, i.e., ENet-Label, which uses ENet as the backbone and the overall feedforward time is around 15 ms (SCNN is 130 ms).

@ArayCHN Hi I meet the same problem like yours.
bash make_lmdb.sh  E0605 10:11:28.018514  9723 convert_driving_data.cpp:73] argv[1]: /home/ruwei/LaneDetection/VPGNet/caltech-lanes-dataset/cordova1 E0605 10:11:28.018903  9723 convert_driving_data.cpp:74] argv[2]: cordova1.txt E0605 10:11:28.555956  9723 convert_driving_data.cpp:145] Total to be processed: 0.
No matter how I changed the path , it does not work. My .sh like this
`../../build/tools/convert_driving_data /home/ruwei/LaneDetection/VPGNet/caltech-lanes-dataset/cordova1 cordova1.txt LMDB_train
../../build/tools/compute_driving_mean LMDB_train ./driving_mean_train.binaryproto lmdb
../../build/tools/convert_driving_data /home/ruwei/LaneDetection/VPGNet/caltech-lanes-dataset/cordova1 cordova1.txt LMDB_test`

@ArayCHN
The folder LMDB_train and LMDB_test have been created ,but no driving_mean_train.binaryproto.

@daixiaogang @chengm15 @CSUMIT Hi! i met the same issues. my .txt files contain no local point. could you send your txt files? my email is<EMAIL_ADDRESS>Thank you!


Update fzf repo

https://github.com/junegunn/fzf-bin is deprecated, all releases in main repo are now include binaries https://github.com/junegunn/fzf/releases

Perfect! Thanks for the PR!


upsert function doesnt return id value. Returns only success/error messages in response message

I am pointing to jsforce -> lib-> connection.js file where Connection.prototype.upsert  function. Wanted to know if this function would return a id value as response or just success/error messages. If this is as designed, how would upsert doing a create will work - as create would return a id in response. Please let us know the details asap.

It will not return id value when it is existing record. This is due to the REST API upsert behavior (which returns only HTTP 204).
https://www.salesforce.com/us/developer/docs/api_rest/Content/dome_upsert.htm
https://github.com/jsforce/jsforce/blob/master/test/connection-crud.test.js#L229-L251

Thanks for the response.But for both the cases - I meant even in the Create case i dont get an id. But normal upsert - Create operation returns an id.
Pointing to the same doc,
https://www.salesforce.com/us/developer/docs/api_rest/Content/dome_upsert.htm
Response
Successful response:
{
    "id" : "00190000001pPvHAAU",
    "errors" : [ ],
    "success" : true
}

The response body is empty. HTTP status code 201 is returned if a new record is created.

But this doesnt happen with jsforce.

I'm sure it returns id field in the response in the above test code (See that assertion is done in returned record)
https://github.com/jsforce/jsforce/blob/master/test/connection-crud.test.js#L236
Please verify your code or post the code which fails to retrieve the id.

okay. But we are calling https://github.com/jsforce/jsforce/blob/master/lib/sobject.js  -> upsert function -> our assumption is that it internally calls connection.js under https://github.com/jsforce/jsforce/blob/master/lib/connection.js. Please correct if i am wrong. In connection.js upsert function i could not see the response to be different for each. We have even printed console.dir for return(response) for our code but it gives only {success: true} or error messages. It doesnt return an id.

We are trying this ,
self.sfconn.sobject(sObjectName).upsert(data,extIdField, function(err, ret) {
if (err || !ret.success) {
logger.error({"message":"Salesforce Connector error"},{"errorMessage":"Exception occured while getting the connection","error":err});
callback(err, ret);
}else{
logger.info({"message":"Salesforce Connector : updateOrCreate Successful"})
callback(null, ret);
}
});
}.bind(this));

Can you please let me know any update on this ticket.

It cannot be said surely from your code but I'm afraid you are updating existing record instead of newly creating the one. Make sure the extIdField of the record is not dup in DB so that insert will happen in the upsert call.


Fix minor Grammar issue in Compact.md

Signed-off-by: Kartik Ramesh<EMAIL_ADDRESS>Found a minor grammatical issue in the Compacter Component Documentation. I was unsure if it's acceptable to make a PR for such a minor change, so I confirmed on Slack beforehand. Feel free to Close this PR if unacceptable.

[ ] I added CHANGELOG entry for this change.
[x] Change is not relevant to the end user.

Changes
Made slight grammatical changes to compact.md.

Thanks!


No transactions is displayed on Queue and History if there is a problem with connection to back-end( or back-end error)

Title/Description
In case of error on back-end the user see no transactions message. It's confusing when the user knows that his save contains may transaction and some of the in the Queue
Environment

Browser: Chrome
Safe: 0x8675B754342754A30A2AeF474D114d8460bca19b
Wallet: MM
App Version: 3.3.0
Environment:

production (mainnet)

Steps to reproduce
Precondition:

error on client gateway or transaction services side related to the transactions list loading

Steps

Go to Queue or History
Current result:  Transactions will appear here the message is displayed.

Expected result
More informative and not confusing error for the user in case of problems on back-end
Screenshots

For QA: how to simulate error from back-end for web-client

is this a bug or a feature?
I think we don't have UI designs to inform the user when some fetch has failed.
It should be handled consistently for all the pages.

Just synced with Tobi. This is a feature and should be addressed with https://github.com/gnosis/safe-react/issues/1868


Looks fine when previewed, but not when built

Firstly, I apologise for this silly question, but I'm trying to learn how to use github to host a blog and decided to use wintersmith.
Baiscally, I can make the blog and preview it; it looks fine when I preview, however when I build the blog and view the index.html on local host, it doesn't look anything like what's shown on the preview i.e. seems like none of the css stuff has been applied. Was whether there was a step I've missed? I was following this tutorial: https://www.youtube.com/watch?v=zLenQTdgPaI (I'm using windows 7 but everything works fine).
While I'm at it, once I built the files, is it a matter of uploading all the web-file (html, blog entries) on to my github-pages repository?

That is because Wintersmith assumes you will be deploying what's inside build, or that you will use a local webserver pointing at said directory to test it. Loading the index.html straight in a web browser (by double-clicking on it for example) will not load the CSS properly. Personally I would rather have the stylesheet be a relative path, maybe it's an easy fix to contribute.
For example, in index.html, have
    <link rel="stylesheet" href="css/main.css">

instead of:
    <link rel="stylesheet" href="/css/main.css">

and in articles/red-herring/, have:
    <link rel="stylesheet" href="../../css/main.css">

instead of:
    <link rel="stylesheet" href="/css/main.css">

You can also get the urls from the content tree directly, {{ contents.css['mystyle.css'].url }}


Modify workflow to use custom version of WRF, adding variables

Change source paths to urban-m4 forks of WRF and WPS
Add rule UP_TO_WPS for easier development
Add rule ADD_42 to modify geogrid output and insert an additional input field (temporarily, will do this properly later on)
Make all output relative to ./output so we can easily gitignore them
Add .gitignore for cleaner git status

@ClaireDons have a look at this. I might still change it, but for now I'm focusing again on WRF compilation. We can merge this so you can work again in a clean PR.


Edible Item animation doesn't work.

I'm using the edible_item powertype and it kinda works.
Almost everything functions as normal except when I right-click it doesn't actually eat the item, it just plays a slowed-down version of the interact animation (the one where the item drops down and comes back up).
I've looked through the other issues and the only ones similar to mine are caused by collective, which I don't have installed.
Are there any other mod incompatibilities? I can send my mods list if you'd like.

I don't know about any other mod incompatibilities, may I please have a mod list?

I had to specify the use_action, it works now.
I thought it defaulted to eat, but that doesn't seem to be the case.

I should still probably set a default.


feat: implement designed UI/UX

Description
The figma file is here: https://www.figma.com/design/2ADLprS4xgd0n3seuScE8V/🗳-MACI-RPGF?node-id=60-730&t=kLD8IaAg8dPVYO23-0

The very first commit message does not meet the commitlint rules, we can do either

rebase -i:  to reword the commit message, but still need to solve the conflicts through dozens of commits
squash commits: would lose the tracking history of this PR

I found something: the eslintignore in each packages is no use (? the eslintignore file in the root is actually working. So my question is: should we just remove the eslint files inside packages?

The maci versions should be update to v2.0.1 after it released.


WIP: cypress work

Proposed changes

Unreleased product version (optional)

Related issues (optional)

@zchase im going to close this cause i think we've solved it another way, pls reopen if ur still working on it


Simpler integration of config and the stdlib flag package

This enables simpler integration between the Config struct and the flag package which will make example consumers from nsq easier to use outside of that repo.
RFR @mreiferson
cc: @Dieterbe

I think I follow, want to see the changes on the https://github.com/bitly/nsq side before we land?

:+1:

PR on the nsq side will be forthcoming

ohh so thoughtful of you. thank you @jehiah <3


How i fix it. please help me.

Given I send and accept JSON          # cucumber-api-steps-0.13/lib/cucumber/api_steps.rb:21
      undefined local variable or method `app' for #<Object:0x007ffc32d779f0> (NameError)

After i setup project cucumber when i run
cucumber -p verbose features/

and then i found it. i don't know to fix it. please help.


[paho-mqtt] Fix wrong include path

Describe the pull request

What does your PR fix?
Fixes #15349
If link to the target eclipse-paho-mqtt-c::paho-mqtt3as the header files can't be found. The INTERFACE_INCLUDE_DIRECTORIES point to /home/sandro/vcpkg/installed/x64-linux/include whereas the headers are located in /home/sandro/vcpkg/installed/x64-linux/include/paho-mqtt
If this patch is removed it works as expected.
I have tested the usage successfully

Closing this PR since it seems that no progress is being made. Please reopen if work is still being done.


Add Revs Protection (GP SINK)

Add a protection option to the revs command to have a virtual clan protect you from PKers, no more deaths at revs.
Cost a few mill per trip or something, idk how much exactly but would be a good gp sink atleast - IIRC on osrs it was 150m osrs gp for a weeks protection, correct me if im wrong
would also mean people can pay to safely use revs weapons at revs without chance of being smited and losing them

I'm all for GP sinks! But where do we draw the line for the sinks? For example RC runners would be a very good GP sink, potentially sinking billions also Corp boosting, mob tagging, Blast furnace runners etc etc. And all of them are commonly used in game. (Blast furnace slight less)

Imo something like this definitely needs to be polled first to gauge the communities opinion on it. As Fishy said it's hard to say you can use this but then rc runners are not allowed


feedRandom should use an entropy pool instead of XORing the data with the key

The current method is simple, but probably also insecure. The reason I didn't do that already is that I'm getting stack corruption for some reason, which probably indicates a bigger issue

Spinel was since rewritten in Rust, so this is no longer an issue.


Working with Livescript

First up cheers for the plugin for ember-cli.
However I'm having a hard time getting the livescript files to work.
I created a fresh ember-cli project and ran the following to generate a application route
ember g route application
This created a new application.js file for me which I altered to look like this:
import Ember from 'ember';

export default Ember.Route.extend({
    model(){
        return { id: 10 };
    }
});

And I altered the application.hbs to look like this:

Welcome to Ember.js

Id: {{model.id}}

This would correctly display the following screen:

However when I alter application.js ( in the routes folder ) to instead use livescript ( renaming to application.ls ):
``import Ember from 'ember';``

``export default`` Ember.Route.extend do
	model: -> { id: 10 }

The application route no longer displays any id:

This is all after installing ember-cli-livescript, both via npm and ember:
npm install ember-cli-livescript --save-dev
ember install ember-cli-livescript
I'm not getting anything back from firebug or from the ember-inspector.
Is there another step I'm suppose to be taking?

[Closed]
Reason: Needed to restart the ember-client, running ember serve again.


[SPARK-33152][SQL] Improve the performance of constraint propagation for Project and Aggregate

What changes were proposed in this pull request?

To improve performance, changed the UnaryNode.getAllValidConstraints to discard constraints, that will not change the end result.
Why are the changes needed?

There has been at least two attempts at speeding up the constraint system: #30185 and #26257. Both of them seem to have stalled.
Optimizing project and aggregate nodes could have exponential memory and time complexity in relation to the number of aliases they have. Most simple example would be a Project, that has incoming columns a1, a2, ..., an and a child constraint a1 + a2 + ... + an > 0. If it would alias its columns a1 as b1, a2 as b2, ..., an as bn, then UnaryNode.getAllValidConstraints would return 2 to the power of n constraints (plus some isNotNull constraints) - each column is replaced by its alias in half of the constraints. All except one of these constraints would get filtered out later on - the one where all aliases are replaced is kept. Eagerly filtering these out will improve the performance and avoids possible OOM.
Does this PR introduce any user-facing change?

No
How was this patch tested?

New and existing UTs.
Manually verified the performance gain by an example provided in #30185 :
  object Optimize extends RuleExecutor[LogicalPlan] {
    val batches =
      Batch("InferAndPushDownFilters", FixedPoint(100),
        PushPredicateThroughJoin,
        PushPredicateThroughNonJoin,
        InferFiltersFromConstraints,
        CombineFilters,
        SimplifyBinaryComparison,
        BooleanSimplification,
        PruneFilters) :: Nil
  }

  test("benchmark") {
    val tr = LocalRelation(
      'a.int, 'b.int, 'c.int, 'd.int, 'e.int,
      'f.int, 'g.int, 'h.int, 'i.int, 'j.int,
      'k.int, 'l.int, 'm.int, 'n.int)

    val plan = tr.select('a, 'b, 'c, 'd, 'e, 'f, 'g, 'h, 'i, 'j, 'k, 'l, 'm, 'n,
      CaseWhen(Seq(('a.attr + 'b.attr + 'c.attr + 'd.attr + 'e.attr + 'f.attr + 'g.attr
        + 'h.attr + 'i.attr + 'j.attr + 'k.attr + 'l.attr + 'm.attr + 'n.attr > Literal(1),
        Literal(1)),
        ('a.attr + 'b.attr + 'c.attr + 'd.attr + 'e.attr + 'f.attr + 'g.attr + 'h.attr +
          'i.attr + 'j.attr + 'k.attr + 'l.attr + 'm.attr + 'n.attr > Literal(2), Literal(2))),
        Option(Literal(0))).as("JoinKey1")
    ).select('a.attr.as("a1"), 'b.attr.as("b1"), 'c.attr.as("c1"),
      'd.attr.as("d1"), 'e.attr.as("e1"), 'f.attr.as("f1"),
      'g.attr.as("g1"), 'h.attr.as("h1"), 'i.attr.as("i1"),
      'j.attr.as("j1"), 'k.attr.as("k1"), 'l.attr.as("l1"),
      'm.attr.as("m1"), 'n.attr.as("n1"), 'JoinKey1.attr.as("cf1"),
      'JoinKey1.attr).select('a1, 'b1, 'c1, 'd1, 'e1, 'f1, 'g1, 'h1, 'i1, 'j1, 'k1,
      'l1, 'm1, 'n1, 'cf1, 'JoinKey1).join(tr, condition = Option('a.attr <=> 'JoinKey1.attr))

    val t1 = System.currentTimeMillis()
    Optimize.execute(plan.analyze)
    val t2 = System.currentTimeMillis()

    val timeTaken = t2 - t1
    // scalastyle:off println
    println(s"Time taken to optimize = $timeTaken ms")
    // scalastyle:on println
  }

The optimization time for this was reduced from 25s to 0.2s.

Test build #133240 has started for PR 30894 at commit 03c6e56.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37838/

Test build #133242 has started for PR 30894 at commit 08dc723.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37840/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37840/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37840/

Test build #133242 has finished for PR 30894 at commit 08dc723.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133242/

Test build #133240 has finished for PR 30894 at commit 03c6e56.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133240/

Test build #133262 has started for PR 30894 at commit 4bd8c06.

Test build #133262 has finished for PR 30894 at commit 4bd8c06.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133262/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37860/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37860/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37860/

Test build #133318 has started for PR 30894 at commit e554605.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37911/

Test build #133318 has finished for PR 30894 at commit e554605.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ConstraintPropagationSuite extends SparkFunSuite with PlanTest with PrivateMethodTester

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133318/

cc @maropu , @HyukjinKwon

cc @gengliangwang too

cc @gengliangwang too

Test build #133626 has started for PR 30894 at commit 8cf2da9.

Test build #133626 has started for PR 30894 at commit 8cf2da9.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38215/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38215/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38215/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38215/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38215/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38215/

Test build #133649 has started for PR 30894 at commit 0c156f7.

Test build #133649 has started for PR 30894 at commit 0c156f7.

Test build #133626 has finished for PR 30894 at commit 8cf2da9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #133626 has finished for PR 30894 at commit 8cf2da9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133626/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133626/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38238/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38238/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38238/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38238/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38238/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38238/

Test build #133649 has finished for PR 30894 at commit 0c156f7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #133649 has finished for PR 30894 at commit 0c156f7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133649/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133649/

Checked the 2 git action errors:

CliSuite.SPARK-29022: Commands using SerDe provided in --hive.aux.jars.path
It is a timeout error and cannot be reproduced in my local enviroment.
This test will download jar file from maven repository. Maybe it is a temporary network issue.
SparkScriptTransformationSuite.SPARK-33934: Add SparkFile's root dir to env property PATH
Caused by PR https://github.com/apache/spark/pull/30973 and has been fixed by PR https://github.com/apache/spark/pull/31046

Look forward to see this PR get merged.

Test build #136771 has started for PR 30894 at commit f1332eb.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41354/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41354/

@cloud-fan, there have been some reviews allready, but perhaps you could also take a look.

Hi @tanelk  @HyukjinKwon @maropu any updates for this pr, we've also met this issue for many spark jobs.


add cents for PHP

Sorry, i missed this before but Philippine peso has 2 decimal cents

Thanks again :)


please add ability to change button type

I have found that there are so many data-type that line developer provide
I want to use data-type => share-d but for that I have to change it directly in share.js
if I want to use this in another project I have to change it like this every time
so please make it can be config

Feature was added with an updated README.md.


adding RGD to dqm loading pipeline, adding 'medline' and 'sici' to ignore-id-list for xml-to-json script

and fixes to make sure XREF prefixes are removed before comparing data from db and from json, and some other random fixes for lit_processing scripts.

Thanks for looking over the fixes @valearna

Thanks ! @valearna

@azurebrd Thanks Juancarlos for checking out this PR.


CI: Simplify preparation on Windows

Requirements for Contributing a Performance Improvement

Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
The pull request must only affect performance of existing functionality. To contribute other changes, you must use a different template. You can see all templates at https://github.com/atom/.github/tree/master/.github/PULL_REQUEST_TEMPLATE.
After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see https://github.com/atom/.github/tree/master/CONTRIBUTING.md#pull-requests.

Description of the Change

Don't "update npm" twice. Once is enough.
Don't explicitly set a version of Python. We can use whatever version we want, so long as it's 2.6+ or 3.5+. 3.7 is included in the image, so why not use that?

Admittedly this does not cause a performance improvement for us. It does simplify our preparation.yml a bit, though.

Quantitative Performance Benefits

About 45 seconds is saved before bootstrapping/building on Windows, and another 45 seconds is saved in each Windows test job.

Installing npm-windows-upgrade takes about 20 seconds
Running npm-windows-upgrade takes about 24 or 25 seconds.

See the time taken for those steps in this CI run for an example: https://dev.azure.com/DeeDeeG/b/_build/results?buildId=625&view=logs&j=2985f0af-e798-5fdc-91b8-be9f0a3685c5&t=33143b02-a236-56d5-9221-c8b903d3c111
Possible Drawbacks

This PR un-pins the Python version, so @aminya I'm not sure whether you prefer we keep the Python version pinned?
Verification Process

CI Passes. For example: https://dev.azure.com/DeeDeeG/b/_build/results?buildId=624&view=results
Applicable Issues

None.
Release Notes

N/A

Should universal Python 3 be a separate PR? Usually I'd say yes, but they're such small changes. It'll be awkward to think of a PR title that fits, but I can make it work.


feat(upload): added ssl cert options to upload and download function

Original Issue: https://github.com/tauri-apps/plugins-workspace/issues/2092
Add skip_ssl_cert_check and trust_ssl_cert options to upload and download function, to skip ssl check or trust a given self signed ssl cert.
Sample Code:
 download(
      "https://localhost:9559/stream-file",
      "/Users/hk/Downloads/test.mp4",
      (progress) => {
        console.log(progress);
      },
      undefined,
      undefined,
      {
        skipSslCertCheck: true,
      }
    ))

My app (https://github.com/kunkunsh/kunkun) includes a local file transfer server. Self-signed cert is used for data encryption, but this plugin doesn't support self-signed cert or skipping SSL check.

Another suggestion: a options field is added to the JS API download() and upload(), which prevents having to use undefined for not used variables. headers and body field should also be added to the options object.
But to keep backward compatibility, I didn't move them in the PR to avoid breaking the API.


[BUG] Longhorn upgrade fails from 1.2.6 to 1.3.x when keeping volumes attached

Describe the bug (🐛 if you encounter this issue)
Longhorn upgrade fails from 1.2.6 to 1.3.x when keeping volumes attached
longhorn-manager-krjn4                                0/1     CrashLoopBackOff   14 (5m1s ago)    51m
longhorn-manager-gns2x                                0/1     CrashLoopBackOff   14 (4m59s ago)   51m
longhorn-manager-g9lw4                                0/1     CrashLoopBackOff   14 (4m43s ago)   51m

time="2023-06-15T15:57:56Z" level=warning msg="Error syncing Longhorn volume longhorn-system/pvc-efc10ad8-6a93-4bdc-a4e5-00a11b0d11b4" controller=longhorn-volume error="failed to sync longhorn-system/pvc-efc10ad8-6a93-4bdc-a4e5-00a11b0d11b4: unable to get engine image longhornio/longhorn-engine:v1.3.x-head: engineimage.longhorn.io \"ei-fb0e9660\" not found" node=ip-10-0-2-197
time="2023-06-15T15:57:29Z" level=warning msg="Error syncing Longhorn volume longhorn-system/pvc-efc10ad8-6a93-4bdc-a4e5-00a11b0d11b4" controller=longhorn-volume error="failed to sync longhorn-system/pvc-efc10ad8-6a93-4bdc-a4e5-00a11b0d11b4: unable to get engine image longhornio/longhorn-engine:v1.3.x-head: engineimage.longhorn.io \"ei-fb0e9660\" not found" node=ip-10-0-2-128
time="2023-06-15T15:57:29Z" level=fatal msg="Error starting manager: admission webhook \"validator.longhorn.io\" denied the request: failed to set the setting storage-network with invalid value : cannot apply storage-network setting to Longhorn workloads when there are attached volumes"
time="2023-06-15T15:57:56Z" level=fatal msg="Error starting manager: admission webhook \"validator.longhorn.io\" denied the request: failed to set the setting storage-network with invalid value : cannot apply storage-network setting to Longhorn workloads when there are attached volumes"
time="2023-06-15T15:57:33Z" level=warning msg="Error syncing Longhorn volume longhorn-system/pvc-efc10ad8-6a93-4bdc-a4e5-00a11b0d11b4" controller=longhorn-volume error="failed to sync longhorn-system/pvc-efc10ad8-6a93-4bdc-a4e5-00a11b0d11b4: unable to get engine image longhornio/longhorn-engine:v1.3.x-head: engineimage.longhorn.io \"ei-fb0e9660\" not found" node=ip-10-0-2-227
time="2023-06-15T15:57:33Z" level=fatal msg="Error starting manager: admission webhook \"validator.longhorn.io\" denied the request: failed to set the setting storage-network with invalid value : cannot apply storage-network setting to Longhorn workloads when there are attached volumes"

QoS Class:                   BestEffort
Node-Selectors:              <none>
Tolerations:                 node.kubernetes.io/disk-pressure:NoSchedule op=Exists
                             node.kubernetes.io/memory-pressure:NoSchedule op=Exists
                             node.kubernetes.io/not-ready:NoExecute op=Exists
                             node.kubernetes.io/pid-pressure:NoSchedule op=Exists
                             node.kubernetes.io/unreachable:NoExecute op=Exists
                             node.kubernetes.io/unschedulable:NoSchedule op=Exists
Events:
  Type     Reason     Age                   From               Message
  ----     ------     ----                  ----               -------
  Normal   Scheduled  51m                   default-scheduler  Successfully assigned longhorn-system/longhorn-manager-g9lw4 to ip-10-0-2-197
  Normal   Pulled     51m                   kubelet            Container image "longhornio/longhorn-manager:v1.3.x-head" already present on machine
  Normal   Created    51m                   kubelet            Created container wait-longhorn-admission-webhook
  Normal   Started    51m                   kubelet            Started container wait-longhorn-admission-webhook
  Normal   Started    51m (x4 over 51m)     kubelet            Started container longhorn-manager
  Normal   Pulled     50m (x5 over 51m)     kubelet            Container image "longhornio/longhorn-manager:v1.3.x-head" already present on machine
  Normal   Created    50m (x5 over 51m)     kubelet            Created container longhorn-manager
  Warning  BackOff    109s (x244 over 51m)  kubelet            Back-off restarting failed container

To Reproduce
Steps to reproduce the behavior:

Install Longhorn v1.2.6
Create a volumes used by Deployment
Upgrade Longhorn to v1.3.x
See error

Expected behavior
The Longhorn upgrade from version 1.2.6 to 1.3.x should be successful while keeping volumes attached.
Log or Support bundle
Environment

Longhorn version: v1.3.x
Installation method (e.g. Rancher Catalog App/Helm/Kubectl):Kubectl
Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version:v1.24.8+k3s1

Number of management node in the cluster:1
Number of worker node in the cluster:3

Node config

OS type and version: SLES 15.4
CPU per node: 4
Memory per node: 16G
Disk type(e.g. SSD/NVMe): SSD
Network bandwidth between the nodes:

Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal):AWS
Number of Longhorn volumes in the cluster:

Additional context

@roger-ryao we have daily regression for the 1.3.x upgrade, what's the result there?

Hi @innobead :
When I attempted to fix the daily regression for the 1.3.x upgrade (PR: https://github.com/longhorn/longhorn-tests/pull/1425), I discovered that the upgrade also failed with my private longhorn-test image. You can check the details in the console output: https://ci.longhorn.io/job/private/job/longhorn-tests-regression/4145/console.
That's why I tried to reproduce it and investigate the issue.


Add interactions (Slash commands)

Slash commands will be officially coming to discord.js in version 13 which is right around the corner. Currently, the version directly from the Github repository can be used to test it out.
Slash commands should ideally be added to the bot at least for the water prefixed commands, to begin with.
Some work has been started on this in the dev branch. Contributors can use this as a jumping-off point.

I would like to be assigned to this issue


imwrite does ignore nifti intent_code and intent_name

Description
When saving images using itk.imwrite() in nifti format the writer does ignore nifti intent_code and nifti intent_name.

Steps to Reproduce

Load image with intent_code / intent_name or set them on loaded image
Save the image with itk.imwrite(image, some_place.nii)
Load the saved image and check new_img['intent_code'] and new_img['intent_code']

Expected behavior
itk.imwrite() respects intent_code and intent_name

Actual behavior
intent_code is set to 0 and intent_name to ""

Reproducibility
Every time

Versions
itk-io 5.2.1.post1
and higher

Environment
Python 3.8, 3.9, 3.10

@ch-n   The intent_code and intent_name are specific to the nifti file format.  They are not part of the ITK data model and therefore are not managed by ITK.
As an application developer, you could potentially use the metadata dictionary functionality to privately manage those values in your application.
The code currently works as expected and is documented according to the designed ITK behavior.


Refactoring: add reorder modules

This PR moves stuffs related to reordering items into a reorder module.

Looks good, thanks!


Support asynchronous computed

What problem does this feature solve?
This would allow

computation to rely on WebAPIs, for example IndexedDB
implementation of event loop non-blocking computation
implementation of debouncing / throttling or other custom use cases

What does the proposed API look like?
a = computed(async () => {
  return await IndexedDB.get(id.value) + 5;
});

...

await a.value // get value

You could say this feature works out of the box, but unfortunately dependency on b is not tracked in this example
a = computed(async () => {
  return await IndexedDB.get(id.value) + b.value;
});

A complete example would be helpful in understanding what your actual usecase is.
What's b? Where would you await a computed? And are you aware that collection of reactive effects is inherently synchronous in all kinds of effects in Vue?

In such a situation, the watch could come in handy

Have you tried https://vueuse.org/core/computedasync?

@sqal @lidlanca both of your proposed solutions have the same problem - I quote from https://vueuse.org/core/computedasync/

Dependencies that are accessed asynchronously will not trigger re-evaluation of the async computed value.

@lidlanca your proposed workaround does not cover some scenarios, for example
const getDependency = (key) => ...

const a = computed(async () => {
  const c = await IndexedDB.get(id.value);
  return await IndexedDB.get(getDependency(c).value);
});

@boussadjra thanks, unfortunately watch would not solve the problem example I provided above

@LinusBorg I try to keep examples laconic, so we do not dig into irrelevant details.

What's b?
Let's say b = ref(5). It could be any Vue computed / ref.

Where would you await a computed?
Anywhere where I want to use it, let's say before making request to some API.

And are you aware that collection of reactive effects is inherently synchronous in all kinds of effects in Vue?
Yes, I am aware. I don't see how it helps solving the problem.

irrelevant details.

I'm nto asking to get into irrelevant details, I'm asking to understand the use case and the kind of usage you have in mind.
for that, abstract one-line examples are not really useful.

Anywhere where I want to use it, let's say before making request to some API.

Can you write a short example how what would look like?

Yes, I am aware. I don't see how it helps solving the problem.

I wasn't saying it's solving the problem in any way. Quite to the contrary, I was pointing out that dependency collection in Vue is synchronous in general, and as such is fundamentally unsuited for what I so far think you seem to ask for.

@LinusBorg as I understand that's the point of having issues here in GitHub - discussing valuable changes (fundamental ones included). Please correct me if I'm wrong.
I provided few use cases in the very beginning:

computation to rely on WebAPIs, for example IndexedDB
implementation of event loop non-blocking computation
implementation of debouncing / throttling or other custom use cases

In my opinion your questions / requests are irrelevant and exhausting, please don't be surprised if I stopped replying you.

I'm not sure how I gave the impression that I want to stop discussion. I just pointed out the scope. If I gave that impression, sorry for that.
Also feel free to stop replying. Just consider that we likely won't implement something that we don't see a need for ourselves "and* for which we don't have concrete use cases / expectations / scenarios. That's what I wanted to get more understanding on with my questions. But you are free to not help me understand better.
Me failing to fully imagine the desired usage from your short descriptions of course doesn't mean that  all of our team will have the same trouble that I have, so maybe someone will understand and implement it.

@LinusBorg with all due respect I guess that your teammates of higher seniority (for example @yyx990803) would understand the problem well.
Vue is amazing, thank you for contributing to it.

Lol

const getDependency = (key) => ...
const a = computed(async () => {
const c = await IndexedDB.get(id.value);
return getDependency(c).value;
});

this does not handle all possible use cases, but  it address a way for the use case you presented.

const getDependency = (key) => ...

// using vueuse to simplify handling of a computed based on a promise.
const a = computedAsync(async () => {
  return await IndexedDB.get(id.value);
});

const b = computed(()=>{
  if(a.value){
    return getDependency(a.value).value
  }
})

@lidlanca I agree, this could be a workaround in many cases, thanks!
However an ideal solution in my opinion would be native support for async computed in @vue/reactivity. I have nice use cases for this library in Node.js environment where VueUse does not belong I assume.

Dependencies that are accessed asynchronously will not trigger re-evaluation of the async computed value.

This is a fundamental limitation of how Vue's reactivity system works, unless JavaScript provides a mechanism to capture function execution context across async ticks.
What you can do is to ensure the deps you are interested in are accessed synchronously before entering the first await:
a = computed(async () => {
  const idVal = id.value
  const bVal = b.value
  return await IndexedDB.get(_id) + _b;
});

A form of async computed that tracks deps across async ticks could potentially be done by using a generator function, but either way there is no plan to provide this feature in Vue core because:

This is a niche case with a great amount of complexity.
Vue provides enough primitives to do this in userland.

Side note: @donatas-luciunas your interaction with @LinusBorg has been patronizing and borderline rude. I'm sure you wouldn't be pleased if I imply that your request roots from a lack a good understanding of how Vue's reactivity tracking works. Please be respectful when interacting with maintainers who are trying to help you. If you continue with this attitude, don't be surprised for not getting any further replies from the team.

@yyx990803

This is a fundamental limitation of how Vue's reactivity system works, unless JavaScript provides a mechanism to capture function execution context across async ticks.

I agree that it is not possible with the API I described, but you could change the API
const getDependency = (key) => ...

const a = computed(async (value) => {
  const c = await IndexedDB.get(value(id));
  return value(getDependency(c));
});

where parameter value is a unique function for every caller. Do you agree this could work?

What you can do is to ensure the deps you are interested in are accessed synchronously before entering the first await:

As I mentioned this workaround does not cover some scenarios, for example the one I provided above here.

This is a niche case with a great amount of complexity.

I do not agree on niche adjective. If you are interested let me share a bit of a vision. Let's assume @vue/reactivity supports async computed.
For example we have 3 separate components that rely on the same peace of data that is retrieved with fetch. We could use async computed for such scenario and minimal amount of fetch invocations would be ensured (invoked with first call; cached until invalidated; recomputed if watched).
Imagine not one peace of data, but whole business model expressed as computed values some depending on others. You could use dependency injection container (could be inversify for example) to avoid clutter. Again @vue/reactivity would ensure minimal amount of fetch invocations, which is more or less a target for every developer.
It seems that Vue tries to address this problem with async setup, but it has it's limitations. I wanted to offer this alternative approach, as it would ensure optimal runtime elegantly.
Is there a possibility you will reconsider supporting async computed?

I'm sure you wouldn't be pleased if I imply that your request roots from a lack a good understanding of how Vue's reactivity tracking works.

I believe we have a misunderstanding on what a "feature request" means. Do you mean that feature requests that are not easy to implement are not welcome?

If you continue with this attitude, don't be surprised for not getting any further replies from the team.

Why do you look at the speck of sawdust in your brother’s eye and pay no attention to the plank in your own eye? That's retorical.

...where parameter value is a unique function for every caller. Do you agree this could work?

No, because async dependency collection creates race conditions where each re-run of the entire async effect could produce different set of dependencies to be tracked. This is much more complicated than it may seem.

As I mentioned this workaround does not cover some scenarios, for example the one I provided above here.

You example is not technically valid, because the return value of IndexedDB.get can never be a reactive dependency. Vue's reactivity system implies that reactive dependencies are created before the effects runs - they cannot be created on the fly during an effect (and then tracked by the effect itself).

Is there a possibility you will reconsider supporting async computed?

No. I still believe it's a niche case and most common scenarios can be solved by synchronously accessing necessary dependencies upfront before starting going into async land.

I believe we have a misunderstanding on what a "feature request" means. Do you mean that feature requests that are not easy to implement are not welcome?

As maintainers, we not only have to gauge the cost of not only implementing something, but also the cost of maintaining it forever afterwards. To ensure it is worth prioritizing over other things that we have to spend time on (which is limited), we also need to consider how many users would actually benefit from it. In this case, we have decided to not honor this request due to the reasons I have already outlined.
Coming back to your question: "feature request" means it is entirely up to the maintainer to decide whether to honor it or not. You can disagree with our reasoning behind the decision, but that doesn't make us in any way obliged to implement it, or even continue to engage in the conversation.

Why do you look at the speck of sawdust in your brother’s eye and pay no attention to the plank in your own eye? That's retorical.

I have looked at the comments from both sides and I do not see anything inappropriate from @LinusBorg, and certainly nothing that warrants the patronizing tone you have used against him.

Please note maintainers have no obligation to spend more effort than they deem necessary. I have responded with as much patience as I can, explaining why we are not interested in implementing it. In short: not worth it in core, maybe doable in userland for those who really need it. Again, you can disagree with the reasoning, but you are in no position to demand anything. I have no interest in engaging further on this topic.


Refactor system/config wizard forms to import the reverse direction

Is your feature request related to a specific problem?
Right now, we import config wizard forms into the system forms because the config wizard forms were built first. It would make more intuitive sense if we imported the other way around.
Describe the solution you'd like
Move all the system related forms to the system directory, then update imports.
Describe alternatives you've considered, if any
We don't have to do this, but it'd be nicer :)
Additional context
https://github.com/ethyca/fides/pull/1072#discussion_r972316650

Closed by https://github.com/ethyca/fides/pull/1097


Nintendo Switch support

It would really be useful for me, please do it if it's not that hard for you!

Hello @Sokolargm, thanks for the interest in the plugin! Unfortunately I don't have a Nintendo Switch to test the library. And I think there is a Unity license needed to build for Nintendo Switch.

Ok, thanks for the reply😁
пт, 25 авг. 2023 г., 12:06 Gindemit Konstantin @.***>:

Hello @Sokolargm https://github.com/Sokolargm, thanks for the interest
in the plugin! Unfortunately I don't have a Nintendo Switch to test the
library. And I think there is a Unity license needed to build for Nintendo
Switch.
—
Reply to this email directly, view it on GitHub
https://github.com/gindemit/unity-wrapper-vorbis/issues/5#issuecomment-1693031613,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOGRRWBDGACGN5BBF44QZODXXBTINANCNFSM6AAAAAA34CJQQ4
.
You are receiving this because you were mentioned.Message ID:
@.***>

If you have the license, and the device to test, you can try to build it youself. Here are the instructions for the other platforms:
https://github.com/gindemit/unity-wrapper-vorbis/wiki/Building-from-Source
I can assist you if you encounter any issues.


More detections for the Object Analyzer

This adds more detections to the object analyzer:

BgCheck Collision

CollisionHeader
CollisionVertices
CollisionPolygons
CollisionSurfaceTypes
CollisionCamData

Other limb types

SkinLimb
LODLimb

LinkAnimationHeader in gameplay_keep
Material Animations in Majora's Mask, all 6 types (some share the same holder data)

MatAnimHeader
MatAnimTexScrollParams
MatAnimColorParams
MatAnimTexCycleParams
MatAnimTextureIndexList
MatAnimTextureList

Addresses #30 and #31.
This also removes the assumption that single limb skeletons do not exist, as it has been shown they do. I'm unsure whether there are any regressions caused by this change, since as I mentioned in #48 there isn't a great way to check this currently except just trying a few objects.
Still to do:

C Exporter for Collision and Material Animations
Skeleton Renderer supporting other limb types

Very cool
This doesn't change or add anything rendering-wise, right? Or does it allow rendering skeletons using skin/lod limbs?

That's correct it doesn't add any new rendering features, it just makes the data available for possible renderers to be added.


import maria conf

This was manually configured on prod based on the previous hosting and should be recorded in the playbook.

hey @pushcx You added the file on the commit<PHONE_NUMBER>4184fb38eb80fc838be3ac86b647fd. So you can close this one.


Breaking changes / regression on runtime parameters handling

Describe the Bug with repro steps
Context : logic app consumption
We notice a recent change in the way Logic App is handling parameters that make impossible to save (in code view) the workflow.
The following minimal sample can be saved without errors in the code view :
{
    "definition": {
        "$schema": "https://schema.management.azure.com/providers/Microsoft.Logic/schemas/2016-06-01/workflowdefinition.json#",
        "contentVersion": "<IP_ADDRESS>",
        "triggers": {
            "Recurrence": {
                "type": "Recurrence",
                "recurrence": {
                    "interval": 10,
                    "frequency": "Day"
                }
            }
        },
        "actions": {},
        "outputs": {},
        "parameters": {
            "param0": {
                "type": "Bool",
                "defaultValue": true
            },
            "$connections": {
                "type": "Object",
                "defaultValue": {}
            }
        }
    },
    "parameters": {
        "param0": {
            "type": "Bool",
            "value": true
        },
        "$connections": {
            "value": {}
        }
    }
}

The following minimal sample cannot be saved in the code view :
{
    "definition": {
        "$schema": "https://schema.management.azure.com/providers/Microsoft.Logic/schemas/2016-06-01/workflowdefinition.json#",
        "contentVersion": "<IP_ADDRESS>",
        "triggers": {
            "Recurrence": {
                "type": "Recurrence",
                "recurrence": {
                    "interval": 10,
                    "frequency": "Day"
                }
            }
        },
        "actions": {},
        "outputs": {},
        "parameters": {
            "param0": {
                "type": "Bool",
                "defaultValue": true
            },
            "$connections": {
                "type": "Object",
                "defaultValue": {}
            }
        }
    },
    "parameters": {
        "param0": {
            "type": "Bool",
            "value": false
        },
        "$connections": {
            "value": {}
        }
    }
 #}

Error returned :
"error": {
        "code": "InvalidTemplate",
        "message": "The template validation failed: 'The value for the workflow parameter 'param0' at line '1' and column '170' is not provided.'."
    }

The only change made is switching the param0 value from false to true in the runtime parameters.
What type of Logic App Is this happening in?
Consumption (Portal)
Which operating system are you using?
Windows
Are you using new designer or old designer
New Designer
Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg
Yes
Workflow JSON
{
"definition": {
"$schema": "https://schema.management.azure.com/providers/Microsoft.Logic/schemas/2016-06-01/workflowdefinition.json#",
"contentVersion": "<IP_ADDRESS>",
"triggers": {
"Recurrence": {
"type": "Recurrence",
"recurrence": {
"interval": 10,
"frequency": "Day"
}
}
},
"actions": {},
"outputs": {},
"parameters": {
"param0": {
"type": "Bool",
"defaultValue": true
},
"$connections": {
"type": "Object",
"defaultValue": {}
}
}
},
"parameters": {
"param0": {
"type": "Bool",
"value": false
},
"$connections": {
"value": {}
}
}
#}
Screenshots or Videos
No response
Browser
Chrome
Additional context
We also notice that :

the runtime parameters's type is now mandatory when saving with code view (an error is triggered if not)
when switching to UI and then code view the runtime parameters's type is deleted, so if an other change need to be done in code view, the parameter's type need to be added manually to be saved.

Hey @bkgge, thanks for reporting this issue, I've identified the issue and have a bugfix for this.

Hi @Eric-B-Wu, thanks for the quick fix, do you know when it will be delivered to the logics apps designer in the Azure portal ?


Get Started with the SAP BTP Command Line Interface (btp CLI)

Tutorials: https://developers.sap.com/tutorials/cp-sapcp-getstarted.html
In step 4, i had to download the btp cli.  when I tried to login using the btp login, i got the below error; my client is too new.
There is no previous version available on the SAP development tools page
C:\Users\i063230\Downloads\windows-amd64>btp login
SAP BTP command line interface (client v2.10.0)
CLI server URL [https://cpcli.cf.eu10.hana.ondemand.com]>
Connecting to CLI server at https://cpcli.cf.eu10.hana.ondemand.com...
Your client (2.10.0) is too new and not supported by the configured server (2.9.0).
Please download a client version 2.9.x from: https://tools.hana.ondemand.com/#cloud-btpcli
Could not log in to CLI server.
If the problem persists, contact support at component 'BC-CP-TOOLS-CLI'.
ERROR

Hey David, we're working on this, but for the time being, please install client version 2.8 from SAP Development Tools page.
When logging in with version 2.8, you may get an error about the config file. Please just delete the config.json from the location given in the error message.
Sorry for the inconvenience!
Kind regards,
Anna