[UI] Replace notistack with MaterialUI Snackbar

Current Behavior
This issue is related to meshery-ui-restructring branch
The dev server crashes on start with the following log:
prakhar@prakhar-ubuntu:~/Documents/meshery$ make run-ui-dev
cd ui; npm run dev; cd ..

><EMAIL_ADDRESS>dev
> npm run dev:proxy

><EMAIL_ADDRESS>dev:proxy
> node ui_dev_server.js

warn  - Disabled SWC as replacement for Babel because of custom Babel configuration "babel.config.js" https://nextjs.org/docs/messages/swc-disabled
info  - Using external babel configuration from /home/prakhar/Documents/meshery/ui/babel.config.js
error - ./node_modules/notistack/dist/notistack.esm.js:4:0
Module not found: Can't resolve '@material-ui/core/Slide'

Import trace for requested module:
./pages/_app.js

https://nextjs.org/docs/messages/module-not-found

This happens because currently we were using notistack previously which was dependent on mui v4 but since now we are using mui v5 and have to use the snackbar component provided by mui v5 (https://mui.com/components/snackbars/).
We will have to remove notistack from the list of dependencies and make sure this error does not exist.
Desired Behavior
All notistack toasts are replaced by new mui5 Snackbars
Environment

Browser: Chrome Safari Firefox
Host OS: Mac Linux Windows
Meshery Server Version: stable-v
Meshery Client Version: stable-v
Platform: Docker Kubernetes

Contributor Guides and Resources

🎨 Wireframes and designs for Meshery UI in Figma
🖥 Contributing to Meshery UI
🙋🏾🙋🏼 Questions: Layer5 Discussion Forum and Layer5 Community Slack

I would like to solve this issue

Go ahead @Prakhar-Agarwal-byte .


⚠ Avatar API Endpoint has degraded performance

In 09edd7f, Avatar API Endpoint (https://avatar.roblox.com/v1/avatar-rules) experienced degraded performance:

HTTP code: 200
Response time: 4761 ms

Resolved: Avatar API Endpoint performance has improved in ebc10c1 after 9 minutes.


Region, queue name parsing, message based on protocol

First of all - good job! :) You saved me a lot of time. Have been using fake_sns for a year but it is just sooo slow, so was about to write my own implementation and then i found this repo!
Anyways, as i said i have been using fake_sns and we have hundreds of integration tests that we use to test our service here internally. When i have tried to use this impl I had to implement these fixes.
Now these integration tests we run against fake_sns we also run against real SNS/SQS to make sure those are compatible. So with fixes in this PR our suite passes all tests.
Changes:

Add region to config
While parsing queue name we need to split it by ':' and use last element as queue name
Return message based on protocol, basically currently it returns json with two keys default and sqs, based on protocol we need to return only one

If you are willing to maintain this repo I will gladly contribute to it :), but if not, then please let me know.
Thank you!

@tomasbartkus - Thank you for the kind words and the PR.  I will certainly maintain this into the foreseeable future as future as we also use it for all out integration tests here.  Let me give this a run in our environment and make sure that your changes are compatible with our suite as well.  If that all goes well which I do not anticipate a problem I will merge this at the latest over the weekend.
Thanks!

Awesome! Thanks!


update backup details merge code to handle deleted items

closing as after more thought this is not required. Only items that were actually sent to kopia will have entries denoting that they need merged from the base snapshot


assets precompile failed

Hi,
ive checked a post from 2014 with similar issue, but i couldnt find a solution with it.
i realize it attempt to load routes which causes it to load User model and causing error because it tries to connect to the database.
when i commented out the devise routes in the route file, it works fine.
using:
railties-5.0.0.rc2
devise 4.0.3
thank you

Please use StackOverflow for questions/help, where a wider community will be able to help you. We reserve the issues tracker for issues only.
Thank you!


Consider making blocks look more like the underlying language

This is speculation more than a feature request.  I'm interested in thoughts on the matter.
The goal of the original Blockly project was to create a stand-alone block-based environment to teach beginning computer programming, and they made some design choices to support that goal.  Among them: name blocks with clear English language words and grammar.
The goals of CodeWorld are a bit different.  Among these goals: get students familiar and comfortable with working with mathematical notation, and keep the bridge open to graduate from the block UI to the text UI for more advanced projects.  I'm coming to believe that this difference in goals should be reflected in the UI.  Perhaps the blocks should:

consistently use the same names as CodeWorld: "drawingOf" rather than "Drawing Of", for example.
have visible parentheses, commas, and other syntax.
always use the "inline" style of embedding sub-blocks rather than attaching them on the side.

This might look a little less familiar to beginning students, it's true.  It might accomplish more of the goals of the project.
Discussion welcome.  I'm not even sure what I personally think.

I'm also for making this closer to the underlying language. A block based interface is good for getting students motivated and familiar with the concepts, but such an interface can't be used indefinitely. Educational block based languages are used temporarily as a means to introduce computer programming.
The end point should be to get students familiar enough to be able to move on to a text based environment, and having functions show their CodeWorld names will make the transition easier.
On the other side it might also be important to get students familiar with programming in a friendly and intuitive manner, so that they understand programming concepts and think logically about programs. This might involve making the interface as easy as possible to use and disregarding some notational consistency.
Some of Blockly Games' later examples have blocks that represent their JavaScript almost identically, with parentheses and commas and so on.
Too much such characters looks like line noise, and I'm not sure how much of that would be remembered if the user does not have to type it himself.
Probably some compromise is needed to make the interface as friendly as possible and make it easy to move on to text based programming later.
I don't really know how to weigh these as I don't have much experience teaching programming. Just my 2 cents.

I like the change to use CodeWorld function names.
Further things to think about here:

Add language syntax, such as parentheses and commas, to the blocks.
Render the "helper" text that labels parameters in a smaller size and/or different color, to distinguish it from the actual program.  Or perhaps move it to the tooltip.

Would still be great to add the language syntax (parens and commas) to the blocks.

Thanks for the updates on this.  A few places that could still use the change:

Add parentheses and commas to user-defined function blocks (but remove them for the first-class representation?  Is that possible?)
Add parentheses and commas in the let block, when there are parameters.
Add an equal sign to the let block.
Add the data keyword when defining new types.
Add parentheses and commas for constructors and their parameters, in data blocks, case blocks, and constructor blocks.


feat: added iframe with eventListener for coming messages

changes:

added an iframe with an eventListener to listen for new messages to update the localStorage with the deriv-app

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

4 of 5 (80.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.003%) to 75.261%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/components/DerivIframe/DerivIframe.tsx
2
3
66.67%

Totals

Change from base Build<PHONE_NUMBER>:
0.003%

Covered Lines:
4382

Relevant Lines:
5275

💛  - Coveralls


Cannot find generate_rdtest_bed.R in the gatksv/sv-pipeline-qc docker environment

In Module03Qc.wdl,

task VcfExternalBenchmark_to_Rdtest {
input {
File vcf_stats
File comparator
String sv_pipeline_qc_docker
RuntimeAttr? runtime_attr_override
}
Float input_size = 2 * size(vcf_stats, "GiB")
Float compression_factor = 5.0
Float base_disk_gb = 5.0
Float base_mem_gb = 2.0
RuntimeAttr runtime_default = object {
mem_gb: base_mem_gb + compression_factor * input_size,
disk_gb: ceil(base_disk_gb + input_size * (2.0 + 2.0 * compression_factor)),
cpu_cores: 1,
preemptible_tries: 3,
max_retries: 1,
boot_disk_gb: 10
}
RuntimeAttr runtime_override = select_first([runtime_attr_override, runtime_default])
runtime {
memory: "~{select_first([runtime_override.mem_gb, runtime_default.mem_gb])} GiB"
disks: "local-disk ~{select_first([runtime_override.disk_gb, runtime_default.disk_gb])} HDD"
cpu: select_first([runtime_override.cpu_cores, runtime_default.cpu_cores])
preemptible: select_first([runtime_override.preemptible_tries, runtime_default.preemptible_tries])
maxRetries: select_first([runtime_override.max_retries, runtime_default.max_retries])
docker: sv_pipeline_qc_docker
bootDiskSizeGb: select_first([runtime_override.boot_disk_gb, runtime_default.boot_disk_gb])
}
command <<<
set -eu -o pipefail
# Run benchmarking script
/opt/sv-pipeline/scripts/vcf_qc/compare_callsets_V2.sh
-O ~{vcf_stats}.SENS.bed
~{vcf_stats}
~{comparator}
/opt/sv-pipeline/scripts/vcf_qc/compare_callsets_V2.sh
-O ~{vcf_stats}.SPEC.bed
~{comparator}
~{vcf_stats}
awk '{if ($8=="NO_OVR" && $9=="NO_OVR" && $3-$2>5000) print}'
~{vcf_stats}.SENS.bed
| awk '{if ($5=="DEL" || $5=="DEL_ALU" || $5=="DEL_HERV" || $5=="DEL_LINE1" || $5=="DEL_SVA" || $5=="DUP") print}'
> ~{vcf_stats}.missed.large_cnv.bed
awk '{if ($8=="NO_OVR" && $9=="NO_OVR" && $3-$2>5000) print}'
~{vcf_stats}.SPEC.bed
| awk '{if ($5=="DEL" || $5=="DEL_ALU" || $5=="DEL_HERV" || $5=="DEL_LINE1" || $5=="DEL_SVA" || $5=="DUP") print}'
> ~{vcf_stats}.newUniq.large_cnv.bed
Rscript generate_rdtest_bed.R
-r ~{vcf_stats}.missed.large_cnv.bed
-b  ~{comparator}
-o ~{vcf_stats}.missed.large_cnv.rdtest.bed
Rscript generate_rdtest_bed.R
-r ~{vcf_stats}.newUniq.large_cnv.bed
-b ~{vcf_stats}
-o ~{vcf_stats}.newUniq.large_cnv.rdtest.bed
# Prep outputs

output {
File sens = "~{vcf_stats}.SENS.bed"
File spec = "~{vcf_stats}.SPEC.bed"
File rdtest_missed = "~{vcf_stats}.missed.large_cnv.rdtest.bed"
File rdtest_newunique = "~{vcf_stats}.newUniq.large_cnv.rdtest.bed "
}
}

generate_rdtest_bed.R is used in the code, but I did not find this R script in the latest docker image (gatksv/sv-pipeline-qc:b3af2e3 and epiercehoffman/sv-pipeline-qc:eph_03qc_variables-e597d85). Could anyone provide it?
Thanks.

Thank you for reporting this. I can't seem to find this script in our version history. Interestingly the VcfExternalBenchmark_to_Rdtest doesn't seem to be incorporated in the final tarball and should probably be removed.

Thank you for reporting this. I can't seem to find this script in our version history. Interestingly the VcfExternalBenchmark_to_Rdtest doesn't seem to be incorporated in the final tarball and should probably be removed.

Task is removed


Error in license?

The license specifies the plugin name as rabbitmq-autocluster-consul. I am guessing that the plugin initially only targeted Consul, but has since then integrated with additional services, AWS EC2 as an example.

I don't see any mentions of Consul, or AWS, or specific tools and products.

Neither the name of the rabbitmq-autocluster-consul

I could have created a PR, but the effort for you to accept it is on the same ballpark as you fixing it yourself


Update requirement.txt in flask_react and werkzeug==2.3.7

When flask_demo doesn't work
Reason: werkzeug, which depends on flask, does not yet support version 3.0.0

Updated in another PR


Creation of object at run-time

Is it possible to create an object, like a cube, in which the dimensions are specified by the user with a ROS service or something similar?
In more details, I would like to run several simulations, one after the other, in which I need to specify the position and the dimension of an object at every initialization.
Thanks !

From Python you can use PyMJCF.
From C++ if you want to change sizes you'll need to modify your XML at runtime. We are planning a C++ model creation/modification API, but it is not yet ready.
If you want to change positions you can just write into mjData.qpos for free objects or mjData.mocap_{pos,quat} for mocap bodies (free bodies without dynamics).


AttributeError: 'Buttons' object has no attribute 'redraw'

Describe the bug
AttributeError: 'Buttons' object has no attribute 'redraw'
To Reproduce
Steps to reproduce the behaviour:

While button is pressed, gain +1 Qty.
On hovered show tooltip how much Qty does button have
Update tooltip

Expected behaviour
Update tooltip to see proper number of Quanities.
Tried to use redraw() functions but got Attriibute Error:
Screenshots
Video:
https://streamable.com/iaq9g9
Platform and software (please complete the following information):

OS: Windows 10
Pygame GUI version Newest one.
Pygame version Newest one.

Additional context
Code:
https://pastebin.com/cBSXJEJ4

Updating the tool tips dynamically while hovering them is not a well supported feature right now.
Here is how to do it in a window I think:
def dynamic_tool_tip_set_text(button, new_text):
    button.tool_tip_text = new_text
    if button.tool_tip is not None:
        button.tool_tip.text_block.html_text = button.tool_tip_text
        button.tool_tip.text_block.rebuild()
        button.tool_tip.set_dimensions(button.tool_tip.text_block.rect.size)

Hey, i was working so couldn't check it, but it didnt't work,but figured it somehow alone by button.tool_tip_text = next_text
so i just made something like that:
def update_text(self):
self.cost = float(round(self.cost,2))
self.qty = float(round(self.qty,2))
self.draw.tool_tip_text = 'Cost: {}, Qty: {}'.format(self.cost, self.qty)
and it work as it should, thank u so much 4 ur help. Keep up your good work.
Have a great night! :)


flutter run stuck on starting daemon

this is the output of flutter run -v
[+1111 ms] executing: [D:\flutter\flutter_windows_2.0.1-stable\flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H
[+1056 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[   +8 ms] c5a4b4029c0798f37c4a39b479d7cb75daa7b05c
[   +3 ms] executing: [D:\flutter\flutter_windows_2.0.1-stable\flutter/] git tag --points-at c5a4b4029c0798f37c4a39b479d7cb75daa7b05c
[+1209 ms] Exit code 0 from: git tag --points-at c5a4b4029c0798f37c4a39b479d7cb75daa7b05c
[   +3 ms] 2.0.1
[ +259 ms] executing: [D:\flutter\flutter_windows_2.0.1-stable\flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[ +394 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[   +4 ms] origin/stable
[   +2 ms] executing: [D:\flutter\flutter_windows_2.0.1-stable\flutter/] git ls-remote --get-url origin
[ +223 ms] Exit code 0 from: git ls-remote --get-url origin
[   +3 ms] https://github.com/flutter/flutter.git
[ +603 ms] executing: [D:\flutter\flutter_windows_2.0.1-stable\flutter/] git rev-parse --abbrev-ref HEAD
[ +581 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[   +1 ms] stable
[ +403 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[  +12 ms] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[   +2 ms] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[  +34 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[  +12 ms] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[  +19 ms] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[  +21 ms] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[   +5 ms] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[  +10 ms] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[  +11 ms] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[ +508 ms] executing: D:\Android\SDK\platform-tools\adb.exe devices -l
[ +239 ms] List of devices attached
emulator-5554          device product:sdk_gphone_x86_arm model:sdk_gphone_x86_arm device:generic_x86_arm transport_id:1
[  +64 ms] D:\Android\SDK\platform-tools\adb.exe -s emulator-5554 shell getprop
[ +368 ms] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[   +4 ms] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[  +31 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[  +10 ms] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[  +16 ms] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[  +32 ms] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[  +17 ms] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[  +15 ms] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[  +37 ms] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[ +759 ms] Skipping pub get: version match.
[ +708 ms] Generating D:\Android\AndroidStudioProject\firebase_chatapp\android\app\src\main\java\io\flutter\plugins\GeneratedPluginRegistrant.java
[ +379 ms] ro.hardware = ranchu
[ +189 ms] Using hardware rendering with device sdk gphone x86 arm. If you notice graphics artifacts, consider enabling software rendering with
"--enable-software-rendering".
[ +229 ms] Initializing file store
[ +135 ms] Skipping target: gen_localizations
[ +142 ms] complete
[  +75 ms] Launching lib\main.dart on sdk gphone x86 arm in debug mode...
[  +72 ms] D:\flutter\flutter_windows_2.0.1-stable\flutter\bin\cache\dart-sdk\bin\dart.exe --disable-dart-dev
D:\flutter\flutter_windows_2.0.1-stable\flutter\bin\cache\artifacts\engine\windows-x64\frontend_server.dart.snapshot --sdk-root
D:\flutter\flutter_windows_2.0.1-stable\flutter\bin\cache\artifacts\engine\common\flutter_patched_sdk/ --incremental --target=flutter
--debugger-module-names --experimental-emit-debug-metadata --output-dill
C:\Users\Dalvi\AppData\Local\Temp\flutter_tools.79b44b9\flutter_tool.d7b6502f\app.dill --packages
D:\Android\AndroidStudioProject\firebase_chatapp.dart_tool\package_config.json -Ddart.vm.profile=false -Ddart.vm.product=false --enable-asserts
--track-widget-creation --filesystem-scheme org-dartlang-root --initialize-from-dill build\cache.dill.track.dill
[ +259 ms] executing: D:\Android\SDK\platform-tools\adb.exe -s emulator-5554 shell -x logcat -v time -t 1
[ +130 ms] <- compile package:firebase_chatapp/main.dart
[ +560 ms] --------- beginning of main
03-13 18:51:00.010 D/KeyguardClockSwitch(  662): Updating clock: 6î¸51
[  +36 ms] executing: D:\Android\SDK\platform-tools\adb.exe version
[ +242 ms] Android Debug Bridge version 1.0.41
Version 31.0.0-7110759
Installed as D:\Android\SDK\platform-tools\adb.exe
[  +22 ms] executing: D:\Android\SDK\platform-tools\adb.exe start-server
[ +290 ms] Building APK
[  +94 ms] Running Gradle task 'assembleDebug'...
[  +49 ms] Using gradle from D:\Android\AndroidStudioProject\firebase_chatapp\android\gradlew.bat.
[   +7 ms] D:\Android\AndroidStudioProject\firebase_chatapp\android\gradlew.bat mode: 33279 rwxrwxrwx.
[  +62 ms] executing: D:\Android\Android Studio\jre\bin\java -version
[+2031 ms] Exit code 0 from: D:\Android\Android Studio\jre\bin\java -version
[   +1 ms] openjdk version "1.8.0_242-release"
OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
OpenJDK 64-Bit Server VM (build 25.242-b01, mixed mode)
[   +9 ms] executing: [D:\Android\AndroidStudioProject\firebase_chatapp\android/]
D:\Android\AndroidStudioProject\firebase_chatapp\android\gradlew.bat -Pverbose=true -Ptarget-platform=android-x86
-Ptarget=D:\Android\AndroidStudioProject\firebase_chatapp\lib\main.dart -Ptrack-widget-creation=true -Pfilesystem-scheme=org-dartlang-root
assembleDebug
[+13977 ms] Starting a Gradle Daemon, 786 busy Daemons could not be reused, use --status for details
[+15660 ms] Starting a Gradle Daemon, 787 busy Daemons could not be reused, use --status for details
[+9022 ms] Starting a Gradle Daemon, 788 busy Daemons could not be reused, use --status for details
[+9296 ms] Starting a Gradle Daemon, 789 busy Daemons could not be reused, use --status for details
[+9314 ms] Starting a Gradle Daemon, 790 busy Daemons could not be reused, use --status for details
[+3985 ms] Starting a Gradle Daemon, 791 busy Daemons could not be reused, use --status for details
[+4001 ms] Starting a Gradle Daemon, 792 busy Daemons could not be reused, use --status for details
[+4104 ms] Starting a Gradle Daemon, 793 busy Daemons could not be reused, use --status for details
[+3994 ms] Starting a Gradle Daemon, 794 busy Daemons could not be reused, use --status for details
[+6201 ms] Starting a Gradle Daemon, 795 busy Daemons could not be reused, use --status for details
and Starting a Gradle Daemon, ... busy Daemons could not be reused, use --status for details repeats until the computer crashes

@Abolfazl-11
can you provide your flutter doctor -v and a complete runnable minimal reproducible code sample

@iapicca
output of flutter doctor -v
[√] Flutter (Channel stable, 2.0.1, on Microsoft Windows [Version 10.0.19042.867], locale en-US)
• Flutter version 2.0.1 at D:\flutter\flutter_windows_2.0.1-stable\flutter
• Framework revision c5a4b4029c (10 days ago), 2021-03-04 09:47:48 -0800
• Engine revision 40441def69
• Dart version 2.12.0
[√] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
• Android SDK at D:\Android\SDK
• Platform android-30, build-tools 30.0.2
• ANDROID_SDK_ROOT = D:\Android\SDK
• Java binary at: D:\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
• All Android licenses accepted.
[√] Chrome - develop for the web
• Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe
[√] Android Studio (version 4.1.0)
• Android Studio at D:\Android\Android Studio
• Flutter plugin can be installed from:
https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
[√] Connected device (2 available)
• Chrome (web) • chrome • web-javascript • Google Chrome 89.0.4389.82
• Edge (web)   • edge   • web-javascript • Microsoft Edge 89.0.774.50
• No issues found!

i use AVD but it not connected now

can you provide your flutter doctor -v and a complete runnable minimal reproducible code sample

output of flutter doctor -v
[...]

@Abolfazl-11
can you provide  a complete runnable minimal reproducible code sample as well

i don't know why but i created a new flutter project and it run very good and don't stuck

@iapicca thank you very much for helping me ❤


Fix crash while closing popup from win_execute

let s:w = popup_create('', {})
call win_execute(s:w, printf("normal! :\<C-u>call popup_close(%d)\<CR>", s:w))

Closing popup window self from win_execute always crash.

Hmm, still failing

I realized that this fix was wrong. This should raise an error.

Codecov Report

Merging #5345 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #5345      +/-   ##
==========================================
- Coverage   82.24%   82.24%   -0.01%
==========================================
  Files         134      134
  Lines      147596   147598       +2
==========================================
+ Hits       121395   121396       +1
- Misses      26201    26202       +1

Impacted Files
Coverage Δ

src/popupwin.c
94.5% <100%> (ø)
:arrow_up:

src/gui_beval.c
62.5% <0%> (-0.87%)
:arrow_down:

src/ui.c
72.32% <0%> (-0.09%)
:arrow_down:

src/window.c
88.27% <0%> (-0.04%)
:arrow_down:

src/os_unix.c
63.55% <0%> (ø)
:arrow_up:

src/drawline.c
84.77% <0%> (+0.13%)
:arrow_up:

src/if_xcmdsrv.c
86.35% <0%> (+0.17%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99ebf22...ea9ea07. Read the comment docs.


imp: remove order_matches from ChannelEnd impl

Closes:  #394
Description

Remove the order_matches method, refactor the current usage of order_matches to use match statements instead.

PR author checklist:

[x] Added changelog entry, using unclog.
[x] Linked to GitHub issue.
[ ] Updated code comments and documentation (e.g., docs/).
[x] Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

[ ] Reviewed Files changed in the GitHub PR explorer.
[ ] Manually tested (in case integration/unit/mock tests are absent).

Hi @Farhad-Shabani, please take a look at this PR. Thank you.


Block scrambling - something causes blocks to change shape/texture and function

What you were trying to do
Play.
What actually happened
Blocks became different shapes...
How to reproduce
I can't replicate it reliably and I have no idea what's causing it, but it happens often about every ten hours of gameplay or so. I've booted numerous worlds and it's not always shapes that cause it. Sometimes hitting the wrong thing can cause the scramble...and it usually affects torches but not always.

Step 1
Get into game and do some building. A mine perhaps, spend a few hours.

Step 2
Start getting some shapes of stone blocks and using them.

Step 3
Eventually other items will start changing into stone block shapes or something else will scramble.

Log details and game version
Terasology-init (copy).txt
Terasology-menu (copy).txt
Terasology-Nasuaa (copy).txt
Computer details
It's probably not a computer problem, and I've submitted my computer details in a few other issues.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

I can confirm this happens. Did get the issue a couple of times while trying to get a module going. The blocks that change don't just have the shape or texture changed, but their function as well (had blocks of lava turned into ladders, and climbing them was possible. Placing lava blocks after it happened was just placing ladders.

Thanks for getting an issue on this started @Feralmouse

The blocks that change don't just have the shape or texture changed, but their function as well

Now that's interesting. IIRC past issues like this have been purely texture related (scrambled block tile atlas / interactions somehow?) - I have seen the sea turn into all TNT, but none of it would e click. Same with stuff turning into torches which murdered the framerate but didn't affect lighting. Both of those were long ago though.

Where are block IDs handled?

I had torches turning into oak wood(still produced light) when i placed them against the face of any block which was in a particular direction. Could not reproduce it in any other world, but that world still does it. I had several modules enabled.

Closing this as likely fixed via #2861! Hooray :-)


Create a slack channel to debug #1722

We can duplicate webhooks for indexing and provide the newly created slack channel to debug the issue #1722.

can you add more to the description of this issue? what is the purpose of those logs?

@padms

We can close this, as we are using the same slack channel used for the CI


panlint: Add option to ignore missing inclusion of components/config

Panlint will not issue errors about the missing include for any component in the whitelist.

@stdweird have a look

What's the use case for this?

I find the Component X in use, but component config has not been included errors not really helpful. Especially with metaconfig. It means including a lot of extra lines and it doesn't say anything about including the schema.
So far I've mostly ignored the message but now we have Jenkins that is not happy because of it. This allows a way to get around it.

Additionally, can you add tests for whatever you implement please.

Looking good - can you please squash the commits and amend the commit message of 7c891c0bca4673daf00c596772b596e978d3a99c?

@ned21 good to go

Approved. Do we have a plan to do a new release of panc to include the updated panlint? Or do we just recommend sites use it from HEAD?

Sometime after the next general release yes, but I'd say using it from HEAD is fine too.


sometime links not working

I did some research and this comes from the fact Stack "returns" hide some underlying nodes.
Correction I made into the Stack.prototype.format, where I add path bit by bits instead of the full "return".
I changed
Path(x, y)
	.arc('ne').down(Math.max(0, item.down + Diagram.VERTICAL_SEPARATION - Diagram.ARC_RADIUS*2))
	.arc('es').left(innerWidth)
	.arc('nw').down(Math.max(0, this.items[i+1].up + Diagram.VERTICAL_SEPARATION - Diagram.ARC_RADIUS*2))
	.arc('ws').addTo(this);

With
var temp =y;
Path(x, y).arc('ne').down(Math.max(0, item.down + Diagram.VERTICAL_SEPARATION - Diagram.ARC_RADIUS*2)).addTo(this);
y+=Diagram.ARC_RADIUS+Math.max(0, item.down + Diagram.VERTICAL_SEPARATION - Diagram.ARC_RADIUS*2);
x+=Diagram.ARC_RADIUS;
Path(x, y).arc('es').left(innerWidth).addTo(this);
y+=Diagram.ARC_RADIUS;x=x-innerWidth-Diagram.ARC_RADIUS;;
Path(x, y).arc('nw').down(Math.max(0, this.items[i+1].up + Diagram.VERTICAL_SEPARATION - Diagram.ARC_RADIUS*2)).addTo(this);
y+=Diagram.ARC_RADIUS+Math.max(0, this.items[i+1].up + Diagram.VERTICAL_SEPARATION - Diagram.ARC_RADIUS*2);
x=x-Diagram.ARC_RADIUS;
Path(x, y).arc('ws').addTo(this);
y = temp + Math.max(item.down + Diagram.VERTICAL_SEPARATION, Diagram.ARC_RADIUS*2) + Math.max(this.items[i+1].up + Diagram.VERTICAL_SEPARATION, Diagram.ARC_RADIUS*2);

Sorry for the late review on this!
Can you explain what the original problem was that led you to make this change? I do this sort of single-connected-path all thruout the library without trouble, and I don't immediately see any problem with the older code.

If I can remember, ... long time ago ... Depending upon diagrams, before I made this change, the layout was not that good and links didn't work-- I cannot state what was the problem accurately without making some research! I'll try to make that and let you know.
Thanks for your original work!
I made a 'fork' you can see it here https://github.com/gbrault/railroad-diagrams

Cool! Well, if you ever do recall what the problem was, let me know. ^_^ I'll go ahead and close this issue for now.

Now, if I remeber well, in some conditions, the link (you can click on items) were hidden by the connection edge... But I should go deeper if you want more details...
I experienced that on some complexe grammars (in the sqlite example)


cant cure zombie infection.

Describe the bug
So if you get infected. you just can't heal from it.
To Reproduce
Steps to reproduce the behavior:

Get infected
try the medkit or SCP 500 and doesn't cure you.

Expected behavior
you get cured from it.
Screenshots
[20:28:47] [ERROR] [Exiled.Events] Method "OnHealed" of the class "SCP008X.EventHandlers" caused an exception when handling the event "Exiled.Events.Events+CustomEventHandler1[[Exiled.Events.EventArgs.UsedItemEventArgs, Exiled.Events, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null]]" [20:28:47] [ERROR] [Exiled.Events] System.TypeLoadException: Could not resolve type with token 01000029 (from typeref, class/assembly Exiled.API.Enums.ItemType, Exiled.API, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null)   at Exiled.Events.Extensions.Event.InvokeSafely[T] (Exiled.Events.Events+CustomEventHandler1[TEventArgs] ev, T arg) [0x00024] in :0
is basically what the log says.
Client Build (please complete the following information):

Desktop OS: Windows 10
Version No idea

EXILED Details (please complete the following information):

Version 3.0.0-alpha.70
Plugin Version 3.0.0

Additional context
Add any other context about the problem here.

That TypeLoadExecption indicates a version compatibility mismatch between this plugin, EXILED, and the base game. I'm currently testing an updated build that addresses this issue among others in my developer server.


Implementation of CAN Msg Rx Session

Implemented MessageRxSession
Added intermediate can::TransportDelegate entity:

needed for all sessions to be able reference their parent transport
contains canard related (kinda) mixin logic (like "canard" memory management or errors translation)

Also:

switch to toolshed 22.4.7
disable asserts from "Coverage" build flavor - to not pollute branch coverage

I think my biggest sticking point here is CETL_NODISCARD. I was really hoping to avoid a macro on every single method in this code base.


[DROOLS-1021] Allow to retrieve the KieBase and KieSession models from the KieContainer

+1

The build failed, because adding new method to interface potentially breaks backwards compatibility. Please add these exceptions into https://github.com/droolsjbpm/droolsjbpm-knowledge/blob/master/kie-api/src/build/revapi-config.json


Optimize backend tree loading

I connected https://mosaic-prod-pr-144.herokuapp.com/ to the production database so that we can test the differences in loading time.


How to delete files?

I've mounted my gdrive with plexdrive.
I don't know if it is a problem with plexdrive or not but i cannot delete a file.
I have this error:
rm: cannot remove 'MOVIE_NAME.mkv': Input/output error
Any suggestion?
Tnx

The file system is currently read-only. You cannot delete or insert new files. See #10 for write support.


Fix build break in signing step

Codecov Report

Merging #38 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #38   +/-   ##
=======================================
  Coverage   92.74%   92.74%
=======================================
  Files           7        7
  Lines         262      262
=======================================
  Hits          243      243
  Misses         19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74e55a5...d5ea3e8. Read the comment docs.


add another unique id for upload get error (retrofit.RetrofitError: 500 Internal Server Error)

i want to add another unique id, i tried add some code on ObdReading.java  duplicating the vehicleid code and edit MainActivity.java to match the new code. the application still running well but the upload function return retrofit.RetrofitError: 500 Internal Server Error. can someone help me solve this, or tell me if there any other file i forget to modified. thanks in advance...
sorry for bad english, i'm a student.

@galuhboy123 It's not this project issue. It's yours. Mentioned error means that there is problem on server side. check it via Postman. Anyway, google that error.


After removing energy upgrades, machines retains all energy stored, even if the amount is above the new maxEnergy limit.

This is causing issues with other plug-ins that display a bar graph of stored energy -vs- max energy:
A story in pictures: http://imgur.com/a/VTd7t
Each time an efficiency upgrade is removed from the machine, the code appears to properly adjust the "total available" (max) energy that the machine can hold, but doesn't update the total actual energy that the item is holding.
The energy bar can thus extend all the way across the screen.

Can confirm this issue, exactly the way described.

After cloning the code and testing, I've found that the actual issue is that adding energy upgrades temporarily increases a machine's energy capacity (maxEnergy).  So if you install upgrades, the capacity goes up, and then you can continue to charge the item to get it up to its new capacity.
Once you remove the upgrade, the machine might have a capacity above the new maxEnergy limit.
A discussion should be have whether this is as designed (we don't want to have the user lose the energy they already spent), and, if so, whether we want to report it as the higher value, or report it as the maxEnergy capacity until it goes back below that threshold organically (i.e. we could retain the total stored energy, but report it as Math.min(storedEnergy, maxEnergy)).

If I would design it, I would make it that removing an energy upgrade also decreases the stored energy to the max level. It's like removing a battery, the energy won't stay.

@thommy101 If your battery analogy is true, that would mean that the extra energy is being stored on the upgrades themselves, which means that when they get inserted into a new machine it should instantly get that extra energy, no charging needed.  If that's not how upgrades work, then the energy should stay in the machine.

As a note, TOP was updated to prevent the power bar graph from ever extending beyond the bounds of the graph itself.  That being said, this issue doesn't affect TOP anymore (for which it was originally created), but perhaps a discussion should still be had.

I've changed the mechanic to cap a machine's energy at it's new maximum after an energy upgrade is removed.  Letting the energy sit above it's maximum felt... unclean to me.


plugin add failed in 0.96.1

Error: nu::shell::plugin_failed_to_load

  × Plugin failed to load: Plugin `net` is compiled for nushell version 0.94.2, which is not compatible with version 0.96.1

Ack, fixing...


Glossary : Previous reviewer selected for newly addded glossary

Affected module
UI
Describe the bug
if we create a new glossary, reviewer of the previous glossary is selected by default if we try to add reviewer.
To Reproduce

Navigate to Glossary tab from Settings tab
Add a new glossary
Navigate to the created glossary
Click on add reviewers
The reviewer for the previous glossary is already selected

Expected behavior
The first 10 reviewers list should be displayed
Version:

OpenMetadata version: 0.9.0

Additional context
To reproduce the following issue we only need to add 2 glossaries

@darth-coder00 @Sachin-chaurasiya


LICENSE and Linked to readme.md.

Created LICENSE under MIT license template and linked it with readme.md.

Hi, @frbio I would request you to please resolve the conflict by yourself .

Hi, @frbio I would request you to please resolve the conflict by yourself.

Sure, I have resolved the conflict.


1.0.18 release

dropped py27 support
updated dependencies
updated pytest.ini

Coverage remained the same at 100.0% when pulling 78c476923ab56a6f3071eebe485e44f1280b9645 on develop into b9767195fba74540c385fdf5f94cc4a24bc5e46d on master.


Add complete Python .gitignore

I'm looking into using the project but noticed that when I cloned and setup my virtual environment .venv wasn't included in the .gitignore.
This PR adds the standard Python .gitignore from github.

Thank you for the contribution!


fix gamespy master server query for small list, handle binary response

Hi, the current gamespy master server query have many issues.

It only works if the list is send with more than two packets (1 packet header and more than 1 list packet), it's due to the fact that the content of the first list packet is added after the final packet check for reading all the packet received.
It does not work with servers lists in binary format, there is at least two server list format, the one with the text format \ip\nnn.nnn.nnn.nnn:nnnnn, and the one with the binary format (a simple array of bytes, like the internal qstat master packet list).

For example, currently the following query works (text format, many servers, so more than 2 packets):
qstat -gsm,bfield1942 gsm.qtracker.com

Currently the following query does not work (text format but not enough servers so only 2 packets):
qstat -gsm,rune gsm.qtracker.com

Currently the following query does not work (binary format):
qstat -gsm,mohaa gsm.qtracker.com

So, this PR fixes these two issues and rewrite some part to get a cleaner and safer code:

parse server list that have only two packets (header + list)
parse binary server list
check text server list against complete '\ip' keyword instead of incomplete 'ip' keyword
only allocate memory needed
do not rewrite rawpkt before reading it
check if the header is well formed
check is the text format is well formed
print more debug information

This code was successfully tested against these use cases:
qstat -gsm,bfield1942 gsm.qtracker.com
qstat -gsm,rune gsm.qtracker.com
qstat -gsm,mohaa gsm.qtracker.com
qstat -gsm,rune master.333networks.com:28900
qstat -gsm,ut master.errorist.tk:28900
qstat -gsm,ut master.noccer.de:28900

And some other combinations.

Note: this PR can be merged before others.

Overall for new code blocks please use trailing brace style e.g.
if (condition1 || condition2) {
...
} else {
...
}

Is it really needed since all that will be revamped? I don't like to mix different style in the same block (like a function block), and all this stuff will be rewritten.
However, even if all these feedbacks are annoying, thank you very much for your meticulous review, for sure you read my code considerately. :wink:

If it was all consistent with the existing style I would agree but atm its quite a mixed bag, so at the very least it should be self consistent :)

yeah, that part is one of the worst part (not only style) I ever read in qstat :scream: (one of the other very ugly qstat part is the template code :no_mouth: ), the kind of stuff you'll never accept these days, hopefully. :laughing:

Any intention to address the outstanding comments?

code rebased, revamped and uncrustified

Things done in this PR (see first comment for details):

fix text server support (unsecure protocol)
add support for binary server list (unsecure protocol)

Things not done in this PR:

add secure protocol support

Only unsecure gamespy protocol is supported by qstat, qstat was never able to grok it (that's why XQF used gslist in the past for that task for example) so this part was left untouched, adding support for the secure protocol must be another PR (see gsmsalg.h for a reference implementation).


Getting Started: log created Tesla

Logs the created Tesla to match the surrounding Getting Started examples.

Thanks for fixing this @t3h2mas


TS-6952 update for otp22

There is a Travis issue which blocks rebar3 from getting deps. Nikhil and Travis team are on it. All test cases pass on my computer. Merge now.


resource: automatic determine mirrors for glibc-bootstrap and PyPI resources

[X] Have you followed the guidelines in our Contributing document?
[X] Have you checked to ensure there aren't other open Pull Requests for the same change?
[X] Have you added an explanation of what your changes do and why you'd like us to include them?
[X] Have you written new tests for your changes? Here's an example.

Alternative to #13868.
Resolves Homebrew/glibc-bootstrap#6
Closes #13868

Thanks again @XuehaiPan!

Thanks again @XuehaiPan!


LICENSE

Could you provide the license please?

https://github.com/ember-cli/capture-exit/blob/12a4b8aafbbc0b7605f0fb18a3426c99db14b2df/package.json#L18


Add page increment to navigator horizontal scroll bar

For the navigator horizontal scroll bar, it would be useful to have a way to scroll left or right by one page only, since there is no scroll bar arrow in Linux.
In some applications (e.g. Firefox on Linux) left-clicking on scroll bar background snaps to mouse position while right-clicking on scroll bar background scrolls one page in that direction. This behaviour could be implemented for the navigator.

Fixed by: https://github.com/eclipse-cdt-cloud/timeline-chart/pull/199/commits


Gauge of the wire

I have been trying to use recommended 26mm gauge wire to solder on the seed studio, and having hard time, does anyone suggest better size, that's easy.
What was your experience when you soldered the wires!?

I used 22AWG, worked fine for me. It is very tiny contacts on the back of the chip. I usually apply some alloy on the contacts first, and then solder wires.

FYI https://github.com/BasedHardware/Friend/pull/32

I ended up using 26 gauge recommended wire, I think I mistakenly ordered 18 gauge.


Update POCDijkstra.Tests.csproj

Resolves #ISSUE_NUMBER

Before the change?

After the change?

Pull request checklist

[ ] Tests for the changes have been added (for bug fixes/features)
[ ] Docs have been reviewed and added/updated if needed (for bug fixes/features)

Does this introduce a breaking change?

[ ] Yes
[ ] No

Description by Korbit AI

[!NOTE]
This feature is in early access. You can enable or disable it in the Korbit Console.

What change is being made?
Update the target framework of the POCDijkstra.Tests project from netcoreapp3.1 to net8.0.
Why are these changes being made?
This change is necessary to ensure compatibility with the latest .NET features and improvements, and to maintain alignment with the main project which has also been updated to .NET 8.0. This update will help leverage performance enhancements and new APIs available in .NET 8.0.

Summary by CodeRabbit

New Features

Upgraded the application and testing frameworks to .NET 8.0, providing access to enhanced features and improved performance.

Bug Fixes

Resolved potential compatibility issues related to libraries and dependencies due to the framework upgrade.

:x: Build POC-dotnet-Dijkstra 1.0.203 failed (commit https://github.com/GuilhermeStracini/POC-dotnet-Dijkstra/commit/10a520e569 by @guibranco)

:x: Build POC-dotnet-Dijkstra 1.0.206 failed (commit https://github.com/GuilhermeStracini/POC-dotnet-Dijkstra/commit/788dfaa964 by @guibranco)

:x: Build POC-dotnet-Dijkstra 1.0.208 failed (commit https://github.com/GuilhermeStracini/POC-dotnet-Dijkstra/commit/b971c44d7b by @guibranco)


Include license files in typed-builder-macro crate

Both the Apache-2.0 and MIT licenses require that (re)distributed sources contain a copy of the original license text. As of right now, the sources published and redistributed via crates.io for the typed-builder-macro crate do not contain license texts.
This PR adds symbolic links that point at the license texts in the project's root directory, which is enough for "cargo package" / "cargo publish" to resolve and include them when publishing to crates.io in most circumstances (unless you're running the "cargo publish" command on Windows, AFAIK).

Any reason not to just copy the files? It's not like they are going to change...

Any reason not to just copy the files? It's not like they are going to change...

Not really. Looking at other projects where multiple crates are published from the same repo, using symbolic links just seems to be the standard practice.


getProductDetailsArray fails for dotted product id

Hi,
I have the following method to get several products' details at once: (_open is just a utility method to assure that InAppBilling close and open are called properly.)
export async function getProductDetails (productIds: Array<string>) : any {
  let products
  try {
    await _open()
    products = await InAppBilling.getProductDetailsArray(productIds)
  } catch (err) {
    Sentry.captureException(new Error(err))
  } finally {
    await InAppBilling.close()
  }
  return products
}

These work:
getProductDetails(['my.product'])
getProductDetails(['other_product'])
getProductDetails(['my_product', 'other_product'])

But for the following calls return only 'other_product's details:
getProductDetails(['my.product', 'other_product'])
getProductDetails(['other_product', 'my.product'])

It works, just testing over a real device is not enough. First I had to publish a new version at least in the alpha channel, grab the product using the Play signed apk, and it works since then.


Fixes for version 3.3.2

This pull request fix the following problems:

Login form was broken, due to label and input interpreted as inline boxes
New « jump to project » box was broken
Name changes in admin-menu

Hi, thank you for your contribution!
I generally like those changes, but I cannot accept this PR as-is because it's breaking compatibility with previous versions of Redmine.
I should be able to take a closer look at this soon, I'll what I can do to accept your changes while keeping older code as well.

Hi, sorry for being a bit late in my answer. Effectively I replace some class by their new name (especially for the admin-menu commit). If you would have preferred me to rewrite it, I could have done it. Do you want me to do a second PR, which introduces back the old admin-menu classes?
I think my changes for the login box and the new project selector should not impact old redmine versions.
Thank very much for having accepted my work :)

Hi,
I actually had some time so I accepted your PR and made few amends to keep it backwards compatible. Also I added few improvements :smile: See 3d8889b2
Thanks and enjoy!


update go version in Dockerfile

executables build from go 1.16 builder
but docker still uses go 1.13 builder

Thanks!


Enhancement: add pageHeight to response when generating multi-page output

Possible bug
Is this a possible bug in a feature of sharp, unrelated to installation?

[x] Running npm install sharp completes without error.
[x] Running node -e "require('sharp')" completes without error.

If you cannot confirm both of these, please open an installation issue instead.
Are you using the latest version of sharp?

[x] I am using the latest version of sharp as reported by npm view sharp dist-tags.latest.

If you cannot confirm this, please upgrade to the latest version and try again before opening an issue.
If you are using another package which depends on a version of sharp that is not the latest, please open an issue against that package instead.
What is the output of running npx envinfo --binaries --system --npmPackages=sharp --npmGlobalPackages=sharp?

  System:
    OS: Windows 10 10.0.22000
    CPU: (8) x64 Intel(R) Core(TM) i7-9700K CPU @ 3.60GHz
    Memory: 7.28 GB / 15.87 GB
  Binaries:
    Node: 16.14.2 - C:\Program Files\nodejs\node.EXE
    npm: 8.5.0 - C:\Program Files\nodejs\npm.CMD
  npmPackages:
    sharp: ^0.31.1 => 0.31.1

What are the steps to reproduce?

see code example
What is the expected behaviour?

Please see the code example, can I get the height consistent
Please provide a minimal, standalone code sample, without other dependencies, that demonstrates this problem

const sharp = `require("sharp");`

sharp("./1.gif").toFile("./2.gif").then((info) => console.log(info));
// output:
// {
//     format: 'gif',
//     width: 550,
//     height: 400,
//     channels: 3,
//     premultiplied: false,
//     size: 14314
// }

sharp("./1.gif", { animated: true }).toFile("./3.gif").then((info) => console.log(info));
// output:
// {
//     format: 'gif',
//     width: 550,
//     height: 7200,
//     channels: 3,
//     premultiplied: false,
//     size: 562959
// }

Please provide sample image(s) that help explain this problem

We should add pageHeight to the info response object when generating multi-page/animated output, to match the naming/behaviour of metadata(). I suspect also adding pages for the page count would be useful too.
https://sharp.pixelplumbing.com/api-input#metadata

Thank you, metadata() temporarily solved my problem, still looking forward to info.pageHeight, I wish you a happy day

v0.33.5 now available with pageHeight and pages properties.


Read server port value from env vars

Currently we do
app.run(port=8080)

Instead we should read the port from an environment variables and use a default value (e.g. 8080) if the env var is not set. Consider creating a config object to store configuration.

Also add database parameter to this configure based on the use of env vars
Consider abstracting the code / configuration in flask-app so that it work with any SQL DB. If this is possible, then there should be not mention of "PostgreSQL" in the folder flask-app, only reference to "SQL".


Use correct andromeda background color

The correct background color of sonokai andromeda is: #2b2d3a as seen here
I just realized it when comparing it to the alacritty terminal theme implementation.

Thanks!


The devil wears prada

Add option to use copilot.lua and the accompanying cmp sources.
@abzcoding Made sure that the cmp source is only loaded when the plugin is being used.
Fixes #35

Shit works now. xD Turns out my username is not abz xD

Perhaps you should add some notes about having to first use sell your soul with just active, log into GitHub, and then use prada = active ?

Perhaps you should add some notes about having to first use sell your soul with just active, log into GitHub, and then use prada = active ?

yeah i will eventually


[New analyzer] SA1143 Use implicitly assignable foreach variable type

Port of PR from roslyn analyzers: https://github.com/dotnet/roslyn-analyzers/issues/4479
Fixes: #3307

This analyzer reports on unobvious explicit conversion done under the hood by foreach loop. This conversion can result in runtime exception, but it's not guaranteed.

Could you please help me port original PR? Right now it cannot find following types:
IForEachLoopOperation, IVariableDeclaratorOperation, CommonConversion, Compilation.ClassifyCommonConversion(), WellKnownTypeProvider
Also AnalyzeLoop doesn't get invoked when I run the tests for some reason.

Closing per https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/3307#issuecomment-785952062
@maxkoshevoi it looks like you've done quite a lot of work to implement this rule, only to find it doesn't into any of the well-known analyzer packages. My suggestion would be to create a brand new project in your own GitHub account, implement the rule the rule there, and publish your own NuGet package with it. Users who wish to use this rule can then install your package directly (multiple analyzer packages can be installed in a single project without interfering with each other).


Serverless worker - db adapter

Hey, thanks for creating conveyor-mq, the code looks super clean.
I'm looking for a job queue that can run on serverless infra (lambda).
I planned to use dynamodb first as redis serverless is quite expensive, do you know if that'd be hard to have some sort of db adapter here we could change the backend (as celery does)?
Also, have you tried implementing the worker with serverless infra or have any recommendation?

Hey, thanks for creating conveyor-mq, the code looks super clean.

Hey :) thanks for your kind words.

I'm looking for a job queue that can run on serverless infra (lambda).
I planned to use dynamodb first as redis serverless is quite expensive, do you know if that'd be hard to have some sort of db adapter here we could change the backend (as celery does)?

It shouldn't be too difficult to implement adapters for different backends for Conveyor, although I'm afraid I don't have the time for such work at the moment.

Also, have you tried implementing the worker with serverless infra or have any recommendation?

I have not, I'm afraid I don't have any other recommendations at the moment.


Feature/async client

This adds asynchronous support to the Python SDK of the "Tavily" project, by adding a separate Async Client and leveraging the HTTPX async HTTP request python package.
This PR solves Issue 13

@assafelovic do you have plans to merge?

Thanks @bluzir this is great!


This Is Issue 26

This Is Issue 26
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688290779815959

Proposal
This is test proposal for https://expensify.slack.com/archives/C049HHMV9SM/p1688290779815959

Proposal
This is test proposal for https://expensify.slack.com/archives/C049HHMV9SM/p1688290779815959


Apply threshold & change number of retrieved images

currently, any search query shows by default the top 5 matches regardless of the similarity score.
Implement a thresholding mechanism to filter out similarity scores below a certain value, ensuring that only relevant results are displayed,
Noting that each case (and each model) might have different optimal threshold we need t explore them
# server.py
def search_clip_text(text, image_collection):
...
    # change this 5 to another number (maybe add it in `config.yaml`)
    results = image_collection.query(text_embedding, n_results=5)
    # apply threshold (differes for each task & each model)

def search_clip_image(image_path, image_collection, get_self=False):
#same
def search_embed_text(text, text_collection):
#same

maybe use a strategy similar to top_p or min_p where the number of results depends on the similarity score of the most similar result, here's a quick explanation:
https://www.reddit.com/r/LocalLLaMA/comments/17vonjo/your_settings_are_probably_hurting_your_model_why/
great work btw!


Welcome page background color

Welcome page's background is always set to editor background, while welcome page foreground colors depend on the theme (dark foreground for light theme, light foreground for dark theme). This makes welcome page unreadable in case that you have dark editor background with light theme. The same problem happens for extension documentation page.
Would it be possible to add a setting for welcome page background (it can also apply to extension documentation page and other embedded web pages)? To maintain background compatibility, it can default to editor background when not set.
Examples:

I'd be happy to take a look into this 👍

@audoralc Yes, should be a small change from what I see. Next to and similar to the button colors here: https://github.com/Microsoft/vscode/blob/d1571770ce9f6fdb98e8ee19d7711498a35bfdd0/src/vs/workbench/parts/welcome/page/electron-browser/welcomePage.ts#L590

@audoralc have you already started on this or can i take this up?

@defaults I have already started


RealmSwift Migration

Udemy I use to study now,but the Migration problem was occuted so I didn't gain forward

Closing as insufficient information provided.


OnStart function not visable from Login Screen

Hi was having some trouble in that I cant see the OnStart function on the Login screen, however when I clicked on the app above login screen I could see and amend the list of admin users.
Looks a great app to hit the ground running.
John

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 879fd196-a46f-9f5d-f33b-b5ae9db14b58
Version Independent ID: 67642cb3-92aa-9340-0dff-3786d0672779
Content: Install and configure the Help Desk sample for canvas apps - PowerApps
Content Source: powerapps-docs/maker/canvas-apps/help-desk-install.md
Service: powerapps
GitHub Login: @mr-dang-msft
Microsoft Alias: brdang

Hi John
Thank you for reporting this issue. We found that there's error in the doc. Instead of saying "Select the LoginScreen", it should say "Select the App", then you will see OnStart. We are working on updating the doc and the screenshot accordingly.
Best,
Yijun

Hello,
This is really a perfect application just tried works perfectly, only want to ask one question is it possible when a ticket is created and assigned to a user can it be displayed in that user when he/she starts using it.
Like a user login as a helpdesk user and creates a ticket then administrator assigns that ticket to staff to work on it that users should receive notification in application that he has assigned task.
Kind Regards,
Naveed.

Hi Naveed,
If you want to send the assignee a notification upon assignment of a ticket, you can add a formula to the Create and Update buttons to let it send out email to the assignee using the existing Office365User connector (https://docs.microsoft.com/en-us/connectors/office365users/#user).
Thanks,
Yijun

Hi Yijun,
Thanks for the response, to send a notification to the assignee is already there, what actually i am looking for let me explain:
Once a user creates a ticket and administrator assigns to a staff, the assign staff should be able to see the assigned ticket in his user, like we shared the application to the user he/she installs the power app in the device and provide office365 credentials to login to start using the application once they go ticket view screen they should see there assigned tickets but in the current scenario it's not there. Please see below the scenario:
User A creates ticket
Administrator assigns the ticket to<EMAIL_ADDRESS><EMAIL_ADDRESS>user login in powerapp by providing office365 account ticket should be available as assigned in second step by administrator.
Any help on this will be highly appreciated.
Thanks in advance for your help.
Kind Regards,
Naveed.

Hi Naveed,
Did you have a shared SharePoint list or common storage for those tickets? The information from 1 person to another needs to be sync'd from a common data source somehow based on your scenario.
Thanks,
Yijun

Hi Yijun,
It's a shared point list.
Kind Regards,
Naveed.

Hi Naveed,
In "MyTicketScreen" -> "MyTicketsScreenGallery", the formula for Items is:
If(isAdmin,Sort(TicketList,Id,Descending),Sort(Filter(TicketList,Author = MyProfile.Mail ),Id,Descending))
where "TicketList" is a local Collection
And based on the app's OnStart rule:
ClearCollect(TicketList,{Id:1,Title:"Fix Mouse",Description:"That is my cat!!!",Category:"Laptop/PC equipment issue",PercentComplete:"0.9",Priority:"HIGH",AssignedTO:"THOMAS ANDERSEN",TaskStatus:"COMPLETED",Author:"ScottK@contoso.com",Editor:"Scott Konersmann",Created:"2/8/2018 3:29 PM",Modified:"2/5/2018 3:29 PM"},{Id:2,Title:"Replace keyboard", Description:"Please do it ASAP",Category:"Laptop/PC equipment issue",PercentComplete:"0.8",Priority:"LOW",AssignedTO:"YVONNE MCKAY",TaskStatus:"IN PROGRESS",Author:"PATRICK SANDS",Editor:"THOMAS ANDERSEN",Created:"2/5/2018 3:29 PM",Modified:"2/5/2018 3:29 PM"});
Have you made the TicketList to get the data from your SharePoint list where the tickets information are stored, instead of using the hard-coded list from the sample app itself?

Thanks,
Yijun

Hi Yijun,
Yes the ticket list is getting populated from the share point list, I didn't change anything in the code yet, trying to understand in which line of code I should make the changes so that the assigned staff should only be able to see his/her tickets only.
Thanks
Naveed

Hi Naveed,
You can change the code in the OnStart to have "TicketList" to get records from SharePoint list directly:
ClearCollect(TicketList, _**"here are records from your SharePoint list"**_)

Here is the doc for using ClearCollect: https://docs.microsoft.com/en-us/powerapps/maker/canvas-apps/functions/function-clear-collect-clearcollect

Thanks,
Yijun

Hi Yijun,
This is the example to amend the record and update it, the records are already coming when I assign them as administrator I think I should design one more screen for the normal users to see there assigned tickets because on current scenarios only administrator can see the tickets and also for all users there is no segregation between the users. Please advise.
Thanks,
Naveed

Hi Naveed,
"MyTicketScreen" -> "MyTicketScreenGallery" has an explicit rule:
If(isAdmin,Sort(TicketList,Id,Descending),Sort(Filter(TicketList,Author = MyProfile.Mail ),Id,Descending))

It means if the user is not an admin, the user will only see his/her own ticket.
Thanks,
Yijun

Hi Yijun,
Thanks for the quick responses, let me work on this, I will get back with update.
Thanks for your time and great help.
Naveed.

Just did a quick experiement on the Items formula for "MyTicketScreenGallery"
If(isAdmin,Sort(TicketList,Id,Descending),Sort(Filter(TicketList,AssignedTO = MyProfile.DisplayName ),Id,Descending))
Hope it could help you trouble shoot. :)

Hi Yijun,
Currently, this is the formula on "MyTicketScreenGallery"
If(isAdmin,Sort(AllTickets,Created,Descending),Sort(Filter(AllTickets,Author.Email = MyProfile.Mail || Author.Claims = MyProfile.UserPrincipalName ),Created,Descending))
Could you please guide me which changes need to be done, because when i make changes i am getting errors.
Thanks

When I was playing with the sample, I realize the ticket should show when the name is matching the AssignedTo, instead of the Author.
I am not sure how your schema is on the SPO list, but I only changed from
Sort(Filter(TicketList,Author = MyProfile.Mail )
to
Sort(Filter(TicketList,AssignedTO = MyProfile.DisplayName )
in the formula

Hi Yijun,
Thanks for the great help you out me in right direction to fix formula i have figured it out after modifying the formula as below.
If(isAdmin,Sort(AllTickets,Created,Descending),Sort(Filter(AllTickets,AssignedTo.Email = MyProfile.Mail || Author.Claims = MyProfile.UserPrincipalName ),Created,Descending))
Once again thanks for your valuable time and help.
Kind Regards,
Naveed

Hi Naveed,
Great to hear your problem is solved!
Cheers,
Yijun

One more thing, on the "EditTicketFormScreen" can we give right to a user who has assigned for the ticket to update the status field and take back ticket deletion right ?
Thanks,
Naveed

I have figured out as well the deletion as well just only need guide to give non administrator user right for updating the status and percentage.
Thanks,
Naveed

Hi I am having difficulty on the sample help desk I got most of it working but there are key areas that I need help with
1 when I create a help desk ticket on the app it doesn't stay on the app when I log out
2 I have two Ipads to test the app on and when I create a ticket as a staff on a staff ipad on the admin Ipad I can't see the ticket (although it has successfully emailed me the ticket)
3 the sharepoint is not being used as a collection for the ticketlist how do I do that?

ClearCollect(TicketList, "here are records from your SharePoint list")

how to add the sharepoint list?


[Work in Progress] Updating the documentation with latest updates on APIs

Thank you for contributing to Microsoft Fabric documentation
Fill out these items before submitting your pull request:
If you are working internally at Microsoft:
Provide a link to an Azure DevOps Boards work item that tracks this feature/update.

Who is your primary Skilling team contact? @mention them individually tag them and let them review the PR before signing off.

For internal Microsoft contributors, check off these quality control items as you go

[ ] 1. Check the Acrolinx report: Make sure your Acrolinx Total score is above 80 minimum (higher is better) and with no spelling issues. Acrolinx ensures we are providing consistent terminology and using an appropriate voice and tone, and helps with localization.

[ ] 2. Successful build with no warnings or suggestions: Review the build status to make sure all files are green (Succeeded).

[ ] 3. Preview the pages:: Click each Preview URL link to view the rendered HTML pages on the review.learn.microsoft.com site to check the formatting and alignment of the page. Scan the page for overall formatting, and look at the parts you edited in detail.

[ ] 4. Check the Table of Contents: If you are adding a new markdown file, make sure it is linked from the table of contents.

[ ] 5. #sign-off to request PR review and merge: Once the pull request is finalized and ready to be merged, indicate so by typing #sign-off in a new comment in the Pull Request. If you need to cancel that sign-off, type #hold-off instead. Signing off means the document can be published at any time. Note, this is a formatting and standards review, not a technical review.

Merge and publish

After you #sign-off, there is a separate PR Review team that will review the PR and describe any necessary feedback before merging.
The review team will use the comments section in the PR to provide feedback if changes are needed. Address any blocking issues and sign off again to request another review.
Once all feedback is resolved, you can #sign-off again. The PR Review team reviews and merges the pull request into the specified branch (usually the main branch or a release- branch).
From the main branch, the change is merged into the live branch several times a day to publish it to the public learn.microsoft.com site.

@mberdugo
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@jainr, I am unable to edit this file. Can you please fix the two broken links by putting a slash (/) in front of them. Then I'll be happy to approve and sigh off.

I can't seem to edit this file. Can the review team please just put a slash in front of the two broken links. That should fix them.
#sign-off

#sign-off


Fix cert-exporter alerting

Before adding a new alerting rule into this repository you should consider creating an SLO rules instead.
SLO helps you both increase the quality of your monitoring and reduce the alert noise.

How to create a SLO rule: https://github.com/giantswarm/sloth-rules#how-to-create-a-slo
Documentation: https://intranet.giantswarm.io/docs/monitoring/slo-alerting/

Towards: https://github.com/giantswarm/...
This PR ensures that cert-exporter alerts page everywhere because it's deployed on all providers
Checklist

[x] Update CHANGELOG.md
[ ] Add Unit tests
[ ] Follow Alert structure
[ ] Consider creating a dashboard (guidelines) (if it does not exist already) to help oncallers monitor the status of the issue.
[ ] Request review from oncall area, as well as team (e.g: oncall-kaas-cloud GitHub group).

I think it was because it was not installed in the past but it is now.
I'm reviewing alerts for multi-provider MCs but this one is a bit gray so no parent issues :(


Shallow nested resource results in 404 for create route of parent

Laravel Version: 7.3.0
PHP Version: 7.3.12
Database Driver & Version:

Description:
I create a route resource for Announcements, it worked fine. then I created a nested resource for group announcements and it worked too. but I noticed that if I create shallow nesting, the announcement create page results in 404
Here is my routes list:

everything is fine except that if go to announcements/create it gives a 404,
if I create nested resource without shallow, everything works fine
Steps To Reproduce:

Hey there,
Can you first please try one of the support channels below? If you can actually identify this as a bug, feel free to report back and I'll gladly help you out and re-open this issue.

Laracasts Forums
Laravel.io Forums
StackOverflow
Discord
Larachat
IRC

Thanks!

Hello @driesvints , thank you for your attention, yes I acknowledge this as a possible bug, I just did not posted this for the support here as I find this as a bug so I'll be glad if you can check this out :)


chore: Enable MD033 for tables

Looks like all the table HTML has been converted to Markdown

#sign-off


chore: scope notations from category theory.

Make sure in particular one can import Mathlib.Tactic for teaching without getting category theory notations in scope. Note that only two files needed an extra open.

See Zulip conversation.

Could you do the same for the notations in CategoryTheory.Functor.Basic?

Good point, I'll work on this.

The functor notations are now also scoped. This required a bit more fixing in random files.


[VkBridge] Feature to generate feed using VK API

TODO: write instructions to generate token in Russian and English
TODO: ask SlackCoyote's permission to relicense to UNLICENSE since original code is on MIT
TODO: test on my public instance

Fixes https://github.com/RSS-Bridge/rss-bridge/issues/2878

Currently this PR is deployed on my https://feed.eugenemolotov.ru

Just payed attention, that it runs only one check. It is expected to run at least Lint check, that is definately going to fail.

If I understand correctly, your pr now requires the bridge to be configured with a private access token?

Also, I think the checks didnt run because there are merge conflicts. Can you resolve those?

If I understand correctly, your pr now requires the bridge to be configured with a private access token?

It remains optional.

Instead of returning empty feed (like in https://github.com/RSS-Bridge/rss-bridge/issues/2878), bridge will throw "302 Found" error.
When instance admin will see this error, it expected that he will start using private access token.

Marked as draft, because PR is not ready yet. There are TODOs to resolve.

is there any progress here @em92

This PR stopped being relevant. VK does not report 429 for now.


Added health check facade

Addresses #5
@tylerwoonton would you be able to take a look at this when you get a sec?
Would also like your opinion on what the correct behaviour would be if they pass in a check that doesn't exist, for example
if (HealthCheck::passes('gibberish')

Currently, it just returns false

@Gman98ish Will take a look now. I'd expect it to return false if it didn't pass, so that sounds good.

@Gman98ish I'm in two minds about the expected behaviour.
I think it might be useful for it to return false if the check exists but fails, and throw an exception CheckNotFoundException or something of the sort if it doesn't exist.
I think as an end-user, I'd want to know if it couldn't find my check vs the check failing.

Thanks for the review @tylerwoonton I'll do the changes this evening

No problem @Gman98ish - tag me and I'll review it later tonight.
I'm going to PR the CacheHealthCheck this evening anyway.


Article on minimum in Binary Search Tree

🚀 Feature
I would like to add an article for finding minimum element in BST
Have you read the Contributing Guidelines on Pull Requests?
(Yes)

Please assign me this issue sir @HarshCasper @iamrajiv @ankitaggarwal23 @atarax665 @gat786


 This is established with pull request #14386 from @Vitallium.
[x] Use system-installed QtWebKit. Also part of the above pull request. Ideally of course this is using the latest QtWebKit (see annulen/webkit project from @annulen).
Compared to vanilla QtWebKit of Qt 5.x, this latest QtWebKit enables lots of new modern web platform features, check Comparison with QtWebKit 5.6 for more details.

Packaging

[x] Remove build.py. It won't work anymore with the two above changes. Consequently, building PhantomJS will be similar to building any other Qt-based projects (qmake && make).
We may need to supply a simple configure script and a convenient make install to make packaging easier for the distribution packagers (Debian/Ubuntu/Fedora/Nix/Homebrew/NuGet/etc). See qconf for details.
[ ] #14459: Recreate static build packaging. A single executable with virtually no dependency is what makes PhantomJS very popular. This is also important to support installer wrapper such as npm's phantomjs-prebuilt for Node.js, phantomjs gem for Ruby, etc.

Features
We need to ensure that the Linux version can still operate in pure headless mode (without X11).
Regression: it won't be possible to disable web security.
#14461: Regression: there won't be support for printing headers & footers.

@annulen Is there any news on a distribution packager's willingness to make an official package of QtWebKit TP2 (or later releases)? How about Homebrew @MikeMcQuaid?
This becomes important as it will ensure that a future distribution-packaged PhantomJS does not deviate (get "crippled") regarding its feature sets. For instance, if a distribution contains a PhantomJS 2.5 release built using the outdated Qt 5.2 and its QtWebKit module, it will potentially confuse the users since it will not support all the latest web platform features.

Reference issue: https://github.com/annulen/webkit/issues/115

Any plan to port phantomjs to Qt Webengine , since now Qt WebKit will not see new features ?

@ariya I think it's even more important to ensure that crippled versions are not distributed at all, so users don't get confused and go straight to official release binaries.

@moimael Read the topic plz

@moimael Check this post. In all cases, feel free to start a separate discussion (this issue is focusing on our 2.5 effort).

@annulen Is there any news on a distribution packager's willingness to make an official package of QtWebKit TP2 (or later releases)? How about Homebrew @MikeMcQuaid?

@ariya We'll package it when it's a stable version but are open to having a PR open at any point.

This becomes important as it will ensure that a future distribution-packaged PhantomJS does not deviate (get "crippled") regarding its feature sets. For instance, if a distribution contains a PhantomJS 2.5 release built using the outdated Qt 5.2 and its QtWebKit module, it will potentially confuse the users since it will not support all the latest web platform features.

From a packagers perspective the best way around this would be to check for such things in your configure/CMakeLists.txt/qmake and refuse to build if you're using an outdated version. Similarly, you could consider bumping PhantomJS' version when new Qt 5 releases come out with bumped requirements to note the minimum features that are required.

I don't think it's always possible to prevent a modified/tweaked/crippled version of PhantomJS: take a look at Debian package https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=817277.
Not having a bundled Qt/QtWebKit certainly will simplify the packager's life. That said, it won't help much if the available system Qt/QtWebKit is still outdated.

In Debian Stable you'll always have QtWebKit version, outdated by a couple of years

In other distros (except rolling-release ones) it may be slightly less outdated, but not much
https://blogs.gnome.org/mcatanzaro/2016/02/01/on-webkit-security-updates/

I don't think it's always possible to prevent a modified/tweaked/crippled version of PhantomJS: take a look at Debian package https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=817277.

Sure. Some package managers (i.e. Homebrew) frown on patching, though, so if you want to require a certain version of a dependency the best way to do that is to ensure you do so in your build system.

@annulen That package (https://packages.debian.org/sid/web/phantomjs) is intended for stretch. But you're right, in the near future it will be the next Debian stable.

if you want to require a certain version of a dependency the best way to do that is to ensure you do so in your build system.

Solid advice! Thank you.

@ariya QtWebKit requires somewhat more work to be suitable for shipping in Stretch than just to be usable by PhantomJS, work is in progress

Why no support for printing footer and header ?

Why no support for printing footer and header ?

Please track #14461.

Quick question, giving that build.py is removed now how do we build at the moment?

@samlinbris Check the description, i.e. "Consequently, building PhantomJS...".

@ariya Yeah, I've seen that bit. As I'm relatively new to this field I don't really know how qmake works. I've downloaded qmake and made it available on my mac. However, I'm not sure what's the next step after this. Surely it's not `qmake deploy/build-and-package.sh'

@samlinbris See if you can familiarize yourself with Qt and/or consult a Qt expert.

Hi, i just created a new pull request (https://github.com/ariya/phantomjs/pull/14505), i rearranged build.py and i'm able to build phantomjs with new webkit. With this approach it is not needed to install qt in the system.
Let me know

Thanks @matteoceraico, but we're not planning to go back to that route. The plan is to treat PhantomJS as a normal Qt application and building it with the system-installed Qt and QtWebKit.

I wouldn't recommend using "normal" Qt installation for static builds where you want to throw away everything unnecessary (from both Qt and WebKit), so you still need some kind of build recipe.
For example, testing environment of QtWebKit now uses jhbuild modules which build Qt, Qt's dependencies and WebKit dependencies in an automatic way, applying patches when necessary. You may want to use something like that instead of simple script.

we're not planning to go back to that route. The plan is to treat PhantomJS as a normal Qt application and building it with the system-installed Qt and QtWebKit.

@ariya If I understand correctly, it will be less maintenance for keeping  PhantomJS up to date with a modern QtWebKit right? (as it will use the system's one)

Hi @ariya  - could you please explain "Regression: it won't be possible to disable web security."
What is it about the upcoming 2.5 release that would not allow for disabling web security?  Would a work around be possible?
Thank you.

@samir-mahendra Don't worry. It will possible.

Current ldd output:
        linux-vdso.so.1 =>  (0x00007ffcebbba000)
        libfreetype.so.6 => /usr/lib/x86_64-linux-gnu/libfreetype.so.6 (0x00007f73a8e78000)
        libjpeg.so.8 => /usr/lib/x86_64-linux-gnu/libjpeg.so.8 (0x00007f73a8c18000)
        libpng12.so.0 => /lib/x86_64-linux-gnu/libpng12.so.0 (0x00007f73a89f0000)
        libssl.so.1.0.0 => /lib/x86_64-linux-gnu/libssl.so.1.0.0 (0x00007f73a8780000)
        libcrypto.so.1.0.0 => /lib/x86_64-linux-gnu/libcrypto.so.1.0.0 (0x00007f73a8338000)
        libz.so.1 => /lib/x86_64-linux-gnu/libz.so.1 (0x00007f73a8118000)
        libicui18n.so.55 => /usr/lib/x86_64-linux-gnu/libicui18n.so.55 (0x00007f73a7cb0000)
        libicuuc.so.55 => /usr/lib/x86_64-linux-gnu/libicuuc.so.55 (0x00007f73a7918000)
        libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007f73a7710000)
        librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007f73a7508000)
        libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f73a72e8000)
        libxml2.so.2 => /usr/lib/x86_64-linux-gnu/libxml2.so.2 (0x00007f73a6f28000)
        libxslt.so.1 => /usr/lib/x86_64-linux-gnu/libxslt.so.1 (0x00007f73a6ce8000)
        libhyphen.so.0 => /usr/lib/x86_64-linux-gnu/libhyphen.so.0 (0x00007f73a6ae0000)
        libwebp.so.5 => /usr/lib/x86_64-linux-gnu/libwebp.so.5 (0x00007f73a6880000)
        libstdc++.so.6 => /usr/lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007f73a64f8000)
        libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007f73a61e8000)
        libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007f73a5fd0000)
        libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f73a5c00000)
        /lib64/ld-linux-x86-64.so.2 (0x00005556fc041000)
        libicudata.so.55 => /usr/lib/x86_64-linux-gnu/libicudata.so.55 (0x00007f73a4148000)
        liblzma.so.5 => /lib/x86_64-linux-gnu/liblzma.so.5 (0x00007f73a3f20000)

/cc @ariya

i love you so much bro

https://groups.google.com/forum/#!topic/phantomjs/AefOuwkgBh0

2.5.0 download page here : https://bitbucket.org/ariya/phantomjs/downloads

Sure - but that only has the binaries of the v2.5 release for Linux and
macOS.  The download repository link looks like a snapshot for some old
code.  I am looking for the source code, not binaries.
Cheers,
-pete
On Fri, Jan 13, 2017 at 12:22 PM, Norbert de Langen <
<EMAIL_ADDRESS>wrote:

2.5.0 download page here : https://bitbucket.org/ariya/phantomjs/downloads
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ariya/phantomjs/issues/14458#issuecomment-272538508,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AH-D0wHR4DXU3DRO6E2RmTaHkMByjlAnks5rR90bgaJpZM4Jew0u
.

--
pete wright
www.nycbug.org
@nomadlogicLA

@Vitallium Ah great, the new beta works fine for me on Windows, although it fails when running it on CentOS (Redhat based), as already discussed on the forum.
A few questions:

Do you think there is going to be a version that's dynamically linked, so it can work over multiple distros? If so, any ETA?
If not, are you going to distribute prebuilt binaries for other distros (like CentOS)?
Again, if not, can we build it ourselves? If so, where do the sources for the 2.5 release reside?

Hope to hear from you soon!
Thanks in advance and keep up the good work!

For future reference; i've moved to using Chrome in Docker (https://gist.github.com/addyosmani/5336747). At the moment it's not completely headless yet, but their working on it (https://chromium.googlesource.com/chromium/src/+/lkgr/headless/README.md).
I don't want to talk down PhantomJS, because it's great in its own purpose.
Unfortunately it doesn't keep up with the latest browser features and graphic rendering, making it less convenient to use in cases where exact rendering is needed (as it was in my case).
I'm still hoping PhantomJS 2.5 will be released as a stable version, because it still rocks in running unit tests that need some kind of DOM 👍

Is 2.5 development taking place in some public repository that we can download? Or could you maybe release 2.5beta for Ubuntu Yakkety?
Thanks!

@ktecho it seems that you can build 2.5 yourself.

For Ubuntu binaries you need to install some dependencies:
png
jpeg
webp
openssl
zlib
fontconfig and freetype
libicu
source: https://groups.google.com/forum/#!topic/phantomjs/AefOuwkgBh0

See comment above.

No. If you look at the next comment, it's me pointing out that 2.5 sources
are not to be found.
2017-04-11 18:12 GMT+02:00 Jon Ege Ronnenberg<EMAIL_ADDRESS>
@ktecho https://github.com/ktecho it seems that you can build 2.5
yourself.
For Ubuntu binaries you need to install some dependencies:
png
jpeg
webp
openssl
zlib
fontconfig and freetype
libicu
source: https://groups.google.com/forum/#!topic/phantomjs/AefOuwkgBh0
See comment <#m_-2266175595424881957_issuecomment-272538508> above.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ariya/phantomjs/issues/14458#issuecomment-293314115,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAhZYXlfybA7RwN5YZdfa06S6Uxg8xGYks5ru6ZhgaJpZM4Jew0u
.

@ktecho In the google groups announcement there is a link to https://github.com/ariya/phantomjs/issues/14835 which links to build instructions for 2.5: https://gist.github.com/Vitallium/f84664eb2d71a4dd91e7e5f1bd8c915e
I can only assume that the 2.5 source code is in the master branch of this repo.
Vitallium fork is up to date with this repo: https://github.com/ariya/phantomjs/compare/master...Vitallium:master

Yes, that's correct. Current master branch contains 2.5 version. But remember you need this QtWebKit version - https://github.com/annulen/webkit

Thanks Jon and Vitaly,
Couldn't find it when I give a look into it. Thanks a lot for pointing me
to the correct place with the solution.
It has been difficult to compile QT and start compiling qtwebkit. Lots of
libraries missing (just installed with apt) and lots of problems. The last
one which I couldn't resolve is this one:
[ 43%] Building CXX object
Source/WebCore/CMakeFiles/WebCore.dir/platform/graphics/texmap/TextureMapper.cpp.o
In file included from
/home/ktecho/webkit/webkit-qtwebkit-stable/Source/WTF/wtf/StdLibExtras.h:32:0,
from
/home/ktecho/webkit/webkit-qtwebkit-stable/Source/WTF/wtf/FastMalloc.h:26,
from
/home/ktecho/webkit/webkit-qtwebkit-stable/Source/WebCore/config.h:75,
from
/home/ktecho/webkit/webkit-qtwebkit-stable/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:20:
/home/ktecho/webkit/webkit-qtwebkit-stable/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
In member function â€˜void
WebCore::GraphicsLayerTextureMapper::updateBackingStoreIfNeeded()â€™:
/home/ktecho/webkit/webkit-qtwebkit-stable/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:549:78:
error: â€˜dynamic_castâ€™ not permitted with -fno-rtti
*
ASSERT(dynamic_cast<TextureMapperTiledBackingStore*>(m_backingStore.get()));*
*
^*
/home/ktecho/webkit/webkit-qtwebkit-stable/Source/WTF/wtf/Assertions.h:250:11:
note: in definition of macro â€˜ASSERTâ€™

if (!(assertion)) { \*
     ^~~~~~~~~

Source/WebCore/CMakeFiles/WebCore.dir/build.make:36888: fallo en las
instrucciones para el objetivo
'Source/WebCore/CMakeFiles/WebCore.dir/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp.o'
Cheers,
Luis Miguel García Mancebo
2017-04-11 18:31 GMT+02:00 Vitaly Slobodin<EMAIL_ADDRESS>
Yes, that's correct. Current master branch contains 2.5 version. But
remember you need this QtWebKit version - https://github.com/annulen/
webkit
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ariya/phantomjs/issues/14458#issuecomment-293319468,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAhZYcc16tmjMYtGe1ZFQgDr7zSGtVKdks5ru6rEgaJpZM4Jew0u
.

You are missing -DCMAKE_BUILD_TYPE=Release. (I think I should make it default, I didn't because someone told me it's a bad practice, btw WebKitGTK doesn't do it either)

Thanks a lot for your reply, Konstantin.
Unfortunately, it doesn't work even when your flag added. I'm compiling
with this line right now based on Vitaly's github:
./Tools/Scripts/build-webkit --qt --release --makeargs=-j2
--no-device-orientation --no-web-audio --no-video --no-video-track
--no-touch-events --no-touch-slider --no-geolocation --64-bit
--cmakeargs="-Wno-dev -DCMAKE_PREFIX_PATH=/home/ktecho/qtbase-build
-DQT_INSTALL_PREFIX=/home/ktecho/qtbase-build
-DQMAKE_EXECUTABLE=/home/ktecho/qtbase-build/bin/qmake
-DENABLE_NETSCAPE_PLUGIN_API=OFF -DUSE_GSTREAMER=OFF
-DUSE_THIN_ARCHIVES=OFF -DENABLE_API_TESTS=OFF -DENABLE_TEST_SUPPORT=OFFi
-DCMAKE_BUILD_TYPE=Release"
The problem is the same, I think:
[ 29%] Building CXX object
Source/WebCore/CMakeFiles/WebCore.dir/platform/graphics/texmap/TextureMapperBackingStore.cpp.o
In file included from
/home/ktecho/webkit/webkit-qtwebkit-stable/Source/WTF/wtf/StdLibExtras.h:32:0,
from
/home/ktecho/webkit/webkit-qtwebkit-stable/Source/WTF/wtf/FastMalloc.h:26,
from
/home/ktecho/webkit/webkit-qtwebkit-stable/Source/WebCore/config.h:75,
from
/home/ktecho/webkit/webkit-qtwebkit-stable/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:20:
/home/ktecho/webkit/webkit-qtwebkit-stable/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
In member function â€˜void
WebCore::GraphicsLayerTextureMapper::updateBackingStoreIfNeeded()â€™:
/home/ktecho/webkit/webkit-qtwebkit-stable/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:549:78:
error: â€˜dynamic_castâ€™ not permitted with -fno-rtti
ASSERT(dynamic_cast<TextureMapperTiledBackingStore*>(m_backingStore.get()));
^
/home/ktecho/webkit/webkit-qtwebkit-stable/Source/WTF/wtf/Assertions.h:250:11:
note: in definition of macro â€˜ASSERTâ€™
if (!(assertion)) {
^~~~~~~~~
Source/WebCore/CMakeFiles/WebCore.dir/build.make:36888: fallo en las
instrucciones para el objetivo
'Source/WebCore/CMakeFiles/WebCore.dir/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp.o'
Cheers,
Luis Miguel García Mancebo
2017-04-13 10:48 GMT+02:00 Konstantin Tokarev<EMAIL_ADDRESS>
You are missing -DCMAKE_BUILD_TYPE=Release. (I think I should make it
default, I didn't because someone told me it's a bad practice, btw
WebKitGTK doesn't do it either)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ariya/phantomjs/issues/14458#issuecomment-293830707,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAhZYStSDMWdma3PiUbP8TloMoBOinR1ks5rveFjgaJpZM4Jew0u
.

ok, you have --release already so you don't need -DCMAKE_BUILD_TYPE=Release
-DQT_INSTALL_PREFIX and -DQMAKE_EXECUTABLE are not used
Please try building it from scratch after removing WebKitBuild directory

Hi Konstantin,
I added that -DQT_INSTALL_PREFIX and -DQMAKE_EXECUTABLE because it didn't
work with the default QT from Ubuntu, so I compiled QT5.8 just before
compiling webkit. The -DQMAKE_EXECUTABLE is needed because Ubuntu Yakkety
doesn't have qt5-qmake (or was it qmake-qt5?).
EDIT: I just re-downloaded the webkit from your github repo and now it
works with the "Configure and build WebKit" line from Vitaly's github. It
seems you changed something two days ago, but I don't know if it's because
of that. It's compiling again right now. Will report back in hours as this
is a very slow test machine.
Thanks,
Luis Miguel García Mancebo
2017-04-13 12:04 GMT+02:00 Konstantin Tokarev<EMAIL_ADDRESS>
ok, you have --release already so you don't need -DCMAKE_BUILD_TYPE=Release
-DQT_INSTALL_PREFIX and -DQMAKE_EXECUTABLE are not used
Please try building it from scratch after removing WebKitBuild directory
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ariya/phantomjs/issues/14458#issuecomment-293847540,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAhZYaB1C8XWKqad6qtk1OnyNrEvyKfGks5rvfMvgaJpZM4Jew0u
.

Wow... compiling QT in Ubuntu is a mess. Just a few things to help others with some problems I found:
1- In QT 5.8 -no-gtkstyle is no longer supported:  ERROR: Unknown command line option -no-gtkstyle.
2- Using -fontconfig -system-freetype don't find the libraries in Ubuntu Yakkety even when they're installed. I just removed both modifiers.
3- Compilation fails with a wayland related problem, even when I specified -skip wayland modifier:
/usr/bin/ld.gold: error: cannot find -lqwayland-generic
4- It doesn't honor -nomake tools modifier, because my compile is failing trying to compile qttools:
make[3]: Entering directory '/home/ktecho/qt-everywhere-opensource-src-5.8.0/qttools/src/qtdiag'
linking ../../bin/qtdiag
/usr/bin/ld.gold: error: cannot find -lqwayland-generic
collect2: error: ld returned 1 exit status
Makefile:83: recipe for target '../../bin/qtdiag' failed
make[3]: *** [../../bin/qtdiag] Error 1

It seems like it's a known problem since Jan/13: https://bugreports.qt.io/browse/QTBUG-28909
In my very-slow test server (same Ubuntu Yakketi), QT5.8 has compiled ok (¿?), but compiling qtwebkit is taking ages. Will report back.

You can use official Qt 5.8.0 binaries and Linux binaries of QtWebKit from https://github.com/annulen/webkit/releases/tag/qtwebkit-tp5

@annulen Thanks a lot for the help. The process is a bit harsh for someone who has never made anything with QT.
For anyone using Ubuntu Yakketi, a version not supported by 2.5beta binaries provided by Vitaly, the best option is to download @nkovacs static binary from here, that works fine:   https://github.com/nkovacs/selenium-standalone-phantomjs/tree/11420aaf2174428b56086673232365c820f98a42

Hi @ariya are there plans to continue with phantomjs after @Vitallium has stepped down?
Or is it really dead in the water now?
Headless chrome seems to use a lot more CPU resources, so want to stick with phantomjs for now.
I have been doing some work on a fix to phantomjs 2.1.1 but not sure if it's worth me making a pull request.

hi. Where is the 2.5.0 version of the code.

@344389541 It's in master.

When are you gonna release the 2.5.0 version?

@victorhazbun @Vitallium is releasing the 2.5 beta v2 this weekend. :)

@Vitallium I know you've relased beta 2 for windows. Do you know when we can get the updated beta binaries for linux please?

Can somebody please tell me how I can get source code for PhantomJS 2.5? The comments above say that it's there in the master, so is there any specific tag associated with it? I was expecting it to be v2.5 etc., but I am not sure. I want to evaluate 2.5 code along with system installed Qt. Any definitive help in this regard is much appreciated! Thanks.

2.5 is not out yet. The latest is 2.5beta2. If you want the master branch, click the green "Clone or download" on https://github.com/ariya/phantomjs and choose ZIP. There is apparently no tag.

Correct! We tag release after it has been published.

Thank you very much! I have cloned the master locally. Am I correct in
assuming that build procedure is exactly the same as v2.1? Or are there any
differences?
Best regards,
Atul.
On Tue, Jul 25, 2017 at 8:26 PM, Vitaly Slobodin<EMAIL_ADDRESS>wrote:

Correct! We tag release after it has been published.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ariya/phantomjs/issues/14458#issuecomment-317764376,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AK9wbzttWke8Ry8z60fygBdkwS-y4u-qks5sRgI6gaJpZM4Jew0u
.

@sowani Almost. First of all you need to build new QtWebKit - https://github.com/annulen/webkit/wiki
After that, you can build PJS as usual.

Any news about the header/footer "issue" in the coming release? Will it be possible to print headers and footers in PDF documents? :)

@clarkk Feature would be welcome in QtWebKit if someone prepared a pull request to https://github.com/annulen/webkit with all necessary parts from PhantomJS' fork

@dawesi

Medium.com has declared this project dead

Someone on their Medium.com page has declared this project dead...
Otherwise, Facebook.com, Twitter.com, etc declare a lot of things :P

@tuxayo Good to hear your comment! So does that imply that phantomjs has a new maintainer and a defined roadmap?

Any plan for version > 2.1.1 is effectively abandoned. Please see #15344 for more details.


Fix extract_struct_from_enum_variant not updating record references

Related to #6510

Mixed it up with how visibility works since children can always see their parents.
bors r+


iOS call dies in background after about ~15 seconds

Android seems fine but iOS lasts for around 15 seconds and the call dies, do I need to add something like react native callkeep to keep the app alive or should the app stay alive by itself on iOS?

Ok never mind, I just tested a release build on iOS and it seems to stay awake forever so I guess this isn't really an issue

Hi @moulie415,
You would just need to add voip, inside the UIBackgroundModes. You can see more details about this inside our Readme.
But other than that, all should be good, and the app must keep working in the background.
I will close this issue, feel free to reopen in case the above solution doesn't work and you are able to reproduce it.

I see. I will try to reproduce this with a debug build and see if I can find out anything from Apple reporting this behavior.
Thanks for letting us know about this @moulie415 .


Cookie Popup

Hi Team,
I need cookie popup on the TLC website for every new visitor.

@2016DigiTech I'd recommend signing up with one of the various 3rd party consent management services:
https://www.google.com/search?q=consent+management+service
Typically the integration is as simple as including a script tag in delayed.js.


Publish to open-vsx.org registry

In addition to the VS Code Marketplace, it would be good to publish the extension to the Open VSX registry. A Vendor Neutral, Open Source Marketplace for VS Code Extensions. Used by VS Code compatible editors.
The publishing process is documented in https://github.com/eclipse/openvsx/wiki/Publishing-Extensions

Hey @choutos  - better late than never! https://open-vsx.org/extension/AquaSecurityOfficial/trivy-vulnerability-scanner


xiaozhu Dev

add content that distinction os type

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.:white_check_mark: zhuzhih2017:white_check_mark: xiaozhu36:x: shuwei-yinYou have signed the CLA already but the status is still pending? Let us recheck it.