Allow to search for files with no file extension

I propose using a dot (.) to mean no extension, when using -fe or --file-extension:
countfiles.py --fe .
countfiles.py --file-extension .
The above lines would list files like .gitignore, Pipfile.

I agree, we must do it. The parser does not process this parameter. But the user can search for files without an extension.

By the way, can we ask potential users their opinion on the actual parser functionality?
(something add, change, optimize). For example, in the Python Сommunity

Asking for feedback or even some user testing to help spot issues not found during development is fine. I wouldn’t start a chat room at this time for a project like this, though. I prefer to keep the discussion of features and bugs inside the issues section on GutHub. That way we have everything in one place.
But I see no problem in asking also informally in social media and then open issues for relevant suggestions and bugs mentioned elsewhere.

Hello, the split ext should do the work fine.
I sent you the https://ybin.me/p/6056cb919b7ac01d#6TUJO4V8Zwcwg7fuL+g8znLANqG0SQCvKxlh5hll94w= pastebin on linkedin.
Here your code is doing too much :
https://github.com/victordomingos/Count-files/blob/master/countfiles/utils/file_handlers.py#L11
you should use your helper to return the extension and let upper function decide if they process or not files with falsee extensions.

@cgte Nice work, very concise code, with a very different approach. I just think that it's not as readable (at least from my perspective). Having said that, my code is in fact needing a global cleanup. ;-)
You are right about get_file_extension() doing too much. I just needed to write a has_extension()function that could very well be replaced by a slightly simpler get_file_extension(). I will have to merge those two functions soon.

@cgte, I think I get your point. My intention with has_extension() was to enable slightly shorter and more readable expressions (like in if clauses), but it was more of a quick way for me to better understand what I was writing in the upper function. I have meanwhile merged those two functions (has_extension() and get_file_extension()) into a single get_file_extension() that returns an empty (falsy) string when there is no extension.
Since we are not using a class for single files, I am not sure if you could/should make it a property.
I will be thankful if you could take another look and see the changes I made in this respect. Any further suggestions for improvement are always welcome.


IPC with Vite / svelte-kit

Hello!  Thanks for such a great template! 🚀
I cannot seem to get interprocess communication working.  Now that remote has been depreciated, in a project I have using Vue/webpack everything is converted to IPC.  All good.
At first I thought it may be because of using an older version of this template, but persists after scaffolding a new project.
Possibly related issue vite-electron-builder #189
How can I get IPC to work with Svelte-Kit?  Here is an error I am getting:
[svelte] 2:21:17 PM [vite] Error when evaluating SSR module /Users/redacted/Developer/redacted-dev/redacted/src/routes/__layout.svelte:
[svelte] TypeError: Cannot create proxy with a non-object as target or handler
[svelte]     at nodeRequire (/Users/redacted/Developer/redacted-dev/redacted/node_modules/vite/dist/node/chunks/dep-e9a16784.js:68214:12)
[svelte]     at ssrImport (/Users/redacted/Developer/redacted-dev/redacted/node_modules/vite/dist/node/chunks/dep-e9a16784.js:68164:20)
[svelte]     at eval (/Users/redacted/Developer/redacted-dev/redacted/src/routes/__layout.svelte:9:31)
[svelte]     at instantiateModule (/Users/redacted/Developer/redacted-dev/redacted/node_modules/vite/dist/node/chunks/dep-e9a16784.js:68197:166)
[svelte] Cannot create proxy with a non-object as target or handler
[svelte] TypeError: Cannot create proxy with a non-object as target or handler

I have not yet changed the webPreferences object from the template default.
webPreferences: {
  enableRemoteModule: true,
  contextIsolation: true,
  nodeIntegration: true,
  spellcheck: false,
  devTools: dev,
}

WebPrefs in my other project for comparison:
const webPrefs = {
    nodeIntegration: false,
    enableRemoteModule: false,
    contextIsolation: false
 }

Is the issue with the main process or renderer?
if I pass
// electron.cjs
mainWindow.webContents.send('my-channel', 'message')
…

in renderer (say in __layout.svelte):
import { ipcRenderer } from 'electron'

ipcRenderer.on('my-channel', (event, message) => {
  console.log(message) // Prints 'message'
})

Then I get the error mentioned above.  Thanks for any insight and if this is beyond the scope of the template project then please accept my apologies.

Hey @bjbk, sorry for the delay, I've had limited time to look into this.  It appears it may be related to a few vite related issues.  Have you made any progress on this?  I can take a closer look now that I've freed up a bit.  I agree this is pretty important and would be great to solve for others who may face the problem.

Thanks for looking into it.  Again, this is a great template and just keeps getting better! 😄
No progress on it yet.  I agree, seems to be a Vite issue so probably not an issue with Sveltekit-electron in itself.  If I find a solution I'll be sure to update this issue. Cheers!

getting __dirname is not defined in the renderer when importing ipcRenderer

Seems in order to set contextIsolaton to false, one needs a preload script.  https://www.electronjs.org/docs/api/context-bridge#contextbridge
Getting closer to a solution

Getting closer.  This seems to work, I can send to main but having trouble receiving.  Probably just my mis-application of Svelte.  (Used to Vue, but loving Svelte!)
// preload.cjs

const { contextBridge, ipcRenderer } = require('electron')

contextBridge.exposeInMainWorld(
  'api', {
  send: (channel, data) => {
    ipcRenderer.send(channel, data)
  },
  sendSync: (channel, data) => {
    ipcRenderer.sendSync(channel, data)
  },
  receive: (channel, func) => {
    ipcRenderer.on(channel, (event, ...args) => func(...args))
  }

Main process:
// electron.cjs

…
ipcMain.on('to-main', (event, args) => {
  return mainWindow.webContents.send('from-main', 'hi from main');
})
…

in Svelte component:
<script>
  window.api.receive('from-main', (data) => {
    return `Received ${data} from main process`;
  });

  const handleClick = () => {
    window.api.send('to-main', 'a message');
  }
</script>

https://stackoverflow.com/a/59888788/4727183

@FractalHQ if this seems to be the answer, I'll go ahead and close the issue.

[ ]  #14


Dbeaver crash at launch

Hi,
Since Mojave installation, DBeaver crash at launch w/ blank Eclipse SDK window.
My conf:

Mac OS X: 10.14
java.version=1.8.0_191
DBeaver 5.2.3

log file (extract):
!SESSION 2018-11-05 14:34:19.102 -----------------------------------------------
eclipse.buildId=unknown
java.version=1.8.0_191
java.vendor=Oracle Corporation
BootLoader constants: OS=macosx, ARCH=x86_64, WS=cocoa, NL=fr_FR
Framework arguments:  -keyring /Users/ylepors/.eclipse_keyring
Command-line arguments:  -os macosx -ws cocoa -arch x86_64 -keyring /Users/ylepors/.eclipse_keyring
!ENTRY org.eclipse.ui.workbench 4 2 2018-11-05 14:34:21.847
!MESSAGE Problems occurred when invoking code from plug-in: "org.eclipse.ui.workbench".
!STACK 0
java.lang.NullPointerException
at org.eclipse.swt.widgets.Control.internal_new_GC(Control.java:2180)
at org.eclipse.swt.graphics.GC.(GC.java:177)
at org.eclipse.swt.graphics.GC.(GC.java:138)
at org.eclipse.jface.wizard.ProgressMonitorPart.initialize(ProgressMonitorPart.java:244)
at org.eclipse.jface.wizard.ProgressMonitorPart.(ProgressMonitorPart.java:141)
at org.eclipse.jface.wizard.ProgressMonitorPart.(ProgressMonitorPart.java:106)
at org.eclipse.ui.splash.BasicSplashHandler$AbsolutePositionProgressMonitorPart.(BasicSplashHandler.java:53)
at org.eclipse.ui.splash.BasicSplashHandler.getBundleProgressMonitor(BasicSplashHandler.java:141)
at org.jkiss.dbeaver.core.application.DBeaverSplashHandler.init(DBeaverSplashHandler.java:69)
at org.eclipse.ui.internal.Workbench$2.run(Workbench.java:833)
at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:45)
at org.eclipse.ui.internal.Workbench.createSplashWrapper(Workbench.java:849)
at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:600)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:339)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:563)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:151)
at org.jkiss.dbeaver.core.application.DBeaverApplication.start(DBeaverApplication.java:156)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:199)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:137)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:107)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:391)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:246)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:659)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:595)
at org.eclipse.equinox.launcher.Main.run(Main.java:1501)
!ENTRY org.eclipse.ui 4 0 2018-11-05 14:34:21.851
!MESSAGE Could not instantiate splash
!STACK 0
java.lang.NullPointerException
at org.eclipse.swt.widgets.Control.internal_new_GC(Control.java:2180)
at org.eclipse.swt.graphics.GC.(GC.java:177)
at org.eclipse.swt.graphics.GC.(GC.java:138)
at org.eclipse.jface.wizard.ProgressMonitorPart.initialize(ProgressMonitorPart.java:244)
at org.eclipse.jface.wizard.ProgressMonitorPart.(ProgressMonitorPart.java:141)
at org.eclipse.jface.wizard.ProgressMonitorPart.(ProgressMonitorPart.java:106)
at org.eclipse.ui.splash.BasicSplashHandler$AbsolutePositionProgressMonitorPart.(BasicSplashHandler.java:53)
at org.eclipse.ui.splash.BasicSplashHandler.getBundleProgressMonitor(BasicSplashHandler.java:141)
at org.jkiss.dbeaver.core.application.DBeaverSplashHandler.init(DBeaverSplashHandler.java:69)
at org.eclipse.ui.internal.Workbench$2.run(Workbench.java:833)
at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:45)
at org.eclipse.ui.internal.Workbench.createSplashWrapper(Workbench.java:849)
at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:600)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:339)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:563)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:151)
at org.jkiss.dbeaver.core.application.DBeaverApplication.start(DBeaverApplication.java:156)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:199)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:137)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:107)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:391)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:246)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:659)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:595)
at org.eclipse.equinox.launcher.Main.run(Main.java:1501)
[...]
It seems that this type of problem was solved in previous versions of DBeaver, but none of the proposed resolutions I tested worked.
Thanks,
Yves

Can't reproduce. However it is clearly a bug in splashscreen handler.
You could try to remove line -showsplash from dbeaver.ini.

Hi Serge.
Done in /Applications/DBeaver.app/Contents/Eclipse/dbeaver.ini, which is now:
-startup
../Eclipse/plugins/org.eclipse.equinox.launcher_1.5.100.v20180827-1352.jar
--launcher.library
../Eclipse/plugins/org.eclipse.equinox.launcher.cocoa.macosx.x86_64_1.1.800.v20180827-1352
-vmargs
-XX:+IgnoreUnrecognizedVMOptions
--add-modules=ALL-SYSTEM
-Xms64m
-Xmx1024m
-XstartOnFirstThread
The splashscreen is still displayed and the same error occurs.

Ok, thanks for checking this.
Could you try to remove file ~/.dbeaver4/.metadata/.plugins/org.eclipse.e4.workbench/workbench.xmi then? It keeps UI configurations. Maybe it become corrupted after version upgrade.

Done. Still same behaviour:

splashscreen
blank window Eclipse SDK
log file indicates same error

Ok, then something else is guilty.
I see that your Java version differs from the Java bndled in pkg.
How do you install DBeaver? DMG, zip, or thru some 3rd party package manager?
Could you try to install using PKG (download it from dbeaver.io or GitHub)?

This is weird (I can't reproduce this on two Macs with Mojave).
Anyhow - please test this on the Early Access version (https://dbeaver.io/files/ea/) - it contains the fix of splash screen handler.

Hello Serge.
Done with both releases (DMG and PKG).
Same behavior: crash at launch after the splashscreen, now no empty or blank window.
You will find attached the debug log files for both releases.
debug log.zip

Oops, the archive is password protected

Oops, sorry.
Debug log.zip

Apparently I've made a mistake during Early Access publishing (it is still old). Could you test the latest one (https://dbeaver.io/files/ea/)

Same :/
debug log-20181106-1454.zip

This is a bug in Eclipse: https://bugs.eclipse.org/bugs/show_bug.cgi?id=540357
I hope they'll find a solution in near days.
This error happens because DBeaver tries to switch to Dark theme (I assume that you using Mojave with dark theme).
Please try this workaround: add line -nosplash in dbeaver.ini (before -vmargs line).

I have modified the dbeaver.ini as you suggested (-nospash parameter)
Much better, I have now a clean Eclipse window but I cannot create a new connection and database driver manager is empty (as .dbeaver-driver folder).
Still have NullPointerException
dbeaver-debug.log

I am experiencing the same issue.  Upgraded to Mojave and suddenly DBeaver no longer works.  Upon start, I see the following as normal...

However, after this loads, I see the menu bar options, but the actual editor windows do not open...

Tried adding -nosplash to DBeaver.ini, but that didn't do anything.

@lalato could you also post debug and error logs?

@lalato could you also post debug and error logs?

Edited original post with debug log

Just tried the trick of holding down the Ctrl key during launch.  This seems to be working for me.

@lalato thanks for details.

Just tried the trick of holding down the Ctrl key during launch. This seems to be working for me.

Wow. That's unusual. Thanks a lot for the information :)

Just tried the trick of holding down the Ctrl key during launch. This seems to be working for me.

Hold down control worked for me. That was weird. Besides, the -nosplash option worked for 5.2.4 but not for 5.2.5. I am using Windows with the new dark theme. I think that is the same issue.

Solved the issue for me:
My problem was that I also installed Java11 in the mean time.
I do not know if I ever really shut down dbeaver since installation.
I did the macos latest updates inbetween and it failed as well. Only showing the splash screen and then quitting with a reference to some log file.
Since I installed Java11 inbetween and that probably installed itself as the main java version on the os I told dbeaver to use the java8 vm:
/Applications/DBeaver.app/Contents/Eclipse/dbeaver.ini
-vm
/Library/Java/JavaVirtualMachines/jdk1.8.0_144.jdk/Contents/Home/bin/java
-startup
../Eclipse/plugins/org.eclipse.equinox.launcher_1.4.0.v20161219-1356.jar
--launcher.library
../Eclipse/plugins/org.eclipse.equinox.launcher.cocoa.macosx.x86_64_1.1.550.v20170928-1359
-showsplash
-vmargs
--add-modules=ALL-SYSTEM
-Duser.language=en
-Xms64m
-Xmx1024m
-XstartOnFirstThread

I only did add the first two lines with -vm and /Library/Java/... to the existing file.
!!! Do place it in two lines otherwise eclipse won't properly start with that setting as I understood.

Thank you for the info @greyshine

Solved the issue for me:
My problem was that I also installed Java11 in the mean time.
I do not know if I ever really shut down dbeaver since installation.
I did the macos latest updates inbetween and it now failed as well. Only showing the splash screen and then quitting with a reference to some log file.
Since I installed Java11 in between and that probably installed itself as the main java version on the OS I told dbeaver to use the java8 vm:
/Applications/DBeaver.app/Contents/Eclipse/dbeaver.ini
-vm
/Library/Java/JavaVirtualMachines/jdk1.8.0_144.jdk/Contents/Home/bin/java
-startup
../Eclipse/plugins/org.eclipse.equinox.launcher_1.4.0.v20161219-1356.jar
--launcher.library
../Eclipse/plugins/org.eclipse.equinox.launcher.cocoa.macosx.x86_64_1.1.550.v20170928-1359
-showsplash
-vmargs
--add-modules=ALL-SYSTEM
-Duser.language=en
-Xms64m
-Xmx1024m
-XstartOnFirstThread

I only did add the first two lines with -vm and /Library/Java/... to the existing file.
!!! Do place it in two lines otherwise eclipse won't properly start with that setting as I understood.

@greshyine s method works. I can confirm it.


Adding 'timeBased=true' query paramater to metering URL

As we are reporting time based usage to MaaS, we need to add above query parameter to metering URL.

Pull Request Test Coverage Report for Build 2877

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 90.073%

Totals

Change from base Build 2874:
0.02%

Covered Lines:
9104

Relevant Lines:
9772

💛  - Coveralls


Adding script to fix ID mismatch issue

The script aims to resolve ID mismatch issue for a user across all sites in the tenant.

Have you registered for the PnP Recognition program, your submission will qualify for a badge :-)
Its opt in so please register here: https://pnp.github.io/recognitionprogram

Hey @Barbarur, thank you 👏 for your sample - it is highly appreciated. This should be live shortly 😊
Have you registered for the PnP Recognition program, your submission will qualify for a badge :-)
Its opt in so please register here: https://pnp.github.io/recognitionprogram


Change BracesFixer to avoid indenting PHP inline braces

See @junstyle's original PR here: #3781.
This is a small change that allows for inline <?php tags without forcing indentation for opening braces. This is especially useful when mixing HTML with PHP. Here's an example of inline PHP that can cause issues:

    <?php foreach ($posts as $post) { ?>

<?php echo esc_html($post->post_title); ?>

        <?php if ($post->post_status === 'active') { ?>
        <?php esc_html_e('Live'); ?>
        <?php } ?>

    <?php } ?>

After running php-cs-fixer:

    <?php foreach ($posts as $post) {
    ?>

<?php echo esc_html($post->post_title); ?>

        <?php if ('active' === $post->post_status) {
        ?>
        <?php esc_html_e('Live'); ?>
        <?php
    } ?>

    <?php
} ?>

The current behavior, which forces braces onto the next line, adds a lot of whitespace and can reduce readability. This is especially evident in larger documents with deeply nested PHP as demonstrated in the linked PR from @junstyle. The fix in my PR is based on @junstyle's original changes, with the addition of test fixes and a new test for the behavior.
This is my first time contributing to this project, so please let me know if I'm missing anything. Thank you!

Hi and thank you for this PR,
Templating like mixing html and PHP leads to interesting formatting challenges and we typically do not try to resolve all of these in this project. However, you fix seems small and clean, so if this helps people out than I'm :+1:

Thank you @alecgeatches.

@SpacePossum Thank you for rebasing on 2.12 and merging! When would you expect that this change will be available for release builds?

Hi!
I can't make releases so I go ping some people to check :)

Hello, is this feature already released ?
Will it be implemented as a default behavior or a custom rule ?
Thx

Hi @AgamlaRage
The fix has been merged, but no official release have been made since than.
When we do the releases the change will be in all releases and will be the new default behavior (it is not optional/configurable)


Handle failing promises in the example

fixes #5
NOTE: this is not fixing the Invalid URL error, i.e.
╭─phra at kali in /home/phra/git/h2url (master ✚1…2)
╰─λ node example.js                                                                                0 < 00:04:13
(node:13761) ExperimentalWarning: The http2 module is an experimental API.
{ TypeError [ERR_INVALID_URL]: Invalid URL: undefined
    at onParseError (internal/url.js:219:17)
    at parse (internal/url.js:228:3)
    at new URL (internal/url.js:311:5)
    at Object.request (/home/phra/git/h2url/index.js:13:15)
    at streaming (/home/phra/git/h2url/example.js:18:37)
    at Object.<anonymous> (/home/phra/git/h2url/example.js:32:1)
    at Module._compile (module.js:612:30)
    at Object.Module._extensions..js (module.js:623:10)
    at Module.load (module.js:531:32)
    at tryModuleLoad (module.js:494:12) input: 'undefined' }

I think the correct approach for this is to use https://github.com/mcollina/h2url/blob/master/h2url.js#L3. It fixes the problem at the root by crashing on unhandled rejection.
Can you update your PR?

since it's only supporting nodejs and not browsers i will do it. :+1:
ps: i use the await-to pattern as universal pattern for my frontend and backend code because:

it's isomorphic
it's enforcing an explicit catch or escalate error handling that imho really improve the quality and the legibility of the code (ok, maybe not the performance :sweat_smile: )
let you manage the failure case without increase the nesting
give complete freedom to the developer on how to react to errors while forcing him/her to register a catch handler

just my 2 cents :dollar:

Thanks!

Can you split the two examples? One doing a GET with concat, and another one doing a POST to the local server?

sure!

done! you can launch it with npm run example:localhost.

ok, now the example with google works without errors. :smile:

Thanks!!!!


M3-2039 Fix breakpoint for larger mobile devices for stats & graphs

M3-2039 Fix breakpoint for larger mobile devices for stats & graphs
Description
Fix for Stats & Graphs device views, label and data should be displayed closer together so they're not too far apart. Please review display at multiple breakpoints.
Type of Change

Bug fix ('fix', 'repair', 'bug')

Coverage remained the same at 31.876% when pulling 63cb6089db69959f5512d056a5a1bdd611ea45dd on WilkinsKa1:M3-2039 into 7a0d66933a146d4c81d271ca4fa0f0d6b08ed0b7 on linode:release-0.42.0.


layout.images not shown in rendered output image

For some reason overlay images declared in layout don't get rendered in the output and no error is produced or returned.
I've tried web (google) hosted, local hosted (http://localhost/north_arrow.png), file relative (file://./north_arrow.png) and file absolute (file:///home/.../.../.../north_arrow.png)
I'm using kaleido from plotly R:
R version 4.0.4 (2021-02-15)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: BunsenLabs GNU/Linux 10.5 (Lithium)

The following layout + image declaration should display a NORTH arrow in the top right of the plot area, which works fine when using Firefox-esr:

mp %>%
  plotly::layout(
    images = list(
      list(
        source = "https://freesvg.org/img/north-arrow-2.png",
        xref = "paper",
        yref = "paper",
        x = 0.98,
        y = 0.88,
        sizex = 0.1,
        sizey = 0.1,
        xanchor = "right",
        yanchor = "bottom"
      )
    )
  )

(edited to update to a new image link... problem still persists)

Thanks for your interest in Kaleido. We are currently working on an overhaul that might address your issue - we hope to have news in a few weeks and will post an update then. Thanks - @gvwilson


Add bank account exercise

Loosely based on the C# and scala versions

This looks great, I wonder if we should take the opportunity to showcase the new coroutines capability in the tests instead of all of the threading. Here is a patch that achieves the same thing but looks marginally cleaner:
diff --git a/exercises/bank-account/build.gradle b/exercises/bank-account/build.gradle
index 532a683..a2f84db 100644
--- a/exercises/bank-account/build.gradle
+++ b/exercises/bank-account/build.gradle
@@ -10,8 +10,11 @@ buildscript {

 apply plugin: 'kotlin'

+kotlin.experimental.coroutines = 'enable'
+
 repositories {
     mavenCentral()
+    jcenter()
 }

 dependencies {
@@ -19,6 +22,7 @@ dependencies {

     testCompile 'junit:junit:4.12'
     testCompile "org.jetbrains.kotlin:kotlin-test-junit:$kotlin_version"
+    testCompile 'org.jetbrains.kotlinx:kotlinx-coroutines-core:0.12'
 }
 test {
     testLogging {
diff --git a/exercises/bank-account/src/test/kotlin/BankAccountTest.kt b/exercises/bank-account/src/test/kotlin/BankAccountTest.kt
index 24282ee..af47c95 100644
--- a/exercises/bank-account/src/test/kotlin/BankAccountTest.kt
+++ b/exercises/bank-account/src/test/kotlin/BankAccountTest.kt
@@ -1,10 +1,9 @@
 import org.junit.Ignore
 import org.junit.Test
 import java.util.*
-import java.util.concurrent.CountDownLatch
-import kotlin.concurrent.thread
 import kotlin.test.assertEquals
 import kotlin.test.assertFailsWith
+import kotlinx.coroutines.experimental.*

 class BankAccountTest {

@@ -47,28 +46,25 @@ class BankAccountTest {
     @Ignore
     @Test
     fun concurrentBalanceAdjustments() {
-        val threads = 100
+        val threads = 1000
         val iterations = 500
-        val startLatch = CountDownLatch(1)
-        val endLatch = CountDownLatch(threads)
         val random = Random()

         val account = BankAccount()

-        repeat (threads) {
-            thread {
-                startLatch.await()
+        val jobs = List(threads) {
+            launch(CommonPool) {
                 repeat(iterations) {
                     account.adjustBalance(1)
-                    if (random.nextBoolean()) Thread.yield()
+                    delay(random.nextInt(10).toLong())
                     account.adjustBalance(-1)
                 }
-                endLatch.countDown()
             }
         }

-        startLatch.countDown()
-        endLatch.await()
+        runBlocking {
+            jobs.forEach { it.join() }
+        }

         assertEquals(0, account.balance)
     }

Thanks, that's a good idea 👍

@sdavids13 I have patched the test as you suggested and it does work rather nicely. Coroutines are a great addition to Kotlin :)

Awesome, thanks for the contribution!


app.js in the js folder is still missing

Hi
the app.js file in the js.folder is still missing in the download package. How to get that?
also the babel transfrom js files are missing
vendors~babelTransform-chunk-24844acb4277512e70fd.js
babelTransform-chunk-fe622da15389dffa17f3.js
please advice
Do i have to build these files myself?  If so how ?  Please advice.
Thank you

@BackuPs sorry, can you describe in details what did you do and what you've tried to achieve. I've checked out the app and everything worked for me.

@finom
Sorry if i am not clear.
if i download the master build zip file from github. And upload it in my server or even use it locally on my pc It does not work as 3 js files are not part of the master build. They are missing.
The following files are missing as they are not included in the master build.
app.js
vendors~babelTransform-chunk-24844acb4277512e70fd.js
babelTransform-chunk-fe622da15389dffa17f3.js
So the compress does not work at all once you click the compress button.  Without emascript enabled you the message that app.js is not found. If you enable emascript then you get the js error that the babel js files are missing.
The master zip file is in my opinion incomplete. I reported this also allmost more then a year ago and the files are still not included.
Or please tell me how to generate or get these files.
Kind regards,

are we gonna get a solution for this?

@finom
Sorry if i am not clear.
if i download the master build zip file from github. And upload it in my server or even use it locally on my pc It does not work as 3 js files are not part of the master build. They are missing.
The following files are missing as they are not included in the master build.
app.js
vendors~babelTransform-chunk-24844acb4277512e70fd.js
babelTransform-chunk-fe622da15389dffa17f3.js
So the compress does not work at all once you click the compress button. Without emascript enabled you the message that app.js is not found. If you enable emascript then you get the js error that the babel js files are missing.
The master zip file is in my opinion incomplete. I reported this also allmost more then a year ago and the files are still not included.
Or please tell me how to generate or get these files.
Kind regards,

Can you just download them from the jscompress.com site?
https://jscompress.com/js/app.js
https://jscompress.com/babelTransform-chunk-db67fff9d94e29aa2a74.js
https://jscompress.com/vendors~babelTransform-chunk-38b72474cce8bd4fb904.js

@finom
Sorry if i am not clear.
if i download the master build zip file from github. And upload it in my server or even use it locally on my pc It does not work as 3 js files are not part of the master build. They are missing.
The following files are missing as they are not included in the master build.
app.js
vendors~babelTransform-chunk-24844acb4277512e70fd.js
babelTransform-chunk-fe622da15389dffa17f3.js
So the compress does not work at all once you click the compress button. Without emascript enabled you the message that app.js is not found. If you enable emascript then you get the js error that the babel js files are missing.
The master zip file is in my opinion incomplete. I reported this also allmost more then a year ago and the files are still not included.
Or please tell me how to generate or get these files.
Kind regards,

Can you just download them from the jscompress.com site?
https://jscompress.com/js/app.js
https://jscompress.com/babelTransform-chunk-db67fff9d94e29aa2a74.js
https://jscompress.com/vendors~babelTransform-chunk-38b72474cce8bd4fb904.js

@minig0d thank you for the suggestion but i already knew how to grab them, but that is not the point i am trying to make.
The issue is they change every now an then after each update and the point i am trying to make here is that the zip file is incomplete whereas the owner of jscompress says "and works 100% on client-side."  Which is not true.
The moment you unzip the build and f.e. run it on your localmachine these files are missing and you get a js error.
I did report this several times now with no result to a solution so I decided to switch to another online js compressor a long time ago! Sorry about that.

@minig0d thank you for the suggestion but i already knew how to grab them, but that is not the point i am trying to make.
The issue is they change every now an then after each update and the point i am trying to make here is that the zip file is incomplete whereas the owner of jscompress says "and works 100% on client-side."  Which is not true.
The moment you unzip the build and f.e. run it on your localmachine these files are missing and you get a js error.
I did report this several times now with no result to a solution so I decided to switch to another online js compressor a long time ago! Sorry about that.

@BackuPs sorry, the reason of my long response was the fact that I haven't understood what you're trying to do. I guess you wanted to clone the repository and run the app locally? If the discussion still makes sense to you and my suggestion is correct, you should run build NPM script to get all the needed files.

@BackuPs sorry, the reason of my long response was the fact that I haven't understood what you're trying to do. I guess you wanted to clone the repository and run the app locally? If the discussion still makes sense to you and my suggestion is correct, you should run build NPM script to get all the needed files.

@finom Thanks.  I was under the impression that the zip file contained all the required files needed to make it run locally on my pc or server.  I was not aware that i needed to run the npm script.
Thanks

@finom Thanks.  I was under the impression that the zip file contained all the required files needed to make it run locally on my pc or server.  I was not aware that i needed to run the npm script.
Thanks

so in order to get a full working package i have to install nodjs, npm, uglify.js etc etc...
I just wanted a 100% working product without having todo all these extra things on my machine. Now i need to dive into a lot of extra things to get to the end product. :-(

so in order to get a full working package i have to install nodjs, npm, uglify.js etc etc...
I just wanted a 100% working product without having todo all these extra things on my machine. Now i need to dive into a lot of extra things to get to the end product. :-(


Support EU hosting

The current contentful-merge does not support spaces hosted on eu.contentful.com and does not support adding the host flag, as is possible on the contentful/contentful.js and contentful/contentful-management.js projects.

that's a good point, I will put it on my TODO list


Sidebar to overflow when fixed

Bug:
The sidebar contains more items then can be displayed on some pages, the sidebar cannot be scrolled.
What I did:
I've added a bottom-position and overflow:auto to the sidebar when it's fixed.
How does this fix the problem:
The sidebar is now scrollable.
Demo:

I just noticed some this happens:

Did I introduce that with this? I'll take a look..

Yes, I think so.
This is what is see on my screen:


glfs: check EOF for read

Signed-off-by: Xiubo Li<EMAIL_ADDRESS>

@pkalever Please review. Thanks.


Frame grabs with gstreamer and color cam

So ...
I've been trying to capture a single uncompressed frame from the DFK 22BUC03 TIS camera.
 But I didn't fully understand how the recoloring process works. Following the "First Steps Guide" here I uploaded the "dmk22uc03_163_uvc.euvc" firmware, which is (if I understood it correctly) the monochrome equivalent to my camera.
Or is it the pngencoder? But I couldn't find any arguments to pass to pngenc except "snapshot" and the compression level ... And playing around with those doesn't make it better ...
Or is it something about the timing ... Because the size of those oddly colored frames as seen in the picture vary slightly ...
I just find it weird, that in live streaming mode everything works just fine and as soon as I want to save a single frame it messes up the picture...
I would appreciate every single hint!
Thank you and
with kind regards,
Niko

Hello,
I do not really now the input, the pngenc module needs, but for JPEG I used
bayer2rgb !  ffmpegcolorspace ! video/x-raw-yuv ! jpegenc quality=35  ! multifilesink location="frame%05d.jpg"
You may try this and check the result

Thank you, it worked. I need an uncompressed format, though.
But interestingly enough, the color errors are consistent during the first 10 or so frames and then there is 2 or 3 frames in which the frames get more and more saturated until they are normal colors.
Any ideas where that comes from?
Thank you!

The color error occur, because there are image data blocks not picked up from the USB controller. Thus the Bayer Mosaic pattern is  wrong at the position, where the data block is missing.
I do not know, why the USB controller misses these data packages. It is either, they are not picked up from the camera or the USB controller was not able to save them in memory. You may use a lower frame rate, so the USB controller has a little bit more time.

OK ... I solved it by just grabbing 10 frames and deleting the first 9 all in one script ... I know it's not very elegant, but it works now ...
Thank you for your help!

Hi Niko,
can you send me this script you mentioned?
Thank you in advance
Andreas

Hey Andreas!
I just dug them up. Here's the final script I ended up using. It's used to take four frame grabs from four different cameras connected via USB.
I had to change the file type from .sh to .txt to upload it here.
frameGrab_public.txt
I hope it helps!

Danke


mouse support

Support mouse events where possible.

This is something I'd love to see implemented, but I don't know where I'd start if I were to implement it myself. Do you have any thoughts on this, including where to start and pitfalls?

This looks like a good resource:
http://www.x.org/docs/xterm/ctlseqs.pdf

I don't know the current status of this, but I just thought I'd mention that a brick+vty app in Apple's Terminal on El Capitan (at least) sees mouse-scroll events as cursor up/down, which is rather nice.

@coreyoconnor - I've been working on an implementation of this for the last couple of days, and it works.  But one thing I'm running into is that for terminfo-based terminals, almost no terminfo databases report any of the capabilities related to mouse events (and in the rare event that they do, they aren't useful anyway: they only report old-style capabilities and I want the extended mouse events, which are superior).  And when I run Vty applications I almost always run them in tmux, where Vty chooses to use the terminfo-based driver since TERM is not xterm.
The consequence of this is that my XtermColor implementation of this works just fine, but that isn't the one that gets chosen by Vty.  I could emit the right control sequences in the terminfo-based driver code, but I'm afraid that would not be a good idea.
Any thoughts?

One possibility would be to extend Vty's whitelist of terminals to include screen and tmux variants for XtermColor.  Tmux and screen both require that TERM be set to a variant of those.

This is now available in my fork of the repository on a branch at:
https://github.com/jtdaugherty/vty/tree/feature/mouse-events

I've also just extended this to use the screen terminal type check I mentioned above.  As part of that it now handles "normal mode" mouse events.  In normal mode, it is not specified which mouse button was released, so button-release events in Vty now optionally include the released button or Nothing if one wasn't available.
This kind of impoverishment in the API makes me think there ought to be some way to ask Vty what kind of mouse functionality can expected from the terminal on startup so that applications can degrade expectations accordingly (or refuse to run unless a better mouse event protocol mode is supported).

This has been merged and will go out in the next release.

This is now released: http://hackage.haskell.org/package/vty-5.6


Recent connection list keeps adding connections

Issue Type: Bug

Connect a SQL Server
Query some table from different dbs in the sever connected from step 1 by right click the db name
We can see those connections are added to recent connection list since db name is different.

Too many connections to the same servers if people only care about the server.
Azure Data Studio version: azuredatastudio 1.3.8-insider (b6e32cdeb439246afc6fdcd11d9af2c74ba0ea5a, 2018-12-10T22:09:47.695Z)
OS version: Windows_NT x64 10.0.17763

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7700 CPU @ 3.60GHz (8 x 3600)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
63.92GB (46.43GB free)

Process Argv
C:\Program Files\Azure Data Studio\azuredatastudio.exe

Screen Reader
no

VM
0%

Extensions (1)

Extension
Author (truncated)
Version

sql-vnext
Mic
0.9.1

I think the intended design is that query editor adds connections to the MRU.  Perhaps this only makes sense if the user connects the query editor using the Connection Dialog, rather than New Query command from Server viewlet.

I'm also bugged by this "feature". IMHO, it's a bug as the view's tab title clearly states "Recent connections", not "Recent databases" and the fact that one doesn't connect to a database, but instead to a server.

This should be fixed in the latest builds.  Please let us know if you're still impacted by this issue.


New errors in previously working environment

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting a bug unrelated to a specific site
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Provide a description that is worded well enough to be understood
I run yt-dlp on an x64 QNAP running linux. yt-dlp_linux has worked well for years. Suddenly, I get the following error even if I run "yt-dlp_linux -h":
yt-dlp_linux: tar_extract_all() failed: Invalid argument
This is on version 2024.08.01. If I try on an older version, I get:
Failed to extract Cryptodome/Cipher/_ARC4.abi3.so: decompression resulted in return code -1!
Any suggestions?
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
Adding -vU to the arguments does not produce any debug output

We've changed our build bc the old one broke, and we have not yet have the time to remake them the proper way. That will happen soon™
In the meantime, you should try using python directly, which should work for your case. Install [pipx] (https://pipx.pypa.io) and then install yt-dlp using pipx install --pip-args=--pre "yt-dlp[default]" (or, if you need it, pipx install --pip-args=--pre "yt-dlp[default,curl-cffi]")

Thanks for the quick feedback. I will hold off on installing pipx and instead wait for the upcoming remake. Thanks again.

soon™

FYI, "soon™" means "probably within the next 6 months"

Related: #10072, #10578

last worked version for my qnap ts-262 is 2024.07.08

last worked version for my qnap ts-262 is 2024.07.08

Are you experiencing the same error as the OP? The only changes between versions 2024.07.08 and 2024.07.09 are fixes to the Youtube extractor that should not have any impact here. If 2024.07.08 works, then 2024.07.09 works for you, right?
Perhaps it was the inclusion of curl-cffi in the yt-dlp_linux builds before version 2024.07.16 that is causing the breakage?

last worked version for my qnap ts-262 is 2024.07.08

Are you experiencing the same error as the OP? The only changes between versions 2024.07.08 and 2024.07.09 are fixes to the Youtube extractor that should not have any impact here. If 2024.07.08 works, then 2024.07.09 works for you, right?

yes, i have the same errors (both), but i can't reproduce them:

2024.07.09
[foo@NAS ~]$ ./yt-dlp -h
[756] Failed to extract Cryptodome/Cipher/_ARC4.abi3.so: decompression resulted in return code -1!
[756] Failed to extract entry: Cryptodome/Cipher/_ARC4.abi3.so.

2024.07.08
[foo@NAS ~]$ ./yt-dlp_linux -h
[1548] Failed to extract Cryptodome/Cipher/_ARC4.abi3.so: decompression resulted in return code -1!
[1548] Failed to extract entry: Cryptodome/Cipher/_ARC4.abi3.so.

2024.07.07
[foo@NAS ~]$ ./yt-dlp_linux -h
[2104] Failed to extract Cryptodome/Cipher/_ARC4.abi3.so: decompression resulted in return code -1!
[2104] Failed to extract entry: Cryptodome/Cipher/_ARC4.abi3.so.

2024.07.07 after relogin:
[foo@NAS ~]$ ./yt-dlp_linux -h
yt-dlp_linux: tar_extract_all() failed: Invalid argument

2024.07.07 after erasing /tmp and reboot:
[foo@NAS ~]$ ./yt-dlp_linux -h
[22294] Failed to extract libpython3.11.so.1.0: decompression resulted in return code -1!
[22294] Failed to extract entry: libpython3.11.so.1.0.

either I'm doing something wrong, or the nas is behaving in an unexpected way.. i'm tired of experimenting with this creature of hell

Perhaps it was the inclusion of curl-cffi in the yt-dlp_linux builds before version 2024.07.16 that is causing the breakage?

sorry, this question is not for my skills


Replace MaxPermSize with MaxMetaspaceSize in domain.conf template

According to official Oracle Java docs, Java option MaxPermSize was deprecated in Java 8 and removed in Java 17. Since Java 8, this option was superseded by MaxMetaspaceSize. This seems to require two changes:

domain.conf.epp template should include the correct one in line JAVA_OPTS="-Xms<%= $wildfly::java_xms %> -Xmx<%= $wildfly::java_xmx %>"
The classes that use this template should accept both parameters and validate them against Java version.

I learned that this module can't know Java version - the obvious reason being Java is managed elsewhere - so it can't choose parameter according to that. I changed the title to use only MaxMetaspaceSize instead.
@biemond Adding MaxMetaspaceSize breaks compatibility with Oracle Java < 8. But Java <8 is not supported anymore. Is that OK?


Fix upcoming solc 0.5.0 breaking changes

fixes https://github.com/raiden-network/raiden-contracts/issues/86

fallback functions must be external (https://github.com/ethereum/solidity/blob/develop/Changelog.md#0417-2017-09-21)
keccak256 can only be used with a single bytes argument; abi.encodePacked can be used to tightly pack arguments (https://github.com/ethereum/solidity/blob/develop/Changelog.md#0424-2018-05-16)

What about:

Enforce view / constant with error as experimental 0.5.0 feature.

and

Disallow conversions between bytesX and uintY of different size

All taken from here.
Not saying you need to do something in this PR, just wanna know if you have them in mind/checked for them.

@LefterisJP , there were no other compiler errors aside from the fixed ones.

Enforce view / constant with error as experimental 0.5.0 feature.

We already use view and pure correctly.

Disallow conversions between bytesX and uintY of different size

We don't have this.


Creating a SmaCC parser subclass should also directly be possible from a playground

Instead of using the create class template

It happens that we both created the same issue at the same time. I pushed changes referencing the other issue: #4160


[PATCH] track lockfile

This gist is a patch adding a lockfile and removing Cargo.lock from the gitignore, see that for rationale/etc if necessary.
sorry for doing this through issues, GH's PR workflow is just very cumbersome for small changes. The linked patch should be easy to am to master.

whoops, just realized that binaries track this even if libraries don't - definitely ignore this!


fix: :bug: fix bug in JSON schema

Removing the minItems attribute from the properties.images field for fixing a bug in JSON schema.
Closes cosmos/chain-registry#2352.

I think this is fine although I always thought the requirement only applied iff the images property was includes, and would never complain if there were no images property at all.

Hey, @JeremyParish69 you made me curious and I looked into it.
It is unclear to me from the documentation.
For this reason, I also tried a validator online and you are right. It only requires at least an image if the image field is defined.
I was using this tool for generating the go data type from the JSON Schema definition, so it probably is an issue with that tool.
This commit was wrong.
I could revert it if you want since it does not fix any bugs.

Hey, @JeremyParish69 you made me curious and I looked into it. It is unclear to me from the documentation. For this reason, I also tried a validator online and you are right. It only requires at least an image if the image field is defined. I was using this tool for generating the go data type from the JSON Schema definition, so it probably is an issue with that tool. This commit was wrong. I could revert it if you want since it does not fix any bugs.

I appreciate the investigation. I think for now the images property isn't used enough to bother requiring restrictions on it just yet at the cost of some tools not working. If it can help some tools work, I suppose we might as well leave it removed. But if you think it isn't a required change, then you are free to propose changing it back, if you like.

Thank you.
Yeah, I prefer opening an issue on the other tool and trying to fix that. Since this repo was following the schema, I think it should be better to revert the commit. I'll push a revert commit and open the PR.
Thank you for your time 🙏


Trying to improve language support for better syntax highlighting

First pull request ever and I'm still learning, absolutely no idea if I made many mistakes (please be gentle).
However I tried to understand as good as possible, I did one change in the spec file which I suppose is wrong because others have the same line as in the old version and I only did it to have no failures showing when using atoms spec suite. Please check my changes, I'd really love better syntax support for postcss.

@azat-io Looks good for me

@ai & @azat-io  I think I'm off here:
 +    'captures':
 +      '1':
 +        'name': 'keyword.other.unit.postcss'

and here:
expect(tokens[19]).toEqual value: 'px', scopes: ['source.css.postcss', 'meta.at-rule.media.postcss', 'constant.numeric.postcss', 'keyword.other.unit.postcss']

Those are wrong I guess and I need to make changes to the coffee file for this to actually work as it should, but again I'm still guessing right now, any tools/advise that could help visualize or make my work easier with this are more than welcome.


Updated getIssues method to pull latest issues

In lates version of snyk api there is no aggregated-issues endpoint, I assumed that reporting/issues/latest should contain the same kind of information
Related issue
cc @stevenli6186

Hi. Thanks for your interest and time you've put in the project. We are not maintaining it anymore, and are archiving it for now.


feat(docs): add example for how to create project in codebuild

Regarding https://github.com/spinnaker/spinnaker.github.io/issues/1839, I'm adding an example for creating a project through AWS CLI, which gives first time CodeBuild user an easier way to create a project they could immediately use.

Thanks for adding the info @Kaixiang-AWS. I had a few nitpicks/suggestions. Other than that, LGTM.

Hi @clareliguori, are you okay w/ this being merged?


Migrate the "BumbleBench and HumbleBench" document

🆕🐥 First Timers Only
This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝
👾 Description of the issue
The documentation regarding the BumbleBench benchmark can be found at https://github.com/adoptium/bumblebench/wiki/BumbleBench-and-HumbleBench The documentation must be migrated and stored as Asciidoc documentation in this repository.
📋 Step by Step
To solve this issue and contribute a fix you should check the following step-by-step list. A more detailed documentation of the workflow can be found here.

[ ] Claim this issue: Comment below.
[ ]  Fork the repository in github by simply clicking the 'fork' button.
[ ]  Check out the forked repository
[ ]  Create a feature branch for the issue. We do not have any naming definition for branches.
[ ]  Commit your changes.
[ ]  Start a Pull Request.
[ ]  Done 👍 Ask in comments for a review :)
[ ]  If the reviewer find some missing peaces or a problem he will start a discussion with you and describe the next steps how the problem can be solved.
[ ]  You did it 🎉 We will merge the fix in the master branch.
[ ]  Thanks, thanks, thanks for being part of this project as an open source contributor ❤

🎉 Contribute to Hacktoberfest
Solve this issue as part of the Hacktoberfest event and get a change to receive cool goodies like a T-Shirt. 🎽
🤔❓ Questions
If you have any questions just ask us directly in this issue by adding a comment. You can join our community chat at Slack. Next to this you can find a general manual about open source contributions here.

Hi! I would like to solve this issue.


Django2 support

Codecov Report

Merging #6 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master       #6   +/-   ##
=======================================
  Coverage   85.81%   85.81%
=======================================
  Files           3        3
  Lines         148      148
=======================================
  Hits          127      127
  Misses         21       21

Impacted Files
Coverage Δ

django_inet/models.py
84.09% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 388fc27...8a001a5. Read the comment docs.


Added necessary changes to the js file

Added necessary javascript to make the prework study guide more interactive.

Merged feature/add-js to the main branch.


Periodically send stack traces of all live threads in the Ruby process

This would be helpful to debug processes which seem stuck.

We'll also send percentage CPU usage stats.

Also possible send backtrace on signal https://github.com/puma/puma/pull/1320


segmentation_pointcloud_fusion can't work proper with multiple mask

Checklist

[X] I've read the contribution guidelines.
[X] I've searched other issues and no duplicate issues were found.
[X] I'm convinced that this is not my fault but a bug.

Description
I want to use segmentation_pointcloud_fusion node with 6 cameras and I have a problem. When I have multiple cameras and multiple /perception/object_recognition/detection/mask? outputs from autoware_tensorrt_yolox, my expectation is to see point cloud which fused from all cameras. However I just see the point cloud fused from a single camera, especially the last camera from this loop
In the following loop located in the FusionNode<TargetMsg3D, Obj, Msg2D>::subCallback() function, the output point cloud data is cleared at every step, and the points deleted in the previous step are restored.
for (std::size_t roi_i = 0; roi_i < rois_number_; ++roi_i) {

    // ...

    fuseOnSingleImage(
              *input_msg, roi_i, *((cached_roi_msgs_.at(roi_i))[matched_stamp]),
              camera_info_map_.at(roi_i), *output_msg);

    // ...

}

As a result of this, I just see that the only points remove related with the last camera. Did I make something wrong, or is it the expected behavior?
fyi. @badai-nguyen, I guess you are the maintainer of this package or node.
Expected behavior
I expect to see something like that when I run the segmentation_pointcloud_fusion node: https://youtu.be/Ho4lkrmtuz4
To obtain this results, I make some basic changes in fusion_node.cpp and segmentation_pointcloud_fusion/node.cpp.
Actual behavior
I see something like that when I run the segmentation_pointcloud_fusion node: https://youtu.be/GaNBf3vUcOo
Steps to reproduce
I did not run whole Autoware, I just launch yolox and image_projection_based_fusion.
There are six cameras and one lidar topic in my bag file.

ros2 launch autoware_tensorrt_yolox multiple_yolox.launch.xml

From this launch file, I just added the output/mask topic for each yolox node, because in default it looks mask topics is same for all nodes.

ros2 launch autoware_image_projection_based_fusion segmentation_pointcloud_fusion.launch.xml
ros2 bag play -r 0.015 rosbag/

Currently checking this

@StepTurtle
Thanks for your report and I think this is a bug.
Could you test with the PR https://github.com/autowarefoundation/autoware.universe/pull/8769 and check whether this solves your issue?
Thanks!

@vividf
Thanks for your PR. Yes it solved my problem and it can work for a multiple cameras and masks. 👍🏽


Feature: add onGridLongPress prop

Added onGridLongPress prop, to allow different user-interactions with the grid
I realize the name is different than onGridClick (click vs press). I think in mobile "press" sounds more natural. We could rename onGridClick to onGridPress in a future (breaking) version

LGTM.


Expand documentation for anonymous controllers

anonymous controllers that dont inherit from ActionController::Base need special custom routes, fixes #1670

LGTM


[TST] add coverage to tests

This adds coverage so we can see which functions (and sub-parts of functions!) aren't currently caught by our tests

If you look at the test run (step Full Tests) you can see the coverage result
https://github.com/callumrollo/glidertest/actions/runs/11796201228/job/32857554742?pr=90#step:5:38
We have 90 % test coverage which is very good!
We can see in the table that in tools the following lines are note covered by the tests:
100-101, 121, 126-127, 177-180, 231, 243, 268, 273, 295, 359-376, 460, 468-470, 522, 558, 563, 571-573, 578-579, 603, 659, 667-670, 698, 758, 835, 902-920, 941, 1057, 1088, 1126-1131, 1135, 1173-1177
These are mostly if statements where one of the possibilities is not tested (e.g. making a figure if the user hasn't supplied one, or adding variables that aren't present). the only big one is lines 902-920, which tells us the function calc_DEPTH_Z is not being tested. We should test it!


[SPARK-48260][SQL] Disable output committer coordination in one test of ParquetIOSuite

What changes were proposed in this pull request?

A test from ParquetIOSuite is flaky: SPARK-7837 Do not close output writer twice when commitTask() fails
It turns out to be a race condition. The test injects error to the task committing step, and the job may fail in two ways:

The task got the driver's permission to commit the task, but the committing failed and thus the task failed. This will trigger a stage failure as it means possible data duplication, see https://github.com/apache/spark/pull/36564
In test we disable task retry, so TaskSetManager will abort the stage.

Both these two failures are done by sending an event to DAGScheduler, so the final job failure depends on which event gets processed first. This is not a big deal, but that test in ParquetIOSuite checks the error class. This PR fixes the flaky test by running the test case in a new test suite with output committer coordination disabled
Why are the changes needed?

fix flaky test
Does this PR introduce any user-facing change?

no
How was this patch tested?

GA test + manual test on lcoal
Was this patch authored or co-authored using generative AI tooling?

No

This is another approach for https://github.com/apache/spark/pull/46560. I am trying to avoid changing the production code for a flaky test fix here.

@viirya @cloud-fan thanks for the review. Merging to master.

Hi, @gengliangwang and all.
Do you think we can have this at release branches too?

@dongjoon-hyun From the recent tests of branch-3.5(https://github.com/apache/spark/commits/branch-3.5/), the ParquetIOSuite looks fine for now. I am ok with either backporting or not backporting.


Cannot escape static mustaches

Cannot escape static mustaches.
To recreate try parsing '\[[foo bar]]'
I think this should be available like it is for standard mustaches.
Many thanks.

I think I'm missing something? http://jsfiddle.net/br63j23d/1/

I'm thinking maybe this was meant to be Ractive.parse('\\[[foo.bar]]') where the js string escape was throwing in the monkey wrench ('\[' === '[') so I'm going to close this. If that's not it, please feel free to reopen.


Update documentation website

Describe the bug
Documentation in https://docs.spatie.be/laravel-activitylog displays only documentation for v1 and v2 even though v3 and v4 are published.
Expected behavior
All relevant versions should be available.

Ah, yes, I just came to the issues to report the same.
Anyone who wonders where to find the missing docs can look into the project /docs folder (for the selected branch) - https://github.com/spatie/laravel-activitylog/tree/main/docs

Thanks @reppair  - it took me a minute to figure out where that was!

As of 9 January 2024, documentation for v3 and v4 are available on the website


test: a11y tree snapshot showcase

Docs
Unfortunately, I feel that the snapshot doesn't add much value to tests 😞
Furthermore, Playwright marks the snapshot functionality as deprecated and advises using other tools like Axe (which I checked, but it seems helpful when testing full pages).
On a positive note, I found something that might be useful during development on a11y matter.
Chrome dev tool offers an a11y tree inspector that's what screen readers use.
It might be a good starting point to compare the trees when we have some screen reader misbehavior

Codecov Report
Attention: 87 lines in your changes are missing coverage. Please review.

Comparison is base (638977d) 92.61% compared to head (efd3782) 95.98%.
Report is 131 commits behind head on master.

Files
Patch %
Lines

src/components/core/dom/spread.ts
80.48%
8 Missing :warning:

src/components/icon/icon-base.ts
89.74%
8 Missing :warning:

...metable-occupancy-icon/timetable-occupancy-icon.ts
92.66%
8 Missing :warning:

...nents/core/common-behaviors/slot-child-observer.ts
93.33%
5 Missing :warning:

src/components/core/dom/breakpoint.ts
42.85%
4 Missing :warning:

src/components/autocomplete/autocomplete.ts
86.95%
3 Missing :warning:

src/components/card/card-action/card-action.ts
70.00%
3 Missing :warning:

src/components/core/dom/dataset.ts
25.00%
3 Missing :warning:

src/components/core/dom/host-context.ts
40.00%
3 Missing :warning:

...onents/core/eventing/connected-abort-controller.ts
40.00%
3 Missing :warning:

... and 26 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2263      +/-   ##
==========================================
+ Coverage   92.61%   95.98%   +3.36%
==========================================
  Files          53      334     +281
  Lines        2409    39185   +36776
  Branches      254     2191    +1937
==========================================
+ Hits         2231    37610   +35379
- Misses        176     1531    +1355
- Partials        2       44      +42

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

We decided not to go further with the implementation because playwright has marked the API as deprecated.


Button styles

Fix #https://adobe-acs-group.atlassian.net/browse/WRLDBAEMS-45
Test URLs:

Before: https://main--world-bank--aemsites.hlx.live/
After: https://buttons--world-bank--aemsites.hlx.live/en/drafts/thomas/buttons

@mkbansal1 Added buttons styles for themes. Only changed link style color for now due to open questions and how links are displayed within other components. Kindly have a look.


feat: add json patches

Add ability to apply patches to PodSpecs via JSON Patches  for PodAccessTemplates

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.7%) to 45.13%

Totals

Change from base Build<PHONE_NUMBER>:
-0.7%

Covered Lines:
973

Relevant Lines:
2156

💛  - Coveralls

@dnguy078 What do you think about https://github.com/diranged/oz/pull/234/files merging into this?

@dnguy078 What do you think about https://github.com/diranged/oz/pull/234/files merging into this?

Looks good. I’ll need to bump my local go version to 1.21 to fix the go.mod


Implement Thing object type

See https://github.com/NordicMuseum/Wikimedia-Commons-uploads/issues/20

obs. implement otherInformation

otherInformation is Harvested, but not implemented in makeinfo yet...
look at data["exhibition"] → harvest & insert in tpl

perhaps name related images starting with 1 instead of 0?

Right, that's how normal people count, I've heard ;)

note to self: overwrite the slider no immediately when loading the json, that should trickle down to all the relevant places....

after that i'll probably merge this pr since it's The Big Thing That Technically Works Now 🎆


Make depstat work properly with go1.17+ go mod graphs

This fixes a few issues encountered when working with go1.17+ go.mod files, or the expanded graph resulting from dropping pinned replace directives in https://github.com/kubernetes/kubernetes/pull/113424

Makes longest chain calculation more efficient by memoizing already-computed chains for deps
Uses the effective reachable versions of modules in the graph when computing dependency counts and longest chains

/cc @dims

/cc @RinkiyaKeDad

/approve
/lgtm
thanks @liggitt


Allow sample form to be submitted

As the sample form now exists in the Rails demo app we can make it actually work.

Adds a basic form model and controller for the form
Shows error messages when submitting the form
Simplifies the form logic to keep things simple enough to model

Really bare-bones but just enough to let us test error summary behaviour in the demo app.

when I first looked at the method name new in example_fom_controller and the form file name new.html.erb I expected that it would be linked to the user creating a new form, but it may just be me

The new action is meant to map to the blank form and it's the create action that handles the actual submission. This always catches me out too, but this page has a good summary of what the different actions map to in Rails conventions https://guides.rubyonrails.org/routing.html#crud-verbs-and-actions


[schnorr] support schnorr signature in secp256k1.

Part of https://github.com/rooch-network/rooch/issues/406

@jolestar it's ready for review.

@wow-sven help review

@wow-sven I merge this first.


Use Newtonsoft.Json

We want to use its handling of required non-nullable properties: https://github.com/ondryaso/kachna-online/pull/3#discussion_r739691207
Remember to add Swashbuckle support package for Newtonsoft.Json.

Addressed in b19ae0f2dbfca371dfb2be633574ea6e97c3fcd3 and fc09a2f4f5435117736dee17105db42351c2217f, after #3 is merged to master, remember to adjust new DTOs in the states branch as well.


ocamlPackages.qtest: 2.11.1 -> 2.11.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/ocaml4.10.0-qtest/versions.
meta.description for ocamlPackages.qtest is: "Inline (Unit) Tests for OCaml"
meta.homepage for ocamlPackages.qtest is: "https://github.com/vincent-hugot/qtest"
meta.changelog for ocamlPackages.qtest is: ""
Updates performed

Version update

To inspect upstream changes

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 2.11.2 with grep in /nix/store/lqwhf5h8nlnr0s3ydb4gr5acp3vpcgy7-ocaml4.10.0-qtest-2.11.2

directory tree listing: https://gist.github.com/1080acee14b055ee39791e39ce9c929c

du listing: https://gist.github.com/e65d71f6410565d6e2f97b1c10649d7f

Rebuild report (if merged into master) (click to expand)

38 total rebuild path(s)

10 package rebuild(s)

10 x86_64-linux rebuild(s)
10 i686-linux rebuild(s)
10 x86_64-darwin rebuild(s)
8 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
beluga
flow
fstar
libbap
liquidsoap
python37Packages.bap
python38Packages.bap
python39Packages.bap
satysfi
stog

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/lqwhf5h8nlnr0s3ydb4gr5acp3vpcgy7-ocaml4.10.0-qtest-2.11.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A ocamlPackages.qtest https://github.com/r-ryantm/nixpkgs/archive/1f63d667b4aafa04694ce1d2bb17f31e2585fc1e.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/lqwhf5h8nlnr0s3ydb4gr5acp3vpcgy7-ocaml4.10.0-qtest-2.11.2
ls -la /nix/store/lqwhf5h8nlnr0s3ydb4gr5acp3vpcgy7-ocaml4.10.0-qtest-2.11.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

23 packages built:

beluga
flow
fstar
libbap
liquidsoap
ocamlPackages.batteries
ocamlPackages.containers
ocamlPackages.containers-data
ocamlPackages.gen
ocamlPackages.iri
ocamlPackages.iter
ocamlPackages.piqi
ocamlPackages.piqi-ocaml
ocamlPackages.qtest
ocamlPackages.sedlex
ocamlPackages.sedlex_2
ocamlPackages.tsort
ocamlPackages.xtmpl
python37Packages.bap
python38Packages.bap
python39Packages.bap
satysfi
stog

Maintainer pings
cc @vbgl for testing.

Result of nixpkgs-review pr 113395 at 1f63d667 run on aarch64-linux 1

1 package marked as broken and skipped:

flow

1 package failed to build:

stog

6 packages built:

beluga
libbap
liquidsoap
python37Packages.bap
python38Packages.bap
python39Packages.bap

Same mystery uunf error as before from @r-rmcgibbo. I verified manually yesterday that it wasn't an OOM error.

Same mystery uunf error as before from @r-rmcgibbo. I verified manually yesterday that it wasn't an OOM error.

Yep, I suspect it might be a compiler issue specific to OCaml 4.08 (at least I hope it is), but I'll have to verify it first. Then I can mark the package as broken for that compiler version and arch.


fix: ignore types & script folders

Summary
Ignore the types output folders and script folders so the run doesn't try to read types as an input folder

:tada: This PR is included in version 1.2.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add 'hidden' widget

I have a schema that makes use of oneOf to choose between two types.
In my types, there is a 'type' object property that looks like this :
{
    'type': 'object',
    'properties': {
        'id': {'type': 'string'},
        'type': {'type': 'string', 'default': 'A', 'readOnly': True, 'enum': ['A']},
    },
    'required': ['id', 'type'],
}

I'd love to be able to hide the field in the admin, since it's not meant to be edited or read.

Alright, I'll add support for "widget": "hidden". Will release in a couple of days.

BTW, meanwhile you can use "format": "hidden". Kind of unintuitive, but it works.

This feature is available in v2.17.0. Please upgrade and test it out.
Usage example:
{
    "type": "string",
    "widget": "hidden"
}

Thanks for suggesting this feature.

Just tested it, works perfectly, thanks !


Configure transitive dependencies in ssr external/noExternal

Description
SvelteKit needs to add Svelte libraries to noExternal to compile the .svelte files. We'd also like devDependencies to be bundled and dependencies not to be. This is because when people run npm install in production they're not getting their devDependencies installed, so it'd be nice to bundle those. This is almost impossible because we can't just add the devDependencies to noExternal since it doesn't also add the transitive dependencies. We can't set noExternal to true and add the dependencies to external because we might add a Svelte library which would cause it to break
Suggested solution
The ssr.external and ssr.noExternal docs are fairly vague. If my recollection serves me, one deals with libraries and one with .js files. It would be nice to clarify what they operate on
Given my current lack of clarity as to how these options work, it's hard for me to suggest solutions. Is it possible for the options to take effect not just for the individual libraries, but also their dependencies?
Alternative
This is currently being worked around by bundling the Vite output with esbuild, but that seems like it should be unnecessary. The second bundling step adds an additional layer of complexity and causes users to hit all of esbuild's bugs (e.g. https://github.com/sveltejs/kit/issues/6440)
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

What we have right now (both in Vite 2 and Vite 3) is:

ssr.noExternal expects packages names.
ssr.external works both with packages names and with direct entries.

Dependencies of the project are external by default, so if we have:

project
-> dep_A -> (depends on dep_B)
-> dep_B

And dep_A is configured as noExternal, dep_B will still be external because it is a dep of the project. But if we have

project
-> dep_A -> (depends on dep_B)

Then both dep_A and dep_B will be noExternal. So if the user wants both dep_A and dep_B in the first case to be noExternal, both will need to be added to ssr.noExternal
If I recall correctly, at one point Vite did differentiate between dependencies and devDependencies. Maybe it was wrong to treat them in the same way, and devDependencies should be noExternal by default that is what you would like to achieve here. Let's discuss this with others, a change here could only be applied in Vite 4 I think though

Yeah, I sent the PR to switch it about a year ago: https://github.com/vitejs/vite/pull/4699. It looks like part of the issue back then was that we were always using require which would fail with ESM libraries. However, now we always use import, so that should no longer be a concern. However, the other part of the issue is that dev mode bundling often fails and would make the development experience slower. As a result, we're currently hoping to only turn it on for build.
Your comment suggested that noExternal is already applied transitively and the way you described it would be perfect for us. However, one of the Svelte maintainers reported otherwise in https://github.com/sveltejs/kit/issues/3176#issuecomment-1216498286 which is why we added the second bundling step with esbuild. Do you know where in the code the transitive dependencies would be included? I could try to debug it and see why they weren't in our case.

@benmccann I think this PR, that is trying to go in the opposite way of what you want here, is a good place to see how this works:

https://github.com/vitejs/vite/pull/9763

Here is the code that is trying to resolve the dep from root, and filters subdependencies as noExternal: https://github.com/vitejs/vite/blob/7c4ab51e744747fd626b7316425f003bcb537c49/packages/vite/src/node/ssr/ssrExternal.ts#L133
cc @bluwy, shouldn't we evaluate having devDependencies be noExternal by default? This threads into the discussion we had with @brillout about SSR by default bundling everything that may not be installed in prod later (or that depends on the used package manager)

In the case I'm looking at @sveltejs/kit depends on devalue. When shouldExternalizeForSSR checks devalue it returns true via the code path below.
shouldExternalizeForSSR: https://github.com/vitejs/vite/blob/561f7de49303b6300704ec071ecf71edccc43852/packages/vite/src/node/ssr/ssrExternal.ts#L106
Calls function returned by createIsSsrExternal:
https://github.com/vitejs/vite/blob/561f7de49303b6300704ec071ecf71edccc43852/packages/vite/src/node/ssr/ssrExternal.ts#L205
Calls function returned by createIsConfiguredAsSsrExternal:
https://github.com/vitejs/vite/blob/561f7de49303b6300704ec071ecf71edccc43852/packages/vite/src/node/ssr/ssrExternal.ts#L188
Calls isExternalizable which returns true:
https://github.com/vitejs/vite/blob/561f7de49303b6300704ec071ecf71edccc43852/packages/vite/src/node/ssr/ssrExternal.ts#L135
I might be missing it, but I don't see anywhere in here where noExternal would be applied transitively. If we could change that so that it were applied transitively that would address the issue we're facing.

cc @bluwy, in Vite 4, shouldn't we evaluate having devDependencies be noExternal by default? This threads into the discussion we had with @brillout about SSR by default bundling everything that may not be installed in prod later (or that depends on the used package manager)

I think the idea so far is to not give special treatment to dependencies and devDependencies, which is good to prevent surprises when adding dependencies. Similar to the discussion where we don't want linked deps to be auto noExternal by default, I think we should also avoid prod and dev deps having special meaning too (?) 🤔

I might be missing it, but I don't see anywhere in here where noExternal would be applied transitively. If we could change that so that it were applied transitively that would address the issue we're facing.

Yeah noExternal currently isn't applied transitively because it doesn't quite work (or maybe I misunderstand the scenario). For example, foo depends on bar, if foo is externalized, it will be handled by node entirely down the tree which we can't rewrite it's bar dependency to the bundled version.

Yeah noExternal currently isn't applied transitively because it doesn't quite work (or maybe I misunderstand the scenario). For example, foo depends on bar, if foo is externalized, it will be handled by node entirely down the tree which we can't rewrite it's bar dependency to the bundled version.

I think it would still be possible given the example you shared. If the user explicitly externalizes foo then it's fine for that to take precedence transitively and for both foo and bar to be externalized.
Another thing I'll mention is that if we have foo depends on bar depends on baz, the only thing I really care about configuring is foo. I've never really had a need to configure bar or baz.
Handling things transitively would also add some simplifications. E.g. we wouldn't need the > syntax to be able to manually specify every transitive dependency in vite-plugin-svelte because it would happen automatically.


Add roadmap for Kraken

Description
This commit adds a roadmap which walks through the features and enhancements that
are going to be added to Kraken in the immediate future in order to help users
understand where we need help as well as where the project is going.
Fixes
#43

Looks good, after we iron out the details network partition scenario outage, proposed by  Alejandro, let's add it to this list.


Add Profile: Darshan Krishna N

Hi 👋, I'm Darshan Krishna N
Lazy Developer

ABOUT ME

👨🏻🎓 2024 graduate with a degree in Electronics and Computer Engineering from REVA University

💼 Currently a Data Quality Analyst intern at JLL Technologies

💻 Primary focus on Backend Development

🌱 Currently learning Automation Scripting

📫 My portfolio website: Portfolio

⚡ I love attending community events and collecting swags

LANGUAGES AND TOOLS

--------------- LET'S CONNECT ---------------

----------------------------------------------------------

Please add hacktoberfest label


Add utils to normalize repo

Signed-off-by: shiyu22<EMAIL_ADDRESS>

Codecov Report

Merging #572 (0d94f9b) into main (17000d0) will decrease coverage by 2.58%.
The diff coverage is 86.48%.

:exclamation: Current head 0d94f9b differs from pull request most recent head 014e4ed. Consider uploading reports for the commit 014e4ed to get more accurate results

@@            Coverage Diff             @@
##             main     #572      +/-   ##
==========================================
- Coverage   72.70%   70.11%   -2.59%
==========================================
  Files         139      145       +6
  Lines        5198     5544     +346
  Branches      778      817      +39
==========================================
+ Hits         3779     3887     +108
- Misses       1180     1420     +240
+ Partials      239      237       -2

Impacted Files
Coverage Δ

towhee/utils/repo_normalize.py
86.48% <86.48%> (ø)

towhee/__init__.py
80.00% <0.00%> (-14.74%)
:arrow_down:

towhee/data/random_erase.py
86.36% <0.00%> (-4.55%)
:arrow_down:

towhee/engine/operator_loader.py
85.48% <0.00%> (-3.41%)
:arrow_down:

towhee/dag/base_repr.py
100.00% <0.00%> (ø)

towhee/engine/__init__.py
100.00% <0.00%> (ø)

towhee/models/layers/mlp.py
100.00% <0.00%> (ø)

towhee/models/layers/sam.py
40.47% <0.00%> (ø)

towhee/models/layers/spp.py
100.00% <0.00%> (ø)

towhee/models/layers/aspp.py
100.00% <0.00%> (ø)

... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17000d0...014e4ed. Read the comment docs.

#550

/lgtm
/approve


chore(ci): add support for x86-64 regions only

Issue number: #1950
Summary
Changes

Please provide a summary of what's being changed

This PR changes our Layer and Canary stack to support regions that only support x86_64 Lambdas. We couldn't find an easy and reliable way to
detect dinamically if a given region supports ARM64 Lambdas, so instead we maintain the map manually and indicate which regions don't support it.
This makes heavy use of CDK/CloudFormation Parameters and Conditions, so the same CloudFormation template can be used across all regions.
User experience

Please share what the user experience looks like before and after this change

After this change, we will generate Lambda Layers for regions that only support x86_64 Lambdas. We will need to update the documentation when the
first Layer version is generated, and validate that the script to update the layer version in the docs works with the single-architecture regions.
Regions that will be added by this PR

ap-south-2
ap-southeast-4
eu-central-2
eu-south-2
me-central-1

Checklist
If your change doesn't seem to apply, please leave them unchecked.

[x] Meet tenets criteria
[x] I have performed a self-review of this change
[x] Changes have been tested
[x] Changes are documented
[ ] PR title follows conventional commit semantics

Is this a breaking change?
RFC issue number:
Checklist:

[ ] Migration process documented
[ ] Implement warnings (if it can live side by side)

Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena unfortunately there's no easy to way to test this. So please check the code to see if it makes sense, and after we merge we can try a couple of workflows to see if any change is needed.

@leandrodamascena unfortunately there's no easy to way to test this. So please check the code to see if it makes sense, and after we merge we can try a couple of workflows to see if any change is needed.

The code makes perfect sense to me, but like you said: there's no way to test it and just looking at the code I have no idea if we need to change anything else.
So, I follow you: let's merge this PR and check for possible changes. I'll approve.


[Task]: Breakdown and analysis of effort required to add a new integration

Is there an existing issue for this?

[X] I have searched the existing issues

SubTasks

Provide a breakdown and analysis of how much time is required and why so for adding a new integration.

[not urgent] @sumitsum have you created a doc for this? If yes would you please link it?

Writeup is available here. cc: @rohan-arthur


vp9 decoder supports increasing resolution on non-keyframe incorrectly

command line:
Sample_decode vp9 -i input.ivf -o output.yuv
MSDK returns MFX_ERR_INCOMPATIBLE_VIDEO_PARAM or MFX_ERR_REALLOC_SURFACE when the resolution is changed from lower to higher
https://github.com/Intel-Media-SDK/MediaSDK/blob/1160bfa30d6b7c6658f9c7189d31254df94393d5/_studio/mfx_lib/decode/vp9/src/mfx_vp9_dec_decode_hw.cpp#L1020-L1024
And Sample_decode doesn't handle MFX_ERR_REALLOC_SURFACE, or calls Pipeline.ResetDecoder() for MFX_ERR_INCOMPATIBLE_VIDEO_PARAM, which will result in wrong result on non-keyframe because the existing references are deleted by Pipeline.ResetDecoder()
https://github.com/Intel-Media-SDK/MediaSDK/blob/1160bfa30d6b7c6658f9c7189d31254df94393d5/samples/sample_decode/src/sample_decode.cpp#L709-L743

should be implemented:

Surface reallocation function in vaapi/d3d/d3d11 allocators (sample_common).
MFX_ERR_REALLOC_SURFACE handling in sample_decoder pipeline

@IlyaSergeyev Please consider the external allocator too, we use external allocator in gst-msdk.

@xhaihao Could you please share your input.ivf for debugging? Thanks

@IlyaSergeyev Could you please review #1725? Thanks.


Adding typings to npm package

Thanks for adding TypeScript typings! However, they are not accessible when you install via npm, as they are not included in the bundle. This PR fixes that :)

Thanks a lot for the contribution! I don't use TypeScript myself, so I didn't notice :)
I'll cut at release later this week


TarError Unrecognized archive format

i am trying to download a cookbook and i am getting an error TarError Unrecognized archive format.
when i follow the download location and fetching the file using wget, the file seems ok.
here is a snippet of the details:
$ cat /etc/*release*
PRETTY_NAME="Debian GNU/Linux 9 (stretch)"
NAME="Debian GNU/Linux"
VERSION_ID="9"
VERSION="9 (stretch)"
ID=debian

# ruby --version
ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-linux]

$ bundle exec berks --version
7.0.1

$ bundle exec berks install --debug
I, [2018-05-05T17:51:45.650488 #355]  INFO -- : Installing windows (4.2.2)
D, [2018-05-05T17:51:45.652197 #355] DEBUG -- :   Downloading windows (4.2.2) from https://supermarket.getchef.com
D, [2018-05-05T17:51:45.652863 #355] DEBUG -- :     => #<Berkshelf::APIClient::RemoteCookbook:0x00007fd671581f70 @name="windows", @version="4.2.2", @attributes={"location_type"=>"opscode", "location_path"=>"https://supermarket.chef.io:443/api/v1", "download_url"=>"https://supermarket.chef.io:443/api/v1/cookbooks/windows/versions/4.2.2/download", "dependencies"=>{}}>
Installing windows (4.2.2) from https://supermarket.getchef.com ([opscode] https://supermarket.chef.io:443/api/v1)
Mixlib::Archive::TarError Unrecognized archive format

$ wget https://supermarket.chef.io:443/api/v1/cookbooks/windows/versions/4.2.2/download -O /tmp/file.tmp
$ file /tmp/file.tmp
/tmp/file.tmp: gzip compressed data, last modified: Tue Apr 24 16:14:29 2018, from Unix

while trying to debug the issue, i tried reproduce on mac os with the same ruby, bundler and gems versions (i am using Gemfile.lock). *the issue does not persist on mac os.
any insight?
(probably different compilation of the ruby gems due to the platform)

oops, please delete. i am moving it to berkshelf.


Upgrades and cleanup for better Angular support

Adds better support for CardView through directives
Adds AOT support
General cleanup of some code
Some of the work is being merged in from charsleysa/nativescript-mdc

@charsleysa thanks. But i don't see the point of your cardview directive. Those properties are declared already and you don't need this. Can you explain?

@farfromrefug to be honest I can't remember the exact reason there was a directive for card view, I think it had something to do with safety around the lifecycle with angular as there would be cases where the angular component would exist but the underlying nativescript component did not yet exist so programmatic access to the UI element would cause an exception.
This is the first of a few PRs. I plan on adding the Bottom Navigation component next which has benefits of using the directives in terms of building out the tabs in the HTML template instead of having to do it through code.
My goal is consolidate efforts to bring all the MDC components to nativescript.

@charsleysa great! So can you modify that PR and remove the directive for now? Until it's actually proven to be necessary?

@farfromrefug updated the PR with the directive removed.


checkbox default check.

how checkbox default check
i tried checked attribute and also try ng-checked attribute but not work.

Just set the model value to the default value you want. This should work.

but not have an attribute and also ng-checked="true" is not working for this.
i work same like your trick.

Same issue, my ng-model value  = 1, the check box is unchecked and the model value changes to 0
here is my checkbox
<checkbox                 ng-model="db.selectedGroup.is_primary"                 ng-true-value="1"                 ng-false-value="0"                 ></checkbox>
and here is my object if the checkbox is not in the page
group_description: "", group_id: "db1-cfb5df1c-6027-11e4-b1b7-525400b87f6d", group_name: "Execs", is_primary: 1
then here is my object again when the checkbox is in the page
group_description: "", group_id: "db1-cfb5df1c-6027-11e4-b1b7-525400b87f6d", group_name: "Execs", is_primary: "0"
any suggestions?

At a first look you are mixing strings and integers, could this be the problem?
is_primary is 1 (int) at first and then "0" (string)

Please reopen if the problem still exists


npm deployment key in travis config

Is there any way to keep your deployment key hidden?
(travis must have something for this...)
I can see your npm deployment key right inside .travis.yml :(

its not a problem, because this key is stored securely at travis.com and the key in the config is just an auth key to access it, so not a problem
this can be closed
@Ben305

btw in version 6.0.0 / my fork, it got changed to be environment variables instead for a secure:


Make it easy to run phpunit tests

Is your feature request related to a problem? Please describe

Helping new users to be able to run tests
Describe the solution you'd like

Add environment variables per phpunit.xml.dist so that tests are just setup
https://mglaman.dev/blog/running-drupals-phpunit-test-suites-ddev

I think I'll take a stab at this :)

We can copy and paste some things from here: https://github.com/bluehorndigital/drupal-civicrm-project

Also +1 to add in the nightwatch command and container yaml from https://github.com/bluehorndigital/drupal-testing-workshop


shooting range is missing (and the current closest match is quite unfortunate, especially for people from US)

According to the wiki a shooting range should be tagged leisure=pitch with sport=shooting.
https://wiki.openstreetmap.org/wiki/Tag:sport%3Dshooting


Include period supplies in kits in NDBN report values that are based on period supplies

Summary
Period supply values in the Annual Survey should include period supplies in kits
Why?
Better reporting of actual distribution
Details
Similar to issue #3939...  You may need to use SQL to extract the information
Look at  services/reports/period_supply_report_service
Assume 1 kit per individual
The following values in the report will need attention:
Period Supplies distributed
Period Supplies per adult per month  [Note:   this should be per individual per month -- confirmed with NDBN liason]
% period supplies donated -- note that most banks make their own kits, but we do have some who have kits donated -- so this is a slightly different twist from #3939
% period supplies bought -- afaik, we don't have any cases of kits being bought, but we don't prevent it.
Criteria for completion

[ ] values in report regarding period supplies reflect period supplies in kits
[ ] tesets demonstrating the changes

This is going to be assigned to @jadekstewart3.  This comments just here so I can do that.

I can take this! Thank you :)

Thank you!

Just an update: Still working on this. I was OOO the last week an a half, so I am hoping to get some more done this week and next :)

Hi @jadekstewart3 -- just a heads up that I'm doing some rework of the whole what-goes-in-what-bucket due to conversations with NDBN, and things I've found that were just not right!

Noting that that is up and merged -- if you check the scope for period supplies on item in main,  you'll see that it is much simpler now!

Hey @jadekstewart3 Checking in on this -- any roadblocks you need cleared?

Hi @cielf! Thank you for checking in! I'm actually having some trouble with pulling the purchased items
I should be showing at least one purchased kit based off of this test set up:

This is my method:

The current method is returning zero, and I should be expecting 1. I've been messing with multiple versions of this method, and I cant quite put my finger on why my method isn't returning the integer 1, as expected with the single purchased kit in my test set up.

@jadekstewart3 I don't have time to dig into it today,  but may I ask --  is purchased_kits  supposed to be getting the number of kits purchased?  Because my first read of that is that it might get the number of line items with  kits purchased -- that being said, I'll have to sit down with it and figure out each step.     Probably tomorrow.

@cielf thank you! That is so helpful!

@jadekstewart3 Just checking in - do you need anything on this?

@cielf I'm almost done with this, i do have a question though. When you are asking for % of period supplies bought, you want me to pull the number of supplies contained in purchased kits, right?

I'm not sure anyone ever purchases kits, but/and it's still correct to take them into account.  You did for the disposables, right?

I checked -- there are a  few purchases of kits in the production db.  Very few, but that does mean the answer is yes.


mdt-cell not able to handle complex ng-repeat

I had a same problem :
https://github.com/iamisti/mdDataTable/issues/79
please help me!
Thank !

Sorry,I am wrong

Should this be closed?

Yes,please answer me in angular formly issue


Update README.md

Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

closing for https://github.com/opensearch-project/observability/pull/341, which updates all references of trace-analytics