Files in named volume disappear on mac beta

Output of docker version:
Docker version 1.12.0-rc3, build 91e29e8, experimental

Output of docker info:
Containers: 1
 Running: 1
 Paused: 0
 Stopped: 0
Images: 144
Server Version: 1.12.0-rc3
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 127
 Dirperm1 Supported: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: overlay host bridge null
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Security Options: seccomp
Kernel Version: 4.4.14-moby
Operating System: Alpine Linux v3.4
OSType: linux
Architecture: x86_64
CPUs: 2
Total Memory: 1.954 GiB
Name: moby
ID: MGAT:ZEGU:E4YU:J7FL:A4P6:LGF3:R7G4:54F3:UKRI:MCJ5:QGQF:DPEY
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): true
 File Descriptors: 32
 Goroutines: 66
 System Time: 2016-07-11T11:09:50.469715841Z
 EventsListeners: 8
No Proxy: *.local, 169.254/16
Registry: https://index.docker.io/v1/
Experimental: true
Insecure Registries:
 <IP_ADDRESS>/8

Additional environment details (AWS, VirtualBox, physical, etc.):
Docker mac beta 18 (build 9996)
Steps to reproduce the issue:

Clone the disappearing-node_modules branch of this repo: https://github.com/nkovacs/docker-mac-bug/tree/disappearing-node_modules
Follow the steps in the readme

Describe the results you received:
The node_modules directory is empty.
Describe the results you expected:
The node_modules directory is not empty.
Additional information you deem important (e.g. issue happens only occasionally):
This works fine on linux. Stopping the container and restarting it causes the files to reappear.

Hm, I'm unable to reproduce this, but there's some possible issues;
looking at the volumes you're defining, there's both bind-mounts and volumes;
volumes:
    - .:/var/www/app
    - ./other:/var/www/other
    - nodemodules:/var/www/app/node_modules

the /var/www/app directory is bind-mounted from your local directory, /var/www/other is also a bind-mount, but from another directory, and /var/www/app/node_modules is a volume.
I wonder if there's a possible race condition here; if (e.g.) /var/www/app/node_modules is mounted before /var/www/app is mounted, then node_modules from the current directory is masking the /var/www/app/node_modules mount, and you may end up seeing files from the bind-mount instead of the named volume.

I'm also having issues with inotify not working, but I wasn't able to reproduce it in this simplified example.
But it definitely requires the inotify watcher and a modification to cause the nodemodules volume to unmount. Just starting index.js and stopping it is not enough, neither is just modifying the file. The bug also doesn't happen when watching with inotifywait -m.

I've found the culprit: It's the two lstat calls sane does: https://github.com/nkovacs/docker-mac-bug/commit/40352e9a8b76f27f3902267ac1cb24ea9af47dae
The bug only happens if both are in there.

ping @dsheets @justincormack perhaps one of you has an idea?

Hi @nkovacs, thanks for the bug report and excellent reproduction repo. I can reproduce the issue and I am currently testing a patch to fix it which will probably be in Beta 19 to be released later this week. With my patch, I can no longer reproduce the issue.

Thanks. I figured out the other problem as well: https://github.com/docker/docker/issues/24527

Hi
Is this fix in beta 19? I can still reproduce the issue.

No, I'm sorry to say that it missed Beta 19 due to additional QA being required on it.

Hi
This is still broken in beta 21.

ping @dsheets

I am sad to say that you are correct. I can also reproduce this in beta 21 and have begun to isolate the issue (again). Thanks for your report and continued patience.

Beta 21.1 has now been released which should resolve this issue.

Thanks! I'll close this issue, but @nkovacs would be great if you could confirm it's fixed

Thanks, I'll check this and #24527 tomorrow.

Confirmed, thank you

Awesome, thanks!


RuntimeError for _reconnect_test Python unit test with Bazel

What version of gRPC and what language are you using?
gRPC version: 1.15.0.dev0 (Built from source)
Language: Python
What operating system (Linux, Windows, …) and version?
Operating System: Ubuntu
Version: 16.04 Xenial
Kernel: Kernel: x86_64 Linux 4.13.0-1013-gcp
What runtime / compiler are you using (e.g. python version or version of gcc)
Python version: 2.7.12
Bazel version: 0.15.0
What did you do?
#16335 introduces Bazel targets for grpcio Python unit tests. One of the tests is //src/python/grpcio_tests/tests/unit:_reconnect_test.
What did you expect to see?
For the test to pass, since it passes in the current build setup.
What did you see instead?
Ran into an error: RuntimeError: maximum recursion depth exceeded while calling a Python object.
Click to see full log

test_reconnect (__main__.ReconnectTest) ... ERROR
======================================================================
ERROR: test_reconnect (__main__.ReconnectTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/ghostwriternr/.cache/bazel/_bazel_ghostwriternr/273849ddb7755c644fd57a5dd5171441/execroot/com_github_grpc_grpc/bazel-out/k
8-fastbuild/bin/src/python/grpcio_tests/tests/unit/_reconnect_test.runfiles/com_github_grpc_grpc/src/python/grpcio_tests/tests/unit/_rec
onnect_test.py", line 82, in test_reconnect
    port = _pick_and_bind_port(sock_opt)
  File "/home/ghostwriternr/.cache/bazel/_bazel_ghostwriternr/273849ddb7755c644fd57a5dd5171441/execroot/com_github_grpc_grpc/bazel-out/k
8-fastbuild/bin/src/python/grpcio_tests/tests/unit/_reconnect_test.runfiles/com_github_grpc_grpc/src/python/grpcio_tests/tests/unit/_rec
onnect_test.py", line 68, in _pick_and_bind_port
    return port if port != 0 else _pick_and_bind_port(sock_opt)
  File "/home/ghostwriternr/.cache/bazel/_bazel_ghostwriternr/273849ddb7755c644fd57a5dd5171441/execroot/com_github_grpc_grpc/bazel-out/k
8-fastbuild/bin/src/python/grpcio_tests/tests/unit/_reconnect_test.runfiles/com_github_grpc_grpc/src/python/grpcio_tests/tests/unit/_rec
onnect_test.py", line 68, in _pick_and_bind_port
    return port if port != 0 else _pick_and_bind_port(sock_opt)
  File "/home/ghostwriternr/.cache/bazel/_bazel_ghostwriternr/273849ddb7755c644fd57a5dd5171441/execroot/com_github_grpc_grpc/bazel-out/k
8-fastbuild/bin/src/python/grpcio_tests/tests/unit/_reconnect_test.runfiles/com_github_grpc_grpc/src/python/grpcio_tests/tests/unit/_rec
onnect_test.py", line 68, in _pick_and_bind_port
    return port if port != 0 else _pick_and_bind_port(sock_opt)
...
...
...
File "/home/ghostwriternr/.cache/bazel/_bazel_ghostwriternr/273849ddb7755c644fd57a5dd5171441/execroot/com_github_grpc_grpc/bazel-out/k
8-fastbuild/bin/src/python/grpcio_tests/tests/unit/_reconnect_test.runfiles/com_github_grpc_grpc/src/python/grpcio_tests/tests/unit/_rec
onnect_test.py", line 68, in _pick_and_bind_port
    return port if port != 0 else _pick_and_bind_port(sock_opt)
  File "/home/ghostwriternr/.cache/bazel/_bazel_ghostwriternr/273849ddb7755c644fd57a5dd5171441/execroot/com_github_grpc_grpc/bazel-out/k
8-fastbuild/bin/src/python/grpcio_tests/tests/unit/_reconnect_test.runfiles/com_github_grpc_grpc/src/python/grpcio_tests/tests/unit/_rec
onnect_test.py", line 50, in _pick_and_bind_port
    s = socket.socket(address_family, socket.SOCK_STREAM)
  File "/usr/lib/python2.7/socket.py", line 191, in __init__
    _sock = _realsocket(family, type, proto)
RuntimeError: maximum recursion depth exceeded while calling a Python object

Can you please refactor the test to use a while loop instead of recursion instead?

That doesn't seem to be making any difference. Instead of a max. recursion depth error like here, it just keeps waiting to bind until the test timeout I set in Bazel for this test and fails.
CLI output:
test_reconnect (__main__.ReconnectTest) ... Terminated
TIMEOUT: //src/python/grpcio_tests/tests/unit:_reconnect_test (Summary)
      /home/ghostwriternr/.cache/bazel/_bazel_ghostwriternr/273849ddb7755c644fd57a5dd5171441/execroot/com_github_grpc_grpc/bazel-out/k8-fastbuild/testlogs/src/python/grpcio_tests/tests/unit/_reconnect_test/test.log

Bazel logs:
Executing tests from //src/python/grpcio_tests/tests/unit:_reconnect_test
-----------------------------------------------------------------------------
test_reconnect (__main__.ReconnectTest) ... Terminated

I'm not fully sure I understand this method though, so I could use some help. Are we sure that the socket will at some point of time surely bind to a port? Also, the port doesn't seem to be changing at all. Am I correct about that? The way the code is set up right now, it seems to be sure to fail this way if it unable to bind to a port. Is this expected behaviour?


Suggestion / Feature Request: support searching sources

Do you have any plans to support searching sources? i.e., create/learn a mapping from sources to their search url (cnn -> http://edition.cnn.com/search/?text=query) and then process the results

This would be extremely helpful (eg. https://news.google.com/news/section?cf=all&ned=us&q=query).

I'm not sure I understand why newspaper doesn't support this.  What changes need to be made for this to work?  All of my URLs which support search terms fail.


[BUG] ui -> path setting broken w/ v1.13.11

Describe the bug
Upgrading to v1.13.11 while running docker compose. I was getting these 404 errors.

I tracked it back to the ui: -> path config setting.
ui:
  path: /matches

It looks like the API isn't getting the path added to them being called from the UI.

I confirmed removing ui:-> path from my config fixed loading. But this is long term problematic as I use nginx as a auth Proxy_Pass in front of it.
Version of Double Take
1.13.11
Expected behavior
I expect the ui->path setting to not break the web interface
Hardware

Architecture or platform: x86_64, Intel(R) Celeron(R) N5095A @ 2.00GHz
OS: Ubuntu
Browser (if applicable): chrome
Docker image (if applicable) skrashevich/double-take:latest

Additional context
Nope.

Could be related to https://github.com/skrashevich/double-take/issues/90 but felt different enough to be a different issue. Please feel free to close if I'm wrong.

I confirmed removing ui:-> path from my config fixed loading. But this is long term problematic as I use nginx as a auth Proxy_Pass in front of it.

Where did you remove this? I didn't have this in my config ? And why would this be a problem for nginx in the future ?

I had this in my config: (Readme Reference: https://github.com/jakowenko/double-take#ui-1)
# ui settings (default: shown below)
ui:
  # base path of ui
  path: /matches

This was added originally here: https://github.com/jakowenko/double-take/issues/166 to support nginx proxying along side other applications.

It's an option I used for my set up, not likely that many people use this option.

Please, show HTML code of http://<IP_ADDRESS>:3000/matches/index.html (especially around  tag)

view-source: http://<IP_ADDRESS>:3000/matches/
<!DOCTYPE html>

    <meta charset="utf-8">
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
    <meta name="viewport" content="width=device-width,initial-scale=1.0">
    <meta id="theme-color" name="theme-color" content="#20262e"/>
    <link rel="icon" type="image/svg+xml" href="./favicon.svg">
    <link rel="apple-touch-icon"  href="./apple-touch-icon.png">

    <meta name="apple-mobile-web-app-capable" content="yes">
    <link href="./splash/iphone-12-pro-max.png" media="(device-width: 428px) and (device-height: 926px) and (-webkit-device-pixel-ratio: 3)" rel="apple-touch-startup-image" />
    <link href="./splash/iphone-12.png" media="(device-width: 390px) and (device-height: 844px) and (-webkit-device-pixel-ratio: 3)" rel="apple-touch-startup-image" />
    <link href="./splash/iphone-12-mini.png" media="(device-width: 375px) and (device-height: 812x) and (-webkit-device-pixel-ratio: 3)" rel="apple-touch-startup-image" />
    <link href="./splash/iphone-11-pro-max.png" media="(device-width: 414px) and (device-height: 896px) and (-webkit-device-pixel-ratio: 3)" rel="apple-touch-startup-image" />
    <link href="./splash/iphone-11-pro.png" media="(device-width: 375px) and (device-height: 812px) and (-webkit-device-pixel-ratio: 3)" rel="apple-touch-startup-image" />
    <link href="./splash/iphone-11.png" media="(device-width: 414px) and (device-height: 896px) and (-webkit-device-pixel-ratio: 2)" rel="apple-touch-startup-image" />
    <link href="./splash/iphone-xs-max.png" media="(device-width: 414px) and (device-height: 896px) and (-webkit-device-pixel-ratio: 3)" rel="apple-touch-startup-image" />
    <link href="./splash/iphone-xs.png" media="(device-width: 375px) and (device-height: 812px) and (-webkit-device-pixel-ratio: 3)" rel="apple-touch-startup-image" />
    <link href="./splash/iphone-xr.png" media="(device-width: 414px) and (device-height: 896px) and (-webkit-device-pixel-ratio: 2)" rel="apple-touch-startup-image" />
    <link href="./splash/iphone-x.png" media="(device-width: 375px) and (device-height: 812px) and (-webkit-device-pixel-ratio: 3)" rel="apple-touch-startup-image" />
    <link rel="manifest" href="./manifest.json">
    <link id="theme-link" rel="stylesheet" href="./themes/bootstrap4-dark-blue/theme.css">
    <title>Double Take</title>

    <link rel="stylesheet" href="./assets/index-baf06cb7.css">

      We're sorry but this app doesn't work properly without JavaScript enabled. Please enable it to continue.

config.yml (just in case)
logs:
  level: error

mqtt:
  host: <IP_ADDRESS>
  user: double-take
  password: not-my-password

  topics:
    frigate: frigate/events
    homeassistant: homeassistant
    matches: double-take/matches
    cameras: double-take/cameras

ui:
  path: /matches

# global detect settings.
detect:
  match:
    # save match images
    save: true
    # include base64 encoded string in api results and mqtt messages
    # options: true, false, box
    base64: false
    # minimum confidence needed to consider a result a match
    confidence: 80
    # hours to keep match images until they are deleted
    purge: 168
    # minimum area in pixels to consider a result a match
    min_area: 1250

  unknown:
    # save unknown images
    save: true
    # include base64 encoded string in api results and mqtt messages
    # options: true, false, box
    base64: false
    # minimum confidence needed before classifying a name as unknown
    confidence: 70
    # hours to keep unknown images until they are deleted
    purge: 168
    # minimum area in pixels to keep an unknown result
    min_area: 1000

# frigate settings.
frigate:
  url: http://<IP_ADDRESS>:5000
  update_sub_labels: true
  stop_on_match: true
  min_area: 2000
  labels:
    - person

  attempts:
    # number of times double take will request a frigate latest.jpg for facial recognition
    latest: 10
    # number of times double take will request a frigate snapshot.jpg for facial recognition
    snapshot: 10
    mqtt: true
    delay: 0

  image:
    # height of frigate image passed for facial recognition
    height: 720

  cameras:
    - camera_1
detectors:
  rekognition:
    aws_access_key_id: !secret aws_access_key_id
    aws_secret_access_key: !secret aws_secret_access_key
    aws_region: "us-west-2"
    collection_id: double-take
    opencv_face_required: true
    cameras:
      - camera_1

telemetry: false

try this build: ghcr.io/skrashevich/double-take:sha-524b747

Success! Thank you @skrashevich that seems to have fixed it!

seems to I can close this issue


Add support for isLoading prop for Youtube vendor

Trying to resolve issue #58

Thank you! I appreciate the PR 🙏


[Doc Issue][Update code samples in start a conversation]

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/resources/bot-v3/bot-conversations/bots-conv-proactive.md
91
13
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit 153dcee:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/resources/bot-v3/bot-conversations/bots-conv-proactive.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/resources/bot-v3/bot-conversations/bots-conv-proactive.md
91
13
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit 539ce82:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/resources/bot-v3/bot-conversations/bots-conv-proactive.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/resources/bot-v3/bot-conversations/bots-conv-proactive.md
91
13
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit 0da2dc1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/resources/bot-v3/bot-conversations/bots-conv-proactive.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/resources/bot-v3/bot-conversations/bots-conv-proactive.md
91
13
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit d63eac1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/resources/bot-v3/bot-conversations/bots-conv-proactive.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/resources/bot-v3/bot-conversations/bots-conv-proactive.md
91
13
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit 5a6d3a6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/resources/bot-v3/bot-conversations/bots-conv-proactive.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/resources/bot-v3/bot-conversations/bots-conv-proactive.md
91
13
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit a893287:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/resources/bot-v3/bot-conversations/bots-conv-proactive.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Fun with imports :)

Hey there,
Thanks for updating Ruff to support the python-black formatter!
I'm using this on Sublime Text 4 via LSP-ruff, and these are my settings:
{
  "log_debug": true,
  "lsp_format_on_save": true,
  "lsp_code_actions_on_save": {
    "lsp_format_on_save": true,
    "source.lsp_format_on_save": true,
    "source.fixAll": true,
    "source.organizeImports": true,
    "source.applyFormat": true
  },
  "clients": {
    "ruff-lsp": {
      "command": [
        "ruff-lsp"
      ],
      "enabled": false,
      "selector": "source.python",
      "initializationOptions": {
        "settings": {
          "args": [],
        },
      },
    },
  },
}

There are a few quirks that I just wanted to point out:

imports that aren't yet used automatically get removed when I save the file.

As I'm writing code, I add import statements, and instinctively hit the save button, only to find that those imports are then removed. I do like how you organize the imports, but I don't like how they disappear! Is it possible to add an additional parameter to separate these two cases.

When writing f-strings, this case is not being caught by Ruff:
my_string = f"Hello {data["name"]}"

previously python-black would catch the fact that we are using " in both the string declaration and the data dictionary. Ruff is not catching these cases, which leads to run-time errors.
Thanks for releasing Ruff, looking fowrard to more features :)

previously python-black would catch the fact that we are using " in both the string declaration and the data dictionary. Ruff is not catching these cases, which leads to run-time errors.

Can you expand on how is python-black catching this case? Is it throwing an error stating that this syntax isn't supported? I think https://github.com/astral-sh/ruff/issues/6591 would solve your use-case.

For (1), do you wish to just disable the fix and allow the editor to highlight unused imports? If so, you can use the unfixable setting to do that.
For additional context, the organize imports action isn't responsible for removing unused imports. It's the F401 rule whose auto-fix removes them and as @zanieb suggested, you could either disable the rule entirely or just disable the fix.

Going to close for now, but happy to answer any follow-up questions.

@dhruvmanila sorry I missed your reply
I used python-black in sublime text 4. For case #2, it would highlight the row when either ' or " were used incorrectly as part of the f-string.

I used python-black in sublime text 4. For case #2, it would highlight the row when either ' or " were used incorrectly as part of the f-string.

By incorrectly, do you mean that the outer and inner quotes were the same? The linked issue in my comment should solve this although how do we go about implementing it isn't final yet.


api.csswg.org/bikeshed server always returns HTML instead of accepting files

Test:
curl https://api.csswg.org/bikeshed/ -F<EMAIL_ADDRESS>-F force=1 > test.html

The output in test.html appears to be roughly the same as the source code I can see in view-source:https://api.csswg.org/bikeshed/. It didn't actually process my document.
@plinss

Disk was full on the server, should be fixed now


Fedora server install instructions that might actuall work - fixes 521

Fixes #521.
Motivated by #510 and #531.

Fedora support is long gone and these instructions are now significantly out of date anyway.  Deleting the corresponding branch.


?.?

Add two question marks.
Add two question marks.
Add two question marks.
Add two question marks.
Add two question marks.
Add two question marks.

データないかも
ウソかも


Issue: Lack of Support for URL Scheme Without HTTP/HTTPS Prefix

Tell us about the task you want to perform and are unable to do so because the feature is not available
I want to test APIs on my local server using the URL format localhost:3000 (without http://). Currently, API Dash does not support this format and returns an error, making it inconvenient to test APIs locally without explicitly adding the http:// prefix.
Describe the solution/feature you'd like us to add
Add support for URLs using the localhost:3000 format, allowing users to enter URLs without needing the http:// scheme prefix. This feature would streamline the testing process by accepting both localhost:3000 and http://localhost:3000 as valid inputs, similar to how tools like Postman handle local URLs.
Any other feedback you would like to provide regarding the site
API Dash is a great tool for testing APIs, and adding this small but useful feature would further enhance usability, especially for developers working in local development environments. Thank you for considering this improvement!
Screenshot of the issue

@userAdityaa Thanks for reporting. Yes this support will be useful.


Cannot build the image because of Oracle JDK dependency

I can't build the image from this Dockerfile. In the command line, I get a "503 Service Unavailable" error. If I visit the corresponding link from my Browser, I get the following error:
"Thank you for accessing the Oracle Software Delivery Cloud. Due to your country location, we are unable to process your request."
In short I can't build the docker image because I am located in an unauthorized country from Oracle's point of view.
I searched for the JDK in another repository, but with no success.
Do you know another repository to download the JDK ?
Do you think the docker file could be rewritten to use a repository that is more accessible across countries ?

You can either try azul or openjdk and change the docker script to pull those in.

This is now provided via azul.


Customisation of the S3 base URL

Hi,
Our company utilises AWS CloudFront for our S3 bucket(s) and I thought this would be the best place to allow that customisation.
Happy to change anything to suit your taste.
Ash.

Hi - thanks for this
Looks good - except I'd rather use 'url_host' instead of 'url_base', to be consistent with ruby's URI class, and also other uses of 'host' in dragonfly.
Also - did you know it's possible to override the url method so that any calls to 'url' go here?
c.define_url do |app, job, opts|
  if job.step_types == [:fetch]          # i.e. no processing at all
    "http://some.cloudfront.url#{job.uid}"
  else
    app.server.url_for(job, opts)     # The standard locally-served dragonfly url
  end
end

Does that suit better, or is it more confusing?
cheers
Mark

Hi Mark,
Shall I close the pull request ?
Ash.

Hi Ash - no leave it open as a reminder - I'll sort it when I get a chance to do a chunk of work on dragonfly
thanks
Mark

Thanks Mark, much appreciate it :)

merged (and changed to "host") - thanks


Add pokemongostatus.org

Hey,
I hope you don't mind adding my server status site to your readme :)

Not at all, thanks for adding.


[Fix bug 1283103] Deprecate basket subscriptions for functional areas

Coverage increased (+0.01%) to 92.617% when pulling 02f8fc5b45e398f06a971b3e29367c08c672b31f on johngian:1283103 into 218d50376d31b046111b2477e1c372afbf1e2249 on mozilla:master.

@akatsoulas r?

r+ :ship:  it


Uptick to ecto 2.2, and looking at fixing up the tests

I have upgraded to ecto 2.2, and wanted to bring this library along for the ride.
The tests were not running locally out of the box for me, so I made a few additional changes to help get them back on track.
I took insight from Question #133, as well as added a ecto_repos to the config.
Finally, I added () to timestamps to remove a warning.
11:06 timex_ecto (f/ecto22)$ mix test

11:06:32.368 [info]  Already up

11:06:32.418 [debug] QUERY OK db=4.5ms
INSERT INTO "users" ("date_test","datetime_test","datetimetz_test","name","time_test","timestamptz_test","inserted_at","updated_at") VALUES ($1,$2,$3,$4,$5,$6,$7,$8) RETURNING "id" [{2017, 9, 26}, {{2017, 9, 26}, {15, 6, 32, 374703}}, {{{2017, 9, 26}, {17, 6, 32, 374703}}, "Europe/Copenhagen"}, "Paul", {12, 30, 15, 120}, {{2017, 9, 26}, {15, 6, 32, 383857}}, {{2017, 9, 26}, {15, 6, 32, 0}}, {{2017, 9, 26}, {15, 6, 32, 0}}]

11:06:32.420 [debug] QUERY OK source="users" db=1.6ms decode=0.5ms
SELECT u0."id", u0."name", u0."date_test", u0."time_test", u0."datetime_test", u0."datetimetz_test", u0."timestamptz_test", u0."inserted_at", u0."updated_at" FROM "users" AS u0 []

11:06:32.424 [debug] QUERY OK source="users" db=2.5ms decode=0.5ms
SELECT u0."id", u0."name", u0."date_test", u0."time_test", u0."datetime_test", u0."datetimetz_test", u0."timestamptz_test", u0."inserted_at", u0."updated_at" FROM "users" AS u0 WHERE (u0."datetimetz_test" = $1::datetimetz) [{{{2017, 9, 26}, {17, 6, 32, 374703}}, "Europe/Copenhagen"}]
.............................

Finished in 0.5 seconds
29 tests, 0 failures

Randomized with seed 952809

Thanks for getting that sorted out! Much appreciated!


Multiple Abide validation after each submit

I have this code below, which is triggered once my ajax form gets submitted, it works well after on first run but after modifying the content on the form and try to click the submit button again it will trigger two instance of "valid.fndtn.abide" which results to multiple call on the form submission. As you click the submit the number of instance call multiplies.
$(entry[0]).on("submit", function (event) {
                $(this).on("valid.fndtn.abide", function(){
                    // Handle the submission of the form
                });
               event.preventDefault();
            });

I was thinking if I can reset the abide validation after successful validation so it won't be triggered multiple times. I hope you can help me on this issue.

Abide already has a listener for the submit event, so you're listening and reacting to it, as is the abide plugin.

I have just tried to use the Submit and remove the valid.fndtn.abide. What happened is that the form continues to submit even though some other requirements failed.
           $(entry[0]).on("valid.fndtn.abide", function (event) {                     // Handle the submission of the form                     console.log("good");                event.preventDefault();

This is old, but I think what you want is:
`$(entry[0]).on("submit", function (event) {
event.preventDefault();
});
$(entry[0]).on("valid.fndtn.abide", function(){
// Handle the submission of the form
});`
I.e, listen to Abide's valid event, and separately listen to the form's submit event, and prevent it's default action.


Initial commit to add more control over the ingress

Solves Issue #98 (https://github.com/Oteemo/charts/issues/98)
Allows for the user to add an additional Ingress in case they are using the ALB Ingress controller or need to use a servicePort other than the .Values.service.externalPort as the default option.

Please take a look at #101 and let me know if that will still work for your use case. Just a little cleaner way of doing it.

Agree with you 100%. Lets go with #101 instead :)


feat: user-activity page removal

Description of the change
Please provide a brief description of the changes included in this PR.

Related issues: Link to related issue(s) this PR addresses, if any (use phrases like "fixes #1234" or "closes #1234").

Screenshot(s)
If the PR includes changes to the UI, please add screenshots or a brief screengrab to demonstrate the changes.
Additional context
Please include any additional context or information that the reviewer may need to understand the PR.

@MillerSenior, I noticed some changes to the lock files (yarn.lock, go.sum, etc.).  These files typically change only when dependencies are added or modified, so the updates to the component shouldn't have impacted them.
Also, for the UserActivity page, could you please delete the code (icon, nav links, and route) instead of commenting on it? Deleting it helps keep the codebase clean and avoids confusion or issues if someone mistakenly uncomments it later. The code will still be in git history when we decide to bring it back in the future.

Looks great!


Add bin/build-development-docker script [DEV-70]

(This isn't the main thing to finish DEV-70 (that's #4815), but it's related, so I'm tagging that Jira issue here, as well.)

Closing in favor of #4817.


[Regression] AnimationPlayer click&drag Timeline scrolling

Godot version: 3.1.2 stable
OS/device including version: Win7
Issue description:
LMB click and drag on the timeline is no longer possible in 3.1, while it was possible in 3.0.6
3.1:

3.0.6:

Steps to reproduce:
Either zoom into the timeline or increase the animation length to something larger than the currently displayed time in the Animationpanel, LMB click and drag the timestamp on the timeline

You can use Middle Mouse while dragging the timestamp (but I guess it's not perfect solution).

Still valid in 3.2.3

This was probably lost in the animation editor rewrite in Godot 3.1.


Added tee log to admins as bot messages

This addition eases the debugging, especially in HA/kubernetes environments, and should be useful for customer support, as well as development. Note that when turned to debug, it will post debug log entries even if the overall server log level is lower.
cc @hanzei to consider as a Helpers feature.

Also pulled in Logger and IsUserAdmin into utils/bot.
Also updated .cicrleci scripts, the build now works. Fixes https://mattermost.atlassian.net/browse/MM-19883.

Details:
Adds config settings to turn teeing on/off and control its level and verbosity.

With these settings, the output of /msoffice subscribe looks like this,

/update-branch


starknet_in_rust executor failing with WrongValidateRetdata

Starknet in rust executor failing when executing from an account due to invalid validate return data.
Our version of account contract is not following the standard of returning the the VALIDATE return data of the __validate__ entrypoint.
We might need to modify the class implementation for the __validate__ entry point.

Update: the issue is caused by out of gas error when executing the validate entry point because the initial gas was set to 0. The return data was wrong because the actual return data that was returned by the validate call is out of gas. Unsure whether this is how the particular error is supposed to be handled by the VM or if it should be thrown as an error type. Will bring this up to upstream.


Hangs forever

First time using this so maybe I have the args wrong. I just want to autoformat a file in the current directory.
I tried this: npm-groovy-lint --format --files 'myfile.groovy'
And I'm left staring at this output:
(node:33119) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)

Using no-server worked npm-groovy-lint --format --noserver


Fix bug did from url with subpaths

Full description: https://github.com/interop-alliance/did-web-resolver/issues/20
@dmitrizagidulin please take a look when you have time

Thanks for the fix, @iliecirciumaru!


Mynewt: Define logs in packages' syscfg files

This is a Mynewt-specific PR.
Defining logs in syscfg files provides a few benefits:

Ability to set log level per module at build time.  Setting a global log level of 0 (LOG_LEVEL=0) might produce an image that is too big.  Instead, we can enable debug logging only for the modules we are interested in.

Easier to visualize system log configuration (see below).

Log modules can be remapped at build time in case of conflicts.

To see the system-wide log configuration, use either of these commands:
newt target logcfg brief <target-name>
newt target logcfg show <target-name>

@sjanc Sounds good.  I wonder if it would be difficult to move logging to NPL and still allow newt to generate the Mynewt logging macros.  If you think this PR is not the right direction, I am happy to close it so that it can be re-thought.

@sjanc Is there something else I can do with this?  Do you want me to close it?


create gtm Duplicate

Click on new page, create gtm Duplicate

We have the same issue.
Did you disable auto init?
export default {   gtm: {     autoInit: false   } }

We have the same issue.
Did you disable auto init in nuxt.config.ts? export default { gtm: { autoInit: false } }

What does autoInit: false do? It seems that after adding it, I can't see any GTM events.

Why it's closed? I still can't solve thi problem

Why it's closed? I still can't solve thi problem

has been successful, this is my code configuration
gtm: {
    enabled: true,
    // debug: true,

    id: process.env.GTM_ID,
    layer: 'dataLayer',
    variables: { sites: 'www' },

    // pageTracking: true,
    pageViewEventName: 'nuxtRoute',   // nuxtRoute and pageViewEventName

    // autoInit: true,

    scriptId: 'gtm-script',
    scriptDefer: true,
    scriptURL: 'https://www.googletagmanager.com/gtm.js',
    crossOrigin: false,

    noscript: true,
    noscriptId: 'gtm-noscript',
    noscriptURL: 'https://www.googletagmanager.com/ns.html'
  },


LTR and RTL at the same time spacing issue

I'm using Bootstrap 5 LTR and RTL mode at the same time but I get an issue with ms-2 spacing class when I switch to RTL mode not working??
the issue :

The Bootstrap Version (package.json)
"dependencies": {
   "bootstrap": "^5.0.0-beta1",
}

The Main file (app.scss)
/* rtl:begin:options: {
  "autoRename": true,
  "stringMap":[
    "name": "ltr-rtl",
    "priority": 100,
    "search": ["ltr"],
    "replace": ["rtl"],
    "options": {
      "scope": "*",
      "ignoreCase": false
    }
  ]
} */
.ltr {
    @import "~bootstrap/scss/bootstrap";
	@import "~bootstrap/scss/functions";
	@import "~bootstrap/scss/variables";
	@import "~bootstrap/scss/mixins";
}
/*rtl:end:options*/

Note : When I use the same thing in Codepen.io with CDN links it work Here is a preview link.

You're not supposed to use both CSS files in the same page, as mentioned in our docs. You may have a look at our starter template in that page, using a single CSS file.
If you need RTL and LTR at the same time, you'll need to use Sass and tweak your build a bit. But our official build (thus releases available through a CDN) won't work with both directions in the same page.
We plan to add an example template with some bidi contents in #32330 — but it's not done yet. I close this issue since it works as intended.
We'd be pleased to get any insights or suggestions you'd have to help us improve our docs or template example, though. :)


Community details: create requests tab

Similar to the “My dashboard - list requests”, a community should have a page with all requests for the community.

Duplicated: https://github.com/inveniosoftware/invenio-communities/issues/454.


MFA methods & Hardware token vs Security Key & Passwordless

Hello,

Please explain more the MFA methods
Right now if we look in this section in Azure cloud MFA: Verification code from mobile app or hardware token

Not really clear what kind of hardware token we can use, the one that shows code or hardware token as a security key?
Or does it mean we can use or code from a mobile app or code from the hardware token?

Please help to explain the behavior
If we enable the tenant to use only MFA Methods available to users:

Notification through a mobile app
Verification code from mobile app or hardware token

So no SMS or Call, we could onboard users to Security Key by Excluding user from Conditional Access policy that requires MFA, but when adding a security key in MySignins page, the message shows that user must be signed-in using MFA authentication, reload page to page where it says "More information required" and user again stuck if the user cannot use the phone...
Would be great to have some feedback on the questions above and request document review in combination with the security keys.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f132318f-8670-fd0d-2524-01305ccff2a1
Version Independent ID: 0849b4a9-ff14-1d61-47f2-a2daecf3cde9
Content: Deployment considerations for Azure AD Multi-Factor Authentication
Content Source: articles/active-directory/authentication/howto-mfa-getstarted.md
Service: active-directory
Sub-service: authentication
GitHub Login: @Justinha
Microsoft Alias: justinha

@lightupdifire
Thanks for your feedback! We will investigate and update as appropriate.

Hi @lightupdifire , I've reached out to our engineering group about this to find you a solution.
Best,
James


Android | WebView controller.canGoBack() and controller.canGoForward() are not accurate until 2 navigations

Steps to reproduce

Initialize a WebViewController with loadRequest(uri).
Include navigation buttons for moving backward and forward.
Update the button taps and colors in the onNavigationRequest method of the WebView's NavigationDelegate.

Expected results
Navigation details for forward and backward should update correctly in onNavigationRequest().
Actual results
In iOS, the WebView navigation works flawlessly. However, in Android,

controller.canGoForward() and controller.canGoBack() do not provide correct values for the first two screens.

Code sample
class MyScreen extends StatefulWidget {
  const MyScreen({super.key});

  @override
  State<MyScreen> createState() => _MyScreenState();
}

class _MyScreenState extends State<MyScreen> {
  @override
  Widget build(BuildContext context) {
    final WebViewController controller = WebViewController()
      ..loadRequest(someUri);

    final ValueNotifier<String?> urlNotifier =
        ValueNotifier<String>(constants.myURL);
    final ValueNotifier<bool> canGoBackNotifier = ValueNotifier<bool>(false);
    final ValueNotifier<bool> canGoForwardNotifier = ValueNotifier<bool>(false);

    return ValueListenableBuilder(
        valueListenable: urlNotifier,
        builder: (_, value, __) {
          return MyScaffold(
              title: value
              body: Column(children: [
                _navBar(controller, canGoBackNotifier,
                    canGoForwardNotifier, context),
                Expanded(
                  //This is a CustomClass which uses WebViewWidget
                  child: WebView(
                    controller: controller,
                    onUrlChange: () async {
                      urlNotifier.value = await controller.currentUrl();
                    },
                    //Doesn't work for either of these
                    onPageFinished: (url) async {
                      canGoBackNotifier.value = await controller.canGoBack();
                      canGoForwardNotifier.value =
                          await controller.canGoForward();
                    },
                    onNavigationRequest: () async {
                      canGoBackNotifier.value = await controller.canGoBack();
                      canGoForwardNotifier.value =
                          await controller.canGoForward();
                    }))]));});
  }

  Widget _navBar(
      WebViewController controller,
      ValueNotifier<bool> canGoBackNotifier,
      ValueNotifier<bool> canGoForwardNotifier,
      BuildContext context) {
    return Row(
      mainAxisAlignment: MainAxisAlignment.spaceBetween,
      children: [
        Padding(
          padding: const EdgeInsets.only(left: design.ComponentSpacing.small),
          child: _navigationButton(
              notifier: canGoBackNotifier,
              icon: design.Icon.arrowBack,
              onPressed: controller.goBack),
        ),
        _navigationButton(
            notifier: canGoForwardNotifier,
            icon: design.Icon.arrowForward,
            onPressed: controller.goForward),
        design.Icon.refresh.widget(
            onPressed: controller.reload),
      ],
    );
  }

  Widget _navigationButton({
    required ValueNotifier<bool> notifier,
    required design.Icon icon,
    required VoidCallback onPressed}) {
    return ValueListenableBuilder<bool>(
      valueListenable: notifier,
      builder: (_, value, __) {
        return icon.widget(onPressed: onPressed);
      },
    );
  }
}

Flutter Doctor output
[✓] Flutter (Channel stable, 3.22.2, on macOS 13.6.6 22G630 darwin-x64, locale en-GB)
    • Flutter version 3.22.2 on channel stable at /Users/vasudevkinit/Development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 761747bfc5 (3 weeks ago), 2024-06-05 22:15:13 +0200
    • Engine revision edd8546116
    • Dart version 3.4.3
    • DevTools version 2.34.3

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/vasudevkinit/Library/Android/sdk
    • Platform android-34-ext8, build-tools 34.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15C500b
    • CocoaPods version 1.14.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)

[✓] VS Code (version 1.90.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.90.0

[✓] Connected device (3 available)
    • LE2121 (mobile) • c3a2306f • android-arm64  • Android 13 (API 33)
    • macOS (desktop) • macos    • darwin-x64     • macOS 13.6.6 22G630 darwin-x64
    • Chrome (web)    • chrome   • web-javascript • Google Chrome 126.0.6478.127
    ! Error: Browsing on the local area network for iPhone 12 Pro. Ensure the device is unlocked and attached with a cable or associated with the same
      local area network as this Mac.
      The device must be opted into Developer Mode to connect wirelessly. (code -27)
    ! Error: Browsing on the local area network for iPhone. Ensure the device is unlocked and attached with a cable or associated with the same local area
      network as this Mac.
      The device must be opted into Developer Mode to connect wirelessly. (code -27)
    ! Error: Browsing on the local area network for iPhone 11 Pro. Ensure the device is unlocked and attached with a cable or associated with the same
      local area network as this Mac.
      The device must be opted into Developer Mode to connect wirelessly. (code -27)

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Hi @vasudev-kini-wdc, what version of webview_flutter & webview_flutter_android are you using? What device(s) are you seeing this on? What values do the methods return that are not correct?
Also, your code sample is not runnable, please provide a complete runnable code sample so that we can properly investigate this issue.
Thank you

Hi @danagbemava-nc. Version is 4.2.4 - which I now realize was released about 10 months prior to the latest version. Will update the code to run independently (Convert the custom WebView class to include the WebViewWidget directly) and update the package version.

Hi @vasudev-kini-wdc, I can't seem to reproduce this with the plugin example app. See the screen recording below? Am I missing something?
https://github.com/flutter/flutter/assets/88313112/82f3b298-944d-4fc6-b80f-ebbfb29c1294


Change(wiki): Combine "Custom Format Synchronization" page with "Behavior"

One other thing: Could you also mention "Fixed #60" in your commit message? That will cause the issue to be resolved when it gets merged.


Don't update a row without changes

At this moment when a row has no updated fields it will try to be saved, this has to be prevented.

This has been fixed in the latest push.


Pervent overlapping external labels in pie chart

Description
Currently when there are multiple small categories in pie chart, the external label would overlap with each other.

This change will prevent it from happening but moving down the label up on detecting overlap.

Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

[x] If this is a bug fix, did you add or update a test file to the examples directory that verifies the bug is fixed?
[ ] If this is a new feature, did you add files to the examples directory to demonstrate the feature?
[ ] If this is a new feature, did you add documentation to the docs directory for the feature?

Thanks for your contribution


No distinction between "Edit" and "Change" on image panel in french

Issue Summary

The french translation translates both "Edit" and "Change" to "Modifier", which makes the 2 buttons in the image panel have the same label (although they’re doing different things). Here’s what you get in english (correct):

And in french (incorrect):

The fix would be to change the translation of "Change" to "Changer".
Steps to Reproduce
Switch to french language and edit a page with an image chooser. I think the issue started appearing in Wagtail 4.

I have confirmed that this issue can be reproduced as described on a fresh Wagtail project: yes

Technical details

Python version: 3.9.13
Django version: 4.1.1
Wagtail version: 4.0.1
Browser version: n/a

Thanks for the report @sephii! It seems the same thing happened for the Italian translation (#9045) - there's an open ticket #9113 proposing that we change the label back to "Choose another", so I'll close this as a duplicate and bump #9113 up in priority to 4.0.2.

Thanks!

Added a bit of a summary of this underlying issue and learnings here https://github.com/wagtail/wagtail/discussions/8017#discussioncomment-3639114
Any feedback on that sub-comment would be appreciated.


Fix page move

Fix #3820

@jsma would please test this?

Grabbing lunch but will test as soon as I get back, thanks!

LGTM! I missed the fact that django-cms wraps the MP_Tree.move() calls to return a reloaded object. That gives us a consistent way of handling this then and alleviates some of my general concerns. Did you already review all types of tree modification calls or did you primarily focus on move() calls for now? I haven't fully thought it through but do you foresee any similar issues with add_root(),  add_child() or add_sibling()?

I realize now that you wrapped the move() call in this very PR. I confused myself bouncing between branches earlier and thought this must have already been in develop, guess I didn't overlook it after all. Good call on adding it in!

@jsma nope, it's been added in this PR.
This makes Page / CMSPlugin not consistent with treebeard API, but it's a small price for a much more robust implementation on our side


docs: add QandA notebook.

Related Issues/PRs

#xxx
What changes are proposed in this pull request?
Briefly describe the changes included in this Pull Request.
How is this patch tested?

[ ] I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

[x ] No. You can skip this section.
[ ] Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

[x ] No. You can skip this section.
[ ] Yes. Make sure you have added samples following below steps.

Find the corresponding markdown file for your new feature in website/docs/documentation folder.
Make sure you choose the correct class estimators/transformers and namespace.
Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
Make sure the DocTable points to correct API link.
Navigate to website folder, and run yarn run start to make sure the website renders correctly.
Don't forget to add <!--pytest-codeblocks:cont--> before each python code blocks to enable auto-tests for python samples.
Make sure the WebsiteSamplesTests job pass in the pipeline.

/azp run

azp /run

/azp run

Codecov Report

Merging #2029 (22edd3d) into master (df2712a) will decrease coverage by 82.88%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #2029       +/-   ##
==========================================
- Coverage   87.04%   4.16%   -82.88%
==========================================
  Files         306     306
  Lines       16068   16068
  Branches      860     860
==========================================
- Hits        13986     670    -13316
- Misses       2082   15398    +13316

see 294 files with indirect coverage changes

/azp run

/azp run

/azp run


Possible redundant steps in "Test Docker Image" CI job

Hey @mjhea0! There is a question concering suggested GH Actions setup:

Do we really need Build images (which included building of two images) step in "Test Docker Image" job?
It comes only after Build Docker Image job (needs: build) and docker pull ${{ env.IMAGE }}-builder:latest command (in Build images step) should always pull images were built and pushed to registry on previous job Build Docker Image, right?
It's impossible that Test Docker Image job would run before Build Docker Image (having the dependencies set), am I correct?

Also I'm not sure why we ever need to build two images and run tests + linter against ${{ env.IMAGE }}-final:latest only...?

And the related point about Deploy to Heroku job - why would we like to build images again at this step and not just pull alredy build images from previous steps?

Addressing over email...


AKSクラスター 1.26.1 にてFlacoのCrashLoopBackOff発生

AKSクラスターのバージョンを1.26.1に上げたところFalcoがCrashLoopBackOffとなり正常に稼働しなくなりました。
再起動・再デプロイ・新しいバージョンのFlacoのデプロイ・割り当てcpuの変更など行いましたが事象は解決されませんでした。
こちらの事象についてご教示いただけると幸いです。
※現在のFalcoのバージョンは1.29.1です。

My best bet is that there are issues with downloading and/or loading the kernel driver.
Incidentally we just added more info to the following 2 repos, perhaps useful as well:

https://github.com/falcosecurity/deploy-kubernetes/tree/main/kubernetes
https://github.com/falcosecurity/cncf-green-review-testing

Could you overwrite your Falco container entrypoint to something like?
command: ["/bin/sh"]
args:
  - -c
  - >-
    sleep 10000000

and after execing into the pod, launch Falco manually and tell us the error message?
What kernel driver are you using? If you can try --modern-bpf.

thank you for reporting, could you provide the Falco logs of one of the pods? Could you rewrite the issue in English, please?

English translation.
I upgraded my AKS cluster to version 1.26.1 and Falco stopped working properly with CrashLoopBackOff.
I have rebooted, redeployed, deployed a new version of Flaco, changed the assigned cpu, etc., but the problem has not been resolved. We would appreciate any information you can give us on this issue.
The current version of Falco is 1.29.1.
Confirmation.
Connect with the following command.

kubectl exec -it  -n falco

service falco start
or
systemctl start falco
and run this command (journalctl -fu falco) or is the understanding to provide logs output to /var/messages?

I tried to connect to Falco with the previous recognition, but could not confirm it due to the CrashLoopBackOff status as shown in the operation log.
Am I correct in my understanding that the repository should be added before logging?
If so, I apologize. I do not know how to add a repository due to my limited knowledge.
I would appreciate it if you could tell me how to do this as well.
sankou.txt

https://github.com/falcosecurity/falco/issues/2982#issuecomment-1863860540

My best guess is that there is a problem downloading and/or loading the kernel drivers.
BTW, I have added more information to the following two repositories. Perhaps they will be equally helpful.
・https://github.com/falcosecurity/deploy-kubernetes/tree/main/kubernetes
・https://github.com/falcosecurity/cncf-green-review-testing
Could you please overwrite the Falco container entry point with something like

I am sorry. Please let me know the procedure again about the above.

@incertum
@Andreagit97
Hello.
I apologize for my lack of knowledge.
Please let me know whatever information you need to solve the problem.
We will try to get it.
However, there are many operations that I do not know how to acquire and that is my issue.
Please help me. Please let me know how to acquire it along with the necessary information.

As a first attempt, I would try to install Falco with the modern-bpf probe, which is the easiest method we have https://github.com/falcosecurity/charts/tree/master/charts/falco#daemonset.  Happy Helming!
2024-01-15T10:20:51.7629087Z NAME: falco
2024-01-15T10:20:51.7630661Z LAST DEPLOYED: Mon Jan 15 19:20:49 2024
2024-01-15T10:20:51.7631105Z NAMESPACE: falco
2024-01-15T10:20:51.7631467Z STATUS: deployed
2024-01-15T10:20:51.7631804Z REVISION: 23
2024-01-15T10:20:51.7632196Z TEST SUITE: None
2024-01-15T10:20:51.7632611Z NOTES:
2024-01-15T10:20:51.7633104Z Falco agents are spinning up on each node in your cluster. After a few
2024-01-15T10:20:51.7633820Z seconds, they are going to start monitoring your containers looking for
2024-01-15T10:20:51.7634370Z security issues.
2024-01-15T10:20:51.7634619Z
2024-01-15T10:20:51.7634633Z
2024-01-15T10:20:51.7634867Z No further action should be required.
2024-01-15T10:20:51.7635178Z
2024-01-15T10:20:51.7635189Z
2024-01-15T10:20:51.7635330Z Tip:
2024-01-15T10:20:51.7636551Z You can easily forward Falco events to Slack, Kafka, AWS Lambda and more with falcosidekick.
2024-01-15T10:20:51.7637337Z Full list of outputs: https://github.com/falcosecurity/charts/tree/master/falcosidekick.
2024-01-15T10:20:51.7638085Z You can enable its deployment with `--set falcosidekick.enabled=true` or in your values.yaml.
2024-01-15T10:20:51.7638735Z See: https://github.com/falcosecurity/charts/blob/master/falcosidekick/values.yaml for configuration values.

It seems like you are using the wrong Falco version
2024-01-15T10:20:47.7272964Z 22      	Mon Jan 15 19:11:44 2024	deployed  	falco-1.15.2	0.29.0     	Upgrade complete

Maybe you could try to delete the actual helm deployment with
helm uninstall falco

and then try again
# to update the helm chart to the latest version
helm repo update falcosecurity --fail-on-repo-update-fail
# to run Falco with modern ebpf
helm install falco falcosecurity/falco \
    --set driver.kind=modern-bpf

@Andreagit97
Sorry for the delay in implementation.
I tried to remove Falco using the command you provided, but the output was as follows.
Is it safe to delete the daemon from the Azure portal, delete and reinsert the deployed pod?

What is the output after these 2 commands?
# to update the helm chart to the latest version
helm repo update falcosecurity --fail-on-repo-update-fail
helm show chart falcosecurity/falco

@Andreagit97
The result is as below.

By the way, the way to delete the daemon set is to delete the Falco daemon set from the portal screen below.

ok, I don't know why you have Falco deployed through Azure but I think you can remove it. At the end of the cleanup, you should check that there are no Falco instances in the cluster:
kubectl get pods -A | grep falco

This should return nothing...
If you are in this situation now you can simply deploy Falco with:
helm install falco falcosecurity/falco \
    --set driver.kind=modern-bpf

@Andreagit97
Thank you for teaching.
I immediately installed the latest version of Falco.
The results are as follows.
The problem persists despite the latest versi
20240126_開発環境_Falco最新Vserデプロイ.txt
on.
I will also send you the entire log, so please check it.

P.S.
The command you provided didn't work, so I used the upgrade command.

@Andreagit97
Don't you know the cause of this problem?
We've been investigating this for the past two weeks, but we can't find the cause.
Please let me know if you have any advice.

ei @hkinjo2 to help you we need the Falco startup logs, otherwise we cannot understand what is going on...
These are the startup Falco logs:
Sep 11 08:46:08 localhost.localdomain falco[789]: Falco version: 0.37.1 (x86_64)
Sep 11 08:46:08 localhost.localdomain falco[789]: Falco initialized with configuration file: /etc/falco/falco.yaml
Sep 11 08:46:08 localhost.localdomain falco[789]: Loading rules from file /etc/falco/falco_rules.yaml
Sep 11 08:46:08 localhost.localdomain falco[789]: Loading rules from file /etc/falco/falco_rules.local.yaml
Sep 11 08:46:08 localhost.localdomain falco[789]: The chosen syscall buffer dimension is: 8388608 bytes (8 MBs)
Sep 11 08:46:08 localhost.localdomain falco[789]: Starting health webserver with threadiness 4, listening on port 8765
Sep 11 08:46:08 localhost.localdomain falco[789]: Loaded event sources: syscall
Sep 11 08:46:08 localhost.localdomain falco[789]: Enabled event sources: syscall
Sep 11 08:46:08 localhost.localdomain falco[789]: Opening 'syscall' source with modern BPF probe.
Sep 11 08:46:08 localhost.localdomain falco[789]: One ring buffer every '2' CPUs.
...

You can obtain them by running kubectl logs <falco_pod_name>

Hi @hkinjo2, it seems that one of the initContainers is failing. Please provide the logs for those containers. To get the logs of a previous run for a given container use the --previous flag:
kubectl logs --previous -n falco  falco-7f5qx name-of-init-container-here

@alacuku
We become indebted to.
Sorry for my late reply.
I tried using the command you provided, but it still didn't work.
Please see the image.

@alacuku
Hello
Can I investigate using the information you previously provided?
Please tell us about your current situation.
It's a no-brainer at my place of work.
We apologize for any inconvenience.
Thank you very much.

@Andreagit97
We upgraded the AKS cluster to a supported version yesterday, April 4, including the possibility of isolating whether the problem was caused by AKS or by Falco. (1.27.9)
The upgrade was successfully completed, but Falco is still not resolved.
We checked the events of the pods and found the following message.
Preemption: 0/4 nodes are available: 4 No preemption victims found for incoming pod..."
Please see the attached file for the actual screen of the above message.
Therefore, we would appreciate it if you could provide us with Falco's perspective on possible causes and solutions.
Thank you in advance.

@Andreagit97
We become indebted to.
What do you think about the status of the investigation?
Due to the version upgrade of AKS equipped with Falco,
There was a difference in the container used with other normally operating Falcos, so we will cooperate.
Compared to an environment that is running normally, "falcoctl-artifact-follow" is added extra.
Originally, it was assumed that only a container called "Falco" was attached.
＝＝＝抜粋＝＝＝＝＝＝＝＝
NameSpace           NAME                                                      CONTAINERS
falco               falco-4t57h                                               falco,falcoctl-artifact-follow
falco               falco-f4h4s                                               falco,falcoctl-artifact-follow
falco               falco-xd9cz                                               falco,falcoctl-artifact-follow
falco               falco-z2s8l                                               falco,falcoctl-artifact-follow

hi folks as we told you we can help you if Falco is not working but we need logs. Please clean all your Falco instances and try this
helm repo update falcosecurity

Then
helm show chart falcosecurity/falco

the output should be something like
apiVersion: v2
appVersion: 0.37.1
dependencies:
...

Then install Falco
helm install falco \
  --set driver.kind=modern_ebpf \
  --set falcoctl.artifact.install.enabled=false \
  --set falcoctl.artifact.follow.enabled=false \
  falcosecurity/falco

if Falco doesn't work and is in CrashLoopBackOff you should provide us with the logs
kubectl logs <your-falco-instance-name>

@Andreagit97
hello
Thank you for teaching me.
However, the result was not what I expected.
I will send it along with the execution log, so please check it.
Thank you for continuing to be with me.
thank you.
falco.zip

Uhm it seems you have an already running Falco instance, you can try to delete it with
helm uninstall falco  -n falco

and then retry
helm install falco \
  --set driver.kind=modern_ebpf \
  --set falcoctl.artifact.install.enabled=false \
  --set falcoctl.artifact.follow.enabled=false \
  falcosecurity/falco

@Andreagit97
Hello,
Thank you for your guidance.
We recently conducted a reinstall of Falco.
Out of the four redeployed pods, three have successfully started up.
However, one remains in a pending state without starting up.
Attached is the event log for your review to assess if there are any functional implications.
Additionally, if there are any impacts, could you please advise on the appropriate course of action?
Thank you.
falco-rg6n9.17d171d27601c9ec_Event.yaml.zip

@Andreagit97
Thank you for your help.
I understand that this may have impacted the AKS environment.
The pending pods recovered over time.
So I think reinstalling Falco resolved the issue.
Thank you for your support so far.
I'm going to close this issue now.
Thank you.

great, I'm happy to hear that! I will close the issue

@Andreagit97
Hello.
The event you requested also occurred in a different environment.
I reinstalled Falco but this also failed.
Could you please take a look at the log for details?
I want to solve it in a hurry.
20240612_falco.txt
20240613_falco.txt


[vm/ffi] Structs API in NNBD

With NNBD, non-nullable fields need initializers or need to be late field.
Our structs API uses nun-nullable fields, without initializers - because they are replaced by getters and setters:
https://github.com/dart-lang/sdk/blob/ef0c7f16e609e84cad7411394cec9fd8b1e1e04b/tests/ffi/coordinate.dart#L11-L26
We could work around it by replacing them with late fields, but it isn't elegant.
 class Coordinate extends Struct {
   @Double()
   late double x;

   @Double()
   late double y;

   late Pointer<Coordinate> next;
 }

cc @mkustermann @lrhn

Reference to migrating breaking changes for NNBD: https://github.com/dart-lang/sdk/issues/40444.
For this API change, we can probably allow struct fields to be non-external for opted out code to ease the migration.

Proposal language: https://github.com/dart-lang/language/blob/master/working/00044 - Abstract-External Variables/proposal.md

This is not required for unforking the SDK.
For the time being, we can keep the FFI usages opted out of NNBD. (NNBD is an opt in feature.)

All tests/ffi/* now succeed on all configurations except for the analyzer.
SELECT configuration
FROM `dart-ci.results.latest_results`
WHERE suite = "ffi"
AND unexpected_result IS NOT NULL
GROUP BY configuration;

Row | configuration |
-- | -- | --
1 | analyzer-asserts-strong-linux |
2 | analyzer-asserts-weak-linux
Analyzer issue: https://github.com/dart-lang/sdk/issues/41940


C2 Hutao burst fix

now the only condition for her to apply Blood Blossoms with her burst is "if c.Base.Cons >= 2"
"c.StatModIsActive(paramitaBuff)" condition removed

closes #1217


gcp-deployer doesn't work with newer Kubernetes versions

I've tried ./gcp-deployer create -c cluster.yaml -m machines.yaml with versions 1.9.6 and 1.10.2 (for both Kubelet and control plane). Output from deployer:
I0501 19:07:57.493144   67527 deploy_helper.go:58] Starting cluster creation test1
I0501 19:07:57.493209   67527 deploy_helper.go:60] Starting master creation gce-master-test1
I0501 19:08:00.067163   67527 machineactuator.go:525] Wait for insert "operation-1525194478467-56b28031a37b9-7bfce688-f2be25a8"...
I0501 19:08:42.656880   67527 machineactuator.go:535] Finish wait for insert "operation-1525194478467-56b28031a37b9-7bfce688-f2be25a8"...
I0501 19:08:42.656922   67527 deploy_helper.go:67] Created master gce-master-test1
I0501 19:08:42.922144   67527 deploy_helper.go:210] Waiting for Kubernetes to come up...
[...]
I0501 19:12:25.747012   67527 deploy_helper.go:210] Waiting for Kubernetes to come up...
I0501 19:12:29.051570   67527 deploy.go:128] Deleting master vm gce-master-test1
I0501 19:12:30.195419   67527 machineactuator.go:525] Wait for delete "operation-1525194749405-56b2813406749-fc725735-a4008f1f"...
I0501 19:14:00.366549   67527 machineactuator.go:535] Finish wait for delete "operation-1525194749405-56b2813406749-fc725735-a4008f1f"...
I0501 19:14:00.366762   67527 serviceaccount.go:107] No service a/c found in cluster.
F0501 19:14:00.366779   67527 create.go:50] unable to write kubeconfig: timedout writing kubeconfig: timed out waiting for the condition

My machines.yaml file:
items:
- apiVersion: "cluster.k8s.io/v1alpha1"
  kind: Machine
  metadata:
    generateName: gce-master-
    labels:
      set: master
  spec:
    providerConfig:
      value:
        apiVersion: "gceproviderconfig/v1alpha1"
        kind: "GCEProviderConfig"
        project: "kawych-test"
        zone: "us-central1-f"
        machineType: "n1-standard-2"
        image: "projects/ubuntu-os-cloud/global/images/family/ubuntu-1604-lts"
    versions:
      kubelet: 1.9.6
      controlPlane: 1.9.6
      containerRuntime:
        name: docker
        version: 1.12.0
    roles:
    - Master
- apiVersion: "cluster.k8s.io/v1alpha1"
  kind: Machine
  metadata:
    generateName: gce-node-
    labels:
      set: node
  spec:
    providerConfig:
      value:
        apiVersion: "gceproviderconfig/v1alpha1"
        kind: "GCEProviderConfig"
        project: "kawych-test"
        zone: "us-central1-f"
        machineType: "n1-standard-8"
        image: "projects/ubuntu-os-cloud/global/images/family/ubuntu-1604-lts"
    versions:
      kubelet: 1.9.6
      containerRuntime:
        name: docker
        version: 1.12.0
    roles:
    - Node

cc @karan

Are you building gcp-deployer from HEAD?

cc @kubernetes/sig-cluster-lifecycle-bugs

Yes, I'm synced to commit 5d7e0ecaec541c561f6e18cb4500c11554cfa406.

Have you tried older 1.8 version? Just want to make sure it's not broken for some other reason.

I've tried 1.8.3 (default) as well and it worked for me. Didn't try any other.

@kawych This is a known bug, and was fixed in the new repo. We moved to github.com/kubernetes-sigs/cluster-api. There's a pending item to delete the cluster API from this repo.


Use path.join properly and in more places.

Doesn't fix #1931, but it's a good practice.

Coverage remained the same when pulling 23d462e5d5ccbf46bd3e6c2d2a632e2438803890 on XhmikosR:path.join into f46fe408d4e0084cd7704a9cc7ba5d28407f7ef4 on jshint:master.

Coverage remained the same when pulling c0f8e7dcc264391c1f3980e9cf68c1b70870115a on XhmikosR:path.join into f7494c84554241d068cbe899730a119272f2329b on jshint:master.

Coverage remained the same when pulling c0f8e7dcc264391c1f3980e9cf68c1b70870115a on XhmikosR:path.join into f7494c84554241d068cbe899730a119272f2329b on jshint:master.

Coverage remained the same when pulling e1e74e553694a4042c59afc9d5b9b56d6c57420d on XhmikosR:path.join into f7494c84554241d068cbe899730a119272f2329b on jshint:master.


aho-corasick should be applied for cases like \b(literal1|literal2|...|literalN)\b

Discussed in https://github.com/rust-lang/regex/discussions/890

Originally posted by Guillermogsjc July 19, 2022
Hi, to match efficiently large amounts of alternations, I guess it is interesting to trigger aho_corasick variant  here https://github.com/rust-lang/regex/blob/9ca3099037dcb2faf1b49e6493f4c758532f2da1/src/exec.rs#L91 regarding doc:

/// This is only set when the entire regex is a simple unanchored
/// alternation of literals. We could probably use it more circumstances,
/// but this is already hacky enough in this architecture.

The question is: is there any way to use word boundaries in such a way this expression is highly optimized for a thing like this?
r"\b(a|... #massive ammount of literal alternations here# ...|z)\b"

or with (?-u:\b) instead of \b .
And... regarding PERFORMANCE documentation here

there is no problem with using non-greedy matching or having lots of alternations in your regex

this previously stated regex would be in the set of "no problem" ?
Thanks

This example demonstrates why this optimization is subtle, and more generally, the difficulty of composition with respect to regex internals:
$ regex-cli count matches nfa thompson pikevm --matches 'samwise' '(?:sam|samwise)'
build pike vm time:  29.693µs
 create cache time:  658ns
        cache size:  800
       search time:  4.221µs
            counts:  [1]

PatternID(0): [0, 3)

$ regex-cli count matches nfa thompson pikevm --matches 'samwise' '\b(?:sam|samwise)\b'
build pike vm time:  26.135µs
 create cache time:  585ns
        cache size:  896
       search time:  11.146884ms
            counts:  [1]

PatternID(0): [0, 7)

The key thing here is that you can't just try to match the inner (?:sam|samwise) without regard for the surrounding word boundaries, because the surrounding \b's might change which thing gets reported.
Here are some ideas (mostly written with a future me as a target audience, so apologies if they appear cryptic):
Normally, Aho-Corasick is used with leftmost-first or "preference order" match semantics. This way, it is purely consistent with the match semantics of the regex crate. But in this case, maybe we need to use standard match semantics and execute an overlapping search. That way, we can be sure that we're guaranteed to see every possible match. So for example, this code:
use aho_corasick::{MatchKind, AhoCorasickBuilder};

fn main() {
    let ac = AhoCorasickBuilder::new()
        .match_kind(MatchKind::Standard)
        .build(&["sam", "samwise"]);
    for m in ac.find_overlapping_iter("samwise") {
        println!("{:?}", (m.pattern(), m.start()..m.end()));
    }
}

outputs:
(0, 0..3)
(1, 0..7)

So if we iterated over those matches and then tried to test whether the surrounding word boundary assertions held and reported the first one that did, we'd get the right answer here.
Unfortunately, I don't think this works in all cases. Consider this one:
use aho_corasick::{MatchKind, AhoCorasickBuilder};

fn main() {
    let ac = AhoCorasickBuilder::new()
        .match_kind(MatchKind::Standard)
        .build(&["sam the wise", "the"]);
    for m in ac.find_overlapping_iter("sam the wise") {
        println!("{:?}", (m.pattern(), m.start()..m.end()));
    }
}

outputs:
(1, 4..7)
(0, 0..12)

So if we applied our idea from above, we'd report the as the match since it's the first one reported by Aho-Corasick where the word boundary assertions are satisfied. But this would be the wrong answer:
$ regex-cli count matches nfa thompson pikevm --matches 'sam the wise' '\b(?:sam the wise|the)\b'
build pike vm time:  32.37µs
 create cache time:  601ns
        cache size:  1136
       search time:  11.419901ms
            counts:  [1]

PatternID(0): [0, 12)

The right answer is sam the wise because of leftmost-first or "preference order" matching.
I think the reason why this case fails is because \b matches at a location other then the start or end of sam the wise. Thus, there is an opportunity for a substring in sam the wise to match even if preference should be given to sam the wise.
More generally, my intuition is that for any regex of the form \b(?:re)\b, we can match re independently and then test the word boundary assertions as long as the following holds:

We report every possible match of re, including overlapping matches.
For all strings s in the language defined by re, it must be true that \b matches at s[0], s[s.len()-1], both or neither, but nowhere else.

Probably this can be generalized even further to re-left(?:re-inner)re-right.


Update protobuf-java to 3.15.0

Updates com.google.protobuf:protobuf-java from 3.13.0 to 3.15.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.google.protobuf", artifactId = "protobuf-java" } ]

labels: library-update, semver-minor

Superseded by #378.


CentralDogma may incorrectly report status as healthy when shutting down

Currently, CentralDogma shuts down resources in the following order:

sessionManager
file channels
executors
the server

https://github.com/line/centraldogma/blob/e93bc5a04eb3d38a0f315d9c5fdb0db3b0af1f52/server/src/main/java/com/linecorp/centraldogma/server/CentralDogma.java#L828-L832
As more long running tasks/repositories are added to CentralDogma (either from the API or via plugins), it is more likely that shutting down will take more time at intermediate steps.
When CentralDogma starts shutting down the actual server, health check will be turned off and the server will stop receiving requests.
https://github.com/line/centraldogma/blob/e93bc5a04eb3d38a0f315d9c5fdb0db3b0af1f52/server/src/main/java/com/linecorp/centraldogma/server/CentralDogma.java#L904
We may do one of the following:

try to shut down the server before cleaning up internal resources
set the server status as unhealthy before starting to shut down resources

Handled by #737


Proposal: Migrating to Next.js for Enhanced SEO

Hey Lukas, Thanks for starting this project!
Given the importance of SEO for the app, I suggest considering a switch to Next.js
I’m ready to tackle the migration and will prepare a PR for your review soon.

@hismethod
Unfortunately, the code mirror does not work properly in next js, and I failed to find a solution.


SerializationException

Hi,
When I started 3 CopycatServer locally, got the following exceptions.
Any idea on this?
Thanks!
16:21:04.880 [copycat-server-Address[localhost/<IP_ADDRESS>:8521]] ERROR i.a.c.u.c.SingleThreadContext - An uncaught exception occurred
io.atomix.catalyst.serializer.SerializationException: cannot serialize unregistered type: class io.atomix.copycat.server.request.PollRequest
        at io.atomix.catalyst.serializer.Serializer.writeObject(Serializer.java:589) ~[rafty-server-1.0-SNAPSHOT.jar:na]
        at io.atomix.catalyst.transport.NettyConnection.writeRequest(NettyConnection.java:180) ~[rafty-server-1.0-SNAPSHOT.jar:na]
        at io.atomix.catalyst.transport.NettyConnection.lambda$send$11(NettyConnection.java:295) ~[rafty-server-1.0-SNAPSHOT.jar:na]
        at io.atomix.catalyst.transport.NettyConnection$$Lambda$57/1712713197.run(Unknown Source) ~[na:na]
        at io.atomix.catalyst.util.concurrent.Runnables.lambda$logFailure$17(Runnables.java:20) ~[rafty-server-1.0-SNAPSHOT.jar:na]
        at io.atomix.catalyst.util.concurrent.Runnables$$Lambda$5/1555690610.run(Unknown Source) [rafty-server-1.0-SNAPSHOT.jar:na]
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [na:1.8.0_45]
        at java.util.concurrent.FutureTask.run(FutureTask.java:266) [na:1.8.0_45]
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) [na:1.8.0_45]
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) [na:1.8.0_45]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [na:1.8.0_45]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [na:1.8.0_45]

We've seen this every now and then. Was this built from master?
A little background on what you're seeing: PollRequest is a server-to-server request that's typically the first request sent in the cluster. Request types are registered with the Serializer via the Java ServiceLoader pattern and provided to the Serializer via ServiceLoaderTypeResolver. Did you do anything to change the Serializer? What does the CopycatServer.Builder look like, and what do your dependencies look like? I have never been able to reproduce this myself but have seen it come up a few times. There may be some other related issues here or in the Atomix queue

Alternatively, I would love if you could give me a reproducer in a test, gist, or in a throw away GitHub repo. Sure I could find the issue quickly.
Alternatively, the examples are known to work so you can check for differences in dependencies and what not.

On Nov 27, 2015, at 7:37 AM, Qinjin<EMAIL_ADDRESS>wrote:
Hi,
When I started 3 CopycatServer locally, got the following exceptions.
Any idea on this?
Thanks!
16:21:04.880 [copycat-server-Address[localhost/<IP_ADDRESS>:8521]] ERROR i.a.c.u.c.SingleThreadContext - An uncaught exception occurred
io.atomix.catalyst.serializer.SerializationException: cannot serialize unregistered type: class io.atomix.copycat.server.request.PollRequest
at io.atomix.catalyst.serializer.Serializer.writeObject(Serializer.java:589) ~[rafty-server-1.0-SNAPSHOT.jar:na]
at io.atomix.catalyst.transport.NettyConnection.writeRequest(NettyConnection.java:180) ~[rafty-server-1.0-SNAPSHOT.jar:na]
at io.atomix.catalyst.transport.NettyConnection.lambda$send$11(NettyConnection.java:295) ~[rafty-server-1.0-SNAPSHOT.jar:na]
at io.atomix.catalyst.transport.NettyConnection$$Lambda$57/1712713197.run(Unknown Source) ~[na:na]
at io.atomix.catalyst.util.concurrent.Runnables.lambda$logFailure$17(Runnables.java:20) ~[rafty-server-1.0-SNAPSHOT.jar:na]
at io.atomix.catalyst.util.concurrent.Runnables$$Lambda$5/1555690610.run(Unknown Source) [rafty-server-1.0-SNAPSHOT.jar:na]
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [na:1.8.0_45]
at java.util.concurrent.FutureTask.run(FutureTask.java:266) [na:1.8.0_45]
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) [na:1.8.0_45]
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) [na:1.8.0_45]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [na:1.8.0_45]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [na:1.8.0_45]
—
Reply to this email directly or view it on GitHub.

Hi
Thanks! Haven't changed any code in copycat. The code looks like this:
this.copyCatServer = CopycatServer.builder(this.serverAddress, members)
                .withTransport(new NettyTransport())
                .withStateMachine(new MyStateMachine())
                .withStorage(new Storage(storageDir, StorageLevel.MEMORY))
                .build();

The storageDir is:
System.getProperty("user.dir") + "/logs/" + serverId

The dependency in pom is:
           <dependency>
                <groupId>io.atomix.copycat</groupId>
                <artifactId>copycat-server</artifactId>
                <version>1.0.0-beta2</version>
            </dependency>
            <dependency>
                <groupId>io.atomix.copycat</groupId>
                <artifactId>copycat-client</artifactId>
                <version>1.0.0-beta2</version>
            </dependency>
            <dependency>
                <groupId>io.atomix.catalyst</groupId>
                <artifactId>catalyst-netty</artifactId>
                <version>1.0.0-rc4</version>
            </dependency>
            <dependency>
                <groupId>com.google.guava</groupId>
                <artifactId>guava</artifactId>
                <version>18.0</version>
            </dependency>
            <dependency>
                <groupId>ch.qos.logback</groupId>
                <artifactId>logback-classic</artifactId>
                <version>1.1.2</version>
            </dependency>

It works fine when I ran code from Intellij, but it threw that SerializationException when I built a jar and executed in local command line.

The built copycat jar should contain the resource META-INF/services/io.atomix.catalyst.serializer.CatalystSerializable. Depending on how you are packaging the jar in your setup, it is possible you might be missing this.

Copycat no longer registers serializers via the ServiceLoader pattern. All serializer registration is done programmatically. This should no longer be an issue.


fix: show evaluated value for action selector fields

Description
The evaluated values for text fields in action selector were not shown. This PR fixes the issue.
PR fixes following issue(s)
Fixes #12736
Type of change

Bug fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

[x] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[x] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[x] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[x] Cypress test cases have been added and approved by SDET/manual QA
[x] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/ok-to-test sha=410f54a

/build-deploy-preview env=release

/ok-to-test sha=f0b99dd

lgtm
cc: @ravikp7

/ok-to-test sha=300a904


Aborted (core dumped) in tf.raw_ops.SparseMatrixZeros

Issue type
Bug
Have you reproduced the bug with TensorFlow Nightly?
No
Source
binary
TensorFlow version
tf 2.13
Custom code
Yes
OS platform and distribution
Ubuntu 20.04
Mobile device
No response
Python version
3.8
Bazel version
No response
GCC/compiler version
7.5.0
CUDA/cuDNN version
12.0
GPU model and memory
No response
Current behavior?
Under specific input, tf.raw_ops.SparseMatrixZeros encounters "Aborted (core dumped)".
However, the parameters dense_shape and type meet the requirements in the API documentation. (https://tensorflow.google.cn/api_docs/python/tf/raw_ops/SparseMatrixZeros)
Standalone code to reproduce the issue
import tensorflow as tf
import numpy as np
dense_shape=tf.constant(value=np.random.randint(0,100,size=(1, 1)), shape=(1, 1), dtype=tf.int64)
type=tf.float64
name=None
tf.raw_ops.SparseMatrixZeros(dense_shape=dense_shape, type=type, name=name)

Relevant log output
2024-03-19 02:18:57.223847: F tensorflow/core/framework/tensor_shape.cc:45] Check failed: NDIMS == dims() (1 vs. 2)Asking for tensor of 1 dimensions from a tensor of 2 dimensions
Aborted (core dumped)

Hi @Zoeeeeey ,
I tried to run your code on colab using tf 2.16.1 and tf-nightly versions faced same issue. Please find the gist here for reference.
Thank you!

Hi, thank you for your reply. Indeed, there are crashes happening for unclear reasons, and I believe my inputs are all in compliance with the requirements. Is this an existing bug?
Additionally, I would like to ask, does the code hint Aborted (core dumped) indicate that there is a bug in the current version? @Venkat6871


Error go getting kubecfg

Tried install per docs.
$ go get github.com/bitnami/kubecfg
go get<EMAIL_ADDRESS>requires
<EMAIL_ADDRESS>requires
<EMAIL_ADDRESS>invalid pseudo-version: version before v0.1.0 would have negative patch number

$ go version
go version go1.13.8 linux/amd64

0.15.1 binary from Github Releases release works fine though

This is due to https://github.com/Azure/go-autorest/issues/449.
I guess it could be resolved by updating the contrib.go.opencensus.io/exporter/ocagent module dependency in this (kubecfg) repo?

This same problem has been raised against other repos that use opencensus - e.g. https://github.com/Azure/go-autorest/issues/449
I think kubecfg just needs to update its contrib.go.opencensus.io/exporter/ocagent dependency and cut a new release.


Native assets should be able to specify a privacy manifest

Also, we may need to add Privacy Manifest files in it.

Posted in https://github.com/flutter/flutter/issues/140544
Filing a separate issue to track this.
Issue tracking privacy manifests for Flutter packages:

https://github.com/flutter/flutter/issues/131940

I need to think a bit about where this would fit in in the build.dart flow. The BuildOutput needs to contain the information.
A completely different approach would be to force build.dart to build frameworks. This would however significantly complicate build.dart scripts (which currently output, non-fat dynamic libraries). The build.dart script would need to start knowing the install name for example.
Umbrella issue:

https://github.com/flutter/flutter/issues/129757

@stuartmorgan @SKKbySSK Do we need a privacy manifest per framework? Or should we have one per build.dart invocation and reuse it for all frameworks (one dylib per framework) that come from that dart package?

Each framework needs a privacy manifest describing its usage. For instance, if a package builds two frameworks and each one uses a different Required Reason API, then they would need different privacy manifests.
(Caveat: there's a fair amount of guesswork on everyone's part about how these rules are going to be enforced. For instance, does a framework signed by the same developer as the app—which will be the case for anything built from source—even factor into this, given that the requirements talk about third-party SDKs? We don't know, but we should prepare for that interpretation so people don't end up unable to ship their app. I didn't raise this previously because I didn't realize we had to ship these are frameworks rather than dylibs, so I thought this would be handled at the app privacy manfiest level.)

Can we overapproximate, and put too many things in a framework manifest? E.g. all permissions that are specified in the app manifest?
It would feel more natural for an app developer to specify the manifest in some sense. If an apps depends on a package that from one version to the next would output a manifest that requires more permissions, an app developer might not be aware of this at all.
On the other hand, it would be more ceremony for app developers. If a native assets package author specifies the permissions, the package "just works".

Can we overapproximate, and put too many things in a framework manifest?

Essentially everything we know about this is what's in the docs linked to in the initial issue comment. We do not know how Apple would react to a privacy manifest that included things that the binary does not do, nor is there really a mechanism other than trial and error (the pain of which would fall on Flutter developers) for doing so.
I would strongly recommend against designing a system that is predicated on knowingly making privacy manifests that are inaccurate.

It would feel more natural for an app developer to specify the manifest in some sense.

What we think is or is not more natural is ultimately irrelevant; what matters is how Apple enforces this feature.

If an apps depends on a package that from one version to the next would output a manifest that requires more permissions, an app developer might not be aware of this at all.

Presumably that is why Apple is moving to having things declared at a framework level; app developers are not necessarily going to know what the frameworks they are using do, from a privacy perspective.
To make sure this is clear though: this is not about "permissions" as that word is generally used in the app development space; nothing here is about user-granted runtime permissions (i.e., the things you get modal dialogs about while running an app). This is about a structured mechanism for things like nutrition labels and app store policy reviews.

As far as we know Apple isn't requiring this for macOS (yet).

Describe the reasons your app or third-party SDK on iOS, iPadOS, tvOS, visionOS, or watchOS uses these APIs, and check that your app or third-party SDK only uses the APIs for the expected reasons.

https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api


Issues with running compiled versions of tensorflow for different machines and CFLAGS

This is a bug  related to https://bugs.gentoo.org/show_bug.cgi?id=679714.
Here is the system information:
### System information
python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
2019-03-12 05:23:07.606918: F tensorflow/core/platform/cpu_feature_guard.cc:37] The TensorFlow library was compiled to use AVX2 instructions, but these aren't available on your machine.
Actual system is an IvyBridge non AVX2 CPU. GCC version 8.3.0. No LTO. Simple use flags.
How did this happen? I compiled tensor flow on my build machine. The build machine has loads of RAM big fans and is suited for compling stuff. I wanted to run tensorflow on my notebook, which was a bit older and more limited. I tried building tensor flow from the gentoo ebuild directly, with specific CPU flags for the CPU that I was going to run tensorflow on. I then ran into the gentoo bug 679714. This is where the libtensorflow_framework.so is missing the symbol __cpu_model (the flags I used on the build machine were -O2 -march=ivybridge -mcx16 -msahf -mno-movbe -maes -mpclmul -mpopcnt -mno-abm -mno-lwp -mno-fma -mno-fma4 -mno-xop -mno-bmi -mno-bmi2 -mno-tbm -mavx -mno-avx2 -msse4.1 -msse4.2 -mno-lzcnt -mno-rtm -mno-hle -mrdrnd -mf16c -mfsgsbase -mno-rdseed -mno-prfchw -mno-adx -mfxsr -mxsave -mxsaveopt -mtune=ivybridge -minline-all-stringops -finline-functions -fmerge-all-constants). I changed the CFLAGS to "-### O2" only and tensorflow ran fine on the build machine. I tried to run a python script (python versions 3.6 and 2.7) found was told that the CPU didn't support AVX2.

@perfinion may have an idea.
According to this, -mno-avx2 should disable avx2, but I did not go through all flags.
https://gcc.gnu.org/onlinedocs/gcc-8.3.0/gcc/x86-Options.html#x86-Options
So it is possible, within so many flags one of the enabled things is using avx2, and gcc is not handling all flag combinations correctly (which is not unheard of).

No those flags are from gcc-march=native for IvyBridge. To my knowledge and that of wikipedia there are no know IvyBridge CPUs that have support AVX2. https://en.wikipedia.org/wiki/Advanced_Vector_Extensions
There are many many things that it could possibly be, but given the fact that these flags have remained constant for a few gcc versions and when I compile and AVX2 program with explicit AVX2 code I get a compiler error, I think that the odds of it being a GCC error are small.
Anyhow, its almost the end of like for IvyBridge, so I would not worry about it, unless others are whining.