swagger schema hardocded and references ibm properties

This schema should not include IBM specific properties:
See https://github.com/apache/incubator-openwhisk-client-go/blob/1759868a61729708a8ab1a6de1b409d6e2aea00a/whisk/api.go#L153-L154
I think the entire struct should be removed anyway - it overly restricts the schema unnecessarily.

Why? this limits are applicable and valid to open source gateway

They are not ibm specific

The fields are called x-ibm-...

Yeah for backwards compatibility the it can x-ibm or “x- something else” don’t remember right now what’s the other option for the same

Both work in the api gateway

There are no references to XConfig or XRateLimit in the project - how about we remove them... actually I'd remove the entire class, I don't think these types help much anyway and just over constrain the schema ---- or as shown several times, they get out of sync.

See ongoing discussion here: https://github.com/apache/incubator-openwhisk-client-go/pull/88


decode() attempts to decode JavaScript Blob type but always fails

Currently, this results in the following fairly cryptic error message: RangeError: offset is outside the bounds of the DataView. It would be preferable to have a more useful error message.
A MessagePack blob can be obtained from a Python server sending a MessagePack over a WebSocket.

Thanks for your report. Could you show me the code to reproduce your problem?

Here you go: files.zip

@Newbytee
Thanks, but please just paste your code snippet in the issue message itself, not uploading a zip.
And to fix this problem, this is intentional. This is becauseBlob is a high-level object to provide multiple ways to obtain its content, esp. arrayBuffer() and stream(), so decoding Blob is something like this (as tested in https://github.com/msgpack/msgpack-javascript/pull/110):
// (1) via ArrayBuffer
const content = decode(await blob.arrayBuffer());

// (2) via ReadableStream
const content = await decodeAsync(blob.stream());

By the way, if you use TypeScript, it doesn't compile because decode() rejects Blob, so I recommend you to use TypeScript.

By the way, if you use TypeScript, it doesn't compile because decode() rejects Blob, so I recommend you to use TypeScript.

I'm actually using TypeScript, problem was that the function I got the Blob from has any as its return type signature (something I had not noticed previously, to be clear). I realise this is not your issue to deal with however.

And to fix this problem, this is intentional. This is becauseBlob is a high-level object to provide multiple ways to obtain its content, esp. arrayBuffer() and stream()

Got it.

I'm actually using TypeScript, problem was that the function I got the Blob from has any as its return type signature

Got it. So I'd like to add some runtime checks for it.

Now it is explained in README.md: https://github.com/msgpack/msgpack-javascript#decoding-a-blob


make launch error

Setup.sh: llvm-6.0-ex already installed.
Setup.sh: boost-1.69.0 already installed.
Setup.sh: rpclib-v2.2.1_c1 already installed.
Setup.sh: googletest-1.8.0-ex already installed.
Setup.sh: CARLA version 0.8.4-dirty.
Setup.sh: Generating CMake configuration files.
Setup.sh: Success!
BuildLibCarla.sh: Building LibCarla "Server.Release" configuration.
ninja: no work to do.
[1/1] Install the project...
-- Install configuration: "Server"
BuildLibCarla.sh: Success!
BuildCarlaUE4.sh: ERROR: UE4_ROOT is not defined, or points to a non-existant directory, please set this environment variable.
Util/BuildTools/Linux.mk:7: recipe for target 'launch' failed
make: *** [launch] Error 2
This problem has been bothering me for a long time.Please help me . Thanks.

Have you skipped the setting UE4 variable step?
You should type the following before "make launch":
export UE4_ROOT=~/UnrealEngine_4.21
where ~/UnrealEngine_4.21 is the absolute path to the installation directory of UE4 in your PC.

I've solved this problem. Thank you.
export UE4_ROOT=~/UnrealEngine_4.21 This file is best placed in the Homo directory


List All Order
curl <IP_ADDRESS>:8081/orders
[]%

(3.9-default) danielsudz@Daniels-MacBook-Pro-5 04-networking % curl <IP_ADDRESS>:8081/orders
[]%

Create an Order
curl -X POST <IP_ADDRESS>:8081/orders -d '{"customer":"Test","food":[{"Burger":{"bun":"Sesame","patty":"Beef","toppings":["Lettuce"]}}]}'

(3.9-default) danielsudz@Daniels-MacBook-Pro-5 04-networking % curl -X POST <IP_ADDRESS>:8081/orders -d '{"customer":"Test","food":[{"Burger":{"bun":"Sesame","patty":"Beef","toppings":["Lettuce"]}}]}'
created order with id 1

Delete Specific Order
curl -X DELETE <IP_ADDRESS>:8081/orders/1

(3.9-default) danielsudz@Daniels-MacBook-Pro-5 04-networking % curl -X DELETE <IP_ADDRESS>:8081/orders/1
deleted order with id 1

Delete All Orders
curl -X DELETE <IP_ADDRESS>:8081/orders

(3.9-default) danielsudz@Daniels-MacBook-Pro-5 04-networking % curl -X DELETE <IP_ADDRESS>:8081/orders

reset all orders%

Test Invalid JSON
curl -X POST <IP_ADDRESS>:8081/orders -d '{"invalid":"json"}'

(3.9-default) danielsudz@Daniels-MacBook-Pro-5 04-networking % curl -X POST <IP_ADDRESS>:8081/orders -d '{"invalid":"json"}'

Failed to parse request%

Test Invalid Path
curl <IP_ADDRESS>:8081/invalid

(3.9-default) danielsudz@Daniels-MacBook-Pro-5 04-networking % curl <IP_ADDRESS>:8081/invalid

Invalid Request%

Automated Testing
Note: automated testing has integration with real sockets so kill any running server before testing.
cargo test

(3.9-default) danielsudz@Daniels-MacBook-Pro-5 04-networking % cargo test
    Finished `test` profile [unoptimized + debuginfo] target(s) in 0.07s
     Running unittests src/lib.rs (target/debug/deps/aspirin_eats-2ee806374b24f1b2)

running 16 tests
test paths::tests::test_path_matches_delete_orders ... ok
test paths::tests::test_path_matches_orders ... ok
test food::tests::test_order_from_order_request ... ok
test http::tests::test_http_response_to_string ... ok
test http::tests::test_http_response_from_aspirin_eats_error ... ok
test paths::tests::test_path_matches_root ... ok
test db::tests::test_remove_order ... ok
test db::tests::test_reset_orders ... ok
test db::tests::test_add_get_order ... ok
test db::tests::test_get_all_orders ... ok
test paths::tests::test_path_matches_order_with_id ... ok
test paths::tests::test_path_matches_delete_order_with_id ... ok
test http::tests::test_http_request_from_str ... ok
test tcp::tests::test_read_http_packet_no_content_length ... ok
test tcp::tests::test_read_http_packet ... ok
test paths::tests::test_all_path_handler ... ok

test result: ok. 16 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.19s

     Running unittests src/bin/origin.rs (target/debug/deps/origin-8d06ef0a0e364316)

running 3 tests
test tests::test_create_and_get_order ... ok
test tests::test_invalid_request ... ok
test tests::test_root_endpoint ... ok

test result: ok. 3 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1.69s

     Running unittests src/bin/reverse_proxy.rs (target/debug/deps/proxy-ea94b58b48693098)

running 3 tests
Handling connection
Reading HTTP packet from TCP stream
Reading HTTP packet from TCP stream
Reading HTTP packet from TCP stream
RootPathHandler
[Origin] Terminated connection sucessfully
[Reverse Proxy] Terminated connection sucessfully
test tests::test_proxy_forwards_requests ... ok
Handling connection
Reading HTTP packet from TCP stream
Reading HTTP packet from TCP stream
Error while handling connection: Failed to read/write from stream
[Origin] Terminated connection sucessfully
test tests::test_invalid_http ... ok
Handling connection
Reading HTTP packet from TCP stream
Reading HTTP packet from TCP stream
Reading HTTP packet from TCP stream
RootPathHandler
[Origin] Terminated connection sucessfully
[Reverse Proxy] Terminated connection sucessfully
Handling connection
Reading HTTP packet from TCP stream
[Origin] Terminated connection sucessfully
Reading HTTP packet from TCP stream
Handling connection
Reading HTTP packet from TCP stream
Reading HTTP packet from TCP stream
[Origin] Terminated connection sucessfully
[Reverse Proxy] Terminated connection sucessfully
Reading HTTP packet from TCP stream
Handling connection
Reading HTTP packet from TCP stream
Reading HTTP packet from TCP stream
CreateOrderPathHandler
Order created with id 1
[Origin] Terminated connection sucessfully
[Reverse Proxy] Terminated connection sucessfully
Reading HTTP packet from TCP stream
Handling connection
Reading HTTP packet from TCP stream
Reading HTTP packet from TCP stream
[Origin] Terminated connection sucessfully
[Reverse Proxy] Terminated connection sucessfully
Reading HTTP packet from TCP stream
Handling connection
Reading HTTP packet from TCP stream
Reading HTTP packet from TCP stream
[Origin] Terminated connection sucessfully
[Reverse Proxy] Terminated connection sucessfully
Reading HTTP packet from TCP stream
Handling connection
Reading HTTP packet from TCP stream
Reading HTTP packet from TCP stream
[Origin] Terminated connection sucessfully
[Reverse Proxy] Terminated connection sucessfully
Reading HTTP packet from TCP stream
Handling connection
Reading HTTP packet from TCP stream
Reading HTTP packet from TCP stream
[Origin] Terminated connection sucessfully
[Reverse Proxy] Terminated connection sucessfully
Reading HTTP packet from TCP stream
Handling connection
Reading HTTP packet from TCP stream
Reading HTTP packet from TCP stream
[Origin] Terminated connection sucessfully
[Reverse Proxy] Terminated connection sucessfully
Reading HTTP packet from TCP stream
Handling connection
Reading HTTP packet from TCP stream
Reading HTTP packet from TCP stream
[Origin] Terminated connection sucessfully
[Reverse Proxy] Terminated connection sucessfully
test tests::test_proxy_complex_flow ... ok

test result: ok. 3 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 4.19s

   Doc-tests aspirin_eats

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

Clippy
(3.9-default) danielsudz@Daniels-MacBook-Pro-5 04-networking % cargo clippy
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.12s

Rubric for Assignment 4: Networking
Submission
Canvas
1: The link submitted on Canvas is for the pull request containing the assignment submission.
0: The link submitted on Canvas is not for the pull request containing the assignment submission.
Git Branch
1: The branch includes only changes for this assignment.
0: The branch includes commits or changes outside this assignment.
Git Commit Message
1: All commit messages for the branch are reasonably clear.
0: One or more commit messages for the branch are reasonably clear.
GitHub Pull Request
1: The pull request is made to the main branch of the student's fork of the course repository.
0: The pull request is made to a branch other than main or to a repo that is not the student's fork of the course repository.
Points
Submission Score: 4/4
Correctness
HTTP
Unit tests are provided for this section; for each of the three tests:
2: The test passes
1: The test fails due to a minor error
0: The test fails due to a major error
Origin Server
For each of the following API routes

GET Request to /orders
GET Request to /orders/{id}
POST Request to /orders
DELETE Request to /orders
DELETE Request to /orders/{id}
Home page (nothing or /)

2: The server responds correctly to this command with the intended behavior as documented in README.md
1: The server responds to this command, but there is a minor error in the behavior
0: There is a major error in the implementation of this pathway
Additionally, the following error types must be handled appropriately in an idiomatic, non-fatal manner and return an appropriate HTTP response (1 pt each)

Invalid JSON for an OrderRequest in a POST request
Invalid HTTP Request
Attempting to access a path that does not exist
Attempting to call an unsupported method for a path

Reverse Proxy
5: Reverse proxy correctly forwards requests towards origin server and sends response to client under a manual test
3: Reverse proxy server does not correctly forward requests and responses due to a minor error
1: Reverse proxy server does not correctly forward requests and responses due to a major error
0: Reverse proxy server was not attempted
Points
Correctness Score: 21/21
Code Quality
Design
Tests
For each of the 6 API Routes:
2: This functionality is appropriately tested with passing unit test cases, including error cases
1: This functionality has unit tests, but they don't adequately cover code path/reasonable input cases
0: This functionality has no unit tests
General Cleanliness
4: The code is effectively documented, especially for sources of user-facing errors. Additionally, function signatures are clear and the code is overall very readable.
2: Attempts at verbose documentation were made, but certain sources of error are unclear OR poor function signatures are used and readers would have slight difficulties while scanning the code.
0: Documentation is severely lacking in several places and the code is not written in a readable way.
Lint/Format
RustFmt
2: RustFmt produces no warnings when run on the changed files
1: RustFmt produces a few minor warnings when run on the changed files
0: RustFmt produces many warnings when run on the changed files
Clippy
2: Clippy produces no warnings when run on the changed files
1: Clippy produces a few minor warnings when run on the changed files
0: Clippy produces many warnings when run on the changed files
Points
Code Quality Score: 20/20
Summary
Total Score: 45/45

Add new lines to the end of msgs sent to clients in the future (:
Great work! V solid unit tests


Migrated to null-safety

@anish-adm @SAGARSURI  I would like to know when are we expecting the null safety version to be updated in the pub.dev

I guess the owner of this repo is not active. So you can this null-safety branch. I will keep it updated.


STREAMLINE-702  Factoring out join functionality from WindowedQueryBolt

Core logic from WindowedQueryBolt has been moved into Storm's JoinBolt.
WindowedQueryBolt in Streamline has now become an adapter for Storm's JoinBolt... providing any StreamLine specific customizations

+1.


Left side bar does not save position

Currently using foundry VTT 0.8.9 but able to duplicate issue with 0.8.8, and the issue occurs even with all other modules uninstalled &/or disabled.
I've found two issues that appear to be related - I'm unsure if it's specific to me, but adjusting the module settings for the "left controls position" - it will remain in place until I log out.
Upon logging back in, the left control bar isn't present - so I have to click on the foundry logo (at which point it re-appears) but it's no longer in the position that was chosen under the module settings.
As noted above, tried with all other modules uninstalled (as well as disabled), and the issue occurs with foundry VTT version 0.8.8 and 0.8.9; no error messages/notifications have been noted.

Thank you for taking the time to disable other mods and finding a relationship. Will take a look at this as soon as possible.

Hi @Wraithlord2015 I tried to reproduce this problem but I am unable to. I have a few questions:

You mention that when you log back in, the left control bar is not present. Why is this so? Nothing in this module should hide completely the left bar. Only FoundryVTT does that when you are don't have any Scene open.
Could you try resetting Minimal UI default settings to see if you happen to see any problems?
In all my tests, I tried different positions of the left side bar but even after log in and out I still see it where I left the settings.

Could you share some information on the browser you are using to use Foundry? and check again if you really have any mods enabled?
thanks

Will post additional information in this post as soon as I have it. Just acknowledging that I saw your response. ;)

Thank you for exploring this! My recommendation is to use FoundryVTT Normally and track an issue if this happens again.
ps: Windows  7 btw - come on haha :)
If it happens again, feel free to open a new issue and share what were you doing when this happened. Maybe it was an update or a module that caused settings to reset to default. Otherwise the configuration should be saved on Foundry and there are no normal reasons to edit the settings.


Modal enhancements

Added previous next to search modals.
Replaced modals on showcase page with the same material ui component as item search modals.
Changed hash for modals from #modal-11111111 to #11111111

:+1:


Modernize all the things

This PR contains a slew of changes:

Migrate to null safety (resolves #90)
Migrate to a federated plugin architecture (paves the way for #51)
Migrate to v2 Android embedding APIs (resolves #85)
Use more effective Dart guidelines in the example

As a part of this, it's worth noting that I removed the exception documentation in a few functions.
The exceptions documented should never be thrown by this plugin unless there's a bug; developers should not have to handle them.

This PR can supersede #69 because:

It supports null safety.
Platform-independent code like the URI stream is in the right spot - in #69, it's in the platform interface instead of the main plugin, which is incorrect.

@avioli may I ask if you plan on merging this pr soon? FYI, if you don't want to mantain this package anymore you can also transfer ownership to fluttercommunity.

Thank you @hacker1024

Could you please tell me when do you release the new plugin version that contains the PR?

@avioli there is no new release yet with the null-safety features ☺
Could you publish a release to pub.dev? Would be really awesome 😍


Remove generics of Client, enabling dynamic dispatch

This is an attempt to solve #106. This removes generics of Client and use Rc trait objects to do dynamic dispatch.
Breaking changes:

The type of Client is different, so users need to change their code to use this newer version. Fortunately, the change is easy, just remove anything like <C: Config>.
Config trait is different, since Debug + 'static is added as a trait bound. As long as users do not impl Config for their own type, this is perfectly fine. Otherwise, they need to impl Debug for their structs and make sure their structs don't contain non-static references.
Client::configs now returns &Rc<dyn Config>, not &C: Config.

I think this breaking change is worthwhile, since users don't need to color all their functions that use client with C: Config and this makes switching between services at runtime painless.

Hey this initiative is awesome, thanks for this. A couple questions:

Wouldn't requiring Config to be 'static make impossible to read it at run time? How would you (safely) get it from a file, for instance?

Another question, why not have a GenericClient with Config as associated type? Then the current type gets its implementation, no breaking change required. Plus one is able to specify a dyn object as Box<dyn GenericClient<Config=TheOneIExpect>>. This has precedence with the Iterator trait (Box<dyn Iterator<Item=TheOneIExpect>>). No dynamic dispatch required in the library per se, yet users are able to have it just fine.

Keep in mind I haven't thoroughly reviewed the code, so I may have made some mistakes in this comment.

Wouldn't requiring Config to be 'static make impossible to read it at run time? How would you (safely) get it from a file, for instance?

'static here does not mean only static objects can be constructed. Rather, it means a type cannot hold non-static references. A struct can have owned objects like String, i8 etc, but not &'a str unless 'a is the same as 'static

Another question, why not have a GenericClient with Config as associated type?

I think you are moving generics from a place to another. Ideally, a client should be agnostic to configs in terms of functionalities and type signatures. And honestly, I don't think dynamic dispatch and generics don't make much difference in terms of performance. We've already spent trillion of cycles to run transformers after all. Programming ergonomics matters more in my opinion. But it's not the case in Iterator.

@64bit hey I saw new releases getting published and new PR getting merged while this PR got no feedback. Do you have any comments?

This does look like moving in right direction long term, and similar to how it looked before Azure support.
I recalled why Generics were used in first place - so that differences in Azure and OpenAI can be handled in type safe manner.
But now Azure OpenAI service not available to everyone, and with growing drift between Azure and OpenAI spec just means that long term async-openai should just drop support for Azure OpenAI service. And so this PR is in right direction.
Now breaking change in this is really breaking, and so moving in this direction means this is one way and not going back (type safe API for two platforms)
So we target this to be released in next version bump? v0.18.0, if yes do you mind updating this PR?
Thats all I have on the topic.

I recalled why Generics were used in first place - so that differences in Azure and OpenAI can be handled in type > safe manner.
But now Azure OpenAI service not available to everyone, and with growing drift between Azure and OpenAI spec just means that long term async-openai should just drop support for Azure OpenAI service.

I see. I rely on both Azure and OpenAI. I recently took a closer look at the differences between Azure and OpenAI's APIs. Except headers and API versioning, they work almost the same. Recently because OpenAI dramatically changed their APIs, Azure and OpenAI APIs diverges a lot, but I think Azure's APIs of a newer version will converge again with OpenAI's.
The premise to remove generics of Client is that APIs of the two are not so different, but for now the premise does not hold unfortunately. If Azure is still supported, then we should wait and see Azure's APIs of a newer version that converge again. If Azure support is drop in v0.18.0, then I think we can just go ahead.
Off topic a bit:
I'm afraid we will eventually have to manage multiple sets of APIs of different versions with different concrete implementations. Azure does API versioning properly and OpenAI for now just break things and move fast, but I guess, from the fact that OpenAI marks their APIs as v1 in their API base (i.e. https://api.openai.com/v1), they will come up with a totally different set of APIs probably in v2. When it comes true, we will also need to decide whether to support v1 in Config and how to do the dispatch (like generics "static dispatch" or dynamic dispatch).

Hello @ifsheldon
Would you like to get this into next version bump, perhaps v0.19.0 or v0.20.0?
It seems not worth holding too long for uncertainties surrounding Azure. Not having access to it is tough to maintain changes related to it. So I'd be completely relying on you for testing.
This PR would also be beneficial to dynamic dispatch to other LLMs / AI providers fully compatible with OpenAI.

Yeah. Noteworthy is that after merging updates from main, a few tests failed to compile due to tokio::spawn which requires Send, so I had to add more trait bounds (Send and Sync) to Config trait and use Arc in Client.

I think Azure support is still fine, incomplete though, because only latest version of Azure APIs is and will be compatible with OpenAI's. For example, I think this crate, as of now, can only support 2023-12-01-preview version of Azure APIs, which is basically the same as OpenAI's APIs.

Ah nice, anything on Azure that works with latest of OpenAI is good.
Please feel free to repurpose/augment the note about Azure in README for documentation.

I think I've got a better idea. In https://github.com/64bit/async-openai/pull/125/commits/639eaa4fe58f2557b2c13f6c15f45a6d042d5643 , I added BaseConfig and a new Config with generics and a generics default. API users can now opt in extra configs at the cost of writing their own Client. The only issue is that API users need to impl BaseConfig instead of previously Config, which is a breaking change.
With this, any differences in difference LLM services/deployments can be handled in a type safe manner. API users just need to impl Config<SomeExtraDataType> and propagate this generic and extra data to where needed. Client now accepts any types impl Config<()>, which is ensured by a blanket impl as long as they impl BaseConfig.
We could make Client generic with a default as well, like
pub struct Client<ExtraConfigs = ()> {
    http_client: reqwest::Client,
    config: Arc<dyn Config<ExtraConfigs>>,
    backoff: backoff::ExponentialBackoff,
}

but I think it's over generic for now.
Tell me what you think @64bit

That's a clever approach.
I see that blanket  Config<()> would be the case for dynamic dispatching. However, from the library user perspective any non-blanket case would requires them to write separate code anyway - and so type for extra config must be manage in user application  - without it being built into async-openai - for example as a separate function parameter or generic type for function parameter.
Moreover extra_config() is not used in the library itself, so that also suggest it can live outside library and in user's application.

OK, make sense.
When I rethink about making Config generic, it occurs to me that various Config implementations are not enough but various Clients that make requests based on configs. So probably we should factor functionalities of the existing Client into traits. For example, a client impl ChatClient trait will have create and create_stream methods (factored from existing Chat).
Then we will/can have OpenAIClient that impls ChatClient, ImageClient etc, and a AzureClient can impl a different set of these functionality traits. Any other backend can also have their own client structs, but with unified interfaces defined by traits.
But this would be a radical change.
For now, I will revert https://github.com/64bit/async-openai/commit/639eaa4fe58f2557b2c13f6c15f45a6d042d5643

Thats a good idea too. However, we want to keep things simple without falling into overengineering trap, above all, just working with openai should be prioritized even if that means library doesn't work with any other providers.
The assumption with other providers is that they provider compatible API, if APIs differ significantly then it would become a nightmare to maintain and so async-openai should limit scope to work well with just one provider that is OpenAI.

However, we want to keep things simple without falling into overengineering trap, above all, just working with openai should be prioritized even if that means library doesn't work with any other providers.

yeah, that would be async-litellm in Rust.

It seems not worth holding too long for uncertainties surrounding Azure. Not having access to it is tough to maintain changes related to it. So I'd be completely relying on you for testing.

If you feel like ready, you can merge this before next release. I think now I don't have anything major to add. And tests seem fine.

Thank you @ifsheldon, I'll give it one last review.
Hey @deipkumar, this was your feature request - do you wanna take it for test drive and provide us any feedback (you're also welome to review the PR)  before this makes it a release?


Show prices with or without taxes

Allow the admin to display prices with or without taxes.

yes, this feature should e added immediately

yes, this feature should e added immediately

Hi @ghermans
I agree with @jnikhil652 this should be sorted out on a high priority basis.
For example:
As per the current User Flow:
User comes to website > Visit product page with Price showing as $100 > User takes action for buying the product > During checkout, Addition of extra 10% ($10) of excluded tax increased the total price to $110 which in turn reduces the chances of buying the product.
So for a better conversion rate, It is very important to provide an inclusive of all taxes option on the product page itself.
It should be like

Thanks

Hi @ghermans
I agree with @jnikhil652 this should be sorted out on a high priority basis.
For example:
As per the current User Flow:
User comes to website > Visit product page with Price showing as $100 > User takes action for buying the product > During checkout, Addition of extra 10% ($10) of excluded tax increased the total price to $110 which in turn reduces the chances of buying the product.
So for a better conversion rate, It is very important to provide an inclusive of all taxes option on the product page itself.
It should be like

Thanks

Hi @parasbhadauria,
As we have already mentioned, this feature request will be added to the upcoming releases.
Since this is a community request,  we also want to give contributors the opportunity to provide this functionality.
This is why we do not provide a schedule when it will be implemented and mark it as low priority.
If you still want this to be treated with high priority, the functionality can still be developed faster by our team with a schedule for a fee.
You can create a ticket on https://bagisto.uvdesk.com/en/customer/create-ticket/, we will then make a quote for you.

Hi @parasbhadauria,
As we have already mentioned, this feature request will be added to the upcoming releases.
Since this is a community request,  we also want to give contributors the opportunity to provide this functionality.
This is why we do not provide a schedule when it will be implemented and mark it as low priority.
If you still want this to be treated with high priority, the functionality can still be developed faster by our team with a schedule for a fee.
You can create a ticket on https://bagisto.uvdesk.com/en/customer/create-ticket/, we will then make a quote for you.

Hi @ghermans,
I am starting to work on it.


Symbols: Default value for the “Image” property

A user suggested that the „Image” property should get a default value (for example the first sprite) to give immediate feedback that the layer is working.

It's common to have a symbol layer without the icon-image set, text labels for example. Is there something I'm missing?

It's common to have a symbol layer without the icon-image set

Yes, icon-image is optional.
I think what is requested here, is to show a default image if the value of icon-image is an empty string.
I'm afraid such a behaviour would be more confusing than it would help.
To check if a symbol layer is working in general, it is possible to put some random text in the text-field.
There are also use cases where it is intended to have an empty string for icon-image, e.g. to be able to set layout properties which require icon-image and set the value of icon-image based on user interaction later in an application.
The cause for this survey feeback might be that there is currently no information available in the editor regarding which images are available in a sprite used by the style and the user therefore needs to know how to get this information elsewhere.
To show/list the available images in a sprite somewhere in the editor would be a nice feature.

@pathmapper so I guess there's nothing to do here, shall we close it.

Yep.


Added sci chat workshop (properly)

Added sci-chat workshop's ARR commitment deadline
https://sites.google.com/view/dialogue-evaluation/

Thanks for the updated PR. It looks like you have an older version of the file though.
I went ahead and copied your addition into the site. Let me know if I missed anything.

Thank you for taking care of it!


fix: Llama3_1ChatWrapper types

Description of change
Fix the type mismatch in the Llama3_1ChatWrapper constructor.
Fixes #349
Pull-Request Checklist

[X] Code is up-to-date with the master branch
[X] npm run format to apply eslint formatting
[X] npm run test passes with this change
[X] This pull request links relevant issues as Fixes #0000
[N/A] There are new or updated unit tests validating the change
[N/A] Documentation has been updated to reflect this change
[X] The new commits and pull request title follow conventions explained in pull request guidelines (PRs that do not follow this convention will not be merged)

Thanks for the PR!
The _specialTokensTextForPreamble parameter is internal and should not be exposed.
I fixed this issue by hiding the _specialTokensTextForPreamble option from the function signature in the transpiled types in #351.
I'll release it in the next few days.


Install with Antigen

Can I install this through antigen as well? ✌

I'm not too experienced with Antigen, but it probably won't work since this is an executable and needs to be in the $PATH, and not sourced at startup.


python:3.10-bullseye has Python 3.9 instead

VSCode Version: 1.73.1
Local OS Version: Windows_NT x64 10.0.19045
Local chip architecture: 64-bit
Reproduces in: Remote - Containers
Name of Dev Container Definition with Issue: python:3.10-bullseye

Steps to Reproduce:
1 .devcontainer.json
{
	"name": "Python 3",
	"image": "mcr.microsoft.com/devcontainers/python:3.10-bullseye",
	"features": {
		"ghcr.io/devcontainers/features/node:1": {
			"version": "lts"
		},
		"ghcr.io/devcontainers/features/common-utils:1": {},
		"ghcr.io/devcontainers/features/git:1": {},
		"ghcr.io/devcontainers/features/nvidia-cuda:1": {},
		"ghcr.io/devcontainers/features/python:1": {},
		"ghcr.io/rocker-org/devcontainer-features/pandoc:1": {},
		"ghcr.io/devcontainers-contrib/features/pylint:1": {},
		"ghcr.io/devcontainers-contrib/features/tox:1": {}
	},

	// Use 'forwardPorts' to make a list of ports inside the container available locally.
	// "forwardPorts": [],

	// Use 'postCreateCommand' to run commands after the container is created.
	"postCreateCommand": "pip3 install --user -r requirements-test.txt",

	// Configure tool-specific properties.
	// "customizations": {},

	// Set `remoteUser` to `root` to connect as root instead. More info: https://aka.ms/vscode-remote/containers/non-root.
	"remoteUser": "vscode"
}

2 Terminal
vscode ➜ /workspaces/genca (dev ✗) $ python
Python 3.9.2 (default, Feb 28 2021, 17:03:44)
[GCC 10.2.1 20210110] on linux
Type "help", "copyright", "credits" or "license" for more information.

See that Python 3.9 is installed instead of 3.10.

@BorjaEst You included the "ghcr.io/devcontainers/features/python:1": {} feature which will default to installing the OS version of python and including that in the path.  If you only want the tools in the python feature, set version to none.
"ghcr.io/devcontainers/features/python:1": { "version": "none" }

@Chuxel, that solved the issue, thanks!


feat: add prefix topics

Fixes #30
BREAKING CHANGE to add support for prefix topics
Users can subscribe to any path (root or subpath) to receive value updates to their callback

Published https://www.npmjs.com/package/ntcore-ts-client/v/3.0.0-beta.1

This is great, however it does not seem to be compatible with the topicsOnly flag, I only want to receive the names/types of all topics, not all of the data from them, is there some way to do this? When I subscribe to a prefix key with topicsOnly: true, the callback never gets called.

Also, I noticed that if I am subscribing to a prefix topic of "/" that normal subscriptions stop working (never recieve updates for them). As soon as I comment out allTopics.subscribe(/*...*/) it works as normal.

Thanks for letting me know, I'll try to get some time this weekend to spin up a simulator to test this

Sounds good, thanks for your work on this

I've done some more experimenting and noticed that the problem is that when I subscribe to the "/" prefix and then attempt a subscription to a double[], I get a bunch of ZodErrors. When I remove it, it works as expected.

@nab138 can you provide a minimal reproducible example please?


#195 Added bail option, clean processes if bailing early

@jamiebuilds Any chance I could get a review :)

@jamiebuilds we're finding our builds are not very informative without executing with --no-bail - would be great to get this in ASAP. Or @lukebatchelor?

Hi @kayneb / @Dahaden , apologies, I didnt actually see this come through till Kayne messaged me this week.
Taken a look and it LGTM, I'll give Jamie a quick ping and see if he's fine with me just merging it.
Thanks heaps for the contribution! I'll ping you once its released


Fix selfupdate when beta channel is not set

I don't know why this issue started to happen, maybe something changed in the SDKMAN API, but every time I tried to run sdk selfupdate, it was failing with some HTML output.
❯ sdk selfupdate
bash: line 1: syntax error near unexpected token `newline'
bash: line 1: `<!DOCTYPE html>'

Debugging it, I noticed that it was trying to curl --silent --location 'https://api.sdkman.io/2/selfupdate?beta=', and the failure was about beta not being set.
This makes the beta_channel configuration set to false by default.

If you type sdk config, do you see an entry for sdkman_beta_channel?
Could it be that you've accidentally that entry?

I checked that. Actually, if I write beta_channel=false in my config the issue is gone as well.
I believe the issue can be replicated anywhere, I just don't actually know how to install an older version of sdkman to simulate an upgrade.

Hi @felipecrs, nothing has really changed in the backend that I'm aware of to cause this behaviour. Both the install and self-update scripts ensure that these config variables are set. This code has never really changed. I guess that you might have deleted it from your config by accident. Might that be possible?
Be that as it may, let's keep an eye on it to see if anyone else experiences this problem. If there really is an issue, I would prefer to fix the root cause rather than adding such defensive code.

I guess that you might have deleted it from your config by accident. Might that be possible?

@marc0der, is it mandatory to be set in my config? I thought that I could omit the configs in which I would like to use the default.

This error can be replicated:
❯ docker run -it --rm mcr.microsoft.com/vscode/devcontainers/java:0.201.5-15 bash -c 'rm -f $SDKMAN_DIR/etc/config && exec bash -ic "sdk selfupdate"'
We periodically need to update the local cache. Please run:

  $ sdk update

bash: line 1: syntax error near unexpected token `newline'
bash: line 1: `<!DOCTYPE html>'
```

@felipecrs I really don't think we need to document this. Nobody is deleting the configs from their config files, and you would be the first person ever to report a problem about this. My best advice: just leave them as they were intended to be, then nothing will break. We even go so far as to ensure that all configs are present in the /etc/config on every self-update.

The other option is to check if the variable is defined in the selfupdate function, without having to set it in the init. Should I change the implementation of the fix?

@marc0der can you please review again? I'm using a less intrusive approach now.


Is it possible to display multiple F2 views?

Does APP_VIEW_TRIGGER always assume only a single view is visible at a time?  I'm working on an application where our “settings” view is more of an overlay than a single view, and it might be necessary for changes in it to update the main app view in the background. Is it possible to do this while still treating this as an “F2 view”?  If not, does the ability to display an f2 view without hiding another seem like a useful feature, or am I misunderstanding the point of views?

Views are being removed in v2.


Finished processes always show with a warning

When a process finishes, the dashboard shows it with a warning. But I believe this to be incorrect. When a process exits with code 0 it's successfully completed. So the dashboard shouldn't display a warning at all.
I am running several processes to migrate databases in Python and I only want to see a warning when the migration tool fails.
Is it possible to change this behavior?

I agree this behavior is strange. We can fix it post GA.
cc @kvenkatrajan

Perhaps we can use the regular variant (non-filled) of the same checkmark icon and with the underline, like this?

Hello ! Can I take this one as my first issue on Aspire ?

@pierrebelin You just need to have a resource added that will run to completion, e.g. just calling dotnet --version
var builder = DistributedApplication.CreateBuilder(args);

builder.AddExecutable("dotnet-version", "dotnet", Environment.CurrentDirectory, "--version");

builder.Build().Run();

Appreciated @DamianEdwards ! I've created the PR related to this issue with the icon you named

Thanks for fixing this @pierrebelin. Choosing this issue as completed.


Usage of new @CreationPolicy annotation breaks AggregationTestfixture

Introduction of annotation @CreationPolicy that was added by #667 breaks AggregationTestfixture. Here is the reason:
In AggregationTestFixture, every registered repository is wrapped inside a IdentifierValidatingRepository, which should override loadOrCreate() in order to delegate it to the actual repository impl. Something like:
@Override
public Aggregate<T> loadOrCreate(String aggregateIdentifier, Callable<T> factoryMethod) throws Exception {
            return delegate.loadOrCreate(aggregateIdentifier, factoryMethod);
}

Without this overriding, every call to loadAndCreate() will skip the actual impl of this method and use the default one instead.

Thanks for marking this issue @vitorarrais, but the problem has luckily already been resolved in this pull request. Hence, I will be closing this issue as a duplicate. We intent to release 4.3.1, containing this fix, next week.


Minor Improvements

Merged cakephp-plugin-template v2.1.0, which brings tests/test_app setup.
Added repository badges.

Current coverage is 0.00% (diff: 100%)

Merging #9 into master will not change coverage

@@           master    #9   diff @@
===================================
  Files           3     3
  Lines         151   151
  Methods        14    14
  Messages        0     0
  Branches        0     0
===================================
  Hits            0     0
  Misses        151   151
  Partials        0     0

Powered by Codecov. Last update 1ebb7b4...6d00279


Handle errors from __gc metamethods

This handles errors from __gc metamethods as well as any other errors that are not caught by xpcall.

looks nice, will merge as soon as tests run.

Thanks, let me verify that the test runs and passes with Lua 5.2/5.3.  I am only able to test with 5.1 on my system.

Ok, I was able to fix the unit test for Lua 5.2/5.3.  Everything should be good to go now.

very nice! Thank you!


Azure SQL testing on macOS

The Azure SQL (which is SQL Server 2017 underneath) needs to be tested with a computer running macOS. Since Catalina, Apple has been really picky about what kind of TLS certificates they accept.
This means, that any of the following points will cause a TLS error when connecting to the server:

RSA keys < 2048 bits
SHA-1 signatures
DNS Names in certificates

Microsoft has an article about certificate requirements, and another on SHA-1 deprecation.
What needs to be done here is to launch an Azure SQL server, run macOS Catalina and try to see how hard it is to set the TLS requirements so we can connect to the machine. This might also need to be addressed by the documentation team later on.

We should be able to tackle this via https://github.com/prisma/e2e-tests/issues/969 as well.


Merge annotations package into constant package

Merge annotations package into constant package
Signed-off-by: zounengren<EMAIL_ADDRESS>

Why?


Bump boto3 version to 1.34.39 for acktest library

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/ok-to-test

/retest

/retest

/retest

/retest

/retest

/retest


Nuitka in azure devops pipeline

Hey
I am using python 3.9.12 and nutika 0.7.6. I am trying to automate the creation of exe using build azure devops pipeline which was done manually in my local machine. The command works perfectly in my local machine but when running through the pipeline, the generated exe is small in size(29mb instead of 70mb) and exiting without an error on running in the local command prompt. All the dependency files and folders are already provided in the command.
The only discrepancy I could find is the mistmatch of acrhes but in the command I have used --mingw64, --assume-yes-for-downloads, --onefile &  --windows-disable-console.  --plugin-enable=tk-inter $(System.DefaultWorkingDirectory)\myFile.py used for python file.  All the required folder and files are present in the azure repository.
I am installing nuitka using pip in the pipeline.

No issue template no fun, and very old Nuitka too.


Add an agnostic redirect action

This adds an action to platform, called redirect. This action was originally written to handle redirecting to off-site urls so that we could redirect to reddit-live. This seemed awfully similiar to the /u/* -> /user/* redirect handler in mweb, so it seemed appropriate to also handle relative urls (this could be removed, but it seems very useful to have). With support for both absolute and relative urls, with server-friendly redirects this could be the canonical action for changing urls if we wanted it to be.
👓  @nramadas @phil303

:nail_care:

Can you add that description (or something similar) to the commit message?

:phish:

Squashed and with a new commit message, :haircut_man:

:tropical_fish:


"Download the hands-on tutorial" 404

there is a link on mbrace webpage that says "Download the hands-on tutorial" and points to https://github.com/mbraceproject/MBrace.StarterKit/blob/master/azure/brisk-versions.md but GitHub show the 404 page.

Thanks for pointing that out. I think it is fixed now.


Slider is not accessible via keyboard

Pressing tab on Shared room checkbox focuses More filters. Similarly pressing shift + tab on More filters focuses Shared room checkbox. Skipping the slider control in both forward and backward navigation.
Please find the stated behavior in the below animation.

For expected keyboard interaction, please refer WAI-ARIA Authoring Practices - Slider (Multi-Thumb).
And I guess for the slider button you would prefer to use<button> instead of <div>. Please check out Use button if you mean it for further details.

Thanks for filing @sarbbottam :)
From what I understand there's only one issue concerning rheostat and that's if we should use <button> instead of <div>.
I did not choose <button> initially because the slider handles aren't meant to act as buttons. There's nothing to "press" or "click" about them. I only care about keyboard interaction and when someone drags them around.
After reading your article as well as Nicholas', which you link to at the end, I'm still not sure <button> is the appropriate element to use here but I'd love to hear your thoughts on this.

I think what we really want it to behave like is a <input type="range">, but since the native range slider is unavailable as a standalone element, I think <button type="button"> would be the best analog (ie, keyboard+mouse -focusable and interactive). That you can't click on it is fine, I think, because it'd just be a noop.

I did not choose <button> initially because the slider handles aren't meant to act as buttons.

@goatslacker you are right.
button semantic is not appropriate. It could be any focusable element with role="slider".
As @ljharb mentioned, <button> seems to be the best match.

I think <button type="button"> would be the best analog

Options

add tabindex=0 and role="slider" to the existing divs.
div are meant for container, I personally would not use it for any other purpose

replace div with button and add role="slider", also update the style to make the button look like slider thumb in the current UI.

may be something else ...

Irrespective of the approach chosen, on keydown,

Must
Right Arrow and Up Arrow increase the value of the slider.
Left Arrow and Down Arrow decrease the value of the slider.
Good to have
Home and End move to the first and last values of the slider.
Page Up and Page Down optionally increment or decrement the slider by a given amount.

FYI the main reason why this isn't keyboard accessible is not because of the fact that it's a div (the tabIndex value allows it to be tabbed to). It's because there is an explicit tabIndex value set (in this case 1 and 2), which means that this slider will get tabbed to when unexpected (the 1st and 2nd elements on the page) and not get tabbed to when expected (in the natural flow of elements). Additionally, the slider controls lack any sort of highlight for when they have focus, resulting in a confusion of when they have focus. The fix would be to not allow passing in a particular tabIndex and always setting tabIndex to 0, in addition to adding any proper aria roles necessary.


Tracking issue for migration from rust-crypto to supported crates

Since rust-crypto is unmaintained, pwhash should probably be migrated away from using it for all digest and encryption algorithms (except DES, which is in-tree). There are independent crates for MD5, SHA1 and SHA2. There is nothing that I know of for bcrypt, so I'll probably move it in-tree from rust-crypto.

[ ] MD5
[ ] SHA1
[ ] SHA2
[ ] bcrypt

Take a look at RustCrypto organization. It has all hash functions you need and DES implementation too. (though not yet published) There is also a bcrypt crate, but it will need a bit of work.

Revisited for v0.2.0: bcrypt is still missing in RustCrypto, so I see no pressing reason to proceed with porting.

You can use @Keats bcrypt crate, it's not part of RustCrypto (though I would be happy to see it change), but it does the job.


ImportError: cannot import name 'Adadelta' from 'keras.optimizers'

System information.

OS Platform and Distribution (e.g., Linux Ubuntu 16.04):  window 10   ~for Python notebook
TensorFlow installed from (source or binary): pip install --upgrade tensorflow        ~for both colab and pyhton Notebook
TensorFlow version (use command below): 2.6     ~both colab and pyhton Notebook
Python version: Python 3.7.12 (google colab) / 3.8.8 (python Notebook)
GPU model and memory: google colab/ for Notebook: Intel(R) Core(TM) i5-1035G1 CPU@ 1.00 GHz /memory: 8 gb
Exact command to reproduce: from bidaf.models import BidirectionalAttentionFlow

Problem.
I have been trying to recreate bidaf model. But it has been keep throwing me below error. I have installed all six mentioned dependencies. Don't know how to fix this issue. Here's the link of my google colab notebook. Both Python and colab are giving me same error.
Describe the current behavior.
ImportError: cannot import name 'Adadelta' from 'keras.optimizers' (C:...........\AppData\Roaming\Python\Python38\site-packages\keras\optimizers.py)
Describe the expected behavior.
It should import Adadelta after installing Bidaf-keras model. I can see it already there in the located path.
Standalone code to reproduce the issue.
from bidaf.models import BidirectionalAttentionFlow
link of Colab/Jupyter/any notebook
Here's my google colab

@ReetuData please provide access for google colab

@kumariko, I have changed the authorization. You might be able to access it now. Let me know if you are still having issue.
Thanks

@jvishnuvardhan Was able to reproduce the issue in TF v2.6  please find the gist here.Thanks!

@ReetuData I think this is more related to bidaf-keras. May be the location of adadelta need to be updated in bidaf-keras.
I took very simple mnist model and ran with adadelta optimizer without any issues. Please check the gist here. Thanks!


Show table view progress bar color

Thank you for the PR!
Please remember to add a before and after screenshot(s) on any css changes!
Progress bar should be blue for shows that are continuing and have all the episodes

Yup, looks good. Thanks!


Add compio::main macro as a wrapper of compio::task::block_on

Perfect work! I only have only some small requirements to fix.
Would you consider refactor all examples to use this macro? We can also change the README to use it.

Off course.

As a next step, I will implement the test macro and replace all test functions with it.


prometheus: 2.27.1 -> 2.30.3

Motivation for this change
Needs update, there are some syntax shown on ie. blackbox-exporter that does not work on the current version of prometheus (I think).
Things done
I have updated the version numbers + hashes.
However, they have changed yarn out with npm, which has caused some headache.
They have also added a module system, that is currently working OK with a hack that needs to be changed...
I have ran the prometheus tests and they pass without any issues.
TODOs

[x] Cleanup code, ie. remove unused packages, buildInputs, etc.
[x] Update webui update script

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg test prometheus

@eyJhb I'm trying to upgrade to the latest prometheus-2.31.0 and I noticed they moved the web/ui package to npm workspaces. Any idea how to update your pkgs/servers/monitoring/prometheus/webui/update-web-deps.sh to this new way?

@eyJhb I'm trying to upgrade to the latest prometheus-2.31.0 and I noticed they moved the web/ui package to npm workspaces. Any idea how to update your pkgs/servers/monitoring/prometheus/webui/update-web-deps.sh to this new way?

It just seems to be sugar on top of npm, and nothing more. Currently it just builds the two components independently, and then fixes the paths.
Should that be any issue? The webui works fine when I tested it :) - Are you available on Matrix for discussing any miscommunication? :)

It just seems to be sugar on top of npm, and nothing more. Currently it just builds the two components independently, and then fixes the paths.

The issue is that they now have a single package-lock.json file in web/ui instead of two separate ones in web/ui/module/codemirror-promql and web/ui/react-app/.

Should that be any issue? The webui works fine when I tested it :)

At the moment the package doesn't build. But maybe I can try just using that single package-lock.json for the two packages.

Are you available on Matrix for discussing any miscommunication? :)

I'm not and TIL about Matrix. I'll look into signing up. Where can I do that?

It seems this is ready to merge. We can do the 2.31.0 upgrade in another PR. Merging in now...

It seems this is ready to merge. We can do the 2.31.0 upgrade in another PR. Merging in now...

Oh, didn't notice a new version had come out. Sorry!
Hopefully it can be fixed soon. Seems annoying that Prometheus cannot settle on anything, and keeps changing it around.
But what can one do ... :)
Thanks for merging @basvandijk ! :)


Function.toString() does not work as expected with @Annotation

Function.toString() seems to ignore the annotations added to the parameters.
Example:
void main() {
  print((@MyAnnotation() String data ) {});
}

class MyAnnotation {
    const MyAnnotation();
}

Dart VM print:
Closure: (String) => Null

Perhaps the correct behavior should be:
Closure: (@MyAnnotation() String) => Null

Is there any reason to omit this or is this a bug?

I'm pretty sure this is working as intended.
The string being printed is the type of the closure. The annotation is not part of that, it's just something which exists in the source code (and might be accessible using dart:mirrors).
While it's probably possible to make the closure toString include the source text of annotations, it will certainly have some runtime-cost. (Also, on the web there is no need to retain annotations at all, since there is no dart:mirrors. Don't know if the VM can exclude them when compiling for Flutter too.)

Thanks for the quick response @irhn.
I understand that the main use of annotations is in reflection, but I feel this is not expected behavior as annotations have been declared.
That's why it looks like a bug to me.
Would it be too expensive to do this?

This is working as intended. We don't include annotations into AOT snapshots to save space and neither does dart2js. We could change this in JIT - but that would introduce a discrepancy between JIT and AOT.
Also note that the annotation is attached to the parameter not the parameter's type - so it is actually strange to include it when parameter name itself is not included into the toString output.


[ENH] - Add kubernetes horizontal autoscaler for conda-store workers based on queue depth

Feature description
Currently conda-store is set to allow 4 simultaneous builds at once.  This is a bottleneck once multiple environments start getting built at once and presents a scaling challenge. If we set the simultaneous builds to 1 and autoscale based on queue depth then we should be able to handle scaling far more gracefully
Value and/or benefit
Having the conda-store workers autoscale based on queue depth will allow larger orgs to take advantage of Nebari without hitting scale bottlenecks.
Anything else?
https://learnk8s.io/scaling-celery-rabbitmq-kubernetes

Options
We have two options to achieve this:

Horizontal Pod Autoscaler
KEDA (Kubernetes-based Event-driven Autoscaling)

Option#1 Horizontal Pod Autoscaler based on external metrics and a load monitor/watcher.
Ref: https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale-walkthrough/
The sequence of events:

Build watcher queries the conda-store database every 5 seconds and populates the total number of queued workers.
Horizontal autoscaler takes this value as an external metric to scale on:

- type: External
  external:
    metric:
      name: queue_messages_ready
      selector:
        matchLabels:
          queue: "worker_tasks"
    target:
      type: AverageValue ## This needs to change accordingly.
      averageValue: 0

Horizontal Pod Autoscaler (HPA) creates new pods according to queued workers.

Option#2 KEDA (Kubernetes-based Event-driven Autoscaling)
Ref:
https://blogs.halodoc.io/autoscaling-k8s-deployments-with-external-metrics/
https://keda.sh/docs/2.13/scalers/
https://keda.sh/docs/2.13/concepts/external-scalers/
https://keda.sh/docs/2.13/scalers/rabbitmq-queue/
https://keda.sh/docs/2.13/scalers/redis-cluster-lists/
https://keda.sh/docs/2.13/scalers/redis-lists/
https://keda.sh/docs/2.13/scalers/postgresql/
The PGSql scaler allows us to run a query on a database. Which means we can simply point it  towards the existing conda-store database to get the queue depth of pending jobs.
Pros and Cons
Option#1

Components added

Metrics Server
Horizontal Pod Autoscaler
A Queue like RabbitMQ
Custom service to manage the Queue

Pros

Light weight
Components like RabbitMQ and Metrics Server can be re-used if needed.

Cons

Requires managing the queue and queue-manager service.
Its a bit hacky solution

Option#2

Components added (ref)

Metric adaptor
Contoller
Scaler
Addmission webhooks

Pros

Single purpose but elegant solution based on HPA.
No customization needed, its full featured and provides an extendable options of scheduling scalers.
Same machinesum can be reused to scale other services in future.

Cons

The only Metrics adoptor can be re-used by other services.

Should this be part of conda-store?
Regardless of the option we take, this can be moved upstream to conda-store.

Points in favour of moving this to conda-store

It solves a conda-store problem and touches only conda-store components.
Moving it to conda-store can make it available for all the other conda-store

Points in against of moving this to conda-store

Since conda-store is a core component of Nebari, we can rely on it being there. Therefore we can reuse KEDA to scale other pods as and when needed. This will become an issue in the highly unlikely event if we decide to move away from conda-store.
We will need to figure out if this is in line with long term road-map of conda-store.

We should agree on these before we start. Please suggest. Thanks.

@pt247 Conda store already has a queue, it is using redis and celery. I expect we can pull queue depth from that, so we shouldn't need to deploy extra infra there. The nebari-conda-store-redis-master stateful set is what you are looking for.
I am unfamiliar with KEDA, but it does look promising and has a redis scaler too. In general I prefer to use built in solutions as my default, so the horizontal autoscaler was my first thought, but if KEDA allows for better results with less complexity then I can see going with that. KEDA is a cncf project that seems to be actively maintained, so that is good.
As to whether this solution belongs in conda-store, I will simply say, it does not. Conda-store allows for horizontal scaling by having a queue with a worker pool. That is where conda-store's responsibility ends. Building specific implementation details for scaling on Nebari into conda-store would cross software boundaries and greatly increase coupling between the projects. That would be moving in the wrong direction. We want to decrease coupling between conda-store and Nebari. conda-store has a method for scaling horizontally, it is on Nebari to implement autoscaling that fits its particular environment.

Seems like this issue should be in the conda store repo

We want to decrease coupling between conda-store and Nebari. conda-store has a method for scaling horizontally, it is on Nebari to implement autoscaling that fits its particular environment.

Either KEDA or the horizontal autoscaler would work here and both can be used to scale automatically using the queue depth. I think that KEDA seems a bit more elegant with its implementation so would suggest using that to start to see if it works and if for some reason it doesn't, then falling back to the horizontal autoscaler.

Notes on POC
Installing KEDA:
helm repo add kedacore https://kedacore.github.io/charts
helm install keda kedacore/keda --namespace dev

Scaled job spec:
apiVersion: keda.sh/v1alpha1
kind: ScaledObject
metadata:
  name: scaled-conda-worker
  namespace: dev
spec:
  scaleTargetRef:
    kind:          Deployment                               # Optional. Default: Deployment
    name:          nebari-conda-store-worker  # Mandatory. Must be in the same namespace as the ScaledObject
  triggers:
  - type: postgresql
    metadata:
      query: "SELECT COUNT(*) FROM build WHERE status='BUILDING' OR status='QUEUED';"
      targetQueryValue: "0"
      activationTargetQueryValue: "1"
      host: "nebari-conda-store-postgresql"
      userName: "postgres"
      password: "{nebari-conda-store-postgresql}"
      port: "5432"
      dbName: "conda-store"
      sslmode: disable

I am getting the following error:
│ 2024-04-05T18:44:42Z    ERROR    Reconciler error    {"controller": "scaledobject", "controllerGroup": "keda.sh", "controllerKind" │
│ : "ScaledObject", "ScaledObject": {"name":"scaled-conda-worker","namespace":"dev"}, "namespace": "dev", "name": "scaled-conda-work │
│ er", "reconcileID": "17f8e76e-7f9d-4e9e-90e4-77dde8a455d4", "error": "error establishing postgreSQL connection: failed to connect  │
│ to `host=nebari-conda-store-postgresql.dev.svc.cluster.local user=postgres database=conda-store`: server error (FATAL: password au │
│ thentication failed for user \"postgres\" (SQLSTATE 28P01))"}

UHm this is a strange behaviou, I think there might be something missing... I will try to reproduce this on my side as well

I have also tried TriggerAuthentication:
apiVersion: v1
kind: Secret
metadata:
  name: conda-pg-credentials
  namespace: dev
type: Opaque
data:
  PG_PASSWORD: "xxxxxxxxxxxxxxxxxxxxxxxxxxxxx"
---
apiVersion: keda.sh/v1alpha1
kind: TriggerAuthentication
metadata:
  name: keda-trigger-auth-conda-secret
  namespace: dev
spec:
  secretTargetRef:
  - parameter: password
    name: conda-pg-credentials
    key: PG_PASSWORD
---
apiVersion: keda.sh/v1alpha1
kind: ScaledObject
metadata:
  name: scaled-conda-worker
  namespace: dev
spec:
  scaleTargetRef:
    kind:          Deployment                 # Optional. Default: Deployment
    name:          nebari-conda-store-worker  # Mandatory. Must be in the same namespace as the ScaledObject
  triggers:
  - type: postgresql
    metadata:
      query: "SELECT COUNT(*) FROM build WHERE status='BUILDING' OR status='QUEUED';"
      targetQueryValue: "0"
      activationTargetQueryValue: "1"
      host: "nebari-conda-store-postgresql"
      userName: "postgres"
      port: "5432"
      dbName: "conda-store"
      sslmode: disable
    authenticationRef:
      name: keda-trigger-auth-conda-secret

This worked:
apiVersion: keda.sh/v1alpha1
kind: TriggerAuthentication
metadata:
  name: trigger-auth-postgres
  namespace: dev
spec:
  secretTargetRef:
  - parameter: password
    name: nebari-conda-store-postgresql
    key: postgresql-password
---
apiVersion: keda.sh/v1alpha1
kind: ScaledObject
metadata:
  name: scaled-conda-worker
  namespace: dev
spec:
  scaleTargetRef:
    kind: Deployment
    name: nebari-conda-store-worker
  triggers:
  - type: postgresql
    metadata:
      query: "SELECT COUNT(*) FROM build WHERE status='BUILDING' OR status='QUEUED';"
      targetQueryValue: "1"
      host: "nebari-conda-store-postgresql"
      userName: "postgres"
      port: "5432"
      dbName: "conda-store"
      sslmode: disable
    authenticationRef:
      name: trigger-auth-postgres


A Pallet for Benchmarking Common Runtime Operations

This is a pallet which is meant purely to benchmark individual operations commonly performed throughout the runtime. It serves no logical purpose, and probably this PR should not be merged in where the Benchmark pallet is included in the runtime.
Also introduces a small update to the benchmark! macro to allow for custom functions to be inserted directly into the string matching logic from the CLI so that fully custom benchmarks can be written parallel to the pre-designed benchmarking framework.
This is useful for timing non-extrinsic functions as is done here for current_time and storage_root.
Question: Is there a way to place a feature flag over this in the runtime?

@shawntabrizi please merge master and resolve the conflict.

@shawntabrizi looks like something went wrong, CI tests failing.


Build failure with not finding linux/idxd.h in container

When I tried to use DTO in container(Ubuntu 20.04) and it will build failure with:
gcc -shared -fPIC -Wl,-soname,libdto.so dto.c -D_GNU_SOURCE -DDTO_STATS_SUPPORT -o libdto.so.1.0 -laccel-config -ldl
dto.c:15:10: fatal error: linux/idxd.h: No such file or directory
   15 | #include <linux/idxd.h>
      |          ^~~~~~~~~~~~~~

Dockerfile such as:
# base-OS-image for build
ARG OS_VER=20.04
ARG OS_IMAGE=ubuntu
FROM ${OS_IMAGE}:${OS_VER} AS baseimage
RUN apt-get update && DEBIAN_FRONTEND="noninteractive" TZ="America/Los_Angeles" apt-get install -y build-essential git cmake autoconf libtool pkg-config uuid-dev numactl libevent-dev asciidoc libjson-c-dev gdb

ARG DTO_VERSION="1.0"
ARG DTO_URL="https://github.com/intel/DTO/archive/refs/tags/v$DTO_VERSION.tar.gz"

RUN curl -fsSL "$DTO_URL" -o dto.tar.gz && tar -xzf dto.tar.gz
RUN cd DTO-$DTO_VERSION && \
    make libdto && make install

A workaround is copy the idxd.h from accel to /usr/local/include

I think the proper way is to install kernel-headers package. Have you tried that?

Which kernel header for Ubuntu 20.04? I don't find it in Ubuntu web.

It seems on Ubuntu kernel-headers package is called linux-libc-dev.

Ubuntu 20.04 install linux-libc-dev_5.4.0-159.176_amd64.deb by default which doesn't work. which version should I use?


where is ReactiveContext.stop() in (1.3.7)

I'm using this code with angular-meteor#1.3.7
ReactiveContext = $reactive(this).attach($scope)

and according to the 1.3.6 docs I'm supposed to call stop() manually. but I cannot find it in 1.3.7

stop
This method takes care of stopping every subscribe, autorun and helpers registration you created.
Note that this method is called automatically when using $scope with your reactive context, which means you need to call this method manually when you do not use $scope.

I did find a stop() method on the subscription handle. is it enough just to call that?

    $scope.$on '$ionicView.enter', (e)->
      subHandle = ReactiveContext.subscribe 'collection'

    $scope.$on '$ionicView.leave', (e) ->
      subHandle.stop()

const context = $reactive(this).attach($scope)
context.stop()
// or
this.stop()

It's working on the latest release :)


stats.taxonworks.org - roles last week

For 335 new sources I should have more than 335 roles.

Only roles unique to that project are shown.  Source roles are Community, so they don't appear there.


The website icon is not shown

Describe the Bug
The favicon.ico don't show, but the file is stored in a public directory.
Steps to Reproduce
open bookstack website
Expected Behaviour
The website display favicon.ico
Screenshots or Additional Context

Browser Details
No response
Exact BookStack Version
BookStack v22.04.1
PHP Version
8.0.20
Hosting Environment
Red Hat Enterprise Linux 7

I added the following code to resource/views/layouts/base.blade.php and it worked.
<link rel="icon" href="{{ versioned_asset('favicon.ico') }}">

I confirm, the problem is similar. Only the standard favicon is displayed

Hi @GongMingCai and @Statium,
Are you hosting your instance on sub-paths? For example: https://example.com/wiki

yes

yes


Can Ensemble-Pytorch integrate multiple different models? [Support heterogenous models to be aggregated]

RT

Hi @timewaitsfor, I would be very happy if you could provide some suggestions on the design pattern of MixWrapper as you suggested.
I have been thinking that it may not be a good idea to design a class that takes heterogenous models as the input, and condut a training stage on all of them, because the configuration on learning rate, batch size, etc., could be quite diverse for different models to achieve good performance. If we cater to all of these configurations, the input to the MixWrapper may be quite complex.
Instead, how about we provide a wrapper for trained base estimators? In such case, we take all fitted base estimators along with the test loader as the input, and we can then evaluate the accuracy, or other callbacks of these base estimators on the test loader. As to the training stage, it is up to you to decide how to train each of them.

Hi @timewaitsfor. This feature request will be involved after the version 0.1 released. Thanks for bringing us this feature request!


Running on Windows - almost

This is issue is both help for others that haven't gotten this far and an unresolved problem tht I need help with.  Here is what I did to get what I have so far.  Maybe this will help other people.
First, I downloaded the latest python version 2.7 here: https://www.python.org/ftp/python/2.7.16/python-2.7.16.msi
Once downloaded, I double clicked the file to start the installer.  I took all the defaults EXCEPT when it asks what modules to install.  All are selected by default except the path variables.   I switched those to full on.  Then I let the installer do its thing for the remainder.
If you don't include the paths in the install, it wont work right.
Clone the archiver files from github to a zip file.  Open the zip file and copy yahoo.py and yahoogroupsapi.py to c:\python27\scripts .
Open the command prompt: Start->run->CMD->Enter
Enter "path" to make sure the c:\python27 is in the path correctly.
On the command line, enter "pip install requests"
You should have something like this so far:
=================
Microsoft Windows XP [Version 5.1.2600]
(C) Copyright 1985-2001 Microsoft Corp.
C:\Documents and Settings\Dennis>path
PATH=C:\Python27;C:\Python27\Scripts;C:\WINDOWS\system32;...
C:\Documents and Settings\Dennis>pip install requests
Collecting requests
Downloading https://.../requests-2.22.0-py2.py3-none-any.whl (57kB)
100% |UUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUU| 61kB 435kB/s
Collecting certifi>=2017.4.17 (from requests)
Downloading https:///.../certifi-2019.9.11-py2.py3-none-any.whl (154kB)
100% |UUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUU| 163kB 547kB/s
Collecting urllib3!=1.25.0,!=1.25.1,<1.26,>=1.21.1 (from requests)
Downloading https://.../urllib3-1.25.6-py2.py3-none-any.whl (125kB)
100% |UUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUU| 133kB 547kB/s
Collecting idna<2.9,>=2.5 (from requests)
Downloading https://.../idna-2.8-py2.py3-none-any.whl (58kB)
100% |UUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUU| 61kB 1.3MB/s
Collecting chardet<3.1.0,>=3.0.2 (from requests)
Downloading https://.../chardet-3.0.4-py2.py3-none-any.whl (133kB)
100% |UUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUU| 143kB 409kB/s
Installing collected packages: certifi, urllib3, idna, chardet, requests
Successfully installed certifi-2019.9.11 chardet-3.0.4 idna-2.8 requests-2.22.0 urllib3-1.25.6
You are using pip version 18.1, however version 19.3.1 is available.
You should consider upgrading via the 'python -m pip install --upgrade pip' command.
Now the part that doesn't seem to work right.  On the command line, I entered:
"yahoo.py -f -us UserName -pa Pass -ct "MY T COOKIE"  -cy "MY Y COOKIE"  mygroupname"
The "-f" is so that it will only copy everything from the group files section.
I get:
===========
logging in...

Fetching directory 'ExPCB Helper' (1/32)
Fetching file 'ExpcbHelper.zip' (1/1)
Traceback (most recent call last):
File "C:\Python27\Scripts\yahoo.py", line 471, in
archive_files(yga)
File "C:\Python27\Scripts\yahoo.py", line 167, in archive_files
archive_files(yga, subdir=pathURI)
File "C:\Python27\Scripts\yahoo.py", line 160, in archive_files
yga.download_file(path['downloadURL'], f)
File "C:\Python27\Scripts\yahoogroupsapi.py", line 65, in download_file
r = self.s.get(url, stream=True, **args)
File "C:\Python27\lib\site-packages\requests\sessions.py", line 546, in get
return self.request('GET', url, **kwargs)
File "C:\Python27\lib\site-packages\requests\sessions.py", line 533, in request
resp = self.send(prep, **send_kwargs)
File "C:\Python27\lib\site-packages\requests\sessions.py", line 646, in send
r = adapter.send(request, **kwargs)
File "C:\Python27\lib\site-packages\requests\adapters.py", line 514, in send
raise SSLError(e, request=request)
requests.exceptions.SSLError: HTTPSConnectionPool(host='xa.yimg.com', port=443): Max retries exceeded with url: /df/expresspcb/ExpcbHelper.zip?token=K...&type=download (Caused by SSLError(SSLError(1, u'[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:727)'),))

====================
So it croaks on SSL somehow.  I do not have an E cookie.  Not sure if this is relevant, but where is it getting the name "ExpcbHelper" from?  The name of the group is 'expresspcb' not 'ExPcb'.
Anybody know how to make it work the rest of the way?

I don't know why the above post went all giant letters like that.  When I tried to edit the post, it wouldn't let me.

Running a second time made it cough in a different spot.  One of the files was "docs *.txt" which is an illegal file name in windows.  I logged onto the group and renamed that file and it downloaded all the files successfully (I think).  When I switched to photos "-i", it coughs up the following error:
[code]
logging in...

Fetching album 'Miscellaneous' (1/8)
** Fetching photo 'cropped_jpg_from_PDFCreator' (1/4)
Traceback (most recent call last):
File "C:\Python27\Scripts\yahoo.py", line 474, in
archive_photos(yga)
File "C:\Python27\Scripts\yahoo.py", line 200, in archive_photos
yga.download_file(photoinfo['displayURL'], f)
File "C:\Python27\Scripts\yahoogroupsapi.py", line 65, in download_file
r = self.s.get(url, stream=True, **args)
File "C:\Python27\lib\site-packages\requests\sessions.py", line 546, in get
return self.request('GET', url, **kwargs)
File "C:\Python27\lib\site-packages\requests\sessions.py", line 533, in request
resp = self.send(prep, **send_kwargs)
File "C:\Python27\lib\site-packages\requests\sessions.py", line 646, in send
r = adapter.send(request, **kwargs)
File "C:\Python27\lib\site-packages\requests\adapters.py", line 514, in send
raise SSLError(e, request=request)
requests.exceptions.SSLError: HTTPSConnectionPool(host='xa.yimg.com', port=443): Max retries exceeded with url: /kq/groups/NMlqG3HtetRkme_Fng--/or/lYU
a5WXredkRuxlMeQ--/name/ExpressSCHcrop.jpg (Caused by SSLError(SSLError(1, u'[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:727)'),
))
[/code]

I'm unsure what is causing the certificate verification failures for you. Initial suspicion was that Root CA Certificates weren't available for your python installation, but your first post shows the certifi package being installed, which contains them and will be used. Unsure how to progress from here, holding this open until I can think further about it.

I've also had this on Linux and macOS.

I think yahoo is playing games with us.  I ran the exact same code and it worked flawlessly.  Maybe it needs to have two attempts before it gets all its registers set right.

I'm getting this fairly consistently on files and photos.  Run once and you get the error.  Run twice and it works fine.  However, on messages, it does it only when there is an attachment to download and re-running it doesn't fix it.  It goes by "can't download attachment" ones without a problem, but then failed when it apparently found an attachment to download.

** Yahoo says this message has attachments, but I can't find any!

Fetching message #4527 of 4576
** Fetching attachment 'clock face - rotor.jpg'
Traceback (most recent call last):
File "C:\Python27\Scripts\yahoo.py", line 468, in
archive_email(yga, save=(not args.no_save), html=args.html)
File "C:\Python27\Scripts\yahoo.py", line 116, in archive_email
atts[attach['filename']] = yga.get_file(photoinfo['displayURL'])
File "C:\Python27\Scripts\yahoogroupsapi.py", line 54, in get_file
r = self.s.get(url)
File "C:\Python27\lib\site-packages\requests\sessions.py", line 546, in get
return self.request('GET', url, **kwargs)
File "C:\Python27\lib\site-packages\requests\sessions.py", line 533, in request
resp = self.send(prep, **send_kwargs)
File "C:\Python27\lib\site-packages\requests\sessions.py", line 646, in send
r = adapter.send(request, **kwargs)
File "C:\Python27\lib\site-packages\requests\adapters.py", line 514, in send
raise SSLError(e, request=request)
requests.exceptions.SSLError: HTTPSConnectionPool(host='xa.yimg.com', port=443): Max retries exceeded with url: /kq/groups/_8AmBUzrftcrm1mt/or/mj6eksr
tfNHWhXCAZWjj/name/clock+face+-+rotor.jpg (Caused by SSLError(SSLError(1, u'[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:727)'),
))

My hunch is that some of the load balancers that serve xa.yimg.com are missing their intermediate certificate chain certificates, making certificate verification fail for clients.
I found that simply retrying the request would result in a connection that would get served a proper SSL response.

Fixed by #44

@dossy I found that retrying would often lead to the same error happening over and over. Therefore the fix.

@d235j - yeah, it's a coin-toss - if your request gets sent back to the same worker that is missing the intermediate certificate chain, the request will keep failing.  I guess I just got lucky every time, in that on retry, my request went to a different worker that presented a cert I could verify.


Remove function GetTimestamp of ConsensusState interface

This function has been marked as deprecated in https://github.com/cosmos/ibc-go/pull/5353, so now it just needs to be removed. It would seem natural to me to do this in v9, together with the 02-client routing refactoring, so that's why I am adding it to that milestone. Since v9.0.0 will be the first major release where the deprecation notice is given, then we should remove it in v11.

Hi @crodriguezvega, could I take this PR for now, or do we need to wait until v9 is released?

Hi @crodriguezvega, could I take this PR for now, or do we need to wait until v9 is released?

Thank you for reaching out, @neitdung. We have decided to not remove it yet, so this issue can still wait. v9 will be the first major version where the deprecation notice will be effective, and our policy is to wait at least for two major releases before remove deprecated code.


Update governance.md

Updated the following:

Corrected a selling error in my name
Changed my role to OSPO team member & LF Energy TAC member for Alliander
Added that Maarten is LF Energy TAC member for GXF

Signed-off-by: Jonas van den Bogaard<EMAIL_ADDRESS>

Can one of the admins verify this patch?


Add some functions

This is untested, and certainly incomplete,  which is why it's just a draft PR (hopefully that doesn't ping anyone).


cleanup download example

add import statement (otherwise throws error on op.exists)
correct space formatting on line data_files=...

Closing as stale.


Lexical Converter Missing

Documentation Issue
https://payloadcms.com/docs/lexical/converters#lexical-jsx
The documentation states that the RichText component can be found here:
import { RichText } from '@payloadcms/richtext-lexical/react'

but this is not the case.
I am getting this error:
TS2307: Cannot find module @payloadcms/ richtext-lexical/ react or its corresponding type declarations.

@Sharlmagne What payload version are you using?

@AlessioGr
version v3.5.0
"dependencies": {
"@hookform/resolvers": "^3.9.1",
"@payloadcms/db-postgres": "latest",
"@payloadcms/next": "latest",
"@payloadcms/richtext-lexical": "latest",
"@payloadcms/storage-vercel-blob": "latest",
"@radix-ui/react-aspect-ratio": "^1.1.0",
"@radix-ui/react-avatar": "^1.1.1",
"@radix-ui/react-dialog": "^1.1.2",
"@radix-ui/react-icons": "^1.3.2",
"@radix-ui/react-label": "^2.1.0",
"@radix-ui/react-separator": "^1.1.0",
"@radix-ui/react-slot": "^1.1.0",
"@zapal/payload-lexical-react": "^1.6.0",
"class-variance-authority": "^0.7.0",
"clsx": "^2.1.1",
"cross-env": "^7.0.3",
"embla-carousel": "^8.5.1",
"embla-carousel-autoplay": "^8.5.1",
"embla-carousel-react": "^8.5.1",
"graphql": "^16.8.1",
"lucide-react": "^0.460.0",
"next": "15.0.4",
"next-themes": "^0.4.3",
"payload": "latest",
"react": "19.0.0",
"react-dom": "19.0.0",
"react-hook-form": "^7.53.2",
"sharp": "0.32.6",
"sonner": "^1.7.0",
"tailwind-merge": "^2.5.4",
"tailwindcss-animate": "^1.0.7",
"wikipedia": "^2.1.2",
"zod": "^3.23.8"
},

Can you share a repository that reproduces this issue?

https://github.com/Sharlmagne/gsi-webapp
There is a component titled "LexicalConverter", which is a copy of what I found in the docs.

@Sharlmagne the issue is that you are not using the latest version of payload. You have 3.0.1 installed:

I recommend hardcoding the version numbers in your package.json. So, change "latest" to "3.5.0" and make sure not to use any ^ carets.


Fix problem with huge files

With this patch, serialbox should be able to handle flawlessly any file supported by the operating system. This works by using the OffsetTable::offset_t type instead of int. offset_t is a typedef to std::streamoff
See http://stackoverflow.com/questions/24437016/is-stdstreampos-guaranteed-to-be-unsigned-long-long.

The type std::streamoff is a signed integral type of sufficient size to represent the maximum possible file size supported by the operating system.

The only way offset_t variables interact with other functions is through std::seekg (as a parameter) and through std::tellp (as return value). Both functions operate with std::streampos, which is a class type consistently convertible from and to std::streamoff (see http://www.cplusplus.com/reference/ios/streampos/). The only other interaction is with JSON (conversion from and to JSON_INT_TYPE, which is long long). If we want to be very picky, we should also modify libs/libjson/JSONOptions.h to define JSON_INT_TYPE to be std::streamoff, but long long will suffice in all our cases.

Although streamoff can take negative values, I decided to get rid of the convention "negative offset means no field present at the savepoint".
Now I use exception for those cases.

lgtm.

I also like typedef std::streamoff offset_t; which makes a sane solution!

Move to https://github.com/MeteoSwiss-APN/serialbox/pull/23


Can you publish more details about FedST-Separate: reference, how to generate fack_image

Hello, I don't know how to generate fack_image in the FedST-Separate: reference code. Could you please publish more details about FedST-Separate: reference and how to generate fack_image

Same question ，how to generate fack image for our own dataset？

Please refer to https://github.com/YoferChen/FedST/blob/master/ddpm/README.md


Adding post-fork Mapbox features

Getting access to your Slack channel is a nightmare. So I'm asking here.
What is the process for adding new features to Maplibre that correspond to changes that Mapbox made after the Maplibre fork? Can I just port them over as a new PR?

Thanks for asking. Porting features from Mapbox only works if the source license allows it. In Mapbox GL JS v2, e.g., the license does not allow porting code to MapLibre GL JS.
Which features are you thinking of?

Many things sadly =( Is there guidance on how to add new features to maplibre that might exist in mapbox w/out violating license?

We had discussions on not violating licenses in the context of the terrain3d pull request im MapLibre GL JS. Our approach there was to not look at the implementation of other companies at all. To give an example, say you like the globe view that some map products show when zooming out. You are free to implement this yourself in MapLibre and no one we be able to claim that this is a license violation, since globe view is just a concept which is not under copyright. Don't know if this helps... Maybe someone who actually already received cease and desist letters could share better insights... @nyurik @klokan maybe?

@tir38 see also this discussion we had in MapLibre GL JS: https://github.com/maplibre/maplibre-gl-js/discussions/701

@tir38 let me close this issue for the time being. Feel free reopen and to ask any question regarding licensing and implementing missing features...


accidentally space in Hostname field

⚠ Please verify that this bug has NOT been raised before.

[X] I checked and didn't find similar issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

Description
Hello! Want to inform U concerning a small bug which cost me a little of time :)
Yesterday I add a new host, and during a copy of its ip address to the Hostname field i missed the space at the beginning of ip.
Instead of getting any warning, the entered ip was accepted and this new Monitor got the status "Down". So I spent some time before realise this extra space at the beginning of entered ip address.
Is it possible to add the additional checking of the data, entered to the Hostname field? At least for the extra spaces :)

👟 Reproduction steps

👀 Expected behavior
Warning - check the entered data, entered to the Hostname field!
😓 Actual Behavior
No warning. Monitor is always Down.
🐻 Uptime-Kuma Version
1.19.4
💻 Operating System and Arch
Ubuntu 20.04
🌐 Browser
Firefox
🐋 Docker Version
Docker 20.10.22
🟩 NodeJS Version

📝 Relevant log output
-

Hi,
There is an auto test for this function you could update here : https://github.com/louislam/uptime-kuma/blob/master/test/cypress/unit/util-frontend.spec.js
Just a thought, but couldn't we add a trim when we submt?


Hy language code doesn't work in org-mode

What did you expect to happen?
When inserting a code snippet in the org-mode between #+begin_src/#+end_src and pressing C-c C-c output should be produced as it does for, say, python.
What actually happened?
Nothing is being calculated and emacs says: "No org-babel-execute function for Hy!"
Steps to reproduce:
Inside .org file:

#+begin_src hy :results output
(+ 1 1)
#+end_src

System information:

emacs   version    26.3
        features   JPEG RSVG IMAGEMAGICK GLIB NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES THREADS LCMS2
        build      Aug 30, 2019
        buildopts  (--disable-dependency-tracking --disable-silent-rules --enable-locallisppath=/usr/local/share/emacs/site-lisp --infodir=/usr/local/Cellar/emacs-plus/26.3/share/info/emacs --prefix=/usr/local/Cellar/emacs-plus/26.3 --with-xml2 --without-dbus --with-gnutls --with-imagemagick --with-modules --with-rsvg --with-ns --disable-ns-self-contained)
        windowsys  ns
        daemonp    server-running
doom    version    2.0.9
        build      HEAD -> develop cb4f9b86c 2020-03-06 16:37:57 -0500
        dir        ~/.doom.d/
system  type       darwin
        config     x86_64-apple-darwin18.5.0
        shell      /bin/zsh
        uname      Darwin 18.7.0 Darwin Kernel Version 18.7.0: Thu Jan 23 06:52:12 PST 2020; root:xnu-4903.278.25~1/RELEASE_X86_64 x86_64
        path       (~/.rbenv/shims ~/.gem/ruby/2.6.0/bin ~/anaconda3/bin ~/anaconda3/condabin ~/.local/bin ~/.cabal/bin /usr/local/bin /usr/bin /bin /usr/sbin /sbin ~/bin /Applications/SuperCollider/SuperCollider.app/Contents/MacOS /usr/local/Cellar/emacs-plus/26.3/libexec/emacs/26.3/x86_64-apple-darwin18.5.0/)
config  envfile    envvar-file
        elc-files  0
        modules    (:completion company ivy :ui doom doom-dashboard doom-quit hl-todo modeline nav-flash ophints (popup +all +defaults) vc-gutter vi-tilde-fringe window-select workspaces :editor (evil +everywhere) file-templates fold multiple-cursors rotate-text snippets :emacs dired electric ibuffer vc :checkers syntax :tools ein (eval +overlay) (lookup +docsets) lsp magit :lang data emacs-lisp hy markdown (org +dragndrop +jupyter +present) (python +lsp) sh :config (default +bindings +smartparens))
        packages   ((org-super-agenda) (org-roam :recipe (:host github :repo jethrokuan/org-roam)) (org-fancy-priorities))
        unpin      (n/a)
        elpa       (n/a)

You'll need to install https://github.com/brantou/ob-hy for this to work.

Add (package! ob-hy) to ~/.doom.d/packages.el
Run doom sync on the command line
Restart Doom.

Give it a try. If it works well enough I'll include it in Doom.

I does work! Thanks!

I've added it to :lang org in 691ecee. Thanks for bringing it to my attention!


Improved handling of draft dashboards in the sidebar, allowing to distinguish between save/overwrite

In the previous version of the sidebar, the currently edited dashboard (the 'draft') was always located at index = -1 of the list (i.e. the very first element to be displayed before all currently saved dashboards).
This PR changes this. Now, the sidebar lets people edit existing dashboards (remembering their current index), and provide the draft interface for the currently selected dashboard, without using the explicit "index = -1" entry.
The explicit entry does still exist though, as when a person has created a dashboard that is not yet saved to the database, there is no matching element in the list. Here, we do use the "-1" entry.

I think the uuid also needs to be changed if there is a new dashboard name. Otherwise I have encountered an issue with 2.4.1 where the draft will overwrite the existing saved dashboard. The way I found around this was to export the prev version json, clone the prev dashboard node and manually modify the uuid, then save current draft so that the current version I am working on does not overwrite the previous version.


Potential bug in the multi-stream sensor data transmission.

Hi team,
Recently I was playing with the multi-stream sensor data transmission feature and encountered the std::bad_weak_ptr exception. I guess it might be a bug caused by the shared_from_this() function. Here are the re-production scripts.
script1.py    # This file is intended to spawn two sensors (lidar + camera)
import carla
import time

def do_something(data):
    if isinstance(data, carla.LidarMeasurement):
        print('lidar data frame:', data.frame)
    else:
        print('camera data frame:', data.frame)

def main():
    try:
        client = carla.Client('localhost', 2000)
        client.set_timeout(10.0)
        world = client.get_world()

        # set synchronous mode
        previous_settings = world.get_settings()
        world.apply_settings(carla.WorldSettings(
            synchronous_mode=True,
            fixed_delta_seconds=1.0 / 30.0))

        spawn_point = world.get_map().get_spawn_points()[0]
        blueprint = world.get_blueprint_library().filter("vehicle.*")[0]

        actor = world.spawn_actor(blueprint, spawn_point)

        blueprint_camera = world.get_blueprint_library().find('sensor.camera.rgb')
        blueprint_camera.set_attribute('image_size_x', '640')
        blueprint_camera.set_attribute('image_size_y', '480')
        blueprint_camera.set_attribute('fov', '110')
        blueprint_camera.set_attribute('sensor_tick', '0.1')
        transform_camera = carla.Transform(carla.Location(y=+3.0, z=5.0))
        camera = world.spawn_actor(blueprint_camera, transform_camera, attach_to=actor)
        camera.listen(lambda data: do_something(data))

        blueprint_lidar = world.get_blueprint_library().find('sensor.lidar.ray_cast')
        blueprint_lidar.set_attribute('range', '30')
        blueprint_lidar.set_attribute('rotation_frequency', '10')
        blueprint_lidar.set_attribute('channels', '32')
        blueprint_lidar.set_attribute('lower_fov', '-30')
        blueprint_lidar.set_attribute('upper_fov', '30')
        blueprint_lidar.set_attribute('points_per_second', '56000')
        transform_lidar = carla.Transform(carla.Location(x=0.0, z=5.0))
        lidar = world.spawn_actor(blueprint_lidar, transform_lidar, attach_to=actor)
        lidar.listen(lambda data: do_something(data))

        while True:
            world.tick()
            time.sleep(0.1)

    finally:
        if previous_settings:
            world.apply_settings(previous_settings)
        if actor:
            actor.destroy()
        if camera:
            camera.stop()
            camera.destroy()
        if lidar:
            lidar.stop()
            lidar.destroy()

if __name__ == "__main__":
    main()

script2.py # This file is intended to listen to the "alive" sensors. This script will stop listening the sensor when the sensor is no longer alive.
import carla

def do_something(data):
    if isinstance(data, carla.LidarMeasurement):
        print('lidar data frame:', data.frame)
    else:
        print('camera data frame:', data.frame)

def main():
    try:
        client = carla.Client('localhost', 2000)
        client.set_timeout(10.0)
        world = client.get_world()

        sensors = dict()

        while True:
            snapshots = world.wait_for_tick(30)
            ids = set()
            for snapshot in snapshots:
                ids.add(snapshot.id)
                if snapshot.id in sensors.keys():
                    continue
                actor = world.get_actor(snapshot.id)
                if actor.type_id.startswith('sensor'):
                    print('find sensor')
                    actor.listen(lambda data: do_something(data))
                    sensors[snapshot.id] = actor

            to_delete_sensor = []
            for sensor_id in sensors.keys():
                if not sensor_id in ids:
                    print('stop listening to dead sensor')
                    to_delete_sensor.append(sensor_id)
                    sensors[sensor_id].stop()
            for sensor_id in to_delete_sensor:
                sensors.pop(sensor_id)

    except Exception as e:
        print(e)

if __name__ == "__main__":
    main()

Now we launch the carla simulator, script1 and script2. Then keep terminating and re-launching script1 (which means keeping destroying sensors). Then the std::bad_weak_ptr might be thrown in script2. Since there is a race condition, error might not be there every time when you kill the script1. You might need to try several times to get the error. Here is the output of the result.
script2.py
lidar data frame: 2175
lidar data frame: 2176
lidar data frame: 2177
camera data frame: 2176
lidar data frame: 2178
stop listening to dead sensor
terminate called after throwing an instance of 'std::bad_weak_ptr'
  what():  bad_weak_ptr
Aborted (core dumped)

After some investigations, I found that the error might come from this file - LibCarla/source/carla/streaming/detail/tcp/Client.cpp - line 158. The shared_from_this() function is called when all shared_ptrs of this class have been destructed and this callback is a dangling callback.
Please let me know if it is correct and is there anything the team can do to fix this problem.
Best,
Minjun

@bernatx this is very relevant for the current release. Please, have a look at it.

Hi Minjun Xu, glad you are back.
Thanks for all the details, I'm looking at it.

Hi team,
I was testing again with Carla 0.9.10. However, everytime when I terminated script1.py with ctrl+c, the carla server will get segmentation fault. Here is the output.
4.24.3-0+++UE4+Release-4.24 518 0
Disabling core dumps.
Signal 11 caught.
Malloc Size=65538 LargeMemoryPoolOffset=65554
CommonUnixCrashHandler: Signal=11
Malloc Size=65535 LargeMemoryPoolOffset=131119
Malloc Size=118144 LargeMemoryPoolOffset=249280
Engine crash handling finished; re-raising signal 11 for the default handler. Good bye.
Segmentation fault (core dumped)


Windows Defender is saying that "Another-Redis-Desktop-Manager.1.4.8.exe" is containing a trojan virus

OS
Windows
VERSION
When upgrading to 1.4.8
ISSUE DESCRIPTION
Windows Defender is blocking the update setup file "Another-Redis-Desktop-Manager.1.4.8.exe" saying that it contains virus. "Trojan:Win32/Emali.A!cl"

v1.4.7 got this alert before?

No. I’ve not had any issues with the previous updates. Only with this one from 1.4.7 to 1.4.8.
Best regards
Stellan Lindell
El 7 jul 2021 16:49 +0200, qii404 @.***>, escribió:

v1.4.7 got this alert before?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

I just update electron8 to 11😂

https://www.virustotal.com/gui/file/88581171ffb2f2663761cfa0f18cfe9b3a387978c19f48cc90b2913c242538af/detection
but no virus was detected here

Yes, I ran it through VirusTotal as well without issues ant then I decided to exclude it.  Maybe because of something in the Electron update idk.

submitted to Microsoft  https://www.microsoft.com/en-us/wdsi/submission/8d4c9bf3-ab62-430d-b188-47bcc2f86158