[build] Making config.h fully available to CMake users

Assuming config.h should be the main source of truth regarding raylib customization, I proposed the following changes:

The CMakeOptions.txt file should expose all the flags found in config.h.
The CompileDefinitions.cmake should treat the configuration values in config.h as the default ones.

To this end I created the ParseConfigHeader.cmake script to read config.h and generate lists which are in turn used by CMakeOptions.txt and CompileDefinitions.cmake to do their thing.

@lzralbu It looks like a very big change on the CMake build system, not sure it could be potentially breaking for some users.
I don't use or maintain CMake so someone with experience in the system should review this PR.

@lzralbu is setting CUSTOMIZE_BUILD to On supposed to enable every single file format? because that's what your branch does for me...

No, regarding file formats it should only enable the SUPPORT_FILEFORMAT_* flags that are uncommented in the config.h file.
Could you share your cmake configuration step output?

There is no SUPPORT_FILEFORMAT_JPG=ON for example.

@lzralbu I'm doing nothing special
[peter@peter build]$ cmake .. -DCUSTOMIZE_BUILD=On
-- Testing if -Werror=pointer-arith can be used -- compiles
-- Testing if -Werror=implicit-function-declaration can be used -- compiles
-- Testing if -fno-strict-aliasing can be used -- compiles
-- Using raylib's GLFW
-- Including Wayland support
-- Including X11 support
-- Building raylib static library
-- SUPPORT_MODULE_RSHAPES=ON
-- SUPPORT_MODULE_RTEXTURES=ON
-- SUPPORT_MODULE_RTEXT=ON
-- SUPPORT_MODULE_RMODELS=ON
-- SUPPORT_MODULE_RAUDIO=ON
-- SUPPORT_CAMERA_SYSTEM=ON
-- SUPPORT_GESTURES_SYSTEM=ON
-- SUPPORT_RPRAND_GENERATOR=ON
-- SUPPORT_MOUSE_GESTURES=ON
-- SUPPORT_SSH_KEYBOARD_RPI=ON
-- SUPPORT_WINMM_HIGHRES_TIMER=ON
-- SUPPORT_BUSY_WAIT_LOOP=ON
-- SUPPORT_PARTIALBUSY_WAIT_LOOP=ON
-- SUPPORT_SCREEN_CAPTURE=ON
-- SUPPORT_GIF_RECORDING=ON
-- SUPPORT_COMPRESSION_API=ON
-- SUPPORT_AUTOMATION_EVENTS=ON
-- SUPPORT_CUSTOM_FRAME_CONTROL=ON
-- SUPPORT_QUADS_DRAW_MODE=ON
-- SUPPORT_FILEFORMAT_PNG=ON
-- SUPPORT_FILEFORMAT_BMP=ON
-- SUPPORT_FILEFORMAT_TGA=ON
-- SUPPORT_FILEFORMAT_JPG=ON
-- SUPPORT_FILEFORMAT_GIF=ON
-- SUPPORT_FILEFORMAT_QOI=ON
-- SUPPORT_FILEFORMAT_PSD=ON
-- SUPPORT_FILEFORMAT_DDS=ON
-- SUPPORT_FILEFORMAT_HDR=ON
-- SUPPORT_FILEFORMAT_PIC=ON
-- SUPPORT_FILEFORMAT_KTX=ON
-- SUPPORT_FILEFORMAT_ASTC=ON
-- SUPPORT_FILEFORMAT_PKM=ON
-- SUPPORT_FILEFORMAT_PVR=ON
-- SUPPORT_FILEFORMAT_SVG=ON
-- SUPPORT_IMAGE_EXPORT=ON
-- SUPPORT_IMAGE_GENERATION=ON
-- SUPPORT_IMAGE_MANIPULATION=ON
-- SUPPORT_DEFAULT_FONT=ON
-- SUPPORT_FILEFORMAT_TTF=ON
-- SUPPORT_FILEFORMAT_FNT=ON
-- SUPPORT_FILEFORMAT_BDF=ON
-- SUPPORT_TEXT_MANIPULATION=ON
-- SUPPORT_FONT_ATLAS_WHITE_REC=ON
-- SUPPORT_FILEFORMAT_OBJ=ON
-- SUPPORT_FILEFORMAT_MTL=ON
-- SUPPORT_FILEFORMAT_IQM=ON
-- SUPPORT_FILEFORMAT_GLTF=ON
-- SUPPORT_FILEFORMAT_VOX=ON
-- SUPPORT_FILEFORMAT_M3D=ON
-- SUPPORT_MESH_GENERATION=ON
-- SUPPORT_FILEFORMAT_WAV=ON
-- SUPPORT_FILEFORMAT_OGG=ON
-- SUPPORT_FILEFORMAT_MP3=ON
-- SUPPORT_FILEFORMAT_QOA=ON
-- SUPPORT_FILEFORMAT_FLAC=ON
-- SUPPORT_FILEFORMAT_XM=ON
-- SUPPORT_FILEFORMAT_MOD=ON
-- SUPPORT_STANDARD_FILEIO=ON
-- SUPPORT_TRACELOG=ON
-- SUPPORT_TRACELOG_DEBUG=ON
-- Generated build type: Debug
-- Compiling with the flags:
--   PLATFORM=PLATFORM_DESKTOP
--   GRAPHICS=GRAPHICS_API_OPENGL_33
-- Building examples is enabled
-- Testing if -std=c11 can be used -- compiles
-- Configuring done (0.2s)
-- Generating done (0.3s)
-- Build files have been written to: /home/peter/bruh/raylib/build

Honestly I think the way this is engineered is total overkill. New file formats don't get added often enough to make updating the default values in cmake a hassle, and nothing so terrible happens if one gets overlooked.

All this time I was testing my modifictions while using raylib as a subproject via add_subdirectory, but by cmake-configuring my branch as a top-level project gives me the same results as yours. I'll investigate further.

@lzralbu I'm doing nothing special
[peter@peter build]$ cmake .. -DCUSTOMIZE_BUILD=On
-- Testing if -Werror=pointer-arith can be used -- compiles
-- Testing if -Werror=implicit-function-declaration can be used -- compiles
-- Testing if -fno-strict-aliasing can be used -- compiles
-- Using raylib's GLFW
-- Including Wayland support
-- Including X11 support
-- Building raylib static library
-- SUPPORT_MODULE_RSHAPES=ON
-- SUPPORT_MODULE_RTEXTURES=ON
-- SUPPORT_MODULE_RTEXT=ON
-- SUPPORT_MODULE_RMODELS=ON
-- SUPPORT_MODULE_RAUDIO=ON
-- SUPPORT_CAMERA_SYSTEM=ON
-- SUPPORT_GESTURES_SYSTEM=ON
-- SUPPORT_RPRAND_GENERATOR=ON
-- SUPPORT_MOUSE_GESTURES=ON
-- SUPPORT_SSH_KEYBOARD_RPI=ON
-- SUPPORT_WINMM_HIGHRES_TIMER=ON
-- SUPPORT_BUSY_WAIT_LOOP=ON
-- SUPPORT_PARTIALBUSY_WAIT_LOOP=ON
-- SUPPORT_SCREEN_CAPTURE=ON
-- SUPPORT_GIF_RECORDING=ON
-- SUPPORT_COMPRESSION_API=ON
-- SUPPORT_AUTOMATION_EVENTS=ON
-- SUPPORT_CUSTOM_FRAME_CONTROL=ON
-- SUPPORT_QUADS_DRAW_MODE=ON
-- SUPPORT_FILEFORMAT_PNG=ON
-- SUPPORT_FILEFORMAT_BMP=ON
-- SUPPORT_FILEFORMAT_TGA=ON
-- SUPPORT_FILEFORMAT_JPG=ON
-- SUPPORT_FILEFORMAT_GIF=ON
-- SUPPORT_FILEFORMAT_QOI=ON
-- SUPPORT_FILEFORMAT_PSD=ON
-- SUPPORT_FILEFORMAT_DDS=ON
-- SUPPORT_FILEFORMAT_HDR=ON
-- SUPPORT_FILEFORMAT_PIC=ON
-- SUPPORT_FILEFORMAT_KTX=ON
-- SUPPORT_FILEFORMAT_ASTC=ON
-- SUPPORT_FILEFORMAT_PKM=ON
-- SUPPORT_FILEFORMAT_PVR=ON
-- SUPPORT_FILEFORMAT_SVG=ON
-- SUPPORT_IMAGE_EXPORT=ON
-- SUPPORT_IMAGE_GENERATION=ON
-- SUPPORT_IMAGE_MANIPULATION=ON
-- SUPPORT_DEFAULT_FONT=ON
-- SUPPORT_FILEFORMAT_TTF=ON
-- SUPPORT_FILEFORMAT_FNT=ON
-- SUPPORT_FILEFORMAT_BDF=ON
-- SUPPORT_TEXT_MANIPULATION=ON
-- SUPPORT_FONT_ATLAS_WHITE_REC=ON
-- SUPPORT_FILEFORMAT_OBJ=ON
-- SUPPORT_FILEFORMAT_MTL=ON
-- SUPPORT_FILEFORMAT_IQM=ON
-- SUPPORT_FILEFORMAT_GLTF=ON
-- SUPPORT_FILEFORMAT_VOX=ON
-- SUPPORT_FILEFORMAT_M3D=ON
-- SUPPORT_MESH_GENERATION=ON
-- SUPPORT_FILEFORMAT_WAV=ON
-- SUPPORT_FILEFORMAT_OGG=ON
-- SUPPORT_FILEFORMAT_MP3=ON
-- SUPPORT_FILEFORMAT_QOA=ON
-- SUPPORT_FILEFORMAT_FLAC=ON
-- SUPPORT_FILEFORMAT_XM=ON
-- SUPPORT_FILEFORMAT_MOD=ON
-- SUPPORT_STANDARD_FILEIO=ON
-- SUPPORT_TRACELOG=ON
-- SUPPORT_TRACELOG_DEBUG=ON
-- Generated build type: Debug
-- Compiling with the flags:
--   PLATFORM=PLATFORM_DESKTOP
--   GRAPHICS=GRAPHICS_API_OPENGL_33
-- Building examples is enabled
-- Testing if -std=c11 can be used -- compiles
-- Configuring done (0.2s)
-- Generating done (0.3s)
-- Build files have been written to: /home/peter/bruh/raylib/build

Could you test again, please?
I guess the culprit was a regex that assumed inactive flags in config.h should start with exactly //  instead of // or //                , etc. My code formatter induced me to make such assumption.

It seems to work correctly now, for that case. I checked it over again and I do have some questions/review comments, though.

Works properly for me now. Approved.

@lzralbu Thank you very much for the improvement! Despite the added build complexity, it improves alignment with raylib config.h, there were some issues in the past because of that need to update two files separately. Thanks!
@Peter0x44 Thank you very much for the review and testing of this BIG redesign!


Windows.gitignore - Change desktop.ini to [Dd]esktop.ini

Reasons for making this change:
Some Windowses uses desktop.ini instead of Desktop.ini.
This commit can close PR #2460 by @NeverMine17
Links to documentation supporting these rule changes:
https://ru.wikipedia.org/wiki/Desktop.ini

@Yousha thanks!


Update INamingStrategy.GetQueueName to take SqsReadConfiguration for …

…easier extension.

@brainmurphy Submitted this PR as discussed.

@payman81 Actually, I think that we wanted to make SqsReadConfiguration.InstancePosition public.

I checked and it was public already https://github.com/justeat/JustSaying/blob/master/JustSaying.AwsTools/QueueCreation/SqsReadConfiguration.cs#L30 cc @brainmurphy

Oh, bugger, it's SubscriptionType I was thinking of! We need that to distinguish between whether we're subscribing to SQS directly or to SQS-subscribed-to-SNS.


Update runtime-spec dependency to v1.0.0-rc1

Signed-off-by: Mrunal Patel<EMAIL_ADDRESS>

On Tue, Jun 14, 2016 at 02:14:49PM -0700, Mrunal Patel wrote:

M Godeps/Godeps.json (6)
M Godeps/_workspace/src/github.com/opencontainers/runtime-spec/specs-go/config.go (76)
M Godeps/_workspace/src/github.com/opencontainers/runtime-spec/specs-go/state.go (4)
M Godeps/_workspace/src/github.com/opencontainers/runtime-spec/specs-go/version.go (6)

This updates the config structures, but it doesn't update test_runtime
to use the newly-split create/start (opencontainers/runtime-spec#384).
Are we going to do that in a follow-up PR?  And we'll have to drop
Bash or insert something like 1 now that we need
PR_SET_CHILD_SUBREAPER to collect the container process's exit code
2.

@wking Yes, we can do that change in a follow-on PR.

LGTM

On Tue, Jun 14, 2016 at 03:42:04PM -0700, Mrunal Patel wrote:

@wking Yes, we can do that change in a follow-on PR.

In that cases there's not much chance of anything going wrong here,
since there were no backwards icompatible runtime-spec/specs-go
changes between 0.5.0 and 1.0.0-rc1.

On Tue, Jun 14, 2016 at 02:14:49PM -0700, Mrunal Patel wrote:

M Godeps/Godeps.json (6)

This actually bumped to v1.0.0-rc1-15-g6de52a7, 15 commits after the
v1.0.0-rc1 tag.  Can we roll it back to the tag?  With the current
Godeps I'm still seeing #108:
$ ./test_runtime.sh -r ccon-oci
VALIDATING RUNTIME: ccon-oci
…
NotImplementedError: unsupported OCI-spec version: 1.0.0-rc1-dev
Runtime ccon-oci failed validation


Build Failed

I'm assuming the module must be built before being used, unless there is a precompiled version somewhere that I am not seeing??
When I attempt to build the module in Titanium, I'm getting the following error:
Traceback (most recent call last):
  File "/Users/allenhartwig/Downloads/sideshowcoder-jpgcompressor-fd04563/build.py", line 191, in <module>
    compile_js(manifest,config)
  File "/Users/allenhartwig/Downloads/sideshowcoder-jpgcompressor-fd04563/build.py", line 69, in compile_js
    from compiler import Compiler
ImportError: cannot import name Compiler

The module was looking for SDK 1.7.2.
Changing TITANIUM_SDK_VERSION = 1.7.2 to TITANIUM_SDK_VERSION = 1.8.2 in titanium.xcconfig took care of the issue.


Logging

Since commit '28373500cb77eece0fc51e7959b1f68997925b57' - log output to the console is much worse:
For example:
[CRIT] SyntaxError: Unexpected end of input0[ 'SyntaxError: Unexpected end of input',\n  '    at Object._load_and_compile_plugin (/root/Haraka/plugins.js:161:12)',\n  '    at /root/Haraka/plugins.js:121:26',\n  '    at Array.map (native)',\n  '    at Object.load_plugins (/root/Haraka/plugins.js:115:39)',\n  '    at Object.createServer (/root/Haraka/server.js:60:13)',\n  '    at Object. (/root/Haraka/haraka.js:39:8)',\n  '    at Module._compile (module.js:402:26)',\n  '    at Object..js (module.js:408:10)',\n  '    at Module.load (module.js:334:31)',\n  '    at Function._load (module.js:293:12)' ]
[CRIT]     at Object._load_and_compile_plugin (/root/Haraka/plugins.js:161:12)1[ 'SyntaxError: Unexpected end of input',\n  '    at Object._load_and_compile_plugin (/root/Haraka/plugins.js:161:12)',\n  '    at /root/Haraka/plugins.js:121:26',\n  '    at Array.map (native)',\n  '    at Object.load_plugins (/root/Haraka/plugins.js:115:39)',\n  '    at Object.createServer (/root/Haraka/server.js:60:13)',\n  '    at Object. (/root/Haraka/haraka.js:39:8)',\n  '    at Module._compile (module.js:402:26)',\n  '    at Object..js (module.js:408:10)',\n  '    at Module.load (module.js:334:31)',\n  '    at Function._load (module.js:293:12)' ]
The intent of the previous patch was to remove carriage returns from messing up the syslog output (as syslog on Linux doesn't handle this well).
How about changing line 33 of logger.js to:
data.replace(/\r/g, '');
It should then be up to the individual log plugin as to whether to filter LF's into \n or not (syslog handled LF's without issue).
With this modification; my console log output is back to normal:
[CRIT]     at Function._load (module.js:293:12)10[ 'SyntaxError: Unexpected end of input',
'    at Object._load_and_compile_plugin (/root/Haraka/plugins.js:161:12)',
'    at /root/Haraka/plugins.js:121:26',
'    at Array.map (native)',
'    at Object.load_plugins (/root/Haraka/plugins.js:115:39)',
'    at Object.createServer (/root/Haraka/server.js:60:13)',
'    at Object. (/root/Haraka/haraka.js:39:8)',
'    at Module._compile (module.js:402:26)',
'    at Object..js (module.js:408:10)',
'    at Module.load (module.js:334:31)',
'    at Function._load (module.js:293:12)' ]

Interestingly that one comes because of the global process.on('uncaughtException') which I'm thinking of getting rid of anyway...

Ok - but my point was shouldn't it be up to the log plugin to strip LF's or not?
As for getting rid of the uncaughtException process event; for plugins with syntax errors - it's not very useful as vm.runInNewContextContext() exceptions do not show the file and line number of the actual error despite 'name' being provided to it.
I've just modified my plugins.js to this:
try {
    vm.runInNewContext(code, sandbox, name);
}
catch (err) {
    logger.logcrit('Loading plugin ' + name + ' failed: ', err.message);
    if (config.get('smtp.ini', 'nolog', 'ini').main.ignore_bad_plugins) {
        return;
    }
    else {
        throw 'plugin_error';
    }
}

That provides much briefer output on plugin errors and is no less useful than a full stack trace:
[root@vm3 Haraka]# node haraka.js
[DEBUG] no cluster available, running single-process
Starting up Haraka version 0.9.0
[INFO] Loading plugins
[INFO] Loading plugin: stats
[CRIT] Loading plugin stats failed: Unexpected token .
[CRIT] Caught exception: plugin_error
[CRIT] Server not ready yet. Stopping.

+1. No line breaks makes errors extremely difficult to read.

Please try 1.0.0. Closing this issue for now.


Make cuda optional

This PR implements a fallback on the host if the CUDA toolkit wasn't found; also fixes a bug where the co-dependent targets wouldn't link as stb_image can't be linked with.

Looks good to me


Update conda

Mostly cosmetic changes. @antgonza @wasade wanna take a quick look?

looks good to me!


Potential StackOverflow when binding CurrentPage in Pagination

cc @yangjieshao for follow-up.

We should not bind a nullable property to a non-nullable value with OneWayToSource directly. Add a converter to deal will null condition in ConvertBack.


Small fixes: docs, examples, import order and use of service acount

This one references #1125 :)

@SantoDE tests failed :'(

Sorry, should be fixed now @emilevauge

@SantoDE could you also complete traefik.sample.toml ?


Predictable order for columns in assign through sorting

The order of columns coming out of .assign is hard to predict
In [1]: import pandas as pd

In [2]: df = pd.DataFrame({'a': [1], 'b': [2]})

In [3]: df
Out[3]:
   a  b
0  1  2

In [4]: df.assign(d=df.a*10, a=df.b*10, e=df.a*20)
Out[4]:
    a  b   e   d
0  20  2  20  10

Would it be reasonable to keep all existing keys in their current location and then add the remaining keys in sorted order at the end?

this does seem reasonable
there args are passed as kwargs where ordering is not defined
but existing columns are known and new keys could be sorted

Agreed, this seems like a sane change.

@TomAugspurger want this issue?

I thought about doing this initially but then backed off when I saw PEP 468: https://www.python.org/dev/peps/pep-0468/ which is for preserving the order of **kwargs. Plus the eventual future where pandas runs on pypy, whose dicts are ordered.
That said, I'm not sure we should make design decisions around those, which could be very far off in the future or not happen at all. Having a predictable order now is probably a good thing.
It'll be a few days before I can get to it probably.

its a nice idea to have the ordering for kwargs, but practically that is long off (and pypy is even longer IMHO / never be adopted).

FYI https://www.python.org/dev/peps/pep-0468/ was actually accepted for 3.6 at the last minute (thanks to dicts maintaining sort order now).
Is this worth revisiting this now? It'd only be for 3.6+, so users writing code would need to be aware of that. Seems like a cause for subtle bugs if you're writing code that should support earlier versions.

Yes, we should revisit this, though I don't see it being a major pain point so there's no rush. Maybe for pandas 2.0? By the time pandas 2.0 is out we'll probably all be using Python 3.6 day to day anyways.


naoqi_sensors_py no longer contains nodlet plugins

This outputs following errors
[ERROR] [1439112250.398724708]: Skipping XML Document "/home/laala/ros/indigo/src/ros_naoqi/naoqi_bridge/naoqi_sensors_py/naoqicamera_nodelet.xml" which had no Root Element.  This likely means the XML is malformed or missing.

Cc: @sasabot

thx !

@Karsten1987 , don't hesitate to release this week.


Close output channels in streaming collection builders

Since these functions return a receive-only channel, the
caller can't close the channel it pulls the constructed
collection off of. Since the builder function can easily
know when it's safe to close the channel, it seems fine
to just have NewStreamingWhatever() do the close.

PTAL. I believe we've been leaking channels

Codecov Report

Merging #3242 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted Files
Coverage Δ

go/types/list.go
98.5% <100%> (ø)
:white_check_mark:

go/types/set.go
93.15% <100%> (+0.04%)
:white_check_mark:

go/types/map.go
93.75% <100%> (+0.03%)
:white_check_mark:

go/datas/http_batch_store.go
88.05% <0%> (+0.62%)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25f3824...6ceb8d3. Read the comment docs.


Update isReady attribute

Short description of changes:
The isReady attribute is set to false at the creation of a wavesurfer. Then, It is set to true when a song is loaded but it is never set to false when emptying the wavesufer. As a result, after the first song is loaded, isReady return true even if the wavesurfer is empty.

Coverage increased (+0.03%) to 68.431% when pulling 2dfba6b009e866c429b860150279694277043e2f on Guisch:patch-1 into cd5e3f2974032486d27c7ce6a605b708ce1c4d13 on katspaugh:master.

Thanks!

@Guisch I think it should also be set to false in destroy?

Yes !

@Guisch can you also do a PR for that? (and verify it's false in the destroy unit test)?

Done (except for the unit test, sorry i do not see what you'r talking about)

cool. yea the unit test for destroy is missing, can you open a new ticket for that?


Clarify contributor guidelines.

A proposal to capture some of the changes we discussed at the last TAC meeting.

Clarify that diversity of both committers and contributors is important.
Add some caveat text to describe the "bare minimum", to hopefully capture the spirit of what the TAC is looking for in a healthy project.

Unfortunate that GitHub-flavored Markdown doesn't support footnotes, would have been useful here.


fix Fix the problem of exporting stuck

What problem does this PR solve?
Problem Summary:
The disruptor will be witing when the ringbuffer does not have enough capacity. At the same time, addExportJobAndRegisterTask will not release the lock of ExportMgr. This prevents other methods from obtaining the lock.
Release note
Check List (For Author)

Test

[ ] Regression test
[ ] Unit Test
[ ] Manual test (add detailed scripts or steps below)
[x] No need to test or manual test. Explain why:

[ ] This is a refactor/code format and no logic has been changed.
[ ] Previous test can cover this change.
[ ] No code files have been changed.
[x] Other reason

Behavior changed:

[x] No.
[ ] Yes.

Does this need documentation?

[x] No.
[ ] Yes.

Check List (For Reviewer who merge this PR)

[ ] Confirm the release note
[ ] Confirm test cases
[ ] Confirm document
[ ] Add branch pick label

run buildall

run cloud_p0

run buildall


Choose tasks from past and future sprints

Expected Behavior
User should have possibility to display and report time to tasks from past and future sprints
Actual Behavior
Only tasks from current sprint are displayed
Steps to Reproduce the Problem
.
Specifications

T-REC Version: 1.1.0
Platform: (mac/linux/windows): all

I don't think this is good, we should do this more generic: allow to own search query

this is releated to #40


Remove the check that if base file name starts with ^ is dynamic file name since those files can exist

Fixes #35734

do we lose any ability to detect or create dynamic file names since real files can use carat now?

We already have tests for all the scenarios that use dynamic file names and they work, (I think work to retain projectRootPath for open files has rendered this not needed any more)

@typescript-bot pack this

@uniqueiniquity @jessetrinity @amcasey can you try our the drop here to see the debugging scenarios are working ok.
I tried creating bunch of dynamic files in VS but I might not have covered all scenarios. (file is created dynamic when debugging in ie and clicking files from solution explorer and script documents list if there is not matching file found on disk.. eg you compile ts with --inlineSources and then delete the ts files)

@sheetalkamat sure thing - I actually just built it locally a few moments ago.

@sheetalkamat Looks good to me. Tried naming normal files with a leading ^, tried using dynamic files, and tried using dynamic files that start with a leading ^. All seems fine.


Allow the private class B networks

For the Docker for Mac and  the Docker for Windows.

@snj  Could you review this?  🌻

LGTM

Thanks!


feat: Update sensor-dt-pr-merge.yaml

:tada: This PR is included in version 1.16.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


fix: avatar not changed in tooltip when updating avatar

Details

Fixed Issues
$ https://github.com/Expensify/App/issues/20672
PROPOSAL: https://github.com/Expensify/App/issues/20672#issuecomment-1589597755
Tests

Go to offline mode
Go to Settings -> Profile and change the avatar
Go to any chat and hover on email to see user details in tooltip
Verify if updated avatar is displayed
Go to online mode and take steps 2 - 4.

[x] Verify that no errors appear in the JS console

Offline tests

Go to Settings -> Profile and change the avatar
Go to any chat and hover on email to see user details in tooltip
Verify if updated avatar is displayed

QA Steps

Go to offline mode
Go to Settings -> Profile and change the avatar
Go to any chat and hover on email to see user details in tooltip
Verify if updated avatar is displayed
Go to online mode and take steps 2 - 4.

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/126839717/aae457a0-4390-488d-b474-18f987cafbe6

Mobile Web - Chrome
https://github.com/Expensify/App/assets/126839717/07441d91-3a5e-4b5b-b4df-c9a49d44d903

Mobile Web - Safari
https://github.com/Expensify/App/assets/126839717/a8568a06-3c5b-40f4-aef5-3b1fe8632e83

Desktop
https://github.com/Expensify/App/assets/126839717/9b0702fa-1f42-4126-8fe5-b14379faf3ef

iOS
https://github.com/Expensify/App/assets/126839717/c7bb686f-0dde-4737-8c23-7eae00f091a2

Android
https://github.com/Expensify/App/assets/126839717/cb5a555c-e627-4505-a29e-e757c50f5308

Reassigning since @allroundexperts can review it sooner!

@s-alves10 Can you also check why the uploaded image while in offline mode, does not show up in the image viewer modal?

This seems out of scope but let me check.

When you upload an image in offline mode, avatar is stored as blob. blob url hasn't image extension in it and image check fails here
https://github.com/Expensify/App/blob/0a471b016d9b36c986a81680ef2518d2ae749937/src/components/AttachmentView.js#L110
That's why it isn't displayed as image

We might need to handle blob urls for offline mode

Do you think this is a regression?

@allroundexperts
We have now similar bugs in ND.

In offline mode, ImageView in profile page doesn't work correctly as you mentioned
If you upload new avatar in offline status and go to online, avatars doesn't work correctly

These bugs are currently in ND and not caused by this PR
I don't think these are regression. Can you tell me your thoughts?

@mountiny
Those bugs are not related to this PR. I found them on staging

@s-alves10 Can you please share steps to reproduce this on staging?

@allroundexperts
Issue 1
https://github.com/Expensify/App/assets/126839717/40915cec-3ca9-4928-a135-52a8352bd754
Issue 2
https://github.com/Expensify/App/assets/126839717/367a36b8-2870-483f-b635-7560e32432d6

Issue 1 is related to AttachView component. It can't show blob image. This can be addressed in a separate issue, I think

I think we should fix this properly also with the new issue this introduces.

I think we should fix this properly also with the new issue this introduces.

Excuse me, but can you explain in more detail? There are no issues this PR newly introduces.

This is the issue with the profile, right? Would it be that hard to fix in this PR as well?

Maybe we got a bit lost in many comments here
@allroundexperts would you be able to summarize the problem and current situation we got here now, thanks?

@s-alves10 Can you verify this as well?

Is this one I have to check?

Checked.

@allroundexperts @s-alves10 can you confirm that once you go back online, the avatar will show correctly in this scenario?

@pecanoro  I think its good to CP this and make a follow up issue for the problem discovered by this PR. All yours 🙇

Awesome, doing a final test run!

The bug #1 we found with the profile image, I think it might be working on dev and some fix might have been recently merged as it works well for me. We will see after the back-end deploy anyways, otherwise, all good! Approving!

@pecanoro I think its good to CP this and make a follow up issue for the problem discovered by this PR. All yours 🙇

I can work on the follow up issue. Thanks

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Oh shit, I forgot to add the CP label.

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.27-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

Tested on staging, bug was fixed!

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.27-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Skip verilator CI step if rtl not modified

We shouldn't run the verilator CI job when changes in a PR do not affect rtl that it tests.

Decision has been made to run verilator on every PR for now due to limits of skipping required CI workflows. See https://github.com/mosscomp/moss/pull/22#issuecomment-808914786 for more info.


Unable to

There are 2 application in project, one is the mirco service application, and the other is the zuul application
Frist test case:

Zuul Application run on localhost:8080
MyApplication run localhost:8081

Send request by:
browser -->  Zuul app --> MyApp
Result:
The cookie set correctly before redirect to login controller.
Second test case:

Zuul Application run on localhost:8080
MyApplication run AWS server

Send request by:
browser -->  Zuul app --> MyApp
Result:
The cookie is not set , even I saw the cookie is in the response header
I have tried to set
zuul.sensitiveHeader: Cookie,Set-Cookie,Authorization

But is not working at all.
// Spring boot application : MyApplication
// using spring session for handling login
// user post a request, after validation will redirect user to login page
@RequestMapping(path = "checkRequest", method = GET)
    public String login(@ModelAttribute("form") LoginForm form) {
        ... // do some validation
        ... // create session
        return "redirect:/login";
}

@RequestMapping(path = "login", method = GET)
    public String login(@ModelAttribute("form") LoginForm form) {
        if(!isSessionExist()) {
            return "redirect:/error"
        }
}

// Zuul Applcaition
// forward incoming request to MyApplication
public class ConductorRoutingFilter extends ZuulFilter {
    ...
    @Override
    public String filterType() {
        return "route";
    }

    @Override
    public Object run() {
        try {
            CommandContext context = prepareCommandContext();
            Future<HttpCommandResponse> responseFuture = executionManager.submit(context);
            HttpCommandResponse commandResponse = responseFuture.get();
            // update the Location header so the redirection will via the conductor, I set as 8080 / 8081 just for testing zuul on local
            if (commandResponse.getHeaders().get("Location") != null) {
                commandResponse.getHeaders().set("Location", "http://localhost:8080" + commandResponse.getHeaders().get("Location").get(0).replace("http://localhost:8081", ""));
            }

            if (StringUtils.hasText(commandResponse.getResponseStr())) {  RequestContext.getCurrentContext().setResponseBody(commandResponse.getResponseStr());
            } else if (commandResponse.getDataStream() != null) {
                byte[] data = commandResponse.getDataStream().toByteArray();
                InputStream inputStream = new ByteArrayInputStream(data);
                RequestContext.getCurrentContext().set("zuulResponse", inputStream);
                this.helper.setResponse(
                        commandResponse.getStatusLine().getStatusCode(),
                        (inputStream),
                        (commandResponse.getHeaders() == null ? new LinkedMultiValueMap<String, String>() : commandResponse.getHeaders())
                );
            } else {
                RequestContext.getCurrentContext().set("zuulResponse", commandResponse.getEntity());
                this.helper.setResponse(
                        commandResponse.getStatusLine().getStatusCode(),
                        (commandResponse.getEntity()),
                        (commandResponse.getHeaders() == null ? new LinkedMultiValueMap<String, String>() : commandResponse.getHeaders())
                );
            }

        } catch (Exception e) {
            ... // some fallback response
            }
        }
        return null;
    }
}

You misunderstand zuul.sensitiveHeaders. it's headers that are NOT passed on. Set it to empty

Thanks for quick reply
Tried to set it as empty, but the cookie is still not set.
But why the cookie is set if MyApplication is running on localhost?

That's http. Cookies are only set for a particular domain. Other domains can't see them


Version 2 and also got error today morning

Hi, do QbitNinja support version 2? if yes then which is the stable version of Package we can use?
This shows version 2 while our all transaction shows version 1.
https://www.smartbit.com.au/tx/33cea950b1e23f4465fc005400ac0c8e53e4816a644eb30cea5aeefea12799a3
I wrote because in version 2, it shows fee double instead of version 1. Like in above example it shows 57.11 on blockchain. Then also it got confirmed.
https://blockchain.info/tx/33cea950b1e23f4465fc005400ac0c8e53e4816a644eb30cea5aeefea12799a3
Please provide more details and example for git, so it's good for us to use less satoshi as fee.

Also we got one or more error occurred from package at today 2017-12-29 06:17:45.010 UTC time.

Version 2 is only useful if you make use OP_CSV as specified here https://github.com/bitcoin/bips/blob/master/bip-0112.mediawiki .
It has no impact on how much time it takes to validate a transaction.

Please open a new issue for the error you got with more feedback.


mention #628

bors r+

Marking your own homework @spookyvision? ;)

Marking your own homework @spookyvision? ;)

having a full blown PR for trivial non-code fixes is already more noise than I like, adding a reviewer to the mix even worse in my book. Ultimately I don't care much either way though.


[WIP] Implement Update Op

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: alexisbatyk:x: Alexis BatykAlexis Batyk seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Templates for the file output

This feature provides users with the ability to customise the generated module file to their needs. With templates the generated module can support wider set of use cases, for example those that need to read the package name in addition to the version tag.
This feature solves or is related to various open and closed issues: #1 #12 #14 #19 #21 #24
Background
Most of the development effort put to genversion after the initial release relates to the exact format of the generated module file. There are various code style guides, linter rules, JavaScript variants and preferences in the wild that each require special formatting, beginning from the use of trailing semicolon and "use strict" directive. Some style guides even force each comment to end with a dot.
To support all those use cases, genversion has provided a set of boolean flags to control the output format. However, with the increased usage of genversion in real world projects, it has become evident that no number of flags will suit all the cases people confront in their development. Also, more flags means more complexity in genversion code and documentation burden. Introduction of a new flag requires careful consideration how it interacts with other flags and parameters.
In addition to formatting issues, there exists a need to read other properties from package.json aside the version tag. Users of genversion have described situations where they need to hardcode the name or description of their project to pass it to their client side while the version tag is provided via genversion. Although genversion – as the name suggests – is primarily concerned to deliver the version tag, its approach of read-and-generate fits those other situations well. Presumably, also the primary concern of the user is often the version tag but it would be very convenient for them if genversion provides more properties to go with the version.
Solution
Various solution ideas have been presented, ranging from addition of more flags and inclusion of additional exported properties all the way to generating additional module files and forking genversion for each package.json property: genname, gendescription, and so on. Although individual features, such as adding a new flag, would be relatively easy to implement, the complexity they bring grows exponentially with every new addition. Additional generated module files or project forks are possible solutions but they explode the complexity and maintenance burden even further.
Fortunately there is one solution that can solve most if not all of the issues above and that is the use of templates. How genversion currently functions is via a built-in ad-hoc template function that respects all the flags and parameters and outputs the generated module file. By accepting that the flags, regardless their number, cannot support all the use cases, and increasingly make the template function more complex we should make the template function replaceable instead. In other words, users should become able to select a built-in template that fits their use case or provide a their own.
Preferably, users select the template with a string parameter, either via command line interface or node API. Genversion should provide a set of basic templates that users can refer to by a short name. To support a custom templates, the same string parameter can be interpreted as a file path, borrowing from the Node's require function interface.
For inclusion of additional properties from package.json, genversion can expose those properties to templates. Then it is up to the template to decide which properties to render. This is safe, because the template is used only when genversion is ran, and only the rendered output is then passed to the client application. However, genversion should not expose all package.json properties to templates but only the most common ones that are considered safe. This is because there is a remote possibility that a bad custom template could in theory render all the package.json contents if the template were given the right to access all of those.
Challenges
The template approach does not come without downsides. Most obvious is the conflict with the current flags that control the format. To maintain backward-compatibility, those flags should still function after introduction of the template parameter. The template parameter likely overrides all those flags because we do not and should not have an easy way to format the specified template further. Such feature could be possible by depending eslint's --fix flag but that kind of complexity is too much to handle maintenance-wise for the small benefit of avoiding the override. The simplest approach for the template parameter is – if specified – to override any formatting flags.
Another challenge also has to do with the backward-compatibility. If the current and complex templating function were replaced with a set of simpler templates and option for a custom template, then how genversion should handle the formatting flags internally? Either we keep the old templating function and add the simpler templates next to it, or we use the flags just to pick the correct template among the built-in, simpler templates. The latter approach likely produces simpler architecture and frees us from the maintenance burden. This however comes with initial cost of having to write a template for each possible combination of the flags. There are currently four such flags implying 2^4=16 combinations. Sixteen built-in templates sounds manageable, thus we can agree to the approach of simpler architecture.
The template parameter that allows a custom template requires us to decide the templating language. The choice of templating language can be a personal thing and should not be only the favourite of the author (mine is EJS). Therefore the custom template parameter should be designed so that we can support multiple templating languages without major changes to API later. We can start with EJS and then add others if requested from the community. The language should be detected from the file extension of the custom template but because that might not always be accurate, there should also be another parameter that selects the templating engine.
Based on these considerations we can begin to form a specification. Regardless of major rewrite of genversion internals, it seems that we are able to maintain backwards compatibility. Therefore let us target this feature to genversion v3.2. We might possibly drop all formatting flags in v4 if favour of the template parameter.

Specification
CLI syntax: -t --template <name> --template-engine <name>
Node API: generate(..., { template: , templateEngine: , ... }, (err) => { ... })
The value of the template parameter is an optional string and either:

the name of a built-in template
an absolute or relative path to a custom template file

a path begins with ./, ../, or /
If the template is a relative path, it must be relative to the current working directory and not relative to package.json or the target file.

The default value of template is default and refers to CommonJS template that follows StandardJS style.
The value of the templateEngine parameter is an optional string. The choice of a template engine determines how the template is processed.
Possible values for templateEngine are:

auto, referring to automatic detection of templating engine based on template file extension. If the extension is unknown or the template is not a filepath but a name of a built-in template, ejs engine will be selected.
ejs, referring to EJS

More engines can be added in future if requested.
The built-in templates follow the naming of formatting flags by combining flag names. The template name begins with the JavaScript language version or module format abbreviation such that cjs for CommonJS and esm for ECMAScript modules. The name is then followed by modifiers that reflect the names of active flags, for example esm-double-semi for ES6 with double quotes and semicolons. The modifiers are given in alphabetic order and separated with dashes.
Available built-in templates:

default or cjs
cjs-double
cjs-double-semi
cjs-double-strict
cjs-double-semi-strict
cjs-semi
cjs-semi-strict
cjs-strict
esm
esm-double
esm-double-semi
esm-double-strict
esm-double-semi-strict
esm-semi
esm-semi-strict
esm-strict

Additionally, we can have built-in templates that export more properties beside version. Their usage can vary and therefore must take precedence in the names. Templates that export just the version do not have prefix (maybe could have v- prefix). Templates that export multiple values have prefix multi-.

multi-cjs
multi-cjs-double
multi-cjs-double-semi
multi-cjs-double-strict
multi-cjs-double-semi-strict
multi-cjs-semi
multi-cjs-semi-strict
multi-cjs-strict
multi-esm
multi-esm-double
multi-esm-double-semi
multi-esm-double-strict
multi-esm-double-semi-strict
multi-esm-semi
multi-esm-semi-strict
multi-esm-strict

Comment: due to the required number of built-in templates and their repetitive nature, we might want to reconsider the approach. Especially with multiple exported properties, users likely want to control what properties they want to include. It is much easier for users to list the properties, for example --properties name,version,author than to learn how to write a custom EJS template.

Discussions in separate issue #22 and #26 have indicated a partial solution to templating with --variable flag. With --variable users can specify a special placeholder string to be replaced with the version tag, effectively letting users to hardcode the placeholder anywhere in their codebase and then using genversion to substitute it with the actual version tag after compilation and bundling.

After more inspection, --variable flag idea is now dropped as unfeasible. Its replacement approach does not work for bundles because it would break source maps and checksums. It is not very useful before bundling either.
Therefore --template should have the variables already baked in with the templating engine syntax. Genversion provides at least two parameters for templates: properties and options, where the first is a subset of package.json and the latter contains all formatting options the template designer can respect or neglect.

The --template and --template-engine options were implemented and released today in v3.2.0.
Architecturally, we decided to stay in single built-in template function and discard all the built-in template madness ideas above. In other words, genversion v3.2.0 functions as before, with the added possibility for user to use a custom template.


DHCP

Hi ' how can add dhcp option for auto ip configuration...
i want to setup one config file for many clients

I doubt you can, because wireguard uses key-based routing, one private key belongs to one IP address. So you must have a unique config for each  client.


[Android] [5.2.1] Can see Android MediaPlayer logs even-though setup to support ExoPlayer

Bug
I can see logs from Android MediaPlayer and ExoPlayer on LogCat even though the library was set up to support ExoPlayer. I have followed the documentation to do the setup.
Platform

Android

Environment info
React native info output:
System:
    OS: macOS 12.6.1
    CPU: (8) arm64 Apple M1
    Memory: 80.80 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.17.1 - ~/.nvm/versions/node/v16.17.1/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v16.17.1/bin/yarn
    npm: 8.15.0 - ~/.nvm/versions/node/v16.17.1/bin/npm
    Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
  Managers:
    CocoaPods: 1.11.3 - /opt/homebrew/bin/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 22.1, iOS 16.1, macOS 13.0, tvOS 16.1, watchOS 9.1
    Android SDK: Not Found
  IDEs:
    Android Studio: 2021.2 AI-212.5712.43.2112.8512546
    Xcode: 14.1/14B47b - /usr/bin/xcodebuild
  Languages:
    Java: 11.0.15 - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 18.2.0 => 18.2.0
    react-native: 0.70.7 => 0.70.7
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Library version: 5.2.1
Steps To Reproduce

Install package by yarn add react-native-video
Configure ExoPlayer as following in settings.gradle file.

include ':react-native-video'
project(':react-native-video').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-video/android-exoplayer')

Following are some logs from the LogCat
2023-06-12 19:55:48.388 32558-1155/com.test.exoPlayer W/unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.brentvatne.exoplayer.ReactExoplayerViewManager

2023-06-12 19:58:45.752 32558-1155/com.test.exoPlayer V/MediaPlayer-JNI: native_setup
2023-06-12 19:58:45.753 32558-1155/com.test.exoPlayer V/MediaPlayerNative: constructor
2023-06-12 19:58:45.757 32558-1155/com.test.exoPlayer V/MediaPlayerNative: setListener
2023-06-12 19:58:45.785 32558-1155/com.test.exoPlayer V/MediaPlayer-JNI: setDataSourceFD: fd 216
2023-06-12 19:58:45.785 32558-1155/com.test.exoPlayer V/MediaPlayerNative: setDataSource(216, 237637514, 15933)
2023-06-12 19:58:45.803 32558-1155/com.test.exoPlayer W/MediaPlayer: Use of stream types is deprecated for operations other than volume control
2023-06-12 19:58:45.803 32558-1155/com.test.exoPlayer W/MediaPlayer: See the documentation of setAudioStreamType() for what to use instead with android.media.AudioAttributes to qualify your playback use case
2023-06-12 19:58:45.806 32558-1155/com.test.exoPlayer V/MediaPlayer-JNI: setAudioStreamType: 3
2023-06-12 19:58:45.806 32558-1155/com.test.exoPlayer V/MediaPlayerNative: MediaPlayer::setAudioStreamType
2023-06-12 19:58:45.807 32558-1155/com.test.exoPlayer V/MediaPlayerNative: setVideoSurfaceTexture

2023-06-12 19:59:28.639 32558-32558/com.test.exoPlayer I/ExoPlayerImpl: Init e184650 [ExoPlayerLib/2.13.3] [a52, SM-A525F, samsung, 33]
2023-06-12 19:59:28.668 32558-32558/com.test.exoPlayer D/ReactExoplayerView: onStateChanged: playWhenReady=true, playbackState=idle
2023-06-12 19:59:28.680 32558-32558/com.test.exoPlayer D/ReactExoplayerView: onStateChanged: playWhenReady=true, playbackState=buffering
2023-06-12 19:59:31.404 32558-32558/com.test.exoPlayer D/ReactExoplayerView: onStateChanged: playWhenReady=true, playbackState=ready
2023-06-12 19:59:58.666 32558-32558/com.test.exoPlayer D/ReactExoplayerView: onStateChanged: playWhenReady=true, playbackState=ended
2023-06-12 19:59:58.788 32558-32558/com.test.exoPlayer D/ReactExoplayerView: onStateChanged: playWhenReady=false, playbackState=ended
2023-06-12 19:59:58.838 32558-32558/com.test.exoPlayer D/ReactExoplayerView: onStateChanged: playWhenReady=false, playbackState=buffering
2023-06-12 20:00:00.195 32558-32558/com.test.exoPlayer D/ReactExoplayerView: onStateChanged: playWhenReady=false, playbackState=ready

1/ Did you do a gradlew clean ?
2/ do you find these logs in react native video ? The system can also display logs with MediaPlayer...

@freeboub

I did a gradlew clean
I found these logs when I run adb logcat | grep -i mediaplayer & adb logcat | grep -i exoplayer respectively
I test this on several devices. But I can see both logs.

Is there any additional step in the setup process other than the ones I have mentioned?

No I think you integration is ok.
If you want to do a complementary test, you can try to use the V6 release. On this release MediaPlayer implementation has been totally removed.
If you still see the logs, it means that they are expected ...
Notice that both integrations are exclusive. You cannot use both player in the same build.


Add pr template

Any addition should be written in index.html.

Hello @tapaswenipathak I am confused on what this issue is about

On Sat, May 11, 2019 at 11:35 AM Onyemenam Ndubuisi
<EMAIL_ADDRESS>wrote:

Hello @tapaswenipathak I am confused on what this issue is about

PR template should have
 -

[ ] You have added the SoC/WoC in README.md file in correct table
[ ] You have added the SoC/WoC in index.html in correct table
[ ] Website tested on a deployment

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

--
Tapasweni

@tapaswenipathak I think we can close this issue.


Bug fix use after free on load channel in work load group scheduler

Proposed changes
fix use after free on load channel in work load group scheduler
introduced by #36176

run buildall

run buildall


Support for JSON 7.0 conditionals?

Question | Feature Request
For bugs/questions:

OS: Pop_OS 19.10
Python version 3.7.3
Pydantic version 0.25

It would be useful for me if conditionals (if, then, else) were supported.
In this example, I'm not using code because I realize there might be alternate ways to do this thing I need done.  I have read many docs, but I am new at implementation.
Example situation:
'animal' is an Enum, which holds 'cat', 'dog', and 'horse'.
'sounds' is also an enum, but it changes depending on 'animal'.  Horse has 'neigh', 'whinny' and 'snort'; cat has 'purr', 'meow', 'hiss';  dog has 'bark', 'whine' and 'growl'.
Is there some way to get Pydantic to write this into Schema?  I understand that JSON 7.0 supports this.  I can probably use custom validation to validate existing JSON, but I'd love for it to be explicit in the schema.  And, yes, I can write that part of the schema myself if needed.
Thanks!

@Lachele there's currently no way to make Pydantic generate JSON Schema with if, then, else.
For now, I think you would have to use Union and validation.
Also, you can use Schema to pass any other keyword argument to be included in the final schema for each field: https://pydantic-docs.helpmanual.io/#schema-creation

Thanks!  It's not that big a deal in my schema.  I was just wondering if I missed something.  Thanks for the tip about including custom keywords - I had missed that!


Truncated tweets and not receiving DMs - twitter node

What happens?
Regarding the changes in the Twitter API, If the tweet is longer than 160 characters the twitter input node returns a truncated msg.tweet.text and msg.tweet.truncated is true.
Just a few tweets includes an extended_tweet object with the full text and entities.
Could you update the node and include the extended param to get the full tweet by default?
https://stackoverflow.com/questions/38717816/twitter-api-text-field-value-is-truncated
In the other hand, the twitter node is not receiving any incoming direct message. The Twitter app has the proper permissions.
Please tell us about your environment:

[ ] Node-RED version: 0.18.7
[] twitter node version: 1.0.1
[ ] Platform/OS: Bluemix
[ ] Browser: safari

Duplicate of https://github.com/node-red/node-red-nodes/issues/464 and https://github.com/node-red/node-red-nodes/issues/443


Pylint and static code analysis

Changes

Added Pylint as a development dependency
Added .pylintrc file, which is based on Google's Python style guide
Updated all yamlator/ and tests/ files to fix any Pylint violations
Updated the pycodestyle max line length to 80 to match Pylint

Codecov Report

Merging #33 (cdc7a8e) into main (6205f8b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #33   +/-   ##
=======================================
  Coverage   99.67%   99.67%
=======================================
  Files          19       19
  Lines         609      616    +7
=======================================
+ Hits          607      614    +7
  Misses          2        2

Impacted Files
Coverage Δ

yamlator/validators/__init__.py
100.00% <ø> (ø)

yamlator/validators/base_validator.py
100.00% <ø> (ø)

yamlator/validators/optional_validator.py
100.00% <ø> (ø)

yamlator/validators/required_validator.py
100.00% <ø> (ø)

yamlator/__init__.py
100.00% <100.00%> (ø)

yamlator/cmd.py
100.00% <100.00%> (ø)

yamlator/exceptions.py
100.00% <100.00%> (ø)

yamlator/parser.py
98.64% <100.00%> (+0.01%)
:arrow_up:

yamlator/types.py
100.00% <100.00%> (ø)

yamlator/utils.py
100.00% <100.00%> (ø)

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6205f8b...cdc7a8e. Read the comment docs.


./vttcompile -a fails on the vttdemo.ttf on linux

Just trying vttcompile on the vttdemo.tff shipped with VTT. -s -b and -c completes with success, but -a fails with:
$ ./vttcompile -a ../Sample/vttdemo.ttf /tmp/t.ttf

Microsoft Visual TrueType Command Line Interface Version 6.35
Copyright (C) Microsoft Corporation. Licensed under the MIT License.
....................
...............
Glyf Pgm, glyph 341 (Unicode 0xb8), line 10: NN

Can not complete compile operation!

This is after #17 and fixing #19 . Given #19 (it was surprising to see vttcompile failing on the shipped ttf with the maxp error, and that turns out to be a genuine bug), I'd assume the vtt shipped vttdemo.ttf should be valid and can be used as input to vttcompile for all operations. If it isn't, it should - that's still a bug, but a bug in the font, so the issue should still be reported.

The text parser and etc on unix is quite buggy - I ran a 32-bit cross-compiled build under wine, and it returns success:
Z:\home\Hin-Tak\git-others\VisualTrueType\src>vttcompile.exe -a ../Sample/vttdemo.ttf w2.ttf
Microsoft Visual TrueType Command Line Interface Version 6.35
Copyright (C) Microsoft Corporation. Licensed under the MIT License.
....................
...............
Success

Z:\home\Hin-Tak\git-others\VisualTrueType\src>

For some reason, -m32 also works allow the result to run to completion.
And about the missing characters, besides \r vs \n (in the code it is sometimes \x0d vs \x0a), it should be said that wchar in microsoft land is 16-bit and same size as short, but on gcc/linux/glibc, it is 32-bit and also int.

The reason why -m32 works is because some of the code use %li to print to a buffer then parse it back. That's is an implicit cast to "long". Anyway, all fix in #22 .

Actually mingw turns out to use the same 16-bit for wchar as msvc; but  it uses only fwprintf, fprintf, vfprintf, wprintf_s from the microsoft runtime; so all the swprintf() are still internal (and seem to follow other gcc convention, rather than windows convention).

fixed with #22 - https://github.com/microsoft/VisualTrueType/commit/e0d3cfa4ce7b5951f040515771c0604f9b906a8e


Update "Set default branch explicitly"

#243 seems like an important change. This is my crude attempt (without know much about this package or the tools it relies on) to update it to important changes. This most important thing is that #297 didn't fix this PR. I have no idea if this is OK, any chance you could take a glance @mjram0s? Just the last commit is different.
One of the tests that I marked as broken is explained in https://github.com/invenia/PkgTemplates.jl/pull/315#issue-748091329.

This is finally passing. I just disabled certain problematic tests for Windows; since this package isn't something I know a lot about, that just seems expedient. I could file an issue as a reminder to turn on Windows again some day. (The error was quite strange, a permissions error on a directory & file created by mktemp(). That doesn't seem like it should happen. But I can't easily debug it locally, and for all I know it's a CI-only error.)

You did all the hard work, my contribution ended up being a few lines. And I learned a bit (just a bit...) about the internals of an important package for the ecosystem. Thanks again for everything you've done for this package!


Feature request: Bundling code

I see typescript as a great solution to the mess of modern day front-end web development, where you have to use a module bundler, transpiler, other loaders ... etc.
Webpack is a great tool, but sometimes it's just an overkill and adds it's own runtime overhead.
TypeScript does a great job of compiling modern ES6 all the way down to ES3 thus eliminating the need for Babel and such. However, I still need to use rollup or webpack to bundle my compiled TypeScript code!
It would be great if there's a feature where my whole TypeScript project gets bundled into a single file without the need for require.js or system.js, much like what rollup does.

This has been discussed many many many times before. (see #8918 for example) and TypeScript already supports a limited set of bundling (see #6261).
Also, it is contrary to the non-goal of TypeScript:

Provide an end-to-end build pipeline. Instead, make the system extensible so that external tools can use the compiler for more complex build workflows.

Module resolution is complex, especially when you have to be able to support circular module references, which for various reasons AMD and ESM both support.  Also, things like WebPack and Rollup deal with other resources too.  Almost any decisions other than the basic bundling already support will likely work for no-one instead of being useful to anyone.

As noted, this has been brought up before. There's really no reason for us to re-implement webpack / rollup / whatever bundler comes next.

Almost any decisions other than the basic bundling already support will likely work for no-one instead of being useful to anyone.

🏆 ❤  ⭐


updating skipRange in generated csv

updating skipRange in the generated csv which was missed in the original PR.

/retest


Thoughts on debugging rejected promises

It's sad that with promises we're losing ability to pause execution on exceptions exactly where they were thrown.
We always have two absolutely different cases:

When something went wrong and regular exception was thrown. I.e. usual ReferenceError or TypeError. The same is when we are throwing our own exception, i.e. when we don't have enough arguments passed to some method.
When we want to say that current async operation has not finished successfully or even when it should not be executed at all. I.e. when we are about to do something that depends on user's permissions we'd like to have it that way:

user.addFriend(friendId)
    .then(sendNotification, showFriendshipDisabledMessage)
    .then(showUserProfile)

To make this code work we have to throw an exception in user.addFriend() method to reject the operation promise. This is bad, because exception assumes something unexpected and critical. Here we have regular situation when some user has disabled friend requests and it's normal. We just have to notice current user about that and go on.
Now let's pretend we have that code synchronous. We'd hardly throw an exception in that place for client code to handle it by try/catch. We'd return null or false for him to just check it.
We could use that approach here, but then client code would be something like:
user.addFriend(friendId).then(function (isFriendAdded) {
    if (isFriendAdded) {
        sendNotification().then(showUserProfile);
    } else {
        showFriendshipDisabledNotice();
    }

    return isFriendAdded;
})

That code looks awkward and promise chain is broken. Moreover we can realize here that we should name that method not addFriend but kind of tryToAddFriend.
Seems that finally it would be better to use previous approach and throw exception in user.addFriend().
Now the worst thing is coming when we are about to debug that code. Either we use done or not we face strange behavior. If we do, we have exceptions when user has disabled friendship. If not, user will see that "friendship disabled" notice when we forget to pass friendId and real TypeError is thrown.
Also regarding to #522 and #625 I assume that done() seems not to be obvious and natural. It's messing the logic and the debug. We always have to check the right spot to place it and remember to remove it, i.e. when we start to return promise. And it's out of spec, btw.
In our project we chose to adopt the convention that we don't reject promises by throwing exceptions but by returning another rejected promise (using analog of Q.reject). This allows us to setup the debug mode when exceptions in promises are not swallowed and we are able to pause execution on the right place and get full stack trace and navigate through it.

+1 for this
debugging exceptions (or rather detecting where they occured) is a pain atm

You are not alone in these thoughts. Much of the conversation about promises involves these issues.
As for .done(), Q is a dialog with the Promise spec, not an adherent. Q influenced the evolution of the spec and the evolution of the spec influences Q. .done() may or may not become vestigial as developer tools improve.
Across the board, developer tools are exposing a promise inspector which shows unhandled rejections. The thing about an unhandled rejection that makes them unsuitable for plain old logging is that they can be eventually handled. Also, since a promise can be observed by anyone at any time, a handler can be introduced asynchronously. This is anticipated by the design.
Distinguishing operational errors from programmer errors is also a common topic. One could theoretically allow programmer errors to pass through and halt a program. This may or may not be desirable in production, mostly depending on whether a service is stateless, whether you manage your side-effects carefully, whether you can restart quickly, whether your availability matters more than your consistency, &c. So there is no one-size-fits-all for that. Using Q.reject to distinguish asynchronous operational errors from synchronous programmer errors is smart. Similarly, one could require Q.resolve for asynchronous resolution. At that point you have taken on all the burdens necessary to get rid of the recursive unwrapping feature of promises, then becomes equivalent to flatMap in the Monad world. But that’s a different library with a backward incompatible change to its semantics. I won’t even contemplate that for v2. That is not to say it is a bad idea.
The other issue is that promise chains branch and merge, as above. Ideally your whole program can be modeled as a single asynchronous function call with one way in and one way out, in which you would only ever call .done() once. That is admittedly difficult. Also, handling one branch of a promise chain does not necessarily mean that the root cause of an exception has also been handled by another branch of the promise chain. So, a.then(b).done() does not mean that a.then(c).done() should omit its done() clause, even though a rejected A promise would get reported twice.
In any case, I thank you for your thoughts. I am closing this issue for the purpose of triaging actionable issues. Continued discussion is welcome.


Idle time with no ascension time problem

Game wont let you start if you have idle time with no ascension time.
line 100 should look more like this I think.
if (idleMinutes > minutesPerAscension && minutesPerAscension != 0)

Thanks for pointing this out!  Fixed it with version 4.2


Gated Marketplaces: Owner approval

Before users can list a tax credit for sale, they must FIRST receive approval from the marketplace owner:

[ ] Waiting on #122
[ ] Create a new storage map to track owner approval
[ ] Create an extrinsic in the gated-marketplace pallet to allow the owner to unfreeze the tax credit
[ ] Once the owner has approved the tax credit, the item can be put up for sale

No longer needed.


When an email with attachment is send, it keeps on creating duplicate emails in "Email messages"

Hi,
When I send a mail with attachment and when I check the "Email messages" section on cyphon, I could see duplicate emails created twice every minute with the same subject name.

I have uploaded the SS, I there a possible solution for this issue?

Hi @sajeeshgit, this can happen when the Celery task is not able to empty the inbox before the next task interval starts. Try increasing the interval in your config/cyphon/settings/base.py file to see if that resolves the issue, e.g.:
CELERYBEAT_SCHEDULE = {
    'get-new-mail': {
        'task': 'tasks.get_new_mail',
        'schedule': timedelta(seconds=60)
    },
    ...
}

@lhadjchikh thank you for the response, I solved the issue by deleting the mail with attachment at the source; reason for doing this was I want the mail fetch intervals as minimum as possible.

Ok. You might want to double check your settings, though, to make sure the attachment was allowed:

``


How does this library implement context

I'm using gin as the back end of the web, but I can't seem to implement the context when I call, for example when I ask it "What is a chatGPT?" It answered me, but when I asked it again, "Who invented it?" At this time, it replied to me not related to Chatgpt, but other content I hope someone can answer my question, thank you!

Sounds like you need to include the context of previous messages inside the request you send, otherwise it will not remember what was talked about previously.

Ok, I see. Thank you. Now the conversation is normal and the context is normal.

Sounds like you need to include the context of previous messages inside the request you send, otherwise it will not remember what was talked about previously.

Ok, I see. Thank you. Now the conversation is normal and the context is normal.


CTC-79 Progress bar on the check-quality command

Closes CTC-79

Hey @aranega I commented an unused import because it was making the tool not work


Cleanups/improvements to streams/queue.h/c++

Should not remove the close sentinel from the buffer in handleRead
Avoid using kj::Refcounted for queue entries

Going to be adding a bit more to this...


fix: resolved nil pointer dereference bugs.

Signed-off-by: wasabi<EMAIL_ADDRESS>

This bug caused me to encounter a null pointer reference, which happened when calling GetOrganizationByUserwhen(user *User) *Organization, argument *user is nil
context：
2021/06/09 15:00:25.086 [C]  the request url is  /api/get-account
2021/06/09 15:00:25.086 [C]  Handler crashed with error runtime error: invalid memory address or nil pointer dereference
2021/06/09 15:00:25.086 [C]  /usr/lib/golang/src/runtime/panic.go:969
2021/06/09 15:00:25.086 [C]  /usr/lib/golang/src/runtime/panic.go:212
2021/06/09 15:00:25.086 [C]  /usr/lib/golang/src/runtime/signal_unix.go:742
2021/06/09 15:00:25.086 [C]  /root/casdoorr/object/organization.go:97
2021/06/09 15:00:25.086 [C]  /root/casdoorr/controllers/account.go:181
2021/06/09 15:00:25.086 [C]  /usr/lib/golang/src/reflect/value.go:476
2021/06/09 15:00:25.086 [C]  /usr/lib/golang/src/reflect/value.go:337
2021/06/09 15:00:25.086 [C]  /root/go_workpath/pkg/mod/github.com/astaxie/beego@v1.12.3/router.go:897
2021/06/09 15:00:25.086 [C]  /usr/lib/golang/src/net/http/server.go:2843
2021/06/09 15:00:25.086 [C]  /usr/lib/golang/src/net/http/server.go:1925
2021/06/09 15:00:25.087 [C]  /usr/lib/golang/src/runtime/asm_amd64.s:1374
2021/06/09 15:00:25.087  [HTTP] http: superfluous response.WriteHeader call from github.com/astaxie/beego/context.(*Response).WriteHeader (context.go:230)

wait, it seems that the front-end cannot accept the organization as nil.

@sh1luo when does this happen?

When the user does not exist in the database, the function func (c *ApiController) GetAccount() under the controllers package will still be called, and the return value user is nil. At this time, calling object.GetOrganizationByUser(user) will causes the program to crash because of  nil pointer reference. even if the object.GetOrganizationByUser(user) function is judged, the front end will still report an error, "can't set property "organization" of null" as seen in the previous picture.
I think the function func (c *ApiController) GetAccount() should be modified to:
func (c *ApiController) GetAccount() {
    userId, ok := c.RequireSignedIn()
    if !ok {
        return
}

var resp Response

user := object.GetUser(userId)
    if user != nil {
    organization := object.GetOrganizationByUser(user)
    resp = Response{Status: "ok", Msg: "", Data: user, Data2: organization}
} else {
    resp = Response{Status: "error", Msg: "Please sign in first"}
}

c.Data["json"] = resp
c.ServeJSON()
}

In this way, line #148 in web/src/App.js can throw an error normally.
This is a screenshot, there are only default users in the database (users without name=主管理员)

sorry,It seems that there is still a problem, let me take a look

This screenshot is a little strange, I think it has no reference value.
However, the problem with function func (c *ApiController) GetAccount() still exists, it's just latent,  we haven't found it yet, so this code is still necessary :)


[Solved] mismatch typing to api response

Describe the bug
So I am using this library to interact with the API, but the type definitions are buggy as some responses don't match what to expect according to API reference. As you can see in the screenshot below, I only get three object keys for a single database object after using the result from the search api.
To Reproduce
Node version: v16.13.0
Notion JS library version: 1.0.4
Steps to reproduce the behavior:
import { Client as notionClient } from "@notionhq/client";
.....
const notion = notionClient({ auth: user.token });
const response = await notion.search({ filter: { property: "object", value: "database" }});
const results = response.results

if (results && results .length > 0) {
		results.map(base => {
			if (base.object === 'database') {
				base // see screenshot below for prediction
			}
		})
	}
....

Expected behavior
I should have access to all object keys for a database object as mentioned in https://developers.notion.com/reference/database#all-databases.
Screenshots

I think I figured it out by myself(https://twitter.com/_waptik/status/1521212734381203458). It would be great if there were documentation indicating how to access objects from responses.

Thank you for your finding!


temp fix transaction fees issue

Fixed fees with no default value causes web socket crash bug on account property transactions

Pull Request Test Coverage Report for Build 197

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.3%) to 71.133%

Totals

Change from base Build 195:
-0.3%

Covered Lines:
1004

Relevant Lines:
1292

💛  - Coveralls


Dark mode for website

Since in modern days many would like to choose view web pages in dark mode ...

I would Like to implement this feature for this project...@apu52 please may this task assigned to me?

please describe the issue in proper way with some screenshots, and how it will look after the feature, add a good title for issue as its good practise.Happy coding.

please describe the issue in proper way with some screenshots, and how it will look after the feature, add a good title for issue as its good practise.Happy coding.

please describe the issue in proper way with some screenshots, and how it will look after the feature, add a good title for issue as its good practise.Happy coding.

Okay sure

@Prithwi32 Welcome to the repo.
Sorry to close this issue.
Make sure to open the issues after coding period starts

@Prithwi32 Welcome to the repo. Sorry to close this issue. Make sure to open the issues after coding period starts

hello @apu52  Sure sir. I will open this issue after coding phase starts.

@Prithwi32 Welcome to the repo. Sorry to close this issue. Make sure to open the issues after coding period starts

hello @apu52 Sure sir. I will open this issue after coding phase starts.

I will suggest you to open an new issue instead of reopening this old one

@Prithwi32 Welcome to the repo. Sorry to close this issue. Make sure to open the issues after coding period starts

hello @apu52 Sure sir. I will open this issue in the same topic after coding phase starts.

I will suggest you to open an new issue instead of reopening this old one
Okay, U want me to work on dark mode feature or different feature you like me to contribute?

@Prithwi32 Welcome to the repo. Sorry to close this issue. Make sure to open the issues after coding period starts

hello @apu52 Sure sir. I will open this issue in the same topic after coding phase starts.

I will suggest you to open an new issue instead of reopening this old one
Okay, U want me to work on dark mode feature or different feature you like me to contribute?

You can raise any issue you want to work on . Just look at the existing issues before raising new issues.


Add support for the cases environment

While #246 added support for the \begin... \end environment (which is terrific!), it would be also great to support cases environment in order to create systems of simultaneous equations (examples here: https://kogler.wordpress.com/2008/03/21/latex-multiline-equations-systems-and-matrices/).

The cases environment looks really useful, especially for piecewise functions.

Relevant part of amsmath.sty:
\renewenvironment{cases}{%
  \matrix@check\cases\env@cases
}{%
  \endarray\right.%
}
\def\env@cases{%
  \let\@ifnextchar\new@ifnextchar
  \left\lbrace
  \def\arraystretch{1.2}%
  \array{@{}l@{\quad}l@{}}%
}

The most important here seems to be the non-default \arraystretch, which the current array implementation doesn't support yet.

Implemented by @gagern.  This is now on master, but isn't yet part of an official release.


How do I use my own copy of sqlite3.dll

I have purchased the Sqlite Encryption Extensions which allows me to build a version of the sqlite3.dll which encrypts the contents of the database.
I wan to use this sqlite.dll to replace the version of sqlite used by iOS and Android.
How do I go about doing this?

Update - Looking through the code, I see static libraries esqlite.a for iOS. Do I just have to build the sqlite3 library as a static library, and overwrite this file,  and the application will use this version of sqlite rather than the one installed on iOS? I assume it is a similar process for Android?

What's your timeframe on this?
I've been nearing completion on a new release (version 0.9.0).
The answer to your question now is very different from the answer to your question after 0.9.0 is released.

Hi Erik, my timescales would be within the next month, however I am using MvvmCross, and I hope to be moving to v4 soon. Looking at the new SQLite plugin for v4, it does not seem to use SQlitePCL.Raw any more. So I think I don't have this need anymore. Am I correct in this assumption?
Although it looks like the library now used in the plugin, SQLite.NET-PCL, only uses DllImport to use the SQLite library deployed with iOS and Android.

Hmmm.  I didn't realize the MvvmCross plugin was ever using SQLitePCL.raw.  Somewhere I got the impression they were doing something different.
Anyway, looking now at their v4 plugin, yeah it looks like they're using the oystein.krog fork of praeclarum's sqlite-net.
So yeah, you're heading in a different direction.

Yeah, I think they used a library which used SQLitePCL.Raw.
Thanks for answering my question Eric. I read you article on sqlite corruption which explains the best way to link to a custom version of sqlite, it helped me a lot.

I am looking for the right approach to use sqlite with SEE in xamarin.iOS. I have a static library built from the SEE sources. How do I use this to the application instead of the system library?

I need to make this case easier.  But for now, here's how to do it:

Compile (csc or mcs) gen_build.cs

Run gen_build.exe to create the bld directory

cd bld (the directory created by gen_build.exe)

cd plugin.sqlite3.ios_unified

Modify the csproj file in that directory.  Look at the ManifestResourceWithNoCulture line.

The 1.0 release contains better support for using a custom SQLite build.  Still a little tricky, but better.  See the "custom_sqlite3" provider.  For iOS, see the SQLitePCLRaw.provider.internal.

Guys, how can I use newer dll version of SQLite from my Xamarin.iOS project ?


Document that "page" is a reserved route value for Razor Pages

The term page (like controller, action, and area) is reserved for routing in Razor Pages. It doesn't look like we have this documented anywhere.

@guardrex  should we document this in https://docs.microsoft.com/en-us/aspnet/core/mvc/razor-pages/razor-pages-conventions ?


Currently crashing for me...

Hi,  This plugin is crashing Sketch on me.  I'm on Sketch 3.3 running OSX 10.9.5 on a 2014 MacBook Pro.

I have the same problem, Sketch 3.3.1 on OSX 10.10.1, on a Mid-2012 MacBook Pro.

Still not working :(

Sorry about this, I missed this myself and did not get a notification about these reports.

Just out of curiosity, was it fixed?
Thanks,
Kevin

Yes, it was, with #6

Yep, I merged the commit from @jslvtr, thanks again. :)

Appears to be working now!  Thanks!

Awesome sauce.  Thanks!


fix: localization keys added to change messages hl-1213

Description :sparkles:
Missing localizations added.
commissionAmount is not anymore in use, but it was seen in one test case showing
changes.fields.commissionAmount.label:
(tyhjä)->(tyhjä)
Issues :bug:
Testing :alembic:
Screenshots :camera_flash:
Additional notes :spiral_notepad:

API branch is deployed to platta: https://helsinkilisa-pr2880.api.dev.hel.ninja/healthz :rocket::rocket::rocket:

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2880.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is success for https://helsinkilisa-ui-pr2880.dev.hel.ninja :laughing::tada::tada::tada:

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2880.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is success for https://helsinkilisa-ui-handler-pr2880.dev.hel.ninja :laughing::tada::tada::tada:


Can not use flipper template

version

@astar-network/swanky-cli/1.0.0-rc.4 darwin-x64 node-v18.0.0

You may already know the solution.
This issue is caused by the absence of test code templates in the following directory:
'node_modules/@astar-network/swanky-cli/node_modules/@astar-network/swanky-templates/dist/templates/contracts/ink/flipper/test'
Creating the "test" directory and "flipper.test.tx.hbs" file here will avoid the error.

Thanks! You're right, it's the missing template - will be patched in the next release 👍

This is fixed in v1.06.
Note that the flipper contract itself is changed a bit to return a bool value, so it might be inconsistent with original flipper examples.