UP-4647:  Suppress noisy WARN messages for optional properties files

https://issues.jasig.org/browse/UP-4647

@jameswennmacher -- That's a good suggestion, and not one that I thought of before.  It may be feasible (and we should do it if it is), but I'm concerned that it may not work.  This change is to the setLocations() method, which is a bean setter method.  I'm not sure the order in which properties are set is known or reliable.  Even with ignoreResourceNotFound=true in the xml, I'm not sure we'll know it in time.
And I'm not sure we have the opportunity to refactor the code to a @PostConstruct method.  It may be too late, and I' not sure about what the superclass may do with @PostConstruct.

That's a good point about the property order.
At the moment the only place this class is used is applicationContext which has ignoreResourceNotFound=true so it doesn't matter for our current use but it would be confusing and painfully misleading if someone else uses it without setting that flag.
I think you could instead override loadProperties(Properties props) to call super if ignoreResourceNotFound=false but if ignoreResourceNotFound=true (and this is a bit ugly) filter the locations (which means you are effectively post-processing the locations property) and then call the super method.  I'm thinking this is the best solution.
If you don't do that or something similar, at minimum I'd place a warning comment in the javadocs for ExtendedPropertySourcesPlaceholderConfigurer making it clear that there is a hazard if you don't set ignoreResourceNotFound=true (a missing file would be ignored instead of failing bean creation) and also place a warning in its current use in applicationContext.xml.  That of course wouldn't be sufficient, but at least there would be some visibility/acknowledgement of the issue.  By the same token if we end up on this path, I'd rename ExtendedPropertySourcesPlaceholderConfigurer to ExtendedPropertySourcesPlaceholderConfigurerIgnoresMissingResources so it is more clear.

@jameswennmacher -- Documentation of loadProperties is sparse;  I had to look at the source to understand it's role in the class:  http://grepcode.com/file/repository.springsource.com/org.springframework/org.springframework.core/3.2.2/org/springframework/core/io/support/PropertiesLoaderSupport.java#PropertiesLoaderSupport.loadProperties(java.util.Properties)
There is an issue:  the locations member variable is private, and there is no getLocations() method.  I'd have to overload setLocations(), hold onto the collection, then overload loadProperties() and call setLocations within that before calling super.loadProperties().  This approach has a certain code smell.
Better, I think, is to take ignoreResourceNotFound out of the xml entirely and call setIgnoreResourceNotFound(true) inside the constructor... and document that this impl is ALWAYS ignoreResourceNotFound=true.

I see.  Sounds good.  I do suggest renaming the class then to make it painfully obvious. :smile:

I renamed it, but I thought the example name was even more painful than obvious (though it was obvious).  I added a big, descriptive javadoc comment at the class level.

+1 for descriptive javadocs!

@drewwills what can I say.  I have a greater tolerance/love for long names than most people. :smile:

+1 on the recent changes.


Add billing estimator styles

found a not-used style. also repeating-linear-gradient is not being rendered as expected on Safari. fixing now.. 🔨


Connection state raises an error

As reported by @zulufoxtrot in #49, the SDK crashes when subscribing to the connection state:
Autopilot.py", line 268, in get_connection_status
async for connection_state in Autopilot.vehicle.core.connection_state():
AttributeError: 'NoneType' object has no attribute 'connection_state'

That is fixed now.


For small size M, like the shape M=1 K=5120 N=1792, how to improve the performance with triton?

Hi triton team,
I try the tutorial @ https://github.com/triton-lang/triton/blob/main/python/tutorials/03-matrix-multiplication.py, and set M=1 K=5120 N=1792, and want to check whether triton could compete with cublas in this case.
Here is the result:
Triton:294us
torch.matmul: 64us
I understand in the tutorial there is only a few tuning confg there, so how I could improve the triton speed further to make it competitive with torch's natvie method?
Thx~

FYI:https://github.com/triton-lang/triton/blob/main/python/triton/ops/matmul.py.   SPLIT-K should be able to solve such problems.

SPLIT-K

Great! It seems that the tutorail itself don's support splitk, so we need to make it change to have it tested with 03 tutorial?
And after applying with splitk, how much performance you saw comparing with torch?
Thx~

IMHO, I don't think we should change 03tutorial.
You can do  benchmarking on your own.
because your M=1， it also applies to the problem domain of GEMV.


Usage with more than one sequence type

I'm working on a serde implementation of EDN, which has 3 different types of sequences: vectors, lists, and sets. I'm looking for the best way to serialize and deserialize these using serde.
I started by forking serde_json, so I can successfully deserialize a vector into a Value::Vector just like a JSON array using ValueVisitor.visit_seq:
fn visit_seq<V>(self, mut visitor: V) -> Result<Value, V::Error>
                where
                    V: SeqAccess<'de>,
            {
                let mut vec = Vec::new();

                while let Some(elem) = try!(visitor.next_element()) {
                    vec.push(elem);
                }

                Ok(Value::Vector(vec))
            }

I keep thinking I should call visit_seq when I detect a list in the input stream, but visit_seq doesn't seem to be able to know to return a Value::Vector vs a Value::List.
I'm running into a similar problem on the serialization end, where I can write out the correct [] for a vector through serialize_seq, but can't figure out a way to disambiguate from other sequence types like list which requires () be written out instead:
fn serialize_seq(self, len: Option<usize>) -> Result<Self::SerializeSeq> {
        if len == Some(0) {
            try!(self
                .formatter
                .begin_vector(&mut self.writer)
                .map_err(Error::io));
            try!(self
                .formatter
                .end_vector(&mut self.writer)
                .map_err(Error::io));
            Ok(Compound::Map {
                ser: self,
                state: State::Empty,
            })
        } else {
            try!(self
                .formatter
                .begin_vector(&mut self.writer)
                .map_err(Error::io));
            Ok(Compound::Map {
                ser: self,
                state: State::First,
            })
        }
    }

I'd really appreciate any help. I've been working on it for a few days. I don't feel much closer to a solution than when I started and can't seem to let it go.

Here's a playground trying to deserialize into multiple sequence types:
https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=28b057779d25b894451e92d48378b7b6
At this point I don't know how to use serde to accomplish this without modifying Visitor, or supplying my own version of it with something like visit_set. Alternatively it seems modifying visit_seq to take an argument indicating what type of sequence variant should be returned would permit this also. Either way, most the deserialization path depends on Visitor, so I'd need to write aDeserializer trait with methods that use the new kind of visitor (serde::de::Visitor + VisitorExt) and a Deserialize trait for that.
I've been asking around on Rust Discord and the Rust Forums and haven't received any suggestions on how to be able to do this. I #serde IRC briefly as well but didn't get any replies.

You will need to pick some representation of EDN vectors and lists and sets against this set of Serde data types. The mapping you pick is pretty arbitrary and up to you. For example you could decide that an EDN set would be represented as a Serde struct called "edn::Set" with a single field called "elements" which is a Serde seq.
Then you need to think about four transformations: Serialize (Rust type to Serde data model), Serializer (Serde data model to EDN), Deserializer (EDN to Serde data model), Deserialize (Serde data model to Rust type). The Serializer and Deserializer steps should be straightforward -- Serializer needs to identify when it is being fed your chosen representation for these EDN types and emit them in the appropriate EDN form, and Deserializer needs to parse EDN and produce your chosen representation to the caller's Visitor when it encounters a list or set. For the Serialize and Deserialize steps you could do it either by having your library define its own Set / List etc types with Serialize and Deserialize impls that produce the chosen representations (the toml crate handles its Datetime type this way so check that out as an example), or alternatively by exposing a serde(with = "...") function that would let the user use any existing set / list types probably from the standard library:
#[derive(Serialize, Deserialize)]
struct Demo {
    #[serde(with = "edn::set")]
    my_set: HashSet<String>,
}

@dtolnay Thanks! That makes sense.
For others, before I received this advice I ended up adding my own Visitor trait (trait EDNVisitor<'de> :  serde::de::Visitor). This allows adding methods specific to the data format (visit_list, visit_set, visit_vector) and leaving the impl for serde's Visitor as-is. It did require copying and renaming Deserialize and Deserializer so the serde::de::Visitor constraint could be changed to the format-specific visitor (EDNVisitor). This leverages serde's Visitor for data types that directly map to serde's data model, like string, number, boolean, and unit, and format-specific visitor methods when that mapping is less obvious.
For sequences, copying SeqAccess and changing the trait requirements for methods like next_element and next_element_seed was necessary in order to require elements of the sequence implement the format-specific Deserialize trait.
All told the traits I needed to modify fit in about 300LOC.


Edit text

How to edit a text element in svg?
contenteditable on the wrapping div works, but I'm looking for a more native solution. :smile:

/cc @Fuzzyma

...same as in #5
editing text in svg is not easy to do. contenteditable only works on the wrapping div.
SVG2 will add this attribute to the SVG namespace, too.
If you want do it anway you have to do the whole manipulation yourself

:+1:

there are hacks which adds htmlinputs as overlay to the svgtext to achieve what you want

@Fuzzyma Thanks! :cake: :grin:


[BUG] Data Prepper Workflow will still copy image to latest when RELEASE_LATEST_TAG is not checked

Hi,
The workflow has some bugs that even if latest is off 1.5.2 still copied to latest.
https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/data-prepper/release-data-prepper-all-artifacts.jenkinsfile
@rishabh6788 @zelinh
https://build.ci.opensearch.org/job/release-data-prepper-all-artifacts/26/
I suspect the Major tag have the same issue.
Thanks.

I think I know what's wrong here.
https://github.com/opensearch-project/opensearch-build/blob/2fe6e745ab9c6ae09b91e5c00bd8800dc0b6caa3/jenkins/data-prepper/release-data-prepper-all-artifacts.jenkinsfile#L98
We are having the condition check with just the RELEASE_LATEST_TAG or RELEASE_MAJOR_TAG inside the if statement bracket, this would also be true as Jenkins considers it as string.
We could either use params.RELEASE_LATEST_TAG or RELEASE_LATEST_TAG.toBoolean() to specify it as boolean parameter. I would take care of it now.


This DAG crashes my scheduler very quickly (with explanation)

Environment

OS: Debian Wheezy (via docker-airflow)
Configuration (trimmed)
python 2.7.9, Airflow 1.6.1 from pypi, my project's requirements.txt (trimmed)

How to replicate and explanation
This DAG crashes my scheduler very quickly when manually (externally) triggered. I'm going to guess it will crash for everyone running Airflow 1.6.1 and up to master.
I find my DAGs start to be scheduled only after manually / externally triggering them. (Not sure why.) The manual trigger generates this DagRun:
<DagRun crash_dag @ 2015-12-17 16:28:34: test, externally triggered: True>

Then the subsequent scheduler heartbeats generates new scheduled DagRuns one at a time (one for each of the four previous minutes):
<DagRun crash_dag @ 2015-12-17 16:24:34: scheduled__2015-12-17T16:24:34, externally triggered: False>
<DagRun crash_dag @ 2015-12-17 16:25:34: scheduled__2015-12-17T16:25:34, externally triggered: False>
<DagRun crash_dag @ 2015-12-17 16:26:34: scheduled__2015-12-17T16:26:34, externally triggered: False>
<DagRun crash_dag @ 2015-12-17 16:27:34: scheduled__2015-12-17T16:27:34, externally triggered: False>

One minute passes, then it tries to schedule the next DagRun, but it crashes with this exception:
2015-12-17 16:29:35,097 - root - ERROR - (_mysql_exceptions.IntegrityError) (1062, "Duplicate entry 'crash_dag-2015-12-17 16:28:34' for key 'dag_id'") [SQL: u'INSERT INTO dag_run (dag_id, execution_date, state, run_id, external_trigger, conf) VALUES (%s, %s, %s, %s, %s, %s)'] [parameters: ('crash_dag', datetime.datetime(2015, 12, 17, 16, 28, 34), u'running', u'scheduled__2015-12-17T16:28:34', 0, None)]
Traceback (most recent call last):
   File "/usr/local/lib/python2.7/dist-packages/airflow/jobs.py", line 608, in _execute
     self.schedule_dag(dag)
   File "/usr/local/lib/python2.7/dist-packages/airflow/jobs.py", line 398, in schedule_dag
     session.commit()
   File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/session.py", line 801, in commit
     self.transaction.commit()
<snip>

The reason is my Airflow database (tested on both MySQL and Postgres) has a unique key definition in the dag_run table on (dag_id, execution_date). Indeed, the DagRun attempting to be scheduled with ID scheduled__2015-12-17T16:28:34 is colliding with my DagRun with ID test.
After this collision and exception, the scheduler remains alive, and for each scheduler heartbeat, I get the following SQLA rollback message, preventing all future scheduling:
2015-12-17 16:29:35,115 - root - ERROR - This Session's transaction has been rolled back due to a previous exception during flush. To begin a new transaction with this Session, first issue Session.rollback(). Original exception was: (_mysql_exceptions.IntegrityError) (1062, "Duplicate entry 'crash_dag-2015-12-17 16:28:34' for key 'dag_id'") [SQL: u'INSERT INTO dag_run (dag_id, execution_date, state, run_id, external_trigger, conf) VALUES (%s, %s, %s, %s, %s, %s)'] [parameters: ('crash_dag', datetime.datetime(2015, 12, 17, 16, 28, 34), u'running', u'scheduled__2015-12-17T16:28:34', 0, None)]
 Traceback (most recent call last):
   File "/usr/local/lib/python2.7/dist-packages/airflow/jobs.py", line 618, in _execute
     self.import_errors(dagbag)
   File "/usr/local/lib/python2.7/dist-packages/airflow/jobs.py", line 340, in import_errors
     session.query(models.ImportError).delete()
   File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/query.py", line 2883, in delete
     delete_op.exec_()
<snip>

Looking into the Airflow codebase, I see that the DagRun model has a single unique index that is not the unique index causing this issue. There is, however, a migration that adds the unique DagRun index causing this issue.
How to fix
I'm going to try to work-around by manually deleting the unique constraint on the dag_run.(dag_id, execution_date) index. I'm guessing it will work okay for now.
I think the root cause is an inconsistency between the DagRun model and the list of migrations that needs to be resolved in such a way there isn't index collisions.

Thanks for the detailed report, this seem to be an edge case. That unique index is important as the pk of the task instances are dag_id/task_id/execution_date. If 2 dag runs had the same timestamp there would be collisions in the task_instance table.
To me normally DAGs are either scheduled or externally triggered by nature, I'm not sure if I understand the hybrid use case and infer how to deal with collisions.

From a technical perspective, I still believe there is an inconsistency between the DagRun migration scripts and the DagRun model which needs to be addressed / clarified. This index dag_run.(dag_id, execution_date) does not exist in the model but does exist in the migrations.
From a usability perspective, my DAG (referenced above) will not be scheduled without first manually externally triggering the initial run, even with my DAG flipped in the "ON" position. It is my desire to have my DAGs work on a schedule exclusively, but they would be scheduled only after the initial external trigger. Maybe the hybrid use case may not make sense, but it is a necessary starting point for this DAG.

@boxysean it should be addressed as part of AIRFLOW-20, please keep an eye on it and create a Jira issue if it doesn't. Closing this here for now


[fix] fix a stream stat loop bug

At the first beginning, I used total_nclients to decide whether there are more streams or not, but it's wrong. If a stream has no clients and this live application has more streams, the JSON string generated finally will miss a comma, which leads a serious error. I have tried to fix it.
And, I have fixed some code flaws in order to keep up with original author's code style.

Temporarily, the JSON stat feature needs no change.


REST > Billing getOne/getMany/Download/Webhook doc + schemas

+ postman collection update

postman collection update

You can import the OAS file in Postman in the end.

You can import the OAS file in Postman in the end.

Didn't know that ! Then, do we remove the JSON collection from the repo ? As anyone can generate its own collection with the OpenAPI file. This could avoid syncing both files and avoid people from using a deprecated collection

You can import the OAS file in Postman in the end.

Didn't know that ! Then, do we remove the JSON collection from the repo ? As anyone can generate its own collection with the OpenAPI file. This could avoid syncing both files and avoid people from using a deprecated collection

No you can re-generate it once and everyone will use it right away when you will have finished the migration.


Sierpiński Triangle-CatR3kd

Generative Sierpiński triangle fractal! Messy code but otherwise pretty cool + fun (:

This is definitely a classic drawing. If you want to submit fractals that have lots of code examples online could you give a sample of a few more classic fractals.

I'm going to close this for housekeeping. Feel free to submit again when you are ready.


Adding windows support to server the index.html in the static.js

server root in windows is '' and when it is represented in javascript it becomes '\'.
may be this is an issue with the path, but this solves the problem on two windows machines that i tested

I had this problem as well, and solved it the same way. +1 pull request

Thank you @bsparks


NoMethodError at / undefined method `length' for nil:NilClass

So today I wanted to test drive the application. I cloned the repo, Ran make run, and got the following error when opening http://localhost:5678/ in the browser:
 application error
NoMethodError at /
undefined method `length' for nil:NilClass

    file: delimiter.rb location: parse line: 192

This is copied from the web interface, I'd have liked to print a full backtrace but I'm not sure where I'm supposed to get it from, as the web interface doesn't seem to provide a plaintext version of it..
I read at #100 that taskwarrior needs to be installed. Is it installed in the docker image? Will running the application with this method will use my ~/.taskrc and it's included files?

bumped, same issue.

I have the same

Same here, even on empty .task/


Due card

Nothing much happens here, since the due card gets determined by a command.
However, it might be the case that there is no due card. Then an "empty card" is delivered back.

I'm not entirely happy with the solution if no due card has been selected or it got deleted after having been selected. But will do for now.


[Suggestion] Add config to hide JEI capturing enchant spam.

As per the title. I get that the idea is to get people to know what it does, but with mods like enchantment descriptions it becomes redundant and quite the info spam in the JEI info tab. I'd really appreciate a toggle for it to disable it.

what is the percent chance per level of getting a spawn egg


AccountsTemplates.logout() and iron-router's this.next()

Hi! I am able to get a /sign-out route to work and redirect on logout using:
Router.route('/sign-out', {
    name: 'signOut',
    onBeforeAction: function () {
        AccountsTemplates.logout(); // onLogoutHook is configured to redirect to home
        this.next();
    }
});

However, with the code above, I get a brief display of this message before redirection to home happens:
Couldn't find a template named "SignOut" or "signOut". Are you sure you defined it?

I can think of:

creating the "signOut" template but that is a bit pointless.
or disable this.next() but iron-router says "Route dispatch never rendered. Did you forget to call this.next() in an onBeforeAction?"

What is the best solution to this if I need a route to perform log out?

How are you redirecting the user to the /sign-out route at the moment?
Couldn't you simply call AccountsTemplates.logout() in response of a button click?

See the click #at-nav-button event handler used for the atNavButton template.

I am redirecting through a link like "a href=/sign-out".
If i create an event handler to call AccountsTemplates.logout() then no issue at all. A logout link just feels more direct in my case.
For now, i do workaround:
Router.route('/sign-out', {
    name: 'signOut',
    onBeforeAction: function () {
        AccountsTemplates.logout();
        this.redirect('/');
    }
});

It still performs the redirect but at least I am not getting the "Couldn't find a template names "SignOut"..." message.
I will leave it this way until someone propose a better option.
Thanks!

Ok, I see.
Btw, we had a sign-out page working in Telescope (which now switched to FlowRouter btw)
and we had to add these lines to get the previous page logic to work correctly

+1 needs fix


Oryx consistently detects v12 of node, when engine is set to v16

Describe the bug
When building API for an Azure Function app compiling from typescript to js, oryx detects node v12.
Detecting platforms...
Detected following platforms:
  nodejs: 12.22.11
Version '12.22.11' of platform 'nodejs' is not installed. Generating script to install it...
Detected the following frameworks: Typescript

A clear and concise description of what the bug is.
Expected behavior
Expect node v16 to be detected
Additional context
Add any other context about the problem here.
staticwebapp.config.json:
  "platform": {
    "apiRuntime": "node:16"
  },

/api/package.json:
  "engines": {
    "node": "16.18.0"
  }

/api/host.json:
{
  "version": "2.0",
  "logging": {
    "applicationInsights": {
      "samplingSettings": {
        "isEnabled": true,
        "excludedTypes": "Request"
      }
    }
  },
  "watchDirectories": ["prisma"],
  "extensionBundle": {
    "id": "Microsoft.Azure.Functions.ExtensionBundle",
    "version": "[3.*, 4.0.0)"
  }
}

.github/workflows/xyz.yml:
name: Azure Static Web Apps CI/CD

on:
  push:
    branches:
      - main
  pull_request:
    types: [opened, synchronize, reopened, closed]
    branches:
      - main

jobs:
  build_and_deploy_job:
    if: github.event_name == 'push' || (github.event_name == 'pull_request' && github.event.action != 'closed')
    runs-on: ubuntu-latest
    name: Build and Deploy Job
    steps:
      - uses: actions/checkout@v2
        with:
          submodules: true
      - name: Build And Deploy
        id: builddeploy
        uses: Azure/static-web-apps-deploy@v1
        with:
          azure_static_web_apps_api_token: ${{ secrets.AZURE_STATIC_WEB_APPS_API}}
          repo_token: ${{ secrets.GITHUB_TOKEN }} # Used for Github integrations (i.e. PR comments)
          action: "upload"
          ###### Repository/Build Configurations - These values can be configured to match your app requirements. ######
          # For more information regarding Static Web App workflow configurations, please visit: https://aka.ms/swaworkflowconfig
          app_location: "/src" # App source code path
          api_location: "/api" # Api source code path - optional
          output_location: "out" # Built app content directory - optional
          ###### End of Repository/Build Configurations ######

  close_pull_request_job:
    if: github.event_name == 'pull_request' && github.event.action == 'closed'
    runs-on: ubuntu-latest
    name: Close Pull Request Job
    steps:
      - name: Close Pull Request
        id: closepullrequest
        uses: Azure/static-web-apps-deploy@v1
        with:
          azure_static_web_apps_api_token: ${{ secrets.AZURE_STATIC_WEB_APPS_API}}
          action: "close"

@Sealjay Where is your staticwebapp.config.json file located? Can you please try placing that file in the app_location, which is /src like /src/staticwebapp.config.jsonand see if it works? Thanks!

That has worked, thanks @vivekjilla - the staticwebapp.config.json file was in the top-level directory, above src and api.
Moving the file into the src folder has worked; and I updated the swa-cli.config.json file accordingly too, updating the swaConfigLocation param.

Closing as I can see this here:

https://learn.microsoft.com/en-us/azure/static-web-apps/configuration#file-location


fix: server access logs contain the protocol used between the server …

…and the load balancer, but not the protocol used between the client and the load balancer
https://github.com/gogf/gf/issues/1655

Codecov Report

Merging #1657 (920dbbe) into master (8f326dc) will increase coverage by 0.02%.
The diff coverage is 50.00%.

:exclamation: Current head 920dbbe differs from pull request most recent head f6054ab. Consider uploading reports for the commit f6054ab to get more accurate results

@@            Coverage Diff             @@
##           master    #1657      +/-   ##
==========================================
+ Coverage   71.06%   71.09%   +0.02%
==========================================
  Files         445      445
  Lines       42492    42493       +1
==========================================
+ Hits        30198    30209      +11
+ Misses      10391    10382       -9
+ Partials     1903     1902       -1

Flag
Coverage Δ

go-1.15
71.05% <50.00%> (+0.01%)
:arrow_up:

go-1.16
71.05% <50.00%> (+0.01%)
:arrow_up:

go-1.17
71.05% <50.00%> (+0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

net/ghttp/ghttp_request.go
78.90% <50.00%> (+0.16%)
:arrow_up:

os/gmutex/gmutex.go
94.73% <0.00%> (-2.64%)
:arrow_down:

container/gtree/gtree_avltree.go
96.53% <0.00%> (+0.57%)
:arrow_up:

net/gtcp/gtcp_pool.go
38.63% <0.00%> (+4.54%)
:arrow_up:

os/gspath/gspath_cache.go
94.73% <0.00%> (+10.52%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f326dc...f6054ab. Read the comment docs.


Incorrect shape handling in scipy.stat.multivariate_t.rvs method

The rvs method of multivariate_t works only when size parameter is strictly 1 dimensional. This is not the case with multivariate_normal.
Reproducing code example:
>>> import sys, scipy, numpy; print(scipy.__version__, numpy.__version__, sys.version_info)
1.6.3 1.20.3 sys.version_info(major=3, minor=7, micro=7, releaselevel='final', serial=0)
>>> import numpy as np
>>> from scipy.stats import multivariate_normal, multivariate_t
>>> mean, cov = np.zeros(2), np.eye(2)
>>> multivariate_normal.rvs(mean=mean, cov=cov, size=None).shape
(2,)
>>> multivariate_t.rvs(loc=mean, shape=cov, size=None)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/sayam/miniconda3/envs/pymc_dev/lib/python3.7/site-packages/scipy/stats/_multivariate.py", line 4148, in rvs
    samples = loc + z / np.sqrt(x)[:, None]
IndexError: invalid index to scalar variable.

>>> multivariate_normal.rvs(mean=mean, cov=cov, size=(10, 3)).shape
(10, 3, 2)
>>> multivariate_t.rvs(loc=mean, shape=cov, size=(10, 3))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/sayam/miniconda3/envs/pymc_dev/lib/python3.7/site-packages/scipy/stats/_multivariate.py", line 4148, in rvs
    samples = loc + z / np.sqrt(x)[:, None]
ValueError: operands could not be broadcast together with shapes (10,3,2) (10,1,3)

>>> multivariate_t.rvs(loc=mean, shape=cov, size=(3))
array([[ 1.54502738, -0.23866557],
       [-0.79040924, -1.72035808],
       [-0.28060545, -0.69889876]])

I guess the errors arise from this line -
https://github.com/scipy/scipy/blob/f856e3e852a59120d44133a0ce550cceb19f9244/scipy/stats/_multivariate.py#L4084
This issue popped up while adding MvStudentT to PyMC3 https://github.com/pymc-devs/pymc3/pull/4731. Its random sampling method makes use of scipy.stats.multivariate_t.

The shape handling of multivariate_t and multivaraite_normal is completely broken. See gh-7689 for shape bugs in multivariate_normal distribution. Here are a few more broken examples:
>>> from scipy.stats import multivariate_normal, multivariate_t
>>> # all the problems below also hold for multivariate_normal
>>> multivariate_t.rvs([0], [[1]], size=7)   # expected array of shape (7, 1)
array([ 1.64545405, -0.11754869,  0.14135387, -0.72304521, -3.50994847,
        2.15339272,  1.32959055])
>>> multivariate_t.rvs([0], [[1]], size=1)  # expected array of shape (1, 1)
9.221726325909353
>>> multivariate_t.rvs([0], [[1]], size=(1,))  # expected array of shape (1, 1)
0.38894268481522826
>>> multivariate_t.rvs([0], [[1]], size=(1,1,1,1,1,1))  # expected array of shape (1,1,1,1,1,1, 1)
-18.01539251887883

PDF also gives unexpected shapes:
>>> from scipy.stats import multivariate_normal, multivariate_t
>>> # all the problems below hold for multivariate_normal too.
>>> multivariate_t.pdf([[[[[1.]]]]], loc=[0.], shape=[[1.]])  # expected an array of shape (1,1,1,1)
0.15915494309189535

Other inconsistencies:
>>> from scipy.stats import multivariate_normal, multivariate_t
>>> # all the problems below hold for multivariate_normal too.
>>> multivariate_t.pdf([0., 1.], loc=[0], shape=[[1]])  # multivariate_t accepts this
array([0.31830989, 0.15915494])
>>> multivariate_t.pdf([[0., 1.]], loc=[0], shape=[[1]])  # but fails to accept this. I would expect it to broadcast
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/tirthasheshpatel/Desktop/scipy_source/scipy/stats/_multivariate.py", line 3958, in pdf
    logpdf = self._logpdf(x, loc, shape_info.U, shape_info.log_pdet, df,
  File "/home/tirthasheshpatel/Desktop/scipy_source/scipy/stats/_multivariate.py", line 4029, in _logpdf
    maha = np.square(np.dot(dev, prec_U)).sum(axis=-1)
  File "<__array_function__ internals>", line 5, in dot
ValueError: shapes (1,2) and (1,1) not aligned: 2 (dim 1) != 1 (dim 0)

In the above example, the ideal behavior would be to only accept inputs with shape (..., 1) as it is a one-dimensional multivariate distribution. Other input sizes must raise an error. But currently, it accepts inputs with shape (N, ) which is technically wrong.
This is because of the use of _squeeze_output function before returning. As many other distributions use it, we might be too late to fix them without breaking backward compatibility. For now, I have submitted gh-14192 fixing this issue. But it would be better to fix some of the above inconsistencies in some other PR.

Hello @tirthasheshpatel . Happy to see you around and thanks for the quick reply.
I was also thinking about the use of ellipsis to fix this issue but struggled my way through setting up scipy dev environment locally. FInally, I got it working.
Now, I'll try to understand the shape handling in scipy in near future 🤞

I was also thinking about the use of ellipsis to fix this issue but struggled my way through setting up scipy dev environment locally. FInally, I got it working.

Happy to hear that you got it working! You can refer to https://docs.scipy.org/doc/scipy/reference/building/linux.html#debian-ubuntu anytime if you are on Ubuntu/Debian. If you are on windows, this wiki page might help set it up easily. Sorry, I was not aware you were working on this.

Now, I'll try to understand the shape handling in scipy in near future crossed_fingers

Sure, @Sayam753 :smiley:! It would be very helpful if you could resolve the shape bugs I mentioned above. If you face any problems, feel free to ping me.

Unfortunately, I am on MacOS and was following this tutorial.

In step 1, I installed miniconda instead of Anaconda (trying to be minimalist here)
In step 11, this command conda install mkl openblas cython numpy pytest pybind11 pythran=0.9.11 -c conda-forge helped me to follow next steps.

Sorry, I was not aware you were working on this.

My bad, I should have mentioned this earlier. Thanks for the helping hands anyways.

@Sayam753 what step in the guide did you struggle with when setting up your environment?

Hello @mdhaber
On the Building Scipy part in MacOS development guide -

The first step recommends installing Anaconda. But I installed miniconda. After the installation, I created a new conda environment (creating a conda env comes a lot later in the tutorial but I prefer keeping my base env clean, so that's why I created a new env)
Then following as it is till step 13, I could not do an in-place build. Tracing the errors, it turned out my environment didn't have mkl, openblas and pythran
So, my step 11 was basically to install them all via

conda install mkl openblas cython numpy pytest pybind11 pythran=0.9.11 -c conda-forge
conda install conda-build  # Helped in `conda develop /scipy` part

Rest, everything was smooth.

As I am looking more into it, I should have been following latest devdocs tutorial instead of tutorial at 1.6.3 release here
I got confused tricked with dev word in 1.6.3 release URL https://docs.scipy.org/doc/scipy/reference/dev/contributor/quickstart_mac.html#building-scipy and assumed them to be dev docs. Anyways, I will https://scipy.github.io/devdocs/dev/contributor/quickstart_mac.html#quickstart-mac from now

Yes, it's best to look at the dev version of the developer guide when working with master. (Then again, not even that is always up to date... there are some issues with the Ubuntu quickstart guide right now.)


Collaboration without Templates

So we got this tutorial by @mattkaustik that we are currently trying to find a new home for, posting it here for now so it can be discussed:
Collaboration Within Core
Overview
Collaboration can be done simply with everything core provides to you out of the box or with external tools. The methods used in this tutorial are mainly for
team projects consisting between 2 - 4 people for quickly developing games in core. These methods can be expanded on with tools such as
discord and google drive, which will be covered in advanced section.
Team Manager
This role is the person who carries the master version of the game, this is the version of the game that will be published to their account.
This person is highly recommended to also be your programmer for ease of use.
Importing Work to Master Copy
When others have work they are ready to send you it will come inside of a zip folder you need to unpack the zip to the maps folder.

Unzip and save the zip somewhere on your computer incase you need a backup
Locate C:\Users\USERNAME\Documents\My Games\CORE\Saved\Maps\
Paste the unziped Documents
Open core editor and the new files are ready to be opened
Open the files
Copy the work folder you need or any new updates your team have sent you
Close the editor
Open the master and paste now the new files are inside the main game remember to test for errors

Designer Basics
A designer in core is typically someone who is making mostly objects and using kitbashing to make unique things to look at in the world.
Method For Saving Work
This method is for the desinger to properly organize and send their work for the team project.

Open your project in the Core Editor
Right click in the Hierarchy
Select New Folder
Move all your work into this new folder
Save your game with Ctrl + S

Method For Sending Work

Locate the game files you wish to send C:\Users\USERNAME\Documents\My Games\CORE\Saved\Maps\
Right click and pick the option Send to -> then pick Compressed Zip
Choose one of the methods for deliver in the Advanced Team Tools section

Programmer Basics
A programmer typically in core is someone versed in LUA as well as cores standard API.
Basic Saving
As a programmer you can send your team files as needed you can use the following below.
Text Method

Create a script you wish to send
Copy the raw text from this document
Send the raw text to your team
On their end they create a script
Then they paste the code you sent

Template Method

Create the script in the Hierarchy
Right Click it then select Create Template From Script
Right Click it again, find the option Find In Catalog
It will take you to your saved template Right Click the saved template and click Export

Anyone will now be able to drag and drop your script into their project. Remember to be careful to outline the dependencies needed for the
script to your team so the script works properly, alternatively you can do the following.
Desinger Friendly Method

Open your project in the Core Editor
Right click in the Hierarchy
Select New Folder
Move all your work into this new folder.
Save your game with Ctrl + S

Method For Sending Work

Locate the game files you wish to send C:\Users\USERNAME\Documents\My Games\CORE\Saved\Maps\
Right click and pick the option Send to -> then pick Compressed Zip
Choose one of the methods for deliver in the Advanced Team Tools section

Advanced Team Tools For Collaboration
Discord
You can create a team discord for your game and collaborate through voice
You can install Discord using the link to download on their website.
This is the Core Hub Offical Discord Link.
Creating a discord server

Scroll to the bottom of your discord server list via the left panel of discord.
Click the green plus Add a Server
Create a server and fill in the info for the server

Inviting Your Team

Click the name at the top of your new server
Click the option Invite People
You can copy this link and send it to people you'd like to be on the server

Alternatively you can edit this link and change its options from the same screen.
Setting Permissions
Remember to set permissions so that only your team can view the discord files you are dropping in. You can create roles and premissions for
those roles using the following method.

Click on the arrow next to the server name.
Click on Server Settings
Click on Roles

When you first create your server there is only one pre-made role: @everyone. The @everyone role defines the permissions that are enabled for
everyone on your server even if they have no other roles assigned to them.

To create a new role click on the '+'.
Once you have created a role, you can assign specific server-wide permissions for that role by toggling the dials.

Don't forget to click Save Changes to save your changes!
Assigning Roles

Click on the 'Members' tab in the server settings menu.
Click on the plus sign under the member you want to assign a role to and select the role from the drop down window.

This member now has the server-wide permissions that you assigned to that role. Alternatively you can simply right click the user
if they are in a voice channel and assign roles via the roles option.
Sending files
On your teams discord channel or via direct message you can drag and drop files to your team, remember the cap on files for discord is 8MB.
Should you go over this amount you can get a higher cap from discord by purchasing nitro alternatively the free method using google drive is below.
Google Drive
If your file size gets too big for discord (8MB Limit) you can use Google Drive
You can signup for GoogleDrive using the link to their website.
Sending a file

Drag and drop your zip file into your Google Drive
Right click the file once uploaded then pick the option Get Shareable Link
Make sure to set this link from Restricted to Anyone With The Link
Copy the link and send this to your team

Trello
This program is for quickly creating story board type workflow. This will allow you to streamline bugs and patches to your programmer.
You can signup for Trello using the link to their website.
Trello Basics
Using Trello is a straight forward process start by making a board then you create a team and give them the links to the board. Now you
will all be able to edit and create on the board together.
Visual Studio Code
This program is useful for coding together or alone in a more streamlined fashion than cores built in coding platform.
You can download Visual Studio Code using the link to their website.
Hooking Into The Project
You will need to hook into the project files before sharing the live session with your team.

Collaboration Via Live Share
Live Share is an extension for VS Code that enables real-time collaboration between developers. As you'll see in a second,
you'll have the ability to share a "session" with someone else, allowing them to edit code as well as share a sever and debugging session.
Getting Started

Install the Live Share extension by clicking the extension button located on the left panel
Open the command palette
Type in Live Share and install
Start Live Share
Share link with your team.

Fixed by https://github.com/ManticoreGamesInc/platform-documentation/pull/369


chore: upgrade dependence

😇 I am a user of Mac M1, so I need to build from source code. However, I found that certain npm versions were causing compilation issues, and I made some fixes on the side. By the way, I'm not very familiar with ts, so please feel free to point out any issues if there are any.

Looks good, thanks!


How to use V2X?

Hi,  developments !
We plan to use V2X module, but wo haven't found official documentation in V2X module folder.
Is there any official documentation about V2X can tell us how to use it ?
Thanks!
System information

OS Platform and Distribution (e.g., Linux Ubuntu 18.04):  Linux Ubuntu 18.04
Apollo installed from (source or binary): source
Apollo version (3.5, 5.0, 5.5, 6.0): 6.0
Output of apollo.sh config if on master branch:

The V2X module will require hardware OBU and RSU to run, first make sure it is ready.
Apollo use grpc communication with OBU, you should run the client and server in both side.
Do some test then.

I am from OEM, doing the job about V2X algorithm.I beg for manual book too....

Can I get more imformation about the OBU hardware?
Thanks.

Apollo's v2x module and obu device have been decoupled, there're design by modules and use grpc to communication. So you can use any OBU.
So you need to provide detailed questions, broad questions are not easy to answer


styled-components need to be updated

Hi,
I think we getting some kind of conflict. We need to update the packages for sanity-plugin-mux-input to fix styled-components issue.
npm i
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/styled-components
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!   peer<EMAIL_ADDRESS>|| ^6.0" from<EMAIL_ADDRESS>npm ERR!   node_modules/@sanity/document-internationalization
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!   10 more (@sanity/language-filter, ...)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/sanity-plugin-mux-input
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Conflicting peer dependency<EMAIL_ADDRESS>npm ERR! node_modules/styled-components
npm ERR!   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/sanity-plugin-mux-input
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Resolved in https://github.com/sanity-io/sanity-plugin-mux-input/releases/tag/v2.3.0


make aperture sdk not block readiness on connecting to agent (breaking "dogfooding recursion deadlock")

After setting:

in aperture-agent

fluxninja.enable_cloud_controller: true

in agent-service:

aperture_sdk.enabled: true

and running tilt up agent agent-service, the agent, agent-service, and cloud controlled etcd all become ready - the bug is currently not reproducible.


explorer.openEditors.visible is 0, but shows "Open Editors" list header when first opening directory

Issue Type
Bug
Description
To reproduce:

Set vscode settings to { "explorer.openEditors.visible": 0 } and close.
mdir temp; cd temp; code-insiders .
You will see "Open Editors" in the explorer menu, even though you asked not to see this. (It still shows a maximum of 0 though, so just the title appears.)
Does not reproduce in vscode non-insiders.

Screen Reader
no

VM
0%

Reproduces without extensions

@isidorn Could you link to the issue this is a duplicate of?

https://github.com/Microsoft/vscode/issues/43597

Thanks


Add codecov.yml file with defaults and ignores.

Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #
Checklist:

[ ] Documentation has been updated, if necessary.
[ ] Pending release notes updated with breaking and/or notable changes, if necessary.
[ ] Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
[ ] Code generation (make generate) has been run to update object specifications, if necessary.
[ ] CRD manifests generation (make manifests) has been run to update CRD manifests yaml file specifications, if necessary.
[ ] Update dependencies (make vendor) has been run to update Gopkg.lock file, if necessary
[ ] All related commits have been squashed to improve readability.
[ ] Comments have been added or updated based on the standards set in CONTRIBUTING.md

Argh.. righ. Good catch @jbw976 . Rebasing...

@jbw976 ... fixed, PTAL


Runtime error on MacOS due to glDebugMessageCallback

On MacOS Trundle is crashing here at runtime: https://github.com/zacharyselk/Trundle/blob/ad566d0efced507fda57621528b45128a9d63d69/Engine/src/Platform/OpenGL/openGLContext.cpp#L74
Commit: ad566d0efced507fda57621528b45128a9d63d69

MacOS only supports OpenGL up to version 4.1~4.2 and  glDebugMessageCallback was introduced in OpenGL 4.3 (see the documentation). So this function call needs to be removed for MacOS builds.


Improve support for  Stock-Alike Station Parts

make PPD-24 built-in antenna Kerbalism compatible. The stats are taken from the small fixed antenna.
modify PPD-24 description to mention presence of antenna explicitly

Happy New Year!

Thanks a lot, merging this. Happy new year to you too!

Thanks a lot, merging this. Happy new year to you too!


Frequent failure to check latest TeXlive version

I'm getting this error about one third to half the time I run this action:
Failed to check for latest version: Error: Request timeout: /json/2.0/pkg/texlive
Use `2023` as latest version

This started happening a few weeks ago. Because it chooses 2023 by default, I then get a further error:
UnexpectedVersion: Unexpected install-tl version: 2024
    at UnexpectedVersion.check (file:///home/runner/work/_actions/teatimeguest/setup-texlive-action/v2/dist/index.mjs:62275:11)
    at async download (file:///home/runner/work/_actions/teatimeguest/setup-texlive-action/v2/dist/index.mjs:62693:7)
    at async acquire (file:///home/runner/work/_actions/teatimeguest/setup-texlive-action/v2/dist/index.mjs:62660:36)
    at async installTL (file:///home/runner/work/_actions/teatimeguest/setup-texlive-action/v2/dist/index.mjs:62632:25)
    at async file:///home/runner/work/_actions/teatimeguest/setup-texlive-action/v2/dist/index.mjs:63316:9 {
  version: '2023',
  repository: 'https://us.mirrors.cicku.me/ctan/systems/texlive/tlnet/',
  remoteVersion: '2024'
}

@jonsterling Since v3.2.0, TeX Live 2024 is the default. Perhaps you are using an older version?

@jonsterling The log shows that you are still using v2:

at UnexpectedVersion.check (file:///home/runner/work/_actions/teatimeguest/setup-texlive-action/v2/dist/index.mjs:62275:11)

Please consider upgrading to v3. Breaking changes are listed here, but in most cases no changes to your workflow are required.

This started happening a few weeks ago.

This may indicate that CTAN has recently become unstable (CTAN had previously announced that it was being targeted by spammers). If this is the case, a similar error may occur even with v3, as this action uses the CTAN API not only to check latest version but also to resolve package names. I will consider some workaround.

@teatimeguest Oh, thanks very much! I'll try upgrading to v3.

I'm going to close this ticket — the new version seems to work well. Thanks again for your help!


FEAT-#6417: Add support for filters to read_parquet

What do these changes do?
Resolves #6417 by adding support for the filters argument to read_parquet. This is my first PR so I'm sure I've made a lot of mistakes here -- please let me know! Also feel free to edit directly.

[x] first commit message and PR title follow format outlined here

NOTE:  If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

[x] passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
[x] passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
[x] signed commit with git commit -s
[x] Resolves #6417
[x] tests added and passing
[x] module layout described at docs/development/architecture.rst is up-to-date

@vnlitvinov I believe I've resolved the issue that caused the CI to fail.

@vnlitvinov I believe I've resolved the issue that caused the CI to fail.

I have approved CI run again, let's see how it goes.

@vnlitvinov I'm a bit confused why the CI is failing again. It looks to have only failed on Windows, and it isn't immediately obvious to me why adding filters would have caused that failure. I am wondering if maybe this is a random failure? Any pointers?

@vnlitvinov I'm a bit confused why the CI is failing again. It looks to have only failed on Windows, and it isn't immediately obvious to me why adding filters would have caused that failure. I am wondering if maybe this is a random failure? Any pointers?

@zmbc to me it looks like some of the worker processes did not close the file before main process decided that the read is over. As to why it happened... I don't have a good enough guess right now, and it isn't obvious from the code...

to me it looks like some of the worker processes did not close the file before main process decided that the read is over.

@vnlitvinov I think I've figured out why the CI is failing now. I believe it's actually two issues going on at once, though I am not 100% sure of my interpretation.

There is a race condition with how Modin does setup/teardown for error cases on Windows. There's this cool logic that checks that Pandas and Modin both raise an error, and even that they raise the same error type. But at least on Ray, that error is propagated from the worker to the main process as soon as it happens, which means that another worker process may still be doing stuff in the background. The error "completes" the test, so we think we are ready for teardown, but the other worker may still be using the file.
With the version restrictions currently in environment-dev.yml, reading a Parquet file with a Categorical index with fastparquet always fails. It fails in the same way in both Pandas and Modin, but it does not work at all. That's because Modin is on pandas 2, but due to this max version restriction on fastparquet, we are using a version of fastparquet that does not contain this fix for pandas 2 compatibility.

None of this has anything to do with filters directly. It's just that (2) means that (1) is always happening for this particular test case, and adding filters makes reading the Parquet file much slower, which makes it much more likely for the race condition to actually occur.
Both of these issues seem like they require fixes that are out of the scope of this PR. For now, I will simply skip the test of the Categorical index case when (2) is true. Hopefully that is an okay stopgap.

Hopefully CI will pass now. I tested it on a Windows machine that was reproducing the issue before my latest change.

@zmbc please fix black and flake8 errors

to me it looks like some of the worker processes did not close the file before main process decided that the read is over.

@vnlitvinov I think I've figured out why the CI is failing now. I believe it's actually two issues going on at once, though I am not 100% sure of my interpretation.

There is a race condition with how Modin does setup/teardown for error cases on Windows. There's this cool logic that checks that Pandas and Modin both raise an error, and even that they raise the same error type. But at least on Ray, that error is propagated from the worker to the main process as soon as it happens, which means that another worker process may still be doing stuff in the background. The error "completes" the test, so we think we are ready for teardown, but the other worker may still be using the file.
With the version restrictions currently in environment-dev.yml, reading a Parquet file with a Categorical index with fastparquet always fails. It fails in the same way in both Pandas and Modin, but it does not work at all. That's because Modin is on pandas 2, but due to this max version restriction on fastparquet, we are using a version of fastparquet that does not contain this fix for pandas 2 compatibility.

None of this has anything to do with filters directly. It's just that (2) means that (1) is always happening for this particular test case, and adding filters makes reading the Parquet file much slower, which makes it much more likely for the race condition to actually occur.
Both of these issues seem like they require fixes that are out of the scope of this PR. For now, I will simply skip the test of the Categorical index case when (2) is true. Hopefully that is an okay stopgap.

@zmbc thank you very much for the research and detailed description of the problems!
@vnlitvinov perhaps the problem is that in the logic pointed by @zmbc  we rely on that the repr materializes all the computations, but this is not the case now.

@zmbc please fix black and flake8 errors

Sorry about that, should be fixed now.

In debugging the CI failure, I think I found another issue -- this check is supposed to be about Pandas v2, according to #6072, but it is actually checking the Modin version.
https://github.com/modin-project/modin/blob/f994acacb7cc0f375c2fb22f1cb879713b9e0541/modin/pandas/test/test_io.py#L1478-L1483

Thanks @zmbc, I've created a separate tracker https://github.com/modin-project/modin/issues/6467 on that condition.

oh... @zmbc I think you also should update the docs to clarify that filters are now properly supported, ref:
https://github.com/modin-project/modin/blob/f994acacb7cc0f375c2fb22f1cb879713b9e0541/docs/supported_apis/io_supported.rst?plain=1#L45-L47


feat(turbo): add promiseRequestHandler

Coverage increased (+0.4%) to 77.871% when pulling 75492f395ba139a4f617f4bba9faf54b85ad2fb2 on promiserequesthandler into f0b89e65333d781d1f2ebf121332c928ac929ffc on dev.


Application: Olympus Protocol

Grant Application Checklist

[X] The application-template.md has been copied, renamed ( "project_name.md") and updated.
[X] A BTC address for the payment of the milestones is provided inside the application.
[X] The software of the project will be released under the Apache license version 2.0 as specified in the terms and conditions.
[X] The total funding amount of the project is below CHF 30k at the time of submission.

Clarified the orml implementation (tokens and currencies for multi-currency setup with native token and auxiliary assets). I removed the mention of aUSD since it isn't relevant at this point and shouldn't have been there in the first place; since we are building a test net the assets do not need to be real so we don't need to bring real aUSD onto the runtime yet. I'm honestly not sure how assets will become interoperable on a technical level but I can't imagine it is too difficult and has already been done multiple times by at least Acala and Polkadex.

@olympusprotocol Thanks for a prompt reply.
I still require a password to access your whitepaper via your website.
Also, I still don't see any more details regarding the substrate modules. Have you had a look at requirement list on https://github.com/w3f/Open-Grants-Program/blob/master/src/grant_guidelines_per_category.md#runtime-moduleschains?
While we are not asking for a full technical specification, your current application is too vague (e.g. We will use the orml pallet for the multi-token trait) and providing the pallet interface as specified in that document would speed up the application process - it also facilitates the evaluation of your deliveries upon completion.
(note that this applies to other modules as well, not just the orml pallet).
Lastly, a cosmetic detail - please keep only one file in your application.
I'd be happy to assist your team in drafting out the specifications or to point you in the right direction. Feel free to reach out to me on matrix: @marcin:web3.foundation

I'm closing this PR due to inactivity. Feel free to re-open it with an updated proposal when ready.


Ensure first field render gets initial value

Should fix #4304, #4344 and possibly other duplicates.
Since react-redux v6, a snapshot of the state is used each render in connected components instead of the store. This makes it impossible to initialize the form before the fields render. This fix simply passes the initial value as value when the form is uninitialized.
Also fixes a number of tests that required Field to be rendered twice initially. Most notably, "Field > should have value set to initial value on first render" actually checked if the field had an initial value on the second render 😄

The travis-failure only occurs in node v11.11, see this issue: https://github.com/facebook/create-react-app/issues/6591
I don't think there's a lot to be done about that for now.

@erikras Could you please have a look at this PR? We are currently facing the issue, where the values are an empty object in validate, although the initialValues exist.

Codecov Report

Merging #4397 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #4397   +/-   ##
======================================
  Coverage     100%    100%
======================================
  Files          74      74
  Lines        1694    1690    -4
======================================
- Hits         1694    1690    -4

Impacted Files
Coverage Δ

src/ConnectedField.js
100% <100%> (ø)
:arrow_up:

src/structure/immutable/deepEqual.js
100% <0%> (ø)
:arrow_up:

src/handleSubmit.js
100% <0%> (ø)
:arrow_up:

src/createReduxForm.js
100% <0%> (ø)
:arrow_up:

src/structure/plain/deepEqual.js
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 720c9d0...5c217b4. Read the comment docs.


Getting CloudFormation error on Auth config updating during amplify push

Describe the bug
After an Amplify push, updating resources in the cloud failed on cognito configuration with the following message :
"Parameters: [userPoolGroupList, resourceNameTruncated, dependsOn] must have values"
Amplify CLI Version
4.2.0
Auth is configured with multi-auth : UserPool and Iam

I tried a new installation to get the tree missing parameters.
If added them in the former installation into the auth parameters.json.
After a push, the new error is pretty confusing :
"Parameters: [resourceNameTruncated, dependsOn, userPoolGroupList] do not exist in the template"

Ok i resolved it.
I tried an Amplify auth update
-> Create or update UserPool
Change nothing to the settings.
But it created a second named "userPoolGroup" witch caused a mess in the next "amplify push" I did.
So i tried a "amplify env pull --restore" that i already did previously but with no success.
And as a miracle the "Auth" line in the next "amplify status" stayed to "update".

Sorry i have forgotten to close.


feat(scrollOffset): return scrollOffset from useVirtual

What is the change?
useVirtual now returns its scrollOffset state.
Docs, tests, and types for the behaviour have been included.
Motivation
There are a variety of reasons you may want to implement behaviour that is dependent on the current scroll offset of the virtualizer. e.g. Pagination UI like "displaying rows 1-5" or a "Scroll to top" that only shows when scrollOffset > tooCloseToStart.
Right now to implement this kind of behaviour the host component needs to add its own onScroll handler and update a state. However useVirtual already has a scrollOffset state updated once on every scroll event resulting in a re-render. As a result if the host component adds its own onScroll that changes state, then the host component will re-render twice on every single scroll event. Even though useVirtual already has all the information that is needed to implement that kind of behaviour and the 2nd re-render is entirely unnecessary and would halve the component's performance. Additionally the UI could experience tearing as the render where useVirtual's new list of items to display and the render where the pagination UI is updated are separate renders.
Here's a demo showing the double render behaviour which would be avoided if useVirtual didn't hide the scrollOffset.
https://codesandbox.io/s/usevirtual-with-an-extra-scroll-event-3q6jqz?file=/src/main.jsx

@tannerlinsley Can we get this merged?

This PR is outdated and should either be closed, re-architected or rebased against v3 beta. Thanks!


Paging of only forward seekale data sources

It can been tricky but it would be nice to see a take on data sources that are only forward seekable. For example the github user api (unless I'm missing something) only allows forward seeking (paging), as the Link response headers don't have a prev link. As a page of suers can be fetched using the "since" parameter (user id) it would be a KeyedDataSource datasource but there is no way of loading users "before" a user id.

This is definitely supported now as passing null for prevKey terminates loading on the PREPEND side.


Building docker fails

Currently trying to build the docker image on my local MacBook Pro 16". Build works up until the point when torch (currently version 1.5) is supposed to be installed.
Collecting torch (from -r /tmp/requirements.txt (line 1))
  Downloading https://files.pythonhosted.org/packages/13/70/54e9fb010fe1547bc4774716f11ececb81ae5b306c05f090f4461ee13205/torch-1.5.0-cp36-cp36m-manylinux1_x86_64.whl (752.0MB)
Killed
The command '/bin/sh -c pip3 install -r /tmp/requirements.txt' returned a non-zero code: 137

The above error rears its ugly head after roughly 3 minutes or so. Any ideas what's going on here?

Go in docker preferences and increase your default memory size : ). Looks like the container was killed, whenever this happens to me upping the memory usually fixes it. I'm building this container with 5GB of memory on OSX and it works. : )


merge package from arlac77/npm-package-template

package.json

chore(package<EMAIL_ADDRESS>chore(scripts): cover@#overwrite c8 --temp-directory build/coverage ava && c8 report -r lcov --temp-directory build/coverage
chore(package): add nyc from template
chore(package): set $.ava.require='esm' as in template
chore(package): set $.ava.files='tests/-test.js,tests/-test.mjs' as in template
chore(package): set $.ava.extensions='js,mjs' as in template

Coverage increased (+0.5%) to 48.147% when pulling 8039b1ae7df0c3682b913c698d881244c1c8a69b on template-sync-1 into 0d6c80f29e44b7df1b02e6349768eb64e17495f5 on master.

:tada: This PR is included in version 8.1.21 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Enabling CD for custom Docker images with Azure CLI command does not create a webhook on relevant ACR

As introduced in this page, I have executed the following command to enable continuous deployment for custom Docker images. However,  a webhook on relevant ACR wasn't created.
az webapp deployment container config -n sname -g rgname -e true

Executing the command above should created a webhook on relevant ACR for achieving continuous deployment just as enabling CD with ACR in Azure Portal (see the azure docs page: Continuous deployment with Web App for Containers)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b5c53066-4865-75e5-ebe4-370d32458714
Version Independent ID: 2af4bfe0-2bdf-bce8-ae22-1cdd01123470
Content: Manage Web App for Containers using Azure CLI - Azure App Service
Content Source: articles/app-service/containers/app-service-linux-cli.md
Service: app-service
GitHub Login: @ahmedelnably
Microsoft Alias: aelnably

@yokawasa, Thanks for the question! Could you please share a screenshot of the issue after concealing any private details? In the interim, Just to clarify, kindly ensure that you're looking at the right page/blade, if you haven't tried this already, you may refresh the Azure Portal and then check to see if that helps.

@btardif, I no longer work on that area

@AjayKumar-MSFT
Here is a screenshot of the issue where I tried 2 senarios - enabling CD in Azure Portal & with Azure CLI command. Please let me know if you need further info

@yokawasa, Thanks for providing additional details. Just to highlight, you should execute the following for the configuration.
az webapp config container set -n sname1 -g rgname -c <container name> -r <server url> -u <username> -p <password>

I have tried the same cmds and I understand what you're seeing. I'm checking on this internally and will get back to you soon.

We are tracking this work via the CLI github issue here. Currently we do need to run the config command as pointed out above after create.
https://github.com/Azure/azure-cli/issues/7261

@yokawasa,  As Panchagnula mentioned, the issue is being tracked on the GitHub Azure-CLI repo, we will update that thread once we finish the work, so requesting you to keep a watch on that. We will close this issue out for now. Thanks again for raising this issue and sharing your valuable feedback, it's highly appreciated.


Updated README.md with information on Netlify staging and removed out…

…dated information on versioned doc branches.

Signed CLA.


Add state transform for compute.ForwardingRule

This pull request addressses a gap in state migration from v6 of this provider to modern versions.
The affected field is serviceDirectoryRegistrations, which changed from a List to an Object.
This change will allow for a successful upgrade from v6.67.1 to the next release of this provider.
Fixes #2471.

Add state migration to endure compute.ForwardingRule can upgrade from v6 to mordern versions
Add upgrade test for compute forwarding rule

Tests are failing because tests don't clean up after they fail. I've requested access to clean up resources manually.

The cluster test 409 should be fixed in https://github.com/pulumi/pulumi-gcp/pull/2516, try merging that to see if it resolves the clash?


How about FormData?

I guess this doesn't work out-of-the-box with FormData (as zod doesn't really have a built-in way to work with FormData)?
Also, if it did and I wanted to create a regular form with a server action that posts the form data via Next.js, would there ever be a way to catch validation errors and display those cleanly within your form? Currently the docs suggest you can end that scenario only with redirect, revalidatePath and revalidateTag.
I know you can do this:
<form onSubmit={async (e) => {
   e.preventDefault();
   const myData = ...
   const response = await myServerAction(myData);
   // Deal with validation errors here
}}

but then we're spaghetticoding again, which the whole action={myServerAction} is trying to solve...

I know there's zod extension packages for FormData, but I guess you can't just go and use those with zact, or am I wrong there?

The validated action infers the zod/zfd schema type and Typescript yells when you pass it FormData.

Yeah, there's a problem with the input type, which I already created PR #19 to address that. As of now, you can patch the package locally to workaround.

I'm doing something like this!!!!
import { useState } from 'react';
import { z } from 'zod';
type AsyncFunction = (...args: any) => Promise<any>;
export function useServerAction<T extends AsyncFunction>(action: T, validator: z.Schema) {
	const [loading, setLoading] = useState(false);
	const [error, setError] = useState<Error | null | undefined>(null);
	const [data, setData] = useState<Awaited<ReturnType<T>> | null | undefined>(null);

	async function execute(payload: FormData) {
		setLoading(true);
		setError(null);
		setData(null);

		try {
			const objectData = formDataToObject(payload);
			const validatedPayload = validator.parse(objectData);
			const res = await action(validatedPayload);
			setData(res);
		} catch (e: any) {
			setError(e);
		}

		setLoading(false);
	}

	return {
		data,
		loading,
		error,
		execute
	};
}

function formDataToObject(formData: FormData): { [key: string]: any } {
	const object: { [key: string]: any } = {};
	formData.forEach((value, key) => {
		if (!object.hasOwnProperty(key)) {
			object[key] = value;
		} else if (Array.isArray(object[key])) {
			object[key].push(value);
		} else {
			object[key] = [object[key], value];
		}
	});
	return object;
}

'use client';

import { useServerAction } from '@/lib/useServerAction';
import { test } from './action';
import { z } from 'zod';

export default function Form() {
	const {
		data,
		loading,
		error,
		execute: testAction
	} = useServerAction(
		test,
		z.object({
			name: z.string().min(3).max(20)
		})
	);
	if (loading) return
Loading...
;
	if (error) return
Error: {error.message}
;

	return (
		<form action={testAction} className='flex flex-col justify-center items-center h-full'>
			<input placeholder='Enter a value' name='name' />
			<button type='submit'>Add</button>

{JSON.stringify(data, null, 2)}

		</form>
	);
}

'use server';
export async function test({ name }: { name: string }) {
	return name ;
}

Aren't server actions just functions? I'm unsure why Zod's primitives for this aren't sufficient:
"use server";

export const action = z
  .function()
  .args(z.object({ hello: z.boolean() }))
  .implement(async (data) => {
    console.log("Server", data);
  });

Aren't server actions just functions? I'm unsure why Zod's primitives for this aren't sufficient

You are actually correct, Zod alone is sufficient enough if you only want to validate the input data.
But it wasn't enough if you want to catch the invalid input and display the error on to client-side.

I resorted to this setup with react-hook-form as an intermediary with Zod validatino. Basically validation is first done on the client, and the data is sent as an object instead of FormData to the sever where you can reuse the same Zod schema for server-side validation. Whatever is still invalid at that point has been messed with by the end user so you can basically throw dirty errors that are handled by an error boundary (or Next.js error pages) from that point I guess...
Tutorial: https://www.youtube.com/watch?v=h3w9tQoXx5I&t=1s&pp=ygUSem9kIHNlcnZlciBhY3Rpb25z

@verheyenkoen Yeah, having the client-side validation works too, I personally use it myself. But when it comes to progressive enhancement, they are not really an option.
I personally don't really enjoy having a form library and validation library bundle in client code, as they add quite a bit to the bundle size, even for a simple form. I always wanted to do something similar to remix-validated-form, validation on server-side, but it just not possible with NextJS yet. I heard they (React/Vercel Team) are planning something in the near future, something similar to the experimental useOptimistic & useFormStatus.


search function is case-sensitive

扩展版本 (extension version):  Version: 1.4.2
浏览器版本 (browser version): Chromium 71.0.3578.98
操作系统 (operating system): Peppermint 8
问题描述 (problem description):
Search function ought to be case-insensitive, if there isn't an button to toggle between case-sensitive and case-insensitive. But better-onetab's search function is case-sensitive without toggle button.
实际行为 (actual behavior):

Store cnwangjie/better-onetab: A better OneTab for Chrome & Firefox
Search chrome
Search function can't find cnwangjie/better-onetab: A better OneTab for Chrome & Firefox

期望行为 (expected behavior):

Store cnwangjie/better-onetab: A better OneTab for Chrome & Firefox
Search chrome
Search function can find cnwangjie/better-onetab: A better OneTab for Chrome & Firefox

重现步骤 (reproduce step):

Store cnwangjie/better-onetab: A better OneTab for Chrome & Firefox
Search chrome

+1


Keep getting an exception

Hi, I keep getting an exception when running your plugin.
https://gist.github.com/Pentasis/0a77053bb5a61fbc086dd81b7d4132fb

Does this exception prevent the extension from working, or is it just a side effect with the extension still working anyway?

Having just looked at the line in my code where the exception is thrown, it looks like the extension wouldn't be working at all for you. But the issue is very strange. The exception is thrown on the first line of this code:
      for (language in LanguageUtil.getFileLanguages()) {
        val li = LanguageInfo(language, ++nextLanguageId)
        val id = language.idLc

        languageLookup[id] = li
        languageIndexLookup[nextLanguageId] = li
      }
    }

LanguageUtil.getFileLanguages() is nothing more than an IntelliJ method for listing available languages. The failure has to be somewhere inside IntelliJ itself, and I can't imagine why this would throw an exception.
I suppose I could try to work around the problem, by catching any exception that happens, and if one does happen, substituting a pre-defined language list. But it's odd that I'd need to do that.
Which IntelliJ product are you using? Can you think of anything unusual about your configuration or other extensions that might cause checking the list of available languages to fail?

Hi,
I am using IntelliJ IDEA Community Edition 2020.2.3 with the following added plugins:

Atom file Icons
cmdsupport
git machette
git toolbox
batch support
gitignore
ini4idea
toml support
JBehave
Json editor
Ligature Limited (yours)
Minecraft development
Minecraft NBT support
Python community edition
Shell script
String manipulation

If I had to venture a guess I'd say perhaps the Minecraft plugins? As they are not widely used.

I've just submitted an update which will hopefully fix your problem. It should be available in a couple of days as long as nothing goes wrong with the JetBrains approval process.
Please let me know if it helps, whenever you can download it. Since I couldn't reproduce the bug myself it will be good to know for sure that my changes fixed the problem for you.

Since my update has passed the automated JetBrains checks, I made a release of those change available here, which are available now if you don't want to wait for the final JetBrains approval: https://github.com/kshetline/ligatures-limited-intellij/releases/tag/v1.0.2
You can download the extension and install it manually from the linked release above.

The updated plugin is now available in the JetBrains Marketplace, so you should be able to automatically update to the new version, without having to manually install it. I'll close this bug as fixed in a few days unless I hear otherwise from you.

I got the update this afternoon. It seems to be fixed. Thank you.

Fixed.

I'm getting the same stack trace in PhpStorm 2021.1 EAP. @kshetline would you like me to open a new issue?


How to add a stage?

What is your question?
I have an image, I want to set this image as stage, how to do it?

read the wiki

@bbpanzu I don't find something on it.

https://github.com/ShadowMario/FNF-PsychEngine/wiki/Lua-Script-API on this page there is an example with the lua


ES6 import doesn't work

I tried to import iziModal through ES6 import but it was unsuccessful.

import 'izimodal/js/iziModal.js';

This is probably conflicting with two versions of JQuery, the izimodal is using JQuery 2
@dolce , could you upgrade to Jquery 3?

@carlosfiori , @Ernisto .
Use the latest version. Now it supports the AMD pattern. thx

@dolce Thanks!


Feat noloop

Noloop feature.
This resume the work of @markbjerke #181
I had a fix for noLoop rule which were not re-evaluated when change happens from another rule.

I should add a test with multiple agendas


Add types for activate and deactivate functions

Add types for activate and deactivate functions
/**
 * **Required**
 *
 * Entry point of a VSCode Extension
 *
 * Called when the first [Activation Event](https://code.visualstudio.com/api/references/activation-events) happens
 *
 * [_(Source)_](https://code.visualstudio.com/api/get-started/extension-anatomy#extension-entry-file)
 */
export type Activate = (extensionContext: ExtensionContext) => void;

/**
 * **Optional**
 *
 * Called before an extension is deactivated
 *
 * Gives a chance to clean up before an extension becomes deactivated
 *
 * For many extensions, explicit cleanup may not be required, and the deactivate method can be removed. However, if an extension needs to perform an operation when VS Code is shutting down or the extension is disabled or uninstalled, this is the method to do so.
 *
 * [_(Source)_](https://code.visualstudio.com/api/get-started/extension-anatomy#extension-entry-file)
 */
export type Deactivate = () => void;

From https://github.com/DefinitelyTyped/DefinitelyTyped/pull/67929

We don't accept PRs to the DefinitelyTyped repo, the source of truth is the vscode.d.ts file in this repo.
I don't think we need this though, the function will typically be in the generated yo code file, and its type doesn't need to be referred to from anywhere else in user code.

@roblourens

the source of truth is the vscode.d.ts file in this repo.

That's why I made a PR to make this feature be added to vscode.d.ts instead of making a PR to DefinitelyTyped ?

and its type doesn't need to be referred to from anywhere else in user code.

import { Activate, Deactivate, ExtensionContext } from 'vscode';

export const activate: Activate = (extensionContext) => {
	// etc...
}

export const deactivate: Deactivate = () => {
	// etc...
}


dparse-0.5 is broken on Python 2

safety version: 1.8.7
Python version: 2.7.15
Operating System: macOS, Ubuntu

Description
safety has a dependency on dparse>=0.4.1, but on 2020/03/14 dparse released version 0.5 that only supports Python 3.x, but does not have a python_requires = '>=3.0' constraint in its setup.py, so pip will happily install v0.5 in Python 2 environments.
dparse-0.5 will assume anything that's not a str to be a nested iterable to process recursively, but safety passes requirements lines to setuptools_parse_requirements_backport as unicode instances, so dparse tries to recursively parse the first character of the line forever, eventually exceeding the maximum stack depth.
Issue in dparse's tracker: https://github.com/pyupio/dparse/issues/46
What I Did
$ safety check --full-report -r output_of_pip_freeze.txt
Traceback (most recent call last):
  File "/Users/lanzz/.pyenv/versions/2.7.15/bin/safety", line 10, in <module>
    sys.exit(cli())
  File "/Users/lanzz/.pyenv/versions/2.7.15/lib/python2.7/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/Users/lanzz/.pyenv/versions/2.7.15/lib/python2.7/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/Users/lanzz/.pyenv/versions/2.7.15/lib/python2.7/site-packages/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/Users/lanzz/.pyenv/versions/2.7.15/lib/python2.7/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/Users/lanzz/.pyenv/versions/2.7.15/lib/python2.7/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/Users/lanzz/.pyenv/versions/2.7.15/lib/python2.7/site-packages/safety/cli.py", line 59, in check
    packages = list(itertools.chain.from_iterable(read_requirements(f, resolve=True) for f in files))
  File "/Users/lanzz/.pyenv/versions/2.7.15/lib/python2.7/site-packages/safety/util.py", line 80, in read_requirements
    req, = parse_line(parseable_line)
  File "/Users/lanzz/.pyenv/versions/2.7.15/lib/python2.7/site-packages/dparse/parser.py", line 62, in setuptools_parse_requirements_backport
    for line in lines:
  File "/Users/lanzz/.pyenv/versions/2.7.15/lib/python2.7/site-packages/dparse/parser.py", line 58, in yield_lines
    for s in yield_lines(ss):
  File "/Users/lanzz/.pyenv/versions/2.7.15/lib/python2.7/site-packages/dparse/parser.py", line 58, in yield_lines
    for s in yield_lines(ss):
  File "/Users/lanzz/.pyenv/versions/2.7.15/lib/python2.7/site-packages/dparse/parser.py", line 58, in yield_lines
    for s in yield_lines(ss):

. . . skip lots of repeats from the same line 58 . . .

  File "/Users/lanzz/.pyenv/versions/2.7.15/lib/python2.7/site-packages/dparse/parser.py", line 50, in yield_lines
    if isinstance(strs, str):
RuntimeError: maximum recursion depth exceeded while calling a Python object

Python version was dropped with version 0.5 you can still use 0.4 anyway. There is a bug anyway with the published package that does not includes py_requires attribute.

We are open to consider whether Python 2.7 support should be back to master branch. At this moment, if you depend on Python 2.7 you should be able to use dparse version 0.4.


Search issue [ Missing Lab automation filter ]

The "Lab automation" filter is missing from the products.

@andreituicu Understood your point. We can close this issue.

@MeghnaTewari thank you!


feat(TextIndex): add text index DDL and DML syntax

What problem does this PR solve?

Issue Number: close/fix/reslove/ref #141
What is changed and how it works?
Please describe how it works
添加全文索引DDL,DML语法
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B
[x] Test cases to be added
[ ] No code

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

Codecov Report

:exclamation: No coverage uploaded for pull request base (full-text-index@e4f5b40). Click here to learn what that means.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@                Coverage Diff                 @@
##             full-text-index     #140   +/-   ##
==================================================
  Coverage                   ?   70.28%
==================================================
  Files                      ?      394
  Lines                      ?    83847
  Branches                   ?        0
==================================================
  Hits                       ?    58935
  Misses                     ?    21072
  Partials                   ?     3840

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

建议下次拆分功能提交，另外请在PR里面补充添加全文索引DDL,DML语法具体是什么 @lkx-del

thx @lkx-del


Issue #3: Adding Upon API Documentation

To fix Issue #3
Overview:

Added jsdoc annotations to auth and quote modules (both controller and helper js files).

Did an npm install of jsdoc so it is included in dependencies

Generated jsdocs and have packaged them up as part of this PR in the out directory (which is automatically where jsdoc places them).

Added a script to package.json to generate jsdocs. Run this by running npm run-script docs. This will call the jsdoc cli tool and auto-generate jsdocs based on annotations present in all folders under /src.

Notes on Accessing Documentation: All jsdoc documentation can be accessed by viewing any of the generated html files in the /out folder. /out/index.html includes links to all the namespaces/methods documented and is a good starting point to access documentation.

Hi, @mlimos
Thank you for your contributions! They were very helpful!
I will be merging this for now!


Improve Evaluation Metrics and HTML minifier

Pull Request Summary
This PR includes the following changes:
Changes in htmlMinifier.js

Added a custom attribute data-supported-primitives to the minified HTML.

This attribute helps the LLM (Language Model) identify if an element is clickable, hoverable, etc.

Added helper functions:

isClickable: Determines if an element is clickable.
isHoverable: Determines if an element is hoverable.
canInputText: Determines if an element can accept text input.

Updates in the eval/ folder

Updated evaluations for the following sites:

bigbasket
flipkart
makemytrip

Added an evaluation for 99bikes.com.
Removed evaluation for jackphelanchevy.info due to constant blocking issues.

Log Line Improvements

Improved log messages for better clarity.

#5 #6


docker image is run by default as root (privileged) user

At the moment docker image runs as root user when invoked.
I would suggest to use a non-privileged user in image by default.

You are right. But I'm a little concerned about the incompatibility of changing the default user...

@wata727 here is PR with the change https://github.com/terraform-linters/tflint-bundle/pull/69 ready for review please.

For example, the following code from Super-Linter will no longer work.
https://github.com/github/super-linter/blob/05f34c653f433dfac36856d446a0d624c46c2012/Dockerfile#L124
Originally, this image was not intended to be used as-is (probably too many things are missing), so a non-root user may not be necessary.


Vulnerability Issue with Jackson Library

Hi,
We are still getting issues with Jfrog for Vulnerability in Jackson, and It is still looking for the 2.12 Jackson library instead of 2.14. I also used MVN org.owasp.dependency-check-maven for Vulnerability; It is also highlighting jackson 2.12. Could you please check what is wrong here? Please refer below screenshots

This is due to the use of shade plugin, which brings in an earlier version of Jackson dependencies.  This was necessary because breaking changes were introduced in cucumber gherkin logic from version 7.3.0. The new code was breaking the adapter code. To avoid having multiple versions based on cucumber versions I added the shade plugin.
I have to figure out a way but currently I do not have a solution nor a definite time frame. Please feel free to use an alternate reporting solution or even better offer a way out. Thanks.

I checked Maven and it does not show any vulnerabilities for this artifact. Also the maven dependency tree does not show any jackson jar bought in by the adapter pom. The versions that you mention are only present in the meta-inf\maven\pom files of the shaded jar.

Actually, you did an awesome work with extent and most people started switching to your library. With org.owasp.dependency-check-maven and Jfrog we are able to detect this Vulnerability. Some people unable to use dependency because of vulnerability. I will also try to find solution to this and get back to you. We really appreciate your work. Thanks a lot!

Can you check how jfrog is checking for this vulnerability? I have never worked on jfrog. I ran the owasp checker on the jar and it is showing the issue.
I have to dig deeper into the inner workings of maven shade plugin. The original  messages.jar is also a shaded jar which is adding complexity.

You can use this artifact safely, as I have double checked, as there is no jackson jar dependency bought in or jackson code in the shaded jar. I guess jfrog and owasp are reading the meta-inf\maven\pom files. I have a minimize jar setting in the shade plugin which removes all classes which are not used, which removes the jackson classes.
Currently I am unable to figure out how to remove this entry from these files.

Fixed in 1.9.2

Hi,
Many thanks, we are not getting this issue.


Admin tasks

You're the repo boss so you get to do these two things:

[ ] Choose and add licence
[x] Summary blurb at the top of the page says "MAtlab". I guess it should be "MATLAB"

Summary blurb was deliberate but it doesn't look like it so changed.
Decided on MIT license for simplicity


Error:(50, 34) error: cannot find symbol class Builder

in Android-WiFiBeacon-demo/wibeacon-sample/src/main/java/cz/droidboy/wifibeacon/util/PrefUtils.java call function
return new ScanFilter.Builder()
                    .setMac(mac)
                    .setSsid(ssid)
                    .setChannels(channels)
                    .setProximity(proximity)
                    .build();

because ScanFiliter there is no method Builder so appear Error:(50, 34) error: cannot find symbol class Builder when build apps.

I have try to solve this, please check My PR #2 @jonasevcik

just add this to end ScanFilter.java
public static class Builder {

        private String mac;
        private String ssid;
        private Set<Integer> channels;
        private Proximity proximity;

        public Builder setMac(String mac) {
            this.mac = mac;
            return this;
        }

        public Builder setSsid(String ssid) {
            this.ssid = ssid;
            return this;
        }

        public Builder setChannels(Set<Integer> channels) {
            this.channels = channels;
            return this;
        }

        public Builder setProximity(Proximity proximity) {
            this.proximity = proximity;
            return this;
        }

        public ScanFilter build() {
            return new ScanFilter(mac, ssid, channels, proximity);
        }

    }