serverCloseFrame.getPayload() is not working

Hello,
I have a problem with method serverCloseFrame.getPayload() in OnDisconnected method. When I try to call serverCloseFrame.getPayload(), OnDisconnected basically freezes and does not do anything further and I dont get anything for getPayload method. Could it be because it is empty?
Sincerely,
Egor

Did getPayload() freeze? Please show me your source code around the call of getPayload().

We are seeing the same issue here: Code around getPayLoad():
public void onDisconnected(Socket socket,WebSocketFrame serverCloseFrame, WebSocketFrame clientCloseFrame, boolean closedByServer) {
     log.debug("Disconnected from websocket end-point, was it closed by server: " + closedByServer);
    log.debug(serverCloseFrame.getCloseReason() + "\t" + serverCloseFrame.getPayloadText() + "\t" + serverCloseFrame.
    log.debug(clientCloseFrame.getCloseReason() + "\t" + clientCloseFrame.getPayloadText() + "\t" + clientCloseFrame.
}

We see the action end at the first log.debug line. Nothing is written on console. Only when the closedByServer = true, those log.debugs print something.


[common] Load plugin classes directly from jar without decompression

Purpose
Currently to load classes from plugins, PluginLoader have to decompress a jar file out of Paimon distribution jar and load that jar file. It is hard for a long existing client (for example a SQL gateway service) to clean up these jar files.
This PR fixes the issue by loading plugin classes directly from distribution jar without decompression.
Tests
Existing tests should cover the change.
API and Format
No.
Documentation
No.

This solution is not work in JDK 11 and JDK 17.

This solution can not work in JDK 11 and JDK 17.

Changed the solution a bit and now it works on both JDK 11 and 17.


Spike inline editing emoji

EditableText and therefore TextField does not support WidgetSpan on any platform.
Tested WidgetSpan on Web and works.
#36

Please rebase after your windows PR is merged.

Please rebase after your windows PR is merged.

This PR seems to be abandoned. I'm going to merge it as a reference because it's quarantined to its own directory.


Increase timeout to 2h

The test make target can take longer than default 1h timeout.
Documentation:
https://tekton.dev/docs/pipelines/pipelines/#configuring-the-failure-timeout
https://tekton.dev/docs/pipelines/pipelineruns/#configuring-a-failure-timeout
Verification Steps
Apply the pipelines to some cluster (other than the one where nightlies rue) and validate that the timeout is set as expected

I applied the eventlistener change on kua-multi already


UVI Request

--- UVI JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from  to before v5.12.11",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=fb429fad145a987056ac315b2c859197c3daa890"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "fb429fad145a987056ac315b2c859197c3daa890",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "dm verity: fix require_signatures module_param permissions\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.12.11 by commit fb429fad145a987056ac315b2c859197c3daa890. For more details please see the references link."
}
--- UVI JSON ---

This issue has been assigned UVI-2021-1001016


[Event Request] codeunit 5752 "Get Source Doc. Outbound"- OnBeforeCheckSalesHeaderLocation

Hi, in the codeunit 5752 "Get Source Doc. Outbound", would it be possible to get an event OnBeforeCheckSalesHeaderLocation in the procedure CheckSalesHeader, like this:

            if SalesLine.FindSet then begin
                IsHandled:= false;
                OnBeforeCheckSalesHeaderLocation(SalesLine, SalesHeader, ShowError, SalesOrder, Result, IsHandled);
                if IsHandled then
                    exit(Result);

                LocationCode := SalesLine."Location Code";
                SetItemVariant(CurrItemVariant, SalesLine."No.", SalesLine."Variant Code");
                TotalNoOfRecords := SalesLine.Count();

    [IntegrationEvent(false, false)]
    local procedure OnBeforeCheckSalesHeaderLocation(var SalesLine: Record "Sales Line"; SalesHeader: Record "Sales Header"; ShowError: Boolean; SalesOrder: Page "Sales Order"; Result: Boolean; IsHandled: Boolean)
    begin
    end;

Thanks

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Update requirements.txt and some CI config

Update Ubuntu CI image
Bump Python in CI to something not EOL
rebuild requirements.txt using uv

@grahamgower
This has to happen before anything else can work (#167, etc.).
One proposal/question for this one:
I'd argue that we can take the requirements_old.txt and:

rename it requirements.txt
remove all the version pins
rename the requirements.txt in this PR to requirements_locked.txt or requirements_CI.txt

A change like this would reproducible builds in CI, allow things like uv to regenerate the locked file for us, etc..

@grahamgower -- I made those changes and squashed it all down.

Merged. Thanks!


Use Milliseconds instead of Second since ResLevel1DownsampleRange is …

Use Milliseconds instead of Second since ResLevel1DownsampleRange is in Milliseconds
Signed-off-by: clyang82<EMAIL_ADDRESS>

[ ] I added CHANGELOG entry for this change.
[x] Change is not relevant to the end user.

Changes

Verification

/assign @moadz Please take a look. That is a blocking issue for us. Thanks.


Sector-specific visibility toggle switch not sticking.

This question, which is specific to the fisheries sector, isn't showing up because I can't toggle the "sector-specific visibility" and have it stay on.
https://next.seasket.ch/fsm/survey-editor/35/691

Fixed in eeb627f93119305bde9685797c07361b715f3a3e and deployed to production


Fixing a few links in the support policies section

@tapashmajumder Please do not merge yet, but I'd love a review.


Back-fill changes

:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-autogen/overview/azure/HDInsight.yml
:warning:Warning

Details

docs-ref-autogen/overview/azure/HDInsight/Management.yml
:warning:Warning

Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docfx.json
:white_check_mark:Succeeded

docs-ref-mapping/reference.yml
:white_check_mark:Succeeded

docs-ref-autogen/overview/azure/HDInsight.yml

[Warning] Failed to extract file creator information from git history.

docs-ref-autogen/overview/azure/HDInsight/Management.yml

[Warning] Failed to extract file creator information from git history.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Create logger hierarchy

This means that all loggers are organized in a tree with a single root logger, and configuring a logger subtree involves determining the path to its root, ex:root.child.grandchild.

This is at least partly implemented now; I don't remember what remains.


Treewide: fix more URL permanent redirects

Motivation for this change
Less problems reported by Repology
Related issue: #60004
Previous PR: #73478
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @jonringer

no rebuild, diff LGTM


Unable to Load switches file

Saving and then Loading turns the switches list type from Array[Switch] to Array.

Fixed in the latest commit.


Add missing parameters from /v1 endpoint

Context
Currently beam_width is missing in the schemas. It should be added with default values provided. Any other missing parameters from /v1 endpoints should be added in the schemas.
Alternatives
Not right now.
Has the feature been requested before?
Yes
If the feature request is approved, would you be willing to submit a PR?
No

Seed's constraint on maximum value should be removed as well.


Avoid unnecessary memory allocations

Zero-length slice allocations might result in an unnecessary memory allocation if you don't add later data to the slices, which could result in multiple unnecessary allocations per flow received.
This PR suggests to replace constructs like:
templatesFlowSet := make([]netflow.TemplateFlowSet, 0)

by:
var templatesFlowSet []netflow.TemplateFlowSet

The code is still safe against nil references to slice, as Go allows operating with nil slices in the len, append and range operators:
If e.g. templatesFlowSet == nil:

len(templatesFlowSet) == 0
templatesFlowSet = append(templatesFlowSet, XX) will return a new slice with XX appended.
for i, v := range templatesFlowSet will be a zero-iteration loop.

Thanks! Will take a look

Thank you!


fuzz: delete CBOR test

We were using an outdated CBOR crate for MSRV reasons. But this old crate is causing suprious test failures. So delete it. (Sadly, updating the crate doesn't fix the issue, replacing it with ciborium breaks our MSRV tests because it needs a more recent half dependency, and replacing it with minicbor doesn't work because minicbor is not based on serde. So we don't really have any options.)
In general, I am suspicious of this decode-then-reencode test. CBOR has some ambiguity in integer encoding. Empirically it has seemed to work for a long time, but this seems more like an indictment of our test than a positive result.
Also, round-trip testing serde encoding of a byte vector is probably not a great use of our fuzz resources. I don't believe we have ever had a problem with this.
Fixes #2801

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.332%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
19313

Relevant Lines:
23176

💛  - Coveralls

Also, round-trip testing serde encoding of a byte vector is probably not a great use of our fuzz resources. I don't believe we have ever had a problem with this.

Should we be removing the hashes/json fuzz test as well then?

Yeah. Historically, I believe the hashes have fuzztests because those tests were extremely easy to write, and bitcoin_hashes was a repo where I could do experimental stuff with basically no friction. But I don't think the fuzztests were ever actually useful, other than for my learning to use honggfuzz.
So, yes, I think it's reasonable to just delete them all.


Powertoys doesn't index the same shortcut in two places (start menu folder and desktop) unlike Windows Search

Microsoft PowerToys version
"0.53.3"
Running as admin

[X] Yes

Area(s) with issue?
PowerToys Run
Steps to reproduce

Open any website in Chrome
Three dots upper right corner -> More tools -> Create shortcut...  (this creates a shortcut on Desktop and in Start Menu folder)
Name it so you can remember it
Open PowerToys run and search for the file name
If you see it's found, delete it from Desktop (it's a shortcut of that file name)
Try searching again in PowerToys run
It's not there anymore
Open Windows search and search for the same file. Windows Search still sees the shortcut in Start Menu folder while PowerToys doesn't

** the only workaround I have found is to restart PowerToys and the item from start menu folder will show up**
✔ Expected Behavior
Powertoys Run shouldn't pick only 1 location of the file and ignore every other instance of the same file when the initial file is deleted.
It should re-check upon deletion of the indexed file if there's another instance of the file without having to restart PowerToys.exe
❌ Actual Behavior
It stopped indexing Start Menu folder if the shortcut was found on Desktop and it PowerToys run needs to be restarted in order for it to find the shortcut in Start Menu.
Other Software
No response

Can you confirm this issue is still relevant in v0.73? /needinfo


allow manually trigger & add permission to write

Hello, I am a code review bot on flows.network.
It could take a few minutes for me to analyze this PR. Relax, grab a cup of coffee and check back later. Thanks!


Not working on Android...

with Flutter 1.13.5 / Dart 2.8:
The package works on iOS (with the minor build fix I mentioned in a separate report) however it is not working on Android for me.  The scanning appears to work correctly (camera appears and then automatically dismisses upon framing a barcode), however the Flutter call never returns from the method channel.  I'm going to do some more digging today and see if I can determine why.

This turned out to be a problem in our code.  Specifically, our main activity was not invoking the super method in its own onActivityResult() handler.


Add new GMOS Pyraf data reduction NB

Data reduction example NB to showcase usage if the Gemini IRAF kernel at DL. NB contributed by Vini P and Brian M from US-NGO. @jacquesalice can you please review it?

@rnikutta will do! Should I leave my comments in this PR or email Brian and Vini directly?

@jacquesalice You can make the comments right here on GH, thanks,

@vmplacco @rnikutta  I'm having an issue with the cell that uses bash and wget to download the FITS files from the Gemini archive. I'm running the notebook on the Data Lab notebook server under in this directory: ~/notebooks_20230123_193855/04_HowTos/DataReduction/PyrafGMOS/. But when I run the cell to download the files, it saves them in my ~/ directory and the rest of the notebook gives me errors like:
ERROR - GSREDUCE: Input image : N20190302S0248.fits does not exist
ERROR - GSREDUCE: Exiting with 1 errors

ERROR - GSREDUCE: Program execution failed with 1 errors

GSREDUCE done

Hi Alice,
Yes, it assumes that you're running on your home directory. If you do:
import os
os.chdir(~/notebooks_20230123_193855/04_HowTos/DataReduction/PyrafGMOS/)
would it work?
Best,
Vini
On Tue, Apr 18, 2023 at 10:48 AM Alice Jacques @.***>
wrote:

@vmplacco https://github.com/vmplacco @rnikutta
https://github.com/rnikutta I'm having an issue with the cell that uses
bash and wget to download the FITS files from the Gemini archive. I'm
running the notebook on the Data Lab notebook server under in this
directory: ~/notebooks_20230123_193855/04_HowTos/DataReduction/PyrafGMOS/.
But when I run the cell to download the files, it saves them in my ~/
directory and the rest of the notebook gives me errors like:
ERROR - GSREDUCE: Input image : N20190302S0248.fits does not exist
ERROR - GSREDUCE: Exiting with 1 errors
ERROR - GSREDUCE: Program execution failed with 1 errors
GSREDUCE done
—
Reply to this email directly, view it on GitHub
https://github.com/astro-datalab/notebooks-latest/pull/163#issuecomment-1513572417,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADDPMU5B3IH3JD3B75A6MSLXB3HWBANCNFSM6AAAAAAXC4F32I
.
You are receiving this because you were mentioned.Message ID:
@.***>

@vmplacco ah yes! That worked when I did:
import os
os.chdir('/home/jail/dlusers/ajacques/notebooks_20230123_193855/04_HowTos/DataReduction/PyrafGMOS/')

Or even:
import os
os.chdir('./')

I'll review the rest of the notebook, but this is something that will need to be added in case other users are running on their home directory.

Great, thanks!
Yes, we can add an extra cell there.
Best,
Vini
On Tue, Apr 18, 2023 at 11:01 AM Alice Jacques @.***>
wrote:

@vmplacco https://github.com/vmplacco ah yes! That worked when I did:
import os
os.chdir('/home/jail/dlusers/ajacques/notebooks_20230123_193855/04_HowTos/DataReduction/PyrafGMOS/')
Or even:
import os
os.chdir('./')
I'll review the rest of the notebook, but this is something that will need
to be added in case other users are running on their home directory.
—
Reply to this email directly, view it on GitHub
https://github.com/astro-datalab/notebooks-latest/pull/163#issuecomment-1513586545,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADDPMU6N2MXDPVBJWJH5KALXB3JGPANCNFSM6AAAAAAXC4F32I
.
You are receiving this because you were mentioned.Message ID:
@.***>

So, it should work in the directory in which the NB is. Mike made a change to the kernel specifically for that.
@mjfitzpatrick , can you please work with Alice to identify what's causing the regression?
Thanks,
Robert

@bmerino95 @vmplacco my other comments:

Can you add a bit more description about what is happening in each cell? For instance, in the Basic Reduction part what do the parameters being passed to gsreduce and gsflat represent (i.e. fl_flat, fl_gmosaic, fl_fixpix, etc)?
In the same cell, I can see that the first 3 inimages are the files that were downloaded to my directory in the previous cell, but where do inflats="gsN20190302S0250" and inimages="gsN20190302S0248" come from?
Again in this same section, you should inform the user that there will be a few dozen FITS files and temporary files created/removed from running this cell.
In the "Display fully reduced spectrum" section, can you briefly explain how you are calculating the wavelength values from CD1_1 and CRVAL1?
In the same section, change data = iraf_out[2].data to flux = iraf_out[2].data for clarity on what the variable contains.

Thanks! :)

Thanks @jacquesalice! I should be able to work on this on Thursday (there is an AURA meeting tomorrow and I am helping out with a NOIRLab Open House) and send it back for a final review.

Great, thanks! The DRAGONS one is coming soon...
On Thu, Apr 20, 2023 at 2:36 PM Alice Jacques @.***>
wrote:

@.**** approved this pull request.
Looks great @vmplacco https://github.com/vmplacco thank you! I'm
approving the PR but I think @rnikutta https://github.com/rnikutta
wanted to take a look as well before we merge into production.
—
Reply to this email directly, view it on GitHub
https://github.com/astro-datalab/notebooks-latest/pull/163#pullrequestreview-1394798157,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADDPMU624F3VKXO4J542Y2DXCGT5TANCNFSM6AAAAAAXC4F32I
.
You are receiving this because you were mentioned.Message ID:
@.***>

Thank you @vmplacco and @jacquesalice . I only cleared the outputs, and will now merge. (We most often leave the output in a NB, but these ones here are very long).


Problem in loading icons

I suggest adding this line in the header section:
<head>
  <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.7.0/css/font-awesome.min.css">
</head>

as the icons didn't appear in my browsers (tried Edge & Firefox).
Any way a huge Thank U for this nice template.

Thank you for this suggested fix. Note that it's only for v4 and Font Awesome is currently on v6. I was unable to get the v6 icons to show in the rendered web page (on Firefox), but I know Font Awesome changed some things with v6 so aren't surprised.
Here's the link to the v6.5.0 stylesheet: https://cdnjs.cloudflare.com/ajax/libs/font-awesome/6.5.0/css/fontawesome.min.css

Try: <link rel="stylesheet" type="text/css" href="dep/Font-Awesome/css/all.css" />
The class for the LinkedIn icon also needs to be adjusted to fa-brands. This worked for me with FA 6.5.1.


traverse: provide an API to get the address of Ancestor

Here a case can be replaced with StatementInjector (#6653). But I'm stuck on how to get address by Ancestor
https://github.com/oxc-project/oxc/blob/ca8c578932734329ee753ca5eb814029a4714e64/crates/oxc_transformer/src/react/refresh.rs#L269-L304
The above logic handles the following code, ￼and determines whether the parent of the current node is Ancestor::VariableDeclaratorInit, if yes, transform and add a new statement to self.extra_statements
const statement = function b() {}

I want to use StatementInjector to replace self.extra_statements, so I need to get the Address of Statement::VariableDeclaration by Ancestor
Do you think it is possible?
Originally posted by @Dunqing in https://github.com/oxc-project/oxc/issues/6641#issuecomment-2421668633

I think this is possible. The actual code for it would be quite simple, but I just need to make sure don't accidentally cause UB. I'll work on this today. Need to do some reading of the unsafe code guidelines!

I think this is possible. The actual code for it would be quite simple, but I just need to make sure don't accidentally cause UB. I'll work on this today. Need to do some reading of the Rustonomicon!

Happy to see you mention what you need to read because I am very curious.

Turns out I was worrying too much. Raw pointers have quite loose restrictions. It would very likely be UB to dereference the pointer with &*ptr (because then that'd create a reference, when there's already a &mut reference to same object in play). But just converting the pointer too a usize should be legal as it doesn't involve deferencing.

In the example you gave above, you'd need to go up the ancestor chain to find the Ancestor::VariableDeclarationDeclarations, and that's the one to get the Address of (because it's the VariableDeclaration which is the Statement).
GetAddress::address is not typed, so type system won't prevent getting the Address of any random node (e.g. an Expression) and then comparing it to Address of a Statement. That comparison will always return false, because they're not the same node, but that result isn't meaningful (of course they're not equal, a Statement and an Expression are completely different things).
Perhaps we should have a typed version of Address to make such mistakes a compile-time error. But I'm not quite sure how to do that. Maybe best we see if it causes us any problems in practice.

Perhaps we should have a typed version of Address to make such mistakes a compile-time error. But I'm not quite sure how to do that. Maybe best we see if it causes us any problems in practice first.

I think this is good enough, initially, our goal is to find a temporary workaround for AstNodeId, and we have achieved

Implemented in #6877.


Use Flowershow for DataHub website

Upgrade datahub.io nextjs site to use Flowershow.
Main details in DataHub website issue.

@rufuspollock can we close this?


governance: record proto events when proposal pass

Before we ship 65, we should make sure that governance events are recorded using proto-events.
Part of #3504.

@zbuc For example, this is done in #3513. We should basically do the same thing for the governance module.

Passed on discussion in planning meeting today, we've decided it's not critical to land this for Testnet 65 (#3554).


Improve dashboard test

Wait for only 20s instead of 100s, to increase test time
Stop sending HTTP traffic to TCP port
Send to all clusters in parallel. Before it was 100s * 5 clusters = 500s per test

cc @gargnupur

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
ecd0dd096aea6ac746e9ba4f5713b2bb6b98f698
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
ecd0dd096aea6ac746e9ba4f5713b2bb6b98f698
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
ecd0dd096aea6ac746e9ba4f5713b2bb6b98f698
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

In response to a cherrypick label: new pull request created: #29005


Fix error display for make default payment method

Details

Fixed Issues

None, noticed here: https://github.com/Expensify/App/pull/10447/files/80e71832f7ba5d0b3f6540d2b1ce7ba57a6eecc9#r1017060491
PROPOSAL: GH_LINK_ISSUE(COMMENT)
Tests

Have an account with multiple payment methods (eg. one personal bank account one P2P debit card)

To add an open personal bank account follow this SO
(Dev-only) To create a P2P debit card, change this condition to always return true
(Staging/Prod-only) Create a debit card using a real US debit card

Sign in to NewDot. Navigate to Settings > Payments
Select a payment method and Make default payment method. Enter the wrong password.
Verify the error is shown on the bottom of the page
Go offline and repeat step 3
Go online, verify the red brick road that leads to the payments page
Repeat step 3 but enter the correct password
Verify the error message is not displayed and the correct payment method is shown as default

QA Steps

Same as test steps
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots

Web
https://user-images.githubusercontent.com/12268372/200855259-15a098ba-874e-4b7c-81f6-9d2a916cc35c.mov
Mobile Web - Chrome
https://user-images.githubusercontent.com/12268372/200856157-55f178af-6f4e-4625-857c-884a9d83d836.mov
Mobile Web - Safari
https://user-images.githubusercontent.com/12268372/200859041-3c51949a-b45d-41f6-8ace-f7f44597a72f.mp4
Desktop
https://user-images.githubusercontent.com/12268372/200861960-f300f48a-88d4-48ae-83bb-066f76cf3a33.mov
iOS
https://user-images.githubusercontent.com/12268372/200860854-491093e9-5e52-4831-8bd0-23a8c3de52d8.mp4
Android
https://user-images.githubusercontent.com/12268372/200858218-c42b1cdf-a4d9-44eb-9dc9-705b59cee012.mov

There is already a PR here: https://github.com/Expensify/App/pull/12579 for this, I guess we should close this since the other already got a review from a C+


Multiple versions of bootstrap

Hi, we have been planning to use tailor for combining multiple of our apps into one.
We have been facing some issues with CSS. Though we fixed app specific css using fragment name as name-spacing, we are unable to do so for external css like bootstrap. We have two react apps, using two different version of bootstrap. Once both the apps are loaded, we are seeing css clash happening for bootstrap components like select, datetimepicker etc. Any thoughts on this?

You have to remember that this is still front-end code once it is all processed by Parse. You wouldn't include two version of Bootstrap in your regular application correct?
You have to decide on one version and stick to it.

True that. I get what you are saying. But the case is a little different here.
Each app is built by a different team, and one app uses bootstrap 3.x, and the other uses 4.x.
Upgrading the other is not feasible at this time. So I was wondering if there is any way to handle this scenario. Appreciate your help.

Here's an idea, perhaps you can use tools like gulp and webpack to prefix each fragment's static resource code. For example you can use the SASS Bootstrap and run it through your own build script which can add prefixes for your fragments. Hope this can get you started...

I think you are talking about using namespace for the css, which I have already done. With that, css issues are taken care to an extent. But the js code from both versions still spill over and are causing issues. Even using common fragment didn't solve that.


Fix GUI display exceptions for time and DST offsets

disable DST offset menu when "Use time of last update..." is disabled
enable save (Ok button) when time difference value is changed

Your patch didn't properly fix all the GUI issues:

if you check "Ignore DST box" and uncheck "Use time of last update", the DST offset list can still be scrolled and changed
the Ok (save) button is still not enabled when you change only the Allowable time offset list (1, 3, 10)

Here's a proper patch, tested
Thank you a lot

this is ok to merge

Sorry, I overlooked your point.

still not fixed, you missed two lines of the code
but I will commit a better fix to effectively hide the list spinner
look next commit


unexpected use of reserved word 'let' in strict mode

This error is raised under Safari both desktop and mobile using CDN.
http://cdn.rawgit.com/dwmkerr/angular-modal-service/master/src/angular-modal-service.js
"let" is no more supported
http://caniuse.com/#search=let

@angelogeminiani It's because the source code is transpiled from ES6 with babel (see webpack config). You need to use the distribute folder instead of source (http://cdn.rawgit.com/dwmkerr/angular-modal-service/master/dst/angular-modal-service.js).

Please use the code from the dst/ folder rather than the raw source. I have removed the let just in case, but you should use the transpiled code in dst/ to be on the safe side!


fix: move basic field config after RLC and Keccak config in aggregation-circuit

@kunxian-xia mentioned that it may cause lookup table not enough for same degree.
Related commit of scroll-prover https://github.com/scroll-tech/scroll-prover/pull/179/commits/c3ad910fd265a7136b7e29e0a3705caf7bde26cc (tested with degree = 20 in aggregation-tests)

If we use same degree both in FpConfig and the aggregation circuit (e.g. k = 20), before this pr, the flex gate calculates its max_rows = 1 << k - meta.minimum_rows() is larger than the actual max_rows, because keccak circuit uses more rotation than flex_gate does. Therefore, we need to place FpConfig after the configuration of keccak circuit.


Redundant reads and writes

The issue is around the fact that a shard is persisted when a hamt is expanded here and also the cache is flushed and cleared even on read only access which leads to completely unnecessary writes.
I'll link to the PR where I add these extra writes/cache clears as I think it might be the easiest way to describe the diff and what can be improved: https://github.com/ChainSafe/forest/pull/731. The functionality that matches this repo currently is under the go-interop feature and can ignore the Amt changes (I grouped this change together)
I haven't benchmarked the difference in a real use case, but generally saw the writes and reads to be between 1.5-2x more than they need to be.

Eric did some further investigation and documentation work on this here too: https://github.com/filecoin-project/go-hamt-ipld/pull/61

This will be fixed in #74.


Recursive coroutines terminate early

It seems that a coroutine containing a recursive call terminates as soon as the first recursive call returns.
One example:
val foo: Int ~~> (Int, Unit) = coroutine { (i: Int) =>
  yieldval(i)
  if (i > 0) { foo(i - 1); foo(i - 1) }
}

val bar = coroutine { () => foo(2); foo(2) }

val c = call(bar())
while (c.resume) print(c.value)

Expected output: 211211
Actual output: 21
Scala 2.11.7, coroutines 0.4.

Many thanks for reporting!!
Actually, expected output is<PHONE_NUMBER>0100. ^_^
The actual output is indeed 21. This happens due to an ArrayIndexOutOfBoundsException, which means it's easy to fix (it's not a transformation error, phew!). Fix took only 4 characters :)

Very speedy fix :smile_cat:


[QUERY] ORDER BY item expression could not be mapped to a document path

Question
How to pass ORDER BY value to @com.azure.spring.data.cosmos.repository.Query?
@Repository
public interface UserRepository extends CosmosRepository<User, String> {
@Query("SELECT * FROM c ORDER BY c.name DESC")
List<User> query();

works fine, but
@Query("SELECT * FROM c ORDER BY @orderBy DESC")
List<User> query(@Param("order") String orderBy); // orderBy = "c.name";

fails with
com.azure.spring.data.cosmos.exception.CosmosAccessException: Failed to find items;
nested exception is CosmosException{userAgent=azsdk-java-cosmos/4.7.1 Windows10/10.0 JRE/11.0.8, error=
{"code":"BadRequest","message":"Gateway Failed to Retrieve Query Plan:
Message: {\"errors\":[{\"severity\":\"Error\",\"message\":\"Unsupported ORDER BY clause.
ORDER BY item expression could not be mapped to a document path.\"}]}

Setup:

com.azure:azure-spring-data-cosmos:3.1.0

@mbhaskar - please take a look at this.

@Repository
public interface UserRepository extends CosmosRepository<User, String> {
@Query("SELECT * FROM c ORDER BY c.name DESC")
List<User> query();

This is the correct way of doing orderby. If you want to sort on a different property, then that should be part of the query text. Parameters should be used only for values of the document paths

Is there any way to avoid a bunch of similar hardcoded queries with different ordering?

@mbhaskar, @kushagraThapar
Guys, any suggestions?

Currently specifying order by path / sort order as query parameters is not supported.


100days-Day-063.ipynb doesn't parse correctly

https://public.paws.wmcloud.org/12410844/100days/100days-Day-063.ipynb
might be a bug, I don't know, need to look into it

I think it's just that nbqa black 100days-Day-062.ipynb --nbqa-diff isn't valid syntax


Add support for attribute((target(...))) to overcome limitations of -march=native.

Support for -march=native for AArch64 is still new, so it doesn't detect all CPU extensions.
Implicitly telling gcc/clang to enable "crc" extension when using -march=native will allow compiling functions with ACLE CRC32 intrinsics.

I think this can more easily be done by not replacing the crc compiler parameter with -march=native, but rather prepending -march=native to it. That way it will enable it in addition to whatever the native detection enables.

I think this can more easily be done by not replacing the crc compiler parameter with -march=native, but rather prepending -march=native to it. That way it will enable it in addition to whatever the native detection enables.

I thought about that, but it's not any cleaner solution... There was previous discussion about later processors that always have "crc" extension and people wanting to have clean way to make sure compiler use all the available instructions instead of defaulting to "armv8" basic set.
We already removed "native" support in configure, because it was getting ugly, this patch does fix the underlying issue without changing the configuration step of build and solely relying on compiler-specific solution.

Right, with x86 it is a lot easier to specify the wanted instruction (sets for gcc/clang), I forgot the ARM variant is more messy.

Right, with x86 it is a lot easier to specify the wanted instruction (sets for gcc/clang), I forgot the ARM variant is more messy.

That might be one reason why -march=native wasn't supported for AArch64 before.


docs: add JSDocs for top level API objects

This commit adds JSDoc documentation to the CloudEvent and HTTPReceiver
objects exposed by the API when using the top level imports.
Ref: https://github.com/cloudevents/sdk-javascript/issues/130
Ref: https://github.com/cloudevents/sdk-javascript/issues/9
Creating as a draft PR because I'd still like to add docs generation for hosting on GitHub pages.
Signed-off-by: Lance Ball<EMAIL_ADDRESS>

I didn't mark this as "Fixes" for #130 since I think we should discuss what the actual exposed API should be before we determine what constitutes acceptable documentation for end users. I think once a version agnostic emitter is available, that should be exposed at the top level as well, and everything else should be removed from the public facing API. What else besides the CloudEvent and HTTPEmitter and an HTTPReceiver is needed for CloudEvent producers and consumers?

I've added automatic doc generation. You can see how it will look on my fork here: http://lanceball.com/sdk-javascript/

@helio-frota changes applied. Would you mind refreshing your review? Thanks.


Handle alpha versions correctly

The master branch of elasticsearch-net is failing to run integration tests due to an inability to locate the artefact for 8.0.0-alpha1. This PR ensures that any versions which include "-alpha" in their version string are treated in the same way as snapshot versions and located correctly.

Now that the alpha is released properly, this is not an issue. I'll close this for now and we can reconsider it's usefulness in the future should such a situation re-occur.


Fluid Interface to extract fluid from specific tank

"I would really love to see optional ports added to the fusion reactor where you can specify access to each internal tank. Trying to automate an extended chain of reactions is very difficult as you can not specify what input tank to pump in to and what output tanks to extract from. It would be nice if there was say, four ports on the top and bottom of the reactor that could be changed via a gui or right clicking with a wrench in world that changed what tank they accessed." - ElectroFried on Reddit

Put on hold for now, as fitering is made a lot easier with the addition of fluid container interactions with the machine's blocks - now fluid can be taken out of machines and used to set up filtering before any piping is done.


Feature Request: Customize confirmation prompt before exit.

Feature request: A confirmation prompt before terminal app exit.
For example, if there are multiple tabs open, upon initiation of exit a prompt to confirm or cancel exit.
Particularly with the case when multiple tabs open, prompting the user to think before closing multiple tabs may prevent a accidental loss of work/processing in tabs that are not in the foreground.
Perhaps make the prompt configurable in settings with the options:

disabled (no prompt before exit)
multiple (prompt if multiple tabs open)
always (prompt always before exit - for a check before closing even a single open tab)

[ ] #6641 add a "remember" checkbox

We'll use this to track the work to connect #1589 to the close button.

I am using the terminal app together with the WLS and R.
If I am in a similar situation using Ubuntu the terminal asks if I close a tab that contains a running process. If I have a resting tab with just the command prompt waiting for some input I can close the tab without any questions, but if I have an R or ssh session running I get the confirmation dialogue.
I think this would actually be the best way to make everybody kind of happy - right?

New user here, and am loving the new Windows Terminal. In regards to the 'Prompt on close' Can there please be a 'Remember my answer' option to prevent it from coming up every time if we don't want it to? Or can this be done in the Setting .json file?
Thanks in advance!

You can set confirmCloseOnExit to false. Check out the documentation! :smile:

You can set confirmCloseOnExit to false. Check out the documentation! 😄

Thank you!!!!

This is now "confirmCloseAllTabs"

Works like a Charm, Thank you sir!
On Wed, Jul 15, 2020 at 11:15 AM ouweiya<EMAIL_ADDRESS>wrote:

This is now "confirmCloseAllTabs"
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/terminal/issues/2976#issuecomment-658855218,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALSZVHXNYBQ5KAD5AKKEF4TR3XIZRANCNFSM4I3TSTIA
.

--
0101001001101111011000100110010101110010011101000010011101110011001000000100000101110111011001010111001101101111011011010110010100100001

Is there a way to always confirm when closing (even with a single tab)?  I just hit Alt+F4 by mistake on a Terminal window which was half way through a PowerShell script and wasn't prompted.  I'm not sure if there's a way to detect a running action, but ideally it should never exit without prompt while a script or similar is running in the window imho.
Huge thanks
Fotis

Is there a way to always confirm when closing (even with a single tab)?  I just hit Alt+F4 by mistake on a Terminal window which was half way through a PowerShell script and wasn't prompted.  I'm not sure if there's a way to detect a running action, but ideally it should never exit without prompt while a script or similar is running in the window imho.
Huge thanks
Fotis

@fgimian sorry for the late reply! I'm working on implementing it right now

Is there a way to always confirm when closing (even with a single tab)?  I just hit Alt+F4 by mistake on a Terminal window which was half way through a PowerShell script and wasn't prompted.  I'm not sure if there's a way to detect a running action, but ideally it should never exit without prompt while a script or similar is running in the window imho.
Huge thanks
Fotis

@fgimian sorry for the late reply! I'm working on implementing it right now

Thank you so much! 😄

You’re welcome!
From: Fotis<EMAIL_ADDRESS>Sent: July 27, 2020 19:31
To<EMAIL_ADDRESS>Cc: Eric<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [microsoft/terminal] Feature Request: Customize confirmation prompt before exit. (#2976)
Is there a way to always confirm when closing (even with a single tab)? I just hit Alt+F4 by mistake on a Terminal window which was half way through a PowerShell script and wasn't prompted. I'm not sure if there's a way to detect a running action, but ideally it should never exit without prompt while a script or similar is running in the window imho.
Huge thanks
Fotis
@fgimianhttps://github.com/fgimian sorry for the late reply! I'm working on implementing it right now
Thank you so much! 😄
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/terminal/issues/2976#issuecomment-664739682, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALKX3RVW47BOUSAM4XVCKHLR5YZ7ZANCNFSM4I3TSTIA.

ooops, I've closed a tab by mistake. not big work lost, but I was just an ENTER keypress away from starting a long script.
what is the status of this?

what is the status of this?

I've got about 50% of the spec written over in: https://github.com/microsoft/terminal/issues/6549#issuecomment-675494526. Just needs time to flush that out to a proper doc, and implement it.

The confirmCloseAllTabs is not enough. It needs to confirm also if only one tab but multiple windows in that tab is present.

How about hiding the close X except on the active tab? Typically the ones I accidentally close are not the tab I'm currently active in (because I'm trying to switch tabs). Perhaps if you hover long enough on the tab the X appears, but it seems like it would prevent a lot of accidents if you have to activate the tab first before you can close it.

@coopstah13 That particular element we're tracking in #3335, namely, https://github.com/microsoft/terminal/issues/3335#issuecomment-1127502724

is still still waiting deployment ? I just lost a bunch of work by hitting the x on a tab by mistake (no prompt if i meant it) :(

Yep. There still hasn't been any progress on formalizing https://github.com/microsoft/terminal/issues/6549#issuecomment-675494526 nor any work done to actually implement that yet.


Configuration for Blazor-wasm

Blazor WebAssembly 3.2-preview3 adds support for configuration. Blazor will populate config from wwwroot/appsettings.json and wwwroot/appsettings.${HostingEnvironment}.json from the Blazor WebAssembly (client) app.

In a hosted application, the value of HostingEnvironment is the same as the server app's value. See xref:aspnet/core/fundamentals/environments
HostingEnvironment is always Development when using the Blazor Development server. In non-ASP.NET Core hosts, this value would be Production by default.

Warning: Configuration in a Blazor WebAssembly application is visible to users and should not be used to store application secrets or credentials.

@guardrex this is for the 3.2 release. It's a bit sparse, because there isn't much to it, but let me know if you need more details.


[Retro][API][v3] Adding item using POST endpoint fails when specifying valid collection id (int)

https://en.numista.com/forum/topic119117.html

Fixed Apr 1


Details how to inpaint?

Hi, I'm having a bit of trouble with this and seemingly getting diff results when doing some trial and error.
1: create img with txt2img
2: erase region of  img I want SD to inpaint?
*3: select the img layer and press inpaint. ... just gives me a new inpaint 1 layer... that is all white.
or
1: create img with txt2img
2: erase region of  transparency mask of the img I want SD to inpaint?
*3: select the img layer and press inpaint. ... just gives me a new  inpaint 1 layer... that is all white.
or
1: create img with txt2img
2: erase region of  transparency mask of the img I want SD to inpaint?
*3: select the transparency layer and press inpaint. ... Crashes Krita
Advice on what I might be doing wrong here would be appreciated!
Cheers

Watch the demo video: https://youtu.be/nP8MuRwcDN8


Another timeout issue

I'm currently getting this error fairly frequently:
An error occurred in an after hook
  Capybara::Poltergeist::TimeoutError: Timed out waiting for response to {"name":"reset","args":[]}
  occurred at /Users/tfwright/.rbenv/versions/1.9.3-p194/lib/ruby/gems/1.9.1/bundler/gems/poltergeist-943398fdd23a/lib/capybara/poltergeist/web_socket_server.rb:147:in `rescue in send'

It appeared after updating to 0.7 PhantomJS 1.7, briefly disappeared after a restart but came back. I know there have been other timeout issues reported but I haven't seen this particular error (with reset).   I'm now using 943398fdd23a5c187df39a520265350a6168bbeb as advised in the other thread.  PhantomJS works fine in the console and there don't appear to be any hung processes.  On OS X 10.8.2

I am seeing this error constantly while running my test with parallel_tests.  My phantomjs version is 1.9.7 with mac os mavericks + ruby 2.2.1p85  + and Rails 4.1.9.
Other members in my team don't have the problem though, so it's probably related to my local environment.  Any idea in what may have caused this??
  An error occurred in an after hook
    Capybara::Poltergeist::TimeoutError: Timed out waiting for response to {"name":"reset","args":[]}. It's possible that this happened because something took a very long time (for example a page load was slow). If so, setting the Poltergeist :timeout option to a higher value will help (see the docs for details). If increasing the timeout does not help, this is probably a bug in Poltergeist - please report it to the issue tracker.
    occurred at /Users/andang/.rvm/gems/ruby-2.2.1@dandelion/gems/poltergeist-1.5.1/lib/capybara/poltergeist/web_socket_server.rb:87:in `rescue in send'

!!!!! EXCEPTION: Timed out waiting for response to {"name":"visit","args":["http://localhost:62668/app/products/='foo:'bar'"]}. It's possible that this happened because something took a very long time (for example a page load was slow). If so, setting the Poltergeist :timeout option to a higher value will help (see the docs for details). If increasing the timeout does not help, this is probably a bug in Poltergeist - please report it to the issue tracker..  Retrying once !

As you have mentioned, your phantomjs version is 1.9.7, this may be causing problem, also your poltergeist version need to be updated. According to me,  you should update your Poltergeist gem, and also update PhantomJS to version >= 2.1.0.
use bundle update poltergeist.
Hope this works for you.


Chained connection as member of multiple receivers array

Currently you can't do this (from fizzbuzz example)
:data -> [
  lock:data -> :data,
  mod:data
]

That is handy if you need smt like this
:data -> lock:data -> :data
:data -> mod:data

But this one is impossible due to #473

Currently you have to
:data -> [mod:data, lock:data]
...
lock:data -> :data

implemented


can I filter a boundary (zb Netherlands)

Can I filter a boundary zb the Netherlands?
At this moment I can create a BBox but there are also edits from Germany and Belgium in this filter.
picture

At the moment you cannot. But we will soon be shipping out the filter where you can upload the geometry.

I'd appreciate having this too. I'm usually interested in what's happening within the borders of Denmark (the country) only, so I'd appreciate being able to select "Denmark" as a filter (or even one of the 5 administrative regions). The borders are in OSM allready, so it shouldn't be necessary to upload any geometry.

Also useful for the Mapillary team. Linking image capture challenges with edit challenges will be a lot easier when we can search changeset comments easily within a given area.


[FIX] Change "manager" for "observer"

Why
Correct possibly unintended swap of words
Changes
Swap of single word in context
Tasks

[x] Add relevant tests, if needed
[x] Add documentation, if needed
[x] Update README, if needed
[x] Ensure that all the examples (as well as the demo) work properly

It looks like the Travis CI job failed though... 😕

Thanks a lot for the contribution!


Update sbt-shading to 2.0.0

Updates io.get-coursier:sbt-shading from 2.0.0-RC6-1 to 2.0.0.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.get-coursier", artifactId = "sbt-shading" } ]

labels: sbt-plugin-update, semver-pre-release

Handled from https://github.com/coursier/coursier/pull/1713.


Class when calendar is open

To help distinguish this UI element from others in a group, is it possible to get a class added to the DateRangePicker element when the picker is open/shown/active?
Just a simple class like is-open or DateRangePicker_open. There is a focused class on the input but that doesn't allow the parent element to be styled.
Much appreciated and apologies if this has previously been requested (I couldn't find anything related to stateful classes).

Hi @M-Willett, you can use onFocusChange={this.onDateRangeFocusChange} prop from DateRangePicker to detect when dateRange is focused and calendar is opened. Then you can wrap dateRangePicker in div with dynamic className.


MNT: Re-rendered with conda-build 3.17.8, conda-smithy 3.2.14, and co…

…nda-forge-pinning 2019.03.12; now building from source again, using some ugly hacks

Checklist

[X] Used a fork of the feedstock to propose changes
[X] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[X] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[X] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

The recipe could do with some maintainers listed in the extra/recipe-maintainers section.
Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [14]

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

todo: add to LDFLAGS etc, not replace

@conda-forge/core Can you please check if a hack I used to get this recipe to build is safe/valid?  In build.sh I did
rm ${BUILD_PREFIX}/${HOST}/sysroot/usr/lib/libpthread.so
ln -s /lib64/libpthread.so.0 ${BUILD_PREFIX}/${HOST}/sysroot/usr/lib/libpthread.so
Is there a less hacky / proper way to fix the linking error that happens without these lines?

@yarikoptic @joeyh i’ve found a pair of ugly hacks that seems to work for building the git-annex recipe with the current conda-forge.  maybe, try it to see if it installs and works ok on your systems?

Only for Linux, right?

yes

installed, ran annex test -- all clear.  Installed datalad and ran its tests - discovered only datalad related issues (https://github.com/datalad/datalad/issues/3224) so afaik all good


Don't allow setting various properties, such as currentPageNumber/currentScale/currentScaleValue/pagesRotation, before {PDFViewer, PDFThumbnailViewer}.setDocument has been called

Currently a number of these properties do not work correctly if set before calling setDocument; please refer to the discussion starting in https://github.com/mozilla/pdf.js/pull/8539#issuecomment-309706629.
Rather than trying to have some of these methods working, but not others, it seems much more consistent to simply always require that setDocument has been called.
/cc @timvandermeij Since your comment in https://github.com/mozilla/pdf.js/pull/8539#issuecomment-309897649 seems to support doing this.
/cc @yurydelendik I know that https://github.com/mozilla/pdf.js/pull/8539#issuecomment-309706629 is a long read, but can you please check that you're OK with that reasoning and this PR?

/botio-linux preview

This PR contains a proper fix to the underlying issues uncovered by #8539, please refer to https://github.com/mozilla/pdf.js/pull/8539#issuecomment-309706629 for all the gory details.
@yurydelendik Since you originally added this code, back when the viewer split into components, I just wanted to make sure you're on-board with this change before we land the PR.


wlan0 doesnt support scanning : network is down

When I run hotspot start it overides my channel and hardware selection because the scanning fails. How can I turn off the FndChan function and have it only use the hostapd.conf parameters?

I think there must be line 231 has to be changed
from: Find_Chan $wli_dev 11
to:     Find_Chan "$wli_dev" "11"


Add dry run flag

Is there a way to run luigi in "dry run" mode - to find out what tasks would get run but not actually run them? I found this post that suggests using --workers 0 but that schedules the jobs before quitting. Ideally, it would be nice not to actually touch anything for information purposes (luigi-deps does a good job of listing dependencies but not what the task status would be).

@lebolo, perhaps --workers 0 --local-scheduler? Unlike --workers 0 solution it'll not touch your central scheduler and unlike luigi-deps it will actually carry out the necessary side effects to see what things are done yet and not.

Yeah that's perfect! Would it be useful to add a --dryrun flag that wraps around this for others?

That's a sensible idea. But it's hard to justify which behaviour is a dry run. In particular the  --dryrun you just suggested would still run the side-effects of the complete() methods.
I would prefer if we could have some documentation covering this. @lebolo, would you mind writing a short summary of the pros and cons of different "dryrun" methods? luigi-deps, luigi-deps-tree and --workers 0 --local-scheduler. Perhaps the chapter could be called something like "Various methods of dry running your pipeline".


Add missing property to node object HTTPRequest

Also add tests for broken headers

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Proposed changes

copy n.insecureHTTPParser to node object used in later test
Checklist

[x] I have read the contribution guidelines
[ ] For non-bugfix PRs, I have discussed this change on the forum/slack team.
[x] I have run grunt to verify the unit tests pass
[x] I have added suitable unit tests to cover the new/changed functionality

Fixes #3772 (again)
Probably also needs backporting to cover fix in 2.2.3

Coverage increased (+0.01%) to 68.212% when pulling 58b951e134ab7815640c7184ea33bd561ec427e3 on hardillb:fix-broken-headers-tests into<PHONE_NUMBER>e21df74b339a399e854ed89af6394f on node-red:master.


libreoffice: Update to version <IP_ADDRESS>

Relates to: updating LibreOffice to <IP_ADDRESS> (latest version)

[x] I have read the Contributing Guide.

The autoupdate URL for 64bit needs to be updated too.

libreoffice also supports arm64 architecture now, please consider adding in architecture.

@404NetworkError @ivaquero done and done.

Also what do you think of the following fixes/suggestions:

Rename the following to reflect the actual name of architecture, since 64Bit is now vague! 64 bit for x86 or arm?!

64Bit -> x86_64
32Bit to x86

In lines 12 and 16, replace url with "https://downloadarchive.documentfoundation.org/libreoffice/old/$version/win/x86_64/LibreOffice_$version_$architecture.msi

Thanks for your good suggestions, however this is upstream work of https://github.com/ScoopInstaller/Scoop and tightly bound with the current manifest scheme. Such revisions are reasonable, but not urgent, furthermore this may bring huge rework, I am not sure whether the core maintainers would like to append this to the road map.

Also what do you think of the following fixes/suggestions:

Rename the following to reflect the actual name of architecture, since 64Bit is now vague! 64 bit for x86 or arm?!

64Bit -> x86_64
32Bit to x86

In lines 12 and 16, replace url with "https://downloadarchive.documentfoundation.org/libreoffice/old/$version/win/x86_64/LibreOffice_$version_$architecture.msi

Okay. We can leave those suggestions for later. Please merge this PR as fit. Thanks!

/verify

* `"regex"` in `"checkver"`: `x64` -> `x86_64`

I believe this should be x86**-**64, correct?

Yeah, you are right.

/verify

"autoupdate"."architecture"."64bit"."url": $version_Win_x86_64 -> $version_Win_x86-64

done.
This is exactly why I wish naming conventions were a bit less confusing. Anyways, hope that was all the fixes needed.

Yeah, you are right.

This is exactly why I wish naming conventions were a bit less confusing. Anyways, hope that was all the fixes needed.

/verify

/verify

LGTM

A question out of curiosity: Is it normal for scoop PRs to take this long to be merged to upstream? Thanks.

Since last year, the responses for PRs became particularly slow. Several former maintainers left, and the current maintainers' schedules are obviously too tight.  What's worse is that it takes a long time to become a member of the core team.

I really suggest that the core team to clarify and simplify the procedure of being a maintainer.

I agree! I'm used to pacman and it's fast-paced package management and updates and I was wishing scoop can be that on Windows. I like it over WinGet and Chocolatey, but I think the general turnover should be much faster.

@r15ch13, if you have time, can you review this pull request and merge it into the master branch if it's fine, please?

@niheaven , if you have time, can you review this pull request and merge it into the master branch if it's fine, please?


Peer Review Ticket (Tri 2 Week 1)

Concepts and Expectations
Click here to see our ideation issue that goes over the concepts behind our project.

Build a Sort class for each unique sort. Use Fibonacci Abstraction heirarchy as guide to build an init/sort method for each unique sort. (Include bubble, insertion, selection, and merge. Use of extends. In Parent class store the number of iterations, comparisons, merges/swaps.)

We will meet this expectation by sourcing all sort algorithms from one overarching parent class, sharing inheritable data within a Fibonacci Abstraction hierarchy. This is the step in the process we don't have details proofs for at this point in the process.

Analyze the Big O complexity on Sorts. (Consider the number of operations, time, and space used when analyzing a sort algorithm. Establish analytics including time to sort, number of comparisons and number of swaps. Average the results for each each Sort, run each at least 12 times with 5000 random elements. You should throw out High and Low when doing analysis. Make your final/judgement on best sort: Number of Comparisons, Number of Swaps, Big O complexity, and Total Time.)

This is a large part of our sorting algorithm work on the backend (see timed[type]Sort throughout the API request code). The current step in the backend process that we're in is adding all of the time complexity functionality and making sure that the necessary backend methods connect to the frontend's expectations.

Create 2 additional methods to solve nth result in the Fibonacci Sequence.

Okay, we'll just bake that into our site I guess. We'll just make a page on our frontend blog that does it.

Visualize process in the frontend.

This is one of the primary considerations of our backend-frontend connection. We will be returning the step-by-step process of sorting the different colors, along with discussion of the time complexity, number of comparisons and number of swaps throughout the process. See the wireframe for a better visual example.
Current Progress
We already have some progress with the backend connection, including the setup for our API request and the object that will be used for the request body. You can see both of these things here.
Group Organization
Our group, "MADradium", consists of Drew, Haseeb and AJ.

Name
Role
Responsibilities

Haseeb
Frontend Developer
Creating the frontend functionalities including color setup and user sort functionality.

Drew
Backend Developer
Creating backend sort functionality, timing and step-by-step sort info.

AJ
DevOps
Deployment, as well as focusing on frontend-backend connections in the program.

We have already created and made use of this Scrum Board to chronicle our work. We have also created the start of a full frontend DevLog site for more detailed progress reports.

Group Planning Blog - Drew, AJ, Haseeb
Graded by: David V, Alex L, Ethan Z
Glows:

Everything is explained, well structured
Frontend plan seems intuitive and would complete the requirements
Uses personal idea of colors to sort, not pure sorting
Uses hierarchy to organize classes and subclasses

Grows:

Not everyone spoke about their parts in the project
Fibonacci integration seems a bit to the side but it still completes the requirements

Overall Score/Comments:

0.98/1
Overall, pretty good project, everything seems well integrated and already started coding everything.


tweak(runtime/luaglm): vector values

I've done some testing on vectors and this is what resulted out of it.
You can make any vector with 1 argument, it'll fill out the vector with that one argument, but if you just use vector(number) it will make a vector with one argument, a vector1 if you will.
vectors have the the fields r, g, b and a, depending on the type of vector.
I've only encountered one conflict with this change, and that is the lua extension not seeing the missing parameters anymore when doing vector3(0, 0) for example, as that is not possible and will result in an error. (I do not have the missing-parameter debug disabled)

Best to be explicit with values. vector3(0) works but if this change means vector3(0, 0) doesn't throw an error then I'd rather not use.
As for fields rgba, you can also use number indexes, i.e. vector[1] but I feel it just adds extra confusion to the type.

if you just use vector(number) it will make a vector with one argument, a vector1 if you will.

This actually results in a number, not a vector structure (vector(1) returns 1.0), which would be confusing for type definitions.

As for fields rgba, you can also use number indexes, i.e. vector[1] but I feel it just adds extra confusion to the type.

I would like to have these added though as they are available in the type.

This actually results in a number, not a vector structure (vector(1) returns 1.0), which would be confusing for type definitions.

Yeah that can be left out then, if I were to add an overload function it would cause the same problems as the vector3 example I gave


Error on segmentation

when I ran on Python 3.10 the sample code on the readme file got this error:
trend_classifier/segmentation.py:63: UserWarning: No data frame provided, column argument will be ignored.   self._handle_input_data(column=column, df=df, x=x, y=y)
and when I ran on Python 3.8 get the following error:
/trend_classifier/segment.py", line 20, in Segment     slopes: list[float] = [] TypeError: 'type' object is not subscriptable

Yeah, me too


Form or Forms

This is a issue I am facing , it is written from discord.ext.forms import Form but actually forms is used even while using pip it is said to install discord.ext.forms ,This is all mess the docs also doesnt seem to work pls help.
Making a menu has s in form
@bot.command()
async def menu(ctx):
    embed1=discord.Embed(description="This is embed1")
    embed2=discord.Embed(description="This is embed2")
    embed3=discord.Embed(description="This is embed3")
    rmenu = forms.ReactionMenu(ctx,[embed1,embed2,embed3])
    await rmenu.start()

but not others still a mess pls help

If you import the module like this:
from discord.ext.forms import Form # what is forms, python only knows what 'Form' is

then you cannot access the forms module directly. You would have to use
from discord.ext import forms # now forms exists


Clicking on foreign key column should show record details from other table

Feature request
Is your feature request related to a problem? Please describe.
A couple of weeks ago, clicking on the arrow+box icon in a cell of a column with a foreign key relation would bring up a side panel with more details of the record in the other table.

Now, it brings up a modal that lets you search through the other table, but it does not show more information about the specific record you clicked on.
Describe the solution you'd like
It would be nice to be able to quickly see the full details of the record in the other table corresponding to the specific key you click. This could be with the old side panel view, or it might also work to automatically filter the records in the search modal that pops up now.
Additional context
This experience is currently made worse by the fact that you cannot select and copy the text from a cell with a foreign key relation (or at least not one that's of type uuid), so you can't even copy the value and paste it into the search modal.

Hi @emschwartz We've just fixed this. There' 2 changes in the foreign-key modal:

show the current selected item detail.
clear value action will be inside the modal.

hopefully it'll be released to dashboard app soon.

This experience is currently made worse by the fact that you cannot select and copy the text from a cell with a foreign key relation

For the upcoming update, you can

Ctr+c on a cell to copy the content.
right click on a cell to copy

Excellent!

a solution similar to prisma studio (have a separate column) is more optimal imo

Thanks @maximousblk, we will look into the suggestions on future update.


[Docs]: Clean up our documentation for development & frontend

We have fairly old and incomplete docs in our frontend folder.
We need to document how we can start up and run the various tests -- storybook, jest, etc.
We should also add to the frontend docs the reasoning behind optionalDependencies (from https://github.com/opendatahub-io/odh-dashboard/pull/1004#discussion_r1137271965)

Migrated to:  https://issues.redhat.com/browse/RHOAIENG-2458


[BUG] bcrypt library failure

Describe the bug
This happens when building the app in Docker. bcrypt library fails with the following error:
api-1  | Database 'police_data' already exists.
api-1  | Initialized the database 'police_data'.
api-1  | (trapped) error reading bcrypt version
api-1  | Traceback (most recent call last):
api-1  |   File "/usr/local/lib/python3.11/site-packages/passlib/handlers/bcrypt.py", line 620, in _load_backend_mixin
api-1  |     version = _bcrypt.__about__.__version__
api-1  |               ^^^^^^^^^^^^^^^^^
api-1  | AttributeError: module 'bcrypt' has no attribute '__about__'

To Reproduce
Steps to reproduce the behavior:

Build the app in docker. Since the package version is not pinned, it installs a recent bcrypt version

Expected behavior
Docker should build without issues and api container should work.

Here is the PR to fix this issue: https://github.com/codeforboston/police-data-trust/pull/374

closed with #374


df: kubernetes: job: Kubernetes based orchestrator

Orchestrator for running dataflows in kubernetes using individual jobs.

Kubernetes has a system for strong workload identity. All workloads are associated with service accounts, and they have short-lived OpenID-Connect (OIDC) identity-tokens issued by Kubernetes. The Kubernetes API server signs these OIDC tokens, and other workloads can validate tokens through the Kubernetes API server. This provides strong identities for workloads running on Kubernetes and can be used as a foundation for role-based authentication and authorization.
Instead of using Kubernetes Secrets, developers should base authentication and authorization on OIDC tokens. This means that instead of, e.g., storing a database password in a Secret resource, we should ensure that our database only accepts requests when presented with a valid, unexpired token.
Examples of OIDC token usage to integrate with external systems are AWS IAM roles for service accounts and Hashicorp Vault Kubernetes auth.

Source: https://www.eficode.com/blog/the-future-of-kubernetes-and-why-developers-should-look-beyond-kubernetes-in-2022


add CONTRIBUTING.md

Please add a CONTRIBUTING guide for external contributions

this is now in https://github.com/E4S-Project/e4s/blob/master/docs/contributing.rst


Add new Rails/NegateInclude cop

Closes #17

Renamed to NegateInclude.

This new rule looks good to me. Can you open a PR about this new rule as the Rails Style guide?
https://github.com/rubocop-hq/rails-style-guide

Opened PR in rails-style-guide - https://github.com/rubocop-hq/rails-style-guide/pull/262

Thanks!


Skewed Rotation of UAVs

UAVs are still rotating in a skewed way sometimes.
expected behavior: UAVs always rotating around X and Z axis only.

fixed with new version of DOTween


Every time I launch IntelliJ 2024.1 with codegpt installed, an error regarding inotify is logged.

What happened?
Every time I launch IntelliJ 2024.1 with codegpt installed, an error regarding inotify is logged.
IntelliJ IDEA 2024.1 (Ultimate Edition)
Build #IU-241.14494.240, built on March 28, 2024
Licensed to xxxx
Subscription is active until xxxxx.
Runtime version: 17.0.10+8-b1207.12 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Linux 6.5.0-28-generic
GC: G1 Young Generation, G1 Old Generation
Memory: 2048M
Cores: 20
Registry:
ide.experimental.ui=true
Non-Bundled Plugins:
com.jetbrains.plugins.ini4idea (241.14494.240)
com.guohanlin.JsonToJava (2023.1.3)
bundled-intellij-idea-help (241.14494.240)
org.jetbrains.jumpToLine (0.1.15)
ink.organics.pojo2json (2.0.6)
com.jetbrains.jax.ws (241.14494.158)
jd-intellij (0.8.1)
com.intellij.properties.bundle.editor (241.14494.150)
com.intellij.spring.websocket (241.14494.158)
com.intellij.editSuggestion (241.14494.158)
ee.carlrobert.chatgpt (2.6.3-241)
Pythonid (241.14494.314)
com.intellij.laf.macos (241.14494.150)
com.intellij.grazie.pro (0.3.300)
com.intellij.ml.llm (241.14494.320)
com.jetbrains.packagesearch.intellij-plugin (241.0.9)
org.jetbrains.android (241.14494.240)
com.android.tools.design (241.14494.158)
androidx.compose.plugins.idea (241.14494.158)
com.intellij.queryComplexity (241.14494.150)
com.intellij.spring.ws (241.14494.158)
org.sonarlint.idea (<IP_ADDRESS>113)
com.intellij.java.rareRefactorings (241.14494.158)
Kotlin: 241.14494.240-IJ
Current Desktop: KDE
Relevant log output or stack trace
Unhandled exception in [ComponentManager(ProjectImpl@245312888), CoroutineName(run activity), run activity, StandaloneCoroutine{Cancelling}@32df9e9a, Dispatchers.Default]

java.io.IOException: User limit of inotify instances reached or too many open files
	at java.base/sun.nio.fs.LinuxWatchService.<init>(LinuxWatchService.java:62)
	at java.base/sun.nio.fs.LinuxFileSystem.newWatchService(LinuxFileSystem.java:47)
	at ee.carlrobert.codegpt.FileWatcher.watch(FileWatcher.kt:18)
	at ee.carlrobert.codegpt.CodeGPTProjectActivity.execute(CodeGPTProjectActivity.kt:43)
	at com.intellij.ide.startup.impl.StartupManagerImplKt$launchActivity$1.invokeSuspend(StartupManagerImpl.kt:473)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:108)
	at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:584)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:793)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:697)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:684)
	Suppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException: [ComponentManager(ProjectImpl@245312888), CoroutineName(run activity), run activity, StandaloneCoroutine{Cancelled}@32df9e9a, Dispatchers.Default]

Steps to reproduce
No response
CodeGPT version
2.6.3-241
Operating System
Linux

This seems related to the recent changes to watching for file changes. Can you give us any estimate on the size of the project Could you check your current number of allowed inotify instances with cat /proc/sys/fs/inotify/max_user_instances?
A guess at a temporary workaround is to increase that number using echo higher_number_here | sudo tee /proc/sys/fs/inotify/max_user_instances. Changing the number this way will see it reset at every reboot.
Can you test increasing the number of inotify instances allowed, and see if that solves the problem?

Thank you for reporting, glad to see a Linux user! Can you check your current setting and increase it?
https://stackoverflow.com/questions/32281277/too-many-open-files-failed-to-initialize-inotify-the-user-limit-on-the-total#answer-38486048
If you don't need the FileWatcher you can disable it (enabled by default):
Settings | Tools | CodeGPT | Configuration: Check for new screenshots automatically
I'm wondering if Java would detect your home directory correctly... System.getProperty("user.home") 🤔

Here's the inotify values as reported by sysctl:
user.max_inotify_instances = 128 user.max_inotify_watches = 104857
When you ask about the size of the project, are you talking about source files?
After disabling the filewatcher, it appears that the error is no longer appearing.
However, when I launch a local instance of LLaMA c/c++ usin a pre-defined model, I get "Request timed out. This may be due to the server being overloaded." when I ask it to explain some highlighted code.
No clue if the two issues are related.

Do you have a screenshot, is there an exception stacktrace in the log?
I don't think they are related, you probably chose a model which is "too big" for your machine.
You could try one with a smaller download size, they are usually faster, for example Code Llama 7B 4-bit precision.

My laptop is relatively powerful ... i7 w/ 10 cores & 32gb ram.
IIRC, the local server worked before.
Which log are you referring to?
llama.cpp/llama.log just has this ...
[1713906704] warming up the model with an empty run
The idea log has this timeout error when I ask the plug-in to explain a section of code:
2024-04-23 16:18:04,909 [2705768] SEVERE - #ee.carlrobert.codegpt.toolwindow.chat.ToolWindowCompletionResponseEventListener - Request timed out. This may be due to the server being overloaded. java.net.SocketTimeoutException: timeout 	at okio.SocketAsyncTimeout.newTimeoutException(JvmOkio.kt:146) 	at okio.AsyncTimeout.access$newTimeoutException(AsyncTimeout.kt:186) 	at okio.AsyncTimeout$source$1.read(AsyncTimeout.kt:390) 	at okio.RealBufferedSource.request(RealBufferedSource.kt:210) 	at okio.RealBufferedSource.require(RealBufferedSource.kt:203) 	at okio.RealBufferedSource.readHexadecimalUnsignedLong(RealBufferedSource.kt:388) 	at okhttp3.internal.http1.Http1ExchangeCodec$ChunkedSource.readChunkSize(Http1ExchangeCodec.kt:437) 	at okhttp3.internal.http1.Http1ExchangeCodec$ChunkedSource.read(Http1ExchangeCodec.kt:416) 	at okhttp3.internal.connection.Exchange$ResponseBodySource.read(Exchange.kt:281) 	at okio.RealBufferedSource.select(RealBufferedSource.kt:233) 	at okhttp3.internal.sse.ServerSentEventReader.processNextEvent(ServerSentEventReader.kt:50) 	at okhttp3.internal.sse.RealEventSource.processResponse(RealEventSource.kt:75) 	at okhttp3.internal.sse.RealEventSource.onResponse(RealEventSource.kt:46) 	at okhttp3.internal.connection.RealCall$AsyncCall.run(RealCall.kt:519) 	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) 	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) 	at java.base/java.lang.Thread.run(Thread.java:840) Caused by: java.net.SocketException: Socket closed 	at java.base/sun.nio.ch.NioSocketImpl.endRead(NioSocketImpl.java:253) 	at java.base/sun.nio.ch.NioSocketImpl.implRead(NioSocketImpl.java:332) 	at java.base/sun.nio.ch.NioSocketImpl.read(NioSocketImpl.java:355) 	at java.base/sun.nio.ch.NioSocketImpl$1.read(NioSocketImpl.java:808) 	at java.base/java.net.Socket$SocketInputStream.read(Socket.java:966) 	at okio.InputStreamSource.read(JvmOkio.kt:93) 	at okio.AsyncTimeout$source$1.read(AsyncTimeout.kt:153) 	... 14 more
There is nothing additional logged to llama.log.

I'm playing around with the timeout values in the advanced settings.
Looks like it may be the fix.


[KOGITO-6032] BDD tests: Rename disable_clean_cluster parameter to en…

…able_clean_cluster
https://issues.redhat.com/browse/KOGITO-6032
Signed-off-by: Karel Suta<EMAIL_ADDRESS>Many thanks for submitting your Pull Request :heart:!
Please make sure your PR meets the following requirements:

[x] You have read the contributors' guide
[x] Pull Request title is properly formatted: [KOGITO-XYZ] Subject
[x] Pull Request contains a link to the JIRA issue
[x] Pull Request contains a description of the issue
[x] Pull Request does not include fixes for issues other than the main ticket
[ ] Your feature/bug fix has a unit test that verifies it
[ ] You've ran make before-pr and everything is working accordingly
[x] You've tested the new feature/bug fix in an actual OpenShift cluster
[ ] You've added a RELEASE_NOTES.md entry regarding this change

/jenkins test

/jenkins test

/jenkins test

/jenkins test

/jenkins test

@sutaakar I guess we need to rebase that PR

Rebased
/jenkins test


Attributes in cache files?

Hey there,
maybe I am missing something, but the cache files do also contain informations for attributes.
I am not 100% sure why valinor needs attributes as there is no attribute support regarding type addition from what I can see?
We recently ran into an issue where our OpenAPI Attributes of a request object were persisted in the cache since we do generate the cache at build time while dev dependencies are still available. We changed this to non-dev composer dependencies now but I still wonder why attributes are even parsed at all.

Hi @boesing, thanks for the report.
Attributes support comes from a long time ago, when I was not sure whether mapping behaviors could be controlled by attributes (which is the case in some other PHP mapping libraries). Currently, attributes are only used for the dynamic constructor feature, but I plan to add support for a Constructor attribute which could be used to ease constructor registration, among maybe other features, so removing it is not possible.
I'd better like to know what was the issue you ran into?

Hi @boesing after reading again this issue I understood what was going on.
I opened #408, which should fix it. Any chance you review it and/or test it on your app to see if it fixes the problem?
Thanks!

Hey @romm ,
sorry for not responding.
I'll have a look once I find some time. One thing what for example jms/serializer does, it checks for the attributes namespace so it only caches its own attributes instead of any attribute. That is what I would expect here as well, since you do only care for valinor specific attributes from what I understand, right?
Maybe that could be a thing as well, so you dont have to care about unavailable attributes at runtime? Just dropping my 2 cents here but I will have a look on the Patch as well.
Thanks for considering this.
Regards!

Hi @boesing, thanks for your valuable input.
You're right, for now the library only uses one internal attribute, your suggestion to only accept internally namespaced attributes makes total sense.
However, custom attributes could be used in the future; although it is often advised not to over-engineer things in advance, this feature was coded at a time (before the first public beta release) where I had plan for third party attributes that implemented Valinor-namespaced interfaces.
For this reason, I prefer to keep the feature in place — at least for now — and fix small bugs like the one you just submitted, in case we need it for future attribute features. 😉


RFC: Web Servers Re-Architecture

Readable

2022-07-26 Working Group notes: waiting for feedback.
Should have minimal impact on the PHP language family that consumes httpd/nginx because PHP will likely only want the -dist buildpack.

2022-08-02 WG Notes:
Pending a bit more feedback from other web servers maintainers. There is a question about naming, using -dist or not. If no objections to the proposed naming then @ForestEckhardt will merge.

WG 08-09-2022 Notes:
More approvals are required.
TH: there's a constant mention about the layer limit for Docker, would that still be a concern with this proposal?
EC: I think we need isolation. Pretty much anything we add is a new layer
TH: Agree
DM: it might be nice to know where we are in # of layers to see if we are close to the limit

As of v0.2.151, the full builder has 117 layers. The docker limit is 125.
docker pull paketobuildpacks/builder:full
docker history paketobuildpacks/builder:full | wc -l
     117

2022-08-16 Working Group Notes: @ekcasey has left comments (see above), those comments should be addressed by next week as per @ForestEckhardt

WG 2022-08-23 Notes:
Needs response from @ekcasey after update.

WG 2022-08-30 Notes: OK to merge


footer is not available in login and signup page

footer is not availabe here
please assign me to fix it

@shivamy009 To justify adding the GSSoC-EXT label to your work, you'll need to incorporate additional features or functionality. Only then can I assign the label.
Let me know if you can add anything extra to it.