I followed the introduction to build this project. But I always get many errors like these

/home/luban/miner/xdag-0.4.0/client/block.c:1170: undefined reference to g_rx_pool_mem_index' /home/luban/miner/xdag-0.4.0/client/block.c:1174: undefined reference to g_rx_pool_mem'
/home/luban/miner/xdag-0.4.0/client/block.c:1174: undefined reference to g_rx_pool_mem' /home/luban/miner/xdag-0.4.0/client/block.c:1174: undefined reference to g_rx_pool_mem'
/home/luban/miner/xdag-0.4.0/client/block.c:1174: undefined reference to g_rx_pool_mem' /tmp/ccc7QLBP.o: In function xdag_create_block':
/home/luban/miner/xdag-0.4.0/client/block.c:1053: undefined reference to is_randomx_fork' /home/luban/miner/xdag-0.4.0/client/block.c:1054: undefined reference to g_rx_pool_mem_index'
/home/luban/miner/xdag-0.4.0/client/block.c:1055: undefined reference to g_rx_hash_epoch_index' /home/luban/miner/xdag-0.4.0/client/block.c:1055: undefined reference to g_rx_pool_mem_index'
/home/luban/miner/xdag-0.4.0/client/block.c:1059: undefined reference to g_rx_pool_mem' /home/luban/miner/xdag-0.4.0/client/block.c:1060: undefined reference to g_rx_pool_mem_index'
/tmp/ccc7QLBP.o: In function rx_hash_difficulty': /home/luban/miner/xdag-0.4.0/client/block.c:2341: undefined reference to rx_block_hash'
/tmp/ccc7QLBP.o: In function add_block_nolock': /home/luban/miner/xdag-0.4.0/client/block.c:673: undefined reference to is_randomx_fork'
/tmp/ccc7QLBP.o: In function unset_main': /home/luban/miner/xdag-0.4.0/client/block.c:370: undefined reference to rx_unset_fork_time'
/tmp/ccc7QLBP.o: In function work_thread': /home/luban/miner/xdag-0.4.0/client/block.c:1253: undefined reference to rx_loading_fork_time'
/tmp/ccc7QLBP.o: In function set_main': /home/luban/miner/xdag-0.4.0/client/block.c:357: undefined reference to rx_set_fork_time'
/tmp/ccpvnhZg.o: In function xdag_init': /home/luban/miner/xdag-0.4.0/client/init.c:116: undefined reference to rx_init_flags'
/home/luban/miner/xdag-0.4.0/client/init.c:109: undefined reference to rx_init_flags' /tmp/ccvI9LAk.o: In function process_received_share':
/home/luban/miner/xdag-0.4.0/client/pool.c:884: undefined reference to is_randomx_fork' /home/luban/miner/xdag-0.4.0/client/pool.c:888: undefined reference to rx_pool_calc_hash'
/tmp/ccOgMoqT.o: In function mining_thread': /home/luban/miner/xdag-0.4.0/client/miner.c:386: undefined reference to xdag_rx_mine_worker_hash'
/tmp/ccOgMoqT.o: In function miner_net_thread': /home/luban/miner/xdag-0.4.0/client/miner.c:287: undefined reference to rx_mine_init_dataset'
/tmp/ccYiNv0n.o: In function processExitCommand': /home/luban/miner/xdag-0.4.0/client/commands.c:631: undefined reference to rx_pool_release_mem'
/home/luban/miner/xdag-0.4.0/client/commands.c:631: undefined reference to rx_pool_release_mem' /home/luban/miner/xdag-0.4.0/client/commands.c:631: undefined reference to rx_pool_release_mem'
collect2: error: ld returned 1 exit status
make: *** [xdag] Error 1

Can you tell me the version of your operating system and the steps you followed?
Looks like it lacks a dependency on randomx. You can check if randomx is installed.
If you can tell me more detailed information, I can try to help you solve this problem

Can you tell me the version of your operating system and the steps you followed?
Looks like it lacks a dependency on randomx. You can check if randomx is installed.
If you can tell me more detailed information, I can try to help you solve this problem

@MyronX Emmm. The system is [Linux version 3.10.0-957.el7.x86_64]. And I checked the randomx.h file. It is under the path:[/usr/local/include/randomx.h]. So I guess randomx.h is correctly installed. What is more, I followed the instructions by "cd client && make" command.

maybe u use centos？
try this to build randomx
git clone https://github.com/tevador/RandomX.git
cd RandomX
mkdir build && cd build
cmake -DARCH=native ..
make
sudo make install

and try to open hugepage for randomx

Temporary open

sudo sysctl -w vm.nr_hugepages=2560

Permanent open

sudo bash -c "echo vm.nr_hugepages=2560 >> /etc/sysctl.conf"

then reboot system
See if this method solves your problem

maybe u use centos？
try this to build randomx
git clone https://github.com/tevador/RandomX.git
cd RandomX
mkdir build && cd build
cmake -DARCH=native ..
make
sudo make install

and try to open hugepage for randomx

Temporary open

sudo sysctl -w vm.nr_hugepages=2560

Permanent open

sudo bash -c "echo vm.nr_hugepages=2560 >> /etc/sysctl.conf"

then reboot system
See if this method solves your problem

I do actually build randomx in this way. Maybe rebooting is the key.

ok. Waiting for your feedback

maybe u use centos？
try this to build randomx
git clone https://github.com/tevador/RandomX.git
cd RandomX
mkdir build && cd build
cmake -DARCH=native ..
make
sudo make install

and try to open hugepage for randomx

Temporary open

sudo sysctl -w vm.nr_hugepages=2560

Permanent open

sudo bash -c "echo vm.nr_hugepages=2560 >> /etc/sysctl.conf"

then reboot system
See if this method solves your problem

I do actually build randomx in this way. Maybe rebooting is the key.

ok. Waiting for your feedback

@MyronX I'm facing the same issue, but after I set huge pages and restart my server, it is still not working.


Key store support for Cosigned Admission Webhook

Today Cosigned Admission Webhook can be used with generated keys and potentially with K8s secret
# generate a key-pair in Kubernetes Secret
cosign generate-key-pair k8s://[NAMESPACE]/[NAME]

but cosigned webhook can't use keys from persisted sources. Please add functionality to support keys from other sources like Azure Key Vault, AWS KMS, Google Cloud KMS, Hashicorp Vault. Thanks

Moved it to cosign repo: https://github.com/sigstore/cosign/issues/1069


Nebula lighthouse in different subnet causes issues with latest build

I use a 128 ip range, class B network with a /17 subnet.
I have my lighthouses in their own subnet purposefully. I'm wondering if I can bypass this check of verifying the lighthouse in the current subnet, as that is not something I want. Thank you

In our current state nebula needs a route via nebula to the lighthouses. If they exist in different islands then a client node can't communicate with the lighthouse.


Can't really tell which json is for which workflow

What happened?
Your screenshots are private, so we can't see the high resolution version of those. That means they are not readable. When we click on the hyperlink to see the workflows, their names are not clear enough as to be sufficient for us to know which corresponds to the workflow we're looking for.
Steps to reproduce the problem
Use incognito mode and try to to this in your browser
What should have happened?
I should have received one million dollars automatically
Commit where the problem happens
ComfyUI:
ComfyUI-layerdiffuse:
Sysinfo
RTX 6900
Console logs
herdthsdgsdf

Workflow json file
dghfjsfghsdfgh
Additional information
No response

The screenshots are now working, as soon as I finished making this post.


train/test data

the model LF-InterNet use macro-pixel image as input for train and test, but in this repo generate SAI image?

LF_InterNet.py in this repo includes an additional operation, i.e., x = SAI2MacPI(x, self.angRes), which can covert the SAI images to macro-pixel images for LF-InterNet.

ok, thanks.


ngf-select not detecting horizontal swipe, causing opening window to select image in mobile devices

Hi I am seeing an issue with swipe -
if we have list of placeholders to select images, which has ngf-select to select image. then I am not able to swipe through the list. as it is causing opening a window while swiping. I looked at the code in select.js and saw it has the code to detect and handle vertical swipe but horizontal swipe is not handled.
Please have a look.
ref - http://stackoverflow.com/questions/38920489/ngf-select-causing-opening-window-while-swiping-on-phone?noredirect=1#comment65596330_38920489

Fixed at 12.2.5


Add Update-VCEventAndTaskRetention.Tests.ps1

Added a check to ensure the vCenter Server task and event retention is
set correctly and if not, will remedite to the desired settings in the
config file.
Changes:

Added new Tests.ps1 file
Modified config.ps1 file to add variables for the task and event retention settings
Modified Config.tests.ps1 to validate the changes made in config.ps1

Looks good to me and works in my environment. I think the end goal is to break out the tests into unique Describe blocks, though, which would make tagging simpler. I'd say this works for now and we can break out the individual tests in module in the future.


[Task]: Implement logic to decode the token and validate the token expiry.

SubTasks
Implement function to decode the token obtained from CS and validate the token expiry.

Hey team! Please add your planning poker estimate with Zenhub @AmanAgarwal041 @sneha122

Setting the final estimate to 1 as per planning poker estimate.

Completed with PR https://github.com/appsmithorg/cloud-services/pull/1754


Create Main Page split

Create a split for Posts and Interesting Things.
Left side of posts (8 column) and right side interesting things (4 columns)
Limit number of posts and interesting things to most recent.

close with PR #8


Enable usage of the Trusty beta on Travis

Travis now has new Trusty based instances in Beta. They offer much
faster boot times, twice as much memory, and a more reliable core count.

Also see http://docs.travis-ci.com/user/ci-environment/#Virtualization-environments for a summary of the differences between the standard (Precise) and beta (Trusty) environments.

@bors-servo r+
Should we be turning this on for other repos that require sudo?

:pushpin: Commit a2d4f50 has been approved by Manishearth

:hourglass: Testing commit a2d4f50 with merge 81e7ec8...

We also have Trusty on our linux boxes so this works out well!

Which other repos? I was looking through the Travis docs (actually looking into #142) and noticed they now have a beta for Trusty environments. There only seem to be advantages to switching, so I'd recommend yes after testing to make sure it doesn't cause any regressions.

Ooh, the increased parity also sounds like a good idea, +1 for keeping all environments in sync as much as possible.

Well, sudo: false is still faster than the Trusty thing right now.
The repos that need sudo: required are actually using sudo: 9000, which is a whole different thing and probably won't work with this Trusty stuff.

:sunny: Test successful - travis

Yeah, the significantly faster speed of the container infrastructure makes sense for anything that doesn't need sudo.
What's sudo:9000? A quick search seems to say it's Ubuntu 14.04 on GCE, which AFAICT is the same as the Trusty beta.

Unpublicized faster builds on GCE (experimental feature), not sure if it's exactly the same as trusty, @larsbergstrom would know.

They're the same thing.


Handlers are objects

To allow injecting per handler configuration make our handler modules objects instead.

[x] :+1:
[ ] :shipit:

Looks good @pmcnr-hx

:+1:


more feature rich telemetry in sequencer relayer

Closing, because it's an old ticket with little context and we have done a lot of telemetry changes since opened.

Reopend by automation. Closing again.


:qa completely shuts down Neovim in the background

Brief description:
Entering command qa results in messages "MainController: Neovim was disconnected" and "MainController: Neovim exited with code: 0", shutting itself down and vscode not responding any further.
Reproduce steps:
(1) :qa
Expected
It would be preferred if the editor closes all open tabs without completely shutting down Neovim
Happens
See 1.
Other info
Microsoft Windows [Version 10.0.19043.1165]
VSCode 1.59.0
Neovim NVIM v0.6.0-dev+142-g5a111c1b0

Works for me

I had this issue when closing any tab due to the following:
" Close window when quitting last buffer
autocmd BufDelete * if len(filter(range(1, bufnr('$')), 'empty(bufname(v:val)) && buflisted(v:val)')) == 1 | quit | endif


fmt -w X is failing on "attempt to subtract with overflow"

With one-word-per-line.txt
this
is
a
file
with
one
word
per
line

The program fails with
target/debug/uutils fmt -w 10 fixtures/fmt/one-word-per-line.txt
thread 'main' panicked at 'attempt to subtract with overflow', src/uu/fmt/src/linebreak.rs:298:29
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
this%

https://github.com/uutils/coreutils/blob/master/src/uu/fmt/src/linebreak.rs#L298

Unfortunately, this will take a while to track down as the utility is rather large.


Doc: some minor clarifications and formatting nits

Use "least significant digit first" instead of "little endian" for    32-bit digits.
Document ordering of BigInt::from_slice and    BigInt::assign_from_slice.
Put a dash in "two's-complement" when used as an adjective.
Change "u32" to "u32".

Fixes #124.

bors r+


Update imapsync

Improvement upon PR https://github.com/NixOS/nixpkgs/pull/14209 as recommended by @lancelotsix and @joachifm.

Thanks you. Please review the guidelines on commit naming at https://nixos.org/nixpkgs/manual/#idm140737318605648

It fails on master due to perl bump, would you care to fix it?

@robinbb are you going to open a new PR?

@domenkozar No. I love Nix, but I do not have the time to commit to doing a good job of upgrading this package.

OK, I'll do that then.

@robinbb can you just rebase? It should work now.

Integrated. Thank you.


Page template

Use this issue to discuss the Page template in the ONS Design System

The page template example with save and complete - button doesn't display in the footer < 740

No config for the masthead logo href in the page template

Width and height of svgs lost when rendered in the browser

 prePage block should be preMain

Unlinked references in page template variable tables

Increase page__main margin-top to 2.5rem (over 740) and 1.5rem (under 740).
Spacing is currently too tight.

Save and sign out button in footer of page template example ('Customised page template') is missing exit icon

Is there a way to provide a 'nonce' for the inline script calls without using Talisman? The existing if statements in the layout/_template.njk only allow for the talisman call to add a nonce as far as I can tell

Update page template languages logic.  If more than one other language, hide language toggles in masthead, and show in footer (at appropriate breakpoint)

Broken footer in census page template
https://ons-design-system.netlify.app/styles/page-template/examples/census/


Add @chakra-ui/vue to the dependencies whitelist

Can you link the DefinitelyTyped PR that requires this?

Closing due to inactivity.


Use java.nio.file.Path in FileVirtualIRFiles

Updated. I managed to simplify even further.

CI says that MainGenericRunner.scala in partest needs to be updated.

What a surprise :P Fixed


A few small fixes

handle parsing timestamps when value not supplied (return nil instead of exception).
handle open and closed order on the Order class.
gracefully handle a symbol not returning data for Quote class.
additional attributes for Order class.

Specs updated.  Plus, can see code in action on my crypto project

WHAt is this
a few small fixes ?
is this me being hacked?

CryptOKlizO

-------- Original Message --------
Subject: Re: [mwerner/bittrex] A few small fixes (#13)
Local Time: November 1, 2017 1:07 PM
UTC Time: November 1, 2017 8:07 PM
From<EMAIL_ADDRESS>To: mwerner/bittrex<EMAIL_ADDRESS>Subscribed<EMAIL_ADDRESS>Merged #13.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Hello wtf?

CryptOKlizO

-------- Original Message --------
Subject: Re: [mwerner/bittrex] A few small fixes (#13)
Local Time: November 1, 2017 2:00 PM
UTC Time: November 1, 2017 9:00 PM
From<EMAIL_ADDRESS>To: mwerner/bittrex<EMAIL_ADDRESS>mwerner/bittrex<EMAIL_ADDRESS>Subscribed<EMAIL_ADDRESS>WHAt is this
a few small fixes ?
is this me being hacked?

CryptOKlizO

-------- Original Message --------
Subject: Re: [mwerner/bittrex] A few small fixes (#13)
Local Time: November 1, 2017 1:07 PM
UTC Time: November 1, 2017 8:07 PM
From<EMAIL_ADDRESS>To: mwerner/bittrex<EMAIL_ADDRESS>Subscribed<EMAIL_ADDRESS>Merged #13.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.


The state file does not correspond to the given data file when using custom feature extraction method

Discussed in https://github.com/asreview/asreview/discussions/1048

Originally posted by michagast April 29, 2022
Hi everyone,
I am back again this time with a question about asreview lab. I have currently made my own extension for feature extraction for asreview. This can be found here.
The relevant code is as follows:

from asreview.models.feature_extraction.base import BaseFeatureExtraction
import numpy as np

import pandas as pd                 #For data science purposes
import re                           #For performing regex
import torch                        #For running models with cuda
from transformers import AutoTokenizer, AutoModelForSequenceClassification, pipeline

class Enron(BaseFeatureExtraction):
    """Custom feature extraction

    Feature extraction that generates features based on sentiment values and named entity recogntion among other things.
    """

    name = "enron"
    label = "Enron feature extraction"

    def __init__(self, *args, **kwargs):

        super(Enron, self).__init__(*args, **kwargs)
    def transform(self, texts):
        model = AutoModelForSequenceClassification.from_pretrained("distilbert-base-uncased-finetuned-sst-2-english")

        tokenizernlp = AutoTokenizer.from_pretrained("distilbert-base-uncased-finetuned-sst-2-english")
        sentiment_analysis = pipeline("sentiment-analysis", model=model, tokenizer=tokenizernlp,
                                           max_length=512,
                                           truncation=True, device=0)
        result = np.empty([0])
        for text in texts:
            np.append(result, sentiment_analysis(text))
        return result

The feature extraction method properly shows up within asreview lab and can be selected. The program then takes a while to apply the feature extraction to the dataset but after a while it gives the following error:
ERROR:root:Project enron - ValueError: The state file does not correspond to the given data file, please use another state file or dataset.
Traceback (most recent call last):
  File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.10_3.10.1264.0_x64__qbz5n2kfra8p0\lib\runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.10_3.10.1264.0_x64__qbz5n2kfra8p0\lib\runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "C:\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.10_qbz5n2kfra8p0\LocalCache\local-packages\Python310\site-packages\asreview\__main__.py", line 122, in <module>
    main()
  File "C:AppData\Local\Packages\PythonSoftwareFoundation.Python.3.10_qbz5n2kfra8p0\LocalCache\local-packages\Python310\site-packages\asreview\__main__.py", line 80, in main
    entry.load()().execute(sys.argv[2:])
  File "C:\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.10_qbz5n2kfra8p0\LocalCache\local-packages\Python310\site-packages\asreview\entry_points\lab.py", line 112, in execute
    main_run_model(argv)
  File "C:\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.10_qbz5n2kfra8p0\LocalCache\local-packages\Python310\site-packages\asreview\webapp\run_model.py", line 200, in main
    raise err
  File "C:\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.10_qbz5n2kfra8p0\LocalCache\local-packages\Python310\site-packages\asreview\webapp\run_model.py", line 186, in main
    train_model(args.project_id, args.label_method)
  File "C:\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.10_qbz5n2kfra8p0\LocalCache\local-packages\Python310\site-packages\asreview\webapp\run_model.py", line 117, in train_model
    reviewer = get_reviewer(dataset=data_fp, mode="minimal", **asr_kwargs)
  File "C:\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.10_qbz5n2kfra8p0\LocalCache\local-packages\Python310\site-packages\asreview\review\factory.py", line 243, in get_reviewer
    reviewer = MinimalReview(as_data,
  File "C:\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.10_qbz5n2kfra8p0\LocalCache\local-packages\Python310\site-packages\asreview\review\minimal.py", line 21, in __init__
    super(MinimalReview, self).__init__(*args, **kwargs)
  File "C:\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.10_qbz5n2kfra8p0\LocalCache\local-packages\Python310\site-packages\asreview\review\base.py", line 209, in __init__
    raise ValueError("The state file does not correspond to the "
ValueError: The state file does not correspond to the given data file, please use another state file or dataset.
ERROR:root:Error on training.

Long story short, apparently the state file doesn't correspond to the given datafile. However this seems weird as this happens after I have selected the configuration and have asked asreview to train a base model with the given configurations and have thus not changed the dataset in any way. Note that it takes a while for this error to be generated as it seems that feature extraction is working but then suddenly it throws the error. After the error it is not possible to continue to the active learning.
Does anybody have a clue as to what causes this error? Please let me know.
Thanks in advance,
Micha

Potential issue. I'm transferring it to the issue tracker to be sure it's not missed.

I think the error is in the definition of the transform method, not really in what happens after that.  But it might be useful to have a better error message. Maybe a check to see if the number of rows is correct, directly after feature_extractor.transform() is called.

Thanks for the info @PeterLombaers. Can you review my PR on this?


Added Instrumentation to Gobblin Service

Added basic Instrumentation to the following Gobblin Service modules:

Compiler
Orchestrator

Trivial change, self approving.


Record/Replay trace for the layered store

Use the record/replay mechanism for the benchmark command of the layered store in Tezos (https://github.com/tarides/tezos/tree/vicall%40layered_store_benchs).

This needs a new scehduling (as Q3 2021 is last year :p)


Is it possible to use a native Promise object with q ?

Is it possible to use a native Promise object with q ?
console.log(typeof q.all([]));

Doesn't return a native Promise. Is there anyway to force it to return a native Promise ?

Promise.resolve(promise) will coerce any promise to a standard library promise. All promise methods of all libraries including the standard library will accept another kind of promise, by virtue of "thenability".


Test Performance Optimization

Introduced some new testing base classes to centralize integration testing
Trying to reuse a DocumentStore over most of the integration tests with IntegrationContext
Separated the Schema tests that tend to be slow and destructive of the database structure to Marten.Schema.Testing
Running the main test library with xUnit parallelization turned on
Selectively turns on Storyteller retry for some of the not perfectly reliable async daemon tests

I'm a little disappointed by the progress here, but I see a little better than a 25% reduction in execution time for the unit tests.

@jeremydmiller it would be also good to made the base classes abstract and their constructor protected ;)

I think the base classes are all protected, and I'm saying no to making the constructor protected. That's super annoying 'cause R# tries to make the subclass constructors protected. Can we just get this thing in if the tests pass?


create shortcuts during installation

How can we create shortcuts during installation?
we can use menuinst as suggested here
This continues the simpler install effort

@joamatab I'm just curious, do we know what the shortcut is supposed to do? As in, will it be used to open the docs upon clicking on it, or something else?

Hi Skandan, we can add shortcuts to spyder, anaconda navigator and jupyter lab

After clicking on this icon:

I got Spyder shortcut installed :). I now have a template for adding shortcuts to all executables, so adding them for Anaconda Navigator and Jupyter lab should just be a matter of replacing "Spyder" in my script with these.

Great work Skandan :)

Thanks Joaquin! Should we rename this icon as something like "Spyder with GDSFactory"?

yes, that would be great,
How about gdsfactory spyder gdsfactory jupyterlab and gdsfactory navigator for spyder, jupyterlab and anaconda navigator
?

Thank you Skandan!
there were some hard coded paths that i tried fixing in release  v5.54.0
let me know if that release creates the shortcuts correctly :)

Woops, sorry about that, I must've double checked before sending it!

Thank you Skandan,
I will mark this as done


Volunteer Home - Volunteer for Disaster - Disaster Names are not unique

Multiple disasters exist with the same name.  These should be unique.

I am curious.  I noticed @BillWagner  said this was starting to be implemented.  Did it ever get completed?

@evclay This has been implemented. See here for the code: https://github.com/HTBox/crisischeckin/blob/master/crisischeckin/Services/DisasterService.cs#L74
The added tests are here: https://github.com/HTBox/crisischeckin/blob/master/crisischeckin/Services.UnitTest/DisasterServiceTest.cs#L352
and here: https://github.com/HTBox/crisischeckin/blob/master/crisischeckin/Services.UnitTest/DisasterServiceTest.cs#L471
It looks like I did not close this issue at that time. Fixing now.


refactor cmake install

Why

see https://github.com/alibaba/yalantinglibs/issues/160
What is changing

rename all library name from libxxx to xxx
add alias yalantinglibs::xxx
install all headers (include 3rdparty) to INSTALL_PREFIX/yalantinglibs
add cmake install helper function ylt_install
add test install ci script test_install.sh

Example
Usage
cmake_minimum_required(VERSION 3.24)
project(demo)

set(CMAKE_CXX_STANDARD 20)
find_package(yalantinglibs 1.0 CONFIG REQUIRED)
if (yalantinglibs_FOUND)
    message(STATUS "find ylt")
endif ()

add_executable(main main.cpp)
target_link_libraries(main PRIVATE yalantinglibs::struct_pack)

run
cmake -B build -S .

then, the output
-- The C compiler identification is Clang 13.0.1
-- The CXX compiler identification is Clang 13.0.1
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/clang - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/clang++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Imported target: yalantinglibs::struct_pack
-- Imported target: yalantinglibs::struct_pb
-- Imported target: yalantinglibs::protoc-gen-struct_pb
-- Now you can use cmake helper function protobuf_generate_struct_pb to generate xx.struct_pb.cc xx.struct_pb.h
-- Imported target: yalantinglibs::struct_json
-- Imported target: yalantinglibs::easylog
-- Imported target: yalantinglibs::coro_rpc
-- find ylt
-- Configuring done
-- Generating done
-- Build files have been written to: /tmp/tmp.fGTqFqgSIt/build

Install log
#cmake --install .


"Cannot find valid samples" when running DPO on llama3-8b

Reminder

[X] I have read the README and searched the existing issues.

 The dataset preview in the webui was fine, meaning the data path should be alright.
[
  {
    "instruction": "You are an assistant for multiple choice tasks.Your output should include ONE correct answer (A or B or C or D) and your explanation.Use the following retrieved context to answer the question.Use three sentences maximum and keep the answer concise. ",
    "input": "Question: 增强子的作用特点是（　　）。(A) 只作用于真核细胞中(B) 有严格的专一性(C) 无需与蛋白质因子结合就能增强转录作用(D) 作用无方向性",
    "chosen": "The correct answer is (D) No direction of action.Explanation: The passage states that enhancers can regulate genes at long distances (usually 1 to 4 kb or even 30 kb away), and they do not have a specific direction, meaning their function is not directional. They can still function when the sequence is reversed, unlike promoters which lose their function when the direction is reversed.",
    "rejected": "The correct answer is C) 无需与蛋白质因子结合就能增强转录作用.Explanation: According to the context, enhancers (增强子) do not require protein factors to bind in order to enhance transcription. This is stated in point (5): 需要有启动子才能发挥作用，没有启动子存在，增强子不能表现活性 which translates to Enhancers need a promoter to play their role, and without a promoter, they cannot manifest activity."
  },
  {
    "instruction": "You are an assistant for multiple choice tasks.Your output should include ONE correct answer (A or B or C or D) and your explanation.Use the following retrieved context to answer the question.Use three sentences maximum and keep the answer concise. ",
    "input": "Question: 增强子的作用特点是（　　）。(A) 只作用于真核细胞中(B) 有严格的专一性(C) 无需与蛋白质因子结合就能增强转录作用(D) 作用无方向性",
    "chosen": "The correct answer is (D) No direction of action.Explanation: The passage states that enhancers can regulate genes at long distances (usually 1 to 4 kb or even 30 kb away), and they do not have a specific direction, meaning their function is not directional. They can still function when the sequence is reversed, unlike promoters which lose their function when the direction is reversed.",
    "rejected": "The correct answer is C) 无需与蛋白质因子结合就能增强转录作用.Explanation: According to the context, enhancers (增强子) do not require protein factors to bind in order to enhance transcription. This is stated in point (5): 需要有启动子才能发挥作用，没有启动子存在，增强子不能表现活性 which translates to Enhancers need a promoter to play their role, and without a promoter, they cannot manifest activity."
  },
  {
    "instruction": "You are an assistant for multiple choice tasks.Your output should include ONE correct answer (A or B or C or D) and your explanation.Use the following retrieved context to answer the question.Use three sentences maximum and keep the answer concise. ",
    "input": "Question: 增强子的作用特点是（　　）。(A) 只作用于真核细胞中(B) 有严格的专一性(C) 无需与蛋白质因子结合就能增强转录作用(D) 作用无方向性",
    "chosen": "The correct answer is (D) No direction of action.Explanation: The passage states that enhancers can regulate genes at long distances (usually 1 to 4 kb or even 30 kb away), and they do not have a specific direction, meaning their function is not directional. They can still function when the sequence is reversed, unlike promoters which lose their function when the direction is reversed.",
    "rejected": "The correct answer is C) 无需与蛋白质因子结合就能增强转录作用.Explanation: According to the context, enhancers (增强子) do not require protein factors to bind in order to enhance transcription. This is stated in point (5): 需要有启动子才能发挥作用，没有启动子存在，增强子不能表现活性 which translates to Enhancers need a promoter to play their role, and without a promoter, they cannot manifest activity."
  },
  {
    "instruction": "You are an assistant for multiple choice tasks.Your output should include ONE correct answer (A or B or C or D) and your explanation.Use the following retrieved context to answer the question.Use three sentences maximum and keep the answer concise. ",
    "input": "Question: 增强子的作用特点是（　　）。(A) 只作用于真核细胞中(B) 有严格的专一性(C) 无需与蛋白质因子结合就能增强转录作用(D) 作用无方向性",
    "chosen": "The correct answer is (D) No direction of action.Explanation: The passage states that enhancers can regulate genes at long distances (usually 1 to 4 kb or even 30 kb away), and they do not have a specific direction, meaning their function is not directional. They can still function when the sequence is reversed, unlike promoters which lose their function when the direction is reversed.",
    "rejected": "The correct answer is C) 无需与蛋白质因子结合就能增强转录作用.Explanation: According to the context, enhancers (增强子) do not require protein factors to bind in order to enhance transcription. This is stated in point (5): 需要有启动子才能发挥作用，没有启动子存在，增强子不能表现活性 which translates to Enhancers need a promoter to play their role, and without a promoter, they cannot manifest activity."
  }
]

inside dataset_info.json
{
    "biochem_train": {
        "file_name": "biochem_preference_train_1.json",
        "ranking": true,
        "columns": {
            "prompt": "instruction",
            "query": "input",
            "chosen": "chosen",
            "rejected": "rejected"
        }
    }
}

Expected behavior
start the dpo training
Others
however i got the error below
2024-09-17 07:06:38.389902: I tensorflow/core/util/port.cc:153] oneDNN custom operations are on. You may see slightly different numerical results due to floating-point round-off errors from different computation orders. To turn them off, set the environment variable `TF_ENABLE_ONEDNN_OPTS=0`.
2024-09-17 07:06:38.408209: E external/local_xla/xla/stream_executor/cuda/cuda_fft.cc:485] Unable to register cuFFT factory: Attempting to register factory for plugin cuFFT when one has already been registered
2024-09-17 07:06:38.429936: E external/local_xla/xla/stream_executor/cuda/cuda_dnn.cc:8454] Unable to register cuDNN factory: Attempting to register factory for plugin cuDNN when one has already been registered
2024-09-17 07:06:38.436541: E external/local_xla/xla/stream_executor/cuda/cuda_blas.cc:1452] Unable to register cuBLAS factory: Attempting to register factory for plugin cuBLAS when one has already been registered
2024-09-17 07:06:38.452401: I tensorflow/core/platform/cpu_feature_guard.cc:210] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations.
To enable the following instructions: AVX2 AVX512F AVX512_VNNI FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags.
2024-09-17 07:06:39.674862: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT
09/17/2024 07:06:44 - INFO - llmtuner.hparams.parser - Process rank: 0, device: cuda:0, n_gpu: 1, distributed training: False, compute dtype: torch.float16
[INFO|tokenization_utils_base.py:2269] 2024-09-17 07:06:44,968 >> loading file tokenizer.json from cache at /root/.cache/huggingface/hub/models--meta-llama--Meta-Llama-3-8B/snapshots/62bd457b6fe961a42a631306577e622c83876cb6/tokenizer.json
[INFO|tokenization_utils_base.py:2269] 2024-09-17 07:06:44,969 >> loading file added_tokens.json from cache at None
[INFO|tokenization_utils_base.py:2269] 2024-09-17 07:06:44,969 >> loading file special_tokens_map.json from cache at /root/.cache/huggingface/hub/models--meta-llama--Meta-Llama-3-8B/snapshots/62bd457b6fe961a42a631306577e622c83876cb6/special_tokens_map.json
[INFO|tokenization_utils_base.py:2269] 2024-09-17 07:06:44,969 >> loading file tokenizer_config.json from cache at /root/.cache/huggingface/hub/models--meta-llama--Meta-Llama-3-8B/snapshots/62bd457b6fe961a42a631306577e622c83876cb6/tokenizer_config.json
[INFO|tokenization_utils_base.py:2513] 2024-09-17 07:06:45,376 >> Special tokens have been added in the vocabulary, make sure the associated word embeddings are fine-tuned or trained.
09/17/2024 07:06:45 - INFO - llmtuner.data.template - Add pad token: <|end_of_text|>
09/17/2024 07:06:45 - INFO - llmtuner.data.loader - Loading dataset biochem_preference_train_1.json...
Generating train split: 5 examples [00:00, 262.65 examples/s]
num_proc must be <= 5. Reducing num_proc to 5 for dataset of size 5.
Converting format of dataset (num_proc=5): 100% 5/5 [00:00<00:00, 30.75 examples/s]
num_proc must be <= 5. Reducing num_proc to 5 for dataset of size 5.
Running tokenizer on dataset (num_proc=5): 100% 5/5 [00:01<00:00,  3.28 examples/s]
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/dist-packages/llmtuner/data/loader.py", line 174, in get_dataset
    print_function(next(iter(dataset)))
StopIteration

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/bin/llamafactory-cli", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.10/dist-packages/llmtuner/cli.py", line 65, in main
    run_exp()
  File "/usr/local/lib/python3.10/dist-packages/llmtuner/train/tuner.py", line 39, in run_exp
    run_dpo(model_args, data_args, training_args, finetuning_args, callbacks)
  File "/usr/local/lib/python3.10/dist-packages/llmtuner/train/dpo/workflow.py", line 29, in run_dpo
    dataset = get_dataset(model_args, data_args, training_args, stage="rm", **tokenizer_module)
  File "/usr/local/lib/python3.10/dist-packages/llmtuner/data/loader.py", line 176, in get_dataset
    raise RuntimeError("Cannot find valid samples, check `data/README.md` for the data format.")
RuntimeError: Cannot find valid samples, check `data/README.md` for the data format.

The minimum number of samples should be larger than 20 instances

I see. But After increasing this dataset manually to 22 samples (using the same dummy data), there is still the same error:
2024-09-19 03:58:53.575022: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT
09/19/2024 03:58:58 - INFO - llmtuner.hparams.parser - Process rank: 0, device: cuda:0, n_gpu: 1, distributed training: False, compute dtype: torch.float16
tokenizer_config.json: 100% 50.6k/50.6k [00:00<00:00, 92.9MB/s]
tokenizer.json: 100% 9.09M/9.09M [00:00<00:00, 11.9MB/s]
special_tokens_map.json: 100% 73.0/73.0 [00:00<00:00, 533kB/s]
[INFO|tokenization_utils_base.py:2269] 2024-09-19 03:59:00,884 >> loading file tokenizer.json from cache at /root/.cache/huggingface/hub/models--meta-llama--Meta-Llama-3-8B/snapshots/62bd457b6fe961a42a631306577e622c83876cb6/tokenizer.json
[INFO|tokenization_utils_base.py:2269] 2024-09-19 03:59:00,884 >> loading file added_tokens.json from cache at None
[INFO|tokenization_utils_base.py:2269] 2024-09-19 03:59:00,885 >> loading file special_tokens_map.json from cache at /root/.cache/huggingface/hub/models--meta-llama--Meta-Llama-3-8B/snapshots/62bd457b6fe961a42a631306577e622c83876cb6/special_tokens_map.json
[INFO|tokenization_utils_base.py:2269] 2024-09-19 03:59:00,885 >> loading file tokenizer_config.json from cache at /root/.cache/huggingface/hub/models--meta-llama--Meta-Llama-3-8B/snapshots/62bd457b6fe961a42a631306577e622c83876cb6/tokenizer_config.json
[INFO|tokenization_utils_base.py:2513] 2024-09-19 03:59:01,289 >> Special tokens have been added in the vocabulary, make sure the associated word embeddings are fine-tuned or trained.
09/19/2024 03:59:01 - INFO - llmtuner.data.template - Add pad token: <|end_of_text|>
09/19/2024 03:59:01 - INFO - llmtuner.data.loader - Loading dataset biochem_preference_train_1.json...
Generating train split: 22 examples [00:00, 1025.38 examples/s]
Converting format of dataset (num_proc=16): 100% 22/22 [00:02<00:00, 10.95 examples/s]
Running tokenizer on dataset (num_proc=16): 100% 22/22 [00:03<00:00,  5.94 examples/s]
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/dist-packages/llmtuner/data/loader.py", line 174, in get_dataset
    print_function(next(iter(dataset)))
StopIteration

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/bin/llamafactory-cli", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.10/dist-packages/llmtuner/cli.py", line 65, in main
    run_exp()
  File "/usr/local/lib/python3.10/dist-packages/llmtuner/train/tuner.py", line 39, in run_exp
    run_dpo(model_args, data_args, training_args, finetuning_args, callbacks)
  File "/usr/local/lib/python3.10/dist-packages/llmtuner/train/dpo/workflow.py", line 29, in run_dpo
    dataset = get_dataset(model_args, data_args, training_args, stage="rm", **tokenizer_module)
  File "/usr/local/lib/python3.10/dist-packages/llmtuner/data/loader.py", line 176, in get_dataset
    raise RuntimeError("Cannot find valid samples, check `data/README.md` for the data format.")
RuntimeError: Cannot find valid samples, check `data/README.md` for the data format.

Actually I tried on my original dataset of 1000 samples, it had the same error. That is why I replace my the dataset to this dummy one to see if it has something to do with invalid character, etc. But turns out the dummy set still does not work TT

please update llamafactory to the latest version, you used a very very obsolete version of llamafactory


$file doesn't work correctly when run from ammonite predef file

As in the title:
$ cat predef.sc
import $file.test
$ cat test.sc
val f = 5
$ coursier launch com.lihaoyi:ammonite_2.12.2:0.9.3 -- -f predef.sc
Loading...
Compiling /Users/aleksbg/amm/predef.sc
Compiling /Users/aleksbg/amm/test.sc
Welcome to the Ammonite Repl 0.9.3
(Scala 2.12.2 Java 1.8.0_112)
If you like Ammonite, please support our development at www.patreon.com/lihaoyi
@ test
cmd0.sc:1: not found: value test
val res0 = test
           ^
Compilation Failed
@ $file.test
res0: $file.test.type = test
@

Specifically, the issue is the imports in the respective predef file are meant to be automatically propagated to the REPL/scripts, but I guess the logic around the ImportHooks in the predef isn't doing it correctly so the magic-imported $file.test isn't being made available in the REPL as test

Fixed by https://github.com/lihaoyi/Ammonite/commit/49e007dccc4c5ac7ad78f7d4f124fb436d5f053c

Fixed in the latest unstable
lihaoyi Ammonite$ cat ~/.ammonite/predef.sc
import $file.foo
lihaoyi Ammonite$ cat ~/.ammonite/foo.sc
val bar = 1337
lihaoyi Ammonite$ amm
Loading...
Welcome to the Ammonite Repl 49e007d
(Scala 2.12.2 Java 1.8.0_112)
If you like Ammonite, please support our development at www.patreon.com/lihaoyi
@ foo.bar
res0: Int = 1337


GEODE-5105: Push down ClusterConfigurationService implementation from interface to implementation class

Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[ ] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[ ] Is your initial contribution a single, squashed commit?

[ ] Does gradlew build run cleanly?

[ ] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

Ooops.  Sorry for forgetting to squash first.  Will do as part of any merge, of course.

Aaaand I didn't see GEODE-4858 / #1822, which would conflict and is probably preferable to just pressing those methods down.  I'll close this for now and update after that's resolved.


[Event Request] table 36 "Sales Header" - OnCreateDimOnBeforeConfirmKeepExistingDimensions

Could you please add the following event to skip the Confirm for specific scenarios.
procedure CreateDim(DefaultDimSource: List of [Dictionary of [Integer, Code[20]]])
var
    SourceCodeSetup: Record "Source Code Setup";
    OldDimSetID: Integer;
    IsHandled: Boolean;
    KeepExistingDimensions: Boolean;
begin
   ...

    OnCreateDimOnBeforeUpdateLines(Rec, xRec, CurrFieldNo, OldDimSetID);

    if (OldDimSetID <> "Dimension Set ID") and (OldDimSetID <> 0) and guiallowed then
        //+Change
        //-if CouldDimensionsBeKept() then
        //-    if Confirm(DoYouWantToKeepExistingDimensionsQst) then begin
        //-        "Dimension Set ID" := OldDimSetID;
        //-        DimMgt.UpdateGlobalDimFromDimSetID(Rec."Dimension Set ID", Rec."Shortcut Dimension 1 Code", Rec."Shortcut Dimension 2 Code");
        //-    end;
        if CouldDimensionsBeKept() then begin
            IsHandled := false;
            OnCreateDimOnBeforeConfirmKeepExistingDimensions(Rec, xRec, CurrFieldNo, OldDimSetID, IsHandled, KeepExistingDimensions);
            if not IsHandled then
                KeepExistingDimensions := Confirm(DoYouWantToKeepExistingDimensionsQst);
            if KeepExistingDimensions then begin
               "Dimension Set ID" := OldDimSetID;
                DimMgt.UpdateGlobalDimFromDimSetID(Rec."Dimension Set ID", Rec."Shortcut Dimension 1 Code", Rec."Shortcut Dimension 2 Code");
            end;
        end;
        //-Change

    if (OldDimSetID <> "Dimension Set ID") and SalesLinesExist() then begin
        Modify();
        UpdateAllLineDim("Dimension Set ID", OldDimSetID);
    end;
end;

[IntegrationEvent(false, false)]
local procedure OnCreateDimOnBeforeConfirmKeepExistingDimensions(var SalesHeader: Record "Sales Header"; xSalesHeader: Record "Sales Header"; CurrentFieldNo: Integer; OldDimSetID: Integer; var IsHandled: Boolean; var KeepExistingDimensions: Boolean)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 53447.


Adds a make target to create a test cluster

What this PR does / why we need it:
This PR adds a 'cluster' make target to create a test cluster for CI.
It also refactors the existing devel/ci-run-e2e.sh to pull out the functionality that creates a new cluster so that it can be re-used.
This is so that upgrade tests can be run in CI with make cluster verify_upgrade (because the upgrade script itself does not create a cluster).
(I originally wanted make cluster to run ./devel/cluster/create.sh however this script does not install any tools (kubectl etc). I think eventually we should be aiming for those tools to be built into the CI image itself although we need to figure out local testing workflow).
NONE

/kind cleanup
Signed-off-by: irbekrm<EMAIL_ADDRESS>

DNS tests seem quite flakey lately
/test pull-cert-manager-e2e-v1-21

/test pull-cert-manager-e2e-v1-21

It passes for me locally so I am assuming this is a flake
/test pull-cert-manager-e2e-v1-21

These should be genuine flakes
/test pull-cert-manager-bazel

Assuming that this is now ok
/hold cancel


Tile x/y position sometimes wrong for array of all color tiles block

Describe the bug
The x,y position from each tile retrieved with the array of all color tiles block is wrong sometimes. @mileswatson noted this during development of Chomper game. It's very visually apparent if the tile position is used to place multiple sprites as the layout should be evenly spaced but often isn't.
I did some digging on this and from a brief investigation it looks like this only affects some colours, possibly only the 0th palette pseudo-color which represents the transparent background pixels/tiles.
The bug is very peculiar as it doesn't affect first/last one but rather a tile somewhere in the middle of list. Perhaps this relates to default position of sprites and/or some attempt not to overlap them when initially placed, or perhaps not.
To Reproduce
Steps to reproduce the behavior:

Use array of all blocks to retrieve a tile list for background color (the first one: 222,222,222).
Use the x,y position in some way.
Check the x,y position is correct for all tiles.
Observe a few being incorrect.

Expected behavior
Consistent x,y position/local-offset for a tile.
Screenshots
This shows problem, code is highlighting the bug with red circle (demo code embedded in png):

This is the code:

Desktop (please complete the following information):

OS: Windows
Browser: Chrome
Version: 76.0.3809.132

Smartphone (please complete the following information):

n/a but does behave the same

Additional context
Originally noticed on Chomper, note white dot layout on animated gif showing Level 1: MakeCode Forum: Presenting: Chomper

minimal repro: https://makecode.com/_K7fa8JeXU0X4


Text Formatting in the Summary

Can we enable Text formatting capabilities for the Summary field ?

If I am not mistaken you can use the MarkDown marking allowed on the Adaptive Cards that is explained here. We are using it and it looks correctly.

Closing the issue. As mentioned above, you can format a message with Markdown.


Fix #23 - Restores label basic functionality

I tried to satisfy the requirement described in the issue #23. Maybe it's not the best solution or has a bug I  didn't ran into, but at least it's working for me.
It's highly recommended to check the solution.
Robert.

Your solution fixes the problem that clicking on the labels do not change the value for me.
But it "disables" the click function on the toggle itself. In detail: the toggle() function seems to be called twice in that cases: once from your handler in line 35 and once from the old handler in line 186.
From my tests the old handler can be removed.

Your solution fixes the problem that clicking on the labels do not change the value for me.
But it "disables" the click function on the toggle itself. In detail: the toggle() function seems to be called twice in that cases: once from your handler in line 35 and once from the old handler in line 186.
From my tests the old handler can be removed.


Add commit hooks closes #25

Also, check that commit message ends with #{issue number}
If messages starts with 'Minor' then commit message should not have #{issue number} at the end.

Also, run detekt for pre-push


try to compile example 1 fail

i try to compile your examples but it wil fail ? can you help please . I Like your Project !
try to write to victron smartSolar 100|50

substitutions:
devicename: "victron-ve"
friendname: victron-ve
esphome:
name: ${devicename}
platformio_options:
upload_speed: 115200
esp32:
board: nodemcu-32s
framework:
type: arduino
logger:
level: DEBUG
logs:
component: ERROR
#Enable Home Assistant API
api:
encryption:
key: !secret esp_api_key
ota:
platform: esphome
password: !secret ota_pwd
wifi:
domain: .fritz.box
fast_connect: false
ap:
ssid: $devicename
password: !secret esp_pwd
ap_timeout: 1min
reboot_timeout: 60min
web_server:
port: 80
version: 2
auth:
username: esp
password: !secret esp_pwd
captive_portal:
INFO ESPHome 2024.12.2
INFO Reading configuration /config/esphome/victronve.yaml...
INFO Generating C++ source...
INFO Compiling app...
Processing victron-ve (board: nodemcu-32s; framework: arduino; platform<EMAIL_ADDRESS>HARDWARE: ESP32 240MHz, 320KB RAM, 4MB Flash

toolchain-xtensa-esp32 @ 8.4.0+2021r2-patch5
Dependency Graph
|-- AsyncTCP-esphome @ 2.1.4
|-- WiFi @ 2.0.0
|-- FS @ 2.0.0
|-- Update @ 2.0.0
|-- ESPAsyncWebServer-esphome @ 3.2.2
|-- DNSServer @ 2.0.0
|-- ESPmDNS @ 2.0.0
|-- noise-c @ 0.1.6
|-- ArduinoJson @ 6.18.5
Compiling .pioenvs/victron-ve/src/esphome/components/api/api_connection.cpp.o
Compiling .pioenvs/victron-ve/src/esphome/components/api/api_frame_helper.cpp.o
Compiling .pioenvs/victron-ve/src/esphome/components/api/api_pb2.cpp.o
Compiling .pioenvs/victron-ve/src/esphome/components/api/api_pb2_service.cpp.o

Compiling .pioenvs/victron-ve/src/esphome/components/api/api_connection.cpp.o
Compiling .pioenvs/victron-ve/src/esphome/components/api/api_frame_helper.cpp.o
Compiling .pioenvs/victron-ve/src/esphome/components/api/api_pb2.cpp.o
Compiling .pioenvs/victron-ve/src/esphome/components/api/api_pb2_service.cpp.o
Compiling .pioenvs/victron-ve/src/esphome/components/api/api_server.cpp.o
Compiling .pioenvs/victron-ve/src/esphome/components/api/list_entities.cpp.o
Compiling .pioenvs/victron-ve/src/esphome/components/api/proto.cpp.o
Compiling .pioenvs/victron-ve/src/esphome/components/api/subscribe_state.cpp.o
Compiling .pioenvs/victron-ve/src/esphome/components/api/user_services.cpp.o
Compiling .pioenvs/victron-ve/src/esphome/components/captive_portal/captive_portal.cpp.o
Compiling .pioenvs/victron-ve/src/esphome/components/esp32/gpio.cpp.o
Compiling .pioenvs/victron-ve/src/esphome/components/esp32/preferences.cpp.o
Compiling .pioenvs/victron-ve/src/esphome/components/esphome/ota/ota_esphome.cpp.o
Compiling .pioenvs/victron-ve/src/esphome/components/json/json_util.cpp.o
Compiling .pioenvs/victron-ve/src/esphome/components/logger/logger.cpp.o
Compiling .pioenvs/victron-ve/src/esphome/components/logger/logger_esp32.cpp.o
Compiling .pioenvs/victron-ve/src/esphome/components/logger/logger_esp8266.cpp.o
Compiling .pioenvs/victron-ve/src/esphome/components/logger/logger_host.cpp.o
Compiling .pioenvs/victron-ve/src/esphome/components/logger/logger_libretiny.cpp.o
Compiling .pioenvs/victron-ve/src/esphome/components/logger/logger_rp2040.cpp.o
Compiling .pioenvs/victron-ve/src/esphome/components/m3_vedirect/manager.cpp.o
Compiling .pioenvs/victron-ve/src/esphome/components/m3_vedirect/register.cpp.o
Compiling .pioenvs/victron-ve/src/esphome/components/m3_vedirect/sensor/sensor.cpp.o
Compiling .pioenvs/victron-ve/src/esphome/components/m3_vedirect/ve_reg.cpp.o
Compiling .pioenvs/victron-ve/src/esphome/components/m3_vedirect/ve_reg_def.cpp.o
In file included from src/esphome/components/m3_vedirect/ve_reg_flavor.h:25,
from src/esphome/components/m3_vedirect/ve_reg_register.h:2,
from src/esphome/components/m3_vedirect/ve_reg_def.h:7,
from src/esphome/components/m3_vedirect/defines.h:2,
from src/esphome/components/m3_vedirect/manager.h:17,
from src/esphome/components/m3_vedirect/manager.cpp:1:
/data/cache/platformio/packages/framework-arduinoespressif32@3.20005.220925/cores/esp32/esp32-hal-gpio.h:58:19: error: expected identifier before numeric constant
#define DISABLED  0x00
^~~~
src/esphome/components/m3_vedirect/ve_reg_macro.h:10:16: note: in definition of macro 'Y'
#define Y(...) VA_ARGS
^~~~~~~~~~~
src/esphome/components/m3_vedirect/ve_reg_macro.h:12:15: note: in expansion of macro 'Y'
#define IF(x) x  // alternate method similar to IFNOT()
^
src/esphome/components/m3_vedirect/ve_reg_enum.h:68:39: note: in expansion of macro '_ENUMS_ITEM'
ENUM(WARNINGS, 0), ENUM(REMOTE, 2), ENUM(DISABLED, 3), ENUM(NORMAL, 4), ENUM(BATTERY_LOW, 5),
^~~~
...

Hello @kjk25,
That looks like a conflict in preprocessor symbols definitions and it might be related to using the 'arduino framework'.
I've encountered similar issues in the past and thought they were fixed but I'm usually testing/developing with esp-idf so this might still be a compatibility issue.
I'll try investigate compiling with all different frameworks but, in the meantime if you could try using esp-idf we could see if it works.

It should now compile even on arduino for esp32 (commit)

Hello @krahabb,
First: Thanks for this great Project!
I am working with @kjk25 on a solution to set the value for "Maximum charging current of the battery" in "A" on a SmartSolar MPPT 100/50 via ESP/HomeAssistant, ESP is connected on the ve.direct Port (Serial), so far so good, reading of the Values and registers are working, also the switch on/off, but we need a way to set the Value for the "Maximum charging current" of the battery into the SmartSolar via ESP/HomeAssistant, may you have a solution for this?
Thanks in Advance!

Hi @krahabb ,
the compile for ESP32 works perfect ! thank you verry much for such a fast response.
now we try to write some data to REgister 0xEDF0 to set the charge current.
KK

Hello @kjk25 , @carluccitriest,
It is possible to use EspHome number entities for numeric registers configuration. Some are already (pre)defined but of course there are so many...
I'll show you an example on how to manually configure the entity to properly link the register (the documentation for this is on the way but there's a lot of explanations to carry on...)
number:
  - platform: m3_vedirect
    vedirect_id: vedirect_0
    vedirect_entities:
      - name: "Battery maximum current"
        min_value: 1
        max_value: 10
        step: 0.1
        register:
          address: 0xEDF0
          data_type: UN16
          numeric:
            scale: 0.1
            unit: "A"

min_value, max_value, step are just the common properties you set for numeric entities so you can use whatever meaningful values for your use case. The register section instead describes the layout of the HEX register and is used in place of the type config key since there is no register (preset) definition for 0xEDF0 at the moment in code.
I'm sorry to say I still havent properly tested this way of configuring entities, especially those that are usually not automatically broadcasted by the device itself (configuration registers are in fact not broadcasted by the device) so it might not work as expected.
Nevertheless I have an MPPT on my bench and I'll check this in the coming days (I'll also try to add the preset register definitions for this and maybe other config registers)
Thank you for having a look at the component so that I can improve it with your precious feedback!

Hi @krahabb,
Thanks for the quick response! @kjk25 & I have play around today with your predefinitions .h files of the Register and add the Register 0xEDF0 and 0x2015 (set Temp. Charge), for now it works fine, we would also try your manually configuration tomorrow oř next days and will give you feedback with Details asap. I am excited that we can work well with your project and support many DIY battery storage friends.
Thanks a lot, good job! Mille Grazie, Buon Anno 2025!

UPDATE
The manual configuration in yaml with the register key does not work actually...
I'm testing the scenario and there are various issues which need to be fixed still

we try to set the value of a vedirect_entitie every 30seconds, the value of the slider change like we whont.
but the value in the vedirect_entitie (vedirect_0) is not updated ?
can you help here also?
interval:

interval: 30s
then:

lambda: |-
id(SET_TMP).publish_state(2);

number:

platform: m3_vedirect
vedirect_id: vedirect_0
vedirect_entities:

type: BAT_MAX_CUR_SET_TMP
name: "BAT_MAX_CUR_SET_TMP"
id: SET_TMP
min_value: 0
max_value: 30
step: 0.1

I'm not sure if I get it right but the publish_state api for the number entity only send ('publishes') the new value/state to the rest of the EspHome framework (i.e. it usually broadcast it to linked listeners and/or the homeassistant api component).
In fact, it is used internally by the component to publish a new value when it is received from the protocol.
If you want to 'control' the value (i.e. send a new value to the device) you should use the control api for the number entity but it is protected so far so you cannot directly call it according to how EspHome is designed. According to the way EspHome works you should use an action instead (see this)
Another way, bypassing all of the EspHome stuff/mechanics would be to use the vedirect component directly.
The vedirect component (m3_vedirect::Manager class in manager.h) has several low level api to communicate with the device.
You can access it like this (in a lambda):
id(vedirect_0).send_register_set(0xEDF0, (unsigned short)20); // sets 'Battery maximum current' to 2A

This api in detail, being a template member, must be used with the proper parameter size/type according to the register layout and the value, of course, must be scaled accordingly since it is the raw value for the register.
If the command is successful, the reply should then be automatically routed (with the new value set) to the number entity thus updating it.
NOTE: I'm not sure if you're aware that data written to this and all of the 'Battery settings registers' (page 9 of BlueSolar-HEX-protocol.pdf) are always stored to non-volatile memory and you're discouraged from writing too often (Victron note in the same page)


Update v2-app-types.md

Improve the description of the SPA section.

@VanDng : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@VanDng  Thanks for the update, that looks good.  #sign-off


Change Cloud Debugger to Stackdriver Debugger

Using the latest version of IntelliJ and the plugin. I signed into my account and saw that we ask for permission to manager Cloud Debugger. Should we change that to Stackdriver Debugger?
https://screenshot.googleplex.com/0FkHgqo6O0x

Yes, but I think this need to be filed internally. Let me find the correct place.

filed issue internally. closing since it is not part of this plugin.


Sort comments based on most likes

As a user I want to see the comments with the most likes at the top of the comment list. All other comments should be sorted by date of publication of the comment.

Verified.


Silhoutte plot

Add silhouette plot and score.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

50 of 52 (96.15%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 92.402%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sklearn_evaluation/metrics.py
3
4
75.0%

src/sklearn_evaluation/plot/clustering.py
46
47
97.87%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
1727

Relevant Lines:
1869

💛  - Coveralls

@neelasha23 tag us when ready for review.
I assume you took the tests module as is? If so try to think if we're missing something (mainly on the integration that didn't exist in the module).
Also, we'll need to add docs, like easy code snippets users can plug and play.

Yes I'll tag. I did add a test case for the Integration,  but I'll  check if anything more can be added.

@idomic @edublancas This is ready for review. I have added around 6 test cases apart from the scikit-plot tests, but still the coverage score seems to be stuck at 92%.  Do I need to add anymore code snippets apart from the 4 example scripts?

@idomic have added a .ipynb file for silhouette. Do I need to add guide for elbow curve in this PR or create a separate PR?
Haven't added a .rst file, I think it would be having similar content as the clustering_evaluation.ipynb file

@neelasha23 Please include it as part of this PR

I don't believe there's a way to render the docs locally (I haven't seen it in the readme/tasks).
@edublancas thoughts? Either we push it and check the guide or we add similar scripts to ploomber so devs can test locally

there's a way to render docs locally: https://github.com/ploomber/sklearn-evaluation/tree/master/docs
but the instructions might be incomplete. so if you find any issues, let us know so we can help and please document any missing steps

@idomic  @edublancas
have added test cases and docs for elbow curve as well. A couple of points that I want to highlight:

It looks like there's some inconsistency with the matplotlib @image_comparison functionality. There were two test cases which passed on my local but failed in the CI so I have removed the image comparison for only those 2 cases. Running the override_failed_result_images.py script also didnt help in these cases.  Maybe we should include our own image comparison utility like yellowbricks has.
While building the docs locally I faced this issue. It might be because sklearn has a module by the same name and some conflict is happening. I renamed the module as classification_report_skeval.py and that solved the issue. However I haven't pushed this change as it might be an issue with my local setup. Let me know if I still to push this

@neelasha23 I see some conflict, please solve it.

For 1. we can open an issue about it and move on, I think as long as it works without those 2 tests it's fine.
For 2. I'll build the docs now locally and lets see if this continues.

@yafimvo please review this PR.

looking good to me
@idomic @neelasha23

Good points, on 1 we should use a fixture to save it into a tmp folder.

@neelasha23 tag me when this is done and we can merge.

@idomic  I have fixed @yafimvo 's review comments. On point 1 , it was a miss from my end. I forgot to remove the image save logic, I was just using it for testing purpose. Have removed the logic now. If the docs look okay this is ready

Nice job!

the docs are still missing. I see there is a reference to user_guide/clustering_evaluation but the notebook isn't there. also, the new plots do not appear on the plots list in the docs.

He's talking about the readthedocs

I'm able to see it when I build the docs in my local:
i think it will be visible if this PR is merged?


Change agent's ssl upload behavior according to the configuration

At present the agent uploads the ssl metadata to the controller, however a user may want to opt out of sending this sensitive information to the controller.
The agent can use the agent configuration flag: nginx-ssl-config to decide if the agent is allowed to send the ssl information.

This is a feature request as we haven't implemented it just yet. We had it on our backlog to do


[Bug] Clicking a measurement in measurement tracking panel during read-only mode should NOT navigate

Describe the Bug
While tracking one or more measurements AND then loading a previous measurement tracking report in read-only mode, clicking the various tracked measurements in the measurements side panel should NOT navigate to those measurements and/or images.
Steps to Reproduce

Open any study. Let's call it study A
Create any measurement and label it "measurement 1" and opt to track measurements when prompted.
In the side panel click 'Create Report' to save it as dicom SR. Let's call it, "report 1"
Return to the study list.
Open study A again
Create any measurement and label it "measurement 2" and opt to track measurements when prompted.
Load the previously saved SR, "report 1". Note that measurement tracking enters "read-only" mode.
In the measurements side panel, Click "measurement 1".

https://github.com/OHIF/Viewers/assets/109477394/5c80d8b9-1875-48cf-8efc-5a3f0b991f67
The current behavior
The viewer navigates to the first image of the stack.
The expected behavior
No navigation should occur
OS
Windows 11
Node version
16.14.0
Browser
Chrome 114.0.5735.134

This might be a little tricky to fix correctly and perhaps a bit of time might be needed to properly define what is expected when a markup in the side panel is clicked when the active viewport is in read-only mode.
https://github.com/OHIF/Viewers/assets/109477394/82dfbf3c-5ecd-4093-a81c-f05387d49e4e


NullPointerException when using in memory storage

I got this null pointer exception when publishing the Oxygen user's manual to HTML5 using in memory storage
 C:\Users\radu_coravu\Downloads\dita-ot-develop(2)\dita-ot-develop\src\main\plugins\org.dita.base\build.xml:29: The following error occurred while executing this line:
  C:\Users\radu_coravu\Downloads\dita-ot-develop(2)\dita-ot-develop\src\main\plugins\org.dita.base\build_preprocess.xml:266: java.lang.NullPointerException
at org.dita.dost.ant.types.JobSourceSet.getResults(JobSourceSet.java:65)
at org.dita.dost.ant.types.JobSourceSet.iterator(JobSourceSet.java:102)
at org.apache.tools.ant.types.resources.Resources$MyCollection$MyIterator.hasNext(Resources.java:108)
at java.util.Iterator.forEachRemaining(Unknown Source)

Probably https://github.com/dita-ot/dita-ot/blob/develop/src/main/java/org/dita/dost/ant/types/JobSourceSet.java#L65
} else if (f.src.getScheme().equals("file")) {

where getScheme() is null. @raducoravu could you add debug logging that will log f.src so I can see what the URL looks like. Whether it's a source file or some external reference.

@jelovirt I added logging, the entire "f.src" is null.

So I logged this:
               System.err.println("ORIG " + f.file);
            System.err.println("TEMP " + tempFile);
            System.err.println("Scheme " + f.src);

and I obtained:
  [pathconvert] ORIG topics\content_fusion_task_details-x2.dita
 [pathconvert] TEMP D:\git-projects\userguide-private\DITA\temp\html5\topics\content_fusion_task_details-x2.dita
 [pathconvert] Scheme null

There is a copy-to somewhere in the DITA Map:
     <topicref href="../topics/content_fusion_task_details.dita"
    copy-to="../topics/content_fusion_task_details-x2.dita"/>

Other than that, if I skip in the code over "f.src" which are null there is a speed improvement from 236 to 97 seconds.
But: in the [conref] stage none of the content references seem to be resolved. We are using conkeyrefs, no key scope and no branch filtering.
So I get lots of errors like:
[DOTX010E]: Unable to find target for conref="../reusables/topics/reusables-editing-documents.dita#remove-text-dlentry".

And I also get a lot of warning about the chunks we have:
[DOTX061W]: ID 'dcpp_how_to_style_the_indexterms' was used in topicref tag but did not reference a topic element. The href attribute on a topicref element should only reference topic level elements.
 [DOTX023W]: Unable to retrieve navtitle from target: 'Chunk216651295.dita#dcpp_how_to_style_the_indexterms'.

and all copy-to topics are not present.

Is your user manual the public one in GitHub? Which commit are you trying to build?

You can use the master branch here:
https://github.com/oxygenxml/userguide

Can't reproduce. I wonder if this is some Windows related bug.

The conref error messages were a bug, fixed by #3624

I confirm the conref problem seems to be fixed.
I get the NullPointerException also on Mac when running:
  sh dita -i ../../../../userguide-master/DITA/UserManual.ditamap -f html5 -filter ../../../../userguide-master/DITA/ditaval/editor-sa.ditaval --store-type=memory -d -v

So what I do on Mac is:

Download the entire source code as a zip: https://github.com/dita-ot/dita-ot
Run "gradlew" in the dita-ot folder
Download the Oxygen userguide DITA content as a zip from: https://github.com/oxygenxml/userguide
Run the command line specified above.

The NPE stack trace is not visible in the command line, I can see the stack trace if I run the publishing from Oxygen which delegates directly to the ANT code.

One other thing I noticed, without any memory or parallel processing improvement, publishing the Oxygen user guide with Java 15 is slowed than publishing with Java 1.8 (6 minutes as opposed to 4 minutes).

Ok, was able to reproduce because I didn't know you needed to use a filter.

@jelovirt I confirm the null pointer exception can no longer be reproduced with your code , thanks.
I still get lots of warnings like this with the storage-type set to "memory":
[move-meta] Processing file:/Users/raducoravu/Downloads/userguide-master/DITA/temp/html5/UserManual.ditamap
[move-meta] Warning at char 9 in xsl:sequence/@select on line 60 column 69 of mappullImpl.xsl:
[move-meta]   FODC0002: I/O error reported by XML parser processing
[move-meta]   file:/Users/raducoravu/Downloads/userguide-master/DITA/temp/html5/Chunk395390874.dita:
[move-meta]   /Users/raducoravu/Downloads/userguide-master/DITA/temp/html5/Chunk395390874.dita (No such
[move-meta]   file or directory)
[move-meta] file:/Users/raducoravu/Downloads/userguide-master/DITA/maps/chapter-configure-application.ditamap:48:70: [DOTX061W][WARN]: ID 'set-parameter-in-startup-script' was used in topicref tag but did not reference a topic element. The href attribute on a topicref element should only reference topic level elements.
 [move-meta] file:/Users/raducoravu/Downloads/userguide-master/DITA/maps/chapter-configure-application.ditamap:48:70: [DOTX023W][WARN]: Unable to retrieve navtitle from target: 'Chunk395390874.dita#set-parameter-in-startup-script'.

and there are no such errors when publishing with "file" storage.
Should I open a new issue about these problems? Or make the subject of this issue more generic?

I confirm the latest fix removes the warnings reported in the move-meta stage.
Unfortunately publishing to HTML using that command line and steps specified above I still get 41 extra errors that I do not get with storage-type=file.
I'm attaching a zip with an HTML table containing all the extra problems. None of the problems appears using storage-type=file:
problems.html.zip

The remaining issues should be reported in new issue.


Probabilities not working on trained model

when I use zuphilip's branch on OCR with pre-trained model, it will report error, see following. How can I fix that? @zuphilip
Traceback (most recent call last):
  File "./ocropus-rpred", line 253, in safe_process1
    return process1(arg)
  File "./ocropus-rpred", line 148, in process1
    pred = network.predictString(line)
  File "/root/Michael/ocropy/ocrolib/lstm.py", line 926, in predictString
    cs = self.predictSequence(xs)
  File "/root/Michael/ocropy/ocrolib/lstm.py", line 876, in predictSequence
    self.outputs = array(self.lstm.forward(xs))
  File "/root/Michael/ocropy/ocrolib/lstm.py", line 587, in forward
    xs = net.forward(xs)
  File "/root/Michael/ocropy/ocrolib/lstm.py", line 636, in forward
    outputs = [net.forward(xs) for net in self.nets]
  File "/root/Michael/ocropy/ocrolib/lstm.py", line 537, in forward
    if n>N: raise ocrolib.RecognitionError("input too large for LSTM model")
RecognitionError: input too large for LSTM model

Do you have more details here? It doesn't look that this is related to the new function translate_back_with_probabilities which would be on the lines 756-772. Actually, the error report points to line 537 but the raise would be in line 551. Which branch are you using?
(BTW If this issue is not anymore relevant for you, we can also close the issue.)

There's not enough information in here. @1a1a11a Please try again with #135 and open a new issue if you encounter problems.


runserver is not stable with 0.5.0

I switched to 0.5.0 and in my daily work I see simple changes in the markdown trigger issues that the type is not found anymore for a page.
For example the simple addition of an image include triggered this:
[I 240222 09:01:28 handlers:92] Reload 2 waiters: content/coaching/example.md
Parsing TOML failed:  Duplicate keys! (line 4 column 1 char 140)
Gathered 37 tasks
Task exception was never retrieved
future: <Task finished name='Task-176' coro=<build_development() done, defined at /Users/okandler/.pyenv/versions/3.10.4/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/blurry/__init__.py:229> exception=ValueError('Required @type value missing in file or TOML front matter invalid: coaching/example.md')>
Traceback (most recent call last):
  File "/Users/okandler/.pyenv/versions/3.10.4/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/blurry/__init__.py", line 230, in build_development
    await build(release=False)
  File "/Users/okandler/.pyenv/versions/3.10.4/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/blurry/__init__.py", line 219, in build
    await asyncio.gather(*markdown_tasks)
  File "/Users/okandler/.pyenv/versions/3.10.4/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/blurry/__init__.py", line 109, in write_html_file
    raise ValueError(
ValueError: Required @type value missing in file or TOML front matter invalid: coaching/example.md
/Users/okandler/.pyenv/versions/3.10.4/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/asyncio/base_events.py:1881: RuntimeWarning: coroutine 'write_sitemap_file' was never awaited
  handle = self._ready.popleft()
RuntimeWarning: Enable tracemalloc to get the object allocation traceback
/Users/okandler/.pyenv/versions/3.10.4/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/asyncio/base_events.py:1881: RuntimeWarning: coroutine 'process_non_markdown_file' was never awaited
  handle = self._ready.popleft()
RuntimeWarning: Enable tracemalloc to get the object allocation traceback

I see this also with other changes in the text.

I also just saw this behavior, when simply replacing two sentences with a slightly different version. (Copy paste form another app)
[I 240222 10:00:01 handlers:135] Browser Connected: http://localhost:8000/coaching/example/
[E 240222 10:00:02 web:1875] Uncaught exception GET /assets/images/foo-20240222.png (<IP_ADDRESS>)
    HTTPServerRequest(protocol='http', host='localhost:8000', method='GET', uri='/assets/images/foo-20240222.png', version='HTTP/1.1', remote_ip='<IP_ADDRESS>')
    Traceback (most recent call last):
      File "/Users/okandler/.pyenv/versions/3.10.4/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/tornado/web.py", line 1790, in _execute
        result = await result
      File "/Users/okandler/.pyenv/versions/3.10.4/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/tornado/web.py", line 2760, in get
        await self.flush()
      File "/Users/okandler/.pyenv/versions/3.10.4/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/tornado/web.py", line 1183, in flush
        return self.request.connection.write(chunk)
      File "/Users/okandler/.pyenv/versions/3.10.4/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/tornado/http1connection.py", line 502, in write
        self._pending_write = self.stream.write(self._format_chunk(chunk))
      File "/Users/okandler/.pyenv/versions/3.10.4/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/tornado/http1connection.py", line 478, in _format_chunk
        raise httputil.HTTPOutputError(
    tornado.httputil.HTTPOutputError: Tried to write more data than Content-Length
[E 240222 10:00:02 web:1278] Cannot send error response after headers written
[I 240222 10:00:02 handlers:135] Browser Connected: http://localhost:8000/coaching/#fn-2

Hmm! That does look bothersome. I'm not able to reproduce that issue on my machine by running blurry runserver and making changes to Markdown or template files. What OS are you using? I'm using Python 3.11, which is one difference

I took another look at this and in the first example there's a TOML parsing error:
Parsing TOML failed:  Duplicate keys! (line 4 column 1 char 140)

Are you still having any issues? If so I'll reopen this issue


uv run --script should imply --no-project

I'm running into a variation of https://github.com/astral-sh/uv/issues/8666
I have some uv scripts that are just generic command line tools, not part of a project.
I'm using the --script shebang:
#!/usr/bin/env uv --script
I realize that I can add --no-project to it, but really, I think once you're using --script there's a good argument to be made that uv should assume --no-project

We should just stop throwing that error so aggressively. I don't want --script to imply --no-project in case we want to read things like settings from the project too in the future.

I actually can't reproduce this. Are you still able to? I don't think we discover projects when --script is provided, from reading the code.

Agreed, could not reproduce.

I no longer see this either.


[fix] [broker] Producer is blocked on creation because backlog exceeded on topic, when dedup is enabled and no producer is there

Motivation
As per backlog quota logic, Producer is blocked on creation  when

backlog exceeded on topic
dedup is enabled
no producer is there.

Especially, producer creation is indefinitely blocked when there brokerDeduplicationEnabled=false(default=false), which disables periodic dedup map snapshots every 2mins.
When checking backlog size, the logic computes the backlog size against the slowest consumer on the topic. Unfortunately, the dedup system consumer(for the dedup map recovery) is usually behind the latest position -- the broker takes deup recovery map snapshot every 1000 entry(by default, brokerDeduplicationEntriesInterval) or every 2 mins(by default) when brokerDeduplicationEnabled is enabled(default is false), so before the next snapshot cycle, the dedup system consumer's MarkDeletePos is usually behind, and this can hold backlog more than the quota. As a result, the dedup-enabled topic could show more backlog size and block produce creations, especially when there is no producer and the time-based dedup-map snapshot is disabled, although all of the actual consumers' MarkDeletePos are up-to-date.
Modifications

Add advanceSlowestMessageDeduplicationCursor in the backlogQuotaCheck failure handler to advance the Slowest MessageDeduplication Cursor when the backlog quota exceeds the threshold.
Verifying this change
# local repro steps
bin/pulsar-admin tenants create my-tenant
bin/pulsar-admin namespaces create my-tenant/my-namespace-3 --bundles 5
bin/pulsar-admin namespaces set-backlog-quota my-tenant/my-namespace-3 -l 1K -p producer_request_hold
bin/pulsar-admin namespaces set-deduplication my-tenant/my-namespace-3 --enable

# on another console
bin/pulsar-client consume -s sub-read persistent://my-tenant/my-namespace-3/my-topic -p Earliest -n 0 --hide-content

# on another console, try multiple times until hit
bin/pulsar-perf produce persistent://my-tenant/my-namespace-3/my-topic -r 100 -bm 1 -mk random -n 1

[x] Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:
Added the unit test to cover this logic change.
Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository: https://github.com/heesung-sn/pulsar/pull/50

@heesung-sn Please rebase to the master branch to resolve the CI issue.

@heesung-sn Please rebase to the master branch to resolve the CI issue.

Done

@heesung-sn Is there anything blocking your committer process? I realized you still don't have permission for the pulsar repo.

@heesung-sn Is there anything blocking your committer process? I realized you still don't have permission for the pulsar repo.

I got the permission now. I merged this PR.


Support objects in terms include / exclude.

See issue #4093.
It wasn't clear from the contributing guide how to handle breaking changes, so initially just raising this PR against master to start the discussion.

After reading

The reasoning is that numeric types in Elasticsearch are optimized for range queries and a bit slower at exact queries than keyword fields.

https://discuss.elastic.co/t/matching-integers-in-an-array/96534/2
Closing and will work around this by re-indexing documents to use strings rather than ints.


Removed extra asterix.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Please don't make duplicate or tiny pull requests. Please delete any previous pull requests(#19877, #26711, #26719, #27135, #19893).

Quality Standards
In line with Hacktoberfest value #2 (Quantity is fun, Quality is key), we have provided examples of the quality standards we encourage. This applies mainly to beginners.

PRs that are automated e.g. scripted opening PRs to remove white space / optimize images.
PRs that are disruptive e.g. taking someone else's branch/commits and making a PR.
PRs that are regarded by a project maintainer as a hindrance vs. helping.
Something that's clearly an attempt to simply +1 your PR count for October.

Closed and Reopened this PR to attempt to resolve a specific Travis build failure.


Tight coupling between the Pointer and Provider

I'm not sure if I've read the examples right, but it appears that there may be a tight coupling between the Pointer variable and the Provider. When creating a definition in a graph, it always asks for a Pointer and a Provider. And I can't reuse this definition for a different instance of the same pointer type.
What is the pattern for creating multiple instances of the service, each with its own instance of dependency? Do I need to create a new Definition for every instantiation of Service/ Dependency in code?

Yes. Each Definition is only constructed once, because each Pointer can only hold one object. If you want two copies of Thing then you can use NewThing as the Provider for both, but you need two Pointers to put the two objects in once they’ve been created.

Pardon my questions, but I'm trying to understand the constraints ...
Is there a way to get a Singleton instance of a dependency if I don't have the variable that was passed in the definition?

Not easily, no.
The idea is that instead of hardcoding the name of the object as a string (which is equivalent to a “magic number” or enum) you reference the object with a pointer variable which you can then inject into objects that need it using the same construction mechanism. This guarantees type safety at compile time, makes refactoring trivial, and allows usage tracing, increasing maintenanability and reducing “magic”.

FWIW, you CAN introspect the graph of objects, but if you don’t have the unique identifier (the pointer) you can only do thinks like get the list of definitions that match or satisfy a specific type.


Compute result

Work on #457. I am not adding the closing keyword yet, since the PR now contains a specific provider version in barge instructions, which should be removed after we merge the computeResult stuff into the main provider.

Updated for transparency: running this with a local provider from main branch, everything works perfectly. However, it does not work with the provider from barge. I have no explanation for this. I asked for @alexcos20 to help me out a bit.

Status: works with the latest provider version on barge, but waiting for Provider release of 0.4.16, which in turn depends on ocean-contracts 0.6.6. Will update and re-request review after dependencies are solved.


Update email-activity.md

Add the licensing requirement information to the report

@kwekuako - PR is ready for final review. Thank you.

@Divya-RP I don't understand the note you added. You said it's licensing requirement information, but the note says the email activity report is available for licensed user mailbox. How is that a requirement? Can you explain why this note is needed?

Hell0 Cern,
The article does not talk about the license requirement. The email activity report is available only for mailboxes which have licenses.
Example: Shared mailbox does not have license, the email activity report is not available for the shared mailbox
Regards,
Divya
From: Cern McAtee<EMAIL_ADDRESS>Sent: Wednesday, July 17, 2019 12:38 AM
To: MicrosoftDocs/OfficeDocs-O365ITPro<EMAIL_ADDRESS>Cc: Divya R P<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/OfficeDocs-O365ITPro] Update email-activity.md (#608)
@Divya-RPhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FDivya-RP&data=02|01|divyarp%40microsoft.com|3a54380fc6d84ef2ae8c08d70a20f45d|72f988bf86f141af91ab2d7cd011db47|1|0|636989008960245868&sdata=oPZkuhr1H5GOUPVq%2BSrM9apzjnTJeVMSupoVRJuafrM%3D&reserved=0 I don't understand the note you added. You said it's licensing requirement information, but the note says the email activity report is available for licensed user mailbox. How is that a requirement? Can you explain why this note is needed?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FOfficeDocs-O365ITPro%2Fpull%2F608%3Femail_source%3Dnotifications%26email_token%3DAKXHUJ5HOCDAIZSMPX5XNYLP7YMB5A5CNFSM4H5XUPA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2B25GI%23issuecomment-511946393&data=02|01|divyarp%40microsoft.com|3a54380fc6d84ef2ae8c08d70a20f45d|72f988bf86f141af91ab2d7cd011db47|1|0|636989008960255863&sdata=m8thZ8614sXlUAYTjFsudpYHyj4cEWmseeQc3WvOLo0%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKXHUJ26GJ4HWXMR46CT2IDP7YMB5ANCNFSM4H5XUPAQ&data=02|01|divyarp%40microsoft.com|3a54380fc6d84ef2ae8c08d70a20f45d|72f988bf86f141af91ab2d7cd011db47|1|0|636989008960255863&sdata=Yvif3lvjwFR44GkiqQMAP3kT19ImM7n77MzGWi%2F4vQk%3D&reserved=0.

@Divya-RP - We would like to follow up. Kindly merge the commit on this PR as suggested. Thank you.

Hello Joyce,
I have committed the changes. Please let me know if anything else to be done.
Regards,
Divya
From: Joyce Y<EMAIL_ADDRESS>Sent: Tuesday, July 23, 2019 6:10 PM
To: MicrosoftDocs/OfficeDocs-O365ITPro<EMAIL_ADDRESS>Cc: Divya R P<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/OfficeDocs-O365ITPro] Update email-activity.md (#608)
@Divya-RPhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FDivya-RP&data=02|01|divyarp%40microsoft.com|d5d88e2e848f4568398308d70f6aee98|72f988bf86f141af91ab2d7cd011db47|1|0|636994824253811540&sdata=OikMr8cs0zPQXfcvh3gOJMEVCeM1fH8y6RcdO1d7x1I%3D&reserved=0 - We would like to follow up. Kindly merge the commit on this PR as suggested. Thank you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FOfficeDocs-O365ITPro%2Fpull%2F608%3Femail_source%3Dnotifications%26email_token%3DAKXHUJYZWXYJPO46WMBM5GTQA333PA5CNFSM4H5XUPA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2S7G6I%23issuecomment-514192249&data=02|01|divyarp%40microsoft.com|d5d88e2e848f4568398308d70f6aee98|72f988bf86f141af91ab2d7cd011db47|1|0|636994824253821538&sdata=TM%2BqVhXQpO8VeyXBSQsFU7hxY34cbZmXJ5plPc8j4vg%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKXHUJ4BMN256QZVWCH6VZTQA333PANCNFSM4H5XUPAQ&data=02|01|divyarp%40microsoft.com|d5d88e2e848f4568398308d70f6aee98|72f988bf86f141af91ab2d7cd011db47|1|0|636994824253831532&sdata=rv00gKWemqzQqQT%2BzRa5XPF6sPS9RaimOppDnf5j6%2FE%3D&reserved=0.

@cmcatee-MSFT - Your recommended change has been applied and PR is now ready for your final review. Please assist to merge the PR content. Thank you.


Last edit broke something?

When I run a freshly cloned version of this program to train connect4, all graphs in the Total_reward-section of tensorboard become flat lines (Total reward=10, Mean value=0, Episode length=11, MuZero reward=0, Opponent reward=0). The graphs in all of the other sections look ok I think. I get this result both locally and in Google colab.
It worked before https://github.com/werner-duvaud/muzero-general/commit/91afb1d7b77f5c9382ac3651d9d139cded895a63 so maybe something broke there?

Hi,
Thanks for reporting. It should be fixed now.


The current row is not updated till we save

e-ng-change($data,currentRow) in this on change event i want the value of different fields in current row. m getting the current data but since the currentRow is not bind at the moment i get undefined. but i want to do validation of 1 select field depending on other select field. How to do that?
Thanks for speedy reply, u already solved 2 of my issues :+1:

I think the only thing you can currently do is some form of onbeforesave/onaftersave.  See the documentation

Then after every row the user has to save according to my current requirement. Guess have to make use of normal select box and table for this.

Yeah, I don't think there is any other way to do it right now and I think I've seen other issues opened with similar problems.


Import interpolation for loc/rot/scale from GLTF

Currently all transform animation tracks get imported as linear.

To support things like camera cuts honor the interpolation mode set in the gltf.

Note that GLTF cubic is not the same as godot cubic.
	} else if (gltf_interp == GLTFAnimation::INTERP_CUBIC_SPLINE) {
		return Animation::InterpolationType::INTERPOLATION_CUBIC;
	} else {
		return Animation::InterpolationType::INTERPOLATION_CUBIC;

Thanks a lot for taking a look - I should have been clearer, this is only about the STEP/NEAREST interpolation.
The method already does handle baking.
For STEP interpolation we do not want any in-betweens generated, so we have to mark the resulting animation track with NEAREST interpolation, the other tracks will get baked correctly.
I've made the change handle only the STEP case, wdyt?

If you have some spare time, could check https://github.com/KhronosGroup/glTF-Sample-Models/tree/master/2.0/InterpolationTest

I think the change is working as it should. The existing code bakes everything to linear, so the only time we need to propagate the original interpolation intent is when it's STEP/NEAREST.

Thanks! And congrats for your first merged Godot contribution :tada:

Thank you


[Bug] Express, Entry List Block, search by keywords always "on"

This is happening in v8.1.0
When I have "Search by Keywords" unchecked, the ability to search by keywords still is available. Enabling it seems to change nothing. It would be nice to be able to disable it as one would expect.

This is not how that works.
Search by Keywords simply means that an attribute's content is included in the search index. If you want to completely remove the ability to search by keywords from the front-end you'll need to implement a custom template for the block.

So, when configuring the block, if you uncheck search by keyword, why even have the field "search by keyword" still be available on the page? It's just confusing from a usability perspective.

Ah, I see; you're referring to the block not the attribute checkbox. Yeah, that would make sense to remove.

Not sure at what point but this has since been fixed (just verified in version 9.)

Yay thanks for the update! @aembler


fix: revised Apple logo design

No, it doesn't seem you know what this repository is about... before doing some pull requests, look at all the existing icons, the issues and open an issue if you don't seem to find what you need, but the apple icon is actually acurate


Setup and cleanup triggers for session-scoped providers

Session-scoped providers are instanciated the first time the provider is consumed. Yet in some cases, it can be useful to trigger their instanciation manually.
In the case of Bocadillo, app-scoped ingredients need to be instanciated on app startup, and cleaned up (if need be) on app shutdown.
Ideally, we'd need to be able to write something like:
app.on("startup", ingredients.init)
app.on("teardown", ingredients.cleanup)

Blocked by #5

Fixed by #10


small cleanups

IIRC, we used to reload the mapping file in the dispatcher, and for that we needed a register_mapping_consumers. Now the dispatcher gets the updated mapping from the file manager at every read, so there is no need for mapping_consumers.

Codecov Report

Merging #2062 (5bcec24) into main (5374885) will increase coverage by 0.00%.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             main    #2062   +/-   ##
=======================================
  Coverage   64.34%   64.35%
=======================================
  Files         131      131
  Lines       15584    15577    -7
=======================================
- Hits        10028    10024    -4
+ Misses       5556     5553    -3

Impacted Files
Coverage Δ

src/irmin-pack/unix/ext.ml
66.47% <0.00%> (-0.19%)
:arrow_down:

src/irmin-pack/unix/file_manager.ml
83.90% <100.00%> (+1.23%)
:arrow_up:

src/irmin-test/store.ml
94.82% <0.00%> (-0.06%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Update to stable chokidar.

That's it. It is much more stable.

Thanks for this.
Will this fix https://github.com/paulmillr/chokidar/issues/258 ?
I didn't take some time to reproduce that sorry :)

@MoOx we've made some improvements to unwatch in 1.0.1 — maybe. I'll test it on my machine.

Awesome.
Patch released as 1.2.2 :)

Thanks !


New Device: Delta Pro Ultra

Device
Delta Pro Ultra
Characteristics

Service
Characteristic
Standard
Permission

Battery
BatteryLevel
✅
Read

Battery
ChargingState
✅
Read

Battery
StatusLowBattery
✅
Read

Outlet AC
On
✅
Read/Write

Outlet AC
OutletInUse
✅
Read

Outlet AC
Battery Level, %
🔲
Read

Outlet AC
Input Consumption, W
🔲
Read

Outlet AC
Output Consumption, W
🔲
Read

Outlet USB
On
✅
Read/Write

Outlet USB
OutletInUse
✅
Read

Outlet USB
Battery Level, %
🔲
Read

Outlet USB
Input Consumption, W
🔲
Read

Outlet USB
Output Consumption, W
🔲
Read

Switch X-Boost
On
✅
Read/Write

Are you ready to test beta version of plugin with added device support?
🔴 No (please explain in the 'More Information' box below)
More Information
Have no device to test on. Can test only in Simulate mode

I'm more than happy to help test this with a live device when ready!

I'm more than happy to help test this with a live device when ready!

Thank you.
I've released v1.4.0-beta.0 with Delta Pro Ultra support. The only limitations for now are:

Outlet AC On is not read or wtitten from/to device (no description of API for that here)
Switch X-Boost On is no read from device, but you can write it


Production builds should not contain source maps

Currently source maps are generated for development builds as well as for production builds. I think it would be better not to generate source maps in a production build by default.
Setting the devtool option in build/webpack/development.js instead of build/webpack/_base.js should fix this.
What do you think?

Very much agree, was actually just thinking about that the other day. I'll make the changer later tonight/tomorrow unless you'd like to submit a PR for it before then.
Thanks!


Add Context - Commit History

Validations

[X] I believe this is a way to improve. I'll try to join the Continue Discord for questions
[X] I'm not able to find an open issue that requests the same enhancement

Problem
It would be nice to be able to ask something based on previous commits.

do the same changes as @lastCommit, but for euros instead of dollars

And add the possibility to target a commit via a branch name / commit id / commit range.
Solution
No response

This is a cool idea! While we may not immediately prioritize this, I think it is a great area for contribution. So if anyone comes across this, some further details on what I think would be a pretty straightforward PR:

See the CONTRIBUTING.md: https://github.com/continuedev/continue/blob/main/CONTRIBUTING.md#writing-context-providers
In order to give the possibility of selecting a target commit, I think a "submenu" type context provider would be best
And then it should be fairly straightforward to call git with subprocess

@sestinj good to hear about this feature , that would be a lovely integration , would you like to assign me this issue

@Anonymous-RD
Absolutely!

Thankyou for assigning me this issue i got gist what to add but where should i ask for the previous commits to get some deeper knowledge , so that i can work in this issue smoothly

This seems pretty stale, I'm gonna post a PR for this if thats alright.