Fix typo:  INSTANCE-PROFILE -> $INSTANCE_PROFILE"

Fixes:
 AWS-CLI Profile: [INSTANCE-PROFILE] AWS API Region: [us-east-1] AWS Filter Region: [all]

and
 7.3 [extra73] Ensure there are no S3 buckets open to the Everyone or Any AWS user (Not Scored) (Not part of CIS benchmark)
       INFO! Looking for open S3 Buckets (ACLs and Policies) in all regions...

The config profile (INSTANCE-PROFILE) could not be found

 7.4 [extra74] Ensure there are no Security Groups without ingress filtering being used (Not Scored) (Not part of CIS benchmark)

Becomes correct:
 AWS-CLI Profile: [local-credentials] AWS API Region: [us-east-1] AWS Filter Region: [all]

couldnt you use aws sts get-caller-identity to determine if its a role/etc and have it work across local and ec2?

From an instance with an IAM role:
[marc@ip-10-0-3-7 ~]$ aws sts get-caller-identity
{
    "UserId": "AROAJH7TPQRIN3ZDTZ3EC:i-####",
    "Arn": "arn:aws:sts::redact:assumed-role/Vault/i-####",
    "Account": "..."
}

Locally using an assumed role (via metadata proxy):
$ aws sts get-caller-identity
{
    "UserId": "AROAJIPXI2UAQHOYRVMM2:1527870906355210886",
    "Account": "...",
    "Arn": "arn:aws:sts::...:assumed-role/ops/1527870906355210886"
}

Locally using access creds:
$ aws-vault exec work -- aws sts get-caller-identity
{
    "UserId": "AIDAI5347JMWD7###",
    "Account": "...",
    "Arn": "arn:aws:iam::...:user/marc"
}

Btw, I forgot to mention that caller identity is already in the header:
                          _
  _ __  _ __ _____      _| | ___ _ __
 | '_ \| '__/ _ \ \ /\ / / |/ _ \ '__|
 | |_) | | | (_) \ V  V /| |  __/ |
 | .__/|_|  \___/ \_/\_/ |_|\___|_|v2.0-beta2
 |_| the handy cloud security tool

 Date: Fri Jun  1 15:00:14 EDT 2018

 Colors code for results:
 INFO (Information), PASS (Recommended value),  FAIL (Fix required),  Not Scored

 This report is being generated using credentials below:

 AWS-CLI Profile: [INSTANCE-PROFILE] AWS API Region: [us-east-1] AWS Filter Region: [all]

 Caller Identity:
---------------------------------------------------------------------------------
|                               GetCallerIdentity                               |
+--------------+--------------------------------------+-------------------------+
|    Account   |                 Arn                  |         UserId          |
+--------------+--------------------------------------+-------------------------+
|  123456789 |  arn:aws:iam::123456789:assumed-role/AuditInstanceProfile/i-123456789  |  AIDAI3KD5JASDFASDFASD  |
+--------------+--------------------------------------+-------------------------+


TOC seems not well split

At end of TOC, in my case two <li class="toc-entry"> nodes, are not showing.
Sorry but I couldn't manage to reduce the problem to a test case. I guess that css must be part of the problem.
I could solve my "complex" case by not including in the TOC the single root level that I had (TOME I).

Could you please post a sample document that reproduces this issue and/or a screenshot?

Just to show that I am not kidding ;-)

The two element-zones are overlaping (one line is lost here):


Test improvements

Fixes #2.
Changes in PR:

Adds a test-languages folder
Has a python file test
Improve main usage tests (can be removed later when Java tests are added)

Goals:

[x] Add test-languages folder
[x] Add Python mapping test file
[ ] Add Java mapping test file

I used this Java samples page to make the mapping, maybe I can cannibalize it to get everything? I don't care or even know enough about Java to make a really good mapping, I just happened to be able to find some good info to make a mapping from

With a bit of Chat GPT you too can make a Java test file that you have no idea is comprehensive or not but trust is


MariaDB version is not recognized under Performance

PHP Version
No response
Shopware Version
6.5
Plugin Version
1.3.3
Actual behaviour
MariaDB version is not recognized correctly under Performance.
The version is recognized correctly under System Status.
MariaDB is officially recommended by Shopware:
https://docs.shopware.com/en/shopware-6-en/first-steps/system-requirements#environment

Expected behaviour
Recognize MariaDB version and do not issue an error/warning.
Steps to Reproduce?
Nothing.

see https://developer.shopware.com/docs/guides/hosting/performance/performance-tweaks.html#mysql-instead-of-mariadb

Then a warning instead of an error.
And only the MariaDB version, as with System Status.


hash '__CARGO_DEFAULT_LIB_METADATA' in metadata for rustc

We already have __CARGO_DEFAULT_LIB_METADATA to force adding the hash of some metadata in the libraries file name when building rust.
For now, we only check if it is set or not.
This patch makes also use of its value to compute the hash. This way we'll be able to pass in the channel we're building to avoid hash collisions between channels.

r? @alexcrichton
(rust_highfive has picked a reviewer for you, use r? to override)

@bors: r+
Seems reasonable to me!

:pushpin: Commit dc8d5d3 has been approved by alexcrichton

:hourglass: Testing commit dc8d5d38d5dd958aec58ba5f8775a5fe5c75f9ea with merge d2d6e675fcb70cfb91c2cf2fad8cdd345c120316...

:sunny: Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing d2d6e675fcb70cfb91c2cf2fad8cdd345c120316 to master...

Any chance to get this backported in beta?

Sure yeah seems fine by me, want to send a PR?


As the system, I can Categorize occupations

[x] create role class
[x] good work adding getter/setter for name, try getter/setter with other attributes: description, num_employed, mean_hourly_wage, etc.)
[x] finish data structure for mapping (see below comment with 9 attributes below)
[x] #13
[x] #14

Role class possible attributes:
field_of_work: string[] (govt, trade, business, entertainment)
services_provided: string[]
level_of_income: string
essential: string (maybe?? essential, partially essential, non essential)
Other possible attributes from BLS:
Employment
EmploymentRSE
Mean hourlywage
Mean annualwage
Wage RSE

@jpoulsenjr - Here's the example data structure for the following attributes to add:
(<category>, (<values,>), (<keys,>)
So as an example, another program could use the setter with this data:
('Employment Services', (572290, 16.41, 15.10, 31410), ('employment', 'percent_of_industry_employment', 'hourly_mean_wage', 'hourly_mean_wage', 'annual_mean_wage'))
Important: Keep in mind, the amount of keys/columns, will vary between attributes, and we can create classes for them in the future to ensure data quality, but for this version the getters and setters below should be fine.
An example setter might look like this:
# x === <category>, y === (<values,>), z === (<keys,>)
def set_percentile_90(self, x, y, z):
        self.__percentile_90 = (x, y, z)

For the following attributes:

[ ] industry_highest_level_employment
[ ] industry_highest_concentration_employment
[ ] industry_top_paying_industries
[ ] state_highest_level_employment
[ ] state_highest_concentration_employment
[ ] state_top_paying
[ ] metropolitan_highest_level_employment
[ ] metropolitan_highest_concentration_employment
[ ] metropolitan_top_paying
[ ] non_metropolitan_highest_level_employment
[ ] non_metropolitan_highest_concentration_employment
[ ] non_metropolitan_top_paying

@jpoulsenjr - remember to click the tasks that are done, I took the other two an made them enhancements. Close the task when you are done.

Nevermind, you clicked on my computer, so I'll close this. Nice work!


ref callback not (correctly) working for Form.Control (missing attributes)

Taking this official example from React Bootstrap and giving the first Form.Control a ref callback:
import React from 'react';
import Button from 'react-bootstrap/Button';
import Form from 'react-bootstrap/Form';

export function App(props) {
  return (
    <Form>
      <Form.Group className='mb-3' controlId='formBasicEmail'>
        <Form.Label>Email address</Form.Label>
        <Form.Control
          type='email'
          placeholder='Enter email'
          ref={el => {
            console.log('type', el.type); // logs "email"
          }}
        />
        <Form.Text className='text-muted'>
          We'll never share your email with anyone else.
        </Form.Text>
      </Form.Group>

      <Form.Group className='mb-3' controlId='formBasicPassword'>
        <Form.Label>Password</Form.Label>
        <Form.Control type='password' placeholder='Password' />
      </Form.Group>

      <Form.Group className='mb-3' controlId='formBasicCheckbox'>
        <Form.Check type='checkbox' label='Check me out' />
      </Form.Group>

      <Button variant='primary' type='submit'>
        Submit
      </Button>
    </Form>
  );
}

Doing the same for the official example from Solid-Bootstrap:
import { render } from 'solid-js/web';
import { Button, Form } from 'solid-bootstrap';

export function App(props) {
  return (
    <Form>
      <Form.Group class='mb-3' controlId='formBasicEmail'>
        <Form.Label>Email address</Form.Label>
        <Form.Control
          type='email'
          placeholder='Enter email'
          ref={el => {
            console.log('type', el.type); // logs "text"
          }}
        />
        <Form.Text class='text-muted'>
          We'll never share your email with anyone else.
        </Form.Text>
      </Form.Group>

      <Form.Group class='mb-3' controlId='formBasicPassword'>
        <Form.Label>Password</Form.Label>
        <Form.Control type='password' placeholder='Password' />
      </Form.Group>

      <Form.Group class='mb-3' controlId='formBasicCheckbox'>
        <Form.Check type='checkbox' label='Check me out' />
      </Form.Group>

      <Button variant='primary' type='submit'>
        Submit
      </Button>
    </Form>
  );
}

It seems as if the input has only default attributes when the callback is called.

Interesting.  However if you wait until the element is mounted then you get "Email" instead...
          ref={el => onMount(() => {
            console.log('type', el.type); // logs "email"
          })}

Seems to be just how Solid's Dynamic component works - which is used internally here to support the "as" property.
Example in Playground
Closing this as not much we can do about that.

It's actually not a problem of Dynamic but of forwarding refs in general. I opened solidjs/solid#2005.


Speedseq align stops at sambamba sort

Does speedseq work with non-human genomes?
I'm trying it out with a fish genome and the programme seems to stop running at the sambamba sort step. I have given it over 24h and it does not go further than this step. Any ideas as to what I am doing wrong? Any suggestions would be great!
speedseq align -M 50 -R "@RG\tID:id\tSM:samplename\tLB:lib" -o AG1 fishref.fna ag1F.fastq ag1R.fastq
sourcing executables from /users/speedseq/bin/speedseq.config ...
Aligning...
mkdir -p AG1.k1vuuiNaaBBx/full AG1.k1vuuiNaaBBx/spl AG1.k1vuuiNaaBBx/disc
mkfifo AG1.k1vuuiNaaBBx/spl_pipe AG1.k1vuuiNaaBBx/disc_pipe

/users/speedseq//bin/bwa mem -t 1  -R '@RG  ID:id   SM:samplename   LB:lib' /users/fish.fna  /users/ag1F.fastq /users/ag1R.fastq |
/users/speedseq//bin/samblaster --excludeDups --addMateTags --maxSplitCount 2 --minNonOverlap 20 --splitterFile AG1.k1vuuiNaaBBx/spl_pipe --discordantFile AG1.k1vuuiNaaBBx/disc_pipe | \ /users/speedseq//bin/sambamba view -S -f bam -l 0 /dev/stdin | \ /users/speedseq//bin/sambamba sort -t 1 -m 48G --tmpdir=AG1.k1vuuiNaaBBx/full -o AG1.bam /dev/stdin
gawk '{ if ($0~"^@") { print; next } else { $10=""; $11=""; print } }' OFS="  " AG1.k1vuuiNaaBBx/spl_pipe | \ /users/speedseq//bin/sambamba view -S -f bam -l 0 /dev/stdin | /users/speedseq//bin/sambamba sort -t 4 -m 1G --tmpdir=AG1.k1vuuiNaaBBx/spl -o AG1.splitters.bam /dev/stdin
gawk '{ if ($0~"^@") { print; next } else { $10=""; $11=""; print } }' OFS=" " AG1.k1vuuiNaaBBx/disc_pipe | \ /users/speedseq//bin/sambamba view -S -f bam /dev/stdin | /users/speedseq//bin/sambamba sort -t 4 -m 1G --tmpdir=AG1.k1vuuiNaaBBx/disc -o AG1.discordants.bam /dev/stdin

is your fasta file indexed?

Yes.. apologies I didn't paste the first step:
Warning: Reference file not indexed with BWA. Indexing now...
[bwa_index] Pack FASTA... 20.81 sec
[bwa_index] Construct BWT for the packed sequence...
[BWTIncCreate] textLength=4480409982, availableWord=327258216
[BWTIncConstructFromPacked] 10 iterations done. 99999998 characters processed.
[BWTIncConstructFromPacked] 20 iterations done. 199999998 characters processed.
[BWTIncConstructFromPacked] 30 iterations done. 299999998 characters processed.
[BWTIncConstructFromPacked] 40 iterations done. 399999998 characters processed.
[BWTIncConstructFromPacked] 50 iterations done. 499999998 characters processed.
[BWTIncConstructFromPacked] 60 iterations done. 599999998 characters processed.
[BWTIncConstructFromPacked] 70 iterations done. 699999998 characters processed.
etc etc etc
[bwt_gen] Finished constructing BWT in 516 iterations.
[bwa_index] 2046.35 seconds elapse.
[bwa_index] Update BWT... 17.66 sec
[bwa_index] Pack forward-only FASTA... 13.35 sec
[bwa_index] Construct SA from BWT and Occ... 674.77 sec
[main] Version: 0.7.10-r789
[main] CMD: /users/r01acb15/Downloads/speedseq//bin/bwa index fishref.fna
[main] Real time: 2786.876 sec; CPU: 2772.961 sec
Done

To answer your question, "speedseq align" ought to work on non-human genomes. Some downstream modules (like VEP variant annotation with the -A flag or CNVnator read-depth annotation) might have problems because they expect GRCh37 chromosomes.
Since you've given "-M 50", it's actually possible that speedseq is working, but it won't write temp output until the buffer hits 50 GB, so it might be computing. You're only using 1 thread, so it's going to take a long time. (Tests in the paper used -t 32).
To check whether your commands are setup properly, you might try a parallel run using "-M 3" and "-t 8" if you have more threads available. This should produce output in the temporary sambamba directory within a matter of minutes.


Allow option to specify RID for dotnet publish

Currently, RID is selected automatically from these: "win-x64", "linux-x64", "osx-x64", but they may might not be always correct for given scenario.
Because of that its not possible, for example, to produce binary for Linux while being on Windows.

RID seems to select both the runtime and the binary used, so it seems impossible to select Windows target while compiling on linux (docker-in-docker)


Update Decimal.js to the latest version

https://github.com/MikeMcl/decimal.js
The current version is 4.0.2.
The latest available is 5.0.7.
Here is a changelog of Decimal.js versions.
https://github.com/MikeMcl/decimal.js/blob/master/CHANGELOG.md
Actually, Decimal.js has been already updated to 5.0.7 in this commit (64bit_support branch):
https://github.com/bridgedotnet/Bridge/commit/05ea3b1f7999a97f873aa3eca5cab946d6eedccd
Just created an Issue as it is worth to have it logged individually.
The 64bit_support branch (the long support - #778) is going to be merged in v1.12.
Most likely, this is going to fix the issue with 15 digits limitation:
http://forums.bridge.net/forum/community/help/1308

Updated in #778


litte fix for the launcher

When building on OSX with the new qmlui, this fix enables the launcher to run the binary "qmlplus-qml" instead of "qlcplus"

Rejected. QLC+ 5 will have no launcher.
The Fixture Editor will be a separate bundle.
The script to edit is create-dmg.sh
If you have some patience I will make the change, but the macOS bundle is the last of my concerns right now

ok, no problem

@chrisderock 97d88b1354a10a811a9208fdb0bfb85b3ef66ce8
This should do:
create-dmg.sh CONFIG+=qmlui


More fixes

Changed Nimzo-Indian Defense, Romanishin Variation and Nimzo-Indian Defense, Romanishin Variation, English Hybrid from E21 -> E20
Changed Blackmar-Diemer Gambit, Declined, O'Kelly Defense and Blackmar-Diemer Gambit, Declined, Weinsbach Declination to D00. Also changed move order as in chesstempo
Queen Pawn Game, London System, Pterodactyl Variation to D02
Englund Gambit, Declined, Reversed French to A40. Also move order
A40 Queen's Pawn Game: Englund Gambit 1. d4 e5 2. dxe5 Nc6 3. Nf3 Qe7 4. Qd5 f6 5. exf6 Nxf6 already covered in Englund Gambit Complex, Stockholm Variation
Queen's Gambit Accepted, Rosenthal Variation D02 -> D21 . Also changed move order
Old Indian Defense, Tartakower-Indian A46->A54. Also changed move order

Thanks!


Updated links to GitHub Actions docs

Closes https://github.com/MicrosoftDocs/azure-docs/issues/67517
This PR updates the links to GitHub Actions docs for the following articles:

"Deploy to App Service using GitHub Actions": [Published article] - [Markdown source].
"Deploy a custom container to App Service using GitHub Actions": [Published article] - [Markdown source].
"Set up a GitHub Actions workflow to deploy your static website in Azure Storage": [Published article] - [Markdown source].
"Continuous delivery by using GitHub Action (Azure Functions)": [Published article] - [Markdown source].
"Deploy Azure Resource Manager templates with GitHub Actions": [Published article] - [Markdown source].
"Configure a GitHub action to create a container instance": [Published article] - [Markdown source].
"Use GitHub Actions to connect to Azure SQL Database": [Published article] - [Markdown source].
"Quickstart: Use GitHub Actions to connect to Azure MySQL": [Published article] - [Markdown source].
"Use GitHub Actions with Azure Machine Learning": [Published article] - [Markdown source].
"GitHub Actions for deploying to Kubernetes service": [Published article] - [Markdown source].
"Sync your GitHub repository to App Configuration": [Published article] - [Markdown source].

@martin389 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

👋  I'm working with @juliakm on this to address https://github.com/MicrosoftDocs/azure-docs/issues/67517

👋 I'm working with @juliakm on this to address #67517

Hi @martin389 - Thanks for the info. We did a spot check of the links in preview; they look good. We'll merge the PR.
-PR review team


Remove un-needed registerWith method from jni

Fixes #1204.
Tested with flutter run --debug in the jni example app with the changes in https://github.com/flutter/engine/pull/52022 applied.

[ ] I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

See our contributor guide for general expectations for PRs.
Larger or significant changes should be discussed in an issue before creating a PR.
Contributions to our repos should follow the Dart style guide and use dart format.
Most changes should add an entry to the changelog and may need to rev the pubspec package version.
Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

coverage: 91.215%. remained the same
when pulling 00c03f2a869d4d970a86da96711b9895210f7939 on gmackall:main
into ecb8b7eca32143348ce645d57eab3890e10b046f on dart-lang:main.


Vulkan: Using a lot of different materials spams error message

Godot version
v4.0.alpha.mono.custom_build [a647fb3e6]
System information
manjaro KDE
Issue description
I'm testing the game a lot, this needs to constantly and frequently open and close the game, but suddenly the engine freezes with the following message:
ERROR: Condition "!material" is true.                                                                       ✔
   at: material_update_dependency (servers/rendering/renderer_rd/renderer_storage_rd.cpp:462)
ERROR: Condition "!material" is true. Returning: true
   at: material_casts_shadows (servers/rendering/renderer_rd/renderer_storage_rd.cpp:437)
ERROR: Condition "!material" is true. Returning: false
   at: material_is_animated (servers/rendering/renderer_rd/renderer_storage_rd.cpp:424)
ERROR: Condition "!material" is true.
   at: material_get_instance_shader_parameters (servers/rendering/renderer_rd/renderer_storage_rd.cpp:450)

Steps to reproduce
New way:

Close the engine by clicking on [X]

Old way:
No Idea how to reproduce, but since its related to materials, I'm using particles, so maybe a possibility could be:

Use a lot of materials
Close/Open the game a lot of times fast

Minimal reproduction project
N/a

How old is this build? This seems related to https://github.com/godotengine/godot/pull/58491 - My guess would be that the textures allocated are never freed and the engine runs to exhaustion. But that's just my 2 second analysis.

5 days ago, you can simply check by going into Godot Version above.

Ah my bad, I missed it and I didn't even realize that was a clickable version link 😮

Just updated the post, I found another bug which was The engine doesnt close via [X] but I found that what doesnt let the engine close is actually this material bug reported above

Not too sure if it's the same issue (didn't see the output panel) but I had the engine completely freeze and then crash on me. I only had two scenes opened (main, which does use more materials but not in editor, they're preload()'ed for in-game use, and the prefab I was working on, which only used one material.
Before it froze completely, it exhibited symptoms similar to a memleak...

@Zireael07 you can open godot with terminal and use a -v argument after the executable name, then when it crashes you can see the output! also I recommend using the debug version, the errors will be more detailed!

I get the material error too:
servers\rendering\renderer_rd\storage_rd\material_storage.cpp:2633 - Condition "!material" is true.

It's not freezing for me, but when there are lots of materials it can take a very long time to endure the spamming.

thanks for showing a way to reproduce, for me the engine is almost unusable, I have to close and open again every 5 min :/

FWIW, I'm hitting this using voxel_tools. I only have 1 material, and it doesn't freeze the engine, but I get about 4000 of these errors each time I regenerate the terrain.

So I started getting this Errors while manipulating a Material of an Object through the "Surface Material Override" and was freeing them with "queue_free()"
My Workaround is to set the Override-Material to null before queueing it free:
Char.get_node("Model").set("surface_material_override/0", null)
Char.queue_free()

Maybe it has something to do, when something needs to be rendered but is queued free?
Hope this helps a little bit :)

this error is already fixed, I didnt had this issue anymore, also not related to queue_free!

I'm seeing the same errors in beta3 when I queue_free() a Node with a surface material override.   Unsetting the material right before queue_free(), like @zurrealStudios suggested, makes the error disappear.
Notes (may not be relevant):

The culprit material is a StandardMaterial3D
The culprit material has resource_local_to_scene = true
The culprit material has a next_pass.

Still present in v4.0.beta.custom_build [2ec0da1a7]:

I see these errors when changing scenes or, as mentioned, freeing nodes with active surface_material_override.
A workaround, when applicable, is to use 'material_override' of GeometryInstance3D instead.

get the same error messages in 4.0rc2

I'm getting a bunch of these errors every time I call queue_free() on characters in my game:

I'm closing this in favour of https://github.com/godotengine/godot/issues/67144 which is more specific about what is causing the issue and includes an MRP.
Please continue the discussion in https://github.com/godotengine/godot/issues/67144
Duplicate of https://github.com/godotengine/godot/issues/67144


[SDL 0177] Alert icon

Proposal: Alert icon

This proposal is about adding the RPC alert to include an icon.

Review: smartdevicelink/sdl_evolution#515

Closed with #1112


str object not callable in print line

On a Toss system, I am receiving this issue with an updated print line.
It is happening here:
for v in brothers:
print("testlist[%d].set(%s, 'Previously ran.') # %s"
(v.serialNumber - 1, v.status.name, v.name), file=fc)
Here is the python error:
Traceback (most recent call last):
File "/usr/WS2/dawson/git-mercury-ats-new/atsmercury_back_end", line 483, in
result = manager.core()
File "/usr/apps/ats/7.0.4/lib/python2.7/site-packages/ats/management.py", line 918, in core
self.continuationFile(interactiveTests)
File "/usr/apps/ats/7.0.4/lib/python2.7/site-packages/ats/management.py", line 985, in continuationFile
(v.serialNumber - 1, v.status.name, v.name), file=fc)
TypeError: 'str' object is not callable

New line is this:
     print("testlist[%d].set(%s, 'Previously ran.') # %s"
             (v.serialNumber - 1, v.status.name, v.name), file=fc)

Old line was this:
print >>fc, "testlist[%d].set(%s, 'Previously ran.') # %s" %
(v.serialNumber-1, v.status.name, v.name)

I added the continuation character but issue still arises.


Ordering curve fixes

This bugfix PR resolves #101 and an unintentional change of the  order curve line width in 3D.

PR
Author
Editor
Reviewers
Assignment
Approval
Merge

#102
@tzanio
@tzanio
@mlstowell + @v-dobrev + @rw-anderson
06/03/20
⌛due 06/10/20
⌛due 06/12/20

Thanks for the help with this @v-dobrev !

Merged in next for testing...


Index#removeAll doesn't pass payload to callback

As far as I can tell, payload is ignored entirely.

I'm guessing addAll and updateAll has the same problem too...

@novalis Looks like this is intentional as the generator explicitly uses undefined for the payload.
https://github.com/nodegit/nodegit/blob/04f481c27e30b0306190bad1f0120a962b102cf5/generate/templates/partials/callback_helpers.cc#L35-L39

It would be ok with me if the docs were fixed. I just used bind to sneak my arg in.
On April 11, 2018 8:00:58 PM EDT, Remy Suen<EMAIL_ADDRESS>wrote:

@novalis Looks like this is intentional as the generator explicitly
uses undefined for the payload.
https://github.com/nodegit/nodegit/blob/04f481c27e30b0306190bad1f0120a962b102cf5/generate/templates/partials/callback_helpers.cc#L35-L39
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/nodegit/nodegit/issues/1479#issuecomment-380632303

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.


Can't find "pldxxx" node in Houdini

Windows
Houdini FX 17.5.391
Pre-Built Palladio 1.6.3
No license
1.Create a new "dso" folder under "C:/Users/MyUserName/houdini17.5/".
2.Extract into that directory.
3.Reopen a new Houdini Project, but I cant find the new two nodes.
Could you please tell me which step is wrong?

make sure the palladio.dll is directly in the dso subdirectory, there must not be an intermediate directory in between.
also, you could try to set HOUDINI_DSO_ERROR environment variable to a value of 2 or 3 and check the output for "palladio" (also see https://www.sidefx.com/docs/houdini/ref/env.html)

Additionally, also make sure the "dso" folder you created is added to the PATH environment variable (we are working to avoid this requirement in the future).

After I added the "dso" folder into the PATH environment variable, it worked.
I found "Note: it is NOT necessary to modify the system PATH environment variable." in "Quick Start".
I think it need to be fixed.


Make Spatial Mapping use unscaledTime

Related to https://github.com/Microsoft/HoloToolkit-Unity/issues/79 - when physics in Unity are paused using timeScale = 0.0f (which is quite a common use case), the spatial mapping stops too, which is undesirable in almost all circumstances.
The common use case is actually the opposite: the game is usually paused, while the HoloLens is allowed to gather spatial mapping data.
The change to unscaledTime allows Spatial Mapping to continue while the physics are
paused.

@mironec,
Thanks for having already signed the Contribution License Agreement. Your agreement has not been validated yet. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot


Pest with Coverage

Hey there, first off: awesome work with the plugin. Works incredible well for me.
Is it possible to run Pest in PhpStorm with Coverage, so the test coverage is already shown in the editor and project tree? (Works with PhpUnit without extra config.)
Currently not runnable (inactive, grayed out) in the "Run" menu in 2020.1.4 with v0.2.1-alpha.3
My workaround is to run it with an extra configuration and then open the results in a browser.

Thanks for the feedback 👍
Currently this is not possible and to be honest something I forgot completely about 😄
We can add support for coverage inside phpstorm so it works like any other code coverage engine.
Some scribbles here for implementation ideas (mostly for myself):
For adding coverage 3 extension points should be needed.

programRunner
coverageEngine
coverageRunner

And a coverageAnnotator might also be needed.
As it is possible to have the plugin installed without having the coverage plugin enabled, it should be added as a new optional dependency, e.g.
<depends optional="true" config-file="pest-coverage.xml">com.intellij.modules.coverage</depends>

It might be possible to reuse most of the logic from phpunit implementation.

Just opened a PR for the coverage support, would be awesome if anyone could test it out 👍
I attached the file for installation from disk.
pest-intellij-0.2.1-alpha.5.zip

alpha.5 works just awesome out of the box. Tested with Xdebug and PCOV (which speeds the execution time a lot).
Does the plugin add some extra Xdebug related arguments to the executed command (cf. screenshot)? (It does not affect neither the usage of PCOV nor the execution time.)

Awesome! Thanks for testing it out 👍
Those arguments are added by phpstorm when I till it to enable debugger and it finds xdebug as your installed debugger.
Not sure what they all do exactly, but I think it's for sending data between xdebug and phpstorm 😄
I'll try and finish up the pr, missing one feature as can be seen in the PR.


Fix WebGL view not updating when dropping second viewport

When dropping a second viewport and re-enabling direct-to-screen WebGL rendering, we really want the WebGL canvas' zIndex to be lower than the 2d canvas, but if we do that, browsers can decide to not update the WebGL canvas contents once it is re-added to the parent div after dropping other viewports. The offending element is the 2d canvas sitting on top of the WebGL canvas. We need to clear the 2d canvas' contents in order to ensure browsers allow the underlying WebGL canvas to update. If a decorator is present, the 2d canvas is cleared during the frame render process by virtue of updating the decorator. For the non-decorator case, and for iOS, we must make sure we still clear the 2d canvas, done here. iOS appears to need this clear even when decorators clear the canvas later in the frame render process.
https://bentleycs.visualstudio.com/iModelTechnologies/_workitems/edit/724983

@pmconne @MarcNeely @DStradley I verified that the "white flash" also happens when re-adding a viewport when a decorator is rendering (the working case).


[Request] Add a config to disable light's effects on the Hood/Cloak of Darkness

I've always found the Cloak of Darkness to be extremely under-powered because of how limiting the light restriction is. so my suggestion is to add a config to disable this behavior entirely.

Added now


Successfully run training in 4bit mode, while the training speed is very slow

Here's some code needed for this adjustments.
https://github.com/johnsmith0031/alpaca_lora_4bit
Don't know why the training is so slow.

How slow compared to 8-bit?

I'm not too surprised, there aren't any good pytorch libraries for doing int4 on the tensor cores

How slow compared to 8-bit?

Had not tried 8-bit yet, but apparently could not complete 3 epoch on instruction dataset in 5 hours.

But why finetune on 4bit? afaik it's ok for inference but extremely bad for training
Maybe we need a way to covert the lora to 4bit instead?

But why finetune on 4bit? afaik it's ok for inference but extremely bad for training

Because in 4-bit you can probably fine-tune the 65b model on a single 4090.

But why finetune on 4bit? afaik it's ok for inference but extremely bad for training

Because in 4-bit you can probably fine-tune the 30b model on a single 4090.

Doesn't matter if the quality isn't good.

Re-inplement the 4bit matmul and increased the training speed by about 20 times.

 I got this running when you first posted it.  I got this running when you first posted it. Tomorrow I'm going to try to train 65b with this plus #131

If you are training on the alpaca dataset, try using the cleaned dataset and let us know if you get better results.

Optimized VRAM usage and now can train LoRA with 30b model on a single 4090

Just wanted to post I was able to train on 30B with a 4090 as well using your code, johnsmith0031.  Thanks for the effort!

The quality of the model obtained (30B 4 bits) was good after training on 4 bits? (I am interested because I also own a 4090)

We also try to implement 4bit-qlora, thanks to the kernel implementation of optimized back-propagation, the speed is similar to 8-bit lora at present. Welcome to use and issue:  https://github.com/megvii-research/Sparsebit/tree/main/large_language_models/alpaca-qlora

Really that bad ?!? I have spent so much time and money on 4-bits last few days, it is not good ...!


placeholder + inherit + or prefers or clause over inherited content

Summary
When a placeholder template has both inherit and or flags, the or content (e.g., the <img> in the example below) shouldn't be used if the current page or an ancestor has a content-generating plugin in the placeholder.  However, the or content is used when the ancestor should be respected.
{% placeholder "header_secondary_image" inherit or  %}
    <img  src="{% static 'img/default_header_secondary_image.jpg' %}" alt="">
{% endplaceholder %}

Expected behaviour
As the doc for inherit says, "It’s also possible to combine this with the or argument to show an ultimate fallback if the placeholder and none of the placeholders on parent pages have plugins that generate content:"
Actual behaviour
Stepping through ContentRenderer.render_page_placeholder in cms/plugin_rendering.py, content has been set to the or version at the end of this code segment so that is the content used.  However, the check for inherited content comes afterwards.  IOW, or is given a preference over inherit.
    def render_page_placeholder(self, slot, context, inherit, nodelist=None):
        current_page = self.current_page

        if not current_page:
            return ''

        content = self._render_page_placeholder(
            context=context,
            slot=slot,
            page=current_page,
            editable=True,
            nodelist=nodelist,
        )

        if content or not current_page.parent_id:
            return content

Environment

Python version: 2.7.12
Django version: 1.8.18
django CMS version: 3.4.3 and 3.4.4 (other versions not tested)

Also:
CMS_PAGE_CACHE = False
CMS_PLACEHOLDER_CACHE = False
CMS_PLUGIN_CACHE = False

Hey @czpython thanks very much for your work on this!  I've been testing this today and it is working largely as desired.  I noticed one odd case though:

in the CMS editing environment
active page has {% placeholder "FOO" inherit or  %}
parent page does not have that placeholder, so nothing to inherit

The placeholder is not rendered (collapses to ''), whereas I expected the "or" contents to be used.
If I view the page anonymously or with the toolbar off, the placeholder is rendered, using the "or" contents as desired.
As of the fix for #6000, the modified call to render_placeholder() in render_page_placeholder() no longer passes through nodelist but instead passes None.  If I change that as shown below, this particular scenario works as I anticipated.
diff --git cms/plugin_rendering.py cms/plugin_rendering.py
index 79258a6..dc1d310 100644
--- cms/plugin_rendering.py
+++ cms/plugin_rendering.py
@@ -296,7 +296,7 @@ class ContentRenderer(object):
                 page=current_page,
                 editable=editable,
                 use_cache=True,
-                nodelist=None,
+                nodelist=nodelist,
             )

         should_inherit = (

I don't know how this relates to why it works when outside of edit mode.  Any thoughts?


Show refine constantly in no results page

Coverage remained the same at 39.38% when pulling 2df02e7a12e40c586922e8d86725fe678b41b0bf on refine into a4ea57e77145fd908647fcd619ff6eef86f91f6d on dev.

Changes Unknown when pulling b0acd719cfe73bbd4d1c82b6a174f18f53ba44fa on refine into ** on dev**.

Changes Unknown when pulling 305359e04ab5b0241241d43e62227c4980481836 on refine into ** on dev**.


Feature/bitrate limit

This is a proposal for a way to set bandwidth limits on available video tracks as discussed #32.

I'm not sure about setMaxBandwidth/setMinBandwidth.  What about something that would allow the user to set all restriction properties, without having to create setters for each one?  Perhaps something like getRestrictions / setRestrictions ?
Also, can you please make this change in the master branch?  The 1.2.x branch is for maintenance, to collect bugfixes relative to 1.2.0.  New features are being added to master, and will first be released as 1.3.0.
We've already refactored Player in master such that all EME-related stuff is in shaka.media.EmeManager.  The way things are organized now, you'll want to provide a reference to the Player's restrictions_ object to EmeManager to set the license-based restrictions.

Yup, I'll submit to master. Was unsure where to go without a develop branch.
I'll put more thought into the setMax/setMin vs get/set restrictions. But this seems like a good point so I'll change it and submit again.
Thanks for the quick feedback.

Closing, superseded by #36.


allow_private vs allow-private argument problem 0.17.0

Describe the bug
I'm getting the following error after upgrading to 0.17:
[cargo-make] INFO - cargo make 0.17.0
...
error: Found argument '--allow_private' which wasn't expected, or isn't valid in this context
	Did you mean --allow-private?

To Reproduce
Steps to reproduce the behavior:
git clone https://github.com/mbrobbel/dqcsim-rs.git
cd dqcsim-rs
make build

found the issue. will fix it today. thanks!!!

@mbrobbel just published new 0.17.1 version with the fix.
if you could also please verify it.

0.17.1 works! Thanks.


CF Release

Updates
Added

capital-framework: [patch] Add atomic-component dependency to main package.json.

Changed

cf-expandables: [minor] Update atomic-component dependency to 1.3.2.
cf-tables: [minor] Update atomic-component dependency to 1.3.2.

Removed

all components: [patch] All individual component lockfiles.

Review

@cfpb/front-end-team-admin

I am a bot
After this PR is merged, I will instruct Travis to automagically perform the following steps:

Increment Capital Framework's version per our guidelines.
Add a timestamped entry to the changelog with the new version and its changes.
Tag the release and push it to GitHub.
Publish both capital-framework and any individually updated components to npm.
Update both canary, our development branch, and master, our release branch.

If I do something wrong, blame a human.

Yeah I republished it at 0.0.1 just to ensure it exists in the registry
before the bot releases new versions.
On Sep 7, 2017 07:46, "Ans"<EMAIL_ADDRESS>wrote:

@anselmbradford commented on this pull request.
In src/cf-notification/package.json
https://github.com/cfpb/capital-framework/pull/590#discussion_r137560197
:

@@ -1,6 +1,6 @@
{
"name": "cf-notification",

"version": "1.1.1",

"version": "1.0.0",

Yet it's currently published as 0.0.1, is that expected?
https://www.npmjs.com/package/cf-notification
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/cfpb/capital-framework/pull/590#discussion_r137560197,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABAtmBmmJLhGmppI7LIio1aOeBLI60gBks5sgAHegaJpZM4PO15Z
.

Alrighty cf-notification has been published at 1.0.0 and it's listed in this PR as 1.0.1.


Package Builds for Ubuntu Bionic and Fedora 28

Both versions have just hit stable, and automating the package builds for both shouldn't be too hard. If you'd like I can send in a pull request for it.

Currently building on Bionic is breaking with:
[  4%] Built target taglib
[  4%] Linking CXX shared library ../../../bin/plugins/libpulseout.so
/usr/bin/ld: cannot find -lcrypto
collect2: error: ld returned 1 exit status
src/plugins/pulseout/CMakeFiles/pulseout.dir/build.make:153: recipe for target 'bin/plugins/libpulseout.so' failed
make[2]: *** [bin/plugins/libpulseout.so] Error 1
CMakeFiles/Makefile2:887: recipe for target 'src/plugins/pulseout/CMakeFiles/pulseout.dir/all' failed
make[1]: *** [src/plugins/pulseout/CMakeFiles/pulseout.dir/all] Error 2
Makefile:127: recipe for target 'all' failed
make: *** [all] Error 2

I'm not sure what provides the crypto library, and more importantly what changed between xenial and bionic to cause this error.

Actually, it appears this happens in xenial too.

Got it, libssl-dev needs to be installed.

Sorry, life's currently a bit crazy and I didn't see this one come in! Are we missing a required dependency (libssl-dev) in the packaging scripts on Ubuntu?

Sorry for the delay, been busy with things as well. It doesn't need to be installed as a package dependency, but it does need to be installed during build. libcurl4, however, will have to be a package dependency for bionic builds. Fedora, thankfully, has no such problems, so a build for Fedora 28 would just be adding another job to CircleCI and (IIRC) another version in PackageCloud.

Fixed! Bionic and F28 builds are now distributed with new releases.


use GPy if available

Added possibility to use GPy engine library if available instead of Scikit-Learn for Gaussian Process interpolation

No one tested if the flow works in all the possible scenarios but the interpolating function has been encapsulated in a try-and-catch block. The "happy" should be put to "no" by default in this case.


[bugfix] controls info bubble don't show up

It turns out the new icon referenced (fa-question-circle-o) was in a newer version of font-awesome.

@ascott @bkyryliuk

Coverage decreased (-0.09%) to 81.385% when pulling 4fa46945c986055aa97baaad98c4f919be1c2562 on fix_question_mark into 572c6ee85ea4f46cca36a9d41e95a668a7a78a23 on master.

hmm, i wonder why this worked locally? maybe i have font awesome on my local machine.
lgtm 🎉


layout manager loses event subscriptions?

I have a single view that is bound to a collection:
Permissions.Views.UserList = Backbone.LayoutManager.View.extend({
        template: 'userlist',

        events: {
            'click': 'select'
        },

        initialize: function() {
            this.collection.bind("all", function() {
                    this.render();
                }, this);
        },

        serialize: function() {
            return { users: this.collection.toJSON() };
        },

        select: function() {
            console.log('select');
        }
    });

The 'select' function is never called because of the collection bind in intialize.  If I comment out the initialize the select fires just fine.

I'm using async load of the templates if that matters.

The bug is definitely something with async, I changed the fetch to:
fetch: function(path) {
    var html = $.ajax({
        url: path + '.html',
        async: false
    }).responseText;

    return html;
},

and all works.

Hey man I have not been able to reproduce this at all and without a reduced test case I can't evaluate if this is a real issue or not still.  Please give the latest code on master a shot and let me know if it still fails with a reduced test case showing the issue.
Thanks man!

Finally able to reproduce, will keep you posted on a solution.

Okay I think I nailed the problem.  I am unable to reproduce at all now with latest master.


Demos/appnp

I've added in an APPNP demo for the reddit dataset from the GraphSAGE paper and included APPNP in the twitter demo.
One issue is:

APPNP doesn't naturally allow for node embeddings. To keep the workflow of the twitter demo consistent I obtained node embeddings by propagating the MLP features (as opposed to the MLP predictions) but the resulting embeddings aren't well separated by TSNE=

Reviewer Checklist

[ ] Twitter demo notebook runs and clearly demonstrates how to use APPNP
[ ] Feature propagation in twitter notebook is correct
[x] Reddit demo notebook runs and clearly demonstrates how to use APPNP

hi @habiba-h, I've added the new SG class in and the memory use is way down. I've also removed appnp from hateful twitters because I don't think it added much and made it more confusing. I think its ready for review again :)

Per our discussion at sprint planning, if we land this here without running it on CI, we should have a follow-up issue for getting it running (some approaches might be: just taking the download cost; using a smaller/reduced version of the datasets).
Alternatively, if we do https://github.com/stellargraph/stellargraph/issues/1221, we can land this in our "use cases" repo.


A JavaScript error occurred in the main process

macOS version: 10.13.6
Kap version: 3.0.0-beta.2
Steps to reproduce

Download the beta
Install by dragging to /Applications
Launch the app (via Alfred in case that's relevant)

Current behaviour

Expected behaviour
For the app to start
Workaround
None afaict

Duplicate of #581


Karpenter not deleting node after scale down of replicas

Description
Observed Behavior:
I am using karpenter with EKS,
So initially, i created only one node, and then deployed my application with replicas 1
Now, when i scale these replicas from 1 to 20, karpenter detects it and launched new node and scheduled pod on that newly created node.
But now when I scale it down to 1 replica, the replica is still on newly created node due to which karpenter didnt deleted that node.
Ideally it should, be on desired node and deleted newly created node
Expected Behavior:
It should delete the node, once replicas decrease from 20 to one and it should keep 1 replica on desired node
Reproduction Steps (Please include YAML):
Versions:

0.13.0

@Vijaygawate What did you manually create a node for? Karpenter would automatically provision new nodes in response to pending pods. From what you have described, Karpenter created a new node when it saw a pending pods which seems like a normal behavior. When you scale down to 1 replica, it will still continue to run that pod on the node that it provisioned.

@jigisha620 So if it will still continue to run that pod on the node that it provisioned., then newly created node will not be deleted, i want scale down nodes as well when replicas scale down to 1 or 2. How can I achieve this?

How many nodes did Karpenter provision is response to the your deployment?


[MPWG Prospectus Quote Addition] Payara

Payara's quote
@rstjames,
Can you add it to the document?
This addition with latest adjustments you have made make me wonder if we could improve the way the Quotes are presented in the MPWG page by allowing a quote link to be possible. Like that, that link could be a part of the Prospectus Quote's section and help scale the document.   It is not going to be scalable when we get 20 Organization quotes, so we need to think ahead and find a way that shows all of them in the document with 1 links.  Website link sounds great but it is not focus... "later wish".
Also, we are awaiting for Oracle and Garden State quotes to be submitted whenever the partners wish to submit.
Thanks Ryan,

done


Identity object should be retrieved in the background (also when app is closed)

[placeholder]

I guess this tries to solve the same problems as the "new" last page of the identity issuance flow, letting the user know to check back once in a while. I've drawn up a few suggestions on what that last page could look like, but I think automatic retrieval would be a better solution. Maybe we should discuss what to do.

@jens-concordium: This is a backlog placeholder for some future version, it is not in scope for the upcoming release. The last page is in scope now, so your suggestions are relevant for this release and should be included in a new issue and discussed with Mjoelner.

@concordium-cl, alright! I'll make issues for the last page then.

last page: https://github.com/Concordium/concordium-reference-wallet-android/issues/27

Context changed.


Complete cover Jetson

Complete cover jetson and add hole for air refresh

[x] complete cover
[ ] Holve for fan

Added diagonal cover d174c39883a7d8f078c8adf9bd44e523e3d87798

Test Cover with hole for fan

Solved without fan hole


Compatibility with ArcGIS v.4+

Hi!
I would like to find out if there are any plans on compatibility with ArcGIS JS of version 4+?

@kellyhutchins any plans to migrate this to 4x?


Basic and Progress examples break on resize

Vertically resizing the browser window or just opening the developer console breaks these examples. The progress steps will end at some progress < 100%, and the elements in the basic example will get triggered at the wrong time.

I didn't put in any resize events to handle responsive on either of these demos. However, it is a two-liner (simply setting up a resize event handler and calling the scrollama resize function) - so I'll add it in.


chore: classify used to be dsimp porting notes

Classifies by adding issue number (#10934) to porting notes claiming anything semantically equivalent to:

"used to be dsimp"
"was dsimp"

Thanks :tada:
bors merge


docs(traffic_light_fine_detector): update add training documentation

Description

Update documentation for the package. Provide explanation how to train detection model on custom data and example dataset.
This PR should be merged after the creation Autoware repo for helper package which includes configuration files, training and conversion scripts.  Currently this code is stored in private repo.
Tests performed

Not applicable.
Effects on system behavior

Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[X] I've confirmed the contribution guidelines.
[X] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@lexavtanke Is the PR still in progress?


Update to Kotlin 1.2.60 and androidx

Coverage decreased (-1.4%) to 58.407% when pulling d922613e655d77c094bae06a9afc050eee27839a on version_upgrade into 03dc92b34ac2e8680ab8cdd2f86d9495c8100da7 on master.


Code duplication

Remove this code duplication and update line 93 to call the getAveragePrice function instead:
from: uint256 rate = SafeMath.div(sumPrice, length);
to: uint256 rate = getAveragePrice();
https://github.com/omsfinance/oms/blob/b2fbd8a9c657af6389bb2a856d8618d675b0f3f1/contracts/v6/OraclePrice.sol#L83-L91

This is not duplicate data this method is an internal method and getAveragePrice method is view method to get average price.


Install: Discover and use kubeconfig

Description
Our assumption is that most users will initially run Meshery outside of their cluster and will have a local ~/.kube/config that may be referenced for connecting to their Kubernetes cluster(s). To facilitate time-to-value in using Meshery, let's look for that kubeconfig during initial deployment and assume it's use.
Behavior

[x] Users should be able to swap out this config after initial deployment, if they would like to use a different config.
[x] If a previous kubeconfig has been loaded, do not override the existing config. If not previously loaded, look for the user's kubeconfig and assume use of the current-context.

Implementation and Related Challenges
In order to discover the kubeconfig file, Meshery will need to mount $HOME/.kube in order to access the kubeconfig file.
Currently, when a kubeconfig is loaded into the Settings screen (into Meshery), the entirety of the kubeconfig file contents are persisted into Meshery's local database. As a user makes changes to their kubeconfig, they will need to update Meshery with those changes.

Future

To accommodate for changes in the user's kubeconfig file without making the user reload the config file in Meshery, we will need to only persist a reference to the kubeconfig file and not its contents. In order to continue to facilitate for kubeconfigs that may be in a separate location, however, Meshery needs to persist the entire file contents in it's local database.This issue needs to be addressed in the future.

Parse and display all Kubernetes contexts, so that the user may select their desired "current context".

Delivered in #205


Missing Spaces while using Multiple Monitors

I have a dual display setup where my primary display is the Mac's display and the secondary is my External monitor. The Spaces only show the spaces from either one of the displays. If i disconnect the external monitor then this works perfectly. Otherwise it just shows the spaces from either one of the displays.

Hey,
Please, try a new version:

https://github.com/ekalinin/SpaceName/releases/tag/0.6

@ekalinin This works perfectly! Also a suggestion, I am not sure if this is possible since I am new to lua and hammerspoon. But showing just the desktops in that monitor would be much better. Just a suggestion that could be considered if it is programatically possible. This is great work though! Love it.

But showing just the desktops in that monitor would be much better. Just a suggestion that could be considered if it is programatically possible.

Good point, thanks! Will investigate whether it is possible to implement it with hammerspoon.

This is great work though! Love it.

Thanks!

I have two monitors as well and observe this behavior:
if "Multi Monitor Mode" is enabled, then using the SpaceName menu I can switch to any desktop, but in the menu it will show only desktop names from only one of the desktops, and I can set the name only for the desktop which is shown in the menu.
And this is determined at the start of Hammerspoon, maybe randomly.
Basically I have to restart Hammerspoon a few times in order to show the desktop from the second monitor so that I can rename the desktops there.
(which is a workable, but not ideal solution)


Setup controller

Hello 👋🏾
The following objectives have been implemented:

[x] Use controllers to handle requests and render empty views.
[x] Understand Rails naming conventions.
[x] Use params from browser requests in a safe way.

Hi Sharon,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
Kindly ensure that your ReadMe is professionally documented, and adhere(s) to the following standard(s):

[ ]  Kindly ensure that provided text instructions are removed and replaced with appropriate contents applicable under each section of your ReadMe. Similarly:

Kindly also remove guide notes for license creation under the license section.
Kindly remove all guide notes from your ReadMe

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
Invalid Code Review Request does not count into the code reviews limit.

Hello, what's wrong with te readme file?


Some errors don't have a 'key'. Gracefully degrade.

The test should show what I'm talking about. Specifically I'm using:
ubuntu 18.04
python 3.6.5
libcouchbase-dev 2.9.5-1
couchbase Community Edition 5.1.1 build 5723
not quite sure why some ViewResults don't have key attributes, but this seems to fix it.

Hi @djeebus - please could you sign the CLA today if possible, as I would like to get a fix reusing your test into the release today?
Many thanks,
Ellis

@griels I believe I signed it a week ago? The website claims "Agreement already submitted."

@griels I believe I signed it a week ago? The website claims "Agreement already submitted."

The most common reason that it may not be matching up is using a different email address on the gerrit account from your PR.  The bot gave an anonymized email to check matching above-- do they match?
Check http://review.couchbase.org/#/settings/ and http://review.couchbase.org/#/settings/contact .
Thanks for working through this necessary step!

Yup, the anonymized email address looks to be the same as the one in gerrit. Anything else I should check?

Adapted and merged. Thanks for your contribution.

Adapted and merged. Thanks for your contribution.

Have adapted your test and written a new implementation. Thanks for your contribution!


installation stuck at solving environment

Hi, i'm encountering issue installing mosaicforecast. The following was what i've conducted but it seems conda is stuck at solving environment. Wondering how may i troubleshoot this issue?
conda env create -n MF --file environment.yaml
Collecting package metadata (repodata.json): done
Solving environment: -

Thank you very much for the kind help.

Hi, i'm encountering issue installing mosaicforecast. The following was what i've conducted but it seems conda is stuck at solving environment. Wondering how may i troubleshoot this issue?
conda env create -n MF --file environment.yaml
Collecting package metadata (repodata.json): done
Solving environment: -

Thank you very much for the kind help.

Sorry for the delayed response. Have you tried installing each package using conda separately?


WIP - Try using Vitest instead of Jest

A quick experiment to see if how hard replacing jest with an actively documented, library like vitest  would be.
Why Vitest?
https://vitest.dev/guide/why.html

Oh neat, that wasn't too complicated. We have a way out from maintaining Jest no longer being a priority for Meta/Facebook.


Rename distributed_backend to accelerator in examples

What does this PR do?

Fixes # (issue)
Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In in short, see following bullet-list:

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[ ] Make sure the title is self explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?
Make sure you had fun coding 🙃

To your point @Borda the differentiation will eventually be made I think, with plugins abstracting more out we'll converge to hopefully separating accelerator/distributed


Wiesemann-Theis.USB-Redirector version 3.62

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/111366&drop=dogfoodAlpha

@wingetbot waivers Add Validation-Domain


GROOVY-7074: fix for using a Builder as delegate in a DelegatingScript

created out of patch https://issues.apache.org/jira/browse/GROOVY-7074 submitted by Jochen Kemnade

I'm closing this, as the solution does not seem optional. See discussion at: https://issues.apache.org/jira/browse/GROOVY-7074


Array with nodes that have attributes AND values

Hello,
I have an XML of a structure:
<categories>
    <category parentId="" id="000000001" order="1" tagid="">Red</category>
    <category parentId="000000001" id="000000002" order="1" tagid="">Blue</category>
    <category parentId="000000002" id="000000254" order="1" tagid="">Green</category>
</categories>

So, you see, it's an array of dictionaries.
Could you please give me a hint how to parse such data?

declxml supports a small subset of XPath syntax. Specifically, the dot selector ('.') can be used here to select the current element which allows you to select multiple values from a single element both from its attributes and its element data.
So a processor that would work for your sample data would be
import declxml as xml

processor = xml.array(xml.dictionary('category', [
    xml.string('.', attribute='parentId', required=False),
    xml.string('.', attribute='id'),
    xml.string('.', attribute='order'),
    xml.string('.', attribute='tagid', required=False),
    xml.string('.', alias='color'),
]), nested='categories')

Specifically, the line xml.string('.', alias='color') means "From the current dictionary element (category in this case) select its data and store it in a field called color in the resulting dictionary".
I hope that helps. Please let me know if you have any more questions or issues.

Closing this as resolved for now. Definitely let me know if you have any more issues or questions!

@gatkin That works, thank you a lot for exhaustive explanation!
And sorry for late response.


Blender: Use task level attributes instead of asset

Changelog Description
Improved creators to set up scene properties instead of using asset-level attributes.
Testing notes:
The creators and the extractors that have been updated should be tested to check if they're using the information set in the creator.

For what it's worth - looking at the code I see nothing related to "task level attributes" versus asset level attributes. Is the PR title and description wrong maybe?

Regarding to the comment above, we need to also adjust the get_folder_attributes function in pipeline.py. And there should be possible change of the function name.
Instead of merely using folder entity, we use task entity and we can use the folder entity as backward compatibility(maybe or maybe not).
The function which can get the related data from task entity(take below as example)
from ayon_core.pipeline.context_tools import get_current_task_entity
task_attributes = get_current_task_entity(fields={"attrib"})["attrib"]

PR moved to ayon-blender repository https://github.com/ynput/ayon-blender/pull/1


Initial conversation from bot. But start over while user input

Hi guys,
I want to start the very first conversation from bot. So I trigger the "bot.beginDialog" while "conversationUpdate" occur.
var bot = new builder.UniversalBot(connector);

bot.on('conversationUpdate', function(session){
	bot.beginDialog(session.address, "*:/");
});

It works, the bot start the conversation and direct the conversation to root dialog "*:/"
But while the user reply, the conversation start over. The session id and conversation id are the same.
How can I modify the code to let the user input connect to the conversation which start by bot?
Or we should not start the very first conversation by bot?
I put the log below.
Thank you!
ChatConnector: message received.
session.beginDialog(*:/)
/ - waterfall() step 1 of 1
Root dialog Address:  { id: '10a97ghj983i40jgc',
  channelId: 'emulator',
  user: { id: 'a444ihm749eg9k717c' },
  conversation: { id: 'a444ihm749eg9k717c' },
  bot: { id: 'default-bot' },
  serviceUrl: 'http://localhost:9002',
  useAuth: true }
/ - session.send()
/ - session.beginDialog(/askQuestion)
./askQuestion - waterfall() step 1 of 2
askQuestion dialog Address:  { id: '10a97ghj983i40jgc',
  channelId: 'emulator',
  user: { id: 'a444ihm749eg9k717c' },
  conversation: { id: 'a444ihm749eg9k717c' },
  bot: { id: 'default-bot' },
  serviceUrl: 'http://localhost:9002',
  useAuth: true }
./askQuestion - session.beginDialog(BotBuilder:Prompts)
..Prompts.text - session.send()
..Prompts.text - session.sendBatch() sending 2 messages
ChatConnector: message received.
session.beginDialog(/)
/ - waterfall() step 1 of 1
Root dialog Address:  { id: '8g16n7f3kg9gjb37l',
  channelId: 'emulator',
  user: { id: 'default-user', name: 'User' },
  conversation: { id: 'a444ihm749eg9k717c' },
  bot: { id: 'default-bot' },
  serviceUrl: 'http://localhost:9002',
  useAuth: true }
/ - session.send()
/ - session.beginDialog(/askQuestion)

Hi @Taroka Could you please also post your emulator logs?

Hi @eanders-MS , sure!
[15:58:47] -> POST 202 [conversationUpdate]
[15:58:47] <- POST 200 Reply[message] This is root msg, let's go to next dialog.
[15:58:47] <- POST 200 Reply[message] This is the second dialog
[15:58:58] -> POST 202 [message] i wan to ask question  // start over to the right user flow
[15:58:58] <- POST 200 Reply[message] This is root msg, let's go to next dialog.
[15:58:58] <- POST 200 Reply[message] This is the second dialog
[15:59:08] -> POST 202 [message] i want to ask question
[15:59:09] <- POST 200 Reply[message] I'm sorry. I didn't understand.
[15:59:09] <- POST 200 Reply[message] Do you have any other questions?

I don't yet have a clear picture of the problem. Can you give more detail about what you're seeing vs. what you expected to happen?

Sorry for the confusing. I try to make it clear.
This is what I see

And this is what I want:

Bot: Hi, I'm Bot. I can answer your question
Bot: Do you have any question?
User: here is my quesion.
Bot: Here is your answer.
Bot: Do you have any other question? If you want to end this chat, please say "bye".

That is, I want the bot start a conversation and user smoothly success join the conversation which start by bot.
Right now seems the user will start another conversation once they reply the initial msg from bot. That is, bot don't know it send a message to user and still waiting for the first "Hi" from user to start the conversation.

hi @eanders-MS  could you help?

@Taroka I believe that the 'conversationUpdate' handler accepts a message rather than a session. This might be a factor. @Stevenic are you able to shed light here?

Hi @Taroka Some experimentation led me to this, which seems to achieve what you're trying to accomplish, at least in a simplistic way:
bot.on('conversationUpdate', (message) => {
    if (message.membersAdded) {
        const hello = new builder.Message()
            .address(message.address)
            .text("Hi, I am Bot. I can answer your question");
        bot.send(hello);
        bot.beginDialog(message.address, '*:/');
    }
});
bot.dialog('/', [
    (session) => {
        builder.Prompts.text(session, 'Do you have any questions?');
    },
    (session, results) => {
        session.send('Here is your answer');
    }
]);

Emulator log:
[00:17:15] -> POST 202 [conversationUpdate]
[00:17:16] <- POST 200 Reply[message] Hi, I am Bot. I can answer your question
[00:17:16] <- POST 200 Reply[message] Do you have any question?
[00:17:27] -> POST 202 [message] my question
[00:17:28] <- POST 200 Reply[message] Here is your answer.

Hi @eanders-MS thanks! And I found an interesting situation. that is the same code give me different result in different version emulators lol

Ah, it's because you're running an older version of the new emulator than me. :) I was running an internal dev build with a bugfix you don't have yet. We're in the midst of making a new emulator release at the moment. You should get an update available prompt the next time you run it.

Closing this issue as it appears we've addressed the problem. If you have additional questions or would like to discuss further, please at-mention either of us or open a new issue. Thanks!

Thank @eanders-MS and @dandriscoll !

ok but i noticed that if you add both a first run and a conversationUpdate, both of them get triggered on facebook so arent you using a first run?

I have the same issue, but with the Webchat (IFrame) channel. Any inputs regarding that?


Failed to create tenants with working domain and SSL certificate

I'm creating an app that already has a domain assigned and ssl certificate working, but when I want to create new tenants to replicate the app, they don't work, I have configured in my dns provider a subdomain *.myapp.com, and several subdomains anyname.myapp.com with possible names that I can give them all pointing to the IP of the server,   And when I create those tenants with those subdomain names, I can't access it from the browser.

The only way I was able to get a tenant to work with a subdomain, was by deleting the SSL certificate, restarting the entire server, having the previously created subdomain and previously created tenant, by starting again by installing the certificate again, restarting saltcorn again, and after several error alerts per endpoint due to the certificate, I was able to run a single tenant.

@gianlucafiore there are two different things going on here:

in your initial set up, where are you using the built in SSL certificate facility from let's encrypt? This does not work with wildcard domains or with tenants. If you want to use wildcard SSL with tenants, you should use a custom SSL certificate. You can either buy this or you can use let's encrypt but you need to use certbot on the command line and make adjustments to your domain's DNS settings.

in the second problem your browser has remembered that this website must be served on HTTPS. Try to open an incognito/private tab and if this helps and clear your cookies.


Ability to load multiple tags/hrefs reusing a unique callback

Reviewed 2 of 2 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from the review on Reviewable.io


Bus route

resolves #74
The bus driver gets a route assigned on connection.
They have the bus line as well as the next stop displayed.
They press a button to change to the next stop and send it to passengers via MQTT
By pressing on the current stop, a list with all stops for the line is displayed. It goes away by pressing on the current stop again
When the last stop is reached, the driver and passengers are notified that this is the last stop. The driver is invited to press the "NEXT button again to reverse the line and continue the trip but the other way.

Hey Alex, I am just concerned about that the "Stop list" is covering other functionalities when clicking it. I know the layout is already stuffed, maybe we could have another layout shows these info before proceeding to the driver's control dashboard? And then the dashboard could just show the next stop. Just a suggestion! We can  also discuss that in the meeting tomorrow :)

This PR is closed and will come back with new elements. The original issue #88  has been completed with new elements which make this PR no complete anymore
Be back soon ! 😄

Hey Alex, I am concerned about that the "Stop list" is covering other functionalities when clicking it. I know the layout is already stuffed, maybe we could have another layout shows these info before proceeding to the driver's control dashboard? And then the dashboard could just show the next stop. Just a suggestion! We can also discuss that in the meeting tomorrow :)

Hi Bassam ! Yes, I understand. That is how I thought about it at the beginning, but then I thought what if the driver wants to see the list while he is at a stop for instance. It would need to go to the page for it which would make the whole interface hidden (if we think the list is on another activity).
We can definitely discuss the alternatives during today's meeting, yes =)

@juliavankirk Video updated !
@edizgenc2021 The master is merge correctly now!
@gusaxtcha Fixed the code so it is clearer with the "end of line" text !
😄


Reduce frequency of content pages design survey

Survey currently appears too frequently, this PR reduces that.

Do we also need to reduce the frequency of GOVUK_content_pages_design_survey_2 or is it just GOVUK_content_pages_design_survey_1?

Good spot, it should be both. Will fix.

@vanitabarrett now applied to both surveys

@maxgds Changes all look good to me, not sure what the Jenkins failure means though.


Dev components rename

Coverage decreased (-1.02%) to 69.019% when pulling 40856ee71d5ccff384d9dd8480f9de85086a2993 on dev-components-rename into 45f37f4ff346b3e509df7a25c041effe5e517f48 on dev.


This document does represent a released version of the Standard

I think this ship has sailed, whether we're ready or not.

I won't be able to look at this until I'm finished with freeze work


fedora-messaging schema issues

We're currently not updating copr build checks in PRs. This is all I see in fedmsg pod logs:
[WARNING fedora_messaging.message] The schema "copr.build.start" is not in the schema registry! Either install the package with its schema definition or define a schema. Falling back to the default schema...
[INFO fedora_messaging._session] Consuming message from topic "org.fedoraproject.prod.copr.build.start" (id 6875ed24-b4db-4824-ad34-4d08ac4bf881)
[WARNING fedora_messaging.message] The schema "copr.build.end" is not in the schema registry! Either install the package with its schema definition or define a schema. Falling back to the default schema...
[INFO fedora_messaging._session] Consuming message from topic "org.fedoraproject.prod.copr.build.end" (id ed16a560-8fbf-45be-96af-7dadde671688)

It seems to work again https://github.com/packit-service/packit/pull/601 :)

So the problem was not in our code - let me create an issue to improve usability when such thing happens in future again.

How the we know the problem was not on our side?

It seems to work again

Looking at both workers logs; the outage was from
2019-11-07 11:10 to 2019-11-11 22:53

How do we know the problem was not on our side?

We (or at least I) don't know.
There are no timestamps in the fedmsg pod logs, so I don't know what was happening in the above timeframe, but I don't see any abnormalities in the logs, so I guess there were just no messages comming from the bus.

According to datagrepper, the messages were sent.
For example these are the data from 2019-11-09 01:00 to 2019-11-09-12:00 UTC https://apps.fedoraproject.org/datagrepper/raw?topic=org.fedoraproject.prod.copr.build.end&start=1573261200&end=1573300800

Then the problem was on our side.

[WARNING fedora_messaging.message] The schema "copr.build.start" is not in the schema registry!

#227

There are no timestamps in the fedmsg pod logs

#229

but it started to work w/o us doing anything - hence I assumed the problem was not on our side


crawl: use static config for data files on darwin

This allows the game to be executed from anywhere, not just from the package /bin

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[X] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Hi @virusdave.
Would or is DATADIR not being set causing issues on linux?

This allows the game to be executed from anywhere, not just from the package /bin

Does that mean the program looks for datafiles relative to where it was executed?

can you also make the commit msg to what I edited the PR title to?

@abbradar can we get this PR merged?

Hi @virusdave.
Would or is DATADIR not being set causing issues on linux?

Not sure.  I can don't have a linux box, but i can re-read the code tonight perhaps.  The program has a hardcoded set of absolute and relative paths to look for its data files.  On OSX, these are "normal" locations you'd expect installed programs to live, not the nix store.  The relative paths in the list are based on where the CWD was when the program was executed, not where the program actually lives on the FS.

This allows the game to be executed from anywhere, not just from the package /bin

Does that mean the program looks for datafiles relative to where it was executed?

Yes, relative to the CWD when it was executed (not where the binary itself lives, which would have also solved the problem).

Can you also change the commit msg to what I edited the PR title to?

Sure, i'll do this tonight and update the PR.

@worldofpeace I've updated the commit title.

Hi @virusdave.
Would or is DATADIR not being set causing issues on linux?

Not sure. I can don't have a linux box, but i can re-read the code tonight perhaps. The program has a hardcoded set of absolute and relative paths to look for its data files. On OSX, these are "normal" locations you'd expect installed programs to live, not the nix store. The relative paths in the list are based on where the CWD was when the program was executed, not where the program actually lives on the FS.

This allows the game to be executed from anywhere, not just from the package /bin

Does that mean the program looks for datafiles relative to where it was executed?

Yes, relative to the CWD when it was executed (not where the binary itself lives, which would have also solved the problem).

So I guess it would be okay to do this for linux also?

Yes, relative to the CWD when it was executed (not where the binary itself lives, which would have also solved the problem).

So I guess it would be okay to do this for linux also?

Ok, i've removed the conditional check for darwin on this as well.  I don't have a great way to check this on linux (no linux box), but perhaps i can grab a docker image or something to test it.

Yes, relative to the CWD when it was executed (not where the binary itself lives, which would have also solved the problem).

So I guess it would be okay to do this for linux also?

Ok, i've removed the conditional check for darwin on this as well. I don't have a great way to check this on linux (no linux box), but perhaps i can grab a docker image or something to test it.

I'm using NixOS so I can test for you :+1:

Actually, what is the expected directory of DATADIR?
Would that be $out/share or $out/dat?

Tested on a nixos docker container and this works still.

Actually, what is the expected directory of DATADIR?
Would that be $out/share or $out/dat or is it inferred from the parent directory?

./share and ./dat (and friends) are tried relative to DATADIR.

@virusdave This worked for me. Please squash and rephrase your commit msg.

Done.

@virusdave Thanks. I'm confident we can merge this.


Twitter Remain authenticated

Find a way to store authentication token so user stays authenticated even when app closes

Related #38


ProcBots: JenkinsTestBot suggestion

As I suggested in https://github.com/resin-io/resin-supervisor/pull/446#issuecomment-307984478
I've not used Jenkins myself, but from what I've seen, it looks like in order to get Jenkins to test / re-test a PR, you need to add a comment like @resin-jenkins test this please.
However adding comments like this can be seen as 'noisy' as each time a comment is added to a PR it sends out a notification email.
So taking inspiration from the way that VersionBot gets triggered via the application of a ready-to-merge label (which AFAIK doesn't send notification emails), I suggested it might be nice if there was a ProcBot that could watch for e.g. a jenkins-test-this label being added to a PR, and use that to trigger a Jenkins build. (although I've no idea how feasible / practical this would be)

This only works if there's somewhere to kick Jenkins programmatically without needing to create a comment. Else we're back to the point where we came in. It would need to be done without any sort of Jenkins credentials, ie. it'd need to be able to essentially click on the details button then select 'Rebuild'.

*shrug*
I know nothing about Jenkins, I just assumed ProcBots could use some API to interface to it (ServiceEmitter?), like it does with GitHub.

@lurch I'd need to look into it, but from what I understand the GH App for Jenkins only runs off comments (I could be completely wrong).


[no-restricted-path] Custom error message

Main change
Adds a message configuration param for every zone, that will be displayed in case of the rule violation.
The logic is pretty similar to eslint's no-restricted-imports
Background
Sometimes, it is not very clear, why you can not import certain modules in certain scenarios. This is especially the case for newcomers. To be more user friendly, we could display additional info, right in the error message. It would look something like this:
//eslint config
'import/no-restricted-paths': [
  'error',
  {
    basePath: './src',
    zones: [ {
      target: './core',
      from: './features',
      message: '' +
        '\n\nCore should be completely isolated from features.' +
        '\nFeatures may use core but not vice versa',
    }],
  }
],

Then VSCode would display it like that:

Coverage remained the same at 97.739% when pulling 7b5e2dc74e85dac9906907e4f55e7b6f4efaadfc on malykhinvi:no-resticted-path-custom-message into 0547c7efa0a1becd2cdf35ae03f6fe74472398d9 on benmosher:master.

Coverage remained the same at 97.739% when pulling 7b5e2dc74e85dac9906907e4f55e7b6f4efaadfc on malykhinvi:no-resticted-path-custom-message into 0547c7efa0a1becd2cdf35ae03f6fe74472398d9 on benmosher:master.

Coverage remained the same at 97.739% when pulling 7b5e2dc74e85dac9906907e4f55e7b6f4efaadfc on malykhinvi:no-resticted-path-custom-message into 0547c7efa0a1becd2cdf35ae03f6fe74472398d9 on benmosher:master.

Coverage remained the same at 97.739% when pulling 7b5e2dc74e85dac9906907e4f55e7b6f4efaadfc on malykhinvi:no-resticted-path-custom-message into 0547c7efa0a1becd2cdf35ae03f6fe74472398d9 on benmosher:master.