Create webpack setup for angular2

Description:
Create webpack setup for angular2 in project.

We are using angular-cli, so I'm going to close it for now.


Adfgvx cipher implementation

Implementation of ADFGVX Cipher. Basic function is chain the existing Polybius and ColumnarTransposition ciphers.
Tests included:

encrypt_message
decrypt_message
with_utf8
invalid_key_phrase

Most tests are delegated to those in Polybius and ColumnarTransposition ciphers.
Updated .travis.yml to include rustfmt check to ensure consistent code style. Build fails if developer has not formatted code, use: cargo +nightly fmt
Ran Clippy - cargo +nightly clippy to lint existing code. I've fixed up most of the issues and it largely aligns with idiomatic styles.
Merged in latest master and merged in my working adfgvx branch.
Known issues:

Code smell: ColumnarTransposition pads with whitespace that leads to output that can include trailing whitespace. I think the cipher would not include whitespace, but without the padding, the decrypt function is harder as it is iterating over ragged column lengths that if unhandled with cause out of bounds errors.

Okay great. To be honest, this was my first Rust project, so apologies for the sloppiness in places. I'll fix up.
I'll have a look at the ColumnarTransposition code and the white space padding. In some tests I ran there was legitimate trailing whitespace. I understand why you included the padding, it makes the subsequent processing so much easier. But, unfortunately, I feel it does create downstream problems. I had a quick go a resolving, but I ran out of time (holidays here in China, and the kids are at home looking for things to do!).
Cheers

Changes to README are in. Nice attention to detail! 👍

Did you want to fix the trailing whitespace issue in another PR? We could always merge this one and create an issue for someone to fix later - up to you though.

Please - another PR for the whitespace, I've run out of time for now and probably won't get back to it until next week. I'll sort that out then. Cheers!
I'll open an Issue.


[Feature Request] Add Support for 1.18.2 Minecraft Version

Hello, as the title says i would like to see compatibility with 1.18.2 minecraft server version, i tried it and got an error on console
https://paste.enginehub.org/ClVlZRcea
Thanks =D

This is honestly something I won't work on, as it would require me to either manage a separate branch for 1.18, or lower the api-version to 1.18, which would result in servers running 1.19 printing a warning about my plugin supporting an outdated api-version, which is something I would like to avoid.
However, the issue can easily be fixed by yourself by changing the api-version in /paper/src/main/resources/plugin.yml to 1.18:
https://github.com/Andre601/AdvancedServerList/blob/ec3b9872787369f8aa21109d933a178c4fd848a3/paper/src/main/resources/plugin.yml#L8
All you need to do after that is run mvn clean install in the root directory of the project and the jar should then be compiled.
Sorry that I can't provide you with another answer, but the negatives outweigh the benefits in the end (Also, 1.19 isn't a bad version either)


UIMenuItem extra properties (Sub Item)?

Currently have Text, Description, can we have extra field?
for Example I need to read a list of item from a database
Example Database:
.Text     .SetRightLabel      .SubItem(index)
AK47   |   $7000    |    ak47ModelNameHere
MG6    |   $12000  |    mg6ModelNameHere

Use a Dictionary<string, WeaponHash>? or WeaponHash.TryParse

i donno, just for example

oops wrong press

hello

I think that's unnecessary. If you want to hold data, use a list, dictionary or whatever you want.


dns_server role enhancement: add ability to set IP addresses for external domains

Scenario:
Cluster with no Internet access.
Many BMCs set to use public NTP servers - too many to change by hand/not possible.
= lots of DNS errors in the logs
Is it possible for the dns_role to have the ability to return an IP for a given host?
E.g. in the example return the cluster's chrony server IP for pool.ntp.org?
@oxedions asked me to tag @btravouillon ;-)

PR is merged, thanks a lot for this feature !


Please consider fixing issues detected by repository checker

Notification from ioBroker Check and Service Bot
Dear adapter developer,
I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter tvprogram for common errors and appropiate suggestions to keep this adapter up to date.
This check is based the current head revisions (master / main  branch) of the adapter repository
Please see the result of the check below.
ioBroker.tvprogram
   -
ERRORS:

[ ] :heavy_exclamation_mark: [E145] Missing mandatory translation into de of some "common.news" in io-package.json.
[ ] :heavy_exclamation_mark: [E157] js-controller 3.3.22 listed as dependency but 4.0.24 is required as minimum, 5.0.19 is recommended. Please update dependency at io-package.json.
[ ] :heavy_exclamation_mark: [E254] Versions "1.1.3-alpha.1, 1.1.3-alpha.0, 1.1.1" listed at common.news at io-package.json do not exist at NPM. Please remove from news section.

WARNINGS:

[ ] :eyes: [W040] "keywords" within package.json should contain "ioBroker"
[ ] :eyes: [W127] Missing suggested translation into uk of "common.titleLang" in io-package.json.
[ ] :eyes: [W134] Missing suggested translation into uk of "common.desc" in io-package.json.
[ ] :eyes: [W154] Missing suggested translation into ru,pt,nl,fr,it,es,pl,uk,zh-cn of some "common.news" in io-package.json.
[ ] :eyes: [W184] "common.main" is deprecated and ignored. Please remove from io-package.json. Use "main" at package.json instead.
[ ] :eyes: [W184] "common.title" is deprecated and replaced by "common.titleLang". Please remove from io-package.json.
[ ] :eyes: [W252] Version of package.json (1.1.3-alpha.1) doesn't match latest version on NPM (1.1.2)

:thumbsup: No suggestions found
Please review issues reported and consider fixing them as soon as appropiate.
Errors reported by repository checker should be fixed as soon as possible. Some of them require a new release to be considered as fixed. Please note that errors reported by checker might be considered as blocking point for future updates at stable repository.
Warnings reported by repository checker should be reviewed. While some warnings can be ignored due to good reasons or a dedicated decision of the developer, most warnings should be fixed as soon as appropiate.
You may start a new check or force the creation of a new issue at any time by adding the following comment to this issue:
@iobroker-bot recheck
@iobroker-bot recreate
Please note that I (and the server at GitHub) have always plenty of work to do. So it may last up to 30 minutes until you see a reaction. I will drop a comment here as soon as I start processing.
Feel free to contact me (@iobroker-bot) if you have any questions or feel that an issue is incorrectly flagged.
And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.
your
ioBroker Check and Service Bot
@mcm1957 for evidence
Last update at Fri, 13 Sep 2024 13:56:10 GMT based on commit ad93901bdb32fd970dc0d1d6a93b7f681f408369
ioBroker.repochecker 3.0.5

This issue has been updated by ioBroker Check and Service Bot
The following issues have been fixed
[W184] "common.main" is deprecated and ignored. Please remove from io-package.json. Use "main" at package.json instead.
:thumbsup:Thanks for fixing the issues.
The following issues are new and have been added
[W184] "common.main" is deprecated and ignored. Please remove from io-package.json. Executable is defined by entry "main" at package.json.


spec-cleaner 0.9.1 requires a never version of re than ships with CentOS 7

spec-cleaner 0.9.1 is not compatible with Python 2.7.5's re which is the version used by CentOS.
The regular expressions introduced in https://github.com/openSUSE/spec-cleaner/commit/2c97233bcd2628ae9034ba48b4e5629257681159, break compatibility with Python 2.7.5
This affects building OpenStack on CentOS based Distros.
I have also filed a bug at Launchpad: https://bugs.launchpad.net/openstack-requirements/+bug/1655509
$ docker run -it --rm centos:7 python
Python 2.7.5 (default, Nov  6 2016, 00:28:07)
[GCC 4.8.5 20150623 (Red Hat 4.8.5-11)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import re
>>> re_configure = re.compile(r'(^|(.*\s)?)./configure($|(\s(.*)?))')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib64/python2.7/re.py", line 190, in compile
    return _compile(pattern, flags)
  File "/usr/lib64/python2.7/re.py", line 242, in _compile
    raise error, v # invalid expression
sre_constants.error: nothing to repeat
>>> re_cmake = re.compile(r'(^|(.*\s)?)cmake($|(\s(.*)?))')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib64/python2.7/re.py", line 190, in compile
    return _compile(pattern, flags)
  File "/usr/lib64/python2.7/re.py", line 242, in _compile
    raise error, v # invalid expression
sre_constants.error: nothing to repeat

It seems to be bug in re honestly. In old version of 3.3 it was also present and fixed as one of the minor bumps.
Maybe reporting it to Redhat would make them fix it in their python?

@scarabeusiv specifically '(.)?' does not work in <2.7.6 python. Using a regex without that is probably the best move here. I ran into this problem about a year ago and the solution was to use a different regex without (.)? rather than have anyone else change anything.
For the record, Ubuntu 12.04 and Debian Wheezy also will have an issue with this

Oky as it is easier here I just tweaked it back, thanks to pointing out what is wrong :)
Hang tight for 0.9.2 release fixing this.


Upload of sparse page blobs should make use of SEEK_HOLE/SEEK_DATA on Linux

Is your feature request related to a problem? Please describe.
A sparse disk image file of 1000GB that is empty will take a very long time to upload as the SDK is scanning the whole file for zeros.
Describe the solution you'd like
The SDK should be more clever and, if available on the OS, use SEEK_HOLE/SEEK_DATA as well to jump over unallocated blocks in the file. Since version 3.3, Python has os.SEEK_HOLE/os.SEEK_DATA.
Describe alternatives you've considered
None.

Hi @letmaik
Thanks for providing the thought to optimize our upload function, we will create an item in backlog to look into that

@xiafu-msft Great, thanks. Do you have a rough estimate on when this improvement would land?

Hi @letmaik, I have picked up your ask from our backlog and will be looking into adding it to our SDK.
We're sorry this was left in our backlog for a while. I will update you once any changes are added to the SDK


Add paginator utility

Adds a paginator utility that takes an interaction and a list of embeds, and paginates them.
It's protected against out-of-bounds scenarios by disabling buttons when at the end or beginning of a list.

In addition, you can customize the button styles and the labels of each button:

You can refer to testCommand.ts for an example of usage.
Closes #26

I made a couple of minor improvements, but this is good to go.


feat: Add named routes support

Something like:
https://groups.google.com/forum/#!topic/express-js/M5BMl4mo1pE
http://stackoverflow.com/questions/12854689/is-it-possible-to-name-routes-in-express-js
Thanks

Hi, great suggested! The issue #2739 is tracking this and PRs are welcome to implement it!


uSubscription as a trait in support of pluggable uStreamer

As @stevenhartley has found by experimenting on uStreamer, it looks like it will make it easier to have a uSubscription trait.
Why?
Because up-streamer-rust (which is generic and should be able to work with any transports) will need to interact with not a concrete implementation of a uSubscription, but in fact some generic representation of one, because there will be different uSubscription implementations per transport.
Tagging in @AnotherDaniel & @sophokles73 for discussion

Hm, going by the implementation in your fork, this does not look horrible ;-)
I am only just getting off the ground with my usubscription component, managed a little 'breakthrough' (by my standards) yesterday, so slowly there emerges a scaffold to hang things on... at the moment I can say this:

I'm also trying to make usubscription transport-agnostic (-pluggable), although not 100% there yet to have a full opinion
being immersed in the usage side of up-rust and all the rest now, I've started some background tasks in my mind wrt how to make this more usable going forward; I haven't gotten as far as you guys yet, but a up-subscription trait that serves as the frond-end for client code interactions fits some of these thoughts (at least I think so at the moment)

Again, I'm late to the party of actually working with all this - so the coming weeks will be needed on my side to flesh out how I feel about all of this.
Right now I'd say let's try this out, let's have the trait - if it needs to change then it can, if we really hate it, or it really should live somewhere else, then we also can address that going forward.

Okay, so based on your feedback, does it make sense for me to add doc comments to the branch for https://github.com/PLeVasseur/uprotocol-rust_fork/pull/1 and open a PR into up-rust as a first step?

Yupp that's what I'd suggest. If the PR is ok for @sophokles73 , then I can immediately also use this in my up-subscription code base, see what it does for me.

Alrighty -- if you're good with me taking a try at it, I'll refine this a bit, add some doc comments and doc tests and then retarget it for up-rust. :+1:

Took a shot at this in #83


auro-badge: create blueprint figma file

General Support Request
The auro-badge requires a blueprint supporting document to be released to Figma. The new element auro-slider has a dependency on this as a defined element for example use.
Support request
Review the current state of the auro-badge design and create the Figma blueprint document.
Possible Solution
Design to review current UI for new design opportunities.
Separating auro-badge and auro-tag due to functionality differences. This will not be reflected 1:1 on the dev and design side. Instead, the design toolkit will have two different components while development treats it as one component with different types.
Exit criteria

[x] complete blueprint work
[ ] signoff from Auro engineering (Jason Baker)
[ ] signoff from UI designers (Vidal Men)
[x] add link completed version of auro-badge blueprint (Link)

Next steps
When this element blueprint is added to the Figma Auro UI Kit, this is intended to be used by the new auro-slider as an example.

Completed blueprint in Figma

@jason-capsule42 Requesting a dev review for the completed blueprint. Please let me know if there is anything to add/edit.

@vidalmenAS Requesting a design review.

This looks great.
FYI others in this thread, it has been discussed that we will probably be deprecating the auro-badge component as it never really caught on and newer conversations around a more comprehensive auro-tag element are in progress.
@leeejune regarding this element, one thing that has been an issue is how to deal with type descenders. E.g. a y or g. The type in this comp is always perfectly centered, but we can't actually recreate that in code because type and line height always account for descenders. This issue was raised by @erikalanghauser in regard to the use of auro-badge in the auro-flightline custom element.
I just want to make sure that we are currently representing this in the blueprint.

Would leaving a note be enough to reflect this? Or is there another preferred way to represent this?

Completed auro-tag blueprint

Added a note about type descenders.

Adding @ geoffcastroAAG to the thread.

auro-tag will have a type called auro-badge to support different functionalities of "Tag" and "Badge" on the design side. On Figma, the two are distinct components. On the engineering side, they will be under the same web component auro-tag. Current auro-badge's color features will be deprecated. The rest of the functions remain the same.

Reviewed + Approved!

Added "Size" property to implement "Small" sized badge. Need @blackfalcon's review.

@leeejun both large and small have the same definitions? Also, what is the border-radius?

@leeejune feedback has been send via Teams for updates.

@blackfalcon Changes made according to the feedback.

This Blueprint file is complete and ready for dev plan.


replace pyusb,pywinusb with fido2's hid abstraction

I'm changing the branch I made this changes on and making a new PR.
I've been having strange problems using libusb for USB HID. I replaced both pyusb and pywinusb with the native USB HID abstractions that are in the fido2 package, and now it seems to work without issue. I'm on MacOS Catalina.
Abstractions are here: https://github.com/Yubico/python-fido2/tree/master/fido2/_pyu2f

Thanks for MacOS support, but now it doesn't work in Linux and in Windows I havent tested yet. I will try to look on it over weekend.


Python 3.13 is stuck on rc2

~ $ uv --version
uv 0.5.1 (Homebrew 2024-11-08)

When I run uv run --python 3.13 python then Python 3.13.0rc2 is started. Why it is still using the release candidate?
~ $ uv python list --only-installed
cpython-3.13.0-macos-aarch64-none<EMAIL_ADDRESS>-> ../Frameworks/Python.framework/Versions/3.13/bin/python3.13
cpython-3.13.0rc2-macos-aarch64-none    .local/share/uv/python/cpython-3.13.0rc2-macos-aarch64-none/bin/python3.13
cpython-3.12.7-macos-aarch64-none<EMAIL_ADDRESS>-> ../Frameworks/Python.framework/Versions/3.12/bin/python3.12
cpython-3.12.6-macos-aarch64-none       .pyenv/versions/3.12.6/bin/python3.12
cpython-3.12.6-macos-aarch64-none       .pyenv/versions/3.12.6/bin/python3 -> python3.12
cpython-3.12.6-macos-aarch64-none       .pyenv/versions/3.12.6/bin/python -> python3.12
cpython-3.11.10-macos-aarch64-none      .local/share/uv/python/cpython-3.11.10-macos-aarch64-none/bin/python3.11
cpython-3.10.15-macos-aarch64-none      .local/share/uv/python/cpython-3.10.15-macos-aarch64-none/bin/python3.10
cpython-3.9.6-macos-aarch64-none        /Library/Developer/CommandLineTools/usr/bin/python3 -> ../../Library/Frameworks/Python3.framework/Versions/3.9/bin/python

I had to run uv python uninstall 3.13 to get rid of the release candidate, and only then did uv run --python 3.13 python run the latest version - the one installed by Homebrew.
Shouldn't uv automatically use the final version over the release candidate? It feels strange that I had to manually install 3.13 for it to use the newer 3.13.

Was the release candidate already installed? Did uv python install 3.13 give you the release candidate after uninstalling? (That should be impossible, we don't even include the RC links in 0.5.1.)

Yeah we'll use a managed versions over system ones (like that homebrew one) and installed versions over available downloads. It looks like you used the release candidate — I think it's reasonable we don't switch the version out from under you without some sort of intervention?

(Arguably, we should automatically upgrade people to the latest patch version of Python somehow, but we do not do that now)

I had the release candidate installed back when that was the newest version, yeah. Since then Homebrew installed 3.13 because one of its packages demands it (I didn't manually brew install python 3.13).
I expected that uv would pick that version.
After running uv python uninstall 3.13 I then ran uv python install 3.13 and yes that gave me the newest version:
~ $ uv python list --only-installed
cpython-3.13.0-macos-aarch64-none<EMAIL_ADDRESS>-> ../Frameworks/Python.framework/Versions/3.13/bin/python3.13
cpython-3.13.0-macos-aarch64-none     .local/share/uv/python/cpython-3.13.0-macos-aarch64-none/bin/python3.13
cpython-3.12.7-macos-aarch64-none<EMAIL_ADDRESS>-> ../Frameworks/Python.framework/Versions/3.12/bin/python3.12
cpython-3.12.6-macos-aarch64-none     .pyenv/versions/3.12.6/bin/python3.12
cpython-3.12.6-macos-aarch64-none     .pyenv/versions/3.12.6/bin/python3 -> python3.12
cpython-3.12.6-macos-aarch64-none     .pyenv/versions/3.12.6/bin/python -> python3.12
cpython-3.11.10-macos-aarch64-none    .local/share/uv/python/cpython-3.11.10-macos-aarch64-none/bin/python3.11
cpython-3.10.15-macos-aarch64-none    .local/share/uv/python/cpython-3.10.15-macos-aarch64-none/bin/python3.10
cpython-3.9.6-macos-aarch64-none      /Library/Developer/CommandLineTools/usr/bin/python3 -> ../../Library/Frameworks/Python3.framework/Versions/3.9/bin/python3

To me it's weird that I had to do this manually.

I think it's reasonable we don't switch the version out from under you without some sort of intervention

Well, going from a release candidate to a final, when I never explicitly asked for a release candidate install anyway, seems reasonable.

we should automatically upgrade people to the latest patch version of Python somehow

That would make sense to me too.

How does one update the installed Python version anyway? Like, I did run uv python install 3.13 when the release candidate was still installed, and it did nothing. It didn't upgrade 3.13 to the final version.
Or let's say 3.13.1 is released, how do I then update to that version? Will running uv python install 3.13 at that point update to 3.13.1? Or do I first have to uninstall 3.13? And what about all my Python projects with a .python-version file that says 3.13. Will they automatically update to 3.13.1 after I run uv python install 3.13? Do I have to specify the patch version in the .python-version file?

let's say 3.13.1 is released, how do I then update to that version? Will running uv python install 3.13 at that point update to 3.13.1?

If you already have 3.13.0 downloaded, then if you run uv python install 3.13 uv will detect that you already have a compatible Python installation that matches the requirement of 3.13 and therefore do nothing. With verbose mode enabled you can see this:
$ uv -v python install 3.13
DEBUG uv 0.5.1 (f399a5271 2024-11-08)
DEBUG Found `cpython-3.13.0-macos-x86_64-none` for request `Python 3.13`

So no, in this case it won't automatically fetch and download version 3.13.1. You would have to specifically state that you want uv python install 3.13.1 or use uv python install 3.13 --reinstall.
$ uv -v python install 3.13 --reinstall
DEBUG uv 0.5.1 (f399a5271 2024-11-08)
DEBUG Ignoring match `cpython-3.13.0-macos-x86_64-none` for request `Python 3.13` due to `--reinstall` flag
DEBUG Found download `cpython-3.13.1-macos-x86_64-none` for request `Python 3.13`

If you run uv python uninstall 3.13 - which would trigger your all downloaded versions matching 3.13 to uninstall - then running uv python install 3.13 would the next time install 3.13.1 straight away. Because in this case it wouldn't find a compatible version meeting the requirement and therefore proceed to download the latest version.
The same goes for your .python-version file. If it states 3.13, then uv will look and see what is the latest version of 3.13 you already have downloaded. It won't go and automatically download the latest version. It just use whatever you already have if that's possible.

I think this looks like it's working correctly -- --reinstall or --upgrade should upgrade, but we shouldn't do it implicitly.

Sounds good. I honestly thought --upgrade existed already, but I was thinking of uv tool install.

I think we're waiting to add --upgrade until we have better behavior around upgrading Python distributions that are in-use by virtual environments.


graphite-api seems to throw 400s overzealously

Hi,
I'm trying to track down what's going on after an upgrade. Using graphite-api 1.1.3 on Debian 12.
All calls return 400s. I'm not sure why.
I tried something like: curl http://<IP_ADDRESS>:8081/metrics/find?query=*, and it gives a 400.
Is this normal behavior? I'm wondering if my test method is off.
Thank you!

I think my problem is with another codebase. Sorry about that!
https://github.com/brutasse/graphite-api/issues/252


Fading out Lua Sprites

Describe your problem here.
Hey! Would there be a Way to Fade out the Lua Sprites, I'm Trying it out right now and it isn't Doing Anything
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
The Mod Team is Only Using Lua, I Dunno Why

``function onEvent(name, value1, value2)
if name == 'Event name' then
duration = tonumber(value1);
if duration < 0 then
duration = 0;
end
	targetAlpha = tonumber(value2);
	if duration == 0 then
		setProperty('objectname.alpha', targetAlpha);
	else
		doTweenAlpha('amogusnotfunni', 'objectname', targetAlpha, duration, 'linear');
	end
end

end

function onEvent(name, value1, value2)
if name == 'Event name' then
duration = tonumber(value1);
if duration < 0 then
duration = 0;
end
	targetAlpha = tonumber(value2);
	if duration == 0 then
		setProperty('objectname.alpha', targetAlpha);
	else
		doTweenAlpha('amogusnotfunni', 'objectname', targetAlpha, duration, 'linear');
	end
end

end
This might help

`function onEvent(name, value1, value2)
if name == 'Event name' then
duration = tonumber(value1);
if duration < 0 then
duration = 0;
end
	targetAlpha = tonumber(value2);
	if duration == 0 then
		setProperty('objectname.alpha', targetAlpha);
	else
		doTweenAlpha('name', 'objectname', targetAlpha, duration, 'linear');
	end
end

end`

Probs a custom event. Also I recommend getting a source coder and keeping your main coder and label him as the lua coder. The source coder is good to get incase you wanna change the main menu, title screen, story menu, or freeplay menu in any way that isn't possible in lua like moving the logo in the middle and removing gf or adding a sprite in main menu, story menu, or freeplay menu. But most importantly dialogue or a cutscene. So make the dialogue in game than add it to the data and go into play state and add the code for starting the dialogue there. Same with cutscene besides making it and and putting it in data. Lua coders are good for the main focus of the engine. Characters, charting, events, notetypes, stages, and etc.

doTweenAlpha


Old-style classes interfere with returning strings

I have no idea how to solve this one, but when trying to return strings from a function decorated with an @threads, rather than executing, it simply errors. Code below to reproduce:
def download_nm(delimiter, source, dump):
    images = [line.split(delimiter)[10] for line in open(source)][1:]  # avoid header row
    with open(dump, 'a') as sink:
        for i, image in enumerate(images):
            results = return_image_json(image)  # type(results) == <type 'instance'>
            sink.write(results)  # Error, expected string or buffer

@threads(16)
def return_image_json(image_link):
    response = requests.get(image_link)
    encoded = "data:%s;base64,%s" % (response.headers['Content-Type'], base64.b64encode(response.content))
    return json.dumps({image_link: encoded}) + '\n'

It looks like moving to new-style classes resolves this issue, but since you're relying on some of the syntax-hacks of old-style classes I'm not sure if this is solvable.

Did more digging into this error. Seems that tomorrow breaks if any type-checking whatsoever is done on the resulting object. So passing the results into most any library function should break.

Super valid complaint.  It's actually unrelated to the kind of class being used -- it's simply that calls to isinstance and type(obj) don't actually trigger a __getattr__ call.
You can fix this by doing literally anything to the result object before calling a function that checks the results type.  I would recommend calling tomorrow._wait() explicitly in these circumstances.  Simplified example below:
import base64
import json

from tomorrow import threads
import requests

def save_image_json(images, filename):
    with open(filename, 'a') as sink:
        for i, image in enumerate(images):
            results = return_image_json(image)
            sink.write(results)

@threads(4)
def return_image_json(image_link):
    response = requests.get(image_link)
    encoded = "data:%s;base64,%s" % (response.headers['Content-Type'], base64.b64encode(response.content))
    return json.dumps({image_link: encoded}) + '\n'

if __name__ == "__main__":
    # koala images
    images = [
        'http://i.imgur.com/1p5nKyZ.jpg',
        'http://i.imgur.com/lDt3nJ8.jpg',
        'http://i.imgur.com/hkUeCBT.jpg',
        'http://i.imgur.com/ZglSElj.jpg'
    ]
    save_image_json(images, filename='koalas.json')

I'm going to look into forcing isinstance and type to trigger resolution of the future, but I'm not entirely certain this is possible.

if I have the error after run code，what I get is all the Tomorrow class. Is there any method to deal with it？


Fix learn more link to open another tab

Description
Fixes # 180
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] User Interface
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have npm run format before commiting
[x] I replicated the UI with the Design

ScreenShots (if any)

thanks for the PR @Neeteshking21
LGTM!

@kaiwalyakoparkar  can you please review this?

@kaiwalyakoparkar


Minor errors on expectation over transformation notebook

Describe the bug
There are some errors while running the notebook in https://github.com/Trusted-AI/adversarial-robustness-toolbox/blob/main/notebooks/expectation_over_transformation_classification_rotation.ipynb
The first one is that the following part is wrong
from art.classifiers import TensorFlowV2Classifier

It returns ModuleNotFoundError: No module named 'art.classifiers'
I could fix it in the following way
import art.estimators.classification as abc
 abc.TensorFlowV2Classifier()

The other error happens at the end of the notebook. The correction is below:
x_adv_eot = attack_eot.generate(x=np.expand_dims(x,axis=0), y=y_target)

System information (please complete the following information):

Linux
Python 3.8
ART 10.1
TensorFlow 2.4

Hi @anselmoferreira Thank you very much for reporting this issue! I agree, the import for TensorFlowV2Classifier needs to be updated.
Would you be interested to make a pull request for the updated notebook?

Hi @anselmoferreira Thank you very much for reporting this issue! I agree, the import for TensorFlowV2Classifier needs to be updated.
Would you be interested to make a pull request for the updated notebook?

Yes, I will. Just give me some time. Thank you!


Ability to use only fine-grained token with actions

By using gh API commands in the bin/check-duplicates.sh file, it is now possible to use only fine-grained tokens.
It is now possible to run the actions with only one fine-grained github token. I chose to keep REPO_ACCESS and removed the NIXPKGS_TOKEN reference in the action files

The action fails 🤔

I just ran the "update changes" action in my test branch and the action succeeded :/
It's the first time I'm dealing with actions so I don't exactly know how to troubleshoot it
Is it possible that it uses my token because it is from my branch or that your REPO_ACCESS token doesn't support action / is expired ?
As I understood it, NIXPKGS_TOKEN was a gh key for the repo (that could be a fine-grained one) and REPO_ACCESS had to be a legacy gh token because some gh command might need graphQL (and only legacy tokens are supported atm).
But I might be wrong and NIXPKGS_TOKEN is something else. (in that case I will revert the changes done to the action files)

I didn't knew that if I push something to my main branch it will update this PR. I will close it for now.
If you want I can redo the PR on a specific branch to contribute back

I don't know too much about actions myself. Honestly, I am happy that it works; I don't think it is super important that this is as secure as possible.
However, I certainly do appreciate any help on this, so don't feel discouraged. But I am afraid I cannot help you with any details on why exactly this actions is setup as it it.

No problem, when I have some time I will try to see what might be the cause.
When I pulled a commit from your branch into mine I got the same token error in the action so I will search in this direction.


README: Table of Contents

Context
This README could use a table of contents to allow easy/instant navigation to the relevant section.
Changes

added a table of contents

this is using the "markdown all-in-one" plugin for vscode, which I use pretty regularly for all my READMEs

heading format and arrangement

title-case all headings. I'm not sure if this is going too far or altering the original ALL CAPS vibe of the headings, but I find title/camel case generally easier on the eyes
rearrange headings to be more hierarchical

Thanks, Tom!

Cheers mate, stoked you like it! I have a couple more ideas for the readme, pretty much just tidying up the bottom sections with some slight style adjustments.


Improve varint encoding throughput with unrolled loop

Second try at this, I've added all the benchmark code and selected the top performing encoding loop (the unrolled loop) on a variety of platforms. The test produces a distribution of integers that favors small and negative integers, of which small integers more so, since a big use case for this is to encode e.g. length of an array, string, or bit set. The Blackhole tests write to an OutputStream adapter for a Blackhole object, so that the compiler does not optimize away the lack of use of the output. The ByteString tests use the existing ByteStringOutputStream to reflect the consequences for real uses of this.
All tests were executed with a JDK 21 release.
x86-64 (Intel Haswell)
Benchmark                                                 Mode  Cnt           Score         Error  Units
VarIntBenchmark.encodeDoLoopBlackhole                    thrpt   25    91363908.455 ± 1028792.699  ops/s
VarIntBenchmark.encodeDoLoopByteString                   thrpt   25    50548932.989 ± 6074517.818  ops/s
VarIntBenchmark.encodeDoLoopTwiddleBlackhole             thrpt   25   116402268.752 ± 3603776.825  ops/s
VarIntBenchmark.encodeDoLoopTwiddleByteString            thrpt   25    36670590.967 ±  409015.501  ops/s
VarIntBenchmark.encodeLoopBlackhole                      thrpt   25   168611086.404 ± 1326173.181  ops/s
VarIntBenchmark.encodeLoopByteString                     thrpt   25    38176858.648 ±  302810.404  ops/s
VarIntBenchmark.encodeUnrolledBlackhole                  thrpt   25   427173311.707 ± 2843652.971  ops/s
VarIntBenchmark.encodeUnrolledByteString                 thrpt   25    76080516.198 ± 1733183.347  ops/s
VarIntBenchmark.singleByteEncodeDoLoopByteString         thrpt   25   780650734.907 ± 6097388.892  ops/s
VarIntBenchmark.singleByteEncodeDoLoopTwiddleByteString  thrpt   25   706896985.619 ± 6815684.460  ops/s
VarIntBenchmark.singleByteEncodeLoopByteString           thrpt   25<PHONE_NUMBER>.288 ± 9434393.825  ops/s
VarIntBenchmark.singleByteEncodeUnrolledByteString       thrpt   25<PHONE_NUMBER>.027 ± 8241663.978  ops/s

x86-64 (Intel Skylake)
Benchmark                                                 Mode  Cnt          Score         Error  Units
VarIntBenchmark.encodeDoLoopBlackhole                    thrpt   25   85522300.489 ±  507182.636  ops/s
VarIntBenchmark.encodeDoLoopByteString                   thrpt   25   51786339.926 ±  652379.318  ops/s
VarIntBenchmark.encodeDoLoopTwiddleBlackhole             thrpt   25  102082971.841 ±  596369.624  ops/s
VarIntBenchmark.encodeDoLoopTwiddleByteString            thrpt   25   37699402.162 ±  283047.578  ops/s
VarIntBenchmark.encodeLoopBlackhole                      thrpt   25  172018270.955 ± 1520544.862  ops/s
VarIntBenchmark.encodeLoopByteString                     thrpt   25   34553387.089 ±  229986.587  ops/s
VarIntBenchmark.encodeUnrolledBlackhole                  thrpt   25  402915952.520 ± 6423653.533  ops/s
VarIntBenchmark.encodeUnrolledByteString                 thrpt   25   69586822.886 ±  448196.667  ops/s
VarIntBenchmark.singleByteEncodeDoLoopByteString         thrpt   25  745308809.259 ± 4885814.194  ops/s
VarIntBenchmark.singleByteEncodeDoLoopTwiddleByteString  thrpt   25  608806027.462 ± 2857508.766  ops/s
VarIntBenchmark.singleByteEncodeLoopByteString           thrpt   25  928856531.647 ± 4072410.196  ops/s
VarIntBenchmark.singleByteEncodeUnrolledByteString       thrpt   25  928543205.153 ± 4319585.652  ops/s

x86-64 (AMD Rome)
Benchmark                                                 Mode  Cnt          Score          Error  Units
VarIntBenchmark.encodeDoLoopBlackhole                    thrpt   25  123204915.841 ±   465877.673  ops/s
VarIntBenchmark.encodeDoLoopByteString                   thrpt   25   44072083.020 ± 12567598.952  ops/s
VarIntBenchmark.encodeDoLoopTwiddleBlackhole             thrpt   25  150683316.254 ±   846832.099  ops/s
VarIntBenchmark.encodeDoLoopTwiddleByteString            thrpt   25   44719733.007 ± 11296208.141  ops/s
VarIntBenchmark.encodeLoopBlackhole                      thrpt   25  301293285.937 ±  1005547.629  ops/s
VarIntBenchmark.encodeLoopByteString                     thrpt   25   33245953.475 ±   535105.314  ops/s
VarIntBenchmark.encodeUnrolledBlackhole                  thrpt   25  362186083.508 ±  1499794.449  ops/s
VarIntBenchmark.encodeUnrolledByteString                 thrpt   25   71576604.553 ±   315081.403  ops/s
VarIntBenchmark.singleByteEncodeDoLoopByteString         thrpt   25  712163772.828 ±  3970392.503  ops/s
VarIntBenchmark.singleByteEncodeDoLoopTwiddleByteString  thrpt   25  676866242.466 ±  3079666.362  ops/s
VarIntBenchmark.singleByteEncodeLoopByteString           thrpt   25  713840995.347 ±  3629284.012  ops/s
VarIntBenchmark.singleByteEncodeUnrolledByteString       thrpt   25  715269682.199 ±  3603390.673  ops/s

AArch64 (Ampere Altra)
Benchmark                                                 Mode  Cnt          Score          Error  Units
VarIntBenchmark.encodeDoLoopBlackhole                    thrpt   25  112679724.135 ±  2062187.803  ops/s
VarIntBenchmark.encodeDoLoopByteString                   thrpt   25   35515917.017 ±  6951804.869  ops/s
VarIntBenchmark.encodeDoLoopTwiddleBlackhole             thrpt   25  125060394.102 ±   630292.295  ops/s
VarIntBenchmark.encodeDoLoopTwiddleByteString            thrpt   25   32037842.165 ±   123755.020  ops/s
VarIntBenchmark.encodeLoopBlackhole                      thrpt   25  286536916.042 ±  1884502.344  ops/s
VarIntBenchmark.encodeLoopByteString                     thrpt   25   29421856.524 ±    72523.600  ops/s
VarIntBenchmark.encodeUnrolledBlackhole                  thrpt   25  337454124.761 ±   297026.167  ops/s
VarIntBenchmark.encodeUnrolledByteString                 thrpt   25   56205527.872 ±  8349285.386  ops/s
VarIntBenchmark.singleByteEncodeDoLoopByteString         thrpt   25  655880295.197 ±   324276.379  ops/s
VarIntBenchmark.singleByteEncodeDoLoopTwiddleByteString  thrpt   25  552379656.507 ± 11504123.544  ops/s
VarIntBenchmark.singleByteEncodeLoopByteString           thrpt   25  737085425.684 ±   412676.068  ops/s
VarIntBenchmark.singleByteEncodeUnrolledByteString       thrpt   25  736918644.246 ±   516196.399  ops/s

AArch64 (Apple M1 Pro)
Benchmark                                                 Mode  Cnt          Score          Error  Units
VarIntBenchmark.encodeDoLoopBlackhole                    thrpt   15  255762269.772 ±  1936301.235  ops/s
VarIntBenchmark.encodeDoLoopByteString                   thrpt   15   92070021.391 ±   231006.921  ops/s
VarIntBenchmark.encodeDoLoopTwiddleBlackhole             thrpt   15  275594462.558 ±   415451.028  ops/s
VarIntBenchmark.encodeDoLoopTwiddleByteString            thrpt   15   71425250.074 ±   581033.665  ops/s
VarIntBenchmark.encodeLoopBlackhole                      thrpt   15  431213450.958 ±  2778545.953  ops/s
VarIntBenchmark.encodeLoopByteString                     thrpt   15   85565524.194 ±    41168.798  ops/s
VarIntBenchmark.encodeUnrolledBlackhole                  thrpt   15  557690428.746 ±  1000945.227  ops/s
VarIntBenchmark.encodeUnrolledByteString                 thrpt   15  148073371.323 ±   139152.954  ops/s
VarIntBenchmark.singleByteEncodeDoLoopByteString         thrpt   15  487760431.638 ±  4243492.375  ops/s
VarIntBenchmark.singleByteEncodeDoLoopTwiddleByteString  thrpt   15  486854230.146 ±  4056558.449  ops/s
VarIntBenchmark.singleByteEncodeLoopByteString           thrpt   15  484208552.095 ± 14475945.013  ops/s
VarIntBenchmark.singleByteEncodeUnrolledByteString       thrpt   15  487350383.023 ±  4249040.461  ops/s

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[x] Update CHANGES.md with noteworthy changes.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Run Java PreCommit

Run Java PreCommit

assign set of reviewers

Run Java PreCommit

Run Java_IOs_Direct PreCommit

Note to self: Perform integration benchmarks to verify the instruction bloat does not negatively affect cache behavior.

Run Java PreCommit

@Abacn or @damccorm I'll merge this in 24 hours to let anyone express any concerns.

@damondouglas Thanks for reviewing this. I haven't had the time yet to to run Nexmark to compare the existing implementation against this implementation using somewhat realistic uses of this code.
I'll be able to get that going over the weekend with results early next week. Might be worth holding off a merge until then to make sure this isn't just performing well on synthetic benchmarks.

No problem, @sjvanrossum. Please let me know when you are ready.

@damondouglas spotbugsMain reported two fields were unused, which don't get cleaned up by spotlessApply. After removing the two fields spotbugsMain reports no remaining issues.
I ran Nexmark on the base commit for this PR and the latest commit in this PR and (as expected) there's no noteworthy increase or decrease in performance overall, I just wanted to validate that the improvements we're seeing on the micro benchmark aren't causing issues outside of that scope due to the increase in code size that comes with unrolling.

@sjvanrossum Could you confirm this as well?
The two failing tests referenced from https://ge.apache.org/s/jwl3x4lvysvzc: 1) :sdks:java:fn-execution:test and 2) :runners:spark:3:test passed for me from https://github.com/sjvanrossum/beam/tree/varint-performance clone.
Once you confirm on your end, I'm ready to squash/merge.

I ran both of them on my laptop (macOS on M1) and workstation (Linux on AMD) and they completed successfully.

@damondouglas I synchronized the PR branch with master.
:runners:java-fn-execution:test is still failing with InterruptedException in CI (passing locally) and :runners:spark:3:test is passing in CI now (https://ge.apache.org/s/bva2psun2yk3s).

@sjvanrossum I'm ready to merge after your go-ahead.
I compared ./gradlew :runners:java-fn-execution:test at the latest 22fefebacab commit and yours 08dba68933 and both passed, despite https://ge.apache.org/s/wqgqr4uvnjb56 citing it as failing.

@damondouglas seems good to me then 👍


Follow-up to #1740 - various issues and broken modules

With the big #1740 merged and the Omega lineup of modules tweaked there are some smaller things we get to start working on now, yay! :sparkles: Considering the magnitude of the changes the game is looking pretty good :-) No trouble in multiplayer that I noted, for instance.
Notes

Post-merge engine build: http://jenkins.terasology.org/job/Terasology/1433/
Post-merge Omega 166 zip: http://jenkins.terasology.org/job/DistroOmega/166/artifact/distros/omega/build/distributions/TerasologyOmega.zip (broken - item below in the bugs list)
Should we reintroduce a BlockManager.AIR block of some sort or is that bad? I added a @In blockManager a couple places and did a getBlock to compare with air in a few more modules
Need @synopia for some Pathfinding review, although I think all unit tests and working locally, just broken in Jenkins from environment issues
Need @MarcinSc for some computer review - we fixed up some of the modules, are the fixes acceptable? Two more remain broken in part from the engine PR that was delayed due to the big merge (BlockFamily / side stuff). Marcin please let us know what else on the engine side you run into that might need fixing :-)
Need @small-jeeper for Rails - it is pretty broken, but could be put on vacation from the lineup (no integration with anything else)
I did version increments in lots of places when adding -SNAPSHOT but just patch level. Probably minor would be more right at least in some places, but for the sake of expediency and all that + not formally in release management land yet. I did have a bit of a related breakthrough, but no time tonight to pursue it further
@flo I increased the minVersion in a few places where it seemed unlikely an older version would've been appropriate, making maxVersion no longer needed. We'll probably need this more seriously later, right now increasing min seems a non-issue

Broken modules

[ ] Signalling
[ ] ComputerMonitors
[ ] Rails

Bugs

[ ] Attempting to fill a wooden bucket in TTA causes index out of bounds crash (probably in trying to retrieve/customize the updated bucket icon?) - we've seen that one before. Didn't grab a log, but easy to replicate with giveItem woodenbucket in the console + go scoop some water
[ ] Stall on startup in JoshariasSurvival, stack thrown during char spawn (1). Didn't happen a second time though. Later on leaving a reloaded game got another stack but no crash/stall (2)
[ ] Crash on world gen in L&S over seed not set yet - yet clearly some seed is set based on how LASMapGenerator looks, huh (3)
[ ] Odd crash starting a game with some misc modules enabled (4) - module/asset scanning? Hit it again later on trying to join a headless server. I wonder if this might relate to having crashed instances of the game idling in the background - if so it may be a non-issue (or maybe we could catch it better?)
[ ] Unrelated probably split out: If you kill a wandering deer its highlighted target square never un-highlights (Pathfinding or WildAnimals fix?) - just noticed and had it in my notes
[ ] Cities worldgen doesn't register: o.t.w.g.i.WorldGeneratorManager - class org.terasology.cities.CityWorldGenerator marked to be registered as a World Generator, but is not a subclass of WorldGenerator or lacks the correct constructor - @msteiger ?
[ ] Weird sandbox denial on game startup: o.t.module.sandbox.ModuleClassLoader - Denied access to class (not allowed with this module's permissions): org.terasology.logic.spawner.Spawner (related to new player spawning?)
[ ] Crash on startup from binary download (Omega 166) - permission/asset issue? @immortius ? Same with exe and straight jar (5)
[ ] It can take a nice chunk of time to scan for assets (at least from source) - might be ways to optimize further or perhaps just update the status message ("Scanning for assets - may take a little while" ?) if we want to live with it for a while, it does work eventually :-)

(1)
21:13:38.091 [Chunk-Generator-5] INFO  o.t.w.b.internal.BlockManagerImpl - Registered Block core:GreenLeaf with id 59
21:13:38.155 [Chunk-Generator-6] INFO  o.t.w.b.internal.BlockManagerImpl - Registered BlockFamily[core:OakTrunk]
21:13:38.155 [Chunk-Generator-6] INFO  o.t.w.b.internal.BlockManagerImpl - Registered Block core:OakTrunk with id 60
21:13:38.397 [Chunk-Generator-4] ERROR o.t.u.concurrency.TaskProcessor - Error in thread Chunk-Generator-4
java.lang.NullPointerException: null
	at org.terasology.world.block.Block.setCollision(Block.java:597) ~[classes/:na]
	at org.terasology.world.block.internal.BlockBuilder.constructCustomBlock(BlockBuilder.java:135) ~[classes/:na]
	at org.terasology.world.block.internal.BlockBuilder.constructTransformedBlock(BlockBuilder.java:116) ~[classes/:na]
	at org.terasology.world.block.family.HorizontalBlockFamilyFactory.createBlockFamily(HorizontalBlockFamilyFactory.java:53) ~[classes/:na]
	at org.terasology.world.block.loader.BlockFamilyDefinition.createFamily(BlockFamilyDefinition.java:67) ~[classes/:na]
	at org.terasology.world.block.internal.BlockManagerImpl.loadFamily(BlockManagerImpl.java:271) ~[classes/:na]
	at org.terasology.world.block.internal.BlockManagerImpl.getBlockFamily(BlockManagerImpl.java:239) ~[classes/:na]
	at org.terasology.world.block.internal.BlockManagerImpl.getBlock(BlockManagerImpl.java:297) ~[classes/:na]
	at org.terasology.core.world.generator.trees.TreeGeneratorCactus.generate(TreeGeneratorCactus.java:35) ~[na:na]
	at org.terasology.core.world.generator.rasterizers.TreeRasterizer.generateChunk(TreeRasterizer.java:57) ~[na:na]
	at org.terasology.world.generation.WorldImpl.rasterizeChunk(WorldImpl.java:64) ~[classes/:na]
	at org.terasology.world.generation.BaseFacetedWorldGenerator.createChunk(BaseFacetedWorldGenerator.java:77) ~[classes/:na]
	at org.terasology.world.chunks.localChunkProvider.LocalChunkProvider$4.run(LocalChunkProvider.java:631) ~[classes/:na]
	at org.terasology.utilities.concurrency.TaskProcessor.run(TaskProcessor.java:50) ~[classes/:na]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [na:1.8.0_45]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [na:1.8.0_45]
	at java.lang.Thread.run(Thread.java:745) [na:1.8.0_45]
21:13:38.497 [Chunk-Generator-2] INFO  o.t.w.b.internal.BlockManagerImpl - Registered BlockFamily[core:Cactus]
21:13:38.498 [Chunk-Generator-2] INFO  o.t.w.b.internal.BlockManagerImpl - Registered Block core:Cactus.LEFT with id 61
21:13:38.498 [Chunk-Generator-2] INFO  o.t.w.b.internal.BlockManagerImpl - Registered Block core:Cactus.RIGHT with id 62

(2)
21:19:29.246 [main] WARN  o.t.w.internal.WorldProviderCoreImpl - Attempted to access unavailable chunk via block at -69, -12, -46
21:19:29.246 [main] WARN  o.t.w.internal.WorldProviderCoreImpl - Attempted to access unavailable chunk via block at -69, -13, -46
21:19:36.610 [Chunk-Updater-3] ERROR o.t.u.concurrency.TaskProcessor - Error in thread Chunk-Updater-3
java.lang.NullPointerException: null
	at org.terasology.world.chunks.internal.ChunkImpl.getSunlight(ChunkImpl.java:206) ~[classes/:na]
	at org.terasology.world.chunks.internal.ChunkImpl.getSunlight(ChunkImpl.java:201) ~[classes/:na]
	at org.terasology.world.internal.ChunkViewCoreImpl.getSunlight(ChunkViewCoreImpl.java:141) ~[classes/:na]
	at org.terasology.world.internal.ChunkViewCoreImpl.getSunlight(ChunkViewCoreImpl.java:116) ~[classes/:na]
	at org.terasology.rendering.primitives.ChunkTessellator.calcLightingValuesForVertexPos(ChunkTessellator.java:181) ~[classes/:na]
	at org.terasology.rendering.primitives.ChunkTessellator.generateOptimizedBuffers(ChunkTessellator.java:116) ~[classes/:na]
	at org.terasology.rendering.primitives.ChunkTessellator.generateMesh(ChunkTessellator.java:69) ~[classes/:na]
	at org.terasology.rendering.world.ChunkMeshUpdateManager$ChunkUpdateTask.run(ChunkMeshUpdateManager.java:169) ~[classes/:na]
	at org.terasology.utilities.concurrency.TaskProcessor.run(TaskProcessor.java:50) ~[classes/:na]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [na:1.8.0_45]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [na:1.8.0_45]
	at java.lang.Thread.run(Thread.java:745) [na:1.8.0_45]
21:19:36.651 [main] INFO  o.t.p.i.ReadWriteStorageManager - Saving - Creating game snapshot
21:19:36.652 [main] INFO  o.t.p.i.ReadWriteStorageManager - Saving - Snapshot created: Writing phase starts
21:19:36.652 [main] INFO  o.t.n.internal.NetworkSystemImpl - Client disconnected: Cervator
21:19:36.653 [main] INFO  o.t.logic.console.ConsoleImpl - [NOTIFICATION] Player "Cervator" has left the game

(3)
21:24:24.477 [main] INFO  o.t.e.m.l.InitialiseWorld - World seed: "wzobxM5aubjKD7DcdqJcp7YlwUksYDXf"
21:24:24.615 [main] ERROR o.terasology.engine.TerasologyEngine - Uncaught exception, attempting clean game shutdown
java.lang.IllegalStateException: Seed has not been set
	at org.terasology.world.generation.WorldBuilder.build(WorldBuilder.java:86) ~[classes/:na]
	at org.terasology.ligthandshadow.logic.LASMapGenerator.setWorldSeed(LASMapGenerator.java:93) ~[na:na]
	at org.terasology.engine.modes.loadProcesses.InitialiseWorld.step(InitialiseWorld.java:107) ~[classes/:na]
	at org.terasology.engine.modes.StateLoading.update(StateLoading.java:237) ~[classes/:na]
	at org.terasology.engine.TerasologyEngine.mainLoop(TerasologyEngine.java:458) ~[classes/:na]
	at org.terasology.engine.TerasologyEngine.run(TerasologyEngine.java:384) ~[classes/:na]
	at org.terasology.engine.Terasology.main(Terasology.java:151) [classes/:na]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.8.0_45]
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[na:1.8.0_45]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:1.8.0_45]
	at java.lang.reflect.Method.invoke(Method.java:497) ~[na:1.8.0_45]
	at com.intellij.rt.execution.application.AppMain.main(AppMain.java:140) [idea_rt.jar:na]
21:24:24.616 [main] INFO  o.terasology.engine.TerasologyEngine - Shutting down Terasology...

(4)
21:26:54.975 [main] INFO  o.terasology.engine.TerasologyEngine - Initialization completed in 8.79sec.
21:26:56.215 [main] WARN  o.t.engine.internal.TimeBase - Delta too great (36241056), capping to 1000
21:28:26.456 [main] WARN  org.reflections.Reflections - given scan urls are empty. set urls in the configuration
21:28:26.463 [main] INFO  o.t.e.m.loadProcesses.RegisterMods - Activating module: engine:0.54.0-SNAPSHOT
21:28:26.463 [main] INFO  o.t.e.m.loadProcesses.RegisterMods - Activating module: Breathing:0.1.1-SNAPSHOT
21:28:26.463 [main] INFO  o.t.e.m.loadProcesses.RegisterMods - Activating module: CakeLie:0.1.1-SNAPSHOT
21:28:26.463 [main] INFO  o.t.e.m.loadProcesses.RegisterMods - Activating module: MusicDirector:0.2.1-SNAPSHOT
21:28:26.463 [main] INFO  o.t.e.m.loadProcesses.RegisterMods - Activating module: ChrisVolume1OST:0.2.1-SNAPSHOT
21:28:26.463 [main] INFO  o.t.e.m.loadProcesses.RegisterMods - Activating module: Core:0.54.0-SNAPSHOT
21:28:26.463 [main] INFO  o.t.e.m.loadProcesses.RegisterMods - Activating module: CoreSampleGameplay:0.54.0-SNAPSHOT
21:28:26.463 [main] INFO  o.t.e.m.loadProcesses.RegisterMods - Activating module: Fences:0.1.1-SNAPSHOT
21:28:26.463 [main] INFO  o.t.e.m.loadProcesses.RegisterMods - Activating module: FunnyBlocks:0.1.1-SNAPSHOT
21:28:26.463 [main] INFO  o.t.e.m.loadProcesses.RegisterMods - Activating module: Hunger:0.1.1-SNAPSHOT
21:28:26.463 [main] INFO  o.t.e.m.loadProcesses.RegisterMods - Activating module: MarkovChains:1.5.1-SNAPSHOT
21:28:26.463 [main] INFO  o.t.e.m.loadProcesses.RegisterMods - Activating module: NameGenerator:0.4.1-SNAPSHOT
21:28:26.463 [main] INFO  o.t.e.m.loadProcesses.RegisterMods - Activating module: Oreons:0.2.1-SNAPSHOT
21:28:26.463 [main] INFO  o.t.e.m.loadProcesses.RegisterMods - Activating module: Pathfinding:0.1.1-SNAPSHOT
21:28:26.464 [main] INFO  o.t.e.m.loadProcesses.RegisterMods - Activating module: Spawning:0.1.1-SNAPSHOT
21:28:26.464 [main] INFO  o.t.e.m.loadProcesses.RegisterMods - Activating module: Portals:0.1.1-SNAPSHOT
21:28:26.464 [main] INFO  o.t.e.m.loadProcesses.RegisterMods - Activating module: TutorialWorldGeneration:0.1.1-SNAPSHOT
21:28:26.464 [main] INFO  o.t.e.m.loadProcesses.RegisterMods - Activating module: Valentines:0.1.1-SNAPSHOT
21:28:26.464 [main] INFO  o.t.e.m.loadProcesses.RegisterMods - Activating module: WildAnimals:0.1.1-SNAPSHOT
21:28:26.959 [main] ERROR o.terasology.engine.TerasologyEngine - Uncaught exception, attempting clean game shutdown
java.nio.file.ClosedWatchServiceException: null
	at sun.nio.fs.AbstractWatchService.checkOpen(AbstractWatchService.java:80) ~[na:1.8.0_45]
	at sun.nio.fs.AbstractWatchService.poll(AbstractWatchService.java:97) ~[na:1.8.0_45]
	at org.terasology.module.filesystem.ModuleWatchService.poll(ModuleWatchService.java:61) ~[gestalt-module-4.0.2.jar:4.0.2]
	at org.terasology.assets.module.ModuleWatcher.checkForChanges(ModuleWatcher.java:132) ~[gestalt-asset-core-4.0.2.jar:4.0.2]
	at org.terasology.assets.module.ModuleAwareAssetTypeManager.reloadChangedOnDisk(ModuleAwareAssetTypeManager.java:164) ~[gestalt-asset-core-4.0.2.jar:4.0.2]
	at org.terasology.engine.TerasologyEngine.mainLoop(TerasologyEngine.java:438) ~[classes/:na]
	at org.terasology.engine.TerasologyEngine.run(TerasologyEngine.java:384) ~[classes/:na]
	at org.terasology.engine.Terasology.main(Terasology.java:151) [classes/:na]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.8.0_45]
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[na:1.8.0_45]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:1.8.0_45]
	at java.lang.reflect.Method.invoke(Method.java:497) ~[na:1.8.0_45]
	at com.intellij.rt.execution.application.AppMain.main(AppMain.java:140) [idea_rt.jar:na]
21:28:26.960 [main] INFO  o.terasology.engine.TerasologyEngine - Shutting down Terasology...

(5)
01:03:44.440 [main] ERROR org.terasology.assets.AssetType - Failed to load asset 'engine:UITexture'
java.security.PrivilegedActionException: null
	at java.security.AccessController.doPrivileged(Native Method) ~[na:1.8.0_45]
	at org.terasology.assets.AssetType.reload(AssetType.java:323) [gestalt-asset-core-4.0.2.jar:4.0.2]
	at org.terasology.assets.AssetType.getNormalAsset(AssetType.java:352) [gestalt-asset-core-4.0.2.jar:4.0.2]
	at org.terasology.assets.AssetType.getAsset(AssetType.java:232) [gestalt-asset-core-4.0.2.jar:4.0.2]
	at org.terasology.assets.management.AssetManager.getAsset(AssetManager.java:206) [gestalt-asset-core-4.0.2.jar:4.0.2]
	at org.terasology.assets.management.AssetManager.getAsset(AssetManager.java:186) [gestalt-asset-core-4.0.2.jar:4.0.2]
	at org.terasology.assets.management.AssetManager.getAsset(AssetManager.java:170) [gestalt-asset-core-4.0.2.jar:4.0.2]
	at org.terasology.asset.Assets.get(Assets.java:80) [engine-0.54.0-SNAPSHOT.jar:1433, develop, 1433, pre-alpha]
	at org.terasology.asset.Assets.getMaterial(Assets.java:226) [engine-0.54.0-SNAPSHOT.jar:1433, develop, 1433, pre-alpha]
	at org.terasology.rendering.nui.internal.LwjglCanvasRenderer.<init>(LwjglCanvasRenderer.java:108) [engine-0.54.0-SNAPSHOT.jar:1433, develop, 1433, pre-alpha]
	at org.terasology.engine.subsystem.lwjgl.LwjglGraphics.postInitialise(LwjglGraphics.java:125) [engine-0.54.0-SNAPSHOT.jar:1433, develop, 1433, pre-alpha]
	at org.terasology.engine.TerasologyEngine.postInitSubsystems(TerasologyEngine.java:295) [engine-0.54.0-SNAPSHOT.jar:1433, origin/develop, 1433]
	at org.terasology.engine.TerasologyEngine.<init>(TerasologyEngine.java:188) [engine-0.54.0-SNAPSHOT.jar:1433, origin/develop, 1433]
	at org.terasology.engine.Terasology.main(Terasology.java:122) [Terasology.jar:1433, origin/develop, 1433]
Caused by: java.io.IOException: Unable to resolve shader 'engine:uiTexture'
	at org.terasology.rendering.assets.material.MaterialFormat.load(MaterialFormat.java:72) ~[engine-0.54.0-SNAPSHOT.jar:1433, develop, 1433, pre-alpha]
	at org.terasology.rendering.assets.material.MaterialFormat.load(MaterialFormat.java:47) ~[engine-0.54.0-SNAPSHOT.jar:1433, develop, 1433, pre-alpha]
	at org.terasology.assets.module.UnloadedAssetData$AssetSourceResolver.load(UnloadedAssetData.java:292) ~[gestalt-asset-core-4.0.2.jar:4.0.2]
	at org.terasology.assets.module.UnloadedAssetData.load(UnloadedAssetData.java:180) ~[gestalt-asset-core-4.0.2.jar:4.0.2]
	at org.terasology.assets.module.ModuleAssetDataProducer.getAssetData(ModuleAssetDataProducer.java:228) ~[gestalt-asset-core-4.0.2.jar:4.0.2]
	at org.terasology.assets.AssetType.lambda$reload$1(AssetType.java:325) [gestalt-asset-core-4.0.2.jar:4.0.2]
	at org.terasology.assets.AssetType$$Lambda$42/1463022229.run(Unknown Source) ~[na:na]
	... 14 common frames omitted
01:03:44.441 [main] ERROR o.terasology.engine.TerasologyEngine - Failed to initialise Terasology
java.util.NoSuchElementException: No value present
	at java.util.Optional.get(Unknown Source) ~[na:1.8.0_45]
	at org.terasology.rendering.nui.internal.LwjglCanvasRenderer.<init>(LwjglCanvasRenderer.java:108) ~[engine-0.54.0-SNAPSHOT.jar:1433, develop, 1433, pre-alpha]
	at org.terasology.engine.subsystem.lwjgl.LwjglGraphics.postInitialise(LwjglGraphics.java:125) ~[engine-0.54.0-SNAPSHOT.jar:1433, develop, 1433, pre-alpha]
	at org.terasology.engine.TerasologyEngine.postInitSubsystems(TerasologyEngine.java:295) ~[engine-0.54.0-SNAPSHOT.jar:1433, origin/develop, 1433]
	at org.terasology.engine.TerasologyEngine.<init>(TerasologyEngine.java:188) ~[engine-0.54.0-SNAPSHOT.jar:1433, origin/develop, 1433]
	at org.terasology.engine.Terasology.main(Terasology.java:122) [Terasology.jar:1433, origin/develop, 1433]
01:03:44.441 [main] INFO  o.terasology.engine.TerasologyEngine - Shutting down Terasology...

I wouldn't count on loading game working well for now. I found about 3-4 issues with it and will create issues once I get some time and proper internet access, and that was with old code, so new one might have introduced more stuff.

Yep we are expecting further issues. Some were fixed during the big PR. The more we identify the more we can fix :-)
Will appreciate it!

(4) Is possibly a threading issue related to environment switch, depending when it occurs. Will investigate but would be easier with instructions to reproduce if it is consistent.
(5) Ignore the PrivilegedActionException (I probably need to filter that out), the important bit is the inner exception (shader not found) and the following exception. Is the uiTexture shader asset being included in the distro correctly?

Just a mental note, in case someone wants to take a look at it, before I manage to create proper issues.

Block entities without components that require persistence get stored, if they are active when save is made.
Entities with component that has a collection of @ManagedContainer objects throw exception when getting deserialized (with old asset code, did not check new one).
Block entities in the same chunk are getting loaded and have their lifecycle events called one by one. As a result, if during OnActivatedComponent of a block entity I make a call to get an entity of another block (that was persisted), I will get default (from prefab) entity for that block.
When block entities have their lifecycle events called upon loading chunk, it's impossible to get any block from that chunk.
PreBegin method of ComponentSystem is called after world is loaded, which is the opposite of what the javadoc for that method says.

(4) is not consistent :-( Encountered it twice. I suspect it might only occur if there is a crashed version of the game holding file watchers in some bad state, and you run a new game instance on top.
(5) I see assets/shaders/ui/[stuff] in the engine jar packaged with the zip, yep. Includes uitexture.info, uitexture_frag.glsl, uitexture_vert.glsl. Material file seems to be there too.

(5) On further investigation, apparently the reflections.cache in engine has list the GLSLShaderFormat as being marked with the RegisterAssetFileFormat annotation, which results it not being set up and shaders not being discovered.

@MarcinSc On your number 5, I intend to improve the initialisation code shortly, and will attempt to deal with issues like these as part of that. Please let me know of any similar issues.

I have created issues from my list - #1763 #1764 #1765 #1766 and #1767 with some more detail (where available and needed).

Signalling and ComputerMonitors should compile after my PR #1768 gets accepted.

I spent some more time investigating (5). Still not sure is going wrong - the same code outside of the gradle context works correctly, so something odd in there I guess. Perhaps we need to encapsulate the reflections caching into a gradle plugin or some such?
Easy fix for now is to turn off the compile time caching of reflections and allow it to be calculated at runtime, although this obviously comes with a load time cost.

Investigated (4). Error occurred if an asset reload check occurs after the module environment is changed and the old environment shut down, but the asset manager hasn't been switched to the new environment yet. I've patched the issue in #1769 but this is just another indication of the need to revisit the core engine handling of initialisation and game lifecycle. Will start this next.

Fantastic!

Closing this as resolved, split out, or likely fixed over time without more specific poking


glyph icons

Any idea why the glyphicons do not display in outlook? opening the page in an internet browser works fine

I have the same problem which also reduces the functionality of the taskboard. Would love to figure this out...

I have been investigating this issue, and I am really really puzzled. It turns out that editing the html file causes the icon to disappear, even if you rollback your changes and having no differences between the edited file and the original one (and I proved they are equal by doing a binary comparison). The only thing that appears to work is editing it online on Github and download it again. That way of working will keep the icons being displayed. This is the weirdest issue I have ever seen....

@janvv
I am also puzzled over this problem.
I replaced the <link rel="stylesheet" href="css/bootstrap.min.css"> for <link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap.min.css"> in kanban.html
And now in outloook the icons are displayed correctly.
But only if you refresh via the right mouse button. If you refresh via F5, the problem remains.


[REQ] Additional keyboard function keys

Could someone add the ability to use additional function keys that were present on older and specialty keyboard?
F13-F18
#define KEY_F13				0x68
#define KEY_F14				0x69
#define KEY_F15				0x6A
#define KEY_F16				0x6B
#define KEY_F17				0x6C
#define KEY_F18				0x6D
I have tried adding this myself, but have limited knowledge with Arduino libraries.
I try to press F15, and I get "j" rather than the press of F15.

Turns out the values are wrong.
These are the correct ones:
#define KEY_F13	0xF0 // 0x68 + 0x88
#define KEY_F14	0xF1 // 0x69 + 0x88
#define KEY_F15	0xF2 // 0x6A + 0x88
#define KEY_F16	0xF3 // 0x6B + 0x88
#define KEY_F17	0xF4 // 0x6C + 0x88
#define KEY_F18	0xF5 // 0x6D + 0x88
Sorry. Closing.


Fixing the failing build

I went to start using this package today but ran into a few issues straight away...

.ImproperlyConfigured: Specifying a namespace in include() which appears to be fixed (https://github.com/dj-paddle/dj-paddle/pull/18) but is not on pip yet
When running djpaddle_sync_plans_from_paddle I was getting malformed API response. "response" missing. without any more information. It turns out my Vendor ID was copied badly but I was not getting the correct error - Again it appears to be fixed (https://github.com/dj-paddle/dj-paddle/pull/12) but not on pip yet

In other words I was hoping to get a new version on pip so I don't have to monkey patch the above.
I then noticed that the builds were failing on Travis so I decided to fix it all up as I thought that could be a blocker?
There are quite a few changes.

A lot of it is import and linting fixes automatically done by black and isort
I've tried to change as little code as possible. I did move some bits in utils to settings as I felt it would be better for it to fail on load
Improved test coverage. Please check the tests are OK as it's been a long time since I wrote unittest style tests not straight pytest

Please take a look and let me know what you think

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@e912092). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #20   +/-   ##
=========================================
  Coverage          ?   97.84%
=========================================
  Files             ?        8
  Lines             ?      186
  Branches          ?       17
=========================================
  Hits              ?      182
  Misses            ?        0
  Partials          ?        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e912092...0b1565f. Read the comment docs.

@FPurchess 👍
I've put back in pop before the update_or_create


FutureWarning: Setting an item of incompatible dtype is deprecated and will raise an error in a future version of pandas.

Which version are you running? The lastest version is on Github. Pip is for major releases.
pandas_ta V
0.3.14b0
Do you have TA Lib also installed in your environment?
YES
Have you tried the development version? Did it resolve the issue?
NO
Describe the bug
A clear and concise description of what the bug is.
FutureWarning: Setting an item of incompatible dtype is deprecated and will raise an error in a future version of pandas.
pandas is not allowing mix of data, so it is requesting a cast,
`
Value '891.4783225765763' has dtype incompatible with int64, please explicitly cast to a compatible dtype first.
df = ta.ma(name, df[applyTo], length=val)
\0            NaN
1            NaN
2            NaN
3            NaN
4            NaN
5            NaN
6            NaN
7            NaN
8            NaN
9            NaN
10           NaN
11           NaN
12     891.47832
13    1739.77306
14    2525.27395
15    3261.01269
`
To Reproduce
calling the following function will procduce the error above
`def allMaUtils(self, name="ema", df=df, val=7, applyTo='close'):
df = ta.ma(name, df[applyTo], length=val)
return df
`
Expected behavior
to return what has been reported to solve the problem pandas
Thanks for using Pandas TA!
Thank you Guys

Hello @esteban2006

Have you tried the development version? Did it resolve the issue?
NO

Install the development version to resolve this like you were asked to do above.
Kind Regards,
KJ


Remove stream js in playable concern

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1021

Relevant Lines:
1021

💛  - Coveralls


Remove bad practice of writing process.env.DEBUG

In some projects an error occurs when building node.js applications with webpack.
It's a bad practice to write environment variables inside javascript, in my opinion. Environment variables should always be set by the environment. So the current solution should be refactored by using an own global variable with a fallback/default value of the process.env.DEBUG environment variable.
After this is fixed the problem will never appear again. Or is there any specific reason why you have to write process.env?
Some related issues:
https://github.com/visionmedia/debug/issues/301
https://github.com/mrsteele/dotenv-webpack/issues/271

Writing environment variables is not a "bad practice", wherever did you get this idea?
Closing as there's nothing actionable here. The fact webpack bakes process.env has always been a weird feature, and not one I want to tiptoe around personally.
Sorry if this isn't the answer you're looking for.

@Qix- I think this would be an easy fix and would solve this issue finally for a lot of people. Would it be fine for you if one is creating a PR for it?

No, this is not something I'm interested in changing, sorry.

Ok, now I'm very interested in the reason. Because as I understand it will not change how the library works, it wouldn't break anything, so what speaks against changing it, if not even you have to put effort in it?

The only place it's happening is with save(). I'm not going to change that because it's part of the public API and would incur a major version release, which is not at all ready yet because v5 will be almost a complete rewrite.
So there is no worth in "fixing" this now. Further, I staunchly disagree with the idea that modifying environment variables is "bad practice". This is, quite literally, their intended purpose, and the reason why they're called "environment" variables is that they are inherited by subprocesses via exec syscalls. If they weren't meant to be modified, then the setenv() libc call wouldn't exist.
I would imagine save() gets removed entirely in v5. Don't quote me on that though. That would "fix" Webpack's incorrect usage of process.env for this package, but keep in mind that any other package that modifies environment variables is going to choke too. Please don't confuse webpack's behavior as "correct", because it's not. It's a hack.

Thank your for your large response and all those information. I totally agree that webpack's behavior is a hack but you cannot just say that it is valid to change env vars on runtime, just because there is a function in libc for doing it.
This function does probably exist for some low level code or CLI tools, but maybe I'm wrong - I don't see any other reason why you should ever want to use something like this in a real application.
Anyway, we don't have to discuss about this topic for hours. Let's close it here. I'm looking forward to v5. :)

I had another idea which might work for all of us. What about doing something like this:
process['env'].DEBUG = namespaces;

Then the DefinePlugin would not match the string process.env anymore. WDYT?

There's nothing dynamic there, and that would violate our linter's rules. There's nothing stopping the bundler from constant folding that statement either.
This just isn't going to happen, sorry. Perhaps ask Webpack to allow you to disable their hacks?


Improve handling of Cypher syntax errors

A syntax error in Cypher code sent to the /execute endpoint results in a Java exception that is reported to the client as a HTTP 500 error, with the server log containing the actual error message and stack dumps.
Why not catch the syntax error in a try block and return it to the client as part of the HTTP 500 response?

This would require the creation of a debug/development mode. Returning the trackback in production is a security risk.

Aha, understood!

Although I wasn't thinking of returning the traceback, just the error message, for example:
Variable `external` not defined (line 18, column 14 (offset: 1443))
"      RETURN external, end_housing_external LIMIT 10"

Hrm. That might be useful. Not sure if 500 error is the right thing to return. Maybe a 400 error? Or is 400 reserved only for issues with the HTTP request itself?

I think 500 is the right error code but will check. I've pretty well got this working, so expect a pull request.

You are correct. From Wikipedia:

400 Bad Request
The server cannot or will not process the request due to an apparent client error (e.g., malformed request syntax, size too large, invalid request message framing, or deceptive request routing).


Unable to login succesfully

Hi @poeticninja. We are trying to run your example but have come across an issue where we are unable to set cookie object. We think this is where the problem is :
L50
And this is the error from the console :

We hope you can help out. Thanks

I just ran a clean install of this project and it worked. I cloned the repo into a new directory, ran npm install, I am on Node 5.1.1, and no problems doing the login with Postman (https://www.getpostman.com/).
Did you modify any of the code in the project or change the dependencies in the package.json to a newer version?

We haven't used Postman because we added view with the form here. package.json looks the same as ours, we only added few dependencies for view rendering. The only difference is that I am using node 4.1. I will update node and see if that might be an issue.

I'm getting the same error, running node 4.2.4.
The issue I suspect is request.auth.session.set(user), as noted by OP....  Doing a print out of the request object's '.auth' there is no 'session'.  "request.auth.session" is undefined.
I also get the same error running /logout with the 'request.auth.session.clear()'. "Cannot read property 'clear' of undefined".
Any suggestions?

I can confirm that the difference is in Hapi's version.
'"Starting with Hapi 12 the request.session placeholder was removed."
It is now in a plugin known as 'Yar' (https://github.com/hapijs/yar).
Using Yar I was able to overcome the login and logout errors.  However, I don't believe the session is properly being set as when I go to a protected route I get a 'Missing authentication' message.
Any ideas?
Thank you.

I'm submitting a pull request. In this pull request there are several changes as es5 to es6 style , refactoring and updating dependecies. But it retains the original idea. Now this example Hapijs work with version 12.1.0. I apologize for my english.


Integrate Dart Formatter directly into ts2dart for cleaner output

and more readable test cases.
Not sure if the way I integrated dart-style.d.ts is the right but it works.

ptal

Looks pretty good. Could you check out my other comment above?
Also: in this project's package.json, you should now have a dependency on dart-style - did you run npm install dart-style --save?

Merged as c43031f.


Reproduction test.

I somehow come to this problem in my program where I use GoogleSheets library. Can you please confirm that this isn't the wanted behavior.
I think problem might be somewhere in update_ets_entry or load_spreadsheet which returns version, but I'm not sure.
I'd happily do implementation that fixes it, but will need some input/help. Anyhow, I'm going to vacation for 14 days now so if I don't answer ... this is why :)

Thanks for the test case!
Found the root cause for the issue, which was that the list of worksheet names wasn't taken into account when calculating the hash used as a version for a spreadsheet. Pushing new version to hex and fix is in commit https://github.com/GrandCru/GoogleSheets/commit/7e540018dd9fc10a4291fa34e01a12f380c0fccf

Thanks!


Refactor ParserVisitor

We need the visitor to allow control over whether to recurse or not into
something. This change makes the old ParserVisitor class behave much more
like the newer IR Walkers.
We need this for the tokens refactor because IR lowering will not be just
a trivial visitor anymore in the future.

bbeb485405911351f590f7389d7f4f461f445125


[website]fix: release note anchor jumper

Signed-off-by: LiLi<EMAIL_ADDRESS>
(If this PR fixes a github issue, please add Fixes #<xyz>.)
Fixes #
fix: release note anchor jumper not incorrectly
Master Issue: #
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Describe the modifications you've done.
Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API: (yes / no)
The schema: (yes / no / don't know)
The default values of configurations: (yes / no)
The wire protocol: (yes / no)
The rest endpoints: (yes / no)
The admin cli options: (yes / no)
Anything that affects deployment: (yes / no / don't know)

Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?

[ ] doc-required
(If you need help on updating docs, create a doc issue)

[ ] no-need-doc
(Please explain why)

[x] doc
(If this PR contains doc changes)

@RobertIndie PTAL


Nightly build broke due to outdated CMake version

Since https://github.com/apache/tvm/commit/8c88aab77863e43985318c575a2fa648fc783338 TVM requires CMake version 3.18 or higher which led to failing CI jobs in the tlcpack repo. While the latest CMake version is installed into the containers (see centos_install_cmake.sh) the System version of CMake is used instead of the manually installed one.
To fix the CI up to 5 steps are required:

Update centos_install_cmake.sh to add the installed CMake version to the SYSTEM path. Alternative: build a specific version of CMake from source similarly to https://github.com/apache/tvm/blob/main/docker/install/ubuntu_install_cmake_source.sh
Build new Docker images using the fix
Tag a new version for the newly build images on Dockerhub (Optional if we just want to use the SHA1 of the latest image instead)
Update https://github.com/tlc-pack/tlcpack/blob/main/.github/workflows/wheel_manylinux_nightly.yaml#L20:L30 etc. to use the updated images

2 and 3 will happen automatically with https://github.com/tlc-pack/tlcpack/actions/runs/3275287205, so once that's done we can update the images in the workflows

@driazati Should I then just use tlcpack/package-cpu:bf872ef etc. or can we create a tag for this such as v0.6?

just the hash is probably fine, the version number doesn't add much meaning imo


Add small detail to 'Image' platform widget documentation

Please add the small detail that users need to prefix the Image URL with 'https://' for it to work. Took me 6 hours to get this working because of the small detail :)

Thank you for this suggestion. I have added this information to Image documentation, and we are investigating this requirement.


B-17616 TOO Can Edit SIT Entry Date (formatted date with UTC)

B-17616 TOO Can Edit SIT Entry Date
Summary
Added javascript function to consider UTC when implementing date formatting. It was returning the day prior in the UI, but was correct in the database (database said 31 Oct 23 but UI would say 30 Oct 23, for example).
Additional story to follow to update SIT panel upon SIT entry date update.

Warnings

:warning:
Please add the JIRA issue key to the PR title (e.g. MB-123)

:warning:

Files located in legacy directories (src/shared or src/scenes) have
been edited. Are you sure you don’t want to also relocate them to the new file structure?
View the frontend file org ADR for more information

  Generated by :no_entry_sign: dangerJS against 0e31400a0a68fb4d1ddd105560fe67222f60b6ff


Typo in the README.md

Description
There is a typo in the README.md file under the Github actions section for Docs Status
it reads

checkout source files, duild doc files, deploy

should be

Checkout source files, build doc files, deploy

Screenshots

Additional Context
Join Eddie's discord community here

Thank you for raising the issue 👍


[Polygon] Updated paraswap to V5

[x] deployed and comment address
[x] Add to dsa-connect here
[ ] update to docs

Deployed on Polygon: 0x7f4466Faf06A2CA3b10e806cC21E2280E5Ef3D8f


Sans-IO MultiPartParser

While this PR doesn't add any asyncio code, the motivation here is making it easier to support asyncio in the form parser, which is the major piece of synchronous-only code in werkzeug.
The idea here is to rewrite the parser to be force-fed pieces of buffer by something else. MultiPartParser's existing, synchronous API is then implemented by reading a file and feeding it in. This does necessitate making all parser state explicit, but the total LOC change is surprisingly light.
An effort to add async support might subclass MultiPartParser, and the only change required would be to drive the basic parsing logic with data acquired asynchronously.
One thing I'm not very happy with is that we need to keep parse_multipart_headers, as part of the documented API, despite the fact that we can't use it.

Nice work.
One other complication here that I'm not sure how to tackle best is that stream_factory presents a blocking interface onto file I/O. Really you also want those operations to happen asynchronously.

Yeah. asyncio provides no standard way to deal with files asynchronously, so I expect we'll just have to invoke synchronous write operations via the executor. I do need to think about how to split that out cleanly, though.

Makes sense - Helps that we’d be able to pass a custom stream_factory argument for the async case.
I’d be interested in seeing this implementation in Starlette https://github.com/encode/starlette too - since it doesn’t yet support form parsing.

I've pulled out the bit that touches files into another class.
Regarding Starlette, you're welcome to it and I can try to remember to make a PR there when this is done with, but if I were you I'd take advantage of being async-only and write a natively async implementation.

Sorry for taking so long. This looks good.
Would you add more comments to the code so it's easier to maintain later? For example, there's a lot of intermediate blocks and methods that are used in the parser, and it would be nice to know what string is being parsed at that point and what gets produced. It would also be good to document the "entry points" for parsing so another developer could understand when and how to override these classes.

You mention keeping parse_multipart_headers. Can the code in the function be replaced with the new interface, or is there some other difference that we need to maintain?

I guess we can implement parse_multipart_headers in terms of the new stuff. :)

Going to close this in favor of a second pass (#1788). Some MLH Fellowship members are interested in tackling this, so it will hopefully get some more progress soon.


ChangeLog creation 0.9.0

in case any merges still happens, I will need to update the ChangeLog again


Add Template and Action classes and tests

@jaapio thanks for the review; I have fixed your feedback and added the missing test for the Template class (had forgotten to commit that in the initial commit facepalm)

looks good, Wercker should be able to pass? think you need a rebase here. But can be merged without that.


Search about the format requirements

In order to solve #132 we need to search about the format requirements: type of the laTEX template, parts, style...

I have focus my search on arXiv articles since the majority of the paper I used in my memory came from this organization.
Source: Submission guidelines
Requirements:

Registration
Give lisense to arXiv, agreement... (see Submission guidelines)

Submission preparation

The text is going to be sumbitted in LaTeX format (see)

Figures format: PS, EPS, JPEG, GIF, PNG or PDF (using packages such as graphics or graphicx)

File names a-z A-Z 0-9 _ + - . , =

Ancillary files could be

Raw data for tables and plots in the article
Program code
Additional images or movies
Workbooks and spreadsheets

And an example of structure is:
/article.tex
/figure1.pdf
/anc/my_program.cpp

Metadada
Source Title and Abstract Field
Required field on the web submitions form:

Title
Authors
Abstract
Comments
Category
DOI: (Question: We need a DOI?)
MSC class or ACM class (Questions this paper is both?)

See more requeriments at the provided source.
Article structure
I have not found any structure or template restriction.
Some articles example are:
Book style paper
Simple model in one page
Two column paper
The structure should be:

Title
Authors
Abstract
Introduction
Related work
Algorithm

Description
Convergence proof

Experiment

Result

Conclusion
References

The template could be selected later, according to @JJ @JavierMeri criteria, I think two columns paper are easier to read.

I have submission privs in certain topics, not in others. Neural networks and all that is OK.
We can use a simple article template. If you use LNCS or suchlike, it will be reje4cted. Overleaf offers many templates for anything.


Refactor Box select; Lasso(Polygon) Select for Non-Rectangular Region

[x] Refactor: As a fisheries scientist, John wants to select a box on the echogram display, so that he can focus on a specific region of interest and examine the Sv within that area for fish analysis.
[ ] To do: As a fisheries scientist, John wants to use the lasso tool to select a polygon on the echogram, so that he can precisely define an irregular region of interest and analyze the Sv within that polygon to identify fish species and their spatial distribution.
[ ] To do: As a fisheries scientist, John wants to export the dataset that is sliced by the selected box or polygon, so that he can save the specific Sv values within that region to a separate file for further analysis or sharing with colleagues.

Fisheries scientists collaborate with colleagues to verify species identifications in different regions. However, the current functionality of the system does not allow me to plot a histogram specifically for non-rectangular polygon regions. Therefore, I would like to propose a new feature that enables users to plot a histogram based on a non-rectangular polygon region, allowing to analyze the distribution of "hake" in these areas accurately.
Users should be able to select a non-rectangular polygon region.
Relavant reference: lasso select in holoviews

Warning appears when plotting real-time bounds from box select in VS Code:
See: https://github.com/holoviz/holoviews/issues/5731

Hey @ldr426 : What do you think if you split this issue into 2: one focuses on using a rectangular area (a box) and the other focuses on using a polygon area, with each of them having the (a) selection and (b) data export component? This way in the current Refactoring milestone you could just focus on the box one, and push the polygon one to the next milestone?

This is issue was split and the remaining parts about polygon select are separate issues now #118, #124. So closing!


Can't have Sass @import inside a conditional

According to this issue putting a SASS @import inside a conditional is not allowed (can only import plain CSS in conditional).
This is my error when compiling application.scss with Sass 3.4.21:
Error: Import directives may not be used within control directives or mixins. on line 9 of .../src/sass/components/_icons.scss

Oh no :confused: well, I guess I saw that coming, although it used to work.
The only solution I can think of now is to move that import to application.scss. Fortunately, browsers don't load external fonts until they are necessary.
@maedi: Would you like to create a PR with that change? Or if you have a better idea that's most welcome. I need help with supporting this project as I don't use Redmine anymore. :sweat:


Update debug

Signed-off-by: Matteo Collina<EMAIL_ADDRESS>
Checklist

[x] run npm run test and npm run benchmark
[x] documentation is changed or added
[x] commit message and code follows the Developer's Certification of Origin
and the Code of conduct

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.71%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
385

Relevant Lines:
385

💛  - Coveralls


feat: Single approach to user creation via AuthService::signup

Q
A

Is bugfix?
❌

New feature?
✔

I think it's best to move it to common, so we don't have duplicate settings.

Sketch ready. Any comments?
I will fix config:

config/common/users.php
tests

👍


Is there any functionality to get every ones cart. As its store in session.

I want to get every single cart store from different browsers. is it possible.

kindly explain with some example

I need to add a functionality to display favorite products  in my website. the logic for this is to display all the cart and wishlist's content. means display the cart and wishlist of every user for guest on my website. because this pkg don't store cart or wishlist in database. I can't use Cart::all();
do you have any solution. or i have to store every cart and wishlist in db as well when storing it using session(this package).


enthesitis

Please add:
enthesitis
DEF: inflammation of the entheses, the sites where tendons or ligaments insert into the bone; the entheses are any point of attachment of skeletal muscles to the bone, where recurring stress or inflammatory autoimmune disease can cause inflammation or occasionally fibrosis and calcification
SYN: enthesopathy
SYN: pathologic condition involving the entheses
From  J:217720
DEF SOURCE:
https://en.wikipedia.org/wiki/Enthesitis
Thanks
Anna

New term added
enthesitis MP:0013942


fix: Do not disable built-in ruler Ctrl+Drag to measure

Fix for #15961.
Examining the history of this method I suspect leaving this check was an oversight after checks for token were added elsewhere in the file.

This would appear to introduce a new bug rather than fixing anything.

This would appear to introduce a new bug rather than fixing anything.

It definitely restores the built-in Ctrl+Drag behavior and doesn't seem to break the PF2E system token drag. What do you think it breaks?

I just tested it by removing the method (you don't need an override just to super up), and it does not enable the original ctrl-drag behavior.

Ugh, the dreaded 'it works on my machine.' I'll try to document exactly what I'm doing/observing.

Foundry 12.331, Chrome 130.0.6723.92

Checkout commit 515c1a062fc92b78887a2f0ff7f9026864ee0c8b (from master)

Run npm ci, npm run build, npm run watch (with a Windows symbolic link set up instead of npm run link)

Create a new world

Create a new scene in the world

Use the Token Controls, Select Tokens tool:

With the PF2E system setting for drag measurement (Never/Always, being sure to click 'Save Changes' after updating it), hold left-CTRL and click+drag with left mouse button:
Never: Works as expected

Always: Does not work

Update ruler.ts, deleting canMeasure() as suggested, refresh browser:
Never: Still works as expected

Always: Now works as expected

I don't claim that removing the override is the right fix because I don't know what other situations canMeasure() is called in, but the change definitely fixes the observed problem.

Had a second person check this, and while it starts the initial drag with CTRL held down, it doesn't enable full standard CTRL measurement. A new PR is up to fully reintegrate the core feature with drag measurement.