Support your own queries (for custom things like full text queries)

Well... We could do that easily if we had access to functionality like the "toType" function, the one that takes (columns []gmq.Column, rb []sql.RawBytes). It just does the hard work for you.
There has to be some way to do outlandish queries onto a type, having modelq trust you that you're returning the right columns to it. Even if it's just a blaobjs.Query("query here") that returns a _BlaQuery so you can start outputting results. It doesn't have to support any more Filters or anything.

This message was created automatically by mail delivery software.
A message that you sent could not be delivered to one or more of its
recipients. This is a temporary error. The following address(es) deferred:
<EMAIL_ADDRESS>Domain reulen.nl has exceeded the max emails per hour (10/5 (200%)) allowed.  Message will be reattempted later
------- This is a copy of the message, including all the headers. ------
Received: from mail-ob0-f171.google.com ([<IP_ADDRESS>]:35794)
by fyvie.footholds.net with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128)
(Exim 4.86_1)
(envelope-from<EMAIL_ADDRESS>id 1alcsO-0007pp-UW
for<EMAIL_ADDRESS>Thu, 31 Mar 2016 14:43:09 +0100
Received: by mail-ob0-f171.google.com with SMTP id fp4so23195882obb.2
for<EMAIL_ADDRESS>Thu, 31 Mar 2016 06:42:49 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:delivered-to:date:dkim-signature:from:reply-to
:to:message-id:subject:mime-version:content-transfer-encoding
:precedence:list-id:list-archive:list-post:list-unsubscribe;
bh=N4z9LGKfCTZQ3inUZJmsAG79yicpRBzUTI4MVe0RQHo=;
b=cF+VKnNcM5VwgrTAwCAPGZFzAe+1aSPbsD+gU7P/uMDYNa4R5ppboO98o+On3/r8XT
5AZGqEgaEig2THJ7QlSznziDaNDtLXqmBTC5xl6/CHx3bjdCOq3l0UwBT+eENr0Ie+94
huox/tZP4UtvhztXPWWHUZJjYjaiTgyuUh/7nl4+hIDLmrYLJXGu2SuwP5tEauylS1Ay
+sHhLy26GMTNoddEPRjoy4ygwVIDzKZEMCutdZuyegHPd13LzTBM7x3ou1ByyCjAz9AU
Gs4RUdFudCdNKwASpvwNBHNeN9KvNNid8Q0aY0C53dcutRbTA2WNrcZJPI2KhBpuJPjv
p0IA==
X-Gm-Message-State: AD7BkJJMlXWAexDU6LGtkP+t7+yAYTx2EbIIQqsWi1ZFk0q8B44B/PJYAsQb6BAj8jYJHrunrIhiiHSIma6DwZo9GSFIvn4=
X-Received: by <IP_ADDRESS> with SMTP id yw3mr8192134obb.45.1459431748260;
Thu, 31 Mar 2016 06:42:28 -0700 (PDT)
X-Forwarded-To<EMAIL_ADDRESS>X-Forwarded-For<EMAIL_ADDRESS><EMAIL_ADDRESS>Delivered-To<EMAIL_ADDRESS>Received: by <IP_ADDRESS> with SMTP id 94csp131213ots;
Thu, 31 Mar 2016 06:42:27 -0700 (PDT)
X-Received: by <IP_ADDRESS> with SMTP id a197mr16221039qkb.43.1459431747197;
Thu, 31 Mar 2016 06:42:27 -0700 (PDT)
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2-ext3.iad.github.net. [<IP_ADDRESS>])
by mx.google.com with ESMTPS id g131si7775684qhd.79.2<IP_ADDRESS>.42.27
for<EMAIL_ADDRESS>(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Thu, 31 Mar 2016 06:42:27 -0700 (PDT)
Received-SPF: pass (google.com: domain of<EMAIL_ADDRESS>designates <IP_ADDRESS> as permitted sender) client-ip=<IP_ADDRESS>;
Authentication-Results: mx.google.com;
dkim=pass (test mode<EMAIL_ADDRESS>spf=pass (google.com: domain of<EMAIL_ADDRESS>designates <IP_ADDRESS> as permitted sender<EMAIL_ADDRESS>dmarc=pass (p=NONE dis=NONE) header.from=github.com
Date: Thu, 31 Mar 2016 06:42:26 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com;
s=pf2014; t=1459431746;
bh=N4z9LGKfCTZQ3inUZJmsAG79yicpRBzUTI4MVe0RQHo=;
h=From:Reply-To:To:Subject:List-ID:List-Archive:List-Post:
List-Unsubscribe:From;
b=CrlkOD74XMmPtDsn+/ctgpPwAS7AOSNLsXp1SZ7Z0e6TQUPX6BJmWoBBnQRt7yiwb
U/uFmGMkH5NhElMYIFOo4pmgZQiQG9WWbJaDsrtDn54gvk+JPoQ+ILE/FRjAsSZ4ll
0JLBB9C9J+qwrgDuDAyiCup4Ex1pW7beLcoazL88=
From: sinni800<EMAIL_ADDRESS>Reply-To: mijia/modelq<EMAIL_ADDRESS>To: mijia/modelq<EMAIL_ADDRESS>Message-ID<EMAIL_ADDRESS>Subject: [mijia/modelq] Support your own queries (for custom things like full
text queries) (#19)
Mime-Version: 1.0
Content-Type: multipart/alternative;
boundary="--==_mimepart_56fd2942e3bc3_7d503fe9f79ab2a01838d5";
charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: sinni800
X-GitHub-Recipient: Gys
List-ID: mijia/modelq <modelq.mijia.github.com>
List-Archive: https://github.com/mijia/modelq
List-Post<EMAIL_ADDRESS>List-Unsubscribe<EMAIL_ADDRESS>https://github.com/notifications/unsubscribe/AA5kk5FK0IqHTSNxWPz4dUERBxjyMrpLks5py89CgaJpZM4H8xqT
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address<EMAIL_ADDRESS>----==_mimepart_56fd2942e3bc3_7d503fe9f79ab2a01838d5
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Well... We could do that easily if we had access to functionality like the "toType" function, the one that takes (columns []gmq.Column, rb []sql.RawBytes). It just does the hard work for you.
There has to be some way to do outlandish queries onto a type, having modelq trust you that you're returning the right columns to it. Even if it's just a blaobjs.Query("query here") that returns a _BlaQuery so you can start outputting results. It doesn't have to support any more Filters or anything.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mijia/modelq/issues/19
----==_mimepart_56fd2942e3bc3_7d503fe9f79ab2a01838d5
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Well... We could do that easily if we had access to functionality like the "toType" function, the one that takes (columns []gmq.Column, rb []sql.RawBytes). It just does the hard work for you.
There has to be some way to do outlandish queries onto a type, having modelq trust you that you're returning the right columns to it. Even if it's just a blaobjs.Query("query here") that returns a _BlaQuery so you can start outputting results. It doesn't have to support any more Filters or anything.
—You are receiving this because you are subscribed to this thread.Reply to this email directly or view it on GitHub

----==_mimepart_56fd2942e3bc3_7d503fe9f79ab2a01838d5--

You can easily use custom template for generation code and add this functionality

This message was created automatically by mail delivery software.
A message that you sent could not be delivered to one or more of its
recipients. This is a temporary error. The following address(es) deferred:
<EMAIL_ADDRESS>Domain reulen.nl has exceeded the max emails per hour (11/5 (220%)) allowed.  Message will be reattempted later
------- This is a copy of the message, including all the headers. ------
Received: from mail-ob0-f181.google.com ([<IP_ADDRESS>]:36727)
by fyvie.footholds.net with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128)
(Exim 4.86_1)
(envelope-from<EMAIL_ADDRESS>id 1alcvk-00017y-El
for<EMAIL_ADDRESS>Thu, 31 Mar 2016 14:46:36 +0100
Received: by mail-ob0-f181.google.com with SMTP id m7so27097843obh.3
for<EMAIL_ADDRESS>Thu, 31 Mar 2016 06:46:16 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:delivered-to:dkim-signature:dkim-signature:date
:from:reply-to:to:cc:message-id:in-reply-to:references:subject
:mime-version:content-transfer-encoding:precedence:list-id
:list-archive:list-post:list-unsubscribe;
bh=DMO6KAVJV/hXZmmk17hBK80XP4k9sv31FhhhJjAWX6o=;
b=HRaTWmpXXlwnU5c2/GH0vZPzYSsBGZNHdSsTQuLKZMwVrMZkLKBp8IzrNSgaLDuG2D
OgcR/Jyx+rEFJ3AYHaxOIt5ZuXWXX6RiR/dIp/YyuhbM7SyEDtyH3FncmPfoiv1g3s9x
1/NEAKcLNphvZQbJhHstAUHbxQcz7Bt+PMJjvbSNrlUGy96Kj50JWG0cKgnGibHKiiFe
aZZB61h6mjaLlFQvDBBnPqQolJd9KqQX8taPIb/4HRLf1Ufy4alhDPfV5DSx+/ZyOuTZ
liL9QLaSlaoUDPs50DL3F6jM3TdxmNIQTNVLLNM2D7chARif7a40p+pMLJYBebVv8Vp1
YHjg==
X-Gm-Message-State: AD7BkJLP5Ej3pvdW4QZUr7CrI+LclUNrUjXaHTGx4iyxx5238AIyV7CRqxmkXhI8VjtfRR7gQXKZ8WxOt/whP2WSxVkYQgk=
X-Received: by <IP_ADDRESS> with SMTP id rx9mr8384321obb.34.1459431955804;
Thu, 31 Mar 2016 06:45:55 -0700 (PDT)
X-Forwarded-To<EMAIL_ADDRESS>X-Forwarded-For<EMAIL_ADDRESS><EMAIL_ADDRESS>Delivered-To<EMAIL_ADDRESS>Received: by <IP_ADDRESS> with SMTP id 94csp132884ots;
Thu, 31 Mar 2016 06:45:55 -0700 (PDT)
X-Received: by <IP_ADDRESS> with SMTP id z71mr18269516iod.43.1459431955111;
Thu, 31 Mar 2016 06:45:55 -0700 (PDT)
Received: from o4.sgmail.github.com (o4.sgmail.github.com. [<IP_ADDRESS>])
by mx.google.com with ESMTPS id 98si7502222iok.122.2<IP_ADDRESS>.45.54
for<EMAIL_ADDRESS>(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Thu, 31 Mar 2016 06:45:55 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of<EMAIL_ADDRESS>designates <IP_ADDRESS> as permitted sender) client-ip=<IP_ADDRESS>;
Authentication-Results: mx.google.com;
dkim=pass<EMAIL_ADDRESS>dkim=pass<EMAIL_ADDRESS>spf=pass (google.com: best guess record for domain of<EMAIL_ADDRESS>designates <IP_ADDRESS> as permitted sender<EMAIL_ADDRESS>dmarc=pass (p=NONE dis=NONE) header.from=github.com
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=github.com;
h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe;
s=s20150108; bh=W62uiORgNCgTETsaLWai+TS1U2E=; b=jMuxiQyLCnawcp9f
ZBcNuYvWwdQUWCy6cTA2XfrxyoEq+2bT7/hT5CrRkqfXAEyi41EeMZGzxVv4ug8I
G9t9bvSMnXBNKU3eIMx/k3dVqntIJ88mAMqJP49TE1eoMVeR1cy7lsytv+Pk5jE+
kzSQ+PXL0/ZXzh71tBR8kmfCCE8=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.info;
h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe:x-feedback-id;
s=smtpapi; bh=W62uiORgNCgTETsaLWai+TS1U2E=; b=jedjEwC2h0R4Eb5h/Y
eeu4X+tV6yJYjwGlZLoYQ7GZm2jaf7YGtIIfEZfZInTGcUil2+Ij8+XnUqUmWHHE
dALZXPeyDsJiJ4yRFS6khmuyDvev/H1cEGTiKNfHO4HEYGpaoW44alu2EJyvSFta
i+VTn1NguSU7Zd7cEFE3RUd8s=
Received: by filter0604p1mdw1.sendgrid.net with SMTP id filter0604p1mdw1.10145.56FD2A103C
2016-03-31 13:45:52.961317862 +0000 UTC
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2b-ext-cp1-prd.iad.github.net [<IP_ADDRESS>])
by ismtpd0004p1iad1.sendgrid.net (SG) with ESMTP id nr-xHgidRiu3wy33-3Kx9A
for<EMAIL_ADDRESS>Thu, 31 Mar 2016 13:45:52.626 +0000 (UTC)
Date: Thu, 31 Mar 2016 06:45:52 -0700
From: Anton Skorokhod<EMAIL_ADDRESS>Reply-To: mijia/modelq<EMAIL_ADDRESS>To: mijia/modelq<EMAIL_ADDRESS>Cc: Gys<EMAIL_ADDRESS>Message-ID<EMAIL_ADDRESS>In-Reply-To<EMAIL_ADDRESS>References<EMAIL_ADDRESS>Subject: Re: [mijia/modelq] Support your own queries (for custom things like
full text queries) (#19)
Mime-Version: 1.0
Content-Type: multipart/alternative;
boundary="--==_mimepart_56fd2a1078c93_6b313fd8290052bc35002b";
charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kanocz
X-GitHub-Recipient: Gys
X-GitHub-Reason: comment
List-ID: mijia/modelq <modelq.mijia.github.com>
List-Archive: https://github.com/mijia/modelq
List-Post<EMAIL_ADDRESS>List-Unsubscribe<EMAIL_ADDRESS>https://github.com/notifications/unsubscribe/AA5kk-yuuSg6KeFenwwQ36t4NYIHZCOJks5py9AQgaJpZM4H8xqT
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address<EMAIL_ADDRESS>X-SG-EID: qR3giqMM8d2jHQYrpEPaPQBGxw8h1tcDalzNlZzMenPWWkwqSjP8/3L7DGWGiLRxslGOy2U9qqLf0Y
LFteqqCl+7eLOJSX4hiWvnSnKcn8UqlNcQoFPhi4lOKrtukwSyQ8qshEhvCVKcLX5uGCYAO3QXAadk
Xz0HzomPwpNt9bbznxSC/zaJ1rIl+tFiUIvdL48YU7ciXJSUmW4lIZ6Ib6zIqjnEU6yOnarupQcObk
Y=
X-Feedback-ID: 848413:6xvVEJqleZlAW7/vhv7PzD/cv5tamo2SWZDKyvugGvg=:6xvVEJqleZlAW7/vhv7PzD/cv5tamo2SWZDKyvugGvg=:SG
----==_mimepart_56fd2a1078c93_6b313fd8290052bc35002b
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
You can easily use custom template for generation code and add this functionality

You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/mijia/modelq/issues/19#issuecomment-203946163
----==_mimepart_56fd2a1078c93_6b313fd8290052bc35002b
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit
You can easily use custom template for generation code and add this functionality
—You are receiving this because you commented.Reply to this email directly or view it on GitHub

----==_mimepart_56fd2a1078c93_6b313fd8290052bc35002b--

Easily? Selecting uses the gmq.Select function to create a query object... And on the gmq side there's also no function to create a query object strictly from a query string.
On the other hand, maybe not even using the Query type will be the better route... But that means duplicating all the functionality related to getting the data from the query.

This message was created automatically by mail delivery software.
A message that you sent could not be delivered to one or more of its
recipients. This is a temporary error. The following address(es) deferred:
<EMAIL_ADDRESS>Domain reulen.nl has exceeded the max emails per hour (16/5 (320%)) allowed.  Message will be reattempted later
------- This is a copy of the message, including all the headers. ------
Received: from mail-ob0-f179.google.com ([<IP_ADDRESS>]:35333)
by fyvie.footholds.net with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128)
(Exim 4.86_1)
(envelope-from<EMAIL_ADDRESS>id 1ald8V-00083s-Eh
for<EMAIL_ADDRESS>Thu, 31 Mar 2016 14:59:47 +0100
Received: by mail-ob0-f179.google.com with SMTP id fp4so23549547obb.2
for<EMAIL_ADDRESS>Thu, 31 Mar 2016 06:59:27 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:delivered-to:dkim-signature:dkim-signature:date
:from:reply-to:to:cc:message-id:in-reply-to:references:subject
:mime-version:content-transfer-encoding:precedence:list-id
:list-archive:list-post:list-unsubscribe;
bh=z6022gQ7XUvI5q0SSqJ+7zp2Pj/r8o6T4SEhYYDOyjA=;
b=mewq4eTq98za39vibebrNrc2k032iN/gN8S9pOdI3bhlI+3Y6FCoDKlr+Nd2Mgvn6Q
x/EbrNA/dih6LDI3ldlcXlL4btc0EXpE9eA4RND1XEbx5ADV35fiXTt8PjqeS8aOEIUb
kOGoyU8tmNFu/986hRvpQYrg7+zhCJs5m88swqwIFCae4FnTonIGK48+kSeZyj2b+Dg/
oNkXkYZeW17YRBCKc9FdcWQMaqfQipc9OCbiJMtlGW/kXy2c9P9lU14kpOf5CficP1B8
TBbKAEP4pZtTmgZBAQYXwwVzQAMJ/zzDxCsIP29dJrEA+4CC3EydUQ+xyOw8HwAflgA7
bXlg==
X-Gm-Message-State: AD7BkJLVNs0E4VCY1LtPENFm/5eNbY/WmL3VSIlrQ4iqUE6HPeh0/VqxDOZkaFYSHis0LmkmK8kOaU8u1lV8qiJEkBFPrSE=
X-Received: by <IP_ADDRESS> with SMTP id vv1mr8358903oeb.60.1459432746582;
Thu, 31 Mar 2016 06:59:06 -0700 (PDT)
X-Forwarded-To<EMAIL_ADDRESS>X-Forwarded-For<EMAIL_ADDRESS><EMAIL_ADDRESS>Delivered-To<EMAIL_ADDRESS>Received: by <IP_ADDRESS> with SMTP id 94csp139060ots;
Thu, 31 Mar 2016 06:59:05 -0700 (PDT)
X-Received: by <IP_ADDRESS> with SMTP id k77mr15388749iok.121.1459432745920;
Thu, 31 Mar 2016 06:59:05 -0700 (PDT)
Received: from o3.sgmail.github.com (o3.sgmail.github.com. [<IP_ADDRESS>])
by mx.google.com with ESMTPS id a13si11153056igm.79.2<IP_ADDRESS>.59.05
for<EMAIL_ADDRESS>(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Thu, 31 Mar 2016 06:59:05 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of<EMAIL_ADDRESS>designates <IP_ADDRESS> as permitted sender) client-ip=<IP_ADDRESS>;
Authentication-Results: mx.google.com;
dkim=pass<EMAIL_ADDRESS>dkim=pass<EMAIL_ADDRESS>spf=pass (google.com: best guess record for domain of<EMAIL_ADDRESS>designates <IP_ADDRESS> as permitted sender<EMAIL_ADDRESS>dmarc=pass (p=NONE dis=NONE) header.from=github.com
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=github.com;
h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe;
s=s20150108; bh=YI8+RWpDfH8e+RBapiyT1yCEXWU=; b=q6UdJ0HROGbRTkbG
JM/8vZ3DcM/znObZ553zqRU1QyZvAOrAi0uWTtne+gPkhJV3bJN4bm7vBfcVGmkJ
UDIYAEAkgb8vZao9lT/AL3sYlgxNa5GuSAgrM8etCVJj8TABYROS1joSyXDFmss1
LckgV2EY8sg75YtXmHRiQbhMZiY=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.info;
h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe:x-feedback-id;
s=smtpapi; bh=YI8+RWpDfH8e+RBapiyT1yCEXWU=; b=G0hjdNrrt6G9ZaxGUG
z/T2TaMkvW0BsGC5JHMRB+qIX288a2PQeOezNPkOqYh76on//N+OGzycvcOqi550
w+v01c9gkAyVDl3sx6eaoZJ27pli+vNOR7doH4MwewM0UIVu5H1XIhYcKJcTZmu3
d6/9SHHrsdCvi76L1Gl+vaHtI=
Received: by filter0490p1mdw1.sendgrid.net with SMTP id filter0490p1mdw1.21672.56FD2D282D
2016-03-31 13:59:04.328414798 +0000 UTC
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2a-ext-cp1-prd.iad.github.net [<IP_ADDRESS>])
by ismtpd0003p1iad1.sendgrid.net (SG) with ESMTP id bS1e_MOmRfy2eQFrXAs-Dw
for<EMAIL_ADDRESS>Thu, 31 Mar 2016 13:59:03.317 +0000 (UTC)
Date: Thu, 31 Mar 2016 06:59:03 -0700
From: sinni800<EMAIL_ADDRESS>Reply-To: mijia/modelq<EMAIL_ADDRESS>To: mijia/modelq<EMAIL_ADDRESS>Cc: Gys<EMAIL_ADDRESS>Message-ID<EMAIL_ADDRESS>In-Reply-To<EMAIL_ADDRESS>References<EMAIL_ADDRESS>Subject: Re: [mijia/modelq] Support your own queries (for custom things like
full text queries) (#19)
Mime-Version: 1.0
Content-Type: multipart/alternative;
boundary="--==_mimepart_56fd2d272b997_6ca33fa7438172a07312";
charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: sinni800
X-GitHub-Recipient: Gys
X-GitHub-Reason: comment
List-ID: mijia/modelq <modelq.mijia.github.com>
List-Archive: https://github.com/mijia/modelq
List-Post<EMAIL_ADDRESS>List-Unsubscribe<EMAIL_ADDRESS>https://github.com/notifications/unsubscribe/AA5kk3YXq2Z5DHxtNgMvt4xDXTzk9xOqks5py9MngaJpZM4H8xqT
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address<EMAIL_ADDRESS>X-SG-EID: qR3giqMM8d2jHQYrpEPaPQBGxw8h1tcDalzNlZzMenMh+6y89XJTjoa+c3QuJPx5GT9OSTszd0NlsU
RaVOvZoLfQbBZHbmi9P/EGY9Cy7eD47ImWhqNRay87+kVcqPaxV/8gq/ONgojJ3kvh0wgA5S00hHAj
/93QYcq8PfrJjhhfo0hZDuS4xLa4LFvLiqkZsBeb7221oSpNrKgwN3XMrQ==
X-Feedback-ID: 848413:6xvVEJqleZlAW7/vhv7PzD/cv5tamo2SWZDKyvugGvg=:6xvVEJqleZlAW7/vhv7PzD/cv5tamo2SWZDKyvugGvg=:SG
----==_mimepart_56fd2d272b997_6ca33fa7438172a07312
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Easily? Selecting uses the gmq.Select function to create a query object... And on the gmq side there's also no function to create a query object strictly from a query string.
On the other hand, maybe not even using the Query type will be the better route... But that means duplicating all the functionality related to getting the data from the query.

You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/mijia/modelq/issues/19#issuecomment-203952820
----==_mimepart_56fd2d272b997_6ca33fa7438172a07312
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Easily? Selecting uses the gmq.Select function to create a query object... And on the gmq side there's also no function to create a query object strictly from a query string.
On the other hand, maybe not even using the Query type will be the better route... But that means duplicating all the functionality related to getting the data from the query.
—You are receiving this because you commented.Reply to this email directly or view it on GitHub

----==_mimepart_56fd2d272b997_6ca33fa7438172a07312--

I mean do you really need to use gmq part? using custom template (one is in exmaple folder) you can customize code generation and optimize result. Or you can extract original template from templates.go and add what do you need

I don't really have any idea right now how I would do it. That's why I am asking for this. I was also suspecting since the library is pretty limited right now (things like COUNT don't work) that others would be interested in this feature.

@sinni800 Hi, I am really confused about what you are asking for, can you provide me some more specific examples or what kind of code you would be likely to be writing?
If you still want to write SQL statements like what you can do with sqlx, you can just use modelq to generate the sqlx compatible structs without anything related to the gmq (using custom templates). Will this solve your problem?

Actually, yeah. I would just write all my queries myself then and use sqlx to apply them to structs instead of modelq...
That would work out.

I will close this then. Thank you very much.


Rebuild crate binaries on integration tests rebuild

Right now we call compiled binaries from integration tests, so cargo do not know there is actual dependency

https://github.com/zenithdb/zenith/commit/24c3e961e4a2dbcd812a1c61e45d5a8b850de72c
Anything else?


Sentinel is GA

Sentinel is not free anymore as it is not in preview, but GA.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 734ff6a2-959a-b862-a691-54410031cb71
Version Independent ID: 04f70373-d24c-5c48-5c13-1dfa5e2ddd4d
Content: Microsoft 365 Security for Business Decision Makers (BDMs)
Content Source: microsoft-365/security/Microsoft-365-security-for-bdm.md
Service: o365-seccomp
GitHub Login: @BrendaCarter
Microsoft Alias: bcarter

@andrePKI - From our understanding, the issue has been resolved based on this merged commit https://github.com/MicrosoftDocs/microsoft-365-docs/commit/d3b15fde8188f5353b3b5c46448ab3bf534654bc.
Thank you for your contribution to make the docs better! Much appreciated!


Birth date is not pre-populated

Filling out the comprehensive sample program:

On page 1, input birthday
On page 5, select “Spring”
On page 6, the user is asked for their birthday again. (Expected the birthday to be pre-populated)

Slack Message

@ssandbekkhaug This is the existing behavior.  If we keep this bug, I propose that it not be related to the North Star.


Dropdown button with direction up not working?

components: dropdown
reactstrap version latest
react version `latest
bootstrap version 4

What is happening?
reactstrap on dropdown direction variations button with direction up not working, it's at  https://reactstrap.github.io/components/button-dropdown/:

Docs look good now


Release automation

[ ] 1. for night pre release page.
[ ] 1.1 running jobs
[ ] 1.2 refresh pre release page.
[ ] 2. enhance CI with a release job which
[ ] 2.1 create release page
[ ] 2.2 create issue in kelpler-action
[ ] 2.3 create issue in this repo as regular version bump up

@rootfs ,@husky-parul , I suppose we can try with this repo as research with our release automation.
wdyt?

close as depend bot can help us maintain dependency update for github action.


filelock.py gets logger on global level

https://fangpenlin.com/posts/2012/08/26/good-logging-practice-in-python/ explains why this is not a good practice.

I updated the code so that the logger is first acquired when needed.
I'm a bit courious, is there a reason why the disable_existing_loggers command is not sufficient or not an option?

How could I disable filelock's logging?

Disable propagation via https://docs.python.org/3/library/logging.html#logging.Logger.propagate
logger = filelock.logger()
logger.propagate = False

or set the level of the logger high enough.


Feature/update rails

Coverage decreased (-0.2%) to 97.048% when pulling 2e4bf1b40be27d9c10c9c2c9d95f394c2d41c6da on feature/update_rails into 208c9042622a50223709d9b58c32e8d3c5615f3c on master.


Resolves #53

Adds a more graceful exit when the directory does not exist.
If the desired behavior is any different (for example, printing the absolute path of the nonexistent directory), I can update with the absolute path.

@aviramha I tried to take all of your comments into consideration as I updated using anyhow to handle an invalid path.
Additional meta-information:

This is my first open source PR, so I apologize if I'm not quite following best practices
I found this issue through the This Week In Rust call for collaboration - just so you know!

@thedanvail

Great! Thanks for choosing us to be your first contribution. Beware, OSS contributing can be addictive!
Cool! Thanks for letting us know :)

Few small tweaks left :) Sorry for being hard, but we want to make sure everything is great. Also please fix conflicts with the main branch so we GH can run our automated tests.

No, please be as hard as you'd like! I'm trying to take as many notes as I can to get better at Rust and so I can be better at my next OSS PR. I sincerely appreciate your patience with me during this process!
I believe I have updated to reflect your suggestions and updated to fix the merge conflicts. I'm currently between a couple flights, so I didn't have time to check the status before the plane took off, but should be good now!

Few small tweaks left :) Sorry for being hard, but we want to make sure everything is great. Also please fix conflicts with the main branch so we GH can run our automated tests.

No, please be as hard as you'd like! I'm trying to take as many notes as I can to get better at Rust and so I can be better at my next OSS PR. I sincerely appreciate your patience with me during this process!
I believe I have updated to reflect your suggestions and updated to fix the merge conflicts. I'm currently between a couple flights, so I didn't have time to check the status before the plane took off, but should be good now!

Awesome, just see my last comment in the conversation about the ?.

Done and done!

(Just updated with cargo fmt)

I looked at the last CI run, and it looks like the cargo clippy issues are in mirrord-layer, which I did not touch in this PR. Let me know if I should do anything further.

Yes you're right. We're not binding clippy to a specific version so such cases can happen :)
Thanks for the contribution!


Problem with youtube auto-generated subtitles - .vtt (or other format) without timesteps

Checklist

[ ] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2021.12.17
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log

PASTE VERBOSE LOG HERE
`[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'https://www.youtube.com/watch?v=eF0IdEbplus', '--write-auto-sub', '--skip-download']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2021.12.17
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.19041
[debug] exe versions: none
[debug] Proxy map: {}
[youtube] eF0IdEbplus: Downloading webpage
[youtube] eF0IdEbplus: Downloading MPD manifest
[debug] Default format spec: best/bestvideo+bestaudio
[info] Writing video subtitles to: Seamless Transition to PCIe 5 0 Technology in System Implementations Webinar-eF0IdEbplus.en.vtt

## Description

<!--
Provide an explanation of your issue in an arbitrary form. Please make sure the description is worded well enough to be understood, see https://github.com/ytdl-org/youtube-dl#is-the-description-of-the-issue-itself-sufficient. Provide any additional information, suggested solution and as much context and examples as possible.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->

WRITE DESCRIPTION HERE
Seems like it's a problem to download auto-generated English subtitles in YouTube videos . Output .vtt file dont have timesteps , except first one :
"WEBVTT
Kind: captions
Language: en

00:00:02.960 --> 00:00:04.309 align:start position:0%

hi everyone thank you so much for  joining us for this webinar we'll get  started in just a moment thank you  hi everyone thank you again for joining  us for seamless transition to ... "
Tried it wi/wo --skip_download . Tried different output formats , like srv (srv1-3)
intersting fact - if you download auto translated subtitles too - these subttiles files is fine

Closed


[Feature Request] Bulk Property Assignment

I don't believe the following is possible with properties (without editing an exported CSV). Happy to be proved wrong.

Bulk Edit: To select multiple elements on a view, then assign a property to them all. Better still, assign a property value too.
Default Property: Assign a property as a default to all elements of a given element type, with a blank value.

I find this and interesting idea. Closing this one has discussion (re)started on issue #339.


wifi:PP q FULL in Mesh node (IDFGH-12296)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
I have a mesh network with a ROOT fixed and 5 NODES.
One of this nodes, show this error infinitely:
[2024-03-08 09:35:22.494] E (55919560) wifi:fail to post timer, type=12
[2024-03-08 09:35:23.374] I (55920440) app_main: Heap size -> 8279320
[2024-03-08 09:35:24.393] I (55921440) app_main: Heap size -> 8279320
[2024-03-08 09:35:24.514] W (55921560) wifi:pp q full: 7-3c274548
[2024-03-08 09:35:24.514]
[2024-03-08 09:35:24.514] E (55921560) wifi:fail to post timer, type=12
[2024-03-08 09:35:25.652] I (55922440) app_main: Heap size -> 8279320
[2024-03-08 09:35:26.386] I (55923440) app_main: Heap size -> 8279320
[2024-03-08 09:35:26.507] W (55923560) wifi:pp q full: 7-3c274548
[2024-03-08 09:35:26.507]
[2024-03-08 09:35:26.508] E (55923560) wifi:fail to post timer, type=12
[2024-03-08 09:35:27.387] I (55924440) app_main: Heap size -> 8279320
[2024-03-08 09:35:28.378] I (55925440) app_main: Heap size -> 8279320
[2024-03-08 09:35:28.503] W (55925560) wifi:pp q full: 7-3c274548
[2024-03-08 09:35:28.503]
[2024-03-08 09:35:28.503] E (55925560) wifi:fail to post timer, type=12
[2024-03-08 09:35:29.384] I (55926440) app_main: Heap size -> 8279320
[2024-03-08 09:35:30.387] I (55927440) app_main: Heap size -> 8279320
[2024-03-08 09:35:30.505] W (55927560) wifi:pp q full: 7-3c274548
[2024-03-08 09:35:30.505]
[2024-03-08 09:35:30.505] E (55927560) wifi:fail to post timer, type=12
[2024-03-08 09:35:31.388] I (55928440) app_main: Heap size -> 8279320
[2024-03-08 09:35:32.375] I (55929440) app_main: Heap size -> 8279320
[2024-03-08 09:35:32.506] W (55929560) wifi:pp q full: 7-3c274548
[2024-03-08 09:35:32.506]
[2024-03-08 09:35:32.506] E (55929560) wifi:fail to post timer, type=12
[2024-03-08 09:35:33.377] I (55930440) app_main: Heap size -> 8279320
[2024-03-08 09:35:34.387] I (55931440) app_main: Heap size -> 8279320
[2024-03-08 09:35:34.506] W (55931560) wifi:pp q full: 7-3c274548
[2024-03-08 09:35:34.506]
[2024-03-08 09:35:34.507] E (55931560) wifi:fail to post timer, type=12
[2024-03-08 09:35:35.387] I (55932440) app_main: Heap size -> 8279320
[2024-03-08 09:35:36.382] I (55933440) app_main: Heap size -> 8279320
[2024-03-08 09:35:36.500] W (55933560) wifi:pp q full: 7-3c274548
[2024-03-08 09:35:36.500]
[2024-03-08 09:35:36.500] E (55933560) wifi:fail to post timer, type=12
[2024-03-08 09:35:37.380] I (55934440) app_main: Heap size -> 8279320
[2024-03-08 09:35:38.405] I (55935440) app_main: Heap size -> 8279320
[2024-03-08 09:35:38.505] W (55935560) wifi:pp q full: 7-3c274548

What could have caused this problem?
The nodes runs the ip_internal_network  example using this init:
drv_mesh_netif_init(mesh_recv_cb);

esp_event_handler_register(IP_EVENT, IP_EVENT_STA_GOT_IP, &wifi_sta_ip_event_handler, NULL);

esp_wifi_start();

//! Mesh initialization
esp_mesh_init();

esp_mesh_set_xon_qsize(128);
esp_mesh_allow_root_conflicts(false);
esp_mesh_send_block_time(5000);

esp_mesh_fix_root(true);
if(wifi_mesh_config->is_root) esp_mesh_set_type(MESH_ROOT);

esp_event_handler_register(MESH_EVENT, ESP_EVENT_ANY_ID, &mesh_event_handler, NULL);
esp_mesh_set_max_layer(6);

mesh_cfg_t cfg = MESH_INIT_CONFIG_DEFAULT();

//! Mesh ID
memcpy((uint8_t *) &cfg.mesh_id, wifi_mesh_config->id, WIFI_MESH_ID_LEN);

//! Router
if(wifi_sta_en)
{
    wifi_sta_initialized = true;
    cfg.channel          = 0;
    cfg.router.ssid_len  = strlen((char *) wifi_params->ssid);
    memcpy((uint8_t *) &cfg.router.ssid, wifi_params->ssid, cfg.router.ssid_len);
    memcpy((uint8_t *) &cfg.router.password, wifi_params->password, sizeof(wifi_params->password));
}

//! Mesh softAP
esp_mesh_set_ap_authmode(WIFI_AUTH_WPA2_PSK);
cfg.mesh_ap.max_connection         = 6;
cfg.mesh_ap.nonmesh_max_connection = 0;
memcpy((uint8_t *) &cfg.mesh_ap.password, wifi_mesh_config->password, sizeof(wifi_mesh_config->password));
esp_mesh_set_config(&cfg);

print_wifi_mesh_config(&cfg);

//! Mesh start
esp_mesh_start();
wifi_mesh_initialized = true;

@yanmartins Which ESP device you are using? Which IDF version? Can you provide the logs before the error occur?

@yanmartins Which ESP device you are using? Which IDF version? Can you provide the logs before the error occur?

ESP32-S3
ESP 5.2.1
About the logs, unfortunately I was not saving the logs at the time this error occurred.
I have been monitoring these devices and the error has not happened again. Now I'm always saving the logs, if I find something, I'll send it here
I just found it strange because these devices have the same firmware and hardware, and the error happened on only one of them

ok, will waiting for your feedback.

I tested over the last 5 days and the problem was not reproduced. I'll close the issue and reopen it if I get the error
thank you


Challenge Editor Error: Unexpected token '<', "<!doctype "... is not valid JSON

Describe the Issue
When opening the Challenge Editor I saw this "Unexpected token '<', "<!doctype "... is not valid JSON" error.
Affected Page
Challenge Editor
Steps to Reproduce

run pnpm run challenge-editor
Go to http://localhost:3300
See error

Expected behavior
There should be no errors.
Screenshots

System

Device: Macbook M1
OS: MacOS 13.4.1 (22F82)
Browser: Chrome

Additional context
No response

I've checked latest code on gitpod and haven't encountered any issues.
Make sure you have .env file up to date for challenge editor, there was variable name change lately.

I've checked latest code on gitpod and haven't encountered any issues.
Make sure you have .env file up to date for challenge editor, there was variable name change lately.

Hmmm... I merged the latest changes but still having it.

Check if the challenge editor's client .env matches sample.env.

Oh, this is the reason. thanks!


setEtherbase

What was wrong?
https://github.com/pipermerriam/web3.py/issues/118
How was it fixed?
just added the method and test,
now I don't get why all the preceding commits from my fork are into that PR as well, I'm sure I'm using git the wrong way but couldn't figure a way to have only the commit https://github.com/pipermerriam/web3.py/commit/4b85343b88b08aa3234d95b8c6940b56072dd035 which is the only one relevant
Cute Animal Picture

Looks pretty good.  Suspiciously missing the required cute animal picture.......
I'll let it slide this time 😉


scrubber: perform manifest check with etag and refactors

This adds the etag to remote_storage::ListingObject, and uses it in the scrubber for performing the manifest freshness check added in #10007. This is in response to review giving feedback about the clock precision not being enough to prevent races.
I think the addition of the etag is useful enough as a general change, even without the motivation of wanting to do cheap checks whether there has been a change or not.
Note that the etag check still isn't 100% perfect, and we could get there also by just comparing the manifest, but I think the addition of the etag is useful enough of its own right. I don't know, please write if you think that it's baggage.
As for why the etag check is not perfect: it is fully determined by the content at least on AWS (md5 on AWS, didn't check Azure). So if you change a file from A to B and back to A, the etag will be the original one. Maybe something based on the version ID would be better, but we can't assume to always have it, as sometimes versioning is disabled on the bucket.
Follow-up of https://github.com/neondatabase/neon/pull/10007

@problame do you think the ListingObject etag addition is worth it? If not, I'll close this, or remove it and just derive Eq on RemoteTenantManifestInfo.


Minimal template causing TypeError: init() got an unexpected keyword argument 'acct_key'

Which version of python are you using?
Python 3.6.9
What operating system and version of operating system are you using?
Ubuntu 18.04
What version of sewer are you using?
0.8.4
What did you do? (be as detailed as you can)
Just trying to create a minimalistic dns provider without params
What did you expect to see/happen/not happen?
It detonated without style
What did you actually see/happen?
Working with style
So, you got a provider example here: https://github.com/komuw/sewer/blob/master/docs/dns-01.md
I tried to replicate that on a minimal basis without paramets and such, but it did explode.
Here is my current class: https://pastebin.com/b8YJGCxM
It seems to throw:
cert_key=AcmeKey.create("rsa2048")
TypeError: init() got an unexpected keyword argument 'acct_key'
At https://pastebin.com/a6Un2nsP
Any idea why?

Thanks for asking!  By the time of 0.8.4, the account key argument to Client() was changed to the AcmeAccount type, and the name was changed to account.  I expect you found one or more bits of text that I missed updating.  Sewer's been through a lot of changes in 2020, and when you run into something that doesn't match such as this, the first check should be to see if the code has moved along since the text you used was last updated.
If you can identify the example that steered you to use acct_key, I'll fix at least that out of date text.  Likewise any others you come across, of course!

I end up with more errors, can you please update the documentation?
Its painful to get this stuff to work only for the basic functions.

What texts are you finding that mislead you?  That they are not all uniformly up to date is a known issue - too many were written while I was in the process of sorting out the substantial changes, and probably should just be deleted at this point.  What did you change and what errors are you getting now?  I can't read your mind.
I would also suggest pulling the current HEAD from the github repo, as there have been some fixes and cleanups since 0.8.4 was released.  Also, and work I've done on the docs since 0.8.4 was released will be correct for those changes, maybe not for what's on 0.8.4.  As will any future corrections or additions...

Your examples just don't work, hence I asked you to update them.
After fixing the acmeClient I ended up with:
Traceback (most recent call last):
File "cert.py", line 29, in
cert_key=AcmeKey.create("rsa2048")
TypeError: init() got an unexpected keyword argument 'domain_name'
According to the class, its a needed parameter.

Even your example copy & pasted from https://github.com/komuw/sewer/blob/master/docs/sewer-as-a-library.md with Cloudflare throws me the same TypeError: init() got an unexpected keyword argument 'domain_name'

I'm sorry, it's still difficult to get started writing a new Provider class.  That was what finally pushed me to get involved with maintaining the code - that and the belated protocol change that was rolled out in lettsencrypt's staging testbed a bit more than a year ago.  I have gotten rid of some semi-hidden hoops, but exercising a new driver is still not as simple as I'd wish it to be.
Unless you want to deal with all the internals, I would suggest that you consider adding a new case to the get_provider() monstrosity in cli.py, and adding a stanza in catalog.json.  For both the existing pieces for cloudns will be the most simply adapted to get started, as that driver has no parameters that we have to deal with.  (which is not a plus - it still takes some authorization credentials, but sucks them out of the environment in a lower-level library, so they aren't visible to sewer's CLI program.)  Then you can use cli to handle all the interfaces to the Client class.
As the comment on get_provider() says, the goal was to eliminate all that boilerplate, but the bolierplate turns out to hide a number of odd special cases, and that conversion has yet to be completed.  :-(


tweak doc publishing instructions

Which issue does this PR close?
N/A
Rationale for this change
I got a little confused while creating https://github.com/apache/arrow-site/pull/191 (due to my own fault for not reading the instructions carefully)
What changes are included in this PR?
tweak the instructions for publishing new content for the documentation
Are there any user-facing changes?
NO

FYI @houqp

Thanks for the review @realno


Unexpected url from Provider link in Single result view

Description
Clicking the provider link on the audio metadata information takes you to the track page on the provider rather than the provider's main page. Reported by @sarayourfriend
Reproduction

Search anything.
Open one result to see the single result view.
Click on the provider's name in the Audio information area.
It opens the audio link instead of the source site's homepage.

Resolution

[ ] 🙋 I would be interested in resolving this bug.

As more I think of this, I believe we need to switch to "Go to the content site" button for all content. This because we will start integrating the search engine in core, and because it solves the friction we might have with providers on redirecting user traffic.


Wrong PDBInformation GUID endianness

The endianness of the guid in PDBInformation seems to be off compared to llvm-pdbutil, specifically its first three fields:
llvm-pdbutil:  98D1EFE8-6EF8-FE45-9DDB-E11382B5D1C9
willglynn/pdb: e8efd198-f86e-45fe-9ddb-e11382b5d1c9

The problem seems to originate in manually parsing the UUID fields with platform-endianness here:
https://github.com/willglynn/pdb/blob/7947bcc3cc1f8f7ab2952155f83ed1bd8dd0eb05/src/pdbi.rs#L159-L164
After changing this to Uuid::from_bytes(buf.take(16)?), the output is correct. I'll submit a patch shortly, after running some more tests. I did not verify that llvm-pdbutil is correct in this case, but I'm assuming so foolishly 😄
For testing, I was using the Electron v2.0.11 x64 PDB. You can obtain an archive here (sorry, it's rather large).

Hmm, I thought I had a reason for doing this the long way. Is there a Microsoft tool that can confirm the intended byte order, either in the PDB or in the corresponding PE executable?

Sorry for not checking this earlier. Microsoft's GUIDs specify little endian representation of the fields indeed, which means your initial implementation was correct. dumpbin /headers electron.exe showed the original GUID.
Surprisingly, llvm-pdbutil is buggy. I'll go ahead and put in a bug report there. Thanks for double-checking this!


Fix #688 Clarify % operator documentation for non-zero return-code

Fix for https://github.com/lihaoyi/Ammonite/issues/688

Thanks!


Please allow configuring of the build timeouts

The build timeouts are currently set to 60 minutes. We have a few jobs that need to take longer, at times. If this was configurable, we can avoid having to create our own separate code build pipelines/stages and reuse the existing ones in this module.
Thank you.

Hey @nitrocode, thanks for the feature request - good call-out here. I've created an item in our backlog to enable customization of build job timeouts.

I also ran into this. A resource took greater than 30 minutes to provision and then state was not commited. a nasty one to stumble over.
considering the terraform codebuild could be used for any number of resources I think 60mins is really quite conservative here and should be configurable for sure
https://github.com/aws-ia/terraform-aws-control_tower_account_factory/blob/1010f5ead7960114a4abf96afffb02c7a6e47e70/modules/aft-customizations/codebuild.tf#L64

Release 1.3.4 now has support for custom CodeBuild timeouts.


Extract e2e test vector set and/or profile from verite and tbd implementations?

test harness? jest type harness versus docker-based?
could pair with, e.g., a VC-JWT and did-method-set profile for people to run locally/internally and self-attest
start with e2e/reasonable coverage, do full conformance in a second pass?

(will check in at next week's meeting on normative statements and neg vectors)

jest is fine, since we'll just be plugging in json. I'm not a js/ts guy though so can't commit to doing the impl but I can commit to generating the vectors

Discuss next week?

Discussed on DIF:

Focus on building the test vectors out first ( can do )
Second, let's build out the test harness. ( challenged with resources. need to find a way to get this through with the limited bandwidth everyone has)

Niels pointed out there is an OpenAPI def for v1 and for v2 already on their repo:
https://github.com/Sphereon-Opensource/pex-openapi
to generate APIs per language...

Also, as Niels pointed out on the call, https://github.com/kimdhamilton/presex-lib is currently private, @kimdhamilton !

Testing artefacts moved into a DIF repo and editors here are now CODEOWNERS over there, so feel free to PR against it if you find bugs or nits!


Import problem during running

Hello! When I run the program calling $ python main.py I get this:
~/b/kivy-designer ❯❯❯ python main.py [INFO   ] [Logger      ] Record log in /home/victor/.kivy/logs/kivy_16-08-19_6.txt [INFO   ] [Kivy        ] v1.9.1 [INFO   ] [Python      ] v2.7.6 (default, Jun 22 2015, 17:58:13)  [GCC 4.8.2] [INFO   ] [Factory     ] 179 symbols loaded [INFO   ] [Image       ] Providers: img_tex, img_dds, img_gif, img_sdl2, img_pil (img_ffpyplayer ignored) [INFO   ] [Text        ] Provider: sdl2 [INFO   ] [OSC         ] using <multiprocessing> for socket [INFO   ] [Window      ] Provider: sdl2(['window_egl_rpi'] ignored) [INFO   ] [GL          ] OpenGL version <3.0 Mesa 10.1.3> [INFO   ] [GL          ] OpenGL vendor <Intel Open Source Technology Center> [INFO   ] [GL          ] OpenGL renderer <Mesa DRI Intel(R) Haswell Mobile > [INFO   ] [GL          ] OpenGL parsed version: 3, 0 [INFO   ] [GL          ] Shading version <1.30> [INFO   ] [GL          ] Texture max size <8192> [INFO   ] [GL          ] Texture max units <32> [INFO   ] [Window      ] auto add sdl2 input provider [INFO   ] [Window      ] virtual keyboard not allowed, single mode, not docked  Traceback (most recent call last):    File "main.py", line 1, in <module>      from designer.app import DesignerApp    File "/home/victor/bin/kivy-designer/designer/app.py", line 9, in <module>      from designer.buildozer_spec_editor import BuildozerSpecEditor    File "/home/victor/bin/kivy-designer/designer/buildozer_spec_editor.py", line 18, in <module>      from pygments.lexers.configs import IniLexer  ImportError: No module named configs ~/b/kivy-designer ❯❯❯
I have installed the requirements. Twise. Nothing.
I am using Ubuntu MInt.

Hi,
There is some problem in pygments package on your system. Please, check this issue: https://github.com/kivy/kivy-designer/issues/133

I've removed pygmets. Because of dependencies kivy was removed too. I've installed pygments-2.1.3 via pip. Then again kivy. But kivy forced apt to download pygments-1.6 and install it. So I am stuck


Range officer can't see their agreements

User has tried:
Clearing cache
I have tried:
Checking browser version
Stealing data, making myself RO, I can see them fine
Have double checked they are in fact in right zone
Will try next:  Another browser for them.

Turns out they have two IDIRS in FTA, getting it sorted.


Create empty rugby file!

Created a new .md doc for visiting Rugby. :gb:

Skip Rugby for Leamington or Warwick, they are nicer.

I approve of this latest change.


⚡ DD Package Dynamic Memory Management

WIP that build on https://github.com/cda-tum/dd_package/pull/158 as well as https://github.com/cda-tum/qfr/pull/304 and aims to bring dynamic memory management to the DD package.

Closing for now in favour of cda-tum/mqt-core#447


Can't share image, ShareDialog not show on Android and IOS

On IOS:
[43180:367646] -canOpenURL: failed for URL: "fbapi:/" - error: "The operation couldn’t be completed. (OSStatus error -10814.)"
On Android:
Not show dialog.

https://stackoverflow.com/help/how-to-ask
https://stackoverflow.com/help/minimal-reproducible-example
But please also note: this repository moves forward through community effort. Stated differently, if you have a specific problem, like this, you will need to invest your time or your company's time in a fix for the problem, and propose the solution here
We can merge and release PRs but there is no group of people here with time to work on other people's problems


Add management for TeamForCapella repositories

Description
This PR adds the repository management to the t4c instances, with the following actions:

Create a repository (in the database and on the t4c instance)
Delete a repository (in the database and on the t4c instance)
List the repositories, with a state synchronisation and a reconciliation between the database and the instance:

The repositories that are only on the instance are created in the database
The repositories that are only in the database are created on the instance
The statuses are set from the instance (they are not stored in the database anyway)

Start and stop repositories.

Resolves #221
Testing
How were the changes tested?
Checklist

[x] My code follows the guidelines of this project: CONTRIBUTING.md
[x] I updated the documentation with the new functionality
[x] I went through the code and removed all print statements, breakpoints and unused code
[ ] Error handling for all possible scenarios has been implemented
[x] I've add logging for all relevant operations
[x] I added the appropriate labels to this PR (enhancement/bug/documentation, effort, priority)

When trying it out, I noticed two things that should be improved:

When the server is not reachable at all, the frontend shows an unknown error. We should have a good error message if the T4C Server is not reachable.
Users should be able to create new repositories, even if the server is not reachable. They would only be stored in our database then. Whenever the server is reachable again, the repository appears as "not found" and users can recreate the repositories (like described here: https://github.com/DSD-DBS/capella-collab-manager/issues/221)
When a repository is created via our frontend, but deleted in TeamForCapella, this should be handled properly. It should not be automatically recreated, but shown as status "Not found" with a button to recreate it in TeamForCapella.


Dooya Motors/Remotes

Could the plugin be updated to include Dooya motors/remotes please?

Supported in 2.2.2 fork
https://github.com/Ghawken/rfxcom-plugin

Closed in 3.0.2.


Migrate to AndroidX

Updates the library and accompanying sample to use the AndroidX
support library.

Thanks, can you check why the build failed and try to solve that as well?

Thanks, can you check why the build failed and try to solve that as well?

Should be fixed with the latest push.

Thanks again! :)


vet dependent projects

This checks that we haven't broken the apis used by various other m-lab projects.

This change is

Pull Request Test Coverage Report for Build 508

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 79.087%

Totals

Change from base Build 499:
0.0%

Covered Lines:
658

Relevant Lines:
832

💛  - Coveralls


FXGL game app in child window

is this possible?
parent window: javafx normal gui app
child window: fxgl game app
game app is launched from normal gui app.
any sample code?
im using fxgl 0.5.4

In 0.5.4 I don't think it is possible, but in 11.8 it is. You just need a stage object. Sample code

Can you rethink about java8?
2019 83%
https://www.jetbrains.com/lp/devecosystem-2019/java/
2018 84%
https://www.jetbrains.com/research/devecosystem-2018/java/
At this pace it will take another 83 years for java8 to stop being used.

I would love to support java 8. However, as it currently stands the architectures of fxgl for java 8 and fxgl for java 11+ are not compatible. There is significant effort and time required to backport the whole codebase to java 8. If you are interested, you are very welcome to provide such a port.

Thank you for your response. I understand the situation.


Feature Request for Threema Web Application Enhancement

I hope this message finds you well. I am writing to kindly request the addition of a feature to your web application. I have tried to implement this functionality myself, but unfortunately, I encountered some issues, and it did not work as expected.
The feature I would like to request is add Threema App . This addition would greatly enhance the usability and convenience of the Threema web platform (https://web.threema.ch/#!/welcome) and improve the overall user experience.
Thank you in advance for considering this request. I look forward to seeing Station Team continue to evolve and improve.

no update?


Bash window flashes on start then disappears

I just installed developer mode and installed and turned on the Subsystem for Linux. When I hit the windows key and type Bash, I get the icon for bash (Run command), but when I click on it a window appears and then disappears.
Thanks,
R

run bash.exe in cmd.exe and instead of flashing it will return an error code.

ok, thanks. Now I get:
Unsupported console settings. In order to use this feature the legacy console must be disabled.
How do I fix this?

Disable in via cmd.exe's properties.

Thanks, it's working now.


Rafefile: include test:special by default

The tests under the "special" directory were not being executed by "script/test".

They weren't because they are "special", possibly because of adding a bit of time to the suite. Personally I don't think we need to separate the only test it contains from the rest unless it indeed adds a lot of time. How about moving it with the rest and either removing the special directory or adding a text file stating the purpose is to have expensive tests there?

On my machine it runs in ~0.7s. I wouldn't separate it from the rest of the test suite because we have others that take longer (there are some that sleep for 1s).


add systemd

@Ansen
Thank you for your changes, if you have a chance please let me know and reopen the pull request.


Typed property Filament\Actions\MountableAction::$livewire must not be accessed before initializatio

Package
filament/actions
Package Version
v3.2.53
Laravel Version
v10.48.3
Livewire Version
v3.4.9
PHP Version
8.3.4
Problem description
When I'm trying to invoke an action, I got Typed property Filament\Actions\MountableAction::$livewire must not be accessed before initializatio
here is the error
https://flareapp.io/share/67OWWEv7
Expected behavior
Dont get the error
Steps to reproduce
Call some action
Reproduction repository
https://flareapp.io/share/67OWWEv7
Relevant log output
No response

Update Filament


Custom UI using FirebaseInAppMessagingDisplay crashes app at FirebaseApp.configure()

Xcode version: 10.1 (10B61)
Firebase SDK version: 5.16.0
Firebase Component: In-App Messaging
Component version: 0.12.0

App crashes as soon as it starts with the following exception:
Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[FIRAnalyticsConnector unregisterAnalyticsListenerWithOrigin:]: unrecognized selector sent to instance 0x281a8f100'
Steps to reproduce:
I'm using local pod 'FirebaseInAppMessagingDisplay' for showing my custom UI for in-app message by following instruction listed here:
https://firebase.google.com/docs/in-app-messaging/customize-messages
This is the relevant pod entry:
pod 'Firebase/Core', '5.16.0'
    pod 'Firebase/RemoteConfig'
    pod 'FirebaseInAppMessagingDisplay', :path => '/Users/monty/Documents/GitHub/firebase-ios-sdk'
    pod 'FirebaseInAppMessaging', :path => '/Users/name/Documents/GitHub/firebase-ios-sdk'
    pod 'FirebaseAnalyticsInterop', :path => '/Users/name/Documents/GitHub/firebase-ios-sdk'

Hey @animeshp - thanks for the report. We recently updated the FIRAnalyticsConnector code to use a new method introduced in FirebaseAnalyticsInterop but the FirebaseAnalytics SDK that implements the method hasn't been released yet.
We have a version that works staged right now on https://github.com/Firebase/SpecsStaging which you can use for testing, but should not use this for your product. A public and more well tested version should be ready in our next release.

Thanks @ryanwilson for replying.
So I wanted to use FirebaseInAppMessagingDisplay for implementing my custom UI as per instructions provided here. But following instructions leads to local pod not being able to find FIRInAppMessagingRendering.h, so I had to include pod 'FirebaseInAppMessaging'.
This further leads to including pod 'FirebaseAnalyticsInterop' pointing to local path because one of the other files is also not found.
So may be I'm missing something here or the instructions are incomplete for implementing custom UI.
After doing all of the above I got the above crash.

Ahh, I was not aware of our instructions to do so. Apologies! One thing you can do in the meantime is instead of relying on master, use the latest release. If you checkout the 5.16.0 branch that should get you back up and running.

cc: @christibbs @paulb777 - looks like we need to be more careful about temporarily breaking master.

Thanks @ryanwilson for suggesting to use 5.16.0 branch. I got my implementation for custom UI working in test build.
Do you have any idea if 5.16.0 branch is safe to use in production? Or any timeline to get everything working in master?

The 5.16.0 branch matches the current published release and is safe to use for production.
The docs should be updated to give instructions to point at the last release branch. The master branch is not recommended for production.

I sent our technical writer a note to update this, will close when the docs are updated.

@christibbs Please add an internal bug number so that other Googlers can track.

Internal bug number is 128939308.

Documentation has been updated.


add: Chowdhury Tafsir Ahmed Siddiki

Description

Related Issues

Changes Proposed

Checklist

[x] I have read and followed the Contribution Guidelines.
[x] All new and existing tests passed.
[x] I have updated the documentation to reflect the changes I've made.
[x] My code follows the code style of this project.
[x] The title of my pull request is a short description of the requested changes.

Screenshots
Note to reviewers

@ctafsiras Thank you so much for your contribution! Your efforts are greatly appreciated and will go a long way in improving our project. Please feel free to share it with others and help us grow even further!


Automatically generate default exec_root path

exec_root is used as the directory field in the produced compile
command database, which must be an absolute path of the local file
system.  Specifying a fixed absolute path in the repository
significantly reduce the portability of the develop environemnt,
virtually requires the repository to be compiled in a fixed container
setup.
This change use shell command-line to automatically generate
exec_root path when no value is explicitly specified, which avoids
above limitation.
Due to the extreme difficulty of retrieving real filesystem absolute
path inside bazel script.  The path is retrieved from working path
from in shell script through run_shell action.  This approach
relies on the relative path from sandbox execution path to workspace
execution path, which may be changed in future bazel versions.

Thank you for the change. While I agree with the spirit of the change, I feel like the current implementation is slightly brittle and hard to read, as you have mentioned in your comments. FWIW, our generate.sh script is also hacky, but I would like to not introduce more, and in principle, we could simplify the generate.sh script but we would not have clear paths forward here.
Let me think if there is a better way of detecting the exec root. For source directory, we take the root workspace file as a label attribute, and follow symlinks to that. For execroot, we would have to take a generated file as an input to this rule, like how you are doing with __main__.
When I initially wrote this rule, I thought the simplest way would be for people to wrap the bazel invocation in a shell script that would use sed to replace the marker with the actual location. Similar to what we do in generate.sh. Would it help if this project provided a template script for this purpose?

Hello!
I have updated the README with better instructions on how to use the selected targets mode. Perhaps that will clarify the expected usage pattern here.
Please let me know if it is sufficient for you.
We can then review the filter_flags change separately.
Thanks!

Thanks for the clarification.  However manual step outside bazel is undesired in our step thus this may not be as useful.

Actually the hacky part of my realpath command could be removed by using execution_requirements:  https://stackoverflow.com/a/48551327/3466604, where we no longer need to get rid of the relative path of sandbox.

@siddharthab
I have completely reworked the MR to use repository_rule to access results from shell command and filesystem for the calculation of exec_root path.  It still relies on the fact that an external repository is placed at <build_root>/external/<repo_name> while exec_root being <build_root>/execroot/<workspace_name>.  I think this part should be a much stable layout for bazel than the previous sandbox path.
I also took the liberty to move filter_flags to the same virtual repo so flag filtering could happen in the very first place also.
Added clang_tidy_test to show case how I envision the update aspect could be used.
Since this is now a full bazel solution as clang_tidy_test use case would show, script generate.sh shall no longer be needed.  However I do not quite understand the bazel build command in the generate.sh script and why it failed.  Maybe you could shed some light here?

Thanks for your continued efforts on this. I will take a look this weekend.

will this MR be merged ?

My apologies for the delay in getting to this PR.
With 0.5.1, I have now included the changes to support the clang-tidy check as you want it:

There is now an OUTPUT_BASE value that you can supply to the compilation_database rule to set the right compilation directory. More details in the README.
The aspect output group is now returning the direct source files of a target.
For filter_flags, I felt that it could be too specific to an application, and so should be handled at that level. In your case, you can remove the filter_flags strings from the compilation database json before using it with clang-tidy. If this is not enough, then maybe we can open a new PR with just that feature.

I think the clang-tidy check rule itself should be better off in a new repo, as it is a very specific application. I think I am exporting everything that you would need. If you do create such a repo, please let me know and I can advertise it here.
I am going to close this PR now. Thank you so much for your efforts.


🐛 fix : Fixed the input select width to fit the contents of the options

refer #41 for input select option issue ,
This is another reference

fixed the width to fit content

Amazing!

Thanks


Render PDF by "render template".

http://weasyprint.org/docs/

Example
from weasyprint import HTML

class FromTemplate(APIView):
    renderer_classes = (PDFRenderer, )

    def get(self, request):
        pdf = StringIO()

        # This example may change to a new drf-pdf response
        HTML(string='
Foo
').write_pdf(pdf)

        return PDFResponse(
            pdf.getvalue(),
            file_name='example',
            status=status.HTTP_200_OK
        )

We could do this using from django.template.loader import render_to_string
May I know what are you trying to achieve here?


Issue to do with node-sass and Meteor <IP_ADDRESS>

Hi running with Meteor <IP_ADDRESS> similar to https://github.com/Dogfalo/materialize/issues/5275 which relates to Node-Sass version and materialize any ideas pls?
meteor@fa9ef693d871:~/buzzy7$ meteor run --settings ../buzzy-settings/settings.json -p 3000
[[[[[ ~/buzzy7 ]]]]]

=> Started proxy.
=> Started MongoDB.
=> Errors prevented startup:

   While loading package<EMAIL_ADDRESS>   error: Command failed: /home/meteor/.meteor/packages/meteor-tool/.1.6.1_1.c76v6p.io9tw++os.linux.x86_64+web.browser+web.cordova/mt-os.linux.x86_64/dev_bundle/bin/npm rebuild --update-binary
   Cannot download "https://github.com/sass/node-sass/releases/download/v3.8.0/linux-x64-57_binding.node":

   HTTP error 404 Not Found

   Hint: If github.com is not accessible in your location
   try setting a proxy via HTTP_PROXY, e.g.

   export HTTP_PROXY=http://example.com:1234

   or configure npm proxy via

   npm config set proxy http://example.com:8080
   gyp info it worked if it ends with ok

Actually just noticed this mention of node-sass version  https://github.com/lookback/meteor-emails/blob/26334cf702ee015fd820eb92805988d1469a5560/package.js#L16
WHich uses this package, which it seems is not needed anymore as per https://github.com/chrisbutler/meteor-node-sass/issues/3#issuecomment-236681321

Hi,
I am using Meteor 1.8 and I have been trying to add your package for a project with metoer but i get the same error that @adamgins got:
While loading<EMAIL_ADDRESS>error: Command failed: /Users/pastor/.meteor/packages/meteor-tool/.<IP_ADDRESS>ws1gu.b0tmg++os.osx.x86_64+web.browser+web.browser.legacy+web.cordova/mt-os.osx.x86_64/dev_bundle/bin/npm rebuild --update-binary
Cannot download "https://github.com/sass/node-sass/releases/download/v3.8.0/darwin-x64-57_binding.node":

Apparently that url package is not available anymore.

This might be due to the 3.8.0 node-sass dependency in the example app.
Is this fixed, if you:

Clone down this package into your app/packages folder
Bump that to latest node-sass in the example/package.json file

That worked for me!! Much appreciate it! I am a bit new in "Meteor".

Cool! If you'd like to, feel free to submit a Pull Request to this repo with your change :)

Yes. Renaming the example dir solves it.
I sent a pull request. https://github.com/lookback/meteor-emails/pull/99

I forgot to update references to the example folder. Sent PR to that too. #100


test_annual failing

First, dumping panchanga object to string with sorted keys is failing. (None key somewhere?)
Even if the above is fixed by skipping stringification and resorting to dict comparison (with an update to the sanskrit_data package - see Chennai 2018 test) - there is still a failure.

What's going on? Seems unrelated to today's changes. For all I know, tests were failing before today.

Using http://www.jsondiff.com/ with the files dumped from an unsuccessful run on the Chennai 2018 case shows some seemingly insignificant changes (2 missing properties 2199 unequal values). @karthikraman  should examine more closely and update the expected json as needed.

I suspect it's because of the ayanamsha? Can we recreate SIDM_TRUE_CITRA? CHITRA_AT_180 seems to mirror Lahiri?? I also find that the moonrise moonset timings have changed. The jd midnight time in the JSON also seems to have changed by some -0.8 seconds.

It is easy to recreate TRUE_CHITRA for CHITRA_AT_180 - if the pyswisseph API were to work properly! (see commented out code where CHITRA_AT_180 is computed which mentions the issue). I also wonder if the swisseph Lahiri not actually implements TRUE_CHITRA (it's 24 something degrees, not 23). Only other change which might cause the fractional second shift might be the use of different (equally/ more standard) libraries for jd - gregorian conversion.
If the changes are minor, plz update the the jsons so that the tests pass (can always readjust to true-chitra later) - will facilitate making changes with confidence in the meantime.

After more changes; for Chennai test, only these seem to be the outstanding changes:
'Adityahasta-puNyakAlaH': [90, 118, 363], rather than 'Adityahasta-puNyakAlaH': [35, 63, 336, 364],
Deletion of 'AyuSmAn-bava-saumya': [31, 234],
'               'Azvayuja-amAvAsyA (alabhyam–svAtI, puSkalA)': [311], changed to                'Azvayuja-amAvAsyA (alabhyam–svAtI, puSkalA)': [311],
aGgAraka-caturthI': [64, 183, 330], added
Some weird key change in 'akSayya-tRtIyA'.
Overall all seems well.

It seems to fail for me...
karthik@nu:spatio_temporal$ python3 test_annual.py
DEBUG: 2020-09-15 17:28:46,509 {common.py:860}: {'DataSource': <class 'sanskrit_data.schema.common.DataSource'>, 'JsonObject': <class 'sanskrit_data.schema.common.JsonObject'>, 'JsonObjectNode': <class 'sanskrit_data.schema.common.JsonObjectNode'>, 'NamedEntity': <class 'sanskrit_data.schema.common.NamedEntity'>, 'SchemaError': <class 'jsonschema.exceptions.SchemaError'>, 'ScriptRendering': <class 'sanskrit_data.schema.common.ScriptRendering'>, 'Target': <class 'sanskrit_data.schema.common.Target'>, 'TargetValidationError': <class 'sanskrit_data.schema.common.TargetValidationError'>, 'Text': <class 'sanskrit_data.schema.common.Text'>, 'UllekhanamJsonObject': <class 'sanskrit_data.schema.common.UllekhanamJsonObject'>, 'ValidationError': <class 'jsonschema.exceptions.ValidationError'>}
Traceback (most recent call last):
  File "test_annual.py", line 7, in <module>
    from jyotisha.panchangam.spatio_temporal import City, annual
  File "/home/karthik/GitHub/jyotisha/jyotisha/panchangam/spatio_temporal/annual.py", line 13, in <module>
    from jyotisha.panchangam.spatio_temporal import periodical
  File "/home/karthik/GitHub/jyotisha/jyotisha/panchangam/spatio_temporal/periodical.py", line 21, in <module>
    from jyotisha.panchangam.temporal.festival import read_old_festival_rules_dict
ImportError: cannot import name 'read_old_festival_rules_dict'

Perhaps because of the re-organisation?


Reduce the big inrush current if the CVL jumps from Bulk/Absorbtion to Float

Is your feature request related to a problem? Please describe.
The problem is when a very large battery is present and a voltage drop from bulk 55.2V to 54V float voltage happens in one go. A lot of energy is suddenly discharged from the battery. This can be up to 5kw or more.
Describe the solution you'd like
My solution is in the battery.py.
To reduce the inrush current i do this in steps with the update interval to the float voltage
my change is at line 275
OLD:
self.control_voltage = round(
  (utils.FLOAT_CELL_VOLTAGE * self.cell_count), 3
)
  self.charge_mode = "Float"

NEW
floatVoltage = round((utils.FLOAT_CELL_VOLTAGE * self.cell_count), 3)`
if self.control_voltage:
    if self.control_voltage >= (floatVoltage + 0.005):
        self.control_voltage -= 0.005
    else:
        self.control_voltage = floatVoltage
else:
    self.control_voltage = floatVoltage
self.charge_mode = "Float"

Describe alternatives you've considered
Maybe also something for the coinfig file
Additional context
Nice Driver. ;)
i have installed Version: v1.0.20230508beta

Could you please post also your diagrams from the VRM portal where we can see this behaviour before and after?

Yes, I can do that, but the VRM portal has currently performance problems.
As soon as this is running again I will send pictures.

Here you can see that the current is not so large and also rises slowly. You can also no longer hear the inverters as they try to lower the voltage as quickly as possible.
Bevore:

After:

Perfect, I will test it a few days and then add it.

I also have an adaptation for aggregate batteries for this problem but that is probably better placed at DR-Gigavolt. Whar do you mean? I used the new "Chargmodes" for that.
With Aggregate Batteries the problem is that as soon as the first battery goes into float, all other batteries that are not yet balanced go into float as well.

@Rikkert-RS for the aggregate batteries you have to open an issue in the related repository as you said.
@ogurevich what do you think about this code change? Do you see the same in your charts?

can confirm, the inrush current at the moment the battery goes in float mode is significant (in ESS mode with DC-coupled PV - Feed in excess - ON)
it make sense to reduce control voltage gently wenn going in to float. We could in addition in this time period self.charge_mode = "Float (dynamic)"
the proposed code change is charming. the management function called every second, we achieve the desired effect.
it make sense imho

Hello guys,
ESS does not support the lead-acid algorithm at all, this works only with stand-alone MPPTs or Multis/Quattros. Why do you try maintain it? Just reduce the CVL and balancing-start voltage in BMS in order to to extend the battery life. What is the gain of charging the battery to 100% and than discharge it into the grid? The battery does not need to be at 100% to be balanced. I tried to reduce my LTOs (although there is the battery life not a limiting factor) from 2.5V to 2.35V and it works without any troubles.

@ogurevich thanks
@Dr-Gigavolt I think we already talked about this a few times. It's the flat charging curve of LFP batteries where it's better to balance at voltage where the curve is steeper.

What is the gain of charging the battery to 100% and than discharge it into the grid? that is a very valid question.
nevertheless, it is not wrong to make the transition to float mode smooth. The user can use the MAX_CELL_VOLTAGE and
FLOAT_CELL_VOLTAGE parameters control how he wants to do that. If you set the parameters the same, you have eliminated the float mode. So everyone would be happy. (...this is a new topic for me, maybe I don't see some moments deeply enough)

LTOs are even flatter. IMHO there is no difference at which voltage the balancing is performed. As there is almost no leakage current, it does not help to balance in the knee. The charge that must be transferred by balancer is almost the same. When I built my batteries, I tried the initial balancing at Vmax = 2.7V, it did not help at all. Once above knee (2.5V for LTO) the balancer has no chance against peaking. I reduced to 2.5V and it was OK. And now with 2.35V is OK as well.

I had huge problems, if I balanced the LFP batteries in the flat area. Two batteries were much less charged than all others. This happend multiple times with different cells. Right now I'm asking me what would be more efficient. Only balancing in the top voltage section or always? If you don't need it, just set float and max voltage to the same.

This was implemented and is available tomorrow in the dev branch. It will be available also in the next version.

Hello,
Just as feedback. Thanks for the implementation. I've been running this for a few weeks now and you can't hear anything, it runs very smoothly.
@Dr-Gigavolt , @ogurevich
The goal was also not to dictate how anyone charges their battery.
By this function it is only made smother. Everybody can decide for himself. Yes, feeding energy into the grid at all makes no sense at this point. In sum, not much energy is pushed into the grid but in such a short time that does not have to be. For me it is much better to balance at 55.2V (16S) than at less voltage (Lifepo4). And then to keep the battery permanently until the next discharge at 55.2V is also not good.
If someone is still interested in the changes from the "aggregate batteries" code. Then I can also share this and post it here.
@mr-manuel
Keeping everything together on this Issue (topic) makes sense if someone is looking for it?
What I noticed in particular and what does not work with "aggregate batteries" is that if you have for e.g. 2 battery packs installed and the first pack is ready woth balancing, the whole BattterieBank then goes into float mode even if the other pack is not yet finished with the balance process. My change waits until all battery packs are ready with balancing process.
@Dr-Gigavolt If there is also interest here I would rise an "enhancement" Issue in your repo and would share the code there.
best regards Rikkert-RS

@Rikkert-RS for the aggregate batteries you have to open an issue in the related repository as you said.

You can then link the issue here.

Sorry for being late to the party. I tested this code as well, and after a few days I changed the slope from 0.005 to 0.001 and I'm more happy with that. Not sure if everybody wants it that slow. but if we go from 3.45 to 3.35, then it will be only 20 seconds (JKBMS Bluetooth only 10 seconds) but with 0.001 it will be 100 or 50 seconds.

Maybe in this case it would be better not not user cycles but time. Like every minute 0.10 V.

Can you specify this better?

I would not let the user decide this. This makes the driver unnecessary complex. Better, if we discuss a reasonable V/time for this.

What I noticed in particular and what does not work with "aggregate batteries" is that if you have for e.g. 2 battery packs installed and the first pack is ready woth balancing, the whole BattterieBank then goes into float mode even if the other pack is not yet finished with the balance process. My change waits until all battery packs are ready with balancing process.

In abstract terms, aggregator does its job correctly. As soon as one of the several battery packs (the driver) reports "I am full, please reduce the charge voltage", the aggregator forwards the signal to the DVCC logic. Control question: what is more damaging in this case, reducing the voltage, or grilling the fast pack a little longer because of "slow" batteries?

This is exactly what I wanted to do.
Another question: why do we need an exact balancing? The only reason I see is full charging, to avoid peaking. But if the goal is 80...90% to extend battery life, who cares about few % difference?
When I'll have some time to do it, I'll try to implement an array of CVLs for each month for Aggregate Batteries. In winter full, in summer less full and e.g. once or twice per month full charging for re-balancing and reset of the SoC counter. A good trade-off between usage and life.
For LTO I found this datasheet:
https://www.global.toshiba/content/dam/toshiba/ww/products-solutions/battery/scib/pdf/ToshibaRechargeableBattery-en.pdf
please look onto "long life", right chart.  Do you know such a curve for LFP? Just to understand how harmful is to keep the cells fully charged over certain period of time.
Best regards,
Anton

Do you know such a curve for LFP? Just to understand how harmful is to keep the cells fully charged over certain period of time.

See https://github.com/Louisvdw/dbus-serialbattery/issues/458#issuecomment-1537219671

Hi @mr-manuel ,
this one you've shared already. I mean depending on the float voltage over the time, without cycling.

During experiments yesterday and today I observe something strange what I haven't seen before. The setting of CVL is slow at Multis, it is known. But the CCL does not work at all when the CVL is adjusted dynamically to avoid peaking of the most full cell. If limited to zero or few A, the charge current of several 10A continues to flow, the battery is charged more then set up and then is discharged by large current, the system oscillates. I tried to downgrade Venus 3.0 to 2.94, no change. Have you an idea?

could it be that this is the current between different battery packs? The Multiplus, MPPTs and Venus OS would then be out of play

During experiments yesterday and today I observe something strange what I haven't seen before. The setting of CVL is slow at Multis, it is known. But the CCL does not work at all when the CVL is adjusted dynamically to avoid peaking of the most full cell. If limited to zero or few A, the charge current of several 10A continues to flow, the battery is charged more then set up and then is discharged by large current, the system oscillates. I tried to downgrade Venus 3.0 to 2.94, no change. Have you an idea?

I found something, it is bad and you should consider it as well:
https://community.victronenergy.com/questions/106290/bug-in-ess-dc-feed-in-enabled-charge-current-limit.html
I wrote the code in winter with few 100W from DC-coupled modules, therefore no troubles at that time. And after balancing there was no dynamic CVL change to trigger the issue. Just last days when experimenting and increasing the voltage.

During experiments yesterday and today I observe something strange what I haven't seen before. The setting of CVL is slow at Multis, it is known. But the CCL does not work at all when the CVL is adjusted dynamically to avoid peaking of the most full cell. If limited to zero or few A, the charge current of several 10A continues to flow, the battery is charged more then set up and then is discharged by large current, the system oscillates. I tried to downgrade Venus 3.0 to 2.94, no change. Have you an idea?

could it be that this is the current between different battery packs? The Multiplus, MPPTs and Venus OS would then be out of play

The pack are fully identical and cells assembled in order to make identical Rin for both.
http://gigavolt.eu/projects/PV2/PV2.html

Hi @mr-manuel
you could consider adding the following safety feature for the time of absorption and if cell peaking detected:

switch the DC-feed off by setting com.victronenergy.settings: '/Settings/CGwacs/OvervoltageFeedIn' to 0
and re-activate the DC-feed by writing 1 when the cell voltage difference falls under certain threshold, e.g. 30...50mV

Hi @mr-manuel you could consider adding the following safety feature for the time of absorption and if cell peaking detected:

switch the DC-feed off by setting com.victronenergy.settings: '/Settings/CGwacs/OvervoltageFeedIn' to 0
and re-activate the DC-feed by writing 1 when the cell voltage difference falls under certain threshold, e.g. 30...50mV
It works well.

sorry, i am pretty sure that is not a task of battery driver. The main task is to provide infos to databus what for the battery better is.  (imho)

Coming back to the original topic, of course I miscalculated the time, since it's for the whole pack, not the cell voltage. I think something like 5-10 Minutes is a good time for a 0.1V/Cell voltage drop. To make it easy we could say 500 seconds for the whole transition?

the tests show me that 300 sec. seem to be ok. We could also drag this out.  Here ist example with full length (300 sec)
https://github.com/Louisvdw/dbus-serialbattery/assets/50322596/d27ccb9f-6da4-4698-a049-70c7f2dc72bb

Coming back to the original topic, of course I miscalculated the time, since it's for the whole pack, not the cell voltage. I think something like 5-10 Minutes is a good time for a 0.1V/Cell voltage drop. To make it easy we could say 500 seconds for the whole transition?

I would not specify the time for the whole transition but for the voltage change (e.g. 0.01 V/10 seconds). Else it's a huge difference if someone is using a 4S system versus a 18S system.

I would not specify the time for the whole transition but for the voltage change (e.g. 0.01 V/10 seconds). Else it's a huge difference if someone is using a 4S system versus a 18S system.

indeed, we have to take that into account. Or some thing like this ?
FLOAT_MODE_TRANSITION_DURATION = self.cell_count * 12

the variant (0.01 V/10 seconds) is also elegant and good

The different voltage drop per second is a little scary. If the user sets the float voltage via absorption, the algorithm will fail. It should probably be validated at init time
(pushed in to "voltagedroppersecond" branch)
                chargeMode = "Float"
                if self.control_voltage:
                    if not self.charge_mode.startswith("Float"):
                        self.transition_start_time = int(time())
                        self.initial_control_voltage = self.control_voltage
                        chargeMode = "Float Transition"
                    elif self.charge_mode.startswith("Float Transition"):
                        elapsed_time = int(time()) - self.transition_start_time
                        # Voltage drop per second
                        VOLTAGE_DROP_PER_SECOND = 0.01 / 10
                        voltage_drop = min(
                            VOLTAGE_DROP_PER_SECOND * elapsed_time,
                            self.initial_control_voltage - floatVoltage,
                        )
                        self.control_voltage = (
                            self.initial_control_voltage - voltage_drop
                        )
                        if self.control_voltage <= floatVoltage:
                            self.control_voltage = floatVoltage
                            chargeMode = "Float"
                        else:
                            chargeMode = "Float Transition"
                else:
                    self.control_voltage = floatVoltage
                self.charge_mode = chargeMode

Somehow one step is taking 10 second, the next 20 seconds, then 10 seconds, 20 seconds and so on. Can you check that?

roger, wilco

how often is this function called?

It should be every second

thank you, there is a bug, i check it and try to fix. (not good)

https://github.com/Louisvdw/dbus-serialbattery/assets/50322596/a92813cd-5e36-44d0-a4b2-6236a89c0519
hm, probably graph interpolation ?

Theoretically it should get and display every change. The reduction seems a bit to steep for me comaring with the measured voltage. How does your graphics look like? Is the measured voltage following the voltage reduction?

it look not bad by me. There is a table view possible, let's check the values please

the reduction of maxChargeVoltage seems to be correct. Agreed ?

sorry, now with a timeline

All good the timespan matches exactly the code.
I was only thinking about to increase it, but I looked again at the code on the top of this issue, so this is fine.

… please set a bigger value there. …. On the road, …..PGP fingerprint: 38A0 D0CC BD23 1707 B0AF  D158 E9D7 6E3F E74A 0B0COn 16. Jun 2023, at 16:07, Manuel @.***> wrote:
All good the timespan matches exactly the code.
I was only thinking about to increase it, but I looked again at the code on the top of this issue, so this is fine.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

oh, i apologize, the lowering per step was here: https://github.com/ogurevich/dbus-serialbattery/tree/voltagedroppersecond
i had to close this pull request and open a https://github.com/ogurevich/dbus-serialbattery/tree/voltagedroppersecond. Sorry !

my mistake, should I start a new pull request ?

... basically both variants are pretty much the same. please choose the variant you like best.

Yes please.
Theoretically it should also not change the value more often than LINEAR_RECALCULATION_EVERY as for the other linear calculations. Could you also integrate this and open a new PR?

ok, implemented here: https://github.com/ogurevich/dbus-serialbattery/tree/voltagedroppersecond
I'll test the code tomorrow and if everything is ok, open a pull request

In a perfect world this would be so, unfortunately in past we had troubles with fast changing CVL, CCL and DCL. The MultiPlus for example was not able to stay behind the changes that were made every second and very strange phenomena appeared. There is a discussion or issue somewhere in this repo.
To solve this, I introduced LINEAR_RECALCULATION_EVERY .

ok, see, we're trying to bang the error that occurs somewhere else. What happens when we have 10 battery packs? Everyone sets the value 1 time per 10 seconds and in the worst case we will change the value 1 time per second.
Anyway, we've taken that into account (LINEAR_RECALCULATION_EVERY). 👍

Only one battery pack can be chosen in DVCC as BMS to control CVL, CCL and DCL.

Only one battery pack can be chosen in DVCC as BMS to control CVL, CCL and DCL.

correct. usually it is some battery aggregator, wich takes the values from all connected battery packs. Does it take a care how often it changes CVL, .... values ?


exclude embedding in MFU computation

Stack from ghstack (oldest at bottom):

-> #280

Per suggestion in #274:
This PR removes embedding from number of parameters calculation, because embedding op doesn't do matmul.
This PR keeps a factor of 12 in the self-attention, because dealing with sparsity (causal attention) is very tricky and for now let's follow the convention (PaLM paper, nanoGPT, etc.)

FlashAttention makes use of the causal mask to do half the work, so one of my friends got >100% MFU when using the 12 factor rather than 7. Common options for multipliers in the causal setting are:
6: This is theoretically the lowest FLOP count possible, but it's not what an efficient implementation would use. I only know of one implementation which calculates it this way.
7: This is Flash Attention, and how they benchmark themselves. This is the most accurate counter to engineer against.
12: This is common, but not very useful in my experience, as it's easy to make the MFU go way up by changing context length.

@ad8e imo, I would either use 6 or 12. MFU was originally intended to exclude recomputation flops (from activation checkpointing), it seems somewhat strange to me to reinclude it here. In addition, other FlashAttention implementations (like say, Triton's) actually end up with a factor of 9 for FLOPs.
My argument for 12 would be that, if you use 6, then you need to start to be quite consistent about taking into account sparsity (for example, let's say we add sliding window attention). Otherwise, you end up back in the same situation you're referring to, where increasing sequence length results in overly increased MFU.
Perhaps unobviously, flop counting is a somewhat subjective enterprise. For FlashAttentionv2 itself it makes sense to benchmark with 7, as what it cares about is "how much room is there to optimize this kernel".

@ad8e
I checked some other mainstream repos on how MFU is computed. From what I can tell, most (if not all) of them are using 12. For example:

nanoGPT: https://github.com/karpathy/nanoGPT/blob/master/model.py#L296
Megatron: https://github.com/NVIDIA/Megatron-LM/blob/main/megatron/training/training.py#L79

Since ultimately MFU is a derived metric from token-per-second (formula) and there doesn't exist a consensus on what formula to use, we feel it's safer to follow the industry convention to use 12, unless the community change it together. One can always use token-per-second for more direct comparisons.

I checked some other mainstream repos on how MFU is computed. From what I can tell, most (if not all) of them are using 12. For example:

If you wish to base your decision on what is most widely used, I agree that 12 is the most common number. Only Flash Attention uses 7 (and me), and only one codebase I've seen uses 6.


Subtitles timing

Hi,
is it possible to add subtitles timing? It will be perfect!
Thanks
Btw I read your roadmap and If bit player have this functions I will donate you! Absolutely perfect idea! Good job, continue in good work :)

it is possible, but i do see a point to do so, as google announced it won't be continuing to support chrome apps: http://www.ghacks.net/2016/08/19/google-to-dump-chrome-apps/
you may find this player as a nice alternative: http://powder.media/

I did not know that.So future is Play Store apps. And player that you send
me link is not fór chromebook :/
Dne 29. 1. 2017 13:32 napsal uživatel "roeycohen"<EMAIL_ADDRESS>
:

it is possible, but i do see a point to do so, as google announced it
won't be continuing to support chrome apps: http://www.ghacks.net/2016/08/
19/google-to-dump-chrome-apps/
you may find this player as a nice alternative: http://powder.media/
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/roeycohen/Bit-Player-Chrome-Extension/issues/9#issuecomment-275910922,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATO6vSOvhjxQC0rShqMZiAnd0lx2xbWgks5rXIbCgaJpZM4LvDSx
.

yeah, powder player indeed does not support chrome book.
adding new features to this player takes a lot of time and effort, and i don't want to work for something that will stop working for me and other users in a few months :(

I understand. It will be work for nothing.
But thank you for your great work. I hope that Android Apps will work on
chromebooks well
Dne 29. 1. 2017 13:40 napsal uživatel "roeycohen"<EMAIL_ADDRESS>
:

yeah, powder player indeed does not support chrome book.
adding new features to this player takes a lot of time and effort, and i
don't want to work for something that will stop working for me and other
users in a few months :(
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/roeycohen/Bit-Player-Chrome-Extension/issues/9#issuecomment-275911307,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATO6vQpGubxE1UBlkFZP2Z8vDC-B6psPks5rXIi2gaJpZM4LvDSx
.

i hope so too.
if google will change its mind, i'll surely continue to improve bit player.

So I read the Google plan is "convert" app to web pages. You can see it here https://developers.google.com/web/progressive-web-apps/
Is it possible "convert" app to this web app?

I took a look on PWA. it seems like native implementation for Cordova/Phonegap.
The main problem with BitPlayer is that it's requires sockets (tcp/ip) api, and it doesn't exists in a normal web page and i didn't found support for this in PWA.
maybe if at some point in future they will add support for sockets i'll be able to convert to PWA.


minor cleanup

Can one of the admins verify this patch?

@jbonofre thanks :) I'm just trying to integrate PR tester, sorry for the noise!

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Aries-cdi-pr/1/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Aries-cdi-pr/2/


simplification and generalization of component path removal

🤖 AutoRest automatic publish job 🤖
> will publish once PR gets merged


diffusers 0.22.x released, some features may useful

https://github.com/huggingface/diffusers/releases
I wonder LCM can accelerate how much the generation.
Also PEFT is useful for multi lora I think.

to follow up on this; https://github.com/intellerce/controlanimate seems to suggest its a 10x increase in inference.

to follow up on this; https://github.com/intellerce/controlanimate seems to suggest its a 10x increase in inference.

LCM is only available at dedicated checkpoints, right?
Maybe the existing controlnet model is not available either.
I'm wondering if we should support this.

@s9roll7 LCM looks like a plugin compatible with Checkpoint/LoRA/Controlnet.
After incorporating LCM into my comfyui animatediff workflow, it functions exceptionally well. The process was straightforward, involving the addition of just two nodes and an adjustment to the sampler node.
Still, LCM may look lack of details in 5 steps

You Can find my workflow here, https://github.com/hylarucoder/comfyui-workflow/tree/main/animatediff
Link: https://huggingface.co/latent-consistency/lcm-lora-sdv1-5

to follow up on this; intellerce/controlanimate seems to suggest its a 10x increase in inference.

LCM is only available at dedicated checkpoints, right? Maybe the existing controlnet model is not available either. I'm wondering if we should support this.

I'm wondering if we should support this.

Absolutely! Controlanimate now has support for LCM Lora which works with any SD1.5/XL derived model and is compatible with controlnets, loras etc
https://huggingface.co/latent-consistency/lcm-lora-sdv1-5

7f3ca02

@s9roll7 that's huge, thx sooooo much


Replaced the 'µ' with 'u' in "µPickle"

Why?

Why?

It was the only occurrence of the word "µPickle". In all other places this librarry is called "uPickle".