% sign in URI must not be interpreted (other than for URI encoding)

Describe the bug
v3 appears to interpret % signs that aren't part of URI encoding in some way. The result is that on nginx with v3 the URI /?test=%ua produces the value /?test=\xfa. The values after the % sign are clearly being interpreted as hexadecimal values, but are clamped to a valid range (i.e., values > f are clamped to f).

This behavior is unexpected and makes matching against such values almost impossible
The behavior differs from v2

To Reproduce
Steps to reproduce the behavior:
Run 920260-1 against nginx.
Expected behavior
ModSecurity must ignore invalid URI encoding, just like the web server does, and pass it through to rules to inspect.
Server (please complete the following information):

ModSecurity version (and connector): ModSecurity v3.0.12, nginx-connector latest
WebServer: nginx 1.25.3
OS (and distro): Debian 12 (Docker)

Rule Set (please complete the following information):

CRS main branch

Hi @theseion,
thanks for this report. We're going to check this issue soon.

I have looked into this issue and I believe that this behavior is caused by Nginx, not libmodsecurity3.
Libmodsecurity3 has a great testing framework - anyone can write tests and check the behavior of the library, without connectors and other components. This framework is base of the regression test, also uses the CI pipeline.
I have created this test case:
[
  {
    "enabled":1,
    "version_min":300000,
    "title":"Testing % character in URI - issue 3235",
    "expected":{
      "http_code": 403
    },
    "client":{
      "ip":"<IP_ADDRESS>",
      "port":123
    },
    "request":{
      "headers":{
        "User-Agent":"OWASP CRS test agent",
        "Host":"localhost",
        "Accept":"text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5"
      },
      "uri":"/?test=%uff0F",
      "method":"GET",
      "body": [ ]
    },
    "server":{
      "ip":"<IP_ADDRESS>",
      "port":80
    },
    "rules":[
        "SecRuleEngine On",
        "SecRule REQUEST_URI|REQUEST_BODY \"@rx (?i)%uff[0-9a-f]{2}\" \"id:920260,phase:2,deny,t:none,msg:'Unicode Full/Half Width Abuse Attack Attempt',logdata:'%{MATCHED_VAR_NAME}=%{MATCHED_VAR}'\""
    ]
  }
]

Key parts:

under the expected I mark that the library must return with 403
check the request.headers for headers, those are the same as in the mentioned CRS test file
the request.uri is also the same as in the test file
in the rules section I copied the simple form of original rule 920620.

When I run this test, I got the expected 403 result, and the test passes:
$ ./regression_tests test-cases/regression/issue-3135.json
ModSecurity 3.0.12 - tests
(options are not available -- missing GetOpt)

  # File Name                                         Test Name                                                             Passed?
--- ---------                                         ---------                                                             -------
  1 issue-3135.json                                   Testing % character in URI - issue 3235                               passed!

Ran a total of: 1 regression tests - All tests passed. 0 skipped test(s). 0 disabled test(s).

If I change the expected result to 200, I got the detailed errors:
Test failed. From: test-cases/regression/issue-3135.json.
Test name: Testing % character in URI - issue 3235.
Reason:
HTTP code mismatch. expecting: 200 got: 403

Debug log:
[17150244124.274430] [] [4] Initializing transaction
[17150244124.274430] [] [4] Transaction context created.
[17150244124.274430] [] [4] Starting phase CONNECTION. (SecRules 0)
[17150244124.274430] [] [9] This phase consists of 0 rule(s).
[17150244124.274430] [] [4] Starting phase URI. (SecRules 0 + 1/2)
[17150244124.274430] [/?test=%uff0F] [4] Adding request argument (GET): name "test", value "%uff0F"
[17150244124.274430] [/?test=%uff0F] [4] Starting phase REQUEST_HEADERS.  (SecRules 1)
[17150244124.274430] [/?test=%uff0F] [9] This phase consists of 0 rule(s).
[17150244124.274430] [/?test=%uff0F] [9] Appending request body: 0 bytes. Limit set to: 0.000000
[17150244124.274430] [/?test=%uff0F] [4] Starting phase REQUEST_BODY. (SecRules 2)
[17150244124.274430] [/?test=%uff0F] [9] This phase consists of 1 rule(s).
[17150244124.274430] [/?test=%uff0F] [4] (Rule: 920260) Executing operator "Rx" with param "(?i)%uff[0-9a-f]{2}" against REQUEST_URI|REQUEST_BODY.
[17150244124.274430] [/?test=%uff0F] [9] Target value: "/?test=%uff0F" (Variable: REQUEST_URI)
[17150244124.274430] [/?test=%uff0F] [9] Matched vars updated.
[17150244124.274430] [/?test=%uff0F] [9] Target value: "" (Variable: REQUEST_BODY)
[17150244124.274430] [/?test=%uff0F] [4] Rule returned 1.
[17150244124.274430] [/?test=%uff0F] [9] Saving msg: Unicode Full/Half Width Abuse Attack Attempt
[17150244124.274430] [/?test=%uff0F] [4] Running (disruptive)     action: deny.
[17150244124.274430] [/?test=%uff0F] [8] Running action deny
[17150244124.274430] [/?test=%uff0F] [8] Skipping this phase as this request was already intercepted.
[17150244124.274430] [/?test=%uff0F] [4] Starting phase RESPONSE_HEADERS. (SecRules 3)
[17150244124.274430] [/?test=%uff0F] [9] This phase consists of 0 rule(s).
[17150244124.274430] [/?test=%uff0F] [9] Appending response body: 0 bytes. Limit set to: 0.000000
[17150244124.274430] [/?test=%uff0F] [4] Starting phase RESPONSE_BODY. (SecRules 4)
[17150244124.274430] [/?test=%uff0F] [4] Response body is disabled, returning... 2
[17150244124.274430] [/?test=%uff0F] [4] Starting phase LOGGING. (SecRules 5)
[17150244124.274430] [/?test=%uff0F] [9] This phase consists of 0 rule(s).
[17150244124.274430] [/?test=%uff0F] [8] Checking if this request is suitable to be saved as an audit log.
[17150244124.274430] [/?test=%uff0F] [8] Checking if this request is relevant to be part of the audit logs.
[17150244124.274430] [/?test=%uff0F] [5] Audit log engine was not set.
[17150244124.274430] [/?test=%uff0F] [8] Request was relevant to be saved. Parts: 4430

Error log:
[client <IP_ADDRESS>] ModSecurity: Access denied with code 403 (phase 2). Matched "Operator `Rx' with parameter `(?i)%uff[0-9a-f]{2}' against variable `REQUEST_URI' (Value: `/?test=%uff0F' ) [file "issue-3135.json"] [line "2"] [id "920260"] [rev ""] [msg "Unicode Full/Half Width Abuse Attack Attempt"] [data "REQUEST_URI=/?test=%uff0F"] [severity "0"] [ver ""] [maturity "0"] [accuracy "0"] [hostname "<IP_ADDRESS>"] [uri "/"] [unique_id "17150244124.274430"] [ref "o7,6v4,13"]

I think I have to insect the connector - if there is no any invalid decoding, then this behavior by Nginx, not the library nor connector.
Please take a look at the test and correct me, may be I'm wrong.

Thanks, I'll check.

Just for sure: I checked with the example you given - here is the test case:
      "uri":"/?test=%ua",
      "method":"GET",
      "body": [ ]

and the result:
[171502559910.049186] [/?test=%ua] [4] Adding request argument (GET): name "test", value "%ua"
[171502559910.049186] [/?test=%ua] [4] Starting phase REQUEST_HEADERS.  (SecRules 1)
[171502559910.049186] [/?test=%ua] [9] This phase consists of 0 rule(s).
[171502559910.049186] [/?test=%ua] [9] Appending request body: 0 bytes. Limit set to: 0.000000
[171502559910.049186] [/?test=%ua] [4] Starting phase REQUEST_BODY. (SecRules 2)
[171502559910.049186] [/?test=%ua] [9] This phase consists of 1 rule(s).
[171502559910.049186] [/?test=%ua] [4] (Rule: 920260) Executing operator "Rx" with param "(?i)%uff[0-9a-f]{2}" against REQUEST_URI|REQUEST_BODY.
[171502559910.049186] [/?test=%ua] [9] Target value: "/?test=%ua" (Variable: REQUEST_URI)

So the library does not encode the pattern %ua to \xfa.

I just checked with Nginx and libmodsecurity3 - seems to work as you expect:
curl -v "http://localhost/?test=%ua"

result:
[171510021893.966265] [/?test=%ua] [4] (Rule: 920260) Executing operator "Rx" with param "(?i)%uff[0-9a-f]{2}" against REQUEST_URI|REQUEST_BODY.
[171510021893.966265] [/?test=%ua] [9] Target value: "/?test=%ua" (Variable: REQUEST_URI)
[171510021893.966265] [/?test=%ua] [9] Target value: "" (Variable: REQUEST_BODY)
[171510021893.966265] [/?test=%ua] [4] Rule returned 0.

This is the same issue as https://github.com/owasp-modsecurity/ModSecurity/pull/3016.
Unfortunately, the patch somehow never made it into the release branch: https://github.com/owasp-modsecurity/ModSecurity/blob/5f44383236b94ef8066529861d0b4d603f9b3bcb/src/utils/decode.cc#L102.

Yes, the release (3.0.12) was on 30th of January, and #3016 was merged in March. Finally, I'm happy we found the root cause.


react-command-generate-documents

New sample
This project contains an azure function that can populate a word template stored in a document library with information passed into it in the post body. It can be used to add text, images, checkboxes and tables to a Word template. The function saves the generated document back to another SharePoint document library. The function impersonates the logged in user to ensure that the function only can write to libraries the caller has access to. It can also create a PDF version of the file using the v2.0 SharePoint rest interface. A sample SPFX list view command set is also included to demonstrate how to call the azure function. The replacement parameters in this sample came from a single list, but in real life they would likely come from multiple lists (order header/order detail).

enhancememnts to table handling

Hi @russgove ,
Unfortunately, we cannot accept this sample as it is currently. Please read and follow the contribution guidelines and make changes to your PR accordingly: https://github.com/SharePoint/sp-dev-fx-extensions/blob/master/.github/CONTRIBUTING.md
Also, I'd recommend you to remove the publishing profile, and other environment-specific things, from your PR.
Cheers!
Laura

Thanks ! I've  removed the publishing profile and cleaned up the README.

Hi Can this PR get Merged?

Thank you @russgove for your patience while we processed your PR.
This is a great sample, would you be interested in demoing it on an upcoming SPFx community call?

Hi hugo,
I can do that. just give me a couple of weeks as i need to st up my dev tenant.
russell
Sent from my iPad

On Apr 3, 2020, at 11:12 AM, Hugo Bernier<EMAIL_ADDRESS>wrote:

Thank you @russgove for your patience while we processed your PR.
This is a great sample, would you be interested in demoing it on an upcoming SPFx community call?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

That's great. Do you want to book a tentative date now, or would you prefer to set up your tenant first?


Worked fine in Chrome but seems to infinitely hang in Firefox

Hey it's me again lmao, so I just left Chrome for Firefox and I've been porting all the custom Youtube tweaks over, all the formatting stuff seems to be fine but for some reason it gets stuck trying to load the Watch Later page because it seems to be hanging on the script. The debug script button highlights the last parenthesis in this function
const sumResult = (data) =>   data.reduce((pre, cur) => {     return (       pre +       (!!cur.playlistVideoRenderer         ? +cur.playlistVideoRenderer.lengthSeconds         : 0)     );   }, 0);
No idea if that helps, probably not. If there's anything I can do that might help, let me know

I figured I would have a look at it myself since I've been in quite the mood to alter things that bother me in websites with TamperMonkey scripts. So I added console.log() lines all across the functions to see where it hangs and I realise it's likely to do with the MutationObserver being triggered an unreal amount of times. I commented out most of the functions to see where it actually begins to get really bad and just having it print a message for the MutationObserver callback itself it prints once then five more times each within half a second. Letting it do the querySelector parts somehow increased it to 110 runs.
It successfully grabs the element and playlistdata on the third mutation. I guess what's happening here is that when addDurationOverlay is called, it creates a recursion since you never used observer.disconnect(). Why exactly this doesn't cause the same issue on Chrome, I have no idea, because logically it should be the same problem.
I figured if I made it disconnect at the start of main and set it back to observe at the end of main, and it seems to be fine now. You can implement this by editing it to
const main = (m,obs) => {
    obs.disconnect();
    //the code is here
    obs.observe(document.body, config);

The m is the mutation list, which you have to put a name to in order to also put a name to the observer so you can use it inside, the callback is passed those two automatically anyway. You can probably use the mutation list to determine that the element you need to be ready is actually now on the page at all, but it might be better to instead or also observe a more isolated element rather than the entire body.
When going from the playlist to a video it TypeErrors a lot in sumResultText as getDataWatchPage returns undefined since watchPageEle is on the page right away but the contents aren't there for about ten mutations and you aren't validating this like you are with overlayTimeEle in addDurationOverlay for playlist pages. You can use nullish coalescing similar to what you use in sumResult to replace null and undefined with false so you can check them afterwards to skip over the functions that need the data like
const data = getDataWatchPage(watchPageEle) ?? false;
if (data) {//the next three functions...}

which is pretty much the same as the if statements before them, and you could apply this same coalescing to them too as an extra catchfence.
As for optimising the MutationObserver, you can make it observe the ytd-page-manager element which will skip the first two mutations that won't contain the elements the code is looking for, and it'll only be 45 mutations when the page stops loading anything. After that, since you know those elements are now there, you can actually observe the two of them directly and in tandem, so the callback will only fire if it gets a mutation from either of those elements.
While tinkering with this I noticed that playlist pages that weren't Watch Later didn't show the overlay but it was getting updated in the DOM, since it was referring to the ytd-playlist-header-renderer element but the playlist page uses yt-page-header-renderer instead. I've reordered addDurationOverlay and added some backup selectors for when it's a playlist page that isn't using playlist-header-renderer and it seems to be working, I've run out of steam to type this stuff up for now though so if you're interested let me know.


Fix List containers

This PR https://github.com/Azure/azure-rest-api-specs/pull/5562 suggests that list containers is pageable, this is fixing the missing declaration if that's the case

Automation for azure-sdk-for-java

Automation for azure-sdk-for-python

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-go

Automation for azure-sdk-for-js

Can one of the admins verify this patch?


Update survey-relationship-type.ttl

Update display list

If you are going to make more of the Concepts top concepts in the vocab, then you need to remove their broader relationship.
For example, you add:
cs:
    skos:hasTopConcept
        ...
        srt:infill
        ...
.

and yet your definition for srt:infill is:
srt:infill
    a skos:Concept ;
    skos:historyNote "Developed by the Geological Survey of Queensland." ;
    rdfs:isDefinedBy cs: ;
    skos:broader srt:follow-up ;
    skos:definition "A follow-up survey designed to increase the spatial resolution of a pre-existing survey, usually using the same parameters to ensure data compatibility."@en ;
    skos:inScheme cs: ;
    skos:prefLabel "Infill"@en ;
.

Note the broader predicate indicating srt:follow-up.
So you need to either remove the broader predicates from those Concepts you are now making top concepts - flattening the hierarchy - or leave them in but remove the top concept declarations.
If you want a flat listing of all the Concepts in the vocab, regardless of their position in the Concept Hierarchy, you should add them all to a Collection.

I have amended the vocabulary to declare only two Top Concepts, "same-project", and "follow-up".
I have removed the Top Concept declarations from the specific relationship types, and have shuffled them into one of these two Top Concepts using the Broaders.
Top Concept: same-project
Dependent
Independent
Top Concept: follow-up
Extension
Infill
Repeat
Reprocessing
Reprocessed-from
Resampling

Included the edits from 534 into 527.


Move typescript from dependencies to devDependencies

It's not imported by the code and should be moved.

Also please remove react-scripts from deepDependencies since it causes significant installation bloat.

This was completed in #26 . Please use<EMAIL_ADDRESS>


Can canokey be ran on other chips in the stm32 ecosystem

Can I run canokey firmware on the STM32F103T8U6 or would I have to modify the firmware in some way to do so?

F1 series lack of support of MPU and other minor features. You need to test it carefully.


Drop support for Python 3.8

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.98%. Comparing base (9070f83) to head (d799448).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #92   +/-   ##
=======================================
  Coverage   85.98%   85.98%
=======================================
  Files         146      146
  Lines       16216    16216
=======================================
  Hits        13943    13943
  Misses       2273     2273

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


home-page-redirection-#32

Issue
(#32 )
Description
To resolve the "Cannot GET /Home.html" error, the Home button's link should be updated to direct users to index.html. This can be achieved by modifying the HTML code for the Home button. Ensure that the link is set correctly:
Related Issues
None
Type of PR

[Bug] ()

Screenshots / videos (if applicable)

Checklist

[X] I have gone through the contributing guide
[X] I have updated my branch and synced it with project main branch before making this PR
[X] I have performed a self-review of my code
[X] I have tested the changes thoroughly before submitting this pull request.
[X] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[X] I have commented my code, particularly in hard-to-understand areas.

@amankumarcu please add related issue number in PR description.

@amankumarcu I will assign u level 3 label for PR , if check redirection of all links in website.

ok i wiil check that @Anjaliavv51

checked all the links @Anjaliavv51
only the home page button has issue.

Pl merge it @Anjaliavv51

@amankumarcu in all html pages.

@amankumarcu I can see only one file changed.

check now @Anjaliavv51

@amankumarcu please delete the branch and create PR


Latency Routing Policy

Working with a company that use OctoDNS to manage their Route53 DNS, we are wanting to implement latency based routing.
Is this supported? Cant see any mention of it in the documentation.
Have you got a full list of supported features including the correct syntaxes to use in the configuration files?

That said it does have provider specific functionality where someone has wanted/needed it and added in a clean way to configure it (without causing problems for other providers.)

To elaborate, PRs welcome. It's not really something that I have a use/case for or that would be generally applicable so I'm unlikely to get to it on my own, but I'm open to discussing developing it on contract if that's of interest.

Thanks for the update Ross


Update README and site with skydoc deprecation

Update README to reference Stardoc instead of Skydoc
Improve Skydoc-to-Stardoc migration documentation

Fixes #146

I still need to manually verify the site changes get pushed OK before I merge this (I'm waiting on some permissions issues) but want to make sure things look good in principle :)


change isset to !empty

Fixes #6149
Change from checking if the FAQ array exists to checking if there are any actual FAQs in there. Last time the main example I was looking at did not have this array unless there were FAQs, but I guess that is not always the case.
To test:
As both an admin and regular user, click "Contact Us" for a variety of campaigns both with and without FAQs. There should only be a link to FAQs if the campaign has them.
cc: @mikefantini, @DFurnes

:+1:

you went too far with this PR, you actually broke github


Mat_VarGetStructFieldByName doesn't work with HDF library above 1.8.16

Hey, guys
I have found an issue that related to the higher version of hdf library (above 1.8.16). My code snipper
is like :
                    matvar_t * shrink = Mat_VarGetStructFieldByName(pChnsfield, "shrink", 0);
                    assert(shrink != NULL);
                    paraPyr.chnsParas.shrink = *((double *) shrink->data); //shrink->data becomes null with 1.8.19 or 1.8.20 hdf library

this code works perfectly with version1.8.16 of hdf library.
But it doesn't work with 1.8.19 or later version of hdf library.
I spent some time debugging but haven't found out the reason.
Hope you can give me some help.
Thanks.
Charles Tamz

I need more information, since I see that Mat_VarGetStructFieldByName performs on the testsuite as expected.

How dou generate the MAT file? In MATLAB or using matio? If matio, which version and which HDF5 version do you use. If HDF5, do you use pre-compiled or self-compiled binaries?
Please attach a test MAT file and some C/C++ file I can run and debug to reproduce the observed behaviour!


Error on trying to add TensorRT in compilation

Running either of the first two commands in the instructions via docker on Ubuntu 16.04 gives me the following error:
Step 10/18 : ADD TensorRT-2.1.2.x86_64.cuda-8.0-16-04.tar.bz2 /opt/
ADD failed: stat /var/lib/docker/tmp/docker-builder161170432/TensorRT-2.1.2.x86_64.cuda-8.0-16-04.tar.bz2: no such file or directory
Any idea what the issue is? Thanks in advance.

TensorRT needs to be downloaded separately. But you would need to change this line anyway since a new version has been released since.


[PoC] Reduce copy of C string to symbol in class, module and method definition.

Since this is too big and breaks compatibility will split after reviews.
Most changes are to replace C function using const char* to macro and add _id suffix to it.
Some C function needs to have symbol for FFIs I've moved it to mruby-symbol-ext mrbgem.
For checking the improment I've added a feature to see how many symbol is static.
It seems most symbol can be static on launched VM.

Have you measured how much memory (or object allocation) this patch reduced?

config; https://gist.github.com/take-cheeze/36097cacd58bce1dd6ca2f430ceb9edf
time -v results(first half is master and second half is the patch applied):
https://gist.github.com/take-cheeze/d36108f43615dc172229ae4be121b4cd
Minor page faults occur on malloc-ed memory so seems it is 30 pages less when applied.
Page size is 4096 so 4096 * 30 = 120k less malloc-ed memory  usage.

Modification for time -v : https://gist.github.com/take-cheeze/24853d07dc694a34f7e3da9a57f5966e
mrbtest creates many VMs with full-core so maybe should compare mrb_open.

Page faults are inaccurate and 30 minor page faults are less than 1.5% of total faults.
Could you measure the allocation amount by direct number, by using valgrind, for example?

valgrind doesn't work well with fmt_fp.c so instead I used address sanitizer's stat:
https://gist.github.com/take-cheeze/dd8a932e98f0193e67e3f0eac0049ba5
https://gist.github.com/take-cheeze/9714b1fda87d11dcd4262c14f90ec52b
(ASAN_OPTIONS env var atexit enabled. And removed full-core since it is noisy.)
malloc call is slightly less(10k decrease):
master:
  Stats: 13M malloced (3M for red zones) by 117681 calls
symbol_literals:
  Stats: 13M malloced (3M for red zones) by 107390 calls

mmap is less too(about 10 maps):
master:
Stats: 23M (23M-0M) mmaped; 374 maps, 0 unmaps
  mallocs by size class: 2:46204; 3:10197; 4:33281; 6:2466; 7:1854; 8:1285; 11:9876; 12:650; 13:221; 14:146; 15:4803; 16:34; 17:441; 18:114; 19:166; 20:95; 21:12; 22:66; 23:4500; 24:45; 25:58; 26:361; 27:48; 29:187; 30:178; 31:44; 32:44; 33:95; 34:47; 35:44; 37:48; 38:2; 47:68; 49:1;

symbol_literals:
Stats: 22M (22M-0M) mmaped; 365 maps, 0 unmaps
  mallocs by size class: 2:36832; 3:9188; 4:33370; 6:2422; 7:1899; 8:1285; 11:9832; 12:606; 13:265; 14:190; 15:4803; 16:34; 17:441; 18:114; 19:166; 20:95; 21:12; 22:66; 23:4500; 24:45; 25:58; 26:361; 27:48; 29:187; 30:179; 31:44; 32:44; 33:95; 34:47; 35:44; 37:48; 38:2; 47:67; 49:1;

I have read the patch:

mrb_funcall etc. may not take string literals.
if MRB_USE_ETEXT_EDATA is effective on the platform, should it reduce as much memory as this patch?

mrb_funcall etc. may not take string literals.

At least in the core mrbgems I only need to modify mruby-struct for the API changes.
And I think the API to use should be different with dynamic strings and static strings.
(If possible static lifetime of rust would be great.)

if MRB_USE_ETEXT_EDATA is effective on the platform, should it reduce as much memory as this patch?

In some environment for example

changing linker scripts is difficult
dynamic linked symbols

can't be used.
If things can be judged in compile time I prefer to judge it as much as possible.


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-main" workflow

Codecov Report

Merging #617 (38bc211) into main (336f118) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main     #617   +/-   ##
=======================================
  Coverage   95.69%   95.69%
=======================================
  Files           1        1
  Lines         395      395
  Branches       53       53
=======================================
  Hits          378      378
  Misses         17       17

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Update temp work around for dev exception

Update dependency exception to new format until dev version script is updated

/azp run js - textanalytics

/azp run js - core - ci

/azp run js - textanalytics


Allow "pgx" driver to be used with SavePoint

Currently the SAVEPOINT function checks for driver name == "postgres". Since "pgx" driver is now supported by sqlx as well, it'd be great and we allow both.

Hello (and sorry for the extra late reply!)
This is definitely a change we can include
Would you care to open a pull request that includes tests? Thanks in advance


Tooltip/Popover closed when hovering out of the trigger onto the Tooltip/Popover

Describe the bug
When hovering over a tooltip trigger, the tooltip is opened, but when hovering from there onto to tooltip to click something, it's closed. It should be possible to do that to click something inside the tooltip, e.g. a button or a link to more information.
Reproduction
https://github.com/dword-design-honestly/demo-bootstrap-vue-next-tooltip-hover
Used Package Manager
yarn
Validations

[X] Have tested with the latest version. This is still alpha version and sometime things change rapidly.
[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

I believe that's what the interactive is used for.

@Hiws Looks like it, thanks for the quick answer. I didn't see the prop conversion happening in BTooltip between interactive and noninteractive. The components need docs, but that's a different story. Closing.


Handle escaped commas in measurement name

Fixes #3183

+1, cherry-pick into the 0.9.1 branch as well


implemented running play event in a new process

Playwright needs to get the running_loop of asyncio for it to use the trade_session object. I workaround could be something like subprocess instead of multiprocess lib

It seems Sharing PW instances with different threads is not possible. see https://github.com/microsoft/playwright-python/issues/1207

All attempts for multiprocessing have failed. See PW Issue 1207
The only option is to go fully asnyc


Update README.md

I am so much thankful to you for this package and excel totally depends on xml.
Thanks again for this awesome package

Thank you!


Fix moment-timezone version constraint

Yarn 3 has problem to resolve the version constraint begining with the @.

Thanks for the PR. We've merged it into the main monorepo (https://github.com/remp2020/remp/commit/b9924416664b55713ede57128e2493fe024a3d49), it will get split here at the time of the next release.

Thank you @rootpd for merge.


Add Subject prefix filtering support

Please check if the PR fulfills these requirements

[x] The commit messages are descriptive
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)
[x] An issue has been created for the pull requests. Some issues might require previous discussion.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR introduce the support of subject prefix filtering.

What is the current behavior? (You can also link to an open issue here)
Currently it is not possible to define which subjects should be managed.

What is the new behavior (if this is a feature change)?
As we can do with topics and groups, with this PR, we can now manage which subjects should be managed using prefixes.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Fix #526.

Some tests do not pass. Currently looking for why.
@purbon are some integration tests a bit flacky when running multiple times ?
This could be because some bindings or ressources in general could stay in the integration cluster ?

@purbon I think I have found a bug.
When a prefix is define (topic, group or now subject), cluster bindings are filtered.

Thanks a lot for your contributions @ludovic-boutros and team, I'm currently on holidays, but I promise to take them in as soon as possible.

Back from my break, thanks a lot for your help in the project again! ❤


parse_config fails when metric alias has a dash and a configuration is provided

Quick reproduction:

Change the standard network-io metric to:

[metric network_io:test-network]
;Network traffic in kB/s.
NETWORK_IO_INTERFACE=eth0

run metrics.sh in verbose mode and it will output something like

$ ./metrics.sh -c metrics.ini -v
Started in verbose mode
OS detected: linux
Available metrics: cpu disk_io disk_usage heartbeat memory network_io ping swap
Available reporters: file influxdb keen_io logentries_com prometheus stathat statsd stdout udp
Loading configuration file: metrics.ini
./metrics.sh: 1: eval: Syntax error: Bad function name

minimal example config file i used for the above run is attached.
metrics.txt
In my humble opinion it fails in config.sh here:
eval "${fn_name}_config () { $_body; }"
But couldn't figure out why

Functions can’t contain dashes. Need to implement something around get_alias I suppose.


License?

I don't see any license stated for this project.  Public domain?

LICENSE added.

Forgot to put one in initially! Hope this helps.

Thanks!


Gie-py with proxy

Hello, is there any way how to use proxy with GiePandasClient?
Example how it works at Entsog-py:
client = GiePandasClient(api_key=api_key)
client.session.proxies = proxies
Thanks for an answer :)

hi @risosoky  very sorry for the late reply I missed this. Yes you can in the same way! But in this library you need to do client.s.proxies as the sessions object is called diferent in the class. hope that helps!


Implement Tensor

What should a tensor allow:

creation from a flat array with a shape
creation of identity
creation of zeros
creation of ones
scalar operations

multiply
add
divide
subtract
power (including fractional power)
logical operations (>, <, == etc)

element-wise tensor operations (between two tensors of the same shape)

multiply
add
divide
subtract
power (including fractional)
logical operations

creation from tile of a smaller tensor
slice a sub-tensor from an existing tensor
iterate over one axis
reduction operations

sum
mean
median
mode
max
min
stddev

collapse operations (e.g. multiply every element in tensor together)

sum
multiply

Would the logical operators return a Boolean tensor?

Would the logical operators return a Boolean tensor?

Didn't think about that lol. I guess so. But that seems like an extra type that we just don't need right now. Let's leave those out until we absolutely need them.

I suppose you could also have a tensor which has 1's and 0's for true and false respectively. So might not be too difficult to implement, but still. Probably best to wait until we need it.


Quickstart #2 doesn't run

Clean download... run
Api Error:
Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware[1]
An unhandled exception has occurred while executing the request.
Swashbuckle.AspNetCore.SwaggerGen.SwaggerGeneratorException: Ambiguous HTTP method for action - Api.Controllers.IdentityController.Get (Api). Actions require an explicit HttpMethod binding for Swagger/OpenAPI 3.0
Identity Server Error:
[00:30:53 Error] Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware
An unhandled exception has occurred while executing the request.
System.ArgumentException: The 'ClientId' option must be provided. (Parameter 'ClientId')
Web Client Error:
fail: Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware[1]
An unhandled exception has occurred while executing the request.
System.InvalidOperationException: IDX20803: Unable to obtain configuration from: 'System.String'.
---> System.IO.IOException: IDX20807: Unable to retrieve document from: 'System.String'. HttpResponseMessage: 'System.Net.Http.HttpResponseMessage', HttpResponseMessage.Content: 'System.String'.

Why do we have swagger in the API hosts at all? Is that generated from something?

Swagger is generated by dotnet new webapi.

@jlpm10091 Swagger is only here because it is automatically included by Microsoft's template, and we don't actually make use of it in the quickstart docs at all. That said, we have a fix incoming for it: #47.
Can you give us some more detail about the steps you took to create the other errors you included above? I'm not able to reproduce either of those.

Hello, same problem here. In the sample #2 - I run the WebClient, and I get an error:
InvalidOperationException: IDX20803: Unable to obtain configuration from: 'System.String'.
Then, I checked the Program Console (Client), which works in the #1 - and I have the root problem - the following error :
System.ArgumentException: The 'ClientId' option must be provided. (Parameter 'ClientId')    at Microsoft.AspNetCore.Authentication.OAuth.OAuthOptions.Validate()    at Microsoft.AspNetCore.Authentication.RemoteAuthenticationOptions.Validate(String scheme)    at Microsoft.AspNetCore.Authentication.AuthenticationBuilder.<>c__DisplayClass4_02.b__1(TOptions o)
at Microsoft.Extensions.Options.ValidateOptions1.Validate(String name, TOptions options)    at Microsoft.Extensions.Options.OptionsFactory1.Create(String name)
at Microsoft.Extensions.Options.OptionsMonitor1.<>c__DisplayClass10_0.<Get>b__0()    at System.Lazy1.ViaFactory(LazyThreadSafetyMode mode)
at System.Lazy1.ExecutionAndPublication(LazyHelper executionAndPublication, Boolean useDefaultConstructor)    at System.Lazy1.CreateValue()
at System.Lazy1.get_Value()    at Microsoft.Extensions.Options.OptionsCache1.GetOrAdd(String name, Func1 createOptions)    at Microsoft.Extensions.Options.OptionsMonitor1.Get(String name)
at Microsoft.AspNetCore.Authentication.AuthenticationHandler1.InitializeAsync(AuthenticationScheme scheme, HttpContext context)    at Microsoft.AspNetCore.Authentication.AuthenticationHandlerProvider.GetHandlerAsync(HttpContext context, String authenticationScheme)    at Duende.IdentityServer.Hosting.FederatedSignOut.FederatedSignoutAuthenticationHandlerProvider.GetHandlerAsync(HttpContext context, String authenticationScheme) in /_/src/IdentityServer/Hosting/FederatedSignOut/FederatedSignoutAuthenticationHandlerProvider.cs:line 33
Is there a secret to filled or something?

I figure out the problem. I don't have secrets filled, and we need it for the google OAuth2 :
HostingExtensions
  builder.Services.AddAuthentication()
            .AddGoogle("Google", options =>
            {
                options.SignInScheme = IdentityServerConstants.ExternalCookieAuthenticationScheme;

                options.ClientId = builder.Configuration["Authentication:Google:ClientId"];
                options.ClientSecret = builder.Configuration["Authentication:Google:ClientSecret"];
            })

I commented out these lines and it works perfectly.
Sorry for the false positive

@brockallen - do you think we should comment out the google provider so that the sample will run "out of the box"?

Yea, might as well. And then people will be forced to understand how to get google configured if/when they want it. Also, can we update our QS docs to mention something about it, please? TY!

Just do an "" for the id/secret.

@leastprivilege - That's a good idea, except we have to put in a dummy value. The handler throws if you try to configure it with the empty string for id or secret.
@brockallen - We have a whole section in the quickstart on google auth. For the initial registration with google, we refer folks to microsoft's docs:

See Microsoft’s guide for details on how to register with Google, create the client, and store the secrets in user-secrets. Stop before adding the authentication middleware and Google authentication handler to the pipeline.

we have to put in a dummy value

That's what I meant - IIRC our templates do the same.


wsldl backup fails with<PHONE_NUMBER> exit code

Way to reproduce:

Windows Server 2019
PowerShell

Invoke-WebRequest -Uri https://dl-cdn.alpinelinux.org/alpine/v3.15/releases/x86_64/alpine-minirootfs-3.15.0-x86_64.tar.gz -OutFile alpine.tar.gz
Invoke-WebRequest -Uri https://github.com/yuk7/wsldl/releases/download/21082800/wsldl.exe -OutFile wsldl.exe
./wsldl.exe install alpine.tar.gz
./wsldl.exe backup --tgz

Here's GitHub Actions test run that reproduces this error: https://github.com/slonopotamus/wsldl-backup/runs/4752601188?check_suite_focus=true

Note that I do NOT reproduce this on Windows 10 20H2 neither in WSL1 nor in WSL2 modes.

Thank you for your reporting.
I'll work on fixing this.

Additional info: this does NOT reproduce on Windows Server 2022: https://github.com/slonopotamus/wsldl-backup/runs/4752656765?check_suite_focus=true

The problem is that wsl.exe doesn't support --export on Windows Server 2019.


fix heightmap orientation, black is low and white is high

issue found while experimenting with xonotic assets in #159, see also #30, especially https://github.com/DaemonEngine/Daemon/issues/30#issuecomment-466850340
there is only one heightmap standard: black is low and white is high
xreal was doing white is low and black is high for heightmap in alpha channel of normal map but was doing black is low and white is high for heightmap in loose file which does not make sense
in any way daemon seems to have been forked before the addition of shader keywords to support heightmap loose file so only heightmap in alpha channel is supported at this point

Maybe it's not so simple. You can see here some sort of binary search on the heightmap values, which means you would not get the same result after reversing the depth scale and inverting the image. I can't tell which convention it is intended to use.

Yay, maybe, I tried to import the similar code straight from ioquake3's renderergl2 and it renders the good way without to invert stuff. It also fixed a second bug for free. Will push code later.
Btw there is still another bug that is not fixed yet (or maybe two if I'm wrong by assuming two weirdness I see come from the same bug), but there is maybe more parallax code I can pick…

I'm wrong, even renderergl2's code is wrong if used properly, the problem seems to have something to do with SWIZ.

I'm closing it, parallax needs far more work than a scaling inversion, and perhaps a rework will just fix the issues by doing things right by working on causes instead of reverting bad results.


[Working On] Custom Destination Per User and Media Type

It would be cool if we could have target directories per user and their respective media type.
Configuration File
<username>:
	<media type>:<destination>
	<media type>:<destination>

Configuration File Example
nature:
	story-image:/nature/img
	story-video:/nature/video
	default:/nature/other

Going to start working on this today.

It can easily be done through templated filename feature, introduce a new template key say {mediatype} that is expanded to story-image/story-video/image/video then run scraper with --template {mediatype}/{urlname} to get the files sorted into folders

That's a good idea 0:


Invalid Schema in decimal type

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
When I'm using None as a default value in Field for decimal type, I got error.
pydantic_core._pydantic_core.SchemaError: Invalid Schema:
model.schema.model-fields.fields.amount.schema.default.schema.nullable.schema.function-after.max_digits
  Extra inputs are not permitted [type=extra_forbidden, input_value=32, input_type=int]
    For further information visit https://errors.pydantic.dev/2.1.2/v/extra_forbidden
model.schema.model-fields.fields.amount.schema.default.schema.nullable.schema.function-after.decimal_places
  Extra inputs are not permitted [type=extra_forbidden, input_value=16, input_type=int]
    For further information visit https://errors.pydantic.dev/2.1.2/v/extra_forbidden

Example Code
from decimal import Decimal

from pydantic import BaseModel, Field

class Wallet(BaseModel):
    name: str
    amount: Decimal | None = Field(default=None, max_digits=32, decimal_places=16)

my_wallet = Wallet(name='moein', amount=Decimal('0.005'))

Python, Pydantic & OS Version
pydantic version: 2.0.2
        pydantic-core version: 2.1.2 release build profile
                 install path: /home/moein/n/invex-services-serve/venv/lib/python3.11/site-packages/pydantic
               python version: 3.11.4 (main, Jun  7 2023, 12:45:48) [GCC 11.3.0]
                     platform: Linux-5.19.0-50-generic-x86_64-with-glibc2.35
     optional deps. installed: ['email-validator', 'typing-extensions']

Selected Assignee: @adriangb

Is your issue a duplicate of this issue: https://github.com/pydantic/pydantic/issues/6955
I was also confused by this error after migrating to pydantic v2.

Indeed it does seem like it’s a duplicate of that issue. You’ll have to do Annotated[Decimal, Field(…)] | None.

OK but I can't use default in Field. Where can I use default? (I know the problem solved with =None)
from typing import Annotated

from pydantic import BaseModel, Field
from decimal import Decimal

class Wallet(BaseModel):
    name: str
    amount: Annotated[Decimal, Field(default=None, decimal_places=16, max_digits=32)] | None

my_wallet = Wallet(name='moein')

default applies to the field itself (a type can't really have a default in the abstract) so it needs to be at the outer level (either in Annotated or as part of a Field or plain default value):
from typing import Annotated

from pydantic import BaseModel, Field
from decimal import Decimal

class Wallet(BaseModel):
    name: str
    amount: Annotated[Decimal, Field(decimal_places=16, max_digits=32)] | None = None
    # or
    # amount: Annotated[Decimal, Field(decimal_places=16, max_digits=32)] | None = Field(None)
    # or, but type checkers won't like it as much
    # amount: Annotated[Annotated[Decimal, Field(decimal_places=16, max_digits=32)] | None, Field(None)]

my_wallet = Wallet(name='moein')


Packages loaded again after packloadall

Describe the bug
My understanding of the documentation for packages is that they should only be loaded once, whether automatically or as a result of packloadall:
To load packages earlier, so that 'runtimepath' gets updated:
        :packloadall
This also works when loading plugins is disabled.  The automatic loading will
only happen once.

However I am seeing them being loaded twice: firstly as a result of packloadall, called from .vimrc, then as part of the regular load sequence (I assume)
To Reproduce
cd $(mktemp -d)
cat <<EOD > .vimrc
packloadall
EOD
mkdir -p ./.vim/pack/plugins/start/example/plugin
cat <<EOD > ./.vim/pack/plugins/start/example/plugin/example.vim
echom "Hello from example"
EOD
HOME=$PWD vi

You will see the output:
Hello from example
Hello from example
Press ENTER or type command to continue

Expected behavior
Hello from example
Press ENTER or type command to continue

Screenshots
n/a
Environment (please complete the following information):

Vim version

VIM - Vi IMproved 8.1 (2018 May 18, compiled Jun 13 2019 12:32:13)
Included patches: 1-1518
Compiled by myitcv@myitcv
Huge version with GTK2 GUI.  Features included (+) or not (-):
+acl               -farsi             -mouse_sysmouse    -tag_any_white
+arabic            +file_in_path      +mouse_urxvt       -tcl
+autocmd           +find_in_path      +mouse_xterm       +termguicolors
+autochdir         +float             +multi_byte        +terminal
-autoservername    +folding           +multi_lang        +terminfo
+balloon_eval      -footer            -mzscheme          +termresponse
+balloon_eval_term +fork()            -netbeans_intg     +textobjects
+browse            +gettext           +num64             +textprop
++builtin_terms    -hangul_input      +packages          +timers
+byte_offset       +iconv             +path_extra        +title
+channel           +insert_expand     -perl              +toolbar
+cindent           +job               +persistent_undo   +user_commands
+clientserver      +jumplist          +postscript        +vartabs
+clipboard         +keymap            +printer           +vertsplit
+cmdline_compl     +lambda            +profile           +virtualedit
+cmdline_hist      +langmap           +python            +visual
+cmdline_info      +libcall           -python3           +visualextra
+comments          +linebreak         +quickfix          +viminfo
+conceal           +lispindent        +reltime           +vreplace
+cryptv            +listcmds          +rightleft         +wildignore
+cscope            +localmap          -ruby              +wildmenu
+cursorbind        +lua               +scrollbind        +windows
+cursorshape       +menu              +signs             +writebackup
+dialog_con_gui    +mksession         +smartindent       +X11
+diff              +modify_fname      -sound             -xfontset
+digraphs          +mouse             +spell             +xim
+dnd               +mouseshape        +startuptime       +xpm
-ebcdic            +mouse_dec         +statusline        +xsmp_interact
+emacs_tags        -mouse_gpm         -sun_workshop      +xterm_clipboard
+eval              -mouse_jsbterm     +syntax            -xterm_save
+ex_extra          +mouse_netterm     +tag_binary
+extra_search      +mouse_sgr         -tag_old_static
   system vimrc file: "$VIM/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
  system gvimrc file: "$VIM/gvimrc"
    user gvimrc file: "$HOME/.gvimrc"
2nd user gvimrc file: "~/.vim/gvimrc"
       defaults file: "$VIMRUNTIME/defaults.vim"
    system menu file: "$VIMRUNTIME/menu.vim"
  fall-back for $VIM: "/home/myitcv/usr/vim/share/vim"
Compilation: gcc -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_GTK  -pthread -I/usr/include/gtk-2.0 -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include -I/usr/include/gio-unix-2.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/fribidi -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/libpng16   -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: gcc   -L/usr/local/lib -Wl,--as-needed -o vim   -lgtk-x11-2.0 -lgdk-x11-2.0 -lpangocairo-1.0 -latk-1.0 -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lpangoft2-1.0 -lpango-1.0 -lgobject-2.0 -lglib-2.0 -lfontconfig -lfreetype -lSM -lICE -lXpm -lXt -lX11 -lXdmcp -lSM -lICE  -lm -ltinfo -lnsl   -ldl  -L/usr/lib/x86_64-linux-gnu -lluajit-5.1  -L/home/myitcv/.pythons/2.7.15/lib/python2.7/config -lpython2.7 -lpthread -ldl -lutil -lm -Xlinker -export-dynamic

OS: Ubuntu 19.04
Terminal: XTerm(330)

Additional context
Add any other context about the problem here.

Paul Jolly wrote:

Describe the bug
My understanding of the documentation for packages is that they should only be loaded once, whether automatically or as a result of packloadall:
To load packages earlier, so that 'runtimepath' gets updated:
        :packloadall
This also works when loading plugins is disabled.  The automatic loading will
only happen once.

However I am seeing them being loaded twice: firstly as a result of packloadall, called from .vimrc, then as part of the regular load sequence (I assume)
To Reproduce
cd $(mktemp -d)
cat <<EOD > .vimrc
packloadall
EOD
mkdir -p ./.vim/pack/plugins/start/example/plugin
cat <<EOD > ./.vim/pack/plugins/start/example/plugin/example.vim
echom "Hello from example"
EOD
HOME=$PWD vi

You will see the output:
Hello from example
Hello from example
Press ENTER or type command to continue

Expected behavior
Hello from example
Press ENTER or type command to continue

This happens because when a package is loaded, its directory is added to
'runtimepath'.  When after reading the vimrc the plugins are loaded, for
all directories in 'runtimepath', it is encountered again.
It's not easy to avoid.  And plugins should be able to handle being
loaded twice, thus I'm not sure we should try fixing this.
--
Apathy Error: Don't bother striking any key.
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

When after reading the vimrc the plugins are loaded, for all directories in 'runtimepath', it is encountered again. It's not easy to avoid

Ah that makes sense, thanks for the explanation.
I'll handle this within the plugin


:: command not found:

Hello. I am using oh-my-zsh and found an issue. In the first place I thought it was an issue in ack-grep, because this was the command I experienced the issue first. Then it turned out it probably is more about the shell I am using. So here you go.
vagrant@xenial ack-grep --version
ack 2.14
Running under Perl 5.22.1 at /usr/bin/perl

Copyright 2005-2014 Andy Lester.

This program is free software.  You may modify or distribute it
under the terms of the Artistic License v2.0.
vagrant@xenial ack-grep Foo().Bar
vagrant@xenial ack-grep
ack-grep:2: command not found: .Bar
vagrant@xenial ack-grep --version
ack-grep:3: command not found: .Bar

vagrant@xenial zsh --version
zsh 5.1.1 (x86_64-ubuntu-linux-gnu)

vagrant@xenial tar --version
tar (GNU tar) 1.28
Copyright (C) 2014 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by John Gilmore and Jay Fenlason.
vagrant@xenial tar Foo().Bar
vagrant@xenial tar --version
tar:3: command not found: .Bar

See also the original issue in the ack-grep repo: https://github.com/petdance/ack2/issues/612. Have somebody an idea what is going on here?

That's actually a zsh syntax error running without errors. Your statement turns tar into a function. See:
$ tar Foo().Bar
$ which tar
tar () {
	.Bar
}

Now, I don't know if that's intended behavior or it should throw a syntax error (which you get on bash), but in any case this would never work. Parenthesis, curly braces and square brackets are symbols that are interpreted by the shell, so you have to quote them always: tar 'Foo().Bar'. That and certain globbing characters like asterisk (*), question mark (?) and equal sign (=).
TL;DR: always be quoting.

IMO this issue points to a problem that is not solved. Closing this issue is thus not the right thing to do. I would rather appreciate trying to fix the problem instead of telling the user to fix is behaviour, which never works. Software needs to be fixed, not the user. Since the technical details of your explanation are correct, the user does not care at all about them. The user has a problem, which still exists, even though you are closing the issue.

Ok maybe I'm not explaining myself correctly. Zsh and Bash and other shells use parenthesis to define functions. There's no going around that. If you use parenthesis you have to tell to the shell that you mean a string which contains parenthesis, which you do by quoting the argument. There is no software to be fixed.
You define functions with parenthesis. You de define strings that contain parenthesis by putting them inside quotes. That's just the shell language syntax. And so is in many other languages. Just quote the string and it'll work.
Now, you can make the argument that the error it spits out is confusing. The way bash works is spitting a syntax error:
$ tar Foo().Bar
bash: syntax error near unexpected token `('

So probably zsh should just output a syntax error when doing that. I'm not exactly sure why that doesn't happen, but you'll need to ask that over to the official zsh mailing list. Hope that clears things up.

I see this might not an issue related to oh-my-zsh. Closing this issue here is fine then. What is not correct thought is There is no software to be fixed. Anyway, not your problem. Thanks clarifying the situation.

I mean that you'll have the same problem when trying to use it with ack-grep, only that there would be a syntax error.
But maybe that is a valid function definition statement and I don't know about it. Anyway the folks at zsh will know about it better than I do.


Add a LICENSE file

Hello,
Thank you for this library, gaussian splatting are progressing fast !
It seems that this repository lacks a proper mention of the licence applied. Could you specify it in the README and add a LICENSE file so that we know if it is opensource or not ?
The licence of the code can be different from the terms and conditions of the Luma service of course.

Seconded - I don't think anyone can realistically use this without it?

1675e0ccd00d6eaa97ec1f8601f39de55d099126


HSEARCH-1792 Multi-tenancy support

https://hibernate.atlassian.net/browse/HSEARCH-1792
This patch will add support for multi-tenancy to hibernate search by keeping track of the tenant id in the Work class and storing it in the index,
Documentaitno is currently missing but I will add it if the solution make sense.
@Sanne what do you think?

merged after some pair programming


fix(operator): increase operator resource limits

The operator container won't start with to low resource restrictions.
Seen when trying to install v0.10.0 on Openshift 4.7.7

/test openshift

@aslakknutsen: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

e2e-tests-openshift
d5ccfce6f93dff69ae0fc212c41da2417a58dffd
link
/test openshift

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test openshift

/test openshift

/test openshift

@aslakknutsen: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

e2e-tests-openshift
d5ccfce6f93dff69ae0fc212c41da2417a58dffd
link
/test openshift

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test openshift

@aslakknutsen: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

e2e-tests-openshift
13df9c974f0a327281875421d39c808cc40f2d5a
link
/test openshift

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test openshift

@aslakknutsen: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

e2e-tests-openshift
13df9c974f0a327281875421d39c808cc40f2d5a
link
/test openshift

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test openshift

@aslakknutsen: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

e2e-tests-openshift
13df9c974f0a327281875421d39c808cc40f2d5a
link
/test openshift

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test openshift

@aslakknutsen: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

e2e-tests-openshift
13df9c974f0a327281875421d39c808cc40f2d5a
link
/test openshift

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test openshift

@aslakknutsen: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

e2e-tests-openshift
13df9c974f0a327281875421d39c808cc40f2d5a
link
/test openshift

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test openshift

/test openshift

/test openshift

@aslakknutsen: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

e2e-tests-openshift
912c4fdc359b0ad1bd2d4346cdbf0d803b86884b
link
/test openshift

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test openshift


Cannot refactor - File not found

I have a refactor issue after last update.

VSCode Version:
1.9.0
OS Version:
Windows 8.1 Pro x64

Steps to Reproduce:

Select and press F2
Rename and hit enter
Warning message: "File not found (\path\to\current\file.js)"

Note: This does not happen in every file. I tried to create blank folder with new .js file and refactoring worked correctly. I'm not sure what causes this behavior...

I have not experienced this issue since I solved #19753

Closed this as this is due to #19753


User information is hard to read because of busy background.

See attached screenshot.
To reproduce: select any person.

We have made some changes on that accordingly. Thanks so much for the suggestions!


Audit logging support

Is your feature request related to a problem? Please describe.
Audit logging is a requirement from most compliance standards (e.g. FedRAMP, PCI-DSS). Pinniped doesn't provide a way to meet these compliance requirements today.
Describe the solution you'd like
Just like the API Server has capabilities to provide Audit logs for all API requests, Pinniped components should provide auditable log for events such as login attempts, access denied events, session creation, termination etc.

This is (mostly) done in #2009. Gaps in auditing should be indicated with future issues.


Fetch tag count data with the persistent segment adapter

This commit uses the persisted data rather than the session data to calculate whether a user should be in a segment based on what tagged articles they've visited.
This will cause one database query per pageview for a logged-in user, per segment that is currently enabled. The query is of the form:
SELECT COUNT(*)
    FROM (SELECT page_id, COUNT(page_id) FROM "table"
        WHERE (visited_at >= $TIMESTAMP AND visited_at <= $TIMESTAMP AND tag_id = $ID AND user_id = $ID)
        GROUP BY page_id)

This isn't terrible because at least it's only using one table, but it's still not ideal.

👍


Is there a concurrent stressing testing and its performance report on Java-WebSocket?  Thanks!

Is there a concurrent stressing testing and its performance report on Java-WebSocket?  Thanks!

No, we currently have no stress test running.
Best regards,
Marcel

OKay, thank you so much for reply!!!


New term requests: N2,3-ethenoguanine (N2,3-εG) and 1,N2-ethenoguanine (1,N2-εG)

It would be great if N2,3-ethenoguanine (N2,3-εG) and 1,N2-ethenoguanine (1,N2-εG) could be added.
N2,3-εG is on PubChem: https://pubchem.ncbi.nlm.nih.gov/compound/176480
The 1,N2-εG nucleoside is on PubChem: https://pubchem.ncbi.nlm.nih.gov/compound/481078
Both would have HAS FUNCTIONAL PARENT relationships to guanine (CHEBI:16235).
A couple of relevant references:

Prem D. Sattsangi, Nelson J. Leonard & Charles R. Frihart (1977). 1,N2-Ethenoguanine and N2,3-ethenoguanine. Synthesis and comparison of the electronic spectral properties of these linear and angular triheterocycles related to the Y bases. The Journal of Organic Chemistry, 42, 3292-3296.
Chang SC, Fedeles BI, Wu J, et al. Next-generation sequencing reveals the biological significance of the N(2),3-ethenoguanine lesion in vivo. Nucleic Acids Res. 2015;43(11):5489-500.

Hi,
These two entities have been added to CHEBI
N2,3-ethenoguanine (CHEBI:134095)
1,N2-ethenoguanine (CHEBI:134096)
Kind regards,
Steve


Delete valid duplicate indexes doesn't clear command line

Yet it deletes the person correctly. I think it deletes the person, then runs into an error and dies
Before entering command

After entering command

#266


merge from arlac77/template-arlac77-github,arlac77/template-esm-only,arlac77/template-nginx,arlac77/template-pacman,arlac77/template-systemd

README.md

docs(README): update from template

Pull Request Test Coverage Report for Build 3805

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.871%

Totals

Change from base Build 3802:
0.0%

Covered Lines:
72

Relevant Lines:
87

💛  - Coveralls


ModuleNotFoundError: No module named 'binance'

Hi, i installed python-binance with pip.
But whenever i try to use it with from binance.client import Client i get this error ModuleNotFoundError: No module named 'binance.
I use Python 3.7.7 and the latest version of PyCharm.
Can anyone help me ? :(

Have you selected the correct interpreter in the settings?
In File -> Settings -> Project -> Project Interpreter, you can select the appropriate Python Interpreter.
Here is a tutorial.

I think so:

I aslo tried to install python-binance through pycharm and this message showed up:


Container App Job fails to use User Assigned Managed Identity

This issue is a: (mark with an x)

[ x] bug report -> please search issues before submitting
[ ] documentation issue or request
[ ] regression (a behavior that used to work and stopped in a new release)

Issue description
I have a Container App Cron job that uses a user-assigned managed identity. The managed identity has the AcrPull role, but the Container App job fails, and Log Analytics logs the following error:
MountVolume.SetUp failed for volume "identity-config" : configmap "biotrackr-auth-identity" not found

Steps to reproduce
Review the following Terraform template for creating the job:
data "azurerm_resource_group" "rg" {
  name = var.resource_group_name
}

data "azurerm_container_app_environment" "env" {
  name                = var.env_name
  resource_group_name = data.azurerm_resource_group.rg.name
}

data "azurerm_user_assigned_identity" "msi" {
  name                = var.uai_name
  resource_group_name = data.azurerm_resource_group.rg.name
}

data "azurerm_container_registry" "acr" {
  name                = var.acr_name
  resource_group_name = data.azurerm_resource_group.rg.name
}

resource "azurerm_container_app_job" "job" {
  name                         = var.aca_app_name
  location                     = data.azurerm_resource_group.rg.location
  resource_group_name          = data.azurerm_resource_group.rg.name
  tags                         = var.tags
  container_app_environment_id = data.azurerm_container_app_environment.env.id
  template {
    container {
      name   = var.aca_app_name
      image  = var.image_name
      cpu    = 0.25
      memory = "0.5Gi"
    }
  }
  replica_timeout_in_seconds = 60
  replica_retry_limit        = 3
  schedule_trigger_config {
    cron_expression          = "*/15 * * * *"
    parallelism              = 1
    replica_completion_count = 1
  }

  registry {
    server   = data.azurerm_container_registry.acr.login_server
    identity = data.azurerm_user_assigned_identity.msi.id
  }

  identity {
    type         = "UserAssigned"
    identity_ids = [data.azurerm_user_assigned_identity.msi.id]
  }
}

This is the terraform for implementing the ACR, MSI, and role assignment:
module "usi" {
  source   = "../modules/user-assigned-identity"
  name     = var.user_assigned_identity_name
  location = var.location
  rg_name  = module.resource_group.name
  tags     = var.tags
}

module "acr" {
  source                    = "../modules/container-registry"
  name                      = var.acr_name
  location                  = var.location
  rg_name                   = module.resource_group.name
  sku                       = var.acr_sku
  admin_enabled             = var.acr_admin_enabled
  user_assigned_identity_id = module.usi.user_assinged_identity_id
  tags                      = var.tags
}

module "acr_pull_role" {
  source       = "../modules/role-assignment"
  role_name    = var.acr_pull_role_name
  principal_id = module.usi.user_assinged_identity_principal_id
  scope_id     = module.acr.acr_id
}

This is the logic that the job is doing. Very basic .NET worker:
using Microsoft.Extensions.Hosting;
using Microsoft.Extensions.Logging;
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;

namespace Biotrackr.Auth
{
    public class AuthWorker : BackgroundService
    {
        private readonly ILogger<AuthWorker> _logger;
        private readonly IHostApplicationLifetime _appLifetime;

        public AuthWorker(ILogger<AuthWorker> logger, IHostApplicationLifetime appLifetime)
        {
            _logger = logger;
            _appLifetime = appLifetime;
        }

        protected override async Task<int> ExecuteAsync(CancellationToken stoppingToken)
        {
            try
            {
                _logger.LogInformation($"Hello there! Biotrackr.Auth running at {DateTime.Now}");
                return 0;
            }
            catch (Exception ex)
            {
                _logger.LogError($"Exception thrown: {ex.Message}");
                throw;
            }
        }
    }
}

Implemented in a Program.cs file like so:
using Biotrackr.Auth;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Hosting;

IHost host = Host.CreateDefaultBuilder(args)
    .ConfigureServices(services =>
    {
        services.AddHostedService<AuthWorker>();
    })
    .Build();

host.Run();

The full code (with all Terraform modules and C# code) can be found here: https://github.com/willvelida/biotrackr
Expected behavior [What you expected to happen.]
For Log Analytics to log out the message, and for the container app job to be successful
Actual behavior [What actually happened.]
Container App job fails due to the following error:
MountVolume.SetUp failed for volume "identity-config" : configmap "biotrackr-auth-identity" not found

@willvelida can you please share your job's resource id with us at acasupport@ microsoft.com and reference this issue? Thanks! 🙂

Thanks @anthonychu, just emailed you now :)

@anthonychu we can mark this as resolved - Thanks to the team for helping me with this offline!
For those wondering what the solution is, I had a Container App that I was running as a Dapr cron job called biotrackr-auth. I used the same name for a normal job, and while the Terraform deployment destroyed the old Container App and created a new job, using the same name caused a transient issue as they were trying to execute at the same time.
I resolved it by using a new name.


Add bullet digraph

Missing digraph for the  Bullet (punctuation) symbol.
I am not sure, if oo is the best digraph. Probably bp as bullet point would be better.
Unicode Character 'BULLET' (U+2022)
Don't be confused with math symbol BULLET OPERATOR

I can't find any recommendation for 0x2022.  We can use oo until something pops up.


Refactor options

All the options and the init part need a small refactoring. Might solve the startup issue also.

Also the WATCH_STATES, etc stuff need to be renamed to modifiers also in the code.
The options are the sleep_min, etc stuff


Register Endpoint - Default + failure to show in table

Ensure CF is automatically selected as type
Once added and modal is closed the new endpoint fails to appear in endpoint table

Both have been fixed


Readme doc for this repo needs to be updated to reflect new build/make process

The old build process, using make source, is now obsolete. A new process needs to be documented to detail the way the package is currently built.

Fixed via #230


Add shutter group to HomematicIP Cloud

Proposed change
Add shutter group to HomematicIP Cloud
Type of change

[ ] Dependency upgrade
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New integration (thank you!)
[x] New feature (which adds functionality to an existing integration)
[ ] Breaking change (fix/feature causing existing functionality to break)
[ ] Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:

Checklist

[x] The code change is tested and works locally.
[x] Local tests pass. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist
[x] The code has been formatted using Black (black --fast homeassistant tests)
[x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
[ ] Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

[ ] No score or internal
[ ] 🥈 Silver
[ ] 🥇 Gold
[x] 🏆 Platinum

@SukramJ please update the documentation accordingly :)

Groups are not documented for HomematicIP Cloud (same as hue, doconz), so there is no open tasks, and i think this is not required.


 What do you see instead?

i change the code in YUICompressor.php:

if(!exec(self::_getCmd($options, $type, $tmpFile), $output, $revar)){
            throw new Exception('Minify_YUICompressor command error code: ' . $revar);
};

sorry for my English!

Please use labels and text to provide additional information.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 18 Aug 2011 at 9:21

php version is 5.1.6
java is 1.6.0
centOS 5

Original comment by<EMAIL_ADDRESS>on 18 Aug 2011 at 9:26

This seems solved in 2.1.5 (exit code is checked)

Original comment by<EMAIL_ADDRESS>on 29 Mar 2012 at 7:18

Original comment by<EMAIL_ADDRESS>on 29 Mar 2012 at 8:04

Changed state: Verified


Feature request: macOS - show/hide sidebar setting

Hey,
It'd be awesome if the show/hide sidebar preference was saved when closing the app, as is the show/hide toolbar setting.
Thanks!

Agreed!


PWA: Cannot fetch files in a remote repo after going back online

Testing #141296
Repro steps:

Open a remote repo in https://insiders.vscode.dev/
Go offline, wait for the red status bar + "offline" status to appear
Try to open some of the files, see the "Failed to fetch" messages
Go back online, wait for the red status bar to disappear
Try to open the same files, same "Failed to fetch" messages appear

Yeah it seems some layer caches the error promises. Two possibilities:

Core workbench services @bpasero
Remote Repositories extension @joyceerhl

The problem is not the Failed to fetch per se, but rather that some code caches that error when it happens due to being offline but keeps returning it even after going online, when the promise would actually succeed.

The console shows this error:
  ERR HttpError: Failed to fetch
    at eval (extension.js:117:7584)
    at Su.request (extension.js:119:25450)
    at Su.getBlobContent (extension.js:219:727)
    at Su.getFileContent (extension.js:219:1422)
    at vc.readFile (extension.js:112:14864)
    at Ys.readFile (extension.js:107:27024)

The extension is: https://github.vscode-unpkg.net/GitHub/remotehub/0.23.2022012602/extension/dist/browser/extension.js#vscode-extension:formatted

@joaomoreno is spot on, RemoteHub constructs a filetree representing the repo contents where each file has a memoized getContent method that returns a promise resolving to the file contents. That's where the stacktrace above is coming from. We need to know when to clear out the memoized promise. We could use some heuristics like refetching the filetree when we see a 'failed to fetch' like the above.

Still reproduces for me
Offline:

Back online:


Recover transaction pool on light client

It has been broken since #3538
TLDR: this PR introduces 'generic' light tx pool, which should work on all chains. There's a way to override different parts of this 'generic' implementation with chain-specific implementations. The chain specific implementation could, sometimes, be better than generic.
PART 1. What needs to be implemented.
Basically, it is:
1.1) validation of transactions on light client;
1.2) removal of 'mined' transactions on light client;
1.3) removal of 'invalid' transactions on light client;
1.4) moving transactions between 'ready' and 'future' queues on light client.
PART 2. Validation of transactions on light client.
Options that I have considered:
2.1) do not validate transactions at all - just broadcast to full nodes
2.1.PROS) fastest option;
2.1.CONS) I assume the submitter wants to know if his transaction is valid asap + it is impossible to prune invalid transactions from the pool just by looking at the blocks (it will never be included);
2.2) require specific implementation for every chain:
2.1.PROS) chain-specific implementation could be simpler/faster than generic. Like we could use proof-of-read of account nonce instead of proof-of-call of fn TaggedTransactionQueue::validate_transaction(). Or we might have a chain where validation could be performed on full node, if all required information is available from block headers;
2.2.CONS) it isn't always possible to write better than generic validation + writing specific implementation is an optimization task + we might want to get slow, but functional light client in the beginning;
2.3) provide generic implementation, but allow overriding it by chain-specific implementations:
2.3.PROS) easy-to-start + might be optimized later;
2.3.CONS) requires proof-of-call from remote nodes
So I've chose the option 2.3. In the code it is in the LightChainApi. The specific implementation could be provided when transaction pool is created.
Part 3. Removal of 'mined' transactions on light client.
Options that I have considered:
3.1) chain-specific removal. E.g. we can fetch proof-of-read of account nonce from remote node and prune all transactions with nonce < than provided
3.1.PROS) may be faster if we could figure out whether tx has been included from the header
3.1.CONS) the same as in 2.2.CONS
3.2) generic removal by fetching proof-of-inclusion
3.2.PROS) -
3.2.CONS) should be fast enough for most of implementations
I've chose the option 3.2. But in this PR there's no proof-of-inclusion - instead we fetch bodies of all transactions for every block when txpool is not empty and prune these transactions from the pool. If PR will be accepted, I'll file an issue about this optimization.
Part 4 and 5. Moving transactions between 'future', 'ready' and 'invalid' states.
First of all, I've made a controversial decision that on light client we do not accept transactions to the 'future' queue. That's because it is impossible to know whether transaction should be moved to the 'ready' queue without revalidation. And I wanted to avoid much revalidaton calls, because they're quite heavy in 'generic' implementation. Also - 'ready'/'future' state depends on transactions that are in transaction pool. Like the same transaction could be moved to 'ready' queue if tags that it requires are satisfied by other transactions from the 'ready' queue. At the same time, on other node it could be moved to the 'future' queue if the 'satisfying' transaction is missing. That said, I'm not sure - whether this restriction makes sense, or not. So any opinion/advice is appreciated.
So after this restriction, we only have 'ready' and 'invalid' states. And the only possible transition is from 'ready' to 'invalid' state. Iiuc, on full client, this transition is detected when some of mined transactions are providing the same tags => then the 'ready' transaction is revalidated. On light client it isn't a good idea to revalidate every transaction from every block (just to receive tags that it provides). So the (not best, but functional) solution is to perform revalidation at some intervals.  These constants can be overrided. And the whole mechanism could be overrided by passing chain-specific 'TranasctionPoolMaintainer' implementation to fn ServiceBuilder::with_transaction_pool_maintainer().
Part 6, unrelated. Accounts RPC.
When I was testing this PR, I found that "Accounts RPC methods" from node are (now?) required to submit transaction to the pool. So I've also fixed it in this PR. The fix is localized in the node/rpc/src/* and additional argument is added to the fn ServiceBuilder::with_rpc_extensions(). But if required, I could extract this fix to the separate PR.

(this pr was accidently linked in another one as being fixed)

So I've made a new TransactionPool trait. However, I haven't introduced two implementations - FullTransactionPool and LightTransactionPool. This is because I want to provide ability to customize PoolApi and Maintainer for (at least) light nodes (see notes about this in description). And when I made LightTransactionPool and FullTransactionPool generic over PoolApi and Maintaner, the implementation was exactly the same.
Main changes are - tx pool clients are now generic over TransactionPool instead of ChainApi. Also maintain procedure is now a part of the pool implementation itself.
I had to wrap all the futures that TransactionPool returns in the Box because otherwise too many impl details are to be exposed (also to avoid multi-multi-lines Futures declarations) and I'm unable to return impl Future from the trait, obviously. Also there's a bit more methods than simply submit(), ready() and maintain() - it appears that we need to subscribe to pool transactions (hence import_notification_stream), we need to report poll status to telemetry (hence status), ...
After doing this, I'm not sure that traitifying TransactionPool was a perfect idea - we still have a single implementation (BasicTransactionPool instead of txpool::Pool) that is generic over PoolApi and Maintainer. What do you think on that?

So here's now core/src/transaction-pool/api - the create that defines the TransactionPool trait, TransactionPoolMaintainer and InPoolTransaction trait. Besides that, it declares MaintainableTransactionPool struct that is able to merge two structs that are implementing TransactionPool and TransactionPoolMaintainer into a single struct that implements both.
Normally, everyone would use 'basic' implementations from core/src/transaction-pool - BasicPool<FullChainApi> and BasicPool<LightChainApi>, though one could customize Api implementation. There are also two default maintainer implementations in this crate - FullBasicPoolMaintainer and LightBasicPoolMaintainer.
No crates except those who create transaction pools are now depend on substrate-transaction-pool crate. Though, it is still referenced by significant amount of crates, because basic implementation is used in tests

Corresponding fix of polkadot is here. I'm not opening PR because don't know if (and when) this PR will be approved. Will open polkadot PR once if it is approved.

@tomusdrw Thanks for merging with master! I've resolved another bunch of conflicts - mostly caused by #4145 . The main change is that now offchain::TransactionPool is implemented for txpool_api::MaintainableTransactionPool (before it has been implemented for transaction_graph::Pool). It would be better to have blanket impl, but TransactionPool traits are in different crates && I can't move common trait TransactionPool to primitives, because it depends on sr_primitives.
(note that corresponding PR in polkadot isn't opened until this PR is approved)


Connected Accounts

Platform

[x] Web
[ ] iOS
[ ] Android

Describe the bug
Initializing Stripe with a connected account ID does not link payment intent confirms to this connected account. I am passing the customer ID of the connected account as well as the ephemeral key which has been generated for the customer of a connected account. I can see both ephemeral keys & payment intent events in the connected customer logs but confirming the payment with test info gives an "Unrecognized request URL" error.
Expected behavior
Stripe should initialize with the connected account ID
Additional context
async paymentSheet() {
    var keys: Keys;
    // Connect to your backend endpoint, and get every key.
    this.http
      .get<Keys>('api/AppBasket/GetStripeKeys')
      .subscribe({
        next: async (v) => {
          keys = v;
          // prepare PaymentSheet with CreatePaymentSheetOption.
          await Stripe.createPaymentSheet({
            paymentIntentClientSecret: keys.PaymentIntentClientSecret,
            customerId: keys.CustomerId,
            customerEphemeralKeySecret: keys.StripeEphemeralKey,
          });
          const result = await Stripe.presentPaymentSheet();
          if (result.paymentResult === PaymentSheetEventsEnum.Completed) {
            console.log('completed');
          }
        },
      });
  }

export class AppComponent {
  constructor() {
    Stripe.initialize({
      publishableKey: env.testKey,
      stripeAccount: env.ConnectedAccount,
    });
  }
}

Product Name:
Product URL :
Using Function:

[x ] Payment Sheet / Payment Flow
[ ] Apple Pay
[ ] Google Pay
[ ] Identity Verification Sheet

https://github.com/capacitor-community/stripe/blob/main/packages/payment/src/web.ts#L84
We set a value in stripeAccount. This appears to be a stripe-pwa-elements issue.
https://github.com/wpkyoto/stripe-pwa-elements
to raise an Issue.


python3Packages.luftdaten: init at 0.1.4

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg eval

@GrahamcOfBorg eval

I created a server too small to run the evaluator. Let's try again.
@GrahamcOfBorg eval

Thanks for your efforts @grahamc

Failure on aarch64-linux (full log)
Partial log (click to expand)
error: Please be informed that this pseudo-package is not the only part of
Nixpkgs that fails to evaluate. You should not evaluate entire Nixpkgs
without some special measures to handle failing packages, like those taken
by Hydra.

Failure on x86_64-linux (full log)
Partial log (click to expand)
error: Please be informed that this pseudo-package is not the only part of
Nixpkgs that fails to evaluate. You should not evaluate entire Nixpkgs
without some special measures to handle failing packages, like those taken
by Hydra.

Guh .. that is a concerning error... sorry for the spam.


Add flag to nixos-rebuild

In the case we need sudo for the remote target, the flag
--use-remote-sudo must be passed if the target's ssh user is not root.
If target's ssh user is root, it doesn't hurt to use sudo.

@Mic92 care to review (saw you were active “recently”)

That was fast! thx


add workinghours option

@rentzso Could you please do a quick sanity check?

LGTM

Merged manually into aloha.


Resolving Issue #141

the following things  are done for OpenWhisk Adapter

Fixing NPE caused when no payload is sent, with this commit the user will get JSON response like {"result":"No input provided"}
Fixing the ClassCast Exception
Refactor class Names to be inline with other Adapters e.g. FunctionInitializer --> OpenWhiskFunctionInitializer
Add UT for OpenWhiskActionHandler

@kameshsampath Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@kameshsampath Thank you for signing the Contributor License Agreement!

thanks @dsyer


Needs joblib module

I had an issue with the PyPy package so I installed directly from github (pip install git+git://github.com/ajtulloch/sklearn-compiledtrees). It's missing joblib, which I had install myself.

Fixed by #20


Bump BoringSSL version.

Add a SSL process tls13 new session ticket and bump minimum CMake version to 3.3.

Thanks for the PR @froseiun. However this is superseded by https://github.com/cloudflare/quiche/pull/546 as it needs additional changes.


Set default sampling points in subvolume to 10,000

currently it's 100

10, 000 was the number recommended by Brian when we asked him what the default should be.
In the example DVC input file, which comes with the executable, it is set to 8000


TDR-3507 Add references to File case class to be included in bagit export

Looks good. The ConsignmentRouteSpec all data query should be updated as well to include the new fields in the unit tests

I've added the new fields to the unit tests. Not sure if you wanted me to add them to the pagination queries but I've done it for the main all data and file queries.


Add ignoreGitDirtyLocalPods

Description
Add ignoreGitDirtyLocalPods flag for ignore dev pod which git is dirty.
References
Provide links to an existing issue or external references/discussions, if appropriate.
Checklist

[x] I've added at least one test that validates that my change is working, if appropriate
[x] I've followed the code style of the rest of the project
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary

❤ Thanks for contributing to the 🏈 Rugby!

Hello @mlch911! Could you please describe a case when we need such a new flag?

Our App has so many develop Pods to split different module. So our pod changes frequently.
And we usually works on several Pods at once. So we need this flag to cache all other Pods we don't need for now.

So, do you make some changes in several pods just before using 🏈 Rugby? Is it convenient?
Have you tried such command yet?
https://github.com/swiftyfinch/Rugby/blob/main/Docs/Cache.md#build-local-pods

If you want to focus on some local pods and cache all others:
rugby --focus MyFocusedPod1 MyFocusedPod2

I work in huge project and pass to focus only about 10 local pods. It's pretty easy.

Thanks. I may try a better solution.


Learn why floating point functions fail

We have so many big functions that are nearly perfect, except for the fact that the floating point registers are swapped. Figuring out why this happens is important. Is it a compiler setting? Do we have the wrong compiler?
It may be worth writing a program which tries to run make with different permutations of compiler settings with a failing floating point function that we are certain should match.

Seil 12/26/2020
i think i know what the issue is with floats causing functions to be nonmatching
basically, all float constants are stored in the .sdata2 section. everything in that section is considered to be const data
so if you use the same float constant multiple times, the compiler will try to optimize it to where it only reads the float constant once instead of multiple times
for example, if you use a float constant inside a for loop, the compiler will actually move the lfs instruction outside of the loop, because the float constant in memory is not expected to change, so it only needs to be loaded once
however, more often than not, it seems like in the original asm, .sdata2 is NOT treated as const data. there are instances where the same float constant is loaded multiple times in the original asm but will only be loaded once in our asm. or a float constant will be loaded inside a loop in the original asm but loaded outside the loop in our asm
interestingly, this has only happened to me when using float literals. if i leave the float in the asm and extern it out, it's more likely that the compiler will load the float multiple times. maybe extern symbols in .sdata2 are not treated as const by default?
unfortunately I have yet to figure out how to force that behavior when using float literals. I've tried adding (DATA) to the .sdata2 section in the .lcf file, I've tried using every compiler from 1.1 to 2.7, I've tried messing with compiler flags, and I haven't been able to get that behavior to happen

https://github.com/bfbbdecomp/bfbb/pull/118

https://github.com/bfbbdecomp/bfbb/pull/118

This shouldn't be as big of a problem for us anymore. We have a shiftable build now and can work around floating point issues, the code doesn't have to match 100% as long as it matches functionally.

Changing this to not planned rather than completed, since we're simply working around it now, but would still like to fix the issue in the possible f possible.


Showcase vs Examples part of the website

Hi
Does the scrollbar still need help ?
What is blocking https://github.com/ratatui/ratatui-website/issues/249 ?
Also, on the website these two pages are very similar https://ratatui.rs/examples/widgets/ https://ratatui.rs/showcase/widgets/. Why not merging them (add links to doc.rs) ?

Does the scrollbar still need help ?
What is blocking https://github.com/ratatui/ratatui-website/issues/249 ?

Yes, for the scrollbar widget it would be nice to have a small example screenshot that looks good in context with the other examples, so yes please if you'd like to contribute something. Probably in the size available I'd show a few different examples of scrollbars in each orientation, with various customizations and colors to make them look good.

Also, on the website these two pages are very similar https://ratatui.rs/examples/widgets/ https://ratatui.rs/showcase/widgets/. Why not merging them (add links to doc.rs) ?

You're right that there's some overlap, but perhaps I could explain my thinking on this and it would help work out what to do:

The purpose of the examples is to show in simple terms how to use each widget. The goal is to make it easy to to combine the API docs with something which is the simplest running code without too much conceptual overhead. These examples choose code simplicity over good looks as their purpose is to teach. The examples are generally copied directly from the Ratatui repo each time we release. Additionally, the code for these examples also show up directly in the API docs.
The purpose of the showcase was to make it easy to see some ideas about how each widget can be used to create good looking apps, hopefully encouraging developers to move away from colorless bordered apps that lack soul and identity. These preferentially choose good looks over code simplicity. These are also designed to look good alongside https://ratatui.rs/showcase/third-party-widgets/. The showcase was created much later than the examples purely for the website.

So at a high level, it's teaching vs demo.
Right now we're also moving around the examples quite a bit for the next Ratatui release (0.30.0). Details in https://github.com/ratatui/ratatui/issues/1512 (TLDR - splitting things up into simple examples, demos / application style examples, and tools). This will end up being reflected in the example section of the website when we sync them.
Ideally each example would also have some narrative text associated with it (maybe worth LLM generating that), but we haven't got to that yet.
Given that context, I'd suggest that we should:

Leave the examples section alone as it's not the source of truth.
Move the showcase section earlier in the website tree to answer the question "What can I build" before "How can I build it"

Any other ideas you'd suggest?
Another approach might be to make each example page have a bunch of small screenshot + code examples to make it super easy to copy paste the code that solves your problem directly into your own code.

Thanks for the informations
I've updated the PR with

the image for scrollbar demo
links to the example code for each widget

Note that only LineGauge doesn't have an example

Ha - I didn't look at this carefully enough and thought I was responding to an issue rather than a PR.  Apologies for the brainfart :D


How to run your code

I can't run the code directly. Can you give me an introduction

Can you explain what you have tried?

Thank you for reading my questions late at night

Ahhh I think I might know what is wrong here. I will try to fix it as soon as possible

https://github.com/yxswy/league-connect.git  It was slightly modified

There was a tiny bug with how we got the certificate. That should be fixed now. Can you try to clone again and follow the instructions in /examples?

thanks, I go to try


Update Integration Process from Travis CI to Github Actions

Delete Travis CI file
Create Github Actions file
Push/Tag event will update package.

Recently switched over directly to new branches


Map broken

Checklist

[X] I've looked at the documentation to make sure the behavior isn't documented and expected.
[X] I'm sure this is an issue with Leaflet, not with my app or other dependencies (Angular, Cordova, React, etc.).
[X] I've searched through the current issues to make sure this hasn't been reported yet.
[X] I agree to follow the Code of Conduct that this project adheres to.

Steps to reproduce
Im following the documentation and still the map shows broken, the steps to reproduce is the same documentation just using flask.
Also navigator issues are discarded cause using folium of python the map is renderer correctly.
Sorry if im doing something wrong im new on this so hopefully i create the issue correctly
Expected behavior
See the complete map with the expected dimensions
Current behavior
The current behavior is a map broken that doesnt render as expected

Minimal example reproducing the issue
No response
Environment

Leaflet version: 1.9.4
Browser (with version): Microsoft Edge 119.0.2151.72
OS/Platform (with version): Windows 11

https://leafletjs.com/reference.html#map-invalidatesize