[SPARK-33428][SQL] Conv UDF use BigInt to avoid  Long value overflow

What changes were proposed in this pull request?
Use Long value store  encode value will overflow and return unexpected result, use BigInt to replace Long value and make logical more simple.
Why are the changes needed?
Fix value  overflow issue
Does this PR introduce any user-facing change?
People can sue conf function to convert value big then LONG.MAX_VALUE
How was this patch tested?
Added UT
BenchMark
/*
 * Licensed to the Apache Software Foundation (ASF) under one or more
 * contributor license agreements.  See the NOTICE file distributed with
 * this work for additional information regarding copyright ownership.
 * The ASF licenses this file to You under the Apache License, Version 2.0
 * (the "License"); you may not use this file except in compliance with
 * the License.  You may obtain a copy of the License at
 *
 *    http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

package org.apache.spark.sql.execution.benchmark

import scala.util.Random

import org.apache.spark.benchmark.Benchmark
import org.apache.spark.sql.functions._
object ConvFuncBenchMark extends SqlBasedBenchmark {

  val charset =
    Array[String]("0", "1", "2", "3", "4", "5", "6", "7", "8", "9",
      "A", "B", "C", "D", "E", "F", "G",
      "H", "I", "J", "K", "L", "M", "N",
      "O", "P", "Q", "R", "S", "T",
      "U", "V", "W", "X", "Y", "Z")

  def constructString(from: Int, length: Int): String = {
    val chars = charset.slice(0, from)
    (0 to length).map(x => {
      val v = Random.nextInt(from)
      chars(v)
    }).mkString("")
  }

  private def doBenchmark(cardinality: Long, length: Int, from: Int, toBase: Int): Unit = {
    spark.range(cardinality)
      .withColumn("str", lit(constructString(from, length)))
      .select(conv(col("str"), from, toBase))
      .noop()
  }

  /**
   * Main process of the whole benchmark.
   * Implementations of this method are supposed to use the wrapper method `runBenchmark`
   * for each benchmark scenario.
   */
  override def runBenchmarkSuite(mainArgs: Array[String]): Unit = {
    val N = 1000000L
    val benchmark = new Benchmark("conv", N, output = output)
    benchmark.addCase("length 10 from 2 to 16") { _ =>
      doBenchmark(N, 10, 2, 16)
    }

    benchmark.addCase("length 10 from 2 to 10") { _ =>
      doBenchmark(N, 10, 2, 10)
    }

    benchmark.addCase("length 10 from 10 to 16") { _ =>
      doBenchmark(N, 10, 10, 16)
    }

    benchmark.addCase("length 10 from 10 to 36") { _ =>
      doBenchmark(N, 10, 10, 36)
    }

    benchmark.addCase("length 10 from 16 to 10") { _ =>
      doBenchmark(N, 10, 10, 10)
    }

    benchmark.addCase("length 10 from 16 to 36") { _ =>
      doBenchmark(N, 10, 16, 36)
    }

    benchmark.addCase("length 10 from 36 to 10") { _ =>
      doBenchmark(N, 10, 36, 10)
    }

    benchmark.addCase("length 10 from 36 to 16") { _ =>
      doBenchmark(N, 10, 36, 16)
    }

    //
    benchmark.addCase("length 20 from 10 to 16") { _ =>
      doBenchmark(N, 20, 10, 16)
    }

    benchmark.addCase("length 20 from 10 to 36") { _ =>
      doBenchmark(N, 20, 10, 36)
    }

    benchmark.addCase("length 30 from 10 to 16") { _ =>
      doBenchmark(N, 30, 10, 16)
    }

    benchmark.addCase("length 30 from 10 to 36") { _ =>
      doBenchmark(N, 30, 10, 36)
    }

    //
    benchmark.addCase("length 20 from 16 to 10") { _ =>
      doBenchmark(N, 20, 16, 10)
    }

    benchmark.addCase("length 20 from 16 to 36") { _ =>
      doBenchmark(N, 20, 16, 36)
    }

    benchmark.addCase("length 30 from 16 to 10") { _ =>
      doBenchmark(N, 30, 16, 10)
    }

    benchmark.addCase("length 30 from 16 to 36") { _ =>
      doBenchmark(N, 30, 16, 36)
    }

    benchmark.run()
  }

}

Result with patch :
Java HotSpot(TM) 64-Bit Server VM 1.8.0_191-b12 on Mac OS X 10.14.6
Intel(R) Core(TM) i5-8259U CPU @ 2.30GHz
conv:                                     Best Time(ms)   Avg Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
------------------------------------------------------------------------------------------------------------------------
length 10 from 2 to 16                               54             73          18         18.7          53.6       1.0X
length 10 from 2 to 10                               43             47           5         23.5          42.5       1.3X
length 10 from 10 to 16                              39             47          12         25.5          39.2       1.4X
length 10 from 10 to 36                              38             42           3         26.5          37.7       1.4X
length 10 from 16 to 10                              39             41           3         25.7          38.9       1.4X
length 10 from 16 to 36                              36             41           4         27.6          36.3       1.5X
length 10 from 36 to 10                              38             40           2         26.3          38.0       1.4X
length 10 from 36 to 16                              37             39           2         26.8          37.2       1.4X
length 20 from 10 to 16                              36             39           2         27.4          36.5       1.5X
length 20 from 10 to 36                              37             39           2         27.2          36.8       1.5X
length 30 from 10 to 16                              37             39           2         27.0          37.0       1.4X
length 30 from 10 to 36                              36             38           2         27.5          36.3       1.5X
length 20 from 16 to 10                              35             38           2         28.3          35.4       1.5X
length 20 from 16 to 36                              34             38           3         29.2          34.3       1.6X
length 30 from 16 to 10                              38             40           2         26.3          38.1       1.4X
length 30 from 16 to 36                              37             38           1         27.2          36.8       1.5X

Result without patch:
Java HotSpot(TM) 64-Bit Server VM 1.8.0_191-b12 on Mac OS X 10.14.6
Intel(R) Core(TM) i5-8259U CPU @ 2.30GHz
conv:                                     Best Time(ms)   Avg Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
------------------------------------------------------------------------------------------------------------------------
length 10 from 2 to 16                               66            101          29         15.1          66.1       1.0X
length 10 from 2 to 10                               50             55           5         20.2          49.5       1.3X
length 10 from 10 to 16                              46             51           5         21.8          45.9       1.4X
length 10 from 10 to 36                              43             48           4         23.4          42.7       1.5X
length 10 from 16 to 10                              44             47           4         22.9          43.7       1.5X
length 10 from 16 to 36                              40             44           2         24.7          40.5       1.6X
length 10 from 36 to 10                              40             44           4         25.0          40.1       1.6X
length 10 from 36 to 16                              41             43           2         24.3          41.2       1.6X
length 20 from 10 to 16                              39             41           2         25.7          38.9       1.7X
length 20 from 10 to 36                              40             42           2         24.9          40.2       1.6X
length 30 from 10 to 16                              39             40           1         25.9          38.6       1.7X
length 30 from 10 to 36                              40             41           1         25.0          40.0       1.7X
length 20 from 16 to 10                              40             41           1         25.1          39.8       1.7X
length 20 from 16 to 36                              40             42           2         25.2          39.7       1.7X
length 30 from 16 to 10                              39             42           2         25.6          39.0       1.7X
length 30 from 16 to 36                              39             40           2         25.7          38.8       1.7X

Test build #130986 has started for PR 30350 at commit 6b2c41d.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35592/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35592/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35592/
Test PASSed.

Test build #130986 has finished for PR 30350 at commit 6b2c41d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130986/
Test FAILed.

Test build #131001 has started for PR 30350 at commit 1ccb5f3.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35607/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35607/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35607/
Test PASSed.

Test build #131001 has finished for PR 30350 at commit 1ccb5f3.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131001/
Test FAILed.

Test build #131027 has started for PR 30350 at commit f384c89.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35633/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35633/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35633/
Test PASSed.

Test build #131027 has finished for PR 30350 at commit f384c89.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131027/
Test FAILed.

Test build #131035 has started for PR 30350 at commit 6dcad9f.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35641/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35641/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35641/
Test PASSed.

Test build #131035 has finished for PR 30350 at commit 6dcad9f.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131035/
Test FAILed.

retest this please

Test build #131051 has started for PR 30350 at commit 6dcad9f.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35655/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35655/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35655/
Test PASSed.

Test build #131051 has finished for PR 30350 at commit 6dcad9f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131051/
Test PASSed.

gentle ping @dongjoon-hyun @HyukjinKwon @cloud-fan

Test build #131526 has started for PR 30350 at commit 0e7221a.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36128/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36128/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36128/
Test PASSed.

Test build #131526 has finished for PR 30350 at commit 0e7221a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

retest this please

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131526/
Test FAILed.

Test build #131538 has started for PR 30350 at commit 0e7221a.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36141/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36141/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36141/
Test PASSed.

Test build #131538 has finished for PR 30350 at commit 0e7221a.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131538/
Test FAILed.

retest this please

Test build #131541 has started for PR 30350 at commit 0e7221a.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36144/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36144/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36144/
Test PASSed.

Test build #131541 has finished for PR 30350 at commit 0e7221a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131541/
Test FAILed.

Test build #131600 has started for PR 30350 at commit 0e7221a.

Test build #131600 has finished for PR 30350 at commit 0e7221a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131600/

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36201/

retest this please

Test build #131930 has started for PR 30350 at commit 0e7221a.

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36526/

Test build #131930 has finished for PR 30350 at commit 0e7221a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131930/

It's a behavior change which could be OK if it's a bug fix. Do SQL standards have anything to say about what the result should be?

Didn't  find the place to describe this exactly in SQL standards. It's a function from hive and I prepare to make a pr in hive too.
From the benchmark, seems  have little influence in performance.

Fixing overflow should be good. It's not very intuitive to read the results of this function. Is there any database we can use as a reference?

Fixing overflow should be good. It's not very intuitive to read the results of this function. Is there any database we can use as a reference?

Mysql: https://dev.mysql.com/doc/refman/8.0/en/mathematical-functions.html#function_conv
But still only support 64-bit presicion.
Hive: https://cwiki.apache.org/confluence/display/Hive/LanguageManual+UDF
Latest version support BigInt now

retest this please

Test build #132100 has started for PR 30350 at commit 0e7221a.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36700/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36700/

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36700/

Test build #132100 has finished for PR 30350 at commit 0e7221a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132100/

retest this please

Test build #132111 has started for PR 30350 at commit 0e7221a.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36710/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36713/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36710/

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36710/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36713/

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36713/

Test build #132111 has finished for PR 30350 at commit 0e7221a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132111/

retest this please

Test build #132184 has started for PR 30350 at commit 0e7221a.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36784/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36784/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36784/

Test build #132184 has finished for PR 30350 at commit 0e7221a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132184/

ping @cloud-fan @srowen Any more update?

retest this please

Test build #132628 has started for PR 30350 at commit 0e7221a.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37231/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37231/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37231/

Test build #132628 has finished for PR 30350 at commit 0e7221a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132628/

retest this please

Test build #132735 has started for PR 30350 at commit 0e7221a.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37336/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37336/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37336/

Test build #132735 has finished for PR 30350 at commit 0e7221a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132735/

retest this please

Test build #132743 has started for PR 30350 at commit 0e7221a.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37346/

Test build #132743 has finished for PR 30350 at commit 0e7221a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132743/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37346/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37346/

the scala 2.13 build is broken:
[error] /home/runner/work/spark/spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/NumberConverter.scala:36:46: Byte does not take parameters
[error]       value(i) = (tmpV - q * radix).byteValue()
[error]

Test build #132763 has started for PR 30350 at commit 8564e0f.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37365/

Test build #132763 has finished for PR 30350 at commit 8564e0f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132763/

Since the overflow behavior is expected, this is more like an improvement instead of a bug fix. Thus, I'm merging it to master only, thanks!

I found a behavior change here.
Before this commit
scala> sql("select conv(-100, 10, 10)").show(20, false)
+----------------------------------+
|conv(CAST(-100 AS STRING), 10, 10)|
+----------------------------------+
|18446744073709551516              |
+----------------------------------+

After this commit
scala> sql("select conv(-100, 10, 10)").show(20, false)
+------------------+
|conv(-100, 10, 10)|
+------------------+
|-100              |
+------------------+

If the toBase is positive, the result is unsigned. It's a bit hard to reason about how to put a negative value into an unsigned value, but MySQL returns the same result as before this commit and the overflow behavior seems to be desirable. @AngersZhuuuu can you take a look?

I found a behavior change here.
Before this commit
scala> sql("select conv(-100, 10, 10)").show(20, false)
+----------------------------------+
|conv(CAST(-100 AS STRING), 10, 10)|
+----------------------------------+
|18446744073709551516              |
+----------------------------------+

After this commit
scala> sql("select conv(-100, 10, 10)").show(20, false)
+------------------+
|conv(-100, 10, 10)|
+------------------+
|-100              |
+------------------+

If the toBase is positive, the result is unsigned. It's a bit hard to reason about how to put a negative value into an unsigned value, but MySQL returns the same result as before this commit and the overflow behavior seems to be desirable. @AngersZhuuuu can you take a look?

Got it.

Yea, check the detail of mysql https://www.w3resource.com/mysql/mathematical-functions/mysql-conv-function.php
I means if to base is positive, we treat it as unsigned. then when overflow, it return -1(unsigned long value as<PHONE_NUMBER>3709551615 ),  for current mysql behavior,

User always not clear about the overflow, so if we return overflow  value, user may not known it.
Long can't satisfy current user's requirement, if we use a big decimal or bigint, we can't use this fuction.
Keep same with other engine is good.
For both keep same and satisfy user's requirement,  should we revert this change and add a new function such as conv_without_overflow?

I've reverted this commit.
Regarding conv_without_overflow, are we going to disallow negative toBase? Does any other database have it?

I've reverted this commit.
Regarding conv_without_overflow, are we going to disallow negative toBase? Does any other database have it?

Hmmm why do we need to disallow negative toBase. Doesn't find other database have it.

If we never overflow, why do we need to return unsigned results?

If we never overflow, why do we need to return unsigned results?

Hmmm you mean negative number? conv(number, fromBase, toBase). This pr won't change behavior when negative toBase

Do we still need this signed vs unsigned difference in the conv function if it never overflows?


2.0.0 beta initial

Pull Request Test Coverage Report for Build 44

17 of 21 (80.95%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-4.4%) to 86.538%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/Field.js
0
4
0.0%

Totals

Change from base Build 39:
-4.4%

Covered Lines:
30

Relevant Lines:
34

💛  - Coveralls


s3_iter_bucket: stream instead of downloading full content?

Is it somehow possible to use s3_iter_bucket to open a stream for each key instead of downloading the full content? The actual behaviour could be problematic for very large files that do not fit in memory.

It is possible, but defeats the purpose of s3_iter_bucket().
If you need just the keys, and are OK with downloading the data yourself later, why not simply list the keys (strings) and open them with smart_open as/when needed?
There's no point complicating the situation with parallel s3_iter_bucket() downloads, when you're not actually downloading anything.

Well, it would be nice to have an option inside s3_iter_bucket (or maybe a new method) to switch from downloading to streaming mode per key (I am using smart_open for its streaming functionalities).
Actually I have to list the keys using boto3.client('s3').list_objects_v2(...) and then iterate over the keys with smart_open.open(...), while it seems reasonable to have all this wrapped inside smart_open,  just my thought.

Yes, listing keys and then opening the ones you need seems the way to go. But I'll leave this open for @mpenkov 's thoughts.

IMO smart_open should focus on streaming. Listing a bucket (which is essentially what this feature request boils down to) is already covered by boto3 reasonably well, and offering a new abstraction over that isn't going to bring much value.

Agreed. Sorry @spinlud – that's for the suggestion, but closing as "won't fix".


Incorrect view of wide tables (Frontend)

Bug Report
Installation Method
Docker Desktop
Environment

Open WebUI Version:  v0.3.19 with CUDA

Ollama: 3.1 8B

Operating System: Windows 10

Browser (if applicable): Edge 128.0.2739.54

Confirmation:

[x] I have read and followed all the instructions provided in the README.md.
[x] I am on the latest version of both Open WebUI and Ollama.
[-] I have included the browser console logs (i can't, there is sensitive info).
[-] I have included the Docker container logs (i can't, there is sensitive info).
[x] I have provided the exact steps to reproduce the bug in the "Steps to Reproduce" section below.

Expected Behavior:
When i get really wide table in response, it has a scroll and head/content not become unreadable.
Actual Behavior:
Table are trying to fit in only working area, which is about 930px, and all data and header become vertical alignment columns of unreadable letters.
Description
I use OWUI with custom function to connect to PostgresDB to write and execute SQL query. Some of data stored in tables with 20+ columns, and when i get response as a table it can't fit in propeply. My temporary fix:

Set property «overflow: auto;» to CSS class «chat-assistant».
Set property «width: max-content;» to CSS class «chat-assistant.table».

Then table can use all needed space and response become scrollable.
Reproduction Details
Steps to Reproduce:

Ask LLM «Give me example of table with 10 columns and 5 rows».
You will get generic example without problems.
Edit response to make table with 20 columns of just edit some columns name to make table wider.
See the problem.

Also, you need to edit table by yourself, cause it can't response with wider tables in correct way, it compose wider table in 2 rows which not a table, but mess too. Maybe LLM know smth.
Logs and Screenshots
Before fixes:

After:

PR Welcome!

Fixed on dev!


3691, 3715, 3717

#3715 Vs Hangs When streaming tweets

rewrote carriage return processor to use queue rather than IMainThread.Post

#3717 Lint complains about ::

Added special case for operators that do not need spaces around them

#3691 Lint complaints about braces in markdown block parameters

Special cased {r block
Plumbed through projection status to suppress trailing blank lines check

Added tests

👍


Request: call it posh rather than pwsh

Heya!
Powershell 6 is pwsh. But folks in the Powershell community have called it posh for more than a decade now. It would be cool for the command to do the same.

@mikemaccana  What do you mean by CALL here ? are you referring to the executable name(pwsh.exe) ?

There are reasons why we didn't(were not able to) use posh. see this .

@mikemaccana within the Community, people call it posh and as far as I'm concerned pwsh is pronounced posh.  However, as @kvprasoon pointed out, we've been through this discussion and we couldn't use posh literally as it's an existing shell


Multiple modules

From #15. This handles modules-within-modules according to the following logic. Certainly open to feedback, since I haven't written enough flow decls to know all the permutations!

Nested modules names are parsed as delimited by /
Any level of nesting after the first is considered a single submodule name: e.g. foo/bar/baz becomes a module BarBaz in the foo.re output. I could also recursively nest them by ensuring a Bar and adding the Baz decls inside it; not sure if this is a use case that happens a lot. I wanted to get an impression/opinion before adding what seems like a polish feature.
 That is, I @@bs.module "foo/bar/whatever" inside each external in Foo.Bar.

Some changes are formatting; will annotate the one real change.

Ok, so first off this is seriously amazing work 🎉 This is honestly fantastic!
The PR looks great overall! The only problem is having src/retyped take a dependency of jsoo. Right now it's compiled as a library dependency of the two modules insrc, meaning it can target native OCaml if you run jbuilder build src/cli.exe - hopefully we don't have to lose that.
Can we take a dependency on another OCaml regex library? Native target is really helpful for development speed.
You can test out the native target with jbuilder build src/cli.exe and then run ./_build/default/src/cli.exe -debug <my-file.js>

This is perfect! Thanks for implementing this so quickly 😄

I'd say so; native and JS tests seem to work (where "native test" is just building cli.exe and running it on my test file).


Upgrade to react-redux@7

npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.

➜   npm info react-redux

<EMAIL_ADDRESS>| MIT | deps: 6 | versions: 91
Official React bindings for Redux
https://github.com/reduxjs/react-redux

keywords: react, reactjs, redux

dist
.tarball: https://registry.npmjs.org/react-redux/-/react-redux-7.0.3.tgz
.shasum: 983c5a6de81cb1e696bd1c090ba826545f9170f1
.integrity: sha512-vYZA7ftOYlDk3NetitsI7fLjryt/widNl1SLXYvFenIpm7vjb4ryK0EeFrgn62usg5fYkyIAWNUPKnwWPevKLg==
.unpackedSize: 238.1 kB

dependencies:
@babel/runtime: ^7.4.3          invariant: ^2.2.4               prop-types: ^15.7.2
hoist-non-react-statics: ^3.3.0 loose-envify: ^1.4.0            react-is: ^16.8.6

maintainers:
- gaearon<EMAIL_ADDRESS>- timdorr<EMAIL_ADDRESS>
dist-tags:
latest: 7.0.3     next: 7.1.0-rc.1  previous: 4.4.10

published a month ago by acemarke<EMAIL_ADDRESS>

I think this is a duplicate of #287. There is a draft PR open (#303) to support react-redux v7.


pull request for e2e test at 01/24/2017 05:45:08

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Most CRS rules using @validateByteRange are failing

I have no more information by the moment but it requires testing.

Fixed, validateByteRange was reworked


In 711 handle multiple configs - Part 6

Rename DX parameters and appropriate changes in the bash code
Fix a lot of errors
Fix using the config assay code rather than the actual config dict
FIx some imports

This change is

Hello @Yu-jinKim! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file resources/home/dnanexus/run_workflows/run_workflows.py:

Line 673:80: E501 line too long (85 > 79 characters)

In the file resources/home/dnanexus/run_workflows/utils/dx_requests.py:

Line 88:80: E501 line too long (105 > 79 characters)
Line 89:80: E501 line too long (95 > 79 characters)
Line 129:80: E501 line too long (101 > 79 characters)
Line 369:80: E501 line too long (101 > 79 characters)
Line 430:80: E501 line too long (105 > 79 characters)
Line 780:80: E501 line too long (80 > 79 characters)
Line 887:80: E501 line too long (87 > 79 characters)

In the file resources/home/dnanexus/run_workflows/utils/manage_dict.py:

Line 16:1: E402 module level import not at top of file
Line 17:1: E402 module level import not at top of file


main.dart.js file not found

When working on a remodel of the web version, I came across this error right away in the js console. I do not know if it causes this, but it shows a blank page instead of what shows on the live site. Here are a few screenshots for reference...

These first two show the js console logs for the live site, which they all generally complain about the main.dart.js file missing.

The next two above are the same error on the web server shown in two different forms... a notification and in the console.

The next one above shows the blank page which may be the outcome of the error.

This last one shows why the thesis from the previous image and caption is not logical, as it is working on the live site. I still do think it is the outcome though...

Anyways, thanks for taking the time to read this!

@Lukas-Batema which version of flutter are you using?

@Lukas-Batema which version of flutter are you using?

I do not know, which probably means I am not using it :/

Right. How did you run it in the browser without flutter?

Right. How did you run it in the browser without flutter?

I used an IDE with a web server

Oh. You're supposed to run it using flutter.
flutter run -d chrome

Oh. You're supposed to run it using flutter.
flutter run -d chrome

Yeah, I realize that now.

Wait, what about the live site complaining about the missing file?

It's generated by flutter when you run flutter run -d chrome

Wait, what about the live site complaining about the missing file?

It's generated by flutter when you run flutter run -d chrome

Ah, okay. Understandable now.


MAISTRA-862 Stop leaking goroutines in MultiNamespaceListWatcher

Marking this WIP for now, I want to implement a unit test next week and then push a PR upstream as well.

Closing as this is not the simplest solution. Will push another PR in a bit


The iface zif_abapgit_repo should declare the method get_dot_abapgit

All kind of repos should be able to return the configuration object .abapgit.
After the PR #5329 my scripts got broken because I was doing this:
      data(repo) = zcl_abapgit_repo_srv=>get_instance( )->new_online(
        iv_url = git_repo_url
        iv_branch_name = branch
        iv_package = abap_package
        iv_folder_logic = folder_logic
        iv_ign_subpkg = ignore_subpackages
        iv_main_lang_only = main_lang_only
      ).

      repo->get_dot_abapgit( )->set_starting_folder( starting_folder ).

+1

I think it makes sense to move this and some other methods in. I moved just minimal necessities within https://github.com/abapGit/abapGit/pull/5329.

closed by #5466


Incorrect version in created mtad.yaml file

Bug or question.

Please search existing issues to avoid creating duplicates. https://github.com/SAP/cloud-mta-build-tool/releases. - done
Also please test using the latest version build to make sure your issue has not already been fixed:
(xMake is used)

I'm building MTA app with UI5 module via internal xMake system.
Steps to Reproduce:

GitHub repo with UI5 module. Created app should be deployed into NEO.

Created mta.yaml file contains version parameter two times (in accordance with documentation both are required):

After using of Piper library and xMake with Cloud Mta builder i expect to get mtar file with created mtad.yaml file where BOTH versions should be updated (suffix with timestamp and commitid should be added to the versions). It worked so several days ago.
But now only one version is updated in mtad.yaml:

Could you please help to understand the reason for this behaviour?
Did you update mta builder recently?
Thank you and best regards,
Marina

Hi,
The Cloud MTA Build tool does not have a feature that updates a version in the mtad,yaml during the build.
Probably the behavior that you describe is implemented in the tools that trigger the build, e.g. piper. Therefore, please open a  ticket in their issue tracking systems.
Regards
Natalia


Troubleshooting guide

I tried this out recently but my materialized view always yields 0 rows when queried. However it seems to understand the schema of the source just fine so it's obviously connected in some fashion. I'm just not sure how to troubleshoot it. I was using docker for everything with mounted volumes to share the data.

This sounds like something that we should put into our operations guide at https://materialize.io/docs/ops .
The first things to check are the docker logs for materialized and tb.

However it seems to understand the schema of the source just fine so it's obviously connected in some fashion.

Does this mean that SHOW SOURCES and SHOW SOURCE foo look correct? You can try running the dashboard to get an overview of what materialized is doing, something might be surprising there.

Yes as far as I can tell everything looks fine on the source. But create a materialized view from that source (or even creating a materialized source instead) always yields 0 rows. It's a very small table with only 2 columns and 3 rows. Is it possible I'm hitting #24 even though the table is already populated by the time I create the source?

I don't know what to look for in the dashboard that would clue me in to a problem.

Is it possible I'm hitting 24 even though the table is already populated by the time I create the source?

It's possible, although very unlikely. You can check if the files that the sources read from by looking at the files that you specify in the CREATE SOURCE statement, they're binary files, but text data from your database should be readable. At the very least, there should be data after the header line, if there's no data after the header (which is a json document describing the schema) then there is an issue with tb, otherwise the issue is probably in materialized.

I don't know what to look for in the dashboard that would clue me in to a problem.

The most interesting thing would be the number of arrangement or records. If both of those are zero then no data has ever made it into materialize, if they're above zero then it is likely that something in your materialized view is filtering out all the data.
Something else worth trying is just creating a materialized source with CREATE MATERIALIZED SOURCE ... and selecting from that. It should always return either results or an explicit error about data not being fully loaded yet.

I tried CREATE MATERIALIZED SOURCE and even that gave back zero rows. Also the dashboard showed that there were many thousands of "records" (what that means I'm not sure). The Kafka ingest etc counters were all 0.

The files in /tmp/tbshare seem to have header-ish information only but no data that is in my table. I wonder if it's silently failing due to write permissions or something like that.

In case it's helpful:
I'm running postgresql via their latest docker image 62473370e7ee.
With this schema:
postgres=# \d+ names
                                                Table "public.names"
 Column |  Type   | Collation | Nullable |              Default              | Storage  | Stats target | Description
--------+---------+-----------+----------+-----------------------------------+----------+--------------+-------------
 pk     | integer |           | not null | nextval('names_pk_seq'::regclass) | plain    |              |
 name   | text    |           | not null |                                   | extended |              |
Publications:
    "dbz_publication"
Replica Identity: FULL
Access method: heap

postgres=# SHOW wal_level;
 wal_level
-----------
 logical
(1 row)

@3noch it seems likely that you ran into #24 , and the most recent tb release in docker might fix it.


add a keyboard shortcut to preferences on mac

Open preferences with Cmd, on macOS

👍  Looks good, thanks!


[FLINK-33398][runtime] Support switching from batch to stream mode for one input stream operator

What is the purpose of the change
This PR supports switching from batch to stream mode to improve the performance during processing backlog data for one input stream operator.
Brief change log

Introduce RecordAttributes to notify the downstream whether the records are backlog data.
Propagate the RecordAttributes at runtime.
Automatically sort the backlog data for one input operator.

Verifying this change
This change added tests and can be verified as follows:

Added integration test for keyed aggregation and keyed windowed aggregation with backlog data.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): yes
The serializers: no
The runtime per-record code paths (performance sensitive): yes
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? yes
If yes, how is the feature documented? JavaDocs

@flinkbot run azure

@yunfengzhou-hub Thanks for the review! I updated the PR. Can you have another look?

Hi @Sxnan! Sorry, I understand that I'm not a reviewer, but it happened that I was testing functionality from this MR recently, and I found a bug (in my opinion). It concerns the logic of RecordAttributesValve.
I my test there was very little backlog data at source + it had parallelism 4 (actually, any value > 1 suits the case). Due to very short backlog phase, time interval between sending RecordAttributes(isBacklog=true) and RecordAttributes(isBacklog=false) was also very short. In addition, due to the high parallelism one source subtask could send RecordAttributes(isBacklog=false) even before RecordAttributes(isBacklog=true) of another subtask. As a result, race condition have occurred in RecordAttributesValve#inputRecordAttributes. backlogChannelsCnt was incrementing and decrementing simultaneously, which led to not reaching 'numInputChannels' at all, so no RecordAttributes was emitted from RecordAttributesValve.

Hi @Sxnan! Sorry, I understand that I'm not a reviewer, but it happened that I was testing functionality from this MR recently, and I found a bug (in my opinion). It concerns the logic of RecordAttributesValve.
There was very little backlog data in my test  at source + it had parallelism 4 (actually, any value > 1 suits the case). Due to very short backlog phase, time interval between sending RecordAttributes(isBacklog=true) and RecordAttributes(isBacklog=false) was also very short. In addition, due to the high parallelism one source subtask could send RecordAttributes(isBacklog=false) even before RecordAttributes(isBacklog=true) of another subtask. As a result, race condition have occurred in RecordAttributesValve#inputRecordAttributes. backlogChannelsCnt was incrementing and decrementing simultaneously, which led to not reaching numInputChannels, so no RecordAttributes was emitted from RecordAttributesValve at all.
I suggest to have different counters for RecordAttributes(isBacklog=true) and for RecordAttributes(isBacklog=false). Therefore, the race condition I mentioned earlier won't affect the result. Something like this:
    if (recordAttributes.isBacklog()) {
        backlogChannelsCnt += 1;
        if (backlogChannelsCnt != numInputChannels) {
            return;
        }
        backlogChannelsCnt = 0;
    } else {
        nonBacklogChannelsCnt += 1;
        if (nonBacklogChannelsCnt != numInputChannels) {
            return;
        }
        nonBacklogChannelsCnt = 0;
    }

    if (lastOutputAttributes == null
            || lastOutputAttributes.isBacklog() != recordAttributes.isBacklog()) {
        if (lastOutputAttributes != null && !lastOutputAttributes.isBacklog()) {
            LOG.warn(
                    "Switching from non-backlog to backlog is currently not supported. Backlog status remains.");
            return;
        }
        lastOutputAttributes = recordAttributes;
        output.emitRecordAttributes(recordAttributes);
    }

WDYT? Also, it is good to have a test for aforementioned case.

Hi @Sxnan! Sorry, I understand that I'm not a reviewer, but it happened that I was testing functionality from this MR recently, and I found a bug (in my opinion). It concerns the logic of RecordAttributesValve. There was very little backlog data in my test at source + it had parallelism 4 (actually, any value > 1 suits the case). Due to very short backlog phase, time interval between sending RecordAttributes(isBacklog=true) and RecordAttributes(isBacklog=false) was also very short. In addition, due to the high parallelism one source subtask could send RecordAttributes(isBacklog=false) even before RecordAttributes(isBacklog=true) of another subtask. As a result, race condition have occurred in RecordAttributesValve#inputRecordAttributes. backlogChannelsCnt was incrementing and decrementing simultaneously, which led to not reaching numInputChannels, so no RecordAttributes was emitted from RecordAttributesValve at all.
I suggest to have different counters for RecordAttributes(isBacklog=true) and for RecordAttributes(isBacklog=false). Therefore, the race condition I mentioned earlier won't affect the result. Something like this:
    if (recordAttributes.isBacklog()) {
        backlogChannelsCnt += 1;
        if (backlogChannelsCnt != numInputChannels) {
            return;
        }
        backlogChannelsCnt = 0;
    } else {
        nonBacklogChannelsCnt += 1;
        if (nonBacklogChannelsCnt != numInputChannels) {
            return;
        }
        nonBacklogChannelsCnt = 0;
    }

    if (lastOutputAttributes == null
            || lastOutputAttributes.isBacklog() != recordAttributes.isBacklog()) {
        if (lastOutputAttributes != null && !lastOutputAttributes.isBacklog()) {
            LOG.warn(
                    "Switching from non-backlog to backlog is currently not supported. Backlog status remains.");
            return;
        }
        lastOutputAttributes = recordAttributes;
        output.emitRecordAttributes(recordAttributes);
    }

WDYT? Also, it is good to have a test for aforementioned case.

Hi @Smir. Thanks for trying this out! The RecordAttributesValve combines the RecodAttributes from different input channels from the same input. The input is considered in backlog state if and only if all the input channels are backlog = true. Otherwise, some non-backlog records will be considered as backlog records.
Back to your case, where there is very little backlog data and it has parallelism greater than 1. It is possible that an input channel switches to non-backlog state before other input channels switch to backlog state.  When that happens, we just process those data as if they are non-backlog data.

Thanks for the response, @Sxnan. I got your points. BTW, the reason why delivery guarantees of RecordAttributes elements to downstream operators was important to me is that I was testing the possibility to use them in order to properly implement Processing Time Temporal Join. I described my thoughts about this in FLIP-326 discussion thread. Thus, if eventually it will be  decided to reuse RecordAttributes logic to solve FLINK-19830, the problem I described will arise one way or another.

Thanks for the response, @Sxnan. I got your points. BTW, the reason why delivery guarantees of RecordAttributes elements to downstream operators was important to me is that I was testing the possibility to use them in order to properly implement Processing Time Temporal Join. I described my thoughts about this in FLIP-326 discussion thread. Thus, if eventually it will be decided to reuse RecordAttributes logic in order to solve FLINK-19830, the problem I described will arise one way or another.
Also, I should mention that there is another workaround that guarantees delivery of RecordAttributes(isBacklog=false) (but not isBacklog=true), but at the same time prevents considering some non-backlog records as backlog records. Pseudocode may be like this:
if (lastOutputAttributes == null && nonBacklogChannelsCnt == numInputChannels) {
    nonBacklogChannelsCnt = 0;
    output.emitRecordAttributes(RecordAttributes(isBacklog=false));
}

The downside is that it is possible to have RecordAttributes(isBacklog=false) without RecordAttributes(isBacklog=true) previously, but probably, it's ok. In other respects, this approach worked fine for me.

After an offline discussion with @xintongsong, we will split this PR into two PRs.  This PR will focus on optimizing the one input operator during backlog. The other PR will focus on propagating the RecordAttributes through the job graph.
This PR should be merged after the other PR.


Api

Open an issue here for technical questions on how to implement Attribution Reporting API code, or questions on the docs or demo for this API. For questions on how to fulfil a certain use case with the API, file an issue in the spec repository instead.

Closing as no text in issue.


fix: add CRA CVE omit file to ignore until remediation available

Addresses https://snyk.io/vuln/SNYK-GOLANG-GITHUBCOMGINGONICGIN-1041736 until remediation is available.

@gee4vee I reviewed the updates and made a few edit suggestions. Please reach out on slack if you have any questions. Thank you!


Implement Subsonic getAlbumList and getAlbumList2

Hi i really like your Jellyfin to Subsonic bridge, its especially useful for iOS users ^^.
I hope this contribution makes its way into master so everyone else can finally browser their albums.
If you have any questions or comments on my code please feel free to ask.

its especially useful for iOS users

@ExNG I’m thinking about setting this up. What iOS client do you use?


Calling createPaymentMethod causes app to crash and close.

Describe the bug
Currently using React Native with Expo. Using @stripe/stripe-react-native version 0.22.1 (latest as of now on 12/10/2022).
A view render's the CardField component from the SDK and when trying to call createPaymentMethod,
expo shuts down. The error i get:
NSInvalidArgumentException: -[NSNull _fastCStringContents:]: unrecognized selector sent to instance 0x1fe57a740
NOTE: this only happens on iOS. i am using a physical iPhone 14 Pro running iOS 16
To Reproduce
Steps to reproduce the behavior:

Fill out CardField from sdk
Call createPaymentMethod

Expected behavior
It works fine on physical Android
Screenshots
If applicable, add screenshots to help explain your problem.

Hi! Expo's latest SDK (47) supports v0.19.0. Can you install stripe with expo install @stripe/stripe-react-native and retry?

Hi, will retry.

Just tried and it did not work. Here is what my package.json looks like:
{
  "name": "app",
  "version": "1.0.0",
  "main": "node_modules/expo/AppEntry.js",
  "scripts": {
    "start": "NODE_ENV=production expo start",
    "start-local": "NODE_ENV=local expo start",
    "start-dev": "NODE_ENV=development expo start",
    "android": "NODE_ENV=local expo start --android",
    "ios": "NODE_ENV=local expo start --ios",
    "web": "NODE_ENV=local expo start --web",
    "build-pre-release": "NODE_ENV=development eas update --branch=preview"
  },
  "dependencies": {
    "@googlemaps/google-maps-services-js": "^3.3.16",
    "@react-native-async-storage/async-storage": "^1.17.10",
    "@react-native-picker/picker": "2.4.8",
    "@react-navigation/bottom-tabs": "^6.4.0",
    "@react-navigation/drawer": "^6.5.0",
    "@react-navigation/material-top-tabs": "^6.2.4",
    "@react-navigation/native": "^6.0.13",
    "@react-navigation/native-stack": "^6.9.0",
    "@stripe/stripe-react-native": "0.19.0",
    "axios": "^0.27.2",
    "buffer": "^6.0.3",
    "dotenv": "^16.0.3",
    "eslint-plugin-react-hooks": "^4.6.0",
    "expo": "^47.0.8",
    "expo-device": "~5.0.0",
    "expo-image-picker": "~14.0.2",
    "expo-linking": "~3.2.3",
    "expo-location": "~15.0.1",
    "expo-notifications": "~0.17.0",
    "expo-status-bar": "~1.4.2",
    "expo-web-browser": "~12.0.0",
    "install": "^0.13.0",
    "moment": "^2.29.4",
    "npm": "^8.19.2",
    "react": "18.1.0",
    "react-dom": "18.1.0",
    "react-native": "0.70.5",
    "react-native-app-link": "^1.0.1",
    "react-native-encrypted-storage": "^4.0.2",
    "react-native-gesture-handler": "~2.8.0",
    "react-native-google-places-autocomplete": "^2.4.1",
    "react-native-image-picker": "^4.10.0",
    "react-native-keyboard-aware-scroll-view": "^0.9.5",
    "react-native-maps": "1.3.2",
    "react-native-pager-view": "6.0.1",
    "react-native-reanimated": "~2.12.0",
    "react-native-safe-area-context": "4.4.1",
    "react-native-screens": "~3.18.0",
    "react-native-signature-canvas": "^4.4.1",
    "react-native-signature-capture": "^0.4.12",
    "react-native-tab-view": "^3.1.1",
    "react-native-web": "~0.18.7",
    "rxjs": "^7.5.6",
    "socket.io-client": "^4.5.1",
    "thenby": "^1.3.4",
    "uri-scheme": "^1.0.120",
    "expo-secure-store": "~12.0.0",
    "expo-updates": "~0.15.6",
    "@expo/webpack-config": "^0.17.0"
  },
  "devDependencies": {
    "@babel/core": "^7.12.9",
    "@types/react": "~18.0.14",
    "@types/react-native": "~0.69.1",
    "typescript": "~4.3.5"
  },
  "private": true
}

I found the issue. Basically, no property in the billingDetails object should be null/undefined:
const createCardParams: CreateParams = {
        paymentMethodType: 'Card',
        paymentMethodData: {
          billingDetails: {
            name: getUserFullName(you),
            email: you.email,
            phone: you.phone || '',
          },
        }
      };

If you don't have a value for it, just use an empty string, -1, etc. Just something other than null/undefined.

Hm, I'm not able to reproduce that @ryanwaite28

+1 It only happens in release environments

I confirm @ryanwaite28 solution. Thank you!

I was stuck in the same issue, thanks @ryanwaite28 !! Your solution worked!

Fix was released in v0.23.0


bump JDK tip version to JDK18

fixes: https://github.com/adoptium/ci-jenkins-pipelines/issues/167
Changes also made in temurin-build https://github.com/adoptium/temurin-build/pull/2658

run tests


[V3] Migrate to Renesas BSP v5.9.0 (and misc fixes)

Acked-by: Ruslan Shymkevych<EMAIL_ADDRESS>

Instead of https://github.com/xen-troops/meta-xt-prod-devel-rcar/pull/69

Acked-by: Volodymyr Babchuk<EMAIL_ADDRESS>


Fix muddle not found issue for font-awesome-styles

this happens in webpack 2

I did a quick test to see whether this change impacts anything in default bootstrap-loader basic example and it worked fine.

What about webpack v1, @vpanjganj?

I should probably make this v1.

It's fine in webpack 1. I think my description was very short. This PR will make it work in both webpack 1 and 2.

LGTM.
Guessing that this makes the absence of the search for a .loader file work fine.


integration of Tensorflow.js into malevo

the recent release of Tensorflow.js would allow us to run some parts of the network in the browser and have "built-in" support for Tensorflow model files
It would also offer a "javascript numpy" which would simplify adding of new features in the future than having to deal with the Phovea datastructures.

Won't be considered in this version.


Feature: Radio reception based on camera position

Unity has a distortion audio filter which can give impression of degraded audio: https://docs.unity3d.com/Manual/class-AudioDistortionFilter.html
Would it be possible to link that to radio tower (natural disasters) coverage for the current camera position, so that as player moves camera further from radio mast (including height, optionally) the radio station quality degrades and maybe decrease volume too?
Bonus round: Set available radio stations per radio mast (default all)... This way while driving in first person cam, you'd hear a radio station crackle out as you drive out of range, then new radio station crackle in further down the route. A bit like how a car radio can auto-tune to a new station if the signal strength of previous one is too low.
I know this is niche af, and not really in scope, but thought I'd suggest just in case :)

Interesting idea, but out of scope for ACME, I think.  Will bear it in the back of my mind, though, should other opportunities arise!


ciberbullying

to show that there has to be done and greatly affects the people who make it .

wtf?

yeah, wtf ?

Closing, since this issue seems to have been created for fun.


Diego/add inf functions to autocli

Add get inference, forecast, losses at topic and block to autocli

just make sure make init doesn't break, otherwise good


undesirable insertion of comment leader in recent vim versions with cindent

Steps to reproduce

Enable cindent and set formatoptions+=ro
Type a line with a single-line comment at the end, e.g.

        foo();  // do foo

and then press enter
3. Observe insertion of comment leader lined up with the single comment:
        foo();  // do foo
                //
                   ^--(cursor now here)

Expected behaviour
I absolutely never want this new behaviour. Single-line comments at the end of a statement are for small remarks about that line alone, if you need multiple lines for the comment I'd put them on their own line before the statement.  For me, the expected behaviour is how it always used to work and still does in the version (debian pkg 2:8.2.2434-3+deb11u1) currently in debian stable (bullseye), which is also how it still works when using autoindent or smartindent instead of cindent, i.e. simply go to the next line with appropriate indent so that I can continue typing code.
        foo();  // do foo

        ^--(cursor now here)

I only expect the comment leader insertion if I'm in an actual comment block:
        // comments comments yada yada press enter at end of line
        //
           ^--(cursor now here)

(this behaviour hasn't changed and works the same for cindent, smartindent, and autoindent)
I can understand that different people can have a different opinion about this, and that they'd appreciate a flag for this behaviour, but changing the default from the way it always used to work and forcing me to remove the comment leader every single time I press enter at the end of a line that has an inline comment is really obnoxious and conflicts with years of muscle memory.
Version of Vim
8.2.3955 ?  (debian package 2:8.2.4793-1)
Environment
Operating system: Debian sid
:version says:
VIM - Vi IMproved 8.2 (2019 Dec 12, compiled Feb 06 2022 17:44:00)
Included patches: 1-3995
Modified by<EMAIL_ADDRESS>
The version that worked correctly (imo), in debian stable, reports:
VIM - Vi IMproved 8.2 (2019 Dec 12, compiled Oct 01 2021 01:51:08)
Included patches: 1-2434
Extra patches: 8.2.3402, 8.2.3403, 8.2.3409, 8.2.3428
Modified by<EMAIL_ADDRESS>

Duplicate of #10006?

Indeed, my bad!


Discord bot faucet

Some extra ideas for this include streak bonus and reminder that you can get more rewards by voting https://github.com/webaverse/app/issues/182

Some extra ideas for this include streak bonus and reminder that you can get more rewards by voting https://github.com/webaverse/app/issues/182


[JAX + IREE | Apple M1 Max] - Fails to legalize 'math.roundeven'

What happened?
Using jax + iree Mac M1 Max fails call to round() on a a jax DeviceArray().
Steps to reproduce your issue

Create a _DeviceArray(), let's say its called dArr
Call round on dArr.round()
See error

>>> x
DeviceArray([[1., 2.],
             [3., 4.]], dtype=float32)
>>> x.round()

......

{CompilerToolError}Error invoking IREE compiler tool iree-compile
Diagnostics:
<string>:1:0: error: failed to legalize operation 'math.roundeven'
<string>:1:0: error: failed to run translation of source executable to target executable for backend #hal.executable.target<"vulkan", "vulkan-spirv-fb", {spirv.target_env = #spirv.target_env<#spirv.vce<v1.3, [Shader, Float16, Int64, Int16, Int8, StorageBuffer16BitAccess, StorageUniform16, StoragePushConstant16, StorageBuffer8BitAccess, UniformAndStorageBuffer8BitAccess, StoragePushConstant8, GroupNonUniform, GroupNonUniformVote, GroupNonUniformArithmetic, GroupNonUniformBallot, GroupNonUniformShuffle, GroupNonUniformShuffleRelative, GroupNonUniformQuad, VariablePointers, VariablePointersStorageBuffer], [SPV_KHR_16bit_storage, SPV_KHR_8bit_storage, SPV_KHR_storage_buffer_storage_class, SPV_KHR_variable_pointers]>, Apple:IntegratedGPU, #spirv.resource_limits<max_compute_shared_memory_size = 32768, max_compute_workgroup_invocations = 1024, max_compute_workgroup_si...

Also happens to jnp.linalg.inv(x) where the error is:
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/lausena/developer/repos/jax/jax/_src/iree.py", line 186, in compile
    iree_binary = iree.compiler.compile_str(
  File "/Users/lausena/miniforge3/envs/tfpy310/lib/python3.10/site-packages/iree/compiler/tools/core.py", line 278, in compile_str
    result = invoke_immediate(cl, immediate_input=input_bytes)
  File "/Users/lausena/miniforge3/envs/tfpy310/lib/python3.10/site-packages/iree/compiler/tools/binaries.py", line 196, in invoke_immediate
    raise CompilerToolError(process)
iree.compiler.tools.binaries.CompilerToolError: Error invoking IREE compiler tool iree-compile
Diagnostics:
<stdin>:1:0: error: 'mhlo.scatter' op expects bounds of the scatter dimensions of updates to be same as the bounds of the corresponding dimensions of scatter indices. For scatter dimension 1, updates bound is 2 , scatter_indices bound is 1.
compilation failed

What component(s) does this issue relate to?
No response
Version information
M1 Max | Darwin 22.1.0
JAX compiled with the following extra_args  extra_args += ["--iree-llvm-target-triple=arm64-apple-darwin22.1.0", "--iree-flow-demote-i64-to-i32", "--iree-vulkan-target-triple=m1-moltenvk-macos", "--iree-llvm-target-cpu-features=host", "--iree-mhlo-demote-i64-to-i32=true"]

Yeah we are missing conversions from math.roundeven to SPIR-V. Should be straightforward given we have GLSL extended instruction RoundEven. Assigning to @kuhar to add it.

This should be fixed when https://github.com/llvm/llvm-project/commit/c97035c49d941e5b196a938f0393f811d1adbd57 gets integrated


Add email in view student

Please fix the links for TOC items 1, 4, 7.10.2, 7.10.3, 7.10.5. Thanks!

This will be the last PR for today before submission


Feature: Support photos:// URI (iOS Photos Framework)

I'd like to use react-native-photos-framework as a video picker in conjunction with this library.
Problem: That library uses iOS Photos Framework, so the URI is photos://. Trying to feed that into this library will crash the app.
From Apple:

@flybayer currently library doesn't support photos:// URI, it's a new feature , we doesn't support photos library because you can't edit remote videos (ex. From iCloud) . assets library gives only videos from users devices, that's why it's good for us, anyway we can also use photos URI but only local videos.

This issue has some helpful info: https://github.com/wkh237/react-native-fetch-blob/issues/218

@flybayer Thank you !
Also i found one helpful example from stackoverflow
I'm quite busy in this days. i'll back to this issue when i'll have free time.


Check for INTERFACE library type in add_library function …

defined in windows.cmake. Currently this function will fail with INTERFACE libraries.

Thanks for patch.
Since a new release of catkin was made earlier this day it might be a while until the next patch release.

Since this only affects Windows maybe you should ask the Microsoft team to update their package.

Since this only affects Windows maybe you should ask the Microsoft team to update their package.

Please go ahead and do as suggested. I don't know how they are building packages or who the right person to notify is.

https://github.com/ms-iot/ROSOnWindows/issues/158


Add Ellison support

With the test server running: http://localhost:8080/?target=targets/ellison.md&wrap=1&stylesheet=stylesheets/ellison.css

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

2 of 34 (5.88%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.9%) to 93.338%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/Languages/Ellison/EllisonLanguage.php
1
5
20.0%

src/Languages/Ellison/Injections/ParserInjection.php
0
28
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-1.9%

Covered Lines:
1457

Relevant Lines:
1561

💛  - Coveralls

Tagged: https://github.com/tempestphp/highlight/releases/tag/2.4.0

@assertchris I made a couple of small changes. The most important one is that I removed the addition of <p> tags. I understand why you did it, but it also meant that combining ellison support with markdown codeblock rendered p tags within the pre body, which messed up styling.
Maybe we should make it configurable on the EllisonLanguage? WDYT?

Oh also, I added some docs about this: https://tempest.stitcher.io/highlight/04-optin


Null pointer exception when changing ActionTextColor in Dialog

When changing ActionTextColor(positive & negative button) in either DatePickerDialog or TimePickerDialog, it's giving null pointer exception.
Code:
builder.positiveAction("OK").negativeAction("CANCEL");
builder.getDialog().positiveActionTextColor(Color.parseColor("#FFB125"));
builder.getDialog().negativeActionTextColor(Color.parseColor("#FFB125"));
DialogFragment fragment = DialogFragment.newInstance(builder);
fragment.show(getSupportFragmentManager(), null);
Also, tried changing button color after showing DialogFragment but still gives 'nullpointerexception'

The getDialog() return a Dialog object only after onCreateDialog() method of DialogFragment is called. If you want to style the dialog, you can use style(int) method, or override onBuildDone(Dialog) method.


Error: Could not find or load main class python.example

After creating a python file and even the .class is also generated but I still get this error

It's very hard for us to provide any assistance when you don't give us details. What were you trying to do? What files were generated by VOC? What commands did you run?
You need to help us help you.


Seems to have issues with Ex Nihilo Aluminum Ingot

I'll peek at the code tomorrow, but here's what I'm seeing in game (Agrarian skies 2)

I have a chest full of Aluminum Ingot (6003)
Two packagers set to 3x3 (I believe the code calls this LARGE) next to it and powered (I know they're working because other ingots are being crafted)
None of the aluminum ingots are crafted.

My hypothesis is that this has to do with aluminum ingots also having a 2x2 crafting recipe and some bad short-circuiting logic with respect to that. (Empty Canister from Tinker's Construct)
I haven't fiddled, but I imagine the easiest repro would be AutoPackager + Tinker's Construct + Ex Nihilo and reproducing the same situation as above

The Ex Nihilo aluminium ingot is not valid for making a Block of Aluminum from Tinker's Construct.

oh sure enough.  womp. Thanks!


Update Seaside dependencies

Coverage remained the same at 98.046% when pulling 63d65870c43955c353ae3713b082c5b17a21a29b on seaside-update into 569cde2938ff2ad9337e7e1e8bf7f6f0e1992b2b on master.


OR conditions for composite search fails

Describe the bug
When searching using an OR condition on composite search parameters, server fails with 403 forbidden, "The number of composite components specified for search parameter 'component-code-value-quantity' exceeded the number of components defined."
To Reproduce
Steps to reproduce the behavior:

Spin up an Azure FHIR server

Search for:
GET https://myfhirserver/Observation?component-code-value-quantity=http://loinc.org|8462-4$gt70,http://loinc.org|8462-6$gt150

i.e., diastolic blood pressure greater than 70 OR systolic blood pressure greater than 150

Return:
{
"resourceType": "OperationOutcome",
"id": "873868e8-8d15-46d3-a989-bb6281beb56f",
"issue": [
    {
        "severity": "error",
        "code": "forbidden",
        "diagnostics": "The number of composite components specified for search parameter 'component-code-value-quantity' exceeded the number of components defined."
    }
]
}

Expected behavior
Should return a search result bundle
The following searches work on public servers:
http://hapi.fhir.org/baseR4/Observation?component-code-value-quantity=http://loinc.org|8462-4$gt70,http://loinc.org|8462-6$gt150
Vonk also ignores:
https://vonk.fire.ly/Observation?component-code-value-quantity=http://loinc.org|8462-4$gt70,http://loinc.org|8462-6$gt150
(search parameters excluded in self link)
Actual behavior
Returns 403

Is this the same issue as https://github.com/microsoft/fhir-server/issues/523?

@brandonpollett , yeah, I think two different symptoms of the same issue that we are not processing the ORs correctly for composites. We can close one or keep them both open since they sort of lay out the test cases that would need to go in.


[BUG] - Complete your bug title here

**UE Version: **
E.g. UE 5.2.1
**Frontend Version: **
E.g. UE5.2-0.6.5
Problem component
Build is having memory(RAM) leak on server if we run for a long time.
Description
Out of memory(RAM). If you keep running the build on cloud (Windows server). It keeps adding up RAM usage and the app crashes.
Its very fast and obvious in development build but very gradual increase in shipping build. And I also found this issue posted by many people in epic forum and other forums.
Its happening more on cloud.
Since pixel streaming keeps running app on cloud for example reserved server this is a major issue.
If you can test a development build you can easily get the issue.
Cloud Specs: G4 2XL dn (Intel Xenon)

Hey @vijodvijay,
Thanks for bringing this up.
The bug you've reported is actually an issue with the Unreal Engine itself, not the Pixel Streaming Infrastructure. As such, I'm going to close this is issue but don't worry, we are tracking it internally.
Cheers,
Will

Please forward it to engine development team


Draft: handle incompatible numerator/denominator selections without snackbar effects

The main thing here is that useOverlayConfig returns undefined if the numerator/denominators are incorrect in two ways

the existing condition that numerators must be present in denominator
all numerators and denominators must be in the variable's vocabulary (which can change now, due to filters)

When the overlay config is "bad" then the bubbles and bubble legend data requests are disabled and the user is directed to make amends.
How to test

at the moment, it's best to use the tick data from qa.vectorbase back end
for me that's https://localhost:3000/maps/DS_e18287e335/new
get bubble markers on biological sex with female / female+unknown
then add a filter on biological sex = male, unknown
go back to bubble config to see what's going on

Some rough edges still need to be worked out

[ ] ideally we need to stop showing the markers when the config is bad, and the legend(s) need to show something helpful, rather than the previous legend data (I'm thinking that all map legends should have a :gear: icon in the bottom right corner which simply opens up the maptype configuration panel)
[ ] how can we get the useQuerys to emphatically return "no data" so that we don't keep showing the previousData? I tried a return undefined in a queryFn and it didn't like that.
[ ] basically we want the map to look the same after changing filters so that bubble proportion configs are invalid
- directly after invalidation
- after switching map types and back to bubble again (or refreshing the browser)
[x] must test lineplot proportions and check not broken! - see how filter sensitivity works there
[ ] check how many back end requests are made - are any causing back end errors?

Tested lineplot (as a floater).
It looks like the new approach would help here. We just have to tell the user what the red outline means and decide whether or not to disable plotting when things are invalid (probably should!)

I think the general UX for this is good. Once you are able to get rid of the markers, I think this will be in very good shape.
A suggestion for the legend when the config is bad is to show the invalid proportion error, along with a link/button to open the config menu.
I also think we should keep the invalid values, even if not selected, and to disable them if not selected. I think it will make what's going on more obvious to the user.

Superseded by https://github.com/VEuPathDB/web-monorepo/pull/671
This should NOT be merged!


Release 0.2

Why 0.2.0 is not uploaded to PyPi?

I will upload the wheels right now, it was too late yesterday :-)

Ok, no problem :-) But please don't make half-way releases for next time.

@ccordoba12 They're available right now on PyPi


make bootstrap is failing due to missing build dependences

Bug Report
Hi all, I'm excited to get started developing with Ralph. Getting set up I ran into an issue, however. On the master branch make bootstrap errors out pip installing psutil due to gcc not being available.
Expected behavior/code
make bootstrap builds the docker images cleanly.
Actual Behavior
An error occurs:
#0 22.22       creating build/temp.linux-aarch64-cpython-39/psutil
#0 22.22       gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_SIZEOF_PID_T=4 -DPSUTIL_VERSION=594 -DPy_LIMITED_API=0x03060000 -DPSUTIL_LINUX=1 -DPSUTIL_ETHTOOL_MISSING_TYPES=1 -I/usr/local/include/python3.9 -c psutil/_psutil_common.c -o build/temp.linux-aarch64-cpython-39/psutil/_psutil_common.o
#0 22.22       C compiler or Python headers are not installed on this system. Try to run:
#0 22.22       sudo apt-get install gcc python3-dev
#0 22.22       error: command 'gcc' failed: No such file or directory

Steps to Reproduce

Sync the Ralph master branch
run make bootstrap
The above error occurs

Environment

Ralph version: master branch
Platform: Docker Desktop on Mac OS 13.0.1

Possible Solution
I was able to get a successful build by adding the required development tools, see the PR here: https://github.com/bmtcril/ralph/pull/1

Thanks for your feedback! :heart:
I cannot reproduce this behavior, not sure if it's platform-specific or not.

Did you add a new dependency before trying to build / bootstrap?
Can you provide the full building logs?
Which version of Docker + compose are you running?

Thanks for the reply @jmaupetit ...

No new dependencies, just pulled master and ran make bootstrap
It's pretty long, but I just reproduced it. Here's a gist with the log: https://gist.github.com/bmtcril/6f5b5653318a7baf045750eee73bc079
Docker Desktop for Mac, Docker version 20.10.21, build baeda1f, Docker Compose version v2.13.0

Ok, after digging a bit with colleagues using M1 Mac laptops, it occurs that it is linked to this specific architecture. Adding platform: linux/amd64 to the app service in the docker-compose file seems to fix the issue:
# docker-compose.yml

# [...]
services:
  app:
    platform: linux/amd64
    # [...]

Can you confirm this?

This does work, but forces the image to run in emulation which is bad for performance and can exhibit bugs. An alternative to the fix I proposed, if the concern is build speed, is to wrap it in a conditional. I've confirmed this only installs the necessary packages on the correct platform (line 53 in Dockerfile):
# Only the M1 Mac images need these packages installed
ARG TARGETPLATFORM
RUN if [ "$TARGETPLATFORM" = "linux/arm64" ]; \
    then apt-get update && \
        apt-get install -y \
        build-essential \
        gcc \
        python-dev && \
        rm -rf /var/lib/apt/lists/*; \
    fi;

Ok, then, let's do it this way! Can you submit your PR please?
Thanks again for this feedback. M1 Mac users will thank you :heart:


How to config containerd runtime data dir？

by default, is it /run/containerd
How to change to /data/containerd ?

I think it is this file: https://github.com/containerd/containerd/blob/master/defaults/defaults_unix.go
Can you share the reason that you want to use a customized directory?

@qiutongs
is this config similar to --graph=/data/docker  in docker ?

containerd/cri repo is planned to be archived. Let me move this issue from containerd/cri to https://github.com/containerd/containerd/discussions


Define the strategy for creating a new azd template repo in Azure-Samples

The current approach is to create a private repository with a staging branch and to make the repository public once it is ready.
For the time it becomes public, we need to create a main branch as the default and use the commits from staging.  Then staging should continue to be the development vehicle for that template
New suggested approach

Create public branch since the beginning.
Create main branch as default with placeholder files (like a work-in-progress Readme file and files)
Create and start using the staging branch for building the template
Once the template is ready, merge staging to main to make the template public (optionally creating a release tag to add versioning to the template)

Repos with nothing in the main branch look pretty bare. Is there a way to programmatically construct something to put in README... otherwise people will stumble across these repos and wonder why they're empty and when they'll be filled.
On merge to main:

Update the description
Set the topics
Ensure repo is not private? (will we ever have a need to release to main and keep the repo private?)


Review the Italian Open Data License (IODL)

http://www.dati.gov.it/iodl/2.0/

Is this something we need to do? Perhaps @federicomorando has an opinion? Please re-open if so. Otherwise closing this stale issue.


Use null instead of an object with undefined properties

This will be coalesced to an empty object, which keeps the expected behavior. The previous default would trigger a warning in the console about it not being conform to the vec3 property type definition.
Warning is:
core:schema:warn Default value [object Object] does not match type vec3 in component ammo-body

Thanks for this.


Improved environment management docs

Addresses #55
While testing the documented workflow I also bumped the environment to use jupyterbook 0.13, python 3.10 (which will be nice for tutorials b/c of better error messages), and added osx-arm64 to the lockfile (seems more and more people have the new CPUs!)...

TODO: will also modify https://tutorial.xarray.dev/scipy-tutorial/00_overview.html once the other open PRs / restructuring is merged in


Question: Setting up ODBC connection using server/instance

Hello. I am trying to setup an ODBC connection using this great library. I have been struggling to get the connection established and have been getting a rather vague message:

Login error: driver: bad connection

The connection string I am using looks like this:
	conn, err := sql.Open("sqlserver", `odbc:server=owmsrvdb1\Altaris;database=Altaris;trusted_connection=yes;`)

Note: When I change the server name to just owmsrvdb1 it seems to go a little farther. Perhaps a bug is revealing itself?

I was able to connect to my database using a python library  (I am hoping to bring Go to the company I work for the very first time, so it would be nice to be able to get going again!), which looked like this:
conn = pypyodbc.connect(
  'Driver={SQL Server};'
  'Server=owmsrvdb1\Altaris;'
  'Database=Altaris;'
  'Trusted_Connection=yes;'
  )

Am I missing something? Any and all help appreciated, thanks!

It is possible that your databases aren't configured to support TCP/IP.
Also, this driver does NOT speak ODBC, it speaks TDS which is what MS SQL Server nativity speaks.
A better comparison would be to try the connection with an ADO.NET driver to see if you can connect. We won't be able to use an ODBC data source with this driver.


Modified code to return as a percent value

@param-thakker LGTM, could you please run pre-commit to fix the build?

@geospatial-jeff Could you please tell me how to do it? This is my first ever contribution to OSS and I'm trying to learn!

The Contributing doc might be helpful: https://github.com/cogeotiff/rio-tiler/blob/master/CONTRIBUTING.md#contributing

Yes please follow the Contributing doc to get your environment set up.  It doesn't cover retroactively running pre-commit checks, which you can do with pre-commit run --all-files after you've installed the hooks with pre-commit install.
This will apply pre-commit to all existing files in your branch, you can push the changes and that should fix the build.

thanks for your contribution @param-thakker 🙏
I've ran pre-commit and updated the test to make sure the valid_percent value is between 0 and 100.


Disallow tag name change

Tasks

[ ] Make tag name input disabled in tag detail editor

Issue requires review and rearrangement. Close it.


block transfer unit tests broken

While testing #461 (block transfer)
Suite: Suite_block1
Test: test of test_block1_nominal() ...passed
Test: test of test_block1_retransmit() ...Segmentation fault (core dumped)

In PR #461 the "test_block1_retransmit()" is disabled. The test is considered faulty not the code. Should be revisited and re-enabled

@tuve Any chance you can take care of this?

I can have a look at

PR #682 will fix this.


[bug] Apple Music Gradient not moving on macOS

Environment

Spotify Version: <IP_ADDRESS>2.g26c92729
Spicetify Version: v2.36.2
Platform: MAC

Addons

Extensions: hidePodcasts.js, romaji-convert.js, popupLyrics.js, beautiful-lyrics.js, shuffle+.js, fullAppDisplayMod.js, listPlaylistsWithSong.js (EDIT: Also tried without any extension installed, same problem.)
Custom Apps: none
Snippets: none

Spicetify Config
Default
Theme Information
Pastebin: https://pastebin.com/UNibkUPu
Describe the bug
On Windows, my friend has an animation with the Apple Music Gradient option enabled, while I don't have that (nothing moves) with the default Apple Music Gradient options on MacOS.
Screenshots
Here's a video : https://cln.sh/FNXdRgdvx8z8Z6s97Jwq
Thanks

I am unable to reproduce and fix as i do not have a mac device, are you certain this is the case on all mac devices - do you know anyone else with a mac that can test this?


add instruction to label the default ns for bookinfo example

resolving this https://github.com/istio/istio/issues/6957

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: rokii
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sdake
Assign the PR to them by writing /assign @sdake in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

content/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @rokii. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

@rokii: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rokii
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: rokii
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sdake
Assign the PR to them by writing /assign @sdake in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

content/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: rokii
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sdake
Assign the PR to them by writing /assign @sdake in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

content/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdake I have no idea why this pr cause the lint check fails.
- ./public/docs/examples/bookinfo/index.html
  *  7:359: ERROR: Unexpected end tag : p (line 7)
htmlproofer 3.9.1 | Error:  HTML-Proofer found 1 failure!
LINTING FAILED

Could you help merge or fix this?

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: frankbu, rokii
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

content/OWNERS [frankbu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@geeknoid I think that either the html proofer is getting confused, or there's a a problem transforming command output with two commands plus output. Either way, it seems to display correctly. Any idea which it is?

This is unfortunately a bug in the markdown converter that happens once in a while. The fix is simple. Just wrap the whole text block with a div. Please search the .md files for the few examples of this and use the same class name as those divs.

BTW, when this happens, the generated HTML is incorrect. Whether it displays properly or not is up to the luck of the draw.

Merging and will fix hugo issue in followup PR


Import release notes

Closes #61

All the magic came from @jcfr 's script and package -- a huge time saver!


AppVeyor doesnt fail build when it fails

No idea why but AppVeyor doesnt fail build when it fails.
e.g. https://ci.appveyor.com/project/TomPallister/ocelot-fcfpb/build/2.1.0-PullRequest.168+20.build.425
Work out why and fix.

Could be this https://github.com/cake-build/cake/issues/1478

@TomPallister out of interest did the exit statement fix the problem? Got a few pipelines of my own to fix... ;)

@binarymash yes it did!


Develop Email Marketing Campaigns

Newsletter Lead

[ ] - Create email newsletters to update supporters and stakeholders on CLENT Africa’s activities.
[ ] - Highlight upcoming events, recent achievements, and ways to get involved.
[ ] - Use email marketing tools to design and distribute the newsletters.

cc @axelledongni


Show Insiders Commit on Download Website

https://code.visualstudio.com/insiders/ should be more verbose. At the very least it should be showing the current commit it is on right now. As a bonus, it could also show the timer until the next build.

@Tyriar What do you think about this?

Why do you want the current commit?

@Tyriar To tell when it was updated last? It's daily but this would be useful nevertheless

@Astrantia you should get the update notification on the gear in the bottom-left though when there are updates available?

@Tyriar It's confusing as it is right now. I don't have Insiders installed now and I can't tell what commit it is on. I tried installing and saw that it was last updated 7 days ago.

@Astrantia but the notification in VS Code will always tell you when there's a new update as it asks the update server. Why would you care if it was last updated 7 days ago if you haven't even installed it yet? 😕
We turn off Insiders updates during our testing period (to stabilize the release) and at the end of the year (as most people are out).

@Tyriar I uninstall Insiders after checking some feature updates so I'd like a better transparency over updates without relying on the vscode insiders notification.

The latest commit depends on the platform. We don't have this available on the website but we do have it available as a REST API:
https://update.code.visualstudio.com/api/update/PLATFORM/insider/latest
Possible values for PLATFORM:
"win32-x64",
"win32",
"win32-archive-x64",
"win32-archive",
"win32-x64-user",
"win32-user",
"linux-x64",
"linux-ia32",
"linux-deb-x64",
"linux-deb-ia32",
"linux-rpm-x64",
"linux-rpm-ia32",
"darwin"


Forgot Password full implementation

Fixes #75
This code review is probably a good example as to how to make any general feature, as I had to touch nearly every part of the code.

few minor things. Otherwise looks good and functions as expected. Thanks!

creates #99 to address forgot password information reveal

Should also run jshint on this. you have some errors


test

i added the unit tests as requested, pls merge 🙏

@Disservin help, idk how to access the openings.epd file in the tests, this doesnt seem to cut it: https://github.com/gahtan-syarif/fast-chess/blob/reducemem6/tests/openings_test.cpp#L12

@Disservin help, idk how to access the openings.epd file in the tests, this doesnt seem to cut it: https://github.com/gahtan-syarif/fast-chess/blob/reducemem6/tests/openings_test.cpp#L12

nvm figured it out

This test isn't exactly testing much.. you are calling getEpdBook which returns a copy of the internal vector and then you check if certain strings are at the exact position you want them to be. You should be testing it how it is also used in the code, meaning you create the book and then you call fetchId multiple times and you use the result of that to index the OpeningBook which you then assert

This test isn't exactly testing much.. you are calling getEpdBook which returns a copy of the internal vector and then you check if certain strings are at the exact position you want them to be. You should be testing it how it is used in the code, meaning you create the book and then you call fetchId multiple times and you use the result of that to index the OpeningBook which you then assert and you call fetch as often as the number of rounds which will be played. Also there are cases to cover,

rounds < number of openings
rounds == number of openings
rounds > number of openings

alright, ill fix it


support validation of nmdc-schema data objects against stricter submission-schema rules

currently requires flattening nmdc-schema data objects to match the tabular orientation of the submission schema
possible solution: add environment-specific Biosample subclasses to nmdc-schema

@turbomam if i'm understanding this, you want the ability to test if record in mongo "A" would pass nmdc-schema validation? Yes?
I think this would be very helpful for projects we pull in without using the submission portal & would be a good part of the "rating system"https://github.com/microbiomedata/issues/issues/475


Improve invitation list

Fix delete invites
Add resend invite
Add copy invitehash

Note: Ask for resend invite endpoint

1- Under the hood, the libraries use the same pattern I used and as this was the only case I didn't want to add a library just for this case. But if we had/will have other use cases when this method is not enough we should go with a library.
2- The use case that max said if we want to send the link through chat for faster but I agree, re-send the invitation is more secure. I will talk to him.

Update: we are going to use just the resend here and delete the copy functionality

1.- Understandable. Let's do that then.
2.- Awesome. Let me know when the changes are pushed.

Done


Update Settings “general”

Automatically generated by Netlify CMS

👷 Deploy Preview for dashing-fox-64c847 processing.

Name
Link

🔨 Latest commit
18b51fa09c9f05add99981236b305168d4c7372b

🔍 Latest deploy log
https://app.netlify.com/sites/dashing-fox-64c847/deploys/62b1653f9e00660008dd74fe


Feature/admin update testing

Testing branch, don't merge to dev!

@dowdt is this PR intended to be merged into nixpkgs ? or opened by accident since "dev" branch is not part of nixpkgs workflow

Sorry mate, this is a mistake! Meant to make a pull request on our own repo.


Add config for metastore filtering

The metastore does not enforce canonical representation of values. For
example, a boolean column may represent the false value as "0", "false",
"False" or possibly other representations as well. This adds a config
flag "hive.assume-canonical-partition-keys" which can be set to true, if
all partition values are known to use the canonical (Java)
representation. Doing so may provide a performance increase for tables
with a large number of partitions that have non-string partition keys.

We should probably add a test table for this.

Looks good


merge at 2018-06-13

Codecov Report

Merging #4211 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4211      +/-   ##
==========================================
+ Coverage   41.07%   41.08%   +0.01%
==========================================
  Files        2378     2378
  Lines       74516    74516
  Branches    10087    10087
==========================================
+ Hits        30607    30618      +11
+ Misses      41089    41082       -7
+ Partials     2820     2816       -4

Impacted Files
Coverage Δ

...om/navercorp/pinpoint/rpc/codec/PacketDecoder.java
61.7% <0%> (-2.13%)
:arrow_down:

...pinpoint/profiler/monitor/DeadlockMonitorTask.java
18.6% <0%> (-1.17%)
:arrow_down:

...cluster/zookeeper/ZookeeperClusterDataManager.java
64.62% <0%> (-0.69%)
:arrow_down:

...point/rpc/client/DefaultPinpointClientHandler.java
71.06% <0%> (-0.33%)
:arrow_down:

...m/navercorp/pinpoint/test/OrderedSpanRecorder.java
72.11% <0%> (ø)
:arrow_up:

...orp/pinpoint/rpc/server/DefaultPinpointServer.java
81.25% <0%> (+2.77%)
:arrow_up:

...corp/pinpoint/rpc/stream/StreamChannelManager.java
72.41% <0%> (+2.87%)
:arrow_up:

...tor/metric/datasource/DefaultDataSourceMetric.java
78.78% <0%> (+3.03%)
:arrow_up:

...vercorp/pinpoint/rpc/packet/ClientClosePacket.java
66.66% <0%> (+11.11%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 433c40b...8f1e58c. Read the comment docs.