Memory leaks detected when calling EN_saveinpfile()

Tests that open an input file, modify the data model, and then save a modified input file are affected by this bug.

Bug may be isolated to [REACTION] section.

I am compiling exactly as defined above.  Networks having pumps are modified by adding some tanks and pipes. New pipe indexes are added after the present pump (leaving pumps in between) until the network is saved as inp.
In the saved inp, pump indexes are moved to the end as they are supposed to be (I think).
Are these related to this issue?

@kafakiran Thanks for asking, however, I don't think these issues are related.

Still having memory problems with unit tests when they are built in Debug configuration.
The parser does not like the input file generated using EN_saveinpfile(). When I run it, it causes periodic stack overflows in readdata().

I believe it may have something to do with the [DEMANDS] section.

I was encountering the same issue and I think I've solved it. I will push my latest commits shortly.

I've tracked down the source of the segfaults. When EN_saveinpfile() writes an input file to disk it doesn't place a line feed character at the end of the last line (which is [END]). The gettokens() function in input2.c, which splits an input line into a set of string tokens when an INP file is read, assumes that each line ends with a line feed, a space or a tab. If it doesn't see one of these it keeps parsing the input line beyond its end-of-string null character, using whatever the contents are in the unused portion of the line's character array (sized to MAXLINE = 1024 characters) until up to MAXTOKS = 40 tokens are generated. In the process, it overwrites the end of each token with a null character which I assume can cause the segfaults somewhere.
The immediate fix is to replace
 fprintf(f, s_END);

at about line 801 in inpfile.c with
fprintf(f, "%s\n", s_END);

This will allow the unit tests that read from a saved INP file to work consistently. The longer term need is to fix gettokens() so it works correctly even when the last line in an INP file doesn't end with a line feed.

gettokens() can be fixed as follows:
    while (len > 0 && n < MAXTOKS)
    {
        m = (int)strcspn(s,SEPSTR);     // Find token length
        if (m == len)                   // NEW CODE BEGINS HERE
        {
            Tok[n] = s;
            n++;
            break;
        }


Thermostat ranges in F???

One of my accessories developed using the thermostat service, how does one make the ranges appear as "F" rather than "C".
It seems the TargetTemperature/CoolingThreshold/HeatingThreshold etc characteristics are only limited to a max of 38 C, even if change the allowed ranges.
Sure an earlier version of iOS (12??) when you changed the DisplayedTemperatureUnits, HomeKit automatically converted these numbers to between C and F.. At least in iOS 13 (13.3 and 13.4B), doesn't do this.,

That would be a bug in the Home app.  HAP only deals with °C and it's up to the HomeKit app to convert this to °F.  Did you try another HomeKit app?
The characteristic is called TemperatureDisplayUnits.  Did you double-check your code?
https://github.com/KhaosT/HAP-NodeJS/blob/52abfb360f8d65a7ec73ded685db5b8a58d0c2b7/src/lib/gen/HomeKit.ts#L2910

Seems to be the same in EveHome also. Changing the display units to F changes the current temp, but not the ranges. oh well. wondered if anyone had come across this also


Feature request term and goal expansion

I tried term and goal expansion. But it seems not to be available:

The test case is from here:
https://github.com/hsk/simpletapl/blob/master/prolog_basis/README.md#goal_expansion

Added in ea31ee5b309a12ef09ef8682e7a7ca9de22e1e93.
Thanks for your request.


⚠ Melody Beta has degraded performance

In 9b4616c, Melody Beta (https://canary.melody.api.triza.dev) experienced degraded performance:

HTTP code: 200
Response time: 20504 ms

Resolved: Melody Beta performance has improved in 195aa6c.


Change Issues visibility in Explorer & Navigator

Relevant information
By setting the isAlertable flag from true to false we're proposing to remove entities type of Issue from Explorer and Navigator. These entities will be still searchable in the Quick Find section and all Issues will be visible within the Alerts & AI Issues feed page.
Furthermore - Issues entities will continue to be colored according to the severity of the underlying set of issues.
Checklist

[x] I've read the guidelines and understand the acceptance criteria.
[x] The value of the attribute marked as identifier will be unique and valid.
[x] I've confirmed that my entity type wasn't already defined. If it is I'm providing an explanation above.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Identify error with point layers.

This issue was imported from CodePlex
jwolter wrote 2011-01-10 at 18:18
I'm working with Alaska data while writing some proof of principle code for a project I'm working on.
I have the state outline(poly), Lakes(poly), Major Rivers(line), Rivers(line), Railroads(line), and Populated Places(point) added to the map.
Identify works for all of the polygon and line features but when I click on a point I get the following error.
"
An unhandled exception of type 'System.IO.IOException' occurred in mscorlib.dll
Additional information: An attempt was made to move the file pointer before the beginning of the file.
"
I've tried using a different point layer but get the same error with identify.
Is this a known problem?

Not reproduced.


Typo, easy fix

VSCode Version: 1.7.2
OS Version: Debian 8.6

Steps to Reproduce:

ctrl+shift+f
Toggle search details

Settings appears as "files excluded through set tings"

Try to use the new version of vscode

This fixed in 1.8.0


Fix: scrollLeft and scrollTop can be negative in Grid's onScroll

If the total width of the columns is less than the specified width of the Grid, then onScroll fires with a negative value. I assume the Math.min(...) is to prevent scrollLeft from being set to a value that would imply scrolling beyond the right edge of the right-most column -- the Math.max(...) I've added should stop scrolling beyond the left edge of the left-most column.

I've also just noticed similar code in CollectionView, but I've never used that component. Assuming this fix actually makes sense, does it belong there as well? If so, is it worth trying to extract the common code?

[Current coverage][cc-pull] is 94.81%

Merging [#256][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master       #256   diff @@
==========================================
  Files            30         30
  Lines           983        983
  Methods          85         85
  Messages          0          0
  Branches        217        217
==========================================
  Hits            932        932
  Misses           51         51
  Partials          0          0

Powered by Codecov. Last updated by [2c1134a...33fb603][cc-compare]
[cc-base-branch]: https://codecov.io/gh/bvaughn/react-virtualized/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/bvaughn/react-virtualized/compare/2c1134ad3c60cc86b84303a530af76152b18a66b...33fb6032af258f3f0506935b9bf8cdd937f7f898
[cc-pull]: https://codecov.io/gh/bvaughn/react-virtualized/pull/256?src=pr

Nice! Thanks for the fix and the clear explanation.

I've also just noticed similar code in CollectionView, but I've never used that component. Assuming this fix actually makes sense, does it belong there as well? If so, is it worth trying to extract the common code?

I tried to do this at one point but decided it was too large an effort for me given the time I had. My initial intent was for CollectionView to be the shared code and for Collection and Grid to both just be cellLayoutManager implementations. Obviously I only got half way there. (Collection uses it but Grid does not...at least yet.)

Btu yes, to answer your other question~ this fix does apply to Collection too! Would you be willing to add it? If not I'd be happy to, after merging your PR.

I'll add it myself. :)

Fixed and released as 7.2.0
Thank you for your contribution. :)


the logo is too big

hello the logo is too big, it crosses out my username, home button, and Games. Please fix
Edit: it only works when in light mode

Edit: it only works when in light mode
Yeah. The style was built ontop of .light-mode classes so it'll only work on light mode.


URL Prefix

I have set up my CI server behind an Nginx reverse proxy that maps it to /drone/. However, is there a way to let Drone know of this prefix? It redirects to /login instead of /drone/login.

duplicate of https://github.com/drone/drone/issues/475


Inconsistency with bem.info - Single dash vs. double dash

Hi!
While digging for more info about BEM, we found that getbem.com and bem.info contradict each other regarding naming of modifiers.

The modifier name is separated from the block or element name by a single underscore (_).
https://en.bem.info/methodology/quick-start/#modifier

getbem and basically every other resource I found on the internet uses two underscores. bem.info lists this style as Two Dashes style. In a discussion with team members, the question "Why are we using an alternative style?" arose.
Can someone shed some light onto this? Is bem.info just outdated on that regard?

@Malax bem.info is not outdated but uses convention which was invented at the very beginning and is just fine. Two Dashes style was introduced later but has no any distinct advantages. It's just a matter of taste.
See https://en.bem.info/methodology/naming-convention/#which-style-to-choose

BTW, take a look at https://github.com/rebem/css

Thanks for your answer! I guess it's a bit my fault considering BEM also a style guide for CSS. It's more a methodology than a style guide I guess. Anyway, this means you cannot say: "We're doing BEM" but need to add what kind of style you use.
This might be a good Idea to state that on getbem.com so other will not run into the same issue. getbem.com is consistent regarding the style, but if you dig deeper you find others and might get into the confused state.
Anyway, this Issue can be closed - but maybe you guys can take the idea into consideration. :)


jpeg <0.0.0a run constrain breaks pillow torchvision compatibility

Comment:
Hi @hmaarrfk and all
There is an compatibility issue introduced between libjpeg-turbo <IP_ADDRESS> (via pillow 9.5.0) and any torchvison version due to the addition of jpeg <0.0.0a run constrain in https://github.com/conda-forge/libjpeg-turbo-feedstock/commit/6cee8324c6109060155cfe31c4175a62f7628eef.
May i ask the rational of this breaking change in an update between 2.1.4 build 0 to 2.1.4 build 1?
Also, further investigation found that jpeg <0.0.0a doesn't map to any existing jpeg conda package versions in conda-forge, which means this constrain will eliminate the compatibility between libjpeg-turbo and any other conda package that depend on jpeg.
The following packages are incompatible
├─ pillow 9.5.0**  is installable and it requires
│  └─ libjpeg-turbo >=<IP_ADDRESS>,<3.0a0 , which requires
│     └─ jpeg <0.0.0a , which can be installed;
└─ torchvision   is uninstallable because there are no viable options
   ├─ torchvision [0.15.1|0.15.2] would require
   │  └─ jpeg  , which conflicts with any installable versions previously reported;
   └─ torchvision [0.10.0|0.10.1|...|0.9.1] conflicts with any installable versions previously reported.

Please see https://github.com/conda-forge/conda-forge.github.io/issues/673
The last comment is me mostly admitting the difficulty in fixing the problem you are hitting.
My solution has been to
conda uninstall --force --offline --yes jpeg
mamba update --all --yes

generally gets you through.
https://github.com/conda-forge/conda-forge.github.io/issues/1894

software maintainers

As I understand it torchvision, the recipe you linked to, is not dependent on the conda-forge ecosystem.
https://github.com/pytorch/vision/blob/main/packaging/torchvision/conda_build_config.yaml#L2
while there used to be a big alignment between defaults and conda-forge in the past, the two channels are, today, largely incompatible.
The torchvision package from conda-forge should be compatible
https://github.com/conda-forge/torchvision-feedstock/
on windows, we could use help in the form of packing, or donation of your "time" to manually build windows from time to time.
see the many attempts at building windows:
https://github.com/conda-forge/pytorch-cpu-feedstock/pulls

I forgot to say, thank you for being so understanding of the tradeoffs.


gradients for depthwise 2d convolutions

Description
This PR addresses https://github.com/tensorflow/tfjs/issues/71 by introducing gradient support for depthwiseConv2D (letting users train or compute saliency maps for models using depthwise convolutions).
Gradient functions are very similar to the corresponding functions for regular 2D convolutions (and actually return the same results in the special case that no further transformations of the output occur), except instead of iterating over all the output channels, we only iterate over a subset. The indexing into filter weights also becomes different than the indexing into outputs.
In implementing this, I found reference implementations in C++ very helpful.

For repository owners only:
Please remember to apply all applicable tags to your pull request.
Tags: FEATURE, BREAKING, BUG, PERF, DEV, DOC, SECURITY
For more info see: https://github.com/tensorflow/tfjs/blob/master/DEVELOPMENT.md

This change is

Really really nice work. Left tiny comments - feel free to go ahead with WebGL

Review status: all files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.

src/kernels/backend_cpu.ts, line 1247 at r1 (raw file):
Previously, asross (Andrew Ross) wrote…
This selects only the output channels corresponding to the current gradient component's input channel.

Nice!

src/kernels/backend_cpu.ts, line 1251 at r1 (raw file):
Previously, asross (Andrew Ross) wrote…
dm just goes from 0 to chMul. It might actually be more intuitive to index that way (so d2 = d1 * chMul + dm) -- let me know if you'd prefer that.

Yeah, it would be a bit cleaner to do dm from 0  to chMul.

src/ops/conv.ts, line 578 at r1 (raw file):
Previously, asross (Andrew Ross) wrote…
For a while, I was missing this true, which ended up being a very tricky bug. Might
be a sign that the interface for computeConv2DInfo is getting a bit clunky, though I know it's not part of the public API...

yeah, it gradually evolved to be all encompassing and splitting it into different entry points is a great suggestion, but as you pointed out correctly, may not be worth the effort for now.

src/ops/conv.ts, line 549 at r2 (raw file):

    util.assert(
        xShape4D.length === 4,
        `Error in depthwiseConv2DDerInput: inShape must be length 4, but got length ` +

fix wrap

src/ops/conv.ts, line 571 at r2 (raw file):

      util.assert(
          util.isInt(pad as number),
          `Error in depthwiseConv2DDerInput: pad must be an integer when using, ` +

fix wrap

src/ops/conv.ts, line 624 at r2 (raw file):

    util.assert(
        x4D.rank === 4,
        `Error in depthwiseConv2DDerFilter: input must be rank 4, but got shape ` +

wrap

src/ops/conv.ts, line 632 at r2 (raw file):

    util.assert(
        filterShape.length === 4,
        `Error in depthwiseConv2DDerFilter: filterShape must be length 4, but got ` +

wrap

src/ops/conv.ts, line 646 at r2 (raw file):

      util.assert(
          util.isInt(pad as number),
          `Error in depthwiseConv2DDerFilter: pad must be an integer when using, ` +

fix wrap

src/ops/conv2d_depthwise_test.ts, line 445 at r1 (raw file):
Previously, asross (Andrew Ross) wrote…
Let me know if you think this test is too complicated / not complicated enough. I basically just copied outputs from this notebook into the test.

This test is great. Though I would write a couple more that test different scenarious, e.g. stride = 2, chMul = 2, another padding type.  Don't worry about tests being mostly repetitive (we don't ship these) - the more self containing the test is - the better.

Comments from Reviewable

Really really nice work! Left a few comments, but they are all very small!

Review status: all files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.

src/kernels/webgl/conv_backprop_gpu_depthwise.ts, line 3 at r3 (raw file):

/**
 * @license
 * Copyright 2017 Google Inc. All Rights Reserved.

2018 Google LLC

src/kernels/webgl/conv_backprop_gpu_depthwise.ts, line 46 at r3 (raw file):

        float dotProd = 0.0;

        for (int b = 0; b < ${convInfo.batchSize}; b++) {

add a // TODO: Vec4 over the batch size . (will chat in person after this PR is in)

src/kernels/webgl/conv_backprop_gpu_depthwise.ts, line 124 at r3 (raw file):

            int wCPerm = ${filterWidth} - 1 - wC;

            for (int dm = 0; dm < ${channelMul}; dm++) {

add a // TODO: Vec4 over the channelMul (we'll chat in person after this PR)

src/ops/conv.ts, line 508 at r3 (raw file):

  }

  static depthwiseConv2dDerInput<T extends Tensor3D|Tensor4D>(

since these 2 private methods don't have any decorators, move them to the bottom of the file and remove static keyword. (context: decorators are only allowed on class methods, and not free-floating functions, thus we have these strange looking classes with bunch of static methods )

src/ops/conv2d_depthwise_test.ts, line 433 at r3 (raw file):

  it('wrt input, squared output', () => {
    const grad = tf.grad(
      (x: tf.Tensor4D) => tf.square(tf.depthwiseConv2d(x, filter, stride, pad))

tip: https://js.tensorflow.org/api/0.11.2/#grad
tf.grad returns a function with an optional second argument being dy
so you can specify your own dy
e.g. https://github.com/tensorflow/tfjs-core/blob/master/src/ops/binary_ops_test.ts#L773
so it might be simpler to just use that API instead of calling tf.square()

Comments from Reviewable

 Wohoo!

Review status: 4 of 6 files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.

Comments from Reviewable


fix issues with soc rename: intel_adsp/ace30/ptl

soc: intel_adsp: rename missing file during compilation
manifest: update SOF revision

Fixes #78931

@nashif maybe this also needs updating(?)
xtensa-build-zephyr.py
94: "intel", "intel_adsp/ace30_ptl",
100: "intel", "intel_adsp/ace30_ptl_sim",

@nashif maybe this also needs updating(?)
xtensa-build-zephyr.py
94: "intel", "intel_adsp/ace30_ptl",
100: "intel", "intel_adsp/ace30_ptl_sim",

yes, but this is not used in our CI or zephyr, this is done from SOF, so it wont break anything from our side of things in this PR.
Will do the update as a followup one CI is unblocked

@nashif maybe this also needs updating(?) xtensa-build-zephyr.py 94: "intel", "intel_adsp/ace30_ptl", 100: "intel", "intel_adsp/ace30_ptl_sim",

Yes, but I changed it in the sof repo
https://github.com/thesofproject/sof/pull/9475/files#diff-daebe2b740a448f2617ecb57b6bb2ac998b0ba033b67552559b5b1344f0ee1de

Yes, but I changed it in the sof repo
thesofproject/sof#9475 (files)

yeah, will update sof module once this is merged


TSCBasic: Use collection diff api for EditDistance if possible

Sorry this is my first PR for this. I'm not sure if I should or how to correctly commit to SPM according to the README:
All changes to source files in this repository need to be done in the repository of the Swift Package Manager repository ([link](https://github.com/apple/swift-package-manager)) and then copied here using the Script in Utilities/import which takes the local path to the SwiftPM directory as input (or uses ../swiftpm as default).

@swift-ci please test linux

https://github.com/apple/swift-tools-support-core/pull/303 removes the outdated remark you noticed.

thanks @PetrGuan can you confirm we have a test covering this functionality?

@tomerd There's already a test in EditDistanceTests. But I'm not sure how to test the full code path for if #available and else, any suggestions? Or should I break it up to two functions and test each separately?

right we can break into separate functions and test separately

Thanks, just updated

@swift-ci test

thanks @PetrGuan


Fix backslashes in generated files

Fixes #213
Some systems treat escaping of text passed to the echo command
from a Makefile differently.
This seems to work for our needs.

Please @rafatower @ethervoid  CR this

:+1


RE 2 Poor performance RTX3080 mobile version

Hi,
I am trying to achieve playable fps with decent quality on my alienware x15, rtx3080, i7-11800H, Win10, when connecting to Quest 2 Airlink.
Below I am sending my current quality(recorded using broadcasting on Oculus mobile app).
https://www.youtube.com/watch?v=kf726DP6Exw
I am encountering low fps. What I also notice is my head movement is fluid but when I am moving the image is jittering.
I have even less demanding setup than this:
https://youtu.be/AJI8MIUdfVc?t=1666 (should starts from 27:46).
I was different things: setting up on oculus side resolution to 72/90HZ (1 - 1.5). Changing resolution in SteamVR.
When I change resolution to 20% in SteamVR i am still having negative headroom.
I see many things that might affect that and I need to figure it out, but maybe you guys are having some suggestions.

It like my first attempt this mod,
I notice your resolution 2704x2736 is huge in steamVR,
90HZ is fine,
Then install FSR to get playable performance.


Specifying parameters in policy assignment loses Log Analytics ID

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Versions

terraform: 1.1.7
azure provider: 3.0.2
module: 2.0.0
Description
Describe the bug
I'm trying to set a parameter on a policy to disable logging of Azure Firewalls to the Log Analytics resource as per a company requirement. I'm not sure whether I am adding the parameter to the correct place in the policy but I am configuring the following set of locals in my code:
locals {
  archetype_config_overrides = {
    root = {
      archetype_id   = "es_root"
      parameters     = {
        Deploy-Resource-Diag = {
          FirewallLogAnalyticsEffect = "Disabled"
        }
      }
      access_control = local.empty_map
    }
  }
}

This creates the following change in Terraform:
module.enterprise_scale.azurerm_management_group_policy_assignment.enterprise_scale["/providers/Microsoft.Management/managementGroups/[correct-mg]/providers/Microsoft.Authorization/policyAssignments/Deploy-Resource-Diag"] will be updated in-place
  ~ resource "azurerm_management_group_policy_assignment" "enterprise_scale" {
        id                   = "/providers/Microsoft.Management/managementGroups/[correct-mg]/providers/Microsoft.Authorization/policyAssignments/Deploy-Resource-Diag"
        name                 = "Deploy-Resource-Diag"
      ~ parameters           = jsonencode(
          ~ {
              + FirewallLogAnalyticsEffect = {
                  + value = "Disabled"
                }
              ~ logAnalytics               = {
                  ~ value = "/subscriptions/[correct-id]/resourceGroups/[correct-rg]/providers/Microsoft.OperationalInsights/workspaces/[correct-workspace]" -> "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/[correct-rg]/providers/Microsoft.OperationalInsights/workspaces/[correct-workspace]"
                }
            }
        )
        # (8 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

Is this even the correct way of disabling the functionality of that policy (by sending in the parameter into the policy assignment) and if so what is causing the additional parameter to cause the subscription ID to be lost?

Based on further research (#207) I figure I need to specify the loganalytics parameter in the archetype configuration as I am overriding the parameters. I have done this and it has resolved the issue. Are the details in the linked issue still valid (i.e, if I add another value to the policy parameter it loses the subscription_id on the LA instance in the policy)?

Hi @adhodgson1. Thank you for logging this issue and following up with your further findings.
As you've discovered, we currently only set parameters based on what you provide in the parameter input object. i.e. We don't merge individual parameter inputs per assignment.
This means as soon as you set one parameter value for a specified assignment, you need to set all which don't have a (suitable) default value.
We took this approach to avoid unpredictable results.
As such I don't believe this is something that we would want to change, but I can see this would benefit from greater clarity on the Wiki page for archetype_config_overrides but also with a dedicated example page so I'll keep this issue open to track this update.
Would you be happy that updating the Wiki with clearer guidance would resolve your issue?
Thank you

Happy with your resolution here.

Trigger ADO Sync


preact-cli-foo not found.

Do you want to request a feature or report a bug?
bug
What is the current behavior?
~/workspace/potsdam(master ✗) npm install --save-dev preact-cli-foo
npm ERR! code E404
npm ERR! 404 Not Found: preact-cli-foo@latest

npm ERR!      /Users/elsa/.npm/_logs/2017-10-09T10_10_20_576Z-debug.log

If the current behavior is a bug, please provide the steps to reproduce.

What is the expected behavior?
I follow this wiki - https://github.com/developit/preact-cli/wiki/Plugins
preact-cli-foo is not exist.
If this is a feature request, what is motivation or use case for changing the behavior?
Please mention other relevant information.

node version 8.4.0
npm version 5.3.0
Operating system OSX

Hi, in that context preact-cli-foo represents any of the plugins which are listed here in the wiki.

@reznord  -_ -, I got it. thx


Hardening fails on Centos 7.1 at task 'minimize access'

Hardening fails on a brand new Centos 7.1 box:
failed: [idp-centos] => (item=/sbin) => {"failed": true, "item": "/sbin", "msg": "src and dest are required for creating links"}
failed: [idp-centos] => (item=/bin) => {"failed": true, "item": "/bin", "msg": "src and dest are required for creating links"}

Can anyone reproduce the issue?

The problem here is that /bin and /sbin are symlinks to /usr/bin and /usr/sbin in CentOS 7 and the file-module needs a dest-parameter to work, when the src is a symlink.
I don't know yet how I will work around this.

A quick workaround could be to use a when: statement with facts about the distribution such as:
`when: ansible_distribution="CentOS" and ansible_distribution_major_version="7"
and just have a special task for CentOS 7?

Yes, something like this:
- name: minimize access
  file: path='{{item}}' mode='go-w' follow=yes recurse=yes
  with_items:
    - '/usr/local/sbin'
    - '/usr/local/bin'
    - '/usr/sbin'
    - '/usr/bin'
    - '/sbin'
    - '/bin'
    - '{{os_env_extra_user_paths}}'
  when: not (ansible_distribution = "CentOS" and ansible_distribution_major_version="7")

- name: minimize access
  file: path='{{item}}' mode='go-w' follow=yes recurse=yes
  with_items:
    - '/usr/local/sbin'
    - '/usr/local/bin'
    - '/usr/sbin'
    - '/usr/bin'
    - '{{os_env_extra_user_paths}}'
  when: (ansible_distribution = "CentOS" and ansible_distribution_major_version="7")

Yep. I can put a PR together if you give me about 1h.

Take your time! ;)
However I'm not sure yet if this is the best approach to solving this problem, since there are essentially two tasks that do the same thing, then. And I'd like to keep it clean and simple.

I agree with you. But this is one of the troubles of having a role work on multiple OSes. I personally prefer to use one role per OS since it's a lot cleaner.

As discussed in #77, a two-pass approach for extracting a list of directories from a list of fullpaths will suffice here.


Use docker's new mounts API instead of Binds

Closes #1308 -- though this will be handled in the engine itself instead of the agent/exec interface. Not sure if we also want to check this in the agent.

Current coverage is 54.17% (diff: 62.06%)

Merging #1563 into master will increase coverage by 0.19%

@@             master      #1563   diff @@
==========================================
  Files            79         82     +3
  Lines         13479      13598   +119
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           7276       7367    +91
- Misses         5219       5235    +16
- Partials        984        996    +12

Powered by Codecov. Last update 3be4c3f...c2b9963

All better

LGTM

@cpuguy83 This still looks fine but should we wait for 1.13 release before merging into swarmkit or did you want to use this as a test bed? I have no opinion either way expect that it is hard to run dev version on mac.

Friendly ping :)
The train for 1.13 is leaving soon, we have to make a quick decision about this

What's the status of this PR? 1.13 has come and gone. Do we still want to pursue the changes?

@aaronlehmann This is still valid and relevant. Should be even easier to get working now that 1.13 is out.
@cpuguy83 Do you have time to update this?

Forgot about this thing.
Looks like we'll also be able to move tmpfs over to the new format as well. Can follow up with that.

Rebased.

LGTM

LGTM
Are there any analagous changes to make in the executor in docker, or is this specific to the dockerapi executor?

Are there any analagous changes to make in the executor in docker, or is this specific to the dockerapi executor?

These have already been done. I think the issue with making this change is that the API required 1.13 (or 17.03) or later.


add new browsers, platforms, devices and tests

Fixes #185.

Pull Request Test Coverage Report for Build 1545

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 1536:
0.0%

Covered Lines:
819

Relevant Lines:
819

💛  - Coveralls


Need to specify pubkey to connect using privKey

Why do we need to specify pubkey as well if we want to connect using ssh privkey?

there is an issue related to libssh2 <= 1.10.0, see #15


Windows AuthenticationDisplayName always null

Even when you do this:
services.Configure<IISOptions>(iis =>
{
    iis.AuthenticationDisplayName = "Windows";
    iis.AutomaticAuthentication = false;
});

The display name for Windows is always null when using IAuthenticationSchemeProvider.GetAllSchemesAsync.

IIS in-proc or out of proc? They use different options types, you might just be changing the wrong one. IISOptions is for out of proc, but most apps these days use in proc.
In proc:
https://github.com/aspnet/AspNetCore/blob/aaaaf572fdf11088ee0efd205ff6834e16a36804/src/Servers/IIS/IIS/src/IISServerOptions.cs#L31
https://github.com/aspnet/AspNetCore/blob/aaaaf572fdf11088ee0efd205ff6834e16a36804/src/Servers/IIS/IIS/src/Core/IISHttpServer.cs#L80
Out of proc:
https://github.com/aspnet/AspNetCore/blob/3477daf3c4f530dff80f197e0642cb39a26fb07b/src/Servers/IIS/IISIntegration/src/IISOptions.cs#L18
https://github.com/aspnet/AspNetCore/blob/f6c3f9e02ab7c4ae5c395245f2792ba18c33075a/src/Servers/IIS/IISIntegration/src/IISMiddleware.cs#L82

Thanks - that's indeed the problem. Not sure I am happy that this is the solution though ;)


Merge WatirSpec into Watir

We've discussed the difficulties of using a submodule to write tests for PRs.
@Rodney-QAGeek had this issue when doing his first PR, and westlakem mentions it here
@p0deje mentioned he'd like to do this in a way that other projects can still access it if necessary.
Depending on how complicated the solution is, we may also need a tutorial on how to write PRs.

I'm willing to work on this, not sure when I'll start though :)

I also want to make sure that the solution we pursue solves the underlying problem. For instance, Capybara puts a bunch of their specs inside their lib, but these are really difficult to run the way I'm used to (one test at a time). It's kind of an all-or-nothing approach to running their selenium specs. While a submodule is a pain to set up, once it is set up, it's much easier to work with than what I'm seeing of Capybara's solution.

You can add an rspec tag if you want to run a particular Capybara test.

Maybe I just found it difficult getting it to work with Rubymine the last time I tried.

@abotalov - Is there an example somewhere of how to run specific selenium specs in the capybara repo? I couldn't find anything online.

I noticed that answer was already given here - https://github.com/jnicklas/capybara/pull/1744#issuecomment-244249665 :-)

Oh, this is now done 😄


stropts.h : No such file or directory

Hi, I have a problem during installation with "make -j" .
At 78% I have this error " stropts.h : No such file or directory"  with  sim/CMakerFiles/sim.dir/include/moc_JoystickTest.cpp.o
After that , the last message is "waiting for finished jobs ..." and my computer crash.
Computer : MSI gl62mvr 7rfx
Linux : Ubuntu 20.04 ( with acpi=off during installation)

I'm having the same error, what was the solution here?

what was the solution here?
I tried touch /sur/include/stropts.h, and then the problem was disappeared, but there are some problems else.

I don't know exactly what was the problem but it seems to be a problem of compatibility version between Eigen, LCM and QT.
For me , it works with this configuration :
Ubuntu 18.04.4
Eigen 3.3.90
QT 5.12.4
lcm 1.3.1
java 1.6.0
During the installation of each component, be sure that no error appears or try to solve it before install the next component, especially with LCM which installed very badly for me.

Thanks for your reply。
My configuration:
Ubuntu 20.04
Eigen 3.3.7
Qt 5.14.2
lcm 1.4.0
By the way, i've not install java yet.
The problem else is that
In file included from /usr/include/x86_64-linux-gnu/asm/termios.h:1,
from /home/zxliao/Documents/mit-biomimetics_Cheetah-master/robot/src/rt/rt_serial.cpp:15:
/usr/include/asm-generic/termios.h:15:8: error: redefinition of ‘struct winsize’
15 | struct winsize {
|        ^~~~~~~
In file included from /usr/include/x86_64-linux-gnu/sys/ioctl.h:29,
from /home/zxliao/Documents/mit-biomimetics_Cheetah-master/robot/src/rt/rt_serial.cpp:11:
/usr/include/x86_64-linux-gnu/bits/ioctl-types.h:27:8: note: previous definition of ‘struct winsize’
27 | struct winsize
|        ^~~~~~~
In file included from /usr/include/x86_64-linux-gnu/asm/termios.h:1,
from /home/zxliao/Documents/mit-biomimetics_Cheetah-master/robot/src/rt/rt_serial.cpp:15:
/usr/include/asm-generic/termios.h:23:8: error: redefinition of ‘struct termio’
23 | struct termio {
|        ^~~~~~
In file included from /usr/include/x86_64-linux-gnu/sys/ioctl.h:29,
from /home/zxliao/Documents/mit-biomimetics_Cheetah-master/robot/src/rt/rt_serial.cpp:11:
/usr/include/x86_64-linux-gnu/bits/ioctl-types.h:36:8: note: previous definition of ‘struct termio’
36 | struct termio
|        ^~~~~~
I finally solve this problem by this solution https://www.toradex.com/community/questions/7445/custom-baudrate-on-vybrid-soc.html
using #include <asm/ioctls.h> and #include<asm/termbits.h> instead of //#include <asm/termios.h>  in rt_serial.cpp

Same problem in ubuntu 20.04
To me, this problem is caused by the default new version of glibc, from which stropts.h has been removed. I solved this problem by commenting #include <asm/termbits> (line 17) and #include/stropts.h (line 24) in rt_serial.cpp and replacing them with
#include <asm/ioctls.h>
#include <sys/ioctl.h>
#include <asm/termbits.h>

Thanks @LeoSource for suggestion :)

Thanks for @cyoahs , I also fixed the same problem.
I am running my environment as below.

Version
Installation method

Ubuntu
20.04

Kernel
x86_64 Linux 5.4.0-56-generic

Eigen
3.3.7
sudo apt install libeigen3-dev

QT
5.15.2
https://www.qt.io/download-qt-installer (using online installer)

lcm
1.4.0
Source build  from https://github.com/lcm-proj/lcm.git . (checkout to refs/tags/v1.4.0)

Java
1.8.0_275
sudo apt install openjdk-8-jdk

I also modified source code and CMakeLists.txt .
Here is my focal-devel branch forked from this repository.

https://github.com/RyodoTanaka/Cheetah-Software/tree/focal-devel

I also created the docker image which I mentioned above. (The image size is a bit large... be careful ! )

https://hub.docker.com/repository/docker/ryodo/cheetah-software


Crypto widget/service how-to?

Hi,
I'm trying to work out your crypto widget. What exactly do you set as the cryptoCurrency.url? From what I can see, it literally just tries to execute whatever string you set as the cryptoCurrency.url via bash which is confusing. Can you please explain how I can go about using your crypto widget and service? Thanks in advance,

Hello,
It should be your coinmarketcap API url. its like :
cryptoCurrency.url = `curl -H "X-CMC_PRO_API_KEY: {YOUR APIKEY}" -H "Accept: application/json" -d "start=1&limit=500&convert=USD" -G https://pro-api.coinmarketcap.com/v1/cryptocurrency/listings/latest`


trap at runtime for core[7eee]::core_arch::x86::sse::_mm_add_ss: llvm.x86.sse.add.ss

After compiling my bevy-project with the new cranelift backend, using the nightly rustc from 2024-03-01, I get the following crash due to trap when running it:
$ RUSTFLAGS="-Zcodegen-backend=cranelift" rustup run nightly-2024-03-01-x86_64-unknown-linux-gnu cargo run
    Finished `dev` profile [optimized + debuginfo] target(s) in 0.19s
     Running `target/debug/ultra-game`
2024-03-05T23:50:26.379503Z  INFO bevy_winit::system: Creating new window "App" (0v0)
2024-03-05T23:50:26.380222Z  INFO log: Guessed window scale factor: 1
DRM kernel driver 'nvidia-drm' in use. NVK requires nouveau.
2024-03-05T23:50:26.585528Z  INFO bevy_render::renderer: AdapterInfo { name: "NVIDIA GeForce GTX 1060 6GB", vendor: 4318, device: 7171, device_type: DiscreteGpu, driver: "NVIDIA", driver_info: "550.54.14", backend: Vulkan }
trap at Instance { def: Item(DefId(2:13803 ~ core[7eee]::core_arch::x86::sse::_mm_add_ss)), args: [] } (_ZN4core9core_arch3x863sse10_mm_add_ss17h911d741fe58f9e47E): llvm.x86.sse.add.ss

Without RUSTFLAGS="-Zcodegen-backend=cranelift" it runs fine (e.g., the DRM kernel driver ...-message isn't critical).
To reproduce: Run the failing command with this repo & commit: https://github.com/futile/ultra-game/tree/831eeb43b56c1d9dbc9422d130095cd14da8e145

This cranelift backend is a great project, compile time for my project (for a full debug-build) went from ~4min to ~1min when enabling cranelift! Really cool, thanks a lot for your work! :)

The _mm_add_ss intrinsic isn't yet implemented. It is used by the glam linear algebra crate which bevy uses internally. Looks like there are a fair bit of unimplemented intrinsics used by glam. I'm going to work on implementing them.

compile time for my project (for a full debug-build) went from ~4min to ~1min when enabling cranelift!

How much of a difference is it if you remove https://github.com/futile/ultra-game/blob/831eeb43b56c1d9dbc9422d130095cd14da8e145/Cargo.toml#L13-L15? Anything opt-level > 0 is kind of equivalent to opt-level = 1 with LLVM in terms of optimizations. (I haven't actually measured the runtime performance difference, but Cranelift doesn't have a lot of optimizations it supports, so it is far from as fast in terms of runtime perf as opt-level = 3 with LLVM.) If you want dependencies to be fully optimized you did have to build them with LLVM and then build just your own code with cg_clif. For Bevy this currently doesn't work due to an ABI incompatibility though: https://github.com/rust-lang/rustc_codegen_cranelift/issues/1449

Turns out there were only three intrinsics missing.

Turns out there were only three intrinsics missing.

Oh wow, that was super fast, thanks a lot! :) Can I somehow test this/should I just test the next 1-2 nightly rustc versions?

You can download a precompiled version from https://github.com/rust-lang/rustc_codegen_cranelift/releases/tag/dev Unpack it anywhere you like and use the cargo-clif executable inside it in the place of cargo.
It may take a couple of days before I'm able to update the version distributed with rustup.

How much of a difference is it if you remove https://github.com/futile/ultra-game/blob/831eeb43b56c1d9dbc9422d130095cd14da8e145/Cargo.toml#L13-L15? Anything opt-level > 0 is kind of equivalent to opt-level = 1 with LLVM in terms of optimizations. (I haven't actually measured the runtime performance difference, but Cranelift doesn't have a lot of optimizations it supports, so it is far from as fast in terms of runtime perf as opt-level = 3 with LLVM.)

Ah good point! Yeah, running without opt-level > 0 (i.e., commenting out what you mentioned, and also opt-level = 1 for dev) changes the times to 56s with cranelift, and 65s with LLVM, so pretty much equal. Well, still ~10% faster, but much less of a difference than before :sweat:

If you want dependencies to be fully optimized you did have to build them with LLVM and then build just your own code with cg_clif. For Bevy this currently doesn't work due to an ABI incompatibility though: #1449

Cool, thanks for the tip, will keep it in mind & subscribed! :)

Can I somehow test this/should I just test the next 1-2 nightly rustc versions?

The fix will be available on the next nightly.


Multiple Values in QueryParam / Headers Support

Hello,
First of all, thanks for the library, it's very neat :) I've been checking out and testing the library to see if we can use it in our codebase. I found out that it didn't seem to support matching multiple values in query params / header as per the official docs of wiremock:
// There must be 3 values of id exactly whose values are 1, 2, and 3
stubFor(get(urlPathEqualTo("/things"))
    .withQueryParam("id", havingExactly("1", "2", "3"))
    .willReturn(ok()));

{
  "mapping": {
    "request" : {
      "urlPath" : "/things",
      "method" : "GET",
      "queryParameters" : {
        "id" : {
          "hasExactly" : [
            {
              "equalTo": "1"
            },
            {
              "equalTo": "2"
            },
            {
              "equalTo": "3"
            }
          ]
        }
      }
    },
    "response" : {
      "status" : 200
    }
  }
}

// There must be 3 values of id exactly whose values conform to the match expressions
    stubFor(get(urlPathEqualTo("/things"))
    .withQueryParam("id", havingExactly(
    equalTo("1"),
    containing("2"),
    notContaining("3")
    )).willReturn(ok()));

{
  "mapping": {
    "request" : {
      "urlPath" : "/things",
      "method" : "GET",
      "queryParameters" : {
        "id" : {
          "hasExactly" : [
            {
              "equalTo": "1"
            },
            {
              "contains": "2"
            },
            {
              "doesNotContain": "3"
            }
          ]
        }
      }
    },
    "response" : {
      "status" : 200
    }
  }
}

Am I reading it right? If we don't have support for this, are you open for contribution? I can create a PR to add this support and would love to work with you on this.
Thanks in advance :)

Hello!
That's right, there is currently no support for multiple values. I'm currently working on expanding the functionality and will add it soon.
Thanks for the issue and offer of help!

completed in #14


Use iOS asset catalogs

Add iOS asset catalog in the default template and use it. See https://github.com/NativeScript/nativescript-cli/issues/683

+1
I got the following error when I submitted Groceries to the App Store and I had to go into Xcode and add an asset catalog manually to fix it.

Since we can make animated splash screens, I had thought that we wouldn't need to include the usual set of static resized images, but App Uploader won't send your binary to iTunes without all the screens in place. Right now, it seems like I don't have to have an asset catalogue for splash screens, but you still need to have the files in place. Can we figure out a better way to handle these splash screens, like listing everything out in a config file (icons and splash screens), so that we don't have to mess around so much in xCode?


temporarily remove demand

binary hotfix rolled out so the demand is working now, but the capability is missing from the hosted pool :)
temporarily removing the demand and until the capability is in place.


use openaicallback with ChatOpenAI

I'm trying to track openai usage. but this is not working for ChatOpenAI class,
I guess  using OpenAI class(which is subclass of llm) might be a solution,
but bit worried because of the depreciation warning
UserWarning: You are trying to use a chat model. This way of initializing it is no longer supported. Instead, please use: from langchain.chat_models import ChatOpenAI``

One alternative for now is
chat = ChatOpenAI(...)
messages = [...]
result = chat.generate([messages])
result.llm_output # this will contain usage information


regtest: for id'ing a user

After the canonical users patch is applied, you should be able to track t_alice, t_bob or t_charlie.

there's now also t_doug (PGP key only, no sigchain) and t_ellie (no keys at all)

Pushed branch jack_issue195. Right now I'm only looking at the success of the operation, and I should probably look a little more deeply to confirm which proofs get validated. @maxtaco I'll ask you about that tomorrow.

Yeah, this is a good start.  You probably want to have a pointer method to your FakeUI so you can collect data as a result of the callbacks.


Replace modals with shared component kern-modal

Is your feature request related to a problem? Please describe.
Some of the modals have different style, width and other differences. They should be consistent over the application and should be replaced with shared component that has a standard template where the content of the modal is changed.
Describe the solution you'd like
We have a shared component kern-modal, and all modals should be replaced with this shared component.

Steps to implement:

Find all occurrences of modals in the application (N modals).
Estimated the refactor of one modal (X minutes).
Testing all modals (2h)
Review (2h)

Estimation time: N modals * X minutes + 4h


Docs Changes Needed from dbt-core PR #8527

At a minimum, update body to include a link to the page on docs.getdbt.com requiring updates and what part(s) of the page you would like to see updated.

duplicate of https://github.com/dbt-labs/docs.getdbt.com/issues/4014


combine view protocol document with main docs

This commit also tweaks the language a bit:

Use "ARGB" instead of "RGBA", which is more accurate.
Mention the specific notifications that are used by the protocol.
Use the correct name for the def_style notification.
Clarify the use of the scroll_to notification.

Thanks for this, pardon the delay!


Style tag added to DOM on every mount

I am seeing an issue where the following style-element is being added to the DOM on each mount when using  AdvancedRealTimeChart
<style>.tradingview-widget-copyright {font-size: 13px !important; line-height: 32px !important; text-align: center !important; vertical-align: middle !important; font-family: -apple-system, BlinkMacSystemFont, 'Trebuchet MS', Roboto, Ubuntu, sans-serif !important; color: #9db2bd !important;} .tradingview-widget-copyright .blue-text {color: #2962FF !important;} .tradingview-widget-copyright a {text-decoration: none !important; color: #9db2bd !important;} .tradingview-widget-copyright a:visited {color: #9db2bd !important;} .tradingview-widget-copyright a:hover .blue-text {color: #1E53E5 !important;} .tradingview-widget-copyright a:active .blue-text {color: #1848CC !important;} .tradingview-widget-copyright a:visited .blue-text {color: #2962FF !important;}</style>

Also happens on https://www.tradingview.com/widget/advanced-chart/, so I guess TradingView changed its behaviour


[FancyZones] Split zones-settings: custom layouts

Summary of the Pull Request
What is this about:

Keep custom layouts in a separate file.
Create custom-layouts.json from zones-settings on FZ start
Save custom layouts in the custom-layout.json in Editor.
Unit tests

What is included in the PR:
How does someone test / validate:

Run PT, verify custom-layouts.json created
Run tests
Open editor, create or edit the custom layout, verify it was saved properly.

Quality Checklist

[x] Linked issue: #14782
[ ] Communication: I've discussed this with core contributors in the issue.
[x] Tests: Added/updated and all pass
[ ] Installer: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Docs: Added/ updated
[ ] Binaries: Any new files are added to WXS / YML

[ ] No new binaries
[ ] YML for signing for new binaries
[ ] WXS for installer for new binaries

Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.

what is the background for the issue + fix?

what is the background for the issue + fix?

Users lose data on driver updates or windows crashes. It happens because FZ tries to rewrite zone-settings right before crash/restart. So I split zone-settings into different files and FZ wouldn't have even the possibility to rewrite them. From now, they can be changed from the Editor only.


vue ui Error: spawn /usr/bin/chromium ENOENT

Version
4.5.7
Reproduction link
https://codesandbox.io/s/relaxed-merkle-2xwdp
Environment info
  System:
    OS: Linux 5.8 Arch Linux
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
  Binaries:
    Node: 14.12.0 - /usr/bin/node
    Yarn: 1.22.4 - /usr/bin/yarn
    npm: 6.14.7 - /usr/bin/npm
  Browsers:
    Chrome: Not Found
    Firefox: 81.0
  npmPackages:
    @vue/cli-overlay:  4.5.7
    @vue/cli-plugin-eslint: ~4.5.0 => 4.5.7
    @vue/cli-plugin-router: ~4.5.0 => 4.5.7
    @vue/cli-plugin-vuex:  4.5.7
    @vue/cli-service: ~4.5.0 => 4.5.7
    @vue/cli-shared-utils:  4.5.7
    @vue/compiler-core:  3.0.1
    @vue/compiler-dom:  3.0.1
    @vue/compiler-sfc: ^3.0.0 => 3.0.1
    @vue/compiler-ssr:  3.0.1
    @vue/component-compiler-utils:  3.2.0
    @vue/eslint-config-prettier: ^6.0.0 => 6.0.0
    @vue/preload-webpack-plugin:  1.1.2
    @vue/reactivity:  3.0.1
    @vue/runtime-core:  3.0.1
    @vue/runtime-dom:  3.0.1
    @vue/shared:  3.0.1
    @vue/web-component-wrapper:  1.2.0
    eslint-plugin-vue: ^7.0.0-0 => 7.0.1
    vue: ^3.0.0 => 3.0.1
    vue-eslint-parser:  7.1.1
    vue-hot-reload-api:  2.3.4
    vue-loader:  15.9.3 (16.0.0-beta.8)
    vue-router: ^4.0.0-0 => 4.0.0-beta.13
    vue-style-loader:  4.1.2
    vue-template-es2015-compiler:  1.9.1
  npmGlobalPackages:
    @vue/cli: Not Found

Steps to reproduce

Open the codesandbox reproduction
Export it as ZIP so you can run vue ui on your terminal
yarn install
run vue ui

What is expected?
It should work as described in the docs.
What is actually happening?
Gives
vue ui
🚀  Starting GUI...
🌠  Ready on http://localhost:8000
events.js:291
      throw er; // Unhandled 'error' event
      ^

Error: spawn /usr/bin/chromium ENOENT
    at Process.ChildProcess._handle.onexit (internal/child_process.js:268:19)
    at onErrorNT (internal/child_process.js:464:16)
    at processTicksAndRejections (internal/process/task_queues.js:80:21)
Emitted 'error' event on ChildProcess instance at:
    at Process.ChildProcess._handle.onexit (internal/child_process.js:274:12)
    at onErrorNT (internal/child_process.js:464:16)
    at processTicksAndRejections (internal/process/task_queues.js:80:21) {
  errno: -2,
  code: 'ENOENT',
  syscall: 'spawn /usr/bin/chromium',
  path: '/usr/bin/chromium',
  spawnargs: [ 'http://localhost:8000' ]
}

This is just a fresh project created via vue-cli.

It seems  vue ui failed to open chrome, and it doesn't catch the error. Maybe relate to https://github.com/sindresorhus/open/issues/144

Just to be clear, I do have Google Chrome but not Chromium.
Is vue ui hardcoded to open up chromium or is it from its dependencies? I tried looking for it but wasn't able to find anything related to what handles the command.

Could you test this shell script ? vue ui open URL with default  browser by this package.

export BROWSER=/usr/bin/%YOUR_WEB_BROWSER%


The cursor is not placed on the search box when I open PT Run.

Environment
Windows build number: [19041.330]
PowerToys version: v0.19.1
PowerToy module for which you are reporting the bug (if applicable): PowerToys Run

Steps to reproduce
The cursor is not placed on the search box if there is some text.
For example, after using PT Run once, the search box will be filled of the text that was entered last time if you open it again.
Meanwhile the cursor will not be placed on the search box.
Expected behavior
The cursor would be placed on the search box automatically whenever it opened.

hi @PoonKinWang, this is a duplicate issue (given this has more conversation). Thanks for the submissions, working on fixing this here: #4897
closing as duplicate


:construction: migrate multiple board

Codecov Report

Merging #147 (6dff5c6) into master (00f6df8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #147   +/-   ##
=======================================
  Coverage   51.85%   51.85%
=======================================
  Files          19       19
  Lines         513      513
=======================================
  Hits          266      266
  Misses        218      218
  Partials       29       29

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00f6df8...6dff5c6. Read the comment docs.


[SPARK-9026] Refactor SimpleFutureAction.onComplete to not launch separate thread for every callback

This commit refactors SimpleFutureAction so that registering a callback with onComplete does not immediately tie up a thread in the provided execution context.
As @zsxwing noticed in https://github.com/apache/spark/pull/7276#issuecomment-121097747, the existing implementation of SimpleFutureAction.onComplete creates a separate thread to wrap the blocking awaitResult() callback:
  override def onComplete[U](func: (Try[T]) => U)(implicit executor: ExecutionContext) {
    executor.execute(new Runnable {
      override def run() {
        func(awaitResult())
      }
    })
  }

This PR addresses this issue by making JobWaiter into a Future using that future in the implementation of SimpleFutureAction's future methods.
This patch was pair-programmed with @tdas.

@zsxwing, TD and I think that this patch's fix may eliminate the need to introduce a new submitAsyncJob API.  I'm going to push another commit in a few minutes to add some code comments plus more tests, but I just wanted to submit this PR now to get your initial feedback on the approach.

Merged build triggered.

Merged build started.

Test build #37179 has started for   PR 7385 at commit 11c7450.

Merged build triggered.

Merged build started.

Test build #37184 has started for   PR 7385 at commit 7b25e6b.

@tdas, PTAL @ the regression test that I added.

Merged build triggered.

Merged build started.

Test build #37188 has started for   PR 7385 at commit d779af8.

Test build #37179 has finished for   PR 7385 at commit 11c7450.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test build #37184 has finished for   PR 7385 at commit 7b25e6b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Ah, interesting: it looks like this failed some of the JavaAsyncRDDActions tests. I'll investigate.

Test build #37188 has finished for   PR 7385 at commit d779af8.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Least(children: Expression*) extends Expression
case class Greatest(children: Expression*) extends Expression

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #37200 has started for   PR 7385 at commit 1e2db7f.

@JoshRosen thank you for fixing this. Actually, I have another requirement for submitJob. Current submitJob signature is
  def submitJob[T, U, R](
      rdd: RDD[T],
      processPartition: Iterator[T] => U,
      partitions: Seq[Int],
      resultHandler: (Int, U) => Unit,
      resultFunc: => R): SimpleFutureAction[R]

I cannot access TaskContext in this method. Could you change processPartition: Iterator[T] => U to processPartition: (TaskContext, Iterator[T]) => U, or add a new method for it?

@zsxwing will TaskContext.get() work for you?  AFAIK we're trying to avoid the introduction of new withContext methods when TaskContext.get() will suffice (see some of the old discussions regarding mapPartitionsWithContext, etc.).

@zsxwing will TaskContext.get() work for you? AFAIK we're trying to avoid the introduction of new withContext methods when TaskContext.get() will suffice (see some of the old discussions regarding mapPartitionsWithContext, etc.).

Forgot it. It should work. Thanks.

Test build #37200 has finished for   PR 7385 at commit 1e2db7f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #37245 has started for   PR 7385 at commit 1346313.

@zsxwing I've updated this to use a lazy val; please take another look.

Test build #37245 has finished for   PR 7385 at commit 1346313.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #37319 has started for   PR 7385 at commit e08623a.

I just pushed a commit which changes JobWaiter to extend Future[Unit], which I think should resolve the most recent round of review feedback.

Test build #37319 has finished for   PR 7385 at commit e08623a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

LGTM except the minor comments.

Merged build triggered.

Merged build started.

Test build #37370 has started for   PR 7385 at commit b504384.

LGTM

Test build #37370 has finished for   PR 7385 at commit b504384.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

@tdas, I'll leave this open if you want to take a final look.  Feel free to merge in order to unblock @zsxwing's other patch.

@rxin quick look please.

Ping @rxin, @tdas said that you should probably take a look at this, since you may be able to comment on why JobWaiter wasn't a Future to begin with.

Merged build triggered.

Merged build started.

Test build #37442 has started for   PR 7385 at commit c6fdc21.

Test build #37442 timed out     for PR 7385 at commit c6fdc21     after a configured wait of 175m.

Merged build finished. Test FAILed.

Jenkins, retest this please.

Merged build triggered.

Merged build started.

Test build #37505 has started for   PR 7385 at commit c6fdc21.

Test build #37505 timed out     for PR 7385 at commit c6fdc21     after a configured wait of 175m.

Merged build finished. Test FAILed.

Uh oh, looks like there's a problem.  I'll investigate this afternoon.

Seems unrelated random hang. Trying to run this again.

Jenkins, test this please.

Merged build triggered.

Merged build started.

Test build #37537 has started for   PR 7385 at commit c6fdc21.

Test build #37537 timed out     for PR 7385 at commit c6fdc21     after a configured wait of 175m.

Merged build finished. Test FAILed.

Okay this seems like  recurring problem. @JoshRosen mind taking a look soon.

Sure, but I'm kinda swamped with some other stuff now so it might take a day before I get to this.

Ah, interesting: it looks a race condition in the existing JobWaiter has led to flakiness in a unit test.  Here's the Jenkins failure: https://amplab.cs.berkeley.edu/jenkins/job/Spark-Master-SBT/lastCompletedBuild/AMPLAB_JENKINS_BUILD_PROFILE=hadoop1.0,label=centos/testReport/org.apache.spark.scheduler/DAGSchedulerSuite/misbehaved_resultHandler_should_not_crash_DAGScheduler_and_SparkContext/

java.lang.UnsupportedOperationException: taskSucceeded() called on a finished JobWaiter was not instance of org.apache.spark.scheduler.DAGSchedulerSuiteDummyException

It looks like the hanging test is DAGSchedulerSuite's "misbehaved resultHandler should not crash DAGScheduler and SparkContext" test.  Here's the relevant part of the unit tests log:
15/07/17 09:05:49.333 pool-1-thread-1-ScalaTest-running-DAGSchedulerSuite INFO SparkContext: Starting job: runJob at DAGSchedulerSuite.scala:762
15/07/17 09:05:49.346 dag-scheduler-event-loop INFO DAGScheduler: Got job 0 (runJob at DAGSchedulerSuite.scala:762) with 1 output partitions (allowLocal=true)
15/07/17 09:05:49.346 dag-scheduler-event-loop INFO DAGScheduler: Final stage: ResultStage 0(runJob at DAGSchedulerSuite.scala:762)
15/07/17 09:05:49.347 dag-scheduler-event-loop INFO DAGScheduler: Parents of final stage: List()
15/07/17 09:05:49.347 dag-scheduler-event-loop INFO DAGScheduler: Missing parents: List()
15/07/17 09:05:49.348 dag-scheduler-event-loop INFO DAGScheduler: Computing the requested partition locally
15/07/17 09:05:49.353 pool-1-thread-1-ScalaTest-running-DAGSchedulerSuite INFO DAGScheduler: Job 0 failed: runJob at DAGSchedulerSuite.scala:762, took 0.019835 s
15/07/17 09:05:49.362 pool-1-thread-1-ScalaTest-running-DAGSchedulerSuite INFO SparkContext: Starting job: runJob at DAGSchedulerSuite.scala:773
15/07/17 09:05:49.363 dag-scheduler-event-loop INFO DAGScheduler: Got job 1 (runJob at DAGSchedulerSuite.scala:773) with 2 output partitions (allowLocal=false)
15/07/17 09:05:49.363 dag-scheduler-event-loop INFO DAGScheduler: Final stage: ResultStage 1(runJob at DAGSchedulerSuite.scala:773)
15/07/17 09:05:49.363 dag-scheduler-event-loop INFO DAGScheduler: Parents of final stage: List()
15/07/17 09:05:49.363 dag-scheduler-event-loop INFO DAGScheduler: Missing parents: List()
15/07/17 09:05:49.366 dag-scheduler-event-loop INFO DAGScheduler: Submitting ResultStage 1 (ParallelCollectionRDD[1] at parallelize at DAGSchedulerSuite.scala:772), which has no missing parents
15/07/17 09:05:49.452 dag-scheduler-event-loop INFO MemoryStore: ensureFreeSpace(1048) called with curMem=0, maxMem=1691332116
15/07/17 09:05:49.453 dag-scheduler-event-loop INFO MemoryStore: Block broadcast_0 stored as values in memory (estimated size 1048.0 B, free 1613.0 MB)
15/07/17 09:05:49.459 dag-scheduler-event-loop INFO MemoryStore: ensureFreeSpace(769) called with curMem=1048, maxMem=1691332116
15/07/17 09:05:49.459 dag-scheduler-event-loop INFO MemoryStore: Block broadcast_0_piece0 stored as bytes in memory (estimated size 769.0 B, free 1613.0 MB)
15/07/17 09:05:49.461 sparkDriver-akka.actor.default-dispatcher-3 INFO BlockManagerInfo: Added broadcast_0_piece0 in memory on localhost:61512 (size: 769.0 B, free: 1613.0 MB)
15/07/17 09:05:49.463 dag-scheduler-event-loop INFO SparkContext: Created broadcast 0 from broadcast at DAGScheduler.scala:901
15/07/17 09:05:49.465 dag-scheduler-event-loop INFO DAGScheduler: Submitting 2 missing tasks from ResultStage 1 (ParallelCollectionRDD[1] at parallelize at DAGSchedulerSuite.scala:772)
15/07/17 09:05:49.466 dag-scheduler-event-loop INFO TaskSchedulerImpl: Adding task set 1.0 with 2 tasks
15/07/17 09:05:49.488 sparkDriver-akka.actor.default-dispatcher-3 INFO TaskSetManager: Starting task 0.0 in stage 1.0 (TID 0, localhost, PROCESS_LOCAL, 1369 bytes)
15/07/17 09:05:49.491 Executor task launch worker-0 INFO Executor: Running task 0.0 in stage 1.0 (TID 0)
15/07/17 09:05:49.504 Executor task launch worker-0 INFO Executor: Finished task 0.0 in stage 1.0 (TID 0). 810 bytes result sent to driver
15/07/17 09:05:49.506 sparkDriver-akka.actor.default-dispatcher-3 INFO TaskSetManager: Starting task 1.0 in stage 1.0 (TID 1, localhost, PROCESS_LOCAL, 1426 bytes)
15/07/17 09:05:49.506 Executor task launch worker-0 INFO Executor: Running task 1.0 in stage 1.0 (TID 1)
15/07/17 09:05:49.507 task-result-getter-0 INFO TaskSetManager: Finished task 0.0 in stage 1.0 (TID 0) in 30 ms on localhost (1/2)
15/07/17 09:05:49.508 pool-1-thread-1-ScalaTest-running-DAGSchedulerSuite INFO DAGScheduler: Job 1 failed: runJob at DAGSchedulerSuite.scala:773, took 0.145836 s
15/07/17 09:05:49.509 Executor task launch worker-0 INFO Executor: Finished task 1.0 in stage 1.0 (TID 1). 810 bytes result sent to driver
15/07/17 09:05:49.511 task-result-getter-1 INFO TaskSetManager: Finished task 1.0 in stage 1.0 (TID 1) in 6 ms on localhost (2/2)
15/07/17 09:05:49.512 dag-scheduler-event-loop INFO DAGScheduler: ResultStage 1 (runJob at DAGSchedulerSuite.scala:773) finished in 0.041 s
15/07/17 09:05:49.512 task-result-getter-1 INFO TaskSchedulerImpl: Removed TaskSet 1.0, whose tasks have all completed, from pool
15/07/17 09:05:49.516 dag-scheduler-event-loop ERROR DAGSchedulerEventProcessLoop: DAGSchedulerEventProcessLoop failed; shutting down SparkContext
java.lang.IllegalStateException: Promise already completed.
	at scala.concurrent.Promise$class.complete(Promise.scala:55)
	at scala.concurrent.impl.Promise$DefaultPromise.complete(Promise.scala:153)
	at scala.concurrent.Promise$class.failure(Promise.scala:107)
	at scala.concurrent.impl.Promise$DefaultPromise.failure(Promise.scala:153)
	at org.apache.spark.scheduler.JobWaiter.jobFailed(JobWaiter.scala:86)
	at org.apache.spark.scheduler.DAGScheduler.handleTaskCompletion(DAGScheduler.scala:1059)
	at org.apache.spark.scheduler.DAGSchedulerEventProcessLoop.doOnReceive(DAGScheduler.scala:1508)
	at org.apache.spark.scheduler.DAGSchedulerEventProcessLoop.onReceive(DAGScheduler.scala:1472)
	at org.apache.spark.scheduler.DAGSchedulerEventProcessLoop.onReceive(DAGScheduler.scala:1461)
	at org.apache.spark.util.EventLoop$$anon$1.run(EventLoop.scala:48)
15/07/17 09:05:49.516 pool-1-thread-1-ScalaTest-running-DAGSchedulerSuite INFO SparkContext: Starting job: count at DAGSchedulerSuite.scala:783
15/07/17 09:05:49.519 dag-scheduler-event-loop INFO DAGScheduler: Stopping DAGScheduler
15/07/17 09:08:48.579 sparkDriver-akka.actor.default-dispatcher-4 WARN HeartbeatReceiver: Removing executor driver with no recent heartbeats: 179561 ms exceeds timeout 120000 ms
15/07/17 09:08:48.580 sparkDriver-akka.actor.default-dispatcher-4 ERROR TaskSchedulerImpl: Lost executor driver on localhost: Executor heartbeat timed out after 179561 ms

It looks like the problem is that jobFailed can be called multiple times if a task that runs in DAGScheduler.runLocallyWithinThread fails.  We get one call from runLocallyWithinThread and another call inside of DAGScheduler.handleTaskCompletion.
I guess this is actually a subtlety that was overlooked in the old code.  I guess one approach is to make jobFailed into an idempotent method.  Let me try that now...

Merged build triggered.

Merged build started.

Test build #37647 has started for   PR 7385 at commit 1a19268.

Test build #37647 has finished for   PR 7385 at commit 1a19268.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
abstract class UnsafeProjection extends Projection
case class FromUnsafeProjection(fields: Seq[DataType]) extends Projection
abstract class BaseProjection extends Projection
    class SpecificProjection extends $
    class SpecificProjection extends $

Merged build finished. Test FAILed.

Jenkins, retest this please.

This latest failure seems to be due to a DistributedSuite test that may have recently become flaky.

Merged build triggered.

Merged build started.

Test build #37654 has started for   PR 7385 at commit 1a19268.

Test build #37654 has finished for   PR 7385 at commit 1a19268.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
abstract class UnsafeProjection extends Projection
case class FromUnsafeProjection(fields: Seq[DataType]) extends Projection
abstract class BaseProjection extends Projection
    class SpecificProjection extends $
    class SpecificProjection extends $

Merged build finished. Test PASSed.

Jenkins, test this please.

Merged build triggered.

Merged build started.

Test build #37673 has started for   PR 7385 at commit 1a19268.

Test build #37673 has finished for   PR 7385 at commit 1a19268.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Jenkins, retest this please.

Merged build triggered.

Merged build started.

Test build #37677 has started for   PR 7385 at commit 1a19268.

Test build #37677 has finished for   PR 7385 at commit 1a19268.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Jenkins, retest this please.

Merged build triggered.

Merged build started.

Test build #37706 has started for   PR 7385 at commit 1a19268.

Test build #37706 has finished for   PR 7385 at commit 1a19268.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Jenkins, retest this please.

Merged build triggered.

Merged build started.

Test build #37745 has started for   PR 7385 at commit 1a19268.

Test build #37745 has finished for   PR 7385 at commit 1a19268.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

retest this please

@tdas could you take a look at this PR again? I think it's better to merge this one at first.

Merged build triggered.

Merged build started.

Test build #61 has started for   PR 7385 at commit 1a19268.

Test build #61 has finished for   PR 7385 at commit 1a19268.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #38083 has started for   PR 7385 at commit 1a19268.

Test build #38083 has finished for   PR 7385 at commit 1a19268.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test build #1162 has started for   PR 7385 at commit 1a19268.

Test build #1162 has finished for   PR 7385 at commit 1a19268.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

;Jenkins, retest this please

Jenkins, retest this please.

Merged build triggered.

Merged build started.

Test build #38119 has started for   PR 7385 at commit 1a19268.

Test build #38119 has finished for   PR 7385 at commit 1a19268.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #38258 has started for   PR 7385 at commit 692b3a4.

Test build #38258 has finished for   PR 7385 at commit 692b3a4.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #38280 has started for   PR 7385 at commit 17edbcd.

Test build #38280 has finished for   PR 7385 at commit 17edbcd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test build #1191 has started for   PR 7385 at commit 17edbcd.

Test build #1192 has started for   PR 7385 at commit 17edbcd.

Test build #1191 has finished for   PR 7385 at commit 17edbcd.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #1192 has finished for   PR 7385 at commit 17edbcd.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Jenkins, retest this please.

Merged build triggered.

Merged build started.

Test build #38573 has started for   PR 7385 at commit 17edbcd.

Test build #38573 has finished for   PR 7385 at commit 17edbcd.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test build #2093 has started for PR 7385 at commit 17edbcd.

Test build #2093 has finished for PR 7385 at commit 17edbcd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

@JoshRosen could you close this one, since  #9264 fixes the issue as well? Thanks!

@zsxwing @JoshRosen Does the comment need attention since the pr is closed,  https://github.com/apache/spark/blob/master/streaming/src/main/scala/org/apache/spark/streaming/scheduler/ReceiverTracker.scala#L438?

That's a good find.
cc @zsxwing

Thanks @jaceklaskowski I will submit a PR to remove submitJobThreadPool


Removed hardcoded categories for Samakal

@aniruddha-adhikary

Thank you @bdcodefreak for being awesome, merged!


put column with an input group does not display content side by side

The following code should cause a message to be displayed by the side of a form. But instead it displays it on the following page. Using Chrome on a Mac.
`
from pywebio.input import input, input_group, PASSWORD
from pywebio.output import put_row, put_column, put_text, put_image
def main():
# Side content
content = put_text(
"Please fill out the form to register. Blah blah.")
# Layout using put_row to position elements side by side
put_row([
    put_column([content]),  # Side content in a column
    put_column([input_group("Registration Form", [
        input("Full Name", name='fullname'),
        input("Email", name='email'),
        input("Password", type=PASSWORD, name='password'),
        input("Confirm Password", type=PASSWORD, name='confirm_password'),
    ])])  # Form in a column
], size='50% 50%')  # Adjust the relative width of each column

main()
`

The content of put_column() should be output widget. All put_xxx() functions from pywebio.ouput module and pin_xxx()  functions from pywebio.pin module will return a output widget.
The input functions from pywebio.input module are blocking functions and return the user's input. So you can't add input functions to  put_column.
In your case, you can consider to use the pin module.


Real world example (phonecat) of Webpack, Angular and features

Hi. I think it would be a great asset for new comers if you could show an example of how to use webpack to build an angular app. You could do the phonecat app and maybe also include external libraries from public cdn (angular, bootstrap, jguery). I think that would really help and it would make things really clear since people use the phonecat example to learn angular ... that is a "real world" example for a lot of new comers. I for one would really appreciate it.

Hi, @mlmarius
You can start with https://github.com/packetloop/angular-webpack
That is kind of build-core of our real-world app.

Here is another: https://github.com/escapedcat/angular-phonecat-webpack-gulp
Closing as this appears to no longer be an issue. Thanks!


Add tests

It's downright embarrassing not to have any. This tool has grown enough (in codebase size and popularity) that it deserves tests.
Probably we can use a combination of pouchdb-server and pouchdb-load to avoid having to replicate all of npm just to run the tests. Running the tests on a subset should be fine.

Fixed by https://github.com/nolanlawson/local-npm/pull/59


Add inputId prop

In order to have multiple times this component on the same page and with the same name, i have created an inputId prop to make every component unique.

Looks good to me! thanks for the contrib


clientHold / serverHold

This checker is fire.  Thank you.
Domains in clientHold or serverHold are typically ones that earned it in a bad way, which should be considered for removal from PSL.
Is it possible to also make a csv that outputs the domains where you can find Hold in the whois response?
It can be done with the current data set.

Thank you for the feedback! I will implement a hold filter soon, which will dump data/hold.csv with domains that are possibly put on clientHold/serverHold.

Added filter to find domains with any type of hold status and exported the results to hold.csv

Updated dataset


Add meltano schema <extractor> to view and manage schema rules

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/2229
Originally created by @DouweM on 2020-08-11 21:41:43

This would make it easier to use the extractor's schema extra and view the currently configured rules and their effect on the catalog.
Currently, you'd need to use meltano config --extras <plugin> to view the value of the _schema setting, and hope it has the desired effect.

View 3 previous comments from the original issue on GitLab

Still relevant

Still relavant


kbfsgit: send LFS progress messages on uploads/downloads

LFS allows us to send progress messages during uploads or downloads, by sending a JSON message containing the OID of the operation, plus the number of bytes processed so far.
For downloads, this is pretty easy, as we can just re-use the strategy of wrapping the io.Writer to send progress messages, just like we do for normal git.
It's a bit trickier with uploads, because uploads have two stages -- one copying it into the journal, and one flushing it from the journal. LFS only lets us have one progress-reporting stage, so we choose the journal flush since it's usually the slower of the two.  Unfortunately this means a bit of a lag in reporting since we wait until the copy finishes before reporting the journal status, but that's good enough for now I think.
The size of the file in the journal doesn't match the plaintext size, so we need to scale the upload progress messages to reflect the plaintext size reported by the LFS CLI.
Issue: HOTPOT-1275

Haven't looked at the code yet, but what do you think of sending the first 40% of the progress while copying it into the journal and the last 60% while flushing the journal? more code but no time that the user is just waiting for nothing to apparently happen.

@jakob223 thanks for the suggestion.  Yep, that would be possible if we are willing to be a bit sneaky.  Shouldn't be too hard.

Do you want to do that as a separate ticket/PR or add onto this? (i.e. should I review this PR now?)

Probably separate PR and ticket makes more sense.  But this isn't the first PR in the series -- you should probably start with #20869.


Top level domains are blocked

Describe the bug
There are top level domains which are blocked, eg: lifehacker.com
To Reproduce
Steps to reproduce the behavior:

Go to lifehacker.com
See error
Expected behavior
The filter should only block the harmful part (second level domain) of the site. eg. ad.lifehacker.com or stat.lifehacker.com ..
*Additional context
Add any other context about the problem here.
zaloapp.com
tmall.com
1688.com
taobao.com
facebook.com
embedly.com
goo.gl
smarthomebeginner.com
atom.io
whatsapp.com
riotgames.com
amazon.com
chotot.com

Please red the README for this repo. This should be expected.


'uploader' information is null in YouTube playlist extractor

Checklist

[x] I've verified that I'm running youtube-dlc version 2020.11.11
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log

Description

Hi, the uploader information is all null in the YouTube playlist extractor. More specifically, the 'uploader', 'uploader_url', and 'uploader_id'. Here's the response: https://ibb.co/hMz7HWG
This is the command that I'm using: youtube-dlc -v -4 -q --no-warnings -J --flat-playlist https://www.youtube.com/playlist?list=UU_aEa8K-EOJ3D6gOs7HcyNg
It used to include the uploader information before, but now it doesn't.

I don't know if this is in any way related, but as of today (Nov 11 2020) the latest youtube-dl (not youtube-dlc) doesn't even download playlists anymore (it sees 0 videos):
$ youtube-dl https://m.youtube.com/playlist?list=PL7yh-TELLS1HSmBcqYk9LhPYSWp31FWH2
[youtube:playlist] PL7yh-TELLS1HSmBcqYk9LhPYSWp31FWH2: Downloading webpage
[download] Downloading playlist: PL7yh-TELLS1HSmBcqYk9LhPYSWp31FWH2
[youtube:playlist] playlist PL7yh-TELLS1HSmBcqYk9LhPYSWp31FWH2: Downloading 0 videos
[download] Finished downloading playlist: PL7yh-TELLS1HSmBcqYk9LhPYSWp31FWH2

So I think Youtube may have changed the way they embed the requisite info in playlists.

Also encounter this bug myself. Playlist title is set to NA all the time.

Having the same issue here, I'm trying to download videos in a folder that's the name of the uploader of the video, but instead of the channel name it just names the folder to "NA".
Here's my download script:
`youtube-dlc --sleep-interval 15 --download-archive "archive.log" -i --add-metadata --all-subs --embed-subs --embed-thumbnail --match-filter "playlist_title != 'Liked videos' & playlist_title != 'Favorites'" -f "(bestvideo[vcodec^=av01][height>=1080][fps>30]/bestvideo[vcodec=vp9.2][height>=1080][fps>30]/bestvideo[vcodec=vp9][height>=1080][fps>30]/bestvideo[vcodec^=av01][height>=1080]/bestvideo[vcodec=vp9.2][height>=1080]/bestvideo[vcodec=vp9][height>=1080]/bestvideo[height>=1080]/bestvideo[vcodec^=av01][height>=720][fps>30]/bestvideo[vcodec=vp9.2][height>=720][fps>30]/bestvideo[vcodec=vp9][height>=720][fps>30]/bestvideo[vcodec^=av01][height>=720]/bestvideo[vcodec=vp9.2][height>=720]/bestvideo[vcodec=vp9][height>=720]/bestvideo[height>=720]/bestvideo)+(bestaudio[acodec=opus]/bestaudio)/best" --merge-output-format mkv -o "$PWD/%(playlist_uploader)s/%(title)s - %(id)s.%(ext)s" "https://www.youtube.com/c/UnusAnnus/videos"
Here are my verbose logs.

Also, the folder where the playlist is downloaded is not named properly. It names it with the same name as the actual URL.
So in this case the folder name is this:   PLDV1Zeh2NRsDGO4--qE8yH72HFL1Km93P
youtube-dlc -f 22/bestvideo+(140/bestaudio)/best -o "d:\YT Downloads%%(uploader)s%%(playlist_title)s%%(playlist_index)s - %%(title)s.%%(ext)s" https://www.youtube.com/playlist?list=PLDV1Zeh2NRsDGO4--qE8yH72HFL1Km93P

Can confirm I am having an issue with this too. It seems like the regex for extracting the playlist title, uploader, etc is no longer valid. It probably needs to be updated to use the json data.
https://github.com/blackjack4494/yt-dlc/blob/d052b9a112fb7ae749a829dceba6e3289663a303/youtube_dlc/extractor/youtube.py#L2971-L2986

any  progress in this issue ?

I can see that #150 seems to have code in place that fixes this, but not sure myself what is happening with this.  For reference #151 was the one that got merged without this. Maybe we can merge the portion of the code in #150 that fixes this issue?

Same Problem here when building from source (master-branch, d052b9a)
%(playlist_title)s gets evaluated as NA in the output template.
I'd also suggest looking at #150 using their solution to fix this problem.

this should be fixed now - #245


Cherry pick lazy expiration of DetectTable

What have you changed? (mandatory)
Cherry pick  https://github.com/tikv/tikv/pull/5108, https://github.com/tikv/tikv/pull/5156, https://github.com/tikv/tikv/pull/5157, https://github.com/tikv/tikv/pull/5162.

/run-integration-compatibility-test

/run-integration-ddl-test

/rebuild

/run-integration-compatibility-test

/test

/test

/rebuild

/run-integration-compatibility-test

/run-integration-ddl-test

/test

/test

/test

/test


Upgrade libs versions. Opentelemetry 1.22.0

@graemerocher @n0tl3ss Hi! Don't think that we need to wait micronaut 4.0.0 release to actualize libraries versions. But need help to fix failed tests:
io.micronaut.tracing.jaeger.HttpTracingSpec#test basic response reactive HTTP tracing and  io.micronaut.tracing.jaeger.HttpTracingExclusionSpec.#test basic response reactive HTTP tracing

@altro3 There are already updates on 4.6.x branch

@n0tl3ss oh, great! Sorry, didn't see


Figure out Hard Bounce Issue between Keystone and Mail Chimp

@jeremysMARE researched issue with tagging manual subscribers in mailchimp and identified that he is unable to subscribe some social workers b/c they previously had a hard bounce from their known email and thus were cleaned by mailchimp.  The only way to resolve this is to have the user fill out a form to resubscribe to each list, which is a big challenge for us.
We need noah to explore the following:
1.) Did deeper into the why these email addresses are having a hard bounce.
2.) If we were to get users to resubscribe, what would prevent this from continuing to happen?
3.) If a user gets wiped clean in mail chimp, is it circling back and deleting their subscription preferences in Keystone?
4.) Potentially figure out how to get around DCF's spam filters if this is indeed the reason why some emails are getting hard bounce
5.) explore options for sending emails in batchs as possible solution to avoid hard bounce in the future

Hold on global resolution.
@n-devr will investigate the process by which keystone email changes are reflected at MailChimp. Provide a resolution that includes IDing changes at Keystone to reflect the change on the MailChimp list.

MailChimp - Keystone Comparison.xlsx
I'm attaching an excel sheet that shows the disparity between MailChimp's list of subscribed social workers and Keystone's list of subscribed social workers.

Based on our discussion/investigation yesterday there are two tasks on my plate:

[ ] Update email address in Mailchimp if a user updates their email in Keystone
[ ] Run a script to update the subscription preferences of the social workers in Jeremy's list

@joesmare @bchiaruttini  please let me know if there's anything else you'd like me to tackle as part of this story!

Yes @n-devr those are the actions required. I'm ruling out other external factors at this point. If there are any future issues I'll open a new story should we need to look at other related issues?
Thank you for all of your insight and input. I appreciate it. Glad you are on the team.

Sounds good @joesmare , thank you!  Happy help and happy to be part of the team 😄

I've added logic in Keystone to update a user's email address in Mailchimp if they update their email address in Keystone, so that should take care of any issues with users getting out of sync when they change their email.
Now I'm looking into creating a script to sync the subscription statuses of the social workers in the list that @jeremysMARE provided, but I'm a little confused.  From the checks that I've done (just randomly picking an email from the list), none of those social workers exist in the Keystone database.  Is that your expectation @bchiaruttini and @joesmare ?  I thought these were all social workers that existed in Keystone but did not have their mailing list preferences synced with their actual subscriptions in Mailchimp.  I think I must have missed something 🤷♂

@n-devr there is one specific use case that I want to be sure to include in this work. In conversation with Bridget this morning we discussed that staff are sometimes creating records (as we've discussed as part of this work in the past) and that when someone creates a record from the admin UI they don't get the mailing list elections. Since Opt-In is the protocol I assume that the code would replicate the behavior of adding them to all three mailing lists, but have not tested this directly. Before I go down a rabbit hole, can you think about the code side of things and confirm or deny that a new user (any type) created by an admin. will be automatically subscribed to the lists? TY-we can discuss further on our call, as needed.

As discussed @n-devr the staff will use front-end form for creating ANY new accounts. DO NOT create a new record on the back-end.

@jeremysMARE did you check the other user types (aside from SW) to see if the initial code missed any other groups? We will need to run the clean-up on any other lists that may have chunks of missing tags as well. Please report back to @joesmare with any additional findings. There is a use case specific use case with SW-Waluszko (this is an example of a wrongly tagged SW-tagged as Homestudy registered in MailChimp)
@n-devr and @jeremysMARE please work together to pull lists to assure that we've caught these issues across all populations. Also, schedule quarterly/semi-annual audits to assure that this stays in sync.

While testing with Joe I realized that the social workers that @jeremysMARE compiled into a list do in fact exist in Keystone - you just can't search for users by their email address.  That was my misunderstanding - Jeremy the list is accurate and I will write a script to ensure their email preferences are captured properly on the Keystone side.

Is it possible that the subscription statuses of the social workers have changed since the Excel spreadsheet was generated?  I started writing a script to run through the list, but I'm noticing that many of them are subscribed to at least one, if not all three, of the Mailchimp mailing lists.

@n-devr @jeremysMARE  Yes I do think Jeremy manually tagged some workers as SW in mail chimp since that spreadsheet was first run.

I went through the updated list of active Social Workers who weren't subscribed to any Mailchimp mailing lists and updated any of them that had valid emails and had somehow gotten out of sync.  Attached is a list of the social workers that I could not update for some reason or another.
Social Workers Missing From Mailchimp.xlsx

@n-devr  thank you for all of your help researching and correcting this issue. The final list of 40+/- workers with missing emails, unidentifiable issues, etc. is a an acceptable exceptions list. I understand that in your research you determined that there were a number of records that appear to have been corrected in Keystone without any explanation. As such, you did not end-up writing code to support this process. Rather, you fixed them manually due to the low volume (as it was more efficient).
We will close this story, but not assume that the issue is fully resolved until we have several future opportunities to validate that the data is staying in sync between MailChimp and Keystone.
To that end, @jeremysMARE will run list sync checks between either the MM or Event lists and Keystone, once every 30 days. He will report any discrepancies back through this team to allow for further exploration of possible causes. If no out of sync record issues are observed over several cycles we will then consider this issue fully closed.
Moving this to a new story for @jeremysMARE..


A warning is displayed when creating a new app

Running npm init @zetapush <app-name> displays the warning below:
$ npm init @zetapush test-app
../src/pos.cc: In function ‘void Method(const v8::FunctionCallbackInfo<v8::Value>&)’:
../src/pos.cc:259:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
  int ret, row, col;
      ^

A similar warning is displayed a bit later, after entering the user credentials.
make: Entering directory '/mnt/c/Users/Gildas/Dev/project-zetapush/test-app/node_modules/get-cursor-position/build'
  CXX(target) Release/obj.target/pos/src/pos.o
../src/pos.cc: In function ‘void Method(const v8::FunctionCallbackInfo<v8::Value>&)’:
../src/pos.cc:259:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
  int ret, row, col;

Can you report your environment information? OS, Node/Npm version?

OS: Windows 10 Pro/WSL (Ubuntu 16.04.4 LTS)
Node: v8.11.1
NPM: v6.1.0

RELATED TO: https://github.com/bubkoo/get-cursor-position/issues/11

RELATED TO: https://github.com/bubkoo/ascii-progress/issues/26


Update Featured Link List Item Types

💡 Description
Featured link list item currently appears the same for all data types. It must be updated to look different for documentation, tool and data.
For example documentation should look like this:

Tool should look like this:

I created a follow up ticket to find the properties which describe the documents and data tab, see https://github.com/NASA-PDS/wds-react/issues/89


[move source language] Migrated operator tests

Motivation

Used for constant folding tests

Test Plan

ran em

@bors-libra r=tzakian

:pushpin: Commit 0043c50 has been approved by tzakian

:hourglass: Testing commit 0043c5097cf6a6bb34197abcf7908192e41d50a8 with merge 1ea271e18948d71c300c9696843efbaa59f39745...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: tzakian
Pushing 1ea271e18948d71c300c9696843efbaa59f39745 to master...


Link from basic middleware to middleware extensibility

Fixes #17730.
I wouldn't typically include a [!NOTE] like this, but I think it's important to call out that this entire topic assumes convention-based middleware.

@serpent5  I agree.
BTW, we don't change the date unless we've review the entire doc or made significant changes.  Minor date changes I don't bother.


typescript-apollo-angular generates unused types with sdkClass option

Describe the bug
When using sdkClass option together with typescript-apollo-angular plugin (see #3005 where this option was added), the generated wrapper service always includes a set of "xxxAlone" types, regardless of the contents of the schema for which code is being generated. But, these types are only used when wrapping a query, mutation or subscription, respectively.
The result is that depending on your schema, a generated type ends up being unused. And if you have enabled noUnusedLocals/noUnusedParameters flags in tsconfig.json, this results in a compile error on the generated code.
To Reproduce
Steps to reproduce the behavior:

My GraphQL schema:

type Feed {
  id: Int
}

type Query {
  feed(): [Feed]
}

My GraphQL operations:

query MyFeed {
          feed {
            id
          }
        }

My codegen.yml config file:

...
generates:
  ./src/graphql-types.ts:
    plugins:
      - typescript
      - typescript-operations
      - typescript-apollo-angular:
          sdkClass: true
          serviceName: GraphqlService
          serviceProvidedInRoot: false

Result: the generated file contains:
type Omit<T, K extends keyof T> = Pick<T, Exclude<keyof T, K>>;

type WatchQueryOptionsAlone<V> = Omit<ApolloCore.WatchQueryOptions<V>, 'query' | 'variables'>;

type QueryOptionsAlone<V> = Omit<ApolloCore.QueryOptions<V>, 'query' | 'variables'>;

type MutationOptionsAlone<T, V> = Omit<ApolloCore.MutationOptions<T, V>, 'mutation' | 'variables'>;

type SubscriptionOptionsAlone<T, V> = Omit<ApolloCore.SubscriptionOptions<T, V>, 'mutation' | 'variables'>;

Expected behavior
The generated file should contain only types that are required for the wrapper GraphqlService.
So, omit MutationOptionsAlone and SubscriptionOptionsAlone from the generated output when the schema does not contain mutation/subscription operations.
Environment:

OS: Windows 10
@graphql-codegen/typescript-apollo-angular: 3.4.1
NodeJS: 14.18.2

Additional context

Your changes have been released in<EMAIL_ADDRESS>📦
Thank you!


Make pygsti.DataSet.add_count_dict convert all keys in count_dict…

… to strings. This allows us to use the collections.Counter returned by cirq.TrialResult.histogram for count_dict. This does not affect existing behaviour because if the keys are already strings, then they won't be altered.

I think that you can simplify sorted(list(count_dict.keys()), key=str) to sorted(count_dict, key=str) altho the former is probably easier to interpret. I might at least get rid of the list(...).
test = {'a': 0, 'b': 1, 'c': 3}
sorted(test.keys()) -> ['a', 'b', 'c']
sorted(test) -> ['a', 'b', 'c']

The suggested update, which changes DataSet.add_count_dict so it converts the keys of count_dict into strings, would be problematic for other portions of pyGSTi.
PyGSTi uses tuples of strings, in general, to designate circuit outcomes.  For example, a circuit with an intermediate measurement with outcomes "A" and "B" and a final measurement with outcomes "0" and "1" has the outcomes ("A","0"), ("A","1"), ("B","0"), and ("B","1").  In the special case when there is only a terminating measurement the outcome is a 1-tuple.  PyGSTi contains logic that seamlessly treats 1-tuple outcomes as strings and vice versa, giving the impression that outcome labels are just strings so long as you never deal with intermediate measurements.  That said, the suggested update would break this framework for the general case.
I'm not entirely clear on the motivation for this change - perhaps just casting or changing the keys Counter returned from cirq.TrialResult.histogram to strings would offer an alternative solution?

Regarding the suggested simplification of sorted(list(count_dict.keys())) to sorted(count_dict), I expect you're right - though I'd want to check this works for versions of Python 3.5 and above.  It may be a leftover from some Python 2 version also.  I don't think the creation of the list is a big performance hit.  I'll note this as a low priority update.

Closing this PR for the reasons mentioned above.  Feel free to reopen if continued discussion is desired.


Editor crashes when custom time format is selected and blank

Bug Description
If you change your time format to "custom" on settings and clear the input so it's blank and save, when you navigate to the editor it will crash.
Expected Behaviour
There should be a fallback time format to avoid crashes.
Steps to Reproduce
Settings > custom time format > clear input > save
Navigate to editor (new story or existing), see that it has crashed.
Screenshots

Additional Context

Plugin Version:
Operating System:
Browser:

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

This is the issue I fixed in my last PR actually

Fixed by #5104

🤦♀ ooph i even reviewed that! I thought that date fix had been merged and that this was an edge case that i didn't test. my apologies.