Jupyter notebook support

Since https://github.com/psf/black/pull/2357 was merged, black supports linting Jupyter notebook files (.ipynb).
This PR therefore aims to extend the action to also annotate Jupyter notebook files.
I'm not sure how this will play with Github's displaying of Jupyter notebook code, or whether the output format from black for Jupyter is different from normal python file output, so this may need more testing/adaptation.
P.S. I debated adding an extra with arg for this, but then figured it's easier to just use the existing black_args  , if you wish to exclude/disable .ipynb checks, but maybe a README remark on this is useful?
Input/opinions/edits welcome.

I couldn't manage to test this properly on my local machine due to #45, so please feel free to ping me if there test/build issues that still need resolving.

@Chadsr Thanks a lot for implementing this pull request! I noticed you transferred your pull request to a draft. Feel free to let me know when you are ready. I added one small commit to account for the false positives received from the spellcheck linter.

@rickstaa I've added some Bash magic, so that the test actually checks the output of black is as expected.
Beyond that, i'm not yet totally sure how to verify if reviewdog handles the .ipynb annotations "properly" in Github?

Either I am missing something, or the .ipynb file annotation does not work properly, yet (probably due to structural differences in the file vs black output).
I would expect to see the reviewdog annotations added to this pull request, correct?

Should we maybe come to a decision, as to whether to put this PR on hold until annotations are definitely working properly, or do merge this and open an issue/PR to figure out the absolute vs relative line number problem?
Having some form of output as seen in https://github.com/reviewdog/action-black/actions/runs/1562786562 still seems like a good step in the right direction, and possibly worth of merging as-is, for now.

@Chadsr Thanks again for your pull request. I haven't yet been able to find the time to review your pull request properly. I try to do it this or next weekend. You can also try requesting a review from the other maintainers to speed the process along.

@rickstaa Whoops, this PR slipped my mind. No problem.
Technically I can merge this myself, now that I joined the reviewdog org, but it would still be good to get a second opinion, I think?

@Chadsr I understand! I will try to squeeze in some time to review it this weekend.

On the subject of dedicating time to this repo, I should also add, that moving forward I will happily take on a pro-active maintainer role to spread the load.

On the subject of dedicating time to this repo, I should also add, that moving forward I will happily take on a pro-active maintainer role to spread the load.

and on this subject, maybe it's useful for us to add a .github/CODEOWNERS file so that contributors can more easily know who to ping, or even better, just let Github automatically assign reviewers to PRs.

That's very nice! 🚀 I also like your ideas. I, unfortunately, still haven't found the time to review the pull request but I will look at it this weekend.

@rickstaa I've added some Bash magic, so that the test actually checks the output of black is as expected.
Beyond that, i'm not yet totally sure how to verify if reviewdog handles the .ipynb annotations "properly" in Github?
Edit: whoops, now I realise that the new test only covers pushes, not PRs. Let me fix that up. Edit 2: Actually, since test-check always runs, even during the pull_request event, I think this might be sufficient as is?

@Chadsr You are right the new test should be enough I like it! I extended it a bit to test both files that should be checked and the ones that should not be checked (see
3dc3b32).

@Chadsr I reviewed your pull request this morning, the code looks very clean and it works (see https://github.com/rickstaa/action-test-repo/actions/runs/1822872981). I agree that we might be able to improve the review dog output later but I think for now your pull request already is very valuable. Thanks again for implementing it! 🚀

@Chadsr Feel free to merge it after you reviewed 89696f9.

@Chadsr Thanks for merging this pull request.
Please be aware that with the current release action https://github.com/reviewdog/action-black/actions/workflows/release.yml the GitHub marketplace version does not automatically update. As a result, after each release, we have to manually click the edit button and save it for the version to update in the marketplace.
I still have to change this to using the gh https://github.com/cli/cli (see https://github.com/reviewdog/reviewdog/issues/1043), but I haven't found the time yet. I will created a pull request to remind us to change this.


object_store: Uploading empty file to S3 results in "411 Length Required"

Describe the bug

When using the S3 implementation of object_store a put() call with an empty content fails on the server side with a "411 Length Required" error:

Generic S3 error: response error "<?xml version="1.0" encoding="UTF-8"?>
<Error>MissingContentLength<Message>You must provide the Content-Length HTTP header.</Message></Error>", after 0 retries: HTTP status client error (411 Length Required) for url (https://s3.us-west-2.amazonaws.com/...)

To Reproduce

s3_store.put(&"foo".into(), Bytes::new()).await.unwrap()

Expected behavior

The call succeeds and uploads an empty file to S3.
Additional context

https://github.com/rust-lang/crates.io/issues/6793

label_issue.py automatically added labels {'object-store'} from #4518


cuda out of memory error

Hey, thanks for sharing your code!
I'm trying to fine-tune the model on my dataset, but I keep getting an out-of-memory error, even though I have 24 gigabytes of RAM. Any ideas on what might be causing this problem?
Thank You!

I am doing fine-tune on kaggle and using python3.10 and used transformers==4.30.2
git+https://github.com/huggingface/peft.git@86290e9660d24ef0d0cedcf57710da249dd1f2f4
But still not able to start the training
Unexpected exception formatting exception. Falling back to standard exception
Traceback (most recent call last):
File "/opt/conda/lib/python3.10/site-packages/IPython/core/interactiveshell.py", line 3508, in run_code
exec(code_obj, self.user_global_ns, self.user_ns)
File "/tmp/ipykernel_42/3053083764.py", line 29, in
trainer.load_base_model()
File "/kaggle/input/llama-finetune1/llm_qlora-main/QloraTrainer.py", line 34, in load_base_model
model = LlamaForCausalLM.from_pretrained(model_id, quantization_config=bnb_config, device_map={"":0})
File "/opt/conda/lib/python3.10/site-packages/transformers/modeling_utils.py", line 3694, in from_pretrained
Positions of the first token for the labeled span.
File "/opt/conda/lib/python3.10/site-packages/transformers/modeling_utils.py", line 4104, in _load_pretrained_model
File "/opt/conda/lib/python3.10/site-packages/transformers/modeling_utils.py", line 786, in _load_state_dict_into_meta_model
File "/opt/conda/lib/python3.10/site-packages/transformers/integrations/bitsandbytes.py", line 108, in set_module_quantized_tensor_to_device
RuntimeError: CUDA error: device-side assert triggered
CUDA kernel errors might be asynchronously reported at some other API call, so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
Compile with TORCH_USE_CUDA_DSA to enable device-side assertions.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/opt/conda/lib/python3.10/site-packages/IPython/core/interactiveshell.py", line 2105, in showtraceback
stb = self.InteractiveTB.structured_traceback(
File "/opt/conda/lib/python3.10/site-packages/IPython/core/ultratb.py", line 1428, in structured_traceback
return FormattedTB.structured_traceback(
File "/opt/conda/lib/python3.10/site-packages/IPython/core/ultratb.py", line 1319, in structured_traceback
return VerboseTB.structured_traceback(
File "/opt/conda/lib/python3.10/site-packages/IPython/core/ultratb.py", line 1172, in structured_traceback
formatted_exception = self.format_exception_as_a_whole(etype, evalue, etb, number_of_lines_of_context,
File "/opt/conda/lib/python3.10/site-packages/IPython/core/ultratb.py", line 1087, in format_exception_as_a_whole
frames.append(self.format_record(record))
File "/opt/conda/lib/python3.10/site-packages/IPython/core/ultratb.py", line 969, in format_record
frame_info.lines, Colors, self.has_colors, lvals
File "/opt/conda/lib/python3.10/site-packages/IPython/core/ultratb.py", line 792, in lines
return self._sd.lines
File "/opt/conda/lib/python3.10/site-packages/stack_data/utils.py", line 144, in cached_property_wrapper
value = obj.dict[self.func.name] = self.func(obj)
File "/opt/conda/lib/python3.10/site-packages/stack_data/core.py", line 734, in lines
pieces = self.included_pieces
File "/opt/conda/lib/python3.10/site-packages/stack_data/utils.py", line 144, in cached_property_wrapper
value = obj.dict[self.func.name] = self.func(obj)
File "/opt/conda/lib/python3.10/site-packages/stack_data/core.py", line 681, in included_pieces
pos = scope_pieces.index(self.executing_piece)
File "/opt/conda/lib/python3.10/site-packages/stack_data/utils.py", line 144, in cached_property_wrapper
value = obj.dict[self.func.name] = self.func(obj)
File "/opt/conda/lib/python3.10/site-packages/stack_data/core.py", line 660, in executing_piece
return only(
File "/opt/conda/lib/python3.10/site-packages/executing/executing.py", line 190, in only
raise NotOneValueFound('Expected one value, found 0')
executing.executing.NotOneValueFound: Expected one value, found 0


Added event-data/events + event-data/fields

Added support for reading from the event data API to pull events and fields.
Also minor documentation cleanup.

thank you so much, really appreciate it :)


how to map wod question/answers to in-game wod reactions

basically, determine all the madlib variations and situations that trigger them


Export deeplearn as dl in the global namespace

This change is

Forked from an incorrect branch. Will open another PR


Combine rbus and rbuscore Unittest Programs under one single binary

Reason for change: Combine rbus and rbuscore Unittest Programs under one single binary
Test Procedure: Run rbus_gtest.bin to execute both core and rbus unittests
Risks: Low

Blackduck scan failure details
Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/rbus/5/rdkcentral/rbus

Commit: 48a59ef3d73ee3d43771735e9cbe3a2bc5581a5b

Report detail: gist


for eventhubcapture publisher, require a connectionstring

Exception if using capture publisher but did not specify connectionString

Expected function.json
{
  "bindings": [
    {
      "type": "EventGridTrigger",
      "name": "myBlob",
      "direction": "in",
      "publisher": "eventhubcapture",
      "connection": "privateStorage"
    }
  ],
  "disabled": false
}

output difference:
before change
2017-07-31T06:37:25.482 Function started (Id=3346b2ee-807c-4aba-8a22-43b06d9f0be0)
2017-07-31T06:37:25.732 file name archivecontainershun/canaryeh/test/0/2017/07/31/06/36/27.avro
2017-07-31T06:37:25.732 blobName canaryeh/test/0/2017/07/31/06/36/27.avro
2017-07-31T06:37:25.732 metadata System.Collections.Generic.Dictionary`2[System.String,System.String]
2017-07-31T06:37:25.986 Function completed (Failure, Id=3346b2ee-807c-4aba-8a22-43b06d9f0be0, Duration=512ms)
2017-07-31T06:37:27.635 Exception while executing function: Functions.EventGridTrigger-Test. mscorlib: Exception has been thrown by the target of an invocation. Microsoft.WindowsAzure.Storage: The remote server returned an error: (404) Not Found. System: The remote server returned an error: (404) Not Found.

after change
2017-07-31T06:43:05.450 Function started (Id=6ffd80bd-1774-4f99-b243-85cd5e8dcb11)
2017-07-31T06:43:05.450 file name archivecontainershun/canaryeh/test/0/2017/07/31/06/41/27.avro
2017-07-31T06:43:05.450 blobName canaryeh/test/0/2017/07/31/06/41/27.avro
2017-07-31T06:43:05.450 metadata System.Collections.Generic.Dictionary`2[System.String,System.String]
2017-07-31T06:43:05.529 Objavro.codecnullavro.schema�{"type":"record","name":"EventData","namespace":"Microsoft.ServiceBus.Messaging","fields":[{"name":"SequenceNumber","type":"long"},{"name":"Offset","type":"string"},{"name":"EnqueuedTimeUtc","type":"string"},{"name":"SystemProperties","type":{"type":"map","values":["long","double","string","bytes"]}},{"name":"Properties","type":{"type":"map","values":["long","double","string","bytes","null"]}},{"name":"Body","type":["null","bytes"]}]} ���#΁M�1��  ���#΁M�1��
2017-07-31T06:43:05.529 Function completed (Success, Id=6ffd80bd-1774-4f99-b243-85cd5e8dcb11, Duration=90ms)

@watashiSHUN,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot


support for volume resize

Describe the problem/challenge you have

If the NFS PV capacity is being used up, there is no way to resize the capacity - even though the underlying PV supports resize.
Describe the solution you'd like

NFS PV resize should be supported, if the underlying storage class (PV) supports it.
Anything else you would like to add:

This feature needs to take into account the following:

Typically NFS is mounted on block storage and it may be possible that some of the backend storage class/PVs do not support resize, or support silent resize ( like hostpath), or online/offline resizes (like GPD vs iSCSI volumes).

As of now, NFS PV can be resized through manual steps. Once NFS Provisioner supports CSI provisioning, Resizing can be done dynamically.


Support parallel requests for multiRes panorama tiles

Looking at the network waterfall diagram in Chrome's developer tab, it's clear that the individual tiles for multiRes panoramas are always loaded serially, making them excruciatingly slow to load if the latency to the server is high:

This is true regardless of the setting of cacheTop in loadTexture(), which would ideally be in control of the texture loading parallelism:
var cacheTop = 4;   // Maximum number of concurrents loads

The reason is due to this code:
program.currentNodes.sort(multiresNodeRenderSort);
// Only process one tile per frame to improve responsiveness
for (i = 0; i < program.currentNodes.length; i++) {
    if (!program.currentNodes[i].texture) {
        console.log("setTimeout: " + program.currentNodes[i].path); // <- Added this for debugging
        setTimeout(processNextTile, 0, program.currentNodes[i]);
        break;
    }
}

Every frame, a list of nodes in the viewport is sorted by their position and level, and then because of the break statement, only the first of the incomplete nodes will ever be queued for loading. The sorting means that the same node is likely to be chosen for loading every time, unless the view shifts significantly, even if that node is already queued for loading. A new node is only chosen once the first node is loaded (texture gets set).
The net result is that the same tile gets queued over and over again (20 times or more). The cache loader pool is not properly utilised (only one or two loaders is ever run in parallel).
This patch allows nodes to be queued up for loading until the texture loading pool is completely full. After the patch, the network diagram on Chrome clearly shows 4 requests in the (pending) state simultaneously, and the panorama loading is astonishingly faster on high latency connections (100ms+).

Thanks! The multires tile loading is definitely something that's suboptimal.


Browse Search not working. Sources missing website titles.

Steps to reproduce
This happens for most of sources with many other titles, especially the obscure ones like this. Makes me feel like sources scraping/parsing only top titles ignoring unpopular ones.
Example:

Install MangaDex source
Go to browse search and type DDT or Miminashi-Hohichi (this title on mangadex)

Expected behavior
It should find what mangadex has on it's website.
Actual behavior
Instead get nothing.
Crash logs
No response
Mihon version
0.16.5
Android version
Android 12
Device
Motorolla idk
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version 0.16.5.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

you need to enable that content in the extension settings, also this is not related to the app.

What should be enabled there?


Add support for enabling cluster mode in scripts

This PR:

add command line args for both Texera server and worker to enable cluster mode.

Group discussion 1/11: @shengquan-ni will test it on openlab machines and merge it soon

Discussion 2022.05.12: @shengquan-ni will merge it.


[Android] EventInfo.Time is set to year 0001 despite TimeStamp being set correctly on eventproperties

OneDrive Android
We are on <IP_ADDRESS> . We recently updated this version from 3.5.63, which is a massive update worth about two years of changes.
Steps to reproduce.
We are sending EventProperties to Logger with the timestamps correctly set to current time in milliseconds. This is what it looks like on our end. The second highlighted line shows TimeStamp correctly set with a millisecond time.
What is the expected behavior?
I expect that the value passed into EventProperties.setTimestamp(long) should be the time reflected in EventInfo.Time
What is the actual behavior?
EventInfo.Time is incorrect when the data is emitted and picked up in Aria. EventInfo.Time is showing a date in the year 0001. This causes our telemetry tools to reject the data.
This is what the data looks like when I receive it in Aria. I notice that there are two properties marked TimeStamp, with the inner TimeStamp value being set to a negative number Perhaps this is why EventInfo.Time is incorrect, although I do not know why this happens.

Here's a decoded request body from fiddler
decoded_oneds_sample.txt

I see timeStamp here but I do not see an "eventInfo.time".

cc: @kindbe @lalitb
The value shown is treated by collector as time in ticks, not millis. If you take that time value and convert it as .NET ticks to time, you get exactly this date 0001-01-02.
The fix should be in EventPropertiesDecorator.hpp to convert the value returned by GetTimestamp() from millis to .NET ticks. time_t should have a helper method for that. Collector expects the ticks, not millis in this field. 😊
In BaseDecorator.cpp:
record.time = PAL::getUtcSystemTimeinTicks()
This is correct. That's why all usual events have the right timestamps on them.
In EventPropertiesDecorator.hpp:
record.time = timestamp
This is incorrect. Because timestamp above is in millis, not ticks. #909 needs a minor fix.

For the millis, is there a well known start point of the milllis value? In getUtcSystemTimeinTicks, Windows and Linux are handled differently.


debug error

When I debug the code refers to mmcv.inshow_det_bboxes line 330 in mmdet/models/detectors/base.py,
the error was,self:ATSS with_box:('Traceback (most recent call last):\n  File "/root/.vscode-server/extensions/ms-python.python-2021.5.842923320/pythonFiles/lib/python/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_resolver.py", line 193, in _get_py_dictionary\n    attr = getattr(var, name)\n  File "/root/anaconda3/envs/mmdetection/lib/python3.8/site-packages/torch/nn/modules/module.py", line 593, in getattr\n    raise AttributeError("'{}' object has no attribute '{}'".format(\nAttributeError: 'ATSS' object has no attribute 'with_bbox'\n')
But bboxes and bbox_result has values.

Hi @mytk2012  You can try the following script to see if it is correct？ python demo/image_demp.py  configs/atss/atss_r101_fpn_1x_coco.py  http://download.openmmlab.com/mmdetection/v2.0/atss/atss_r50_fpn_1x_coco/atss_r50_fpn_1x_coco_20200209-985f7bd0.pth


How to clase StyleableToast ?

I'm make a toast that's appear when user scan a QR code , For some reasons toast can show more times. I need to close it or hide it when the user leave the scanning activity.
Thanks In advance

There is a toast.cancel(); method you can use


community: Add Fireworks callback handler to track token usage info

Description: I implemented FireworksCallbackHandler using OpenAICallbackHandler as a reference, it allows you to access token usage information in the same way.
Issue: None
Dependencies: None

Usage example:
from langchain.llms.fireworks import Fireworks
from langchain_community.callbacks import get_fireworks_callback
llm = Fireworks()
with get_fireworks_callback() as cb:
    result = llm("Hello world!")
    print(cb)

@efriis Would you mind approving these workflows? Thanks

Hey @baskaryan could I get you or another maintainer to take a look at this PR? Would be super useful to have as I need to compare token costs between OpenAI and Fireworks for my eval pipeline, thank you! :)

cc @hinthornw

Could we add this to ChatFireworks as well before landing?

Closing but tag me and I will re-open if anyone wants to push this with the following updates:

Correct pricing information;
Reads token counts off AIMessage.usage_metadata, which ChatFireworks outputs for both invoke and streaming.

Should be tested (at least locally) using ChatFireworks in langchain-fireworks library.
See example with OpenAI callback here.


blog: wip development vs harness development

Hello @ellenkorbes,
Please review the following commits I made in branch nicks/wip:
0666039fc4e2bf9357f415e492056a966260ddc2 (2021-05-26 19:48:57 -0400)
blog: wip development vs harness development
Code review reminders, by giving a LGTM you attest that:

Commits are adequately tested
Code is easy to understand and conforms to style guides
Incomplete code is marked with TODOs
Code is suitably instrumented with logging and metrics

Goals:

in the spirit of blog posts as documentation, I want to try the pattern of using slack discussions as a pipe into blog posts, so we have things to point to in the future
I'm trying to test out different names of what Tilt is for, and see what terms people repeat back to me. I really admire "GitOps" as a term of art. I like how "WIP changes" (a) mirrors the "WIP" commit message everyone uses, (b) clarifies that you really shouldn't deploy with Tilt, and (c) sounds funny

I think overall what's missing is a clear and concise statement of the point of the two.
After reading I get the feeling that Harness-type is good and reliable vs. WIP-type which is sloppy and insecure. That's because the end-goal of each wasn't outlined explicitly, only their characteristics. And I don't we can expect everyone to connect the dots themselves.
So for example:

"WIP-style serves for fast iteration, when you're actively working on a solution to a problem, and you want as-fast-as-possible feedback, and it's a development environment anyway so correctness and reliability are secondary concerns to sheer speed of iteration."
"Harness-style is what happens after the step above. It's when the solutions to individual coding steps have already been solved, and now we're trying to conform that code to the standards of a larger system. Here we are very concerned about correctness, reliability, and security, but we don't care about speed anymore."

And I would also point out that the point in which these two connect is the commit/PR. One workflow is focused on the pre-commit stage, the other on the post-commit stage.

ya, I think that's a fair high-level criticism. Let me think on this a bit.

ahhh, i keep getting sidelined when i set aside time to work on this, so just made the edits you suggested!


Indicate area return unit

I see that measurements.length says something about the return value (default km), but measurements.area doesn't. This an be easily fixed, but it would be perhaps more helpful to allow for different langth and area units. There are some packages for handling units in a way that they can be used in calculations, but these are likely not enough standardized...

Addressed in https://github.com/omanges/turfpy/commit/9deea11ac647169cd0ac0fbef26b6dd2ab494351#diff-bd9667bdd2aeaebd63dcc2dc03e5f622


Unable to launch a go-gtk program on linux

I managed to compile my go-gtk app on windows. But when running on another computer, or without Msys64 in the PATH, Windows can't find the GTK libraries.
Can't i bundle them in the .exe ?
I saw that : https://github.com/mattn/go-gtk/issues/220
But he closed the issue without solving his problem

You can't bundle *.dll's into a program. The dynamic linker loads the *.dll's just before it starts the program.
I have no specific knowledge about of how Windows works regarding dynamic linked libraries (dll), but what you need to do is to make sure the dynamic linker can find the *.dll libraries your program are using.
Read this:
https://linux.die.net/man/8/ld-linux
On Linux distros you could fiddle with LD_LIBRARY_PATH, if the *.so file (the Linux equiv of a *.dll file) are outside the normal directories that are searched by the dynamic linker.
About Static, Shared Dynamic and Loadable Linux Libraries:
http://www.yolinux.com/TUTORIALS/LibraryArchives-StaticAndDynamic.html
That is of course specific for Linux distros, but Windows work the same way, but with a slightly different way of doing things.

Thanks i lot, i will look at this


Update formWizard.ts

fix: submit should fire in Result component according to route config.

Thank you @cpprookie


Unable to install app

Error: ENOENT: no such file or directory, open '/Users/name/Library/Application Support/Figma Plus/input/window_manager.js'
    at Object.fs.openSync (fs.js:577:3)
    at Object.module.(anonymous function) [as openSync] (ELECTRON_ASAR.js:166:20)
    at Object.fs.readFileSync (fs.js:483:33)
    at Object.fs.readFileSync (ELECTRON_ASAR.js:563:29)
    at injectSync (/Applications/Figma Plus.app/Contents/Resources/app.asar/node_modules/inject-code/lib/index.js:163:19)
    at module.exports (/Applications/Figma Plus.app/Contents/Resources/app.asar/node_modules/inject-code/lib/index.js:227:22)
    at startInjecting (/Applications/Figma Plus.app/Contents/Resources/app.asar/renderer.js:266:3)
    at checkFigmaBeforeRunning (/Applications/Figma Plus.app/Contents/Resources/app.asar/renderer.js:181:5)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Figma Plus 1.0.0
Electron 3.0.9
darwin 18.5.0
Locale: en-US

resolved, need to have the desktop app first.


[WIP] Add support for generating Azure Blob Storage signed URLs

This PR introduces support for sharing Delta Lake tables stored on Azure Blob Storage.
I've marked the PR as WIP, since I feel there are still a couple of open questions that we may want to address in this or subsequent issues.

Is it okay to change the signature of the function signing the urls to be async?
The crate that I used to call the Azure SDK for building a pre-signed URL has an async method to do so. I figured this was okay, since all route handlers are async anyway.
What should we do if there are no credentials available to sign the urls?
Right now the urls are passed through to the client unsigned. We may want to present an error instead.
In Azure there are multiple possibilities for authentication to Azure Blob Storage. I've chosen to implement only the Shared Key method, since that brings this crate at parity with the scala implementation

On a higher level:

I think it is a good idea to bring in a crate that can handle signing URLs for the different cloud object stores where the Delta Table lives. To this end I've published a crate that I used in some other personal projects to do exactly this https://crates.io/crates/cloud-file-signer. This crate defines a CloudFileSigner trait and implements it for a couple of popular object stores (S3, Azure Blob Storage, GCS) and could be extended to other stores (R2, MinIO, etc.)

Looking forward to some feedback!
Closes #18

Hi Tim, thank you for submitting this PR!
I haven't delved into the details of the PR yet, but it looks great. That aside, I like your idea of the Delta Sharing Server SDK, the delta-sharing-server-rs project. Since the Delta Sharing protocol is defined through REST APIs, there may be some considerations to keep in mind; nevertheless, the idea is interesting.
As for the cloud-file-signer crate, I believe it would be more beneficial to expand it into a larger project, similar to the delta-sharing-server-rs. If your contribution here serves any purpose, please feel free to incorporate it.

@tdikland
Regarding the open questions, here are my answers:

Yes, it is totally fine, and it would be better to do so.
According to the official protocol specification, there is no description. However, I think we should return a 500 error and trace the error.
For now, I would not like to introduce complexity, so I really appreciate your implementation that aligns with the reference server implementation. When we want to add further options, we should create another issue.

Thanks for your quick reaction and enthusiasm @ognis1205.
Regarding the delta-sharing-server-rs project, I think it would be great for users to have both the lib that implements the delta sharing protocol and the batteries included version (which this crate is currently focusing on). The user journey that I'm thinking about is a user starts by deploying the reference implementation of the delta sharing server and when customisation is needed they can take the lib and plugin custom auth, retry, other middleware, different database etc. It may be nice to support this user journey with this project. I will open a new issue to discuss this in more depth.
Regarding the support for the underlying object stores (i.e. AWS, Azure, GCP). Thanks for your insights on my questions. I will be iterating on the implementation and let you know when it's ready for review.

I am very grateful for your contribution @tdikland !
This is a quick review of the current commit. Regarding the 'cloud-file-signer' crate, I believe there is operational experience in your project, but I think it still needs a bit more incubation. Therefore, I believe it's still early to use the crate. Since this project itself is also in incubation, considering the future development speed, I would prefer to have the implementation of signed URLs for each cloud provider done here as much as possible. The experience gained here can then be reflected in 'cloud-file-signer,' and eventually, I would like to use the crate in 'delta-sharing-rs' as well.
Please do not remove utilities::signed_url. Instead, can we consider implementing a policy to instantiate the cloud signer instance from the credentials of each provider using a factory method (similar to what is done in the bootstrap module)? I would like a factory method to be added to the struct Utility. The reason is that having information in the form of logging, indicating which provider's credentials were loaded during server bootstrap, would be more informative and would ensure compatibility with other modules. What do you think?

@tdikland
Even if, for instance, we are not currently using the crate, I am considering stating in the README that we anticipate potential future use of it as a related project.

Thanks for the feedback. I agree it is not yet desirable to depend on the cloud-file-signer crate. I was experimenting with it and accidentally pushed it to this PR (sorry!). I'll give a heads-up once it is ready for review!

You don't have to apologize for it at all! I apologize if I have caused any disruption to the development. We should have prepared a more accessible system, such as a Code of Conduct (COC), to make participation easier. It was very helpful that you made various suggestions and asked questions.

Allright, I think I got it down now.

Thank you for your cooperation @tdikland :)
I believe we have reached a consensus on the general direction of the implementation. It seems there are still some parts that I would like to discuss though, before proceeding to the review, let's go ahead and run some tests for now. @roeap could you please approve the workflow?

Hi @ognis1205, @roeap, I'm ready for reviewing.

acquire pre-signed URls

We already support this for S3, Azure and GCP are more complex but would be happy for contributions in this space - https://docs.rs/object_store/latest/object_store/signer/trait.Signer.html

@tdikland @roeap
I will review this PR in the next 12 hours, here in Tokyo, it's around 24:00 midnight.

I did not see the discussion around delta-sharing-server-rs, but in the past @ognis1205 and I had discussed that
we want to break this up into smaller crates. and split the different "sub-apis" such that one can easily mix-and-match
a server that supports the sharing protocol with just the desired features.

Is there any place to discuss this issue? I have some opinions on this since the protocol is defined over REST APIs.

FWIW I've created two upstream tickets on object_store for adding support for Azure and GCP, along with links to the relevant docs. I think they should be relatively straightforward if anyone wanted to pick them up:

https://github.com/apache/arrow-rs/issues/5232
https://github.com/apache/arrow-rs/issues/5233

@tustvold  - i know the azure apis quite well, and signing using keys should (hopefully) be straignforward to leverage the existing signing using the master key ... user delegated are just API cal li think :)
had a quick glance at GCP - might do that second - seems similar, cannonicalize request and sign ...

@tdikland - just FYI, started to add url signing for azure to object store https://github.com/apache/arrow-rs/pull/5259.

@roeap @ognis1205 - FYI I have created two new issues to keep track of the discussion and next steps.

https://github.com/delta-incubator/delta-sharing-rs/issues/23
https://github.com/delta-incubator/delta-sharing-rs/issues/24


fix command to run test bot to use ts-node

Since the testbot is written in typescript, we need to use ts-node to run it instead of plain old node

@mgbennet,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Oh interesting. No compile step for testbot?

ts-node handles the compiling for you, letting you just run it.


Text composables: Android Basics with Compose - Create an Empty Activity should be Create an Empty Compose Activity

URL of codelab
https://developer.android.com/codelabs/basic-android-kotlin-compose-text-composables?continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-compose-unit-1-pathway-3%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-compose-text-composables#1
In which task and step of the codelab can this issue be found?

Set up a Happy Birthday app - Create an Empty Activity project - 2. In the New Project dialog, select Empty Activity and then click Next.

Describe the problem
The instructions should say Create an Empty Compose Activity rather than Empty Activity. If you follow the instructions and Create an Empty Activity project then not only does running it show a different thing to the screenshot but there is also no @Composable Greeting or GreetingPreview functions generated for you.
Steps to reproduce?

Follow instructions on Set up a Happy Birthday app to Create an Empty Activity project
Build and run to get something that shows Hello World! in the centre of the screen.
Note the absence of Greeting and GreetingPreview functions in MainActivity.kt.

Versions
Android Studio Electric Eel | 2022.1.1 Patch 2 (Linux)
Don't know how to get the _API version of the emulator but it's not important for this issue
Additional information

Hi @LinuxBrickie
Thank you for writing in with your issue.
From your report, you are using an older version of Android Studio.
The prompts have changed in newer versions which is why you are experiencing this issue.
Please update to the latest stable version of Android Studio as this should resolve your issue.
Hope you are enjoying the course!
Regards.


Added comma replacement for min/max methods and updated tests. Fixes #379

It makes sense that if we accept numbers with US comma separators for numbers that we also accept them for min/max.

this is a joke. both issues #188 and #379 which have been unfixed for years are closed referring to each other as reasons for closing. yet this fix STILL has not made it into release.


Enable IAM Authn fails to refresh certificate when using ADC retrieved from a metadata server

Bug Description
When running the proxy on GKE with the -enable_iam_login flag, the proxy will initially succeed at startup, but about 1 hour later when it tries to refresh the ephemeral certificate, it fails with a message like the following:
2021/03/05 22:48:21 failed to refresh the ephemeral certificate for kvg-testing:us-central1:test2, returning previous cert instead: new ephemeral certificate expires too soon: current time: 2021-03-05 22:48:21.070824294 +0000 UTC m=+302.212008501, certificate expires: 2021-03-05 23:43:20.959727769 +0000 UTC m=+3602.100911936

This is likely related to how we're doing OAuth2 token refresh, which differs based on the credentials in use.
Related to #643.

Specifically, we think this is related to where the ADC are generated from. We think the issue is that the ADC return a gaeTokenSource that doesn't use a ReuseTokenSource, but instead does some internal caching, which is preventing us from getting a new token early.

I was able to verify it's not a problem with the gaeTokenSource - the token is definitely a ComputeTokenSource.
Not sure why or where the token is getting cached for whatever reason. Might be happening on the server side.


bug fix: return errors from hcsEnumerateComputeSystem

Errors from GetContainers were being ignored, and instead the returned pointer was unexpectedly null, resulting an (incorrect) invalid data from hcs error.
Signed-off-by: Darren Stahl<EMAIL_ADDRESS>/cc @jhowardmsft @jstarks

LGTM


Billing address is not required for creating order

The commit is based on documentation:
https://online.worldpay.com/api#orders
The documentation says, that billingAddress is optional.

We are busy with a larger refactor of the code, will add this into the next version.


Add links to projects required to claim certificate above the certificate itself

Currently when you visit a person's certificate you only see the certificate that was issued.
We should add some text and links to the projects that were required to claim the certificate above the certificate itself. Each link should go to the solution that was submitted rather than the project page.
For example:
In preparation for completing this certification, _(name)_ completed these five projects:

* Project 1
* Project 2
* Project 3
* Project 4
* Project 5

If you think there has been academic dishonesty, report it here.

However, links to the JS Algorithms and Data Structures projects will need to be handled differently -- the solutions are stored in the DB, but won't exist anywhere online.
Also, "report it here" should be the same link/method used for the current "Report This User" link on the profile page.
Cc @QuincyLarson for feedback on the text.

I am assigning this to @ahmadabdolsaheb to cut the turn around time and feedback loop.

I am removing my assignment in case another contributor is interested in making a pull request.

I am interested in taking this up 😃

@scissorsneedfoodtoo Kris, I will get a PR, once #39735 is through, also depending on if I want to leverage anything from #39695 . So, for now, clarification on styling would be very useful:

Is there anything (words) I should be deleting from the current certification? Or, just adding the OP suggestion?
Is it ok for this to go over 100vh? Or, should there be a separate view for mobile?
For the JS solutions, should the link to open up a modal like it does on the settings page?
For the backend projects, should the link be a dropdown with links to the solution/github, as it is on the settings page? (This does not sound ideal for the campers who screenshot/pdf their certs)

Probably justify the text on the certs like we have on the landing page? Other than that it looks great to me.

@raisedadead, here is an idea to make the project list cover all the corner cases that @Sky020 addressed above:

The project list could be either above of below the certificate itself to avoid crowing the exiting elements.

The list would consist of text items followed by a list to a solution. That way we could list both of links (solution, github) links in the same line.

The JS solution could open in a modal as the settings page.

Here is an example:
Submitted projects for this certification:

project number one:  solution, source
project number one:  solution, source
project number one:  solution, source
project number one:  solution, source
project number one:  solution, source

let me know what you think?

Hey @Sky020, thanks for your patience.
Awesome, it seems like you made some great progress here already! Also, thank you for bringing up all those corner cases. Those are all very good points to consider.
Like @ahmadabdolsaheb mentioned, it might be good just to have the text and links for each project above the certificate itself to avoid many of the issues you pointed out. I think it looks pretty good on the certificate itself, though.
This is something we can bring up with @QuincyLarson for additional input.

@scissorsneedfoodtoo Thanks for bringing this to my attention.
@Sky020 This is a good way to show people's work. Rather than list these projects on the certification itself, we should list them below the certification with the following message:
As part of this certification, {name} built the following projects and got all automated test suites to pass:

Project 1
Project 2
Project 3
Project 4
Project 5

If you suspect that any of these projects violate the academic honesty policy, please [report this to our team](Report URL).

@QuincyLarson and @ahmadabdolsaheb I would still like clarification about the way the projects/solutions/code will be linked to:

This was the easiest way to test (essentially, copy-pasta of the settings page)
Should the project names, just be links to:

Modal of code, if JS Data Structures section
Live App, otherwise.

Or, should it be as Ahmad has above:

project name: solution, source...

I will fix the spacing between the social links and the projects, and report URL later.

Also, how do we want the report to be handled? I have it routing to /user/username/report-user
This has the issue of expecting the reporter to be logged-in. Is this ok?

This has the issue of expecting the reporter to be logged-in. Is this ok?

I think this is a very good idea, to be honest. Allowing unauthenticated reports inhibits the ability to track spam, and prevents a report from being traced back to a source - while spam/abuse might not be likely to happen, I think it's still good to take steps to mitigate it.

This has the issue of expecting the reporter to be logged-in. Is this ok?

At first this seemed logical to me, to create some accountability to those reporting the issue.  Otherwise, we could have a bunch of random "false alarms" where someone is just spamming someone's account.
However, if someone who has never been a member of freeCodeCamp discovers someone has copied their content (i.e. from their own app or website), they should not have to signup for an account just to report a user's plagarism.

However, if someone who has never been a member of freeCodeCamp discovers someone has copied their content (i.e. from their own app or website), they should not have to signup for an account just to report a user's plagarism.

I think this is a valid concern - but rather than allowing unauthenticated/anonymous reports, could we add an alternate flow that allows for a direct email? Or something that does not require an fCC account but still provides some form of identification?

I would prefer the following format for its simplicity:
project name: solution link, source link


[POAE7-2390] JITModule & JITFunction Class

What changes were proposed in this pull request?

Basic compile framework for next gen query compiler.
Why are the changes needed?

For next gen compiler.
Does this PR introduce any user-facing change?

No
How was this patch tested?

UTs
Which label does this PR belong to?

Infra
This is the basic compile framework for next gen query compiler. You could start from the basic usage example in the unit test and dive into the detail implementation.
There are some remaining works will be done soon:

~Header files including refactor.~
~LLVMBuilder passing interface refactor.~
~Template-based function signature generator.~

Pls take a review @winningsix @xieqi @Ma-Jian1

Any design doc or class diagram can refer?

MIP is under working, will be pushed to the wiki after finished.

Thanks for all comments! I will refactor the code and push later.


Styling of the info

 Issue by Donaldini
Monday Mar 06, 2017 at 10:35 GMT
Originally opened as https://github.com/storybooks/react-storybook-addon-info/issues/140

I was looking through the issues whether there was something about styling the content generated by the add-on, but couldn't find any previous info.
I did see this post of @mnmtanish that showed a styled version of the info.
What would be the best and contained way of styling the add-on?

 Comment by mnmtanish
Saturday Apr 08, 2017 at 11:13 GMT

Related PR: https://github.com/storybooks/react-storybook-addon-info/pull/135
cc: @jbellsey

I will not be pursuing that PR any further. Feel free to take its code and/or ideas and implement as you see fit (or abandon it).


(maint) Bump bundled modules to latest versions

!feature

Update bundled modules to latest versions
The following bundled modules have been updated to their latest
versions:

package 2.1.0

puppet_agent 4.9.0

puppet_conf 1.2.0

reboot 4.1.0

service 2.1.0

stdlib 8.0.0

Hm, since this is bumping stdlib a major version with a breaking change to a function signature, I think calling out either in release notes or in the docs that users can install the old version of the module to their project if they need to https://puppet.com/docs/bolt/latest/modules.html#modulepath is important.

@lucywyman Updated the release note.


Add Python memory management post

This PR adds a new blog post covering Python memory management and troubleshooting. The work is inspired from content initially developed in CU-DBMI/demo-python-memory-reference-accounting#1 , which is a test-driven investigation of Python memory. My hope here is to share information on the same topics while allowing for greater flexibility to explore memory implications within CU-DBMI/demo-python-memory-reference-accounting.
As part of this work I also added a "tip-of-the-month" includes block to adjust to newsletter wording and a less frequent post cadence. We could also drop the nomenclature here as well to provide more flexibility.
Thank you in advance for any feedback and input you may have!
CC @chrisroederucdenver
Relates to work in cytomining/CytoTable#75

Background on the nested tables: I tried to find a better way to describe these without tables (using diagramming tools) but found HTML tables to be the plainest / simplest to work with. If there's something else I should use or do for these, please don't hesitate to let me know!

Update: I've moved to images of the rendered tables to work around any potential issues here. The HTML source is preserved within an HTML comment for replicability / modifications.

Didn't see this comment until now. Were you seeing any specific issues? If so, it could be a CSS issue with the template. The bucket emojis would look different on different devices but I don't think that's a problem.

Thank you @vincerubinetti and @falquaddoomi for your reviews and thorough comments! I've made some modifications based on your comments.

Thank you so much @chrisroederucdenver for your review and further comments to this! I've adjusted the content to be more accurate based on what you mentioned.


Windows support radical Idea?

this sounds crazy, but hear me out, don't reject the idea right away, research & think about it.
Microsoft has this ancient technology called HTML Applications (HTA) on Windows since Windows XP.
it was a failure, and was discontinued. it's even patented, LOL oh classic 2003 Microsoft.
but mshta.exe is still on every windows installation since Windows XP. and I don't think it's going to be removed in any future Windows release. I am currently playing with HTA(s) on my Windows 10 (1703) machine.
HTA(s) can have access to the machine (the "this program can make changes to your PC" YES | NO dialogue)
HTA(s) can run scripts that can do native things, like modifying the registry, file system IO operations, etc..
it uses the default Internet Explorer of the Windows installation. to render and run the scripts of the "*.hta" file in the HTA Host (C:\Windows\SysWOW64\mshta.exe).
HTA(s) run Javascript (JScript) scripts and VB scripts in Internet Explorer compatibility mode.
in IE compatibility mode (IE 8) I believe you are restricted to EcmaScript 3. but transpilation can help with that. bebel and the Typescript transpile to ES3, Typescript even transpiles the async/await ES6 feature to ES3.
according to my research HTA(s) scripts can call .NET dlls and powershell and any program from shell.
I think we can make a bridge to Node.js with that capability. think of Edge or the cross platfrom .NET Core Javascript Services Library
I know its IE, every web developer's nightmares, but we can polyfill everything in it.
this will solve Electron's issue of installing Chromium with every Electron App on Windows.

Sounds good, but Microsoft already has a replacement for it and its called UWP.

UWP apps use the Windows Runtime, a native API built into the operating system. This API is implemented in C++ and supported in C#, Visual Basic, C++, and JavaScript. Some options for writing apps in UWP include:

XAML UI and a C#, VB, or C++ backend
DirectX UI and a C++ backend
JavaScript and HTML

This option will be better IMO because you can distribute your app from the windows store and also will support other platforms.

PC, tablet, phone, Xbox, HoloLens, Surface Hub and more

So building around a legacy library will make harder to maintain in mid/long term.

Windows Support discussion is happening on #6

Yes, I think using new APIs described by @norman784 would be the more future-proof choice. (Also because working with legacy Win32 APIs sounds scary... I used to write DirectShow-based code a decade ago and still have nightmares ;))
Further discussion can go into #6 I think?

It's possible to use a hack to get IE 11 support -- if within the .hta file you navigate to an .html file, the latest IE (not Edge) will be used. https://stackoverflow.com/a/50495897


Cartographer compatibility fix and Odometry frame drift fixes

I would like to address fixes I made when utilising this autonomous exploration algorithm in a project with a real-life robot and LiDAR:

Using Cartographer with this exploration algorithm

For those who are attempting to use Cartographer instead of slam_toolbox, Cartographer operates differently in the sense that it builds up obstacle boundaries on the map based on confidence levels (percentage), hence why you see obstacles grow and fade in Rviz when you use Cartographer. This causes issues since this codebase requires a bitmap of 0s and 1s, and Cartographer requires scans of a certain object for a long time before it has 100% confidence of the object existing. This leads to the algorithm never being able to discover new frontiers.
FIX: If you want to use Cartographer because your LiDAR or setup does not work well with slam_toolbox, then you should create a ROS package which remaps the /map topic published by Cartographer to a /remap topic, and supply the /remap topic to this algorithm. The ROS package should operate on logic similar to: "If Cartographer's confidence level of this obstacle is >50%, then map it as a 1, otherwise map it as a 0".

Odometry frame inaccuracy

In Turtlebot simulation, everything is usually ideal, so data such as the odometry frame is perfect without drift. In real life, the odometry frame might drift, instead it is used as a relative reference by the base_link of the robot to achieve localisation of the robot's position in the map (tf_tree: map -> odom -> base_link). Supplying the odometry frame to this algorithm will lead to issues where the robot thinks that it is out of the map boundary, or that it is already in a wall. This was found out when I attempted to write my own bitmap-based frontier exploration algorithm because I couldn't get this algorithm to work.
FIX: Instead of providing your /odom topic to the algorithm, attempt to extract your base_link frame and publish it as a /base_link topic. Usually this frame is not extractable, but you can find it by taking the /map topic and applying the transformation of map->base_link, since the transformation is usually exposed and extractable. Then, providing the base_link frame in replacement of the odometry frame to this algorithm will allow the frontier exploration to run smoothly.
Hopefully someone finds this helpful!

Thank you for your contribution.


Add link to Aus TS fact sheet; minor rewording

Addresses #87

Thanks for the review and suggestion Boyd. My latest commit should cover it 😸


Use :message_received event to trigger interpret_monitor instead of /./

This change removes the catch-all /./ chat route in favor of using a
:message_received event route to trigger interpret_monitor.

Coverage remained the same at 100.0% when pulling 39102dd1eab3944266f5b99c481bdc0c459fc696 on remove-permissive-regex into 9896e081cf59cd7e69c2421640cc9dea9ef0f4d0 on master.


312 | Burst Balloons | C++

Burst Balloons -
What will change -
Type of Issue -
Please add/delete options that are not relevant.

[x] Adding New Code

Programming Language
Please add/delete options that are not relevant.

[x] C++

Self Check

Ask for issue assignment and wait to get assigned to it before making Pull Request.
Add your file in the proper folder
Clean Code and Documentation for better readability
Add Title and Description of the program in the file

:star2: Star it :fork_and_knife:Fork it :handshake: Contribute to it!
Discord server ✉ - https://discord.gg/CXksGdn
Happy Coding,

The solution for burst balloons is not present I will add the solution, please assign to me

Pls assign the issue to me.

I would like to work on it kindly assign it to me


Renaming Money::equals and Currency::equals to isEquals

Maybe it is only my preference, but every time when I write code, I start typing as isEquals instead of equals. Every time! I think, that it is should be renamed in next major version, like as isZero, isPositive and isNegative

May be is good idea will be add additional method isEquals which will be like alias for equals

I understand your reasoning, though I prefer to have one method for one piece of functionality. If there would have been a completely incorrect chosen name, I might have accepted an alias function for BC reasons. Since that is not the case, I close this issue. Thanks for your suggestion though.


Feature Request:  Implementation of Additional KMS Endpoint - generate_data_key

I was looking to see if there is any plan to implement the generate_data_key endpoint for KMS.
I was trying to use moto in stand-alone server mode to mock the behavior of CredStash (JCredStash to be exact), however upon the putSecret() call in my Java code, I was hit with the following traceback in my logs ending with
File "/usr/local/lib/python3.6/site-packages/moto/core/responses.py", line 295, in call_action
    "The {0} action has not been implemented".format(action))
NotImplementedError: The generate_data_key action has not been implemented

Many other endpoints needed to simulate a local usage of CredStash are available though moto, but we need 3 more to get it working:

generate_data_key
~encrypt~
~decrypt~

~Obviously these don't need to be actually secure since we're just mocking, but it would be extremely helpful to get these up and running.  I don't know if it would be best to just encrypt / decrypt with whatever key is in the store already, or ignore encryption all together and just return the same values that were provided like an echo server for the encrypt/decrypt endpoints.~ Turns out that these are implemented, but the documentation wasn't updated.
I'm willing to take a stab at it myself, but to be frank KMS is still a magic service to me and I'm not quite sure how it works in order to implement mock endpoints that provides anything worthwhile to the masses.

Any update on this? #1555 looks to be stale and I'm also seeing a more recent #2071 out there. Anything I can do to help?

I'll have a look at merging the conflicts this week.

#2071 merged


Set up Netlify Deployment

Description
As we did in the Backend repository, we want to add one click deployment as an option for the react application. This Pull Request will add a netlify.toml file that should enable that, and also add a Deploy button to the README.
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Change status

[x] Complete, tested, ready to review and merge
[ ] Complete, but not tested (may need new tests)
[ ] Incomplete/work-in-progress, PR is for discussion/feedback

How Has This Been Tested?
Tested locally using netlify dev --live.
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] There are no merge conflicts

@TomHessburg This is ready for review now. The Netlify button can't be tested until it's in master due to how Netlify looks for the netlify.toml file, but it should work just fine given that the netlify.toml file itself is sound.


aio cloudmanager:execution:get-step-details should expose action in format accepted by cloudmanager:execution:get-step-log

The (JSON) output of the command aio cloudmanager:execution:get-step-details exposes something like
...
 {
    "action": "Build Image",
    "status": "Finished",
    "startedAt": "February 19, 2021 7:19 PM",
    "finishedAt": "February 19, 2021 7:42 PM",
    "duration": "23 minutes"
  },
...

The action field is not usable as argument for subsequent command aio cloudmanager:execution:get-step-log as that expect values like (build|codeQuality|devDeploy|stageDeploy|prodDeploy|buildImage)
Instead of building a manual mapping table the former command should expose the actionId (next to the action label) which can be used in subsequent commands as argument.

This is intentional -- the JSON/YAML outputs are intended to be alternate renderings of the table.

Just to clarify: I am not proposing to only add it to JSON, also the textual table should have the column actionId. If only the action label is exposed that does not help if you want to call subsequent commands....


add count_blobs example

I wrote this example to see how to page through the results with the next marker. It pages through the results and returns the total count of blobs.
To test it, I ran a create_blobs.rs to populate a container with something more than 5000 results so that it would be forced to page.

It works, but I'm not sure if this is the most ergonomic rust code and would appreciate review and better alternatives. I find the futures 0.1 really hard to deal with and I'm really looking forward to standard futures #140.

I see there is a stream_list_blobs that may be make this easier. See #87.

Very nice! Thank you!


🐞 - Divider in tuiMultiSelectGroup overlaps options if used without label

Playground Link
https://stackblitz.com/edit/angular-21zc5f
Description
Divider in tuiMultiSelectGroup overlaps options if used without label
Also tuiMultiSelectGroup label moved to the right and is not aligned with the divider
Angular version
12.2.16
Taiga UI version
3.25.0
Which browsers have you used?

[X] Chrome
[ ] Firefox
[ ] Safari
[ ] Edge

Which operating systems have you used?

[X] macOS
[ ] Windows
[ ] Linux
[ ] iOS
[ ] Android

Let's improve this example to showcase all possible combinations so screenshot testing covers it:
https://taiga-ui.dev/components/multi-select#datalist


Windows binaries fail to deploy from Travis CI

Due to Windows binaries having an .exe extension, the following line won't match Windows binaries and will fail to deploy them:
https://github.com/japaric/trust/blob/bbeaa9b8282f5faf2a2e276d41e2960082edbd2b/ci/before_deploy.sh#L24
Adding a wildcard glob (such as hello*) is a simple workaround to this problem, but this should be fixed so that it works out of the box :slightly_smiling_face:

Nevermind, this pull request seems to address this issue (while removing a few hardcoded references).

Why was this issue closed ? The problem is still there, and the pull request that fixes it is still pending.


Permissions dialog not working in fragment

Expected behaviour
Actual behaviour
Steps to reproduce
MainActivity permission allow then replace a fragment in activity. From fragment location permission checked with Dexter permission allow dialogue not appeared.
Dexter.withActivity(getActivity())
                    .withPermissions(
                            Manifest.permission.ACCESS_COARSE_LOCATION,
                            Manifest.permission.ACCESS_FINE_LOCATION
                    ).withListener(new MultiplePermissionsListener() {
                @Override
                public void onPermissionsChecked(MultiplePermissionsReport report) {
                    /* ... */

                }

                @Override
                public void onPermissionRationaleShouldBeShown(List<PermissionRequest> permissions, PermissionToken token) {
                    /* ... */
                    // token.continuePermissionRequest();
                }
            }).check();

Version of the library

@sathishmscict I'm using this library in fragments and seems it works ok.
I use Dexter like the following code:
 vButtonCamera.setOnClickListener {             Dexter.withActivity(this.activity)                     .withPermission(Manifest.permission.CAMERA)                     .withListener(permissionListener)                     .check() }
I'm just using Kotlin instead Java, but this.activity in Kotlin is the same as this.getActivity() in Java.

happens to me too..

Expected behaviour
Once denied it will  ask permissions  again and again  until permanently  denied.
Actual behaviour
It is not asking permissions  once denied .
Steps to reproduce
MainActivity permission allow then replace a fragment in activity. From fragment location permission checked with Dexter permission allow dialogue not appeared.
Dexter.withActivity(getActivity())
.withPermissions(
Manifest.permission.READ_EXTERNAL_STORAGE,
Manifest.permission.WRITE_EXTERNAL_STORAGE
).withListener(new MultiplePermissionsListener() {
@Override public void onPermissionsChecked(MultiplePermissionsReport report) {
            if (report.areAllPermissionsGranted()) {
                Toast.makeText(context, "hello", Toast.LENGTH_SHORT).show();
            }

            // check for permanent denial of any permission
            if (report.isAnyPermissionPermanentlyDenied()) {
                // show alert dialog navigating to Settings
                showSettingsDialog();
            }

        }
        @Override public void onPermissionRationaleShouldBeShown(List<PermissionRequest> permissions, PermissionToken token) {
               token.continuePermissionRequest();
        }
    }).withErrorListener(new PermissionRequestErrorListener() {
        @Override
        public void onError(DexterError error) {
            Log.d("Debuger",error.toString());

        }
    }).onSameThread().check();

Version of the library   implementation 'com.karumi:dexter:5.0.0'
I’m  using this in fragment.

@sathishmscict @PalakSDarji can you please fill the issue template properly? We need to know the expected behavior, the behavior you are facing, and the version of the library you are using to be able to understand what's going on. If you could also create an example project on GitHub reproducing the error, that'd be awesome 😃

@pedrovgs : happens to me too....Its happen on Samsung devices

@chihung93 could you please upload any android project reproducing the issue in a simple example? Just a simple empty app where you can reproduce the issue. I'm trying to reproduce it in a new project, but there must be something I'm missing.

@chihung93 : nope, I don't have time to do this anymore, Some device don't get this issue, but Samsung always get this problem....
It's only happening on Fragment and using Samsung device.

My code is the same @sathishmscict , but I have this line token.continuePermissionRequest();
Dexter.withActivity(getActivity())
                    .withPermissions(
                            Manifest.permission.ACCESS_COARSE_LOCATION,
                            Manifest.permission.ACCESS_FINE_LOCATION
                    ).withListener(new MultiplePermissionsListener() {
                @Override
                public void onPermissionsChecked(MultiplePermissionsReport report) {
                    /* ... */

                }

                @Override
                public void onPermissionRationaleShouldBeShown(List<PermissionRequest> permissions, PermissionToken token) {
                    /* ... */
                    token.continuePermissionRequest();
                }
            }).check();

Only happening on Samsung devices @chihung93 ? I don't have any Samsung device to fix this issue at all. Could some external collaborators help us with this? We should first check how to reproduce the error.

I am using dexter in a fragment and it is working in Galaxy S8 (G950F) with android 9. I am not sure if it fails in older Samsung devices. Also I tested with simple and multiple permissions.

It works in my fragment class too...using a samsung s8 device

As we have two confirmations from different years of the library working in Samsung devices I'm closing the issue. Thank you all for your comments and help 😃

I'm facing the same issue permission dialog appears in activity but not working in fragment
Here is the code which I'm using in fragment
Dexter.withContext(getActivity())
                        .withPermissions(
                                Manifest.permission.READ_EXTERNAL_STORAGE,
                                Manifest.permission.WRITE_EXTERNAL_STORAGE
                        ).withListener(new MultiplePermissionsListener() {
                    @Override
                    public void onPermissionsChecked(MultiplePermissionsReport report) {
                        if (report.areAllPermissionsGranted()) {
                            selectImage();
                        } else {
                            Toast.makeText(getContext(), "Please allow permissions", Toast.LENGTH_SHORT).show();
                        }
                    }

                    @Override
                    public void onPermissionRationaleShouldBeShown(List<PermissionRequest> permissions, PermissionToken token) {/* ... */}
                }).check();

when I click on button instead of showing permission dialog
the else statement runs and toast message shows
if (report.areAllPermissionsGranted()) {
       selectImage();
  } else {
       Toast.makeText(getContext(), "Please allow permissions", Toast.LENGTH_SHORT).show();
 }

As we have two confirmations from different years of the library working in Samsung devices I'm closing the issue. Thank you all for your comments and help 😃

If it helps, for some reason you need to delete, recompile and install the app.


liquibase drops logs of raise notices when used with postgresql upgrade

Search first

[x] I searched and no similar issues were found

Description
i have setup liquibase + postgresql
liquibase drops the raise notice/msg/info/exception/log/message if its in given as
basically changelog is like
<changelog label .... >
 --> going to postgrsql file
 whatever we give in raise syntaxes will be dropeed
Steps To Reproduce
simply write a changelog with sqlfile changeset
and give raise notice' messsssage'
or any raise syntax
that gets dropped
Expected/Desired Behavior
raise should get directed to default log feli
Liquibase Version
4.2.19
Database Vendor & Version
postgresql 14.3
Liquibase Integration
No response
Liquibase Extensions
No response
OS and/or Infrastructure Type/Provider
rhel
Additional Context
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR (Thank you!)

Hi @thehealer15, thank you for reaching out to us.
The message will be displayed when Liquibase's log level is set to the equivalent of the raised message's level. So, RAISE EXCEPTION will always be displayed (and will stop the execution), and WARNING, INFO and NOTICE will be displayed with Liquibase's log-level=warn.
For LOG and DEBUG, make sure to set log_min_messages and client_min_messages to the appropriate values, and they will be shown with Liquibase's log-level=info or log-level=fine.
I will be closing this issue as it isn't a bug, but feel free to leave a comment if the problem persists.
Thank you,
Tatiana


Implement and document a triaging process and stale issue process

Issue description / feature objectives
compliance-trestle has many issues with no recent activity or comment interactions. To identify enhancements that are supported by the community and reduce noise in the backlog, I proposed we document our triaging process to include how we manage stale issues. This could help facilitate an asynchronous process and allow broader participation in the process.
Caveats / Assumptions

Valid issues may be closed if they become stale. However, they can be reopened.

Completion Criteria

Implement an automated solution to identify stale issues (e.g. https://github.com/actions/stale or https://github.com/aws-actions/stale-issue-cleanup)
Reach out to community with documentation and plan before closing the issues to give everyone time review any issues
Put automation in place that will close stale issues in an amount of time that is agreed upon in the prior steps

Relates to a process being discussed in #1642


qc_signal_intensity plot merge (line 182) fails on pandas v1.3.0+

This code failed on circleci running pandas v1.3.2 (also tested and failed on 1.3.0) but works on earlier pandas versions (1.2.x).
               qc = pd.merge(left=medians,
               right=percent_failures_hues,
               left_on=medians.index,
               right_on=percent_failures_hues.index,
               how='inner')

something changed in pandas merge function.
https://pandas.pydata.org/docs/whatsnew/v1.3.0.html -- deprecated
possibly related to

Deprecated using merge(), DataFrame.merge(), and DataFrame.join() on a different number of levels (GH34862)
Deprecated merge() producing duplicated columns through the suffixes keyword and already existing columns (GH22818)

the error produced is:

ValueError: Unable to fill values because RangeIndex cannot contain NA

For now, the quick fix is to disallow pandas version 1.3.0 when installing methylcheck. But resolving the merge issue would be a better long term fix.

Currently: methylcheck and methylprep specify using pandas v1.2x-v1.3x to avoid this bug. Hopefully a future version of pandas resolves this and we can open it up.


add health check for load balance servers

This PR introduces a health check mechanism for proxy servers which support configuring probe interval, path, timeout, fail and pass threhold.

Codecov Report
Base: 77.09% // Head: 76.98% // Decreases project coverage by -0.10% :warning:

Coverage data is based on head (c8499bc) compared to base (59cc1a2).
Patch coverage: 79.12% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #857      +/-   ##
==========================================
- Coverage   77.09%   76.98%   -0.11%
==========================================
  Files         108      108
  Lines       12241    12315      +74
==========================================
+ Hits         9437     9481      +44
- Misses       2278     2301      +23
- Partials      526      533       +7

Impacted Files
Coverage Δ

pkg/filters/proxy/server.go
80.85% <64.00%> (-19.15%)
:arrow_down:

pkg/filters/proxy/loadbalance.go
87.14% <84.84%> (-1.86%)
:arrow_down:

pkg/filters/validator/basicauth.go
77.41% <0.00%> (-3.23%)
:arrow_down:

pkg/filters/headerlookup/headerlookup.go
84.61% <0.00%> (-1.40%)
:arrow_down:

pkg/object/mqttproxy/client.go
81.61% <0.00%> (-0.90%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add example to readme for using inside an SQL block

In particular using #{AccountBalance.table_name} in place of account_balances.

This won’t be needed once #7 is implemented and there is an official way to declare dependencies.


Track changes in Unit Test add-in

:heart:
(does this mean the unit-testing add-in in MD will get MS-Test support soon? :stuck_out_tongue:)

@knocte completely unrelated :)

:grimacing: :smile:


Update deepspeed_zero_optimizer.py

Fix for https://github.com/microsoft/DeepSpeed/issues/292

@MikalaiDrabovich  Thanks for fixing this.

@MikalaiDrabovich thank you for your contribution! Can you run our pre-commit formatter (see: https://github.com/microsoft/DeepSpeed/blob/master/CONTRIBUTING.md#prerequisites)? Otherwise the tests are going to fail and we can't merge this PR.


HBASE-23823 Run maven with more than default single thread (--threads…

…=1C)

Patch adds to hbase-personality extras --threads=0.5C. Adds MAVEN_ARGS for when building site with --threads == 0.5C. Then it adds -XX:-MaxFDLimit as flag for surefire forked JVMs so we can up the file count for the jvm.... Or, oops, this seems to be a macosx special so probably won't make a difference. The build boxes are set to 16k. Lets see.

Removed changes to the website generating script.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  7s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
5m 57s
branch-2 passed

+1 :green_heart:
compile
3m 19s
branch-2 passed

+1 :green_heart:
shadedjars
4m 42s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 55s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 26s
the patch passed

+1 :green_heart:
compile
3m 18s
the patch passed

+1 :green_heart:
javac
3m 18s
the patch passed

+1 :green_heart:
shellcheck
0m  4s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
shadedjars
4m 43s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
17m 20s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
2m 54s
the patch passed

_ Other Tests _

-1 :x:
unit
106m  9s
root in the patch failed.

+1 :green_heart:
asflicense
0m 33s
The patch does not generate ASF License warnings.

165m 14s

Reason
Tests

Failed junit tests
hadoop.hbase.master.assignment.TestCloseRegionWhileRSCrash

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1158/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1158

Optional Tests
dupname asflicense shellcheck shelldocs javac javadoc unit shadedjars hadoopcheck xml compile

uname
Linux ae4fe6f6e845 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1158/out/precommit/personality/provided.sh

git revision
branch-2 / 50eaa0293e

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1158/1/artifact/out/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1158/1/testReport/

Max. process+thread count
5934 (vs. ulimit of 10000)

modules
C: . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1158/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.7.0

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  9s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
5m 50s
branch-2 passed

+1 :green_heart:
compile
3m 14s
branch-2 passed

+1 :green_heart:
shadedjars
4m 40s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 52s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 25s
the patch passed

+1 :green_heart:
compile
3m 23s
the patch passed

+1 :green_heart:
javac
3m 23s
the patch passed

+1 :green_heart:
shellcheck
0m  4s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
shadedjars
4m 43s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
17m  8s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
2m 57s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
135m 58s
root in the patch passed.

+1 :green_heart:
asflicense
0m 33s
The patch does not generate ASF License warnings.

194m 43s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1158/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1158

Optional Tests
dupname asflicense shellcheck shelldocs javac javadoc unit shadedjars hadoopcheck xml compile

uname
Linux cf50b659b222 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1158/out/precommit/personality/provided.sh

git revision
branch-2 / 50eaa0293e

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1158/2/testReport/

Max. process+thread count
6363 (vs. ulimit of 10000)

modules
C: . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1158/2/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.7.0

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Back to 6k files. Looking at the console, the -T is not being added to mvn command runs. We're not using patched personality? I can try applying to master branch again.

Running patches here does not insert the -T when mvn runs. Running patches out of JIRA does. Closing this then.


Could you please clarify io.js support

Since much of the community has moved over to io.js, does this project work on it?

:+1:

Right now appmetrics won't install on io.js but it's definitely something I want to get working very soon.

@tunniclm ... let me know if there's anything in particular you need to help get that going. The new Node.js TLS release that we're working towards right now is targeted for early October. It will essentially be io.js + v0.12 so we'll want to make sure appmetrics is updated to support it.

At the moment a pre-built module binary is downloaded at install time, and those are currently available for Node.js 0.10 and 0.12.
With the uplift of the NODE_MODULE_VERSION between Node.js 0.12 and io.js, some additional pre-built binaries will be required for io.js. There were module version changes at 1.0.x, 1.1.x and 2.x so we might support all of those, or just the 2.x line if that's reasonable.

I managed to get something compiled and starting today on the latest io.js version. It's not running perfectly yet due to some behaviour changes related to the V8 APIs -- a missing HandleScope that wasn't problematic for the version on V8 in Node 0.10 or 0.12.

Once we have completed #11 it should be possible to compile from source against io.js for any version that is supported by<EMAIL_ADDRESS>(I have tested io.js v2.3 and v2.5).

Version 1.0.1 provides support for io.js v2.5 and that is documented in the updated README.md.
Since io.js v3 has been released we now need to look at what needs to be done to bring us up to date.


Clean query state

I found a strange like below
const query = Model.query();

(async () => {
  await query.where({ id: 1 });
  console.log(await query.where({ id: 2 }));
})();

expected
will generate select * from table where id = 2
actual
last state generate select * from table where id = 1 and id = 2
Is there any way to get clean query state?

Here's a decent way to achieve this,
const query = Model.query();

(async () => {
  await query.clone().where({ id: 1 });
  console.log(await query.clone().where({ id: 2 }));
})();

Thank you. This is what I'm looking for.
closed by https://vincit.github.io/objection.js/#clone


What to log when logging definitions for complicated datatypes?

When expl3 is given the option log-functions, all declarations (of variables and functions) are logged into the log file.  Most datatypes are rather simple and only use one control sequence, whose definition is logged.  Some are more complicated: messages, keys, coffins, and naturally produce too much output in the log.  For instance, \coffin_new:N \l_my_coffin currently produces
Defining \l_my_coffin on line 0
\l_my_coffin=\box41
Defining \l__coffin_corners_41_prop on line 0
Defining \l__coffin_poles_41_prop on line 0

with of course different numbers instead of 41 and of 0.  This seems too verbose, and it is too tied to the implementation.  That is not good for making tlg files testing what functions/variables a particular package defines (in a way similar to m3expl001.lvt and friends).

I forgot to reference this issue in revisions r5789 and r5790 on the svn, sorry.
Now the lines concerning coffin corners and poles are omitted, while others are kept.  This is based on a general mechanism to omit some of the messages "Defining ...".  I'll mark the issue as closed as there is no other complex datatype to worry about for now, and types defined later can take example on coffins.


Portainer makes queries to GitHub API and hits rate-limits

Before you start please confirm the following.

[X] Yes, I've searched similar issues on GitHub.
[X] Yes, I've checked whether this issue is covered in the Portainer documentation or knowledge base.

Problem Description
I noticed that my IP address is constantly hitting GitHub API limits which in turn breaks my self-hosted GitHub runners.
Turns out the issue is that the Portainer UI keeps calling the Portainer API on every page, and one or many of those calls make a request to GitHub API every single time.
Since the anonymous rate-limits are so low, only 60 per hour, simply using Portainer means completely breaking our CI pipeline.
Expected Behavior
Do not make calls to GitHub API at all, or at least cache the response for a long time.
Actual Behavior
https://www.dropbox.com/scl/fi/wzy37kblh1ut2kwy39ww7/Termius_2024-04-15_18-34-01.mp4?rlkey=155v2q2rytyzcvhl0jlp6dpu8&dl=0
Steps to Reproduce

Open Portainer UI. In my case it was a Swarm cluster opened to an app view
Open a terminal on the same host as Portainer and run curl https://api.github.com/rate_limit
Make a note of "rate": {    "limit": 60,     "remaining": 44,
Simply open the browser again. Portainer refreshes all API requests simply by bringing the window to focus
Run curl https://api.github.com/rate_limit again. You will be missing 1 or more queries from your limit.

I also made a video https://www.dropbox.com/scl/fi/wzy37kblh1ut2kwy39ww7/Termius_2024-04-15_18-34-01.mp4?rlkey=155v2q2rytyzcvhl0jlp6dpu8&dl=0
Portainer logs or screenshots
No response
Portainer version
2.19.4
Portainer Edition
Business Edition (BE/EE) with 5NF / 3NF license
Platform and Version
Swarm 24.0.5
OS and Architecture
Ubuntu 22.04
Browser
Chrome 123
What command did you use to deploy Portainer?
No response
Additional Information
No response

Thanks for flagging this one - I'm discussing with the team.

We've just released 2.20.3 which includes a fix for this - are you able to confirm that this is now resolved?

Closing as completed as a fix was included in 2.20.3.


Configure end-to-end extension testing with Puppeteer

Puppeteer is a JS project for testing Google Chrome. I've done some research on testing extensions with it, and it is possible to run a (non-headless) chrome with an extension loaded, using the --loadExtensions flag. It is not currently possible to run headless chrome with an extension.
You can also interact with the actual UI of the extension by getting the extension ID of the project. Some useful information is found here: https://stackoverflow.com/questions/48089670/detect-and-test-chrome-extension-using-puppeteer

@kyranjamie I'm assigning to you - see the todo list in the connected PR for next steps on this.


Remove Google Ops Agent and install Stackdriver Logging and Monitoring

Waiting for green light from Brett/Nicky...

Nicky requested this be held until am of 17/09/21


fix bug in how modules are resolved

:beer:
Also bumps css-modules-require-hook.

:+1: Thank you!


Invisible filter icon

mantine-react-table version
2.0.0-beta.0
react & react-dom versions
18.2
Describe the bug and the steps to reproduce it
Filter icons are not visible due to --ai-color: var(--mantine-color-white); in light mode, due to inline styling in Mantine. It is visible in dark mode, but not with the wanted blue color --mantine-primary-color-filled.
Minimal, Reproducible Example - (Optional, but Recommended)

https://v2.mantine-react-table.com/docs/examples/basic
Switch to light mode
Filter something
The filter icon is invisible, if you hover over it you can barely see it

Screenshots or Videos (Optional)

Do you intend to try to help solve this bug with your own PR?
Maybe, I'll investigate and start debugging
Terms

[X] I understand that if my bug cannot be reliably reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.

A simple fix is to do the same as MRT_TableHeadCellSortLabel and set color instead of --ai-color.
We could change the file MRT_TableHeadCellFilterLabel.module.css to:
  &[data-active] {
    color: var(--mantine-primary-color-filled);
  }

But I'm not sure if that is the way you would want it to be fixed?

What do you think? @KevinVandy happy to make that PR if you agree.

Yep

As a side question related to this. Is it possible to manually render this icon? I want to render this always, and when clicked toggle the visibility of the column filters. I now have my own button that does this:

But with this button I cannot focus the filter input like the filter icon does.


Virus detected

https://www.virustotal.com/gui/file/49125f4ca5e4da2b2d3ad266d94e1f99b8ab976647b0db3a91344d6ed27360bb?nocache=1

Great response to the issue.
Unfortunately, if you don't message all the vendors who flagged it (at least 4 as per VirusTotal) the files keep getting deleted from the running program causing misbehaviour.
Not quite sure that is the best way to release a software

Sorry for closing without a response, but please read the disclaimer under "Installation" in the docs first. As far as I can tell from the analysis it gave me, the virus detection that was posted in this issue only flags it as malware because it makes some IP calls with the software having not been signed and certified yet (again, please read the note). Please understand that at the moment I only wish to get feedback and suggestions before I fully release it for the Microsoft Store, but by that time I will have the code signed and these flags will be resolved. Thank you for your concern.


Update some chain names

Please update some chain names as listed below:

[x] Watr Network -> Watr Testnet
[x] Watr Network - EVM -> Watr Testnet - EVM
[x] Mangata Kusama -> Mangata X

Version test: https://164f1573.subwallet-webapp.pages.dev/
Validation passed


Flaky test: TestGatewayEssentials

The following failure has been observed in this CI run: https://github.com/Kong/gateway-operator/runs/7970955157?check_suite_focus=true#step:5:3743
        	Error Trace:	/home/runner/work/gateway-operator/gateway-operator/test/integration/gateway_test.go:99
        	Error:      	Condition never satisfied
        	Test:       	TestGatewayEssentials

The test succeeded on a subsequent run without any code modifications: https://github.com/Kong/gateway-operator/runs/7971300586?check_suite_focus=true

Second failure in https://github.com/Kong/gateway-operator/runs/7971753639?check_suite_focus=true#step:5:4631

Saw it again here: https://pipelines.actions.githubusercontent.com/serviceHosts/c81d839e-81ff-4819-b743-a1ded9d25776/_apis/pipelines/1/runs/2022/signedlogcontent/2?urlExpires=2022-08-23T15%3A07%3A15.9979174Z&urlSigningMethod=HMACV1&urlSignature=dMOfZTomyII2r7JIU4YCYXCGryE3qJUzd9BuTsvAY84%3D
After debugging, I'm pretty sure #91 introduced the flake because the 10 seconds we used to wait is not enough now that we're deleting and replacing the DataPlane just before. My suspicion is that a slight rework of the test to allow more time during these steps will be adequate, I'll create a patch.

Saw it again here: https://pipelines.actions.githubusercontent.com/serviceHosts/c81d839e-81ff-4819-b743-a1ded9d25776/_apis/pipelines/1/runs/2022/signedlogcontent/2?urlExpires=2022-08-23T15%3A07%3A15.9979174Z&urlSigningMethod=HMACV1&urlSignature=dMOfZTomyII2r7JIU4YCYXCGryE3qJUzd9BuTsvAY84%3D

Weird URL 🤔 And it says {"count":11,"value":"Uri expired"}

After debugging, I'm pretty sure https://github.com/Kong/gateway-operator/pull/91 introduced the flake because we now delete and try to have the DataPlane re-created during TestGatewayEssentials. I'm going to verify whether the DataPlane is simply not given enough time, OR if it's actually perma-crashed.

Oh, nice. Thanks!

After some debugging, it appears the replacement functionality is flaking. I've temporarily disabled this in https://github.com/Kong/gateway-operator/pull/210 and this issue is prioritized to get this fixed and re-enable the tests before the next release.

Yup, it seems that #207 didn't solve it completely. Another failure: https://github.com/Kong/gateway-operator/runs/7978283717?check_suite_focus=true#step:5:4679

The tests have been temporarily disabled, closing this in favor of https://github.com/Kong/gateway-operator/issues/212 which includes the scope of this and https://github.com/Kong/gateway-operator/issues/199 and will be resolved for the next release.


depth_u16 download problem

Hi, the link you give for downloading depth_u16 is inaccessable.
Can you please give another address ? Thank you so much.

Hi, @JiayiLy .
Sorry that the previous link is invalid. Please download depth_u16 from this new link.

Hi, @JiayiLy .
Sorry that the previous link is invalid. Please download depth_u16 from this new link.


Encountered exception while upgrading prefab

Unity 2019.4.31f1
Installed via new VRCCC (VRChat Creator Companion)
VRCSDK - Base 3.0.8
VRCSDK - Worlds 3.0.8
UdonSharp - 1.0.1
VRChat Client Sim 1.1.4
RadioAsset - tested with Beta16/Beta15/4.4.1
The error I get in the console:
[UdonSharp] Hit exception while attempting to upgrade scene behaviours: System.InvalidOperationException: Cannot run serialization on U# behaviour 'UdonRadioCommunicationDemo (URC.UdonRadioCommunication)' with outdated behaviour version, wait until program assets have compiled.
at UdonSharpEditor.UdonSharpEditorUtility.CopyUdonToProxy (UdonSharp.UdonSharpBehaviour proxy, UdonSharpEditor.ProxySerializationPolicy serializationPolicy) [0x00045] in D:\Unity\CaveAdventureWorld\Library\PackageCache\com.vrchat.udonsharp@26d6812704\Editor\UdonSharpEditorUtility.cs:987
at UdonSharpEditor.UdonSharpEditorUtility.UpgradeSceneBehaviours (System.Collections.Generic.IEnumerable`1[T] behaviours) [0x002f9] in D:\Unity\CaveAdventureWorld\Library\PackageCache\com.vrchat.udonsharp@26d6812704\Editor\UdonSharpEditorUtility.cs:553
at UdonSharpEditor.UdonSharpEditorManager.RunAllUpgrades () [0x0002b] in D:\Unity\CaveAdventureWorld\Library\PackageCache\com.vrchat.udonsharp@26d6812704\Editor\UdonSharpEditorManager.cs:1612
UnityEngine.Debug:LogError (object)
UdonSharp.UdonSharpUtils:LogError (object) (at Library/PackageCache/com.vrchat.udonsharp@26d6812704/Editor/UdonSharpUtils.cs:316)
UdonSharpEditor.UdonSharpEditorManager:RunAllUpgrades () (at Library/PackageCache/com.vrchat.udonsharp@26d6812704/Editor/UdonSharpEditorManager.cs:1616)
UdonSharpEditor.UdonSharpEditorManager:OnChangePlayMode (UnityEditor.PlayModeStateChange) (at Library/PackageCache/com.vrchat.udonsharp@26d6812704/Editor/UdonSharpEditorManager.cs:693)
UnityEditor.EditorApplication:Internal_PlayModeStateChanged (UnityEditor.PlayModeStateChange)
VRC.SDK3.Editor.Builder.VRCWorldAssetExporter:LaunchSceneBlueprintUploader ()
VRC.SDK3.Editor.Builder.VRCWorldBuilder:UploadLastExportedSceneBlueprint ()
VRC.SDK3.Editor.Builder.VRCWorldBuilder:ExportSceneAndPrepareForUpload ()
VRC.SDK3.Editor.Builder.VRCWorldBuilder:ExportAndUploadSceneBlueprint ()
VRC.SDKBase.Editor.VRC_SdkBuilder:ExportAndUploadSceneBlueprint ()
VRC.SDK3.Editor.VRCSdkControlPanelWorldBuilder3:OnGUIScene () (at Library/PackageCache/com.vrchat.worlds@cdd31e9733/Editor/VRCSDK/SDK3/VRCSdkControlPanelWorldBuilder3.cs:252)
VRC.SDKBase.Editor.VRCSdkControlPanelWorldBuilder:ShowBuilder () (at Library/PackageCache/com.vrchat.base@cdd31e9733/Editor/VRCSDK/Dependencies/VRChat/ControlPanel/VRCSdkControlPanelWorldBuilder.cs:130)
VRC.SDK3.Editor.VRCSdkControlPanelWorldBuilder3:ShowBuilder () (at Library/PackageCache/com.vrchat.worlds@cdd31e9733/Editor/VRCSDK/SDK3/VRCSdkControlPanelWorldBuilder3.cs:43)
VRCSdkControlPanel:ShowBuilders () (at Library/PackageCache/com.vrchat.base@cdd31e9733/Editor/VRCSDK/Dependencies/VRChat/ControlPanel/VRCSdkControlPanelBuilder.cs:329)
VRCSdkControlPanel:OnGUI () (at Library/PackageCache/com.vrchat.base@cdd31e9733/Editor/VRCSDK/Dependencies/VRChat/ControlPanel/VRCSdkControlPanel.cs:214)
UnityEngine.GUIUtility:ProcessEvent (int,intptr)
This happens as soon as I put any of your assets into the scene. Just having your pack installed still allows me to publish.
I AM able to do build & test, where your assets work perfectly fine, this only occurs when trying to press build and publish for windows.
My guess is that im using a version of UdonSharp thats changed something. Maybe the one from the VRCCC is special?
Lemme know if theres any additional info you need! When I was testing them through Build & Test they were amazing! Exactly what I was looking for for my world!

The logs indicate that U# assets are not compiled. If you have not installed UdonRadioComunication with the git URL, Compile All UdonSharp Programs may solve the problem. Otherwise, Unity will get fail because it cannot rewrite the assets.
If logs shows prefabs are broken. Then you can build system without any Prefabs, they will maybe works.

This project is still being developed with UdonSharp 0.x. U# 0.x and 1.0 are not compatible. The compiled program should not even work as is. We also observe that most Prefabs are broken. I believe this is due to incomplete conversion on the U# side.
Whenever I install with VCC, it is always installs 1.0. However, VCC is still a test version. The only other way to get 1.0 is private beta, and while it is possible to fully migrate to VCC, I don't know when that should be done.
Finally, I would like to inform you that the feature/usharp-1.0 branch exists. This is an experimental branch. So I'cant promise you to it works completely.

Thank you for the thorough response!
"Compile All UdonSharp Programs may solve the problem."
as far as I could tell, this did nothing at all.
"the feature/usharp-1.0 branch exists."
This however, worked perfectly! I apologize for missing it, I did go through the branches but my eyes must have accidentally rolled off of it.
Thank you for the powerful tool. It is perfect for my exploration-focused world. Great work!


Feature request: possible to use MapTiler custom tiles?

Is it possible to use custom made map tiles from maptiler.com?

No. Only raster tiles.

Not possible for now(

Not possible for now(