[url=http://site/?x=y] is not rendered correctly

The URL tag is not rendered correctly in case the url contains equal signs. Only the part before the first equal sign is passed to the onTap action. For example, [url=http://site/?x=y]  will result in an attempt to launch http ://site/?x
The issue appears to be somewhere in the bbob library, which parses the url into {key,value} pairs.
The following code worked around the issue for me:
class MyUrlTag extends StyleTag {
  final Function(String)? onTap;

  DpcUrlTag({this.onTap}) : super("url");

  @override
  void onTagStart(FlutterRenderer renderer) {
    String url = "URL is missing!";
    if (renderer.currentTag?.attributes.isNotEmpty ?? false) {
      url = "";
      for (var key in renderer.currentTag!.attributes.keys) {
        String value = renderer.currentTag!.attributes[key]!;
        url += value.isEmpty ? key : "$key=$value"; // restore the equal sign
      }
    } else if (renderer.currentTag?.children.isNotEmpty ?? false) {
      url = renderer.currentTag!.children.first.textContent;
    }

    renderer.pushTapAction(() {
      if (onTap == null) {
        dbgPrint("URL '$url' has been pressed!");
        return;
      }
      onTap!(url);
    });
    super.onTagStart(renderer);
  }

  @override
  void onTagEnd(FlutterRenderer renderer) {
    renderer.popTapAction();
    super.onTagEnd(renderer);
  }

  @override
  TextStyle transformStyle(
      TextStyle oldStyle, Map<String, String>? attributes) {
    return oldStyle.copyWith(
        decoration: TextDecoration.underline,
        color: Colors.blue);
  }
}

PR has been reviewed and modified. Waiting for it to be approved.

Upstream has a fix published. Will probably update 'soonisch'

Fixed in the latest release. Thanks for reporting!


Calculation accuracy is not correct

mexp.eval("89*0.11")  -> 9.790000000000001   error
correct :  89*.011 = 9.79

Math in JavaScript is done with floating point arithmetic so this isn't really wrong. If you put this calculation into the console you'll get the same result. Check out https://docs.oracle.com/cd/E19957-01/806-3568/ncg_goldberg.html if you want the details. Getting the answer you want would require using some kind of arbitrary precision math library (BigDecimal/BigNumber things) which is much slower and harder to use.


Upstream syntax files are outdated

runtime/syntax/typescript.vim and other syntax files were upstreamed from this project. They are quite old. Actually they were upstreamed on 2022 and don't seem to be updated since then. Syntax highlighting is not able to follow the syntaxes recently added to TypeScript (e.g. type-only imports). This is the root cause of issues like #276.
@HerringtonDarkholme If you're okay, I can take my time to upstream current syntax files to vim/vim. What do you think? And is there any guide to upstream this project to vim/vim? The syntax files structure look very different from this project actually.

I have already updated merged file in this repo.  https://github.com/HerringtonDarkholme/yats.vim/tree/master/merged
However, AFAIK, vim has modified syntax in their repo without syncing to this one. there might be merge conflict if one directly copies the file to vim repo.

Thank you for updating the merged version files. I'll try to update the upstream based on these files after understanding what changes were added to the upstream files by Bram.

@HerringtonDarkholme I created a PR. Would you roughly review the changes as a maintainer of the syntax files?
https://github.com/vim/vim/pull/14840

Note:
The changes added to the upstream:

g:did_typescript_hilink was removed since it is for compatibility with old Vim
:HiLink custom command was expanded manually to hi def link
g:yats_host_keyword was renamed to g:typescript_host_keyword

The patch was merged. Closing.

@rhysd Thanks!

The changes added to the upstream:
g:did_typescript_hilink was removed since it is for compatibility with old Vim
:HiLink custom command was expanded manually to hi def link
g:yats_host_keyword was renamed to g:typescript_host_keyword

I would also like to introduce these change in yats to keep sync with downstream. I will give it a look when I have time.

@HerringtonDarkholme While resolving review comment in the PR, I noticed that upstream removed the conceals feature. Do you think it should be removed from this repository as well? Or should it be kept?

@rhysd I think the conceals feature can be removed. Since this repo is adopted as vim's builtin syntax, I think it makes sense to make the plugin neutral and less opinionated.


Missing initial Conditions for Modelica.Electrical.Analog.Semiconductors.NPN

Reported by jfrenkel on 6 Jan 2017 12:20 UTC
The attached model evoke in different Modelica compilers missing initial conditions for the model Modelica.Electrical.Analog.Semiconductors.NPN.
If UIC is false there are two missing initial conditions. If UIC is true then one missing initial condition is reported.
This should be fixed to avoid confusion by the users.
A possible solution is to add an parameter to initialize the Variable vbe

Migrated-From: https://trac.modelica.org/Modelica/ticket/2146

Comment by beutlich on 6 Jan 2017 12:31 UTC
Please do also add a description to parameter UIC.

Dymola does not report missing initial conditions for that model in both cases (UIC=true and UIC=false).
Added a description string to UIC in SHA-1: ae6372e926224a5aaeb9893e9c19e504fd481091

Dymola 2018 FD01 reports in pedantic mode for UIC=false:
The initial conditions are not fully specified.
Dymola has selected default initial conditions.

Assuming fixed default start value for the continuous states:
npn1.C.v(start = 0.0)
npn1.vbe(start = 0.0)

and for UIC=true:
The initial conditions are not fully specified.
Dymola has selected default initial conditions.

Assuming fixed default start value for the continuous states:
npn1.vbe(start = 0.0)

but there is no clean way to specifiy the fixed start / initial value for protected state variable vbe.

The initial condiction handling for capacitances need a generally suitable concept. This concerns other models containing capacitances besides the NPN model. We do not prefer a " quick and dirty" solution for this particular ticket. We postpone the ticket until we developed the concept for handlig the initial conditions.

There would be a simple fix to at least allow the user to get rid of this annoying warning. Make vbe unprotected. I don't see this as hack but rather fix.

There would be a simple fix to at least allow the user to get rid of this annoying warning. Make vbe unprotected. I don't see this as hack but rather fix.

The short-term issue was resolved by 5eaf686e024d61533d1095b421fbaeddb084f385, aa6b3d0b66c5bad8d15d86981b691ec34c941618 and 68f6be7ed9dd65c8fffe7e4e0d85c58e69f37640 already for MSL v3.2.3.

We postpone the ticket until we developed the concept for handlig the initial conditions.

The long-term issue will be considered in #3168. It is unlikely that it will be resolved for MSL v4.0.0.

I have some more comments on this issue here as #3168 seems (from the title) not the be right place to put them:

The NPN model contains the following parameters:

parameter SI.Voltage IC=0 "Initial value" annotation(Dialog(enable=UIC));
parameter Boolean UIC = false "Decision if initial value should be used";

The parameter description string of IC states Initial value but it is not clear which quantity this value refers to. Reading the code the initial value IC is the potential of the collector, C.v.

I find it strange the the potential of pin C instead of a potential difference (voltage) is set by the initial condition:

initial equation
  if UIC then
    C.v = IC;
  end if;

Consequently the following circuit is illegal when UIC is true, as the potential of the collector is fixed by constantVoltage2 already.

It does absolutely not make sense to me that such circuit shall not be allowed! This is not only a shortcoming of the model, this is a bug on my opinion.

The three equations related with the transistor currents

  C.i = (ibe - ibc)*qbk - ibc/Br - cbc*der(vbc) + Ccs*der(C.v);
  B.i = ibe/Bf + ibc/Br + cbc*der(vbc) + cbe*der(vbe);
  E.i = -B.i - C.i + Ccs*der(C.v);

show the expression der(C.v) in the first and third line. This does not make sense to me. The parameter description of the capacitance Ccs reads
parameter SI.Capacitance Ccs=1e-12 "Collector-substrate(ground) cap.";

so obviously the corresponding capacitor Ccs is connected between the collector and the substrate which is assumed to have ground potential. It, however, does not make sense to have implicit grounding in the transistor model. Instead a substrate connector shall be added if the effect of the collector substrate capacitance shall be taken into account.
Note: When reading [Vlach1983] I could neither find the capacitance Ccs nor the substrate of the bipolar transistor model, but I may have overseen the corresponding equations and text in the book.

I agree with @christiankral  that the implicit earthing of the component makes no sense unless it has an additional connector that can be set to a certain potential. I suggest to open a new ticket for this.

The included test model is available as Transistor2.mo

It is also odd that UIC/IC are only present in NPN, but not in HeatingNPN. I suggest to remove it then from #3178 where I explicitly added it for backward compatibility yesterday.

It is also odd that UIC/IC are only present in NPN, but not in HeatingNPN. I suggest to remove it then from #3178 where I explicitly added it for backward compatibility yesterday.

I fully agree. Even the NPN and PNP model are not implemented in the same way as only the NPN includes an initial condition. Yet, I think we shall just go ahead with #3178 and merge and then create a different PR handling

the initial conditions
the substrate connector

OK, #3178 is merged with only NPN/PNP left to consider.


Script recorder 8.1

Meta issue to track requirements for each flow below:
Doc

Design doc

Design enanchment

[x] Update header to match new design

Action

[x] Edit an action recorded by the recorder

Assertion

[x] Add a new assertion
[x] Edit an assertion
[x] Delete an assertion

Steps divider

[x]  Add a new step divider
[x]  Rename a step divider
[x]  Collapse a step divider
[x]  Delete a step divider
[x]  Drag and drop a step divider

Replay/test

[x] Replay/Test steps flow

Export script

[x] Export scripts allowing to select between inline/suite script

Copy and content

[ ] Make sure we check the copy and we keep the content consistent

New designs are here
https://www.figma.com/file/6xfG7uIpgc84d62JnXhOMV/Script-recorder?node-id=10%3A45816
I'll try to finalise it asap with the flows that are missing

Btw, as a more general note, I'd suggest that we break this down into multiple issues for each part of the designs so that we can more easily keep track of it. What does everyone think?

@paulb-elastic during our 1:1 last week we have discussed making a gap analysis between the designs and what we have in this issue so that we could add more issues for 8.1 if necessary.
Here's the result of my gap analysis:

Items with a ⭐  indicate I believe we need a new issue for them.

Step layout: As you can see below, the steps in the recorder and the steps on the designs are different, however, I assume that will be addressed as part of the step separators, not just updating the step layout and then adding configurable separators. Therefore, I assume that's fine and we don't need another issue for it.

⭐  Test results: The new test results have a very different appearance from what is currently in the recorder. Currently, they're embedded into the main view. On the designs, they appear on a fly-out. Furthermore, the fly-out contents themselves are also very different. I think we need a separate issue for this.

⭐  Expanding replay steps: In addition to the different layout for test replay results, users can also expand steps on the recorder. Expanding replayed steps is not currently possible. I think we need a separate issue for this.

Editing actions: Editing actions is currently significantly different. However, given we'll do lots of changes to add step separators, I believe we can bundle the new edit layout in them.

⭐  Exporting scripts: Currently, exporting scripts opens a dialog to save the journey's code. On the designs, on the other hand, the journey's code appears within a fly-out from which the user can copy the code. I think we need a separate issue for this.

Thanks for going through this @lucasfcosta.  I agree, it seems those three differences should have separate issues, whereas the other points should be covered elsewhere.  @liciavale, do you happen to already have these three covered elsewhere, or ok for Lucas to create them?

...do you happen to already have these three covered elsewhere, or ok for Lucas to create them?

@liciavale for example, https://github.com/elastic/synthetics-recorder/issues/121

@paulb-elastic @lucasfcosta we have some issues, but some that @lucasfcosta mentioned are missing. I'll create them and link them to this meta

@liciavale can we close this now (with other issues tracking further specific updates)?

Hey @paulb-elastic I'd like to cover the last point about copy and content before closing it.

Yes, we should do it when the last PRs are merged in, I can do it but it also depends on the conversation regarding suites/inline, etc.
I wanted to track it somewhere, I'm ok if we close the issue, I think we should just have this somewhere tho'.

We haven't merged implementations for all of the items described in this issue. I think this issue is more from a design perspective, but if we want to wait until all the work is done for these then the issue should stay open.

Moving onto the 8.2 board

Hello @liciavale, I just wanted to clarify this task in the first comment:

Make sure we check the copy and we keep the content consistent

Does it refer to a functionality copying script content to the clipboard in the Export flyout and making sure the content is as same as the one shown in the flyout preview?


[RUSTSEC-2021-0093][rel-1.3] crossbeam-deque 0.8.0 -> 0.8.1

Motivation
https://github.com/diem/diem/issues/9009
https://rustsec.org/advisories/RUSTSEC-2021-0093
Have you read the Contributing Guidelines on pull requests?
y
Test Plan
existing coverage
Related PRs
(If this PR adds or changes functionality, please take some time to update or suggest changes to the docs at https://developers.diem.com, and link to your PR here.)
If targeting a release branch, please fill the below out as well

Justification and breaking nature (who does it affect? validators, full nodes, tooling, operators, AOS, etc.)
dependency update

Comprehensive test results that demonstrate the fix working and not breaking existing workflows.
existing tests

Why we must have it for V1 launch.
Vulnerability seems real.

What workarounds and alternative we have if we do not push the PR.
Wait for 1.5 roll.

release binaries dependency change summary:
target packages:
  M crossbeam-deque 0.8.1 (transitive third-party, crates.io)
    * version upgraded from 0.8.0
    * (unchanged features: crossbeam-epoch, crossbeam-utils, default, std)

LEC dependency change summary:
target packages:
  M crossbeam-deque 0.8.1 (transitive third-party, crates.io)
    * version upgraded from 0.8.0
    * (unchanged features: crossbeam-epoch, crossbeam-utils, default, std)

LSR dependency change summary:
target packages:
  M crossbeam-deque 0.8.1 (transitive third-party, crates.io)
    * version upgraded from 0.8.0
    * (unchanged features: crossbeam-epoch, crossbeam-utils, default, std)

/land


Decide where to define the "domain types" corresponding to the proto types

See discussion and comment

Structure
I suggest the following structure, based on how the ibc-rs repository handles it:

proto crate: this crate contains the .proto files, as well as the generated versions. It does not contain conversions.

this should probably live in miden-base, or in a repository of its own
this is analogous to ibc-proto-rs

Any type that has an analogous protobuf type defines the conversion to-from the protobuf type next to its definition

ibc-rs example
In the ibc-rs ecosystem, we'll take the ChannelEnd type as an example.

The protobuf definition lives here (this is the generated version, the protobuf definition actually lives in another repository, but we don't need to do that). We call this the "raw" type
The "domain" type lives here, in its separate crate, which has the proto crate as a dependency. The conversion code lives with the domain type here

Benefits of proposed structure
I prefer this system over ours because

The conversion code lives next to the domain type; everything is in one place. Contrast with our conversion.rs module which contains every and all conversions of all types. This makes it much harder to understand how each protobuf type relates to other "domain types" in our system.
You can implement TryFrom<Raw> for Domain where the Error type lives in the domain crate

our current system prevents us from doing this. Specifically, miden-node-proto doesn't have a reference to miden-block-producer, and so cannot implement TryFrom<Raw, Error = SomeErrorTypeInBlockProducerCrate>

A few preliminary thoughts:
I think there are two classes of domain objects: (1) objects defined somewhere upstream (e.g., RpoDigest defined in miden-crypto) and (2) objects defined locally in this repo specifically for the purposes of Miden Node (e.g., AccountInputRecord).
I think for the first class, the conversions have to be in the same crate where the generated protobuf structs are (or at least I'm not sure if we have any other option).
For the second class, I think we have 3 options:

Put domain types into proto crate.
Put domain types into its own crate which depends on proto crate.
Put domain types into specific crates where they are used (e.g., rpc, block_producer).

Currently, I think we have a mix of 1 and 3. To take The example of AccountInputRecord:

The generated type is named AccountBlockInputRecord and is defined in the proto crate here.
A domain type called AccountInputRecord is defined in the proto crate here. This type is used in the block_producer crate.
Another domain type called AccountStateWithProof is defined in the store crate here. This type is used by the store.

I think this situation is not ideal - we should probably pick one approach and stick with it.
In my opinion, options 1 and 2 are fairly close to each other as both of them mean we have a centralized location for defining domain types. For example, we could still keep domain types in the proto crate but improve on the current structure by moving conversion code close to the struct definitions. Specifically, instead of having one big conversions.rs file, we could put conversion code for AccountInputRecord right next to this struct.
So, the main question for me is whether we want to define domain structs in a central place (options 1/2) or have them defined in places where they are used (option 3).
The obvious downside of going with option 3 is that it could lead to code duplication. The potential upside is that it is more flexible (requests/responses could be built in different ways in different places).

One other thing to consider which is somewhat related to this (though, maybe should be its own issue/discussion) - we currently store protobuf-serialized objects in the store's database.
The main benefit is extra efficiency, but it does mean that we treat protobuf types as domain types - which feels odd. So, the question is - should we take a performance hit and translate protobuf objects to domain types before using them in meaningful ways in node components?

I see the domain types really as "really close" to the protobuf version; they only exist to address quirks from protobuf,such as every non-native type being optionally present, but we actually expect them all to be present always. Hence, I don't think we'd need the flexibility that option 3 gives; IMO, there's always only one conversion that "makes sense".
I'm indifferent whether we go with option 1 or 2, assuming we don't dump everything in a single conversions.rs. I'd probably lean towards option 2 though, since it provides a crate-level separation between both kinds of definitions (enabling things like functions accessible to the entire crate that are only useful for either proto or domain type stuff).

If we go with option 1, I wonder if it makes sense to rename the crate to something like miden-node-core and merge it with utils crate. The structure of the new crate could be something like:
├── proto
├── src
│   ├── domain
│   ├── generated
│   ├── utils
│   │   ├── config
│   │   ├── logging
│   │   └── hex.rs
│   ├── errors.rs
│   └── lib.rs
├── build.rs
└── Cargo.toml

IMO we already have the domains clearly defined:

The domain of the servers is the networking, since we use protobuf, the generate code itself are the domain structs.
The code the servers are driving, like the VM and the protocol, have their own domain already, and are on their respective repos like crypto,  miden-vm, and miden-objects.

So a struct like BlockWitness should have gone to miden-objects and there should be a conversion in the protobuf to it. The conversions will always be on the protobuf crate because of the orphan rules that bobbin mentioned.
Another way of saying the above is that protobuf should not have a domain mod.

After the call we just had, my opinion is that the repo structure should look like:
     ┌────────────────────────────── miden-client
     │                                  │
     │                                  │
     ▼                                  │
miden-proto ◄─────── miden-base◄────────┤
     ▲                                  │
     │                                  │
     │                                  │
     └────────────────────────────── miden-node

miden-proto: contains all the proto types that need to be sent over the wire

It is necessary to put all proto definitions in the same place because they have dependencies amongst them (e.g. AccountBlockInputRecord in miden-node depends on AccountId in miden-base)

miden-base: contains the domain types that are shared by both the node and client (and possibly other consumers) - e.g. AccountId

Note: I think we're treating AccountId wrong currently by redefining it in the node. The node should always use AccountId in miden-base, and miden-base should define how it is converted to its protobuf equivalent.

miden-node and miden-client: define the domain types that only they need (e.g. AccountInputRecord).

I'm not sure if miden-client needs to define its own types, but if ever it does, this structure would support it

One thing I had forgotten to consider previously is that some domain types live in miden-base. Therefore, "option 1" doesn't work anymore, because miden-base and miden-client also need access to the protobuf definition to provide the conversion to the corresponding domain type (which they would define - e.g. AccountId for miden-base).
A few notable points:

All conversions then need to be in either miden-base, miden-node and miden-client (next to the corresponding domain type).

They can't be in the miden-proto crate because the miden-proto crate doesn't have access to the domain type definitions anymore.

One big change from our current structure is that miden-base would now be aware that some of its types need to be convertible to a corresponding protobuf version.

I think this makes sense though - the consumers of miden-base need to use protobuf, and so miden-base should provide that capability

@hackaugusto thinks that it will be too painful to make updates that span multiple repos. This is a fair point. The downside of our current approach though is that it is confusing even to us where things should be defined. I'm not sure which is the lesser evil.

I would actually go into the opposite direction and do something like this (which is basically what we have now):
     ┌────────────────────────────── miden-client
     │                                  │
     │                                  │
     ▼                                  │
miden-base ◄─────── miden-proto◄────────┤
     ▲                                  │
     │                                  │
     │                                  │
     └────────────────────────────── miden-node

The main reason for this is that I don't think of protobuf definitions as being a part of the core protocol. That is, if, in the future, we decide to ditch protobuf for anything else, miden-base shouldn't be affected.
I believe that with this structure we can still achieve most of the goals you mentioned. Specifically:

miden-base: contains the domain types that are shared by both the node and client (and possibly other consumers).
miden-proto:  contains all the proto types that need to be sent over the wire.

All conversions between proto types and domain types live here as well.

miden-node and miden-client: define the domain types that only they need.

One question is where miden-proto crate should live. I think for now it is fine to keep it in this repo. In the future, we could actually move it into miden-base repo or create a separate repo for it altogether - but I think now it would create too much inconvenience.

That is, if, in the future, we decide to ditch protobuf for anything else, miden-base shouldn't be affected.

Agreed.
One question remaining for me in this case is: where to put the protobuf definitions of the domain types defined in miden-node and miden-client? miden-proto defines the conversions with miden-base domain types, but it can't do that with miden-node and miden-client. It seems like for miden-node/client we'd need to put the protobuf definitions in miden-proto, and conversions in miden-node/client. So miden-proto would contain some conversions, but not all. Which might be ok?

@bobbinth what is the approach you want me to take for this?

I think there are several things here, and I think we can do them sequentially (but also maybe makes sense to combine some of them):

Move away from storing protobuf messages in the database. This implies that before storing data in the DB (e.g., account ID, digest, etc.), we convert such data to our "native" types (e.g., types defined in or re-exported from miden-base).
Move conversions between protobuf messages and native types into proto/src/domain module. Here, instead of having a single large module, we should split the code up into sub-modules - one per domain type. For example: proto/src/domain/account_id.rs, proto/src/domain/digest.rs, proto/src/domain/block_header.rs etc.
For protobuf messages which do not map to native domain types from miden-base, we define "sister" types which remove Option from relevant fields. Let's take AccountUpdate as an example:

Currently, the generated Rust struct for this message is defined roughly as follows:
pub struct AccountUpdate {
    pub account_id: ::core::option::Option<super::account::AccountId>,
    pub account_hash: ::core::option::Option<super::digest::Digest>,
}

Where accountId and Digest are protobuf messages. The "sister" type for this would be defined as:
pub struct AccountUpdate {
    pub account_id: AccountId,
    pub account_hash: Digest,
}

Where AccountId and Digest are structs defined in miden-base (and Digest is actually RpoDigest defined in miden-crypto and re-exported from miden-base).
This sister type would be defined in the src/proto/domain module and conversions to/from protobuf message type would be defined there as well.
Note that we actually already have a "sister" type for AccountUpdate defined in the store called AccountState. This type would go away once we define the new AccountUpdate type.

Once the above is done, in most cases, response handlers would convert protobuf message types into corresponding domain "sister" types early on, and then rest of the code would deal only with the domain types.
As a part of the above, we may also want to normalize some protobuf message names.
Lastly, and this could be a part of a separate workstream altogether, we could consider merging proto and utils crates into something like miden-node-core (see this comment).

All of the above would probably be done in several PRs and it is also possible that I missed something.

Is this issue likely to be close this week?

@Dominik1999

Is this issue likely to be close this week?

Yes, I'm going to finish work on it today or tomorrow, hope, my changes will be approved.


[RFC] IgnorePlugin filter function should receive more arguments

Feature request

What is the expected behavior?
Currently checkResource (resource, context) is the filter function for IgnorePlugin. I would suggest the filter function should change to checkResource({resource, context, issuer, type}).
What is motivation or use case for adding/changing the behavior?
I have a scenario that if the request is issued from non node_modules and the request is asynchronous (import("./lazy"), require.ensure(["./lazy"]), require(["./lazy"])), I want to ignore it.
How should this be implemented in your opinion?
Change this line from
https://github.com/webpack/webpack/blob/0fa27b62441b8dd36097cd1ddc3e39f83e65aa37/lib/IgnorePlugin.js#L41
to
this.options.checkResource({
  request: resolveData.request,
  context: resolveData.context,
  issuer: resolveData.contextInfo.issuer,
  type: resolveData.dependencies[0].type
})

Are you willing to work on this yourself?
yes

any updates?

type won't work as multiple types are resolved in a single request.

@sokra Could you give some example? Or are you talking about this scenario?
import _ from "lodash";

import("lodash")

How can I ignore all the lazy loading import statement from my app only? I am trying to build a bundle for server side rendering. there is no need to split the lazy chunk because they will not get called or executed in the initial state. So it is safe to ignore them.
I do not want to put the magic comment /* webpackIgnore: true */ because when I build the client side rendering bundle and I have to remove this magic comment.


added maintenance note

Codecov Report

Merging #25 (68da61e) into main (9035efb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   35.00%   35.00%
=======================================
  Files           3        3
  Lines          20       20
=======================================
  Hits            7        7
  Misses         12       12
  Partials        1        1

Impacted Files
Coverage Δ

internal/smee/maintenance.go
0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9035efb...68da61e. Read the comment docs.

#25 Added Maintenance Note

#16 Added Maintenance Note


Support more types from the time crate

From what I noticed in time.rs only the time::OffsetDateTime type is supported by default.
I'd like to implement support for the other following types:

time::Date
time::Time
time::Instant
time::Duration
time::PrimitiveDateTime
time::UtcOffset
time::Weekday
time::Month

Is this something that you'd accept as a PR?

Only Date (like chrono NaiveDate), Time (like chrono NaiveTime) and PrimitiveDateTime (like chrono NaiveDateTime) seem meaningful to me.

@gwenn true, those are the most useful ones. I'll implement only those three. I assume you would find this change meaningful?

Only if FromSql/ToSql implementations behave like the chrono ones.

@gwenn thanks for the heads-up, I'll concentrate on achieving that :)

Fixed with rusqlite version 0.30.0


Discuss on contest rework

Discuss from navbar (facebook like)

Managed on https://github.com/michelcourtade/Pronostics/pull/50


AsmConv1x1U may produce wrong results on gfx803

Test environment:
MIOpen v2.3.0 (commit 869a484)
Tensorflow-rocm v2.1.0
Rocm v3.1
Ubuntu 19.10 (kernel version 5.3.0-45-generic)
Test script:
The test script is based on https://github.com/ROCmSoftwarePlatform/tensorflow-upstream/issues/519
pip install numpy scikit-image tensorflow-rocm efficientnet
wget https://upload.wikimedia.org/wikipedia/commons/f/fe/Giant_Panda_in_Beijing_Zoo_1.JPG
cat <<EOF >test_efficientnet_gfx803.py

import numpy as np
from skimage.io import imread
import efficientnet.tfkeras as efn
from efficientnet.tfkeras import center_crop_and_resize, preprocess_input

model = efn.EfficientNetB0(weights='imagenet')
image = imread('Giant_Panda_in_Beijing_Zoo_1.JPG')
image_size = model.input_shape[1]
x = center_crop_and_resize(image, image_size=image_size)
x = preprocess_input(x)
x = np.expand_dims(x, 0)
y = model.predict(x)
print('Top-10 prediction values:\n', np.sort(y[0])[:-11:-1])

EOF

Results:
Results on CPU (reference):
HIP_VISIBLE_DEVICES=-1 python test_efficientnet_gfx803.py
Top-10 prediction values:
 [0.7587872  0.00835475 0.00720724 0.00413023 0.00402107 0.00319306
 0.00221962 0.0021532  0.00194688 0.00153865]

Results on gfx906 (correct):
HIP_VISIBLE_DEVICES=1 python test_efficientnet_gfx803.py
Top-10 prediction values:
 [0.75878704 0.00835476 0.00720722 0.00413022 0.00402108 0.00319307
 0.00221963 0.0021532  0.00194688 0.00153866]

Results on gfx803 (wrong numbers; each run generates different result):
HIP_VISIBLE_DEVICES=1 python test_efficientnet_gfx803.py
Top-10 prediction values:
 [0.46198544 0.09125268 0.03395936 0.03032065 0.02977441 0.02380551
 0.01966209 0.01934384 0.01164374 0.01030718]

Results on gfx803 disabling 1x1 ASM kernel (correct):
MIOPEN_DEBUG_CONV_DIRECT_ASM_1X1U=0 HIP_VISIBLE_DEVICES=0 python test_efficientnet_gfx803.py
Top-10 prediction values:
 [0.75878704 0.00835476 0.00720722 0.00413022 0.00402108 0.00319307
 0.00221963 0.0021532  0.00194688 0.00153866]

MIOpen v2.2.0 does produce correct results as all ASM kernels were disabled on gfx803.
It seems the problem is related to 1x1 convolution kernel conv_asm_1x1u.cpp and conv1x1u.s, since setting MIOPEN_DEBUG_CONV_DIRECT_ASM_1X1U=0 eliminates this bug. Additionally, I ran the  test with MIOPEN_ENABLE_LOGGING_CMD and dump all MIOpenDriver commands. However, when running each 1x1 convolution individually using MIOpenDriver, none of them fail. I guess this is possibly a memory related bug on gfx803 since the wrong prediction values are different each time.

Thanks for the detailed report. The support for gfx803 we can provide is very limited, so I think we will disable 1x1U asm kernel for a while and fix later, when time permits. We have quite fast new ImplicitGemm kernels so I do not expect notable performance drop.

@atamazov Thank you for looking into this issue!
BTW I dumped all the convolution kernel invocations when running the test script, and filtered out all kernels that are not ConvAsm1x1U.


Update Get-MsolDevice.md

Changes for get-MsolDevice with version <IP_ADDRESS>

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

Line 108: [Error] Restore nuget package W:\df4v-s.optemp\dependentPackages\Microsoft.OpenPublishing.CommonPlugins\packages.config in folder:W:\df4v-s.optemp\packages failed, possibly due to transient errors from nuget servers. Please retry building your content. If the issue still happens, open a ticket in http://SiteHelp. Detailed error:  Errors in packages.config projects     Unable to find version '1.0.149-alpha' of package 'Microsoft.OpenPublishing.CommonPlugins'.       D:\Windows\system32\config\systemprofile.nuget\packages: Package 'Microsoft.OpenPublishing.CommonPlugins.1.0.149-alpha' is not found on source 'D:\Windows\system32\config\systemprofile.nuget\packages'.       https://www.myget.org/F/op-dev/api/v2: Package 'Microsoft.OpenPublishing.CommonPlugins.1.0.149-alpha' is not found on source 'https://www.myget.org/F/op-dev/api/v2'.
Line 290: [Error] Restore dependent packages failed

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

Line 108: [Error] Restore nuget package W:\hjdz-s.optemp\dependentPackages\Microsoft.OpenPublishing.CommonPlugins\packages.config in folder:W:\hjdz-s.optemp\packages failed, possibly due to transient errors from nuget servers. Please retry building your content. If the issue still happens, open a ticket in http://SiteHelp. Detailed error:  Errors in packages.config projects     Unable to find version '1.0.149-alpha' of package 'Microsoft.OpenPublishing.CommonPlugins'.       D:\Windows\system32\config\systemprofile.nuget\packages: Package 'Microsoft.OpenPublishing.CommonPlugins.1.0.149-alpha' is not found on source 'D:\Windows\system32\config\systemprofile.nuget\packages'.       https://www.myget.org/F/op-dev/api/v2: Package 'Microsoft.OpenPublishing.CommonPlugins.1.0.149-alpha' is not found on source 'https://www.myget.org/F/op-dev/api/v2'.
Line 290: [Error] Restore dependent packages failed

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

Line 108: [Error] Restore nuget package W:\4hlh-s.optemp\dependentPackages\Microsoft.OpenPublishing.CommonPlugins\packages.config in folder:W:\4hlh-s.optemp\packages failed, possibly due to transient errors from nuget servers. Please retry building your content. If the issue still happens, open a ticket in http://SiteHelp. Detailed error:  Errors in packages.config projects     Unable to find version '1.0.149-alpha' of package 'Microsoft.OpenPublishing.CommonPlugins'.       D:\Windows\system32\config\systemprofile.nuget\packages: Package 'Microsoft.OpenPublishing.CommonPlugins.1.0.149-alpha' is not found on source 'D:\Windows\system32\config\systemprofile.nuget\packages'.       https://www.myget.org/F/op-dev/api/v2: Package 'Microsoft.OpenPublishing.CommonPlugins.1.0.149-alpha' is not found on source 'https://www.myget.org/F/op-dev/api/v2'.
Line 290: [Error] Restore dependent packages failed

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Does not function properly

Program does not work correctly. Does not correctly playback key inputs. One time it might playback all key inputs correctly & then the next time it will either add or remove inputs. Is not consistent in any way shape or form. I would not recommend anyone use this program because it is not going to function properly & that is extra wear and tear on a pricey console.

Yea it's not perfect it doesn't work 100% of the time on my laptop but support from Komefai has stopped long time ago. On my PC & MANY other peoples it works flawlessly 100% of the time period, even as default with no scripts running.
 You're acting like you paid $100 for it.

would not recommend anyone use this program because it is not going to function properly & that is extra wear and tear on a pricey console.

LOL! Extra wear & tear? Wear & tear on what?? Pricey console?? What are you homeless?  It's cheap as piss & it's over 5 years old the PS4.


Weird behaviour for video on scroll

please check this recording
this is really unexpected behavior.
mtp://[usb:001,033]/Internal%20shared%20storage/AzRecorderFree/2018_09_19_19_13_12.mp4

@eneim  https://drive.google.com/file/d/1mfTkTlPFGxk90P1y4xr1VUBHQsN2UOXO/view?usp=sharing

@Kitlabs Can you send me the xml layout of your ViewHolder, and the Video URL that can reproduce this? via email is fine<EMAIL_ADDRESS>

@Kitlabs really bad your email is filtered to spam ... Check it now.

Okay,thanx @eneim

Hi @eneim ,Any Updates?

@Kitlabs not much. I cannot reproduce the issue on Oreo Pixel XL emulator. Is this 100% happen on your test?

Yes @eneim, i have tested on one plus 3T (oreo),Motorola (oreo) ,Samsung(marshmallow),Redmi(Marshmallow),Sony(Lollipop) ,but the problem is only on oreo

Hi @eneim I hope you'll be looking for the bug

Hey sorry for the lack of comment. Quite time issue. I can only use emulator to verify on Oreo and could not reproduce it yet. I will help create a demo so you can test on it. Maybe somewhere this weekend. (FYI living at UTC +9:00).

yes Please @eneim try to help me out in any way you can,Thank you for the efforts you are doing

@eneim i found a solution ,
The problem was with Surface_type of Exoplayer in xml .Firstly i was using surface_view but now i am using texture_view with hardwareAccelerated true in AndroidManifest.xml  it works :)

The problem still exists with surface_view but still, Thanks for you Time,You can close this issue if you want to.

@Kitlabs Good to hear. Though SurfaceView is superior over TextureView, I highly recommend you to consider this. I acknowledge that changing to use TextureView may help to resolve the issue temporarily, so if it works for you, no problem.
I will keep this issue alive, and still think it would be nice if you can give more information about the issue like: when it happens and how often it happens. I doubt that the issue is so device-depend and I can escalate this to ExoPlayer dev team via their issue tracker to help solving this issue from root.

@eneim The issue with SurfaceView is 100% ,i have tested on multiple oreo devices

@eneim,The problem is solved with surface_view as well :) actually i was missing to make the hardwareAccelerated true in case of surface_view
So the thing is  android:hardwareAccelerated="true" must be there in AndroidManifest.xml for surface_view and texture_view

Please make a note for this in your tutorial,if this is not mentioned Specifically
Thanks

@Kitlabs Thanks. I will take this into account. Having hardwareAccelerated to true will affect battery usage so it should be careful. It is good to know it works well for your app.

I have the same problem.. However, doing hardwareAccelerated = true doesn't solve my problem.
I'm looking into it further, in case any other solution is found. Could you discuss it here?

@anubhavmalik You should create a new issue and describe the behaviour a bit more. I would like to know your current behaviour and your expected behaviour. Also your device you are using for testing, Android version, Toro version, log cat/stack trace if it is available.

@eneim .. Sorry for replying late. Seems like my design was at fault and not the library. There was a part of the consecutive videos overlapping my current video and also while scrolling the player view seemed shaky..
However, it was because in I was having wrap content for height and match parent for width. So, my layout had to be drawn with wrap content at every point causing this issue.
Now, I have started using a more reliable system by using aspect ratios and fixing sizes of my item in the recycler view. That fixed the problem.
Good library by the way man, thanks and cheers! :D


libcaca built with only BMP support?

man cacaview says:

cacaview can load the most widespread image formats: PNG, JPEG, GIF,
PNG, BMP etc.

However, if I try to open a PNG image in cacaview, cacaview says:

Error loading <file>. Only BMP is supported.

Looking at pkgs/development/libraries/libcaca/default.nix, it
doesn't look like any image format libraries are passed to it, and I'm
guessing that the BMP support is built in.
Why is libcaca built with only BMP support, if I'm correct in
guessing that it is?

I suppose just nobody added this dependency.
You could expand this in a pull request.

Note that I reverted the change in master as it causes quite a big rebuild (thanks to gstreamer). It's in staging now and will hit master at some point. Feel free to reopen the issue until it's in master.

Okay, thanks.


CB-6567. Log collection: test anonymization rule regex

add jregex dependeny (to handle perl-like regex)
implement test anonymization rule endpoint
rename TestAnonymizationRulesRequest and TestAnonymizationRulesResponse to TestAnonymizationRuleRequest and TestAnonymizationRuleResponse

Endpoint: 200 success + match, no match -404 (can be different - i do not know), invalid regex: 400
It only tests one rule (not all of them with a new one - reason is, it can match on different ones - so from UI perspective, it should be like a new window if someone want to test a specific rule)

LGTM


ADDING NODES

I am running verge v7.0.0 on both Windows and Mac and I noted I have no nodes running in both wallets.
In the past to solve this problem I used to go to HELP - DEBUG WINDOW - CONSOLE and I had a list of nodes to add, example (addnode xyz.onion add) This method no longer works for me.
I went to https://verge-blockchain.info/peers and tried to add the addresses numeric and alpha-numeric  to the CONSOLE but it didn't work for me.
Is there a way to make that work?
P.S. If this is the wrong area to ask for this type of help kindly let me know where to ask.
Thanks in advance

hi @kevintenda this is the proper place! firstly, adding nodes in the verge desktop wallet, is done by going into help, debug console, and then in the input bar at the bottom, typing "addnode nodename.onion add" (without quotes)
but 7.0.0 is outdated and nodes have been added since then. try 7.4!
https://github.com/vergecurrency/verge/releases
let us know if this works, and we will close the issue. i'll leave this open until you get it resolved =]
cheers

Hello @justinvforvendetta I'll let you know it in a couple of hours.
Regards

Hello @justinvforvendetta I'll let you know in a few hours.
Regards

Hello @justinvforvendetta  is this website   https://verge-blockchain.info/peers  where I get the nodes, right? Or there are others?
Regards

So, I upgraded both desktop wallets in Windows & Mac to V.7.4... went to  https://verge-blockchain.info/peers to get some nodes but in both say null.
Have a look at my screenshot. That is from mac desktop wallet. The other wallet gave me the same result.

Nevermind... Not sure what happened, other than keeping both wallets open for hours every thing is fine now.

the new nodes you added were accepted. if your wallet hasn't been synced for a while, it may take hours for them to do so. glad you're all caught up now! try n open them once a week or so for an hour to keep them up to date =]

Alright.
Have a good Sunday.

thanks! you as well!


Z~FREE^VIDEOS ™Ice Spice Leaked Video On Social Media X Twitter[SBH51K]

30 sec ago, Z~FREE^VIDEOS ™Ice Spice Leaked Video On Social Media X Twitter[SBH51K]

™Ice Spice's latest video has taken social media by storm, captivating viewers and sparking widespread discussions. This young digital creator has garnered significant attention for her engaging content, particularly with her recent Spiderman-themed video that has gone viral. Fans are eagerly searching for where to watch the full video, turning to platforms like Instagram, X (formerly Twitter), and Discord for access.
As the buzz around ™Ice Spice grows, fans are actively sharing their reactions online. The viral success of her video highlights the powerful role of social media in propelling creators into the spotlight.
Thank You

FG

vf

rtrt


Implement CJK support

Due to lack of fonts, current asciidoctor-fopub does not support CJK documents. CJK characters will be rendered as "#" in output pdfs. This is annoy for CJK users.
This pull request fixes the above problem using open source fonts and automatic language detection. To be specific, it implements the following functionalities:

Download and install KaiGenGothic fonts when users request. KaiGenGothic fonts is the ttf version of Adobe Source Han Sans fonts created by akiratw? and released open-sourced. Since they are open sourced by legel owners, there are no copyright problems. Here I use the enhanced version (+bold, +italic, +bold_italic) created by chloerei at https://github.com/chloerei/asciidoctor-pdf-cjk-kai_gen_gothic.
Add static font definitions into the original fop-config.xml. This makes sure the installed fonts is selected and selected by correct names.
Add language detection in fopub to automatically detect and set language code to fop. The detection just scans the input xml for "xml:lang" attributes and default to "en".
Add automatic font switching in fo-pdf.xsl. KaiGenGothic is used for CJK documents and the original fonts are used for other languages. This is done automatically.

I have tested it with README.adoc by setting lang attributes to zh_CN, zh_TW, ja and ko. The chapter titles and figure captions works fine. I use it for full Chinese documents for a while and it just works.
Caveat: The 'fopub' script check and modify fop-config.xml for font path on every invocation. It would be nice if there are other ways to do it. I have tried to use post-install hook but failed. One can still use gradle job to change the font path on first fopub invocation, but I am not quite into gradle. Help is welcome.

@nicorikken @mojavelinux  Would you please review this?

Thanks for asking me for review, because it is sad to see PR's just hanging.
Never having used this package, not clearly understanding the use-case, and not having any experience with CJK language support, I find it difficult to review this.
But, based on your comments and the code, this seems like a good PR:

Proper method for language detection/selection.
Code structure improvement by moving off all the font definitions into a separate source file.

I'm not sure how the other fonts are handled, but I would opt for inclusion of fonts, rather than providing a manual GitHub download to execute. Maybe a proper CJK font-gem is already available, to refrain from writing and maintaining your own downloading solution?
Is there some way to check for CJK fonts present on the system, to prevent having to manually call specific directories?
Another solution might be to load the fonts locally in a specific fonts directory, such that the fop-config.xml can be hardcoded. I don't know if manual edits on the fop-config.xml are needed or are typical, but having dynamically expended content in a file for manual edit can introduce some unexpected behavior for users.
I hope this helps you out for now, otherwise give me another heads up.

Thanks for the comments, @nicorikken. It would be nice to be able to build a seperate CJK font-gem. However, since the font part belongs to docbook-xsl, which does not fit in any gem, I failed to find proper ways to distribute the fonts. The docbook-xsl part is installed by fopub at the first run.
I don't quite like the dynamically expanded @FONTBASE@, either. Maybe I can use gradle to modify it at the first run of fopub. But I don't quite understand the gradle system and specifically how to modify a file as a gradle task. Help is welcome.
For the reviewer, I am afraid may be we have to ask @mojavelinux for help.

I don't want this program to be downloading fonts from unofficial sources, especially since the origin of those fonts isn't even clear.
I'd be okay with the Noto Fonts described here: https://docs.asciidoctor.org/pdf-converter/latest/theme/cjk/#obtain-the-ttf-fonts But I understand more fonts may still be needed. That is just outside the scope of this project. If you need this functionality, fork the project and add it to your own copy.


igluctl: overwrite old jsonpath files with static generate for minor version updates

When I add fields to a schema in a minor version upgrade (1-0-0 to 1-0-1), then run static generate on it with --with-json-paths, a new file will be created in the sql folder to update the table, but the existing jsonpaths file won't be updated/overwritten unless I delete that file first.
Since not having a field in the jsonpaths file will cause a pipeline failure, I think Igluctl should detect minor version upgrades and overwrite the jsonpath file in these cases.
For non-technical users this is a difficult part of the tracking setup process, so I think we should make it as easy/foolproof as possible.

Hey @colmsnowplow, thanks for report. For sure, JSONPaths file must always correspond to Redshift DDL. Correct behavior here would be following:

By default nothing should be overwritten. Notification should be printed if (and only if) there's a significant change in either JSONPaths or Redshift (only later can be checked)
If user provided --force flag - both JSONPath and Redshift DDL must be overwritten.

Did you provide --force flag? If not - then bug lays not in not-overwritten JSONPaths, but in overwritten DDL.
@oguzhanunlu, could you please check if igluctl conforms expected behavior?

Ah I see - no, I didn't use --force this issue looks to be user error then.
For the record it doesn't overwrite the DDL file in this case, it creates a new file (1-0-1), which contains ALTER TABLE statements to be run on the existing table.
I've just tested it, and --force does indeed overwrite the jsonpath file, along with the redshift DDLs. As long as we've followed the correct schemaVer convention for the schemas, this indeed produces the behaviour I'm after.
Thanks for the answer @chuwy!

Thanks Colm, good to know. But did it print a warning that you can overwrite JSONPath using --force flag?

Nope, it simply overwrote the files, with the following  (abridged) output:
File [/Users/xxx/GitHub/com.example-schema-registry/./sql/com.example/event/1-0-0/1-0-3.sql] was overridden successfully (no change)!

Ok, thanks. It means we still have some inconsistencies between desired and current behaviors. @oguzhanunlu, could you test assumptions and create a ticket to fix these inconsistencies.

Sure @chuwy , I'll.

Migrated to https://github.com/snowplow-incubator/igluctl/issues/24


issue with getting all pokemon

Hello, I hope you are well, sorry for the inconvenience it was solved in the new update 1.2.12


ci: Split Experimental tests from Universe tests

Closes #2375
A new workflow has been created to run the experimental packages "x" inside "universe.dagger.io".
This workflow is named test-experimental-universe.yml and its based on test-universe.yml.
The package.json in the "universe.dagger.io" folder has been modified to add another script to only test the experimental packages and the original "test" script now ignores the tests in folder "x".
Main Makefile has been modified to add a new task for this.
After reviewing and merging this PR when all is ready, we need to ensure that in the repo settings, in "Branch protection rules", the "Status checks that are required" does not contain this workflow, so PRs can be merged when this tests fail:

Signed-off-by: piraces<EMAIL_ADDRESS>

@TomChv Thanks for the tips! Just committed the changes 👍

Given the PR #2442 (basically moving everything to a dagger plan), do we still need this?

@samalba From my point of view I think it can be useful in order to not block pull requests that have failed tests from the experimental packages.
Maybe we need to "sync" this behaviour in the new dagger CI plan, having a separate section for the experimental packages which the new workflow will execute.

After the PR #2465, which allows to filter universe tests, I have adapted this PR taking into account the #2442 plan. So this will be need to be ported to the dagger plan as soon as #2442 is complete.
It will make the project to acomplish the original issue and be synced with the current state of the CI.
What do you think @samalba @TomChv ?

The timeout you are getting in the universe tests should be fixed by this: https://github.com/dagger/dagger/pull/2495

Rebasing... thanks!

@piraces I was about to merge and noticed the commits are weird. Maybe the rebase was not done correctly?
If you go to main, do a git pull, then switch to this branch and git rebase main && git push -f it should solve this. At the end, you should only see your own commits in this PR. Let me know if you need help.

Hi @samalba I have squashed all my commits into a single one and rebased from main. I think now its correct.
I have also made some changes in order to "adapt" to the latest CI commit and run the experimental tests with dagger as the universe ones.
I hope this is now correct and ok regarding latest changes 😃


Wifi/WLAN Control

Discussed in https://github.com/timsneath/win32/discussions/223

Originally posted by Carl-CircuitWorx April 26, 2021
WLan control examples to perform
Wlanscan to list availible networks
Indicate current network name and signal strength
Network switching
Think this is the API https://docs.microsoft.com/en-us/windows/win32/api/wlanapi/nf-wlanapi-wlangetavailablenetworklist

Fixed in win32 v2.2.8, @Carl-CircuitWorx.


Fix truncate copy job when WRITE_TRUNCATE in BigQuery batch load

Fixes #24535
Due to a typo the original fix did not take effect. Fixed and added a test.
Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @robertwb
R: @johnjcasey
We may need another cherry-pick because the original fix, marked as 2.45.0 milestone, did not take effect.

We may need to update the comment, as this did not impact the 2.44 release

@johnjcasey it impacts 2.44.0, and also seen in previous releases. Will try to track since when it is introduced.

Run Python_Examples PreCommit


fix: rekor get tlog entry with uuid

Signed-off-by: Asra Ali<EMAIL_ADDRESS>Sign blob w/ search otherwise doesn't work, because the UUID in the response of Rekor now includes a prefix shard UUID.
cc @priyawadhwa

Summary

Release Note

Documentation

Codegen or a rebase issue?

I think an issue with compiling cosign, we might need to update to 1.18:
Error: ../../../go/pkg/mod/sigs.k8s.io/release-utils@v0.7.1/version/version.go:124:25: bi.Settings undefined (type *debug.BuildInfo has no field or method Settings)
note: module requires Go 1.18

I think an issue with compiling cosign, we might need to update to 1.18:

yeah, i'm seeing some problems when i run codegen locally as well. is this because rekor is at 1.18?

I think that sigs.k8s.io/release-util dependency requires 1.18. looks like rekor recently pinned to a specific version of it and updated the go version at the same time -- https://github.com/sigstore/rekor/pull/904

Confirmed this fixes goreleaser:
$ COSIGN_EXPERIMENTAL=1 ./cosign verify-blob   --signature https://github.com/goreleaser/goreleaser/releases/download/v1.10.3/checksums.txt.sig   https://github.com/goreleaser/goreleaser/releases/download/v1.10.3/checksums.txt
tlog entry verified with uuid: 6ad8e71d61e4757a7010ba3d31fca287db1e1e3ecdc09ebaeab317b7974f2581 index: 3045145
Verified OK

@priyawadhwa @dlorenc @hectorj2f sorry this got lost after the golang bump! but this will fix the recent goreleaser issue so I am reviving it.

Once again I have some dep problems... :/

@imjasonh I think I still require go 1.18 https://github.com/sigstore/cosign/pull/2093

You should be able to rebase now!

Updated, thank you!
Note the comment in the dep check: If needed, I'll see if I can split up the sharding package's sharding computation from the stuff that requires Trillian clients.

Actually we need to hold on the trillian dep check I think, cc @vaikas and @mattmoor

Yeah, if this can't be WIP for a little time, I can copy/paste the sharding code with a TODO to remove the copy-paste. LMK

I'd personally prefer to not pull that in as it has caused (well, not Trillian alone, but things with glog and other huge deps. My preference would be (I can't believe I'm saying this ;) ) cut&paste.
When you say it would be wip for little time, what's the actual fix that we would have to do?
But from this PR I don't quite get why we need to comment out the trillian bit, this doesn't seem to bring in new deps added, so I don't understand why we need to remove it.
My second question is just curiousity about leaking the the implementation details (but we don't have to discuss it here) about the trillian that sits behind rekor.

Also, I know folks are sensitive to deps and sizes (I know when I inadvertently pulled in something that had a k8s dep :) )

Or, as @vaikas says, copy and paste sharding.GetUUIDFromIDString into cosign.

Yeah exactly. I could either do this, since it's not complicated logic, but my main idea was to separate these sharding utils from the sharding code that manipulates and requires the trillian log client.
I'll resolve it internally. Before GA we will expose verification libraries with few deps in rekor anyway. And that will supersede all this code.

All set, PTAL. Added tests for all the cases of whether Rekor will return EntryUUIDs or UUIDs to make sure matching occurs correctly.


clients don't end up in the github (monitoring) store.

Would be nice to also see who deleted or adjusted the client information.

Fixed by PR #75


[WIP] Added #1713: Office 365 OAuth2 Authentication

Description
This PR aims to implement OAuth2 authentication for Microsoft Office 365 email notifications. This is in relation to their depreciation of basic authentication from the 1st of October 2022.
Closes #1713
Type of change
Please delete any options that are not relevant.

User interface (UI)
New feature (non-breaking change which adds functionality)
This change requires a documentation update

Checklist

[ ] My code follows the style guidelines of this project
[ ] I ran ESLint and other linters for modified files
[ ] I have performed a self-review of my own code and tested it
[ ] I have commented my code, particularly in hard-to-understand areas
(including JSDoc for methods)
[ ] My changes generate no new warnings
[ ] My code needed automated testing. I have added them (this is optional task)

See https://github.com/louislam/uptime-kuma/issues/1713#issuecomment-1145050167 for details on why this is not required


Fix skip-codecov check in test workflow

I added an extra step in test.yml to optionally disable Codecov in commit e5676993. I believed it was working, meaning that Codecov wasn't running, but that was a false positive; the entire job was actually broken. This commit fixes it.

This seems to be working now - tested with https://github.com/artefactual-sdps/enduro/pull/884/commits/8c53e00a5cae1576d882b1c847bdb14d2dd3c941 (now removed from this branch).
The run logs show that the coverage report step is successfully skipped.


To Do list: list structure

In This Pull Request, I:

Set up a new project with webpack
Created an index.html file
Created an empty To Do List placeholder
Created an index.js file and set an array of some simple to do tasks
Wrote a function to iterate over the tasks array and populate an HTML list item element for each task
Rendered the dynamically created list of tasks in the dedicated placeholder on page load
Created a style.css and set rules for the To Do List

Thank you so much, @mimipeshy :pray:


Error on passing data to functions in 'before', 'after' and 'conditions'

The first example in "Passing Data" section in README gives this error:
Traceback (most recent call last):
  File "/Users/harshit/PycharmProjects/DialogFlow/test.py", line 17, in <module>
    lump.melt(temp=45, pressure=1853.68)  # keyword args
  File "/usr/local/lib/python3.5/site-packages/transitions/core.py", line 227, in trigger
    if t.execute(event):
  File "/usr/local/lib/python3.5/site-packages/transitions/core.py", line 145, in execute
    machine.callback(getattr(event_data.model, func), event_data)
  File "/usr/local/lib/python3.5/site-packages/transitions/core.py", line 460, in callback
    func(*event_data.args, **event_data.kwargs)
TypeError: print_pressure() got an unexpected keyword argument 'temp'

on adding transitions the following way
machine.add_transition('melt', 'solid', 'liquid', before='set_environment', after='print_pressure')

Please read the whole section. That's expected behavior if your callbacks can't all handle arbitrary args and kwargs, unless you set send_event=True in the Machine initializer. Use the second example.

Adding transitions in the way defined above in the second example gives the following error:
Traceback (most recent call last):
  File "/Users/harshit/PycharmProjects/DialogFlow/Transitions/test.py", line 24, in <module>
    lump.melt(temp=45, pressure=1853.68)  # keyword args
  File "/usr/local/lib/python2.7/site-packages/transitions/core.py", line 227, in trigger
    if t.execute(event):
  File "/usr/local/lib/python2.7/site-packages/transitions/core.py", line 145, in execute
    machine.callback(getattr(event_data.model, func), event_data)
  File "/usr/local/lib/python2.7/site-packages/transitions/core.py", line 458, in callback
    func(event_data)
TypeError: print_pressure() takes exactly 1 argument (2 given)


encowl, constableship (logical-conflict)

This pull request was generated by the 'mq' tool

/trunk merge


Con 679 add ami id to the ec2 ami inventory

This work is good, and we should keep it, but I wanted to see the new column in a different composite. I'll leave more info in the ticket.


Added mbs_0158 schema to SR

What is the context of this PR?
Adding schema mbs_0158 to SR
How to review
match with spec file found on trello card:
https://trello.com/c/lKxP2QKJ/0-m

@davecharles @MIslam92 could you check this one again?

@shahi645 i cant review as no docker image?

Its failing to build image because of codacy, will try and make a false push so the codacy might fix itself


Create n queen problem

solution of n  queen problem in CPP

File extension missing
add the file extension @silentkiller18 .
Will verify again just update it.

now u can reveiw

PR accepted @silentkiller18
Successfully merged to HacktoberFest_22  repo.
Need to Star this repo incase not done.
🚀🚀👍


Energy cable is not compatible with ImmersiveEngineering part of the equipment

Crash-report link: https://hastebin.com/qiciculusa.http
Problem:Server crash, Client crash
Minecraft version:1.10.2
Forge version:1.10.2-<IP_ADDRESS>6
Mod version：
LibVulpes-1.10.2-0.1.19
AdvancedRocketry-1.10.2-1.0.19
ImmersiveEngineering-0.10-61
Steps to reproduce the problem:
Use energy cable to connect ImmersiveEngineering Heater.
Energy cable to connect the bucket wheel mining machine to destroy its multi-block structure.

Is this still a issue? Please comment if it is and i will reopen if if you are unable? We are closing old issues to see what is still relevant and needs to be fixed.

This should no longer be a problem anymore since cables are deprecated.


Add [MMWB telegram wallet bot] #exchange #wallet GBSNN2…D7CMMW

Address: GBSNN2SPYZB2A5RPDTO3BLX4TP5KNYI7UMUABUS3TYWWEWAAM2D7CMMW
Tags: exchange wallet
Title: MMWB telegram wallet bot
Requested by @attid

https://t.me/MyMTLWalletBot

Hello @attid,
What is the use of this bot wallet that you believe should be tagged on the Stellar Expert database?
Your BOT asks for Private Keys (suspisious unless you have openly posted the coding for your BOT) and it offers to create a wallet (it would be possible to then know the user keys) Is that a Stellar Wallet or just with your BOT and MTL system? It doesn't seem to be part of the Stellar system since you state that you have the right to close the wallet if it is inactive for over 6 months (That seems extremely centralized and controlling)
Looking Towards the future with you,
Rob

Hello @attid,
This issue is being closed. Please feel free to reopen it if you have new information.
Looking Towards The Future With You,
Rob


Update Theme: SuperPins

Added compatibility with Zen's a35 Update

Fixed margins
Fixed grid layout
Fixed "Hide separator line" option
Removed align with navbar
Changed compact mode option to only decrease gap between pins instead of making them smaller too

Added option to disable SuperPins Layout

Added option to disable max height of pinned tabs container

Increased version to 1.3.0

Pls dont merge yet

Ready to merge!

Ready to merge!

Ready to merge!

Ready to merge!


Migrate workbox-webpack-plugin to TypeScript

Placeholder to track the migration.

Is there any update on the state of the migration in this repo?
I'd be more than happy to help, and submit a PR or two migrating packages to TypeScript. Just point me in the right direction :)

Is there any update on the state of the migration in this repo?
I'd be more than happy to help, and submit a PR or two migrating packages to TypeScript. Just point me in the right direction :)

Not for workbox-webpack-plugin at this time.
I am in the middle of migrating workbox-build to TypeScipt (#2477, WIP code at https://github.com/GoogleChrome/workbox/compare/wb-build-ts). That is a more involved migration, as it's also going to including switching from joi to something like https://github.com/gristlabs/ts-interface-checker or https://github.com/pelotom/runtypes to use the TypeScript parameter definitions as the source of truth for runtime option validation.
Once #2477 is complete, I think the workbox-webpack-plugin migration should be more straightforward. If you're looking to contribute at that point, that would be great!

Not for workbox-webpack-plugin at this time.
I am in the middle of migrating workbox-build to TypeScipt (#2477, WIP code at https://github.com/GoogleChrome/workbox/compare/wb-build-ts). That is a more involved migration, as it's also going to including switching from joi to something like https://github.com/gristlabs/ts-interface-checker or https://github.com/pelotom/runtypes to use the TypeScript parameter definitions as the source of truth for runtime option validation.
Once #2477 is complete, I think the workbox-webpack-plugin migration should be more straightforward. If you're looking to contribute at that point, that would be great!

Sounds good!
Like I said, I'd be more than happy to help with the migration, not only for workbox-webpack-plugin, but for other packages in this repo as well. Anything you need help with, especially if it has to do with migrating to TypeScript, just let me know :)

Sounds good!
Like I said, I'd be more than happy to help with the migration, not only for workbox-webpack-plugin, but for other packages in this repo as well. Anything you need help with, especially if it has to do with migrating to TypeScript, just let me know :)

I see #2477 was merged recently 🎉.
Is there any work currently being done to migrate workbox-webpack-plugin to TypeScript?
If not, I can take a look at it over the weekend, get something started :)

Thanks for following up on your initial offer!
Feel free to take a look, and even if you're not able to fully take this on, I'm happy to continue a WIP PR at some point.
The nuance of incompatible webpack v4 and v5 types is an interesting problem... I'm going to ask some colleagues if they have ever run into similar problems. I wonder if adding in explicit devDependencies on both webpack-v4 and webpack-v5 and then explicitly importing both of their exported types, along with some conditional casting, would end up being a path forward.

Is there any update on this?
The typings published for the webpack plugin is old and I think is incomplete as well.
I am making a custom plugin for angular and while it works in practice, the only problem is that typescript keeps complaining so I have to silence it.

Sorry, I haven't had the time to push this forward on my end...
If anyone is interested in taking the helm on this and continue with my base branch, you are more than welcome.
Otherwise, I'll try and find the time to work on it

@tropicadri from the core Workbox engineering team is actively working on getting the open PR cleaned up: https://github.com/GoogleChrome/workbox/pull/2882

The PR is ready for review. It should be live relatively soon.

This is released as part of https://github.com/GoogleChrome/workbox/releases/tag/v6.5.0


Sincerely ask you a question

Hello, I am a developer exploring GEC. May I ask if this tool can summarize errors? I have now implemented a method to obtain errors and correct sentences, but I am unable to obtain the reason for the error

Hello, the answer is No.
GECToR is a model for just correcting errors and cannot explain why.
While it may be possible to analyze the tokens associated with errors through analysis such as Attention, I do not believe there are any research.
I'm sure there are several studies that are similar to your interests (these are not related to GECToR):

Enhancing Grammatical Error Correction Systems with Explanations
https://aclanthology.org/2023.acl-long.413/
Controlled Generation with Prompt Insertion for Natural Language Explanations in Grammatical Error Correction
https://arxiv.org/abs/2309.11439

Hello, the answer is No.您好，答案是否定的。 GECToR is a model for just correcting errors and cannot explain why.GECToR 是一个仅用于纠正错误的模型，无法解释原因。
While it may be possible to analyze the tokens associated with errors through analysis such as Attention, I do not believe there are any research.虽然可以通过诸如Attention之类的分析来分析与错误相关的标记，但我不认为有任何研究。
I'm sure there are several studies that are similar to your interests (these are not related to GECToR):我敢肯定有几项研究与您的兴趣相似（这些与GECToR无关）：

Enhancing Grammatical Error Correction Systems with Explanations通过解释增强语法纠错系统
https://aclanthology.org/2023.acl-long.413/
Controlled Generation with Prompt Insertion for Natural Language Explanations in Grammatical Error Correction在语法纠错中对自然语言解释进行提示插入的受控生成
https://arxiv.org/abs/2309.11439

Thank you for your answer and providing information. I will take a closer look at this research


Complete publishing pipeline for MacOS, Linux, .NET Core

We had to modify the pipeline to get around some errors that we were having with dotnet publish. The workaround involved adding a <runtimeIdentifier> to each of the .csproj files, which definitely isn't what we want long term.
Might be due to dotnet/sdk#10902, but needs more investigation.

@daalcant It looks like if we leave off self-contained entirely but publish with a runtime identifier, it just works. Not sure why this was failing before. Could you try generating a full set of releases?


Support for CREATE TABLE table AS select_statement?

I think this is a feature request, but does Kysely support creating a new (potentially temporary) table from a select statement?
This feature seems to be supported by the major databases; MySQL, PostGres, Sqlite.

Sounds like a good addition 👍. Let's add it.
The API would be:
db.schema
  .createTable('new_table')
  .as(db.selectFrom('person').select(['id', 'first_name']))

hi, can i try to work on this?

@LeoOmori Go ahead, good luck! If you have any question, feel free to post in the contribution channel on discord.

Hi all, there's no activity since september so I'd like to work on this issue.
@LeoOmori please ping me if you started to implement something and I have to stop :)


Add --shrink-pdf option, using ghostscript to shrink the PDF file

This change is

Is there any way we could pipe the output of the original pdfmaker into the input of the ghostscript one and never have to create the huge PDF file? This might actually make it faster to generate a shrunk PDF than a big one, instead of slower, as well as reducing the chance of running out of disk space. (This would thus be an alternative to JohnH's idea of having a separate process for shrinking...no point in that if a pipe makes it FASTER to shrink immediately.)

Review status: 0 of 4 files reviewed at latest revision, 3 unresolved discussions.

Comments from Reviewable

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, 6 unresolved discussions.

src/ConversionOrder.cs, line 73 at r1 (raw file):

-shrink-pdf

I don't see a change to use this. Are we going to default to setting it always? Otherwise, how do we determine when?

src/ConversionProgress.cs, line 26 at r1 (raw file):

			InitializeComponent();
			_progressBar.Maximum = 100;
			_progressBar.Style = ProgressBarStyle.Continuous;

I'm confused about this change. Doesn't this make it just move across without regard to setting the percentage? Yet I see other parts which are setting the percentage. Or is this a different progress bar?

src/GeckofxHtmlToPDFComponent.cs, line 586 at r1 (raw file):

17

Is this a magic number? Or a holdover from testing a specific book? Same for the 9 below.

Comments from Reviewable

The original process is using the mozilla code, which is going to a file.   (We're highjacking the "print" processing of the browser to get the pdf file.)  There's no option that I see for sending the output to stdout instead of a file.  I also don't know if ghostscript can take input from stdin, although that may be likelier.

Review status: all files reviewed at latest revision, 6 unresolved discussions.

src/ConversionOrder.cs, line 73 at r1 (raw file):
Previously, andrew-polk wrote…

-shrink-pdf

I don't see a change to use this. Are we going to default to setting it always? Otherwise, how do we determine when?

This is only the auxiliary program implementation.  Bloom changes remain to be done.

src/ConversionProgress.cs, line 26 at r1 (raw file):
Previously, andrew-polk wrote…
I'm confused about this change. Doesn't this make it just move across without regard to setting the percentage? Yet I see other parts which are setting the percentage. Or is this a different progress bar?

The style changes the bar to move smoothly, reacting to each progress setting rather than in big blocks that don't change as often.  The default on Windows seems to be Continuous, but not on Linux.

src/GeckofxHtmlToPDFComponent.cs, line 547 at r1 (raw file):
Previously, hatton (John Hatton) wrote…
Can you change this allow us to ship the necessary GS files with Bloom, rather than as a separate install?

See my comment in BL-3271 as to why I don't think it's feasible to ship GS with Bloom.  It's mostly (but not entirely) a licensing issue.

src/GeckofxHtmlToPDFComponent.cs, line 574 at r1 (raw file):
Previously, hatton (John Hatton) wrote…
How long does this take? If it's not, like, instant, then this feature would be better as a separate process, probably called from Bloom. I say that because we could just not do it until you ask Bloom to Save the PDF.  Same goes for CMYK conversion.

It's certainly not instant if you have a large file with a lot of jpeg images.  But it's faster than creating the file to begin with.
To test this, I've rewritten the code to exist inside Bloom and be triggered at Save PDF.  For a book with 50 JPEG photos (each on a separate page), creating the book on my desktop Linux machine took about 64 seconds.  It then took about 17 seconds to display the PDF file.  (timed with second hand on wristwatch)  Shrinking the file on save took about 13 seconds.
original PDF file = 686,218,495 bytes, compressed PDF file = 27,159,318 bytes
If I used this code in the BloomPdfMaker program, then creating and shrinking the file took about 76 seconds (roughly the sum of the times given above), but displaying the program took only 1-2 seconds.  So the user could see the PDF displayed just as soon or a even a couple of seconds sooner if we shrink in the process of creating the file.
My conclusion is that we should do the shrinking in the BloomPdfMaker program.

Comments from Reviewable

Review status: all files reviewed at latest revision, 6 unresolved discussions.

src/ConversionOrder.cs, line 73 at r1 (raw file):
Previously, StephenMcConnel (Steve McConnel) wrote…
This is only the auxiliary program implementation.  Bloom changes remain to be done.

Wow. Somehow I failed to realize this was in geckofxHtmlToPdf

src/ConversionProgress.cs, line 26 at r1 (raw file):
Previously, StephenMcConnel (Steve McConnel) wrote…
The style changes the bar to move smoothly, reacting to each progress setting rather than in big blocks that don't change as often.  The default on Windows seems to be Continuous, but not on Linux.

Ah. Thanks for clarifying.

Comments from Reviewable

Review status: all files reviewed at latest revision, 4 unresolved discussions.

src/GeckofxHtmlToPDFComponent.cs, line 586 at r1 (raw file):
Previously, andrew-polk wrote…

17

Is this a magic number? Or a holdover from testing a specific book? Same for the 9 below.

It's the length of one of the matched strings.  I'll do something to clarify it.

Comments from Reviewable

Review status: all files reviewed at latest revision, 4 unresolved discussions.

src/GeckofxHtmlToPDFComponent.cs, line 586 at r1 (raw file):
Previously, StephenMcConnel (Steve McConnel) wrote…
It's the length of one of the matched strings.  I'll do something to clarify it.

Ah. I got confused thinking it was a page index rather than a string index. Obviously I didn't look at the algorithm in detail. : )

Comments from Reviewable

Review status: all files reviewed at latest revision, 4 unresolved discussions.

src/GeckofxHtmlToPDFComponent.cs, line 574 at r1 (raw file):

27,159,318
I would say that in some ways it would be better to have the CMYK output available for viewing in the PDF immediately so that the user can check that the colors look generally okay.

Comments from Reviewable

Regardless of whether this code is executed immediately after creating the original PDF file or delayed until saving the PDF, I think it works better as part of Bloom itself.  So I'm closing this PR.  The code has largely been copied and modified according to the feedback here already.


Is the dead simple task runner literally dead now?

no, just waiting for some feature request or bug report :) start works fine for me, but it seems like no one else uses it a lot...

@deepsweet Which is a pity as it really is how things should be done in 2016!

do you have any suggestions or ideas? existing amount of tasks completely meet my personal needs in all projects.

@deepsweet I think the project needs more awareness and maybe a simple landing page. I will try to promote it wherever I can.

I'm using it and loving the concept. Sexy landing page. Maybe a sample using "tasks" in multiple files etc...
I will promote this when I can as a good "run" tool

I slowly move toward the sexy landing page with some kind of "recipes" section along with a list of available tasks. All the tasks were reviewed (and some of them were completely refactored) last month, so I'll be ready to spend some time for the "website" pretty soon.

it's definitely not, see master branch.


Encountered typeIdOffset not 0? This is your report.

Hi there,
Apktool has intentionally output this error message because we need to find an application in the wild, like the application that sent you to this report.
Please attach the apk / email me (ibotpeaches (at) gmail (dot) c0m) so we can fix this issue.

This warning has been merged into master - https://github.com/iBotPeaches/Apktool/pull/1690. Next release will have it.

Going to close this, I still get notification, but one less bug.

Going to close this, I still get notification, but one less bug.

You like to keep close issues with no fix, what a wonderful developer.

Did I do something wrong or is there something that I can go and fix
assistentce will be appreciated
Let me know
On Sat, 23 Dec 2023, 21:36 El Mehdi, @.***> wrote:

Going to close this, I still get notification, but one less bug.
You like to keep close issues with no fix, what a wonderful developer.
—
Reply to this email directly, view it on GitHub
https://github.com/iBotPeaches/Apktool/issues/1728#issuecomment-1868357433,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APH2FDEDHPI4SEDCFW3MOMLYK46DZAVCNFSM4ERBLQEKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBWHAZTKNZUGMZQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Hello,
I was researching same for purpose of "type id offset" I couldn't find enough resources thus I made my assumption as:
type-id = typeIdOffset + typeIdOnSpecHeader. Then I generated three apks(using my tool) with typeIdOffset = 0, 1, 2 and tested on two devices API-16 (4.3)  &  API-28 (9.0)
Here is my results:

typeIdOffset
API-16
API-28

0
OK
OK

1
OK
fail to load strings

2
OK
fail to load all resources

I am guessing that  typeIdOffset is abandoned by android after some version.
type-id-offset-apks.zip

very interesting - thanks @REAndroid. Guessing the various newer iterations of packing resources became a more optimized approach than type offsetting which was probably part of the sparse era of optimization.

“What does this project look like after it starts? I see this（> Configure project :
Building SNAPSHOT (no .git folder found)
fatal: No names found, cannot describe anything.
） when I run it in IDEA, does it have any impact?”

“What does this project look like after it starts? I see this（> Configure project : Building SNAPSHOT (no .git folder found) fatal: No names found, cannot describe anything. ） when I run it in IDEA, does it have any impact?”

This looks to have nothing to do with typeIdOffset - I don't understand? What is the relevance to this thread?

@REAndroid - Styled strings are the bane of my existence. The spec lies, apps lie, nothing makes sense.

#3588
#2890

In terms of what you are looking for though for compilation - I don't know. I just have to build something to handle disassembly and let aapt2 do the heavy lifting again. Our StyledString class has all the details.


Bugfix

see test results on commit 9f7af61 for bug information

...maybe this is just a bad file?
I'm looking at the stack trace, and on inspecting it through the debugger it really just looks like the payload is the wrong length:

parser.format == 'HHH'

data is three 2-byte ints
-> payload should be a multiple of 6

len(self.payload) == 2477

2477 ≅ 5 mod 6 (in fact 2477 has no prime factors smaller than 30)
-> neither 2, 3 nor 6 divide the payload length

maybe I should ignore this?

This file was recorded with an old school SSS running on the Series 0 processor, FW rev of 19. Lab 2.1 displays the main and DC accel, but shows an error and does not display other channels.
An error like this calls into question the reliability of any other data in the CDB or even the channel.
Would be nice if IDELib could extract data from the other channels, or provide a clearer message about what channel caused the issue, but since we have not seen this issue in a while, I am fine with closing this

sounds good; closing


project application

@todo

[ ] tasks to be done by our team and not the applicants:

[ ] wait for all applications until the weekend of the deadline 2022.04.22-23:00(UTC0)
[ ] watch all application videos received before locking the issue
[ ] lock the issue comments during the weekend after the deadline passed
[ ] evaluate submitted screencasts to choose candidate(s)
[ ] inform and announce chosen candidate(s)

@output :question: list of chosen candidate(s)

@info
1. click here to learn about the trial phase
2. click here to learn about the gig

=> start your application now:
1. post your candidate profile and portfolio, which needs to include:

show your github and twitter profile (make one if you dont have one)
present your portfolio with focus on your outstanding designs and wireframes
(if any) show live apps or websites you made or worked on and what you did
(if any) present github repos you made or worked on and what you did

you can use one of these browser extensions to record the screencast:

e.g. screencastify

https://chrome.google.com/webstore/detail/screencastify-screen-vide/mmeijimgabbpbgpdklnllpncmdofkcpn?hl=en

e.g. loom

https://chrome.google.com/webstore/detail/loom-–-free-screen-and-ca/liecbddmkiiihnedobmlmillhodjkdmb

e.g. vidyard

https://chrome.google.com/webstore/detail/vidyard-free-video-and-sc/jiihcciniecimeajcniapbngjjbonjan?hl=en

2. please scroll to the bottom of this issue and make a comment with your application
3. we will carefully inspect and evaluate all submitted applications

we will watch your recorded screencast presentation
we will study all links you provide
we will discuss with our team
we will make a subjective decision to choose probably only a single candidate

MATTEONE
Background:

My background is comics and graffiti (>15y). I have a Wacom tablet and can draw digital. I also attend conferences like 36C3, RC3 and other ones the last 10 years. But I was not patient enough to learn programming yet. December last year I tried some PHP, MYSQL and JS. What are you looking for exactly?

Hmmm. I am doing more analog work but can I also use digital tools. But to be honest the last time I used CSS was back in 2006... :/

Ayoola Daniel
Background:
I write react and other languages. Including web technologies
Use Figma too
Can basically build out my designs easily
I write js
Got SEO experience too
github https://github.com/dalexz4
dribbble https://dribbble.com/geekydaniel
website https://ayoola-seo.company/

twitter: https://twitter.com/theayooladaniel

Location:
lagos, nigeria

高梓棋 (taiwan)
Background:
I gave a grid work only use grid
My background maybe start with drawing and animation lottie and also uiux design and front-end
github https://github.com/queekao
website https://queekao.github.io/MY-CV/CV.html

https://queekao.github.io/Guideline/guideline.html

Location:
taiwan

Judy Li
Background:

https://github.com/judy50024
https://judylisdesign.myportfolio.com/
I can do raw CSS with SCSS.

My background is generally in art and design, I do painting since my early age and studied jewellery design at universities, I’ve done some graphic design jobs and turned UIUX designer for this recent 2 years.
From 2019 I started to take online courses to learn web development and programming languages, I’m currently focused on front end development and constantly learning.
I see, I’m relatively a beginner so JS frameworks are still pretty confusing to me, besides there are so many to choose
I just finished a frontend bootcamp by this month, am currently unemployed and do some freelancing from time to time.
I had a full-time remote work experience for a Japanese startup before, from 2020/2 to 2021/9 sadly they shut down the business, so I'm looking for my next job
if we can work together i can basically dedicate full time, are you in Europe time zone?
Location:
taiwan

0_0NoOB
Background:
I do have knowledge of CSS, HTML and Javascript I mostly code using the vanilla aspects of these languages with the exception of SASS but I can work in just CSS if it is required. I am adept in the Adobe CS package (Illustrator, Indesign and Photoshop) I also dabble in UI/UX using Figma, my prototyping on UI/UX is not the best since I am still getting use to components and such but I can still contribute if I am needed.
I had a look at the github link, and I realised I need more understanding on how to use github other than just browsing and/or copy, pasting from there really lol.
at the moment I am currently working on an ecommerce site for a family member, so once thats up I will hopefully try to make a more public appearence since most previous clients I had are just hush hush, also another reason I dont generally have portfolio pieces to show, in any case I will keep that all in mind! and if you are asking why I applied here while working on projects is because I have bills to pay and as of now this current project is going to be commission's base so until it''s up and running there wont be any terms of income.
github thing is somewhat confusing to me, I understand a simple make git repository and such but the whole pull and such isn't something I've used, I have done some tampering a few years back using vscode and git requests to install code from git repositories but it's been so long I forgot how that works,
I did get a graphic design diploma, my programming I was self taught and I have been doing this since 2015, but as a freelancer so I have always been on my own. I have a linkedin it's
i am moderator of this design discord server for UX/UI (nirvana group):
it's somewhat more organised than the UI/UX channle since a few mods and I are actively removing spam or try to remove anything that can be considered suspicious. it doesn't appear extremely active, I guess it just hard since it's one of those looking for work and or

dribble: https://dribbble.com/0_0Nathan
linkedin: https://www.linkedin.com/in/mypersonalspacedesigner/
codepen: https://codepen.io/0_0Nathan
take note the simple designs are CSS only interactions taking advantage of the Checkbox hack, no javascript I made them myself, at the time I didnt see anyone that ever made it so I was pretty proud of the designs mysel

Also Adobe designs what are you looking for specificially, my behance does have I think atleast 3 logo design concepts, I have done abit of product and logo designs, even Isometric designs if you want to see?
work samples:

https://media.discordapp.net/attachments/928468374093180940/928671423441031258/MOTH-abstract.png
https://cdn.discordapp.com/attachments/928468374093180940/928671776760795146/kissanime.png
https://cdn.discordapp.com/attachments/928468374093180940/928671777050222672/GTC.png
https://cdn.discordapp.com/attachments/928468374093180940/928671795068928010/The-Fireplace_final_logo_rounded.png
https://cdn.discordapp.com/attachments/928468374093180940/928671836475109467/The-Fireplace_final_logo.png
https://cdn.discordapp.com/attachments/928468374093180940/928672368308678706/Flowers.png
https://cdn.discordapp.com/attachments/928468374093180940/928672368635838494/incompleteISO.png
https://cdn.discordapp.com/attachments/928468374093180940/928672368853917746/discord-profile.png

Location:
south africa

mimi.uxui
Background:
i'm a ux ui designer and a frontend developer, my portfolio is still a work in progress (will be done by 13th of January)
i've been using css since 2018 or 2017
i can play around with flexbox, make grid layouts and media queries also vanilla js
at some point you have to pass by css and vanilla js before jumping to react and css frameworks or sass
because they're the fundamentals and just core
regarding the job advert, i have all these skills and i happen to be proficient haha
i don't see a reason why i'm not a good fit for this
I had my Masters degree in Business Intelligence  in 2020, but along the way of achieving that I realised that it's not for me, I still want a career in IT but just not in that part of the industry, I want to do UX/UI design and coding, to become a UX Unicorn, but specialised in web 3 and blockchain type of industry, simply because it's an undiscovered field, existing and fast growing, nobody knows where it going to go and how far, which is very interesting for me
I worked before as a freelancer, doing mainly design and frontend, I worked as fullstack developer but I quit after 4 months because it was unfulfilling and it didn't align with my goals and career path, then shortly after that, I found a frontend offer, which where i'm still currently doing but i'm planning to quit very soon for the same reason that made me quit my fullstack position
Currently, I live in Algeria and planning to move to Canada in about 5-7 month to pursue a second masters degree in computer science and AI.
I'm still open to other masters but for now, that's what's looking interesting for me

figma: https://www.figma.com/file/At27mskUUiz5SRFLLCTuOt/PORTFOLIO?node-id=0%3A1
github: https://github.com/mimi-uxui-dev
twitter: https://twitter.com/mimi_uxui

Location:
algeria

MD Agency
Background:

linkedin: https://www.linkedin.com/in/donatien-migue/
figma: https://www.figma.com/proto/ZyDJG3k42Knd8PAgc2u3it/Midjamo?node-id=301%3A2
I also use Adobe suite
CSS it's not a problem for me
I am a one person digital agency named MD Agency - sometimes i hire employees
currently i have a client, but looking foe new clients
can be full available between february to august
can provide UX/UI Design service

mail<EMAIL_ADDRESS>pages

https://total-technics.com/
https://staging.beig3.com/en/

behance: https://www.behance.net/miguedonatien
dribbble: https://dribbble.com/MigueDonatien
twitter: https://twitter.com/MigueTsawo
github: https://github.com/migudonatien

Location:
unknown


[Feature] Can the box selection support series custom

What problem does this feature solve?
I drew some rectangles using series custom and need to perform box selection on them. Currently, the toolbox does not support box selection for series custom
What does the proposed API look like?
Hope the toolbox box supports series custom selection

toolbox.dataZoom supports custom rectangles - official demo.
📌 please close issue if problem solved.

@helgasoft What I need is to select some rectangles to obtain the selected rectangle data, rather than filtering. The example you provided is using Zoom to filter data.

oops, you are right - brush selection does not work for custom series.
Demo - custom and scatter brush selection comparison.


One more Provider Mangareader.XYZ

Mangareader.xyz
A provider that's not in your list but almost implemented it (I think so)

They use mangastream's images so I don't think it's that famous
But just to let you know such site exists

Thank you. Will be added in the next update.


chore: improve thorswap streaming logic

Description

[ ] Removes limits from THORSwap streaming swaps (TODO: currently removed from all THORSwaps, add it back for non-streaming.
[x] Improves streaming interval logic for streaming swaps to support L1 pools with no derived_depth_bps
[ ] Adjust streaming interval based on size of swap relative to pool depth
[ ] Add UI explaining to the user that there is no guaranteed minimum on streaming swaps
[ ] Disable custom slippage UI for THORSwap streaming swaps

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[x] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)
Closes https://github.com/shapeshift/web/issues/5536
Risk
TODO
Testing
TODO
Engineering
☝
Operations
☝
Screenshots (if applicable)
N/A

Will await further information from the thorchain team before committing to a path forward here.

@0xApotheosis now that https://github.com/shapeshift/web/pull/5748 went in, do we want to close this?