Dependency resolution ignores the rest repositories except the first one

Hi.
Starting with Gradle 4.3 I have a problem with the gradle-intellij-plugin.
The plugin registers two local ivy repositories here and here. Since Gradle 4.3 any dependency that should be resolved via the second repository fails with the following message:
FAILURE: Build failed with an exception.

* What went wrong:
Could not resolve all files for configuration ':compileClasspath'.
> Could not resolve org.jetbrains.plugins:coverage:2017.2.
  Required by:
      project :
   > Could not resolve org.jetbrains.plugins:coverage:2017.2.
      > inconsistent module metadata found. Descriptor: com.jetbrains:ideaIC:2017.2 Errors: bad group: expected='org.jetbrains.plugins' found='com.jetbrains'
        bad module name: expected='coverage' found='ideaIC'

Here is a project for recreating the issue: https://github.com/zolotov/gradle-intellij-plugin-dependency-issue, just run ./gradlew assemble. The same project works fine on Gradle 4.2.
Is this a problem of the gradle-intellij-plugin? If so, could you point me to what should be changed there, please? Thank you.

Thanks for reporting. This is the expected bahavior (see here). Instead of skipping the failure (artifact not found is NOT a failure) silently, we decide to throw it explicitly.
In your case, I noticed you registered two ivy repos:

Repo1: [Ivy pattern 'file:/Users/zhb/.gradle/caches/modules-2/files-2.1/com.jetbrains.intellij.idea/ideaIC/2017.2/5155889067278eb216234aa0eeb8e1944644624c/ideaIC-2017.2/ideaIC-2017.2-withKotlin.xml']

Repo2: [Ivy pattern 'file:/Users/zhb/.gradle/caches/modules-2/files-2.1/com.jetbrains.intellij.idea/plugins.jetbrains.com/coverage-master-2017.2.xml']

A pattern tells Gradle where to look for ivy files. So the cause is, when you ask Gradle to search org.jetbrains.plugins:coverage:2017.2 artifact, it first tries to access Repo1 and fetch the metadata (ideaIC-2017.2-withKotlin.xml) successfully, which is not correct. Repo1 should tell Gradle, "hey, the metadata you're looking for is not here!" , then Gradle would try the next repository.
To fix this, I'd advice to introduce some pattern. For example, you can register repos as follows:

Repo1: [Ivy pattern 'file:/Users/zhb/.gradle/caches/modules-2/files-2.1/com.jetbrains.intellij.idea/ideaIC/2017.2/5155889067278eb216234aa0eeb8e1944644624c/ideaIC-2017.2/[module]-2017.2-withKotlin.xml']

Repo2: [Ivy pattern 'file:/Users/zhb/.gradle/caches/modules-2/files-2.1/com.jetbrains.intellij.idea/plugins.jetbrains.com/[module]-master-2017.2.xml']

This can make sure Gradle won't fetch the unexpected result.
Please let me know if there's anything unclear.

@bigdaz Since you're an expert on this, I'd like to hear your opinions, are there better solutions?

To fix this, I'd advice to introduce some pattern. For example, you can register repos as follows

Sounds good. I'll try this and will update the issue. Thank a lot!

It works. Thank you. The issue can be closed I think.

Glad to here that!

@blindpirate looks like I still have a problem with this.
If I add two repositories

repo.ivyPattern("$path1/[module]-$channel-[revision].xml") with artifact patter $artifactPath1/[module]-master-[revision]/[artifact].[ext]
repo.ivyPattern("$path2/[module]-$channel-[revision].xml") with artifact patter $artifactPath2/[module]-master-[revision]/[artifact].[ext]

And add two dependencies dependency1 from artifactPath1 and dependency2 from artifactPath2, then dependency2 is tried to be resolved via artifactPath1 (even though it's not defined in the first ivy xml).
I can provide a sample project to recreate this if it's needed.

Reproducible in Gradle 4.3.1

Very sorry for the late response.
Well, I think this is exactly how the repository works. Multiple repositories make up a repository chain then all dependencies would be searched in the chain in turn. You can't say, "I want dep1 to be resolved only in repo1 and dep2 only to be resolved in repo2".
In your case, looks like what you need is not repositories. Instead, would it be better if you register your dependency with files?

You can't say, "I want dep1 to be resolved only in repo1 and dep2 only to be resolved in repo2".

It's ok to me to say "I want dep1 and dep2 to be resolved in repo1 OR in repo2". The problem is that both of them are resolved in repo1 only, which is success for the first one and fail for the second. Why repo1 is even used for dep2 if it's ivy.xml pattern is not matched?
Unfortunately, I cannot use files dependencies because there is no way to attach sources in IDE them.

I'm not sure I follow you. You mean even when the dep2's ivy.xml corresponding to repo1's pattern doesn't exist, repo2 wouldn't be searched?
Pattern is used to locate ivy.xml. For dep2, Gradle will render repo1's ivy pattern with dep2's information and try to search the dep2's ivy.xml with the rendered "pattern". If the target file exists, repo2 wouldn't be attempted. Otherwise, repo2 would be searched in the same way as repo1.
It would be great if you can provide me with a sample project.

@blindpirate while preparing test project I've found a way how both dependencies were matched for the one ivy.xml. Sorry for wasting your time :(

Not at all, feel free to ask whatever you want.
P.S. I'd thank your IDEA, which saved a lot time for me with "Set value" functionality when debugging.


:boom: Introducing CI version 5.0.0

All CI steps for converted 3.0.0 libraries work. The others will be updated soon.


PackedScene with missing file causes crash when set in an Export

Create a node subclass
Create an export of packedScene on that class @Export var packedScene: PackedScene?
Create an scene that uses that subclass
Drag a valid packed scene over to the export location in the Godot editor
Quit Godot
Delete the file which was dragged as a packed scene into the export from disk (or rename or move etc)
Restart Godot

What happens:
Godot crashes with the information at the bottom of this
Expected to happen:
I would expect an PackedScene that has been initialized with a invalid path to ultimately end up returning nil or otherwise being initialized but broken.

Thread 0 Crashed::  Dispatch queue: com.apple.main-thread
0   libsystem_kernel.dylib        	       0x180ad20dc __pthread_kill + 8
1   libsystem_pthread.dylib       	       0x180b09cc0 pthread_kill + 288
2   libsystem_c.dylib             	       0x180a15a40 abort + 180
3   Godot                         	       0x104fa33d8 0x104c28000 + 3650520
4   libsystem_platform.dylib      	       0x180b39a24 _sigtramp + 56
5   libSwiftGodot.dylib           	       0x11094d0a0 lookupObject<A>(nativeHandle:) + 376 (Wrapped.swift:313)
6   libSwiftGodot.dylib           	       0x11094d0a0 lookupObject<A>(nativeHandle:) + 376 (Wrapped.swift:313)
7   libSwiftGodot.dylib           	       0x11095bdf4 Variant.asObject<A>(_:) + 256 (Variant.swift:165)
8   libPlantQuest.dylib           	       0x10ed7c7e0 CharacterModel._mproxy_set_bodyModel(args:) + 128 (@__swiftmacro_10PlantQuest14CharacterModelC04bodyD06ExportfMp_.swift:6)
9   libPlantQuest.dylib           	       0x10ed7eb24 implicit closure #9 in implicit closure #8 in closure #1 in variable initialization expression of static CharacterModel._initializeClass + 4 (@__swiftmacro_10PlantQuest14CharacterModel5GodotfMm_.swift:28) [inlined]
10  libPlantQuest.dylib           	       0x10ed7eb24 partial apply for implicit closure #9 in implicit closure #8 in closure #1 in variable initialization expression of static CharacterModel._initializeClass + 12
11  libSwiftGodot.dylib           	       0x11093ac8c bind_call(_:classInstance:variantArgs:argc:returnValue:r_error:) + 684 (ClassServices.swift:264)
12  Godot                         	       0x108395154 0x104c28000 + 58118484
13  Godot                         	       0x1083c12a0 ClassDB::set_property(Object*, StringName const&, Variant const&, bool*) + 344
14  Godot                         	       0x1083d4c34 Object::set(StringName const&, Variant const&, bool*) + 152
15  Godot                         	       0x1071fa9a0 SceneState::instantiate(SceneState::GenEditState) const + 6328
16  Godot                         	       0x1071fc450 PackedScene::instantiate(PackedScene::GenEditState) const + 36
17  Godot                         	       0x1071f9c40 SceneState::instantiate(SceneState::GenEditState) const + 2904
18  Godot                         	       0x1071fc450 PackedScene::instantiate(PackedScene::GenEditState) const + 36
19  Godot                         	       0x105e263e8 EditorNode::load_scene(String const&, bool, bool, bool, bool, bool) + 3288
20  Godot                         	       0x105e458a0 EditorNode::_load_open_scenes_from_config(Ref<ConfigFile>) + 468
21  Godot                         	       0x105e25574 EditorNode::_load_editor_layout() + 608
22  Godot                         	       0x105e251d8 EditorNode::_sources_changed(bool) + 144
23  Godot                         	       0x1083da2a8 Object::emit_signalp(StringName const&, Variant const**, int) + 520
24  Godot                         	       0x105d73968 0x104c28000 + 18135400
25  Godot                         	       0x105d75c44 EditorFileSystem::_notification(int) + 868
26  Godot                         	       0x1083d4b08 Object::notification(int, bool) + 80
27  Godot                         	       0x10687f728 SceneTree::_process_group(SceneTree::ProcessGroup*, bool) + 232
28  Godot                         	       0x10687db7c SceneTree::_process(bool) + 888
29  Godot                         	       0x10687e194 SceneTree::process(double) + 240
30  Godot                         	       0x104fee468 Main::iteration() + 984
31  Godot                         	       0x104f9fbb0 OS_MacOS::run() + 116
32  Godot                         	       0x104fcdedc main + 304
33  dyld                          	       0x1807890e0 start + 2360

What version of Godot are you using? I can't reproduce this issue on 4.2.1 release. Godot does not let me open a scene with missing dependencies and provides a proper dialog window for fixing them.

What version of Godot are you using? I can't reproduce this issue on 4.2.1 release. Godot does not let me open a scene with missing dependencies and provides a proper dialog window for fixing them.

I am using 4.2.1 but I think you missed my description. The PackedScene is set onto an @Export of my custom SwiftGodot class. It's not in the node tree of the scene.

I think that's what I was trying to do. I have a trivial SwiftGodot class with PackedScene export:
@Godot
final class SomeScene: Node {
    @Export
    var otherScene: PackedScene?
}

and its scene file Scene.tscn:
[gd_scene load_steps=2 format=3 uid="uid://hmmqvij3if3d"]

[ext_resource type="PackedScene" uid="uid://cvyspe7pi4ooy" path="res://OtherScene.tscn" id="1_kkivn"]

[node name="Node2D" type="SomeScene"]
otherScene = ExtResource("1_kkivn")

If I delete OtherScene.tscn and restart Godot, it will throw some errors in the console:
 scene/resources/resource_format_text.cpp:448 - res://Scene.tscn:3 - ext_resource, invalid UID: uid://cvyspe7pi4ooy - using text path instead: res://OtherScene.tscn
  Cannot open file 'res://OtherScene.tscn'.
  Failed loading resource: res://OtherScene.tscn. Make sure resources have been imported by opening the project in the editor at least once.
  scene/resources/resource_format_text.cpp:284 - res://Scene.tscn:6 - Parse Error:
  Failed loading resource: res://Scene.tscn. Make sure resources have been imported by opening the project in the editor at least once.
  editor/editor_data.cpp:626 - Index p_idx = 1 is out of bounds (edited_scene.size() = 1).

and present a dialog allowing to fix missing dependencies.

What if you load your game with that scene in the main file

On Feb 19, 2024, at 12:42 PM, Mikhail Tishin @.***> wrote:
I think that's what I was trying to do. I have a trivial SwiftGodot class with PackedScene export:
@Godot
final class SomeScene: Node {
@Export
var otherScene: PackedScene?
}
and its scene file Scene.tscn:
[gd_scene load_steps=2 format=3 uid="uid://hmmqvij3if3d"]
[ext_resource type="PackedScene" uid="uid://cvyspe7pi4ooy" path="res://OtherScene.tscn" id="1_kkivn"]
[node name="Node2D" type="SomeScene"]
otherScene = ExtResource("1_kkivn")
If I delete OtherScene.tscn and restart Godot, it will throw some errors in the console:
scene/resources/resource_format_text.cpp:448 - res://Scene.tscn:3 - ext_resource, invalid UID: uid://cvyspe7pi4ooy - using text path instead: res://OtherScene.tscn
Cannot open file 'res://OtherScene.tscn'.
Failed loading resource: res://OtherScene.tscn. Make sure resources have been imported by opening the project in the editor at least once.
scene/resources/resource_format_text.cpp:284 - res://Scene.tscn:6 - Parse Error:
Failed loading resource: res://Scene.tscn. Make sure resources have been imported by opening the project in the editor at least once.
editor/editor_data.cpp:626 - Index p_idx = 1 is out of bounds (edited_scene.size() = 1).
and present a dialog allowing to fix missing dependencies.
—
Reply to this email directly, view it on GitHub https://github.com/migueldeicaza/SwiftGodot/issues/398#issuecomment-1953135548, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALK4P2BKHHBS53H3MN6G3DYUO2K3AVCNFSM6AAAAABDLEKKNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJTGEZTKNJUHA.
You are receiving this because you authored the thread.

Same errors, no crash:
W 0:00:00:0412   load: res://Scene.tscn:3 - ext_resource, invalid UID: uid://cvyspe7pi4ooy - using text path instead: res://OtherScene.tscn
  <C++ Source>   scene/resources/resource_format_text.cpp:448 @ load()
E 0:00:00:0412   load: Cannot open file 'res://OtherScene.tscn'.
  <C++ Error>    Condition "err != OK" is true. Returning: Ref<Resource>()
  <C++ Source>   scene/resources/resource_format_text.cpp:1643 @ load()
E 0:00:00:0412   _load: Failed loading resource: res://OtherScene.tscn. Make sure resources have been imported by opening the project in the editor at least once.
  <C++ Error>    Condition "found" is true. Returning: Ref<Resource>()
  <C++ Source>   core/io/resource_loader.cpp:275 @ _load()
E 0:00:00:0412   _parse_ext_resource: res://Scene.tscn:6 - Parse Error: [ext_resource] referenced non-existent resource at: res://OtherScene.tscn
  <C++ Source>   scene/resources/resource_format_text.cpp:163 @ _parse_ext_resource()


[SPARK-28227][SQL] Support TRANSFORM with aggregation.

What changes were proposed in this pull request?
For Spark SQL, it can't support sql like :
SELECT TRANSFORM ( d2, max(d1) as maxd1, cast(sum(d3) as string))
USING 'cat' AS (a,b,c)
FROM script_trans
WHERE d1 <= 100
GROUP BY d2
HAVING maxd1 > 0
But in hive, it can support this kind SQL.
This makes our SQL migration difficult and complex。
This PR is to support use Aggregation with TRANSFORM and make SQL migration from Hive to Sparkeasier.
How was this patch tested?
Added unit test.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@cloud-fan @gatorsmile @HyukjinKwon @jerryshao @wangyum
Hi all, could you help to review this and give some advise.

@dongjoon-hyun
Could you help to review this for me and  can you help me to @ who work on this part

Could we implement ScriptTransformation in sql/core first(SPARK-15694)?

Could we implement ScriptTransformation in sql/core first(SPARK-15694)?

Yea, I agree with @wangyum's. Can we? @AngersZhuuuu

Yea, I agree with @wangyum's. Can we? @AngersZhuuuu

Nowadays  I am doing for support SparkThriftServer to enable proxy client user's authentication and make a PR for master.
#25179
After that, I will focus on this problem.

Can one of the admins verify this patch?

@AngersZhuuuu, let's fix https://github.com/apache/spark/pull/25028#issuecomment-510929154 first. Feel free to open another PR.

@AngersZhuuuu, let's fix #25028 (comment) first. Feel free to open another PR.

It's OK.

@AngersZhuuuu one small regression:
test query:
MAP k / 10 USING 'cat' AS (one) from (select 10 as k);
Results:
with master:
1.0
with this PR:
Exception:
Error in query: cannot resolve '(k / 10)' given input columns: [(CAST(k AS DOUBLE) / CAST(10 AS DOUBLE))];;
This is simplified test case from HiveCompatibilitySuite:
https://github.com/apache/spark/blob/master/sql/hive/src/test/resources/ql/src/test/queries/clientpositive/mapreduce1.q

@AngersZhuuuu one small regression:
test query:
MAP k / 10 USING 'cat' AS (one) from (select 10 as k);
Results:
with master:
1.0
with this PR:
Exception:
Error in query: cannot resolve '(k / 10)' given input columns: [(CAST(k AS DOUBLE) / CAST(10 AS DOUBLE))];;
This is a simplified test case from HiveCompatibilitySuite:
https://github.com/apache/spark/blob/master/sql/hive/src/test/resources/ql/src/test/queries/clientpositive/mapreduce1.q

Yeah, i found this problem too. In some complex column expressions,  we can't find a direct attribute name for a col, so I use sql pretty name. But some complex col's final name is not  the same as toPrettySQL.  Then cause this problem.

Regarding the issue in https://github.com/apache/spark/pull/25028#issuecomment-547230458
Instead of
    val namedExpressions = expressions.map {
      case e: NamedExpression => e
      case e: Expression => UnresolvedAlias(e)
    }

How about also using a manual aliasing function to create an alias for complex column expressions (i.e. BinaryExpression) instead of relying on toPrettySQL
Example:
   val aliasFunc = (position: Int, e: Expression) => s"gen_alias_${position}"

    val namedExpressions = expressions.zipWithIndex.map {
      case (e: NamedExpression, _) => e
      case (e: BinaryExpression, index) => UnresolvedAlias(e, Some(aliasFunc(index, _)))
      case (e: Expression, _) => UnresolvedAlias(e)
    }

Test query runs successfully.

Regarding the issue in #25028 (comment)
Instead of
    val namedExpressions = expressions.map {
      case e: NamedExpression => e
      case e: Expression => UnresolvedAlias(e)
    }

How about also using a manual aliasing function to create an alias for complex column expressions (i.e. BinaryExpression) instead of relying on toPrettySQL
Example:
   val aliasFunc = (position: Int, e: Expression) => s"gen_alias_${position}"

    val namedExpressions = expressions.zipWithIndex.map {
      case (e: NamedExpression, _) => e
      case (e: BinaryExpression, index) => UnresolvedAlias(e, Some(aliasFunc(index, _)))
      case (e: Expression, _) => UnresolvedAlias(e)
    }

Test query runs successfully.

Good suggestion, make subquery 's output and transform's input with same alias.  Can solve this problem. Nice method.

Follow up - I think It's even better to always use a manual aliasing function and not just for a subset of expressions:
   val aliasFunc = (position: Int, e: Expression) => s"gen_alias_${position}"

    val namedExpressions = expressions.zipWithIndex.map {
      case (e: NamedExpression, _) => e
      case (e: Expression, index) => UnresolvedAlias(e, Some(aliasFunc(index, _)))
    }

Another issue:
test query:
FROM (select 1 as key, 100 as value) src
MAP src.*, src.key, CAST(src.key / 10 AS INT), CAST(src.key % 10 AS INT), src.value
USING 'cat' AS (k, v, tkey, ten, one, tvalue);

Results:
with master:
1	100	1	0	1	100
with this PR:
1	100	1	100	1	0
This is a simplified test case from HiveCompatibilitySuite:
https://github.com/apache/spark/blob/master/sql/hive/src/test/resources/ql/src/test/queries/clientpositive/mapreduce7.q

simpler test case:
FROM (select 1 as key, 100 as value) src
MAP src.*, CAST(src.key % 10 AS INT), src.value
USING 'cat' AS (k, v, one, tvalue);

simpler test case:
FROM (select 1 as key, 100 as value) src
MAP src.*, CAST(src.key % 10 AS INT), src.value
USING 'cat' AS (k, v, one, tvalue);

Star cause the problem . Trying solve this .

simpler test case:
FROM (select 1 as key, 100 as value) src
MAP src.*, CAST(src.key % 10 AS INT), src.value
USING 'cat' AS (k, v, one, tvalue);

Found the reason, in current mode of trasform, in here
https://github.com/apache/spark/blob/095f7b05fd7ae8ce0d8a82f0c4bc26aa92853762/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala#L1098
It will expand star with t.child.output, after t.child was analyzed, it will have src.key, src.value, gen_alias_2 src.value  output, then expand method will make all t.child's output match src as transform's input. Then this error happened.
change to
      // If the script transformation input contains Stars, expand it.
      case t: ScriptTransformation if containsStar(t.input) =>
        t.copy(
          input = t.child.output
        )

This change is reasonable since transform's input is it's child's output.

Another test query:
SELECT TRANSFORM(key, abs(key))
USING 'cat'
FROM (SELECT DISTINCT key FROM src);

The physical plan looks different with this PR applied. in particular, HashAggregate gets another output column, while it should be just one:
HashAggregate(keys=[key#18], functions=[], output=[key#18, **another_output**])

Another test query:
SELECT TRANSFORM(key, abs(key))
USING 'cat'
FROM (SELECT DISTINCT key FROM src);

The physical plan looks different with this PR applied. in particular, HashAggregate gets another output column, while it should be just one:
HashAggregate(keys=[key#18], functions=[], output=[key#18, **another_output**])

Since we can solve every thing with path a Seq(UnresolvedStar(None)) to ScriptTrasnform

Here's what I mean:
test query:
SELECT TRANSFORM(key, abs(key))
USING 'cat'
FROM (SELECT DISTINCT key FROM src);

The physical plan without this PR (on master):
ScriptTransformation [key#7, abs(key#7)], cat, [key#9, value#10], HiveScriptIOSchema(List(),List(),Some(org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe),Some(org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe),List((field.delim,	)),List((field.delim,	)),Some(org.apache.hadoop.hive.ql.exec.TextRecordReader),Some(org.apache.hadoop.hive.ql.exec.TextRecordWriter),true)
+- *(2) HashAggregate(keys=[1#16], functions=[], output=[key#7])
   +- Exchange hashpartitioning(1#16, 1), true, [id=#27]
      +- *(1) HashAggregate(keys=[1 AS 1#16], functions=[], output=[1#16])
         +- *(1) Scan OneRowRelation[]

The physical plan with this PR:
ScriptTransformation [key#0, abs(key)#9], cat, [key#2, value#3], HiveScriptIOSchema(List(),List(),Some(org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe),Some(org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe),List((field.delim,	)),List((field.delim,	)),Some(org.apache.hadoop.hive.ql.exec.TextRecordReader),Some(org.apache.hadoop.hive.ql.exec.TextRecordWriter),true)
+- *(2) HashAggregate(keys=[1#10], functions=[], output=[key#0, abs(key)#9])
   +- Exchange hashpartitioning(1#10, 1), true, [id=#21]
      +- *(1) HashAggregate(keys=[1 AS 1#10], functions=[], output=[1#10])
         +- *(1) Scan OneRowRelation[]

Difference:
+- *(2) HashAggregate(keys=[1#16], functions=[], output=[key#7]) vs
+- *(2) HashAggregate(keys=[1#10], functions=[], output=[key#0, abs(key)#9])

Another issue:
query:
MAP k / 10 USING 'cat' AS (aa) from (select 10 as k);
Error in query: cannot resolve '(k / 10)' given input columns: [(CAST(k AS DOUBLE) / CAST(10 AS DOUBLE))];;

Another issue:
query:
MAP k / 10 USING 'cat' AS (aa) from (select 10 as k);
Error in query: cannot resolve '(k / 10)' given input columns: [(CAST(k AS DOUBLE) / CAST(10 AS DOUBLE))];;

This can be solved by https://github.com/apache/spark/pull/25028#issuecomment-548675869

Another issue:
query:
MAP k / 10 USING 'cat' AS (aa) from (select 10 as k);
Error in query: cannot resolve '(k / 10)' given input columns: [(CAST(k AS DOUBLE) / CAST(10 AS DOUBLE))];;

This can be solved by #25028 (comment)

Yes we already discussed a solution in https://github.com/apache/spark/pull/25028#discussion_r339890074
which I can confirm it works.
Currently the open issue is https://github.com/apache/spark/pull/25028#issuecomment-548691723

output=[key#7]

This is right since we current tread transform's child logicalplan as an entire one.

@alfozan
You can see my branch's newest change. and check the update

Difference:
+- *(2) HashAggregate(keys=[1#16], functions=[], output=[key#7]) vs
+- *(2) HashAggregate(keys=[1#10], functions=[], output=[key#0, abs(key)#9])

Seems after my pr. the output is right.

@alfozan
You can see my branch's newest change. and check the update

Could you share a link to the new branch/PR?

@alfozan
You can see my branch's newest change. and check the update

Could you share a link to the new branch/PR?

https://github.com/AngersZhuuuu/spark/commit/f18a6f99043ec26ac19a8337f41194b6f972090c

Looks good! Thank you.

Looks good! Thank you.

Also thank you for so many error case to make this pr better.

@alfozan
Seems you are working on https://issues.apache.org/jira/browse/SPARK-15694
But I am confused that current ScripTransform execution process has been implemented, are you clear what we need to do?

@alfozan
Seems you are working on https://issues.apache.org/jira/browse/SPARK-15694
But I am confused that current ScripTransform execution process has been implemented, are you clear what we need to do?

yes - we presented the work in https://databricks.com/session_eu19/powering-custom-apps-at-facebook-using-spark-script-transformation and I'll send the PRs later this month.

yes - we presented the work in https://databricks.com/session_eu19/powering-custom-apps-at-facebook-using-spark-script-transformation and I'll send the PRs later this month.

please ping me when you raise a pr to learn your great job.

@HyukjinKwon
Can i reopen this since @alfozan is working or transform script.

@AngersZhuuuu, I didn't read all fully but can we make https://issues.apache.org/jira/browse/SPARK-15694 done first as @wangyum's advice?

@AngersZhuuuu, I didn't read all fully but can we make https://issues.apache.org/jira/browse/SPARK-15694 done first as @wangyum's advice?

Seems @alfozan is doing that part?

Shall we wait for that first? I would like to see how it's implemented first, and possibly we should match the impl.

@AngersZhuuuu, I didn't read all fully but can we make https://issues.apache.org/jira/browse/SPARK-15694 done first as @wangyum's advice?

Seems @alfozan is doing that part?

Yes I'm


Fix various issues in TriggerRate

In order to actually reach the desired rate, the inequality needs to be replaced with greater equal.
Here is an example with publish_rate = 50 and Gazebo simulation (i.e. perfect sim time)
Before: rate = 47.619 Hz = 1/21ms
rostopic hz /franka_state_controller/joint_states
subscribed to [/franka_state_controller/joint_states]
WARNING: may be using simulated time
average rate: 47.619
        min: 0.019s max: 0.024s std dev: 0.00086s window: 143

After: rate = 50 Hz = 1/20ms (as expected)
average rate: 50.000
        min: 0.018s max: 0.022s std dev: 0.00063s window: 52

I found some more issues with this class:

Using ros::Time() conversion to double can introduce rounding errors, causing sporadic misses in state publishing
When ros::Time was reset (e.g. in simulation), there were no state updates at all, because now - time_stamp_ is negative.

@rhaschke Excellent observations! Much appreciated.
@Maverobot Unfortunately, I couldn't test this PR on the real robot, but they look good to me. Would be great if these could be merged as they will significantly improve the performance 🚀.


feature:  统一语言 Cookie (closed #1648)

Codecov Report

Merging #1653 (677e092) into v2.3.2-dev (acf4c0d) will decrease coverage by 43.34%.
The diff coverage is 25.00%.

@@               Coverage Diff               @@
##           v2.3.2-dev    #1653       +/-   ##
===============================================
- Coverage       73.38%   30.05%   -43.34%
===============================================
  Files             389       15      -374
  Lines           26297      569    -25728
===============================================
- Hits            19298      171    -19127
+ Misses           6999      398     -6601

Impacted Files
Coverage Δ

config/default.py
3.30% <0.00%> (-78.92%)
:arrow_down:

env/__init__.py
89.28% <50.00%> (-10.72%)
:arrow_down:

... and 384 files with indirect coverage changes


Migration task steps woven into volume concept page

This is a Bug Report

Problem:
Volumes is supposed to be a page that explains the concept of volumes in Kubernetes, perhaps as a primer before introducing PersistentVolume and PersistentVolumeClaim in the API.
However, the Volumes concept also includes details, per storage driver, of how to migrate it to CSI and how to operate once that migration is complete.
Proposed Solution:

Migrate reference details for storage plugins into the reference section. After this tidying, the volumes concept should link to driver details but not contain any, other than for examples.
Migrate information about migration to CSI plugins into the task section.

Page to Update:
https://kubernetes.io/docs/concepts/storage/volumes/

Issue #4514 is an umbrella issue for tracking improvements to storage-related documentation
/sig storage
/language en
/kind cleanup

/remove-lifecycle stale
Relevant (a bit) to PR #24077


filter update

What issue is this solving?

Closes #158
Description

Added the ability to treat '0' as an 'o' so that spellings such as 'g0damn' are not missed.
As an extra I went ahead and changed the filter to log everything to swear-jar channel, though this is controlled by a constant variable autoMod so it can be reverted quickly.

Is a re-seeding of the database necessary? NO
Any new dependencies to install? NO
Any special requirements to test?
Can't have SU, Mod, or Admin for the filter to check your messages

Please make sure you've attempted to meet the following coding standards

[x] Code has been tested and does not produce errors
[x] Code is readable and formatted
[x] There isn't any unnecessary commented-out code

Should be fixed now!


[help] XSLT::Stylesheet#transform return infinite template recursion error

What problem are you trying to solve?
I try to transform the zugferd/factur-x schema file with the xslt2 into a schematron to be able to validate incoming factur-x xml invoices.
Please show your code!
Here is a zip file with the schema file and the iso-schematron-xslt2 files:
files.zip
The 'iso_dsdl_include.xsl' file will raise an error when tranforming.
Example code:
require 'nokogiri'

schema_path = File.join(__dir__, 'Factur-X_1.0.07_EN16931.sch')
schematron_doc = Nokogiri::XML(File.read(schema_path))
xsl_path = File.join(__dir__, 'iso_dsdl_include.xsl')
xsl_file = Nokogiri::XSLT(File.read(xsl_path))
xsl_file.transform(schematron_doc)

=> (irb):7:in `transform': runtime error: element value-of (RuntimeError)
xsltApplySequenceConstructor: A potential infinite template recursion was detected.

FullError:
(irb):7:in `transform': runtime error: element value-of (RuntimeError)
xsltApplySequenceConstructor: A potential infinite template recursion was detected.
You can adjust xsltMaxDepth (--maxdepth) in order to raise the maximum number of nested template calls and variables/params (currently set to 3000).
Templates:
#0 name strip-strings
#1 name strip-strings
#2 name strip-strings
#3 name strip-strings
#4 name strip-strings
#5 name strip-strings
#6 name strip-strings
#7 name strip-strings
#8 name strip-strings
#9 name strip-strings
#10 name strip-strings
#11 name strip-strings
#12 name strip-strings
#13 name strip-strings
#14 name strip-strings
Variables:
#0
mode
string
#1
string
#2
mode
string
#3
string
#4
mode
string
#5
string
#6
mode
string
#7
string
#8
mode
string
#9
string
#10
mode
string
#11
string
#12
mode
string
#13
string
#14
mode
string
        from (irb):7:in `<main>'
        from /home/.../.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/irb-1.4.1/exe/irb:11:in `<top (required)>'
        from /home/.../.rbenv/versions/3.1.2/bin/irb:25:in `load'
        from /home/.../.rbenv/versions/3.1.2/bin/irb:25:in `<top (required)>'
        from /home/.../.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/bundler-2.5.22/lib/bundler/cli/exec.rb:58:in `load'
        from /home/.../.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/bundler-2.5.22/lib/bundler/cli/exec.rb:58:in `kernel_load'
        from /home/.../.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/bundler-2.5.22/lib/bundler/cli/exec.rb:23:in `run'
        from /home/.../.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/bundler-2.5.22/lib/bundler/cli.rb:455:in `exec'
        from /home/.../.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/bundler-2.5.22/lib/bundler/vendor/thor/lib/thor/command.rb:28:in `run'
        from /home/.../.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/bundler-2.5.22/lib/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
        from /home/.../.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/bundler-2.5.22/lib/bundler/vendor/thor/lib/thor.rb:527:in `dispatch'
        from /home/.../.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/bundler-2.5.22/lib/bundler/cli.rb:35:in `dispatch'
        from /home/.../.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/bundler-2.5.22/lib/bundler/vendor/thor/lib/thor/base.rb:584:in `start'
        from /home/.../.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/bundler-2.5.22/lib/bundler/cli.rb:29:in `start'
        from /home/.../.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/bundler-2.5.22/exe/bundle:28:in `block in <top (required)>'
        from /home/.../.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/bundler-2.5.22/lib/bundler/friendly_errors.rb:117:in `with_friendly_errors'
        ... 3 levels...

Environment

nokogiri 1.16.7
ruby 3.1.2
ubuntu 20.04

Additional context
I tried to adapt the codebase of the nokogiri-schematron gem (https://github.com/alexxed/schematron) which wasn't updated in ~8 years.

@ChrisKaun Thanks for asking this question.
Nokogiri doesn't currently support Schematron, although libxml2 itself does. I honestly don't know much about Schematron, and have never used it myself. Can you explain a bit more about what this code snippet is supposed to do? Can you say more about why you aren't using the gem that you mention (it seems like it still passes its test suite with modern Nokogiri)?


New Architecture

Any plans to migrate this library to the new architecture (fabric)?
Thanks 🙏

Hi, since this library is no longer maintained I've decided to migrate it on my own: https://github.com/Vadko/react-native-file-viewer-turbo. Enjoy!


Define Communication Channels for the Project

To ensure effective and organized communication within our community, it is essential to establish clear and dedicated communication channels. This will help streamline our discussions, support, and collaborations, making it easier for all contributors to engage and stay informed.
I propose that we utilize the following communication channels for our project:

Mailing List: For formal announcements, important updates, and discussions that require more in-depth conversation.
GitHub Discussions: For casual conversations, questions, feature requests, and other project-related interactions that can benefit from the visibility and structure provided by GitHub.

Proposed Solution

Utilize the existing Mailing list of the project.
Utilize GitHub discussions.
Document the communication channels: Update the README and CONTRIBUTING documents to include information about our communication channels, how to access them, and what types of discussions are best suited for each channel.

Action Items

[ ] Create categories and guidelines for GitHub Discussions.
[ ] Update the README and CONTRIBUTING documents to include information about the mailing list and GitHub Discussions.

Announced the mailing list here, too.
https://github.com/eclipse-dataspace-protocol-base/DataspaceProtocol/discussions/24
Need to add this to the Contributing file and the Readme

@ssteinbuss can this be closed?


add support for RS_DISTORTION_FTHETA into rs_project_point_to_pixel()

Using the Intel RealSense ZR300  that has the "motion module" with fish_eye camera.  Accessing the fish_eye stream and getting the intrinsic and distortion parameters is supported by the current librealsense.   Additionally there is a sample displaying these newly available streams.
However, there is no documentations on specifically what the fisheye intrinsic parameters mean.   At minimum, if the equations were simply added to the function rs_project_point_to_pixel().  Currently the function asserts when provided intrinsics returned from the api.
  auto intrinsics = dcam.dev->get_stream_intrinsics(rs::stream::fisheye);
  auto p = intrinsics.project(rs::float3{ my_x, my_y, my_z });   // this will assert!!!!!

We tried an radial projection with distortion implementation and a few variants based on common conventions that people tend to use (there are a number of them), but in our tests things didn't quite line up.  Consequently, not sure if equation is correct, or if the calibration parameters are off.  code tested is:
static void rs_project_point_to_pixel(float pixel[2], const struct rs_intrinsics * intrin, const float point[3])
{
    assert(intrin->model != RS_DISTORTION_INVERSE_BROWN_CONRADY); // Cannot project to an inverse-distorted image
    // comment out the assert for FTHETA:
    //assert(intrin->model != RS_DISTORTION_FTHETA); // Cannot project to an ftheta image

    float x = point[0] / point[2], y = point[1] / point[2];

    if(intrin->model == RS_DISTORTION_MODIFIED_BROWN_CONRADY)
    {
        .... same as before ...
    }
    if (intrin->model == RS_DISTORTION_FTHETA)
    {
		float r2 = x*x + y*y;
		float r = sqrt(x*x + y*y);
		float t = atan(r);
		float f = 1 + intrin->coeffs[0] * t*t;    // we noticed other coeffs, besides coeffs[0], were all 0.0 anyways
		x *= f;
		y *= f;
		if (r>1e-8)
		{
			x *= t / r;
			y *= t / r;
		}
    }
    pixel[0] = x * intrin->fx + intrin->ppx;
    pixel[1] = y * intrin->fy + intrin->ppy;
}

Note, the above code may be incorrect.  Anybody using the fish_eye data will need to know the correct equation.  Library on github should be updated with the necessary code added to this function in rsutil.h.
I'd also suggest adding such correspondence to the multi-stream viewer sample.   i.e. when the mouse cursor is over a point in one of the stream images, the program also displays a small highlight over all the other streams that corresponds to the same point if one exists and can be computed.  This would make it very clear how to apply the intrinsics and extrinsics for each stream.   Such short code samples are a way to overcome any ambiguity or missing information in the documentation.

Required Info

Camera Model
ZR300

Firmware Version

Operating System & Version
Windows

Kernel Version (Linux Only)

Build System
VS2015

i'm using windows and vs2015, but this would also apply to other operating systems and compilers.

Someone suggested I try the distortion model from equation 13 from "Straight lines have to be be straight: automatic calibration and removal of distortion from scenes of structured environments" by Devernay and Faugeras.    https://hal.inria.fr/inria-00267247/document
So i just tried the following implementation:
    float r = sqrt(x*x + y*y);
    auto rd = (1.0f / intrin->coeffs[0] * atan(2 * r* tan(intrin->coeffs[0] / 2.0f)));
    x *= rd / r;
    y *= rd / r;

seems closer and more consistent throughout the view volume of the depth camera, but it doesn't quite line up pixel perfect in my test program.   If someone could confirm whether this is how the zr300 fisheye intrinsics are supposed to be applied that would be nice.   even better, someone in the know please just add the correct equation to the code (whether the above snippet or something else).
thanks in advance.

Hi @melax,
To be honest, texture mapping between depth and fish-eye was never explicitly requested for ZR300 product so we never got to implementing it. There is no official documentation from Algo, but we do have the code used to undistort fish-eye frames:

It seems very close to the second method you suggested (it should be more or less the inverse).
And indeed using the second formula, fish-eye frames seem to be undistored and reasonably mapped to depth:

I'll try to get the official confirmation on this and would be happy to add this functionality to librealsense.

For best support, post issues in the RealSense Community.
Hello,
Do you still need help with this issue?
Best regards,
Jesus
Intel Customer Support

got it implemented.   we're all good.


Bug (?) : cannot provide Uri to an Internet image file (URL) or to a contact photo?

If I provide the CropImageView with a Uri to a URL address of an image file, or to a contact photo, I don't see that it gets loaded and viewed.
How come?
Does it only accept Uris of local storage?

yes, it only supports android storage uri

So please consider updating the description. It doesn't say it's limited to storage alone (using the SAF API).
This is the current description:

Set cropping image as Bitmap, Resource or Android URI (Gallery, Camera, Dropbox, etc.).

Android uri means Android, not web

Android uri can be of contacts, of Internet, and of anything the contentProvider allows...

Will update the documentation

Thank you


Better way to manage depenedencies?

I have been considering this for a while now. The more loaders, LLMs and embedding models we add, the question becomes more and more important. Currently the library already separates out the dependencies for the vector databases using clever package.json config, leveraging peer and optional dependencies.
But this does not scale well but is not a problem today. At the same time, it's getting important that we really break out the various parts even more. I don't want a lot of dependencies being added in by default. It's also problematic to address vulnerabilities. Ultimately people will only use some of the choices and they should only have those relevant modules.
Here are our options -

Continue with the current package.json based solution. We will have more optional dependencies and we will address this by more detailed documentation.

Switch to a monorepo. A core package (embedJs) and several sub-packages (like embedjs-openai, embedjs-slack-loader, etc)

Clearly option 2 is the long term direction but might be more work than necessaty today.
What do you all think?

I can't recommend NX enough, and getting started with it incrementally is faster than you may think.  Their ecosystem enables you to spin up new packages and dependencies rapidly and easily, breaking down your architecture into easily manageable small pieces.
I would be interested in contributing to help this endeavour.  I am looking to use EmbedJS right now for my application and migrating off from a kind of hacky use of Embedchain running with JsPyBridge.  There are some functionalities I need from EmbedJS which I will have to add and am happy to contribute.

Yes, I have been considering switching to NX primarily. My only concern is asking people to install even more packages per loader. But this removes the need to install 3rd party packages (like for vector databases) as those dependencies will be packaged into the corresponding sub-package published.
I haven't used NX before (last time had to deal with node monorepos, it was the era of lerna) but let me take a first stab at it. You can review the PR and let me know if there are best practises that I missed.
Do let me know what missing functionalities will be useful for you?

I came across NX from their takeover of lerna as well. However, moving this lib to NX will take some time as I am not familiar with NX at the moment. I do think the monorepo route is the long term direction to go in but it will come up after some core functional items are added in.
Some of the functionalities you mention are aligned with the roadmap I have.
I am currently adding support for auto-detecting files and URLs to auto load using relevant loaders. So in principle, you should be able to pass a path/URL/a json (etc) and the library should be able to auto load the content identifying the correct loader. You should also be able to pass a directory path and load all files in it.
This is being added in this PR https://github.com/llm-tools/embedJs/pull/66 and I hope to get it out over the next few days after more testing.
The next major feature to add in is going to be searching via metadata.
Could you tell me more about the last feature? Is that just a list of files / data sources that were added so far to the vector database?

All for moving to monorepo.
(Bias declaration: My only experience with NX on another project is people gave up.)
Do what you know as you are the primary maintainer.
I'm currently working on a project which is heavily using embedJS and will be contributing back and knowing how to do this best would be great. e.g. we add loaders, embedders.
Currently the biggest thing we have added is an abstraction of the whole conversations layer so conversaiton history can also be stored in memory/database so it persists. So far to do this has required changes across the intialiser and base-model, so this wouldn't be as easy to split.

Yes; I explored nx past few days. I am begining to feel turborepo is easier to get started with for this project compared to nx and they have similar feature sets. Likely will move in that direction.
You can contribute in a number of ways -

If you add a new loader / embedder that you want to contribute back - you can send in a PR for that. Contributing back helps the community but also helps you get bugfixes and support for your code.
If you find bugs somewhere, you can contribute by creating an issue with details that will help identify and address the issue. You can also send in a PR for a bugfix and get it merged upstream on priority.
You can also suggest to me new features (like allowing conversation history to be stored in memory/database). We will need to scope these out a bit more to make sure they are broadly useful. Post this, the community (me and anyone else including you) can create PRs to add support for that. This gets us in built support for your needs right in the library.

The library has now switched over to NX. Closing this thread.


Deprecate main entry point classes of Karyon2

Karyon2 is no longer a supported project.  We recommend users either use RxNetty (https://github.com/ReactiveX/RxNetty) directly in combination with Governator (https://github.com/Netflix/governator) or other DI frameworks.

https://github.com/Netflix/runtime-health as replacement for healthcheck functionality that currently exist in karyon2


Fix flaky HTTPClient adapter spec

If the clock moves to next second during the spec run, date header might be different. Mock time to ensures that date headers of request signatures match.

Thanks.
I wonder if the time matters in this example, since it's not clear where it comes from. Perhaps the assertion should be improved.

HTTPClient sets the time header: https://github.com/nahi/httpclient/blob/f7b36d2257407dfbb807ab004c144b5a991ac5b1/lib/httpclient/session.rb#L733.
Changing the assertion would do the trick, but there's more work as everything else but one field in the RequestSignature should match. An alternative would be to set Date header in the requests explicitly.

Ok, makes sense!


Lecture/Section: integration of Judies lectures

[ ] clean judies lecture slides (cut out things that are not needed)
[ ] clean judies lecture videos use imovie to cut things out that are not needed such as refernces to old classes

create here list of all videos and go through them
sometimes it may be easier to redraw slides. Also some slides have wrong copyright e.g. elsevier can not claim copyright of slides that are copied form elsewhere.

lets have meeting about this in which you propose what to do with it.
Thursday sometime between 10am - noon


Add csv_all_strings guess plugin

This guess plugin suggests column types within Csv files as string types. The default Csv guess plugin suggests column types unexpected by users. To execute Embulk correctly, users sometimes need to edit Embulk config manually and fix column types that users expect. But, some users don't want to edit Embulk config so much.
This plugin is not included in the list of default guess plugins. And to use this plugin, users explicitly need to exclude default csv guess plugin from the list of default guess plugins like:
exec:
  exclude_guess_plugins: ['csv']
  guess_plugins: ['csv_all_strings']
in:
  type: file
  path_prefix: path/to/csvfile

Looks good 👍
Please add some documents as well.

Sure, please check it later. https://github.com/embulk/embulk/pull/493


GHSA-mmf6-6597-3v6m Does this vulnerability also contain org.springframework.security.oauth/spring-security-oauth2

Because the link has been explained to be included. Https://spring.io/security/cve-2019-11269
but GHSA-mmf6-6597-3v6m  only contain org.springframework.security.oauth/spring-security-oauth

Hi @zhangzhenyu2, thank you for your contribution. To suggest adding a new package, please use our improvement suggestion form. This will ensure a timely response and you get credit for the change.


docs: fix typos

Hello,
This tiny PR will fix :

1 typo in components/AppContext.tsx
1 typo in contracts/NFTMarketplace.sol

Best! :robot:

Thanks for your help :)


Object.add is deprecated.

Are you trying to listen for the 'view-tail-large-files:up' Atom command with jQuery::on?
jQuery::trigger can no longer be used to listen for Atom commands. Please
use atom.commands.add instead. See the docs at
https://atom.io/docs/api/latest/CommandRegistry

Hmmm.   I only have one key binding and it looks like ...
    @subs.add atom.commands.add 'atom-workspace, atom-text-editor::shadow', 'view-tail-large-files:open', =>

I can't run it because Atom won't load it.  I'll post an issue for this on Atom/Atom.

See https://github.com/atom/atom/issues/7375.

This package is deprecated since Atom supports larger files now.  The tail functionality will be implemented in a new package by itself ASAP.


Verificarlo on Ubuntu 18.04

Used gcc 5 and llvm 4.0, as tests failed with older versions.
Removed call to setarch in src/vfc_ddebug as it seems to require privileged mode in recent Debian versions.

Also, interesting! It appears that repo-enabled "secrets" are not carried over to PRs, so the login step failed on the PR and thus the subsequent build steps. Optionally, we can make the login and build steps optional if the branch is master. This can be detected via Travis Env variables. I'm happy to verify the build locally and then add this PR myself, @glatard, if you don't want to add that :)

Removing calls to setarch in vfc_ddebug may make delta-debug fail. setarch call is used to disable ASLR (address space layout randomization). Delta-debug uses multiple runs to build a minimal test-case triggering a numerical error. It needs to disable ASLR so that the address of instructions stay the same for every run.

ok, closing this for now, might get back to it in the future, thanks for the hints @pablooliveira!


Metrics: Add Controllers metrics

Added two new metrics related to controllers:

controllers_runs_total which provide the number of runs labeled by
success or not.
controllers_runs_duration_seconds which provide the number of seconds
that a controller took labeled by the status.

Signed-off-by: Eloy Coto<EMAIL_ADDRESS>

This change is

Hi,
About long controllers, the way that I see that:

The histogram creates the values per less than so each time that a controller takes more than a second we'll see that.

cilium_controllers_runs_duration_seconds_bucket{status="success",le="0.005"} 2575
cilium_controllers_runs_duration_seconds_bucket{status="success",le="0.01"} 2645
cilium_controllers_runs_duration_seconds_bucket{status="success",le="0.025"} 2800
cilium_controllers_runs_duration_seconds_bucket{status="success",le="0.05"} 2856
cilium_controllers_runs_duration_seconds_bucket{status="success",le="0.1"} 2880
cilium_controllers_runs_duration_seconds_bucket{status="success",le="0.25"} 2880
cilium_controllers_runs_duration_seconds_bucket{status="success",le="0.5"} 2880
cilium_controllers_runs_duration_seconds_bucket{status="success",le="1"} 2880
cilium_controllers_runs_duration_seconds_bucket{status="success",le="2.5"} 2881
cilium_controllers_runs_duration_seconds_bucket{status="success",le="5"} 2881
cilium_controllers_runs_duration_seconds_bucket{status="success",le="10"} 2881
cilium_controllers_runs_duration_seconds_bucket{status="success",le="+Inf"} 2881
cilium_controllers_runs_duration_seconds_sum{status="success"} 8.773957286000007
cilium_controllers_runs_duration_seconds_count{status="success"} 2881
cilium_controllers_runs_total{status="success"} 2881

I do not think that we have successful controllers that take more than 10 seconds, but if we have, maybe if something that we should check.

Having this data we can use 95th percentitle using histogram_quantile, so the 95th percentile should be in less that a second, or I understand so.

test-me-please

How are these metrics useful if we can't tell what controller it is?

How are these metrics useful if we can't tell what controller it is?

The issue with the controllers is the same as the endpoint, it's easy to get hundred of controllers because there are using the id or pointer in the name:
vagrant@runtime:~$ cilium status --all-controllers  -o json | jq '.controllers|length'
510

So, my idea is:

Know how many controllers are failing/success
Know the time that the controller took if is working or it's failing.

You can't do a fine grained debug in there, but at least you'll know when controllers are failing or not.
Regards

We could add a new field to UpdateController called category or type (or something) and use that as a label. We have many controller instances but only 31 places we call UpdateController, so perhaps "only" 31 types. That might still be too many for a label, though, especially because we are likely to add more controllers.
A similar alternative is to split name into type and id fields but internally they are combined as the controller name. The id here is freeform but could be empty or be the id we usually use.


fix: location_last_updated_at

Issue root cause described here:
https://github.com/ZuinigeRijder/hyundai_kia_connect_monitor/issues/48#issuecomment-1436588493
The root cause is in the hyundai_kia_connect_api library.
In Vehicle.py _location_last_set_time is not correctly filled, only for KiaUvoApiEU.py this is done correctly.
You see the missing conversion to a datetime in HyundaiBlueLinkAPIUSA.py.
    vehicle.location = (
            get_child_value(state, "vehicleStatus.vehicleLocation.coord.lat"),
            get_child_value(state, "vehicleStatus.vehicleLocation.coord.lon"),
            get_child_value(state, "vehicleStatus.vehicleLocation.time"),
        )

The last statement should be converted to a datetime, e.g. with get_last_updated_at.
Note that the same is wrong for KiaUvoAPIUSA.py and KiaUvoApiCA.py.
here are 2 problems in get_last_updated_at for HyundaiBlueLinkAPIUSA.py:

time can be None as input, and then the error: TypeError: expected string or bytes-like object
the other datetime last_update_at string replaces characters before calling get_last_updated_at

Changes:
HyundaiBlueLinkAPIUSA.py
KiaUvoAPIUSA.py
KiaUvoApiCA.py
KiaUvoApiEU.py

Fix location_last_updated_at to convert to correctly datetime or to 2000-01-01
added doc strings
moved suppression of pylint warnings to second line, after doc string
fixed pylint warnings or suppressed specific pylint warnings
fixed flake8 warnings, "line to long warnings" suppressed at end of line with # noqa

ApiImpl.py
Token.py
Vehicle.py
VehicleManager.py
init.py
const.py
exceptions.py
utils.py

added doc strings
moved suppression of pylint warnings to second line, after doc string
fixed pylint warnings or suppressed specific pylint warnings
fixed flake8 warnings, "line to long warnings" suppressed at end of line with # noqa

@cdnninja I made a new Pull Request, because I did probably something wrong during merging. So I started with a fresh fork and my local changes and merge of HyundaiBlueLinkAPIUSA.py of master are committed.

@cdnninja Note that I found a problem in the commit to MAIN, namely that in lock_action method, the call to _get_vehicle_headers the parameter vehicle was forgotten in HyundaiBlueLinkAPIUSA.py. That is also why it is important to use pylint and flake8. This is also solved in this commit/Pull Request.

Thank you for this!  I will merge and also going to give you contributor access to this.  You have been a huge help on this project.

@cdnninja   You also thanks for the constant bug fixes and feature updates!


Proposal: Image Gallery

Beautiful JavaScript plugin could be used to make a gallery:
Here are 2 of them I think very usefull

Photoswipe
Nanogallery

I found this package: https://github.com/mjgr0013/Symfony-UX-Photoswipe

Curiously it doesn't appears on official packages.
I'll have a try 😀

That's pretty cool :)


[FLINK-13157]reeanble unit test read complext type of HiveInputFormatTest

What is the purpose of the change
reeanble unit test read complext type of HiveInputFormatTest
Brief change log

reeanble unit test read complext type of HiveInputFormatTest

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no )
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

cc @bowenli86 @xuefuz @lirui-apache
Travis-LinkLink

@zjuwangg thanks for your contribution!
I wonder if we should add a shim for the changes you made in HiveInspectors?

@zjuwangg thanks for your contribution!
I wonder if we should add a shim for the changes you made in HiveInspectors?

@bowenli86 I talked with @lirui-apache offline and found a way to make the change in HiveInspectors look more reasonable.
We don't need a shim for the changes right now, maybe it's needed for the long term.

LGTM overall. Probably a follow up is to use hive runner to simplify these tests.

address @lirui-apache 's comments.

The latest changes look good to me. It would be good if we can revert unnecessary changes on the indention. (This might be taken care at commit time.(

Yes, as @xuefuz mentioned, please revert any unnecessary changes in the future. I reverted them for you this time.

The latest changes look good to me. It would be good if we can revert unnecessary changes to the indention. (This might be taken care at commit time. (

Yes, as @xuefuz mentioned, please revert any unnecessary changes in the future. I reverted them for you this time.
Ran tests for Hive 2.3.4 and 1.2.1 locally. Merging

Thanks, I will take care of in the future.


can't build to android

Self help steps before reporting the issue:
[ ] Check Solar2D forums for a solution
[ ] If Android: make sure Java8 is installed and reported when running java -version and javac -version if not, download and install Java 8
can't build into android using sample project horse animation, already trying using java 8, java 11 and java 14.
Platforms involved
Building on: linux lite 6.
Building for: Android
this is the message error
FAILURE: Build failed with an exception.

What went wrong:
A problem occurred configuring root project 'Corona Android'.

Could not resolve all files for configuration ':classpath'.
Could not resolve com.android.tools.build:gradle:7.4.2.
Required by:
project :
No matching variant of com.android.tools.build:gradle:7.4.2 was found. The consumer was configured to find a runtime of a library compatible with Java 8, packaged as a jar, and its dependencies declared externally, as well as attribute 'org.gradle.plugin.api-version' with value '7.5' but:
- Variant 'apiElements' capability com.android.tools.build:gradle:7.4.2 declares a library, packaged as a jar, and its dependencies declared externally:
- Incompatible because this component declares an API of a component compatible with Java 11 and the consumer needed a runtime of a component compatible with Java 8
- Other compatible attribute:
- Doesn't say anything about org.gradle.plugin.api-version (required '7.5')
- Variant 'javadocElements' capability com.android.tools.build:gradle:7.4.2 declares a runtime of a component, and its dependencies declared externally:
- Incompatible because this component declares documentation and the consumer needed a library
- Other compatible attributes:
- Doesn't say anything about its target Java version (required compatibility with Java 8)
- Doesn't say anything about its elements (required them packaged as a jar)
- Doesn't say anything about org.gradle.plugin.api-version (required '7.5')
- Variant 'runtimeElements' capability com.android.tools.build:gradle:7.4.2 declares a runtime of a library, packaged as a jar, and its dependencies declared externally:
- Incompatible because this component declares a component compatible with Java 11 and the consumer needed a component compatible with Java 8
- Other compatible attribute:
- Doesn't say anything about org.gradle.plugin.api-version (required '7.5')
- Variant 'sourcesElements' capability com.android.tools.build:gradle:7.4.2 declares a runtime of a component, and its dependencies declared externally:
- Incompatible because this component declares documentation and the consumer needed a library
- Other compatible attributes:
- Doesn't say anything about its target Java version (required compatibility with Java 8)
- Doesn't say anything about its elements (required them packaged as a jar)
- Doesn't say anything about org.gradle.plugin.api-version (required '7.5')

Was you able to build on Linux before?

I have same issue on my ubuntu 22.04
After update solar2d to 2023.3693 and newer version a can't build even new project on android.
Solar2d 2023.3692 works fine.


[Question]: Several tasks prepend values in PATH, which causing me issues (Kubernetes and Python)

Task name
Kubernetes & UsePythonVersion
Task version
1.227.0 (Kube) & 0.229.0 (Python)
Environment type (Please select at least one enviroment where you face this issue)

[X] Self-Hosted
[X] Microsoft Hosted
[ ] VMSS Pool
[ ] Container

Azure DevOps Server type
dev.azure.com (formerly visualstudio.com)
Azure DevOps Server Version (if applicable)
No response
Operation system
Ubuntu 22.04
Question
Hello,
I have a pipeline that does some tasks in Python, then connect to an Azure Kubernetes Service, then interact with it through an other Python script.
But both tasks Kubernetes@1 and UsePythonVersion@0 prepend values into %PATH%, which causing me issues
If I'm using UsePythonVersion@0 first then Kubernetes@1 (login), I end up with my python messed up because Kubernetes@1 prepends /usr/bin/ to %PATH% and unfortunately, there is a python in that folder...
I could reshuffle the tasks in my pipeline, but it feels like a patch. What do you recommend?
Here is a minimal example to reproduce the issue:
trigger:
- None

pool:
  vmImage: ubuntu-latest

steps:

- task: UsePythonVersion@0
  displayName: 'Use Python 3.9'
  inputs:
    versionSpec: 3.9

- bash: |
    which python
    python --version
  displayName: 'Python path'

- task: Kubernetes@1
  displayName: 'Kubectl login'
  inputs:
    connectionType: 'Azure Resource Manager'
    azureSubscriptionEndpoint: 'some_subscription_endpoint'
    azureResourceGroup: 'some_resource_group'
    kubernetesCluster: 'some_cluster_name'
    command: login

- bash: |
    which python
    python --version
  displayName: 'Python path'

My output from bash commands are :

/opt/hostedtoolcache/Python/3.9.18/x64/bin/python
Python 3.9.18
/usr/bin/python
Python 3.10.12

Hi @SylvainLem thank you for your question.
Unfortunately, this is expected behavior - the Kubernetes@1 task should append the kubectl binary location (/usr/bin) to the system path during the task initialization, to prepare the agent for further actions, and the UsePythonVersion@0 task is designed to prepend the location of the toolcache Python to the path, instead of replacing the default system Python.
The correct approach here is to use UsePythonVersion@0 after the Kubernetes@1 to avoid this issue.
Also, please feel free to open a ticket for the Kubernetes@1 task enhancement if you think that the current task behavior can be improved.

@SylvainLem I'm going to close this issue, please feel free to reopen it if you have additional questions.


segmentation: Change precision of log(scale) to Q23

This is aligned to IEEE 754 binary32 precision and avoids possible saturation of i32 from extreme values of DistortionScale.
Also, restore internal documentation from the draft of #2993.

Codecov Report
Base: 86.56% // Head: 86.48% // Decreases project coverage by -0.07% :warning:

Coverage data is based on head (50ab134) compared to base (468007d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2998      +/-   ##
==========================================
- Coverage   86.56%   86.48%   -0.08%
==========================================
  Files          88       88
  Lines       33973    33983      +10
==========================================
- Hits        29409    29391      -18
- Misses       4564     4592      +28

Impacted Files
Coverage Δ

src/rdo.rs
85.81% <100.00%> (-0.06%)
:arrow_down:

src/segmentation.rs
94.80% <100.00%> (+0.17%)
:arrow_up:

src/header.rs
68.93% <0.00%> (-4.17%)
:arrow_down:

src/cpu_features/x86.rs
39.58% <0.00%> (-2.09%)
:arrow_down:

v_frame/src/plane.rs
88.78% <0.00%> (-0.35%)
:arrow_down:

src/deblock.rs
95.50% <0.00%> (+0.07%)
:arrow_up:

src/me.rs
95.69% <0.00%> (+0.09%)
:arrow_up:

src/encoder.rs
87.19% <0.00%> (+0.10%)
:arrow_up:

src/asm/x86/lrf.rs
94.11% <0.00%> (+0.63%)
:arrow_up:

... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Update throwaway_domains.txt

Add domain from temp-mail.org and sort the list

@MattKetmo There are a few open PR's with changes to the list. We could all benefit from those changes 👍


KAFKA-16888 Fix failed StorageToolTest.testFormatSucceedsIfAllDirectoriesAreAvailable and StorageToolTest.testFormatEmptyDirectory

a quick fix for https://issues.apache.org/jira/browse/KAFKA-16888
https://github.com/apache/kafka/commit/459da4795a511f6933e940fcf105a824bd9e589c#diff-4bacfdbf0e63a4d5f3deb1a0d39037a18510ac24ee5ec276fe70bc818ba4d209L505 put extra information as follows to the output which break some tests in StorageToolTest that rely on the original output.
metaPropertiesEnsemble=MetaPropertiesEnsemble(metadataLogDir=Optional.empty, dirs={/tmp/kafka-10468059960007009962: EMPTY, /tmp/kafka-11677474438939329103: EMPTY, /tmp/kafka-17616780619664597434: EMPTY})

This pr modified the test testFormatSucceedsIfAllDirectoriesAreAvailable, testFormatEmptyDirectory to get rid of those extra infos to avoid test failed.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Thanks for the fix @brandboat ! I assume the patch fixes the broken tests, but could you please add some info in the PR description for reviewers know why this fixes the issue. Something like:

Why it is broken
In which commit changes the behavior and why changes
How do you fix it
Thanks.
Added some description in pr, thanks ! 😃


wSPI sent to Metamask, I rejected the gas fee by mistake and now the tokens have vanished.

Hey there,
So I was testing out the Wormhole in a bid to escape high gas fees, realised I was in a bottle neck and tried to move them back.  I rejected the gas fees and now the SPI is nowhere to be seen even though the transaction was successful.
Any help very much appreciated!!!!
Solana Wallet:
HBaZTYaAjMDcGoqg91VreCniLXXXitjLrdGGMhosS9Fe
Metamask Wallet:
0x11D82b9F5d79B8288f0410d101a6Dc3AA7af054f
https://explorer.solana.com/tx/53bVeJ3ZsD1tTSL6SeSPivfXnwUnG7QbQYwxQuvZgKsgTE9q6Mf2h21vaseviM8DrpffFHwvLEzghEey1kA21DNk

The transaction was successfully processed by the Wormhole network, but the client-side transaction submission may have failed. Try clearing your cache and reloading wormholebridge.com to see if the transaction can be completed there. Make sure both wallets are connected.
If wormholebridge.com doesn't work, you can manually submit the signed VAA bytes below to the submitVAA method on the Wormhole contract: https://etherscan.io/address/0xf92cd566ea4864356c5491c177a430c222d7e678#writeContract

Digest: 9a106fa1968854cdfd49da6cda7c05683e0d0866354d198f3dcdd1579d8048f2
Signed VAA bytes:

0x01000000010d0001fe031b7c0b5e801f0bcd25e540f62455e906092ee6a8694412423dc7e2c10c7ebcee7eee573e3e7d9151fa7eaffa87e8841b666a573765a488c50b5b1b58e20001ee0313e7504e781d47195b2f16481421d3b6f23ecbf6a84af0b768fa1c51ddd70226cafdd5067c458e4b430e38b910c0de190910f8ec3720cb7388d44ed84aa20102ce45ae3b710e7c710c6a891bb2da0a2af12cc0aae13fe50b6ff956b8302e725b3cea3568b3b5560f14d0699ccc5af38de22a7ef1c35428ce2e6a7937564c5716000451ea6557bee5d5b72ddb2bfa473f0e45aa01be7cfa751f2ad490e6a4942edf2c698a5ca8a2cfeb89af11686d0eee75955fe95610a067fb5c673e0d33515641b500051297777e3ee43ee624f32d0e8f2b291d51b4b2c05abed8c13866f9174bb975964c18f1742ac441769c19a91e00921a9868e2a13dd94cbd92ad80f23e4643e7640107936a36f98b45d34901733a5007dbe56dc383a0ca0761bbc47a1c7dfdecd71e2c5aad04f109aa252372a038d2f60d036cad565293c266930a413b91dcb7417c440008e657a80fd2cc6f3e453b72ade737122f530b41812cc75a4207c74a8d2ca75efc0c1d1aa99e73cb598763801ef786222a99ca99fd1b496965acb1bf73e3cca2e4010acedf3fa47d4cc973e7ed4022cb5122828c866ca5521c0299b55df3edf56b27ca0feaefa7cdf3b446f5367d2b7f31dbcb5a928c40922937634c57dcea06251ad6010bc5e3a7698d0e3f47eaf2ee3afb5167f285870d3358527f7e4e0269c7835e443d0060535c374bc272d698e6ed273f54f650b8c3415a78681bc301f3ec5ee130fd000d156356ba5f930391c0d5be6e4b42b166ee0f648bddfab0d84c635fd2cf33663a45ffca1b19315e1636922fca1cfeda8113e29c3505c1aba2fbf944df6fe5701f01109ea39559b96b22de54e333823acaf6f4d39bfd46267eac27825cf3a71905c368384a227acec71c667a4089b164869b2b2a6f0c55e65d63cf8e3ee5fdd7fd13420011674b2ff927aa5d4662ba0f197ada7c3d3987d48553e884aeb72334963eddfaa03eb6b4d3709d11ab5baf16b94196f3cd20df92365697508cb766d3312fb9c7fe011216246fab2464f7ebcf6c82f46ddaf71cf469ae5188eeeb9b70008c02cf388bd021d53fec3b0de392c670b6d769b6f07ed9b51208aaf34a76386329c75fcdd14001612d441310000106a40102c81b379533bbf5e23d2ec0ab293b1fa878ff9d83e1801923dc4777c19989fb5f00000000000000000000000011d82b9f5d79b8288f0410d101a6dc3aa7af054f020000000000000000000000009b02dd390a603add5c07f9fd9175b7dabe8d63b70900000000000000000000000000000000000000000000000000000026e1f9c600

No need, glad to help


Docker without Host Network

When running in a container and mapping only port 34400 (not using "Host" networking), xteve thinks it's IP is the Docker IP.  When trying to download a backup I am sent to a URL of the Docker IP, however a manual edit to the host IP allows download of backup.

xTeVe uses the network stack and all IP addresses provided by the OS. I do not know exactly how Docker works, but for me that sounds like a NAT problem between the host IP and the IP from the Docker image.

I think OP is asking to be able to configure xTeVe where to send the backup file as a selection in settings. Feature Request.

That's seems more like it.  A lot of Docker apps allow the manual
specification of a hostname or ip.
On Tue, Aug 6, 2019, 12:09 PM Steve<EMAIL_ADDRESS>wrote:

I think OP is asking to be able to configure xTeVe where to send the
backup file as a selection in settings. Feature Request.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/xteve-project/xTeVe/issues/5?email_source=notifications&email_token=AEBDQQKW45AJKWRCTXHUNNDQDHD5JA5CNFSM4IJYQ3O2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3WFAWQ#issuecomment-518803546,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEBDQQOD5QJVEHUEQD2C7M3QDHD5JANCNFSM4IJYQ3OQ
.

As I said, I'm not familiar with Docker, I use FreeBSD Jails to isolate programs.
I do not know any programs, in which one indicates which IP address these have. I know only programs, in which one can specify, which IP addresses may call this program.
xTeVe sets the requested IP address / hostname dynamically, since they must also be in the M3U or DVR Lineup.
My server has several IP addresses. Here's an example:
...
2019/08/06 15:19:44 [xTeVe] System IP Addresses:   IPv4: 2 | IPv6: 7
2019/08/06 15:19:44 [xTeVe] Hostname:              mbp.local
...

Request over IP: <IP_ADDRESS>:34400/m3u/xteve.m3u
For the xteve.m3u the IP address will be adjusted
#EXTINF:0 channelID="x-ID.2" tvg-chno="1002" tvg-name="M3U8 Test" tvg-id="1002" tvg-logo="" group-title="Buffer 1",M3U8 Test
http://<IP_ADDRESS>:34400/stream/f39126c7469d3640bc13df03c9fa71fd

Request over IP: <IP_ADDRESS>:34400/m3u/xteve.m3u
For the xteve.m3u the IP address will be adjusted:
#EXTINF:0 channelID="x-ID.2" tvg-chno="1002" tvg-name="M3U8 Test" tvg-id="1002" tvg-logo="" group-title="Buffer 1",M3U8 Test
http://<IP_ADDRESS>:34400/stream/f39126c7469d3640bc13df03c9fa71fd

Request over hostname: mbp.local:34400/m3u/xteve.m3u
For the xteve.m3u the hostname will be adjusted:
#EXTINF:0 channelID="x-ID.2" tvg-chno="1002" tvg-name="M3U8 Test" tvg-id="1002" tvg-logo="" group-title="Buffer 1",M3U8 Test
http://mbp.local:34400/stream/f39126c7469d3640bc13df03c9fa71fd

When an M3U client loads xteve.m3u over a public domain (http://example.com:34400/m3u/xteve.m3u), the client will get back the M3U with the domain in the streaming URL. If parallel Plex queried the DVR Linup over localhost, Plex got the lineup with localhost addresses.

Setting the Ip or hostname only applies and refers to links within the site
itself refer back to the specified hostname or IP instead of what it thinks
it is itself.  A few examples are: Unifi Controller, Ombi and Tautulli.
On Tue, Aug 6, 2019 at 1:28 PM xteve-project<EMAIL_ADDRESS>wrote:

As I said, I'm not familiar with Docker, I use FreeBSD Jails to isolate
programs.
I do not know any programs, in which one indicates which IP address these
have. I know only programs, in which one can specify, which IP addresses
may call this program.
xTeVe sets the requested IP address / hostname dynamically, since they
must also be in the M3U or DVR Lineup.
My server has several IP addresses. Here's an example:
...
2019/08/06 15:19:44 [xTeVe] System IP Addresses:   IPv4: 2 | IPv6: 7
2019/08/06 15:19:44 [xTeVe] Hostname:              mbp.local
...
Request over IP: <IP_ADDRESS>:34400/m3u/xteve.m3u
For the xteve.m3u the IP address will be adjusted
#EXTINF:0 channelID="x-ID.2" tvg-chno="1002" tvg-name="M3U8 Test" tvg-id="1002" tvg-logo="" group-title="Buffer 1",M3U8 Testhttp://<IP_ADDRESS>:34400/stream/f39126c7469d3640bc13df03c9fa71fd
Request over IP: <IP_ADDRESS>:34400/m3u/xteve.m3u
For the xteve.m3u the IP address will be adjusted:
#EXTINF:0 channelID="x-ID.2" tvg-chno="1002" tvg-name="M3U8 Test" tvg-id="1002" tvg-logo="" group-title="Buffer 1",M3U8 Testhttp://<IP_ADDRESS>:34400/stream/f39126c7469d3640bc13df03c9fa71fd
Request over hostname: mbp.local:34400/m3u/xteve.m3u
For the xteve.m3u the hostname will be adjusted:
#EXTINF:0 channelID="x-ID.2" tvg-chno="1002" tvg-name="M3U8 Test" tvg-id="1002" tvg-logo="" group-title="Buffer 1",M3U8 Testhttp://mbp.local:34400/stream/f39126c7469d3640bc13df03c9fa71fd
When an M3U client loads xteve.m3u over a public domain (
http://example.com:34400/m3u/xteve.m3u), the client will get back the M3U
with the domain in the streaming URL. If parallel Plex queried the DVR
Linup over localhost, Plex got the lineup with localhost addresses.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/xteve-project/xTeVe/issues/5?email_source=notifications&email_token=AEBDQQMW4DXEEMH2HONMALLQDHNF5A5CNFSM4IJYQ3O2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3WLWCQ#issuecomment-518830858,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEBDQQPYVDRNQPCDB5RGJOLQDHNF5ANCNFSM4IJYQ3OQ
.

Right, in the Unifi controller, the hostname can be changed. But for some other reason, the controller is usually the DNS server on the network and also configures the USG.
xTeVe is not a DNS server, xTeVe is a web server and hunches all data from the HTTP protocol:
Here's a quote on xTeVe with hostname: map.local:
Here is the HTTP header
&{GET /web/img/log.png HTTP/1.1 1 1 map[Accept:[image/webp,image/apng,image/,/*;q=0.8] Accept-Encoding:[gzip, deflate] Accept-Language:[de-DE,de;q=0.9,en-US;q=0.8,en;q=0.7] Connection:[keep-alive] Referer:[http://mbp.local:34400/web/] User-Agent:[Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3770.142 Safari/537.36]] {}  0 [] false mbp.local:34400 map[] map[]  map[] <IP_ADDRESS>:56737 /web/img/log.png    0xc0158267c0}
The host name comes from the HTTP header, because everything is in there what an HTTP client / server needs to know.

I do not have a Docker that's why I can not check it

Works fine for me in Docker. The only place I've seen it use the internal Docker IP is in the log output, like:
2019/08/07 11:24:47 [xTeVe] Web Interface:         http://<IP_ADDRESS>:8082/web/

Can you try downloading a copy of the xteve backup?  That's the other
location I see xteve using the Docker IP instead of host.
On Wed, Aug 7, 2019 at 5:35 AM Jonathan Cremin<EMAIL_ADDRESS>wrote:

Works fine for me in Docker. The only place I've seen it use the internal
Docker IP is in the log output, like:
2019/08/07 11:24:47 [xTeVe] Web Interface:         http://<IP_ADDRESS>:8082/web/
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/xteve-project/xTeVe/issues/5?email_source=notifications&email_token=AEBDQQKNPDAGFDC2F4DDF7DQDK6PVA5CNFSM4IJYQ3O2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3YHYMQ#issuecomment-519076914,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEBDQQMRQMOCA5FMXU6B7STQDK6PVANCNFSM4IJYQ3OQ
.

The problem with the URL is fixed in v2.0.1. That xTeVe sees the host IP must be at your docker configuration.


Non-trivially removable DTOs

[ ] MigratedFundsEntryDto
[x] OutputMetadataDto
[x] ProtocolParametersDto
[ ] AccountDetailsDto
[ ] TransactionDto
[ ] OutputDataDto
[ ] PreparedMintTokenTransactionDto
[ ] MintTokenTransactionDto
[ ] TransactionOptionsDto
[ ] BlockDto
[ ] InputSigningDataDto
[ ] StrongholdDto
[ ] BurnDto
[ ] RemainderDataDto
[ ] SignedTransactionDataDto
[ ] PreparedTransactionDataDto
[x] NetworkInfoDto

I think everything has been examined and the only one left that I think could be removed is FeatureDto. Not sure if it's worth it.


Does not work on SCPH-7000 & SCPH-7500

I've tried both slot 1 and 2lot 2 images on 2 separate SCPH-7000 and one SCPH-7500 using different cards and both slot 1 and slot 2 images, nothing seams to work at all, I go straight to memory card menu. I have some 50 spare Japanese PS1s so I can keep on testing it. Edit: ps2 reports each card as unformatted so I suppose the files have been copied correctly, I've downloaded the file multiple times and used some older and newest versions of MC annihilator multiple times.

There's been a lot of "fake" memory cards sold recently, they have only 64 KB of memory instead of 128 KB. A few people have confirmed this, and what happens in this case is that the last 64 KB of the memcard image overwrite the first 64 KB, and the memory card appears empty.
You can open your memory card and check the markings on the IC inside, then a google search should reveal if it's a 64 KB or 128 KB memory card.


Changing readme to have updated uw-it-aca urls and django==1.8

Changing readme to have updated uw-it-aca urls and django==1.8
Attempted to change the coveralls icon to be from uw-it-aca, but apparently we haven't activated it as a CI setting here (and I don't have access to change that...) since https://coveralls.io/github/uw-it-aca/nagios_registration is not present

Outdated, see #3 instead


Update the current components for MDL 1.1

New changes and fixes are coming with the release of MDL 1.1. We should also apply them in React-MDL.
See https://github.com/google/material-design-lite/releases/tag/v1.1.0

I've integrated all small changes from the release notes, except these 2:

Added full bleed modifier option to menu items.
Added column sorting to data table.

I'm definitely not sure the bleed divider modifier is a good idea (see https://github.com/google/material-design-lite/issues/4083)
And for the datatable, it's not useful without a better component to automatically handle sorting.
So closing this issue now.


Should code follow the PEP8 format specification?

RT，也许您的代码需要遵守官方代码规范？
As title, should code follow the standard format specification?

感谢，之前没有了解过PEP8


Empty list of attached devices

I have a problem with plugin, list of attached devices are always empty but it seems that the device is created.
` [16:59:03]: Re-creating new AVD.
[16:59:03]: $ echo "no" | /usr/local/Caskroom/android-sdk/25.2.3/tools/bin/avdmanager create avd --name "TestAvdList" --package "system-images;android-23;google_apis;x86"  --tag google_apis --abi x86
[16:59:44]: ▸ Do you wish to create a custom hardware profile? [no]
[16:59:44]: Restarting adb
[16:59:44]: $ /usr/local/Caskroom/android-sdk/25.2.3/platform-tools/adb kill-server
[16:59:44]: ▸ * server not running *
[16:59:44]: $ /usr/local/Caskroom/android-sdk/25.2.3/platform-tools/adb start-server
[16:59:48]: ▸ * daemon not running. starting it now at tcp:5037 *
[16:59:48]: ▸ * daemon started successfully *
[16:59:48]: Attemting to apply custom config to TestAvdList
[16:59:48]: No config file found for AVD 'TestAvdList'. AVD won't have config.ini applied.
[16:59:48]: Launching all AVDs at the same time.
[16:59:48]: Waiting for AVDs to finish booting.
[16:59:48]: Performig wait for ADB boot
[16:59:48]: $ /usr/local/Caskroom/android-sdk/25.2.3/emulator/emulator -port 5556 -avd TestAvdList   &>/var/folders/n3/kxvcvj0d7d52dds2jtm_mxs4000086/T/emulator_output20170612-2178-18zme14&
[16:59:58]: $ /usr/local/Caskroom/android-sdk/25.2.3/platform-tools/adb devices
[16:59:58]: ▸ List of devices attached
[17:00:08]: $ /usr/local/Caskroom/android-sdk/25.2.3/platform-tools/adb devices
[17:00:08]: ▸ List of devices attached `

After running a command, device isn't running.
/usr/local/Caskroom/android-sdk/25.2.3/emulator/emulator -port 5556 -avd TestAvdList
because of the error: Segmentation fault: 11
Did anyone had a similar issue?

Hello,
When plugin is scanning your PC for visible devices - try open terminal and type adb devices is response empty too at that time?
Second error is weird. I haven't seen it.
Try upgrading your SDK to something similar to this:

Beware Android Emulator ver higher than 26.03 and Android SDK Platform-Tools higher than 25.06 - it's bugged atm.

Thank you for the response. The list is also empty when I try adb code so the problem is not in the plugin.

I'm having the same problem about the empty list of attached devices. Do you know how to handle it?


HADOOP-16276. Fix jsvc startup command in hadoop-functions.sh due to jsvc >= 1.0.11 changed default current working directory

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
89
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

0
shelldocs
0
Shelldocs was not available.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1238
trunk passed

+1
mvnsite
82
trunk passed

+1
shadedclient
781
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1
mvninstall
58
the patch passed

+1
mvnsite
78
the patch passed

+1
shellcheck
5
There were no new shellcheck issues.

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
840
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
unit
140
hadoop-common in the patch passed.

+1
asflicense
30
The patch does not generate ASF License warnings.

3455

Subsystem
Report/Notes

Docker
Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1272/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1272

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs

uname
Linux 63de4b65f56a 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 9b8359b

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1272/1/testReport/

Max. process+thread count
310 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1272/1/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.4.6

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
972
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

0
shelldocs
0
Shelldocs was not available.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1315
trunk passed

+1
mvnsite
76
trunk passed

+1
shadedclient
732
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1
mvninstall
61
the patch passed

+1
mvnsite
79
the patch passed

+1
shellcheck
4
There were no new shellcheck issues.

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
854
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
unit
136
hadoop-common in the patch passed.

+1
asflicense
34
The patch does not generate ASF License warnings.

4369

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1272/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1272

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs

uname
Linux 1a4e5e8ad3c2 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 6244502

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1272/2/testReport/

Max. process+thread count
412 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1272/2/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.4.6

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
40
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

0
shelldocs
0
Shelldocs was not available.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1083
trunk passed

+1
mvnsite
73
trunk passed

+1
shadedclient
652
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1
mvninstall
50
the patch passed

+1
mvnsite
58
the patch passed

+1
shellcheck
4
There were no new shellcheck issues.

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
696
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
unit
121
hadoop-common in the patch passed.

+1
asflicense
28
The patch does not generate ASF License warnings.

2907

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1272/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1272

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs

uname
Linux 128b89949853 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / ee7c261

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1272/3/testReport/

Max. process+thread count
456 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1272/3/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.4.6

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
48
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

0
shelldocs
0
Shelldocs was not available.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1264
trunk passed

+1
mvnsite
81
trunk passed

+1
shadedclient
679
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1
mvninstall
50
the patch passed

+1
mvnsite
68
the patch passed

+1
shellcheck
5
There were no new shellcheck issues.

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
764
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
unit
173
hadoop-common in the patch passed.

+1
asflicense
35
The patch does not generate ASF License warnings.

3293

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1272/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1272

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs

uname
Linux 933b18e232bb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 3329257

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1272/4/testReport/

Max. process+thread count
411 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1272/4/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.4.6

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
1685
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

0
shelldocs
0
Shelldocs was not available.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1533
trunk passed

+1
mvnsite
95
trunk passed

+1
shadedclient
860
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1
mvninstall
71
the patch passed

+1
mvnsite
86
the patch passed

+1
shellcheck
6
There were no new shellcheck issues.

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
931
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
unit
154
hadoop-common in the patch passed.

+1
asflicense
34
The patch does not generate ASF License warnings.

5593

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1272/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1272

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs

uname
Linux 8b24bac0e96c 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 915cbc9

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1272/5/testReport/

Max. process+thread count
307 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1272/5/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.4.6

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

+1


[BUG] incorrect hightlighting

Please search existing issues to avoid duplicates.
Details

Atom version: 1.34.0
Julia version: 1.1.0
OS: MacOS 10.14.3
Package versions:

Atom.jl: 0.7.15
julia-client: 0.7.13
ink: 0.9.14

Steps to reproduce
ex = [
    :(function foo end),
    :(foo(x) = x),
    :(foo(x, y::T) where T),
    :(foo(x, y::T) where T = x)]

this end is not in the same color with function.
PS. seems whatever github uses has this error as well.

Very similar to https://github.com/JuliaEditorSupport/atom-language-julia/issues/140, so closing this. And yes, github uses the exact same syntax highlighting rules (just like VSCode).


Print Or Export - Home Page

Component to export the contents from autographa (HTML, USFM, PDF etc.)

Moved to #230


Create documentation for Multi Region APIM Deployment for both APIM 3.2.0 and 4.0.0

Description:
We do not have a document on $subject.  It is a required patter for high availability. Therefore, it is essential that we have these.
Suggested Labels:
API-M-3.2.0
API-M-4.0.0
Priority/High
Suggested Assignees:
Affected Product Version:
All versions from 3.2.0 onwards

I touched base with Tharindu in this regard. As suggested by him, I will schedule a meeting in this regard with Tharindu and Bhathiya to come to a conclusion as to how best to proceed in this matter.


Make sure --deploy-rethink-as-rc works with 'deploy local'

LGTM

May be a good opportunity to address
https://github.com/pachyderm/pachyderm/issues/1196
But in the spirit of small PRs, that can be done separately.


What to do with Task#foreach ?

Task#foreach triggers side effects and doesn't behave like Future#foreach, in that it doesn't log errors.
We need to decide what to do with it. Solutions:

we make it behave like Future#foreach, to report errors via Scheduler#reportFailure
we make it return a Task instead, but this helps with nothing imo
we deprecated it in 3.0.0-RC2 and then remove it in 3.0.0

Opinions?

2. is a no-go:

There's already Task#foreachL that returns a Task[Unit]
for-syntax might be silently broken:

for (a <- taskA; b <- taskB) println(a + b)

//desugars
taskA.foreach {a =>
  taskB.foreach(b => println(a + b)) // discarded value, so loop is no-op!
}

I think it's ok to deprecate it and leave for a while with a message to use runAsync or runSyncUnsafe instead. That means losing for-loop support, however.

Also, foreach is essentially implemented as map { a => f(a); () }.runAsync
So the issue you mention means that there is a more general bug: exceptions thrown inside map might not get reported. That has to be fixed.

Unfortunately I don't have time now to play around with it too much but I agree with @oleg-py that the problem might be with map. Shouldn't it reportFailure somewhere?

It should, but it doesn't and I got a confused user on Gitter complaining about it.
The current behavior is wrong, along with its signature.
Returning CancelableFuture[Unit] is also a bad idea for the same reason that @oleg-py mentioned above ... the result will not wait on an inner-for, this isn't a flatMap that we are describing, so returning a Future in here gives a false sense of what the thing does.
We need to get rid of it.
And first we'll fix the implementation to report errors and @deprecate it for 3.0.0-RC.

I have problems reproducing the behavior. Seems like map is catching things, like expected.