Signal Strength for Wifi Data

Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR.
e.g.

Fix #123
Related #456

Checklist

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I titled the PR using Conventional Commits.
[ ] I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
[ ] All existing and new tests are passing.
[ ] The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
[ ] No, this is not a breaking change.

Hello! Your PR doesn't follow the Contributing Guidelines, nor does provide a valid PR description or title.
Plus, the feature only supports Android, and as per the contributing guidelines all new features must support at least Android and iOS to be considered, with a plan to support all platforms.
Please make sure to address this, otherwise we will have to close this PR.


sdk_version file missing

 $ cmake -GNinja -DBOARD=esp32 ..
CMake Deprecation Warning at /Users/anujdeshpande/code/zephyr/cmake/app/boilerplate.cmake:38 (cmake_policy):
  The OLD behavior for policy CMP0000 will be removed from a future version
  of CMake.

  The cmake-policies(7) manual explains that the OLD behaviors of all
  policies are deprecated and that a policy should be set to OLD only under
  specific short-term circumstances.  Projects should be ported to the NEW
  behavior and not rely on setting a policy to OLD.
Call Stack (most recent call first):
  CMakeLists.txt:2 (include)

-- Found PythonInterp: /Users/anujdeshpande/miniconda3/bin/python3 (found suitable version "3.6.3", minimum required is "3.4")
-- Selected BOARD esp32
Zephyr version: 1.12.99
CMake Error at /Users/anujdeshpande/code/zephyr/cmake/host-tools-zephyr.cmake:24 (message):
  The file '/Users/anujdeshpande/code/zephyr/sdk_version' was not found.  Is
  ZEPHYR_SDK_INSTALL_DIR=/Users/anujdeshpande/code/zephyr misconfigured?
Call Stack (most recent call first):
  /Users/anujdeshpande/code/zephyr/cmake/host-tools.cmake:1 (include)
  /Users/anujdeshpande/code/zephyr/cmake/app/boilerplate.cmake:248 (include)
  CMakeLists.txt:2 (include)

-- Configuring incomplete, errors occurred!

I am trying to get the basic hello world to run - can't seem to find a file called sdk_version. As far as I can see there is no such file in the project directory.
a comment from #2111 says that there ought to be one.
Another recent issue says that older project directories did not have the sdk version file (comment on #5626) - but the present sdk project does not have it.

Is there a script that is supposed to be run that creates this said file?

Did you
export ZEPHYR_TOOLCHAIN_VARIANT=espressif
?

Hi @anujdeshpande,
It seems to be issue with "ZEPHYR_SDK_INSTALL_DIR" pointing to wrong directory.
Please be aware that Zephyr SDK(Zephyr Software Development Kit - necessary tools and cross-compilers needed to build the kernel on all supported architectures) and Zephyr RTOS - Project source code are two different projects.
Please check the following points:

Is this the correct SDK install directory

ZEPHYR_SDK_INSTALL_DIR=/Users/anujdeshpande/code/zephyr

Try reinstalling SDK by following steps in the link, if required:
http://docs.zephyrproject.org/getting_started/installation_linux.html

You additionally need to add/update following variables:

required to build esp32

export ZEPHYR_TOOLCHAIN_VARIANT=espressif
export ZEPHYR_SDK_INSTALL_DIR="sdk installation directory"
If case, you do not have esp32 toolchain, install it from the link and update the variables properly:
export ESP_IDF_PATH="/path/to/esp-idf"
export ESPRESSIF_TOOLCHAIN_PATH="/path/to/xtensa-esp32-elf/"

ZEPHYR_SDK_INSTALL_DIR doesn't seem to be the problem - checked and double checked.
Removing all variables and setting them again worked. Not sure what was the issue.

ZEPHYR_SDK_INSTALL_DIR doesn't seem to be the problem - checked and double checked.
Removing all variables and setting them again worked. Not sure what was the issue.

I would say that this is transient bug - It appeared for me. Building in new context (another terminal instance) solves the problem.


Publish to Operator Hub

Are there any plans to publish the operator on OperatorHub?
That would ease the maintenance of the operator via OLM.

Duplicate https://github.com/dragonflydb/dragonfly-operator/issues/131. (saw it as soon as I opened it :facepalm: )


Fix syntax highlight for XML, CSS, JS

If a file ended with a multi-line comment, highlighting for the subsequent file does not work properly.
The fix resets the corresponding flag.
Before:

After:

add a unit test?

css and js don't have any UTs. that for another time to create some.


All NaNs in processed timeseries

behavior_700708_2024-06-27_08-43-37_processed_sfn_rachel
ID: 37a74f48-c2c5-4921-bacd-fcd450126806
G_1 and G_2 have numeric values
G_1_dff-* and G_2_dff-* are all NaNs

@Ahad-Allen Can you take a look at this?

@j-friedrich will look into this and figure out what is going on.

G_1 and G_2 include NaNs at the end of the recording, which - looking at the traces - should have stopped earlier. Do we always have to cut off a few frames at the end?

Detect first NaN, discard all other data from the session for the purpose of dF/F and motion correction.
Log that this happened as a QC metric.

TLDR: QA should take care of this by calculating derivative and then tossing the data after.
The best metrics would be:
-sudden large change in the 1st derivative of (multiple, more than two) traces simultaneously
Some rationale for why hardware/rawdata cannot be NaN:
-CMOS minimum values are 255 (in 16it)
-there is always sensor floor noise, so cannot be constatly 255 even there is no photon
-if you unplug patchcables in a really bright situation, the value would be saturated at 655xx (max in 16bit)
-if you unplug in a dark situation, ~255+noise
__
@j-friedrich
could you please go through processed data and collect sessions with NaN (after preprocessing)?
we can then check them together to confirm if this mostly happens when unplugged before acquisition stopped or not.


docs: add SimpliField to users

Motivation
SimpliField love to use docusaurus 🙏
Have you read the Contributing Guidelines on pull requests?
Yes I did
Test Plan
I tested running the app locally

Hey @yangshun. I got it, thanks for your feedback.
I didn't get that the link have to be a docusaurus one.
Actually our doc is for an internal purpose, so I cannot provide the urls.
I hope we could share it in the future.

I see, thanks for the explanation. In that case we can't add SimpliField to the users page now, but we would consider separating that page into a showcase and users list where users are simply just users without having to showcase their usage. Thank you for your understanding!


Hook up integration test for Index Management Kibana Plugin

Request adding integration test for Index Management Kibana plugin to the build workflow with and without security plugin
With security: yarn run cypress run --env security_enabled=true
WIthout security: yarn run cypress run
Index Management Cypress PR

Hi @bowenlan-amzn ,
I was working on adding the above integration tests in build workflows however it appears that the tests are flaky.
The below tests passed when I reran it:
TAR with security: https://github.com/opendistro-for-elasticsearch/opendistro-build/runs/2188572814?check_suite_focus=true
Failing tests:
RPM with no security: https://github.com/opendistro-for-elasticsearch/opendistro-build/actions/runs/684530878
TAR with no security: https://github.com/opendistro-for-elasticsearch/opendistro-build/actions/runs/684355635
Passing tests:
RPM with security: https://github.com/opendistro-for-elasticsearch/opendistro-build/actions/runs/684541062
DEB with security: https://github.com/opendistro-for-elasticsearch/opendistro-build/actions/runs/684453251/workflow
DEB without security: https://github.com/opendistro-for-elasticsearch/opendistro-build/actions/runs/684493940
Can you please look into it and let me know the next steps?
Thanks!


TiFlash failed to replicate data from TiKV in the master branch

Bug Report
Please answer these questions before submitting your issue. Thanks!
1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)
3. What did you see instead (Required)
https://do.pingcap.net/jenkins/blue/organizations/jenkins/pingcap%2Ftiflash%2Fpull_integration_test/detail/pull_integration_test/492/pipeline/372
In the CI intergrate testing, tiflash failed to replica data from TiKV, with error logging like
[2024/06/14 11:44:39.043 +08:00] [ERROR] [kv.rs:774] ["dispatch raft msg from gRPC to raftstore fail"] [err=Grpc(Codec(WireError(InvalidEnumValue(15))))] [thread_id=0x5]
[2024/06/14 11:44:39.043 +08:00] [ERROR] [kv.rs:781] ["KvService::batch_raft send response fail"] [err=RemoteStopped] [thread_id=0x5]
[2024/06/14 11:44:44.046 +08:00] [INFO] [kv.rs:737] ["batch_raft RPC is called, new gRPC stream established"] [source_store_id=Some(1)] [thread_id=0x5]
[2024/06/14 11:44:44.047 +08:00] [ERROR] [kv.rs:774] ["dispatch raft msg from gRPC to raftstore fail"] [err=Grpc(Codec(WireError(InvalidEnumValue(15))))] [thread_id=0x5]
[2024/06/14 11:44:44.047 +08:00] [ERROR] [kv.rs:781] ["KvService::batch_raft send response fail"] [err=RemoteStopped] [thread_id=0x5]
[2024/06/14 11:44:49.054 +08:00] [INFO] [kv.rs:737] ["batch_raft RPC is called, new gRPC stream established"] [source_store_id=Some(1)] [thread_id=0x5]

It's because tikv introduce a new precheck process before snapshot generation https://github.com/tikv/tikv/pull/17019 for
resolving issue https://github.com/tikv/tikv/issues/15972. While tiflash-proxy does not updated and don't recognize the new type of raft message.
4. What is your TiFlash version? (Required)
master

@CalvinNeo Do we have UT for replicating data from TiKV? From my point of view, it's a very basic feature.

@CalvinNeo Do we have UT for replicating data from TiKV? From my point of view, it's a very basic feature.

We have ut in both tiflash and tiflash proxy. Check https://github.com/pingcap/tidb-engine-ext/tree/raftstore-proxy/proxy_tests for example.
However, this is not a case that a UT should cover, because the mutation happened in TiKV.


makemake: Switch to latest buildbot and use GH app

This came up while working on #347. It switches the flake to follow nix-community/buildbot-nix instead of Mic92/buildbot-nix (it's a redirect either way) as well as switches to the new GitHub app authentication for Buildbot instead of legacy tokens.

I don't care about the names. @lorenzleutgeb feel free to redo the thing as you please :)

Uh. Looks like status checks on infra/makemake and infra/overview are no longer valid with GitHub app auth?

As I don't have access to the org and app settings, I'm not sure what might be wrong here. We can switch back to the legacy auth to see if it unblock PRs until we figure out what's going on.

Me neither, although I suppose the rules mentioned here need to be adjusted.


Emit signposts for request handling

This allows you to trace sourcekit-lsp in Instruments to get a feeling for how long requests take to be handled. I’m not sure how useful this will be in practice but we can’t really know until we have it in a build that we see an issue with, so I’d propose we put it in and if we never use it in the next year or two, we can rip it back out again.

@swift-ci Please test

@swift-ci Please test

@swift-ci Please test Windows

@swift-ci Please test Windows


155

This is primarily a simplification and method extraction refactor. The largest code flow change is that deploy() now chooses the saved trained model or fits the regressor which is then passed in to find_top_three_factors

In light of our conversation, I converted the two simple_develop_examples into unit tests and added a third.


Fix CI packaging, format

Fixes the packaging build failure on main:

nginx: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.38' not found (required by /usr/lib/x86_64-linux-gnu/rustls-libssl/libssl.so.3)

As well as the clang-format error.
Also complete a TODO to replace 24.04 with ubuntu-latest.

16 successful and 3 expected checks

Admin merged & then updated the branch protection rules to replace the ubuntu-24.04 labelled ones with ubuntu-latest labelled ones.


Document Depth auto power down

Depth camera will power down to preserve device life if it detects frames have not been read from the device for more than 60s.
This is note worthy in the case of being a subordinate device, if the master takes more than 60s, then depth will not start.

it is documented in our Azure Kinect documentation.


fix: design module register menubar

Types

[x] 🐛 Bug Fixes

Background or solution
Changelog

/next

/next

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.:white_check_mark: life2015:white_check_mark: bytemain:x: zhanbaYou have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.:white_check_mark: life2015:white_check_mark: bytemain:x: zhanbaYou have signed the CLA already but the status is still pending? Let us recheck it.

/next


fix(firestore): fix an issue that would cause FieldValue.increment to not work for big int

Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues
closes #1218
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[ ] All existing and new tests are passing.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] The analyzer (melos run analyze) does not report any problems on my PR.
[ ] I read and followed the Flutter Style Guide.
[ ] I signed the CLA.
[ ] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change.
[ ] No, this is not a breaking change.

Hello,
I've observed a change in behavior when using FieldValue.increment(1) with cloud_firestore after updating to a new version. Previously, when incrementing a field in Firestore, the incremented value would be received as an integer. However, now it appears to be received as a double.
The relevant code modification seems to be in packages/cloud_firestore/cloud_firestore_platform_interface/lib/src/method_channel/utils/firestore_message_codec.dart, where an adjustment was made to handle FieldValueType.incrementInteger as (delegate.value as int).toDouble() internally, to avoid precision loss:
} else if (value is FieldValuePlatform) {
    MethodChannelFieldValue delegate = FieldValuePlatform.getDelegate(value);
    final int code = _kFieldValueCodes[delegate.type]!;
-    buffer.putUint8(code);
-    if (delegate.value != null) writeValue(buffer, delegate.value);
+    if (delegate.type == FieldValueType.incrementInteger) {
+        buffer.putUint8(_kIncrementDouble);
+        writeValue(buffer, (delegate.value as int).toDouble());
+    } else {
+        buffer.putUint8(code);
+        if (delegate.value != null) writeValue(buffer, delegate.value);
+    }
}

Is this change intentional? It seems to introduce inconsistencies with how incremental updates are handled and serialized. For a temporary workaround, I've specified cloud_firestore_platform_interface: 6.1.7 in my pubspec.yaml.
Could someone clarify if this is the intended behavior moving forward and suggest how we might adjust our code to accommodate this change effectively?
Thank you.

Already reported and tracked here: https://github.com/firebase/flutterfire/issues/12436


BLE disconnected, reason code: 520

Hi NimBLE developers,
Through this post, I would like to share some issues I am facing now and ask for some feedback/help if possible.
Laptop OS: Ubuntu 22.04
Real-time operating system (RTOS): RIOT OS (newest)
Bluetooth Low Energy (BLE) stack: NimBLE in RIOT OS
Development boards: feather-nrf52840-sense
Examples/Apps used: NimBLE "central" and "peripheral" implemented in RIOT OS
As shown above, I am currently developing some BLE applications based on NimBLE and RIOT OS. However, some issues showed up. In the beginning, I tried the existing BLE examples in RIOT OS together with my phone, i.e., "nimble_gatt" and "nimble_heart_rate_sensor". When I tried to connect my phone (Android) to the development board (feather-nrf52840-sense), GATT 133 connection error happened. This error was shown in the "nRF Connect" app on my Android phone. By checking the error code table, it basically suggests a connection timeout.
To make sure it is not an issue of Android (Since some complaints can be seen online about Android BLE already.), I further developed two applications using NimBLE on RIOT, based on “central” and “peripheral” applications from GitHub mynewt-nimble project. They were flashed to two feather-nrf52840-sense boards respectively. However, again, the connection cannot be continued due to connection timeout. This time, the NimBLE offers an error code of 520 (decimal), i.e., 0x0208 (hex), which suggests connection timeout. The peripheral board this time can be connected to my Android phone sometimes without an error or connection loss. But still, the GATT 133 connection error occurs from time to time.
However, after looking into a sniffer record, I notice that the BLE connection has never been established properly, which is the reason why the connection timeout occurs all the time. According to the sniffer, after receiving the advertisements from the peripheral, the central initializes the connection establishment. However, after few connection events (1 ~ 25) between the central and the peripheral, the peripheral does not respond to the central anymore. What I see is that all the packets are from the central to the peripheral, and there are no packets from the peripheral to the central. Besides, all the packets from the central are retransmissions. After multiple retransmissions, the connection is lost due to connection timeout (I suppose it reaches the defined supervision timeout). Then the peripheral starts to advertise again, and the above process is repeated.
It is worth mentioning that I also tried the above examples on an nRF52840dk board. It seems they work properly on it, e.g., the nRF52840dk can be connected to my phone without a connection loss due to timeout.
If possible, I would like some help with this case. Are there any explanations for it? What can I do to avoid/solve it?
Thanks in advance for any possible reply and help.

could you please share sniffer trace?

20240514_Sniffer_files.zip
Hi @andrzej-kaczmarek, please find in the attachment two sniffer traces. One for the connection between two feather-nrf52840-sense board (central + peripheral), the other one for the connection between an Android phone (central) and a feather-nrf52840-sense board (peripheral).

Thanks. The connection is established properly since there are PDU from both sides on 1st connection event, but then slave indeed stops responding on events.
The problem is likely clock accuracy setting. The nRF52840 Feather board file includes cfg_clock_32_0.h which sets LFCLK to LFRC since it doesn't have LFXO by default. This requires clock accuracy in the range of 251-500ppm so you need to set BLE_LL_SCA=500 in NimBLE configuration (syscfg) to make it work properly. Also LFRC needs to be calibrated iirc.
The nRF52840 DK board includes cfg_clock_32_1.h which sets LFCLK to LFXO so the default accuracy (60ppm) is more than enough and thus it works properly ootb.

Hi @andrzej-kaczmarek, indeed, the clock accuracy setting is the cause. Thanks a lot for your straight-to-the-point answer and help!


Allow to alter JUnit output file name

We've come up with innovative way to screw things up: the test binaries have the same test group, but test different things (probably not uncommon). If they run in the same "make check" or similar, we get only 1 file instead of as many as binaries.
It seems that cpputest either needs to append "package" to file name (as we can easily say that these tests are for different packages), or provide some other way to alter file names to make them unique (extra "prefix" argument?).
Am I right that currently there is no way to alter the junit output behavior? IMO, we need to add it.
Seems to be lacking part of #263...

It seems that my observation is correct.
Can anybody suggest the best way to fix this?
I mean that I see some options, but not sure what option fits cpputest design the best:

Modify the file name generator to include something additional. E.g. it can be program name (argv[0]). But program name alone will not help if we have working directory like "/work" and programs "a/test", "b/test", etc. Probably need to include also program path replacing slashes with underscores? (Windows vs Linux issues...)

Modify -ojunit to have optional =prefix. Is it natural to cpputest? Do we need to support = vs   (space)? Variations...

Introduce new argument like report-prefix for the prefix (should it be postfix?).

Introduce some variation of -ojunit, like -ojunit-with-prefix <prefix> that needs extra prefix after the argument...

I'm not sure what to choose. Proposals?

Same test group in same binary, right? Just in different directories?

Well... For me different binary name may be fine as well. Just before doing something, better to see what potential usage scenarios may be.
I can guess that someone could have UTs per some component and they may decide to name those like: a_ut, b_ut, or may instead have a/ut and b/ut.
And then something like test group "startup" or similar is very likely to appear in both.
And then some CI may want to just run all UT binaries from the same working directory (e.g. "make check" or similar).
So, we can do something simple, like adding binary name, or binary+path from working directory, or allow custom prefix.
As I wrote, I'm not sure how to decide.

So, you run the different binaries with the same current dir? And in the different binaries is the same test group?

Yes, in the case we faced it happens to be like that: same working directory and test group collision between binaries. And so we cannot get full Junit report as only one binary wins.
And in our case binary names are different. But in general case, I'm not sure if this can be assumed.

I would suggest to not add a feature related to this and instead fix this in the build process. You ought to be able to run them from different current dirs relatively easily.
If we do want to fix it, then I would suggest to add -junit-output-dir as parameter or something like that. That seems more useful than a prefix. Though it would lead to additional depdenencies on the file system and I'm not completely happy with that.

After some internal discussion, we got a question: why is the package parameter present, but file name is not impacted by package? It seems to have been done exactly for this use case, when test groups collide.
Can we adjust cpputest file name to include package name if provided via existing parameter in command line?

Yeah, I think that would actually make sense....


[Lint] Turn off unnecessary rules in test code

Description
This is the second follow-up smaller PR to https://github.com/corona-warn-app/cwa-app-ios/pull/104. Together with the other PRs I will be posting, all SwiftLint warnings should be fixed to allow us to enable the --strict mode of SwiftLint on the CI to prevent any new warnings getting merged in the future.
Related PRs
https://github.com/corona-warn-app/cwa-app-ios/pull/516, https://github.com/corona-warn-app/cwa-app-ios/pull/522, https://github.com/corona-warn-app/cwa-app-ios/pull/527, https://github.com/corona-warn-app/cwa-app-ios/pull/531, https://github.com/corona-warn-app/cwa-app-ios/pull/534.
Note that all these PRs are completely independent and can be merged in any order.

Thank you very much for this PR. I will put this on hold for the next couple of days because we are in a critical phase in the project at the moment. I hope you understand. We will come back to you once this phase is over.

@inf2381 Why was this closed? Could you please give an explanation instead of just closing it? Thank you.


feat(share/eds): implement eds-store metrics

Implementation ideas
It is very hard to understand performance and stability of eds store operations without proper metrics. Add metrics coverage for eds-store.

Add metric for long put operations https://github.com/celestiaorg/celestia-node/pull/2516#issuecomment-1655285757

Implemented in https://github.com/celestiaorg/celestia-node/pull/2536


Scaling experiments

Updated readme.
SLURM multi node training changes and example bash script.
HQQ Lora training changes.

Closing per discussion with @KeremTurgutlu, as the HQQ changes are also in #14.


<EMAIL_ADDRESS>decompress error

Installing 'avidemux' (2.8.1) [64bit] from extras bucket
Avidemux_2.8.1.VC++.64bits.exe (38,1 MB) [====================================================================] 100%
Checking hash of Avidemux_2.8.1.VC++.64bits.exe ... ok.
Extracting dl.7z ... ERROR Exit code was 2!
Failed to extract files from C:\Users\femao\scoop\apps\avidemux\2.8.1\dl.7z.
Log file:
~\scoop\apps\avidemux\2.8.1\7zip.log
Please try again or create a new issue by using the following link and paste your console output:
https://github.com/ScoopInstaller/Extras/issues/new?title=avidemux%402.8.1%3A+decompress+error

Duplicate of #9689


can't get order to charge on stripe

Able to create a token but can't grab it and charge.  Here is my code:
 app.post('/charge', function(req, res) {
  var stripeToken = req.body.stripeToken;
  var amount = 9;

  stripe.charges.create({
      source: stripeToken,
      currency: 'usd',
      amount: amount
  },
  function(err, charge) {
      if (err) {
          res.send(500, err);
      } else {
          res.send(204);
      }
  });
});

This is more of a question about Stripes library than the provided sample.
Can you clarify what errors your running into when trying to make a charge with the provided code?

@cgilhoi I got it working with Stripe as shown here: https://gist.github.com/thorsten-stripe/9928b11dbf45980af058c3284aafd416

@cgilhoi I got it working with Stripe as shown here: https://gist.github.com/thorsten-stripe/9928b11dbf45980af058c3284aafd416
And yes, the error message would be helpful 👍

Yeah, I was finally able to get it to work too.  Next step is trying to assemble a cart.  Lots of work.  Do you have an app that does transactions in production?

From: Thor<EMAIL_ADDRESS>Sent: Wednesday, November 7, 2018 3:51 AM
To: actions-on-google/dialogflow-transactions-nodejs
Cc: cgilhoi; Mention
Subject: Re: [actions-on-google/dialogflow-transactions-nodejs] can't get order to charge on stripe (#14)
@cgilhoihttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fcgilhoi&data=02|01||99b852ee161743f09f4e08d644969870|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636771810915051870&sdata=u85kF0jwprcEPPNebbySnY3%2FPT1jpWOiH%2FeJFSrHHm4%3D&reserved=0 I got it working with Stripe as shown here: https://gist.github.com/thorsten-stripe/9928b11dbf45980af058c3284aafd416https://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgist.github.com%2Fthorsten-stripe%2F9928b11dbf45980af058c3284aafd416&data=02|01||99b852ee161743f09f4e08d644969870|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636771810915051870&sdata=vkmB9aRGp54DGUDNdRC1Q28C6PzG6nzH2LTHunDaFmg%3D&reserved=0
And yes, the error message would be helpful 👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Factions-on-google%2Fdialogflow-transactions-nodejs%2Fissues%2F14%23issuecomment-436567211&data=02|01||99b852ee161743f09f4e08d644969870|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636771810915051870&sdata=KMZzuDsNx%2BAO3N%2FRX9DDvmsOUftAlWGrFeojhQqEPHM%3D&reserved=0, or mute the threadhttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAUPypiyAjiSW0XbLk-pnzvCiqCy7rQD6ks5usq0ggaJpZM4UxRbC&data=02|01||99b852ee161743f09f4e08d644969870|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636771810915051870&sdata=sYl8KtkWjTR6I4kRGhPLXHRx93W4BhkfJ6BHc8YeOgo%3D&reserved=0.


investigate whether custom high resolution alarms are compatible with autoscaling

https://blog.powerupcloud.com/aws-autoscaling-based-on-database-query-custom-metrics-f396c16e5e6a


color on BlockLink is overridden by color: inherit;

When setting color on a BlockLink, it is overridden by the color: inherit; style from the component itself.
<BlockLink to={`/some/url`} color="white">GO</BlockLink>

Good catch, thanks! The color value should be set in the props object instead of the style object – feel free to open a PR otherwise I'll try to patch this in the next release

That's odd, I was expecting the rules to be added in the order they're defined and the ones from props to be defined last....

Oh, ignore me, for some reason GH wasn't showing me the activity and I just replied to the original issue. I see this is fixed and what the issue was. 👍 thanks for addressing this so soon.

@jxnblk I opened #323 to fix this issue, could you please take a look?


updated cheerio and added option to preserve entities

Hi @Keyes, we have a new version of grunt-nginclude coming up that seems to solve your problems. Could you take a look at #9 or even try it and give us some feedback?

Closing issue as functionality is available in new version


Clarity regarding dotnet Spark Job definition dependencies for Synapse

There are a few things that were unintuitive about the documentation when we initially set up our .NET Spark project.

We built using 2.1.0, and spent time trying to figure out why the DotNetRunner was timing out.
We found out we had to use 1.0.0 with our spark pool, and got a SerDe error when attempting to debug locally.

@cutecycle : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@cutecycle : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@cutecycle : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@cutecycle : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@juluczni - If you approve these changes, lines 27-40 must be indented three spaces before this PR can be merged.
#label:"aq-pr-triaged"

after going through some local development environment setup, there's a few things worthy of rewriting:

When setting up a spark pool, the Studio interface shows you what version of .NET Spark you should use. Of course, we started with scala notebooks and had the workspace deploying in ARM for months before prototyping the .NET Spark workflow, so we hadn't seen this one. I think it'd be ideal to call that out in a small compatibility table + screenshot at the top
I think the dotnet spark example should be project source code, rather than a pre-built executable, though that's out of scope of this PR.

@cutecycle : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#assign:SnehaGunda for review

@SnehaGunda can you check this one? I don't know why but it won't let me assign it to you.

@SnehaGunda can you check this one? I don't know why but it won't let me assign it to you.

Yes, I think you missed @ in the assignment.

@cutecycle thanks for the contribution. @mlee3gsd validated your fixes. Your PR will be merged soon.

#sign-off

@ShannonLeavitt can you please fix the indentation and merge the PR.

@SnehaGunda - I've fixed the indentation and made other minor edits as you requested. The indentation didn't look right in the GitHub view, so I staged the content in the private repo to confirm and also to take advantage of automated checks.
Can you please address the following issue in a new PR in the private repo?
articles/synapse-analytics/spark/media/apache-spark-job-definitions/net-spark-workspace-compatibility.png

This new image needs to be moved to a folder dedicated to spark-dotnet.md; it shouldn't be in the apache-spark-job-definitions media folder. Please open a new PR to move the image.

I'll merge now.


[WIP] Add support for Multiselect Dropdown List Widget

Added support for Multiselect Dropdown List Widget (MLDW ) by using prototypal inheritance which inherits from the existing dropdown_list_widget.
Essentially adopted a cleaner methodology than using if/else ladders within the dropdown_list_widget itself (#17674).
TODOs:
Major

[ ] Implement a better way to add check marks to dropdown items. Since, the current methodology interpolates unescaped text into HTML.
[ ] Handle scenarios where user triggers the Reset button with MLDW.

Minor

[ ] Add tooltip to MLDW button displaying all the items checked by user (if the items checked exceeds the limit).
[ ] Add node tests for MLDW.
[ ] Fix failing list_widget node tests to regain coverage.
[ ] Improve overall styling.
[ ] Better commit messages (obviously!)

Usage:
Initial prototype when implemented in Move Topic dropdown as an example!
const opts = {
  widget_name: "select_stream",
  data: streams_list,
  default_text: $t({ defaultMessage: "No streams" }),
  include_current_item: false,
  value: [current_stream_id], // Defines the existing items that should be present in dropdown.
  limit: 3, // Maximum items to display in button.
};

Corresponding template:
{{> dropdown_list_widget
  widget_name="select_stream"
  filter_button_text = (t 'Filter')
  list_placeholder=(t 'Filter streams')}}

Yields:

@aryanshridhar I think this approach is way cleaner than the one we were going for in #17674. 😄 (FYI the node tests are failing because of loss of coverage)

I posted a few comments. Also posted in the CZO thread about whether we can avoid the bootstrap changes; I'd much prefer to not change third-party libraries unnecessarily; if we do so, we'll want to document it in the comments we have about what we've changed.
I think aside from these relatively minor things, we should merge this and then start working on UI for a few of the places where we want to use these, which may suggest further changes to the library itself.

think aside from these relatively minor things, we should merge this and then start working on UI for a few of the places where we want to use these, which may suggest further changes to the library itself.

Cool updated it @timabbott. Yup, I am almost done with its implementation in recent topic view in my local sub branch. Will rebase and push it.


Share dataset problems in both cloud and onpremise after removing groups

This fixes the issue causing CartoDB/support/issues/1057.

Answered. Take a look and move to acceptance if ok.

Deployed master to the same server and the error goes away, so it seems somewhat related to this PR. Back to dev.

@ethervoid CR or unnasign this, please 🤗

Im on it trying to decipher the last commit xDD

Working fine. Tested group creation/deletion/rename/changing members, in conjuction with adding/removing permissions. Happy path works, and I was not able to break it in any other way. 🚀


3.0.0 beta.4

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: Zack:x: gaoliZack seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Update to latest fontmake v2, requires Python >= 3.6

the fontmake version currently used in noto-source repo is quite old (v1.8.0) and needs updating.
The current fontmake requires python3.6 or greater, so I have updated the build setup to look for python3 (or python3.6 or python3.7) executable when creating the build environment.

if you have cloned the noto-source repo before, you should delete the previous env folder before running again this new ./build setup command, as the old env was still using python2.7.


Issue with k8s.io/docs/setup/best-practices/cluster-large/

This is a Bug Report

Problem:
Missing max limit of k8s servces object in the documentation.
Proposed Solution:
when specify number of nodes, also can you specify the limit (if any) on number of k8s services, deployment objects?
Page to Update:
https://kubernetes.io/...

/language en
/sig scalability

/language en
/sig scalability
that solves the issue although Mr.tengqn mentioned it before


 with error Cannot create property 'semiMejorAxis' on string '{position:track.position,radius:5000,granularity:0.08}'

Intended outcome:
I want to add circle around plane 3D model so I use ac-circle
Actual outcome:
I got error below

How to reproduce the issue:
I cloned project from git@github.com:TGFTech/angular-cesium.git and add code below for ac-circle in track-layer.component.html at line number 49.

I'm not sure did I do something wrong. Could you please help me about this error.

hi, tried to add <ac-circle> to <track-layer> and all worked, checkout the images below....
maybe you did another thing that caused the error?

inside ac-layer you must use <ac-XXX-desc> components . check out this.
And for creating a sphere you can use <ac-ellipsoid-desc> ... good luck!

Hi eitanfr
Oh I made mistake, I have to use <ac-xxx-desc> components in <ac-layer>. Thank you for your advice.
I tried to draw sphere using <ac-ellipsoid-desc>. I work sometime. Sometime when I reload web page the spheres did not appear.
If I leave web page running for a while the sphere's position did not update along with track position like screenshot below

look at your props, you put an extra ','
your props be like that:
props="{
position: track.position,
radius: 40000.0,
granularity: 0.03
}"
instead of
props="{
position: track.position,
radius: 40000.0,
granularity: 0.03,
}"
let me know if it fixed your problem. @mrkimmy

look at your props, you put an extra ','
your props be like that:
props="{
position: track.position,
radius: 40000.0,
granularity: 0.03
}"
instead of
props="{
position: track.position,
radius: 40000.0,
granularity: 0.03,
}"
let me know if it fixed your problem. @mrkimmy

Hi EladIsraeli,
Sorry for lately reply.
Remove extra ',' not solve my problem.
As eitanfr's answer I have to use <ac-circle-desc> inside <ac-layer> that solved my problem.
Thank you.


add a preview line to show what will happen when you click while holding down alt

while holding alt to create a new point, it's not obvious from where the point will be connected. Since you're already holding down a key we might as well draw a line to show what will be created. This line should also disappear when hovering over an edge since clicking the edge will not create a point connected to the last point but rather split this edge

Closed by c2e5335f8fae4b16d8c8a57da25a12613b833dc6
Thanks Guy!


Dataquery fixing

changing apn_chr (string) for apn (i64). apn_chr sometimes contains "-" (hyphens) which we do not want to parse. also applying minor frontend color change

must be implemented with https://github.com/Greenetwork/BLX_backend/pull/4


Only works intermittently

I haven't been able to find a pattern.
Settings:

Close on Save: false
Max Open Tabs: 15
Open Tab Threshold: 0
Timeout Minutes: 15
What other information would you want?

Fixed in PR #9


Apply synchronous command timeout from the given context using RedisClient

RedisClient behaves in a strange way regarding the timeout. The default timeout is set from the initial RedisURI that is used to construct the client or 60 SECONDS if the client is constructed without a URI. Connections that are created without passing in a RedisURI apply the default timeout of the RedisClient as default connection timeout (connection defaults can be changed once the connection is created).
Connections that are created using a RedisURI argument get as well the default client timeout applied, not the one of the RedisURI.
Expected behavior:

Connections created without a RedisURI parameter using the connect(…) methods should use the RedisClient default timeout
Connections created with a RedisURI parameter using the connect(…) methods should use the timeout setting from the RedisURI

See also #271

Fixed.


[5.7] Move Unit tests from Auth folder to Unit/Auth folder.

We have the Integration folder for Integration tests.
Could we have also a Unit folder for unit tests?
In this PR I have moved tests from Auth folder to Unit\Auth folder. In case if it will be accepted, then I can move other tests.

I don't think this is necessary tbh.


[BUG] ... Toolkit won't load

Hi there,
Lately, when I've gone to open YNAB on my computer, I get the following message:
"Uh-oh!
An error occurred in Toolkit for YNAB (a browser extension you installed to enhance YNAB). Click here to report the issue to the YNAB Toolkit project."
I have not been able to locate the problem myself, and hope that you're able to help me. To be able to get YNAB to work, I have had to turn off the toolkit for now, however I really miss some of the features.
Best Regards,
Stine

Do you happen to have the "localization" feature on? If so, you'll need to disable that since it's no longer working after a few changes on YNAB's end.

If that's not what the issue is, please re-open a ticket filling out the form you deleted before opening this one.


[CARBONDATA-3676] Support clean carbon data files of stages.

Why is this PR needed?
At the end of the CarbonInsertFromStageCommand, the stage files will be cleared, but the data files which referenced by stage files will be not cleared. This could lead to a large backlog of data files。
What changes were proposed in this PR?
Provide a new command to allows us to delete data files which referenced by disabled table stages.
The new command is CarbonDeleteStageCommand.
Does this PR introduce any user interface change?

Yes

Is any new testcase added?

Yes

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/1845/

Build Failed  with Spark 2.4.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.4/141/

retest this please

does this command support deleting any folder which specified?

Build Success with Spark 2.4.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.4/143/

does this command support deleting any folder which specified?

Yes

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/1847/

retest this please

Build Success with Spark 2.4.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.4/153/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/1856/

LGTM

Better to avoid to specify the path if the path can be any path.

@niuge01 Why are you not using the executors to make this job parallel?
Not recommended to open threads in the driver, it will impact the other queries

Build Success with Spark 2.4.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.4/166/

retest this please

Build Success with Spark 2.4.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.4/169/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/1869/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/1871/

retest this please

Build Success with Spark 2.4.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.4/173/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/1876/


Event menu does not open when clicking on an event

Check that this is really a bug

[X] I confirm

Reproduction link
https://codesandbox.io/p/sandbox/xenodochial-currying-dxl85n?file=%2Fsrc%2FApp.js%3A19%2C16
Bug description
When trying to click an event, the menu doesn't open as expected,
but if I don't use withDragAndDrop,
then the problem goes away.
Or if i removed the "props.event.children" in EventComponent also the problem goes away.
You can examine the problem in the link I attached.
Expected Behavior
No response
Actual Behavior
The menu will show up as expected with - "WithDragAndDrop"
react-big-calendar version
1.5.2
React version
18.0.2
Platform/Target and Browser Versions
chrome 107.0.5304.107
Validations

[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
[X] Make sure this is a react-big-calendar issue and not an implementation issue

Would you like to open a PR for this bug?

[ ] I'm willing to open a PR

Apparently I have too many Draft sandboxes to make any changes to see, but...
My guess is you don't have the correct function component definition. You have
eventWrapper: (e) => {
            return <EventComponent event={e} />;
          },

Where you would need
eventWrapper: EventComponent

Which would automatically pass all props (including event) to the component. Remember that this not the same as a click event, but rather the event object from your calendar.

Apparently I have too many Draft sandboxes to make any changes to see, but...
My guess is you don't have the correct function component definition. You have
eventWrapper: (e) => {
            return <EventComponent event={e} />;
          },

Where you would need
eventWrapper: EventComponent

Which would automatically pass all props (including event) to the component. Remember that this not the same as a click event, but rather the event object from your calendar.

It still does not work.
I lowered to version 0.40.8 and it works fine
The problem is that it breaks other things for me because it's an old version


Fix broken headings in Markdown files

GitHub changed the way Markdown headings are parsed, so this change fixes it.
See bryant1410/readmesfix for more information.
Tackles bryant1410/readmesfix#1

thanks.


Include "type hints" with uploaded datasets

All datasets should be viewable with the to-be-built-in general vis modes (e.g., node-link diagram, adjacency matrix, hive plot, etc.), but some of the uploaders should mark the resulting datasets as also being viewable in specific, custom-built external applications (e.g., Jen's evo-bio app, etc.).

This might be a good thing to discuss with Derya (if I understand correctly, this concept aligns with Derya's research topic).


Release 200720

This branch/PR handles:

Name refactor for the MasterDetail sample. It's now ListDetail 😍
Improved and cleaned up code on many samples.
Added dependencies.gradle file + better way to handle dependencies.
Removed non needed files.
Removed duplicated resources that were making some samples not work.
The repo will be now ready to run our new CI pipeline. Fixed unit and instrumentation tests (even though are dummy yet), fixed issues regarding lint, pmd and checkstyle (analysis tools).

LG to the team! 🚀


Add documentation discussing storage scheduling use cases in more detail

By now we have accumulated quite some scheduling options (see https://flexmeasures.readthedocs.io/en/latest/api/notation.html#flex-model, and https://flexmeasures.readthedocs.io/en/latest/api/v3_0.html#post--api-v3_0-sensors-(id)-schedules-trigger)) that aren't really explained in detail anywhere else. I suggest we add a new documentation section (e.g. to https://flexmeasures.readthedocs.io/en/latest/tut/forecasting_scheduling.html or to https://flexmeasures.readthedocs.io/en/latest/api/notation.html#flex-model) where we can discuss some scheduling problems. There we can then also address the case detailed in #575, and what the client can do to set up this problem as a feasible scheduling problem. This will require some combination of using the soc-maxima and soc-minima fields, instead of the soc-max and soc-targets fields. Something like:

setting soc-maxima to a list of values equal to the normally preferred maximum value, for each time step, but excluding some time range around each soc-target (to make the problem feasible),
setting the soc-minima to a list of 100% values, for each soc-target datetime.

Originally posted by @Flix6x in https://github.com/FlexMeasures/flexmeasures/issues/680#issuecomment-1554345807
And from #679: The storage efficiency field could also use some more explanation. For example, a storage efficiency of 99 percent per (absolute) day, for scheduling a 1-hour resolution sensor, should be passed as a storage efficiency of 0.99**(1/24).

Good idea :smile:
I think we should have a major section for scheduling and different subpages for, not exclusively, explaining the following:

The general model, i.e., linear_optimization.py (constraints, cost function, variables...)
StorageScheduler, input parameters, how does it fill the constraints (i.e. maxima, minima, min, max, storage losses...)
Use cases, i.e how to use the input parameters to describe some real life situations (e.g. use minima to approximate to a target SOC, how to model availability of a EV, ...).

Just noting that this is a high-value issue in my mind.
Scheduling is the reason why FlexMeasures exists, so the explanations here mean a lot.
Examples help users. We have the API docs and the tutorial which both handle an example but the docs should be the place where someone can start. Maybe a little repitition wouldn't hurt, even. For instance, what's in the API documentation often isn't read by non-developers.

I see two PRs for this:

Main conceptual section for scheduling, types of schedulers, use cases
Latex model of the linear programming model in the storage scheduler and shifting scheduler


Updates for v0.14.0 release.

Codecov Report

Merging #579 into master will decrease coverage by -0.38%.

@@            Coverage Diff             @@
##           master     #579      +/-   ##
==========================================
- Coverage   10.98%   10.61%   -0.38%
==========================================
  Files         210      235      +25
  Lines       17513    18130     +617
==========================================
  Hits         1924     1924
- Misses      15589    16206     +617

Impacted Files
Coverage Δ

Source/RestKit/RestRequest.swift
50.58% <ø> (ø)
:white_check_mark:

...uageUnderstandingV1/Models/CategoriesOptions.swift
0% <ø> (ø)

...anguageUnderstandingV1/Models/RelationEntity.swift
0% <ø> (ø)

...nguageUnderstandingV1/Models/MetadataOptions.swift
0% <ø> (ø)

...ualRecognitionV3Tests/VisualRecognitionTests.swift
77.48% <ø> (ø)
:white_check_mark:

...turalLanguageUnderstandingV1/Models/Features.swift
0% <ø> (ø)

...anguageUnderstandingV1/Models/EntitiesResult.swift
0% <ø> (ø)

...nguageUnderstandingV1/Models/RelationsResult.swift
0% <ø> (ø)

...nguageUnderstandingV1/Models/ConceptsOptions.swift
0% <ø> (ø)

... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eae7616...a3e3841. Read the comment docs.


MainButton is not clickable on iOS

Platform
Select one of the following:

[ ] Telegram for Android
[x] Telegram for iOS
[ ] Telegram for macOS
[ ] Telegram Desktop
[ ] Telegram Web A
[ ] Telegram Web K

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Mount the button with @tma.js/sdk-react with the following code

const onSubmit = useCallback((values: zod.infer<typeof schema>) => {
  // ...
}, []);

useEffect(() => {
  mainButton.setText("Зберегти");
  mainButton.on("click", form.handleSubmit(onSubmit));

  return () => {
    mainButton.hide();
    mainButton.off("click", form.handleSubmit(onSubmit));
  };
  // eslint-disable-next-line react-hooks/exhaustive-deps
}, [onSubmit]);

Try to press the button and see nothing happened

Expected behavior
The button calls the callback passed to mainButton.on('click')

Have you called mainButton.enable()?

I was missing mainButton.enable(). Now it's working, thanks!. Strange that it was working in macOS without calling it


ECDC-2841 guaranteed logging

This PR makes most exceptions guaranteed to be logged. I think.

Codecov Report

Merging #155 (e38bea1) into main (c86c877) will decrease coverage by 0.20%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
- Coverage   87.32%   87.12%   -0.21%
==========================================
  Files          19       19
  Lines         655      660       +5
  Branches       91       91
==========================================
+ Hits          572      575       +3
- Misses         65       67       +2
  Partials       18       18

Impacted Files
Coverage Δ

forwarder/update_handlers/base_update_handler.py
75.30% <0.00%> (ø)

forwarder/update_handlers/ca_update_handler.py
68.42% <0.00%> (ø)

forwarder/update_handlers/pva_update_handler.py
75.00% <0.00%> (ø)

forwarder/repeat_timer.py
83.87% <66.66%> (-4.60%)
:arrow_down:


[1pt] PR: fix a bug to make model domain polygon

This PR fixes a small bug for making polygons for model domains that results in reporting all models to be not-conflated to NWM reaches. This PR closes #195.
Changes
Updated src/create_model_domain_polygons.py by removing an extra "is True" from a single line. Also, the file  tools/ras_unit_to_s3.py changed slightly after performing linting.
Testing
Successfully tested the changes on the 12090301 beta releases results.
Checklist
You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.

[x] Informative and human-readable title, using the format: [_pt] PR: <description>
[x] Pre-commit executed and linting changes made.
[x] Links are provided if this PR resolves an issue, or depends on another other PR
[ ] If submitting a PR to the dev branch (the default branch), you have a descriptive Feature Branch name using the format: dev-<description-of-change> (e.g.: dev-revise-levee-masking)
[ ] Changes are limited to a single goal (no scope creep)
[ ] The feature branch you're submitting as a PR is up to date (merged) with the latest dev branch
[ ] Changes adhere to PEP-8 Style Guidelines
[ ] Any change in functionality is tested
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged / future todos are captured in comments
[ ] Project documentation has been updated (CHANGELOG and/or README)
[ ] Reviewers requested

Merge Checklist (For Technical Lead use only)

[ ] Update CHANGELOG with latest version number and merge date

closed this because it should be merged into "dev_v2" and not "dev".


auto.offset.reset docs not in sync with validation

In this commit https://github.com/apache/kafka/commit/0699ff2ce60abb466cab5315977a224f1a70a4da#diff-5533ddc72176acd1c32f5abbe94aa672 among other things auto.offset.reset possible options were changed from smallest to earliest and from largest to latest, but not in documentation for that configuration property.
This patch fixes documentation for auto.offset.reset consumer configuration property so it is in sync with validation logic.

Build is unstable, tests failing, but not due to this PR.

+1

LGTM
@sslavic, not sure why but it seems like the flaky tests don't like your documentation updates. :) The tests have been passing for other PRs with actual code changes.

@ijuma thanks for reviewing my patches. Projects have different rules, what about Apache Kafka - is it a must to have a JIRA ticket for every commit? Am I supposed to create a JIRA ticket along with PR? Would it just speed up accepting of changes?

@sslavic The official documentation on contributing is here http://kafka.apache.org/contributing.html .
There is an ongoing vote in the mailing list to switch to GitHub pull requests for new contributions and that is described here https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes . It looks like the vote will pass and if that happens, then a JIRA ticket won't be required for trivial documentation changes such as this.
A separate question is how to speed up the process of integrating changes. Many of the current committers only monitor JIRA at this point since that's still the official way.

LGTM.


Duplicate coders when nesting create fixits

To reproduce:

In a method write self foo
Use the fixit to create the method
In the spawned coder write self bar use the create fixit again.

Similar to https://github.com/feenkcom/gtoolkit/issues/2732

Appears to be fixed as it is no longer reproducible.

Nice!


Updated the release notes for 2.0.0

Description
Added one of the last changes to Data Prepper.
Also added a list of breaking changes to help pipeline authors and administrators know what to do.
Issues Resolved
N/A
Check List

[ ] New functionality includes testing.
[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #1911 (e79b1cc) into main (29a4a97) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1911      +/-   ##
============================================
+ Coverage     93.89%   93.92%   +0.02%
+ Complexity     1551     1549       -2
============================================
  Files           198      198
  Lines          4589     4589
  Branches        372      372
============================================
+ Hits           4309     4310       +1
+ Misses          197      195       -2
- Partials         83       84       +1

Impacted Files
Coverage Δ

...opensearch/dataprepper/pipeline/ProcessWorker.java
88.46% <0.00%> (-1.93%)
:arrow_down:

...rwarder/discovery/AwsCloudMapPeerListProvider.java
95.12% <0.00%> (+2.43%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Tutorial: Build an ASP.NET app in Azure with SQL Database - has several out of date steps

Tutorial: Build an ASP.NET app in Azure with SQL Database -  it's a great Tutorial, hope it will be updated.
Environment: Windows 64 with Microsoft Visual Studio Enterprise 2019 Version 16.4.2
Issues with Steps and screenshots with my VS 2019 environment

Publish to Azure - after Pick a publish target

"Create App Service" is slightly different new name (App Service - create new)
has field for "Application Insights" config (important for later?)

Create an App Service Plan

the Publish UI image shows "Hosting Plan" in the UI, but refers to  App Service Plan in text.
"Configure App Service" image has changed and now says "Hosting Plan - create new"

Create a SQL Server instance

"Configure SQL Server" dialog changed -now reads "Azure SQL Database - Create new"

Update app

for this code in the sample, I got checkbox displayed- but could only check the box and save it during Create. Would not toggle check on index page. Otherwise could publish the update successfully.

Enable Code First Migrations in Azure

The Publish UI is different, there are "New  Edit  Rename  Delete" options under the entry for the  "Web Deploy" name.  Choosing "edit" accomplishes what "configure" did previously.

Enable Log Streaming

could not follow steps.  Right Click menu didn't display choices

Also..., Hi Cephas!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 72d855c6-51fd-a1da-5c44-8b44658c0211
Version Independent ID: 15c87b07-e89e-2b0c-6337-3940a5259101
Content: Tutorial: ASP.NET app with SQL Database - Azure App Service
Content Source: articles/app-service/app-service-web-tutorial-dotnet-sqldatabase.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin

Thanks for the feedback and bringing this to our notice . At this time we are reviewing the feedback and will update the document as appropriate .

Hi @eric-camplin,  upon further review we feel your feedback would be best received by the doc author to see if it is necessary to update the current doc or create a new doc if they align with your feedback. Thanks!

@Eric-camplin Hi Eric! Sorry for the delay. I updated the article a month ago but forgot to write back here. Thanks for your feedback. #please-close


Istio and Dev Spaces

I have a vanilla cluster with Istio installed, and when I install Dev Spaces, then all routing within the cluster stops working. It appears that Dev Spaces is conflicting with Istio. When I uninstall Dev Spaces from the cluster, then Istio routing works perfectly.
Is this a known issue?

Yes, it's a known issue that Istio and Dev Spaces do not currently play well together.  It would be helpful to know if you are using the routing capabilities of Dev Spaces in addition to Istio and what behavior you would expect in this case.

In our case, I would expect that we could leverage routing and security aspects of Istio in Dev spaces.  This would make for less changes between development and production.


Backport Pin controller-runtime to v0.1.4 #828 to v0.2.x

operator-sdk branch v0.2.x currently broken due to recent controller-runtime bump to v0.1.8. See #828. Backport @LiliC's master fix to v0.2.x.

@shawn-hurley @mhrivnak Any clue why the ansible based memcached-operator is giving the following error:
2018-12-10T05:19:52.612Z	ERROR	runner	runner/runner.go:250	error from ansible-runner	{"job": "8716441061609681071", "name": "example-memcached", "namespace": "default", "error": "exit status 1"}

I guess we've fixed some things on the master since, so it might be related to the fixes from #819
And since we added #812 later as well the logs above aren't too clear on why the runner failed.
@madorn Can you please cherrypick the commit from #812 so we can see why the ansible runner is failing to run.

@madorn you will probably need the dockerfile fixes? https://github.com/operator-framework/operator-sdk/pull/813

/hold
@madorn what errors are you seeing? all tests passed in CI and locally (for me).

@estroz Issue documented in #827 and fixed on master (#828).
operator-sdk's v0.2.x branch Gopkg.toml is not currently pinned to controller-runtime v0.1.4. It's automatically bumping to v0.1.8 causing incompatibility with apimachinery version kubernetes-1.11.2
cd $GOPATH/src/github.com/example-inc/
operator-sdk new app-operator
cd app-operator
operator-sdk add api --api-version=app.example.com/v1alpha1 --kind=AppService
operator-sdk add controller --api-version=app.example.com/v1alpha1 --kind=AppService
operator-sdk up local (or build)
[...]
# github.com/example-inc/app-operator/vendor/sigs.k8s.io/controller-runtime/pkg/client
vendor/sigs.k8s.io/controller-runtime/pkg/client/unstructured_client.go:49:24: undefined: v1.CreateOptions
vendor/sigs.k8s.io/controller-runtime/pkg/client/unstructured_client.go:67:24: undefined: v1.UpdateOptions
vendor/sigs.k8s.io/controller-runtime/pkg/client/unstructured_client.go:145:26: too many arguments in call to r.UpdateStatus
vendor/sigs.k8s.io/controller-runtime/pkg/client/unstructured_client.go:145:30: undefined: v1.UpdateOptions```

/unhold
Missed which branch this was being merged into. Thanks for clarifying.

/hold cancel

@madorn Thanks for the fix. We've cut a patch release for v0.2.1 that should have this fix.
https://github.com/operator-framework/operator-sdk/releases/tag/v0.2.1

I just tried this. Looks like still broken.
Gopkg.toml is created with
[[override]]
name = "sigs.k8s.io/controller-runtime"
version = "v0.1.4"

@h7kanna Are you sure you're using v0.2.1 (operator-sdk --version)? I just tried both building from the git tag and using the provided binaries and both output the correct Gopkg.toml files.


Short, consistent categories in Coda data

Some categories are very long and inconsistently styled:
research$status %>% unique()
 [1] NA
 [2] "01_Needs prioritization/assessor rating"
 [3] "deprioritized -- low ratings"
 [4] "02_final consideration needed"
 [5] "30_contacting/awaiting_authors_response_to_evaluation"
 [6] "de-prioritized bc. of journal-publication status, authors permission, etc."
 [7] "50_published evaluations (on PubPub, by Unjournal)"
 [8] "999_Other"
 [9] "Not a paper/project"
[10] "20_awaiting_evaluations"
[11] "authors rejected/blocked us"
[12] "10_seeking_(more)_evaluators"
[13] "21_need evaluator followup"
[14] "04_selected_choose_evaluation_manager"
[15] "03_awaiting authors' consent (where needed) or imminent update"

research$main_cause_cat %>% unique()
 [1] NA
 [2] "Development Economics"
 [3] "Economic development & governance (LMICs)"
 [4] "The Environment: Harm to human health, biodiversity, risks and climate change"
 [5] "Emerging technologies: social and economic impacts (focus: AI)"
 [6] "Health and well-being (global, including wealthy countries)"
 [7] "Empirical methods"
 [8] "Innovation, meta-science, and research"
 [9] "Catastrophic and existential risks,  the long-term future, forecasting"
[10] "Other: Economics/welfare, growth, policy, global markets and population"
[11] "Markets for products with large externalities (focus: animal agriculture)"
[12] "Attitudes and behaviors (Altruism, moral circles, animal consumption, effectiveness, political attitudes, etc.) [Psychology/behavioral economics adjacent group]"
[13] "Global health; “Health & well-being in low-income countries”"
[14] "Other: Theory and philosophy, artificial intelligence, natural science, etc."
[15] "Communicable diseases, bio-security and pandemic preparedness, biological risks"
[16] "Beliefs and misinformation"
[17] "International cooperation and conflict, behavior of large governments; authoritarianism"

They should preferably be shorter and consistently styled.

Dupe


add .current to useEffect dependencies of React DOM doc

Without it the hook is never called again even if the refs update.

That example seems off to me, when refs values are changed React doesn't trigger a re-render, so that effect won't be called anyways 🤔

Usually you have an open dependency that will cause it to run at the correct time:
useEffect(() => {
  if (open) {
    return autoUpdate(...);
  }
}, [open, refs.reference, refs.floating, update]);

return open &&
floating

But you are right that if reference changes (or some other case) the effect fails to run. Specifying .current as a dependency is weird though (and is documented for the external reference, but I think that pattern is bad anyway)

refs should not be included in the dependencies list, but the eslint rule is not very smart and doesn't understand if a ref is being forwarded from some other hook.

@FezVrasta yeah it's just because of the rule not because it's necessary, in fact it causes additional confusion and would be more obvious without them there :\

@maloguertin I opened a PR for a new callback which would solve this better and makes it simpler: https://github.com/floating-ui/floating-ui/pull/1683
Let me know what you think.

@maloguertin I opened a PR for a new callback which would solve this better and makes it simpler: #1683
Let me know what you think.

Perfect :100:

This will be released soon (whileElementsMounted prop)


Consider integrating with OpenTelemetry

https://opentracing.io/docs/best-practices/instrumenting-frameworks/

InfoQ Podcast on OpenTracing
Google Research paper on Dapper

OpenTracing was archived.
OpenTelemetry is a new thing.


Fix FixedProcessFlow - stopping sometimes throws an exception

From time to time FixedProcessFlowSpec fails:
[info] FixedProcessFlowSpec
[info] ====================
[info]   + complete runs synchronously and calls onComplete
[info]   + start runs asynchronously and calls onComplete
[info]   + exception causes onThrowable than onComplete
[info]   x stop causes onStopped than onComplete
[error]  List(OnStopping, OnThrowable, OnCompleted)
[error]   is not equal to
[error]  List(OnStarting, OnStopping, OnCompleted); List(OnStopping, OnThrowable, OnCompleted)
[error]   is not equal to
[error]  List(OnStopping, OnStarting, OnCompleted); List(OnStopping, OnThrowable, OnCompleted) is not equal to List(OnStopping, OnCompleted); List(OnStopping, OnThrowable, OnCompleted) is not equal to List(OnCompleted, OnStopping) (FixedProcessFlowSpec.scala:82)
[error] Expected: ...(OnSt[art]in...On[St]o[pping], OnC...
[error] Actual:   ...(OnSt[opp]in...On[Thr]o[wable], OnC...
It seems like a race condtion.
I lost printed stacktrace (if there was any), sorry:-) I'll post it when I get it again.

No longrt using FixedProcessFlow.


[5.x]  Electron app not found in GNOME applications menu after successful make

OS: Ubuntu 18
electron: 3.0.10
electron-forge: 5.2.3
electron-prebuilt-compile: 3.0.13
I ran the electron-forge make command.
All the operations were completed successfully and the output folder was generated with a .deb file and some other files.
I ran the .deb file and the application got installed successfully but I'm not able to find the application installed anywhere in my system. It's not there in the Applications menu.
However, under the 'installed' section in Ubuntu Software Center, the app is listed under the 'Add-ons' subsection. (frappe-accounting is the name of my app)

package.json

{
  "name": "frappe-accounting",
  "description": "Simple Accounting app for everyone",
  "productName": "Frappe-Accounting",
  "version": "0.0.2",
  "author": {
    "name": "Frappe Technologies Pvt. Ltd.",
    "email"<EMAIL_ADDRESS>  },
  "config": {
    "forge": {
      "make_targets": {
        "linux": [
          "deb"
        ]
      },
      "electronPackagerConfig": {},
      "electronWinstallerConfig": {
        "name": ""
      },
      "electronInstallerDebian": {},
      "electronInstallerRedhat": {},
      "github_repository": {
        "owner": "",
        "name": ""
      },
      "windowsStoreConfig": {
        "packageName": ""
      }
    }
  },
  "main": "dist/electron/main.js",
  "license": "MIT",
  "scripts": {
    "test": "mocha tests",
    "start": "frappe start",
    "electron": "cross-env ELECTRON=true frappe start electron",
    "postinstall": "electron-builder install-app-deps",
    "dist": "electron-builder"
  },
  "dependencies": {
    "frappejs": "github:frappe/frappejs",
    "popper.js": "^1.14.4",
    "vue-color": "^2.7.0",
    "vue-toasted": "^1.1.25"
  },
  "devDependencies": {
    "electron-prebuilt-compile": "3.0.13"
  }
}

Any help is appreciated. Thank you.

What is the output of dpkg -L frappe-accounting | grep applications?
Does it show up if you restart your X session?

Good, at least the desktop file is there.
When you run sudo dpkg -i /path/to/frappe-accounting_0.0.2_amd64.deb, does something like the following get printed out (probably not the same version numbers, as I run Debian Stretch):
Processing triggers for mime-support (3.60) ...
Processing triggers for desktop-file-utils (0.23-1) ...
Setting up frappe-accounting (0.0.2) ...
Processing triggers for gnome-menus (3.13.3-9) ...

I ran sudo dpkg -i /path/to/frappe-accounting_0.0.2_amd64.deb
The following is the output:
Selecting previously unselected package frappe-accounting.
(Reading database ... 190262 files and directories currently installed.)
Preparing to unpack frappe-accounting_0.0.2_amd64.deb ...
Unpacking frappe-accounting (0.0.2-1) ...
Setting up frappe-accounting (0.0.2-1) ...
Processing triggers for desktop-file-utils (0.23-1ubuntu<IP_ADDRESS>) ...
Processing triggers for gnome-menus (3.13.3-11ubuntu1.1) ...
Processing triggers for mime-support (3.60ubuntu1) ...

Having the same issue here.


Add an --after flag

Shreddit kept hitting API errors after running for a while against my
GPDR export. I wanted to be able to have Shreddit pick up from where it
left off, and the easiest way to do that was with an --after flag.

Thanks for the contribution! I think --after would more intuitively mean that posts after the given date should be shredded (and vice versa with --before). Could you update the logic for these please?

Sorry! Just got this. Happy to.


Add vulkan renderer to Craft

Abstract the rendering interface of Craft and add an OpenGL and then a Vulkan implementation. This also converts the shaders to spir-v that is used for both. The Vulkan port required a later version of GL and thus a later version of glfw and glew, which was acquired by adding a system dependency on them.

First a disclaimer. I did this project for my own benefit to better familiarize myself with Vulkan and porting to it. That said, I would be perfectly content for it to be accepted into the main branch, but I am not as insistent as the volume of the changes might suggest. If any part of this is appealing, please feel free to take what you want and leave the rest. I'd be happy to continue collaborating as well.
Uploaded at @chaoticbob's suggestion.


Viewing in latest Ubuntu Firefox GTK3 controls messed with layout.

Firefox 46 was released for Ubuntu today. This new build uses GTK3 controls when rendering. These controls are not the same size as the old ones. This causes issues in layout in Groovebasin.

Hm. I'm not able to reproduce your problem. Here's what it looks like for me in Firefox 46:

I confirmed that the debian package for firefox I'm using depends on libgtk-3-0 (and libgtk2.0-0? not sure what that's about).
Could it be there there are some system-level user preferences that you could customize to change the font/size/behavior of the Groovebasin UI? What window manager are you using? And is there a theme that you've chosen? Those might be good places to look for such customization.
If you can help us reproduce this problem, we can look into tightening up the UI code to prevent that wrapping problem from happening.

It might be based on the GTK theme. I'm just using the default theme(Ambiance) for Unity/Ubuntu 14.04 in this case.

@eyecreate are you familiar enough with browser dev tools that you could fiddle with the width of the dropdown in the css until it is no longer wrapping? if you figure out a value that makes it work tell me and I'll update the css accordingly.

Changing these two values seemed to make things fit better.
#library-pane .window-header {
height: 35px;
}
#organize {
width: 185px;
}


[Backport 2.x] Query instrumentation Minor Enhancements

backport #73 to 2.x
Description
Describe what this change achieves.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Need @dzane17 changes to be backported first for this to succeed.


Avoid the convert_hf_checkpoint step

https://github.com/Lightning-AI/lit-parrot/blob/main/scripts/convert_hf_checkpoint.py is a script that converts a list of *.bin files into a single checkpoint file: lit_model.pth.
This has the disadvantage of:

adds 1 extra step to get started
the checkpoint weights are now duplicated in the filesystem
it takes time and memory to convert.

This is particularly interesting for inference. For training/fine-tuning, the checkpoints generated will still be single file. We would need to support loading both options.
Instead, we could write a function lazy_load_from(checkpoint_dir) that does the weight mapping on the fly.

This would get complicated when loading checkpoints with split weights that need to be consolidated, such as the llama qkv weights. Closing in the spirit of simplicity.


Add Mithril

By making a PR you are agreeing to that contributing a hello world project allows the repo/project owner to use the hello world app in examples for their own use.

[ ] only the most simple basic hello world app
[ ] must say "Hello World" on the main component
[ ] only include the minimal components (1 ideally)
[ ] no routing, not extras whatsoever
[ ] no styling
[ ] nothing else !
[ ] must work by running npm install and npm start (or equivalent)
[ ] must be in the folder named <tech-name>
[ ] add yourself using the all-contributors bot @allcontributors please add @<your-github-account> for code
[ ] add build steps and which folder to serve in the README.md, Serve the public folder

thanks so much!
please resolve readme conflicts

I'm on it, thanks!

@all-contributors please add @wolfhoundjesse for  code

no worries - I could have been clearer :)
had a lot to review, so I was kinda short.
thanks for the PR


Fix upstream build

Thank you for opening a pull request and contributing to AsciidoctorJ!
Please take a bit of time giving some details about your pull request:
Kind of change

[ ] Bug fix
[ ] New non-breaking feature
[ ] New breaking feature
[ ] Documentation update
[x] Build improvement

Description
What is the goal of this pull request?
This PR fixes the upstream build which does not succeed anymore since the upstream version of highlights has changed.
How does it achieve that?
It's an intermediate step of updating the version number used by the test highlighter.
Are there any alternative ways to implement this?
Yes, as suggested in (#953) the version number should not be checked for exact equality.
Unfortunately I don't have the time right now, but still want to unblock the upstream built.
Are there any implications of this pull request? Anything a user must know?
Issue
If this PR fixes an open issue, please add a line of the form:
Fixes #Issue
Release notes
Please add a corresponding entry to the file CHANGELOG.adoc

Unfortunately I don't have the time right now, but still want to unblock the upstream built.

I have time now, but I don't fully understand the problem. Is just that normal tests work, but upstream fails because a change in asciidoctor main/dev branch?

Yes, exactly.
Right now the test uses 2 syntax highlighters implemented in Groovy and checks that either of the results when using it matches exactly what is produced by Asciidoctor Ruby.
Now this breaks when Asciidoctor upgrades the version of highlightjs as the version number gets into the resulting HTML.
One of the 2 highlighters should match the current version of Asciidoctor Ruby, the other should match the current upstream.
(Besides the version number there sometimes are other changes, for example where the script tag is placed)
The goal would be to make the check more flexible so that the test does not break when Asciidoctor Ruby upgrades the version Highlightjs.


Errors when trying the IDE

Hi,
First of all, the Reactide project looks great and I am very interested in trying it out and maybe contribute.
I am having problems in the console and it seems a lot of components are not loaded. I checkouted the project (e416738b) then I did :
$ yarn install

It seems the yarn.lock is not up-to-date since after this command, I have got 693 additions and 82 deletions according to git on the yarn.lock file.
After I tried :
$ yarn run dev-start
$ yarn run dev (in another tab)

The editor launches with the console opened and I have got this in the console :

I must have made a mistake somewhere ?
Screenshot of the window :

I have PRs for some errors. Vote for them - https://github.com/reactide/reactide/pulls.


Add django 2.0 to Travis

Description:
Fixes #
Checklist

[ ] Tested OK on Travis
[ ] Written tests and documentation
[ ] Added an entry to 'Unreleased' in HISTORY.rst

Superseded by #23


Add STM's FF Ribbon Pack - Enlisted Ranks from Kerbal Stuff

This pull request was automatically generated by Kerbal Stuff on behalf of SmarterThanMe, to add STM's FF Ribbon Pack - Enlisted Ranks to CKAN.
Please direct questions about this pull request to SmarterThanMe.

Closing in favour of #2927.


Upgrade esp-hal v0.15.0

This allows us to drop the nightly toolchain. I deleted the toolchain.toml file.
One peculiar thing I had to do was lower the heap size to avoid some allocation failures. It would be really good to understand why this was necessary before merging.
Main benefit of this is that it seems to fix the problem of panic messages not being displayed in the panic handler. Note i'm not sure if that's to do with lowering the heap size or just the dependency upgrade.

I just pushed a commit to clean up display errors in st7735.rs. We need error_print to be infallible so we don't panic inside the panic handler.

@musdom do you have any idea why the heap size change was necessary?

Not sure. I tried flashing this 0.15 template https://github.com/esp-rs/esp-template and was able to give it 300kB no problem.

Nice so many unwraps removed :broom:
Rebased and upgraded hal to 0.16.0 which notably makes esp32c3 a feature rather than its own package.
Tested and reviewed.

I could not figure out the cause of the memory allocation error.
I looked through the hal changelogs but nothing really stood out, couldnt quite understand https://github.com/esp-rs/esp-hal/pull/1289.
Tried finding which line the error was occurring on using panics.
When using a 300kb heap size on a device that already has a key, the panic seems to be happening in this line match flash.read_header(), but I don't think there's anything of interest happening in here? Memory probably being exhausted elsewhere, i can keep looking

I'm pretty sure @musdom already discovered that it was changes to the display driver.

Confirmed it seems to be SPI/display related. When using a 166+ byte heap, I am unable to allocate anything after intializing the display.
Haven't managed to figure out much more..
There are some things in the changelog which look interesting,
https://github.com/esp-rs/esp-hal/blob/main/esp-hal/CHANGELOG.md
enabling place-spi-driver-in-ram seemed to have no effect.
I began to try the unreleased esp-hal, but didn't quite manage to build for our device, not sure if this avenue is worth exploring.


update channel for amq-streams to 1.8.x

the 1.7.x channel of amq-streams has been dropped, we need to upgrade the channel to 1.8.x, otherwise the amq-streams will never be installed successfully.

/assign @vadimeisenbergibm


test: Fix act errors in DndColumnSelectControl tests

SUMMARY

Cleans up a few act errors in

superset-frontend/src/explore/components/controls/DndColumnSelectControl/OptionWrapper.test.tsx
superset-frontend/src/explore/components/controls/DndColumnSelectControl/Option.test.tsx

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A
TESTING INSTRUCTIONS

cd into /superset-frontend
npm run test -- src/explore/components/controls/DndColumnSelectControl/Option.test.tsx
npm run test -- src/explore/components/controls/DndColumnSelectControl/OptionWrapper.test.tsx
Check for act errors

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Welcome back @corbinrobb!!!


Gaussian process with neural network notebook

Update to the gp-nn.ipynb notebook. Convert it to gpflow 2.0.

@vdutor , run it longer, got 97.2233


Impossible to add Force in Roster

I tried to create a Warhammer 40k 10th edition roster and I did not succeed to add a force. Nothing happens when I clicked on the Create Button

I'm seeing this too. Tried on mobile (Android) and desktop (macOS Firefox). On Firefox I'm seeing this error in the console:

Error: Couldn't find rule 86aa-437f-260b-5cad of Synapse (52e5-4e0d-4d0e-572c) in Xenos - Tyranids!


There are some ways to encrypt sqlite db?

This library is good. But I have some questions, please help me.

Is there some way to encrypt sqlite db? That is very important!
If I'm query and update use SELECT so frequently (maybe 1-4 times/sec, maybe 1-4 times/min), should I increase the stack or memory size? What should I do.

In other platforms I would encrypt the entire database and decrypt it on first opening. But in the this lib the sqlite db will write to the indexDB and split into many sub, so what should I do.

Encryption of an SQLite db is a project in and of itself, with several implementations available. See this forum post for a recent discussion which mentions the available options.

1-4 times/second is, in the general case, not terribly frequent for SQLite. As a rule of thumb, you don't need to change anything unless/until you determine, through observation and measurement, that doing so actually helps. Increasing the stack memory size won't help queries because they use dynamic memory, not stack memory. Depending on how the .wasm file is built, it may have a fixed or growable dynamic memory size. If it's fixed, you may need to increase it for large queries, but the query frequency, by itself, plays no significant role in memory usage. RAM usage is next to impossible to calculate accurately in advance, but if your app fails with allocation errors from wasm, growing the memory will be required.

In this project, Issues are only for possible bugs in project code.


Attempt to fix unicode error when using python3.x to make test happy

This PR add the following changes:
Code changes

Essay to take a stab at fixing the following unicode error raised below when running codemod master branch on python3.x according pyporting guide :

(codemod-3.6) % codemod -m -d . --editor vim --extensions="py" -i '(extensions)' 'sbz test replace \1'
Resume where you left off, at ./build/lib/codemod/helpers.py:47 (y/n)?  y
Searching for first instance...
Traceback (most recent call last):
  File "/private/tmp/test/bin/codemod", line 11, in <module>
    load_entry_point('codemod==1.0.0', 'console_scripts', 'codemod')()
  File "/private/tmp/test/lib/python3.6/site-packages/codemod-1.0.0-py3.6.egg/codemod/base.py", line 493, in main
    run_interactive(**options)
  File "/private/tmp/test/lib/python3.6/site-packages/codemod-1.0.0-py3.6.egg/codemod/base.py", line 79, in run_interactive
    _ask_about_patch(patch, editor, default_no)
  File "/private/tmp/test/lib/python3.6/site-packages/codemod-1.0.0-py3.6.egg/codemod/base.py", line 252, in _ask_about_patch
    terminal.terminal_clear()
  File "/private/tmp/test/lib/python3.6/site-packages/codemod-1.0.0-py3.6.egg/codemod/terminal_helper.py", line 55, in terminal_clear
    if not _terminal_use_capability('clear'):
  File "/private/tmp/test/lib/python3.6/site-packages/codemod-1.0.0-py3.6.egg/codemod/terminal_helper.py", line 75, in _terminal_use_capability
    sys.stdout.write(unicode(capability, 'ascii'))
NameError: name 'unicode' is not defined

Make happy test suite in python3.x because of doctest print statement issue
Add python3.x stable version in the travis ci-configuration

Tests verification should be ok after that change

python2.x:

(codemod-2.7) % make test
py.test --doctest-modules codemod
========================== test session starts  =============
platform darwin -- Python 2.7.14, pytest-3.8.2, py-1.6.0, pluggy-0.7.1
rootdir: /Users/sbrabez/github/codemod, inifile: pytest.ini
collected 18 items

codemod/base.py .                                                                                [  5%]
codemod/helpers.py ...                                                                                [ 22%]
codemod/patch.py .                                                                                [ 27%]
codemod/position.py .                                                                                [ 33%]
codemod/query.py ...                                                                                [ 50%]
codemod/base.py .                                                                                [ 50%]
codemod/helpers.py ...                                                                                [ 50%]
codemod/patch.py .                                                                                [ 50%]
codemod/position.py .                                                                                [ 50%]
codemod/query.py ...

18 passed in 0.12 seconds

python3.x

(codemod-3.6) % make test
py.test --doctest-modules codemod
========================== test session starts  =============
platform darwin -- Python 3.6.5, pytest-3.8.2, py-1.6.0, pluggy-0.7.1
rootdir: /Users/sbrabez/github/codemod, inifile: pytest.ini
collected 18 items

codemod/base.py .                                                                                [  5%]
codemod/helpers.py ...                                                                                [ 22%]
codemod/patch.py .                                                                                [ 27%]
codemod/position.py .                                                                                [ 33%]
codemod/query.py ...                                                                                [ 50%]
codemod/base.py .                                                                                [ 50%]
codemod/helpers.py ...                                                                                [ 50%]
codemod/patch.py .                                                                                [ 50%]
codemod/position.py .                                                                                [ 50%]
codemod/query.py ...

18 passed in 0.13 seconds

Thank you for this awesome project to help refactoring huge code base!
I hack on this change for Hacktoberfest, please let me know your feedback.

Great, thank you!

@modocache Thank you for merging! It looks like the travis ci integration was disabled for facebook/codemod, so I run a build against my fork sbz/codemod rebased on master. Everything is fine as expected according the build logs \o/


Question about accessing endpoint from external network

I have generated simple server code from a swagger file and successfully added a handler and testing locally with curl works fine.
I have just deployed this to OpenShift and whilst it works fine on the actual container using curl from the terminal to http://<IP_ADDRESS>:8080 I can't access it remotely using the route created. Before I dive into OpenShift/Kubernetes route debugging I wondered if there was anything I needed to do to my go-swagger generation flags /config process to allow external IP address access?

OP solved issue