Discontinuation of multi module configuration modes

Proposal
I am considering removing both "navgraphs" and "destinations" modes from the library. For anyone who doesn't know what these are, read about them here:
https://composedestinations.rafaelcosta.xyz/codegenconfigs#multi-module-configs
This issue is here so I can present my decision beforehand to the community and give users of the feature a chance to tell me why I shouldn't do this.
I also totally appreciate it if you let me know in the comments if you agree with my reasonings.
Reasonings
These modes were introduced as a tentative to help multi-module applications define their screens directly inside each feature module. The issue with it is that they ultimately require a lot of manual code to be written and developers lose a lot of the benefits of using Compose Destinations. Also, I don't think the end result is better than just having a navigation module (same that would call DestinationsNavHost even with these configs) that defines all the destinations and navigation graphs and just calls normal Composables (i.e, not annotated with @Destination) of the feature modules.
I would say that the amount of code you have to write is actually less and Compose Destinations can help you a lot more since it can infer the structure around the destinations and their navigation graphs.
It also puts a lot of strain on the future development of Compose Destinations (which I already have been feeling) because these configurations change the flow of generating the classes in the very core and it's very difficult to always keep in mind with all changes I do how it may affect these modes.

Note: I will keep the "generateNavGraphs" config still. This can somewhat be used for achieving the same goal as these modes. You can disable navigation graph to be generated on all feature modules and then gather all of them in the central nav module and call DestinationsNavHost.
I don't really recommend this approach though, "generateNavGraphs" is here more for people who don't want to use DestinationsNavHost and they just want the type safety of the library and call the normal NavHosts.

Pros of removing them

Easier development of the library going further
Arguably better end result for all code bases that migrate to the one navigation module approach (this is also what Jetpack Compose Navigation advocates for which we ultimately are very dependent on and have very similar setup to it)
Compose Destinations can do more for the developers if all the generation happens in a single module and it doesn't really become a "monolith", the actual UI can still be composed in different modules. In regards of coupling, it's actually better because navigation is not tied to all your feature modules

Cons of removing them

Migration for active users of the feature. By now, I hope you guys know that I am super helpful to anyone who asks me for help and I will be willing to help everyone with the transition. I am also planning to do this migration myself on the two repositories I provided as examples of this feature (https://github.com/raamcosta/tivi and https://github.com/raamcosta/CalorieTracker). This way, they will be examples of this migration.
I want to avoid as much as possible to have breaking changes, but I also still for now want the freedom to do them if I really feel it will be better in the long run. Please stay with me through these discovery times 🙏 😅
Honestly, I can't see any other benefit of keeping them. But please let me know in the comments if you use this feature and you like it and why.

Some code examples
Before:

 👉 Click me
// 👉 feature module "A"

// 👇 here to allow this module to navigate to where it needs to without knowing the other modules
interface ModuleANavigator {

    fun navigateUp()

    fun navigateToScreenX()

    //....
}

@Destination
@Composable
fun MyScreenA(
    moduleANavigator: ModuleANavigator
) {
    //...
}

// 👉 navigation module

object RootNavGraph: NavGraphSpec {

    val destinations = listOf(
        MyScreenADestination,
        //.... other destinations from other modules
    )

    val startDestination = MyScreenADestination

    // ...
}

// ...

DestinationsNavHost(
    navGraph = RootNavGraph,
    dependencyContainerBuilder = {
        dependency(instanceOfModuleANavigator) // 👈 we could have a single navigator that would implement all interfaces of the different modules, but still a lot of manual work
    }
)

After:

 👉 Click me
// 👉 feature module A

@Composable
fun MyScreenAContent(
    navigateUp: () -> Unit,
    navigateToScreenX: () -> Unit
) {
    // ...
}

// 👉 navigation module

// RootGraphDestinations.kt // 👈 since we have very small Destinations code, it's totally fine to group them by nav graph in a single // file for example

@Destination
@Composable
fun MyScreenA(
    navigator: DestinationsNavigator
) {
    MyScreenAContent(
        navigateUp = { navigator.navigateUp() },
        navigateToScreenX = { navigator.navigate(ScreenXDestination) }
    )
}

// ...

DestinationsNavHost(
   navGraph = NavGraphs.root
)

Warning: just example code, I actually wrote all of that directly in Github, I may be missing some details, but I think they probably aren't important enough in this discussion. But if you see a detail missing that might be relevant, let me know in the comments 🙂

Although this change looks fine, I actually don't feel like performing this kind of large-scale refactoring in my project, first of all.
I really like the way destinations are defined in the feature module as they are right now.
The issue with the code above is that I actually already do this kind of thing in my own repository, i.e:
My composables are defined in the feature module, annotated as @Destination and look like this:
@Composable
@Destination
internal fun OverviewScreen(
    ritualId: Long, // <- nav param
    navigator: AppNavigator, // <- huge interface defined in the navigation module that has functions to navigate to each screen in the app (will be split by nav graph in the future)
) = MVIComposable(getViewModel<OverviewViewModel>()) { state ->

    // some MVI event handling

    OverviewScreenContent(state)
}

The problem with migrating the block of code above is, there are 8 (!) navigation events in the screen above. I'd need to add lambdas to navigate to all of those. This essentially means "defining" a "function" each time I'd like to navigate to the same destination. Basically like the approach with yours "before" example, but on a large scale. 9+ parameters of a function seems a bit over the top for me. (also what about the stability (@Stable) of the destination and performance impacts?
I also use some utility stuff that does not really apply to the usecase above, like using AppNavigator to determine the canGoBack property in a specific screen. Again, using your approach would mean defining this property in every single composable.
So all that stuff above means that the refactoring for my app would be quite... Extensive. From adding another layer to my composable screen layout (OverviewScreenContentContent xD (I know, I'll use proper naming)) to shuffling a bunch of stuff around.
What I suggest is deprecating these values for a reasonable time. I might not get around to that kind of refactoring in a couple of months, and there may be people with larger projects out there.

Hi @Nek-12 ! 👋
Thank you so much for taking the time to write your feedback, it is really really appreciated!
Let me counter-argument some of your points, but don't take this like "ok he is set on doing this, no need to counter argument again" - I want you to tell me why I am wrong in these 🙂

The problem with migrating the block of code above is, there are 8 (!) navigation events in the screen above. I'd need to add lambdas to navigate to all of those. This essentially means "defining" a "function" each time I'd like to navigate to the same destination. Basically like the approach with yours "before" example, but on a large scale. 9+ parameters of a function seems a bit over the top for me. (also what about the stability (@Stable) of the destination and performance impacts?

If you like the interface approach vs the lambdas, you can still use that. The only difference is where the @Destination is used. Your feature module can ask for whatever type that you can provide (like f.e an interface to navigate) and when you call the feature module's Composable, you just pass that along.
Sorry for misleading you with my examples, I'll add a note explaining this in the proposal.

So all that stuff above means that the refactoring for my app would be quite... Extensive. From adding another layer to my composable screen layout (OverviewScreenContentContent xD (I know, I'll use proper naming)) to shuffling a bunch of stuff around.

The idea is that you still only need 2 Composables, the Destination and the Content one. So you'd just move your Screen example to the navigation module. I feel like this further separates from Android specific code, to a "Content Composable" that just receives state and lambdas (or interfaces) for actions. Having that separation in the same place as the module separation has a lot of benefits, for example maybe in your case your feature modules won't need to depend all on the MVI framework you're using.
I do recognize how for some this won't be possible right away as this would be the actual migration effort (maybe it's your case), but at that point yes, you would have 1 Destination, 1 Setup Composable inside the feature module and the actual Content Composable (also in feature module ofc).
I believe you can make this migration with minimal changes (if you don't do the MVI migration as well. Like I outlined above in bold, that would probably be way harder).

What I suggest is deprecating these values for a reasonable time. I might not get around to that kind of refactoring in a couple of months, and there may be people with larger projects out there.

Again, I'll add a note to the proposals about this. The idea is that these will be a part of a new major version that would co-exist with 1.x for some time. So technically, no one is forced to move to v2 right away. New features will only exist in v2, but I plan to still make new releases in v1 for stuff like new versions of navigation or Compose.

I can't use the screen example to the navigation module because it has a bunch of logic inside for handling MVI Actions. Feature modules can't not depend on the framework since it permeates the viewmodel layer too. But the navigation module can not depend on it, I do agree here. If I add another wrapper though.
Am I right in my assumption that you can't deprecate these modes without removing them because some internal improvements you mentioned are not possible with this functionality present?

Am I right in my assumption that you can't deprecate these modes without removing them because some internal improvements you mentioned are not possible with this functionality present?

The issue with actual deprecation is that since these are configs in gradle, the IDE won't help developers understand that they are deprecated.
Also compared to just releasing a new major version and giving people time to migrate, I don't think is worse for anyone. It's basically the same thing I believe 😄

I'm also confused about the naming. Do you have a proper name for the destination composable (*Screen in my example) if the "Screen" name is already taken?

Hmm.. I guess you can call *Screen in the nav module, *Setup and *Content for example. I don't know naming is hard ahah. Basically something that conveys 1st is NavigationDestination, 2nd is the Screen Setup, and 3rd is the actual screen Content.

Also compared to just releasing a new major version and giving people time to migrate, I don't think is worse for anyone. It's basically the same thing I believe 😄

if you believe you won't be releasing any bug fixes or other improvements until most people migrate, then that would be possible. Regarding gradle, we could just print a message to the build log.
I guess we can call what we call *ScreenContent a "*ScreenLayout" instead

Arguably better end result for all code bases that migrate to the one navigation module approach (this is also what Jetpack Compose Navigation advocates for which we ultimately are very dependent on and have very similar setup to it)

This is absolutely not what Navigation Compose advocates for. In fact, it is the exact opposite, where each module is encouraged to define its own nested navigation graph:

It is strongly recommended that you split your navigation graph into multiple methods as the graph grows in size. This also allows multiple modules to contribute their own navigation graphs.

While it is true that at some point you combine the graphs from various modules together into a single combined graph (generally at the construction time of the NavHost), a key part of scaling your application into multiple modules is to have each module control its own set of destinations, providing the right level of encapsulation to not expose internal implementation details (i.e., no module outside of the login module should have to know how many screens are involved in user registration).

Arguably better end result for all code bases that migrate to the one navigation module approach (this is also what Jetpack Compose Navigation advocates for which we ultimately are very dependent on and have very similar setup to it)

No, each module should expose its own <navigation which is then all <includeed together in the :app root parent, allowing a hierarchy of destinations in a graph.
I didn't read everything, might do later.

Interesting I may have been too influenced by Chris Bane's tivi project I guess 😅
But now that I think of it, nowinandroid uses the approach you guys are saying.
I will rethink this then, maybe the answer is to keep only the "navgraphs" mode and delete the other, or maybe actually keep both. Or maybe a 3rd option would be to improve them even more somehow, as one of the reasons I have is also how they're a bit of work to whoever uses them atm.
Thanks @ianhanniballake and @Zhuinden! Glad I had your opinions 🙏

The encapsulation the "navgraphs" mode provides is nice and important but cross-module navigation is pretty hard. It would be nice if we could flag a @Destination as public and have such destinations then be aggregated within a specific module that all feature modules depend on. Is this even possible? 😄

One benefit I'm thinking of while using the approach described by @raamcosta is that KSP will only be needed in a single navigation module, and we can remove both the dependency and ksp task from all the feature branches, thus reducing build time.
Not sure about this though, because now a ksp-heavy task will be compiled on a single thread before all the feature modules will be able to compile. Although, the navigation module is still included in most feature branches, it's just that it will be a little more heavy on time to compile.


how to send text messages

Hello, im trying to send a text message and it throws me this exception: WhatsappBusiness.CloudApi.Exceptions.WhatsappBusinessCloudAPIException: 'Unsupported post request. Object with ID 'messages' does not exist, cannot be loaded due to missing permissions, or does not support this operation.
i saw that builder.Configuration.GetSection("WhatsAppBusinessCloudApiConfiguration") is not working.
i would appreciate if you can provide an example connecting whatsapp business  configurations such as phonenumberid with the project

@AlejandroT02
You need to perform the following steps:

You need to create your app from Meta for developers
You need to add WhatsApp business product to the app you created in the portal
You will get the test WhatsApp phone Number Id and WhatsApp Business Account Id assigned to your app from meta.

If you are using asp.net core 6.
You will need to add the following key and value the appsetting.json file. This will solve this issue builder.Configuration.GetSection("WhatsAppBusinessCloudApiConfiguration") it is reading the configuration from appsetting.json file
{
  "WhatsAppBusinessCloudApiConfiguration": {
    "WhatsAppBusinessPhoneNumberId": "<YOUR PHONE NUMBER ID FROM META>",
    "WhatsAppBusinessAccountId": "<YOUR BUSINESS ACCOUNT ID FROM META>",
    "WhatsAppBusinessId": "",
    "AccessToken": "<YOUR TEMPORARY OR PERMANENT ACCESS TOKEN FROM META>"
  }
}

Let me know if that solved your issue

Thank you, but it is giving me another problem, I am entering the data correctly and it does not send me the whatsapp or give me any exception

@AlejandroT02 If you have received a test hello world message from meta when sending it to test your phone number. You are required to reply with any text since it's a template message.
After you reply to the Facebook hello world template message with any text to it. You can now send any type of message to your test phone number since it is like a form verification on their end. That will solve your issue of not receiving WhatsApp messages from cloud api.

Thanks!!!! didn't know i had to reply, you helped me a lot.


Error being thrown from rescue block.

undefined method `associated_key' for #<JSONAPI::FindOperation:0x007f70b89cd9b8>
"/usr/local/bundle/bundler/gems/jsonapi-resources-6f0267121284/lib/jsonapi/active_record_operations_processor.rb:29:in `rescue in block in process_operation'"
I've hit this quite a few times and it's pretty rough to debug with the real stacktrace being thown away, especially with a prod-spefic error

Looks like this is an issue whenever there is an AR RecordNotFound that is not the primary resource being queried. I'm getting when trying to implement a filter


build: Update SPIRV-Tools and glslang to latest

CI Vulkan-ExtensionLayer build queued with queue ID 171558.

CI Vulkan-ExtensionLayer build # 904 running.


Unserialising empty ImmutableRoaringBitmaps results in a RuntimeException

After adapting the example code for loading a ImmutableRoaringBitmap from a ByteBuffer to load two consecutive empty bitmaps results in the following exception:
Exception in thread "main" java.lang.RuntimeException: I failed to find one of the right cookies. 0
	at org.roaringbitmap.buffer.ImmutableRoaringArray.<init>(ImmutableRoaringArray.java:102)
	at org.roaringbitmap.buffer.ImmutableRoaringBitmap.<init>(ImmutableRoaringBitmap.java:406)
…

Code (in Scala):
object EmptyBitmapLoadingBug extends App {
  val rr1 = MutableRoaringBitmap.bitmapOf()
  val rr2 = MutableRoaringBitmap.bitmapOf()
  val bos = new ByteArrayOutputStream()
  val dos = new DataOutputStream(bos)
  rr1.serialize(dos)
  rr2.serialize(dos)
  dos.close()
  val bb = ByteBuffer.wrap(bos.toByteArray)
  val rrback1 = new ImmutableRoaringBitmap(bb)
  bb.position(bb.position() + rrback1.serializedSizeInBytes())
  val rrback2 = new ImmutableRoaringBitmap(bb)
}

The exception is thrown on loading the second bitmap.
I'm using RoaringBitmaps 0.5.9 on Java 1.8.0_65.

Verified.

Thanks for the bug report. Fixed in release 0.5.17. Please upgrade and verify.

Verified as fixed. Thank you, @lemire!

@maciej  Please keep the bug reports coming! ;-)

:+1: whenever I find any – I definitely will! However due to the quality of the project – I doubt there will be many coming. :-)


Switched to semantic versioning

The semver package provides some really nice functionality here that will allow us to bridge semantic and non-semantic versioning:
Console.WriteLine( SemVer.Parse("27") ); // "27.0.0"
Console.WriteLine( SemVer.Parse("28.0.0") ); // "28.0.0"
Console.WriteLine( SemVer.Parse("28.0.0") > SemVer.Parse("27") ); // True

Resolves #12

It would be preferable to keep this in sync with the AssemblyVersion and AssemblyFileVersion, but those don't allow for <IP_ADDRESS> or 28.0.0. I assume this is because it doesn't support a two-digit major version number.

I'm able to set
[assembly: AssemblyVersion("<IP_ADDRESS>")]
[assembly: AssemblyFileVersion("<IP_ADDRESS>")]

without issue.

Obviously <IP_ADDRESS> doesn't make the most sense. It might make more sense to write a proper backwards compatibility layer and use that for both the versioning as well as the launch panels. Currently, we determine which launch panel to use based on what file is found.
https://github.com/redscientistlabs/RTC-Launcher/blob/master/RTCLauncher/MainForm.cs#L325-L336
Sadly, I managed to make a horrible oversight and not version the json which is another potential future compatibility issue that'll have to be dealt with (the json should be versioned rather than directly deserialized so the format can be updated without direct compatibility issues).  We've dug ourselves into a hole and I think a proper interface for handling legacy stuff is a bit better than another coat of paint to try and keep things compatible with old versions.

Understood. I'll close this out then since it sounds like we need a more holistic solution here.


How to draw this attention map correctly? Thanks

This is done in a very similar fashion to saliency maps (also a similar analysis was performed in the Deformable-DETR paper). We do not plan to release this code.


fix: preserve CommonJS compatibility

Resolves: #345
This is another option to #347. Only one of the two PR should be merged.
Description
This PR brings back CommonJS compatibility for @prismicio/client. Unified dependencies introduced in v7.7.0 are ESM-only and need to be compiled down to CommonJS by @prismicio/client. This is achieved by moving the dependencies to the devDependencies map, saving package users from installing them for no purpose since they are now inlined in the dist folder.
For the above to work, this PR also has to do the following:

Rollup needs to be told to explicitly use the Node-compatible export of decode-named-character-reference (the Node-compatible export being browser-compatible too). Rollup would default to using the its browser dedicated export otherwise which is incompatible.
css-selector-parser and parse5 need to remain external and therefore are declared as regular dependencies. This is done because otherwise when attempting to inline them in dist, Rollup/ESBuild would replace their type imports (e.g. https://github.com/mdevils/css-selector-parser/blob/master/src/render.ts#L1) with bare imports, potentially causing bundlers bundling @prismicio/client later on to worry why it's declared side-effect free while have bare imports.
Note: I find this one quite weird to be honest. I tried playing with TypeScript compiler options importsNotUsedAsValues and verbatimModuleSyntax with no luck. I don't know why it keeps on creating bare imports, those packages' dist don't even have them :(

Checklist

[ ] If my changes require tests, I added them.
[x] If my changes affect backward compatibility, it has been discussed.
[x] If my changes require an update to the CONTRIBUTING.md guide, I updated it.

Preview

npm install<EMAIL_ADDRESS>
How to QA [^1]

Checkout and build this branch:git checkout lh/cjs-compat
npm run build

At the root of @prismicio/client:

Create an index.cjs file with the following content and run it with node index.cjsconst prismic = require("./dist/index.cjs")

Create an index.js file with the following content and run it with node index.jsimport * as prismic from "./dist/index.js"

[^1]:
Please use these labels when submitting a review:
:question: #ask: Ask a question.
:bulb: #idea: Suggest an idea.
:warning: #issue: Strongly suggest a change.
:tada: #nice: Share a compliment.

Closed in favor of #347


Flesh out Project and Artifact pages with widgets

We need to create widgets (Plasmic components) for each ArtifactType.
We already have VizNPM and VizGiHub, which probably need to be updated.
We should similarly create ones for

[ ] VizNPM
[ ] VizGitHub
[ ] VizTreasuryAddress
[ ] VizContractAddress
etc

Then plop these into the Project and Artifact pages as appropriate and plumb up the EventDataProvider

@ryscheng I've gone through these and now feel comfortable wiring these up. I've tagged you on a few bugs and EventDataProvider feature requests, mostly related to GitHub stats and basic ContractAddress analysis. I'll jump back in over the weekend and make additional widgets / styling.

Project page is partially done last night. See Plasmic v23.0.0

I have wired up all of the widgets shown here. I'm closing this issue and will open separate issues for bugs and other features.


[Ruby 3.0] Migrate google-api-client gem and drop Ruby 2.4 (#18656)

I merged these in the wrong order 😱
This contains #18656 and #18646

@googlebot I consent.


Setup the Github Actions for website preview

We can deploy the website for a preview if there is a new PR.

With the help of ossjrw/pr-preview-action,
now we can deploy the PR preview.
It doesn't support the create the preview from a forked repo.


Improve index.html

Hi,
we have ~9000 rows in the resulting index.html because we have a lot of images with a lot of tags each.
Loading index.html takes forever because its 8mb in size.
I would like to reduce the content of the index.html to only list all images which are links to a page per image which will list all tags of this image. The reference to the vulns will be located there as well.
@jessfraz what do you think ?

Let my chime in if I may, do you mean to split the results in multiple HTML pages? Like index.html, results-1.html, ...

You can build in pagination I just didn't need it
On Apr 4, 2017 08:19, "George Gkirtsou"<EMAIL_ADDRESS>wrote:

Let my chime in if I may, do you mean to split the results in multiple
HTML pages? Like index.html, results-1.html, ...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jessfraz/reg/issues/19#issuecomment-291533828, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABYNbAobIww7upKvcuDN-OCd9llIs5e8ks5rsl-CgaJpZM4My9AG
.

I can imagine to serve index.html dynamically, should be fast if it only represents the catalog and the tags per image are rendered to a static page for every image.

I open a PR to address this issue here #21

merged.


Merging release 1.50.0 to dev to keep in sync

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

Closing so I can resolve this in a separate branch


step adjust

hi, Is there the possibility to adjust the steps?
in Whisperer there is a "scale factor" setting.
Thanks

There's kinda two ways to do this, neither one is really solid. You can set the scaling in Rotary Settings and leave the settings on with the steps correctly adjusted. Then you can also hit alt+F3 and control+F3 which will adjust to the rotary scaling. (make sure to set the rotary off, with the correct scaling for that one).

Also see #253

Is there a way to set the steps per rotation value?
The textfield in the rotary settings is disabled.

Hi, I tried to adjust the steps in the rotary menu, it doesn't work.
I checked, unchecked but nothing. I have a 1.8 degree stepper motor, whisperer works, meerk no ... I prefer meerk but I don't know how to use it ...help?

You can. Click rotary. Adjust those values. And turn rotary back off. The values still saved and are used for the rotaryview. It was the quick and dirty way to do that while 0.7.0 is still kinda screwy.
Hitting Alt+F3 and Control+F3 will then trigger the view changes as set in there.
https://youtu.be/viCVItFcXi4?t=483
It uses the settings in rotary, even with rotary off. It still saves the scale_x and scale_y values.

The rotary trick works if you have a job loaded. If you move the laser head with the "navigation" menu it does not accept the set values: if I move by 100mm, the head moves by 200mm ...
Do you think there is this change in the next versions?

Hm. That is a fantastic point. Yeah, moving to specific locations would absolutely fail because I'm not adjusting the tick-space correctly. It should properly and correctly warp a lot of those operations. I am trying to finish up 0.7.0 now. I think I have most things no longer crashing. And tweaks and corrections in 0.7.0 are a lot easier to make. Though I think correcting this might require a few different steps.

[ ] Conversion away from Scale Y, Scale X in Rotary for something that is properly step-adjust. This should likely be added into Preferences.
[ ] Change/Correct Navigation to move with regards to the scaling of the space. The Jog distance 394 = 10.0075mm = 1.00076cm = 0.394in information is wrong if we're saying a step in the y-direction is 1.1 mils rather than 1mil. The distance of 1 step is not 1mil but 1.1mil.
[ ] Any returned tracking information is taken as units and would need to be converted to mils to be drawn in the scene.
[ ] Shift home position, should give the position in units rather than mils.
[ ] Most units should be given in steps rather than mils. Dot Length, Overscan, Raster Step. Since a mil is unit of actual distance and a step could be a completely different size accordingly.

Some objects like raster images where each pixel equals each one step would need to be automatically stretched with the deformation but viewed correctly. So if they were 10cm x 8cm but the y: 1step -> 2mils it would have 10cm  x 4cm worth of pixels and need to be stretched, accordingly.
As an alternative, the images could be adjusted correctly. 1 pixel = 1 step in images. If you have a deformed space it would still display the image as the image would actually exist. And give you options to transform it with the rotary scale accordingly.
While I could easily modify the vectors to say that the vectorspace's final real units are not mils but steps and so those could be sent normally rasters would be treated differently with each pixel being equal to 1 step. Which unit-wise would be fairly correct. You would then see everything in the scene as displayed in the correct units but rasters would scrunch according to their pixels (which would then need correcting in a variety of ways).
Another oddity is the rotation of objects. If we have stretched views and scenes, we end up with objects that cannot rotate because of the non-uniform space. Rotating an object stored in steps would require stretching and scrunching it while it's rotating. But, if we treat the scene view as mils, we could have our uniform space, which would be non-uniform tickspace.
I dunno about next version. I'm kinda committed to a feature freeze and getting 0.7.0 up to snuff and working. It seems like a few choice changes could almost do this and then deal with some of the hairier details later. Basically define the scene native units as mils and keep the door open to the fact that the devices native units are steps, and then define the conversion.

I think the big issue is that rasters to work well natively have a pixel size of 1 step. This can be converted prior to actualization where we resample all the pixels. But, after resampling rather than viewed correctly they would be viewed scaled, but they would also be resampled to have more or fewer pixels according to the size of the step-adjust. This is kinda what's done with step-size, in fact it might be able to be folded into that kinda of stuff. Because declaring a raster-step to be 2 or 3 is really just declaring the size of the pixels to be 2 mils x 2 mils or 3 mils x 3 mils.

I understood less than half of what you explained, but I think you are right .. :-)
I think the "scale factor" option should be integrated, perhaps with version .71 or later. It is also important to correct elongated belts, pulleys with different teeth and motors with different pitches.
Thank you for the time you spend improving the software.


Bump webpack-dev-server to 3.1.11

Dependabot is reporting webpack-dev-server as a low severity vulnerability. We need to bump webpack-dev-server to 3.1.11.
https://issues.redhat.com/browse/COST-319

Codecov Report

Merging #1605 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1605   +/-   ##
=======================================
  Coverage   78.72%   78.72%
=======================================
  Files         238      238
  Lines        3891     3891
  Branches      714      714
=======================================
  Hits         3063     3063
  Misses        729      729
  Partials       99       99

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adf0397...be01e15. Read the comment docs.


Fix bug where apps cannot be launched on iOS 18

Closes #41 .
Updates the outdated https://developer.apple.com/documentation/uikit/uiapplication/1622961-openurl API to the newer https://developer.apple.com/documentation/uikit/uiapplication/1648685-openurl API.
The new one works on iOS 18, the old one does not.

Any chance this to be merged? @sarika01
Thanks in advance. 😄

Thanks for PR. Already added fix in 4.0.1 version.

@geekruchika I don't see this fixed in 4.0.1 yet. Only the minimum iOS version was increased, but the deprecated API is still being used. Did you test this on an iOS 18 device?

@geekruchika The issue can still be reproduced in version 4.0.1 on iOS 18.

@geekruchika the bug is still there on iOS 18, can you double check and include this fix in a new release?


Update concept-event-aggregation.md

@batamig - Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


solved twist2ticks bug

in capybarauno_solo solved bug in twist2ticks conversion.
commented useless ROS_INFO
_kbaseline parameter in echo set correctly
default odom parameter now are from the sapienzbot
cheers
praise the sun

Solved another bug in 'solo' node.
From uint16_t to double for sensor_msgs/Joint changed the conversion. I've made the commit from the lenovo notebook, where git commits as Giorgio.
cheers,
Bart


Add portus chart

This is a resubmit of #1284.
Thanks to @so0k for all the hard work!
This is currently the same as the last commit in that PR.
It looks like there are a few differences in layout since that PR was submitted so I will try to address those concerns as I go.
There were also a few concerns not address in the original PR so I will address those as well.

Please check our best practices, especially those on naming resources and standard labels. Resource metadata should generally look like so:
name: {{ template "portus.fullname" . }}
labels:
  heritage: {{ .Release.Service }}
  release: {{ .Release.Name }}
  chart: {{ .Chart.Name }}-{{ .Chart.Version }}
  app: {{ template "portus.name" . }}

Thanks @unguiculus I will get those fixed.

@unguiculus This Chart has multiple components but there isn't a definition $component.name in the _helpers.tpl file and I am not sure of the proper way to do that.
Can you point me to some docs on how to achieve that?
On a side note I am very tempted to split out the registry component into it's own chart and then add that as a requirement for this chart so the templates are a bit simpler.
I am also new to writing Charts so I am still learning how best to do them.

There's a chart for Docker registry already: https://github.com/kubernetes/charts/tree/master/incubator/docker-registry

True. I forgot about that Chart.
I had already discounted that because doesn't have the options we need to setup the registry for Portus.
Maybe I can expand that one so it can be configured with those extra options.
As for my other question what is the best way to define those $component.name variables?

@unguiculus I think worked out what I needed to change.
The latest commit addresses the label inconsistencies.

Please create a PR for the registry chart to add the stuff you need. We should also see that we can move it to stable so you can use it.

Will do.
Thanks for the help @unguiculus It is much appreciated. :)

The reason I had them bundled was the auth token service configuration required on the registry side.
If the registry chart exposes that, it should be fine to define it as a dependency though

@unguiculus What else needs changing in the docker-registry chart to move it to stable?

/ok-to-test

@viglesiasce This is dependent on my other PR for getting docker-registry usable and put of incubator #2801. Once that is sorted I can update this to reflect the new location of docker-registry.

I think the Docker registry chart looks pretty good. I'd suggest you create PR to move it to stable.

It needs to be redone or rebased. Redoing it seems quicker at this stage. #2612 got merged that changed a lot of the docker-registry chart.
I will get that sorted when I get a chance.

The docker-registry PR has been redone in #2926.

@unguiculus This is my PR to promote docker-registry to stable: #2944
I can update the requirements on this once that is merged.

/retest

Let's try it again. Timeouts have been increased.

/retest

I ran a test locally and it's failing with default settings because it expects a tls secret setup with the cert for docker-registry.
It's listed in the README.

You'll have to change it such that CI passes. Otherwise it can't be merged.

Hello @rendhalver the work on this chart is looking very good!
I wasn't aware that anyone was working on implementing a Portus chart, until I came across this. I work at SUSE, and we have also been developing a Portus chart. Our work can be found at https://github.com/kubic-project/caasp-services/tree/master/contrib/helm-charts/portus
Our goal was to propose our chart here when we finished developing it. Would you be interested in collaborating?

Hi @bonhamjp I wasn't aware SUSE was working on a Chart for Portus so I guess we both learned something. :)
Collaboration sounds good to me.
Are you using your Chart in production?
The portus parts of your chart look similar to mine and has some good features that would help get this one finished like generating a tls cert in the container.
I have tried to make this chart use other charts to deploy the components (docker-registry for example).
I am in k8s Slack as rendhalver as well if you want to chat about it there.

@bonhamjp - I pinged portus maintainers on the portus issues related to k8s deployments almost a year ago (when I submitted the first chart proposal - mostly based on the work from Nordstorm)
However, I've notice master was broken for several months and overall development seems stuck - which is why we no longer run Portus at Honestbee

@so0k I couldn't get 2.2 working in our setup either.
I will downgrade it in this chart till it does work.

@unguiculus I just rebased this to pickup the new tests and It looks like we have test success now.
Do you have any further concerns about this one?

I just realised this will need changes to work with Portus 2.3.
I will get those added as soon as I can.

I think work on this PR can be resumed. @mssola released a new version of the Portus image that fixes the issue reported by @rendhalver

I noticed that new version had been released.
Thanks for the reminder @flavio.
I will try and requisition some time to get this working.

@unguiculus Do you have any further concerns?
I managed to get this working with the new 2.3 release.

/lgtm

/approve

Test seem to fail:
I0814 18:31:38.332] Installing chart 'stable/portus' into namespace 'presubmit-2766-12568-wpavpmqpitulekn4'...
I0814 18:31:38.332] Chart does not provide test values. Using defaults...
W0814 18:31:39.426] Error: release portus-wpavpmqpitulekn4 failed: Deployment.apps "portus-wpavpmqpitulekn4" is invalid: spec.template.spec.containers[1].volumeMounts[0].name: Not found: "secrets"
I0814 18:31:40.107] Waiting for rollout to finish: 0 of 2 updated replicas are available...

https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/helm_charts/2766/pull-charts-e2e/12568/

/hold

/lgtm cancel

Thanks I will get that fixed.

Why didn't that failure fail the build?

@rendhalver Have a look at https://github.com/helm/chart-testing/issues/9

/retest

I see what's going on.
It's the problem we had with testing before where the deploy is assuming the Secret exists before the chart it setup.
I will put in the code to create those certs if they don't exist.

With the latest chart-testing fix the CI job finally fails as expected.

Triggering the reopening of this issue. @mssola is going to take care of that unless @rendhalver or others have something against it.

I am happy to help get it working. I haven't had the time to devote to it lately.
I am also happy to be a maintainer and OWNER if you need one.

And thanks. :)
I had a few ideas on how to get it working but didn't get time top test them.
Ping my on your new PR and I will add those thoughts there.


Backbone network used

Which backbone segmentation network is being used in each model(Trained with different datasets)?
Thanks

The backbone network used our own proposed 'HLNet' ...
------------------ 原始邮件 ------------------
发件人: "Vedanta<EMAIL_ADDRESS>发送时间: 2020年2月1日(星期六) 凌晨4:11
收件人<EMAIL_ADDRESS>抄送<EMAIL_ADDRESS>主题: [JACKYLUO1991/Face-skin-hair-segmentaiton-and-skin-color-evaluation] Backbone network used (#4)
Which backbone segmentation network is being used in each model(Trained with different datasets)?
Thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Oh, Okay. Why have you set the default for backbone as none then. Thanks

@JACKYLUO1991 Have you not added the files for HLNet yet ? Sorry for disturbing you.

@Nerdyvedi Hello, the experiment is actually done long ago, and the HLNet (HLRNet is its early version) network in the paper has been updated recently. However, the paper is in the second review .. Once it is done, I will immediately announce all training details.

@JACKYLUO1991 . Thank you so much.
I am training the HLNet network(from your last commit) and the HLRNet network with default parameters, Would the results be not as good as the paper claims ?

@Nerdyvedi Certainly.


fix: Disabled failing e2e test

Temporarily disabling failing e2e test until we can figure out the root cause.
#1553

This doesn't actually fix the linked ticket. I linked the existing closed tickets in the new ticket. We should have something open for the failing test still.


Benchmark using Ramsey detuned routine

This adds a very basic script to benchmark and test Quantum Machines programs directly (without qibolab, qibocal, etc.). I will not spend time on docs, README etc. as I am not sure if this will be used a lot.
What is interesting is that I used the Ramsey detuned routine from the qibolab paper to compare unrolling (=writing multiple play pulse instructions) vs doing a QUA for_ loop and the difference is huge:
Unrolling:
Connection time: 1.482797622680664
Execution time: 3.4133341312408447
Fetch time: 39.18629169464111
Total time: 44.08242344856262

Loop:
Connection time: 1.1545066833496094
Execution time: 0.44145917892456055
Fetch time: 0.2814207077026367
Total time: 1.8773865699768066

@alecandido you may be interested in this.
The two different programs are defined in programs/unrolled.py and programs/loop.py. I have not confirmed they have the same behavior but will try to do so using the simulator.

@stavros11 another simple option for the "simulator": since here only a very limited part of the API is used, you could define your own functions for_(), align(), play(), frame_rotation_2pi(), measure(), and just print an assembly like listing.
Of course, the full simulator should give us some more information, because it could be aware of the quirks of the machine.
But even the less informative listing could help us to check the differences between the two executions, giving a different perspective (we won't have a result, or a timing, but we have the detail of operations, in something that could be automatically inspected and compared).


Footer copyright adjustment

Should read:
© 2021 Consumer Reports, Inc

@benrito This is up for review

Perfect!


Set up GitHub repository with default folders

(From Milestone 1 description)
Create project structure for the software package

Create the project structure for your software package appropriate for the language you have chosen, and push it as a public repository in the UBC-MDS organization on Github.com.

If you are choosing to work in the Python programming language, there is a quickstart guide for setting up the structure for Python project, you can find it here. This time when you are prompted as whether to include GitHub Actions, say yes! In particular, choose option 3 (build + deploy).
If you are choosing to work in the R programming language use the devtools and usethis package for setting up the structure for R project.

The name of the repository should be relevant to the package/project topics.
During project creation, you will be prompted to pick a license and for now choose the MIT license. You may change it later when you learn more about licenses.

Once the projects have been created, add a section to the README.md file called ## Contributors and listing the contributors’ names there (i.e., the names of the members of your student team).

Edit CONDUCT.md to include the code of conduct for contributing to your project. The intention behind creating this file is fostering a healthy and positive work dynamic. Recall that you already have done something similar in DSCI 522, and you can start with that document and adapt it for your new team. Note that when you create the project structure with the methods above, a default version of this file will be created. You may choose to use it or adapt it with appropriate attributions.

Agree upon a collaboration strategy that describes how you will work together on this project (e.g., GitHub flow and edit CONTRIBUTING.md to reflect your strategy. Again, there will be a default version of this file. You can use it as is or adapt it with appropriate attribution. Here are some example CONTRIBUTING.md files for your reference.

Software Carpentry CONTRIBUTING.md
factory_bot_rails CONTRIBUTING.md
moby CONTRIBUTING.md

Outline the package you would like to build in the README.md file. (This can be identical for both projects at this point in the project). In particular, your README.md should contain:

a summary paragraph that describes the project at a high level
a bulleted list of the functions (and datasets if applicable) that will be included in the package (this should be a 1-2 sentence description for each function/dataset)
a paragraph describing where your packages fit into the Python ecosystem (are there any other Python packages that have the same/similar functionality? Provide links to any that do. If none exist, then clearly state this as well).

As discussed during the meeting, I will help with writing the README file. Thanks @Sampsonyu for setting up the default folders! As mentioned, could you just check/edit the conduct/contributing documents haha I thinnk everything else looks good!


extend existing effects from Effect

Proposed changes
Add Effect class that manages connecting the effects in a chain from their AudioPlayer to the AudioEngine.
Reason for changes
Standardize Effect lifecycle so AudioPlayer can treat effects agnostically once it constructs and chains them.
The Effects have these lifecycle "events":

connect
initialize
set
update
dispose

looks good!


Make a matrix multiplication implementation in Rust

Also used in OPQ for matrix dot product

Hi! I would like to implement this one, but it would be nice to specify some details and provide some guidance.
Like how do you see it to be done and so
@changhiskhan

@changhiskhan I can take this. Maybe also a sparse matrix multiplication would be nice (if we can)


Fix boolean ops regression

The boolean ops no longer works in most cases. It was never perfect, but now it rarely works except in ideal circumstances.
The current theory is that winding order has been incorrect since we switched away from Kurbo shapes.
Primitive shapes work with each other, and Pen tool shapes work with each other, but not between the two groups. That's why it's probably a winding order issue. Meaning this is potentially an easy fix.

I don't see why a different winding order would change anything? The algorithm goes around the two shapes looking for intersections, and then creates a new shape based on.

The direction of the user's path should dictate the winding order in my opinion, as it does in inkscape. Renderers will create triangles in the correct way for their graphics API. I believe that the boolean operation sometimes doesn't work on path tool shapes with strait edges due to the handles being located on top of the control points, rather than it just being a linear segment.


fix jaeger from creating unnamed volume for /tmp

The jaegertracing/all-in-one image has a /tmp volume specified in it. Since no volume are mounted in the docker-compose.yaml for jaeger, new unnamed volumes are created on the host each time the container start.
Ref: https://github.com/jaegertracing/jaeger/pull/1571/files

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Draft: Use the USB OUT endpoint transfer failed interrupt

Previously, when the USB interrupt was unmasked and a host issued an OUT transfer that was not subsequently read(), the interrupt would continually fire until read() was called.  This change provides a way for a USB class to acknowledge the transfer without reading the data, and so clear the interrupt flag.

Just noticed this might've broken isochronous transfers; I've got some other local changes that might also be where the problem comes from, but need to do some more digging.

I've made a few changes from the original version of this PR, the main one is that the transfer complete and transfer failed flags are cleared in poll().  usb-device says that the "[OUT] event should continue to be reported until the packet is read" - I think we're still doing that because poll() will continue to report the event, and will be called regularly because endpoint's transfer failed interrupt will now fire when the host retries.


Docs: fixed FAB

I'd suggest adding the following to the documentation for floating buttons:
Wrap your button in the following div to make it fixed:

[Button code...]

Or am I doing something wrong? Couldn't find it anywhere.

@darthsitthiander its a good idea!
You didn't miss anything, it wasn't anywhere in our documentation.


Add support for leader election

By default, the leader election is now enabled in the deployment yaml
but controller's replica count is set to 1.
This is required to prevent IPAM controller
misbehavior in case if user will decide to scale the deployment.

@ykulazhenkov once PR#18 is merged, can you update "flags" section with updated flag set ?

@ykulazhenkov once PR#18 is merged, can you update "flags" section with updated flag set ?

sure, will do

@ykulazhenkov once PR#18 is merged, can you update "flags" section with updated flag set ?

sure, will do

updated

Coverage: 76.01% (-0.4%) from 76.366% when pulling 92f44fd6193c58506273673111ac3e3de4d373cc on ykulazhenkov:leader-elect into 87ee551f0f2213feac58521a7101779cd2e68d5a on Mellanox:main.

This will require a followup PR in network operator as well.


Set up basic data loading from 17Lands

API reference](https://www.17lands.com/ui/)

Reference of sample requests:

Color ratings - https://www.17lands.com/color_ratings/data?expansion=DMU&event_type=PremierDraft&start_date=2020-09-01&end_date=2022-10-08&combine_splash=false
Card ratings - https://www.17lands.com/card_ratings/data?expansion=DMU&format=PremierDraft&start_date=2022-06-08&end_date=2022-10-08
Card evaluation metagame - https://www.17lands.com/card_evaluation_metagame/data?expansion=DMU&format=PremierDraft&rarity=common&color=W&start_date=2022-06-08&end_date=2022-10-08
Play/Draw - https://www.17lands.com/data/play_draw
Trophies - https://www.17lands.com/data/trophies?expansion=DMU&format=PremierDraft
Leaderboard - https://www.17lands.com/data/leaderboard?expansion=DMU&format=QuickDraft

Constants:

Colors - https://www.17lands.com/data/colors
Expansions - https://www.17lands.com/data/expansions?live=true
Formats - https://www.17lands.com/data/formats


Vizlib

Visualization library for thermo raw like data

This is just a quick update for AlphaViz paper, so the docs are still missing for some viz functions.


Workspace data keeps getting deleted

I'm using the free snap version on ubuntu 18.04.  Multiple times I've created many requests in various workspaces in Insomnia that disappear.
It appears as though all saved data is removed after an update to the snap.
Not sure if this expected behavior for the open source version or a bug?

Having the same issue on Mint 20 Cinnamon, installed through the .deb file. It's literally unusable, as I've timed it and just 8 minutes after editing my workspace and environment, everything gets reverted.


Add a not filter for schedules

There is a filter for schedules (https://github.com/Qiskit/qiskit-terra/blob/a3ae434326aefbb19a7861518b4a4f1e05528fb1/qiskit/pulse/schedule.py#L232) It would be convenient if that returned the remainder of the schedule that doesn't satisfy the filter. This makes it easier to, e.g., shift a part of a schedule.
filter(schedule, blah) << 100 + filter(schedule, not blah)

What is the expected enhancement?

Would this be easy to do @lcapelluto?

I think it should be pretty straightforward. For the API, how about:
schedule.filter(args)  # what we already have
schedule.exclude(args)  # the new function

sure as long as schedule.filter(args)+schedule.exclude(args) == schedule

@dcmckayibm it would require | not +, but otherwise yes 👍

I meant whatever we are using for concatenating two schedules


HSEARCH-2569 Make the 'delete-by-query' plugin requirement for ES clearer

https://hibernate.atlassian.net/browse/HSEARCH-2569
This PR brings two changes:

The documentation is clearer about the fact that the 'delete-by-query' plugin is required when using the "purgeAll" option on the mass indexer, and this part of the documentation is more visible.
Whenever a user tries to purge indexes and a 404 error occurs, the error message now mentions that the 'delete-by-query' plugin is required.

We'll probably want to backport at least the first commit to 5.6.

Looks nice, and +1 to backport: I see no significant risk.
Minor question: why did you opt for org.hibernate.search.elasticsearch.impl.JestAPIFormatter to be a Service?
(I couldn't test & build it yet, still figuring out what's wrong with my machine..)

Minor question: why did you opt for org.hibernate.search.elasticsearch.impl.JestAPIFormatter to be a Service?

Because it needs access to GsonService. I guess I could have made it a constructor parameter, but users would still have had to request/release an instance of GsonService (instead of JestAPIFormatter right now), so it wouldn't have been simpler in the end.

merged on master and 5.6


Add more foundries

Thanks for creating this site - I was thinking I would have to make one on this topic!
I've spent way too much time the past week reading font foundry EULAs. Here's my initial contribution.
I've added a new field licenseVersion to make it easier to keep track of which version was read (in the hope more foundries add subsetting and the list becomes out of date).

Is it worth sorting the foundries alphabetically?

Hi @jfrankl I've updated the sorting via #4 so no matter what's going on in the JSON they will be in order - sorted by .support (DESC) then .name (ASC). Hope that works for you!


Searching for future dates by day is not relative to today

Today is: 2017-03-06 (day 65)
Database record is: 2017-06-19 (day 170)
Search success: expires < "172 days"
Search zero results: expires < "171 days"
Search zero results: expires < "Today + 175 days"
As a user, my expectation is that date searches are relative to today. Trying "Today +" syntax also yields zero results.

scoped_search 4.0.0

If expires is a date/time field, then the syntax you are using isn't correct, it should be "172 days ago", not "172 days".
See https://github.com/wvanbergen/scoped_search/wiki/Query-language#temporal-comparisons
Otherwise please include more precise information about the field definition, the database field type and the generated SQL query.

These are future dates being searched for, not in the past. What is the syntax for that?

There is no relative syntax (certainly not just "X days"), use absolute dates or add support.

Consider this an RFE then.


Ltm Pool Members Monitor Property

There is an issue that affects all known versions with monitor property, specifically x of m:
 min 1 of { /Common/https_443 /Common/icmp }

REST has problems processing {} that are in that string, the workaround now is to submit this property string without {}.
 min 1 of  /Common/https_443 /Common/icmp

In the interest of staying consistent, we will strip {} from the property when user specifies it, so we keep user experience consistent, without having to worry about workarounds

This currently blocks refactoring of  pool members module for ansible


[Enhancement] support auto spill mode in aggregate blocking operator

What type of PR is this：

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[ ] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

closed, new PR is : https://github.com/StarRocks/starrocks/pull/21610


fix(site-discovery): error logs

Please ensure your pull request adheres to the following guidelines:

[ ] make sure to link the related issues in this description
[ ] when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

Related Issues
Thanks for contributing!

:tada: This PR is included in version 1.21.0 :tada:
The release is available on:

v1.21.0
GitHub release

Your semantic-release bot :package::rocket:


Blank sideMenu

Hello:
I'm following along with your code examples in the demo of all components, and I've got a sideMenu working just fine on the right side, but when I swipe from the left edge I get what looks like a blank side menu that's just whitespace. I'm not sure if it's related to this issue or not:
http://stackoverflow.com/questions/29690816/ionic-sidemenu-shows-blank-screen-while-swiping-the-screen
If so, how do I edit Ionic settings with this package?
I've been playing with the framework on both iPhone and Android devices and it's working beautifully otherwise. Great package!

Never mind, found your answer here:
https://github.com/meteoric/meteor-ionic/issues/74
Sorry!


add auth token for github api requests

when the github action is being run on repositories that requires authentication to list the commits, the curl command will give a message: Not Found. This is fixed by adding authentication headers to curl, if an access token is being passed as an input.
Signed-off-by: Akhil Mohan<EMAIL_ADDRESS>

cc: @estesp Can you take a look at this PR?

cc: @AkihiroSuda Can you also take a look at the changes?

When will a new tag be made for this repo. Is it on demand or is there a specific process that is being followed for tagging?


refactor(sahared-data): update plunger motor configs

Due to mechanical changes, the PVT single channel pipette needs to run at a lower current than other pipette models.
Additionally, after some period without use, all pipette plungers, except the 96 channels, will need to home using 1A motor current to overcome their static friction.
This branch is just these couple of changes, however I'd like a quick sanity check before merging to make sure that speed won't be an issue during homing. It looks like homing for the first time after attaching will happen using the _build_home_pipettes_runner function, in which case the speed chosen should be 5 mm/sec.

Nice!
Let's retarget this for the 7.0.0 release branch


Proposal: Predefined variables for user's home directory

We are running into a bunch of issues trying to support all of the use cases for devcontainers:

VS Code with bind mounts for source ("Reopen in container" after you open the source folder)
VS Code with code cloned into a container
Codespaces
PyCharm

The main hurdle we are hitting is the fact that Windows has a different env for the Home directory then Linux/Mac. If you are doing 1 or 3, it does not matter as much because for Windows you can do from within WSL first. Codespaces is always Linux.
I have seen some other people use both envs but that is still often resulting in a blank env that generates an error:
"mounts": [
        "source=${localEnv:HOME}${localEnv:USERPROFILE}/.docker,target=/home/app/.docker,type=bind,consistency=cached"
]

results in the following if I do "Clone Repository into Container Volume" straight from VS Code on Windows:
docker: Error response from daemon: invalid mount config for type "bind": bind source path does not exist: /.docker.

Having a cross-platform and always defined way of providing the user's home directory on the host machine would help a ton.
(we are getting around the mount point not always existing with an initializeCommand)
"initializeCommand": {
    "mkdir-posix": "mkdir -p $HOME/.config $HOME/.docker $HOME/.cloudflared || true",
    "mkdir-windows": "mkdir %USERPROFILE/.config %USERPROFILE/.docker %USERPROFILE/.cloudflared || true"
},

Hi 👋
Thanks for opening the issue.
"${localEnv:HOME}${localEnv:USERPROFILE}" is expected to work across Windows and Linux, as either one must be set depending on the OS.

docker: Error response from daemon: invalid mount config for type "bind": bind source path does not exist: /.docker.

Based on the OS, @AngellusMortis can you double check if HOME or USERPROFILE variables exist on your local machine? If those variables are not set, that's the reason why you are seeing this error ^.

They exist on the host machine but are not existing inside of the of VS Code or PyCharm/Jetbrains Gateway. Both within the context of cloning the repo inside of a volume. If it is happening within the Docker "host" VM, I am guessing it is because it is not initializing the user envs correctly inside of the VM.
But this is not the first time I have encountered env issues with devcontainers. Way back when they first started with VS Code, there is a bug/issue where it would not initialize your profile correctly on Windows with WSL. I understand you want to try to use the most "standard" solutions to implement global envs and such, but a user's home directory is pretty critical variable that would great to codify into the standard to ensure it is available even if the profile discovery fails / does not run as expected in some cases (like running inside of a Docker Desktop VM on a Windows machine).

Thanks for the detailed response.

They exist on the host machine but are not existing inside of the of VS Code or PyCharm/Jetbrains Gateway

It would be great to narrow down this issue to a CLI vs Dev Containers Extension vs a VS Code/Py Charm issue.
Did you try using the @devcontainers/cli to create a container, wondering if that worked? That will help us narrow down the issue, thanks!
It would be great if we can update the CLI and somehow compute the home directory without depending on the host environment variables. However, as the home directory is customizable, I cant think of a standard way which will be compatible with all use cases. Thanks for asking this question, would be an interesting investigation. Let us know if you have any thoughts.
Looping in @chrmarti for additional thoughts.

So, I did notice a typo and I started doing more testing. It looks like the issue may have actually been some weird caching. The "Clone Repository in Container Volume" seems to have been re-using the existing container volume regardless if I had deleted the old volume with the code cloned on it. So that seems to have resolved the issue with the env not existing, it was probably a typo in an earlier version of the devcontainer config.
I do still think a platform independent way of way of definitely common envs is a good idea though. Having to specify both variables is kind of annoying, but my main blocking issue is "fixed".
However, I did just encounter a new issue since that is finally working. It looks like workspaceMount and workspaceFolder are not working with VS Code's "Clone Repository in Container Volume"
I can move it to a new issue, but figured I would mention it here since you are likely looking at this thread at the moment. Though it probably needs to be moved to a VS Code Dev Containers repo somewhere.
Using Windows 11 22H2 (build 22621.2428) with VS Code 1.83.1 and Docker Desktop 4.22.1.
Config:
    "workspaceFolder": "/home/vscode/dev",
    "workspaceMount": "source=${localWorkspaceFolder},target=/home/vscode/dev,type=bind,consistency=cached",

Test repo to reproduce: https://github.com/AngellusMortis/test-devcontainer
Full Logs: https://gist.github.com/AngellusMortis/594326ce92bc52970e64b95b78824f64
You can see there is no reference to /home/vscode/dev in the logs, only the default location (/workspaces/test-devcontainer).

It also turns out that JetBrains IDEs do not handled the empty envs. ${localEnv:HOME}${localEnv:USERPROFILE} will resolve to /home/user${localEnv:USERPROFILE}. I know their implementation of dev containers is still pretty experimental as well though.

workspaceFolder not being respected when using a volume is tracked in https://github.com/microsoft/vscode-remote-release/issues/3034.

"${localEnv:HOME}${localEnv:USERPROFILE}" is expected to work across Windows and Linux, as either one must be set depending on the OS.

Problem is that there are cases where you need to set HOME on Windows for some other software ported from Unix, so it's not guaranteed HOME will not be set on Windows. I my case it was usually trying to make git-bash, msys2 and/or cygwin work together correctly, because while git-bash is based on msys2, it is configured slightly differently.

I run into the same issue. The problem seems to be related to WSL2 - there isn't a variable USERPROFILE, hence it will fail on Docker using WSL2. I'm using devcontainer on Windows with VS Code to get an Ubuntu-24 developer environment.


Bug/front end cannot reach feature flags api container add additional auth/cdd 1952

This PR does the following:

Enforces another header on the feature flags alb called x-auth
Injects this key into the frontend containers as the env var FEATURE_FLAGS_AUTH_KEY

This means all requests made to the feature flags service must include the x-auth header

Don't merge this in until the FE is sending the x-auth header
@8lane @rhys-burendo @phill-stanley


feat: #985 check my own permissions

new router and check if need router handler
"my permissions" to side nav bar
global table search
new table for view own access using cached user access info
if user has no access in FAM, he can still access to this page, and we'll display a text message shows that the user has no access in FAM

Hi Jota, I feel the data I get doesn't seem correct... but let's confirm with Olga tomorrow, to see if this table should return my admin access or my regular app access, thanks!!

I think the table margins are not correct, it should have some spacing from the sidenav and the right page border.

Hello! That's the way in the design, and do seen out off place compared to the other tables, maybe we should ask @OlgaLiber2

@NickSaglioni @J0taFerreira yes, it should have some spacing on the right and left like in this example:

Hi Jota, just some suggestions for future, so for this kind of pr that we have 4 difference cases (no permission, FAM admin, app admin, delegate admin), it will be great if we can share some screenshots of how it looks like in the pr description or in the comment, it will help the review process and in the future when we look back. Thanks so much!

This looks pretty good! thanks!!


Add ability to set inTransaction flag when configuring a database

This allows you to configure a test database when you manually start and stop transactions outside of Fluent in order to rollback changes in tests without any other code changes to get Fluent queries to work

Some context:
This came from a client who has a test set up and teardown for integration tests to run the whole test in a transaction. Their setup involves a
try await sqlDB.raw("BEGIN TRANSACTION;").run()

and their teardown involves
try await sqlDB.raw("ROLLBACK;").run()

However Fluent internally stores whether the DB is in a transaction to be able to work out which code path to take https://github.com/vapor/fluent-postgres-driver/blob/main/Sources/FluentPostgresDriver/FluentPostgresDatabase.swift#L84-L86. So in order for Fluent to execute correctly they need to set the flag or change all their business logic to see if they are in a test or not and then either execute the closure or start a transaction
I did try to create a custom extension for Fluent Postgres to expose it as in the PR but everything is internal so it was a complete copy and paste of the entire stack

Would it be better to have something like automateTransactionCommands property in the config (defaulting to true)?
The one additional code change that would require is that this guard https://github.com/vapor/fluent-postgres-driver/blob/main/Sources/FluentPostgresDriver/FluentPostgresDatabase.swift#L84-L86 would need to be guard !self.inTransaction && automateTransactionCommands else.
A couple reasons for this, neither of which affects the underlying functionality:

I think that property name would make the purpose of this config option clearer.
If you never want to use the automated transaction commands in your application, it feels weird to set inTransaction to true during config when you are in fact not in a transaction yet.

I'm uneasy about adding this - there are a lot of ways to turn this into a footgun. I'd ask why this client can't leverage the existing withTransaction(_:) API instead of manually issuing raw transaction control queries; certainly some refactoring would be required, but it beats opening an explicit hole in the transaction safety logic.


Wilderness, The Void, & Enter-Claim

Currently below Y0 and above Y255 is classified as the wilderness. In the case of a void world, if this flag is set to false, a falling player will rubberband at Y0 instead of die a horrible (and deserved) death.

Just ran into this issue as well.  I couldn't even use commands while this was happening and needed someone else to tp me out of it.


Sign OS X binaries

Need to get a key from Apple and sign the .app to allow users to run without removing the extra attributes

Not going to pursue this


Reload instead of restart on config change

Description
This does a graceful restart which shouldn't disrupt existing connections,
except in rare cases of heavy load (which future haproxy versions will
better address).
https://cbonte.github.io/haproxy-dconv/1.7/management.html#4
Issues Resolved
N/A
Contribution Check List

[ ] All tests pass.
[ ] New functionality includes testing.
[x] New functionality has been documented in the README if applicable

This change is

I'm aware of the effort to make service management optional in https://github.com/sous-chefs/haproxy/pull/251, but for ourselves and I think most people, just switching to a graceful reload on config change would suffice.

@jbarbuto if Ubuntu ships with such an old version of haproxy why not use the compile package to get a more modern version, that supports this?

Either way I'm happy to ship this as a fix for this right now.
Thanks!

@damacus I don't personally need to use the haproxy version shipped by Ubuntu Trusty, the init script change was just for the sake of allowing the failed test at https://travis-ci.org/sous-chefs/haproxy/jobs/260412814 to pass. :)
Thanks for merging!


refactor(plot): unify interface of time-series plot API to Collection[XXX]

Signed-off-by: atsushi421<EMAIL_ADDRESS>This PR unifies the interface of the time series data plotting API to Collection[TARGET_OBJECT].
To reproduce: https://drive.google.com/drive/folders/1Egu_tpNeU_KyC7BMa___a-6eKnPr5dAd?usp=sharing

@takeshi-iwanari
Just a notification.
Since this PR changes old APIs to deprecated, CARET_report may outputs warnings.
However, outputs plots will be shown as before.
https://github.com/tier4/CARET_analyze/pull/142/files#diff-022bca202b5b601d96e1f8bac48c11a90a771a7cf173a267fe0da981127a1725R40

@takeshi-iwanari
Just a notification. Since this PR changes old APIs to deprecated, CARET_report may outputs warnings. However, outputs plots will be shown as before.

OK. Thank you for telling it.


KAFKA-12457: Add sentinel ID to metadata topic

KIP-516 introduces topic IDs to topics, but there is a small issue with how the metadata topic will interact with topic IDs.
For example, https://github.com/apache/kafka/pull/9944 aims to replace topic names in the Fetch request with topic IDs. In order to get these IDs, brokers must fetch from the metadata topic. This leads to a sort of "chicken and the egg" problem concerning how we find out the metadata topic's topic ID.
One solution proposed in KIP-516 was to introduce a "sentinel ID" for the metadata topic. This is a reserved ID for the metadata topic only.  This PR adds the sentinel ID when creating the metadata log.
More information can be found in the JIRA and in KIP-516
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@hachikuji we defined it and have a check, but it is internal. I can add a public constant.

@hachikuji I wasn't sure if I should mention the metadata topic/KRaft in the javadoc. I did for now, but let me know if I should change it.


Add Katello 4.8 pipeline

@ekohl how does this look?

@ekohl fixed the script and used it to make the changes requested. Will update Discourse as well.


exe.file?

When will offer The vertcoin wallet as a exe.file?

Hi,
We already offer executable downloads for all the major platforms (Mac, Windows, Linux). The downloads are available here: https://github.com/vertcoin/vertcoin/releases
James


Teradata datatype PERIOD(Date, Date) is shown as [Object]

System information:

Operating system (distribution) and version : Windows 10
DBeaver version 5.3.3

Connection specification:

Database name and version Teradata <IP_ADDRESS>
Driver name: com.teradata.jdbc.TeraDriver <IP_ADDRESS>

Describe the problem you're observing:
Columns of the type PERIOD are shown as 'Object'
We work in a datawarehouse environment and all timelines are saved in PERIOD fields.
As lead developer i'm trying to move all developers and analists to DBeaver but the the period fields are the most important onces which everyone wants to see immediately in the resultwindow.
Steps to reproduce, if exist:
Strangely, when you use this query: select period(date '2019-01-01', date '2019-02-01');
the result is 2 columns, Attr0 & Attr1 which each hold a date.
When querying a table with a period field the resultwindows shows 'Object' in 1 field.

Unfortunately we don't have live instance of Teradata for testing at the moment..

seems issue is fixed for now

Thank you very much, this will make adopting dBeaver by our analists a lot easier.


Connection retry support for uv pip install

pip install supports the --retries command. According to pip install --help...
--retries <retries>         Maximum number of retries each connection should attempt (default 5 times).

I currently develop within an internal package index that can flake when fetching packages. It'd be great for uv pip install to support retrying on a per-connection basis as well. I don't have a preference for if it should retry by default.

command invoked: RUN UV_SYSTEM_PYTHON=1 NO_SQLITE=1 uv pip install -r requirements.txt --no-cache
platform: docker
uv --version: uv 0.2.17

I think we already support network retries, there's more discussion at https://github.com/astral-sh/uv/issues/3514 which should cover what you're looking for. We also added some logging around retries:

#3933
https://github.com/astral-sh/uv/pull/4725

(Feel free to let me know if you have any more questions though!)


Ionic.Zip.dll is missing in Binaries folder in Release <IP_ADDRESS> zip

Hi.
Thank you for MSBuild Extension Pack <IP_ADDRESS>.
Ionic.Zip.dll v<IP_ADDRESS> is missing in the Binaries folder in the <IP_ADDRESS> Release zip file.
As a result, I get the following MSBuild error:
error MSB4062: The "MSBuild.ExtensionPack.Framework.Guid" task could not be loaded from the assembly C:\Build\1\Third Party\MsBuild Extension Pack\<IP_ADDRESS>\Binaries\MSBuild.ExtensionPack.dll. Could not load file or assembly 'Ionic.Zip, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=edbe51ad942a3f5c' or one of its dependencies. The system cannot find the file specified. Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask.
It exists in the v<IP_ADDRESS> zip file though.
Thank you.

Thanks for letting me know. will fix in a few days when i push out a new release.


Consider replace ByteArrayOutputStream and access buffer directly in StatsSerializer.serialize()

As @technicalYogi mentioned in PR #124, directly using ByteArrayOutputStream and call toByteArray() may not be very efficient, as it needs to copy memory to different location. Instead he/she suggests inheriting from ByteArrayOutputStream and access the buffer directly. May be worth considering.

This change may not be necessary with #213.

Agree, going to close this issue since it's outdated.


Update Messaging Groups automatically when Campaign run id changes.

Now, fields mobilecommons_group_doing and mobilecommons_group_completed are not updated when Campaign Run id changes.

 GAMBIT: Update Messaging Groups automatically when campaign run id changes

 GAMBIT: Update Messaging Groups automatically when campaign run id changes

As mentioned -- https://github.com/DoSomething/gambit/issues/775#issuecomment-291535058 I'm leaning toward Gambit requesting the Group ID's from the DS Messaging Groups API (MGAPI) instead of maintaining its own cache (or storing the ID's in a cache on Contentful). The MGAPI maintains its own cache in Mongo to avoid querying out to Mobile Commons for every request.
If we have that in place, the only issue left is posting to the MGAPI when we have a new campaign and/or campaign run -- currently in place when the app starts up based on the values set in CAMPAIGNBOT_CAMPAIGNS. I'd like to deprecate CAMPAIGNBOT_CAMPAIGNS entirely to avoid an app restart to add/remove a Campaign, it also adds overhead when we're maintaining what's available via Contentful through published keywords. Some ideas:

In the Gambit GET /campaigns route -- when querying out to MGAPI and a Messaging Group is not found, make the POST call there to create it and return the new group ID

Add a Slothbot command to POST to MGAPI to create the Groups -- there's already a manual step of a Gambit admin informing @sergii-tkachenko / Quicksilver team that the group id's need to change

The first option seems a bit more error proof.


On ios App closes on back button pressed ?

Bug description:

To Reproduce:

Expected behavior:

Screenshots/Videos:

Environment:

OS:
OS version: 15.0
react-native version: 0.62
react-native-webview version:8.0.2

What back button? iOS doesn't have a back button.

as the error solved now , the error is that i put the web view container in the navigator components from where it get default back header or these header fails in ios on back button pressed.


Adding a newsletter featuring all the available pets to all the users who subscribe!

Yeahh,some pets might be available and not adopted for a long time and some specific people might be searching for the same and I would like to mitigate this problem by cvreating newletters every month which would also increase the popularity of the website!
A newsletter goes to the emails of all those people that subscribed and this way we can also promote the company and also showcase the available pets to all the people around!
Interesting alternative would be to send mails periodically to the customers and the subscribers to visit the website!
I'm Ananya, a GSSOC contributor and would like to work on the same!

Please assign me this issue as GSSOC 23


cmake error on linux, build.sh -p webgl release

I think something might have changed on the cmake side ...
CMake Warning at third_party/spirv-tools/CMakeLists.txt:207 (find_package):
By not providing "FindPython3.cmake" in CMAKE_MODULE_PATH this project has
asked CMake to find a package configuration file provided by "Python3", but
CMake did not find one.
Could not find a package configuration file provided by "Python3" with any
of the following names:
Python3Config.cmake
python3-config.cmake

Add the installation prefix of "Python3" to CMAKE_PREFIX_PATH or set
"Python3_DIR" to a directory containing one of the above files.  If
"Python3" provides a separate development package or SDK, be sure it has
been installed.

Which version of CMake are you using?

3.10.2

You'll need CMake 3.12, I see I forgot to update BUILDING.md, I'll fix this asap.

Is there a way to install that via apt-get?  Or is it  a manual install?

What distribution do you use? It should be available via apt-get if you have a recent distribution or the right repositories for apt-get.

Let me see if I can make the CMake files compatible with 3.10.

ubuntu18.10

https://github.com/google/filament/pull/2296 should address your problem hopefully.

Thx!

after #2296
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at CMakeLists.txt:27 (cmake_policy):
Policy "CMP0074" is not known to this version of CMake.

I can manually install 3.12, but I can see this creating a support headache in the future.

I checked in a fix, try again :)

[94/662] Building CXX object filament/backend/CMakeFiles/backend.dir/src/vulkan/VulkanContext.cpp.o
[95/662] Generate extended instruction tables for debuginfo.
[96/662] Generate tables based on the SPIR-V XML registry.
FAILED: third_party/spirv-tools/generators.inc
cd /tmp/filament/out/cmake-release/third_party/spirv-tools/source && /usr/bin/python3 /tmp/filament/third_party/spirv-tools/utils/generate_registry_tables.py --xml=/tmp/filament/third_party/spirv-tools/external/spirv-headers/include/spirv/spir-v.xml --generator-output=/tmp/filament/out/cmake-release/third_party/spirv-tools/generators.inc
Traceback (most recent call last):
File "/tmp/filament/third_party/spirv-tools/utils/generate_registry_tables.py", line 17, in
import distutils.dir_util
ModuleNotFoundError: No module named 'distutils.dir_util'
[97/662] Building C object third_party/getopt/CMakeFiles/getopt.dir/src/getopt_long.c.o
[98/662] Generate extended instruction tables for spv-amd-gcn-shader.
[99/662] Generate info tables for SPIR-V vunified1 core instructions and operands.
[100/662] Generate language specific header for OpenCLDebugInfo100.
[101/662] Building CXX object filament/backend/CMakeFiles/backend.dir/src/vulkan/VulkanDriver.cpp.o
ninja: build stopped: subcommand failed.
The command '/bin/sh -c ./build.sh -p webgl release' returned a non-zero code: 1

Looks like an issue with your python installation or spirv-tools. It's not part of filament itself unfortunately.

@romainguy for some reason it only happens on master, v1.4.5 builds fine.

We've upgraded to a more recent version of spirv-tools that requires Python3.

I've got python3 installed, guess it's the spirv-tools.

Not sure, you're missing the module distutils which is part of Python.

python3 --version
Python 3.6.9

Try apt-get install python3-distutils maybe? It should already be installed but it seems it's not on your distribution.

That did the trick, thx @romainguy !


Invalid Declaration

Guys i'm still getting the invalid declaration error

My podfile
    # Uncomment this line to define a global platform for your project
 platform :ios, '10.0'

target 'TechStack' do
  # Comment this line if you're not using Swift and don't want to use dynamic frameworks
  use_frameworks!

  # Pods for TechStack
    pod 'ObjectMapper', '~> 2.1'
    pod 'Moya', '8.0.0-beta.2'
    pod 'RxAlamofire', :git => 'https://github.com/RxSwiftCommunity/RxAlamofire.git', :branch => 'develop'

  target 'TechStackTests' do
    inherit! :search_paths
    # Pods for testing
  end

  target 'TechStackUITests' do
    inherit! :search_paths
    # Pods for testing
  end
post_install do |installer|
  installer.pods_project.targets.each do |target|
    target.build_configurations.each do |config|
      config.build_settings['SWIFT_VERSION'] = '3.0'
    end
  end
end

end

it builds when i comment out these to lines and import RxCocoa

Probably Moya', '8.0.0-beta.2' is downloading RxSwift and RxCocoa 3.0.0-beta.2 and RxAlamofire is not working with beta.2, they have to update it. You can use a previous version of Moya until they upgrade RxAlamofire to beta.2

This was fixed in #56. Closing now


Added responsiveness(Alert Message) in contact page

#122

#122

Hey @tjanhvi  can you show me what changes have you done.


DeepAR external Regressors

I am working on time series forecasting using LSTMs. My dataset has time series (sales on each day) data, plus external regressors like discount on particular day, holidays, day of week. Now that I want to move to DeepAR, I was wondering, how to incorporate these features in the DeepAR training data (json format) and run DeepAR ? "cat": in training dataset didn't work. Note : I want to add these because, I want to know how forecast is affected based on discount and holiday period features.

Thanks, @cna274 .  Currently, the SageMaker DeepAR algorithm does not support external regressors.  However, some lags are automatically calculated and included in the model for you.  With daily data, the lags included are previous week, 2 weeks, 3 weeks, 4 weeks, and year.  Ideally, this should capture some of the seasonality.  Unfortunately, you won't be able to capture the effect of discount, or planned discount, in your DeepAR model.

https://aws.amazon.com/blogs/machine-learning/amazon-sagemaker-deepar-now-supports-missing-values-categorical-and-time-series-features-and-generalized-frequencies/
This blog was posted on 11 JUL 2018.
Has this situation now changed @djarpin ?

The blog post talks about: "Custom time series feature" which seems like an external regressor to me

Hi @pjebs - Correct.  DeepAR began supporting external regressors in July.

Is it possible to obtain the model without accessing it through the endpoint?

Hi @pjebs - The model.tar.gz is written to S3 output path you specify.  What would you like to do with the model though?  DeepAR is a recurrent neural network model, so there aren't really interpretable coefficients like you'd find in a linear regression.  And the scoring code to generate predictions and quantiles is non-trivial.  So, it would be difficult to generate predictions locally.  There is SageMaker batch transform which would allow you to generate predictions without having a persistent endpoint.  Thanks.

Our use case is we have sales data for lots of different customers and would like to forecast for each individual customer.
It just seems cumbersome for our backend (or frontend) to have to keep a record of each generated forecasting endpoint when we want to apply it for each customer.

Hi @pjebs - Typically DeepAR excels when building one model to forecast multiple time series.  i.e. You may want to build one DeepAR model capable of generating forecasts for every customer.  This would mean you'd only have on endpoint to keep a record of.  Is there a reason you want to have a separate model for each customer?  Thanks.

Hi @pjebs - To a large extent this is dependent on your data.  In some cases, even if customers are different, overarching similarities like increased buying on weekends or holidays, or upward or downward trends in aggregate demand over time, means that fitting one model in aggregate will produce better results.  A bit of experimentation here, in particular using DeepAR's "cat" feature to group customers from the same market and/or industry, may help you determine what works best for your data.

@basharre

@djarpin Yes you are right, we can also add Multiple categories per time series now in DeepAR. For example in your case you can group customer from one country to particular category.
Given each customer could have different timezones, would we need to convert the dates column to utc and have a different category for timezone?
This is very specific design question. But idea for DeepAR is cross-learning hence high number of time series would give better accuracy.
I added external regressors and ran the model, works perfectly fine. I am figuring out hyper-parameter tuning now. I see "start_date" in input json is very important make sure you give right value to it.


1202288 security

These are all minor upgrades. I'll wait until Travis is green, then merge.

Green! Merge!


Mark review comment as invalidated when file is deleted

When deleting a file with review comments these comment are now marked as outdated.
Fixes https://github.com/go-gitea/gitea/issues/5417

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@cb1048d). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master    #8751   +/-   ##
=========================================
  Coverage          ?   41.39%
=========================================
  Files             ?      539
  Lines             ?    69477
  Branches          ?        0
=========================================
  Hits              ?    28757
  Misses            ?    37029
  Partials          ?     3691

Impacted Files
Coverage Δ

models/issue_comment.go
47.97% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb1048d...4fafcbf. Read the comment docs.


no "Open" and "Open with" buttons on .zip archives

Explain the bug
as titled
To reproduce
right click on .zip file
Expected behavior
there should be missing options
Logfile
debug.txt
debug_fulltrust.txt
System Information

OS Version:  Windows 10 2004 19041.867
App version: <IP_ADDRESS>

Screenshots
actual

expected

This issue should be resolved with #6002.


AP-269 keep payment after shipping selection, add update info button

Summary

Update payment selection screen, verify  payment data selected stays stored in Session storage.
When selecting a shipping method, validate if an active payment method is available.
if payment data is available do not reset the payment web component screen (show update info button)
Show the "update info" button when active payment data is available,
before it would  show an empty web component card for the payment option.

:no_entry: Current Adyen development branch has a breaking change:
:no_entry: updated development branch has an additional issue with me.opts.adyenIsAdyenPayment coming from BE.
// file:  Resources/frontend/js/jquery.adyen-confirm-order.js

checkSetSession: function () {
     if (!$.isEmptyObject(me.opts.adyenSetSession)) {
//      ...
      } else {
           me.sessionStorage.removeItem(me.paymentMethodSession);
     }
}

This else breaks the confirm page as it will clear the payment data from session storage which is needed for the actual payment process.

Tested scenarios

Select payment method Bancontact, continue to checkout confirm
Select payment method Bancontact, change shipping method, continue to checkout confirm
Select payment method Bancontact, re-select payment method MasterCard, continue to checkout confirm
Select payment method Bancontact, change shipping method, re-select payment method MasterCard, continue to checkout
Select payment method Bancontact, change shipping method, re-select payment method MasterCard, change shipping method, continue to checkout confirm

Fixed issue:  #134

Hi @bortefi, I found something odd, maybe you're able to confirm if it is an issue.

Enter 3DS2 card details.
Change shipping method (this adds update info link).
Confirm.
Place order.

I get "Invalid card number" instead of the 3DS2 challenge, and the logs show that apparently the payment details are empty. Could this be because of the issue you mention in the description and that is being fixed in #149?

@acampos1916 I will test today this PR with the updated develop branch if the issue still is present.

Thanks for checking @bortefi.

After updating the branch with the updated develop branch i also receive the invalid card for Bancontact
on without the develop branch the this PR works.

Weird, I just tested again making sure of using your forked branch and was able to reproduce using 3DS2 and Bancontact.
I'm opening an internal ticket so that someone else can confirm.

@acampos1916
✔ I will test today this PR with the updated develop branch if the issue still is present.
After updating the branch with the updated develop branch i also receive the invalid card for Bancontact
on without the develop branch the this PR works.
The issue remains with checkSetSession, on initial checkout there is no payment data form BE (because the front end has this data before a payment is made, but the new option me.opts.adyenIsAdyenPayment is set from the backend this will not work as expected. The front end should validate if it has an Adyen payment set.
In this PR also added some helper methods on payemn-selection.js to facilitate the validation if the set payment method.

@bortefi did you say that there was still a problem with checkout after merging #149 ? I made the changes to checkSession here and now the issue is gone for me. Can you still reproduce the bug that prevents paying with Adyen PMs?

@bortefi could you please check Peter's comment? Maybe that change indeed fixe this issue.
Thank you in advance!

@peterojo, @cyattilakiss I will check it this sprint,

@bortefi
I merged by accident. Did you check Peter's comment above?
If so, we can undo the revert. Otherwise, let us know.
Cheers!

@msilvagarcia
I will check it together with the pull request 155,
which needs a rebase of the development branch anyway.

This PR is now included and brought up to date with #155


[MLIR] load and execute plugins

Context: After #1285 we will be able to compile LLVM and our MLIR tools with default visibility. Default visibility is needed for MLIR plugins.
Description of the Change: This PR adds the ability to load and execute plugins from catalyst-cli and quantum-opt.
Benefits: Users can build the standalone module easily with make standalone-plugin and can run it with catalyst-cli.
Possible Drawbacks: Something I don't like about this PR is the need to copy the standalone folder from LLVM/MLIR. However, I do make some changes such that the plugin test tests that it works with catalyst-cli. See here for an example.
Related GitHub Issues:
[sc-73562]
[sc-73565]
[sc-73566]
Before merging, we need to clear the cache of all LLVM, MHLO, Enzyme as they need to be rebuilt with VISIBILITY=default. Otherwise, trying to build the standalone plugin will fail.

@dime10 it is mostly there, I still need to work on the build system to reflect the recent changes (i.e., apply the patch on all the wheels). I'll work on it tomorrow

@dime10 , I think this is ready.

@dime10 , I think this is ready.

Is it expected that the build is broken? 😅

Is it expected that the build is broken? 😅

Yes. Because it is attempting to build the standalone plugin but the linker cannot see the symbols.
@CMakeFiles/StandalonePythonCAPI.rsp && :
/usr/bin/ld: /home/runner/work/catalyst/catalyst/llvm-build/lib/libMLIRLLVMCommonConversion.a(TypeConverter.cpp.o): relocation R_X86_64_PC32 against protected symbol `_ZN4mlir27barePtrFuncArgTypeConverterERKNS_17LLVMTypeConverterENS_4TypeERN4llvm15SmallVectorImplIS3_EE' can not be used when making a shared object
/usr/bin/ld: final link failed: bad value

Once we purge everything, then it will pass.


Write a C# program to convert a string to an integer

Description
Write a C# program to convert a string to an integer
Input  : "123"
Output : 123

How to contribute

Save the solution in program/ConvertAStringToAnInteger.cs file
Add ConvertAStringToAnInteger.cs file in convert-a-string-to-an-integer folder

!assign

Hey @roberanegussie, this issue is already assigned to @anandfresh !!!
Please choose another issue.
Thanks for your interest in contributing to this project.


Fix non-deterministic search

Fixes #10.
Copy over the following functions from UMAP master (ab7f27d):
build_candidates, new_build_candidates and make_nn_descent.
Honestly, I didn't look at the code at all, nor did I delve into how the method works. But I took the code for the problematic functions from the UMAP repository, which appears to be a fair bit ahead of this repository, and put it here and, voilà, it works.
I did identify the problem being the parallel=True directive in the old build_candidates. It seem that it was found and fixed a while ago in UMAP.

@pavlin-policar I've turned your code to reproduce this issue into a unit test in #14. It has been fixed by #12, so this PR may no longer be needed.
I've also started work on harmonizing the the common code between umap and pynndescent (see #13), with the aim of ultimately removing the duplication entirely by making umap depend on pynndescent.

Awesome, thanks!

Thanks @tomwhite!