[$250] Search - (edited) label disappears after refreshing Search page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.43-1
Reproducible in staging?:
Reproducible in production?:
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Action Performed:

Go to staging.new.expensify.com
Go to DM.
Send a message.
Go to Search > Chat.
Click on the message sent in Step 3.
Right click on the message > Edit comment.
Edit the comment and save it.
Refresh Chat page.

Expected Result:
(edited) label will persist after refreshing Search page.
Actual Result:
(edited) label disappears after refreshing Search page.
Workaround:
Unknown
Platforms:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/473d0643-2756-424d-9a60-383c1205a1ac

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021843656023889583525
Upwork Job ID:<PHONE_NUMBER>889583525
Last Price Increase: 2024-10-08

Issue OwnerCurrent Issue Owner: @hungvu193

We think that this bug might be related to #wave-control

I believe this is a backend issue because the response from the Search API does not include isEdit in the Onyx data. When this response is saved to the snapshot, it removes isEdit from the snapshot data, causing the issue.

Still need to test this to confirm it can be recreated! Working on that ASAP

After fresh testing, I was FINALLY able to get it to happen consistently, so getting eyes on this!

Sounds like a BE issue. I'll review this one in my morning 🥹

I can reproduce, reviewing shortly

I think this one can be external. Waiting for proposals!

I think this is BE issue, isEdited didn't return from the BE. Can you please add Internal label? @CortneyOfstad

Proposal
Please re-state the problem that we are trying to solve in this issue.
Search - (edited) label disappears after refreshing Search page
What is the root cause of that problem?
The backend does not return isEdited in the API response. As a result, the snapshot is updated with the response without isEdited after the Search call is successful, which causes this issue.

What changes do you think we should make in order to solve the problem?
I suggest two options to fix this issue:
Option 1: We can use the message data in reportAction from Onyx to update the reportAction in snapshot_ because the reportActions from Onyx includes isEdited and is up to date. Something like that:

Create SnapshotConnection.ts like ReportConnection to get all snapshot_

+           let allSnapshot;
+             Onyx.connect({
+                   key: ONYXKEYS.COLLECTION.SNAPSHOT,
+                   waitForCollectionCallback: true,
+                   callback: (value) => {
+                          allSnapshot = value;
+                  },
+            });

+  function getAllSnapshot() {
+    return allSnapshot;
+ }

Update the reportAction data for ONYXKEYS.COLLECTION.SNAPSHOT.

function getOnyxLoadingData(hash: number): {optimisticData: OnyxUpdate[]; finallyData: OnyxUpdate[]; successData: OnyxUpdate[]} {
  // .src/libs/actions/Search.ts#L30
+    const allSnapshot = SnapshotConnection.getAllSnapshot();
+    const allReportActions = ReportActionsConnection.getAllReportActions();
+    const allSnapshotData = allSnapshot ? allSnapshot[`${ONYXKEYS.COLLECTION.SNAPSHOT}${hash}`]?.data : [];

 // .src/libs/actions/Search.ts#L37
+ const successData: OnyxUpdate[] = [];

+    if (allSnapshotData) {
+        let reportActions: Record<string, any> = {};

+        Object.keys(allSnapshotData).forEach((item) => {
+            if (!item.startsWith(ONYXKEYS.COLLECTION.REPORT_ACTIONS) || !allReportActions) {
+                return;
+            }

+            const allSnapshotDataItem = allSnapshotData[item];
+            const reportActionItem = allReportActions[item];

+            if (reportActionItem) {
+                Object.keys(allSnapshotDataItem).forEach((reportActionID) => {
+                    if (reportActionID in reportActionItem) {
+                        allSnapshotDataItem[reportActionID].message = reportActionItem[reportActionID].message;
+                    }
+                });
+            }

+            reportActions[item] = allSnapshotDataItem;
+        });

+        successData.push({
+            onyxMethod: Onyx.METHOD.MERGE,
+            key: `${ONYXKEYS.COLLECTION.SNAPSHOT}${hash}`,
+            value: {
+                data: reportActions,
+            },
+        });
+    }
}

 // .src/libs/actions/Search.ts#L144
- API.write(WRITE_COMMANDS.SEARCH, {hash: queryJSON.hash, jsonQuery}, {optimisticData, finallyData});
+ if (successData && successData.length) {
+        API.write(WRITE_COMMANDS.SEARCH, {hash: queryJSON.hash, jsonQuery}, {optimisticData, finallyData, successData});
+    } else {
+        API.write(WRITE_COMMANDS.SEARCH, {hash: queryJSON.hash, jsonQuery}, {optimisticData, finallyData});
+    }

Option 2: The backend must be updated to return isEdited, if applicable.

POC
https://github.com/user-attachments/assets/a5c4b50e-5a23-425f-b016-194a07f90256

@hungvu193 , Could you please review my proposal? If we don't update from the backend, we can use the message from ReportAction in Onyx, which is the first option I suggest. If you agree with this option, I will continue testing and create a test branch soon. The second option is to update from the backend side.

@huult I don't think looping over all snapshot data to update the reportActions is a good idea. I still think BE should fix this.

@hungvu193 , Yes, thank you for your feedback. If the backend change is complex, we can address it from the frontend.

Hey @mallenexpensify! I am heading OoO this afternoon (10/15 to 10/23) so reassigning this in the meantime to keep it moving! Thanks!

@hungvu193 can you add 🎀 to assign an internal engineer to confirm they agree it's a bug that needs to be fixed on the backend?  (they can unassign after)

🎀 👀 🎀

Yes, it seems we send a smaller version of the action compared to the normal one and isEdited is missing. I am not fully sure how search works on the BE but I am going to take a quick lool

Found the bug

I'm back from OoO – thanks for holding down the fort @mallenexpensify!

Removing the Hot pick label because Rocio picked this up. What remains for this issue?

Cool, sounds good. I'll leave that to the BZ assigned. 👍

@CortneyOfstad Can you double check the bug is gone after fixing it in the back-end?

Yep! Testing now @pecanoro!

Just tested and it works! The edited label stayed even after refreshing a few times!
@hungvu193 can you confirm if this needs any regression tests? Once that is confirmed, I can do the Payment Summary and get this closed out 👍
Thanks!

Heyy @CortneyOfstad, This is BE issue so I don't think there's payment summary or regression tests are needed. Feel free to close 😄


Icon ArrowBackIos left-aligned while icon ArrowForwardIos center aligned

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

The ArrowBackIos is left-aligned while ArrowForwardIos is center aligned. Assuming these are used together quite often, it makes for funny looking buttons when a background is applied.
Expected Behavior 🤔
Either center-align ArrowBackIos or right-align ArrowForwardIos

Steps to Reproduce 🕹

Steps:

import ArrowBackIos and ArrowForwardIos
Use both on white backgrounds
See how funny they look.

Context 🔦
From https://material-ui.com/components/material-icons/:

Your Environment 🌎

Tech
Version

Material-UI-icons
v4.9.1

Duplicate of https://github.com/mui-org/material-ui/issues/17425 and https://github.com/mui-org/material-ui/issues/21898 🤦♂


Host key verification failed

Hey again, seems like I keep on bumping to your actions 👋🏻
I've tried adding this, and I get a successful message
Starting ssh-agent
Adding private key to agent
Identity added: (stdin)

However, when trying to do a clone or submodule init, I get this:
Host key verification failed.
fatal: Could not read from remote repository.

I've tried cloning the repo using the key, and it works on my machine. I've seen a note in keyscan but I'm not really sure if it's the correct command
I used this to no avail
 ssh-keyscan -t rsa bitbucket.org | ssh-keygen -lf -

nevermind, I'm using ssh-keyscan incorrectly.
resolved using it like this:
ssh-keyscan bitbucket.org >> ~/.ssh/known_hosts

@thisguychris It's generally safer to not rely on ssh-keyscan. See a workaround here.


Guidance on updating an ORD database from a (much) earlier version

Is your feature request related to a problem? Please describe.
If an organisation has been using a very early version of the ORD to store their internal data, there may be challenges in updating the ord-schema to later versions.
Describe the solution you'd like
Some documentation to outline the process. Where version changes are found to change the ORM and how it functions, or deprecate certain fields or ENUMs then advice can be provided on how to migrate old data through the change.

0.3.37 -> 0.3.38 ord_schema.orm.mappers overhauled to use programmatic ORM  definitions instead of explicitly defined classes. After this change it is no longer possible to use:
from ord_schema.orm.mappers import Compound, CompoundIdentifier, Reaction, ReactionInput

You need to change your imports to use the Mappers object: https://github.com/open-reaction-database/ord-schema/blob/main/ord_schema/orm/rdkit_mappers_test.py#L29

0.3.37 -> 0.3.38 NAME ReactionIdentifierType ENUM changed to REACTION_TYPE.


Add Engagement Activity Method to Operational Real Time API

https://developers.liveperson.com/data-operational-realtime-agent-activity.html

Fixed in https://github.com/scottwestover/Unofficial-LiveEngage-API-Wrapper/commit/b31bbffb9a9d3bf5045699a5c45014a94f7dd92b


feat: Add support for dual_stack_dns_name output value

Description

Add support for dual stack capability with Global Accelerator:
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/globalaccelerator_accelerator.html#ip_address_type
https://aws.amazon.com/about-aws/whats-new/2022/07/aws-global-accelerator-announces-ipv6-support
Motivation and Context

AWS Global Accelerator offers dual-stack accelerators that enable us to route IPv6 traffic to Regional Application Load Balancer endpoints. This great feature empowers us toward a dual-stack edge network.
Breaking Changes

No

How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[ ] I have tested and validated these changes using one or more of the provided examples/* projects

[x] I have executed pre-commit run -a on my pull request

This PR is included in version 2.2.0 :tada:


Broken public_path in Rails 3.2

jruby-jars (1.6.7)
jruby-rack (1.1.4)
rails (3.2.1)
warbler (1.3.2)

Generating a new rails app with rails new jruby-rack-bug -OJT and adding this to config/application.rb:
$stderr.puts(Rails.public_path.inspect)
$stderr.puts((::PUBLIC_ROOT rescue :undefined).inspect)

yields this in the log:
130 [main] INFO org.mortbay.log - jetty-6.1.24
160 [main] INFO org.mortbay.log - Deploy /etc/jetty/contexts/javadoc.xml -> org.mortbay.jetty.handler.ContextHandler@285876fe{/javadoc,file:/usr/share/jetty/javadoc}
197 [main] INFO org.mortbay.log - Extract file:/var/lib/jetty/webapps/jruby-rack-bug.war to /var/cache/jetty/data/Jetty__8080_jruby.rack.bug.war__jruby.rack.bug__7r60zq/webapp
1088 [main] INFO org.mortbay.log - NO JSP Support for /jruby-rack-bug, did not find org.apache.jasper.servlet.JspServlet
1189 [main] INFO /jruby-rack-bug - Warning: no max runtimes specified.
1247 [main] INFO /jruby-rack-bug - jruby 1.6.7 (ruby-1.8.7-p357) (2012-02-22 3e82bc8) (OpenJDK 64-Bit Server VM 1.7.0_147-icedtea) [linux-amd64-java]
1247 [main] INFO /jruby-rack-bug - Info: using runtime pool timeout of 30 seconds
1247 [main] INFO /jruby-rack-bug - Warning: no min runtimes specified.
1247 [main] INFO /jruby-rack-bug - Warning: no max runtimes specified.
1259 [main] INFO org.mortbay.log - Opened /var/log/jetty/2012_02_24.request.log
1272 [main] INFO org.mortbay.log - Started SelectChannelConnector@:8080
"/var/cache/jetty/data/Jetty__8080_jruby.rack.bug.war__jruby.rack.bug__7r60zq/webapp/WEB-INF/public"
"/var/cache/jetty/data/Jetty__8080_jruby.rack.bug.war__jruby.rack.bug__7r60zq/webapp"

and checking the directories:
$ file /var/cache/jetty/data/Jetty__8080_jruby.rack.bug.war__jruby.rack.bug__7r60zq/webapp/WEB-INF/public
/var/cache/jetty/data/Jetty__8080_jruby.rack.bug.war__jruby.rack.bug__7r60zq/webapp/WEB-INF/public: ERROR: cannot open `/var/cache/jetty/data/Jetty__8080_jruby.rack.bug.war__jruby.rack.bug__7r60zq/webapp/WEB-INF/public' (No such file or directory)
$ file /var/cache/jetty/data/Jetty__8080_jruby.rack.bug.war__jruby.rack.bug__7r60zq/webapp
/var/cache/jetty/data/Jetty__8080_jruby.rack.bug.war__jruby.rack.bug__7r60zq/webapp: directory

Seems jruby-rack updates/edits Rails.application.config.paths['publc'] some time later (railtie initializers run too late). So if anyone else needs to use the public path inside config/application.rb (e.g. for a custom config.exceptions_app), you have to add a work-around in config/application.rb which seems to work OK:
   class Application < Rails::Application
+    # NOTE https://github.com/jruby/jruby-rack/issues/99
+    config.before_configuration{ paths['public'] = PUBLIC_ROOT } if defined? PUBLIC_ROOT
+

Hey @zaadjis thanks for reporting !
As far as I see things there at least 2 related issues, let's break them down :

Rails.public_path being set "too" late (currently in an initializer), I think it should be movable to a before_configuration block (maybe even earlier) in jruby-rack just like you did
secondly PUBLIC_ROOT seems as a pre Rails 3 thing - it should not be set for Rails 3
and of course the "...7r60zq/webapp/WEB-INF/public" path should never have been seen as Rails.public_path

Let me know if I forgot something ...


Add docs for Terraform package

@justinvp Do I need to do anything else here to get this stuff into the ToC since it is a new package?

@ellismg, you'll need to add the following below these lines in config.toml:
[[menu.reference]]
    parent = "node"
    name = "terraform"
    url = "/reference/pkg/nodejs/pulumi/terraform/"

It'd also be good to add it to this map to get nicer links to GitHub: https://github.com/pulumi/docs/blob/5c3ab26d28ae18c1f844e10ce3f0b69607b3d817/tools/tscdocgen/main.go#L165

The build failure looks like just an intermittent network issue (broken link checker failed on https://aws.amazon.com/lambda/, but it works for me).

Applied your feedback, @justinvp, PTAL.


Fix grpcgen TestMtls

Please provide a description of this PR:
Fix https://github.com/istio/istio/issues/36804

@hzxuzhonghu: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-operator-controller-tests_istio

unit-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-operator-controller-tests_istio

unit-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-operator-controller-tests_istio

unit-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-operator-controller-tests_istio

unit-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-ipv6-k8s-tests_istio

integ-cni-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-cni-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-operator-controller-tests_istio

unit-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-ipv6-k8s-tests_istio

integ-cni-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-cni-k8s-tests_istio

release-test_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-operator-controller-tests_istio

unit-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-ipv6-k8s-tests_istio

integ-cni-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-cni-k8s-tests_istio

release-test_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test release-test_istio

gencheck_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-operator-controller-tests_istio

unit-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-ipv6-k8s-tests_istio

integ-cni-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-cni-k8s-tests_istio

release-test_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test release-test_istio

gencheck_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test gencheck_istio

integ-security-multicluster-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-operator-controller-tests_istio

unit-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-ipv6-k8s-tests_istio

integ-cni-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-cni-k8s-tests_istio

release-test_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test release-test_istio

gencheck_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test gencheck_istio

integ-security-multicluster-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-security-multicluster-tests_istio

lint_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-operator-controller-tests_istio

unit-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-ipv6-k8s-tests_istio

integ-cni-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-cni-k8s-tests_istio

release-test_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test release-test_istio

gencheck_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test gencheck_istio

integ-security-multicluster-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-security-multicluster-tests_istio

lint_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test lint_istio

integ-security-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-operator-controller-tests_istio

unit-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-ipv6-k8s-tests_istio

integ-cni-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-cni-k8s-tests_istio

release-test_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test release-test_istio

gencheck_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test gencheck_istio

integ-security-multicluster-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-security-multicluster-tests_istio

lint_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test lint_istio

integ-security-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-security-k8s-tests_istio

integ-security-istiodremote-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-security-istiodremote-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-operator-controller-tests_istio

unit-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-ipv6-k8s-tests_istio

integ-cni-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-cni-k8s-tests_istio

release-test_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test release-test_istio

gencheck_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test gencheck_istio

integ-security-multicluster-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-security-multicluster-tests_istio

lint_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test lint_istio

integ-security-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-security-k8s-tests_istio

integ-security-istiodremote-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-security-istiodremote-tests_istio

analyze-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-operator-controller-tests_istio

unit-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-ipv6-k8s-tests_istio

integ-cni-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-cni-k8s-tests_istio

release-test_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test release-test_istio

gencheck_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test gencheck_istio

integ-security-multicluster-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-security-multicluster-tests_istio

lint_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test lint_istio

integ-security-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-security-k8s-tests_istio

integ-security-istiodremote-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-security-istiodremote-tests_istio

analyze-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test analyze-tests_istio

release-notes_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-operator-controller-tests_istio

unit-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-ipv6-k8s-tests_istio

integ-cni-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-cni-k8s-tests_istio

release-test_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test release-test_istio

gencheck_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test gencheck_istio

integ-security-multicluster-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-security-multicluster-tests_istio

lint_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test lint_istio

integ-security-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-security-k8s-tests_istio

integ-security-istiodremote-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-security-istiodremote-tests_istio

analyze-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test analyze-tests_istio

release-notes_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test release-notes_istio

integ-telemetry-mc-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-operator-controller-tests_istio

unit-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-ipv6-k8s-tests_istio

integ-cni-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-cni-k8s-tests_istio

release-test_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test release-test_istio

gencheck_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test gencheck_istio

integ-security-multicluster-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-security-multicluster-tests_istio

lint_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test lint_istio

integ-security-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-security-k8s-tests_istio

integ-security-istiodremote-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-security-istiodremote-tests_istio

analyze-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test analyze-tests_istio

release-notes_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test release-notes_istio

integ-telemetry-mc-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-telemetry-mc-k8s-tests_istio

integ-pilot-multicluster-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-operator-controller-tests_istio

unit-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-ipv6-k8s-tests_istio

integ-cni-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-cni-k8s-tests_istio

release-test_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test release-test_istio

gencheck_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test gencheck_istio

integ-security-multicluster-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-security-multicluster-tests_istio

lint_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test lint_istio

integ-security-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-security-k8s-tests_istio

integ-security-istiodremote-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-security-istiodremote-tests_istio

analyze-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test analyze-tests_istio

release-notes_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test release-notes_istio

integ-telemetry-mc-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-telemetry-mc-k8s-tests_istio

integ-pilot-multicluster-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-pilot-multicluster-tests_istio

integ-telemetry-istiodremote-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-telemetry-istiodremote-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-operator-controller-tests_istio

unit-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-ipv6-k8s-tests_istio

integ-cni-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-cni-k8s-tests_istio

release-test_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test release-test_istio

gencheck_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test gencheck_istio

integ-security-multicluster-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-security-multicluster-tests_istio

lint_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test lint_istio

integ-security-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-security-k8s-tests_istio

integ-security-istiodremote-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-security-istiodremote-tests_istio

analyze-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test analyze-tests_istio

release-notes_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test release-notes_istio

integ-telemetry-mc-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-telemetry-mc-k8s-tests_istio

integ-pilot-multicluster-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-pilot-multicluster-tests_istio

integ-telemetry-istiodremote-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-telemetry-istiodremote-tests_istio

integ-pilot-istiodremote-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-pilot-istiodremote-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-operator-controller-tests_istio

unit-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-ipv6-k8s-tests_istio

integ-cni-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-cni-k8s-tests_istio

release-test_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test release-test_istio

gencheck_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test gencheck_istio

integ-security-multicluster-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-security-multicluster-tests_istio

lint_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test lint_istio

integ-security-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-security-k8s-tests_istio

integ-security-istiodremote-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-security-istiodremote-tests_istio

analyze-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test analyze-tests_istio

release-notes_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test release-notes_istio

integ-telemetry-mc-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-telemetry-mc-k8s-tests_istio

integ-pilot-multicluster-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-pilot-multicluster-tests_istio

integ-telemetry-istiodremote-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-telemetry-istiodremote-tests_istio

integ-pilot-istiodremote-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-pilot-istiodremote-tests_istio

integ-pilot-istiodremote-multicluster-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-pilot-istiodremote-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-operator-controller-tests_istio

unit-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-ipv6-k8s-tests_istio

integ-cni-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-cni-k8s-tests_istio

release-test_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test release-test_istio

gencheck_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test gencheck_istio

integ-security-multicluster-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-security-multicluster-tests_istio

lint_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test lint_istio

integ-security-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-security-k8s-tests_istio

integ-security-istiodremote-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-security-istiodremote-tests_istio

analyze-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test analyze-tests_istio

release-notes_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test release-notes_istio

integ-telemetry-mc-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-telemetry-mc-k8s-tests_istio

integ-pilot-multicluster-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-pilot-multicluster-tests_istio

integ-telemetry-istiodremote-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-telemetry-istiodremote-tests_istio

integ-pilot-istiodremote-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-pilot-istiodremote-tests_istio

integ-pilot-istiodremote-multicluster-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-pilot-istiodremote-multicluster-tests_istio

integ-helm-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-helm-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-operator-controller-tests_istio

unit-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-ipv6-k8s-tests_istio

integ-cni-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-cni-k8s-tests_istio

release-test_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test release-test_istio

gencheck_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test gencheck_istio

integ-security-multicluster-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-security-multicluster-tests_istio

lint_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test lint_istio

integ-security-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-security-k8s-tests_istio

integ-security-istiodremote-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-security-istiodremote-tests_istio

analyze-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test analyze-tests_istio

integ-telemetry-mc-k8s-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-telemetry-mc-k8s-tests_istio

integ-pilot-multicluster-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-pilot-multicluster-tests_istio

integ-telemetry-istiodremote-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-telemetry-istiodremote-tests_istio

integ-pilot-istiodremote-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-pilot-istiodremote-tests_istio

integ-pilot-istiodremote-multicluster-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-pilot-istiodremote-multicluster-tests_istio

integ-helm-tests_istio
cea21f45b3919b677dc52760f2c287755631a9f5
link
true
/test integ-helm-tests_istio

release-notes_istio
5f2f15316938569dc791fc8a9446422256c5a4ed
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
5f2f15316938569dc791fc8a9446422256c5a4ed
link
unknown
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

/test all

Still a few flakes: https://prow.istio.io/view/gs/istio-prow/pr-logs/pull/istio_istio/37112/unit-tests_istio/1488922988769185792. Need to look into it


Develop Endpoint to Fetch LLM Application Variant Parameters

Description
Implement an endpoint that lets users retrieve parameters for a specific LLM application variant. Users should be able to obtain parameters using either app_name/variant_name or app_name/environment.
Details
We currently have:
/api/app_variant/list_variants/

This provides parameters for all variants. To enhance user experience, we aim to introduce:
/api/app_variant/get_variant_parameters

The new endpoint will accept a payload in one of these structures:

{app_name: <name>, variant_name: <variant>}
{app_name: <name>, environment: <environment>}

Note: The approach to fetch parameters by app_name/environment to be implemented in issue #570.
Example
Request Payload:
{
  "app_name": "SampleApp",
  "variant_name": "VariantA"
}

Expected Response:
{
  "app_name": "SampleApp",
  "variant_name": "VariantA",
  "parameters": {...}
}

app_name/variant_name part is WIP

I'm gearing up to tackle app_name/environment and was wondering if the response for this should come back as a list, given that multiple variants within the same app could share an environment.
Additionally, after reading the comments on issue #583, I'm starting to question the return type for app_name/variant_name, which is already merged. It looks like a single variant within an app could exist across multiple environments, so should that also return a list?

@yeokyeong-yanolja

@mmabrouk I'm gearing up to tackle app_name/environment and was wondering if the response for this should come back as a list, given that multiple variants within the same app could share an environment.

I don't think multiple variant within the same app can share an environment. Each environment can have only one app variant deployed to it.

Additionally, after reading the comments on issue #583, I'm starting to question the return type for app_name/variant_name, which is already merged. It looks like a single variant within an app could exist across multiple environments, so should that also return a list?

That's a good point. I think however a better solution is not overload the endpoint and have instead two distinct logic.
Keep get_variant_by_name as it is:
POST app_variant/get_variant_by_name (from #583)
Payload
{
  "app_name": "SampleApp",
  "variant_name": "VariantA"
}
Response:
{
  "app_name": "SampleApp",
  "variant_name": "VariantA",
  "parameters": {...}
}

Add a new
POST environment/get_deployed_variant
Payload
{
  "app_name": "SampleApp",
  "environment_name": "Staging"
}
Response:
{
  "app_name": "SampleApp",
  "variant_name": "VariantA",
  "parameters": {...}
}

What do you think? Did I understand you comment correctly? Does my answer make sense or am I missing a detail?

Got it, thanks for the detailed explanation and examples!

I've created a pull request, but it's dependent on Suhyun's code. So, I've made the PR against Suhyun's repository. Could you please take a look?
Here's the link: https://github.com/kangsuhyun-yanolja/agenta/pull/1
@mmabrouk

Thanks for the PR @yeokyeong-yanolja
It reads all good!


Develop Training Approach

Document how to carry out the training.

10/3/22 - all documents reviewed and signed off by Cath. They are stored in: Migration Documentation.
Ticket moved to backlog as further versions may be required as the migration to Mauro progresses.

Will need to be reviewed for 2023 project.

Document updated for the next phase of Mauro and sent to Nick Richman on 6 March 2024 for sign off.


Support for creating annotated heatmaps with categorical axis

It would be nice if there's an easy way to plot heatmaps such as the one shown below

If there's an easy way to do it, please help.

Linking to a related stack overflow question/answer: http://stackoverflow.com/questions/31756636/how-to-plot-annotated-heatmap-on-plotly/31807387#31807387

@theengineear Thank you, for the quick response. I understand how it works now.


Updated package and fixed import alias

Fixes #278.
Hopefully this will work, there wasn't anything else for solving this since it is related to this issue

Closing as the new refactoring to use angular cli probably fixed it.


Add fused Lasso penalization to estimation of error models

Resolve #22

Codecov Report

Merging #23 (8353a43) into main (5ef29a1) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@          Coverage Diff          @@
##            main     #23   +/-   ##
=====================================
  Coverage   0.05%   0.05%
=====================================
  Files         16      16
  Lines       1883    1883
=====================================
  Hits           1       1
  Misses      1882    1882

Impacted Files
Coverage Δ

src/estim/estim.jl
0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


JSON (serialize) encoding for data exchanging

The idea is related to allocation issue we have when using witc-abi, and considering we may like to call a function from another instances, use universal encoding has it's benefit. This will combine the forward-call, but which will generated by witc to fit various length parameters.

related https://serde.rs/enum-representations.html

To complete this idea, first makes every single component in this system be the same, all of them provides two functions

allocate : usize -> addr
write: addr -> byte -> ⊥

In this sense, every time we generate a function call, e.g. foo : A -> B -> C will be
a <- # ...
sa <- toJSON a
addr_a <- allocate (length sa)
map (write addr_a) sa

# b same as a

# call
(addr_c, size_c) <- foo(addr_a, length sa, addr_b, length sb)
# addr_c is, since `foo` side call `allocate` and `write` of these instance
sc <- loadString addr_c size_c
c <- fromJSON sc

NOTE: there has many ways to improve write, but as a proof of concept, it's not important here


Switch rmm device_memory_resource to device_async_resource_ref

Switch the soon-to-be-removed rmm device_memory_resource to device_async_resource_ref.  However this PR does not update the resource adaptor, as that solution is not ready yet.

build

build

build

build

build

build

build

build


Add a PlutusIR symbolic-execution engine into Pirouette

Pirouette was built on the assumption that many Plutus contracts would be built with the StateMachine API. From our experience, this has not been the case. Plutus contracts are being built in very diverse formats. In order to have a chance at translating these diverse contracts into TLA+, we need a full-featured symbolic execution engine.
This PR is now a collection of all the children PRs that are needed to bring a symbolic execution engine into Pirouette. This is our progress so far:

[x] Symbolic Execution with SMT assistance of basic terms (no Higher-order, no polymorphism). (merged on: #52)

[ ] Add a sanityCheck predicate that captures the SMT translation assumptions and gets called every time a term is being translated when running pirouette in debug mode
[x] Create a simpler LanguageDef TestingLang and add more tests to pirouette, in particular, capture the specs of symbolic execution.

[x] Monomorphizing PlutusIR terms as a standalone transformation ( Merged on #54 )

[ ] Handle de Bruijn variables instead of hardcoding Var 1.

[ ] Defunctionalizing PlutusIR terms as a standalone transformation

[ ] Add a sanityCheck predicate to capture defunctionalizing assumptions.
[ ] Replace TLA+ defunctionalization by monomorphizing then defunctionalizing PlutusIR before translating to TLA+

[ ] Update the relevant readmes

Subsumed by #65


How to use federated credentials outside CLI and Powershell

We maintain Github action for Synapse. So far we've been using the SPN Secret to generate the bearer token from AAD using the REST API. The ask is to support federated credentials. Based on the documentation, it is recommended to use AzLogin Github action. However, how can this be used with a REST API? Our action uses REST API to deploy artifacts to Synapse instead of using powershell or CLI.
How can we use federated identity + AzLogin action to generate tokens which can be used in the REST API for AuthN and Authz?

Hi @lordozb, you can follow this guide to use azure/login with federated credentials.  After logging into Azure with azure/login, you can run azure-cli commands by azure/cli action to manage and operate Synapse Workspace by az synapse. If this doesn't meet your request, you can use the Azure REST API with Azure CLI by az rest. For just getting an access token by using Azure CLI or Azure PowerShell, use az account get-access-token with azure/cli or Get-AzAccessToken with azure/powershell.

Thanks for your response @MoChilia
The GitHub action that we maintain is written in typescript. Invoking multiple CLI calls within it to retrieve the token may cause a hit to the performance as that would cause it to start a new process and retrieve it. This is how we currently retrieve the token - https://github.com/Azure/Synapse-workspace-deployment/blob/b566de16bc88c95c22e9995287bdf8bfc81fdc4e/build_and_deploy/utils/service_principal_client_utils.ts#L14
We make a REST API call to AAD to get the token. Is there something similar that AzLogin internally does to get the token?

@lordozb, you can call AzureCliCredential().getToken() in your code to retrieve the token for the currently logged-in Azure CLI account.


database query for species distribution and orthologs

Hi Kim,
When you get change could you check and send me the list of anything which has a human ortholog annotated, but does not have
conserved in vertebrates		species_dist
I think I sometimes forget and add only
conserved in metazoa		species_dist
cheers
Val

There are 3477 pombe genes in Chado that have a human ortholog.  Sounds about right?
Only 4 don't have "conserved in vertebrates"
pbi2 | SPCC338.12
sol1 | SPBC30B4.04c
spr1 | SPBC19G7.04
etp1 | SPAC22E12.10c
Note to self, here's the query:
SELECT name, uniquename
FROM feature pombe_gene
WHERE pombe_gene.type_id =
    (SELECT cvterm_id FROM cvterm WHERE name = 'gene')
  AND organism_id = 1
  AND pombe_gene.feature_id IN
    (SELECT object_id FROM feature_relationship fr
     WHERE type_id IN
         (SELECT cvterm_id FROM cvterm WHERE name = 'orthologous_to')
       AND subject_id IN
         (SELECT feature_id FROM feature WHERE organism_id = 2))
  AND pombe_gene.feature_id NOT IN
    (SELECT feature_id FROM feature_cvterm fc JOIN cvterm t ON fc.cvterm_id = t.cvterm_id
         WHERE t.name = 'conserved in vertebrates');

yep 68.5 % to human
68.9% to metazoa (small number in C. elegans etc not detected in vertebrates).
still hoping get to 70% with those distant orthologs.....

etp1 | SPAC22E12.10c
is a weird one, its one of the tandem fusions. these will be resolved by
https://github.com/pombase/curation/issues/810

fixed


P3-Find a better way for including rank_llm in sys path.

Currently we add the following snippet to every script that we want to run both from a cloned repo and using package installation.
Ideally we should find a cleaner/simpler way
import sys
import os

SCRIPT_DIR = os.path.dirname(os.path.abspath(__file__))
parent = os.path.dirname(SCRIPT_DIR)
parent = os.path.dirname(parent)
sys.path.append(parent)

I can handle this with relative paths. Would that be preferred over the current snippet?

Relative or absolute path would be still the same, @wu-ming233 if you are interested in this problem. Try looking for solutions that don't require adding path at the beginning of every file that needs it.

By relative imports, I meant imports such as:
from ..retrieve.indices_dict import INDICES
from ..retrieve.topics_dict import TOPICS

as opposed to, say,
SCRIPT_DIR = os.path.dirname(os.path.abspath(__file__))
parent = os.path.dirname(SCRIPT_DIR)
parent = os.path.dirname(parent)
sys.path.append(parent)

from rank_llm.result import Result, ResultsWriter
from rank_llm.retrieve.indices_dict import INDICES
from rank_llm.retrieve.topics_dict import TOPICS

Do you think that will be preferred?

I feel relative imports are fine internally, this is what transformers does from what I remember.
What about generally relying more on init.py for conveniently importing modules besides this? @sahel-sh

"Remember that you should generally opt for absolute imports over relative ones, unless the path is complex and would make the statement too long" this is from real python: https://realpython.com/absolute-vs-relative-python-imports/#:~:text=With your new skills%2C you,make the statement too long.
@wu-ming233 In general I would like to keep the imports as absolute path. I will try a relative path in one of the demos. If the demo is still runnable both from a cloned repo and by importing rankllm after installing it as a package, I will let you know and you can update every thing script that does add to the path  explicitly?

If we were to use relative imports, one can call our scripts as modules, respecting the package structure, such as:
python -m rank_llm.demo.rerank_demo_docs.py

which would work if the user calls from the directory rank_llm/src.
I am still looking for ways that could handle imports more elegantly, but most of them don't seem to be as robust as just using the somewhat dirty sys.path.append. The most "pythonic" way so far is to use editable installs, though this would make it slightly feel like "development mode" even when the user just wants to run a demo. Let me know what you think!


Pg metatore test suite is flaky

Some tests using the same index ID run concurrently. Failed coverage job.

I think this was fixed by https://github.com/quickwit-oss/quickwit/pull/5340, feel free to re-open if not


IPTT: Pin/Excel buttons need styling

The Pin and Excel buttons look a little wonky.

[x] 1. Almost joined together but not quite.

[ ] 2. The Excel buttons use secondary style -- I'd expect primary. (See #346 for background and mockup.)
Pin button -- primary button

Excel button -- secondary buttons, even though they're not secondary to Pin

[ ] 3. Popovers are not docked to buttons, the way they are for the Pin button on Production. On Prod, if you readjust the window, the popover moves along with the button. But on QA, I get this:

This is a little mixed up with the IPTT work which is apparently not yet merged(?) but that's not Jennÿ’s  problem.

For the excel buttons, there is an established UI widget for this kind of thing, the dropdown button

Criterion 3 (popover placement) is a bigger issue. I notice this is no longer using the Bootstrap Popover  component (as it was on production.) It looks like the React widget has some layout issues. It also doesn't get our uniform styling.

@camgnostic what would it take to backport this into the BS popover?

Here's what I'm seeing:

@axoplasm Is this what you want to see -- in particular, the secondary gray color? It's okay by me, just want to check before marking this done.

Yes they should (still) be secondary buttons, but secondary buttons are now solid gray instead of outlined

Cool. Passed.


Move backend to server

AS IS: standalone app
TO BE: cloud server app
If user can't connect to server, there is should be a possibility to run it locally on PC
-[ ] #518

Done.


Modified docstrings & deleted test data

Modified docstrings of stat_summary.py function
deleted test data

`def daily_plot(data, campaign_id, start_date, end_date):
'''
Returns a time series chart that visualises daily performance of a campaign
in a period.

    Parameters
    ----------
        data : dataframe
            Dataframe containing information from google analytics
        campaign_id : int
            The unique id of the campaign.
        start_date : int
            The campaign start date.
        end_date : int
            The campaign end date.

    Returns
    ----------
        time-series plot: plot
            A plot that visualize data points of four metrics.
            Four metrics:
                    1. New to return rate
                    2. Conversion rate
                    3. Total transaction revenue
                    4. Average transaction revenue

'''`


Filters from Application.display should migrate to Data

Is your feature request related to a problem? Please describe.
Our current implementation to handle filtering arguments (--more, --before, --name, etc) is by filtering our copy of the data using if blocks to iteratively filter our data. This approach works, and it works well -- within Application.display. Those same arguments and filters are also desired in other modes. To repeat the code in each place would be an unnecessary burden and leave much more room for bugs & errors.
Describe the solution you'd like
The statements which actually perform the filtering can be made more general-purpose and broken down into individual members of Data. To do so, would allow us to re-use the same set of filtering logic throughout Application without repeating in each location.
I propose a set of filtering methods added in to Data that will accept a filter criteria and apply that filter onto the instance's copy of Data._data. Methods such as Data.amount_less_than, Data.date_before, and Date.new_equal are envisioned here. They can probably be made even more general purpose to handle any column, or set of criteria. That may not be a bad idea to prevent another refactor in the future and allow far greater extensibility.
Because we will be applying the filters to an internal copy of the data, we need to consider how we actually access pieces of that data from within Application. Data._data is not intended to be directly accessed and the changes proposed here may effect how methods such as Application.display work.
I would also like to update Arguments so that we do not need to re-create the same sets of sub-parsers, or arguments for each mode where we want to re-use the data filters we create. However, that is getting a bit out of scope and would best serve in it's own issue.
Describe alternatives you've considered
I have briefly considered the implementation above using two separate copies of the data. Data._data and Data._display_data. The latter being used when applying sort or filtering operations so that we can write back to disk without worry of losing data. This is not being further considered because I feel it would just create complexity where none is needed.
As long as any write operations follow the format: read, apply, write; there should be no issues with data loss. At least due to this, anyway. Plenty of other ways to watch out for!
Additional context
No additional context required at this time.

Quick Shower Thought: We can create a generic Data.filer_data(filters_to_apply) method, where filters_to_apply is a dictionary of the desired filters. The dictionary should use the filter action as the key, and the filter amount/search term as the value. Alternatively, we can use nested dictionaries to separate filter column from filter action/term. Something like below seems like a solid place to start.
filters_to_apply = {
    'amount': {
        'less_than': 2500,
        'more_than': 2000,
    },
    'date': {
        'equal_to': '2020-02-25',
        'before': '2020-02-10',
    },
}

This way, we can use one set of generic filters and filtering logic, and Application only creates the dictionary and sticks it in. We may be onto something! Those couple days break may have paid off!

Work on this issue has begun in the feature/data_filters branch. Not quite ready for a pull request, not by a long shot. Soon! :smile:
https://github.com/ncdulo/suppylement/tree/feature/data_filters


[MM-11959] Add closing back ticks and send that message if it has inline opening back ticks

Summary
On Ctrl + Enter, add closing back ticks and send that message if it has inline opening back ticks.

Note that I've submitted this on top of https://github.com/mattermost/mattermost-webapp/pull/1809 just to prevent merge conflict.  Will rebase after approval.
Ticket Link
Jira ticket: MM-11959
Checklist

[x] Ran make check-style to check for style errors (required for all pull requests)
[x] Ran make test to ensure unit and component tests passed
[x] Added or updated unit tests (required for all new features)

Thanks @lieut-data! This should be ready for review.  Note that I changed the behavior based on your comment since I believe it makes a lot of sense but I'll wait for Eric to confirm as well.
cc @esethna

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: https://i-0bdf59813758dcad5.test.spinmint.com
Test Admin Account: Username: sysadmin | Password: sysadmin
Test User Account: Username: user-1 | Password: user-1
Instance ID: i-0bdf59813758dcad5

Spinmint test server destroyed


[Gemini] open grad checkpoint when model building

The orange line indicates mem stats when using grad checkpoint
The blue line indicates  mem stats when using grad checkpoint


WindowsTerminal.exe and OpenConsole.exe aren't signed

Windows Terminal version (or Windows build number)
Windows Terminal version 1.6.10571.0
Other Software
No response
Steps to reproduce
Open Sysinternal Process Explorer, enable the "Verified Signer" column and see "(No signature was present in the subject)".
Expected Behavior
I would expect programs from Microsoft to be signed by Microsoft. All other programs from Microsoft installed on my machine are signed.
Actual Behavior
I saw "(No signature was present in the subject)" in Sysinternal Process Explorer's "Verified Signer" column for both WindowsTerminal.exe and OpenConsole.exe

Here's a screenshot from Process Explorer:

So, Terminal is distributed in a signed container, the msixbundle/individual msix archives. Packaged applications are signed as a single unit, and the signature is recorded as part of the app platform's package manager database. :smile:
You can verify the signature on the build artifacts on our Releases page.

So is it a bug in Process Explorer?

Hmmm, let's have Mark Russinovich's take on it? ;)

:smile:

In general, there are some things about packaged processes (or packaged applications in general) that don't play nicely with the established systems. I know that's not great... but this seems to be the case for every store-deployed signed app on my machine today. There's a signature file at the root of the package that attests to its contents, and a "block map" that is also signed that attests they haven't been tampered with!

(Properties dialog -- since I can't actually get Process Explorer to display anything for Verified Signer ☹; Anyway, no Digital Signatures page!)
However, this guy is here:

Indeed, all in good fun!

Hi @DHowett, I understand everything you wrote here.
However, windowsterminalshellext.dll also not signed, and the it is being blocked on my machine because of the missing digital signature.
When I'm casually browsing my file system using File Explorer I'm being prompted by an alert that ddlhost.exe wasn't able to access windowsterminalshellext.dll because it's content cannot be verified, and it's being blocked to prevent any malicious things.
Is this something I need to open an issue for?

@b-dasass two questions:

How did you install the Terminal? (from the store, from the Releases page, from winget, choco, scoop, etc)
What program is displaying the alert about the missing signature?

@zadjii-msft
It is installed from the store, and the alert is coming from Carbon Black.

I suspect that the "security" software you're using doesn't respect package signatures and will throw a warning for any packaged shell extension. :/

Packaged executables are signed, along with other files as required for deployment, but file signatures are stored in the package catalog, AppxMetadata\CodeIntegrity.cat (except for Windows system packages). Executables may also have embedded signatures, but those are not required when packaged, even for a verified publisher UAC elevation prompt.
Process Explorer currently only displays the package name (package full name*, not display name) for UWP processes, not all packaged processes, and does not use the package catalog. We will fix both issues in Process Explorer. Thanks!
In the meantime, try the following workaround with Sigcheck from PowerShell:
$ (ps WindowsTerminal).Path
C:\Program Files\WindowsApps\Microsoft.WindowsTerminal_1.15.3466.0_x64__8wekyb3d8bbwe\WindowsTerminal.exe

$ cd "C:\Program Files\WindowsApps\Microsoft.WindowsTerminalPreview_1.16.3464.0_x64__8wekyb3d8bbwe\"

$ sigcheck.exe -f .\AppxMetadata\CodeIntegrity.cat .\WindowsTerminal.exe

Sigcheck v2.90 - File version and signature viewer
Copyright (C) 2004-2022 Mark Russinovich
Sysinternals - www.sysinternals.com

C:\Program Files\WindowsApps\Microsoft.WindowsTerminalPreview_1.16.3464.0_x64__8wekyb3d8bbwe\WindowsTerminal.exe:
        Verified:       Signed
        Signing date:   10:03 2022-12-13
        Publisher:      Microsoft Corporation
        Company:        Microsoft Corporation
        Description:    WindowsTerminal.exe
        Product:        Windows Terminal
        Prod version:   1.16.221212004-preview
        File version:   1.16.2212.12004
        MachineType:    64-bit

* Example package full name: Microsoft.SysinternalsSuite_2<IP_ADDRESS>_x64__8wekyb3d8bbwe


ActiveField: Setting the id for an input field does not change the id for the validation js

I had a situation where I was using an ActiveForm instance for a batch input form and needed to change the fields to use custom ids. The initial javascript generated per input was as follows:
jQuery('#w0').yiiActiveForm([{
    "id": "vehicle-type_id",
    "name": "[]type_id",
    "container": ".field-vehicle-type_id",
    "input": "#vehicle-type_id",
    "validate": function(attribute, value, messages, deferred) {
        yii.validation.required(value, messages, {
            "message": "Type cannot be blank."
        });
        yii.validation.number(value, messages, {
            "pattern": /^\s*[+-]?\d+\s*$/,
            "message": "Type must be an integer.",
            "skipOnEmpty": 1
        });
    }
}, {

This resulted in all the type_id fields being validated together since the ids were the same.
On changing the code to include the id as follows:
$form->field($model, '[]type_id')->dropdown($items, ['id' => 'mycustomid']);

the validation javascript was unchanged.

I solved the problem but I am not sure my solution is without side effects.
I narrowed down the problem to the following parts:

$inputID in ActiveField::getClientOptions()  is generated using Html::getInputId(). I solved this by creating a custom function ActiveField::getInputId() that checked whether a custom id had been set and then replacing all the calls to Html::getInputId() with this function.

    protected function getInputId() {
        return (isset($this->inputOptions['id']) && $this->inputOptions['id'])
                ? $this->inputOptions['id']
                : Html::getInputId($this->model, $this->attribute);
    }

The inputOptions have to be set manually. I tried to add this to the field function but had to include the default class form-control e.g.

$form->field($model, 'type_id', ['inputOptions' => [
                'class' => 'form-control','id' => 'myCustomId'
        ])->dropdown($items, ['id' => 'mycustomid']);

I bypassed this by altering the ActiveField::dropDownList() to save the result of the merge of ActiveField::inputOptions and the $options passed into the function as ActiveField::inputOptions
public function dropDownList($items, $options = [])
    {
        $this->inputOptions = array_merge($this->inputOptions, $options);
        $this->adjustLabelFor($this->inputOptions);
        $this->parts['{input}'] = Html::activeDropDownList($this->model, $this->attribute, $items, $this->inputOptions);

        return $this;
    }

ActiveField::getClientOptions() was being called before the merging of ActiveField::inputOptions. I therefore moved the following code from ActiveField::begin() to ActiveField::end():

if ($this->form->enableClientScript) {
            $clientOptions = $this->getClientOptions();
            if (!empty($clientOptions)) {
                $this->form->attributes[] = $clientOptions;
            }
        }

When you set an ID yourself, you have to configure the selectors property of the field accordingly: http://www.yiiframework.com/doc-2.0/yii-widgets-activefield.html#$selectors-detail

@cebe I encountered another problem. When i use the following input
$form->field($model, '[]type_id', ['selectors' =>
    ['input' => '#mycustomid', 'container' => '.field-mycustomid']
])->dropdown($items, ['id' => 'mycustomid']);

the javascript produced is
jQuery('#w0').yiiActiveForm([{
    "id": "vehicle-type_id",
    "name": "[]type_id",
    "container": ".field-vehicle-type_id",
    "input": "#mycustomid",
    "validate": function(attribute, value, messages, deferred) {
        yii.validation.required(value, messages, {
            "message": "Type cannot be blank."
        });
        yii.validation.number(value, messages, {
            "pattern": /^\s*[+-]?\d+\s*$/,
            "message": "Type must be an integer.",
            "skipOnEmpty": 1
        });
    }
}, {

The problem is to do with the id being obtained using Html::getInputId(). I replaced both instances where it is called with a function that checked for the existence of selectors[input] first and used this if found.

Sorry for the many commits, was having issues syncing my master.

looks like you forgot to send a pull request, did that for you: https://github.com/yiisoft/yii2/pull/6810 is this correct?

I was waiting for some confirmation before I sent it.

@kanyuga discussion and feedback about code is always done in the pull request so you have to send it directly ;)

@kanyuga can you answer the questions in https://github.com/yiisoft/yii2/pull/6810#issuecomment-69374407 ?

Resolved by https://github.com/yiisoft/yii2/commit/13fca3bc54e22e9e89f9b86eeedbfb87a248d750


KOGITO-4666: Converge the CSS to avoid conflicts between PF3 and PF4

@tiagobento @manstis can you guys take a look?
@manstis
With these changes, I believe the only code that you'll need in your style.scss is:
.pf-c-button.pf-m-secondary {
  color: var(--pf-global--primary-color--100);
}

.pf-c-button.pf-m-primary {
  color: var(--pf-global--Color--light-100);
  background-color: var(--pf-global--primary-color--100);
}

We decided to remove the switch between themes for the shortcuts panel.
Now it is kept "light" regardless the VS Code theme.
The behavior for the loading screen is kept, though.
Could you guys take another look? I just pushed a new commit.
Thanks!

@caponetto LGTM (with the most recent commit).


Added "Field Constraints" examples

fixes #917

It adds "Field Constraints" examples without changing the specification itself

Thanks @peterdesmet!

Would be nice if we had the option for a side by side view of data and table schema.

Agree we need to try this; on the other hand we need to evaluate if it adds to much editing complexity to markdown (in my opinion the closer to bare markdown the better)


Investigate options around tutorials

We likely need a structured way to have tutorials through the docs part of the website. Base docsy is ok for this, but not always the easiest to read.
This could take the form of more interactive live examples using something like Katacoda (https://www.katacoda.com/), but I think a good starting point might be closer  to what Keptn uses ( based around the Google Code Lab Format: https://github.com/keptn/tutorials/tree/master/site/tutorials ). We can also look at just creating a couple of standard templates in docsy
We could target the local dev setup/introduction to k8s/helm/microservices as an early experiment for this.

I agree that docsy may not be best for tutorials.  Hard to navigate.  Don't know much about Google Code Lab Format.  Tekton added tutorials in the last 6 months.  Need to see how they structured it.

While we have not added this level of live examples, we added a simple POC to take someone through the basics.
https://docs.ortelius.io/guides/userguide/first-steps/2-intro-to-set-up/


Install script improvements

Ports some of the nice features of rocSOLVER's install script to hipSOLVER, including the cmake-arg argument and the ability to specify relative paths for custom rocBLAS and rocSOLVER locations.

The CI on hipSOLVER is cheap and it does at least run the install script.


More and better Image API

What problem does this solve or what need does it fill?
I've been trying to do some pre-processing on textures to implement better material handling in bevy_fbx. But a show stopper is the ability to mix/match and modify textures.
I need a better API to be able to do that.
What solution would you like?
A few API changes could help.

Create a wrapper type EditImage you could convert an Image into, that implement's the image crate's GenericImage trait.
implements methods on Image to convert into EditImage if the Image format supports it, there should be an infaliable EditImage::into_image(self).
I don't think much more is needed. I've been having issues with DDS on the bistro scene, but I think trying to do image modifications on compressed format is hopeless and inadvisable at runtime.
In the very long future, we could imagine a new asset pipeline that is capable of generating new assets based on intermediate processing steps in bevy, so that it's not necessary to do this at run time every time the game is loaded; furthermore, it would also not be needed to write special pre-processing code, it would be integrated into the asset loading pipeline, and a special option would output post-processed assets.

What alternative(s) have you considered?
It's possible to get the raw Vec<u8> from the Image, and try to figure out the proper DynamicImage from the texture descriptor, then build a DynamicImage, do the operations on it, finally rebuild the previous image from the descriptor.
It might sound hard, but it's actually much more annoying in practice :D

There is still some possible improvements such as more convertible format and direct implementation of the image crate's GenericImage trait for bevy's Image struct.


tpdnn.py has merge conflicts

see https://github.com/CSTR-Edinburgh/merlin/blob/de494eb1760b341c03b9f7c4514add055c8ac425/src/models/tpdnn.py#L181-L205

We're not really using this file anywhere in the pipeline -- may be we can exclude this.


wrap references to resources in static-ref's Ref/RefMut

to assert that they point to static data

@homunkulus r+

:pushpin: Commit a94de6b has been approved by japaric

:hourglass: Testing commit a94de6b with merge a94de6b...

:sunny: Test successful - status-travis
Approved by: japaric
Pushing a94de6bafcd95c0313e638138643f87c3b0e6aa0 to master...


Key "html" for sequence/mapping with keys "label, url" does not exist.

I've upgraded a site from Craft 4 to 5 and get this error when clicking on a saved submission in the CP:
Key "html" for sequence/mapping with keys "label, url" does not exist.
...in /vendor/craftcms/cms/src/templates/_layouts/components/crumbs.twig

Anyone else?

It looks like this extension's template at vendor/hybridinteractive/craft-contact-form-extensions/src/templates/submissions/_show.twig is expecting each submission to have a defined subject, but mine have none (the subject text comes from the Contact Form plugin instead). Adding a default in there fixes it:
https://github.com/hybridinteractive/craft-contact-form-extensions/blob/v5/src/templates/submissions/_show.twig#L13
{% if crumbs is not defined %}
    {% if submission %}
        {% set crumbs = [
            { label: craft.contactFormExtensions.name, url: url('contact-form-extensions') },
            { label: submission.subject ?? 'No subject', url: '' }
        ] %}

    {% else %}
        {% set crumbs = [
            { label: craft.contactFormExtensions.name, url: url('contact-form-extensions') }
        ] %}
    {% endif %}
{% endif %}


Add reprocessing filter that targets specific tenant

The backend now allows you to reprocess content for a specific tenant. It would be good to have this in the admin UI as well.
I'm not sure how much work it'd be, but it'd be cool if the filters were combinable as they are in the backend.
For example, say a tenant gets a new video processing thingie, it'd be cool if we could select the tenant in a dropdown and then select the appropriate mime types to reprocess for that tenant. That can be outscoped from this ticket though.

@sathomas : Looks like there is a merge conflict here

Merge de-conflicted. To @nicolaasmatthijs for review.


Add global styles to emails

Adding global style as a feature could be nice.
I was able to make it work by creating a new file /emails/styles.tsx
// styles.tsx
export const main = {
  backgroundColor: '#000',
};

// email.tsx
import { main } from './styles'

Issue with this method
styles.tsx shows up in preview. Workaround is to name the file components.tsx which is filtered from the list
I wasn't able to get it to work if I had the file in a subfolder. Could be nice to have a /styles/ folder and ability to have multiple template styles there.

Yup! Let's add it.


Can't publish app

Describe the bug
We can't publish our app
To Reproduce
Steps to reproduce the behavior:

Go to 'https://dashboard.stripe.com/apps/my-app'
No option to upload app publicly

Expected behavior
Have option to publish app
Screenshots

Desktop (please complete the following information):

OS: [macOS Monterey]
Browser [chrome]

Closing due to inactivity. Let us know if you are still blocked @rabinkarp!


Feature/tcomp 70 make apis for context value computations

I'd like some people from the Studio to try this implmentation and tell if it fits their requirements for context values.

I think it is a good idea which use "Value Evaluator" to handle context script in runtime.


chore: better loading tips ui

Preview

Features

Follow app theme settings
Dark & light style
Fluent UI style (same as vcc)

LGTM


captured functions have original seed injected

the following snippet:
from sacred import Experiment

ex = Experiment()

@ex.capture
def test(seed):
    print(seed)

@ex.automain
def main(_seed):
    test(_seed)
    test()

when run, generates:
$ python main.py with seed=42
WARNING - main - No observers have been added to this run
INFO - main - Running command 'main'
INFO - main - Started
767258318
42
INFO - main - Completed after 0:00:00

Is this intended behavior? I think it should at least give a warning about injecting the original seed instead of injecting _seed, it took me a while to understand why it was not reproducing due to both the missing parameter and the missing _ on the variable name.

Yes, seed and _seed are different. While seed is the original seed from the configuration, _seed is another value generated (deterministically) from that original seed. While seed is the same everywhere, _seed will be different every time the function is called. But it depends on the global seed and thus the experiment should still be reproducible.
The _seed and _rnd is a feature I went a bit overboard with. It is meant to support a function that should be called several times in an experiment and produce different random behavior everytime. But I wanted to make sure that it was still reproducible, and even better: that its randomness would only depend on  its own call history. So if you have this:
@ex.capture
def testA(_seed):
    print('A', _seed)

@ex.capture
def testB(_seed):
    print('B', _seed)

Then calling testA several times will give you different values even with a fixed seed:
>>> ./test_randomness.py with seed=42
A 904388214
A 36157956
B 767258318
B 951190362

And no matter how you re-arrange the calls of testA and testB you should get the same:
>>> ./test_randomness2.py with seed=42
B 767258318
A 904388214
B 951190362
A 36157956

This was done to keep an experiment as reproducible as possible even through code changes, since it localizes the effect of using the random-number generator. But as I said: I think I went a bit overboard with this. :-)

Oh, actually, I think it's a great feature... my main problem was that seed was being injected when I wasn't expecting it... is there a way to avoid some arguments from being injected?
@ex.capture(ignore=['seed'])
def func(seed):
  pass

func()
# TypeError: func() missing 1 required positional argument: 'seed'

Ah, I see. That makes sense. No there currently isn't. But it does seem like a useful feature, and should be quite easy to implement. Want to give it a try?

@Qwlouse sure, I've taken a look already, see my pull request... what do you think?


FR : Add setting to work only with party tokens

Hi, it seems that the module will look for all token that players have access to (owned, observer, limited) which can lead to scroll hell to select targets for a roll :

Adding a module setting to only show tokens from the active party would be nice.
Removing observed/limited token would also help, as well as only showing online players token.
Or showing only players token on the scene the GM is when he opens the roll UI.

I'll look into it. Hopefully should be simple enough.

In several places, replace
game.actors.filter(actor => actor.hasPlayerOwner && actor.type === "character");
with
game.actors.filter(actor => actor.hasPlayerOwner && actor.type === "character" && actor.parties.size);
(or game.actors.party.members.includes(actor) if you want to restrict it to only the currently active party)


✨ get_recurring_items

This PR implements the new API endpoint for recurring items: v1/recurring_items. It also deprecates v1/recurring_expenses

:tada: This PR is included in version 1.4.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket: