[FEATURE REQ] Enhance MockableTrafficManagerArmClient Usability for Unit Testing by Adding Setters to TrafficManagerRegion Properties

Library name
Azure.ResourceManager.DataFactory.Mocking
Please describe the feature.
When trying to write the unit test using 'MockableTrafficManagerArmClient.GetTrafficManagerGeographicHierarchyResource' method, and to get 'TrafficManagerGeographicHierarchyData' as the result (which is required in the method we need to test as a parameter) we ran into a dead end:

When mocking, the data is empty, but we need such a hierarchy object
We also can not create an instance of this object and give it customized values, because the missing setter in the list of 'TrafficManagerRegion'

Would there be a better way of approaching this issue? or could you add the setter?

Hey @chensy96 , thank you for reaching out to us, I guess your question is about Azure.ResourceMananger.TrafficManager.
For you question:

You need to fill in all data if you want to mock a class.
You meant this TrafficManagerGeoGraphicHierarchyData.TrafficManagerRegion ? It's not a collection. If a property is a collection, then there is no setter because you can use collection's add/update/delete methods to update the property, instead of assign a new collection.


[#3649] feat(client): remove log4j impl from client-java-runtime

What changes were proposed in this pull request?
remove log4j impl from client-java-runtime
Why are the changes needed?
Fix: #3649
Does this PR introduce any user-facing change?
no
How was this patch tested?
existing IT
local spark env

propose #3665 to fix conflict


Polyfill Instructions

I saw #135 and decided to try to help out. I based this on https://babeljs.io/docs/usage/polyfill/. Please let me know if there's any changes you would require.

The package hasn't been published yet.

It should mention the unpkg url for the polyfill on README section about using it without a build system.

@sstephenson when does that package will be published?

Yes please, could you tell us when it'll be published. I need it. :)

Workaround for the moment:

install

$ npm install core-js element-closest mutation-observer-inner-html-shim

usage

import "core-js/fn/array/find"
import "core-js/fn/array/find-index"
import "core-js/fn/array/from"
import "core-js/fn/map"
import "core-js/fn/object/assign"
import "core-js/fn/promise"
import "core-js/fn/set"
import "element-closest"
import "mutation-observer-inner-html-shim"


Fix blurred tab close icon on FF61

I don't know if this break something on previous FF versions.

Looks nice, thanks! This bug is in FF 59 too, but not FF 58. I'll merge this pull request tomorrow, because I'll be ending FF 58 support. Also your fix makes the whole button smaller - the button's border is too small.
Firefox 58:

Firefox 59+ with your fix:

But it's easy to fix, so that's okay.
.tab-close-button {
	padding: 2px;
	margin-left: 1px;
}

Oh, i don't noticed that padding xD thanks.
BTW,  i was thinking that we should add the --gnome-icons-hack-close-button-hover-bgimage and --gnome-icons-hack-close-button-hover-box-shadow variables to the themes, for better GTK look.

Merged your commits.
About those two new variables: if they are needed, then sure, we could add them. But are they needed? Everything looks fine to me on GNOME 3.18, I don't know about other versions.

This is FF close tab button on hover (looks flat):

And this is GTK+ app close tab button on hover (3.26):


Feature/ondoubleclicknode

Hi ! I have added the onDoubleClick feature as requested on issue #194. There is still a small bug that I couldn't fix: when double-clicking on a node, a zoom is triggered on the graph and I don't know how we could cancel it but it should be related to the d3-zoom library.
I've done my best to update the documentation, tell me if something is missing ! And it seems that some prettier script makes me change some of the README signs, I don't know how I could cancel it :'(
Have a good day !

I have disabled the double click zoom on the whole graph, I think it's the better (and only possible from what I know) way !

Hello,
I have received a message saying that this PR is becoming stale, do you want any more changes ? Everything works now and I have followed your advices :)
Have a good day !

Hey @IgorMacGregor thanks for noticing I will proceed with this soon :slightly_smiling_face:


Fix Template Specification API Auth Object formatting

Description:
In the SAM Template Specification (versions/2016-10-31.md) the paragraph about the API Auth Object is badly formatted.
Steps to reproduce the issue:

Go to the API Auth Object paragraph of versions/2016-10-31.md (AKA SAM Template Specification)

Observed result:
The YAML for the Authorizers section is badly formatted (because the ```yaml block is opened twice).
Expected result:
Better formatting.

I will submit a PR in a few minutes, addressing this issue.

Released!


Like operator does not work

Information

Version of Medoo: 2.1.11
Version of PHP: 8.2.9
Type of Database: Mysql 8
System: Linux

Describe the Problem
The like operator [~] does not work as expected.
Code Snippet
The detail code you are using that causes the problem:

##skipped medoo init code
$this->database->select("test_table", "*", [
    'field[~]' => 'abc%'
]);

Expected Behavior
the above code should generate and execute the sql "select * from test_table where field like 'abc%'"
Actual Behavior
An sql error  "SQLSTATE[HY093]: Invalid parameter number: parameter was not defined" occurred
The issue should be related to the fix 1a892c7 of #1109. It seems that the sql statement is not correctly parse by PDO when the parameter placeholder contains a "$".
The issue could be resolved by changing the ending "$" in the placeholder to a "L".
From
$likeClauses[] = $column . ($operator === '!~' ? ' NOT' : '') . " LIKE {$mapKey}L{$index}$";
$map["{$mapKey}L{$index}$"] = [$item, PDO::PARAM_STR];

to
$likeClauses[] = $column . ($operator === '!~' ? ' NOT' : '') . " LIKE {$mapKey}L{$index}L";
$map["{$mapKey}L{$index}L"] = [$item, PDO::PARAM_STR];

Fixed it on 1f035fd.


Unexpected peer dependency?

It seems like the latest version (0.14.0) introduced a new peer dependency.
I get this error when I try to load listr in a new project:
$ node -p "require('listr')"
/home/targos/test/node_modules/any-observable/register.js:29
		throw new Error('Cannot find any-observable implementation nor' +
		^

Error: Cannot find any-observable implementation nor global.Observable. You must install polyfill or call require("any-observable/register") with your preferred implementation, e.g. require("any-observable/register")('rxjs') on application load prior to any require("any-observable").
    at loadImplementation (/home/targos/test/node_modules/any-observable/register.js:29:9)
    at register (/home/targos/test/node_modules/any-observable/loader.js:32:18)
    at Object.<anonymous> (/home/targos/test/node_modules/any-observable/index.js:2:39)
    at Module._compile (internal/modules/cjs/loader.js:654:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:665:10)
    at Module.load (internal/modules/cjs/loader.js:566:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:506:12)
    at Function.Module._load (internal/modules/cjs/loader.js:498:3)
    at Module.require (internal/modules/cjs/loader.js:598:17)
    at require (internal/modules/cjs/helpers.js:11:18)

@targos Same here. Did you solve it?

@marcuspoehls no. I'm staying on v0.13.0 for now.

It's due to this bug in any-observable https://github.com/sindresorhus/any-observable/issues/18. Hope to get this fixed shortly after the weekend.

fix is out with sindresorhus/any-observable/releases/tag/v0.3.0

Same here on ^0.14.0

Still waiting on stream-to-observable. Use an 0.13 for now, sorry for the inconvenience. If it isn't merged at the beginning of next week, I'll fork the package so we can fix this.

Wow, great work Sam!
Thank you for keeping us updated and working on a fix yourself.
 Hope to get this fixed tomorrow.

<EMAIL_ADDRESS>is released and should fix this issue (hopefully).

Still getting this with 0.14.1. I'm using lint-staged (https://github.com/okonet/lint-staged/issues/416).
/Users/brunolemos/Projects/x/node_modules/@samverschueren/stream-to-observable/node_modules/any-observable/register.js:29
		throw new Error('Cannot find any-observable implementation nor' +
		^

Error: Cannot find any-observable implementation nor global.Observable. You must install polyfill or call require("any-observable/register") with your preferred implementation, e.g. require("any-observable/register")('rxjs') on application load prior to any require("any-observable").
    at loadImplementation (/Users/brunolemos/Projects/x/node_modules/@samverschueren/stream-to-observable/node_modules/any-observable/register.js:29:9)
    at /Users/brunolemos/Projects/x/node_modules/@samverschueren/stream-to-observable/node_modules/any-observable/loader.js:30:18
    at Object.<anonymous> (/Users/brunolemos/Projects/x/node_modules/@samverschueren/stream-to-observable/node_modules/any-observable/index.js:2:39)
    at Module._compile (module.js:652:30)
    at Object.Module._extensions..js (module.js:663:10)
    at Module.load (module.js:565:32)
    at tryModuleLoad (module.js:505:12)
    at Function.Module._load (module.js:497:3)
    at Module.require (module.js:596:17)
    at require (internal/module.js:11:18)

Fixed by deleting both node_modules and package-lock.json.

I'm also running into this problem with 0.14.1. And I cannot seem to get around it, despite wiping my caches and all the locks and node_modules and so on. So this is making lint-staged unusable for me on a certain project :(
Here are my relevant dependency versions:
└─┬<EMAIL_ADDRESS>    └─┬<EMAIL_ADDRESS>      └─┬<EMAIL_ADDRESS>        └──<EMAIL_ADDRESS>

Could lint-staged fix this by depending on zen-observable or rxjs itself?
I'm running into this after installing lint-staged with PNPM (see here).

<EMAIL_ADDRESS><EMAIL_ADDRESS>

Facing a similar issue with v0.14.3 and using rollup to bundle my project.
Error: Cannot find any-observable implementation nor global.Observable.

I ended up installing any-observable and polyfilling it with rollup-plugin-polyfill
{
	input: 'bin/cli.js',
	output: {
		file: 'dist/bundle.cjs.js',
		format: 'cjs',
		strict: false,
		banner: '#! /usr/bin/env node\n',
	},
	plugins: [
		...,
		polyfill(['any-observable/register/rxjs']),
		...
	]
}


Add ownership annotations to new and existing olm-managed secrets

As a part of certificates ownership work, all of new and existing secrets that are created with certificate information need to have ownership annotations. New secrets that are created with OLM certresources controller will have new ownership annotations injected at creation/update time. The existing olm-managed secrets that don't have the required annotations will get reconciled at startup when olm operator is restarted/redeployed. This PR only add OpenShift owning component annotation and the description annotation can be added later.
Signed-off-by: Vu Dinh<EMAIL_ADDRESS>

This contains non-upstreamed changes to the staging directory.
Because of that, it needs to be marked specially. I believe [carry] needs to be added to the git commit headline.

/test e2e-gcp-olm

@joelanford @tmshort Seeking for a LGTM here unless there are any further feedbacks.


Getting GATTC_OPEN event for interface that's already connected (IDFGH-2083)

Environment

Development Kit: ESP32-DevKitC
Kit version (for WroverKit/PicoKit/DevKitC): unknown
Module or chip used:  ESP32-SOLO-1
IDF version (run git describe --tags to find it):
// v3.3
Build System: CMake
Compiler version (run xtensa-esp32-elf-gcc --version to find it):
// xtensa-esp32-elf-gcc (crosstool-NG crosstool-ng-1.22.0-80-g6c4433a) 5.2.0
Operating System: macOS
Power Supply: USB

Problem Description
I have a program that's acting as a GATT client and connecting to up to 3 peripherals, as well as acting as a GATT server with 3 services (note: that adds up to 6 GATT "interfaces"). The program is constantly scanning and connecting to peripherals as they appear and maintaining long-lived connections to them.
We recently upgraded our ESP-IDF version from v3.2 to v3.3 and I believe the behavior I'm about to describe is new with the version upgrade.
Our normal flow for connection is:

Get a ESP_GAP_SEARCH_INQ_RES_EVT event from scanning.
Stop scanning (esp_ble_gap_stop_scanning).
Initiate connection using fi_gattc_open.
Get a ESP_GATTC_OPEN_EVT.
Re-start scanning.

The behavior I'm seeing is that I'm getting a GATTC_OPEN event for a GATT interface that is already connected to a peripheral. This causes my code to attempt to re-start scanning, but since this is outside of the normal flow I described above it turns out that my program is already scanning, and so the start scan command fails (BTM_BleScan scan already active) because we are already scanning.
I have a profile_tab structure (similar to the examples) that keeps track of the different GATT client interfaces and their associated current connection ID. The connection ID is set on GATTC_OPEN and cleared on GATTC_CLOSE.
The full logs demonstrating the issue are quite complex, but I wrote a task that prints out the current state of the profile_tab:
I (355328) GATTC: STATUS: App 0, if=3, conn_id=1
I (355328) GATTC: STATUS: App 1, if=4, conn_id=2
I (355328) GATTC: STATUS: App 2, if=5, conn_id=3
I (355808) GATTC: ESP_GATTC_OPEN_EVT, if=5, conn_id=1

What you see here is that according to my bookkeeping, interface 5 is associated with connection ID 3. However I get the GATTC_OPEN event for interface 5 connection ID 1. Weirdly, conn 1 is already associated with interface 3.
Expected Behavior
Don't receive a GATTC_OPEN event for an interface that's currently connected to a peripheral.
Actual Behavior
Receives a GATTC_OPEN event for an interface that's currently connected.
Steps to reproduce
Continuously scan for and connect to multiple peripherals.
Code to reproduce this issue
I don't have a minimal code repro but I could probably come up with one. This might be hard to reproduce locally unless you have multiple peripherals lying about.
Debug Logs

Hi, Sorry for the late reply. can you provide some code to reproduce this problem? I didn't find similar problems here. Thank you.

Any update on this, I got the similar issue

Hello @q7777777hk , Could you provide your code to help us to reproduce this issue? Thank you.

I can only provide the ESP32 side, my peripheral side use Nordic
gattc_multi_connect.zip
Below is my log
[ESP32 scan my peripheral 2]
I (18529) GATTC_MULTIPLE: Searched Device Name Len 20
I (18529) GATTC_MULTIPLE: ABCDE_BCEA73CACCDB
[my peripheral 1 finish communication and disconnect from ESP32, I don't know why everytime disconnect, I see below]
W (18529) BT_APPL: bta_gattc_conn_cback() - cif=3 connected=0 conn_id=3 reason=0x0013
W (18539) BT_APPL: bta_gattc_conn_cback() - cif=4 connected=0 conn_id=4 reason=0x0013
W (18549) BT_APPL: bta_gattc_conn_cback() - cif=5 connected=0 conn_id=5 reason=0x0013
W (18559) BT_APPL: bta_gattc_conn_cback() - cif=6 connected=0 conn_id=6 reason=0x0013
W (18569) BT_APPL: bta_gattc_conn_cback() - cif=7 connected=0 conn_id=7 reason=0x0013
W (18569) BT_APPL: bta_gattc_conn_cback() - cif=8 connected=0 conn_id=8 reason=0x0013
[ESP32 stop scan as already detected my peripheral 2, and call open]
I (18589) GATTC_MULTIPLE: esp_ble_gap_stop_scanning()
I (18589) GATTC_MULTIPLE: esp_ble_gattc_open()
[my peripheral 1 disconnection event]
I (18589) GATTC_MULTIPLE: Profile Event : 41
I (18599) GATTC_MULTIPLE: device 0 disconnect (conn_id 0, gattc_if 3/3)
I (18609) GATTC_MULTIPLE: Profile Event : 5
I (18649) GATTC_MULTIPLE: Gap Event : 18
I (18649) GATTC_MULTIPLE: Stop scan successfully
[ESP_GATTC_CONNECT_EVT event to my peripheral 2]
I (18669) GATTC_MULTIPLE: Profile Event : 40
[ESP_GATTC_OPEN_EVT event to my peripheral 2]
I (18669) GATTC_MULTIPLE: Profile Event : 2
I (18679) GATTC_MULTIPLE: >> connect device ok app_id 1
I (18689) GATTC_MULTIPLE: ESP_GATTC_OPEN_EVT conn_id 0, if 4, status 0, mtu 23
I (18689) GATTC_MULTIPLE: REMOTE BDA:
I (18699) GATTC_MULTIPLE: db cc ca 73 ea bc <==
[ESP_GATTC_CFG_MTU_EVT event to my peripheral 2]
I (19129) GATTC_MULTIPLE: Profile Event : 18
I (19129) GATTC_MULTIPLE: Status 0, MTU 200, conn_id 0
I (19129) GATTC_MULTIPLE: esp_ble_gattc_search_service()
[ESP_GATTC_SEARCH_RES_EVT event to my peripheral 2]
I (19139) GATTC_MULTIPLE: Profile Event : 7
I (19149) GATTC_MULTIPLE: SEARCH RES: conn_id = 0 is primary service 1
I (19149) GATTC_MULTIPLE: start handle 11 end handle 65535 current handle value 11
I (19159) GATTC_MULTIPLE: UUID128: 9e ca dc 24 e e5 a9 e0 93 f3 a3 b5 1 0 40 6e
[ESP_GATTC_SEARCH_CMPL_EVT event to my peripheral 2]
I (19169) GATTC_MULTIPLE: Profile Event : 6
I (19179) GATTC_MULTIPLE: esp_ble_gattc_get_attr_count (H:11 to 65535)
I (19179) GATTC_MULTIPLE: esp_ble_gattc_get_char_by_uuid 1 (P:28 H:13)
I (19189) GATTC_MULTIPLE: esp_ble_gattc_register_for_notify() ....
[ESP_GATTC_REG_FOR_NOTIFY_EVT event to my peripheral 2]
I (19199) GATTC_MULTIPLE: Profile Event : 38
I (19199) GATTC_MULTIPLE: esp_ble_gattc_get_attr_count() 1 ....
I (19209) GATTC_MULTIPLE: esp_ble_gattc_get_descr_by_char_handle() 1 2 ....
I (19219) GATTC_MULTIPLE: esp_ble_gattc_write_char_descr() ....
[ESP_GATTC_WRITE_DESCR_EVT event to my peripheral 2, ESP32 will write AE 03 to peripheral when connected at this stage]
I (19249) GATTC_MULTIPLE: Profile Event : 9
I (19249) GATTC_MULTIPLE: write descr success 1
I (19249) GATTC_MULTIPLE: write_char_data_connected 1
I (19259) GATTC_MULTIPLE: esp_ble_gattc_write_char() .... write_char_data_connected 1
I (19269) GATTC_MULTIPLE: ae 03
[This is the problem part : ESP_GATTC_OPEN_EVT event to my peripheral 2, again !?]
I (19299) GATTC_MULTIPLE: Profile Event : 2
I (19299) GATTC_MULTIPLE: >> connect device ok app_id 0
I (19299) GATTC_MULTIPLE: ESP_GATTC_OPEN_EVT conn_id 0, if 3, status 0, mtu 200
I (19309) GATTC_MULTIPLE: REMOTE BDA:
I (19309) GATTC_MULTIPLE: db cc ca 73 ea bc <==
[ESP_GATTC_NOTIFY_EVT to peripheral 2. In normal situation after ESP32 sent AE 03 to peripheral 2, peripheral will reply  ea 03 ef 2f 00 01 00 3f to ESP32. However this responses to above strange connection, and from the log here, even this connection is correct, I have not send anything at this stage to peripheral. Is  this a ghost event from previous disconnected peripheral 1]
I (19319) GATTC_MULTIPLE: Profile Event : 10
I (19329) GATTC_MULTIPLE: ESP_GATTC_NOTIFY_EVT, Receive notify value: (device 0 conn_id 0, gattc
_if 3/3)
I (19339) GATTC_MULTIPLE: ea 03 ef 2f 00 01 00 3f
I (19339) GATTC_MULTIPLE: write_char_data_ack 0
[ESP_GATTC_NOTIFY_EVT to peripheral 2. After ESP32 sent AE 03 to peripheral 2, peripheral will reply  ea 03 ef 2f 00 01 00 3f to ESP32. And ESP32 will reply AA to the peripheral]
I (19349) GATTC_MULTIPLE: Profile Event : 10
I (19349) GATTC_MULTIPLE: ESP_GATTC_NOTIFY_EVT, Receive notify value: (device 1 conn_id 0, gattc
_if 4/4)
I (19359) GATTC_MULTIPLE: ea 03 ef 2f 00 01 00 3f
I (19369) GATTC_MULTIPLE: write_char_data_ack 1
I (19369) GATTC_MULTIPLE: esp_ble_gattc_write_char() .... write_char_data_ack 1
I (19379) GATTC_MULTIPLE: aa
[ESP_GATTC_WRITE_CHAR_EVT to peripheral 2 to confirm AA is sent]
I (19379) GATTC_MULTIPLE: Profile Event : 4
I (19389) GATTC_MULTIPLE: write char success 1
[In normal case, peripheral 2 will disconnect at this moment. And scan will be trigger again]
E (19399) BT_BTM: BTM_BleScan scan already active
W (19399) BT_APPL:  bta_dm_ble_scan start scan failed. status=0x6
I (19409) GATTC_MULTIPLE: Gap Event : 7
I (19409) GATTC_MULTIPLE: Scan start success
[Instead of seeing disconnection, I see below HEAP corrupt. Mayybe it connect twice as above and always cause below]
CORRUPT HEAP: multi_heap.c:477 detected at 0x3ffdce0c
abort() was called at PC 0x40092b0d on core 0
0x40092b0d: multi_heap_assert at C:/work/Boiler/msys32/opt/esp/esp-idf/components/heap/multi_hea
p.c:380
(inlined by) multi_heap_free_impl at C:/work/Boiler/msys32/opt/esp/esp-idf/components/heap/mult
i_heap.c:477
ELF file SHA256: 847dee8695a0ed50425e553e0cc967e444cff9c96a45596a255f7dc29f76435f
Backtrace: 0x4008dd7c:0x3ffdaa70 0x4008dfc9:0x3ffdaa90 0x40092b0d:0x3ffdaab0 0x40082976:0x3ffdaa
d0 0x40082e21:0x3ffdaaf0 0x4000bec7:0x3ffdab10 0x4011d026:0x3ffdab30 0x4011d29a:0x3ffdab60 0x401
1b71e:0x3ffdaba0 0x4011b9ae:0x3ffdabc0 0x40122ef7:0x3ffdabe0 0x40113f48:0x3ffdac20 0x40114176:0x
3ffdac40 0x4009125d:0x3ffdac70
0x4008dd7c: invoke_abort at C:/work/Boiler/msys32/opt/esp/esp-idf/components/esp32/panic.c:715
0x4008dfc9: abort at C:/work/Boiler/msys32/opt/esp/esp-idf/components/esp32/panic.c:715
0x40092b0d: multi_heap_assert at C:/work/Boiler/msys32/opt/esp/esp-idf/components/heap/multi_hea
p.c:380
(inlined by) multi_heap_free_impl at C:/work/Boiler/msys32/opt/esp/esp-idf/components/heap/mult
i_heap.c:477

My SDK is v3.3-202-gefdddbb25-dirty

For peripheral 1, the disconnection is 0x13, code 0x13 is connection terminate by peer user. So I don't know what's happened with the peer device.
For the next problem, I checked your code. And you shouldn't set readyForNextScan = true; when got ESP_GAP_BLE_SCAN_STOP_COMPLETE_EVT . You should enable the next scan when one connection has been connected, such as after ESP_GATTC_SEARCH_CMPL_EVT event. And another problem is you should only call esp_ble_gap_set_scan_params one time, rather than call it on every ESP_GATTC_REG_EVT.

Hi GYC
Thanks for your quick reply

You should only call esp_ble_gap_set_scan_params one time, rather than call it on every ESP_GATTC_REG_EVT

I will modify and do the test again

You should enable the next scan when one connection has been connected

From my above log, scan stop during my peripheral 2's connection and data communication. And before scan resume, peripheral 2 has another ESP_GATTC_OPEN_EVT (but no ESP_GATTC_CONNECT_EVT). Is there any idea on this ?

Hello, about another ESP_GATTC_OPEN_EVT, I test two devices to be the server, the one is our esp32, the other one is my smartphone, which has two different actions. The esp32 stop adv after connection established, but the smartphone still advertising. And your code will try to connect the devices every times when a device advertising the name "ABCDE_". So my esp32 connect and only open once, and the smartphone tries to open many times. I don't know how the peer device work, so please try to check if it has the same behavior as my smartphone. And maybe you need to change your code.

Thanks for your information
Can I ask one more question, how to make esp_ble_gap_start_scanning() scan forever ?
I only want it to stop scanning when I call esp_ble_gap_stop_scanning()

@q7777777hk Did you change number of max simultaneous BLE connections in menuconfig?
By default it is 3. You need to change 2 settings:
CONFIG_BT_ACL_CONNECTIONS:
Maximum BT/BLE connection count

and
CONFIG_BTDM_CONTROLLER_BLE_MAX_CONN:
BLE maximum connections of bluetooth controller.
Each connection uses 1KB static DRAM whenever the BT controller is enabled

Its just guessing, but i think this is what you have here:

[ESP_GATTC_NOTIFY_EVT to peripheral 2. In normal situation after ESP32 sent AE 03 to peripheral 2, peripheral will reply ea 03 ef 2f 00 01 00 3f to ESP32. However this responses to above strange connection, and from the log here, even this connection is correct, I have not send anything at this stage to peripheral. Is this a ghost event from previous disconnected peripheral 1]

https://docs.espressif.com/projects/esp-idf/en/latest/api-reference/bluetooth/esp_gattc.html#_CPPv419esp_ble_gattc_close13esp_gatt_if_t8uint16_t

Close the virtual connection to the GATT server. gattc may have multiple virtual GATT server connections when multiple app_id registered, this API only close one virtual GATT server connection. if there exist other virtual GATT server connections, it does not disconnect the physical connection. if you want to disconnect the physical connection directly, you can use esp_ble_gap_disconnect(esp_bd_addr_t remote_device).

Which means you can have bug in your app that is opening new virtual connection to device you already are connected and:

[Instead of seeing disconnection, I see below HEAP corrupt. Mayybe it connect twice as above and always cause below]
CORRUPT HEAP: multi_heap.c:477 detected at 0x3ffdce0c

another bug in your app or bug in esp-idf.

@q7777777hk Did you change number of max simultaneous BLE connections in menuconfig?
By default it is 3. You need to change 2 settings:
CONFIG_BT_ACL_CONNECTIONS:
Maximum BT/BLE connection count

and
CONFIG_BTDM_CONTROLLER_BLE_MAX_CONN:
BLE maximum connections of bluetooth controller.
Each connection uses 1KB static DRAM whenever the BT controller is enabled

I am assuming you have the same issue:
I (355328) GATTC: STATUS: App 0, if=3, conn_id=1
I (355328) GATTC: STATUS: App 1, if=4, conn_id=2
I (355328) GATTC: STATUS: App 2, if=5, conn_id=3
I (355808) GATTC: ESP_GATTC_OPEN_EVT, if=5, conn_id=1

or you just hijacked issue.
PS to scan forever use scan time = 0

CONFIG_BT_ACL_CONNECTIONS=7
But I cannot find CONFIG_BTDM_CONTROLLER_BLE_MAX_CONN in my sdkconfig (my sdk is 3.3)
My situation is like
I (789) GATTC_MULTIPLE: Reg app ok, app_id 0000, status 0, gattc_if 3
I (789) GATTC_MULTIPLE: Reg app ok, app_id 0001, status 0, gattc_if 4
I (809) GATTC_MULTIPLE: Reg app ok, app_id 0002, status 0, gattc_if 5
I (829) GATTC_MULTIPLE: Reg app ok, app_id 0003, status 0, gattc_if 6
I (839) GATTC_MULTIPLE: Reg app ok, app_id 0004, status 0, gattc_if 7
I (859) GATTC_MULTIPLE: Reg app ok, app_id 0005, status 0, gattc_if 8
a device connect to
I (18689) GATTC_MULTIPLE: ESP_GATTC_OPEN_EVT conn_id 0, app_id 1, if 4, status 0, mtu 23
I (18689) GATTC_MULTIPLE: REMOTE BDA: db cc ca 73 ea bc
but it connect again before above is disconnected (my scan is already disabled when above connection starts)
I (19299) GATTC_MULTIPLE: ESP_GATTC_OPEN_EVT conn_id 0, app_id 0, if 3, status 0, mtu 200
I (19309) GATTC_MULTIPLE: REMOTE BDA: db cc ca 73 ea bc
I am studying you 2nd reply, thanks

2 more questions

How can I tell if ESP32 is scanning ? Is there any API like IsScanning() ?
We want to save the power by increasing the connection interval, what is the max connection interval that ESP32 can support (as master to connect 6 slaves at the same time) ?

Not have that API, the scan time is set by the function esp_ble_gap_start_scanning(uint32_t duration),  the param "duration" is the keeping scanning time. But if you don't open the duplicate scan, you can get the scan result event every time when scanning an adv. That means the scan is still working.
The max interval of connection is 0x0C80, you can find related comments in our source code.

@wcauchois @q7777777hk Thanks for reporting, will close due to short of feedback, feel free to reopen with more details. Thanks.


feat: add controllino

add controllino hotspot as per #127
Issue

Link:
Summary:

How

Screenshots

References

Checklist

[ ] Tests added
[ ] Cleaned up commit history (rebase!)
[ ] Documentation added
[ ] Thought about variable and method names

Left as draft as I haven't sussed all the hardware functionality in #127
might need help from @MuratUrsavas


Error when running the Script.

🐛 Summary
Hello,
Thank you for the script saving me a lot of time looking thru our environment.
I have the proper roles assigned and Auditing is turned on under security and compliance.
When I run the script I'm getting errors under these sections.
VERBOSE: Searching for 'Set domain authentication' and 'Set federation settings on domain' operations in the UAL.
The property 'Count' cannot be found on this object. Verify that the property exists.
At C:\Users\xxxxxx\Documents\Ps_scripts\solarwindsv1.ps1:331 char:13

    If ($UALInput.Count -eq 5000)

        ~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : NotSpecified: (:) [], PropertyNotFoundException
FullyQualifiedErrorId : PropertyNotFoundStrict

VERBOSE: Searching for 'Update application' and 'Update application ? Certificates and secrets management' in the UAL.
The property 'Organization' cannot be found on this object. Verify that the property exists.
At C:\Users\xxxxx\Documents\Ps_scripts\solarwindsv1.ps1:339 char:17

            $DataProps = [ordered]@{

            ~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : NotSpecified: (:) [], PropertyNotFoundException
FullyQualifiedErrorId : PropertyNotFoundStrict

The variable '$DataProps' cannot be retrieved because it has not been set.
At C:\Users\xxxxx\Documents\Ps_scripts\solarwindsv1.ps1:366 char:68

...         $DataObj = New-Object -TypeName PSObject -Property $DataProps

VERBOSE: Searching for 'Update service principal' and 'Add service principal credentials' in the UAL.
The property 'Organization' cannot be found on this object. Verify that the property exists.
At C:\Users\xxxxx\Documents\Ps_scripts\solarwindsv1.ps1:339 char:17

            $DataProps = [ordered]@{

            ~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : NotSpecified: (:) [], PropertyNotFoundException
FullyQualifiedErrorId : PropertyNotFoundStrict

The variable '$DataProps' cannot be retrieved because it has not been set.
At C:\Users\xxxxx\Documents\Ps_scripts\solarwindsv1.ps1:366 char:68

...         $DataObj = New-Object -TypeName PSObject -Property $DataProps

VERBOSE: Searching for 'Add OAuth2PermissionGrant' and 'Consent to application' in the UAL.
The property 'Organization' cannot be found on this object. Verify that the property exists.
At C:\Users\xxxxx\Documents\Ps_scripts\solarwindsv1.ps1:339 char:17

            $DataProps = [ordered]@{

            ~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : NotSpecified: (:) [], PropertyNotFoundException
FullyQualifiedErrorId : PropertyNotFoundStrict

The variable '$DataProps' cannot be retrieved because it has not been set.
At C:\Users\xxxxx\Documents\Ps_scripts\solarwindsv1.ps1:366 char:68

...         $DataObj = New-Object -TypeName PSObject -Property $DataProps

VERBOSE: Searching for PowerShell logins using known PS application ids in the UAL.
The property 'Organization' cannot be found on this object. Verify that the property exists.
At C:\Users\xxxxx\Documents\Ps_scripts\solarwindsv1.ps1:339 char:17

            $DataProps = [ordered]@{

            ~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : NotSpecified: (:) [], PropertyNotFoundException
FullyQualifiedErrorId : PropertyNotFoundStrict

The variable '$DataProps' cannot be retrieved because it has not been set.
At C:\Users\xxxxx\Documents\Ps_scripts\solarwindsv1.ps1:366 char:68

...         $DataObj = New-Object -TypeName PSObject -Property $DataProps

It creates 3 CSV files and the rest of the CSV files have zero bytes.

Which 3 CSVs are being created?

Which 3 CSVs are being created?

PSMailbox_Operations_Export.csv
ApplicationGraphPermissions.csv
Domain_List.csv

PSMailbox_Operations_Export.csv
ApplicationGraphPermissions.csv
Domain_List.csv

Interesting. The traceback makes it appear that the Search-UnifiedAuditLog cmdlet is not returning any data.
Can you try connecting to exchange online using powershell, then running:
[datetime] $StartDate = [DateTime]::UtcNow.AddYears(-1).AddMinutes(10)
[datetime] $EndDate = [DateTime]::UtcNow

$PSLoginData1 = Search-UnifiedAuditLog -StartDate $StartDate -EndDate $EndDate -ResultSize 5000  -FreeText "a0c73c16-a7e3-4564-9a95-2bdf47383716"

$PSLoginData1

and see if any data is returned?
If no data is returned it could be indicative of a permissions issue and you will want to verify all permissions listed in the README.md are present.

Interesting. The traceback makes it appear that the Search-UnifiedAuditLog cmdlet is not returning any data.
Can you try connecting to exchange online using powershell, then running:
[datetime] $StartDate = [DateTime]::UtcNow.AddYears(-1).AddMinutes(10)
[datetime] $EndDate = [DateTime]::UtcNow

$PSLoginData1 = Search-UnifiedAuditLog -StartDate $StartDate -EndDate $EndDate -ResultSize 5000  -FreeText "a0c73c16-a7e3-4564-9a95-2bdf47383716"

$PSLoginData1

and see if any data is returned?
If no data is returned it could be indicative of a permissions issue and you will want to verify all permissions listed in the README.md are present.

Interesting. The traceback makes it appear that the Search-UnifiedAuditLog cmdlet is not returning any data.
Can you try connecting to exchange online using powershell, then running:
[datetime] $StartDate = [DateTime]::UtcNow.AddYears(-1).AddMinutes(10)
[datetime] $EndDate = [DateTime]::UtcNow

$PSLoginData1 = Search-UnifiedAuditLog -StartDate $StartDate -EndDate $EndDate -ResultSize 5000  -FreeText "a0c73c16-a7e3-4564-9a95-2bdf47383716"

$PSLoginData1

and see if any data is returned?
If no data is returned it could be indicative of a permissions issue and you will want to verify all permissions listed in the README.md are present.

You should be able to connect to exchange online with the cmdlet Connect-ExchangeOnline

Interesting. The traceback makes it appear that the Search-UnifiedAuditLog cmdlet is not returning any data.
Can you try connecting to exchange online using powershell, then running:
[datetime] $StartDate = [DateTime]::UtcNow.AddYears(-1).AddMinutes(10)
[datetime] $EndDate = [DateTime]::UtcNow

$PSLoginData1 = Search-UnifiedAuditLog -StartDate $StartDate -EndDate $EndDate -ResultSize 5000  -FreeText "a0c73c16-a7e3-4564-9a95-2bdf47383716"

$PSLoginData1

and see if any data is returned?
If no data is returned it could be indicative of a permissions issue and you will want to verify all permissions listed in the README.md are present.

You should be able to connect to exchange online with the cmdlet Connect-ExchangeOnline

I'm getting data returned. I'm getting user log entries back from 5/20 to the present.

I'm getting data returned. I'm getting user log entries back from 5/20 to the present.

Can you try running this command (connecting to exchange online with cmdlet Connect-ExchangeOnline):
[datetime] $StartDate = [DateTime]::UtcNow.AddYears(-1).AddMinutes(10)
[datetime] $EndDate = [DateTime]::UtcNow

$testData = Search-UnifiedAuditLog -StartDate $StartDate -EndDate $EndDate -ResultSize 5000

$testData

This will give a more generic output of the data in your environment. If data returns, that's a good first step to rule out permission issues.  If it returns data, please let us know how far back it was able to get.
After running the above command, please try running this one:
[datetime] $StartDate = [DateTime]::UtcNow.AddYears(-1).AddMinutes(10)
[datetime] $EndDate = [DateTime]::UtcNow

$ConsentData = Search-UnifiedAuditLog -StartDate $StartDate -EndDate $EndDate -RecordType AzureActiveDirectory -Operations "Add OAuth2PermissionGrant","Consent to application" -ResultSize 5000

$ConsentData

Does this return data?
You can also run the other queries like this as well if you wanted to check all the operations manually.

Can you try running this command (connecting to exchange online with cmdlet Connect-ExchangeOnline):
[datetime] $StartDate = [DateTime]::UtcNow.AddYears(-1).AddMinutes(10)
[datetime] $EndDate = [DateTime]::UtcNow

$testData = Search-UnifiedAuditLog -StartDate $StartDate -EndDate $EndDate -ResultSize 5000

$testData

This will give a more generic output of the data in your environment. If data returns, that's a good first step to rule out permission issues.  If it returns data, please let us know how far back it was able to get.
After running the above command, please try running this one:
[datetime] $StartDate = [DateTime]::UtcNow.AddYears(-1).AddMinutes(10)
[datetime] $EndDate = [DateTime]::UtcNow

$ConsentData = Search-UnifiedAuditLog -StartDate $StartDate -EndDate $EndDate -RecordType AzureActiveDirectory -Operations "Add OAuth2PermissionGrant","Consent to application" -ResultSize 5000

$ConsentData

Does this return data?
You can also run the other queries like this as well if you wanted to check all the operations manually.

I just went old school and rebooted the server and started the PS script over and it's working now. I now have CSV files all filled out.
Thank you for your time and Tshooting.

I just went old school and rebooted the server and started the PS script over and it's working now. I now have CSV files all filled out.
Thank you for your time and Tshooting.


dep2nix: remove

Description of changes
part of: https://github.com/NixOS/nixpkgs/issues/318069
5 years without updates on a leaf package

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

oops, duplicate


Route helpers generating wrong path

Hi,
Route helpers are generating paths to assets with params instead of the expected path.

Debugging I get the same result:
[1, 10] in /audits1984/app/views/audits1984/sessions/_session.html.erb
    1: <%= link_to session_path(session) do %>
    2:   <% debugger %>
=>  3:

    4:

    5:       <%= format_date session.created_at %>
    6:

    7:

    8:

    9:

   10:           <%= session.reason %>

session_path(session)
"/console/assets?action=show&controller=audits1984%2Fsessions&id=1"

When I copy the routes into my routes instead of mounting the engine it generates the correct routes:
- mount Audits1984::Engine => "/console"
+ namespace :audits1984, path: "console" do
+   resources :sessions, only: %i[index show] do
+     resources :audits, only: %i[create update]
+   end
+
+   resource :filtered_sessions, only: %i[update]
+
+   root to: "sessions#index"
+ end

I have other engines mounted in my router like:

Sidekiq::Web
JasmineRails::Engine
LetterOpenerWeb::Engine
GraphiQL::Rails::Engine

All of them are working perfectly
Using:
rails: 7.0.4
ruby: 3.2.0 (mri)
pg: 1.4.5
audits1984: 0.1.2
console1984: 0.1.26

Continuing with the Path helpers errors.
When solving the first issue by copying the routes in the router instead of mounting.
In the controllers scope sessions_path is returning "/sessions" without the namespace, should be: "/console/sessions"
[36, 45] in /audits1984/app/controllers/audits1984/audits_controller.rb
   36:         else
   37:           sessions_path
   38:         end
   39:
   40:         debugger
   41:
=> 42:         redirect_to next_path, notice: "Session<EMAIL_ADDRESS>was<EMAIL_ADDRESS>   43:       end
   44:   end
   45: end
(byebug) next_path
=> "/sessions"

In the view:
[1, 10] in /audits1984/app/views/audits1984/sessions/_session.html.erb
    1: <%= link_to session_path(session) do %>
    2:

    3:    <% debugger %>
=>  4:

    5:       <%= format_date session.created_at %>
    6:

    7:

    8:

    9:

   10:           <%= session.reason %>
(byebug) sessions_path
"/console/sessions"

@arturictus was experiencing the same issue and came across https://github.com/rails/rails/issues/34452
I realized that we were including Rails.application.routes.url_helpers in our main app.
removing this resolves the issue.
adding include Audits1984::Engine.routes.url_helpers to Audits1984::ApplicationHelper also resolves the issue.
Haven't spend any more time diagnosing this but might as well make a note of this if someone elses encounters this issue

@jorgemanrubia how do you handle the audit routes in an application like Basecamp that has account ID middleware? Does it always require an account ID in the route but then it doesn't matter which account it is as long as the user is an admin? I have a similar setup and I'm getting UrlGenerationErrors in a before_action callback in the base controller for redirecting if there's no current user, saying it can't find the sign in route with the given controller and action parameters even though it's resolving the path helper (and it works everywhere else in the app, just not when a controller from this engine is the one inheriting from the base controller).


Change our xaml controls resources version to version 2

Summary of the Pull Request
Change our controls resources version to version 2
PR Checklist

[ ] Closes #xxx
[x] CLA signed. If not, go over here and sign the CLA
[ ] Tests added/passed
[ ] Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
[ ] Schema updated.
[x] I work here

[ ] How are we lanning on dealing with the numerous TabView quirks in v2? Just ship it as-is and fix in post? Or manually adjust the styling now?

[ ] EX the close button hover is weirdly wide
[ ] the tab text is bold

[ ] Icons throughout the app are still on the Segoe MDL2, not Segoe Fluent
[x] Tab color picker looks fine
[x] Tab renamer looks fine (if maybe needs a little padding...)
[x] Window Renamer / ID toast looks fine
[ ] About looks... Fine? The links aren't underlined anymore, but that might just be how WinUI works these days
[ ] InfoBars look totally insane transparent

How does it look overall? Should we merge and test in post?

Should we merge and test in post?

I like this idea, the visual issues we've found so far have been fixed getting it in will help us find more (if any) faster

renamed the PR!

[ ]  How are we lanning on dealing with the numerous TabView quirks in v2? Just ship it as-is and fix in post? Or manually adjust the styling now?

[ ]  EX the close button hover is weirdly wide
[ ]  the tab text is bold

Ship, file, fix. :)


Release Google.Cloud.Optimization.V1 version 1.0.0-beta01

Changes in this release:
Initial release.

Created release for Google.Cloud.Optimization.V1-1.0.0-beta01


Dynamic image loading/updating via ImageAPI

This is a large PR that does a number of things:

It adds "layer1" image management via the ImageAP
It squashes several bugs in the StateMutationEngine
It improves the module API to provide SetValue(s) capabilities, helping modules not squash each other
It adds the "/Busy" node state which can indicate that control of the node no longer belongs to us
It fixes some ServiceManager bugs that got tickled when the service manager got a lot of simultaneous requests
We generally disallow powering off while the node is in busy or sync states.
...and probably a bunch of other tweaks and fixes.

This PR alsoe resolves #195


Minimize waiting time

Is your feature request related to a problem? Please describe
I my problem case, waiting for the client is not allowed. When a vehicle arrives at a location it must start immediately, and then the TW violiations must be minimized.
Describe the solution you'd like
I want to add a minimization of the waiting time to the objective of the problem. Therefore, i think i need to adjust the CostEvaluator class and add a term for waiting time and also add a penalty for waiting time in the penalty manager. I adjusted the files accordingly, but how can i implement them into the model when i am using python to use pyvrp?
Describe alternatives you have considered
I can also add a constraint that waiting time is not allowed but i do not know how i should do this.
Additional context

Hi @PFonteijn!

Therefore, i think i need to adjust the CostEvaluator class and add a term for waiting time and also add a penalty for waiting time in the penalty manager.

That sounds reasonable, yes. For completeness, you may also want to update the feasibility checks inside the Route and Solution classes to test for wait time.

I adjusted the files accordingly, but how can i implement them into the model when i am using python to use pyvrp?

I am not sure if I understand the question. Did you recompile your local version of PyVRP and use that? If you've updated the cost evaluator (and possibly also the PenaltyManager on the Python side), I think things should already work?


docs(bartholomew/quickstart): misc updates/fixes

Updates/fixes a few items on the Bartholomew Quickstart page
Closes https://github.com/fermyon/developer/issues/539
Pre-Merge Content Checklist
This documentation has been checked to ensure that:

[ ] The title, template, and date` are all set
[ ] Does this PR have a new menu item (anywhere in templates/*.hbs files) that points to a document .md that is set to publish in the future? If so please only publish the .md and .hbs changes in real-time (otherwise there will be a menu item pointing to a .md file that does not exist)
[x] File does not use CRLF, but uses plain LF (hint: use cat -ve <filename> | grep '^M' | wc -l and expect 0 as a result)
[x] Has passed bart check
[x] Has run npm run build-index
[x] Has been manually tested by running in Spin/Bartholomew (hint: use PREVIEW_MODE=1 and run npm run styles to update styling)
[ ] Headings are using Title Case
[ ] Code blocks have the programming language set to properly highlight syntax and the proper copy directive
[x] Have tested with npm run test and resolved all errors

@vdice some overlap here with #541 I think?

Oh definitely, thank you @itowlson.  Sorry @tpmccallum, had missed your PR.  Closing this in favor of https://github.com/fermyon/developer/pull/541.


It's not working

Traceback (most recent call last):
File "gui.pyw", line 206, in
File "gui.pyw", line 29, in init
File "gui.pyw", line 81, in create_window
File "utils.py", line 210, in update_window
File "utils.py", line 177, in language
File "utils.py", line 173, in get_language
StopIteration

Traceback (most recent call last): File "gui.pyw", line 206, in File "gui.pyw", line 29, in init File "gui.pyw", line 81, in create_window File "utils.py", line 210, in update_window File "utils.py", line 177, in language File "utils.py", line 173, in get_language StopIteration

Did you follow the new installation instructions and install python and do the install requirements command?

Nuthing working add me on discord to help me username is icewolf56

Traceback (most recent call last): File "gui.pyw", line 206, in File "gui.pyw", line 29, in init File "gui.pyw", line 81, in create_window File "utils.py", line 210, in update_window File "utils.py", line 177, in language File "utils.py", line 173, in get_language StopIteration

did u even try the source code or just give up when the exe failed

Nuthing working add me on discord to help me username is icewolf56

Did you try the source code w/ the installation instructions?

hi, I have the same problem. unlike the other guy I have tried the source code which doesn't run at all ;(

hi, I have the same problem. unlike the other guy I have tried the source code which doesn't run at all ;(

What version of python are you running?

3.12.4

3.12.4

Try 3.11.8

same issue

same issue

Trying version 3.11.8?

same issue

We had another person with same error and was able to fix it. Asking that person now if they can tell me what they did to fix it as this doesnt occur with many ppl.

Traceback (most recent call last): File "gui.pyw", line 381, in File "gui.pyw", line 134, in init File "gui.pyw", line 237, in create_window File "utils.py", line 236, in update_window File "utils.py", line 193, in language File "utils.py", line 189, in get_language StopIteration
How to fix this pls help me guys

Try running the bot directly via python if you know how.

hi, I have the same problem. unlike the other guy I have tried the source code which doesn't run at all ;(

Have you done this?
If you have -
You need to install the dependencies.
go to Python and type "pip install -r requirements.txt" while in the source code folder.


Sidebar draft

@viktor-yakubiv Don't pay much attention to design. It's ugly. There haven't been applied many css styles. It's mostly for making subpages working. Also, I copied & pasted the icon component from Reader. I believe we will migrate to design package soon.

@viktor-yakubiv thanks for the review. 🙂


Camera Transformation Question

@una-dinosauria Thanks for putting this out! Regarding the camera transformations, when the transformation is applied, the subject "leans" up to 500mm from head to foot (see pictures below for before and after). I've checked across different actions, subjects, and frames and this lean seems to be in every datapoint. Is there an explanation for this lean?
Is the virtual frontfacing camera tilted or is the camera transformation code somehow doing this?
Why aren't the camera transformation matrices simply translations around the room and rotations about the z axis (which would keep subjects upright)?
The 3d view of the subject.

Untransformed top view. Notice the feet are reasonably under the body.

Transformed top view. Notice how the feet are swept out forward. The axes are x and z because transformation seems to rotate the subject 90 degrees.

Hi @RobertEng!

Regarding the camera transformations, when the transformation is applied, the subject "leans" up to 500mm from head to foot

Thanks for pointing this out, I had not noticed this before. Full disclosure: (1) this is perhaps a question better suited for the creators of the Human3.6M dataset -- we are simply borrowing their data as is, and (2) I have not myself worked on camera calibration before.

Is the virtual frontfacing camera tilted or is the camera transformation code somehow doing this?

By "camera transformation code", do you mean this?
https://github.com/una-dinosauria/3d-pose-baseline/blob/f4606662ba4017dd1963147b44ce32dd5fb0c004/src/cameras.py#L55-L72
If so, the camera transformation code is doing nothing but applying the camera's rotation and translation, so this is about the parameters of the transformation, not the code itself.

Why aren't the camera transformation matrices simply translations around the room and rotations about the z axis (which would keep subjects upright)?

The ultimate goal of these transformations is to project the 3d subject into a camera plane. Perhaps the representation that you mention would be more intuitive if we only cared about world->camera transformations in 3d, but wouldn't work so well for camera projections? (my best guess :S)
I'm sorry I don't have a better answer for you.

Hi @una-dinosauria, thanks for helping me out!
I think I've made a sufficient hack to prevent any lean. I ended up changing the rotation matrix to prevent any rotation which isn't about the z axis.

Cool! I guess you set a couple of columns or R to zero? How is that working for the 2d projections though?

Hi @una-dinosauria!
I ended up converting R to Euler angles and taking only the angle rotating about the z axis, and converting that back to a rotation matrix. In retrospect, I realize this is probably the same as setting columns 0.
After doing this rotation, the 2d projections look great and there is no lean anymore. Thanks for the help!

Hi @una-dinosauria!
I ended up converting R to Euler angles and taking only the angle rotating about the z axis, and converting that back to a rotation matrix. In retrospect, I realize this is probably the same as setting columns 0.
After doing this rotation, the 2d projections look great and there is no lean anymore. Thanks for the help!

Hi @RobertEng and @una-dinosauria ,
I also noticed the "leaning" of the poses and would like to do the same adaptations as RobertEng did. Where precisely should I make the changes? Do I make the changes that you described in the  world_to_camera_frame(P, R, T) function (set columns of R to 0) and retrain the model?
Thank you in advance!
Cheers,
Tim


new tests and notebook example for new generation metrics

Putting a pause on this PR for now, will come back to this later


Challenge is not passing even having the right code.

Challenge Override All Other Styles by using Important has an issue.
User Agent is: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.103 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

Hello World!

We are supposed to override all styles by pink-text class style using important key word.
I have given the important keyword, still getting this error:
Your pink-text class declaration should have the !important keyword to override all other declarations.
what to do?

Has any solution been found here? I'm currently having the same issue.

Hi finch145,
Remove the margin line : "margin-left: 10px;"
And it will work. There is some conditional mismatch in the regular expression used for evaluation of this challenge.
Thanks,
Mausam

Hi,
Thanks a mill 😃
On 9 Jul 2016 21:57, "Mausam"<EMAIL_ADDRESS>wrote:

Hi finch145,
Remove the margin line : "margin-left: 10px;"
And it will work. There is some conditional mismatch in the regular
expression used for evaluation of this challenge.
Thanks,
Mausam
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/FreeCodeCamp/FreeCodeCamp/issues/9455#issuecomment-231555441,
or mute the thread
https://github.com/notifications/unsubscribe/AQbJEu2GsGZot5GHblTZSc0UynI5vm_sks5qUAtFgaJpZM4JBms4
.


added print statements, to test report on pull request

Codecov Report

Merging #1 (4ef6aad) into main (57c0efd) will increase coverage by 10.60%.
The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.
@@             Coverage Diff             @@
##             main       #1       +/-   ##
===========================================
+ Coverage   72.72%   83.33%   +10.60%
===========================================
  Files           1        1
  Lines          11       18        +7
===========================================
+ Hits            8       15        +7
  Misses          2        2
  Partials        1        1

Files Changed
Coverage Δ

calculator.go
83.33% <100.00%> (+10.60%)
:arrow_up:


⚠ Bofrost.es has degraded performance

In 0524e3d, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1524 ms

Resolved: Bofrost.es performance has improved in 9ac9590 after 6 minutes.


stack_themes and new @StackedApp

I used to use:
  @lazySingleton
  ThemeService get themeService => ThemeService.getInstance();  //https://www.filledstacks.com/post/multiple-themes-in-flutter-dark-and-light-theme-flutter-stacked/

before the new @StackApp version of Stacked.  The below doesn't work
@StackedApp(
  routes: [
    MaterialRoute(page: HomeView, initial: true),
  ],
  dependencies: [
    LazySingleton(classType: NavigationService),
    LazySingleton(classType: ThemeService),
  ],
)
class AppSetup {
  /** Serves no purpose besides having an annotation attached to it */
}

as I get a null anytime I use
  final ThemeService _themeService = locator<ThemeService>();

Am I missing something or is this an issue?

Mmmmm, I'd have to add an option to register a function to call instead of constructing the service myself. I'll look into that.

You can now pass in
    LazySingleton(
      classType: ThemeService,
      resolveUsing: ThemeService.getInstance,
    )

The same for Singleton and pass it the static function to use for resolving. This is available in v1.9.7 and generator v0.2.6

Could this be added inside the documentation of stacked_themes?
The documentation mentions locator.registerSingleton(() => ThemeService.getInstance()); to register the service.
https://pub.dev/packages/stacked_themes

I've added the tag. It'll be added as we comb through and add docs for the new release.


Corruption eye

Closes #74

Yeah it was just a sketch so that I knew it was working

I'm getting ready to merge and updating the change log - please @me if any other changes are pushed.


Try OS X

Investigate if we can help with #19

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@msarahan the first issue we hit with OS X is,
Error: Found multiple instances of qca: ['lib/qca.framework/qca', 'QGIS.app/Contents/Frameworks/qca.framework/Versions/2.1.3/qca', 'lib/qca.framework/Versions/2.1.3/qca', 'QGIS.app/Contents/Frameworks/qca.framework/qca']

full log: https://api.travis-ci.org/jobs/261634960/log.txt?deansi=true
PS: here is the link we used to get some info for the builds https://github.com/qgis/QGIS/blob/master/INSTALL

Thanks @ocefpaf.  I'll try to take a look later today.  Seems like we'll have to force it to one of the options.


Fixed issue 145

see #145

The fix looks good. I can't reproduce anymore.
The circles still overlap however, see below:

@Ish-rivera should I create a ticket for the overlapping?


content and style changes

https://dsdmoj.atlassian.net/browse/AP-1040

changed bulleted list to numbered list
added third item to list ('keep it on file')
changed feedback sentence and made it inset text

In your editor you should be able to see the file at app/views/providers/saml_idp/idp/saml_post.html.erb. You can just delete it from there. Then just commit again and push.


[Bug]: fix method getPersistedThemesForApplication

Is there an existing issue for this?

[X] I have searched the existing issues

SubTasks
No response

This bug is a duplicate of https://github.com/appsmithorg/appsmith/issues/21331
Hence closing it.


Demos: Add warning stating that WebGL2 is required if it's not available

Lets wait until someone complains


Resource api for subnet and vpc

Hey @narayansharma91 do we need to update the resource list : https://github.com/cloudmatos/matos-gcp-provider/blob/master/src/matos_gcp_provider/config.py#L192
with new resource type?


Test pull request.

This is a test pull request that will have test failures.

Test Failure:

Test Failure:
Chrome_58_0_3029_(Linux_0_0_0).Mp4vttParser Mp4vttParser parses init segment Failed
  Failed: Something failed
      at Object.<anonymous> (test/media/mp4_vtt_parser_unit.js:59:5)

Chrome_58_0_3029_(Linux_0_0_0).Mp4vttParser Mp4vttParser parses media segment Failed
  Failed: Something failed
      at Object.<anonymous> (test/media/mp4_vtt_parser_unit.js:59:5)

Chrome_58_0_3029_(Linux_0_0_0).Mp4vttParser Mp4vttParser parses media segment containing settings Failed
  Failed: Something failed
      at Object.<anonymous> (test/media/mp4_vtt_parser_unit.js:59:5)

Chrome_58_0_3029_(Linux_0_0_0).Mp4vttParser Mp4vttParser accounts for offset Failed
  Failed: Something failed
      at Object.<anonymous> (test/media/mp4_vtt_parser_unit.js:59:5)

Chrome_58_0_3029_(Linux_0_0_0).Mp4vttParser Mp4vttParser rejects init segment with no vtt Failed
  Failed: Something failed
      at Object.<anonymous> (test/media/mp4_vtt_parser_unit.js:59:5)

Failed 5 tests, passed 0, skipped 1173


chicken: 4.13.0 -> 5.0.0

Motivation for this change
WIP because:

this is a major breaking update.  is it worth keeping both versions, as with python 2/3?

no other packages in nixpkgs depend on it
build-support/fetchegg and egg2nix had to change for chicken-5, so the changes wouldn't be contained to one directory

chicken 4 and 5 now coexist

it still needs more testing

I had to update egg2nix for chicken-5, so it's currently fetching my fork until I hear back from upstream

This should be fine as-is for now: https://github.com/the-kenny/egg2nix/pull/3
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

I ended up letting chicken 4 and 5 coexist, so I've removed WIP.  5 is still the default for the top level packages though.

Can you try to eliminate the duplication of package declarations? Similar to python2/3. I'd think only the compilers should differ between 4 and 5, while packages generally can stay compatible with both versions.


DB passwords can be accidentally leaked through logs

Disclaimer: I'm reporting this problem here because there are no public policies on how to report security problems. I would have preferred doing this privately.
Environment
Knex version: 2.4.2
Database + version: MySQL, PostgreSQL, MSSQL (I didn't test with others. DB version does not have any effect)
OS: Mac OS X, Linux
Bug

Explain what kind of behaviour you are getting and how you think it should do:
const query = knex('myTable').select('*');
logger.debug({ query }) // passwords are leaked here

// For a more realistic case:
try {
  const result = await query
  return result
} catch (err) {
  logger.error({ err, query }, 'Unknown Error while performing query') // passwords are leaked here
}

The previous code should not leak passwords through the logs, but it does 😢 .
In our case, the logger was Pino, this problem doesn't necessarily happen with other loggers (as they might use different
serialisation methods).

Error message: There is no error message

Reduced test code:
// This new test could be placed in `test/integration2/query/misc/additional.spec.js`
it('should not leak passwords when logged', async function () {
   const util = require('util')
   const query = knex('test_table_two').select('*');
   const fakeLog = util.inspect(query, { depth: null });
   const passwordMatches = fakeLog.match(
     /(knextest|testpassword|S0meVeryHardPassword|testrootpassword)/g
   );

   expect(passwordMatches).to.be.null;
});

I'd like to share a parameter that might help resolve this issue:
https://knexjs.org/guide/#compilesqlonerror

Released in 2.5.0


6 list persistance

Here is a design overview:

Instead of directly storing a List, I've abstracted that into a class called ListModel, which can be directly put into an isar database.
Isar database work is abstracted into a static class called ListsDatabaseManager.

Some design questions/concerns:

At the current moment, the list model (and its items) are loaded "eagerly", so all the lists and their items are loaded at the start. Should the items and list model's metadata (such as the name of the list model) be loaded separately? Do you think an "eager" loading would seriously slow down the app?
All updates are eager (I couldn't find any way to schedule updates to happen at the termination of the app), so a slight change leads to the whole list model being re-put into the database. Would this slow down the app noticeably?
Are there any sloppy names that need to be fixed (like ListsDatabaseManager)?

Here is a design overview:

Instead of directly storing a List, I've abstracted that into a class called ListModel, which can be directly put into an isar database.
Isar database work is abstracted into a static class called ListsDatabaseManager.

Some design questions/concerns:

At the current moment, the list model (and its items) are loaded "eagerly", so all the lists and their items are loaded at the start. Should the items and list model's metadata (such as the name of the list model) be loaded separately? Do you think an "eager" loading would seriously slow down the app?
All updates are eager (I couldn't find any way to schedule updates to happen at the termination of the app), so a slight change leads to the whole list model being re-put into the database. Would this slow down the app noticeably?
Are there any sloppy names that need to be fixed (like ListsDatabaseManager)?

I think the current "eager" system should be fine for now. We can optimize later if we need. For ListsDatabaseManager, why not call it just DatabaseManager or DbManager?


metric: add toxicity and bias

toxicity and bias both endpoint support for the SDK

@shotu can you take a look. Should i add custom three lables for toxicity like in the bias.
"Not toxic"
"Toxic"
"Severly Toxic"

vboxuser@shivam:~/Desktop/backend/inspeq-py-sdk$ python3 test.py
{"metric_name": "TOXICITY_EVALUATION", "actual_value": 0.001000117976218462, "actual_value_type": "FLOAT", "metric_labels": ["custom_label_1"], "others": {}, "threshold": ["Pass"], "threshold_score": 0.5}


Download contract classes for predeployed ERC20 tokens when in forking mode

Usage related changes
closing #587
closing #591
Detect class hash and contract class for ETH, STRK ERC20 contracts when in forking mode.
Minting is refactored to transfer funds from chargeable account.
Changed logic when downloading contract class from origin network.
Checklist:

[ ] Checked out the contribution guidelines
[ ] Applied formatting - ./scripts/format.sh
[ ] No linter errors - ./scripts/clippy_check.sh
[ ] No unused dependencies - ./scripts/check_unused_deps.sh
[ ] No spelling errors - ./scripts/check_spelling.sh
[ ] Performed code self-review
[ ] Rebased to the latest commit of the target branch (or merged it into my branch)

Once you make the PR reviewable, please avoid force-pushing

[ ] Updated the docs if needed - ./website/README.md
[ ] Linked the issues resolvable by this PR - linking info
[ ] Updated the tests if needed; all passing - execution info

Do we need to expand anything in docs here? https://0xspaceshard.github.io/starknet-devnet-rs/docs/next/predeployed


Long cannot be used as array

public function randText(int length = 10)
{
   int i;
   var characters,
         charactersLength,
         randomString = "";
   let characters = "23345233405343234352335536837633839432034334";
   let  charactersLength = strlen(characters);
   for i in range(0, length) {
      let randomString .= characters[rand(0, charactersLength - 1)];
   }

   return randomString;
}

@zhiephie
string characters = "23345233405343234352335536837633839432034334";
var idx, charactersLength, randomString;

let charactersLength = characters->length();
let idx = rand(0, charactersLength - 1);

// ...

let randomString .= characters[(int) idx];

Thanks for replay @sergeyklay, but error message : Operator 'concat-assign' is not supported for variable type: unchar

https://github.com/phalcon/cphalcon/blob/master/phalcon/security/random.zep#L187-L206

Ahay, Thanks @sergeyklay, work, I change type randomString to string.


modify-document-comments duplicate word

just curiosity, is it handled by script?
If you really want to contribute for community, please help us to scan the whole repo, thanks. Please aggregate them. :)

@fuweid   I  have scan the whole repo  by misspell  tool . There are no word-spelling  And I  have checked  the repeat word by script. According to my lesion,no similar problems  have been found.   If I expand my lexicon and find similar problems, I will pl . Thank you !!!


Add status and type filters on task lists endpoints.

Summary
Add filtering capabilities to the tasks endpoints to facilitate the management of an instance and its indexes, or a specific index.
This first iteration adds filters on the status and type attributes of the task API resource.
Summary Key Points

Add filtering capabilities on type and status for GET task lists endpoints.

Motivation
Following the specification aiming to stabilize the task API resource, we want to give users the capability to refine the lists of task according to several criteria to find precise information more quickly.

Closed in favor of https://github.com/meilisearch/specifications/pull/116


Add support for setting number of follow-up questions

Fixes https://github.com/vanna-ai/vanna/issues/315.
Changes:

[x] Added support to set number of follow-up questions to be generated by the LLM
[x] Updated documentations to include the sql and n_questions variables

@zainhoda Any thoughts regarding this PR?


Wrong behavior when ≥2 tables in blockquote (>)

Hi, when writing tables in blockquote, they will join and repetitive display.
Here is test image, left: reading mode; right: source mode.

The test text:
>| | |
>| ---- | ---- |
>| TEST | 1 |
>
>| | |
>| ---- | ---- |
>| TEST | 2 |

I have tested in sandbox vault. My Sheets Extended Plugin version is 1.2.5，Obsidian Current and Installer version are v1.5.3，Default Theme.
Thanks.

Should be fixed by deafc15

@NicoNekoru
The reason for this issue is that when the table is in blockquote >, the lineStart and lineEnd are not those of the table, but of the entire block.
Therefore, if .findIndex() is used to search, and if > is a callout, it will find the head of the callout, which is the line >[!note] for example.
As a result, textContent.slice(0, endIndex + 1) will cut off all tables, causing them not to display.
Additionally, if there are two or more tables in >, .findIndex() will always find the position of the first table, causing all tables to render as the first one.

(Sheets Extended Plugin version is 1.2.10, Obsidian Current and Installer versions are v1.5.12)
Sorry I am not a programmer. I know where the problem is but don’t know how to fix it.


Add WARNING test result

ADR-0008 defines five different test result status types -- SUCCESS, FAILURE, WARNING, SKIPPED and ERROR. There was no policy defined for handling the WARNING result type.
Signed-off-by: arewm<EMAIL_ADDRESS>

Nice!
Also need an update here: https://github.com/hacbs-contract/ec-policies/blob/2caee697f6254dea112182d3e779ea2be9ecaeb6/data/rule_data.yml

Also needs the change in rule_data.yml that @lcarva mentioned.

Disregard, I see it's done already.


Error: $compile:nonassign Non-Assignable Expression when adding filter

Hi,
I want filter all the calendar events using the types
Matt Lewis gave me the following code but I get an error when implementing it.
Code : events="vm.events | filter: {type: 'success'}"
My code : <mwl-calendar
events="vm.events | filter: event.type"
view="vm.calendarView"
view-title="vm.calendarTitle"
Error:
Error: $compile:nonassign
Non-Assignable Expression
Expression 'vm.events | filter: event.type' used with directive 'mwlCalendar' is non-assignable
https://docs.angularjs.org/error/$compile/nonassign?p0=vm.events | filter: event.type&p1=mwlCalendar\
Please help

Maybe just do the filter in the controller instead with something like:
vm.updateEvents = function(eventType) {
  vm.events = vm.allEvents.filter(function(event) {
    return event.type === eventType;
  });
};

Hi Matt,
I did and it those filter but only the first element type in the events and when I try filter or search for other types I get the following error.
Code
Filter method (controller):
$scope.$watch('type', function() {
$scope.filteredEvents = $filter("filter")($scope.events,{type: $scope.type},false);
});
Html:
events="filteredEvents"
view="calendarView"
.............................................
.............................................
Error :
TypeError: Cannot redefine property: $id
at Function.defineProperty (native)
at http://localhost:63342/app/lib/angular-bootstrap-calendar/dist/js/angular-bootstrap-calendar-tpls.min.js:7:28527

Ah that is a bug with the calendar, until I have the time to push a fix your best bet is to delete the $id property from the events when you update the list.
$scope.filteredEvents = $filter("filter")($scope.events,{type: $scope.type},false).map(function(event) {
  delete event.$id;
  return event;
});

Thanks Matt, I will test the provided code and get back to you.

Unfortunately the delete method those not work. I get the following Error
TypeError: Cannot delete property '$id' of #

I had some more time to look into this, I think I've already fixed this in a newer version of the calendar - what version are you currently using?

"angular-bootstrap-calendar": "~0.11.2",
Kind Regars,
KC MASHISHI
On Sat, Sep 19, 2015 at 2:50 PM, Matt Lewis<EMAIL_ADDRESS>wrote:

I had some more time to look into this, I think I've already fixed this in
a newer version of the calendar - what version are you currently using?
—
Reply to this email directly or view it on GitHub
https://github.com/mattlewis92/angular-bootstrap-calendar/issues/160#issuecomment-141661292
.

Ah that'll be why, if you upgrade to 0.15.0 then it should work. The changelog with breaking changes is here:
https://github.com/mattlewis92/angular-bootstrap-calendar/releases

Are you busy with the repo, i get this error when I try to run bower
bower angular-bootstrap-calendar#~0.15.0          ECMDERR Failed to execute
"git ls-remote --tags --heads
https://github.com/mattlewis92/angular-bootstrap-calendar.git", exit code
of #128 fatal: unable to access '
https://github.com/mattlewis92/angular-bootstrap-calendar.git/': Failed to
connect to <IP_ADDRESS> port 80: Timed out
Kind Regars,
KC MASHISHI
On Sat, Sep 19, 2015 at 3:45 PM, Matt Lewis<EMAIL_ADDRESS>wrote:

Ah that'll be why, if you upgrade to 0.15.0 then it should work. The
changelog with breaking changes is here:
https://github.com/mattlewis92/angular-bootstrap-calendar/releases
—
Reply to this email directly or view it on GitHub
https://github.com/mattlewis92/angular-bootstrap-calendar/issues/160#issuecomment-141668740
.

Looks like an error with github or your connection to the internet

Hi Matt,
As always, thank you very much for your prompt reply and the very helpful information.
It's not working.


AE duration is not only changed on Round change on the AE on the Actor but also on the Spell Item

3.0.1 see comments, because the 3.0 change to AE transferrals the SRD Bless (guess more?) Spell Item needs to be changed.
AE duration is not only changed on Round change on the AE on the Actor but also on the Spell Item
All modules deactivated, dropped Bless from SRD Compendium to be sure to not have corrupted data.

As far as I can tell, this means that the timers for effects are useless once an effect expires once. I could find no way to reset the timer aside from getting a new copy of the spell. I believe in 2.4 that this could be accomplished by deleting the effect from the actor and dragging it back from the spell, but now it seems when I delete the bless effect from the actor, it is removed from the spell also. Would love to be proven wrong 😅.

but now it seems when I delete the bless effect from the actor, it is removed from the spell also. Would love to be proven wrong 😅.

If an effect is set to transfer, then in v3 you will see it on the actor despite it being on the item. Hence what you were deleting was likely the effect on the item.

If an effect is set to transfer, then in v3 you will see it on the actor despite it being on the item. Hence what you were deleting was likely the effect on the item.

Yes. But that still leads to what he wrote. Currently as the duration on the Item goes down, not just on the AE on the Actor, one would have to drop a new Spell Item for every casting or reset the duration on the Spell Item.

If an effect is set to transfer, then in v3 you will see it on the actor despite it being on the item. Hence what you were deleting was likely the effect on the item.

Ah, okay, I can confirm checking Effect Suspended and unchecking Apply Effect to Actor works much better: I can apply the effect from the chat card, it ticks down, then I can delete it and reapply from the chat card. However this is only possible if I modify Bless. Maybe SRD items that should be applied in this way should have Apply Effect to Actor unticked by default.

ah, true. So this is not a code bug, but compendium

We wanted to preserve the 'old way' of toggling spell effects, whereby if you cast the Shield spell, for example, you would toggle on the AE in your own effects tab. A caster could cast Bless on themselves, and might prefer to toggle it in this way, so we left Bless as transfer: true. It's possible that we need to move entirely to applying spell AEs via the chat card though. I think we need to create fresh effects if we want to appropriately track duration and expire them, and track things like concentration.

To clarify, if we go with @Fyorl's suggestion, we'd do this?

Spell effects should not have transfer: true by default or in the SRD compendium (unless simply having the spell gives some effect. Which would be weird, but supported I guess).
When applying a spell effect from the chat card, we create a new effect on the actor, regardless of whether that actor owns the spell the effect came from (unless the actor already has an effect with the same origin).
In #2881 we made it so that if you re-apply the effect from the chat card to an actor that already has the effect, it will disable the effect. Would it be better to completely remove the effect from the actor rather than just disabling it?

Spell effects should not have transfer: true by default or in the SRD compendium (unless simply having the spell gives some effect. Which would be weird, but supported I guess).

Yes. We also need to change the logic for what effects appear in the effects tray. There's a conditional branch that will sometimes show effects with transfer: true. We would not need that anymore.

When applying a spell effect from the chat card, we create a new effect on the actor, regardless of whether that actor owns the spell the effect came from (unless the actor already has an effect with the same origin).
In [#2770] Toggle effect on actor if it already exists #2881 we made it so that if you re-apply the effect from the chat card to an actor that already has the effect, it will disable the effect. Would it be better to completely remove the effect from the actor rather than just disabling it?

I think if you try to apply an AE to an Actor that already has it, it should probably just do nothing. I don't think toggling something off/deleting it would be the expected outcome of an apply operation. There is some existing logic that would toggle it on if it finds an existing AE that is disabled. But assuming we do the first point, such AEs would not naturally exist anymore.

Yeah, sounds reasonable to me.

I think if you try to apply an AE to an Actor that already has it, it should probably just do nothing. I don't think toggling something off/deleting it would be the expected outcome of an apply operation. There is some existing logic that would toggle it on if it finds an existing AE that is disabled. But assuming we do the first point, such AEs would not naturally exist anymore.

As a couple of messages before you mentioned something about properly tracking duration, in this context, applying on an Actor an already existing effect, it should at least "renew" it for expiration reasons.

As a couple of messages before you mentioned something about properly tracking duration, in this context, applying on an Actor an already existing effect, it should at least "renew" it for expiration reasons.

Yeah that makes sense.

Should we/can we make any attempt in a migration to reset the duration on spell effects? Or just tell people to re-add the spell if the duration is messed up?

Should we/can we make any attempt in a migration to reset the duration on spell effects? Or just tell people to re-add the spell if the duration is messed up?

We would want to avoid resetting the durations on AEs in an active combat. Maybe we can check for an existing Combat instance. I'm not sure how reliable that would be.

One the Spell Item I'd think resetting would be correct even in combat. If it is transferred to Actor, the copy is different. That should not be reset. If resetting is worth it, a good heuristic being possible, but still a heuristic as there is no link to the compendium, extreme case would be a table using a Spell's version keeping the name but having changed the duration intentionally.


Chore/natspec

Making a pull request to resolve style and natspec issue. Gigantic PR so if there is not a big issue, we should merge it in and make it easier to track from here.
Closes #39 and #40.

Could attempt to generate docs too


Any plans for Fixed Point numbers?

Are there any plans to support Fixed Point numbers?
I did a search on crates and did not find any implementation.
BigRational is too slow for me.
and I could not get Ratio working for my case. (overflow issues).

See issue #8 and PR #224 for BigDecimal, although I think there are still some unanswered questions.

Yep, saw that. But thats regarding the BigDecimal - which would have infinite precision.
I am looking form something having decimal representation but not being as slow as BigDecimal probably would be.
Any plans for d64  or d128 in this library?

In theory it shouldn't be that hard. However truly fixed point arithmetic isn't possible until we get Π types so you could write:
let a: Fixed64<10> = 10.into(); // 64 bit digit with 10 digits after decimal point
let b: Fixed64<5> = 10.into();

// a + b would be impossible as their type is different

Currently only solution would be using typenum crate which is quite slow when compiling. So I hope that in future it will be possible (as I would ❤ to have Π types as I could make good use of them in my Octavo library).

It should be easy to write a macro that constructs a fixed-point number type to the given specifications, so:
// Create a signed 64-bit number with 10 bits after the decimal point
fixed_point!(Fix64_10, i64, 10);

let a: Fix64_10 = 10.into();
let b: Fix64_10 = 20.into();
a + b

There's a typenum-based implementation here, that looks interesting. It might be better to limit the library to defining the macro's, and let the library users instantiate the types of interest (as suggested by icefoxen), though. Otherwise compilation time could quickly explode with the number of types, especially if you tried to provide all possible converting functions (mul, cast, etc.).

I don't have any plans to implement this in the rust-num organization, but maybe fpa or some other crate could work for you.


HBASE-22920 github pr testing job should use dev-support script

the PR tester Jenkinsfile_GitHub has its own set of commands for gathering information about the build environment it runs in. Instead it should rely on the dev-support/gather_machine_environment.sh that gets used by nightly

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  5s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 36s
Maven dependency ordering for branch

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
shellcheck
0m  0s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

_ Other Tests _

+0 :ok:
asflicense
0m  0s
ASF License check generated no output?

2m 51s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-883/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/883

Optional Tests
dupname asflicense shellcheck shelldocs

uname
Linux 4cd77387aa06 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-883/out/precommit/personality/provided.sh

git revision
master / 636fa2c6b0

Max. process+thread count
52 (vs. ulimit of 10000)

modules
C:  U:

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-883/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.7.0

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 35s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 48s
Maven dependency ordering for branch

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
shellcheck
0m  0s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

_ Other Tests _

+0 :ok:
asflicense
0m  0s
ASF License check generated no output?

2m 17s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-883/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/883

Optional Tests
dupname asflicense shellcheck shelldocs

uname
Linux 1887400c5c1a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-883/out/precommit/personality/provided.sh

git revision
master / 636fa2c6b0

Max. process+thread count
52 (vs. ulimit of 10000)

modules
C:  U:

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-883/2/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.7.0

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@saintstack I did a quick diff between the master's machine info and this patch's machine info
https://pastebin.com/yFKmyN41
Don't see any difference. I think this is good to go.


Support clearing the screen via C-l.

This should work the same as bash et al.
If there is an "in progress" line it is preserved and redrawn
at position (0, 0).

Looks great


Be explicit about rank of "left" versus "right" with respect to their relative positions within the source dataset

https://github.com/keras-team/keras/blob/f9336cc5114b4a9429a242deb264b707379646b7/keras/utils/dataset_utils.py#L36
Given the frequency with data leakage is a problem in AI models, it is important that documentation for methods that split training and testing data be as clear as possible.  Given the documentation of this method, it would be easy for an untrained reader to come away with the impression that training_dataset, testing_dataset = split_dataset(source_dataset, left_size=training_size, right_size=testing_size) is essentially equivalent to testing_dataset, training_dataset = split_dataset(source_dataset, left_size=testing_size, right_size=training_size).  Even knowing that this is an important issue when working with a time series, it is not altogether clear to me, without testing, that left would precede right (though it seems intuitive).
Please update the documentation to indicate that "left" precedes "right" and update the example to demonstrate this - e.g.:
>>> import tensorflow as tf
>>> source_dataset = tf.data.Dataset.from_tensor_slices([[n] for n in range(0, 2)])
>>> list(source_dataset)
[<tf.Tensor: shape=(1,), dtype=int32, numpy=array([0], dtype=int32)>, <tf.Tensor: shape=(1,), dtype=int32, numpy=array([1], dtype=int32)>]
>>> training, testing = tf.keras.utils.split_dataset(source_dataset, left_size=1, right_size=1)
>>> list(training)
[(<tf.Tensor: shape=(), dtype=int32, numpy=0>,)]
>>> list(testing)
[(<tf.Tensor: shape=(), dtype=int32, numpy=1>,)]

Hi @hstclair ,
The API tf.keras.utils.split_dataset returns a tuple containing two tf.data.Dataset  objects. The left value takes Index[0] and right value takes index[1]. This is python behaviour and I hope users are aware of that.
Do you mean to say for Time series data, if they use test_dataset at left then there might be problem ?
Is that what you meant to say or is there anything else I am missing here ?

For timeseries data, the left entry in the tuple (at index[0] in the tuple) contains earlier elements and the right entry in the tuple (at index[1] in the tuple) contains later elements.
Given a dataset of k elements and some selection n where n < k:
left, right = split_dataset(dataset, left_size=n, right_size=k-n)
left will contain elements dataset[:n] while right will contain elements dataset[n:]
This result is not specified anywhere in the documentation and, while this result makes sense, it is not strictly intuitive.
A user who is concerned about defending against temporal dependency errors while processing time series history versus outcomes must manually test this method in order to determine how it actually behaves.
I'm simply asking that an explanation similar to what I have provided above be added to the documentation so that it is not necessary to test the method in order to discover how it behaves.

Hi @hstclair ,
I think the example provided in documentation also same what you are expecting.Please refer below.

The example seems enough to what you are expecting. For me this seems enough.
May be, you can propose adding some additional text under the Returns section like: the first and second objects of the tuple represents left_size and right_size datasets respectively. You may propose similar text by creating a PR and let's hear from the developer team. WDYT ?
Thanks!


Add contribution notes

Signed-off-by: Chris Evich<EMAIL_ADDRESS>

@Mergifyio rebase

@mergifyio refresh


Structurizr as a dev container feature

Description
Hi! It would be nice if instead of using prebuild containers we could use devcontainer feature (https://containers.dev/features). In this case we can keep using our devcontianer images but with preinstalled CLI.
Priority
Low
Resolution
I have no budget, please add this feature for free
More information
No response

You might be interested in https://github.com/evilpilaf/structurizr-remotecontainer (linked to from https://github.com/structurizr/cli/blob/master/docs/containers.md).

well - indeed - I understand what you mean, but here is the point. The root container may be different . Someones writes java, someone uses Node, we all use different base containers. But feature approach allows us to share features among base containers actually

Dev containers isn't something that I use, but you're welcome to add support.


User group management zone permissions

Is your feature request related to a problem? Please describe.
Allthough we can create user groups with the Terraform provider for Dynatrace and we can set permissions for environments, we cannot set permissions for specific Management Zones. At least the documentation does not cover permissions to management zones.
Describe the solution you'd like
We would like to configure permissions on Management Zone level with the Terraform provider for Dynatrace. Probably this has to be added to the resource "dynatrace_user_group".
Describe alternatives you've considered
Create the user group via Terraform and configure the permissions later via UI. This renders the automation a bit less useful.

Hello @PatMis16,
I believe what you're looking for is the resource dynatrace_mgmz_permission. Am I right?

Hi @Dynatrace-Reinhard-Pilz
Yes, you are probably right. In this case, this issue can be closed.


Add fsanitize testing

Found some issues in #63. Plus we would want to satisfy an optional requirement of xSDK (cf #58).

Actually, fsanitize is probably preferred to valgrind.

I just have problems running CMake using MPI then.

You probably need a suppression file.  Bruno had added one in DTK.  Refer to ORNL-CEES/DataTransferKit@d2c8c4f

With -fsanitize=leak and surpressing errors for libopenpal.so(no CUDA), I currently see:
 SUMMARY: LeakSanitizer: 33065 byte(s) leaked in 407 allocation(s).
13:     #1 0x7fab0e05a547  (<unknown module>)
13:
13: Indirect leak of 80 byte(s) in 1 object(s) allocated from:
13:     #0 0x7fab12d80acb in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/liblsan.so.0+0xeacb)
13:     #1 0x7fab0a158edc  (<unknown module>)
13:
13: Indirect leak of 56 byte(s) in 1 object(s) allocated from:
13:     #0 0x7fab12d80acb in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/liblsan.so.0+0xeacb)
13:     #1 0x7f0dd9e75484  (<unknown module>)
13:     #2 0x3433  (<unknown module>)
13:
13: Indirect leak of 48 byte(s) in 2 object(s) allocated from:
13:     #0 0x7f0ddec05acb in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/liblsan.so.0+0xeacb)
13:     #1 0x7f0431fa9c4c  (<unknown module>)
13:

Apparently we are not doing it, it's been 3 years.

Sure.  We can always re-open as necessary.  I have a suppression file laying around somewhere for stuff from Boost.  I typically didn't use with MPI (mostly because I usually don't enable to save time when developing these days)


Feature: create main abstraction in commons

This PR moves the main abstraction to the commons package combined with your previous PR:
https://github.com/joutvhu/spring-dynamic-commons/pull/1

I have implemented this on develop branch.
The process method has been moved from DynamicQueryTemplateProvider to DynamicQueryTemplate.

I implemented two the template providers below with new design:
spring-dynamic-freemarker
spring-dynamic-velocity


Upgrade minimist to avoid security vulnerability

See this for more info.

Additional resources: https://www.npmjs.com/advisories/1179

Also, fixes #163

you might want to checkout https://github.com/tmcw/togeojson which is a maintained fork of togeojson.

you might want to checkout https://github.com/tmcw/togeojson which is a maintained fork of togeojson.

Thanks!


[FR] Add Line Item on Sales Orders does not search Supplier Part Names

Is your feature request the result of a bug?
No
Problem
A number of our parts have 3 or more valid numbers because of History, Standards Bodies, or assembly manufacturers.
As an example. So the manual says use NumberA.  The supplier calls it 1970StdBdy-A. The part is entered into our instance as NumberA.  We ordered the part from the supplier as 1970StdBdy-A.  The part arrived with 2020StdBdy-123 written on it.
The mechanic then wrote the part down on the workorder as 2020StdBdy-123.  At the point data entry is being done the person entering data only sees 2020StdBdy-123 but the Add line item on the search doesn't find it.  So they search the name using the Omni Search at the top right, they find 2020StdBdy-123 and get frustrated that the search is not working.
Suggested solution
Also search the supplier part names when adding parts to Sales Order.
Describe alternatives you've considered
This can be fixed by adding all of the Supplier Part Names to the keywords of the part but why enter the data into the system twice?
Do you want to develop this?
I probably could.  I think this should be as simple as adding the correct field name to the list of search fields.

Intresting find, I only use internal IPNs everywhere but I can see how this problem comes up. I assigned this the 1.0 milestone - that means basically whenever. Feel free to ping inventree/maintainer if you need pointers / want feedback etc.

@nwns should be an easy addition to the API search fields as you say.

@nwns I think that it currently does work as you intend, actually:
Create a part with a supplier part name (SKU) as follows:

Search on this SKU in the "add line item" form:

I believe this is what you are looking for?

Note that this is running latest master, not stable. Might be different on stabl.

@nwns can you please confirm if you still see this issue on latest version (e.g. on the demo site). Otherwise I'll close it out.

@SchrodingersGat It doesn't seem to be working

@nwns really confused here. This is on current "latest" master branch:

@SchrodingersGat This request is for Sales Orders, it currently works fine on Purchase Orders as you noted.

@nwns I guess I can't read? I'll look into Sales Orders ;)

Seems to work for sales orders on my end...

Hrm. I was trying it on the public demo server. Is the demo server master or stable?  I will have try this again tomorrow @SchrodingersGat

This is on current master

Figured it out.  It does seem to work on the demo server and on master.  Problem was the part was not saleable.


Thread safe?

Can a global ranger be used across many goroutines for read only search operations?

Can you share the answer?


display names are not unique

two users had the name "test" pointing to a potential vulnerability.

Fixed in 4.2.2


[DayZ] Bug Fixing & Cleanup

Description
Egg:

Fixed mission persistence and mission parameters (like loot tables, etc.) being broken due to missing vanilla mission files in certain scenarios (ie. Steam account does not own the DayZ game).
Fixed bugs that prevented the server from starting due to a missing hostname variable in 'serverDZ.cfg'.
Improved the installation script to better accommodate Steam users with Steam Guard enabled and check for missing required files.
Changed the installation script to not overwrite 'beserver_x64.cfg` upon reinstallation if it already exists.
Changed the default Steam Query Port to be correct.

README:

Added @shaynendradika as a contributor.
Fixed/Improved "Server Ports" section.
Elaborated on the differences that game ownership makes in the "Installation/System Requirements" section.
Updated the "Running With Steam Guard Enabled" section.
Fixed typo.

Resolves #39
Checklist for all submissions

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] Have you tested and reviewed your changes with confidence that everything works?
[x] Did you branch your changes and PR from that branch and not from your master branch?

[x] You verify that the start command applied does not use a shell script
[x] The egg was exported from the panel

I tested it, but I still have the same problem.

To prevent this PR from going stale, and because these fixes are still generally good overall & finally have been tested and approved by someone other than myself, I'm going to go ahead and merge it. However, because it still cannot be confirmed to fix #39, I will remove the link to this PR that would close that issue (leaving it open to be fixed in the future).


Crashes on Out of Space

Out of a total of nine nodes I run (four on docker, five native), only Oasis and an old bitcoin copy-paste-fork crashed and ceased running due to a temporary out of space condition that was then resolved hours later.
Note that this was an edge case with Github being down yesterday and bug in an autoupdate script recursively copying my home directory into a single directory infinitely.  Still, Oasis needs to be made much more robust if other nodes can handle it.

Any more details of the crash? Logs and potential backtrace (in case of panic) would be useful.