[transaction] Recover from failures during endTransaction after writing to storage

(cherry picked from commit 7f59a829bfdfb5cffd7f4eda0dc8d549048c9e59) refer to https://github.com/datastax/starlight-for-kafka/commit/7f59a829bfdfb5cffd7f4eda0dc8d549048c9e59
Motivation
Recover from failures during endTransaction after writing to storage.
Modifications
Reset the transaction pending state from failures during endTransaction.
Documentation
Check the box below.
Need to update docs?

[ ] doc-required
(If you need help on updating docs, create a doc issue)

[x] no-need-doc
(Please explain why)

[ ] doc
(If this PR contains doc changes)

It looks like the test failed. Can you check the failed test?


new data training

Hello. Can I use your git repo to train with my new language data?

Yes. it is absolutely possible! in fact, this repo contains everything you need to train your own miipher from scratch.
Please check out the configuration file first

This configuration file should give you some insights on how to start training miipher with your own data
https://github.com/Wataru-Nakata/miipher/blob/main/examples/configs/config.yaml


House number is display as N/A

Describe the bug
PayPal shows N/A on the address line, because you don't split the house number from the address line.
https://github.com/Adyen/adyen-shopware6/blob/7e9427e70fb857dda8fead1729c93e6e6cf63316/src/Handlers/AbstractPaymentMethodHandler.php#L352
Versions
Shopware version: v<IP_ADDRESS> Stable Version
Plugin version: Version: 3.3.1
To Reproduce
Steps to reproduce the behavior:
Pay with PayPal
Expected behavior
House number should be split from the address line and should display correct on any payment, and in Adyen backend.
Desktop (please complete the following information):

OS: any
Browser any
Version any

Smartphone (please complete the following information):

Device: any
OS: any
Browser any
Version any

This issue is resolved in #255 and will be released in version 3.5


Can't disable backref generation

Currently it is not possible to disable backref generation for SQLAlchemy model. It makes impossible to inherit model with two ForeignKey to same model.
Example:
class A(models.Model):
    ...

class B(models.Model):
    field1 = models.ForeignKey(A, related_name='+')
    field2 = models.ForeignKey(A, related_name='+')
    class Meta:
        abstract = True

class BA(B):
    ...

class BB(B):
    ...

It is not possible to make this models work in any way and will always result in:
InvalidRequestError: One or more mappers failed to initialize - can't proceed with initialization of other mappers.  Original exception was: Error creating backref 'ba_set' on relationship 'BA.field1': property of that name exists on mapper 'Mapper|A|app_a'
If related_name is set to '+' aldjemy shouldn't generate backref as Django does.

@yuriiz: Can you test this patch please?

Works for me. Thanks.


[Bug] Mamushi can't parse 10_000

Describe the bug
Mamushi throws errors (unable to parse) when a contract contains an underscore as a part of an integer, despite Vyper accepting these numbers as valid.
Unable to parse input file, are you sure the Vyper code is valid?
To Reproduce
Try to lint any vyper smart contract containing an underscore in a number.
Expected behavior
Mamushi accepts 10_000 the same as 10000 and does not error. Perhaps a simpler alternative could be to at least warn users that this is a possible source of the error message.
Desktop (please complete the following information):

OS: MacOS 12.7.5
Mamushi version 0.0.2a1
Vyper version 0.3.9

Additional context
Using underscores in smart contracts is common practice to allow for clear, visual separation of thousands places.

My bad, the fix was not included in the last release on pypi, this should now be fixed:
https://pypi.org/project/mamushi/0.0.2b0/
please try again and let me know if that solved your issue

confirmed that it works with the latest version, thanks!


Changed example boolean arbitraries to jsc.bool

Writing some tests myself I was blocked on an error coming back saying TypeError: jsc.bool is not a function. After some trial and error I found out that the expected syntax is to use jsc.bool instead of calling bool as if it is a function as in jsc.bool().

Done in #177


Make string column name as property

Problem
String column name in dynamic set was treated as string
Solution
Make it a Property

Thanks!


Updated to DALI 1.4.0

Checklist before submitting

[x] Did you read the contributor guide?
[ ] Did you update any affected documentation?
[ ] Did you write any tests to validate this change?

Description
Refreshed to DALI 1.4.0
Review process to land

All tests and other checks must succeed.
At least one maintainer must review and approve.
If any  maintainer requests changes, they must be addressed.

Thanks @npanpaliya !


Support for Amazon SageMaker Studio Lab

Amazon SageMaker Studio is a free cloud computing platform, similar to Binder but users can install packages and save files permanently. It seems localtileserver is not working on SageMaker, even after running the following code. Any advice?
import os
os.environ["LOCALTILESERVER_CLIENT_PREFIX"] = "proxy/{port}"

I haven't used sage maker yet but it seems to be gaining a lot of traction... I'll see what I can do to get this to work.

I have no idea where to begin with this... I signed up for a handful of different "SageMaker" things and could not figure out how to launch a notebook environment anywhere... this whole has left me quite confused.
Anywho, I think "SageMaker Studio Lab" is the platform? right? If so, I'm waitlisted:

@banesullivan Yes, SageMaker Studio Lab is the free version, something similar to Google Colab. It might take a few hours /days to get the account approved. Other SageMaker products are not free.

I finally have an account, but I'm having trouble getting ipywidgets to work at all... tried restarting JupyterLab from the sagemaker menu but no luck...

However, from the looks of it. SageMaker truly is just JupyterLab (unlike Google Colab) so setting up Jupyter-server-proxy to get this working should be all the same

Yes, ipyleaflet might not work with SageMaker Studio. Try folium

Indeed, same set up with JupyterLab, just need the right prefix. This works as:
import os
os.environ['LOCALTILESERVER_CLIENT_PREFIX'] = f"studiolab/default/jupyter/proxy/{{port}}"

On MyBinder, this prefix is easy to get with the JUPYTERHUB_SERVICE_PREFIX environment variable. Unfortunately, I do not see anything like this in the environment on sagemaker.... though studiolab/default/jupyter/ seems standard enough that this is probably the prefix in any environment -- @giswqs, you might know better than I

Really IMO, we should raise issues like this upstream in jupyter-server-proxy and see if they can make this easier to do in Colab, SageMaker, MyBinder, etc.

I'll add it to my to do list to open an issue upstream outlining the need clearly

That's fantastic! How did you figure out the prefix?

Is it possible to get the browser URL programmatically and extract the prefix from the URL?

I think @arttt was able to do this. See https://github.com/banesullivan/localtileserver/issues/101#issuecomment-1397932114


Add API to handle and process IM events.

Problem
Need API to handle and process iM events in controller side.

This is blocking Matter Test Harness.
For certain controller certification tests, a simulated node needs to be able to handle events like StartUp, ShutDown and Leave. @vivien-apple's simulated nodes for these controller tests leverage the matter stack to handle events. Therefore this bug needs to close so that the Matter stack supports events and thus the simulated nodes leveraged by the test harness can handle events as well.

Fixed in #11615

If there are further requirements on the controller side, please open a new issue.


cerf instead of Faddeeva

This is roughly what I was thinking of for #53 . See what you think. (PR includes #52 but I can rebase those out later.)

All good, thanks for the changes.


Consolidated table of all 600 articles that comprise LSD600

I'm reviewing the preprint LSD600: the first corpus of biomedical abstracts annotated with lifestyle–disease relations.
It would be helpful to have a single table of all 600 abstracts comprising the LSD600 corpus.
Columns that come to my mind are:

pubmed id
journal
publication year
title
number of disease entities
number of LSF entities
number of relations
dev/train/test category
abstract text

And perhaps you can think of more.
The goal here is to have an accessible reference of all abstracts in the corpus and their metadata.

Thank you for your comment and for reviewing the preprint! We appreciate your suggestion, and we will provide this table as metadata about the LSD600 corpus soon.

I’m pleased to inform you that the metadata file you requested is now available. It includes a comprehensive table of all 600 abstracts in the LSD600 corpus with the following columns:

Publication ID
Article Title
Journal Name
Publication Year
Data Set (Dev/Train/Test Category)
Lifestyle Factor Count
Disease Count
Relations Count
Abstract Text

You can access the file here:
🔗 LSD600 Metadata File

Very helpful. I see the LSD600_metadata.tsv on the Zenodo and the contents look good.
Closing this issue and the corresponding request in my review should be considered addressed!


Authentication works using sessionStorage

If you set the token using
sessionStorage.setItem('token', 'blahblah')
It works fine and you can access the protected  content. Could there be something wrong?

Sorry for the late response. It is actually working as intended.
When a user logs in, the token goes to the reducer to be put in the Redux store and it is saved in the sessionStorage. When changing for sessionStorage.setItem('token', 'blahblah'), the correct token is still stored in the Redux store and when a REST request is made, the authentication uses the correct token (from the Redux store). If you clean your browser cache and try to force the Redux store to be initialized by dispatching the login with the incorrect token stored in the sessionStorage it won't be able to authenticate (because the token is invalid). The code below illustrates this authentication.
let user = {};
try {
  user = JSON.parse(sessionStorage.getItem('user'));
} catch (e) {
  // Failed to parse
}

if (token !== null) {
    store.dispatch(authLoginUserSuccess(token, user));
}```


[KeyvAdapter] Allow return "undefined" when cache backend is unavailable

I am using @apollo/utils.keyvadapter to implement redis cache backend. The adapter makes redis or other cache backend a hard dependency. This means when the apollo server lost connection to redis server, any incoming requests will fail. It would be good to allow the redis client to retry connection. At the same time, any queries with cache control should still function by bypassing cache.
Meanwhile, I use the following code to achieve the goal.
class BetterKeyvAdapter extends KeyvAdapter {
  // this will allow the query to bypass the cache if cache backend is not available
  async get(key) {
    try {
      return await super.get(key);
    } catch (e) {
      return undefined;
    }
  }
}

It looks like you're looking for ErrorsAreMissesCache, a KeyValueCache implementation that wraps another KeyValueCache implementation. It is provided by @apollo/utils.keyvaluecache.


CCP.EVEOnline version 2294803

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[x] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Unfortunately, it appears that the EvE Online installer doesn't support unattended install.

@rolling2405 this isnstaller is dprecated


Hello WebAssembly! (MVP implementation)

See #829.
This PR adds minimal support for compiling a Crystal program into WebAssembly and then linking it with a WASI-based LibC. Browsers are still not supported.
What does not work:

GC
Fiber and spawn
Mutex
Thread
Signal
Exception
CallStack
Dwarf
Event Loop (needs building LibEvent. It should work fine, but I didn't try)

How to use:

Write a simple Crystal program, let's say: puts "Hello WebAssembly!" and put it to main.cr.
Build a compiler from this branch (simply run make).
Build the WebAssembly module: bin/crystal build main.cr --cross-compile --target wasm32-unknown-wasi. This will generate a main.o file that is actually a binary wasm file.
For this to work you will need a LibC based on WASI. You can download a precompiled one from https://github.com/WebAssembly/wasi-sdk/releases/download/wasi-sdk-14/wasi-sysroot-14.0.tar.gz.
Link your program and this LibC into a final WebAssembly module: wasm-ld main.o -o main.wasm wasi-sysroot-14.0/wasi-sysroot/lib/wasm32-wasi/libc.a wasi-sysroot-14.0/wasi-sysroot/lib/wasm32-wasi/crt1.o.
Now you have a main.wasm file. It is already a final module that can run on any WASI-capable runtime, like Wasmer.

$ wasmer main.wasm
Hello WebAssembly!

This PR is the bare minimum necessary to get it working. Unfortunately, I had to add flag checks on more places than I would like, but these can go away once other features get ported.

Would it be better to implement more WebAssembly-related features here before this gets merged or to focus on merging this minimally as is (hardly useful by itself) and bring improvements later? The included smoke test should at least avoid regressions.

IMO I Would strongly caution against trying to get more features in and maintaining a long-running branch for a new platform (it'll be harder to keep momentum if you have to play catch-up with upstream)
Each of the pending things is easily enough extra time and work for their own PR (and likely multiples)

The scope of this is perfect, thank you. It just seems that nobody has gotten around reviewing it, due to the release cycle, conference and other more urgent tasks.

Would it be better to implement more WebAssembly-related features here before this gets merged or to focus on merging this minimally as is (hardly useful by itself) and bring improvements later? The included smoke test should at least avoid regressions.

My only concern is there are a lot of stub methods, which is fine, but there is no indication that they need to be completed later, which might get confusing as this is iteratively worked on.  I'm wondering if those stub methods should at least have a # TODO:  comment or something, if possible with a description of what is required to complete them.

Yes, a couple of TODO or NotImplementedError would be nice. Ideally, any stub method should have at least one of those.

I included some code from @maxfierke here and I want to thank and credit him for this too. Thank you!

As an aside, I'd love to get Crystal support in the WASM-4 fantasy console once this is done. My understanding is that --prelude will be usable to keep the output tiny and runtime free if wanted. Also need some ability for memory control in wasm4 to make things work. Currently has support for AssemblyScript, C, C++, D, Go, Odin, Rust, & Zig, hopefully with Nim coming soon.

Great news: I got the Crystal compiler itself compiled into WebAssembly and linked with LLVM 13 targeting WebAssembly. It is not yet able to self-host because the compiler needs exceptions internally (raise SkipMacroException.new for example) and probably some other issues I don't yet know. I'll be working on them to make it able to compile itself inside a browser.
With this, I can already run crystal tool format entirely inside a browser successfully. My next goal is to set up a web-based Crystal playground.
$ wasmer crystal.wasm -- -h
Usage: crystal [command] [switches] [program file] [--] [arguments]

Command:
    init                     generate a new project
    build                    build an executable
    docs                     generate documentation
    env                      print Crystal environment information
    eval                     eval code from args or standard input
    i/interactive            starts interactive Crystal
    play                     starts Crystal playground server
    run (default)            build and run program
    spec                     build and run specs (in spec directory)
    tool                     run a tool
    help, --help, -h         show this help
    version, --version, -v   show version

Run a command followed by --help to see command specific information, ex:
    crystal <command> --help

Download: crystal.zip

As an aside, I'd love to get Crystal support in the WASM-4 fantasy console once this is done. My understanding is that --prelude will be usable to keep the output tiny and runtime free if wanted.

So I built this branch and ran this line with empty files for both main.cr and prelude.cr: bin/crystal build main.cr --cross-compile --target wasm32-unknown-wasi --prelude prelude.cr
But specifying an empty prelude doesn't bring down the size at all. With or without that option, I get the same size of about 670k. Am I using prelude wrong?

@lbguilherme forgive me the unprofessional comment: HOLY WOW!!!

does wasmer/wasi need some explicit file access permission?
I always get 'Unable to get file info' error:
~/dev/script/crystal/ wasmer crystal.wasm -- run test.cr
EXITING: Attempting to raise:
Unable to get file info: 'test.cr': Invalid argument (File::Error)

wasmer crystal.wasm -- build test.cr
EXITING: Attempting to raise:
Unable to get file info: 'test.cr': Invalid argument (File::Error)

@pannous WebAssembly is sandboxed in such a way that you can't access the host file system by default. You use --mapdir <guest-path>:<host-path> to expose some directory. For example:
wasmer --mapdir /:/ crystal.wasm -- tool format $PWD/test.cr

Or, more selectively:
wasmer --mapdir /:$PWD crystal.wasm -- tool format /test.cr

@tjpalmer It looks like if you use --prelude prelude.cr it will include de default prelude even if you have a file named prelude.cr in the current dir. Try this:
touch empty.cr
bin/crystal build empty.cr --release --cross-compile --target wasm32-unknown-wasi --prelude empty.cr
wasm-ld empty.wasm -o empty-final.wasm $WASI_LIBS/libc.a $WASI_LIBS/crt1.o
wasm-opt empty-final.wasm -o empty-opt.wasm -O3 --converge

This produces an empty-opt.wasm file with 9.8kb (all of which comes from libc initialization and not from Crystal).

More great news: This is the Crystal compiler running inside a browser, targeting WebAssembly and running the binaries it produces on the fly!

Try for yourself: https://lbguilherme.github.io/crystal-playground/
(I'll later provide exact instructions on how to build LLVM and Crystal together in this way, it isn't simple)

Now I think I'm just having fun with it. This produces just 42kb of gzipped wasm and runs on any modern browser just fine:

Here I used macros to generate a minimal javascript glue code exposing the DOM methods.

Now I think I'm just having fun with it. This produces just 22kb of gzipped wasm and runs on any modern browser just fine:

Do you have the build instructions for this? And how big uncompressed?

22kb gzipped / 54kb before compression.
Here are my code and instructions on running it: https://github.com/lbguilherme/crystal-web

Current status:

This PR is ready for review, I don't plan to add anything more here.
Fibers: stack switching can be implemented on top of Binaryen Asyncify. It allows unwinding and rewinding stacks. The main function must be wrapped in a loop that will first begin normal execution. The swapcontext will then set a global variable with the target Fiber and begin unwinding until it reaches the main function. It will check this global for the target Fiber and start rewinding into it. The loop repeats until no Fiber wants to execute. Thus the Scheduler must be started from main, wrapping everything inside it. LLVM produces a shadow stack on memory for the local variables that we grab a pointerof. The address of this stack has to be switched too, but this is much simpler, just swapping a pointer at the right time.
Garbage Collection: LibGC (bdwgc) can be compiled into WebAssembly, but it requires inspecting the stack to work properly. In WebAssembly the normal stack can't be inspected. But we can take advantage of Asyncify again: If we unwind the current Fiber then, at this point, every variable is stored in memory. This is the only time the GC can run. We must then rewind into the same Fiber again.
Exceptions: There is an exceptions extension to WebAssembly that is already implemented by Chrome and is in the process of being implemented by Firefox. LLVM already supports emitting it behind a flag. So I guess we just wait for it to be ready and use it. No need to be too clever here.
WASI: There are currently two usual targets for WebAssembly: WASI is a set of standard functions (think of it as syscalls or a special libc) that most embedders already implement natively, and there is Emscripten that emits a companion JavaScript file that will work on browsers too, following a very specific format of this tool. There are currently more libs that work on Emscripten than that work on WASI, but I opted for using a standard format that produces a single WebAssembly file and has no relation with JavaScript. It limits the things we might do, but I think it's ok. Shards can provide the missing functionality by emitting JavaScript (see lbguilherme/crystal-web for example)
Threads: WebAssembly has atomics and can be run in multiple threads. But WASI has no way of creating new threads, so we can't do much. I guess this can remain NotImplemented until either WASI supports threads or we decide to emit a JavaScript support file for it. Either option should take a while given multi-threading is still experimental in native Crystal.
EventLoop: WASI supports async IO and wasi-libc implements poll on top of it, so I think compiling libevent is viable. If it isn't, we can always implement the event loop on top of WASI directly.
Signals and Process: Those don't make sense in WebAssembly since there is no concept of process. So it will remain not implemented.
CallStack: We might be able to raise and rescue from exceptions, but we are still unable to obtain a stack trace from it as the stack can't be inspected. There are two options as far as I can tell: unwinding the current Fiber with Binaryen Asyncify and then analyzing the generated format together with debug info stored in some format (highly complex!) or calling into a JavaScript runtime where producing a stack trace is trivial, but this again means the output won't be a pure wasm file. The debugability of WebAssembly itself right now is far from ideal.
Web: The WASI target can be used for the Web by mocking some WASI functions. I'm not sure if this should be always provided by shards or if the compiler should support a second WebAssembly target (--target wasm32-unknown-web?) where it will always emit a js file (and thus enable some of the features we just discussed). Anyway this can be decided later.
Libraries: Building a final wasm file requires libc, libpcre, libgc, libevent, etc. All of those should be built for wasm-wasi and grabbing those isn't trivial. Ideally, the compiler should ship with prebuilt versions of these so it can target WebAssembly without any extra work from the user. Is there a precedent for this on other platforms? Also wasm-ld from LLVM and wasm-opt from Binaryen would be required to produce a working final binary. Could those be shipped together as well? Or the user will be instructed to install them?

Actually, those were correct.
We can think about three wasm targets:

wasm32-unknown-wasi: Currently implemented. Uses the WASI layer together with the libc from wasi-sdk.
wasm32-unknown-unknown: Imports nothing and should restrain itself to only pure wasm features. This is useful for embedding wasm somewhere. It has no IO of any kind, but it is still possible to include LibGC. Does not work currently.
wasm32-unknown-js: For running wasm inside a JavaScript environment, I'm not sure if we will have this functionality short-term.

The first two targets are quite important to have. I'm using flag?(:wasi) for things that involve only the first target and flag?(:wasm32) for the guards about both targets.
Wasm doesn't have a way of implementing FFI with or without wasi. It could be done with js, but I'm leaving this to the future.


Unknown Puppet subcommand 'debugger'

As per instructions:
~ gem install puppet puppet-debugger
Successfully installed puppet-5.5.6-universal-darwin
Successfully installed puppet-debugger-0.9.1
2 gems installed

~ puppet debugger
Error: Unknown Puppet subcommand 'debugger'
See 'puppet help' for help on available puppet subcommands

~ gem list|grep puppet
puppet (5.5.6 universal-darwin)
puppet-debugger (0.9.1)
puppet-lint (2.3.6)

thanks for reporting.  Not sure what changed.  In the meantime you can use the pdb command. Although if you have the python debugger this may conflict.

Thanks @logicminds, Indeed it seems to work with the system ruby, does it perhaps have some hard coded paths in it's alias from pbd? (and yeah I use the python debugger of the same name so that clashed and threw me off at first!)

No hard coded paths, but I think this is an issue with using relative path loading and RVM. I'll need to go back and change a few things later this week.

Have same issue with RVM on Ubuntu

There is a bug in puppet core that is causing this issue.
The following code is the responsible code for not loading the puppet-debugger.
https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/rubygems.rb#L11
Essentially, RVM loads up bundler by default which causes puppet to ignore external gem directories (puppet-debugger) and many more gems with faces and applications.  This means that all puppet versions are affected.
There is no way to fix this in the puppet-debugger code.  This is a puppet issue and an unfortunate side affect with bundler which RVM uses and loads by default.
There are some workarounds:

Set the RUBYLIB path to always load the debugger code  (set in shell environment variable)
ie. RUBYLIB=/home/worker/.rvm/gems/ruby-2.3.1/gems/puppet-debugger-0.10.1/lib puppet debugger

Don't use RVM, use rbenv as this does not occur with rbenv.


Fix building aarch64 linux wheel

Closes https://github.com/kylebarron/arro3/issues/276.
The core issue is that ring (used by rustls) doesn't build automatically (at least with manylinux auto) for linux aarch64.
This PR changes the manylinux version for aarch64 to be manylinux_2_28.
Ref https://github.com/PyO3/maturin-action/issues/278, https://github.com/PyO3/maturin-action/issues/222

Right on, thanks for knocking this out so quickly!

@kylebarron is it possible to also publish for manylinux_2_17? Nix doesn't currently support manylinux_2_28

No, it doesn't compile on 2_17: https://github.com/kylebarron/arro3/actions/runs/12416815454/job/34666333514, https://github.com/kylebarron/arro3/pull/278.
You're welcome to make a PR to try and fix that compilation

Ah bummer! I'll take a look and try to figure something out. Thanks for pointing me to the failing build

It looks like 2_24 works, it's just 2_17 that doesn't, see #279

@kylebarron I managed to figure out a workaround in Nix. I can manually override the derivation builder for each dependency so don't need 2_17.


Remove edit button from view panel

Properties should always correspond to currently open file => redundant.

When peeking a definition, the active file changes and the button fully switches to that file, so it is not entirely redundant.


Nominate maintainers

As discussed in CC 7/10/24, we will bulk appoint a base-line set of maintainers for the org. Subsequent maintainer nominations will follow a standard nomination process to be defined by guidance published.
Please respond to this issue with your vote.
Proposed Maintainers:

Susan Shi (@susanshi)
Binbin Li (@binbin-li)
Akash Singhal (@akashsinghal)
Feynman Zhou (@FeynmanZhou)
Yi Zha (@yizha1)

I approve. thanks!

LGTM

LGTM

Approved

Closed by #8


Add scatterplot marker labels using a secondary axis

I have a bargraph, with a scatterplot over the top. The scatterplot is using a secondary axis. I would like to add labels to each point on the scatter to aid in reading the graph. I cannot see any option to turn this on globally (No scatter plot equivalent to ShowValuesAboveBars).
I can use AddText at x/y coordinates, but the x/y used are from the primary axis, not the secondary, so I can't get the text to line up against the scatter.
Help?

Hi @Terebi42,

I have a bargraph, with a scatterplot over the top

[There is] no scatter plot equivalent to ShowValuesAboveBars

This is correct. To add text at specific locations use the AddText() method.
The cookbook has some examples of this:
https://swharden.com/scottplot/cookbooks/4.1.16/category/plottable-text/#text
You may want to customize the alignment and rotation to make the labels look as good as possible:
https://swharden.com/scottplot/cookbooks/4.1.16/category/plottable-text/#text-alignment-and-rotation
Hope it helps!

Hi @Terebi42, sorry if my first answer was incomplete.

I can use AddText at x/y coordinates, but the x/y used are from the primary axis, not the secondary, so I can't get the text to line up against the scatter.

I think you can do something like this to place text using coordinates for the secondary axis:
var plt = new ScottPlot.Plot(600, 400);

// primary axis
var scatterA = plt.AddScatter(/* data */);
var myTextA = plt.AddText("hello", 5, 10);

// secondary axis
var scatterB = plt.AddScatter(/* data */);
var myTextB = plt.AddText("hello", 5, 10);
scatterB.YAxisIndex = 1;
myTextB.YAxisIndex = 1;


Server installation ERR! EINTEGRITY

I tried to run the script to install on a raspberry 3: sudo npm install -g --unsafe-perm signalk-server
I would have attached the log file but couldn't find it.  (hidden files were enabled)
This is the result:
npm WARN registry Unexpected warning for https://registry.npmjs.org/: Miscellaneous Warning EINTEGRITY: sha512-4mq9KKjaxDQcgUlFClyrn1CNwgNRxmRqvGXfAF7ON6YU07MNNzGPlQ3QUCmT3CW2kTDaEjozFE9HVSGrGANkYQ== integrity checksum failed when using sha512: wanted sha512-4mq9KKjaxDQcgUlFClyrn1CNwgNRxmRqvGXfAF7ON6YU07MNNzGPlQ3QUCmT3CW2kTDaEjozFE9HVSGrGANkYQ== but got sha512-Jao2w62xjsNLdPaXaMevBV6DfqVhKMH5EZqbL9PWGomsntbGEu5Bi84CPF3mAhXjAw5KFIhimpckSapP6YHwGw==. (7159 bytes)
npm WARN registry Using stale data from https://registry.npmjs.org/ due to a request error during revalidation.
npm ERR! code EINTEGRITY
npm ERR! errno EINTEGRITY
npm ERR! Invalid response body while trying to fetch https://registry.npmjs.org/cookie: Integrity verification failed for sha512-4mq9KKjaxDQcgUlFClyrn1CNwgNRxmRqvGXfAF7ON6YU07MNNzGPlQ3QUCmT3CW2kTDaEjozFE9HVSGrGANkYQ== (/root/.npm/_cacache/content-v2/sha512/e2/6a/bd28a8dac4341c8149450a5cab9f508dc20351c6646abc65df005ece37a614d3b30d37318f950dd0502993dc25b69130da123a33144f475521ab18036461)
npm ERR!

I tried it again with the same result.  This is a new install and I had trouble installing node-red until I found out that you had to run "sudo apt update --allow-releaseinfo-change" first due to some recennt changes.
I re ran this as well as update and upgrade and the signalK script still gives the same result.
I have installed signalK before on other boards with no problems.
Am I the only one with this problem?  If so I will start over.
Thanks,
Al

Yeah, I think there may be an issue with your npm install.
I'd say don't install node-red. The node-red server plugin has it build in anyway.
-=Scott

OK, I started with a new image on SD card and entered:  "sudo apt update --allow-releaseinfo-change"
From that point I followed the raspberry detailed instructions for Signal K install and got an error because "npm" was missing, so I entered: "sudo apt install nodejs npm"
This(npm) should probably be added to the: raspberry_pi_installation.md
After that the install script ran OK!
I never did get anything after entering: "avahi-browse -a" so after waiting awhile I used Ctrl C to exit and continued the process of installing.
SignalK  appears to have installed properly and is running, so I will close this issue.
Thanks for the help!
Al


/spawnfeature doesn't give error message if feature fails to be placed.

Instead of throwing an error message if /spawnfeature fails to place the feature, the command does nothing.
Perhaps an error message like 22w03a's would work? ("Failed to place feature")
Reproduction steps:

Go into an invalid area for a given feature (e.g. in the air for a geode)
Attempt to place the feature.
No error message is given.

whoops, meant to throw this on the fabric repo


Emissive strength property modified in place by gltf exporter.

When I export a model using the gltf2.0 exporter, materials that have emissive strength >1 seem to sometimes have their emissive strength value modified 'in place' in the model, if the material strength property 'animated' button is enabled/selected.
For example:

Set model emission strength of a material to, say, 1.
Save .blend model, inspect material, no problem.
Change emission strength to, say, 5.
Save .blend model, inspect material, no problem.
Export .glb, inspect material, oops, emission strength has changed to, say, 4.

The value it changes to seems to be a bit unpredictable, you might have to experiment with the above steps a few times to get it to happen.
This only seems to happen if the little diamond button (apparently 'animated property') next to the strength property is set to 'diamond', not set to 'dot'.
Also, I am using Blender 4.2 which I believe is fairly new so perhaps it's that.
Bye!
Mark

Hello,
I am not able to reproduce.
Can you please provide me a test file?
In your description (in 5 steps), you didn't insert any keyframes.
A test .blend file will help understand what you are trying to do.
Note that during export, we will bake animation, so any not saved interpolation value (in orange) will be lost.

OK, my fault, I just tried again and the 'diamond' next to the strength property is a 'dot' by default, I must have accidentally clicked on it when changing the property.


Added cosign plugin in the dynamic buildkite template

Desc:
Cosign plugin has been added via changes to "conf.yaml" and changes to template file. On top of it, now with a single command a user should be able to generate buildkite template for multiple plugins. The defaults should come from "conf.yaml" and the overrides for various plugins can be passed as yaml path as below.
O/P:-
Hari.Nadiminti@EUMBQTHV267VXT dynamic-buildkite-template % go run main.go
steps:
  - command: ls
    plugins:
      - equinixmetal-buildkite/cosign#v0.1.0:
          image: ghcr.io/my-project/my-image:latest
          keyless-config:
            fulcio-url: https://fulcio.sigstore.dev
            rekor-url: https://rekor.sigstore.dev
          cosign-version: v0.1.0
      - equinixmetal-buildkite/trivy#v1.18.3:
          exit-code: 0
          timeout : "5m0s"
          severity: "HIGH,CRITICAL"
          ignore-unfixed: true
          security-checks: "vuln,config"
          skip-files: ""
          skip-dirs: ""
          image-ref: ""
Hari.Nadiminti@EUMBQTHV267VXT dynamic-buildkite-template % go run main.go --overrides plugins.trivy.skip-files="x.txt,y.txt" --overrides plugins.cosign.keyless=false
steps:
  - command: ls
    plugins:
      - equinixmetal-buildkite/cosign#v0.1.0:
          image: ghcr.io/my-project/my-image:latest
          keyless : false
          keyed-config:
            key: sample-key
          cosign-version: v0.1.0
      - equinixmetal-buildkite/trivy#v1.18.3:
          exit-code: 0
          timeout : "5m0s"
          severity: "HIGH,CRITICAL"
          ignore-unfixed: true
          security-checks: "vuln,config"
          skip-files: "x.txt,y.txt"
          skip-dirs: ""
          image-ref: ""

Hari.Nadiminti@EUMBQTHV267VXT dynamic-buildkite-template % go test -v ./...
?       dynamic-buildkite-template      [no test files]
?       dynamic-buildkite-template/cmd  [no test files]
?       dynamic-buildkite-template/config       [no test files]
=== RUN   TestGenerateTrivyStep
=== RUN   TestGenerateTrivyStep/success
=== RUN   TestGenerateTrivyStep/wrong_template_path
--- PASS: TestGenerateTrivyStep (0.00s)
    --- PASS: TestGenerateTrivyStep/success (0.00s)
    --- PASS: TestGenerateTrivyStep/wrong_template_path (0.00s)
PASS
ok      dynamic-buildkite-template/generator    (cached)
=== RUN   TestGetLatestTag
=== RUN   TestGetLatestTag/PublicRepo
=== RUN   TestGetLatestTag/PublicRepo/ValidPAT
=== RUN   TestGetLatestTag/PublicRepo/InvalidPAT
=== RUN   TestGetLatestTag/PublicRepo/NoPAT
=== RUN   TestGetLatestTag/PrivateRepo
=== RUN   TestGetLatestTag/PrivateRepo/ValidPAT
=== RUN   TestGetLatestTag/PrivateRepo/InvalidPAT
=== RUN   TestGetLatestTag/PrivateRepo/NoPAT
--- PASS: TestGetLatestTag (1.33s)
    --- PASS: TestGetLatestTag/PublicRepo (0.81s)
        --- PASS: TestGetLatestTag/PublicRepo/ValidPAT (0.46s)
        --- PASS: TestGetLatestTag/PublicRepo/InvalidPAT (0.17s)
        --- PASS: TestGetLatestTag/PublicRepo/NoPAT (0.19s)
    --- PASS: TestGetLatestTag/PrivateRepo (0.51s)
        --- PASS: TestGetLatestTag/PrivateRepo/ValidPAT (0.31s)
        --- PASS: TestGetLatestTag/PrivateRepo/InvalidPAT (0.16s)
        --- PASS: TestGetLatestTag/PrivateRepo/NoPAT (0.03s)
PASS
ok      dynamic-buildkite-template/util (cached)

JIRA ticket

@hnadiminti-equinix, with this pr, we're removing all the flags with the exception of --config and --overrides?
that's actually done in commit 72700a314854c487e6e596cf5cbe7977c47e8f01: https://github.com/equinixmetal-buildkite/dynamic-buildkite-template/pull/20/commits/72700a314854c487e6e596cf5cbe7977c47e8f01#diff-688f857fa41b86c2e3e022a69cd3a3c1f8b8b47b0d8c57abba0725613d293f87L27-L36
and so we would relay and also require a presence of the config file (ie, will not work without it)
not saying this is wrong, it's actually more simple, but curious if that was the original intention with this tool?

@hnadiminti-equinix, with this pr, we're removing all the flags with the exception of --config and --overrides? that's actually done in commit 72700a3: 72700a3#diff-688f857fa41b86c2e3e022a69cd3a3c1f8b8b47b0d8c57abba0725613d293f87L27-L36 and so we would relay and also require a presence of the config file (ie, will not work without it) not saying this is wrong, it's actually more simple, but curious if that was the original intention with this tool?

Hi @prezha , Morning! "Cobra does not allow two sub commands to run at the same time for different plugins. Using the conf.yaml to have defaults makes it simple to use multiple plugins at the same time, still allowing the user to specify overrides for each plugin in the same command"

looks like there's are some issue with eg, keyless - ie, when keyless is true (as is - by default, but also when explicitly set), it does not appear in the config, but keyless-config does:
$ go run .
steps:
  - command: ls
    plugins:
      - equinixmetal-buildkite/cosign#v0.1.0:
          image: ghcr.io/my-project/my-image:latest
          keyless-config:
            fulcio-url: https://fulcio.sigstore.dev
            rekor-url: https://rekor.sigstore.dev
          cosign-version: v0.1.0
      - equinixmetal-buildkite/trivy#v1.18.3:
          exit-code: 0
          timeout : "5m0s"
          severity: "HIGH,CRITICAL"
          ignore-unfixed: true
          security-checks: "vuln,config"
          skip-files: ""
          skip-dirs: ""
          image-ref: ""%

go run main.go --overrides plugins.trivy.skip-files="x.txt,y.txt" --overrides plugins.cosign.keyless=true
steps:
  - command: ls
    plugins:
      - equinixmetal-buildkite/cosign#v0.1.0:
          image: ghcr.io/my-project/my-image:latest
          keyless-config:
            fulcio-url: https://fulcio.sigstore.dev
            rekor-url: https://rekor.sigstore.dev
          cosign-version: v0.1.0
      - equinixmetal-buildkite/trivy#v1.18.3:
          exit-code: 0
          timeout : "5m0s"
          severity: "HIGH,CRITICAL"
          ignore-unfixed: true
          security-checks: "vuln,config"
          skip-files: "x.txt,y.txt"
          skip-dirs: ""
          image-ref: ""%

i haven't checked other combinations, would be good to test them

hi @hnadiminti-equinix looks like some tests are failing, can you please have a look
$ go test -v ./...
?   	dynamic-buildkite-template	[no test files]
?   	dynamic-buildkite-template/cmd	[no test files]
?   	dynamic-buildkite-template/config	[no test files]
=== RUN   TestGenerateTrivyStep
=== RUN   TestGenerateTrivyStep/success
=== RUN   TestGenerateTrivyStep/wrong_template_path
--- PASS: TestGenerateTrivyStep (0.00s)
    --- PASS: TestGenerateTrivyStep/success (0.00s)
    --- PASS: TestGenerateTrivyStep/wrong_template_path (0.00s)
=== RUN   TestGenerateDockerMetadataStep
=== RUN   TestGenerateDockerMetadataStep/success
    common-pipeline_test.go:121: Not equal:
        expected: steps:
          - command: ls
            plugins:
              - equinixmetal-buildkite/docker-metadata#:
                  images: "[test_image]"
                  title: "test_title"
                  vendor: "test_vendor"
        actual  : steps:
          - command: ls
            plugins:
              - equinixmetal-buildkite/docker-metadata#:
                  images:
                  - "test_image"
                  title: "test_title"
                  vendor: "test_vendor"
=== RUN   TestGenerateDockerMetadataStep/wrong_template_path
--- FAIL: TestGenerateDockerMetadataStep (0.00s)
    --- FAIL: TestGenerateDockerMetadataStep/success (0.00s)
    --- PASS: TestGenerateDockerMetadataStep/wrong_template_path (0.00s)
FAIL
FAIL	dynamic-buildkite-template/generator	0.121s
=== RUN   TestGetLatestTag
=== RUN   TestGetLatestTag/PublicRepo
=== RUN   TestGetLatestTag/PublicRepo/ValidPAT
=== RUN   TestGetLatestTag/PublicRepo/InvalidPAT
=== RUN   TestGetLatestTag/PublicRepo/NoPAT
=== RUN   TestGetLatestTag/PrivateRepo
=== RUN   TestGetLatestTag/PrivateRepo/ValidPAT
=== RUN   TestGetLatestTag/PrivateRepo/InvalidPAT
=== RUN   TestGetLatestTag/PrivateRepo/NoPAT
--- PASS: TestGetLatestTag (1.27s)
    --- PASS: TestGetLatestTag/PublicRepo (0.65s)
        --- PASS: TestGetLatestTag/PublicRepo/ValidPAT (0.30s)
        --- PASS: TestGetLatestTag/PublicRepo/InvalidPAT (0.15s)
        --- PASS: TestGetLatestTag/PublicRepo/NoPAT (0.21s)
    --- PASS: TestGetLatestTag/PrivateRepo (0.63s)
        --- PASS: TestGetLatestTag/PrivateRepo/ValidPAT (0.31s)
        --- PASS: TestGetLatestTag/PrivateRepo/InvalidPAT (0.13s)
        --- PASS: TestGetLatestTag/PrivateRepo/NoPAT (0.18s)
PASS
ok  	dynamic-buildkite-template/util	1.410s
FAIL

hi @hnadiminti-equinix looks like some tests are failing, can you please have a look
$ go test -v ./...
?   	dynamic-buildkite-template	[no test files]
?   	dynamic-buildkite-template/cmd	[no test files]
?   	dynamic-buildkite-template/config	[no test files]
=== RUN   TestGenerateTrivyStep
=== RUN   TestGenerateTrivyStep/success
=== RUN   TestGenerateTrivyStep/wrong_template_path
--- PASS: TestGenerateTrivyStep (0.00s)
    --- PASS: TestGenerateTrivyStep/success (0.00s)
    --- PASS: TestGenerateTrivyStep/wrong_template_path (0.00s)
=== RUN   TestGenerateDockerMetadataStep
=== RUN   TestGenerateDockerMetadataStep/success
    common-pipeline_test.go:121: Not equal:
        expected: steps:
          - command: ls
            plugins:
              - equinixmetal-buildkite/docker-metadata#:
                  images: "[test_image]"
                  title: "test_title"
                  vendor: "test_vendor"
        actual  : steps:
          - command: ls
            plugins:
              - equinixmetal-buildkite/docker-metadata#:
                  images:
                  - "test_image"
                  title: "test_title"
                  vendor: "test_vendor"
=== RUN   TestGenerateDockerMetadataStep/wrong_template_path
--- FAIL: TestGenerateDockerMetadataStep (0.00s)
    --- FAIL: TestGenerateDockerMetadataStep/success (0.00s)
    --- PASS: TestGenerateDockerMetadataStep/wrong_template_path (0.00s)
FAIL
FAIL	dynamic-buildkite-template/generator	0.121s
=== RUN   TestGetLatestTag
=== RUN   TestGetLatestTag/PublicRepo
=== RUN   TestGetLatestTag/PublicRepo/ValidPAT
=== RUN   TestGetLatestTag/PublicRepo/InvalidPAT
=== RUN   TestGetLatestTag/PublicRepo/NoPAT
=== RUN   TestGetLatestTag/PrivateRepo
=== RUN   TestGetLatestTag/PrivateRepo/ValidPAT
=== RUN   TestGetLatestTag/PrivateRepo/InvalidPAT
=== RUN   TestGetLatestTag/PrivateRepo/NoPAT
--- PASS: TestGetLatestTag (1.27s)
    --- PASS: TestGetLatestTag/PublicRepo (0.65s)
        --- PASS: TestGetLatestTag/PublicRepo/ValidPAT (0.30s)
        --- PASS: TestGetLatestTag/PublicRepo/InvalidPAT (0.15s)
        --- PASS: TestGetLatestTag/PublicRepo/NoPAT (0.21s)
    --- PASS: TestGetLatestTag/PrivateRepo (0.63s)
        --- PASS: TestGetLatestTag/PrivateRepo/ValidPAT (0.31s)
        --- PASS: TestGetLatestTag/PrivateRepo/InvalidPAT (0.13s)
        --- PASS: TestGetLatestTag/PrivateRepo/NoPAT (0.18s)
PASS
ok  	dynamic-buildkite-template/util	1.410s
FAIL

That was my bad...it's now fixed and all test cases are being passed.
Can you please check...Thanks @prezha

if run as-is, i think it still might have several issues - eg:

where will the COSIGN_KEY_SECRET be stored, ie, the COSIGN_KEY_PATH is not defined?
COSIGN_KEY_SECRET : test-secret, COSIGN_PASSWORD : passwd, GITHUB_TOKEN : token, key: sample-key under the keyed-config, image: ghcr.io/my-project/my-image:latest, etc. would not work - ie, should be parameterised, not generic example constant values
when defaults are used, we have:

$ go run .
steps:
  - label: ":docker: get cosign key"
    key: "getkey"
    command: |
      #!/bin/bash
      echo "\$COSIGN_KEY_SECRET" > ${COSIGN_KEY_PATH}
    plugins:
      -<EMAIL_ADDRESS>          parameters:
            COSIGN_KEY_SECRET : test-secret
            COSIGN_PASSWORD : passwd
            GITHUB_TOKEN : token
      - equinixmetal-buildkite/cosign#v0.1.0:
          image: ghcr.io/my-project/my-image:latest
          keyless : false
          keyed-config:
            key: sample-key
          cosign-version: v0.1.0
      - equinixmetal-buildkite/trivy#v1.18.3:
          exit-code: 0
          timeout : "5m0s"
          severity: "HIGH,CRITICAL"
          ignore-unfixed: true
          security-checks: "vuln,config"
          skip-files: ""
          skip-dirs: ""
          image-ref: ""
      - equinixmetal-buildkite/docker-metadata#v1.0.0:
          images:
          - "my-org/my-image"
          - "image2"
          extra_tags:
          - "latest"
          - "tag2"
          title: "sample"
          vendor: "abc"
          debug: "true"

then, if user wants to use keyless for cosign, the keyless: true param is missing from the output yaml conf (could be considered the default), but also the keyless-config is still present and COSIGN_KEY_SECRET and COSIGN_PASSWORD are still "pulled" from ssm, which should not be needed (ie, only needed for the keyed and not for the keyless signing)? eg:
go run main.go --overrides plugins.cosign.keyless=true
steps:
  - label: ":docker: get cosign key"
    key: "getkey"
    command: |
      #!/bin/bash
      echo "\$COSIGN_KEY_SECRET" > ${COSIGN_KEY_PATH}
    plugins:
      -<EMAIL_ADDRESS>          parameters:
            COSIGN_KEY_SECRET : test-secret
            COSIGN_PASSWORD : passwd
            GITHUB_TOKEN : token
      - equinixmetal-buildkite/cosign#v0.1.0:
          image: ghcr.io/my-project/my-image:latest
          keyless-config:
            fulcio-url: https://fulcio.sigstore.dev
            rekor-url: https://rekor.sigstore.dev
          cosign-version: v0.1.0
      - equinixmetal-buildkite/trivy#v1.18.3:
          exit-code: 0
          timeout : "5m0s"
          severity: "HIGH,CRITICAL"
          ignore-unfixed: true
          security-checks: "vuln,config"
          skip-files: ""
          skip-dirs: ""
          image-ref: ""
      - equinixmetal-buildkite/docker-metadata#v1.0.0:
          images:
          - "my-org/my-image"
          - "image2"
          extra_tags:
          - "latest"
          - "tag2"
          title: "sample"
          vendor: "abc"
          debug: "true"

if run as-is, i think it still might have several issues - eg:

where will the COSIGN_KEY_SECRET be stored, ie, the COSIGN_KEY_PATH is not defined?
COSIGN_KEY_SECRET : test-secret, COSIGN_PASSWORD : passwd, GITHUB_TOKEN : token, key: sample-key under the keyed-config, image: ghcr.io/my-project/my-image:latest, etc. would not work - ie, should be parameterised, not generic example constant values?
what the GITHUB_TOKEN is used for here, ie, why we have it in the generated template?
when defaults are used, we have:

$ go run .
steps:
  - label: ":docker: get cosign key"
    key: "getkey"
    command: |
      #!/bin/bash
      echo "\$COSIGN_KEY_SECRET" > ${COSIGN_KEY_PATH}
    plugins:
      -<EMAIL_ADDRESS>          parameters:
            COSIGN_KEY_SECRET : test-secret
            COSIGN_PASSWORD : passwd
            GITHUB_TOKEN : token
      - equinixmetal-buildkite/cosign#v0.1.0:
          image: ghcr.io/my-project/my-image:latest
          keyless : false
          keyed-config:
            key: sample-key
          cosign-version: v0.1.0
      - equinixmetal-buildkite/trivy#v1.18.3:
          exit-code: 0
          timeout : "5m0s"
          severity: "HIGH,CRITICAL"
          ignore-unfixed: true
          security-checks: "vuln,config"
          skip-files: ""
          skip-dirs: ""
          image-ref: ""
      - equinixmetal-buildkite/docker-metadata#v1.0.0:
          images:
          - "my-org/my-image"
          - "image2"
          extra_tags:
          - "latest"
          - "tag2"
          title: "sample"
          vendor: "abc"
          debug: "true"

then, if user wants to use keyless for cosign, the keyless: true param is missing from the output yaml conf (could be considered the default), but also the keyless-config is still present and COSIGN_KEY_SECRET and COSIGN_PASSWORD are still "pulled" from ssm, which should not be needed (ie, only needed for the keyed and not for the keyless signing)? eg:
go run main.go --overrides plugins.cosign.keyless=true
steps:
  - label: ":docker: get cosign key"
    key: "getkey"
    command: |
      #!/bin/bash
      echo "\$COSIGN_KEY_SECRET" > ${COSIGN_KEY_PATH}
    plugins:
      -<EMAIL_ADDRESS>          parameters:
            COSIGN_KEY_SECRET : test-secret
            COSIGN_PASSWORD : passwd
            GITHUB_TOKEN : token
      - equinixmetal-buildkite/cosign#v0.1.0:
          image: ghcr.io/my-project/my-image:latest
          keyless-config:
            fulcio-url: https://fulcio.sigstore.dev
            rekor-url: https://rekor.sigstore.dev
          cosign-version: v0.1.0
      - equinixmetal-buildkite/trivy#v1.18.3:
          exit-code: 0
          timeout : "5m0s"
          severity: "HIGH,CRITICAL"
          ignore-unfixed: true
          security-checks: "vuln,config"
          skip-files: ""
          skip-dirs: ""
          image-ref: ""
      - equinixmetal-buildkite/docker-metadata#v1.0.0:
          images:
          - "my-org/my-image"
          - "image2"
          extra_tags:
          - "latest"
          - "tag2"
          title: "sample"
          vendor: "abc"
          debug: "true"

if run as-is, i think it still might have several issues - eg:

where will the COSIGN_KEY_SECRET be stored, ie, the COSIGN_KEY_PATH is not defined?
COSIGN_KEY_SECRET : test-secret, COSIGN_PASSWORD : passwd, GITHUB_TOKEN : token, key: sample-key under the keyed-config, image: ghcr.io/my-project/my-image:latest, etc. would not work - ie, should be parameterised, not generic example constant values?
what the GITHUB_TOKEN is used for here, ie, why we have it in the generated template?
when defaults are used, we have:

$ go run .
steps:
  - label: ":docker: get cosign key"
    key: "getkey"
    command: |
      #!/bin/bash
      echo "\$COSIGN_KEY_SECRET" > ${COSIGN_KEY_PATH}
    plugins:
      -<EMAIL_ADDRESS>          parameters:
            COSIGN_KEY_SECRET : test-secret
            COSIGN_PASSWORD : passwd
            GITHUB_TOKEN : token
      - equinixmetal-buildkite/cosign#v0.1.0:
          image: ghcr.io/my-project/my-image:latest
          keyless : false
          keyed-config:
            key: sample-key
          cosign-version: v0.1.0
      - equinixmetal-buildkite/trivy#v1.18.3:
          exit-code: 0
          timeout : "5m0s"
          severity: "HIGH,CRITICAL"
          ignore-unfixed: true
          security-checks: "vuln,config"
          skip-files: ""
          skip-dirs: ""
          image-ref: ""
      - equinixmetal-buildkite/docker-metadata#v1.0.0:
          images:
          - "my-org/my-image"
          - "image2"
          extra_tags:
          - "latest"
          - "tag2"
          title: "sample"
          vendor: "abc"
          debug: "true"

then, if user wants to use keyless for cosign, the keyless: true param is missing from the output yaml conf (could be considered the default), but also the keyless-config is still present and COSIGN_KEY_SECRET and COSIGN_PASSWORD are still "pulled" from ssm, which should not be needed (ie, only needed for the keyed and not for the keyless signing)? eg:
go run main.go --overrides plugins.cosign.keyless=true
steps:
  - label: ":docker: get cosign key"
    key: "getkey"
    command: |
      #!/bin/bash
      echo "\$COSIGN_KEY_SECRET" > ${COSIGN_KEY_PATH}
    plugins:
      -<EMAIL_ADDRESS>          parameters:
            COSIGN_KEY_SECRET : test-secret
            COSIGN_PASSWORD : passwd
            GITHUB_TOKEN : token
      - equinixmetal-buildkite/cosign#v0.1.0:
          image: ghcr.io/my-project/my-image:latest
          keyless-config:
            fulcio-url: https://fulcio.sigstore.dev
            rekor-url: https://rekor.sigstore.dev
          cosign-version: v0.1.0
      - equinixmetal-buildkite/trivy#v1.18.3:
          exit-code: 0
          timeout : "5m0s"
          severity: "HIGH,CRITICAL"
          ignore-unfixed: true
          security-checks: "vuln,config"
          skip-files: ""
          skip-dirs: ""
          image-ref: ""
      - equinixmetal-buildkite/docker-metadata#v1.0.0:
          images:
          - "my-org/my-image"
          - "image2"
          extra_tags:
          - "latest"
          - "tag2"
          title: "sample"
          vendor: "abc"
          debug: "true"

I fixed and updated the code; could you perhaps verify and let me know. The parameterisation will be updated after I test the job in the buildkite CI pipeline. Thank you!


Maybe mention intero

It might be worth mentioning intero, perhaps in tools.

I've thought about it. It works great for simple projects but it's a bit slow on the projects I work on in my day job, so I'm a little hesitant for now. I won't close this as I'd like to. Maybe after they do the upcoming bug clean up pass?


libgpg-error fails to cross-compile

Somewhere between the current nixpkgs-unstable channel and master libgpg-error cross-compilation broke.
It's a dependency of gpg, and systemd is usually compiled with a minimal gpg, to verify container image signatures - meaning this currently breaks NixOS cross. It's probably in the dependency closure of a lot of other stuff, so fixing it is probably better than building a systemd without a minimal gpg ;-)
https://github.com/NixOS/nixpkgs/pull/89219 seems unrelated - while it looks like this might have improve things, it was targeted to staging, is currently in staging-next, but not yet in master - so it broke before that, and still fails with it.
I'm currently bisecting this, but wanted to open a tracking issue, in case anyone else is running into this.
cc @NixOS/exotic-platform-maintainers

This has briefly been discussed in #nixos-dev yesterday: https://logs.nix.samueldr.com/nixos-dev/2020-06-17#3621161;

I'd be not so sure that it wasn't #89219. Reverting 683004d092e6c4b5dc68d40684e8ecf65c87c1fc on top of nixos-unstable makes pkgsCross.aarch64-multiplatform.libgpgerror buildable for me.
According to their release notes they had cross fixes in both 1.37 and 1.38.

Hmm, my bisecting didn't get me too far:
git bisect start
# good: [9d0c3ffe6783d59b427d018e8341e0084737fde9] Merge pull request #90304 from r-ryantm/auto-update/binaryen
git bisect good 9d0c3ffe6783d59b427d018e8341e0084737fde9
# bad: [1357624fa9edff4add4c535c0606eb673f29966f] Merge pull request #90716 from doronbehar/update-zoom
git bisect bad 1357624fa9edff4add4c535c0606eb673f29966f
# bad: [b6108e021b557d4b9be5fb5927c12efa7f9ba419] Merge pull request #89327 from mweinelt/go-neb-module
git bisect bad b6108e021b557d4b9be5fb5927c12efa7f9ba419
# bad: [a038553c8b8cb108ecba63f77ac0f04917d29672] Merge #89901: dbus: 1.12.16 -> 1.12.18 (security)
git bisect bad a038553c8b8cb108ecba63f77ac0f04917d29672
# bad: [41dba08dd0ca5df86616f1857f8d01e715e7ceba] python: bugsnag: 3.6.0 -> 3.6.1
git bisect bad 41dba08dd0ca5df86616f1857f8d01e715e7ceba
# bad: [a337c44db65bdb7838bf1b1875631879b3a820c9] python3Minimal: disable optimizations
git bisect bad a337c44db65bdb7838bf1b1875631879b3a820c9
# skip: [af2dd0c798101dc112108859a3c427979d4802fc] Revert "Revert "Merge pull request #78910 from serokell/libarchive-zstd""
git bisect skip af2dd0c798101dc112108859a3c427979d4802fc
# skip: [7d5751412795e3a58cad82ac945eaa30377df746] meson: fix hash after incorrect merge
git bisect skip 7d5751412795e3a58cad82ac945eaa30377df746
# skip: [b76c308ecdc7a90179b49a55abca0058e481cb5b] Merge staging-next into staging
git bisect skip b76c308ecdc7a90179b49a55abca0058e481cb5b
# skip: [1c7d22e663ebbf76bf2a939994317a43dceb4c3a] ghostscript: 9.50 -> 9.52
git bisect skip 1c7d22e663ebbf76bf2a939994317a43dceb4c3a
# skip: [b7ff7465401257e9b0814bb68937a494c58de538] python3: now points to python38
git bisect skip b7ff7465401257e9b0814bb68937a494c58de538
# skip: [e761cfe50ac6a9204af703e2bb91e89ba521db02] libexif: 0.6.21 -> 0.6.22
git bisect skip e761cfe50ac6a9204af703e2bb91e89ba521db02
# skip: [bcf03e8cd2d1fb3a7d1dbbfee960dd47b36fc7bb] Revert "cpython: Optimize dynamic symbol tables, for a 6% speedup."
git bisect skip bcf03e8cd2d1fb3a7d1dbbfee960dd47b36fc7bb
# skip: [0f2e569505597fc700049d06eeb54b3cf7656582] linux: CONFIG_MOUSE_ELAN_I2C_SMBUS=y
git bisect skip 0f2e569505597fc700049d06eeb54b3cf7656582
# skip: [6bfabdf1a22300731b63b2177caef9f232afab1a] openh264: 2.1.0 -> 2.1.1
git bisect skip 6bfabdf1a22300731b63b2177caef9f232afab1a
# skip: [55258867b922839d8349a2483ceeecf81703907c] pcre2: 10.34 -> 10.35
git bisect skip 55258867b922839d8349a2483ceeecf81703907c
# skip: [34aff7f6973743a5e6e672c01016c4280d471453] treewide: strip more things in cross
git bisect skip 34aff7f6973743a5e6e672c01016c4280d471453
# skip: [818fa358c83864c654f5e4c4d842915e7eb30237] Merge pull request #87954 from marsam/update-postgresql
git bisect skip 818fa358c83864c654f5e4c4d842915e7eb30237
# skip: [f8a8243bd3127ba9c6090d57f43d979389c1653c] cpython: Use --enable-optimizations, for a 16% speedup.
git bisect skip f8a8243bd3127ba9c6090d57f43d979389c1653c
# skip: [683004d092e6c4b5dc68d40684e8ecf65c87c1fc] libgpgerror: 1.36 -> 1.38
git bisect skip 683004d092e6c4b5dc68d40684e8ecf65c87c1fc
# skip: [68513786143e7698ad5dfab4e18b14b44b090822] postgresql_9_6: 9.6.17 -> 9.6.18
git bisect skip<PHONE_NUMBER>3e7698ad5dfab4e18b14b44b090822
# skip: [62ee86086c611e2209e11615cfc5fa96384ef468] libssh2: fix broken patch hash
git bisect skip 62ee86086c611e2209e11615cfc5fa96384ef468
# skip: [01377fc6ef7ab5092fd96a02a660c69805bbdc31] Merge pull request #87435 from matthewbauer/strip-more-in-cross
git bisect skip 01377fc6ef7ab5092fd96a02a660c69805bbdc31
# skip: [d89c58a012e4a8bc2d408bbc69a8d4bb1b265c44] perl: 5.30.2 -> 5.30.3
git bisect skip d89c58a012e4a8bc2d408bbc69a8d4bb1b265c44
# skip: [52c04b0347d60064f11ae8430e5a6c57a30ec831] cpython: Use autoreconfHook to rebuild configure script.
git bisect skip 52c04b0347d60064f11ae8430e5a6c57a30ec831
# skip: [c5669b0e475e7876eb96a3b3b4c95be049d4542c] Merge pull request #89441 from flokli/systemd-systemd.pc-system-user
git bisect skip c5669b0e475e7876eb96a3b3b4c95be049d4542c
# skip: [35d2d4d223d8993df12b70ffb312ead9f44cbf72] postgresql_10: 10.12 -> 10.13
git bisect skip 35d2d4d223d8993df12b70ffb312ead9f44cbf72
# skip: [b7b7da0521bbddf5725ff6259f51845de5f03311] python3Packages.cython: 0.29.14 -> 0.29.19
git bisect skip b7b7da0521bbddf5725ff6259f51845de5f03311
# good: [480c8d199166b2f8cd20e6e245d8a019329ec466] cpython: Optimize dynamic symbol tables, for a 6% speedup.
git bisect good 480c8d199166b2f8cd20e6e245d8a019329ec466
# skip: [073c37e06575f69be921840ca53c0a08a1793662] Merge pull request #89324 from doronbehar/libgme-gcc-ref
git bisect skip 073c37e06575f69be921840ca53c0a08a1793662
# skip: [3d2010311fd2280728dd404d4157086222a8c57e] gdb: 9.1 -> 9.2
git bisect skip 3d2010311fd2280728dd404d4157086222a8c57e
# skip: [3f08d642feb52ec08b09cff2ef668f3753a1803a] glibc: patch CVE-2020-1752
git bisect skip 3f08d642feb52ec08b09cff2ef668f3753a1803a
# skip: [ac0716aa6193d6ad72d255de38c9d0a6077ce8ee] iproute: 5.6.0 -> 5.7.0
git bisect skip ac0716aa6193d6ad72d255de38c9d0a6077ce8ee
# skip: [070c330f9b891513d61d2e3b8944bebc80850190] postgresql_11: 11.7 -> 11.8
git bisect skip 070c330f9b891513d61d2e3b8944bebc80850190
# skip: [da33b3e00a13bb41314e1c4cfdcc1c830a6a5fc6] Merge pull request #88266 from r-ryantm/auto-update/btrfs-progs
git bisect skip da33b3e00a13bb41314e1c4cfdcc1c830a6a5fc6
# skip: [c2039e1901aca58527d8c1a3206accac3b8482cb] mesa: make more things optional (#87438)
git bisect skip c2039e1901aca58527d8c1a3206accac3b8482cb
# skip: [3b1b4fde0cba48860c2db5dca0e39e6c3233a9c1] systemd: systemd.pc: fix systemdsystemunitpath and systemduserunitpath
git bisect skip 3b1b4fde0cba48860c2db5dca0e39e6c3233a9c1
# skip: [d1dcd310ddaf4dfcd192fb09e97c441836082cd8] jbig2dec: 0.17 -> 0.18
git bisect skip d1dcd310ddaf4dfcd192fb09e97c441836082cd8
# skip: [cf657dc584e296b629ac037aab583002b11166cf] libgme: Don't reference gcc-unwrapped
git bisect skip cf657dc584e296b629ac037aab583002b11166cf
# skip: [a2be64bf13bf23c69f5e67401bab96408cfd75cb] Merge pull request #84072 from gnprice/python-build
git bisect skip a2be64bf13bf23c69f5e67401bab96408cfd75cb
# skip: [51fd4ebc6ac7ebbe2ae1a785de955edbb816c9e8] Merge pull request #88842 from r-ryantm/auto-update/openh264
git bisect skip 51fd4ebc6ac7ebbe2ae1a785de955edbb816c9e8
# skip: [d2d070015b6daefc7dd5428b88cbfdca5de8d562] python: coverage: 4.5.4 -> 5.1
git bisect skip d2d070015b6daefc7dd5428b88cbfdca5de8d562
# skip: [490cce07a5ed11b0fba13b739a5246bf12991513] postgresql_12: 12.2 -> 12.3
git bisect skip 490cce07a5ed11b0fba13b739a5246bf12991513
# skip: [3ea0c1720086b247d2af54f8b99f142c48aae4a8] postgresql_9_5: 9.5.21 -> 9.5.22
git bisect skip 3ea0c1720086b247d2af54f8b99f142c48aae4a8
# skip: [54db65586179599a5a2b3dabff168523339f8bf6] btrfs-progs: 5.6 -> 5.6.1
git bisect skip 54db65586179599a5a2b3dabff168523339f8bf6
# only skipped commits left to test
# possible first bad commit: [a337c44db65bdb7838bf1b1875631879b3a820c9] python3Minimal: disable optimizations
# possible first bad commit: [bcf03e8cd2d1fb3a7d1dbbfee960dd47b36fc7bb] Revert "cpython: Optimize dynamic symbol tables, for a 6% speedup."
# possible first bad commit: [a2be64bf13bf23c69f5e67401bab96408cfd75cb] Merge pull request #84072 from gnprice/python-build
# possible first bad commit: [d2d070015b6daefc7dd5428b88cbfdca5de8d562] python: coverage: 4.5.4 -> 5.1
# possible first bad commit: [1c7d22e663ebbf76bf2a939994317a43dceb4c3a] ghostscript: 9.50 -> 9.52
# possible first bad commit: [d1dcd310ddaf4dfcd192fb09e97c441836082cd8] jbig2dec: 0.17 -> 0.18
# possible first bad commit: [e761cfe50ac6a9204af703e2bb91e89ba521db02] libexif: 0.6.21 -> 0.6.22
# possible first bad commit: [0f2e569505597fc700049d06eeb54b3cf7656582] linux: CONFIG_MOUSE_ELAN_I2C_SMBUS=y
# possible first bad commit: [55258867b922839d8349a2483ceeecf81703907c] pcre2: 10.34 -> 10.35
# possible first bad commit: [3d2010311fd2280728dd404d4157086222a8c57e] gdb: 9.1 -> 9.2
# possible first bad commit: [683004d092e6c4b5dc68d40684e8ecf65c87c1fc] libgpgerror: 1.36 -> 1.38
# possible first bad commit: [62ee86086c611e2209e11615cfc5fa96384ef468] libssh2: fix broken patch hash
# possible first bad commit: [d89c58a012e4a8bc2d408bbc69a8d4bb1b265c44] perl: 5.30.2 -> 5.30.3
# possible first bad commit: [b7b7da0521bbddf5725ff6259f51845de5f03311] python3Packages.cython: 0.29.14 -> 0.29.19
# possible first bad commit: [ac0716aa6193d6ad72d255de38c9d0a6077ce8ee] iproute: 5.6.0 -> 5.7.0
# possible first bad commit: [b7ff7465401257e9b0814bb68937a494c58de538] python3: now points to python38
# possible first bad commit: [7d5751412795e3a58cad82ac945eaa30377df746] meson: fix hash after incorrect merge
# possible first bad commit: [af2dd0c798101dc112108859a3c427979d4802fc] Revert "Revert "Merge pull request #78910 from serokell/libarchive-zstd""
# possible first bad commit: [b76c308ecdc7a90179b49a55abca0058e481cb5b] Merge staging-next into staging
# possible first bad commit: [073c37e06575f69be921840ca53c0a08a1793662] Merge pull request #89324 from doronbehar/libgme-gcc-ref
# possible first bad commit: [c5669b0e475e7876eb96a3b3b4c95be049d4542c] Merge pull request #89441 from flokli/systemd-systemd.pc-system-user
# possible first bad commit: [818fa358c83864c654f5e4c4d842915e7eb30237] Merge pull request #87954 from marsam/update-postgresql
# possible first bad commit: [da33b3e00a13bb41314e1c4cfdcc1c830a6a5fc6] Merge pull request #88266 from r-ryantm/auto-update/btrfs-progs
# possible first bad commit: [3b1b4fde0cba48860c2db5dca0e39e6c3233a9c1] systemd: systemd.pc: fix systemdsystemunitpath and systemduserunitpath
# possible first bad commit: [cf657dc584e296b629ac037aab583002b11166cf] libgme: Don't reference gcc-unwrapped
# possible first bad commit: [51fd4ebc6ac7ebbe2ae1a785de955edbb816c9e8] Merge pull request #88842 from r-ryantm/auto-update/openh264
# possible first bad commit: [3f08d642feb52ec08b09cff2ef668f3753a1803a] glibc: patch CVE-2020-1752
# possible first bad commit: [c2039e1901aca58527d8c1a3206accac3b8482cb] mesa: make more things optional (#87438)
# possible first bad commit: [01377fc6ef7ab5092fd96a02a660c69805bbdc31] Merge pull request #87435 from matthewbauer/strip-more-in-cross
# possible first bad commit: [6bfabdf1a22300731b63b2177caef9f232afab1a] openh264: 2.1.0 -> 2.1.1
# possible first bad commit: [54db65586179599a5a2b3dabff168523339f8bf6] btrfs-progs: 5.6 -> 5.6.1
# possible first bad commit: [490cce07a5ed11b0fba13b739a5246bf12991513] postgresql_12: 12.2 -> 12.3
# possible first bad commit: [070c330f9b891513d61d2e3b8944bebc80850190] postgresql_11: 11.7 -> 11.8
# possible first bad commit: [35d2d4d223d8993df12b70ffb312ead9f44cbf72] postgresql_10: 10.12 -> 10.13
# possible first bad commit: [68513786143e7698ad5dfab4e18b14b44b090822] postgresql_9_6: 9.6.17 -> 9.6.18
# possible first bad commit: [3ea0c1720086b247d2af54f8b99f142c48aae4a8] postgresql_9_5: 9.5.21 -> 9.5.22
# possible first bad commit: [34aff7f6973743a5e6e672c01016c4280d471453] treewide: strip more things in cross

I git bisect skiped all other build failures that weren't exactly the one as found here.
There are only 'skip'ped commits left to test.
The first bad commit could be any of:
073c37e06575f69be921840ca53c0a08a1793662
b76c308ecdc7a90179b49a55abca0058e481cb5b
af2dd0c798101dc112108859a3c427979d4802fc
7d5751412795e3a58cad82ac945eaa30377df746
c5669b0e475e7876eb96a3b3b4c95be049d4542c
b7ff7465401257e9b0814bb68937a494c58de538
818fa358c83864c654f5e4c4d842915e7eb30237
ac0716aa6193d6ad72d255de38c9d0a6077ce8ee
b7b7da0521bbddf5725ff6259f51845de5f03311
d89c58a012e4a8bc2d408bbc69a8d4bb1b265c44
62ee86086c611e2209e11615cfc5fa96384ef468
683004d092e6c4b5dc68d40684e8ecf65c87c1fc
3d2010311fd2280728dd404d4157086222a8c57e
55258867b922839d8349a2483ceeecf81703907c
da33b3e00a13bb41314e1c4cfdcc1c830a6a5fc6
0f2e569505597fc700049d06eeb54b3cf7656582
3b1b4fde0cba48860c2db5dca0e39e6c3233a9c1
cf657dc584e296b629ac037aab583002b11166cf
51fd4ebc6ac7ebbe2ae1a785de955edbb816c9e8
e761cfe50ac6a9204af703e2bb91e89ba521db02
490cce07a5ed11b0fba13b739a5246bf12991513
d1dcd310ddaf4dfcd192fb09e97c441836082cd8
070c330f9b891513d61d2e3b8944bebc80850190
1c7d22e663ebbf76bf2a939994317a43dceb4c3a
3f08d642feb52ec08b09cff2ef668f3753a1803a
35d2d4d223d8993df12b70ffb312ead9f44cbf72
c2039e1901aca58527d8c1a3206accac3b8482cb
d2d070015b6daefc7dd5428b88cbfdca5de8d562
01377fc6ef7ab5092fd96a02a660c69805bbdc31
68513786143e7698ad5dfab4e18b14b44b090822
a2be64bf13bf23c69f5e67401bab96408cfd75cb
34aff7f6973743a5e6e672c01016c4280d471453
3ea0c1720086b247d2af54f8b99f142c48aae4a8
54db65586179599a5a2b3dabff168523339f8bf6
6bfabdf1a22300731b63b2177caef9f232afab1a
bcf03e8cd2d1fb3a7d1dbbfee960dd47b36fc7bb
a337c44db65bdb7838bf1b1875631879b3a820c9
We cannot bisect more!

@Ericson2314 did you get any further?

[clever@amd-nixos:~/apps/nixpkgs-gpg]$ git bisect log
git bisect start
# bad: [f7214facbf5668e2957fd763041b6a4ef990a10b] Merge pull request #74487 from oxalica/cargo-insta
git bisect bad f7214facbf5668e2957fd763041b6a4ef990a10b
# good: [45e01e508a792077c77067467e07bce757932fb6] Merge pull request #78716 from Ma27/bump-matrix-synapse
git bisect good 45e01e508a792077c77067467e07bce757932fb6
# good: [44e56c2503d0bfa60e200f9a0dfc1c12d0219b28] kmon: 1.0.0 -> 1.0.1
git bisect good 44e56c2503d0bfa60e200f9a0dfc1c12d0219b28
# good: [8a2688fbdbed0fd16f8f8644d3f4a6b9e993b41c] python3Packages.google-cloud-iot: 0.3.0 -> 0.3.1
git bisect good 8a2688fbdbed0fd16f8f8644d3f4a6b9e993b41c
# good: [0f114432d4a9399e0b225d5be1599c7ebc5e2772] Merge pull request #89193 from zowoq/minikube
git bisect good 0f114432d4a9399e0b225d5be1599c7ebc5e2772
# good: [9dd9bc7bcc2a54f7dc0cb23cef701439dfb9d0ca] linux: fix kernel config options
git bisect good 9dd9bc7bcc2a54f7dc0cb23cef701439dfb9d0ca
# bad: [6857bccf12e1b55b75e22342368feef22c78d7b9] Merge #89438: firefox updates (into staging-next)
git bisect bad 6857bccf12e1b55b75e22342368feef22c78d7b9
# good: [3437d3c64fd7578651d2695f9c43b4c972dfa9a5] Merge pull request #90154 from adisbladis/gimp-2_10_20
git bisect good 3437d3c64fd7578651d2695f9c43b4c972dfa9a5
# bad: [3b3d4f9dbef0e9c7258f1f66c55bdf07d6ef22b6] python: trimesh: 3.6.38 -> 3.6.43
git bisect bad 3b3d4f9dbef0e9c7258f1f66c55bdf07d6ef22b6
# bad: [5322686d537e30cd11c2bf135edb41578e570108] mailman: 3.3.0 -> 3.3.1
git bisect bad 5322686d537e30cd11c2bf135edb41578e570108

no skips in my log
but ive hit a stdenv rebuild, and need to head to bed

Yeah bisecting stuff that went to staging is a PITA. Especially if it's cross stuff.
I recognised that 683004d092e6c4b5dc68d40684e8ecf65c87c1fc is part of your list of possible commits. I'm pretty sure this is an upstream problem.

There are some fixes upstream since the release, trying them.

683004d092e6c4b5dc68d40684e8ecf65c87c1fc is the first bad commit
commit 683004d092e6c4b5dc68d40684e8ecf65c87c1fc
Author: zowoq<EMAIL_ADDRESS>Date:   Sun May 31 00:29:33 2020 +1000

    libgpgerror: 1.36 -> 1.38

bisect confirms that the problem did happen at a recent version update

So work took me away from this, but the main problem might be that the script that generates the header during include was not in extra dist. There was a commit fixing this, but of course fetchpatch doesn't regenerate the tarball. Just fetching that file and seeing if any of the fetchpatch is actually needed is the next thing I'm going to try.


AJ - Multi-Feature Branch: Login, Register, Unit Testing, CI/CD, Code Coverage Reporting

This pull request introduces a series of substantial changes, covering multiple features and improvements, including:

Login & Registration Functionality

Implemented user authentication and registration mechanisms.
Integrated front-end validation and back-end API connections.

Unit Testing

Added unit tests to ensure the functionality and stability of the new features.
Updated the testing suite for broader test coverage.

Continuous Integration

Integrated CI pipeline for automated testing and coverage reporting.
Ensured that the CI process reflects the latest code changes and runs tests when any branch is updated

Code Coverage Reporting

Established tools for reporting code coverage to CodeCov

Important Note:
This branch involved a complex merge and rebase process with the main branch due to the extensive scope of changes. Please review these changes carefully before approval as there were significant merge conflicts and resolutions that may impact overall system stability.
Feedback and a detailed review would be greatly appreciated. Thank you for your thorough attention!

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
:information_source: You can also turn on project coverage checks and project coverage reporting on Pull Request comment
Thanks for integrating Codecov - We've got you covered :open_umbrella:


allow main page to be viewed without redirect

some wiki option should tell the main page to be shown at / rather than redirecting to the real location

this is now the default behavior. new wiki extended option main_redirect switches back to the old behavior


Replace Mode with OrderBy

Incremental mode (working at the on-print-demand level) will be deprecated and replaced with OrderBy (working at the data source level, like Immediate mode).
Summary fields are basically window functions. You pick an aggregation function, an expression to aggregate, a filter, a partition (previously Running, now will be PartitionBy), and either absence or presence of order by (previously Mode = Incremental):
With OrderBy = false, the default, same as Immediate mode had been:
[Func](case when [Filter] then [Expression] end) over (partition by [PartitionBy band])
With OrderBy = true, same as Incremental mode had been:
[Func](case when [Filter] then [Expression] end) over (partition by [PartitionBy band] order by [child report sort])
The issue with Incremental mode is that values are added to the summary on demand as the report is printed, which can have surprising side effects because this doesn't always correspond to seeing the value in a report row. By the same token, there is no way to get partial summaries without printing all the rows. Much better to calculate everything at the data source level.

With the appearance of expression bindings, my next goal is to deprecate this project. See https://github.com/jnm2/DevExpressMods/issues/23.


Check new Spring-Boot version

Spring-Boot 1.3.2.RELEASE has been released. We should check if we can update DP to this new version

see https://github.com/canoo/dolphin-platform/pull/492


[FLINK-35182] Bump org.apache.commons:commons-compress from 1.24.0 to 1.26.1 for Flink Pulsar connector

OK, LGTM. We need to get the CI pass, finally.

@tisonkun


Version 3 is missing the --depth option

Since version 3 got released, the --depth option is no longer available.
how can I achieve that functionality in V3?

this depth feature was indeed helpful in previous versions where we can only perform scans over newer commits , any reasons why it has been removed @zricethezav ?

@arbazkiraak No reason, I simply dropped the ball on including all the features when doing the v3 rewrite. This should be added in the next minor version release.

Since gitleaks now support commit scan range feature I don't think depth feature is necessary.

@arbazkiraak the range addition is 3.1 is very cool but it is not a good replacement for the depth option. nothing beats --depth 100 in simplicity and ease of use


Update formatter version

Why was that chosen @thazhemadam ?

They weren't even the same version, I'm confused why this was ever set?

I think it was set just because those were the latest versions at the time. This is probably best set to 1 itself, so it resolves to the latest versions.


SSH public keys need to be a single line

Users have been known to submit multi-line SSH public keys, which do not work. An easy fix before #183 is implemented would be to make the SSH input box only accept a single line of input. Additionally, all trailing white space needs to be stripped.

Addressed by PR #252


Support for air quality

Can we add support for https://open-meteo.com/en/docs/air-quality-api ?
You should be able to input coordinates and get an response returned

Feature request added to Milestone for v0.2

The next merge will implement Air Quality API support


detect M1

only do changes on M1, so other devices work. FYI this can probably be improved, I'm not the best at Swift, but this should be fine for now and be functional :P.

my bad, I meant to PR to MasterOfMike's fork; I thought GitHub let you make PRs to forks... closing this :P


Improve encoding line detection

Those patches the following encoding patterns:
Encoding names that have "-" like "utf-8":
# coding: utf-8
Encoding line with Emacs style parameters:
# -- coding: cp932; indent-tabs-mode: t -
C style comment:
/* coding: utf-8 */
C++ style comment:
// coding: utf-8
I really need "C style comment" support. Without it, I get many "???" in output HTML...

Thank for for improving our encoding support :)


typo "site" corrected to "side"

READ ME PLEASE!
TL;DR: Make sure to add your changes to versioned docs
Thanks for opening a PR!
The docs cover several versions of react-navigation, and in some cases there are several files (for version 1, version 2 and etc.) that all describe a single page of the docs (eg. "Getting Started").
Please make sure that the edit you're making in docs/file-you-edited.md is also included in the file for the correct version, eg. website/versioned_docs/version-3.x/file-you-edited.md for version 3. If such file doesn't exist, please create it. :+1:

You are right, thanks for the contribution!


Lowering the message for the version check to warn

@lbustelo my original pull from master failed when I released 5.1.0 and #535 is the only missing thing in the release. I am reopening the PR on master here.

That is fine... this is not a big deal at all.


Spelling Check

Haha, thanks @jonfinley, but I ended up correcting it myself. IDK why I don't see e-mails for my repos.


Removing internal tests from hcsshim's cri-containerd tests

As we work towards further separating the cri-containerd and azcri-containerd tests, we need to first remove the internal only tests from the shim repo, as they are not being run anyways, and it makes it easier to upstream the external tests in the future.
Validated by running external package build with test run on ADO.

LGTM after addressing Hamza's comments.

revert this change

Refers to: test/cri-containerd/test-images/nanoserver-gracefultermination-repro/latest/delayed-shutdown.go:46 in ede1352. [](commit_id = ede135266b523bddd720cecd5a738b9e5296244a, deletion_comment = False)

revert this change

Refers to: test/cri-containerd/test-images/servercore-gracefultermination-repro/latest/delayed-shutdown.go:46 in ede1352. [](commit_id = ede135266b523bddd720cecd5a738b9e5296244a, deletion_comment = False)


Solve VSCode notebooks usage

Ongoing thread on Discord: VSCode notebooks seem to import modules from a different path. Can be solved by using axonasif/workspace-python:debug2 https://github.com/astrojuanlu/workshop-jupyter-kedro/commit/da77fe0638065a0d0e4f439c824b74782b63ee58
https://github.com/astrojuanlu/workshop-jupyter-kedro/blob/da77fe0638065a0d0e4f439c824b74782b63ee58/.gitpod.Dockerfile#L1

I should raise the priority of this one.


add possibility to prefix query with lang ":" params

:wave: hey, thanks a lot for this, very cool to have a rofi/translate-shell combo via a rofi mode instead of a whole separate script like other projects.
Here is a proposal that fits my usecase, figured it could be useful.
Since the whole input was passed to translate-shell as one param, there was no possibility to give from/to languages info.
This small patch allows us to specify lang now.
I'm not a C developer and I know just checking for ":" in first param is not that error-proof… Just figured I'd let you know!
Cheers,
Manu

Hey, thanks for the feedback, sorry for the low quality code, it's actually my first time writing C haha so really I don't know what I'm doing.
Updated the branch with your input. Thanks!


Crew not on ship

Crew will NEVER appear on the ship under any circumstances except current follower. May be caused by boarding and stealing another ship, but once it happens even switching to another normal ship or the frontier wont fix it.

Game Version
<IP_ADDRESS>
New Game
No
Reproduction Steps
It doesn't happen every time per evidence of others on reddit.

I have this issue currently. And if you use the console to move an NPC into the ship, they will just stand in one spot without doing anything, as if they weren’t assigned crew. You can engage in dialogue but they will not move around at all. You can ask them to be your follower, but then your current follower will leave the ship.

See duplicate issue (closed) for more detailed info https://github.com/Starfield-Community-Patch/Starfield-Community-Patch/issues/268

This was at one point fixed in SFCP, and has since been fixed by Bethesda.


Fork docstring parser and integrate it directly into pyment

For faster bug fixes and features.
For example proper reprs for DocstringParam etc.

https://github.com/JanEricNitschke/pyment/commit/b8551aa6685bec47f094b0d68345c5630457171b


Durable Objects

This tracks the implementation of Durable Objects in wrangler v2.
It currently doesn't exist, but soon will. We expect to match wrangler v1's implementation, and potentially also detect if the exports don't match (whether fewer, or more).
More details soon.

This sort of matches wrangler 1's implementation now, additionally working in local mode. There's a bunch of work to be done to make this usable and nice, but we can track that separately. Closing this issue.


feat(binding/python): allow setting append/buffer/more in write() call

Fixes https://github.com/apache/incubator-opendal/issues/3242
This PR adds named parameters to python Operator.write() AsyncOperator.write() methods, to allow append/buffer/content_type/more to be set.

This PR mostly LGTM. Needs @messense to confirm the pyi changes.


Error: error:0308010C

Error: error:0308010C:digital envelope routines::unsupported
at Generator.next ()
at new Promise ()

this is a duplicate of many issues. use node 16


Results are inconsistent with expectations

Platform: xavier. jetpack4.4.1 cuda:10.2 pytorch:1.6
the correlation_packege in this repo is for pytorch0.4 which is not suite for pytorch 1.6, so I used flownet2's (https://github.com/NVIDIA/flownet2-pytorch/tree/master/networks/correlation_package)
then everything is ok.
the output is :
/usr/local/lib/python3.6/dist-packages/torch/nn/functional.py:3384: UserWarning: Default grid_sample and affine_grid behavior has changed to align_corners=False since 1.3.0. Please specify align_corners=True if the old behavior is desired. See the documentation of grid_sample for details.
warnings.warn("Default grid_sample and affine_grid behavior has changed "
but the result is not same in the repository.

You can try the Pytorch Correlation module, which supports newer versions of PyTorch, such as 1.2 and 1.6, and refer to the issue Installing Correlation package. Also, please note the implementation of warping layer.

Hi, I had installed the Pytorch Correlation module, but I noticed that the "Pytorch Correlation module " construct is not equal with origin.
SpatialCorrelationSampler(1, 9, 1, 0, 1) <-> Correlation(pad_size=4, kernel_size=1, max_displacement=4, stride1=1, stride2=1, corr_multiply=1)

import torch
from spatial_correlation_sampler import SpatialCorrelationSampler

input1 = torch.randn(2, 32, 48, 64).cuda()
input2 = torch.randn(2, 32, 48, 64).cuda()

# define a correlation module
correlation_sampler = SpatialCorrelationSampler(1, 9, 1, 0, 1)

output = correlation_sampler(input1, input2)

# reshape output to be a 3D cost volume
b, c, h, w = input1.shape
output = output.view(b, -1, h, w) / c

print(output.shape)

I have checked that the Correlation module in my repository (PyTorch=0.4.1) and SpatialCorrelationSampler module (PyTorch=1.2) can output the same results. Remember to reshape the direct output of SpatialCorrelationSampler module and divide it by channel numbers. Also, you should check whether the input tensors are the same.


Label the production namespaces with active and standby

In order to aid visibility into the stack, it would be nice if the operator could label the 2 production namespaces to indicate which is active and which is now standby.
e.g.
lagoon.sh/active-standby=<acitve|standy>

Cross post from https://github.com/amazeeio/dioscuri/issues/23

going to leave this in dioscuri for action


Add crate badges

Closes #361.

Codecov Report

Merging #362 (07eef2d) into master (1d72b26) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #362   +/-   ##
=======================================
  Coverage   82.59%   82.60%
=======================================
  Files         162      162
  Lines       44164    44164
=======================================
+ Hits        36479    36480    +1
+ Misses       7685     7684    -1

Impacted Files
Coverage Δ

parquet/src/encodings/encoding.rs
95.04% <0.00%> (+0.19%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d72b26...07eef2d. Read the comment docs.


Add support for marshal with loads and dumps

This adds the marshal module with support for loads and dumps.
No support for load and dump for now.
I just added Serde's Serialize and Deserialize to bytecode::CodeObject (and all the needed sub structs).
The marshal module just uses bincode to encode and decode the CodeObject.

Codecov Report

Merging #1004 into master will decrease coverage by <.01%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##           master    #1004      +/-   ##
==========================================
- Coverage   65.04%   65.03%   -0.01%
==========================================
  Files          95       96       +1
  Lines       16690    16714      +24
  Branches     3707     3714       +7
==========================================
+ Hits        10856    10870      +14
- Misses       3339     3344       +5
- Partials     2495     2500       +5

Impacted Files
Coverage Δ

vm/src/bytecode.rs
58.73% <0%> (-2.88%)
:arrow_down:

parser/src/lexer.rs
80.24% <0%> (ø)
:arrow_up:

parser/src/ast.rs
14.21% <0%> (-0.08%)
:arrow_down:

vm/src/pyobject.rs
78.81% <100%> (ø)
:arrow_up:

vm/src/stdlib/marshal.rs
100% <100%> (ø)

vm/src/stdlib/mod.rs
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96df472...bd89c4e. Read the comment docs.

Fantastic change! This might pave the way for pyc files. Thanks for contributing!


feat(transformer): add esbuild comma separated target API --target=es2020,chrome58

Merge activity

Nov 8, 9:04 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.


Auto-indent after function declaration

Pressing Enter after a function declaration doesn't result in auto-indentation:
function thing()<Enter>
|
end function

Yes. This would be very nice. I was playing with this about a week ago but my regex was not complete enough.


Create example of plugin for napari viewer

Anticipating the Alfa Cohort Showcase that will take place on Thursday, April 29th, 2021 from 8:00AM-1:00PM, Pacific Time (PT), it could make sense to develop a skeleton of ITK based plugin for napari viewer that would enable the use of ITK python.

Focusing on detection and segmentation of cells, nuclei, and structures, we seek to (1) establish some of the first analysis plugins for the open source napari, (2) ensure that the platform meets the needs of these tools and their users, and (3) work together to make napari the best place to build and share image analysis methods.

Relevant references:

https://napari.org/docs/dev/plugins/index.html

@ViktorvdValk has a WIP napari plugin for itk-elastix. We could add a pointer to this along with a reference "hello world" type example.


Fix bad_ping

Fixes #11529.
The server-side bdp may trigger a window update frame, and reset the ping strike counter. It should be disabled in the bad_ping test.

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

Known issues:
Tsan C: #11383

[qps] No significant performance differences


request for another 2017 build

hi, i would like to request for another 2017 build? any chance we can get prebuilt latest please?
if you would prefer not to then ok too, i just requesting.
thank you very much rob,

Will get to it right after the 1.11 release.

aye another build would awesome. vscode now has PLAY THE FAN FARE actual proper key layouts for DVORAK users. so can now actually use cmd-/ to comment thing out. woooo

Hi @RobDangerous, any update on this?

Sorry, already worked on it but turned out to be more complicated than expected. Don't have a good estimate yet.

Finally!


python310Packages.splinter: 0.18.0 -> 0.18.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.splinter is: "Browser abstraction for web acceptance testing"
meta.homepage for python310Packages.splinter is: "https://github.com/cobrateam/splinter"
meta.changelog for python310Packages.splinter is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 0.18.1 with grep in /nix/store/98qyc7w2hlm6p7nicrh8frmga8grpbrk-python3.10-splinter-0.18.1
found 0.18.1 in filename of file in /nix/store/98qyc7w2hlm6p7nicrh8frmga8grpbrk-python3.10-splinter-0.18.1

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

2 package rebuild(s)

2 x86_64-linux rebuild(s)
2 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
python310Packages.splinter
python39Packages.splinter

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/98qyc7w2hlm6p7nicrh8frmga8grpbrk-python3.10-splinter-0.18.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.splinter https://github.com/r-ryantm/nixpkgs/archive/e57322d34e7c6728e42353681c830430f795e357.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/98qyc7w2hlm6p7nicrh8frmga8grpbrk-python3.10-splinter-0.18.1
ls -la /nix/store/98qyc7w2hlm6p7nicrh8frmga8grpbrk-python3.10-splinter-0.18.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

python310Packages.splinter
python39Packages.splinter

Maintainer pings
cc @dotlambda for testing.

Result of nixpkgs-review pr 179903 run on x86_64-linux 1

2 packages built:

python310Packages.splinter
python39Packages.splinter


Add templatetag for transition logs

Would it make sense to provide a templatetag for the transition logs, or include a section in the README?
Here's a working example:
myproject/myapp/subapp/templatetags/__init__.py:
Don't forget to register the templatetags folder as module. I've placed the templatetags inside the nested subapp that has django_fsm transitions.
myproject/myapp/templatetags/transitions.py
from django import template
from django_fsm_log.models import StateLog
register = template.Library()

@register.inclusion_tag('tx_logs.html', takes_context=False)
def tx_logs(obj):
    """Renders the FSM transition logs for an object."""
    return {'logs': [log for log in StateLog.objects.for_(obj)]}

A very basic template myproject/templates/tx_logs.html - note my user model has a field name:
{% for log in logs %}

{{ log.timestamp|date:"r" }} {{ log.state }} by {{ log.by.name }}

{% endfor %}

Feel free to place the template in a better place, just make sure to adjust the path in the inclusion tag accordingly.
In this example, I'm overriding the admin change form with a custom myproject/myapp/templates/admin/change_form.html,
inserting the logs underneath the messages block. YMMV.
{% extends "admin/change_form.html" %}
{% load i18n admin_urls transitions %} {# load templatetag library transitions #}
{% block messages %}
    {{ block.super }}
    {% if original %}
    {% tx_logs original %} {# the object "original" has a django_fsm status field #}
    {% endif %}
{% endblock %}

As I'm overriding an admin change form, the object is available in the template as original.
Happy to send PR if appropriate.

How does this play with #43, is there is overlapping ?

@ticosax #43 is a few months younger than my idea above, and looks more refined.
My example is a bare-bones MWE displaying a list of state changes. I'm using it in production in Django 1.11.
#43 works for 1.7.7 (before the breaking changes and deprecations in 1.9 and later) and touches more internals, so care has to be taken when upgrading across Django versions. I reckon it will be easier to include (being an admin mixin), while my example requires adding a custom template.
I'd be happy to see #43 merged and something along the lines of my example either included in the docs or as an actual template tag. Whatya think @ticosax?

Thank you for you feedback.
That's my impression also, that #43 is easier to integrate in a existing project. I'll will first ask the submitter if he is willing to contribute again.

Probably solved by #58

@ticosax Thanks, using it now in anger (and with pleasure)! Exactly what I needed, thanks!


v1.17.2 won't start on macos sierra 10.12.6

VSCode Version:1.17.2
OS Version: macos sierra 10.12.6

Steps to Reproduce:

code . --disable-extensions --verbose

Reproduces without extensions: No
Logs from verbose flag:
[31276:1030/164811.214784:WARNING:dns_config_service_posix.cc(154)] dns_config has unhandled options!
[main 16:48:11] Sending env to running instance...
[main 16:48:11] Sent env to running instance. Terminating...

Could be a duplicate of #37147. @Alexintosh can you check if in your developer tools the same errors appear?

I don't think so @maxibanki, in my case it won't even start.
Although code-insiders will work just fine.

https://github.com/Microsoft/vscode/issues/35527
Give insiders a try: https://code.visualstudio.com/insiders, some people report it's working for them.

@octref yes, I already said in my last comment that insiders works fine.
This issue shouldn't be closed @octref, it's not the same of #35527.

Oops, sorry.
So Code does not even start for you? Did you recently upgraded to sierra and it stopped working? Have you tried re-installing?
Meanwhile, does this look like your issue? https://github.com/Microsoft/vscode/issues/19104#issuecomment-276227392


Not running on El Capitan

I try running the image with: $ docker run -v $HOME/Documents:/home/ace/Documents:rw -v /dev/snd:/dev/snd --privileged -v /tmp/.X11-unix:/tmp/.X11-unix -e uid=$(id -u) -e gid=$(id -g) -e DISPLAY=unix$DISPLAY --rm munkie/acestreamplayer and get the following error:
docker: Error response from daemon: Mounts denied:
The path /dev/snd
is not shared from OS X and is not known to Docker.
You can configure shared paths from Docker -> Preferences... -> File Sharing.
See https://docs.docker.com/docker-for-mac/osxfs/#namespaces for more info.

I investigated a bit and the /dev/snd doesn't exist. Do you have to do something different on OSX?

@stickperson This continer is intended ti be run on linux, not OSX


Fix requests for bad image URL before view is evaluated

Fixes #69

https://docs.angularjs.org/api/ng/directive/ngSrc

Thanks @spadgett , that error msg was annoying me and was on my todo list to investigate.