Missing Update Files in PG12-v1.1.1 Release

Hi,
in the new release for PG12-v1.1.1 there is no extension update file included, only the initial installation file age--1.1.1.sql
Is that expected? How to proceed on an update here? Drop and recreate the extension?
Dropping does not seem to be a good option when there are already objects depending on the extension.
age=# alter extension age update; ERROR:  extension "age" has no update path from version "1.1.0" to version "1.1.1"
Thanks,
Dennis

To add: In the latest PG11 release the update file is also missing:
./age--1.2.0.sql ./age--0.7.0--1.0.0.sql ./age--1.0.0--1.1.0.sql ./age--0.6.0--0.7.0.sql ./age--0.5.0--0.6.0.sql

To add: In the latest PG11 release the update file is also missing:
./age--1.2.0.sql ./age--0.7.0--1.0.0.sql ./age--1.0.0--1.1.0.sql ./age--0.6.0--0.7.0.sql ./age--0.5.0--0.6.0.sql

Per the RELEASE file for PG11 there isn't an upgrade path due to a core table being extended.

There isn't a difference for PG12, though. I will need to check if it just needs an empty update file.

@guruguruguru The new draft release has the script added.

@jrgemignani thank you! yes combining the issues was not the best idea, sorry for that!

age=# \dx
List of installed extensions
Name   | Version |   Schema   |         Description
---------+---------+------------+------------------------------
age     | 1.1.0   | ag_catalog | AGE database extension
plpgsql | 1.0     | pg_catalog | PL/pgSQL procedural language
(2 rows)
age=# alter extension age update;
ALTER EXTENSION
age=# \dx
List of installed extensions
Name   | Version |   Schema   |         Description
---------+---------+------------+------------------------------
age     | 1.1.1   | ag_catalog | AGE database extension
plpgsql | 1.0     | pg_catalog | PL/pgSQL procedural language
(2 rows)
Worked now, thank you!

@guruguruguru If this has resolved the issue for you, please close it at your earliest convenience.


NetInfo Event change deprecated

hi,
your event listener NetInfo.isConnected.addEventListener('change', this.checkInternet) is deprecated will you update the module for fix this?
thanks

Hey @malikoum94, thanks for Your input!
We're open to help with the library! Feel free to send a PR :)

@Krizzu here ya go https://github.com/rauliyohmc/react-native-offline/pull/37


Add isComposing check to keydown event for users using Japanese IME with Kanji characters

I am a user of GitHub and I use a Japanese IME to input Kanji characters. However, I noticed that when using the keydown event in JavaScript, it does not always capture the correct input due to the way that the IME works.
I suggest adding an isComposing check to the keydown event, which will improve the accuracy of input detection for users using Japanese IME with Kanji characters. This will ensure that the event is only triggered once the user has finished composing their input.
Here is an example of the code modification that would need to be made:
document.addEventListener('keydown', function(e) {
  if (!e.isComposing) {
    // Perform action when input is finished composing
  }
});

I believe that this improvement would benefit many users who use a Japanese IME and would greatly improve their experience with GitHub. Thank you for considering this suggestion.

@katsumi-axis thanks for the suggestion. I am not familiar with the isComposing attribute, is that a common way to fix the issues with such keyboards?

There are many ways to do it, but given that an API is provided, it seems like one correct implementation method.
https://www.stum.de/2016/06/24/handling-ime-events-in-javascript/

document.getElementById('question-input').addEventListener("keydown", function (event) {
if (event.key == "Enter" && !event.shiftKey && !event.isComposing) {
event.preventDefault();
addFreeTextQuestion();
}
});
@gencay modify media/main.js just like this code. Thank you for the great work.

document.getElementById('question-input').addEventListener("keydown", function (event) {     if (event.key == "Enter" && !event.shiftKey && !event.isComposing) {         event.preventDefault();         addFreeTextQuestion();     } });
@gencay modify media/main.js just like this code. Thank you for the great work.

document.getElementById('question-input').addEventListener("keydown", function (event) {
    if (event.key == "Enter" && !event.shiftKey && !event.isComposing) {
        event.preventDefault();
        addFreeTextQuestion();
    }
});

@gencay modify media/main.js just like this code. Thank you for the great work.

@harley005 @katsumi-axis please check out the v3.9.5 on marketplace. This should now be fixed. Could you confirm?

@gencay I confirm it, Thank you for your great work.


Metadata: dnGrep.dnGrep version 2.9.270.0

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[X] Does your manifest conform to the 1.0 schema?

Microsoft Reviewers: Open in CodeFlow

https://github.com/microsoft/winget-pkgs/pull/22166#issuecomment-886110868

Closing these PRs since the dnGrep devs seems to have no idea how to not check for update.


Add automated regression tests

I was wondering if you could add some automated regression tests into a GitHub pipeline using something like pytest-postgresql to automatically exercise each of the enum modifying features.

Thanks so much for addressing the dependency version issue I raised so fast - I know this is a longer-term larger request.
I'm preparing for a local PyCon for the next month or so but might be able to help with this issue afterwards if you think it has merit and haven't addressed it already.

That is a good idea, I will try it out in new branch.


Need global error handler / refresh advice

In case of errors, the state of the editor can be corrupted and weird things subsequently happen. Need to create a global error handler such that such errors can be captured, logged (to a remote server also?), and then the user is prompted to refresh the editor so that they can resume editing on a known  good state.

Working on this (minus the server logging).


Remove version: Jackett.Jackett version 0.21.188

404 - release deleted
Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/Jackett/Jackett/releases/download/v0.21.188/Jackett.Installer.Windows.exe
Response Error: The remote server returned an error: (404) Not Found.
(Automated message - build 918)


CollisionShape2D Polygon Shape doesn't respect parent X/Y position coordinates

Tested versions
4.2.1 stable
System information
Godot v4.2.1.stable.mono - macOS 14.1.1 - Vulkan (Mobile) - integrated Apple M1 - Apple M1 (8 Threads)
Issue description
Godot CollisionPolygon2D doesn't respect X/Y positions applied at Node while calculating positions using _Draw method:
public override void _Draw()
{
  // Godot drawn polyline with option "Editable children" for access to localPolygon updated values
  Vector2[] localPolygon = _collisionShape.Polygon.ToArray();
  localPolygon = localPolygon.Append(localPolygon[0]).ToArray();
  DrawPolyline(localPolygon, _pathColor, 40f, true);
}

If the Polygon is created without moving X/Y axis, _collisionShape.Polygon.ToArray(); gets all X/Y value of points correctly, but if i move the Node positions X/Y, the Polygon Node doesn't listen to these values and as result draw the lines at incorrect positions.
Theres a full project with the functional issue running.
Steps to reproduce

Create a Area2D
As children of the Area2D add a CollisionPolygon2D
Attach a Polygon to the CollisionPolygon2D
Implement a Draw method using Polygon Node from the recent created CollisonPolygon2D
Move the parent CollisionPolygon2Daxis X/Y
The Polygon objects doesn't get updated with the X/Y values from it's parent Node.

Minimal reproduction project (MRP)
https://github.com/wallynm/godot-issue-collision2d

This is correct behavior, it works as intended.

CollisionPolygon2D.polygon is local to the given CollisionPolygon2D. I guess this can be clarified in the docs.
CanvasItem.draw_X methods by default draw locally to the given CanvasItem.

You would need to somehow apply a proper transform from one coordinate space to the other. E.g. by transforming all the points or (simpler) by applying an additional transform for drawing such CollisionPolygon2D-local points.
Since these are in parent-child relation you could simply use DrawSetTransformMatrix(_collisionShape.transform) before the DrawPolyline(...) call in the Area2D (this C# version might need tweaking).
In more general case: for two CanvasItems A and B being within the same canvas layer, to get a transform converting from A local coordinate space to B local coordinate space you could use B.get_global_transform().affine_inverse() * A.get_global_transform(). See also the docs.
(for transforming a single Vector2 you could use B.to_local(A.to_global(some_A_local_point)))

Fixed in: #87024


Fixes to ShadingSystemImpl::decode_connected_param

@marsupial correctly points out that we are unsafely passing
a string_view.data() into both atoi and strchr, which is unsafe because
there's no guarantee that a string_view is null-terminated. Ugh!
He proposed a fix here: https://github.com/imageworks/OpenShadingLanguage/pull/800
and there's nothing wrong with it per se, but I suspected it could be done
more simply, so this PR is my stab at it, using the OIIO::Strutil::parse_*
functions.

This is a counter-proposal to #800

LGTM

Seems to play nicely here with #801.
FWIW OIIO::Strutil::parse_int also looks to have the same issue and may parse beyond the string_view's length.
line 689:        p.remove_prefix (end-p.begin()); can throw with a std::string_view.

Oh, let me have a look at parse_int, too, then.

Ow, you are quite right. Will make a fix there...

parse_float as well...

I want to point out that this is a legit bug according to spec, but in practice in our code base the string_view's are always generated from a std::string or ustring or null-terminated char* (or a substring of one of those), so it's not a huge emergency "how did this ever work" kind of bug -- in our code, every string_view does point to (or within) a null-terminated string. So it can't crash, but it can generate wrong results if there's a string like "1234" and the string_view is referring to just the first 2 characters (should parse to 12, but will erroneously parse to 1234). I don't think we actually do this anywhere, but it's a nasty bug just waiting to happen, so I want to fix it.

I feel like this issue is very much related to the changes in https://github.com/OpenImageIO/oiio/pull/1785, so I think I'll address the primary problems with the parse functionality there.

The strchr bug was definitely creating bad results for me.
I agree the rest is a bit pedantic from what I can see in the context of OSL, but it's not to hard to imagine an exploit where OIIO (or some client of) tries parsing a well crafted string in some image header/metadata.

I agree totally!  I'm working on a robust fix for it all.


Dependencies: update PGV and API deps

Dependencies: update PGV and API deps
Additional Description:

update to PGV 0.6.1 (release notes)
update API versions to corresponding PGV and gRPC versions
Bazel build tools to 4.0.1
Zipkin API to 1.0.0
OpenTelemetry Proto to 0.9.0

Risk Level: Low
Testing:

bazel --nohome_rc test //test/...
bazel --nohome_rc test @envoy_api_canonical//test/... @envoy_api_canonical//tools/...
bazel --nohome_rc build @envoy_api_canonical//envoy/...
tools/dependency/release_dates.py api/bazel/repository_locations.bzl

Docs Changes: None required
Release Notes: None required
Signed-off-by: Michael Payne<EMAIL_ADDRESS>

/retest

after checking - it seems that this doesnt resolve the bazel pin issue
Current running Bazel is ahead of bazel-toolchains repo. Please update your pin to bazel-toolchains repo in your WORKSPACE file.

it would be great if we could resolve that somewhere


[BUG - Release] Fatal Error: PS scan timed out

Branch or Release
UE4SS - v3.0.1 Beta #0 - Git SHA #d935b5b
UE4SS Build Configuration: Game__Shipping__Win64 (MSVC)
Game and Engine Version
[2024-09-18 11:43:50] [PS] Found EngineVersion: 5.4
Describe the bug
[2024-09-18 11:44:21] Fatal Error: PS scan timed out
Mods don't work.
Mods directory
Default
To Reproduce
Steps to reproduce the behavior:

Launch game
See error in log

Expected behavior
No error
Screenshots, UE4SS Log, and .dmp file
UE4SS.log
Desktop:

OS:
Edition	Windows 11 Pro
Version	23H2
OS build	22631.4169

Additional context
Game: Everspace 2

Your bug report is wrong.
Have you read what the log says?
[PS] Failed to find FText::FText(FString&&): expected at least one value
[PS] You can supply your own AOB in 'UE4SS_Signatures/FText_Constructor.lua'

I've found signature for another UE 5.4 game. Try it out if it works for you.
UE4SS_Signatures.zip

Switched to Experimental and added the file you gave me and it worked.
Are any of the included mods required for the UE4SS itself to work properly, or can I safely disable them all and use only one game-specific lua mod?

Switched to Experimental and added the file you gave me and it worked.
Are any of the included mods required for the UE4SS itself to work properly, or can I safely disable them all and use only one game-specific lua mod?

The included mods are not required.


Automated deployments should be uniquely identifiable with tags

Benefit/Result/Outcome
Knowing which specific version of MissionLZ was deployed from some automation would benefit development teams and IT Admins.
Description
Tags on resources and resource groups will allow IT Admins and support functions to determine which resources were deployed by MLZ and what version of MLZ was used.
Acceptance Criteria

A tag identifies resources deployed by Mission Landing Zone, e.g. "MissionLandingZone"
Resources deployed via Terraform are distinct from those deployed with Bicep (maybe MissionLandingZoneTF or MissionLandingZoneARM?)
Resource groups receive the same tags

I updated the original text and acceptance criteria to refer to tags instead of resource names.

The Terraform portion of this user story is complete
Pending Bicep tagging before resolution

re-opening because the bicep tagging is not yet completed

opening once again, still need to complete the bicep portion of this user story


Mapbox error fireEvent failed: <rnmapbox_maps.RCTMGLEvent: 0x60000237f9e0> - callback is null

console.error: Mapbox error fireEvent failed: <rnmapbox_maps.RCTMGLEvent: 0x60000237f9e0> - callback is null {"level":"error","message":"fireEvent failed: <rnmapbox_maps.RCTMGLEvent: 0x60000237f9e0> - callback is null"}
construct
[native code]:0
construct
[native code]:0
_construct
construct.js:19:9
Wrapper
wrapNativeSuper.js:26:22
construct
[native code]:0
_createSuperInternal
index.bundle?platform=ios&dev=true&minify=false:29476:321
SyntheticError
index.bundle?platform=ios&dev=true&minify=false:29494:31
reactConsoleErrorHandler
ExceptionsManager.js:187:33
overrideMethod
backend.js:2134:10
overrideMethod
[native code]:0
console.error
LogBox.js:33:4
registerError
YellowBox.js:169:6
errorImpl
YellowBox.js:84:8
console.error
YellowBox.js:63:4
SphericalMercator
sphericalmercator.js:23:24

index.bundle?platform=ios&dev=true&minify=false:293517:21
emit
EventEmitter.js:189:10
__callFunction
MessageQueue.js:425:19
__guard$argument_0
MessageQueue.js:112:6
__guard
MessageQueue.js:373:10
callFunctionReturnFlushedQueue
MessageQueue.js:111:4
callFunctionReturnFlushedQueue
[native code]:0

@Rajat-verma-99 Check your UserLocation component. I fixed this issue by improving my UserLocation component.

I think this error has resurfaced due to some of the event coalescing changes in v10.0.8, and occurs whenever any function is passed to MapView for onCameraChange. Reverting to v10.0.7 fixes the issue for me.
Also of note is that we use reanimated 3, and after doing some debugging, it looks like for some reason a REAEventDispatcher is being passed around within RCTMGLMapView.swift, which is responsible for the error.

To just affirm what Michael has mentioned, I am  also seeing the same issue with anything over v10.0.8.
It doesn't seem to be particularly critical ( the application will still work properly) but it is annoying nonetheless.

We have the same issue using the latest version (10.0.15)

same in 10.0.15


Proposed 1.4.0

Closes #3162

Codecov Report

Merging #3163 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3163      +/-   ##
===========================================
- Coverage    68.94%   68.94%   -0.01%
===========================================
  Files          688      688
  Lines        55743    55743
===========================================
- Hits         38432    38431       -1
- Misses       17311    17312       +1

Impacted Files
Coverage Δ

src/ripple/protocol/impl/BuildInfo.cpp
79.16% <ø> (ø)
:arrow_up:

src/ripple/core/Stoppable.h
93.75% <0%> (-6.25%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 232975b...1ed819c. Read the comment docs.

The xcode-9 failure can be safely ignored - it is a known homebrew/travis issue and will be fixed in the first 1.5 beta. All other variants are passing.


Block Load Event fixes and content canBeShown

Coverage decreased (-0.4%) to 55.459% when pulling 8bf5899ea440ef5b441203344bf3a7f7bff3e8f7 on block_load_event_handler into 2bba2e5a9ff2d168a8802f6628a5e1bc36f80fe2 on master.

Coverage decreased (-0.5%) to 55.345% when pulling 0387c1b65b6fd2f07dae4c58ed89140e1a0d71ed on block_load_event_handler into 2bba2e5a9ff2d168a8802f6628a5e1bc36f80fe2 on master.

Coverage decreased (-0.3%) to 55.61% when pulling 93b83e276b9c3f224600b88d1e7e45c3cf72809a on block_load_event_handler into 2bba2e5a9ff2d168a8802f6628a5e1bc36f80fe2 on master.


Add route code review and components sidebaroct, navbaroct, footeroct

nueva ruta codereview and new components sidenavoct, navbaroct, footeroct.

This is one step for build the first version, currently this doesn't need reviewer.


Queues on SQS sometimes gets called, sometimes does not

Laravel Version: 5.8
PHP Version: 7.3
Queue driver: SQS

Description:
I find weird problem with dispatching jobs to Laravel queue. Sometimes, the queue gets called, sometimes not.
Code:
class ProcessSomethingJob implements ShouldQueue
{
    use Dispatchable, InteractsWithQueue, Queueable, SerializesModels;

    protected $params;

    public function __construct($params)
    {
        $this->params = $params;
        Log::debug("This gets called");
    }

    public function handle(SomeService $service)
    {
        Log::debug("This doesn't get called sometimes.");
    }
}

I think this might be a bug because there's nothing wrong with the code (I tried to run with queue driver=sync, and it works perfectly fine all the time). I also monitor SQS, and make sure all messages are sent and received. Although I'm not sure on monitoring supervisor, but all queue services are running and doesn't have any error.

Nevermind. I found the problem was there's an old Lambda that triggered by same SQS queue.
This caused some events are executed in the that Lambda instead of the Laravel queue. In case anyone having same issue like this, please make sure that there's no other services consuming your SQS messages.


store NIMS PID into nims_pid property

This PR will fix https://github.com/antleaf/nims-mdr-development/issues/421 .

I will merge it according to https://github.com/antleaf/nims-mdr-development/issues/431 .


proxy: only divert outbound traffic from Ingress proxy to cilium_host

https://github.com/cilium/cilium/pull/29530 re-introduced the custom routing of Ingress proxy traffic to cilium_host. But we actually don't need to route all Ingress proxy traffic - it's sufficient to divert traffic that is in direction from the connection's source to destination.

/test

/test

/test


buildmycube -m option default configuration improvements : default cards

I just install ideascube on a raspberry pi using buildmycube with th -m option set to false <moment_americain> which is soooo easy and sooo awesome btw </moment_americain>.
I said to buildmycube that I did not want the khan academy and I was not asked about the blog. Buildmycube installed the khan academy card (with nothing behind it) and the blog card. Whicch I did not want.

We have to wait for Ideascube to be able to automatically show or hide those cards

These cards are defined from ideascube, BUILTIN_APP_CARDS and EXTRA_APP_CARDS. Having ansiblecube touch anything there is a no-go :)


⚠ Text Filter API Endpoint has degraded performance

In 3f4626a, Text Filter API Endpoint (http://textfilter.roblox.com/) experienced degraded performance:

HTTP code: 200
Response time: 4707 ms

Resolved: Text Filter API Endpoint performance has improved in 7ff55f9.


Maximum 3 clients

I commented in
#define CONFIG_BT_NIMBLE_MAX_CONNECTIONS 8
in nimconfig.h, then cleaned my project and built, but no change in behavior for the 4th attempted connection. It looked like many NimBLE*.o files were created on that build.
I reviewed issue #99. It seems that it should work with just the nimconfig.h change, but maybe there's an issue with platform io.
I am using platform io, and I apologize for having no clue how platform io manages the various included libraries.

Try adding -D CONFIG_BT_NIMBLE_MAX_CONNECTIONS 8 to your PlatformIO.ini and delete the .pio folder.

build_flags = -DCONFIG_BT_NIMBLE_MAX_CONNECTIONS=8
I added this to the platformio.ini file, deleted the .pio folder and it works. I am not sure, but maybe clean and build without deleting the .pio folder would also work.
Thanks for your help.


Extending Content Author to support more finegrained tagging

Using the DescriptorAsContentTransformer, descriptors such as FileMetadata can be re-input into the pipeline as content, for instance in order to create a prompt for later captioning. So far, complex struct descriptors have been ignored, since they do not map onto content easily. In order to support the usecase of including exif metadata in prompts for image captioning I have made the following main contribution:

The DescriptorAsContentTransformer now uses the ContentAuthorAttributes as a rudimentary tagging system to load all the values of an AnyMapStructDescriptor into the content of a retrievable while maintaining the keys.

For instance, if the name of the operator is "exif_content_transformer" and the names of the subfields are "location" and "date" then the transformer will transform a descriptor into two text content elements, tag them both with "exif_content_transformer", tag the location content with "exif_content_transformer.location" and tag the date content with "exif_content_transformer.date".
We should have a discussion, if this is intended behaviour of our tagging system. If so, let us maybe rename ContentAuthorAttribute to ContentTagAttribute and set CONTENT_AUTHORS_KEY from contentSources (which was inconsistent anyways) to tagWhiteList or something similar. Maybe we might want to make this kind of "namespace" approach "operator.tag" more rigorous.
Additionally:

The ExifMetadata Extractor can now extract more complex json objects as strings by simply keeping the raw json

@lucaro Do you have any feedback on this?

I did not get around to look at it yet, will do so as soon as I'm able.

Can somebody help me out with this test? Why am I getting failed tests on functionality I didn't touch?


Use BigNumber instead of number type for amount

For amount field, it has the number type which can support around 53 bit number. However, an issue currency amount has the maximum value of<PHONE_NUMBER>999999 * 10^80, which is not a value that number can store. Explorer should change to a type(eg. BigNumber) that can store these large values. This would likely affect a lot of places in the repo, such as  helper functions.

5300000000
On Tue, 2 Apr 2024, 2:21 am Shawn Xie, @.***> wrote:

For amount
https://github.com/ripple/explorer/blob/2835d72c98a5106378b6c8b456df82b6f4582327/src/containers/shared/types.ts
field, it has the number type which can support around 53 bit number.
However, an issue currency amount has the maximum value of<PHONE_NUMBER>999999

10^80, which is not a value that number can store. Explorer should
change to a type(eg. BigNumber) that can store these large values. This
would likely affect a lot of places in the repo, such as helper functions.

—
Reply to this email directly, view it on GitHub
https://github.com/ripple/explorer/issues/968, or unsubscribe
https://github.com/notifications/unsubscribe-auth/A6G5GTNYXQLSXD4432N4LTLY3HFVVAVCNFSM6AAAAABFSHDUHWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIYTSMBYGYZDGOI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Thanks @shawnxie999 for raising the issue! We have added this ticket to our backlog


Not redirect long inactive user to logon.aspx

Hello.
If the user is inactive for longer than specified in the parameter and then try click on the report of folder it does not redirect to logon.aspx. Portal try load logon.aspx with XMLHTTPRequest into current page.

This issue was a defect in the serverin how it handled expired cookies, and was fixed in SSRS2016, 2017 and Power BI RS


feat: add setupCliTest, findCliCommand

Coverage increased (+0.08%) to 97.222% when pulling a4a51e722563b60dc85581733c4357c6e3ec8b58 on find-cli into 06b502248c33114a7463d47d482764522534b87a on master.

:tada: This PR is included in version 4.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


video support?

Hello,
Is there any way I could play a video with Ebiten? Maybe integrating FFMpeg with it? (see https://github.com/3d0c/gmf go ffmpeg bindings).
Concerning the video format, it is random (my program can be used to play videos) but I guess it shouldn't really be an issue as FFMpeg has support for them
However I have no idea how to do it, especially with sound.
Thanks

Hi,
This seems the duplication with #110 .

Is there any way I could play a video with Ebiten?

No so far. Supporting video would be a really tough work (which format should be supported? Can they be in pure Go), so it is not feasible to implement this feature in near future so far.


chore: remove old signer and refactor tests

This replaces https://github.com/celestiaorg/celestia-app/pull/2238
It tries to consolidate a lot of our testing infrastructure using the new signer instead of the old
Note that with the exception of signer, this PR touches only tests
Checklist

[ ] New and updated code has appropriate documentation
[ ] New and updated code has new and/or updated testing
[ ] Required CI checks are passing
[ ] Visual proof for any user facing features like CLI or documentation updates
[ ] Linked issues closed with keywords

Codecov Report

Merging #2314 (f655cce) into main (376132a) will decrease coverage by 0.09%.
Report is 3 commits behind head on main.
The diff coverage is 18.18%.

@@            Coverage Diff             @@
##             main    #2314      +/-   ##
==========================================
- Coverage   20.34%   20.25%   -0.09%
==========================================
  Files         136      132       -4
  Lines       15800    15504     -296
==========================================
- Hits         3214     3140      -74
+ Misses      12278    12063     -215
+ Partials      308      301       -7

Files Changed
Coverage Δ

pkg/user/signer.go
0.00% <0.00%> (ø)

x/blob/types/codec.go
100.00% <ø> (ø)

x/blob/types/payforblob.go
75.70% <100.00%> (ø)

... and 1 file with indirect coverage changes

Do we want to backport this to v1.x?

Strangely this PR removes a test util helper that is causing tests to fail when bumping the v1.x branch to Go 1.21 so I'm inclined to backport this refactor to v1.x if possible.


Fix minor typo

Can you please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "typo" git@github.com:sapphiredev/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

This will update the existing PR, so you do not need to open a new one.

LGTM

LGTM


Info

https://f-droid.org/en/docs/All_About_Descriptions_Graphics_and_Screenshots/

@mondlicht-und-sterne I'm closing this issue because the description is not clear for us.
Please provide us more info so we can understand your request, feel free to reopen it.


Support for WP post embeds

Problem: The height of the wp-embed iframe is unknown until the iframe is rendered.

[ ] PWA support
[ ] AMP support

For PWA support, we can create a converter which executes this JS code that should change the iframe height properly:
https://gist.github.com/luisherranz/a8b0e4c3eba6f446e16fee736b8cf908
For AMP support, we need to investigate what the wp-amp plugin is doing to change the height. Maybe we can install it and see what happens.

After a bit of research I've found this PR in amp-wp from Weston:
https://github.com/Automattic/amp-wp/pull/914/files
It looks like amp-wp doesn't support wp-embed yet either.
He is suggesting to add this to WP core:
/**
 * Add JS required for iframe to resize itself in AMP.
 *
 * @todo This should be incorporated into core.
 * @since ?.?
 */
function amp_add_post_embed_js() {
	?>
	<script>
	if ( /amp=1/.test( location.hash ) ) {
		window.parent.postMessage({
			sentinel: 'amp',
			type: 'embed-size',
			height: document.body.scrollHeight
		}, '*');
	}
	</script>
	<?php
}
add_action( 'embed_footer', 'amp_add_post_embed_js' );

Which is taking from here:
https://www.ampproject.org/docs/reference/components/amp-iframe#iframe-resizing
We could add that code to our plugin, then add #amp=1 to the iframe src in our converter and render the wp-embed iframe like this:
<amp-iframe width=300 height=300
    layout="responsive"
    sandbox="allow-scripts allow-same-origin"
    resizable
    src="https://wp-blog.com/post-one#amp=1">
  <div overflow tabindex=0 role=button aria-label="Read more">Read more!</div>
</amp-iframe>

Then we should take out the amp_add_post_embed_js function once it's merged to the core.

We'll use the code without amp=1:
		window.parent.postMessage({
			sentinel: 'amp',
			type: 'embed-size',
			height: document.body.scrollHeight
		}, '*');
	```

Once it's finished, we should remove removeWpEmbeddedContent:
https://github.com/frontity/saturn-theme/blob/dev-stable/src/shared/processors/low/removeWpEmbeddedContent.js

#notify


Enhancement: Support new-line delimited JSON format/JSON lines

Thank you for the great project. It looks very promising to me.
I currently use val df = DataFrame.readJsonStr(File("foo.ndjson").readLines().joinToString(",", "[", "]")), to read new-line delimited JSON files, which works quite well. However, it would be much more convinient if the API would offer such a function directly. It would be also nice if it would work directly on InputStreams, because readLines() is already reading the entire file under the hood.

Hi! Can you provide a small sample of such JSON?

Sure:
foo.ndjson.txt
(had to change extension due to github extension issues).

https://codebeautify.org/json-decode-online
file is not json spec.  is Json have "new-line delimited" spec variant? You try to read all file and convert it in memory.  Its very huge and slow. Json parser read file by many smal parts (buffer size).

Yes, I'm aware, that is true. My file is not valid JSON, however, this format is commonly used in BigData environments. The specification is available here: http://ndjson.org/

API could be:
DataFrame.readNdJson(path: String, skip: Int? = null, limit: Int? = null)
It can be parsed line by line to JsonElement (or JsonObject?), then joined into JsonList and converted to dataframe by readJsonImpl
From https://www.atatus.com/glossary/jsonl/
When dealing with regular JSON, there is essentially just one course of action: load the entire dataset into memory and parse it. Although you can break an 11 GB file into smaller files without parsing the whole thing, search for a certain location inside JSON Lines, use CLI n-based tools, etc.

parameter filter: (JsonElement) -> Boolean could be useful too. will be easier to load only relevant parts of a big file


Install error on windows10 with msvc

Hi there, I just install rust and run cmd :

cargo install minidump-stackwalk

But it unexpectedly got an build error:
error: failed to run custom build command for `ring v0.16.20`

Caused by:
  process didn't exit successfully: `C:\Users\CHENJI~1\AppData\Local\Temp\cargo-installHQigpm\release\build\ring-4232d471cd9b88f3\build-script-build` (exit code: 101)
  --- stdout
  OPT_LEVEL = Some("3")
  TARGET = Some("x86_64-pc-windows-msvc")
  HOST = Some("x86_64-pc-windows-msvc")
  cargo:rerun-if-env-changed=CC_x86_64-pc-windows-msvc
  CC_x86_64-pc-windows-msvc = None
  cargo:rerun-if-env-changed=CC_x86_64_pc_windows_msvc
  CC_x86_64_pc_windows_msvc = None
  cargo:rerun-if-env-changed=HOST_CC
  HOST_CC = None
  cargo:rerun-if-env-changed=CC
  CC = Some("clang")
  cargo:rerun-if-env-changed=CFLAGS_x86_64-pc-windows-msvc
  CFLAGS_x86_64-pc-windows-msvc = None
  cargo:rerun-if-env-changed=CFLAGS_x86_64_pc_windows_msvc
  CFLAGS_x86_64_pc_windows_msvc = None
  cargo:rerun-if-env-changed=HOST_CFLAGS
  HOST_CFLAGS = None
  cargo:rerun-if-env-changed=CFLAGS
  CFLAGS = None
  cargo:rerun-if-env-changed=CRATE_CC_NO_DEFAULTS
  CRATE_CC_NO_DEFAULTS = None
  DEBUG = Some("false")

  --- stderr
  running "clang" "-O3" "-ffunction-sections" "-fdata-sections" "--target=x86_64-pc-windows-msvc" "-I" "include" "-Wall" "-Wextra" "/GS" "/Gy" "/EHsc" "/GR-" "/Zc:wchar_t" "/Zc:forScope" "/Zc:inline" "/Zc:rvalueCast" "/sdl" "/Wall" "/wd4127" "/wd4464" "/wd4514" "/wd4710" "/wd4711" "/wd4820" "/wd5045" "/Ox" "-DNDEBUG" "-c" "/FoC:\\Users\\CHENJI~1\\AppData\\Local\\Temp\\cargo-installHQigpm\\release\\build\\ring-e9a530021c266280\\out\\aes_nohw.obj" "crypto/fipsmodule/aes/aes_nohw.c"
  clang: error: no such file or directory: '/GS'
  clang: error: no such file or directory: '/Gy'
  clang: error: no such file or directory: '/EHsc'
  clang: error: no such file or directory: '/GR-'
  clang: error: no such file or directory: '/Zc:wchar_t'
  clang: error: no such file or directory: '/Zc:forScope'
  clang: error: no such file or directory: '/Zc:inline'
  clang: error: no such file or directory: '/Zc:rvalueCast'
  clang: error: no such file or directory: '/sdl'
  clang: error: no such file or directory: '/Wall'; did you mean '-Wall'?
  clang: error: no such file or directory: '/wd4127'
  clang: error: no such file or directory: '/wd4464'
  clang: error: no such file or directory: '/wd4514'
  clang: error: no such file or directory: '/wd4710'
  clang: error: no such file or directory: '/wd4711'
  clang: error: no such file or directory: '/wd4820'
  clang: error: no such file or directory: '/wd5045'
  clang: error: no such file or directory: '/Ox'
  clang: error: no such file or directory: '/FoC:\Users\CHENJI~1\AppData\Local\Temp\cargo-installHQigpm\release\build\ring-e9a530021c266280\out\aes_nohw.obj'
  thread 'main' panicked at 'execution failed', C:\Users\chenjiannan\.cargo\registry\src\index.crates.io-6f17d22bba15001f\ring-0.16.20\build.rs:656:9
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
error: failed to compile `minidump-stackwalk v0.17.0`, intermediate artifacts can be found at `C:\Users\CHENJI~1\AppData\Local\Temp\cargo-installHQigpm`

How can I solve it?

I don't think there are many people building these crates for Windows, unfortunately. (If you are on Windows you typically would use one of Microsoft's debuggers to read a minidump.) It looks like ring's build is attempting to pass MSVC-style arguments to clang, which obviously won't work. You might be able to set CC to clang-cl, which is the clang frontend with an MSVC-compatible interface. Otherwise I'd recommend having a look at ring's documentation.

@luser I think you meant to link to https://docs.rs/ring/latest/ring/ instead of some Minecraft-related documentation?

Releases have pre-built Windows binaries now, closing this.


Upload/Fetch from URL/Use OCDS Data Source - back

Component of backend allowing users to input JSON
The input JSON can be provided in a few ways:

Upload a file
Provide the URL of a file
Via the OCDS data registry

Resolve issue https://github.com/open-contracting/spoonbill/issues/3

Looks good. But docker image starting to massive with all this dependencies, so I really want to try two stage build. Maybe lets wait a bit as @pontostroy try this out before merging.


Should openpyxl and xlrd be listed in configuration files?

Hi,
I notice that openpyxl  and xlrd are used as  direct dependencies in import_export/formats/base_formats.py. So should openpyxl  and xlrd be listed in configuration files?

by 'configuration files', do you mean requirements files?

Hi, I mean that if the dependency is directly used in code files, it should be declared. "Configuration files" here， for example requirements-*.txt

Thanks for raising this - I'll look into updating requirements.

I looked into this and I think we are OK with the dependencies as they are.  In our base.txt, we have:
tablib[html,ods,xls,xlsx,yaml]>=3.0.0

(also in setup.py)
hence openpyxl and xlrd are provided by tablib as optional dependencies.  Therefore we can be sure that the dependencies will be installed, and that we will have the versions that are known to work with tablib.  I think if we define the specific versions for openpyxl and xlrd we run the risk of introducing subtle bugs where these dependencies get out of sync with tablib.
Therefore I propose to take no further action.  Let me know if you disagree with the above.


Daily Updates

I think the idea is maybe to break this down into GitHub issues
Workflow_3
Ideas:
Refresh Database
~ Alerts - check how long they’ve been running
~ Update Sensor List - see Get_Spike_df issue
~Update User List from RedCAP
~New Subscriptions (check if any sensors nearby & text)
~Unsubscriptions (Check for  “Sign Up Information” subscribed = FALSE (which is updated realtime), text with instructions on how to resume service, remove from RedCAP/our database & delete all messages on Twilio)
Update Daily Log
~ Number of Alerts/Spikes Events
~ Sensors’ Spike Frequencies
~ Number of messages sent past day
~ Number of new users
~ Number of unsubscriptions
Submit reports Weekly? on Monday morning as a .csv

Another update with this is 6f99381
This initialized:
Update Sensor List
Update User List from RedCAP
Number of messages sent past day
Number of new users
Slightly premature, but had to get D an updated MAIN.py for setting up Virtual Machine.

Made a branch for testing this stuff
https://github.com/RwHendrickson/AQ_SpikeAlerts/tree/Daily_Updates


Output nothing but the gpu was working

First of all, thank you for your excellent work. The model I deployed was codellama. I built this project, and two containers started. However, when I used the OpenAI API, it didn't output anything while the GPU was actually working.
I ran the following Python example:
python3 openai_completion_stream.py

But nothing outputted.
I ran the following curl command:
curl --location 'http://<IP_ADDRESS>:3000/v1/chat/completions' \
--header 'Content-Type: application/json' \
--data '{
    "model": "ensemble",
    "messages": [
        {
            "role": "user",
            "content": "What is machine learning?"
        }
    ],
    "max_tokens": 200,
    "temperature": 0,
    "stop": [""]
}'

The response looked like this:
{
    "id": "cmpl-8959e6ff-41c7-4abf-b9eb-38489480af04",
    "object": "text_completion",
    "created":<PHONE_NUMBER>,
    "model": "ensemble",
    "system_fingerprint": null,
    "choices": [
        {
            "index": 0,
            "message": {
                "role": "assistant",
                "content": "User: What is machine learning?\nASSISTANT:"
            },
            "finish_reason": "stop"
        }
    ],
    "usage": {
        "prompt_tokens": 0,
        "completion_tokens": 0,
        "total_tokens": 0
    }
}

and the log info looks normal:
{
    "timestamp": "2024-04-07T09:00:51.437413Z",
    "level": "INFO",
    "message": "request: Json(ChatCompletionCreateParams { messages: [User { content: \"What is machine learning?\", name: None }], model: \"ensemble\", frequency_penalty: 0.0, logit_bias: None, max_tokens: 200, n: 1, presence_penalty: 0.0, response_format: None, seed: None, stop: Some([\"\"]), stream: false, temperature: 0.0, top_p: 1.0, user: None })",
    "target": "openai_trtllm::routes::chat",
    "span": {
        "headers": "{\"host\": \"<IP_ADDRESS>:3000\", \"user-agent\": \"curl/8.2.1\", \"accept\": \"*/*\", \"content-type\": \"application/json\", \"content-length\": \"220\"}",
        "name": "chat_completions"
    },
    "spans": [
        {
            "http.request.method": "POST",
            "http.route": "/v1/chat/completions",
            "network.protocol.version": "1.1",
            "otel.kind": "Server",
            "otel.name": "POST /v1/chat/completions",
            "server.address": "<IP_ADDRESS>:3000",
            "span.type": "web",
            "url.path": "/v1/chat/completions",
            "url.scheme": "",
            "user_agent.original": "curl/8.2.1",
            "name": "HTTP request"
        },
        {
            "headers": "{\"host\": \"<IP_ADDRESS>:3000\", \"user-agent\": \"curl/8.2.1\", \"accept\": \"*/*\", \"content-type\": \"application/json\", \"content-length\": \"220\"}",
            "name": "chat_completions"
        }
    ]
}

However, when I used curl in the container of triton_trt_llm:
curl -X POST localhost:8000/v2/models/ensemble/generate_stream -d '{
    "text_input": "What is machine learning?",
    "max_tokens": 200,
    "stream": false,
    "bad_words": "",
    "stop_words": "",
    "pad_id": 2,
    "end_id": 2,
    "return_log_probs": false
}'

The answer was just like normal. I'm wondering if any parameters that I input were wrong or if there is any documentation to guide me on what to do next.
Thanks for your kind work again!

I think you should use the gRPC port of triton. Maybe it's 3001 in your case?

I think you should use the gRPC port of triton. Maybe it's 3001 in your case?

I used the default gRPC port (8001) to communicate with Triton.
I0407 07:25:59.905119 103 server.cc:677]
+------------------+---------+--------+
| Model            | Version | Status |
+------------------+---------+--------+
| ensemble         | 1       | READY  |
| postprocessing   | 1       | READY  |
| preprocessing    | 1       | READY  |
| tensorrt_llm     | 1       | READY  |
| tensorrt_llm_bls | 1       | READY  |
+------------------+---------+--------+

I0407 07:25:59.966723 103 metrics.cc:877] Collecting metrics for GPU 0: NVIDIA A100-SXM4-80GB
I0407 07:25:59.969556 103 metrics.cc:770] Collecting CPU metrics
I0407 07:25:59.969690 103 tritonserver.cc:2508]
+----------------------------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Option                           | Value                                                                                |
+----------------------------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| server_id                        | triton                                                                                |
| server_version                   | 2.43.0                                                                                |
| server_extensions                | classification sequence model_repository model_repository(unload_dependents) schedule_policy model_configuration system_shared_memory cuda_shared_memory binary_tensor_data parameters statistics trace logging |
| model_repository_path[0]         | /tensorrtllm_backend/triton_model_repo                                                                                |
| model_control_mode               | MODE_NONE                                                                                |
| strict_model_config              | 1                                                                                |
| rate_limit                       | OFF                                                                                |
| pinned_memory_pool_byte_size     | 268435456                                                                                |
| cuda_memory_pool_byte_size{0}    | 67108864                                                                                |
| min_supported_compute_capability | 6.0                                                                                |
| strict_readiness                 | 1                                                                                |
| exit_timeout                     | 30                                                                                |
| cache_enabled                    | 0                                                                                |
+----------------------------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+

I0407 07:25:59.971120 103 grpc_server.cc:2519] Started GRPCInferenceService at <IP_ADDRESS>:8001
I0407 07:25:59.971319 103 http_server.cc:4637] Started HTTPService at <IP_ADDRESS>:8000
I0407 07:26:00.012131 103 http_server.cc:320] Started Metrics Service at <IP_ADDRESS>:8002

and my docker-compose.yml as following:
version: "3"

services:
  openai_trtllm:
    image: openai_trtllm
    build:
      context: .
      dockerfile: Dockerfile
    command:
      - "--host"
      - "<IP_ADDRESS>"
      - "--port"
      - "3000"
      - "--triton-endpoint"
      - "http://tensorrtllm_backend:8001"
    ports:
      - "3000:3000"
    depends_on:
      - tensorrtllm_backend
    restart: on-failure

  # Triton backend for TensorRT LLM
  tensorrtllm_backend:
    image: triton_trt_llm:latest
    volumes:
      - /tensor/tensorrtllm_backend:/tensorrtllm_backend
    command:
      - "/bin/bash"
      - "-c"
      - |
        python3 /tensorrtllm_backend/scripts/launch_triton_server.py --world_size=1 --model_repo=/tensorrtllm_backend/triton_model_repo
        tail -f /dev/null
    ports:
      - "8000:8000"
      - "8001:8001"
      - "8002:8002"
    deploy:
      replicas: 1
      resources:
        reservations:
          devices:
            - driver: nvidia
              count: 1
              capabilities: [ gpu ]
    shm_size: '2g'
    ulimits:
      memlock: -1
      stack: 67108864
    restart: on-failure

i think the port was right here, maybe?

could try this https://github.com/triton-inference-server/tensorrtllm_backend/blob/main/inflight_batcher_llm/client/end_to_end_grpc_client.py to check the ensemle？

Can u use completion instead of chat completion to make sure the inputs are same to compare？And it's better to set RUST_LOG to debug.
I tested codellama and it works for me.

Can u use completion instead of chat completion to make sure the inputs are same to compare？And it's better to set RUST_LOG to debug.
I tested codellama and it works for me.

thanks for your patient, i open the debug mode and try with /v1/completion, here is the log in detail:
curl --location 'http://<IP_ADDRESS>:3000/v1/completions' \
> --header 'Content-Type: application/json' \
> --data '{
>     "model": "ensemble",
>     "prompt": "What is machine learning?",
>     "max_tokens": 200,
>     "temperature": 0
>   }'
{"id":"cmpl-8f38b74e-1630-43c9-9586-f9e7d1e89345","object":"text_completion","created":1712719920,"model":"ensemble","choices":[{"text":"What is machine learning?","index":0,"logprobs":null,"finish_reason":"stop"}],"usage":{"prompt_tokens":0,"completion_tokens":0,"total_tokens":0}}

and the debug log:
openai_trtllm-1        |   2024-04-10T03:31:53.761914Z  INFO openai_trtllm::routes::completions: request: Json(CompletionCreateParams { model: "ensemble", prompt: ["What is machine learning?"], best_of: 1, echo: false, frequency_penalty: 0.0, logit_bias: None, logprobs: None, max_tokens: 200, n: 1, presence_penalty: 0.0, seed: None, stop: None, stream: false, suffix: None, temperature: 0.0, top_p: 1.0, user: None })
openai_trtllm-1        |     at src/routes/completions.rs:35 on tokio-runtime-worker
openai_trtllm-1        |     in openai_trtllm::routes::completions::completions with headers: {"host": "<IP_ADDRESS>:3000", "user-agent": "curl/8.2.1", "accept": "*/*", "content-type": "application/json", "content-length": "117"}
openai_trtllm-1        |     in otel::tracing::HTTP request with http.request.method: POST, network.protocol.version: 1.1, server.address: "<IP_ADDRESS>:3000", user_agent.original: "curl/8.2.1", url.path: "/v1/completions", url.scheme: "", otel.name: POST, otel.kind: Server, span.type: "web", http.route: "/v1/completions", otel.name: "POST /v1/completions"
openai_trtllm-1        |
openai_trtllm-1        |   2024-04-10T03:31:53.762164Z DEBUG tower::buffer::worker: service.ready: true, processing request
openai_trtllm-1        |     at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tower-0.4.13/src/buffer/worker.rs:197 on tokio-runtime-worker
openai_trtllm-1        |     in openai_trtllm::routes::completions::non-streaming completions with headers: {"host": "<IP_ADDRESS>:3000", "user-agent": "curl/8.2.1", "accept": "*/*", "content-type": "application/json", "content-length": "117"}
openai_trtllm-1        |     in openai_trtllm::routes::completions::completions with headers: {"host": "<IP_ADDRESS>:3000", "user-agent": "curl/8.2.1", "accept": "*/*", "content-type": "application/json", "content-length": "117"}
openai_trtllm-1        |     in otel::tracing::HTTP request with http.request.method: POST, network.protocol.version: 1.1, server.address: "<IP_ADDRESS>:3000", user_agent.original: "curl/8.2.1", url.path: "/v1/completions", url.scheme: "", otel.name: POST, otel.kind: Server, span.type: "web", http.route: "/v1/completions", otel.name: "POST /v1/completions"
openai_trtllm-1        |
openai_trtllm-1        |   2024-04-10T03:31:53.762537Z DEBUG h2::codec::framed_write: send, frame: Headers { stream_id: StreamId(3), flags: (0x4: END_HEADERS) }
openai_trtllm-1        |     at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/h2-0.3.26/src/codec/framed_write.rs:213 on tokio-runtime-worker
openai_trtllm-1        |     in h2::proto::connection::Connection with peer: Client
openai_trtllm-1        |
openai_trtllm-1        |   2024-04-10T03:31:53.762616Z DEBUG h2::codec::framed_write: send, frame: Data { stream_id: StreamId(3) }
openai_trtllm-1        |     at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/h2-0.3.26/src/codec/framed_write.rs:213 on tokio-runtime-worker
openai_trtllm-1        |     in h2::proto::connection::Connection with peer: Client
openai_trtllm-1        |
openai_trtllm-1        |   2024-04-10T03:31:53.762642Z DEBUG h2::codec::framed_write: send, frame: Data { stream_id: StreamId(3), flags: (0x1: END_STREAM) }
openai_trtllm-1        |     at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/h2-0.3.26/src/codec/framed_write.rs:213 on tokio-runtime-worker
openai_trtllm-1        |     in h2::proto::connection::Connection with peer: Client
openai_trtllm-1        |
openai_trtllm-1        |   2024-04-10T03:31:53.762899Z DEBUG h2::codec::framed_read: received, frame: Ping { ack: false, payload: [0, 0, 0, 0, 0, 0, 0, 1] }
openai_trtllm-1        |     at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/h2-0.3.26/src/codec/framed_read.rs:405 on tokio-runtime-worker
openai_trtllm-1        |     in h2::proto::connection::Connection with peer: Client
openai_trtllm-1        |
openai_trtllm-1        |   2024-04-10T03:31:53.762944Z DEBUG h2::codec::framed_write: send, frame: Ping { ack: true, payload: [0, 0, 0, 0, 0, 0, 0, 1] }
openai_trtllm-1        |     at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/h2-0.3.26/src/codec/framed_write.rs:213 on tokio-runtime-worker
openai_trtllm-1        |     in h2::proto::connection::Connection with peer: Client
openai_trtllm-1        |
openai_trtllm-1        |   2024-04-10T03:32:00.505616Z DEBUG h2::codec::framed_read: received, frame: Headers { stream_id: StreamId(3), flags: (0x4: END_HEADERS) }
openai_trtllm-1        |     at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/h2-0.3.26/src/codec/framed_read.rs:405 on tokio-runtime-worker
openai_trtllm-1        |     in h2::proto::connection::Connection with peer: Client
openai_trtllm-1        |
openai_trtllm-1        |   2024-04-10T03:32:00.505727Z DEBUG h2::codec::framed_read: received, frame: Data { stream_id: StreamId(3) }
openai_trtllm-1        |     at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/h2-0.3.26/src/codec/framed_read.rs:405 on tokio-runtime-worker
openai_trtllm-1        |     in h2::proto::connection::Connection with peer: Client
openai_trtllm-1        |
openai_trtllm-1        |   2024-04-10T03:32:00.505758Z DEBUG h2::codec::framed_read: received, frame: WindowUpdate { stream_id: StreamId(0), size_increment: 329 }
openai_trtllm-1        |     at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/h2-0.3.26/src/codec/framed_read.rs:405 on tokio-runtime-worker
openai_trtllm-1        |     in h2::proto::connection::Connection with peer: Client
openai_trtllm-1        |
openai_trtllm-1        |   2024-04-10T03:32:00.505786Z DEBUG h2::codec::framed_read: received, frame: Headers { stream_id: StreamId(3), flags: (0x5: END_HEADERS | END_STREAM) }
openai_trtllm-1        |     at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/h2-0.3.26/src/codec/framed_read.rs:405 on tokio-runtime-worker
openai_trtllm-1        |     in h2::proto::connection::Connection with peer: Client
openai_trtllm-1        |
openai_trtllm-1        |   2024-04-10T03:32:00.506087Z DEBUG openai_trtllm::routes::completions: triton infer response: ModelInferResponse { model_name: "ensemble", model_version: "1", id: "", parameters: {"sequence_id": InferParameter { parameter_choice: Some(Int64Param(0)) }, "sequence_end": InferParameter { parameter_choice: Some(BoolParam(false)) }, "sequence_start": InferParameter { parameter_choice: Some(BoolParam(false)) }, "triton_final_response": InferParameter { parameter_choice: Some(BoolParam(true)) }}, outputs: [InferOutputTensor { name: "text_output", datatype: "BYTES", shape: [1], parameters: {}, contents: None }], raw_output_contents: [[25, 0, 0, 0, 87, 104, 97, 116, 32, 105, 115, 32, 109, 97, 99, 104, 105, 110, 101, 32, 108, 101, 97, 114, 110, 105, 110, 103, 63]] }
openai_trtllm-1        |     at src/routes/completions.rs:166 on tokio-runtime-worker
openai_trtllm-1        |     in openai_trtllm::routes::completions::non-streaming completions with headers: {"host": "<IP_ADDRESS>:3000", "user-agent": "curl/8.2.1", "accept": "*/*", "content-type": "application/json", "content-length": "117"}
openai_trtllm-1        |     in openai_trtllm::routes::completions::completions with headers: {"host": "<IP_ADDRESS>:3000", "user-agent": "curl/8.2.1", "accept": "*/*", "content-type": "application/json", "content-length": "117"}
openai_trtllm-1        |     in otel::tracing::HTTP request with http.request.method: POST, network.protocol.version: 1.1, server.address: "<IP_ADDRESS>:3000", user_agent.original: "curl/8.2.1", url.path: "/v1/completions", url.scheme: "", otel.name: POST, otel.kind: Server, span.type: "web", http.route: "/v1/completions", otel.name: "POST /v1/completions"
openai_trtllm-1        |
openai_trtllm-1        |   2024-04-10T03:32:00.506152Z DEBUG openai_trtllm::routes::completions: deserialized triton infer response content: "What is machine learning?"
openai_trtllm-1        |     at src/routes/completions.rs:170 on tokio-runtime-worker
openai_trtllm-1        |     in openai_trtllm::routes::completions::non-streaming completions with headers: {"host": "<IP_ADDRESS>:3000", "user-agent": "curl/8.2.1", "accept": "*/*", "content-type": "application/json", "content-length": "117"}
openai_trtllm-1        |     in openai_trtllm::routes::completions::completions with headers: {"host": "<IP_ADDRESS>:3000", "user-agent": "curl/8.2.1", "accept": "*/*", "content-type": "application/json", "content-length": "117"}
openai_trtllm-1        |     in otel::tracing::HTTP request with http.request.method: POST, network.protocol.version: 1.1, server.address: "<IP_ADDRESS>:3000", user_agent.original: "curl/8.2.1", url.path: "/v1/completions", url.scheme: "", otel.name: POST, otel.kind: Server, span.type: "web", http.route: "/v1/completions", otel.name: "POST /v1/completions"

@npuichigo  I have found the source of the problem. The parameter "top_p" is being sent to the gRPC, and this parameter is set as default in your code. If I comment out this parameter, the answer will be normal. I am still trying to determine what is causing it.

Thank you for all your hard work. I will close this issue now.


Introduce a roadmap document

Description

This file contains an outline of where we would like the monorepo to end up within the next 6-12 months. It also includes a glossary of common terms that are used within the document.

Should denote which packages / exports are node-only, browser-only, and platform agnostic

We should add status notes (e.g. incomplete, started, complete)


What about "min_floor_temp:"

Hi @ll,
what about "min_floor_temp:" ?
Thank you!
lucky

Could you describe the expected logic?
What if we reached the raget temp but not the min_floor_temp, for example?

Hi,
would be interest for savety in case of frost - maby - must work without thermostat "on"
Thank you

Setting a thermostat's away temp to a nonfrost temp will accomplish this.

Hi. I'm jumping into this old issue with another implementation of min_floor_temp. If it's a warm winter day and your ambient temperature is warm enough, heating can stay turned off for a long time, so your floor becomes cold to the touch (but with no problems seen to thermostat logic).
It would be great to be able to still turn on heating just to warm up the floor a bit, even if it will overshoot room temperature.
I guess there's at least 3 values needed for this logic to work properly: min_floor_temp, timeout and max_room_temp
If floor temperature is lower than min_floor_temp for timeout or longer, then we turn on heating ignoring the fact that it's already warm enough, but if room temperature is greater than max_room_temp, then we turn it off

One way I think it could or should work is to switch the thermostat to a "floor temperature thermostat". Where the current temperature is not the room temperature but the floor temperature, my concern is that the UI should give you an idea of what's going on. It will be very confusing to be honest.

I don't like the idea of a thermostat controlling only the floor temperature not being aware of the actual room temp 🥺

Well, the simplest way to do it would be just to set the min_floor_floor_temp, and the thermostat won't turn off until it's reached. I could inject this extra logic when I check if the room is warm enough by adding (and the floor is warm enough, too)
I also planned to introduce some attributes of the thermostat that communicate the reason for current state

@alvarocarrera @dankarization. I added the logic, please try the v0.9.3-bata

@luckysession @dankarization . Did you have a chance to try the above beta for minimum floor temperature?

Not yet, my sensor board needs some work to be done first(


2.x Diagnostic REST API - initial version

NetflixOSS » eureka » eureka-pull-requests #398 SUCCESS
This pull request looks good


NIFI-11890 Upgrade Guava from 31.1 to 32.0.1 for Toolkit Modules

Summary
NIFI-11890 Upgrades Google Guava from 31.1 to 32.0.1 on the version 1 support branch for the Toolkit Admin and ZooKeeper Migrator modules, as well as the Hortonworks Schema Registry.
These three modules are deprecated and removed from the main branch, but this upgrade align upgradable Guava versions with other references.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[X] Apache NiFi Jira issue created

Pull Request Tracking

[X] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[X] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[X] Pull Request based on current revision of the main branch
[X] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[ ] Build completed using mvn clean install -P contrib-check

[ ] JDK 17

Licensing

[ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[ ] Documentation formatting appears as expected in rendered files

Merged to 1.x.


Parameter "body" is null on NavServer

Hi, sometimes I get this error on my Ais around the game:
E 0:00:23:0244   Ai_Pathfinder_Kine.gd:247 @ _on_navigation_agent_3d_velocity_computed(): Parameter "body" is null.
  <C++ Source>   src\servers\jolt_physics_server_3d.cpp:1114 @ _body_get_direct_state()
  <Stack Trace>  Ai_Pathfinder_Kine.gd:247 @ _on_navigation_agent_3d_velocity_computed()

Since it's base directs me to Jolt server, I figured it could be it.
The code in question is:
func _on_navigation_agent_3d_velocity_computed(safe_velocity):
	velocity = velocity.move_toward(safe_velocity, .25)
	move_and_slide() #Line 247

And what body? While it does not crash the game, it floods the console with this error, with a couple dozens of them being thrown around.
And the code in the source is:
PhysicsDirectBodyState3D* JoltPhysicsServer3D::_body_get_direct_state(const RID& p_body) {
	JoltBodyImpl3D* body = body_owner.get_or_null(p_body);

	// Unlike most other server methods this one is meant to quietly return null if the body has
	// since been freed, which is used in places like `move_and_slide` to determine whether a
	// previously used platform has been freed or not.
	QUIET_FAIL_NULL_D(body);

	return body->get_direct_state();
}

Sometimes language is a barrier lol, but my Ai characters have not been freed for sure, which makes me wonder why it returns null?
Or is this supposed to happen, and can I suppress this without any worries?

I can't speak to whether you should be getting this error or not without seeing some kind of repro first, but the code you pasted from JoltPhysicsServer3D has not been released yet.
The equivalent method in version 0.9.0 emits an actual error when body is null, which is the error you're getting for some reason, whereas the code you pasted from the master branch does not actually emit any error (hence the QUIET_* macro). It was changed fairly recently as a result of #645.
I'll try and have a new release out this weekend, which will contain this change. But again, I don't know if that will hide an actual error in your case or just a false positive.

Oh ok, I got it from the master branch here, thought was the same I was using.
Maybe it's the interactions from the bodies in my game then, I have some rigidbodies which queue_free after some set time limit.
But I don't see a way to check for that around their move_and_slide(), since there are no bodies to check there.
I get the collisions here:
func detectar_col_ocorrida() -> Vector3:
	for col_idx in get_slide_collision_count():
		var col := get_slide_collision(col_idx)
		if col.get_collider() is CharacterBody3D:
			return col.get_normal().normalized()
		if col.get_collider() is StaticBody3D and col.get_normal().y < 0.1:
			return col.get_normal().normalized()
		if col.get_collider() is RigidBody3D:
			var force_multiplier = clamp(velocity.length(), 1.5, 10)
			var _force = -col.get_normal() * force_multiplier
			col.get_collider().apply_impulse(_force)
	return Vector3.ZERO

And, if any happened, I add them to:
	if col_vector != Vector3.ZERO:
		dir += col_vector * fator_peso_colisão # I probably need to normalize this later =D, you know, flying bodies...
	nav_agent.set_velocity(dir) #Which will then be calculated and used in the safe_velocity variable

I wonder, it's probably between this col detection and the safe velocity computed that I get this error if the body collided has been freed?

Assuming this issue is still affecting you, would you be able to try out the newly released 0.10.0-rc1 and see if that fixes the issue for you? If nothing else it should at least silence the error itself.

What I hope is the fix for this is part of the newly released 0.10.0-stable, so I'll go ahead and close this for now.
If it seems like the issue isn't resolved even when using 0.10.0-stable then feel free to bump this issue again.


Add Sass version to SassTemplate cache_key

Fixes #373 for the 5.x branch. (I'm not sure if this issue is already fixed on the 6.x branch or if it will need a separate fix there.)

That is correct. Master branch is fine already. We should follow the same implementation we use for the master version https://github.com/rails/sprockets/blob/master/lib/sprockets/sass_processor.rb#L49.


[Bug]: NG Poland event has a broken image

Relevant scope
angular application
Description
NG Poland event has a broken image.
Do you want to contribute with a pull request?
No

Fixed, thanks for the report!


fix(deps): update terraform ibm to latest for the deployable architecture solution

This PR contains the following updates:

Package
Type
Update
Change

ibm (source)
required_provider
patch
1.71.2 -> 1.71.3

Release Notes

IBM-Cloud/terraform-provider-ibm (ibm)
v1.71.3
Compare Source
Bugfixes

fix: HOT FIX to include properties from issue 5579 (5818)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

:tada: This PR is included in version 8.15.5 :tada:
The release is available on:

GitHub release
v8.15.5

Your semantic-release bot :package::rocket:


Setup periodic sequence generator

Codecov Report
Patch coverage has no change and project coverage change: +0.19% :tada:

Comparison is base (1a0b012) 99.80% compared to head (9de6a93) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #105      +/-   ##
===========================================
+ Coverage   99.80%   100.00%   +0.19%
===========================================
  Files          60        60
  Lines        2095      2095
  Branches      144       144
===========================================
+ Hits         2091      2095       +4
+ Misses          4         0       -4

see 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Show editor dirty state when tab bar is hidden

it's a awsome feature to hide tab bar, but I can NOT comfirm wether this file saved or not when hide tab bar

A workaround is probably to use the window.title setting, which can include a ${dirty} element.

Indeed, it seems to be included in the default value for this property. @jkiss aren't you seeing an indicator at the beginning of the window title when the current editor has unsaved changes?

If a user has no tab bar, has a command center and uses the default window title values, then we just show the name of the current file. It however would make sense to include the dirty state in this case.

@benibenj here's what I'm seeing on 1.84 on Windows with Command Center enabled, default window title, and a dirty file open in my folder:

And after Ctrl+Z to undo the change:

@gjsjohnmurray can you confirm that you have exactly the following value for window.title: ${dirty}${activeEditorShort}${separator}${rootName}${separator}${profileName}${separator}${appName}
You are seeing more text than default in the command center, which is normally due to not using the default value.

@benibenj aha, it's because I have set a separator:
"terminal.integrated.tabs.separator": " ● "

To summarise, I haven't set window.title but I have set window.titleSeparator.

Yes, that is it. We check if the user has a custom title format which is also affected by changing titleSeparator. By changing any title formatting, we assume you want to see the title instead of just workspace name (or file name when tabs are hidden)

OK, so maybe it's reasonable for the default behaviour to become that {dirty} is added when tabs are hidden.
Meanwhile @jkiss a workaround is to set "winodw.titleSeparator": " -  " (Note - two trailing spaces following the -).

👍 to include dirty indicator in command center by default without the user having to change something.

@gjsjohnmurray hi, I'm a MacOS user, so there is really NOT a unsave indicator at anywhere 😢

@gjsjohnmurray hi, I'm a MacOS user, so there is really NOT a unsave indicator at anywhere 😢

@gjsjohnmurray ok, there is a BIG dot, could I set this dot color to red or yellow?

verification steps:

Hide tabs: workbench.editor.showTabs: "hidden"
Show Command Center
Make sure to use default window.title value
Make active file dirty
Command center should display the dirty icon in front of the file name


SDK now supports versioned templates

See the "Use the SDK" section of this doc.

@drgy This is how your reviewed change committed by GitHub (#1). I assume it is wrong and the second example (#2) is correct.

// #1
console.log(
<EMAIL_ADDRESS><EMAIL_ADDRESS>);

/// #2

console.log(
  validator.validateWithTemplate('exampleSpecs/config.specs.json'<EMAIL_ADDRESS>);


AndroidPackagingOptionsInclude is ignored

Android framework version
net9.0-android
Affected platform version
VS 2022 17.12
Description
We have .NET Android application which we migrated from .NET 6.0 to .NET 9.0.
The app use Kotlin bindings that require Kotlin.StdLib and Kotlin.Reflect packages.
The application doesn't work neither DEBUG or RELEASE mode.
The exception in ADB log is :
java.lang.AssertionError: Built-in class kotlin.Any is not found at
kotlin.reflect.jvm.internal.impl.builtins.KotlinBuiltIns$3.invoke(KotlinBuiltIns.java:93)

We found that starting from .NET 7.0 the SDK excludes kotlin-related code from resulting APK file.
Related issues/PRs are:
AndroidPackagingOptionsExclude cannot be modified
Fix AndroidPackagingOptionsExclude so it can be overridden in the csproj
We applied the way from this comment<PHONE_NUMBER> and built the app using .NET 8.0 SDK. The resulting APK contained the kotlin-related code and our app works fine.
But in .NET 9.0 the AndroidPackagingOptionsExclude and the new AndroidPackagingOptionsInclude items were moved to AutoImport.props (docs). So the new way for us to modify was to use the Directory.Build.props file:
<Project>
    <ItemGroup>
        <AndroidPackagingOptionsExclude Remove="@(AndroidPackagingOptionsExclude)" />
        <AndroidPackagingOptionsInclude Include="$([MSBuild]::Escape('*.kotlin*'))" />
        <AndroidPackagingOptionsInclude Include="$([MSBuild]::Escape('*.test*'))" /> <!-- added here as flag that our props have been applied -->
    </ItemGroup>
</Project>

But resulting APK still lacked the kotlin code. In msbuild logs we found that SDK still removes kotlin code:
                   AndroidPackagingOptionsExclude
                       *.kotlin*
                       *.kotlin_*
                       DebugProbesKt.bin
                       DebugProbesKt.bin
                   AndroidPackagingOptionsInclude
                       *.kotlin*
                       *.kotlin_builtins
                       *.test*

Ignoring jar entry 'META-INF/annotations.kotlin_module' from '05D34BA5CA8637CF.jar'. Filename matched the exclude pattern '.*\.kotlin.*'. (TaskId:358)
                     Ignoring jar entry 'META-INF/kotlin-stdlib.kotlin_module' from 'F91D79B39A269A7E.jar'. Filename matched the exclude pattern '.*\.kotlin.*'. (TaskId:358)
                     Ignoring jar entry 'kotlin/annotation/annotation.kotlin_builtins' from 'F91D79B39A269A7E.jar'. Filename matched the exclude pattern '.*\.kotlin.*'. (TaskId:358)
                     Ignoring jar entry 'kotlin/collections/collections.kotlin_builtins' from 'F91D79B39A269A7E.jar'. Filename matched the exclude pattern '.*\.kotlin.*'. (TaskId:358)
                     Ignoring jar entry 'kotlin/coroutines/coroutines.kotlin_builtins' from 'F91D79B39A269A7E.jar'. Filename matched the exclude pattern '.*\.kotlin.*'. (TaskId:358)
                     Ignoring jar entry 'kotlin/internal/internal.kotlin_builtins' from 'F91D79B39A269A7E.jar'. Filename matched the exclude pattern '.*\.kotlin.*'. (TaskId:358)
                     Ignoring jar entry 'kotlin/kotlin.kotlin_builtins' from 'F91D79B39A269A7E.jar'. Filename matched the exclude pattern '.*\.kotlin.*'. (TaskId:358)
                     Ignoring jar entry 'kotlin/ranges/ranges.kotlin_builtins' from 'F91D79B39A269A7E.jar'. Filename matched the exclude pattern '.*\.kotlin.*'. (TaskId:358)
                     Ignoring jar entry 'kotlin/reflect/reflect.kotlin_builtins' from 'F91D79B39A269A7E.jar'. Filename matched the exclude pattern '.*\.kotlin.*'. (TaskId:358)
                     Ignoring jar entry 'META-INF/kotlin-stdlib-jdk7.kotlin_module' from 'F91D79B39A269A7E.jar'. Filename matched the exclude pattern '.*\.kotlin.*'. (TaskId:358)
                     Ignoring jar entry 'META-INF/kotlin-stdlib-jdk8.kotlin_module' from 'F91D79B39A269A7E.jar'. Filename matched the exclude pattern '.*\.kotlin.*'. (TaskId:358)

Steps to Reproduce

File -> New Project -> MAUI (Android) .NET 9.0
Add

<ItemGroup>
      <PackageReference Include="Xamarin.Kotlin.StdLib" Version="<IP_ADDRESS>" />
    </ItemGroup>

Publish the app in debug mode. The resulting APK doesn't have kotlin related code.

The link on .NET 8.0 project (works fine): link
The link on .NET 9.0 project (doesn't work): link
Did you find any workaround?
Only the way is bypass the issue is to commented out the code in AutoImports.props:

Relevant log output
AndroidPackagingOptionsExclude
                       *.kotlin*
                       *.kotlin_*
                       DebugProbesKt.bin
                       DebugProbesKt.bin
                   AndroidPackagingOptionsInclude
                       *.kotlin*
                       *.kotlin_builtins
                       *.test*

Ignoring jar entry 'META-INF/annotations.kotlin_module' from '05D34BA5CA8637CF.jar'. Filename matched the exclude pattern '.*\.kotlin.*'. (TaskId:358)
                     Ignoring jar entry 'META-INF/kotlin-stdlib.kotlin_module' from 'F91D79B39A269A7E.jar'. Filename matched the exclude pattern '.*\.kotlin.*'. (TaskId:358)
                     Ignoring jar entry 'kotlin/annotation/annotation.kotlin_builtins' from 'F91D79B39A269A7E.jar'. Filename matched the exclude pattern '.*\.kotlin.*'. (TaskId:358)
                     Ignoring jar entry 'kotlin/collections/collections.kotlin_builtins' from 'F91D79B39A269A7E.jar'. Filename matched the exclude pattern '.*\.kotlin.*'. (TaskId:358)
                     Ignoring jar entry 'kotlin/coroutines/coroutines.kotlin_builtins' from 'F91D79B39A269A7E.jar'. Filename matched the exclude pattern '.*\.kotlin.*'. (TaskId:358)
                     Ignoring jar entry 'kotlin/internal/internal.kotlin_builtins' from 'F91D79B39A269A7E.jar'. Filename matched the exclude pattern '.*\.kotlin.*'. (TaskId:358)
                     Ignoring jar entry 'kotlin/kotlin.kotlin_builtins' from 'F91D79B39A269A7E.jar'. Filename matched the exclude pattern '.*\.kotlin.*'. (TaskId:358)
                     Ignoring jar entry 'kotlin/ranges/ranges.kotlin_builtins' from 'F91D79B39A269A7E.jar'. Filename matched the exclude pattern '.*\.kotlin.*'. (TaskId:358)
                     Ignoring jar entry 'kotlin/reflect/reflect.kotlin_builtins' from 'F91D79B39A269A7E.jar'. Filename matched the exclude pattern '.*\.kotlin.*'. (TaskId:358)
                     Ignoring jar entry 'META-INF/kotlin-stdlib-jdk7.kotlin_module' from 'F91D79B39A269A7E.jar'. Filename matched the exclude pattern '.*\.kotlin.*'. (TaskId:358)
                     Ignoring jar entry 'META-INF/kotlin-stdlib-jdk8.kotlin_module' from 'F91D79B39A269A7E.jar'. Filename matched the exclude pattern '.*\.kotlin.*'. (TaskId:358)

The link on .NET 8.0 project (working):
The link on .NET 9.0 project (working):

This is probably related https://github.com/dotnet/android/pull/8459.

I suspect Directory.Build.props might well be too early in the build process. It is one of the first files evaluaed, as a result the AndroidPackagingOptionsExclude is not being cleared by the <AndroidPackagingOptionsExclude Remove="@(AndroidPackagingOptionsExclude)" /> code.

hey @dellis1972
I have tried to import the props in the way you suggested, but no luck.
The updated csproj:
<Project Sdk="Microsoft.NET.Sdk">
    <PropertyGroup>
        <TargetFramework>net8.0-android</TargetFramework>
        <SupportedOSPlatformVersion>21</SupportedOSPlatformVersion>
        <OutputType>Exe</OutputType>
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
        <ApplicationId>com.companyname.KotlinReflectTest90</ApplicationId>
        <ApplicationVersion>1</ApplicationVersion>
        <ApplicationDisplayVersion>1.0</ApplicationDisplayVersion>
        <Platform>Android</Platform>
        <TrimMode>full</TrimMode>
    </PropertyGroup>
    <ItemGroup>
        <PackageReference Include="Xamarin.Kotlin.StdLib" Version="<IP_ADDRESS>"/>
    </ItemGroup>
    <Import Project="Foo.props"/>
</Project>

The logs still reports the old AndroidPackagingOptionsExclude values:
                   AndroidPackagingOptionsExclude
                       *.kotlin_*
                       DebugProbesKt.bin
                       DebugProbesKt.bin
                   AndroidPackagingOptionsInclude
                       *.kotlin_builtins

The log output:
Ignoring jar entry 'META-INF/annotations.kotlin_module' from '05D34BA5CA8637CF.jar'. Filename matched the exclude pattern '.*\.kotlin_.*'. (TaskId:357)
                     Ignoring jar entry 'META-INF/kotlin-stdlib.kotlin_module' from 'F91D79B39A269A7E.jar'. Filename matched the exclude pattern '.*\.kotlin_.*'. (TaskId:357)
                     Ignoring jar entry 'kotlin/annotation/annotation.kotlin_builtins' from 'F91D79B39A269A7E.jar'. Filename matched the exclude pattern '.*\.kotlin_.*'. (TaskId:357)
                     Ignoring jar entry 'kotlin/collections/collections.kotlin_builtins' from 'F91D79B39A269A7E.jar'. Filename matched the exclude pattern '.*\.kotlin_.*'. (TaskId:357)
                     Ignoring jar entry 'kotlin/coroutines/coroutines.kotlin_builtins' from 'F91D79B39A269A7E.jar'. Filename matched the exclude pattern '.*\.kotlin_.*'. (TaskId:357)
                     Ignoring jar entry 'kotlin/internal/internal.kotlin_builtins' from 'F91D79B39A269A7E.jar'. Filename matched the exclude pattern '.*\.kotlin_.*'. (TaskId:357)
                     Ignoring jar entry 'kotlin/kotlin.kotlin_builtins' from 'F91D79B39A269A7E.jar'. Filename matched the exclude pattern '.*\.kotlin_.*'. (TaskId:357)
                     Ignoring jar entry 'kotlin/ranges/ranges.kotlin_builtins' from 'F91D79B39A269A7E.jar'. Filename matched the exclude pattern '.*\.kotlin_.*'. (TaskId:357)
                     Ignoring jar entry 'kotlin/reflect/reflect.kotlin_builtins' from 'F91D79B39A269A7E.jar'. Filename matched the exclude pattern '.*\.kotlin_.*'. (TaskId:357)
                     Ignoring jar entry 'META-INF/kotlin-stdlib-jdk7.kotlin_module' from 'F91D79B39A269A7E.jar'. Filename matched the exclude pattern '.*\.kotlin_.*'. (TaskId:357)
                     Ignoring jar entry 'META-INF/kotlin-stdlib-jdk8.kotlin_module' from 'F91D79B39A269A7E.jar'. Filename matched the exclude pattern '.*\.kotlin_.*'. (TaskId:357)

If you are using .net 8 it will still pull in the dotnet 8 targets even if you are using .net 9 afaik.

also not I did say there is a bug for Debug builds. For release it works as expected here.

If you are using .net 8 it will still pull in the dotnet 8 targets even if you are using .net 9 afaik.
Noted, thank you! I tried to build net9.0-android using .NET 9.0 SDK with <Import Project="Foo.props" /> both in Debug/Release mode and the kotlin folder is inside of resulting APK.


Store URL encoded key-value pairs as [String: [String]]

… rather than a [String: String].

Description

When a GET request is done with query parameters, such as http://example.com/search?query=foobar, those parameters are accessible in the .queryParameters property of the RouterRequest object in the handler. If a POST is done with the default "application/x-www-form-urlencoded" enctype, those parameters are accessible by calling .body?.asURLEncoded on the RouterRequest object. Both of these are [String: String] dictionaries. These changes change them to be [String: [String]] dictionaries; in other words, rather than each key having a single string value, they have an array of strings.
A PR for KituraContracts will also need to be accepted to reflect these changes. For now, if you clone my branch to test, you'll need to change the line for KituraContracts in Kitura's Package.swift to:
        .package(url: "https://github.com/NocturnalSolutions/KituraContracts.git", .branch("UrlEncodingValuesArray")),

Motivation and Context

The code that decodes the URL encoding to create these dictionaries is in String+Extensions.swift.
Consider a form such as:

What are your favorite pizza toppings?

<form method="get">
  <input type="checkbox" name="toppings" value="extraCheese" />Extra cheese
  <input type="checkbox" name="toppings" value="pepperoni" />Pepperoni
  <input type="checkbox" name="toppings" value="pineapple" />Pineapple
  <input type="checkbox" name="toppings" value="anchovies" />Anchovies
  <input type="submit" />
</form>

If you were to select both "Extra cheese" and "Pineapple," the resulting URL-encoded string would look something like toppings=extraCheese&toppings=pineapple. So there are two values for the same key.
However, Kitura will only allow a single string value for each key. So Kitura works around this by using a comma to concatenate all of the values. The result is that request.queryParameters["toppings"] will be "extraCheese,pineapple".
I don't like this. For one, it makes it impossible to simply count how many values you have for a key without doing something like .split(separator: ",").count. For another, what if a value itself has a comma? Now we're in painful territory.
Unfortunately, this is a fairly significant change that will break existing sites that use forms. Basically, instead of using let name = request.queryParameters["name"], they'll have to use let name = request.queryParameters["name"]?.first if they're just expecting a single value in the request. On the other hand, for those if they're doing silliness like let names = request.queryParameters["name"]?.split(separator: ","), it'll just become let names = request.queryParameters["name"].
I'm willing to bet Swift has a way to make a thing which acts like a dictionary if you do a subscript operation on it but acts like a string otherwise, but I think that might be overengineering in this case.
How Has This Been Tested?

Existing tests have been adjusted to work with the change.
Checklist:

[ ] If applicable, I have updated the documentation accordingly.
[ ] If applicable, I have added tests to cover my changes.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

The CI failing is expected as, as mentioned above, this PR is recursively dependent on https://github.com/IBM-Swift/KituraContracts/pull/16.

Thank you for the PR!  As you mentioned, this is unfortunately an API breaking change so merging it would require us to tag Kitura 3.0 - which we don't plan to do any time soon.
Is there some way we could add the functionality you want in an additive way?  i.e. by leaving request.queryParameters unchanged and adding new API instead?

Is there some way we could add the functionality you want in an additive way? i.e. by leaving request.queryParameters unchanged and adding new API instead?

To be clear, are you speaking of implementing it another way inside of Kitura, or as a separate package/module that wouldn't involve patches to Kitura?

I think inside of Kitura would probably be fine.

Closing as the successor #1238 is now merged.


Legend uses years, will not update automatically in future

As of now the map legend states the time period of historic and current (e.g., 2005). That is hard-coded into the website. If MassBays were to update the datasets, the legend would be wrong.
I could change things around and load the time periods from the dataset files, but I feel like a more fool proof option would be to just switch back to "historic" and "current" as legend entries.

addressed with #86


fix a bug in select-query.md which the property_form lack of the『granularity』

There result would be {"error"=>"Unknown exception",
"errorMessage"=>nil, "errorClass"=>"java.lang.NullPointerException",
"host"=>nil} when the json lack of『granularity』.

@fanjieqi where is teh bug fix? I just see the docs
Also, can you fill out http://druid.io/community/cla.html?
Thx,
FJ

Sorry for my poor English.
I mean the property form in the select-query.md has a problem that it lack of the "granularity".
There isn't a bug in the code.

@fanjieqi can you fill out the CLA? http://druid.io/community/cla.html

@fjy ，I've submitted the CLA. Could you please check Did I submit it successfully?


Goalpost 1: inspect keys

[x] Fixtures - mnemonic, seed, (accounts?) addresses via https://github.com/dashhive/dashhd.js/pull/6
[x] full path => address
[x] hardened path + range => addresses
[x] hex seed => mnemonic
[x] is a root + partial path => child root + complete path equal to root + full path? via #3
[x] hex seed => derived key? *****
[x] README
[x] Publish to npm

On hold:

Debug Info: mnemonic => hex seed + (checksum?)

Closed via #3, #6, #7


Proxies not working

My script shows that proxies aren't working. Am I doing something wrong?
Here's the code if you need:
Script.zip

Code here:
# Important stuff here
from json import load
import requests
from random import choice, randint, shuffle
from urllib2 import urlopen

url = 'http://epiccodes.com'

# Random proxies from - http://proxygaz.com
proxies = {'https': 'https:<IP_ADDRESS>:9064',
           'https': 'https:<IP_ADDRESS>:80',
           'https': 'https:<IP_ADDRESS>:80',}

# Retrieves IP Address
def IPAddress():
    IP = load(urlopen('http://httpbin.org/ip'))['origin']
    return(IP)

# Retrieves Cookie
def CookieIP():
    r = requests.get(url,
                     # Using proxy
                     proxies=proxies)
    try:
        Cookie = r.headers['Set-Cookie']
        return(Cookie)
    except KeyError as e:
        return("Website might be down")

# This prints your IP
print("IP Address: " + IPAddress())

# The website's cookie has your IP in it. If proxy works, then the IP on the
# cookie should be different from the other IP.
print("\nProxy's IP: " + CookieIP())

A few things:

If you look at the proxy documentation you'll see that your proxy dictionary should look like this:
proxies = {'https': 'https://<IP_ADDRESS>:9064'}

Note the //.

You haven't described what kind of proxies these are. (Hint: If they're SOCKS proxies, those will not work with requests... yet.)

You haven't described what you're seeing versus what you're expecting.

Questions belong on StackOverflow. Please ask future questions there.

If you look at my script (the one @kennethreitz  posted), that's what I did.
proxies = {'https': 'https:<IP_ADDRESS>:9064',
'https': 'https:<IP_ADDRESS>:80',
'https': 'https:<IP_ADDRESS>:80',}

The proxies I tried to use are HTTPS

If you look at the cookies for http://epiccodes.com, you'll see your IP in the cookies, I was expecting to see the proxy's IP in the cookie when I use proxies=proxies in the get request.

My bad, I didn't know. Will do in the future if I have any questions.

If you look at my script (the one @kennethreitz posted), that's what I did.

It isn't. Please look closely at what you wrote and what I wrote. Further, which proxy do you expect to be used? Creating a dictionary with a repeated key is undefined behaviour (as to which value is kept) in Python.

@Pr0xy671 you are specifying 3 proxies. Try only doing one. Also, add a // to your proxy URL.
p.s. you can use http://httpbin.org/ip to get ip address easily.

Ok, I tried doing this way and still nothing.
r = requests.get('http://httpbin.org/ip', proxies={'https': 'https://<IP_ADDRESS>:3128'})
print(r.json()['origin'])
It then prints out my real IP and not <IP_ADDRESS>

@Pr0xy671 it's because you specified the proxy for HTTPS ({'https': …}) but requested a HTTP page


The plugin can't work for me

Hi,
I follow the install illustration installed the plugin,but it can't work.
My environment is:
IDEA: 2017.2.5
JDK Version: java8_131
DECVM Install:

IDEA Plugin Setting:

When i debug run the  configuration ,there is not any changes than before.

Hi,
I found the reason ,whenmake Gradle delagate the IDEA' building, the howswap will not work.

Gradle used jvm  may be is another  different from the IDEA configuration .
How to make  hotswap-agent work in this case?

@lugreen Actually it doesn't matter if you use delegate IDE build to Gradle or not.
In your particular case you are trying to run some tests via Gradle runner.
What is the real use case to use hot swap agent in test? The main idea behind hot swap agent to use
a better redeploy in case if you are debugging some application started in IDE. Tests are usually can be simple restarted because there is no overhead to stop test and run it again.

By the way. It still possible to use hotswap agent via plugin in test configured with Gradle Test Runner.
It fully depends which JVM use Gradle to run your test. You can try to reconfigure Gradle to use JVM with DCVM installed.


Can't move tabs around (again)

Type: Bug
For some inexplicable reason the future to move tabs around, left and right, down to terminal, split to compare, or whatever stops working...
I have already tried (not a clean one, that would be too much work) to reinstall. Also disable all extensions, no change. Look for settings about "drag and drop" that are unchanged.
UPDATE: The issue is resolved for the moment by signing out and into Windows 10.
 To help narrow it down, please take the time to follow below steps. Thanks a lot and happy coding 🙏
Is the issue caused by an Extension?
Stop VS Code and from the command line (NOT the integrated terminal in Code), execute: code --disable-extensions and try your steps again to see if it reproduces. If it still reproduces, jump to the next chapter.
If you see it is an issue with the extension, please run the command Start Extension Bisect and follow the instructions to find the extension that is causing this issue.

Please report the issue to the extension causing this.
Is the issue caused by VS Code Core?
If the issue is not caused by an extension, it is maybe caused by your configuration. Try to run code --disable-extensions --user-data-dir <directory> where <directory> is an empty folder. This will ensure Code is starting with a fresh data directory, e.g. no specific settings and without any extensions running.
If it still reproduces, it was maybe fixed already in our nightly release. Please download from https://code.visualstudio.com/insiders/ and see if you can reproduce the issue.
Finally, to help us narrow down what change caused the issue, please run the following command to find the build. It will start previous releases of VS Code insiders to see where the regression was introduced:

npx --yes vscode-bisect@latest
follow the instructions until you found the offending build
report back the commit range in this issue

Thanks!

Ok this is not helpful.


SSH (backticks and absent command)

What article on docs.github.com is affected?
Generating a new SSH key and adding it to the ssh-agent

generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent.md
What part(s) of the article would you like to see updated?
Reduce the amount of provided OS specific information in the file.
Mac and Linux
$ eval "$(ssh-agent -s)"
> Agent pid 59566

Windows (uses backticks)
The command could be the same as on the above OSes.
# start the ssh-agent in the background
$ eval `ssh-agent -s`
> Agent pid 59566

Adding your SSH key to the ssh-agent
For Linux and Windows another line could be added accessing a new kill_ssh_agent.md file.
4. {% data reusables.command_line.kill_ssh_agent %}
kill_ssh_agent.md (proposed)
Kill the current agent (given by the SSH_AGENT_PID environment variable).
```shell
$ eval "$(ssh-agent -k)"
> Agent pid 59566 killed
```

Here's the sole reference to killing the agent PID.
$ grep -nr ssh-agent content | grep kill
content/github/authenticating-to-github/connecting-to-github-with-ssh/working-with-ssh-key-passphrases.md:84:The `ssh-agent` process will continue to run until you log out, shut down your computer, or kill the process.
$

Perhaps the OS specific content regarding keychain could be hosted by the vendor and linked to.

"Working with SSH key passphrases"
working-with-ssh-key-passphrases.md
[Mac version of the page]
Saving your passphrase in the keychain
This content is perhaps dated.
[Windows version of the page]
Auto-launching ssh-agent on Git for Windows
Perhaps this content could be shifted to a Wiki page.
Additional information
If GitHub Inc. wants to hire me to review the entire repository send me an e-mail.

@fluesvamp Thanks for opening an issue! Please update your OP to use the issue template, this helps us to triage issues to the right folks.
Can you also clarify why you'd like to see the changes you're suggesting? Thank you!

@janiceilene

"Working with SSH key passphrases"
Auto-launching ssh-agent on Git for Windows
Perhaps this content could be shifted to a Wiki page.

The translations of the Windows version of this page are also affected by #6753.
English
Auto-launching ssh-agent on Git for Windows

Auto-launching ssh-agent on Git for Windows

Japanese
Git for Windows で ssh-agent を自動的に起動する

Git for Windows で ssh-agent を自動的に起動する

Thanks for the update @fluesvamp! I'll triage this for the team to take a look 👀

Hi @fluesvamp, thanks for all of these ideas! Let's unify the command for starting the ssh-agent in "Generating a new SSH key and adding it to the ssh-agent" across OSes, as you suggest. However, we'll keep "Working with SSH key passphrases" as is.
Could you please provide a bit more explanation of your proposed new kill_ssh_agent.md file? Thanks!

@lecoursen
generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent.md
- $ eval `ssh-agent -s`
+ $ eval "$(ssh-agent -s)"

I presume you concur on the above change.
generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent.md
1. {% data reusables.command_line.start_ssh_agent %}
The above line appears in both the mac and linux content; it accesses start_ssh_agent.md.

4. {% data reusables.command_line.kill_ssh_agent %}

The new file would close the socket and unset the shell variables.

@lecoursen

Perhaps the OS specific content regarding keychain could be hosted by the vendor and linked to.

I've sent an enquiry today to the macOS devs.

I presume you concur on the above change.

Yes!

The new file would close the socket and unset the shell variables.

Thanks! Feel free to add that to https://github.com/github/docs/pull/6994 if you like! 😊

@lecoursen
Created another branch for a separate PR.
Is it sufficiently unambiguous (with the changes) that one leaves the process running until one no longer needs it?

I'll link to that question in the PR, which someone on the team will review soon!

@lecoursen
Can you ask a reviewer to look at this?
generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent.md
  3. Add the SSH key to your account on {% data variables.product.product_name %}. For more information, see "[Adding a new SSH key to your {% data variables.product.prodname_dotcom %} account](/github/authenticating-to-github/adding-a-new-ssh-key-to-your-github-account)."

+ {% note %}
+
+ **Note:** The ssh-agent will continue to run until you kill the process.
+
+ {% endnote %}
+
  {% endwindows %}

  3. Add the SSH key to your account on {% data variables.product.product_name %}. For more information, see "[Adding a new SSH key to your {% data variables.product.prodname_dotcom %} account](/github/authenticating-to-github/adding-a-new-ssh-key-to-your-github-account)."

+ {% note %}
+
+ **Note:** The ssh-agent will continue to run until you kill the process.
+
+ {% endnote %}
+
  {% endlinux %}

AIR/©®*~44216