POST not saving all data

When I POST using the simple setup described on the project page, the post creates a new id, but does not add the title and author I specify in the JSON body.
I do a POST to:  http://localhost:3000/posts
Body is: { "title": "hello world", "author": "typicode" }
Result is HTTP 201, with body: { "id": 2 }
db.json shows id 2, but that's it
What am I missing?

@BrianKrohn, how did you add the Content-Type?  I have added it on my test, but I still seem to be only able to post IDs. I'm not too sure if I need to associate it with the POST test?
Please see issue 821 > https://github.com/typicode/json-server/issues/821

Don't worry guys, I had incorrectly added the HTTP Header Manager. Thanks 👍 :)

i had the same problem, found the solution here https://www.youtube.com/watch?v=FyZBTbv7UM0

When I am using this way from postman, it is working but when I try with XMLHttpRequest title & author are not getting created only id is created. Anything else i am missing to add in headers.
request.setRequestHeader("Content-Type", "application/json");
var postBody = '{ "title": "hello world", "author": "typicode" }';
Anything else I need to do when using XMLHttpRequest

When I am using this way from postman, it is working but when I try with XMLHttpRequest title & author are not getting created only id is created. Anything else i am missing to add in headers.
request.setRequestHeader("Content-Type", "application/json");
var postBody = '{ "title": "hello world", "author": "typicode" }';
Anything else I need to do when using XMLHttpRequest

How to add content type for json-server


👻 Add options to customize behavior of unknown Wasm imports

Adds a new shared option to the CLI with three behavior modes:
      --unknown-import-behavior <UNKNOWN_IMPORT_BEHAVIOR>
          Set the behavior for unknown imports.

          Note that if a program only works with a non-default setting for this flag, it is unlikely to be publishable to Fastly.

          [default: link-error]

          Possible values:
          - link-error:   Unknown imports are rejected at link time (default behavior)
          - trap:         Unknown imports trap when called
          - zero-or-null: Unknown imports return zero or a null pointer, depending on the type

This ended up touching more files than I'd expect, because I had to make the integration test harness bubble out link-time errors rather than .expect()ing them, so there are quite a few new ?s across the integration test suite.

This sounds great! Since we're using the privileged hostcall bill_for_service in the challenge service, we currently have a cargo viceroy feature to avoid referencing that hostcall for local testing. I think the zero-or-null behavior would work perfectly there and make local testing less annoying.


docs: fix typo

What does this PR do?

Motivation

More

[ ] Added/updated tests
[ ] Added/updated documentation

Additional Notes

I'm sorrry. I'm not sure anymore this is correct. By skimming the docs I couldn't find a reference to my-service. So I just assumed it should be my-container.

Hello,
Sorry but the names are currently right.
Thanks anyway.


How to use ComputeElementFlux and ComputeFluxEnergy?

Hi everyone! I am a newbie using MFEM. I have some problem when I try to compute Energy of elasticity equation.  I think I do not know how to use ComputeElementFlux and ComputeFluxEnergy function to calculate. More specifically, I want to apply into the examples 2 to calculate the Energy. May you guys help me by performing calculation for ex2
Thank you!

Hi @nghiakvnvsd ,
Sorry I'm not familiar with elasticity equation. Could you please provide linear form or bilinear form to compute energy?

Hi @nghiakvnvsd ,
Sorry I'm not familiar with elasticity equation. Could you please provide linear form or bilinear form to compute energy?
Thanks for replying! I want to apply into the example 2 (https://github.com/mfem/mfem/blob/master/examples/ex2.cpp). You can see the bilinear form and linear form in it.

Actually, MFEM provides a function to compute it. But I do not know how to use it (http://mfem.github.io/doxygen/html/classmfem_1_1ElasticityIntegrator.html)

Hi @nghiakvnvsd,
The methods ComputeElementFlux and ComputeFluxEnergy are typically used for the Zienkiewicz-Zhu error estimator. If that is what you are interested in, see Example 21/21p which illustrates their use for a linear elasticity problem.
If you just want to compute the energy from the FE formulation, E(u) = (1/2) a(u,u) - b(u) then you can use the methods BilinearForm::FullInnerProduct and LinearForm::operator()(const GridFunction &). Since the LinearForm is typically modified when eliminating boundary conditions, then it will be easier to copy the LinearForm to a Vector after assembly but before elimination of b.c. and then later compute b(u) by using the InnerProduct with the solution GridFunction.


help wanted: high(ish) resolution heatmap performance

I have a some 2d data which is unquestionably too large to plot on scatterplot, so I am downsampling and trying to plot on Heatmap. I also need ability to highlight.
I'm playing with the downsampling/resolution of the outputted heatmap.
The framerate/responsiveness of the highlight tool is good up until around 500 datapoints, higher than this and it gets lag-y.
My project requires a visual resolution such that 1-2k datapoints are plotted. Are there any optimizations I can make? I didn't see a canvas mode for Heatmap like there are for other series types - has development of this been considered?
Suggestions welcome.
       <XYPlot
          height={500}
          width={500}
        >
          <XAxis />
          <YAxis />
          <HeatmapSeries
            colorType="literal"
            data={this.state.plotBinData}
          />
          <Highlight
            drag
            onBrush={area => this.setState({filter: area})}
            onDrag={area => this.setState({filter: area})}/>
        </XYPlot>

just saw this issue which addresses my question re a canvas series in the future.

Using highlight code from the showcase example and things are buttery smooth for way higher resolutions than I need:
          <Highlight

            onBrushEnd={area => this.setState({lastDrawLocation: area})}
            onDrag={area => this.setState({
              lastDrawLocation: {
                bottom: lastDrawLocation.bottom + (area.top - area.bottom),
                left: lastDrawLocation.left - (area.right - area.left),
                right: lastDrawLocation.right - (area.right - area.left),
                top: lastDrawLocation.top + (area.top - area.bottom)
              }})}/>


Fix mypy syntax errors

Fixes issue 19290.
All mypy [syntax] error codes are resolved:

Function has duplicate type signatures resolved by using the (...) in the type return comment
Type signature has too few arguments resolved by switching from single line type comment to multiline with (...) in the type return comment.  Unknown args were left unannotated.
Type signature has too many arguments resolved by deleting excess type arguments

@tasherif-msft can you please look at this PR?

LGTM


Edde\Protocol: Prevent oversaving of Elements

Currently when an Error occures, this Error is saved many times (and created many times); the problem is in AbstractProtocolHandler.

So this was fixed. I hope.


Disable scroll when dragging at edges of TextEdit

Fixes #59822
I checked on master and this function doesn't seem to work properly, so I guess that's why this bug doesn't appear lol.

I think that scroll when dragging at edges should be disabled only if text_editor/cursor/scroll_past_end_of_file is enabled on the editor.

Done.

Thanks!


Add "rule enforcer"

Add a feature that would run checks similar to the CI reusable workflow that is now mandatory in app repos.
The idea is to check the code of the apps opened in vscode like the rule enforcer does in the CI of app repositories.
It is not about checking the code of the extension itself.

check manifest
check icons
check app load params --> check db
check makefile (standard)
check readme
check clang

script already present in the docker file ?

Fixed in #55


tncattach: init at 0.1.9

Description of changes

Originally leveraged in an overlay: https://github.com/sarcasticadmin/ham-overlay/tree/master/pkgs/tncattach
I have been using this to provide TCP/IP over packet for my amateur radio equipment. CC @pkharvey
$ ./result/bin/tncattach --help
Usage: tncattach [OPTION...] port baudrate

Attach TNC devices as system network interfaces

  -m, --mtu=MTU              Specify interface MTU
  -e, --ethernet             Create a full ethernet device
  -i, --ipv4=IP_ADDRESS      Configure an IPv4 address on interface
  -n, --noipv6               Filter IPv6 traffic from reaching TNC
      --noup                 Only create interface, don't bring it up
  -T, --kisstcp              Use KISS over TCP instead of serial port
  -H, --tcphost=TCP_HOST     Host to connect to when using KISS over TCP
  -P, --tcpport=TCP_PORT     TCP port when using KISS over TCP
  -t, --interval=SECONDS     Maximum interval between station identifications
  -s, --id=CALLSIGN          Station identification data
  -d, --daemon               Run tncattach as a daemon
  -v, --verbose              Enable verbose output
  -?, --help                 Give this help list
      --usage                Give a short usage message
  -V, --version              Print program version

Mandatory or optional arguments to long options are also mandatory or optional
for any corresponding short options.

To attach the TNC connected to /dev/ttyUSB0 as an ethernet device with an MTU
of 512 bytes and assign an IPv4 address, while filtering IPv6 traffic, use:

	tncattach /dev/ttyUSB0 115200 -m 512 -e --noipv6 --ipv4 <IP_ADDRESS>/24

Station identification can be performed automatically to comply with Part 97
rules. See the README for a complete description. Use the --id and --interval
options, which should commonly be set to your callsign, and 600 seconds.

Report bugs to<EMAIL_ADDRESS>
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@sikmir thank you for the feedback! Ive implemented those changes and this should be ready for another review.

Result of nixpkgs-review pr 191103 run on x86_64-linux 1

1 package built:

tncattach

@sikmir fixed up the PR with those suggestions, thank you! Let me know how this looks now


Track Survey Design Products for Runs including Run 1.1

The survey design products that will be used during simulations of different runs are:

[x] minion_1016_desc_dithered_vn.db an OpSim like database with additional columns with the positional and rotational dithers used for DC2.
[x] Set of OpSim visits that are included in the simulation

These also depend on a set of underlying data products

[x] minion_1016_desc_vn.db An undithered version of OpSim Database
[x] Set of visits that overlap the main and uDDF survey region in WFD and DDF

which in turn depend on a set of inputs and decisions that were taken.
We should track the versions of the set of products used for simulations, the underlying set inputs and decisions for each set of products which we then use in simulations. As has been discussed in #83 and other places: We will have versions of these products on nersc directories, but will keep documents that note the progress with version upgrades on this repository. The versions that we will use in simulation runs (like 1.1 or later) should be on the google doc notes for DC2. For this purpose I propose  having a directory in documents with a README file describing each of the products (including locations) and new columns we have added, and the input in notes corresponding to the product, and a csv file which shows the set of associated products. As an example I will make a PR putting such a directory in the Documents directory of this repository (but can move it elsewhere).

@rbiswas4 This one can be closed now also, right? Thanks!

Might be good to keep this open as  DC2 project tracker for completing the notes, which are not done yet. Sorry!
Keeping this open helps letting you keep tabs on us. That is useful I think.

@rbiswas4 Now the notes are complete, right? Do you want to close this?

@rbiswas4 Can this be closed now? As @katrinheitmann pointed out I think the notes are done now.


Input field gets cleared/freeze/blocked while typing on IE11

Whenever I use your autocomplete on Chrome, Edge it works fine. If I use it in IE11, when I start typing I get blocked and cannot continue typing. When the response is received from the server with the suggestions whatever was in the input filed gets cleared and the suggestions do not appears. I can start typing again once the field is cleared.

@maximedubois thanks for reporting, however I am unable to reproduce. Are you able to provide a little more detail?

here's a repo I created simple aurelia project with your autocomplete to reproduce.
From what I can see there's a kind of delay of being able to type before the list shows the result. Once the result is displayed in the list then I'm able to start typing again. When using real api that might have a delay before getting an answer it's getting worse.
https://github.com/maximedubois/aurelia-autocomplete-ie11-issue.git

@maximedubois ok there is some native code in IE that is just thrashing.....if you add corejs (on our app we use 2.5.3).....
yarn add<EMAIL_ADDRESS>and then add to prepend in aurelia.json....
"node_modules/core-js/client/core.js"
Performance is great so there must be some polyfill there that is fixing it......you could possibly try using the aurelia-polyfills package as it may achieve the same results if you don't want to add corejs dependency.

@maximedubois hopefully this answers your question? Going to close for now, please let me know if you still have any troubles...


Remove echo from being used to trigger itself

Happens a lot that in speaker mode, the bot triggers itself with its own voice.
Would it be possible to suppress its own voice by integrating an echo cancellation? We already have the voice in and the voice out, maybe would it be possible to suppress the last seconds of the voice out from the voice in.
It's related to WebRTC AEC (Acoustic Echo Cancellation).

Done in 416afd583681ae77e86729111d3d25319544ee19. noisereduce has been implemented for that.


Review and improve installation modes

With v0.9, IPM gains the ability to be installed namespace-specific, but is currently restricted to explicitly not run in %SYS.
Really the main goal had been to get it out of IRISSYS, not to prevent legitimate use cases (meaning, currently: not modifying IRISLIB) from running in the %SYS namespace.
Need to review %IPM.Main:EnableNS to better handle enabling instance-wide. This might be able to use %ALL (which would be valid), need to test; otherwise it'll be a ton of namespace-specific mappings.
Upon migration from v0.7, instance-wide should be the default.

Dev is done; still needs doc.

Doc is covered through a handful of wiki updates.


[17.07] Fix wrong changelog entries

These issues also exist in the release notes. They should be fixed there as well.

CI failures are unrelated. This is a docs-only PR.

@albers could you also please add (experimental) in front of Implement long running interactive session and sending build context incrementally while your at it ?

@vieux done.

LGTM


Custom scopes in with/withCount closures

Larastan Version: 0.3.4
--level used: 5 (default)

Description:
 ------ -------------------------------------------------------------------------------------
  Line   app/Http/Controllers/Browse/CatalogueController.php
 ------ -------------------------------------------------------------------------------------
  95     Call to an undefined method Illuminate\Database\Eloquent\Builder::matchingSearch().
 ------ -------------------------------------------------------------------------------------

The issue here is that my Product model has public function scopeMatchingSearch(Builder $query) {...}
however larastan is not picking up that context inside the closure, meaning it believes I only have access to the query builder methods and not the model scopes.
Laravel code where the issue was found:
class Product extends Model {

  public function scopeMatchingSearch(Builder $query, $term): Builder
  {
    return $query->where('title', 'like', "%{$term}%")
      ->orWhere('code', 'like', "%{$term}%")
  }

}

class Catalogue extends Model {

  public function products(): HasMany
  {
    return $this->hasMany(Product::class, 'catalogue_id');
  }

}

Catalogue::withCount(['products' => function (Builder $query) use ($request) {
    $query->matchingSearch($request->input('search')); //False positive
}])->get();

I noticed a similar issue, I have a query which has 3 scopes chained, 1 scope works and is analyzed correctly, the second I add any more scopes it complains that that scope does not exist.

I have a similar issue. When i call a HasMany relationship method on a model instance, and then chain a scope onto that, it complains that Illuminate\Database\Eloquent\Relations\HasMany does not have that method.

Can you re-test this with 0.4.3?

While the problem described in this issue should have been fixed, https://github.com/nunomaduro/larastan/issues/351 came up instead


Fix bump segments iteration order and day of month/week intersection/union handling

Fixes #33
Issue is that sometimes changing a part of the ref date should also change other parts.
Example: If we bump year while computing next tick, we must then put ref to 1st January of next year, at midnight.
To implement this logic the iteration over segments have been reversed to start with segments corresponding to bigger time periods, and the bump function has been updated to handle this new logic of dependent segment changes.
Fixes #26
Issue was that when using steps for months (e.g. 3/*) the fact that months start at 1 (January) and not 0 must be taken into account.
About day of week and day of month
So according to crontab guru (see tip 1 in https://crontab.guru/tips.html) and also general crontab standard, day of week and day of month are intertwined. So if any starts with * the computed day must match the intersection of the two. If not, it must match the union.

wow, thanks for this 👍. will take a look closely later when im in a PC

Codecov Report
Attention: Patch coverage is 86.73469% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 92.11%. Comparing base (d3b6afc) to head (71a9be7).

Files
Patch %
Lines

next.go
87.30%
5 Missing and 3 partials :warning:

gronx.go
81.81%
2 Missing and 2 partials :warning:

validator.go
87.50%
0 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   94.78%   92.11%   -2.67%
==========================================
  Files           9        9
  Lines         594      672      +78
==========================================
+ Hits          563      619      +56
- Misses         16       30      +14
- Partials       15       23       +8

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

i have yet to review but wanted to let the actions run thru. it's great that tests/builds passed, only a little comment from coverage bot codecov.

i have yet to review but wanted to let the actions run thru. it's great that tests/builds passed, only a little comment from coverage bot codecov.

Understood thanks! I will add the missing coverage.

@adhocore added new tests for coverage

thank you for clarification. seems now we are near merging this PR. while it is more of personal preference, is there a way to make some var name shorter instead like monthDaySegIsIntersecting


[lc_ctrl / flash / otp] nvm_debug_en availability

Right now, lc_ctrl exposes an nvm_debug_en signal that is available during test and rma states.
Due to the need to split up secrets during test states however, we need to be able to remove at least flash debug enable before we completely transition to production states.
I think ideally it would be nice to pinpoint exactly which state needs this change, but we won't know that information for some time.
So it seems like for now it would be best to add another HW_CFG that allows a manufacturer disable flash debug.
The flash wrapper / controller will then take a combination of the life cycle signal and the new config bit to determine whether debug is allowed.
Does this sound reasonable? Or do we think there might be a different / better approach?

just to chime in on this one again.  I think given some of the features available in lc_ctrl, it's fine to just pick a state that disable nvm_debug_en.
right now it looks like the following
      unique case (lc_state_i)
        ///////////////////////////////////////////////////////////////////
        // Enable DFT and debug functionality, including the CPU in the
        // test unlocked states.
        LcStTestUnlocked0,
        LcStTestUnlocked1,
        LcStTestUnlocked2,
        LcStTestUnlocked3: begin
          lc_dft_en            = On;
          lc_nvm_debug_en      = On;
          lc_hw_debug_en       = On;
          lc_cpu_en            = On;
          lc_iso_part_sw_wr_en = On;
          lc_keymgr_div_d      = RndCnstLcKeymgrDivTestDevRma;
        end

I'm thinking we just tweak this slightly such that in 2/3 nvm_debug_en is no longer on.
let me know what you think.

just to chime in on this one again.  I think given some of the features available in lc_ctrl, it's fine to just pick a state that disable nvm_debug_en.
right now it looks like the following
      unique case (lc_state_i)
        ///////////////////////////////////////////////////////////////////
        // Enable DFT and debug functionality, including the CPU in the
        // test unlocked states.
        LcStTestUnlocked0,
        LcStTestUnlocked1,
        LcStTestUnlocked2,
        LcStTestUnlocked3: begin
          lc_dft_en            = On;
          lc_nvm_debug_en      = On;
          lc_hw_debug_en       = On;
          lc_cpu_en            = On;
          lc_iso_part_sw_wr_en = On;
          lc_keymgr_div_d      = RndCnstLcKeymgrDivTestDevRma;
        end

I'm thinking we just tweak this slightly such that in 2/3 nvm_debug_en is no longer on.
let me know what you think.

From a design perspective this is easy to do. We just have to agree which unlocked states should not enable NVM debug (probably the last unlocked state?).

Yes. The last.

This has been addressed in #7328.


Allow to add custom handlers in cartridge role

I didn't forget about

[x] Tests
[x] Changelog
[x] Documentation (README and rst)

Close #120, #242

Closed because of https://github.com/tarantool/metrics/issues/242#issuecomment-890057341


TextInput should have an Icon/IconAfter prop

Pretty common usecase to have a preceding icon for eg search fields

It would be nice if that icon could provide a button functionality too.

There's a PR for this that could use someone to help get it across the finish line, you guys should help there.'
https://github.com/tamagui/tamagui/pull/1654
Don't use issues for this, Discussions are where we take requests.


Added_Loader_To_Organization_Page

Closes #1211

Not sure why setLoading has to be set to true and false inside the useEffect that's not actually calling the organizations API, but good job on getting it to work. For a minor update suggestion, could the background of the spinner be changed to white so that it matches the rest of the page? If it's too complicated to change the background, then we can just merge as is. Thanks.

I saw in other pages like individual organization page it was blue spinner , so used the same thinking it was uniform.


Optimize is not working

Hi,
I try to use optimize(true) in the routing builder and it does not seem to work. I try to find the shortest route if I start from point A and want to visit B, C,D and E. The order of visiting does not matter.
Any ideas?

Hey, I am sorry but this project isn't being actively maintained at the moment. It would probably be better off to use Google Client library or something else.


change GA county arcgis resource

Original fix in PR #151 changed the ArcGIS resource for Georgia county. The ArcGIS server had updated the names and locations of the specific features, and the one that was originally used wasn't returning any data.
This PR now changes back to the original resource as it is now returning data.

@tlyon3 this doesn't seem quite right:
d = GeorgiaCountyVaccine()

df = d.fetch_normalize()

df.query("location_name == 'Franklin'")[["dt", "category", "value"]]
Out[22]:
            dt                          category  value
6   2021-03-10           total_vaccine_initiated   3136
165 2021-03-10           total_vaccine_completed   3828
324 2021-03-10  total_vaccine_doses_administered   6964

Notice that for this county vaccine_completed > vaccine_initated
This can't be true because our definitions are:

vaccine_initiated: people with at least one dose
vaccine_completed: people with full series (2 for moderna/pfeizer or 1 for JJ)

Can you poke around the ArcGIS resources to see if we can get definitions for their columns so we can get these lined up properly?

Looks like this is a data issue. I've looked at all the other counties and Franklin County is the only one that has this issue

Hey @mikelehen what do you think here? All the other counties have dose1 >= dose 2. It is just Franklin county.
I tried goggling around for other resources directly from the county, but didn't find any. It looks like other sites/places are reporting what is in the picture above too


@dynamicMemberLookup static subscripts do not work with unprefixed dot syntax

Describe the bug
@dynamicMemberLookup static subscripts do not work with unprefixed dot syntax.
Demonstration:
struct Color {

    let red: Double
    let green: Double
    let blue: Double
    let alpha: Double

}

@dynamicMemberLookup
struct Prop {

    static subscript<T>(dynamicMember member: KeyPath<Color, T>) -> Self { Prop() }

}

_ = Prop.red // works
let prop: Prop = .red // does not work

Steps To Reproduce
Steps to reproduce the behavior:

Define a static dynamicMember subscript
Observe that it does not work with unprefixed dot syntax

Expected behavior
Dynamic properties are inferred the same way as other unprefixed properties are.
Environment (please fill out the following information)

OS: macOS 12.5
Xcode Version: 13.4.1 (13F100)

Additional context
Swift forums thread post discussing this issue.

Looking forward for this to be fixed as well.


Windows install path

Steam install path isn't hardcoded so I have to set it  manually in install.py every update , please add an option to batch file to set the target path.

v2.2 should now read Steam install path from registry on Windows.
Also you should now be able to pass target path to install.py with #251 fixed.


Docs - Alert.alert() does not have a type argument

As can be seen in the implementation, there is no type argument for Alert.alert:
https://github.com/facebook/react-native/blob/master/Libraries/Alert/Alert.js#L47

Thanks @JonnyBurger! Looks like type is an arg for Alert.prompt


NBS: Defer AWS reads when opening a table with cached index

Prior to this patch, whenever we created a chunkSource for a table
persisted to AWS, awsTablePersister::Open() would hit DynamoDB to
check whether the table data was stored there. That's how it knew
whether to create a dynamoTableReader or an s3TableReader. This
results in consulting Dynamo (or the in-memory small-table cache)
every time we go to open a table. Most of the time, this isn't
necessary, as we separately cache table indices and really only
need that data at Open() time.
This patch defers reading table data if possible.
Fixes #3607

Uff. A bunch of the files are changed just because I added stats *Stats to the signature of Open(). Reading indices out of storage wasn't getting tracked properly in our stats, which should be mostly fixed now for AWS.
PTAL.

Ok! I fixed all the extra index data reading and simplified some stuff. PTAL


bugfix: remove initializer when specific namespaces are set

What this PR does / why we need it:
The initializer was not removing itself from the list of pending initializers when specific namespaces were specified in the configuration. This PR fixes that problem so that deployments created in ignored and excluded namespaces can be created properly.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #1470
Special notes for your reviewer:
Release note:

NONE

/cc @dcberg @linsun

@ayj: GitHub didn't allow me to request PR reviews from the following users: dcberg.
Note that only istio members can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @dcberg @linsun

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ayj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-e2e-smoketest.sh
900c8454247787b5bdc541eab6ac15cb945f5b55
link
/test pilot-e2e-smoketest

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-e2e-smoketest.sh
8cf9e3bc071c70169501a9507ba4519c5ebbbc12
link
/test pilot-e2e-smoketest

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-e2e-smoketest.sh
e9d86d65b3bc488a605ac74fa3e319cd1a8160c5
link
/test pilot-e2e-smoketest

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thanks @ayj for the update, but I do want to see more test cases as this:
In https://github.com/istio/pilot/blob/master/platform/kube/inject/inject_test.go#L58 , we have the function of TestIntoResourceFileWithIncludeNamespaces, but this test is using IncludeNamespaces: []string{v1.NamespaceAll},.
What I want to test is we can probably add a new test case named as TestIntoResourceFileWithIncludeNotAllNamespaces, then for this test cases, we can set IncludeNamespaces: []string{"ibm-system"}, or the namespace as you want and do the test to see if deployments in other namespaces can work well. This will also introduce some new YAML templates to test, hope it helps.

set IncludeNamespaces: []string{"ibm-system"}, or the namespace as you want and do the test to see if deployments in other namespaces can work well.

What do you mean by "work well"? Other namespaces not in the included list will be completely ignored by the initializer and won't have the pending initializer cleared.

FWIW, includeNamespace doesn't have any affect on kube-inject since the assumption is the user running the tool implies they want it injected. This fix is more important for the initializer case which runs unconditionally on all deployments.

What do you mean by "work well"? Other namespaces not in the included list will be completely ignored by the initializer and won't have the pending initializer cleared.

@ayj do you mean that the resources in other namespaces will still have the pending initializer created? If so, then those resources will still be pending, can you elaborate? Also the work well I mean is the resources created by kubernetes should not be pending but should be created successfully, which means that the pending initializers should be cleared.

@gyliu513, I believe what you're suggesting is to

@gyliu513, yes resources that aren't in include, ignore, or exclude namespace lists will still have their pending initializer. We could change this behavior and make the initializer truely cluster wide, but that is a change in design (see https://github.com/istio/pilot/pull/1476#discussion_r144669080). I'm fine making that change if others agree, but don't want to rush into it.

yes resources that aren't in include, ignore, or exclude namespace lists will still have their pending initializer.

@ayj Here is a common scenario:  I configure the istio-initializer to exclude namespace X, and I'm deploying bookinfo to namespace Y.   Would auto side car injection work for this bookinfo deployment in namespace Y?  I would expect it to work.

@ayj The other scenario is what @gyliu513 mentioned:   I want to configure istio-initializer to include namespace demo.  I can deploy bookinfo to namespace demo with side car auto injected.   If I deploy bookinfo to namespace Y, I should be able to deploy, without side car injected.   I think these two scenarios should work, and I don't see e-2-e injection yaml tests for them.
My understanding from your comment is that the 2 scenarios won't work because the current design is working around the shared cluster issue.  I think we need to make istio initializer cluster wide because that is the scope people is expecting it to work, similar as istio itself.

@ayj I think that this is a critical issue for istio initializer that we must fix, otherwise, it will cause some applications cannot deployed. We can merge this first.

The codecov checks are producing false negatives. Manual verification gives the following results.

file
before
after
delta

platform/kube/inject/configmap.go
100%
100%
0

platform/kube/inject/http.go
79.3%
79.3%
0

platform/kube/inject/initializer.go
73.9%
75.3%
+ 1.4%

platform/kube/inject/inject.go
89.7%
90.9%
+ 0.4%

total
84.2%
85.2%
+ 1%

My understanding from your comment is that the 2 scenarios won't work because the current design is working around the shared cluster issue. I think we need to make istio initializer cluster wide because that is the scope people is expecting it to work, similar as istio itself.

That is correct. The current implementation does not allow for that. We need to make initializer cluster-wide to address the root problem.

@ayj yeah I think it's a bug from codecov, but it doesn't block merge.

This PR has LGTM and codecov/patch and codecov/project are both X'd out for me. It looks like its blocking merge. Maybe I'm missing someone else?

You need a "approve" label, you can comment "/approve" to your own PR to get this label since your are an owner here.

/approve


add comment for function Now()

Ⅰ. Describe what this PR does
add comment for function Now() which in pkg/utils/crtl_utils.go
Ⅱ. Does this pull request fix one issue?

fixes #355
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

And could you please open an issue on it? thanks very much.

And could you please open an issue on it? thanks very much.

And could you please open an issue on it? thanks very much.

ok

Codecov Report

Merging #341 (ede6243) into master (e7bb456) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #341   +/-   ##
=======================================
  Coverage   17.72%   17.72%
=======================================
  Files          52       52
  Lines        2211     2211
=======================================
  Hits          392      392
  Misses       1780     1780
  Partials       39       39

Impacted Files
Coverage Δ

pkg/utils/crtl_utils.go
44.00% <ø> (ø)

pkg/ddc/alluxio/transform_optimization.go
96.70% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7bb456...ede6243. Read the comment docs.


feat: add awesome GitHub Blocks

https://github.com/ghuntley/awesome-github-blocks/
Collation of all things related to https://blocks.githubnext.com/ which is currently in preview. As the preview expands and more things are created "what is awesome" rises to the top 🚀 and what is not awesome will get ⚔'ed away.

You have not followed the guidelines and there's almost no content in your Awesome list. Lists submitted here are expected to be high-quality and content-rich. Try again in a few months if the list is more mature by then.
For now, you can post it in https://github.com/sindresorhus/awesome/issues/2242 instead.


enhancement: closes issue #642

Closes issue #642

Other than the two things above - looks like it should work. You tested it?

Yeah just tested it with the following structure and it worked:
      account: 'eosio',
      name: 'bidname',
      authorization: [{ actor: 'teamgreymass', permission: 'active' }],
      data: {
        bidder: '............1',
        bid: `${parseFloat(biddingAmount).toFixed(4)} EOS`,
        newname: biddingName
      }
    }]```
I also made the two changes you requested :D

Awesome! I'll have this merged in for the next Anchor release then :D


vertical alignment does not appear to be fixed

I have this code:
VStack(alignment: .leading) {
                Marquee {
                    Text("Tag \(viewModel.courseDay.indexRank) - \(viewModel.courseDay.title ?? "KEIN TITEL GEGEBEN!")") //TODO: add marqueeText to entire app
                        .font(.headline)
                        .fontWeight(.semibold)
                        .foregroundColor(.primary)
                }.marqueeDuration(9)

                Text(viewModel.courseDay.description ?? "")
                    .font(.body)
                    .fontWeight(.light)
                    .foregroundColor(.secondary)
            }
            .padding(.all, 16)

This however causes the text to be shifted downwards ...

I have already tried and found no problems, please provide more information.

Hi @CatchZeng I've run into this alignment issue when using the .marqueeWhenNotFit(..) modifier (see screenshot below).

I'm new to your library so it's possible that I'm using it incorrectly. Any help would be appreciated (see source below).
import SwiftUI
import Marquee

struct ContentView: View {
    var body: some View {
        VStack(alignment: .center) {
            Text("This works")
            Marquee {
                Text("This does not work")
            }
            .frame(height: 20)
            .marqueeWhenNotFit(true)
        }.padding()
    }
}

struct ContentView_Previews: PreviewProvider {
    static var previews: some View {
        ContentView()
    }
}

@kelada For the feature of marqueeWhenNotFit, you can see
https://stackoverflow.com/a/65197021/14785930

@kelada For the feature of marqueeWhenNotFit, you can see
https://stackoverflow.com/a/65197021/14785930

@CatchZeng thanks for the quick reply. I don't quite understand your answer, as I am aware of what .marqueeWhenNotFit(...) does and am using it for a reason - in my previous comment I'm highlighting that the Marquee does not respect the VStack(alignment: .center) { ... }.
What I am trying to do is centre a Text view when the string fits inside the Marquee, if it doesn't fit, it should animate - the key is that it respects the alignment of the VStack when not animating.

@kelada For the feature of marqueeWhenNotFit, you can see
https://stackoverflow.com/a/65197021/14785930

@CatchZeng thanks for the quick reply. I don't quite understand your answer, as I am aware of what .marqueeWhenNotFit(...) does and am using it for a reason - in my previous comment I'm highlighting that the Marquee does not respect the VStack(alignment: .center) { ... }.
What I am trying to do is centre a Text view when the string fits inside the Marquee, if it doesn't fit, it should animate - the key is that it respects the alignment of the VStack when not animating.
I've been looking into seeing if I can work around this by using an .alignmentGuide(...) modifier, but the behaviour is very inconsistent.
https://swiftui-lab.com/alignment-guides/

Is the picture shown below what you want?

You can upgrade marqueue to 0.3.0 and try the code below.
        VStack(alignment: .center) {
            Text("This works")
            Marquee {
                Text("This also works")
                    .background(Color.yellow)
            }.background(Color.blue)
            .frame(height: 20)
            // This is the key point.
            .marqueeIdleAlignment(.center)
            .marqueeWhenNotFit(true)
        }.padding()

@CatchZeng that's perfect! thank you so much! 🥇


Be sensitive to token in tests

Currently, the test_token test runs through but actually should fail. The test obviously is not sensitive to the token setting. In practice it works, but the test should represent that behaviour.

This is the test in question: https://github.com/blue-yonder/azure-cost-mon/blob/master/tests/test_app.py#L32

This should be the trick to check for the header https://github.com/getsentry/responses#request-callback


CEF runtime download fails with a 403

Looks like #99 has reappeared, I get a 403 when trying to run a published build of my application.
It looks like they moved stuff again, when I go to http://opensource.spotify.com/cefbuilds/index.html it says they're moving to https://cef-builds.spotifycdn.com

@cheeplusplus we should have made that configurable.
You can get latest nuget Chromely v<IP_ADDRESS> or you download manually.
Thanks for pointing that out.

I'd suggest switching to JSON and using https://cef-builds.spotifycdn.com/index.json instead of using Regex to parse the html. You can then simply match the cef_version property e.g. 91.1.22+gc67b5dd+chromium-91.0.4472.124


Add seo metadata helper

also renamed redux-helpers to pwa-helpers since the repo name changed

Maybe also update package.json and README.md for the name (redux-helpers -> pwa-helpers) change. Otherwise, LGTM.

ohhh right good call. i'm a doofus


Bugfix/dapp uncaught redirect errors

Thank you for submitting this pull request :)
Fixes #2383
Short description
This PR got bigger than expected due to a bunch of additional improvements for the path/query parameter handling that caused we error. Please check the commit messages for further details of the fix.
Definition of Done

[x] Steps to manually test the change have been documented
[x] Acceptance criteria are met
[ ] Change has been manually tested by the reviewer (dApp)

Steps to manually test the change (dApp)

Connect to the dApp until getting to the transfer screen (you should have at least one token connected)
Open the dev tools console and make sure there is no more an error message of the Vue router
Try to play around with the token path parameter (/transfer/0xtoken...) and the query parameters (/transfer?amount=3 and /transfer?target=0x...) and play wildly around with them.

I don't get why the test coverage drops. I actually added a bunch of new tests and the logic itself got reduced. :scream:


Revert "Print debug info and use absolute path in public image for now"

Reverts vespa-engine/vespa#10318
@hakonhall please review, and let's merge when we have found and fixed the issue.

Done in a different PR.


task resource property change

Signing off with comments

Signing off with comments - please use AddOrUpdate. Then go ahead with merge.

Could u please send a CR iteration. It would make it easier for reviewing. Have a few minor suggestion


Conflicts on new fresh laravel application (11.5)

composer require saloonphp/laravel-plugin "^3.0" does not work anymore on Laravel 11.5 version, giving conflicts.

Hey, @ces27.
Could you just post the output you get?
I haven't tried running the command, but just to ensure you don't get different conflicts than others, and, what conflicts you actually do get.


Add support for the OPTIONS verb

Add support for the OPTIONS verb, which requires us to use Faraday's run_request() method instead of the dynamically-generated method associated with the verb name (Faraday.options is a different thing - see lostisland/faraday#305)
@zacharywelch are you ok for me to merge into master and push a 0.9.1 gem (need it for a project we're working on)?

@zacharywelch I decided to bump to version 0.10.0 rather than 0.9.1 because this release includes your refactor of attributes which is a relatively big chunk of stuff. Hope ok.


Error running orb-tools/increment

I’ve successfully published a dev version of an orb (civicteam/helm@dev:orbs) via circleci using the<EMAIL_ADDRESS>orb (publishing an orb for use in circleci via an orb on circleci is cool btw!)
However, I am getting this error when running Increment: "Error: User does not have access to publish SemVer orbs in this namespace.". I am using the same publish-token-variable for publish and increment and this is a token generated by my github admin account. I also created the namespace itself.
Is the publish-token-variable the place where circle gets the permissions from, or is this based on some other setting in the circle project such as the github ssh key? I presume if I am a github admin I should have permissions to run increment?

That worked fine:
Debugger Logging: true
>> variables: map[name:civicteam/helm namespace:civicteam]
>> query:
        query ($name: String!, $namespace: String) {
                orb(name: $name) {
                  id
                }
                registryNamespace(name: $namespace) {
                  id
                }
          }

>> result status: 200 OK
<< &{Orb:{ID:9b7eaf38-454d-4e81-a1b3-91e5f70b4641} RegistryNamespace:{ID:782898bc-5d4b-47d4-ba96-edef88769e8c}}
>> variables: map[name:civicteam/helm]
>> query: query($name: String!) {
                            orb(name: $name) {
                              versions(count: 1) {
                                    version
                              }
                            }
                      }
>> result status: 200 OK
<< &{Orb:{Versions:[]}}
>> variables: map[config:version: 2.1
description: |
  Deploy a helm chart on AWS EKS
commands:
  setup-kube:
    parameters:
      cluster:
        type: string
      namespace:
        default: default
        type: string
      chart:
        type: string
    steps:
    - run:
        name: Configure Kubernetes Client
        command: |
          aws eks update-kubeconfig --name  << parameters.cluster >>
          kubectl config set-context $(kubectl config current-context) --namespace << parameters.namespace >>
          # sanity check
          kubectl get services
    - run:
        name: Initialise Helm
        command: |
          helm init --client-only
          helm list | grep << parameters.chart >>
          # download any missing subcharts
          helm dep update
  upgrade:
    parameters:
      helmparams:
        default:
        type: string
      chart:
        type: string
    steps:
    - run:
        name: Update Cluster
        command: |
          helm upgrade << parameters.helmparams>> << parameters.chart >> . || export STATUS=$?
          # cleanup
          [ ${STATUS:-0} -eq 0 ] || helm rollback << parameters.chart >> $(helm history << parameters.chart >> | grep DEPLOYED | awk '{print $1}')
          exit ${STATUS}
executors:
  default:
    docker:
      - image: civicteam/circle-aws-kube

 orbId:9b7eaf38-454d-4e81-a1b3-91e5f70b4641 version:0.1.0]
>> query:
                mutation($config: String!, $orbId: UUID!, $version: String!) {
                        publishOrb(
                                orbId: $orbId,
                                orbYaml: $config,
                                version: $version
                        ) {
                                orb {
                                        version
                                }
                                errors { message }
                        }
                }

>> result status: 200 OK
<< &{PublishOrb:{Orb:{ID: Name: Namespace: CreatedAt: Source: HighestVersion:0.1.0 Commands:map[] Jobs:map[] Executors:map[] Versions:[]} Errors:}}
Bumped civicteam/helm#9b7eaf38-454d-4e81-a1b3-91e5f70b4641 from 0.0.0 by minor to 0.1.0
.
Orb `civicteam/helm` has been incremented to<EMAIL_ADDRESS>Please note that this is an open orb and is world-readable.

I think I may know what the reason is.
The docs say the token should be publish-token-variable (see: https://circleci.com/docs/2.0/creating-orbs/#orb-toolsincrement)
but the source code for<EMAIL_ADDRESS>says token-variable ( https://circleci.com/orbs/registry/orb/circleci/orb-tools#commands-increment )
I haven't tested this yet on circle. Am I right? Should I use token-variable instead?

@dankelleher that's likely the cause. It looks like there is a bit of a discrepancy in the naming.
The command called increment uses token-variable
The job called increment uses publish-token-variable

Hmm. I was using the job though...

I'll snoop around the source code a little more.

@dankelleher in case it's still giving you trouble, maybe if you paste a part of your compiled config containing the increment command we can take another look? Here's how to get to the compiled config from the UI (the Configuration tab in the bottom right corner):

@dankelleher closing for now, please let us know if you still have issues publishing orbs.


problem with [pipe]

Not sure if this has come up before. Sorry, if so:

Heavy __delay cannot convert argument "delay" with value "f" to type float: could not convert string to float: f

Got this issue in my latest upload. The pipe has, in all three cases, two arguments, e.g. "f 200".

What does the "f" argument do? Pipe only takes a numeric delay argument, no?

f stands for float. If you look at the help file for pipe, it shows that you can put other arguments before the last argument to specify the type(s) of values being passed through (and also to pass through multiple values).
But if that's the problem, I can remove the f, as I'm only passing through one value anyway.

🤔 is this in Vanilla too? Our pipe will pass through arbitrary messages. Just pass the numeric delay argument.

Yeah, I'm using Vanilla. But yeah, that was the problem, thanks.


Don't prefix full path specification when changing & to &mut.

With the following code:
fn f(vec: &Vec<usize>) {
    vec.push(5);
}

I get a suggestion to "change this to a mutable reference", but if I do, I get:
fn f(vec: &mut std::vec::Vec<usize>) {
    vec.push(5);
}

That's a bit overkill, right? I would rather expect
fn f(vec: &mut Vec<usize>) {
    vec.push(5);
}

It actually becomes worse. I've decided to file this bug report after my argument:
shells: &LocatedShells,

was changed to
shells: &mut topology::located_slice::LocatedBoxedSlice<std::collections::HashMap<usize, shell::Shell, std::hash::BuildHasherDefault<fnv::FnvHasher>>>,

instead of just
shells: &mut LocatedShells,

That's definitely overkill, so I end up changing the & to &mut by hand.
Is this something expected? Or something I can configure not to happen?

I think those quick fixes are generated by rustc, not rust-analyzer.

@bjorn3 Oh, should I move the issue to rust then?

Yes


wiki -> Winlink.md

change 3rd paragraph to:
You will need to create a Winlink account with your Callsign (https://www.winlink.org/user) and you will get your password: 6 letters that you should save on the tracker_conf.json file.

done


Do you still use block_tea while you train it? (not any issues, but just a question)

Thank you for this awesome application. This is just a quesiton( not any issues at all), Do you still use block_tea in training phase, which we can see in IFNet of your original RIFE repository. And if so, Did you train the 'block_tea' at outside of those codes? According to your paper, I thought you had been using guided mask something. So I was thinking you were doing it when the 'block_tea' was in training phase, prior to training the main model 'flownet'. Is this correct?

https://github.com/hzwer/Practical-RIFE#model-training
You may check our code. I haven't manipulated block_tea before training. It seems to me that I just implemented some kind of deep supervision. BTW, deleting block_tea in the current framework only very slightly reduces performance.

Thank you so much! Oh you've already released it for v4 series. Actually I didn't notice it:) I just looked into it a bit, and I understand it. Thank you!

Add this function to train.py
def flow2rgb(flow_map_np):
    h, w, _ = flow_map_np.shape
    rgb_map = np.ones((h, w, 3)).astype(np.float32)
    normalized_flow_map = flow_map_np / (np.abs(flow_map_np).max())

    rgb_map[:, :, 0] += normalized_flow_map[:, :, 0]
    rgb_map[:, :, 1] -= 0.5 * (normalized_flow_map[:, :, 0] + normalized_flow_map[:, :, 1])
    rgb_map[:, :, 2] += normalized_flow_map[:, :, 1]
    return rgb_map.clip(0, 1)


add bartender

Description
Add extension to control Bartender application.
Screencast
You can search for menu bar item, and click it.

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Ok

Hi 👋
For me, it's called Bartender so it doesn't work

I have Bartender from SetApp; if I change BARTENDER_APPLICATION_NAME to Bartender - could you look into a way to fix this?
I'm looking forward to testing this extension again 🔥
Request a new review when you are ready. Feel free to contact me here or at Slack if you have any questions.

Ok, I installed the app by homebrew and it's called Bartender 4. I will look into it for a fix.


Identity Scaffolding creates empty Services folder

Steps to reproduce:

Create new ASP.NET Core 2.1 Project with Identity
Scaffold Identity
Empty Services Folder with no Email or SMS Services

Expected behavior:

Per @blowdart it seems weird the services aren't generated, the base ones provided in the past should be there at least

Actual behavior:

Nothing in Services folder

@javiercn @mkArtakMSFT

@seancpeters @vijayrkn Can you take a look at this? There should not be a services folder.

I know why this is happening, I'll get a PR out with the fix.

With identity scaffolding, we've never had any services scaffolded (such as the ones mentioned in the original post). If it's desired to add those services, let's discuss exactly what we want to add.

My personal opinion is that the scaffold experience should be very similar to the experience before scaffolding was introduced (i.e. EmailService and SMSService scripted as part of template). If the team disagrees, I would like to know why not making those services available is ideal over the old experience which allowed developers to quickly build out identity apps.

The services mentioned are part of the UI package. We don’t want to scaffold the services because that prevents people from shipping third party package implementations that can be reused.

If that is truly the goal it should be documented somewhere. If I scaffold identity, the email for account setup does not work out of box.

@Rick-Anderson Can you add something on the docs for this?

I can add this needed info to the scaffold doc.

The creation of the empty services folder is fixed as part of with #866

@isaac2004  yes, PR the doc.


Specific pandas version required to read in pickled results

In 02_api.ipynb, we read in the results of an API query about the 2020 election using the following code:
df = pd.read_pickle("../data/election2020_articles.pkl")
As per this issue on the pandas github, the pd.read_pickle function is not backwards compatible, so we will need workshop attendees to have pandas version 1.3.4 (or an earlier version). I'm not sure how best to require this?

I just tried running pd.read_pickle("../data/election2020_articles.pkl") while running Pandas 2.0.3 which worked. Can you still reproduce the error @Emmavt?

Yes, with Pandas 2.1.2 it is still returning the same error.

Replaced Pickle with csv


Proxy is not allowing service to start

When I run docker-compose up:
MBP-Vitaly:bb dyatlov$ docker-compose up
Starting bb_db_1...
Starting bb_web_1...
Cannot start container 473e51676f19ffa3e15245d6bc1ffb0e73b04b405ede41b9bcad1c7134ff8773: Bind for <IP_ADDRESS>:80 failed: port is already allocated

My docker-compose.yml:
db:
  image: postgres
web:
  build: .
  command: bundle exec foreman start -f Procfile
  volumes:
    - .:/app
  ports:
    - "80:3000"
    - "8030:8030"
  links:
    - db
  environment:
    - VIRTUAL_HOST=bb.dev

Procfile:
rails: rails s -p 3000 -b '<IP_ADDRESS>'
webpack: npm start

The dinghy up command has a flag to disable the proxy, if you need to.


Error when using mypy==1.5.0

When using mypy==1.5.0 (from environment), the following error occurs:
mypy: error: ambiguous option: --show-error-code could match --show-error-codes, --show-error-code-links

@schmidt-ai Please try the pre-release this is fixed in that.


Add support for "canned flows"

Although it is useful to allow flexible outgoing frames, it would be useful to expose a mechanism for something like the "channel groups" to be transmitted as packed-data only.
This would probably need a "flow CRC" in the payload.

The configuration of a "canned flow" should probably be sent as the frame prototype described in #13.

We should follow advice here: https://github.com/vkottler/vtelem/issues/14#issuecomment-886446828


Test cases fail on checkpoints.

The test cases fail only on checkpoints but run successfully when the checkpoints are removed. Any idea why this happens?
The function 'postCheckpoint()' does not get called under any situation.
Please help.

Any updates on this?
It's urgent.

I'm not sure what postCheckpoint() is... can you add a simple failing test case to the BPSampleApp project in Bluepill and create a PR?

Yeah I am doing it and will raise the PR.

Also, can you tell me something about "ProcessInfo.processInfo.environment"?.
I get the value of this as nil when I run the test case with bluepill, but while running the test cases via xcode, this variable is not nil. :(
How should I set it when running it with bluepill?

Is that ProcessInfo.processInfo.environment being called in your tests? Bluepill sets the App's environment from the xctestrun file.

Yes, it is being called in our tests.
Following is the code for your reference.
// Variable to check if application is running in test environment
static var isRunningTestCase: Bool {
    return ProcessInfo.processInfo.environment["XCInjectBundleInto"] != nil
}

// Use to post notification when any special event occurs, example: login, logout.
// - parameter name: Identifier for event to post.
static func postCheckPoint(_ name: String) {
    if isRunningTestCase {
        NotificationCenter.default.post(name: Notification.Name(rawValue: name), object: nil)
    }
}

Yes, it is being called in our tests.
Following is the code for your reference.
// Variable to check if application is running in test environment
static var isRunningTestCase: Bool {
    return ProcessInfo.processInfo.environment["XCInjectBundleInto"] != nil
}

// Use to post notification when any special event occurs, example: login, logout.
// - parameter name: Identifier for event to post.
static func postCheckPoint(_ name: String) {
    if isRunningTestCase {
        NotificationCenter.default.post(name: Notification.Name(rawValue: name), object: nil)
    }
}

@abhishekshroff-tudip  is this still a valid issue?


Add delete view on employer dashboard

Description
refs #33
Add delete view on employer dashboard
Code formating
Done

Good job!


Feature/gciluffo/upgrade android sdk

@JorgeQuevedoC Can you take a look at this when you get a chance? We can merge this in and do a final review in the original repo.


Subprocess in Nameko Service Ignoring errors = 'replace'

Describe the bug
I am using subprocess.Popen to create a run a shell command. I expect the output from the command to include non-Unicode characters so I am using errors = 'replace' to ignore any Unicode decoding errors and replace the offending characters with � (the prescribed Unicode replacement character). However, the subprocess module that is available when I run the code as a nameko service seemed to be ignoring the errors = 'replace' argument to Popen.
I am certain that the issue described is in the eventlet package but I am not directly using eventlet so I thought opening an issue here was a good starting point.
To Reproduce
I extracted the source code that is essential to demonstrate the issue and created a simple (single file) Nameko service the source code for which is included below. The output from the code when I run it as a Nameko service (using curl localhost:8000 to invoke the service from a different console) and as a simple Python script is as follows:
$ nameko run service
[service] sout - UTF-8 strict
[service] serr - UTF-8 strict
[service] Command Output hello world!!!

^C
$ python service.py
[__main__] sout - UTF-8 replace
[__main__] serr - UTF-8 replace
[__main__] Command Output hello world!!!

'''service.py'''

import subprocess

from nameko.dependency_providers import Config
from nameko.web.handlers import http

def get_output():
    ostream, estream = run()
    output = ostream.read()
    print('[{}] Command Output {}'.format(__name__, output))
    return output

def run():
    command = 'echo "hello world!!!"'
    process = subprocess.Popen(
        command, shell=True, text=True, errors='replace', bufsize=1,
        stdout=subprocess.PIPE, stderr=subprocess.PIPE
    )
    sout, serr = process.stdout, process.stderr
    print('[{}] sout - {} {}'.format(__name__, sout.encoding, sout.errors))
    print('[{}] serr - {} {}'.format(__name__, serr.encoding, serr.errors))
    return sout, serr

class NamekoService:
    name = 'nameko'

    config = Config()

    @http('GET', '/')
    def get(self, request):
        return get_output()

if __name__ == '__main__':
    _ = get_output()

Expected behavior
The errors = 'replace' should not have been ignored.
Environment (please complete the following information):

Nameko version: nameko==2.11.0
Python version: Python 3.7.2
OS: Ubuntu 18.04.2 LTS (GNU/Linux 4.15.0-45-generic x86_64)

Additional context
The command I am using subprocess.Popen to run is git log --patch and some of the patches will include characters that cannot be decoded to Unicode.

This is almost certainly a bug in eventlet.green.subprocess. Eventlet monkeypatches the standard library subprocess module to invoke the green version instead.
You can demonstrate that it's an eventlet bug by reproducing without Nameko, but with the monkey patch applied (by calling eventlet.monkey_patch() early in your script).
Unfortunately there is no workaround possible in Nameko; we need the monkeypatch to be applied.

Thank you for your response. I will reproduce this issue using eventlet.green.subprocess and open an GitHub Issue in the eventlet project.


URLs for specific consumers are invalid - need encoding

Issue submitter TODO list

[X] I've looked up my issue in FAQ
[X] I've searched for an already existing issues here
[X] I've tried running master-labeled docker image and the issue still persists there
[X] I'm running a supported version of the application which is listed here

Describe the bug (actual behavior)
We were trying to record a URL link into our docs about a specific consumer under a topic.
We browsed to the right place and got this link:
https://kafka-ui.ourdomain.com/ui/clusters/kafka/consumer-groups/Common.Scheduling.SchedulerHostedService`1[[Common.Entities.Scheduling.AccountDeviceBulkSchedule, Common.Entities, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null]]
But this link is not really usable in most browsers. Pasting it into Firefox just results in a blank page.
We think it needs the square brackets encoded as %5B - then it is usable
Expected behavior
A usable URL link to a particular consumer
Your installation details

56fa824
Don't know
Don't have access to this.
Don't know what this is.

Steps to reproduce
Browse to a topic
Click consumers
Click the listed consumer
Copy the URL from the browser URL bar
Screenshots
No response
Logs
No response
Additional context
No response

Hi, this repo is no longer maintained (#4255). We can address your issue here: https://github.com/kafbat/kafka-ui


updated requirements.txt

updated requirements.txt to include specific package versions

updated requirements.txt to include specific package version


Custom dataset

Is there a way to use this framework with a custom dataset? How would I go about doing that?

That's great news! Thank you.

I understand that ROME requires a 'subject.' I have a dataset of prompts and answers. Do you have suggestions for the best way to determine the subject? I saw a suggestion for using the last token as the subject, but that doesn't seem very accurate.

The best approach is to use a tool to extract the subject from the prompt. If this is not done, apart from taking the last token as the subject as you mentioned, we sometimes use the entire prompt as the subject. You can also try this and see how it works. In addition, if you are selecting some methods as baselines, consider using the WISE method. The link to the method is as follows:
https://github.com/zjunlp/EasyEdit/blob/main/examples/WISE.md
This method does not require specifying the subject, making it well-suited for your data.

hi, do you have any further questions?

All good! Thank you


how to make addendum work

have started turning it into a part two wrapped in bundle like bryce did in motion.
Is that OK? better to actually do overflow in this case so that the entries start out on the true page?

is the one with the requested values simple enough that I can just put it on the main attachment anyway because will always be same number of lines?


new InputEvent() hangs the terminal after closing node, needs kill -9

Hi,
I'm trying to use this package for my nodejs project running on an armv7 device with node v8.9.4.
I was amazed that it worked right away, without any problems. I can easily read events from /dev/input following the examples.
However I have one problem, when I close the node script (ctrl+c), my script itself stops working and I can even catch the SIGINT even telling it to stop, however after pressing ctrl+c, I cannot type anything into the terminal (nor press CTRL+C) anymore, it's stuck. The only way to stop is to execute killall -9 node and it frees the terminal.
It's caused solely by using new InputEvent('/dev/input/event0');, if I comment this line, it's not freezing anymore.
What can be the cause of this? Is there any way to fix it?

Have you try with "/dev/input/by-id/xxx"?

I can confirm this bug(?). Even a process.exit() hangs. Somehow this is caused by the fs.createReadStream() that's not properly cleaned, even though .close() is called in inputEvent.close().
My workaround, sending a SIGTERM to myself on exit:
    process.on('exit', () => {
      // Workaround for the process not terminating on process.exit() due to input-event
      // calling fs.createReadStream() (which, for unknown reason, prevents exit).
      process.kill(process.pid, 'SIGTERM');
    });

See https://github.com/nodejs/node/commit/c6ec036c582bb41a7a5ca53df7e1247df01c917a


Seg Fault in HydroDyn in v3.5.1

Bug description
I'm getting a seg fault when running OpenFAST v3.5.1 (via conda installation, both locally and on a linux CI) when running HydroDyn and our IEA-22MW reference model.
To Reproduce

Steps to reproduce the behavior:

conda install openfast
clone/download the IEA-22MW reference model
run openfast IEA-22-280-RWT-Monopile.fst
See the error

Expected behavior
A simple test simulation with most modules enabled.
Screenshots, if applicable
 **************************************************************************************************
 OpenFAST

 Copyright (C) 2023 National Renewable Energy Laboratory
 Copyright (C) 2023 Envision Energy USA LTD

 This program is licensed under Apache License Version 2.0 and comes with ABSOLUTELY NO WARRANTY.
 See the "LICENSE" file distributed with this software for details.
 **************************************************************************************************

 OpenFAST-HEAD-HASH-NOTFOUND
 Compile Info:
  - Compiler: GCC version 12.3.0
  - Architecture: 64 bit
  - Precision: single
  - OpenMP: Yes, number of threads: 16/16
  - Date: Oct 20 2023
  - Time: 23:54:21
 Execution Info:
  - Date: 11/08/2023
  - Time: 13:33:58-0700

 OpenFAST input file heading:
     Generated with AeroElasticSE FAST driver

 Running ElastoDyn.
 Nodal outputs section of ElastoDyn input file not found or improperly formatted.
 Running AeroDyn.
 AD15 Nodal Outputs: Nodal output section of AeroDyn input file not found or improperly formatted.
 Skipping nodal outputs.
 Running InflowWind.
 Running HydroDyn.

Program received signal SIGSEGV: Segmentation fault - invalid memory reference.

Backtrace for this error:
#0  0x10aeaad96
#1  0x10aea9edd
#2  0x7ff8101a35ec
#3  0x109645540
#4  0x10961af00
#5  0x1088163c3
#6  0x10881fd76
#7  0x1086d6a65
#8  0x109e95b5e
#9  0x7ff80fe1c41e

OpenFAST Version
(iea-env) dzalkind@x86_64-apple-darwin13 IEA-22-280-RWT % conda list | grep openfast
openfast                  3.5.1                h157c8df_0    conda-forge

Additional context
Workarounds (clues :-)):

Setting CompHydro to 0 runs okay.
Adding Wave1Elev to the output list also works fine.
OpenFAST v3.5.0 works okay, too.

@luwang00, do you have any ideas?

@dzalkind, does this happen only when HydroDyn doesn't contain ANY outputs? or just when it doesn't contain that specific Wave1Elev output?
I recently found an error in the dev branch (which is significantly different than v3.5.1) that could attempt to pass an unallocated array when no output was selected.

It appears as though it wants some output specified.  Does not have to be Wave1Elev.

I also vaguely remember there was a bug with HydroDyn when there's no output channel requested, but I can't find that particular issue.

I remember seeing this recently as well.  Not sure where though. @bjonkman, I suspect the unallocated array passing you found is the issue.

The issue is around Line 3081 of HydroDyn_Input.f90 from the 3.5.1 release. If no outputs are specified then InputFileData%Waves2%NumOuts, InputFileData%Morison%NumOuts, and InputFileData%NumOuts are not set and InputFileData%OutList is not allocated. @bjonkman fixed this in PR #1008 (https://github.com/OpenFAST/openfast/pull/1008/commits/c9a6153e336ebe50ff207a28284f8d634c9a56e3). @andrew-platt should we fix this in a 3.5.2 release?

The rc-3.5.2 branch was created to address this issue and other potential issues with v3.5. You can either use the new branch or add any output variable to HydroDyn.


Add extra shortcuts (ordinal numbers) to the New Tab Dropdown menu

Description of the new feature/enhancement
I'd like to have every item in the "openNewTabDropdown" menu (a dropdown list of shells for a new tab) to have a number that can be used as a very convenient shortcut
In Conemu: when I open a dropdown menu/list of all the shells for a new tab, in Conemu I can use 123 etc. keys to select an item (1 for "Group17", 2 for "wsl", 3 for "Shells")

In WT: I can't do that — I either have to use the less convenient shortcuts (e.g. CtrlShift1 for "Windows PowerShell"), which can never be made as convenient as 123, or select with a cursor/mouse

This is very helpful for opening less frequently used shells, for which I don't have to memorize the order/special shortcuts, but instead I can use an open new tab-kind of shortcut and select a number

Okay I don't hate this. I do personally hate the verbosity of the 1: {profile} text. I'd almost want this to be a totally hidden feature that "just works". Like have no UI indicating it, but the 1-9 keys would just work to open the 1st-9th entries in the dropdown.
I'm sure there's some accessibility doc somewhere that says I can't just do that, and would need to have some text there. So I'd probably want to make the 1:  text configurable. That's just personal preference.
Thanks for the suggestion!

I'd almost want this to be a totally hidden feature that "just works". Like have no UI indicating it, but the 1-9 keys would just work to open the 1st-9th entries in the dropdown.

Why would you force users to count the entries to make it work? I'm not sure everyone uses the same defauled numbered shortcuts to have a # hint (like, maybe they use a shortcut with a first letter of a shell there?)

So I'd probably want to make the 1: text configurable

But yeah, for those that do rely on the numbered shortcuts, having an option to make the text invisible might be worth it since there is already an UI indication of a #, so I'm all up for that
By the way, if you make the text of the same keyboard-shortcut-grey color, you definitely don't need the colon :, so that would cut down some verbosity :)
Also, you could add this number to the left of the current shortcuts (after all, this is also a shortcut), but to the right of the shell name (in the second/middle column) and the colon would even stop making sense

I will probably create an issue, but it sure seems like a more useful generic solution would be to allow users to assign a keyboard shortcut of their choosing to any profile.

I will probably create an issue, but it sure seems like a more useful generic solution would be to allow users to assign a keyboard shortcut of their choosing to any profile.

That is already possible: https://docs.microsoft.com/en-us/windows/terminal/customize-settings/actions#new-tab. It is possible to set the profile name in the action definition.

You know what, I think I'm gonna dedupe this with #6213. That one generically suggested "access keys" for the menu. This thread was talking specifically about using the numbers. Whatever we come up with should make sure to resolve both ideas.
/dup #6213


[Infra] Can't scale past a single instance on Render.

From @mattbroussard on Slack:
I doubt this will be an issue anytime soon, but it looks like enabling the Disks feature in Render (needed for ARPA integration) means you can't scale past a single instance. In December they said they planned to eventually remove this limitation: https://feedback.render.com/features/p/allow-disk-access-from-multiple-instances-and-services
If we got to the point where we needed to scale to multiple instances and this still isn't resolved, I think we would have to migrate our uploads storage to something like S3 instead of Render's built-in disk construct.
Reading [a bit more](https://render.com/docs/disks#application-considerations) about this:

Using the disks feature also prevents zero-downtime deploys. Not a huge deal but slightly annoying.
It sound like their plan is to allow "multiple service instances each with its own disk", but not multiple instances sharing the same disk -- so even with this feature, once we need to scale past a single instance I think we'd need to switch to something like S3 for upload storage (or have some kind of stateful sharding where a given tenant is guaranteed to only be on a single specific instance)

Again, not a super pressing issue right now or likely anytime soon given how low the traffic + CPU/memory load we're dealing with is, but something to be aware of down the road.cc [@Andrew Hyndman (PT)](https://usdigitalresponse.slack.com/team/U02N6NS9M45) [@Mindy Huang (PT)](https://usdigitalresponse.slack.com/team/U0285FPPSDA)

Addressing this with the AWS migration off Render


Invalid sytax for suite format but without error

Description
In a robot file, the user can execute the following content without error
*** Setting ***
Library    SSHLibrary
Library    Screenshot
Library    DateTime
Library    Process

*** Variable ***
${var1}=  10

*** Keyword ***
Test Keyword
    Log  ${var1}

*** Test Case ***
Test
    Test Keyword

According to the document, it should be
*** Settings ***
Library    SSHLibrary
Library    Screenshot
Library    DateTime
Library    Process

*** Variables ***
${var1}=  10

*** Keywords ***
Test Keyword
    Log  ${var1}

*** Test Cases ***
Test
    Test Keyword

Environment

Robotframework: 3.1.2
Python: 3.5.4
OS: macOS Catalina 10.15.1

Is the difference that the first one uses headers like *** Setting *** while the latter adds s at the end like *** Settings ***? If yes, that's a documented feature.

I missed this part of the document. Both of them are able to generate the same result.
I'll close the issue. Thanks for your comment.


Suspecting wrong backend selection while calling k8s services

Bug report

General Information

Cilium version v1.10.5 via kops addon
Kernel version 5.8.0-1042-aws
Orchestration system version in use v1.21.2 via kops
AWS Cloud used
encryption enable via IPSec
ipv4 only
hubble activated
node-local-dns installed via kops addon
partial kube-proxy replacement in place
cni chaining portmap
pods pass through kubernetes services to communicate

Summary
Periodically, a source pod receives a 404 error when calling a kubernetes service.
Our traces system shows us that a pod from a deployment B is called instead of a pod from a deployment A. Which induces
a 404 error returned by the wrong pod because it can't handle the request.
How to reproduce?
It is very hard to reproduce the issue and needs a lot of luck because the occurences are very rare and transient.
We succeeded to find a pod generating the issue. When connecting to it and executing a curl loop to simulate http calls to the same k8s service
we were able to reproduce the 404 issue. At the same time, we had 50 pods attached to the kubernetes service.
Findings

error still transient via curl calls (1 out of 50)
ips from cilium endpoint and kubernetes endpoint were identical and corresponded to valid pod
no error while calling directly cilium endpoint ip (500 http calls were made for each endpoint ip)
no error while doing the same curl calls from a pod that didn't experience 404 issue
after activating l7 monitoring via the io.cilium.proxy-visibility annotation no error seen from the point of view of hubbe monitor

same number number of requests sent vs the number of response

with cilium monitor we were able to see that all the requests were sent to the right service ip but without knowing the destination pod ip

See in attachment a sysdump for a node who had the issue.
And here the cilium config:
apiVersion: v1
data:
  auto-direct-node-routes: "false"
  bpf-ct-global-any-max: "262144"
  bpf-ct-global-tcp-max: "524288"
  cgroup-root: /sys/fs/cgroup/unified
  cluster-name: default
  cni-chaining-mode: portmap
  container-runtime: none
  debug: "false"
  enable-hubble: "true"
  enable-ipsec: "true"
  enable-ipv4: "true"
  enable-ipv6: "false"
  enable-k8s-event-handover: "true"
  enable-metrics: "true"
  enable-node-port: "false"
  enable-remote-node-identity: "true"
  etcd-config: |-
    ---
    endpoints:
      - https://xxxxxxxx:4003

    trusted-ca-file: '/var/lib/etcd-secrets/etcd-ca.crt'
    key-file: '/var/lib/etcd-secrets/etcd-client-cilium.key'
    cert-file: '/var/lib/etcd-secrets/etcd-client-cilium.crt'
  hubble-disable-tls: "false"
  hubble-listen-address: :4244
  hubble-metrics: dns drop flow http icmp port-distribution
  hubble-metrics-server: :9091
  hubble-socket-path: /var/run/cilium/hubble.sock
  hubble-tls-cert-file: /var/lib/cilium/tls/hubble/tls.crt
  hubble-tls-client-ca-files: /var/lib/cilium/tls/hubble/ca.crt
  hubble-tls-key-file: /var/lib/cilium/tls/hubble/tls.key
  identity-allocation-mode: kvstore
  install-iptables-rules: "true"
  ipam: kubernetes
  ipsec-key-file: /etc/ipsec/keys
  kube-proxy-replacement: partial
  kvstore: etcd
  kvstore-opt: '{"etcd.config": "/var/lib/etcd-config/etcd.config"}'
  masquerade: "true"
  monitor-aggregation: medium
  operator-prometheus-serve-addr: :6942
  preallocate-bpf-maps: "false"
  prometheus-serve-addr: :9090
  sidecar-istio-proxy-image: cilium/istio_proxy
  tofqdns-dns-reject-response-code: refused
  tofqdns-enable-poller: "false"
  tunnel: vxlan
  wait-bpf-mount: "false"
kind: ConfigMap
metadata:
  labels:
    addon.kops.k8s.io/name: networking.cilium.io
    addon.kops.k8s.io/version: 1.10.0-kops.1
    app.kubernetes.io/managed-by: kops
    role.kubernetes.io/networking: "1"
  name: cilium-config
  namespace: kube-system
  resourceVersion: "2015"

Thank you 🙇🏼
ping @gmiam @grams @alex-raoul @valouille @IxDay @choutone

ping @gmiam

Maybe a precision: we switch identity-allocation-mode from crd to kvstore in the morning. I don't know if it may be confusing in the sysdump

Thanks for opening the issue. This needs more info:

What service name?
What client and backend IP addrs?
Accessed from inside or outside cluster?

* What service name?

Calls should land on badoom3 service but sometimes land on something else.
Calls coming to badoom3 are from doorman and pastrami.

* What client and backend IP addrs?

It is really hard to answer this question as our pods come and go :/ ; Tell me if you want me to give you the IP based on the sysdump.

* Accessed from inside or outside cluster?

Accessed from inside.

One additional information, we don't have any network policies in place.

We ran into the same situation and made multiple sysdumps to give you additional info:

cilium-sysdump-receiver-1.zip
cilium-sysdump-transmitter-1.zip

The pod doorman-7f5f67c946-j47nx should have contacted the pastrami service but we found that the call was directly made to the pod badoom3-598698858d-49zl6.
We made one sysdump for the node hosting doorman-7f5f67c946-j47nx called receiver-1.zip and another one for the node hosting badoom3-598698858d-49zl6 called transmitter-1.zip
Hope that will help.

Thanks for the sysdumps!
Some investigation brain dump below.
In-cluster bpf_lxc per-packet LB Client "doorman-7f5f67c946-j47nx" (<IP_ADDRESS>) connects to "pastrami" service (<IP_ADDRESS>, revnat=57) but gets wrong server "badoom3-598698858d-49zl6" (<IP_ADDRESS>, belong to svc=<IP_ADDRESS>, revnat=62). The session affinity is disabled.
From the CT on the client node there are 4 entries of the wrong selection:
cat cilium-bpf-ct-list-global.md | grep -v ICMP | grep --color=auto
<IP_ADDRESS> | grep --color=auto <IP_ADDRESS> | grep RevNAT=57

TCP OUT <IP_ADDRESS>:33660 -> <IP_ADDRESS>:80 expires=96650 RxPackets=15 RxBytes=103572 RxFlagsSeen=0x03 LastRxReport=96640 TxPackets=15 TxBytes=3728 TxFlagsSeen=0x03 LastTxReport=96640 Flags=0x0013 [ RxClosing TxClosing SeenNonSyn ] RevNAT=57 SourceSecurityID=46028 IfIndex=0
TCP OUT <IP_ADDRESS>:53390 -> <IP_ADDRESS>:80 expires=96613 RxPackets=14 RxBytes=100482 RxFlagsSeen=0x03 LastRxReport=96603 TxPackets=15 TxBytes=3101 TxFlagsSeen=0x03 LastTxReport=96603 Flags=0x0013 [ RxClosing TxClosing SeenNonSyn ] RevNAT=57 SourceSecurityID=46028 IfIndex=0
TCP OUT <IP_ADDRESS>:51678 -> <IP_ADDRESS>:80 expires=96720 RxPackets=16 RxBytes=103603 RxFlagsSeen=0x03 LastRxReport=96710 TxPackets=17 TxBytes=2479 TxFlagsSeen=0x03 LastTxReport=96710 Flags=0x0013 [ RxClosing TxClosing SeenNonSyn ] RevNAT=57 SourceSecurityID=46028 IfIndex=0
TCP OUT <IP_ADDRESS>:50788 -> <IP_ADDRESS>:80 expires=96603 RxPackets=15 RxBytes=100962 RxFlagsSeen=0x03 LastRxReport=96593 TxPackets=15 TxBytes=3104 TxFlagsSeen=0x03 LastTxReport=96593 Flags=0x0013 [ RxClosing TxClosing SeenNonSyn ] RevNAT=57 SourceSecurityID=46028 IfIndex=0

Let's take port "<IP_ADDRESS>:33660", there are the following entries in the
CT:
> ack '<IP_ADDRESS>:33660' .
cilium-bpf-ct-list-global.md
9678:TCP OUT <IP_ADDRESS>:33660 -> <IP_ADDRESS>:80 expires=96650 RxPackets=15 RxBytes=103572 RxFlagsSeen=0x03 LastRxReport=96640 TxPackets=15 TxBytes=3728 TxFlagsSeen=0x03 LastTxReport=96640 Flags=0x0013 [ RxClosing TxClosing SeenNonSyn ] RevNAT=57 SourceSecurityID=46028 IfIndex=0
33586:TCP OUT <IP_ADDRESS>:80 -> <IP_ADDRESS>:33660 service expires=115387 RxPackets=0 RxBytes=333 RxFlagsSeen=0x00 LastRxReport=0 TxPackets=0 TxBytes=0 TxFlagsSeen=0x03 LastTxReport=93787 Flags=0x0012 [ TxClosing SeenNonSyn ] RevNAT=62 SourceSecurityID=0 IfIndex=0
66569:TCP OUT <IP_ADDRESS>:80 -> <IP_ADDRESS>:33660 service expires=105991 RxPackets=0 RxBytes=495 RxFlagsSeen=0x00 LastRxReport=0 TxPackets=0 TxBytes=0 TxFlagsSeen=0x03 LastTxReport=84391 Flags=0x0012 [ TxClosing SeenNonSyn ] RevNAT=70 SourceSecurityID=0 IfIndex=0
82781:TCP OUT <IP_ADDRESS>:80 -> <IP_ADDRESS>:33660 service expires=118240 RxPackets=0 RxBytes=328 RxFlagsSeen=0x00 LastRxReport=0 TxPackets=0 TxBytes=0 TxFlagsSeen=0x03 LastTxReport=96640 Flags=0x0012 [ TxClosing SeenNonSyn ] RevNAT=57 SourceSecurityID=0 IfIndex=0

From the above we can see that the client with the same sport connected first to
revnat=70, revnat=62 (the wrong backend belong to it), and then to revnat=57
service.
The revnat=57 entry has selected backend_id=328 (the RxBytes hack):
key: 48 01  value: 64 62 87 34 00 50 00 00

This is the wrong backend <IP_ADDRESS>.
How is it possible that lb4_local() selected the wrong backend?
I expect that it entered this branch https://github.com/cilium/cilium/blob/v1.10.5/bpf/lib/lb.h#L1370, as client->svc tuple should have been new (i.e., CT_NEW), and thus the correct backend should have been selected.
@sterchelen some questions:

Is it possible that <IP_ADDRESS> has belonged to a backend which belonged to pastrami service, and during the testing the backend was removed, and the IP was assigned to the new pod which belongs to a diffrent svc?
Would it be possible to run for you a custom image based on v1.10.5? I'd add some debug statements to the datapath.

Hello,
I'm working with @sterchelen

Is it possible that <IP_ADDRESS> has belonged to a backend which belonged to pastrami service, and during the testing the backend was removed, and the IP was assigned to the new pod which belongs to a diffrent svc?

It is possible, but we don't have the logs about ip assignements to pods.
We have a pool of let's say :

20 doorman (emitter)
25 pastrami (supposed receiver)
30 badoom (one of them being actual unexpected receiver)
Each doorman is doing curl like calls to pastrami svc, which is spread accross the 25 pods.

If we take the podname you found.
Accross doorman-7f5f67c946-j47nx lifetime (~7h), it did around 40k calls to pastrami service.
We estimate (we did some kubectl exec curl loops, spying in hubble-ui the real backend accessed on another occurence) that around 1/(pastrami-pool-size + 1) (1/26 in my example) calls were misrouted (might have been 1/25 as well, we didn't run thousands of calls to confirm the exact probability).
Each (detected) wrong routing went to badoom3-598698858d-49zl6, and not to any other badoom pod (or any other pod at all).
No other doorman pod had any issue during this period.
As soon as we detect a faulty pair, like here, a doorman pod calling through pastrami svc a badoom pod, it'll stay until either end is deleted, even if the hpa+rs for doorman, pastrami or badoom added/removed pods (as long as it didn't killed either end of the faulty pair).
Some additional notes :

We detected the issue on other pod to svc interaction (not only doorman pod > pastrami svc).
Badoom pods are exposed through another svc as well.
We ran a few scripts to compare CiliumEndpoints to svc Endpoints and bpf map content (decoding bpftool + /sys/fs/bpf/tc/globals/cilium_lb4_backends & cilium_lb4_services_v2 on cilium DS pod) and we found nothing strange.
We had 30+ hours span with no fault detection, and sometimes 50+ faulty pairs (we automated pod deletion with a custom script) within 6h with no apparent connection correlation between those (node, traffic, hpa activity ...).

Would it be possible to run for you a custom image based on v1.10.5? I'd add some debug statements to the datapath.

Yes sure, but we have yet to find a reliable way to reproduce on demand the issue.

As soon as we detect a faulty pair, like here, a doorman pod calling through pastrami svc a badoom pod, it'll stay until either end is deleted, even if the hpa+rs for doorman, pastrami or badoom added/removed pods (as long as it didn't killed either end of the faulty pair).

Are you saying that once the request is routed to the wrong backend, each subsequent request is routed to the same wrong backend?

Yes sure, but we have yet to find a reliable way to reproduce on demand the issue.

Could you ping me in the Cilium slack on Monday (I'm martynas there)?

Are you saying that once the request is routed to the wrong backend, each subsequent request is routed to the same wrong backend from the same client pod?
No, only a small proportion, like 1 out of approximate size of backend pool. And as soon as we detect it, this small error rate will be visible until either pod are killed.
It's as-if the wrong backend joined the pool of legit backend but only for this emitter.

Could you ping me in the Cilium slack on Monday (I'm martynas there)?
Will do 👍

Closing, as it should be fixed by https://github.com/cilium/cilium/pull/18113. Please reopen, if the issue persists.


CLOUDSTACK-9843 : Performance improvement of SSHHelper

A delay of 1 sec has been introduced in SSHHelper Class. This is a fail safe code. Removing this will improves the performance of deployVm by 4 sec, createFirewallRule by 1 sec and createPortForwardingRule by 1 sec.
We have not faced any issues after removing the delay. This was introduced when we were using older version of Trilead library.

@sudhansu7 Thanks for the fix. We need to update the unit test as well.
Please check:
diff --git a/cosmic-core/utils/src/test/java/com/cloud/utils/ssh/SshHelperTest.java b/cosmic-core/utils/src/test/java/com/cloud/utils/ssh/SshHelperTest.java
index c7282c426..b9b7213c8 100644
--- a/cosmic-core/utils/src/test/java/com/cloud/utils/ssh/SshHelperTest.java
+++ b/cosmic-core/utils/src/test/java/com/cloud/utils/ssh/SshHelperTest.java
@@ -126,6 +126,5 @@ public class SshHelperTest {
         Mockito.verify(conn).openSession();

         PowerMockito.verifyStatic();
-        Thread.sleep(Mockito.anyLong());
     }
 }

Test openConnectionSessionTest passes again for me after above change.

@remibergsma  Added suggested changes.

LGTM for the code changes.

tag:mergeready

ACS CI BVT Run
Sumarry:
Build Number 786
Hypervisor xenserver
NetworkType Advanced
Passed=107
Failed=3
Skipped=12
Link to logs Folder (search by build_no): https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0
Failed tests:

test_router_dns.py

test_router_dns_guestipquery Failed

test_list_ids_parameter.py

ContextSuite context=TestListIdsParams>:setup Failing since 24 runs

test_routers_network_ops.py

test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failed

Skipped tests:
test_vm_nic_adapter_vmxnet3
test_01_verify_libvirt
test_02_verify_libvirt_after_restart
test_03_verify_libvirt_attach_disk
test_04_verify_guest_lspci
test_05_change_vm_ostype_restart
test_06_verify_guest_lspci_again
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm
Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vm_snapshots.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_metrics_api.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py


Add perfect entangler functional and WeylChamber submodule

Codecov Report

Merging #22 (c581e04) into master (3f3d530) will increase coverage by 1.97%.
The diff coverage is 96.84%.

:exclamation: Current head c581e04 differs from pull request most recent head 9b01a90. Consider uploading reports for the commit 9b01a90 to get more accurate results

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
+ Coverage   87.33%   89.31%   +1.97%
==========================================
  Files          13       14       +1
  Lines         766      861      +95
==========================================
+ Hits          669      769     +100
+ Misses         97       92       -5

Impacted Files
Coverage Δ

src/QuantumControlBase.jl
100.00% <ø> (ø)

src/propagate.jl
75.86% <50.00%> (-0.93%)
:arrow_down:

src/weyl_chamber.jl
97.26% <97.26%> (ø)

src/functionals.jl
100.00% <100.00%> (+0.95%)
:arrow_up:

src/testutils.jl
73.91% <0.00%> (+3.10%)
:arrow_up:

src/controlproblem.jl
96.87% <0.00%> (+6.25%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f3d530...9b01a90. Read the comment docs.


Persistent Session Support & get_groups() Method

Added support to switch Webdriver between Chrome and Firefox.  Default is still Firefox. With driver = WhatsAPIDriver(browser='Chrome'), the Webdriver will use Chrome with Persistent Session Support. Theres no need to scan the QR Code each time the Script is starting up.
Added Method get_groups()
GroupList is working, Participantinformation is experimental. Detailed Explanation can be found in the get_groups.js File.

The get_grou.js file is missing in this merge request


Fix dates to have Tooltip with exact date

Dates should look like this if possible:

@ZitaNemeckova the format would be DD MMM YYYY, and if available the timestamp. For example, 07 Jan 2019, 23:33 UTC


Fix builds with matching Bazel target names

Hi,
When I have a target where the name matches the last component of the package path, there are conflicting action output paths.
If I rename example:app to example:example
❯  bazel build --config=clang-tidy //example
ERROR: output path 'bazel-out/darwin-fastbuild/bin/example/example' (belonging to //example:example) is a prefix of output path 'bazel-out/darwin-fastbuild/bin/example/example/lib.cpp.lib.clang-tidy.yaml' (belonging to //example:lib). These actions cannot be simultaneously present; please rename one of the output files or build just one of them

I've added a prefix to the tidy action outfile but perhaps you have a different way you would like to solve the problem.

Thanks! I'll merge it right after the build completes.

🎉


Release 2.1.0

Questions
Answers

Description?
Release 2.1.0

Type?
improvement

BC breaks?
no

Deprecations?
no

Fixed ticket?
N/A

How to test?
N/A

Possible impacts?
N/A

@Robin-Fischer-PS PR #24

@Robin-Fischer-PS Fixed in #24 and checked by @florine2623

Hello @Progi1984 ,
I have found an issue, maybe related to https://github.com/PrestaShop/statssales/pull/17.
I should have the tax excluded total instead of €0,00 :

Could you take a look ?
Thanks!

@florine2623 The bugfix should be #25.

Waiting for #25 to be merge first

#25 is merged :tada:

@florine2623 For this last bug, you should create a new issue because it's relative to the module dashtrends.

Thanks @florine2623 for this wonderful QA (and a lot of :exploding_head:).


I think 'only deletable mode' is needed

Thank you for providing good library. I think it is very useful and easy, so I'm satisfied with using your library.
I think this library can be more useful if there is 'only deletable mode'. When I making my application, I need deletable tags, but I don't want 'add a new tag' function. That means, I don't want the function that users can write their own tags. So, I override your library and making my own tag library by deactivating 'appendInputTag()' function.
I think some of this library users want this function that I made. Can you add the 'only deletable mode'? It can be useful for us.

hi @Candykick you can take the library class.
so gradle implement the library :
implementation 'me.gujun.android.taggroup:library:1.4@aar'
then take this file : https://github.com/2dxgujun/AndroidTagGroup/blob/master/library/src/main/java/me/gujun/android/taggroup/TagGroup.java
make new class into your project then extend the R.attr using your own Resources and it will automatically solved.
then
protected void appendInputTag() {
//        appendInputTag(null);  //COMMENT OUT THIS LINE
}
THIS WILL SOLVE IT. 👯 HOPE IT HELPS!!

hi @Candykick you can take the library class.
so gradle implement the library :
implementation 'me.gujun.android.taggroup:library:1.4@aar'
then take this file : https://github.com/2dxgujun/AndroidTagGroup/blob/master/library/src/main/java/me/gujun/android/taggroup/TagGroup.java
make new class into your project then extend the R.attr using your own Resources and it will automatically solved.
then
protected void appendInputTag() {
// appendInputTag(null); //COMMENT OUT THIS LINE
}
THIS WILL SOLVE IT. 👯 HOPE IT HELPS!!

Oh Thank you! I did it by overriding some classes in this library, but your answer is much greater than mine.