cmd/common: allow to specify gadget runtime configuration using "-f"

This allows specifying a manifest file using the "-f" flag.
Gadget instance specs can look like this:
version: 1
kind: instance-spec
imageName: trace_exec
name: yoyo
tags:
  - foo
  - bar
paramValues:
  operator.LocalManager.host: true
---
version: 1
kind: instance-spec
imageName: trace_exec
name: gagaga
tags:
  - second
paramValues:
  operator.oci.wasm.gadget_a: 1212
  operator.oci.ebpf.gadget_a: 1212
  operator.LocalManager.host: true

When defining multiple specs inside the file like that, this functionality can only be used in combination with --detach.
More info tbd.

Also, documentation would be welcomed! But let's first agree on the naming before proceeding with it.

IMO, it's a must for the release. But yeah, let's first agree on the naming ... naming ... naming 🤣

Changed:
File is now called manifest. A manifest can host multiple things of which we only evaluate those of kind instance-spec(maybe runtime-spec is better?) - the kind field is mandatory. Also added a mandatory version field to future-proof.
WDYT?

Changed:
File is now called manifest. A manifest can host multiple things of which we only evaluate those of kind instance-spec(maybe runtime-spec is better?) - the kind field is mandatory. Also added a mandatory version field to future-proof. This was done to align more with the kubernetes naming as discussed.
WDYT?

I like it. I think the items inside the manifest should be called "instance-specs".

Changed:
File is now called manifest. A manifest can host multiple things of which we only evaluate those of kind instance-spec(maybe runtime-spec is better?) - the kind field is mandatory. Also added a mandatory version field to future-proof. This was done to align more with the kubernetes naming as discussed.
WDYT?

I like it. I think the items inside the manifest should be called "instance-specs".

So instance-specs as kind vs instance-spec? Kubernetes is only using spec.

So instance-specs as kind vs instance-spec? Kubernetes is only using spec.

Nope, I meant instance-specs. Kind should be instance-spec as it refers to a single one.

Thanks for the reviews!


Error Deploying Vercel + Supabase instance

Hello! I followed the instructions to deploy umami on Vercel with the database hosted on Supase. I created a Supabase project, pasted the sql/schema.postgresql.sql into the Supabase SQL editor to create the tables, and added the DATABASE_URL (with &pgbouncer=true) and HASH_SALT env variables.
However, I got this error:
[16:27:16.430] Cloning github.com/candidexmedia/umami2 (Branch: main, Commit: d09baa3)
[16:27:16.961] Cloning completed: 531.124ms
[16:27:17.491] Looking up build cache...
[16:27:17.786] Build Cache not found
[16:27:17.839] Running "vercel build"
[16:27:18.511] Vercel CLI 28.2.5
[16:27:18.962] Installing dependencies...
[16:27:19.401] yarn install v1.22.17
[16:27:19.513] [1/4] Resolving packages...
[16:27:20.009] [2/4] Fetching packages...
[16:27:51.845] [3/4] Linking dependencies...
[16:27:51.849] warning " ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>[16:27:51.850] warning " ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>[16:27:51.851] warning "react-spring ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>[16:27:51.852] warning "react-spring ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>|| ^17.0.0".
[16:27:51.852] warning "react-spring ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>[16:27:51.852] warning "react-spring ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>[16:27:51.852] warning "react-spring ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>[16:27:51.853] warning "react-spring ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>[16:27:51.853] warning "react-spring ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>[16:27:51.866] warning "eslint-config-next > @typescript-eslint/parser > @typescript-eslint/typescript-estree ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>|| >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta".
[16:28:08.675] [4/4] Building fresh packages...
[16:28:16.742] $ prisma generate || true
[16:28:19.692] prisma:warn The postinstall script automatically ran `prisma generate` and did not find your `prisma/schema.prisma`.
[16:28:19.693] If you have a Prisma schema file in a custom path, you will need to run
[16:28:19.693] `prisma generate --schema=./path/to/your/schema.prisma` to generate Prisma Client.
[16:28:19.693] If you do not have a Prisma schema file yet, you can ignore this message.
[16:28:19.695]
[16:28:20.751] $ node -e "if (process.env.NODE_ENV !== 'production'){process.exit(1)} " || husky install
[16:28:20.904] husky - Git hooks installed
[16:28:20.913] Done in 61.52s.
[16:28:20.951] Detected Next.js version: 12.2.5
[16:28:20.953] Running "yarn run build"
[16:28:21.289] yarn run v1.22.17
[16:28:21.356] $ npm-run-all build-db check-db build-tracker build-geo build-app
[16:28:21.942] $ npm-run-all copy-db-files build-db-client
[16:28:22.512] $ node scripts/copy-db-files.js
[16:28:22.662] Database type detected: postgresql
[16:28:22.676] Copied /vercel/path0/db/postgresql to /vercel/path0/prisma
[16:28:23.120] $ prisma generate
[16:28:25.500] Prisma schema loaded from prisma/schema.prisma
[16:28:27.107]
[16:28:27.107] ✔ Generated Prisma Client (4.3.1 | library) to ./node_modules/@prisma/client in 227ms
[16:28:27.108] You can now start using Prisma Client in your code. Reference: https://pris.ly/d/client
[16:28:27.108] ```
[16:28:27.108] import { PrismaClient } from '@prisma/client'
[16:28:27.108] const prisma = new PrismaClient()
[16:28:27.108] ```
[16:28:27.772] $ node scripts/check-db.js
[16:28:27.950] ✓ DATABASE_URL is defined.
[16:28:28.174] ✗ Unable to connect to the database.
[16:28:28.194] error Command failed with exit code 1.
[16:28:28.194] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[16:28:28.215] ERROR: "check-db" exited with 1.
[16:28:28.234] error Command failed with exit code 1.
[16:28:28.234] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[16:28:28.250] Error: Command "yarn run build" exited with 1

The error says ✗ Unable to connect to the database. Make sure you can connect manually and that your password doesn't have characters that need to be escaped.

@mikecao I think it could make debugging more easier if you can print the catched error here: https://github.com/umami-software/umami/blob/0cb14f3f6c4fd542da0f20ae55849f88ce357d6d/scripts/check-db.js#L35-L36

Thank you for your help. I solved the issues with the database connection, but now I'm having migration issues. See the error text below:
[15:26:51.027] Cloning github.com/.../umami (Branch: main, Commit: 9bcb0eb)
[15:26:51.438] Cloning completed: 410.844ms
[15:26:51.891] Looking up build cache...
[15:26:52.182] Build Cache not found
[15:26:52.221] Running "vercel build"
[15:26:52.711] Vercel CLI 28.2.5
[15:26:53.033] Installing dependencies...
[15:26:53.370] yarn install v1.22.17
[15:26:53.449] [1/4] Resolving packages...
[15:26:53.765] [2/4] Fetching packages...
[15:27:11.871] [3/4] Linking dependencies...
[15:27:11.873] warning " ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>[15:27:11.874] warning " ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>[15:27:11.875] warning "react-spring ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>[15:27:11.875] warning "react-spring ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>|| ^17.0.0".
[15:27:11.875] warning "react-spring ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>[15:27:11.875] warning "react-spring ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>[15:27:11.875] warning "react-spring ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>[15:27:11.875] warning "react-spring ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>[15:27:11.875] warning "react-spring ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>[15:27:11.882] warning "eslint-config-next > @typescript-eslint/parser > @typescript-eslint/typescript-estree ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>|| >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta".
[15:27:33.434] [4/4] Building fresh packages...
[15:27:39.317] $ prisma generate || true
[15:27:41.641] prisma:warn The postinstall script automatically ran `prisma generate` and did not find your `prisma/schema.prisma`.
[15:27:41.641] If you have a Prisma schema file in a custom path, you will need to run
[15:27:41.641] `prisma generate --schema=./path/to/your/schema.prisma` to generate Prisma Client.
[15:27:41.642] If you do not have a Prisma schema file yet, you can ignore this message.
[15:27:41.643]
[15:27:42.443] $ node -e "if (process.env.NODE_ENV !== 'production'){process.exit(1)} " || husky install
[15:27:42.549] husky - Git hooks installed
[15:27:42.552] Done in 49.19s.
[15:27:42.585] Detected Next.js version: 12.2.5
[15:27:42.586] Running "yarn run build"
[15:27:42.848] yarn run v1.22.17
[15:27:42.891] $ npm-run-all build-db check-db build-tracker build-geo build-app
[15:27:43.324] $ npm-run-all copy-db-files build-db-client
[15:27:43.751] $ node scripts/copy-db-files.js
[15:27:43.882] Database type detected: postgresql
[15:27:43.891] Copied /vercel/path0/db/postgresql to /vercel/path0/prisma
[15:27:44.230] $ prisma generate
[15:27:46.139] Prisma schema loaded from prisma/schema.prisma
[15:27:47.504]
[15:27:47.504] ✔ Generated Prisma Client (4.3.1 | library) to ./node_modules/@prisma/client in 210ms
[15:27:47.504] You can now start using Prisma Client in your code. Reference: https://pris.ly/d/client
[15:27:47.504] ```
[15:27:47.504] import { PrismaClient } from '@prisma/client'
[15:27:47.505] const prisma = new PrismaClient()
[15:27:47.505] ```
[15:27:48.015] $ node scripts/check-db.js
[15:27:48.148] ✓ DATABASE_URL is defined.
[15:27:48.374] ✓ Database connection successful.
[15:27:48.605] ✓ Database tables found.
[15:27:51.075] Prisma schema loaded from prisma/schema.prisma
[15:27:51.075] Datasource "db": PostgreSQL database "postgres", schema "public" at "db.nqjaxdvhlyauafxqebmm.supabase.co:6543"
[15:27:51.075]
[15:27:51.075] 3 migrations found in prisma/migrations
[15:27:51.075]
[15:27:51.075] Following migrations have not yet been applied:
[15:27:51.075] 01_init
[15:27:51.075] 02_add_event_data
[15:27:51.076] 03_remove_casade_delete
[15:27:51.076]
[15:27:51.076] To apply migrations in development run yarn prisma migrate dev.
[15:27:51.076] To apply migrations in production run yarn prisma migrate deploy.
[15:27:51.076]
[15:27:51.076] Running update...
[15:27:53.805] Prisma schema loaded from prisma/schema.prisma
[15:27:53.805] Datasource "db": PostgreSQL database "postgres", schema "public" at "db.nqjaxdvhlyauafxqebmm.supabase.co:6543"
[15:27:53.806] Migration 01_init marked as applied.
[15:27:53.806]
[15:27:56.725] Error: P3018
[15:27:56.725]
[15:27:56.725] A migration failed to apply. New migrations cannot be applied before the error is recovered from. Read more about how to resolve migration issues in a production database: https://pris.ly/d/migrate-resolve
[15:27:56.725]
[15:27:56.725] Migration name: 02_add_event_data
[15:27:56.725]
[15:27:56.725] Database error code: 42501
[15:27:56.726]
[15:27:56.726] Database error:
[15:27:56.726] ERROR: must be owner of table event
[15:27:56.726]
[15:27:56.726] DbError { severity: "ERROR", parsed_severity: Some(Error), code: SqlState(E42501), message: "must be owner of table event", detail: None, hint: None, position: None, where_: None, schema: None, table: None, column: None, datatype: None, constraint: None, file: Some("aclchk.c"), line: Some(3583), routine: Some("aclcheck_error") }
[15:27:56.726]
[15:27:56.726]
[15:27:56.726] ✗ Command failed: prisma migrate deploy
[15:27:56.726] Error: P3018
[15:27:56.726]
[15:27:56.726] A migration failed to apply. New migrations cannot be applied before the error is recovered from. Read more about how to resolve migration issues in a production database: https://pris.ly/d/migrate-resolve
[15:27:56.726]
[15:27:56.727] Migration name: 02_add_event_data
[15:27:56.727]
[15:27:56.727] Database error code: 42501
[15:27:56.727]
[15:27:56.727] Database error:
[15:27:56.727] ERROR: must be owner of table event
[15:27:56.727]
[15:27:56.727] DbError { severity: "ERROR", parsed_severity: Some(Error), code: SqlState(E42501), message: "must be owner of table event", detail: None, hint: None, position: None, where_: None, schema: None, table: None, column: None, datatype: None, constraint: None, file: Some("aclchk.c"), line: Some(3583), routine: Some("aclcheck_error") }
[15:27:56.727]
[15:27:56.727]
[15:27:56.727]
[15:27:56.742] error Command failed with exit code 1.
[15:27:56.742] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[15:27:56.756] ERROR: "check-db" exited with 1.
[15:27:56.771] error Command failed with exit code 1.
[15:27:56.771] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[15:27:56.782] Error: Command "yarn run build" exited with 1

Looks like you don't have permissions to edit tables on Supabase.
Please refer to the Prisma/Supabase troubleshooting instructions to attain permission.
https://supabase.com/docs/guides/integrations/prisma#troubleshooting

Closing for no activity.  Please refer to discussion here, https://github.com/umami-software/umami/discussions/1542

Thanks for linking to https://github.com/umami-software/umami/discussions/1542! My issue has finally been resolved (now I just have to transfer my old data to my new deployment).
In case anyone has the same issue as me, here are the steps I took:
I ran both rohandebsarkar's Solution and Prisma's Solution from https://github.com/umami-software/umami/discussions/1542 in Supabase's SQL Editor.
I then ran into the error described here: https://github.com/umami-software/umami/discussions/1486#discussioncomment-3567442.
To solve this, I did the following:
3. Forked the umami GitHub project
4. Cloned my fork locally using GitHub Desktop
5. In my local folder, I created a file called .env. In this file, I typed in DATABASE_URL= and pasted the postgres URL from Supabase (Connection Pooling > Connection String) along with ?pgbouncer=true
6. Once that was done, I ran the following commands in my command prompt (with the directory set to my local cloned umami fork):
yarn install
yarn build
yarn prisma migrate resolve --applied "02_add_event_data"

Once that was done, I redeployed on Vercel, and it now works.
Thank you everyone for your help!


Also make AST data structures strict.


Server rendering: Value rendered to input, but not to texarea

Hi Ben!
While playing with serverside (neko) ithril, I find that in the following example, the testInt value is rendered correctly into the input element, while the textarea element is blank.
(When rendered clientside, both elements are rendered with the testInt value - as expected.)
Bug or feature?
class Index extends Component {
	public function view() [
		(title > 'Index')
		(meta[charset="utf-8"])
		(meta[name="viewport"][content="width=device-width, initial-scale=1.0"])
		(link[href="style.css"][rel="stylesheet"])
		(body)
			[body()]
	];

	public static var testInt = 123;

	@:access(ithril.component.ComponentCache)
	public function body() {[
		(div)
			(textarea (value  = '$testInt'))
			(input (value = '$testInt'))
	]; }
}

This happens because a textarea's innerHTML can be set directly through value in javascript, but this will not work when set as attribute (eg <textarea value="test"></textarea> will render blank).
The correct way to approach this is rewriting it like this for example: (textarea > testInt)

Ah, as simple as that! Thanks!


unable to get any data

I'm using React 15.4.2 and I cannot get any data in the Perf panel.
I'm building with grunt, window.Perf is available in the window, I hit start, and stop but no data is collected.
Any clue would be appreciated.

Sorry. I am not sure what happened since I haven't worked on React for more than half a year. I will try to update a more user-friendly version next month.

Seconding this.


how to make a player input form?

to execute a command like sw stats {(get the player name form the form)}

The value inputted in the first element will be put into {form.data.0}.(the second is {form.data.1} and the third is {form.data.2}...) So in this case, you can execute a command with sw stats {form.data.0}.


remove bin/console from gemspec

bin/console shouldn't be packaged as an executable

Thanks for this! ❤
Will we get a new release soon? 🙏
wisper's executable "console" conflicts with countries
Overwrite the executable? [yN]  N
ERROR:  Error installing cp8_cli:
        "console" from wisper conflicts with installed executable from countries


Uncaught TypeError: Cannot read property 'readJSON' of undefined

Uncaught TypeError: Cannot read property 'readJSON' of undefined
Atom Version: 0.161.0
System: Unknown Windows Version
Thrown From: atom-beautify package, v0.17.2
Steps To Reproduce

...
...

Stack Trace
At d:\buzz\Projetos\mobtag\backend\Gruntfile.js:25

TypeError: Cannot read property 'readJSON' of undefined
  at module.exports (d:\buzz\Projetos\mobtag\backend\Gruntfile.js:25:20)
  at Builder.discoverBuildSystem (c:\Users\buzz\.atom\packages\build-systems\lib\builder.coffee:83:13)
  at Builder.discoverBuildSystems (c:\Users\buzz\.atom\packages\build-systems\lib\builder.coffee:112:10)
  at c:\Users\buzz\.atom\packages\build-systems\lib\main.coffee:20:31

/cc @atom/core

From your log in the Issue it looked like this package was the culprit to me: https://atom.io/packages/build-systems
Good luck and let me know if there's anything I can do with Atom Beautify.

From your log in the Issue it looked like this package was the culprit to me: https://atom.io/packages/build-systems
Good luck and let me know if there's anything I can do with Atom Beautify.


Autopopulate proof default for sources

For example of Vaaran Bhai Gurdas Ji, most issue templates can auto link the 2011 edition that covers all the pages as opposed to the amrit kirtan proof.
This would also speed things up and make it easier for users to submit mistakes, thought it introduces the lazy default that some may not be aware of changing.
A drop-down in the viewer would help too before submitting the issue.

Upon further reflection, the drop-down makes the most sense. However that hinges upon a GUI overhaul of the database viewer.
Autolinking should not occur, because it cannot be accurate (e.g. researching user supplies own physical proof) and a lazy user will submit incorrectly.


react18.2.0

Asking a Question?
Please don't file GitHub issues to ask questions! Instead use:

Stack Overflow: http://stackoverflow.com/questions/tagged/react-virtualized
X [ERROR] No matching export in "node_modules/react-virtualized/dist/es/WindowScroller/WindowScroller.js" for import "bpfrpt_proptype_WindowScroller"
node_modules/react-virtualized/dist/es/WindowScroller/utils/onScroll.js:74:9:
74 │ import { bpfrpt_proptype_WindowScroller } from "../WindowScroller....
╵          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I have the same issue, are you using pnpm by any chance?


doc: test README change

Will submit this as a PR.
Change-Id: I2ecbdee988bbdd57d21c6d3e406b49d17bd61ae6

Closing as this was just a test to verify protected branch settings (even as admin)


Major issue with Speech Mode

Happens when trying to add a new line.

Resolved in 1.8.1, download a new release. Thank you for reporting!


AWS autoscaling: arbitrary VPCs and CWL

CJ -- this follows up on our discussion in #1470 around using accounts with non-default VPCs. It's back compatible with the previous approach but provides a new option so a user can specify a VPC to launch in, then all other steps happen within that VPC. With this in place I can spin up and start running autoscaling CWL jobs, then get blocked by a bug in cwltool which is also fixed here. Thanks much for the help getting this in.

Allow specifying a VPC subnet when launching a cluster. The previous
code assumed use of a default VPC which is not true for all AWS
accounts.
VPC subnet passed to all node creation scripts so everything occurs
in same configured VPC.
Using specific VPCs in boto requires sending security groups by ID
instead of name (https://github.com/boto/boto/issues/350).
Retrieve cluster name from instance tags instead of security groups
(fixes #1508)
Place spot instances in current VPC availability zone.
Handle spot instances where we can't find pricing history for
an instance type.
Use public_dns_name instead of ip_address for ssh. This allows
tweaking AWS ssh options in ~/.ssh/config via Host *.amazonaws.com
Update cwltool to latest stable tested version, fixing issue
with schema-salad in current Toil Docker images.

@chapmanb great, thanks for the PR! Unfortunately the jenkins build is failing with that old setuptools issue:
    The required version of setuptools (>=18.5) is not available,
    and can't be installed while this script is running. Please
    install a more recent version first, using
    'easy_install -U setuptools'.

CJ -- ugh, sorry. I guess this setuptools pinning is happening somewhere inside cwltool. @tetron do you know offhand if this is resolved? If so, I'll test and get this PR updated with a more recent cwltool.

CJ -- I re-thought this and it would make sense to get the fixes for AWS VPC in and then tackle the CWL issues separately. That would help with debugging the CWL failures I'm seeing on Toil runs since I wouldn't have to first patch for all these VPC issues. I dropped the setup.py changes and hopefully the new tests will run cleanly. Thanks much for helping with this.

@chapmanb it looks like this approach might not work with new account types?
boto.exception.EC2ResponseError: EC2ResponseError: 400 Bad Request
<?xml version="1.0" encoding="UTF-8"?>
<Response><Errors><Error>SecurityGroupLimitExceeded<Message>You have exceeded the number of VPC security groups allowed per instance.</Message></Error></Errors><RequestID>b33cdea3-2dc3-4aa9-8a9d-8c2c8bf1ac2a</RequestID></Response>

CJ;
Sorry about the issues, I pushed a fix that I hope will resolve this. When we were looking up security group IPs within the current VPC (or default) it didn't limit by name of the cluster. I'd guess when running on a system with larger numbers of security groups available this triggered the problem. Hopefully the updated approach will run cleanly now through the tests.

@chapmanb looks like the fix worked! Have you tried the cluster utilities (ssh-, rsync-, and destroy-cluster) on your account with this branch? I'm curious to see whether they will work with an older account.
The branch also has some conflicts that need to be addressed due to #1446, hopefully they shouldn't be too tricky.

CJ -- awesome. This does work on my account with all the commands: start, ssh, destroy-cluster. This PR gets me to the point I can start running the bcbio CWL tests. I'm keeping notes on progress here: https://github.com/chapmanb/bcbio-nextgen/tree/master/scripts/ansible#running-with-toil
I rebased against the current master and resolved the merge conflict so hopefully tests will pass cleanly again. Thanks again for the help getting this merged.

CJ -- thanks for the code review. I pushed a fix to check for VPC ID matches during deletion as well and to use camelCase (it's so painful to code python this way). Hopefully that makes everything fit cleanly.

@chapmanb great, thanks again for the PR! I also prefer snake case but I try to repress it when I'm working on Toil


First attempt mixed project support

Following the disussion in #101 I did this spike for supporting C# projects better.
This is still just single project,  but:

C# projects (probably not Winforms I think, but normal class libs and XAML) are now supported with regards to renaming and content replacement in the init.fsx file
Added Cs proj + assemblyinfo.cs files to the sourcelink target.
init.fsx is now prepared a bit for any multi project support that might or might not come in the future, I've tried to reduce the number of hardcoded names so make this easier.

Tested with C# main project and F# test project.

Entering a period of infrastructure maintenance now. Anything that needs to be done to get this merged into master?

/cc @pblasucci

This looks really good. I'm going to give it a whirl.


Update irrigation example to support time limited activation, small c…

…hange in scheduler code
Example inject node data in Node Red:
Set Address 101  off
[{"data":0,"type":0,"id":101}]
Get status of address 102
[{"data":0,"type":1,"id":102}]
Set address 103 on for 20 seconds
[{"data":20,"type":0,"id":103}]
Working on multiple array elements but I think some other code needs to be changed before that is supported.
Format of loadFDRS....
loadFDRS(data, type, address);
Get Coil status of address 102 (data value is ignored)
loadFDRS(1, 1, 102);
Turn off (set) Coil at address 102 for an indefinite amount of time
loadFDRS(0, 0, 102);
Turn on Coil (set) at address 102 for an indefinite amount of time
loadFDRS(1, 0, 102);
Turn on (set) Coil at address 102 for 300 seconds
loadFDRS(300, 0, 102);
When turning on coil for certain amount of time the data value
must be 10 or greater and is in units of seconds.

I admit, I sorta forgot about this. I'm finally getting through my springtime work and am looking forward to spending time on FDRS again. I think this looks good, and I'll get to testing it soon!

@aviateur17 I was testing this and found an issue in the timekeeping stuff...
There were a couple globals that weren't defined, so it couldn't compile:
 #define GLOBAL_STD_OFFSET     (-5)
#define GLOBAL_DST_OFFSET     (GLOBAL_STD_OFFSET + 1)

Now I'm getting the following error, presumably due to one of the DST macros needing to be defined. I assume we can just choose one to default to if the user doesn't define it.
In file included from c:\Users\webma\Documents\Arduino\libraries\Farm-Data-Relay-System\src/fdrs_node.h:41,
                 from C:\Users\webma\AppData\Local\Temp\.arduinoIDE-unsaved2024510-7460-1rohzlk.04tz\Irrigation\Irrigation.ino:10:
c:\Users\webma\Documents\Arduino\libraries\Farm-Data-Relay-System\src/fdrs_time.h: In function 'void checkDST()':
c:\Users\webma\Documents\Arduino\libraries\Farm-Data-Relay-System\src/fdrs_time.h:197:10: error: 'tdstBegin' was not declared in this scope; did you mean 'dstBegin'?
  197 |       if(tdstBegin != -1 && (time(NULL) - tdstBegin >= 0) && isDST == false) { // STD -> DST
      |          ^~~~~~~~~
      |          dstBegin

exit status 1

Compilation error: exit status 1

Thanks Timm, I'll try to look at this soon.

Timm, I'm not sure how changing those defines affects that variable name error.
I think that variable is not defined because neither USDST nor EUDST is defined somewhere.
You can see, in fdrs_time.h, that time_t tdstBegin is defined inside the preceeding macros EUDST or USDST so if neither of those is defined that that tdstBegin variable will not be defined.
So sounds like the issue is that we are missing some #defines in the node_config file.
Now my version of that repo doesn't include the timekeeping stuff so I think when I started that branch the timekeeping stuff was not committed yet.  So your testing shouldn't have fdrs_time.h in  there.   I guess we will need to make sure that node_config.h file is updated with the timekeeping #defines.

In main commit this is added to bottom of
examples/Controller_Examples/Irrigation/fdrs_node_config.h
// Time settings
#define USDST
// #define EUDST
#define STD_OFFSET      (-6)                // Local standard time offset in hours from UTC - if unsure, check https://time.is
#define DST_OFFSET      (STD_OFFSET + 1)    // Local savings time offset in hours from UTC - if unsure, check https://time.is
#define TIME_PRINTTIME    15     // Time, in minutes, between printing local time to debug

So perhaps seeing if those lines are in your fdrs_node_config.h if your files include the fdrs_time.h file.  Again, my repo does not include fdrs_time.h as I think I branched before the timekeeping stuff was committed into main.

I should have been a bit more clear. I was testing the new irrigation sketch using the latest version of the main branch of the repo (which includes timekeeping). Timekeeping wasn't added at the time you submitted this PR, thus the node config doesn't have them.
The general issue I have is that most configurations, including these, should have a default value that the system reverts to in case the user omits them. There is currently no entry in 'fdrs_globals.h' for GLOBAL_STD_OFFSET or GLOBAL_DST_OFFSET, and that's the issue there. We should also choose either USDST or EUDST to default to in case neither is set. I'm gonna vote US.
Below is the Single_Channel_Relay sketch, which demonstrates how few configs should actually be needed:
#define READING_ID 31
#define GTWY_MAC 0x01
#define USE_ESPNOW
#define COIL_PIN 5

#include <fdrs_node.h>

bool status = 0;

void fdrs_recv_cb(DataReading theData) {
  status = (bool)theData.d;
}
void setup() {
  beginFDRS();
  if (addFDRS(1000, fdrs_recv_cb))
    subscribeFDRS(READING_ID);
  pinMode(COIL_PIN, OUTPUT);
}
void loop() {
  loopFDRS();
  if (status) digitalWrite(COIL_PIN, HIGH);
  else digitalWrite(COIL_PIN, LOW);
}

I understand now.  I will submit another PR to cover those #defines in the fdrs_global.h and then the checks at the top of the file to use those globals if user defines are not there.

Submitted PR #215 for those timekeeping #defines

From the MQTT topic PR #216:

note on: You have the registerWithGateway() function that's essentially doing what already should be done in the background by the ESP-NOW controller's refresh_registration() function. To my knowledge the only device that should need to register are ESP-NOW controllers, since LoRa controllers just process all incoming broadcast packets from their gateway. If this is just an oversight, no problem. If there's something new with LoRa timekeeping requiring more connection maintenance, let me know.

You are correct.  This is the first time I've played with the controllers receiving values so I just assumed LoRa would need to operate the same as ESP-NOW.   But now that you pointed it out I see that there is no "peer registration" required with LoRa like ESP-NOW.

Confirmed that multiple commands submitted as one JSON  message are acted upon in the controller.  My testing is complete.

Apologies, it would seem that merging main into here screwed everything up completely. Shoulda just done it locally... I think our best bet is to make a new branch from your last commit, then try again without my recent commit. I was getting it ready to test tomorrow, which I still will do!


More complex player rights system

That can include donators, developers, veterans, etc.

Maybe not make it 'right',  but more like an add on status?
On 22 Oct 2015 4:11 pm, "lare96"<EMAIL_ADDRESS>wrote:

That can include donators, developers, veterans, etc.
—
Reply to this email directly or view it on GitHub
https://github.com/lare96/luna/issues/7.

Rights*

Was thinking of that too but at the same time I feel like decoupling the two could get annoying

I feel making them 'rights' is damn annoying, as it makes it confusing, comparing moderator rights to a veteran status.

right which is why im looking for the perfect compromise in not having them too decoupled where they're separate systems but also not too coupled where you're comparing a donator status to an administrator status

You should be able do be both donor and moderator.
On 22 Oct 2015 4:34 pm, "lare96"<EMAIL_ADDRESS>wrote:

right which is why im looking for the perfect compromise in not having
them too decoupled where they're separate systems but also not too coupled
where you're comparing a donator status to an administrator status
—
Reply to this email directly or view it on GitHub
https://github.com/lare96/luna/issues/7#issuecomment-150242961.

yeah, the best way to achieve this is to just keep PlayerRights with things that can be compared: player, moderator, admin, developer, super admin, head admin, etc.
anything else should be loaded somewhere else in the file as "isDonator" or whatever


Minor formatting issues

switch x {
  _ => x
}

get formatted to:
switch x {
  x => x
}

One nit-pick:  For default case, it puts two spaces after the underscore instead of one:

Since we're at it, here are a few more:
fn add(a, b) {
    a + b // comment
}

Result:
fn add(a, b) {
    a + b
}

The comment is gone.

fn add(a, b) {
    a + b; // a very very very looooooooonnnnnng long long long long long long comment
}

is formatted to:
fn add(a, b) {
    a
        + b; // a very very very looooooooonnnnnng long long long long long long comment
}

If a line comment is too line, the item gets moved to the second line, which looks strange.

Missing space before line comment if it is right after an open {.


[Fix] #8 release-cli CI-workflow

[Fix] #8 release-cli CI-workflow
Added missing dependencies and minor refactors to release.yml

ignoring build-ci for now. MR it asap

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fix panic on permission check error

Ensures that we nil check the response from a CheckPermission request before attempting to extract the debug info from it.
This regression was introduced in #354 where we added support for the new debug info in the response body rather than in HTTP trailers.

@alecmerdler feel free to release a patch version 🙏🏻


Add command to compare two classes

This is a proof of concept of compare two classes, intended to produce the common parts between two versions of the same class, e.g. after obfuscation or some other process.
The same dropping of all non-opcodes is done as in the bytecode instruction hashing.
Once that is done the resulting method bytecode is compared, first identifying and removing all 100% matches. The rest is then sorted to run a greedy algorithm over that attempts to find the longest match for each method, starting with the longest bytecode from the first class.
This results in distinct results for testing with 2.14.1, 2.15.0 and 2.16.0 comparing the apache version against an obfuscated version of the same class.
Actually using these results to compare to unknown examples will be very expensive, but if there is a class under suspicion (e.g. because it is called JndiManager) or a jar is highly suspect (e.g. all packages and classes have single character names) then this is likely a worthwhile price to pay.
Right now everything is just printed out in hex roughly as it's calculated. This is intended to give a rough idea of how it's working, this PR isn't in a format where it's intended to be merged.

example output:
 ./out/build/log4j-sniffer/0.7.0-5-gfe596e6.dirty/darwin-amd64/log4j-sniffer compare examples/multiple_bad_versions/log4j-core-2.15.0.jar org.apache.logging.log4j.core.net.JndiManager ~/obfuscated/2.15.0-aaaagb.jar org.a.a.a.a.g.b
2a012bb72a2cb52a2db52a19b52a19b5b1
12b6b201b8c0b0
2ab201b8c0b0
2a2b2c2d1919b83ab8b219b8c0b0
b8b22ab8c0b0
bb59b712b6b610b612b6b6b6b0
2ac701b0bb59b73a19122ab6572bc619122bb657a7b2122ab92cc619122cb6572dc619122db65719c6191219b657a7b2122db919c61919b619b0
2ab4b8ac
bb592bb74d2cb6c62ab42cb6b2b6b99ab2122cb6b901b0122cb6b69a122cb6b6992ab42cb6b99ab212b901b02ab42bb94e2dc6bb59b73a2db93a19b99919b9c03a1919b919b957a71912b9c03a1912b9c619c619b9b63a2ab419b99ab21219b901b0a7b2122bb901b01912b9c71912b9c6b2122bb901b0a74db2122bb901b02ab42bb9b0
bb59b712b62ab4b612b62ab4b612b6b6b0
b2b0
b2b0
b2b0
2a2b2c2d1919b7b1
b2b0
bb5901b7b3b8b310bd590312b653590412b653590512b653590612b653590712b653590812b653591012b653591012b653591012b653b8b306bd590312535904125359051253b8b3b1

Second class
2a012bb72a2cb52a2db52a19b52a19b5b1
12b6b201b8c0b0
2ab4b8ac
bb592bb7594db6c62ab42cb6b2b6b99ab2122cb6b901b0122cb6b69a122cb6b6992ab42cb6b99ab212b901b02ab42bb9594dc6bb59b74e2cb94d2cb9992cb9c03a2d19b919b957a72d12b9c03a2d12b9c619c619b9b64d2ab42cb99ab2122cb901b0a7b2122bb901b02d12b9c72d12b9c6b2122bb901b0a757b2122bb901b02ab42bb9b0
bb5912b72ab4b612b62ab4b612b6b6b0
b2b0
b2b0
b2b0
2a2b2c2d1919b7b1
b2b0
bb5903b7b3b8b310bd590312b653590412b653590512b653590612b653590712b653590812b653591012b653591012b653591012b653b8b306bd590312535904125359051253b8b3b1

Exact matches
2a012bb72a2cb52a2db52a19b52a19b5b1
12b6b201b8c0b0
2ab4b8ac
b2b0
b2b0
b2b0
b2b0
2a2b2c2d1919b7b1

Partial matches
bb592bb7_________________________________________________________________________________________________________________________b2122bb901b02ab42bb9b0
bb59___b7b3b8b310bd590312b653590412b653590512b653590612b653590712b653590812b653591012b653591012b653591012b653b8b306bd590312535904125359051253b8b3b1
bb59_____2ab4b612b62ab4b612b6b6b0

Unmatched bytecode from first class
2ac701b0bb59b73a19122ab6572bc619122bb657a7b2122ab92cc619122cb6572dc619122db65719c6191219b657a7b2122db919c61919b619b0
2a2b2c2d1919b83ab8b219b8c0b0
bb59b712b6b610b612b6b6b6b0
2ab201b8c0b0
b8b22ab8c0b0
b2b0
b2b0
b2b0

Unmatched bytecode from second class


Add Clear button for a section of the Create Project form

Overview
Links to jira tickets

https://quartech.atlassian.net/browse/BHBC-912

This PR contains the following changes

Add Clear button for a section of the Create Project form
Only the relevant sections of the form

This PR contains the following types of changes

[x] New feature (change which adds functionality)
[x] Enhancement (improvements to existing functionality)

How Has This Been Tested?

Local

Screenshots

this ticket actually is stale turns out and this is not required at this time, closing this for now @NickPhura @anissa-agahchen @jeznorth


PHP 8 support

Hi there! Switching to php 8, I got the following error:
 Problem 1
    - Root composer.json requires sven/forge-cli dev-master -> satisfiable by sven/forge-cli[dev-master].
    - sven/forge-cli dev-master requires php ^7.2 -> your php version (8.0.3) does not satisfy that requirement.

Maybe I can open up some PR to enable php 8 support, but I wanted to check if there's already been worked on yet.

Why can't I just look before opening an issue... #51 will add PHP 8 support. Thanks :)


Add DPG: Cboard

Encode Cboard full submission into JSON

Hi, I am part of a bi-annual check-in call with the Cireha/Cboard team next week. Is there any information I can get from the Cboard team to help move this nomination forward? Let me know if I be an interface to the Cboard team for this one.

@nathanbaleeta @jwflory Find below the necessary information about Cboard in order to merge this.

Cboard general ownership (in terms of the repository) is Ottaa Project, and it is part of the company's portfolio. Cboard trademark is registered in Argentina by Martín.  Overall project direction is defined by the company.

Adherence to Privacy and Applicable Laws.
https://www.cboard.io/privacy/
https://www.cboard.io/terms-of-use/

Deployment countries. What countries is this project actively deployed in (Please list the countries)?

United States, Canada, Belgium,  Argentina, Croatia, Montenegro, Macedonia, Bulgaria, Serbia, Israel.

Thanks @martinbedouret for the swift turnaround, would you be able to share a link to where the ownership of Cboard by OTTAA project is documented.

This raises a good point! We have email correspondence between OTTAA and Cboard about their collaboration, and it has also been shared to the Cboard community in their project meetings, but I don't think this has been announced publicly on the Cboard blog or the OTTAA Project blog. I think this would be a good opportunity for the OTTAA and Cboard teams to put out a blog post or press release to document their collaboration.
Some unofficial notes on this collaboration:

@UNICEFinnovate Twitter: "And in true collaborative spirit, our Portfolio companies @Cboard-org+@OTTAA-Project and qAira+@rentadronecl have been working together on business solutions and on scaling market share and impact."
Meet OTTAA Project, tech for speech impairment: "Partnered with Cboard to join forces and amplify our impact!"

@nathanbaleeta, do you have some examples you could share for @martinbedouret and @hectoritr about the general ownership of the repositories, as it pertains to trademark and copyright?

This raises a good point! We have email correspondence between OTTAA and Cboard about their collaboration, and it has also been shared to the Cboard community in their project meetings, but I don't think this has been announced publicly on the Cboard blog or the OTTAA Project blog. I think this would be a good opportunity for the OTTAA and Cboard teams to put out a blog post or press release to document their collaboration.
Some unofficial notes on this collaboration:

@UNICEFinnovate Twitter: "And in true collaborative spirit, our Portfolio companies @cboard-org+@OTTAA-Project and qAira+@RentadroneCL have been working together on business solutions and on scaling market share and impact."
Meet OTTAA Project, tech for speech impairment: "Partnered with Cboard to join forces and amplify our impact!"

@nathanbaleeta, do you have some examples you could share for @martinbedouret and @hectoritr about the general ownership of the repositories, as it pertains to trademark and copyright?

@martinbedouret Please checkout [Bisa Health]() which is owned by Bisa Technologies

Seems straightforward. What if we added a note in the README, per the GPLv3's guidance on how to apply the license to the project? Would this fulfill the requirement?
Copyright (C) 2017-2021 OTTAA Project

This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.

@jwflory looks good, please proceed!

Thank you @jwflory  and @nathanbaleeta
We have added the official communication about board and ottaa here: https://www.cboard.io/cboard/unicef/ottaa%20project/2021/11/25/cboard-and-ottaa-project/


Settings keys on field widgets

Hi! I'm quite new to flutter but Is there any way it would be possible to set predictable value keys on the underlying form field widgets? At the moment, as far as I can tell, it is not possible to locate the widgets in integration testing with flutter_driver.
If this sounds like an acceptable idea, I could take a stab at a PR

Hello @tjarvstrand,
Sounds like a great idea. A PR will be much appreciated!


get Catlab version without assuming it is a dependency

Thanks Angeline! It's hard to write a test for this, but I'm assuming you tried it out yourself and it worked?

Thanks Angeline! It's hard to write a test for this, but I'm assuming you tried it out yourself and it worked?

No problem! I did test it out, it worked, and had no regressions. Yeah, it's a bit tough to figure out a good test for it because the version will change every so often. If anything, I would be like writing a unit test for the Pkg.project() function, which I would hope they write a test for.


fixed issue noted in issue #193

PR as mentioned in issue #193 . thanks for mergin.

Awesome @zanettin
Thx


Problem when DICOM Dump to JSON and DICOM Dump using explicitDataSetToJS

When I use examples / explicitdatasettojs / index HTML and examples / explicitdatasettojson / index HTML, an error is thrown. Is this a problem, or am I using it in the wrong way?
CT.1.2.840.113619.2.278.3.168442890.71.1597019219.142.12.zip

Having the same issue here, some files we've seen crash with this same error.
Uncaught (in promise) dicomParser.explicitElementToString: cannot convert implicit element to string

Okay, I guess it's just that the DICOM is implicit VR (not explicit), which is not supported: https://github.com/cornerstonejs/dicomParser/blob/master/src/util/elementToString.js#L15

I'm going to close this because it looks like the original report was also using an implicit VR file.

@wangwendong-code and @jussimattila FYI in the latest release, the explicitDataSetToJS and explicitDataSetToJson examples now support implicit DICOM files, so this may be fixed for you. If you have private tags in your files, though, you'll need to locally update the dictionary in the example code to include them.


athb & athb_array

Modified jsdoc and import pmv_calculation from pmv_ppd.js, resolved conflict
for review purpose
All tests of athb passed, it won't pass on GitHub because missing pmv_ppd.js in this commit

this seems okay now, I will approve once all the checks pass


Fix various buttons show/noshow and text

…eady registered user.

 Change the landing page for invited reviewer agreeing to review.


when i install the protobuf my goland was showing  waring

What version of protobuf and what language are you using?
Version: (e.g., v1.1.0, 89a0c16f, etc)
D:\GOPATH\src\mypro\message>protoc --version
libprotoc 3.17.0
golang 1.6
What causes it?
What should I do about it？
Const initializer 'protoimpl.EnforceVersion(protoimpl.MaxVersion - 20)' is not a constant

What did you do?
If possible, provide a recipe for reproducing the error.
A complete runnable program is good with .proto and .go source code.
What did you expect to see?
What did you see instead?
Make sure you include information that can help us debug (full error message, exception listing, stack trace, logs).
Anything else we should know about your project / environment?

🤔 This is werid. protoimpl.EnforceVersion is a type and both protoimpl.MinVersion and protoimpl.MaxVersion are declared in a const ( … ) grouping. So, these expressions should be a constant.
What is your go.mod? Perhaps you are picking up some odd version, or something else that is confusing your goland?

This error suggests that somehow the wrong version of the google.golang.org/protobuf is being used by your development environment.

Closing as inactionable. We try to keep this issue tracker about actionable issue. For questions regarding usage, it is better to ask on Slack or on some other means where you can more readily get immediate help. Consider joining the #protobuf channel or the Gophers slack workspace: https://gophers.slack.com/messages/general/


Update AutoStop.java

Add environment variable which indicates that threshold limit was hit and test was stopped. This is required later to check in Tear down thread group and act accordingly (e.g. in my case I want to send Slack message about failed test).

For this to complete, you'd need to also document this feature, so other people would be able to discover it, too. It lives in this file: https://github.com/undera/jmeter-plugins/blob/master/site/dat/wiki/AutoStop.wiki
If you want to make this really JMeter-style feature, you should introduce a UI input field where user inputs the name of environment variable to set. That would need a but more programming. However, I won't insist on this.

For this to complete, you'd need to also document this feature, so other people would be able to discover it, too. It lives in this file: https://github.com/undera/jmeter-plugins/blob/master/site/dat/wiki/AutoStop.wiki
If you want to make this really JMeter-style feature, you should introduce a UI input field where user inputs the name of environment variable to set. That would need a but more programming. However, I won't insist on this.

Thanks, wiki updated. I don't have much experience in developing JMeter plugins, but this feature I believe could be interesting for many. The use case here is to use JMeter in CI envirnoment to run fully automated performance test after deployment and stop test + alert based on response times. Feel free to suggest other changes or update if you see value in this.
Only other way to fail test and take actions based on average response/latency times is via Taurus, but that's a completely different realm.

This plugin is so rarely changed, that I'm happy to see any improvement.
Thanks for contributing!


omni_gettradehistoryforaddress : Add blocktime for each match in matches array of JSON response

When trying to build a list of all DEX matching transactions for an Omni Core wallet, the omni_gettradehistoryforaddress method is very useful. However, in order to get a timestamp for each matching transaction an additional call for each match must be made to get the transaction (block) time.
Adding a blocktime property to each object in the matches array would eliminate the need for these extra calls. (The blocktime property in the root object is the blocktime for the sell offer, but we also need the time for each matching transaction.)
It might also make sense to add a blocktime property to each match in the response to omni_gettradehistoryforpair.

PR #1270 looks good!


v0.11.0 release branch

Let's release 0.11.0!

Closing, https://github.com/vegafusion/vegafusion/pull/188 accidentally commented out some important tests and there are some new bug fixes we want to get in for the release


Add coverageReport sbt task

@matthewfarwell
Codecov shows 0% coverage since its not grabbing the report

Codecov Report

Merging #337 into master will increase coverage by 88.56%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #337       +/-   ##
===========================================
+ Coverage       0%   88.56%   +88.56%
===========================================
  Files          62       62
  Lines        1495     1495
  Branches      146      156       +10
===========================================
+ Hits            0     1324     +1324
+ Misses       1495      171     -1324

Impacted Files
Coverage Δ

src/main/scala/org/scalastyle/Main.scala
36.84% <0%> (+36.84%)
:arrow_up:

src/main/scala/org/scalastyle/Output.scala
46.77% <0%> (+46.77%)
:arrow_up:

...scala/org/scalastyle/ScalastyleConfiguration.scala
64.94% <0%> (+64.94%)
:arrow_up:

...cala/org/scalastyle/util/CreateRulesMarkdown.scala
81.57% <0%> (+81.57%)
:arrow_up:

...scalastyle/scalariform/AbstractMethodChecker.scala
82.5% <0%> (+82.5%)
:arrow_up:

src/main/scala/org/scalastyle/Checker.scala
82.71% <0%> (+82.71%)
:arrow_up:

...tyle/scalariform/ProcedureDeclarationChecker.scala
83.33% <0%> (+83.33%)
:arrow_up:

.../scalastyle/scalariform/NamedArgumentChecker.scala
84.61% <0%> (+84.61%)
:arrow_up:

src/main/scala/org/scalastyle/Directory.scala
86.36% <0%> (+86.36%)
:arrow_up:

src/main/scala/org/scalastyle/CommentFilter.scala
86.95% <0%> (+86.95%)
:arrow_up:

... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec14399...4a81f3f. Read the comment docs.


continuous variable overlays switch from gradient to discrete when heavily subsetted

Data viz topic:
heavy subsetting switches the legend for a continuous variable from the gradient to the standard categorical colormap
See: GEMS1 scatterplot using BMI-for-age as overlay:
unsubsetted:

with heavy subsetting:

@danicahelb @asizemore I have checked this and looked into corresponding web-eda part. I tried to mimic the behavior and confirmed that it happened when the number of data points are small. What happens in this case is that the backend does not return gradient data (seriesGradientColorscale) to the frontend (perhaps due to the lack of data points to compute gradient level?). So, the frontend treats such a small number of data points as a normal plot.
Thus, I don't know what you want in this case without having the backend data. Perhaps current behavior is what it should be?

i dont think we want to keep the current behavior, it is very confusing
@moontrip what is a "small" number of data points? is the issue the number of data points or the number of unique overlay values for that small set of data points?
@d-callan can we adjust something on the backend?

This should get fixed in plot.data in the short term, and this ticket transferred there. In the longer term we probably want the client to dictate which colormaps it'd like to use? That's probably worth a separate discussion and ticket.

Thanks @d-callan for taking care of it.
@danicahelb Honestly, I don't know exact condition that happens. From my various tests, it occurs when the number of data points is small, usually less than 8 points.

@d-callan i've made this placeholder ticket for the convo about the client dictating which colormap to use https://github.com/VEuPathDB/EdaNewIssues/issues/606


Possibility to change sample data row number in profiler workflow

let's do this on 0.12.1

This has been implemented


ProgrammingError at /en/cms_wizard/create/ substr

Using MSSQL server as the backend for Django CMS leads to following error:
ProgrammingError at /en/cms_wizard/create/
('42000', "[42000] [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]'substr' is not a recognized built-in function name. (195) (SQLExecDirectW)")

params | (5, 0, 6, 'en', 'omg%')
self | <sql_server.pyodbc.base.CursorWrapper object at 0x7f38b5b62e50>
sql | ('SET NOCOUNT OFF; UPDATE [cms_title] SET [path] = substr([cms_title].[path], '  '?) WHERE ([cms_title].[has_url_overwrite] = ? AND [cms_title].[page_id] IN '  '(SELECT V0.[id] FROM [cms_page] V0 WHERE V0.[node_id] IN (SELECT U0.[id] '  'FROM [cms_treenode] U0 WHERE U0.[id] = ?)) AND [cms_title].[language] = ? '  "AND [cms_title].[path] LIKE ? ESCAPE '\\')")

@zacqed can you provide additional information as requested in the issues template?

Closing this due to insufficient info.


No alias when using GROUPBY on a Function

This PR fixes a bug where using GROUP BY on a Function creates an invalid Vertica query if the Function has an alias set.

Coverage increased (+0.002%) to 98.315% when pulling e9e14ec8f9c244e4e275539c8d20668ff71fc514 on bugfix/no-alias-in-group-by into 1299bff26a68cfd98105012126f15ba3513c548b on master.

All issues should be fixed now.

Coverage increased (+0.002%) to 98.315% when pulling f205d5f33bd58f7c184a6fc85311bc13811b532d on bugfix/no-alias-in-group-by into 1299bff26a68cfd98105012126f15ba3513c548b on master.

Coverage increased (+0.002%) to 98.315% when pulling af699f0d00fa4ce7a4e8a37a647816fabad997e4 on bugfix/no-alias-in-group-by into 1299bff26a68cfd98105012126f15ba3513c548b on master.


double-beep: Watch metagenix\W?alpha\W?x

double-beep requests the watch of the watch_keyword metagenix\W?alpha\W?x. See the MS search here and the Stack Exchange search here.

metagenix\W?alpha\W?x has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by tripleee in Charcoal HQ


Tools / Battery: 'Charging' and 'Discharging' are swapped

Shouldn't it read 'Discharging' instead of 'Charging', when not connected to a charger?
(and vice versa)

That's odd; does it show a capacity (mAh) and current draw for you?

That's odd; does it show a capacity (mAh) and current draw for you?

At least on my 'willow' it does; cf. attached graphs.

At least on my 'willow' it does; cf. attached graphs.

On the 'willow' device, does the capacity shown increase when connected to the charger (and alternatively, does it decrease when disconnected)?

On the 'willow' device, does the capacity shown increase when connected to the charger (and alternatively, does it decrease when disconnected)?

I made a few changes to the battery screen in my latest push to main. Based on your post in the New Feature Ideas discussion, it looks like you are building from source. If so, would you be able to try out the latest version on the main branch?
(if not, I can generate a debug build and upload it to dropbox)

I made a few changes to the battery screen in my latest push to main. Based on your post in the New Feature Ideas discussion, it looks like you are building from source. If so, would you be able to try out the latest version on the main branch?
(if not, I can generate a debug build and upload it to dropbox)

Capacity decreases when disconnected (and vice versa), seems to be working the right way.
I'll try to build with current version, and am going to check, in case I'll succeed.

Capacity decreases when disconnected (and vice versa), seems to be working the right way.
I'll try to build with current version, and am going to check, in case I'll succeed.

Okay, thank you.
The odd thing is that it works correctly on my device, and according to the Android documentation it is set up properly (positive current means charging, negative discharging - which is what determines the charging message).

Okay, thank you.
The odd thing is that it works correctly on my device, and according to the Android documentation it is set up properly (positive current means charging, negative discharging - which is what determines the charging message).

Done:

Version is now 1.6, so I assume I'm using the current sources.
Behaviour is still the same as before ..
The value behind the Charging/discharging message (below the bar) is always positive, I assume it
is not the original value which the decision on charging/discharging is based upon?

Done:

Version is now 1.6, so I assume I'm using the current sources.
Behaviour is still the same as before ..
The value behind the Charging/discharging message (below the bar) is always positive, I assume it
is not the original value which the decision on charging/discharging is based upon?

Thank you - and does the arrow next to the percentage change at all?
And no, it is not the original value which the decision for that message is made on, it updates every 20ms with the latest current data from Android's OS (which update frequency there is determined by the manufacturer).

Thank you - and does the arrow next to the percentage change at all?
And no, it is not the original value which the decision for that message is made on, it updates every 20ms with the latest current data from Android's OS (which update frequency there is determined by the manufacturer).

I seem to have lost the arrow (I remember having it seen in the past, and was wondering why it didn't change, or what it was supposed to indicate).
Another observation: on my S4 the charging/discharging seems to be indicated the right way, though the total charge there is always zero, like on the Moto G4.
I need to go out, maybe I can check te source code myself later (not saying that I'm going to understand anyting 8-) )

I seem to have lost the arrow (I remember having it seen in the past, and was wondering why it didn't change, or what it was supposed to indicate).
Another observation: on my S4 the charging/discharging seems to be indicated the right way, though the total charge there is always zero, like on the Moto G4.
I need to go out, maybe I can check te source code myself later (not saying that I'm going to understand anyting 8-) )

Okay, thank you for testing that. I'm going to make a few more changes and I'll let you know when they are in place.
The arrow currently uses the change in capacity to determine which way it points - so if the capacity doesn't change, it won't show up (which looking at your screenshots, it doesn't seem to change other than the initial load). If the capacity is reported at 0, it uses a different metric to determine the arrow.

Okay, thank you for testing that. I'm going to make a few more changes and I'll let you know when they are in place.
The arrow currently uses the change in capacity to determine which way it points - so if the capacity doesn't change, it won't show up (which looking at your screenshots, it doesn't seem to change other than the initial load). If the capacity is reported at 0, it uses a different metric to determine the arrow.

On the S4, new build, I just saw the arrow again, at it seems to do the right thing (going up when charging eg).
Total charge is gone now (before it was at '0' constantly.
Could it be an option to open a dedicated Telegram group for this app btw?
Thanks  - Jakob.

On the S4, new build, I just saw the arrow again, at it seems to do the right thing (going up when charging eg).
Total charge is gone now (before it was at '0' constantly.
Could it be an option to open a dedicated Telegram group for this app btw?
Thanks  - Jakob.

Thanks! I'll look into the Telegram group, I've never used it before.

Thanks! I'll look into the Telegram group, I've never used it before.

I think I fixed these issues now - when you get a chance, can you confirm it is behaving properly? (no rush, whenever you have a chance)
For reference:

The arrow is now determined by the Android OS (no longer tied to the capacity, which is only available on some devices)
The charging message will match the arrow regardless of if the current was reported as positive or negative (I'm guessing some manufacturers have that opposite)
If the device does not report current usage, it falls back to AC, DC, or Wireless charging - which is something all devices should report

I think I fixed these issues now - when you get a chance, can you confirm it is behaving properly? (no rush, whenever you have a chance)
For reference:

The arrow is now determined by the Android OS (no longer tied to the capacity, which is only available on some devices)
The charging message will match the arrow regardless of if the current was reported as positive or negative (I'm guessing some manufacturers have that opposite)
If the device does not report current usage, it falls back to AC, DC, or Wireless charging - which is something all devices should report

Working as expected now, thanks!
'Charging' and 'arrow up', when charging, and vice versa.
Some details:

Current charge is not displayed on S4 and MG4+, on willow it is there (not changing very often it seems).
S4 shows always '0 mA' for charging/discharging current, might be a ROM problem.

Thanks for the quick fix!

Working as expected now, thanks!
'Charging' and 'arrow up', when charging, and vice versa.
Some details:

Current charge is not displayed on S4 and MG4+, on willow it is there (not changing very often it seems).
S4 shows always '0 mA' for charging/discharging current, might be a ROM problem.

Thanks for the quick fix!

Awesome, thank you for testing!
The 0 mA is probably because that property isn't implemented either in the ROM or it lacks the appropriate hardware. I'll put a check in place to fall back to the charging type when 0 mA (or something that round to 0mA) is present.

Awesome, thank you for testing!
The 0 mA is probably because that property isn't implemented either in the ROM or it lacks the appropriate hardware. I'll put a check in place to fall back to the charging type when 0 mA (or something that round to 0mA) is present.


Rename bookmarks

Can we have a keybinding to rename bookmarks, for example ur and uR?

There's no direct renaming feature at the moment. You can use keybinding ua for the path you want to rename. I'll implement it later.

Thanks for the suggestion. This feature has already been implemented. Have a pleasant experience.

Thanks


Bug to do with second monitor.

Microsoft PowerToys version
V0.79.0
Installation method
Microsoft Store
Running as admin
Yes
Area(s) with issue?
TextExtractor
Steps to reproduce

✔ Expected Behavior
It's not supposed to zoom in to the corner only It's supposed to do the whole screen.
❌ Actual Behavior
It's only zooming into the corner of my screen. It only seems to do that when my second monitor on the right side only.

Other Software
No response

/dup #21676
we have committed a fix which will hopefully resolve this issue in v0.80


Implement list comprehension and list aggregation

Fixes #910  and #909

[x]  List Aggregation Support

let average =
  reduce z, a in ages from 0 {
    yield z + a;
  };

[x]  List Comprehension Support

let ages =
  for p in people {
    yield p.age;
  };

[x]  RibByteCodeCursor for Jump loops

[x] Math operations

[x]  Remove Clone from interpreter stack values (a derived outcome, yet a good outcome)

[x] Other needed clean ups

A ticket for this week based on my own review:  https://github.com/golemcloud/golem/issues/1035

Fixing a few compilation errors, which I didn't foresee in other modules


[Bug]: Incorrect script in music recognition tutorial

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
In this page, this script has two problems:
import numpy as np
import os
from pathlib import Path

dataset_path = './music_dataset/dataset'
music_list = [f for f in Path(dataset_path).glob('*')]
vec_sets = []

for audio_path in music_list:
    vecs = embedding_pipeline(str(audio_path))
    norm_vecs = [vec / np.linalg.norm(vec) for vec in vecs[0][0]]
    vec_sets.append(norm_vecs)
Loading model...
Model is loaded.

the path './music_dataset/dataset' doesn't exist. after unzip the file, the path is './music_dataset/music_dataset'
the 'Loading model...' and 'Model is loaded.' is invalid code, should be commented with "#", or use print() to print them.

Expected Behavior
No response
Steps To Reproduce
No response
Environment
- Towhee version(e.g. v0.1.3 or 8b23a93):
- OS(Ubuntu or CentOS):
- CPU/Memory:
- GPU:
- Others:

Anything else?
No response

This is fixed in https://github.com/towhee-io/towhee-docs/pull/125 (gdown link is updated but this has not been merged yet.)
Fixed in https://github.com/towhee-io/towhee-docs/pull/130

@yhmo How do you download the test dataset? If using gdown from google cloud, the it should be "./music_dataset/dataset"

I just follow the music recognition tutorial, run this command to download:
gdown 'https://drive.google.com/uc?id=1gHF8HDzXxeSy8bhtaTVueRFVPdj6ZEZJ'
It seems the URL has been fixed, now it is correct.
5 hours ago I use the same command but download a file named "data.zip":

/close


ci: enable tests

I see only 2 (!!!) test issues:

testautomation --filter audio_resampleLossERROR: 07/19/24 19:09:00: Assert 'Expected output length 9600000, got 9600004.': Failed

Is the test too strict? Or is this actual audio distortion?
The tests are timing out on the msys2 runners and nothing is actually run. I will look into this.

Is the test too strict? Or is this actual audio distortion?

I think this is actual audio distortion, I was waiting for @icculus to look into this.

Suggest rebasing and retesting especially after eae0b80c095fd6171e524bcca86c4627f547c6c2 which fixed incompatibility between dynapi and main body .

I see a segfault on macos.
Perhaps it's related to https://github.com/libsdl-org/sdl2-compat/issues/206?

I see a segfault on macos. Perhaps it's related to #206?

I'm sure it is.

There is still some segfault on macos
This is using SDL3 hash fe5dcf79be0c00d7220ea0a8fdecf1306d2c90d9 -> https://github.com/libsdl-org/SDL/commit/fe5dcf79be0c00d7220ea0a8fdecf1306d2c90d9

There is still some segfault on macos This is using SDL3 hash fe5dcf79be0c00d7220ea0a8fdecf1306d2c90d9 -> libsdl-org/SDL@fe5dcf7

Fixed in a81922a. @icculus, can you double check that this matches the original SDL2 behavior on macOS?

Woohoo! Awesome job, SDL team !

@slouken you might want to disable the "Create a merge commit" option for PRs for this repo, and other satellite repos, as well

@slouken you might want to disable the "Create a merge commit" option for PRs for this repo, and other satellite repos, as well

Done!


Incompatibility or no relocated dependencies alerts

Problem
It is evident that when trying to turn on a server with this plugin present, other plugins that contain dependency detectors in their code, PlayerKits2 does not have correct relocations.

Because it is important?
As the information presented by the "LibertyBans" plugin, this may cause incompatibility or dependency failures with other plugins, or simply not start.
Solution
Some small changes are made to the dependency manager, correctly carrying out the relocations, giving good results.

Extra
A version upload is made, as it is an important change, it is taken into account in the nomenclature for versioning in git

Was this tested enabling the PlayerKits2 MySQL feature on the configuration?

Database connection is successful with current changes

However I just found a bug with "slf4j", I will make the change for the final version

Now everything works correctly @Ajneb97


Semihosting not handled properly by QEMU

Describe the bug
I'm implementing backend driver for emulated flash that uses semihosting to utilize file stored on host machine as its flash storage. When I run tests on qemu_cortex_a53 with QEMU from Zephyr SDK 0.16.8 some tests are failing. It looks like next read/write operation is started before the previous one is completed or they are not flushed. Either way content of the file is not changed what causes unexpected values. When I run the same tests with upstream QEMU all tests are passing. The issue hasn't been discovered as semihosting wasn't used extensively in zephyr. This is not a regression. It looks like somewhere between 7.0 used in Zephyr SDK and newest 9.1 upstream version of QEMU the issue has been fixed.
To Reproduce
Checkout to the pull/76639/head:pr_76639 to get emulated flash tests with semihosting backend driver and execute following command:
west build -b qemu_cortex_a53 tests/drivers/flash_simulator/flash_sim_impl -T drivers.flash.flash_simulator.semihost -t run

If you want to run the test suite calling qemu-system-aarch64 directly, use following command:
qemu-system-aarch64 -cpu cortex-a53 -nographic -machine virt,secure=on,gic-version=3 -net none -pidfile qemu.pid -chardev stdio,id=con,mux=on -serial chardev:con -semihosting-config enable=on,target=auto,chardev=con -mon chardev=con,mode=readline -icount shift=4,align=off,sleep=on -rtc clock=vm -kernel build/zephyr/zephyr.elf

Expected behavior
All tests should pass
Impact
This bug stops me from being able to merge the #76639
Logs and console output
Zephyr SDK 0.16.8 (downstream QEMU 7.0)
*** Booting Zephyr OS build v3.7.0-2278-g9aa7f6c3d331 ***
Running TESTSUITE flash_sim_api
===================================================================
START - test_align
 PASS - test_align in 0.001 seconds
===================================================================
START - test_flash_fill

    Assertion failed at WEST_TOPDIR/zephyr/tests/drivers/flash_simulator/flash_sim_impl/src/main.c:493: flash_sim_api_test_flash_fill: ((uint8_t)buf[i & (sizeof(buf) - 1)] not equal to 0x55)
Unexpected value at offset 0

 FAIL - test_flash_fill in 2.123 seconds
===================================================================
START - test_flash_flatten
 PASS - test_flash_flatten in 1.633 seconds
===================================================================
START - test_get_erase_value
 PASS - test_get_erase_value in 0.001 seconds
===================================================================
START - test_get_mock
 PASS - test_get_mock in 0.001 seconds
===================================================================
START - test_out_of_bounds
 PASS - test_out_of_bounds in 0.001 seconds
===================================================================
START - test_read
 PASS - test_read in 0.590 seconds
===================================================================
START - test_write_read_erase

    Assertion failed at WEST_TOPDIR/zephyr/tests/drivers/flash_simulator/flash_sim_impl/src/main.c:178: test_write_read: (val32 not equal to r_val32)
flash byte at offset 0x0 has value 0xffffffff, expected 0x00000000
 FAIL - test_write_read_erase in 2.082 seconds
===================================================================
TESTSUITE flash_sim_api failed.

------ TESTSUITE SUMMARY START ------

SUITE FAIL -  75.00% [flash_sim_api]: pass = 6, fail = 2, skip = 0, total = 8 duration = 6.432 seconds
 - PASS - [flash_sim_api.test_align] duration = 0.001 seconds
 - FAIL - [flash_sim_api.test_flash_fill] duration = 2.123 seconds
 - PASS - [flash_sim_api.test_flash_flatten] duration = 1.633 seconds
 - PASS - [flash_sim_api.test_get_erase_value] duration = 0.001 seconds
 - PASS - [flash_sim_api.test_get_mock] duration = 0.001 seconds
 - PASS - [flash_sim_api.test_out_of_bounds] duration = 0.001 seconds
 - PASS - [flash_sim_api.test_read] duration = 0.590 seconds
 - FAIL - [flash_sim_api.test_write_read_erase] duration = 2.082 seconds

------ TESTSUITE SUMMARY END ------

===================================================================
PROJECT EXECUTION FAILED
QEMU: Terminated

upstream QEMU 9.1
*** Booting Zephyr OS build v3.7.0-2278-g9aa7f6c3d331 ***
Running TESTSUITE flash_sim_api
===================================================================
START - test_align
 PASS - test_align in 0.001 seconds
===================================================================
START - test_flash_fill
 PASS - test_flash_fill in 3.222 seconds
===================================================================
START - test_flash_flatten
 PASS - test_flash_flatten in 1.633 seconds
===================================================================
START - test_get_erase_value
 PASS - test_get_erase_value in 0.001 seconds
===================================================================
START - test_get_mock
 PASS - test_get_mock in 0.001 seconds
===================================================================
START - test_out_of_bounds
 PASS - test_out_of_bounds in 0.001 seconds
===================================================================
START - test_read
 PASS - test_read in 0.590 seconds
===================================================================
START - test_write_read_erase
Incremental pattern expected
Erased area expected
Incremental pattern expected
 PASS - test_write_read_erase in 2.697 seconds
===================================================================
TESTSUITE flash_sim_api succeeded

------ TESTSUITE SUMMARY START ------

SUITE PASS - 100.00% [flash_sim_api]: pass = 8, fail = 0, skip = 0, total = 8 duration = 8.146 seconds
 - PASS - [flash_sim_api.test_align] duration = 0.001 seconds
 - PASS - [flash_sim_api.test_flash_fill] duration = 3.222 seconds
 - PASS - [flash_sim_api.test_flash_flatten] duration = 1.633 seconds
 - PASS - [flash_sim_api.test_get_erase_value] duration = 0.001 seconds
 - PASS - [flash_sim_api.test_get_mock] duration = 0.001 seconds
 - PASS - [flash_sim_api.test_out_of_bounds] duration = 0.001 seconds
 - PASS - [flash_sim_api.test_read] duration = 0.590 seconds
 - PASS - [flash_sim_api.test_write_read_erase] duration = 2.697 seconds

------ TESTSUITE SUMMARY END ------

===================================================================
PROJECT EXECUTION SUCCESSFUL
QEMU: Terminated

Environment (please complete the following information):

OS: Linux (docker zephyrprojectrtos/zephyr:latest)
Toolchain: Zephyr SDK 0.16.8
#76639

I'm wondering whether it's better to update qemu fork to the newest version or try to apply patches from upstream on current version to fix this. Getting right patches is not trivial as there are many changes that depends on each other

I'm wondering whether it's better to update qemu fork to the newest version or try to apply patches from upstream on current version to fix this. Getting right patches is not trivial as there are many changes that depends on each other

Upgrade to QEMU 9.1 is planned for some time in 2025; so, I would say it would be better to identify and backport the QEMU patch that fixed this issue to the Zephyr QEMU fork.

Upgrade to QEMU 9.1 is planned for some time in 2025;

why can't this be done before 2025? What is the holdup? Can we make this move faster? Let me know if anything is needed to make this go faster.

@stephanosio

Upgrade to QEMU 9.1 is planned for some time in 2025;

why can't this be done before 2025? What is the holdup? Can we make this move faster? Let me know if anything is needed to make this go faster.

Reworking all the existing patches in our fork (there are many) and making sure QEMU 9 is "compatible" with our CI (upgrading QEMU version has been quite painful in the past due to all sorts of breakages in the CI) takes a lot of work. I would prefer to tackle this alongside the rest of toolchain upgrade tasks.


Ben/csv

Purpose
Access the available profile on the server or locally using the InputData class.
What the code is doing
Implement a get_profile_version in the InputData class that returns the profile version for the specified field (demand, hydro, solar or wind).
Testing
>>> from powersimdata.input.input_data import InputData
>>> info = {"base_demand": "vJan2021", "grid_model": "usa_tamu"}
>>> id = InputData()
>>> version = id.get_profile_version(info, "demand")
>>> version
['vJan2021']

Where to look
in the powersimdata.input.input_data module.
Note
This function will be used in the powersimdata.scenario.create module to fetch the available profile version when the user builds a scenario. This is currently achieved by the CSV class. I did not touch the powersimdata.scenario.create module in this PR since we will refactor the Create and _Builder class in a next PR and any effort to remove the CSV instance and used the get_profile_version of the InputData class in place will most likely not be helpful for the new design.
Time estimate
5 min

Did you want the target to be the model branch? Looks like some changes here that were already reviewed and merged into that

Did you want the target to be the model branch? Looks like some changes here that were already reviewed and merged into that

Good catch. Thanks


Protobuf test for decoding response with dispatch exception

This PR adds a test to ensure that DispatchException decoded by Protobuf invoker has ConvertToInternal set to true. It is equivalent to the IncomingResponseTests we have for Slice.

Making these 2 private methods of IceRpc.Protobuf internal and then exposing all internals to the test assembly does not seem clean or necessary to me.
It shouldn't be difficult to write a test where the client receives a DispatchException "over the wire". And this test could then simply rely on the public API.

Probably, but we already do the same thing for Zeroc.Slice.

Probably, but we already do the same thing for Zeroc.Slice.

Presumably you meant IceRpc.Slice? If we have the same structure in IceRpc.Slice, we should fix it too.

Probably, but we already do the same thing for Zeroc.Slice.

Presumably you meant IceRpc.Slice? If we have the same structure in IceRpc.Slice, we should fix it too.

I was just looking to see which other projects a similar assembly info ZeroC.Slice was the first one I found. IceRpc.Slice does not  have this.

Reworked the test to use the public API.


Release 0.6.11

Codecov Report

Merging #3155 (6ad44b7) into main (bdb68ef) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3155   +/-   ##
=======================================
  Coverage   82.12%   82.12%
=======================================
  Files          55       55
  Lines        6064     6064
=======================================
  Hits         4980     4980
  Misses       1084     1084

Impacted Files
Coverage Δ

flax/version.py
100.00% <100.00%> (ø)


relax test for simple iterator()

See https://github.com/Level/abstract-leveldown/blob/master/abstract/iterator-test.js#L125-L128 , also rewrite the test a bit, since it doesn't really make sense to do e.g.
if (key && value) {
  t.ok(key, 'key exists')
  t.ok(value, 'value exists')
}

Maybe instead use a counter that unless the counter is at the end, then key and value should be set, if not, then check for undefined on err, key and value.
Also, remove https://github.com/Level/abstract-leveldown/blob/master/abstract/ranges-test.js#L14-L48 since it's basically the same test and doesn't add any value

Relevant code is now here:
https://github.com/Level/abstract-level/blob/5bf853a0b7ca882652f3a630d6633da2f6e57f7d/test/iterator-test.js#L163-L197
Which I agree, should not check specific keys or values, just that it got one. In addition, subsequent tests are dependent on the data written in this test, which is not immediately obvious.


Windows startup

Hi guys,
I would like LedFx to start automatically after the Windows startup. Is this possible?
I used to do that with the "old" Systematic-LED by not-matt by using the Windows task scheduler but I don't which file to start.
It would be useful to know which python file is started with the command "ledfx --open-ui". For Systematic-LED you had to execute the "main.py".

I am also looking for solution but for Linux system

I am able to do this by doing below step in pi
1)Create any file called rohan.sh
--Content of file
/home/pi/.local/bin/ledfx
2)Call this file in rc.local
sudo /home/pi/rohan.sh 2 > /etc/nohup.out &
3)sudo reboot
Once PI comes online Ledfx is able to start sucessfully
**Please rember to do all the installation with root user else it will not work
'

I worked out a solution:

Create a batch file with this code:
@echo off C:\Users\_username_\anaconda3\Scripts\activate ledfx && ledfx --open-ui
You might need to change the environment if you gave it another name.

Start the batch file on startup by either putting it into the Startup folder (WIN+R --> shell:startup) or creating a new task in the windows task sheduler.


A lot of detail missing on the Data Integrator

[Enter feedback here]
There is a lot of detail and documentation missing on the Data Integrator.

UI has changed, this needs to be updated.
Integration Key - where is the usage of this documented?
How do you stop a test integration or migration job?

A lot is missing.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bd884343-7f2e-9765-4860-4cb4981a908e
Version Independent ID: efe70284-6f99-698c-9406-802595535d97
Content: Integrate data into Microsoft Dataverse - Power Platform
Content Source: power-platform/admin/data-integrator.md
Service: power-platform
GitHub Login: @sabinn-msft
Microsoft Alias: sabinn

We are recommending all our customers to start using dual-write (https://docs.microsoft.com/en-us/dynamics365/fin-ops-core/dev-itpro/data-entities/dual-write/dual-write-home-page). I request you review this for your use to integrate Finance and operations apps with Dataverse


Assign to array indexes

We currently don't support this syntax:
a := [1, 2, 3]
a[0] = 0

Do we want to?

I think yes, it's way too expected to be left out.

So... Turns out this is like... Really complicated to do. I think we want to rewrite how we handle expressions.

Doing an expression rewrite, for this case, to combine two branches into one.

After thinking some more, the code is only duplicated 2 times. I don't like it but it simplifies a lot of other things in the compiler. That said, we should probably do a complete expression rewrite, since some of it is a bit convoluted. Like:
a! true <=> 0

Should in my mind work as a program. It might be a pipedream, and completely unnessecary. I don't know, one can argue that this code is a lot clearer and should be prefered
0 <=> a! true

I think this should morph into a new issue.

I think this should morph into a new issue.

Sure. The question becomes if we have the time/energy for a complete rewrite.


Refactor JoinExpressionBase & Improve uniquification of table alias

This is another breakout from #7543 that will shave 9 files or so off of that PR. Summary:

Added the LeftJoinLateralExpression, although it is not used yet in this PR
Renamed LateralJoinExpression to CrossJoinLateralExpression for consistency and to resolve ambiguity
Introduced a new base class, PredicateJoinExpressionBase, for InnerJoinExpression and LeftOuterJoinExpression to inherit from. This allows CrossJoinLateralExpression and LeftJoinLateralExpression to then inherit from JoinExpressionBase, creating new and stronger possibilities for algorithms like HandlesQuerySource and GetTableForQuerySource
Most places using SelectExpression.AddTable(TableExpressionBase, bool) were passing false, so changed the couple of places that were not to generate the unique alias themselves in order to simplify things. One places was already doing this, resulting in unnecessary uniquification anyways.
Instead of adding more AddWhateverJoin methods to SelectExpression for the LeftJoinLateral, removed all of the AddWhateverJoin methods and added an AddToProjection(IEnumerable<Expression>) method.

Hi @tuespetre, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

:up::date:
I have made the requested changes in addition to catching that I forgot to make CrossJoinExpression inherit from JoinExpressionBase.

Looks good otherwise 😃

:up::date:

:up::date: to rebase onto the VS2017 changes

Merged via d95988daa3b866b09acbb3e2b457cb5eee0f3c68


⚠ Bofrost.de has degraded performance

In aeeda24, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 949 ms

Resolved: Bofrost.de performance has improved in 660150b.


Click doesn't work

In the provided template ssr-vue, In the DEV environment the click event does not work, and this is also the case in my own project. Clicking is completely unresponsive and does not execute the functions in setup，How to solve this problem

<template>

Home

  <button @click="state.count++">count is: {{ state.count }}</button>
  <Foo />

msg from virtual module: {{ foo.msg }}

this will be styled with a font-face

  <ImportType />
</template>

https://github.com/vitejs/vite/tree/main/packages/playground/ssr-vue，this is template's url.

https://github.com/halodong/issue-click-not-work-3654, Here I reproduce the problem.

in index.html,  instead of , it should be

in index.html, instead of , it should be

client is csr , but i need ssr

ssr is performed in server side. in index.html you need entry-client.js to
hydrate
Dong @.***>于2021年6月4日 周五20:33写道：

in index.html, instead of , it should be

client is csr , but i need ssr
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/vitejs/vite/issues/3654#issuecomment-854675079, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABXDV3D5XJEHIOOUROS76LLTRDB3NANCNFSM457CASJQ
.

ssr is performed in server side. in index.html you need entry-client.js to hydrate Dong @.***>于2021年6月4日 周五20:33写道：
…
in index.html, instead of , it should be  client is csr , but i need ssr — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3654 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXDV3D5XJEHIOOUROS76LLTRDB3NANCNFSM457CASJQ .

So that's it! Thank you for solving my problem


[CWS] Log errors when stopping the eventmonitor module

What does this PR do?

Starts logging errors occuring when the eventmonitor module is stopped
Avoids closing the eventmonitor gRPC socket twice (as the gRPC server is already closing it when stopped)

Motivation
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes

/merge


Add preprocessNodes option

Add preprocessNodes option
Expose htmlparser2 library

Coverage remained the same at 100.0% when pulling ddcdf9f69d3b1257d140533ba7e9f152b7072f90 on custom_processNodes into 4de7c2c26f3d80fae2992b7d5198afda3c1920d8 on master.

Coverage remained the same at 100.0% when pulling 22bd74494c5220d9dadf884a700293a7347443b0 on custom_processNodes into 4de7c2c26f3d80fae2992b7d5198afda3c1920d8 on master.


Weak

Hello,
Just for tour information :-) : on IOS
/platforms/ios/Pods/Starscream/Sources/WebSocket.swift:125:5: warning: 'weak' should not be applied to a property declaration in a protocol and will be disallowed in future versions
    weak var delegate: WSStreamDelegate? {get set}

[18-08-05 09:54:15.348] (CLI) === BUILD TARGET QBImagePickerController OF PROJECT Pods WITH CONFIGURATION Release ===
[18-08-05 09:54:15.348] (CLI) /Users/kefahbader/Sites/nativescript-project/DIGI-PAY-CLIENTS/platforms/ios/Pods/Starscream/Sources/WebSocket.swift:125:5: warning: 'weak' should not be applied to a property declaration in a protocol and will be disallowed in future versions
[18-08-05 09:54:15.348] (CLI)     weak var delegate: WSStreamDelegate? {get set}
[18-08-05 09:54:15.348] (CLI)     ^~~~~

Thank

@kefahB that's from one of dependency


Interception CreatContext always returning 0?

I followed everything as said, but while loading I'm getting context as 0 as return value from CreateContext with interception. Please help me solve this.

i have this problem to, no any answer

In case someone has the same problem. Here's the answer.


Feature/annotate to file

Testing out https://github.com/DasSkelett/AVC-VersionFileValidator/tree/feature/annotate-to-file

No idea why GitHub annotates everything twice, but it works :man_shrugging:


Check for option to base releases on: qzed/linux-surface

Hello,
It's been a while since jakeday did any updates on his repo, qzed seems to have taken bigger part of the job on him and is releasing updates with newer kernel version.
Is it possible to base a release or upcoming releases on that one?
https://github.com/qzed/linux-surface/releases

Apparently the releases from qzed include packages that work on arch.


[Universal Steam Metadata]Not all games can be found even it is in steam store.

When searching the games, not all games are supported.
For example:
[Uncharted Waters IV HD] (https://store.steampowered.com/app/1424800/Uncharted_Waters_IV_HD_Version/)
Taiko Risshiden V DX

We use Steam's own store search, if those games don't show up in the results, it's an issue with Steam store itself.
https://store.steampowered.com/search/?term=Taiko Risshiden V DX&ignore_preferences=1&category1=998

We use Steam's own store search, if those games don't show up in the results, it's an issue with Steam store itself.
https://store.steampowered.com/search/?term=Taiko Risshiden V DX&ignore_preferences=1&category1=998

Thank you for getting back to me.  I found that this game is not available in the US/Canadian region but only in Asian Stores.  Is there a way to solve this?

There isn't, unless you want to use something like a VPN from a different region.


Update distribution readme for WildFly 10.0.0.Beta1

...including some awesome ascii art.

Windows Build 2277 is now running using a merge of 002c9d21822f8908c3ba806bd2b5c56c55dbcbe0

Linux with security manager Build 2093 is now running using a merge of 002c9d21822f8908c3ba806bd2b5c56c55dbcbe0

Linux Build 7223 is now running using a merge of 002c9d21822f8908c3ba806bd2b5c56c55dbcbe0

Linux Build 7223 outcome was FAILURE using a merge of 002c9d21822f8908c3ba806bd2b5c56c55dbcbe0
Summary: Tests passed: 726, ignored: 275; exit code 1 (new) Build time: 0:04:45
Build problems:
Process exited with code 1

Linux with security manager Build 2093 outcome was FAILURE using a merge of 002c9d21822f8908c3ba806bd2b5c56c55dbcbe0
Summary: Tests passed: 726, ignored: 275; exit code 1 (new) Build time: 0:04:46
Build problems:
Process exited with code 1

Windows Build 2277 outcome was FAILURE using a merge of 002c9d21822f8908c3ba806bd2b5c56c55dbcbe0
Summary: Tests passed: 738, ignored: 277; exit code 1 (new) Build time: 0:06:38
Build problems:
Process exited with code 1

Linux Build 7224 is now running using a merge of 002c9d21822f8908c3ba806bd2b5c56c55dbcbe0

Linux Build 7224 outcome was FAILURE using a merge of 002c9d21822f8908c3ba806bd2b5c56c55dbcbe0
Summary: Tests passed: 726, ignored: 275; exit code 1 Build time: 0:04:11
Build problems:
Process exited with code 1

The extension-jberet got merged with an incorrect version, retest this please.

Windows Build 2279 is now running using a merge of 002c9d21822f8908c3ba806bd2b5c56c55dbcbe0

Linux with security manager Build 2095 is now running using a merge of 002c9d21822f8908c3ba806bd2b5c56c55dbcbe0

Linux Build 7226 is now running using a merge of 002c9d21822f8908c3ba806bd2b5c56c55dbcbe0

Linux with security manager Build 2095 outcome was SUCCESS using a merge of 002c9d21822f8908c3ba806bd2b5c56c55dbcbe0
Summary: Tests passed: 897, ignored: 285 Build time: 0:07:15

Linux Build 7226 outcome was SUCCESS using a merge of 002c9d21822f8908c3ba806bd2b5c56c55dbcbe0
Summary: Tests passed: 2983, ignored: 358 Build time: 0:49:49

Windows Build 2279 outcome was SUCCESS using a merge of 002c9d21822f8908c3ba806bd2b5c56c55dbcbe0
Summary: Tests passed: 2981, ignored: 359, muted: 1 Build time: 0:51:43


Not working properly

When typing something, the words are not played when entered and the "Play in Soundpad" button stops working.

I have the same issue. This seems to be related to the recent SoundPad 3.3.0 update. I hope Medokin is able to fix this bug, although this tool seems to be somewhat graveyarded.

Duplicate of #15

@kingcailan It is not graveyarded 🤪 Just because I am not pumping features, does not mean that it is not maintained.

Understood! I tend to assume a project is dead or finished when noone shares bugs, and there are no commits. Sorry for the assumption!


Align the GOVERNANCE.md and CONTRIBUTING.md documents

The governance model has been approved with this follow-up task:

move the repository rules from the governance.md to the contributing.md document.

Originally posted by @TheNeikos in https://github.com/thin-edge/thin-edge.io/pull/1203#discussion_r955893433

I will do this in a PR after #1203 is merged.

Was closed automatically with the merge of #1379, but as @didier-wenzek said we shouldn't close this one until the CONTRIBUTING.md was rewritten because of duplicated stuff in there now.


[gettext-libintl] build failure

Operating system
Windows
Compiler
MSVC
Steps to reproduce the behavior
vcpkg install gettext-libintl

Failure logs

This pops up and blocks progress of building. I have had this happen on CI and eventually the build times out and fails.
Additional context
No response

I started getting this also -- If I click Retry or Ignore the port build continues normally and have not noticed in other side effects... but for the OP or anyone building on GitHub CI it is a show stopper as there is no way to respond to the message.

I have been troubleshooting to see if I could figure out the problem, my first step was creating a completely new/vanilla vcpkg instance and building port gettext-libintl but the same results.

https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/set-printf-count-output?view=msvc-170
Seems like _set_printf_count_output(1) should be called somewhere before building, maybe?

Or maybe patch with this, https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/crtsetreportmode?view=msvc-170

Actually, just tried with the latest vcpkg commit, and the issue seems to be gone...
fc3f61366102c1f0d4547c06d03c523bb18c13a7

Actually, just tried with the latest vcpkg commit, and the issue seems to be gone...
fc3f613

I take that back...running locally on the latest commit, I don't see this error anymore, however running the lastest commit on GitHub CI still has an infinite wait

Can you share the state of x64-windows-dbg/config.log at the time the window appears?

I guess this used to be addressed via
https://github.com/microsoft/vcpkg/pull/30429/files#diff-f615a394355e453bbaa9690a1cefd4315c055d94c41bbecfbb47dcd08173c61bL47
This line can restored in gettext-libintl and gettext. Do you feel able to try this locally?
(This conftest originally comes from gnulib. In the long term, it would be good to help them to adapt their code to the MSVC debug runtime.)

I guess this used to be addressed via https://github.com/microsoft/vcpkg/pull/30429/files#diff-f615a394355e453bbaa9690a1cefd4315c055d94c41bbecfbb47dcd08173c61bL47 This line can restored in gettext-libintl and gettext. Do you feel able to try this locally?

Can confirm restoring that line in gettext-libintl seems to build without issue.

Thanks!
gettext[tools] shouldn't be affected because it doesn't build a debug config.

@dg0yt  - do you still need the logs?
If so I can remove port gettext-libintl and the other ports I have installed and then run the install along with these additional runtime parameters --debug --debug-env --x-cmake-args=-DVCPKG_CMAKE_CONFIGURE_OPTIONS=--trace-expand and wait for the message to pop-up and capture all the logs created at that moment in the buildtrees/gettext-libintl before answering with retry so it will continue installing. I can then zip them all up and post back here?
Just let me know.
Thanks everyone for all the hard work.

gettext[tools] shouldn't be affected because it doesn't build a debug config.

Yeah, gettext[tools] never caused any issue for me.

No logs needed. The research and test by @nlogozzo gave me enough confidence for (restoring) the immediate fix.
What I can't do (due to lack of MSVC) is preparing a permanent fix for gnulib. They do have _set_invalid_parameter_handler for that test:
https://git.savannah.gnu.org/cgit/gnulib.git/tree/m4/printf.m4#n896
but IIUC this must be complemented by _CrtSetReportMode for building against the debug runtime.

I do not know one way or another - as I am still doing my C/C++ lessons, learning C/C++ is a very new direction for me, as most of my years in IT were - should I say it, COBOL, mainframes and distributed AIX/HP-UX servers.


MINOR: replace deprecated remove with delete

According to rocksDB commit history, it should be a pure renaming and no perf / correctness implications at all. But still good to remove deprecated API.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@vvcephei @mjsax