when i running the main_MFQ_Ising.py, then a error happen, that is  AttributeError: module 'gym.spaces' has no attribute 'MultiBinary'

who can help  me ?  thanks a lot.

@Brucewangxq check your gym with version == 0.9.2 or 0.9.4, it might not work with later version

ok，thank you


502 Bad Gateway

$ curl -L david-dm.org # follow redirects

<title>502 Bad Gateway</title>

502 Bad Gateway

nginx/1.4.6 (Ubuntu)

Thanks for reporting. The Node Security project renamed the repo where security advisories live and there was no null checking around the code that iterates over the data. This was fixed in https://github.com/alanshaw/david-www/commit/dae6680eddcf9da422800e4cb81a4095bc37be05 and the site is now back up.


Paginate LSIF references

This modifies the LSIF references provider to read subsequent pages if an endCursor is given in the first request. This will enable cross-repo LSIF results to be shown in the UI.

@chrismwendt Updated could you take another quick look?


call callback function on cancel

Correctly check if the callback function takes any arguments.
Function.prototype.length is supported even in IE6.
ps. I run gulp compress sass. There is some difference how sass was compiled. I guess you might use some packages in a different version than what is in package.json.

Great PR, thank you @coot!

https://github.com/limonte/sweetalert2/releases/tag/v0.2.9


rm read() from setup.py

It doesn't look the read() method is being used, unless maybe it is being imported by another module somewhere?

good catch ;-)


[PE-D][Tester A] Identification of different persons

It might be better to consider two persons with same name and telephone number be the same person.

Labels: type.FeatureFlaw severity.Low
original: YuZizhen/ped#9

Not a bug.


consider installing goodfirstissue app on project

Hi,
I was reading about ghost today, when I found out that ghost also has 'goodfirstissues' (from https://docs.ghost.org/concepts/contributing/) for helping new contributors.
I've developed a github bot goodfirstissue which tweets 'good first issues' via twitter handle @goodfirstissue.
the targeted audience for twitter account are first time contributors, and to encourage open source contributions.
I was hoping if you can install the app on Ghost repo (or even better if installed on TryGhost org). It needs only read access to public issues/metadata.
some open source projects like openfaas, kubernetes-helm, fastify are already using this bot to connect to first time contributors.
Some details:
Permissions this app need: read permission on issues and metadata.
Twitter Handle used to tweet: @goodfirstissue
Source code of the app/webhook: https://github.com/rajatjindal/goodfirstissue
Instructions to install github app: https://github.com/rajatjindal/goodfirstissue#how-to-install
Thank you for considering and thank you for your contributions to open source community.
Disclaimer: i am the author of goodfirstissue bot and I am relatively new to opensource community and looking to engage more with open source contributions myself too.
Thanks
Rajat Jindal

Hi Naz
Thanks for your feedback.
The github api that i am aware of allows only pull from github. I am not
aware if i can configure webhooks on repos that i am not owner of. Please
correct me if i am wrong here.
As you can imagine the pull operation wont scale very well and will be
limited by the github api rate limits therefore we went ahead with this
push operation where owner of repo can push “issues events” which involve
only public metadata.
I hope that clarifies, but i am happy to chat/learn more if you think there
is a better way to so it
On Thu, Jul 4, 2019 at 2:45 PM Naz Gargol<EMAIL_ADDRESS>wrote:

Hi @rajatjindal https://github.com/rajatjindal. We would definitely
like to get involved and the idea of helping new contributors find issues
to work on is great!
On the other hand, we would like to keep the amount of integration to the
minimum to avoid overcrowding. Just wondering why this type of checking for
'good first issues' was done through integration (which requires
action/work from the repository maintainer) instead of using public GitHub
API/Webhooks to get the same information?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/TryGhost/Ghost/issues/10868?email_source=notifications&email_token=AAEVN7B54ZD4HQPDNL6WL23P5W5SLA5CNFSM4H5D2V3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZG23NY#issuecomment-508407223,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEVN7DYFS2NI6KPGX6SSVLP5W5SLANCNFSM4H5D2V3A
.

--
Rajat Jindal |  Pune |  https://rajatjindal.com |<EMAIL_ADDRESS>

Hi @naz
a gentle reminder to review my response when you get chance.

@gargol ^ :stuck_out_tongue:

whoops. sorry about the wrong username tag

Hey @rajatjindal! Sorry gotten focused on new features and had this on a waiting list :stuck_out_tongue:
Regarding webhooks, I'm not up to speed with the permission details on them, but if that requires to be an owner then definitely a no go.
The reason why I'm asking about the "no work on our side approach", is that have seen similar concept done in https://24pullrequests.com/ with them collecting issues to triage over pre-Christmas time. And in your case, it's a 'continuous' way of collecting specifically tagged issues. Wondering if they had to integrate with every single repository or had some less intrusive way to tackle this problem?

Sorry when i said owner i meant a person who is authorized to make changes
to the repo OR org. It can be a collaborator or member.
The model of this bot is slightly different.
In 24pullrequests (from my brief reading) it seems they pull data for
projects and then store/cache and provide link to projects issues with
filters. ( this is a great project between)
The idea behind goodfirstissue bot was to give realtime notification of a
relevant issue to new comers. For popular repositories the new
goodfirstissue issue might get taken in matter of mins, and therefore the
real time notification via twitter can give opportunities to a new comer to
look for that issue as soon as its reported.
I can close this issue if you think its a no-go.
I really appreciate your time to review this with me and the suggestions
given. And ofcourse for your opensource contributions.
On Fri, Jul 12, 2019 at 1:54 PM Naz Gargol<EMAIL_ADDRESS>wrote:

Hey @rajatjindal https://github.com/rajatjindal! Sorry gotten focused
on new features and had this on a waiting list 😛
Regarding webhooks, I'm not up to speed with the permission details on
them, but if that requires to be an owner then definitely a no go.
The reason why I'm asking about the "no work on our side approach", is
that have seen similar concept done in https://24pullrequests.com/ with
them collecting issues to triage over pre-Christmas time. And in your case,
it's a 'continuous' way of collecting specifically tagged issues. Wondering
if they had to integrate with every single repository or had some less
intrusive way to tackle this problem?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/TryGhost/Ghost/issues/10868?email_source=notifications&email_token=AAEVN7HAO2EPXXKN6A2MPYLP7A5VVA5CNFSM4H5D2V3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZZCTUQ#issuecomment-510798290,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEVN7CDBTAK2CYN4QZZ5HTP7A5VVANCNFSM4H5D2V3A
.

--
Rajat Jindal |  Pune |  https://rajatjindal.com |<EMAIL_ADDRESS>

Hi @rajatjindal thanks for getting in touch, As you can see, we use the labels good first issue and help wanted to try to support the contributor community.
If you're able to leverage these labels to bring the issues to the attention of more people that's great, however we're not interested in installing any 3rd party apps to do this right now.


Don't send a client update if consensus state already exists

Summary
With the fix for #2087, because multiple batches perform client update at same height we see the following warnings:
2022-05-13T11:09:32.471130Z  WARN ThreadId(290) packet_cmd{src_chain=ibc-0 src_port=transfer src_channel=channel-1 dst_chain=ibc-1}:clear:schedule_recv_packet_and_timeout_msgs{h=Some(Height { revision: 0, height: 599 })}:schedule{odata=oHMVz0CGiB ->Destination @0-599; len=50}: [ibc-0 -> ibc-1:07-tendermint-1] resolving trusted height from the full list of consensus state heights for target height 0-600; this may take a while

Then things proceed and work is wasted for an updated that it is not needed.

Problem Definition

Proposal
Add a check in update client for client_latest_height == target_height  and make it a noop in this case.

Acceptance Criteria
The warning above is not seen and the client update is not issued if the chain already has the consensus state.

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate milestone (priority) applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

Done in https://github.com/informalsystems/hermes/pull/3555


[Feature]: add AwaitClientProvider

Package Scope
@suspensive/react-await
Description
Check the comment https://github.com/toss/suspensive/pull/1066#discussion_r1672283896
Possible Solution
No response
etc.
When the PR is merged, work begins

@SEOKKAMONI In my opinion, we should try to focus @suspensive/promise. Make it in @suspensive/promise please
or Could you share plan you want?

@SEOKKAMONI In my opinion, we should try to focus @suspensive/promise. Make it in @suspensive/promise please or Could you share plan you want?

I was thinking of developing an AwaitClientProvider, which I consider to be the minimum functionality required for existing users of @suspensive/react-await, and migrating it to @suspensive/promise. What do you think about this?

@SEOKKAMONI In my opinion, we should try to focus @suspensive/promise. Make it in @suspensive/promise please or Could you share plan you want?

I agree your opinion. Then, I will change the issue to add SuspensePromise, promiseOptions, and PromiseCacheProvider ...

Cool Let's move to make @suspensive/promise from version 0 to version 1


dict2inst should ensure type correctness

Godot version:
3.3.stable
OS/device including version:

Ubuntu 20.04, GLES3
Issue description:
When converting from json parsed dictionary to instance, dict2inst, does not keep the correct type. Since JSON always uses float, all int properties are set as float, even if using typed gdscript.
extends Spatial

enum Test {A, B, C}

var i: int = 1

func _ready():
	print_match(i)
	var another = dict2inst(parse_json(to_json(inst2dict(self))))
	print_match(another.i)

func print_match(value):
	match value:
		Test.A:
			print("A")
		Test.B:
			print("B")
		Test.C:
			print("C")
		_:
			print("None")

The above code should print "B" even after the parsing, but instead, it fails on second match pass:
B
None

As a workaround, I made the following function, to fix the deserialized object:
func fix_ints(obj: Object) -> void:
	for prop in obj.get_property_list():
		if prop.type == TYPE_INT:
			obj.set(prop.name, obj.get(prop.name) as int)

Steps to reproduce:

Open the project
Run the project
See results

Minimal reproduction project:
project.zip

There are no integers in JSON, there's no way to preserve this information.
If you want to keep exact type info, use ConfigFile instead of JSON.

Yes, I know this is because of how JSON works, but dict2inst show try to cast the type or at least, throw an error, because having an object with a property of TYPE_INT but with a float value, doesn't seems right.

Well in your example, there's no indication that another.i should be an int. It's whatever can be inferred from the JSON, it has no link to the member i which had been converted to JSON.

I have a PR which can solve the issue with JSON, see #33241, but for it to be merged it needs an approval from the core developers.

Well in your example, there's no indication that another.i should be an int. It's whatever can be inferred from the JSON, it has no link to the member i which had been converted to JSON.

Isn't dict2inst suppose to do this link? Since it converts a dictionary, which has a link to the script, to the object.
Anyways, I made a small change to the test script, using a subclass and casting the type:
extends Spatial

enum Test {A, B, C}

class Sub:
	var i: int = 1

func _ready():
	var sub := Sub.new()
	for info in sub.get_property_list():
		if info.name == "i":
			print(info)

	print_match(sub.i)
	var another = dict2inst(parse_json(to_json(inst2dict(sub)))) as Sub
	print_match(another.i)

	for info in another.get_property_list():
		if info.name == "i":
			print(info)

func print_match(value):
	match value:
		Test.A:
			print("A")
		Test.B:
			print("B")
		Test.C:
			print("C")
		_:
			print("None")

This prints the following:
{class_name:, hint:0, hint_string:, name:i, type:2, usage:8192}
B
None
{class_name:, hint:0, hint_string:, name:i, type:2, usage:8192}

So the dict2inst converts the dictionary to instance without problems, but it ends with a int property that has a float. For consistence, I think dict2inst should ensure the type when casting back.

Thanks, I understand the issue better now. The JSON number vs float/int issue is not the real issue, it's just a way to expose it, so let's simplify:
extends Spatial

class Sub:
	var i: int = 1

func _ready():
	var dict = { "@path":"res://Spatial.gd", "@subpath":"Sub", "i":42.0 }
	var inst = dict2inst(dict)
	print(inst is Sub)  # True
	print(typeof(inst.i) == TYPE_INT)  # False, expected is True

Since dict2inst does create an instance of the object defined by @path and @subpath, one could expect that it would either do type coercion or raise an error if the dict contains different types.
Instead, it silently assigns a float value to a member with int type hint.


Enabling via Application Insights through auto-instrumentation or SDKs "Node.js" link redirects to "Application Insights for ASP.NET Core applications" page

Clicking "Node.js" link under "Enabling via Application Insights through auto-instrumentation or SDKs" section

Redirects to "Application Insights for ASP.NET Core applications" page:

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1eef7c73-3c31-ca45-0e5e-cb5b970be268
Version Independent ID: c4da818c-6404-210e-0185-be5b095a80de
Content: Distributed Tracing in Azure Application Insights - Azure Monitor
Content Source: articles/azure-monitor/app/distributed-tracing.md
Service: azure-monitor
Sub-service: application-insights
GitHub Login: @nikmd23
Microsoft Alias: nimolnar

@MarioArriaga92 Thanks for your comment. We will review the issue and get back to you shortly.

@MarioArriaga92  Thanks for the feedback! I have fixed the referenced change, and the change should reflect on the doc within 24 hours. We will now proceed to close this thread. If there are further questions regarding this matter, please revert and we will gladly continue the discussion.


It is not working for data that is dynamically loaded through Ajax

How should i use the plugin for data that is dynamically loaded through ajax. Currently i am calling  $('article').readmore() function whenever the data is loaded through ajax, but this is removing the readmore functionality on other elements that are already loaded. Please help

Depends on how you are loading that new content. I'd have to see your code. Please post your code or a link to your page.

Just stumbled upon the same issue, in the destroy method calling current.removeData('plugin_' + readmore); instead of current.removeData(); fixes this issue.
Else somehow the plugin just gives up on reinitializing the elements with readmore data already on them.


Update README example to match #214 changes

As shown in examples/basic.rs, bincode::Infinite isn't used anymore.

Good catch, thanks!


Interpolating arcs can lead to error messages

A path element's "d" attribute for an arc (such as those created with d3.arc) contain "A" commands ("elliptical arc curve commands"). They have five parameters, two of which are flags which can only be 0 or 1.
Unfortunately, some transitions can lead to these flags being linearly interpolated, leading to values such as 0.12345. At least in Chrome, this causes error messages. Here is an example:
http://codepen.io/anon/pen/qRrgLe
(You will need to open the console to see the error messages.)
Is there a chance to have these flags only assume the values 0 or 1 during a transition?

This is the expected behavior of transition.attr, which uses d3.interpolateString to interpolate strings, and has no understanding of SVG path data. If you want to use a path-aware interpolator, you should use transition.attrTween instead, and supply a different interpolator. A convenient technique is to use a piecewise linear curve (a polyline) as the intermediate representation to allow smooth transitions between arbitrary shapes; see https://bl.ocks.org/mbostock/3916621 for an example.

Thanks for the explanation, this makes sense. What I ended up doing is use d3.interpolateString but override its result by rounding the 4th and 5th parameter in "A" (arc) commands:
transition.attrTween("d",function() {
  var basic = d3.interpolateString(d3.select(this).attr("d"),targetArc);
  return function(t) {
    return basic(t).replace(/A[^A-Z]+/g,function(match) {
      return "A" + match.substr(1).split(/[, ]+/).map(function(value,index) {
        return index == 3 || index == 4 ? String(Math.round(parseFloat(value))) : value;
      }).join(",");
    });
  };
})

This gets rid of the error messages when interpolating arcs (e.g. in pie charts).

here is the live demo https://observablehq.com/@d3/path-tween


[FEATURE REQUEST] Add basic HDFS storage option for catalogs

Is your feature request related to a problem? Please describe.
Currently it appears that the storage options are geared towards cloud providers. To support companies running on premise I would like to request HDFS support.
Describe the solution you'd like
Catalog R/W support HDFS as a storage option.
For the first implementation we would like something basic:

The service is able to R/W against a HDFS cluster without authentication/authorization required.

We can add HDFS support, but handling credentials might be difficult. @sfc-gh-schen, can you provide more insight? I think it may not be possible for credential vending.

Would permissive HDFS be a simpler first ask with potential evolutions in the future to support credentials? Aka start off assuming that the HDFS cluster is open (no Kerberos, etc), running on-premise protected by networking, and then consider a proper strategy in the future?
Sorry if I'm off the mark on what you meant by your last comment but I assumed it's relating to authn/authz against HDFS (and not mapping to an internal strategy in Polaris).

Yup, it's reasonable to start with non-authentication and non-authorization for HDFS.

I don't mind trying my hand at this for the simple case and provide a baseline for people to extend in the future.
I think in order for this to work, due to the DFS is created inside of Iceberg core with the Hadoop configuration object we initialize, we'll need to rely on the HADOOP_USER_NAME environment variable (which will mean all DFS interaction would be under the same username). Otherwise it'll default access to be the user running the service.
I can see if I find time one of these days to throw something together in a PR (as an non-tested PoC) just to get feedback on if it's something we want to move forward

@flyrain QQ about the repo which I noticed starting to write the changes required by this MR:

Do the regtests have Open API Python templates that aren't commit into the repo? When I generate the files with the provided commands in the README it results in generated Python files without the license header and in some cases it breaks the functionality. An example diff of regtests/client/python/polaris/management/models/aws_storage_config_info.py:

         _obj = cls.model_validate({
             "storageType": obj.get("storageType"),
-            "allowedLocations": obj.get("allowedLocations"),
-            "roleArn": obj.get("roleArn")
+            "allowedLocations": obj.get("allowedLocations")
         })

I was thinking about how to add integration / e2e tests and noticed that there isn't really any integration tests (outside of polaris-service/src/test/java/io/polaris/service/catalog/PolarisSparkIntegrationTest.java), do we rely on the e2e tests for testing against the storage providers? -- Curious to what your preference would be for this repo

cc @dennishuo @collado-mike @eric-maynard for the first question.
for 2, we cannot really do that without a sponsor of cloud environments. We have discussed using minIO to simulate it. But for HDFS, it should be OK to add integration tests.


Yes sir.

It works great. Just pay attention to the small text box since that will become the commit message.


Duplicate entry for key

I'm using gorm and I wonder how can i get the error when i use the c.Save()?
I'm using gorm for my golang project. The underlying database is mysql, besides the gorm framework, I added a unique index for two column with the below statement manually in mysql prompt:
CREATE UNIQUE INDEX unique_name ON users(name, account_type)

and then, I use the c.Save(user) for the new record. however, when i insert two record with same name and account_type, but I cann't get it because no error is returned by Save method of DB.
thanks in advance!

I got it, it can be caught with
MyDB.Save(record).GetErrors()

@asxalex It's lighter to check with .Error() to see if any errors occurred. If multiple errors are thrown, you might not always care and it will essentially cost overall more resources if you always ask to get all errors. Just my 2 cents :)

@Allendar aha, got it, thanks a lot!


unhandledRejection: ReferenceError: document is not defined

Thanks for filling out this bug report. Please provide as much detail as possible.
If your issue is with our RPC APIs and not the SDK please report your issue on (discord)[https://alchemy.com/discord].
[REQUIRED] Environment

Browser version:
AA SDK version: 3.11.1
Package:  alchemy/aa-alchemy

[REQUIRED] Describe the problem
Getting error when doing build for my nextjs project.
⨯ unhandledRejection: ReferenceError: document is not defined
at createSigner (webpack-internal:///(ssr)/./node_modules/@alchemy/aa-alchemy/dist/esm/config/store/client.js:43:27)
How to reproduce:
Relevant code or sample repro:

Also getting this error:
⨯<EMAIL_ADDRESS>(6:14) @ getAccount
⨯ ClientOnlyPropertyError: account is only available on the client

this looks related to https://github.com/alchemyplatform/aa-sdk/issues/648, it should be fixed now


Renamed public protocol 'View' to 'ReactorView'

It was clashing with SwiftUI's public protocol named 'View'.
SwiftUI's public protocol: https://developer.apple.com/documentation/swiftui/view
Motivation:
It was discovered that views on UIKit can be previewed on real time without building the project every time same as in projects which are built on SwiftUI.
However, current version of ReactorKit has the same named public protocol for the UIViewControllers to inherit Reactor automatically.
I renamed the protocol from 'View' to 'ReactorView', which should solve the issue.

#204

There is one problem.
It is necessary to migrate all View's in all places of the previously used project.
That's why I'm worried...

There is one problem.
It is necessary to migrate all View's in all places of the previously used project.
That's why I'm worried...

Oh that is so true!
Hmm, let me think about work around this issue then, and get back with possible solutions here!


Can't launch iOS simulator with WebStorm IDE

[*] Review the documentation: https://facebook.github.io/react-native
[*] Search for existing issues: https://github.com/facebook/react-native/issues
[*] Use the latest React Native release: https://github.com/facebook/react-native/releases

Environment
React Native Environment Info:
System:
OS: macOS 10.14
CPU: x64 Intel(R) Core(TM) i5-7360U CPU @ 2.30GHz
Memory: 93.62 MB / 8.00 GB
Shell: 5.3 - /bin/zsh
Binaries:
Node: 10.6.0 - /usr/local/bin/node
npm: 6.4.1 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 12.0, macOS 10.14, tvOS 12.0, watchOS 5.0
IDEs:
Android Studio: 3.2 AI-181.55<IP_ADDRESS>56338
Xcode: 10.0/10A255 - /usr/bin/xcodebuild
npmPackages:
react: ^16.6.0-alpha.8af6728 => 16.6.0-alpha.8af6728
react-native: ^0.57.4 => 0.57.4
npmGlobalPackages:
react-native-cli: 2.0.1
Description
WebStorm could launch Metro Bundler and iOS simulator correctly In React Native version 0.56.
But in the 0.57 version with the same configuration, development environment and softwares, it can't launch iOS simulator. (Metro Bundler is correctly launched.)
I have no idea about this issue. Please how to fix this problem?

Same problem here:
React Native Environment Info:
System:
OS: macOS High Sierra 10.13.6
CPU: x64 Intel(R) Core(TM) i5-5287U CPU @ 2.90GHz
Memory: 4.37 GB / 16.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 10.2.1 - /usr/local/bin/node
Yarn: 1.10.1 - /usr/local/bin/yarn
npm: 5.6.0 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 12.0, macOS 10.14, tvOS 12.0, watchOS 5.0
Android SDK:
Build Tools: 23.0.1, 25.0.2, 26.0.2, 27.0.3, 28.0.3
API Levels: 23, 26, 27, 28
IDEs:
Xcode: 10.0/10A255 - /usr/bin/xcodebuild
npmPackages:
react: 16.5.0 => 16.5.0
react-native: 0.57.2 => 0.57.2
npmGlobalPackages:
react-native-cli: 2.0.1
svg-to-react-native-cli: 0.0.3

so... what should i do ?

Same issue, WebStorm starts the metro bundler but does not execute the run-ios command in parallel

With RN 0.56.x it's working like a charm.
Workaround for 0.57.x: remove "Start React Native Bundler" from before launch section in the configuration editor and start RNB manual in a Terminal window.

I am going to guess the issue in here is the introduction of the react native metro bundler as opposed of what was used before that.
I imagine this is an issue that needs to be raised with jetbrains as opposed to facebook.

Unfortunately it is not the reason, RN 0.56 already had the metro bundler...

The newest EAP version of WebStrom is working well.
https://youtrack.jetbrains.com/issue/WEB-34895

@imrepapp Indeed, fixed on WS 2018.3 EAP Build 183.3975.16 with React Native 0.57.4 👍

@imrepapp Indeed, fixed on WS 2018.3 EAP Build 183.3975.16 with React Native 0.57.4 👍

I have updated to the latest versions of React Native (v0.57.4) and WebStorm (2018.2.5).
But still can't start normally, so I guess the real thing should be WebStorm 2018.3.
I am full of expectations for WebStorm 2018.3.

If this issue is not related to react native, it should be closed as the facebook team will have little to do here. Instead, this feedback should be directed to jetbrains so they can fix the environment.

If this issue is not related to react native, it should be closed as the facebook team will have little to do here. Instead, this feedback should be directed to jetbrains so they can fix the environment.

However, 0.56 and 0.57 have different results in the same WebStorm environment.
I don’t know why.

it works well with WebStorm 2018.3.


Use cached thread-pool instead of unbounded pool

Using Executors.newFixedThreadPool will start off with 30 threads, but will create new threads in an unbounded fashion. Instead, using the cachedThreadPool this behavior will find a steady-state.
Signed-off-by: David Fuelling<EMAIL_ADDRESS>

https://www.baeldung.com/java-executors-cached-fixed-threadpool

The cached pool starts with zero threads and can potentially grow to have Integer.MAX_VALUE threads.

Closing this PR due to me not thinking.


Export not working on some devices (missing External Storage)

Some devices, such as the Samsung Galaxy S7 (Global) running latest stock Android 7.0, will refuse to export to "External Storage" when one is not available (only internal storage, which should serve the same purpose in this case). Even when trying to export via "Send as", the operation will fail for the same reason.

Affecting all Android 6, 7 and 8 devices.


Fix overlapping transparent placeholder avatars in message reactions

The Avatar component uses semi-transparent rgba background colors. This works fine against opaque backgrounds, but not with overlapping message reactions.

This can be addressed as part of the broader reactions changeset proposed by @covrter .


Double check coding.

There was some discussion on the mage discord that Sextant of Unstable Currents was simming higher then it should in aoe conditions especially when aoe capped. Can you please double check that the proc is is coded as the right stat. There was some speculation that it was proccing crit and not spell power.
Also the 2% damage from improved sanc aura sims higher than the 3% damage from Ferocious Inspiration which shouldn't be the case unless the math for the 2 is applied at different levels. Idk for sure but something to double check and make sure it is correct.

lmao yeah it was adding crit
probably sloppy reading from me when I added the first 20 trinkets


Use Rails caching on views and api responses

see also https://github.com/QutBioacoustics/baw-server/issues/144
raised due to slow generation time when using api on visualise page
mainly thinking about Rails 4 low-level caching

more explaination: How key-based cache expiration works

See also #161

Also look at gzipping in rails and apache.

See also #144

Also relevant to global stats page


Lost all unstaged work!!

Issue Type: Bug
I had made a number of changes to various files. I went to commit as always, and I noticed that the "current branch" was a hex string, not the name of a branch as usual. I couldn't find any branch id that it referred to. When I went to make the commit, it said I couldn't make a commit because I hadn't checked out a branch. When I checked out the branch I thought I was already on, I lost all my work!!
I checked all my stashes. I checked all my other branches. I see nothing at all because I never got to make a commit.
Then on a whim I decided to try hitting "undo" on each file I had made changes on—even though they already show as "saved" and thus have no changes to revert—and lo and behold, I got my work back!!
I don't know how to reproduce this, but this seems like a potentially serious bug, so I hope it's helpful somehow...
VS Code version: Code 1.40.1 (8795a9889db74563ddd43eb0a897a2384129a619, 2019-11-13T16:47:44.719Z)
OS version: Darwin x64 18.7.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-4260U CPU @ 1.40GHz (4 x 1400)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_offsurface_control: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
3, 3, 3

Memory (System)
4.00GB (0.07GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (1)

Extension
Author (truncated)
Version

debugger-for-chrome
msj
4.12.1

Great that you have "recovered" your work. It seems like you never lost it at all.

Something doesn't fit right in the story. First you mention:

When I checked out the branch I thought I was already on, I lost all my work!!

Which means that the files are no longer listed in the Git view... but then:

Then on a whim I decided to try hitting "undo" on each file I had made changes on

How is that possible?
How did you do this, if the files weren't listed in the view?

I'm not sure why you're being so condescending. For all intents and purposes, VSCode indicated that the code was lost. It was only by chance that I discovered that "undo" would have any effect, even though the files were displaying as saved and unedited, in which state "undo" would normally not do anything.

This is what happened:
a) I went to make a commit as usual. I noticed that the lower-left branch name displayed a hex string of about 10 digits with an asterisk instead of the normal branch name that has always been there. I had never seen this happen before and I'm not sure what put it into this state.
b) Upon attempting to commit, I received an error message that said something like "You cannot commit because no branch has been selected." I thought that was pretty bizarre, as I did of course have all my files checked out and I was editing them.
c) Because I figured there was no way I could accidentally lose any work, I clicked on the branch name and checked out the branch I thought I was on. At this point, all my changes disappeared, and the files appear unedited (which is what happens normally when you check out a branch, except that normally git would require me to stash existing changes).
I don't know how to replicate it, unfortunately, and I understand that this is not actionable. But jesus, I figured someone might at least want to know this happened. If you don't want to believe me, I guess that's your prerogative.

Apologies if I came out wrong. I'm trying to be concise and ask the right questions. I do believe you, but I also have to get the facts straight, in order to understand where the issue happened.

At this point, all my changes disappeared, and the files appear unedited (which is what happens normally when you check out a branch, except that normally git would require me to stash existing changes).

Is it possible that your changes were all in untracked files which are simply ignored by .gitignore in the branch to which you checked out?

How did you click "undo" on each file if all the changes disappeared

I'm not exactly sure what you mean. I mean this is part of the strange behavior. I had made changes to the file. Saved. Tried to commit. Forced to checkout a branch (that I thought was already checked out). Changes were wiped and files reverted to the last commit in that branch (which is what normally happens when you check out a branch, except normally git doesn't let you toss changes without explicitly forcing it).
The file editors at that point looked like normal files that didn't have any unsaved changes. I hit "undo" anyway. Maybe that itself is a bug. And undo brought my changes back somehow.

untracked files which are simply ignored by .gitignore

No, these are all files I've successfully committed many many times, and have since as well.
Very strange :( I wish I could offer something more. I think the heart of the problem was that somehow I got into this strange state where either git or VSCode thought I didn't have a branch checked out. Where normally it says the branch name in the bottom left, it just had a hash that didn't correspond to any commits or branches (that I know of).
Anyway—I don't think there's any more information I can provide, but on the off chance this happens again to someone, maybe we'll at least know it wasn't an isolated incident? :/

I mean that there isn't any undo button to click, if the files do not appear in the SCM view. Do you maybe mean the simple editor undo, as in Ctrl Z?

Very strange :( I wish I could offer something more. I think the heart of the problem was that somehow I got into this strange state where either git or VSCode thought I didn't have a branch checked out. Where normally it says the branch name in the bottom left, it just had a hash that didn't correspond to any commits or branches (that I know of).

Yes, this is called detached mode in git. You can get to it simply by checking out a commit directly instead of a branch. For example git checkout HEAD~.

Anyway—I don't think there's any more information I can provide, but on the off chance this happens again to someone, maybe we'll at least know it wasn't an isolated incident? :/

I'll definitely keep it in mind! :+1:

Do you maybe mean the simple editor undo, as in Ctrl Z

Ah, yes, that's what I meant. There were no files in the SCM view at all.

Ah that explains my confusion, sorry about that! Let me know if you do manage to reproduce the issue. Thanks for the input!


simplify: Separate attribute quadrics on attribute discontinuities

Initial implementation of attribute metric used the same indexing that
we use for positional quadrics, where multiple vertices with the same
position are collapsed into a single element. This is correct and
optimal for positions, but results in problems for attributes when the
vertex is on a seam: two associated vertices carry very different
attributes, and evaluating any attribute against a vertex from an
opposite side of the seam results in a large error. This results in a
suboptimal collapse sequence and an artificially inflated resulting
error.
This change fixes this by preserving the original indexing for attribute
quadrics and carefully aggregating these during collapses. For simplicity,
and because it does not seem crucial for quality, we still approximate
an error for one edge collapse using only one side of the seam (this
distinction only matters for seam-seam edges).
Also includes improved complex vertex handling and much more detailed
trace logging which is helpful for debugging unit tests or very small
reproducers.
Contributes to #158.
This contribution is sponsored by Valve.

As an example for why this can be valuable, with a sufficiently high normal weight on seams along the cylinder caps previously we would commonly constrain the movement of the vertices both along the seam and towards the seam because of the normal quadrics from different faces (pointing up and pointing sideways) blending together. Visible on this model: https://sketchfab.com/3d-models/ruby-rose-2270ee59d38e409491a76451f6c6ef80
where before this change the simplifier would try hard to keep these at their original tessellation, which would penalize the rest of the mesh:

and with this change these (small) parts of the mesh are more aggressively simplified, which improves quality in other mesh areas that are more prominent

Additionally, I've done very limited testing on this but before this change, feeding texture coordinates as attributes to the simplifier would be fairly counter-productive because it would penalize the UV seams way too much when UV shells are far away from each other, making the weights effectively impossible to tune well; with this it is probably more reasonable to give simplifier access to UVs with a small weight in hopes that it will somewhat improve the texture distortion.


Azure Key Vault-backed secret scope where AKV uses RBAC roles

"Create an Azure Key Vault-backed secret scope using the UI" steps listed on this page only work if the AKV is configured to use Access Policies to manage authorisation. If the AKV uses RBAC then an additional step of assigning the "Key Vault Secret User" role to the AzureDatabricks enterprise app needs to be performed otherwise users will not be able to list secrets via Databricks CLI.
Refer to the content in this Microsoft QandA discussion,, some of this content probably should be added to this page.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 810a218a-80a5-2da0-b540-26347f9ef908
Version Independent ID: 41c2a12f-99b6-0faa-500b-3e4308cd00de
Content: Secret scopes - Azure Databricks
Content Source: databricks/security/secrets/secret-scopes.md
Service: azure-databricks
GitHub Login: @mssaperla
Microsoft Alias: saperla

@pnarsi Thanks for the feedback! I have assigned the issue to the content author to evaluate and add the details on how to connect using RBAC role in the document.

Thanks for your dedication to our documentation. Unfortunately, we have been unable to review your issue and apologize for the delayed response. The requested updates have not yet been made. The timeline for resolution varies based on resourcing. We've created an internal work item (DOC-7063) to incorporate your suggestions. We are closing this issue for now, but feel free to comment here as necessary.
#please-close


fix: dynamodb optional json use

After merging https://github.com/winglang/wing/pull/6839
everything is passing:

https://github.com/winglang/winglibs/blob/48044f0a1f00e03218691dc017eecf513078a902/dynamodb/package.json#L3
@eladcon here?


Rework of interface description requested

Up to now I concentrated on the maintenance of the main component description. But also the interface description needs to be reworked (wording, layout, alignment with main component description). But to do this makes sense only after all planned changes in the code are done.

Hello Thomas,
Could you please plan this documentation ticket for further release?
Thank you,
Son

Hi Thomas,
you can assign this task to me also.

Hi Holger,
transferred to you.
Thank you,
Thomas

Done with
https://github.com/test-fullautomation/python-jsonpreprocessor/pull/218


[js - template - tests] Pipeline failure - min-max job

js - template - tests nightly pipeline fails at the min-max job

Update: All the tests are affected, not just template


[refarch/osp-cli] DOMAIN setup variable duplicates/conflicts with other DNS related vars

The variables that define the host naming internally and externally sometimes duplicate or conflict.
DOMAIN can duplicate with OCP3_DNS_PREFIX among others.
Clean up input variables and de-duplicate.

DOMAIN and OCP3_BASE_DOMAIN use are unclear and confusing.  The control net name should be derived from the base domain.
IE DOMAIN=control.${OCP3_BASE_DOMAIN}
Possibly rename DOMAIN as well.


event binder generator does not use canonicalname for implements type.

Not using full canonical name for implements type will cause issues if the binding code is in different package than the bound code.

 Binding a class in a different package should work fine under normal circumstances - there's a test at https://github.com/google/gwteventbinder/blob/master/eventbinder/src/test/java/com/google/web/bindery/event/shared/binder/EventBinderTest.java#L133 that confirms this.
The line you're pointing to is where the generated code implements EventBinder. A couple lines down we add EventBinder as an import, so AFAICT this should work fine without having to fully-qualify the name there.

Hrmmm I can't seem to enable strict mode with the gwt maven plugin the project is using.
When I run "mvn clean test" in sub-project "eventbinder" I am getting:
Validating units:
Ignored 3 units with compilation errors in first pass.
Compile with -strict or with -logLevel set to TRACE or DEBUG to see all errors.
Should not this cause a test failure?
I'll create a new gradle project and  see if I can reproduce what I was seeing.

Ok, please see:
https://github.com/mjoyner-vbservices-net/eventbinder-magali/tree/master/eventbinder-magali
A copy of the error output:
gradle clean compileGwt
:clean
:compileJava
:processResources UP-TO-DATE
:compileGwt
Compiling module test.Test
   Adding '1' new generated units
      Tracing compile failure path for type 'test.shared.BindsEvents_MyEventBinderImpl'
         [ERROR] Errors in '/home/mjoyner/git/eventbinder-magali/eventbinder-magali/build/gwt/gen/test/shared/BindsEvents_MyEventBinderImpl.java'
            [ERROR] Line 11: HandlesEvents cannot be resolved to a type
            [ERROR] Line 11: The type BindsEvents_MyEventBinderImpl must implement the inherited abstract method AbstractEventBinder<HandlesEvents>.doBindEventHandlers(HandlesEvents, EventBus)
            [ERROR] Line 11: The interface EventBinder cannot be implemented more than once with different arguments: EventBinder<HandlesEvents> and EventBinder<HandlesEvents>
      See snapshot: /tmp/test.shared.BindsEvents_MyEventBinderImpl4096437061114992414.java
   [ERROR] Errors in '/home/mjoyner/git/eventbinder-magali/eventbinder-magali/build/gwt/gen/test/shared/BindsEvents_MyEventBinderImpl.java'
      [ERROR] Line 11: The interface EventBinder cannot be implemented more than once with different arguments: EventBinder<HandlesEvents> and EventBinder<HandlesEvents>
      [ERROR] Line 11: The type BindsEvents_MyEventBinderImpl must implement the inherited abstract method AbstractEventBinder<HandlesEvents>.doBindEventHandlers(HandlesEvents, EventBus)
      [ERROR] Line 11: HandlesEvents cannot be resolved to a type
      See snapshot: /tmp/test.shared.BindsEvents_MyEventBinderImpl2504917617312099534.java
   Tracing compile failure path for type 'test.shared.BindsEvents_MyEventBinderImpl'
      [ERROR] Errors in '/home/mjoyner/git/eventbinder-magali/eventbinder-magali/build/gwt/gen/test/shared/BindsEvents_MyEventBinderImpl.java'
         [ERROR] Line 11: HandlesEvents cannot be resolved to a type
         [ERROR] Line 11: The type BindsEvents_MyEventBinderImpl must implement the inherited abstract method AbstractEventBinder<HandlesEvents>.doBindEventHandlers(HandlesEvents, EventBus)
         [ERROR] Line 11: The interface EventBinder cannot be implemented more than once with different arguments: EventBinder<HandlesEvents> and EventBinder<HandlesEvents>
   [ERROR] Hint: Check that the type name 'test.shared.BindsEvents_MyEventBinderImpl' is really what you meant
   [ERROR] Hint: Check that your classpath includes all required source roots
   [ERROR] Errors in 'test/shared/BindsEvents.java'
      [ERROR] Line 12: Rebind result 'test.shared.BindsEvents_MyEventBinderImpl' could not be found
   [ERROR] Errors in 'test/client/HandlesEvents.java'
      [ERROR] Line 11: Rebind result 'test.shared.BindsEvents_MyEventBinderImpl' could not be found
:compileGwt FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileGwt'.
> Process 'command '/usr/lib/jvm/java-8-openjdk-amd64/bin/java'' finished with non-zero exit value 1

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 25.244 secs

The relevant error is:
[ERROR] Line 11: HandlesEvents cannot be resolved to a type
```
"HandlesEvents" is not in the package the generated file is in. It is in a different package.

Looks like a dupe of #28 then; already fixed in master but there hasn't been a release since then.

Confirmed. I just compile against 1.1.1-SNAPSHOT and it seems happy.


Feature: list contextProperties of Logger

Make _contextProperties public on the Logger object.
Discussion: read-only or mutable?
asked here: https://stackoverflow.com/questions/56278360/nlog-list-property-values

Discussion: read-only or mutable?

I vote for readonly using IReadOnlyDictionary (Only have the property on platforms where interface is supported).

I checked the code. I think IDictionary is flexible enough. If we need to know changes in the dictionary, we could implement this.

Doesn't make sense. You can modify using the IDictionary-interface. It is way too flexible. You will get Collection was modified-exceptions

Do we need also a clone then? (I think so)

Do we need also a clone then? (I think so)

Would be very confusing to get a mutable dictionary returned, and your changes doesn't have any effect.
I continue to vote for IReadOnlyDictionary

That's clear ;)
But besides IReadOnlyDictionary we need a clone then. Otherwise your could cast it back. Unfortunately, you could always change and object living in the dictionary

Trying to protect yourself from a developer is hard work, and seldom gives any bonus.
Developer can also do reflection and access the dictionary that way.
The goal is to provide an easy to understand interface.

fixed by #3430


Permission denied when collecting docker.container.open_fds

Describe what happened:
Agent is configured with a simple container monitoring config:
---
instances:
- url: unix://var/run/docker.sock
logs:
- type: docker
  service: docker
  source: docker

init_config:

Logs are full of lines like:
2020-02-17 15:16:42 UTC | CORE | WARN | (pkg/collector/corechecks/containers/docker.go:272 in Run) | Failed to get file desc length for pid 29853, container cd4410ca734e: open /proc/29853/fd: permission denied
2020-02-17 15:16:42 UTC | CORE | WARN | (pkg/collector/corechecks/containers/docker.go:272 in Run) | Failed to get file desc length for pid 30028, container cd4410ca734e: open /proc/30028/fd: permission denied

Those path in /proc can not be read by the agent due to their permissions:
# ls -ld /proc/30028/fd
dr-x------ 2 messagebus ssh 0 Feb 17 08:01 /proc/30028/fd

Describe what you expected:
Datadog does not generate hundred of lines like this.
It could either:

not collect this metric if it can not access /proc/*/fd
not log one line each time it fails
provide a way to disable this metric collection
use something similar to try_sudo from the process check, which has the exact same issue

Steps to reproduce the issue:
Setup Docker monitoring on a Debian system, launch some containers.
Additional environment details (Operating System, Cloud provider, etc):
Debian 10.2
Docker version 19.03.5, build 633a0ea838
Agent 7.16.1 - Commit: 02e0969 - Serialization version: 4.15.0 - Go version: go1.12.9

Hi, this has been happening to us as well after enabling docker containers monitoring.
docker.yaml config:
init_config:
instances:
  -
    collect_container_size: true
    collect_disk_stats: true
    collect_exit_codes: true

Additional environment details (Operating System, Cloud provider, etc):
Amazon Linux AMI release 2018.03 4.14.165-103.209.amzn1.x86_64
Agent 7.17.0 - Commit: 6eb25b4 - Serialization version: 4.19.0 - Go version: go1.12.9
Docker version: 18.09.9-ce
Adding dd-agent to the list of sudoers as suggested for the process integration hasn't fixed the issue.

Adding dd-agent to the list of sudoers as suggested for the process integration hasn't fixed the issue.

This is normal as the Docker check does not support the sudo find-based method that the process check supports:
https://github.com/DataDog/datadog-agent/blob/642b251f9f7bccd03c76352fec3b7eb07f606c18/pkg/collector/corechecks/containers/docker.go#L273
Which calls:
https://github.com/DataDog/datadog-agent/blob/642b251f9f7bccd03c76352fec3b7eb07f606c18/pkg/util/containers/metrics/proc.go#L21-L34

Running into this as well
docker.d/conf.yml
init_config: null
instances:
-   collect_events: true
    collect_exit_codes: true
    collect_disk_stats: false
    collect_container_size: false

datadog.yml
config_providers:
-   name: docker
    polling: true
listeners:
-   name: docker

2020-03-30 21:10:53 UTC | CORE | WARN | (pkg/collector/corechecks/containers/docker.go:275 in Run) | Failed to get file desc length for pid 10528, container f04adeaeb836: open /proc/10528/fd: permission denied
2020-03-30 21:10:53 UTC | CORE | WARN | (pkg/collector/corechecks/containers/docker.go:275 in Run) | Failed to get file desc length for pid 10591, container f04adeaeb836: open /proc/10591/fd: permission denied
2020-03-30 21:10:53 UTC | CORE | WARN | (pkg/collector/corechecks/containers/docker.go:275 in Run) | Failed to get file desc length for pid 9752, container 4b5c5f763bb5: open /proc/9752/fd: permission denied

Can't seem to find a way to disable it either, kind of a nightmare for the journal

Hi,
Thank you for bringing this to our attention!
Indeed, these errors shouldn't be logged as warnings see https://github.com/DataDog/datadog-agent/pull/5350
Hopefully the fix will be included in Agent 7.20.
Thanks!

closing this issue as https://github.com/DataDog/datadog-agent/pull/5350 is merged and will be in Agent 7.20


Should swifter return content-length when using shareFilesFromDirectory to share files?

Lately, I've been using swifter on an iOS app to create a local http server for installing apps that is signed with enterprise certificate within app. (Here's the demo)
server.listenAddressIPv4 = "<IP_ADDRESS>"
server["/:path"] = shareFilesFromDirectory(downloadFilePath)
try server.start(8090, forceIPv4: true)

Everything's fine by using the code pasted above, until i try to install an app which size is over 1 gigabyte.
In this circumstance, iOS will stuck like 40 sec before it starts to download file that is shared by swifter.
After some dig in, i found that iOS require header content-length from http response to start download immediately.
Then i change shareFilesFromDirectory like this (just for test)
public func shareFilesFromDirectory(_ directoryPath: String, defaults: [String] = ["index.html", "default.html"]) -> ((HttpRequest) -> HttpResponse) {
    return { r in
        guard let fileRelativePath = r.params.first else {
            return .notFound
        }
        if fileRelativePath.value.isEmpty {
            for path in defaults {
                if let file = try? (directoryPath + String.pathSeparator + path).openForReading() {
                    return .raw(200, "OK", [:], { writer in
                        try? writer.write(file)
                        file.close()
                    })
                }
            }
        }
        if let file = try? (directoryPath + String.pathSeparator + fileRelativePath.value).openForReading() {
            let mimeType = fileRelativePath.value.mimeType();

            let filePath = directoryPath + String.pathSeparator + fileRelativePath.value
            var fileSize : UInt64 = 0

            let attr = try FileManager.default.attributesOfItem(atPath: filePath)
            fileSize = attr[FileAttributeKey.size] as! UInt64

            let dict = attr as NSDictionary
            fileSize = dict.fileSize()

            return .raw(200, "OK", ["Content-Type": mimeType, "Content-Length": String(fileSize)], { writer in
                try? writer.write(file)
                file.close()
            })
        }
        return .notFound
    }
}

Returning Content-Length solve my problem.
So i wonder shall swifter return content-length when using shareFilesFromDirectory to share files?

Hey, @nichbar Thanks for reporting this issue! It makes sense, did you want to create a PR with it? I'll be happy to review it

Sure, i will create a PR asap.


Refactor search functions and filtered search functions

I have merged the search functions and filtered search functions into a single function by adding a search type parameter to specify the type of field to be searched. I made the necessary adjustments in the test files for these refactored functions.
I ran manuel and pytest tests.

really cool thanks for the PR!
Honestly I don't think I can merge this in it's current state since it will break the implementation for everyone else (by removing search by title / search by author). I wish I'd written the code like this originally! But it was ages ago now... oh well 😅
If you want to get this merged, maybe we could add the search() method without removing the existing ones. Then we could also keep your refactor to SearchRequest.

Thanks for feedback. I agree with you. It's best to do it the way you suggested. I hadn't thought of that when I first made the PR 😄 .

I added new search and search_filtered functions without changing the previous functions.
And ran pytests.


Fix User Guide issues

Note:

Add Glossary
Add div breaks for various sections for PDF printing
Add hyperlinks to numerous terminologies and image section to improve User Experience
Fix formatting issues etc
Fix MOST of the issues mentioned in UG Peer Review

ready to merge?


Proposal: remove 'import accounts from backup file' feature

I think at first launch we need to provide only 2 options:

create new wallet
restore wallet from seed

If user has legacy wallet.data file, he can just put it manually in wallet folder.
The issue is that I generated HD seed, created many accounts and transactions. Then I tried to create a wallet in a new location by importing accounts from wallet.data via GUI. But at this point wallet generated a new HD seed and forced me to use it (different from the old one).
So now, after recovering wallet via GUI + wallet.data, I have 2 HD seeds and the old one can restore only old used addresses, while the new one only new created addresses.
This is super confusing with many HD seeds for the same wallet.data and very likely this will lead to loss of funds sooner or later.

We might just need to update our wording to user.  Import wallet from backup should import accounts as well as scan for hd accts from that key, but it should not replace the current wallets seed phrase.  It's an import/merge feature, not a restore feature.

Fixed.  We still allow import/recover, but we do not replace the existing HD seed.  we just import the addresses from it with a different prefix.


Drop explicit gdisk in debian/install

See: http://tracker.ceph.com/issues/12541
gdisk has been a proper dependency in Ceph packages since before
Firefly.  There is no need to install it directly.
Fixes: #12541
Signed-off-by: Travis Rhoden<EMAIL_ADDRESS>

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/ceph-deploy-pull-requests/1709/
Test PASSed.


Android:Make MessageQueueThreadImpl startNewBackgroundThread more efficient.

Notes
By adding thread synchronization,creating background threads is more efficient.
TianXia
XiaoMi Corp.

There's quite a few changes here. Can you limit them to MessageQueueThreadImpl.java?

Thanks for @javache reviews.
I has pull new request here.Looking forward to your reply.
https://github.com/facebook/react-native/pull/14116


Tutorial scripts are not working. Unit test also not working.

Hi, Tutorial C++ snippets are having run-time errors, I have attached the output of all the examples and unit tests.
Please help us.
boson@boson:~/Fields2Cover/build/tutorials$ ./1_basic_types_tutorial
####### Tutorial 1.1 Initialize a Point ######
Point 1: Point(1.2, 3.4, 0)
Point 2: Point(9.8, 7.6, 5.4)
Point 3: Point(11, 22, 0)
Point 4: Point(3, 0, -1). Its components are: {x: 3, y: 0, z: -1}
Point 5: Point(0, 4, 4)

####### Tutorial 1.2 Basic types are shared pointers ######
Access to OGRPoints: 5
Without accessing: 5

The old point is Point(1, 2, 0)
Old point is: Point(1, 2, 0) and cloned point is: Point(5, 10, 0)
Old point is: Point(5.5, 11, 0) and copied point is: Point(5.5, 11, 0)

####### Tutorial 1.3 Initialize a F2CLineString ######
Length of line 1: 5
Length of line 2: 2

####### Tutorial 1.4 Initialize a F2CLinearRing ######
Area of the ring: 0.5

####### Tutorial 1.5 Initializing other collections ######
Lines have length: 5, 2,

The area of the cell is: 3

The area of the cells is: 3

Points contains 2 points.
Points contains 3 points.
Points contains 4 points.

####### Tutorial 1.6 Accessing elements in collections ######
First point in points: Point(1, 2, 0)

Modified p_0: Point(100000, 200000, 0)
First point in points without modification: Point(1, 2, 0)
Modified first point in points: Point(100000, 200000, 0)

####### Tutorial 1.9 Visualizing Fields2Cover data ######
Segmentation fault (core dumped)

./2_objective_functions_tutorial
####### Tutorial 2.1.1 Remaining Area ######
The remaining area is 0.25
The remaining area with sign is -0.25

####### Tutorial 2.2.1 Field Coverage ######
The field coverage with swath1 is 0.5 and with all of the swaths 1
The field coverage with sign for all of the swaths is -1

####### Tutorial 2.2.2 Number of swaths ######
The number of swaths with swath1 is 1 and with all of the swaths 3

####### Tutorial 2.2.3 Overlap ######
The field overlapping with swath1 is 0 and with all of the swaths 0.5

####### Tutorial 2.2.4 Swath length ######
The swath length with swath1 is 4 and with all of the swaths 12

####### Tutorial 2.3.1 Distance with turns ######
The complete length is: 3.57166 =~= 3.5708

####### Tutorial 2.3.2 Direct distance without turns ######
The aproximated length is: 3

####### Tutorial 2.4.1 Path length ######
The path length is: 3

./3_headland_generator_tutorial
####### Tutorial 3.1 Constant width headland generator ######
The complete area is 10000, and the area without headlands is 7709.94
Segmentation fault (core dumped)

./4_swath_generator_tutorial
####### Tutorial 4.1 Brute force swath generator ######
Segmentation fault (core dumped)

./5_route_planning_tutorial
####### Tutorial 5.1 Boustrophedon ######
Segmentation fault (core dumped)

./6_path_planning_tutorial
####### Tutorial 6.1 Dubins curves ######
Segmentation fault (core dumped)

UNIT TEST RESULTS
~/Fields2Cover/build/tests$ ./unittests
[==========] Running 159 tests from 43 test suites.
[----------] Global test environment set-up.
[----------] 2 tests from fields2cover_hl_const_gen
[ RUN      ] fields2cover_hl_const_gen.empty_area
[       OK ] fields2cover_hl_const_gen.empty_area (0 ms)
[ RUN      ] fields2cover_hl_const_gen.border_area
[       OK ] fields2cover_hl_const_gen.border_area (1 ms)
[----------] 2 tests from fields2cover_hl_const_gen (1 ms total)

[----------] 6 tests from fields2cover_obj_complete_turn_path_obj
[ RUN      ] fields2cover_obj_complete_turn_path_obj.computeCost_cost
[       OK ] fields2cover_obj_complete_turn_path_obj.computeCost_cost (2 ms)
[ RUN      ] fields2cover_obj_complete_turn_path_obj.computeCost_cost_2
[       OK ] fields2cover_obj_complete_turn_path_obj.computeCost_cost_2 (1 ms)
[ RUN      ] fields2cover_obj_complete_turn_path_obj.computeCost_cost_long_swath
[       OK ] fields2cover_obj_complete_turn_path_obj.computeCost_cost_long_swath (134 ms)
[ RUN      ] fields2cover_obj_complete_turn_path_obj.computeCost_cost_dubinsCC
[       OK ] fields2cover_obj_complete_turn_path_obj.computeCost_cost_dubinsCC (71 ms)
[ RUN      ] fields2cover_obj_complete_turn_path_obj.computeCost_cost_reedsshepp
[       OK ] fields2cover_obj_complete_turn_path_obj.computeCost_cost_reedsshepp (70 ms)
[ RUN      ] fields2cover_obj_complete_turn_path_obj.computeCost_cost_reedssheppHC
[       OK ] fields2cover_obj_complete_turn_path_obj.computeCost_cost_reedssheppHC (70 ms)
[----------] 6 tests from fields2cover_obj_complete_turn_path_obj (348 ms total)

[----------] 1 test from fields2cover_complete_pred_turn_path_obj
[ RUN      ] fields2cover_complete_pred_turn_path_obj.params_check
[       OK ] fields2cover_complete_pred_turn_path_obj.params_check (0 ms)
[----------] 1 test from fields2cover_complete_pred_turn_path_obj (0 ms total)

[----------] 2 tests from fields2cover_obj_direct_dist_path_obj
[ RUN      ] fields2cover_obj_direct_dist_path_obj.computeCost_cost
[       OK ] fields2cover_obj_direct_dist_path_obj.computeCost_cost (0 ms)
[ RUN      ] fields2cover_obj_direct_dist_path_obj.params_check
[       OK ] fields2cover_obj_direct_dist_path_obj.params_check (0 ms)
[----------] 2 tests from fields2cover_obj_direct_dist_path_obj (0 ms total)

[----------] 3 tests from fields2cover_obj_field_coverage
[ RUN      ] fields2cover_obj_field_coverage.get_best_value
[       OK ] fields2cover_obj_field_coverage.get_best_value (1 ms)
[ RUN      ] fields2cover_obj_field_coverage.computeCost_cost
[       OK ] fields2cover_obj_field_coverage.computeCost_cost (1 ms)
[ RUN      ] fields2cover_obj_field_coverage.params_check
[       OK ] fields2cover_obj_field_coverage.params_check (0 ms)
[----------] 3 tests from fields2cover_obj_field_coverage (2 ms total)

[----------] 3 tests from fields2cover_obj_n_swath
[ RUN      ] fields2cover_obj_n_swath.get_best_value
[       OK ] fields2cover_obj_n_swath.get_best_value (0 ms)
[ RUN      ] fields2cover_obj_n_swath.computeCost_cost
[       OK ] fields2cover_obj_n_swath.computeCost_cost (0 ms)
[ RUN      ] fields2cover_obj_n_swath.params_check
[       OK ] fields2cover_obj_n_swath.params_check (0 ms)
[----------] 3 tests from fields2cover_obj_n_swath (0 ms total)

[----------] 2 tests from fields2cover_obj_overlaps
[ RUN      ] fields2cover_obj_overlaps.computeCost_cost
[       OK ] fields2cover_obj_overlaps.computeCost_cost (2 ms)
[ RUN      ] fields2cover_obj_overlaps.params_check
[       OK ] fields2cover_obj_overlaps.params_check (0 ms)
[----------] 2 tests from fields2cover_obj_overlaps (2 ms total)

[----------] 2 tests from fields2cover_obj_pathLength
[ RUN      ] fields2cover_obj_pathLength.computeCost
[       OK ] fields2cover_obj_pathLength.computeCost (1 ms)
[ RUN      ] fields2cover_obj_pathLength.params_check
[       OK ] fields2cover_obj_pathLength.params_check (0 ms)
[----------] 2 tests from fields2cover_obj_pathLength (2 ms total)

[----------] 1 test from fields2cover_obj_pp_obj
[ RUN      ] fields2cover_obj_pp_obj.isMinimizing
[       OK ] fields2cover_obj_pp_obj.isMinimizing (0 ms)
[----------] 1 test from fields2cover_obj_pp_obj (0 ms total)

[----------] 2 tests from fields2cover_obj_remArea
[ RUN      ] fields2cover_obj_remArea.computeCost
[       OK ] fields2cover_obj_remArea.computeCost (0 ms)
[ RUN      ] fields2cover_obj_remArea.params_check
[       OK ] fields2cover_obj_remArea.params_check (0 ms)
[----------] 2 tests from fields2cover_obj_remArea (0 ms total)

[----------] 1 test from fields2cover_obj_rp_obj
[ RUN      ] fields2cover_obj_rp_obj.computeCost_cost
[       OK ] fields2cover_obj_rp_obj.computeCost_cost (0 ms)
[----------] 1 test from fields2cover_obj_rp_obj (0 ms total)

[----------] 3 tests from fields2cover_obj_sg_obj
[ RUN      ] fields2cover_obj_sg_obj.get_best_value
[       OK ] fields2cover_obj_sg_obj.get_best_value (0 ms)
[ RUN      ] fields2cover_obj_sg_obj.computeCost_cost
[       OK ] fields2cover_obj_sg_obj.computeCost_cost (0 ms)
[ RUN      ] fields2cover_obj_sg_obj.params_check
[       OK ] fields2cover_obj_sg_obj.params_check (0 ms)
[----------] 3 tests from fields2cover_obj_sg_obj (0 ms total)

[----------] 2 tests from fields2cover_obj_swath_length
[ RUN      ] fields2cover_obj_swath_length.computeCost_cost
[       OK ] fields2cover_obj_swath_length.computeCost_cost (0 ms)
[ RUN      ] fields2cover_obj_swath_length.params_check
[       OK ] fields2cover_obj_swath_length.params_check (0 ms)
[----------] 2 tests from fields2cover_obj_swath_length (0 ms total)

[----------] 2 tests from fields2cover_pp_dubins_cc
[ RUN      ] fields2cover_pp_dubins_cc.turn_dist
[       OK ] fields2cover_pp_dubins_cc.turn_dist (1 ms)
[ RUN      ] fields2cover_pp_dubins_cc.random_points
[       OK ] fields2cover_pp_dubins_cc.random_points (24 ms)
[----------] 2 tests from fields2cover_pp_dubins_cc (25 ms total)

[----------] 4 tests from fields2cover_pp_dubins
[ RUN      ] fields2cover_pp_dubins.turn_dist
[       OK ] fields2cover_pp_dubins.turn_dist (1 ms)
[ RUN      ] fields2cover_pp_dubins.random_points
[       OK ] fields2cover_pp_dubins.random_points (538 ms)
[ RUN      ] fields2cover_pp_dubins.cached_turn
[       OK ] fields2cover_pp_dubins.cached_turn (5 ms)
[ RUN      ] fields2cover_pp_dubins.turn_valid
[       OK ] fields2cover_pp_dubins.turn_valid (4 ms)
[----------] 4 tests from fields2cover_pp_dubins (548 ms total)

[----------] 1 test from fields2cover_pp_pp
[ RUN      ] fields2cover_pp_pp.turn_dist
[       OK ] fields2cover_pp_pp.turn_dist (2 ms)
[----------] 1 test from fields2cover_pp_pp (2 ms total)

[----------] 2 tests from fields2cover_pp_reeds_shepp_hc
[ RUN      ] fields2cover_pp_reeds_shepp_hc.turn_dist
[       OK ] fields2cover_pp_reeds_shepp_hc.turn_dist (2 ms)
[ RUN      ] fields2cover_pp_reeds_shepp_hc.random_points
[       OK ] fields2cover_pp_reeds_shepp_hc.random_points (20 ms)
[----------] 2 tests from fields2cover_pp_reeds_shepp_hc (22 ms total)

[----------] 2 tests from fields2cover_pp_reeds_shepp
[ RUN      ] fields2cover_pp_reeds_shepp.turn_dist
[       OK ] fields2cover_pp_reeds_shepp.turn_dist (1 ms)
[ RUN      ] fields2cover_pp_reeds_shepp.random_points
[       OK ] fields2cover_pp_reeds_shepp.random_points (17 ms)
[----------] 2 tests from fields2cover_pp_reeds_shepp (18 ms total)

[----------] 2 tests from fields2cover_route_boustrophedon
[ RUN      ] fields2cover_route_boustrophedon.genSortedSwaths
[       OK ] fields2cover_route_boustrophedon.genSortedSwaths (0 ms)
[ RUN      ] fields2cover_route_boustrophedon.genSortedSwaths_empty_swaths
[       OK ] fields2cover_route_boustrophedon.genSortedSwaths_empty_swaths (0 ms)
[----------] 2 tests from fields2cover_route_boustrophedon (0 ms total)

[----------] 5 tests from fields2cover_custom_order
[ RUN      ] fields2cover_custom_order.defined_order
[       OK ] fields2cover_custom_order.defined_order (0 ms)
[ RUN      ] fields2cover_custom_order.constructor_order
[       OK ] fields2cover_custom_order.constructor_order (0 ms)
[ RUN      ] fields2cover_custom_order.incomplete_order
[       OK ] fields2cover_custom_order.incomplete_order (0 ms)
[ RUN      ] fields2cover_custom_order.bad_order
[       OK ] fields2cover_custom_order.bad_order (0 ms)
[ RUN      ] fields2cover_custom_order.out_of_range
[       OK ] fields2cover_custom_order.out_of_range (0 ms)
[----------] 5 tests from fields2cover_custom_order (0 ms total)

[----------] 2 tests from fields2cover_route_snake
[ RUN      ] fields2cover_route_snake.genSortedSwaths_even
[       OK ] fields2cover_route_snake.genSortedSwaths_even (0 ms)
[ RUN      ] fields2cover_route_snake.genSortedSwaths_odd
[       OK ] fields2cover_route_snake.genSortedSwaths_odd (1 ms)
[----------] 2 tests from fields2cover_route_snake (1 ms total)

[----------] 6 tests from fields2cover_route_spiral
[ RUN      ] fields2cover_route_spiral.genSortedSwaths_even
[       OK ] fields2cover_route_spiral.genSortedSwaths_even (0 ms)
[ RUN      ] fields2cover_route_spiral.genSortedSwaths_odd
[       OK ] fields2cover_route_spiral.genSortedSwaths_odd (0 ms)
[ RUN      ] fields2cover_route_spiral.genSortedSwaths_even_size
[       OK ] fields2cover_route_spiral.genSortedSwaths_even_size (0 ms)
[ RUN      ] fields2cover_route_spiral.genSortedSwaths_odd_size
[       OK ] fields2cover_route_spiral.genSortedSwaths_odd_size (0 ms)
[ RUN      ] fields2cover_route_spiral.genSortedSwaths_default_size
[       OK ] fields2cover_route_spiral.genSortedSwaths_default_size (0 ms)
[ RUN      ] fields2cover_route_spiral.genSortedSwaths_default_cstr
[       OK ] fields2cover_route_spiral.genSortedSwaths_default_cstr (0 ms)
[----------] 6 tests from fields2cover_route_spiral (0 ms total)

[----------] 1 test from fields2cover_swath_brute_gen
[ RUN      ] fields2cover_swath_brute_gen.best_angle
[       OK ] fields2cover_swath_brute_gen.best_angle (260 ms)
[----------] 1 test from fields2cover_swath_brute_gen (260 ms total)

[----------] 8 tests from fields2cover_types_cell
[ RUN      ] fields2cover_types_cell.constructor
[       OK ] fields2cover_types_cell.constructor (0 ms)
[ RUN      ] fields2cover_types_cell.setGeometry
[       OK ] fields2cover_types_cell.setGeometry (0 ms)
[ RUN      ] fields2cover_types_cell.getArea
[       OK ] fields2cover_types_cell.getArea (0 ms)
[ RUN      ] fields2cover_types_cell.addRing
[       OK ] fields2cover_types_cell.addRing (0 ms)
[ RUN      ] fields2cover_types_cell.createLineUntilBorder
[       OK ] fields2cover_types_cell.createLineUntilBorder (0 ms)
[ RUN      ] fields2cover_types_cell.isPointInBorder
[       OK ] fields2cover_types_cell.isPointInBorder (0 ms)
[ RUN      ] fields2cover_types_cell.isPointIn
[       OK ] fields2cover_types_cell.isPointIn (0 ms)
[ RUN      ] fields2cover_types_cell.Buffer
[       OK ] fields2cover_types_cell.Buffer (0 ms)
[----------] 8 tests from fields2cover_types_cell (0 ms total)

[----------] 9 tests from fields2cover_types_cells
[ RUN      ] fields2cover_types_cells.constructor
[       OK ] fields2cover_types_cells.constructor (0 ms)
[ RUN      ] fields2cover_types_cells.Difference
[       OK ] fields2cover_types_cells.Difference (0 ms)
[ RUN      ] fields2cover_types_cells.Buffer
[       OK ] fields2cover_types_cells.Buffer (0 ms)
[ RUN      ] fields2cover_types_cells.Intersection
[       OK ] fields2cover_types_cells.Intersection (0 ms)
[ RUN      ] fields2cover_types_cells.LongLines
[       OK ] fields2cover_types_cells.LongLines (0 ms)
[ RUN      ] fields2cover_types_cells.WherePoint
[       OK ] fields2cover_types_cells.WherePoint (0 ms)
[ RUN      ] fields2cover_types_cells.setGeometry
[       OK ] fields2cover_types_cells.setGeometry (0 ms)
[ RUN      ] fields2cover_types_cells.splitByLine
[       OK ] fields2cover_types_cells.splitByLine (1 ms)
[ RUN      ] fields2cover_types_cells.isPointIn
[       OK ] fields2cover_types_cells.isPointIn (0 ms)
[----------] 9 tests from fields2cover_types_cells (1 ms total)

[----------] 3 tests from fields2cover_types_field
[ RUN      ] fields2cover_types_field.area
[       OK ] fields2cover_types_field.area (0 ms)
[ RUN      ] fields2cover_types_field.clone
[       OK ] fields2cover_types_field.clone (0 ms)
[ RUN      ] fields2cover_types_field.getCellsAbsPosition
[       OK ] fields2cover_types_field.getCellsAbsPosition (0 ms)
[----------] 3 tests from fields2cover_types_field (0 ms total)

[----------] 2 tests from fields2cover_types_geometries
[ RUN      ] fields2cover_types_geometries.access_iterators
[       OK ] fields2cover_types_geometries.access_iterators (0 ms)
[ RUN      ] fields2cover_types_geometries.mult_iterators
[       OK ] fields2cover_types_geometries.mult_iterators (0 ms)
[----------] 2 tests from fields2cover_types_geometries (0 ms total)

[----------] 19 tests from fields2cover_types_geometry
[ RUN      ] fields2cover_types_geometry.getAngContinuity
[       OK ] fields2cover_types_geometry.getAngContinuity (0 ms)
[ RUN      ] fields2cover_types_geometry.intersects
[       OK ] fields2cover_types_geometry.intersects (0 ms)
[ RUN      ] fields2cover_types_geometry.touches
[       OK ] fields2cover_types_geometry.touches (1 ms)
[ RUN      ] fields2cover_types_geometry.disjoint
[       OK ] fields2cover_types_geometry.disjoint (0 ms)
[ RUN      ] fields2cover_types_geometry.within
[       OK ] fields2cover_types_geometry.within (0 ms)
[ RUN      ] fields2cover_types_geometry.crosses
[       OK ] fields2cover_types_geometry.crosses (1 ms)
[ RUN      ] fields2cover_types_geometry.distance
[       OK ] fields2cover_types_geometry.distance (0 ms)
[ RUN      ] fields2cover_types_geometry.getDimMinX
[       OK ] fields2cover_types_geometry.getDimMinX (0 ms)
[ RUN      ] fields2cover_types_geometry.getDimMinY
[       OK ] fields2cover_types_geometry.getDimMinY (0 ms)
[ RUN      ] fields2cover_types_geometry.getDimMaxX
[       OK ] fields2cover_types_geometry.getDimMaxX (0 ms)
[ RUN      ] fields2cover_types_geometry.getDimMaxY
[       OK ] fields2cover_types_geometry.getDimMaxY (0 ms)
[ RUN      ] fields2cover_types_geometry.getHeight
[       OK ] fields2cover_types_geometry.getHeight (0 ms)
[ RUN      ] fields2cover_types_geometry.getWidth
[       OK ] fields2cover_types_geometry.getWidth (0 ms)
[ RUN      ] fields2cover_types_geometry.getMinSafeLength
[       OK ] fields2cover_types_geometry.getMinSafeLength (0 ms)
[ RUN      ] fields2cover_types_geometry.equality
[       OK ] fields2cover_types_geometry.equality (0 ms)
[ RUN      ] fields2cover_types_geometry.exportToGML
[       OK ] fields2cover_types_geometry.exportToGML (0 ms)
[ RUN      ] fields2cover_types_geometry.exportToKML
[       OK ] fields2cover_types_geometry.exportToKML (0 ms)
[ RUN      ] fields2cover_types_geometry.exportToJson
[       OK ] fields2cover_types_geometry.exportToJson (0 ms)
[ RUN      ] fields2cover_types_geometry.rotateFromPoint
[       OK ] fields2cover_types_geometry.rotateFromPoint (0 ms)
[----------] 19 tests from fields2cover_types_geometry (2 ms total)

[----------] 2 tests from fields2cover_types_linestring
[ RUN      ] fields2cover_types_linestring.init
[       OK ] fields2cover_types_linestring.init (0 ms)
[ RUN      ] fields2cover_types_linestring.loop
[       OK ] fields2cover_types_linestring.loop (0 ms)
[----------] 2 tests from fields2cover_types_linestring (0 ms total)

[----------] 4 tests from fields2cover_types_linearring
[ RUN      ] fields2cover_types_linearring.init
[       OK ] fields2cover_types_linearring.init (0 ms)
[ RUN      ] fields2cover_types_linearring.getArea
[       OK ] fields2cover_types_linearring.getArea (0 ms)
[ RUN      ] fields2cover_types_linearring.mult_equal
[       OK ] fields2cover_types_linearring.mult_equal (0 ms)
[ RUN      ] fields2cover_types_linearring.loop
[       OK ] fields2cover_types_linearring.loop (0 ms)
[----------] 4 tests from fields2cover_types_linearring (0 ms total)

[----------] 5 tests from fields2cover_types_multilinestring
[ RUN      ] fields2cover_types_multilinestring.init
[       OK ] fields2cover_types_multilinestring.init (0 ms)
[ RUN      ] fields2cover_types_multilinestring.getGeometry
[       OK ] fields2cover_types_multilinestring.getGeometry (0 ms)
[ RUN      ] fields2cover_types_multilinestring.append
[       OK ] fields2cover_types_multilinestring.append (0 ms)
[ RUN      ] fields2cover_types_multilinestring.setGeometry
[       OK ] fields2cover_types_multilinestring.setGeometry (0 ms)
[ RUN      ] fields2cover_types_multilinestring.getLineSegments
[       OK ] fields2cover_types_multilinestring.getLineSegments (0 ms)
[----------] 5 tests from fields2cover_types_multilinestring (0 ms total)

[----------] 2 tests from fields2cover_types_multipoint
[ RUN      ] fields2cover_types_multipoint.init
[       OK ] fields2cover_types_multipoint.init (0 ms)
[ RUN      ] fields2cover_types_multipoint.getGeometry
[       OK ] fields2cover_types_multipoint.getGeometry (0 ms)
[----------] 2 tests from fields2cover_types_multipoint (0 ms total)

[----------] 6 tests from fields2cover_types_path
[ RUN      ] fields2cover_types_path.appendSwath
[       OK ] fields2cover_types_path.appendSwath (0 ms)
[ RUN      ] fields2cover_types_path.op_plus_equal
[       OK ] fields2cover_types_path.op_plus_equal (0 ms)
[ RUN      ] fields2cover_types_path.populate_and_reduce
[       OK ] fields2cover_types_path.populate_and_reduce (3 ms)
[ RUN      ] fields2cover_types_path.length
[       OK ] fields2cover_types_path.length (0 ms)
[ RUN      ] fields2cover_types_path.serialize
[       OK ] fields2cover_types_path.serialize (0 ms)
[ RUN      ] fields2cover_types_path.moveTo
[       OK ] fields2cover_types_path.moveTo (0 ms)
[----------] 6 tests from fields2cover_types_path (3 ms total)

[----------] 10 tests from fields2cover_types_point
[ RUN      ] fields2cover_types_point.minus
[       OK ] fields2cover_types_point.minus (0 ms)
[ RUN      ] fields2cover_types_point.plus
[       OK ] fields2cover_types_point.plus (0 ms)
[ RUN      ] fields2cover_types_point.mult_equal
[       OK ] fields2cover_types_point.mult_equal (0 ms)
[ RUN      ] fields2cover_types_point.multiply
[       OK ] fields2cover_types_point.multiply (0 ms)
[ RUN      ] fields2cover_types_point.plus_v
[       OK ] fields2cover_types_point.plus_v (0 ms)
[ RUN      ] fields2cover_types_point.minus_v
[       OK ] fields2cover_types_point.minus_v (0 ms)
[ RUN      ] fields2cover_types_point.clone
[       OK ] fields2cover_types_point.clone (0 ms)
[ RUN      ] fields2cover_types_point.set
[       OK ] fields2cover_types_point.set (0 ms)
[ RUN      ] fields2cover_types_point.print
[       OK ] fields2cover_types_point.print (0 ms)
[ RUN      ] fields2cover_types_point.rotateFromPoint
[       OK ] fields2cover_types_point.rotateFromPoint (0 ms)
[----------] 10 tests from fields2cover_types_point (0 ms total)

[----------] 1 test from fields2cover_types_robot
[ RUN      ] fields2cover_types_robot.init
[       OK ] fields2cover_types_robot.init (0 ms)
[----------] 1 test from fields2cover_types_robot (0 ms total)

[----------] 1 test from fields2cover_types_route
[ RUN      ] fields2cover_types_route.init
[       OK ] fields2cover_types_route.init (0 ms)
[----------] 1 test from fields2cover_types_route (0 ms total)

[----------] 1 test from fields2cover_types_stip
[ RUN      ] fields2cover_types_stip.clone
[       OK ] fields2cover_types_stip.clone (1 ms)
[----------] 1 test from fields2cover_types_stip (1 ms total)

[----------] 8 tests from fields2cover_types_swath
[ RUN      ] fields2cover_types_swath.hasSameDir
[       OK ] fields2cover_types_swath.hasSameDir (0 ms)
[ RUN      ] fields2cover_types_swath.comparison
[       OK ] fields2cover_types_swath.comparison (0 ms)
[ RUN      ] fields2cover_types_swath.length
[       OK ] fields2cover_types_swath.length (0 ms)
[ RUN      ] fields2cover_types_swath.set_id
[       OK ] fields2cover_types_swath.set_id (0 ms)
[ RUN      ] fields2cover_types_swath.width
[       OK ] fields2cover_types_swath.width (0 ms)
[ RUN      ] fields2cover_types_swath.area
[       OK ] fields2cover_types_swath.area (0 ms)
[ RUN      ] fields2cover_types_swath.angles
[       OK ] fields2cover_types_swath.angles (0 ms)
[ RUN      ] fields2cover_types_swath.start_and_end_points
[       OK ] fields2cover_types_swath.start_and_end_points (0 ms)
[----------] 8 tests from fields2cover_types_swath (0 ms total)

[----------] 4 tests from fields2cover_types_swaths
[ RUN      ] fields2cover_types_swaths.append
[       OK ] fields2cover_types_swaths.append (1 ms)
[ RUN      ] fields2cover_types_swaths.sort
[       OK ] fields2cover_types_swaths.sort (0 ms)
[ RUN      ] fields2cover_types_swaths.reverseDirOddSwaths
[       OK ] fields2cover_types_swaths.reverseDirOddSwaths (0 ms)
[ RUN      ] fields2cover_types_swaths.push_back
[       OK ] fields2cover_types_swaths.push_back (0 ms)
[----------] 4 tests from fields2cover_types_swaths (1 ms total)

[----------] 6 tests from fields2cover_utils_parser
[ RUN      ] fields2cover_utils_parser.import_gml
[       OK ] fields2cover_utils_parser.import_gml (3 ms)
[ RUN      ] fields2cover_utils_parser.get_area_imported
[       OK ] fields2cover_utils_parser.get_area_imported (8 ms)
[ RUN      ] fields2cover_utils_parser.file_not_found
[       OK ] fields2cover_utils_parser.file_not_found (1 ms)
[ RUN      ] fields2cover_utils_parser.import_json
Segmentation fault (core dumped)

Hi @RamanaBotta,
Same error as https://github.com/Fields2Cover/Fields2Cover/issues/46. Thanks to notice it
Working on it!

Solved on https://github.com/Fields2Cover/Fields2Cover/pull/50


404 page not found error for api/v2 but debug responds with some experiment for  api/v1

I have an elabFTW running on a remote server and trying to read experiments it only works as described in the title.

Hello,
Can you provide the code you're using please? Make sure to hide the key! Also, what version are you using of eLabFTW?

Hi, sure. This works for me:
import elabapi_python

my_api_key = "my_key"

# Config
configuration = elabapi_python.Configuration()
configuration.api_key["api_key"] = my_api_key
configuration.api_key_prefix["api_key"] = "Authorization"
configuration.host = "https://XXX.XXX.XX.X/api/v1"
configuration.debug = True
configuration.verify_ssl = False

# create an instance of the API class
api_client = elabapi_python.ApiClient(configuration)
# fix issue with Authorization header not being properly set by the generated lib
api_client.set_default_header(header_name="Authorization", header_value=my_api_key)

we run elabFTW 4.3.10 currently

Apiv2 comes with 4.4. Please upgrade your instance!


Support RMQ transient (non-durable) exchanges

Reported by @Wooderz, if you configure Brighter to use a transient (non-durable) exchange it gives the following error:
The AMQP operation was interrupted: AMQP close-reason, initiated by Peer, code=406, text=\"PRECONDITION_FAILED - inequivalent arg 'durable' for exchange 'exchange.wooderz' in vhost '/': received 'false' but current is 'true'\", classId=40, methodId=10, cause=",

Presumably we don't have durability as a config option then so the ExchangeDeclare call is forcing it to durable, and when the exchange isn't, it errors. We should provide a configuration attribute or similar.
Edit: https://github.com/iancooper/Paramore/blob/3d3c604d9ad9aeb1a44accbff00fc5399c5a7871/Brighter/paramore.brighter.commandprocessor.messaginggateway.rmq/MessageGatewayHelper.cs#L37

@ianbattersby there is a config setting https://github.com/iancooper/Paramore/blob/master/Brighter/paramore.brighter.commandprocessor.messaginggateway.rmq/MessagingGatewayConfiguration/RMQMessagingGatewayConfigurationSection.cs#L216-L225

I know, it's ignored ;-)

It can't be ignored, must be working as our exchange is durable. We have to add durable="true" as the default is false.
Or am I missing something here?

Apologies, I'm thinking about exchange type.
I need sleep :sleeps:


Fixes for Botkit v0.6

This brings the code up to botkit v0.6 compatibility, using Messaging Pipeline
I also changed the event names that are emitted, need to update the docs still for that

Thank you 👍


List themes in alphabetical order

I left other sections untouched since there might be some recommendation order, but I am pretty sure that the themes section would be better if everything is listed in alphabetical order.

this seems to be good thing to do. though pull-request template have to be updated accordingly then

@iamstarkov Not sure how you'd like to see the template been modified, I think all 5 items are not applicable to this PR.

nay, i meant pull-request template for future pull-requests to request include new themes with respect to alphabetical order

@iamstarkov I see where I misunderstood. I've submitted the PR template retouch as a separate PR (#214) since I've rephrased several other parts.

@gsklee landed in master! thank you


[Windows] Update upstream flannel plugin

Now we are using a forked branch for flannel as upstream flannel doesn't have a release which contains some important Windows commits.
We should switch to use upstream flannel plugin once there is a release which contains the commits
Related issue https://github.com/rancher/rancher/issues/20330

@loganhz Does https://github.com/rancher/flannel-cni need to be updated to constantly rebase upstream?

@StrongMonkey  No, Windows is not using https://github.com/rancher/flannel-cni any more.
We need to change the flannel download url here https://github.com/rancher/rke-tools/blob/master/package/Dockerfile.windows#L70
But we have to wait https://github.com/coreos/flannel/pull/1209 or https://github.com/coreos/flannel/pull/1238 merged and released.

I like #1238 better. If powershell/routing was all the code that we ever wanted (not much btw), lets pull it in. Ideal solution would be an org repo like github.com/Microsoft or something, but anyhow..

v0.12.0 added to windows rke-tools container https://github.com/rancher/rke-tools/pull/96

Validated using windows 1809 and 1903 on 2.4.6-rc2

Ingress, DNS checks fail in the automation checks
Manually deploy a daemonset - 3 pods, deploy an ingress.
The ingress fails to resolve to all the 3 pods.
It resolves always to only 1 pod.
On the windows nodes -

C:\opt\bin>rancher-wins-flanneld.exe --version
v0.12.0

Verified on 2.4-head - commit id: fb2c5fb2d

Bring up windows clusters using k8s versions - 1.18.3-rancher2-3, 1.17.7-rancher2-3, 1.16.10-rancher2-3 and 1.15.12-rancher2-4 - 3 linux - etcd, control and worker nodes, and 3 windows nodes.
Validation checks including Ingress, deployments, daemonsets, nodeport, dns resolution work fine.
flannel version on the windows nodes:

C:\opt\bin>rancher-wins-flanneld.exe   --version
v0.12.0-rancher1-dirty

Reopening this issue to get a fix in master-head

Verified on master-head - f7e83e3e4

Bring up windows clusters using k8s versions - 1.18.3-rancher2-3, 1.17.6-rancher2-3, 1.16.10-rancher2-3 and 1.15.12-rancher2-4 - 3 linux - etcd, control and worker nodes, and 3 windows nodes.
flannel version on the windows nodes:

C:\opt\bin>rancher-wins-flanneld.exe   --version
v0.12.0-rancher1-dirty

Basic checks - ingress, daemonsets, dns resolution works.


FEAT: increment version, sha256, and migrate the source URLs

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

known fragile unit tests. will be fixed in 0.9.1 release (pending). I'm not sure how conda-forge handles merging despite a CI failure. I guess I'll try it and find out.


Rgw/admin: add num_shards to  bucket struct field

This change add a new bucket struct field , so we can use rgw.admin.API.GetBucketInfo() to get a bucket's num_shards.
radosgw-admin bucket stats --bucket test
{
    "bucket": "test",
    "num_shards": 11,    <<<<    NumShards  *uint64 `json:"num_shards"
    "tenant": "",
    "zonegroup": "d9d22c42-ea25-44df-bded-506b5d64bc82",
    ...
}

Checklist

[ ] Added tests for features and functional changes
[ ] Public functions and types are documented
[x] Standard formatting is applied to Go code
[ ] Is this a new API? Added a new file that begins with //go:build ceph_preview

Please have commit message body similar to what's written in the PR's description, thanks!

done

Format code to pass CI.

My mistake, sorry

Changes look reasonable to me. I'll give @thotz a couple of days to re-approve but if he's unavailable/too busy to re approve I'll try to do so by the end of the week.


Call for Code Release

First of all, congratulations on your paper being accepted to NAACL 2024.
A few months ago, I read the preprint you uploaded to ArXiv, where your model, based on LLaMA2, achieved a Spearman correlation coefficient score of 86.01 across seven STS benchmark tasks.
Recently, I noticed that you've updated your paper and that the corresponding experimental results have improved from 86.01 to 86.26.
We have been unable to replicate these results and are therefore eager to access the corresponding code. As per the ReadMe file, it was mentioned that the code would be made available by the end of March 2024. Given that it's now April 5,2024, and the code has not yet been released, could you please share the code or provide an update on its availability?
Thank you for your attention to this matter. We are keen to explore and build upon your work.

@AnonymXXXXX Thank you for following our work and sorry for the delay. It should be released last week. But I was busy with the ACL rebuttal. Thus the schedule changed.
I will return to work on it next week. Will let you know when push the code and pretrained weights.

Thanks for your reply!

hi, I have pushed the code. More details are incoming

Thank you very much for open source your code, we will study it carefully.


Update for Artifactory 4.x plus some other cleanup

I think starting with Artifactory v4.0 they began naming their release zip files differently. This update uses the new naming scheme. This also now supports the new release types (oss, pro, registry). In addition it defaults to the latest current release (4.5.1).
I also updated some of the tasks to be more forgiving of individual configuration differences, stopped using the Ansible deprecated 'sudo' meta param, squashed some errors, fixed configuration file permissions, enabled the service for reboots, and finally symlinked the current Artifactory version.

I should also mention that I'm using this on Ubuntu 14.04 without issue.

@bbaassssiiee Hi there. Hopefully you see this in your email or notification somewhere. I've added support for more recent Artifactory versions to your Ansible role. Can you please take a look at it?
Thanks,
Matt


Missing import in generated desinations list for "destinations" mode

DestinationSpec import is missing in a generated destinations list in a module with only one desination declared and "destinations" mode set.
I'm using version 1.8.37-beta.
This is what's generated:
package redactedpackage

import redactedpackage.destinations.*

public val onboardingFeatureDestinations: List<DestinationSpec<out Any>> = listOf(
	OnboardingDestination
)

Thank you so much for reporting. It was my bad here. Should be fixed in new version which is cooking right now 🙂


xeval/evaluator:implement json_modify

Hi,
This PR support functions json_set/json_replace/json_insert in evaluator, the related PR in tidb is https://github.com/pingcap/tidb/pull/3492,
and the related source files in tidb are

https://github.com/pingcap/tidb/blob/master/expression/builtin_json.go
https://github.com/pingcap/tidb/blob/master/distsql/xeval/eval_json.go
https://github.com/pingcap/tidb/blob/master/distsql/xeval/eval.go

And the file datum.rs is the same with https://github.com/pingcap/tikv/pull/1996. we should do review after it has been merged.

[ ] https://github.com/pingcap/tikv/pull/1996

@hhkbp2 @hicqu @lishihai9017 @andelf PTAL

LGTM

LGTM

LGTM.


Add  command to Task.BuildSpec.Steps in all  example Task definitions.

Expected Behavior
The Task documentation in Concepts mentions use of field command.
It advises on not have an entry point set for container image.
apiVersion: pipeline.knative.dev/v1alpha1
kind: Task
metadata:
  name: hello-world
  namespace: default
spec:
  buildSpec:
    steps:
      - name: echo
        image: busybox
        command:
          - echo
        args:
          - "hello world!"

However, the example tasks still follow the old practice.
Actual Behavior
We should have examples also follow the same principles as explained in concepts documentation.
Steps to Reproduce the Problem

Additional Info

Once #183 is merged the advice to not rely on Entrypoint/Command will no longer be true, so the examples will be correct again. Is it worth updating them in the meantime? I think #183 will be merged in soon.

@tanner-bruce my feeling is we should still encourage people to be explicit about the command and args they should use, since with the entrypoint solution there is still the possible edge case where the entrypoint of the image as viewed by the controller and the pod are different, and this causes a problem, but open to other perspectives if you think this is not worth worrying about!

/assign