Fix NU5127, NU5128, and NU1701 in relation to native packages.

Fixes #514.
This resolves NU5127 and NU5128 at pack time. Also verified using a local package source that NU1701 no longer occurs when consuming the package.
New versions of all the native packages should probably be pushed after this is merged.

Is this really enough to fix it?

Done.


Zend_Filter_Encrypt_Mcrypt , mcrypt is not supported since php 7.2

Fatal error: Uncaught ErrorException: Function mcrypt_list_algorithms() is deprecated
Fatal error: Uncaught ErrorException: Function mcrypt_list_modes() is deprecated
PHP Fatal error:  Uncaught ErrorException: Function mcrypt_module_self_test() is deprecated

Try polyfill:

https://github.com/Shardj/zf1-future/issues/136#issuecomment-786741904

@aymencis your bug report lacks any reproducibility, how can the developer reproduce your problem without even describing what are you doing, what's your php version or how you enabled mcrypt extension?
to me seems if you install from pecl, it does not have methods deprecated:

https://github.com/Shardj/zf1-future/issues/136#issuecomment-787489865

$ git clone -b 1.0.3 https://git.php.net/repository/pecl/encryption/mcrypt.git
$ cd mcrypt
$ git grep E_DEPRECATED
mcrypt_filter.c:        php_error_docref(NULL, E_DEPRECATED, "mcrypt and mdecrypt stream filters have been deprecated");
$

#136 already addresses this as glensc linked


zap refuses to work

I have installed zap via the system wide script, and it gives this error.
[sussy@enterthevoid ~]$ zap install firefox
[FATAL] 2022/11/26 18:44:44 main.main:main.go:163 this app does not provide any candidate for installation

Try this instead
zap install --github --from=srevinsaju/Firefox-AppImage firefox

I'm not sure if it's just me, but I also have this issue.
Is the index still broken? zap search x seems to find the package I'm looking for.

Try this instead
zap install --github --from=srevinsaju/Firefox-AppImage firefox

Looks like the index is broken.

how do i fix the index then


Load balancer

(moved from https://code.google.com/p/solrnet/issues/detail?id=153 )
As described in http://wiki.apache.org/solr/LBHttpSolrServer . Make balancing algorithms pluggable, i.e. some implementations could be http://content.websitegear.com/article/load_balance_types.htm
Balancing algorithms should have access to response so that an impl can use qtime to schedule.

Current issue has been closed as part of cleanup process, which is tracked in https://github.com/SolrNet/SolrNet/issues/338.
Please reopen if needed, hopefully helping bringing up to date with current code.


Quick Start: az network front-door waf-policy managed-rules add = Managed rule set type and version is not supported

Following "Quickstart: Create an Azure Front Door Standard/Premium - Azure CLI"...
https://learn.microsoft.com/en-us/azure/frontdoor/create-front-door-cli
Everything works as expected until "Assign managed rules to the WAF policy"
https://learn.microsoft.com/en-us/azure/frontdoor/create-front-door-cli#assign-managed-rules-to-the-waf-policy
$org = "MyOrg"
$rg = $org + "-ResourceGroup"
$waf_policy = $org + "WafPolicy"
az network front-door waf-policy managed-rules add \
    --policy-name $waf_policy \
    --resource-group $rg \
    --type Microsoft_DefaultRuleSet \
    --version 1.2 --debug

At which point (with the --debug flag included) I see...
[...snipped...]
cli.azure.cli.core.sdk.policies: {
  "error": {
    "code": "BadRequest",
    "message": "WebApplicationFirewallPolicy validation failed. More information \"Managed rule set type and version is not supported\"."
  }
}
[...snipped...]

However, the syntax given in the learn document does seem to match the documentation for az network front-door waf-policy managed-rules add as well,
What am I missing?  I've seen mentioned elsewhere that the az network front-door  commands use the old frontdoor product/service, but this documentation seems to indicate it is still the right path for the WAF?
Please advise/amend.
PS:  Edited to reflect current effort.  I omitted the hyphen from the waf name as per this, however the issue remains.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: a5658f8e-b8f2-362a-d673-4aab4ccdf000
Version Independent ID: 94acd5d4-0b4b-2df3-7013-c19d44f686ee
Content: Quickstart: Create an Azure Front Door Standard/Premium - the Azure CLI
Content Source: articles/frontdoor/create-front-door-cli.md
Service: frontdoor
GitHub Login: @duau
Microsoft Alias: duau

@bigteejay
Thank you for your feedback! We will review and update as appropriate.

In line with this issue, I ensured there are no hyphens in any resources I create.  Issue still persists.

@bigteejay
Thank you for the feedback here.
I also faced the same issue and below is how I was able to resolve it.

Run az extension update --name front-door in order to update the front-door extension in Az CLI
Update the command to include --action parameter as shown below

az network front-door waf-policy managed-rules add  --policy-name contosoWAF --resource-group <YourRG> --action Log  --type Microsoft_DefaultRuleSet --version 2.1
I was successfully able to run both the commands this way.

I will propose a PR to get this updated in the documentation. Hope this helps! Please tag me in your response and we gladly re-open this issue and continue with our discussion. Thank you!

Interestingly there are a number of versions of front-door installed locally...
az extension list-versions --name front-door --query [].version --output tsv
1.0.2
1.0.3
1.0.4
1.0.5
1.0.6
1.0.7
1.0.8
1.0.9
1.0.11
1.0.12
1.0.13
1.0.14
1.0.15
1.0.16
1.0.17 (max compatible version)

@ChaitanyaNaykodi-MSFT is the "max compatible version" ran by default?
I'll try clearing them out and then updating as instructed.

@ChaitanyaNaykodi-MSFT
The --action  flag info was what was missing.  Thank you!

@ChaitanyaNaykodi-MSFT
Can you briefly speak to the propriety/accuracy of intermingling az afd and az network front-door?  My concern is that they appear to be two distinct control systems and using both will either be ineffective or conflicting.
Should az afd alone be used to enable/manage and integrate the latest managed rules (with OWASP Top 10 protection) into a solution with a webapp and managed postgres?


Docker image tag 2.4 and 2.4.3 do not match...

Docker image tag 2.4 and 2.4.3 do not match...
Surely 2.4 tagged image should match the latest sub-version 2.4.3?
Or was there a 2.4.4 release made but not tagged in github?

I made the same assumption and was confused by the different image digests.
Even worse, the latest tag points to a 2.5 DEV version, where as the README clearly states at the top:

Last stable release: 2.4.3 (2.4, 2.4.3 and latest tags from the official Docker image)


store & store-core are not in stack nightly resolver

Putting store-<IP_ADDRESS> & store-core-0.4.1 in extra-deps results in this error under stack build on a project with nightly-2017-08-25:
    /tmp/stack29424/store-<IP_ADDRESS>/src/Data/Store/Internal.hs:110:1: error:
        Could not find module ‘Data.Typeable.Internal’
        it is a hidden module in the package ‘base-<IP_ADDRESS>’
        Use -v to see a list of the files searched for.
        |
    110 | import           Data.Typeable.Internal (Typeable)
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Putting a github packages->location entry for store & store-core with the latest commit instead results in a successful build. So, perhaps the hackage is not the latest, either.
This affects people trying to use stack with GHC 8.2 & store for their projects.

It is disabled in the current Stackage plan due to a compilation failure. However, I haven't checked if it's still true.
# - stackage-curator # via store compilation failure
- store < 0 # compilation failure

I'm not sure I want to release the current changes, so I created a branch with a few fixes, in particular the compilation fix: https://github.com/fpco/store/tree/version-<IP_ADDRESS>
Pinging @snoyberg

(Also released that branch) Will close this once it's in stackage

Stackage PR https://github.com/fpco/store/issues/117 is merged 👍


chore: update documentation

Description

Linear Link

Business Impact

Testing required outside of automated testing?

[ ] Not Applicable

Screenshots (if appropriate):

[ ] Not Applicable

Rollback / Rollforward Procedure

[ ] Roll Forward
[ ] Roll Back

Documentation
Reviewer Checklist

[ ] Description of Change
[ ] Description of Business Impact.
[ ] Description of outside testing if applicable.
[ ] Description of Roll Forward / Backward Procedure
[ ] Documentation updated for Change

:tada: This PR is included in version 1.3.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


The dynamic feature causes issues since dyld cannot load libstd when debugging on macOS within CLion

Bevy version
0.6
Operating system & version
macOS 12.1 running on M1 Pro
What you did
Create a new binary with cargo and the bevy dependency using bevy = { version = "0.6", features = ["dynamic"] }. Then change the code within main.rs to the following:
use bevy::prelude::*;

fn main() {
    App::new().add_plugins(DefaultPlugins).run();
}

Start the application in Debug mode from within CLion.
What you expected to happen
The app would start without issues.
What actually happened
The debugger halts with the following error in the console:
dyld[53483]: Library not loaded: @rpath/libstd-834e42ded129b20e.dylib
  Referenced from: /Users/near/Code/Personal/bevy_dynamic_issue/target/debug/bevy_dynamic_issue
  Reason: tried: '/usr/local/lib/libstd-834e42ded129b20e.dylib' (no such file), '/usr/lib/libstd-834e42ded129b20e.dylib' (no such file)
Signal: SIGABRT (signal SIGABRT)

Process finished with exit code 9

Additional information
Weirdly enough just running the application instead of debugging it, works without issues. Presumably there is an erroneous interaction between lldb that is used by CLion and the executable.

You have to set LD_LIBRARY_PATH to the directory which contains the executable. cargo run automatically does this for you, but clion doesn't.

Just to make sure I get that right. The environment variable should point to the path wherein my debug executable is at /Users/near/Code/Personal/bevy_dynamic_issue/target/debug/?

To  /Users/near/Code/Personal/bevy_dynamic_issue/target/debug/. Also on macOS it is called DYLD_LIBRARY_PATH I believe, not LD_LIBRARY_PATH as I initially said.

You were right with the name of the environment variable, albeit the error remains. Please note that I am not getting an error that the libbevy_dynamic.dylib cannot be found, it is an error that libstd, presumably the one from Rust, cannot be loaded.
Reason: tried: '/Users/near/Code/Personal/bevy_dynamic_issue/target/debug//libstd-834e42ded129b20e.dylib' (no such file), '/usr/local/lib/libstd-834e42ded129b20e.dylib' (no such file), '/usr/lib/libstd-834e42ded129b20e.dylib' (no such file)

Try adding a colon (:) and then the output of running rustc --print target-libdir. This command lists the directory which contains libstd-*.dylib.

Since I work on an M1 the path was slightly different since it points to the aarch64 version of the toolchain, but the gist was right and I got it to work properly! Did I miss any details within the docs about this or does it happen to not be properly documented?

Since I work on an M1 the path was slightly different since it points to the aarch64 version of the toolchain, but the gist was right and I got it to work properly!

Nice!

Did I miss any details within the docs about this or does it happen to not be properly documented?

I don't think this is documented anywhere. Let's leave this issue open for documenting this.

the libstd file exsit, it maybe only happend while manully run excutable file like
./target/debug/app

custom  DYLD_LIBRARY_PATH work for me
DYLD_LIBRARY_PATH=$(rustc --print target-libdir) ./target/debug/app

For those debugging in VSCode the following addition to my launch.json fixed it for me:
            "env": {
                // rustc --print target-libdir
                "DYLD_LIBRARY_PATH": "${userHome}/.rustup/toolchains/nightly-aarch64-apple-darwin/lib/rustlib/aarch64-apple-darwin/lib"
            }

But that path is architecture specific, so run rustc --print target-libdir to find the required suffix.


Issue with dylib linking on macOS

Template text
This area is reserved to developers.
If you are not a developer, you are in the wrong place and your issue will be closed.

For discussions, feedbacks, ideas and new fixtures, go to:
http://www.qlcplus.org/forum/index.php
and provide as many details as possible regarding your findings.

Before reporting new issue, please discuss it on the forum. Let's keep the issues tidy!

If you are a developer, you are supposed to have built QLC+ from sources, and started to debug the issue you have found.

Therefore, please provide a crash log or references to the code that are supposed to help the QLC+ developers to resolve the issue.
Also, if your issue concerns a specific platform, please indicate it in the issue title like [platform] description.

Specs

Machine: Macbook Pro M1 macOS Sonoma 14.4
Qt: 5.15.13 install through homebrew
All dependencies install through brew not macports, but I don't think that's the issue here.
git commit: current master HEAD, 0ce5c5b3da9d2eeca405c961d84dc16812d90b45

Issue
qmake and make execution in the repo are both successful, the issue arises when make install is executed. The issue comes from executing targets in the 'platforms/macos/Makefile' file. Here is the log section where it cds to that directory and fails:
cd macos/ && ( test -e Makefile || /opt/homebrew/opt/qt@5/bin/qmake -o Makefile /Users/user/Developer/qlcplus/platforms/macos/macos.pro ) && /Applications/Xcode.app/Contents/Developer/usr/bin/make -f Makefile install
install_name_tool -id @executable_path/../Frameworks/libqlcplusui.1.dylib ~/QLC+.app/Contents/Frameworks/libqlcplusui.1.dylib
install_name_tool -id @executable_path/../Frameworks/libqlcpluswebaccess.1.dylib ~/QLC+.app/Contents/Frameworks/libqlcpluswebaccess.1.dylib
install_name_tool -id @executable_path/../Frameworks/libqlcplusengine.1.dylib ~/QLC+.app/Contents/Frameworks/libqlcplusengine.1.dylib
/opt/homebrew/opt/qt@5/bin/qmake -install qinstall /opt/homebrew/Cellar/libusb/1.0.26/lib/libusb-1.0.0.dylib /Users/user/QLC+.app/Contents/Frameworks/libusb-1.0.0.dylib
install_name_tool -id @executable_path/../Frameworks/libusb-1.0.0.dylib ~/QLC+.app/Contents/Frameworks/libusb-1.0.0.dylib
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/install_name_tool: warning: changes being made to the file will invalidate the code signature in: /Users/user/QLC+.app/Contents/Frameworks/libusb-1.0.0.dylib
/opt/homebrew/opt/qt@5/bin/qmake -install qinstall /opt/homebrew/Cellar/libftdi/1.5_2/lib/libftdi1.2.dylib /Users/user/QLC+.app/Contents/Frameworks/libftdi1.2.dylib
install_name_tool -id @executable_path/../Frameworks/libftdi1.2.dylib ~/QLC+.app/Contents/Frameworks/libftdi1.2.dylib
error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/install_name_tool: can't open file: /Users/user/QLC+.app/Contents/Frameworks/libftdi1.2.dylib (No such file or directory)
make[2]: *** [install_LIBFTDI_ID] Error 1
make[1]: *** [sub-macos-install_subtargets] Error 2
make: *** [sub-platforms-install_subtargets-ordered] Error 2

You can see the initial warning about invalidating the code signature in the libusb dylib, then it fully fails claiming it can't find the libftdi dylib that it copied to the app Frameworks dir. I have confirmed that the dylib is properly copied there. From my googling, it seems like both of these outputs are the result of some stuff getting mismatched during initial source compilation and the linker link step (source).
I found where a few libraries are being called with install_name_tool -change above in the full log output:
install_name_tool -change /opt/homebrew/Cellar/libusb/1.0.26/lib/libusb-1.0.0.dylib @executable_path/../Frameworks/libusb-1.0.0.dylib libdmxusb.dylib && install_name_tool -change /opt/homebrew/Cellar/libftdi/1.5_2/lib/libftdi1.2.dylib @executable_path/../Frameworks/libftdi1.2.dylib libdmxusb.dylib

Here's the output of otool -L /opt/homebrew/opt/libftdi/lib/libftdi1.2.dylib:
/opt/homebrew/Cellar/libftdi/1.5_2/lib/libftdi1.2.dylib:
        /opt/homebrew/opt/libftdi/lib/libftdi1.2.dylib (compatibility version 2.0.0, current version 2.5.0)
        /opt/homebrew/opt/libusb/lib/libusb-1.0.0.dylib (compatibility version 4.0.0, current version 4.0.0)
        /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1311.0.0)

Here's all the available dylibs:

Even if I comment out the install_name_tool -id call for the ftdi make target, there's another failure shortly after with a different library. I don't have too much experience with all of this dynamic linking on full-blown operating systems - is there something easy I'm missing here with fixing the link paths?

Homebrew is not yet supported. Closing, sorry


Add pre-commit autoupdate workflow

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (a649959) to head (ab80257).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #218   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           33        33
  Lines          634       634
  Branches        41        41
=========================================
  Hits           634       634

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Added font weight configuration to the suggestion widget

resolves #53469

Thanks for the PR @oriash93. We are at the very end of the current iteration, I will get back to this in the start of the next iteration which is next week.

Sorry for the delay in getting back to this @oriash93
Instead of introducing a new setting, we settled on re-using the editor.fontWeight setting as per discussions in #53469. Therefore, I will close this PR.


[CIP 0039] Move CIP-39 file and fix spelling errors

Minor edits to CIP-39:

Moves the file from CIPs/cip-39.md to CIP/cip-0039.md
Fix a number of spelling errors

@YazzyYaz would you mind approving this when you get a chance?


Error in the php code

Hello,
I tried these databases in the WAMP server locally. I had created a new database. uploaded the entire database and entered the credentials in index.php. When i try to load the index.php file, it is showing the following error. I need your help in solving this issue. I'm attaching a screenshot for your reference.

Thanks and regards
Pradeep Augustine

please post the php code snippet here, someone here might help you.

Will look into those things - we might simply create a new project as an interface to the databases.


AWS: Allow callers to specify VPC_ID and SUBNET_ID

This is for people that want to run in a shared VPC/Subnet; while this should
work, we don't actively want to support it yet.  So we don't block it,
but we don't document/encourage it either!

LGTM


Enable OnnxRuntime to use execution providers for benchmarking.

ONNX Runtime works with different hardware acceleration libraries through its extensible Execution Providers (EP)  framework to optimally execute the ONNX models on the hardware platform.
Currently, mlagility only supports the default execution provider (CPU/ MLAS). Ability to use the other EPs can broaden the spectrum for benchmarking.

The following is the list of all available onnxruntime execution providers

The focus of this MR is going to be on adding support for:

NVIDIA CUDA
AMD ROCm
Intel OpenVino

None of the ARM EPs listed here has a pypi package ready to deploy.
We will have to build onnxruntime from source within the container we plan to deploy. The downside is the initial setup time for building from source will be ~15-20 mins.

Let's say we took that install-from-source as a manual step. And provisioning an ARM server on AWS or Azure as a manual step. Any difficulty beyond that?

Nope. Provisioning and install from source are the long poles. The other parts of the pipeline are pretty straightforward.


Improve JavaScript parameter recognization

Some improvements:

Fix: not recognizing function name with uppercase letter
Add: test cases for destructuring
Add: support default value with bracket (function call)

The top-level group of the expression before the lookahead has to be reluctant because we will match too many spaces otherwise. So +?.

@RunDevelopment Finished~

Thank you for contributing!


Expand the Visitor API

We should allow for context so the node is aware of what the parent is and also allow for some mechanism for replacement of the currently visited node.

Released in 3.0.0


support cmake compiling

This is like a pre-staging PR, I am not so sure about your code style, so please do some review and let me know what needs to be changed.
My dev env:
cmake version: v2.8.7
gcc version: 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5)
os: Ubuntu 12.04

compile command
cmake CMakeLists.txt
make

Supported:

build of daemon
build of static lib
build of Examples
build of test exec file
build of tags
build of docs
build of check and lint
build of storage tool
auto checkout the submodule of gtest
no source code is changed

Something changed

the test exec file is changed build/test/test -> build/TestRunner
the daemon exec file is changed build/LogCabin -> build/LogCabinServer
all example exec files are moved to build
cmake generates the .o files into CMakeFiles/${executable_name}.dir/${src_dir}.o so it will do some extra compiling for each executable files.

TODO

currently, I am using -std=c++0x to compile I will add support to -std=c++11 in the future.
lib detecting
rpm packing
testing action
Separate the flags for protoc generated files , gtest files and logcabin project files. You will see tons of warning when compiling those protoc generated files now.
update .travis.yml

Let me know if I still have something missed.

Hey @johnzeng, thanks for doing the heavy lifting here! It's looking pretty good already. A few more thoughts:

the daemon exec file is changed build/LogCabin -> build/LogCabinServer

logcabind might be better to match the install name.

cmake generates the .o files into CMakeFiles/${executable_name}.dir/${src_dir}.o so it will do some extra compiling for each executable files.

I can't tell quite how bad this is. We should time clean and incremental scons vs cmake builds and double-check that compile times haven't gotten much worse.
The protobuf warnings are indeed painful. You might want to prioritize that just because it'll make it easier to see what's going on without all the clutter.
You might not be aware of .travis.yml, but that'll need slight updating too (since you have a TODO list in your description above).

Thanks for your comment ,I do know that there is a .travis.yml file , I think it should be modified after the switching. I will do some update on these codes when I get time.

I've make some improvement.

fixed all your commented codes
use different compile flags for different types of fies, so protobuf generated files won't throw lots of warning now
libray dependency checking is done
build/LogCabinServer changed back to build/LogCabin .(Note: case-unsensitive file system(like the default file system of OSX) will get error because they treat locabin and LogCabin as same target, and that's why I changed it to LogCabinServer )
Improve the compile behaviour of .o files, you don't need to compile them again and again now.

about cmake object files
It's a default behaviour that cmake will generate .o files into CMakeFiles/${executable_name}.dir/ for different executable target, it is designed to make sure different target can be built in different setting. But I think logcabin doesn't need this , so I compile them into three static libs:

the original locabin static lib
server lib for files in /Server
and storage lib for files in /Storage

And then linking these libs into the executable files instead of inputing .cc files directly.

Compile times are looking good. Here's some rough times from my dual-core 2012 laptop:

build
complete
incremental

cmake x 1 CPU
2m39s
0m51s

scons x 1 CPU
3m02s
0m44s

cmake x 5 CPU
1m16s
0m27s

scons x 5 CPU
1m24s
0m22s

From running the following script (keep this outside your git clone or it'll delete itself):
#!/bin/bash
set -e

# ProtoBuf files to copy to build/ first as workaround for cmake parallel build
# issue.
PROTO="
  Core/ProtoBufTest.proto
  Protocol/Client.proto
  Protocol/Raft.proto
  Protocol/RaftLogMetadata.proto
  Protocol/ServerControl.proto
  Protocol/ServerStats.proto
  Server/SnapshotMetadata.proto
  Server/SnapshotStateMachine.proto
  Server/SnapshotStats.proto
  Storage/SegmentedLog.proto
  Storage/SimpleFileLog.proto
  Tree/Snapshot.proto
"

INCRFILE=Storage/Log.h

build() {
  case $BUILD in
    "cmake")
      for FILE in $PROTO; do
        mkdir -p $(dirname build/$FILE)
        cp $FILE build/$FILE
      done
      time sh -c "cmake . && make -j$CPUS" > /dev/null
    ;;

    "scons")
      time scons NUMCPUS=$CPUS > /dev/null
    ;;
  esac
}

for RUN in {1..3}; do
  for CPUS in 1 5; do
    for BUILD in cmake scons; do
      echo "---"
      echo "Running clean build with $BUILD on $CPUS CPUs"
      git clean -fdx > /dev/null
      git checkout $INCRFILE
      build
      echo "---"
      echo "Running incremental build with $BUILD on $CPUS CPUs"
      echo >> $INCRFILE
      build
    done
  done
done

The full output was:
Running clean build with cmake on 1 CPUs
using gcc

real	2m39.385s
user	2m28.208s
sys	0m9.104s
---
Running incremental build with cmake on 1 CPUs
using gcc

real	0m51.379s
user	0m47.788s
sys	0m2.980s
---
Running clean build with scons on 1 CPUs

real	3m1.918s
user	2m50.452s
sys	0m10.184s
---
Running incremental build with scons on 1 CPUs

real	0m43.840s
user	0m41.508s
sys	0m2.144s
---
Running clean build with cmake on 5 CPUs
using gcc

real	1m16.307s
user	4m24.328s
sys	0m13.732s
---
Running incremental build with cmake on 5 CPUs
using gcc

real	0m26.968s
user	1m16.488s
sys	0m4.096s
---
Running clean build with scons on 5 CPUs

real	1m23.762s
user	4m55.588s
sys	0m15.692s
---
Running incremental build with scons on 5 CPUs

real	0m22.370s
user	1m9.072s
sys	0m3.304s
---
Running clean build with cmake on 1 CPUs
using gcc

real	2m40.216s
user	2m29.092s
sys	0m9.084s
---
Running incremental build with cmake on 1 CPUs
using gcc

real	0m52.122s
user	0m48.628s
sys	0m2.848s
---
Running clean build with scons on 1 CPUs

real	3m0.541s
user	2m48.872s
sys	0m10.444s
---
Running incremental build with scons on 1 CPUs

real	0m44.658s
user	0m42.236s
sys	0m2.220s
---
Running clean build with cmake on 5 CPUs
using gcc

real	1m15.214s
user	4m24.972s
sys	0m13.532s
---
Running incremental build with cmake on 5 CPUs
using gcc

real	0m26.388s
user	1m17.080s
sys	0m4.132s
---
Running clean build with scons on 5 CPUs

real	1m24.206s
user	4m56.604s
sys	0m15.804s
---
Running incremental build with scons on 5 CPUs

real	0m23.377s
user	1m10.392s
sys	0m3.172s
---
Running clean build with cmake on 1 CPUs
using gcc

real	2m39.735s
user	2m28.880s
sys	0m8.824s
---
Running incremental build with cmake on 1 CPUs
using gcc

real	0m52.694s
user	0m49.004s
sys	0m3.072s
---
Running clean build with scons on 1 CPUs

real	3m22.524s
user	3m10.216s
sys	0m10.864s
---
Running incremental build with scons on 1 CPUs

real	0m46.009s
user	0m43.376s
sys	0m2.444s
---
Running clean build with cmake on 5 CPUs
using gcc

real	1m16.466s
user	4m23.892s
sys	0m13.692s
---
Running incremental build with cmake on 5 CPUs
using gcc

real	0m25.774s
user	1m17.000s
sys	0m4.196s
---
Running clean build with scons on 5 CPUs

real	1m23.515s
user	4m56.128s
sys	0m15.764s
---
Running incremental build with scons on 5 CPUs

real	0m22.251s
user	1m9.988s
sys	0m3.312s

I think we should merge this once you've taken care of those minor nits, then address the remaining to-do items in subsequent PRs. Sound good?

It's ok to copy proto files at the begin. Will fix it soon

Please clean up the build, CMakeFiles and CMakeCache files and re-run it with make -j8 (or something else if you get enough CPU cores) to test it. My working env is a virtual machine with single core only, so I am not sure if it works perfectly or not.

Thanks. I tried a couple of make -j builds and they seem to work.

BTW the Ninja build is broken for me:
$ cmake -GNinja . && ninja -j1
-- The C compiler identification is GNU 4.9.2
-- The CXX compiler identification is GNU 4.9.2
-- Check for working C compiler using: Ninja
-- Check for working C compiler using: Ninja -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler using: Ninja
-- Check for working CXX compiler using: Ninja -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Configuring done
-- Generating done
-- Build files have been written to: /home/ongardie/logcabin
[6/156] Building CXX object CMakeFiles/ServerSrcObject.dir/Server/RaftConsensusInvariants.cc.o
FAILED: /usr/bin/c++    -fno-strict-overflow -fPIC -std=c++11 -I./gtest/include -I./gtest -I./build -I./include -I.      -DSWIG -MMD -MT CMakeFiles/ServerSrcObject.dir/Server/RaftConsensusInvariants.cc.o -MF CMakeFiles/ServerSrcObject.dir/Server/RaftConsensusInvariants.cc.o.d -o CMakeFiles/ServerSrcObject.dir/Server/RaftConsensusInvariants.cc.o -c Server/RaftConsensusInvariants.cc
In file included from Server/RaftConsensusInvariants.cc:18:0:
./Server/RaftConsensus.h:24:38: fatal error: build/Protocol/Client.pb.h: No such file or directory
 #include "build/Protocol/Client.pb.h"
                                      ^
compilation terminated.
ninja: build stopped: subcommand failed.
Exited with status 1.

I don't know how much we care (I'm perfectly OK with not supporting Ninja), except that this may be symptom of having incorrectly defined dependencies.
That's with cmake 3.0.2 and ninja 1.3.4.

Fixed the spelling error. As for ninja build, I haven't really used it yet, but it looks like the dependency is wrong, build/Protocol/Client.pb.h should be generated before Server/RaftConsensus.h is compiled. I add protocol as a dependency of Server, pls try to compile it by ninja again, let me know if it works or not.

@ongardie Ninja works for me, with cmake 3.6.3 and 1.3.4.
@johnzeng I found a problem, this version of CMakeList.txt only works in the root direcotry of the project, cause of copying of the .proto files.
If I build the project in a subdirectory, I got errors.
$ mkdir cmake_build
$ cd !$
$ cmake ..
$ make
Scanning dependencies of target copy_proto_files_to_build
cp: failed to get attributes of ‘Core’: No such file or directory
cp: failed to get attributes of ‘Protocol’: No such file or directory
...

It's expected to work.

Well, 7ecba30 didn't quite fix Ninja for me:
$ cmake -GNinja . && ninja -j1
-- The C compiler identification is GNU 4.9.2
-- The CXX compiler identification is GNU 4.9.2
-- Check for working C compiler using: Ninja
-- Check for working C compiler using: Ninja -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler using: Ninja
-- Check for working CXX compiler using: Ninja -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Configuring done
CMake Warning (dev) at CMakeLists.txt:384 (add_dependencies):
  Policy CMP0046 is not set: Error on non-existent dependency in
  add_dependencies.  Run "cmake --help-policy CMP0046" for policy details.
  Use the cmake_policy command to set the policy and suppress this warning.

  The dependency target "build/Protocol/Client.pb.cc" of target
  "ServerSrcObject" does not exist.
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at CMakeLists.txt:384 (add_dependencies):
  Policy CMP0046 is not set: Error on non-existent dependency in
  add_dependencies.  Run "cmake --help-policy CMP0046" for policy details.
  Use the cmake_policy command to set the policy and suppress this warning.

  The dependency target "build/Protocol/Raft.pb.cc" of target
  "ServerSrcObject" does not exist.
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at CMakeLists.txt:384 (add_dependencies):
  Policy CMP0046 is not set: Error on non-existent dependency in
  add_dependencies.  Run "cmake --help-policy CMP0046" for policy details.
  Use the cmake_policy command to set the policy and suppress this warning.

  The dependency target "build/Protocol/RaftLogMetadata.pb.cc" of target
  "ServerSrcObject" does not exist.
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at CMakeLists.txt:384 (add_dependencies):
  Policy CMP0046 is not set: Error on non-existent dependency in
  add_dependencies.  Run "cmake --help-policy CMP0046" for policy details.
  Use the cmake_policy command to set the policy and suppress this warning.

  The dependency target "build/Protocol/ServerControl.pb.cc" of target
  "ServerSrcObject" does not exist.
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at CMakeLists.txt:384 (add_dependencies):
  Policy CMP0046 is not set: Error on non-existent dependency in
  add_dependencies.  Run "cmake --help-policy CMP0046" for policy details.
  Use the cmake_policy command to set the policy and suppress this warning.

  The dependency target "build/Protocol/ServerStats.pb.cc" of target
  "ServerSrcObject" does not exist.
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Generating done
-- Build files have been written to: /home/ongardie/logcabin
[6/156] Building CXX object CMakeFiles/ServerSrcObject.dir/Server/RaftConsensusInvariants.cc.o
FAILED: /usr/bin/c++    -fno-strict-overflow -fPIC -std=c++11 -I./gtest/include -I./gtest -I./build -I./include -I.      -DSWIG -MMD -MT CMakeFiles/ServerSrcObject.dir/Server/RaftConsensusInvariants.cc.o -MF CMakeFiles/ServerSrcObject.dir/Server/RaftConsensusInvariants.cc.o.d -o CMakeFiles/ServerSrcObject.dir/Server/RaftConsensusInvariants.cc.o -c Server/RaftConsensusInvariants.cc
In file included from Server/RaftConsensusInvariants.cc:18:0:
./Server/RaftConsensus.h:24:38: fatal error: build/Protocol/Client.pb.h: No such file or directory
 #include "build/Protocol/Client.pb.h"
                                      ^
compilation terminated.
ninja: build stopped: subcommand failed.

Maybe @TigerZhang's newer cmake version makes a difference.

I did get a successful ninja -j5 build after making these changes:
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 2d5391d..4b7de53 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -174,6 +174,7 @@ set(SERVER_PROTO_FOR_STORAGE_TOOL_SRC
 set(SERVER_PROTO_SRC
     build/Server/SnapshotStats.pb.cc
     ${SERVER_PROTO_FOR_STORAGE_TOOL_SRC}
+    ${PROTOCOL_SRC}
     )

 set(STORAGE_PROTO
@@ -184,6 +185,7 @@ set(STORAGE_PROTO
 set(STORAGE_PROTO_SRC
     build/Storage/SegmentedLog.pb.cc
     build/Storage/SimpleFileLog.pb.cc
+    ${PROTOCOL_SRC}
     )

 set(TREE_PROTO
@@ -381,7 +383,6 @@ add_library(ServerSrcObject STATIC
     ${SERVER_SRC}
     ${SERVER_PROTO_SRC}
     )
-add_dependencies(ServerSrcObject ${PROTOCOL_SRC})

 add_library(StorageSrcObject STATIC
     ${STORAGE_PROTO_SRC}

But I don't know how much wasted compiler effort this might be causing.

@ongardie CMake shipped a protobuf module.  That module should work well and efficiently.
And I guess I know why @johnzeng was trying to write an ad-hoc protobuf compiling command for logcabin. The shipped protobuf module doesn't work with our protobuf importing manner, ex:
import "build//.proto"
I modified all these imports and removed the leading "build/" in my forked repo. But there are a couple of modifications needed for .h/.cc files, for header file including.
I agree we can go with @johnzeng's version at this stage. Nothing changed, just a new CMakeLists.txt file added.

@ongardie Including these files into SERVER_PROTO_SRC and STORAGE_PROTO may fix the error, but I believe make them as a target which is built before these two object will be better.
Another thing is about copying proto files to build and including proto files from build. I don't know why you did that before, looks like scons won't work if you don't do that. So I just kept them. If you think changing these codes is acceptable, it will be much easier to build.
@TigerZhang For cmake v2.8.7, cmake always generate the build files beside the cmakelist.txt so I didn't realize that the cp command will result in an error. I am looking for a better solution.
➜  logcabin git:(feature/cmake) ✗ mkdir compiling
➜  logcabin git:(feature/cmake) ✗ cd compiling
➜  compiling git:(feature/cmake) ✗ cmake ..
-- The C compiler identification is GNU
-- The CXX compiler identification is GNU
-- Check for working C compiler: /usr/bin/gcc
-- Check for working C compiler: /usr/bin/gcc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Configuring done
-- Generating done
-- Build files have been written to: /home/johnzeng/logcabin

In your pull request description you gave some bad advice to do an in-tree build:
cmake CMakeLists.txt
make

It is much better to do an out-of-tree build so you do not dirty up the source tree with build files, and to use separate output directories for each build type.  This makes building exactly what you want easier to do.  You can also use cmake to run the build in a platform-independent manner that will work on all platforms:
mkdir ../build-Debug
cmake -DCMAKE_BUILD_TYPE=Debug -DCMAKE_INSTALL_PREFIX=<some dir> ../logcabin/CMakeLists.txt
cmake --build . --config Debug --target install

Note that on Windows, setting CMAKE_BUILD_TYPE when running cmake doesn't do anything, as you select the build type when building; however on Linux you set the build type while running cmake.

It would be advisable, before merging this, to:

[required] Have the cmake build work in Travis CI.
[desired] Add Appveyor support to prove Windows builds work too.
[optional] add codecov.io support so we can see what kind of code coverage this project provides as part of build and test.


Add Common Resource Dropdown Component

Example:

/assign @SanjalKatiyar

Few functionalities that can be added:

LoadingInline component untill resources are loaded and error in case of loaderror.
A filtering prop, which will filter data before creating dropdown items.
If we are using this component as a StorageClass dropdown as well, then it should have one more functionality of pre-selecting default StorageClass if any initial selection is not provided by the parent component (if this functionality is not needed we can skip it and can make a new FC for SC dropdown instead).

Few functionalities that can be added:

LoadingInline component untill resources are loaded and error in case of loaderror.
A filtering prop, which will filter data before creating dropdown items.
An initial selection prop, if we want any dropdown item pre-selected.
This and the 4th one is the same. You can implement 4 using the above prop.
If we are using this component as a StorageClass dropdown as well, then it should have one more functionality of pre-selecting default StorageClass if any initial selection is not provided by the parent component (if this functionality is not needed we can skip it or can make a new FC for SC dropdown as well).

/lgtm

/test odf-console-e2e-aws

/test odf-console-e2e-aws

/test ci/prow/lint

/test lint


ciao-controller: report errors properly when setting logDirFlag value

If logDirFlag fails to set, we should report the error and exit.
If it does not fail to set, we should not report an error.
Fixes: #1552
Signed-off-by: Kristen Carlson Accardi<EMAIL_ADDRESS>

Coverage decreased (-0.008%) to 65.451% when pulling 65be72aca9505f38b5a0ebba25a391bccd049959 on kaccardi:topic/issue-1552 into 46d6a0d111822457e335bde4175e5303c74493e9 on ciao-project:master.


Online/Offline Issues

My bulbs are continually losing connection in homebridge. I tried messing with config.js "lightOfflineTolerance" and "resendMaxTimes" which resulted in a minor improvement. I know its not an issue with the bulbs themselves as the lifx app controls them fine even when they appear offline in homebridge.
Any ideas on how I could fix this?

@KiwiAs sorry I somehow missed this. I'd suggest posting an issue on node-lifx. I'm basically exposing the bulb functionality via that module, hopefully Marius might have some ideas.

Hello @devbobo  I would like to ask something about your code. Keep in mind that I'm new in this and I'm not capable of doing it myself so I would like to have your thoughts about that.
First when I install homebridge-lifx-lan everything was working fine, I have two bulbs, I could do everything we could do by Siri. But after sometime I realised my bulbs were having online/offline issues.
Sometimes I was asking siri to do something, he would answer me that it was done, but my bulbs were in the same state. I tried to know why and I finally discovered the problem.
First I have to give you more informations about my installation.
So I have a raspberry pi 3 with everything install (homebridge and lifxlan), I have an iPhone 4S as a hub for my flic buttons for my lifx bulbs. I also have an iPhone 6 and iPad air that I use for Siri. On my Lifx ios app I set schedules to turn on my lifx on sunrise, turn them off 1 hour after, turn them on at the sunrise and turn them off 2 hours after.
So after experiencing those issues that I thought the connection between siri and my bulbs were off I had to reboot my raspberry or, turn on or off my wifi on the iphone 6 or ipade air ( the one I was using at the moment with siri) or, open the Home ios app, to be able to command my bulbs with siri again.
So I had to know why I was having those issues randomly in time. And yesterday I figured it out. It was because the status of the lights changed.
So for exemple:
My lights are off and I turn on my lights with siri, and after a while I turn them back off, so until here everything works fine, but, if I use my flic buttons or if a shedule on the lifx app change the status of my lights for exemple to turn them back on, if then I ask to siri to turn them off it wouldn't work even if siri tells me that they are off because the last status on the lifxlan was "lights off". But if I turn them off with the flic button for exemple, and then ask siri to turn them on it will work again because, the actual status of the lights would be equal again with the last status on the lifxlan.
Another exemple:
I turn my lights to the ambiance "film"(lights blue)  with siri -> lights on and blue
I turn my lights white with the flic button -> lights on and white
I now I ask to siri to turn the ambiance "film" -> lights stays white and siri says "ambiance film on"
To make siri work again without rebooting anything or turning on/off the wifi I have to:
Turn the lights blue (ambiance film) with the flic button -> lights on and blue
Now the status on lifxlan is again équal at the actual lights status so the commands with siri will work again.
I don't know if my explainations were clear, I hope so.
But to fix this problem, it would need to save the actual status of the lights on the last status of lifxlan before siri send the command we ask, like this the lifxlan status would always be the good actual one, and not the last status that worked with lifxlan, and who changed in between if we used something else than siri to change the status.
Thank you for your time and sorry if I made some mistakes writing this.
Do you think it would be possible to get the actual status on lifxlan before sending the command we asked to siri instead of lifxlan only checking the last working status?

@helder14 try version 0.2.0 that I just released. I tried to reproduce your issue using this version and I found that scheduling lights to turn on...and then turn them off with siri works perfectly for me.

Hello @devbobo, thanks for the answer, I just updated it and I tried with the schedules on the lifx app to turn on the light then turn it off with siri and it didn't work, tried with the flic buttons and the result was the same, still have to come back to the last state saved in lifx-lan before being able to control it by siri unless I get it back to the last saved state in lifx-lan , by the methods I already wrote, and also if I turn on the lights by a schedule then trying with siri, doesn't work but if I ask to siri to turn it on ( lights are already on by the schedule) and then turn it off then it work, because the state came back as the last one in lifx-lan even if I use siri for it.
Hope my explainations are clear.

@helder14 what version of Homebridge are you running ? Which specific lifx bulbs are you using ?

@devbobo homebridge version 3.10.10 with node version 7.2.1, I think that just before reinstalling homebridge I was on the 4.3.3.
My bulbs are the very first ones, the GU10, I think they don't even sell them anymore, at least I don't see them on their website.

I am having this exact same issue.  My bulbs continuously disconnect and reconnect.
For the first few weeks, things had no issues, similar to how the OP described.


spirv-val: Conditional Branch without an exit is invalid in loop header

From 2.16.2, for CFG:
Selections must be structured. That is, an OpSelectionMerge instruction is required to precede:

    an OpSwitch instruction

    an OpBranchConditional instruction that has different True Label and False Label operands where neither are declared merge blocks or Continue Targets.

I don't have approval permissions but this looks correct to me.

I agree with your interpretation of the spec, but I don't remember discussing this specific case in Khronos internal SPIR issue 115. I'm attempting to double check the Alloy model that was recently developed to see what was tested there.

I went back and did some digging and sadly neither the issue nor the meeting minutes were particularly informative. :weary: I do remember there being a discussion and that I pushed for the current rules. I don't remember what all else was said and I didn't bother to go dig up a recording.

@cmarcelo have you tested this against CTS by chance? I assume it's ok, but I know LLVM would like to generate code like this sometimes.

Yes, we tested it against the CTS as well as a large pile of additional tests from the fuzzing folks.
As far as LLVM goes, you can get exactly the same thing by translating:
OpLoopMerge %merge, %continue
OpBranchConditional %a, %b

with
OpLoopMerge %merge, %continue
OpBranch %c
%c = OpLabel
OpSelectionMerge %continue
OpBranchConditional %a, %b

and let the early merge logic take care of the rest.  It's exactly 3 more SPIR-V instructions.  I don't think this will hurt LLVM's ability to generate SPIR-V.  The difference is that we now explicitly have two different constructs: a selection and a loop, instead of a loop that's also kind-of a free selection.

CC: @Jack-Clark

I believe the VS2019 failures are due to this being an older branch. Could you please rebase this PR?

Rebased.

That's odd... I'll check what's up.

@alan-baker is there a way to see the details of the "CI-ubuntu-clang" runs?

Nevermind, managed to load other runs results here. The issue seems to be with fuzzer, I'll look into that.

When the message is "Kokoro build finished" it generally indicates an internal error in the CI process. I try to retrigger those builds when I see them.

@alan-baker there were a few Fuzz internal tests that were assuming an initial state invalid. I've added a separate patch to this PR to fix them. Could you trigger the builds again?

For the record: I've tested by enabling -DSPIRV_BUILD_FUZZER=ON (that's not the default, which is why I've missed before).


Interactive Mobjects in Manim

Motivation
Having sliders, textbox, checkbox, etc will speed up the development process of videos and it can also help in some videos that include explanations of how things change when some parameters are tweaked.
Example

( Source code of the above interactive is added in example_scenes.py )
Uses

It can be used during development purposes for tweaking parameters and seeing the changes live.
It can also be used for explanation videos that consist of tweaking parameters.
For videos, instead of mouse and keyboard, you can change Interactive Mobject Values using the set_value method.
Like ValueTracker, you can add updaters to other mobjects which changes mobject state using interactive mobjects get_value method.

Files Changed

manimlib/mobject/mobject.py

Added event handlers methods and "listen_to_events" config in Mobject Class.

manimlib/scene/scene.py

Added calls to event handlers of Mobject whose "listen_to_events" property is True.

manimlib/mobject/interactive.py

Added some interactive Mobjects in this file.
This file includes

MotionMobject (This Mobject can be dragged to any location on-screen)
Button (You can pass any Mobject associate with it an on_click event listener)
ControlMobject (It extends ValueTracker Mobject and is base for other controls below)
EnableDisableButton and Checkbox (It stores bool value and toggles it on press)
LinearNumberSlider (It stores number value and can be changed using slider)
ColorSliders (It is a Group of 4 Sliders for RGBA and one preview box)
Textbox (It stores string value and can be changed by clicking on textbox once to activate it and typing)
Control Panel (It can take Mobjects and put it in a drawer on the top left corner which can be dragged down as in the example)

manimlib/utils/space_ops.py

Added one space util method used for LinearNumberSlider Mobject.

manimlib/imports.py

Added manimlib/mobject/interactive.py import in global imports.

example_scenes.py

Added the above example source code in this file.

@3b1b, I've submitted another pull request to address this concern
Link of pull request: https://github.com/3b1b/manim/pull/1324

@3b1b, I've submitted another pull request to address this concern
Link of pull request: https://github.com/3b1b/manim/pull/1324

@3b1b, I've submitted another pull request to address this concern
Link of pull request: #1324

@3b1b and @TonyCrane, Since the shaders branch is merged into the master branch, I've submitted another pull request for the master branch.
Link of pull request: https://github.com/3b1b/manim/pull/1326

@3b1b, I've submitted another pull request to address this concern
Link of pull request: #1324

@3b1b and @TonyCrane, Since the shaders branch is merged into the master branch, I've submitted another pull request for the master branch.
Link of pull request: https://github.com/3b1b/manim/pull/1326


feat: add missing api endpoints

Adds the rounds api endpoints.
Adds the transactions/fees endpoint.
Refactors the node/fees function so that it accepts an optional days argument.
@ItsANameToo the project file project.pbxproj needs to be adjusted to include the new files for the Round API.

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[x] Refactor
[ ] Performance
[ ] Tests
[ ] Build
[ ] Documentation
[ ] Code style update
[ ] Continuous Integration
[ ] Other, please describe:

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Does this PR release a new version?

[ ] Yes
[x] No

If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:

[ ] It's submitted to the develop branch, not the master branch
[x] All tests are passing
[x] New/updated tests are included

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.
If no reviewer appears after a week, a reminder will be sent out.

Any more endpoints missing that should be added? So we can wrap them up in a single PR.

Not that I'm aware of.

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.
Thank you for your contribution!

Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days.

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.

This shouldn't have a tier tag, should it @faustbrian ?

Take it 🔫


Knowledge base citation source links occasionally blank

Occasionally the Bedrock KB LambdaHook code resolves an empty string for the title to use in the link for a citation (sources) URL.

Fixed in v0.2.0


Fix examples on question page pattern

This adds:

closing <div>'s for  <div class="govuk-o-width-container"> on two examples
corrects indent of example code
Swaps a <label> with an <h1> for a <legend> with an <h1> (and hidden <label>) on postcode example (this is probably what it should have been from the start)

You can preview this change here:
Built with commit 3563ed499903933c82805aa7d9d2f2c0b5e6dbb2
https://deploy-preview-178--govuk-design-system-preview.netlify.com

Sorry, just noticed this also needed to be changed on the postcode example too.

@36degrees This is now a bit of a different PR. So will need a new review.


added unique char solution

Looping through a list of characters, All printed items are shown as their ascii character(s) in a list.

this is my first open source pull request

Interesting! Thanks :D


feat(cli): support for transformers

fix: #1369

Can we have some tests for it? Thanks

Can we have some tests for it? Thanks

Please review again

@wkeylin BTW, Can you take a look at this pr #1602 ? maybe merged together.


GUI: Disable "stereo orientation" when downmixing enabled

[ ] If you are a maintainer (only @nyanpasu64 at the moment), make sure to edit the changelog if needed. Otherwise, a maintainer will edit the changelog.

Fixes #341.
Rename "stereo orientation"?

Stereo layout?

Codecov Report

Merging #345 into master will increase coverage by 0.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #345      +/-   ##
==========================================
+ Coverage   77.55%   77.72%   +0.17%
==========================================
  Files          26       26
  Lines        3689     3691       +2
==========================================
+ Hits         2861     2869       +8
+ Misses        828      822       -6

Impacted Files
Coverage Δ

corrscope/gui/view_mainwindow.py
97.54% <ø> (ø)

corrscope/gui/__init__.py
45.73% <100.00%> (+0.32%)
:arrow_up:

corrscope/gui/model_bind.py
78.74% <0.00%> (+1.49%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c7b66b...a5341be. Read the comment docs.


Updater check-in-use command should output JSON instead of exit code

Instead of using a weird exit code. Exit code is hard to determine cross platform and JSON is more helpful. Also is probably a good idea to avoid exit codes unless there was a real error.

@maxtaco

Can you give me some more background on this change?

Yeah.. the updater will call this to see if keybase is in use... it returns:
{
  "in_use": true
}

if in use (or false).
Before I was returning a non-zero exit code if was in use but exit codes aren't really cross platform (windows) so am doing this instead.

👍 then!


Parking Map

Why haven't we done anything with @josephlei's parking map?

That's a very good question. @josephlei?

Apparently @josephlei has posted stuff publicly:
https://crosskonaftw.cartodb.com/viz/ee4d102c-ff1a-11e4-96a4-0e0c41326911/public_map
https://crosskonaftw.cartodb.com/viz/6adf39d0-fd09-11e4-a589-0e9d821ea90d/public_map


kind istio-ingressgateway LoadBalancer pending?

Bug Description
istio-ingressgateway always pending ?
╰─○ curl http://<IP_ADDRESS>:31659/productpage
curl: (7) Failed to connect to <IP_ADDRESS> port 31659 after 4 ms: Connection refused

Version
╰─○ kind version
kind v0.11.1 go1.16.4 darwin/arm64

╰─○ istioctl version
client version: 1.12.9
control plane version: 1.12.9
data plane version: none

╰─○ kubectl version --short
Client Version: v1.22.5
Server Version: v1.19.11

### Additional Information

_No response_

### Affected product area

- [ ] Docs
- [ ] Installation
- [ ] Networking
- [ ] Performance and Scalability
- [ ] Extensions and Telemetry
- [ ] Security
- [ ] Test and Release
- [ ] User Experience
- [ ] Developer Infrastructure
- [ ] Upgrade
- [ ] Multi Cluster
- [ ] Virtual Machine
- [ ] Control Plane Revisions

### Is this the right place to submit this?

- [X] This is not a security vulnerability
- [X] This is not a question about how to use Istio

you need a loadbalance provider, please check metallb

metallb or update cluster ip to node port

metallb or update cluster ip to node port

i think node port is good ideas


CLOUD-900 No valid JSON value after a successful installation with Am…

…bari

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1502/


feat: support AsyncAPI 2.5.0

Description
Support AsyncAPI 2.5.0.
Related issue(s)
Part of https://github.com/asyncapi/spec/issues/830

/rtm


fixed switch is always flipped but with arg parse

so that 'default=true' flag means if you don't set the flag fefault its value to true but then when we set the flag we set its value to true so there was no possible false condition

Resolves https://github.com/f8al/DNSrazzle/issues/24


Fix defibs resetting rot timer + slimes not having perishable

About the PR

Defibs reset rot timer because they force a state change even when it gets reverted immediately. Very sad!
Slimes weren't perishable which i know people pretended like was some cool species trait but was honestly just a really weird niche that invalidates a core part of medical. I'm also 99 percent sure it was a bug.
Why / Balance

Being able to reset rotting without actually reviving people means that you can stop rotting permanently with no tools. Just zap a person once every 10 minutes and boom no more rot at no cost.
Rotting is pretty important to medical gameplay and revival at a whole and shouldn't be trivially subverted. Slimes being able to subvert rotting by merely existing is really strange and honestly shouldn't be a thing. They're the only player species with this feature and the only thing it enables is for Med to perform a hail mary revival half an hour after they die, which really shouldn't be happening.
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl:

fix: Fixed defibrillators resetting the rot timer when zapping a dead body.
fix: Fixed slimes not rotting.

isn't slimes not rotting a temporary stand-in for the stockholm syndrome 13 feature of spimes regrowing from their brain

no its a bug that never got fixed

isn't slimes not rotting a temporary stand-in for the stockholm syndrome 13 feature of slimes regrowing from their brain

if it is then it still sucks and shouldn't be in the game.

inb4 someone says they cant revive anyone now because skill issue, morgue exists to prevent rotting as do body bags

Slimes not rotting is intentional. It was introduced in #12016 and was also intentionally kept when other species (namely diona and moth) were given the component after formerly missing it. I think it’s a good upside for a species that doesn’t have many and also thematically makes sense.

I think it’s a good upside for a species that doesn’t have many and also thematically makes sense.

It would be more understandable if they had some other tradeoff for their death mechanics. As it stands, simply having no permadeath is really strange. If someone wants to add that, be my guest, but in the meantime, they shouldn't just have nothing.

It would be more understandable if they had some other tradeoff for their death mechanics. As it stands, simply having no permadeath is really strange.

I mean, they have a tradeoff in that they take more barotrauma damage, take damage from water, and take more cold, slash, and pierce damage. Their only other real upside is breathing less & being immune to nitrous oxide (both of which can be negated incredibly easily) and taking less blunt, so I don't think not rotting is really out of place. They can also still be permakilled through gibbing, though admittedly the very low blunt modifier makes that difficult, wouldn't mind seeing that raised, but the point is that it isn't impossible.
Also the perishable component probably shouldn't be on base species anyways since I could see a new species being implemented that doesn't rot (like plasmamen or something idk)

I'm not a fan of this change because there's cases where your medic or someone else might find someone stuck in a locker doing maintenance dives that were dead for, say 8 minutes. The defib was able to give medical a chance to save the person (if they stuck around). The proposed change will increase the amount of rotting individuals in cases outside of medical control.
Can this be changed to delay rot by say, 30 seconds instead but keep the timer? It would allow medical to still have a chance to save people close to rot instead of having people rot on the bed while topicals are being applied.

we have bodybags and morgues for this exact use case

we have bodybags and morgues for this exact use case

This probably should be explained somewhere then, because I don't believe many medical players use either for that at all.

they dont use it because the defib bug is super overpowered lmao

then make slimes longer time to start rotting

lmao???

This probably should be explained somewhere then, because I don't believe many medical players use either for that at all.

this is because people just defib corpses without scanning so they dont rot, if the bugs fixed they have to use the actual rot prevention methods

Two-pronged attack to ensure the rot will consume us all ahhhh
Slimes not rotting is a feature so describing it as a bugfix is odd. Reworking is preferable since rot sucks (see below):
Being able to reset rot timer was a miracle since:

Rot timer is way too short at 10 minutes; dragging bodies out of maints may take like 3 minutes on its own, 3 minutes waiting time due to secoff patients meeting spiders, 1 minute to find defib, 5 minutes for intern to find topical meds before they realise you rotted

Deadchat gets filled with salt rather than intellectual discussions about mothroaches or clown ODing on meth
2.1. I get salty when interrupted from my bartending button-mashing adventure and rot in medbay, forcing me to either leave server (dishonourable) or wait 30 minutes to round to end (better but bad)

Current ghostrole selection is very limited, weak incentive to ghost gang

Cloning or the rot-resetting drug aren't in, and borging is its own mess (assuming sci isn't irradiated to hell or cargo isn't poor/throngled)

Rot at low temperatures is very finnicky, seems to occur anyways in spaced areas - at least you seem to stop taking barotrauma damage on death

Bodybags take up space (4 body bags to one defib), are surprisingly hard to find outside of morgue and medical, and asking for them as non-medical is powergaming - then people forget they exist when they're needed
6.1. Non-perishable containers such as freezer crates and upright fridges are neither marked or replaceable, upright fridges seem to only work when anchored(?)

Medical is boring enough as it is without also fighting off inevitable entropy with electric shocks
7.1.  Probably because rot implies negligence.
You still got the problem of actually finding a corpse within to bodybag in 10 minutes (morgue only has 5 bags and risk your patient being dragged off to morgue), low temps not working to pause rot, and non-perishable storage components having to be deduced off github

print more bags

take bodies that are in bodybags and put them in morgues

Rather than arguing the current state of rot here, I will probably open an issue about it

What there really needs to be is a way to reset rot timers.  Especially of you HAVE THE BODY in medical.

there is, its called heal until 194 damage and defib

What I'm really gonna miss was treating patients with 200+ rads as they could metabolise arith briefly before dying again
Again, I'll bring this up in an issue rather than a bugfix pr

there is, its called heal until 194 damage and defib

tell this to the two unlucky folks that got zapped ONCE by an electrified door and fence and got 2k and 800 shock damage respectively during the first part of the 24h event on Miros


Does this support chunking based on MTU?

If not, what can I do to help support it?

The library doesn't currently support chunking either on the write or read side, although on the read side it's possible for the application to recombine chunks itself. Adding proper chunking support would be pretty straightforward (see the todo here) and I'd be happy to walk you through the code if you're interested.

How would the application implement chunking support itself? I can`t see how I can give a offset for reading past the MTU limit from a characteristic...


Remove the circular dependency between pipeline & runner

R: @vikkyrk

Coverage increased (+0.003%) to 69.975% when pulling f3c5fcfc575e849f34cbbf30e2f54e295d26672b on aaltay:circ into 456dcc11708d37a3cfba57a3f6bda01e08275a66 on apache:master.

retest this please

retest this please

retest this please

hcatalog tests are failing, not related to this PR but it fails before the Python tests could run.

retest this please

Coverage decreased (-0.01%) to 69.962% when pulling f3c5fcfc575e849f34cbbf30e2f54e295d26672b on aaltay:circ into 456dcc11708d37a3cfba57a3f6bda01e08275a66 on apache:master.

R: @charlesccychen


What's the point to new Curl($base_url) if it's not used?

What's the point to accepting a base URL in the constructor if it's never used? Why can't I just do this?
$curl = new \Curl\Curl($endpoint);
$response = $curl->get('/request-uri', [
	'someParam' => $myParamValue
]);

I noticed that the URL is always overwritten if/when I ever do a ->get() since that method accepts a URL and always calls ->setURL() which then overrides ->base_url property. Why ever even provide a base URL? I know Guzzle handles this sort of syntax.

Hi. Base url is meant to be set for all the subsequent calls with only the data being passed to the follow. This is how it would be rewritten:
$curl = new \Curl\Curl($endpoint . '/request-uri');
$response = $curl->get([
    'someParam' => $myParamValue
]);

Thanks for the suggest. Ticket #347 created.


v0.5.0 release

PRs: https://github.com/projectmesa/mesa-geo/milestone/2?closed=1

[x] update history and version number
[x] release after Mesa v1.2.0

Release tagged at GitHub and uploaded to PyPI. Closing the ticket now.


getCurrentAccessToken() after app restart return null

After login FBAccesToken returns with no problem. If I refresh metro FBAccesToken exists, but if I kill the app and call getCurrentAccessToken() after app restart, it returns always null on IOS. Maybe there is an issue with persisting accessToken

Hi there! This lacks any sort of detail needed to help.
Imagine you are an extremely busy engineering manager. You have a direct report that comes to you with this. What do you do, drop everything to ... what exactly? Please do the prep work you would want done, it will help tremendously
https://stackoverflow.com/help/how-to-ask
https://stackoverflow.com/help/minimal-reproducible-example


editable text after modal display

Input text should not be editable after modal appearance.

Added flag that would represent if modal is displayed:
let isModalVisible = false;
developed logic to prevent text input from user in case of "true" for isModalVisible.


Group assignment lost when splitting locomotives from each other.

Describe the Bug
In TrainGroups version 1.0.3.  Splitting a train with a locomotive on each end will assign the group to one half but not the other.
Normally if you are only shunting manually, this is not a problem.  The group gets assigned to the whole train when you couple something to the half that was assigned the group.  But Multiple Unit Train Control also uncouples, deletes and replaces locomotives automatically, which causes TrainGroups to delete the data before recoupling.
When MUTC replaces a locomotive, the following events occur:

MUTC decouples the target locomotive from the front and rear stock.
The target locomotive becomes its own train ID and is the subject of the first on_train_created event(s) triggered by the decoupling(s), because it was the target of the "decouple" command.
In the first on_train_created event, TrainGroups moves the group data from the original train ID to the target locomotive's train ID.
The rest of the train ends up in either one or two remainder trains, and each piece can contain a mix of wagons and/or locomotives, triggering on_train_created a second time.
In the second on_train_created event, TrainGroups does not have any data associated with the original train ID, so the remainder trains do not get assigned a group.
MUTC deletes the target locomotive.
TrainGroups deletes the group data that was assigned only to the target locomotive.
MUTC creates the replacement locomotive and couples it to the remainder train(s).
TrainGroups has no group data assigned to the remainder train(s), so there is no group assigned to the new train.

Unfortunately, there is no way to tell from on_train_created whether there was more than one train created by the same event.  That's why I suggested saving it for on_tick.  With careful coordination, you can subscribe when an entry is added to the checking queue and unsubscribe when the checking queue is empty.

Aw man. I guess on_tick is necessary after all.
I used to conditionally register on_tick, but after finding a desync that would have been annoying to fix, I decided to not do that any more. So it just runs all the time.
Luckily, calling pairs() on an empty table has practically zero performance impact, so it's fine.

Yeah, I do conditional registration in MUTC.  Took some care to make sure that the event registration always matches the size of the queue.  That's also what on_load is for.

Thanks for fixing this!

I also updated it to remove the requirement for locomotives for a train to have a group. This matches the base game's behavior. If you make a 1-1 train, decouple it, then couple a new locomotive to the cargo wagon, it will take the group from the cargo wagon.
Will this be a problem with MUTC?

That should work well.  There's no harm setting the schedule for a train with no locomotives.


More intro docs

Hi! I have strong opinions about example code :) I've tried to make sure everything in hardware-check is explained with a comment (or just removed).
I was a little confused that we Box'd the Result that comes from the wifi() function, because then it's hard to unwrap. Should it return a Result<Box<Wifi>> perhaps? I couldn't tell how big Wifi itself was.

OK, so it looks like WiFi isn't very big - when you drill down it mainly holds Arcs, and one raw pointer.

love the additions! as to the Box, it's probably just a copy paste error. I don't see any reason to keep it.


declaration

declaration shadows a local variable

The purpose of the code in this repository is just to match what is in the YouTube video, so I don't accept pull requests.
I see what you mean regarding the variable i being 'shadowed', though that said it won't effect the algorithm in this case, as the first couple for loops use 'i' in their own block scope without effecting this 'i' local variable of the function.


DOC-8367 added language for immutable backups

Addresses DOC-8367:

Currently our docs have no language around immutable backups and we only refer to this through object locking. I've added this for search visibility

lgtm. Assuming this will show up in the search?

Yes it should. I'll confirm upon merge

Also, I didn't see it in the diff, but I'm assuming we're chaning the title fom --> Object locking to "Immutable storage"

Yes! title change is here - https://deploy-preview-17495--cockroachdb-docs.netlify.app/docs/stable/use-cloud-storage#immutable-storage


Environment inside extension

Obviously in development, my URL for anything going back to my App is a named tunnel. But when I deploy this exact same code to production, my URL going back to my App is now a cloud URL.
What is the secret sauce inside the extension (purchase option in my case) to know whether I'm dealing with a local development call or a production one? There is no env or process I can query apparently. What is the technique?

When I console log process it throws an error that process does not exist. Hence my question.

@resistorsoftware could you try process.env.NODE_ENV specifically and not the process object?

It is so weird that I can just use this:
const environment = process.env.NODE_ENV
And it works. The fact that process is nothing, and process.env is nothing, but process.env.NODE_ENV actually resolves to a string just crushes my pea brain... I love ESBuild. Fastest, best tool in the JS world for me.

Sorry to re-open the discussion while it's already closed, but I need clarification about the "solution" provided.
If we need to setup an APP_URL constant according to the stage we are running on (development , staging, production),
the only way to setup is to hardcode APP_URL for each stage on our code.
Is that a satisfying solution for you ? I believe that we could have a solution where we can use the process API in dev mode, and in production mode we can also read ENV variables at BUILD time. Which is totally fine and doable I guess.
Am I missing something ?

hey, i search for this solution also, how can we use process env on CI/CD deploy

@michaelr231 use the value of process.env.NODE_ENV? Why not?

its not working well, i have 3 envs, 3 apps
each app is "production"
and i need point to dev, stage and prod different urls


How to get initial path of the photo

if the image was already saved to on the device, how can i get the path. I want to use this to get the exif info

Hello
not use exif interface.
2 reasons:
google play store not support apps with exif interface in any occasions.
Not all information thas true, for example the rotate state of picture...
in any device get vertical when is horizontal... or get null...
Use magical camera library for obtain the path, please read the
documentation.
Regards
2017-12-06 3:35 GMT-06:00 buelersandra<EMAIL_ADDRESS>
if the image was already saved to on the device, how can i get the path. I
want to use this to get the exif info
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/fabian7593/MagicalCamera/issues/33, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AMua5RCKyf8eCm8IUvTb82VL_vJOQnq8ks5s9l_ngaJpZM4Q3naC
.

--
Fabián Rosales Esquivel
*Analyst and Software Developer *
Frosquivel Developer
If you can dream, it you can do it.
Desamparados, San José, Costa Rica
Mobile: (506) 8346 1166
*GitHub: *https://github.com/fabian7593 https://github.com/fabian7593

<EMAIL_ADDRESS>[image: skype]fabianre7593

The path obtained by magical camera is the path it created for the image and not the original path.am i right?
my issue is i can't set all images from getphoto() to rotate say 270 when i don't know their original orientation else all images will be rotation even the ones with the normal orientation.

The rotate is different with any brands of devices...
Samsung for example have the camera in land scape, on most devices.
But I understand your question, please use this.
magicalCamera.getUriPaths().getUriPathsObject().getRealPath()
And tell me how did it go.

will do ....thanks

Cannot resolve method .getUriPaths()...might be a private method.

I review the code... and yes, I dont have this method public...
Im so sorry, in the next version of magical camera I fix it... but in this moment my recommendation is download the project and add the class manually and modify the class that you needed.

will do...thanks for assistance.

The next version have this new feature


Linkage between select fields reworks and other bugs fixed

Linkage between select fields reworks. It seems when ChangedField  events received from other fields it depends on, it should reRender so its option elements can be updated. I think F7SelectField, F7MultiSelectField and F7RadioField should behavior like this, but some fields like F7TextField don't have to do this. Maybe missing other fields?

newContext created by getOrCreateContext in FSSytem not added into children

BSModal5Base should call modalRenderer.render() when render first time to get correct aroundId. I'm not sure about this, but at least this behavior is consisted with Widget.renderWidget()

All implicit classes extends AnyVal to avoid the cost of objects creation when these implicit conversions occur.

Hey @mizerthilez , thanks for the fixes! :) Just one thing with regards to the fields: in trait F7Field it already calls updateFieldStatus() which should update the field status without needing to rerender the whole field - ideally all elements should be able to do this by default - you can see this working here: https://www.fastscala.com/demo/forms/server-side-update (please try to change the "random seed" and see as all fields bellow update their values)

Hey, I update new version, but it still breaks Linkage between select fields.
In "Create a form" page, if Province field has been changed to P3, City fields' options need to be C31, C32, C33.  But them do NOT updated. Linkage between them breaks! You can see the following snapshot.
I think the problem is updateFieldStatus() only update 'currentValue‘, not its options.  F7SelectField, F7MultiSelectField and F7RadioField  all have the same issue.

Hey @mizerthilez , indeed I looked into it, and now I believe it is working correctly 👍


emoji: Run generate_emoji_names with up-to-date data.

This data comes from node modules (cldr-annotations-modern, cldr-annotations-derived-modern, and emoji-datasource-google)  which have been updated since the last time we run this script.

Note that this removes a few aliases:

:black: → :black_cat: 🐈⬛
:burn: → :heart_on_fire: ❤🔥
:flag_turkey: → :flag_türkiye: 🇹🇷
:leftward: → :leftwards_hand: 🫲
:legume: → :beans: 🫘
:light_blue: → :transgender_flag: 🏳⚧
:pink: → :transgender_flag: 🏳⚧
:rightward: → :rightwards_hand: 🫱
:vegetable: → :bell_pepper: 🫑

which seems basically fine (but I’m generally apathetic to the details of the particular colon-strings in a system that should not be based on colon-strings).

Ah yes -- I forgot to mention it does this, and it does it because of the introduction of emoji which share those aliases.

flag_turkey was a canonical name, and not an alias, and was renamed.

Yeah, those removals seem fine, merged, thanks @evykassirer!

Great!
Adding breadcrumbs to help make this easier to find in the future by search or by links: this gives us emoji from Unicode 15, making it a sort of next round after #19371 / #22067.

:light_blue: → :transgender_flag: transgender_flag
:pink: → :transgender_flag: transgender_flag

These are a great example of where our "alias" model of emoji naming has served us poorly — these make no sense as alternative names. So dropping these aliases is for the best.
When we someday switch to using CLDR (#18121), we'll have alternate search terms instead of alternate names. As search terms, "pink" and "light blue" are good matches for the trans flag, and indeed CLDR has them.


it is impossible to delete several FW rules at once (api.DeleteFirewallRules)

Expected behavior
the function should delete several firewall rules by the IDs passed to it
Current behavior
when passing multiple IDs to a function, an error occurs
error from makeRequest: HTTP status 400: content "{\n  \"result\": null,\n  \"success\": false,\n  \"errors\": [\n    {\n      \"message\": \"invalid field value: a2982f3dd8df442*****90da937e7b99,38997b32*****8f68e131986d1ab51a1\",\n      \"source\": {\n        \"parameter\": \"id\"\n      }\n    }\n  ],\n  \"messages\": null\n}\n"
Steps to reproduce (for bugs)
func main() {
	api, _ := cloudflare.New(apiKey, apiEmail)

	zoneID := "e5a692d6a2d090b8ee8efd6*****"
	firewallRuleIDs1 := []string{"7e50436a45fa4d68a8157517e*****" }
	firewallRuleIDs2 := []string{"e037c9d76a31459b88fc04c3e*****", "8623c65269c3445596f9e9be0b****" }

	err := api.DeleteFirewallRules(zoneID, firewallRuleIDs1)
	if err != nil {
		fmt.Println(err)
	} else {
		fmt.Println("Deleted")
	}

	err = api.DeleteFirewallRules(zoneID, firewallRuleIDs2)
	if err != nil {
		fmt.Println(err)
	} else {
		fmt.Println("Deleted")
	}
}

response:
go run cmd/test/test.go

Deleted
error from makeRequest: HTTP status 400: content "{\n  "result": null,\n  "success": false,\n  "errors": [\n    {\n      "message": "invalid field value: e037c9d76a31459b88fc04c3e3*****,8623c65269c3445596f9e9be0b*****",\n      "source": {\n        "parameter": "id"\n      }\n    }\n  ],\n  "messages": null\n}\n"

Looks like your using it as the method intends and the API is documented. @patryk are you able to check if this is still possible?
In the meantime, @PavelvKalinin you may need to loop over the IDs and use the singular version of the method to unblock it.


resolve issue 69 update changeset dependencies

Bumped ember-changeset and ember-changeset-validations

Hi @nmccready, thanks for the PR! I just tested the nested keys feature as requested in #69, and it seems the validations are not working yet (see https://github.com/poteto/ember-changeset-validations/issues/110). I'll merge this anyway since it doesn't break existing functionality.

Thanks


monetizing

The Yelp display requirements state:
"You can monetize your apps and sites to your heart’s content -- we don’t require any sort of revenue share - but don’t create tools for sale that extend Yelp functionality (such as Facebook integration)."
I'm making an app that incorporates bike share locations with local business and I'm using Yelp to provide local biz info. Does that count as "extending Yelp functionality"?
Also, speaking of monetizing my app. I've never done that before. Do you have any advice on how I could go about doing that?

On the monetizing front: There are a bunch of approaches; the most common are including ads in your app, or charging for your app in the Android / Apple / whatever store.
(I'm not qualified to interpret the legalese in the display requirements.)


Add supported browser check

OP#1961

@meejah I agree it's better to check for required features, but for now I'll use the list of browser versions at OP#1961


Update information-barriers-in-teams.md

Information Barriers feature in Teams does not support federated scenarios today. Removing scenario reference to Federation in the documentation as this sets wrong expectations with admins and customers. IB for guest users remains supported and available.

Expanded on the known issues scenarios to make it more clear.

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@scanum - Please help connecting this PR with the technical writer / content publisher so we can get these out. I can share more details / context if required. Thanks.

@anwara-ms PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

@anwara-ms - I have expanded on the known issues we have been triaging for a while now. Please take a look and help merge. Thanks.

@scanum @JohanFreelancer9  I dont see option to merge. could you do it please?

How do I get write access?

@scanum - How can we get this merged? It appears @anwara-ms  is not able to merge.

@scanum Hi. This is urgent. could you please merge this change. I dont have write access.

can you please tell me how can I do it myself. I dont have write access. Do PMs have write access, or merge is always done by doc writing team?

Hi Anwar – If you make a comment saying it is ready, etc. I can do the merge for you.
Does that help?
Kateyanne
From: Anwar Ali<EMAIL_ADDRESS>Sent: Tuesday, November 10, 2020 9:39 AM
To: MicrosoftDocs/OfficeDocs-SkypeForBusiness<EMAIL_ADDRESS>Cc: Kateyanne Unullisi (Aquent LLC<EMAIL_ADDRESS>State change<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/OfficeDocs-SkypeForBusiness] Update information-barriers-in-teams.md (#5979)
can you please tell me how can I do it myself. I dont have write access. Do PMs have write access, or merge is always done by doc writing team?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FOfficeDocs-SkypeForBusiness%2Fpull%2F5979%23issuecomment-724857112&data=04|01|v-kaunu%40microsoft.com|ceed346fbf1948f32c1b08d8859f8312|72f988bf86f141af91ab2d7cd011db47|1|0|637406267431640713|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=MK8u1eBKigNUalzorxH2sDlBynsNJFxrykCgwmi0XFI%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAQD2HUW2D72IYJECL32C263SPF3DLANCNFSM4SS3G3JA&data=04|01|v-kaunu%40microsoft.com|ceed346fbf1948f32c1b08d8859f8312|72f988bf86f141af91ab2d7cd011db47|1|0|637406267431650711|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=VEl3uYoSVgcYp6U1dIOOUqAwmdrjmttszKEo6IYWJcs%3D&reserved=0.


bug(chips): text input in mat-chip-row prevent space key usage

Is this a regression?

[X] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
14
Description
Problem description :
When a text input is used into a mat-chip-row it's not possible to use the space key.
Cause :
Usage of matChipAction in chip-row.html prevent space usage.
Reproduction
StackBlitz link:  https://stackblitz.com/edit/rchveu-hjsuvg?file=src%2Fexample%2Fchips-autocomplete-example.html
Steps to reproduce:

update first code sample from this url : https://material.angular.io/components/chips/examples
add input element under *fruit" binding :
<mat-chip-row *ngFor="let fruit of fruits" (removed)="remove(fruit)">
{{fruit}}

<button matChipRemove [attr.aria-label]="'remove ' + fruit">
cancel

Expected Behavior
Expect to be able to use space key.
Actual Behavior
not able to use space key
Environment

Angular: 16.1.6
CDK/Material: 16.1.6
Browser(s): Chrome
Operating System (e.g. Windows, macOS, Ubuntu): Windows

Nesting inputs like this inside of chip rows isn't supported. If you're building editable chips, you can use either the editable input (example) or project a matChipEditInput.


make-initrd-ng: fix reproducibility problems

Description of changes
The previous find invocation didn't match the root directory, so the root directory's access and modification time wasn't set to a deterministic value and the build time leaked into the output.
make-initrd replaced cpio with bsdtar in #165892 because the former includes the number of hardlinks in the created archive, which depends on the filesystem (and can also be influenced by nix-store --optimise). The same problem applies to make-initrd-ng, so this PR replaces cpio with libarchive's bsdtar.
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[X] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Let's test this on real systems :)


Add lint for 'tmt story'

Resolves #706.

Just noticed that the Node class was also mentioned in the docs, so hopefully the last change, slightly improved the docs ;)


Update changelog for 0.8.0 and add Lerna Changelog

Lerna Changelog allows us to generate a scaffold for the changelog, a list of changes with all the PR and contributor links in place, from labeled GitHub pull requests.
I added the following labels (inspired by Babel's change log which is also made with Lerna Changelog).

tag: new feature: :rocket: New Feature – Features added in this release.
tag: breaking change: :boom: Breaking Change – Breaking changes should be accompanied with a migration guide for users in the change log.
tag: bug fix: :bug: Bug Fix
tag: enhancement: :nail_care: Enhancement – Changes to existing features.
tag: documentation: :memo: Documentation –  Contributions to docs can also be credited in the change log now.
tag: internal: :house: Internal – Any internal house keeping / refactoring / infra change that doesn't affect the public interface of the tools.

Any merged pull request should be tagged with one these labels so it's picked up for change log in the next release. Lerna Changelog also detects which packages were affected by each change and shows this in the log.
This saves a lot of time when doing releases because a large part of the manual work is done automatically. It's still very important to write good descriptions of the changes in the change log, because it's a document meant to be read by humans, not just a list of commits. But having the bulk of the log generated by this tool gives us more time to focus on authoring these descriptions.

@gaearon Could you review that the new format is OK? I can then prepare the release.

LGTM


Add the "align object" tool

This aims to add the feature discussed in #936 and #813
This is a pretty barebone implementation for now (especially UI-wise).
I'm still really new to C#, so i would appreciate any tips if i'm doing anything the wrong way ^^

Right now i'm blocking on two things:

Where should the tool go? It's currently in "Adjustments", but this feels like a weird place to put it. Maybe a new "effects" category should be made?
I'm not too sure what the most intuitive behavior would be for this tool when using selections. Should it use the selection as the "object" to align? Use the selection as the bounding box for the alignment? And in the latter case, how do we deal with non-rectangular selections?

Thanks for looking at this!
I think having either the option to align within the bounding box of the selection, or aligning the selection contents within the image, could be useful. Ignoring the selection seems like the user could just do that beforehand by deselecting?
With implementing this as an effect, I think you might run into challenges with modifying the whole image since the result of your effect will be masked by the selection afterwards (normally, effects are only applied to the selection's contents). So it might be easier to implement it more like the Auto Crop tool if you need a lot more flexibility, or we can figure out the right API for effects to indicate they need to modify the whole image.

Thanks for looking at this!
I think having either the option to align within the bounding box of the selection, or aligning the selection contents within the image, could be useful. Ignoring the selection seems like the user could just do that beforehand by deselecting?
With implementing this as an effect, I think you might run into challenges with modifying the whole image since the result of your effect will be masked by the selection afterwards (normally, effects are only applied to the selection's contents). So it might be easier to implement it more like the Auto Crop tool if you need a lot more flexibility, or we can figure out the right API for effects to indicate they need to modify the whole image.

Indeed, i ran into that exact problem of selection masking the effect a few hours ago :sweat_smile:
I don't think a whole lot of flexibility is needed, an API allowing to just say we want to edit the whole image seems like it would suffice. And i do feel like "align object" fits better under the effects tab than the image tab.
On another note, when trying to implement the selection-related options, the only way i could find to access the selection was with the "rois" parameter, which seems to just be an array of rectangle, so i'm not too sure how to deal with things like a circular selection. Or does that array of rectangle already represent a circle?

Right now I don't think the document's actual selection is passed down through the effect's API (similarly, because the masking against the selection is done implicitly afterwards)
The rectangle list would be a single entry with the bounds of the selection if IsTileable is false, otherwise it'll be a list of smaller sub-regions to process in parallel

That's not too much of an issue for the "align within the selection" option (since we just use the bounds anyways), but it is an issue for the "align selection within the image" option.
That makes it 2 required change for that latter option, when the former should work right now without any API changes.
Maybe i should only implement "align within the selection" for now, and leave "align selection within the image" for a later PR?
Especially since the same effect can be achieved by just copying the selection to a new empty layer the using the align tool.

Yeah, that sounds like a good approach to take 👍

went ahead with it for now, we can always revert the commit if you would rather have it somewhere else

Added tests and took the comments into account

Added tests and took the comments into account Should i also move the feather effect into the object category? Or is that too out-of-scope for the PR?

Thanks! Updating the feather effect category is fine to add into this PR since it's a trivial change


Consider rebinding ctrl+shift+~ to creat terminal with profile in instead of default

after the new version of vscode is supported terminal with profile. we are strongly recommend that we should rebinding the short cut ctrl+shift+~ to workbench.action.terminal.newWithProfile in stead of workbench.action.terminal.new
    {
        "key": "ctrl+shift+oem_3",
        "command": "workbench.action.terminal.newWithProfile",
        "when": "terminalProcessSupported"
    },
    {
        "key": "ctrl+shift+oem_3",
        "command": "-workbench.action.terminal.new",
        "when": "terminalProcessSupported"
    },

We still want as few prompts available for the default keybinding to make it easy to create terminal(s), but the command is available for just this sort of customization.


/Applications/VSCode.app/Contents/Resources/app/bin/code: line 10: ./MacOS/Electron: No such file or directory

VSCode Version: 1.45.0
OS Version: macOS Catalina

Steps to Reproduce:

Write a direnv .envrc that exits with a non-zero code.
Try to launch VSCode on that project directory.

Can you provide minimal repro with detailed steps, I am not familiar with direnv. Thanks!


TNT-41403 Enable AEP mode via edgeConfigId SDK setting

Description
TNT-41403 Enable AEP mode via edgeConfigId SDK setting
Related Issue

https://jira.corp.adobe.com/browse/TNT-41403

I noticed you made aepEdgeService.js. But we don't really refer to anything else as a "service" in the node js sdk up to now. For example, the target.js file has all the executeDelivery functionality within to handle delivery api request/responses. For consistency can we rename aepEdgeService.js to just aep.js or aepEdge.js ?

I wanted to align it with the SDK architecture doc, but sure, let me shorten it to aepEdge.js

Also, I think creating the abstraction at the level you have will work fine (having target.js do delivery api and aepEdge.js do aep). But I wonder if it might be better to separate it the way it was done using the createDeliveryApiMethod function (see helper.js line 597). Currently it conditionally returns an object with an execute method on it. Up till now, the SDK returned either an object that goes to Delivery API or one that goes to decisioning engine. But we can now add a condition to return an aep execution object that is responsible for translating requests/responses to the aep edge api. What do you think?

Right, I considered this option, but it's a bit more restrictive, as we end up with somewhat redundant code paths in the AEP flow, like the HTTP client configuration performed in target.js (setting server host and request headers for Delivery API), which we'll still need to override downstream. So, I opted for a cleaner separation between Delivery and AEP flows..

Right, I considered this option, but it's a bit more restrictive, as we end up with somewhat redundant code paths in the AEP flow, like the HTTP client configuration performed in target.js (setting server host and request headers for Delivery API), which we'll still need to override downstream. So, I opted for a cleaner separation between Delivery and AEP flows..

Fair enough, I think the way you have it will work well.  If we see a reason to refactor to a lower level we can always do it later.


Rendering issue with DEPTH_TEXTURE reading.

Godot version
3.0 ... 3.3.2
System information
Windows 10, GLES 3, Nvidia 1050
Issue description
I'm just reading the DEPTH_TEXTURE and don't expect any changes in the picture. I don't apply the received value anywhere. However, it seems that normals are inverted.

Steps to reproduce
Just comment or uncomment reading DEPTH_TEXTURE.
Minimal reproduction project
depth_buffer_error.zip

Im sorry, i found same issue right now.
https://github.com/godotengine/godot/issues/29206

Thanks for searching existing issues!
Duplicate of https://github.com/godotengine/godot/issues/29206