Try to generate a total report

What changes are proposed in this pull request?
Please outline the changes and how this PR fixes the issue.
Why are the changes needed?
Please clarify why the changes are needed. For instance,

If you propose a new API, clarify the use case for a new API.
If you fix a bug, describe the bug.

Does this PR introduce any user facing changes?
Please list the user-facing changes introduced by your change, including

change in user-facing APIs
addition or removal of property keys
webui

The first coverage data.

The second. I don't run all workflows. So I doubt that the data is an append on the previous one. Next I will rerun all workflows.

The third.

The fourth.

The fifth.

sixth.

seventh.

eighth.

nineth.

tenth.


Replace GitHub classic Personal Access Tokens with fine-grained tokens

User Story
As a Modernisation Platform Engineer
I want to replace our Classic PATs with fine-grained PATs
So that I can continue to adhere to a principle of least privilege
User Type(s)
Modernisation Platform Engineer
Value
In October 2022, GitHub released an update to how Personal Access Tokens can have their permissions controlled. In replacing our existing classic PATs with fine-grained PATs we can restrict their privileges so that only necessary actions they were created to accomplish are achievable using the new permission options.
Questions / Assumptions / Hypothesis
Hypothesis
If we replace our classic PATs with fine-grained PATs
Then we will reduce the risk from a compromised PAT
Definition of done

[x] use cases for each classic PAT understood
[x] fine grained PATs generated to replace classic PATs
[x] GitHub actions referring to PATs updated
[x] GitHub actions tested successfully

Reference
How to write good user stories
Introducing fine-grained personal access tokens for GitHub

The tokens in scope for this are the following:

Token
Description

github_ci_user_pat
Used to create PRs etc in GitHub actions and deploy GitHub resources via Terraform

github_ci_user_environments_repo_pat
Used in reusable pipelines of the modernisation-platform-environments repository. This is so that the CI user can post comments in PRs, e.g. tf plan/apply output.

From a quick look at the tokens available to the CI user one has already been converted to a fine-grained token, so hopefully only github_ci_user_pat will need updating

The github_ci_user_pat token is used to populate the TERRAFORM_GITHUB_TOKEN secret in the Modernisation Platform repository. This is then referenced in the following jobs:

collaborator-inactivity-monitoring.yml
modernisation-platform-account.yml
new-environment.yml
new-environment-files.yml
new-member-environment-files.yml
secrets-retrieval.yml
secrets-rotation-reminder.yml
terraform-github.yml
terraform-pagerduty.yml
terraform-single-sign-on.yml
generate-dependabot-file.yml

It currently has the following permissions:

repo
Full control of private repositories
workflow
Update GitHub Action workflows
admin:org
Full control of orgs and teams, read and write org projects
user:email

Access user email addresses (read-only)
project
Full control of projects

Next steps are to try creating a dummy fine-grained token that has the necessary permissions required to perform all the actions.
I might create a dummy token with minimal permissions and then on a branch try running all of these workflows and see what it complains about.

I've tested each workflow listed in the comment above by creating a new fine-grained token and giving it virtually no access and then referencing it in a branch in all the jobs and running them to see what fails. Then I have gradually enabled more permissions as required.
In particular, the terraform-github.yml workflow which runs the Terraform to manage all of our github resources (e.g. creating new repos etc.) requires the widest scope as it needed me to open up permissions to "All repositories" rather than "Only select repositories" where you can limit it to just the MP repo for example.
I'm thinking of writing a follow-up to consider creating another token that has less privileged access for those jobs.

A new fine-grained GitHub token has been created, updated in aws secrets manager and applied here
Permissions granted:
Organization permissions

Read and Write access to members and organization projects

Repository permissions

Read access to metadata
Read and Write access to administration, code, pull requests, and secrets

Follow on story created to consider creating a separate token with less privileges for certain workflows - https://github.com/ministryofjustice/modernisation-platform/issues/8476

I've reviewed this & moving to done.


Record Audio button missing in main bar

macOS version:    10.14.6 Mojave
Kap version:      3.0.0
Steps to reproduce
Start Kap
Try to enable/disable audio by checking the "Record Audio" button
Current behavior
Button not available in main bar

Expected behavior
Button as in version 2.2 available in main bar to immediately enable/disable for each recording

Workaround
Enable/disable globally in the preferences
Attention: it is not clear while recording if audio is recorded or not

Thanks for bringing this up @raabmar. In the next version of Kap you can decide to remove the audio channel in the editor after recording, or completely opt-out of audio recording in your preferences.

Thanks a lot. Personally, I think a user knows beforehand if he/she would like to enable/disable audio. So having the opportunity to enable/disable quickly with one switch upfront sounds more logical to me. But I am sure you thought it through and tested the usability. Happy to have the option back soon - so far Kap 3.0.0 seems quite stable.

+1
I would really like this back, even though I trust that Kap will remove the audio on export if I choose, I have a headset that if it detects audio input is enabled will change the sound processor, which makes recording with audio default on (for the few times I need it) quite annoying.
Thanks :)

Idea for this, that minimizes UI changes and pushing this around. We could add a shortcut to toggle audio recording in the menu that shows when you right-click the tray icon, or the ... icon in the main bar:

It could be a checkbox item that would show toggled if audio is enabled, and could be clicked to toggle on/off.
Additionally we can also have a keyboard shortcut in the cropper (maybe m?)

Additionally we can also have a keyboard shortcut in the cropper (maybe m?)

Having a shortcut like that without a clear indicator if audio is recorded would be "dangerous" I can see myself hitting m by accident.

This was fixed in #859


SSL properties are not being passed to the producer

Hi,
I have created a connector thanks to debezium that successfully connect to my broker with ssl.
We can see in producer and consumer ssl properties correctly initialized :
	ssl.keystore.location = /etc/config/kafka.keystore.p12
	ssl.keystore.password = [hidden]
	ssl.keystore.type = PKCS12
	ssl.protocol = TLSv1.3
	ssl.trustmanager.algorithm = PKIX
	ssl.truststore.location = /etc/config/kafka.truststore.jks
	ssl.truststore.password = [hidden]

But the properties of the sap hana connector producer in source mode are not being passed well :
	ssl.keystore.location = null
	ssl.keystore.password = null
	ssl.keystore.type = JKS
	ssl.protocol = TLSv1.3
	ssl.provider = null
	ssl.secure.random.implementation = null
	ssl.trustmanager.algorithm = PKIX
	ssl.truststore.certificates = null
	ssl.truststore.location = null
	ssl.truststore.password = null
	ssl.truststore.type = JKS

It seems like only the bootstrap server is present in producer's config so I'm getting this warning :  Bootstrap broker <broker-host> - (id: -1 rack: null) disconnected   [org.apache.kafka.clients.NetworkClient] even tho the connection to SAP Hana database seems up : Returning 100 records for IncrColTableQuerier{...
I have tried many ways to override those properties, as environnement variables directly and also on connector's configuration when creating it.
    "producer.security.protocol": "SSL",
    "producer.ssl.key.password":
    "producer.ssl.keystore.location": "/etc/config/kafka.keystore.p12",
    "producer.ssl.keystore.password":
    "producer.ssl.keystore.type": "PKCS12",
    "producer.ssl.truststore.location": "/etc/config/kafka.truststore.jks",
    "producer.ssl.truststore.password":

    "security.protocol": "SSL",
    "ssl.key.password":
    "ssl.keystore.location": "/etc/config/kafka.keystore.p12",
    "ssl.keystore.password":
    "ssl.keystore.type": "PKCS12",
    "ssl.truststore.location": "/etc/config/kafka.truststore.jks",
    "ssl.truststore.password":

    "connect.security.protocol": "SSL",
    "connect.ssl.key.password":
    "connect.ssl.keystore.location": "/etc/config/kafka.keystore.p12",
    "connect.ssl.keystore.type": "PKCS12",
    "connect.ssl.truststore.location": "/etc/config/kafka.truststore.jks",
    "connect.ssl.truststore.password":

i removed passwords from config

Could you please tell me if there is a way to use SSL in the producer config ?

The correct configuration was :
     "connect.producer.security.protocol": "SSL",
    "connect.producer.ssl.key.password":
    "connect.producer.ssl.keystore.location": "/etc/config/kafka.keystore.p12",
    "connect.producer.ssl.keystore.password":
    "connect.producer.ssl.keystore.type": "PKCS12",
    "connect.producer.ssl.truststore.location": "/etc/config/kafka.truststore.jks",
    "connect.producer.ssl.truststore.password":

@Thomas-Dangleterre I wanted to reply but you resolved it on your own. But it is strange what you observed.
When the broker is running on TLS, the connector needs its series of ssl.xxxxx properties set for its bootstrap server connection.  In addition, the series of producer.ssl.xxxx and consumer.ssl.xxxx properties just need to be set for the sink and source connectors, respectively. And that should be sufficient.  https://docs.confluent.io/platform/current/kafka/encryption.html#kconnect-long


etcd down notification

In case cetcd_multi_watch_async i sused and at any given point etcd is not reachable anymore, how is application notified ?
From what i saw there is no notification. After etcd is reachable again subscription is renewed but any notification is responced with
Error Code:1000
Error Message:not a json response
Error Cause:HTTP/1.1 200 OK
thank you

hi again, i think that the problem is that state machine (for parser) is not reset after watch is re-issued after etcd is reachable again. I have created a pull request for a possible fix.
thank you

Thanks very much for your contribution. I'd like to test about pr these days.


Better injection logging

Before:
AdmissionReview for Kind=/v1, Kind=Pod Namespace=service-graph14 Name= (svc14-0-5-0-7df978d7db-***** (actual name not yet known)) UID=e2e08980-1a8e-4d25-9519-56c4228cbf07 Rfc6902PatchOperation=CREATE UserInfo={system:serviceaccount:kube-system:replicaset-controller 6674512c-50fb-4ee3-b6a4-6f6224b47be1 [system:serviceaccounts system:serviceaccounts:kube-system system:authenticated] map[]}
Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
825d8f72ce0ae82298c6c89e89664401622f7931
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest
On Mon, Aug 31, 2020 at 9:39 PM Istio Automation<EMAIL_ADDRESS>wrote:

@howardjohn https://github.com/howardjohn: The following test failed,
say /retest to rerun all failed tests:
Test name Commit Details Rerun command
integ-operator-controller-tests_istio 825d8f7
https://github.com/istio/istio/commit/825d8f72ce0ae82298c6c89e89664401622f7931
link
https://prow.istio.io/view/gs/istio-prow/pr-logs/pull/istio_istio/26951/integ-operator-controller-tests_istio/7550 /test
integ-operator-controller-tests_istio
Instructions for interacting with me using PR comments are available here
https://git.k8s.io/community/contributors/guide/pull-requests.md. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:
repository. I understand the commands that are listed here
https://go.k8s.io/bot-commands.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/26951#issuecomment-684215440, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXNFADYLSJMFGNHACA3SDR3ITANCNFSM4QQ6VN7A
.


Change client code accordingly after protocol tokenomics v1 PR merged

https://github.com/taikoxyz/taiko-mono/pull/243/files

https://github.com/taikoxyz/taiko-client/pull/104


Show that agents are online if they are active in Slack

Problem
A lot of users prefer to reply directly from Slack, instead of the Papercups dashboard.
They want the "agent availability indicator" to show if they're online in Slack. At the moment it only shows as "online" when in the dashboard.
Solution
Figure out how to use the Slack API/events to indicate online presence.

Questions, or need help getting started?
Feel free to ask below, or ping us on Slack :)
(You can also check out our CONTRIBUTING.md)

@reichert621 I'm open to take this one on:
What I've gathered so far:

Slack has API Events that could push to Papercups
The Slack presence_change event signifies the status change of a user as "away" vs "active"
Slack sends the Slack user ID in the JSON in the "user" key, if it's multiple online in a given time period it'll send a batch with a key of "users"
I believe there would need to be a mapping between the user ids in Slack and users in Papercups within the Papercups database. Possibly in the user_profiles table or slack_authorizations or a new table such as slack_users?
When a user is marked as online from slack it'll toggle the online message based on account id to the frontend? Unsure how to do this

@LeviLong01 regarding your second-last point - have you taken a look at lib/chat_api/slack/event.ex?

I did not see that! Thanks will take a look at that

@LeviLong01 we also have a slack_user_id on the user_profiles table, but at the moment there's no way to set it in the UI (i currently just use this script to sync it by matching email addresses: https://github.com/papercups-io/papercups/blob/master/lib/mix/tasks/set_missing_slack_user_ids.ex)
(at the moment we do an email lookup every time we want to match, but eventually it would be nice to be able to map a papercups user to a slack user, because it's not always the case that the emails match)

@reichert621 thanks I see that now on the user_profiles table. Are you wanting to give the ability for someone to set the Slack ID in the UI?

So far added a migration that adds an attribute called slack_active with a Boolean type to the 'user_profiles' table
Did setup a 'Slack user ID: ' section in the 'My Profile' page in case a user did happen to want to manually add it. Would only want to display that field if the Integrations page shows they are connected to Slack, but am figuring out which table would indicate that a user is connected to Slack. Am thinking it would be the 'slack_authorizations' table with the 'authed_user_id' as the attribute to match on.

A lot of this is learning on the go 😄
Got a Slack environment setup with proper access credentials.
Figuring out how to setup ngrok so the Slack environment has a public URL to use during testing:

https://slack.dev/node-slack-sdk/events-api
https://slack.dev/node-slack-sdk/tutorials/local-development

Next am going to add an event handler (for the presence_change event) to what you showed me @a8t  in the Slack event file


tegola: 0.15.0 -> 0.15.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/go-spatial/tegola/releases.
meta.description for tegola is: "Mapbox Vector Tile server"
meta.homepage for tegola is: "https://www.tegola.io/"
meta.changelog for tegola is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.15.2 with grep in /nix/store/i2rw61zivkxkr36f83y2an7yzb5nczm8-tegola-0.15.2
found 0.15.2 in filename of file in /nix/store/i2rw61zivkxkr36f83y2an7yzb5nczm8-tegola-0.15.2

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
tegola

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/i2rw61zivkxkr36f83y2an7yzb5nczm8-tegola-0.15.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A tegola https://github.com/r-ryantm/nixpkgs/archive/bb846cbbc384955ce5e9c52106f65d07b63f38e5.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/i2rw61zivkxkr36f83y2an7yzb5nczm8-tegola-0.15.2
ls -la /nix/store/i2rw61zivkxkr36f83y2an7yzb5nczm8-tegola-0.15.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

tegola

Maintainer pings
cc @ingenieroariel for testing.

@ofborg eval

Result of nixpkgs-review pr 184076 run on x86_64-linux 1

1 package built:

tegola


linking problem with PNG library

I am using the PNG writing function of Dlib (cloned from github into /usr/local/dlib and dtest run successfully for all tests but 2 machine precision errors) and tried to write a test image in the same way as the functions in dilb/test:
#define DLIB_PNG_SUPPORT

#include <dlib/image_io.h>
#include <dlib/array2d.h>

using namespace dlib;

int main() {

  array2d<unsigned char>     img;

  img.set_size             ( 100,        100 );
  assign_all_pixels        ( img,          7 );
  save_png                 ( img, "test.png" );

  return (0);

}

The command line I used for compiling this test program is
g++ -o test_dlib_png test_dlib_png.cpp /usr/local/dlib/dlib/all/source.cpp -I/usr/local/dlib -L/usr/lib/x86_64-linux-gnu -lpng16 -lpthread -lX11

So I added the compilation of /usr/local/dlib/dlib/all/source.cpp and included /usr/local/dlib for the headers and /usr/lib/x86_64-linux-gnu for libraries, and linked against `libpng16'.
I expected to get a small greyscale image like test.png in the dlib/test/build directory. But at the moment I cannot compile the code with the g++ call above, because it gives a linker error:
/usr/bin/ld: /tmp/ccrXNLK3.o: in function `dlib::disable_if<dlib::is_matrix<dlib::array2d<unsigned char, dlib::memory_manager_stateless_kernel_1<char> >, void>, void>::type dlib::save_png<dlib::array2d<unsigned char, dlib::memory_manager_stateless_kernel_1<char> > >(dlib::array2d<unsigned char, dlib::memory_manager_stateless_kernel_1<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)':
test_dlib_png.cpp:(.text._ZN4dlib8save_pngINS_7array2dIhNS_33memory_manager_stateless_kernel_1IcEEEEEENS_10disable_ifINS_9is_matrixIT_vEEvE4typeERKS7_RKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE[_ZN4dlib8save_pngINS_7array2dIhNS_33memory_manager_stateless_kernel_1IcEEEEEENS_10disable_ifINS_9is_matrixIT_vEEvE4typeERKS7_RKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE]+0x2a9): undefined reference to `dlib::impl::impl_save_png(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::vector<unsigned char*, std::allocator<unsigned char*> >&, long, dlib::impl::png_type, int)'
collect2: error: ld returned 1 exit status

In other words. If I have a C++ file as above called test_dlib_png.cpp in /tmp and try to compile it with the command above, I get a linker error.
Does it need to be linked against something other than libpng (or libpng16)?
Dlib version is >= 19.15, cloned this month from https://github.com/davisking/dlib
My platform is Debian 9.8, 64 bit with C++ compiler g++ 8.2.0-20

Never #define DLIB_PNG_SUPPORT inside a cpp file.  You have set it in one translation unit and not in others, creating ODR violations.  https://en.cppreference.com/w/cpp/language/definition
You have to set it everywhere, you typically do this via a compiler build switch or by letting a build system do it, since a build system will compile all translation units the same way, and therefore avoiding ODR violations.  This is why I encourage people to use cmake.  CMake won't create ODR violations be invoking the compiler in ways that violate ODR.  Or at least you will have to work to make it mess up the build like that.


Remove start page and its build dependencies

Closes #16453 (as part of #16678)
I won't be here next week, so this can wait for a bit 🙂
What got removed:

Start page

"Open start page" command
showStartPage setting
extensionVersion memento set up by the start page (was used to decide whether to show the start page or not if the showStartPage setting was set to true) and used for the "we bundle Pylance" prompt
Telemetry

"Jupyter is not installed" prompt that appears when clicking on the start page + its telemetry
React/JSX/TSX-related build steps and package.json dependencies

@jakebailey FYI


How to implement register file to block RAM manually?

My toolchain doesn't support to implement register file as dedicated memory. How to implement it manually to reduce core size?

Hmm. This is a strange limitation. What architecture/toolchain is that?
I see two options:
Option 1: Use Yosys to synthesize the pivorv32 verilog code into lower-level verilog with the register file mapped to a block ram. I.e. do something like this:
$ cat picorv32_presyn.ys
read_verilog picorv32.v
chparam -set COMPRESSED_ISA 1 picorv32
prep -top picorv32
memory_bram -rules picorv32_regs.txt
write_verilog -noattr picorv32_presyn.v

$ cat picorv32_regs.txt
bram picorv32_regs
  init 0
  abits 5
  dbits 32
  groups 2
  ports  2 1
  wrmode 0 1
  enable 0 1
  transp 0 0
  clocks 1 1
  clkpol 1 1
endbram

match picorv32_regs
  make_transp
endmatch

$ yosys picorv32_presyn.ys

This will create a picorv32_presyn.v file with a "pre-synthesized" version of the core that contains an instance of a picorv32_regs:
  picorv32_regs \cpuregs.0.0.0  (
    .A1ADDR(_0008_),
    .A1DATA(_0140_),
    .A2ADDR(_0009_),
    .A2DATA(_0141_),
    .B1ADDR(latched_rd),
    .B1DATA(cpuregs_wrdata),
    .B1EN(_0000_[31]),
    .CLK1(clk)
  );

The following (untested) code demonstrates the semantics of the picorv32_regs interface:
module picorv32_regs (
    input [4:0] A1ADDR, A2ADDR, B1ADDR,
    output reg [4:0] A1DATA, A2DATA,
    input [31:0] B1DATA,
    input B1EN, CLK1
);
    reg [31:0] memory [0:31];
    always @(posedge CLK1) begin
        A1DATA <= memory[A1ADDR];
        A2DATA <= memory[A2ADDR];
        if (B1EN) memory[B1ADDR] <= B1DATA;
    end
endmodule

You have to provide an implementation of this module, which can be a simple wrapper for you block rams. A1 and A2 are the read ports, B1 is the write port.
If you enable interrupts with Q registers then you'll have to change abits 5 to abits 6 in picorv32_regs.txt and you'll have to provide a block ram wrapper with a 6-bit wide address port.
If you set ENABLE_REGS_DUALPORT=0 then you should also change the ports line in picorv32_regs.txt to ports 1 1 and you will get an instance of a block RAM with only one read port.
Option 2: Refactor the picorv32.v code to work around the limitations of the tool chain you are using.
This is the relevant code from picorv32.v for reading from and writing to the block RAM:
    always @(posedge clk) begin
            if (resetn && cpuregs_write)
                    cpuregs[latched_rd] <= cpuregs_wrdata;
    end

    always @* begin
            decoded_rs = 'bx;
            if (ENABLE_REGS_DUALPORT) begin
                    cpuregs_rs1 = decoded_rs1 ? cpuregs[decoded_rs1] : 0;
                    cpuregs_rs2 = decoded_rs2 ? cpuregs[decoded_rs2] : 0;
            end else begin
                    decoded_rs = (cpu_state == cpu_state_ld_rs2) ? decoded_rs2 : decoded_rs1;
                    cpuregs_rs1 = decoded_rs ? cpuregs[decoded_rs] : 0;
                    cpuregs_rs2 = cpuregs_rs1;
            end
    end

Note that this code does not contain any read FFs. If you only have block RAMS with read FFs then manually refactoring the code to use them explicitly might be hard and option 1 becomes much more interesting.

It is Anlogic AL3, and compile by it's proprietary tool TD.

@cliffordwolf
I try to use yosys for pre-synth, but when I run demo, it gives me not correct result:
rgwan@laptop:~/anlogic/picorv32_demo$ vvp tb
VCD info: dumpfile system.vcd opened for output.
Hellb Jbeld! If lbh caa eead ghif meffage ghea
ghe CicbEI32 CCH feemf gb be jbekiag jhfg fiae.
            GEFG CAFFED!

(I've fixed a typo in my verilog code above: A1DATA, A2DATA are of course [31:0], not [4:0]. But I don't think this is the issue you are having.)
I've now added a complete example for this:
https://github.com/cliffordwolf/picorv32/tree/master/scripts/presyn
Seems to be working fine here:
picorv32/scripts/presyn$ make
yosys -v0 picorv32_presyn.ys
End of script. Logfile hash: 230c775540
CPU: user 1.44s system 0.02s, MEM: 56.36 MB total, 24.29 MB resident
Yosys 0.7+97 (git sha1 8480620, clang 3.8.0-2ubuntu4 -fPIC -Os)
Time spent: 14% 6x opt_expr (0 sec), 13% 6x opt_clean (0 sec), ...
iverilog -o testbench.vvp testbench.v picorv32_presyn.v
/opt/riscv32ic/bin/riscv32-unknown-elf-gcc -Os -ffreestanding -nostdlib -o firmware.elf firmware.S firmware.c \
	 --std=gnu99 -Wl,-Bstatic,-T,firmware.lds,-Map,firmware.map,--strip-debug -lgcc
/opt/riscv32ic/bin/riscv32-unknown-elf-objcopy -O binary firmware.elf firmware.bin
python3 ../../firmware/makehex.py firmware.bin 4096 > firmware.hex
vvp -N testbench.vvp
VCD info: dumpfile testbench.vcd opened for output.

Hello World! If you can read this message then
the PicoRV32 CPU seems to be working just fine.

                TEST PASSED!

TRAP.

The register code listed above:
module picorv32_regs (
    input [4:0] A1ADDR, A2ADDR, B1ADDR,
    output reg [31:0] A1DATA, A2DATA,
    input [31:0] B1DATA,
    input B1EN, CLK1
);
    reg [31:0] memory [0:31];
    always @(posedge CLK1) begin
        A1DATA <= memory[A1ADDR];
        A2DATA <= memory[A2ADDR];
        if (B1EN) memory[B1ADDR] <= B1DATA;
    end
endmodule

That shows the read data is registered so it shows up after the rising edge of CLK1.
The latest version in picorv32 is asynchronous without the register.
Is there a way to get the registered version to work again?
Some block ram implementations are clocked.


Image on side not showing

Image on the side is not showing. All I see is a "?" in a blue box. I am using a Mac computer. Should this be an issue?
Challenge Size your Images has an issue.
User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/602.4.8 (KHTML, like Gecko) Version/10.0.3 Safari/602.4.8.
Please describe how to reproduce this issue, and include links to screenshots if possible.
 We're aware of this, it's caused by an outage at our image hosting provider, AWS S3. See https://github.com/freeCodeCamp/freeCodeCamp/issues/13653 for more details. I'm closing this as a duplicate.

Update at 1:12 PM PST from the AWS status page. Everything should be back to normal for us!
After refreshing your browser, images should load again. If not, please clear your cache and try again.

Image is loading https://s3.amazonaws.com/freecodecamp/relaxing-cat.jpg but bit.ly redirection seems not to work with this exercise. Please don't use redirection services.

Responsively Style Radio Buttons
On Sat, Mar 4, 2017 at 7:26 PM, t0cc<EMAIL_ADDRESS>wrote:

Image is loading https://s3.amazonaws.com/freecodecamp/relaxing-cat.jpg
https://s3.amazonaws.com/freecodecamp/relaxing-cat.jpg but bit.ly
http://bit.ly redirection seems not to work with this exercise. Please
don't use redirection services.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/freeCodeCamp/freeCodeCamp/issues/13658#issuecomment-284162142,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AX9USOGv73PcfjLmMIBF-zj8rMEe7cTdks5riZC8gaJpZM4MO3nW
.


No public initializers for KeyParams and KeysQuery structs.

Hello!
The KeyParams and KeysQuery structs do not have publicly accessible initializers. This implies that any code outside the MeiliSearch module cannot create new instances of these structs.
This works in direct contrast to examples laid out in the Meilisearch documentation such as when it displays constructing new KeyParams instances to pass to the POST /keys endpoint, which can be seen here, if you select Swift as the client language.
Thanks!
meilisearch-swift v0.14.1

Hello @mannuch thanks for having opened this issue! 😄 Reviewing your PR today!


Separate Orbit.js (core) to its own module

Orbit.js, the main part of Orbit, should be its own module so that it's reusable by other programs.

Work happening here: https://github.com/haadcode/orbit-core


Improve Dashboard Site Homepage

Date:  07 Sep 2024
Developer Name:  Nikhil Kumar
Issue Ticket Number:  #808
Description
Fixed styling of the Dashboard page and added description.

https://tubular-crostata-e9a09e.netlify.app/

The cards font weight looks too strong. Can we take the reference from /groups?

Too Much Truth

Please ask the role creator or admin to update this group description.

.card {
     background: var(--color-group-background);
     padding: 20px;
     border-radius: 15px;
     border: 1px solid hsla(0, 0%, 92%, 1);
     box-shadow: 1px 2px 4px 0px hsla(0, 0%, 0%, 0.1);
}

.card__title {
  font-size: 1.1rem;
  font-weight: 600;
}

.card__description {
  margin-top: 0.6rem;
  color: var(--color-text-secondary);
  font-weight: 400;
  font-size: 0.8rem;
  line-height: 18px;
}

Thanks for changing the font weight. Can we do the same for box shadow and font color? Also would recommend to remove the hover effect. What do you think?

Yes, I will do it
On Sun, 15 Sept, 2024, 23:39 Pallab Sonowal, @.***>
wrote:

Thanks for changing the font weight. Can we do the same for box shadow and
font color? Also would recommend to remove the hover effect. What do you
think?
—
Reply to this email directly, view it on GitHub
https://github.com/Real-Dev-Squad/website-dashboard/pull/817#issuecomment-2351708723,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BBBQVZXUHFWDCH7GTSPQEZLZWXEOXAVCNFSM6AAAAABN2G74QOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJRG4YDQNZSGM
.
You are receiving this because you authored the thread.Message ID:
@.***>

Discussed

Create Goals

          Set and track goals to align efforts and measure progress.

.card {
  margin: 0;
  background-color: white;
  text-decoration: none;
  padding: 20px;
  width: 300px;
  border-radius: 15px;
  border: 1px solid hsla(0, 0%, 92%, 1);
  box-shadow: 1px 2px 4px 0px hsla(0, 0%, 0%, 0.1);
}

.card__title {
  font-size: 1.1rem;
  font-weight: 600;
  color: hsla(0, 0%, 21%, 1);
}

.card__description {
  margin-top: 0.6rem;
  color: hsla(0, 0%, 21%, 0.75);
  font-weight: 400;
  font-size: 0.8rem;
  line-height: 18px;
}

Details are missing

previously I had written commit01,02,03, but  after that I have started mentioning the details, could you please check once.


Pre-release version can no longer start local mode kernels without running jupyter-notebook

Applies To

[X] Notebooks (.ipynb files)
[ ] Interactive Window and/or Cell Scripts (.py files with #%% markers)

What happened?
It used to be the case that I could start a local Jupyter kernel for a virtualenv that just had ipykernel (and maybe a couple other things) installed, but without jupyter (I think) or notebook installed.
With the latest pre-release Jupyter extension, it seems that even for local mode kernels, the Jupyter extension now tries to run jupyter-notebook in the environment. This is a problem for us because we've got an internal version of jupyter with some customizations that lives under a different command name, and for that reason we've patched the jupyter-notebook command to print an error instructing people to use the other one (just to reduce confusion).
But I could imagine it also being a potential problem for other people who were expecting to be able to run kernels with fewer dependencies installed (i.e. without the jupyter-notebook command) who will now be prompted to install those other packages. If they're relying on frozen or containerized environments, this will effectively mean that after this upgrade they can no longer run Jupyter notebooks using those environments in VS Code.

I'm also confused about why it appears to try using an environment from a different project first. I find this behavior very confusing but can't nail down why/when it happens. That might be a bug too.
VS Code Version
Version: 1.77.0-insider Commit: c97d5812f...
Jupyter Extension Version
v2023.3.1000771902
Jupyter logs
My environment is firewalled such that I cannot directly paste output. I'm sorry, but screenshots are the best I can do. I've added those to the main section above.

Coding Language and Runtime Version
Python v3.9.12
Language Extension Version (if applicable)
No response
Anaconda Version (if applicable)
No response
Running Jupyter locally or remotely?
Local

Yeah, Debian 10, x64.
The environment I'm in doesn't let me copy text out, unfortunately. Let me see if I can reproduce it elsewhere.

The environment I'm in doesn't let me copy text out, unfortunately. Let me see if I can reproduce it elsewhere.

Ok, then can you scroll to the very top of the logs and take a screenshot of that. I need the first 10 lines of the logs
That contains an error message about zeromq not loading.
& thanks for providing the OS info

Aha!
warn 21:26:39.443: Exception while attempting zmq : /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33` not found (required by /home/leif/.vscode-server-insiders/extensions/ms-toolsai.jupyter-2023.3.1000771902/out/node_modules/zeromq/prebuilds/linux-x64/node.napi.glibc.node)

We're on glibc 2.28 :-/

Here's a screenshot of the rest but I doubt it's relevant:

Thanks , we are planning on addressing this issue
Closing as a duplicate of https://github.com/microsoft/vscode-jupyter/issues/13089

Thank you!

Thank you for filing this issue and providing the logs, that helps a lot.
Hopefully this will be fixed in a day or two.

@leifwalsh what version of Debian are you currently on.
I'm trying to test this within a docker container that will pull in debian, when testing with Debian latest version, i believe thats 11, then things work as expected (at least for me)
Pleas let me know

Linux distro
Version
Whether arm64 or x64 or x86 (architecture used)

ms-toolsai-jupyter-insiders.vsix (3).zip
@leifwalsh Please could you test this and let me know if this works for you.
Thanks

No, but new error:
warn 02:33:38.753: Error occurred while trying to start the kernel, options.disableUI=false Cn [Error]:
    at new Cn (/home/leif/.vscode-server-insiders/extensions/ms-toolsai.jupyter-2023.3.100/out/extension.node.js:2:1611002)
    at Function.from (/home/leif/.vscode-server-insiders/extension/ms-toolsai.jupyter-2023.3.100/out/extension.node.js:2:1611081)
    at Gg.createJupyterSession (/home/leif/.vscode-server-insiders/extension/ms-toolsai.jupyter-2023.3.100/out/extension.node.js:17:264091)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

TypeError: t.Subscriber is not a constructor
    at /home/leif/.vscode-server-insiders/extension/ms-toolsai.jupyter-2023.3.100/out/extension.node.js:17:97545
...

Distro: Debian
Version: 10 (buster)
Architecture: x64

fwiw I no longer see a warning about zmq failing to load.

thanks, the new error indicates its not working correctly, i will be building a new VSIX shortly.

I'm here to test when ready!

@leifwalsh please try installing the latest pre-release version of the Jupyter extension from the marketplace.
It should be fixed now.
Would appreciate it if you could get back with a confirmation of the fix, and of course if it does not work, please re-open this issue or i will do that, or just create a new issue and I will look into it.

Yep, v2023.3.1000820547 works great. Thanks!


Azure Account Sign-In does not work in VSCode when behind proxy

VSCode Version:1.8.1
OS Version: Windows 10 Profssional

Steps to Reproduce:

View->Command Pallete-> Azure : Sign In
The popup to provide the code to run in browser does not open. This results in not able to sign in to Azure account.
Try this without proxy. All works fine. Able to connect Azure account.

Reproduces without extensions: Yes/No

Reading your description it seems that the issue originates from an extension and not VS Code itself. Thereby I will close this issue and kindly ask you to report this issue against the extension repository.
Most extensions are on GitHub as well so it should be easy to file it against the extension. If you open an extension on the market place, click on the Support link to find out more.

Thanks again for your feedback!


Automated Package Upgrade

:tada: This PR is included in version 28.2.12 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Improve AzureWebJobsStorage experience for local debugging

When I create a Cosmos trigger I'm asked a bunch of quick pick questions about the Cosmos database, collection, lease, etc.
Then, I'm prompted in the lower right to select a Storage account to be set in local.settings.json for local debugging.

And when i choose "Set Storage Account" I'm sent back up to the quick pick lists.
Why does this prompt show up in the lower right instead of in the quick pick flow at the top/center?

Well...when this prompt was created the prompts were at the top instead of as notifications in the bottom right 😂
Honestly I think we should have a larger discussion around this message. It's been there for a long time, but it's always been a little confusing. I don't think moving to a quick pick will solve that entirely. For example, here are a few things I think we could do:

If on Windows and storage emulator is installed, use that and don't prompt

Question: Should we prompt users to install the emulator if it's not installed or keep using storage accounts in Azure as the default?
Note to self: Need to check if the error makes sense if the emulator is installed, but not running

If AzureWebJobsStorage exists as an environment variable on the system, don't prompt. (Honestly this is what I usually do. It's so much easier to set this once per system instead of once per project)

Note to self: Need to validate the connection string? Not sure if people will set and forget an environment variable and then be confused if they delete that account

Prompt right before debugging instead of after function creation. I was hesitant to make this a "required" dialog in the past (hence the "Skip for now" button)  because (a) you have other options as listed above and (b) you don't need it to deploy. But it seems much more reasonable to be "required" right before you debug

I honestly have no idea why I'm being prompted for a storage account just for debugging :). Is there some way to make it all go away?

At the end of the day that's a question for the platform team. The current solution to "make it all go away" is to use the storage emulator, but that's only available on Windows.
Running the functions runtime locally is the same as running it in the cloud - which I always thought was one of its selling points. So if the platform needs Azure Storage when running in the cloud, it makes sense to me if it needs it locally. But again this is just my understanding and it'd be better to ask someone on the platform team

originally filed by @gbowerman here
Azure Functions VS Code extension 0.14.0.
VS Code 1.31.1.
Windows 10.
Create Azure Function, select Timer Trigger.
In side by side tests, on Mac this prompted user for a storage account, on Windows it didn't.
Subsequently running function locally fails due to AzureWebJobsStorage not set.

Per @jinglouMSFT storage emulator also has a cross plat thing: https://github.com/Azure/Azurite


Extension Module redundant with release of adyen-web 5.0.0

I've been in the process of implementing this integration for a client over the last couple of weeks, while Adyen recently released version 5.0.0 of their adyen-web npm package.
The major feature of this release is the ability to create a payment session, which eliminates the need to make a /payment request to Adyen on our server. Consequently, this would make the extension module of this repo redundant, wouldn't it?
The implementation we have followed now is:

The frontend makes a request to our server with cart ID
Our server fetches the total amount of the cart using its ID and creates a commercetools payment with status BalanceDue and the key set to a uuid. It uses the same uuid as a reference to make a /sessions request to Adyen (along with other relevant payment data)
Adyen return a session ID and session data, which we return to our frontend
The frontend passes the session data into the mounted Adyen Web Drop-In. Payment methods and forms get rendered accordingly.
Shopper finishes payment flow on the frontend and frontend displays payment result.
Adyen sends a notification to our webhook lambda. We update the commercetools payment accordingly and create an order from the cart

Are there any issues you see in this approach? And would it make sense to consider to upgrade this integration repo with Adyen's new adyen-web version?

Hi @MaxAst as documentation states the integration is build on top of Adyen web-components (https://docs.adyen.com/online-payments/web-components) only. It means it could work to some extent with Adyen drop-in or any other Adyen integration approaches but we can neither confirm it nor support in case you get into issues.

Hi @butenkor, this release affects web-components in exactly the same way as web drop-in. See https://docs.adyen.com/online-payments/web-components#create-payment-session and the blue info box at the top of the page announcing the release

We are currently evaluating your request. We will keep you updated.

Hi @butenkor, anything new on this?

Hey @MaxAst thanks for opening the issue, and sorry for the late response:

Consequently, this would make the extension module of this repo redundant, wouldn't it?

No, because the extension module also manages updates on commercetools payment object, such as adding transactions , it's handling lots of edge cases, beside that it has additional features like cancellation, refund, manual capture, restore etc.

Are there any issues you see in this approach?

I could not as you are following the official adyen documentation, you could do as you wrote but you need to handle commercetools payment part in your merchant service/frontend.

And would it make sense to consider upgrading this integration repo with Adyen's new adyen-web version?

Here is an official reply from Adyen on this topic (we will add this info also later to the integration FAQ documentation):

No migration required for existing merchants. The /sessions release is only an orchestration layer on top of existing functionalities. This means that the complete checkout experience is still available and existing merchants will not have to change anything to their existing workflow. In fact, the 3 step /paymentMethods, /payments, /payments/details is still the way to go for more complex user flows. We will be revisiting this topic in Q2 2022 and will keep you updated on the potential upgrade.

I'm closing the issue for now, please feel free to reopen in case of open questions.


Invalid text path while creating Text model using ttf file

Hello,
When I was trying to generate SVG using makerjs "Text" model,
I am getting invalid text path when compared with other software.
I guess there is some issue with transformation of character.
Also, some part at start of svg is missing
Text = روميك
Preview in Microsoft word

Preview of makerjs SVG

Here is generated SVG & input font file

https://drive.google.com/file/d/1nAWOMypqvJTa2hufy5pxOfc2PMlKj6sw/view?usp=sharing

Hello, to help determine where the issue is, can you try your ttf in opentype.js? We use opentype for ttf parsing, perhaps our version might be out of date.


[feature request]: Allow diff view (from select for compare command) to be used to edit both sides

VSCode Version: 0.10.13-insider
OS Version: Windows 7 64-bit

It would be nice if the diff view in the select for compare can be used to edit both files being compared instead of just the file on the right side.
It would make it easy to edit two very similar files at the same time, that only differ in certain parts.

Duplicate of https://github.com/Microsoft/vscode/issues/4180


Add specialized overloads to Effect.merge and Reducer.combine

This PR adds additional overloads to Effect.merge and Reducer.combine to take advantage of the specialized merge publishers rather than defaulting to Publishers.MergeMany. Additional benchmarks have also been added.
name                                      time         std        iterations
----------------------------------------------------------------------------
Effects.merge([a, b])                      7275.000 ns ±  36.93 %     184188 <- Before
Effects.merge(a, b)                        6001.000 ns ±  42.96 %     226572 <- After
Effects.merge([a, b, c, d, e, f, g, h])   15660.000 ns ±  29.94 %      82214 <- Before
Effects.merge(a, b, c, d, e, f, g, h)     12124.000 ns ±  38.70 %     105266 <- After

name                                      time         std        iterations
----------------------------------------------------------------------------
Reducer.combine([a, b])                   12251.000 ns ±  53.21 %     102758 <- Before
Reducer.combine(a, b)                      9703.000 ns ±  36.59 %     129784 <- After
Reducer.combine([a, b, c, d, e, f, g, h]) 21670.000 ns ±  40.42 %      60340 <- Before
Reducer.combine(a, b, c, d, e, f, g, h)   15953.000 ns ±  37.13 %      74157 <- After

Notes:

Could revert benchmark changes. They are mainly to give an indication of changes in performance.
Alternative parameter names could be used combine(_ a: Reducer, _ b: Reducer) vs combine(_ r0: Reducer, _ r1: Reducer)
Unsure about related docs and formatting.

@mbrandonw @stephencelis CI failed at ReducerTests.testDebug which I don't think is impacted by this change.

Asynchronous wait failed: Exceeded timeout of 2 seconds, with unfulfilled expectations: "logs".

https://github.com/pointfreeco/swift-composable-architecture/blob/d924b9ad27d2a2ccb0ada2639f5255084ff63382/Tests/ComposableArchitectureTests/ReducerTests.swift#L113-L120
Think this is similar to https://github.com/pointfreeco/swift-composable-architecture/pull/181

Great find @iampatbrown, the gain in performance seems very substantial, even for two effects only.
I know that @mbrandonw and @stephencelis are generally wary about adding additional overloads/API surface. Each case should be discussed of course, and the compiler has made great progress in this area, so it's maybe not an issue as of today. However, it seems there's a case for an EffectBuilder resultBuilder. I wonder what form it could take in this case. That wouldn't probably solve the number of overloads, but it can maybe simplify what the user will see for code completion. Maybe there are also features from resultBuilder that can be exploited here to provide new functionalities to the user, like conditional blocks for example. I have a few reducers where I know I could use such a builder to add optional effects inline instead of using an array that I need to name.
Another positive side effect of resultBuilders is that they provide a level of API indirection that gives more freedom when reorganizing the internal without touching the public API. This can prove useful if the library migrates away from Combine at some point.
But it's just an idea like that, and we can discuss it elsewhere if you think it's too off-topic for this PR.

I know that @mbrandonw and @stephencelis are generally wary about adding additional overloads/API surface.

Understandable. That's one of the reasons I've made this a draft. I do think there's an opportunity to use result builder for sure. If you feel like starting up a separate discussion go for it :) My hope was this PR would have minimal impact on the API and allow existing code to benefit from the performance improvements.
I recognise this may become redundant as alternatives to Combine are introduced, however, I thought there was a decent enough performance gain to justify the change. I also think .combine and .merge are used pretty heavily at the moment.

@tgrapperon As an alternative it's possible to use switch reducers.count and switch effects.count and specialize that way. I just found the overloads benchmarked slightly better.

I thought there was a decent enough performance gain to justify the change

Indeed, I was just pitching the EffectBuilder idea. I'll probably open another PR later to explore further.

As an alternative it's possible to use switch reducers.count and switch effects.count

As I'm getting it, users using the variadic overload will automatically switch to the specific overload without having to touch their code, so the current PR approach doesn't effectively increase the API surface as much as it can seem at first sight. The additional burden on the compiler is probably acceptable too.

@iampatbrown, you said you were unsure about documentation, so it was probably about this: There is a 25-30% penalty in using the array variants, but there is nothing yet to inform the user about the difference. Do you think some /// - Note: in the doc would be enough, or should the array variant be made more difficult to reach in order to favorize the faster specialized version when possible (using a labeled argument for example[^1])?
I personally never used the array variant for Reducers, but I'm often using the array variant for Effects when I need to return effects conditionally. With this PR in place, I would wrongly assume I'm optimizing SLOC's without consequences.
[^1]: If a label is added to the array variant, the unlabelled variant could probably be deprecated with a fix-it that would also invite to switch to the specialized variant. I'm unsure if this deprecation works with respect to the previous fix you did with @_disfavoredOverload, or if array variants would fall back again by mistake into the variadic overload? (I don't know how Swift ranks @_disfavoredOverload vs deprecated methods. It probably doesn't change anything, but I need to verify)
After thinking more about it, the EffectBuilder idea is indeed completely off-topic for the scope of this PR: It adds no new API/features, and many users will assume they're using the variadic variant where they're instead using the specialized one. It's indeed a completly different question.

@iampatbrown Cool exploration! This PR and @tgrapperon's give us a lot to think about. We definitely want to revisit some of these ideas when we get around to exploring Reducer as a protocol, and what builders bring to the table then (especially with constrained opaque types on the horizon).
Because of this we may hold off on merging these things for now since the improvements, while nice, are also pretty small in the grand scheme of things, and the added surface area can be intimidating (we've seen firsthand how swift-parsing can be a lil steeper to dive into than a TCA project).


Added 'qemu-system' in worker's Dockerfile

That about it. I will be adding some features in the near future.

Thanks!


Link from local orchestration to real orchestration overview

Also list mesosphere on orchestration overview.

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/97c7840ae877ea79ff2da0229a4cd04622c236a6/


Derive storage encryption key from authentication code

WIP, don't merge.

Not needed, I've pushed directly on top of the PR#31


Include test templates in source tarball.

Otherwise tests would fail for people who use the pypi tarball.

Current coverage is 96.37%

Merging #565 into dev will not affect coverage as of feafd3e

@@              dev    #565   diff @@
=====================================
  Files          24      24
  Stmts        2483    2483
  Branches      221     221
  Methods         0       0
=====================================
  Hit          2393    2393
  Partial        44      44
  Missed         46      46

Review entire Coverage Diff as of feafd3e

Powered by Codecov. Updated on successful CI builds.


Keyboard Shortcuts

After moving to High Sierra, and updating nvALT, I’ve experienced issues with keyboard shortcuts. With each launch of the app, the “Bring-to-Front Hotkey” does not work until I “Set…” the hotkey again. Meanwhile, I’ve been unable to make App Shortcuts set within the Keyboard pane of System Preferences working at all. Any ideas very welcome, since muscle memory is now spoiling my day!

I've also been having this issue. I have a Mac at work that it works fine on, but my personal computer doesn't like the bring to front. I have looked through other shortcuts in mac settings and couldn't find any conflicts. I've also uninstalled/reinstalled with no change. Any idea where I should be looking to find conflicts, Brett?


fix(emissary): strip trailing slash from artifact src before creating…

Hi,
At the moment when running workflows with Emissary executor and saving output artifacts, trailing and leading slashes in srcPath are not being taken into consideration before creating the destination file. When compressing a full directory, srcPath could either be, for instance:

/tmp
/tmp/

For now, paths are only being concatenated, leading in our second example to output paths looking like /var/run/argo/outputs/artifacts//tmp/.tgz. I believe this should probably be var/run/argo/outputs/artifacts/tmp.tgz
My proposal consists of using :

filepath.Join for concatenation, which would take care of potential specific characters (., .. and / basically)
strings.TrimSuffix for getting rid of the trailing slashes

I've also added a unit test case for validating the behaviour.
As it's my first time opening a pull request on Argo, I have no idea whether or not those changes might break any other parts of the codebase. Also please let me know if anything looks wrong regarding the implementation details.
As far as I know this PR does not address any open issues so please just let me know if this contribution does not make any sense to you folks.
Thanks in advance for taking the time to consider this change.
Signed-off-by: Elliot Maincourt<EMAIL_ADDRESS>

@sarabala1979 can we add to v3.1.10?


fix(material-experimental/mdc-input): native select option blending in with background on dark themes

On dark themes the color of the native select inside of an MDC-based form field is usually set to some shade of white. The problem is that the color of the native select dropdown preserves its white background, making the text invisible. These changes make it so that the options always use a dark text color.

We can't have this be in the native select mixin, because it's using theme colors.

Oh, I meant that we place it as a separate mixin in the dedicated native-select file. See how it's done for the subscript: https://github.com/angular/components/blob/master/src/material-experimental/mdc-form-field/_form-field-subscript.scss#L37.

We can't really do that, because we're inverting the color: we're using the light theme color for a dark theme. I don't think that MDC's API supports something like that.

But then we'd be mixing non-theme styles with theming ones. I don't think we're doing that anywhere else, aside from the MDC form field.

That's fair. I don't consider this a big deal though. It makes more sense to me group them by part, and not based on what is theme or not. That should be obvious enough based on mixin name.
I don't mind too much, I'm just saying that we are already doing this in the form field, and this one will fall out of that pattern. Maybe @mmalerba has a feeling on this.

Oh sorry, I missed @devversion's comment. I think since there's already a precedent for doing it for other parts of the form field, it would be fine to make it a separate native select mixin

Done.


Gem for updated Logstash plugin needs to be updated at rubygems.org

Describe the bug
Me and @pkhabazi created a PR recently because we developed a new feature for the Logstash output plugin for Log Analytics. This PR recently got approved and merged but now we need to make sure the respective Gem 💎 gets updated at rubygems.org as well. This ensures automatic updates for existing users and easier installation for new users.
But since Microsoft is the owner of this Gem, we need your help getting this done.
To Reproduce

Check the latest version (1.1.1) of the Gem here at rubygems.org.
You'll notice that user 'MS-HAIMN' is the owner.
Since the recent merge of our PR the latest version is now 1.2.0.

Expected behavior
Please upload the new Gem 💎 for us to rubygems.org 😊
Additional context
I spoke with Haim Rubinstein about this. Apparantly a member of him team is able to perform these steps and he asked me to create this issue here.
If you have any question don't hesitate to reach out!

Hi @TheCloudScout ,Could you please share email id of team member will connect over teams meeting for getting this done

Hi @TheCloudScout ,Could you please share email id of team member will connect over teams meeting for getting this done

Please invite<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

Hi @TheCloudScout ,Could you please share email id of team member will connect over teams meeting for getting this done

Please invite<EMAIL_ADDRESS>and<EMAIL_ADDRESS>
Noted,Will share teams meeting for this issue

Hi @TheCloudScout ,Could you please share email id of team member will connect over teams meeting for getting this done

Please invite<EMAIL_ADDRESS>and<EMAIL_ADDRESS>
Noted,Will ask for convenient time slots for teams meeting for this issue.

We are both currently in Redmond for the MVP summit. So in PST time zone. Please let us now when you have time.

Hi @TheCloudScout ,Could you please share email id of team member will connect over teams meeting for getting this done

Please invite<EMAIL_ADDRESS>and<EMAIL_ADDRESS>
Noted,Will ask for convenient time slots for teams meeting for this issue.

We are both currently in Redmond for the MVP summit. So in PST time zone. Please let us now when you have time.

Could you please share time slots for teams meeting and asked the same over email

Hi @TheCloudScout ,Could you please share email id of team member will connect over teams meeting for getting this done

Please invite<EMAIL_ADDRESS>and<EMAIL_ADDRESS>
Noted,Will ask for convenient time slots for teams meeting for this issue.

We are both currently in Redmond for the MVP summit. So in PST time zone. Please let us now when you have time.

Could you please share time slots for teams meeting and asked the same over email

As discussed over email,will schedule meeting on 18Mar2024

Hi @pkhabazi / @TheCloudScout ,as discussed yesterday over call,waiting for credentials,once received ,will update you,so we can have a call

Hi @pkhabazi / @TheCloudScout  got response from Haim that the commit will be reverted in PR,so there will be no action at rubygems.org ,so closing the issue,If you still need support for this issue(https://github.com/Azure/Azure-Sentinel/issues/10109), feel free to re-open at any time. Thank you for your co-operation!

Hi @v-muuppugund,

the commit will be reverted in PR

Are you saying that you're going to revert/undo the entire PR? What is the reason behind this? Does Haim not agree with the changes made by us?
Please me and @pkhabazi know what didn't work for him and need to be changed. We want to work together to get things right.
Thank you!

Hi @v-muuppugund,

the commit will be reverted in PR

Are you saying that you're going to revert/undo the entire PR? What is the reason behind this? Does Haim not agree with the changes made by us?
Please me and @pkhabazi know what didn't work for him and need to be changed. We want to work together to get things right.
Thank you!

Hi @TheCloudScout ,Ok,Sure,shared details over individual teams chat of email,please let me know there,so will proceed further steps.

Where can we get updated about the status of this work? We would need a ballpark estimate of when we would get generally available managed identity support on this logstash output plugin. Thanks.

@LuKePicci, after having multiple sessions with the MS PM team, they have decided that this feature will not be implemented in the current version that is published on RubyGems. This is mainly because they are in the process of planning a GA for the module in the current version without support for MI, and I can't share more details due to NDA constraints. The current code base will also be reverted to the earlier version without support for MI, as mentioned above.
Therefore, we have decided and agreed with the MS team to bring the current code base with support for MI to a separate GitHub repository and release it under a new Gem name. We are still in the process of updating the documentation, etc. However, the links are already online; feel free to test and share your feedback with us.
Link to the GitHub Repo: https://github.com/pkhabazi/microsoft-sentinel-logstash-output
link to the new RubyGem: https://rubygems.org/gems/microsoft-sentinel-logstash-output

Awesome, thanks for the update.

Trying to test the new plugin, it installs correctly but logstash says:
Unable to configure plugins: (PluginLoadingError) Couldn't find any output plugin named 'microsoft-sentinel-logstash-output'. Are you sure this is correct? Trying to load the microsoft-sentinel-logstash-output output plugin resulted in this error: Unable to load the requested plugin named microsoft-sentinel-logstash-output of type output. The plugin is not installed.
This is logstash configuration file:
output {
     microsoft-sentinel-logstash-output {
                      managed_identity => true
                      data_collection_endpoint => "${DATACOLLECTION_ENDPOINT}"
                      dcr_immutable_id => "${DCR_IMMUTABLE_ID}"
                      dcr_stream_name => "${DCR_STREAM_NAME}"
    }
}

Here the plugin installation output:
Using bundled JDK: /usr/share/logstash/jdk
Validating microsoft-sentinel-logstash-output
Resolving mixin dependencies
Installing microsoft-sentinel-logstash-output
Installation successful

I'm using logstash 8.8.1


[Bug][dao] when run a hive-sql with udf throw ClassCastException

**For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior, for example:

create an hive udf
run a hive-sql with udf
check task log

Expected behavior
Can run hive-sql with udf success
Screenshots
If applicable, add screenshots to help explain your problem.

Which version of Dolphin Scheduler:
-[dev]

[Fix-4929][dao]fix ClassCastException when run hive sql with udf #4930


I got the solution, yet the site will not let me proceed.

Challenge Factorialize a Number has an issue.
User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.95 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:
var array = [];
var x = 1;
function factorialize(num) {
  for(var i = 1; i <= num; i++);{
    array.push(i);
  }
  for(var j = 0; j < array.length; j++) {
    x = x * array[j];
  } return x;
}

factorialize(9);

@joshyu2009 thanks for the issue. You have global variables in your code. Our challenge tests run your function over and over and if you have any global variables, they will change with each test. So move your global variables to within your function and your code will pass. Happy coding!

I came across the exact same solution and exact same error. Moved the variables to inside the function and it's now recognized as correct answer! Thanks!


Aca 60 gareth

Before creating a pull request make sure that:

[ ] commit messages are meaningful and follow good commit message guidelines
[ ] README and other documentation has been updated / added (if needed)
[ ] tests have been updated / new tests has been added (if needed)

Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
Change description
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ ] No

Issue has been identified and fixed in ACA_60 PR #93


Hard-coded assumption about dynamic range when doing clipping detection.

For most sensor brands that GGIR facilitates an assumption is made about the dynamic range of the sensor when testing for signal clipping: If more than 80% of a 15 minute window is near the dynamic range then the window is labelled as clipping and flagged for imputation. For GENEActiv, AX3, AX6, and Actigraph this threshold is set at 7.5 g .
If the dynamic range is actually less than this threshold then clipping detection will not work. It is less concerning if the dynamic range is higher because accelerating with 7.5 for 80% of the time is likely to be non human, regardless of sensor attachment location.
Nonetheless, it would be neater if GGIR could attempt to replace the hard-coded dynamic range assumptions by actual values, if available.

@vincentvanhees , forgive my lack of understanding of some aspect in the current implementation, specifically around when a clipping happened for a portion of the data, what type of warning/messaging does end user receive in console/stdout, and does result (guessing from part 1) include the information that certain period data was imputed specifically due to clipping?

In variable clipping_score in the output from part 2. On a side note - I am in the process of migrating all descriptions of output variables to the vignette, because these are currently half in vignette  and half in more technical function documentation (the GGIR.pdf file).


Add new mapping to avoid deduplicating suggestions via aggregation

With the initial upgrade to Elasticsearch 5, we moved away from Elasticsearch's completion
suggester for a couple of reasons:

it's not scalable (ie. the memory requirements make it cost prohibitive)
it no longer auto dedupes

The first change was to replace the completion suggester via the use of a new autocomplete field in
the mapping and a new edge ngram analyzer. The second change -- specifically to address the
deduplication issue -- was to introduce an additional aggregation query as part of the suggestions
request to ensure that the suggested values are unique.
After some performance testing, despite an expected impact on performance, the individual query
performance looked reasonable (<1 sec in the aggregate). Once we deployed to production however, we
saw a different story -- performance degradation was significant in the context of concurrent
requests.
This next revision builds off of that last step. We remove the need for an aggregation to dedupe
suggestions by restructuring the mapping to store column suggestions as (suggestion, count)
pairs. This new mapping is intuitive. We store only the data we need to satisfy the
request. This is possible because the secondary receives deltas with each row
operation. Specifically, with each insert, deletion, or update we can do the appropriate
book-keeping to ensure counts are correct. Storing counts has the added benefit that they can be
used directly for scoring.
As a side effect of this new mapping (and the need for partial updates to counts), some integration
tests no longer worked with the local ES testing node. These tests were moved to a new
spandex-integration-tests subproject which expect that Elasticsearch is running locally.

[x] unit tests pass
[x] integration tests pass
[x] style check passes

This build looks good.

Build failed.

Build failed.

Retest this please

Build failed.

Retest this please

This build looks good.

@aynleslie thanks for the comments. Re: testing... Note that this doesn't really introduce much new testing -- it basically reproduces the tests we've always had in a new integration test subproject. I agree that there's no better way to test than to do e2e testing. We can definitely let this bake a while. That said, given our time constraints and how long it takes for data to sync, I think we want to provision a cluster in fedramp and deploy the secondary watcher so we can start copying over data ASAP. Migrating data that way will allow us to monitor indexing performance and stats over time and is ultimately simpler anyway.

Using a hash value longer than 4 bytes dramatically reduces your chance of
collisions, even without going to cryptographically secure levels.  I bet
if you work through the birthday problem on 2^32 then a few hundred
thousand values will give you better than even odds of a collision.
On Thu, Apr 26, 2018 at 8:51 PM, Robert Voyer<EMAIL_ADDRESS>wrote:

@rlvoyer commented on this pull request.
In spandex-common/src/main/scala/com/socrata/spandex/common/
client/ResponseExtensions.scala
https://github.com/socrata-platform/spandex/pull/122#discussion_r184586284
:

def makeDocId(datasetId: String, copyNumber: Long, columnId: Long, rowId: Long): String =
s"$datasetId|$copyNumber|$columnId|$rowId"

def makeDocId(datasetId: String, copyNumber: Long, columnId: Long, value: String): String =
s"$datasetId|$copyNumber|$columnId|${value.hashCode}"

Firstly, the likelihood of a collision is extremely rare. Secondly,
consider that the collision would have to be within a single column to be a
problem. My sense: extreme edge case and not worth worrying about. That
said, if you have a viable alternative suggestion, I'm all ears. A note is
a good idea.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/socrata-platform/spandex/pull/122#discussion_r184586284,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAh-r7WOJiaeB7wDc3RZLGyMQDNHdD4pks5tspW1gaJpZM4R4wOL
.

This build looks good.

This build looks good.

This build looks good.


add FireExpress to Javascript section

I rarely use vim, tmux, or related.

I think this is new projects. Here we put the great repository list for inspiring each other to more contribute in open source software.
Thanks for submitting.

Thank you


trouble in zeq_magic

What command was run:
from the PmagPy_plot_analysis notebook:
dir_path='data_files/zeq_magic/'
ipmag.zeq_magic(input_dir_path=dir_path, save_plots=False)
What happened:
contribution_builder threw a KeyError:  'derived_value'  on line 10575 in ipmag.py
I think this is because there is only a measurements.txt file and no higher level files.  This should not happen as zeq_magic was intended as a quick and dirty look - you shouldn't need all the higher level files!  I tried to fix this but got lost in contribution_builder.  Help!

I believe this is because of a change in the online data model.  @ltauxe, try running this command with the internet turned off (or with pmag_env/set_env.py OFFLINE = True).

Setting OFFLINE = True, should be a temporary fix, I will push up a full fix later today or tomorrow.

All fixed!  Thanks Lori - you’re a hero!

On Oct 3, 2019, at 10:31 AM, Lori J<EMAIL_ADDRESS>wrote:
Closed #593 https://github.com/PmagPy/PmagPy/issues/593 via 63de479 https://github.com/PmagPy/PmagPy/commit/63de4794aba00aeba4c2d4e4f11fdc0d6121658c.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/PmagPy/PmagPy/issues/593?email_source=notifications&email_token=AABKWDPGGY2LK3MWIADTYHDQMYUABA5CNFSM4I47CJTKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOUAD5KGY#event-2684867867, or mute the thread https://github.com/notifications/unsubscribe-auth/AABKWDKMTX63SUCXLCNYBCLQMYUABANCNFSM4I47CJTA.


Improve xarray comparators

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (1f0c28c) 100.00% compared to head (cacd146) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #162   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           11        11
  Lines          782       806   +24
  Branches       179       179
=========================================
+ Hits           782       806   +24

Impacted Files
Coverage Δ

src/coola/_xarray.py
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[documentation] Address scaffolding for schema pages

Description
Adds addresses to the schema
Reference
https://github.com/OvertureMaps/schema/pull/193
Testing
https://dfhx9f55j8eg5.cloudfront.net/pr/233/schema/reference/addresses/address/
Checklist
Checklist of tasks commonly-associated with schema pull requests. Please review the relevant checklists and ensure you do all the tasks that are required for the change you made.

[X] Add relevant examples.
[X] Add relevant counterexamples.
[X] Update any counterexamples that became obsolete. For example, if a counterexample uses property A but is not intended to test property A's validity, and you made a schema change that invalidates property A in that counterexample, fix the counterexample to align it with your schema change.
[X] Update in-schema documentation using plain English written in complete sentences, if an update is required.
[ ] Update Docusaurus documentation, if an update is required.
[ ] Review change with Overture technical writer to ensure any advanced documentation needs will be taken care of, unless the change is trivial and would not affect the documentation.

Documentation Website
Update the hyperlink below to put the pull request number in.
Docs preview for this PR.

July 10 Update:
This is a documentation update and we can safely iterate on this into the staging week.


Float literals will never be parsed

@Marist-CMPT331-TOPL/students
Integer and float literals can look similar. In fact, integer literals are effectively a subset of float literals.
For example, should the parser interpret 5 as an integer literal or a float literal? It makes sense that the parser should choose integer literal. What about 5.2? Is this a float literal or an integer literal following by the . operator? Clearly, the parser should treat this as a float literal.
However, the current implementation of the atom parser tries to parse integer literals first. Since it will succeed in parsing an integer 5 when it encounters the token 5.2, it will not parse it as a float. This is the wrong behavior. The atom parser should parse float literals first, only parsing integer literals if it didn't first parse a float.
IMPORTANT: It might seem like the solution is just a simple reordering of lines here, but there is one potential pitfall... When the re-ordered atom parser encounters 5, it will try to parse it as a float literal, and it will only fail when it sees that there is no decimal point after the digit. But by that point, the parser has already consumed the digit 5, so if we try to parse an integer literal we'll have nothing left of the token. The solution here is to try to parse the float literal - using the try function will effectively turn a parser into a look-ahead parser, meaning that if it fails then it will roll back and act like it didn't consume any characters of the token. To use the try function, just give it a regular, non-look-ahead parser - in other words, if p is a parser, then try p is a look-ahead version of that parser. (Note that here p may be a function or other expression that represents a parser.)

I'm curious why this doesn't work? Would I implement the try function here, or somewhere else? And then lets say I were to implement it here, how would I fix the precedence error between <|> and <$>? Do I convert to a <|> FloatLiteralExp >> float?

this is the only reference I see to p outside of the Parser, however I'm not entirely sure it refers to the parser. I tried putting a choice map here, as well as try methods but it doesn't seem to belong.


clientconfig: add RegionName to ClientOpts

For #48

I prefer if opts has the highest priority.

You mean over environment variables? Environment variables always have the final say.

I'm working on Packer, I see you have worked on the OpenStack Terraform provider. In both of them application configuration overrides cloud.yaml and environment variables.

In both of them application configuration overrides cloud.yaml and environment variables.

Unless the application and the application's environment variables are configured to match this clientconfig package.
If Packer is using different environment variables which would conflict with NewServiceClient, then I would say NewServiceClient isn't suitable for Packer and a custom NewServiceClient-ish function local to Packer might be better.
Even though Terraform's environment variables match this package's environment variables, it still does not use NewServiceClient as there are too many other finer details it needs to account for. All of Terraform's config.go file can be thought of as one Terraform-specific NewServiceClient function.

Ok, I thought this was a generalisation of Terraforms config.go. But if it's not I think I'll just copy over Terraforms over to Packer and m.m.

Ah, understood.
This clientconfig package as a whole is an attempt to mirror OpenStack's os-client-config library, which provides various convenience features and functions to authenticate. There are a bunch of functions within clientconfig which can be used together or individually, depending on what works best for the situation at hand.
It's always possible that certain situations won't be able to use anything in clientconfig. In that case, the app developer would have to fall back to gophercloud/gophercloud directly.
Terraform does not use the NewServiceClient function, but uses clientconfig in two places: https://github.com/terraform-providers/terraform-provider-openstack/blob/master/openstack/config.go#L73-L106
It then goes on to configure the rest of the Terraform session in further detail.
Terraform creates a hard separation between someone using a clouds.yaml file and someone authenticating with options explicitly set in Terraform. A combination of the two doesn't happen since, as you've raised, precedence becomes very difficult.
On the topic of regions specifically, Terraform handles this in a very unique way. It's possible to set a region at the provider-level and within each resource.
If you have any questions about what Terraform's doing, please let me know. It's an accumulation of 4 years of work, so there's a lot of functionality accounted for.
But coming back to this PR: I think your request to have RegionName within NewServiceClient is still very valid. I think NewServiceClient will work for 80% of the applications written with Gophercloud. Larger applications, such as Terraform and Packer, will have unique needs outside of it, though.


Implement continuous build that feedback test coverage to github ( to merge PR or not )

test coverage not there, but unit testing in place already.
Closing. For coverage we should make another specific issue


Move e2e dash stateChange test

E2E Tests / Publish E2E Report (pull_request) all tests have passed, problem is only with publish report. We will solve this later.


Posts - I am trying to update for the November 2024 meetup

Here goes my try.

Closing this one as it was updated in a newer pull request.


No obvious way to decrypt lua files?

I've been trying to find out how to decrypt the encrypted lua files (game is Minecraft: Story Mode but I doubt that makes a difference) and I still can't figure it out. The Lua Converter window doesn't seem to be for decrypting.

Nevermind. Found out how to.


[Question]: Metadata question for file readers (docx, pdf, txt)

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
Hi,
I am building a RAG pipeline over a set of the documents. For now, I am only allowing pdf, docx and txt files. I am using the SimpleDirectoryReader to load the files. By default, pdfs have file name and page label as metadata. docx have just file name. txts have no metadata. I want all 3 file types to have consistent metadata.
After some research, I realized it's not easy/possible to get page labels for .txt and .docx files. I still want docx and txts to have file names in metadata. pdfs can have default file name and page label in metadata. What's the best way to achieve it without having to make changes in readers/file/base.py or readers/file/docs_reader.py?
Thanks!

This is how I am doing it right now but I am open to better alternatives:
documents = SimpleDirectoryReader(folder_path, recursive=True, required_exts = ['.pdf', '.docx']).load_data()
txt_filename_metadata_fn = lambda filename: {'file_name': filename}
txt_documents = SimpleDirectoryReader(folder_path, recursive=True, required_exts = ['.txt'], file_metadata = txt_filename_metadata_fn).load_data()
documents.extend(txt_documents)


Prefer exception detailed message

Improve formatting of exceptions using detailed_message.
We may want to feature detect to be compatible with Ruby 3.0.
Types of Changes

New feature.

Contribution

[x] I added tests for my changes.
[x] I tested my changes locally.
[x] I agree to the Developer's Certificate of Origin 1.1.

It was merged in a different PR.


az aks get-versions issue

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az aks get-versions
Errors:
400 Client Error: Bad Request for url: http://localhost:50342/oauth2/token
Traceback (most recent call last):
python3.6/site-packages/knack/cli.py, ln 206, in invoke
    cmd_result = self.invocation.execute(args)
cli/core/commands/__init__.py, ln 603, in execute
    raise ex
cli/core/commands/__init__.py, ln 661, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
...
python3.6/site-packages/msrestazure/azure_active_directory.py, ln 486, in get_msi_token
    result.raise_for_status()
python3.6/site-packages/requests/models.py, ln 940, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 400 Client Error: Bad Request for url: http://localhost:50342/oauth2/token

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az aks get-versions -l {} --query {} -o {}

Expected Behavior
Environment Summary
Linux-4.15.0-1061-azure-x86_64-with-debian-stretch-sid
Python 3.6.5
Shell: bash

azure-cli 2.0.76

Additional Context

Updating tags as the error shows MSI failing, possible to validate that as I don't see anything AKS module specific in that error

@bijithlal09 Apologies for the delayed response. This GitHub issue has been open for quite some time. Could you please let us know if you still facing this issue and need assistance? Awaiting your reply.


fix: coco category ids can now be not sequential - avoiding memory leak

What changes are proposed in this pull request?
Discussed in #4293.
parse_coco_categories returns classes_map instead of classes. It is a dict mapping class IDs to class labels. In areas where the list of classes are needed, it it obtained through list(classes_map.values()).
The caveat I see here is that the public facing add_coco_labels function takes classes as an argument (the list of class labels). To avoid changing the public interface, I did not modify that and built classes_mapusing classes_map = {i: label for i, label in enumerate(classes)}. This should work but requires that in labels_or_path files, the category IDs are sequential (starting from zero). This was already the case before this change.
If we want to allow non-sequential category IDs here also, we need to change the public interface and require classes_mapinstead of classes. Or do you see another solution ? Should we change the public interface or leave it like that ?
How is this patch tested? If it is not, please explain why.
Not thoroughly. I am opening a draft PR to run the tests, as explained in Contributing.
Release Notes
Is this a user-facing change that should be mentioned in the release notes?

[x] No. You can skip the rest of this section.
[ ] Yes. Give a description of this change to be included in the release
notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)
What areas of FiftyOne does this PR affect?

[ ] App: FiftyOne application changes
[ ] Build: Build and test infrastructure changes
[x] Core: Core fiftyone Python library changes
[ ] Documentation: FiftyOne documentation changes
[ ] Other

Summary by CodeRabbit

New Features

Enhanced label handling in COCO dataset utilities by introducing a mapping of class IDs to labels for improved accuracy and flexibility.

With respect to your comment about add_coco_labels(), perhaps you could update so that its classes argument can be either a list (current) or a dict (new format)?

Yes, good idea, I did that.
For the Exporter, I haven't tried yet to use existing IDs as you suggested (in #4293), but I'll see if I get a bit of time to look at it.

@swheaton  any input ?

@patrontheo sorry been very busy, prepping to go on leave.
Thank you for the contribution!!


Problem with better biblatex "An error occured while trying to export the selected file"  (similar to an earlier issue)

I am using Better Biblatex for the first time. I also have a new collection that I have created in the last couple of days.
When I export to Better Biblatex format, I get "An error occured while trying to export the selected file".
Please see https://gist.github.com/cerinunn/85ed16c0db23538e2778

Wow, an error log! I think there's enough info in the log to find and fix
the problem, but could you get me an export of the entrie(s) in the "Zotero
TestCase" format? You can drop the resulting file in
https://dbinbox.com/allthatisthecase . That will allow me to make sure your
problem is fixed, and to add a testcase to my test suite to make sure it
can't be reintroduced.

To be specific, I think I've found it, and the tests are running, but I'd love to be able to add a testcase to prevent regressions; if I'm right, the problem is with an entry that has html somewhere.


ZendViewRendererFactory override HelperPluginManager

[+] I was not able to find an open or closed issue matching what I'm seeing.
[+] This is not a question. (Questions should be asked on slack (Signup for Slack here) or our forums.)

I have Factory which retrieves PhpRenderer from Container and injects this to my AssetMiddleware which prepare js/css files and appends them to view helpers (headLink, headStyle, inlineScript, headScript). During this time PhpRenderer initialize HelperPluginManager
public function getHelperPluginManager()
{
	if (null === $this->__helpers) {
		$this->setHelperPluginManager(new HelperPluginManager(new ServiceManager()));
	}
	return $this->__helpers;
}

But when I inject \Zend\Expressive\ZendView\ZendViewRenderer to my Action \Zend\Expressive\ZendView\ZendViewRendererFactory override HelperPluginManager which was initialized before
// Inject helpers
$this->injectHelpers($renderer, $container);

Factory simply check if HelperPluginManager was registered in Container. There is no check if PhpRenderer already has initialized HelperPluginManager
private function retrieveHelperManager(ContainerInterface $container) : HelperPluginManager
{
	if ($container->has(HelperPluginManager::class)) {
		return $container->get(HelperPluginManager::class);
	}

	if (! $container instanceof InteropContainerInterface) {
		throw new Exception\InvalidContainerException(sprintf(
			'%s expects a %s instance to its constructor; however, your service'
			. ' container is an instance of %s, which does not implement that'
			. ' interface. Consider switching to zend-servicemanager for your'
			. ' container implementation if you wish to use the zend-view renderer.',
			HelperPluginManager::class,
			InteropContainerInterface::class,
			get_class($container)
		));
	}

	return new HelperPluginManager($container);
}

This behavior creates two different HelperPluginManager and creates many problems.

Factory simply check if HelperPluginManager was registered in Container. There is no check if PhpRenderer already has initialized HelperPluginManager

If I understand you correctly, what you are writing here is correct behavior. The ZendViewRendererFactory does not check if the PhpRenderer has a HelperPluginManager registered.
I think what should be done in your custom PhpRendererFactory is grabbing the HelperPluginManager from the container and inject it into the renderer. This way your PhpRenderer and the ZendViewRenderer use the same HelperPluginManager.
class ZendViewRendererFactory
{
    public function __invoke(ContainerInterface $container) : ZendViewRenderer
    {
        $renderer = new PhpRenderer($config);

        if ($container->has(HelperPluginManager::class)) {
            $renderer->setHelperPluginManager(
                $container->get(HelperPluginManager::class)
            );
        }

        return $renderer;
    }
}

Yes, I did it but this behavior isn't obviously. I waste 3 hours for debugging this issue.
I check the hash of PhpRenderer in several places and it was identical. And I didn't understand why HelperPluginManager in my MiddlewareFactory is different to HelperPluginManager in the view template.
class MiddlewareFactory implements FactoryInterface
{
    public function __invoke(ContainerInterface $container, $requestedName, array $options = null)
    {
        /** @var $asseticService AsseticService */
        $asseticService = $container->get('AsseticService');
        $renderer = ($container->has(PhpRenderer::class))
            ? $container->get(PhpRenderer::class)
            : new PhpRenderer();

        // this code was been added after debugging
        #if ($container->has(HelperPluginManager::class)) {
        #    $renderer->setHelperPluginManager($container->get(HelperPluginManager::class));
        #}

        return new AsseticMiddleware($asseticService, $renderer);
    }
}

If PhpRenderer has the possibility for default HelperPluginManager initialization, why I can't use this?
// vendor/zendframework/zend-view/src/Renderer/PhpRenderer.php:359
public function getHelperPluginManager()
{
	if (null === $this->__helpers) {
		$this->setHelperPluginManager(new HelperPluginManager(new ServiceManager()));
	}
	return $this->__helpers;
}

To my mind developer should not know internal logic. If he gets 'PhpRenderer from Container it should come with correct injected dependencies.

Your MiddlewareFactory is good. What you need is a PhpRendererFactory, as I described above. In that PhpRendererFactory you require the HelperPluginManager the same way as the ZendViewRendererFactory to make sure you have the same instance of the HelperPluginManager.

To my mind developer should not know internal logic. If he gets PhpRenderer from Container it should come with correct injected dependencies.

In general you are right. However there is no PhpRendererFactory so this is something you need to create yourself. It's more of an edge case as not many developers use it this way.

Yes, you are right there isn't any PhpRendererFactory and I simply register it as invokables

'dependencies' => [
	'invokables' => [
		PhpRenderer::class => PhpRenderer::class,
	],
]

You can always create a PR and add the missing PhpRendererFactory

I clearly understood you, you suggest me create PhpRendererFactory and pull to a repository. Which one?

ZendViewRendererFactory already check if HelperPluginManager was initialized in Container, it would be good check if it was already injected to PhpRenderer and doesn't override existed.

This repository has been closed and moved to mezzio/mezzio-laminasviewrenderer; a new issue has been opened at https://github.com/mezzio/mezzio-laminasviewrenderer/issues/2.


Be able to have Block::default().title() on the bottom of said block.

Problem

Context: Block::default().title()
The title on the top of a block can sometimes be too long, so being able to have it on the bottom of the block would let users have more information per block.
Solution

I'm not too sure how to program this into the crate, perhaps something like Block::default().title("An example title").bottom() would work.
Alternatives

I don't think vertical titles would be a good idea, so I'm unsure.
Additional context

An exaggerated example, but other titles cannot be seen (ignore the cut-off time).

I don't quite understand how moving a title to the bottom of the block would give you more space, since the top and bottom of a block are the same as far as I know.  You might mean, then, having the capability to put multiple titles, one on top and one on bottom.
Yeah, that might be probably a little overkill to program into the library; you could code it yourself using Layout and Clear, or maybe even just doing away with the border and filling in the symbols yourself.  It would still be time-consuming, though.
Until then https://github.com/fdehau/tui-rs/pull/669; made this for the much simpler functionality of just putting the singular title on the bottom row instead of the top.


ProjectConfig.name to ProjectConfig.id

I changed here too.

Summary
Hi, I changed the ProjectConfig.name to ProjectConfig.id, you can see on and in #10229 . Solution for issue #10013
Test plan

This PR currently has the same title as #10228; are they mean to be two separate PRs (if so, maybe rename one of them so the difference is clear), or did you maybe mean to close one of them?

Sorry, I corrected it. It means this PR.

Closing this as it appears to be incomplete (code won't typecheck unless this is also changed in other places). If you still want to complete this feel free to open another PR with all the changes that are required.


"Failed to start server, will try again in 10 seconds}"

I get this annoying notification prompt every 10 seconds (as the prompt specifies), but I have no idea why the server is failing to start. I've checked to see if the ports are in use, or if I am not running Visual Studio Code as Administrator -- both of these things are fine.
Any troubleshooting tips?

If you are running on Windows 10, with WSL2, I posted some information on why this could be happening & some workarounds in my comment on a similar issue,


conv2d layers in KerasModel

Is it feasible to integrate adding conv2d layers into KerasModel given that conv1d layers are already there?

I looked into this briefly, and noted conv2d takes in a 4d input (conv2d a 3d). So this lead me to think that perhaps KerasModel() could diverge into several (e.g. Model2D, Model3D, and so forth) where each would correspond to a rough use scenario (related with the kind of input data that is available).
What do you think?

This probably makes sense. If done I think a list of example use cases for each should be created to validate that the model created is a good fit for problems in the real world.

Is This Talos works for CONV2D with Wrapper class in keras?
is this comfortable with the fit_generator and evaluate_generator?

@saichandrareddy1 I don't see why that would be a problem, but this ticket is unrelated. Feel free to open new issue if you like.


Detect anomalies in daily routines

Most people and especially elderly have a recurring daily pattern of movement around their home.
An AI sequence model could learn to predict movements and detect anomalies. Examples:

A person did not get out of bed all morning.
A person is spending much longer time in the bath than usual.
A person did not do any stretches and exercises all day.

A person did not open the fridge all day.
A person did not visit bathroom all day.

After gathering additional field experience, the following ideas emerged:
Context:
Falls occur often by the bedside in the bedroom and in bathroom. Both of these are private, space constrained areas with suboptimal visibility. Makes it hard to gather good training data for fall detection.
Possible solutions:

Short time window (10-15 second) time series that capture a sequence of pose detection keypoints and feed them to an anomaly detection model for acute problems such as falls.

Anomaly detection with TensorFlow and Autoencoders https://www.youtube.com/watch?v=2K3ScZp1dXQ
This might be practical for detecting anomalies in basic daily routines such as getting out of bed, walking into/out of bathroom , opening fridge, walking into/out of closet.

Longer time window (24 hour) that compares time series from the most recent 24 hour and the historical 24 hour data distribution to detect anomalies and predict potential upcoming complications that are signaled by change in daily routines.

This model can feed from the short time window model and combine into single activity detection data points.
This model might also combine inference data from multiple ambianic boxes.
The resulting time series might look like this:

around 8am getting out of bed
9:30am - 10am open fridge
11:30am - 12:00pm visit restroom
around 8pm bedtime

Experiment with even longer term time windows to learn about weekly, monthly, seasonal, annual cycles that might relate to health and wellbeing.