Topic branch update: G2P

This brings the G2P branch up to date with recent changes in master. This is a simple merge, and can be done with the following commands:
$ git fetch upstream
$ git checkout upstream/g2p
$ git checkout -b g2p-update
$ git merge upstream/master
$ git push origin/g2p-update

@bwalsh, since you've been nominated to be the G2P branch manager (we had to pick someone, and you seemed the logical choice!), can you merge this PR once it passes CI? As the branch manager you should keep the g2p branch reasonably up-to-date with changes in master using merge PRs like this (see PR #862 for the documentation for this process).  I thought I'd create this merge PR, as an important refactor has happened in master recently which will cause conflicts down the line if we don't deal with it now.

OK, I'm going to merge this.


Colors gone in Project Viewer

ISSUE
Seems with the new update there isn't an option to color the groups. Minor issue but was nice to have.
Thank you.
Environment

OS: OSX
Atom:1.8.0

Hi, yeah, this is not an issue, i have removed this from this version.
But will make it available again, just give me time to implement.
Also you are welcomed to contribute to this project 💪

sure @astucieuxzephyr.
I must be honest, i removed because it was a hack and buggy and I am investigating the documentation for a "better" way.
Sorry for this mates.

Not much left to reimplement this. bare with me

please validate this

It works ! Thank you very much !! :)


Rest of the crypto functions

With this PR, we have first versions of message signing/signature checking and message en/decryption. I pushed the coverage a bit higher, but some error cases are still not covered, e.g. signature errors (for that I sort of have a test, but it's pretty ugly so not included here).

[Current coverage][cc-pull] is 87.87%

Merging [#17][cc-pull] into [master][cc-base-branch] will increase coverage by 12.77%

@@             master        #17   diff @@
==========================================
  Files             7          7
  Lines           265        305    +40
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            199        268    +69
+ Misses           39         37     -2
+ Partials         27          0    -27

Powered by Codecov. Last updated by [d44bd64...50a2aae][cc-compare]
[cc-base-branch]: https://codecov.io/gh/TNG/gpg-validation-server/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/TNG/gpg-validation-server/compare/d44bd64366b375f037bf9aaad9188772b4e6ee23...50a2aaeeb0ffd4ee1ae521cc193eac10735ba82a
[cc-pull]: https://codecov.io/gh/TNG/gpg-validation-server/pull/17?src=pr


Improve collapsible navigation

The viljamis/responsive-nav.js library could be improved:

Should use ARIA attributes differently (menu should not be hidden, see viljamis/responsive-nav.js#156)
Doesn’t use a passive listener, gets flagged in Lighthouse audits

https://medium.com/@heyoka/responsive-pure-css-off-canvas-hamburger-menu-aebc8d11d793

While it's possible to create a functional collapsible menu without JS (see 57527055b463ff9413978106019cf65ccc28d91f), it results in a rather messy DOM tree that looks something like this in screen readers:
Menu (link)
Close Menu (link)

Home
CV
etc

Other sites like http://web-accessibility.carnegiemuseums.org/ use buttons as per the links above. However, it's probably best to keep the DOM clean (i.e. h2 Menu labelling the navigation list) and have a non-collapsible mobile menu when there's no JS.


Fix setuptools version in dev-box

According to https://setuptools.readthedocs.io/en/latest/python 2 sunset.html, Python2 is not supported by setuptools. This PR pins setuptools version to lower than 45.

I suggest to fix the version, i.e., == 45, instead of < 45

Sure. It is better to have a fixed number. I changed it to 44.1.0 because setuptools>= 45 is not recommended for python2


Update encryption.js

I found the problem.  The issue occurs when the data length is a multiple of 16 and you try to add a block with nothing but padding.

:shipit: thanks

Thanks YOU


Reading microscope camera feed.

Hello there - firstly, thanks for developing this API, I was not expecting to find something like this. I would like to ask if there is a way to read the Leica microscope camera feed. A function through which I could extract single frames and then process the extracted frames. Also if it is there is a function that enables you to render the real-time camera feed to the screen. I have gone through the documentation and it seems that the API is designed mostly for sending messages to the microscope, not the other way around.  Please let me know if I am missing something here, I would really appreciate your input on this issue.

Hi!
This library is only built to talk to the Leica LASAF Computer Aided Microscopy TCP interface. As far as I know the image data is not sent over this socket. It's been a couple of years since I was working actively with Leica Miscroscopes, but I haven't heard that they changed this. We did inquire Leica for that feature in my last job.
To achieve a full feedback loop, the application that controls the microscope via this library needs to get separate input from the image data analysis, either from the image data saved to disk or some other custom image feed.
We do get the relative paths of acquired images as messages from the CAM server, but no image data.

Thank you for the speedy response. I have another question. Is it possible to read the microscope camera feed just like any other webcam feed via USB or HDMI?

That depends on the camera you're using. It's not related to this library.


Use mirror in cloudinit too

What does this PR change?
This PR changes user_data.yaml to use the mirror in the case of libvirt backend, like we already do with aws backend.

Thanks for coming up with this effort, it was on my to-do list since official image support landed!

Comments addressed. Better?

Thanks for coming up with this effort, it was on my to-do list since official image support landed!

Most welcome, Silvio.

Now tested to work.


[@tests] increase default concurrent browsers to 3

Currently we run 3 browsers with a max default concurrency of 2.
To avoid leaving a browser hanging, all three should run.
During saucelabs runs this becomes more important due to latency.
This PR increases the default concurrency to 3.

This looks like it reduced the total time for the sauce tests, so I say +1

Awesome! Glad it improves test time a little more :)


FieldValue.increment() is not working as expected on subfields of a map

Thanks for stopping by to let us know something could be better!
PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.

Is this a client library issue or a product issue?
I think it's probably something that should be at-least handled by this library.

Did someone already solve this?

Search the issues already opened: https://github.com/googleapis/nodejs-firestore/issues  ✅
Search the issues on our "catch-all" repository: https://github.com/googleapis/google-cloud-node  ✅
Search or ask on StackOverflow (engineers monitor these tags): http://stackoverflow.com/questions/tagged/google-cloud-platform+node.js ✅

Do you have a support contract?
Nope

If the support paths suggested above still do not result in a resolution, please provide the following details.
Environment details

OS: Mac
Node.js version: 18.16.0
npm version: 9.5.1
@google-cloud/firestore version: ^6.8.0

Steps to reproduce
The FieldValue.increment() function does not work as expected on subFields of a map value. Given this data structure of the object in the database:
{
  amount: 1,
  map: {
    amount: 1
  }
}

If I run this code:
await docRef.update({
  amount: FieldValue.increment(2),
  sub: {
    amount: FieldValue.increment(2)
  }
})

The data in the database ends up being:
{
  amount: 3,
  map: {
    amount: 2
  }
}

It would seem that incrementing using this object syntax does increment on top-level keys, but "sets" the value of subfields of maps to the exact increment value, rather than incrementing.
To me this feels like the incorrect behaviour - I would firstly expect that map.amount would be 3, OR expect the SDK to throw an error as it does when using FieldValue.delete() on a subfield of a map in this way.
The "workaround" is to use dot-notation strings as keys on the top level of the object like so:
await docRef.update({
  amount: FieldValue.increment(2),
  'sub.amount': FieldValue.increment(2)
})

This does work as expected and the data in the db ends up being:
  amount: 3,
  map: {
    amount: 3
  }
}

This issue has been observed in SO here:
https://stackoverflow.com/questions/56427582/how-to-use-fieldvalue-increment-on-the-property-of-an-object-type-document-fie
It feels like this warrants an issue and a change to how the sdk handles this to bring it in line with how it handles FieldValue.delete() on subfields of a map where for example, this code throws an error:
await docRef.update({
  amount: FieldValue.increment(2),
  sub: {
    amount: FieldValue.delete()
  }
})

Error:

Update() requires either a single JavaScript object or an alternating list of field/value pairs that can be followed by an optional precondition. Value for argument "dataOrField" is not a valid Firestore value. FieldValue.delete() must appear at the top-level and can only be used in update() or set() with {merge:true} (found in field "sub.amount")

It took a wilte to figure out what was going on here, and can be especially confusing when incrementing from 0 because it seems like the first request works, but then subsequent requests do not behave as expected. Eg:
Db is:
{
  amount: 0,
  map: {
    amount: 0
  }
}

Run:
await docRef.update({
  amount: FieldValue.increment(1),
  sub: {
    amount: FieldValue.increment(1)
  }
})

Db is now:
{
  amount: 1,
  map: {
    amount: 1
  }
}

Which seems like it works... But if you run the exact same code again:
await docRef.update({
  amount: FieldValue.increment(1),
  sub: {
    amount: FieldValue.increment(1)
  }
})

Now the data in the db ends up being incorrect:
{
  amount: 2,
  map: {
    amount: 1
  }
}

@JamieCurnow,
Thanks for bringing this to our attention. I reproduced the behavior and I agree that it is confusing and the throwing behavior of FieldValue.delete() on a nested property adds to that confusion.
However, this call is technically correct. It's just stating that sub should be replaced with a new object, and then increment the starting value of sub.amount by 1.
await docRef.update({
  sub: {
    amount: FieldValue.increment(1)
  }
});

The solution in your case is to use the dot notation as you already stated.
await docRef.update({
  'sub.amount': FieldValue.increment(1)
});

I'll review this issue with the team after the holidays to see if we can reduce the confusion. The solution might be raising an error, logging a warning, or adding some additional documentation.

Hi @MarkDuckworth, that totally makes sense why this is happening now after your explanation, so thank you so much for the reply 🙌
It's super interesting that a set() with a { merge: true } works differently than an update in this situation. I think I've seen another issue that addresses that... 🤔
In the actual code, I'm changing from a set() call to an update call because I want to fail if the document doesn't already exist. So the solution for me is to just convert all nested object changes into dot-notation strings, though in doing that, I loose type-safety.
Is there any support for a { merge: true } on an update() call in the pipeline that would help this transition in the future to bring the two methods more inline? Or is that something that is just technically not possible under the Firestore hood?
Thanks again!

I just reviewed set(..., {merge: true}) and I can see that the message sent to the backend is slightly different than when using update(...). The set+merge call is requesting that sub should be merged with object {}, and then increment the existing value of sub.amount by 1.
await docRef.set({
  sub: {
    amount: FieldValue.increment(1)
  }
},
{ merge: true });

Is there any support for a { merge: true } on an update() call in the pipeline that would help this transition in the future to bring the two methods more inline? Or is that something that is just technically not possible under the Firestore hood?

This is not currently supported in the SDK from what I can tell. We will discuss allowing this in the SDK.

So the solution for me is to just convert all nested object changes into dot-notation strings, though in doing that, I loose type-safety.

update() can enforce type safety even with dot notation, except when using indexed properties.
type MyType = {
    sub: {
        amount: number
    }
};
let update: UpdateData<MyType> = {
    'sub.amount': increment(1) // must be number | FieldValue | undefined
};
await docRef.update(update);

An alternative solution would be to use a Transaction that checks for existence with a get and then performs the set. The downside to this is that it involves two operations, a read and a write.


Jira data collection stuck v0.10.1

Describe the bug
I tried to collect Jira data using v0.10.1 but the pipeline got stuck at 31.58% for 2 hours (still running).
To Reproduce

Use DevLake version v0.10.1
Set up our own Jira instance
Try to collect board 53 using advanced mode with the following JSON

[
  [
    {
      "Plugin": "jira",
      "Options": {
        "sourceId": 1,
        "boardId": 53,
        "since": "2006-01-02T15:04:05Z",
        "tasks": [
                "collectProjects",
		"extractProjects",
		"collectBoard",
		"extractBoard",
		"collectIssues",
		"extractIssues",
		"collectChangelogs",
		"extractChangelogs",
		"collectWorklogs",
		"extractWorklogs",
		"collectRemotelinks",
		"extractRemotelinks",
		"convertBoard",
		"convertIssues",
		"convertWorklogs",
		"convertChangelogs",
		"convertIssueCommits",
		"convertIssueRepoCommits",
		"ConvertUsers"
           ]
      }
    }
  ]
]

Observe that the pipeline gets to 31.58% rather quickly (15 mins):

Here's the DevLake service log:

But 2 hours later, it's still at 31.58%:

The DevLake service log remains the same as 2 hours ago:

What's the expected behavior?
The pipeline finishes without getting stuck and collects the specified Jira data.

DevLake service log is Incorrect, it is a gitlab plugin not a jira plugin, and the time is 2022-04-21  which seems not right.

The amount of board 53 data is so large that the subtask collectChangelogs is too slow. The collectChangelogs subtask took six hours。

Ok, thank for looking into this for me @abeizn , closing now since it's just slow and not a bug.


Lots of latency; connection time out error

I've been experiencing this for the past  hour, and it hasn't seemed to improve despite heroku's status saying that "everything's okay"
Heroku app: www.savvyist.com

https://status.heroku.com/incidents/723


Permission or Redirection issues

Hi all.  I followed the directions above to try and move my SP2016 databases off of old  hardware and onto a virtual server.  For the most part, everything went pretty smoothly.  When restarting the farm, I was unable to get to Central Admin or the actual SP site.  Event log showed permission issues and that SP could not find the Sharepoint_Config database....despite using cliconfig to create the alias.  I had to roll back unfortunately.  I will diagnose the issues further and hopefully be able to recommend some added steps somewhere.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3659f8a1-257c-e35e-fac9-5f1094217ddc
Version Independent ID: 8915a0d7-882a-8e62-c0b6-3142dee12f95
Content: Move all databases in SharePoint Server
Content Source: SharePoint/SharePointServer/administration/move-all-databases.md
Product: sharepoint-server-itpro
GitHub Login: @bentoncity
Microsoft Alias: stevhord

Thanks @michaelvgibson, definitely let us know what you find. We tested this successfully for SP2016 pre-release but haven't tested it since.

Thanks @bentoncity.  I think I have isolated the problem.  So for some reason, the alias is not redirecting traffic looking for the old SQL server to the new SQL server.  I am trying to diagnose this issue now.

Ok, the issue ended up being related to the 32 bit cliconfig utility.  This was mentioned in the closed comments on issue #17.  They stated that why specify 32 bit when all the components are x64...so i think those instructions were removed.  I would add the x32 part back into the documentation.  Thanks so much.  Mike.

@tseward - regarding the part that was removed in issue 17.. maybe it should be added back as a workaround mentioned above? Thoughts?
@michaelvgibson - thanks for help on this! Much appreciated to make the docs better!

@michaelvgibson - I was able to get this into the backlog for the SharePoint team. The team will get this prioritized into a sprint plan. Thank you for reporting and making the docs better. Much appreciated. And sorry for the long delay!
@bentoncity - I added this to the backlog so we can prioritize in upcoming sprint. Just FYI so if you see it you know. I added all the notes too so we can find the right team to get this addressed on product team.
I made a note to request the team to update this when the work is complete.

@kenwith  any time, glad I could help out.  Keep up the good work.

re-added location path for 32-bit cliconfg.exe on server and republished this topic.


polkavm: Add a knob to control sbrk instruction enablement

Currently, we enable sbrk instruction by default, however we do want to a mechanism to control it for the guest. This patch aims to just do that.
if sbrk is disabled, host should trap the guest program.
A basic test is also added that confirms the same.
Note, since we charge gas per compile block, and not executed instruction, in the test we add a fallthrough().
Fixes: #167

In general we always charge gas on a basic block basis, and when we enter a basic block we charge the gas. This applies to both the recompiler and the interpreter, and they should charge in the same way, otherwise it's a bug. (All of the tests which start with tracing_ actually run both the recompiler and the interpreter at the same time and make sure they behave exactly the same.)
So, few points:

There should not be an fallthrough instruction in the test program. (The only reason why fallthrough exists is that we allow only jumps to the beginning of basic blocks, so you need some sort of a dedicated instruction to forcefully start a basic block if the place you want to jump to doesn't have a control flow instruction there already. In this case there are no jumps, hence no fallthrough is necessary.)
You still need to modify the interpter's compile_block. That function essentially goes through a whole basic block and calculates the gas cost for it, but right now it's not stopping on the sbrk, so the calculation's going to be wrong.
There's also an issue of jumps - if sbrk's going to be treated as a trap then the instruction after it should also be treated as a valid place to jump to, but ignore this for now. I'm currently working on something related to this so I'll clean it up later myself (this is probably currently subtly broken anyway in certain corner cases).

noted, thanks for the pointers!
It looks like GasVisitor do not have any module config passed to it, so I had to make start_new_basic_block public and call it from compile_block. Let me know if that doesn't work.


DeviceName XML docs

There are properties like DeviceName that appear everywhere:
https://github.com/neurogears/onix-refactor/blob/260149bdfb441c8d49a606bbfd303728cbc42bd0/OpenEphys.Onix/OpenEphys.Onix/AnalogInput.cs#L15

Is there some strategy for pulling XML comments for properties like this from a common source? It looks like <inheritdoc> might work even though these are often not inherited properties (https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/xmldoc/recommended-tags#inheritdoc)
Do we want to tailor Properties like this to the node they belong to or just provide a single generic description?

Cris verified that <inheritdoc> works. I think this is the preferred method for repeating docs.
We should try to target the actual XML content to the most base version of the property or type. In the case there is no hierarchy, use the first occurrence by alphabetical order.


[nb_conda_kernels] couldn't call conda

Hello,
I have installed nb_conda_kernels with conda install nb_conda_kernels as mentionned in the installation guide.
It seems that nb_conda_kernels does not find conda as I get the error message [nb_conda_kernels] couldn't call conda.
I use jupyterlab with python 3.7 in my base env, I did not install the Anaconda distribution at the default location and I use zshell as my default shell.
I suppose I should mention the conda path somewhere but I don't know where.

What version of nb_conda_kernels are you using? What does conda list nb_conda_kernels say?

I'm going to close this as stale, but please feel free to re-open if you can provide a bit more information for us to reproduce this. In particular, please provide the version of nb_conda_kernels and the output of the conda info command.


Be more robust when interpreting the intended target of URLs in a page

Bonus: Introduce tests

@abepetrillo  review?

LGTM :+1:

Thanks! 😄


Early move when clicking a piece on mobile

When touching a piece, there is often a move right away, when the user just wants to activate the piece.
Steps to reproduce

Start a new puzzle on android
Click a piece

Expected outcome
The piece should be selected and ready to be moved
Actual outcome
The piece is selected, and moved left/top in the same action
Screenshot/recording
TODO

Fixed in 2cb89855b28ded3e550e15ee0c4117994735e246


feat: replacing bytes.Buffer instances used only to generate strings with strings.Builder.

Ref #223

Coverage remained the same at 99.861% when pulling e2c50d89f09a482a475742848f6bd1a6d84130d7 on ellisonleao:issue-223 into 06e96ce09683498c71cf9223a113a5e4feb7d86f on maxatome:master.

done @maxatome

My bad, by renaming SliceToBuffer to SliceToString I also meant changing the signature from using *bytes.Buffer to *string.Builder. Sorry.

@maxatome any suggestions on how to handle buf.Truncate() and buf.Bytes(),  since they don't exist in strings.Builder?

buf.Bytes() is used by bytes.LastIndexByte so it can be replaced by buf.String() and strings.LastIndexByte;
buf.Truncate() call can be avoided by reworking the preceding loop:buf.WriteString(IndentString(ToString(items[0]), prefix))
for _, item := range items[1:] {
  buf.WriteString(",\n")
  buf.WriteString(prefix)
  buf.WriteString(IndentString(ToString(item), prefix))
}

(not tested :) )

done @maxatome

Thanks a lot @ellisonleao ! 😉 And welcome as go-testdeep contributor.


Add host services tracing spans

Proposed change
Right now the open telemetry tracing support is limited to just the execution trigger handler on functions. We want to expand this so that we can create child spans that maintain the appropriate parent for all of the host services, including kv, object store, and messaging.
Use case
We want to see child spans every time a function utilizes a host service capability
Contribution
No response

This follows from #128


Update card borders

I noticed that you updated the Card component to have borders. On the admin panel, this currently looks like this:

To be honest, I think this is quite noisy/incoherent. In the Discord-channel, Dan said that Filament was always internally using the <x-filament::card> component, also for the stats overview widget. I could not find that relation, because for the stats overview, you have a separate Blade component in packages/admin/resources/views/components/stats/card.blade.php.
Restoring admin panel design
Anyways, I updated the packages/admin/resources/views/components/card/index.blade.php component, so that it doesn't have a border anymore. This change did not impact the Card component from the Forms package, so it basically restores the dashboard design to its 'old' look.
Card component
Second, I took a look at the Card component. This is an example from the admin panel with a dummy card and section about how it currently looks:

Personally I think that the shadows on the grey background are bit too heavy when you compare it with the relationmanager below it. It is not really the same style.
The fix for this is very simple: remove the shadow from both the Card and the Section component. This makes the design of both components more consistent with the design/border of the relationmanagers:

If I'm really honest, I still prefer the old design with only the shadow and no borders, but otherwise I don't have a good idea on how to fix the problem that the Card isn't visible on white backgrounds.

PS: can you explain what the variable $flat exactly does in the Card component?

Nice, I removed the $flat variable.

Thank you


Create a "demo DAO" and add it to the website as part of a "try it out!" section

The idea of this section is to make a "show, don't tell" version of the registration flow, and help people get an immediate sense of the value of adopting 4824 and related standards.

Adding update from telegram text by Joni

Arbitrum Grant work
Aman and I set out astructure for a series of loom videos and materials around eip 4824. This was a request from GMX and will help us scale to other DAOs that need to explain what it is to many stakeholders: Aiming to have transcripts and materials complete by end of next week, and hopefully all recordings too.

Awesome!
On Tue, Jan 23, 2024 at 3:33 PM Rashmi V Abbigeri @.***>
wrote:

Adding update from telegram text by Joni
Arbitrum Grant work
Aman and I set out astructure for a series of loom videos and materials
around eip 4824. This was a request from GMX and will help us scale to
other DAOs that need to explain what it is to many stakeholders: Aiming to
have transcripts and materials complete by end of next week, and hopefully
all recordings too.
—
Reply to this email directly, view it on GitHub
https://github.com/metagov/daostar/issues/31#issuecomment-1906873473,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACHA5PDYJNE3QPXFCXIU3PLYQANC3AVCNFSM6AAAAAAUCQ4RK2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBWHA3TGNBXGM
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
http://www.joshuatan.com/research/

@amanwithwings Could you please share recordings on how to adopt EIP-4824 if they are ready and if you have access?

@Rashmi-278, this is not final but have a look: https://www.loom.com/share/folder/d43a500f904e414eb45c91f5a6150318


Appstudio update test-component-pac-wuxg

Pipelines as Code configuration proposal

Pipelines as Code CI/test-component-pac-wuxg-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
13 seconds
clone-repository

✅ Succeeded
43 seconds
build-container

✅ Succeeded
23 seconds
deprecated-base-image-check

✅ Succeeded
22 seconds
inspect-image

✅ Succeeded
45 seconds
clamav-scan

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
16 seconds
sbom-json-check

✅ Succeeded
15 seconds
optional-label-check

✅ Succeeded
15 seconds
label-check

✅ Succeeded
8 seconds
show-summary

Pipelines as Code CI/test-component-pac-wuxg-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
16 seconds
clone-repository

✅ Succeeded
42 seconds
build-container

✅ Succeeded
11 seconds
inspect-image

✅ Succeeded
9 seconds
deprecated-base-image-check

✅ Succeeded
8 seconds
clair-scan

✅ Succeeded
33 seconds
clamav-scan

✅ Succeeded
14 seconds
sbom-json-check

✅ Succeeded
12 seconds
label-check

✅ Succeeded
11 seconds
optional-label-check

✅ Succeeded
7 seconds
show-summary


Keep all settings (+Keybindings, +Snippits) in .code-workspace file.

This is - fairly spoken, a duplicate of #4504 and also my old much older issue which no longer turns up.
While most of that request was implemented, the one missing feature was keybinding settings being rolled into a settings.json.
There are two aspects that make this differ- which Ill explain, and present a use case, that may make this more attractive to add.  I also believe it to be relatively low hanging fruit.
Extensions, Roots,  Tasks, Launchers, are able to be loaded into a file for .code-workspace.
I would like to see- the last two settings, Snippits, and Keybindings rolled into this space.
This is desirable for two reasons- one- it rolls up all  my settings for a project into a single file - This is mostly a useful template to start another file, but it also allows me to collect customizations specific to that project.
I use this because I use Code in several different "contexts", not a single one.  There is still, as I complained in my initial feature request, a simple way to switch contexts.
As an  implementation, you could make it excessively passive (as with extension recommendations) so much so that  its useless, but at least its saved there...
My principle goal is to be able to switch context easily.  This is a python project. Pull in python workspace file,  all those extensions load, keybindings, load, settings load, and tasks load.
The critical use case that is overlooked at this time, when suggesting a workaround for #4504 is when collecting tasks and assigning them keybindings.  They should be kept together.

Though it is mentioned that "This is a personal setting" there are those of us who want this.  With the extensions. and hopefully snippits and keybindings, ask us for each if wed like to incorporate them.


allow wild menu to be above statusline

would it be possible to allow the wildmenu to be above the statusline?
(open it on a row 1 smaller?)

Why the feature is needed?

Maybe because the floating window hides the statusline and the OP wants to see the statusline (filename, etc.)

you can try this patch:
diff --git a/lua/cmp/view/wildmenu_entries_view.lua b/lua/cmp/view/wildmenu_entries_view.lua
index 3419164..ce3eeda 100644
--- a/lua/cmp/view/wildmenu_entries_view.lua
+++ b/lua/cmp/view/wildmenu_entries_view.lua
@@ -127,7 +127,7 @@ wildmenu_entries_view.open = function(self, offset, entries)
   self.entries_win:open({
     relative = 'editor',
     style = 'minimal',
-    row = vim.o.lines - 2,
+    row = vim.o.lines - 3,
     col = 0,
     width = vim.o.columns,
     height = 1,

If this works for you, you can create a pull requests which makes the row offset configurable.

works for me
I'll open a pr soon

I think the nvim-cmp should not have any view related features except the default float-win menu.
But for now, I can accept PR.

Perhaps you could add a table with which you deep_extend the window options

Quick note about this:
if cmdheight is set to 2 (many people do this so error messages don't require a "press any key" interaction to keep working), then the wildmenu window actually covers the command line and you can't even see what you are typing.
@hrsh7th - Would it make sense to calculate the row to display the wildmenu on based on cmdheight instead of a hard coded value?

and make it configurable
sth like:
pos=vim.opt.lines-(user_conf or cmdheight or 2)

Would it make sense to calculate the row to display the wildmenu on based on cmdheight instead of a hard coded value?

It's make sense.
To be honest, I want to remove the wild menu view.
Currently, nvim-cmp has no mechanism for pluggable view-related functionality so I keep it.

why do you want to remove it?

That's because I think it's basically an anti-pattern to absorb the differences in people's preferences in one implementation in one repository.
We could have just a single implementation if you're happy with a few settings, such as prettier, but in reality various requests have been submitted regarding the appearance of nvim-cmp.

Personally, I disagree that it's an anti pattern. My reasoning is that the
average user cannot, or will not, take the extra effort of installing
plugins for his plugins. It becomes much too complicated and highly
fragmented.
There is also the problem of discovery. There is no central way of
informing users of all the various different plugins or sources available
for cmp.
On Mon, 2 May 2022, 19:31 hrsh7th, @.***> wrote:

That's because I think it's basically an anti-pattern to absorb the
differences in people's preferences in one implementation in one repository.
We could have just a single implementation if you're happy with a few
settings, such as prettier, but in reality various requests have been
submitted regarding the appearance of nvim-cmp.
—
Reply to this email directly, view it on GitHub
https://github.com/hrsh7th/nvim-cmp/issues/908#issuecomment-1115099091,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABFXXCZAXEOTUGZISVDPGNDVH77PTANCNFSM5TSO4POQ
.
You are receiving this because you commented.Message ID:
@.***>

I don't think nvim-cmp does not have any built-in sources is make good ecosystem and it does not make   unnecessary effort to the user.
For example, you did make cmo-fuzzy-buffer. it's interesting and might be useful for some users. This is due to current design.

My point is that we need to have a central place where users can find all
of these plugins.
And we need to better document their use.
The flip side of building cmp to be highly configurable is that users will
encounter more issues down the road, where external plugins misbehave. This
will increase the pressure on cmp maintainers (which should probanly
increase in numbers anyway).
On Tue, 3 May 2022, 9:02 hrsh7th, @.***> wrote:

I don't think nvim-cmp does not have any built-in sources is make good
ecosystem and it does not make unnecessary effort to the user.
For example, you did make cmo-fuzzy-buffer. it's interesting and might be
useful for some users. This is due to current design.
—
Reply to this email directly, view it on GitHub
https://github.com/hrsh7th/nvim-cmp/issues/908#issuecomment-1115765497,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABFXXC66OG5RNFPJTNR36RLVIC6RDANCNFSM5TSO4POQ
.
You are receiving this because you commented.Message ID:
@.***>

I think distributed design is cut off the maintein cost.
For example, I don't maintein cmp-ultisnips and cmp-luasnip. It's supporting by other mainteners.
I can focus core functionality and stability.

 You can only do so much. A different approach is to add other maintainers to help alleviate the load.
If you look at other nvim plugins, they are mostly single repo plugins, without having plugins of themselves. The only plugin which comes to mind which does have its own plugins is telescope, and you can see the complexity this adds to setting it up.

My point is that we need to have a central place where users can find all
of these plugins.

I think you can search plugins by https://github.com/topics/nvim-cmp.
I don't think the central repository is needed.  And it seems off topic.

Not sure its off topic; You are talking about changing the core of cmp to make it more customizable, refactoring all of the views (for example) into external plugins. What I am saying is that this will only exacerbate the current problem of cmp users, where it's quite difficult to know which plugins are available and what is the recommended way of using them.

Not sure its off topic; You are talking about changing the core of cmp to make it more customizable, refactoring all of the views (for example) into external plugins. What I am saying is that this will only exacerbate the current problem of cmp users, where it's quite difficult to know which plugins are available and what is the recommended way of using them.

The sources are already splitted.  I think the external view plugins system is nice.
ddu.vim already implements it.

The flip side of building cmp to be highly configurable is that users will
encounter more issues down the road, where external plugins misbehave. This
will increase the pressure on cmp maintainers (which should probanly
increase in numbers anyway).

The one(central) plugin repository really solves the problem?
Have you read telescope.nvim issues?
In telescope.nvim issues, many external sources issues pollutes the issues.
I know nvim-cmp's configuration is complex.  But it seems customization design trade off.

The sources are already splitted. I think the external view plugins system is nice. ddu.vim already implements it(the view is splitted).

Nice should not be driving the decision here.

The flip side of building cmp to be highly configurable is that users will
encounter more issues down the road, where external plugins misbehave. This
will increase the pressure on cmp maintainers (which should probanly
increase in numbers anyway).

The one(central) plugin repository really solves the problem? Have you read telescope.nvim issues? In telescope.nvim issues, many external sources issues pollutes the issues. I know nvim-cmp's configuration is complex. But it seems customization design trade off.
This above is exactly my point. The external plugin issues will pollut cmp. You will find yourself with hundreds of issues not related to core cmp, but to some esoteric external plugin. Placing the burden of decoupling cmp-core and any cmp-plugin on users whenever they have an issue will only hurt adoption of cmp.

I think that cmp is a really amazing piece of code. Extensibility is also a key part of it. But I think success is starting to show its downsides, where you have a large user base and issues start to creep.
I would think about this entire issue from a different perspective. We should ask what is the long term plan for cmp. It started out as a personal project for you @hrsh7th, but I think it is much more than that now.

tbh I don't care if you move the different view to external repositories
just don't remove them

I think that cmp is a really amazing piece of code. Extensibility is also a key part of it. But I think success is starting to show its downsides, where you have a large user base and issues start to creep.

I know the user base is very huge.  I have read key mappings decision(the default key mappings is removed) issues.
I think the decision is right.  But on the user side, it is not right...

I would think about this entire issue from a different perspective. We should ask what is the long term plan for cmp. It started out as a personal project for you @hrsh7th, but I think it is much more than that now.

Current nvim-cmp seems neovim standard auto completion framework.
It is not just hobby product.  It may be a tragedy.

As the developer of telescope.nvim mentioned, I think it's a bad idea to implement features in this repository that I'm not using. They are not maintained and bug reports are difficult to deal with.
Also, if we focus on the "general user", I still think the wildmenu view is subject to deletion.
I want nvim-cmp to be extensible enough to have a wildmenu view.
To do this, we need to provide the appropriate plugin system or extension point to userland.

I can understand the user expectation that I want to enable my favorite feature via one line config.
But it's the endless way. If we choose this approach, we have to introduce thousand configuration options.

imo your goal shouldn't be to allow users to enable their favorite features via one line config.
But you should allow all the favorite features to be enabled somehow by perhaps exposing window options or something similar (like e.g. telescope pickers do since we're talking about that)
For the wildmenu I don't care if you move it to a different repository but it something really useful and you should keep it somewhere.

For the wildmenu I don't care if you move it to a different repository but it something really useful and you should keep it somewhere.

As the original author of the PR, it's nice to hear :)
@hrsh7th, it's your project, you should decide on how to move forward. I would be happy either way.

another thing kinda related to this
you should also allow the normal menu to be moved because:


[firebase_auth] codeAutoRetrievalTimeout callback never called

Using the flutterfire firebase_auth plugin and its example project I stumble upon the following issue:
The callback for auto retrieval timeout is never called. It should be called after the duration specified in the verifyPhoneNumber(...) call.
I assume firebase is set up correctly for my app, as auto authentication works fine when using a real number. Using a second device to receive a verification code however is not straight forward. In principle it would be possible to show a "please insert verification code" - text field after the "code sent" callback. But this is more a hacky workaround and completely ignores the timeout feature.
It would be nice to only show the verification code text field after the auto verification timed out. This is currently not possible.

@t-fi
The issue at https://github.com/flutter/flutter/issues/22725 has been closed and moved here. Future collaboration on this issue will be done here.

I believe the issue is already fixed in https://github.com/flutter/plugins/pull/1398


Cannot create projects using scoped PAT

Hello!

I am seeing 401 Unauthorized messages when attempting to create Azure DevOps projects using a PAT that has been scoped. The interesting thing is, even if I select ALL scopes under the Custom Scope settings of the token, I am still seeing the same 401 error.
If, however, I revert to Full Scope access for my token, everything works.

Vote on this issue by adding a 👍 reaction
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already)

Issue details

Steps to reproduce

Create an Azure DevOps Personal Access Token
Under Scopes choose Custom defined
For the sake of testing, select ALL scopes.
Use the project resource to create a new project

Expected:
New Azure DevOps project to be created.
Actual:
error: Request returned status: 401 Unauthorized
error: update failed

snippet from the verbose logging generated:
I1028 11:23:59.820606   25989 provider_plugin.go:1523] provider received rpc error `Unknown`: `Request returned status: 401 Unauthorized`
I1028 11:23:59.820674   25989 provider_plugin.go:1526] rpc error kind `Unknown` may not be recoverable
I1028 11:23:59.820691   25989 provider_plugin.go:758] Provider[azuredevops, 0xc001608540].Create(urn:pulumi:shared::kirk-iadp-core-shared::azuredevops:index/project:Project::adp-shr-uks-adoproj-data-platform) failed: Request returned status: 401 Unauthorized
I1028 11:23:59.820748   25989 eventsink.go:86] eventSink::Error(<{%reset%}>Request returned status: 401 Unauthorized<{%reset%}>)
I1028 11:23:59.820841   25989 snapshot.go:316] SnapshotManager: createSnapshotMutation.End(..., false)
I1028 11:23:59.820857   25989 snapshot.go:536] SnapshotManager.markOperationComplete(urn:pulumi:shared::kirk-iadp-core-shared::azuredevops:index/project:Project::adp-shr-uks-adoproj-data-platform)
error: Request returned status: 401 Unauthorized
I1028 11:24:00.163809   25989 step_executor.go:327] StepExecutor worker(2): step create on urn:pulumi:shared::kirk-iadp-core-shared::azuredevops:index/project:Project::adp-shr-uks-adoproj-data-platform failed with an error: Request returned status: 401 Unauthorized
I1028 11:24:00.163863   25989 step_executor.go:327] StepExecutor worker(2): step create on urn:pulumi:shared::kirk-iadp-core-shared::azuredevops:index/project:Project::adp-shr-uks-adoproj-data-platform failed, signalling cancellation

Provider versions affected: 2.1.1 2.20

Per the TF upstream docs:

The account corresponding to the token will need "owner" privileges for this organization

I take this to mean that a scoped token will not work with this provider. Submitting a PR to update our docs.


bug: Failure to Dispense to Trashbin

Overview
I am using an OT-2 with a protocol I initially designed on api 2.15.
Originally, I was able to dispense supernatant using the transfer() command, with protocol.fixed_trash['A1'] as the destination.
When updating the protocol to 2.16, I get the error saying that TrashBin is not subscriptable, which is what is laid out in the API docs.
However, when I remove the supscript, ultimately removing the well, I get the following error in both the simulator and when uploading to the robot.
TypeError [line 217]: <opentrons.protocol_api._trash_bin.TrashBin object at 0x0000018CC05D32E0>

Now this could full well be an understanding issue on my part, in which case I would like the API docs to be updated, because they are now unclear to how one would dispense to trashbin on OT-2.
Steps to reproduce
Here's the transfer command I use within a for loop to transfer a supernatant to the trash. This is after I removed the well specification.
        left_pipette.transfer(
            300,
            column[0],
            protocol.fixed_trash,
            new_tip="once"
        )

I see the documentation has been updated to clarify that the trashbin cannot be used as a well anymore. Is there any way that functionality may return in later versions?


feat(noir-libs): unify Private and Public Context Apis

See https://github.com/AztecProtocol/aztec-packages/issues/1358 for more information
Currently public functions have no context object, which leads them to have completely different code paths to the private counter part, even if the goal of the function is the same.
Currently a private function looks as follows:
    fn transfer(
        //*********************************/
        // Should eventually be hidden:
        inputs: PrivateContextInputs,
        //*********************************/
        amount: u120,
        sender: Field,
        recipient: Field,
    ) -> distinct pub abi::PrivateCircuitPublicInputs {
        let mut context = Context::new(inputs, abi::hash_args([amount as Field, sender, recipient]));

As a reminder, here's that struct:
struct PrivateContextInputs {
    call_context : CallContext,
    roots: CommitmentTreesRoots,

    contract_deployment_data: ContractDeploymentData,

    private_global_variables: PrivateGlobalVariables,
}

While a public function looks like this:
    fn transfer(
        amount: u120,
        sender: Field,
        recipient: Field,
    )  {
       ...logic

However, there is also a PublicContextInputs struct:
struct PublicContextInputs {
    call_context: CallContext,
    block_data: ConstantHistoricBlockData,

    public_global_variables: PublicGlobalVariables,
}

That contains a call context object.
We should be able to call methods like context.this_address() and context.this_portal_address() with the same syntax in Private and Public contexts.
Note: these contexts will eventually be hidden from the developer, they will be wrapped in macros / handled at the compiler level

Done


Window rule doesn't work, popup windows spawn at first monitor top left regardless of explicitly stating center

Hyprland Version
Hyprland, built from branch  at commit 1b48642fd15c433c53876f1b933dcd46265caf8f dirty (). Tag: v0.30.0  flags: (if any)
Bug or Regression?
Bug
Description
Popup based windows are spawning at the top left of my left monitor, even if the IDE window is on the right monitor?
Window rule:
windowrule = center, class:jetbrains-phpstorm
Debugging:
sleep 5; hyprctl activewindow
Window 55bb7e5da660 -> win5:
	mapped: 1
	hidden: 0
	at: 0,0
	size: 332,69
	workspace: 1 (1)
	floating: 1
	monitor: 1
	class: jetbrains-phpstorm
	title: win5
	initialClass: jetbrains-phpstorm
	initialTitle: win5
	pid: 725147
	xwayland: 1
	pinned: 0
	fullscreen: 0
	fullscreenmode: 0
	fakefullscreen: 0
	grouped: 0
	swallowing: 0

How to reproduce
Exists for everyone just installed lasted hyprland, jetbrains and see for yourself.
Crash reports, logs, images, videos
No response

above should fix
@vaxerski


swift-button-functional-test job failing due to changes in sign in flow

The swift-button-functional-test job appears to no longer pass, likely due to changes in the sign in flow. I was able to get parts of the test case to pass, but not reliably. Running locally on a simulator, I would occasionally see the sign in flow succeed, and other times I would see a screen telling me that Safari was unable to contact the server.
Since this test is not passing, and is blocking the beta release of AppCheck support within GSI, I am going to disable this job. This is not harmful since this test is completely unrelated to AppCheck, and the AppCheck tests (including integration) are passing.
We should nonetheless follow up on this and fix the issue.

Need to make sure to re-enable this test and revert the if check back to if: "!github.event.pull_request.head.repo.fork".

Closed via https://github.com/google/GoogleSignIn-iOS/pull/434


azure: Request inspection missing for polling requests

I have a request/response inspector set on the client that prints every request/response. For Azure long-running operations the inspection for the polling "requests" is missing (but their response is inspected just fine):

Azure request  method="PUT" request="https://management.azure.com/subscriptions/27b750cd-ed43-42fd-9044-8d75e124ae55/resourceGroups/docker-machine/providers/Microsoft.Network/networkSecurityGroups/foo0-firewall?api-version=2015-06-15"
Azure response  method="PUT" request="https://management.azure.com/subscriptions/27b750cd-ed43-42fd-9044-8d75e124ae55/resourceGroups/docker-machine/providers/Microsoft.Network/networkSecurityGroups/foo0-firewall?api-version=2015-06-15" x-ms-request-id="e992d5dd-0255-4e8b-bff8-e9aeb49b5c3d" status="201 Created"
Azure response  x-ms-request-id="dc65e42f-569a-4a29-b9dd-bbcd6e17ae49" status="200 OK" method="GET" request="https://management.azure.com/subscriptions/27b750cd-ed43-42fd-9044-8d75e124ae55/providers/Microsoft.Network/locations/westus/operations/e992d5dd-0255-4e8b-bff8-e9aeb49b5c3d?api-version=2015-06-15"

so the request of the last response is missing.

@ahmetalpbalkan This should be fixed in the PR I just submitted. The problem was where I had been invoking the WithInspection (and WithAuthorization) PrependDecorators. They were called during the creation of the initial polling / async request. They should be called just before each use of that request (i.e., moved into Client#Do). I've moved them.

thanks. fixed.


Question about rlbench depth data

I found that the generated depth data from gen_demonstration was quite different from other depth data. Do you think it is a intended result?

This seems ok. As the depth data is saved as a single channel image, such visualization results seem to be display issues. The converted point cloud seems good in Meshlab.

Btw have you ever reproduced the results reported in the paper? It seems hard to reproduce the performance shown in the paper.

Thanks for the reply !
I haven't tried the evaluation since there was a problem when trying to run evaluation code inside of the docker , but the reconstructed image shown in wandb wasn't good.
Are you meaning the success rate?

Sorry for the late reply. The reconstruction results seem normal, as the action loss plays a main role in the optimization, the reconstruction should seem relatively poor. The reconstruction quality does not affect the action prediction because we decode the robot action from the volumetric representation rather than the Gaussians (in the test phase, the Gaussian regressor and deformation field are not used).
However, though the training and evaluation processes still fluctuate even with the seed fixed, the provided scripts should reproduce the results without problem... thanks for your detailed experimental logs, I think there are several things to try: 1. evaluate the 'best' checkpoint rather than 'last' (maybe 90000 steps), sometimes the performance of the 'last' checkpoint drops slightly. 2. just evaluate the checkpoint again.

This seems ok. As the depth data is saved as a single channel image, such visualization results seem to be display issues. The converted point cloud seems good in Meshlab.
Btw have you ever reproduced the results reported in the paper? It seems hard to reproduce the performance shown in the paper.

Thanks for your answer. Yes the depth image is quantized by rlbench, so the visualization may seem weird. See https://github.com/GuanxingLu/ManiGaussian/blob/main/third_party/RLBench/rlbench/backend/utils.py for more details.

Actually, I encountered a same problem. Even with the best ckpt evaluation strategy, the average success rate of ManiGaussian (with scripts/train_and_eval_w_geo_sem_dyna.sh) is only 35.6 less than the 44.8.  @GuanxingLu We will appreciate, if you can provide some suggestions. Thanks!

Hello, thanks for your interest. Can you evalute the checkpoints of 90k and 100k again to see if there is any change of the performance? As you could find in the attached csv in the released checkpoint, the performance fluctuate between 39.20 and 44.80  even with the same checkpoint and same random seed. Besides, I'm planning to train with the provided script in a new server, stay tuned.

Thanks for your reply. After re-evaluating the 90k and 100k ckpt, the successful rate goes to 34.0 and 33.6 as shown in the last two lines, which far from the 39.2 or 44.8 as reported in the paper... :(


Can you debug Edge extensions?

I'm just curious, using the Debugger for Edge in VS Code, can you debug Edge browser extensions or is the debugger only available to pages?

At this point in time our debugger can only debug pages. Neither in Edge or Chrome.


Allow more sophisticated proxy rules

Along the lines of dansguardian for squid -- thanks to Ashish:
 <category name="videosites" action="warn">
  <rule>        <url> youtube.com </url>
  </rule>
  <rule>        <urlpattern> *video*.* </urlpattern>
  </rule>
</category>

another action.xml file contains

  <action name="warn" log="yes">
       <message> the URL $url you are visting is not productive to this network. It falls in ${category.name} category. Do you still want to visit? Click yes or no
       </message>
   </action>

<action name="block" log="yes">
       <message> the URL $url you are visting is not productive to office usage. It falls in ${category.name} category. It is blocked.
       </message>
   </action>

</actions>

@adamfisk - I think you could implement this functionality pretty easily using the filters. I think a good place for this would be a separate project incorporating LittleProxy, or a separate "extras" project that can be used with LittleProxy (similar to what Ox described in #173). What do you think?

Yup sounds right @jekh. Closing for now.


#4120 improved error message

Description
Added a more informative error message when I passed an invalid parameter set, which rejects that parameter set and relays a list of potential paramters that could be inputted
Fixes #4120
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

[ ] New feature (non-breaking change which adds functionality)
[ ] Optimization (back-end change that speeds up the code)
[ ] Bug fix (non-breaking change which fixes an issue)

Key checklist:

[x] No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
[ ] All tests pass: $ python run-tests.py --all (or $ nox -s tests)
[ ] The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).
Further checks:

[x] Code is commented, particularly in hard-to-understand areas
[ ] Tests added that prove fix is effective or that feature works

@all-contributors please add @Ubham16 for code


Error in Turnipprophet

Have you forced a refresh in your browser (e.g. ctrl+F5 in Chrome/Firefox)?

yes - on mobile. Tried in Safari and Chrome

Have you made sure the first time buyer option is correct? If you're unsure, try it both ways

yes

Have you time-travelled this week? Travelling backwards resets the prices, and therefore you must not put prices in from both before & after the time-travel

no, I haven’t TT’d this week

Describe the bug
Turnip Prophet won’t show price predictions. It worked before 12 today. But is not working after.
To Reproduce
Steps to reproduce the behavior:

Go to ACNH.Guide app
Enter turnip price
Click on 'View on Turnipprophet”
Page opens in Safari
Scroll down to 'Output’
See error under Daisy Mae: “Oops! There seems to be an error with your turnip predictions. Please check your inputs.

If your turnip prices are correct and you have not time traveled, please submit a report.”
Permalink to your prices
https://turnipprophet.io/?prices=92.123.153..........&pattern=2
Screenshots

Smartphone (please complete the following information):

Device: iPhone XS
OS: 14.3
Browser: Safari
Version: 14

Additional context
I didn’t purchase turnips on my own island. Will that affect the prediction?

Still “broken” after entering today’s morning sell price of 132. One the predictions before it broke was a small spike so it was right on that front!

Still “broken” after entering today’s morning sell price of 132. One the predictions before it broke was a small spike so it was right on that front!


bug: Not able to customise the ion-toggle component.I just want to adjust the height and toggle knob size as well.

Hi,
Looking for customisation of the ion-toggle component in ionic 5.I just want to adjust the height and toggle knob size as well.  Please suggest how to achieve this.

Thanks for the issue. I am going to close this as a duplicate of https://github.com/ionic-team/ionic/issues/20474.


Use marshmallow schema to validate notification json

The advantage of doing it this way is we can clearly see how the json
should look like and we don't have to rewrite validation code for other
APIs that also accept custom json.

On Friday in discord, we talked about using marshmallow schema for validation so I tried it out.

I'm making some small changes to this branch:
diff --git a/app/extensions/__init__.py b/app/extensions/__init__.py
index 08ecda4d..85aac751 100644
--- a/app/extensions/__init__.py
+++ b/app/extensions/__init__.py
@@ -82,29 +82,55 @@ from . import stripe  # NOQA

 class ExtraValidationSchema(Schema):
     @validates_schema(pass_original=True)
-    def validates_schema(self, data, original_data):
+    def validates_schema(self, cleaned_data, original_data):
         """
+        This method is called after the built-in validation is done.
+        cleaned_data is what is left after validation and original_data
+        is the original input.
+
         Raise validation error if there are extra fields not defined in
         the schema.

-        This is necessary because marshmallow (before 3.13.0) just
+        This is necessary because marshmallow (before 3.0.0) just
         ignores extra fields without any validation errors.
         """
-        if data is None:  # something wrong with the data, skip
+        if cleaned_data is None:  # Wrong type given, nothing to validate
             return
         valid_fields = sorted(self.fields.keys())
         unknown = set(original_data) - set(valid_fields)
         if unknown:
             raise ValidationError(
-                f'Unknown field(s): {", ".join(unknown)}, options are {", ".join(valid_fields)}'
+                f'Unknown field(s): {", ".join(unknown)}, options are {", ".join(valid_fields)}.'
             )

     def get_error_message(self, errors):
+        """
+        Validation errors are like this:
+
+        {
+            'all': {
+                '_schema': [
+                    'Unknown field(s): random, options are email, restAPI'
+                ],
+                'restAPI': [
+                    'Not a valid boolean.'
+                ]
+            }
+        }
+
+        This method turns this into an error message like:
+
+        "all": Unknown field(s): random, options are email, restAPI.
+        "all.restAPI": Not a valid boolean.
+        """
         error_keys = list(errors.keys())
         if error_keys == ['_schema']:
             return ' '.join(errors['_schema'])

         def get_error(errors, results, _keys=[]):
+            # Traverse down the error structure depth first so we can get the
+            # actual field name.  For example in the example above, we want
+            # "all.restAPI" as the field name.
             for key in errors:
                 if isinstance(errors[key], dict):
                     if key == '_schema':
diff --git a/app/modules/notifications/models.py b/app/modules/notifications/models.py
index 9bc3dba2..b86e1534 100644
--- a/app/modules/notifications/models.py
+++ b/app/modules/notifications/models.py
@@ -198,7 +198,7 @@ class NotificationPreferences(HoustonModel):
         from .schemas import NotificationPreferenceSchema

         schema = NotificationPreferenceSchema()
-        data, errors = schema.load(new_prefs)
+        errors = schema.validate(new_prefs)
         if errors:
             raise HoustonException(log_message=schema.get_error_message(errors))

diff --git a/app/modules/notifications/schemas.py b/app/modules/notifications/schemas.py
index 108423eb..59a98184 100644
--- a/app/modules/notifications/schemas.py
+++ b/app/modules/notifications/schemas.py
@@ -4,7 +4,6 @@ Serialization schemas for Notifications resources RESTful API
 ----------------------------------------------------
 """

-import marshmallow
 from flask_restx_patched import ModelSchema
 from flask_marshmallow import base_fields

@@ -14,13 +13,13 @@ from .models import Notification

 class NotificationPreferenceSchema(ExtraValidationSchema):
     class NotificationChannelSchema(ExtraValidationSchema):
-        restAPI = marshmallow.fields.Bool()
-        email = marshmallow.fields.Bool()
+        restAPI = base_fields.Bool()
+        email = base_fields.Bool()

-    all = marshmallow.fields.Nested(NotificationChannelSchema)
-    raw = marshmallow.fields.Nested(NotificationChannelSchema)
-    collaboration_request = marshmallow.fields.Nested(NotificationChannelSchema)
-    merge_request = marshmallow.fields.Nested(NotificationChannelSchema)
+    all = base_fields.Nested(NotificationChannelSchema)
+    raw = base_fields.Nested(NotificationChannelSchema)
+    collaboration_request = base_fields.Nested(NotificationChannelSchema)
+    merge_request = base_fields.Nested(NotificationChannelSchema)

 class BaseNotificationSchema(ModelSchema):
diff --git a/tests/modules/notifications/test_models.py b/tests/modules/notifications/test_models.py
index 7dbbd581..02f2acc7 100644
--- a/tests/modules/notifications/test_models.py
+++ b/tests/modules/notifications/test_models.py
@@ -77,12 +77,14 @@ def test_validate_preferences():
         NotificationPreferences.validate_preferences({'random': 'value'})
     assert (
         str(exc.value)
-        == 'Unknown field(s): random, options are all, collaboration_request, merge_request, raw'
+        == 'Unknown field(s): random, options are all, collaboration_request, merge_request, raw.'
     )

     with pytest.raises(HoustonException) as exc:
         NotificationPreferences.validate_preferences({'all': {'random': True}})
-    assert str(exc.value) == '"all": Unknown field(s): random, options are email, restAPI'
+    assert (
+        str(exc.value) == '"all": Unknown field(s): random, options are email, restAPI.'
+    )

     with pytest.raises(HoustonException) as exc:
         NotificationPreferences.validate_preferences({'all': {'restAPI': 'wrong_type'}})
@@ -94,7 +96,7 @@ def test_validate_preferences():
         )
     assert (
         str(exc.value)
-        == '"all.restAPI": Not a valid boolean. Unknown field(s): random, options are all, collaboration_request, merge_request, raw'
+        == '"all.restAPI": Not a valid boolean. Unknown field(s): random, options are all, collaboration_request, merge_request, raw.'
     )

     # Valid examples

Next I'd like to try schema validation with asset group sighting json which was what we were actually discussing on Friday.

Next I'd like to try schema validation with asset group sighting json which was what we were actually discussing on Friday.

I'd suggest that's a separate PR. This one is already really quite big

/rebase


refactor: add git hook check

Signed-off-by: Frankzhaopku<EMAIL_ADDRESS>Use husky + commitlint + lint-staged to add git hook check for project.
Which will do:

run tslint on pre-commit to make sure the code style is correct.
run commit message check using commitlint to make sure the commit message is in correct style.
run npm run test-local on pre-push to make sure the test passed.

close #265

/rerun jenkins


add bert examples

Hi @Wesley-Jzy , can you provide a detailed readme instead of an empty one?

@FrankLeeeee Thanks for review. It's still on the way since I try to fathom how to change model for TP and PP features now. I will add detailed README and delete code duplication in the final submit.


qmake paths and license

Thanks for creating this, it's very useful.
There's two things missing:

The Qt folder is not relocatable, there's a hard-coded install path /home/qt/work/install. This can be changed by putting a qt.conf file in the same directory as the qmake executable with the following contents:
[Paths]
Prefix = ..

qmake is not usable when not agreeing to the license, which should be done with:
sed -i.bak 's/Enterprise/OpenSource/g' /path/to/mkspecs/qconfig.pri
sed -i.bak 's/licheck.*//g' /path/to/mkspecs/qconfig.pri

@haampie

Do you suggest adding an option that forwards supplied value to a generated qt.conf?
I tend to use CMake and, thus, did not face this issue. This one clear enough, though. I will move it to a separate issue so that it can be tracked individually.

@haampie @marcusl Please see if #8 does what you want.

Hey, I'm no longer working on Qt projects anymore!

@haampie Come back to the dark side, we will be waiting for ya 😈


Don't log "expected" websocket errors

Fixes #1019
Upgrading gorilla/websocket also makes the logging a bit nicer for the other errors.

Do we also want this in app/controls.go:82 and app/pipes.go:44?

We don't actually do anything with those errors, so...

Otherwise LGTM.

Turns out 1005 is also a valid websocket closing. It just means the other end sent a close frame with no reason specified.


get_bundle_all_angle: overlapping wires

Describe the bug
get_bundle_all_angle will generate overlapping wires for certain geometry.
To Reproduce
Run the code sample below.
Code to reproduce
import gdsfactory as gf
from gdsfactory.routing.all_angle import get_bundle_all_angle

NUM_WIRES=10

@gf.cell
def inner_array():
    c = gf.Component()
    base = gf.components.straight(cross_section=gf.cross_section.strip).rotate(45)
    for x in range(10):
        for y in range(6):
            base_ref = c.add_ref(base).move((x*20 - 90, y*20 - 50))
            c.add_port(f"inner_{x}_{y}", port=base_ref.ports['o1'])
    return c

@gf.cell
def outer_array():
    c = gf.Component()
    base = gf.components.straight(cross_section=gf.cross_section.strip)
    for idx, theta in enumerate(range(0, 360, 6)):
        base_ref = c.add_ref(base).move((300, 0)).rotate(theta)
        c.add_port(f"outer_{idx}", port=base_ref.ports['o1'])
    return c

@gf.cell
def chip():
    c = gf.Component()
    inner = c << inner_array()
    outer = c << outer_array()
    routes = get_bundle_all_angle(
        ports1=inner.get_ports_list()[:NUM_WIRES],
        ports2=outer.get_ports_list()[:NUM_WIRES],
        cross_section=gf.cross_section.strip,
        bend=gf.components.bend_euler,
    )
    for route in routes:
        c.add(route.references)
    return c

if __name__ == "__main__":
    # c = inner_array()
    # c = outer_array()
    gf.get_active_pdk().register_cross_sections(strip=gf.cross_section.strip)
    c = chip()
    c.show(show_ports=True)

Expected behavior
Wires generated by the same get_bundle_all_angle call do not overlap.
Suggested fix
This may be a symptom of me misusing a very new feature, rather than an actual bug. If so, documentation on how to use this tool appropriately would be sufficient to close this issue.
If this is an actual bug (i.e. wires are not expected to overlap), maybe have wires run in parallel as long as possible, then fanout? This seems like a particularly complex problem, though.

CC @tvt173 for all-angle routing.

wow, quite an interesting example you give... adding a snapshot for reference...

this is currently a limitation when you have the case of a "direct" connection like this, with no steps defined. essentially bundling logic is ignored. this case is especially tricky, because the input/output ports are not facing each other, so the route needs to do an around-the-back S to acheive the connection. to really properly bundle in this case, the outer routes would need to either use a 180 euler with larger bend radii or insert a straight between two 90(ish) bends... that is also not supported right now. so, in this case, each route essentially does its best on its own, without consideration for the bundle. my suggestion to fix it, at this point, would be to bundle by hand, with custom steps, like shown below:
import gdsfactory as gf
from gdsfactory.routing.all_angle import get_bundle_all_angle

NUM_WIRES=10

@gf.cell
def inner_array():
    c = gf.Component()
    base = gf.components.straight(cross_section=gf.cross_section.strip).rotate(45)
    for x in range(10):
        for y in range(6):
            base_ref = c.add_ref(base).move((x*20 - 90, y*20 - 50))
            c.add_port(f"inner_{x}_{y}", port=base_ref.ports['o1'])
    return c

@gf.cell
def outer_array():
    c = gf.Component()
    base = gf.components.straight(cross_section=gf.cross_section.strip)
    for idx, theta in enumerate(range(0, 360, 6)):
        base_ref = c.add_ref(base).move((300, 0)).rotate(theta)
        c.add_port(f"outer_{idx}", port=base_ref.ports['o1'])
    return c

@gf.cell
def chip():
    c = gf.Component()
    inner = c << inner_array()
    outer = c << outer_array()
    inner_ports = inner.get_ports_list()
    outer_ports = outer.get_ports_list()
    for n_route in range(NUM_WIRES):
        routes = get_bundle_all_angle(
            ports1=[inner_ports[n_route]],
            ports2=[outer_ports[n_route]],
            cross_section=gf.cross_section.strip,
            bend=gf.components.bend_euler,
            start_angle=-40,
            steps=[{'ds': (NUM_WIRES - n_route) * 20},]
        )
        for route in routes:
            c.add(route.references)
    return c

if __name__ == "__main__":
    # c = inner_array()
    # c = outer_array()
    gf.get_active_pdk().register_cross_sections(strip=gf.cross_section.strip)
    c = chip()
    c.show(show_ports=True)

which gives

wow, quite an interesting example you give {...}

Just a quick-and-dirty toy design made for the sole purpose of isolating this and #1252 :slightly_smiling_face:

{...} my suggestion to fix it, at this point, would be to bundle by hand {...example...}

Thanks, this example is great! It sounds like the root issue here was my design not providing sufficient detail to get_bundle_all_angle rather than an actual bug. Assuming that's the case, my only remaining request on this issue is to include a note about this in the eventual docs for this feature.

sounds good,
we can track the improving the non-manhattan router docs in this issue
https://github.com/gdsfactory/gdsfactory/issues/1255


Java8 update

Updated the source to be compiled against Java 8
Added CompletableFuture support for server

This change is

Reviewed 33 of 33 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks broke.

Comments from Reviewable


feat: migrate nixos to 24.05

#77  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @zakuciael and the rest of your teammates on  Graphite


Fix #37: Add rapidjson-dev dependency and fix compilation issues

This pull request proposes a solution to address issue #37 and #34 by adding the missing rapidjson-dev package
and fixing related compilation issues.
Proposed changes:

Add instruction to install rapidjson-dev package using apt-get
Update references to library packages to ensure correct dependencies
Fix several compilation warnings
Resolve compilation errors related to the missing package

To test these changes:

Install the rapidjson-dev package: sudo apt-get install rapidjson-dev
Rebuild the project
Verify that all compilation warnings and errors are resolved

These changes aim to improve the build process and potentially resolve the issues reported in #37.
Disclaimer:
I am not the owner or maintainer of this project. This pull request is a suggested solution based on
the information available in issue #37. It is provided "as is", without warranty of any kind, express
or implied. The project maintainers should review and test these changes thoroughly before considering
implementation. I'm open to feedback and further modifications if needed.

I tested on /home/user/hailo-rpi5-examples folder need to be there.
After reinstalling
sudo apt-get install --reinstall hailo-tappas-core-3.28.2

After you can reboot run . setup_env.sh
$. setup_env.sh
Setting up the environment...
Setting up the environment for hailo-tappas-core...
TAPPAS_VERSION is 3.28.2. Proceeding...
You are not in the venv_hailo_rpi5_examples virtual environment.
Virtual environment exists. Activating...
TAPPAS_POST_PROC_DIR set to /usr/lib/aarch64-linux-gnu/hailo/tappas//post-process/
Device Architecture is set to: HAILO8L

You need to be same folder like  /home/user/hailo-rpi5-examples
$ python basic_pipelines/detection.py --help
usage: detection.py [-h] [--input INPUT] [--use-frame] [--show-fps] [--disable-sync] [--dump-dot] [--network {yolov6n,yolov8s,yolox_s_leaky}] [--hef-path HEF_PATH]
                    [--labels-json LABELS_JSON]

Hailo App Help

options:
  -h, --help            show this help message and exit
  --input INPUT, -i INPUT
                        Input source. Can be a file, USB or RPi camera (CSI camera module). For RPi camera use '-i rpi' (Still in Beta). Defaults to /dev/video0
  --use-frame, -u       Use frame from the callback function
  --show-fps, -f        Print FPS on sink
  --disable-sync        Disables display sink sync, will run as fast as possible. Relevant when using file source.
  --dump-dot            Dump the pipeline graph to a dot file pipeline.dot
  --network {yolov6n,yolov8s,yolox_s_leaky}
                        Which Network to use, default is yolov6n
  --hef-path HEF_PATH   Path to HEF file
  --labels-json LABELS_JSON
                        Path to costume labels JSON file

@chm10 Thanks alot for that PR (and others).
I would add rapidjson-dev as a dependency of our installer for future releases.
I don't get issues building this on the RPi did you installed hailo using the 'apt install hailo-all'?
All dependencies should be resolved from the TAPPAS core package using:
postprocess_dep = dependency('hailo-tappas-core', version : '>=3.28.2', required : false)
or:
postprocess_dep = dependency('hailo_tappas', version : '>=3.28.0')

@chm10 Thanks alot for that PR (and others). I would add rapidjson-dev as a dependency of our installer for future releases. I don't get issues building this on the RPi did you installed hailo using the 'apt install hailo-all'? All dependencies should be resolved from the TAPPAS core package using: postprocess_dep = dependency('hailo-tappas-core', version : '>=3.28.2', required : false) or: postprocess_dep = dependency('hailo_tappas', version : '>=3.28.0')

Yes, I followed the documentation process, and have issue to install. I runapt install hailo-all following the step-by-step tutorial.  The raspeberry 5 have compilation error to compile this project. As mentioned by anothers users.
Maybe the two files I modified need some review beucase have issue inside of them.


Protect against doing requests for snapshots that are over 400KB.

Sources:
https://zaccharles.medium.com/calculating-a-dynamodb-items-size-and-consumed-capacity-d1728942eb7c https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/CapacityUnitCalculations.html
Draft note
I'm well aware that the rename refactor and deployment processes are still ongoing. We'll adapt these commits to the new reality as it materializes but wanted to stage the contributions already.
Also FYI @coreyoconnor

Nice!
To clarify: This is to improve the error handling in the case a snapshot would be rejected due to exceeding DynamoDB's maximum item size?
I also like that this is part of the code that would be required to dispatch large snapshots to S3 :)

To clarify: This is to improve the error handling in the case a snapshot would be rejected due to exceeding DynamoDB's maximum item size?

It is, avoiding a sizeable round trip in doing so.

The headers should be fixed, but it looks like we're still doing something wrong with the formatting.

@spangaer SnapshotTooBigSpec has 2 formatting issues

incorrect indent on line 31
stray space at end of line 61

Should be fixed now.
Failure to use scalafmtAll instead of scalafmt.

Thanks, just found a couple of things.
Also it would be ideal if we could write a test for this.

@mdedetrich could you re-review? I've created a 1.0.x branch so it should now be safe to merge 1.1 stuff.

@mdedetrich @spangaer does this look ok to merge?

Sorry for the late answer, had lost track of this, but the PR was ready to merge back then, so that still holds afaik.

@mdedetrich do you think this is ok to merge now? You have a change request on this PR that blocks it from being merged.


suppress video player logging messages

I dont want to see those messages in my debug console:
W/VideoCapabilities(26566): Unrecognized profile 8192 for video/hevc
W/VideoCapabilities(26566): Unrecognized profile 4 for video/hevc
W/VideoCapabilities(26566): Unrecognized profile/level 0/3 for video/mpeg2
I/VideoCapabilities(26566): Unsupported profile 4 for video/mp4v-es
I/MediaCodec(26566): (0x700ae6ba00) init name(OMX.qcom.video.decoder.avc)
I/OMXClient(26566): IOmx service obtained
I/MediaCodec(26566): (0x700ae6ba00) Component Allocated (OMX.qcom.video.decoder.avc)
I/MediaCodec(26566): (0x700ae6ba00) configure surface(0x700afe2000) crypto(0x0) flags(0)
D/MediaCodec(26566): (0x700ae6ba00) configure format: AMessage(what = 0x00000000) = {
D/MediaCodec(26566):       Buffer csd-1 = {
D/MediaCodec(26566):         00000000:  00 00 00 01 68 e9 7b 2c  8b                       ....h.{,.
D/MediaCodec(26566):       }
D/MediaCodec(26566):       int32_t max-height = 1080
D/MediaCodec(26566):       int32_t max-width = 1920
D/MediaCodec(26566):       string mime = "video/avc"
D/MediaCodec(26566):       int32_t width = 1920
D/MediaCodec(26566):       int32_t priority = 0
D/MediaCodec(26566):       int32_t rotation-degrees = 0
D/MediaCodec(26566):       int32_t max-input-size = 496534
D/MediaCodec(26566):       int32_t height = 1080
D/MediaCodec(26566):       Buffer csd-0 = {
D/MediaCodec(26566):         00000000:  00 00 00 01 67 64 00 28  ac d9 80 78 02 27 e5 9a  ....gd.(...x.'..
D/MediaCodec(26566):         00000010:  80 80 80 a0 00 00 03 00  20 00 1d 4c 01 e3 06 33  ........ ..L...3
D/MediaCodec(26566):         00000020:  40                                                @
D/MediaCodec(26566):       }
D/MediaCodec(26566):     }

How do I suppress them?

flutter doctor -v
[✓] Flutter (Channel dev, 1.20.0-0.0.pre, on Mac OS X 10.15.5 19F101, locale
    en-GB)
    • Flutter version 1.20.0-0.0.pre at /Users/tahatesser/Code/flutter_dev
    • Framework revision d9653445f4 (7 days ago), 2020-06-09 18:43:03 -0400
    • Engine revision e8c13aa012
    • Dart version 2.9.0 (build 2.9.0-14.0.dev 5c1376615e)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/tahatesser/Code/sdk
    • Platform android-30, build-tools 30.0.0
    • ANDROID_HOME = /Users/tahatesser/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 46.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.46.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.11.0

[✓] Connected device (4 available)
    • SM M305F   • 32003c30dc19668f • android-arm64  • Android 10 (API 29)
    • macOS      • macOS            • darwin-x64     • Mac OS X 10.15.5 19F101
    • Web Server • web-server       • web-javascript • Flutter Tools
    • Chrome     • chrome           • web-javascript • Google Chrome
      83.0.4103.97

• No issues found!

@TahaTesser Hi:)
video_player: ^0.10.10
Do you mean to use that specific version for disabling video player logs?
I want to reactively enable/disable the vieo player logs too.
Can you please tell us how?

This can be useful:
https://stackoverflow.com/a/62152411/3332634

I'm having this issue right now, its super hard to see my log messages.
Would be cool if there was a global library variable that can be set to turn off logs.

It's so difficult to debug the app due to these logs. If anyone knows please share, how to disable logs

It's so difficult to debug the app due to these logs. If anyone knows please share, how to disable logs

+!

+!

If you are trying to turnoff logs in vscode you can filter out the logs as a temporary solution.

press cmd/ctrl +f
enter the filter I/flutter
Note that this works only for that session and you have to do it each time you add a new terminal

heres my debug console while the video is playing the code has only one print statement

Reproducible with video_player: ^2.1.6

flutter doctor -v
[✓] Flutter (Channel stable, 2.2.2, on macOS 11.4 20F71 darwin-arm, locale en-IN)
    • Flutter version 2.2.2 at /Users/mahesh/Documents/flutter
    • Framework revision d79295af24 (3 weeks ago), 2021-06-11 08:56:01 -0700
    • Engine revision 91c9fc8fe0
    • Dart version 2.13.3

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] IntelliJ IDEA Community Edition (version 2021.1.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 57.0.5
    • Dart plugin version 211.7233

[✓] VS Code (version 1.57.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.23.0

[✓] Connected device (3 available)
    • sdk gphone arm64 (mobile) • emulator-5554 • android-arm64  • Android 11 (API 30) (emulator)
    • macOS (desktop)           • macos         • darwin-arm64   • macOS 11.4 20F71 darwin-arm
    • Chrome (web)              • chrome        • web-javascript • Google Chrome 91.0.4472.114

• No issues found!

Hi, this is still happening with 2.2.7 version. Would be great to have all these logs removed. It makes debugging really complicated indeed. Thank you

Issue still exists with 2.2.10 version. Please fix soon

For now, these following tricks might be of help in getting rid of the logs
# ripgrep
$ flutter run --hot --track-widget-creation | rg -v "Codec|Audio|Video|Buffer|Exo"

# awk
flutter run --hot --track-widget-creation | awk  '!/Codec|Audio|Video|Buffer|Exo/ {print}'

any updates on this issue? thank you

@ingmferrer Why was this issue closed? as per my understanding, this is not fixed yet.

i have the same issue

Same issue with 3.0.3

same issue


Add nginx authentication support

Add nginx authentication support to the tool.

@1569099266 the auth will be handled through this issue.

This one is already implemented and tested. I'm working on a few more stuff to push everything together.


[RFC] drivers: can: Extend the isr callback with a void* arg

This PR extends the isr callback and the attach_isr function with an argument.
With this argument it's possible to map different filters to the same isr but having the possibility to distinguish them by the argument. This makes the implementation if higher level protocols easier but breaks the current API.
The sram overhead is sizeof(void*) * CAN_MAX_FILTER
Only "drivers: can: Extend attach_isr with void *arg and pass to the isr cb" commit is relevant for this PR

@lowlander what do you think?

@karstenkoenig ping

My old driver that I have almost cleaned up enough to create a PR for, has a bit of another approach. I give my driver a (const) array of filters, that are directly used by the driver, so I do not copy them to not need writable RAM (or a fixed CONFIG_FILTER_COUNT option). Also I made it possible to set a filter-array per FIFO (there are two RX fifos on the F4) Also I have no "detach" system-call because just registering a new array (which can be 0) releases the previous one.  Those array entries, have not just the filter and callback, but also a user-pointer, that will be passed to the callback.
Currently I am implementing a E70 CAN-FD driver, to make sure the API's work on more than just a STM32 controller.
I am a bit afraid things are done in parallel at the moment, but last time I early asked for comments I was pretty much shot down due to code quality, so now I just finish my driver and create a PR when I am done.

Regarding the API break that this PR is introducing, should we just keep the old API and create a new function that introduces the extra arg to the callback. The old API could be deprecated if needed and eventually removed at some later time.

@jukkar I'm not sure if the attach isr is used by users anyway. From userspace it's better to use the queue. The attach_isr is more useful for highlevel stuff. But making a wrapper will not produce any overhead. I'll do that.

I give my driver a (const) array of filters, that are directly used by the driver, so I do not copy them to not need writable RAM (or a fixed CONFIG_FILTER_COUNT option)
I don't copy the filters neither. I just set the registers.  CONFIG_FILTER_COUNT is for the amount of different callbacks/message queues and they can't be constant because socket can relies on appending filter at run-time.
Also my ISO-TP stack I'm working on relies in attach/detach at run-time. Additionally an other project (the project I implement all the CAN stuff here) relies on attach and detach at run-time.

Added an argument to the send callback too.

Codecov Report

Merging #13262 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #13262   +/-   ##
=======================================
  Coverage   48.64%   48.64%
=======================================
  Files         319      319
  Lines       46537    46537
  Branches    10756    10756
=======================================
  Hits        22638    22638
  Misses      19313    19313
  Partials     4586     4586

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b81cfdf...30e5e77. Read the comment docs.

Rebased.

can_attach_workq is implemented as a replacement for can_attach_isr when userspace is on.
attaching an ISR from userspace is not allowed.(See #14204)

@karstenkoenig can you check the changes for mcp2515?


sysbench: add simple sysbench scripts

PTAL @tshqin

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Include types from node_modules in TypeScript input tree

This is a short-term compromise for fixing the current spew of output. We include only .d.ts files and package.json files from node_modules in the input tree to the TypeScript compiler, which reduces the set of files enough to make rebuilds plausibly faster.

Shipped in @glimmer/application-pipeline 0.4.2


Improve /errors over time

(future issue) https://ngrok.com/docs2/errors/ feels like it needs some thought. The side panel is just “all errors” and its a huge list. We could try to create a TOC based on the error code. But using ctrl + f on the page is probably good for now.

closing as stale for now


Add syntax highlighting for Zig

Description
Currently, when trying to add syntax highlighting for Zig it doesn't work. I can try adding it myself and send a pull request.
Use Case
Zig users.

Where should I look to implement this? :smile:

Have you checked that it doesn't already work on main? A lot of new syntax highlighting was added recently, but it won't hit until 0.5

Zig is already supported on main.


Clear all in Drawing App

Clear all in Drawing App .
Goal is to create a button, which when clicked will clear everything previously drawn.
Event
Participating as a part of GSSOC

Assign this to me & I will add the feature!

Sure !!


update table of existing and planned vignettes

@mckinsel and @jnkrupp do you have any updates to the table of existing and planned vignettes? i'll update the table, just want to make sure i have the most up to date notes from y'all as well. thanks!

We have established a CI/CD system for the vignettes. It sounds like vignettes are going to come from many different repos so we are thinking that the TOC for vignettes should be located in teh Portal here https://software.broadinstitute.org/wdl/documentation/topic?name=wdl-tutorials
We think that we should have a TOC of examples in the Portal, and that the user should be able to drill into the code from there.
We have created a number of other issues to track this approach.

The basic table in the consumer-vignettes repo is up to date.


SincNet on Tensorflow?

@mravanelli
Wanted to know if there is a port of the net on TF?
Regards,
Sivam

Hi mravanelli:
      I am having some problems now, sincNet is very poorly tested on the voice of the same person but through different channels (for example, the same person's voice through pc and iphone), I don't know if you have tested this situation. How should this situation be solved? Another problem is that in the case of sound reverberation (same voice speaked by two colleagues) and large signal-to-noise ratio, the model performance is also very poor. I wonder if you have a good way to remove sound reverberation and reduce noise? I look forward to your answer and thank you very much!

Dear Wenkai,
are you able to replicate my results on the standard TIMIT dataset? This is
to exclude first any kind of implementation bug.
Mirco
On Wed, Oct 31, 2018 at 5:40 AM Wenkai.Zhang<EMAIL_ADDRESS>wrote:

Hi mravanelli:
I am having some problems now, sincNet is very poorly tested on the
voice of the same person but through different channels (for example, the
same person's voice through pc and iphone), I don't know if you have tested
this situation. How should this situation be solved? Another problem is
that in the case of sound reverberation (same voice speaked by two
colleagues) and large signal-to-noise ratio, the model performance is also
very poor. I wonder if you have a good way to remove sound reverberation
and reduce noise? I look forward to your answer and thank you very much!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mravanelli/SincNet/issues/9#issuecomment-434621715,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQGs1mZTGmyIGxA7iZehUTBpwLguW0Vbks5uqW_1gaJpZM4XskDU
.

I created this version of SincNet for keras (tensorflow) and I managed to reproduce the same results on TIMIT. I hope it goes well.
https://github.com/grausof/keras-sincnet

Great job Francesco!
Mirco
https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
Virus-free.
www.avast.com
https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
On Thu, Nov 29, 2018 at 3:48 AM Francesco Grauso<EMAIL_ADDRESS>wrote:

I created this version of SincNet for keras (tensorflow) and I managed to
reproduce the same results on TIMIT. I hope it goes well.
https://github.com/grausof/keras-sincnet
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/mravanelli/SincNet/issues/9#issuecomment-442753035,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQGs1sge-9s62esuI60APGaucQ-VELz2ks5uz59kgaJpZM4XskDU
.

I created this version of SincNet for keras (tensorflow) and I managed to reproduce the same results on TIMIT. I hope it goes well.
https://github.com/grausof/keras-sincnet

@grausof where did this go?

I created this version of SincNet for keras (tensorflow) and I managed to reproduce the same results on TIMIT. I hope it goes well.
https://github.com/grausof/keras-sincnet

@grausof where did this go?

Try non!

@grausof
I tried to run your code with the same tensorflow and keras version.
But I got the following error.
It should be noted that I changed the keras to tensorflow.keras in importing.
I tried different ways to solve it. Do you have any idea how can I fix it?
I really apprecaite that if you can help.
FailedPreconditionError (see above for traceback): Error while reading resource variable sinc_conv1d/Variable_102 from Container:
localhost. This could mean that the variable was uninitialized. Not found: Resource localhost/sinc_conv1d/Variable_102/N10tensorflow3VarE does not exist.
[[Node: sinc_conv1d/Variable_103/Initializer/ReadVariableOp = ReadVariableOpdtype=DT_FLOAT, _device="/job:localhost/replica:0/task:0/device:CPU:0"]]

Hello everyone,
Has anyone implemented the code yet in tensorflow 2.0?
The above error I believe I also ran into. I believe it was a version problem. Downgrade to keras =2.1.6 should solve.
regards,

Hi @Ciel24,
Have you solved this problem?
I got the same error after I changed the keras to tensorflow.keras.
thanks,


Test of https://github.com/IntersectMBO/cardano-cli/pull/638, DO NOT MERGE

Test of https://github.com/IntersectMBO/cardano-cli/pull/638

Closing, as https://github.com/IntersectMBO/cardano-cli/pull/638 was merged


Add extraInitContainer for state initialization, etc.

As per title this will allow importing state manually without much fuss.

I guessed the init container feature had been implemented recently by @Nalum
Luke, could you please confirm that we already have this capability please?

Yep, this was part of the v0.13.0 release :+1+

You can see an example in this test https://github.com/weaveworks/tf-controller/blob/main/controllers/tc000311_init_container_test.go#L102-L107