Default RichText color on Card is white as the background when in light mode

Steps to Reproduce

Switch Flutter framework to master channel (3.1.0-0.0.pre.1112, at the moment)
Set your device brightness mode to dark
Create a Card containing a Text widget with a placeholder text
Create a Card containing a RichText widget with a placeholder text
Switch the device brightness mode to light

Expected results for the RichText widget

In DARK mode we should have light text on a dark background
In LIGHT mode we should have dark text on a light background

Actual results for the RichText widget:

In DARK mode the result is OK (screenshot on the left)
In LIGHT mode we have light text on a light background —white on white— (screenshot on the right)

Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData.light(),
      darkTheme: ThemeData.dark(),
      themeMode: ThemeMode.system,
      home: const MyHomePage(title: 'RichText Color on Card'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({Key? key, required this.title}) : super(key: key);
  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: SafeArea(
        child: Padding(
          padding: const EdgeInsets.all(16.0),
          child: Column(
            mainAxisAlignment: MainAxisAlignment.center,
            crossAxisAlignment: CrossAxisAlignment.stretch,
            children: <Widget>[
              const Card(
                elevation: 10.0,
                child: Padding(
                  padding: EdgeInsets.all(16.0),
                  child: Text('This is a Card widget with a Text widget'),
                ),
              ),
              const SizedBox(
                height: 64.0,
              ),
              Card(
                elevation: 10.0,
                child: Padding(
                  padding: const EdgeInsets.all(16.0),
                  child: RichText(
                    text: const TextSpan(
                      text: 'This is a Card widget with a ',
                      children: <TextSpan>[
                        TextSpan(
                          text: 'RichText',
                          style: TextStyle(
                            fontWeight: FontWeight.bold,
                            fontFamily: 'Menlo',
                            fontFamilyFallback: ['monospace'],
                          ),
                        ),
                        TextSpan(text: ' widget in '),
                        TextSpan(
                          text: 'bold',
                          style: TextStyle(
                            fontWeight: FontWeight.bold,
                          ),
                        ),
                        TextSpan(text: ' and '),
                        TextSpan(
                          text: 'italic',
                          style: TextStyle(
                            fontStyle: FontStyle.italic,
                          ),
                        ),
                      ],
                    ),
                  ),
                ),
              ),
            ],
          ),
        ),
      ),
    );
  }
}

Hi @epentesi, can you upgrade to master 3.1.0-0.0.pre.1114 or whatever the latest version is to see if you still experience this issue? Below is what I see when I run your code sample.

flutter doctor -v master
[✓] Flutter (Channel master, 3.1.0-0.0.pre.1114, on macOS 12.3.1 21E258 darwin-arm, locale en-GB)
    • Flutter version 3.1.0-0.0.pre.1114 at /Users/nexus/dev/sdks/flutters
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 82ae61214a (6 hours ago), 2022-06-05 21:23:05 -0400
    • Engine revision 73c59433b5
    • Dart version 2.18.0 (build 2.18.0-170.0.dev)
    • DevTools version 2.14.0

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-32, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] VS Code (version 1.67.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.42.0

[✓] Connected device (4 available)
    • M2007J20CG (mobile) • 5dd3be00                  • android-arm64  • Android 11 (API 30)
    • Nexus (mobile)      • 00008020-001875E83A38002E • ios            • iOS 15.5 19F77
    • macOS (desktop)     • macos                     • darwin-arm64   • macOS 12.3.1 21E258 darwin-arm
    • Chrome (web)        • chrome                    • web-javascript • Google Chrome 102.0.5005.61

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Hi @danagbemava-nc,
To experience the issue you have to switch your device brightness to LIGHT MODE.

Hi @epentesi, that was my bad. I misread the issue.
Reproducible using code sample provided above.

screenshots

dark theme
light theme

flutter doctor -v
[✓] Flutter (Channel stable, 3.0.1, on macOS 12.3.1 21E258 darwin-arm, locale en-GB)
    • Flutter version 3.0.1 at /Users/nexus/dev/sdks/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision fb57da5f94 (2 weeks ago), 2022-05-19 15:50:29 -0700
    • Engine revision caaafc5604
    • Dart version 2.17.1
    • DevTools version 2.12.2

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-32, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] VS Code (version 1.67.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.42.0

[✓] Connected device (4 available)
    • M2007J20CG (mobile) • 5dd3be00                  • android-arm64  • Android 11 (API 30)
    • Nexus (mobile)      • 00008020-001875E83A38002E • ios            • iOS 15.5 19F77
    • macOS (desktop)     • macos                     • darwin-arm64   • macOS 12.3.1 21E258 darwin-arm
    • Chrome (web)        • chrome                    • web-javascript • Google Chrome 102.0.5005.61

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

[✓] Flutter (Channel master, 3.1.0-0.0.pre.1114, on macOS 12.3.1 21E258 darwin-arm, locale en-GB)
    • Flutter version 3.1.0-0.0.pre.1114 at /Users/nexus/dev/sdks/flutters
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 82ae61214a (6 hours ago), 2022-06-05 21:23:05 -0400
    • Engine revision 73c59433b5
    • Dart version 2.18.0 (build 2.18.0-170.0.dev)
    • DevTools version 2.14.0

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-32, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] VS Code (version 1.67.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.42.0

[✓] Connected device (4 available)
    • M2007J20CG (mobile) • 5dd3be00                  • android-arm64  • Android 11 (API 30)
    • Nexus (mobile)      • 00008020-001875E83A38002E • ios            • iOS 15.5 19F77
    • macOS (desktop)     • macos                     • darwin-arm64   • macOS 12.3.1 21E258 darwin-arm
    • Chrome (web)        • chrome                    • web-javascript • Google Chrome 102.0.5005.61

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Hi everyone.
This is intended, RichText is raw and un-affected by theme system, please read https://github.com/flutter/flutter/issues/61452#issuecomment-658219360
Closing as it is working as intended.


Check for rc / beta / alpha

This wouldn't be a good default, of course, but would be nice to be able to check for new[-er] rc / beta / alpha releases. Webpack 2, for example, has been in beta for 9 months now, with a fresh release every week or so, and I'd like to keep up with the same ease as I'm able to with regular releases.

I agree, nice feature to have. Pull requests welcome 👍

This wouldn't be a good default

I disagree, I think this absolutely should be default for dependencies whose installed versions are beta/etc.
At present, npm-check is silent about my babel deps. npm outdated shows them:
❯ npm outdated
Package                                           Current          Wanted         Latest
@babel/cli                                  7.0.0-beta.46   7.0.0-beta.49  7.0.0-beta.49
@babel/core                                 7.0.0-beta.46   7.0.0-beta.49  7.0.0-beta.49
@babel/plugin-proposal-object-rest-spread   7.0.0-beta.46   7.0.0-beta.49  7.0.0-beta.49
@babel/preset-env                           7.0.0-beta.46   7.0.0-beta.49  7.0.0-beta.49

and a yarn upgrade upgraded them.
But I was in the habit of only checking with npm-check so I overlooked these upgrades for a long time.

I'm fully satisfied with yarn upgrade-interactive --latest these days.


Sned File Feature

Is your feature request related to a problem? Please describe.
Tailscale allows sending files directly to other clients. This is a BIG time saver.
Describe the solution you'd like
A command line option as well as a windows context menu that allows sending files to other clients, like Tailscale supports

This would be a nice feature. Please add in the future.


ts-definitions: make prop.create result config optional

when user creates custom props parser via prop.create, config is optional during usage. TS has this config as mandatory.
now:
const myProp = prop.create({/*...*/})

class Foo extends Component<{foo:any}>{
  static get props(){
    return {
      foo: myProp({})
     // foo: myProp()  -> this is valid although TS compiler will error
    }
  }
}

change needed in api.d.ts
from
create<T>(attr: PropOptions<any, T>): PropOptions<any, T> & ((attr: PropOptions<any, T>) => PropOptions<any, T>);
to
create<T>(attr: PropOptions<any, T>): PropOptions<any, T> & ((attr?: PropOptions<any, T>) => PropOptions<any, T>);

can close this when 5.x, cause it doesn't have this api

Closing as this API will no longer be in 5.x


Use raw git hook name for script name

Newer versions of husky (>0.14) suggest doing it.

sorry, other way around, my bad!


Load all static assets over https

When visiting the documentation over https Chrome displays a warning that some assets on the page were loaded over http.
This PR attempts to fix this.

Thanks for your pull request!
Regarding the Google fonts URL, I rely on the Github page generator for that, I can't fix it without stopping using the generator.
Regarding the URLs of the badges, I can fix them, but it seems that some certificate also triggers warnings in Chrome. For instance: https://img.shields.io/badge/godoc-reference-blue.svg?style=flat "This site uses a weak security configuration (SHA-1 signatures), so your connection may not be private."
Antoine

I fixed as much as I could, favoring https where possible.
The Chrome warning will go away when Github will improve its page templates, and when cert update their hash settings.
Closing.

Awesome. Thanks!


KeyError: Timestamp

Traceback (most recent call last):
File "pandas_libs\index.pyx", line 545, in pandas._libs.index.DatetimeEngine.get_loc
File "pandas_libs\hashtable_class_helper.pxi", line 2131, in pandas._libs.hashtable.Int64HashTable.get_item
File "pandas_libs\hashtable_class_helper.pxi", line 2140, in pandas._libs.hashtable.Int64HashTable.get_item
KeyError:<PHONE_NUMBER>000000000
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "D:\anaconda3\envs\trading_bot\lib\site-packages\pandas\core\indexes\base.py", line 3621, in get_loc
return self._engine.get_loc(casted_key)
File "pandas_libs\index.pyx", line 513, in pandas._libs.index.DatetimeEngine.get_loc
File "pandas_libs\index.pyx", line 547, in pandas._libs.index.DatetimeEngine.get_loc
KeyError: Timestamp('2022-07-05 09:40:00+0200', tz='Europe/Berlin')
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "D:\anaconda3\envs\trading_bot\lib\site-packages\pandas\core\indexes\datetimes.py", line 679, in get_loc
return Index.get_loc(self, key, method, tolerance)
File "D:\anaconda3\envs\trading_bot\lib\site-packages\pandas\core\indexes\base.py", line 3623, in get_loc
raise KeyError(key) from err
KeyError: Timestamp('2022-07-05 09:40:00+0200', tz='Europe/Berlin')
The above exception was the direct cause of the following exception:
KeyError: Timestamp('2022-07-05 09:40:00+0200', tz='Europe/Berlin')
i Got this error message by some German stock with an interval of 1 minute.
Are there any possibilities to avoid this and get the correct data ?
best regards

Post code that reproduces error.

this is a short excerpt of the code. the first passes of the loop work, then suddenly this error message appears.
`import yfinance as yf
import pandas as pd
from datetime import date
import datetime
ticker = yf.Ticker('LHA.DE')
start = date.today() - pd.Timedelta(days=7)
end = date.today()
df = ticker.history(interval='1m', start=start, end=end)
start_time = datetime.time(9,00,00)
for i in range(len(df)):
n = df.index[i] + pd.Timedelta(minutes=1)
a = df.index.get_loc(n)
print(df.iloc[a])`

Hi, I have rerun your code locally and it seems that the issue comes from yahoo finance directly where there is missing data for some minutes. You can check he following link to confirm: https://query2.finance.yahoo.com/v8/finance/chart/LHA.DE?period1=1657058400&period2=1657663200&interval=1m&includePrePost=False&events=div%2Csplits

Your code is bad. You don't need to be incrementing times because they're in the index:
for n in df.index:

So you don't need to fill in missing.

I think that the issue comes from https://github.com/ranaroussi/yfinance/blob/ec6279736b570815ec017691b428c90d910b1739/yfinance/base.py#L320
which removes the times where the values are equals to null instead of keeping them.

@ranaroussi , do you have any memory of Yahoo returning NaNs by mistake, where a later request returned data for same timepoints? Assuming that timepoint is historic so Yahoo didn't receive new data from exchange.

Maybe add an argument to keep NaNs? E.g. 'history(keepna=False'


Not consistent rest api when returning annotations

Actions before raising this issue

[X] I searched the existing issues and did not find anything similar.
[X] I read/searched the docs

Steps to Reproduce
It returns elements: [] for any shapes (not only skeletons), but in case with tracks it returns elemens: [...] only for skeletons:

For tags it does not return elements: [].
Expected Behavior
We should decide on unified behaviour
Possible Solution
No response
Context
No response
Environment
No response

At the same time, when PATCH http://localhost:8080/api/jobs/id/annotations?org=&action=update
It returns elements: [] for tracks:


Make Login() take username and password arguments

This is instead of requiring that the user set them in the struct before
calling Login().
I also made the username and password struct fields private. Let me know
if you think the username field should remain public. It may be useful
for UIs. That can always change when needed, though. Until then, it's
probably best to keep the API as simple as possible. I can't think of a
good reason for the password to be accessed in a context other than
Login(), so I'm confident that field can remain private.

That was my first thought, but there are two complications.
The first is that, although the login attempt will fail with an empty username or password, it will happen in a less immediately-apparent way. The reason for the failure will be much less clear - I know many services return "invalid username or password" no matter what the issue is to prevent information leaks.
The second is that most actual wiki bots will read usernames and passwords from CLI arguments or a config file rather than directly from the source. These are both situations in which "" can reasonably be passed.

Thoughts?


Emit event?

Is there a way to emit back to the parent component from within a component passed to the datatable?   I don't see a way to attach a  "v-on" binding.  As an example, clicking on an edit button component to the table triggers a modal open event within the parent component?

I believe you would need to use an "event bus". There is an example here: https://vuejs.org/v2/guide/components.html#Non-Parent-Child-Communication
Is that what you are looking for?


Embed block: fix embedding stories with plain permalinks

Summary
Fixes embedding local stories with plain permalinks.
Relevant Technical Choices

Encodes URLs for transimission
Adds some custom logic to parse URLs because url_to_postid() does not recognize plain permalinks like https://example.com/?web-story=my-story.

To-do

User-facing changes
N/A
Testing Instructions

Disable pretty permalinks in the WordPress settings
Create a new blog post and insert a Web Stories embed block
Paste the URL of a web story on the same site
Verify that the embed is working

Fixes #5560

@spacedmonkey I know, on it already


Incorrect null check in pytree_checkpoint_handler.py

orbax/checkpoint/pytree_checkpoint_handler.py:661 has the following check: if not item
It most likely should be if item is None, as otherwise this check will raise an error when item is an array (which is a valid pytree according to pytree definition).

I think the distinction being made is between PyTree containers and leaves. From the JAX docs: "By default, pytree containers can be lists, tuples, dicts, namedtuple, None, OrderedDict. Other types of values, including numeric and ndarray values, are treated as leaves". To save singular jax.Array or np.ndarray, ArrayCheckpointHandler is provided instead. Obviously there is some grey area, but I'm hesitant to cram yet more functionality into PyTreeCheckpointHandler - it has become bloated enough as it is, and we're pushing for simplification in a few key aspects.

Fair enough. In any case, the error was really obscure and the error message in this case can be improved.

Sure that's also fair, I'll make a TODO.


If I import a flow (for example backup) Alexa will not control more devices

Hi, for the first time on my NR I had to clear all flows and restore the latest backup (export- clipboard - all flows), all was working exept this modules and the reason I believe is because during the Alexa searching the module send to it the node number that NR create for every device, and when I create a new flow NR will assign new numbers to nodes, different ones. I checked that Alexa sent to HUB the proper message (I've logged it) but the HUB can't more redirect it to the proper device, message is lost. I should remove all Alexa devices (better to reset Alexa completely) and search again for all devices.
Of course with this method we can't export the flow and restore it easy as we should suppose to do, so I would suggest to add on devices proprieties a manual ID field, which can be precompiled with the ID that NR created for that node, so the user don't have to define it. In this way these infos can be exported on the clipboard and restored automatically on the backup.
At this moment the only solution to restore flows 100% seems to backup the flows_raspberrypi.json file and restore it

It is because node UUIDs are used to identify the devices that will be controlled by Amazon Echo Hub

There is a way to solve this? As Vernus introduced names, and if I remember right I read somewhere you too, there are chances to give a device an unique node, that can be sent to Echo as device ID, and can be restored with import? (And Echo that remembers that will keep working with same device)
Thank you!

#115 is suggesting how to implement it.


Occurence data file contains NaN fields

When attempting to ingest data via the API (../vector-api/ingest/uploadOccurrence) an error is generated due to some of the data being detected as NaN. This is happening when trying to ingest using the file: src\Database\test_data\occurrence.csv

Check with Marianne if this is even possible with real data - can the Month/Year for a row be nullable?


WIP: Debug PR

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/test metal3-ubuntu-e2e-feature-test-main-pivoting

/test metal3-ubuntu-e2e-feature-test-main-pivoting

/test metal3-ubuntu-e2e-feature-test-main-pivoting

/close


Add tests for API routes

Use mocha and the current test infrastructure to add tests to the API.

I'll take care of this, I've wanted to get into API testing for a long time

Go for it @MeLlamoPablo
I like to use this library for HTTP tests, but feel free to use whatever you want :)


Feature/constants switching 2

replaces  #130
this implementation is neater. Only values that are dependent on ros need to be initialzed after ros::init(), not all.

thanks, you too!


Attempt to fix logging race

I'm trying to fix the logging race occurred when integrating raftify with Backend.AI, but it is still incomplete method currently.

I think the best solution at this point is to write the slog log to a file instead of standard output, so that it doesn't compete with the Python logger at all.
Writing a PyMutex binding to check if slog's standard output is locked every time in Python is too overheady, requires fixing every Python log call to an asynchronous function, and is unnecessary, in my opinion.


Add inspection modes to Python client library

Closes #1321.
Summary:
Adds two debug modes to the Python client library (JS and R clients TBD):

debug logs info about HTTP requests and responses.
sandbox prevents any HTTP requests from actually executing, allowing users to test a long-running or expensive script without any actual server load.

Prerequisites:

[X] Unless it is a documentation hotfix it should be merged against the dev branch
[X] Branch is up-to-date with the branch to be merged with, i.e. dev
[X] Build is successful
[X] Code is cleaned up and formatted

@melange396 @dshemetov re-requesting review as the latest commit invalidated the "approved" checkmarks :)


HBASE-24151 The master server aborted for IllegalThreadStateException

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
5m 44s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-2.2 Compile Tests _

+1 :green_heart:
mvninstall
6m 45s
branch-2.2 passed

+1 :green_heart:
compile
0m 33s
branch-2.2 passed

+1 :green_heart:
checkstyle
0m 20s
branch-2.2 passed

+1 :green_heart:
shadedjars
5m 20s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 25s
branch-2.2 passed

+0 :ok:
spotbugs
0m 56s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 53s
branch-2.2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m 22s
the patch passed

+1 :green_heart:
compile
0m 36s
the patch passed

+1 :green_heart:
javac
0m 36s
the patch passed

+1 :green_heart:
checkstyle
0m 17s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
5m 25s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
27m 53s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2.

+1 :green_heart:
javadoc
0m 19s
the patch passed

+1 :green_heart:
findbugs
0m 52s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
6m 35s
hbase-rsgroup in the patch passed.

+1 :green_heart:
asflicense
0m 13s
The patch does not generate ASF License warnings.

75m 50s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1508/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1508

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux b9b1b99bab4f 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1508/out/precommit/personality/provided.sh

git revision
branch-2.2 / 653fb90270

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1508/1/testReport/

Max. process+thread count
4111 (vs. ulimit of 10000)

modules
C: hbase-rsgroup U: hbase-rsgroup

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1508/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


GPIO Time based Camera Trigger not working in QGC mission

Hi folks, I can not get the GPIO camera trigger to operate in the time based mode when running a mission in QGC. I checked previous trigger issues listed here, most seem to be from 2017,18 but could not find any related. Anybody else having this problem?
Very simple to setup/reproduce. Setup Camera for time based, on command and GPIO output. Set up the trig_ parameters for time, interval, active high, etc. Leave TRIG_PINS at default 56.
Running PX4 on Pixracer
Aux1-4 motors
Aux 5,6 camera trigger
Planned a short mission with Camera trigger in Mission Start, also tried a Start image capture command, put the camera trigger command in a waypoint and tried every other combination of commands and settings, but can't get a trigger. Camera trigger test works, but after running a mission it sometimes gets locked out and we need to reboot. Time based, always on, works, but we can't have the camera continuously shooting pictures. Also, when we change mode to distance based, along with associated parameters, it works flawlessly.
It's only time time based, on command that will NOT work.
Any help would be appreciated,
Thanks,
MM

I think I looked at every camera trigger issue in GitHub, PX4 and slack forums with no solution. If the camera can't be triggered with a GPIO output, it might just be good and come out and say that. The user guide is completely contradicting to other info on the sites. As an example I found this from a year ago, which makes NO sense at all.
https://px4.slack.com/archives/C629RE9H7/p1562611063123900
If the camera is 0:Disable(ed), the user has no control and can't trigger the camera in a planned mission because the camera is DISABLED! So this is completely wrong. Am I the only one trying to trigger a camera in a mission on a periodic basis with the GPIO  #output?
'''
Don Gagne  12 months ago
If you are flying a camera mission should not be setting TRIG_MODE to anything other than 0:Disable. The mission commands should control everything. If you are flying a mission with camera commands and have TRIG_MODE also set to something else I have no idea what the interactions would be.
Don Gagne  12 months ago
If you are planning a Survey in QGC the camera trigger set is specified in the survey item itself. You are setting up camera triggering in Mission Start and then again in the Survey item. The 23.2... trigger distance is what is specified in the Survey item.
Don Gagne  12 months ago
The Survey item will also add a stop triggering command at the end of the Survey which is what you are seeing.
'''

Yes, the camera docs are clearly not correct - the QGC screen is different than current version and the http://docs.px4.io/master/en/peripherals/camera.html#trigger_mode isn't qutie the same as http://docs.px4.io/master/en/advanced_config/parameter_reference.html#TRIG_MODE
@moonmotor There are quite a lot of conditions you have mentioned. Let's just start with what you want to do. I THINK this is time based commands triggered by a mission command (MAV_CMD_DO_SET_CAM_TRIGG_DIST) and stopped by that same command at the end. Is that correct.
@bkueng According to the docs this should work with TRIG_MODE = 4. Is that right? I'm not sure what Don was referring to above by saying the mode should be zero. I think that means "off" too.

Yes I would expect so. TRIG_MODE=1 Time based, on command should start/stop triggering on VEHICLE_CMD_DO_TRIGGER_CONTROL. Is that command sent?

Thanks for the quick replies guys! I'm trying to trigger the camera on a time basis. We could write code to turn it on before a mission and then off after the mission, but that's cumbersome. We'd like to use the mission commands to turn the camera on/of during our missions. The most obvious setting is TRIG_MODE=1 (time based, on command), which doesn't work. I did see in the documentation somewhere that said use TRIG_MODE=4 and we tried that with no luck.
@bkuend, we are setting camera to start in the Mission Start tab, so it doesn't say what command is being sent. If we send a command explicitly it sends the MAV_CMD_IMAGE_START_CAPTURE. But we have also included the Trigger Control command MAV_CMD_DO_TRIGGER_CONTROL and didn't have and luck with that either. It seems like such a basic function, but we have been working on it for days. Your help is very much appreciated!

Another bit of information: It did randomly work twice over the past three days, but was unrepeatable - so that gave us hope we were doing something wrong. Second thing is that in many cases, after running a mission the camera will no longer trigger in the Camera Test screen above. That's why we put in the MAV_CMD_DO_TRIGGER_CONTROL command thinking the camera might need to be (re)enabled first? And again we're trying to use the GPIO output to close a relaying to trigger a "dumb" camera - no PWM communications.
Thanks again!

Sorry to bombard with messages, but we need to solve (what should be) a trivial problem and get out imaging crops. Your help continues to be greatly appreciated. Here's a screen capture from QGC - since we're working within the confines of QGC  - that's where we need to solve the problem.

This happens to be mode 4, but we also tried mode 1 (0,2,&3).
We can trigger from the Mavlink console, start the trigger (which snaps a photo), stop the trigger, but not able to get it running on the time-based mode.
Losing hair, sleep and customers!

@moonmotor I heartily agree this should be a trivial problem and fix. But this is an open source project, so while we will try help, unless a problem affects vehicle safety it is no one's urgent responsibility. You may need to dig into the code yourself or invest in consultancy if we can't help. I have never tried this because I don't have the hardware.
The code is here.
Some observations.

MAV_CMD_IMAGE_START_CAPTURE and friends are a newer mavlink interface than the other message. These are generally supported by MAVLink cameras but do not appear to be supported by this driver (and should be).
The driver also supports MAV_CMD_DO_SET_CAM_TRIGG_INTERVAL (not documented in camera trigger docs)  - @bkueng correct?

My interpretation of the docs is that time triggering in survey missions is not supported - only distance triggering is supported. So what "should work" is that you set TRIG_MODE=4 and the correct pins etc. Then QGC should automatically set MAV_CMD_DO_SET_CAM_TRIGG_DIST in the survey mission. If it does not do that then that's possibly a bug in QGC.
So question, are you doing a survey mission, or some other mission? If it is a survey mission, are those triggers being set - if not, what is being set instead?
It might be that MAV_CMD_IMAGE_START_CAPTURE is being set, in which case perhaps the easiest fix would be to PR in support for that message.
@bkueng Anything else you can infer from this/corrections to my comment?

@moonmotor your screenshot suggests camera_trigger was not running and you had to start it, is that correct? Which firmware version is that?

The driver also supports MAV_CMD_DO_SET_CAM_TRIGG_INTERVAL (not documented in camera trigger docs) - @bkueng correct?

Correct.
To further debug, I suggest setting TRIG_MODE=1, then sending VEHICLE_CMD_DO_TRIGGER_CONTROL with param1=1 and param3=0, and then look at camera_trigger status.

@bkueng that's the secret code!
MAV_CMD_DO_TRIGGER_CONTROL 1,0,0 starts the camera triggering based on the parameters setup in Camera Trigger with TRIG_MODE=1 . None of the other camera commands in QGC Mission Plan seem to have any effect.
MAV_CMD_DO_TRIGGER_CONTROL 0,0,0 stops the triggering.
It's not quite reliable - sometimes the camera will start triggering as soon as the mission is uploaded, and often times the camera will start triggering again after the aircraft has landed.
Before, we couldn't get the camera to start triggering, now we can't get it to stop. hahaha but we're getting much closer!
Thanks!

@bkueng - is there another way to disable the camera in MAVSDK-Python? If we cold put an additional command in our script to turn the camera trigger off (a second time) after the completion of a mission, that would be a temporary work around. We could make the modification(s) in cpp, but that would be a more involved development and right now our time is short.
MM

Good!
@julianoes knows if you can send arbitrary commands from python MAVSDK.

It's not quite reliable - sometimes the camera will start triggering as soon as the mission is uploaded, and often times the camera will start triggering again after the aircraft has landed.

I remember there was a bug in navigator that would do that if the first mission item was a command. Which version are you on? If it's that then a work-around is to add another item before the command.

No you can't send arbitrary commands from MAVSDK-Python. MAVLink passthrough is only available for C++ so far.
In theory there should be some logic in navigator to stop triggering after the mission is done.
Or would this help?
https://github.com/PX4/Firmware/pull/13983/files

I didn't think we could send a command through Python and didn't want to get into the C++ code at this time.
We're running the latest stable build of PX4 and QGC 4.0.9.
@bkueng what would a non-command be? It seems like all of the actions are commands. The first line of the mission is always Mission Start. I don't think we can put anything in before that line.

SOLVED: sort of - we'll be working on a cleaner solution.
We put a takeoff command at the beginning of the mission and that seems to eliminate the camera triggering again after the mission is complete. So, for anyone wanting to trigger a camera using the basic GPIO (relay) output, the workflow is something like this: Setup the camera and Camera Trigger parameters as shown above. Use MAV_CMD_DO_TRIGGER_CONTROL to turn the triggering on or off parameter 1=1 =>on, parameter 1=0=> off. be sure to use a takeoff command as shown below.


Bad text recognition

Microsoft PowerToys version
0.76.0
Installation method
PowerToys auto-update
Running as admin
No
Area(s) with issue?
TextExtractor
Steps to reproduce
Extract text from a dash. you get this weird unicode character thats twice as long as a dash but isnt a dash. now extract text from an 8. it wrongly copies it down as an S. now try it with a 1. it wrongly copies it down as an l
✔ Expected Behavior
to do it right
❌ Actual Behavior
it did it wrong
Other Software
No response

FYI https://github.com/microsoft/PowerToys/issues/30192#issuecomment-1841662580

This issue is with the underlying OCR Engine and fixing it is beyond the scope of this project.


Back out "Add support for constructing expressions from string and evaluating"

Summary:
Reverting original diff since it seems to have broken CI.
Original commit changeset: 4f5a177fe122
Original Phabricator Diff: D42109851 (https://github.com/facebookincubator/velox/commit/aaa704df6f5988a34a45cfa7fc4cfdaf9e2e3a5c)
Differential Revision: D42154471

cc: @save-buffer Reverting this since apparently its breaking CI. Going to investigate and post a fix for that soon after merging this revert.


StoreInterleaved: 2 3 4

Describe the bug
in order to compile main branch I had to comment out all lines with StoreInterleaved2 StoreInterleaved3 StoreInterleaved4
(in dec_group_jpeg.cc and stage_write.cc)
To Reproduce
try to compile main branch
Expected behavior
main branch compiles successfully
Environment

OS: Gentoo Linux
Compiler version: gcc-12.2.1
CPU type: x86_64
cjxl/djxl version string: JPEG XL encoder v0.8.0  [AVX2]

Additional context
emerge =media-libs/libjxl-9999 with -DJXL_HWY_DISABLED_TARGETS_FORCED:BOOL=ON

so this issue was labeled as Platform-specific issues
I wonder where StoreInterleaved2 StoreInterleaved3 StoreInterleaved4 are on other platforms :thinking:

The building/portability label was used here because this seems to be a compiling/build issue.

Sorry, my fault, found all StoreInterleaved* in /usr/include/hwy/ops after updating dev-cpp/highway


OmniSharp Cannot access my file

Environment Data
.NET SDK (reflecting any global.json):
Version:   5.0.403
Commit:    bf9d168ac2
Runtime Environment:
OS Name:     Windows
OS Version:  10.0.22000
OS Platform: Windows
RID:         win10-x64
Base Path:   C:\Program Files\dotnet\sdk\5.0.403\
Host (useful for support):
Version: 5.0.12
Commit:  7211aa01b3
.NET SDKs installed:
3.1.415 [C:\Program Files\dotnet\sdk]
5.0.403 [C:\Program Files\dotnet\sdk]
.NET runtimes installed:
Microsoft.AspNetCore.App 3.1.21 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 5.0.12 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 3.1.21 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 5.0.12 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.WindowsDesktop.App 3.1.21 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 5.0.12 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
To install additional .NET runtimes or SDKs:
https://aka.ms/dotnet-download
Expected behavior
Access my file normally and analyze it.
[fail]: OmniSharp.Stdio.Host
        ************  Response (9.0975ms) ************
{
  "Request_seq": 5596,
  "Command": "/filesChanged",
  "Running": true,
  "Success": false,
  "Message": "\"System.IO.IOException: The process cannot access the file 'c:\\\\Users\\\\Administrator\\\\Desktop\\\\ZOO\\\\Zoogulation\\\\Assets\\\\Editor\\\\BundleBuilder.cs' because it is being used by another process.\\r\\n   at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)\\r\\n   at System.IO.FileStream.Init(String path, FileMode mode, FileAccess access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize, FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)\\r\\n   at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)\\r\\n   at System.IO.StreamReader..ctor(String path, Encoding encoding, Boolean detectEncodingFromByteOrderMarks, Int32 bufferSize, Boolean checkHost)\\r\\n   at System.IO.File.InternalReadAllText(String path, Encoding encoding, Boolean checkHost)\\r\\n   at OmniSharp.Roslyn.BufferManager.<UpdateBufferAsync>d__8.MoveNext() in D:\\\\a\\\\1\\\\s\\\\src\\\\OmniSharp.Roslyn\\\\BufferManager.cs:line 47\"",
  "Body": null,
  "Seq": 42236,
  "Type": "response"
}

@Rabbit0w0 Did you found a fix ? I got the same error


epoch_end Logs Default to Steps Instead of Epochs

🐛 Bug
Logs generated within validation_epoch_end have their iteration set to the number of steps instead of number of epochs.
To Reproduce
Steps to reproduce the behavior:

Create LightningModile with the below functions.
Train the module for 1 or more epochs
Run Tensorboard
Note the iteration for logs generated in validation_epoch_end

Code Sample
    def training_step(self, train_batch, batch_idx):
        x, y = train_batch
        y_hat = self.forward(x)
        loss = self.cross_entropy_loss(y_hat, y)
        accuracy = self.accuracy(y_hat, y)
        logs = {'batch/train_loss': loss}
        return {'loss': loss, 'log': logs}

    def validation_step(self, val_batch, batch_idx):
        x, y = val_batch
        y_hat = self.forward(x)
        loss = self.cross_entropy_loss(y_hat, y)
        accuracy = self.accuracy(y_hat, y)
        return {'batch/val_loss': loss, 'batch/accuracy': accuracy}

    def validation_epoch_end(self, outputs):
        avg_loss = torch.stack([x['batch/val_loss'] for x in outputs]).mean()
        avg_accuracy = torch.stack([x['batch/accuracy'] for x in outputs]).mean()
        tensorboard_logs = {'epoch/val_loss': avg_loss, 'epoch/accuracy' : avg_accuracy}
        return {'avg_val_loss': avg_loss, 'accuracy' : avg_accuracy, 'log': tensorboard_logs}

Version
v0.7.1
Screenshot

Expected behavior
Logs generated in *_epoch_end functions use the epoch as their iteration on the y axis

The documentation seems unclear on the matter. The Loggers documentation is empty. The LightningModule class doesn't describe logging in detail and the Introduction Guide has a bug in the example self.logger.summary.scalar('loss', loss) -> AttributeError: 'TensorBoardLogger' object has no attribute 'summary'.
Is there a workaround for this issue?

Looks like the LightningModule documentation for validation_epoch_end has a note regarding this, to use step key as in: 'log': {'val_acc': val_acc_mean.item(), 'step': self.current_epoch}. This does work correctly - perhaps this should be the default?

Looks like the LightningModule documentation for validation_epoch_end has a note regarding this, to use step key as in: 'log': {'val_acc': val_acc_mean.item(), 'step': self.current_epoch}. This does work correctly as a workaround - perhaps this should be the default for epoch end?

In the current version of PytorchLightening we are encouraged to use self.log() to log statistics, as opposed to returning a dictionary as mentioned in the previous comment. I can not see an obvious way to control the step with the new self.log() method?

Until the step functionality is introduced in self.log one could use self.logger.log_metrics and self.logger.agg_and_log_metrics instead which both have a step argument.

self.logger.log_metrics does work nicely, but it is not the ultimate solution I hope

Also waiting for an update on this, any of the above suggested methods does not work well when you are using early stopping for example.


Add "null version" class, and return compiler versions/build versions as Version objects

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your changes? Here's an example.
[x] Have you successfully run brew tests with your changes locally?

Right now, we return compiler versions and builds as raw strings/fixnums or nil. The latter has caused problems for us in the past: comparing nil vs anything will always fail, and comparing strings/numbers against nil similarly raises exceptions. This is a particular problem for non-typical platforms like Linux, which are commonly missing compilers which are present on OS X.
This patch makes some major changes to this model:

A new Version::NullVersion class has been introduced to represent the absence of a version. It supports the same API as Version, but always returns as smaller in any comparison, even against itself. An instance of it is available as Version::NULL.
Unparseable strings passed to Version.parse will now return Version::NULL instead of nil.
Compiler versions and builds are now returned as instances of Version instead of raw strings or integers.
For compatibility with existing formulae which compare compiler versions/builds against other strings or integers, Version#<=> will now coerce strings or integers into versions before proceeding with a comparison.
Version#<=> will always report a larger value when compared against a raw nil.

Are the Linuxbrew tests expected to be broken right now? Doesn't look related to this branch.

Are the Linuxbrew tests expected to be broken right now?

They are not expected to be.

I'm pretty sure the Linuxbrew failures are from bad compiler selection, I'll dig into the bug. The tests on OS X didn't surface this.

Fixed the compiler selection bugs, and beefed up the compiler selection tests a little.

@mistydemeo Feel free to 🚢 any time when you'll be around for e.g. ~4 hours to handle any post-merge 💥.

I'm on for about four hours now so I'm ready to handle the things I've inevitably broken. ✨


Implement auth interceptor using protobuf options

This uses protobuf options to describe the auth level for each service instead of having them as comments and then syncing the comments with the multi-server system.
I know this won't run as is; and it's missing tests. I wanted to seek out opinions before I put a lot of time into tests and fixing the rest of everything to work with this.
Pros:

.protos are the source of truth for required auth level, which reduces
Only need to have the server listening on one port instead of one for each auth level
Much easier to implement new auth levels (such as admin, implemented here)
Can do more complicated auth/interceptor annotations; e.g. per-method, or other per-service/method interceptor things
Potentially allows frontends to attach their own logic to services depending on annotations

Cons:

Silly protobuf reflection descriptor stuff
Need to have a generated DescriptorFileSet proto in backend too (but we already do codegen, etc; so I don't think this is big)

I've got to say: I do personally think these protobuf annotations/options are pretty nifty...
Missing:

Add is_admin (superuser) field to User removed from this PR
Fix envoy proxy to use single-port thing
Add tests

Backend checklist

[x] Formatted my code by running isort . && black . in app/backend
[ ] Added tests for any new code or added a regression test if fixing a bug
[ ] All tests pass
[ ] Run the backend locally and it works
[x] Added migrations if there are any database changes, rebased onto develop if necessary for linear migration history

Looks like the way to go!
Maybe do the admin in a later PR, so that this one is a pure refactoring step.
Tell me when you want to get flooded with code comments :D

Yep, ready for review now @kalvdans.
Happy to take suggestions for how to test this other than the existing tests.

Also, it's really "reflection", just using the info in the descriptor protos

Ping @kalvdans: the communities stuff requires this (and then a basic admin API to create a new community) before we can push it out

I guess one question here is whether the auth levels are ordinal or not?
If they're ordinal, then we can do increasingly stringent checks to make sure the token (if any) satisfies them.
If they're not; then we should really just basically have a different code path for each to check for each of the different behaviours, or something like that.

I guess one question here is whether the auth levels are ordinal or not?

As long as we only have three levels we can manage with comparing for equality or inequality to get all needed subsets of auth levels.

After this PR I'll add the admin level

After this PR I'll add the admin level

True. I guess we can depend on the numerical values of the enum as long as we document that it matters in annotations.proto .

Did I miss something or happy to merge @kalvdans ?


Add unit conversion test coverage & bugfix

Closes: #56

For contributor use:

[x] Targeted PR against main branch
[x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[x] Code follows the standards mentioned here.
[x] Updated relevant documentation
[x] Re-reviewed Files changed in the Github PR explorer
[x] Added appropriate labels

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.08%. Comparing base (d57c62b) to head (6add503).

Additional details and impacted files
@@                      Coverage Diff                      @@
##           solidity-contract-updates      #68      +/-   ##
=============================================================
+ Coverage                      86.00%   86.08%   +0.07%
=============================================================
  Files                             18       18
  Lines                            886      891       +5
=============================================================
+ Hits                             762      767       +5
  Misses                           124      124

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add tool to generator recommended config

#144

This looks great!
Not so sure how I feel about the existing rules that are marked as recommended... but that can be discussed later

@weirdpattern that was not a goal of this PR, in each rule we should specify if it recommended or not.

If you rename recommended.js to recommended.json, you won’t have to wrap it in the wrapper code you have.

but i'm not going to be able to put comment, but sure, i can change that

What if it wasn’t checked into Git and was regenerated as necessary? That would make it clearer that it’s generated.

@j-f1 its better if file is always present for reference (it's easier to check what is enabled by it)

Hey @j-f1 any way you can modify eslint-docs to read the recommended rules and list them in the README.md file?

I’ll try to look at it tomorrow, but feel free to open a PR!

I will take a look at it tonight

@weirdpattern we had something like that in eslint-plugin-vue

OOOOOKAY
I went through 4 configs that I know with config for our plugin, and came up with the following recommendations by merging them together.
Please provide feedback.
The configs for reference:
eslint-config-typescript-recommended

https://github.com/diva-e/eslint-config-typescript-recommended/blob/master/index.js#L124-L140
{
    "typescript/adjacent-overload-signatures": "error",
    "typescript/class-name-casing": "error",
    "typescript/explicit-member-accessibility": "error",
    "typescript/interface-name-prefix": ["error", "always"],
    "typescript/member-ordering": "error",
    "typescript/no-angle-bracket-type-assertion": "error",
    "typescript/no-empty-interface": "error",
    "typescript/no-explicit-any": "off",
    "typescript/no-namespace": "error",
    "typescript/no-parameter-properties": "off",
    "typescript/no-triple-slash-reference": "error",
    "typescript/no-type-alias": "error",
    "typescript/no-var-requires": "error",
    "typescript/prefer-namespace-keyword": "error"
}

eslint-config-typescript

https://github.com/weirdpattern/eslint-config-typescript/blob/master/src/typescript.js#L21-L68
{
    "typescript/adjacent-overload-signatures": "error",
    "typescript/class-name-casing": "error",
    "typescript/explicit-function-return-type": [
        "error",
        {
            "allowExpressions": true
        }
    ],
    "typescript/explicit-member-accessibility": "error",
    "typescript/interface-name-prefix": "error",
    "typescript/member-delimiter-style": "error",
    "typescript/member-ordering": [
        "error",
        {
            "default": [
                "static-field",
                "private-field",
                "protected-field",
                "public-field",
                "constructor",
                "public-method",
                "protected-method",
                "private-method"
            ]
        }
    ],
    "typescript/no-angle-bracket-type-assertion": "error",
    "typescript/no-array-constructor": "error",
    "typescript/no-inferrable-types": [
        "error",
        {
            "ignoreProperties": true,
            "ignoreParameters": true
        }
    ],
    "typescript/no-namespace": [
        "error",
        {
            "allowDeclarations": true
        }
    ],
    "typescript/no-non-null-assertion": "error",
    "typescript/no-parameter-properties": "error",
    "typescript/no-triple-slash-reference": "error",
    "typescript/no-use-before-define": "error",
    "typescript/no-var-requires": "error",
    "typescript/prefer-namespace-keyword": "error",
    "typescript/type-annotation-spacing": "error"
}

eslint-config-standard-with-typescript

https://github.com/mightyiam/eslint-config-standard-with-typescript/blob/master/src/index.ts#L19-L32
{
    "typescript/adjacent-overload-signatures": "error",
    "typescript/explicit-function-return-type": "error",
    "typescript/explicit-member-accessibility": "error",
    "typescript/member-delimiter-style": [
        "error",
        {
            "delimiter": "none"
        }
    ],
    "typescript/no-angle-bracket-type-assertion": "error",
    "typescript/no-array-constructor": "error",
    "typescript/no-empty-interface": "error",
    "typescript/no-namespace": "error",
    "typescript/no-non-null-assertion": "error",
    "typescript/no-triple-slash-reference": "error",
    "typescript/no-unused-vars": "error",
    "typescript/no-use-before-define": [
        "error",
        {
            "functions": false,
            "classes": false,
            "variables": false,
            "typedefs": false
        }
    ],
    "typescript/no-var-requires": "error",
    "typescript/type-annotation-spacing": "error"
}

eslint-config-assignar

This is the last company I worked at, and I did the eslint config :)
https://github.com/assignar/eslint-config-assignar/blob/develop/packages/eslint-config-assignar-base/src/plugins/typescript.ts
{
    "typescript/adjacent-overload-signatures": "error",
    "typescript/class-name-casing": "error",
    "typescript/explicit-function-return-type": "off",
    "typescript/explicit-member-accessibility": "error",
    "typescript/interface-name-prefix": ["warn", "never"],
    "typescript/member-delimiter-style": [
        "error",
        {
            "delimiter": "none",
            "requireLast": true,
            "ignoreSingleLine": true
        }
    ],
    "typescript/member-naming": "off",
    "typescript/member-ordering": "off",
    "typescript/no-angle-bracket-type-assertion": "error",
    "typescript/no-array-constructor": "error",
    "typescript/no-empty-interface": "off",
    "typescript/no-explicit-any": "warn",
    "typescript/no-inferrable-types": "off",
    "typescript/no-namespace": [
        "error",
        {
            "allowDeclarations": false,
            "allowDefinitionFiles": true
        }
    ],
    "typescript/no-non-null-assertion": "warn",
    "typescript/no-parameter-properties": "error",
    "typescript/no-triple-slash-reference": "warn",
    "typescript/no-type-alias": "off",
    "typescript/no-unused-vars": "error",
    "typescript/no-use-before-define": "error",
    "typescript/no-var-requires": "off",
    "typescript/prefer-namespace-keyword": "off",
    "typescript/type-annotation-spacing": [
        "error",
        {
            "before": false,
            "after": true,
            "overrides": {
                "arrow": {
                    "before": true,
                    "after": true
                },
                "colon": {
                    "before": false,
                    "after": true
                }
            }
        }
    ]
}

Recommended Config
{
    "typescript/adjacent-overload-signatures": "error",
    "typescript/ban-types": [
        "error",
        {
            "types": {
                "Boolean": {
                    "message": "Use boolean instead",
                    "fixWith": "boolean"
                },
                "Number": {
                    "message": "Use number instead",
                    "fixWith": "number"
                },
                "Object": {
                    "message": "Use Record<string, any> instead",
                    "fixWith": "Record<string, any>"
                },
                "Symbol": {
                    "message": "Use symbol instead",
                    "fixWith": "symbol"
                }
            }
        }
    ],
    "typescript/camelcase": [
        "error",
        {
            "allow": ["^UNSAFE_"],
            "ignoreDestructuring": false,
            "properties": "never"
        }
    ],
    "typescript/class-name-casing": "error",
    "typescript/explicit-function-return-type": [
        "error",
        {
            "allowExpressions": true
        }
    ],
    "typescript/explicit-member-accessibility": "error",
    "typescript/generic-type-naming": ["error", "'^T[A-Z][a-zA-Z]+$'"],
    "typescript/interface-name-prefix": ["error", "never"],
    "typescript/member-delimiter-style": "error",
    "typescript/member-ordering": "error",
    "typescript/no-angle-bracket-type-assertion": "error",
    "typescript/no-array-constructor": "error",
    "typescript/no-empty-interface": "error",
    "typescript/no-explicit-any": "error",
    "typescript/no-inferrable-types": [
        "error",
        {
            "ignoreProperties": true,
            "ignoreParameters": true
        }
    ],
    "typescript/no-namespace": [
        "error",
        {
            "allowDeclarations": true
        }
    ],
    "typescript/no-non-null-assertion": "error",
    "typescript/no-parameter-properties": "error",
    "typescript/no-triple-slash-reference": "error",
    "typescript/no-type-alias": "off",
    "no-unused-vars": "off",
    "typescript/no-unused-vars": "off",
    "typescript/no-use-before-define": "error",
    "typescript/no-var-requires": "error",
    "typescript/prefer-namespace-keyword": "error",
    "typescript/type-annotation-spacing": "error"
}

Default configuration of plugin should be recommended one, than we should update default config for those rules.

camelcase is the general consensus I've seen for javascript code now-a-days. I have seen people disable properties due to the fact that APIs are often non-standard in their casing.
class-name-casing is another consensus I've seen from the community in regards javascript class names. The TS docs use PascalCase for all interfaces names from what I can see as well.
generic-type-naming is an open thing; it's a holdover from C# but most people don't have a preference I think.
I haven't seen any consensus in the official docs about it (they switch between single character generic names T/K/U).
What do people think?
I'm happy to turn off member-ordering, I don't like it personally as well, but 2 of the configs had it on, so I turned it on...

okie dokie.
So I think the best course of action is to merge this PR first.
Then we'll go ahead and merge this.
And we'll then go about raising separate PR(s) to update the config to match the desired recommended set.


Upgrade io.swagger.core.v3:swagger-annotations 2.2.10 -> 2.2.11

This PR contains the following updates:

Package
Type
Update
Change

io.swagger.core.v3:swagger-annotations
compile
patch
2.2.10 -> 2.2.11

Release Notes

swagger-api/swagger-core
v2.2.11: Swagger-core 2.2.11 released!
Compare Source

Update Jackson to 2.15.1 to be consistent with SnakeYAML 2.0 (#4417)
apply JAX-RS path regex to params (#4415)

[ ] If you want to rebase/retry this PR, check this box

Suggested commit message:
Upgrade swagger-annotations 2.2.10 -> 2.2.11

See:
- https://github.com/swagger-api/swagger-core/releases/tag/v2.2.11
- https://github.com/swagger-api/swagger-core/compare/v2.2.10...v2.2.11


Do unsubscribe when user request another page and still has pending request

Referenced to https://github.com/IndomaximTechID/storaji/issues/12

Fixed refers
5ef1a5ff4e256b15f54e2921d3c655bed22b3002
ec9c2d78050e6213da0801d6354549c5aa440c91
a404781b8b22954e2a80f93ff6c3ccf29ab7ca59
5146500bea9e8f30bb3703c2eeac6e7d70bd3c73
15b06a0a59fe92f3e398146fd0702a4ddf6453a0
4fe1c47fed803bb46e1070bcce8ac977bf9ce945


Translate [Developer - sênior] session

Translate [Developer - sênior] session on this link.
Related to: #19

[ ] es
[ ] en

@woliveiras I am translating to English, maybe tomorrow I will send the pull request.

Great @thiamsantos!!
Thanks by help!


Chef-Client Version 14.4.56 not running as Scheduled Task

Cookbook version
11.0.0
Chef-client version
14.4.56
Platform Details
AWS provided base Windows Server 2016 AMI/ Custom Windows Server 2016 AMI
Scenario:
Use the chef-client cookbook to create a scheduled task for automatic convergence every 30 minutes
Steps to Reproduce:
Add the chef-client cookbook to the run-list during the node bootstrap process
Expected Result:
chef-client run as a scheduled task every 30 minutes
Actual Result:
The last result for the chef-client run in the Task Scheduler window is showing 0x1 error code.
The instances that have Chef-Client version 14.3.37 installed on them are running as expected, but all the instances with the Chef-Client version 14.4.56 are causing the issue.

+1
All of my Windows machines have stopped running chef-client through scheduled task. A manual chef-client run works fine though.

Same here.

I am seeing the same issue.  I believe this is due to how the scheduled task is defined.
The scheduled task that gets created runs cmd.exe /c '<>'
The issue is with the single quotes. They should be double quotes.
This appears to be due to the if statement on line 49 of /resources/scheduled_task.rb

Same here.

Yes, it looks specifically like we need to update:
https://github.com/chef-cookbooks/chef-client/blob/57e8b9741f1d0f92ca5c20b2a80289b4a2bef50f/resources/scheduled_task.rb#L47-L53
Given that Chef 14.4 delivered fixes to quote handling so they should be passed through correctly, in this case we need the double quotes as @dpmcgarry suggests.


✨ Extended BDL input iterator to support different SiDB input representations

Description
This PR extends the BDL input iterator to accommodate the varying ways input information can be implemented in SiDB technology. In some cases, such as with Bestagon gates, the binary value 0 may be represented by a perturber placed farther away compared to the 1 state. In contrast, SiQAD gates typically represent 0 by the absence of a perturber and 1 by the presence of a perturber.
In addition, this PR includes the missing experiment scripts needed for temperature simulation.
Checklist:

[x] The pull request only contains commits that are related to it.
[ ] I have added appropriate tests and documentation.
[x] I have added a changelog entry.
[x] I have created/adjusted the Python bindings for any new or updated functionality.
[x] I have made sure that all CI jobs on GitHub pass.
[ ] The pull request introduces no new warnings and follows the project's style guidelines.

@Drewniok can you still add a CHANGELOG entry, please?

@Drewniok can you still add a CHANGELOG entry, please?

Done!


Redirect with data

How would I redirect to URL with additional data, success message, errors?

Use query params? We do not use redirected forms, check spiral/toolkit (Ajax forms). Thought we do not have many docs for it yet. But it will be documented with admin panel soon

Yes with query params!
Use Case 1: When I try to login with invalid credentials, I should be redirected to login with errors

Pass additional parameters into the Router->uri method. Second argument, docs are here: https://spiral.dev/docs/http-routing#url-generation
You can also modify the generated Uri object, see https://www.php-fig.org/psr/psr-7/

This is working:
$uri = $this->router->uri('login', [
    'error' => 'Invalid Users'
]);
return $this->response->redirect($uri);

It's a bit difficult... :)

Thanks @wolfy-j Closing it

I'll show you later the proper way to do that. So you won't need to redirect anything like that.


DropDown improvements

What does the pull request do?
Makes DropDown more useful in general:

When DropDown is Open scrolls and focus selected item so it's visible even if drop down has many items
Can select item with up/down keys when dropdown is closed
Focus back DropDown when popup is closed, so user don't loose focus to hidden popup
Minor styling changes so selected and focused items have distinct UI
Add Virtualization support to DropDown
DropDown Popup don't go outside screen

What is the current behavior?

Improve DropDown in several areas
How was the solution implemented (if it's not obvious)?

This PR is ready for review/test. Now Drop down behaves better


Add a full session example

Currently, only individual commands have examples. I wonder if it will be easier to understand for newcomers with a more complicated example of the "common session". The fastboot specification document from Google has this example, I think it would be a good target for doing so:
Example Session
---------------
Host:    "getvar:version"        request version variable
Client:  "OKAY0.4"               return version "0.4"
Host:    "getvar:nonexistant"    request some undefined variable
Client:  "OKAY"                  return value ""
Host:    "download:00001234"     request to send 0x1234 bytes of data
Client:  "DATA00001234"          ready to accept data
Host:    < 0x1234 bytes >        send data
Client:  "OKAY"                  success
Host:    "flash:bootloader"      request to flash the data to the bootloader
Client:  "INFOerasing flash"     indicate status / progress
         "INFOwriting flash"
         "OKAY"                  indicate success
Host:    "powerdown"             send a command
Client:  "FAILunknown command"   indicate failure

I'll just add a full CLI, similar to what other Rust libraries do. It's quite trivial and should be good enough as a reference for using the crate as a pure library.


🐛 BUG: better-sqlite3 issue and Cloudflare dashboard D1 GET error

Which Cloudflare product(s) does this pertain to?
D1, Wrangler
What version of Wrangler are you using?
2.12.0
What operating system are you using?
Mac
Describe the Bug
I have a bare bones worker that don't do anything else. Fresh init.
I have created a binding to a D1 database created through Wrangler. But when I try to run wranger dev --local I get this error:
Error: npx-import failed for better-sqlite3 with message:
    Command failed with exit code 1: npx --prefer-offline -y -p<EMAIL_ADDRESS>printenv PATH

And for some reason I can't install better-sqlite3 locally.
When I try to follow the tutorial in the docs on publishing a Worker with a D1 database... it fails when installing better-sqlite3.
Another strange issue:
When I log into my Cloudflare dashboard and go to my D1 databases... of which I only have the one.
I get this error popup at the bottom...
API Request Failed: GET /api/v4/accounts/<ACCOUNT ID>/d1/database/<D1 Id>
Where Account Id is my account id and D1 Id is the id for the D1 database I created.
Any ideas what might be the issue?

Did you find the workaround?
Even i am facing the same issue.

@IcedMonk I did not. I am also on a timeline so decided to use Planetscale for the next couple projects until D1 is ready for prime time.


feat: pause collab when user switches tabs in the browser

This will stop the socket connection when the user switches to another tab in the browser and reconnects when switches back. Heavily inspired by https://github.com/excalidraw/excalidraw/pull/5625
What is left to be done:

[x] Set user as idle
[x] Find out why is visibilityChange event handler fired multiple times
[x] Merge with onVisibilityChange event handler in the Collab.tsx, (Collab.tsx should handle all logic regarding disconnecting, and index.tsx should be only responsible for UI)
[x] Disable viewModeEnabled after the scene is updated (this is related to the rewrite of the logic above)

There's a case that can be reproduced during testing by lowering the disconnect timeout, but I'm not seeing why that couldn't happen in production as well:

connect two clients to a room
disconnect client A due to inactivity
reload browser on client B
while client B is fetching data from firebase, go to client A and reconnect
neither client gets connected together, and they won't reconnect afterwards by switching between the two tabs (to try to disconnect/reconnect again) either.

The case from https://github.com/excalidraw/excalidraw/pull/6638#issuecomment-1600799080 still seems to be there, but there's also this case which would be way more common:

join to room with clients A, B
disconnect both clients
reconnect client A, then reconnect client B
they don't see each other

The case from #6638 (comment) still seems to be there, but there's also this case which would be way more common:
1. join to room with clients A, B

2. disconnect both clients

3. reconnect client A, then reconnect client B

4. they don't see each other

Interesting, I'm getting the same error with debug commit (https://github.com/excalidraw/excalidraw/pull/6638/commits/0fe79f8819bc7e712c4dcee1b73fbb599b2090b8), but when I checkout to the one before (https://github.com/excalidraw/excalidraw/pull/6638/commits/772a9999b8b22a7b60a79f0b86e53d0707704222) reconnecting works as intended. Something in the change of timeouts and events causes the breaking of reconnecting flow.
Though it is worth investigating as we can meet the same issue in the future.


What is the expected way to debug the native library?

As the native library is usually spawned by a nodejs code located outside of this repository - what is the expected way to debug the calls to the spawned process?

I guess it is done by waiting with lldb for the process spawn process attach --name ios-device-lib --waitfor (this could be done from xcode in debug -> attach to process by PID or Name)

That would depend on what you'd like to debug.
If you'd like to debug the C++ code you could launch the binary directly and paste a message, connected to the section you'd like to debug manually. I've added some example messages in the docs.
If you'd like to debug the Node.js you could write a sample script that reproduces some behavior and debug it in VS Code.


Allow users to register new 'types' of controls for output

This is similar to allowing a definition to have it's own template defined for granular customization, but more generalized so a new component can be added to the built in html text link select options.

Decide if this really needs to generate new directives on the fly....

Fixed with PR #47.


Change the garbageCollectionEnabled field to garbageCollection.enabled

How to categorize this PR?

/kind enhancement
What this PR does / why we need it:
The API change is done to make it easier in future to add new fields related to the garbage collection. For example there is a TTL field that we would like to expose when there is a distribution/distribution release with the PR that introduced the TTL future (ref https://github.com/distribution/distribution/pull/3880).
Which issue(s) this PR fixes:
Part of #3
Special notes for your reviewer:
N/A
Release note:

The `caches[].garbageCollectionEnabled` field is changed to `caches[].garbageCollection.enabled`.

/approve


Adding entry to Built with Eleventy

Website and tech blog, powered by Eleventy and Gulp

Thank you!


Add mteb(eng), mteb(europe), mteb(indic) and mteb(multilingual)

[ ] MTEB(eng):

Notably update touche to v3: https://github.com/embeddings-benchmark/mteb/pull/1262

[ ] MTEB(multilingual):

add miraclhardnegatives

[ ] MTEB(europe) and MTEB(indic) need to be added

Is this issue about adding/extending benchmarks in benchmarks.py?

Just noticed that MTEB(pol) is in lowercase instead of upper case for the lang code. Can update that in the next PR as well.


Maven dependencies might be de-duplicated

I just verified that ORT's analyzer suffers from the same problem as CycloneDX's Maven plugin: The Maven resolver library might de-duplicated dependencies that have already been reported, resulting in an incomplete tree for some  (direct) dependencies.
While at first the discussion in that issue makes it sounds like a pure upstream maven issue, the question remains why apparently the depgraph-maven-plugin gets it right nonetheless.

On a related note, there's a tree-based API for resolution of Maven project dependencies which might solve the problem, and we should consider using it instead of our low-level approach. That library apparently also does only download the POMs which would allow us to get rid of our work-around.

On a related note, there's a tree-based API for resolution of Maven project dependencies which might solve the problem

Looks like we'd need to use its DefaultDependencyCollectorBuilder instead of the DefaultDependencyGraphBuilder, as that's what the maven-dependency-plugin uses in "verbose" mode, see https://github.com/apache/maven-dependency-plugin/commit/d9d34c6674db6c9a5c0786c95d0caf96bc9636fb.

Another interesting Maven artifact resolver implementation to look at is https://github.com/square/maven-archeologist. It also points out https://github.com/google/guava/wiki/GraphsExplained which might be an alternative for our own dependency graph implementation.


ENH: scipy.signal.cwt : provide richer output

Is your feature request related to a problem? Please describe.
When using cwt, the results are often plotted as a 2d pcolor or pcolormesh or similar; currently, cwt only returns the 2D array to be plotted, and the user has to figure out everything about the X and Y axis content.
Describe the solution you'd like.
Change the return of cwt to provide, similar to for example scipy.signal.spectrogram, a triplet (f, t, cwt): frequency, time, cwt matrix.
Describe alternatives you've considered.
The alternative I found so far is to use another package, for example it is possible to do the following in pywt
coef, freqs = pywt.cwt(x, np.arange(1, 50), 'morl',
                       sampling_period=sampling_period)

or in squeezepy:
Twxo, Wxo, *_ = squeezepy.ssq_cwt(xo)

but would be nice to have all in scipy
Additional context (e.g. screenshots, GIFs)
No response

Hey @jerabaul29, the input signal's length is generally used for the time scale, and the input width parameter is used for the width scale. Can you please clarify how will receiving 'f' and 't' from the function will help?

Currently the user has to do the scaling, sampling, definition of the "coordinate arrays", correctly, in order to generate the right time and width. This is potentially error prone. I think that it would be even better if this could be done directly by the function call, so that the user can "just" take the output of the function, and directly plug it in additional functions like pcolor, or plots, etc. See the examples above: pywt and squeezepy provide additional output variables that represent these scales :) .

CWT is deprecated in scipy 1.12, along with the rest of the wavelet functionality. So, this enhancement request cannot be acted upon. Thank you @jerabaul29 regardless.


Some invalid transactions removed from the pool should be revalidated

During block authorship we attempt to detect invalid transactions that are still in the pool.
Since pool is being cleaned asynchronously, it is a completely legal and valid situation - in the front of the ready queue we have transactions that just got included to recently imported/authored block.
However the transactions that are detected invalid are removed from the pool via remove_invalid call.
That in turn causes the entire subtree of transactions to be removed (i.e. all transactions that depend on the invalid ones), as we assume that since their predecessor is invalid they are going to be invalid too.
As an example, let's imagine we have a following set of transactions in the pool (coming from the same sender):
tx(nonce=1)
tx(2)
tx(3)
tx(4)

now, we import a block that contains tx(1), but don't clear the pool.
If we attempt to produce another block, tx(1) will cause InvalidTransaction::Stale error to be returned, hence we will mark it as invalid.
Next we will try to execute tx(2), but it will obviously succeed.
Then imagine that tx(3) does not fit to the block - we finish up block authoring and should resume the next block starting off with including tx(3).
However remove_invalid(tx(1)) will cause the entire subtree originating in tx(1) to be removed from the pool, so tx(3) and tx(4) will no longer be there.

Solution
There are two ways to solve that issue:

Either attempt to resubmit transactions that were not directly invalid, but just transitevly (tx(2),tx(3),tx(4) in the example)
Or remove only invalid transactions reported directly, not their subtrees - this may leave some more invalid transactions in the pool, but they should just be detected on next attempts.

I'd vote for option (2), cause it's more suited for frame-based runtimes, since most likely the transactions left in the pool are still valid. We can possibly implement both solutions and have that configurable as well.

CC @NikVolf let me know if you want to tackle this one.

now, we import a block that contains tx(1), but don't clear the pool.

(1) why we don't clear the pool, then?
(2) I think we go with variant 2, but we can differentiate and don't remove subtree when transaction is Stale and remove subtree when it is invalid for other reason.

(1) we do that asynchronously currently, and we don't really know when the notification task will be picked up.
(2) Yeah that sounds reasonable too.

(1) But notification about previously imported block should be picked up long before we start constructing block on top of it. Maybe we should make sure that imported transactions are removed as fast as possible, and then we can avoid fixing something that not broken?

(1) We remove all known transactions from the pool as soon as we receive import notification
So what makes you think the whole story is the issue?

(1) If new block construction starts immediately, i.e. when transaction pool is still processing notification from the imported block, we can make part the removes known transaction synchronous (move this outside of async block). Another solution is too just note known tags synchronously and never include corresponding transaction in ready iterator.

maintain function in the code that you linked is being called after we receive notification from import_notification_stream, right? This means that block authorship and maintenance are separate tokio tasks and run indepedently on the same runtime. It also means that either of those tasks can be "starved" for a while and just don't run. That creates the race condition described above.
I observed the issue in tests when working on #5121 but it also explains behaviour that was seen by @shawntabrizi when working on benchmarks.
Basically it will happen if we try to produce blocks very fast (for instance --dev chain) and the starvation of maintenance happens.

Another solution is too just note known tags synchronously and never include corresponding transaction in ready iterator.

Yup, I've been thinking about that too - like quickly skipping transactions that are known to be in chain in ReadyIterator.
I'm not strong on any of those solutions, so whoever picks this issue up should be free to choose whatever they prefer and works best.

@NikVolf  @bkchr I think this issue is still there. Is there a plan to fix it at any point soon? What are the blockers?


python bindings

via on irc.freenode.net #logcabin is working on SWIG-based Python bindings. I think it's currently showing signs of life but maybe isn't the nicest API yet.


button story: user-select:none on press test does not work in High Contrast mode

🐛 Bug Report
user-select:none on press test story does not work in high contrast mode
🤔 Expected Behavior
All stories should meet accessibility guidelines
😯 Current Behavior
The button appears in red which isn't a colour which should appear in high contrast mode
💁 Possible Solution
Do not use UNSAFE_style to set background colours for items unless they have been tested in High Contrast mode.
Alternatively change the high contrast implementation to not use forced-color-adjust: none on the base element.
🔦 Context
Performing an accessibility audit of all react spectrum components.
💻 Code Sample
(https://reactspectrum.blob.core.windows.net/reactspectrum/41e26fa0f01ee9ab6e5c21edf6f7bb5d498bf40f/storybook/index.html?path=/story/button--user-select-none-on-press-test)
🌍 Your Environment

Software
Version(s)

react-spectrum

Browser
Edge

Operating System
Windows (or using forced-colors in dev tools)

🧢 Your Company/Team
Accessibility
🕷 Tracking Issue (optional)

These stories are for internal testing only and are not real world examples.  Accessibility testing can be carried out on the documentation website or the more standard stories if more examples are needed.


Re-factor MPI native tests to run as distributed tests

In this PR I adapt all the existing mpi-native tests to run in our current distributed test setting. Most of the code in place can be re-used with very minimal changes.
Two tests are left with the [.] tag as they used MPI_Win_create which we removed some time ago.

May re-open this in the future.


Travis builds are errorring because of submodules checkout

The current Travis config tries to pull the two submodules from this repo but is failing because it does not have the correct access rights.
We can fix this either by using https urls for submodules so no access right is needed, but it will prevent developers from pushing from those submodules when developping locally.
We can also tell Travis to not pull submodules by adding this to the config and completly ignoring the issue:
git:
    submodules: false

But it means that Travis won't be able to run the linting process on the submodules, and that we hope that each submodule will have correctly applied the linting. I'd rather not remove the lint check in here (even if it is currently not working, see #23).
The best way would be to create a GitHub user with a specific key and share this key with Travis so it can correctly pull everything.
Or... we can hack our way around with this:
# Handle git submodules yourself
git:
    submodules: false
# Use sed to replace the SSH URL with the public URL, then initialize submodules
before_install:
    - sed -i 's/git@github.com:/https:\/\/github.com\//' .gitmodules
    - git submodule update --init --recursive

(Source).
What do you think? I'm ok with the hacky solution, but if someone has the courage to create the needed GitHub permissions that'd be even better.

Hey Folks,
Unfortunately creating a specific user doesn't seem possible on https://travis-ci.org but only on Travis Pro:
https://docs.travis-ci.com/user/private-dependencies/#User-Key
Using deploy keys would be definitely awkward (one per submodule), I'd go for the hack.

@proudlygeek
I generate sshkey with travis shell locally.

And I'm sure that the sshkey has been added into github setting and travis repository setting.

However, travis built fail because of the short of permission to read repository.

Detailed Build Report. Is there any step I did not follow the documentation?
Waiting for your reply, thank you

For people Googling this, this checkbox in Travis Pro can help:


add target for new temp-humidity module

will need to update jacdac-stm32x0 submodule

could you add jm-temp-humidity-18-1.0A to DROP_TARGETS? so it gets built in gh action

Done!

you might have missed the .mk file?
https://github.com/microsoft/jacdac-msr-modules/pull/1/checks?check_run_id=1982284130#step:8:811

It's in the PR to the jacdac-stm33x0 repository:
https://github.com/microsoft/jacdac-stm32x0/pull/15/files

upper case/lower case "stm"

Flip! Thanks, will push.
I'm in two minds as to whether all file systems should be case insensitive :wink:


feat(pyroscope/scrape): add support for configuring CPU profile's duration scraped by pyroscope.scrape

PR Description
Which issue(s) this PR fixes

Fixes #195
Notes to the Reviewer
PR Checklist

[x] CHANGELOG.md updated
[x] Documentation added
[x] Tests updated

Docs here include suggestions from the Agent PR, so all good from a doc standpoint. Over to the @grafana/grafana-alloy-maintainers  team for code review

Thanks for the contribution, this is a very useful knob to be able to turn 🙂
I am happy with this to go forward, once all the points @tpaschalis has raised are addressed.

Oops, git rebase sheenanigan 🤦

@tpaschalis @simonswine Anything we can do to help move this forward ? I think @hainenber fixed all the previous comment

Has this change been released? I don't see it in the docs or the changelogs.

Has this change been released? I don't see it in the docs or the changelogs.

It is in the next release, so for docs, you find the new content in the "next" version of the pyroscope.scrape component reference documentation: https://grafana.com/docs/alloy/next/reference/components/pyroscope.scrape/#common-configuration  When Alloy v1.2 is release, this doc change will show up in "latest".


Include Logs Location in Install Toolkit

Is it possible to include this option in the Toolkit? I see it throws it to %temp% but it would be awesome to have the option to dump this to a network drive. Would help in large deployment

This feature has been added to the toolkit, thanks for your feedback.


tr atributes differ

tr attribute when loading throug ajax are diffrend then loading from twig

Use "row_attr" option istead. You can pass there array of your custom tr attributes. Example for onclick attribute:
'row_attr' => array(
                'onclick' => function(MediaSubject $row) {
                    $url = $this->router->generate('media_subject_show', array(
                        'id' => $row->getId()
                    ), true);

                    return 'document.location = \'' . htmlspecialchars($url) . '\'';
                }
            )

Why should not add custom attributes inside twig template? Becouse it will be rendered only first time by PHP (when defer_load is false). All tatatable communication with server side is done by JSON and custom attributes must be included inside that json with don support html of tr tag.


TagHelperElementCompletionService does not return TagHelper completions with a prefix.

https://github.com/aspnet/Razor/commit/cf44f103c11a7bf01cc37d1f2cd7a1263981dc0b


Added world downloading

This PR adds world downloading to servertap. Please version the release, as I don't know the versioning this project uses.

backups :rocket:


Refactoring of code is in order

There is so much wrong with this code. A complete refactoring is in order.

New project for this can be found here


SqlQuery(Type elementType, string sql, params object[] parameters) not supported in Ef core

I' m moving one large project from MVC5 to EF core.
SqlQuery was extremely useful in EF6 as i called stored procedured and didn't need store SomeModel as Entity in DbContext.
I'm trying to bypass it.
If i use suggested way: public DbQuery SomeModels { get; set; } it makes me store SomeModel in DAL assembly. It's very inconvenient as this model is  depending on  some services living in Services assembly.  So i have cross-reference between assemblies.
Please suggest anything

We face the same issue, many large projects using EF6 SqlQuery, having SqlQuery in EF Core would be great and solve a lot of issues for us.

Duplicate of #10753

@ajcvickers I think what some of us are looking for is an equivalent to the SqlQuery that we had in EF 6;
#10753 does not solve the issues because of DbQuery complaining that Query types cannot have keys. While all my complex read-only view models are annotated with the [Key] attribute, removing them would not be trivial and practical because sometimes the models are used by DbSet and sometimes by DbQuery
#1862 is closed but does not actually solve the issue (Raw store access APIs: Support for ad hoc mapping of arbitrary types)
I am hoping an equivalent functionality (SqlQuery) is brought back, or, allow the [Key] attributes to exist in a model for Query types.

Added a note to #10753 to consider the case of multiple mappings for the same CLR type.


Permissions returned from FUSE are wrong

@derekchiang I think you just saw (and perhaps resolved) this -- tar was modifying permissions in something you were working on

We have tests covering permissions and they seem to be correct. Closing.


Changed meaning of .+= in Julia 0.5

Your code uses x .+= y, so you should know that in Julia 0.5 this has changed meaning to be equivalent to broadcast!(identity, x, x .+ y), so that it mutates the x array (see JuliaLang/julia#17510 … in Julia 0.6 the whole operation will occur in-place without temporaries).  So .+ should only be used if the left-hand side is a mutable array, and you don't mind mutating it.
At first glance, this seems like a problem for you, because you use y .+= μ / (1 - ρ) where y is a LinSpace object, which is immutable.  You can change it to += to avoid trying to mutate y.   (However, the code is type-unstable in any case because y changes types, so you might want to use a new variable.)

Thank you for opening this up! We will have to change what we are doing here.


.edit on Linux without setting VISUAL/EDITOR crashes the shell

... because it assumes that vim exists:
Traceback (most recent call last):
  File "/usr/local/bin/aws-shell", line 9, in <module>
    load_entry_point('aws-shell==0.0.1', 'console_scripts', 'aws-shell')()
  File "/usr/local/lib/python3.4/dist-packages/awsshell/__init__.py", line 63, in main
    shell.run()
  File "/usr/local/lib/python3.4/dist-packages/awsshell/app.py", line 213, in run
    self._dot_cmd.handle_cmd(text, application=self)
  File "/usr/local/lib/python3.4/dist-packages/awsshell/app.py", line 113, in handle_cmd
    self.HANDLER_CLASSES[cmd_name]().run(parts, application)
  File "/usr/local/lib/python3.4/dist-packages/awsshell/app.py", line 82, in run
    p = self._popen_cls([editor, f.name])
  File "/usr/lib/python3.4/subprocess.py", line 859, in __init__
    restore_signals, start_new_session)
  File "/usr/lib/python3.4/subprocess.py", line 1459, in _execute_child
    raise child_exception_type(errno_num, err_msg)
FileNotFoundError: [Errno 2] No such file or directory: 'vim'

Couple actionable things I see:

The error message should be cleaned up.  No stack trace should be printed either.

2a. Change the default to vi.  This is what other tools fall back to (including git and from what I understand is a part of the posix standard (http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap02.html)
2b. Try several editors, similar to what's done here.
I think I'd prefer to go with 2a instead of 2b for now unless we start hearing that vi is not available on people's machines.

I think I'd prefer to go with 2a instead of 2b for now unless we start hearing that vi is not available on people's machines.

Sounds good :+1:


feat: Combobox autocomplete variant implementation

Closes # INITIATE-1739
📝 Description

Created new autocomplete variant for Combobox component
Created new loading and loadingText props to combobox to give devs ability to configure loading states for async combobox implementation
Created new noResultsState prop that give devs control over no results states for a combobox

Screenshots

Merge checklist

[ ] Added/updated tests
[ ] Added changeset

@danielrobertson made updates after our pairing session


flix: init at 0.35.0

Description of changes
Added derivation for the Flix compiler, a somewhat popular project (1700 stars on GitHub).
Note that this derivation uses the upstream .jar file, as seems relatively common for Java-based derivations.  I suppose I can change the derivation to use sbt to build from source, if that is desirable, but I don't think I know of any existing derivations that use sbt.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/912

Anything else that remains to be done?

Don't think so, probably best to ping another nixpkgs-commiter. Going to send a message to the matrix dev channel.


Zero acceleration in received data

I am trying to get data form z1 using python. Realized that all obtained joint acceleration are always zeros. Is there exist any way to get valid acceleration data?

This is a historical issue, although the parameter is present in the structure but Unitree's robots do not currently contain acceleration information


Solve Statistics

We need methods to get info about the the solve.  For example,

number of nodes explored
number of cuts generated

The gurobi docs can provide some inspiration.

Just to clarify:
The number of explored nodes is the number of computed relaxations, right?

Includes the number of relaxations computed during a strong branching step

The number of cuts generated is at the moment the number of new incumbent solution and therefore the number of bounding steps, right?

The number of explored noted is actually the size of the tree that was explored.  How strong branching effects this depends on the implementation.
If you throw out all the information after doing strong branching this would only count as 1 node.  If you are opening a bunch of new nodes and then branching on the best one first, then it would count as multiple nodes.

Regarding number of cuts generated, probably the number of constraints added to the problem during search is the right number.

In strong branching I branch on different variables (each creating two nodes) then choose the best for the tree. I only store the information of the gain for future branching like pseudo cost.


Added Growlith

I am sorry but growlithe is already present in the website so i wouldnt be able to add it. Please try and add a pokemon that's not in the wesbite already. Thank you.