Chapter 3 edits

Fewer than you might expect for so much text, but I do have a lot of notes:

weird to mention both AVX2 and AVX512 but not SVE and SVE2 imho

the ARM "ISA" topic is complex. i'd consider "AArch64" to be the
ISA, not Armv8-A (which i'd call an architecture). technically
AArch64 is an "execution environment", though. the reason i
bring this up is because SME was an ARM9 deal, whereas you're
talking about ARM8.

from the horse's mouth, though:
"This guide introduces the A64 instruction set, used in the 64-bit Armv8-A architecture, also known as AArch64."
so i guess Armv8-A works there.

i didn't like "the longer the pipeline, the more effective bypassing becomes."
i would change it to "the more stages bypassed...", since if the pipeline becomes
longer in the e.g. decoding area, bypassing isn't going to become any more effective.
but this seemed pedantic, so i left it alone, silently cursing.

in the WAR example, shouldn't the renaming be
R101 = R1
R103 = R0

i'm not following what you're doing here (i mean, i know how register
renaming works; i'm just not following your notation).

the WAW example is also weird. assuming the code is correct as written,
the first value written to R2 is a dead value; a good compiler ought not have
generated this code (it could of course have been handwritten).

i agree with not mentioning branch-delay slots; they would just complicate things
(and are rarely used these days)

poor itanium!

reservation stations were present in the original Tomasulo algorithm!
see Tomasulo 1954, "An Efficient Algorithm for Exploiting Multiple Arithmetic Units",
where they are discussed at length.

SIMD: technically you eliminate more than 3/4 of the instructions, because
you have fewer loop calculations

don't love the emphasis on pipeline width in SMT discussion. you can interleave
two processes on uniscalar SMT2, hiding memory delays etc. think of a barrel processor.

<IP_ADDRESS>: in addition to competing for memory bandwidth, prefetched data could
evict demand data from cache

regarding "64-bit" vs "64 bit": the difference is subtle. "64-bit" is correct when
it's used as an appositive. "64 bit" is correct when used as a pure adjective.
(you use "64 bit" correctly later in this passage). i'd just trust me on this.

3.8.3: removed "1.25 or 2MB" as this duplicates exactly a sentence from a
previous section (and isn't really relevant here)

3.8.4: likewise, the "there is a hardware page walker" duplicates an earlier sentence. removed.

You use "frontend" in the exercises, but "front-end" in other places. I have changed
them all to "frontend"/"backend".

weird to mention both AVX2 and AVX512 but not SVE and SVE2 IMHO

Which exact place you're talking about?

in the WAR example, shouldn't the renaming be
R101 = R1
R103 = R0

i'm not following what you're doing here (i mean, i know how register renaming works; i'm just not following your notation).

I will improve the explanation. I just gave the R0, R1, and R2 registers new names (R100, R101, etc.).

the WAW example is also weird. assuming the code is correct as written,
the first value written to R2 is a dead value; a good compiler ought not have
generated this code (it could of course have been handwritten).

Yes, I was thinking about it. And I guess I need to change it to the following:
R1 = R0 ADD 1
R2 = R1 ADD R3
R1 = R0 MUL 3   ; WAW and WAR

I was trying to make a minimal example, but the example I came up with is not a meaningful one.

reservation stations were present in the original Tomasulo algorithm!
see Tomasulo 1954, "An Efficient Algorithm for Exploiting Multiple Arithmetic Units",
where they are discussed at length.

Ok, good, I don't think there is anything I should change in the text. Do I?

SIMD: technically you eliminate more than 3/4 of the instructions, because
you have fewer loop calculations

Which exact place you're talking about?

don't love the emphasis on pipeline width in SMT discussion. you can interleave
two processes on uniscalar SMT2, hiding memory delays etc. think of a barrel processor.

Please elaborate.

<IP_ADDRESS>: in addition to competing for memory bandwidth, prefetched data could
evict demand data from cache

Please elaborate. I talk more about prefetching in Section 8.5 (I have a reference as well).

You use "frontend" in the exercises, but "front-end" in other places. I have changed
them all to "frontend"/"backend".

Yes, thanks.

Approved and ready to merge, but @dankamongmen, please reply to my comments above.

weird to mention both AVX2 and AVX512 but not SVE and SVE2 imho

this was in reference to 3.1's "These include enhanced vector processing instructions (e.g., Intel
AVX2, AVX512, ARM SVE, RISC-V “V” vector extension) and matrix/tensor instructions (Intel AMX, ARM
SME)." just seems odd to mention AVX2 and AVX512, but not SVE and SVE2 in this sentence. [shrug]

the ARM "ISA" topic is complex. i'd consider "AArch64" to be the
ISA, not Armv8-A (which i'd call an architecture). technically
AArch64 is an "execution environment", though. the reason i
bring this up is because SME was an ARM9 deal, whereas you're
talking about ARM8.

Refers to 3.1's "Intel x86-64, ARM v8 and RISC-V are examples of..."

from the horse's mouth, though:
"This guide introduces the A64 instruction set, used in the 64-bit Armv8-A architecture, also known as AArch64."

this is taken from the ARM Reference Manual

i didn't like "the longer the pipeline, the more effective bypassing becomes."
i would change it to "the more stages bypassed...", since if the pipeline becomes
longer in the e.g. decoding area, bypassing isn't going to become any more effective.
but this seemed pedantic, so i left it alone, silently cursing.

3.3 p30 "Bypassing helps to save a few cycles. The longer the pipeline, the more effective bypassing
becomes."

in the WAR example, shouldn't the renaming be
R101 = R1
R103 = R0

same page

the WAW example is also weird. assuming the code is correct as written,
the first value written to R2 is a dead value; a good compiler ought not have
generated this code (it could of course have been handwritten).

same page

reservation stations were present in the original Tomasulo algorithm!
see Tomasulo 1954, "An Efficient Algorithm for Exploiting Multiple Arithmetic Units",
where they are discussed at length.

3.3 p32 "Modern processors implement dynamic scheduling techniques that are derivatives of Tomasulo’s original algorithm and include the Reorder Buffer (ROB) and the Reservation Station (RS)." the way it's written makes it sound IMHO like ROB/RS came after toamsulo, but RS was very much in his design

SIMD: technically you eliminate more than 3/4 of the instructions, because  you have fewer loop calculations

3.4 p35 "This leads to issuing 4x fewer instructions and can potentially gain a 4x speedup over four scalar computations."
since you say "issue" , i assume you mean dynamic and not static instructions, in which case we probably get a small win from less loop overhead with SIMD.

don't love the emphasis on pipeline width in SMT discussion. you can interleave  two processes on uniscalar SMT2, hiding memory delays etc. think of a barrel processor.

s 3.5.2 p37 "An example of execution on a non-SMT and a 2-way SMT (SMT2) processor is shown in Figure 3.6. In both cases, the width of the processor pipeline is four, and each slot represents an opportunity to issue a new instruction."
first off, it's weird to say "pipeline width". i always hear length, with width referring to degree of superscalar. either way, i don't think pipeline properties are that fundamental to SMT. simply hiding latency due to loads -- essentially, exposing a second stream of instructions to the OOO engine, one unlikely to have dependencies on the first -- can be a big win.

<IP_ADDRESS>: in addition to competing for memory bandwidth, prefetched data could   evict demand data from cache

<IP_ADDRESS> "Prefetch techniques need to balance between demand and prefetch requests to guard against prefetch traffic slowing down demand traffic."
i'm just pointing out that it can have negative cache effects, too

regarding "64-bit" vs "64 bit": the difference is subtle. "64-bit" is correct when it's used as an appositive. "64 bit" is correct when used as a pure adjective. (you use "64 bit" correctly later in this passage). i'd just trust me on this.

i don't think either of us wants to think about hyphens anymore. no one knows this rule, and it's not like rules truly exist, so who cares where your hyphens are? i will stop sending this kind of correction and i suspect we'll both be happier.
but if you care, go look up "hyphen appositive"
but you probably don't

@dendibakh , as requested, context for notes ^^^^^

3.4 p35 "This leads to issuing 4x fewer instructions and can potentially gain a 4x speedup over four scalar computations."
since you say "issue" , i assume you mean dynamic and not static instructions, in which case we probably get a small win from less loop overhead with SIMD.

ignore this. your 4x didn't just apply to FLOPs, it applied to all dynamic instructions, and thus correctly includes the reductions in loop overhead. carry on!

weird to mention both AVX2 and AVX512 but not SVE and SVE2 IMHO

Well, I mention SVE right in that sentence. SVE2 is not mentioned, yes.

Tomasulo and RS

Ok, I will reword it.

SMT and pipeline width.

Yes, we use the term "pipeline width". We actually refer to allocation width as it is where the pipeline is usually the most narrow. Pipeline width has a very big impact on SMT. Imagine you have threads with IPC of 2, so you can execute 2 instructions every cycle in both. If you have a pipeline width = 2, then you have no bandwidth for the second thread since you already maxed out the throughput of your pipeline. If you double the width, you can fit two such threads in a single core and they will run as if they run on separate cores. Unfortunately, this idealistic scenario never happens in practice. But you could achieve ~70% on a carefully engineered benchmark and ~50% on production software if you're lucky. Don't quote me on those numbers though. :)

i don't think either of us wants to think about hyphens anymore. no one knows this rule, and it's not like rules truly exist, so who cares where your hyphens are? i will stop sending this kind of correction and i suspect we'll both be happier.

I'm not super picky about those small things. If you (as a native speaker) don't roll your eyes seeing this type of mistake, then I'm fine.


Specifying a License

Hi Philip,
thank you for the great code!
I need some adjustments however and would like to create a fork for that.
Could you please specify a license for it?
Thanks in advance,
Chris.

Hi Chris,
You're very welcome, I'm glad it's useful. I added MIT License file let me know if you've any issues with the code.
Philip


home button does not restore initial rotation

I would expect home button to not just set initial zoom and position, but also a rotation (specified in .degrees). As it turns out it does not. Is it by design?
(For context: I have .rotationIncrement set to 15 and use it to view scanned maps which have labels and notes in each and every orientation. To return to initial view to zoom in on a next part I have to press home and then multiple rotate button until it rotates correct side up. Then I zoom in on the area of interest and rotate it until all the labels are in required orientation.)

Good point! I think we just didn't think about it when rotation was implemented. It seems like a decent feature addition, though it might break apps that start off with a non-standard rotation. I suppose the best would be if hitting the home button returned the rotation to whatever was initially set via the viewer options.
If you're interested in implementing this feature, I can point you to the right part of the code.

Yes, thank you. I would appreciate any pointer you can give.

Great! You'll want to add a call to this.setRotation inside of Viewport.goHome:
https://github.com/openseadragon/openseadragon/blob/f097808c95ea11ed8ac9cd57044d98ce3da38914
/src/viewport.js#L269
I think it should happen before the fitBounds in that function, since the rotation may affect the fitBounds.
It should be based on the degrees value that was originally given to the viewport on construction, so you'll need to save that value in the constructor for later use.
Also, for efficiency, it would be good to check if the current degrees is different from the original degrees, and if they're the same, don't bother changing the rotation.


fix: prevent iframe

This PR prevent usage of the UI within an iframe, this is to avoid clickjacking.

What about using as Gnosis safe app? That is also inside an iframe AFAIK

Correct, Safe use iframe.

Hum, good point

Closing this for now

@samuveth we can check if parent frame come from Safe domain and prevent others iframe

Reply from discord @bonustrack

you can use this code to detect if your app is inside an iframe:
https://stackoverflow.com/questions/326069/how-to-identify-if-a-webpage-is-being-loaded-inside-an-iframe-or-directly-into-t
function inIframe () {
    try {
        return window.self !== window.top;
    } catch (e) {
        return true;
    }
}

see this other extra check in our isSafeApp function:
https://github.com/safe-global/safe-apps-sdk/blob/main/packages/safe-apps-web3modal/src/modal.ts#L45

I think we can just check if parent is coming from safe.global, no need to check connector

Chaitu suggested
if (window.top.location.host != "app.safe.global") {
    document.body.innerHTML = "Access Denied";
}

also we need to check for iframe level
let windowLen = window.frames.length;
let parentLen = parent.frames.length;

someone can iframe app.safe.global

also we need to check for iframe level
let windowLen = window.frames.length;
let parentLen = parent.frames.length;

someone can iframe app.safe.global

Interesting, like iframe in iframe?

Yep

@j0hnfl0w wassup with this?

@bonustrack  fixed it using document.location.ancestorOrigins, accept iframe if only parent is knownHost and it was the first one in ancestorOrigins + fallback to document.referrer.
Now it not only hides html with document.documentElement.style.display = 'none'; but also throws an Error to prevent Vue app to be created, to prevent loading spaces/providers/networks etc.

Sorry, I'm too carried away by the iframe lock that blocked it all.
Approved my PR by mistake, review was requested before i was assigned.


Question about how to select the best result

Thank you for your great work.
I am running this code, but I have a question. How can I get the best results? Since there are only train and test sets, what we need to do is to find the best delta from these 400 epochs? If you could answer my question, I would greatly appreciate it.

In logs.csv for each training run, the last column is best_delta_mtl, and the second-to-last column is the current epoch's delta_mtl. You can simply find the checkpoint corresponding to when best_delta_mtl == delta_mtl. Hope that helps!


UWP .NET Native compilation fails when nutc_driver.exe returns exit code -2147483645

The build in Debug works fine, but in Release (where .NET Native compilation happens), we get this error:

error : ILT0005: '[...]nutc_driver.exe @"[...]\MessagePack-CSharp\obj\TestUAP_NETNative\x86\Release\ilc\intermediate\MDIL\TestUAP_NETNative.rsp"' returned exit code -2147483645

What does this error code mean?
It's a UWP test project. I can reproduce it with one super-simple test defined, and a project reference to another project in the solution that targets netstandard2.0;netcoreapp2.1.
From https://github.com/neuecc/MessagePack-CSharp/pull/638

I notice that an otherwise trivial UWP test project that has a PackageReference to Nerdbank.Streams starts failing with this same exit code.
I have no idea what nerdbank.streams may be doing to trip up the .NET Native compiler.

Possibly related to #7372

For issues related to .NET Native for UWP, could you please send email to<EMAIL_ADDRESS>instead?


LUCENE-10460: Delegating DocIdSetIterator could be replaced to DocIdSetIterator#range(int minDoc, int maxDoc) in IndexSortSortedNumericDocValuesRangeQuery

While taking advantage of of index sort In IndexSortSortedNumericDocValuesRangeQuery, if MissingValue disabled, all Documents between a range of firstDoc and lastDoc must contain docValues. So In BoundedDocSetIdIterator#advance(int), the delegating DocIdSetIterator could be replaced to DocIdSetIterator#range(int minDoc, int maxDoc)?

Optimized by #736 , so this issue closed


Need a way to unbind sticky/scroll events

Need an event to remove the scroll listener. ie if you have a button on the screen that is sticky, and then it is removed, the scroll handler will throw errors not being able to find it:

The only thing being bound is the scroll event - unbinding this would make all stickies stop, not just the one that is removed from the dom.
Solution is to add checks - make sure that dom even exists before moving on.
510

wooord


Parts of quoted tweets randomly replaced with mentioned handles

I've mentioned it previously in https://github.com/foozmeat/moa/issues/107#issuecomment-484165128 but it's probably a different issue with similar symptoms...
https://toot.cafe/@aardrian/101942317704538362
https://twitter.com/aardrian/status/1118541790104231937
More recent example:
https://toot.cafe/@aardrian/103516075869620673
https://twitter.com/aardrian/status/1219262647243300864

The issue here is that I was expanding twitter handles after doing URL replacement instead of before. It should be fixed now.


improve usability of total statistic in graph legends

The total statistic doesn't seem to be particularly useful and worse most users seem to interpret it incorrectly. Currently, the total statistic is the sum of all datapoints shown for a given time series on the graph. Most users I have talked with assume it is the total number of events (assuming a counter) that occurred within the time frame of the chart.
Options:

Just remove total. This was done several years ago and it got re-added when someone complained. Though it is quite likely their interpretation of the value was wrong.
Change the value reported with total to try and match the more common user interpretation. This is possible for simple expressions using sum over counters as the aggregate. With something like max or avg it would be an estimate of the total number for a single item. However, if combined with non-counter data it wouldn't be meaningful. Neither make much sense with gauges.
Add support for some sort of legend stat control similar to the current :legend operator. It would be used to specify the stats format. We can then remote total by default and allow users to specify a total variant for counters. This could also help with requests to have some stats, but reduce the amount of vertical space taken up with the statistics. Complications:

Different statistics per line can make the legend rendering more complex. However it is likely needed for correctness as things like total don't really make sense for gauges.
It would be up to the user to make sure it made sense for the input line. One advantage of Option 2 if it could be done cleanly, is it would be more automatic based on the input data.

Option 3 seems good. The default could be based on the statistic tag, or the UI could interpret the statistic tag to set a reasonable value.  For consistent formatting, possibly it could use "N/A" for invalid lines instead of dropping the entry.

@svachalek any preferences for what the format specification would look like?

Sorry, didn't see the question earlier. Probably for readability, a list like
(,max,avg,count,),:stats
would work best.


Animated SlashScreen API Android 12 has inconsistent behaviour on backward Android OS

Implemented Animated FlashScreen using below guides

Flutter guide for Android S
Android Splash Screen API Guide
Migrate your existing splash screen implementation to Android 12 and higher

Issue

Animated flash screen API does work on Android 12
Animated flash screen API doesn't animate on Android 11, just shows the first image in Animation Icon list
Animated flash screen API doesn't animate on Android 6, just shows the first image in Animation Icon list & background color stays in the bottom navigation bar.

Animated flash screen API doesn't show icon on Android 5.1, just shows the background color &  it stays in bottom navigation bar.

Unresolved reference: setDecorFitsSystemWindows. (Splash screen still runs w/o below line)
WindowCompat.setDecorFitsSystemWindows(getWindow(), false)

Animated icon won't show up at all after launching through Android Studio, we have to kill the app & relaunch it.

Steps to Reproduce

Implement Animated Splash Screen using above mention guide.

build.gradle
android {
   compileSdkVersion 31
   ...
}
dependencies {
   ...
   implementation 'androidx.core:core-splashscreen:1.0.0-alpha01'
}

styles.xml
<style name="Theme.App.Starting" parent="Theme.SplashScreen">
   // Set the splash screen background, animated icon, and animation duration.
   <item<EMAIL_ADDRESS>
   // Use windowSplashScreenAnimatedIcon to add either a drawable or an
   // animated drawable. One of these is required.
   <item<EMAIL_ADDRESS>   <item name="windowSplashScreenAnimationDuration">200</item>  # Required for
                                                                # animated icons

   // Set the theme of the Activity that directly follows your splash screen.
   <item<EMAIL_ADDRESS># Required.
</style>

AndroidManifest.xml
<manifest>
   <application<EMAIL_ADDRESS>    <!-- or -->
        <activity<EMAIL_ADDRESS>
import android.os.Build
import android.os.Bundle
import androidx.core.view.WindowCompat
import io.flutter.embedding.android.FlutterActivity

class MainActivity : FlutterActivity() {
  override fun onCreate(savedInstanceState: Bundle?) {
    // Aligns the Flutter view vertically with the window.
    WindowCompat.setDecorFitsSystemWindows(getWindow(), false)

    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) {
      // Disable the Android splash screen fade out animation to avoid
      // a flicker before the similar frame is drawn in Flutter.
      splashScreen.setOnExitAnimationListener { splashScreenView -> splashScreenView.remove() }
    }

    super.onCreate(savedInstanceState)
  }
}

Hi @glintpursuit, thanks for filing the issue. Please provide the output of flutter doctor -v.
Thank you

hi @danagbemava-nc
`flutter doctor -v
[✓] Flutter (Channel stable, 2.5.3, on macOS 11.5 20G71 darwin-x64, locale en-IN)
• Flutter version 2.5.3 at /Users/tech9/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 18116933e7 (9 weeks ago), 2021-10-15 10:46:35 -0700
• Engine revision d3ea636dc5
• Dart version 2.14.4
[✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
• Android SDK at /Users/tech9/Library/Developer/Xamarin/android-sdk-macosx
• Platform android-32, build-tools 32.0.0
• ANDROID_HOME = /Users/tech9/Library/Developer/Xamarin/android-sdk-macosx
• Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 13.0, Build version 13A233
• CocoaPods version 1.10.1
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2020.3)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
[✓] VS Code (version 1.63.0)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.29.0
[✓] Connected device (1 available)
• Chrome (web) • chrome • web-javascript • Google Chrome 96.0.4664.93
! Error: My iPhone 6 is not connected. Xcode will continue when My iPhone 6 is connected. (code -13)
• No issues found!
`

Can you also share the logs of flutter run -v for the various versions of android?
Thank you

@danagbemava-nc
Please find attached log for 5.1 & 6.0
flutter run -v lollipop_5.1.txt
flutter run -v  6.0.txt
`

Can you also share the drawable files?

@danagbemava-nc
Please find attached images

Hi @glintpursuit, I do have one more request to make of you, can you confirm that the SplashScreen API itself is backwards-compatible on native android?
I can repro the no animation on API below 12, but I do not a device running android 5/6, atm, so I can't confirm that and I would also like to know whether or not this is an android issue or a flutter issue.
Thank you

@danagbemava-nc
Not sure on backward compatibility, but I believe there should be some way around it.
It could be Android one, I am also looking for solution.

It looks like the SplashScreen api itself isn't backwards compatible.
I created a small native android project and I could see that there's no exit animation played for the splash screen on android versions lower than 12. I have attached the sample I used below, can you confirm this?

videos

android 12
android 11

SplashTest.zip

@danagbemava-nc
Yes, Android 11 wont show animation.
But below Android 6, we wont get any icon render on splash screen.
Do we have any solution for handling it with different splash screen below Android 11.

@glintpursuit
I did a little bit of searching and this is a bug in the SplashScreen API, or rather, it hasn't been implemented yet with the version of the library you're using.
Release notes https://developer.android.com/jetpack/androidx/releases/core#core-splashscreen-1.0.0-alpha01.

@danagbemava-nc, so let's wait for API update ?
I am not sure how Gmail app is handling this, it has splash screen with animation.

so let's wait for API update ?

There's a new version out, https://developer.android.com/jetpack/androidx/releases/core#core_splashscreen_version_10_2.
I'm not entirely sure if that version has the changes that you want but since this is a core android library, any issues with it are beyond the scope of flutter.
It seems to be affecting native android devs too, see https://stackoverflow.com/questions/69812590/android-12-splash-screen-icon-not-displaying.
Due to the above reason, I'm going to have to close this issue, as it is beyond the scope of flutter.
Thank you


For example,
1. I jump to the definition of a function
2. then move cursor to the next line several times,
when I want to go back to the position where the function get called,  I have to Go back several times in the current implementation.
Since using Go back to go to previous line or next line doesn't make much sence in most situation,  can we ignore continuous movement, so the Go back can be more convenient, or at least provide a disable option.

/needsMoreInfo
Could you provide details about your setup as specified by issue template?
Do you see every cursor position before or these are places where cursor was still for some time?

Sorry for the incomplete information,  After I follow the guideline,  I figure out It's the vim extension I installed change the go back and go forward behavior,  VSC just work as I expected,  Sorry for write an issue before I do a complete check again, I will close the issue


Fixed https support

Fixed support for https by providing https scheme alongside domain when creating client.

Thanks for the contribution and welcome to the group @falling-springs
LGTM @ahuarte47 could you co-review approve this PR?

@lmangani Great, glad to help! FYI, I think the test failure during CI may be an intermittent issue with the httpbin site used in the SQL tests.  Looks like the server returned a 502: Bad Gateway error, which can't be parsed as JSON and so creates the error we see in the CI logs. It may be worth revising this test to use a different domain if this is a regular issue?
For now I think if you re-run that step it will likely pass

Hi, sorry for this late message, this MR was great and it is working, but why not including always the scheme part in the client_url?
May I suggest a super simple change maybe in other new PR?


add pgshrink chinese and english docs

closes: #ISSUE_Number

Change logs

Describe your change clearly, including what problem is being solved or what document is being added or updated.

Contributor's checklist
Here are some reminders before you submit your pull request:

Make sure that your Pull Request has a clear title and commit message. You can take the Git commit template as a reference.
Sign the Contributor License Agreement as prompted for your first-time contribution (One-time setup).
Learn the code contribution and doc contribution guides for better collaboration.
Make sure that your changes deployment preview is successful.
List your communications in the GitHub Issues or Discussions (if has or needed).
Feel free to ask for the @cloudberrydb/doc team or other people to help review and approve.

Hi @IdaLee666, any progress on this PR?

For the sidebars.ts, you need to add the new items here, and the index page. Try to update again, thanks. @IdaLee666


Better readme, esp for Windows

I'm receiving the following error trying to scrapy crawl toscrape-css on Windows 10:

Python 3.6.4
This seems to be a matter of poor documentation rather than a real issue, although I may be mistaken.
I did pip install virtualenv then pip install scrapy then tried to run scrapy crawl toscrape-css. What am I missing?

With all due respect, if you feel the documentation is poor your more than welcome to contribute. This is not a commercial project of course!
Your issue is not scrapy but your local environment. As per the error - No Module named 'win32api'. A google search for this returns the answer your looking for:
https://stackoverflow.com/questions/3580855/where-to-find-the-win32api-module-for-python

Had same problem. Although it's more python thing than scrapy.
As Ciwidey Developer mentioned here https://stackoverflow.com/questions/21343774/importerror-no-module-named-win32api
just run pip install pypiwin32


Add a transformation rule to use synopses

In our PoC version, synopsis tables have not been used automatically.
We need to implement a transformation rule that substitute target base tables with their synopsis tables in SELECT APPROXIMATE statements.

Initial implementation is merged into main branch.
Simple SELECT APPROXIMATE aggr_func FROM ~ WHERE ~ queries are working.
There are still a few issues that need to be fixed including:

Handle the cases with multiple synopsis tables
Check select column lists

I think it would be better to discuss the remaining work as new issues.
I will close this issue.


TORQUE-684: Add support for startup command-options on upstart:install

Created a torquebox.conf.erb that is used if server_opts is set. Added a spec for the templating method.

I left torquebox.conf in place (seems useful)
I used server_opts (case insensitive), but torquebox_opts might be better as Ben suggested in another disscussion.
There's no spec for the copy_init_script method, it would need fakefs or something.

let me know if I should make some changes.

This one was actually merged as part of the TORQUE-681 pull request, so no need to merge this individually. Thanks!


Shohag Hossain

https://github.com/S00350/Sho-Hacker-/issues/1

Tanks for your awesome work.
Do you know how to fix the 'Nan' loss in training and the results is black in inference.We do not encounter the nan loss during training. Have you revised the code or the framework?

We do not encounter the nan loss during training. Have you revised the code or the framework?

- [ ] ~~Tanks for your awesome work.

Do you know how to fix the 'Nan' loss in training and the results is black in inference.~~


Control panel for relations

Inspect relations
Edit relations
Add relations to arbitrary targets
Batch edit relations
Second tab with actions to fix broken relations.

TODO

[x] Inspect relations
[x] Modify relations: Add relation. Delete relation.
[x] Implementation of service in plone.restapi ( ->  https://github.com/plone/plone.restapi/pull/1602)
[x] Stats: how many relation elements per relation
[x] Actions to fix broken relations (two actions: "rebuild" and "regenerate intids and rebuild relations")
[x] many relations: fetching batch per batch. No. Search by source and target has to be narrowed down by UI user.
[x] Filter by target: title, path
[x] Filter by source: title, path
[x] Add potential targets to add more relations
[x] Add potential sources to add more relations
[x] Bug fix in upcoming plone.api 2.0.3 "Create relation only if there is no existing one" https://github.com/plone/plone.api/pull/507

Inspect and modify relations

Fix relations
Nice to have

[ ] ? Filter by target: content type, review state, …

I like the ability to filter by source and target.
But I don't really understand how the output in the screenshot should work. When relations always point from one content item to another content what is then "Chassis" etc?
I would prefer to duplicate the same UI as it is used in classic with links to source and to target. Or change the classic UI as well if there is better proposal. So far in classic inspecting looks like this:

A binary relation is a subset of the cartesian product of source set and target set. This UI provides this cartesian product as a matrix with checkboxes with event handlers to add or delete a relation.
The event handler adds or delete a relation element and gives a confirmation with a toast.
Apart from this, batch editing is possible via the checkbox row on top: check 'Chassis' and all displayed sources (filter by search field or filter by filter on the right side) get a relation to 'Chassis'.
The example above shows that 'Light system' has relation 'comprisescomponentpart' to ['Chassis', 'Electronics','Navigation System']
'Navigation System' has one relation of type  'comprisescomponentpart': the one to 'Electronics'

does this PR add an action to get the relations of a given object? That would be useful too.

Yes I mean exactly that.
Nowadays when we have a relation field in an object, to be able to get the related objects, we index the UID of the objects and then query the catalog to get that information. If an action is available, we can use that action that under the hood calls this endpoint and this way getting the related items could be easier.

Oh my, now I get it, you mean a Volto action to fetch the relations!
@pbauer started working on endpoints for relations in general and the relations controlpanel.
In this PR I provide (will provide) Volto actions for relations in general and the relations control panel, which will attack these endpoints. So these actions can be taken for whatever you want to do with relations in Volto. How the actions will look like (and are already drafted here) with parameters relation name/type, backrelation, etc can be seen in Philips elaborated documentation for the future endpoints on the backend side:

@ksuess @pbauer This PR needs some love :)

I am prepared. Now I need the plone.restapi endpoint please, @pbauer.
https://github.com/plone/plone.restapi/issues/1432#issuecomment-1279761099
No endpoint on context, but one single endpoint /@relations on portal root.
@relations deals with the source/target/relation parameters.

Did you know that you can manage your relations in Volto? Check it out!
^ @nileshgulia1 @avoinea @tiberiuichim @pnicolli @sneridagh @fredvd @giuliaghisini @tisto @claudiaifrim @JeffersonBledsoe @pbauer @spereverde

UI recomendations are turned into code. Tests are green. Let's review!

@ksuess I am currently writing the official roadmap for Plone 6.x. I am adding a link to the documentation for every PLIP. Do we have any kind of documentation for the relations control panel?
I'd also like to give people proper credit. Did anyone help you with this or did you work on this on your own?

@ksuess @tisto I think this is the User Manual for it. Finding links and references to the current page.
There's also developer docs:

Link Integrity
Relations
Relations
plone.api.relation

I hope that captured all of them. This was a huge effort!

@ksuess I am currently writing the official roadmap for Plone 6.x. I am adding a link to the documentation for every PLIP. Do we have any kind of documentation for the relations control panel?

No, control panels are not documented.
The relations control panel has a superb user experience  ;-) and is therefore self-explaining.

I'd also like to give people proper credit. Did anyone help you with this or did you work on this on your own?

The relations control panel is my work.


feat: eslint standard with trailing commas

yes we pass the lint currently, but i missing the babel-eslint to make it work with static property, but as the current code is not using that, it already pass.
and yes, I also missing the npm script there, I'll try to add the lint task and make it run before build

That'd be great, thanks!

the react/prop-types rule is set to warn, is it better to turn that off ?

I'd say so.


Finding the way to avatar change is harder now

The link to change avatar does not appear in home toolbars anymore, so it is harder to find it now

It does appear in profile toolbar, when you are supposed to go if you want to change some info about you. Changing avatar is not an everyday activity, so I can't see the need of having it always accessible.
I can make the little home avatar like the profile one (in terms of having a hover effect with edit option). Do you like this option? Or do you prefer going back to the great avatar?


Conda command-T keyboard shortcut interferes, is not settable

Environment data

VS Code version: 1.38.0 Commit: 3db7e09
OS and version: MacOS 10.14.6 (18G87)
Python version (& distribution if applicable, e.g. Anaconda): Python 3.6.0
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): XXX
Jedi

Expected behaviour
The keyboard shortcut command-t (guessing this is ctrl-t on PC) opens VS Code's native Find Symbol menu.
Actual behaviour
When the python extension is running, command-t short-circuits Find Symbol and runs a Generate Tags command, visible in the output window.
This disrupts normal VS Code workflow and often leads me to disable the python extension.
Steps to reproduce:

start the extension
place cursor in an editor
press command-t (on Mac, probably ctrl-t on PC)

Logs

Hi @mosesoak 👋 Thank you for reaching out.
Closing as the python extension doesn't have any ctags-related keyboard shortcuts (Command Palette > Preferences: Open Keyboard Shortcuts, or cmd+k cmd+s). Please check the other extensions you have installed in your environment, or modify the keyboard shortcut for ctags.

@kimadeline My VS Code installation is definitely triggering this extension's "Python: Build Workspace Symbols" command when I press command-T, even though it is not set in keyboard bindings.
My bindings are normal:

When I disable this extension, the conflict goes away, and when I reenable it, it reappears.
The problem appears to be with the extension but could be my VS Code installation. I could try a clean install, if you think there is really no chance that the extension is causing this issue, despite the consistency of the behavior?

Sadly I could not reproduce your issue locally with the following environment:

OS: macOS Mojave 10.14.6
VS Code version: 1.38.0
Python extension version: 2019.9.34911

There a a couple of things we can try here:

I can see you're using 2019.9.34474, can you try updating to the latest version of the extension?
Do you have any other extensions installed?
What is the content of your keyboard shortcuts screen when you type cmd t in the search bar?

Do you have any ctags-specific settings?

@mosesoak Thanks for reporting this issue.
I'm closing this as this isn't an extension issue, but an issue at your end.
Please remove the key binding you have added at your end.

This happened to me too. Funny thing is that disabling the extension resolves the issue and when I enable it again, the issue no longer appears.

Extension version: 2019.9.34911
VS Code version: Code 1.38.0 (3db7e09f3b61f915d03bbfa58e258d6eee843f35, 2019-09-03T21:47:00.464Z)
OS version: Darwin x64 18.7.0

Because we have not heard back with the information we requested, we are closing this issue for now. If you are able to provide the info later on then we will be happy to re-open this issue to pick up where we left off.

@kimadeline sorry for the delayed response - turning off python.workspaceSymbols.enabled fixes the keyboard binding!
Will that reduce the effectiveness of whatever IntelliSense this extension uses?

It shouldn't, and if it does you are welcome to comment on this issue so that we can reopen it, or you can also create a new issue.


First pass - intro & shortcuts

Is this roughly what you were thinking @Reezaali?
PS - I could not push a new branch to this repo, so I just put it on mine.

Docs Build status updates of commit cce1ae9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/progressive-web-apps-chromium/webappmanifests.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 3179f34:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/progressive-web-apps-chromium/webappmanifests.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 0d161e2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/progressive-web-apps-chromium/webappmanifests.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Jason asked me to handle the other sections… I’ll be working on that today & Monday.

Docs Build status updates of commit 7700e6d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/progressive-web-apps-chromium/webappmanifests.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit efa81be:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/progressive-web-apps-chromium/webappmanifests.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Release v5.1.0

Pull Request Test Coverage Report for Build 409

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.571%

Totals

Change from base Build 407:
0.0%

Covered Lines:
204

Relevant Lines:
217

💛  - Coveralls

@evilebottnawi Isn't the release backlog sufficient?
https://github.com/evilebottnawi/favicons/releases

@brunocodutra someone don't have access to release github page. It is good practice use CHANGLOG and release pages :+1:

@brunocodutra feel free to merge and do this in next PR :+1:


Translation not working - always returns empty string as response

Hello,
Google must have changed something.
In [1]: import textblob

In [2]: blob = textblob.TextBlob("bonjour")

In [3]: blob.translate()
> /home/alopez/.virtualenvs/proj/lib/python2.7/site-packages/textblob/translate.py(42)translate()
     41         import ipdb; ipdb.set_trace()
---> 42         json5 = self._get_json5(self.url, host=host, type_=type_, data=data)
     43         if self._translation_successful(json5):

ipdb> s
--Call--
> /home/alopez/.virtualenvs/proj/lib/python2.7/site-packages/textblob/translate.py(84)_get_json5()
     83
---> 84     def _get_json5(self, url, host=None, type_=None, data=None):
     85         encoded_data = urlencode(data).encode('utf-8')

ipdb> n
> /home/alopez/.virtualenvs/proj/lib/python2.7/site-packages/textblob/translate.py(85)_get_json5()
     84     def _get_json5(self, url, host=None, type_=None, data=None):
---> 85         encoded_data = urlencode(data).encode('utf-8')
     86         req = request.Request(url=url, headers=self.headers, data=encoded_data)

ipdb>
> /home/alopez/.virtualenvs/proj/lib/python2.7/site-packages/textblob/translate.py(86)_get_json5()
     85         encoded_data = urlencode(data).encode('utf-8')
---> 86         req = request.Request(url=url, headers=self.headers, data=encoded_data)
     87         if host or type_:

ipdb>
> /home/alopez/.virtualenvs/proj/lib/python2.7/site-packages/textblob/translate.py(87)_get_json5()
     86         req = request.Request(url=url, headers=self.headers, data=encoded_data)
---> 87         if host or type_:
     88             req.set_proxy(host=host, type=type_)

ipdb>
> /home/alopez/.virtualenvs/proj/lib/python2.7/site-packages/textblob/translate.py(89)_get_json5()
     88             req.set_proxy(host=host, type=type_)
---> 89         resp = request.urlopen(req)
     90         content = resp.read()

ipdb>
> /home/alopez/.virtualenvs/proj/lib/python2.7/site-packages/textblob/translate.py(90)_get_json5()
     89         resp = request.urlopen(req)
---> 90         content = resp.read()
     91         return content.decode('utf-8')

ipdb>
> /home/alopez/.virtualenvs/proj/lib/python2.7/site-packages/textblob/translate.py(91)_get_json5()
     90         content = resp.read()
---> 91         return content.decode('utf-8')
     92

ipdb> content
'""'
ipdb> resp.code
200
ipdb> resp.msg
'OK'

I will post an update if I find out something...

@jschnurr Hi. I see you did the change to the json format. May I ask, where/how did you find out about the client=p parameter and its options?

I don't recall.  I do know that the documentation was limited / non-existent.

Google did indeed change the format. The request still works, but the response body is no longer a json encoded object, but a simple string. I was investigating the same problem, see http://stackoverflow.com/questions/35420602/python-textblob-not-translating/35421116#35421116.

They added a new code parameter to validate requests from their apps exclusively.
There's more info and a solution in https://github.com/soimort/translate-shell/issues/94.
I will have a PR ready soon.

I provided PR #118 last night, but it doesn't deal with this extra parameter.

Yeah. We've been working in the same :(
Sorry, I would have merged your PR into mine if I didn't have the work already done.

The solutions are similar.  It seems there are two factors that can cause "empty string" and/or 403 results from the Google Translate API:

Headers.  Once I added Connection & Accept headers, I started getting results back.

    headers = {'Connection': 'keep-alive',
               'Accept': '*/*',
               'User-Agent': ('Mozilla/5.0 (Macintosh; Intel Mac OS X 10_6_8) '
                              'AppleWebKit/535.19 (KHTML, like Gecko) Chrome/18'
                              '.0.1025.168 Safari/535.19')

tk parameter.  Your solution doesn't have the headers, but the addition of the tk parameter appears to have the same effect.

Perhaps we should go with a 'belt and suspenders' approach here, and merge them together.
What do you think?

It can't hurt I suppose. And I see in the inspector that Google is using them so why not.
Already added. Thanks @jschnurr


Remove default arguments

I dont know why mypy add these command line arguments, and I cant remove them:
c:\Users\myname\.virtualenvs\XXX\Scripts\python.exe -m mypy --no-color-output --no-error-summary --show-absolute-path --show-column-numbers --show-error-codes --no-pretty --config-file=f:\Projects/pyproject.toml --show-error-end

I only add --config-file in settings.json:
"mypy-type-checker.args": [
    "--config-file=${workspaceFolder}/pyproject.toml"
]

Windows: 10 21H2
VSCode: 1.84.0
Mypy Type Checker: v2023.6.0

This is by design. Those CLI arguments are needed by the extension to work. We need to parse the output to show them in the problems view. This output is entirely consumed by the extension, those arguments to make it consistent and easier to parse the output.
If you want to run mypy as needed, you can set-up tasks using task.json, and trigger them as needed.

@karthiknadig Got it!


Add Governance documentation

Purpose

Enhance the Python Starterkit with recently approved Governance documentation.
Modify Contributing documentation with latest updates.

Proposed Changes

Add GOVERNANCE.md
Update PULL_REQUEST_TEMPLATE.md, CONTRIBUTING.md and README.md.

Issues

NASA-AMMOS/slim#55 (issue) and NASA-AMMOS/slim#94 (PR)

Testing

Documentation does not require testing.

Note that the CHANGELOG.md modifications are just along for the ride. They are an example for other projects, so not updated for this sample project.


Auto-import and syntax checking not working

Should it be possible for auto-import, code completion, syntax checking to work?
Doesn't work for me with Scala or Groovy...

Code completion and syntax checking should work. This is assuming that:

it's java based IDE (IntelliJ IDEA or Android Studio)
current project has JDK configured
to see IJ and LivePlugin classes, in Plugins toolwindow click Settings -> Add IDEA/LivePlugin jars to project

I'm not sure what you mean by "syntax checking" though. If you press ctrl+alt+shift+H in editor with plugin, what is the "Highlighting level" it shows?
There is a separate problem with auto-import which doesn't work in non-project files since some change in IJ. I'll try to re-enable it for LivePlugin files.
Thank you for reporting this. Except for fixing problems with it, I could probably add some hints to plugin editor.


[QUERY] For application insights sdk, is there any TokenCredential implementation for AppId and API Key

Query/Question
For application insights rest API calls, we do not need clientId, secret, tenantId etc, as given in https://dev.applicationinsights.io/apiexplorer/metrics. Do we have some TokenCredential implementation which can authenticate to AppInsights with only AppId and API Key.
Why is this not a Bug or a feature Request?
I'm not yet sure, if such implementation is already present or not.
Setup (please complete the following information if applicable):

OS: [e.g. iOS]
IDE: [e.g. IntelliJ]
Library/Libraries: com.azure.resourcemanager:azure-resourcemanager-applicationinsights:1.0.0-beta.1

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[x] Query Added
[x] Setup information Added

@weidongxu-microsoft could you please help reroute.

@latikag
This com.azure.resourcemanager:azure-resourcemanager-applicationinsights package is for managing the application insights resource (e.g. create it or delete it), not querying data. Mostly all request will be on path e.g. /subscriptions/{subscriptionId}/.., not the /v1/apps//metrics/.. in your page.
What you are seeing on the page seems on this spec https://github.com/Azure/azure-rest-api-specs/blob/main/specification/applicationinsights/data-plane/Microsoft.Insights/preview/v1/AppInsights.json
This is data-plane lib, however it seems not on our repo. @pallavit Do you know if we had applicationinsights data-plane SDK?


support postgresql

Ⅰ. Describe what this PR did
support PostgreSQL
Ⅱ. Does this pull request fix one issue?
#1279 #1170 #1641 #1972
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #1987 into postgresql will decrease coverage by <.01%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             postgresql    #1987      +/-   ##
================================================
- Coverage         55.05%   55.04%   -0.01%
  Complexity         2495     2495
================================================
  Files               445      445
  Lines             14926    14926
  Branches           1773     1773
================================================
- Hits               8217     8216       -1
- Misses             5978     5979       +1
  Partials            731      731

Impacted Files
Coverage Δ
Complexity Δ

...main/java/io/seata/core/store/db/LogStoreSqls.java
15.38% <ø> (ø)
10 <0> (ø)
:arrow_down:

...server/store/file/FileTransactionStoreManager.java
57.14% <0%> (-0.32%)
30% <0%> (+1%)


Type for Merge<T, U> overwrites requried props with unrequired

If I have a type Person and try to merge in a Partial<Person>, the output type is not Person as logically would follow, but Partial<Person> because all the optional properties overwrite the required ones, causing an error like this:
Type 'Merge<Person, Partial<Person>>' is not assignable to type 'Person'.
Types of property 'name' are incompatible.
Type 'string | undefined' is not assignable to type 'string'.
Type 'undefined' is not assignable to type 'string'.

The optional property in TS is allowed to assign undefined, though it looks strange in your case, but it did has the possibility of overwriting the required property with undefined.
interface Person {
  name: string;
}

const person: Partial<Person> = { name: undefined }; // valid

Oh, of course, thanks for clearing that up

I sympathize with the intent here, and recall there was an issue over at TypeScript about this behavior... I can't find it atm though. For the time being, might a manual cast to Person help address the issue for you @ahstro?

That is what I resolved to doing, thanks @tycho01 :)


Remove fntlnz from everywhere

Hey all,
I've been thinking about this for a very long time and came to a conclusion that it's time
for me to focus on other things and make room for new people here and for other things in my life.
I don't know for what I'll be remembered in this project, if for the features or for the bugs but
I'm grateful for having had the opportunity to work on Falco, especially thanks to @leodido and @ldegio .
My words of gratefulness go also to @kris-nova , to @mstemm  and to @Kaizhe
I'll follow with a PR to remove myself from all the repos.

Falco https://github.com/falcosecurity/falco/pull/2123
charts https://github.com/falcosecurity/charts/pull/363
community https://github.com/falcosecurity/community/pull/149
evolution https://github.com/falcosecurity/evolution/pull/153
falcoctl https://github.com/falcosecurity/falcoctl/pull/112
libs https://github.com/falcosecurity/libs/pull/471
go plugin sdk https://github.com/falcosecurity/plugin-sdk-go/pull/61
test infra https://github.com/falcosecurity/test-infra/pull/761
client go https://github.com/falcosecurity/client-go/pull/58
driverkit https://github.com/falcosecurity/driverkit/pull/new/remove-fntlnz
pdig https://github.com/falcosecurity/pdig/pull/28
plugins https://github.com/falcosecurity/plugins/pull/130
client-rs https://github.com/falcosecurity/client-rs/pull/18
event generator https://github.com/falcosecurity/event-generator/pull/74
falco website https://github.com/falcosecurity/falco-website/pull/646
kilt https://github.com/falcosecurity/kilt/pull/53
plugin-sdk-cpp https://github.com/falcosecurity/plugin-sdk-cpp/pull/7
template https://github.com/falcosecurity/template-repository/pull/3

I'll remove myself from the organization as well.
It was a good journey, ciao!
Ad maiora

Hi @fntlnz, It's sad to see you go. I didn't have the pleasure to work with you, but I came across your name in many parts of the codebase. Your work speaks by itself, thank you for all you did for the community.
As for next steps of your decision, the DCO checks are failing in all your PR. Would you please proceed and sign-off your commits?

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle rotten

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close

@poiana: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Use Linux' O_TMPFILE for tmpfiles

https://github.com/untitaker/rust-atomicwrites/issues/2

Unsure how to call linkat in Python.

https://docs.python.org/3/library/os.html#os.O_TMPFILE

Something like this seems to work since Python 3.4:
import os
fd = os.open('.', os.O_TMPFILE | os.O_RDWR)
path = '/proc/self/fd/{0}'.format(fd)
os.link(path, 'spam', src_dir_fd=0, follow_symlinks=True)

@jwilk That doesn't seem particularly performant or elegant though. It seems that there is a package on PyPI that provides bindings for this call, however, that would be quite a microdependency.

AFAICT NamedTemporaryFile already set this flag

I think you meant (unnamed) TemporaryFile, which indeed tries to use O_TMPFILE since Python 3.5:
https://bugs.python.org/issue21515


Result font size

Is it possible to change the font size in the bubble pop up?  I am getting tiiiiny fonts on my display and my eyes are having a difficult time with it.

You can edit your stylesheet and add something like that:
.bubble-output-container {
  font-size: 24px;
}

That does it.  Thanks for the prompt reply, this is exactly what I had in mind.  I will close this now.

I found that the following code, allows me to change the text size in 2017.
.hydrogen.output-bubble .bubble-result-container code {
    font-size: 14px;
}

@mackdata we have a style customization page started in our docs. Would love a PR if you are interested!


Added a dialog that pops up when admin wants to close an issue or terminate voting

This should fix issue #338. It is now harder to accidentally close an issue before it should be closed or end voting before voting should be ended.

I think the modal for terminating voting on an issue is unnecessary.
Another way to do it is to click the button once and then toggling the button to something else asking "You sure?", which prompts you to click it again. That way you have to click twice, but not opening a modal, finding the YES button and then clicking it.
Same goes for closing an issue (but not deleting -- there I think the modal is fair).
Just my thoughts.
Tbh these thoughts should probably be on #338 but they aren't. /shrug

I kind of agree on the part about changing the button for a second click rather than displaying a modal.
But I'm also a bit unsure if we'll get it done in time for genfors on Monday if we decide to implement it that way.

If I would be the admin of the system I'd prefer it the way it is today, and rather take care when administering, rather than having to click twice as many clicks.
But I'm not, sooo 😅

Since these actions can't be canceled (at least I think so?) it makes sense to check that it was an intended action.
IMO there's no point making it easier to click the accept button as that just removes the reason to add a "did you really mean to do this?" button.

Personally, I don't think it's a big inconvenience and I think it's worth it as a safety guard to avoid any awkward situations during the voting. I'll be merging this.


test_operator.test_deformable_psroipooling has fixed seed that can mask flakiness

The unit test in title have been using fixed seed to mask flakiness. Suggested action:

Evaluate whether the test is flaky without fixed seed. If not, remove seed. Else move to 2
If test is flaky, determine whether it's an actual uncaught edge case. If so, fix the operator. Else move to 3
If numerical instability is inevitable, adjust tolerance level appropriately.

@marcoabreu Can we re-open the issue?  This test seems to have regressed http://jenkins.mxnet-ci-dev.amazon-ml.com/blue/organizations/jenkins/incubator-mxnet/detail/master/1114/pipeline/

@Oh233 Did you get a chance to look into the fix as the PR #12178 didn't help fixing the issue?


SpringCloudCommandRouter requires local @CommandHandler to function properly

Hey there!
I noticed that if a service wants to use DistributedCommandBus with SpringCloudCommandRouter it's not really possible to do so. SpringCloudCommandRouter will throw a
new IllegalStateException("There should be no scenario where the local member does not exist."
when there haven't been any local member (which would happen when subscribing for a local @CommandHandler?).
It is a perfectly valid scenario that a service would like to dispatch a method to another one, whilst it itself doesn't have any command handlers.
There's no obvious workaround currently, as things are declared as private, so can't really override stuff without copy-pasting the whole class.
Thanks for your help!

Hi @travikk,
you did hit a little issue there, it seems. The problem is that a local instance is only configured once the loadFactor and/or CommandMessageFilter for the local node is registered. The default command message filter is a DenyAll, which basically means it doesn't accept any commands. Since that's the default, no changes are made.
While we'll fix this, as a workaround, you could configure an explicit loadFactor on the DistributedCommandBus to trigger this registration. The loadFactor may be 0.


Customize hero card,Like skyscanner or hipmunk flights results

Need hero card like skyscanner or hipmunk flights results.....
Attached is screenshot marked in Green I need....

Can you generate that green region as an image?  Does the region need to have clickable hot spots?

So you are saying that we need to generate the images and upload them server,give that url to hero card...is that right?
hot spots not required...

@ravipulluri yes, or dynamically create them in the web service behind the ContentUrl you send as an attachment.


Tweak docs about PersistentVolume phase

This follows PR https://github.com/kubernetes/website/pull/42008

Do we want to try and merge this PR before the code freeze which starts on Monday?

/lgtm

/lgtm


whether does "fit_generator" accept multi input generator like "fit"?

from http://keras.io/getting-started/functional-api-guide/#multi-input-and-multi-output-models,
we can see the we can use multi input and multi output by "fit".
but when the data size is huge,it's not practical to load all data into memory and use "fit" method to start training.
so I think up a idea about "fit_generator",but from keras's document,"fit_generator" seems don't accept the generator that generates multi input(in this case,it may return  a dict).the "fit_generator" only accepts the generator that returns a tuple which can only descibe single one input.
Does there exist any solution to solve the problem,or I have to hack the core to complete  my demand？

You may return a tuple of lists for multi input/output, like:
yield [X1, X2], [y1, y2]

did you able to manege this thing ? I am having similar problem ...


User can add a system label but can't delete it

Version - v1.0.1
Steps to Reproduce:

Create a label on a host and name the key io.rancher.host.test1 with any value
Try to delete label

Results: Can't delete
Expected: Shouldn't I be able to delete it since I added it?

Works for me, I think this was fixed a while ago

Version - master 6/16
Verified fixed


Crashes after building in Xcode 11.2

Goals
Don't crash
Expected Results
Don't crash
Actual Results
Crashed: com.apple.main-thread
0  libsystem_kernel.dylib         0x1c0664ef4 __pthread_kill + 8
1  libsystem_pthread.dylib        0x1c0585d1c pthread_kill + 196
2  libsystem_c.dylib              0x1c0515a54 abort + 104
3  libswiftCore.dylib             0x1ce03c9e4 swift::TargetExistentialTypeMetadataswift::InProcess::projectValue(swift::OpaqueValue const*) const + 14
4  libswiftCore.dylib             0x1ce03e574 swift_getWitnessTable + 2128
5  HashPhotos                     0x100c700e0 type metadata accessor for List ()
6  HashPhotos                     0x100c6bbac HLAsset.init() ()
7  HashPhotos                     0x100c6bc24 @objc HLAsset.init() ()
Code Sample
When initializing realm, app crashes
final class HLAsset: Object {
  @objc dynamic var identifier: String = ""
  // other codes

  let tags = List<HLTag>() // <= this line caused a crash
}

Version of Realm and Tooling

Realm framework version: ?
3.20.0
Xcode version: ?
11.2
iOS/OSX version: ?
iOS 13
Dependency manager + version: ?
SPM

Try disabling dead code stripping on your app’s project: DEAD_CODE_STRIPPING = NO

@ydnar Thanks! It's working.
But it was ok until Xcode 11.1 without setting DEAD_CODE_STRIPPING=NO.
Why metadata for List() is not included only when building with iOS 13.2 SDK although List is not  dead code?

There’s a bug in Xcode 11.2 with how it links SPM libraries. Generic superclass symbols are dropped, leading to the crash.
https://bugs.swift.org/plugins/servlet/mobile#issue/SR-11564

@ydnar Thanks for the explanation.


dirPagination: Pagination control is broken when using Multiple Pagination with Asynchronous Data

I had a web app working fine with asynchronous data, but when I add pagination-id to work with multiple pagination instances the pagination controls stop working.
It seems to be a issue with on-page-change, which is no longer triggered.
Can you show show me an example using Multiple Pagination with Asynchronous Data?

Sorry, I saw that'is no longer maintained.


menu option for unit conversion

Add a menu option for unit conversion.
For instance, if the monetary unit is uatom, automatically convert to atom.

Can we please do this. The current way is dangerous and useless.

This and many other improvements are coming with v2.14.0


Source Controls error everytime i deploy the App Template

Hello Team,
I am deploying company communicator for a couple of customers and all return with the same error: Source Control Conflict. It says the deployment failed with a conflict whenever it reaches the source controls creation. Can you please support on this as it seems to be the case for 3 of my customers already

@rhajj19 Are you still facing this issue? Can you check this link.

@rhajj19 Are you still facing this issue? Can you check this link.

@priyank29  i have tried but still gives an error

@priyank29  i have tried but still gives an error

Hi everyone,
@rhajj19 did you solve your problem?
Im facing the same issue, tried installing in different subscriptions/directories and still receiving the same error.
And always in the same azure function...
Resource = *-prep-function/web
Type = Microsoft.Web/sites/sourcecontrols
Status = Conflict
Status Message
{
"status": "Failed",
"error": {
"code": "ResourceDeploymentFailure",
"message": "The resource operation completed with terminal provisioning state 'Failed'."
}
}
After following the workaround, as @priyank29 suggested, Im still having some issues in this function...
For example, the most recent:
[Error] Executed 'SyncGroupMembersActivity' (Failed, Id=66b646e8-593b-475c-8d73-47e345d6d024, Duration=19ms)System.ArgumentNullException : Value cannot be null. (Parameter 'clientSecret')
I followed all steps in the deployment guide and double checked every client secret.
Thank you guys in advance!

Hello @rhajj19, @matheuschulz,
The issue related to Source Control Conflict it should get resolved after syncing it as @priyank29 mentioned. You can try upgrading app service plan just for sync and try.
Also while doing sync please stop all the service and functions then sync it. It helps many user to solve this problem.
Let us know which version you are using and if issue is still there.
Thanks


Issue 42822: Merging, alternative keyed, detailed logging ETLs fail on resolving PK

Rationale
Improvements to how we do detailed audit logging broke an ETL scenario where we're merging based on a column that's not the target table's PK
Related Pull Requests

https://github.com/LabKey/dataintegration/pull/99

Changes

Propagate alternateKeys early enough that the DataIteratorContext can be configured properly for the loadRows() call
Use alternateKeys for finding rows in ExistingRecordDataIterator
Leverage QueryUpdateService setup for DataIteratorContext in more places
Use loadRows() for merge ETLs instead of mergeRows()

Awesome, so looks like we should be good to go with auditing merges with alternate keys again?  Without custom QUS.
Looks good to me but I'll let Matt review since it's his recent work.

@labkey-martyp yes. I only tested the TNPRC scenario that broke, but I'm optimistic it will fix others as well.


Should jjohannes/missing-metadata-guava be merged here?

Looks like https://github.com/jjohannes/missing-metadata-guava is related, and the name of java-ecosystem-capabilities sounds good for an umbrella project.

Thanks for the feedback! Will give this give this some thoughts (also related to #1).

I think I would like to do this for a potential .1.0.

missing-metadata-guava covers two aspects compared to the other rules in this plugin:

Capabilities around Guava (fit in here well)
Add additional variant information (android vs standard-jvm)

The first fits perfectly in here. The second is a bit different compared to other rules and is strictly not directly about Capabilities only. But it is very related so I think it fits in here as well.


Fix day used to select the secret pokémon in the daily game

What
My timezone is GMT-3 and I noticed that when I played the Daily Squirdle after 9PM the secret pokémon of that day would be the same as the next day. This means that I can get two points for my streak for the same pokémon.
Why
The code that formats the local date in daily.html uses the function toISOString() in the process to get the date in the yyyy-MM-dd format, but this function may also change the date day. Since this day is used to determine the pokémon of the day, this would cause the unexpected behavior.
For example, let's suppose it is August 13th at 22:04 for me, when I run the command new Date() it returns: Sat Aug 13 2022 22:04:04 GMT-0300 (Brasilia Standard Time)
When the code calls the function toISOString() it will return: "2022-08-14T01:04:04.158Z"
So the chosen secret pokémon will be the one from August 14th instead of August 13th!
How
I solved this issue by removing the timezone offset from the Date, so when the toISOString() is called and it applies the offset it will get the correct local day and time and it will only work as a formatting function.
With this change, in the example above, the result after this function call would be "2022-08-13T22:04:04.158Z", so the selected pokémon will be the one from August 13th.

Fixes #39


Box clone not overriding child component styles

I'm using Box with the clone property (https://material-ui.com/components/box/#overriding-material-ui-components) and I'm seeing that the Box styles get overridden by the component's styles.
I've confirmed that Box is imported last in the file, but its styles are still not taking precedence. I tried to replicate it in a minimal repo, but it is working there, and I'm not able to narrow down to what is breaking the functionality because it's not consistent - sometimes it works, sometimes it doesn't. I'd like to provide information to track down this issue
I'm using Gatsby and the Gatsby plugin for Material UI, if that helps.

[x] This is not a v0.x issue.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔
The box CSS should take precedence over the child component class.
Current Behavior 😯
The child component CSS is taking precedence.
Here are my imports:

Here is my usage of box:

Here is the CSS that's generated, as you can see the box class has lower precedence

Steps to Reproduce 🕹
I'm not able to create a repository that reproduces this issue. I started with the example gatsby starter and pasted a lot of my code into it, and got it to a point where it wasn't working. Then I started removing code to see how to minimize the example, and it started working again. When I undid the changes, it continued working, so I'm not able to reproduce this bug consistently.
If anyone has some ideas what it could be, or what I could try, I would appreciate it. At this point I'm really stuck, but would like to work with someone to resolve the issue.

https://codesandbox.io/s/hardcore-resonance-by6zt
Context 🔦
I'm trying to use box to override styles on another component. Would really like to have this functionality working.
Your Environment 🌎

Tech
Version

Material-UI
v4.0.1

React
v16.8.6

Browser
Chrome v74.0.3729.157

TypeScript
N/A

Gatsby
2.7.3

@amakk We can't help without a reproduction.

@kptlronyttcna thanks for the reproduction. When using the clone prop, the order in which the elements are imported is important:
This works:
import Typography from "@material-ui/core/Typography";
import Box from "@material-ui/core/Box";

This doesn't work:
import Box from "@material-ui/core/Box";
import Typography from "@material-ui/core/Typography";

Hmm, It appears that
this works:
import Typography from "@material-ui/core/Typography";
import Box from "@material-ui/core/Box";

but this does not:
import { Typography } from "@material-ui/core";
import Box from "@material-ui/core/Box";

In both cases Box is imported last (to see it in codesandbox you have to manually refresh the preview window)

Has anyone had a chance to look into this?
In the mean time, what I have done is copied the Box component and increased specificity of CSS generated by Box. Here is the implementation, in case it's helpful for others having this issue:
import {
  borders,
  compose,
  css,
  display,
  flexbox,
  palette,
  positions,
  shadows,
  sizing,
  spacing,
  typography
} from '@material-ui/system'
import { styled } from '@material-ui/styles'

const innerStyleFunction = css(
  compose(
    borders,
    display,
    flexbox,
    positions,
    palette,
    shadows,
    sizing,
    spacing,
    typography
  )
)

const styleFunction = props => ({
  '&&': innerStyleFunction(props)
})

const Box = styled('div')(styleFunction, {
  name: 'MuiBox'
})

export default Box

Moving to #15561

Adding to @amakk suggestion, we should do this:
styleFunction.filterProps = innerStyleFunction.filterProps;

so that Box doesn't inject unknown properties to the DOM.


Update to Jest 27

There's a bugfix in React that we need to make. Unfortunately, there's a risk of that change breaking some tests. In order to fix the tests, you'd have to upgrade Jest. But if you use Jest via CRA, you can't do this directly.
We need to upgrade CRA to Jest 27 so that we can unblock React from making this bugfix. Jest 27 isn't out yet, but we can start testing the integration using the 27.0.0-next.6 version.
Does anyone want to take this on?

I definitely would love to take this on :)

Thanks @ankurkaushal, please feel free to send a PR! Please keep in mind that the timing is somewhat sensitive so we'd like to avoid the situation where you give up on the work but no one else knows or picks it up. I think it's fair that this issue isn't taken exclusively, and if someone else ends up doing it before, we'll be reviewing that.

@gaearon: Thanks, I will try to put up a PR as soon as possible!

As an aside, updating to v27 will close #9993 (as it'll be the default and you can remove the config)

Hi! how is this going?
I have seen that Jest has released final version 27 a couple of days ago. Any chance of react-scripts to update to v27 to??
Thanks!

Sounds like the related PR #10748 is no longer progressing. Therefore, in the meantime, unable to use Jest v27.

@jasonlimantoro: Having some issues with the upgrade like I mentioned in my PR, will get back to it today & see if I can still fix it. I would love to have another pair of eyes on that.

@ankurkaushal may I clone the branch and have a look if you don't mind?

@sauldeleon: Sure! go ahead.
@jasonlimantoro: Wasn't aware of the regressions in jest 27, may be that's cause of failing tests 🤔

Ok, I will push this a little this weekend to see if we can achieve this. Sorry for not doing anything before!

@sauldeleon No worries! I will probably look again too if I get some time.

Also hoping for jest 27 support due to a nested vulnerability with jest 26:
<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>-- SNYK#SNYK-JS-REQUEST-1314897 Insecure Encryption. Upgrade jest to 27.0.6

@gaearon  @SimenB  @ankurkaushal  Please check this PR which adds jest 27.1.0
https://github.com/facebook/create-react-app/pull/11338

Hi
@petetnt
@elektronik2k5
@iansu
@mrmckeb
@SimenB
@gaearon
@sauldeleon .
Wanted to grab your attention to This PR https://github.com/facebook/create-react-app/pull/11338
which should close this issue  and also this issue https://github.com/facebook/create-react-app/issues/9993 and few other related issues.
Please review this PR so that this can be merged. All the issues have been resolved and the PR should be good to merge

top!!!!!

🎉


Unable to type accent marks on terminal

VSCode Version: 1.51.0
OS Version: KDE Neon 5.20

Steps to Reproduce:

I open terminal on VSCode
When I try to type letters with accent marks, they appear with no accent. So, I cannot write a proper word in Spanish for example.

Does this issue occur when all extensions are disabled?: Yes

/duplicate xtermjs/xterm.js#2479, xtermjs/xterm.js#2151


fix(sec): upgrade com.google.guava:guava to 32.0.0-jre

What happened？
There are 1 security vulnerabilities found in com.google.guava:guava 30.1-jre

CVE-2023-2976

What did I do？
Upgrade com.google.guava:guava from 30.1-jre to 32.0.0-jre for vulnerability fix
What did you expect to happen？
Ideally, no insecure libs should be used.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Deprecated use of PropTypes validation functions

Problem description
With React 15.3.0 the maintainers appear to have deprecated use of PropTypes validation functions.
Steps to reproduce
When using components, e.g. Slider, and passing a prop such as defaultValue, I see error messages like the following:
"ERROR: 'Warning: You are manually calling a React.PropTypes validation function for the defaultValue prop on Slider. This is deprecated and will not work in the next major version. You may be seeing this warning due to a third-party PropTypes library. See https://fb.me/react-warning-dont-call-proptypes for details.'"
Similar warnings are printed for List and EnhancedButton.
Versions

Material-UI: master (2d69cb1)
React: 15.3.0
Browser: Chrome

Same happend to me with AppBar component.
Warning: You are manually calling a React.PropTypes validation function for the linkButton prop on EnhancedButton. This is deprecated and will not work in the next major version. You may be seeing this warning due to a third-party PropTypes library. See https://fb.me/react-warning-dont-call-proptypes for details.

@jacksonrayhamilton Thanks for raising this issue.

Whoops, looks like the PropTypes calls for Slider were missed?

@jacksonrayhamilton Good catch. Do you want to submit a PR?

Sure, but I don't know how it should be fixed. typeof props[propName] === 'number' and return an error in the same format as the PropTypes functions?

@jacksonrayhamilton Basically, you need to spread the arguments to the next function.

I'm getting this error with position attributes.

I think this is also happening for List components.

@Nesciosquid I'm not seeing that on master with my instance of List. Nor do I see PropTypes being called in those components. Do you have conditions to reproduce on master?

There are PropType validation warnings still being thrown for TextField & SelectField components as well.

Ah, I'm using the latest npm build.

Please push to NPM as soon as possible :)

Hello, I've just installed the newest React and Material-UI and I've got the same for the Chip components as well http://www.material-ui.com/#/components/chip

Here's a list of warnings I get after upgrade:
Warning: You are manually calling a React.PropTypes validation function for the `linkButton` prop on `EnhancedButton`.

Warning: You are manually calling a React.PropTypes validation function for the `onEnterKeyDown` prop on `TextField`.

Warning: You are manually calling a React.PropTypes validation function for the `animated` prop on `Menu`.

Warning: You are manually calling a React.PropTypes validation function for the `openDirection` prop on `Menu`.

Warning: You are manually calling a React.PropTypes validation function for the `unCheckedIcon` prop on `Checkbox`.

+1

Hi guys, I am experiencing the same problem with react 0.28.0. Do you have any suggestion?

I'm having the same problem

I was able to solve this problem by downgrading react version to 15.2.1

Got the same problem for react v15.3.0 and material-ui v0.15.2

I had the same problem with react-sparklines, I checked npm that had version 2.8.xx. Then, trying to upgrade my npm to 3.10.5 and no more warning :")

problem is you need the latest version of npm. To do this go to https://nodejs.org and download the most current version (should say Current next to it). type in npm -v into your console and it should be 3.10.3 or above. then go to the repo where you have your sparklines installed and run npm install, npm update. try starting your app again and you should not get any more console errors.

you can also: npm install -g npm

I am using npm 3.10.5, but still got the warning.

Not working on npm 3.10.5, issue seems to be occuring if you split the Listitem into a different component and use a Divider or Subheader there.

This is having issues on SvgIcon as well, and is throwing a bunch of errors:

Warning: You are manually calling a React.PropTypes validation function for the children prop on SvgIcon. This is deprecated and will not work in production with the next major version. You may be seeing this warning due to a third-party PropTypes library. See https://fb.me/react-warning-dont-call-proptypes for details.

Warning: You are manually calling a React.PropTypes validation function for the color prop on SvgIcon. This is deprecated and will not work in production with the next major version. You may be seeing this warning due to a third-party PropTypes library. See https://fb.me/react-warning-dont-call-proptypes for details.

Warning: You are manually calling a React.PropTypes validation function for the hoverColor prop on SvgIcon. This is deprecated and will not work in production with the next major version. You may be seeing this warning due to a third-party PropTypes library. See https://fb.me/react-warning-dont-call-proptypes for details.

Warning: You are manually calling a React.PropTypes validation function for the onMouseEnter prop on SvgIcon. This is deprecated and will not work in production with the next major version. You may be seeing this warning due to a third-party PropTypes library. See https://fb.me/react-warning-dont-call-proptypes for details.

Warning: You are manually calling a React.PropTypes validation function for the onMouseLeave prop on SvgIcon. This is deprecated and will not work in production with the next major version. You may be seeing this warning due to a third-party PropTypes library. See https://fb.me/react-warning-dont-call-proptypes for details.

Warning: You are manually calling a React.PropTypes validation function for the style prop on SvgIcon. This is deprecated and will not work in production with the next major version. You may be seeing this warning due to a third-party PropTypes library. See https://fb.me/react-warning-dont-call-proptypes for details.

Warning: You are manually calling a React.PropTypes validation function for the viewBox prop on SvgIcon. This is deprecated and will not work in production with the next major version. You may be seeing this warning due to a third-party PropTypes library. See https://fb.me/react-warning-dont-call-proptypes for details.

Warning: You are manually calling a React.PropTypes validation function for the muiTheme prop on SvgIcon. This is deprecated and will not work in production with the next major version. You may be seeing this warning due to a third-party PropTypes library. See https://fb.me/react-warning-dont-call-proptypes for details.


Changelog and Github releases

I'm not sure if this should be opened here but I was unable to find releases on GitHub and also not any changelog.
Please let me know where I can find them or is there any plan to implement them?

Thanks a lot for the suggested improvement!
All the releases are now listed at https://github.com/madfish-solutions/templewallet-extension/releases


Add core functionality for build to docker daemon

Thanks for the detailed feedback!

Oh, should link this to https://github.com/GoogleContainerTools/jib/issues/243 for reference.


Diff is treated as js code?

This is the only comment I'm getting from pronto-jshint:
Bad line breaking before '+'.
And it is all over the place. I suspect jshint treats diff as js code, and doesn't like + in the beginning.

@spajus could you try running just jshint and see what happens?

@mmozuras yeah, with clear head it looks like jshint did the right job (there was badly formatted string), but it failed to put comments in right place.


Detect all watches, or just one watch?

Hello, I have been using this successfully to detect my apple watch (series 5) for some time now. I recently tested to see if it picked up my wife's watch (series 3) by walking out of range of the ESP32 while my wife was in range and found that did not detect it. Shouldn't it have detected my wife's watch as well? My config is below.
  scan_parameters:
    interval: 1.2s
    window: 500ms
    active: false
  on_ble_advertise:
    - then:
      # Look for manufacturer data of form: 4c00 10 05 YY 98 XXXXXX
      # Where YY can be 01..0F or 20..2F; and XXXXXX is ignored
      - lambda: |-
          optional<int16_t> best_rssi = nullopt;
          for (auto data : x.get_manufacturer_datas()) {
            // Guard against non-Apple datagrams, or those that are too small.
            if (data.data.size() < 4 || data.uuid.to_string() != "0x004C" || data.data[0] != 0x10 || data.data[1] < 5) {
              continue;
            }
            const int16_t rssi = x.get_rssi();
            const uint8_t status_flags = data.data[2] >> 4;  // High nibble
            const uint8_t data_flags = data.data[3];
            if (data_flags == 0x98) {  // Match unlocked Apple Watches
              if (status_flags == 0 || status_flags == 2) {
                best_rssi = max(rssi, best_rssi.value_or(rssi));
                ESP_LOGD("ble_adv", "Found Apple Watch (mac %s) rssi %i", x.address_str().c_str(), rssi);
              } else {
                ESP_LOGD("ble_adv", "Possible Apple Watch? (mac %s) rssi %i, unrecognised status/action flags %#04x", x.address_str().c_str(), rssi, data.data[2]);
              }
            }
          }
          if (best_rssi) {
            id(apple_watch_rssi).publish_state(*best_rssi);
          }

sensor:
  - platform: template
    id: apple_watch_rssi
    name: "$yourname Apple Watch $roomname RSSI"
    device_class: signal_strength
    unit_of_measurement: dBm
    accuracy_decimals: 0
    filters:
      - exponential_moving_average:
          alpha: 0.3
          send_every: 1
    on_value:
      then:
        - lambda: |-
            if (id(apple_watch_rssi).state > $rssi_present) {
              id(room_presence_debounce).publish_state(1);
            } else if (id(apple_watch_rssi).state < $rssi_not_present) {
              id(room_presence_debounce).publish_state(0);
            }
        - script.execute: presence_timeout  # Publish 0 if no rssi received

  - platform: template
    id: room_presence_debounce
    filters:
      - sliding_window_moving_average:
          window_size: 3
          send_every: 1
  - platform: homeassistant
    name: HA RSSI Present Value
    entity_id: input_number.office_rssi_present_value
    id: harssi_present
  - platform: homeassistant
    name: HA RSSI Not Present Value
    entity_id: input_number.office_rssi_not_present
    id: harssi_not_present
binary_sensor:
  - platform: status
    name: "Office BLE Tracker Status"
  - platform: template
    id: room_presence
    name: "$yourname $roomname presence"
    device_class: occupancy
    lambda: |-
      if (id(room_presence_debounce).state > 0.99) {
        return true;
      } else if (id(room_presence_debounce).state < 0.01) {
        return false;
      } else {
        return id(room_presence).state;
      }

script:
  # Publish event every 30 seconds when no rssi received
  id: presence_timeout
  mode: restart
  then:
    - delay: 30s
    - lambda: |-
        id(room_presence_debounce).publish_state(0);
    - script.execute: presence_timeout

Hi. Yes, the code should detect any Apple watch that is in range, whether Series 3 or 5.
Two things to try:

Is the Series 3 watch unlocked?
Could you post some logs from when your Series 5 watch goes out of range and only the Series 3 is in range? Could help surface the issue.

Very good project, but unfortunately, the AppleWatch firmware sold in China is not universal.
Whether the watch is unlocked or locked, the Data flags are 0x18.

Hi @neroxps - If you want to detect a Watch where the data flag is 0x18, have a look at line 60 in the yaml file. Change
if (data_flags == 0x98) {

to
if (data_flags == 0x98 || data_flags == 0x18) {

If this doesn't work, please send your full yaml, your watch series, and verbose debug log. Verbose logging can be set
logger:
  level: VERY_VERBOSE

Hi @dcgrove - I wanted to check if you still needed help diagnosing this issue?


Changing c-states breaks magic-trace / IPT

I was experiencing issues where my traces were completely empty around the snapshot. After investigating the perf file it hinted at "instruction trace errors" which led me to
https://perf.wiki.kernel.org/index.php/Perf_tools_support_for_Intel®_Processor_Trace
which mentions

It is not uncommon to get overflows when transitioning to a C-state, so these errors are not significant.

I was testing this on a TGL laptop and after disabling turbo boost I got pretty stable traces again.
I am wondering whether other people share the same experience with switching c-states or whether there is maybe something else behind it?
If not it might be worth mentioning disabling c-states in the readme / tutorial? Turbo boost was enough for me but probably something lik e the max_cstate kernel flags work as well.
This is on 5.15.17.

I haven't seen this problem, but we will update the tutorial as you suggested, thank you.
Magic trace reads events via "perf script --itrace=b". Perhaps we should use "--itrace=be" and do something more user friendly when we see overflow packet events, esp if there aren't any other events.

Out of curiosity, is opening /dev/cpu_dma_latency and writing 0 to it sufficient to prevent the issues for you, or did you have to disable turbo entirely? I haven't encountered issues with magic-trace on server processors, but I can imagine mobile being different. I'm thinking of a one-liner like
sudo python3 -c "f = open('/dev/cpu_dma_latency', 'w'); f.write('0'); f.flush(); input('Press any key to exit\n')"

before running magic-trace. If that works, I don't think it wouldn't be unreasonable to add this behavior as a flag to magic-trace.

#33 might also help with this. Assuming this is transient latency, magic-trace would be less likely to fall behind if it has a bigger snapshot buffer.


chartjs dependency issue during installation

⚠ Please verify that this bug has NOT been raised before.

[X] I checked and didn't find similar issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

📝 Describe your problem
I am trying to install uptime-kuma through nodejs manually. When I run npm run setup I keep getting this:
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/chart.js
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!   peer chart.js@"=> ^3.1.0" from<EMAIL_ADDRESS>npm ERR!   node_modules/vue-chart-3
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer chart.js@">= 2.8.0 < 3" from<EMAIL_ADDRESS>npm ERR! node_modules/chartjs-adapter-dayjs
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Conflicting peer dependency<EMAIL_ADDRESS>npm ERR! node_modules/chart.js
npm ERR!   peer chart.js@">= 2.8.0 < 3" from<EMAIL_ADDRESS>npm ERR!   node_modules/chartjs-adapter-dayjs
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /root/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2022-04-06T10_41_05_774Z-debug-0.log

npm install is throwing the same
https://www.npmjs.com/package/chartjs-adapter-dayjs -> There isn't much information there
🐻 Uptime-Kuma Version
1.13.1
💻 Operating System and Arch
Debian 11
🌐 Browser
None
🐋 Docker Version
No response
🟩 NodeJS Version
16.14.2

npm install is throwing the same

The setup script should execute npm ci --prodcution instead of npm install. Did you really using npm run setup?
https://github.com/louislam/uptime-kuma/blob/ffc5bca51df1e4a9961cddad21a5791460faa247/package.json#L39

The setup script should execute npm ci --prodcution instead of npm install. Did you really using npm run setup?

Yes, I initially executed npm run setup and I got that error .I then tried npm ci --production and got the same. That's when I tried npm install just to see if it would make any difference. It didn't.

Strange, because it is a known issue for npm 8. npm ci --prodcution should be ok.
I can only reproduce the problem by deleting the package-lock.json file.
Is there the package-lock.json file in the directory?
Alternative you can install it by npm run install-legacy, but it is not recommended, because you may face file conflict issue later when you try to upgrade Uptime Kuma.

There is a package-lock.json in there. I tried it with Nodejs v17 and it was working now. v16 wasn't working

I will close this now as it's working with Node 17.
There might be a bug with v16 tho.

I was occured same problem.
C:\virtualbox\uptime-kuma>node -v
v16.14.2

Work fine on my Node 16.14.1, will test 16.14.2.
And what is your npm version? npm -v

Ops, after update npm to 8.6.0, I can now reproduce the problem.
Related issue: https://github.com/npm/cli/issues/4664


apache drill failed to execute SQL such as ' table1 left join table2 on condition 1 or condition 2'

Execute the following sql (although it may not make sense):
SELECT aa.employee_id FROM cp.employee.json aa left join cp.employee.json bb on aa.employee_id=bb.employee_id or aa.employee_id=bb.position_id ;

I got the results：

I tried to modify the corresponding parameters 'planner.enable_nljoin_for_scalar_only', but it still didn't work.

I'm not sure what you're trying to do with this query, but I found that rewriting it like this worked:
 SELECT aa.employee_id
 FROM cp.`employee.json` aa ,
 cp.`employee.json` bb
 WHERE aa.employee_id=bb.employee_id or aa.employee_id=bb.position_id

Thank you very much for your answer,But when I switched to MySQL, I encountered another problem,I created two storage configurations that point to the same MySQL,There is no problem when I use the same storage, such as SQL:
 select * from bb.eladmin.table1 a, bb.eladmin.table2 b where a.id =b.id or a.name=b.name

However, when I use two storage systems, the sql is as follows:
 select * from bb.eladmin.table1 a, zz.eladmin.table2 b where a.id =b.id or a.name=b.name

It still reports errors，Let me set the option 'planner.enable_nljoin_for_scalar_only' to false and try again，This is why？


Fix git push error for protected CLA branch

The pull request is created from master636855936902738582 to master to fix git push error for protected CLA branch

@Taojunshen : Thanks for your contribution! The author, @, has been notified to review your proposed change.


Read preference tags are not working on 1.x

ReactiveMongo Version
1.0.2
MongoDB version
4.2.11
Operating System (Ubuntu 15.10 / MacOS 10.10 / Windows 10)
Unutu Linux 20 , mac OS 11.2
JDK (Oracle 1.8.0_72, OpenJDK 1.8.x, Azul Zing)
openjdk 11, graalvm 11
Library Dependencies
Play 2.7
circe-bson 0.5.0
Expected Behavior

I have mongo cluster with 2 datacenters. I set instance tags to {"dc":"dc1"} and {"dc":"dc2"}. I have primary instance in dc1.
I have read preference in my code set to secondaryPreferred {"dc":"dc1"}
Reads go to mongo instance with dc1 tag

Actual Behavior

I upgraded my reactive mongo lib from version "0.19.0" to "1.0.2"
When i run application in mongodb ops manager I see that queries goes to dc2
I tried version to rollback library to version "0.19.0" - trafic goes to dc1

So read preference with tags is working improperly in 1.x branch.

You can try 1.0.4-SNAPSHOT

You can try 1.0.4-SNAPSHOT

Did you publish that to maven central? I'm using play2-reactivemongo as dependency.

Snapshots are only on sonatype OSs snapshots

Did you fix the bug? Can we expect a release anytime soon?

As said previously, it's already in the snapshot.

Thank you!

Published in 1.0.4

Thank you, it works!


Bug found in Readme.md

Line 3 in this file contains a bug.. Kindly check.

It still giving some errors.