Statistics on Moonriver

There are at least two major problems which result in bugs, with the data we have for Moonriver collections:

We're not indexing price of the NFTs, i.e. we don't have any price related data, partially covered here:

#4022

We have only two types of event interactions on Moonriver, MINTNFT (mint in app) and SEND (gift in app):

The options going forward (as I see it, pls feel free to add yours):

As with #4022, we can proceed into hiding features related to event interactions which we currently don't have indexed
We can alter the way we handle SEND event interactions and treat them as BUY ones (this would add some level of detail, although may be a bit misleading since we can't currently differentiate between actual gifting (sending) and buying)
There is a change coming to the data we currently and therefore, we should wait for this before moving forward (@vikiival is there any change coming, or should we just build UI around these two event interactions?)

Marking this as research until we have clear answers, also if there is no change coming to the data we have, I need decision whether to proceed with option 1., 2. or something entirely different @yangwao

moonriver integration discontinued


Company misspelled in Company string of executables

"RealDimensions Sofware, LLC"
should be
"RealDimensions Software, LLC"

Where is this? Thanks in advance!

It's in all of the binary .exe files. Every .exe has a metadata block. I found the executables here, although not sure where they come from:
https://github.com/chocolatey/choco/tree/master/src/chocolatey.resources/redirects

Ah, just the shims. Sweet. Yeah I will get that fixed.

This was handled in https://github.com/chocolatey/shimgen/issues/9


Fix for v1 build failure

…in core/package.json
Issue #, if available: 526
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: 5b2fe7e173039615a07aac0006a55a877f4a188c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 5b2fe7e173039615a07aac0006a55a877f4a188c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 8d9ecb7848613351ee0bbaa4b3758fdd1c2e0bcf
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: 8d9ecb7848613351ee0bbaa4b3758fdd1c2e0bcf
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: ad15c16226642b58654bd53a6e7f2584bc5a9ef6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: ad15c16226642b58654bd53a6e7f2584bc5a9ef6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


First push minimap

Adding minimap

I'm not currently playing the game and don't have a way to test this PR. I'm glad that you've done this, but at a bit of an impasse without a currently active maintainer.

I'm not currently playing the game and don't have a way to test this PR. I'm glad that you've done this, but at a bit of an impasse without a currently active maintainer.

Thanks for your response. I understand the situation with no active maintainer at the moment. I initially made this for myself, but I decided to contribute because I think others would appreciate having this feature. No pressure to review or merge it right now.


New version: elieserdejesus.JamTaba version 2.1.16

Pull request has been created with WinGet Automation :rocket:
Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/113654&drop=dogfoodAlpha

Did the publisher upload this version twice?


unittest and/or pytest?

The tests in the tests folder all seem to use unittest but the GitHub action pipeline uses pytest. Is this intentional?

Running unittests with pytest is an intentional feature :)
History: When I started coding in python, I used unittest mainly because it is in the standard library and somehow stuck to it. Over time though, I swapped to pytest to run the tests. If I remember correctly, that was because of its nice integration with codecov. And we somehow copied that approach to probeye.
But note that I have no strong preferences, all frameworks seem to cover the simple (mainy assert true and assert almost equal and no mocking etc) tests.

Thanks for the explanation. Is it preferred to add new tests using unittest to keep things consistent or it is ok to mix in pytest? I just find the unittest approach verbose with its classes.

Personally, I don't mind if you write new tests in pytest (we just have to add it in the setup.cfg). I just adapted the unittest-approach from our previous BayesianInference package.

pytest is already a dependency in setup.cfg :) https://github.com/BAMresearch/probeye/blob/034ff1ae05943400cdc9c228101303c3ce8a1806/setup.cfg#L36


Refactor searchInPairs and Enhance rtrimLines Functions

This pull request includes the following changes:

Refactored searchInPairs:

Simplified the binary search logic for determining if a hashIndex falls within string literal pairs. This enhances code readability and maintainability.

Enhanced rtrimLines Function:

Modified the implementation to utilize String.prototype.trimEnd() for trimming trailing whitespace from each line, improving performance and efficiency.

These changes aim to streamline the code while maintaining the existing functionality and ensuring that all tests pass successfully.

Summary by CodeRabbit

New Features

Simplified methods for removing docstrings and hash comments in Python files, improving efficiency.
Introduced a new function to manage the instantiation of file manipulators based on file extensions.

Refactor

Enhanced clarity and maintainability of code by streamlining comment removal logic.
Updated the line trimming method to improve readability and efficiency.
Retained the CompositeManipulator class while restructuring manipulator instantiation and access.

@Mefisto04
Thank you for your quick implements!
However, it seems that the lint checks and tests are currently failing. Could you please take a look and address the following:

Resolve any lint errors. npm run lint
Fix the failing tests. npm run test

Thanks again for your contributions to improving Repopack's performance.

I see that secretlint is throwing an error.
Are you perhaps using Windows? It might be an issue with path separators.

@yamadashy yes, i am using windows.
so what will be the approach to solve this ? Coz there is no issue in test when i run that

I've committed the lint fixes to your branch.
Additionally, I've merged a fix into the main branch that addresses the issue with secretlint not running properly on Windows.
Let me know if you encounter any further issues. Thanks for your patience and contribution!

Hi, @Mefisto04
The implementation is perfect, thank you so much!
Your changes have significantly improved the code's readability and efficiency.
I'll merge this!


refactor(module:descriptions): migrate demo to standalone mode

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

tests passed, please review again @HyperLife1119 :)


invalid command 'crowdtruth'

When I run python setup.py crowdtruth I get this error: invalid command 'crowdtruth'
I also tried different commands, but it doesn't work.

We've updated the installation from source command to python setup.py develop


very useful

Very useful thanks. I do have a question. I'm looking to use a custom domain storage account with my own domain name. How do I configure the app (connection string) to use a custom domain name storage account? Thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f1026434-050e-b1d5-7cac-47cf5d5d2cad
Version Independent ID: bfb4d3c9-af35-f08b-710a-afc3281e3d87
Content: Upload image data in the cloud with Azure Storage | Microsoft Docs
Content Source: articles/storage/blobs/storage-upload-process-images.md
Service: storage
GitHub Login: @tamram
Microsoft Alias: tamram

@davidokeyode Thanks for the feedback. We are actively investigating and will get back to you.

@davidokeyode You can configure a custom domain for accessing blob data in your Azure storage account. I'd recommend checking the following document: https://docs.microsoft.com/en-us/azure/storage/blobs/storage-custom-domain-name

@davidokeyode  Let me know if the previous comment answered your question.


New Blade Template Layout

This PR updates the current templates to a more appealing look out of the box.
I was tired of looking at that teal background, thus came the idea to revamp all blade views.
New screenshots:

This looks great @rbcunhadesign! Thanks very much :)


datasets by subject metric

How do we want to handle multiple subjects?
Do we want to go over 100% when comparing #subjects to actual #datasts?

Talked with @jcabanas17 earlier today. He's going to pick this one up as a way to familiarize himself with the changes in the project since he was last involved.


add Harbin Engineering University

add Harbin Engineering University

@eshuo Please provide us with a proof, which shows that the school recognizes the domain hrbeu.cn that you are submitting as an official email domain for the students.
You can provide us with any of the following:

A copy of instruction (a hard-copy or electronic one) given to you by the school that tells you to use an email address in this email domain
An URL of a page at the official school website that says that students use this email domain
A reference to a recognized journal where an article was published by someone from the school, with explicit affiliation to the school, and e-mail address from the email domain
A WHOIS data that link the email domain to the school somehow
A copy of official letter from the school representative saying that the school provides e-mail addresses in this domain to the students
Anything else that can prove this fact in similar way, i.e. can be verified independently.

Sorry, I can't find it yet. I will submit the application after I find the relevant credentials. Thank you.


Can't get plugin to work

Hi @JamesPan,
I can't get the plugin working, nothing changes in the outputted HTML.
The plugin registers to the after_render:html filter event, and then assumes it can read files from the public folder. But when I debug the logic no files are actually written when the event runs, which means all this logic never runs, which means the plugin doesn't work for me.
If I run the plugin a 2nd time on the output that was generated before, then it does works. But obviously much of a solution to always be one step behind last changes.
Can you verify if this is a real problem or something just on my machine? Are you aware of an event that's suitable for the process of reading the other outputted files and altering whats already generated?

To inline assets, make sure you add __inline=true as query parameters to the CSS or JavaScript link


DEV: Remove usage of tagName

What's the context of this? Was it a deprecation? 🤔

Yeah... tagName here is consumed by the raw-hbs template:
https://github.com/discourse/discourse/blob/a1b35601fcd209d83471e269e23b7c4f9a42465a/app/assets/javascripts/discourse/app/templates/list/activity-column.hbr#L1-L1
So I think failing to pass it will lead to some weird/broken behaviour.


support for foo(...$argss)

It turns out that we don't support this at the moment, because this unquoting template isn't syntactical (what looks like a single Term.Apply after parsing may become a bunch of nested applications at runtime). Note: ..$args is still supported.

It turns out that Term.Apply is the only tree that doesn't support syntactic ...$. All other occurrences of ...$ correspond to Seq[Seq[...]], but in Term.Apply we have Seq[Term.Arg]. That's a weird special case.


Ability to revert to a previous Insider version

It would be great if there is the possibility to revert to a previous Insider build if the current one should include a huge blocking issue (like #56792). This way we do not have to revert back to the previous stable build which has completly different settings and extension installation.

We have a switch to unmark the release which will allow users to revert to previous release.


Platform config improvements

Motivation for this change
The first commit is about making the selection of a "platform" less haphazard. The rest are about trying to clean up exactly what's there so it's a bit less ad-hoc. (I hope to do more on that front later.)
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@matthewbauer OK got all your suggestions.

Sorry - forgot to approve - but looks good!


core22 snap installation issues in air-gapped environments

I tried to deploy the charm in a "temporarily air-gapped" environment but it failed with the following error:
unit-prometheus-juju-exporter-0: 10:34:25 WARNING unit.prometheus-juju-exporter/0.install error: cannot perform the following tasks:
unit-prometheus-juju-exporter-0: 10:34:25 WARNING unit.prometheus-juju-exporter/0.install - Ensure prerequisites for "prometheus-juju-exporter" are available (cannot install snap base "core22": Post https://api.snapcraft.io/v2/snaps/refresh: Proxy Authentication Required)

I attached the local snap as follows:
juju attach-resource prometheus-juju-exporter exporter-snap=./prometheus-juju-exporter_3.snap

But snap core22 was still missing and currently, it's impossible to attach it as the resource.
My proposal is to implement a new resource for the core snap, similar to how other charms do it.

Workaround: snap download core22, scp it to the target units and install manually there.

In this particular environment attaching core22 as a resource would be the only possible option. It would be the same solution that is used in the p-o-e charm for example.


Split Registries management to a separate repository

@mostaphaRoudsari brought this up briefly during a call but did not have time to explain his though fully. Would you mind explaining in a bit more detail what your thinking was here so we can keep track of this development proposal?

From showing and explaining queenbee to a handful number of people I felt it will be helpful to separate the package manager functionalities from the queenbee schemas. The package manager part will provide functionalities to package, pull, ... the Queenbee recipes and plugins while Queenbee provides the functionalities for writing the recipes, plugins and plugin functions.
Maybe we can call it Beehive or Queenbee package manager -> qpm!

I like the idea. It would provide a nice abstraction to work from also. Are we ok parking this issue for now and you or I can sift through the codebase to figure out how straightforward it will be to extract this stuff?

Are we ok parking this issue for now and you or I can sift through the codebase to figure out how straightforward it will be to extract this stuff?

I would say so. Let's do it after the early access. I think it is nice to have but it is not critical right now.
The functionalities are almost separate so it shouldn't be that hard to separate them into its own package.


update russian translation

Those 2 conditions on enemy ended up not being required. Need to remove from PR for merge.

manually added changes.


Adding AttestationClient source code

Adding source code and build scripts of AttestationClient

@akashgupta29  addressed comments over PR. Please review it again.

@akashgupta29 #sign-off from my side.


test: increase jwt lifetime for jwt used in tests

:tada: This PR is included in version 1.118.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Missing void types in Table and Array.

I've tried to search through closed issues but could not find anything related.
Within AMQP 0-9-1 Protocol Specification there are void field types which you can use within tables. You can see grammar in 4.2.1 section Formal Protocol Grammar. Void field type is V. Such field does not have size itself besides field type.
Here example of message utilizing such types (seen by Wireshark):

Such messages produced by Celery - Distributed Task Queue.
It is valid headers and Python's clients like Kombu and Pika reading such message without problem.
In your library within table.cpp:
https://github.com/CopernicaMarketingSoftware/AMQP-CPP/blob/c783cbc17e89049c1493c8ca2334682be179f51c/src/table.cpp#L21-L34
Before decode fields using Field::decode you decrease bytesToRead variable for length of field name and additionally for field type character. In Field::decode there no logic for "reading" void type so it returns nullptr. And as result such field will no added to _fields map.

I think this is logically INCORRECT. Since consumer (and producers also) could require fields with given name even with null value.

Despite that bytesToRead variable decreased by correct value. Problem arise with highlighted field within screenshot. When field is array type and any elements have Void field type its array's size() method returns incorrect value.
Here reading lines within array.cpp:
https://github.com/CopernicaMarketingSoftware/AMQP-CPP/blob/c783cbc17e89049c1493c8ca2334682be179f51c/src/array.cpp#L25-L35
Again it have same logic: decrease array's bytesToRead variable by 1 and do not add field to _fields array if field is V type.
In my case array's size() should return 6: 4 byte for length of its content, 1 byte for V field type of first element and 1 byte for V field type for second element. But since these elements was not added to array's _fields it's size() method returns 4.
As result parent table.cpp incorrectly decrease its bytesToRead variable within this line:
https://github.com/CopernicaMarketingSoftware/AMQP-CPP/blob/c783cbc17e89049c1493c8ca2334682be179f51c/src/table.cpp#L34
In my case at end of real headers bytesToRead variable have value of 2 and it read more 2 bytes (delivery mode and priority) out of headers. This will result exception with frame out of range error.
So at least you have error with reading nested types.

If so how to correctly decrease of parents bytesToRead variable?
This especially will be matter if inner type is F Table type. In that case even field names sizes will not be included in parent scope.

@EmielBruijntjes It is odd. You are updating library but do not react for issues for months. This issue related to core protocol support and it should be at least considered firstly.
At least make some comments like "We do not plan to support core protocol".
Not answering at all is more offensive than answer that you will do nothing.

To be honest, we ourselves are not using tables with void-types. So it just somethidoesn't have top-priority for our organization, and I am also not familiar with them and how to handle them.

@EmielBruijntjes Yes. I'm understating that you are not using void types. It is odd for me that you are not implementing standard formal grammar of AMQP.
Void types is like nullptr in C++, None in Python and null in C#. In some libraries such properties called required optional meaning that you have to specify property even if its value is empty. In Celery for example you can specify time range for launch tasks and you could provide empty upper or lower limit (so task launch date will not be limited at one of ends).

If you can, please send in a pull-request to fix it, so that we can merge it into the code.
I've already done that in #345 at July 29. I think it is not overlap with your newer commits.

@EmielBruijntjes I've found that CI is not working and found that ReceivedFrame class became InBuffer so I've made commit which renaming it within my VoidField class.
Please see #372.

@EmielBruijntjes Also despite that is not related problem. I found that VS2019 create many warnings about converting 64 bit size into 32 bit size within Envelope class.
Envelope(InBuffer &buffer) : MetaData(buffer)
    {
        // extract the properties
        _bodySize = buffer.nextUint64();
        _body = buffer.nextData(_bodySize);
    }

Where _bodySize is uint64_t while buffer.nextData expects uint32_t.
If you don't mine, please, review why have you changed size down to 32 bit (maybe it should 32 bit protocol).
I'll also look in Friday.


feature: support inline plugins

Did you check the docs?

[X] I have read all the lazy.nvim docs

Is your feature request related to a problem? Please describe.
Inline plugins incur a 20+ ms delay when lazy-loaded.
I'm using dir = "/dev/null" to create inline plugins. Inline plugins are essentially standalone setup functions packaged inside a plugin spec. For example:
-- Create a GitRepoEnter event
{
  -- The GitRepoEnter event is emitted after VimEnter and even VeryLazy events.
  name = "git-repo-enter-event",
  dir = "/dev/null",
  dependencies = "nvim-lua/plenary.nvim",
  config = function()
    local function exec_git_repo_enter()
      vim.api.nvim_exec_autocmds("User", {
        pattern = "GitRepoEnter",
      })
    end

    vim.api.nvim_create_autocmd({ "VimEnter", "DirChanged" }, {
      pattern = "*",
      callback = function()
        require("vcs").is_inside_git_repo(function(inside_git_repo)
          if not inside_git_repo then
            return
          end

          vim.defer_fn(exec_git_repo_enter, 0)
        end)
      end,
    })
  end,
}

Below is an example of a lazy-loaded inline plugin. On my machine (MacBook Air M2), the lazy-load is 20ms slower than its non-lazy-loaded version (without ft =). I guess there's some issue where Lazy tries to read "/dev/null", maybe?
-- Configure none-ls for Lua
{
  name = "none-ls-lua",
  dependencies = "nvimtools/none-ls.nvim",
  dir = "/dev/null",
  ft = "lua",
  config = function()
    local null_ls = require("null-ls")
    local nls_utils = require("null-ls.utils")

    null_ls.register({
      null_ls.builtins.diagnostics.luacheck.with({
        cwd = function(params)
          -- Use the .luacheckrc that's the nearest to the file.
          -- This is useful when I do things like `nvim .config/nvim/init.lua`, so that `.config/nvim/.luacheckrc`
          -- gets picked up and not `~/.luacheckrc`.
          return nls_utils.root_pattern(".luacheckrc")(params.bufname)
        end,
      }),
      null_ls.builtins.formatting.stylua,
    })
  end,
},

Describe the solution you'd like
I would like to have an option in the plugin spec to classify the plugin as an inline plugin. This option would then instruct Lazy to ignore the dir. It could be done by adding an inline option to the plugin spec. This option could be also implemented by treating dir = '' specially.
Describe alternatives you've considered
I could manually setup such configuration, but it's less convenient for me. Lazy is an excellent framework for this:

Lazy let's me specify plugin dependencies of my configuration snippets.
Lazy automatically handles filetype lazy-loading for me.
Lazy tracks impact of those configuration snippets on my start up time.

Additional context
No response

BTW, doing setting up the FileType autocmd myself also fixes the spurious 20ms issue:
lazy = true,
init = function()
  vim.api.nvim_create_autocmd("FileType", {
    pattern = "lua",
    callback = function()
      require("lazy").load({ plugins = { "none-ls-lua" } })
    end,
  })
end,

Probably the lazy-loading code path uses some different logic.

you should just create autocommands
if you automatically want to lazy load the plugins just set lazy=false and they'll be loaded once they're required. I don't see why you'd need lazy to support this.
Also imo what you want has nothing todo with "inline plugin". It's just configuration parts managed by lazy.nvim

you should just create autocommands
if you automatically want to lazy load the plugins just set lazy=false and they'll be loaded once they're required. I don't see why you'd need lazy to support this.

Two reasons:

{ inline = true } is cleaner than { dir = "/dev/null }`.
There's a "bug" that introduces a 20ms load delay if I use set both dir and ft (for lazy-loading).

Also imo what you want has nothing todo with "inline plugin". It's just configuration parts managed by lazy.nvim

I don't mind, but it's more consistent to call this pattern inline plugins, because in Lazy.nvim's nomenclature those are plugin specs a not configuration specs.

I don't mind, but it's more consistent to call this pattern inline plugins, because in Lazy.nvim's nomenclature those are plugin specs a not configuration specs.

Yes and that's exactly the problem imo. What you want aren't plugins.

Two reasons:

{ inline = true } is cleaner than { dir = "/dev/null" }.
There's a "bug" that introduces a 20ms load delay if I use set both dir and ft (for lazy-loading).

I told you that I'd use autocommands. Both of those reasons are reasons why you would use autocommands and not lazy.nvim. With autocommands you don't have any of this issues and no changes are required in lazy.nvim which will just be for a very niche usecase which can easily be done with a "workaround" (which actually isn't a workaround but just how things are intended to be done).
About the 2. "reason": This definitely isn't because setting dir and ft. I do that myself and don't have such issues.
It might have something todo with dir being /dev/null. Perhaps would be interesting to investigate why this directory has this issue (perhaps because lazy tries to detect e.g. colorschemes or ftdetect folders which is just slow in this directory?) but there shouldn't be any case where you need to do this anyway.

Perhaps this request is similar to this one: feature: allow spec as a plugin


show avatar in thumbnail image in ?userinfo

This issue was created by an automation. It was authored in Discord by Beatso#0024, in Beatserver #feedback-support.

added in pr #70


tools/wrapper.sh: filter out -lstdc++ in ARGS to avoid mesa 24.2 building error

Fixes the following meson building error happening at mesa 24.2 build:
ERROR: Could not detect either libc++ or libstdc++ as your C++ stdlib implementation.

Thank you

You're welcome


Filters not working when using @function on field

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

How did you install the Amplify CLI?
No response
If applicable, what version of Node.js are you using?
No response
Amplify CLI Version
6.3.1
What operating system are you using?
Mac
Amplify Categories
api
Amplify Commands
Not applicable
Describe the bug
I have a Lambda (getUser) connected to a field in my schema. It returns null or a JSON string with user information.
I'm trying to return every item in the database that has a user connected. This seems to be not working with Lambda resolvers.
Schema
type License @auth(rules: [
    { allow: owner, ownerField: "identity_sub", identityClaim: "custom:user_id", provider: userPools, operations: [read] },
    { allow: groups, groups: ["admin"], operations: [create, read, update, delete], provider: userPools },
    { allow: groups, groups: ["lbcoach"], operations: [read], provider: userPools }
  ]) @model
  @key(name: "byTenant", fields: ["tenant_id", "validTo", "identity_sub"], queryField: "listLicensesByTenant")
  @key(name: "byUser", fields: ["identity_sub"], queryField: "listLicensesByByUser")
  @key(name: "byValidTo", fields: ["type", "validTo"], queryField: "listLicensesByValidTo")
  @key(name: "byValidUserTo", fields: ["type", "validTo", "user"], queryField: "listLicensesByValidUserTo")
  {
  id: ID!
  type: LicenseType!
  tenant_id: ID!
  identity_sub: ID
  user: String @function(name: "getUser-${env}")
  validTo: String!
  tenant: Tenant @connection(fields: ["tenant_id"])
}

Query
query listLicensesByValidToUser {
  listLicensesByValidTo(type: LICENSE, filter: {user: {attributeType: string}}) {
    items {
      user
    }
  }
}

Lambda
/* Amplify Params - DO NOT EDIT
	API_API_GRAPHQLAPIIDOUTPUT
	API_API_USERMAPPINGTABLE_ARN
	API_API_USERMAPPINGTABLE_NAME
	AUTH_LIFEBONUSMOBILECC6F448CCC6F448C_USERPOOLID
	ENV
	REGION
Amplify Params - DO NOT EDIT */
const { DynamoDB, CognitoIdentityServiceProvider } = require('aws-sdk');

const dynamoDB = new DynamoDB.DocumentClient();
const cognito = new CognitoIdentityServiceProvider();

const getUserMapping = async (customUserId) => {
    if (!customUserId) {
        return null;
    }

    const userMappingResponse = await dynamoDB.query({
        TableName: process.env.API_API_USERMAPPINGTABLE_NAME,
        IndexName: 'byCustomUserId',
        KeyConditionExpression: "custom_user_id = :custom_user_id",
        ExpressionAttributeValues: {
            ":custom_user_id": customUserId
        },
    }).promise();

    console.warn('[debug] userMappingResponse', userMappingResponse);

    return userMappingResponse.Items[0];
};

const getUser = async (identitySub) => {
    if (!identitySub) {
        return null;
    }

    const user = await cognito.adminGetUser({
        UserPoolId: process.env.AUTH_LIFEBONUSMOBILECC6F448CCC6F448C_USERPOOLID,
        Username: identitySub
    }).promise();

    console.warn('[debug] user', user);

    return user;
}

exports.handler = async (event) => {
    try {
        console.warn('[debug] event input', event);

        const custom_user_id = event.source.identity_sub;

        console.warn(`[debug] custom user id`, custom_user_id);

        const userMapping = await getUserMapping(custom_user_id);
        const user = await getUser(userMapping?.identity_sub);

        if(user) {
            user.UserAttributes = user.UserAttributes.reduce((object, current) => {
                return {
                    ...object,
                    [current.Name]: current.Value
                }
            }, {})
        }

        return user;
    } catch(error) {
        console.error('[error]', error);
        return null;
    }
};

Expected behavior
I would expect that it returns the list of data without the null users.
Reproduction steps
Create an amplify project add a model with a @function resolved field. Make it return null a string and check if you can filter on this.
GraphQL schema(s)

# Put schemas below this line

Log output

# Put your logs below this line

Additional information
No response

Closing due to inactivity


Ensure Bool tags (and possibly others) are not broken by the looser Query lagnage.

we can now search using true / false instead of 1/0

On edge with gharchive dataset, public:true is working.

We can add support for public:1 very easily. This ticket is about the interaction with tags.
Limiting tags to raw string and u64 is probably for the better. (maybe it is already the case)

closed by #3449


[FLINK-32884] [flink-clients] Sending messageHeaders with decorated customHeaders for PyFlink client

FLINK-32884 PyFlink remote execution should support URLs with paths and https scheme
What is the purpose of the change
This PR handles including customHeaders in messageHeaders when a Python client is sending requests. This will allow sending auth tokens with the request.
Brief change log

send messageHeaders which are decorated with customHeaders

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
This change is already covered by existing tests, such as flink-clients/src/test/java/org/apache/flink/client/program/rest/RestClusterClientTest.java#testRESTManualConfigurationOverride
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper:no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot run azure


CHNG CLI signal incorrectly tagged as late

The CHNG CLI signal on the website are incorrectly tagged as "late".  It should be "early", in the same way that the doctor-visits CLI signal is early.

Rating Scale (1 is minor, 7 is severe): 2

see https://github.com/cmu-delphi/delphi-epidata/pull/723


Rename named return variable in walker closure

By default, walker closure has the following signature:
func(i *jscan.Iterator[S]) (err bool)

IDE proposes it every time you're trying to use auto-complete. And I find the named return's name quite inconvenient because of the following reasons:

err variable is pretty common and is usually meant to carry a value of type error. This sometimes leads to name collisions
It doesn't quite respond to its semantics: it is more like some exit or stop

The preferred solution would be to replace bool with the actual error interface, so jscan.Scan would return it instead of error with code ErrorCodeCallback. However, it breaks backward capability, and according to the fact that v2 was released just recently, it definitely won't be implemented just now.
So my current solution is to rename it to some of the already mentioned variants:

exit
stop
break_ (seems ugly tbh)

I'm going to open a PR after the resolution

To understand why I don't return error, as is common in Go,
consider the following benchmark (https://go.dev/play/p/_iAcdhVU8m7):
=== RUN   TestSizeOf
    bench_test.go:10: size of Error[string]: 32
    bench_test.go:11: size of Error[[]byte]: 40
--- PASS: TestSizeOf (0.00s)
goos: darwin
goarch: arm64
pkg: errbench
BenchmarkInterface
BenchmarkInterface-10           54839221                21.78 ns/op           32 B/op        1 allocs/op
BenchmarkStructString
BenchmarkStructString-10<PHONE_NUMBER>               0.9313 ns/op          0 B/op        0 allocs/op
BenchmarkStructBytes
BenchmarkStructBytes-10         334166505                3.578 ns/op           0 B/op        0 allocs/op
PASS
ok      errbench        4.804s

Returning the Error[T] type carrying relevant information as error will allocate it on the heap.
Using fmt.Errorf or similar would also allocate memory.
Copying 32 bytes on modern 64-bit systems is essentially free and 40 bytes in case of []byte is comparably cheap. Therefore, I leave the decision of whether to use Error[T] as error to the API user as it does incur a cost.
If the walker closure would return error then other functions would need to return error too which I would rather avoid for the reason described above.
The fact that the named return err can be inconvenient is a fair point and renaming it would be backward compatible so that's possible. exit and stop are both good candidates, break_ is not.

Talking about performance, user must take care about it by himself, too. So by that, I disagree that returning error interface is that awful in terms of performance, as in my own usecase I use pre-defined static errors. I agree, that there are more usecases as I've seen, and sometimes error text would be needed to be a dynamic, but in this case user still needs to make an effort to avoid fmt.Sprintf or anything like that. In other words, the task is difficult by itself, and used approach currently doesn't really help as far as I can see.
What about renaming the err - have we reached a consensus here, so I can open a PR?

Using jscan.Error[T] as error

but in this case, the user still needs to make an effort to avoid fmt.Sprintf or anything like that.

Not much effort required since jscan.Error[T] implements error, just wrap it:
var err error
if e := jscan.Validate(json); e.IsErr() {
  err = e
}

Or simply call the Error method to get the message allocated:
errMsg := jscan.Validate(json).Error()

Rationale
Consider the following example and benchmark: https://go.dev/play/p/SxuovkZG2D2
IndexOfErrorInJSON needs to return either the index of where there's an error in the JSON or -1 if there was no error. Returning jscan.Error[T] actually makes the code both simpler and faster:
if err := jscan.Validate(j); err.IsErr() {
	return err.Index
}
return -1

If we were to return error from jscan.Validate instead, then we would need to either use a type assertion or errors.As, which are both less convenient and wasteful:
if err, ok := jscan.Validate(j).(jscan.Error[string]); ok {
	return err.Index
}
return -1

var jscanErr jscan.Error[string]
if errors.As(jscan.Validate(j), &jscanErr) {
	return jscanErr.Index
}
return -1

goos: darwin
goarch: arm64
pkg: errbench
Benchmark
Benchmark/concrete
Benchmark/concrete-10           21867732                49.74 ns/op            0 B/op          0 allocs/op
Benchmark/errors_as
Benchmark/errors_as-10           7709853               152.6 ns/op            96 B/op          3 allocs/op
Benchmark/typeassert
Benchmark/typeassert-10         14732881                72.35 ns/op           32 B/op          1 allocs/op
PASS
ok      errbench        3.712s

The fact that jscan.Validate returns jscan.Error gives you an option to avoid paying the extra cost when it's not justified.
 However, package jscan is deliberately designed to allow your code to remain allocation free.
Renaming named return

What about renaming the err - have we reached a consensus here, so I can open a PR?

Yes, this is possible. I don't think we need a PR for that since it's a trivial change I can do myself but if you want - go for it 🙂


[ISSUE] upgrade CI workflow will upgrade from the wrong helm chart versions

Describe the issue:
During the v10.0.0 helm chart release, we found that  the CI workflow that upgrades between a previous version of the helm chart to a newer version of the helm chart will actually upgrade between 2 identitcal versions of the helm chart:
https://github.com/camunda/camunda-platform-helm/actions/runs/8608080625/job/23629186365

Actual behavior:
k get -n camunda-platform-pr-1575-run-8608080625-sfx-y0ajxt-upgrade deployment integration-operate -o yaml | yq .metadata.labels

...
helm.sh/chart: camunda-platform-10.0.0

Also, heres helm list output
> helm list -n camunda-platform-pr-1575-run-8608080625-sfx-y0ajxt-upgrade
NAME       	NAMESPACE                                                 	REVISION	UPDATED                                	STATUS  	CHART                  	APP VERSION
integration	camunda-platform-pr-1575-run-8608080625-sfx-y0ajxt-upgrade	1       	2024-04-09 19:32:15.836004208 +0000 UTC	deployed	camunda-platform-10.0.0	8.4.x

Expected behavior:
Running the following kubectl command will output the latest minor/patch version from the previous major release. In this case,
(replace the namespace with your own)
k get -n camunda-platform-pr-1575-run-8608080625-sfx-y0ajxt-upgrade deployment integration-operate -o yaml | yq .metadata.labels

...
helm.sh/chart: camunda-platform-9.3.3

How to reproduce:

To observe this, run the upgrade CI workflow in a branch, or rerun the above linked job, and then run helm list to view the chart version that gets installed.
Logs:

Environment:
Please note: Without the following info, it's hard to resolve the issue and probably it will be closed.

Platform:
Helm CLI version:
Chart version:
Values file:

I think I misunderstood what the upgrade test was intended for.  This issue should be about how when executing this CI pipeline from a release branch,  for example, 8.3.  The helm chart will install v10.0.2 and then downgrade to 8.3.
The intended upgrade workflow  when it was written was to ensure that upgrading from the latest github release to whatever is in a PR succeeds without any breaking changes.  If we wanted to test upgrades from 8.2 to 8.3, that would be a separate pipeline.

This was fixed in: https://github.com/camunda/camunda-platform-helm/pull/1971
Now each Camunda chart version installs the latest chart in that version then try to upgrade it.
For example, this pipeline was a change for Camunda 8.4 and it installed the latest version at that time 9.3.5
https://github.com/camunda/camunda-platform-helm/actions/runs/9454906174/job/26043707636#step:15:43
then upgrade it from the PR branch:
https://github.com/camunda/camunda-platform-helm/actions/runs/9454906174/job/26043707636#step:18:53


Fixed typos and linting errors in Readme.md

While reviewing the doc I noticed some typos and corrected the linting errors.

Wonderful, Thank you @DarqueWarrior this is VERY useful.


Add KUBECONFIG back into tests

@ericvn catching up on this PR. This change may work for local, but may not work for environments where K8s is running. For example, running an individual functional test such as make test.integration.pilot.kube doesn't work correctly with this change.

https://github.com/istio/istio/issues/20413#issuecomment-578893791


ValueError: setting an array element with a sequence.

Hello, I was testing the finetune code but I got this error:

Traceback (most recent call last):██████████████████████████████████████████████████████████████████████| 30/30 [00:00<00:00, 51.26it/s]
File "bin/DNABERT_2/finetune/train.py", line 286, in
train()
File "bin/DNABERT_2/finetune/train.py", line 268, in train
trainer.train()
File "/miniconda/envs/dna/lib/python3.8/site-packages/transformers/trainer.py", line 1645, in train
return inner_training_loop(
File "/miniconda/envs/dna/lib/python3.8/site-packages/transformers/trainer.py", line 2020, in _inner_training_loop
self._maybe_log_save_evaluate(tr_loss, model, trial, epoch, ignore_keys_for_eval)
File "/miniconda/envs/dna/lib/python3.8/site-packages/transformers/trainer.py", line 2321, in _maybe_log_save_evaluate
metrics = self.evaluate(ignore_keys=ignore_keys_for_eval)
File "/miniconda/envs/dna/lib/python3.8/site-packages/transformers/trainer.py", line 3053, in evaluate
output = eval_loop(
File "/miniconda/envs/dna/lib/python3.8/site-packages/transformers/trainer.py", line 3353, in evaluation_loop
metrics = self.compute_metrics(EvalPrediction(predictions=all_preds, label_ids=all_labels))
File "bin/DNABERT_2/finetune/train.py", line 204, in compute_metrics
return calculate_metric_with_sklearn(logits, labels)
File "bin/DNABERT_2/finetune/train.py", line 190, in calculate_metric_with_sklearn
predictions = np.argmax(logits, axis=-1)
File "<array_function internals>", line 200, in argmax
File "/miniconda/envs/dna/lib/python3.8/site-packages/numpy/core/fromnumeric.py", line 1242, in argmax
return _wrapfunc(a, 'argmax', axis=axis, out=out, **kwds)
File "/miniconda/envs/dna/lib/python3.8/site-packages/numpy/core/fromnumeric.py", line 54, in _wrapfunc
return _wrapit(obj, method, *args, **kwds)
File "/miniconda/envs/dna/lib/python3.8/site-packages/numpy/core/fromnumeric.py", line 43, in _wrapit
result = getattr(asarray(obj), method)(*args, **kwds)
ValueError: setting an array element with a sequence. The requested array has an inhomogeneous shape after 2 dimensions. The detected shape was (2, 471) + inhomogeneous part.

I fixed the issue. If and when the author decides to merge my pull request, you wont face this issue anymore. @Zhihan1996

Thanks a lot!


fotacreate.exe not working on Windows 7

1. SDK version（SDK 版本）
{
SW_V2110_csdk
}

2. In what kind of operation problems appear, and how to reproduce the problem ?（什么样的操作步骤问题会出现，是否是稳定复现，如何复现问题？）
{

then I copy and paste MSVCP140.dll in fota folder after that I am getting

}

That't because Microsoft Visual C++ 2015 Redistributable is not installed on your windows. Install it from link bellow :
https://www.microsoft.com/en-us/download/details.aspx?id=53840
P.S : Close your tickets if they are solved.


go/importer: implement support for importer.Lookup

Missing functionality. Required for clients that store packages outside the implied file system structure.

Started.

We may have to leave this one for 1.7. The existing API based on the importer.Lookup type for flexibility is unfortunately inadequate, and at the same time unimplemented (a non-nil Lookup function was not supported). That is, it's not possible to have any users yet.
This opens the door to a backward-incompatible change. At the same time we don't want to design in a vacuum (as we did on short-notice before 1.5 in this case). Probably better to leave this for early 1.7 when we also get the new import data which should clear things up.

We have x/tools/gcimporter15 as a stop gap for now.
Due to the additional srdDir argument required for lookup because of vendoring, this API may have to change unfortunately.

We had to work around the lack of support for custom lookup functions for http://kythe.io/. I did this by the gross but expedient hack of depending on the internal package, but that prevents building with the go tool. Obviously we'd prefer to get rid of the hack.
What can I offer by way of assistance to get this working?

The API - as it was designed for 1.5 - didn't take into account vendoring (at that point considered an experiment introduced late). As a consequence, the current API (go/importer.Lookup function) may have to change. Since it cannot (Go 1 backward-compatibility promise) we need to come up with a new API. We didn't hurry this for 1.6 because we got to it too late and didn't want to prototype yet another possibly incomplete API.

The export data format is going to change for 1.7 (the new format is already implemented but for inlined exported functions). It shouldn't affect the API, but it might.

In terms of help: It would be good to have examples of concrete use cases, ideally with suggested minimal API. This would help clarify the final solution.
For what it's worth, we have x/tools/go/gcimporter15 which provides (I hope) all the individual pieces to  import from custom locations and it is based on the 1.5/1.6 std repo go/types. Does that help?

Thank you for the information about gcimporter15. If that works as I think, that might even let me get rid of the hacky dependency I took.
For Kythe, our goal is to be able to capture the files involved in building a Go package and to (later) re-run the type checker from those. An ideal API for our use case would be something like a function that takes a compiled package (say, a .a or .gcgox file) and returns whatever the go/types package needs to use it for type resolution—presumably a package name and some other internal state. We don't care at all about the internal format of this information as long as there's a way to get go/types to use it.
Having the API move around is fine, as long as it's a public API.

This is not going to happen for 1.7 since it does require additional API work. We have x/tools/go/gcimporter15 as a stop-gap, it is compatible with the latest import/export work.

What is the status here? Is this important for Go 1.8?

Also indirectly related to #14738.

From our perspective as outside consumers, if gcimporter15 (or a similar workaround) keeps working we can live with that. Our use case is still the same as described above.

I just found a work around to solve this problem.

copy /usr/local/go/src/go/internal/gcimporter to your own GOPATH. (like src/github.com/xxx/gcimporter18
Delete some code in Import function to pass in filename and id directly.(like func Import(packages map[string]*types.Package, id, filename string) (pkg *types.Package, err error))
Delete // import "go/internal/gcimporter"
call it like this gcimporter18.Import(map[string]*types.Package{},"xxx/myPackage","pkg/android_arm/xxx/myPackage.a")
The side effect is that this way only support one version of golang .
You need copy them from go1.7 go1.8 .

Note to self: See comments in @13222 when addressing this issue.

@alandonovan and @griesemer, I need importer.For to accept a non-nil lookup func in order to pass cmd/vet proper details about built packages from cmd/go. I did a basic implementation at C: 74354 that works well enough for my use in CL 74355. Does that seem like a reasonable approach?
In #13222 Alan wrote:

Either it should return the name of a .a file for a given package, or it should return a reader for the specific exportdata section within the file.

I don't understand this either-or. If returning the name of a .a file is OK, then why does the alternative have to be opening the .a file and positioning the reader into the middle of the .a file? I made lookup in my CL position the reader at the beginning of the .a file. gcimporter already knows how to find the export data inside a .a file, so I don't see any reason to duplicate that logic. (If needed gcimporter could also sniff the first few bytes to see if the input is a .a file or raw binary export data.)
One thing that's kind of missing from the Importer API is exposing the mapping step from import path in source code to canonical import path identifier, such as for example turning "foo" into "x/vendor/foo" when compiling "x" (and "x/vendor/foo" exists). I say kind of because I was able to make it work by wrapping the low-level gcimporter with a lookup for opening the expanded imports, and then I have my own Import method that handles the translation. I think this is a bit of an existence proof that the current Lookup API is good enough, even if it's not what we might do if starting over.

Your CL 74354 seems reasonable given that you do the translation to canonical import path identifier externally. This is basically where I stopped in the implementation.
Regarding Alan's comment: He might be thinking about export data that is stored in alternative forms, e.g. in a data base of sorts (e.g., which may be created nightly, by a crawl through a large repo, such as our Google-internal ones) where you may not want to the rest of the .a file around it (or at least before it).

He might be thinking about export data that is stored in alternative forms, e.g. in a data base of sorts (e.g., which may be created nightly, by a crawl through a large repo, such as our Google-internal ones) where you may not want to the rest of the .a file around it (or at least before it).
￼
Yes, that's exactly what I had in mind.

Right, I think it's fine to say that lookup can return an io.ReadCloser positioned at either the archive or the export data (within the archive or for something else). It just doesn't seem worth forcing all implementations to jump into the middle of the archive if that's the form they have easy access to.


x/website: Playground snippet fails at page load "expected 'package', found Loading"

What is the URL of the page with the issue?
https://go.dev/play/p/Z0qYLaaDzyL
What is your user agent?

[Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/101.0.4951.64 Safari/537.36](https://developers.whatismybrowser.com/useragents/parse/?analyse-my-user-agent=yes)

That was Chrome, but the same bug was observed with Firefox.
Screenshot

What did you do?

Open  https://go.dev/play/p/Z0qYLaaDzyL in my web browser
What did you expect to see?
No error
What did you see instead?
prog.go:1:1: expected 'package', found Loading

Go build failed.

More info
This does not seem specific to my browser (tried 2 browsers).
This does not seem specific to my snippet URL (tried other snippets, e.g. https://go.dev/play/p/2DClKGAIhmz ).
The problem occurs as soon as the web page loads, before I do any action.
Subsequently clicking the [Run] button works fine.

Thank you @ZekeLu


Update horizontal momentum (explicit) tendency term

rhoJ Weighted interpolation in horizontal tendency
S2.1.2 Equation (20)
Closes #1274
Longrun Build: https://buildkite.com/clima/climaatmos-longruns/builds/774

@trontrytel @szy21 This PR introduces behaviour changes to some of the TurbulenceConvection cases - Could you please confirm that the buildkite results are reasonable? If so, I'll update the ref_counter and mse_tables and rebase it.

Is there a longrun build for this PR? Could you post the plots?

Temperature

Potential Temperature

Zonal Vel

Thanks. I checked the moist baroclinic wave and moist held suarez in the ci and they look good to me. Anna can help check the EDMF cases. Please make sure to go over all the tests in ci to make sure the results look close enough to the current main.

@akshaysridharl, looks like just some MSE table updates are necessary here? Are we ready for this to get in? cc: @szy21

The following EDMF cases appear to have outputs that require a second review :
(1) SCM EDMF Bomex Default
(2) SCM EDMF Bomex Constant Entrainment
(3) SCM EDMF Bomex (JFNK + IMEX)
With these checked, the regression reference counter needs to be updated, then this is ready to be merged.

The differences in the EDMF cases look small, but I'm not sure if I'm qualified to review EDMF changes. @trontrytel can help.

bors r+

bors r+

bors r+

bors r-

bors r+


Add touch events for mobile devices

@dreyescat  I added some modifications to handle touch events (TouchMove, and TouchEnd) using pre-existing functionality.

@dreyescat please have a review and rebase to master if it okay.

That's nice! It allows to rate sliding your finger :clap:

Merged and published in v0.8.0.

I just tried this in v0.9.0 and touch on mobile doesn't seem to work yet. I am wondering what I am missing.

I just tried this in v0.9.0 and touch on mobile doesn't seem to work yet. I am wondering what I am missing.


Setup fuzzing

It would be good to ensure that the parser doesn't fail on bad inputs. Fuzzing would be a good approach to mitigating this.

Implemented in 48178a16f0b4a4c7aecfb0de1aa61fa98a34256a and 97f6068ece5098b391d677152fb41b21a84e40fe using cargo fuzz. Was pretty painless and hasn't turned up any issues yet!


Does this need consul to work?

Is it possible to run this with an nomad installation without consul?

It is not. That said, nomad has an events api as of 1.0.0, so that may be more useful to you than this project if consul usage is out.
Hope that helps.

It is not. That said, nomad has an events api as of 1.0.0, so that may be more useful to you than this project if consul usage is out.
Hope that helps.


add vearch to vector store

[ ] New feature (non-breaking change which adds functionality)

[ ] Added new notebook (that tests end-to-end)

[ ] I stared at the code and made sure it makes sense

[ ] I have performed a self-review of my own code

[ ] I have commented my code, particularly in hard-to-understand areas

@zhanghexian can you follow the new contribution guide? Specifically, you should create a package in llama-index-integrations/vector_stores instead of modifying legacy
https://docs.llamaindex.ai/en/stable/contributing/contributing.html#creating-a-new-integration-package

Sorry, I don't quite understand how to package based on my submitted code, just execute this command:
cd ./llama-index-integrations/llms
llamaindex-cli new-package --kind "llms" --name "vearch"?
I'm very sorry to trouble you!

I'm very sorry to trouble you. Could you be more specific? I still don't know how to operate the document when I read it.

@zhanghexian you can take a look at other vector store integrations for an idea on structure
to create a boostrapped folder
cd llama-index-integrations/vector_stores
llamaindex-cli new-package --kind "vector_stores" --name "vearch"

We want to add the integration there, and not modify anything in llama-index-legacy

I am very sorry to trouble you, may I ask which version of llama-index can run this command(llamaindex-cli new-package --kind "vector_stores" --name "vearch")? The latest version of llama-index requires onnxruntime>1.17.0, but there is no package of this version on the company Intranet at present. I tried a lower version of llama-index, but couldn't run this command: llamaindex-cli

@zhanghexian which python version are you on? It will work on python 3.11 version.

Now I have the python environment set to 3.11, but I still have the same problem, I tried to change the download  source and install the .whl file directly, but failed!

The problem is that when llama-index=0.10.15 is installing, the llama-index-cli version is incompatible with the onnxruntime version, and the onnxruntimet needs to be installed.>=1,17.0 Please tell me which version of llama-index is suitable to install,thanks!

now i commit it use llamaindex-cli,please check thanks！

thanks,fixed! please check!

hello,i saw the sigh that said some conficts in .md file ,Do I need to make any changes? I'm sorry to trouble you, and when can I see the code I submitted in the project.thanks!


Testing

Hey  @seanpmaxwell,
Awesome piece of code ya have here. We're using it in Production and it's all great. We're trying to figure out how to test the controllers/middlewares with Jest. Any good advice? So far the only way I can do it is make the method public and mock a request/response but that doesn't do any good for the Middleware decorator.
Let me know if I can help with a PR if you have any ideas.
Thanks,
Brandon.

I've never used Jest on the back-end so I can't advise on it. I'm a huge fan of the Jasmine/SuperTest combo though. It's pretty straightforward. You just need to add the instance of express the to supertest agent method. I wrote an article on how to do this:  https://levelup.gitconnected.com/setting-up-a-full-stack-typescript-application-featuring-express-and-react-ccfe07f2ea47. Scroll down to the section on unit-testing.

@seanpmaxwell Thanks! That looks like it's super useful for end-to-end testing. I'm looking for more just shallow unit testing. The test server concept might help me with that though. Let me give it another try.

No this IS for unit-testing not e2e.

Thanks @seanpmaxwell this helps a ton.


Drive Stats show high Max Speeds that are incorrect

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
When viewing the Drive Stats page, my Max Speed values are unusually high. They are definitely incorrect. I have not exceeded 90MPH ever and they are showing as 146, 126 and 111.
I have looked in the Drives section and no drives go above 88.
Is there any way I can check or fix this issue?
Expected Behavior
Accurate MAx mileage in Drive Stats page.
Steps To Reproduce

Open Drive Stats Dashboard.
View Max Speeds (higher than expected).
Open Drives and sort by Max speed column. Max values do not match.

Relevant log output
No logs seem relevant.

Screenshots

Additional data
No response
Type of installation
Docker
Version
Version	1.31.1

Thanks for reporting. The conversion from km to miles is missing in the new introduced max speed, which is already fixed in #4338 and will be included in next release.

Thank you.


[cfe] Implement FutureOr related rules of least upper bound

This is the front end specific issue for #43719, which has the details.

Proposed fix: https://dart-review.googlesource.com/c/sdk/+/166639.


ClickHouse Error: year 54725 is out of range

Whatever query I run in SQL Lab I get the following error:
ClickHouse Error
year 54725 is out of range

This may be triggered by:
Issue 1002 - The database returned an unexpected error.

How to reproduce the bug

Go to SQL -> SQL Lab
Choose any clickhouse database
Write any query, for example: select version(), select 1, select now(), or select 'hello, world'
See error

Expected results
A query should run successfully.
Actual results
I get the following error:
ClickHouse Error
year 54725 is out of range

This may be triggered by:
Issue 1002 - The database returned an unexpected error.

Screenshots

Environment

browser type and version: Version 1.44.105 Chromium: 106.0.5249.91 (Official Build) (x86_64)
superset version: apache/superset:31895f412eba60e274c7158a39cf0a8455ffd671 (Docker image)
python version: 3.8.13
node.js version: N/A since I am using official Docker image
any feature flags active:FEATURE_FLAGS = {
    "ALERT_REPORTS": True,
    "DASHBOARD_RBAC": True,
    "ENABLE_TEMPLATE_PROCESSING": True,
    "SCHEDULED_QUERIES": True
}

Checklist

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any. Logs are available here.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

ClickHouse version: <IP_ADDRESS>
Using clickhouse-sqlalchemy==0.2.2

Hi @hermanzdosilovic, this issue has been resoved by https://github.com/apache/superset/pull/21667, so I close it. Feel free to reopen this one if you have the same issue yet.


goverlay: 0.7 → 0.7.1

Motivation for this change
Update to the latest version: https://github.com/benjamimgois/goverlay/releases/tag/0.7.1
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 150920 run on x86_64-linux 1

1 package built:

goverlay


fix(event-handler): return dict on missing multi_value_headers

Issue number: #3823
Summary
Addresses regression introduced in 2.33 when running Event Handler APIs locally when multiValueHeaders isn't present.
Changes

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Checklist
If your change doesn't seem to apply, please leave them unchecked.

[x] Meet tenets criteria
[x] I have performed a self-review of this change
[x] Changes have been tested
[x] Changes are documented
[x] PR title follows conventional commit semantics

Is this a breaking change?
RFC issue number:
Checklist:

[ ] Migration process documented
[ ] Implement warnings (if it can live side by side)

Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e14e768) 96.38% compared to head (c944e3b) 96.38%.
Report is 77 commits behind head on develop.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3824   +/-   ##
========================================
  Coverage    96.38%   96.38%
========================================
  Files          214      214
  Lines        10030    10093   +63
  Branches      1846     1866   +20
========================================
+ Hits          9667     9728   +61
- Misses         259      260    +1
- Partials       104      105    +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Open VSX Listing: Signing the Publisher Agreement

Thank you for being part of the Open VSX community by adding your extensions to the Open VSX Registry. Please note that the service was recently transferred to the Eclipse Foundation and urgent action on your part is needed so we can continue to list your extensions. To ensure uninterrupted service, please sign the Eclipse Publisher Agreement on or before January 8, 2021. If not signed by that date, your extensions will be delisted and will no longer appear on the site nor be available via the API. If you sign at a later date, your extensions will then be re-activated. The signing process is explained in the Wiki (steps 1 and 2).
Please also note that all extensions MUST have a license in order to be listed.
More details are in these recent blog posts:
https://blogs.eclipse.org/post/brian-king/open-vsx-registry-under-new-management
https://blogs.eclipse.org/post/brian-king/new-era-open-vsx-registry
Today, there’s growing momentum around open source tools and technologies that support Visual Studio (VS) Code extensions. Leading global organizations are adopting these tools and technologies. This momentum has spurred demand for a marketplace without restrictions and limitations. Thanks for joining us on this journey as we continue to build the Open VSX community. We look forward to continued innovation from you in 2021!

Thanks, we will look into that.

Thanks, we will look into that.

Thanks @boaz-codota , any updates? Let me know if you have questions.

Thanks @boaz-codota , any updates? Let me know if you have questions.

@brianking Thanks for reaching out to us. We've signed the agreement.

@brianking Thanks for reaching out to us. We've signed the agreement.


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_d7xy44ri1u/clone/recipe/meta.yaml:15: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_d7xy44ri1u/clone/recipe/meta.yaml:20: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_d7xy44ri1u/clone/recipe/meta.yaml:34: missing_pip_check: For pypi packages, pip check should be present in the test commands
Errors were found


ARcore 2.4.0 apk

Is there a ARcore version of the 2.4.0 client? I know that the 2.3.1 has it but that version crashes on my note 4. Even tho the AR tracking won't work I need the feature that enables you to see the rear camera which the normal version doesn't have. Link the apk below if it exists.

I will try to clone and build the arcore.zip and see if its 2.4.0


client for dotNet

It is posible? we develop with c# and we want use this product.

It's definitely possible but I won't be able to build or test it because I don't have a C# development environment.  Review the https://github.com/SquareSquash/web/blob/master/doc/MAKING_A_CLIENT_LIBRARY.md document to learn how to add your own.

I highly recommend expending the effort.
The API is pretty straight-forward, and the web

From an end-user:
I highly recommend expending the effort (and I'd love to see the result).
The API is pretty straight-forward, and the web server is extremely well-written, and clear.
I'm not so keen on the design-choices of the Ruby client, but ultimately:  meh, it works fine.
At my previous employer, we were on the fence, and thinking seriously about paying for an on-premises solution from one of the other popular exception-handling systems, but on review/hand-over, we realised how cool Squash actually is;  partly because we have full-access to the code and we can do whatever we need with it, but also because we can have 100% control of what can be extremely sensitive data, especially when you take into account certain country's data-protection legislation.

FYI: I may be able to offer some minimal support, having done both C# and Ruby dev, but I don't currently have access to Windows or a C# env.
If that changes, I'll be well-interested in helping out.


save and load specific keras/tensorflow layers

Please make sure that this is a feature request. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:feature_template
System information

TensorFlow version (you are using): 2.4.1
Are you willing to contribute it (Yes/No): Yes

Describe the feature and the current behavior/state.
extract layer of one model with weights and use in another model. For example, using an embedding layer weights of one transformer model in another transformer model. Compared to glove embeddings and word2vec embeddings, it's difficult to map the embedding weights of a transformer.
Will this change the current api? How?
Most probably no.
Who will benefit with this feature?
those who need to export only embeddings layer (or any other layer) and use in another model.
Any Other info.

Closing this. exported the weights in pickle file. Thanks @bhack


[CHANGE]+mimetype/here

The mimetype affected
Please enter the mimetype here
The change to make
Add/remove/change description or link, etc
Supporting link
A link to somewhere that authoritatively says why this change should be made


Fixes

Thinking out loud: we should add a cascade for piecesFilters just for consistency's sake. Maybe also rename it pieceFilters, with a bc alias.

Yeah, you're right


[#4247] improvement(docs, catalog-hadoop): Add docs about multiple-level authentication for Hadoop catalog.

What changes were proposed in this pull request?
Add some details about multiple-level authentication for the Hadoop catalog.
Why are the changes needed?
To better serve our customers.
Fix: #4247
Does this PR introduce any user-facing change?
N/A.
How was this patch tested?
N/A.

@qqqttt123 @jerryshao
Could you please help me review? Thank you.

@jerqi
Please help to take a look again

It's the best to have the abstraction like
class UserContext {
     doAs();
}

class SimpleUserContext {
}

class KerberosUserContext {
}

It's the best to have the abstraction like
class UserContext {
     UserGroupInformation getUGI();
     doAs();
}

class SimpleUserContext implement UserContext {
}

class KerberosUserContext implement UserContext {
}

I'm okay with it, how to handle impersonation?  Add a property like impersonation to keep the value.
Another point, by this meaning, is that we still need to use a map to calculate the real value of impersonation for a schema or fileset? The way you propose is a wapper that wapper UGI and doAs operation.

It's the best to have the abstraction like
class UserContext {
     UserGroupInformation getUGI();
     doAs();
}

class SimpleUserContext implement UserContext {
}

class KerberosUserContext implement UserContext {
}

I'm okay with it, how to handle impersonation? Add a property like impersonation to keep the value?
Another point, by this meaning, is that we still need to use a map to calculate the real value of impersonation for a schema or fileset? The way you propose is a warpper that warps UGI and doAs operation.

impersonation should be a field of UserContext.

It's the best to have the abstraction like
class UserContext {
     UserGroupInformation getUGI();
     doAs();
}

class SimpleUserContext implement UserContext {
}

class KerberosUserContext implement UserContext {
}

I'm okay with it, how to handle impersonation? Add a property like impersonation to keep the value?
Another point, by this meaning, is that we still need to use a map to calculate the real value of impersonation for a schema or fileset? The way you propose is a warpper that warps UGI and doAs operation.

impersonation should be a field of UserContext.

I have reviewed it and am hesitant to make changes based on your comment.
There is no difference between SimpleUserContext and KerberosUserContext as they both utilize UserGroupInforamion#doAs to perform actions.
To differentiate whether we will use Kerberos authentication or not for entities, I need to use a map to keep to the relation like Map<NameIdentifer, Boolean> identToKerberos to represent whether the entity it represents uses Kerberos or not, then I need to calculate the UGI.  I don't think it 's as convenient as the current implementation.

It's the best to have the abstraction like
class UserContext {
     UserGroupInformation getUGI();
     doAs();
}

class SimpleUserContext implement UserContext {
}

class KerberosUserContext implement UserContext {
}

I'm okay with it, how to handle impersonation? Add a property like impersonation to keep the value?
Another point, by this meaning, is that we still need to use a map to calculate the real value of impersonation for a schema or fileset? The way you propose is a warpper that warps UGI and doAs operation.

impersonation should be a field of UserContext.

I have reviewed it and am hesitant to make changes based on your comment.
There is no difference between SimpleUserContext and KerberosUserContext as they both utilize UserGroupInforamion#doAs to perform actions. To differentiate whether we will use Kerberos authentication or not for entities, I need to use a map to keep to the relation like Map<NameIdentifer, Boolean> identToKerberos to represent whether the entity it represents uses Kerberos or not, then I need to calculate the UGI. I don't think it 's as convenient as the current implementation.

SimpleUserContext doesn't have keytab and realm, only contains user and kerberos name. KerberosUserContext has keytab and realm.


docs: external dependecies/outputs

Fixed by https://github.com/iterative/dvc.org/pull/62/commits/6f3621f1802ef27b52d2380a639600aa5619feca


flaky ffi_2/function_structs_by_value_generated_leaf_test/1 turned timeout

on dartk-win-debug-ia32
--- Command "vm" (took 02:00.000019s):
set DART_CONFIGURATION=DebugIA32 & set DART_SUPPRESS_WER=1 & set DART_CRASHPAD_HANDLER=C:\b\s\w\ir\out\DebugIA32\crashpad_handler.exe & out\DebugIA32\dart.exe --deterministic --optimization-counter-threshold=5 -Dtest_runner.configuration=dartk-win-debug-ia32 --ignore-unrecognized-flags --packages=C:\b\s\w\ir\.packages C:\b\s\w\ir\tests\ffi_2\function_structs_by_value_generated_leaf_test.dart

exit code:
null

diagnostics:
win_sdk_path not found

--- Re-run this test:
python3 tools/test.py -n dartk-win-debug-ia32 ffi_2/function_structs_by_value_generated_leaf_test/1

Same happened on vm-kernel-nnbd-linux-release-ia32.
https://dart-ci.appspot.com/log/vm-kernel-nnbd-linux-release-ia32/dartk-strong-linux-release-ia32/680/ffi/function_structs_by_value_generated_leaf_test/1

Also, multiple tests turned from flaky to timeout on vm-kernel-win-debug-ia32:
ffi_2/function_callbacks_very_many_test/0
ffi_2/null_test/1
ffi_2/variance_function_test/1

and from Pass to Timeout:
service_2/pause_on_unhandled_async_exceptions2_test/dds_1

In addition, vm-kernel-optcounter-threshold-linux-release-ia32 is timing out on multiple shards.
It looks like IA32 became slower.
Possible suspect: 1bff4bead9297d2d6e545e3ea7804bdb5a08a305
/cc @rmacnak-google

Just happened again on dartk-weak-asserts-linux-debug-ia32, ffi/function_structs_by_value_generated_leaf_test/1, after the workaround was submitted. But the timeout for that test was already increased in that CL. Maybe the timeout needs to be increased further?

Timeout was not increased, that change increased --optimization-counter-threshold to 20 to prevent too many unnecessary optimized compilations in kernel service. We can try to further increase --optimization-counter-threshold, but we also need to increase number of iterations in the test (to make sure optimization happens for all tested functions), which may slow down the test.
Maybe this time we should just split this test into multiple tests as it is very huge.


kops: 1.20.1 -> 1.20.2

Motivation for this change
Update to latest version.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[x] (Package updates) Added a release notes entry if the change is major or breaking
[x] (Module updates) Added a release notes entry if the change is significant
[x] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 128801 at 05df2bdc run on x86_64-linux 1

1 package failed to build:

kops (kops_1_20)

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

Apparently something is off with my machine, so if someone else could test this and/or fix the hash, it would be greatly appreciated.

@ofborg eval


Fix NumericInput on BigNumber.DEBUG

Background
Here is the definition of BigNumber.DEBUG from the documentation
/**
     * To aid in debugging, if a `BigNumber.DEBUG` property is `true` then an error will be thrown
     * if the BigNumber constructor receives an invalid `BigNumber.Value`, or if `BigNumber.isBigNumber`
     * receives a BigNumber instance that is malformed.
     *
     * ```ts
     * // No error, and BigNumber NaN is returned.
     * new BigNumber('blurgh')    // 'NaN'
     * new BigNumber(9, 2)        // 'NaN'
     * BigNumber.DEBUG = true
     * new BigNumber('blurgh')    // '[BigNumber Error] Not a number'
     * new BigNumber(9, 2)        // '[BigNumber Error] Not a base 2 number'
     * ```
     *
     * An error will also be thrown if a `BigNumber.Value` is of type number with more than 15
     * significant digits, as calling `toString` or `valueOf` on such numbers may not result
     * in the intended value.
     *
     * ```ts
     * console.log(823456789123456.3)       //<PHONE_NUMBER>23456.2
     * // No error, and the returned BigNumber does not have the same value as the number literal.
     * new BigNumber(823456789123456.3)     // '823456789123456.2'
     * BigNumber.DEBUG = true
     * new BigNumber(823456789123456.3)
     * // '[BigNumber Error] Number primitive has more than 15 significant digits'
     * ```
     *
     * Check that a BigNumber instance is well-formed:
     *
     * ```ts
     * x = new BigNumber(10)
     *
     * BigNumber.DEBUG = false
     * // Change x.c to an illegitimate value.
     * x.c = NaN
     * // No error, as BigNumber.DEBUG is false.
     * BigNumber.isBigNumber(x)    // true
     *
     * BigNumber.DEBUG = true
     * BigNumber.isBigNumber(x)    // '[BigNumber Error] Invalid BigNumber'
     * ```
     */

Problem
new BigNumber(null) throws an error when BigNumber.DEBUG is set to true, and yet react-polymorph currently depends on this behavior inside the NumericInput component.
Impact is that programs that have BigNumber.DEBUG set to true can't use react-polymorph's NumericInput.
Solution
To fix this, I handle all the null/undefined cases explicitly
I also added BigNumber.DEBUG=true to the test file to make sure this error gets caught in the future

Works great @SebastienGllmt, thanks! 🙏

@SebastienGllmt I published 0.9.8-rc.3 which contains your fix + my bug fix for an issue I just discovered after merging your PR 😉


How to remove stop words in TextBlobs?

I am doing text classification using TextBlob. I am giving the training dataset through a JSON file. But I'm finding difficulty in removing stop words. Please help.
tb.txt

Same problem here, let me look into the documentation once more.

@srinidhibhat
Try using the following :
from textblob import TextBlob
from textblob import Blobber
import nltk
nltk.download('stopwords')
from nltk.corpus import stopwords

Let's make our stopset:
stop_words = set(['the', 'and', 'a' ,'an'])
Let's say we have the following string
b="the quick brown fox jumped over a lazy dog.  "
Converting our string b to set of words and subtracting the stopset from it
sub_stopwords =  set(blob.words) - stopset
Now we prepare our output string from this set
final_string=' '
for word in sub_stopwords:
    final_string=final_string + word +' '
print final_string

Output quick brown lazy fox jumped


Terminating Pod shows up as Pending Status

Describe the bug
Pod Status is pending but when I use kubectl or k9s the pod is terminating.
To Reproduce
It is complicated to reproduce. I deployed an app called Admiralty.  The flannel pod was stuck in pending. I modified the selector to exclude the node.  K8s identified the pod for termination.  The pod is not stuck in terminating.  I use Lens to look at the pod and it is in Pending.
Using Lens 4 with K8s 1.19.3. Also tested with k9s 0.24.2

Sorry, this is actually working correctly.  Difference between status and phase.


VideoFrameSequence as a potential alternative to ImageSequence, Optional Cache Location, added repeat methods

ImageSequence seems to perform oddly in some cases, its implementation is overcomplicating the actual expected features. It produces issues when the fps does not match and requires users to calculate durations etc. I've tried using it and it creates gaps between videos with missing frames etc.
VideoFrameSequence is a simpler implementation that solves all the said problems, it's also made to work well with mv.repeat and its new features.
Allow users to specify the location of disk-cache for compositions. It does seem like the library does not properly dispose disk-caches after processing, so I just made a quick fix allowing users to specify the location of the disk cache so they can dispose that folder when done rendering/
Added a parameter to change the repeat method. The standard method of replaying the video is now the "loop" method, default parameter when calling mv.repeat. However, users can now also use "bounce" to repeat the video backwards after it has completed. (then forward -> backwards -> forward etc.)

Thank you for your PR!
This excellent PR resolves multiple issues, so it might take some time to review. However, I will thoroughly read it at the end of the workday. Just wanted to let you know for now.

+1


Fix spelling of represents in a couple places

Codecov Report

Merging #405 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master     #405   +/-   ##
=======================================
  Coverage   17.53%   17.53%
=======================================
  Files         211      211
  Lines      122570   122570
  Branches    11801    11801
=======================================
  Hits        21488    21488
  Misses     100230   100230
  Partials      852      852

Flag
Coverage Δ

#2017
17.53% <0%> (ø)
:arrow_up:

#Debug
17.53% <0%> (ø)
:arrow_up:

Impacted Files
Coverage Δ

src/PerfView/StackViewer/PerfDataGrid.xaml
100% <ø> (ø)
:arrow_up:

.../TraceEvent/Computers/StartStopActivityComputer.cs
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ebf015...5f44717. Read the comment docs.

LGTM


optionally keep the track open while unpublishing.

Closes #81

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your<EMAIL_ADDRESS>seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

PR for issue #82

hey @krishnakumarp, we've discussed this one and will resolve the issue in a different way. stay tuned.


Placeholder issue for list of suggested 3D term additions

Here's a list generated from the Darwin Core Hour discussion on the topic of 3D terms:
https://github.com/tdwg/ac/blob/master/3d/proposed-3d-metadata-terms-from-dwc-hour.csv
Also, I wanted to stash the link to the paper on the subject of open digital 3D morphology data: http://rspb.royalsocietypublishing.org/content/284/1852/20170194

Information in this issue is under consideration by the 3D Task Group, so the issue does not need to remain open.


hls: max fragment length reached

Hello
I saw another ticket with such a problem and I can say that it remains for us too. Probably I can say more details about it.
Source is fetched with pull, like this:
    application streams {
        live on;
        pull rtmp://server:1936/stream/channel name=mychannel static;
    }

From the start it works just fine but after a few hours it starts filling log with such error.
The main problem is what nginx rtmp module starts writing all information to the same segment and it grows until fills all available space on file system. Meanwhile manifest file  (index.m3u8) is deleted. Of course we created tmpfs and hls_path follows to it.
We tested on different rtmp sources and problem remains after some time. Probably it is some case of bug with reconnecting feature or something. And I can't say those sources were unstable or something like that.
Is there anything can be done about this?
Thank you.

I comment in post my problem and solutions https://github.com/arut/nginx-rtmp-module/issues/568


Add static version of queue

I was looking into the queue API and I noticed that it works off the heap. It should be possible to implement this as static?
https://github.com/raspberrypi/pico-sdk/blob/6a7db34ff63345a7badec79ebea3aaef1712f374/src/common/pico_util/queue.c#L11-L18
It is a little more risky, but for people that do not want to use heap they are probably stuck with that.
void static_queue_init_with_spinlock(queue_t *q, uint element_size, uint element_count, uint spinlock_num, uint8_t *storage) {
    lock_init(&q->core, spinlock_num);
    q->data = storage;
    q->element_count = (uint16_t)element_count;
    q->element_size = (uint16_t)element_size;
    q->wptr = 0;
    q->rptr = 0;
}

Yes, that would be good

In your proposed new function, it might also be worth passing in a storage_size parameter, and then asserting that storage_size >= ((element_count + 1) * element_size) ?

Forgot about the assert. I had considered it but did not see the point in changing the return signature.
Note there is no nullptr check.


Update and release OTel agent integration distro 0.14.0

This issue is blocked by: https://github.com/newrelic/opentelemetry-exporter-java/issues/146
This project (newrelic-opentelemetry-integration-java) needs to be updated to use the OTel dependencies listed below and we need to release version 0.14.0 of this artifact.
The newrelic-opentelemetry-javaagent module needs to be updated to use the OTel java agent dependency:

io.opentelemetry.javaagent:opentelemetry-javaagent:0.14.0

The custom module needs to be updated to use the New Relic OTel exporter dependencies:

com.newrelic.telemetry:opentelemetry-exporters-newrelic:0.14.0
com.newrelic.telemetry:opentelemetry-exporters-newrelic-auto:0.14.0

The smoke-tests module needs to be updated to use the OTel dependencies:

io.opentelemetry:opentelemetry-proto:0.14.1
io.opentelemetry:opentelemetry-api:0.14.1

Steps:

Update the dependencies used in the newrelic-opentelemetry-javaagent and custom modules. Both can be done here.
Update the dependencies used in the smoke-tests module.
Update the CHANGELOG
Cut a new Github release

Success criteria:

This project (newrelic-opentelemetry-integration-java) builds with the OTel artifacts described above
Before release, verify that the version of this artifact correctly matches the version to be released
A new newrelic-opentelemetry-integration-java artifact is released and published to maven
The CHANGELOG is updated
After release, submit a PR to bump the snapshot version for the next release
All tests pass and the agent distro has been verified to work with the example application

We're not going to make any more updates to the exporter. We are providing an OTLP endpoint that will support traces, and (shortly) metrics. OR, another alternative is to use the OpenTelemetry Collector.
We were maintaining our exporters until a New Relic OTLP endpoint was ready. We've reached a point that is close enough to allow customers to migrate to that preferred solution (for use cases where customers do not want to deploy a Collector) rather than adopting this temporary stop-gap.


<EMAIL_ADDRESS>(#2446)

PR for #2446
Release: https://github.com/maxmind/libmaxminddb/releases/tag/1.10.0
Used by:

https://github.com/envoyproxy/envoy

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (libmaxminddb) have been updated in this PR. Please review the changes.


"The MaybeSource is empty" error occurs with persister

In README.md, there's a sample code contains:
           .persister(new Persister<BufferedSource>() {
             @Override
             public Maybe<BufferedSource> read(Integer key) {
               if (dataIsCached) {
                 return Observable.fromCallable(() -> userImplementedCache.get(key));
               } else {
                 return Observable.**empty**();
               }
             }

With this reference code,  I wrote my own persister like:
StoreBuilder.
    .key<ApiKey<API, Any>, Any>()
    .persister(object : Persister<Any, ApiKey<API, Any>> {
        override fun read(key: ApiKey<API, Any>): Maybe<Any> {
            if (key.haveLocal()) {
                return key.local()
            }
            // Nothing is saved for the key, returns empty
            return Maybe.empty()
        }
        ....
    })
    .fetcher({ it.request(api).computation() })
    .open()

and then i made a request like
store.fetch(key)
But it occurs java.util.NoSuchElementException: The MaybeSource is empty
I followed inside RealInternalStore.java,
there's weird code in RealInternalStore.response()
    @Nonnull
    Single<Parsed> response(@Nonnull final Key key) {
        return fetcher()
                ...
                        .flatMap(aBoolean -> readDisk(key).toSingle()))
                ...

readDisk() doesn't have code for handling empty state,
readDisk(key).toSingle() can occurs NoSuchElementException
How can I return "empty, there's no saved response" state in Persister.read()?

I'm confused how it can be empty when you do  store.fetch.  Fetch should get a new element from your fetcher save it to disk and then return. Could you post a failing test or sample please.

@digitalbuddha What if what the fetch result is empty from very beginning?
What we normally would do is get and the get would fetch when it gets nothing (that's Maybe.empty()) from persister. That what the API designed for.
Now,  what if we could fetch nothing from network etc. (of course there's a response but nothing we could write into persister and use case like this is not rare), the fetch would let persister write (which would write nothing) and read( also read nothing just like when it get) and error is coming?
One may say hey, why don't you return a empty object (not null) from persister for the situation like this. If we do that, when we get, we get a empty object and that's all, we have to do the "get then fetch" ourselves which should be done by store itself.
So the problem is why should we assume that fetch could always get new stuff and not empty?

I have same problem - how to distinguish between "not found in cache" and "not found on API" (both should return list of items) in persister's read method without throwing this excepion.

Thanks for explaining! We are working on store4 and will make an elegant solution. I'll post possible solutions here. Open to suggestions as well


Feature/#571 more button for replays

The reformatter was on maybe the setting are wrong

I tried again, if it does not work I might need your help getting my reformatter correctly set


Add a simple home page to the dashboard

We can start with a very simple home page. Later we'll add more information, metrics, etc.

https://v0.dev/chat/MjOv5O0HwV9?b=b_vwIdC2Dh2Dd
The sidebar (#594) should also show up.

Would it be alright if I take this up?

I improved the UI little bit, like added logo etc and aligned properly.
PR: #616


Added type annotations and fixed docstrings.

Description
Added type annotations to public interfaces and fixed docstrings.
The changes have been verified by pydocstyle and pyright.
Fixes #14.
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

@pseudo-rnd-thoughts I removed requirements.txt. Please let me know if anything else should be changed.


Namespace'd model support?

Does this library work with namespace'd models? I've been having issues doing so. Below is a simplified version of my use case:
Migration:
   create_table :route_locations do |t|
      t.timestamps
      t.actable as: :locatable
      t.string :longitude
      t.string :latitude
    end

    # child of `routes_locations`
    create_table :route_named_locations do |t|
      t.string :name
    end

Models:
class Route::Location < ApplicationRecord
  actable as: :locatable
end

class Route::NamedLocation < ApplicationRecord
  acts_as :location, as: :locatable
end

When running Route::NamedLocation.all via rails console I get the following error:
NameError: uninitialized constant Location which makes sense since I need Route::Location not just Location but I am unable to define it with the namespace. I've tried the following:

acts_as :route_location, as: :locatable

NameError: uninitialized constant RouteLocation

acts_as Route::Location, as: :locatable

TypeError: Route::Location(...) is not a symbol nor a string

acts_as 'Route::Location', as: :locatable

ArgumentError: association names must be a Symbol

acts_as :'Route::Location', as: :locatable

NameError: undefined local variable or method 'build_Route' for #<Module:0x000000035bde18>

I am running Rails 5.0.2, Ruby 2.3.3
It seems doing the following gets me closer, but I still run into another error:
class Route::Location < ApplicationRecord
  actable as: :locatable
end

class Route::NamedLocation < ApplicationRecord
  acts_as :location, as: :locatable, class_name: Route::Location.name
end

Running Route::NamedLocation.all runs just fine, but creating a new record Route::NamedLocation.create(name: 'foo') fails with:
ActiveRecord::InverseOfAssociationNotFoundError: Could not find the inverse association for locatable ("route/location" in Route::NamedLocation)
According to Rails documentation for the inverse_of property for has_one relationships:

Does not work in combination with :through or :as options

Okay, I seem to have this working. For anyone finding this thread later (maybe add to the README?):
Migration:
   create_table :route_locations do |t|
      t.timestamps
      t.actable as: :locatable
      t.string :longitude
      t.string :latitude
    end

    # child of `routes_locations`
    create_table :route_named_locations do |t|
      t.string :name
    end

Models:
class Route::Location < ApplicationRecord
  actable as: :locatable, inverse_of: :location
end

class Route::NamedLocation < ApplicationRecord
  acts_as :location, as: :locatable, class_name: Route::Location.name
end

Thanks!

class Route::Location < ApplicationRecord
  actable inverse_of: :location
end

is not this limited? what should I pass to 'inverse_of' if there's multiple model with 'acts_as' that tried to 'inherit' from the same parent?


How to put feature files and step files in separate folders

Hi all, I am trying to set up my tests so that my files are organised as follows:
- testing
    - features
        - app.feature
    - steps
        - common
            - main.ts
        - app
            - main.ts

In package.json, I have put
"cypress-cucumber-preprocessor": {
        "commonPath": "testing/steps/common",
        "nonGlobalStepDefinitions": true,
        "stepDefinitions": "testing/steps"
    }

however my step files are not being picked up. I am still getting Error: Step implementation missing....
If I move the app folder under features then it will work, so it feels like stepDefinitions is not having any effect. Has anyone had any success having feature files and step files in separate folders?

how about not use nonGlobalStepDefinitions ?
switch to to false or remove that completely

Please give it a try and reopen if that's not it.

Thanks @lgandecki. Yes, that will work but I was hoping to make use of the other advantages of nonGlobalStepDefinitions, e.g. allowing identically-named steps in different feature files to be defined separately.
Is there any way to make this work using nonGlobalStepDefinitions or is it currently not supported?