Move BinderSpawner into a mixin

Related to https://github.com/jupyterhub/binderhub/pull/1353#pullrequestreview-749113043
Moving this into a mixin will reduce duplication if we support multiple spawners. There are several problems though:

Multiple inheritance with multiple classes using traitlets (no idea if it works properly or not... though it seemed to work with PodmanSpawner without auth)
This doesn't work anyway with our current setup because we're depending on the Z2JH chart whose hub image only includes KubeSpawner, it doesn't include any of the BinderHub python files, so we can't import the mixin.

Thanks for reviewing!
I've added some FIXME comments.
Note the BinderHub code base doesn't care about the spawner code at all, it's only used by JupyterHub, but we're currently distributing the custom spawner via the BinderHub repo.
The problem is we want to use the BinderSpawnerMixin code in multiple spawners, not just KubeSpawner. If we want to keep the current deployment setup then either we store the code in binderhub/binderspawner_mixin.py and copy it in to values.yaml, or vice-versa.
I think a nicer long term plan is to either publish the BinderSpawnerMixin code a separate Python package and include that in the Z2JH hub image, or build a custom JupyterHub image in this repository.
I can't put everything in 00-binder because only the BinderSpawnerMixin code is part of the BinderHub Python module, the other bits (subclassing KubeSpawner, setting c.JupyterHub.spawner_class = BinderSpawner) musn't be included. Instead I've renamed it 0-binderspawnermixin which according to https://github.com/jupyterhub/zero-to-jupyterhub-k8s/blob/417e84e81101f5757c5bb735bd7daf249696c45f/jupyterhub/files/hub/jupyterhub_config.py#L444 should mean it's evaluated before 00-binder.

I'm in favour of creating a BinderHub specific JupyterHub image. IIRC there was some resistance in the past due to the maintainance cost, but I'm happy to implement that here if no-ones against it.

@manics I just had a conversation with @consideRatio, and I am now happy to actually merge this as is. The FIXMEs listed in https://github.com/jupyterhub/binderhub/pull/1358#issuecomment-919097521, and I think that's good enough. We agreed that long term option is to install binderhub in the upstream z2jh chart. I personally prefer having this be duplicated, but I have now decided that doesn't need to block this PR :)

Thanks both 😃.
I'm still keen to tidy this up, but we should probably have a more general team discussion about the BinderHub roadmap first.

@manics as an intermediate step, how do you feel about implementing

If we want an intermediate step, I think we can just keep two copies of the file, and add a test that asserts they are identical - so we don't forget to update one when we update the other?

The end goal would probably be for us to consistently publish binderhub to pypi, and install that in z2jh itself.


Updated README.md to include events more

I hope I got everything right.

Thanks @lucaswxp!
I just added you as a collaborator to the repo so you can continue to contribute doc improvements as you see fit. :)

Thanks @feross!


Issue #7200 fixed

Issue fixed #7200

@shivamtiwariwebkul
Not working, the products are not listing on the home page.

@shivamtiwariwebkul
Any update?

@Sanjaybhattwebkul
This is working, please find the screenshot Here


[Dev] use YAML issue templates

What we need to document?
Currenlly we use markdown issue templates, but it they are may be confusing for users. We can try YAML templates (beta at this time).
Refer to:

https://github.blog/changelog/2021-06-23-issues-forms-beta-for-public-repositories/
https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#creating-issue-forms

Inspiration:
https://github.com/pandas-dev/pandas/tree/main/.github/ISSUE_TEMPLATE

Issue template for tests and config will be also added.

Compreted and new templates are avaiable.
https://github.com/lisphilar/covid19-sir/issues/new/choose
Files:
https://github.com/lisphilar/covid19-sir/tree/master/.github/ISSUE_TEMPLATE


ARTEMIS-2705 Test Artemis on aarch64 CPU architecture

Update Netty to 4.1.50 that includes aarch64 binaries

Use Maven wrapper

This way it will use the preferred version of Maven.
Also it seems Maven is not coming pre-installed on ARM64

Update netty-tcnative to 2.0.31.Final

Update Maven to 3.6.2 because artemis-console fails with 3.3.9

travis_wait the build of 'examples'

because it takes more time and Travis kills it: https://travis-ci.org/github/martin-g/activemq-artemis/jobs/697514020
"The job exceeded the maximum time limit for jobs, and has been terminated."

can you rebase it?
What is the point of testing the new platform? there are no natives in the testsuite for travis (we disable libaio on travis).

can you rebase it?

Rebased!

What is the point of testing the new platform? there are no natives in the testsuite for travis (we disable libaio on travis).

In that case maybe there is no point in testing on arm64.
Should I close this PR or enable libaio just on arm64 ?

can you rebase it?

Rebased!

What is the point of testing the new platform? there are no natives in the testsuite for travis (we disable libaio on travis).

Should I close this PR ?
May end goal is to make
./modules/system/layers/base/org/apache/activemq/artemis/journal/main/lib/linux-x86_64/libartemis-native-64.so available for aarch64 too.

@martin-g you should probably close this then, as we don't test the .so on travis. (environment issues on travis were killing us, so we disabled it).
The issue really is how to build it?
Someone willing to use artemis-native on aarch64 should do the cmake .; make and place the natives in the right place.
Now if you have a way we can release with aarch64, you can probably look at the compilations scripts on artemis-native if you can come up with a way to do it in the future.

like, I don't have access an aarch64 box so i could build.
Again, someone willing to use it, can just compile it themselves in 10 seconds.

The issue really is how to build it?

No. Custom build is easy.
The idea is to provide the aarch64 binary within the Wildfly distribution.
I will see what I can do!

https://github.com/apache/activemq-artemis-native/pull/8


Readme example doesn't work

When running:
user error (When running in forward mode you must set shakeLintInside to specify where to detect dependencies)

*** Exception: ExitFailure 1

Requires
  let shOpts =
        forwardOptions $ shakeOptions
          { shakeVerbosity = Chatty
          , shakeLintInside = ["./site/"]
          }

Thanks dude, updated the README.
Hope you got things working for ya.


Refactor BuildIAMUser

This PR is a first pass at refactoring the BuildIAMUser function. It removes the logger from outer functions where possible and cleans up the logic within the function by moving out as much as possible into smaller functions. A couple of TODO's but this makes it much easier to read.
I think that we should move the logger completely from BuildIAMUser and return any errors out to the reconcile and parse there. I didn't do that here because of 1. time and 2. PR size.
All errors are returned to the reconcile function which will then fail the account if there is a problem.
make test-all is passing locally and I've verified that the AWS credentials are working.

This needs to be merged before https://github.com/openshift/aws-account-operator/pull/343 as I just confirmed it fixes issues that I was having on that branch with secret names and creation (I cherry-picked this commit to test). Everything works now.

Passed locally for me as well with make test-all.

/lgtm


Halts on plugins that require refresh

Found a fix, but I thought I should document it in case anyone is encountering similar issues.
For any plugin that requires a refresh/reload to work (for me it was wwise-godot-integration), Godot has no way to handle this in --headless mode. So the Github actions job freezes on a dialog that you can't acknowledge in any way.
The fix here is to use a timeout:
- name: Godot Import
  run: timeout 10 godot --verbose --headless --import

Before running the actual Godot build script:
- name: Godot Build
  run: godot --headless --verbose --export-release "BuildName" build/

And you could probably cache the .godot file to avoid a timeout in the future.

Oh, although it looks like this miiiight be fixed in 4.4? https://godotengine.org/article/dev-snapshot-godot-4-4-dev-2/#error-less-first-project-import


clean up age, updated_at

This commit cleans up the age and updated_at fields. It now uses dates
that are relevant to now instead of hours (i.e. "six days ago", "four
hours ago", "one month ago"). It also uses the correct dates now, as age
used to use the time between the created_at date and the updated_at
date. It now sorts the dates correctly as well.
Unrelated, it adds go get to the readme, which is required to build
the software.
It adds a new dependency, momentjs, a very handy date management tool to generate the humanized dates.
Fixes: https://github.com/minio/buzz/issues/57

waiting on @ebozduman  to approve these changes before merging.

@deekoder, @ebozduman and I just cleared that up, it should be good to merge.

Thanks!


HOTT-1753: Add Images for guides + Helper

What?
This PR
-[x] adds all the images for the guides
-[x] adds a helper to easily show them in the views.
Jira link
https://transformuk.atlassian.net/browse/HOTT-1753
Why?
To add images which are associated with the guides added in the https://transformuk.atlassian.net/browse/HOTT-1728

This PR allows easily adding the image for the guides.
For Example:
<%= guide_image('audio') %>


Support shallow clone [#37]

Can you fix the issue un package.json and make an interactive rebase with all of your commits to just have one single commit?
git rebase -i master
# squash all and rewrite the first one
git push --force

@sharathprabhal thank you for that!

Can't believe I did it again. Please take a look at
https://github.com/neoziro/grunt-shipit/pull/42
On Tue, Jan 13, 2015 at 5:57 PM, Greg Bergé<EMAIL_ADDRESS>wrote:

@sharathprabhal https://github.com/sharathprabhal thank you for that!
—
Reply to this email directly or view it on GitHub
https://github.com/neoziro/grunt-shipit/pull/41#issuecomment-69838003.

@sharathprabhal you can do it in the same PR, for the next time try it, just push force and it will work. I close this one and I merge the other.


Support Legend Text Styling (To Visualize Hover)

Feature Proposal
Proposal
I propose to to add a new fontStyle property (or something similar) to the LegendItem interface.
This should allow at least the following values:

'normal' (DEFAULT)
'bold'
'underlined'

Use Case
We use an on click handler to hide datasets using the legend. This is currently a 'hidden feature' as there is no visual clue to the user that the legend is an interactive user element. You have to know it or read the documentation.
To increase accessibility, we would like to change the text style of the currently hovered element to 'bold' or 'underlined'.
Side Note
This could be a general pattern to implement for other labels in ChartJS.
Possible Implementation
No response

+1 for this


Lateral inhibitory hebbian learning to decorrelate units

First pass, non-biological mechanism: simple hebbian term slowly learned with Inhib type connection directly between neurons in a pool -- specifically penalizes co-activity, weakly..

This is very effective.  Hebbian learning with lrate 0.0001 is better than 0.001 in the long run -- very slow process.


Automatically zoom on planet when using set_track_object

At the moment, when using set_track_object in solar system mode, one still has to zoom in manually to the planet. I believe there is a function gotoTarget that we may be able to use to do this, but this requires a Place object and I haven't had a chance to find out how to get such an object for a given planet.

Thanks @astrojonathan! I'll re-open this until we implement support for it in PyWWT

@astrojonathan Thank you for the assist; I nearly have this fixed. One more question:
The Place.create + gotoTarget method works for all expected bodies except Earth. When I feed the string Earth to gotoTarget, I get this error: TypeError: undefined is not an object (evaluating 'raDec.RA') (line_number=35853, source_id=https://worldwidetelescope.github.io/pywwt/wwtsdk.js).
This is in the get_params method of Place, which calls Planets.getPlanetLocation, which in turn calls Planets.getPlanetIDFromName.
Earth is one of the entries in the switch/case statement of getPlanetIDFromName, so this method returns 19.
That value is passed back to getPlanetLocation to use as an argument when calling AstroCalc.getPlanet. In the latter method, I see that there's no case for when the planet ID is 19 (corresponding with Earth).
Is that intentional, and if so, how can I work around it?

@astrojonathan This comment is lower priority than the previous one, but gotoTarget(place, noZoom, instant, trackObject) is also not working as expected -- I would like a smooth scroll to the planet, but the view changes instantly whether instant is true or false.
I tried using the .aspx version of the SDK and got the desired scrolling zoom, so is this something that doesn't work normally with WebGL?


feat: create Taro Testnet

This is a PR to add Taro Testnet to the chain directory.

got it. thanks! so does it belong in /overrides or /additional?

got it. thanks! so does it belong in /overrides or /additional?

since this looks like you're adding a fully new chain this would go in /additional

alright, i think it should be good now @jnsdls thank you again for the help


[Bug] NFT displayed is incorrect

What happened?

The NFT displayed is incorrect
once you click into the NFT properties, the correct image is shown
once you return to the NFT overview listing, the correct image is shown
Version
1.8.0rc3
What platform are you using?
Windows
What ui mode are you using?
GUI
Relevant log output or stacktrace
No response

fixed via https://github.com/Chia-Network/chia-blockchain-gui/pull/1730 it will be part of 1.8.1


why the score for coco evaluation is the product of kpt score and bbox score?

I'm little confused here. It seems Detectron has a different stragety...

we also tried the summation, but product has a better performance.

Thanks!


feat: adding support for get block rpcs with_cycles and verbosity0 version

with_cycles:
Adds two new similar functions like get_block & get_block_by_number, which will get results with cycles

GetBlockWithCycles
GetBlockByNumberWithCycles
The input params are same form with the original fns

verbosity0:
Adds 4 new functions which specified the vebosity to be 0:

GetPackedBlock
GetPackedBlockWithCycles
GetPackedHeader
GetPackedHeaderByNumber

please follow rust sdk pr naming, change GetBlockVerbosity0 to GetPackedBlock, etc:
https://github.com/nervosnetwork/ckb-sdk-rust/pull/51

please follow rust sdk pr naming, change GetBlockVerbosity0 to GetPackedBlock, etc: nervosnetwork/ckb-sdk-rust#51

Done


Switching from 1.2.1 to 2.x.x drastically slows my app

In my app I allocate realtime video frames (24MB per frame * 60fps)
In my app I time the processing of a frame in milliseconds.
Using ffi: ^1.2.1 I get 8-11ms per frame
Using ffi: ^2.0.0 I get 70 to 200ms per frame in DEBUG mode and 20-30ms in RELEASE mode which makes my app unusable.
I suspect that it has something to do with the switch mentioned in the changelog of 2.0.0

Switch Windows memory allocation to use CoTaskMemAlloc and CoTaskMemFree

I've also found an article that talks about a bug in windows 10 which supposedly makes this a lot slower:
https://randomascii.wordpress.com/2022/07/11/slower-memory-zeroing-through-parallelism/
For now I can't upgrade to ffi 2.x.x since I can't use my app with this version.
Is this a known thing?
EDIT: switching from ffi.calloc to ffi.malloc reduces the time immensly but of course is not always applicable

I experience something similar... media_kit bundles ffi: ^1.2.1 to continue working properly.


Adding the projects in the User Interface and improving the organization of items

Problem: All the projects are not visible on the front home page. It's very difficult to get the project details.
Solution: Arranging the projects category-wise on the home page.

@TusharKesarwani Sir, please assign me this issue, I would like to work on this under SSOC 2.0

Create a fresh issue after 1st June


Add integration tests

Rework the integration tests so that it is possible to run the integration tests on travis and with a customizable set of databases.

resolved


Add aliasing method for pseudo columns

resolves #365

Description
Added the alias_column method to the BigQueryAdapter class.
The purpose of this method is to produce a column alias for use in a select statement or completely rename a provided column. The initial use case is for this to be used to alias pseudo columns so that dbt tests can be applied to them. If not aliased, BigQuery errors as it is trying to produce the dbt__test_audit table using a column name with an illegal character (preceding _).
Checklist

[ ] I have read the contributing guide and understand what's expected of me
[x] I have signed the CLA
[ ] I have run this code in development and it appears to resolve the stated issue
[ ] This PR includes tests, or tests are not required/relevant for this PR
[ ] I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
[ ] I have run changie new to create a changelog entry

Still working on checklist!

I won't actually be reviewing the PR, but am going to approve the workflows running to get CI things kicked off for you in the meantime!

I commented on the original issue last week, waiting for an answer to decide how to move forward on that PR.

Closed as discussed in the issue.


Internal Server Error when Regenerating Summaries

Describe the bug

Settings, Clear and regenerate
Visit "All Time" on dashboard

2022/04/20 07:31:48 runtime error: index out of range [0] with length 0
2022-04-20T07:31:48.767913728Z [INFO ] [request] status=500, method=GET, uri=/summary?interval=any, duration=293.503503ms, bytes=0

It works eventually, presumably after summaries have finished generating.

System information
Please provide information on:

Wakapi version: n1try/wakapi:2.3.4
Database (SQLite, MySQL, ... ?): SQLite

Good catch! I'll fix this asap.


Infinity objective: add / use tube lens focal length correction

Most everything is calibrated assuming you won't swap objectives between systems. But if for example you put a Neo SPlan objective (f=180) on a Mitutoyo system (f=200) you'll get a slight magnification error on scalebars. We might already have this in the objective db and it wouldn't be hard to compensate it.
If system focal length and/or objective focal length is not specified, assume they match. Maybe print a warning if we are in dev mode

this error can be quite bad on Mitutoyo QV objectives (f=100)


Full Text Search on local RTD instance not working

When I spin up RTD locally on a Ubuntu VM and turn on ElasticSearch I can search titles of projects I have imported but when I go to a project page /projects/projecT_name/search I cannot find anything within the search results.
When I examine ElasticSearch I see items in the readthedocs index of type project but no entries of the type page that I would expect need to be there for full page search.
I found some instructions here: https://github.com/rtfd/readthedocs.org/blob/master/docs/rtfd.rst
But when I run index.create_index(index_name) I get the error:
TransportError: TransportError(400, u'IndexCreationException[[readthedocs-20150909120501] failed to create index]; nested: IllegalArgumentException[Custom Analyzer [default_icu] failed to find tokenizer under name [icu_tokenizer]]; ')
Any help in getting this functionality would be greatly appreciated.

Supporting this on local instances is outside the scope of the core team, marking this community support if anyone else wants to jump in on this.

So does that mean it either should work out of the box or is too complicated to explain?

It should Just Work, as it does in our environments, but it's also too complicated for the core team to spend time supporting these external instances that we have no control over. If you are running an internal instance, you should be familiar with managing the entire stack outside of Read the Docs.
We answered this question here:
http://docs.readthedocs.org/en/latest/open-source-philosophy.html
This isn't to say we won't be able to help, but it's effectively very low on a long list and better served by the community.

Being familiar with managing the stack I get the feeling this is a documentation issue which is ironic given your area of business.

It would make a lot of sense for your project to get this thing running in a VM via ansible or Chef...then you dont have to help users run the project anymore...might increase your pull requests.

@frodopwns I've experimented the same problem... did you find a solution?
I've compiled elasticsearch-1.7.0 and elasticsearch-analysis-icu-2.3.0
in my virtualenv as for readthedocs requirements
elasticsearch==1.5.0
pyelasticsearch==0.7.1
django-haystack==2.1.0
celery-haystack==0.7.2
I also tried upgrading libraries
elasticsearch==1.6.0
pyelasticsearch==1.4
celery-haystack==0.9
django-haystack==2.1.1
but isn't helping...
Any suggestion would be appreciated!

@domdinicola No I decided to throw together my own solution instead of using RTD. They must have a very manual setup for ES that isn't well documented.

I did the same... overridden view and template...
Thank you for answering.

Our deployment of elastic search is documented in our production docs, if anyone else is searching. The set up only requires ES + icu, and index creation.
Closing this due to inactivity.

Where can I find these production docs?

@acjackson, by production docs, I think @agjohnson means this: http://read-the-docs.readthedocs.io/en/latest/rtfd.html#elastic-search-setup.  Those are the only docs on elasticsearch setup, AFAICT.
I had zero problems with the rest of the install, and I  have a local instance of RTD running and working (even git pulling, building, and running doxygen and breathe on stuff). Installing elasticsearch was a snap as well, but getting that code to run and do anything meaningful to the elasticsearch index is a different story (that covers many late nights, by many a sad, sad tech writer).

I got this working using elasticsearch 1.7.6 and icu plugin 2.7.0. I struggled for a while trying to use the latest elasticsearch, but it seems somewhat incompatible, and based on the readthedocs.org documentation suggesting the icu plugin 2.30 I suspect it is using an even older elasticsearch.
The elasticsearch/icu compatibilty table is at https://github.com/elastic/elasticsearch-analysis-icu
The docs on readthedocs.org elastic search are at http://readthedocsorg.readthedocs.io/en/latest/rtfd.html?highlight=elastic#elastic-search
Anyway, the steps I used.

Install elasticsearch 1.7.6
Install icu plugin 2.7.0 using/usr/share/elasticsearch/bin/plugin -install elasticsearch/elasticsearch-analysis-icu/2.7.0
fire up elasticsearch
Run magic python script from rtfd page above, slightly modified:

import os
os.environ['DJANGO_SETTINGS_MODULE'] = 'readthedocs.settings.dev'
from readthedocs.search.indexes import Index, PageIndex, ProjectIndex, SectionIndex
index = Index()
index_name = index.timestamped_index()
index.create_index(index_name)
index.update_aliases(index_name)
proj = ProjectIndex()
proj.put_mapping()
page = PageIndex()
page.put_mapping()
sec = SectionIndex()
sec.put_mapping()

Run python manage.py reindex_elasticsearch


platform: Solidify LogAppenderTest

Closes #452
While running LogAppenderTest in IntelliJ, the test fails because the log4j console appender does not write to system output. The system capture would fail.
This PR fixes

PR Checklist
PR Structure

[x] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[x] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[x] This PR's title starts with name of package that is most changed in the PR, ex.
paymentservice.stellar, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.

What
Make sure the logger output correct logger name.
Why
While running LogAppenderTest in IntelliJ, the test fails because the log4j console appender does not write to system output. The system capture would fail.
Known limitations
N/A

Something went wrong with PR preview build please check

Reference Server Preview is available here:https://anchor-ref-pr453.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr453.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr453.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr453.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr453.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr453.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr453.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr453.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr453.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr453.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr453.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr453.previews.kube001.services.stellar-ops.com/


Add notify.js plugin into ipython-notebook-extensions

I think it would be a great inclusion to have the notify plugin. I find it extremely useful.
It is hosted here https://github.com/sjpfenninger/ipython-extensions and I have no credit for this PR, since it's a simple copy paste.
I want to contribute, let me know how I can improve this request.
Thanks!

@sjpfenninger, would this be ok with you? Anything you'd care to alter? Apologies if you've already answered this elsewhere that I haven't found.
@acamps, I have a few suggestions:

I think it might be a bit clearer to rename the extension to something a little more specific, like Notify on kernel idle, or Kernel-idle notifications?
Add notification.png as an icon (specified by a relative path in the yaml as in nbextensions/usability/ruler/ruler.yaml)
Add a README.md (and associated entry in the yaml) adapted from sjpfenninger/ipython-extensions/blob/master/README.md#notebook-web-notifications.
The readme should note that this extension will only work in browsers which support the Notification API. That means no IE, no Safari Mobile, no Opera Mobile. Alternatively, see below for a shim.
In the current implementation, it looks like if Notification is not defined, the extension will just throw an error, since "use strict" was invoked, and Notification hasn't been declared as a variable/argument. It could be worth looking at the shim at nickdesaulniers/fxos-irc/blob/master/js/notification.js to get around this and the previous issue of incomplete support, or just throwing a less cryptic warning on fail than Uncaught ReferenceError: Notification is not defined.
If you fancy extra work (this is by no means necessary), currently, it seems that the length of time for which the kernel must be busy before its idle message generates a notification is stored in the notebook metadata. This is sensible, but it might be nice to also have a default value for any notebooks which don't have the metadata value specified yet, which could be stored in the extension configuration. You could look at nbextensions/usability/ruler/main.js and nbextensions/usability/ruler/ruler.yaml for inspiration on how to do that. This isn't necessary for anything though, just might be nice if you fancy tinkering.

Thanks @jcb91 for your quick reply!
About your comments:
1 - Sure! Makes a lot of sense. I was busy and wanted to start something.
2 - Actually it's not an Icon as I thought at the beginning. It's a picture from @sjpfenninger for the README.
3,4,5 - Of course. I'll appreciate a lot your comments and update the code as soon as possible!
6 - Depending on how long the previous steps take, I'll do that too.
I'll try to work on them in the following days. Thanks again!

Fine with me! (just include the MIT license/attribution in the README or something)

The modified MIT license ist specified in COPYING.rst

The modified MIT license ist specified in COPYING.rst

@juhasch the question isn't what license your project is under but whether you've included the copyright notice/attribution from my code in this PR (created by @acamps but containing my code)

OK, added a readme including copyright notice in PR #447.

Thanks!


chore(package): update npm-pkgbuild to version 6.8.1

Coverage decreased (-49.2%) to 34.805% when pulling b1e717a957b217d15b55f5445f4d44ff8da8f66e on greenkeeper/npm-pkgbuild-6.8.1 into 6d496ce93b54f961d5f14a376f7f850900e0b122 on master.

Coverage decreased (-49.2%) to 34.805% when pulling b1e717a957b217d15b55f5445f4d44ff8da8f66e on greenkeeper/npm-pkgbuild-6.8.1 into 6d496ce93b54f961d5f14a376f7f850900e0b122 on master.


Add custom Tip Callout Component to RS Storybook Instance

Problem statement
The custom Tip Callout Component that RS uses on the website is not in the RS Storybook instance yet. As such, it should be added to Storybook so that design team can use it as a source of truth moving forward (and reference it easily for the engineering team to execute on their designs).
What you need to know

RS Public Storybook instance
May need to use Chromatic. Can reference instructions created in #9987

Acceptance criteria

[ ] The "Tip Callout Component" appears on the public RS Storybook instance (link above)

To do

[ ] ...

Will be part of the Tip Callout PR


Improved the Ui for About

@deveshwadhwa01, it would be awesome if you would star this repo.

@deveshwadhwa01, it would be awesome if you would star this repo.

issue is already resolved.
Thanks


usr/bin/env: escript: No such file or directory

Environment
-Server: AWS
OS: Centos 7
Erlang/OTP: otp_src_19.2.tar.gz
EMQ: v2.0.4
Description
I have two Server on AWS :+1:
OS: Centos 7
EMQ: v2.0.4
sorry I want to make emqtt_benchmark
but...
[root@ip-xxx-xx-xx-xx emqtt_benchmark]# make
/usr/bin/env: escript: No such file or directory
make: *** [get-deps] Error 127
Do I have to have an env directory?
And then How I make escript??

Hi I also have the same problem, do you fix it?

@GLENNCHAN888  Please install Erlang OTP

@GLENNCHAN888 @MuskaWu Suggest to use the JMeter to benchmark EMQ: https://github.com/emqtt/mqtt-jmeter


Support negated pattern matching !(...patterns)

The rest of the extended pattern matching forms are already supported but this one is actually not technically possible due to the current regex backend being used. glob needs to generate a regex negative lookahead of the form (?!...) which isn't implemented yet in regex.
There's an existing issue over there for it: https://github.com/nitely/nim-regex/issues/6
I'm assuming both Nim's stdlib regex engines support it but they both wrap pcre which removes the pure Nim aspect of glob.

@citycide can user defined filterDescend be used for that? see https://github.com/citycide/glob/issues/8
eg:
import glob
import re # or nre
walkGlobKinds(".", filterDescend = dir=>not dir.matches(re"pattern1")).filter(a=>not a.path.matches(re"pattern2"))

or:
import glob
import regex
walkGlobKinds(".", filterDescend = dir=>dir.matches(re"!(...patterns1)")).filter(a=>a.path.matches(re"!(...patterns2)")

Update: while the linked issue has been closed, only single-character lookarounds are supported in (?!...) groups. Progress, but not enough IMO to enable the feature in glob yet.

Update: while the linked issue has been closed, only single-character lookarounds are supported in (?!...) groups. Progress, but not enough IMO to enable the feature in glob yet.

Closed by https://github.com/citycide/glob/commit/83bdafc85ffdcc64004788ded4b94fe8ba06fb7c and released in v0.11.0.

Closed by https://github.com/citycide/glob/commit/83bdafc85ffdcc64004788ded4b94fe8ba06fb7c and released in v0.11.0.


@craigspaeth Remove Mixpanel and Google Analytics in favor of Segment

Addresses https://github.com/artsy/flare/issues/26.  Note I removed the analytics test both because the new analytics code is somewhat simpler and the test didn't seem to provide that much coverage.  If you'd be more comfortable with a test, let me know and I'll learn enough mocha to implement one.

This will require adding a SEGMENT_API_KEY to the environment where this is hosted, which I'm happy to do if you think this change is acceptable.

LGTM 🙌  thank you! Minor style comment but not at all a blocker, just FYI.

Added the SEGMENT_API_KEY to flare-production in heroku.


CMake Linux Configurations renamed

Seems that on Visual Studio 2019 (16.6.0 Community) You need to add the Configurations they no longer show on the dropdown it just shows x64-Debug the options name have now changed and instead of being called Linux-Debug or Linux-Release they are now Linux-Clang-Release Linux-Clang-Debug Linux-GCC-Debug Linux-GCC_Release
Can documentation be updated?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 296f6914-b366-1ab8-4c08-6d51fc7212fa
Version Independent ID: 04aec2e0-f39a-2e52-6a09-354222d47146
Content: Create and configure a Linux CMake project in Visual Studio
Content Source: docs/linux/cmake-linux-project.md
Product: visual-cpp
Technology: cpp-linux
GitHub Login: @TylerMSFT
Microsoft Alias: twhitney

Thank you, @annerajb
I've updated the topic. It'll go live by Monday evening (9/28)
#please-close


python.withPackages: raise error on incompatible modules

Description of changes
So far, any incompatible python packages passed to python.withPackages were silently ignored. This can lead to hard to debug scenarios especially when using downstream tooling to construct python modules outside of the nixpkgs fixpoint.

Things done

Raise descriptive error when an incompatible python module is passed to python[X].withPackages

example:
nix-repl> python310.withPackages (ps: [python39.pkgs.requests])
[...]
       error: Encountered incompatible packages while constructing a python environment.
       The following paths do not represent a python package compatible with the interpreter python3-3.10.13:
         /nix/store/043c6lnjlzfv2cyxjc2yc4inv7mqyrmi-python3.9-requests-2.31.0

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I've tested it in the repl. Do we have unit testing infra in nixpkgs that allows to test for errors? In that case I could add a test.


The prop toolColor is not working in iOS. Does work in Android.

Using the yellow color '#FFFA38' from the Readme, in Android I get the expected result, but in iOS this prop seems to be ignored, I always get a black line.

Hey @diego-caceres  I see that you use the version @=> 0.48.1, for this package, it is mandatory to use v5.3 to avoid problems like that...
Please take It easy, and reinstall all your dependencies creating a new project with correct version
Please, share if this works to you, tnx

Hi @VGamezz19 , thanks for the reply.
I'm not sure why react-native info command threw 0.48 for react native the other day, but in reality I'm using 0.55.2 and I still have this error.
I've also tried react-native 0.53 just in case, but the drawing line is always black in iOS.
Should it be exactly 0.53 or it should work on newer?
Thanks

Ok, so I created a new project from scratch, with version 0.53 (instead of downgrading my existing one) and now the line color props is working correctly!

Nice @diego-caceres  try it the same from issue #2 ,)


add tkong-redhat and Tafhim to reviewers list

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.80%. Comparing base (dcbdd3e) to head (e603b70).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
- Coverage   72.48%   68.80%   -3.69%
==========================================
  Files          19       21       +2
  Lines        1185     1404     +219
==========================================
+ Hits          859      966     +107
- Misses        251      358     +107
- Partials       75       80       +5

see 2 files with indirect coverage changes

/retest

/retest

/retest

/lgtm


Result Exercises backend

Result Exercises backend
Description
As developper,
I want to check whether the field has been filled in correctly depending on the type of field (one-line or multi-line),
In order to know for each response provided by the user (differentiated by the timestamp) if it has been completed, yes or no, according to its type.
Acceptance criteria
1. Single line text

[x] Show a green check if the answer is link to field.
[x] Show red cross if no answer is link to field.

2. List of single lines

[x] Show a green check if the answer is one line.
[x] Show a double green check if the answer is multi-line.
[x] Show red cross if no answer is link to field.

3. Multi-line text

[x] Show a green check if the answer is one line.
[x] Show a double green check if the answer is multi-line.
[x] Show red cross if no answer is link to field.

Additional notes

This function contains the backend for displaying the results, with each response filtered by timestamp.

User story déplacée au sprint 4, elle n'a pas eu le temps d'être terminée durant le sprint 3.


Bug in Helper:Format keys for caching

The keys generated for caching in the Helper:Format are not always unique. In particular, if you format a date like (2017-1-21) and then format (2017-12-1), the second appears as a cache hit on the first. (Key is '{0}-{1}-{2}2017121' for both.) This should be solvable by just using a '+' for the join when creating the cache key, e.g.
var key = format + args.join('+');
resulting in '{0}-{1}-{2}2017+1+21'  and ''{0}-{1}-{2}2017+12+1' as the two respective keys.

@skulegirl
Oh i see!
If you did not tell me, I would not have noticed the issue.
Thank you for your advice.
This issue will be fixed to the next version.

Hi @skulegirl!
This issue is solved at the version v1.4.13.
Thank you again for reporting the issue. 👍

This issue will be closed tomorrow.
If you have other issues, Please create a new issue 🍺


On OTF apply pages, why is the guide and clipboard right justified?

is that on purpose? Seems like it should be left justified.

I thought it looked better, less messy. But probably a good idea to let a designer take a look.
Sent with GitHawk

We are likely making suggestions about this as part of our re-working of the questions and the form. cc @bumbleblue @ei8fdb


[V3] Implement new Concept Exercise: concept/classes-intermediate

This issue describes how to implement the class concept exercise for the JavaScript track and is a continuation of exercism/javascript#942 .
Getting started
Please please please read the docs before starting. Posting PRs without reading these docs will be a lot more frustrating for you during the review cycle, and exhaust Exercism's maintainers' time. So, before diving into the implementation, please read up on the following documents:

The features of v3.
Rationale for v3.
What are concept exercise and how they are structured?

Please also watch the following video:

The Anatomy of a Concept Exercise.

Goal
The goal of this exercise is to teach the student how to consume classes and their properties/methods both from static and instantiation standpoints within JavaScript.
Learning objectives

Understand the new keyword.
Understand the static keyword.
Understand how to consume instance methods and fields
Understand how to consume static methods.

Out of scope

Factory functions
Class expressions (declaring a class with a var statement)
Static properties & static methods
extends keyword
Class inheritance with super
Class properties (get, set, and Object.defineProperty)

Concepts

Class instantiation with the new keyword
Accessing class properties from outside of a class
Calling class methods from outside of a class
Calling static methods from outside of a class

Prerequisites

classes-intro
booleans
numbers
strings

Resources to refer to
Hints
Note: most resources also include inheritance and so suggestions are welcome for resources that expressly tackle the goals without venturing out of scope.

MDN static keyword

After
Note: most resources also include inheritance and so suggestions are welcome for resources that expressly tackle the goals without venturing out of scope.

MDN class fields - after because it goes out of scope and touches on TC39 proposals (possibly a bad resource?)

Representer
No changes needed.
Analyzer
No changes needed.
Implementing
See the Implementation Guide for JavaScript Concept Exercises for more details.
Help
If you have any questions while implementing the exercise, please post the questions as comments in this issue.

I am closing this issue because we decided to cut concepts/concept exercises differently. See https://github.com/exercism/javascript/issues/951#issuecomment-778834953 for details. Classes are covered here now https://github.com/exercism/javascript/issues/1015 and inheritance will be combined with errors into into one exercise with two concepts.


The realsense2.sln file is not being created.

Before opening a new issue, we wanted to provide you with some useful suggestions (Click "Preview" above for a better view):

Consider checking out SDK examples.
Have you looked in our documentations?
Is you question a frequently asked one?
Try searching our GitHub Issues (open and closed) for a similar issue.

All users are welcomed to report bugs, ask questions, suggest or request enhancements and generally feel free to open new issue, even if they haven't followed any of the suggestions above :)

Required Info

Camera Model
L515

Firmware Version
(Open RealSense Viewer --> Click info)

Operating System & Version
Win 10

Kernel Version (Linux Only)
(e.g. 4.14.13)

Platform
PC

SDK Version
{ legacy / 2.. }

Language
Unity 2020.1.0f.1

Segment
Others }

Issue Description
<Describe your issue / question / feature request / etc..>
I'm using Unity Wrapper according to your instructions (https://github.com/IntelRealSense/librealsense/tree/master/wrappers/unity#step-1---build-dependencies-and-open-the-unity-project) I'm installing it.
But I ruined from the beginning.
I follow your manual
I followed "cmake .. -DBUILD_CSHARP_BINDINGS=ON -DBUILD_UNITY_BINDINGS=ON -DBUILD_SHARED_LIBS=ON -DDOTNET_VERSION_LIBRARY=3.5 -DCMAKE_GENERATOR_PLATFORM=x64"
The realsense2.sln file is not created.
I uploaded the video to Youtube and attach a link.
https://youtu.be/3ZGZM6VDDu0
Please solve the problem
(It made you work so complicated.)
The second ruined part is @dorodnic 's instructions.
He told me to use a version of Unity lower than 2020.1 in instructions from #6955 (https://github.com/IntelRealSense/librealsense/issues/6955#issuecomment-664890508).
So I tested on 2018.4.4f1.
The error disappeared, but the same symptom as #6949 appears.
I think this is the reason why CMake did not build.
Why did you make the sample project so complicated?
Can you update the fully running sample project?
(Even the published sample project has not been updated for 16 months.
You're selling new products, but
Your project doesn't fit the age at all)

Moreover, the class ARBackgroundRenderer used in the sample is a deprecated class... from Unity 2020.1

@vertex798 , I will address the technical issue as highlighted in the log:

Cmake can't find git` required for building. It is either uninstalled or its path is not registered with PATH env. value.
You need to resolve it in order it to proceed with compilation.

@ev-mp Thank you for your answer.
By your instructions
The following issues were referenced (https://github.com/IntelRealSense/librealsense/issues/2719#issuecomment-474941250)
And the error no longer appears.
However, also the realsense2.sln file was not created.
What should I do?
Is it the process of creating the DLL to put in the Unity Asset/Plugins folder?
Can't I get the DLL file from you?

@vertex798 , do you need further assistance with SLN?

Hi @vertex798
Were you able to move forward with the suggestion from ev-mp?  Do you need anything else?
*If we don’t hear from you in 7 days, this issue will be closed.


Rome False Positive

There is a false positive for Rome - this has nothing to do with the CVE:
rome-1.12.0.jar (com.rometools:rome:1.12.0, cpe:/a:all-for-one:all_for_one:1.12.0, cpe:/a:feeds_project:feeds:1.12.0) : CVE-2018-12056

Appears to be resolved with the 6.x releases.


Switch from integer IDs to random hex IDs

For better security/privacy.

https://github.com/decisiveteam/DecisiveTeam/commit/b0b2836b8b3ad3a6176e507e7717e4df374a042b


Complete @mbrand01's refactor to use the Node TLS module

This is nearly all @mbrand1's work, from #84 and #86, plus a few commits I've added at different points.
Since #86, I added one commit, c2449dfb679b9f805c951df54e80c818f4711250, which updates the test suite to expect and test for the presence of the root certificate in each site's chain (even if the site doesn't directly serve it).
Closes #84, as it's mooted by this one.

This is now deployed: https://shaaaaaaaaaaaaa.com/check/ipv6.google.com

Oops, meant to cc @mbrand1 on this thread, used the wrong handle above.


Is it possible to have a response that depends on the number of request invocations?

The scenario I'd like to set up is that a first triggering of an expectation returns non empty content and emulates a "delete" so that consequent invocations return empty content.

Oh I see, this is addressed in the answer to https://github.com/jamesdbloom/mockserver/issues/280 .
Perhaps should be documented on http://mock-server.com

this issue is now covered under #115 so closing as duplicate


⚠ GitHub has degraded performance

In f3a7d74, GitHub (https://www.githubstatus.com/api/v2/status.json) experienced degraded performance:

HTTP code: 200
Response time: 200 ms

Resolved: GitHub performance has improved in e9db021.


Added a project along with screens in the readme

Hi @Utkarsh2604,
Can you please merge this into the main codebase?
Thanks in advance.


Library Swapper Stopped Working

After using the plugin all morning (thank you!) it has suddenly stopped working. Any ideas on what I could do?

Confirmed the same issue using Sketch 51.2 (57519). "Swap Symbol Libraries" brings up the dialog, I can successfully select which libraries to swap. Then on submit I get the messages "0 symbols have been swapped to new libraries" and I may have to update the libraries with the "update library" button in Sketch. Though no symbols have been swapped and "update library" never appears.


Rename voice-compass to multimodal

Fixes https://linear.app/nlxai/issue/FRO-14/rename-voice-compass-package-to-multimodal.

@jakub-nlx absolutely!!


Releases failing randomly with agent error "Unhandled exception happened in worker"

Our pipelines are failing randomly with this error message produced by the ADO Agent
Agent package linux-x64.
Running on Linux (X64).
RuntimeInformation: Linux 5.4.0-1078-azure 81~18.04.1-Ubuntu SMP Mon Apr 25 23:16:13 UTC 2022.
Running as container on Kubernetes (AKS)
Azure DevOps Type and Version: dev.azure.com
[2022-06-02 11:31:28Z INFO RSAFileKeyManager] Loading RSA key parameters from file /azp/.credentials_rsaparams
[2022-06-02 11:31:28Z INFO MessageListener] Message '52' received from session 'ba0c5d02-28f2-4b4b-850b-42348f2fdbb2'.
[2022-06-02 11:31:28Z INFO JobDispatcher] Job request 615941 for plan c54e7a4e-ad11-46cc-9bc0-0c73e0cbd070 job 53e656e4-982d-505a-f1c4-7615adf3d251 received.
[2022-06-02 11:31:28Z INFO JobDispatcher] Job request 16a257d5-bebc-5958-3a7b-b4edf1fea8ba processed succeed.
[2022-06-02 11:31:28Z INFO Terminal] WRITE LINE: 2022-06-02 11:31:28Z: Running job: Agent job
[2022-06-02 11:31:28Z INFO AgentServer] Refresh JobRequest VssConnection to get on a different AFD node.
[2022-06-02 11:31:28Z INFO AgentServer] Establish connection with 30 seconds timeout.
[2022-06-02 11:31:28Z INFO VisualStudioServices] Starting operation Location.GetConnectionData
[2022-06-02 11:31:28Z INFO VisualStudioServices] Finished operation Location.GetConnectionData
[2022-06-02 11:31:28Z INFO JobDispatcher] Start renew job request 615941 for job 53e656e4-982d-505a-f1c4-7615adf3d251.
[2022-06-02 11:31:28Z INFO JobDispatcher] Successfully renew job request 615941, job is valid till 06/02/2022 11:41:28
[2022-06-02 11:31:28Z INFO HostContext] Well known directory 'Bin': '/azp/bin'
[2022-06-02 11:31:28Z INFO ProcessInvokerWrapper] Starting process:
[2022-06-02 11:31:28Z INFO ProcessInvokerWrapper]   File name: '/azp/bin/Agent.Worker'
[2022-06-02 11:31:28Z INFO ProcessInvokerWrapper]   Arguments: 'spawnclient 17 134'
[2022-06-02 11:31:28Z INFO ProcessInvokerWrapper]   Working directory: '/azp/bin'
[2022-06-02 11:31:28Z INFO ProcessInvokerWrapper]   Require exit code zero: 'False'
[2022-06-02 11:31:28Z INFO ProcessInvokerWrapper]   Encoding web name:  ; code page: ''
[2022-06-02 11:31:28Z INFO ProcessInvokerWrapper]   Force kill process on cancellation: 'True'
[2022-06-02 11:31:28Z INFO ProcessInvokerWrapper]   Redirected STDIN: 'False'
[2022-06-02 11:31:28Z INFO ProcessInvokerWrapper]   Persist current code page: 'False'
[2022-06-02 11:31:28Z INFO ProcessInvokerWrapper]   Keep redirected STDIN open: 'False'
[2022-06-02 11:31:28Z INFO ProcessInvokerWrapper]   High priority process: 'True'
[2022-06-02 11:31:28Z INFO ProcessInvokerWrapper] Process started with process id 1515, waiting for process exit.
[2022-06-02 11:31:28Z INFO JobDispatcher] Send job request message to worker for job 53e656e4-982d-505a-f1c4-7615adf3d251 (70 KB).
[2022-06-02 11:31:40Z INFO JobDispatcher] Took 11318 ms to send job message to worker
[2022-06-02 11:31:40Z INFO JobNotification] Entering JobStarted Notification
[2022-06-02 11:31:40Z INFO JobNotification] Entering StartMonitor
[2022-06-02 11:31:44Z INFO ProcessInvokerWrapper] STDOUT/STDERR stream read finished.
[2022-06-02 11:31:44Z INFO ProcessInvokerWrapper] STDOUT/STDERR stream read finished.
[2022-06-02 11:31:44Z INFO ProcessInvokerWrapper] Exited process 1515 with exit code 1
[2022-06-02 11:31:44Z INFO ProcessInvokerWrapper] Finished process 1515 with exit code 1, and elapsed time 00:00:15.5187047.
[2022-06-02 11:31:44Z INFO JobDispatcher] Worker finished for job 53e656e4-982d-505a-f1c4-7615adf3d251. Code: 1
[2022-06-02 11:31:44Z INFO JobDispatcher] Return code 1 indicate worker encounter an unhandled exception or app crash, attach worker stdout/stderr to JobRequest result.
[2022-06-02 11:31:44Z INFO VisualStudioServices] Starting operation Location.GetConnectionData
[2022-06-02 11:31:44Z INFO VisualStudioServices] Finished operation Location.GetConnectionData
[2022-06-02 11:31:44Z INFO JobDispatcher] finish job request for job 53e656e4-982d-505a-f1c4-7615adf3d251 with result: Failed
[2022-06-02 11:31:44Z INFO Terminal] WRITE LINE: 2022-06-02 11:31:44Z: Job Agent job completed with result: Failed
[2022-06-02 11:31:44Z INFO JobDispatcher] Stop renew job request for job 53e656e4-982d-505a-f1c4-7615adf3d251.
[2022-06-02 11:31:44Z INFO JobDispatcher] job renew has been canceled, stop renew job request 615941.
[2022-06-02 11:31:44Z ERR  JobDispatcher] Unhandled exception happened in worker:
[2022-06-02 11:31:44Z ERR  JobDispatcher] Newtonsoft.Json.JsonReaderException: Invalid character after parsing property name. Expected ':' but got: m. Path 'requestId', line 1, position 32006.
   at Newtonsoft.Json.JsonTextReader.ParseProperty()
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateObject(Object newObject, JsonReader reader, JsonObjectContract contract, JsonProperty member, String id)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Deserialize(JsonReader reader, Type objectType, Boolean checkAdditionalContent)
   at Newtonsoft.Json.JsonSerializer.DeserializeInternal(JsonReader reader, Type objectType)
   at Newtonsoft.Json.JsonSerializer.Deserialize(JsonReader reader, Type objectType)
   at Newtonsoft.Json.JsonSerializer.Deserialize[T](JsonReader reader)
   at Microsoft.VisualStudio.Services.WebApi.JsonUtility.FromString[T](String toDeserialize, JsonSerializerSettings settings)
   at Microsoft.VisualStudio.Services.Agent.Worker.Worker.RunAsync(String pipeIn, String pipeOut)
   at Microsoft.VisualStudio.Services.Agent.Worker.Program.MainAsync(IHostContext context, String[] args)
Error reported in diagnostic logs. Please examine the log for more details.
    - /azp/_diag/Worker_20220602-113138-utc.log
[2022-06-02 11:31:44Z INFO JobNotification] Entering JobCompleted Notification
[2022-06-02 11:31:44Z INFO JobNotification] Entering EndMonitor

File: /azp/_diag/Worker_20220602-113138-utc.log
root@azure-devops-agent-5857df4ff-6d4bj:/azp# cat /azp/_diag/Worker_20220602-113630-utc.log
[2022-06-02 11:36:30Z INFO Program] Version: 2.204.0
[2022-06-02 11:36:30Z INFO Program] Commit: 166abe8635999375bb798213066ccafbdd7e3875
[2022-06-02 11:36:30Z INFO Program] Culture:
[2022-06-02 11:36:30Z INFO Program] UI Culture:
[2022-06-02 11:36:31Z INFO HostContext] Well known directory 'Bin': '/azp/bin'
[2022-06-02 11:36:31Z INFO HostContext] Well known directory 'Root': '/azp'
[2022-06-02 11:36:31Z INFO HostContext] Well known config file 'Proxy': '/azp/.proxy'
[2022-06-02 11:36:31Z INFO VstsAgentWebProxy] No proxy setting found.
[2022-06-02 11:36:31Z INFO HostContext] Well known directory 'Bin': '/azp/bin'
[2022-06-02 11:36:31Z INFO HostContext] Well known directory 'Root': '/azp'
[2022-06-02 11:36:31Z INFO HostContext] Well known config file 'Certificates': '/azp/.certificates'
[2022-06-02 11:36:31Z INFO AgentCertificateManager] No certificate setting found.
[2022-06-02 11:36:31Z INFO Worker] Waiting to receive the job message from the channel.
[2022-06-02 11:36:31Z INFO Worker] Message received.
[2022-06-02 11:36:35Z ERR  Program] Newtonsoft.Json.JsonReaderException: Invalid character after parsing property name. Expected ':' but got: m. Path 'requestId', line 1, position 32006.
   at Newtonsoft.Json.JsonTextReader.ParseProperty()
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateObject(Object newObject, JsonReader reader, JsonObjectContract contract, JsonProperty member, String id)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract
, JsonProperty containerMember, Object existingValue)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerC
ontract, JsonProperty containerMember, Object existingValue)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Deserialize(JsonReader reader, Type objectType, Boolean checkAdditionalContent)
   at Newtonsoft.Json.JsonSerializer.DeserializeInternal(JsonReader reader, Type objectType)
   at Newtonsoft.Json.JsonSerializer.Deserialize(JsonReader reader, Type objectType)
   at Newtonsoft.Json.JsonSerializer.Deserialize[T](JsonReader reader)
   at Microsoft.VisualStudio.Services.WebApi.JsonUtility.FromString[T](String toDeserialize, JsonSerializerSettings settings)
   at Microsoft.VisualStudio.Services.Agent.Worker.Worker.RunAsync(String pipeIn, String pipeOut)
   at Microsoft.VisualStudio.Services.Agent.Worker.Program.MainAsync(IHostContext context, String[] args)

It is not clear from the error what is wrong. The same agent is able to build some builds which tells me that there is no issue with the PAT token or the injected environment variables. This is running as a container in AKS

Hi @getvivekv thanks for reporting! We are working on more prioritized issues at the moment, but will get back to this one soon.

Any resolution or idea why this is happening. Same problem here. Self Hosted agent  via self hosted kubernetes

##[error]Newtonsoft.Json.JsonReaderException: Invalid character after parsing property name. Expected ':' but got: m. Path 'jobContainer', line 1, position 30728.
at Newtonsoft.Json.JsonTextReader.ParseProperty()
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateObject(Object newObject, JsonReader reader, JsonObjectContract contract, JsonProperty member, String id)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Deserialize(JsonReader reader, Type objectType, Boolean checkAdditionalContent)
at Newtonsoft.Json.JsonSerializer.DeserializeInternal(JsonReader reader, Type objectType)
at Newtonsoft.Json.JsonSerializer.Deserialize(JsonReader reader, Type objectType)
at Newtonsoft.Json.JsonSerializer.Deserialize[T](JsonReader reader)
at Microsoft.VisualStudio.Services.WebApi.JsonUtility.FromString[T](String toDeserialize, JsonSerializerSettings settings)
at Microsoft.VisualStudio.Services.WebApi.JsonUtility.FromString[T](String toDeserialize)
at Microsoft.VisualStudio.Services.Agent.Worker.Worker.RunAsync(String pipeIn, String pipeOut)
at Microsoft.VisualStudio.Services.Agent.Worker.Program.MainAsync(IHostContext context, String[] args)
Error reported in diagnostic logs. Please examine the log for more details.
- /azp/_diag/Worker_20220707-062214-utc.log
,##[error]We stopped hearing from agent linuxagent-nao-7d67dd7db8-jnlnj. Verify the agent machine is running and has a healthy network connection. Anything that terminates an agent process, starves it for CPU, or blocks its network access can cause this error. For more information, see: https://go.microsoft.com/fwlink/?linkid=846610
Started: 7 Jul at 07:34
Duration: <1s

I'm also running self-hosted agents on AKS and getting the exact same thing reported here: sometimes it succeeds first time and other times you need to run 2-3 times for it to succeed because you keep getting the dreaded We stopped hearing from agent. It seems to appear randomly on unrelated stages doing a whole range of different tasks.

Hi @getvivekv @BenH-Puregym @markatky46 could you please share more information on this approach:

Agent version in which the problem occurred
minimal YAML definition and AKS configuration which can help us reproduce the problem

If you have any private information, please send it to<EMAIL_ADDRESS>Thanks

@KonstantinTyukalov, always pulls the latest, it just uses this script at the time of writing it's using 2.210.1
unsure what i can provide on your second point because the agent is just built on linux using the script i mentioned above with some added extras and then that's deployed to AKS as a Keda deployment. In devops it's completely random, there's no specific task which triggers it. Could be building a site, running a script or even sending a http request.
let me know if you need anything else.

Hi all,
@mmrazik and the team are working on debugging this issue however we are having difficulty reproducing. We believe there is a truncation of the JSON payload which is causing the error based on what we can see from the Azure DevOps Pipeline side. Anyone able to work with us on a shared debugging effort?

@BenH-Puregym, @getvivekv We will need some help here from you on your specific setup as we can't reproduce the issue despite trying for several days. Looking at the code we are using standard and very widely used library to serialize/deserialize the json and I don't expect the issue be there. More likely there is something in your environment that triggers this and we would need more info (e.g. are you using ScaledObject or ScaledJobs). Based on the log snippets it almost looks like the http payload has been truncated.
It would be best if you could guide me through your environment during a call. Feel free to drop me an e-mail when/whom to include to martinmrazik (at) microsoft (dot) com

@mmrazik My team reports that they are no longer seeing this error after we had the outage on Azure which forced us to reboot all the nodes on the Kubernetes cluster. The team also moved several of the critical pipeline to use a VM based agent as this was a blocker for us for several weeks. Currently it is not reproducible. The agents were running on AKS with Istio service mesh with mTLS enabled.

Ok. I am closing this for now.

this issue still happens with self-hosted windows agent. I just logged my bug here: https://github.com/microsoft/azure-pipelines-agent/issues/4813


[Conflict Fix] Partial Rust Enum Serialization/Deserialization Support

This fixes conflicts introduced here.
https://github.com/flavray/avro-rs/pull/60
All credit goes to @jdeschenes for implementing the original feature.

I'm not exactly sure what went wrong with the build here..

@poros Do you know what went wrong on the build? It looks like cargo check worked fine.

I am not really sure what the first error is, perhaps something transient caused by travis? Anyways, I have re-started the build and it fails with compilation errors. Maybe you can try to run make test locally and see if your branch works on your machine?

It looks like you just forgot to use serde::Serialize; in the test module of de.rs, the other two things were deprecation warnings that shouldn't break the stable and nightly builds

@codehearts Thanks! I must have missed that when fixing merge conflicts

Ah, now it looks like cargo fmt needs to be run on the repo for the build to be happy

@codehearts I will grab this later tonight :)

@calvinbrown085 are you still interested in this PR? It was pretty close to land!

@poros Yes! I will grab this.

@poros Okay I ran cargo fmt lets see if this passes :)

@poros Anything else here?

Nothing else, thanks :)


Applies refine settings to filter artworks

Related to #972.
@orta I had some questions about how to use the embedded model view controller. Specifically, what are you thoughts on an approach to display not just artworks? We'll need two different cells, one for each masonry/list layout. Could we chat tomorrow sometime?
In the mean time, filtering by price works :tada: and I shored up the tests around the sale view model.

The embedded models VC powers the favouritesVC, so it's being used for Artists/Shows/Artworks, SaleLots is just another model to be embedded :+1:

Cool, looks good :+1:

Thanks Orta, will look there :bow:


Fix issue 124

Switched to 'darkgrid' axes style to improve readability, issue #124
Also this fix another issue. The plotting.context function tries to set 'axes.facecolor' and 'figure.facecolor' properties using seaborn.plotting_context(), but that cannot work. seaborn.plotting_context() is intended to control the scale of plot elements while seaborn.axes_style() fucntion should be used for the style. So a combination of the two is required to have full control of the plotting properties. See http://seaborn.pydata.org/tutorial/aesthetics.html

LGTM, thanks!


Frontend development to enable table for user configuration of Facets and columns to be displayed when needed.

Issue Name
Frontend development to enable table for user configuration of Facets and columns to be displayed when needed.
Summary
The user configuration table dialogue should be accessed from at least 3 locations,

configure columns on the main data table (This should only show the active columns and column order items
configure the available filters in the filter section (This should only show the active filters section)
in the user configuration settings, which should include all the sections


GraphQL::Guard::NotAuthorizedError: 500 instead of 401. How to rescue?

This is NOT a bug and I immediately apologize for this issue but I'm newbie in Ruby, Rails and this amazing gem.
When I get this: GraphQL::Guard::NotAuthorizedError:
{
	"status": 500,
	"error": "Internal Server Error",
	"exception": "#<GraphQL::Guard::NotAuthorizedError: Query.users>",
	"traces": {
		"Application Trace": [
			{
				"id": 35,
				"trace": "app/controllers/graphql_controller.rb:11:in `execute'"
			}
		],
		"Framework Trace": [
			{
				"id": 0,
				"trace": "graphql-guard (1.0.0) lib/graphql/guard.rb:12:in `block in <class:Guard>'"
			},
			{
				"id": 1,
				"trace": "graphql-guard (1.0.0) lib/graphql/guard.rb:38:in `block in instrument'"
			},
			{
				"id": 2,
				"trace": "graphql (1.7.6) lib/graphql/field.rb:230:in `resolve'"
			},
			{
				"id": 3,
				"trace": "graphql (1.7.6) lib/graphql/execution/execute.rb:254:in `call'"
			},
			{
				"id": 4,
				"trace": "graphql (1.7.6) lib/graphql/schema/middleware_chain.rb:45:in `invoke_core'"
			},
			{
				"id": 5,
				"trace": "graphql (1.7.6) lib/graphql/schema/middleware_chain.rb:38:in `invoke'"
			}, ....................

I would prefer something like REST API Unauthorized error 401.
How to do that?
I have to rescue that exception?
Something like:
render json: ["Error 401. Unauthorized."], status: :unauthorized

Hey @johnunclesam!

I would prefer something like REST API Unauthorized error 401.
How to do that?

That's a good question. Unfortunately, currently, it's not possible with the gem out of the box.
One of the reasons is because GraphQL doesn't care about the transport level (HTTP). That is why when you get a query error (like syntax or type), GraphQL by default will return 200 OK and the array of errors in the response itself. So, it's very common to always return 200. That's why I even create the gem https://github.com/exAspArk/graphql-errors.
If you still would like to return custom HTTP status code, you can raise an exception and rescue it in the controller:
MySchema = GraphQL::Schema.define do
  query QueryType
  use GraphQL::Guard.new(
    not_authorized: ->(type, field) { raise MyException }
  )
end

# controller
...
rescue MyException
  render json: ..., status: :unauthorized
end

@johnunclesam you can also follow the discussion https://github.com/rmosolgo/graphql-ruby/issues/1130 in case if somebody will reply :)

Thanks for your answer.
Your link to that discussion got me to this: https://www.graph.cool/docs/faq/api-eep0ugh1wa/#how-does-error-handling-work-with-graphcool
and this:

Notice that HTTP status codes are not relevant when using GraphQL! A GraphQL server will always respond with code 200 (unless an internal server occured, then it might be code 500). Any further information needs to be parsed from the JSON payload of the response.

So the question is: with grahql-guard I receive 500 on NotAuthorized like this:
{
	"status": 500,
	"error": "Internal Server Error",
	"exception": "#<GraphQL::Guard::NotAuthorizedError: Query.players>",
	"traces": {
		"Application Trace": [
			{
				"id": 35,
				"trace": "app/controllers/graphql_controller.rb:10:in `execute'"
			}
		],
		"Framework Trace": [
			{
				"id": 0,
				"trace": "graphql-guard (1.0.0) lib/graphql/guard.rb:12:in `block in <class:Guard>'"
			},
			{
				"id": 1,
				"trace": "graphql-guard (1.0.0) lib/graphql/guard.rb:38:in `block in instrument'"
			},

is it correct?
Isn't better to response with 200 and error: "You are not authorized" as the graphql specs says?

Yes, if you would like to return 200:
SchemaWithErrors = GraphQL::Schema.define do
  query QueryType
  use GraphQL::Guard.new(
    # Returns an error in the response
    not_authorized: ->(type, field) { GraphQL::ExecutionError.new("Not authorized to access #{type}.#{field}") }
  )
end

https://github.com/exAspArk/graphql-guard#error-handling
Which can become a default behavior in the future (don't want to introduce breaking changes for now).

I vote for default behavior. Also from now. Thanks a lot.


Add Cmdlet Prefixes

Fixes issue #76.
Added Polaris as a prefix to commands:
i.e. New-WebRoute becomes New-PolarisWebRoute

Awesome! Thanks for this. I'll merge this in as soon as I get https://github.com/PowerShell/Polaris/pull/77 merged in since it's a rather lengthy PR

I recommend changing the nouns to be more concise while we are at it.
New-PolarisRoute
New-PolarisMiddleware

@doug-reimer I just merged in a big PR by @TimCurwick (thank for that Tim!)  who added quite a bit of Pester tests that all use the old naming convention.
These will also need to be updated with this PR.
I would be incredibly thankful (get it? Because it's Thanksgiving) for that update - otherwise, I'm happy to address it when I get back from vacation!
Thanks a lot for contributing!

I'll get those updated.

I modified a couple of the Cmdlet names to improve conciseness as per @TimCurwick suggestion.

I have fixed the typo in the example. Is keeping the reference to "route" in middleware important to identifying the "type" of middleware?

Very good point. We may want to have a different type of middleware in the future.
Ill merge this in. Thanks for contributing!

I guess some of the wiki documentation will also have to be updated to reflect the the Cmdlet names.

This can actually be done with a single config line change is the module manifest: DefaultCommandPrefix = 'Polaris'
The test compatibility could hypothetically be fixed with Import-Module Polaris -Prefix '' in the tests, though I haven't tested it to verify.


Slow training

Thanks for the great implementation! I notice training is quite slow. Any pointers on what part of the code can be optimized for speed?

Nevermind. I found the note about KNN. Thanks!


FI main into WNP_ToastNotifications_L1

Forward integrating main into WNP_ToastNotifications L1
A few conflicts: accepted incoming changes for all, except for the solution file where I accepted both.

/azp run

closing without merging. Will open another PR later


Footer Not at Bottom of Gallery List on Mobile

Done in https://github.com/macterra/artx-market/commit/a45de10e2817f50eceb19b1752be7141c0bafcf7

tested


chore: include time and scope in log file

the title is misleading, because this is only for "console" ?
for logToOutputChannel, timestamp is redundant because vscode already shows a timestamp next to each message.
also, chore should be banned, it's a useless prefix. almost everything is either a "fix" or a "feature" (or a few other specific types). "chore" is over-used. this PR for example is a "fix".

the title is misleading, because this is only for "console" ?

???

also, chore should be banned, it's a useless prefix. almost everything is either a "fix" or a "feature" (or a few other specific types). "chore" is over-used. this PR for example is a "fix".

Personally, I think it's just a small adjustment...

also, chore should be banned, it's a useless prefix. almost everything is either a "fix" or a "feature" (or a few other specific types). "chore" is over-used. this PR for example is a "fix".

In principle, I agree. The Angular ones are

build
chore
ci
docs:
style
refactor
perf
test

One could argue this PR is a feat, but I don't know if it's something that needs to be explicitly release-noted, either. I usually like chore for things that really couldn't fit into anything else, like linter changes/runs (since those aren't really "build", and perhaps aren't always "style")


Spin 0.3.0-alpha release

My last four PRs (in progress) will make some breaking changes to our API, namely:

translateClassPaths are no longer relative to project/lib, but instead just project.  clients that used this param must add the 'lib/' themselves.
j2objcConfig must end with a call to configureNativeBuild()
shared .dylib libraries are disabled by default

Can I request a 0.3.0-alpha spin after these all go through?

Sure, I've got some other changes too
On Fri, Jun 12, 2015 at 3:27 PM Advay Mengle<EMAIL_ADDRESS>wrote:

Assigned #166 https://github.com/j2objc-contrib/j2objc-gradle/issues/166
to @brunobowden https://github.com/brunobowden.
—
Reply to this email directly or view it on GitHub
https://github.com/j2objc-contrib/j2objc-gradle/issues/166#event-330011367
.

Great, shall we make it a standard to have a release spin issue like this where we document the known changes?  That way we can make sure README.md in the version is good?

Busy for a while now. I'll get through all of this later tonight.
On Fri, Jun 12, 2015, 3:34 PM Advay Mengle<EMAIL_ADDRESS>wrote:

Great, shall we make it a standard to have a release spin issue like this
where we document the known changes? That way we can make sure README.md in
the version is good?
—
Reply to this email directly or view it on GitHub
https://github.com/j2objc-contrib/j2objc-gradle/issues/166#issuecomment-111633720
.

All pending bugfixes for 0.3 should be PR/merged into release_v0.3.0-alpha not master

Plugin published, release created. Have a look @advayDev1 and let me know if everything is order. Then shall I go ahead and delete the release branch?


Support for remote resources in kustomize

The purpose of this commit is to allow us to use the remote resources of kustomize.
We envision the following uses
git clone https://github.com/m3y/descheduler-kustomize.git
cd descheduler-kustomize/
kustomize build . | kubectl apply -f -

an example of how to use the descheduler via kustomize
I would be very happy to have you review it!
Thank you 😄

/assign @aveshagarwal

Also, worth dropping metadata.namespace field from ClusterRole and ClusterRoleBinding objects in rbac.yaml given it has no effect.

@ingvagabund
Thank you for your review!!
I had mentioned in the README how to use the kustomization.yaml file, but I changed it to an easier method for installation.
I have omitted the configmap update patch as it is kustomize-specific.
This provides a way to install the descheduler without the need for additional files.
I'm not very good at English, so I'm sorry if I didn't understand your intentions well :bow:

/lgtm

@damemi I have squashed it, please confirm :bowing_man:

/lgtm


Multi wallet support

Description

This PR adds multi wallet support with a basic ui. The UI is not finished yet.
Please note that as the UI is not finished yet I did not make the strings translatable.
Also some of the UI elements might be a bit unfinished.
Motivation and Context

With this PR we can test and play arround with multi wallet support before releasing it.
How Has This Been Tested?

On my S9, Api 29
Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the Contribution document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

@michaelWuensch I'm having issues building this after following the instructions. I'm getting
error: cannot find symbol class ManageWalletsActivity

This is my first time playing around with Android source code so it could be my fault :)

@michaelWuensch I'm having issues building this after following the instructions. I'm getting
error: cannot find symbol class ManageWalletsActivity

This is my first time playing around with Android source code so it could be my fault :)

oh, I see... you also have to add the following line in the imports in the SettingsFragment.java file
import zapsolutions.zap.walletManagement.ManageWalletsActivity;
My Android Studio did this automatically when uncommenting stuff so I forgot to mention that.

Will be replaced with a new PR soon


feat: add mount overload that allows html element argument

Description

Adds the mount(element: Element) overload to Elements types.

Testing required outside of automated testing?

[x] Not Applicable

Screenshots (if appropriate):

[x] Not Applicable

Rollback / Rollforward Procedure

[x] Roll Forward
[ ] Roll Back

Reviewer Checklist

[ ] Description of Change
[ ] Description of outside testing if applicable.
[ ] Description of Roll Forward / Backward Procedure
[ ] Documentation updated for Change

:tada: This PR is included in version 1.75.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Not able to browse for extensions on new spotify update

🔍 Is there already an issue for your problem?

[X] I have checked older issues, open and closed

ℹ Environment / Computer Info
- Spotify version:
<IP_ADDRESS>1
- Spicetify version:
2.36.11

📝 Description
Unsure why but Spicetfiy Marketplace only shows installed extensions. Not able to browse or add extensions
📸 Screenshots
No response

Not cli related. Update marketplace by installing it again

Same here, tried reinstalling, nothing helps


Support for videos download. (Done)

Hello, akurtovic I understand this is not a issue, however I wanted to run something by you and wasn't really sure of the best way to reach you. However, iv been using your InstaRaider program for some time now and really like it, and wanted to commit some work to it, spec the support for videos downloads, Iv made a branch of the repo on my profile, and got it to work, however it may need work but never the less I wanted you to look over it, I'm not big on GitHub, I'm not sure how to run commits and stuff, my current repo isn't up to date with yours and I'm having a hard time understanding how to use GitHub properly and syncing your repo, Iv worked on the code for some time, but iv been putting it off alot lately due to not knowing what I'm doing here :( ...  I'm just lacking the knowledge of GitHub. PS when you have time could you take a look at my branch?

Sorry I'm just responding now. I've put this project on the back burner for a while. I tried to look at your fork but I didn't see any of your commits there. I could have missed it in my cursory glance. You can always just email me at<EMAIL_ADDRESS>if you want and I can help you figure out the Git stuff.


Added support for dns-search and fixes #30102

- What I did
This PR adds support for --dns-search option for windows. It also fixes https://github.com/docker/docker/issues/30102 Support for dns-search  requires platform support and will only work with the next version of windows.
- How I did it
- How to verify it
Verified the bug fix using the steps Jason mentioned and also validated that dns-suffix is set on the latest builds.
- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

This will require latest windows platforms to work. It will not throw any error on older builds but the option will be silently ignored. This is the present behavior. Do we want to change it so that specifying --dns-search throws error on unsupported platforms?

This will require latest windows platforms to work. It will not throw any error on older builds but the option will be silently ignored. This is the present behavior. Do we want to change it so that specifying --dns-search throws error on unsupported platforms?

I think that would probably be a good idea.

Does this also require any doc updates?

@jhowardmsft Not sure if it requires a doc update. Perhaps we can add somewhere that dns-search is only supported for rs2. Since we are now throwing an error it should be alright.

LGTM. Thanks for doing the updates @msabansal

@jhowardmsft @johnstep Can we merge or do I split these?
The test failures don't look related to this change. Can we rerun or should I triage?

@msabansal looks like @johnstep has minor comment for you

@LK4D4 code looks good and the comment is really a nit. Let's merge this and do a quick follow-up 👼


Improve top-level error handling

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Should we just accept anyhow::Error or something else generic?

I'd just like to throw in my 5 cents while you're considering error handling. With the new axum support, the lack of implementation of IntoResponse for worker::Error presents a bit of an awkward usability problem when working with axum.
I currently have this newtype wrapper to work around and preserve the ergonomics of the ? operator.
pub struct ErrWrapper(worker::Error);

impl From<worker::Error> for ErrWrapper {
    fn from(value: worker::Error) -> Self {
        ErrWrapper(value)
    }
}

impl IntoResponse for ErrWrapper {
    fn into_response(self) -> axum::response::Response {
        (StatusCode::INTERNAL_SERVER_ERROR, self.0.to_string()).into_response()
    }
}

pub type Result<T> = StdResult<T, ErrWrapper>;

Should we just accept anyhow::Error or something else generic?

Can't it just take a Result<T, Box<dyn std::error::Error>>?

Yes, I believe the current consensus is that the return type is something like that where T: Into<web_sys::Response>.


hotfix for IE/Edge text reversal on Windows

@chaw this should fix the iE text reversal problem. Please test and deploy ASAP.

I changed the base to develop instead of master.