Goal likes

Adding and removing likes
Getting all goal likes
Checking the like status of a user for a particular goal

Nice work. Real nice work


Add support of categorical features of types int and bool

ebm2onnx version: 1.1.0
Python version: 3.7
Operating System: Linux

Description
Currently, the categorical features are supported only for string types. We should also support int and booleans as categorical features. For these types, no CategoricalMapper is needed.

I just ran into that issue.

I have several evolutions planned to support the upcoming interpret release.
I will see if I can add this support before.

Thanks a lot @MainRo!


Use SCPStatementType type directly in _pledges_t

@Geod24 I've noticed that log.info doesn't format enums nicely. For example, it will not print out the name of the enum, but instead just its value. So stringification will only be better if format is used from Phobos.
E.g.:
enum E { foo, bar }
E e = E.bar;
log.info("{}", e);  // will just print out '1' instead of 'bar'

Yeah the formatter does not support enum because D1 didn't make it possible. It should be a simple fix now that upstream dropped D1.


Bug: Incorrect folder reference in Dependabot

Is there an existing issue for this?

[X] I have searched the existing issues

Package ecosystem
nuget
Package manager version
No response
Language version
No response
Manifest location and content before the Dependabot update
No response
dependabot.yml content
https://github.com/appium/dotnet-client/blob/main/.github/dependabot.yml
Updated dependency
Bumps Selenium.WebDriver from 4.24.0 to 4.25.0.
What you expected to see, versus what you actually saw
Expected:
The other PR in the Repo:
https://github.com/appium/dotnet-client/pull/830/files
Actual
Title of PR:
build(deps): bump Selenium.WebDriver from 4.24.0 to 4.25.0 in /test/integration
Current file modified:
src/Appium.Net/Appium.Net.csproj
Native package manager behavior
No response
Images of the diff or a link to the PR, issue, or logs
https://github.com/appium/dotnet-client/pull/837
Smallest manifest that reproduces the issue
No response

Thank you for filing the issue.  The PR title references the /test/... directory because that's where dependabot initially started, but due to a <ProjectReference> element, the actual dependency had to be updated elsewhere.
We're currently planning a large-scale rewrite of the NuGet updater that will be able to more accurately report the dependency directories, but in the meantime the PR title will still show the directory where the update job was first started.


Compiler warnings with gcc 8.2.0

trivial-signal-20151031-git/src/grovel__grovel.c:564:16: warning: extra tokens at end of #ifdef directive
 #ifdef SIGRTMIN+1
                ^

These are repeated for every of these #ifdef lines; perhaps that's something that should be fixed in CFFI, though.

I think I misunderstood that there would be a C macro named "SIGRTMIN+1", but if I think just more bit it was obvious that there is just one SIGRTMIN macro and SIGRTMIN+1 is nothing more than an addtion. I will just remove those extra symbols.


parallax: non-uniform texture fetches

The parallax shader uses samples the normal map in a non-uniform branch (https://github.com/SaschaWillems/Vulkan/blob/master/data/shaders/parallax/parallax.frag#L73), which procudes invalid SPIR-V up to my understanding: SPIR-V Spec, 2.20 Code Motion:

Texturing instructions in the Fragment Execution Model that rely on an implicit derivative cannot be moved into control flow that is not known to be uniform control flow within each derivative group.

Assuming the texture doesn't have mipmaps, which I believe is the case here, can the texturing instruction be said to "rely on an implicit derivative"? If not, it seems OK, but I don't actually know how SPIR-V works here...
I suppose a fix, if needed, would be to use textureLOD() with lod=0 instead?

Also, taking a second look, is that actually a non-uniform branch? All the control flow seems to be based on values in UBOs, so should be draw-call uniform right?

@cforfang The break condition depends on the read texture at non-uniform texture coordinates. Therefore it appears to me that the control flow is non-uniform for the executed primitive group.

Ah, right, yes -- I completely missed that :) I still don't quite get the wording in the SPIR-V spec when it says "cannot be moved". Who's moving anything? I assumed the spec is meant to describe what must be true in valid SPIR-V, but this almost sounds like a directive to compilers.
By contrast, if it said something like "Texturing instructions in the Fragment Execution Model that rely on an implicit derivative cannot be placed in control flow that is not known to be uniform control flow within each derivative group." that seems pretty clear, but as-written it almost sounds more like it's meant to tell compilers it should not move texturing-instructions around without considering uniform control flow during compilation.
In any case, to be 100% sure this is legal I guess {{textureLod()}} is the way to go.

Agree, opened an issue on the official repository: https://github.com/KhronosGroup/SPIRV-Headers/issues/58

Ah, sorry -- didn't see your edit that you were going to do it :) I agree, please check if #431 looks OK.

Fixed in https://github.com/SaschaWillems/Vulkan/pull/431


Grey cell fixes

Fix critical bug resulting in invalid HDL due to swapped cell inputs
Fix logical efforts on grey cells' inputs

Adding in another commit that makes buffer cells non-adder-specific, like with other types of cells.

Manually merging this in; critical bugfix.


Delete unnecessary spaces

When copying from the web page, there is an unnecessary space after the code.

@changeworld : Thanks for your contribution! The author, @mikejo5000, has been notified to review your proposed change.

@changeworld Thanks for the fix!

#sign-off


PDF delete particular pages

script name - PDF particular page remover
Brief about script - This script allows you to delete one or more pages from a PDF of your choosing
Issue no. - #572
Self Check

[x] This issue was assigned to me.
[x] One Change in one Pull Request
[x] My file is in proper folder (Name of folder should be in lowercase with no space in between) (E.g. meet_schedular)
[x] I am following clean code and Documentation and my code is well linted with flake8.
[x] I have added README.md and requirements.txt (Include version numbers too e.g. pandas==0.0.1) with my script
[x] Just including required dependencies in requirements.txt (Don't include Python version too)

Nice work @sighclone xD


fix: 🐛 add warning to use the new npm repository

Description
Adds a warning to let people know to update their package.json file. We'll need to remove these changes when we pull into beta.
Breaking Changes

JIRA Link

Checklist

[ ] Updated the Readme.md (if required) ?

:tada: This PR is included in version 14.1.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 15.0.0-beta.7 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[plugins] Support not exact matching of expected warnings

need to add a property for EXACT match of warnings: exactWarningsMatch = true (default)
What if save will expect 5 warnings and receive 6 (if static analyzer is not configurable and can show only all warnings by the default)

originally posted in https://github.com/cqfn/save/pull/39#discussion_r621986065

@kentr0w pls look at this, not a boring task


chore: move tests to origin pull request, update and clean also

Here we clean a simplify the license test to be part of the origin tests.

I am going to merge this PR in. But there still remains some flakyness in other tests that are NOT addressed here.

Lint test's are false negative. We don't need to change chart version if there is no changes to the chart itself.


Add documentation for multi-arena episodes

Proposed change(s)
This change adds a bit of documentation for the multi-episode arenas feature I've been working on. Arguably we should save this until that feature is merged an released, but getting the documentation PR done so we don't forget it.
Types of change(s)

[ ] Bug fix
[X] New feature
[ ] Code refactor
[ ] Breaking change
[X] Documentation update
[ ] Other (please describe)

Checklist

[N/A] Added tests that prove my fix is effective or that my feature works
[N/A] Updated the changelog (if applicable)
[X] Updated the documentation (if applicable)
[N/A] Updated the migration guide (if applicable)

Looks great Ben :)
Q: have you updated the other sections of the docs, where applicable, such as CHANGELOG.MD? For the sake of not forgetting any docs to update, perhaps it's better to update all other docs in this PR?
@benaslater

Looks great Ben :)
Q: have you updated the other sections of the docs, where applicable, such as CHANGELOG.MD? For the sake of not forgetting any docs to update, perhaps it's better to update all other docs in this PR?
@benaslater

Sorry, I forgot about CHANGELOG.md. I can make a revision to this to update it - are there any other files in the docs you think would need updating?

Perhaps you could update the changelog as a draft or remind me when the next build is to be released so I add your changes to the log, but for now, it's not important. I just wanted to ask if you considered the changelog.md in this PR.
I think as a general feedback you should aim to push the tech PR first and then push the docs on the docs, so its still fresh in your mind and you don't have to go back to the docs PR if changes are made in the tech PR. :)


Add golangci-lint

Which problem is this PR solving?

Fixes https://github.com/jaegertracing/jaeger/issues/2503

Short description of the changes

Enable a few linters on golangci-lint to start

Signed-off-by: Dax McDonald<EMAIL_ADDRESS>Happy Hacktoberfest 🎃

I would prefer if there is a make target that would allow running all the lint checks locally, not only in GH actions.

I would prefer if there were a make target that would allow running all the lint checks locally, not only in GH actions.

If we have a config in the repo like the .golangci.yml from this PR, it would be a matter of only running golangci-lint in the base directory, and we could still have the GitHub action for it. The advantage of using an action is that it caches the tool, which would save us a minute or two for each build.
That said, I'd rather have this PR use the official action instead of what we have here. Reference: https://github.com/observatorium/opentelemetry-collector-builder/blob/c725aab7de2c3f782f8273ae4cc96faf21747290/.github/workflows/go.yaml#L27-L39

@yurishkuro thanks for the review!
Do you think this should be a separate yml file? I was planning to nest it under ci-unit-test.yml

for now let's keep it in ci-unit-tests.yml
Can you actually enable any linters? The job is not checking anything right now.

Can you actually enable any linters?

How did you assess that? The configuration looks sane to me and I would guess that the following linters were used, but I wonder if you are looking at some place with a positive confirmation about the linters that were used for the specific run.
https://github.com/jaegertracing/jaeger/pull/2602/files#diff-6179837f7df53a6f05c522b6b7bb566d484d5465d9894fb04910dd08bb40dcc9R10-R37

configuration says disable-all: true, and the job completed too quickly

It does say disable-all, but then it enables linters individually. As opposed to enable-all and disable individually. It took about 10s for the linting phase alone, which is what I would expect the job to take.

Ran golangci-lint in 9282ms

https://github.com/jaegertracing/jaeger/pull/2602/checks?check_run_id=1478020447

gosec alone takes 2min:
$ make lint-gosec
time gosec -quiet -exclude=G104,G107 -exclude-dir=cmd/opentelemetry ./...
      120.03 real       236.28 user       195.93 sys

With the config file, you can use golangci-lint -v run to see what the linter picks up and how long it takes.
There are a few open lint issues. We can address those here or in a separate PR.

Output
golangci-lint -v run
INFO [config_reader] Config search paths: [./ /Users/dax/projects/jaeger /Users/dax/projects /Users/dax /Users /]
INFO [config_reader] Used config file .golangci.yml
INFO [lintersdb] Active 10 linters: [deadcode gofmt goimports golint gosec govet staticcheck structcheck typecheck unused]
INFO [loader] Go packages loading at mode 575 (exports_file|files|imports|name|types_sizes|compiled_files|deps) took 1.012619813s
INFO [runner/filename_unadjuster] Pre-built 0 adjustments in 35.883375ms
INFO [linters context/goanalysis] analyzers took 83.376645ms with top 10 stages: buildir: 17.607961ms, goimports: 11.697858ms, gosec: 8.840719ms, gofmt: 7.785945ms, golint: 5.979534ms, SA1012: 1.844425ms, SA1013: 1.646506ms, printf: 1.482018ms, deadcode: 1.420496ms, ctrlflow: 1.231694ms
INFO [linters context/goanalysis] analyzers took 22.52245ms with top 10 stages: buildir: 17.317955ms, U1000: 5.204495ms
INFO [runner/skip dirs] Skipped 1 issues from dir examples/hotrod/services/frontend by pattern (^|/)examples($|/)
INFO [runner/skip dirs] Skipped 1 issues from dir examples/hotrod/services/customer by pattern (^|/)examples($|/)
INFO [runner/skip dirs] Skipped 69 issues from dir examples/hotrod/services/driver by pattern (^|/)examples($|/)
INFO [runner/skip dirs] Skipped 1 issues from dir examples/hotrod/services/route by pattern (^|/)examples($|/)
INFO [runner/max_same_issues] 9/12 issues with text "G404: Use of weak random number generator (math/rand instead of crypto/rand)" were hidden, use --max-same-issues
INFO [runner/max_same_issues] 4/7 issues with text "G306: Expect WriteFile permissions to be 0600 or less" were hidden, use --max-same-issues
INFO [runner/max_same_issues] 4/7 issues with text "File is not `goimports`-ed" were hidden, use --max-same-issues
INFO [runner] Issues before processing: 3983, after processing: 21
INFO [runner] Processors filtering stat (out/in): max_same_issues: 21/38, max_from_linter: 21/21, severity-rules: 21/21, cgo: 3983/3983, filename_unadjuster: 3983/3983, skip_files: 3983/3983, exclude-rules: 39/339, uniq_by_line: 38/39, path_prettifier: 3983/3983, nolint: 39/39, source_code: 21/21, path_shortener: 21/21, sort_results: 21/21, skip_dirs: 3911/3983, autogenerated_exclude: 339/3911, diff: 38/38, max_per_file_from_linter: 38/38, path_prefixer: 21/21, identifier_marker: 339/339, exclude: 339/339
INFO [runner] processing took 38.919486ms with stages: nolint: 16.716437ms, path_prettifier: 7.979696ms, autogenerated_exclude: 6.675571ms, identifier_marker: 3.172654ms, exclude-rules: 1.69026ms, skip_dirs: 1.570182ms, source_code: 442.928µs, cgo: 358.105µs, filename_unadjuster: 255.942µs, max_same_issues: 26.884µs, uniq_by_line: 11.137µs, max_per_file_from_linter: 9.045µs, path_shortener: 4.857µs, max_from_linter: 3.756µs, skip_files: 621ns, exclude: 392ns, diff: 384ns, severity-rules: 264ns, sort_results: 233ns, path_prefixer: 138ns
INFO [runner] linters took 369.097097ms with stages: goanalysis_metalinter: 224.257539ms, unused: 105.765528ms
model/converter/json/from_domain_test.go:142:10: G306: Expect WriteFile permissions to be 0600 or less (gosec)
		err := ioutil.WriteFile(outFile+"-actual.json", buf.Bytes(), 0644)
		       ^
cmd/collector/app/sanitizer/cache/auto_refresh_cache.go:136:40: G404: Use of weak random number generator (math/rand instead of crypto/rand) (gosec)
	return (interval / 2) + time.Duration(rand.Int63n(int64(interval/2)))
	                                      ^
cmd/collector/app/server/grpc_test.go:80:19: G102: Binds to all network interfaces (gosec)
	listener, err := net.Listen("tcp", ":0")
	                 ^
pkg/discovery/grpcresolver/grpc_resolver.go:68:12: G404: Use of weak random number generator (math/rand instead of crypto/rand) (gosec)
	random := rand.New(rand.NewSource(seed))
	          ^
pkg/cassandra/mocks/Iterator.go:18: File is not `goimports`-ed (goimports)
import cassandra "github.com/jaegertracing/jaeger/pkg/cassandra"
import mock "github.com/stretchr/testify/mock"
pkg/cassandra/mocks/Query.go:18: File is not `goimports`-ed (goimports)
import cassandra "github.com/jaegertracing/jaeger/pkg/cassandra"
import mock "github.com/stretchr/testify/mock"
pkg/cassandra/mocks/Session.go:18: File is not `goimports`-ed (goimports)
import cassandra "github.com/jaegertracing/jaeger/pkg/cassandra"
import mock "github.com/stretchr/testify/mock"
pkg/es/wrapper/wrapper_nolint.go:23:30: method Id should be ID (golint)
func (i IndexServiceWrapper) Id(id string) es.IndexService {
                             ^
pkg/es/wrapper/wrapper_nolint.go:28:30: method BodyJson should be BodyJSON (golint)
func (i IndexServiceWrapper) BodyJson(body interface{}) es.IndexService {
                             ^
cmd/ingester/app/processor/decorator/retry.go:54:18: G404: Use of weak random number generator (math/rand instead of crypto/rand) (gosec)
	rand:           rand.New(rand.NewSource(time.Now().UnixNano())),
	                ^
pkg/queue/bounded_queue_test.go:57:3: SA2001: empty critical section (staticcheck)
		startLock.Unlock()
		^
plugin/sampling/strategystore/static/strategy_store_test.go:346:21: G306: Expect WriteFile permissions to be 0600 or less (gosec)
	require.NoError(t, ioutil.WriteFile(dstFile, srcBytes, 0644))
	                   ^
plugin/sampling/strategystore/static/strategy_store_test.go:367:21: G306: Expect WriteFile permissions to be 0600 or less (gosec)
	require.NoError(t, ioutil.WriteFile(dstFile, []byte(newStr), 0644))
	                   ^
storage/spanstore/token_propagation_test.go:25:2: G101: Potential hardcoded credentials (gosec)
	token := "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiJhZG1pbiIsIm5hbWUiOiJKb2huIERvZSIsImlhdCI"
	^
cmd/anonymizer/main.go:72:22: G601: Implicit memory aliasing in for loop. (gosec)
				writer.WriteSpan(&span)
				                 ^
model/converter/thrift/jaeger/from_domain.go:106:37: G601: Implicit memory aliasing in for loop. (gosec)
		jaegerTags[idx] = d.keyValueToTag(&kv)
		                                  ^
plugin/storage/badger/spanstore/read_write_test.go:142:4: var `lowId` should be `lowID` (golint)
			lowId := rand.Uint64()
			^
cmd/agent/app/reporter/grpc/reporter_test.go:60:2: SA5001: should check returned error before deferring conn.Close() (staticcheck)
	defer conn.Close()
	^
cmd/agent/app/reporter/grpc/reporter_test.go:98:2: SA5001: should check returned error before deferring conn.Close() (staticcheck)
	defer conn.Close()
	^
cmd/query/app/grpc_handler_test.go:138:12: G102: Binds to all network interfaces (gosec)
	lis, _ := net.Listen("tcp", ":0")
	          ^
cmd/query/app/token_propagation_hander_test.go:31:2: G101: Potential hardcoded credentials (gosec)
	bearerToken := "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiJhZG1pbiIsIm5hbWUiOiJKb2huIERvZSIsImlhdCI"
	^
INFO File cache stats: 18 entries of total size 105.4KiB
INFO Memory: 16 samples, avg is 90.0MB, max is 141.1MB
INFO Execution took 1.446295162s

I am specifying --only-new-issues in the Github Action config though. I don't believe this will throw any lint issues on the introductory PR.

gosec alone takes 2min
This seems like a great reason to use golangci-lint, the go sec errors I am seeing look the same, and golangci-lint runs much faster for me (1.446295162 seconds)

I am specifying --only-new-issues in the Github Action config though.

I think this is the key :-)

I am not sure what only-new-issues means: you still have to scan everything to discover IF there are new issues.
Why can't we run with -v in CI as well? That would at least provide some proof that the linters are running.

@jpkrohling my main concern with this is that by adding a whole set of new linters with new changes only mode, we're suppressing a lot of existing issues that will make life painful for future contributors, because their PRs may touch files where these issues exist and start breaking, forcing people to fix previously issues and distracting from the main goal of the PRs.
I think I would prefer instead to add linters one by one or in batches along with the corresponding fixes of ALL issues that a given linter flags. That way each PR could be reasonably sized and not push the burden of the actual fixes on the next random person who happens to touch the files.
For example, with the config in this PR:
$ golangci-lint -v --max-issues-per-linter 500 --max-same-issues 500 run | grep Error | wc -l
     189

because their PRs may touch files where these issues exist and start breaking, forcing people to fix previously issues and distracting from the main goal of the PRs

Good point and I agree with your proposal.

I'm happy to either reduce the number of enabled linters or fix the found issues.
To get this merged it might make more sense to enable less linters for now

I'd recommend enabling only those linters that currently pass on the whole repository.

After removing a few linters there were a few small issues remaining. These all looked like legitimate issues so I proceeded to fix them

Linter errors
INFO [runner] linters took 142.248311ms with stages: goanalysis_metalinter: 112.589465ms, unused: 7.165119ms
storage/mocks/ArchiveFactory.go:17: File is not goimports-ed (goimports)
import mock "github.com/stretchr/testify/mock"
import spanstore "github.com/jaegertracing/jaeger/storage/spanstore"
import storage "github.com/jaegertracing/jaeger/storage"
storage/mocks/Factory.go:17: File is not goimports-ed (goimports)
import dependencystore "github.com/jaegertracing/jaeger/storage/dependencystore"
import metrics "github.com/uber/jaeger-lib/metrics"
import mock "github.com/stretchr/testify/mock"
import spanstore "github.com/jaegertracing/jaeger/storage/spanstore"
import storage "github.com/jaegertracing/jaeger/storage"
import zap "go.uber.org/zap"
cmd/query/app/ui/placeholder.go:20: File is not goimports-ed (goimports)
"github.com/jaegertracing/jaeger/cmd/query/app/ui/placeholder"
plugin/storage/badger/spanstore/read_write_test.go:142:4: var lowId should be lowID (golint)
lowId := rand.Uint64()
^
model/converter/thrift/jaeger/from_domain.go:106:37: G601: Implicit memory aliasing in for loop. (gosec)
jaegerTags[idx] = d.keyValueToTag(&kv)
^
cmd/anonymizer/main.go:72:22: G601: Implicit memory aliasing in for loop. (gosec)
writer.WriteSpan(&span)
^
crossdock/main.go:112:23: response body must be closed (bodyclose)
res, err := http.Get(healthURL)
^
INFO File cache stats: 7 entries of total size 35.1KiB

Happy to revert any commits as needed

The run in the CI succeeds, but when I run it locally with the current config file I get a few errors. Where is the discrepancy coming from?
$ golangci-lint -v --max-issues-per-linter 500 --max-same-issues 500 run

Hmm, are you running on this branch? That exact command passes for me with
golangci-lint version 1.33.0
On Tue, Dec 8, 2020 at 1:09 PM Yuri Shkuro<EMAIL_ADDRESS>wrote:

The run in the CI succeeds, but when I run it locally with the current
config file I get a few errors. Where is the discrepancy coming from?
$ golangci-lint -v --max-issues-per-linter 500 --max-same-issues 500 run
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jaegertracing/jaeger/pull/2602#issuecomment-740958039,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHS5HJRALG47GHWFAKNDR3LST2BXRANCNFSM4TDHO26Q
.

Also, what makes it exclude examples?
INFO [runner/skip dirs] Skipped 69 issues from dir examples/hotrod/services/driver by pattern (^|/)examples($|/)
INFO [runner/skip dirs] Skipped 1 issues from dir examples/hotrod/services/customer by pattern (^|/)examples($|/)
INFO [runner/skip dirs] Skipped 1 issues from dir examples/hotrod/services/route by pattern (^|/)examples($|/)
INFO [runner/skip dirs] Skipped 1 issues from dir examples/hotrod/services/frontend by pattern (^|/)examples($|/)

I think examples code is a fair game for linter (unlike generated code).

Closing due to inactivity.


for protobuf with gRPC, suggest ignore  service field  or add gRPC support?

suggest 1:
as .proto like this
syntax = "proto3";

package apkaaa;

message ActiveReq {
 string serial = 1;
 string code = 2;
 string mac_address_1 = 3;
 string mac_address_2 = 4;
 string release_sn = 5;
}

message ME {
     string user_id = 1;
     string register_date = 2;
     string expiration = 3;
}

message Active {
    ME me =1;
    string token = 2;
}

message ActiveResp {
 repeated Active active =1;
}

service ApkAaaService {
    rpc Active( ActiveReq ) returns (  ActiveResp ) {}
}

should membuffers to ignore the service field ??
suggest 2:
as we know, gRPC support custom codec  like gRPC with flatbuffers,
should membuffers support gRPC ?
in go, gRPC codec interface
// Codec defines the interface gRPC uses to encode and decode messages.
// Note that implementations of this interface must be thread safe;
// a Codec's methods can be called from concurrent goroutines.
//
// Deprecated: use encoding.Codec instead.
type Codec interface {
	// Marshal returns the wire format of v.
	Marshal(v interface{}) ([]byte, error)
	// Unmarshal parses the wire format into v.
	Unmarshal(data []byte, v interface{}) error
	// String returns the name of the Codec implementation.  This is unused by
	// gRPC.
	String() string
}

sorry, i double check the docs first .


Removing JQuery from project broke some animation functionality

I'm still digging into exactly what happened - but I found that when I remove JQuery from my project, an animation that used to work using  no longer works. The animation uses percentages, and looks like this:
<VelocityComponent animation={{ marginLeft: !myFlag ? '0%' : '25%' }} duration={300}>
It used to animate from 0 to 25% margin-left with no problem when myFlag changed, but now it stays stuck at 25%. The style attribute appears to be stuck at calc(0px + 25%)
All of my other animations still work at the moment, including percentage-based widths. I will keep digging in to see if I can discover the problem - but I suspect it has to do with the jQuery shim, since jQuery is the only thing that has changed in my project.

Update - animation works with anything other than 0%. And the 0% to 25% animation works, it's only the 25% to 0% that does not work.

Now I'm pretty sure this was related to updating to the latest velocity-animate. Closing this here and will reopen in that project.


Clean Z_DATA selectively

Sometimes, jumps to certain directories become erroneous after extended periods of usage. Currently, the only way to fix it is by going to the "~/.z" file and removing every line referencing to the directory or running z --clean to wipe out Z_DATA which will result in loss of data for other directories.
Feature Request:
z [-c --clean] <directory_name>
eg.
z --c documents will remove all the entries in the .z file that matches 'documents'

I'm trying to understand your use case here. Would it be better if it were able to clean up directories that no longer exist?
z uses the "last accessed" heuristic, so folders that have not been recently accessed would be necroed and should rank low during completion.

bump?

For the most part, z would jump to the right folder. However, recently, I have been facing this issue.
eg.
I have following folder structure
~/Documents
~/Documents/Projects
Most of the time I in the projects folder and sometimes in the documents folder.
So when I z projects it jumps to ~/Documents/Projects which is perfect. However, when I z documents, it goes to ~/Documents/Projects instead of what I want which is ~/Documents.
I did not really get much time to take a look under the hood for z. Perhaps, my feature request does not actually solve the problem I have. It is only quick, easy temp. fix.

That's unfortunately the way z works: it matches the full string of the directory. You can blacklist a certain directory if you don't want it to be indexed. I could consider changing the implementation of z to match only the folder name and not the path, but I can foresee certain cases where that would be undesirable.
In general for common folders like ~/Documents, using z to navigate to them would not be ideal. What you want is really something like bashmarks. Let me know if you need this in fish, and I'll look into it.

Closing in favour of #20


Refactor random booleans into flipCoin function

Often, you just need a random boolean. Throughout Pokemon Showdown's code, there are many creative ways of requesting random booleans. For example:
if (this.random(10) < 3) {
if (this.isWeather(['sunnyday', 'desolateland']) || this.random(2) === 0) {
let shiny = !this.random(1024);
if (uberCount > 1 && this.random(5) >= 1) continue;
if (!this.random(3)) ability = ability1.name;
} else if ((ability === 'Iron Barbs' || ability === 'Rough Skin') && this.random(2)) {
if (typeof secondary.chance === 'undefined' || this.random(256) <= effectChance) {
if (accuracy !== true && this.random(256) > accuracy) {

Enable these methods to converge by introducing the PRNG#flipCoin function. It accepts a probability and returns true with that probability.
Notes for reviewers:

Commits are separated to improve archaeology and bug-finding. For example, the changes made in 8612729 and 6e3ffaf are behaviour-preserving and straightforward, but the changes made in 73d1bec and f7805c5 possibly affect behaviour and are prone to human error. I recommend rebasing or merging these commits as-is and not squashing them into a single commit.

Also, this introduces some tests that are by-design flaky. Is there some way to mark them as such in Mocha.js and maybe keep long-term track of them in Travis CI?

I don't like flipCoin very much, maybe randomChance or something?

Also flipCoin(1 / 2) is easier to read than flipCoin(1, 2), so assuming there's some way to implement that while preserving functionality (I think there is), that's a pretty good idea

I'd suggest renaming flipCoin => chance, so that this.chance(1, 1000) reads as "do with a chance of 1 in 1000".

I don't like flipCoin very much as a name, maybe randomChance or something?

Yeah, I think randomChance is a better name! I'll make adjustments.

Also flipCoin(1 / 2) is easier to read than flipCoin(1, 2)

I agree.
Unfortunately, floating point division like that leads to inaccuracies. 1/3 is inexact, for example.
Also, it's impossible to refactor existing calls to random(x) with that API while preserving cartridge RNG behaviour.

We strive to keep fidelity to the cartridge RNG behaviour, so we absolutely need the !flipCoin() pattern.

Alright. I'll undo those changes.
Is !flipCoin() needed for random-teams.js?

I made some changes:

Rename flipCoin to randomChance.
Make non-behaviour-preserving changes only to the random team generator.

Unfortunately, floating point division like that leads to inaccuracies. 1/3 is inexact, for example.

I know, but in theory these inaccuracies don't need to matter. In other words, 1/3 may be inexact, but it's still more precision than the actual in-game RNG does, so as long as we can still go from the inexact value to the value used in-game, the inexactness doesn't need to matter.

Hm, okay, but I'd probably want to simplify a few common calls:
randomChance(1, 2) => randomChance()
randomChance(1, n) => randomChance(n)

(Feel free to make a new pullreq for those changes)


Security contexts for workers

We have a need to provide a security context for workers to allow them to run as specific users. In particular we need them to be able to run as the same user as the coordinator as the shared image used in both needs a level of access to its filesystem. We are trying to run this cluster in an OpenShift environment, and have to deal with its restrictions on available user ids.
This change has been tested within our cluster, but I'm looking for feedback on whether this should be a separate security context for the workers vs coordinator.

👍

Duplicate of #48

The duplicate PR is merged. Closing.


Update submodule traces/

Since you got comfortable with our MIPS assembly and sub-modules, I advise you to continue with #378, but the choice is up to you.


Command to check bumpers?

First and foremost thanks for creating this library! I've been looking for such a long time for a quality library to use with the robot.
With that said, did you end up writing a command to check the bumper state? I'm trying to program the robot to let out an "angry" beep and write to an LCD when it bumps into something. If this isn't programmed in already, do you know how I would go about that? I was trying to mess with the library myself however I just find myself more and more confused lol

Take a look at the examples folder:

sensorExamples.py to see how to read the sensor messages. When you read them, you get everything. See the list of sensors here. Since the data returned is a namedtuple you can either do sensor.light_bumper_front_left or do sensor[37]. If you look through the list, the bumpers are there as either bool values or int values ... that is by iRobot design, not mine. The sensor.light_bumper_front_left will give you a value from 0 to 4095. There are corresponding center and right values too for the bumpers.

Google python and namedtuple if that is a new data structure for you. They are basically immutable data class that has a built in pretty print feature.
Some libraries add a lot of complexity to call out subsets of the robot's sensors, but the API is old and originally they had 19,200 bps interfaces when I was in grad school in the 1990's. Now they use 115,200 bps and it is really trivial to just get everything at once, so that is what I do.

displayExample.py is a simple example of how to write to the LCD

Good luck!

closing due to lack of activity


More meaningful error message

This little trick will provide a more meaningful when no implicit instance of Refute can be inferred.

Codecov Report

Merging #881 into master will not change coverage.
The diff coverage is 0%.

@@          Coverage Diff           @@
##           master    #881   +/-   ##
======================================
  Coverage    87.9%   87.9%
======================================
  Files          65      65
  Lines        1497    1497
  Branches        5       5
======================================
  Hits         1316    1316
  Misses        181     181

Impacted Files
Coverage Δ

core/src/main/scala/shapeless/refute.scala
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 906875e...b263679. Read the comment docs.

Did you try @ambiguoisImplicit?

I don't think that's a think actually @joroKr21

Ah my bad, it's called implicitAmbiguous. But it's @since 2.12.0 so no luck.

Also LGTM :-)
Many thanks ... merging ...


[Suggestion] Since all of the git-* commands are broken, why not use the pending/git- tools that toybox provides?

Since all of the git-* commands are broken, why not use the pending/git- tools that toybox provides? Toybox can compile toy's as independent tools, so, it is feasible and a much better alternative than providing binaries that don't work at all.

pending/git seems to be a very, very limited implementation. I might consider it if it was already in stable build.
There's already much better & mature alternatives (tested in a minimal alpine):

Jujutsu

❯ jj git clone [OPTIONS] <SOURCE> [DESTINATION]
❯ jj git clone --quiet "https://github.com/Azathothas/Toolpacks"

gitoxide

❯ gix clone "https://github.com/Azathothas/Toolpacks"

go-git

❯ git-clone <url> <directory>
❯ git-clone https://github.com/Azathothas/Toolpacks Toolpacks

All of these are already part of the build scripts and included in Toolpacks

Okay. I knew Gix, its great, I use it a loot.


[stable/rabbitmq] optionally skip set max file descriptor limit (#14020)

"ulimit -n" is not allowed in AWS EC2. The max file descriptor limit has to be set differently. Therefore there should be an option to not call ulimit command during the startup of the container, otherwise it fails in AWS EC2. This commit adds an option to disable ulimit.
Signed-off-by: Michal Artazov<EMAIL_ADDRESS>What this PR does / why we need it:
Skips ulimit -n command during container startup, which fails in AWS EC2.
Which issue this PR fixes

fixes #14020

Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/assign @sameersbn

Thank you for the PR. It seems to me that it could be easier that, instead of creating an env var with 0 and 1 and then adding an if statement, just do something like this
{{- if .Values.rabbitmq.setUlimitNofiles }}
              ulimit -n "${RABBITMQ_ULIMIT_NOFILES}"
{{- end }}

This would be much simpler and you wouldn't have to add the new env var

@javsalgar I changed my commit to reflect your suggestion. You're right, it's much nicer this way :)


Adds support for SDWebImage and takes preference over JMImageCache

Initial PR. I'd like to add some tests for the new :prepare_for_reuse method call.

302 specifications (610 requirements), 0 failures, 0 errors

Closes #683

Good work!

Thanks man!


Change certificate hypothetic path

Certificate was create with different path on the examples.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "patch-1" git@github.com:igayoso/distribution.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Current coverage is 52.89%

Merging #1443 into master will decrease coverage by -4.26% as of 81b4cbe

@@            master   #1443   diff @@
======================================
  Files          123     123
  Stmts        11386   11386
  Branches       799     729    -70
  Methods          0       0
======================================
- Hit           6508    6023   -485
+ Partial        799     729    -70
- Missed        4079    4634   +555

Review entire Coverage Diff as of 81b4cbe

Uncovered Suggestions

+0.28% via ...ge/driver/gcs/gcs.go#182...213
+0.24% via ...ge/driver/gcs/gcs.go#85...111
+0.21% via ...ge/driver/gcs/gcs.go#471...494
See 7 more...

Powered by Codecov. Updated on successful CI builds.

LGTM
cc @RichardScothern

Lovely.

@igayoso :heart_eyes:


Fix graphs and charts issues on Sepia and Dark modes

https://phabricator.wikimedia.org/T179127
This is not the nicest fix but it does fix the graph & chart issues described in the ticket (on iOS). Better alternatives to tackle this are more than welcome.

Noticed a few regressions on the theme demo articles. At first glance I think the main issue is the query selectors which aren't scoped to div.barbox which causes nots to break baseline theme-ing on td and span elements which aren't in charts. Sorry I don't have more time to review/comment at the moment - was just heading out. Can pair tomorrow if you want.

Some of the issues I noticed, per my comment above, on theme demo articles, as a result of the changes not being scoped to respective chart/graph templates. There may be some dupes as I just took screenshots as I scrolled through the demo articles (there are MCS and Mobileview versions of each article). Also note that some percentage of these issues may have the same or related causes:

@nambatee After I get the (native) headless transform performance tests in place I'd like to circle back and add tests for all of the theming issues in the screenshots above so you and @joewalsh can freely hack with immediate theme breakage feedback.


TerminatorInst’ does not name a type

I got an error when compiling the tool on a Ubuntu 18 machine:
layout.cpp:350:15: error: ‘TerminatorInst’ does not name a type
        const TerminatorInst *ti = blk->getTerminator();

It occurred while
[ 58%] Building CXX object CMakeFiles/fuzzgen.dir/src/layout.cpp.o
Can you help?

It might be due to the version of LLVM you use.
I use LLVM 7.0.0 and could compile the FuzzGen successfully.

Yes, please use LLVM 6 or 7 (with slight changes). Some knowledge of LLVM is required to build FuzzGen.
Reopen if recompilation with an older version of LLVM does not work.

I was using LLVM 8, FYI.
$clang --version
clang version 8.0.0 (trunk 351050)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /usr/local/bin

$ llvm-config --version
8.0.0svn


Expect action to change object attribute to something

Is your feature request related to a problem? Please describe.
It appears that the most common way to check if an attribute has changed is to check whether that attribute value equals what you expected.
This is quite unclear to me because sometimes you are not sure what the initial value of that attribute was, and you do not want to start checking factories just to confirm that.
Describe the solution you'd like
It would be nice if we had a matcher that checks if an attribute name changed to something, or not otherwise.
For example expect { update_user }.to change(user.reload, :name).to 'Kaka Ruto' and expect { update_user }.not_to change(user.reload, :name).to 'Kaka Ruto'
Describe alternatives you've considered
I have had to check if the value of that attribute equals what I expect. For example
expect(user.reload.name).to eq 'Kaka Ruto'
Additional context
I tried using the existing change matchers but got an unexpected behaviour.
For this test, expect { update_user }.to change(user.reload, :name).to 'Kaka Ruto', I got a failing spec with the description expected 'User#name' to have changed to "Kaka Ruto", but did not change. However, it's negated variant passes! This expect { update_user }.not_to change(user.reload, :name) actually passes

The problem with this code is that reload is sent before the change.
So basically this:
expect { update_user }.to change(user.reload, :name).to 'Kaka Ruto'

expands to:
object = user.reload
old_value = object.send(:name)
update_user
new_value = object.send(:name)
expect(new_value).not_to eq(old_value) # i.e. "change"
expect(new_value).to eq('Kaka Ruto')

There are two problems here. One is that reload is executed before the change. You probably expected it to reload after the change.
And another is that you have to do a reload, something in your code instead of using the model is finding it by id and re-instantiating it from scratch, so the one instantiated in test goes out of sync with the one in the tested code forcing you to reload.
I suggest you to use:
expect { update_user }.to change { user.reload.name }.to 'Kaka Ruto'

This has a downside that reload is executed twice, before the change and after.
I've seen something like change_reloaded(model, attribute_name) matcher that saves the value for comparison before the change, then reloads and compares after the change.
However, the issue that update_user is loading the model from the database still stands.
Please feel free to reopen in case you feel that rspec-rails is incomplete or has some flaw.

Thank you @pirj ! That does help indeed.

You're always welcome!

To avoid the double reload you can also do:
expect { update_user; user.reload }.to change { user.name }.to 'Kaka Ruto'

@JonRowe nifty!


[BUG] HTTPConnection/HTTPSConnection is not iterable

Checklist

[x] I checked the FAQ section of the documentation
[x] I looked for similar issues in the issue tracker
[x] I am using the latest version of Schemathesis

Describe the bug
When trying to run schemathesis on a bigger OAS3, I always run into the following error:
TypeError: argument of type 'HTTPConnection' is not iterable.
This also happens for HTTPSConnection. The error mostly occurs when the tool is in the 90% - 99% of endpoint coverage, but I also saw it happen (once) earlier (at ~ 6%). The endpoint where the execution error happens is always different.
To Reproduce
🚨 Mandatory 🚨: Steps to reproduce the behavior:

Run this command schemathesis run openapi.json --checks all --base-url http://X.X.X.X:8080 --request-tls-verify=false -H "X-API-Token: [Filtered]" --show-trace
See additional context

Please include a minimal API schema causing this issue:
I was only able to replicate it on the whole OAS, which is attached to the issue.
Expected behavior
Schemathesis should complete the run and print the found bugs/conformance issues.
Environment
- OS: Ubuntu 24.04 LTS (WSL2 on Windows 11 host machine)
- Python version: 3.12.3
- Schemathesis version: 3.28.1
- Spec version: Open API 3.0.0

Additional context
stack trace for HTTP:
POST /rest/control/v1/service-container-control/start F                   [ 93%]
POST /rest/control/v1/service-container-control/stop Test Execution Error

An internal error occurred during the test run

    Traceback (most recent call last):
      File ".../schemathesis/venv/lib/python3.12/site-packages/schemathesis/cli/__init__.py", line 1110, in into_event_stream
        yield from runner.from_schema(
      File ".../schemathesis/venv/lib/python3.12/site-packages/schemathesis/runner/impl/core.py", line 194, in _generate_events
        yield from self._execute(results, stop_event)
      File ".../schemathesis/venv/lib/python3.12/site-packages/schemathesis/runner/impl/solo.py", line 24, in _execute
        for event in self._execute_impl(results):
      File ".../schemathesis/venv/lib/python3.12/site-packages/schemathesis/runner/impl/solo.py", line 32, in _execute_impl
        yield from self._run_tests(
      File ".../schemathesis/venv/lib/python3.12/site-packages/schemathesis/runner/impl/core.py", line 255, in _run_tests
        for event in run_test(
      File ".../schemathesis/venv/lib/python3.12/site-packages/schemathesis/runner/impl/core.py", line 560, in run_test
        yield events.AfterExecution.from_result(
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File ".../schemathesis/venv/lib/python3.12/site-packages/schemathesis/runner/events.py", line 198, in from_result
        result=SerializedTestResult.from_test_result(result),
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File ".../schemathesis/venv/lib/python3.12/site-packages/schemathesis/runner/serialization.py", line 436, in from_test_result
        errors=[SerializedError.from_exception(error) for error in result.errors],
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File ".../schemathesis/venv/lib/python3.12/site-packages/schemathesis/runner/serialization.py", line 250, in from_exception
        message, extras = extract_requests_exception_details(exception)
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File ".../schemathesis/venv/lib/python3.12/site-packages/schemathesis/exceptions.py", line 555, in extract_requests_exception_details
        if ":" not in inner.reason.args[0]:
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    TypeError: argument of type 'HTTPConnection' is not iterable

Stack trace for HTTPS:
GET /rest/control/v1/box/system-report F                                  [ 95%]
GET /rest/control/v1/box/system-report.tgz Test Execution Error

An internal error occurred during the test run

    Traceback (most recent call last):
      File ".../schemathesis/venv/lib/python3.12/site-packages/schemathesis/cli/__init__.py", line 1110, in into_event_stream
        yield from runner.from_schema(
      File ".../schemathesis/venv/lib/python3.12/site-packages/schemathesis/runner/impl/core.py", line 192, in _generate_events
        yield from self._execute(results, stop_event)
      File ".../schemathesis/venv/lib/python3.12/site-packages/schemathesis/runner/impl/solo.py", line 24, in _execute
        for event in self._execute_impl(results):
      File ".../schemathesis/venv/lib/python3.12/site-packages/schemathesis/runner/impl/solo.py", line 32, in _execute_impl
        yield from self._run_tests(
      File ".../schemathesis/venv/lib/python3.12/site-packages/schemathesis/runner/impl/core.py", line 253, in _run_tests
        for event in run_test(
      File ".../schemathesis/venv/lib/python3.12/site-packages/schemathesis/runner/impl/core.py", line 546, in run_test
        yield events.AfterExecution.from_result(
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File ".../schemathesis/venv/lib/python3.12/site-packages/schemathesis/runner/events.py", line 198, in from_result
        result=SerializedTestResult.from_test_result(result),
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File ".../schemathesis/venv/lib/python3.12/site-packages/schemathesis/runner/serialization.py", line 421, in from_test_result
        errors=[SerializedError.from_exception(error) for error in result.errors],
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File ".../schemathesis/venv/lib/python3.12/site-packages/schemathesis/runner/serialization.py", line 241, in from_exception
        message, extras = extract_requests_exception_details(exception)
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File ".../schemathesis/venv/lib/python3.12/site-packages/schemathesis/exceptions.py", line 547, in extract_requests_exception_details
        if ":" not in inner.reason.args[0]:
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    TypeError: argument of type 'HTTPSConnection' is not iterable

openapi.json

Hi! Thank you for the detailed report! The issue has been fixed in 3.29 and was reported in https://github.com/schemathesis/schemathesis/issues/2219

Hi, thanks for the fast answer and sorry for the oversight 😅.
Regarding the new release the error does indeed not occur anymore but I have a question about the output.
For endpoints where the error previously occurred (just a guess) the output now looks like this:
==================================== ERRORS ====================================
_____________ POST /rest/control/v1/service-container-control/stop _____________
Network Error

Connection failed

    <urllib3.connection.HTTPConnection object at 0x7fe30aeda450>
____________ POST /rest/control/v1/service-container-control/block _____________
Network Error

Connection failed

    <urllib3.connection.HTTPConnection object at 0x7fe30ad64590>
___________ POST /rest/control/v1/service-container-control/restart ____________
Network Error

Any plans to provide a more informative message if this occurs?
Can you tell if this happens because of a mistake with the implementation of the API or is this a caused by schemathesis?

This output is not really informative, indeed - I am keen to improve it! :)
The underlying reason is MaxRetryError meaning that Schemathesis made multiple attempts to send data / establish a connection and it failed. Likely it is caused by the app, but at the moment Schemathesis does not display some information that could help with debugging (i.e. the underlying exception could be Connect / Read timeout, so it could be helpful)
Let me dig a bit into this and I'll improve it in the next release

Yes, I noticed shortly after the comment that a service was stopped during testing, which basically caused all connections to be blocked - so it was an API error.


doubts on properly way to install

hi, i'm a windows user and to install nvui i simply extracted the archive and it recognized the various Nv.. commands but when i put the bin directory into the path it doesn't work anymore, the only solution was to put the plugin directory on the nvim configuration folder and that broke the portability of my configuration.
i'm a new neovim user and i find your frontend the best, so have i done something wrong, any suggestion?

Hey, thanks for the kind words. I think this should be solved in the latest commit of the master branch, since I've bundled most of the assets into the application and the Vim code is also hard-coded inside (folders are still there because I haven't updated the build script though). Try the build here, that should fix the problem.

thanks, the new build solved the problem


Job.isDone() returns true if the job does not exist

This follows from #851 and fixed the issue for BigQuery jobs.

You are missing closing , otherwise looks good.

Feel free to merge after fixing the Javadoc.

Coverage remained the same at 85.543% when pulling 33a81a0433d45e1ca2e203a1be9d93b27b28fc74 on mziccard:fix-job-isdone into 3e7069a1e4af6f7c7efbc7a71e5ccbb148387863 on GoogleCloudPlatform:master.


Add HRM for app, and comment for how to use when we use redux

Closes #1
HMR is quite different than the webpack hot reload. This will rebuild your module, and live inject it into your application... no browser reload necessary.
The same caveats as hot reload apply: New files won't be picked up, and there are some conditions where it may not work.
But in general... just try it, you'll love it!
I'll just drop this here if you want to see frickin magic

Gonna merge this at 7am tomorrow unless I heard feedback, it's needed for some further dev. FYI


Add basic model test rigging

This will allow us to automate basic validation of models
To leverage this, populate one or more jsonl files in the directory, then
go test --tags=integration ./integration  -run TestModels -v

You can test specific models, for example:
go test --tags=integration ./integration  -run TestModels/llama3:70b -v

Consistent with the other integration tests, you can target an existing ollama instance (local or remote) with
OLLAMA_TEST_EXISTING=1 OLLAMA_HOST=myserver:11434 go test --tags=integration ./integration  -run TestModels -v

Closing in favor of #5678 which now has coverage for model architectures.


Light position changed when exporting to glb in sandbox

I imported a glb file with a light in the sandbox, then exported it to a new glb file(no modification). When I imported the new file again, I found that the light position changed.
Screenshots
1.

2.

Desktop:

OS: windows 10 professional 1909
Browser [chrome]

I suppose the question located at here:
https://github.com/BabylonJS/Babylon.js/blob/15804eb5e9c5d5562fad3c5a8167ddc22ddd8431/serializers/src/glTF/2.0/Extensions/KHR_lights_punctual.ts#L148
When I commented out the lines related to the transformations , it seemed to work fine.

Please start a discussion on the forum first:) Unless you want to send a PR to fix it?


[FIX] [TYPO] porps -> props

What's changed

Fixed a typo on Paper.tsx component

Why

"props" is the right word

How

Updated porps to props

Good catch👍👍


Resampler fail to load checkpoint (tutorial_train_plus)

It seems that the pre-trained models ip-adapter-faceid-plus_sd15.bin and ip-adapter-faceid-plusv2_sd15.bin released by huggingface do not use the new structure Resampler (this is defined in IP-Adapter/tutorial_train_plus.py , Line308). Because (1) I tried to re-download and import this plusv2_sd15 model many times, both image_proj and ip_adapter failed to import, and some weight structures were not defined in the plusv2_sd15 pre-training model; (2) I checked the inference code (ipa_faceID_Plus_demo.py), ProjPlusModel( ip_adapter_faceid.py, Line279 ) is used in this code instead of the new structure Resampler. The ProjPlusModel used by the inference code is somewhat different from Resampler and the previous MLPProjModel (IP-Adapter/ip_adapter /ip_adapter_faceid.py, Line64).
I would like to ask, does the new structure Resampler have any special functions? Will your huggingface update the model pre-trained on this structure? Thank you so much for your great work! ! !
Or, maybe I use the wrong code? Can you please correct me? Why this model fails to be imported using the tutorial_train_plus script, and it cannot pass "if "latents" in state_dict["image_proj"] and "latents" in self.image_proj_model.state_dict():". Thank you very much! ! !

you should refer to https://github.com/tencent-ailab/IP-Adapter/blob/main/ip_adapter/ip_adapter_faceid.py


Implement less-than-full circle operating range for Dial

Currently, the operating range for the Dial is completely around the circle. Most dials only cover part of it (bottom-left to bottom-right).

Add operatingRange to Dial initialization:
Taking a Interval<Float> of values between 0.0 and 1.0. For most cases, something like (0.1,0.9) will best reflect hardware dials.

Closed by f52df0b4473454988f2e12edd85356c553d3f724.


Add some error handling directly in blocks.

For specific blocks, it would be nice to check the error directly when a connection is added for example, instead of doing it at compile time. (For example, check that the type of the 2 parameters in an operator are the same).


Added delete and search.

Hey I added a simple delete method so that you can delete by just passing in the id or ids.
But I haven't actually been able to test it yet, so if you can maybe look at it quick that would be great, I'll let you know if I get around to testing it.
Thanks.

I'll work on testing it. Looks great so far.

thanks!

Tested and the delete works great.

Ok I just threw search in here cuz i needed it on my end - tested that as well and seems great.
Also added some more documentation and updated the ISalesforceClient interface accordingly.
This PR should be ready to go.

Also updated the readme - we'll have to update some of the wikis once this is pulled in to to reflect the changes. Might not hurt to go to version 0.3 considering the amount of recent feature adds? :)

Sorry, I have been out of town. I'll take a look.

Thanks, I'm sure you will like it.

Hey, do you think we would be able to move this through soon? I'm happy to make adjustments if you have thoughts about it. Would just be nice to have it up in nuget :)
Thanks again!

Quick question on this one. I noticed that the delete template now only has a reference to the ids? This might break functionality with the other delete methods (allowing you to delete by passing the object). What are your thoughts on this?

You can still delete both ways because I left the original delete methods on the client. The delete template used to pull the ids off the objects for deleting, and now instead, the ids are pulled off the objects when the template is created (as opposed to when it is read). So previous functionality should still be working the same.

Any other thoughts?

This looks good, I'll get this in today.

pushed to nuget

awesome! thanks man


Font Awesome icons referenced in docs

Feature Request
Problem description
There are icons being used in the docs samples that depend on Font Awesome. This results in the icons not being rendered when the code snippets are copy pasted locally / on codesandbox.io.
Proposed solution
Use another icon names that do not depend on Font Awesome. For example: the value of name prop - at should be replaced by close.
Alternatively, the docs should mention that Font Awesome is required to get the examples working.
MVP
https://codesandbox.io/s/stardust-ui-example-yc7jj

Resolved by #1764


datasource.lib is missing

"datasource.lib" is missing (tried both git repo and npm package)
It's referenced in freeboard.js here:
fs.readFile(__dirname+"/datasource.lib", function (err, data) {
	if (err) throw err;
	dslib=data.toString();
});

Here's the relevant Node-RED log:
21 Feb 16:02:47 - [red] Uncaught Exception:
21 Feb 16:02:47 - Error: ENOENT, open '/opt/node-red/node_modules/node-red-contr
ib-freeboard/datasource.lib'

Thanks for your comment, I renamed the file, hopefully that solves the issue?

Super. tested the npm package and now everything is ok.


Create tool-proxy-cli configurations to allow flutter-release-eng to re-trigger dart internal build

Addressed with https://critique.corp.google.com/cl/493005713


dev-cmd/bump-cask-pr: use FromContentLoader when relevant.

When loading from tmp_contents in bump-cask-pr we're always loading from the contents and not from a e.g. filename etc. As a result, skip the detection of the correct loader (as the regex can be a bit flaky) and instead use FromContentLoader directly.

@Bo98 This:
https://github.com/Homebrew/brew/blob/138b7b2e4b03066c6b4bf25f8a8b4b39e95653f0/Library/Homebrew/cask/cask_loader.rb#L58-L66
Thanks for review!


Chainlit is failing to render UI when executed through Bazel since 0.6.1

I have a Bazel-based workspace setup for a Chainlit app development. I have a py_binary target for a Chainlit app and it was working fine until 0.6.0. However, with 0.6.1 and later versions, the server starts fine but the UI is failing to render because the requests to js/css files fail. Here are the logs:
INFO:     Started server process [52356]
INFO:     Waiting for application startup.
2023-08-25 05:42:50 - Your app is available at http://localhost:8000
INFO:     Application startup complete.
INFO:     Uvicorn running on http://<IP_ADDRESS>:8000 (Press CTRL+C to quit)
INFO:     <IP_ADDRESS>:42646 - "GET / HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:42646 - "GET /index-1c4090d7.js HTTP/1.1" 404 Not Found
INFO:     <IP_ADDRESS>:42650 - "GET /index-a6e13df6.css HTTP/1.1" 404 Not Found

I suspect this commit because Bazel creates symbolic links to dependent packages when setting up an execution sandbox directory. Maybe passing follow_symlink=True to the StaticFiles constructor may solve this problem.

Can you try adding follow_symlink=True to your local installation and see if it fixes the issue?

Sure. I verified js/css files load successfully when follow_symlink option is added. Here's the snippet of my patch:
app.mount(
    "/assets",
    StaticFiles(
        packages=[("chainlit", os.path.join(build_dir, "assets"))], follow_symlink=True
    ),
    name="assets",
)

@MathiasSpanhove do you see any security issue with this?

I don't think it will be a security issue. It's a mount to the chainlit build directory so I don't think that users will be able to upload files to it and somehow using symlinks try to extract secrets. (See Zip Slip / Zip Symlink Upload for examples)
If you really want to be safe, you could make it opt-in using configuration.
Interesting info about it from the starlette team themselves:
https://github.com/encode/starlette/pull/1681#issuecomment-1152178256

The 0.6.401 release brings a follow_symlink parameter that should fix your issue!

Verified that the issue is fixed in 0.6.401. Thank you!


Cannot install with go on OpenBSD

Describe the bug
On OpenBSD 6.4, I get the following when running go get -u github.com/liamg/aminal:
# github.com/liamg/aminal/vendor/github.com/go-gl/glfw/v3.2/glfw
In file included from .go/src/github.com/liamg/aminal/vendor/github.com/go-gl/glfw/v3.2/glfw/c_glfw.go:4:
In file included from ./glfw/src/context.c:28:
./glfw/src/internal.h:175:3: error: "No supported window creation API selected"
 #error "No supported window creation API selected"
  ^
1 error generated.
# github.com/liamg/aminal/vendor/github.com/go-gl/gl/all-core/gl
.go/src/github.com/liamg/aminal/vendor/github.com/go-gl/gl/all-core/gl/procaddr.go:70:9: could not     determine kind of name for C.GlowGetProcAddress_glcoreall
.go/src/github.com/liamg/aminal/vendor/github.com/go-gl/gl/all-core/gl/procaddr.go:69:8: could not determine kind of name for C.free

To Reproduce
Steps to reproduce the behavior:

Run go get -u github.com/liamg/aminal on an OpenBSD box
See error

Expected behavior
go get installs aminal
Environment:

OS: OpenBSD 6.4
Go Version: go1.11 openbsd/amd64
Shell: pdksh

Please could you try installing xorg-dev and rebuilding?


Add documentation for Accounts

Docs for Accounts usage:

getAccounts() and getAccountByUsername() usage
Guidance on multiple accounts use cases

Note:
Part of the doc will be replaced with typedocs links when msal-common typedocs are available. cc @jo-arroyo

Coverage remained the same at 79.458% when pulling 8410e7a0d1269b258424d3a22d21b37595a6ab37 on account-docs into bc4597593d4077c475701d981b1bc02dee63f225 on dev.


Small changes: #[inline] and simplifying code.

@Adanos020
Do merge it I need to change little bit code.


Find (Cmd+F) and Replace (Cmd+Alt+F) non-standard behavior

While the current behavior is consistent, it's a bit confusing when moving back and forth from other apps that implement the find / replace in a more standard way. What I'd expect, judging from other editors I use all the time (Sublime, Xcode, Android Studio) is:

Cmd+F opens the find dialog, collapsed to only show the find field (and not the replace field), which makes it clearer what operation you're performing
Cmd+Alt+F opens the replace dialog, expanded showing both find and replace filed, and focuses input on the find field

@marianoprettysimple based on your description, if I understand correctly, your feature request is like (without mentioning what we already have)

when we run Find, only show Find Input Box
when we run Replace, always focus Input Box

is this correct?

@rebornix Yes, that's it.

This feature request will not be considered in the next 6-12 months roadmap and as such will be closed to keep the number of issues we have to maintain actionable. Thanks for understanding and happy coding!


Remove ->parse() and do it in the constructor / new object for every parsed email

When I do:
$mailParser = new MailMimeParser();
$message = $mailParser->parse($email1);
$message = $mailParser->parse($email2);
echo $message->getHeaderValue('subject');

... I would be afraid that if $email2 doesn't have a subject (or parsing fails or whatever), I'd get back $email1s subject ;-)
Am I seeing it right that ->parse() always needs to be called first, before any other function works? If yes, I suggest to remove parse() in favor of a mandatory constructor argument:
$message = new MailMimeParser($email);

With the reason: This is an email parser, so if you don't have an email, don't call it :-)

You're constructing an instance of a parser, and able to call a parse function on it returning a Message object.  You're definitely misreading that.
It allows you to use the parser as a dependency if you're using dependency injection.
The shorthand method if you're not, is Message::from.

This was just some gut feeling - maybe it's wrong. Since it obviously doesn't make sense to you, I'm closing it :-)


Support for Auto Scaling Group instances

Please up-vote if you want this feature. Do not submit a new feature request.

This feature request has been prioritized in our backlog for a future release.


A simple NativeScript-vue application for fetching random people with http module

A simple NativeScript-vue application for fetching random people with http module
https://play.nativescript.org/?template=play-vue&id=FBH2ES

Thanks for your submission! Unfortunately the app is a bit too simple for the marketplace. We like apps to either have a gorgeous design or provide some good technical code that people can copy and paste (ideally both). If you think of any ways to improve this, please let us know!


Job DSL: update UMB triggers for 7.26.x

Fixed the UMB trigger topic for 7.26.x.

@mbiarnes Please take a look, thanks!


📑 Feature Request: Add Multi-Language Support for Global Accessibility

IMPORTANT TO CHECK BEFORE ISSUE

[X] You check that same issue is not present in the repository
[X] You have read contribution guidelines and rules

Please describe your feature request related to a problem?
Implement multi-language support on GitTrace, allowing users from different regions to interact with the website in their preferred language. This feature will enhance accessibility and usability, making it easier for non-English-speaking users to find repositories by links or names.
Describe your solution to problem
Set up a language selection dropdown or toggle in the header/footer for easy switching.
Store language preferences using cookies or local storage.
Ensure that the translated content adapts dynamically based on the selected language.
Describe alternatives you have considered
No response
Additional context
@rahulsainlll please assign this to me under gssoc-ext and hacktoberfest
Add Relevant Screenshot (if available)
No response

can you label level too for gsoc-ext?


registers serialization to file

Grats for the excellent implementation of the library.
One question that came up, after studying the use of it, is how we can export some setup variable name / value to a file and reload it again sometime later.
Do you have any suggestions  about it or the implementation scope doesn't contain such issues?

That is something that we will look into in the future. Its not on our radar right now but nice to see interest in it. Current focus is identifying and implementing things which can freeze now and not get in the way of future expansion of the library.

Thanks a lot for the response.


The meaning of the SAMPLE_GROUPS field

In OpenPCDet dataset.yaml, What is the use of SAMPLE_GROUPS in DATA_AUGMENTOR, and what are the values in it based on? Do I need to make SAMPLE_GROUPS larger for a smaller number of objects if I'm training my data set

I have the same confusion, any suggestion?

@learnuser1 and @SimonSongg, I have the same confusion. Were you able to figure out what exactly they mean?
Thanks.

@learnuser1 and @SimonSongg, I have the same confusion. Were you able to figure out what exactly they mean?
Thanks.

Yes, in the data preparation process, all the target point cloud in the dataset are extracted and saved in "gt database". And in data augmentation step, these targets will be randomly copy paste into the scene. And these numbers in sampling group control how many targets in total you want in the scene. For example, if there's only one car in the scene, and you set the number for class CAR to be 5, then 4 more targets from other frames (in gt database) will be pasted into current scene. There are some security check to make sure the "pasted target" does not overlap with the exsiting target in the scene.

Thanks @SimonSongg

而且，我也有同样的困惑。你能弄清楚它们到底是什么意思吗？
谢谢。

是的，在数据准备过程中，数据集中的所有目标点云都会被提取并保存在“gt数据库”中。而在数据增强步骤中，这些目标将被随机复制粘贴到场景中。采样组中的这些数字控制着场景中想要的目标总数。例如，如果场景中只有一辆汽车，并且您将 CAR 类的数字设置为 5，则来自其他帧（在 gt 数据库中）的另外 4 个目标将粘贴到当前场景中。有一些安全检查，以确保“粘贴的目标”不会与场景中的现有目标重叠。

Hello, thank you for your answer. I noticed that there is also a parameter DISABLE_AUG_LIST: ['placeholder'] in DATA_AUGMENTOR, which seems to disable some data enhancement methods. I wonder what this parameter stands for.
DATA_AUGMENTOR:
    DISABLE_AUG_LIST: ['placeholder']  # What does this parameter do?
    AUG_CONFIG_LIST:
        - NAME: gt_sampling
          USE_ROAD_PLANE: True
          DB_INFO_PATH:
              - kitti_dbinfos_train.pkl
          PREPARE: {
             filter_by_min_points: ['Car:5', 'Pedestrian:5', 'Cyclist:5'],
             filter_by_difficulty: [-1],
          }

          SAMPLE_GROUPS: ['Car:15','Pedestrian:15', 'Cyclist:15']
          NUM_POINT_FEATURES: 4
          DATABASE_WITH_FAKELIDAR: False
          REMOVE_EXTRA_WIDTH: [0.0, 0.0, 0.0]
          LIMIT_WHOLE_SCENE: False

        - NAME: random_world_flip
          ALONG_AXIS_LIST: ['x']

        - NAME: random_world_rotation
          WORLD_ROT_ANGLE: [-0.78539816, 0.78539816]

        - NAME: random_world_scaling
          WORLD_SCALE_RANGE: [0.95, 1.05]

        - NAME: random_local_pyramid_aug
          DROP_PROB: 0.25
          SPARSIFY_PROB: 0.05
          SPARSIFY_MAX_NUM: 50
          SWAP_PROB: 0.1
          SWAP_MAX_NUM: 50

@learnuser1 and @SimonSongg, I have the same confusion. Were you able to figure out what exactly they mean?
Thanks.

Yes, in the data preparation process, all the target point cloud in the dataset are extracted and saved in "gt database". And in data augmentation step, these targets will be randomly copy paste into the scene. And these numbers in sampling group control how many targets in total you want in the scene. For example, if there's only one car in the scene, and you set the number for class CAR to be 5, then 4 more targets from other frames (in gt database) will be pasted into current scene. There are some security check to make sure the "pasted target" does not overlap with the exsiting target in the scene.

Hello, thank you for your answer. I noticed that there is also a parameter DISABLE_AUG_LIST: ['placeholder'] in DATA_AUGMENTOR, which seems to disable some data enhancement methods. I wonder what this parameter stands for.
DATA_AUGMENTOR:
    DISABLE_AUG_LIST: ['placeholder']  # What does this parameter do?
    AUG_CONFIG_LIST:
        - NAME: gt_sampling
          USE_ROAD_PLANE: True
          DB_INFO_PATH:
              - kitti_dbinfos_train.pkl
          PREPARE: {
             filter_by_min_points: ['Car:5', 'Pedestrian:5', 'Cyclist:5'],
             filter_by_difficulty: [-1],
          }

          SAMPLE_GROUPS: ['Car:15','Pedestrian:15', 'Cyclist:15']
          NUM_POINT_FEATURES: 4
          DATABASE_WITH_FAKELIDAR: False
          REMOVE_EXTRA_WIDTH: [0.0, 0.0, 0.0]
          LIMIT_WHOLE_SCENE: False

        - NAME: random_world_flip
          ALONG_AXIS_LIST: ['x']

        - NAME: random_world_rotation
          WORLD_ROT_ANGLE: [-0.78539816, 0.78539816]

        - NAME: random_world_scaling
          WORLD_SCALE_RANGE: [0.95, 1.05]

        - NAME: random_local_pyramid_aug
          DROP_PROB: 0.25
          SPARSIFY_PROB: 0.05
          SPARSIFY_MAX_NUM: 50
          SWAP_PROB: 0.1
          SWAP_MAX_NUM: 50

@learnuser1 and @SimonSongg, I have the same confusion. Were you able to figure out what exactly they mean?
Thanks.

Yes, in the data preparation process, all the target point cloud in the dataset are extracted and saved in "gt database". And in data augmentation step, these targets will be randomly copy paste into the scene. And these numbers in sampling group control how many targets in total you want in the scene. For example, if there's only one car in the scene, and you set the number for class CAR to be 5, then 4 more targets from other frames (in gt database) will be pasted into current scene. There are some security check to make sure the "pasted target" does not overlap with the exsiting target in the scene.

SECOND paper:
3.2.2. Data Augmentation
Sample Ground Truths from the Database
The major problem we encountered during training was the existence of too few ground truths,
which significantly limited the convergence speed and final performance of the network. To solve this
problem, we introduced a data augmentation approach. First, we generated a database containing
the labels of all ground truths and their associated point cloud data (points inside the 3D bounding
boxes of the ground truths) from the training dataset. Then, during training, we randomly selected
several ground truths from this database and introduced them into the current training point cloud
via concatenation. Using this approach, we could greatly increase the number of ground truths per
point cloud and simulate objects existing in different environments. To avoid physically impossible
outcomes, we performed a collision test after sampling the ground truths and removed any sampled
objects that collided with other objects.

@learnuser1 and @SimonSongg, I have the same confusion. Were you able to figure out what exactly they mean?
Thanks.

Yes, in the data preparation process, all the target point cloud in the dataset are extracted and saved in "gt database". And in data augmentation step, these targets will be randomly copy paste into the scene. And these numbers in sampling group control how many targets in total you want in the scene. For example, if there's only one car in the scene, and you set the number for class CAR to be 5, then 4 more targets from other frames (in gt database) will be pasted into current scene. There are some security check to make sure the "pasted target" does not overlap with the exsiting target in the scene.

Hello, thank you for your answer. I noticed that there is also a parameter DISABLE_AUG_LIST: ['placeholder'] in DATA_AUGMENTOR, which seems to disable some data enhancement methods. I wonder what this parameter stands for.
DATA_AUGMENTOR:
    DISABLE_AUG_LIST: ['placeholder']  # What does this parameter do?
    AUG_CONFIG_LIST:
        - NAME: gt_sampling
          USE_ROAD_PLANE: True
          DB_INFO_PATH:
              - kitti_dbinfos_train.pkl
          PREPARE: {
             filter_by_min_points: ['Car:5', 'Pedestrian:5', 'Cyclist:5'],
             filter_by_difficulty: [-1],
          }

          SAMPLE_GROUPS: ['Car:15','Pedestrian:15', 'Cyclist:15']
          NUM_POINT_FEATURES: 4
          DATABASE_WITH_FAKELIDAR: False
          REMOVE_EXTRA_WIDTH: [0.0, 0.0, 0.0]
          LIMIT_WHOLE_SCENE: False

        - NAME: random_world_flip
          ALONG_AXIS_LIST: ['x']

        - NAME: random_world_rotation
          WORLD_ROT_ANGLE: [-0.78539816, 0.78539816]

        - NAME: random_world_scaling
          WORLD_SCALE_RANGE: [0.95, 1.05]

        - NAME: random_local_pyramid_aug
          DROP_PROB: 0.25
          SPARSIFY_PROB: 0.05
          SPARSIFY_MAX_NUM: 50
          SWAP_PROB: 0.1
          SWAP_MAX_NUM: 50

A list of augmentation methods that are to be deactivated. In this case no data augmentation technique is disabled, it's just a placeholder

@learnuser1 and @SimonSongg, I have the same confusion. Were you able to figure out what exactly they mean?
Thanks.

Yes, in the data preparation process, all the target point cloud in the dataset are extracted and saved in "gt database". And in data augmentation step, these targets will be randomly copy paste into the scene. And these numbers in sampling group control how many targets in total you want in the scene. For example, if there's only one car in the scene, and you set the number for class CAR to be 5, then 4 more targets from other frames (in gt database) will be pasted into current scene. There are some security check to make sure the "pasted target" does not overlap with the exsiting target in the scene.

@SimonSongg can you show me where this happens in the code: "these targets will be randomly copy paste into the scene."

@learnuser1 and @SimonSongg, I have the same confusion. Were you able to figure out what exactly they mean?
Thanks.

Yes, in the data preparation process, all the target point cloud in the dataset are extracted and saved in "gt database". And in data augmentation step, these targets will be randomly copy paste into the scene. And these numbers in sampling group control how many targets in total you want in the scene. For example, if there's only one car in the scene, and you set the number for class CAR to be 5, then 4 more targets from other frames (in gt database) will be pasted into current scene. There are some security check to make sure the "pasted target" does not overlap with the exsiting target in the scene.

@SimonSongg can you show me where this happens in the code: "these targets will be randomly copy paste into the scene."

In OpenPCDet/pcdet/datasets/augmentor/database_sampler.py, add_sampled_boxes_to_scene function does this.

Thx I found it just 1day before.
But what does image functions like copy_paste_to_image_kitti(), collect_image_crops_kitti() are purposed for when not using image augmentation in kitti_dataset.yaml, just for purpose? I try to isolate the code necessary for gt_sampling.

@SimonSongg I agree with the first one. Are the objects e.g. in KITTI so far away that there is no overlap in rotation? For example only a high rotation like 45° could intersect with another object.

@SimonSongg I agree with the first one. Are the objects e.g. in KITTI so far away that there is no overlap in rotation? For example only a high rotation like 45° could intersect with another object.

I dont get you point.

@SimonSongg I agree with the first one. Are the objects e.g. in KITTI so far away that there is no overlap in rotation? For example only a high rotation like 45° could intersect with another object.

I dont get you point.

Updated my previous question above.

For example when I use the augmentation technique random_local_rotation for my KITTI Dataset,there is no check function like for gt_sampling. In gt_sampling __call__ with handle this, but when I'm using random_local_rotation how it's handled.

For example when I use the augmentation technique random_local_rotation for my KITTI Dataset,there is no check function like for gt_sampling. For gt_sampling __call__ with handle this (collision avoidance), but when I'm using random_local_rotation how it's handled.

But when all objects and boxes in the point cloud scene are locally rotated by e.g. 9°, then there is no collision, because all objects are rotated and not some overall objects.

brown = objects within points? and blue = original position?

Okay so it's depending on the rotation angle. A small value could working without collision.

Okay so it's depending on the rotation angle. A small value could working without collision.

As you like... If two objects are very close to each other, they will collide even if 1 degree rotation though.

Why the authors didn't consider that during the development? Did you used local_rotation when you was working with OpenPCDet?


[Feature][Agent] Support filter function

Description
When some data is not needed, there is no need to send to downstream. So, the Agent may need to support discarding some unwanted data.
Use case
No response
Are you willing to submit PR?

[ ] Yes, I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

This will be provided later through Tranformer, and there is no need to provide a separate filtering function


How can I use your tool?

Hi, I am really interested by your tool, the gopro website is surprisingly bad.
How could I get it running? Cheers

nervermind, i found your other tool.

ah, yes.  This is a library meant to build tools that interact with the service.


NVDA does not work

Bug report
When opening a dialog with Wolt Modal, NVDA gets the focus of the dialog but cannot read the widgets inside it
Steps to reproduce
Steps to reproduce the behavior:

Open a dialog
Start NVDA
Try moving to the next item Inside the dialog
NVDA reads "Button dialog"

Expected behavior
Accessibility will operate on the widgets and read the semantics

@iyar-avital Yes, we are aware of this and working on a solution. Our next update is focusing on fixing this (using pages as widget)

Any update? @ulusoyca


Adding support for ClickHouse specific lagInFrame function in tests

Issue this PR Addresses/Closes
Closes #324
Summary of Changes
New utility macro lag was added to support ClickHouse specific lagInFrame function and to ensure support for all other sql dialects while keeping the test code clean and readable. This macro is used in the 3 tests which use lag function to ensure ClickHouse compatibility
Why Do We Need These Changes
It's needed to add support for ClickHouse in the current 3 tests which use the lag function and any future tests which will use lag function.
Reviewers
@clausherther

Hi, we don't support ClickHouse since we do not have CI in place to test this.


Avatar is not saving into database

Here, I'm using latest version of carrierwave-base64 with Rails 5.0.2. Image is uploading into /public/uploads/tmp but saving nil avatar in database. Please have a look on this issue and do the needfull.
Thanks!

@akshay-cs-borade if you want me to investigate this issue, I would need more information from you regarding the issue. Can you at least post the code in your controller action that is responsible for saving the record, and the model code?


feat: Add json-output params to watch command

Add JSON output parameters to watch command
Changes

Added --json-output flag to watch command for programmatic data processing
Added --json-output-file flag to specify custom output file path
Default JSON output path is set to /tmp/kyanos_watch.json

Features

Export request-response data in structured JSON format
Each JSON record includes:

Detailed timing information (start/end time, various duration metrics)
Connection details (protocol, addresses, ports)
Content information (request/response sizes and content)
Event details (syscall and NIC events)

Support both default and custom output paths

Documentation

Added JSON output format documentation in both English and Chinese
Updated watch command documentation to include JSON output usage

Thanks for your contributions! There are some code conflicts that need to be resolved.


Switch from Personal Access Token to a Deploy Key

From the README:
# This should be a personal access token made by a member of organization on his/her
# behalf who can read the Keyhouse repository. Go to this
# https://github.com/settings/tokens/new?description=Keyhouse%20Token&scopes=repo
# to make a new token with correct scopes.
token = 'secret_token'

Using a PAT is riskier, since it gives complete user-rights on all repos for the user who creates the token. Putting such a token across multiple servers is not a great idea.
Instead, support a Identity File in the config, and use git clone over SSH with a GitHub Deploy Key instead.

cc @kanav99


[Task]: Make all the property control keyboard accessible

Property Controls to be made keyboard accessible

[x] Action Selector #9920
[ ] Code Editor #10608
[ ] Input Text #10608
[ ] Box Shadow #10613
[ ] Border Radius #10614
[ ] Draggable List / Button List (panel) #10616
[ ] Button Tabs #10657
[ ] Icon Tabs #10656
[ ] Color Picker #10612
[ ] Date picker #10095
[ ] Icon Alignment #10062
[ ] Icon Selector #10060
[x] Multi Select #10373
[ ] Option Input #10615
[ ] Step Control #10059
[x] Switch

Closing this since all the subtasks are separated out into its own Github issue and is being tracked under "Property Pane Improvements" EPIC.


Add intelligent defaults to BtpSubProtocol

Signed-off-by: sappenin<EMAIL_ADDRESS>

Codecov Report

Merging #153 into master will decrease coverage by 0.24%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master     #153      +/-   ##
============================================
- Coverage     70.71%   70.47%   -0.25%
  Complexity      267      267
============================================
  Files            67       67
  Lines          1144     1148       +4
  Branches        128      128
============================================
  Hits            809      809
- Misses          276      280       +4
  Partials         59       59

Impacted Files
Coverage Δ
Complexity Δ

.../main/java/org/interledger/btp/BtpSubProtocol.java
28.57% <0%> (-38.1%)
1 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b53a051...a692a7b. Read the comment docs.


Improve TranslatedField example

Avoid allocating two variables when only need one.

Looks good to me, thanks! Merged in 5a26e22c0f5f96b441ecfcdf23721f4b48b224bb.


Applicable Issues
eiffel-community/etos#128
Description of the Change
Fix a simple syntax error in the jsontas  provider in the etos environment provider
Alternate Designs
N/A
Benefits
Syntactically sound code is always better
Possible Drawbacks
None
Sign-off

Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Fredrik Fristedt<EMAIL_ADDRESS>

Pylint errors are fixed in other PRs on this repository and I don't see them as major problems.
@andjoe-axis  is on vacation so I'll approve this PR in his stead.


Better error in CLI when URL cannot be parsed on login

Old:
./rancher login --token bla:ba <IP_ADDRESS>
FATA[0000] Get /v3: unsupported protocol scheme ""

New:
# ./rancher login --token bla:ba <IP_ADDRESS>
FATA[0000] Failed to parse SERVERURL (<IP_ADDRESS>), make sure it is a valid HTTPS URL (e.g. https://rancher.yourdomain.com or https://<IP_ADDRESS>). Error: parse <IP_ADDRESS>: invalid URI for request

Available in v2.0.4-rc1

Validated using v2.0.4-rc1. Error message showed as expected.


Keys registering

When I initially got the mod it sometimes actually moved to the camera when I press the keys, but for some reason it stopped doing anything when I pressed the keys, I'm not sure what happened. But its happening a lot and if it can't even register like this the mod is useless to me. For example I is to zoom out but when you press I it doesn't zoom out

Please provide the resulting crash log from pressing F3 +C for 10 seconds while ingame. This issue may be related to #33


Verify the "Client List" page loads correctly.

margin and padding

show vip or not in client list

done


Servo trimming using dynamic reconfiguration

The trimming of the servos is a candidate for using dynamic reconfiguration. The dynamic reconfiguration callback could store the trim values and if a pan/tilt angle has been received it could output messages to move the servos by the angle last received plus/minus the trim value.

Package changes to use dynamic reconfiguration


Fix for #1172

Test for the presence of 'np.nan', 'np.inf', and bigmnumbers larger than 1e10, using a theano function which finds the minimum/maximun of the theano.sandbox.cuda.CudaNdarray and then transfers the reduced result onto CPU. This implementaion avoids massive data transfer between GPU and CPU when the CudaNdarray is very large, at the expense of compiling an extra theano function at the instantiation of NanGuardMode.
While using CPU, it does exactly the same to its initial version.

travis tests are failing. I did just a very quick check, not a real review.

I cannot reproduce this error on my machine:

AttributeError: 'module' object has no attribute 'CudaNdarray'
Nevertheless I tried to import it explicitly at the beginning of the nan_guard.py file. Hope that could fix this error.

Also Travis is capturing a key error, which stuck me at the previous ticket also #1428 . The weird thing is, nothing is changed for that train_y_roc_auc key, but it turns out to be an error.

KeyError: "'train_y_roc_auc'\n

Travis do not have a gpu. Yet on a computer without a gpu, maybe that will
allow you to reproduce it.
Le 10 avr. 2015 14:37, "Zhouhan LIN"<EMAIL_ADDRESS>a écrit :

I cannot reproduce this error on my machine:
AttributeError: 'module' object has no attribute 'CudaNdarray'
Nevertheless I tried to import it explicitly at the beginning of the
nan_guard.py file. Hope that could fix this error.
Also Travis is capturing a key error, which stuck me at the previous
ticket also #1428 https://github.com/lisa-lab/pylearn2/pull/1428 . The
weird thing is, nothing is changed for that train_y_roc_auc key, but it
turns out to be an error.
KeyError: "'train_y_roc_auc'\n
—
Reply to this email directly or view it on GitHub
https://github.com/lisa-lab/pylearn2/pull/1477#issuecomment-91647129.

This contains commits from unrelated PR, so we'll need to rebase in addition to fixing it such that it skips certain tests when a GPU is unavailable. There's a "skip_if_no_gpu" thing for that.

I see, will check that now. Also Mehdi has posted a way to deal with the train_y_roc_auc Key error, I will introduce that into this commit too.

Travis is complaining about the reduce() function. Isn't reduce() a built-in function in python? But why we can't use it?
I will try to do the "git rebase" thing after passing Travis.

I find out why. It's because python 3.4 removes that.

Reduce is builtin in Python 2. In Python 3 it is a generator, and it lives
in the functools module. You can use six.moves  (Theano bundles a copy of
six, I forget where, check the code) to import it on either.
On Apr 14, 2015 11:28 AM, "Zhouhan LIN"<EMAIL_ADDRESS>wrote:

Travis is complaining about the reduce() function. Isn't reduce() a
built-in function in python? But why we can't use it?
I will try to do the "git rebase" thing after passing Travis.
—
Reply to this email directly or view it on GitHub
https://github.com/lisa-lab/pylearn2/pull/1477#issuecomment-92909796.

Well... may be I have made this branch more complicated instead... How to remove the unwanted commits by git rebase? (It'd be better if I can talk with you.)

Don't forget you'll have to git push --force
On Tue, Apr 14, 2015 at 12:36 PM, Zhouhan LIN<EMAIL_ADDRESS>wrote:

Well... may be I have made this branch more complicated instead... How to
remove the unwanted commits by git rebase? (It'd be better if I can talk
with you.)
—
Reply to this email directly or view it on GitHub
https://github.com/lisa-lab/pylearn2/pull/1477#issuecomment-92964520.

Yes I did that. There is still an "EpochCounter bugfix" commit, which is unwanted...

In that case, what you should do is create a new branch something like this:
git fetch origin-lisa
git checkout -b nan2 origin-lisa/master

Then use git cherry-pick to get only the good commits:
git cherry-pick first_commit_hash_you_want..last_commit_hash_you_want

so probably fd49dd9..c8de035 in this case.
Finally overwrite your old nan branch:
git checkout -B nan

and git push --force again. You can the do git branch -D nan2 to delete the unneeded second branch.

git rebase -i (interactive) also lets you pick only the commits you want.

Both of the two ways don't work, git is complaining about one of the patch is conflicting to lisa-labo/pylearn2/master.

Hi
I created a new PR at #1486, now those unwanted commits are removed.


test: remove already committed ops from test

Removes sett upgrade/swap configuration ops from test as these have both been committed.

Merging in as this has no functional changes besides removing things from test.


qemu-user-static fails with conflicts over proc-sys-fs-binfmt_mount.automount

Hi, thanks for the repo (and especially qemu-user-static thing), it's been a real head-scratcher before I found this.
Anyways, when I try adding a seperate binfmt config (like the example featured in the AppImages part of the NixOS wiki) it fails to build because both the included nixOS module and this one add a systemd service (I think) which has the same hash therefore causing a conflict.

Relevant log:

nikp123@Wall /e/nixos> sudo nixos-rebuild switch --show-trace
building the system configuration...
trace: warning: optionsDocBook is deprecated since 23.11 and will be removed in 24.05
trace: warning: optionsDocBook is deprecated since 23.11 and will be removed in 24.05
trace: warning: optionsDocBook is deprecated since 23.11 and will be removed in 24.05
error: builder for '/nix/store/7nnf5ivg03qp28i2s5ha9jkgh7mn478k-system-units.drv' failed with exit code 1;
       last 1 log lines:
       > ln: failed to create symbolic link '/nix/store/iwl29zskyj3z6541nnb2ik9054iia6ya-system-units/proc-sys-fs-binfmt_misc.automount': File exists
       For full logs, run 'nix log /nix/store/7nnf5ivg03qp28i2s5ha9jkgh7mn478k-system-units.drv'.
error: 1 dependencies of derivation '/nix/store/59nvbpimn8gji7b7rpi168vd51xk4gab-etc.drv' failed to build
error: 1 dependencies of derivation '/nix/store/9i0iphwbl6bzg31lqkmmq53hbbpxdj2w-nixos-system-Wall-23.11.20231201.5de0b32.drv' failed to build

PS: This module is included as shown in the README.

I have updated the module to not add these duplicate services if NixOS's binfmt module is also in use. Can you try again?