build-osuosl-aix71-ppc64-* failing jdk_lang jdk_util tests

Both grinders on the build-osuosl machines still failed the following tests despite the symlinks being in place
jdk_lang_1
jdk_util_1

with the same error
LD_LIBRARY_PATH= : 	0509-022 Cannot load module /home/jenkins/workspace/Grinder/openjdkbinary/j2sdk-image/lib/libawt_xawt.so.
13:52:59  	0509-150   Dependent module /opt/freeware/lib/libXrender.a(shr_64.o) could not be loaded.
13:52:59  	0509-152   Member shr_64.o is not found in archive

Originally posted by @Haroon-Khel in https://github.com/AdoptOpenJDK/openjdk-infrastructure/issues/1697#issuecomment-804111475

Related link
https://www.ibm.com/support/pages/ibm-java-aix-how-resolve-unsatisfiedlinkerror-gui-based-application

@Haroon-Khel See https://github.com/AdoptOpenJDK/openjdk-infrastructure/issues/1772#issuecomment-750373467 for potential things to try to reproduce the problem. That issue contains a small standlone java test case that might allow you to replicate it outside all the test harnesses.

Perhaps we need ojdk06 in the grinder system - so that test results get captured for all - but only as a wildcard - so that different setups can be tested.

When these tests fail - are they failing from something they just built? Or are they failing against a java image they just installed - meaning, was built on a different AIX system?
If the failing java was not just built then the issue may have it's origin in the system config of the building system, not the config of the running system.

@Haroon-Khel your link above is for the unfortunate user that has to work with a JVM asis - and how to repair the AIX environment so that it can work.
IMHO: we are in a different situation: we are building the JVM and need to make sure that these issues do not occur rather than create a dependency on an AIX Toolbox (unsupported) package.
In the other issue: #1772 I guessed that this is being caused by a ./configure issue and a missing include file - and that libXrender-devel (plus it's requirements) gets installed to satisify a missing include file.
Looking further - it may be that this time - IBM does include the include file, but configure is not finding it:
p159a01:/ # find /usr /opt -name Xrender.h
/usr/lpp/X11/include/X11/extensions/Xrender.h
/opt/freeware/include/X11/extensions/Xrender.h

p159a01:/ # rpm -ql libXrender-devel | grep Xrender.h
/opt/freeware/include/X11/extensions/Xrender.h

p159a01:/ # lslpp -w /usr/lpp/X11/include/X11/extensions/Xrender.h
  File                                        Fileset               Type
  ----------------------------------------------------------------------------
  /usr/lpp/X11/include/X11/extensions/Xrender.h
                                                 X11.adt.ext        File

So, rather than focus on trying to fix libraries - let's take a step back and see why libXrender.RPM (or likely more accurately, libXrender-devel.RPM) is needed/what motivated the install in the first place!

@Haroon-Khel your link above is for the unfortunate user that has to work with a JVM asis - and how to repair the AIX environment so that it can work.
IMHO: we are in a different situation: we are building the JVM and need to make sure that these issues do not occur rather than create a dependency on an AIX Toolbox (unsupported) package.
In the other issue: #1772 I guessed that this is being caused by a ./configure issue and a missing include file - and that libXrender-devel (plus it's requirements) gets installed to satisify a missing include file.
Looking further - it may be that this time - IBM does include the include file, but configure is not finding it:
p159a01:/ # find /usr /opt -name Xrender.h
/usr/lpp/X11/include/X11/extensions/Xrender.h
/opt/freeware/include/X11/extensions/Xrender.h

p159a01:/ # rpm -ql libXrender-devel | grep Xrender.h
/opt/freeware/include/X11/extensions/Xrender.h

p159a01:/ # lslpp -w /usr/lpp/X11/include/X11/extensions/Xrender.h
  File                                        Fileset               Type
  ----------------------------------------------------------------------------
  /usr/lpp/X11/include/X11/extensions/Xrender.h
                                                 X11.adt.ext        File

So, rather than focus on trying to fix libraries - let's take a step back and see why libXrender.RPM (or likely more accurately, libXrender-devel.RPM) is needed/what motivated the install in the first place!

OpenJDK builds require it - it's mentioned in the builfd logs:
18:14:53  checking for X11/extensions/Xrender.h... yes

Yes, and I think an ansible entry or entries to create a symbolic link from /usr/include/X11/extensions/Xrender.h to /usr/lpp/X11/include/X11/extensions/Xrender.h is better
than (?) adding /opt/freeware/include to CFLAGS (just a guess for now).

@aixtools I think I'm missing something - the original issue described was about an inability to link to the library - how have you gone back to trying to fix an issue with the header files? Is that related to the initially described problem?

Yes - as to why the additional libraries were installed.
Quick test is to remove the RPM packages I mentioned.

If a subsequent retry fails due to missing Xrender.h - then create the symlink I suspect will fix that, and try again.
In other words, the problem is that the RPM library should not be there to begin with. If it isn't there it cannot cause a side effect that it is missing the contents (other AIX) libraries are expecting.

On build-osuosl-aix71-ppc64-1
bash-5.0# dump -Xany -H /home/jenkins/workspace/Grinder/openjdkbinary/j2sdk-image/lib/libawt_xawt.so

/home/jenkins/workspace/Grinder/openjdkbinary/j2sdk-image/lib/libawt_xawt.so:

                        ***Loader Section***
                      Loader Header Information
VERSION#         #SYMtableENT     #RELOCent        LENidSTR
0x00000001       0x000004dc       0x00000a80       0x000001b5

#IMPfilID        OFFidSTR         LENstrTBL        OFFstrTBL
0x0000000c       0x00011cd8       0x00008865       0x00011e8d

                        ***Import File Strings***
INDEX  PATH                          BASE                MEMBER
0      /opt/IBM/xlc/13.1.3/../../../../usr/lpp/xlC/lib:/opt/IBM/xlC/13.1.3/lib/aix61:/opt/IBM/xlC/13.1.3/lib:/opt/IBM/xlc/13.1.3/lib/aix61:/opt/IBM/xlc/13.1.3/lib:/usr/vac/lib/aix53:/opt/freeware/lib/pthread/ppc64:/opt/freeware/lib:/usr/lib
1                                    libawt.so
2                                    libXext.a           shr_64.o
3                                    libX11.a            shr_64.o
4                                    libXrender.a        shr_64.o
5                                    libdl.a             shr_64.o
6                                    libXtst.a           shr_64.o
7                                    libXi.a             shr_64.o
8                                    libjava.so
9                                    libjvm.so
10                                   libpthreads.a       shr_xpg5_64.o
11                                   libc.a              shr_64.o

In it's PATH, /opt/freeware/lib is in front of /usr/lib and its the /opt/freeware/lib/libXrender.a that its looking for, not /usr/lib/libXrender.a
Ive checked all the other directories in that PATH, and they do not have their own libXrender.a files

Reinstalled libXrender and its dependencies on build-osuosl-1. Running jdk_util tests on it
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/8040/console

That search path will be controlled by the same line that was last changed in https://github.com/AdoptOpenJDK/openjdk-build/pull/2489 on Feb 23rd but that change won't have affected this problem. It does explain where those entries have come from though -  it's from the LIBPATH that is set during the build.
Based on:

Yes - as to why the additional libraries were installed.

So they come from the libXrender RPM package, which I assume is pulled in as a dependency of libXrender-devel (We could try doing rpm -e libXrender and see if it blocks on libXrender-devel.
However as @aixtools says:

Yes, and I think an ansible entry or entries to create a symbolic link from /usr/include/X11/extensions/Xrender.h to /usr/lpp/X11/include/X11/extensions/Xrender.h is better

That would work, although I'd  rather avoid extra symlinks if we can avoid it so if that if the AIX-provided Xrender.h from X11.adt.ext is good enough to build with then we may be able to try building with  e.g. --with-extra-cflags=-I/usr/lpp/X11/include --with-extra-cxxflags=-I/usr/lpp/X11/include (Possibly doesn't need the cxx one though) - see https://github.com/AdoptOpenJDK/openjdk-build/blob/master/build-farm/platform-specific-configurations/aix.sh#L40 for an example of where such flags it can be set.

I just looked at the existing platform-specific-configurations for AIX and it might be even easier than expected:

currently there is:
export LIBPATH=/opt/freeware/lib/pthread/ppc64:/opt/freeware/lib:/usr/lib

rather than prepend - append - so:
export LIBPATH=/usr/lib:/opt/freeware/lib/pthread/ppc64:/opt/freeware/lib

as one of the libraries in /opt/freeware/bin is LibXrender

IMHO: The AIX library should always be used UNLESS it is shown to be broken - and IBM refuses to repair it. Just because /opt/freeware/lib is used by both BULL and IBM AIXToolbox - does not mean a customer can ever open a ticket on anything there. And should OpenJDK fail because of a library issue in /opt/freeware/lib - they will, correctly, just refer it back to OpenJDK and the choice to use a non-supported library (meaning 'we' OpenJDK must give the support AIXToolbox et al is not expected to give).

I want to add
a) it is one thing to add a library not provided by IBM Systems (aka AIX bos)
b) it is another matter to replace a library provided by IBM - because any issues caused by the replacement library are never going to be recognized by IBM

Moving to the customer perspective - there is an issue with /usr/lib/libXYZ.a - and a work around is to install an OSS produced version of libXYZ.a (e.g., a symbolic link in /usr/lib to /opt/OSS/lib/libXYZ.a

Now the customer can open a ticket - complaining about a defect in IBM provided /usr/lib/libXYZ.a because program DBCA works fine with the OSS library where the defect is fixed. IBM support - patch your version so that it works with DBCA, etc..

Are we going to test this?

Recent jdk11 openjdk sanity test passes on build-osuosl-1
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/8161/console
Running one of -2 aswell
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/8163/console

@aixtools It may be abit of a reach, but would this have anything to do with https://github.com/AdoptOpenJDK/openjdk-infrastructure/issues/1651#issuecomment-814661393 ?

The tests on -2 passed aswell

@aixtools It may be abit of a reach, but would this have anything to do with #1651 (comment) ?

No. not related.

@aixtools I think I'm missing something - the original issue described was about an inability to link to the library - how have you gone back to trying to fix an issue with the header files? Is that related to the initially described problem?

I am not clear on whether this is a fresh build that is testing itself, or a test job that downloads a 'pre-built' from a different location and then tests that. My expectation is that a fresh build would work, but a build coming from somewhere else may fail due to differences in library installation.

What I want to repeat is that the library libXrender.a exists on AIX - and is the system default. Further - it seems on ojdk03 and ojdk04 the RPM package with the library is not installed.

ojdk01
13814    1 lrwxrwxrwx  1 bin       bin             32 Jul  2  2020 /usr/lib/libXrender.a -> /usr/lpp/X11/lib/R7/libXrender.a
274449  165 -rw-r--r--  1 bin       bin         168948 Jul 14  2014 /usr/lpp/X11/lib/R7/libXrender.a
82091  928 -rwxr-xr-x  1 root      system      949342 May 29  2018 /opt/freeware/lib/libXrender.a
ojdk02
13813    1 lrwxrwxrwx  1 bin       bin             32 Jul  2  2020 /usr/lib/libXrender.a -> /usr/lpp/X11/lib/R7/libXrender.a
278545  165 -rw-r--r--  1 bin       bin         168948 Jul 14  2014 /usr/lpp/X11/lib/R7/libXrender.a
67416  928 -rwxr-xr-x  1 root      system      949342 May 29  2018 /opt/freeware/lib/libXrender.a
ojdk03
 2037    1 lrwxrwxrwx  1 bin       bin             32 Jul  5  2018 /usr/lib/libXrender.a -> /usr/lpp/X11/lib/R7/libXrender.a
47348  161 -rw-r--r--  1 bin       bin         164852 Jun  1  2015 /usr/lpp/X11/lib/R7/libXrender.a
ojdk04
 2037    1 lrwxrwxrwx  1 bin       bin             32 Jul  5  2018 /usr/lib/libXrender.a -> /usr/lpp/X11/lib/R7/libXrender.a
47348  161 -rw-r--r--  1 bin       bin         164852 Jun  1  2015 /usr/lpp/X11/lib/R7/libXrender.a
ojdk05
 1815    1 lrwxrwxrwx  1 bin       bin             32 Sep 14  2020 /usr/lib/libXrender.a -> /usr/lpp/X11/lib/R7/libXrender.a
111846  165 -rw-r--r--  1 bin       bin         168948 Apr 23  2018 /usr/lpp/X11/lib/R7/libXrender.a
 8293  928 -rwxr-xr-x  1 root      system      949342 May 29  2018 /opt/freeware/lib/libXrender.a
ojdk06
13105    1 lrwxrwxrwx  1 bin       bin             32 Mar 22 12:46 /usr/lib/libXrender.a -> /usr/lpp/X11/lib/R7/libXrender.a
108344  161 -rw-r--r--  1 bin       bin         164852 Jun  1  2015 /usr/lpp/X11/lib/R7/libXrender.a
  132  928 -rwxr-xr-x  1 root      system      949342 May 29  2018 /opt/freeware/lib/libXrender.a

As to the include file:
AIX ALSO includes the file by default - and surprisingly - the RPM with the include file is installed on ALL
ojdk01
270584   14 -rw-r--r--  1 bin       bin          14160 Sep 21  2009 /usr/lpp/X11/include/X11/extensions/Xrender.h
79078   13 -rw-r--r--  1 root      system       12805 May 29  2018 /opt/freeware/include/X11/extensions/Xrender.h
ojdk02
275881   14 -rw-r--r--  1 bin       bin          14160 Sep 21  2009 /usr/lpp/X11/include/X11/extensions/Xrender.h
66565   13 -rw-r--r--  1 root      system       12805 May 29  2018 /opt/freeware/include/X11/extensions/Xrender.h
ojdk03
90794   14 -rw-r--r--  1 bin       bin          14160 Sep 21  2009 /usr/lpp/X11/include/X11/extensions/Xrender.h
48784   13 -rw-r--r--  1 root      system       12805 May 29  2018 /opt/freeware/include/X11/extensions/Xrender.h
ojdk04
93961   14 -rw-r--r--  1 bin       bin          14160 Sep 21  2009 /usr/lpp/X11/include/X11/extensions/Xrender.h
41288   13 -rw-r--r--  1 root      system       12805 May 29  2018 /opt/freeware/include/X11/extensions/Xrender.h
ojdk05
348885   14 -rw-r--r--  1 bin       bin          14160 Sep 21  2009 /usr/lpp/X11/include/X11/extensions/Xrender.h
73755   13 -rw-r--r--  1 root      system       12805 May 29  2018 /opt/freeware/include/X11/extensions/Xrender.h
ojdk06
119373   14 -rw-r--r--  1 bin       bin          14160 Sep 21  2009 /usr/lpp/X11/include/X11/extensions/Xrender.h
106586   13 -rw-r--r--  1 root      system       12805 May 29  2018 /opt/freeware/include/X11/extensions/Xrender.h

IMHO: the RPM should be removed - and quickfix is a sym-link from /usr/include to /usr/lpp/X11/include/X11/extensions/Xrender.h - and a longer term solution is the change to an argument - as @sxa mentioned.

Update: Looking at TRSS: For AIX:

The 'unstable' for AIX is:

These 4 tests all fail due to:
Standard Error

java.lang.RuntimeException: Unexpected exception: java.lang.UnsatisfiedLinkError: /home/jenkins/workspace/Test_openjdk16_hs_sanity.openjdk_ppc64_aix/openjdkbinary/j2sdk-image/lib/libawt_xawt.so: /home/jenkins/workspace/Test_openjdk16_hs_sanity.openjdk_ppc64_aix/openjdkbinary/j2sdk-image/lib/libawt_xawt.so, LIBPATH=/home/jenkins/workspace/Test_openjdk16_hs_sanity.openjdk_ppc64_aix/openjdkbinary/j2sdk-image/lib/server:/home/jenkins/workspace/Test_openjdk16_hs_sanity.openjdk_ppc64_aix/openjdkbinary/j2sdk-image/lib:/home/jenkins/workspace/Test_openjdk16_hs_sanity.openjdk_ppc64_aix/openjdkbinary/j2sdk-image/../lib, LD_LIBRARY_PATH= : Could not load module /home/jenkins/workspace/Test_openjdk16_hs_sanity.openjdk_ppc64_aix/openjdkbinary/j2sdk-image/lib/libawt_xawt.so.
	Dependent module /opt/freeware/lib/libXrender.a(shr_64.o) could not be loaded.
	Member shr_64.o is not found in archive

Goiing to rename the GNU 'libXrender.a' on build-osuosl-aix71-ppc64-2 (as it is not in the ci.role.test group - and see if it passes:

Rerunning jdk 11 hotspot openjdk sanity tests on -1 and -2

The run on -1 has passed although the one on -2 seems to be taking a lot of time ... But still progressing.

I just ran https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/124/ - with the OSS libXrender.a 'disabled', and https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/125/ with the library enabled.
test # 124 passed
test # 125 - fails as expected
further details (of 125)

JavaTest Message: Test threw exception: java.lang.RuntimeException: Unexpected exception: java.lang.UnsatisfiedLinkError: /home/jenkins/workspace/Grinder/openjdkbinary/j2sdk-image/jre/lib/ppc64/libawt_xawt.so: /home/jenkins/workspace/Grinder/openjdkbinary/j2sdk-image/jre/lib/ppc64/libawt_xawt.so, LIBPATH=/home/jenkins/workspace/Grinder/openjdkbinary/j2sdk-image/jre/lib/ppc64/server:/home/jenkins/workspace/Grinder/openjdkbinary/j2sdk-image/jre/lib/ppc64:/home/jenkins/workspace/Grinder/openjdkbinary/j2sdk-image/jre/lib/ppc64/jli:/home/jenkins/workspace/Grinder/openjdkbinary/j2sdk-image/jre/../lib/ppc64, LD_LIBRARY_PATH= :     0509-022 Cannot load module /home/jenkins/workspace/Grinder/openjdkbinary/j2sdk-image/jre/lib/ppc64/libawt_xawt.so.
        0509-150   Dependent module /opt/freeware/lib/libXrender.a(shr_64.o) could not be loaded.
        0509-152   Member shr_64.o is not found in archive
        0509-022 Cannot load module /home/jenkins/workspace/Grinder/openjdkbinary/j2sdk-image/jre/lib/ppc64/libawt_xawt.so.
        0509-150   Dependent module /home/jenkins/workspace/Grinder/openjdkbinary/j2sdk-image/jre/lib/ppc64/libawt_xawt.so could not be loaded.
JavaTest Message: shutting down test

root@ojdk01:[/opt/freeware/lib]ls -ld *X*
-rwxr-xr-x 1 root system 1565634 May 29  2018 libXft.a
-rwxr-xr-x 1 root system  568202 May 29  2018 libXft.so.2
-rwxr-xr-x 2 root system  949342 May 29  2018 libXrender.a
-rwxr-xr-x 2 root system  949342 May 29  2018 libXrender.a.issue2069
-rwxr-xr-x 1 root system     911 May 29  2018 libXrender.la
root@ojdk01:[/opt/freeware/lib]ar tv libXrender.a
rwxr-xr-x     0/0     383091 May 29 11:13 2018 libXrender.so.1
rw-r--r--     0/0      72911 May 29 11:13 2018 libXrender.so.0
root@ojdk01:[/opt/freeware/lib]ar tv /usr/lib/libXrender.a
rwxr-x---   300/300    70806 Jul 14 16:36 2014 shr.o
rw-r-----   300/300     5495 Oct 27 04:58 2007 libXrender.so.0

Over the weekend this test failed on https://ci.adoptopenjdk.net/job/Test_openjdk8_hs_sanity.openjdk_ppc64_aix/348/ - will 'disable' the OSS library and rerun from test # 348 - setting label to test-ibm-aix71-ppc64-2

As https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/126/console - passes on test-ibm-aix71-ppc64-2 I propose:

to remove the OSS package Xrender - asap.
modify playbooks to not install Xrender

@sxa comments please.

Is be somewhat resultant to make any changes one day before a release cycle

Well, been testing for weeks - and I knew the answer weeks ago.

I can put everything back in the breaking mode, or update all in the passing mode.

Change via PR comes later, obviously.

Change via PR comes later, obviously.

Put the PR in now if you can please - we just won't integrate it until next week, but it gives a few days for reviews :-)

As these are RPM's - a bit of research shows the likely list of RPM's to no longer be installing is more than 'just' Xrender - due to the so-called dependencies:
root@p9-aix1-ojdk06:[/root]rpm -qa | grep Xrender
libXrender-devel-0.9.8-2waixX11.ppc
libXrender-0.9.8-2waixX11.ppc
root@p9-aix1-ojdk06:[/root]rpm --test -e libXrender
error: Failed dependencies:
        libXrender = 0.9.8-2waixX11 is needed by (installed) libXrender-devel-0.9.8-2waixX11.ppc
        libXrender >= 0.9.5 is needed by (installed) libXft-2.3.2-4waixX11.ppc
        libXrender.a(libXrender.so.1) is needed by (installed) libXft-2.3.2-4waixX11.ppc
root@p9-aix1-ojdk06:[/root]rpm --test -e libXft
error: Failed dependencies:
        libXft.a(libXft.so.2) is needed by (installed) tk-8.6.8-3.ppc
root@p9-aix1-ojdk06:[/root]rpm --test -e tk
root@p9-aix1-ojdk06:[/root]
root@p9-aix1-ojdk06:[/root]rpm --test -e tcl
error: Failed dependencies:
        libtcl8.6.so is needed by (installed) expect-5.45.4-1.ppc
        libtcl8.6.so is needed by (installed) tk-8.6.8-3.ppc
        tcl >= 8.6.8-3 is needed by (installed) expect-5.45.4-1.ppc
        tcl = 8.6.8-3 is needed by (installed) tk-8.6.8-3.ppc
root@p9-aix1-ojdk06:[/root]rpm --test -e expect

expect

tcl

tk

libXft

libXrender-devel

libXrender

I hope that is resolvable via yum: and state: absent

Fortunately - none of these are needed by python - they say. I am not completely sure about the accuracy however.

I know git does not need python to run (only to build)

python might need tk/tcl/expect to run the related (python optional) modules

@Haroon-Khel this failed again on  test-osuosl-aix71-ppc64-2
https://ci.adoptopenjdk.net/job/Test_openjdk8_hs_sanity.openjdk_ppc64_aix/381/console

This test fails on all of our aix machines
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/1006/console
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/1006/console
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/1006/console
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/1006/console
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/1006/console

FYI @sej-jackson

Let's go back to the beginning:
LD_LIBRARY_PATH= : 	0509-022 Cannot load module /home/jenkins/workspace/Grinder/openjdkbinary/j2sdk-image/lib/libawt_xawt.so.
13:52:59  	0509-150   Dependent module /opt/freeware/lib/libXrender.a(shr_64.o) could not be loaded.
13:52:59  	0509-152   Member shr_64.o is not found in archive

The loader does not find shr_64.o - because this is was found in /usr/lib/libXrender.a during compile:
root@p9-aix1-ojdk06.osuosl.org:[/root]ar -X64 tv /usr/lib/libXrender.a
rwxr-x---   300/300    76635 Apr 23 15:23 2018 shr_64.o
rw-r-----   300/300     5737 Oct 27 04:58 2007 libXrender.so.0

p.s. - I see yet another surprise - considering the file modes of the archive members. Surprised they were found during the build!

No regular user has either UID or GID == 300.
@sej-jackson - if you could file a PMR with IBM to mention that these shared libraries are not readable by other - would be excellent!

Back to issue: despite my surprise - shr_64.o is being located during the build process, but does not exist in the RPM based packaging:

root@p9-aix1-ojdk05:[/root]ar -X64 tv /opt/freeware/lib/libXrender.a-SXAMOVED1172
rwxr-xr-x     0/0     407535 May 29 11:13 2018 libXrender.so.1
rw-r--r--     0/0      77577 May 29 11:13 2018 libXrender.so.0

With permission - I would like to remove the RPM packages on ojdk05 (aka test-osuosl-aix72-1):

expect
libXft
libXrender-devel
LibXrender

Maybe another dependency shows up - I'll add that to this issue, and make the PR changes once the system configuration 'passes' what people need to build stuff.
Note: might find some C code that needs a change to the name given for Xrender.h, e.g., change #include <Xrender.h> to #include <X11/extensions/Xrender.h>

I'd like to take these machines offline if this is not yet resolved, since when we land on them, it results in ~100 test failures and creates unwanted noise / triage.

@Haroon-Khel In light of Shelley's comments can we try and get this to a conclusion please? My suggestion would be to use ojdk06 for any testing that is required to verify the proposals which Michael has suggested.

ojdk06 is an aix72 system. Shall I reinstall with aix71 and my suggestions?

reinstall? Or work on 'asis'?

Back to March:
So, rather than focus on trying to fix libraries - let's take a step back and see why libXrender.RPM (or likely more accurately, libXrender-devel.RPM) is needed/what motivated the install in the first place!

OpenJDK builds require it - it's mentioned in the builfd logs:
18:14:53  checking for X11/extensions/Xrender.h... yes
The check is not finding the IBM provided Xrender.h, so RPM Xrender gets installed, but the build seems to be linking against the IBM Xrender library.
As @sxa commented, iirc, earlier - this should likely be fixed in the configure script (i,e., check for <X11/extensions/Xrender.h>
rather than #include <Xrender.h>, installing the RPM, and adding CFLAGS=-I/opt/include/X11/entensions.
@smlambert -- while it can be fixed via infrastrure, has anyone actually looked at a PR for ./configure?
a) seeing the test is failing on all systems, I'll just make some changes on ojdk06.
b) if someone will assist - I'll 'also assist' with testing a change in the configure tests.

To test ---
rpm -e libXrender libXft libXrender-devel tk renderproto

# to get the system to point at the IBM installed X11 extenstions
rmdir /opt/freeware/include/X11/extensions
ln -s /usr/include/X11/extensions /opt/freeware/include/X11/extensions

Running Grinder: https://ci.adoptopenjdk.net/job/Grinder/1228/
just noticed this system had been reinstalled with AIX 7.1 some time back. So, the reinstall had already been done.

I must not be understanding 'something', i.e., have probably fogoteen how to specify a proper grinder job:
00:14:29.382  Running jdk_util ...
00:14:29.382  There is no test for target jdk_util

Updated your grinder to use BUILD_LIST=openjdk (versus the default value of BUILD_LIST=functional), so that the openjdk test targets get parsed (and test material gets compiled).
Rerun here: https://ci.adoptopenjdk.net/job/Grinder/1229/

Thanks @smlambert - just finished with a PASS.
Are we okay to do this moving forward (@sxa) - AND, considering your comment above - are you (@smlambert ) okay with the results based on this test, or do you want to run additional tests?

Testing again - just removing the link to the include files - to be sure that bit is being tested.
root@p9-aix1-ojdk06.osuosl.org:[/opt/freeware/include/X11]mv extensions extensions.IBM
root@p9-aix1-ojdk06.osuosl.org:[/opt/freeware/include/X11]

https://ci.adoptopenjdk.net/job/Grinder/1237/

Further, I see the system is not equivalent with the build-*{1|2} as they are oslevel
root@p8-aix2-ojdk01:[/root]oslevel -s -q | head
Known Service Packs
-------------------
7100-04-04-1717

While the test system is:
root@p9-aix1-ojdk06.osuosl.org:[/opt/freeware/include/X11]oslevel -s -q | head
Known Service Packs
-------------------
7100-05-06-2028

So we are NOT testing equivalent kernel settings.

This is also related to #1772 . Will add comment asap - here and #infrastructure

https://github.com/adoptium/infrastructure/issues/2069#issuecomment-902639183
root@p8-aix2-ojdk02:[/root]rpm -e libXrender libXft libXrender-devel tk renderproto
warning: file /opt/freeware/lib/libXrender.a: remove failed: A file or directory in the path name does not exist.

the file had already been renamed - making it appear asif the RPM was already de-installed.
Now removing these files as well - to complete the cleanup:

root@p8-aix2-ojdk02:[/root]ls -l /opt/freeware/lib/libX*
-rwxr-xr-x 1 root system 722338 Mar 28  2017 /opt/freeware/lib/libXrender.a-SXAMOVED
-rwxr-xr-x 1 root system 949342 May 29  2018 /opt/freeware/lib/libXrender.a.issue2069

root@p8-aix2-ojdk02:[/root]rm /opt/freeware/lib/libX*

# to get the system to point at the IBM installed X11 extenstions
rmdir /opt/freeware/include/X11/extensions
ln -s /usr/include/X11/extensions /opt/freeware/include/X11/extensions

If the build now succeeds, the symbolic link should be removed, (https://github.com/adoptium/infrastructure/issues/2069#issuecomment-903280080)
and the test repeated. When it fails, the AIX include directive should be:
#include <X11/extensions/Xrender.h>

ie, needs a change in configure.ac for AIX to look in X11/extensions - rather than add /usr/include/X11/extensions to cflags -
I expect it is /opt/freeware/include/X11/extensions atm.

Build at https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk11u/job/jdk11u-aix-ppc64-hotspot/1001/consoleFull succeeded on build-osuosl-aix71-ppc64-2 after the changes described above.

I cannot run this job, so needs verification after doing:
root@p8-aix2-ojdk02:[/root]ls -ld /usr/include/X11/extensions /opt/freeware/include/X11/extensions
lrwxrwxrwx 1 root system   27 Sep 25 12:00 /opt/freeware/include/X11/extensions -> /usr/include/X11/extensions
drwxr-xr-x 2 bin  bin    4096 Feb 18  2021 /usr/include/X11/extensions
root@p8-aix2-ojdk02:[/root]rm /opt/freeware/include/X11/extensions

The PR #2330 also removes this directory.

Since I cannot run a build via the web-interface and jenkins, I tried using:
git clone  https://github.com/adoptium/temurin-build.git
cd temurin-build
./makejdk-any-platform.sh jdk11u

This completed successfully.


MH-13446 Removed unfinished feature "ACL transitions"

The feature "ACL transition" has been part of the Opencast codebase since at least Opencast 1.6.
Since at least Opencast 2.x, this feature is unfinished in means of not actually being integrated into the Admin UI.
As nobody seems to use this functionality and nobody seems to work on this in the near future, it makes sense to remove the related code parts from our codebase.
Discussion on list: https://groups.google.com/a/opencast.org/forum/#!topic/dev/Wrj8nBwNZ3c

@karendolan At the today's technical meeting, you mentioned that DCE is doing some ACL scheduling. Are you using the code this PR aims to remove or is this completely external code?

@staubesv We are using completely external code. It is Ok with me to remove this code.


Pdfkit import fails in Electron

Bug Report
Description of the problem
I am trying to import pdfkit in Electron. I have been using Pdfkit in Node.js without trouble so far, but my Electron application will not run after I add the import.
Code sample
import PDFDocument from 'pdfkit';
I receive the following error:
    at createError (electron/js2c/asar.js:126)
    at Object.fs.readFileSync (electron/js2c/asar.js:545)
    at Object../node_modules/fontkit/index.js (ArabicShaper.js:5)
    at __webpack_require__ (bootstrap:789)
    at fn (bootstrap:100)
    at Module../node_modules/pdfkit/js/pdfkit.es5.js (index.js:20)
    at __webpack_require__ (bootstrap:789)
    at fn (bootstrap:100)
    at Module../src/renderer/lib/exportToPdf.ts (exportToPdf.ts:3)
    at __webpack_require__ (bootstrap:789)

Your environment

pdfkit version: 0.11.0
Electron version: 9.0.4
Node version: 12.14.1
Browser version (if applicable): Chromium 83.0.4103.104
Operating System: Windows 10

Can you try pdfkit-next?
It load resources in a browser friendly way. ( Not site about electron )

Are you trying to use in the main or a renderer process?  In main depending on your setup you may need to use require.
const PDFDocument = require('pdfkit')
I use it successfully in a renderer process with the import statement.

Anybody found a solution for this?
Thanks!

I got my pdfkit 0.11.0 working with electron 8.5.2 and webpack 4.41.6 or something... As far as i can see (and i was struggling around for two days..) - all the ressource/font/import problems are coming from a broken bundling setup of your webpack... in the end, it had absolutely nothing to do with electron nor pdfkit itself...
But it's really frightening to see, what needs to be included in a webpack config to get pdfkit working... 😩 For me, this PR got the ritght ingredients in it:
https://github.com/Pzixel/PDFKit-example/pull/1/files
I stumbled upon it trough this issue-report: https://github.com/foliojs/pdfkit/issues/990
To describe my journey shortly:

I installed a package, needing pdfkit internally... i could integrate it but always got the error File 'data/Helvetica.afm' not found in virtual file system
Startet to tweak my webpack config.. you need to define an alias for the virtual file-system of "pdfkit"... Then i've got over the error by doing the things here (importing the font file and writing it manually..): https://github.com/blikblum/pdfkit-webpack-example/issues/1
Still no luck... until i've kicked out the package installed again, forked it, cloned it, and copy-pasted the whole source of the package into my electron project... Then, a totally new error arrived: ENOENT: no such file or directory, open '//data.trie'
Googling again for the new error go me to this other issue-report (the first one i've linked) - and thus with the final webpack config where i need to add even more aliases, and much more super crazy loaders, i got now a working example of the integrated pdfkit "PDF" in my electron app - i'm totally amazed! <3

For main process, I did it with following config for webpack.
Electron 10.1.3
Webpack  4.44.2
Pdfkit 0.11.0 ( for pdfmake 0.1.66)
/* eslint-disable no-useless-escape */
const path = require("path");
const StringReplacePlugin = require("string-replace-webpack-plugin");
const ReplaceInFileWebpackPlugin = require("replace-in-file-webpack-plugin");

module.exports = {
  entry: "./src/main/index.js",
  target: "electron-main",
  resolve: {
    modules: [
      "node_modules",
      path.resolve(__dirname, "node_modules/babel-runtime/node_modules")
    ],
    alias: {
      "unicode-properties": "unicode-properties/unicode-properties.cjs.js",
      /*
      !!IMPORTANT!!
      Use this instead of pdfkit.js to get rid of data.trie issue.
      Incorrect data.trie buffer created by transform-loader causing crash without any message.
      */
      pdfkit: "pdfkit/js/pdfkit.standalone.js"
    }
  },
  plugins: [
    new StringReplacePlugin(),
    // Replace for "src = fs.readFileSync(src);"
    new ReplaceInFileWebpackPlugin([
      {
        dir: ".webpack/main",
        files: ["index.js"],
        rules: [
          {
            search: "__REQUIRE__",
            replace: "require"
          }
        ]
      }
    ])
  ],
  module: {
    rules: [
      // Other loaders but not related to pdfkit and pdfmake
      ...require("./webpack.rules"),
      // Replace all fs import. For "src = fs.readFileSync(src);", "require" can not be kept by any conventional method in webpack4.
      // So we have to replace it after compilation.
      {
        enforce: "pre",
        test: /pdfkit/,
        loader: StringReplacePlugin.replace({
          replacements: [
            {
              pattern: "src = fs.readFileSync(src);",
              replacement: function() {
                return "src = __REQUIRE__('fs').readFileSync(src);";
              }
            },
            {
              pattern: /fs.readFileSync/gi,
              replacement: function() {
                return "require('fs').readFileSync";
              }
            }
          ]
        })
      },
      // For classes.trie
      {
        test: /linebreak[\/\\]src[\/\\]linebreaker.js/,
        loader: "transform-loader?brfs"
      }
    ]
  }
};

There's a webpack 5 example at https://github.com/foliojs/pdfkit/tree/master/examples/webpack. It should work with electron


Events do not provide access to the dataTransfer object.

Currently dataTransfer is only passed to the setData event, and getData is never called in sortable.js.
This means it is not possible to pass and receive custom data because there is no way to call dataTransfer.getData.
Possible solutions:

Pass dataTransfer to all events
Add a property "nativeEvent" on evt that allows the native event to be accessed.

Edit:  I can make a pull request if you'll take it in.  I ended up adding a property called "nativeEvent" on your component's event object.
Edit2:  The more I look at it, the cleanest design seems to be using the same object for all events.  This would add more capability and be consistent.  For example, if you need the source list during the setData event, it would be accessible.

I have the same issue, how else can I pass a custom object when drag and drop? any updates?

@RubaXa

There is an option setData (https://github.com/RubaXa/Sortable/blob/master/Sortable.js#L173-L175), why it does not suit you?

I need call event.dataTransfer.getData("Text") in onEnd event to retrieve the data, but it does not provide dataTransfer object

I specifically put a link to the implementation setData, so at onEnd getData("Text") === dragEl.textContent.

So no fix to this?


123 tropind has one point in the arctic ocean

Just reading through to make sure I understand changes to code - so basically, regions are now stored as BitMatrix (no NaN allowed) but Fields can still have NAN values.
Some pretty minor issues I've noted

ex0.tracerinversion fails because there are NaNs in the qPO4 variable file. checkgrid! in readfield throws an error. I'm a little confused about why this is happening, because there are NaN values in \theta, but it doesn't throw an error.
not sure if we want to fix the display of a BC - gappy and doesn't show land?

I'm going to write a script to loop through all regions, and plot them (this will make it easy to check for misbehaving points), and also to easily add new regions using a .csv file - this is how I created my regions, not sure if there's a better way, but I can write a little guide on how to do it.

Thank you for reviewing the code and finding these errors/bugs/features.

Correct, masks do not have NaNs, just trues and falses. Their element type is T::Bool. Fields have numerical values of type T <: Real.

The scripts directory uses code that attempts to duplicate what is in the runtests. It causes issues with maintenance. Whenever the runtest is updated, then the scripts directory needs to be updated, but I have not done so. The solution to the problem in ex0 is probably easy and can be seen in the runtests. It is likely changing readfield to readsource.

The better way to solve the problem is to have the runtests and scripts use the same code chunks, thereby making maintenance easier.

It would be great to make a better representation of the BoundaryCondition mask. Do you have any ideas? The mask is a BitMatrix and the land mask is also a BitMatrix.

Other possible bug - for a surface BC from the regions file b, b.wet returns a BitMatrix that's all 1s - is this intentional?


Contribute - INNR RB 148 T - Candle E14 tuneable white

Updated with more descriptive name in model.json
Updated values for BRI 251/255

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.395%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2758

Relevant Lines:
2803

💛  - Coveralls


Enhance Theme Manager UI

Is your feature request related to a problem? Please describe.
On the theme manager when the number of sets gets too big, it gets easy to miss out which sets are enabled or not. And if the token folders have a nested structure, visually it gives the appearance of not being nested.
Describe the solution you'd like

Have a visual cue to easily identify enabled sets like a toggle/checkbox.
Have a more visual indent for the nested token folders

Current UI
Here the folders "brand-A" and "brand-B" is nested under "brand"

Suggested UI

Closing this issue as the proposed solution is already implemented


docker-compose up gives error, says I need to provide Project ID

This is what I get when I run:
>>> docker-compose up
time="2023-10-31T12:40:57+01:00" level=warning msg="The \"OT\" variable is not set. Defaulting to a blank string."
time="2023-10-31T12:40:57+01:00" level=warning msg="The \"OT\" variable is not set. Defaulting to a blank string."
time="2023-10-31T12:40:57+01:00" level=warning msg="The \"OT\" variable is not set. Defaulting to a blank string."
Attaching to v12-langchain-chainlit-chat-app-1
v12-langchain-chainlit-chat-app-1  | Traceback (most recent call last):
v12-langchain-chainlit-chat-app-1  |   File "/app/.venv/bin/chainlit", line 5, in <module>
v12-langchain-chainlit-chat-app-1  |     from chainlit.cli import cli
v12-langchain-chainlit-chat-app-1  |   File "/app/.venv/lib/python3.11/site-packages/chainlit/__init__.py", line 8, in <module>
v12-langchain-chainlit-chat-app-1  |     from chainlit.config import config
v12-langchain-chainlit-chat-app-1  |   File "/app/.venv/lib/python3.11/site-packages/chainlit/config.py", line 213, in <module>
v12-langchain-chainlit-chat-app-1  |     config = load_config()
v12-langchain-chainlit-chat-app-1  |              ^^^^^^^^^^^^^
v12-langchain-chainlit-chat-app-1  |   File "/app/.venv/lib/python3.11/site-packages/chainlit/config.py", line 189, in load_config
v12-langchain-chainlit-chat-app-1  |     raise ValueError("Project ID is required when public is set to false.")
v12-langchain-chainlit-chat-app-1  | ValueError: Project ID is required when public is set to false.
v12-langchain-chainlit-chat-app-1 exited with code 1

Where do I find the project ID, and with what name do I need to give the project ID in the .env file? I tried CHAINLIT_PROJECT_ID=xxxxxxxxxx, but that did not work.

Also, DOCKER_BUILDKIT does not work on Windows. I keep getting this error:
'DOCKER_BUILDKIT' is not recognized as an internal or external command, operable program or batch file.
That's why I did the docker build without DOCKER_BUILDKIT. Could that be why docker compose is not working?

I think the error is clear public is set to false in the config file of chainlit  about your second question it's not related anyway you can try buildx instead if I'm not wrong


fix: productName best localized choice

What

About a week ago tests started to fail in openfoodfacts-dart (cf. https://github.com/openfoodfacts/openfoodfacts-dart/issues/816, https://github.com/openfoodfacts/openfoodfacts-dart/pull/817)
It looks like from now on we cannot rely on productName to match the specified language, even if a localization is available. Looks like the product name is computed when the data is input (as product name or as localized product names), and then regardless of the language of the "get" queries later we always get the same product name.
A simple fix (that makes sense anyway) is to rely first on the localizations of the product name, and then on the single product name field as a fallback. It used to be coded the other way around, which started not to work about a week ago.

Screenshot
The product name changes between the 2 screenshots (it was not the case before this PR):

The product was downloaded in an app in English
Then the app language was switched to French

Impacted files

nutrition_page_loaded.dart: minor refactoring
product_cards_helper.dart: now the product name is taken from the localized version first; minor refactoring

We're currently processing your upload.  This comment will be updated when the results are available.

It looks like from now on we cannot rely on productName to match the specified language, even if a localization is available. Looks like the product name is computed when the data is input (as product name or as localized product names), and then regardless of the language of the "get" queries later we always get the same product name.

There hasn't been a change on the server side.  product_name contains the name of the product in its main language (indicated by the lc field of the product), it does not changed based on the lc field of the request.

There hasn't been a change on the server side.

Strange, because there was no change on our code either and suddenly tests started to fail.

product_name contains the name of the product in its main language (indicated by the lc field of the product)

Aha, we were not aware of the existence of the lc product field!
Could we say that:

lc is the main language of the product
lang is the language used for the latest product update

@stephanegigandet Could you please confirm that, so that I can add field lc to the product fields in off-dart?

it does not changed based on the lc field of the request.

Then our tests were wrong from the very start. But still passed for some reason.
That said, your comment confirms that the current PR will be an improvement in Smoothie: instead of displaying always the "main" product_name (that always relates to the main product language called lc), we display the localized product name (with product_name as fallback).

@teolemon review ping

@monsieurtanuki When you read products, the "lc" field and the "lang" field you get back in the JSON have the same value: the language of the product. When you write products, you have to use "lang" to specify the main language of the product, and "lc" is the language you are sending fields for (e.g. lc : fr, lang : de, product_name : nom en français)

@stephanegigandet Thank you for this clarification.
Then we shouldn't add lc as a product field in off-dart: when we read it it's the same value as lang anyway, and when we write we already have a lc parameter (not as a product field, but as a query parameter).

@teolemon Now that the possible confusion between lc and lang has been dealt with, we would be better off with the localized product name first, and then the main language product name as fallback. Like coded in this PR.

@teolemon Still not interested in using the best product name?

@g123k @M123-dev could one of you have a look codewise ?

Thank you guys for your comments and reviews!


HIVE-26930: Support for increased retention of Notification Logs and Change Manager entries

What changes does this PR contain?
To support the Planned/Unplanned Failover, we need the capability to increase the retention period for both the Notification Logs and Change Manager entries until the successful reverse replication is done (i.e. the Optimized Bootstrap). A database-level property 'repl.db.under.failover.sync.pending' was introduced to signify this state. This PR contains the changes for,

selective deletion of notification events that are not relevant to the database(s) in failover
skipping the CM clearer thread execution until the time the Optimized Bootstrap is not done

Why this change is needed?
The change is needed to make the Optimized Bootstrap and Point-in-time consistency possible. If the relevant Notification logs and Change Manager entries are not retained, we can't perform the Optimized Bootstrap.
Were the changes tested?
I have included relevant unit tests in this PR, and will also perform manual verification after deploying the changes on a cluster.
Does this PR introduce any user-facing change?
No

Closing this PR, will raise another.


Can't inject into WhatsApp.app

Unfortunately I can't inject into WhatsApp.app... bfinject returns success, but not even the simple dylib injection creates the success popup on the iPhone
root@iPhone (/jb/bfinject) #bash bfinject -P WhatsApp.app -L iSpy
[+] Liberios detected
[+] Injecting into '/var/containers/Bundle/Application/22991067-E622-4525-BC16-12287B29005D/WhatsApp.app/WhatsApp'
[+] Getting Team ID from target application...
[+] Thinning dylib into non-fat arm64 image
[+] Signing injectable .dylib with Team ID 57T9237FN3 and platform entitlements...
[bfinject4realz] Calling task_for_pid() for PID 835.
[bfinject4realz] Calling thread_create() on PID 835
[bfinject4realz] Looking for ROP gadget... found at 0x102fc6c08
[bfinject4realz] Fake stack frame at 0x12a800000
[bfinject4realz] Calling _pthread_set_self() at 0x186bff804...
[bfinject4realz] Returned from '_pthread_set_self'
[bfinject4realz] Calling dlopen() at 0x1869bf460...
[bfinject4realz] Returned from 'dlopen'
[bfinject4realz] Success! Library was loaded at 0x1c01f0e00
[+] So long and thanks for all the fish.

Does it leave an entry in the console log?

I checked in a new version that better accommodates all screen/window/VC layouts. This should work in all cases. Please open a new issue if it doesn't.


Bluetooth Download feature

Description
Download code wirelessly via Web Bluetooth. Supported for micro:bit currently.
How to enable it?

Open a browser that supports Web Bluetooth. See https://caniuse.com/#feat=web-bluetooth. On Windows, you'll need Chrome 70+.
Go to the gearwheel menu and click on Pair Bluetooth
Select your device and pair
Press Download to start remote flashing.

If you cannot see that button and you editor supports this experiment, go to About, then click Experiments and Bluetooth Download. If you cannot see this card, your editor does not support yet this feature.
Known issues
Needs initial drag & drop
This feature only supports partial flashing now. This means that you need to first drag and drop a .hex file using the USB cable; then you'll be able to update that same scripts using Bluetooth.
Pairing issues in windows
Use the "No Pairing" setting in the Project Settings for Windows.
My micro:bit is stuck in pairing mode
Partial flashing failed to finish.

Drag and drop a .hex file via USB

My micro:bit won't start after failed partial flashing?

Reinstall the firmware

Feedback
Do you use this feature? Is there something you'd like to change? Did you encounter issues? Please drop a comment on this issue to send us your feedback.

Is the function supported in android chrome?

Microbit has a pairing-mode LED showing after press "Download" in macos 10.14.1 with chrome 70.0.3538.77
Test in android 8.0.0, chrome 70.0.3538.80 has a stucking after press "Download", LED always no change.

Please try on https://makecode.microbit.org/beta
Get Outlook for iOShttps://aka.ms/o0ukef

From: u-hori<EMAIL_ADDRESS>Sent: Saturday, November 3, 2018 5:52 PM
To: Microsoft/pxt
Cc: Peli de Halleux; Author
Subject: Re: [Microsoft/pxt] Bluetooth Download feature (#4807)
Is the function supported in android chrome?

Microbit has a pairing-mode LED showing after press "Download" in macos 10.14.1 with chrome 70.0.3538.77
Test in android 8.0.0, chrome 70.0.3538.80 has a stucking after press "Download", LED always no change.
[screenshot_20181104-083752]https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F41528875%2F47958775-4fa1ca80-e00d-11e8-9aac-d9a0a17f4047.jpg&data=02|01|jhalleux%40microsoft.com|ae827a6b0866465544b008d641efc2cb|72f988bf86f141af91ab2d7cd011db47|1|0|636768895359644149&sdata=C1giAbsTNZAkjvYiozPVEg2nlPzyQ%2FDcMJvitkCgdzA%3D&reserved=0

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt%2Fissues%2F4807%23issuecomment-435632815&data=02|01|jhalleux%40microsoft.com|ae827a6b0866465544b008d641efc2cb|72f988bf86f141af91ab2d7cd011db47|1|0|636768895359654157&sdata=gBq%2BYj9F8cUiNeE68vLjRg%2FgkPOETvGCZkTZtwWiJ1I%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD-4KXOUa5snm6ygpl-ENdvjxCp6D4_oks5urjo9gaJpZM4XZy3B&data=02|01|jhalleux%40microsoft.com|ae827a6b0866465544b008d641efc2cb|72f988bf86f141af91ab2d7cd011db47|1|0|636768895359654157&sdata=BOE%2B%2FokVGQ6Gqcqrdoz02ZLiAXUOtRfdtDnvgGPZS3E%3D&reserved=0.

@pelikhan Use https://makecode.microbit.org/beta#editor has tha same result.

Try going into “no pairing mode”. For the first flash, you need to do drag and drop. Still beta - UI needs love.

Use https://makecode.microbit.org/beta?dbg=1 and open JavaScript console to see full logs

https://twitter.com/krantas/status/1057996189981798400?s=21

Use https://makecode.microbit.org/beta?dbg=1 and open JavaScript console to see full logs

Macos's console log for the first flash:
pf: error USB flashing required
I got your hint and the Macos's bluetooth download was done in beta!

It is possible to flash the entire image but it takes much longer. Not supported yet.

You can use the Android Microbit app for that.

So... the key point is the first flash flow whatever by USB or BT?  Then BT partial-flash can be triggered?

I buy a Type-C OTG wire and do testing the result re-flashing is workable but no pairing-mode LED is shown in downloading.
And the usage difference in android from macos is the OTG wire has to be connected otherwise beta UI will have a stuck after press "Download" as before. FYR~

This would be a great option! I tried it but the code is not flashed to the micro:bit. These were my steps:

I enabled the experiment
I was able to connect to make a bluetooth connection

I see the special pattern on the m:b
I uploaded the hex via USB to the m:b
I unplugged the USB-connection
I changed the script
I tried to upload it
Nothing happens, stil have the special pattern on the m:b

I am on Chrome 71.0.3578.98 and Windows 10

Make sure to flash using USB at least once (we still need to support full flashing).

Hi,

I built a program and saved it as a hex-file
From the Windows Explorer I copied the hex-file to the micro:bit (I suppose this is what you mean by full flashing)
I made the bluetooth connection with the micro:bit
Changed the program
Clicked the Download button
-The color of the button changed for some seconds, but nothing happens on the micro:bit

On windows, you need to enable the “no pairing” mode.

Looks like this is no longer working since MakeCode 2020 release https://github.com/microsoft/pxt-microbit/issues/3283

I write code on MacOS 10.15.6 with Chrome 84.0.4147.89 (Official Build) (64-bit), the firmware version is 0253. I tried it but the code is not flashed to the micro:bit. These were my steps:

I enabled the experiment on https://makecode.microbit.org/beta?dbg=1#editor

I built a program and uploaded the hex via USB to the micro:bit

I unpluged the USB-connection

I held button A and B, then pressed the restart button on micro:bit

I was able to connect to make a bluetooth connection

I changed the script

I pressed the download button

It saved the .hex file

Nothing happened on the micro:bit.

I encountered the same issue (bluetooth paring being successful while the downloading partially revised code only ending up with downloading .hex file locally) as @microboym has posted above.  For myself, I tried this bluetooth download feature on:
(i) Mac OS 10.13.6 with Chrome 84.0.4147.89 (64 bit) (Official Build) and micro:bit firmware version 0253.
(ii) Windows 10 Home Version 1909 with Chrome 84.0.4147.105 (64 bit) (Official Build)and micro:bit firmware version 0253.  (following the instruction, with "no-paring" setting)
I have successfully paired and flashed codes from (a) iPad with the micro:bit app and I also confirmed that (b) the scratch link via bluetooth works on both of the environments (i) and (ii) above (this (b) may be irrelevant here though).
Fully understand that this bluetooth download feature is on its experimental phase and grateful for the effort to enable code downloading without cable connection.  Thank you.

I overlooked the post by @microbit-mark on June 18 - sorry to see that this feature is no longer available on MakeCode 2020.  Out of curiosity, I tried using the old version MakeCode, with which this feature successfully worked.

I overlooked the post by @microbit-mark on June 18 - sorry to see that this feature is no longer available on MakeCode 2020. Out of curiosity, I tried using the old version MakeCode, with which this feature successfully worked.

How to use the old version MakeCode, @phoenixvane ?

@microboym, please kindly see below for the way to use the previous version of MakeCode where the bluetooth download feature is still available.

Access to the previous version of the editor
Should you need to, you will still be able to access the previous version at https://makecode.microbit.org/v2 until 2022 and you can access the old version at https://makecode.microbit.org/v0 until 2020.

https://support.microbit.org/support/solutions/articles/19000058445-makecode-editor-updates

As documentation to download a project via Bluetooth is not very clear, at least for someone that is trying for the first time, I have decided to put these steps on a paper:
Note:
+All these steps have been tested on Windows10 OS
+You should have basic understanding of working with Microbit (e.g. loading a project via cable)
Prerequisites:
1 x Microbit + battery pack
micro USB cable
PC & Chrome browser v70+
Step 1: Create a new Microbit project in the previous editor version - v1 (the v2 doesn't work with bluetooth extension)
open following link in Chrome browser: https://makecode.microbit.org/v1#editor
Step 2: Enable Bluetooth download extension
Settings>About>Experiments>click on the Bluetooth Download tile
Step 3: check No Pairing Required in Project Settings
In project: go to Settings>Project Settings>
>Enable No Pairing Required
>Provide a Name: e.g. Myproject
>Click Save
Click Download and save the .hex file in your PC
Step 4: Download this project to Microbit via cable (this is mandatory only for the first time, after that, this project can be updated via bluetooth)
Connect Microbit to PC using micro USB cable
Copy the .hex file (resulted from step 3) to Microbit
When transfer is finished, unplug the USB cable from Microbit
Step 5: Connect to Microbit via Bluetooth (this is necessary only when you open your project for first time)
Make sure the Microbit is powered (e.g via battery pack)
Put the Microbit in Pairing mode: press simultaneous the buttons A + B + reset, and keep pressed until the Bluetooth icon appears on Microbit board
In project: go to Settings>Pair Bluetooth>select the Microbit and click on Pair
Step 6:Download the project to Microbit
<only if Step 6 is not done immediately after step 5 :)
Make sure the Microbit is powered (e.g via battery pack)
Put the Microbit in Pairing mode: press simultaneous buttons A + B + reset, and keep pressed until the Bluetooth icon appears on Microbit
>
Click on Download button: the Microbit patern leds will start to flicker and will switch off when download is finished
Enjoy!
Adrian

@adryannn do you know the root cause of this great "experimental" feature not working?

It got broken while refactoring the webusb stack.

It got broken while refactoring the webusb stack.

@pelikhan, I was assuming the same, when I have discovered this in June.
There is any chance to have this fixed in the next release?
Thank you!

When should we expect to see full flashing working?  The reason I am asking is because cables might not connect, ( perhaps to due cable quality ) and having another way to write code would be grand.

i am making project of smart car using microbit. i am sending data from mobile bluetooth terminal app to microbit using bluetooth uart service in that first time getting correct data but second time not getting correct data(some rules not followed by microbit). how to resolve ?

@pelikhan does this experiment still work?

Unlikely. Was working pre-v2, not upgraded yet.

From: Abhijith Chatra @.>
Sent: Thursday, July 14, 2022 9:38:23 AM
To: microsoft/pxt @.>
Cc: Peli de Halleux @.>; Mention @.>
Subject: Re: [microsoft/pxt] Bluetooth Download feature (#4807)
@pelikhanhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpelikhan&data=05|01|jhalleux%40microsoft.com|5d68042162424134d71708da656bd54c|72f988bf86f141af91ab2d7cd011db47|1|0|637933811065949743|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=VxCdqflzoDvW9DgBB4SfHiGT9R0ORL9CIHzyYXm1YRo%3D&reserved=0 does this experiment still work?
—
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpxt%2Fissues%2F4807%23issuecomment-1184104155&data=05|01|jhalleux%40microsoft.com|5d68042162424134d71708da656bd54c|72f988bf86f141af91ab2d7cd011db47|1|0|637933811065949743|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=OsoKh1AqSUHRUYGoA2iuKk6KjhnSb5%2FfNHTSgJgGl1Q%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA73QKMT4NEPNALIWUGB53DVT67W7ANCNFSM4F3HFXAQ&data=05|01|jhalleux%40microsoft.com|5d68042162424134d71708da656bd54c|72f988bf86f141af91ab2d7cd011db47|1|0|637933811065949743|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=S6KzOL2woi3LyDTgljMAD6ua20%2Bvd65ucCw4EIySp1g%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

@pelikhan any plans to rev this for micro:bit V2? web-bluetooth is getting quite prevalent and with the 'triple tap reset to pair' change in CODAL I think the Ux for MakeCode-->micro:bit directly over Bluetooth will be really nice.
https://github.com/lancaster-university/codal-microbit-v2/compare/master...triple-reset-to-pair

Not from me

Can't get it to work on micro:bit v2.1?
What is the alt way to download code via bluetooth? Android apps is not updated either

Bluetooth downloads don't work on my device


APP-761: MessageMLv1 parsers and unit tests refactored to reflect new MessageMLv2 package structures.

MessageMLv1 parsers and unit tests refactored to reflect new MessageMLv2 package structures.

Can one of the admins verify this patch?

This PR is being closed because this code was included on the PR #29.


172 - pythonTestDirChem (Failed)

Configuration:

RDKit Version:  '2020.03.4'
Operating system:
Distributor ID:	Ubuntu
Description:	Ubuntu 16.04.7 LTS
Release:	16.04
Codename:	xenial
Python version (if relevant):  3.6.9
Are you using conda? Use conda for installing additional libs, like boost
If you are using conda, which channel did you install the rdkit from? Install from source
If you are not using conda: how did you install the RDKit? Install from source

I compiled latest RDKit release with Python 3.6.9 but had a failed test pythonTestDirChem :
Description:
Ran 6 tests in 0.145s
OK
......
Ran 6 tests in 0.037s
OK
....[12:04:39]

Pre-condition Violation
valence not defined for atoms not associated with molecules
Violation occurred on line 311 in file /rdkit/rdkit/Code/GraphMol/Atom.cpp
Failed Expression: dp_mol

.
Ran 5 tests in 0.019s
OK
....
Ran 4 tests in 0.019s
OK
..
Ran 2 tests in 0.028s
OK
......................
Ran 22 tests in 0.055s
OK
.....s.................ss
Ran 25 tests in 0.525s
OK (skipped=3)
..s
Ran 3 tests in 0.186s
OK (skipped=1)
...................................
Ran 35 tests in 1.042s
OK
....
Ran 4 tests in 0.032s
OK
.
Ran 1 test in 0.022s
OK
.......
Ran 7 tests in 0.070s
OK
...
Ran 3 tests in 0.049s
OK
.ss.ss.......
Ran 13 tests in 1.709s
OK (skipped=4)
................[12:05:16] WARNING: More than one matching pattern found - picking one
[12:05:16] WARNING: More than one matching pattern found - picking one
.[12:05:16] WARNING: More than one matching pattern found - picking one
..
Ran 19 tests in 27.150s
OK
........
Ran 8 tests in 0.163s
OK
....[12:05:22] WARNING: not removing hydrogen atom without neighbors
[12:05:22] WARNING: not removing hydrogen atom without neighbors
[12:05:22] WARNING: not removing hydrogen atom without neighbors
.......
Ran 11 tests in 4.844s
OK
....
Ran 4 tests in 1.537s
OK
......
Ran 6 tests in 0.552s
OK
.......[12:05:32] WARNING: not removing hydrogen atom with dummy atom neighbors
[12:05:32] WARNING: not removing hydrogen atom with dummy atom neighbors
....[12:05:33] WARNING: not removing hydrogen atom with dummy atom neighbors
[12:05:33] WARNING: not removing hydrogen atom with dummy atom neighbors
[12:05:33] WARNING: not removing hydrogen atom with dummy atom neighbors
[12:05:33] WARNING: not removing hydrogen atom with dummy atom neighbors
...............
Ran 26 tests in 5.598s
OK
..............[12:05:46] WARNING: More than one matching pattern found - picking one
[12:05:46] WARNING: More than one matching pattern found - picking one
...........
Ran 25 tests in 11.576s
OK
..
Ran 2 tests in 0.093s
OK
..s...
Ran 6 tests in 1.189s
OK (skipped=1)
.[12:05:49] WARNING: not removing hydrogen atom without neighbors
.[12:05:49] WARNING: not removing hydrogen atom without neighbors
.[12:05:49] WARNING: no name column found on line 1
[12:05:49] WARNING: no name column found on line 2
[12:05:49] WARNING: no name column found on line 3
[12:05:49] WARNING: no name column found on line 4
[12:05:49] WARNING: no name column found on line 5
[12:05:49] WARNING: no name column found on line 6
[12:05:49] WARNING: no name column found on line 7
[12:05:49] WARNING: no name column found on line 8
[12:05:49] WARNING: no name column found on line 9
[12:05:49] WARNING: no name column found on line 10
[12:05:49] WARNING: no name column found on line 11
[12:05:49] WARNING: no name column found on line 12
[12:05:49] WARNING: no name column found on line 13
[12:05:49] WARNING: no name column found on line 14
[12:05:49] WARNING: no name column found on line 15
[12:05:49] WARNING: no name column found on line 16
[12:05:49] WARNING: no name column found on line 17
[12:05:49] WARNING: no name column found on line 18
[12:05:49] WARNING: no name column found on line 19
[12:05:49] WARNING: no name column found on line 20
[12:05:49] WARNING: no name column found on line 21
[12:05:49] WARNING: no name column found on line 22
[12:05:49] WARNING: no name column found on line 23
[12:05:49] WARNING: no name column found on line 24
[12:05:49] WARNING: no name column found on line 25
[12:05:49] WARNING: no name column found on line 26
[12:05:49] WARNING: no name column found on line 27
[12:05:49] WARNING: no name column found on line 28
[12:05:49] WARNING: no name column found on line 29
[12:05:49] WARNING: no name column found on line 30
[12:05:49] WARNING: no name column found on line 31
[12:05:49] WARNING: no name column found on line 32
[12:05:49] WARNING: no name column found on line 33
[12:05:49] WARNING: no name column found on line 34
[12:05:49] WARNING: no name column found on line 35
[12:05:49] WARNING: no name column found on line 36
[12:05:49] WARNING: no name column found on line 37
[12:05:49] WARNING: no name column found on line 38
[12:05:49] WARNING: no name column found on line 39
[12:05:49] WARNING: no name column found on line 40
[12:05:49] WARNING: no name column found on line 41
[12:05:49] WARNING: no name column found on line 42
[12:05:49] WARNING: no name column found on line 43
[12:05:49] WARNING: no name column found on line 44
[12:05:49] WARNING: no name column found on line 45
[12:05:49] WARNING: no name column found on line 46
[12:05:49] WARNING: no name column found on line 47
[12:05:49] WARNING: no name column found on line 48
[12:05:49] WARNING: no name column found on line 49
[12:05:49] WARNING: no name column found on line 50
[12:05:49] WARNING: no name column found on line 51
[12:05:49] WARNING: no name column found on line 52
[12:05:49] WARNING: no name column found on line 53
[12:05:49] WARNING: no name column found on line 54
[12:05:49] WARNING: no name column found on line 55
[12:05:49] WARNING: no name column found on line 56
[12:05:49] WARNING: no name column found on line 57
[12:05:49] WARNING: no name column found on line 58
[12:05:49] WARNING: no name column found on line 59
[12:05:49] WARNING: no name column found on line 60
[12:05:49] WARNING: no name column found on line 61
[12:05:49] WARNING: no name column found on line 62
[12:05:49] WARNING: no name column found on line 63
[12:05:49] WARNING: no name column found on line 64
[12:05:49] WARNING: no name column found on line 65
[12:05:49] WARNING: no name column found on line 66
[12:05:49] WARNING: no name column found on line 67
[12:05:49] WARNING: no name column found on line 68
[12:05:49] WARNING: no name column found on line 69
[12:05:49] WARNING: no name column found on line 70
[12:05:49] WARNING: no name column found on line 71
[12:05:49] WARNING: no name column found on line 72
[12:05:49] WARNING: no name column found on line 73
[12:05:49] WARNING: no name column found on line 74
[12:05:49] WARNING: no name column found on line 75
[12:05:49] WARNING: no name column found on line 76
[12:05:49] WARNING: no name column found on line 77
[12:05:49] WARNING: no name column found on line 78
[12:05:49] WARNING: no name column found on line 79
[12:05:49] WARNING: no name column found on line 80
[12:05:49] WARNING: no name column found on line 81
[12:05:49] WARNING: no name column found on line 82
[12:05:49] WARNING: no name column found on line 83
[12:05:49] WARNING: no name column found on line 84
[12:05:49] WARNING: no name column found on line 85
[12:05:49] WARNING: no name column found on line 86
[12:05:49] WARNING: no name column found on line 87
[12:05:49] WARNING: no name column found on line 88
[12:05:49] WARNING: no name column found on line 89
[12:05:49] WARNING: no name column found on line 90
[12:05:49] WARNING: no name column found on line 91
[12:05:49] WARNING: no name column found on line 92
[12:05:49] WARNING: no name column found on line 93
[12:05:49] WARNING: no name column found on line 94
[12:05:49] WARNING: no name column found on line 95
[12:05:49] WARNING: no name column found on line 96
[12:05:49] WARNING: no name column found on line 97
[12:05:49] WARNING: no name column found on line 98
[12:05:49] WARNING: no name column found on line 99
[12:05:49] WARNING: no name column found on line 100
[12:05:49] WARNING: no name column found on line 101
[12:05:49] WARNING: no name column found on line 102
[12:05:49] WARNING: no name column found on line 103
[12:05:49] WARNING: no name column found on line 104
[12:05:49] WARNING: no name column found on line 105
[12:05:49] WARNING: no name column found on line 106
[12:05:49] WARNING: no name column found on line 107
[12:05:49] WARNING: no name column found on line 108
[12:05:49] WARNING: no name column found on line 109
[12:05:49] WARNING: no name column found on line 110
[12:05:49] WARNING: no name column found on line 111
[12:05:49] WARNING: no name column found on line 112
[12:05:49] WARNING: no name column found on line 113
[12:05:49] WARNING: no name column found on line 114
[12:05:49] WARNING: no name column found on line 115
[12:05:49] WARNING: no name column found on line 116
[12:05:49] WARNING: no name column found on line 117
[12:05:49] WARNING: no name column found on line 118
[12:05:49] WARNING: no name column found on line 119
[12:05:49] WARNING: no name column found on line 120
[12:05:49] WARNING: no name column found on line 121
[12:05:49] WARNING: no name column found on line 122
[12:05:49] WARNING: no name column found on line 123
[12:05:49] WARNING: no name column found on line 124
[12:05:49] WARNING: no name column found on line 125
[12:05:49] WARNING: no name column found on line 126
[12:05:49] WARNING: no name column found on line 127
[12:05:49] WARNING: no name column found on line 128
[12:05:49] WARNING: no name column found on line 129
[12:05:49] WARNING: no name column found on line 130
[12:05:49] WARNING: no name column found on line 131
[12:05:49] WARNING: no name column found on line 132
[12:05:49] WARNING: no name column found on line 133
[12:05:49] WARNING: no name column found on line 134
[12:05:49] WARNING: no name column found on line 135
[12:05:49] WARNING: no name column found on line 136
[12:05:49] WARNING: no name column found on line 137
[12:05:49] WARNING: no name column found on line 138
[12:05:49] WARNING: no name column found on line 139
[12:05:49] WARNING: no name column found on line 140
[12:05:49] WARNING: no name column found on line 141
[12:05:49] WARNING: no name column found on line 142
[12:05:49] WARNING: no name column found on line 143
[12:05:49] WARNING: no name column found on line 144
[12:05:49] WARNING: no name column found on line 145
[12:05:49] WARNING: no name column found on line 146
[12:05:49] WARNING: no name column found on line 147
[12:05:49] WARNING: no name column found on line 148
[12:05:49] WARNING: no name column found on line 149
[12:05:49] WARNING: no name column found on line 150
[12:05:49] WARNING: no name column found on line 151
[12:05:49] WARNING: no name column found on line 152
[12:05:49] WARNING: no name column found on line 153
[12:05:49] WARNING: no name column found on line 154
[12:05:49] WARNING: no name column found on line 155
[12:05:49] WARNING: no name column found on line 156
[12:05:49] WARNING: no name column found on line 157
[12:05:49] WARNING: no name column found on line 158
[12:05:49] WARNING: no name column found on line 159
[12:05:49] WARNING: no name column found on line 160
[12:05:49] WARNING: no name column found on line 161
[12:05:49] WARNING: no name column found on line 162
[12:05:49] WARNING: no name column found on line 163
[12:05:49] WARNING: no name column found on line 164
[12:05:49] WARNING: no name column found on line 165
[12:05:49] WARNING: no name column found on line 166
[12:05:49] WARNING: no name column found on line 167
[12:05:49] WARNING: no name column found on line 168
[12:05:49] WARNING: no name column found on line 169
[12:05:49] WARNING: no name column found on line 170
[12:05:49] WARNING: no name column found on line 171
[12:05:49] WARNING: no name column found on line 172
[12:05:49] WARNING: no name column found on line 173
[12:05:49] WARNING: no name column found on line 174
[12:05:49] WARNING: no name column found on line 175
[12:05:49] WARNING: no name column found on line 176
[12:05:49] WARNING: no name column found on line 177
[12:05:49] WARNING: no name column found on line 178
[12:05:49] WARNING: no name column found on line 179
[12:05:49] WARNING: no name column found on line 180
[12:05:49] WARNING: no name column found on line 181
[12:05:49] WARNING: no name column found on line 182
[12:05:49] WARNING: no name column found on line 183
[12:05:49] WARNING: no name column found on line 184
[12:05:49] WARNING: no name column found on line 185
[12:05:49] WARNING: no name column found on line 186
[12:05:49] WARNING: no name column found on line 187
[12:05:49] WARNING: no name column found on line 188
[12:05:49] WARNING: no name column found on line 189
[12:05:49] WARNING: no name column found on line 190
[12:05:49] WARNING: no name column found on line 191
[12:05:49] WARNING: no name column found on line 192
[12:05:49] WARNING: no name column found on line 193
[12:05:49] WARNING: no name column found on line 194
[12:05:49] WARNING: no name column found on line 195
[12:05:49] WARNING: no name column found on line 196
[12:05:49] WARNING: no name column found on line 197
[12:05:49] WARNING: no name column found on line 198
[12:05:49] WARNING: no name column found on line 199
[12:05:49] WARNING: no name column found on line 200
[12:05:49] WARNING: no name column found on line 201
[12:05:49] WARNING: no name column found on line 202
[12:05:49] WARNING: no name column found on line 203
[12:05:49] WARNING: no name column found on line 204
[12:05:49] WARNING: no name column found on line 205
[12:05:49] WARNING: no name column found on line 206
[12:05:49] WARNING: no name column found on line 207
[12:05:49] WARNING: no name column found on line 208
[12:05:49] WARNING: no name column found on line 209
[12:05:49] WARNING: no name column found on line 210
[12:05:49] WARNING: no name column found on line 211
[12:05:49] WARNING: no name column found on line 212
[12:05:49] WARNING: no name column found on line 213
[12:05:49] WARNING: no name column found on line 214
[12:05:49] WARNING: no name column found on line 215
[12:05:49] WARNING: no name column found on line 216
......
Ran 9 tests in 0.158s
OK
..................
Ran 18 tests in 1.137s
OK
...
Ran 3 tests in 0.118s
OK
........
Ran 8 tests in 0.055s
OK
..
Ran 2 tests in 0.034s
OK
..
Ran 2 tests in 0.016s
OK
.
Ran 1 test in 0.168s
OK
........
Ran 8 tests in 0.002s
OK
...
Ran 3 tests in 0.005s
OK
...
Ran 3 tests in 0.003s
OK
....
Ran 4 tests in 0.005s
OK
.......
Ran 7 tests in 0.026s
OK
....
Ran 4 tests in 0.017s
OK
....
Ran 4 tests in 4.618s
OK
..........
Ran 10 tests in 0.084s
OK
.
Ran 1 test in 0.000s
OK
..........
Ran 10 tests in 0.008s
OK
.....
Ran 5 tests in 0.141s
OK
.....................
Ran 21 tests in 7.079s
OK
mol_197
219.10,35.89,110.98,11.56,110.32,11.04,95.23,10.25,0.00
mol_223
251.91,7.32,135.48,1.38,135.41,1.39,85.51,0.37,0.00
mol_269
216.26,5.67,105.00,0.87,103.81,0.89,89.27,0.92,6.00
.
Ran 1 test in 0.000s
OK
...[12:06:14]

Pre-condition Violation
molecule has no conformers
Violation occurred on line 37 in file /rdkit/rdkit/Code/GraphMol/MolChemicalFeatures/MolChemicalFeature.cpp
Failed Expression: dp_mol->getNumConformers()

.
Ran 4 tests in 0.020s
OK
..
Ran 2 tests in 26.981s
OK
..
Ran 2 tests in 0.104s
OK
...
Ran 3 tests in 0.019s
OK
....
Ran 4 tests in 0.056s
OK
.....[12:06:44] WARNING: not removing hydrogen atom without neighbors
[12:06:44] WARNING: not removing hydrogen atom without neighbors
[12:06:44] WARNING: not removing hydrogen atom without neighbors
[12:06:44] WARNING: not removing hydrogen atom without neighbors
[12:06:44] WARNING: not removing hydrogen atom without neighbors
[12:06:44] WARNING: not removing hydrogen atom without neighbors
[12:06:44] WARNING: not removing hydrogen atom without neighbors
[12:06:44] WARNING: not removing hydrogen atom without neighbors
[12:06:44] WARNING: not removing hydrogen atom without neighbors
[12:06:44] WARNING: not removing hydrogen atom without neighbors
[12:06:44] WARNING: not removing hydrogen atom without neighbors
[12:06:44] WARNING: not removing hydrogen atom without neighbors
[12:06:44] WARNING: not removing hydrogen atom without neighbors
[12:06:44] WARNING: not removing hydrogen atom without neighbors
[12:06:44] WARNING: not removing hydrogen atom without neighbors
[12:06:44] WARNING: not removing hydrogen atom without neighbors
[12:06:44] WARNING: not removing hydrogen atom without neighbors
[12:06:44] WARNING: not removing hydrogen atom without neighbors
[12:06:44] WARNING: not removing hydrogen atom without neighbors
.....
Ran 10 tests in 0.368s
OK
sss........QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/runtime-root'
qt.qpa.screen: QXcbConnection: Could not connect to display
Could not connect to any X display.
Forcing use of Agg renderer
...
Ran 3 tests in 0.627s
OK
.
Ran 1 test in 0.118s
OK
!!! TEST FAILURE:  python UnitTestDraw.py {}
..........
Ran 10 tests in 1.004s
OK
..[12:06:51] SMARTS Parse Error: syntax error while parsing: boromicacid
[12:06:51] SMARTS Parse Error: Failed parsing SMARTS 'boromicacid' for input: 'boromicacid'
[12:06:51] SMARTS Parse Error: syntax error while parsing: carboxylicacid,acidchlroide
[12:06:51] SMARTS Parse Error: Failed parsing SMARTS 'carboxylicacid,acidchlroide' for input: 'carboxylicacid,acidchlroide'
[12:06:51] SMARTS Parse Error: syntax error while parsing: carboxyliccaid,acidchloride
[12:06:51] SMARTS Parse Error: Failed parsing SMARTS 'carboxyliccaid,acidchloride' for input: 'carboxyliccaid,acidchloride'
[12:06:51] reaction has no reactants
[12:06:51] reaction has no products
[12:06:51] initialization failed
[12:06:51] reaction has no reactants
[12:06:51] reaction has no products
.
Ran 3 tests in 0.046s
OK
....
Ran 4 tests in 0.021s
OK
!!! TEST FAILURE:  python test_list.py {'dir': 'Draw'}
    Start 173: pythonTestSping

173/173 Test #173: pythonTestSping ........................   Passed    0.92 sec
99% tests passed, 1 tests failed out of 173
Total Test time (real) = 590.52 sec
The following tests FAILED:
172 - pythonTestDirChem (Failed)
Errors while running CTest

<!-- If you have a support question, please use the rdkit-discuss mailing list:
https://sourceforge.net/p/rdkit/mailman/ -->

@fedyaryabov Try running
ctest -I 173,172 -V

This will give you more verbose output and a stack trace that might hint at the problem (e.g., missing Python module).

This looks like it could be a display problem.
You might want to try export QT_QPA_PLATFORM='offscreen' before running the tests.

It works! Thank you for your help @greglandrum


The SelaVPR in Figure 2 is missing the citation.

Thank you for the comprehensive and insightful survey paper. The SelaVPR [1] method mentioned in Figure 2 of the paper is missing the citation. Could you update it?
[1] Lu, Feng, et al. "Towards Seamless Adaptation of Pre-trained Models for Visual Place Recognition." The Twelfth International Conference on Learning Representations. 2024.

Thanks for your reminder. We will add this citation in our revised manuscript.


Yaml to proto ?

Is it possible to do yaml to proto also ?
then we still get schema evolution behaviours. So any client can cope with field additions etc

Interesting, There is no reason why it couldn't be done. but I think it detracts form the real use of .proto files.
proto files are designed to be a concise and precise representation of a service definition, whereas YAML is a more human-readable and flexible format that allows for more variability and interpretation.
The original use case I had was to use the generated output as a terraform input format, but can see how some folks will want to do what you mentioned.
It wasnt on the radar to add, but happy to take any sensible PR 😄

hey @krzko
i know what you mean about it not making sense.  It's just that i can code gen off the yaml --> Proto and then code gen from the proto --> golang.
I will try to get to this and make a PR.

Stale


License?

Hi,
I've just cloned Thanks for sharing it!
Could you please add a copyright section to your source files? Or alternatively you could add a LICENSE.txt with an  MIT or BSD license. The TI sources already have this.
Thanks,
David

Good catch, added. Thanks!


ERROR in ./app/components/Header/banner.jpg

I just setup my react-boilerplate for the first time and after following the given steps i have struck in some error related for jpegtran
ERROR in ./app/components/Header/banner.jpg
Module build failed: Error: spawn /home/aniruddh/react/react-boilerplate/node_modules/jpegtran-bin/vendor/jpegtran ENOENT
    at _errnoException (util.js:999:13)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:201:19)
    at onErrorNT (internal/child_process.js:389:16)
    at process._tickCallback (internal/process/next_tick.js:152:19)
 @ ./app/components/Header/index.js 16:0-34
 @ ./app/containers/App/index.js
 @ ./app/app.js
 @ multi eventsource-polyfill webpack-hot-middleware/client?reload=true ./app/app.js

When I am starting the app I am seeing this error and my localhost:3000 is showing not found error.
OS: Ubuntu 16.04 LTS
Node: 9.3.0
npm: 5.6.0
Thanks, in advance

@aniagarwal97 can your try these steps: https://github.com/visionmedia/debug/issues/261#issuecomment-207623445
Also after this, can you check if /node_modules/jpegtran-bin/vendor/jpegtran is present in the file system.

I am also having this problem. Any attempt to install and run the project results in incomplete installs of:

jpegtran-bin (never had jpegtran inside the vendor folder)
gifsicle (gifsicle/vendor/gifsicle binary doesn't seem to work correctly ⚠ gifsicle pre-build test failed`)
optipng

and one other package.

The gifsicle error comes from following the comment you linked, @vigzmv:
><EMAIL_ADDRESS>postinstall <stuff>/react-boilerplate/node_modules/gifsicle
> node lib/install.js

  ⚠ The `<stuff>/react-boilerplate/node_modules/gifsicle/vendor/gifsicle` binary doesn't seem to work correctly
  ⚠ gifsicle pre-build test failed
  ℹ compiling from source
<stuff>/react-boilerplate/node_modules/onetime/index.js:15
        throw new Error(fnName + ' can only be called once.');
        ^

In my experence it is most because of your network is not stable, try to reinstall RBP:
rm -rf ~/.npm   // optional, make sure you know what you do
rm -rf node_modules
yarn install

This happens also with different versions of image-webpack-loader and its image processors. Try disabling JPEG processing in webpack.base.babel.js by doing mozjpeg: false.

Try to reinstall RBP in a stable network environment， close this for now. :)


Check if blob exists before minting NFT

Motivation
This is a follow up suggested on #2354
Proposal
Check if the Blob exists before actually minting the NFT
Test Plan
CI

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#2356  👈
#2355
#2354
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @andresilva91 and the rest of your teammates on  Graphite

Merge activity

Aug 9, 2:14 PM EDT: @andresilva91 started a stack merge that includes this pull request via Graphite.


JVM crash in VM::RetransformClassesHook

Hi Async-profiler developers!
We see the following crash in our internal testing. The issue is not critical for us.
I can't provide a reproducer.
async-profiler version: 2.0
Please ask if you need some additional info.
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x00007fcffcbf23d0, pid=476, tid=478
#
# JRE version: OpenJDK Runtime Environment Zulu11.47+17-NV (11.0.10+1) (build <IP_ADDRESS>.101+1-LTS)
# Java VM: OpenJDK 64-Bit Server VM Zulu11.47+17-NV (<IP_ADDRESS>.101+1-LTS, mixed mode, tiered, compressed oops, g1 gc, linux-amd64)
# Problematic frame:
# C  [libasyncProfiler.so+0x313d0]  VM::RetransformClassesHook(_jvmtiEnv*, int, _jclass* const*)+0x60
#
# Core dump will be written. Default location: /export/workspace/ext/out/runtime/core.476
#
# If you would like to submit a bug report, please visit:
#   http://www.azulsystems.com/support/
# The crash happened outside the Java Virtual Machine in native code.
# See problematic frame for where to report the bug.
#

---------------  T H R E A D  ---------------

Current thread (0x00007fcff8035800):  JavaThread "main" [_thread_in_native, id=478, stack(0x00007fcfffc72000,0x00007fcfffd73000)]

Stack: [0x00007fcfffc72000,0x00007fcfffd73000],  sp=0x00007fcfffd71880,  free space=1022k
Native frames: (J=compiled Java code, A=aot compiled Java code, j=interpreted, Vv=VM code, C=native code)
C  [libasyncProfiler.so+0x313d0]  VM::RetransformClassesHook(_jvmtiEnv*, int, _jclass* const*)+0x60
C  [libjckjvmti.so+0x5f27d]  Java_javasoft_sqe_tests_vm_jvmti_rtrc001_rtrc00117_rtrc00117_doTest+0x8b
j  javasoft.sqe.tests.vm.jvmti.rtrc001.rtrc00117.rtrc00117.doTest()I+0
j  javasoft.sqe.tests.vm.jvmti.rtrc001.rtrc00117.rtrc00117.run([Ljava/lang/String;Ljava/io/PrintStream;)I+85
j  javasoft.sqe.tests.vm.jvmti.rtrc001.rtrc00117.rtrc00117.main([Ljava/lang/String;)V+8
v  ~StubRoutines::call_stub
V  [libjvm.so+0x8d1a12]  JavaCalls::call_helper(JavaValue*, methodHandle const&, JavaCallArguments*, Thread*)+0x3c2
V  [libjvm.so+0x9438c7]  jni_invoke_static(JNIEnv_*, JavaValue*, _jobject*, JNICallType, _jmethodID*, JNI_ArgumentPusher*, Thread*) [clone .isra.89]+0x227
V  [libjvm.so+0x948121]  jni_CallStaticVoidMethod+0x171
C  [libjli.so+0x526f]  JavaMain+0xa8f

Java frames: (J=compiled Java code, j=interpreted, Vv=VM code)
j  javasoft.sqe.tests.vm.jvmti.rtrc001.rtrc00117.rtrc00117.doTest()I+0
j  javasoft.sqe.tests.vm.jvmti.rtrc001.rtrc00117.rtrc00117.run([Ljava/lang/String;Ljava/io/PrintStream;)I+85
j  javasoft.sqe.tests.vm.jvmti.rtrc001.rtrc00117.rtrc00117.main([Ljava/lang/String;)V+8
v  ~StubRoutines::call_stub

siginfo: si_signo: 11 (SIGSEGV), si_code: 1 (SEGV_MAPERR), si_addr: 0x0000000000000000

Register to memory mapping:

RAX=0x0 is NULL
RBX=0x0 is NULL
RCX=0x00007fcff802a0d0 points into unknown readable memory: 0xfffffffffffffffe | fe ff ff ff ff ff ff ff
RDX=0x0 is NULL
RSP=0x00007fcfffd71880 is pointing into the stack for thread: 0x00007fcff8035800
RBP=0x00007fcfffd718c0 is pointing into the stack for thread: 0x00007fcff8035800
RSI=0x00005653e17a7880 points into unknown readable memory: 0x0000000000000002 | 02 00 00 00 00 00 00 00
RDI=0x00000000fff80006 is an unallocated location in the heap
R8 =0x00005653e17a7880 points into unknown readable memory: 0x0000000000000002 | 02 00 00 00 00 00 00 00
R9 =0x0000000000000008 is an unknown value
R10=0x00007fcfdfe086e1 is at code_begin+897 in an Interpreter codelet
method entry point (kind = native)  [0x00007fcfdfe08360, 0x00007fcfdfe08ce0]  2432 bytes
R11=0x0000000101ce2408 is an oop: java.lang.Class
{0x0000000101ce2408} - klass: 'java/lang/Class'
R12=0x0 is NULL
R13=0x0000000000000001 is an unknown value
R14=0x00007fcf3c002060 points into unknown readable memory: 0x00007fcffeeb8200 | 00 82 eb fe cf 7f 00 00
R15=0x00007fcff8035b48 points into unknown readable memory: 0x00007fcffeea8c80 | 80 8c ea fe cf 7f 00 00

Registers:
RAX=0x0000000000000000, RBX=0x0000000000000000, RCX=0x00007fcff802a0d0, RDX=0x0000000000000000
RSP=0x00007fcfffd71880, RBP=0x00007fcfffd718c0, RSI=0x00005653e17a7880, RDI=0x00000000fff80006
R8 =0x00005653e17a7880, R9 =0x0000000000000008, R10=0x00007fcfdfe086e1, R11=0x0000000101ce2408
R12=0x0000000000000000, R13=0x0000000000000001, R14=0x00007fcf3c002060, R15=0x00007fcff8035b48
RIP=0x00007fcffcbf23d0, EFLAGS=0x0000000000010246, CSGSFS=0x002b000000000033, ERR=0x0000000000000004
  TRAPNO=0x000000000000000e

Top of Stack: (sp=0x00007fcfffd71880)
0x00007fcfffd71880:   00000064ffd718e0 00007fcffe24a3f9
0x00007fcfffd71890:   00007fcff8035b48 00007fcf7fc0d698
0x00007fcfffd718a0:<PHONE_NUMBER>000000 00007fcf7fc0d698
0x00007fcfffd718b0:   00007fcfffd71960 00007fcff8035800

OK, the problem is understood. Another agent calls JVM TI RetransformClasses with a NULL argument, but async-profiler is not ready for this.
The issue should never happen in a normal application. This is apparently a crafted example that intentionally makes an invalid JVM TI call (makes sense, since the crash log suggests this was indeed a JVM TI test).
Anyway, async-profiler should handle such situations, too. I've pushed the fix.

Thanks, Andrei!
I have verified the fix.


Use Systemd service instead of rc.local

Since rc.local is considered deprecated, perhaps it would be best to move the script to a normal systemd service implementation instead?

that's great. rc.local will no longer work after several years.


Covers Folder Needs to be created

Awesome Plug In.
A suggestion: If the “Book Covers” folder does not exist, an error should be raised.

On the contrary, create the Folder or allow the folder to be created at New File Location


[Foundation Tests] Add a unit test to validate the behavior of dropFirst

Previous changes resolved an issue that incorrectly offset indexes in slices; this resulted in misbehavior of dropFirst. This is a set of tests to validate the expected behavior.
rdar://problem/32596254

@swift-ci please test

@swift-ci please test

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - f4182b19a68b9024fa7564f75084f0378d403211
Test requested by - @phausler

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - f4182b19a68b9024fa7564f75084f0378d403211
Test requested by - @phausler


Connection header in response is always set to 'close' by response handler

Laravel Version: 5.2
PHP Version: 5.6

Description:
The response header 'Connection' is always set to 'close' by response handler. If the header set function is called to manually assign 'Connection' header to 'keep-alive', then response contains comma separated string 'keep-alive, close' which browser/client interprets as 'close'.
Steps To Reproduce:
use response()->json($array, 200, ['Connection' => 'keep-alive']) to set the keep-alive header.

5.2 is not supported anymore, please post on the forums and I'm sure somebody will be able to help you.


method_missing macro segfaults

The above code compiles but segfaults when executed:
  macro method_missing(name, args, block)
    puts name.class
  end

bad_name

It also crashes if I change name.class to name == "foo"

That's because name isn't defined so it triggers the toplevel method_missing macro again which generates a method like
def name
  puts name.class
end

# or
def name
   name == "foo"
end

which results in a stack overflow due to recursing endlessly.
To access the macro parameter name use {{name}}.

Hum. It is my first time with macros, I didn't know about {{}} syntax. Thank you!


It seems that the shadow in 3d_scene is wrong

Bevy version
Latest change in main branch
Operating system & version
macOS BigSur
What you did
Drop the latest change in main branch and found the shadow in 3d_scene is wrong
What you expected to happen
correct shadow
What actually happened
It seems that the shadow in 3d_scene is wrong
Additional information

it works fine for me on macOS Monterey... what is the gpu of your Mac?

@mockersf
debug info:
INFO bevy_render::renderer: AdapterInfo { name: "Intel Iris Pro Graphics", vendor: 0, device: 0, device_type: IntegratedGpu, backend: Metal }

I remember the shadow is fine a few days ago, maybe a couple of days right before renaming *-piped stuffs. Please let me know if you need any more information.

This looks like a duplicate of https://github.com/bevyengine/bevy/issues/3315 right @mockersf ?

Yup!

Closing to collect discusssion :)


ConnectionError

Describe bug
1 Failed download:
['UPRO']: ConnectionError(MaxRetryError('HTTPSConnectionPool(host='fc.yahoo.com', port=443): Max retries exceeded with url: / (Caused by NameResolutionError("<urllib3.connection.HTTPSConnection object at 0x000001AD4DB41FD0>: Failed to resolve 'fc.yahoo.com' ([Errno 11001] getaddrinfo failed)"))'))
This happens for all tickers.  UPRO is just an example.
Simple code that reproduces your problem
import yfinance as yf
import pandas as pd
def fetch_data(tickers):
ticker_data = {}
for ticker in tickers:
try:
data = yf.download(ticker, 5d, 1m, threads=True)
if not data.empty:
ticker_data[ticker] = data['Close']
else:
ticker_data[ticker] = None
except Exception as e:
ticker_data[ticker] = None
return ticker_data
def update_data(tickers):
ticker_data = fetch_data(tickers)
for ticker, data in ticker_data.items():
    if data is not None and len(data) > 0:
        latest_price = data.iloc[-1]
    else:
        latest_price = 'N/A'

df = pd.DataFrame(data_rows, columns=["Ticker", "Price"])

def run_script():
tickers = ["UPRO"]
update_data(tickers)
if name == "main":
run_script()
Debug log
1 Failed download:
['UPRO']: ConnectionError(MaxRetryError('HTTPSConnectionPool(host='fc.yahoo.com', port=443): Max retries exceeded with url: / (Caused by NameResolutionError("<urllib3.connection.HTTPSConnection object at 0x000001AD4DB41FD0>: Failed to resolve 'fc.yahoo.com' ([Errno 11001] getaddrinfo failed)"))'))
[100%%*]  1 of 1 completed
1 Failed download:
['UPRO']: ConnectionError(MaxRetryError('HTTPSConnectionPool(host='fc.yahoo.com', port=443): Max retries exceeded with url: / (Caused by NameResolutionError("<urllib3.connection.HTTPSConnection object at 0x000001AD4DC65A10>: Failed to resolve 'fc.yahoo.com' ([Errno 11001] getaddrinfo failed)"))'))
Bad data proof
No response
yfinance version
0.2.41
Python version
3.11
Operating system
WIN11

Mysteriously working now

It's on my end.  Am using "unbound" DNS in router.  Had Adblock turned on, that might have caused it.  Also I think the USB is glitchy.

close

Happened again this morning.  All quotes N/A

Working now.  I guess intermittent issue?

Issue with Yahoo servers?  Throttling?

Are you spamming? https://github.com/ranaroussi/yfinance/discussions/1513

Ah no.  Real issue.

Now some quotes coming through.  I think it's yahoo servers(?).

yfinance stores a cookie here: https://github.com/ranaroussi/yfinance#persistent-cache-store
Does deleting it help?

I am on WIN11 and there is no directory called py-yfinance here: Windows = C:/Users//AppData/Local/py-yfinance

All quotes were N/A a second ago and just now flashed real quote.

I also don't have yf.set_tz_cache_location

... how did you check yfinance version?

PS C:\Users\Bill\Documents\Python> pip show yfinance
Name: yfinance
Version: 0.2.41
Summary: Download market data from Yahoo! Finance API
Home-page: https://github.com/ranaroussi/yfinance
Author: Ran Aroussi
Author-email<EMAIL_ADDRESS>License: Apache
Location: C:\Users\Bill\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.11_qbz5n2kfra8p0\LocalCache\local-packages\Python311\site-packages
Requires: beautifulsoup4, frozendict, html5lib, lxml, multitasking, numpy, pandas, peewee, platformdirs, pytz, requests
Required-by:
PS C:\Users\Bill\Documents\Python>

PIP can be wrong. Use the method in the new issue form.

Back to N/As again

import yfinance as yf ; print(yf.version)
0.2.41

Regardless, if you don't have yf.set_tz_cache_location then your version must be almost 1-year old, or corrupt. https://github.com/ranaroussi/yfinance/commit/59af19d84c73e026730ac2c48310316011fe7efd

I had the following but chatGPT said:
Removed Invalid Cache Path:
The yf.set_tz_cache_location call was removed because it is not a valid method for managing cache in yfinance.
import datetime
import yfinance as yf
yf.set_tz_cache_location("C:\Users\Bill\Documents\Python\yfinance\py-yfinance")

Ok I uninstalled yfinance rebooted and reinstalled yfinance.  Quotes seem to be working now.  I'll let you know if something happens.  Thanks for all your help!
pip uninstall yfinance
pip install yfinance

New error even after uninstalling/reinstalling.

1 Failed download:
2024-08-21 08:17:14,639:ERROR:['UPRO']: YFPricesMissingError('$%ticker%: possibly delisted; No price data found (period=1d)')

I wrote some reconnection python code and it seems to be working with that.

I don't think my root cause was the same as your but if you use custom DNS server (for example pihole) fc.yahoo.com could be blocked. So ensure you can open and connect to the url from the device and you may check your dns.

Yes, I use unbound and when I connect to fc.yahoo.com it redirects to https://www.yahoo.com/.  But I don't think unbound is the problem as my scripts work fine on Linux OS.

I don't think my root cause was the same as your but if you use custom DNS server (for example pihole) fc.yahoo.com could be blocked. So ensure you can open and connect to the url from the device and you may check your dns.

you are a genius, thank you very much!


Expanding to other languages

Thank you for creating this! It's the data source I've been eagerly anticipating to integrate document context into https://github.com/TabbyML/tabby
(shooting out a request for api access)
I was wondering if you would be interested in expanding this to other languages such as:

TypeScript / npm
Go / godocs
Rust / docs.rs

I would also like to see some detail on how these embeddings are created and how one can do the same for some more libraries


How to get GPU memory footprints when using distributed inference?

I want to observe the GPU memory footprint of models when performing inferences.
When I perform inferences on a single GPU, torch.cuda.memory_allocated returns a positive number as expected. But when I perform distributed inferences, torch.cuda.memory_allocated returns 0.
Should I use nvidia-smi or some other techniques to get the GPU memory footprint?
Any help would be appreciated.

Hi @HermitSun, thanks for trying out vLLM and good question. When using multiple GPUs, vLLM creates 1 worker process per GPU. Thus, if you use 2 GPUs, there will be 3 processes in total and the process running your code will not directly use any GPU. To actually get the number, you will need to insert torch.cuda.memory_allocated inside the Worker class or in the model code.
BTW, you can configure the vLLM's GPU memory usage via the gpu_memory_utilization argument in the LLM class.

Thank you for your kind reply. After I insert code inside the Worker, it works.
Maybe we can provide some profiling hooks or decorators, if possible.


Don't run reviewer lottery from bots

It seems that the changes of https://github.com/ros-controls/ros2_controllers/pull/946 did not work, I'll add a test commit here to debug the github context.

@mergifyio backport iron humble