Possible migration to  java instead of groovy?

Hello,
First of all I'm using yor plugin in a few project and I'm pretty happy with it. Thank you for all the hard work you've put in.
One thhing that bothers me is that it depends on groovy which brings a big dependency of 4.3MB. If this was the only dependency in a project it shouldn't be a big issue, but dependencies tend to add up. I've checked my projects and groovy seems to be the bigges one.
I know languages are a personal choice and I respect that, please don't get me wrong. I also use groovy from time to time and I believe it has it's uses, especially in devops environments and with gradle.
I do feel however that in this case it's benefits are not really felt from deployment/ distribution perspective.
My question is: would you be open to migrate to Java? It should be doable with two-three day work ? I'm probably be able to put some effor in it if you are committed to this.
Especially since there is the migration to thymeleaf 3 comming up, it seemms like a good moment.
I belive this feature will not impact a lot of users since most of them will just use it and not extend it.
Regards,

Hi @ieugen, the short answer is no, I'm not going to write the next version of the layout dialect in Java.
The long answer is that, for various reasons (my day job is JavaScript, so I like being able to bring dynamic types and functional programming into my personal projects; thus I am now unmotivated to write Java code), I actually moved this project from Java to Groovy about a year ago, and don't want to go back to writing it in Java.
The Java -> Groovy migration happened between versions 1.2.9 and 1.3.0, so if you're keen to create your own Java-only fork, then that should be entirely possible and you're absolutely welcome to do so.  Maybe you can use the state of the code as at 1.2.9 as a starting point, or just rename everything in the current state from .groovy to .java and go from there.  The code is open source and licensed under Apache 2.0, so you've got a lot of freedom there :smiley:

Hi @ultraq, thank you for answering. I respect your reasons. I'll probably for it if I have some time. Thank you for the tip regarding the move from Java ot Groovy.

I know this thread is closed, but I thought I would mention our results for what it's worth. All else equal in our project using Thymeleaf 3, we see a 30% performance increase loading a test page using the fork of the ultraq dialect at https://github.com/zhanhb/thymeleaf-layout-dialect. Removing the dialect altogether, we see a 44% performance increase for the same test.
JMeter results attached for your reference.
dialect_results.zip

Yeah, @zhanhb has been pretty on to it, and if you're looking for a Java-only fork then that is the one I would recommend 👍


feat: Support offline bootstrap of Windows nodes

PR o'clock
Description
In case you need to spin nodes in environment, that does not have egress to internet windows nodes does not connect to cluster. The reason behind that is that Start-EKSBootstrap.ps1 which is baked in windows EKS AMI is executed with minimal set of parameters which then requires egress to eks.<region>.amazonaws.com. This endpoint does not support private link and does not come with managed prefix list. The only way to make the Boostrap script offline is to pass additional arguments - private EKS endpoint and Cluster CA.
Checklist

[x] README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation

could you add working example of EKS with Windows nodes to https://github.com/terraform-aws-modules/terraform-aws-eks/tree/master/examples ?

this looks like an area where we just make a generic variable and its up to users to provide whatever arguments they want for input rather than building out this massive string of input options

I think I require to run procedure to enable windows support over EKS.
I will try that approach

This issue has been resolved in version 18.0.0 :tada:


.github: add Root Cause Analysis in pull_request_template.md

What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
Related changes

PR to update pingcap/docs/pingcap/docs-cn:
Need to cherry-pick to the release branch

Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression

Consumes more CPU
Consumes more MEM

Breaking backward compatibility

Release note

/test

/test

/test

/test

/test

/run-all-tests

/run-all-tests

/run-all-tests

/merge

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests


Add Platform/OS support

I would love to see the same tool with Cross-platform releases, with OS/platform including OSX, Linux, BSD.

Hello @naryal2580,
Thank you for opening this issue! I will work on publishing releases for other platforms, with reference to this issue, plus let you know when the work is completed.
Thanks,
@TheBinitGhimire

Hello @naryal2580,
In the first major release (v0.1.0) of NtHiM, I have included the pre-compiled binaries for multiple architectures (aarch64, armv7, i686 and x86_64) and multiple platforms (Microsoft Windows, Linux, MacOS, Sun Solaris and NetBSD).
With that being done, the things you're looking for in the issue are now available as assets on the latest release of NtHiM.
Thank You for opening up this issue, and providing an opportunity for me to include cross-platform binary releases for NtHiM!
Thanks,
@TheBinitGhimire


Replace reflection with method handles

We now use java8 in the 4.2 branch so we should replace our reflection usage with method handles.

/cc @chrisvest


Fix handling of duplicate type names

When two types have the same name, the codegen often breaks down. This likely requires a deep refactor of this messy code. See this schema file as an example:
cw-ibc-lite-ics02-client.json

In case someone is here after running into this issue, I can give a suggestion. If two types have the same name, code should still be generated fine, but you may need to manually edit it to change the name of one of the structs (and wherever it is used) so that go compiles


Add FilePath to Model

I have realized that it require a certain amount of work that it might not worth it yet.
I'll reconsider when I'll refactor the fdscript class.


FAT-169: Implement mod-login-saml API Karate tests based on test plans

The orchestrate.feature is the top level of the tests. It creates an IdP with a POST binding and calls saml/login for it and does the same for a REDIRECT binding. In the spirit of integration testing, each configured IdP is an "actual test" IdP, taking suggestions for the two IdPs from the guide.
I wasn't able to fully test the saml/callback (what gets called by the IdP after logging in at the IdP), hopefully for obvious reasons, but there are some notes in the samlCallback.feature about that. Maybe there is a way to mock an "actual signature" from the IdP...? If so that requires more code fu than I have.
I think the rest assured tests cover more scenarios and edge cases but the coverage for the two binding types is new here (in addition to the tests running through okapi and a tenant).

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: steveellis:x: Steve EllisSteve Ellis seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Devoted a few brain cycles to this. Not loving that saml/callback isn't tested. I think it should be. There should be a way to simulate calling the endpoint from the IdP and get that 302 response.
The rest assured test just grabs the RelayState cookie from saml/login and posts it as a form param to saml/callback. When I tried doing the same through karate I got a 500 error. That could be generated from more than one place in the vertx route.
I thought it had something to do with the other form param SAMLResponse being signed by the IdP but looking more carefully at the code I'm not so sure about that. I don't see anywhere that the SAMLResponse param is being used at all, which would explain why the rest assured tests don't need it.
Part of the challenge here is that there are 5 or 6 places in the method that could be generating that 500 response, and none pass any details back in the body as far as I can see.
Does anybody have any ideas on this one?
What I would like to be able to do is deploy a build of mod-login-saml to the testing-backend that had more helpful logging on the monster method. Does anyone have a script for such things?

I may have been a little too optimistic about being able to test saml/callback.  I spent more time looking into exactly what the IdP returns in the form of the SAMLResponse and don't see an easy way to create one that would pass validation. Here's what testsaml.id returns:
SamlResponseExample.txt
I could replace the tenant info with the test tenant, but it's unclear to me what would be considered valid values for the other items in the file.


Performance method improvement

closes #9
Implemented the performance method to be able to measure the actual code execution time.
Fixed performance method description in docs.
Usage example:

Expected output:

LGTM @olga-demina , thanks for this!


fix RN race on clearing input

If you type quickly and hit send you can keep typing and your input won't be cleared.
This is largely due to a race with the native component and calling setText (which uses state).
As a workaround I added an explicit inputClear helper which uses the native props (see https://facebook.github.io/react-native/docs/direct-manipulation.html)
So when we clear the input on submit (as the example in the above RN docs does) we explicitly also set the inner view's input to blank also so we're in sync.
Not something we'd commonly need but chat input is pretty special
@keybase/react-hackers

I think this is so specific to rn it doesn't really make sense as anything
other than a pass through
On Tue, Apr 25, 2017 at 9:11 PM Max Goodman<EMAIL_ADDRESS>wrote:

@chromakode approved this pull request.
In shared/common-adapters/input.native.js
https://github.com/keybase/client/pull/6737#discussion_r113346758:

@@ -30,6 +30,10 @@ class Input extends Component<void, Props, State> {
}
}

setNativeProps (props: Object) {
this._input && this._input.setNativeProps(props)

🐑 It might be preferable to not expose setNativeProps and hide it as an
implementation detail of an inputClear method on the input, so we could
have something similar for desktop.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/keybase/client/pull/6737#pullrequestreview-34726108,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAfhU2PWrh6tYii7umYCQJ1CDJKdH1KBks5rzpmjgaJpZM4NIDQr
.


Run Debug Jest fails for CMD and GIT bash

Hello,
thanks for this VSCode extension, I find it really useful.
Unfortunately, I cannot make Debug Jest command work.
I can fire Run Jest on my test and it works fine.
It produces this output:
node "d:/DEV/SDP/sales_portal_master/node_modules/jest/bin/jest.js" "d:/DEV/SDP/sales_portal_master/sales_sdp_gui/fx/services/fx-drafts-chain-store.spec.ts" -t "subscribe: no draft yet, empty one is given"

But if I fire Debug Jest, it fails with this output:
$ "C:\\Program Files\\nodejs\\node.exe" --inspect-brk=7972 node_modules\\jest\\bin\\jest.js -i \"d:/DEV/SDP/sales_portal_master/sales_sdp_gui/fx/services/fx-drafts-chain-store.spec.ts\" -t "subscribe: no draft yet, empty one is given"
Debugger listening on ws://<IP_ADDRESS>:7972/41c4a8e8-153d-4010-bc8f-4991de6e7343
For help, see: https://nodejs.org/en/docs/inspector
Debugger attached.
jest-haste-map: duplicate manual mock found: fx-mocks
  The following files share their name; please delete one of them:
    * <rootDir>\sales_sdp_gui\__tests__\__mocks__\fx-mocks.ts
    * <rootDir>\target\js\sales_sdp_gui\__tests__\__mocks__\fx-mocks.js

jest-haste-map: duplicate manual mock found: gui-state-stub
  The following files share their name; please delete one of them:
    * <rootDir>\sales_sdp_gui\__tests__\__mocks__\gui-state-stub.ts
    * <rootDir>\target\js\sales_sdp_gui\__tests__\__mocks__\gui-state-stub.js

No tests found, exiting with code 1
Run with `--passWithNoTests` to exit with code 0
In D:\DEV\SDP\sales_portal_master
  2847 files checked.
  testMatch: **/?(*.)(spec|test).ts?(x) - 151 matches
  testPathIgnorePatterns: \\node_modules\\ - 2847 matches
  testRegex:  - 0 matches
Pattern: "d:\\DEV\\SDP\\sales_portal_master\\sales_sdp_gui\\fx\\services\\fx-drafts-chain-store.spec.ts" - 0 matches
Waiting for the debugger to disconnect...

Here is my jest.config.js file
 const path = require("path");

 module.exports = {
     preset: "ts-jest",
     setupFiles: ["<rootDir>/tests_gui/global-test-setup.ts"],
     testEnvironment: "jsdom",
     testURL: "http://localhost",
     rootDir: "./",
     transform: {
         ".(ts|tsx)$": "ts-jest",
         ".mail$": "jest-raw-loader"
     },
     testMatch: ["**/?(*.)(spec|test).ts?(x)"],
     snapshotSerializers: ["enzyme-to-json/serializer"],
     moduleNameMapper: {
         "^.+\\.(css|less|scss|html)$": "identity-obj-proxy",
         "ionweb-react": path.join(__dirname, "./src/mocks/ionweb-react")
     },
     globals: {
         "ts-jest": {
             // diagnostics: {
             //     ignoreCodes: [2531, 2532, 2722, 2743, 7005, 7006, 7008]
             // },
             diagnostics: true
         }
     }
 };

Here is my VSCode about:
Version: 1.37.1 (user setup)
 Commit: f06011ac164ae4dc8e753a3fe7f9549844d15e35
 Date: 2019-08-15T16:17:55.855Z
 Electron: 4.2.7
 Chrome: 69.0.3497.128
 Node.js: 10.11.0
 V8: 6.9.427.31-electron.0
 OS: Windows_NT x64 10.0.17763

I tried also to run debug manually by trying different arguments (removing the double quotes from test file path, for instance), but not luck.
Thanks for your support!

I am currently experiencing the same issue.
Running without debugging works fine, with debugging i get '0 matches' on Pattern.

Same issue here :(
c:\Users\Alon\Documents\devel\easy-template-x>cd c:\Users\Alon\Documents\devel\easy-template-x && "C:\Program Files\nodejs\node.exe" --inspect-brk=48008 node_modules\jest\bin\jest.js -i """c:/Users/Alon/Documents/devel/easy-template-x/test/fixtures/text.tests.ts""" -t "removes empty tags"
Debugger listening on ws://<IP_ADDRESS>:48008/0e20a544-e4fa-424f-bbc7-b20aa86fec57
For help, see: https://nodejs.org/en/docs/inspector
Debugger attached.
No tests found, exiting with code 1
Run with `--passWithNoTests` to exit with code 0
In C:\Users\Alon\Documents\devel\easy-template-x
  81 files checked.
  testMatch:  - 0 matches
  testPathIgnorePatterns: \\node_modules\\ - 81 matches
  testRegex: \\test\\.*[.]tests[.]ts$ - 10 matches
Pattern: "c:\\Users\\Alon\\Documents\\devel\\easy-template-x\\test\\fixtures\\text.tests.ts" - 0 matches
Waiting for the debugger to disconnect...

hey i just tested on my machine (linux)
and debug seemed to work and hits the breakpoint.

maybe its a problem for windows? i will double check.
if you know how to solve this issue, please do not hesitate to poste your solution or create a PR

Test on Windows 10 works as well:

my jest config:
https://github.com/firsttris/react-track/blob/master/jest.config.js
test file:
https://github.com/firsttris/react-track/blob/master/packages/server/src/collections/ComplainCollection.test.ts
🤷♂ can not find any issue

Using Powershell as a default shell does indeed fix this on windows. The problem happens when using CMD or Git bash as the default terminal. Perhaps a setting for an independant default terminal might be a solution here? (Might also be a nice way to apply a custom look to your tests).

thx @tuur29 for finding the issue

Perhaps a setting for an independant default terminal might be a solution here?

Seems like you can set a custom shellPath and extra arguments when opening a new terminal: https://code.visualstudio.com/api/references/vscode-api#window.createTerminal
Perhaps you could allow us to set these variables in the extension settings? No clue about the specifics though, I have yet to create my own VSCode extension.

Hi,
Love your extension and used it until this issue started happening.
When it did, I found this other great extension called Daddy-Jest.
The thing is, now I have both installed. I use Daddy Jest for debugging tests and this extension for running test without debugging.
Maybe you can join forces or at least learn from each other...
@firsttris @DevelEx

hey @alonrbar
don't know whats your issue, but this one is simple.
just use powershell - and everything works fine.
it's the best terminal for windows anyway.
if you want to improve stuff - code & contribute.

So you have to configure you vscode to use powershell, which is in most cases the default option anyway.
I also put this in the Readme: https://github.com/firsttris/vscode-jest-runner#known-issues


print key to file stream

All "elementary" keys support " human-readable " output to file stream. All those keys are deprecated in 3.0:
$ grep print_fp util/libcrypto.num
DSAparams_print_fp                      229     3_0_0   EXIST::FUNCTION:DEPRECATEDIN_3_0,DSA,STDIO
DSA_print_fp                            278     3_0_0   EXIST::FUNCTION:DEPRECATEDIN_3_0,DSA,STDIO
ECPKParameters_print_fp                 816     3_0_0   EXIST::FUNCTION:DEPRECATEDIN_3_0,EC,STDIO
X509_REQ_print_fp                       1110    3_0_0   EXIST::FUNCTION:STDIO
RSA_print_fp                            1119    3_0_0   EXIST::FUNCTION:DEPRECATEDIN_3_0,STDIO
EC_KEY_print_fp                         1121    3_0_0   EXIST::FUNCTION:DEPRECATEDIN_3_0,EC,STDIO
DHparams_print_fp                       2111    3_0_0   EXIST::FUNCTION:DEPRECATEDIN_3_0,DH,STDIO
X509_print_fp                           2463    3_0_0   EXIST::FUNCTION:STDIO
X509_CRL_print_fp                       2745    3_0_0   EXIST::FUNCTION:STDIO
X509V3_EXT_print_fp                     2815    3_0_0   EXIST::FUNCTION:STDIO
ECParameters_print_fp                   3318    3_0_0   EXIST::FUNCTION:DEPRECATEDIN_3_0,EC,STDIO
BN_print_fp                             3625    3_0_0   EXIST::FUNCTION:STDIO

Since 1.0 EVP_PKEY supports output using BIO functionality but lack direct output to files:
$ grep PKEY.*print util/libcrypto.num
EVP_PKEY_print_public                   1919    3_0_0   EXIST::FUNCTION:
EVP_PKEY_print_params                   2795    3_0_0   EXIST::FUNCTION:
EVP_PKEY_print_private                  2970    3_0_0   EXIST::FUNCTION:

This is an enhancement request to add functions that outputs directly to files.
Use case:  Now PKIX-SSH is rewritten to use pkey for identity and key exchange. In some operations it still uses "elementary" key. One case is for "debugging" purposes and would like to eliminate custom source here.

Given this is a replacement for functionality we are deprecating in 3.0, we should IMO add it.

Agreed, and it's not  hard task


Allow Staggering upon PlotJobPhase on Drive

Add a more dynamic way of staggering. Currently staggering is done by simply specifying an amount of Minutes to be waited before a plot is spawned on a separate or the same disk.
By continously monitoring PlotJob phase and its effects on ressource usage, a more dynamic way of staggering would be possible.

Hi Tydeno, love your work so far. Thank you.
Just wondering, are you still working on this feature? Actually setting a max jobs in Phase 1 would be perfect, and would compliment your other feature well - Max Jobs on Same Disk

hei @PiSCaRGoT; Thanks for your kind words :)
Yes, I am. Not actively right now, but I will get back to it.

I just commited a few changes to the branch dynamic-stagger that added the following:

Ability to define max parallel jobs in phase 1 per each disk
Ability to define max parallel jobs in phase 1 on all disks
Ability to launch a new plot when a given phase is completed (EarlyStart, set to 3 advised. So when a job completed phase 3, the next can be started)

The whole changed code is untested for now (no chia.exe here to test). @PiSCaRGoT If you'd like to try it out, yu may get the source from the dynamic-stagger branch :)

Perfect! Thanks for turning it around so quickly, let me give it a shot and let you know how it works.

@PiSCaRGoT I just tested it, has some flaws. Not advised to test for you rn. I need to dig deeper, but I'm pretty occupied this Weekend. Might take a bit longer than expected.


Explorer not updating file list

VSCode Version: Code 1.8.0 (38746938a4ab94f2f57d9e1309c51fd6fb37553d, 2016-12-13T17:38:28.425Z)
OS Version: Darwin x64 16.1.0
Extensions:

Extension
Author
Version

xml
DotJoshJohnson
1.6.0

vscode-docker
PeterJausovec
0.0.10

code-settings-sync
Shan
2.3.8

githistory
donjayamanne
0.1.4

python
donjayamanne
0.5.5

haml
groksrc
0.0.2

Go
lukehoban
0.6.51

csharp
ms-vscode
1.5.3

Ruby
rebornix
0.10.4

Steps to Reproduce:

Make changes to the directory from a command line
Note it does not appear in the Explorer

@brendandixon Code does not auto-refresh file changes that are made externally or through the built-in terminal. You need to you use the explorer's Refresh action for that.

@kieferrm that is very much not true, the explorer updates from any file event in the same way as a lot of other UI components react to file changes.
However, our file watcher can fail in some cases e.g. when there are too many events happening at the same time or for example when working with network drives on windows.
@brendandixon does this reproduce every time for you? Can you provide more detailed steps for me to reproduce?

@bpasero I'll keep my eyes open. Unfortunately, it's seems to be working again. (Go figure.)

@bpasero I think I have more detail. I often switch Git branches "under the covers" from VSCode. That is, using the command line, I'll bounce between branches to see different versions. It is this scenario where, occasionally, the explorer fails to see the changes.

However, our file watcher can fail in some cases e.g. when there are too many events happening at the same time or for example when working with network drives on windows.

@bpasero This happens fairly consistent for me when building my app using grunt.  My grunt script shuffles around a lot of files (app -> dist-temp -> dist) and often times explorer gets into a state where dist will appear empty even though it's not, and the manual refresh button will have no effect.
Interestingly enough, if I drag in a file in dist/ manually, it will trigger an update (the same thing I'd expect the refresh button to do).  I can make an animated GIF of it all if that would help.

Seems related: https://github.com/Microsoft/vscode/issues/15744

@langdonx which OS?

Windows 10, sorry.

This is very likely https://github.com/Microsoft/vscode/issues/19377


As the Designer, I want a simple way to enable Perforce so that I can turn Perforce on as needed.

[x] Setup Perforce exports for Linux only.
[x] Setup Perforce alias for Host Ryder only.
[x] Test.

Git-commit d667148 completed this task.


features for production

This looks great and my first thought was, wow, this looks like a great alternative to Flask!  but how would i implement things like  authentication & connections to a database -- things that would likely be needed for any real "production" implementation?

Thanks for the nice feedback!
In the current alpha version, you could add a token field to the Input object for passing an authentication token.
With regards to databases, you can connect to them in your opyrator functions. Since in the current version only a single function is allowed, you would need two files for a storing / loading example. The following example illustrates how this could look like:

Opyrator to save data
app_save.py

# app_save.py
from pydantic import BaseModel
import time
import sqlite3

db_name = 'example.db'
try:
    con = sqlite3.connect(db_name)
    cur = con.cursor()
    cur.execute('CREATE TABLE messages (timestamp text, message text)')
    con.commit()
    con.close
except Exception:
    pass

class Input(BaseModel):
    message: str
    token: str

class Output(BaseModel):
    status: str

def save(input: Input) -> Output:
    if input.token != 'foo':
        return Output(status="Not authenticated")

    con = sqlite3.connect(db_name)
    cur = con.cursor()

    cur.execute(f"INSERT INTO messages VALUES ('{int(time.time())}', '{input.message}')")
    con.commit()
    con.close()

    return Output(status="saved")

Opyrator to load data
app_load.py
from pydantic import BaseModel
from typing import List
import sqlite3

class Input(BaseModel):
    pass

class Output(BaseModel):
    messages: List[str]

def load(input: Input) -> Output:
    con = sqlite3.connect('example.db')
    cur = con.cursor()
    messages = []
    for row in cur.execute('SELECT * FROM messages ORDER BY timestamp'):
        messages.append(row[1])

    return Output(messages=messages)

Start them via:
opyrator launch-ui app_save:save --port 8080
opyrator launch-ui app_load:load --port 8081

Thank you again for awesome work, it will be really great if opyrator has in-built support of SQL alchemy or any ORM.


The following assertion was thrown building StreamBuilder(dirty, state: _StreamBuilderBaseState<User, AsyncSnapshot>#f09f8): 'package:provider/src/delegate_widget.dart': Failed assertion: line 228 pos 16: '_builder != null': is not true.

User-created ancestor of the error-causing widget was
AuthWidgetBuilder
package:mapx_app/main_app.dart:54
When the exception was thrown, this was the stack
#2      new BuilderStateDelegate
package:provider/src/delegate_widget.dart:228
#3      new Provider
package:provider/src/provider.dart:224
#4      MyApp.build.
package:mapx_app/main_app.dart:57
#5      AuthWidgetBuilder.build.

Hi @djfunkd ,
opening an issue please try to provide
all or some of the information indicated in the template

Issue Template
If you are looking for support, please check out our documentation
or consider asking a question on Stack Overflow:
- https://flutter.dev/
- https://api.flutter.dev/
- https://stackoverflow.com/questions/tagged/flutter?sort=frequent

If you have found a bug or if our documentation doesn't have an answer
to what you're looking for, then fill our the template below. Please read
our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports

Steps to Reproduce

Please tell us exactly how to reproduce the problem you are running into.

Please attach a small application (ideally just one main.dart file) that
reproduces the problem. You could use https://gist.github.com/ for this.

If the problem is with your application's rendering, then please attach
a screenshot and explain what the problem is.

1. ...
2. ...
3. ...

Please tell us which target platform(s) the problem occurs (Android / iOS / Web / macOS / Linux / Windows)
Which target OS version, for Web, browser, is the test system running?
Does the problem occur on emulator/simulator as well as on physical devices?

Target Platform:
Target OS version/browser:
Devices:

Run your application with `flutter run --verbose` and attach all the
log output below between the lines with the backticks. If there is an
exception, please see if the error message includes enough information
to explain how to solve the issue.

Run `flutter analyze` and attach any output of that command below.
If there are any analysis errors, try resolving them before filing this issue.

Finally, paste the output of running `flutter doctor -v` here.

Closing this issue, since no information has been provided.
Thank you.


[Bug Report] Form component cannot be verified in some case with requires type is number

Element UI version
1.4.0
OS/Browsers version
Chrome 59
Vue version
2.4.2
Reproduction Link
https://jsfiddle.net/7vgcLLsr/
Steps to reproduce
bind input data with an object's attribute, like: v-model="form.data"
What is Expected?
input validation is working fine
What is actually happening?
Vilidation always return error

https://jsfiddle.net/7vgcLLsr/1/


Clean up code from dlab-finance and set up CRSP-related architecture

cc @max-eddy @Jay4869
Feel free to bug me about this.

I have done a lot of cleanup! At this point, I'm closing this to have an issue (assigned to @max-eddy) focused on CRSP merging.


Decide how execution and cacheing fit into this

Currently, this CLI just does parsing and building with Sphinx. It doesn't handle any execution or cacheing. This means that currently, empty notebooks will be parsed as empty notebooks, and markdown files with computation in them will not be executed.
A few ways that we could do this:

Use a command like jupyter-book run or that would point to a folder, and run its contents in-line
Something similar that would also cache the contents in a jupyter-cache (at the root of the book folder?)
Improvements to MyST-NB so that it knows how to look for a cache in inserting outputs as it parses the documents

I'm curious if @chrisjsewell thinks that jupyter-cache is ready to be used for these two use-cases above? If so, could you give some pointers for how you imagine this could be used? If I have a moment I can try to start making progress towards this as Chris finishes up the parsing improvements etc.

I'm curious if @chrisjsewell thinks that jupyter-cache is ready to be used for these two use-cases above?

Yeh I think so. From our discussion in ExecutableBookProject/jupyter-cache#16, it seems that people are OK with the general API now, just focussing on 'touch ups' to the CLI.
I'd imagine something like automatically adding all notebooks (+ .md/.myst) files from the _toc.yml (or a separate _exec.yml?) to the staging area (i.e. using the same API calls as 'jcache stage add-many'), then using the API calls from jcache execute in jupyter-book run, then MyST-NB would have the improvements to query the cache.

@chrisjsewell that sounds about right to me - one thing I wasn't able to figure out from playing around with jupyter-cache was how to access the cache. E.g., given a notebook path (relative to cache), how do I tell the cache "give me back the mimebundle for cell X in the notebook"?

get_cache_bundle returns a notebook bundle (notebook + extra data), given a Primary Key in the database (mapped to a hash)
match_cache_notebook/match_cache_file take a notebook, hashes it, and check if the hash is in the database. If so it returns a PK that can be used by the method above.
merge_match_into_notebook / merge_match_into_notebook encapsulates both of the above, but also merges the cached notebook into the source notebook, returning a notebook then that contains both up-to-date text and code cells. This would be the best to use with MyST-NB
There are no methods to return specific cells at present, since you have to load the whole notebook anyway; so its more efficient to use the above method, then get mime-bundles for all cells.


pass stderr in verbose mode from running git commands?

e.g.
diff --git a/versioneer.py b/versioneer.py
index a48dcce97..da5916f23 100644
--- a/versioneer.py
+++ b/versioneer.py
@@ -1196,7 +1196,7 @@ def git_pieces_from_vcs(tag_prefix, root, verbose, runner=run_command):
     runner = functools.partial(runner, env=env)

     _, rc = runner(GITS, ["rev-parse", "--git-dir"], cwd=root,
-                   hide_stderr=True)
+                   hide_stderr=not verbose)
     if rc != 0:
         if verbose:
             print("Directory %s not under git control" % root)

since including the fact that I needed -v for pip install to see this verbose, took awhile to troubleshoot the need to overcome recent git's check for safety:
$ sudo git "rev-parse" "--git-dir"
fatal: unsafe repository ('/home/travis/build/datalad/datalad' is owned by someone else)
To add an exception for this directory, call:

	git config --global --add safe.directory /home/travis/build/datalad/datalad
The command "sudo git "rev-parse" "--git-dir"" exited with 128.

in case of installing via sudo from a local git repo (that is how we test datalad on travis).
More of pains could be shared from https://github.com/datalad/datalad/pull/6913

Seems fine. How do you enable verbose mode? Environment variable?

I guess we'd need to know how pip -v gets passed into setuptools subcommands and how those are exposed where we can get at them in versioneer.

someone could indeed do that digging, or just observe that there is a verbose option for that function, and thus possibly makes sense to make running of the underlying commands "not hiding errors" if in verbose mode ;-)

Ah, right. Sure. Feel free to submit a patch. It seems we activate that with the verbose flag in setup.cfg.


CI experimentation - please do not merge

Test PR to see what Jenkins makes of contribution from someone untrusted.

Can one of the admins verify this patch?


Set Checkstyle Java Launcher to current JDK when CheckstylePlugin is not applied

You can create a Checkstyle task without applying CheckstylePlugin. Due to that and changes in 7.5 we broke some builds, since Java Launcher is not set in this case.
With this fix we now set Checkstyle Java Launcher always to current JDK, in case CheckstylePlugin is not applied.
Fixes #21353.

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle cancel

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle cancel

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test and merge

OK, I've already triggered a build for you.


Add ability to filter HasManyThrough relations

It adds the ability to create filters capable of interactions with HasManyThrough relations.

Thanks!


add resource_resolver and resource_priority_map

:construction: WIP

@danielsdeleo i'm starting down the road of creating Chef.stuff hanging off the Chef class.  Let me know if this is what you were thinking or not.

Yeah, that's exactly what I was thinking. :star2:

Copying discussion from internal chat.
We can reduce the size of the API we make public by only exposing certain actions we want to make available to users and hiding the raw objects. So we could have methods that let users add a new case to the resource resolver or change the default resource or whatever, but not expose the resource priority map (which we can document as "private API"). Then we just need to make sure the Chef.do_a_thing methods work but we're free to change the rest of the implementation.

@danielsdeleo can you give the Chef class another look over?  I think I incorporated that discussion.
@chef/client-engineers @chef/client-core ideally give this a look over for design flaws before I get done writing a bunch of spec tests.

hmmm, actually i just found a design flaw or two, lol....

All the stuff on the Chef class is exactly what I wanted :star: :star2: :stars:  :star: :star2: :stars:  :star: :star2: :stars:  :star: :star2: :stars:  :star: :star2: :stars:  :star: :star2: :stars:  :star: :star2: :stars:  :star: :star2: :stars:

I'm :+1: :+1: :+1: on limiting our public API.  Other than my minor comments, I think this needs some web documentation updates.  The existing blog post for provider resolution still looks good.  But I don't know that anyone knows about the priority map - has that been documented anywhere?  The only thing I can find is this reply.
The code and the idea look great - way to go!

Yeah, the first blog post was Provider Resolver 101, this is more advanced usage.
We're also still figuring things out.  If I'd documented it previously we would have told people to start directly twiddling with the priority_map objects.  That is probably going to be bad at some point in the future because of the code duplication and ideally I'd like to clean up the resource resolver and provider resolver and just have one thing -- but its not quite that simple since they're different in subtle ways (no #supports? on a resource).  So now we've got the Chef class APIs and I feel better about documenting twiddling the APIs.  I also want to do something about all the information we have in the helpers for the service class and hopefully use that to clean up some of the library code that someara has in the httpd cookbook over selecting different service providers.
So yeah, blog post on priority_map is on the radar.  Then cleaning up the service helpers and patching the httpd+mysql cookbooks to use them, then blog posting about using those.  Its all still kinda half built though.

@lamont-granquist Is this code-complete? Could we test this and ship it next week instead of shipping a regression-fix for #3022?

I think the code is ready but it could use a few more tests.

@btm i think this is shippable, there's tests around the chef_class and there's functional-ish tests in the recipe specs which exercises the resource resolver code.

:+1:


website: golang.org/dl says old downloads are available from Google Code

Visit https://golang.org/dl/ and scroll to the bottom. There is the sentence 'Older releases of Go are available at Google Code.' This is no longer true.

Dup of #15284


[FEATURE] daft-connect

[ ] resolve todos
[ ] use workspace deps
[ ] remove panics / better error messages

fmt/etc an hour ago
└─ Andrew Gazelka
   └─ Cargo.toml:305 - # todo: remove this at some point

fix up 2 hours ago
└─ Andrew Gazelka
   └─ src/daft-connect/src/convert.rs:22 - // todo: support more truncate options

update 19 hours ago
└─ Andrew Gazelka
   ├─ src/daft-connect/src/convert.rs:15 - // todo: a way to do something like tracing scopes but with errors?
   ├─ src/daft-connect/src/convert.rs:72 - // todo: test
   ├─ src/daft-connect/src/convert/expr.rs:78 - "/" => Operator::FloorDivide, // todo is this what we want?
   └─ src/daft-plan/src/builder.rs:302 - // todo: should NOT broadcast; should only set first row

stash 5 days ago
└─ Andrew Gazelka
   └─ src/daft-connect/src/lib.rs:262 - operation_id: Some(request.operation_id), // todo: impl properly

stash 6 days ago
└─ Andrew Gazelka
   └─ src/daft-connect/src/config.rs:146 - // todo: need to implement this

stash a week ago
└─ Andrew Gazelka
   ├─ src/daft-connect/proto/spark/connect/commands.proto:266 - // TODO: How do we indicate errors?
   ├─ src/daft-connect/proto/spark/connect/commands.proto:267 - // TODO: Consider adding status, last progress etc here.
   └─ src/daft-connect/proto/spark/connect/commands.proto:313 - // TODO: Consider reusing Explain from AnalyzePlanRequest message.

We should add a README to the spark-connect crate stating that it's prost generated rust structs from the spark connect protobufs.

@andrewgazelka just a suggestion, but since the conversion logic from spark to daft is soo similar to what we've done in daft-sql with the conversion between sql and daft, I think it'd make a lot of sense to structure the code similarly. It'd reduce a lot of cognitive overhead for developers if they follow the same general patterns and code structure.

OK, I will look over your code and if I have over a certain number of questions, I’m thinking it could be good to pair program to figure out what makes the most sense but I’m all for making things easier for contributors


interal.Window name field is missing

Hi! Still using your libraries with much pleasure! Right now i am trying to port https://github.com/ocornut/imgui/issues/5484#issuecomment-1189989347 to python code. I am running into the problem that the name field of a window is not provided by imgui_bundle's imgui. There is name_buf_len, but not name.
I'd like to be able to do imgui.get_current_context().current_window.name. Could you look into wrapping this?
Thanks as always!

Hello Diederick,
I do not have time to work on this right now, but you could try this:
add
include  at the top
+
pyClassImGuiWindow.def_readonly("name", &[](const ImGuiWindow& w) { return std::string(ImGuiWindow::Name) });
below the autogenerated code inside external/imgui/bindings/pybind_imgui_internal.cpp
Can you tell me if it is sufficient?

Hi Pascal,
No worries. I no longer have a setup where i can easily compile my own imgui_bundle, so can't test that for you. I have a workaround for my use case as the code doesn't need to be general (I know the parent name). So lets leave this open so its not forgotten to be done at some point?
Thanks!
Dee

Cool, thanks!
I don't know if i've set it yet, but, merry christmas andhappy holidays!

This works, thanks!


Dotted line

I haven't found any info about dotted lines graph (basically line + scatterplot combined). Is that currently possible?

Do you have an example of this?

Ah, I was thinking you could do dashed lines but it doesn't appear to be possible


using mapbox map tiles

Frontend and Release Workflow Started here

https://user-images.githubusercontent.com/35755741/218949985-80f90a60-4dfd-4c86-a20b-e1f9a489308a.mov
couple of bugs can be seen above^^ but style switcher seems very nice.
(note, the bugs are not specific to this implementation, maplibre-gl is port of mapbox) * also quite laggy while focused when zooming compared to google maps (this is an open ticket).

https://user-images.githubusercontent.com/35755741/219228498-6cf23335-624a-4c09-b162-b09ebac56aa0.mov
cool colours + bug fix where points get cut off since paused.


Add a node whitelist filter

This PR adds support for a new scheduling filter that selects candidates based on a provided list of nodes, effectively implementing a "whitelist". This is meant to cover use cases where setting engine labels may not be practical.
The usage is currently implemented as -e whitelist:node==node-1-name|node-2-name|node-3-name, and I am definitely open to suggestions for a better UX.
A similar approach that is available today is to use a series of constraint:name!=<name> constraints to implement a "blacklist" of nodes. However, that method is not equivalent to a whitelist filter during rescheduling.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "whitelist-filter" git@github.com:alexmavr/swarm.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@alexmavr can you please rebase this PR, it would be nice to have it on top of #2492.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "whitelist-filter" git@github.com:alexmavr/swarm.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

The whitelist functionality is definitely new and something that isn't supported in Swarm right now. One concern I have about it is that it puts more responsibility on the user, to make sure that (other) hard constraint requirements aren't accidentally overridden by the whitelist filter. Essentially, it comes with a warning to use at your own risk.
cc @dongluochen

@alexmavr in addition, do you mind rebasing one more time? Several tests were fixed recently.

Rebased and addressed line comment (moved whitelist filter last).
I still don't understand why you say this is a different case for a filter, the use case is to have all types of filters apply, but ignore any candidate nodes that are not part of the whitelisted nodes.

Once we merge this change, please update Swarm doc to reflect the change.

LGTM
Tests failure looks unrelated. Should investigate separately.

ping @nishanttotla @allencloud.

Restarted the CI to run tests one more time.
Code LGTM.

LGTM
@alexmavr please submit a PR to update docs.
@mstanleyjones


Added D5 to submitted folder

Aiden Hebert (22%) - Worked on sections 1 and 6 for D5.
Cathy Ly (26%) - Worked on sections 1, 2, 5, and 6 for D5.
Devin Jay (26%) - Worked on sections 1, 4, 5, and 6 for D5.
Faith Ononye (26%) - Worked on sections 1, 3, and 6 for D5.


RetryErrors obscure actual errors - PubSub API

Similar to #3083, #3900
2017-08-31T11:27:05.702393618Z   File "main.py", line 274, in start
2017-08-31T11:27:05.702404302Z     self.add_topic(topic, params)
2017-08-31T11:27:05.702413945Z   File "main.py", line 292, in add_topic
2017-08-31T11:27:05.702472288Z     self, self.robot_id, self.pubsub_client, self.network, topic, params)
2017-08-31T11:27:05.702501499Z   File "main.py", line 128, in __init__
2017-08-31T11:27:05.702572732Z     if not self.topic.exists():
2017-08-31T11:27:05.702583408Z   File "/usr/local/lib/python2.7/dist-packages/google/cloud/pubsub/topic.py", line 200, in exists
2017-08-31T11:27:05.702634134Z     api.topic_get(topic_path=self.full_name)
2017-08-31T11:27:05.702713982Z   File "/usr/local/lib/python2.7/dist-packages/google/cloud/pubsub/_gax.py", line 132, in topic_get
2017-08-31T11:27:05.702723634Z     topic_pb = self._gax_api.get_topic(topic_path)
2017-08-31T11:27:05.702729859Z   File "/usr/local/lib/python2.7/dist-packages/google/cloud/gapic/pubsub/v1/publisher_client.py", line 341, in get_topic
2017-08-31T11:27:05.702735747Z     return self._get_topic(request, options)
2017-08-31T11:27:05.702754679Z   File "/usr/local/lib/python2.7/dist-packages/google/gax/api_callable.py", line 428, in inner
2017-08-31T11:27:05.702802263Z     return api_caller(api_call, this_settings, request)
2017-08-31T11:27:05.70281738Z   File "/usr/local/lib/python2.7/dist-packages/google/gax/api_callable.py", line 416, in base_caller
2017-08-31T11:27:05.702884253Z     return api_call(*args)
2017-08-31T11:27:05.702898662Z   File "/usr/local/lib/python2.7/dist-packages/google/gax/api_callable.py", line 376, in inner
2017-08-31T11:27:05.703026405Z     return a_func(*args, **kwargs)
2017-08-31T11:27:05.703084222Z   File "/usr/local/lib/python2.7/dist-packages/google/gax/retry.py", line 127, in inner
2017-08-31T11:27:05.703115599Z     ' classified as transient', exception)
2017-08-31T11:27:05.703271957Z google.gax.errors.RetryError: GaxError(Exception occurred in retry method that was not classified as transient, caused by <_Rendezvous of RPC that terminated with (StatusCode.UNIMPLEMENTED, unknown service google.pubsub.v1.Publisher)>)

@jonparrott Dropping your name on this since your fixes to google.api.core will fix it.

I hit the same problem with the Cloud Spanner API.
Specifically I was getting an INVALID_ARGUMENT trying to create an instance but no useful information about what was invalid. I ran the same command using gcloud and got a very helpful error message.
ERROR: (gcloud.spanner.instances.create) INVALID_ARGUMENT: Invalid CreateInstance request.
- '@type': type.googleapis.com/google.rpc.BadRequest
  fieldViolations:
  - description: 'Display name must be between 4-30 characters long. Got: Spanner
      instance used by jlewi@ for TensorBoard.'
    field: instance.display_name

I'm guessing the problem is in the gRPC layer and so all APIs will be affected. Would it make sense to change the title of the issue?

The new exception handling code will only raise a RetryError if retires are exhausted, otherwise, it will raise the real error.
Basically, this won't be an issue once we get gapic to use the new error code.

For near-future historians, this is how this programmer did meaningful error handling:
from google.gax.errors import RetryError
from grpc import StatusCode

try:
  leap_without_looking()
except RetryError as exc:
    if exc.cause.code() is not StatusCode.ALREADY_EXISTS:
        raise


bugsnag.ts in npm package

By some reason npm package v 6.4.2 has extra empty .ts file in @bugsnag\browser\dist\types\bugsnag.ts which causes error on build Angular app:
ERROR in<EMAIL_ADDRESS>Module build failed (from ./node_modules/@ngtools/webpack/src/index.js):
Error<EMAIL_ADDRESS>is missing from the TypeScript compilation. Please make sure it is in your tsconfig via the 'files' or 'include' property.
The missing file seems to be part of a third party library. TS files in published libraries are often a sign of a badly packaged library. Please open an issue in the library repository to alert its author and ask them to package the library using the Angular Package Format (https://goo.gl/jB3GVv).

This reason this file was added is discussed in https://github.com/bugsnag/bugsnag-js/issues/523.
Maybe Angular's AOT mode is fixed now and we can remove it…

I'm building it in pretty silly way, just ng build --eval-source-map --prod. With ng build --eval-source-map --prod --aot I'm getting exactly the same error. Angular version is "@angular/core": "~7.2.0"

Hi @GDreyV
Thanks for the PR! Our team will review it and follow up with any comments there.

Fixed in v6.4.3


phonegap-plugin-push + cordova-plugin-googleplus = cordova-plugin-googleplus not working on android

Expected Behaviour
When clicking to login with Google a dialog opens to login.
Actual Behaviour
When clicking to login with Google no dialog opens to login.
Reproduce Scenario (including but not limited to)
Using phonegap build, and these plugs in my config.xml:
cordova-plugin-googleplus
cordova-android-firebase-gradle-release
phonegap-plugin-push
If I remove phonegap-plugin-push cordova-plugin-googleplus works fine.
Platform and Version (eg. Android 5.0 or iOS 9.2.1)
Android 5.0
(Android) What device vendor (e.g. Samsung, HTC, Sony...)
All
Cordova CLI version and cordova platform version
cordova --version  6.0.0
cordova platform version android  4.1.1

Plugin version
phonegap-plugin-push 2.0.0

try using FCM_VERSION that compatible with cordova-plugin-googleplus plugin when installing phonegap-plugin-push
my plugin version:
<EMAIL_ADDRESS><EMAIL_ADDRESS>
when installing push plugin:
cordova plugin add phonegap-plugin-push --variable FCM_VERSION=11.8.0

the FCM version installed depends on your googleplus version

Thanks! This worked!

Weirdly<EMAIL_ADDRESS>does not return the registrationId now:
     app.push.on('registration', function(data) {         });
Reverting back to 2.0.0 does work, but the problem above remains - any ideas why 2.2.3 wouldn't be working?
Thanks!


Create Indy FileEvent publisher

I understand this is to collect all file event and put them to ISPN caches. Just not sure how do we use that. does AQ get notified when a new entry added, and do something accordingly?

I understand this is to collect all file event and put them to ISPN caches. Just not sure how do we use that. does AQ get notified when a new entry added, and do something accordingly?

Currently we use the replicated cache, once the indy put the events to ISPN caches, that will be replicated into the caches AQ used to query.

Some comments in the code.
And one question is where will we use this ISPNEventPublisher in the future?

Currently it's used in the EventAuditListener.

retest please

retest this please


Build vmdk images as streamOptimized

IMO https://github.com/osbuild/osbuild-composer/issues/938 should have been opened here.

#469 implements this but I've never finished it.

This would have been very nice to have.

ping. Any updates here ? Can we get this issue on the map for the next osbuild version ?

This should now be much easier to implement due to version 2 of the manifest format. This would easily allow a dedicated stage just for configuring qcow-img correctly, which would be easy to test and can be extended with all the possible qemu options (including stream optimized).

Done via #1000


What to expect from the CP-SAT Primer book?

Prelude
Here's my understanding of the CP-SAT Primer book.
The CPSAT-Primer book is an introduction to Google OR-Tools' CP-SAT solver. The book covers the whole of CP-SAT's modeling interface (chapter 2-5) and basics related to solving such as parameters and logging (chapter 6-7). There are many examples that showcase how to use CP-SAT to solve combinatorial optimization problems (primarily knapsack and TSP). The details of how CP-SAT works are briefly discussed in chapter 10, and as you humbly acknowledge, the linked resources do a great job at explaining the inner workings of CP-SAT. Since CP-SAT is a solver portfolio of many sophisticated techniques, it only makes sense that this is not explained in detail in CP-SAT Primer. Furthermore, the book is also a collection of meta-skills related to solving optimization problems: coding patterns (chapter 8), developing an optimization API (chapter 9), benchmarking (chapter 12), etc. I am a big fan of this book, because I personally have been going through all these steps myself and I would have benefited a lot from a book like this early in my PhD.
Discussion point
My main discussion point is: what is the CP-SAT Primer book exactly, and what is its intended audience? It can be a bit confusing for readers what to expect from this book because, from what I perceived, it is an introduction of CP-SAT and related topics that you have encountered in your work as well. Because that is not explicitly mentioned anywhere and the sections are interwoven, I got quite confused about this, and I also recognize that this is an "organic growth" process that the book is going through.
Suggestions
I have the following two suggestions to improve clarity regarding "what to expect."
Restructure the sections
I think it would be helpful to make a more clear distinction between the sections related to CP-SAT and other topics.
Based on the title and introduction, I would expect mostly topics on CP-SAT.
Part 1: Introduction to CP-SAT

Installation: Quick installation guide.
Example: A short example, showing the usage of CP-SAT.
Basic Modeling: An overview of variables, objectives, and constraints.
Advanced Modeling: More complex constraints, such as circuit constraints and intervals.
Parameters: How to specify CP-SATs behavior, if needed. Timelimits, hints, assumptions, parallelization, ...
Understanding the Log: How to interpret the log
How does it work?: After we know what we can do with CP-SAT, we look into how CP-SAT will do all these things.
Alternatives: An overview of the different optimization techniques and tools available. Putting CP-SAT into context.
Large Neighborhood Search: The use of CP-SAT to create more powerful heuristics.

Part 2: Software skills for optimization (or something else
9. Coding Patterns: Basic design patterns for creating maintainable algorithms.
7. (DRAFT) Building an Optimization API How to build a scalable API for long running optimization jobs.
10. Benchmarking your Model: How to benchmark your model and how to interpret the results.
Part 2 is much more advanced and not really relevant immediately for those who just want to get an introduction to CP-SAT.
The topics are, however, extremely relevant, but it having this structure allows readers to much easier cherry-pick what they want to read.
Restructure "Introduction"
The current intro is structured like this:

Introduction paragraph
1 sentence on what is this primer about
Lots of background recommended readings
Intended target audience
Table of content

I think this kind of structure is clearer:

Introduction paragraph
Much longer paragraph on what is this book about

In part 1, CP-SAT modeling, solving, examples, etc.
In part 2, metaskills related to more general modeling -- can be skipped but extremely useful

Inteded target audience

Students from your course
Readers interested in CP-SAT
Readers interested in more advanced skills related to optimization

Table of content
Background

Opinion not to be taken harsh: you provide a lot of helpful recommendations but they sometimes distract from the main text to "get to the point." The introduction has a similar build-up and I'll point it out in other chapters once I get to creating the issues related to those chapters.
(PS: In the coming days, I will make separate issues for other, overarching discussion points. For collections of improvements related to a single chapter I will also make individual issues.)

You are making a good point and this is something I have actually been thinking about, too, the last two weeks. This has already been reflected by the fact that I removed "Cheat Sheet" from the title.
The primer actually started as a cheat sheet of maybe 4 pages for my students to help them with their exercises. It then grew to become a "primer", and now it is has grown even more. New sections were usually added whenever I needed to show my students how to do a certain thing and then I just added it to the primer, too, so I can easily reuse it. However, there have been to many additions without caring about the overall structure and this needs to change to make it accessible again.
I love your idea with Part 1 and Part 2, and the other points seem to be good, too. I try to make an action plan, soon. Unfortunately, my vacation days are over and I have to somehow squeeze it in between my other responsibilities, but I am eager to finally fix the structure of the primer.

Maybe, I would consider LNS an advanced technique and also move it to Part 2 :thinking:
@leonlan Did you have a concrete reason to leave it in Part 1 or was this just gut feeling?

Maybe, I would consider LNS an advanced technique and also move it to Part 2 🤔 @leonlan Did you have a concrete reason to leave it in Part 1 or was this just gut feeling?

Just a gut feeling :-) Moving it outside of part 1 makes sense as well.

Did some experimenting with the structure in the lunch-break, and this structure actually feels much cleaner. However, would still have to change the introduction to accommodate it, which is obviously not something I can do in a break.

Couldn't let it rest and started revising the intro. There is now an extensive content section directly after the introduction paragraph, hopefully giving the reader a much better overview of what to expect.


What is the unit of depth in the published dataset?

I found there is no explanation in readme file about the pre-released depth data

The unit corresponds to the unit of the underlying blender scenes, which is intended to be meters.


agave: 009 -> v10

Motivation for this change
https://github.com/agarick/agave/releases/tag/v10
Powerline glyphs and other goodness!
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

:heart: thanks!


[feat] Automate draft release

As an internal data manager for MC2 Center, I would like to automate the following step(s) of the curation workflow:

draft a release whenever a PR is pushed to the data model

3/5/2024 update
A release for a data model needs to happen before new manifests can be validated and uploaded to Synapse.  Therefore, we can not have a workflow that will automate the release draft and portal sync.
For now, the workflow should only focus on creating the release draft, then run the portal sync workflow manually once manifests are ready.

After a data model release, there is a step of filing a PR with FAIR to update our release tag in the DCA config. This workflow will create the draft of the release. Pushing the actual release will still happen on demand.


Always selecting git tag version when WARNING: Latest git tag doesn't match package.json#version

Greetings,
I'm finding it very hard to change the version to a specific one, when I've changed the package.json version, I get the error:
WARNING Latest Git tag (1.0.52-alpha.15) doesn't match package.json#version (1.0.55).
√ Init (release 1.0.52-alpha.16 for <package>)

This happens even if I attempt to run release-it --preRelease=alpha --no-github-release --no-src.tag -n 1.0.55 --force
What would the process be to set a specific version?

That warning is not an error (as the release-it process continues).
The argument order seems to be the issue here, it should be release-it <increment> [options], i.e. release-it 1.0.55 --preRelease=alpha ....
Does that help?

I'm finding it very hard to change the version to a specific one, when I've changed the package.json version

A few more remarks:

No need to manually do this, release-it should bump the version in package.json.
The --no-github-release should be --no-github.release.
The --force argument has been removed in v8.

Closing this issue as I feel it's answered properly.


Issues when running codes. ImportError: mmdetection/mmdet/ops/utils/compiling_info.cpython-36m-x86_64-linux-gnu.so: file too short

Hi,
I run the example codes as below and met a bug.
Could you please help me to tackle it?  Does it happended because I use python3.6 instead of python3.7?
Thanks.
/-----code------------------------------------
python tools/test.py configs/mask_rcnn_r50_fpn_1x.py
checkpoints/mask_rcnn_r50_fpn_1x_20181010-069fa190.pth
--out results.pkl --eval bbox segm
/-----------------------------------------
/-----------------bug log-----------------------
Traceback (most recent call last):
File "tools/test.py", line 9, in
from tools.fuse_conv_bn import fuse_module
File "/home/bomiao/Documents/Projects/mmdetection/tools/fuse_conv_bn.py", line 7, in
from mmdet.apis import init_detector
File "/home/bomiao/Documents/Projects/mmdetection/mmdet/apis/init.py", line 1, in
from .inference import (async_inference_detector, inference_detector,
File "/home/bomiao/Documents/Projects/mmdetection/mmdet/apis/inference.py", line 9, in
from mmdet.core import get_classes
File "/home/bomiao/Documents/Projects/mmdetection/mmdet/core/init.py", line 5, in
from .mask import *  # noqa: F401, F403
File "/home/bomiao/Documents/Projects/mmdetection/mmdet/core/mask/init.py", line 2, in
from .structures import BitmapMasks, PolygonMasks
File "/home/bomiao/Documents/Projects/mmdetection/mmdet/core/mask/structures.py", line 8, in
from mmdet.ops.roi_align import roi_align
File "/home/bomiao/Documents/Projects/mmdetection/mmdet/ops/init.py", line 15, in
from .utils import get_compiler_version, get_compiling_cuda_version
File "/home/bomiao/Documents/Projects/mmdetection/mmdet/ops/utils/init.py", line 2, in
from .compiling_info import get_compiler_version, get_compiling_cuda_version
ImportError: /home/bomiao/Documents/Projects/mmdetection/mmdet/ops/utils/compiling_info.cpython-36m-x86_64-linux-gnu.so: file too short
/---------------------------------------------------------

There probably be an error copying/extracting the libraries
You can first try to remove your builds and *.so files in mmdet/ops// and then re-build the repo.


Rejection in async listener results in Node process crash

According to the documentation, one of the features of EventEmitter2 is that it supports async listeners. The documentation does not mention that listeners should never reject.
Rejections in listeners result in Node process crash. For example:
const EventEmitter2 = require('eventemitter2');

const rejects = () =>
  new Promise((resolve, reject) => {
    console.log('event listener called');
    reject('from async');
  });

const emitter = new EventEmitter2();

emitter.on('x', rejects, {
  promisify: true,
  async: true,
});
const emitted = emitter.emit('x');
console.log({ emitted });
setTimeout(() => console.log('success!'), 100);

produces the following output:
{ emitted: true }
event listener called
[UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "async error".] {
  code: 'ERR_UNHANDLED_REJECTION'
}

Replacing reject('from async') with resolve('from async') results in
{ emitted: true }
event listener called
success!

Changing promisify and async listener options does not seem to affect this.
It seems that EventEmitter2 does not handle any promise rejections (at least I cannot find any mentions of catch in the source code). Since the value returned by emit is simply true, it seems that there is no way for caller of emit to handle any rejections either.
So the only way to not crash Node process is to handle all rejections in the listener, and to use EventEmitter2, for example, like this:
const handleEvent = async (eventData) => {
  // do some async stuff, I/O, network calls, etc
}

const handleEventSafe = (eventData) => handleEvent(eventData).catch(e => console.error(e));

eventEmitter.on('myEvent', handleEventSafe);

This is a very significant caveat, and it should probably be mentioned in the documentation that async listeners should never ever throw or reject.
(This is not an issue with sync listeners, because errors thrown by sync listeners can be caught by caller of emit as ordinary sync errors.)

This is probably a duplicate of #298, I didn't notice it at first because I was searching by "reject" keyword.


🐛 The Android extensions ('kotlin-android-extensions') compiler plugin is no longer supported.

What were you trying to do?
Build an expo app.
I'm not exactly privvy to app development, here are some dependencies and their versions:
"dependencies": {
    "detox": "20.5.0",
    "expo": "~47.0.12",
    "react-native": "0.70.5",
    "react-native-vision-camera": "2.15.4",
  }

Kotlin version 1.8.0
Gradle version 8.0 (I think)
I'm using detox to build the app, not sure if this matters.
Reproduceable Code
-

What happened instead?
λ> detox build --configuration android.emu.release

cd android && ./gradlew assembleRelease assembleAndroidTest -DtestBuildType=release

> Task :react-native-vision-camera:compileReleaseKotlin FAILED
e: The Android extensions ('kotlin-android-extensions') compiler plugin is no longer supported. Please use kotlin parcelize and view binding. More information: https://goo.gle/kotlin-android-extensions-deprecation

Relevant log output
No response
Device
Ubuntu 22.04
VisionCamera Version
2.15.4
Additional information

[X] I am using Expo
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar issues in this repository and found none.

Solution: remove the line apply plugin: 'kotlin-android-extensions' from react-native-vision-camera's build.gradle file.

We should probably open a PR to fix this. As of now, the only reference to the error is this closed issue, not the easiest to find.

Solution: remove the line apply plugin: 'kotlin-android-extensions' from react-native-vision-camera's build.gradle file.

Thank you! This helped after upgrading Kotlin to 1.8.0 from 1.6.0.


Flickering of the lights and band 1 is linked to band 0

band 1 seems to be linked to band 0 and they constantly flicker at times

I have experienced both these issues and have resolved the flickering issue and that fix will be in the next update.
The bands linking issue is one that's still being worked on at the moment, sorry for the trouble!


Chrome, Firefox and WebKit  Platform/Feature Status?

It's not setup as a phrased question, but these are very useful resources in the same line as caniuse — although pertain more to the feature roadmaps of the browser engines and their progress.
https://chromestatus.com/
https://platform-status.mozilla.org/
https://webkit.org/status/

Also, Microsoft platform status (https://developer.microsoft.com/en-us/microsoft-edge/platform/status).

I had left that out intentionally at first, since I know that Microsoft Edge is still moving over to a Chromium code-base. But looking at list in detail again, it seems fine and usable. 👍


strange "chargedEnergy" glitch

Describe the bug
Noticed the "EV charged energy" jumped to the same value as "Total energy charged"
This happened when :

EV-1:  EVSE charging session was finished, Charged Energy was reading = 7.5kWh
disconnecting the EVSE charging plug from EV-1 and connecting it to EV-2

instead of resetting Charged Energy to "0 kWh", Charged Energy jumped to the value of "Total Energy Charged"
for some reason, during the same charging session of EV-2, "Charged Energy" reset to zero after +- 3h into the session.
directly afterwards, it jumped back to following "Total Energy Charged"

This morning on reconnecting EV-1 to the charger,
"EV charged energy" reset to zero as expected, and is report correctly the session energy like it should
Upload your config
raw.json
Upload a debug log
N/A
To Reproduce
N/A
Expected behavior
A clear and concise description of what you expected to happen; expected Charging Current?
Screenshots

At what frequency are you feeding your EVMeter APIs?

the interval is 3 seconds.
it is the first time I noticed this over the 4 weeks of using it

I suspect it is a glitch that is there immediately going from state B to state C; if that is the problem, this version should solve it:
592ab0824e.zip
...please test!

okay, will do, thanks!
this is my MQTT payload for the EV meter: 144:0:0:3286:339536.0
I noticed I send total energy in float and not int, possibly related?

Well that value is read by a sscanf:
int n = sscanf(payload.c_str(), "%d:%d:%d:%d:%d", &L1, &L2, &L3, &W, &WH);
and it is read as a decimal unsigned integer; it  obviously accepts your values (n=5 is tested) so I don't think that is a problem...

I suspect it is a glitch that is there immediately going from state B to state C; if that is the problem, this version should solve it: 592ab0824e.zip ...please test!

quick feedback:
EV was charging, I did the update during charging, so obviously EVSE rebooted afterwards,
EV resumed charging and EnergyCharged again followed TotalEnergyCharged.
stopped EV charging session, rebooted EVSE from webpage, after reboot EnergyCharged again working as expected, from 0.

will close this issue as solved, as I'm not able to reproduce the behaviour in this version
https://github.com/dingo35/SmartEVSE-3.5/files/15107389/592ab0824e.zip


Client Allocation Request for: WillTechMusing

Client Allocation Questions
Core Information

Name: WillTechMusing
Website / Social Media: https://ctzero.com/
Region: North America
DataCap Requested: 5TiB
Addresses to be Notarized: f17du2ulfhtpwgs4rwd4ngnrblueatjv4c5n57umy
Notary Requested: andrewxhill

Hi,
I saw you asked similar questions for other request so I am going ahead to provide you additional background:

yourself/ your organization (with links to official website/social media/news mentions etc)

This is a new startup web site to capture Innovation training videos and materials to help professional and corporate executives learn about ways and approach to make their organization more innovative. https://ctzero.com/

Your history working on IPFS/Filecoin (notable contributions to the community, type of engagement shown over time etc)

I am currently a miner but came from Technology Management and Consulting background. Would like to take the opportunity to introduce IPFS/Filecoin into the education/training industry.

Use case: type/source/quantity/diversity/scarcity of the data you plan to store on Filecoin

The training materials will come from partners (professors, successful corporate executives, advisors, etc) in the Innovation space. These materials will be developed and authorized by the partners. This data will be granted as public materials and make free to everyone on the topic of Innovation.
The quantity of the data are documents, sound tracks, videos from these authors about Innovation for education. Each author might provide GBs of data, so in 6-12 months would be 5TB+.

Miners you intend to allocate DataCap with allocation proportion(with redundancy/location/specific requirement of storage miners)

Initially for North America market and Asia market so prefer miners in these geo locations.

What's your next plan for the data you plan to store in Filecoin Network? For-profit or not?

The data part are available for public and free.

Would you be OK in posting deal transactions here?

Yes its OK.

Hey, thanks for that, the questions I ask are a bit different but have some overlap

Can you introduce yourself? Where can I find you online? Examples include Github, Twitter, LinkedIn, WeChat, etc., and more than one is encouraged.
If you represent an organization, what is the name, nature, registration country, time since inception, and named officers of your organization?
In which region(s) do you intend to use the DataCap?
What is your use case for the DataCap being requested?
How many miners do you plan on allocating the DataCap? Please specify if you have a specific miner(s) you would like to allocate the DataCap.
Do you agree on providing transparency of DataCap allocation decisions & execution details in public to prevent excessive/unfair self-dealing? If so, how will you plan to report it?
Will your organization be responsible for allocating the full DataCap? Examples where this might not be the case, include app builders where the application end-users may have access to storage backed by the DataCap. Please read our full proposal for details on this approach. Unfortunately, our proposed multisig enabled DataCap provider is not ready today, but when it is, we will provider further documentation.

Feel free to shuffle around your original response and extend for these questions. I'd like to capture your responses in context since they may be used to evaluate future applications.
Out of curiosity, the data that you are proposing to upload here, is that data you already have access to or is it something that you are planning to gather after having the datacap? It also sounds like it might have restrictive licensing?

thank you @andrewxhill.

Can you introduce yourself? Where can I find you online? Examples include Github, Twitter, LinkedIn, WeChat, etc., and more than one is encouraged.

my slack alias @WillTechMusing, Github account: https://github.com/William8Work,

If you represent an organization, what is the name, nature, registration country, time since inception, and named officers of your organization?

This is a new startup web site to share Innovation training videos and materials to help professional and corporate executives learn about ways and approach to make their organization more innovative. https://ctzero.com/.
This is intended for non-profit and has not yet registered as formal corporation.

In which region(s) do you intend to use the DataCap?

Mostly North America, and maybe some in Asia or Europe.

What is your use case for the DataCap being requested?

The training materials will come from partners (professors, successful corporate executives, advisors, etc) in the Innovation space. These materials will be developed and authorized by these partners. This data will be granted permission as public materials and make free to everyone on the topic of Innovation.
The quantity of the data are documents, sound tracks, videos from these authors about Innovation for education. Each author might provide GBs of data, so in 6-12 months would be 5TB+.

How many miners do you plan on allocating the DataCap? Please specify if you have a specific miner(s) you would like to allocate the DataCap.

I know a list of miners from MinerX program so they could be a good group to start with.

Do you agree on providing transparency of DataCap allocation decisions & execution details in public to prevent excessive/unfair self-dealing? If so, how will you plan to report it?

yes I agree. One way is to provide a monthly report on the list of miners with the deals and sizes as auditing. This can be shared with whoever might be interested in it.

Will your organization be responsible for allocating the full DataCap? Examples where this might not be the case, include app builders where the application end-users may have access to storage backed by the DataCap. Please read our full proposal for details on this approach. Unfortunately, our proposed multisig enabled DataCap provider is not ready today, but when it is, we will provider further documentation.

yes the datacap will be used to stored the materials (documents, audio and videos). And the decision will be made by this organization.

Out of curiosity, the data that you are proposing to upload here, is that data you already have access to or is it something that you are planning to gather after having the datacap? It also sounds like it might have restrictive licensing?

I have access to some data already (less than 1TiB). Additional data will be gathered through showing cases the capabilities of the web site and need some marketing and partnerships. Because these data are authentic from the authors, there will be agreement from them to authorize the website to share these materials to the public.

Based on those parameters, I can provide a maximum of 100GiB of datacap this time around. What I recommend if you need the full 5TiB is to use the 100Gib and generate an open record of use that will benefit a follow-up application. Let me know if the 100GiB will be useful to you, and we can finalize it.

This is great. Yes I can definitely start with 100GiB and will generate an
open record of use per your suggestion.
Thank you Andrew and this is exciting!
On Thu, Apr 15, 2021 at 2:44 PM Andrew W. Hill @.***>
wrote:

Based on those parameters, I can provide a maximum of 100GiB of datacap
this time around. What I recommend if you need the full 5TiB is to use the
100Gib and generate an open record of use that will benefit a follow-up
application. Let me know if the 100GiB will be useful to you, and we can
finalize it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/filecoin-project/filecoin-plus-client-onboarding/issues/368#issuecomment-820749560,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA2QOBMQIFI5H7EAD4WNNN3TI5M2HANCNFSM42ZW6TJA
.

hey @William8Work
we made an annoying mistake. in the step to verify that your address was able to accept the DataCap we used https://verify.glif.io. however, in submitting the check we submitted your address in the wrong field (the one that grants automated datacap)! now you have 32GiB Datacap at f17du2ulfhtpwgs4rwd4ngnrblueatjv4c5n57umy  instead.
so, two options. go ahead and use the 32GiB with that address. or, submit a different address now and we can give you the proper 100GiB limit.
let me know.

no problem. here is another
address: f1qb2ecyejmvwuietfiht7leshmy4w2desaslz4da
On Fri, Apr 16, 2021 at 11:33 AM Andrew W. Hill @.***>
wrote:

hey @William8Work https://github.com/William8Work
we made an annoying mistake. in the step to verify that your address was
able to accept the DataCap we used https://verify.glif.io. however, in
submitting the check we submitted your address in the wrong field (the one
that grants automated datacap)! now you have 32GiB Datacap at f17du2ulfhtpwgs4rwd4ngnrblueatjv4c5n57umy
instead.
so, two options. go ahead and use the 32GiB with that address. or, submit
a different address now and we can give you the proper 100GiB limit.
let me know.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/filecoin-project/filecoin-plus-client-onboarding/issues/368#issuecomment-821432664,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA2QOBNKSW6ZFT4TJKYNI7DTJB7I7ANCNFSM42ZW6TJA
.

you are gtg https://filfox.info/en/message/bafy2bzaceaicl5gkqcybj5fd54ximuufuc376fvnkoprhhoytd6lgngodrk7q
you can check it on verify.glif.io


Exordium and memoryleakfix issues with quilt (Internal Error)

Do you have a crash log?

crash-2023-06-21_<IP_ADDRESS>91-quilt_loader.txt

happens on both 1.19.4 and 1.20.1

here's the crash logs
crash-2023-06-21_<IP_ADDRESS>91-quilt_loader.txt
https://pastebin.com/GqfCDgN6

https://github.com/LlamaLad7/MixinExtras/issues/33
https://github.com/QuiltMC/quilt-loader/issues/315


Get the bitrate of videos

Is it possible to get the bitrates of the individual youtube videos with youtube-dl

Sometimes. formats fields of JSON output (--dump-json or --write-info-json) contains the list of format dictionaries, each may contain:
tbr for average bitrate of audio and video in KBit/s
abr for average audio bitrate in KBit/s
vbr for average video bitrate in KBit/s


[SPARK-48169][SQL] Use lazy BadRecordException cause in all parsers and remove the old constructor, which was meant for the migration

What changes were proposed in this pull request?
Use factory function for the exception cause in BadRecordException to avoid constructing heavy exceptions in the underlying parser. Now they are constructed on-demand in FailureSafeParser. A follow-up for https://github.com/apache/spark/pull/46400
Why are the changes needed?

Speed-up JacksonParser and StaxXmlParser, since they throw user-facing exceptions to FailureSafeParser
Refactoring - leave only one constructor in BadRecordException

Does this PR introduce any user-facing change?
No
How was this patch tested?

testOnly org.apache.spark.sql.catalyst.json.JacksonParserSuite
testOnly org.apache.spark.sql.catalyst.csv.UnivocityParserSuite

Was this patch authored or co-authored using generative AI tooling?
No

Merged to master for Apache Spark 4.0.0-preview.


GitHub Action rules for PRs to add workflow for Community Contributions

@xiangyan99 asked if we could add GitHub Action automation for PRs that work similar to how our GitHub Action for customer issues work. Specifically, auto comments/reminders when a PR has "needs-author-feedback".
We'd be looking at the following rules:

if a "customer-reported" PR has "needs-author-feedback" label added:

We add comment mentioning the author and ask for a response

if a "customer-reported" PR has "needs-author-feedback" and not updated more than 15 days

We add "no-recent-activity" label
We add another comment mentioning the PR author asking for a response and letting them know if they don't response within a certain time limit, the PR will be closed.

if a "customer-reported" PR has "needs-author-feedback" and "no-recent-activity" label and not updated more than 30 days

We comment on the PR mentioning the PR author letting them know we are closing the PR because they have not responded to our team's questions or change requests.
We close the PR

@ronniegeraghty and @xiangyan99
CC: @jsquire
PR rules, outside of the Pull Request Triage rule adding the "customer-reported" label when the PR is created by someone with permissions (either they're not in Azure or don't have write permissons). There are no PR rules that care about this label or manipulate it in the way that Issues rules do. Also, PRs do not add/remove or do any processing on the "needs-author-feedback" label, again that's Issue processing.
Here's the path PRs go to get closed.

PRs are identified as stale in the Identify stale pull requests rule. This is based upon time the PR being open, with no activity for more than 60 days and the PR not having the "no-recent-activity" label. If these are true, we add the "no-recent-activity" and a comment saying we'll close this out in 7 days.
PRs are closed by the Close stale pull requests rule. If the PR has the "no-recent-activity" and there's been no activity for 7 days, we close it and add a comment saying they can reopen it.

This additional ask is completely unnecessary. We don't need multiple paths to close a stale PR.

I'm not a fan of this one for several reasons:

We have a rule that deals with stale PRs and closes them out.  Why do we need a second one with more overhead for our team to manage?

Why would we treat community contributions differently than partners and internal teams?

This is being more aggressive about closing out community contributions.  Why are we trying to punish community members who kindly volunteer their free time to help us out?  There's no cost or damage to letting a community PR sit and wait for the normal stale rules to flag it.  If anything, we want to be generous and gentle here.

Why in the world do we want to deal with yet another "oh, I have to remember to tag this" workflow?   Community contributions are infrequent enough that I can't see looking through the discussion thread being a burden for our team.

I believe @xiangyan99 had stated that the Python team spends a lot of time reviewing currently open PRs and they have a few Community Contributions that are consistently waiting on the PR author to answer a question or make some kind of change. And they would like the GH Action rules to add comments on the PR reminding the author that the PR is waiting on their input. I don't know if we need to actually have the PR be auto closed any earlier than the stale PR rules would close it.
I should let @xiangyan99 voice what they are looking for.

I'm not a fan of this one for several reasons:

We have a rule that deals with stale PRs and closes them out.  Why do we need a second one with more overhead for our team to manage?
Why would we treat community contributions differently than partners and internal teams?
This is being more aggressive about closing out community contributions.  Why are we trying to punish community members who kindly volunteer their free time to help us out?  There's no cost or damage to letting a community PR sit and wait for the normal stale rules to flag it.  If anything, we want to be generous and gentle here.
Why in the world do we want to deal with yet another "oh, I have to remember to tag this" workflow?   Community contributions are infrequent enough that I can't see looking through the discussion thread being a burden for our team.

Good point!
And it sounds fine to us.
Closing the request.


Add $touched/$untouched to FormController

I think that there should be $touched/$untouched properties in the FormController in the same way that there are $valid/$invalid properties. It shouldn't be hard to implement IMHO. Actually I was surprised when I found out that they weren't there :P
How can I workaround this for now?

What would be the difference the proposed $touched/$untouched as compared to the existing $dirty/$pristine?

The difference is that a control is $touched when it loses focus, meanwhile a control is $dirty if the user has interacted with it. So what I expect is that if all controls are $untouched, the form should be $untouched; whereas if there is any control $touched, then the form should be $touched.

And what about setting value to control dynamically in response to other control change, like a new default value? Would such control be still marked as $untouched and $prestine?
Another question - should it possible to change $touched/$untouched in the code even though the values refer purely to the fact of interaction?
Just something to think about before implementing it ;)

Is there any progress on this feature? Since I was also looking for a way to validate if your form was touched.

According to this how can I change touched/untouched control state programmatically? It seems that $setUntouched() and $setTouched() are not working

+1

+1 can we get the 'ng-touched' class on the form as well as inputs please?

$setUntouched() and $setTouched() are not working

reproduced it on 1.4.8

+1


Add dataset comparison function

Add an internal dataset comparison function for validation purposes.  Need to be able to control precision.

Redundant issue.


Support multiple hive instances

Is your feature request related to a problem? Please describe.
I want to use hive in a plugin, to keep track of where a user is holding in an audio file. The problem is that the main application and the plugin have to be careful not to conflict, with registering type adapters with the same type id.
Describe the solution you'd like
There are probably a couple ways this use case could be dealt with.
It should be possible to have multiple "contexts" of hive, which are (from the app/plugin developers perspective) not aware of each other.
Describe alternatives you've considered

Specify the type id in main app - not possible, because type id is marked in model class
Have the main app create the class and set the type id - that adds an annoyance to the client, but is probably what I'll have to do for now.
Use a high enough type id that there hopefully won't be a conflict - that's just a bad idea.

Version

Platform: iOS, Android, Mac, Windows, Linux, Web
Flutter version: 1.17.3
Hive version: 1.4.1+1

I understand that a new version of hive is being actively worked on, so IDK if this will be in current hive. But maybe something to keep in mind for the new version.

You can already create multiple Hive instances and register different adapters on them:
final MyHive = HiveImpl();
MyHive.registerAdapter(…);

Is that recommended? I thought I saw in the docs that that class wasn't
part of the public interface.
Meaning, it could change or be removed even in a minor release.
On Sun, Jun 7, 2020, 6:02 AM Marcel Garus<EMAIL_ADDRESS>wrote:

You can already create multiple Hive instances and register different
adapters on them:
final MyHive = HiveImpl();
MyHive.registerAdapter(…);
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/hivedb/hive/issues/336#issuecomment-640189531, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AA7B3KLRDVB45TG3SQ3SZI3RVNQT3ANCNFSM4NWWRW4A
.

@yringler It is not something I intended but you can create multiple HiveImpl without a problem.

@leisim so, you mean that it won't conflict with each other, even if same type id of different classes are registered?

Yes exactly. The two instances will not influence each other in any way.

Very cool! Thank you. Would it make sense to make HiveImpl officially part of the packages public interface, and document that it is only intended to be used explicitly by plugins to avoid conflicts?
Note to other's who may read this thread: to use HiveImpl, you have to import 'package:hive/src/hive_impl.dart';

FYI this is no longer possible due to https://github.com/hivedb/hive/commit/59ad5403593283233d922f62f76832c64fa33a3b#diff-7640da40298286a6e462d5a80f1c608b0df8660fb13bd5aad0f32b6db68b42c0.
I'm not sure why the change was made and in my opinion, this is a critical use-case for packages which use Hive.
For example, if package:a uses hive internally and package:b depends on package:a, package:b cannot use hive.

FYI this is no longer possible due to https://github.com/hivedb/hive/commit/59ad5403593283233d922f62f76832c64fa33a3b#diff-7640da40298286a6e462d5a80f1c608b0df8660fb13bd5aad0f32b6db68b42c0.
I'm not sure why the change was made and in my opinion, this is a critical use-case for packages which use Hive.
For example, if package:a uses hive internally and package:b depends on package:a, package:b cannot use hive.

I've looked into the Browser implementation but I'm not sure, will there be conflicts using multiple HiveImpl() instances on web?


initial checkin for core / tests

All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.

[x] Please open PR in Draft mode if it is:

Work in progress or not intended to be merged.
Encountering multiple pipeline failures and working on fixes.

[x] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[x] I have read the contribution guidelines.
[x] The pull request does not introduce breaking changes.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[x] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
[x] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:
Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

[ ] Include updated management metadata.
[ ] Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.
If the check fails at the Verify Code Generation step, please ensure:

Do not modify any code in generated folders.
Do not selectively include/remove generated files in the PR.
Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,

Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@pakrym here is the apiView you requested https://apiview.dev/Assemblies/Review/393c643a31a344e2805f738350665802 just know this is still a WIP which is why its going into a feature branch vs master so some comments on the apiView will be taken as follow up

/azp prepare-pipelines

/azp run prepare-pipelines

@pakrym adding the example RP APIView that uses the new Azure.ResourceManager.Core.  Again this is WIP so not all comments will be address immediately but we will track them in ADO
https://apiview.dev/Assemblies/Review/12422a8f348249a18e2ff05e6ae776e5

/azp run net - resourcemanager - ci


Nothing working, context menu doesn't work

I cannot get anything to work the way it was before update.
Right click context Log highlight does nothing, changing syntax to Log highlight also does nothing.

I have replaced settings with new default, I have rebuilt syntax,colors

It seems that fille matches work, unsaved or buffer console windows do not..

I also noticed the context menu is sometimes missing...

Open file, change syntax - NOT WORKING
Context Menu - NOT WORKING
open file match - WORKING
I also see 2 syntax sometimes...

I have been trying to debug this, but I cannot find anything, I don't even understand what this is supposed to be doing..
{ "command": "log_highlight", "caption": "Log Highlight" }
I see nothing happening

ok found it,
            if not lname:
                return

LogHighlightCommand run
get_log_name
[ Deviot 2.3.0.dev13 ] Serial Monitor | /dev/cu.SLAB_USBtoUART
Still None
LogHighlightCommand not lname

It works, I had to add an extensionless wildcard..
I assume this is because there are presets so it has to find which preset matches , which is fine i guess, but I think the context menu should always force something.. maybe the first one?

@tablatronix ,
".*" extension was deprecated, when the package was updated to enable multiple log types. You can define multiple log types with different log extensions like this :
"log_list" : {
   "abc" :  {
      "extension"    : [ ".abc" ],
      "output.panel" : [ "exec" ], // exec - to apply to build results
      ...
   "def" :  {
      "extension"    : [ ".def" ],
      ...

The extensions are used to distinguish log types. In order to use the output panel like 'build' window, you can set "output.panel" : [ "exec" ] for a specific log type.

I use a plugin that generates output panels in view with names like
'[ Deviot 2.3.0.dev13 ] Serial Monitor | /dev/cu.SLAB_USBtoUART'
Is there a way to target these, without using '*' ?

@tablatronix , It looks a just view not a output panel. Anyway, you can add an extension item for it. I've updated the package as v2.1.0.
"extension"    : [ ".log", "*.csv", "[ Deviot*" ],

Perfect

@tablatronix
I've updated the package as v2.2.0 to apply 'auto_highlight' correctly for a newly generated view like yours.
You may don't need to run 'Log Highlight' manually if 'auto_highlight' is on.

I will test it out


fix: reload required after login

Description
Currently the user requires to reload after login into the acc, if another session was live, they might need to reload to remove the prev acc from cache which is a major security and privacy vulnerability.

assign me i want to solve this issue


$generichide doesn't work on oploverz.in

AdGuard nightly 2.12.52
To reproduce:
Enable English filter and go here - https://www.oploverz.in
It seems that $generichide doesn't work correctly.
Screenshot

One more thing, I'm not sure if it's a bug, but it looks strange.
There are other scripts between
<!-- Start: injected by Adguard --> and <!-- End: injected by Adguard --> tag.
It happens on https://m.onet.pl/
Screenshot

https://github.com/AdguardTeam/AdguardFilters/issues/17679

Assigned to myself, for now, I'll collect more details.

Resolved in core/pull-requests/426


Merge pull request #116 from theonion/signal-config

Port fix from 0-6-x into master (0-7-x)
@benghaziboy

:+1:


Blank Page?

Installed, on button click the page isn't duplicated but I get a blank page opening up at this url: perch/addons/fieldtypes/frwssr_clonepage/?id=648&renamepostfix=%20(Copy)
Any suggestions?

Hey @MeepleMe, thanks for reaching out. Can you provide me with some more information, please?
Where is the field placed (is it inside your attributes template, e.g. “seo.html”)?
What version of Perch are you using (standard, Runway, what version number)?
Are there any writing restrictions on your folders containing the page you want to duplicate?
Cheers, Nils

Hey @MeepleMe, is the issue still there for you?


Track validator-associated data

There are at least two important pieces of data to associate to a validator:

a shielded address for the the validator's commission (#39);
the validator's commission percentage;
the validator's unclaimed reward balance.

To start, these can probably be defined at genesis, but eventually, validators should be able to update them. Determining how that should happen is out-of-scope for this issue.

As a useful extension, it'd be convenient to be able to specify multiple addresses and commission amounts (which might not need to be controlled by the validator; e.g., they could specify an address for a DAO that did public goods funding, etc.)