Explorer can freeze for large folders and many glob patterns

VSCode Version: 1.3.1
OS Version: Windows 10 Pro

Steps to Reproduce:

Open a folder from visual studio code
In the sidebar, select a subfolder with a huge number of files (mine has over 70000 json files)

Then the window will just freeze. No response to click or keyboard whatsoever, until after a while the system reports that "The Window is no longer responding".
Thank you!

Tree performance...

This cannot be important because we shipped with this for years.

When I open the tests/baseline folder of the TypeScript workspace (it includes 18000 files) it takes 30 seconds to show the contents (not seeing any progress during which, filed https://github.com/Microsoft/vscode/issues/10459).
@joaomoreno most time seems to be spend in the treeModel#Item() function, can you take a look? The profile is here: explorer.cpuprofile.zip
One thing to note is that the explorer is not using templates yet but I would not expect that to be a problem for 18.000 elements where most of them show hidden. Only a problem when quickly scrolling through the results.

Just comment out this section and you'll get rid of the UI performance bottleneck. And obviously so: every filter call is going through all the sibling files, for every file, making this O(n²).
It immediately becomes more responsive, although it still takes ~5 seconds on my machine. Most of that time is spent on the file service and the file viewer classes:

I pushed a fix that avoids the O(n^2) issue for most cases but if the user has configured a filter pattern where I need to know the siblings ("**/*.js": { "when": "$(basename).ts" }) we still run into the performance issue, so I am leaving this open.

Pushed another fix to ignore glob patterns that need to check on siblings when the number of files in a folder exceed a threshold.
Expanding the typescript/test/baseline folder with 16.000 files still takes 3-4 seconds but is much better compared to the 30-60 seconds we used to have. Closing.


Unable to load session library

hey, nice to see that codeigniter is alive !, i would like to upgrade only the Session Library, i fallowed closely the instructions for upgrade from 2 to 3, and i have removed first the Session.php from libraries and copied only the Session Library folder to libraries system folder, but on load the library it says: "Unable to load the requested class: session"

You can't do that. It's either full upgrade or no upgrade.
Also, please don't post support requests or questions here - we only accept bug reports on GitHub. Anything else should be posted on the forums.

Dude, since you rewrite the entire code, and changed the mode how we was coding with codeigniter, you invented and change the methods, so, since the Session library from 2.2 is not very good, and in this version was perfectioned i say Ok, lets change the Session, because it is in CANDIDATE RELEASE, not a stable version, why you people just not keep the same structure and keep the same way of coding ? all the time you redirect to o a forum that doesn't exist anymore in google, and it goes to a ridiculous page where say "Codeigniter has a new home" !

If you even clicked on the link, you'd know it's a new forum and it sure as hell exists. I wouldn't send you there if it didn't.


Items bg colour

How can change items background color. I want to develop it like a pie chart.

hello did you fix this?


[R2] Update docs for notification commands

Update docs for the notification command and add example for the --prefix and --suffix command.

Closing this in favour of #16392


Update chart readme about volume expansion

In GitLab by @paul.laffitte on Feb 4, 2021, 16:58
add missing allowVolumeExpansion: true in storage class example

In GitLab by @paul.laffitte on Feb 8, 2021, 11:16
mentioned in commit 7de56dd15485203be624163596e3f7b252535454

:tada: This issue has been resolved in version 3.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


The content for the tab-group-invalid rule is empty

It just has 2 backticks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: aa011899-ac62-20f9-2292-150c8bfcbe03
Version Independent ID: 22c24db2-daf0-c71c-08f9-98f81e1b13ba
Content: tab-group-invalid - Contributor Guide
Content Source: Contribute/validation-reference/tab-group-invalid.md
Product: non-product-specific
GitHub Login: @meganbradley
Microsoft Alias: mbradley

@meganbradley please take a look when you have a chance.

@JasonWHowell @nschonni thanks - I've removed the file until we're ready for it. Change should go live shortly.


using incrementing mode with CreateDate give an error

Hi
i am using key incrementing mode and CreateDate the standard SAP column and i am getting this error
Caused by: java.util.NoSuchElementException: key not found: CreateDate
{
"name": "sap",
"config": {
"connector.class": "com.sap.kafka.connect.source.hana.HANASourceConnector",
"tasks.max": "10",
"topics": "mytopic",
"mode":"incrementing",
"auto.offset.reset":"latest",
"group.id":"589f5ff5-1c43-46f4-bdd3-66884d61m185",
"poll.interval.ms":"86400000",
"mytopic.table.name":                          ""schema"."table"",
"mytopic.poll.interval.ms":                    "86400000",
"mytopic.incrementing.column.name":            "CreateDate"
}
}

When you're setting up, did you set the auto.create=true
If not that's the problem, the CreateDate if doesn't exist it will give that null point error.

@Sano123456 I suspect the column simply doesn't exist. And if that is indeed the case, the current version will report a more readable error "The Incrementing column is not found in the table". Have you checked the table? I'm closing the ticket. If your table has the column and you are enchanting some error, please reopen this ticket and attach the trace.
Thanks.

@Sano123456 I suspect the column simply doesn't exist. And if that is indeed the case, the current version will report a more readable error "The Incrementing column is not found in the table". Have you checked the table? I'm closing the ticket. If your table has the column and you are enchanting some error, please reopen this ticket and attach the trace.
Thanks.


Check on any possibility to remove LinkedList from the cache impl

$Subject

Description
The following external libs used to analyze the current cache module implementation without a linked list.

Apache concurrentLinkedHashMap
Google code  concurrentLinkedHashMap
Caffeine cache

I have also done the performance test for the below scenarios using the above libs.

Pure cache test
HTTP caching
Http with JWT

You can find those result in this sheet
https://docs.google.com/spreadsheets/d/1z6Ypxx8GkK9pABqoG6d495if-B4oNjLRgbLlKUnCfng/edit#gid=0
Observation
When we used concurrentLinkedHashMap, we got the cache performance test result higher than the existing implementation by twofold. Even though the HTTP performance test result also has improved but there is no relatively significant change.
Conclusion
We can improve the cache module with concurrentLinkedHashMap if we want.

I am not familiar with your work, so I apologize for jumping in, but I see a took a glance at the cache benchmark. This tests with a uniform distribution which minimizes the chance of lock contention, but also has no recency/frequency characteristics for an eviction policy to exploit. Thus random replacement is ideal and it might give a false impression. I use a Zipfian distribution in a JMH benchmark to better model multiple threads accessing the same hot entries.
It may be that the http benchmark suffered from Caffeine's default behavior of deferring the policy maintenance to a background thread (ForkJoinPool.commonPool()). This is used for any asynchronous work, so the policy maintenance is deferred to avoid penalizing the caller from incurring user-facing latencies. For example an eviction listener might be configured and the cache is unaware how expensive that user code may be. In normal operations using the common pool has no negative impact and might improve latencies, as typically a server's cpu isn't maximized. In a benchmark, however, this could be wasteful by adding context switching as threads fight for cpu time. You may observe a small gain by using Caffeine.executor(Runnable::run) to perform the "async" work on the calling thread.
I believe the only difference that Apache made to CLHM is (1) adding compute methods and (2) replacing the backport of JDK8's ConcurrentHashMap to be compiled on JDK8 instead. Since CLHM is small it is nice to fork and embed, so I think it is mostly identical for your purposes.
Some aspects of Caffeine should be faster, but it might also be slower in cpu time due to the additional features. A slightly higher hit penalty for much fewer cache misses would be favored in real systems, so LRU is replaced by a more advanced algorithm. Of course if your workload is strongly recency-biased then LRU is optimal, but to be robust the cache implements a policy that is near optimal in any workload pattern (LRU, LFU, MRU). You might not observe that benefit in a concurrency benchmark.
Your custom cache may suffer from LRU list corruption. While the list operations are guarded by a tryLock and skipped if locked, that could result in a few odd scenarios:

On a get the remove succeeds but the addFirst does not. Now the entry is outside of the LRU list and may never be evicted from the ConcurrentHashMap.
The LRU victim may be concurrently evicted while another thread reads it. This mirrors (1) where the evict's remove may be cancelled by the get calling addFirst.
When the entry fails to be removed, then the cache exceeds its capacity. The size() == maxSize check for triggering eviction will no longer become true, so the cache will never size evict again until expiration "fixes" the state due to a full sweep.

That design might be acceptable for your use-case, but is also a bit surprising by relying on a periodic fixup to avoid runaway growth. You may wish to document that and not allow for expiration to be disabled, or else risk runaway growth.

@ben-manes Thanks a lot for your insight. This is really helpful for us to evaluate further. We also identified the issue in our cache implementation, which leads to LRU list corruption. We are looking for the best solution for our cache design.
We will have another look. Again thanks for jumping in and providing your valuable insight.

@ben-manes Thank you very much for pointing out those and spending your valuable time. Yes, we have an issue with our existing implementation. Therefore, I did some research to improve. Your thoughts and suggestions will definitely help me to analyze further. Thanks a lot, again.

Removed in #72


change PEP8 to pycodestyle

Hello,
PEP8 linter recently changed its name to pycodestyle :

discussion: https://github.com/PyCQA/pycodestyle/issues/466
commit: https://github.com/PyCQA/pycodestyle/commit/26c64badd9ea27cbfbff311f7b3b09b475e80ead

It causes problems when trying to lint python code:
SKIPPED: pep8 is not installed. Run pip install pep8.

@superzazu @addykim This can be closed, it was changed in the previous commit.

Hello,
The fix for this issue has not been merged (PR #84), the issue is still open


Added memory tracking util and validation tool.

Will be useful for future PRs (:
Signed-off-by: Bartlomiej Plotka<EMAIL_ADDRESS>

Not very reliable yet.

Please support

How to sign off

Still valid.


New Connector Sample get IBM DB2 Data LOB into Microsoft 365

New Connector Sample get IBM DB2 Data LOB into Microsoft 365

Awesome! 👏


View cube’s rotation is different in up/down and left/right movements

View cube’s rotation is different in up/down and left/right movements
When left/right arrows are clicked, The rotation of navcube is simple. If started from Front and right arrow is clicked Front-->Right-->Back-->Left-->Front .
Whereas if up/down arrows are clicked , The rotation gets inversed once in two time. If start from Front and down arrow is clicked Front-->Bottom-->Back-->Bottom-->Front . Top will never be displayed
This can be seen in any sandboxes. Is this the right behaviour. Is there any background for this?

@NancyMcCallB  @GerardasB  Request your attention on this issue.

@NancyMcCallB
I understand this is targeted for 4.1 release, but user just wants to know what is the background of this behaviour. Is there any justification?


Fix deepcopy of Model

This commit fixes an issue where deepcopies of models would exhibit behavior different from the original due to broken references buried within the functions of the ssequations and the evaldata object. There is also a test which ensures that the evaldata functions as expected.
In the SteadyStateData, the reference is to the model itself within an SSEqnData object which gets created for the creation of the resid functions, but is discarded and subsequently no longer exists outside of those functions.
function sseqn_resid_RJ(s::SSEqnData)
    function _resid(pt::Vector{<:Real})
        _update_eqn_params!(s.eqn.eval_resid, s.model[].parameters)
        return s.eqn.eval_resid(__to_dyn_pt(pt, s))
    end
    function _RJ(pt::Vector{<:Real})
        _update_eqn_params!(s.eqn.eval_resid, s.model[].parameters)
        R, jj = s.eqn.eval_RJ(__to_dyn_pt(pt, s))
        return R, __to_ssgrad(pt, jj, s)
    end
    return _resid, _RJ
end

function make_sseqn(model::AbstractModel, eqn::Equation, shift::Bool)
    ...
    let sseqndata = SSEqnData(shift, Ref(model), JT, eqn)
        return SteadyStateEquation(type, vinds, vsyms, eqn.expr, sseqn_resid_RJ(sseqndata)...)
    end
end

Perhaps there is a clever way to get at it and update it, but the approach taken in the PR is to reinitialize the steadystate in the copied object and then copy over the steadystate values and mask from the original object.
For the ModelEvaluationData the reference is in the object itself which gets passed to the respective functions so it is enough to make deepcopies of the ModelEvaluationData instances with the reference corrected. This approach was about twice as fast as clearing and recreating the ModelEvaluationData.

Codecov Report

Merging #43 (36f18f4) into master (7a7dfa8) will decrease coverage by 0.67%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
- Coverage   94.43%   93.77%   -0.67%
==========================================
  Files          15       15
  Lines        1671     1686      +15
==========================================
+ Hits         1578     1581       +3
- Misses         93      105      +12

Impacted Files
Coverage Δ

src/model.jl
96.53% <100.00%> (-0.10%)
:arrow_down:

src/transformations.jl
70.00% <0.00%> (-30.00%)
:arrow_down:

src/abstract.jl
94.28% <0.00%> (-2.86%)
:arrow_down:

src/steadystate.jl
91.16% <0.00%> (-1.58%)
:arrow_down:

src/export_model.jl
92.85% <0.00%> (-1.03%)
:arrow_down:

src/evaluation.jl
81.60% <0.00%> (-0.58%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

As it turns out, this issue was caused by an implementation of deepcopy_internal for Parameters which did not update the stackdict.


Dashboard: Add List View UI to Dashboard

Add list view to dashboard

#770

@BrittanyIRL Fixed the sizing issues and updated the code to use the index imports and theme!

@carlos-kelly As mentioned on Slack, this PR caused an issue with the storybook, specifically assets/src/dashboard/components/table/stories/table.js did. Deleting that file resolves the issue, if that helps as a hint.
Note: the error only happens with npm run build:storybook, not npm run storybook.


style: move listbox to main package level and add style.Theme

This PR improves style by doing the following:

move listbox to main package level
add style.Theme
modify the implementation for style/basic by using style.Theme making it easier to create new styles

@aykevl review please? :smile_cat:

So if I understand correctly, the idea is to make "theme" the color scheme basically?
My original idea was to make multiple styles matching different UI frameworks, for example one for Material design and perhaps others as needed. With the idea that different designs also have different kinds of widgets. And the idea was to have a minimal core in the tinygl package itself (and subpackages like tinygl/gfx) with core widget elements (such as boxes and text labels) that would usually not be created directly but through the appropriate style package and the style package would create multiple sub-objects as needed and set text size, color, padding, etc as appropriate.
That's probably not the only way to do this, and maybe not the best way, but that was my original idea. In particular, I wanted to avoid the situation that LVGL has where every object can do lots of things and is super flexible, I'd rather have a few more objects that do one particular thing and compose them together (like how the listbox is composed of text labels).


Unable to throw an error to check if GOVUK.analyticsPlugins.error correctly sends information

Both tests in question are turned of withxit():

it sends errors to Google Analytics
it tracks only errors with a matching or blank filename

Kudos to @andysellick for pretty much all of this.
What we want to test
These tests should check if any JavaScript errors thrown are sent to Google Analytics.
Testing if a function correctly throws an error is done using the toThrow() function. For example: expect(triggerError()).toThrow(errorDetails). This won't work for these cases, since we're not interested in the error being thrown - we're interested in whether the analytics plugin is called to catch the error and whether it sends the correct information.
Consider the following pseudo-code example:
analyticsPlugins.error() // sets up error listeners that point to trackEvent
analytics = {
  trackEvent: function () {
    // event sent to Google Analytics
    // ...
  }
}
spyOn(analytics, 'trackEvent')

triggerError()
expect(analytics.trackEvent).toHaveBeenCalledWith(errorDetails)

When the error is thrown to see if trackEvent() is called, the test halts.
Attempts and methods
Anonymous function
Putting triggerError() inside an anonymous function so it doesn't cause the entire test to halt means that it doesn't trigger trackEvent() because scope - so the test fails.
Try / catch
Putting it in a try/catch block
try {
  triggerError()
  expect(analytics.trackEvent).toHaveBeenCalledWith(errorDetails)
} catch(e) {
  // do something
}

doesn't work as the catch is called as soon as the error occurs - so expect() isn't run.
Moving the expect() function to the catch causes the test to halt as the error is caught by the block before trackEvent() can be called.
.callThrough()
Jasmine has a .callThrough() function - this didn't work, as it happens after the error has occurred and halted the tests.
Stubbed trackEvent function
To check if the trackEvent was being called, the function was stubbed to change a global variable. This didn't work because anything that is supposed to happen after the error is thrown doesn't happen.
Custom event
Thinking that the error event was causing the problem, a custom xerror event was created to be used instead of error - both in the spec and the GOVUK.analyticsPlugins.error function. Though the event was being fired and the data correctly passed into the event listener, the test failed as the trackEvent function wasn't being called.
( Basically ¯\_(ツ)_/¯ and (ノಠ益ಠ)ノ彡┻━┻. )
PR to include the analytics code from govuk_frontend_toolkit: https://github.com/alphagov/static/pull/1795

I can't see a way of checking if the error tracking works with the tests as they currently stand. I wonder if splitting the error tracking into completely separate functions could make the testing easier:

one function to take the error information and send it to GA
one function to add a listener for errors, which then calls the other function

This is pretty much what happens now, just as one black-box style function. Splitting them into two wouldn't make checking if the error is being picked up any more possible - but it would enable us to check if the correct information was being sent in the correct format.

The analytics code is now in govuk_publishing_components although this issue is still relevant.


Video formats (on_server_handshake)

Hi,
I'm surprised why the payload.formats in "on_server_handshake()" has only SD and 720p profiles available, see:
DEBUG:xbox.nano.channel:VideoChannel server handshake payload: \s<XStructObj: None>(Container:
    protocol_version = 5
    width = 1280
    height = 720
    fps = 30
    reference_timestamp =<PHONE_NUMBER>757
    formats = ListContainer:
        Container:
            fps = 30
            width = 1280
            height = 720
            codec = VideoCodec.H264
            rgb = None
        Container:
            fps = 30
            width = 960
            height = 540
            codec = VideoCodec.H264
            rgb = None
        Container:
            fps = 30
            width = 640
            height = 360
            codec = VideoCodec.H264
            rgb = None
        Container:
            fps = 30
            width = 320
            height = 180
            codec = VideoCodec.H264
            rgb = None)

I've also tried to rise the ClientVersion as well as correcting the resolutions in constants.py like:
class WindowsClientInfo(object):
    """
    Client Info for Windows device, used for LocalJoin messages
    """
    DeviceType = ClientType.WindowsStore
    NativeWidth = 1920
    NativeHeight = 1080
    DpiX = 96
    DpiY = 96
    DeviceCapabilities = DeviceCapabilities.All
    ClientVersion = 41
    OSMajor = 6
    OSMinor = 2
    DisplayName = "SmartGlass-PC"

That leads to the question, how the device determines the formats it's offering.
I'm feeling a bit lost, because I can't find anything corresponding in the docs (https://github.com/OpenXbox/smartglass-documentation/blob/master/docs/nano.md).
Needless to say, great work guys! :+1:

Hey,
The resolutions / video formats the NANO protocol offers to the client, are totally unrelated to the LocalJoin message from SmartGlass protocol!
The actual usage for LocalJoin by the console is -> sending content to render on the client - THEORETICALLY!
Only usage ever - Fallout 4 - but even there I am unsure if the companion app accounts for that info...
What you rather want to look into is this: https://github.com/OpenXbox/xbox-smartglass-nano-python/blob/master/xbox/nano/manager.py#L11

It's likely a limitation in the protocol, I wasn't able to achieve higher resolutions either.
Keep in mind, encoding higher resolutions needs more processor power - and Xbox priority number 1 is speed! They likely don't want to risk any slowdowns ingame.
The way they achieve better quality (still on 720p tho) is increasing the bitrate - not the resolution.
In the current way of handling it, the nano client will take the highest bitrate automatically.
Reference: https://www.reddit.com/r/xboxone/comments/8ca0bl/xbox_app_increasing_streaming_quality_beyond_very/

Many thanks for those information.
I'll check and test it.
Another thing (resolution based) is, when activating the "VeryHigh" video quality in the channel.py. It seems to just display the topper-left part from the image. (like one fourth of the whole rendered image)
And I think that is the place where to rise the bitrate, right?  (i.E. a new Enum like VideoQuality."Experimental")

Exactly!
About the cropped image, hmm, maybe the ffmpeg decoder needs more info to handle it sanely - PPS / SPS.
pyav (the ffmpeg python wrapper) is configurable towards that, but I was just using the basic wrappers - it surely is possible to optimize there.

Or maybe the renderer is set to too low of a resolution https://github.com/OpenXbox/xbox-smartglass-nano-python/blob/master/xbox/nano/scripts/client.py#L53

@Schamper, good advise.
Sadly I already changed that to 1080p. I've also eddited: self._window, (1920, 1080), None, (https://github.com/OpenXbox/xbox-smartglass-nano-python/blob/master/xbox/nano/render/video/sdl.py#L43)
still testing.

Tested it without really success..
I've rolled back everything to master, except the resolution settings in in client.py and manager.py.
My best try so far was:
Experimental = [70000000, 2, 60000, 1001, 30, 0]
As soon as I change the second value to 3 the cropping happens.
Is there a doc about this enum(or the VideoQuality itself), espacially about the 2nd - 5th value?

Official settings, provided by Microsoft's Xbox App config file (https://settings.data.microsoft.com/settings/v2.0/xbox/xboxapp):
GAME_STREAMING_VERY_HIGH_QUALITY_SETTINGS	"12000000,1080,60,59,0,10,40,170"
GAME_STREAMING_HIGH_QUALITY_SETTINGS	"8000000,720,60,59,0,10,40,170"
GAME_STREAMING_MEDIUM_QUALITY_SETTINGS	"6000002,720,60,3600,0,40,70,200"
GAME_STREAMING_LOW_QUALITY_SETTINGS	"3000001,480,30,3600,0,40,70,200"

Python lib
"""
6x uint32_t
"""
class VideoQuality(object):
    VeryHigh = [12000000, 3, 60000, 1001, 59, 0]
    High = [8000000, 2, 60000, 1001, 59, 0]
    Middle = [6000002, 2, 60000, 1001, 3600, 0]
    Low = [3000001, 1, 30000, 1001, 3600, 0]

Unsure how it correlates. Apparently there is no documentation as we have not figured out this piece...

Thanks for all the Information.
Currently I'm setting up a new VM to analyze the original protocol from the xbox-app (especially the codec-change). I'm closing this for now, maybe you can flag this issua as "question".
(Maybe reopen this issue on new information)
cheers.

Ok, will do!
Reach out on Discord if you like

Source: https://github.com/MutoMagic/xstream/blob/master/xstream/Program.cs
// Modify standard config, if desired
/*
 * GAME_STREAMING_VERY_HIGH_QUALITY_SETTINGS: 12000000,1080,60,59,0,10,40,170
 * GAME_STREAMING_HIGH_QUALITY_SETTINGS: 8000000,720,60,59,0,10,40,170
 * GAME_STREAMING_MEDIUM_QUALITY_SETTINGS: 6000002,720,60,3600,0,40,70,200
 * GAME_STREAMING_LOW_QUALITY_SETTINGS: 3000001,480,30,3600,0,40,70,200
 *
 * SETTINGS:
 * Unknown1,Unknown2,Unknown3,Unknown4,Unknown5,Unknown6,Unknown7,Unknown8
 * Unknown1 UrcpMaximumRate
 * Unknown2 VideoMaximumHeight
 * Unknown3 VideoMaximumFrameRate
 * Unknown4 ?
 * Unknown5 AudioBufferLengthHns if 0 use Unknown1
 * Unknown6 AudioSyncMinLatency
 * Unknown7 AudioSyncDesiredLatency
 * Unknown8 AudioSyncMaxLatency
 *
 * refer to: https://github.com/OpenXbox/xbox-smartglass-nano-python/issues/7
 * standard: 10000000,720,60,?,0,10,40,170
 */
//config.UrcpMaximumRate = (int)(3.000001 * 1000000);// 1后面6个0
//config.VideoMaximumHeight = 480;
//config.VideoMaximumFrameRate = 30;
//config.Unknown4 = 59;
//config.AudioBufferLengthHns = 0;
//config.AudioSyncMinLatency = 40;
//config.AudioSyncDesiredLatency = 70;
//config.AudioSyncMaxLatency = 200;
string quality = GetSettingString("GAME_STREAMING_AVAILABLE_QUALITY_SETTINGS");
if (mapping.Length == 2 && mapping[1].Length != 0)
    quality = mapping[1];

config.UrcpMaximumRate = GetConfigurationInt(quality, "UrcpMaximumRate");
config.VideoMaximumHeight = GetConfigurationInt(quality, "VideoMaximumHeight");
config.VideoMaximumFrameRate = GetConfigurationInt(quality, "VideoMaximumFrameRate");
//config.Unknown4 = GetConfigurationInt(quality, "Unknown4");
config.AudioBufferLengthHns = GetConfigurationInt(quality, "AudioBufferLengthHns");
config.AudioSyncMinLatency = GetConfigurationInt(quality, "AudioSyncMinLatency");
config.AudioSyncDesiredLatency = GetConfigurationInt(quality, "AudioSyncDesiredLatency");
config.AudioSyncMaxLatency = GetConfigurationInt(quality, "AudioSyncMaxLatency");

if (config.AudioBufferLengthHns == 0)
    config.AudioBufferLengthHns = config.UrcpMaximumRate;

// 由于小数点向上进位，因此误差 +-1 的情况下，永远满足最小分辨率16:9
config.VideoMaximumWidth = (int)Math.Ceiling(config.VideoMaximumHeight / 9.0 * 16);


Crash upon launching

Despite uninstalling and reinstalling more than once, XML Notepad either crashes upon launching, or crashes when trying to open an XML file (I've tried drag and drop, using the Open file, or using the Open with directly from the file directory).

Sorry to hear that, can you tell me which installer you used? ClickOnce, Standalone or winget?
Also XML Notepad now depends on .NET Framework 4.8 can you make sure you have that version installed?
If the crash provides any popup message or details can you include that information also, thanks.

I have tried both the ClickOnce and the Standalone. And the .NET Framework 4.8 is installed.
Unfortunately, there are no pop up messages or details to provide! The app just closes.

That's unfortunate.  You could try deleting these files if they exist:

C:\Users<your user name>\AppData\Roaming\Microsoft\Xml Notepad\XmlNotepad.settings
C:\Users<your user name>\AppData\Local\Microsoft\Xml Notepad\XmlNotepad.settings

Last time I saw anything like this it seemed to be related to windows defender not recognizing my signing certificate and booting the app out for that reason.  More likely if you are running on a machine that is managed by a corporation.  If you are familiar with the Windows Event Viewer and if you can find any relevant errors there that might be helpful.  If you are a developer and you can launch the app in the Visual Studio debugger and find the load time exception that would be super helpful.

I am indeed on a corporate machine. I will reach out to IT as soon as my workload decreases a bit to see if I can troubleshoot with them, using the information that you have provided so far. Thank you!

Ok, good luck.

Great, I have not used it with box, but when I point it to a file on a One Drive folder it works.  Does Box have a concept of "keep files on this device" that you could try to force Box to pre-download the files before trying to open them in XML Notepad?

I just installed Box Drive for window and it shows my Box account as a new windows drive, and I put the XML notepad samples up there.

I was then able to double click the xml files and open them in XML notepad:

I could also shift+right+click a file and select "Copy as path" and paste that into the XML notepad address bar and open files from my Box folder that way:

So can you try following these steps?


Add even more text to the rb section

What's this PR do?

Add text to the reportback image holder to say 'and we'll check it out'
Refactor how that text is added so we know if it's a new reportback or an updated one.

How should this be reviewed?
Take a look at the ~new world~
I personally think this looks more crowded/worse than what we used to have. 😢
new reportback

updating reportback

Any background context you want to provide?
The scholarship block was actually quite a bit of refactoring and causing a lot of bugs, I'm wondering if there's a way we can test that in optimizely without writing code to see if it makes a difference?
Relevant tickets
Fixes #6913
Checklist

[ ] Tested on staging.
[ ] Pinged a PM if this is a larger PR that would benefit from some additional testing love.

@angaither yes! just checked, we can test on the no RB, scholarship one the text "“Add your photo here for a scholarship entry!”" in optimizely!
I don't like the "and" hanging there like that...maybe we could do
add you photo here!
we'll check 'em out!
add you photo here
and
we'll check 'em out
probably terrible ideas, i'll let @lkpttn speak to the layout more. i'll set up the scholarship block test in optimizely for campaigns w/ scholarships

Keep in mind the text is just wrapping to fit the container, so it's probably a losing battle to try to have exact control over where things break to a new line.

^^^ yeah I tested with removing the and and it doesn't split in a sensible way there either.

Is the arrow just an :after element applied to the text box? If the interior text box has a specified width, I think we can narrow it a bit and bring the arrow element closer. That way, even if we're breaking in an odd way, it doesn't look like there's a big separation for the arrow.

@lkpttn dis?

🌵⛵

going to 🚀  this for now, and @lkpttn can revisit if he feels, when he feels bettah.


Global global swap

My understanding is that this behaviour is desired by both skin authors and users - I'm aware that you are negative on it but I mainly wanted to check if you are still negative if the cost of implementing it is merging a PR rather than actually implementing it.

Cost of implementing was never the issue. The issue is i don't agree with having to IL /reflection into MAPI to provide this support.
I agree that skin authors and users both desire this, but the most sensible way is for MAPI to expose a functionality to do this.


Feature-request: Make the plugin usable with a node-js server wiki

I think the following steps would be needed:

Decrypt a tiddler to a $:/temp/d/<title> like tiddler, that will not be saved nor synced
The decrypt-temp button will decrypt the tiddler in view mode
If the $:/temp/d/ tiddler is edited - switch to edit mode
If the edited tiddler is saved ask the user for a password to encrypt it
Encrypt the tiddler and overwrite the "old" encrypted tiddler

With this workflow imo it would be guaranteed, that no plaintext leaves the browser.
@danielo515 ... What do you think?

When the plugin is installed, we need to make sure that $:/temp/d will not be saved or synced.
We need to check in:

$:/config/SaverFilter
$:/config/SyncFilter
$:/core/save/all
$:/core/save/all-external-js
$:/core/save/empty
$:/core/save/lazy-all
$:/core/save/lazy-images

that they contain -[prefix[$:/temp/]] so we can be sure that content won't be saved accidentally.

To make sure, that no plain text hits the server it may be even better to have a hook in the server sync- and the saver- modules.


Wiki Home: Add more highlight to stable downloads

Task Description
Page: https://github.com/solettaproject/soletta/wiki
There should be more highlight to the stable downloads available to try Soletta out.
Review the text about DevApp to be friendlier and simpler.
Dependencies
None

I reviewed the text of home and getting started and made some fixes.
I won't put too much light over pre built images since they're covering a small subset of boards.


Some questions about the reported test accuracy

Thanks for your great work!
I have some questions about the test accuracy.
The code outputs the test accuracy for three cases (test sel / test all / test ft).
Which of the two is the accuracy in the performance table of the paper? ("test all"/ "test ft")
Moreover, I have observed that the performance of the global model after fine-tuning often tends to have lower accuracy than before fine-tuning. Is this considered correct, or how can this result be explained?
**** Communication all   8, Test Accuracy: 0.6960, Loss: 0.8621
**** Communication all   8, Cent Accuracy: 0.7173, Loss: 0.7935
**** Communication ft   8, Test Accuracy: 0.6533, Loss: 0.9915
**** Communication ft   8, Cent Accuracy: 0.6725, Loss: 0.9133

Hi MichaelLee-ceo, thank you for following this work. For your questions,

"test all" is used in the paper.
The same phenomenon occurs in my experiments. Theoretically, after fine-tuning the performance should increase. However, fine-tuning can benefit global model if checking performance on next round. Currently I have no idea on it and didn't go further on this work since it's published.

ZhangLin

Ok. Thanks for your reply!


Question for Speech to Text API v3.0

Hi there,
I want to ues "Get Custom Model Endpoint Log" in "Speech to Text API v3.0" to get my specific audio log. But I could not get the logid as the request parameters from my source. Could you tell how can I get the specific audio 's logid that I want .
Thank you.

@mahilleb-msft Can you help out with this issue?

@Darinzhao you can enumerate custom models endpoints logs through Get Custom Model Endpoint Logs, check .values[].self on the result.

Closed as answered, please open a new issue if more support is needed.


Where is the page?

Can't find it on w3spaces anymore

ran out of requests, but i could just keep making new accounts
new link: special-interest.w3spaces.com

Just use GitHub pages. They don't have the requests rule.

Just move the HTML files to the root and follow the instructions here.

how to move files to root?

how to move files to root?

@jonaszchuang You can just use GitHub web editor and drag and drop everything. The only thing that you need to do is to change all the links.

ok cool looks like you already moved everything

wdym change links?

nvm, it works


Return 400 http status if errors

Hi.
I'd like that when we have errors, the returned status code is 400, and not always 200.
How can I solve?
Thanks

In this moment I have solved by a custom management using response body
public class ErrorDto
{
    public ExtensionsError Extensions { get; set; }
}

public class ErrorsDto
{
    public List<ErrorDto> Errors { get; set; }
}

public class ExtensionsError
{
    public string Code { get; set; }
    public string StackTrace { get; set; }
}

public class ResponseMiddleware
{
    private readonly RequestDelegate next;

    public ResponseMiddleware(RequestDelegate next)
    {
        this.next = next;
    }

    public async Task Invoke(HttpContext context)
    {

        Stream originalBody = context.Response.Body;

        try
        {
            using (var memStream = new MemoryStream())
            {
                context.Response.Body = memStream;

                await next(context);

                memStream.Position = 0;
                string responseBody = new StreamReader(memStream).ReadToEnd();

                if (!string.IsNullOrWhiteSpace(responseBody))
                {
                    ErrorsDto errors = JsonConvert.DeserializeObject<ErrorsDto>(responseBody);

                    if (errors?.Errors != null && errors.Errors.Count > 0)
                    {
                        if (errors.Errors.FirstOrDefault(x => !string.IsNullOrWhiteSpace(x?.Extensions?.StackTrace)) != null)
                            context.Response.StatusCode = (int)HttpStatusCode.InternalServerError;
                        else if (errors.Errors.FirstOrDefault(x => x?.Extensions?.Code == "AUTH_NOT_AUTHORIZED") != null)
                            context.Response.StatusCode = (int)HttpStatusCode.Unauthorized;
                        else
                            context.Response.StatusCode = (int)HttpStatusCode.BadRequest;
                    }
                }

                memStream.Position = 0;
                await memStream.CopyToAsync(originalBody);
            }

        }
        finally
        {
            context.Response.Body = originalBody;
        }

    }
}

// Extension method used to add the middleware to the HTTP request pipeline.
public static class ResponseMiddlewareExtensions
{
    public static IApplicationBuilder UseResponseMiddleware(this IApplicationBuilder builder)
    {
        return builder.UseMiddleware<ResponseMiddleware>();
    }
}

And in starttup configure method
            app.UseResponseMiddleware();

But is there another integrated method to change default 200 status code?

With version 11 we are now following the GraphQL Http Spec Draft:
https://github.com/graphql/graphql-over-http
The spec now lines out when which error code has to be sent.

The new HTTP middleware is already implemented... so if you use our new middleware in 11 you will get the spec behavior.


Organization Name
Caylent
Your Name
On behalf of Randall Hunt
Your current position
On behalf of Randall Hunt
(Optional) Company logo
No response
(Optional) Use case
Randall Hunt, VP of Cloud at Calyent, https://github.com/aws-powertools/powertools-lambda-python/issues/4816 in the Python repository and allowed Powertools for AWS Lambda to add Caylent as a public reference across all runtimes.
Also using other Powertools for AWS Lambda (Java) languages?

[X] Python
[X] TypeScript
[X] .NET

solved with #1704


checkMultipleTimeInstances doesn't work

To guard against specifying multiple instances in instance tag, CoordSubmitXCommand.checkMultipleTimeInstances checks for ',' in instance tag. This breaks for EL extensions.  We have EL extension today(0,0) which maps to start day of nominal time. today(0,0) resolves to a single instance and presence of ',' doesn't imply that it resolves to multiple instances
Please fix this

CLosed for https://issues.apache.org/jira/browse/OOZIE-675


Redundant messages appear in the terminal window

Brief Issue Summary
ENV：
CMake Tools: v1.19.35(pre-release)
vscode: 1.91.1
C/C++ extension: v1.21.5
Repro steps:

Create a new folder named 'Test' and open it with vscode.
Create a file named CMakeLists.txt with the following content:

    cmake_minimum_required(VERSION 3.5)
    project(Test)
    add_executable(Test main.cpp)

Create a file named main.cpp with the following content:

    #include <iostream>
           auto main() -> int { std::cout << "Helloworld" << std::endl; }

Click F1 to run the “CMake: Configure" command
Click the “launch the selected target in the terminal windows”.

Actual result:
Linux:

Mac:

CMake Tools Diagnostics
{
  "os": "linux",
  "vscodeVersion": "1.91.1",
  "cmtVersion": "1.19.35",
  "configurations": [
    {
      "folder": "/home/test/Desktop/v-frankwang/test",
      "cmakeVersion": "3.30.2",
      "configured": true,
      "generator": "Ninja",
      "usesPresets": false,
      "compilers": {
        "C": "/usr/bin/gcc",
        "CXX": "/usr/bin/g++"
      }
    }
  ],
  "cpptoolsIntegration": {
    "isReady": true,
    "hasCodeModel": true,
    "activeBuildType": "Debug",
    "buildTypesSeen": [
      "Debug"
    ],
    "requests": [
      "file:///home/test/Desktop/v-frankwang/test/main.cpp"
    ],
    "responses": [
      {
        "uri": "file:///home/test/Desktop/v-frankwang/test/main.cpp",
        "configuration": {
          "includePath": [],
          "defines": [],
          "compilerPath": "/usr/bin/g++",
          "compilerArgs": [],
          "compilerFragments": [
            "-g"
          ]
        }
      }
    ],
    "partialMatches": [],
    "targetCount": 1,
    "executablesCount": 1,
    "librariesCount": 0,
    "targets": [
      {
        "name": "Test",
        "type": "EXECUTABLE"
      }
    ]
  },
  "settings": [
    {
      "communicationMode": "automatic",
      "useCMakePresets": "auto",
      "configureOnOpen": true
    }
  ]
}

Debug Log
No response
Additional Information
No response

Closing this due to lower priority.


Strange Behaviour of solid angle map for particle

Motivation:
As mentionned in PR #535 (there is a starnage behaviour, in some cases, of the solid angle map computation
Proposition:

Use the Config.calc_solidangle_particle_integrated() (with the plot), to debug more easily
Some of it may be due to the fact that the spatial resolution is large compared to the particle, and that if a mesh center is very close to the particle, it will get a very large solid angle (much larger than the other mesh elements, due to the decrease in /dict**2)

... to be investigated
Example:
In [1]: import tofu as tf
conf = /Home/DV226270/ToFu_All/tofu_git/tofu/tofu/imas2tofu/__init__.py:87: UserWarning:
You do not seem to be using the latest IMAS version:
'module list' vs 'module av IMAS' suggests:
	- Current version: 3.30.0-4.8.4
	- Latest version : 3.32.1-4.9.1-R2019b
  warnings.warn(msg)

In [2]: conf = tf.load_config('AUG', strict=True)

In [3]: part_radius = np.array([10e-6, 10e-6, 10e-6])

In [4]: part_traj = np.array([[1.8, 0.01, 0.], [1.8, 0.01, -0.1], [1.8, 0.01, -1]]).T

In [5]: out = conf.calc_solidangle_particle_integrated(part_traj=part_traj, part_radius=part_radius, resolution=0.05, vmax=False)

What seems wrong in the image above:
in the left plot:
the particle seem to be cenetred around Z=-0.1, which is wrong, it is around Z = 0 (it should be on the red line)
Moreover, the integrated solid angle should be more or less symetric as we go away from the particle, but here there is clear a brutal decrease as we go from the particle towards Z<0 (red cirlce)

it also happens when you try to compute only that test case?

Mmmmm could you tell me what would be the equivalent with my function? So which parameters does it send to GG.compute_solid_angle_map. I just tried it and it looks fine but I might not be using the right parameters.

I plot my image using scatter instead of imshow, maybe there is a problem with the plotting?
I used the script below

import tofu as tf
import tofu.geom._GG as GG
import matplotlib.pyplot as plt
import numpy as np

def compute_min_max_r_and_z(ves_poly):
    r_min_max = np.array([np.min(ves_poly[0, :]), np.max(ves_poly[0, :])])
    z_min_max = np.array([np.min(ves_poly[1, :]), np.max(ves_poly[1, :])])
    return r_min_max, z_min_max

conf = tf.load_config('AUG')
part_radius = np.array([10e-6, 10e-6, 10e-6])
part_traj = np.array([[1.8, 0.01, 0.], [1.8, 0.01, -0.1], [1.8, 0.01, -1]],
                     order="F").T

kwdargs = conf.get_kwdargs_LOS_isVis()
ves_poly = kwdargs["ves_poly"]
rstep = zstep = phistep = 0.05
limits_r, limits_z = compute_min_max_r_and_z(ves_poly)
DR = None
DZ = None
DPhi = None
# -- Getting cython APPROX computation --------------------------------
res = GG.compute_solid_angle_map(part_traj, part_radius,
                                 rstep, zstep, phistep,
                                 limits_r, limits_z,
                                 DR=DR, DZ=DZ,
                                 DPhi=DPhi,
                                 block=True,
                                 limit_vpoly=ves_poly,
                                 **kwdargs,
                                 )
pts, sa_map, ind, reso_r_z = res

fig, axs = plt.subplots(1, 3, figsize=(15,15))
for pp in range(3):
    axs[pp].scatter(pts[0, :], pts[1, :],
                    marker="s", edgecolors="None",
                    s=10, c=sa_map[:, pp].flatten(),
                    vmin=sa_map[:, pp].min(),
                    vmax=sa_map[:, pp].max(),
                    )
    axs[pp] = conf.plot(lax=axs[pp], proj='cross', dLeg=None)
plt.show(block=True)

OK, so maybe it's the plotting then, thanks, I'll double-check !

You were right, the problem did not come from your routine.
It came from the intermediate routine that I wrote and that calls your routine, I was passing a non-closed vessel polygon to it, which triggered strange behaviour,
It is fixed now:

In [1]: import tofu as tf
/home/didier/Documents/Projects/tofu/tofu/__init__.py:93: UserWarning:
The following subpackages are not available:
	- tofu.imas2tofu
	- tofu.mag
  => see print(tofu.dsub[<subpackage>]) for details.
  warnings.warn(msg)

In [2]: conf = tf.load_config('AUG')

In [3]: part_traj = np.array([[1.8, 0.01, 0.], [1.8, 0.01, -0.1], [1.8, 0.01, -1]]).T

In [4]: part_radius = np.array([10e-6, 10e-6, 10e-6])

In [5]: ptsRZ, sang, indices, reseff, dax = conf.calc_solidangle_particle_integrated(part_traj=part_traj, part_radius=part_radius, resolution=0.05, vmax=False, approx=False)


Problem with tf.data.Dataset managing shapes of sparse tensors

Please go to Stack Overflow for help and support:
https://stackoverflow.com/questions/tagged/tensorflow
If you open a GitHub issue, here is our policy:

It must be a bug or a feature request.
The form below must be filled out.
It shouldn't be a TensorBoard issue. Those go here.

Here's why we have that policy: TensorFlow developers respond to issues. We want to focus on work that benefits the whole community, e.g., fixing bugs and adding features. Support only helps individuals. GitHub also notifies thousands of people when issues are filed. We want them to see you communicating an interesting problem, rather than being redirected to Stack Overflow.

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): 16.04.3 LTS (Xenial Xerus)
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): 1.5.0-dev20171224
Python version: 3.6
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version: N/A
GPU model and memory: N/A

Describe the problem
The tf-1.5-dev supports tf.SparseTensor when using tf.data.Dataset.from_tensor_slices, but it cannot infer the shape of new tensor after some operations such as tf.data.Dataset.map.
The shape of tensor becomes Unknown, which is troublesome for downstream operations. For example, we have to call set_shape() if we want to feed the new tensor into a tf.layers.dense.
Source code / logs

import tensorflow as tf
x = tf.SparseTensor([[0,0],[1,1],[2,2]], [1,1,1], dense_shape=[3,3])
ds = tf.data.Dataset.from_tensor_slices(x)
ds.output_shapes   # TensorShape([Dimension(3)])
ds = ds.map(lambda x: tf.sparse_tensor_to_dense(x))
ds = ds.batch(1)
ds.output_shapes   # TensorShape([Dimension(None), Dimension(None)])

iterator = ds.make_one_shot_iterator()
next_elem = iterator.get_next()   # TensorShape([Dimension(None), Dimension(None)])

y = tf.layers.dense(next_elem, 100)
ValueError: The last dimension of the inputs to `Dense` should be defined. Found `None`.

@mrry

Maybe you can get answer in strack overflow.

@Achencan I know that we can explicitly set the shape of new tensor via next_elem.set_shape([None, 3]).
But I do not understand why the last dimension becomes Unknown after tf.sparse_tensor_to_dense.

Please remove the assignee, as this issue is inviting external contributions. Otherwise, remove the contributions welcome label. Thank you.

Please remove the assignee, as this issue is inviting external contributions. Otherwise, remove the contributions welcome label. Thank you.

Please remove the assignee, as this issue is inviting external contributions. Otherwise, remove the contributions welcome label. Thank you.

Please remove the assignee, as this issue is inviting external contributions. Otherwise, remove the contributions welcome label. Thank you.

Please remove the assignee, as this issue is inviting external contributions. Otherwise, remove the contributions welcome label. Thank you.

Is there at least a workaround for this? I wrote a bunch of code for processing batches of SparseTensors where I carefully set the shape everywhere because every part can assume a static shape, and I'm now trying to figure out what I need to change because of this bug.

I hacked together a quick set_shape for SparseTensor in tensorflow/python/framework/sparse_tensor.py. I don't know if this is acceptable for merging into the  main Tensorflow code but I was basically desperate for something to use for my project.
Here's the relevant part:
  def get_shape(self):
    """Get the TensorShape representing the shape of the dense tensor.
    Returns:
      A TensorShape object.
    """
    if self.static_shape is not None:
      return self.static_shape
    else:
      return tensor_util.constant_value_as_shape(self._dense_shape)

  def set_shape(self, shape):
      """Updates the shape of this tensor.
      """
      if not isinstance(shape, tensor_shape.TensorShape):
        shape = tensor_shape.TensorShape(shape)
      self.static_shape = shape

And then I added the following into init:
self.static_shape = None

I know this is an old issue, but is there any progress towards official support for SparseTensor.set_shape?


attribute calculate_rel_locations

when to create data for 3D inversion I faced with error:
interp_mt_data.calculate_rel_locations() AttributeError: 'MTData' object has no attribute 'calculate_rel_locations'

@kashkoulimohammad could you provide the code you are using and the full traceback?


Add cover

Add cover on user header

I think that we should add contrast shadow to text to prevent blending text to image (white for black text and vice versa).


Game crash

Game crashed a couple of times after installing XIValex (been using the "load once" function all along until now). Might not be related to XIValex since I've had a few crashes ever since EW release, but I'm dropping you the log in case it's helpful idk. Cheers!
XivAlexander_20220201_004457_321.log

11000002 error almost always means that some mod has gone wrong.

Thanks for the heads up!


Support sharing resources between Android modules

Make Android modules be dependent on other Andorid/Java modules:

Calling methods
Using layouts
Using images

in build.gradle

dependencies {
              ...
                implementation project(':module4')
                // generated
                compile project(':androidAppModule1')

            }

And in activity
@Override
    public void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);

        // Set the layout for this activity.  You can find it
        // in res/layout/hello_activity.xml
        setContentView(R.layout.activity_main0);

        // generated source
        module1packageJava0.Foo0 zzz = new module1packageJava0.Foo0();
        zzz.foo0();

        // generated resources
        setContentView(com.androidAppModule1.R.layout.activity_main2);
    }

cc @NikitaKozlov

Is this what is currently generated?

This are my tests, to support it fully we need to upgrade the dependencies system

Oh, I see. You want us to generate this kind of code? But why then it calls setContentView twice?

This sis the minimal code I generated and updated by hand to understand the scope of generated code, thus setContentView twice is the minimal code to actually use resources from another Android module and activate relevant android gradle plugin mechanisms

https://github.com/borisf/android-studio-poet/pull/46

Done in "dev" branch


Codeium Auth not work on mac m3

NVIM v0.9.5
Macbook air m3
OS: sonoma

Since your post some updates have been done, maybe retry, ensuring that you do not have any extra white spaces.

@rwese Still not working. I have the same problem.   no white spaces


bugfix(TDI-38303): fix NPE exception for null values in azure...

... storage table
Dynamic table entity converters return null now for non existing or not
mapped key in azure storage table.
The converters was refactored to a group class and the creation of
converter to a factory
Please check if the PR fulfills these requirements

[x] The commit message follows Talend standard

What is the current behavior? (You can also link to an open issue here)
https://jira.talendforge.org/browse/TDI-38303
What is the new behavior?
Refer to the commit message above
Does this PR introduce a breaking change?

[ ] Yes
[x] Tests for the changes have been added (for bug fixes / features)
[x] No

Pull request test result: success :star:

thanks @gonchar-ivan for the review and the comments. i may do some further refactoring in an other PR


mounts: Add check for system volumes

We handle system directories differently, if its a bind mount
we mount the guest system directory to the container mount and
skip the 9p share mount.
However, we should not do this for docker volumes which are directories
created by Docker.

This introduces a Docker specific check, but that is the only
information available to us at the OCI layer.
Fixes #1417

Signed-off-by: Archana Shinde<EMAIL_ADDRESS>

@lifupan @bergwolf PTAL?

/retest

fixes https://github.com/kata-containers/runtime/issues/1472 ?


url_encoding: Use user name instead of email in personal_narrow_url.

This PR updates the urls for personal narrow sent in email notifications to be of form "{user_id}-{encoded_full_name}" to make it consistent with the urls that we use for such narrows in webapp which were recently updated in b4eddad for improving performance. We encode the full name in the same way that we do in webapp by replacing the url characters encoded by browser with "-".
Discussion - https://chat.zulip.org/#narrow/stream/6-frontend/topic/parseOneAddress.20perf/near/1455057

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

This sort of sort of algorithm change without any change in test output isn't great; can you add a small test suite for the function (or perhaps extend an existing test for one of it's callers, which I think are mostly in the email notifications/digests system, if that feels more appropriate)?

Merged, thanks @sahil839!


Added Gmail Policy Group 19

🗣 Description
Added Policy Group 19 Spam filtering group to the Gmail Baseline.
Fixes #149
💭 Motivation and context
Internal Discussion

🧪 Testing

✅ Pre-approval checklist

[ ] This PR has an informative and human-readable title.
[ ] Changes are limited to a single goal - eschew scope creep!
[ ] If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
[ ] The relevant issues PR resolves are linked preferably via closing keywords.
[ ] All relevant type-of-change labels have been added.
[ ] I have read and agree to the CONTRIBUTING.md document.
[ ] These code changes follow cisagov code standards.
[ ] All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
[ ] Tests have been added and/or modified to cover the changes in this PR.
[ ] All new and existing tests pass.

✅ Pre-merge Checklist

[ ] This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
[ ] Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

[ ] Delete the branch to clean up.
[ ] Close issues resolved by this PR if the closing keywords did not activate.

@adhilto I pushed the changes to the implementation steps.


WIP: Remove outdated benchmarking instructions.

Resolves #689
This PR removes the instructions for manually running the pyperf benchmarks from README.rst. It also fixes the tox environment (tox -e perf) for running the benchmarks, which was missing a dependency on twisted.

Merging, thanks!


usage import issue with vite named export 'sanitize' not found

I followed the usage example for import in a basic Astro project. Typescript is good with it and Astro seems good with it in dev mode until the page loads or refreshes. Then I get a 500 server error in devtools.
On the server side in the console I get
23:43:58 [ERROR] [vite] Named export 'sanitize' not found. The requested module 'isomorphic-dompurify' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from 'isomorphic-dompurify';
const {sanitize} = pkg;

As the hint in the terminal shows, if I do the following, it works
import DOMPurify from 'isomorphic-dompurify';

// either this way
const { sanitize } = DOMPurify;
const clean = sanitize(dirtyHTML);

// or this way
const clean = DOMPurify.sanitize(dirtyHTML);

I didn't know if this is an issue with exports in the package or vite or just need a note under the usage section. But wanted to let you know.

You're right @isimmons . I've just recently simplified the Usage section of the Readme and removed importing the entire module but it might be necessary in the browser. Will improve the Readme now according to your findings.

@isimmons Tried to reflect your findings here. Please take a look and let me know what you think.

@kkomelin Looks great to me. By the way, the package is working great in my use case. Thanks

@isimmons Thank you for your contribution!


Import error on Google Colab

Describe the bug
Cannot be imported on Google Colab, the import throws the following error:
ValueError: pyarrow.lib.IpcWriteOptions size changed, may indicate binary incompatibility. Expected 88 from C header, got 72 from PyObject
Steps to reproduce the bug

! pip install -U datasets
import datasets

Expected behavior
Should be possible to use the library
Environment info

datasets version: 2.17.0
Platform: Linux-6.1.58+-x86_64-with-glibc2.35
Python version: 3.10.12
huggingface_hub version: 0.20.3
PyArrow version: 15.0.0
Pandas version: 1.5.3
fsspec version: 2023.6.0

Hi! This can happen if an incompatible pyarrow version (pyarrow<12.0.0) has been imported before the datasets installation and the Colab session hasn't been restarted afterward. To avoid the error, go to "Runtime -> Restart session" after !pip install -U datasets and before import datasets, or insert the import os; os.kill(os.getpid(), 9) cell between !pip install -U datasets and import datasets to do the same programmatically.

One possible cause might be the one pointed out by @mariosasko above, and you get the following warning on Colab:
WARNING: The following packages were previously imported in this runtime:
  [pyarrow]
You must restart the runtime in order to use newly installed versions.

On the other hand, if the old version of pyarrow is not previously imported (before the installation of datasets), the reported issue here is not reproducible: datasets can be installed, imported and used on Colab.

Duplicate of:

#5923

Google Colab now pre-installs PyArrow 14.0.0, making this issue unlikely to happen. So, I'm unpinning it.


Exporting Book Sections as Inbook

Zotero items of type Book Section are exported by BBT's BibTeX exporter as incollection entries. It looks like BBT's BibTeX exporter doesn't use the inbook entry type. According to previous discussions (#282 and #877), BBT's BibLaTeX exporter uses inbook for book sections with book authors and incollection for book sections without book authors; it seems to me that the BibTeX exporter should export entries in the same way. Here's a debug-report ID with a relevant Book Section entry: FBHYQ2SX-euc.

:robot: this is your friendly neighborhood build bot announcing test build <IP_ADDRESS>81 ("dammit fs-extra!")
Install in Zotero by downloading test build <IP_ADDRESS>81, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

Thanks, I can confirm that the issue's resolved in the test build.

Thanks for the confirmation, merged.


Is there a way for mute warnings about missing translations?

Is there a way for mute warnings like:
warning: [R.swift] Strings file 'Localizable' (pt-BR) is missing translations for keys: 'some keys'?

Same problem. Anyone?

@mantovanirian Adding missing keys is not exactly a fix here.  It should be possible to mute missing key warnings as there is a natural delay between a string being introduced and its localization being available for all languages. Especially for projects that support a lot of locales!
There have been similar issues in the past that have asked for this exact functionality. See https://github.com/mac-cain13/R.swift/issues/496
That said there is some long running work going on in https://github.com/mac-cain13/R.swift/issues/136 that would eventually allow for this. My understanding is that its not a priority for the maintainers at the moment though.
I for one would second prioritizing this as I like to run a 0 warnings project and there is very little I can do about translations as a developer. Having the warnings is still great for checking production builds but makes for a lot of false positives during active development.
Just my 2 cents.
Best,
Caio

It's not very easy to create this and I also think the warning is correct. You as a developer should be aware the translation is missing, so it won't ship accidentally in a release for example.
0 warnings in a project is nice, but silencing a warning that is there and is correct is not the way to go in my opinion. So this is not something R.swift will support unless there is a use case for not always having all translations present that we haven't considered yet.

@mac-cain13 we use automated translation system, so we don't need to do this manually. The issue is in warnings, that we have while translation is in progress. But we have a decision to keep our project free of warnings. Is it possible to do something?

@mac-cain13 we use automated translation system, so we don't need to do this manually. The issue is in warnings, that we have while translation is in progress. But we have a decision to keep our project free of warnings. Is it possible to do something?

For anyone finding this later, here's a workaround. Instead of using
"$PODS_ROOT/R.swift/rswift" generate "$SRCROOT/R.generated.swift"

use this:
set -o pipefail
"$PODS_ROOT/R.swift/rswift" generate "$SRCROOT/R.generated.swift" | (grep -v "warning: \\[R.swift\\] Strings file '[^']*' ([a-zA-Z0-9_]*) is missing translations for keys" || true)


COSMIC NEWER VERSION SUPPORT(v94 and later)

Version info

bcbio version :1.2.9
OS name and version :Ubuntu 20.04.5 LTS

To Reproduce
Exact bcbio command you have used:
bcbio_python  prepare_cosmic.py 94  ~/

Log files (could be found in work/log)
`2023-02-13 14:22:35,700 [I] Beginning COSMIC v94 prep for GRCh37.
2023-02-13 14:22:35,700 [I] Beginning COSMIC v94 prep for GRCh38.
2023-02-13 14:22:35,700 [I] Downloading COSMIC VCF files.
2023-02-13 14:22:35,700 [I] Downloading https://cancer.sanger.ac.uk/cosmic/file_download/GRCh38/cosmic/v94/VCF/CosmicCodingMuts.vcf.gz
2023-02-13 14:25:13,610 [I] Downloading https://cancer.sanger.ac.uk/cosmic/file_download/GRCh38/cosmic/v94/VCF/CosmicNonCodingVariants.vcf.gz
2023-02-13 14:26:18,927 [I] Sorting v94/GRCh38/CosmicCodingMuts.vcf.gz to match the order of /home/data/bcbio/genomes/Hsapiens/hg38/seq/hg38.fa.

gsort version 0.1.4
[W::vcf_parse] Contig 'chr1' is not defined in the header. (Quick workaround: index the file with tabix.)
[E::vcf_format] Invalid BCF, CONTIG id=0 not present in the header
[flush_buffer] Error: cannot write to -
Failed to read from standard input: unknown file type
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x546d43]
goroutine 1 [running]:
bufio.NewReaderSize(...)
/home/brentp/go/src/bufio/bufio.go:49
bufio.NewReader(...)
/home/brentp/go/src/bufio/bufio.go:62
github.com/brentp/gsort.Sort(0x7ad380, 0x0, 0x7ad3a0, 0xc00061bb00, 0xc00061bac0, 0xaf0, 0x0, 0x0, 0x0)
/home/brentp/go/go/src/github.com/brentp/gsort/gsort.go:116 +0x63
main.main()
/home/brentp/go/go/src/github.com/brentp/gsort/cmd/gsort/gsort.go:373 +0x513
Failed to read from standard input: unknown file type
2023-02-13 14:26:19,012 [I] bgzipping and indexing v94/GRCh38/CosmicCodingMuts-prep.vcf.gz.
2023-02-13 14:26:19,058 [I] Sorting v94/GRCh38/CosmicNonCodingVariants.vcf.gz to match the order of /home/data/bcbio/genomes/Hsapiens/hg38/seq/hg38.fa.
gsort version 0.1.4
[W::vcf_parse] Contig 'chr1' is not defined in the header. (Quick workaround: index the file with tabix.)
[E::vcf_format] Invalid BCF, CONTIG id=0 not present in the header
[flush_buffer] Error: cannot write to -
Failed to read from standard input: unknown file type
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x546d43]
goroutine 1 [running]:
bufio.NewReaderSize(...)
/home/brentp/go/src/bufio/bufio.go:49
bufio.NewReader(...)
/home/brentp/go/src/bufio/bufio.go:62
github.com/brentp/gsort.Sort(0x7ad380, 0x0, 0x7ad3a0, 0xc000629d40, 0xc000629d00, 0xaf0, 0x0, 0x0, 0x0)
/home/brentp/go/go/src/github.com/brentp/gsort/gsort.go:116 +0x63
main.main()
/home/brentp/go/go/src/github.com/brentp/gsort/cmd/gsort/gsort.go:373 +0x513
Failed to read from standard input: unknown file type
2023-02-13 14:26:19,137 [I] bgzipping and indexing v94/GRCh38/CosmicNonCodingVariants-prep.vcf.gz.
2023-02-13 14:26:19,175 [I] Combining COSMIC files to v94/bcbio_ready/hg38/cosmic.vcf.gz.
INFO	2023-02-13 14:26:19	MergeVcfs
********** NOTE: Picard's command line syntax is changing.

********** For more information, please see:

https://github.com/broadinstitute/picard/wiki/Command-Line-Syntax-Transition-For-Users-(Pre-Transition)

********** The command line looks like this in the new syntax:

**********    MergeVcfs -O v94/bcbio_ready/hg38/cosmic.vcf.gz -D /home/data/bcbio/genomes/Hsapiens/hg38/seq/hg38.dict -I v94/GRCh38/CosmicCodingMuts-prep.vcf.gz -I v94/GRCh38/CosmicNonCodingVariants-prep.vcf.gz -USE_JDK_DEFLATER true -USE_JDK_INFLATER true -CREATE_INDEX false

[Mon Feb 13 14:26:19 CST 2023] MergeVcfs INPUT=[v94/GRCh38/CosmicCodingMuts-prep.vcf.gz, v94/GRCh38/CosmicNonCodingVariants-prep.vcf.gz] OUTPUT=v94/bcbio_ready/hg38/cosmic.vcf.gz SEQUENCE_DICTIONARY=/home/data/bcbio/genomes/Hsapiens/hg38/seq/hg38.dict CREATE_INDEX=false USE_JDK_DEFLATER=true USE_JDK_INFLATER=true    VERBOSITY=INFO QUIET=false VALIDATION_STRINGENCY=STRICT COMPRESSION_LEVEL=5 MAX_RECORDS_IN_RAM=500000 CREATE_MD5_FILE=false GA4GH_CLIENT_SECRETS=client_secrets.json
[Mon Feb 13 14:26:19 CST 2023] Executing as bcbio@dell-PowerEdge-R7525 on Linux 5.15.0-46-generic amd64; OpenJDK 64-Bit Server VM 1.8.0_332-b09; Deflater: Jdk; Inflater: Jdk; Provider GCS is not available; Picard version: 2.27.5
[Mon Feb 13 14:26:19 CST 2023] picard.vcf.MergeVcfs done. Elapsed time: 0.00 minutes.
Runtime.totalMemory()=514850816
To get help, see http://broadinstitute.github.io/picard/index.html#GettingHelp
Exception in thread "main" htsjdk.tribble.TribbleException$MalformedFeatureFile: Unable to parse header with error: Your input file has a malformed header: We never saw the required CHROM header line (starting with one #) for the input VCF file, for input source: file:///home/data/bcbio/cosmic-prep/v94/GRCh38/CosmicCodingMuts-prep.vcf.gz
at htsjdk.tribble.TabixFeatureReader.readHeader(TabixFeatureReader.java:97)
at htsjdk.tribble.TabixFeatureReader.(TabixFeatureReader.java:82)
at htsjdk.tribble.AbstractFeatureReader.getFeatureReader(AbstractFeatureReader.java:117)
at htsjdk.tribble.AbstractFeatureReader.getFeatureReader(AbstractFeatureReader.java:81)
at htsjdk.variant.vcf.VCFFileReader.(VCFFileReader.java:145)
at picard.vcf.MergeVcfs.doWork(MergeVcfs.java:182)
at picard.cmdline.CommandLineProgram.instanceMain(CommandLineProgram.java:309)
at picard.cmdline.PicardCommandLine.instanceMain(PicardCommandLine.java:103)
at picard.cmdline.PicardCommandLine.main(PicardCommandLine.java:113)
Caused by: htsjdk.tribble.TribbleException$InvalidHeader: Your input file has a malformed header: We never saw the required CHROM header line (starting with one #) for the input VCF file
at htsjdk.variant.vcf.VCFCodec.readActualHeader(VCFCodec.java:119)
at htsjdk.tribble.AsciiFeatureCodec.readHeader(AsciiFeatureCodec.java:79)
at htsjdk.tribble.AsciiFeatureCodec.readHeader(AsciiFeatureCodec.java:37)
at htsjdk.tribble.TabixFeatureReader.readHeader(TabixFeatureReader.java:95)
... 8 more
Traceback (most recent call last):
File "prepare_cosmic.py", line 246, in
main(args.cosmic_version, args.bcbio_directory, args.overwrite, args.clean)
File "prepare_cosmic.py", line 62, in main
ready_cosmic = combine_cosmic(sorted_inputs, bcbio_ref, out_file)
File "prepare_cosmic.py", line 153, in combine_cosmic
subprocess.check_call(cmd)
File "/home/data/bcbio/anaconda/lib/python3.7/subprocess.py", line 363, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['picard', 'MergeVcfs', 'O=v94/bcbio_ready/hg38/cosmic.vcf.gz', 'D=/home/data/bcbio/genomes/Hsapiens/hg38/seq/hg38.dict', 'I=v94/GRCh38/CosmicCodingMuts-prep.vcf.gz', 'I=v94/GRCh38/CosmicNonCodingVariants-prep.vcf.gz', 'USE_JDK_DEFLATER=true', 'USE_JDK_INFLATER=true', 'CREATE_INDEX=false']' returned non-zero exit status 1.
`
I have also tried COSMIC version 93 and earlier versions such as v90 , but it seems the VCF files are not available anymore for these versions. Furthermore, for version from v94 on, though the vcf files could be downloaded successfully, the following process always halted because of error:
Contig 'chr1' is not defined in the header. (Quick workaround: index the file with tabix.)
I assume format changes occurred to these newer versions of vcf files. Could you please update the bcbio_nextgen.py script so as to avoid such bugs? Thanks ~

I looked through the python script to prepare cosmic.vcf.gz for hg38 manually. Interestingly, I found the problem arises at the CMD bcftools norm --check-ref s --do-not-normalize -f {ref_file} , which fails because the COSMIC.pre.vcf does not contain contig information in its header, similar to the problem described here: https://github.com/samtools/bcftools/issues/766. So, I tried bgip the COSMIC.pre.vcf and tabix it,  and then the following steps went well until bcftools view -e 'SNP=1'. But if you skip this cmd, you can finally run through all commands.
So my queston is  the step bcftools view -e 'SNP=1' important for annotation? And how could we fix this problem? I didn't see any info regarding "SNP" in the header of the original COSMIC.vcf files, possibly due to the updated version.

That command excludes the known SNPs (non-tumor) from the COSMIC data. I believe they don't ship these variants anymore, though.

Yeah , so I skipped this step as well.  I manually prepared vcf files of CodingVariants and NonCodingVariants separately. This time, the problem arises when I tried to merge the above two vcf files with error indicating that the contigs of them are not compatible. It is strange that even if I normalized according to the same reference genome, the contigs of NonCodingVcf is ordered as "chr1, chr2, chr3, chr 4....." while the CodingVcf  is ordered as "chr1, chr10, chr11, chr12....chr2, chr22..."

I cannot figure out what is wrong

Did you try reordering the contigs so they all have the same order?

Thanks for your advice, I may try this later. But it still confused me how come different orders are given after the same operation(exactly the same gunzip-normalize-gsort process as is shown below)
`gunzip -c CosmicNonCodingVariants.vcf.gz  | sed "s/^([0-9]+)\t/chr\1\t/g" | sed "s/^MT/chrM/g" | sed "s/^X/chrX/g" | sed "s/^Y/chrY/g"  > CosmicNonCodingVariants-fix-chrom.vcf.gz
bgzip -c CosmicNonCodingVariants-fix-chrom.vcf.gz  > CosmicNonCodingVariants-fix-chrom-bgzip.vcf.gz
tabix CosmicNonCodingVariants-fix-chrom-bgzip.vcf.gz
bcftools norm --check-ref s --do-not-normalize -f /home/data/bcbio/genomes/Hsapiens/hg38/seq/hg38.fa  CosmicNonCodingVariants-fix-chrom-bgzip.vcf.gz > CosmicNonCodingVariants-fix-chrom-bgzip-norm.vcf.gz
##Lines   total/split/realigned/skipped:	32580266/0/0/0
##REF/ALT total/modified/added:  	32580266/0/318
gsort --memory 20000 CosmicNonCodingVariants-fix-chrom-bgzip-norm.vcf.gz /home/data/bcbio/genomes/Hsapiens/hg38/seq/hg38.fa.fai > CosmicNonCodingVariants-fix-chrom-bgzip-norm-gsort.vcf.gz
grep -v ^##contig  CosmicNonCodingVariants-fix-chrom-bgzip-norm-gsort.vcf.gz
| bcftools annotate -h ./v97/GRCh38/CosmicNonCodingVariants-fix-chrom-bgzip-norm-gsort-contig_header.txt
bgzip -c CosmicNonCodingVariants-fix-chrom-bgzip-norm-gsort.vcf.gz > CosmicNonCodingVariants-prep.vcf.gz
tabix CosmicNonCodingVariants-prep.vcf.gz
mv CosmicNonCodingVariants-fix-chrom-bgzip-norm-gsort-contig_header.txt  CosmicNonCodingVariants-prep-contig_header.txt
`


Name commands

We want to make sure that the commands and the names of the commands make sense. I'm looking at making several changes from build-releases. As always, naming is hard. Feedback would be appreciated.
Current binary is build-releases, so commands are build-releases [command].
New binary will be changesets, so commands are changesets [command]
Current commands are:

initialize: get changeset default config set up, and create the .changeset dir
changeset: add a new changeset
version: consume changesets and update package versions
publish: publish any packages that need it (effectively just bolt publish)

Simple changes

initialize to init

Reasoning: init is more standard.

changeset to add

Since the base command is now changeset, add is now used to generate a new one
Annoying changes
version and publish were originall introduced as names for bolt commands, which would mean they can mirror npm (and yarn) command names, since the global bolt will intercept them, so running bolt version or bolt publish would always be fine.
Changesets are not set up to be installed globally so you tend to create a package script to make running them easier. The most obvious choice is to include a command of the same name. For example:
"changeset": "build-releases changeset",
"version": "build-releases version",
"publish": "build-releases publish",

If you run yarn version however, it will run yarn's version command before looking for package scripts, which is a massive nonbo. So I want to rename both of these.
I want to rename publish to release, which I think is fairly obvious.
version is giving me grief.
Leading candidate is consume, which is very logical once you understand changesets, but is non-obvious when learning the tool in the way that version was. update makes it unclear if it will update a changeset or packages. update-packages might be the best, but doesn't sound good for single-repo use of changesets, and is still not amazingly clear.
So tentative new name suggestions are:

initialize => init
changeset => add
version => consume
publish => release

Bad other option is encourage people to globally install it and then overwrite npm/yarn namespaces

Possible options off the top of my head for version:

changesets bump
changesets bump-versions
changesets process
changesets run
changesets commit
changesets build
changesets compile
changesets prepare
changesets prepare-release
changesets release prepare
changesets pre-release

All the other renamings sound great 👍

changeset to add

This makes complete sense to me on the surface if I was running yarn changeset add but having package scripts is generally what people end up doing. So with add, what would be the encouraged thing to with npm scripts, would you have a script called changeset:add?
What if the changeset add command existed but just running changeset would be equivalent to it, similar to how just running yarn is equivalent to yarn install. I think that it'd be nice since the majority of people interacting with changesets will only be adding a changeset so IMO, we should optimize for that case.

Good point on optimising for how people will actually be using these (which I got halfway to). Agree that calling changeset without a command can just run add, even if there's also an add script.
"changeset": "changesets",
"consume-changesets": "changesets consume",
"release": "changesets release"

Alt take would be:
"changeset": "changesets",
"changeset:consume": "changesets consume",
"changeset:release": "changesets release"

but I feel people will shortcut the second to (or, I know I would)
Other point @mitchellhamilton accidentally brings up, is the base command changeset or changesets. I guess singular is more common for binaries?

Released as of @changesets/cli 1.0.1


Why all the delegates are multicast?

"The original design considered making a distinction between delegates where only one target method could be attached and invoked, and delegates where multiple target methods could be attached and invoked. That distinction proved to be less useful in practice than originally thought."
I think it's worth to provide more details here. At least conceptually, a multicast delegate that returns some value doesn't make very much sense. In such case, the return value is the one returned by the last element in the invocation list.
To me it seems that the effort spent to make this mechanism type safe contrasts with the decision of having such delegate returning a "casual" value.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1dcd91a4-603a-feb9-cff2-94f1985417fc
Version Independent ID: a86cde90-1eba-e1d5-2b42-2a3cd37f5499
Content: System.Delegate and the delegate keyword
Content Source: docs/csharp/delegate-class.md
Product: dotnet-csharp
Technology: csharp-fundamentals
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

Thank you for opening this issue. I'll add it to the backlog. If you would like to contribute, you can submit a fix by editing the original article. Click on the Content Source link at the bottom of your original comment. To learn how to edit, see the Editing files in a repository article from GitHub.
Thanks again!


DBZ-7364 Distribute Oracle ojdbc8 with Oracle connector

https://issues.redhat.com/browse/DBZ-7364

@Naros Applied, thanks


travis: sudo: true, to gain 4G of RAM, as per @domenkozar suggestion to fix #24200

Motivation for this change
#24200

We could instead set sudo to true, so that machine would have 7G of ram: https://github.com/NixOS/nixpkgs/blob/master/.travis.yml#L5

I don't understand why @matthewbauer switched to container based infrastructure in 95b28da3536, but it did decrease ram significantly. Maybe that should be noted as a comment.

travis docs about this: https://docs.travis-ci.com/user/ci-environment/#Virtualization-environments

@domenkozar, added this:
# 'sudo: false' == containers that start fast, but only get 4G ram;
# 'sudo: true'  == VMs that start slow, but with 8G
# ..as per:  https://docs.travis-ci.com/user/ci-environment/#Virtualization-environments
# Nixpkgs PR tests OOM with 4G: https://github.com/NixOS/nixpkgs/issues/24200

Line 11 should be sudo: required so PR additional line is not needed.

Citing @edolstra wrt memory usage here: https://github.com/NixOS/nix/issues/421#issuecomment-67465452

You can tell Nix to garbage-collect more aggressively:
GC_INITIAL_HEAP_SIZE=128k nix-env -qa
With this, nix-env -qa takes 235 MB on my laptop. (Without it, 471 MB.)
You can also do:
echo 1 > /proc/sys/vm/overcommit_memory
That should make the fork error go away.

GC_INITIAL_HEAP_SIZE=128k nix-env -qa

May help with -qa, but eval-release.nix wants >4GiB virtual address
space even with this option set.

echo 1 > /proc/sys/vm/overcommit_memory

Which requires root anyway, right?

It seems to work again:
error: undefined variable ‘fetchPypi’ at /home/travis/build/NixOS/nixpkgs/pkgs/development/python-modules/btrees/default.nix:10:9
(use ‘--show-trace’ to show detailed location information)


pull request for e2e test at 01/15/2017 04:15:07

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Path and Readonly status of volumes missing from START payload

When we mount a ceph volume into an instance we have the option to specify whether that container should be readonly or not.    Both QEMU and docker allow us to specify that a drive or volume should be read only so there's no technical reason not to support this.
Docker also allows us to specify where a volume should be mounted.  Currently, volumes are mounted inside the container at /volumes/, but it would probably be easier for end users if they had more control over this.
I don't think it's possible to control the device name a ceph volume gets inside a qemu instance but we can check.
Anyway, our new payload might look something like this.
start:
  ...
  storage:
        id: 67d86208-000-4465-9018-fe14087d415f
        mode: ro
        boot: false
        mount: /media/ceph/images

Qemu's got:
{code}
-drive index=N
{code}
which could control or at least influence the location of the device inside the VM.  If launcher can control the location of the device node in the virtual machine, then launcher could insert a cloud-init mount command to match that device node to a "mount: path" from the start payload.
This maps loosely with the volume extensions I'm making in issue #387 and #373 for OpenStack's block-device-mapping-v2.  I've not got a strict requirement for it, but I may include a "ReadOnly bool" flag as it could make implementing some of the flows for block-device-mapping-v2 easier if that's explicitly set.

Based on recent discussions on IRC I think the direction we're headed is to leave mounting up to the user (eg: via their cloud-init config or other automation) and not duplication the read-only status (eg: leave that up to RBD).  @rbradford do you agree?  If so, is there anything else preventing closing this issue?

I think ro/rw and mount path still make sense for containers.  For containers, launcher has to do the mounting before the container is started.  It would be nice if users had a way to configure how and where the volumes get mounted.

Ah ok docker for example has a rich set of command line options on the host for this https://docs.docker.com/engine/tutorials/dockervolumes/ and it makes sense that we'd need to orchestrate something like that and articulate it in the workload definition, through the start payload, out to launcher.


[Identity] Validate identity config for MICredential

Closes: https://github.com/Azure/azure-sdk-for-python-pr/issues/920

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-identity


Create an instance of Client class without username/password

This will be a guest user, no token needed.
If not parameter set and not environment variable then create the client without a token.

This may deserve its own issue, but it might also be a good idea to start thinking about more conventional ways of storing user credentials. Is storing them in environment variables secure enough? I'm not sure.
I've also been thinking lately that the current way of logging in might leave the user's password too exposed (if not stored in environment variables, the user has to type their credentials in plain text in the python code).

I think we should remove the environment variables.

Resolved with #137


gem: init at 2020-03-26

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@doronbehar thanks for the review - updated!

Oh and you can mark all previous conversations as "resolved"

Oh and you can mark all previous conversations as "resolved"

Sure, I didn't know if the etiquette would be to mark them 'resolved' myself or leave that up to the reviewer :)

Sure, I didn't know if the etiquette would be to mark them 'resolved' myself or leave that up to the reviewer :)

The weirdest thing is that I can't mark them as resolved :)...

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/195

/marvin opt-in
/state needs_merger

/status needs_merger

perhaps @magnetophon or @cillianderoiste would like to do a review to push this over the finish line?

@raboof It builds, but IDK how to test it.

For who wants to test, with the following shell.nix:
{ pkgs ? import <nixpkgs> {} }:

pkgs.mkShell {
  buildInputs = [
    (pkgs.puredata-with-plugins [ pkgs.gem ])
  ];
}

you can run pd -lib Gem and then open the examples in /nix/store/63j4zw6y7z58ajm84bxcxw7s75nid18b-gem-unstable-2020-03-26/lib/pd/extra/Gem/ . Most of them have a 'create' message you can click to create the GEM window.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/194

Thanks!


Refactor the example to make a better extendable structure

At the moment the samples are not well structured and named. Need to give more samples together with code and preferably present them using github or via other means as well.

There is now one big page in tutorial format:
you can start the sample using grunt:
grunt devserver
Than open your browser to localhost:8888


Extension causes high cpu load

Issue Type: Performance
Extension Name: intellicode-api-usage-examples
Extension Version: 0.1.1
OS Version: Windows_NT x64 10.0.22000
VS Code version: 1.68.1

:warning: Make sure to attach this file from your home-directory:
:warning:file:///c%3A/Users/aldii/AppData/Local/Temp/VisualStudioExptTeam.intellicode-api-usage-examples-unresponsive.cpuprofile.txt
Find more details here: https://github.com/microsoft/vscode/wiki/Explain-extension-causes-high-cpu-load

@royal45mts could you attach the file at the directory above?

@royal45mts feel free to reopen this issue by attaching the logs at the filepath noted above if you're still experiencing issues


Added Task 2

Issue: #2
Added Command and Screenshots

It's two different tasks.
One command should for accessing super user, i.e logging in as the super user.
The second one is modifying a file permission to make it an executable.

Since there has been no update for quite some time, I'll be closing the PR.


How does the SBE retrieve the number of messages/dlq messages on a SB topic

I have an issue where the SB monitoring on Azure and other places sometimes does not provide the accurate number of messages sitting on a SB topic. Specifically, if the number of messages is low (but not 0), Azure will sometimes say that there are no messages. However, the ServiceBusExplorer has so far always been accurate, so my assumption is that it uses a different way to query the status of the SB.
Could you please point me to the code where this query is done? Then I can see whether I can use the same one for my project. Thanks :)

Azure monitor is using metrics that might be behind by a couple of minutes where SBE is using the SDK (legacy) to query that information in real-time.

It retrieves the message count in multiple places, one place is the method GetMessageCount in the QueueServiceBusPurger class. That uses the SDK track 2, which is the latest and recommended SDK.
There are also other places where the messages count is retrieved but some of them use the SDK track 0, which should be avoided.

Awesome, thanks @SeanFeldman and @ErikMogensen !


Returns True when passed a windows path that includes ().

For example, anything under C:/Program Files (x86)/

I just tested the pattern and it returns false. It should only return true for parentheses when preceded by an extglob character, or when the pattern is a regex or (e.g. (a|b))

My apologies. It looks like the version being required (by whatever package is requiring it) is only version 2.0 and is way more simplistic in its tests.

no worries, thanks for the follow up


Added quick-guide

I think we can remove everything about "quick guide" (in file names and text) since this will be our main submission guide. I also noticed that the markdown and html quick guide files dit not match in content.
After this PR has been merged, I will create another with changes to the text associated  with each step.


feat(WIP): alter fulltext options

I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#4395
What's changed and what's your intention?
As in #4637, support alter fulltext options for column:
ALTER TABLE monitor SET COLUMN <column_name> FULLTEXT WITH(analyzer = 'Chinese', case_sensitive = 'false');
Currently we only support to change the fulltext option when:

Enable to disable
Disable to enable / disable (no effect actually)

TODO: Test
Big thanks to @irenjj for his previous pr #4637 which helps a lot.
Checklist

[ ] I have written the necessary rustdoc comments.
[ ] I have added the necessary unit tests and integration tests.
[ ] This PR requires documentation updates.

Seems too big for a single pr... I'll try to split it  later.


Removal of <: Singleton and usages

mset and hmset were broken due to the presence of type XString = String <: Singleton and its attempted usage via type SingletonKey[A <: XString] = A Refined NonEmpty

Codecov Report

Merging #63 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #63   +/-   ##
=======================================
  Coverage   22.84%   22.84%
=======================================
  Files          33       33
  Lines         950      950
  Branches       18       16    -2
=======================================
  Hits          217      217
  Misses        733      733

Impacted Files
Coverage Δ

core/src/main/scala/laserdisc/package.scala
52.17% <ø> (ø)
:arrow_up:

core/src/main/scala/laserdisc/protocol/HashP.scala
0% <ø> (ø)
:arrow_up:

...re/src/main/scala/laserdisc/protocol/StringP.scala
0% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f5f9d9...e22a1c6. Read the comment docs.


docs: Implement SDS colors for dark mode

Implements basic colors to be consistent with SDS.

Sorry, my mistake.


Day 1 question about 'Greater than symbol" (>)

[I learned that = can be generated in a printf statement by using ==, likewise % by using %%. When trying to generate a single ">" in text it errored out, same with ">>" . Searching for solutions brought me to this shift operators page & thought instead of continuing the search, I'd pause to give the following feedback: it might be a courtesy to include somewhere on the page . . . something to the effect of "If you're trying to include a '>' while using printf (like emulating a terminal prompt) you would need to use (enter the format) & possibly provide a link to a more comprehensive list of these types of exceptions).]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 02b8f7c2-379e-7876-0d36-25b06a294baa
Version Independent ID: 2410c828-0c66-9efe-ae87-9b07708aa731
Content: Bitwise and shift operators - perform boolean (AND, NOT, OR, XOR) and shift operations on individual bits in integral types
Content Source: docs/csharp/language-reference/operators/bitwise-and-shift-operators.md
Product: dotnet-csharp
Technology: csharp-language-reference
GitHub Login: @pkulikov
Microsoft Alias: wiwagn

Hi @johngrund
Can you answer some questions for me before I determine how to address this.
You mention `printf``. That function is part of the C runtime library. This page is for the C# programming language. I'd like to know what search terms you were using. If you are working in C or C++, searches should not have ranked these pages very high.
If you are working in C#, I'm curious how you ended up looking for printf, as that doesn't apply in C#.


Buildsystem: Let cmake determine Endianess

At the moment you have to set endinaness yourself. A least for the examples this can be automated and make the examples compile on more architectures without changes to any files.

Fixed by #128


some docstrings

Add docstring to top-level ipywidgets module and the integer widgets.
I think there are a lot more docstrings we need to add/improve, but this is a start.
closes #275

Thanks min!

Sent a PR - https://github.com/minrk/ipywidgets/pull/2

Thanks, @jdfreder!

Thanks so much, folks!!


Document how managedPaths differs from immutablePaths

Feature to document
snapshot.managedPaths: https://webpack.js.org/configuration/other-options/#managedpaths.
https://github.com/webpack/webpack/pull/14509
Author(s)
@sokra
Additional information
It is not at all clear from the current documentation how managedPaths differs from immutablePaths. The documention for managedPaths just says:

An array of paths that are managed by a package manager and can be trusted to not be modified otherwise.

What does "otherwise" mean? Is there something which will trigger webpack to invalidate the cache for these files? If so, what? If not, how does this option differ from immutablePaths?

I would love to understand the same.
You might be able to glean something from https://github.com/webpack/changelog-v5/blob/master/guides/persistent-caching.md#performance-optimizations


Util.GetTokensAtPosition edge cases

currentToken is often null mid-line in my testing.  As i understand it, a single character token will have StartIndex == StopIndex which means it can never be a current token.  Whenever this happens, leftToken ends up being the last token, even if the cursor is at the start of the line, messing with when RustCompletionCommandHandler triggers intellisense.
I'm inclined to do the following refactorings:

Add Utils.GetIdentTokenAtPosition for use in e.g. RustF1HelpCommandHandler and RustGoToDefinitioncommandHandler, which will return the ident if the cursor is in either | position in e.g. the expression: a |ident| b, (|ident|), etc. despite the left/current tokens being [whitespace, ident] in one case and [ident, whitespace] in the other.

Replace GetTokensAtPosition with GetLineTokensBeforePosition? returning IEnumerable<IToken> or IList<IToken>, so we can still avoid triggering intellisense on e.g. let f, which requires multiple tokens of lookbehind in RustCompletionCommandHandler.

GetIdentTokenAtPosition is a bad idea - RustF1HelpCommandHandler wants to handle more than ident tokens, best to leave the filtering of what tokens the caller wants up to the caller.
That said, I am changing/replacing the behavior of GetTokensAtPosition (possibly with a rename) such that ide|nt returns the same token for both left/right (whereas foo |ident will return the whitespace and ident tokens)

My take on fixing: https://github.com/MaulingMonkey/VisualRust/commit/7b9f314a6db4d54a2afff6942cdb3d758fb5a552

Closing this as it's part of my pull request.


Revert ad45f0e, which breaks :CommandT with a path argument

I noticed that all of my custom mappings to do CommandT in subdirectories broke after pulling master. I bisected and found that this commit broke it:
ad45f0e  (3 months)              Moved some functions around
By the commit message, I assume that this change was not intentional. Reverting fixes the bug, which seems like the right short-term solution since it was only a refactoring.

It's merged. Thanks once again.