Take a crack at Issue #1401

This has a couple of issues at the moment, namely, it seems to be finding the dependency charts underneith every other chart. I'm not sure on how to fix that, though, but figured I'd get the PR up and running, to consult you guys on that.

I appear to have made a mess of my git history with an ill-advised --amend ( thought I had already committed a previous iteration) -- however I assume that won't matter, as there will be a squash, like is done with kubernetes/charts
Anyway, got this passing tests locally, and it's also producing the correct output for my (multi-level) repo -- so I'm happy with this.
If requested, I'll try and wrangle in some tests sometime tomorrow (Monday 2017-02-20)

Michelle has been out on vacation, but she let me know that she is going to review this. Sorry for the delay.

I'll try and take a look this weekend, been feeling pretty burnt out so
I've been taking a break from server related stuff, but I'm still very
interested in getting this merged.
On Mon, Feb 27, 2017, 17:56 Michelle Noorali<EMAIL_ADDRESS>wrote:

@michelleN requested changes on this pull request.
In cmd/helm/package.go
https://github.com/kubernetes/helm/pull/1997#discussion_r102981624:

@@ -121,8 +122,8 @@ func (p *packageCmd) run(cmd *cobra.Command, args []string) error {
}
}

if filepath.Base(path) != ch.Metadata.Name {

return fmt.Errorf("directory name (%s) and Chart.yaml name (%s) must match", filepath.Base(path), ch.Metadata.Name)

if !strings.HasSuffix(path, ch.Metadata.Name) {

return fmt.Errorf("directory name (%s) and Chart.yaml name (%s) must match", path, ch.Metadata.Name)

This change does not ensure that the directory name and the name field
inside the Chart.yaml file actually match. For example, if I package a
chart under the directory somethingnginx/ and the name inside the
Chart.yaml file is nginx, then this error will not be thrown.
I don't believe that is the behavior we want unless I am mistaken.
In pkg/repo/index.go
https://github.com/kubernetes/helm/pull/1997#discussion_r102985004:

@@ -218,9 +218,18 @@ func IndexDirectory(dir, baseURL string) (*IndexFile, error) {
if err != nil {
return nil, err
}

moreArchives, err := filepath.Glob(filepath.Join(dir, "**/*.tgz"))

hey @AmandaCameron https://github.com/AmandaCameron would you mind
adding a test scenario for this chunk?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/helm/pull/1997#pullrequestreview-23758080,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAG_zp8XSHBsqXSpYyHkmnu6iJNIIO6Mks5rg1RmgaJpZM4MFmRN
.

Sorry this took so long for me to come back around to, It looks like the only issue circleci had was that a few files weren't gofmt'd, which I fixed, and I believe the changes I did to the _test.go in c908cf3 should address @michelleN's comment, so this should just need a rebase and it should be good, I think.

@AmandaCameron I believe @michelleN is out this week, but when she comes back she will review this.

@michelleN circling back on this so we can get it merged.
@AmandaCameron can you rebase this on master? That may fix the test failure

hey @AmandaCameron - this branch is passing locally for me so I just kicked off a rebuild on circle. Let's see how that goes.

Hey Amanda,
If we're going forward with making the local directory structure the source of truth for the url path, then we'll need to change repo.IndexDirectory(dir, url) to recursively traverse the directory structure starting with dir, grab all charts in each directory and add it to the IndexFile here: https://github.com/kubernetes/helm/blob/master/pkg/repo/index.go#L224-L249

This line here what does the actual recursion, the **/*.tgz is shell glob syntax for "Every directory under this folder and every directory under it, with a filename matching *.tgz, if that makes sense.

This PR has been sitting out for a few months. Do we still want to move forward with this? @michelleN

FWIW I'm definately still interested in getting this merged.
I'm not sure if I'm misunderstanding the feedback I was given, or if my replies aren't understood, but it definately feels like there's some miscommunication happening between myself and @michelleN and as a result I'm not entirely sure how to proceede, this is probably one of the first contributions I've made to a large, living project like this, so I'm not entirely sure on the etiquite and such that is involved.

Reviewing it now.

hey @AmandaCameron -
I set up a test scenario for this PR but it didn't work as expected. Let me know if I'm doing something wrong here. I created a directory called charts/. I created another directory inside of charts/ called nestedCharts/. I placed one chart inside of charts/ and two charts inside of charts/nestedCharts. I then ran the index command and got an empty index.yaml file. Am I doing something wrong setting up the scenario here?

Hey Amanda,
I set up a test scenario but it didn't go as expected. I created a directory called charts/ and a directory inside of charts/ called nestedDirectory/. I placed a chart in the charts/ dir and two charts inside of charts/nestedDirectory/ and then ran the index command but got back an empty index file. Am I doing something wrong in the set up here?

Running the same command against the stable helm charts folder produces the same output for me, both on the revison my fork's at as well as the latest stable binary release? It's expecting to find a bunch of .tgz files for the indexing, not the source files of the charts.

Thank you! I adjusted the test scenario!

helm [AmandaCameron-issue/1401*]$ cat charts/index.yaml
apiVersion: v1
entries:
  minecraft:
  - created: 2017-09-05T10:26:07.790956973-04:00
    description: Minecraft server
    digest: 9e1d17fecc49c4cb738c8ac775cc7681f1ddffd757b3799f7265c875420a017c
    keywords:
    - game
    - server
    maintainers:
    - email<EMAIL_ADDRESS>      name: Greg Taylor
    name: minecraft
    sources:
    - https://hub.docker.com/r/itzg/minecraft-server/~/dockerfile/
    - https://github.com/itzg/dockerfiles
    urls:
    - https://example-repo.com/minecraft-0.1.3.tgz
    version: 0.1.3
  mysql:
  - created: 2017-09-05T10:26:07.790048703-04:00
    description: Fast, reliable, scalable, and easy to use open-source relational
      database system.
    digest: 4b81edebb4ad77d7eef198111a67e52c6832b2706f5a3981d0fabd23d8a32223
    engine: gotpl
    home: https://www.mysql.com/
    icon: https://www.mysql.com/common/logos/logo-mysql-170x115.png
    keywords:
    - mysql
    - database
    - sql
    maintainers:
    - email<EMAIL_ADDRESS>      name: Vic Iglesias
    name: mysql
    sources:
    - https://github.com/kubernetes/charts
    - https://github.com/docker-library/mysql
    urls:
    - https://example-repo.com/mysql-0.2.8.tgz
    version: 0.2.8
  wordpress:
  - appVersion: 4.8.1
    created: 2017-09-05T10:26:07.790668117-04:00
    description: Web publishing platform for building blogs and websites.
    digest: 67eb379ac12c40522f6fe4df62acc2c1547d4ace55217fd7530ed30ea59d51e9
    engine: gotpl
    home: http://www.wordpress.com/
    icon: https://bitnami.com/assets/stacks/wordpress/img/wordpress-stack-220x234.png
    keywords:
    - wordpress
    - cms
    - blog
    - http
    - web
    - application
    - php
    maintainers:
    - email<EMAIL_ADDRESS>      name: bitnami-bot
    name: wordpress
    sources:
    - https://github.com/bitnami/bitnami-docker-wordpress
    urls:
    - https://example-repo.com/wordpress-0.6.11.tgz
    version: 0.6.11
generated: 2017-09-05T10:26:07.789641441-04:00

The only question I have is around the minecraft chart which is nested in charts/nestedDirectory/ ... is the url supposed to be  https://example-repo.com/minecraft-0.1.3.tgz or should it be  https://example-repo.com/nestedDirectory/minecraft-0.1.3.tgz?

It's currently using the Chart.yaml name as the SoT for that, which I'm now remembering was decided against in the meeting things, and would require piping around the charts/ argument from IndexDirectory to detect that it's "mis-named" as minecraft instead of nestedDirectory/minecraft
If that's still the direction we should take, I'll get some hacking started shortly.

I think relying on the Chart.yaml to be the source of truth for the name makes sense. However, it seems odd to be that to live in a nested directory in a chart repository that the name in the chart.yaml also has to indicate the path that the chart lives under. In my opinion, the chart should be entirely decoupled from the chart repository or path of the chart repository that it lives in. I think the repo command should be responsible for figuring out the path based off of the directory structure, so if the chart is nested in a nested directory, then the url constructed should mirror the nested path.
What do you think @AmandaCameron ?
I'll also cc/ @bacongobbler @technosophos here in case they want to chime in.

The chart name is already (at least superficially) attached to the file name, in the sense that there's checks for if you have a chart named foo in the metadata but it's in the directory named bar helm lint will yell at you. I believe there's also another similar check, but I'm having a hard time remembering where it is, I think it had something to do with actually producing the .tgz files from the source charts.
After coming back at it with a fresh set of eyes, It seems it's entirely possible to detect the misalignment much more cleanly, because the relative path from the charts/ arg is thrown around, which means I need to try and be less clever inside IndexFile.Add

Ah you're right. The chart name has to be the same as the directory it is in in its untarred form.
There is currently no connection however to the chart name and the path in the chart repository it lives in. All of that information comes from the index.yaml.
In the current state, helm serve would not work. So if I run helm serve --repo-path charts/ and tried to hit localhost:8879/minecraft-0.1.3.tgz, I'll get a 404 error but if I hit localhost:8879/nestedDirectory/minecraft-0.1.3.tgz, I get the desired behavior of downloading the minecraft chart from my browser.

I can fairly easily make it serve the correct directory for nestedDirectory/minecraft-0.1.3.tgz by removing some code that is unnessaraially clever, however with the current code layout of helm's chart checking, and the current command layout, I can't garuntee that nestedDir/minecraft being called minecraft in the yaml is the correct name.

To be specific, this is the code I added that was unnessarially clever, and caused the case of metadata: minecraft and file foo/minecraft to be served wrong: https://github.com/AmandaCameron/helm/blob/issue/1401/pkg/repo/index.go#L110-L123

ah I see. So if we took that out, then would the url be https://example-repo.com/nestedDirectory/minecraft-0.1.3.tgz?

Indeed, I've confirmed this locally, I'll push the changes up now so you can verify and check for any new holes it may have opened.

Sounds great!

Awesome. Just tested and it's working great for me! I'm just gonna do a read through of the code real quick before final approval. Thanks so much @AmandaCameron!

Nice, looks like CI failed on the unit tests. Always great to have tests capture the expected behavior!

Appears the test that failed is TestIndexAdd, speficially, the parts where it's trying an absolute path to be added to the index. I'm not familiar enough with the code base to know if that's an expected thing to receive for IndexFile.Add or not

Alright finished reading the code. It's looking good! I added a few questions to the review. If you could address those and fix the failing tests, I think we'll be all set for a merge! 👍

oh I didn't read your last comment before posting mine. Let me look into that broken test then. One sec.

Near as I can tell from looking at the current revison in the PR, it doesn't look like IndexFile.Add be getting called from anywhery where it'd be getting given a full path, but I may be wrong about that, but I' hesitent to just disable / change the test without feedback from someone  more familiar with the codebase.

Okay so it looks like removing line 110 in pkg/repo/index.go is the reason why we're getting the failure. If we put that back, we get passing tests but not the nested URL that we want. One thing we could do is put the baseURL constructing logic in the IndexDirectory function like this:
	index := NewIndexFile()
	for _, arch := range archives {
		fname, err := filepath.Rel(dir, arch)
		nestedDir, baseFileName := filepath.Split(fname)
		if nestedDir != "" {
			baseURL = filepath.Join(baseURL, nestedDir)
		}

		if err != nil {
			return index, err
		}
		c, err := chartutil.Load(arch)
		if err != nil {
			// Assume this is not a chart.
			continue
		}
		hash, err := provenance.DigestFile(arch)
		if err != nil {
			return index, err
		}
		index.Add(c.Metadata, baseFileName, baseURL, hash)
	}

This way we'll be able to construct those nested URLs without changing the behavior of IndexFile.Add. What do you think?

Just pushed 4d8b9fe to verify the ideas you put forward, because they sound right, but I'm unable to run the test suite locally for some reason, so I can't verify they're correct myself.

Appologies for the commit spam, but the CI gods appear to be happy now.

Appologies for the commit spam agian, but I'm fairly sure this is the bulk of the changes that just enable recursive chart scanning for index generation, just waiting to see if the CI gods are happy.


Update cached bank holidays as of 29/12/2022

👋
The cached bank holidays are a bit out of date. Any chance we can update them?
Do you have an internal process for keeping this file up-to-date and publishing new cached copies of the data/lib versions?

yeah it would actually be a good idea to have CI regularly update the cached version 🤔 but i'm not entirely sure i want to give it permission to update the repo and publish releases… i think instead i'll add a script to make it easier (it was always a manual task previously).
i'm going to undo the version bump in this PR and then do a release having added this helper script. but thank you for this update!

now released, thanks @samuelhwilliams!
https://pypi.org/project/govuk-bank-holidays/


Modified and content type fields not showing up

In the below screen shot, I am accessing metadata information the api which is accessing waterbutler which is accessing osfstorage. The modified and content type fields are null. They should not be null.
Both these fields do in fact already exist in the osfstorage. I think the issue might be some issue in processing data coming from osfstorage to waterbutler.

@brianjgeiger

@chrisseto Any thoughts on this? This is considered a Serious Problem.

I can't label these, but if I could, I am sensing "Priority = High" @chrisseto @icereval

@lbanner Checking now
Note content type may not be available.

Fixed via https://github.com/CenterForOpenScience/osf.io/pull/4063 and https://github.com/CenterForOpenScience/waterbutler/commit/c44ca9ff45cd0a581e3505b2537e2245408a066a


Fix errorhandler HTTPException normalization

This is barely noticeable in the development code since #839, but in the latest released version. The current code to normalize the error condition misses its apparent purpose: code_or_exception will never be an instance of HTTPException, as one might only supply an exception class and not an object.
The bug still appears when you declare an errorhandler for a numeric code after setting one for the respective exception: Then, the exception's handler will always take precedence.
The HTTPException base class has no code and therefore must be dealt with like any other exception.

The test case passes without changes in master.


Bug fix for European date format

Fixed bug whereby the incorrect date was being returned when the datepicker-popup attribute was set to 'dd.MM.yyyy', and an invalid date string was entered.

@dbillingham Thanks for the pull request but we have several other pull requests dealing with the same issue: #2395, #2691, #3152, #3294.  There hasn't been a decision made which approach is the best fix as it's tangled with some other fixes.  Closing this for now.


PathAccessException: The process cannot access the file because it is being used by another process (Windows only) after breaking changes 9.0.0

❗
After I updated to version 9.0.0, I randomly got an error saying: 'The process cannot access the file because it is being used by another process.'
This only happened after I upgraded to version 9.0.0.
I investigated the issue and came to the conclusion that it comes down to this.
If a file wants to read the same key at the same time as another file is writing to the same key, then I get this error.
I fixed this by switching back to the previous stable version.
I suggest updating the readme to alert users of this breaking issue.
This error also corrupts the .dat file, so all your secure storage is corrupted and unusable.
The error:
flutter: Failed to decrypt data: Error 0x00000057: Failure on CryptUnprotectData()
Delete corrupt file: c:\users\USER\appdata\roaming\com.example\APPNAME\flutter_secure_storage.dat
flutter: error on refresh token: PathAccessException: Cannot delete file, path = 'c:\users\USER\appdata\roaming\com.example\APPNAME\flutter_secure_storage.dat' (OS Error: The process cannot access the file because it is being used by another process.
flutter: , errno = 32) - stack: #0   _checkForErrorResponse (dart:io/common.dart:55:9)
flutter: #1   _File._delete.<anonymous closure> (dart:io/file_impl.dart:315:7)
flutter: #2   _rootRunUnary (dart:async/zone.dart:1407:47)
flutter: #3   _CustomZone.runUnary (dart:async/zone.dart:1308:19)
flutter: <asynchronous suspension>
flutter: #4   DpapiJsonFileMapStorage.load
flutter_secure_storage_windows_ffi.dart:267
flutter: <asynchronous suspension>
flutter: #5   FlutterSecureStorageWindows.write
flutter_secure_storage_windows_ffi.dart:142
flutter: <asynchronous suspension>
flutter: #6   CoreAuthRepo.toggleLoginEnvironmentInSecureStorage
core_auth_repo.dart:127
flutter: <asynchronous suspension>
flutter: #7   CoreAuthBloc._tryAutoLogin
core_auth_bloc.dart:113
flutter: <asynchronous suspension>
flutter: #8   Bloc.on.<anonymous closure>.handleEvent
bloc.dart:229
flutter: <asynchronous suspension>
flutter:

Greetings. Please fix ;-) 👍

Code example: https://github.com/mogol/flutter_secure_storage/issues/603#issuecomment-1769261086

@mogol

Any updates on this issue @mogol ?

Any updates on this issue @mogol ?

You can use the previous version.

any update on this issue?

@stan-at-work which previous version are you using to avoid this issue?

@stan-at-work which previous version are you using to avoid this issue?

I'm using flutter_secure_storage: ^8.1.0

any update on this issue?

Nope

I have the same problem using flutter_secure_storage: ^9.2.2

I have the same problem using flutter_secure_storage: ^9.2.2

1 i had the same error today after a long time of not having it again.

@mogol  Any updates on this?

@mogol ?


I wonder if it's race condition on update messages...


Multiple Quantities Scanned - Doesn't Prompt Until 3rd Duplicate

We performed a Diaper Drive utilizing the system, in real time, with the scanner.  The quantities were accurate, and everything work well (yay!), but we did notice one thing.. When we had duplicates of one item, the system did not prompt us to verify the duplicate scan until the 3rd time (see below prompt box).

In other words, we would scan a box, scan the same box again (2 of them), scan the same box again (3 of them).  It wasn't until the 3rd scan that we got the above box.  I personally would prefer this box to pop up on the second scan, from that point forward.
My reasoning is this: if you do not scan the multiples directly in a row (scan 10-15 other boxes first) then scan this box again, the original line item for this scan is now out of sight on the screen, and I do not see the quantity visually increase on the screen, causing me to question whether or not it added.
Does this make sense to anyone else?  Let me know your thoughts!!  Thanks!!!

Hey @JLBRDiaperbank this is excellent that it worked well!
That is the expected behaviour and how we were told to make it work. It would be very simple to make that change but maybe we should bring this up at our next feedback session and see what everyone else thinks. I think the original comment was "We either get 1 or 2 of something or a lot of something." So the ideas was that you could scan up to two without having to slow yourself down by having to manually typing something in on a keyboard.
We're definitely happy to make that change though if everyone thinks that is a better way to do things! We're adding it to the agenda!

Yes!  It was awesome to be able to utilize it real time!  Discussing at the next session is a great idea.  That is just my experience and feelings on the interaction.  Perhaps it can just have a popup box that says "Qty:x Packs!" and goes away after 1.5 or 2 seconds?  Just so the verification of multiple scans is there, but does not require interaction on the keyboard?
When we scanned a barcode that was not already in our library, there was no prompt for it to be added real time ( I think this feature is still in development?).  What we then did was save the donation, go to the barcode page, add it, go back to the donation, modify, then scan and it worked properly.
Thanks!!!!


Automatically handle Xcode CLT install if needed on MacOS

See, for example how the homebrew installer handles this.
I have written a function to test if we need to install the CLT, but am wondering at what point do we call it and do the installation. I'm guessing every single one of our dependencies probably needs the Xcode CLT on MacOS, so, I guess we put it near the beginning of install.sh? Here is a function to detect if CLT are missing:
install_xcodeCLT () {
    if [[ "${OSTYPE}" != [Dd][Aa][Rr][Ww][Ii][Nn]* ]]; then
        echo "false"
    else
        local xcode_dir
        xcode_dir="$(/usr/bin/xcode-select -print-path 2>/dev/null)"
        if [[ -z "${xcode_dir}" ]] || ! [[ -x "${xcode_dir}/usr/bin/make" ]] ; then
            echo "true"
        else
            echo "false"
	fi
    fi
}

Works safely on other systems.
Here is the clever magic that homebrew does to get CLT installed and the EULA signed: (from https://github.com/Homebrew/install/blob/master/install#L259-L285)
if should_install_command_line_tools?
  ohai "Searching online for the Command Line Tools"
  # This temporary file prompts the 'softwareupdate' utility to list the Command Line Tools
  clt_placeholder = "/tmp/.com.apple.dt.CommandLineTools.installondemand.in-progress"
  sudo "/usr/bin/touch", clt_placeholder
  clt_label = `softwareupdate -l | grep -B 1 -E "Command Line (Developer|Tools)" | awk -F"*" '/^ +\\*/ {print $2}' | sed 's/^ *//' | tail -n1`.chomp
  ohai "Installing #{clt_label}"
  sudo "/usr/sbin/softwareupdate", "-i", clt_label
  sudo "/bin/rm", "-f", clt_placeholder
  sudo "/usr/bin/xcode-select", "--switch", "/Library/Developer/CommandLineTools"
end

# Headless install may have failed, so fallback to original 'xcode-select' method
if should_install_command_line_tools? && STDIN.tty?
  ohai "Installing the Command Line Tools (expect a GUI popup):"
  sudo "/usr/bin/xcode-select", "--install"
  puts "Press any key when the installation has completed."
  getc
  sudo "/usr/bin/xcode-select", "--switch", "/Library/Developer/CommandLineTools"
end

abort <<-EOABORT if `/usr/bin/xcrun clang 2>&1` =~ /license/ && !$?.success?
You have not agreed to the Xcode license.
Before running the installer again please agree to the license by opening
Xcode.app or running:
    sudo xcodebuild -license
EOABORT

My ruby, while poor, is good enough to translate that to bash, I believe... or come up with our own version.

@zbeekman Possibly we can knock this out relatively quickly in a pair programming session or mark it as "won't fix" and close it.  I'll bel glad to help with modifying the installation scripts if we decide to fix this. Thoughts?


[WIP][TACHYON-795] New master journal interface

https://tachyon.atlassian.net/browse/TACHYON-795

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/4250/
Test PASSed.

@uronce-cc A high level suggestion: is it possible to abstract the function of serialization and deserialization into interfaces, so in the future, we could switch to other serialization and deserialization libraries rather than Json more easily?

Thanks @uronce-cc . Is there a higher-level interface for the journal? Maybe like [read|write]Checkpoint(), or [read|write]Event()? Is this ImageEntry for checkpoint or events or both?

Will rethink the interface, close for now.


[resolves #262] Add generated module XML files to git

Refer to this link for build results (access rights to CI server needed):
https://fabric8-ci.fusesource.com/job/wildfly-camel-pullreq/171/
Test PASSed.


Try to serve index.html if link points to directory

This change may fix a lot of broken links such as the ones I've found in https://github.com/hyperium/hyper/issues/1749 and https://github.com/hyperium/hyper/issues/1750

We currently add index.html for /, but not if the slash is missing. Thanks for writing up instructions!

Just hit the same issue with tokio docs. Wanted to see documentation for the https://docs.rs/tokio/0.2.11/tokio/time but "the resource does not exist". Adding slash or /index.html works, but would be good to have this done automatically.


Focus on Content When a New Page Loads?

Hello,
When a new page or tab loads, focus should shift to the top of the content. This could either be user specified, or assumed by where the content is wrapped.
Currently when a new page loads, nothing happens to the focus. This is extremely annoying for screen reader users who are unable to visually see that the page content has changed.
Thanks,

Moving this to Flow repo as this isn't a component-specific enhancement. Maybe Vaadin could offer "skip to content" -flag.


fix(render): make cacheAsBitmap not affect other textures with a filter for 1 frame

Description of change
The issue I was experiencing was that I had a single texture that had a custom filter. Any time I created a new Graphics object and set cacheAsBitmap to true, the texture with the custom filter would partially flicker for that frame while the Graphic was being cached. This change fixed the problem for me.
I saw an issue which may be the same as my problem here: https://github.com/pixijs/pixi.js/issues/2831
If you really need me to, I could make a new reproducible test demo. But preferably not, I think this change is quite straightforward.
Pre-Merge Checklist

[ ] Tests and/or benchmarks are included
[ ] Documentation is changed or added
[x] Lint process passed (npm run lint)
[ ] Tests passed (npm run test)

OK, still need to find time to review it properly and add a unit test.

I'm on a break but we need someone to add a test. @eXponenta or someone else

Demo is here: https://www.pixiplayground.com/#/edit/LZli1NESJ3Vlf_8l9Fdbe
If you comment out first line, you'll see the original error.
btw, We dont need to clone renderTexture, only sourceFrame, please make that change in PR and I'll approve it.

@Loonride in case you dont have time right now, I can make separate PR with cloning just rectangle. I think whether should I try to add tests too...

Closing in favor of #6466


Fix the order of linux app service runtime

Fix the order of linux app service runtime, for issue #575

Codecov Report

Merging #577 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #577   +/-   ##
========================================
  Coverage    35.56%   35.56%
========================================
  Files           72       72
  Lines         2784     2784
  Branches       374      374
========================================
  Hits           990      990
  Misses        1723     1723
  Partials        71       71

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7605b6...391c051. Read the comment docs.


page.getAnnotations doesn't have opacity?

`
page.getAnnotations().then(function (pageAnnotations) {
console.log(pageAnnotations)
pageAnnotations.forEach((annotation) => {
let color = annotation.color
lineWidth =annotation.borderStyle.width,//works fine
opacity= annotation.opacity//doesn't exists
})
})
})
`

When opening an issue, please provide all of the information requested in https://github.com/mozilla/pdf.js/blob/master/.github/ISSUE_TEMPLATE.md since it's unfortunately not really possible to understand exactly what you're asking for here since in the general case there may not actually be just one "opacity" value for an Annotation.
Also, given that the Firefox PDF Viewer is the primary use-case, please note that we're somewhat unlikely to expose "unused" properties on the Annotation-data that's returned by the API.


IIS + PHP 7.2 = Your FFProbe version is too old and does not support -help option, please upgrade

Q
A

Bug?
yes

New Feature?
no

Version Used
"php-ffmpeg/php-ffmpeg": "^0.13.0"

FFmpeg Version
4.1-static

OS
Windows 10 Pro 64bit + 7.2.12 (cli) (built: Nov  8 2018 05:47:24) ( NTS MSVC15 (Visual C++ 2017) x64 )

Actual Behavior
try {
	$video = $this->ffmpeg->open($file);
	$frame = $video->frame(TimeCode::fromSeconds(5));
	$thumb = $frame->save(null, false, "image2");
} catch (\Exception $e) {
	$e...
}

Your FFProbe version is too old and does not support -help option, please upgrade.
Steps to Reproduce

Setup IIS + PHP 7.2;
Download ffmpeg 4.1-static (from here https://ffmpeg.zeranoe.com/builds/) to your website root;
Try to process some file

Possible Solutions
 ffprobe.exe -h on the project root runs fine. However, inside PHP it hits this line:

It appears that the process is returning the status code 0. I don't have disabled functions in my php.ini.

Managed to fix this, one more complex thing within IIS.
I had to change IIS Application Pool > Advanced Settings > Process Model > Identity from ApplicationPoolIdentity to LocalSystem.
Maybe this should be added to the readme?

Maybe this should be added to the readme?

I would love to see this. I never used this proprietary software once, I have no clue and I'd like somebody else to take responsibility on wording it.


OPAM package?

Hi Leo,
Is it possible to publish octavius in the official OPAM repo?

I haven't made an initial release yet -- and I hope to make significant changes before I do -- so I wasn't going to publish it on OPAM anytime soon.
Is there any particular reason you would like it to be published now?

Thanks for the reply.
I want to implement doctest, tests embeded in documents like https://github.com/sol/doctest#readme . OCamlDoc comments are now accessible as<EMAIL_ADDRESS>attribute in Parsetree, and what is now missing is the extraction of the code part.
I checked OCamlDoc's lexer+parser first but it is not easy to use: the code is obtained in Yacc level and it lacks the position information.  In Octavius, the code part is already available at the lexer level and its location is easily obtainable. So, in short, what I want to use essentially in Octavius is OctLexer (and of course OctTypes).

This will happen at some point in the near future.


Added a DNF fix for solving the docker build problem in earlier docker versions

Added a DNF fix for solving the docker build problem in earlier docker versions. Without this fix current nightly builds fail to build the docker image for 32-bit linux builds.

Linux test PASSed.

Windows test PASSed.

Linux test PASSed.

Windows test PASSed.

The problem came out to be a problem in docker not pulling the latest fedora (docker pull fedora) image at jenkins. When the image was pulled, the builds seem to start working fine. Hence, closing this PR.


Client respects the InsecureSkipTLSVerify setting for a cluster in kubeConfig

Are there any tests to be written for this? As such it's a tiny change.

lgtm, thanks!


nbd: add which to buildInputs

Motivation for this change
The nbd build complains numerously about not being able to find the which package during its testing phase:
make  check-TESTS
make[3]: Entering directory '/build/nbd-3.18/tests/run'
./simple_test: line 9: which: not found
./cfg1
5442: Requests: 0
** Message: 01:01:44.884: 5442: Throughput read test (without flushes) complete. Took 0.080 seconds to complete, 50.222Mib/s
PASS: cfg1
./simple_test: line 9: which: not found
./cfgmulti
5463: Requests: 0
** Message: 01:01:45.988: 5463: Throughput read test (without flushes) complete. Took 0.079 seconds to complete, 50.925Mib/s
5469: Requests: 0
** Message: 01:01:46.068: 5469: Throughput read test (without flushes) complete. Took 0.077 seconds to complete, 52.084Mib/s
PASS: cfgmulti
./simple_test: line 9: which: not found
./cfgnew
5490: Requests: 0
** Message: 01:01:47.178: 5490: Throughput read test (without flushes) complete. Took 0.084 seconds to complete, 47.414Mib/s
PASS: cfgnew
./simple_test: line 9: which: not found
./cfgsize

and so on.
I'm not sure why the build doesn't fail under these conditions, but anyway, simply adding which to its buildInputs fixes this.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build nbd

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: nbd
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: nbd
Partial log (click to expand)
shrinking /nix/store/1ijrpqfyg2qff78srkgvvp9zgh0liapn-nbd-3.18/sbin/nbd-client
shrinking /nix/store/1ijrpqfyg2qff78srkgvvp9zgh0liapn-nbd-3.18/bin/nbd-server
shrinking /nix/store/1ijrpqfyg2qff78srkgvvp9zgh0liapn-nbd-3.18/bin/nbd-trdump
gzipping man pages under /nix/store/1ijrpqfyg2qff78srkgvvp9zgh0liapn-nbd-3.18/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1ijrpqfyg2qff78srkgvvp9zgh0liapn-nbd-3.18/bin  /nix/store/1ijrpqfyg2qff78srkgvvp9zgh0liapn-nbd-3.18/sbin
patching script interpreter paths in /nix/store/1ijrpqfyg2qff78srkgvvp9zgh0liapn-nbd-3.18
checking for references to /build in /nix/store/1ijrpqfyg2qff78srkgvvp9zgh0liapn-nbd-3.18...
moving /nix/store/1ijrpqfyg2qff78srkgvvp9zgh0liapn-nbd-3.18/sbin/* to /nix/store/1ijrpqfyg2qff78srkgvvp9zgh0liapn-nbd-3.18/bin
/nix/store/1ijrpqfyg2qff78srkgvvp9zgh0liapn-nbd-3.18

Success on aarch64-linux (full log)
Attempted: nbd
Partial log (click to expand)
shrinking /nix/store/j2njq4sl95hwh9lq1x0nglp0236w6489-nbd-3.18/sbin/nbd-client
shrinking /nix/store/j2njq4sl95hwh9lq1x0nglp0236w6489-nbd-3.18/bin/nbd-trdump
shrinking /nix/store/j2njq4sl95hwh9lq1x0nglp0236w6489-nbd-3.18/bin/nbd-server
gzipping man pages under /nix/store/j2njq4sl95hwh9lq1x0nglp0236w6489-nbd-3.18/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/j2njq4sl95hwh9lq1x0nglp0236w6489-nbd-3.18/bin  /nix/store/j2njq4sl95hwh9lq1x0nglp0236w6489-nbd-3.18/sbin
patching script interpreter paths in /nix/store/j2njq4sl95hwh9lq1x0nglp0236w6489-nbd-3.18
checking for references to /build in /nix/store/j2njq4sl95hwh9lq1x0nglp0236w6489-nbd-3.18...
moving /nix/store/j2njq4sl95hwh9lq1x0nglp0236w6489-nbd-3.18/sbin/* to /nix/store/j2njq4sl95hwh9lq1x0nglp0236w6489-nbd-3.18/bin
/nix/store/j2njq4sl95hwh9lq1x0nglp0236w6489-nbd-3.18

(No idea what happened with the conflict there. I've rebased, looks ok now.)

@GrahamcOfBorg build nbd

sorry, not everyone can trigger builds
@GrahamcOfBorg build nbd

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: nbd
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: nbd
Partial log (click to expand)
shrinking /nix/store/fdrw448yya0xqfjxs4jz37c7i2b1w8nk-nbd-3.18/sbin/nbd-client
shrinking /nix/store/fdrw448yya0xqfjxs4jz37c7i2b1w8nk-nbd-3.18/bin/nbd-server
shrinking /nix/store/fdrw448yya0xqfjxs4jz37c7i2b1w8nk-nbd-3.18/bin/nbd-trdump
gzipping man pages under /nix/store/fdrw448yya0xqfjxs4jz37c7i2b1w8nk-nbd-3.18/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/fdrw448yya0xqfjxs4jz37c7i2b1w8nk-nbd-3.18/bin  /nix/store/fdrw448yya0xqfjxs4jz37c7i2b1w8nk-nbd-3.18/sbin
patching script interpreter paths in /nix/store/fdrw448yya0xqfjxs4jz37c7i2b1w8nk-nbd-3.18
checking for references to /build in /nix/store/fdrw448yya0xqfjxs4jz37c7i2b1w8nk-nbd-3.18...
moving /nix/store/fdrw448yya0xqfjxs4jz37c7i2b1w8nk-nbd-3.18/sbin/* to /nix/store/fdrw448yya0xqfjxs4jz37c7i2b1w8nk-nbd-3.18/bin
/nix/store/fdrw448yya0xqfjxs4jz37c7i2b1w8nk-nbd-3.18

Ah, hehe. Thought I'd give the magic incantation a try :)

Success on aarch64-linux (full log)
Attempted: nbd
Partial log (click to expand)
shrinking /nix/store/wi92y3ynninv6g86qbmgap2mw4i4njcn-nbd-3.18/sbin/nbd-client
shrinking /nix/store/wi92y3ynninv6g86qbmgap2mw4i4njcn-nbd-3.18/bin/nbd-trdump
shrinking /nix/store/wi92y3ynninv6g86qbmgap2mw4i4njcn-nbd-3.18/bin/nbd-server
gzipping man pages under /nix/store/wi92y3ynninv6g86qbmgap2mw4i4njcn-nbd-3.18/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/wi92y3ynninv6g86qbmgap2mw4i4njcn-nbd-3.18/bin  /nix/store/wi92y3ynninv6g86qbmgap2mw4i4njcn-nbd-3.18/sbin
patching script interpreter paths in /nix/store/wi92y3ynninv6g86qbmgap2mw4i4njcn-nbd-3.18
checking for references to /build in /nix/store/wi92y3ynninv6g86qbmgap2mw4i4njcn-nbd-3.18...
moving /nix/store/wi92y3ynninv6g86qbmgap2mw4i4njcn-nbd-3.18/sbin/* to /nix/store/wi92y3ynninv6g86qbmgap2mw4i4njcn-nbd-3.18/bin
/nix/store/wi92y3ynninv6g86qbmgap2mw4i4njcn-nbd-3.18

Thanks @xeji!


Update links in README

Hi there!
I was looking at your repo and found some broken links in the README, I thought I'll fix them for you :)

Nice catch. Thanks! Will merge tomorrow.


Fix for decoding large manifests

Resolves #459
Related to #308

Looks like there's a few other usages of initProtobuffers. Should these be updated too?
https://github.com/codex-storage/nim-codex/blob/a89938478a1a0c58b48ff8ec3bddfd5c96b51522/codex/manifest/coders.nim#L35

Looks like there's a few other usages of initProtobuffers. Should these be updated too?
https://github.com/codex-storage/nim-codex/blob/a89938478a1a0c58b48ff8ec3bddfd5c96b51522/codex/manifest/coders.nim#L35

I think we're fine with the default there, the manifest is a special case, but it should also get mostly resolved once we move over to merkle trees.

Looks like there's a few other usages of initProtobuffers. Should these be updated too?
https://github.com/codex-storage/nim-codex/blob/a89938478a1a0c58b48ff8ec3bddfd5c96b51522/codex/manifest/coders.nim#L35

I agree that those other places may become an issue in the future. So ideally I would like to see this parameter to be set in a single place as a default configuration for a Protobuf decoder. However doing it this way would require a larger refactor. So for now I'm just trying to fix a single issue.

@tbekas, thanks for the help to test the fix
              Upload   --> Codex Demo
            /                      |
HTTP Client                        |
            \                      |
              Download <-- Codex Local

10GB.bin - upload   - 13m24.079s
10GB.bin - download - 32m19.352s

Upload was so fast probably because file was already uploaded?

Looks like there's a few other usages of initProtobuffers. Should these be updated too?
https://github.com/codex-storage/nim-codex/blob/a89938478a1a0c58b48ff8ec3bddfd5c96b51522/codex/manifest/coders.nim#L35

I agree that those other places may become an issue in the future. So ideally I would like to see this parameter to be set in a single place as a default configuration for a Protobuf decoder. However doing it this way would require a larger refactor. So for now I'm just trying to fix a single issue.

The current default in the core protobuf (which is 4mb) should be more than enough. The manifest is a special case and should be mostly addressed by https://github.com/codex-storage/codex-research/pull/169. I would in fact only set the manifest limit past 4mb, if we're using protobuf for anything larger than that, then protobuf is the wrong tool for the job. One of the issues with protobuf is that it cannot be streamed and as such it can become a bottleneck or even an attack vector.

Upload was so fast probably because file was already uploaded?

@veaceslavdoina  No, upload is faster because in the current implementation it's a simple local operation, there's no p2p communication involved. Download on the other hand require DHT lookups and p2p comms.


Update ESD clamp footprint

Make sure that it has a courtyard and otherwise aligns with the KiCAD standard silk screen etc.

Perhaps switch to the following for nicer route
https://www.mouser.in/ProductDetail/Texas-Instruments/ESDS312DBVR?qs=byeeYqUIh0PGNqB7QuJpTA%3D%3D


Include frozenset in tutorial

The tutorial section on 'Extra Data Types' did not include an example of frozenset.

Thanks for the interest and effort! :nerd_face:
I wasn't trying to include all the possible data types supported by Pydantic.
But still, I'm curious, in which cases do you think a frozen set would be required or particularly useful?
I haven't found a use case where I need it, also that justifies explaining it in the docs. :shrug:

Sorry for the long delay! 🙈  I wanted to personally address each issue/PR and they piled up through time, but now I'm checking each one in order.


[1.12] Unknown Crash, please help!

**Industrial Foregoing Version: industrialforegoing-1.12.2-1.12.13-237
**TeslaCoreLib Version: tesla-core-lib-1.12.2-1.0.17
**Crashlog If Applicable (Upload to pastebin/gist): https://pastebin.com/mxFk2f3T
I'm not sure what could've caused this crash but I'm hoping you can release a fix for it quickly!
Sidenote: VanillaFix detected a hard crash instead of a soft crash while loading the game.
-Sauce

Make a smaller pack, you have too many blocks and items


Add example of importing local file from a different path

Say index.js imports a date utility function from ../utils/date. If we run babel-node lib/index/js, that will work. But the serve script, node dist/index.js will no longer work, because utils/date.js has an export statement, which Babel didn't transpile.
We could have utils/src/date.js transpiled to utils/lib/date.js, but then index.js needs to be changed to explicitly import utils/lib/date, and babel-node lib/index.js alone will no longer work correctly for development because utils/lib/date.js is outdated vs. utils/src/date.js.
@thejameskyle, what would be the best practice here?

I'm facing the very same issue. Any suggestion/solution on this would be helpful.


do not work! no print anything

do not work! no print anything

Perhaps a duplicate of #3.

Same here. The console opens up when shaking. But the log messages I've seen in the IDE console don't show up in this LogConsole. I can't event see how this component attaches itself to the logger framework to receive the log events.


U — [CSS] images, Fx 75 tasks

Trello
https://trello.com/c/oiUALAeb/33-css-images-level-3-4-fx-75
Acceptance criteria

[ ] [css-images] Consider changing initial value of 'image-orientation' to from-image

Looks to be fairly small, probably only needs data updates and a rel note.

@chrisdavidmills Do we have a Fx76 epic to move this to?

For future reference: PR for /data

Do we have a Fx76 epic to move this to?

I didn't before, but I do now: https://github.com/mdn/sprints/issues/2991
I've updated this one to Fx76 on the content roadmap too.

Moved to Echo Foxtrot milestone

And now it's 77? Based on whiteboard value [layout:backlog:77] in the Bugzilla bug.

@jmswisher the tracking flags say fixed in 76, but I think this is only in Nightly for now.
Let's close this for now, and wait for it to resurface later on.


chore(bot-and-integration):Modify .hound.yml

.hound.yml file was modified to resolve error
[Fixes #141409241]

Fix issue with hound.

You should resolve this issue on the branch for this chore and then make a PR, this branch doesn't follow clearly laid out naming conventions also your PR should always follow the laid convention.

Ok. I tried that but got a message like no branch to compare. I believe it was deleted by bayo. That's why the patch branch was created

@andela-oakinwa you can either create the branch again, or create a bug in PT and use that in a new branch to fix the issue as suggested by @andela-uopaluwa.


Would support swagger ?

I was try to find Pascal Swagger support.
But I found nothing.
Then I try to do something for it, but has not progressed.
Would you support swagger?
This framework also try to support it,
https://github.com/danieleteti/delphimvcframework
but they have no help.
Thanks.

Can you provide more information about Pascal Swagger? project link? It is a api doc generator?

Yes, it is an api doc generator.
Please look in this site:
http://swagger.io/open-source-integrations/
Can you support that generate client classes by the api doc like generate datasnap client classes?
It is very useful.
Thanks.

Makes sense, we could support it.
Do you plan to implement this?

I want to do it , but I have no clue even I have read some info.

Ok, let's wait and see if any of the commiters want to work on this. We will need someone with some experience with Swagger.

I think this is outside the scope of this project.
Swagger is focused on the API itself and your development cycle. It generate documentation and have a UI where you can interact with your API to evaluate.
This library is just for consume the API (This library is just to consume the API (that could be backed by Swagger).
It make sense add support for Swagger in https://github.com/danieleteti/delphimvcframework, because you are creating an API, and you need this kind of features. There are already an opened issue: https://github.com/danieleteti/delphimvcframework/issues/38.


perforce-proxy 2015.1.1126382

New upstream version
Add test that verifies executable's version/build

Merged in 4e28034eb410df45c1d0f1e39bacdb536864d135, sorry for the delay!


Import error while trying to run sandbox pipeline

While running sandbox pipeline I run into this error,
Traceback (most recent call last):   File "/opt/env/bin/law", line 10, in <module>     exit_code = run()   File "/law_forward/py/law/cli/cli.py", line 74, in run     return mods[prog].execute(*exec_args)   File "/law_forward/py/law/cli/run.py", line 57, in execute     mod = __import__(modid, globals(), locals(), [cls_name])   File "/home/stevenjames.henderson/aframev2/aframe/tasks/__init__.py", line 1, in <module>     from .data import *   File "/home/stevenjames.henderson/aframev2/aframe/tasks/data/__init__.py", line 14, in <module>     from .timeslide_waveforms import *   File "/home/stevenjames.henderson/aframev2/aframe/tasks/data/timeslide_waveforms/__init__.py", line 1, in <module>     from .timeslide_waveforms import DeployTimeslideWaveforms, TimeslideWaveforms   File "/home/stevenjames.henderson/aframev2/aframe/tasks/data/timeslide_waveforms/timeslide_waveforms.py", line 14, in <module>     from utils import data as data_utils ModuleNotFoundError: No module named 'utils'
Also returning this error when trying to build the data container,
singularity build --force /home/stevenjames.henderson/aframe/images/data.sif /home/stevenjames.henderson/aframev2/projects/data/apptainer.def INFO:    User not listed in /etc/subuid, trying root-mapped namespace INFO:    The %post section will be run under fakeroot FATAL:   Unable to create build: while ensuring correct compression algorithm: while creating squashfs: create command failed: exit status 1: FATAL ERROR:Failed to create thread INFO:    User not listed in /etc/subuid, trying root-mapped namespace INFO:    The %post section will be run under fakeroot FATAL:   Unable to create build: while ensuring correct compression algorithm: while creating squashfs: create command failed: exit status 1: FATAL ERROR:Failed to create thread

The first error is coming from being unable to build the data container. I was getting the second error intermittently this afternoon on LLO, but it went away on its own, so it's a little tough to debug. From some old threads I'm finding online, I think it may be related to running out of RAM. Can you try re-building again? Oh, and by the way, you can enclose blocks of code (or tracebacks) in triple ticks (``` ... ```)  rather than single ticks to get nicer formatting.

The first error is coming from being unable to build the data container. I was getting the second error intermittently this afternoon on LLO, but it went away on its own, so it's a little tough to debug. From some old threads I'm finding online, I think it may be related to running out of RAM. Can you try re-building again? Oh, and by the way, you can enclose blocks of code (or tracebacks) in triple ticks (...) rather than single ticks to get nicer formatting.

That seems to be the problem, I changed nodes to one with more memory and built export and data successfully.


feat(ui): implement trending list

Implement trending list via api in #796 described by #778
close #776
close #777

Since this seems to have implemented descriptions, I will mention it here.
It seems that some repos are missing descriptions even though they are present on Github.

Difftastic's description reads "a structural diff that understands syntax 🟥🟩".

@AntoniosBarotsis This is exactly what #807 is dealing with, GitHub has more than 200 million public code repos, which takes a period of time to get their description information.


initial containerized deployment failing on "look up for ceph-volume rejected devices"

I'm not sure if this is a ceph-ansible issue or an ansible issue.  I'm starting here.
Running the playbook fails on "look up for ceph-volume rejected devices"
TASK [ceph-config : look up for ceph-volume rejected devices] *************************************************************************************************************************************************************************************************************************
Wednesday 20 January 2021  15:46:52 -0800 (0:00:00.428)       0:06:40.502 *****
fatal: [ceph-osd00-mgmt]: FAILED! => changed=true
  cmd:
  - podman
  - run
  - --rm
  - --privileged
  - --net=host
  - --ipc=host
  - -v
  - /run/lock/lvm:/run/lock/lvm:z
  - -v
  - /var/run/udev/:/var/run/udev/:z
  - -v
  - /dev:/dev
  - -v
  - /etc/ceph:/etc/ceph:z
  - -v
  - /run/lvm/:/run/lvm/
  - -v
  - /var/lib/ceph/:/var/lib/ceph/:z
  - -v
  - /var/log/ceph/:/var/log/ceph/:z
  - --entrypoint=ceph-volume
  - docker.io/ceph/daemon:latest
  - --cluster
  - ceph
  - inventory
  - --format=json
  delta: '0:00:00.561605'
  end: '2021-01-20 15:42:41.340605'
  msg: non-zero return code
  rc: 1
  start: '2021-01-20 15:42:40.779000'
  stderr: '-->  AttributeError: module ''ceph_volume.api.lvm'' has no attribute ''is_lv'''
  stderr_lines: <omitted>
  stdout: ''
  stdout_lines: <omitted>
fatal: [ceph-osd02-mgmt]: FAILED! => changed=true
  cmd:
  - podman
  - run
  - --rm
  - --privileged
  - --net=host
  - --ipc=host
  - -v
  - /run/lock/lvm:/run/lock/lvm:z
  - -v
  - /var/run/udev/:/var/run/udev/:z
  - -v
  - /dev:/dev
  - -v
  - /etc/ceph:/etc/ceph:z
  - -v
  - /run/lvm/:/run/lvm/
  - -v
  - /var/lib/ceph/:/var/lib/ceph/:z
  - -v
  - /var/log/ceph/:/var/log/ceph/:z
  - --entrypoint=ceph-volume
  - docker.io/ceph/daemon:latest
  - --cluster
  - ceph
  - inventory
  - --format=json
  delta: '0:00:00.570350'
  end: '2021-01-20 15:42:41.351446'
  msg: non-zero return code
  rc: 1
  start: '2021-01-20 15:42:40.781096'
  stderr: '-->  AttributeError: module ''ceph_volume.api.lvm'' has no attribute ''is_lv'''
  stderr_lines: <omitted>
  stdout: ''
  stdout_lines: <omitted>
fatal: [ceph-osd04-mgmt]: FAILED! => changed=true
  cmd:
  - podman
  - run
  - --rm
  - --privileged
  - --net=host
  - --ipc=host
  - -v
  - /run/lock/lvm:/run/lock/lvm:z
  - -v
  - /var/run/udev/:/var/run/udev/:z
  - -v
  - /dev:/dev
  - -v
  - /etc/ceph:/etc/ceph:z
  - -v
  - /run/lvm/:/run/lvm/
  - -v
  - /var/lib/ceph/:/var/lib/ceph/:z
  - -v
  - /var/log/ceph/:/var/log/ceph/:z
  - --entrypoint=ceph-volume
  - docker.io/ceph/daemon:latest
  - --cluster
  - ceph
  - inventory
  - --format=json
  delta: '0:00:00.557780'
  end: '2021-01-20 15:42:41.351206'
  msg: non-zero return code
  rc: 1
  start: '2021-01-20 15:42:40.793426'
  stderr: '-->  AttributeError: module ''ceph_volume.api.lvm'' has no attribute ''is_lv'''
  stderr_lines: <omitted>
  stdout: ''
  stdout_lines: <omitted>

Share your group_vars files, inventory and full ceph-ansibe log
Environment:
Cluster Nodes:

OS (e.g. from /etc/os-release): CentOS Linux release 8.3.2011
Kernel (e.g. uname -a): 4.18.0-240.1.1.el8_3.x86_64
Podman version: 2.0.5
ceph-ansible version (e.g. git head or tag or stable branch): stable-5.0
Ceph version (e.g. ceph -v): n/a (unable to provision the cluster)

ansible host:

OS: CentOS Linux release 7.7.1908 (Core)
Ansible version (e.g. ansible-playbook --version): ansible-playbook 2.9.16
config file = /home/jwhite/ceph-ansible/ansible.cfg
configured module search path = [u'/home/jwhite/ceph-ansible/library']
ansible python module location = /usr/lib/python2.7/site-packages/ansible
executable location = /bin/ansible-playbook
python version = 2.7.5 (default, Aug  7 2019, 00:51:29) [GCC 4.8.5 20150623 (Red Hat 4.8.5-39)]

[host|group]_vars:
-bash-4.2$ egrep -v '^(#|$|dummy)' group_vars/.yml host_vars/.yml
group_vars/all.yml:---
group_vars/all.yml:configure_firewall: True
group_vars/all.yml:ntp_service_enabled: true
group_vars/all.yml:ntp_daemon_type: chronyd
group_vars/all.yml:ceph_origin: repository
group_vars/all.yml:ceph_repository: community
group_vars/all.yml:ceph_stable_release: octopus
group_vars/all.yml:monitor_address_block: [redacted]/27
group_vars/all.yml:osd_memory_target:<PHONE_NUMBER>
group_vars/all.yml:public_network: [redacted]/27
group_vars/all.yml:cluster_network: <IP_ADDRESS>/24
group_vars/all.yml:radosgw_frontend_type: beast # For additionnal frontends see: http://docs.ceph.com/docs/nautilus/radosgw/frontends/
group_vars/all.yml:radosgw_address: [redacted]
group_vars/all.yml:radosgw_frontend_port: 8443
group_vars/all.yml:radosgw_frontend_ssl_certificate: "[redacted]"
group_vars/all.yml:email_address<EMAIL_ADDRESS>group_vars/all.yml:ceph_docker_image: "ceph/daemon"
group_vars/all.yml:ceph_docker_image_tag: latest
group_vars/all.yml:ceph_docker_registry: docker.io
group_vars/all.yml:containerized_deployment: True
group_vars/all.yml:dashboard_enabled: True
group_vars/all.yml:dashboard_protocol: https
group_vars/all.yml:dashboard_port: 3030
group_vars/all.yml:dashboard_admin_user: admin
group_vars/all.yml:dashboard_admin_password: [redacted]
group_vars/all.yml:dashboard_crt: '[redacted]'
group_vars/all.yml:dashboard_key: '[redacted]'
group_vars/all.yml:dashboard_grafana_api_no_ssl_verify: "{{ true if dashboard_protocol == 'https' and not grafana_crt and not grafana_key else false }}"
group_vars/all.yml:grafana_admin_user: admin
group_vars/all.yml:grafana_admin_password: [redacted]
group_vars/all.yml:grafana_crt: '[redacted]'
group_vars/all.yml:grafana_key: '[redacted]'
group_vars/osds.yml:---
group_vars/osds.yml:devices:
group_vars/osds.yml:  - /dev/dm-1
group_vars/osds.yml:  - /dev/dm-2
group_vars/osds.yml:  - /dev/dm-3
group_vars/osds.yml:  - /dev/dm-4
group_vars/osds.yml:  - /dev/dm-5
group_vars/osds.yml:  - /dev/dm-6
group_vars/osds.yml:  - /dev/dm-7
group_vars/osds.yml:  - /dev/dm-8
group_vars/osds.yml:  - /dev/dm-9
group_vars/osds.yml:  - /dev/dm-10
group_vars/osds.yml:  - /dev/dm-11
group_vars/osds.yml:  - /dev/dm-12
group_vars/osds.yml:  - /dev/dm-13
group_vars/osds.yml:  - /dev/dm-14
group_vars/osds.yml:  - /dev/dm-15
group_vars/osds.yml:  - /dev/dm-16
group_vars/osds.yml:  - /dev/dm-17
group_vars/osds.yml:  - /dev/dm-18
group_vars/osds.yml:  - /dev/dm-19
group_vars/osds.yml:  - /dev/dm-20
group_vars/osds.yml:  - /dev/dm-21
group_vars/osds.yml:  - /dev/dm-22
group_vars/osds.yml:  - /dev/dm-23
group_vars/osds.yml:  - /dev/dm-24
group_vars/osds.yml:  - /dev/dm-25
group_vars/osds.yml:  - /dev/dm-26
group_vars/osds.yml:  - /dev/dm-27
group_vars/osds.yml:  - /dev/dm-28
group_vars/osds.yml:  - /dev/dm-29
group_vars/osds.yml:  - /dev/dm-30
group_vars/osds.yml:  - /dev/dm-31
group_vars/osds.yml:  - /dev/dm-32
group_vars/osds.yml:  - /dev/dm-33
group_vars/osds.yml:  - /dev/dm-34
group_vars/osds.yml:  - /dev/dm-35
group_vars/osds.yml:  - /dev/dm-36
group_vars/osds.yml:  - /dev/dm-37
group_vars/osds.yml:  - /dev/dm-38
group_vars/osds.yml:  - /dev/dm-39
group_vars/osds.yml:  - /dev/dm-40
group_vars/osds.yml:  - /dev/dm-41
group_vars/osds.yml:  - /dev/dm-42
group_vars/osds.yml:  - /dev/dm-43
group_vars/osds.yml:  - /dev/dm-44
group_vars/osds.yml:  - /dev/dm-45
group_vars/osds.yml:  - /dev/dm-46
group_vars/osds.yml:  - /dev/dm-47
group_vars/osds.yml:  - /dev/dm-48
group_vars/osds.yml:dedicated_devices:
group_vars/osds.yml:  - /dev/nvme0n1
group_vars/osds.yml:  - /dev/nvme1n1
Inventory:
[mons]
ceph-osd00-mgmt
ceph-osd02-mgmt
ceph-osd04-mgmt
[osds]
ceph-osd00-mgmt
ceph-osd01-mgmt
ceph-osd02-mgmt
ceph-osd03-mgmt
ceph-osd04-mgmt
ceph-osd05-mgmt
ceph-osd06-mgmt
[mgrs]
ceph-svcs00-mgmt
ceph-svcs01-mgmt
ceph-svcs02-mgmt
ceph-svcs03-mgmt
[mdss]
ceph-svcs01-mgmt
[rgws]
#ceph-svcs01-mgmt
#ceph-svcs02-mgmt
#ceph-svcs03-mgmt
[nfss]
#ceph-svcs01-mgmt
#ceph-svcs02-mgmt
#ceph-svcs03-mgmt
[monitoring]
ceph-svcs00-mgmt
[grafana-server]
ceph-svcs00-mgmt
[clients]
ceph-svcs00-mgmt
ceph-svcs01-mgmt
ceph-svcs02-mgmt
ceph-svcs03-mgmt
ansible_log.txt
ceph-volume.log

stderr: '-->  AttributeError: module ''ceph_volume.api.lvm'' has no attribute ''is_lv'''

This reminds me some ceph-volume related issue but those should have been fixed.
What's the ceph version from the container (ceph --version)?
Because you're using docker.io/ceph/daemon:latest but I don't know which 15.2.x release it is associated.
Is this a recent deployment ?

stderr: '-->  AttributeError: module ''ceph_volume.api.lvm'' has no attribute ''is_lv'''

This reminds me some ceph-volume related issue but those should have been fixed.
What's the ceph version from the container (ceph --version)?
Because you're using docker.io/ceph/daemon:latest but I don't know which 15.2.x release it is associated.
Is this a recent deployment ?

This is a brand new deployment.  I don't actually have any containers up as of yet so I can't easily check the version live but the ceph-ansible logs claim 15.2.8

This is a brand new deployment.  I don't actually have any containers up as of yet so I can't easily check the version live but the ceph-ansible logs claim 15.2.8

You can get this information by running
# podman run --rm --entrypoint=ceph docker.io/ceph/daemon:latest --version

You can get this information by running
# podman run --rm --entrypoint=ceph docker.io/ceph/daemon:latest --version

Yea, 15.2.8:
ceph version 15.2.8 (bdf3eebcd22d7d0b3dd4d5501bee5bac354d5b55) octopus (stable)

Yea, 15.2.8:
ceph version 15.2.8 (bdf3eebcd22d7d0b3dd4d5501bee5bac354d5b55) octopus (stable)

We're not seeing this in our CI so it might be related to your setup (I mean, it seems to be a ceph-volume bug but not triggered in our setup).
Could you tell more more about your storage configuration ? What are all this dm devices ?

We're not seeing this in our CI so it might be related to your setup (I mean, it seems to be a ceph-volume bug but not triggered in our setup).
Could you tell more more about your storage configuration ? What are all this dm devices ?

The dm devices are multipathed single disks (dual-connected JBODs).  I've tried using the sdx device naming as well for a single path and got the same error.  We have 48x14TB disks per osd server as well as 2 each 14TB nvme sticks.  JBODs are basic supermicro 60 disk shelves connected to LSI/Broadcom HBAs (SAS3216 based).
Curiously this is happening without including the OSD role in my site.yml, just the mon role so it's clearly just checking devices, not actually trying to configure them quite yet.

The dm devices are multipathed single disks (dual-connected JBODs).  I've tried using the sdx device naming as well for a single path and got the same error.  We have 48x14TB disks per osd server as well as 2 each 14TB nvme sticks.  JBODs are basic supermicro 60 disk shelves connected to LSI/Broadcom HBAs (SAS3216 based).
Curiously this is happening without including the OSD role in my site.yml, just the mon role so it's clearly just checking devices, not actually trying to configure them quite yet.

Oh I missed it from the ceph-volume log. So all dm are actually multipath devices.
You should probably take a look at [1]
If it doesn't help at all, I'll suggest you to open a bug on the ceph-volume tracker [2]
Alternatively you can switch to the lvm_volumes configuration instead of using devices/dedicated_devices for lvm batch but this would require some LV/VG creation manually.
[1] https://docs.ceph.com/en/latest/ceph-volume/lvm/prepare/#multipath-support
[2] https://tracker.ceph.com/projects/ceph-volume/issues

Oh I missed it from the ceph-volume log. So all dm are actually multipath devices.
You should probably take a look at [1]
If it doesn't help at all, I'll suggest you to open a bug on the ceph-volume tracker [2]
Alternatively you can switch to the lvm_volumes configuration instead of using devices/dedicated_devices for lvm batch but this would require some LV/VG creation manually.
[1] https://docs.ceph.com/en/latest/ceph-volume/lvm/prepare/#multipath-support
[2] https://tracker.ceph.com/projects/ceph-volume/issues


setting the blend amount of AnimationNodeBlend2 in GDScript

Godot version:
master branch
Issue description:
I found that there is no way to set the blend amount of AnimationNodeBlend2
Say I already get the animation node of a AnimationNodeBlend2,
then I try to set:
set_parameter("blend_amount", 0.5)
but it does not work
So can I set the blend amount of a AnimationNodeBlend2 in gdscript?

I do not know when this was added or if it was already like this when you created the issue, but it is possible to set the blend amount as follows (in 3.1-alpha2):
$AnimationTree.set("parameters/MyBlendNode/blend_amount", 1.0)
I have also tried getting the blend node with $AnimationTree.tree_root.get_node("MyBlendNode") and then setting the blend amount on that manually, like you would with every other node in Godot, though that doesn't seem possible at the moment.

This issue can be closed. There are still some difficult things to find out about AnimationNodes, but this specific issue is now documented: https://docs.godotengine.org/en/3.5/tutorials/animation/animation_tree.html#controlling-from-code


[WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys

What changes were proposed in this pull request?

The join condition returned from ExtractEquiJoinKeys does not correspond to the equi-join on the extracted left and right keys. A call site can be risky if it is not aware of that.
The pattern extractor should extract the rest of original join condition as well.
Why are the changes needed?

Does this PR introduce any user-facing change?

No
How was this patch tested?

Existing tests.

Can one of the admins verify this patch?

@cloud-fan @sigmod FYI

add to whitelist

Test build #143270 has started for PR 33985 at commit cf10e32.

Test build #143270 has finished for PR 33985 at commit cf10e32.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143270/

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47773/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47773/

Test build #143272 has started for PR 33985 at commit 460c6b0.

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47775/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47775/

Test build #143272 has finished for PR 33985 at commit 460c6b0.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143272/

Test build #143274 has started for PR 33985 at commit efd33df.

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47777/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47777/

Test build #143274 has finished for PR 33985 at commit efd33df.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143274/

Test build #143275 has started for PR 33985 at commit 62b7307.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47778/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47778/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47778/

Test build #143275 has finished for PR 33985 at commit 62b7307.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143275/

Can one of the admins verify this patch?

Test build #143319 has started for PR 33985 at commit 0a94c1e.

There is a normalization of the keys for the join at the code below, that
probably doesn't pre-exist in the conditionOfJoinKeys
On Wed, Sep 15, 2021 at 12:49 AM Wenchen Fan @.***>
wrote:

@.**** commented on this pull request.
In
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NormalizeFloatingNumbers.scala
https://github.com/apache/spark/pull/33985#discussion_r708929828:

@@ -67,7 +67,7 @@ object NormalizeFloatingNumbers extends Rule[LogicalPlan] {
// Only hash join and sort merge join need the normalization. Here we catch all Joins with
// join keys, assuming Joins with join keys are always planned as hash join or sort merge
// join. It's very unlikely that we will break this assumption in the near future.

 case j @ ExtractEquiJoinKeys(_, leftKeys, rightKeys, condition, _, _, _)

 case j @ ExtractEquiJoinKeys(_, leftKeys, rightKeys, condition, _, _, _, _)

We can simplify the code here now. We don't need to restore the original
join condition by constructing the EqualTo expressions manually. We can
just use the new predicatesOfJoinKeys
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/spark/pull/33985#pullrequestreview-754779063,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVNFVECXZUI3XRCUAIVAB3LUCBF2FANCNFSM5D7BNYPQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47822/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47822/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47822/

Test build #143319 has finished for PR 33985 at commit 0a94c1e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143319/

thanks, merging to master!


Customized ZonedDateTime format in ObjectMapper gets overridden

My own custom ZonedDateTime format is overridden by the com.microsoft.azure.spring.data.cosmosdb.core.convert.MappingDocumentDbConverter.readInternal method
Here is the culprit:
https://github.com/microsoft/spring-data-cosmosdb/pull/264
objectMapper.registerModule(provideAdvancedSerializersModule());

Hello @kxmas , yes this is an issue, and we are fixing it soon.
I am planning to register the modules in MappingDocumentDbConverter, and not on the readInternal method, would that be okay ?
Also, I noticed that MapperFeature.IGNORE_DUPLICATE_MODULE_REGISTRATIONS(true) is enabled by default, so registering shouldn't have overloaded your ZonedDataTimeFormatter because it takes the first registered module and skips any more registering if the module has the same name.

Hi @kushagraThapar,
As I understand it, modules are collections of formatters, and not the formatters themselves, so to me it's not clear what the behavior will be.
My problem with the code is that it was registering the formatter every time it deserialized something. Moving that registration out of readInternal is the right thing to do, which is why I also did that in the PR I opened (and is still open).
Kevin

@kxmas , merged the PR, closing this issue.


Unsubscribe from "stream" does not clean up internal subscriptions

I'm submitting a ...  (check one with "x")
[x] bug report => check the FAQ and search github for a similar issue or PR before submitting
[ ] support request => check the FAQ and search github for a similar issue before submitting
[ ] feature request

Current behavior
When I unsubscribe from the Observable returned by a "stream" method call, an internal subscription stays in memory.
Expected/desired behavior
When I unsubscribe from a stream also the internal stuff is unsubscribed.
Reproduction of the problem
http://plnkr.co/edit/fIi2Xl0XVpl5eXQYT7GP?p=preview
I tried to make a plnkr that actually did what I wanted to show but it was not very easy. This plnkr subscribes to a single string each 3 seconds and unsubscribes a second later. To then see the memory leak, I made heap snapshots (after running gc of course) in Chrome. The number of "Subscriber" objects keeps increasing. The gc root path of all the objects that remain in memory look like:
destination in MergeMapSubscriber @1247973
  parent in InnerSubscriber @1247983
    destination in SwitchMapSubscriber @1247989
      generatorOrNext in system / Context @1247995
        context in () @1248001
          _complete in SafeSubscriber @1248005
            destination in Subscriber @1247827
              [18] in Array @943305
                observers in EventEmitter @943251
                  onLangChange in TranslateStore @939611
                    store in TranslateService @939609
                       translate in AppComponent @941593

So it seems like the stream method does not clean up the subscription to onLangChange. I'm not sure whether this is a shortcoming of ngx translate or the rxjs switchMap/concat implementation by the way!
What is the expected behavior?
No memory leak!

ngx-translate version: 8.0.0

Angular version: 5.0.2

Browser: [all? | Chrome]

Did you try to complete it instead of just unsubscribing ?

Tried it in the plnkr now. Unfortunately I have the same results ...

Thanks for the report as I was struggling with large memory leak issues in a medium-size app for some days now.
In fact, because of this memory leak you reported, the component (and ALL its children) subscribing (through async pipe in my case) to the observable from the .stream() call wasn't properly removed from memory (even after a garbage collector).
It can cause very large memory leak when you have some big nested components.
By the way thanks for the workaround, I have written a simple helper function which I use everywhere I was using .stream() previously :
export function streamTranslate(translateService: TranslateService, keys: string | Array<string>, params?: any): Observable<any> {     return translateService.onLangChange.pipe(         startWith({}),         switchMap(() => params ? translateService.get(keys, params) : translateService.get(keys))     ); }

Hi,
Is this issue still valid? It's better use the workaround or this bug was fixed?

Hi guys,
i have the same problem right now with ngx-translate v13.
For real i'll must unsubscribe manually stream ?
because the get method not change when onLangChange emit the new value and we must use the stream method.
For now i use the tzoratto fix and manually unsubscribe observale in ondestroy event.
Any updates?

Thanks for the report as I was struggling with large memory leak issues in a medium-size app for some days now.
In fact, because of this memory leak you reported, the component (and ALL its children) subscribing (through async pipe in my case) to the observable from the .stream() call wasn't properly removed from memory (even after a garbage collector).
It can cause very large memory leak when you have some big nested components.
By the way thanks for the workaround, I have written a simple helper function which I use everywhere I was using .stream() previously :
export function streamTranslate(translateService: TranslateService, keys: string | Array<string>, params?: any): Observable<any> { return translateService.onLangChange.pipe( startWith({}), switchMap(() => params ? translateService.get(keys, params) : translateService.get(keys)) ); }

Hi,
The problem is still present (2022)?

same problem, any update (2023)?


1.3

@rultor release tag is 1.3

@rultor release tag is 1.3

@portlek Invalid release tag 1.3 specified. There is already a release 1.3 newer than the given release in this repository.

@rultor release tag is 1.3

@portlek I'm sorry, I don't understand you :( Check this page and try again please


New dataset info tab (How can you learn more?)

Adds a new tab with info about the dataset

Thanks!! Possible to use the human readable name in the dataset pulldown? (ie "Microsetta WGS all samples")?
Looking at the code in a moment

Can we add it to the response in the array of dataset names that a sample is in so I don't have to query 5 more times before I can create the pulldown?

All for it, let’s resolve this PR as is, and adjust the pub API. Able to issue a PR for that on the pub API? George is hammering in the nearest neighbor stuff
I’ll have a PR soon for the beta caching which will allow us to scale our the pub api further...

On Mar 12, 2021, at 2:34 PM, Daniel Hakim @.***> wrote:
Can we add it to the response in the array of dataset names that a sample is in so I don't have to query 5 more times before I can create the pulldown?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/biocore/microsetta-interface/pull/107#issuecomment-797794591, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADTZMXSY6BNEZNI5TXAWATTDKCHZANCNFSM4ZDCEJFA.

only the best words :)


Updated diagrams on Average Precision page

Linked issue(s):
What change does this PR introduce and why?
Please check if the PR fulfills these requirements

[ ] Include reference to internal ticket and/or GitHub issue "Fixes #NNNN" (if applicable)
[ ] Relevant tests for the changes have been added
[ ] Relevant docs have been added / updated

@pvanburen, I tried running this locally and the texts seem to be broken just like the KOL-3353 Poor text display on docs graphics.


use update instead of validate for ddl-auto

With the update we will have to test in the future whether we do not destroy the database when we make changes to the persistence layer.

 [Detector] Create database with sql script


Buffering in heat pumps does not seem to do anything

There is no difference between the blue and green curves

There's no volume set on the heat pumps in that LES. Presumable they can't buffer an infinite amount of energy, so lacking a volume, they won't buffer anything at all.
Setting a volume seems to inflate the loads though; I'm not sure why. I'll look into it also.

Hmm... the load is inflated because when you supply a volume, the assumption is that you're using availability curves instead of load curves. This is a tricky one because that is true for EV but not for heat pumps.

This is a tricky one because that is true for EV but not for heat pumps.

For heat pumps we do have both availability curves and load curves. Aren't they used both?

No, the current behaviour (when heat pumps are on or off) is based on a "use" profile:

Buffering in heat pumps disabled:
Places a load on the network according to values in the "use" profile.

Buffering in heat pumps enabled:
Buffers whenever there is sufficient network capacity, and stores this energy internally for later. Energy is subtracted from the stored amount according to the "use" profile. If there is insufficient energy stored in the buffer, a load will be placed on the network to make up the difference.

For example
We might give a heat pump a use profile such as: [0, 0, 0, 0.5, 0.4, 0.5], a capacity of 1.0 and volume of 2.0 (values in kW).
With buffering disabled, the heat pump load follows the profile [0, 0, 0, 0.5, 0.4, 0.5].
With buffering enabled, the heat pump will start to buffer immediately (assuming network capacity permits): [1.0, 1.0, 0.0, 0.5, 0.4, 0.5]. The buffer fills entirely in the first two steps; it places loads on the network in the final three steps to refill the amount used. If the network had become constrained at that point, the loads might look like: [1, 1, 0, 0, 0, 0].

Value
1
2
3
4
5
6

Network Capacity
∞
∞
∞
∞
∞
∞

Amount Used ("Use profile")
0.0
0.0
0.0
0.5
0.4
0.5

External Load
1.0
1.0
0.0
0.5
0.4
0.5

Amount Stored
1.0
2.0
2.0
2.0
2.0
2.0

Value
1
2
3
4
5
6

Network Capacity
∞
∞
∞
0.0
0.0
0.0

Amount Used ("Use profile")
0.0
0.0
0.0
0.5
0.4
0.5

External Load
1.0
1.0
0.0
0.0
0.0
0.0

Amount Stored
1.0
2.0
2.0
1.5
1.1
0.6

Value
1
2
3
4
5
6

Network Capacity
0.0
0.0
0.0
0.0
0.0
0.0

Amount Used ("Use profile")
0.0
0.0
0.0
0.5
0.4
0.5

External Load
0.0
0.0
0.0
0.5
0.4
0.5

Amount Stored
0.0
0.0
0.0
0.0
0.0
0.0

I'm trying to make it work but somehow I'm not sure if the current buffering is working as it should.
As you can see at:
https://github.com/quintel/etmoses/compare/master...issues/%23266-buffering-heat-pumps-not-working#diff-697edaa1d8f85247b43b4350cd51e35bR106
However I have no idea what is influencing the output in the current setup.

Here's an example of it working (turn on "Buffering in heat pumps").
Here's the technology profile:
{
  "Consumer": [
    {
      "name": "Buffer",
      "type": "households_space_heater_heatpump_air_water_electricity",
      "behavior": null,
      "profile": [0.0, 0.0, 1.0, 1.0],
      "load": null,
      "capacity": 500.0,
      "demand": null,
      "volume": 1000.0,
      "units": 1,
      "concurrency": "max"
    },
    {
      "name": "Base load",
      "type": "base_load",
      "behavior": null,
      "profile": [0.0, 0.0, 1.0, 1.0],
      "load": null,
      "capacity": 500.0,
      "demand": null,
      "volume": null,
      "units": 1,
      "concurrency": "max"
    }
  ]
}

We might give a heat pump a use profile such as: [0, 0, 0, 0.5, 0.4, 0.5], a capacity of 1.0 and volume of 2.0 (values in kW)

Just to avoid confusion: the capacity is specified in units of kW and the volume in units of kWh.

With buffering disabled, the heat pump load follows the profile [0, 0, 0, 0.5, 0.4, 0.5].

The profiles (both 'use' and 'availability') for heat pumps should be scaled by the storage volume of the tank (also see https://github.com/quintel/etmoses/issues/299). So, if the volume and capacity are specified as above, a use/availability of 0.5 translates into `0.5 * 2.0


SSL error

i have problem with ssl:
PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target.
but metabase started with keystor java, system and java keystore have this certificate.
I can not specify the path to the certificate in the plugin.

Have the same issue, where can we put certificate if we can specify path to it

Do you know the corresponding option in the JDBC driver?

Could you show where and what options need to be added?

The parameter is called sslrootcert. Connection example
"jdbc:clickhouse://%s:8443/%s?ssl=1&sslmode=strict&sslrootcert=%s"

probably related to #85

We just released 0.8.3, which should bring back "additional JDBC connection string options".
Please try specifying additional JDBC connection string options (something like sslrootcert=/path/to/CA.crt as was suggested by @smarkov92)
That should be available under the "advanced options":

Please feel free to re-open the issue if it does not work for you.


Create Flipside Dashboard for Testnet Transaction Events

Transaction Inspection Logic

Introduction:
Transaction Inspection Logic is a feature designed to enhance the integrity and security of the Cadence 1.0 migration process. By carefully evaluating each transaction, this system helps detect and mitigate issues early, ensuring a smoother migration experience.

Objectives:
Identify transactions that fail due to incomplete or incorrect dependencies during the migration.
Provide detailed metrics for a dashboard to track inspection results.
Gradually refine the blocking mechanism to prevent problematic transactions on the testnet.

Transactions will be marked as either passing (dependencies staged) or failing (dependencies not staged).

Dashboard Metrics: Provide data via a FLIPSIDE or other dashboard for visibility and analysis

Sharing what contracts have “failed through most transactions”
Sharing percentage of transactions that “pass” vs “fail”
Explicitly sharing all the dependencies that are failing inspection.

Informed that Flipside does not currently support Testnet (yet), and we won't know if we're going to get that support until atleaest the 17th when the lead developer is back


[9.x] Add callback to exception ignore method

This PR adds the ability to pass a callback to the ignore() method in the exception handler, in order to decide whether to report the exception at runtime. This is particularly useful when some exceptions provided by SDKs aren't specific and you need to dig a bit deeper into the exception itself to determine if it should be reported. For example if you get an Aws\Ses\Exception\SesException you may decide to not report it if it's to do with rate limiting.
This PR changes the $dontReport property to an associative array, as well as the ignore method signature. These are breaking changes.
This new functionality can be used in the register() method of the exception handler. Here the FooException will not be reported if the given callback evaluates to true. The callback will receive the exception instance as its only parameter.
public function register()
{
    $this->ignore(FooException::class, function (FooException $exception) {
        return $exception->getCode() === 429;
    });
}

You can also pass a callable class:
public function register()
{
    $this->ignore(FooException::class, new ShouldIgnoreFooException);
}

...

class ShouldIgnoreFooException
{
    public function __invoke(FooException $exception)
    {
        return true;
    }
}

I think I can make this better by making it mimic the reportable method usage. Instead of passing in two parameters, you can just pass in the callback and let it determine the exception type by the type-hint:
$this->ignore(function (CustomException $e) {
    return ! $e->shouldBeReported();
});

@jameslkingsley I agree that would be a bit better.

Note that this functionality is generally already possible by doing:
$this->reportable(function (SomeException $e) {
    if (condition) {
        return false;
    }
});

Ohhh I didn't know that. In that case then there's no need for this PR — doesn't make sense to do the same thing twice but in a different way.

OK 👍


[Feature Request] Windows Support

Comment:
Could you please support Windows.
Reference conda-forge/staged-recipes#24925

Tagging @jakirkham @mingwandroid @ocefpaf.
I don't know if the maintainers are going to get a notification, so I am tagging them. Sorry, if you end up getting too many notifications.

Unfortunately this is highly non-trivial
Proposed some alternatives in the PR: https://github.com/conda-forge/staged-recipes/pull/24925#discussion_r1443642835

Thanks for the immediate reply. I will look at your suggestions and try resolving the issue accordingly.


[create-shuttle-app]: allow<EMAIL_ADDRESS>

Considering Rust's backwards-compatibility, it would be preferential to not require version 1.65.0 exactly for create-shuttle-app.
✔ create-shuttle-app requires Rust v1.65.0, do you wish to install it now?

I have version 1.66.0 which should satisfy all conditions, and would prefer not needing to have 2 versions installed.

Hey Shaun! Yes, any version >= 1.65 should work, but unfortunately we have had some bugs caused by our FFI when when a project is compiled with a different compiler than the cargo-shuttle binary is compiled with, especially on mac and windows: https://github.com/shuttle-hq/shuttle/issues/617. To make this more straightforward and to try to spare users of the CLI from dealing with this, we opted with forcing 1.65 for this version, since that's the compiler the release binary is compiled with. When we bump the version we compile our binary with, we will also bump the node-cli version requirement.
We could change this to only warn about the version requirement, however, and allow the user to proceed with their installation of rust if they want to... That may be the better option here.

@oddgrd Thank you for the context.
If there is an existing bug when using new versions of the compiler, then I would leave the requirement; everyone ignores warnings.
If you already have another issue tracking the bug/fix, then this can be closed 🙂

Haha, fair point. :smile: I'll leave this issue up for now, we have some similar ones but I reckon more people will have this question when using the node-cli. Thanks!

create-shuttle-app now works with any version >= to the one shuttle uses (1.65 now, 1.68 from next week), so I'll close this. :partying_face:


fix: record screen on Iphone

#46 : Fix issue  : Invalid value: Not in inclusive range

Please include the percentage updates in another PR. That makes it easier to review individual changes, and roll them back if needed.

Please include the percentage updates in another PR. That makes it easier to review individual changes, and roll them back if needed.

Thanks for your review. This was my mistake. Percentance feature is not tested, And it is not really necessary to create PR right now.
Currently, I have removed this feature in PR, and adjusted the code format to common format.


🐛 Bug Report:  Flutter App fails to compile on android as soon as Appwrite is added as an dependency

👟 Reproduction steps
When I run a new flutter app it launches as expected, but as soon as I re-run the app by adding Appwrite as an dependency it fails to compile. Below is a video indicating the issue.
https://user-images.githubusercontent.com/53489549/225234121-51203aa0-1cc9-4fc4-a215-dcbf2376a0fb.mp4
👍 Expected behavior
App should launch perfectly fine even after adding Appwrite as an dependency
👎 Actual Behavior
Got these error logs

FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':app:checkDebugDuplicateClasses'.

A failure occurred while executing com.android.build.gradle.internal.tasks.CheckDuplicatesRunnable
Duplicate class kotlin.collections.jdk8.CollectionsJDK8Kt found in modules jetified-kotlin-stdlib-1.8.0 (org.jetbrains.kotlin:kotlin-stdlib:1.8.0) and jetified-kotlin-stdlib-jdk8-1.5.30 (org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.30)
Duplicate class kotlin.internal.jdk8.JDK8PlatformImplementations found in modules jetified-kotlin-stdlib-1.8.0 (org.jetbrains.kotlin:kotlin-stdlib:1.8.0) and jetified-kotlin-stdlib-jdk8-1.5.30 (org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.30)
Duplicate class kotlin.random.jdk8.PlatformThreadLocalRandom found in modules jetified-kotlin-stdlib-1.8.0 (org.jetbrains.kotlin:kotlin-stdlib:1.8.0) and jetified-kotlin-stdlib-jdk8-1.5.30 (org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.30)
Duplicate class kotlin.streams.jdk8.StreamsKt found in modules jetified-kotlin-stdlib-1.8.0 (org.jetbrains.kotlin:kotlin-stdlib:1.8.0) and jetified-kotlin-stdlib-jdk8-1.5.30 (org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.30)
Duplicate class kotlin.streams.jdk8.StreamsKt$asSequence$$inlined$Sequence$1 found in modules jetified-kotlin-stdlib-1.8.0 (org.jetbrains.kotlin:kotlin-stdlib:1.8.0) and jetified-kotlin-stdlib-jdk8-1.5.30 (org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.30)
Duplicate class kotlin.streams.jdk8.StreamsKt$asSequence$$inlined$Sequence$2 found in modules jetified-kotlin-stdlib-1.8.0 (org.jetbrains.kotlin:kotlin-stdlib:1.8.0) and jetified-kotlin-stdlib-jdk8-1.5.30 (org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.30)
Duplicate class kotlin.streams.jdk8.StreamsKt$asSequence$$inlined$Sequence$3 found in modules jetified-kotlin-stdlib-1.8.0 (org.jetbrains.kotlin:kotlin-stdlib:1.8.0) and jetified-kotlin-stdlib-jdk8-1.5.30 (org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.30)
Duplicate class kotlin.streams.jdk8.StreamsKt$asSequence$$inlined$Sequence$4 found in modules jetified-kotlin-stdlib-1.8.0 (org.jetbrains.kotlin:kotlin-stdlib:1.8.0) and jetified-kotlin-stdlib-jdk8-1.5.30 (org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.30)
Duplicate class kotlin.text.jdk8.RegexExtensionsJDK8Kt found in modules jetified-kotlin-stdlib-1.8.0 (org.jetbrains.kotlin:kotlin-stdlib:1.8.0) and jetified-kotlin-stdlib-jdk8-1.5.30 (org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.30)
Duplicate class kotlin.time.jdk8.DurationConversionsJDK8Kt found in modules jetified-kotlin-stdlib-1.8.0 (org.jetbrains.kotlin:kotlin-stdlib:1.8.0) and jetified-kotlin-stdlib-jdk8-1.5.30 (org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.30)

 Go to the documentation to learn how to Fix dependency resolution errors.

Try:

Run with --stacktrace option to get the stack trace.
Run with --info or --debug option to get more log output.
Run with --scan to get full insights.

Get more help at https://help.gradle.org

🎲 Appwrite version
Version 2.0.x
💻 Operating system
Windows
🧱 Your Environment
Below is a snap of my flutter doctor

👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

@Rohit-RA-2020 I figured out the issue, this is because one of our dependencies, flutter_web_auth_2 uses newest version of kotlin version (1.8.0) the quickest solution for now is to update android/build.gradle
buildscript {
    ext.kotlin_version = '1.8.0'
	...
}

Yes, that solves the issue but I guess this needs to be fixed as any dependency should work out of the box and many other users of Appwrite or people just getting started with Appwrite might face the same issue .

Yes, that solves the issue but I guess this needs to be fixed as any dependency should work out of the box and many other users of Appwrite or people just getting started with Appwrite might face the same issue .

Good point. We are working to figure out a solution.

I am terribly sorry for this. I have pushed a new release for flutter_web_auth_2 which should fix the underlying issue.

@Rohit-RA-2020 with new version for flutter_web_auth_2 this issue should already be fixed. If not please let us know, we will release another version for appwrite

Yes it works like charm now. I think we can close this issue now.


Create a form editor that suits for each component

Each component will have a different set of properties, thus once clicking on one component, editor should adapt to it

Fixed in https://github.com/clearbridgesoft/form-builder/commit/2e50a350708ff32b78fafa8d37857757ab606f2d


vnet: Allow assigning more than one static IP address

Summary
Currently, vnet allows only one static IP to a Net (=NIC).
Motivation
We'd like to test cases where we use more than one IP address on your local machine.
Describe alternatives you've considered
We cannot do this with the real network interface. Vnet is the way to go.
Additional context
The specific case I would like to use this feature for is to test TURN server which can have separate IP addresses for TURN ports and relay ports.

Current:
type NetConfig struct {
	StaticIP string
}

Proposal:
type NetConfig struct {
	StaticIP string     // deprecated
	StaticIPs []string
}


Scrollable Cursors

Currently only block cursors are supported in result sets. zdb should support scrollable cursors as well, in case a user wants to use zdb to do that.

First step would be to replace calls to statement.fetch() with statement.fetchScroll(.FetchNext, 0), that way the base is already there.

I will work on adding this as I need a pool of cursors working together for bulk exports. Is an export pool something you would want in this library? Or should I add it in a separate library?


[Question] Include only fetch in globalThis

Yes, i'm already asked this question at stackoverflow, left 2 weeks, i still doesnt get the any help.
How to include only fetch autocomplitions for typescript in monaco editor?
Tried to set it up for hours, but it never worked.

I suggest to add more details to your question on stackoverflow!
Unfortunately, we don't have the resources to research/answer questions.


fix: valueOr and withValue utilities

This PR fixes a double call when using the valueOr, withValue and toOpt templates.
The issue was found by @chaitanyaprem with a double call of a custom protocol here: https://github.com/waku-org/nwaku/blob/feat--nwaku-sync/waku/waku_sync/protocol.nim#L125-L126

Codecov Report
Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.56%. Comparing base (03f67d3) to head (5081127).

Additional details and impacted files

@@             Coverage Diff              @@
##           unstable    #1079      +/-   ##
============================================
- Coverage     84.82%   84.56%   -0.26%
============================================
  Files            91       91
  Lines         15428    15487      +59
============================================
+ Hits          13087    13097      +10
- Misses         2341     2390      +49

Files
Coverage Δ

libp2p/utility.nim
30.00% <88.88%> (-14.00%)
:arrow_down:

... and 9 files with indirect coverage changes