Reconsider use of fdatasync()

Nocache is a great way to prevent buffer cache pollution e.g. by rsync.
Unfortunately I just found out the hard way that it also totally destroys rsync performance with small-file workloads due to calling fdatasync() (via sync_if_writable() in free_unclaimed_pages()). Since this happens for every little file (incl. temp files!) on close(), performance becomes completely unacceptable. Not only is it dog slow, it is also not helpful for drive longevity.
I have for now preloaded libeatmydata in addition to nocache, which negates this effect and restores performance; however this should not be necessary. fadvise() works just fine without prior fsync() - buffer pages are flushed out in nice batches, and still marked for reuse.
Unless there is a technical reason that I'm unaware of please consider removing the use of fdatasync().

While looking at the (unrelated) current issue with glibc 2.28 I just realized I never commented on
this. Since it's been >4 years I guess I might as well get over it.. :)
Long story short: I never ended up with the planned "complicated" solution of batching small-file writes together and doing syncfs() for a whole target fs, with a delayed fadvise() for the whole batch. Instead I just applied a patch that simply skips fsync() for small files < 8MB, and that fixed 99% of my performance problem while at the same time cleaning the page cache "well enough" after copying larger files.
If anybody cares, the commit in question is here.
Maybe this can be an inspiration for an official flag to reduce fsync() overhead. Given all my other commitments I don't see myself contributing to this anymore any time soon.


How to expose Metafields in the the theme

Hi bro... greate work with this theme.
I need to know how to implement custom configuration in the gatsby-source-shopify plugin directly from the theme, your theme doesn't have options to do that. Or I missing something??
Thanks for your helpe with this!

Hi there, what version are you on? On 0.1.18, it requires you to install gatsby-source-shopify separately, and you'll be able to do all the config you need to do on that

You'll also need to pass shouldConfigureSourcePlugin: false to the theme options (forgot to mention that)

Thanks man, just make shouldConfigureSourcePlugin: true and expose the metafields via storefront api...

@adinjesuha I think your issue is probably solved; reopen this if you are still facing the issue


Wrong ordering in pokemon window

Minor bug: Sometimes, it orders the Pokemon by CP, even though the "Sort by IV" tab is selected. Changing the ordering to CP or #, and going back makes it sort by IV correctly.
EDIT: Found out exactly what caues it. Steps to reproduce:

Open the Pokemon window
Click on Sort by IV
Close the Pokemon window
Open the Pokemon window again

It now shows the Pokemon ordered by CP, even though "Sort by IV" is selected at the top.

I can confirm "Sort by #" is weird right now.
Its descending instead of ascending and clicking on the button again seem to toggle the order inside each number but I'm not sure what it's doing exactly.

@Algent This is expected (somewhat), as I prefer sorting in a descending way.

Shouldn't it be descending for CP and IV, but ascending for #, the same way the game client does it.

make sens


Featuresupport select into outfile

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run p0

run buildall

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 40.36 seconds
stream load tsv:          459 seconds loaded<PHONE_NUMBER>9 Bytes, about 155 MB/s
stream load json:         22 seconds loaded<PHONE_NUMBER> Bytes, about 102 MB/s
stream load orc:          57 seconds loaded<PHONE_NUMBER> Bytes, about 18 MB/s
stream load parquet:          28 seconds loaded 861443392 Bytes, about 29 MB/s
insert into select:          64.9 seconds inserted 10000000 Rows, about 154K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230627154814_clickbench_pr_168935.html

run buildall

run buildall

run buildall

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 40.2 seconds
stream load tsv:          456 seconds loaded<PHONE_NUMBER>9 Bytes, about 156 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          57 seconds loaded<PHONE_NUMBER> Bytes, about 18 MB/s
stream load parquet:          28 seconds loaded 861443392 Bytes, about 29 MB/s
insert into select:          65.9 seconds inserted 10000000 Rows, about 151K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230703043144_clickbench_pr_171145.html

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 51 seconds
stream load tsv:          504 seconds loaded<PHONE_NUMBER>9 Bytes, about 141 MB/s
stream load json:         19 seconds loaded<PHONE_NUMBER> Bytes, about 118 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          28.4 seconds inserted 10000000 Rows, about 352K ops/s
storage size:<PHONE_NUMBER>7 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230710114613_clickbench_pr_175545.html

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 52.91 seconds
stream load tsv:          505 seconds loaded<PHONE_NUMBER>9 Bytes, about 141 MB/s
stream load json:         19 seconds loaded<PHONE_NUMBER> Bytes, about 118 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select:          29.5 seconds inserted 10000000 Rows, about 338K ops/s
storage size:<PHONE_NUMBER>5 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230712171059_clickbench_pr_177087.html

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.2 seconds
stream load tsv:          448 seconds loaded<PHONE_NUMBER>9 Bytes, about 159 MB/s
stream load json:         19 seconds loaded<PHONE_NUMBER> Bytes, about 118 MB/s
stream load orc:          57 seconds loaded<PHONE_NUMBER> Bytes, about 18 MB/s
stream load parquet:          28 seconds loaded 861443392 Bytes, about 29 MB/s
insert into select:          26.5 seconds inserted 10000000 Rows, about 377K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230712103043_clickbench_pr_177086.html


Adding Node Package

moving IsNodeSchedulable, GetNodesListBySelector and GetNumTargetedNodes functions to Node package.
adjusting existing unit tests accordingly.
when you cr, please tell me if the function FindNodeCondition in line 206 in file /internal/controllers/nmc_reconciler.go should also move, if so I will commit it also to the PR :)

fix #507

/assign @yevgeny-shnaidman

Codecov Report
Attention: Patch coverage is 58.33333% with 20 lines in your changes missing coverage. Please review.

Project coverage is 71.43%. Comparing base (fa23a9b) to head (757ebd2).
Report is 70 commits behind head on main.

Files
Patch %
Lines

internal/node/node.go
62.50%
12 Missing :warning:

cmd/manager/main.go
0.00%
5 Missing :warning:

internal/controllers/build_sign_reconciler.go
50.00%
1 Missing :warning:

internal/controllers/device_plugin_reconciler.go
75.00%
1 Missing :warning:

internal/controllers/module_nmc_reconciler.go
50.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #844      +/-   ##
==========================================
- Coverage   79.09%   71.43%   -7.67%
==========================================
  Files          51       67      +16
  Lines        5109     4481     -628
==========================================
- Hits         4041     3201     -840
- Misses        882     1085     +203
- Partials      186      195       +9

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

when you cr, please tell me if the function FindNodeCondition in line 206 in file /internal/controllers/nmc_reconciler.go should also move, if so I will commit it also to the PR :)

I think it should indeed :)
Here is another place that contain potential code that can be moved to the new Node interface/package:
We also can add 2 methods to the new Node interface RemoveLabels and SetLabels and use them in UpdateNodeLabelsAndRecordEvents - @yevgeny-shnaidman WDYT about this one?

UpdateNodeLabelsAndRecordEvents

I think that UpdateNodeLabelsAndRecordEvents functions should be broken up and refactored - it is to long and therefore not really readable. I am not sure regarding SetLabel and DeleteLabel, maybe we can move the whole logic and setting the labels and updating the node to the new package?

I think that UpdateNodeLabelsAndRecordEvents functions should be broken up and refactored - it is to long and therefore not really readable. I am not sure regarding SetLabel and DeleteLabel, maybe we can move the whole logic and setting the labels and updating the node to the new package?

This function contain much more than generic node code so I don't think it belongs in the new interface.
We can leave it for now and refactor it in a follow up task.

/ok-to-test
/approve
@yevgeny-shnaidman can lgtm when he is happy with the PR for it to be merged.

/lgtm


Added get/list/describe api bindings in new erlcloud_cloudformation module

Problem

Would like to be able to call get/list/describe functions for aws cloudformation

Solution

New Cloudformation module with all non PUT/DELETE API functions

thanks for the contribution - great to have some cloudformation support.


[xwalk-2884][wrt] Add test for packertool2

Impacted TCs num(approved): New 1, Update 0, Delete 0
Unit test Platform: Android
Android test result summary: Pass 1, Fail 0, Block 0

Validate if packer tool can work well about double size on second running ==>
Validate the apk size will not be increased to double size or more on second running

Updated

LGTM


Update HelloWorldScene.cpp

replace   _director->end();  with menuCloseCallback(this);
THIS PROJECT IS IN DEVELOPMENT MODE. Any pull requests should merge to branch dev, otherwise will be rejected immediately.
Describe your changes
Issue ticket number and link
Checklist before requesting a review

[x] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.
[x] I have checked readme and add important infos to this PR (if it needed).
[x] An improved cpp-test/lua-test is not needed (explain why not, thanks).

@halx99 You can merge.
No more changes planed at the moment


Add 'thin_metadata_size' and 'mkfs_options' to Logical Volume

Attribute 'thin_metadata_size' specifies the size of the metadata volume
for a LVM thinpool.
Attribute 'mkfs_options' option passes options to mkfs as part of
logical volume creation.
Fixes #ENGT-9767
@vitroth @zquestz
CC: @earlruby

LGTM


Exclude sections that don’t have URLs

Might it make sense to prevent selection of entries within sections that do not have URLs?
/**
 * Returns all sections that have URLs.
 *
 * @return array An array of Section instances
 */
public function getSectionsWithUrls()
{
    return array_filter(craft()->sections->allSections, function ($section) {
        return $section->isHomepage() || $section->urlFormat;
    });
}

Source

Thanks for the feedback, this will be included in an upcoming rewrite to the plugin which is due to be released shortly, no major changes to functionality, just improvements to the code base and the way data is stored and accessed.

Fixed in the latest release, please make sure you backup and test out pre launch!

:+1: Thanks.


Add declarative equivalent of JUnit's assertThrows

Since version 4.13, JUnit has added assertThrows, with typical JUnit style "expected first argument, actual second argument".
Hamcrest does not have a declarative equivalent.
As a developer, I want to have a declarative equivalent of Junit's assertThrows, so that I can consistently use Hamcrest's declarative syntax when writing unit tests.
So, given the JUnit syntax:
assertThrows(Throwable.class, () -> methodThatThrows())
I would like to be able to write something like this in Hamcrest syntax:
assertThat(() -> methodThatThrows(), throws(instanceOf(Throwable.class)));
Of course, throws is a reserved keyword in Java, so that would have to become for example doesThrow instead.

While preparing a fix, I realized that the functionality I desire leverages Java 1.8 lambda expressions, while Hamcrest is still on Java 1.7.
Java 1.7 was abandoned years ago, I hope it won't be a problem to bump Hamcrest to Java 1.8 too.

I've prepared a fix that adds the desired functionality.

Added <T extends Throwable> MatcherAssert.assertThat(String reason, Executable executable, Throws<T> doesThrow).
Added similar convenience method without reason.
Executable is similar to JUnit's class with the same name, but I gave Hamcrest its own not to be tied down to a JUnit-specific dependency and in addition Hamcrest's is not a @FunctionalInterface because it needs to be Java 1.7 compliant.
To avoid signature conflicts with other assertThat methods, Throws is not a Matcher itself, but is a distinct type.
Added multiple factory methods for throwable matchers to Matchers, backed by a Throws class, in line with Hamcrest design, like doesThrow, throwsInstanceOf etc.
Settled for doesThrow because throws is a reserved Java keyword.

Some examples of use (using Java 1.8):
assertThat(() -> methodCallThatThrowsException(), doesThrow(instanceOf(Exception.class));
// Shorthand for the above
assertThat(() -> methodCallThatThrowsException(), throwsInstanceOf(Exception.class));
// Match throwable's cause rather than throwable itself
assertThat(() -> methodCallThatThrowsExceptionWithCause(), doesThrow(becauseOf(instanceOf(CauseException.class)));
// Match throwable's message
assertThat(() -> methodCallThatThrowsExceptionWithMessage(), doesThrow(withMessage(startsWith("start of message"))));

I created a PR for my changes, but it doesn't link correctly.
Not sure what is wrong, I could use some guidance here.


BlobClient Uri now returns url encoding paths. Is this intended?

Hi, in the old version of Azure.Storage.Blobs (12.4.4 and down), the BlobClient.Uri returns a uri without the path encoded, but the new versions (12.5.1 and up), returns uri with path as encoded characters.
Example: below is the old versions 12.4.4

And below here is new version 12.5.1

I can download the "foo.txt" file whether i download it from "/devstoreaccount1/scratch/hello/foo.txt" or "/devstoreaccount1/scratch/hello%2Ffoo.txt"
But the problem right now is the name of the file will be different.
I'm using a third-party service, that will for example download a file, and save the file in their own system as "foo.txt", but if i use the new version, the third-party service will name the file "hello2Ffoo.txt" which is not what i wanted.
This means the fix to my problem is that i either have to manually replace all "%2F" to "/" or use the old 12.4.4 version.
So was this intended or is it a bug?

Thanks for reaching out to us , but at this time it does not look like you are referring to a document but to a specific scenario . If that's the case we request you to please post your question on Q & A and other forums , we have our engineers and others who are monitoring them and will be happy to help .
If you have a document which you are following and if you think it needs  an update , please let us know about that here .

Thanks for reaching out to us , but at this time it does not look like you are referring to a document but to a specific scenario . If that's the case we request you to please post your question on Q & A and other forums , we have our engineers and others who are monitoring them and will be happy to help .
If you have a document which you are following and if you think it needs an update , please let us know about that here .

Ahh sorry, i'll try to post in a more relevant place

Thank you for your response. Please do share the forum thread link once you open the issue, so other other readers can refer to it.
Thanks again.


[Bug]: Issue installing Integration - UI Not supported

Contact Details
<EMAIL_ADDRESS>What happened?
A bug happened! When clicking your link to install integration, complains around configuration not support in the UI and I have no updates pending. Im on the latest.

Am I doing something wrong to install this?
Version
2.2.4
Relevant log output form Home Assistant
see nothing in logs

Downloaded integration debug logs.
see nothing in logs

Try to search for Olarm Sensors.

Have you added it via HACS, and then downloaded it with HACS before trying to install it?

+1 same issue for me.  HomeAssistant docker install.  Made sure it was on the latest version.  I have HACS installed however trying to search and download from inside HACS the "Olarm Sensors" integration does not find it. Nor does it find it if I just search for "Olarm"  See screenshot.
Trying with the link install as per @HallCraig's original post above results in the same error.  "UI Not supported"

You have then not added the repository to hacs as per install guide.

You have then not added the repository to hacs as per install guide. Add it under the repositories tab. https://github.com/rainepretorius/olarm-ha-integration

Yep. This is my bad. I was so excited to finally see Olarm integration apparently I forgot how to read properly.  I can confirm it installed first time now no issues.  Thanks for the integration and help. ;-)

No problem. Glad you were able to install it first try with no issues. Always happy to help and support the growing comunity.

That was my problem also, a newbie mistake. I needed to add your GitHub repro as a custom repro to HACS...then I could find it and download it. My bad :) buy you a coffee shortly.


[fastlane_core] Updated changelog loader to follow redirects

After moving the repos to fastlane-old

Great notes, thanks @mfurtak, moved over to https://github.com/fastlane/fastlane/pull/4582

@mfurtak I also updated our existing code base: https://github.com/fastlane/fastlane/pull/4583


upgrade to , something error in sqllab

upgrade from apache/superset:c2c8efc3c431cc81bdc93d3595c5c582eb721090  to apache/superset:b94052e438944b34ef30681e976bf1842ba4e0a5, some error in sqllab. help~
Traceback (most recent call last):
File "/usr/local/lib/python3.8/site-packages/flask/app.py", line 1517, in full_dispatch_request
rv = self.dispatch_request()
File "/usr/local/lib/python3.8/site-packages/flask/app.py", line 1503, in dispatch_request
return self.ensure_sync(self.view_functions[rule.endpoint])(**req.view_args)
File "/usr/local/lib/python3.8/site-packages/flask_appbuilder/security/decorators.py", line 175, in wraps
return f(self, *args, **kwargs)
File "/home/admin/fire-insight-analysis-ding/superset/views/sql_lab/views.py", line 219, in put
db.session.query(TabState).filter_by(id=tab_state_id).update(fields)
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/orm/query.py", line 3294, in update
result = self.session.execute(
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/orm/session.py", line 1696, in execute
result = conn._execute_20(statement, params or {}, execution_options)
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/engine/base.py", line 1631, in _execute_20
return meth(self, args_10style, kwargs_10style, execution_options)
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/sql/elements.py", line 325, in _execute_on_connection
return connection._execute_clauseelement(
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/engine/base.py", line 1498, in _execute_clauseelement
ret = self._execute_context(
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/engine/base.py", line 1862, in _execute_context
self.handle_dbapi_exception(
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/engine/base.py", line 2043, in handle_dbapi_exception
util.raise(
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/util/compat.py", line 207, in raise
raise exception
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/engine/base.py", line 1819, in _execute_context
self.dialect.do_execute(
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/engine/default.py", line 732, in do_execute
cursor.execute(statement, parameters)
File "/usr/local/lib/python3.8/site-packages/MySQLdb/cursors.py", line 206, in execute
res = self._query(query)
File "/usr/local/lib/python3.8/site-packages/MySQLdb/cursors.py", line 319, in _query
db.query(q)
File "/usr/local/lib/python3.8/site-packages/MySQLdb/connections.py", line 254, in query
_mysql.connection.query(self, query)
sqlalchemy.exc.IntegrityError: (MySQLdb._exceptions.IntegrityError) (1452, 'Cannot add or update a child row: a foreign key constraint fails (fire-insight-ding.tab_state, CONSTRAINT tab_state_latest_query_id_fkey FOREIGN KEY (latest_query_id) REFERENCES query (client_id) ON DELETE SET NULL)')
[SQL: UPDATE tab_state SET changed_on=%s, latest_query_id=%s, changed_by_fk=%s WHERE tab_state.id = %s]
[parameters: (datetime.datetime(2023, 2, 9, 9, 27, 32, 260966), 'Mvni5_2n7', 1, 22)]
(Background on this error at: https://sqlalche.me/e/14/gkpj)

{"errors": [{"message": "(MySQLdb._exceptions.IntegrityError) (1452, 'Cannot add or update a child row: a foreign key constraint fails (superset-0822.tab_state, CONSTRAINT tab_state_latest_query_id_fkey FOREIGN KEY (latest_query_id) REFERENCES query (client_id) ON DELETE SET NULL)')\n[SQL: UPDATE tab_state SET changed_on=%s, latest_query_id=%s, changed_by_fk=%s WHERE tab_state.id = %s]\n[parameters: (datetime.datetime(2023, 2, 9, 9, 53, 16, 276885), 'hClMJDKPx', 1, 5)]\n(Background on this error at: https://sqlalche.me/e/14/gkpj)", "error_type": "GENERIC_BACKEND_ERROR", "level": "error", "extra": {"issue_codes": [{"code": 1011, "message": "Issue 1011 - Superset encountered an unexpected error."}]}}]}

after 'superset init', it works.
I thought 'superset init' was only used for new environments.
--- from baidu translation

my first issue

my first issus

close again

close again

@chiweng2009 i got this issue too. But isn't running superset init reset all the existing database?

superset init didn't help


Studying all decks still reads decks in order

Probably need to emit multiple keys in the view (one for "", one for the actual deck), and always provide the deck argument when querying.

fixed by #102


Alert outputs display 0 seconds in time_formatted message.

EvenMoreFish dev 138
https://ci.codemc.io/view/All/job/Oheers/job/EvenMoreFish/
Is there any way to not display 0s in alert outputs?
# Sent to all players at specific times to show the remaining time left
# {time_formatted} shows the time (e.g. 5m left, 10m 30s left)
# {time_raw} is what you input in competitions.yml
time-alert: "&rThere is {time_formatted} left on the competition for {type}"

    alerts:
      - "5:00"
      - "1:00"

Thank you ever so much for your patience, I somehow missed this.
Right now this isn't possible to get rid of it, but I'll put it on the todo list to be added to the plugin in the future.

This was actually implemented some time ago, but this issue was never closed. Enjoy!


How to change the height of an arc (doughnut), halving its extension?

Please respect our issue guidelines and ask support / question on StackOverflow.


fix(launch): partial git jobs dont require codePath in metadata

Description

Fixes WB-NNNNN
Fixes #NNNN

What does the PR do? Include a concise description of the PR contents.

[ ] I updated CHANGELOG.md, or it's not applicable

Testing
How was this PR tested?

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#7692  👈
#7652
#7651
#7650
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bcsherma and the rest of your teammates on  Graphite


Can't Open Folder as VS Code Project.

After last update (1.15) i reinstall vs code with win X64
now i can't Open Folder as VS Code Project.
Steps :
Right click on any folder
Choose Open Folder as VS Code Project.
Application throw's an Error  "Application not found"

Issue solved by the following steps
1 - Uninstall VS Code
2 - Restart Operating System
3 - Reinstall VS Code


Consider using codecov again

rc-zip is still using it, things are pretty quiet on that front, they reassured us that they will stay free for open-source moving forward, seems safe to use it again.

Well we never stopped, we just stopped using their action.


Are you sure you want to do a "text" based game?

As I tried to emphasize in class, even though any kind of automation / computing can be performed with object-oriented software, as an educational project, one with a graphical UI, rich set of objects, and lots of interaction on the screen is a more suitable project.

Yes.

Hi sir, @ugurdogrusoz
Our game, Mafia:TCoS, has been discussed and designed as similar to Omerta but with not "Massive-Multiplayer" and "browser-based" properties, rather it is a Desktop Client of the original game. [More info about Omerta (https://en.wikipedia.org/wiki/Omerta_(video_game))
Mafia:The City of Sin players would rank up by stealing cars, committing crimes, dealing and producing narcotics. Other than that, our game will have a rich and clean graphical UI, database-connectivity, map and complex "stats" calculations on backend.
Our pre-Alpha mockup of the game has been designed today(21 Feb) and we decided to discuss those mockups with you on the 22 Feb's class, sir.
Thanks for your interest!
Regards.


1.6.7 broke IE scroll links

I upgraded react-scroll to the latest version, and found that all scoll links worked incorrectly in IE (tested version 10 and 11), they jump directly to the page top. Reverting to 1.6.5 fixed the issue.

I have the same issue.

Does v1.7.3 work for you? @ctkc  @Maarten88

Yes!, v1.7.3 works in IE 10 and 11.
Thanks!


feature or bug ?

you can copy paste ops from public team in your own patches

when saving, join public teams


Updating readme from branch example

Updates
I have updated the readme file. Please review and accept

I am the senior developer. I probably shouldn't but oka 👍


Mongodb update reproduce

This branch can reproduce the MongoDB upgrade issue locally.
It only shows up when deploying MongoDB as a replica set. All pods talking to mongo fail with the same log issue
@nicolasburtey @krtk6160
$ k get pods -n galoy-dev-galoy
NAME                                 READY   STATUS             RESTARTS   AGE
galoy-lnpage-55475ddf5-7688s         2/2     Running            0          8m14s
galoy-lnpay-7477d8bdf5-qgfsc         1/1     Running            0          8m14s
galoy-admin-panel-5b6895b974-9dd6l   2/2     Running            0          8m14s
galoy-mongodb-0                      2/2     Running            0          8m14s
galoy-price-68d7bddf8f-jlmp5         1/1     Running            0          8m14s
galoy-mongodb-1                      2/2     Running            0          7m45s
galoy-redis-node-0                   2/2     Running            0          8m14s
galoy-mongodb-2                      2/2     Running            0          7m33s
graphql-admin-7b878bd56c-7rzcq       0/1     CrashLoopBackOff   5          8m14s
exporter-64dffdf4b6-w7km8            0/1     CrashLoopBackOff   5          8m14s
api-647c68b4cf-kmwhw                 0/1     CrashLoopBackOff   5          8m14s
graphql-864d47698b-vrs9v             0/1     CrashLoopBackOff   5          8m14s
trigger-5dc9b88598-8tlsj             0/1     CrashLoopBackOff   5          8m13s
graphql-864d47698b-jfn2d             0/1     CrashLoopBackOff   5          8m14s

$ k -n galoy-dev-galoy logs trigger-5dc9b88598-8tlsj
{"level":30,"time":1636123209234,"pid":1,"hostname":"trigger-5dc9b88598-8tlsj","module":"trigger","msg":"Health check listening on port 8888!"}
{"level":60,"time":1636123239204,"pid":1,"hostname":"trigger-5dc9b88598-8tlsj","err":{"type":"MongooseServerSelectionError","message":"getaddrinfo ENOTFOUND galoy-mongodb","stack":"MongooseServerSelectionError: getaddrinfo ENOTFOUND galoy-mongodb\n    at NativeConnection.Connection.openUri (/app/node_modules/mongoose/lib/connection.js:830:32)\n    at /app/node_modules/mongoose/lib/index.js:342:10\n    at /app/node_modules/mongoose/lib/helpers/promiseOrCallback.js:31:5\n    at new Promise (<anonymous>)\n    at promiseOrCallback (/app/node_modules/mongoose/lib/helpers/promiseOrCallback.js:30:10)\n    at Mongoose._promiseOrCallback (/app/node_modules/mongoose/lib/index.js:1129:10)\n    at Mongoose.connect (/app/node_modules/mongoose/lib/index.js:341:20)\n    at setupMongoConnection (/app/lib/services/mongodb/index.js:33:34)\n    at Object.<anonymous> (/app/lib/servers/trigger.js:239:40)\n    at Module._compile (internal/modules/cjs/loader.js:1085:14)\n    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)\n    at Module.load (internal/modules/cjs/loader.js:950:32)\n    at Function.Module._load (internal/modules/cjs/loader.js:790:12)\n    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:76:12)\n    at internal/main/run_main_module.js:17:47","reason":{"type":"Unknown","setName":null,"maxSetVersion":null,"maxElectionId":null,"servers":{},"stale":false,"compatible":true,"compatibilityError":null,"logicalSessionTimeoutMinutes":null,"heartbeatFrequencyMS":10000,"localThresholdMS":15,"commonWireVersion":null}},"user":"testGaloy","address":"galoy-mongodb","db":"galoy","msg":"error connecting to mongodb"}

Can we close this? We're on Chart v12 now


Tag Form closes twice

When closing form tag, two </form> appears down
Ex:
<form>

</form>
</form>

It's a known bug, just restart atom and it will go away


Can't SSH via TOR

Did all setup as in a guide, ssh locally is available. When using command:
torify ssh<EMAIL_ADDRESS>torsocks -//-
I get error:
port 22: Undefined error: 0
Any fix?

Issue was not having downloaded OpenSSH on MacOS. No longer getting port error - However now getting error: cant resolve hostname. Will have to look into that


Enable working on arweave-js on Windows

ArweaveJS was using mv, mkdir and rm to interact with the project folders. This was preventing the npm scripts to run on Windows and any OS that don't have by default those commands.
I changed these commands to use npm modules that do the same thing, making it all OS compatible.
mv has been replaced with the npm package cp-cli.
mkdir -p has been replaced with the npm package mkdirp
rm has been replaced with rimraf
I also added yarn.lock to instantly use yarn instead of npm if the dev wants to.

Updated transactions to allow getData as suggested by @mk20001 here https://github.com/ArweaveTeam/arweave-js/issues/24
It's something useful to have to get the transaction data without having to get the entire transaction first.
Added tests for getData.
Updated the sub-version to reflect which version will have arweave.transactions.getData


feat(KFLUXINFRA-739): freeze MPC version in PROD

Change production overlays for multi-platform-controller to specify
a fixed version so that a maunal update would be needed in ordr to push
changes to the production clusters.

How was the version determined previously?

The release pipeline is updating the base setup on every merge to the MPC repo. Since the production environment did not previously have overlays overriding it, the MPC version was simply being update automatically in all environments at once.

/retest


Setup Hugo for 2018

We are going to switch our site from jekyll to hugo (https://gohugo.io). The steps that we need to do are:

[ ] Freeze master branch
[x] Create 'hugo' branch
[x] Choose templating base
[x] Migrate templates
[ ] Setup build pipeline
[ ] Generate our first version

Template migration is partial by now, will add full support this week.
After that, I will create the new pipeline setup.


Script executes in wrong dedicated console when focus changes before kernel starts

Problem Description
When a script is executed in a new dedicated IPython console and the focus changes to a different console while the kernel is still starting, the script will be executed in the selected console, not the dedicated console.
What steps reproduce the problem?

Set the run configurations of a script (Crtl+F6) to "Execute in a dedicated console"
Run the script (F5) to open a new dedicated IPython console (let's call it console A)
While the message "Connecting to kernel" is displayed in console A, click to a different console (console B).

What is the expected output? What do you see instead?
I would expect, that the script is executed in the dedicated console A, once the kernel has finished its start-up. Instead, the runfile-command shows up in console B. Console A only shows the normal In [1]: prompt.
This issue may be related to issue #6851. It seems the process upon pressing F5 is to (1) open the new console A, (2) focus on console A, (3) wait until the kernel is started and (4) send the runfile-command to the currently selected console. Step (4) probably assumes that the focused console is still console A from step (2). So if the console is switched to console B during step (3) (or during any other delay of the execution - in #6851 it was the debugger), the script is run in the wrong console.
Once the dedicated console A has been started and the script is run again, the correct console is used (since there is no delay from the kernel startup anymore). The execution of runfile in the wrong console can be especially aggravating, because it clears all variables in that console (even if "Clear all variables before execution" is turned off in the configuration of the script).
This behavior appears on multiple Spyder installations with Winpython and Miniconda (separated by '&' in the sections below) and was on Spyder version 3.3.1 before I updated it.

Versions

Spyder version: 3.3.2
Python version: 3.6.6 64-bit
Qt version: 5.9.3 & 5.6.2
PyQt version: 5.9.2 & 5.6
Operating System name/version: Windows 7 & Windows 10

Dependencies
IPython >=4.0     :  6.5.0 (OK)   & 7.2.0 (OK)
cython >=0.21     :  0.28.5 (OK)  & None (NOK)
jedi >=0.9.0      :  0.12.1 (OK)  & 0.13.2 (OK)
matplotlib >=2.0.0:  2.2.3 (OK)   & 3.0.2 (OK)
nbconvert >=4.0   :  5.3.1 (OK)   & 5.3.1 (OK)
numpy >=1.7       :  1.14.5 (OK)  & 1.15.4 (OK)
pandas >=0.13.1   :  0.23.4 (OK)  & None (NOK)
pycodestyle >=2.3 :  2.4.0 (OK)   & 2.4.0 (OK)
pyflakes >=0.6.0  :  2.0.0 (OK)   & 2.0.0 (OK)
pygments >=2.0    :  2.2.0 (OK)   & 2.3.1 (OK)
pylint >=0.25     :  2.1.1 (OK)   & 2.2.2 (OK)
qtconsole >=4.2.0 :  4.4.1 (OK)   & 4.4.3 (OK)
rope >=0.9.4      :  0.11.0 (OK)  & 0.10.7 (OK)
sphinx >=0.6.6    :  1.7.7 (OK)   & 1.8.3 (OK)
sympy >=0.7.3     :  1.2 (OK)     & None (NOK)

Thanks for reporting. This is a valid bug and we'll take a look at it after releasing Spyder 4 in a couple of months.

This error could be solved with #9725 by having the runfile queued and having the console checking it's queue first thing when ready.


Create rust.txt

add rust datasets repos

please run scripts/download_repos.py and scripts/decompress_repos.py once and see how many of these can be actually downloaded

please run scripts/download_repos.py and scripts/decompress_repos.py once and see how many of these can be actually downloaded

Ok.No problem.


A dataset variable read is not populated when dropped into the workspace

Create dataset writer
drag new data reader
not updated

Fixed by https://github.com/microsoft/jacdac-docs/commit/a70317427836eb1cd281a14e7b666c97a176ac22


Added support for "&" and "^" in path name

Adds a function called "escape_command_characters".
This functions searches the entire length of a given string and converts any instance of "&"/"^" to "^&"/"^^".
This function is necessary because Command Prompt interprets "&"/"^" without a preceding escape caret as a command.

@lmatt-bit It has been four years.


Add Kits section & sub content

@lorforlinux Added content for DIY Neuroscience Kit Basic in the kits section. Please review and merge.

@bhawnasehgal Thank you for your contribution, I am merging it now!


Python (shutdown) leaks

Brought forward from DISPATCH-1962 Make LSan suppressions more targeted and specific (within reason)
= Python leaks
Leaks in CPython itself are known and there is ongoing effort to fight them: https://bugs.python.org/issue1635741 (https://bugs.python.org/issue25302) and https://www.python.org/dev/peps/pep-3121
Here's valgrind suppression file from somebody who actually investigated the Python leaks and identified the harmless ones: https://github.com/libgit2/pygit2/blob/master/misc/valgrind-python.supp
= Router leaks
One example of a hidden leak in dispatch, which is revealed by making Python suppressions more targetted:
9: Direct leak of 56 byte(s) in 1 object(s) allocated from:
9:     #0 0x7f78a3606e8f in __interceptor_malloc (/nix/store/g40sl3zh3nv52vj0mrl4iki5iphh5ika-gcc-10.2.0-lib/lib/libasan.so.6+0xace8f)
9:     #1 0x7f78a2d64afb in qd_malloc ../include/qpid/dispatch/ctools.h:229
9:     #2 0x7f78a2d657da in qdr_core_subscribe ../src/router_core/route_tables.c:149
9:     #3 0x7f78a2c83072 in IoAdapter_init ../src/python_embedded.c:711
9:     #4 0x7f78a2353a6c in type_call (/nix/store/r85nxfnwiv45nbmf5yb60jj8ajim4m7w-python3-3.8.5/lib/libpython3.8.so.1.0+0x165a6c)

The problem is in
class Agent:
    ...
    def activate(self, address):
        ...
        self.io = IoAdapter(self.receive, address, 'L', '0', TREATMENT_ANYCAST_CLOSEST)

IoAdapter refers to Agent (through the bound method reference self.receive) and Agent refers to IoAdapter (through property self.io). Since IoAdapter is implemented in C and does not implement support for Python's cyclic GC, there is no way to break the cycle, collect the garbage, and run destructors.
Heap dump in attachment of the original Jira. The bound method is at the top of the picture. (Ignore the Mock objects, I was trying to simplify the picture while not getting crashes due to too much meddling).
== Random observations
It is possible to build special Debug build of Python, which has tools to detect leaks, asserts to prevent negative refcounts, etc. https://pythonextensionpatterns.readthedocs.io/en/latest/debugging/debug_python.html#debug-version-of-python-memory-alloc-label
Use the following to detect python leaks (instead of valgrind)
https://docs.python.org/3/library/tracemalloc.html
Use https://pypi.org/project/objgraph (with graphviz) to view heap object trees. The following renders the picture as a png under /tmp and prints the path to stdout.
int ret = PyRun_SimpleString("import objgraph; objgraph.show_backrefs(config.global_agent, max_depth=10)\n\n");
PyErr_PrintEx(0);
assert(ret == 0);

== Tools
=== CPyChecker

https://dmalcolm.fedorapeople.org/presentations/PyCon-US-2013/PyCon-US-2013-dmalcolm-StaticAnalysis.html#(38)
https://emptysqua.re/blog/analyzing-python-c-extensions-with-cpychecker/
https://nedbatchelder.com/blog/201502/cpychecker.html

=== Pungi

http://www.cse.psu.edu/~gxt29/papers/refcount.pdf

Another resource is NumPy, https://numpy.org/devdocs/dev/development_advanced_debugging.html


Reproduce builds in a sand-boxed environment similar to the original

As of now, Repairnator attempts at reproducing builds in the TestProject step.
This impedes Repairnator from reproducing builds of projects which are not compatible with the environment in which it is running, or from finding bugs which are out of the scope of the test library of the project (see #1095).
It would be nice to have Repairnator reproducing builds in a sand-boxed environment, using the configuration of the original CI setup.

The environment inference very much depends on the considered CI technology. We'll have to prioritize between them, incl: Travis, Jenkins see #1042, Github actions see #836

Today, @dginelli reported a case where the Maven profiles used in CI ignored test failures by default, which means that any plausible patch was considered correct.

Today, our main scanner is based on Github, and the perfect reproduction would mean reproducing the Github Action environment locally.


Using a file for suggestion source

Hi,
is it possible to use a file as a source to the suggestions? It would be searched each time you type or delete a letter.

It is not possible right now, but you could write your own suggestion strategy function that gives suggestions from a file.


Slow and choppy scroll on iPad

When visiting http://mleibman.github.com/SlickGrid/examples/example-optimizing-dataview.html from an iPad, scroll the list is slow and choppy. Would be cool to get a nice sliding feal on mobile devices the same way as on desktop.

if i am using slick slider in one of my page, then the page loose smooth scroll in ios device. is anyone faced some problem like this?


Paginate CAS2 submissions end point

UI PR is here https://github.com/ministryofjustice/hmpps-community-accommodation-tier-2-ui/pull/498
This adds pagination to /submissions, which lists all submitted CAS2
applications.
We are using the existing utility functions and Page response already
in the API, and utilised by CAS1/3's getAllApprovedPremisesApplications method.

The sorting is hardcoded as ascending "submitted_at" because we do not yet have UI/need
to set the sort order from the frontend.
We're using the default page size for now, but may need to customise that in the near future.
We have set the pageparam to be optional in order not to break the existing frontend - if
no page param is given, then all the results are returned, which means
we will not break the existing UX on the frontend.

@edavey @pezholio thanks both, yep that PageCriteria class looks good, I'll take a look at using it before merging. (and don't think this work is super urgent to get merged based on the rate of applications being submitted)


Can't Uninstall

Where is the option for uninstall in 3.5.1?

I have no idea but if you need to unistall the ntfstool drivers:
sudo rm -rf /Library/Extensions/ntfstool.kext
sudo rm -rf /Library/Filesystems/ntfstool.fs

I had to uninstall the app and the drivers. it caused some read issues on my external NFTS drive and the ntfstool drivers prevent another ntfs tool from working properly.


Client-Configurable Padding Character

As a consumer of this package, I have a need for generating fixedwidth -encoded output that's padded with 0s, so that I can integrate with a system which treats spaces as significant characters.

at first glance, looks to be wired in here currently:
https://github.com/ianlopshire/go-fixedwidth/blob/7cd39dd347dce351d85c0e8bdf930c3927f5b6b9/encode.go#L161
seems like it'd be straightforward, could add a pkg var padChar to be used in the above ref?

was initially looking at something like:
type Encoder struct {
	w              *bufio.Writer
	lineTerminator []byte
	padchar        rune
}

vs the pkg owning the padchar, but ...
https://github.com/ianlopshire/go-fixedwidth/blob/7cd39dd347dce351d85c0e8bdf930c3927f5b6b9/encode.go#L159
does make the encoder owning the padchar more complicated than I thought at first.
Open to any feedback, suggestions.

Have forked, will experiment and circle back if some solutions reached.

@coip, This is definitely a feature I would like the library to support, but I'm unsure just what that support should look like.
I think configurable formatting on the struct field level (see #28) would support this use-case – though it may be a bit verbose.
The struct encoder issue has been discussed in #32. The package owning the encoders allows for some optimizations that I don't want to lose. The ideal solution is not clear at this point.
Feel free to experiment and see where it goes. I look forward to seeing how you solve this.

the tag would be an elegant solution, though your point on the   case raises a good point... 🤔

shouldve provided a rough example to qualify what I meant.
high level, we can do what we need w/ struct granular padchars.
eg, (my crude understanding of our granularity needs at least, for sake of provenance)
encodedfile.txt
header
datatype1[a]
datatype1[b]
datatype1[c]
...
datatype2[a]
datatype2[b]
...
footer

where padchars might need to be encoded ~as

header: { padchar: 0 }

datatypes:

1: { padchar: 1 }
2: { padchar: 2 }

footer: { padchar: @ }

closed by #37


[Event Request] Table 37 - "Sales Line" OnBeforeCheckSalesHeader

Dear Microsoft,
We like to do some prechecking before executing the code form SetSalesHeader. Therefore we like to see the following publisher added in procedure SetSalesHeader.
procedure SetSalesHeader(NewSalesHeader: Record "Sales Header")
begin
    SalesHeader := NewSalesHeader;
    OnBeforeCheckSalesHeader(Rec); //New Publisher
    if SalesHeader."Currency Code" = '' then
        Currency.InitRoundingPrecision
    else begin
        SalesHeader.TestField("Currency Factor");
        Currency.Get(SalesHeader."Currency Code");
        Currency.TestField("Amount Rounding Precision");
    end;
end;

New publisher
[IntegrationEvent(false,false)]
local procedure OnBeforeCheckSalesHeader(SalesHeader : record "Sales Header");
begin
end;

Thanks,

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Update code to support no-reply from email by template

Acceptance Criteria
Please follow the logic below to determine which sender email address to use per notification -

If the email address is populated for the template, then use that.
If the email address is populated for the service, then use that.
Else, use the default no-reply email address.

Checklist

[ ] Update the code to pull the email address from which you will send the email (aka sender email, no-reply email, etc.). This will either be defined at the template level, service level, or fall back to the default. Template level should be the priority if present.

Assumptions

There is already a table called service_email_reply_to which I'm assuming is supported in the code. If it's not please call that out so we can confirm whether we are or are not going to use it in this iteration.

Additional Info/Resources

Out of Scope

Schema and endpoint changes, these have their own tickets.

Open Questions

Cross Functional Checklist
Testing:

[ ] integration tests for API
[ ] Cypress (e2e) for UI

Monitoring:

[ ] statsd metrics
[ ] datadog graphs
[ ] datadog alterts

Security:

[ ] auth permissions and roles
[ ] Move API enpdoints to new user token auth

Marshmallow

[ ] Model serialization / deserialization

Documentation:

[ ] Readmes
[ ] Project specific
[ ] Support
[ ] Openapi
[ ] ADR
[ ] Tech Debt wall

Mountebank

[ ] Mock API enpoints including error scenarios

Accessibility

[ ] E2E & Testrail

Security:

[ ] auth permissions
[ ] JsonSchema

Postman

[ ] Update collection

Hey team! Please add your planning poker estimate with ZenHub @jakehova @ianperera @jessecanderson @kalbfled @k-macmillan


Update project

A few minor project updates related to the Gradle build.

Thx for the pull request.
But I already updated everything!
Greetings
marci4


performance?

hello,
do you have any ballpark performance numbers for training and generation? i've started my own training session so i'll find out eventually, but it would be nice to have a rough idea of how long i should expect things to take!

Hi,
It's quite difficult to give a good answer to that, since the training time depends on a number of factors which will typically vary widely from case to case. For example factors relating to input, such as dataset size (number of audio chunks), sample rate, and also internal factors such as dimensionality of the network, number of layers, etc. And the variation in these is not necessarily linear. Also remember that there is more than a single metric by which to judge the 'speed' of training - the raw duration of each step / batch / epoch (these stats are reported continuously during training, so it's possible to make a crude estimate), but also the rate at which the network converges towards a 'good' set of predictions.
With a dataset of a few thousand files at 16k sr I have rarely trained for less than a day. That's using a single Titan RTX.
Hope that's of some help.

yes that helps me a lot :) thank you!
btw, do you have/know any publicly available pretrained model that i could try out in the meantime?

No problem. Unfortunately I don't know of any public models, we did release one back in June based on a large choral dataset but it's based on deprecated hyperparams so won't won't now. We are planning to release a number of new models in the coming months, however.
We have been getting nice results with LSTM + linear quantization + skip connections, if that's any help.


Undefined array key 0

Hi, I get error Illuminate \ Foundation \ Bootstrap \ HandleExceptions : 1675 handleError on php-8.0.16 and php-8.1.3

What are you trying to do when this occurs and where does it occur (URL)?

Right after Signup I got an error. Url http://localhost:8000/#F51 even I changed the url, the error remains the same

Alright, i seem to have been able to reproduce it...
Running php artisan migrate instead of php artisan migrate:fresh --seed
Caused the error you described.
It has been fixed here: 8195fba66edee36284a7511454e543c368ea4d42

Thanks it's fixed


release: cut a new release of the builders to include fix

https://github.com/slsa-framework/slsa-github-generator/pull/330

Fyi, the v1.1.0 was a pre-release, and its provenance is not verifiable so it's un-usable (the builder binary fetch fails due to provenance verification failure), so we can delete the v1.1.0.
Wdut?

That works!

That should work


Refactor/blast

Updates

Refactor main DNATransformer model class using pytorch lightning callback interface.
More general support for hugging face models via passing json architecture files.
Scalable dataset class.
Performance study for reformer model.
Results from ANL hackathon.
Dockerfile for deepspeed/pytorch.


Can't set base url

I use knickers/mongo-express:latest to get instance of mongo-express up and running. But the problem is that I use nginx in front of it and map route to /mongoexpress/.
I tried to set baseUrl in site.baseUrl of my config.js as said in README, but this didn't help.

Sounds like your nginx reverse proxy config could use a bit of work. Something like?
proxy_redirect                off;
proxy_set_header              Host             $host;
proxy_set_header              Port             $server_port;
proxy_set_header              X-Real-IP        $remote_addr;
proxy_set_header              X-Forwarded-For  $proxy_add_x_forwarded_for;
proxy_set_header              X-NginX-Proxy    true;
proxy_pass_request_headers    on;

More details at https://www.nginx.com/resources/admin-guide/reverse-proxy/


(node:17640) [DEP0155] DeprecationWarning: Use of deprecated trailing slash pattern mapping "./" in the "exports"

field module resolution of the package at<EMAIL_ADDRESS>imported from C:\Users\colli\OneDrive\Desktop\uppr_v1\node_modules. Mapping specifiers ending in "/" is no longer supported. (Use node --trace-deprecation ... to show where the warning was created) - I am  getting this error when running nuxt buid

Duplicated #140


Extract ansible flags for reuse by helm

Description of the change:

Extract flag definitions from pkg/ansible/flags and move them to pkg/flags
Add new package pkg/helm/flags, which reuses pkg/flags

Motivation for the change:

Increase reuse between Ansible and Helm operators

just wanted to bring up why we broke out the two flags into their own structs instead of one.

@shawn-hurley I'm glad you brought this up. I had done that at first, but I couldn't think of a good name to use for the struct. We have more and more common and duplicate code between Ansible and Helm which is begging for a common package.
Any thoughts on a good name for packages that have the shared Ansible/Helm code?

Also, we may want to put this in pkg/internal/flags as I don't know if we want to expose these as usable flags to other users.

Good point. Since we're only using AnsibleOperatorFlags and HelmOperatorFlags externally, it shouldn't be a problem to make the shared flags internal.

Any thoughts on a good name for packages that have the shared Ansible/Helm code?

I would say whatever that code does (i.e. flags), and put it into internal.
I also am hesitant at this point to do this refactoring.


Create stub files for all exercises

We have decided to require all file-based tracks to provide stubs for their exercises.
The lack of stub file generates an unnecessary pain point within Exercism, contributing a significant proportion of support requests, making things more complex for our students, and hindering our ability to automatically run test-suites and provide automated analysis of solutions.
We believe that it’s essential to understand error messages, know how to use an IDE, and create files. However, getting this right as you’re just getting used to a language can be a frustrating distraction, as it can often require a lot of knowledge that tends to seep in over time. At the start, it can be challenging to google for all of these details: what file extension to use, what needs to be included, etc. Getting people up to speed with these things are not Exercism’s focus, and we’ve decided that we are better served by removing this source of confusion, letting people get on with actually solving the exercises.
The original discussion for this is at https://github.com/exercism/discussions/issues/238.
Therefore, we’d like this track to provide a stub file for each exercise.

If this track already provides stub files for all exercises, please close this issue.
If this track already has an open issue for creating stubs, then my apologies. Please close one as a duplicate.
Otherwise, please respond to this issue with useful details about what needs to be done to complete this task in this track so that people who are not familiar with the track may easily contribute.

If this track already provides stub files for all exercises, please close this issue.

will do.

$ ls -1 exercises/*/source/*/*.ceylon | grep -v module | grep -v Test.ceylon | xargs wc -l
   3 exercises/anagram/source/anagram/Anagram.ceylon
   5 exercises/hamming/source/hamming/Hamming.ceylon
  16 exercises/largest-series-product/source/largestseriesproduct/Series.ceylon
   3 exercises/leap/source/leap/Leap.ceylon
   3 exercises/matching-brackets/source/matchingbrackets/Brackets.ceylon
  29 exercises/react/source/react/Reactor.ceylon
   5 exercises/rna-transcription/source/rnatranscription/RNA.ceylon
   3 exercises/sieve/source/sieve/Sieve.ceylon


Regen

Seems better remove transmute in manual code too

It'll come afterwards. This is just to show that the gir PR is working for the moment. ;)


Does this plugin support template variables in Grafana 7.3.x?

It's just a simple question :-)

I don't really know what template variables are, but variables are supported in general. Is there any specific feature missing or problem you are experiencing?

I don't really know what template variables are, but variables are supported in general. Is there any specific feature missing or problem you are experiencing?


SPIKE: Research the possibility of running GO Applications in the Browser via WASM

We are looking if there are ways of utilizing native tools like helm and kubectl directly in the browser, without the need to spin up docker images in the target cluster.
The expected outcome of this spike would be to have a POC showcasing either the output of helm or kubectl being captured and exposed in the UI ( similar to https://radu-matei.com/blog/helm-wasm/ ) or a full VM that will allow user to connect via kubectl to a k8s api.
Links:

https://radu-matei.com/blog/helm-wasm/
https://github.com/m00g3n/go-asyncapi-parser-wasm
https://github.com/copy/v86
https://medium.com/leaningtech/webvm-client-side-x86-virtual-machines-in-the-browser-40a60170b361
https://github.com/plasma-umass/browsix

We close it for now, as the value/maintenance ratio is too low. Changes and learnings captured in https://github.com/kyma-project/busola/pull/903


-m | --mode should list choices

interactive and stdout should be listed.

all params that have choices should show in the --help


Add options to make resolved paths relative to output destination or docroot

Here is some preliminary code for #3 that addresses both approaches I described in the original comment. Consider this a work in progress. I'll get back to it next week, but I welcome your input if you have any thoughts on it.

Could you grant me access to your branch?

You should have write access to the branch. The option to "allow edits from maintainers" is enabled. I'm not sure how that works, but if that's not sufficient, let me know and I'll add you as a contributor on my fork.

Could you please respond to my pull-request review?

I'm sorry, are you still unable to access the branch? I'll add you as a contributor.


Dependabot creating PR too soon after last PR auto-merges, resulting in on out-of-date with base branch

Is there an existing issue for this?

[X] I have searched the existing issues

Package ecosystem
pip
Package manager version
poetry
Language version
python 3.11
Manifest location and content before the Dependabot update
No response
dependabot.yml content
version: 2
updates:
  - package-ecosystem: "github-actions"
    directory: "/"
    reviewers:
      - "scene-connect/dependabot-reviewers"
    schedule:
      day: "monday"
      interval: "weekly"
      time: "08:00"
      timezone: "Europe/London"
    open-pull-requests-limit: 1
  - package-ecosystem: "pip"
    allow:
      - dependency-type: all
    directory: "/"
    reviewers:
      - "scene-connect/dependabot-reviewers"
    schedule:
      interval: "daily"
      time: "08:00"
      timezone: "Europe/London"
    open-pull-requests-limit: 1
    insecure-external-code-execution: allow # apparently pip executes code see https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#insecure-external-code-execution

Updated dependency
No response
What you expected to see, versus what you actually saw
Similar to #4031 and #5234.
We have a github action which marks dependabot PRs to auto-merge, if they pass our CI workflow.
name: Dependabot auto-merge
on:
  workflow_call:
    inputs:
      merge_major_versions:
        default: false
        description: Auto merge on major version changes
        required: false
        type: boolean

permissions:
  pull-requests: write
  contents: write

jobs:
  dependabot-auto-merge:
    runs-on: ubuntu-22.04
    if: ${{ github.actor == 'dependabot[bot]' }}
    env:
      PR_URL: ${{ github.event.pull_request.html_url }}
      GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
    steps:
      - name: Dependabot metadata
        id: metadata
        uses<EMAIL_ADDRESS>        with:
          github-token: "${{ secrets.GITHUB_TOKEN }}"
      - name: Approve PR
        run: gh pr review --approve "$PR_URL"
      - name: Merge PR
        if: ${{ inputs.merge_major_versions || steps.metadata.outputs.update-type != 'version-update:semver-major' }}
        run: gh pr merge --auto --squash "$PR_URL"

When the first dependabot PR of the day successfully auto-merges, dependabot appears to create the second PR almost instantly, and that second PR gets based on HEAD^ missing the commit from the first dependabot PR, which just auto-merged.
That means we have to go around our multiple repos and @ dependabot rebase each of them to get them moving again,
This all pretty much defeats the point of auto-merging our dependabot PRs in the first place, and also doubles up on CI workflow runs. (I've actually just added a job to fail and halt our CI if not up to date with the base branch, just to save us wasting the github actions minutes.
It also means that typically we only get 2 dependabot PRs per repository each day. We might be able to avoid that by changing our schedule.time and reacting quickly, but that also defeats the point of having dependabot do anything for us, we might as well have a daily task for someone to run poetry lock every morning and just test all our updates in one PR...

We deliberately set open-pull-requests-limit: 1 to avoid having to have multiple PRs which we needed to repeatedly rebase and run our CI workflow. (Yes that could possibly also be avoided by not requiring PRs be up to date with the base branch, but we can't disable that requirement just for dependabot nor really do I want to, we do occasionally run into dependency clashes particularly with type-checking).
Native package manager behavior
No response
Images of the diff or a link to the PR, issue, or logs
No response
Smallest manifest that reproduces the issue
I'll see if I can set up a bare public repo with some generic dependencies and make dependabot reproduce this behaviour.

OK I think I've reproduced this fairly simply.
I didn't get out auto-merge workflow working, but it doesn't matter.
When I manually approved the first dependabot PR (devanubis/dependabot-race-condition#1) and merged it (@ dependabot squash and merge) dependabot almost instantly created the next PR devanubis/dependabot-race-condition#2 from the main branch at HEAD^ as if PR 1 had not yet merged.
The timestamps on the commits show that it did happen in the expected order:

The squashed commit from the 1st PR: devanubis/dependabot-race-condition@7c61569 Wed Nov 20 16:36:42 2024 +0000
The commit of the 2nd PR: devanubis/dependabot-race-condition@cd0ae2d Wed Nov 20 16:36:56 2024 +0000

So it's not like the 2nd PR's branch is being pre-created ahead of the 1st PR even merging, and it's not like 14 seconds isn't enough time for that commit to actually hit the github main branch...
So I'm fairly sure now that nothing in our private repo workflows/actions is causing this behaviour and that using dependabot is hitting some sort of race condition with itself when open-pull-requests-limit: 1.


[TC-DA-1.2] - python script is failing at Test Step 2

Summary:
TC_DA_1.2 test case is failing while sending AttestationRequest at test step 2

[MatterTest] 06-16 14:46:17.460 INFO [Test] test_TC_DA_1_2
[MatterTest] 06-16 14:46:17.461 INFO ***** Test Step 0 : Commissioning, already done
[MatterTest] 06-16 14:46:17.461 INFO ***** Test Step 1 : Generate 32-byte nonce
[MatterTest] 06-16 14:46:17.461 INFO ***** Test Step 2 : Send AttestationRequest
[1686906977.462240][150171:150175] CHIP:DIS: Found an existing secure session to [1:0000000012344321]!
[1686906977.462750][150171:150175] CHIP:EM: <<< [E:46118i S:17909 M:242122262] (S) Msg TX to 1:0000000012344321 [8914] --- Type 0001:08 (IM:InvokeCommandRequest)
[1686906977.462776][150171:150175] CHIP:IN: (S) Sending msg 242122262 on secure session with LSID: 17909
[1686906977.684382][150171:150175] CHIP:EM: >>> [E:46118i S:17909 M:172150126 (Ack:242122262)] (S) Msg RX from 1:0000000012344321 [8914] --- Type 0000:10 (SecureChannel:StandaloneAck)
[1686906977.689654][150171:150175] CHIP:EM: >>> [E:46118i S:17909 M:172150127 (Ack:242122262)] (S) Msg RX from 1:0000000012344321 [8914] --- Type 0001:09 (IM:InvokeCommandResponse)
[1686906977.689859][150171:150175] CHIP:DMG: Received Command Response Data, Endpoint=0 Cluster=0x0000_003E Command=0x0000_0001
[1686906977.695370][150171:150175] CHIP:EM: <<< [E:46118i S:17909 M:242122263 (Ack:172150127)] (S) Msg TX to 1:0000000012344321 [8914] --- Type 0000:10 (SecureChannel:StandaloneAck)
[1686906977.695423][150171:150175] CHIP:IN: (S) Sending msg 242122263 on secure session with LSID: 17909
--- Logging error ---
Traceback (most recent call last):
  File "/usr/lib/python3.10/logging/__init__.py", line 1100, in emit
    msg = self.format(record)
  File "/usr/lib/python3.10/logging/__init__.py", line 943, in format
    return fmt.format(record)
  File "/usr/lib/python3.10/logging/__init__.py", line 678, in format
    record.message = record.getMessage()
  File "/usr/lib/python3.10/logging/__init__.py", line 368, in getMessage
    msg = msg % self.args
TypeError: %d format: a real number is required, not str
Call stack:
  File "/home/grl/May30/connectedhomeip/src/python_testing/TC_DA_1_2.py", line 391, in <module>
    default_matter_test_main()
  File "/home/grl/May30/connectedhomeip/src/python_testing/matter_testing_support.py", line 943, in default_matter_test_main
    runner.run()

Reproduction steps:
Setting up the environment :
Step 1 : cloned Connectedhomeip using  mentioned command : git clone  https://github.com/project-chip/connectedhomeip.git
step 2 :  cd connectedhomeip
step 3 : pulled latest commit
step 4:  source scripts/bootstrap.sh
step 5 :  ./scripts/build_python.sh --install_wheel build-env
step 6 :  source scripts/activate.sh
executed the below mentioned command to put DUT into a commissionable state,
./chip-all-clusters-app
Once DUT reach the  commissionable state sent below mentioned command on TH.
 rm -f admin_storage.json && python3 TC_DA_1_2.py --discriminator 3840 --passcode 20202021 --commissioning-method on-network --paa-trust-store-path /paa_roots --storage-path admin_storage.json
system configuration
Chip-tool - Linux
DUT - RPI
Commit-ID : 40fb7c246671e9d37ca8bb2cfbf37f81c1509334
Dut application: all-clusters-app
PFA logs below
TC_DA_1_2.txt
TC_DA_1.2_DUT.txt

This was always working before. There must be something new that got broken from someone else's PR

The many print errors are coming from a bad merge or something on the update to the matter testing support - print step can now take either a string or an int, but it got changed back by accident.
That all is a red herring though - I believe the real error is here:
File "/home/grl/May30/connectedhomeip/src/python_testing/TC_DA_1_2.py", line 256, in test_TC_DA_1_2
asserts.assert_in(vendor_id, range(1, 0xfff0), "Vendor ID is out of range")
File "/home/grl/May30/connectedhomeip/.environment/pigweed-venv/lib/python3.10/site-packages/mobly/asserts.py", line 149, in assert_in
_call_unittest_assertion(_pyunit_proxy.assertIn,
File "/home/grl/May30/connectedhomeip/.environment/pigweed-venv/lib/python3.10/site-packages/mobly/asserts.py", line 52, in _call_unittest_assertion
raise signals.TestFailure(my_msg, extras=extras)

AKA, I think you're using a test vendor ID. You can bypass that check for dev and in the CI by using the PICS_SDK_CI_ONLY PICS, but for real cert the vendor ID needs to be the manufacturer assigned vendor ID, which is not in that range

Above described issue resolved in latest Commit : f5c462133547c290f7eb09e5628ede162fb4a218
But it still failing at Test Step 8.3 : Verify mandatory cd contents
[MatterTest] 06-20 11:53:14.182 INFO ***** Test Step 8 : Verify that the attestation_elements_message structure fields satisfy the following conditions
[MatterTest] 06-20 11:53:14.182 INFO ***** Test Step 8.1 : Verify attestation elements size is < = 900 bytes
[MatterTest] 06-20 11:53:14.182 INFO ***** Test Step 8.2 : Verify certification declaration is present and follows spec format
[MatterTest] 06-20 11:53:14.183 INFO ***** Test Step 8.3 : Verify mandatory cd contents
[MatterTest] 06-20 11:53:14.189 ERROR Exception occurred in test_TC_DA_1_2.
Traceback (most recent call last):
  File "/home/grl/Jun14/connectedhomeip/.environment/pigweed-venv/lib/python3.10/site-packages/mobly/base_test.py", line 777, in exec_one_test
    test_method()
  File "/home/grl/Jun14/connectedhomeip/src/python_testing/matter_testing_support.py", line 933, in async_runner
    return asyncio.run(body(*args, **kwargs))
  File "/usr/lib/python3.10/asyncio/runners.py", line 44, in run
    return loop.run_until_complete(main)
  File "/usr/lib/python3.10/asyncio/base_events.py", line 646, in run_until_complete
    return future.result()
  File "/home/grl/Jun14/connectedhomeip/src/python_testing/TC_DA_1_2.py", line 256, in test_TC_DA_1_2
    asserts.assert_in(vendor_id, range(1, 0xfff0), "Vendor ID is out of range")
  File "/home/grl/Jun14/connectedhomeip/.environment/pigweed-venv/lib/python3.10/site-packages/mobly/asserts.py", line 149, in assert_in
    _call_unittest_assertion(_pyunit_proxy.assertIn,
  File "/home/grl/Jun14/connectedhomeip/.environment/pigweed-venv/lib/python3.10/site-packages/mobly/asserts.py", line 52, in _call_unittest_assertion
    raise signals.TestFailure(my_msg, extras=extras)
mobly.signals.TestFailure: Details=65521 not found in range(1, 65520) Vendor ID is out of range, Extras=None
[MatterTest] 06-20 11:53:14.191 INFO [Test] test_TC_DA_1_2 FAIL
[MatterTest] 06-20 11:53:14.194 INFO Summary for test class TC_DA_1_2: Error 0, Executed 1, Failed 1, Passed 0, Requested 1, Skipped 0
[MatterTest] 06-20 11:53:14.195 INFO Summary for test run MatterTest@06-20-2023_11-53-12-974:

PFA logs below
TC_DA_1_2.txt


Map::layers() doesn't really list ALL layers - added a comment about it

Took me a while to realize when I tried to load one especially large map.
I guess this needs a bit of improvement, but let's start with a comment.

I see an even bigger problem.
While Layer<'a> is supposed to live as long as the Map, getting Layer out of a LayerType::Group(GroupLayer) only gives one a Layer<'a> where 'a is the lifetime of the local copy of GroupLayer.
Which means it cannot be passed outside of a function.
It is probably safe to cast... in an unsafe block.

I see an even bigger problem.
While Layer<'a> is supposed to live as long as the Map, getting Layer out of a LayerType::Group(GroupLayer) only gives one a Layer<'a> where 'a is the lifetime of the local copy of GroupLayer.

This is a bug. I see the problem: get_layer returns Layer<'self> instead of Layer<'map> + 'map. Has happened elsewhere before. Sorry about that, I'll submit a fix ASAP.

Added the changelog.


Rules window should be a guidebook

The wiki has several thousand more words than ingame with precedents that I doubt most people are familiar with.
Having it with sections makes it significantly more likely to get read.

This issue is older, but #19763 is a bit more descriptive, so closing this one


TST: Fix bugs in various tests found via linter

Reference issue

No issue was filed.
What does this implement/fix?
I was looking through the flake bugbear tests to see if any of them have value to the SciPy project. I found some warnings in the tests which look like bugs to me.
Specifically, I was looking at:

B007: Loop control variable {name} not used within loop body
B015: Pointless comparison. Did you mean to assign a value? Otherwise, prepend assert or remove it.
B017: pytest.raises(Exception) should be considered evil

Many of the B007 warnings look like false positives, but some of them look like clear bugs to me. For example, in the test for kendalltau, a comment says that both variants of the kendalltau test should give the same result, and there is a loop over variants, but the variant is not passed to the function, so it just runs the same test twice.
For B015, there are tests which execute a statement like a == b, but do nothing with the result of that comparison. This looks like a bug to me, unless the intent was just to check that the equality check runs without error, and the result of the equality check is unimportant.
For B017, I found one place in the tests where a more specific exception can be expected, which makes the test more specific.
Additional information
I found one other thing that looks suspicious.
This test loops over two values of y: 0, and a random value. However, the variable y is never used. This looks like a bug to me. Either this shouldn't be a loop, or y should be involved in the check somehow. However, I'm unsure what the fix is.
    def test_roots_croots(self):
        # Test the complex root finding algorithm
        np.random.seed(1234)

        for k in range(1, 15):
            c = np.random.rand(k, 1, 130)

            if k == 3:
                # add a case with zero discriminant
                c[:,0,0] = 1, 2, 1

            for y in [0, np.random.random()]:
                w = np.empty(c.shape, dtype=complex)
                _ppoly._croots_poly1(c, w)

                if k == 1:
                    assert_(np.isnan(w).all())
                    continue

                res = 0
                cres = 0
                for i in range(k):
                    res += c[i,None] * w**(k-1-i)
                    cres += abs(c[i,None] * w**(k-1-i))
                with np.errstate(invalid='ignore'):
                    res /= cres
                res = res.ravel()
                res = res[~np.isnan(res)]
                assert_allclose(res, 0, atol=1e-10)

https://github.com/scipy/scipy/blob/main/scipy/interpolate/tests/test_interpolate.py#L1623

re: the other suspicious one, it's possible it might have started with a plan to treat it like test_roots_random, but that was abandoned? @ev-br I see this was a long time ago, but does this need to use y?
https://github.com/scipy/scipy/commit/19b3f3ed3085750812d235f56032b3c4be9de83c#diff-3dc1d145e06c5b57ea93006ccb5028bd6d8bb51d2738c575583858868ab6bb4f

Indeed, good catch! The loop can remove indeed.

@ev-br it looks like y was added as an argument of _croots_poly1 in that PR, but I don't see another test for it in that file. Should the loop be removed, or can we add y into the test somehow?

croots_poly1 is used by _ppoly.real_roots, which is in turn used by PPoly.solve. So in effect croots_poly1 is tested in test_roots_random.
Alternatively, we can keep the test with non-zero y and fix the test:
$ git diff
diff --git a/scipy/interpolate/tests/test_interpolate.py b/scipy/interpolate/tests/test_interpolate.py
index 9cf34c8b90..0ee5f45be9 100644
--- a/scipy/interpolate/tests/test_interpolate.py
+++ b/scipy/interpolate/tests/test_interpolate.py
@@ -1622,13 +1622,13 @@ class TestPPoly:

             for y in [0, np.random.random()]:
                 w = np.empty(c.shape, dtype=complex)
-                _ppoly._croots_poly1(c, w)
+                _ppoly._croots_poly1(c, w, y)

                 if k == 1:
                     assert_(np.isnan(w).all())
                     continue

-                res = 0
+                res = -y
                 cres = 0
                 for i in range(k):
                     res += c[i,None] * w**(k-1-i)

The test IIUC checks that the value of the polynomial is close to zero at what is returned as the root. For non-zero y, croots_poly1 computes the solution to f(x) = y instead of f(x) = 0. Thus need to check that f(x) - y is close to zero.

Thanks! I see. Your choice @nickodell but since the loop is already there, I think I'd roll with it.

Alternatively, we can keep the test with non-zero y and fix the test:

Thanks. I've implemented this suggestion.

CI failures unrelated, gh-20806 and gh-21311. thanks @nickodell !


Import w/ project template

Overview
Allows selecting a project template during organization import
Checklist

[x] Description of PR is in an appropriate section of CHANGELOG.md and grouped with similar changes, if possible

Demo

Notes
A bit going on here to make this feature work.
The general workflow is:

Upload a CSV, it gets validated against the primary state RegionConfig
We also check to see if the user's organizations have project templates that match the CSV. If so we allow to select an organization/template
After a template is selected, we re-upload the CSV to validate it against the RegionConfig for the template, which may be different (a county of the state in question, or one w/ different data or split census blocks).

Testing Instructions

Use scripts/load-dev-data to setup your region_config table (TRUNCATE region_config CASCADE; is a quick way to nuke your current regions first)
The scripts/load-dev-data test organization has two templates configured, one for PA and one for Dane County.

Create a map for each template, and export them each to CSV

Attempt to import each CSV. For the PA template, you should be able to import it w/ the template or using the "No Organization" option. For the Dane County CSV, attempt to import w/o a template will show warnings, which should go away after selecting the template

Closes #971
Closes #1019
Supersedes #1003

I noticed one more quirk on the form: if I upload my PA file and select "House of representatives/18 districts" while "No organization" is selected, the "Create map" button activates. Then if I change to the Azavea organization, the button stays active even though I haven't selected the template. It does successfully create a map if I click it, but it doesn't seem like intended behavior.

Fixed in https://github.com/PublicMapping/districtbuilder/pull/1033/commits/26063ef726b30eec5917d08ca2821dc1b05f2e72


Weird behaviour of an input in a form

Attach (recommended) or Link to PDF file here:
https://github.com/mozilla/pdf.js/files/2321540/issue6127.pdf
When entering 13 chars in the 3rd text field (i.e. NUMERO D’IMMATRICULATION) the first one appears in the first slot and when the input loses the focus everything looks correct.
With focus:

Without:

The issue is reproductible with firefox nightly and locally on master with firefox and chrome (gulp server).

Sir I would like to work on this issue and also it would be my first contribution so if you could guide me through.

Fixed by #13690.


Visualization error

We searched through our own dataset, but we had problems with NAS visualization.
Execute command：
nnictl webui nas --logdir logs/<current_time_stamp> --port
Error: Cannot create a string longer than 0x3fffffe7 characters
How should we solve this error?
Thank you!

Did you actually type “nnictl webui nas --logdir logs/<current_time_stamp> --port”? You should change logdir to a real log folder and port to a real port.

@guoshu6699 Hi, it has been several weeks. Any updates?


Add dashboards for calls made from apiserver

What type of PR is this?
/kind feature

What this PR does / why we need it:
This adds two new dashboards, the number of calls made by apiserver that resulted in response code different from 200 and 99th percentile of latency of those calls. They exclude calls made to itself, with the main purpose to find calls to external apis that might have caused overall latency increase
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/assign @mborsz @jprzychodzen

/lgtm
/approve
/ok-to-test


Getting errors trying to open in browser github with files from submodule or not-master branch

Hey @bgreenlee. First of all thank you for a very helpful plugin. I consider to include it in everyday workflow.
Still there are some things that I aware of: I can't open in browser files that are part of submodules or located inside repo that is not checkout to master. Here you can see screenshots of the errors:

If you're not in a branch or have no upstream configured, and that file exists in master, you can use the version of the command that always uses master:

Sorry for the confusion. I could add a hint to the error message.

Yeah, I see. At the moment I am working with this option, but still going to master every time is not so convenient every time.
I am sure it is possible to implement this feature, but I am not confident with sublime plugins to create a PR. Could you tell what are the problems behind implementing such functional?

So one thing I could do that would be pretty easy is to use master if there's no upstream branch configured. Would that help?
Also, I haven't used submodules, much, but if you're in a submodule, would you want it to open up the code in that submodule's repo? I assume that would be possible.
Here's the chunk of code that figures out what url to open: https://github.com/bgreenlee/sublime-github/blob/7cd0deccfd67abe6d2a9f1ce703ad2843dd2d662/sublime_github.py#L423-L492

Thank you for pointing this. I will see what it is possible to do.


istioctl AWS NLB for ingress gateway

Describe the feature request
Requesting an update on the AWS nlb configuration for istio ingress with istioctl.
Path : https://istio.io/blog/2018/aws-nlb/
Describe alternatives you've considered
I haven't looked at altnertatives. Would the below work ?

Can we patch the istio installation with nlb annotation for ingress gateway ?
I am running this on a CI server and I was advised to use "istoctl manifest apply " than generate the yaml to ensure that the order expected is preserved.
https://github.com/istio/istio/issues/24232#issuecomment-636425365

[ ] Configuration Infrastructure
[X ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Additional context

Installation of istio into an EKS cluster with istioctl binary.
istio version : 1.5.4

https://preliminary.istio.io/latest/docs/setup/install/istioctl/#configure-gateways has an example for a GB ILB. You can do the same for NLB, just replace the annotation

Does aws nlb for istio production ready ?


group-hover prefix stopped working?

See this flems. I thought maybe group-hover had to be enabled, but the docs say it's supported out of the box.

It's supported but not enabled. See docs here:
https://tailwindcss.com/docs/pseudo-class-variants#default-variants-reference

Ah! Got it, thank you. Maybe adding this to the page could help others like me in the future:

The following variants are supported out of the box (but not all are enabled by default):

@gilbert but it already says that, under group hover documentation https://tailwindcss.com/docs/pseudo-class-variants/#group-hover

@estevanmaito I don't see it? The verbiage under that part of the page is the same for every other variant, including built-in ones like hover:.

This is exactly what is written:
You can control whether group-hover variants are enabled for a utility in the variants section of your tailwind.config.js file:
// tailwind.config.js
module.exports = {
  // ...
  variants: {
    textColor: ['responsive', 'hover', 'focus', 'group-hover'],
  },
}

That doesn't help the original issue. It's not any different from a built-in like hover:
You can control whether hover variants are enabled for a utility in the variants section of your tailwind.config.js file:
// tailwind.config.js
module.exports = {
  // ...
  variants: {
    backgroundColor: ['responsive', 'hover', 'focus'],
  },
}


[SPARK-44139][SQL] Discard completely pushed down filters in group-based MERGE operations

What changes were proposed in this pull request?

This PR adds logic to discard completely pushed down filters in group-based MERGE operations.
Why are the changes needed?

These changes are needed to simplify join conditions used in group-based MERGE operations to avoid evaluating unnecessary expressions.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

This PR comes with tests.

@dongjoon-hyun, this should be ready for the first review round.

Thank you, @aokolnychyi !

Merged to master for Apache Spark 3.5.0.

Thank you, @dongjoon-hyun!


Load templates based on language

In our app we have a complex set of templates using UI.Router to create nested states.
For we might have a url like: /introduction/vision-for-health-and-wellbeing
And the following config:
exampleApp.config(function($stateProvider, $urlRouterProvider, $locationProvider) {

	$stateProvider

		.state('maincontent',
		{
			abstract: true,
			url: '',
			views: {
				'all': {
					templateUrl: 'partials/maincontent.html'
				}
			}
		})
			.state('introductionMaster',
			{
				abstract: true,
				parent: 'maincontent',
				url: '/introduction',
				views: {
					'header': {
						templateUrl: 'partials/introduction/_header.html'
					},
					'sidebar': {
						templateUrl: 'partials/introduction/_sidebar.html'
					}
				}
			})
				.state('vision-for-health-and-wellbeing',
				{
					parent: 'introductionMaster',
					url: '/vision-for-health-and-wellbeing',
					views: {
						'content@maincontent': {
							templateUrl: 'partials/introduction/vision-for-health-and-wellbeing.html'
						}
					}
				})

});

How could we translate these templates? As, as you can see we use a template file for each piece of content (because each page is varied in design and copy), so we'd like to avoid masses of placeholders inside each template file and would like to swap out the templates themselves based on language instead. (Though we do use the placeholders approach as well in some places).
So for example, have the templates for German pull out like: templateUrl: 'partials/introduction/de/vision-for-health-and-wellbeing.html'
Would it be a case of passing the language into the url string itself? e.g.
templateProvider: function($stateParams, $translate)
{
	  return 'partials/' + ( $translate.use() ? $translate.use() : $translate.preferredLanguage ) + '/introduction/vision-for-health-and-wellbeing.html';
}

One problem with the above is that it just returns the url as a string and doesn't use the url as the template...
Or is there a more robust and correct way to handle this? Ideally we'd like it to fallback to the default language if the template doesn't exist or the language is invalid, much like it does for the placeholder replacement shown in the documentation. And I'm not sure the above code would handle this.
Also we're not interested in having the language in the URL it would just use the standard Storage to get the language out, but needs to use this to load the correct template (if available).

Sorry for the delay.
I don't think this place is the right one for your question. We mostly discuss the technical aspects of angular-translate which is made for translating strings (as part of a template, service or more generally a component). The module is not made for controlling template content (aka replacing).
However, you can use the $translateProvider as part of the asynchronous resolve within route configurations. But that's more an aspect for your routing configuration.


Predef is not correctly imported

import scala.Predef.String

object C {
  def foo: Map[Int, Int] = Map.empty
}

Due to the changes from this commit, Predef is not correctly imported, resulting in
error: unbound: type Map
  def foo: Map[Int, Int] = Map.empty
           ^
one error found

Actually, this error is possibly replicated by scalac surprisingly, i.e.
error: not found: type Map
  def foo: Map[Int, Int] = Map.empty
           ^

Removing the import relieves the issue


add cmake-build-debug dir to gitignore

Motivation
add cmake-build-debug dir to gitignore. It shouldn't committed to the repo
Documentation

[ ] doc-required
(Your PR needs to update docs and you will update later)

[x] doc-not-needed
(Please explain why)

[ ] doc
(Your PR contains doc changes)

[ ] doc-complete
(Docs have been already added)

@BewareMyPower @RobertIndie I think we can merge this PR