¿Lost Token?

Hello,
The integration has given this error, possibly due to a failure with the token.
I have restarted the integration Settings->Devices and Services and it worked again without problem.

2023-03-03 14:11:23.868 ERROR (MainThread) [custom_components.mypyllant] Error requesting myVAILLANT data: 400, message='Bad Request', url=URL('https://vaillant-prod.okta.com/oauth2/default/v1/token')
2023-03-03 15:11:16.863 ERROR (MainThread) [custom_components.mypyllant] Error requesting myVAILLANT data: 400, message='Bad Request', url=URL('https://vaillant-prod.okta.com/oauth2/default/v1/token')
2023-03-03 15:11:17.580 ERROR (MainThread) [custom_components.mypyllant] Error requesting myVAILLANT data: 400, message='Bad Request', url=URL('https://vaillant-prod.okta.com/oauth2/default/v1/token')

There has been no internet connection.

I had the same error as you around the same time. It hasn't happened since, so maybe sth. was wrong with the API. I'll keep this open, in case it happens again let me know!

Tuve el mismo error que tú casi al mismo tiempo. No ha sucedido desde entonces, así que tal vez algo. estaba mal con la API. Mantendré esto abierto, en caso de que vuelva a suceder, ¡házmelo saber!

Ok

Good morning,
The problem has not repeated, close the issues and if it happens again I will reopen it.
Possibly it is due to the Vaillant cloud, because it fails a lot, last week we spent 3 days without the application, it was a problem recognized by Vaillant.
Possibly it will happen again when the Vaillant endpoint goes down.

This has also been happening to me lately;
  File "/Users/mariomblu/GitHub/myPyllant/tests/generate_test_data.py", line 54, in main
    async with MyPyllantAPI(user, password) as api:
  File "/Users/mariomblu/GitHub/myPyllant/src/myPyllant/api.py", line 83, in __aenter__
    await self.login()
  File "/Users/mariomblu/GitHub/myPyllant/src/myPyllant/api.py", line 104, in login
    raise Exception(login_json["errorSummary"])
Exception: Authentifizierung fehlgeschlagen
Unclosed client session

A couple days ago I was prompted to update myVaillant app to use an improved "new login" system. Maybe they are deprecating the old endpoint

It has happened again.

state = self._stringify_state(available)
2023-03-07 13:24:50.426 ERROR (MainThread) [custom_components.mypyllant] Error requesting myVAILLANT data: 400, message='Bad Request', url=URL('https://vaillant-prod.okta.com/oauth2/default/v1/token')
2023-03-07 13:44:16.508 ERROR (MainThread) [custom_components.mypyllant] Error requesting myVAILLANT data: 400, message='Bad Request', url=URL('https://vaillant-prod.okta.com/oauth2/default/v1/token')
2023-03-07 13:44:17.156 ERROR (MainThread) [custom_components.mypyllant] Error requesting myVAILLANT data: 400, message='Bad Request', url=URL('https://vaillant-prod.okta.com/oauth2/default/v1/token')

I have included this in my config:

logger:
logs:
custom_components.mypyllant: debug
myPyllant: debug

Regarding the last authentication after the update, the same thing happened to me, it seems to me that they use OAuth 2.0, since that login came out of a website using a federated cloud Web App login.
I may be wrong, but it is possible that the download of the new token in the current version is done by OAuth.

After restarting home assistant with the logger on, two errors:

Logger: homeassistant.config_entries
Source: custom_components/mypyllant/init.py:34
Integration: myVAILLANT (documentation, issues)
First occurred: 15:50:31 (1 occurrences)
Last logged: 15:50:31
Error setting up entry<EMAIL_ADDRESS>for mypyllant
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 383, in async_setup
result = await component.async_setup_entry(hass, self)
File "/config/custom_components/mypyllant/init.py", line 34, in async_setup_entry
await api.login()
File "/usr/local/lib/python3.10/site-packages/myPyllant/api.py", line 104, in login
raise Exception(login_json["errorSummary"])
Exception: Authentifizierung fehlgeschlagen

Logger: myPyllant.api
Source: custom_components/mypyllant/init.py:34
Integration: myVAILLANT (documentation, issues)
First occurred: 15:50:31 (1 occurrences)
Last logged: 15:50:31
Could not log in, got status 401 this response: {'errorCode': 'E0000004', 'errorSummary': 'Authentifizierung fehlgeschlagen', 'errorLink': 'E0000004', 'errorId': 'oae-W27IQvsTry1MHxO3FpSkw', 'errorCauses': []}

The German translation of
Authentifizierung fehlgeschlagen -> Authentification failed
And devices:

This new update has a lot of changes in authentication so it seems

Performing the wipe and recreating the device, still fails to authenticate.

Vaillant changed the login workflow completely, see https://github.com/signalkraft/myPyllant/issues/7#issuecomment-1459049586
Latest version should work again!

It does not work for me either. I uninstalled the previous version before installing v0.1.0, and after entering my credentials, nothing happens. There is no information about the component in the logs.

Having the same issue, no error in the log. Thanks.

I tested the setup with a blank HA docker container, it works for me.
When you log into the myVaillant app, do you get a browser window like this, or do you enter username and password in the app?

If you get the browser window, could you share the URL you are getting? In my case it starts with https://identity.vaillant-group.com/auth/realms/vaillant-germany-b2c/protocol/openid-connect/auth.
Maybe there are different realms (groups) in Vaillant's new authentication, in my case it's vaillant-germany-b2c. I would need to know which addresses you are seeing to validate that.

https://identity.vaillant-group.com/auth/realms/vaillant-italy-b2c/protocol/openid-connect/auth?client_id=myvaillant&redirect_uri=enduservaillant.page.link%3A%2F%2Flogin&login_hint=[emailaddress]&response_mode=fragment&response_type=code&scope=offline_access openid&code_challenge=******&code_challenge_method=S256
That’s the link I got.

Muy link
https://identity.vaillant-group.com/auth/realms/vaillant-spain-b2c/protocol/openid-connect/auth?client_id=myvaillant&redirect_uri=enduservaillant.page.link%3A%2F%2Flogin&login_hint=edudele%40gmail.com&response_mode=fragment&response_type=code&scope=offline_access openid&code_challenge=xa-z90X-gNgxl3CKDVtT3NhjF7bGsI2iGmmIzFDwgY0&code_challenge_method=S256

My link, Spain
https://identity.vaillant-group.com/auth/realms/vaillant-spain-b2c/protocol/openid-connect/auth?client_id=myvaillant&redirect_uri=enduservaillant.page.link%3A%2F%2Flogin&login_hint=edudele%40gmail.com&response_mode=fragment&response_type=code&scope=offline_access openid&code_challenge=*****&code_challenge_method=S256

https://identity.vaillant-group.com/auth/realms/vaillant-belgium-b2c/protocol/openid-connect/auth?client_id=myvaillant&redirect_uri=enduservaillant.page.link%3A%2F%2Flogin&login_hint=***EMAIL***&response_mode=fragment&response_type=code&scope=offline_access openid&code_challenge=****&code_challenge_method=S256
Belgium

My link, Spain
https://identity.vaillant-group.com/auth/realms/vaillant-spain-b2c/protocol/openid-connect/auth?client_id=myvaillant&redirect_uri=enduservaillant.page.link%3A%2F%2Flogin&login_hint=***email***%40gmail.com&response_mode=fragment&response_type=code&scope=offline_access openid&code_challenge=*****&code_challenge_method=S256

Tried uninstalling and reinstalling the component, I’m now unable to login.

I added a country selection in version v0.1.1. After updating and restarting home assistant, please click on configure on myVaillant in integrations and select your country. Afterwards reload the integration.
If you weren't able to login when adding the integration, you should see a country selection after username and password.

V0.1.1 login perfectly.
Thank you for your work.
We keep in observation...

Can confirm it works great 🙌🏻 !

Thanks, this fixed the issue for me after uninstall and reinstall.

Perfect, works fine now

Thanks

Thank you. Now the log in works perfectly.
Unfortunately no devices are listed in the integration.
I report some errors:
Logger: custom_components.mypyllant
Source: custom_components/mypyllant/init.py:139
Integration: myVAILLANT (documentation, issues)
First occurred: 8 marzo 2023 alle ore 23:26:08 (4 occurrences)
Last logged: 21:59:45
Unexpected error fetching myVAILLANT data: 1 validation error for Zone current_room_temperature field required (type=value_error.missing)
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 239, in _async_refresh
self.data = await self._async_update_data()
File "/config/custom_components/mypyllant/init.py", line 139, in _async_update_data
data = [
File "/config/custom_components/mypyllant/init.py", line 139, in
data = [
File "/usr/local/lib/python3.10/site-packages/myPyllant/api.py", line 200, in get_systems
system = System(
File "/usr/local/lib/python3.10/site-packages/myPyllant/models.py", line 114, in init
self.zones = [Zone(system_id=self.id, **z) for z in self._raw_zones]
File "/usr/local/lib/python3.10/site-packages/myPyllant/models.py", line 114, in
self.zones = [Zone(system_id=self.id, **z) for z in self._raw_zones]
File "pydantic/main.py", line 342, in pydantic.main.BaseModel.init
pydantic.error_wrappers.ValidationError: 1 validation error for Zone
current_room_temperature
field required (type=value_error.missing)
And the other one:
Logger: homeassistant.components.binary_sensor
Source: custom_components/mypyllant/binary_sensor.py:32
Integration: Sensore binario (documentation, issues)
First occurred: 8 marzo 2023 alle ore 23:26:09 (4 occurrences)
Last logged: 21:59:46
Error while setting up mypyllant platform for binary_sensor
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 293, in _async_setup_platform
await asyncio.shield(task)
File "/config/custom_components/mypyllant/binary_sensor.py", line 32, in async_setup_entry
for index, system in enumerate(coordinator.data):
TypeError: 'NoneType' object is not iterable
Any help?
Thanks

I'm closing this and moving your issue to a new ticket @MP14588


Lower resource instance producing errors

See: https://github.com/OpenDroneMap/WebODM/issues/314
I'm also getting a very similar error, running as ODM node.
Docker images work fine on an amd64 workstation w/ 32 cores & 64Gb ram.
Tuning & testing for lower resource hardware
On packet.net type-0 4 core atom w/ 8Gb ram
docker --limit-mem 7G --> so to leave rm for OS
157 images
settings.yaml - opensfm @ 2
@01:56 of run
2018-01-28 23:52:13,033 Robust matching time : 0.000956058502197s
2018-01-28 23:52:13,033 Full matching 264 / 279, time: 9.20634508133s
2018-01-28 23:52:22,074 2017_0909_115521_230.JPG - 2017_0909_115558_248.JPG has 397 candidate matches
2018-01-28 23:52:22,076 Robust matching time : 0.00139093399048s
2018-01-28 23:52:22,076 Full matching 360 / 397, time: 9.04226994514s
[DEBUG]   running PYTHONPATH=/code/SuperBuild/install/lib/python2.7/dist-packages /code/SuperBuild/src/opensfm/bin/opensfm create_tracks /var/www/data/0f1e05af-76f5-4cf5-984b-e5a1fef84764/opensfm
2018-01-28 23:52:23,363 reading features
2018-01-28 23:52:43,032 Merging features onto tracks
2018-01-28 23:53:14,937 Good tracks: 169240
[DEBUG]   running PYTHONPATH=/code/SuperBuild/install/lib/python2.7/dist-packages /code/SuperBuild/src/opensfm/bin/opensfm reconstruct /var/www/data/0f1e05af-76f5-4cf5-984b-e5a1fef84764/opensfm
2018-01-28 23:54:05,452 Starting incremental reconstruction
2018-01-28 23:55:25,230 Starting reconstruction with 2017_0909_114819_028.JPG and 2017_0909_114823_030.JPG
2018-01-28 23:55:25,231 Common tracks: 5438
/usr/local/lib/python2.7/dist-packages/loky/backend/semaphore_tracker.py:170: UserWarning: semaphore_tracker: There appear to be 1 leaked semaphores to clean up at shutdown
len(cache))
Illegal instruction (core dumped)
Traceback (most recent call last):
File "/code/run.py", line 47, in
plasm.execute(niter=1)
File "/code/scripts/opensfm.py", line 115, in process
(context.pyopencv_path, context.opensfm_path, tree.opensfm))
File "/code/opendm/system.py", line 34, in run
raise Exception("Child returned {}".format(retcode))
Exception: Child returned 132
settings.yaml - opensfm @ 1
@03:36 of run
2018-01-29 06:52:00,566 Robust matching time : 0.00222086906433s
2018-01-29 06:52:00,566 Full matching 113 / 133, time: 8.93961906433s
2018-01-29 06:52:09,607 2017_0909_115521_230.JPG - 2017_0909_115532_236.JPG has 282 candidate matches
2018-01-29 06:52:09,608 Robust matching time : 0.000813007354736s
2018-01-29 06:52:09,609 Full matching 272 / 282, time: 9.04200792313s
2018-01-29 06:52:18,582 2017_0909_115521_230.JPG - 2017_0909_115558_248.JPG has 404 candidate matches
2018-01-29 06:52:18,584 Robust matching time : 0.00192189216614s
2018-01-29 06:52:18,584 Full matching 365 / 404, time: 8.9751970768s
[DEBUG]   running PYTHONPATH=/code/SuperBuild/install/lib/python2.7/dist-packages /code/SuperBuild/src/opensfm/bin/opensfm create_tracks /var/www/data/e3586734-55ee-41b6-adce-a6a9ad815891/opensfm
2018-01-29 06:52:19,683 reading features
2018-01-29 06:52:39,300 Merging features onto tracks
2018-01-29 06:53:11,229 Good tracks: 169237
[DEBUG]   running PYTHONPATH=/code/SuperBuild/install/lib/python2.7/dist-packages /code/SuperBuild/src/opensfm/bin/opensfm reconstruct /var/www/data/e3586734-55ee-41b6-adce-a6a9ad815891/opensfm
2018-01-29 06:54:02,753 Starting incremental reconstruction
2018-01-29 06:55:33,190 Starting reconstruction with 2017_0909_114819_028.JPG and 2017_0909_114823_030.JPG
2018-01-29 06:55:33,191 Common tracks: 5239
Illegal instruction (core dumped)
Traceback (most recent call last):
File "/code/run.py", line 47, in
plasm.execute(niter=1)
File "/code/scripts/opensfm.py", line 115, in process
(context.pyopencv_path, context.opensfm_path, tree.opensfm))
File "/code/opendm/system.py", line 34, in run
raise Exception("Child returned {}".format(retcode))
Exception: Child returned 132

New error:
TypeError: write() argument 1 must be unicode, not str
Is this from not building with core2 flag?
amd64 32 core 64Gb
opensfm_processes @16
w/o core2
no fast_ortho checked
VTK v8.1.0
2018-02-01 21:13:25,053 INFO: 1 partial reconstructions in total.
[DEBUG]   running PYTHONPATH=/code/SuperBuild/install/lib/python2.7/dist-packages /code/SuperBuild/src/opensfm/bin/opensfm mesh /var/www/data/7b2e570d-cc7b-4c88-aa1f-7d2605d50859/opensfm
[DEBUG]   running PYTHONPATH=/code/SuperBuild/install/lib/python2.7/dist-packages /code/SuperBuild/src/opensfm/bin/opensfm export_visualsfm /var/www/data/7b2e570d-cc7b-4c88-aa1f-7d2605d50859/opensfm
Traceback (most recent call last):
File "/code/SuperBuild/src/opensfm/bin/opensfm", line 34, in
command.run(args)
File "/code/SuperBuild/src/opensfm/opensfm/commands/export_visualsfm.py", line 31, in run
self.export(reconstructions[0], graph, data)
File "/code/SuperBuild/src/opensfm/opensfm/commands/export_visualsfm.py", line 49, in export
fout.write('\n'.join(lines))
TypeError: write() argument 1 must be unicode, not str
Traceback (most recent call last):
File "/code/run.py", line 47, in
plasm.execute(niter=1)
File "/code/scripts/opensfm.py", line 139, in process
(context.pyopencv_path, context.opensfm_path, tree.opensfm))
File "/code/opendm/system.py", line 34, in run
raise Exception("Child returned {}".format(retcode))
Exception: Child returned 1

My bad, I've introduced a bug today when adding python3 compatibility. I've just fixed it. Can you please retry with current master? Thanks.

Will rebuild again.  I had added back in core2 thinking it was that.  Core2 actually works fine with amd64 except for caling fast_orthophoto

Will rebuild again.  I had added back in core2 thinking that was it.  Core2 actually works fine with amd64 except when calling fast_orthophoto.  So w/o core2 for amd64?

Cloning into 'opengv'...
[ 10%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_lzma.c.o
[ 10%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_lzw.c.o
Already on 'master'
Your branch is up-to-date with 'origin/master'.
[ 44%] No patch step for 'opengv'
[ 45%] No update step for 'opengv'
[ 45%] Performing configure step for 'opengv'
[ 11%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_next.c.o
-- The CXX compiler identification is GNU 6.3.0
-- Check for working CXX compiler: /usr/bin/c++
[ 11%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_ojpeg.c.o
[ 11%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_open.c.o
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
[ 11%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_packbits.c.o
[ 11%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_pixarlog.c.o
[ 11%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_predict.c.o
-- Detecting CXX compile features - done
-- Found Eigen: /usr/include/eigen3 (Required is at least version "2.91.0")
-- Boost version: 1.62.0
-- Found the following Boost libraries:
--   python
Not using boost/python/numpy.
-- Found PythonLibs: /usr/lib/aarch64-linux-gnu/libpython2.7.so (found version "2.7.13")
-- Found PythonInterp: /usr/bin/python2.7 (found version "2.7.13")
-- Found NumPy: version "1.12.1" /usr/lib/python2.7/dist-packages/numpy/core/include
-- Configuring done
-- Generating done
-- Build files have been written to: /code/SuperBuild/build/opengv
[ 46%] Performing build step for 'opengv'
[ 11%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_print.c.o
[ 12%] Building C object 3rdparty/libtiff/CMakeFiles/libtiff.dir/tif_read.c.o
Scanning dependencies of target opengv
[  1%] Building CXX object CMakeFiles/opengv.dir/src/absolute_pose/modules/main.cpp.o
/code/SuperBuild/src/opengv/src/absolute_pose/modules/main.cpp:1:0: error: unknown value 'core2' for -march

On Jetson TX-2 6 core arm64v8 w/ 8Gb ram
Node-OpenDroneMap based on OpenDroneMap rebuilt for arm64v8 w/ OSMesa & VTK-v8.1.0 source
Based on GCC doc, explicitly set -march=native for VTK build
amd64 version builds and processes images w/o errors
157 images
opensfm @ 1
Time Elapsed: 05:31:07
2018-02-11 09:13:44,284 DEBUG: Undistorting image 2017_0909_115002_078.JPG
2018-02-11 09:13:48,060 DEBUG: Undistorting image 2017_0909_115148_124.JPG
2018-02-11 09:13:51,842 DEBUG: Undistorting image 2017_0909_114819_028.JPG
2018-02-11 09:13:55,615 DEBUG: Undistorting image 2017_0909_115521_230.JPG
[DEBUG]   running PYTHONPATH=/code/SuperBuild/install/lib/python2.7/dist-packages /code/SuperBuild/src/opensfm/bin/opensfm compute_depthmaps /var/www/data/b6f2428d-06ca-4526-ac44-e5e2ec2d4955/opensfm
2018-02-11 09:14:34,366 INFO: Computing neighbors
2018-02-11 09:16:01,914 INFO: Computing depthmap for image 2017_0909_114741_010.JPG with PATCH_MATCH
2018-02-11 09:17:18,349 INFO: Computing depthmap for image 2017_0909_115321_170.JPG with PATCH_MATCH
2018-02-11 09:18:36,423 INFO: Computing depthmap for image 2017_0909_115757_306.JPG with PATCH_MATCH
Segmentation fault (core dumped)
Traceback (most recent call last):
File "/code/run.py", line 47, in
plasm.execute(niter=1)
File "/code/scripts/opensfm.py", line 154, in process
(context.pyopencv_path, context.opensfm_path, tree.opensfm))
File "/code/opendm/system.py", line 34, in run
raise Exception("Child returned {}".format(retcode))
Exception: Child returned 139

I have met the same problem! I used the tx2 and met the following when computing depth map with lund dataset.
2018-05-15 16:12:36,787 INFO: Computing neighbors
2018-05-15 16:12:38,703 INFO: Computing depthmap for image 026.jpg with PATCH_MATCH
2018-05-15 16:12:39,273 INFO: Computing depthmap for image 025.jpg with PATCH_MATCH
2018-05-15 16:12:39,847 INFO: Computing depthmap for image 022.jpg with PATCH_MATCH
2018-05-15 16:12:40,456 INFO: Computing depthmap for image 015.jpg with PATCH_MATCH
Traceback (most recent call last):
  File "/opt/OpenSfM/bin/opensfm", line 34, in <module>
    command.run(args)
  File "/opt/OpenSfM/opensfm/commands/compute_depthmaps.py", line 25, in run
    dense.compute_depthmaps(data, graph, reconstructions[0])
  File "/opt/OpenSfM/opensfm/dense.py", line 36, in compute_depthmaps
    parallel_map(compute_depthmap_catched, arguments, processes)
  File "/opt/OpenSfM/opensfm/context.py", line 38, in parallel_map
    return list(e.map(func, args))
  File "/usr/local/lib/python2.7/dist-packages/loky/process_executor.py", line 719, in _chain_from_iterable_of_lists
    for element in iterable:
  File "/usr/local/lib/python2.7/dist-packages/loky/_base.py", line 584, in result_iterator
    yield future.result()
  File "/usr/local/lib/python2.7/dist-packages/loky/_base.py", line 431, in result
    return self.__get_result()
  File "/usr/local/lib/python2.7/dist-packages/loky/_base.py", line 382, in __get_result
    raise self._exception
loky.process_executor.BrokenProcessPool: A process in the executor was terminated abruptly while the future was running or pending.

@bryanibit I think your issue could more related to running out of memory.  Have you tried to lower the cores used for processing, which in turn lowers the RAM requirements?


Add limit= to get methods, make their signatures more uniform

Adding one missing request parameters, one key at a time...

Ordered keys to be more like rpc.proto, maybe e.g. get_range(self, range_start, range_end, *, ...) in all sigs can be used to avoid such ordering/additions ever breaking code in the future, but guessing it's not an issue atm anyway.

Added docstrings for couple parameters where they were missing, but dunno how these should look for sort_order and such enums, so skipped these here.

get_all() was missing type annotations.

Thanks! I planned to wrap the rpc enums in custom enum types, like one from watch commands.

Please see https://github.com/martyanov/aetcd/blob/master/aetcd/rtypes.py#L257 for example. I personally don't like the string literals here, pretty much easy to abuse.

Can probably be fixed in a follow-up commit or PR.

Added new enums for ordering in the second commit, a couple notes on those:

Made them comparable to case-insensitive strings (via shared _CaseInsensitiveStringEnum class).
Idea is to allow people to type 'key' instead of 'KEY' or aetcd.rtypes.RangeSortTarget.KEY.
Only downside seem to be having that small superclass and maybe visual inconsistency that it allows, but maybe allowing to avoid HARD_TO_READ_AND_TYPE UPPERCASE is worth it.
Feel free to just drop it though - should be as easy as removing that superclass and adjusting tests.

sort_order/target no longer accept None, only proper enum values.
Seems a bit weird to have one special value there, which is then always translated to enum value under the hood, i.e. not actually optional in any way.
In sort_target it's also translated into 'key', which seems a bit counter-intuitive, so maybe better to just ask for proper enum match in all cases?
This is incompatibility, but same as mentioned in other PRs, maybe ok to introduce at this point.
Should be easy to revert by using typing.Optional for types and something like rtypes.RangeSortOrder(sort_order or 'none').name in _build_get_range_request.

Haven't build docs to test how new descriptions look there, but they are very similar to existing ones, so barring any typos, should probably be fine.

Why not just SortOrder and SortTarget as names for the enums?
Not sure if I like the _CaseInsensitiveStringEnum, I prefer to be more strict and explicit. :) Braking the API at the moment is not an issue at all, alpha status of the prject is reflected in its version and project meta.
I'll take a closer look. Thanks!

 If you make the enums importable via aetcd, as all other rtypes types, then it's just a aetcd.SortTarget.KEY. Personally I'm fine with this.

Why not just SortOrder and SortTarget as names for the enums?

They are only relevant for RangeRequest and translated to RangeRequest.SortOrder, so seemed fitting to namespace them like that, similar to how EventKind is not just Kind, but obviously doesn't really matter.

Yeah, I think with strings I was also a bit influenced by how EventKind is halfway str + enum type.
So seemed to be best to either make them all abstract enums not in any way comparable to strings (as that leads to typos which python can't check), or - if they are string - make them human-friendly strings.
Guess if enums are fine, should get rid of all "str" in there and only ever use/allow enums.

Yep, but only the enums should be explicitly imported, as other types return implicitly as operation results, so the only needed may be for type annotations. I think the short enum name are self descriptive enough, readability counts. And we dont have much of them in proto definitions.

Enum-only variant sounds good to me.

EventKind, SortOrder, SortTarget should be all auto-value enums now, with None or str passed to sort_order/target options raising ValueError.

Hello,
We have an exciting opportunity for you! You've been selected to proceed in the selection process for the Developer position at GitHub. Congratulations on your achievement!
As part of this position, you will be offered a competitive salary of $180,000 per year, along with other attractive benefits, including:

Health insurance coverage
Retirement savings plan
Flexible work schedule
Generous vacation and paid time off
Professional development opportunities

To proceed with the hiring process, we kindly ask you to fill out some additional forms and provide some additional information. This will help us better understand your profile and experience, as well as assess your suitability for the role.
Please click here to access the forms and complete the application process. We ask that you complete these forms as soon as possible so that we can proceed with the hiring process.
Important: You have 24 hours to complete the application process.
If you have any questions or need further information, please don't hesitate to contact us.
Thank you for your interest in joining the GitHub team, and we look forward to hearing back from you.
Best regards,
GitHub Recruitment Team
pbnj, @cubeguerrero, @sharad-s, @ORiON-, @tianchuan2017, @melvin0008, @def1bro, @dtcristo, @shafu0x, @073145, @kofwang, @jocelynalsdorf, @ashishlac, @AALVAREZG, @drifter56, @art2code, @andygray, @meepbobeep, @souvikmalikaot, @erlenstar


Slow HMR speed

Hot reload takes about 5-6 seconds after any change in the code. Is there anything that can be done to speed this up? This project contains a lot of features, maybe a cleaner project with fewer features would help? By comparison, a clean cli project takes about 1-2 seconds to reload.

The following tweaks to webpack.config.js: made my HMR much faster in development. See the lines with the "//PD added this" comment
const clientBundleConfig = merge(sharedConfig, {
entry: { 'main-client': './ClientApp/boot.browser.ts' },
output: { path: path.join(__dirname, clientBundleOutputDir) },
plugins: [
new webpack.DllReferencePlugin({
context: __dirname,
manifest: require('./wwwroot/dist/vendor-manifest.json')
})
].concat(isDevBuild ? [
// Plugins that apply in development builds only
new webpack.SourceMapDevToolPlugin({
filename: '[file].map', // Remove this line if you prefer inline source maps
moduleFilenameTemplate: path.relative(clientBundleOutputDir, '[resourcePath]') // Point sourcemap entries to the original file locations on disk
})
] : [
// Plugins that apply in production builds only
new webpack.optimize.UglifyJsPlugin(),
new AotPlugin({
tsConfigPath: './tsconfig.json',
entryModule: path.join(__dirname, 'ClientApp/app/app.module.browser#AppModule'),
exclude: ['./**/*.server.ts']
})
])
,
devtool: isDevBuild ? 'cheap-eval-source-map' : ''  //PD added this
});
const serverBundleConfig = merge(sharedConfig, {
    resolve: { mainFields: ['main'] },
    entry: { 'main-server': './ClientApp/boot.server.ts' },
    plugins: [
        new webpack.DllReferencePlugin({
            context: __dirname,
            manifest: require('./ClientApp/dist/vendor-manifest.json'),
            sourceType: 'commonjs2',
            name: './vendor'
        })
    ].concat(isDevBuild ? [] : [
        new AotPlugin({
            tsConfigPath: './tsconfig.json',
            entryModule: path.join(__dirname, 'ClientApp/app/app.module.server#AppModule'),
            exclude: ['./**/*.browser.ts']
        })
    ]),
    output: {
        libraryTarget: 'commonjs',
        path: path.join(__dirname, './ClientApp/dist')
    },
    target: 'node',
    devtool: isDevBuild ? 'cheap-eval-source-map' :  'inline-source-map' //PD added this
});

That made a huge difference thanks!!!

@peterdobson
The last line:
devtool: isDevBuild ? 'cheap-eval-source-map' :  'inline-source-map' //PD added this

Shoudn't that be:
devtool: isDevBuild ? 'cheap-eval-source-map' : false //PD added this

Since it was like this before:
devtool: isDevBuild ? 'inline-source-map': false

Otherwise we are adding source maps for production build.

yeah thanks @Flood I think you are right

If you need to debug the Typescript that runs on the Server side (i.e., while Server Side Rendering initial HTML). Then 'inline-source-map' is the best as it maps to the exact source line of .ts file & shows that in the dev toolbar....
But if SSR debugging is not required, then devtool can be false ( as cheap-eval-source-map will map some things to the transpiled JS, so not that useful)
@peterdobson Thanks for your pointer on how to improve HMR build speed.

Added this in the #437 upcoming 5.0 release, thank you Peter! I left it as inline as default figuring people would want that TS SSR debugging, but instead I put a note in there.
Overall I'm sure people won't need it, and would prefer faster rebuilds :)
Thanks again! 🍺

Hey, I'm facing slow speeds with angular 7, please help me


Issue 112 nutritionavoidance

Update nutrition avoidance patterns. #112

Sure.  Should I rerun this with imports or is that still an issue?  There are a handful of terms that need this, but overall it is fine.  (I'm okay either way.)

Try with imports! Damion has actually fixed foodon I think!

Yay! worked! close #112


fix completion for sub-command names

shell completion for subcommands with custom names is broken.
here is a test and a fix.
this same tests and fixes are available for the 7.x maintenance branch via #1598

closing in favor of #1598, that will get merged forward

Decided I'll just be releasing 8.0 rather than another 7.x bugfix just for this, so I'll reopen this one. That said, this will be incompatible with #1622, which rewrites the entire completion system. Would you check that this is still an issue on that branch and leave a comment if so?

Hello @davidism

Decided I'll just be releasing 8.0 rather than another 7.x bugfix just for this, so I'll reopen this one. That said, this will be incompatible with #1622, which rewrites the entire completion system.
i see.

Would you check that this is still an issue on that branch and leave a comment if so?
will write tests for MLH-Fellowship:1484-redesign-completion (#1622) and pullrequest fixes if needed.

Hello @davidism
reviewed #1622 and found that it does not address the fixes from this very PR.
so i asked the authors of #1622 to have them included via https://github.com/MLH-Fellowship/click/pull/28

Great, thanks for the help! I'll close this one again.


feat: Support for Odin Inspector

This PR adds support for Odin Inspector to types derived from NetworkManager and NetworkBehaviour. The code will toggle based on the ODIN_INSPECTOR preprocessor define, which is set by Odin Inspector when it is present in the project.
I've tested this by modifying some the examples provided in the Mirror project to use Odin (these testing modifications are not part of the PR), and confirming that SyncVars are still drawn properly like they would be in a "vanilla" Mirror inspector, both in the case of Unity objects and regular values. When Odin is installed, Odin's attributes also work and are fully supported in Mirror types.

why do we need support for Odin inspector?

what happens if someone uses Odin with Mirror, but we don't have support for Odin?

The short answer is none of the custom inspector attributes or features applied to Network Behaviours by devs work...they're basically ignored.
@TorVestergaard might have some before / after screenshots he could share.

https://youtu.be/5TbhbU0HATQ

The video @MrGadget1024 linked shows what customers get out of Odin.
We've been getting a lot of bug reports from our customers that Mirror "breaks" Odin. Usually this isn't so bad, but with Mirror, a lot of user components end up deriving from types of which Mirror controls the drawing, and so they have to choose between one product or the other, which is a major productivity loss either way.
Eventually I took some time to look into matters, to see if we could do anything, and it looks like an integration would be many times more difficult on our end than on Mirror's, since Mirror is the party declaring the custom editors and controlling the overall drawing.
The Mirror-side changes to use Odin if it's present are fairly trivial, as you can see in the PR. If we were to attempt to integrate Odin on our end, we would have to override or automatically modify your editor scripts somehow, or use even stranger hackery, which is really a long-term recipe for disaster. So I do think that if compatibility has to happen, this is roughly the shape it would have to take.
If people experience any editor issues because of the integration, it would be a bug in Odin, which it would of course be our job to fix. The Mirror-side integration code is so simple that if anything breaks, the error would have to be in the Odin library itself, and thus our responsibility.
Whether you guys think it's a good idea and worth it from here, is up to you. I'll remain on hand for questions about the code and tech part of things :)

so Odin is not compatible with any asset that uses custom Unity inspectors?
or is there a particular problem with Mirror, but it works fine with other assets?

When an asset declares a custom editor, Odin detects that, steps aside, and lets it handle that fully, since there is no reliable, generic way to extend that without also risking to break it. We could override said editors entirely, but that would mean whatever custom logic and drawing they have would be lost, so that's not viable either.
This is usually fine - assets should absolutely be allowed to handle the drawing of their own custom types, and users have no need to customize the inspectors of those types regardless. Users only start encountering problems when an asset takes over the drawing of a type which is intended to be inherited from by users to implement large portions of their game, such as Mirror's NetworkBehaviour. You add some fairly simple UI elements to all derived NetworkBehaviours, at the cost of taking control of the drawing of a majority of your user's inspectors, in effect disallowing any further editor customization past that without reimplementing your own UI extensions.
So while many assets are "incompatible" in this way, it's only with foundational assets like Mirror that it really matters.

I see thanks for explanation.
will take a look

I should say that #1309 doesn't address or fix the issues with Odin that this PR does, since the files/editors changed are entirely different.

Why was this closed?

I'm asking the same question as MrG above - this shouldn't have been closed marked as fix until we've confirmed Odin support was indeed functional again.

sorry, I referenced this in another commit and github closed it automatically

@MrGadget1024 I rebased onto the latest master and pushed an extra commit to fix things up - this issue was introduced by #1290 which added OnEnable() to NetworkBehaviourInspector.

will get back to this asap.
we might be able to remove the custom editor for networkidentity instead

I been using odin for months with mirror never had an issue.

I been using odin for months with mirror never had an issue.

can you elaborate on that?

If something needs odin i would just create another script that the Network Behaviour could reference

Mainly use it for Scriptable objects.

so what about your NetworkBehaviours?
I still don't fully understand why you don't have a problem with Odin, but others do.
What am I missing?

pitty its closed, a PR that sorts so many problems just closed...


MB-9411 Switch SFTP Connection to use private key refactor

MB-9411
Summary
This refactor is actually to make it easier to do the ticket that is linked above and referenced in the title of this PR. The ticket itself is for actually swapping over to use a private key connection for GEX sftp.
I wanted to do a small refactor first, so that I only need to update the sftp stuff in one place.
The functionality should stay the same, mostly just parts got swapped in for more optional reuse.
Reuse the cli package to reduce the number of places environment variables are being read, so recycle the usage of the cli package into syncada_sftp_sender and connect_to_gex_via_sftp.
Adjust syncada_sftp_sender_test so that it isn't checking if every single environment variable is available.
Test for the relevant environment variables inside of gex_sftp_test.
Add a Dockerfile to do some local testing.
Unfortunately, the GEX stuff is not able to be tested in exp.
The pull request to actually switch over to key based auth is in #11184.
Verification Steps for the Author
These are to be checked by the author.

[ ] Have the Jira acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.
How to test

Follow the instructions inside of Dockerfile.local_ssh_test
Run make build_tools
Run milmove-tasks connect-to-gex-via-sftp

Backend

[ ] Code follows the guidelines for Logging.
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Messages

:book:
:link: MB-9411

  Generated by :no_entry_sign: dangerJS against f6caef1d15a5a97a030fe2e8ade7de63a0c82208

Test coverage on client failed.
Last run: Fri 28 Jul 2023 01:50:51 AM UTC
Refer to this report to see coverage details for the client app.
Documentation for test coverage can be found at this link.

Test coverage on server failed.
Last run: Fri 28 Jul 2023 01:50:51 AM UTC
Refer to this report to see coverage details for the server app.
Documentation for test coverage can be found at this link.

@YanZ777 This is the part called by the process_edis command that will also need to be converted to use key based auth:
https://github.com/transcom/mymove/blob/f408e7229eced6d70c8b93e52c85ea48478055fe/pkg/cli/gex_sftp.go#L111-L117

@YanZ777 This is the part called by the process_edis command that will also need to be converted to use key based auth:
https://github.com/transcom/mymove/blob/f408e7229eced6d70c8b93e52c85ea48478055fe/cmd/milmove-tasks/process_edis.go#L225
https://github.com/transcom/mymove/blob/f408e7229eced6d70c8b93e52c85ea48478055fe/pkg/cli/gex_sftp.go#L111-L117

Yes, this PR is a refactor. I'm opening another PR that actually swaps it over to key based auth.

Test coverage on server failed.
Last run: Thu 10 Aug 2023 11:42:53 PM UTC
Refer to this report to see coverage details for the server app.
Documentation for test coverage can be found at this link.


Fix white space below TaskListPanel

Credits to stackoverflow

Codecov Report

Merging #183 (43d3988) into master (268be8f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #183   +/-   ##
=========================================
  Coverage     55.08%   55.08%
  Complexity      658      658
=========================================
  Files           115      115
  Lines          2977     2977
  Branches        362      362
=========================================
  Hits           1640     1640
  Misses         1218     1218
  Partials        119      119

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 268be8f...43d3988. Read the comment docs.


Common API - Python Bindings

Create Python Bindings for the Common API so that Python scripts utilizing TensorRT can also be run. The Resnet50 sample would be a good starting point.

API bindings required to enable the resnet50 example  have been implemented, with the exception of parser error checking apis.


adds inline ability for es6 output

Adds a new transformer module called InlineES6ModuleTransformer for in-lining ES6 imports (as parts) with a root module.
usage: traceur --modules=inline --outputLanguage=es6 --out ./out/some-lib.js ./src/root.js
transforms:
 // a.js
 export function a() {
   return 'A';
 }

 // root.js
 import {a} from './a.js';
 export function b() {
   return a();
 }

into:
 const $__module_a_js__ = (function() {
   "use strict";
   function a() {
     return 'A';
   }
   return {get a() {
       return a;
     }};
 })();
 "use strict";
 const {a} = $__module_a_js__;
 export function b() {
   return a();
 }

relates with #1842
blocked from running tests on windows because of https://github.com/google/traceur-compiler/pull/1832

Thanks!
Can this be tested? Maybe using a unit test.

@arv yes once I've figured out how to get the tests to run on windows. dont merge yet.
Is there a way to determine if the module being transformed is the top dominator? because when specifying a single source file in the cli it would be cool if it we could preserve expose it's es6 export keywords.

Is it make that is causing you trouble?
You can also run the tests directly so that you can skip the currently broken tests on windows.

its failing here and without the tval working it cant run any es6 test..

@arv I've added a test but not sure how to actually get the import (test_a.js, test_b.js) contents injected in to the result, any advice?
and also before we merge this would be nice to be able to determine the root dominator file so we can preserve the ES6 export keywords for import to another ES6 library..

@pflannery Just to be clear. Is your use case that you want to compile a Module and its dependencies into a single ES6 Module. Something like:
Input:
// a.js
export function a() {
  return 'A';
}

// root.js
import {a} from './a.js';
export function b() {
  return a();
}

Outputs:
// root-compiled.js
var $tmp = (function() {
  "use strict";
  function a() {
    return 'a';
  }
  return {a};
})();
const {a} = $tmp;
export function b() {
  return a();
}

@arv yes

@arv I've separated this transform in to a separate transformer module called InlineES6ModuleTransformer and updated the tests..
transforms:
 // a.js
 export function a() {
   return 'A';
 }

 // root.js
 import {a} from './a.js';
 export function b() {
   return a();
 }

into:
 const $__module_a_js__ = (function() {
   "use strict";
   function a() {
     return 'A';
   }
   return {get a() {
       return a;
     }};
 })();
 "use strict";
 var a = ($__module_a_js__).a;
 export function b() {
   return a();
 }

@arv PTAL
If good to go then I will rebase to current master and squash ;) thanks

Very nice.
Can you look at the Travis error too?

@arv @johnjbarton I've implemented root module detection using metadata and removed code that references the options object.
There is a case where the metadata is not defined when using the --dir switch, however I'm not sure anyone would ever use '--dir', inline and es6  together but it does work. Because of this I've made sure that the metadata object is defined when evaluating isRootModule.
PTAL

Thanks, the metadata approach looks much better.
I'm ok with this but for your sake I think another PR with a test with the command line (generated-code-dependencies.js) would be a good addition. The test would take two modules, generate output and run the resulting file; the root module would just use a value from its dependency. This exercises all of the elements without being effected by the details of the code gen.  Especially in this case the rootModule which is null in the current test.

@johnjbarton no problem. I can add the tests to this PR.

Glad I did this as I found an issue where I needed to replicate what InlineModuleTransformer does with transformNamedExport
transformNamedExport(tree) {
    return createEmptyStatement();
}

There seems to be a little bug with this as an empty line with ; get generated,  I see this happening with the current InlineModuleTransformer too.
It doesn't break the tests and is valid runnable code. I believe this also relates to #1822

@pflannery You can return an AnonBlock instead. Those gets removed/expanded in transformList.

LGTM
Thanks for taking care of this.

You can return an AnonBlock instead. Those gets removed/expanded in transformList.

@arv I've switched to use
transformNamedExport(tree) {
    return new AnonBlock(null, []);
}

Actually, I still don't understand why you need to add the 'use strict' to the top of your module?

@arv currently with iojs and chrome canary with --harmony-classes enabled I'm seeing this error
SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode

if there isn't a way around this then I could put a TODO to remove this once this condition is lifted?

Lets leave the use strict for now. It does not hurt.
However, it is not clear what the intended output is? Right now ModuleTransformer transforms a Module into a Script and a Script cannot contain an ExportDeclaration (validation is always off for PureES6Transformer). But what we really want to do is to transform a Module into a Module and execute it as a module, which of course is not possible with V8 today.

Merging


Stub Core-Data/AddEvent for CBOR Request

We need to provide a stub return value for the Device Service team to make a call from their work in the SDK to Core and obtain some kind of response. Once they are able to do that and obtain the 501 response, we will proceed to implement the actual CBOR handling in the core services.
When receiving a new event, core-data now needs to first look at the incoming Content-Type header and make a decision. For this initial issue if the value is application/cbor then this endpoint should return an HTTP 501 status code. All other content type values should proceed as handled currently.
Header values can be obtained from the Context object handled with each request. This is how we pass the Correlation-ID header from service to service. The correlation handler will most likely need to be extended to receive a header string parameter instead of defaulting to clients.CorrelationHeader. The internal logic of this method should then use a switch to determine which header is being asked for and return the value from the Context (or an empty string if the value is not found).
Constants should be defined in the go-mod-core-contracts module per this issue for use. Do not use literal strings for things like the Content-type header name or expected value.

@tsconn23, I thought that there would already be content type constants in a standard go package like there is for HTTP status codes, but I am not finding any. Should these constants be put somewhere in go-mod-contracts?

@lenny-intel You might have added your question while I was editing the above issue. Yes, see last paragraph.

closed via #1176


Use try_compile() when retrieving the header paths.

try_compile() of a single source file will use the right compiler and
compiler flags which were not handled by the execute_process() call
before. In particular, this allows to use clang++ as the compiler and
pass CMAKE_CXX_COMPILER_TARGET=x86_64-w64-mingw32 to cmake instead of
relying on the compiler being x86_64-w64-mingw32-g++.

@alxvasilev I think this pull request can be merged

@alxvasilev hi, would it be possible to merge this pull request?

Sure, yes, apologies for the delay.


Adopt token for WMAgent stage-in/stage-out

Impact of the new feature
WMAgent
Is your feature request related to a problem? Please describe.
Similarly to this ticket https://github.com/dmwm/WMCore/issues/11199 , we need to adopt token for the WMAgent payload. In other words, instead of using X509-based stage-in and stage-out auth/authz, we should adopt a token solution for this storage communication.
Describe the solution you'd like
Support token in WMAgent for stage-in / stage-out.
Tokens in the grid jobs will only be available once we configure
a) access to token in the agent node;
b) management of the token in the agent node;
c) propagation of the token by htcondor and WMAgent job description;
d) use of token by the grid job (stage-in / stage-out).
Unless we have all this setup in place, we shouldn't have production jobs accessing tokens during the job runtime.
As a result, that requires at least the following developments:

setup of HTCondor to propagate the relevant token to the job condor shadow
update SimpleCondorPlugin to define token in the job classad
have the bearer token defined in the job environment (to be picked up by CMSSW for stage-in, and read it for stage-out)
then, improve the debugging information with the token-relevant information

Describe alternatives you've considered
If token-based auth/authz fails, do we want to fallback to x509 ?
Additional context
None

@amaltaro I took the liberty to update the description of the issue, according to the discussion in https://github.com/dmwm/WMCore/pull/12081.
@stlammel , feel free to provide additional comments and suggestions here, rather than in the PR linked above, at your convenience.

I think we want to make the stage-out token safe now, i.e. in case a token is in the environment and transfer with token doesn't work, the stage-out doesn't fails. (Right now, if HTCondor makes a token available but token-based transfer doesn't work stage-out may fail.)
Something like:
print date/time
print hostname
print GFAL*, PYTHON*, and LD_* environment
print gfal-copy location
print PFNs
gfal-copy ...
if ( rc == 0 ) done
if ( X509_USER_PROXY is set )
sleep 3 sec
in subprocess {
unsetenv BEARER_TOKEN
unsetenv BEARER_TOKEN_FILE
gfal-copy -v ...
if ( rc == 0 ) done
}
if ( BEARER_TOKEN or BEARER_TOKEN_FILE is set )
sleep 3 sec
in subprocess {
unsetenv X509_USER_PROXY
gfal-copy -v ...
if ( rc == 0 ) done
}
sleep 15 min
print date/time
voms-proxy-info -all
httokendecode
gfal-copy -vvv ...
(token information may change underneath us, so we should print it just before the debug gfal-copy).
'just a thought/suggestion.
Thanks,

Stephan

Issues I have noticed so far:

When jobs are submitted via the condor python bindings, inside the WMAgent container, the job is submitted, but /usr/bin/condor_vault_storer does not seem to be triggered.

I  am currently working that around by:

Executing a condor_submit  with a test job once from the host
Token seems to stay and refresh afterwards.

maybe @stlammel can comment more on what @khurtado reported

We have not used the python binding in the initial tests. If there is a bug, we'll need to make a test case and submit a bug report.

Stephan

I didn't know/realize this Alan. I was only aware of the condor_submit test. Then this is likely a config issue and not bug.
Thanks,

Stephan

@amaltaro Submission through the python bindings work as long as there is a token present already. This can be achieved by creating the token by hand, or having a client that does this for you (like the host condor_submit).
If the tests at FNAL started with a condor_submit first, and a job submission via WMAgent after, then this issue would not have shown up at all.
The python bindings alone don't seem invoke any token generation, but that is probably not a huge deal because the first job usually prompts you to an oauth website for the authentication, and since we submit the jobs automatically via JobSubmitter, we do need to do this interactively beforehand anyway.
I am just noting that as things are now, we need to generate a token at the host, either by hand or with a simple condor_submit test job, in order for WMAgent to submit and use the tokens later on.
This is a step that may need to be included when we start a WMAgent for the first time for example. E.g.: in wmagent-docker-run.sh

I thought about Kenyi's message about condor_vault_storer to being executed on a submit via python API. The initial authorization forwarding requires interactive execution and the device code URL might be lost on stdin in case of python API.
So, it might be called/executed but prompt for user action not getting through/being lost.
Thanks,

Stephan


Stopped Working suddenly

I had the batch file working perfectly for a while but a few days ago it stopped working suddenly. When I run the command/batch, the window disappears with just the message "downloading 0 files".
I had nodeJS v 6.9.2 x64 and thought maybe that would be the issue so first I repaired/reinstalled it, no go, then uninstalled it to install the next stable version available, 6.9.4 x64, and no go. So I'm at a loss now. (Note: if anyone intends on downloading from the tumblr listed in this screenshot for any reason, be warned that there is NSFW stuff!)
I had quotation marks around the tumblr URL and the folder name but I removed them while attempting to troubleshoot. Same result with or without "quotation marks" around the blog URL and the "Tumblr" word at the very end of the command.

I'll check today and I'll let you know what I find.

@Majora-Luna please check your settings and enable "Share posts you like".


Error - typescript node_modules@types

Thank you for reporting an issue or suggesting an enhancement. We appreciate your feedback - to help the team to understand your needs, please complete the below template to ensure we have the necessary details to assist you.
Category

[ ] Bug

Expected or Desired Behavior
Executing samples/react-videolibrary expect to be able to preview carousel video implementation.
Observed Behavior
Tested in two different dev environment and same issue: Error - typescript - node_modules@types\es6-collections\index.d.ts(78,29): error TS2304: Cannot find name 'object'.
Steps to Reproduce
Browse to sp-dev-fx-webparts\samples\react-videolibrary run npm install and then run gulp serve.
Sharing is caring!

The sample uses older version of the SharePoint Framework and this is maybe the cause of the issue. The npm dependencies have to be upgraded to the GA version of the framework. This can be done for exampe by comparing a sample with GA version and attempt to sync the video library to the GA version.

Example and commits of similar migration here https://github.com/SharePoint/sp-dev-fx-webparts/pull/208, as a hint how it can be done.

I hope they update the examples!

Did you contribute your fixes?
@vesajuvonen, I am planning to setup a demo tenant with as many of the examples as possible. This would probably work well as a testing environment. Are you currently doing any automated testing on the samples?

HI @VelinGeorgiev , im new to creating spfx web parts and i have this error as well, how to i upgrade the dependencies to the GA version?

I just saw this issue. I will update the react-videolibrary to the latest {well almost latest} spfx version.

Any updates on this? I am still facing same issue.

I'm going to close this issue as there has been no activity here for a while.
If you're still experiencing this issue, please feel free to open a new issue.


Ethereum v1 review

@hujw77 request more explanation
If someone call IBacking(backing).crossChainSync and withdraw his balance, the helper function will be stuck.
https://github.com/darwinia-network/darwinia-bridge-sol/blob/631101dbe6a96ae5127561cb8ee9dec71da1d220/contracts/issuing-backing/contracts/ethereum/BackingHelper.sol#L108

https://github.com/darwinia-network/darwinia-bridge-sol/blob/631101dbe6a96ae5127561cb8ee9dec71da1d220/contracts/issuing-backing/contracts/ethereum/BackingHelper.sol#L104-L114
For a same blockNumber, This helper function do a batch withraw wETH to ETH.
But I would only call IBacking(backing).crossChainSync and withraw for lower gas.
In this case, this helper function will always revert in the same blockNumber after my call.

@xiaoch05 Please help check wether these review request are fixed, or link related PR.

It becomes complex to help users redeem the ETH native token.
This will cause the complex of wormhole front-end. And I will delete this helper file. Only allow users to use weth instead.

another idea of processing weth=>eth is from anyswap which called router (https://docs.multichain.org/). Also it can be used to swap xUSDT => USDT etc.
This can be used as an alternative for us.
Currently we don't consider the native token specially, and remove this backing helper file.
This has been moved to deprecated by https://github.com/darwinia-network/darwinia-bridge-sol/pull/129.


Line104 should be "ZerosLike" in gradients.cc

This is from issue #41912 .
Line 104 should be
 absl::StrCat("ZerosLike", ToId(handle_)).c_str());

@Dynmi can you please update your branch , we see some conflicts.

@Dynmi can you please update your branch , we see some conflicts.

No problem. But how should I update it?

@Dynmi Just want to check if are you still interested in fixing this?

@Dynmi Just want to check if are you still interested in fixing this?

Well. It seems this problem has been fixed in another PR, which was just a litte earlier than my PR.


Blue print for ember-orbit is not converting files into type script after the addon was added

ember orbit blue print is creating files in the format .js after type script addon was added. But generated controllers, routes, etc are created as .ts files.

It is true it would be nice to have TypeScript versions of blueprints. Another problem you will run into with TypeScript is that store methods can't be properly typed right now.

Yes, my typescript code is showing errors like, "store has no method"...
On Sat 21 Dec, 2019, 6:09 PM Paul Chavard<EMAIL_ADDRESS>wrote:

It is true it would be nice to have TypeScript versions of blueprints.
Another problem you will run into with TypeScript is that store methods
can't be properly typed right now.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/orbitjs/ember-orbit/issues/231?email_source=notifications&email_token=ALUGHG32Q6T7KUPR6HZZXUDQZYFAXA5CNFSM4JJBOXK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHO3MZQ#issuecomment-568178278,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALUGHG2UAXKJOTL7REBWJ2LQZYFAXANCNFSM4JJBOXKQ
.

I believe that the general typing issues have been solved with the Store and Cache. However, we do still need to figure out how to selectively use TS blueprints. It's an annoying paper cut to have to convert these manually.

Relevant Ember RFC that addresses this very issue.


If 524 performance historical view date issue

Task linked: IF-524 Historical View - Custom Date: Wrong data is shown


Fix Android compilation error with RN 0.47

Method createJSModules was removed from RN 0.47. Which leads to compilation error due to @override annotation. This method can be removed right now (https://github.com/facebook/react-native/issues/15232)

Thank you @EugeneBichel


kakoune: support user modes in keyMappings

Description
The option keyMappings.*.mode only supported the builtin modes, but in kakoune you can define custom ones.
The option now accepts a string instead of the enum so one can define key mappings for user modes as well.
User modes are declared automatically.
Checklist

[x] Change is backwards compatible.

[x] Code formatted with ./format.

[x] Code tested through nix-shell --pure tests -A run.all.

~[ ] Test cases updated/added. See example.~

[x] Commit messages are formatted like
{component}: {description}

{long description}

No one raised concerns since I opened this a month ago so I am merging this at my own risk.


[Feature-Request] Optionally do not publish in a "lazy" fashion in the BridgePublisher

Start with the why:
We have had a few issues with the BridgePublisher, that we have pinned down to issues / gaps between  when the publisher has been advertised and when the subscriber has been counted.
To define the term, Lazy publishers are those which only publish when non-zero subscribers have been counted.
In our case, the lazy publisher does not really provide any meaningful advantage.
Move to the what:
In the BridgePublisher, I suggest adding a "non lazy" publisher that the user can opt-in to using.
https://github.com/luxonis/depthai-ros/blob/165bbc9fe84ec6f836e959f630eb6fc023803141/depthai_bridge/include/depthai_bridge/BridgePublisher.hpp#L211
Move to the how:

add an optional bool value to control the laziness on construction, with default True
edit the PublishHelper to take this bool into account when attempting to count subscribers, etc.

Added in https://github.com/luxonis/depthai-ros/pull/381


Safari on iOS 14.5 supports gap

Indicated lack of support for gap in iOS Safari ends on version 14.4 and starts supporting it on Safari iOS version 14.5

Thanks, have added iOS 14.5 properly and with it included support for gap.


launchRequest do not support big number well, which passed in launch.json

my config in launch.json is:
    {
      "type": "scrypt",
      "request": "launch",
      "name": "Debug Demo",
      "program": "${workspaceFolder}/contracts/demo.scrypt",
      "constructorParams": [
<PHONE_NUMBER>11009147713961771110418164117488507161007978051976495741490223813325323875256303997022886706984087636507589369803363244783178649156051633951688639959604528889695,
        30
      ],
      "entryMethod": "add",
      "entryMethodParams": [
        42
      ]
    }

but I got "1.8215277761100915e+170" in a  lsp launch request as below ， which cannot be accurately converted to "182152777611009147713961771110418164117488507161007978051976495741490223813325323875256303997022886706984087636507589369803363244783178649156051633951688639959604528889695"

{
   "command":"launch",
   "arguments":{
      "type":"scrypt",
      "request":"launch",
      "name":"Debug Demo",
      "program":"C:\\\\Users\\\\myland\\\\code\\\\boilerplate/contracts/demo.scrypt",
      "constructorParams":[
         1.8215277761100915e+170,
         30
      ],
      "entryMethod":"add",
      "entryMethodParams":[
         42
      ],
      "__configurationTarget":5,
      "__sessionId":"f00ed20d-4dcc-4de7-a0c3-50c0e40d6e0e"
   },
   "type":"request",
   "seq":2
}

@zhfnjust please file the issue against VS Code itself. You problem seems unrelated to the LSP libraries.


Fixed quote chars for snowflake

Cleaned up usage of quote characters. Added support for "alias_quote_char" for use with Snowflake.

Coverage decreased (-0.05%) to 97.428% when pulling a149631a43288a3ba2c6ecfe5e4ab9a8fd80410e on alias_quote_char into 34248af1155125c4d8f0f7d1205ecb685f2c51d8 on master.


Mention some of the newer features in README.md

Before we forget about them :p

Might worth adding a note about CrashDumps as well?

Oh yeah good thinking, will update with it now.

Nice! Merged. Thanks!


Multi error

report several errors at once

Hello, I am a code review bot on flows.network.
It could take a few minutes for me to analyze this PR. Relax, grab a cup of coffee and check back later. Thanks!


v2.3.0 - fixed linter issues

Addition

Added support for Amharic language

Improvements

If URL (query text) is over 2083 chars, send using POST

Fixes

Fixed Sundanese language
Fixed BAD_NETWORK error on every request
Fixed null responses

Coverage decreased (-2.3%) to 88.571% when pulling 8a288f5bf98582c788029eda6157e03d51fd8639 on snkrsnkampa:master into 52d2f7440321a32c037739d76ff1ebf820538c48 on matheuss:master.

@snkrsnkampa Try adding 'use strict'; and updating test coverage. https://travis-ci.org/matheuss/google-translate-api/builds/234231062

Coverage decreased (-2.3%) to 88.571% when pulling 88d243f5ff053ebbf234b9b09af1402fbeec5e63 on snkrsnkampa:master into 3f17903c15781b458b95a4ef5a13a19372232495 on matheuss:master.

Hi @k3rn31p4nic ,  myself not able to get the output for the hindi language, can you please help me how to add support for hindi language.

@neran27 It already supports Hindi. Are you sure you're doing it right?
Btw, your question is related to this PR, so you should open a new issue for that.
Or you can also try my library (k3rn31p4nic/google-translate-api) if you wish.


ng-options with restangular collections

Hello!
I'm trying to display collection of an elements with ng-options.
Here is my markup:
<select name="terminalId"
  ng-model="vm.order.terminal"
  ng-options="terminal.id as terminal.name for terminal in vm.terminalList">
    <option value="">Not selected</option>
</select>

and that's how I get an elements:
vm.terminalList = Restangular.all('terminals').getList().$object

It's work well with ng-repeat, but with ng-options i've got those "restangulized" methods displayed in my select. Am i doing something wrong or it's just incompatible with ng-options?
I've tried to use this https://github.com/mgonto/restangular#how-can-i-access-the-unrestangularized-element-as-well-as-the-restangularized-one solution but collection is still remains "restangulized".
angular 1.3.9
restangular 1.4.0|1.3.1

You can get the "plain" objects by using the $plain() method. That will strip out the restangular metadata.

Could you provide an example? How can i use it with $object?

I've never used $object - just because I don't like directly binding values to my view.
Maybe:
Restangular.stripRestangular(Restangular.all('items').getList().$object))

Thanks!


Update machine-learning-retrain-models-programmatically.md

Updated the .csv to .ilearner for "output1".

Hi @raymondlaghaeian, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;


Set Default Browser

Is there a way to set the default browser via the Registry? If so, Chrome.

Hey! I was looking through your repo (seeking some inspiration for my own dotfiles one) and, even so this issue is old and probably fixed, here goes a StackOverflow link that should help on this:
https://stackoverflow.com/a/32355457


Fixed formatting for multiline initialization of object and class members

Fixes #17573

@igelbox,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

thanks! Here are some more formatter bugs in case you are interested.

Cool! I think these bugs will be good starting point for me.
By the way, I've already fixed (and filed an issue for) one of them #16044.


Performance regression: ConnectionClose

A performance regression has been detected for the following scenarios:

Scenario
Environment
Date
Old RPS
New RPS
Change
Deviation

ConnectionClose
Linux, http, KestrelSockets
2019-09-13 08:59:10Z
29518
24303
-17.67 %
-19.22 σ

Before versions:
Microsoft.AspNetCore.App 3.0.0-rc2.19459.5
Microsoft.NetCore.App 5.0.0-alpha1.19404.5
After versions:
Microsoft.AspNetCore.App 3.0.0-rc2.19461.7
Microsoft.NetCore.App 5.0.0-alpha1.19404.5
Commits:
Microsoft.AspNetCore.App
https://github.com/aspnet/AspNetCore/compare/e090a0ff33f6aa4721c0678358075515dabe08ab...33120b6093eb5ee9ecf603f56e80a6a7d5a25f07
Logs

Even more CentOS regressions.


z_cstart bug

Describe the bug
file:init.c
FUNC_NORETURN void z_cstart(void)
{
	/* gcov hook needed to get the coverage report.*/
	gcov_static_init();

	LOG_CORE_INIT();

	/* perform any architecture-specific initialization */
	arch_kernel_init();

#if defined(CONFIG_MULTITHREADING)
	/* Note: The z_ready_thread() call in prepare_multithreading() requires
	 * a dummy thread even if CONFIG_ARCH_HAS_CUSTOM_SWAP_TO_MAIN=y
	 */
	struct k_thread dummy_thread;

	z_dummy_thread_init(&dummy_thread);
#endif

	/* perform basic hardware initialization */
	z_sys_init_run_level(_SYS_INIT_LEVEL_PRE_KERNEL_1);-------------------------------------->  where the bug originated
	z_sys_init_run_level(_SYS_INIT_LEVEL_PRE_KERNEL_2);--------------------------------------> where the bug originated

#ifdef CONFIG_STACK_CANARIES
	uintptr_t stack_guard;

	z_early_boot_rand_get((uint8_t *)&stack_guard, sizeof(stack_guard));
	__stack_chk_guard = stack_guard;
	__stack_chk_guard <<= 8;
#endif	/* CONFIG_STACK_CANARIES */

#ifdef CONFIG_MULTITHREADING
	switch_to_main_thread(prepare_multithreading());  --------------------------------------------> where the bug originated
#else
#ifdef ARCH_SWITCH_TO_MAIN_NO_MULTITHREADING
	/* Custom ARCH-specific routine to switch to main()
	 * in the case of no multi-threading.
	 */
	ARCH_SWITCH_TO_MAIN_NO_MULTITHREADING(bg_thread_main,
		NULL, NULL, NULL);
#else
	bg_thread_main(NULL, NULL, NULL);

	/* LCOV_EXCL_START
	 * We've already dumped coverage data at this point.
	 */
	irq_lock();
	while (true) {
	}
	/* LCOV_EXCL_STOP */
#endif
#endif /* CONFIG_MULTITHREADING */

	/*
	 * Compiler can't tell that the above routines won't return and issues
	 * a warning unless we explicitly tell it that control never gets this
	 * far.
	 */

	CODE_UNREACHABLE; /* LCOV_EXCL_LINE */
}

If the interrupt is enabled when the driver is initialized, and the interrupt is entered before the interrupt stack is initialized, the software will generate a bug.
If I understand it correctly, the initialization of the interrupt stack will always occur after the interrupt is enabled .
When the interrupt is enabled, an interrupt is generated immediately, and the interrupt stack is not ready yet, then the bug I said will appear.
interrupt en：
z_sys_init_run_level(_SYS_INIT_LEVEL_PRE_KERNEL_2)

interrupt stack：
_kernel.cpus[i].irq_stack =(Z_KERNEL_STACK_BUFFER(z_interrupt_stacks[i]) +K_KERNEL_STACK_SIZEOF(z_interrupt_stacks[i]))

I found this problem when I debugged my systemtick

any progress on that so far? Maybe my problem is related to that (https://github.com/zephyrproject-rtos/zephyr/issues/32261)

@hongshui3000 : Interrupt is disabled when it enters z_cstart and gets enabled only when it enters main thread through bg_thread_main.
Also, could you give some more information on how this is encountered and which platform its encountered on?

any progress on that so far? Maybe my problem is related to that (#32261)

Looking at the bug it doesn't look to be related. But will look into it further and get back in here.

@yerabolu my issue is happens at the start up of zephyr when the main function is executed and a task switch happens. Its highly probable that it is triggered through an ISR.
Since a (custom) bootloader runs, before zephyr starts, it might happen that an interrupt etc. is activated there(maybe bug).

@hongshui3000 : Interrupt is disabled when it enters z_cstart and gets enabled only when it enters main thread through bg_thread_main.
Also, could you give some more information on how this is encountered and which platform its encountered on?
file : cavs_timer.c

int z_clock_driver_init(const struct device *device)
{
	uint64_t curr = count();

	IRQ_CONNECT(TIMER_IRQ, 0, compare_isr, 0, 0);
	set_compare(curr + CYC_PER_TICK);
	last_count = curr;
	irq_enable(TIMER_IRQ); ---------------------------------------------------------->this
	return 0;
}

and file: uart_mcux.c
static int uart_mcux_init(const struct device *dev)
{
#ifdef CONFIG_UART_INTERRUPT_DRIVEN
	const struct uart_mcux_config *config = dev->config;
#endif
	struct uart_mcux_data *data = dev->data;
	int err;

	err = uart_mcux_configure(dev, &data->uart_cfg);
	if (err != 0) {
		return err;
	}

#ifdef CONFIG_UART_INTERRUPT_DRIVEN
	config->irq_config_func(dev);
#endif

	return 0;
}

#ifdef CONFIG_UART_INTERRUPT_DRIVEN
#define UART_MCUX_CONFIG_FUNC(n)					\
	static void uart_mcux_config_func_##n(const struct device *dev)	\
	{								\
		IRQ_CONNECT(DT_INST_IRQ_BY_NAME(n, status, irq),	\
			    DT_INST_IRQ_BY_NAME(n, status, priority),	\
			    uart_mcux_isr, DEVICE_GET(uart_##n), 0);	\
									\
		irq_enable(DT_INST_IRQ_BY_NAME(n, status, irq));	\---------------------------->this
									\
		IRQ_CONNECT(DT_INST_IRQ_BY_NAME(n, error, irq),		\
			    DT_INST_IRQ_BY_NAME(n, error, priority),	\
			    uart_mcux_isr, DEVICE_GET(uart_##n), 0);	\
									\
		irq_enable(DT_INST_IRQ_BY_NAME(n, error, irq));		\
	}
#define UART_MCUX_IRQ_CFG_FUNC_INIT(n)					\
	.irq_config_func = uart_mcux_config_func_##n
#define UART_MCUX_INIT_CFG(n)						\
	UART_MCUX_DECLARE_CFG(n, UART_MCUX_IRQ_CFG_FUNC_INIT(n))
#else
#define UART_MCUX_CONFIG_FUNC(n)
#define UART_MCUX_IRQ_CFG_FUNC_INIT
#define UART_MCUX_INIT_CFG(n)						\
	UART_MCUX_DECLARE_CFG(n, UART_MCUX_IRQ_CFG_FUNC_INIT)
#endif

If you use them, then the interrupt may be enabled before the interrupt stack is initialized. At least in the xtensa architecture I don’t see interrupts being turned off.If log is turned on, I feel that the interrupt will also be enabled in advance.
I feel that this should involve all the drivers started by _SYS_INIT_LEVEL_PRE_KERNEL_2 and _SYS_INIT_LEVEL_PRE_KERNEL_1 and whether the architecture will be enabled to interrupt. Our system does not make it clear that interrupts cannot be enabled in this place. So I feel that there may be potential problems at present or in the future.

Thank You for the info. Investigating further to see which drivers are started by _SYS_INIT_LEVEL_PRE_KERNEL_2 and _SYS_INIT_LEVEL_PRE_KERNEL_1. Will update on it by EOD.

Ran the below test to see if the irq_lock() and irq_unlock() are setting correctly and ran the tests. All the tests passed. Could you try it on your end as well and see if there is any issue.
	/* Custom ARCH-specific routine to switch to main()
	 * in the case of no multi-threading.
	 */
	ARCH_SWITCH_TO_MAIN_NO_MULTITHREADING(bg_thread_main,
		NULL, NULL, NULL);
#else
	unsigned int key = irq_lock();
	bool_was_locked = arch_irq_unlocked(key);
	arch_irq_unlock(key);
	bg_thread_main(NULL, NULL, NULL);

@yerabolu
Thank you for the information, I will try to debug my program later. But what I want to know is when zephyr rtos is started, "irq_lock" and "irq_unlock" are executed in the above place. Do you suspect that the execution of "irq_lock" in my code failed?

@yerabolu
Thank you for the information, I will try to debug my program later. But what I want to know is when zephyr rtos is started, "irq_lock" and "irq_unlock" are executed in the above place. Do you suspect that the execution of "irq_lock" in my code failed?

@hongshui3000
Looking at the code mentioned above, Interrupt is disabled when the zephyr rtos is started and then gets enabled when it enters main thread. And the above test confirms that.
When you mention "Do you suspect that the execution of "irq_lock" in my code failed?" - which code are you referring here?

I understand what you said. But when I was debugging the xtensa architecture, I did see an interruption. I will continue to check my own code.

@hongshui3000 : Unfortunately i am not able to see this issue on my end and without a way to reproducing it in some way i will not be able to figure out if it is actually causing problems with the timing of enabling interrupts.

I understand what you said. But when I was debugging the xtensa architecture, I did see an interruption. I will continue to check my own code.

Honestly this sounds like a platform bug.  The way this design is supposed to work:

The platform layer enters z_cstart() with interrupts masked[1]
The OS initializes core elements like the _kernel struct, main thread, interrupt stacks, etc...
The OS does its device- and driver-level initialization
The OS then context switches to the main thread (via a z_swap() to init.c:bg_thread_main()), which is the first moment where interrupts become unmasked

(And on the SMP CPUs the process is similar, they start with interrupts masked and only enable them once switching into user/idle threads)
[1] In the sense of arch_irq_lock().  Note that arch_irq_enable(int) is a separate API designed to selectively mask specific interrupts for the purpose of device control.  An interrupt that is "enabled" will still not be delivered if it is globally masked by irq_lock().  On Xtensa, "enabled" corresponds to a bit set in the INTENABLE special register, while irq_lock() works by setting the INTLEVEL field in the bottom bits of PS to XCHAL_EXCM_LEVEL.

I have basically obtained the information I want, thanks for the reply. I think the issue can be closed now


Result indicator don´t update automatically when validation is done

When running a validation via the web interface, the indicator for Success/Error doesn´t update automatically and you have to press Refresh in the Browser to get the correct status.

Fixed in v 0.5.5


Fix log4j initializer warning

Current warning message:
log4j:WARN No appenders could be found for logger (org.apache.http.impl.nio.client.MainClientExec).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info.

Log4j is no longer used in this repo.


issue with baldur's gate 3

Can you share the log for that exception? There should be one in the /logs/errors.txt. My guess is that it's maybe protected but non-achievement user stats are rare and protected user stats are even more rare (I can't think of any off the top of my head).
I don't own Baldur's Gate 3 so I can't check it myself but I verified that stat save is working for me.

Did some more testing and was able to get (hopefully) that error when saving a stat. In my case, I was setting trying to save 99 to 98 and got the Failed to update Integer stat XXXXXX error.
I checked and saw that the stat definition had incrementOnly set to true but that wasn't reflected in the UI (the grid in SAM.Manager). This has been fixed and the changes can be viewed here:
dfed13100a7e23a67a8cec846b596a294a5fe235
If you want to test this you can download the build artifact here (click the SAM link in the Artifacts section).
Note that this will only fix the "Increment Only" column not displaying properly.

Ideally validation should be done upon editing and if any errors are present they should be highlighted and prevent you from saving. So, I created an issue to track adding (actual) validation for incrementOnly.
#17

2024-03-19 01:58:43,580 [1] FATAL App [(null)] - No app ID argument was supplied. Application will now exit...
2024-03-19 01:59:10,849 [1] ERROR SteamGameViewModel [(null)] - An error occurred attempting to save stats. Failed to update Integer stat BG3_Quest09_STAT.
SAM.Core.SAMException: Failed to update Integer stat BG3_Quest09_STAT.
at SAM.Core.ViewModels.SteamGameViewModel.SaveStats() in //src/SAM.Core/ViewModels/SteamGameViewModel.cs:line 153
2024-03-19 01:59:19,658 [1] ERROR SteamGameViewModel [(null)] - An error occurred attempting to save stats. Failed to update Integer stat BG3_Quest09_STAT.
SAM.Core.SAMException: Failed to update Integer stat BG3_Quest09_STAT.
at SAM.Core.ViewModels.SteamGameViewModel.SaveStats() in //src/SAM.Core/ViewModels/SteamGameViewModel.cs:line 153

you are right, it can only increase but not decrease

Yeah, I never noticed it so I must have always incremented when testing that and didn't know it wasn't showing properly. When I tested it earlier I just incremented the first stat value in L4D and then I went to test it again and tried to undo that earlier save and that's when I got the error and noticed that wasn't set properly in the UI.
I'll eventually add nice validation and stuff so to make this more obvious sometime in the future.

In the meantime, if you really want to reset the stat, I'm 90-ish percent sure that you can use the Steam console's reset_all_stats function.
If you've never used the Steam console, the easiest way is to open the Windows Run dialog (Win + R) and then type steam://open/console.

Click "OK" and Steam should open the Console tab.

Here you can type reset_all_stats <appid> and press Enter and you should see reset_all_stats success for appid <appid>. In your case, Baldur's Gate 3's appid is 1086940 so you would enter:
reset_all_stats 1086940

[!NOTE]
You will need to have the app installed in order to be able to reset the stats.

which app do I need to install?

steam console method actually doesn't work either

Is SAM running? Try closing out of it first.

it didn't help, still doesn't work

@jackwaecow i'll buy the game and see what i can do. i think it's just the order of operations that's the issue. basically, if the stats or your save used to generate those stats are still available then the reset won't be permanent.
I just tested this with Left 4 Dead to make sure it works but here's the full order of operations:

Launch Steam
Install game
Turn off auto updates
Turn off Steam cloud sync
Open Steam console

Press Win + R
Type steam://open/console
Click OK

Run reset_all_stats <id>

Where <id> is the app's id

Play game

Get to a point where you can save the game

Exit game
Enable Steam cloud

If you load any of your previous save data then you're likely going to immediately unlock all of your previous achievements along with your stats being restored as well. The key to making it persist is just having your local data, which you have reset, be newer than what's in the cloud so when you re-enable Steam cloud it overwrites the cloud data with your (reset) local data.


Reproducing Table 1

Hi,
Thank you for your work and sharing the code!
I am trying to reproduce the table 1 results with my own code. I used the repo to run the QL retriever and get the output.
My question is how to get the retrieval performance after appending the clarifying question and generated answer to the query.
I find it not so straightforward because the input of QL is a query_id. How to get the query_id after appending context? Or is there anything I am missing?
Thank you!

Thank you! I believe I get it now. Thanks for making that really easy to use.

Hi alexandres,
I find that a coorperative answer generator is mentioned in the paper. However, in the code, these no-answers are not generated, instead they are from the dataset. Can you confirm that is just how it is supposed to work?
Thanks!

Yes, that is correct. See https://github.com/amzn/cosearcher/blob/main/src/answer_generation.py
If you want, you can create your own answer generator as described here https://github.com/amzn/cosearcher#customization
In our work, we just use the similarity argument (which describes the match between question and user facet) in deciding whether to answer yes/no, but if you want to be more flexible in answering questions, the AnswerGenerator.generate_answer abstract method should be changed to accept as input the question that was asked.

Thank you! It is crystal clear now!

Hi alexandres,
I have a question:
I customize a answer generator and a question generator.
The question generator will randomly choose one question from the questions_answers list of the facet, and the answer generator will simply return the facet as the answer.
I only run this for 1 turn and use the metric_calculator to get the query retrieval performance (the ranking metrics) with these additional information.
However, I find that this has the exact same performance as returning "" (nothing) as the answer.
I wonder if this is normal. Can you please share some insights?

Hi @alexandres,
Thank you very much! I did miss the YesNoDetector part.
So, if I understand correctly, the clarifying question and answer will only be appended to the search query if the YesNoDetector returns a "yes", otherwise it always use the query-only mode. Is that right?
I guess I can set the YesNoDetector following your suggestion and that should work as I expect.
Thanks again!

It does give me much higher performance. Thank you!

But I think I can answer your question without looking at your code. If you have a look at our paper, you'll see that there is a component called the "Response Classifier". The heuristic used is very simple (see here). Since your answer generator is simply returning the facet, the Response Classifier considers the answer a "No" and continues to ask questions. Since it never receives an answer it classifies as "Yes", it simply uses the topic as the query to the IR system. This is why you're seeing the same performance as if you simply returned a "" answer.
Consider writing your own Response Classifier by subclassing YesNoDetector and passing it here.
To test your case, always have your YesNoDetector return a "yes", and you should see much higher IR numbers when returning facets as answers, as compared to returning "".

It does improve the performance. Thank you!


[WIP] Cherry-pick(s):

@graceguo-supercat @michellethomas @john-bodley @williaster

failed.

Codecov Report

Merging #81 into airbnb-master will decrease coverage by 0.14%.
The diff coverage is 8.45%.

@@                Coverage Diff                @@
##           airbnb-master      #81      +/-   ##
=================================================
- Coverage          63.38%   63.23%   -0.15%
=================================================
  Files                350      351       +1
  Lines              21978    22037      +59
  Branches            2450     2463      +13
=================================================
+ Hits               13930    13935       +5
- Misses              8036     8090      +54
  Partials              12       12

Impacted Files
Coverage Δ

...perset/assets/src/visualizations/SparklineCell.jsx
0% <0%> (ø)

superset/assets/src/visualizations/time_table.jsx
0% <0%> (ø)
:arrow_up:

superset/assets/src/modules/visUtils.js
58.33% <100%> (ø)
:arrow_up:

...re/components/controls/TimeSeriesColumnControl.jsx
88.46% <71.42%> (-2.65%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42bdef3...512f41a. Read the comment docs.


Revert "endpoint: set RTS/DTR state"

This reverts commit 940f0b8caf3cf61879c3cdfebd66a78eb127bd70.
I think this was probably one artficact of putting the uart in raw mode
rather than sane mode. We don't care about RTS/DTR and none of the
flight stacks we support are setting those.
Fix #128, but needs testing

And at best this should be under the flowcontrol function.

44ff6aa16c26574cfe55941e5cd55975e4562a53
I don't think we should even try to mess with DTR - not even clear it because we risk it not being supported - if we clear it, then we should ignore errors. No board that I know of uses it. I checked ardupilot, PX4, mavros and mavproxy. Nobody uses those.
The best explanation I can give about why I added it is the commits around that change. I should have recorded better commit messages.

This is not compatible with a fake uart (pts) reated by socat. I think we should go ahead and remove it


Support preview Nested Teams API

GitHub Announcement:
https://developer.github.com/changes/2017-08-30-preview-nested-teams/
This involves adding new endpoints and changing existing endpoints according to the blog post.
Successful completion and closing of this issue involves addressing all the changes described in the GitHub announcement.  Note that it doesn't have to all be done in a single PR.  It is always a good idea to carefully document what portions are being addressed in any given PR and if there is still work yet to be done.
Thank you in advance for contributing to this open source project!
Your assistance is greatly appreciated.

I'd like to start working on this.
Currently I'm assigned to #715 but that is quite an insubstantial change.

Awesome, thanks @e-beach!

As Glenn said, this doesn't have to be resolved in a single PR if that would make it large. If so, it'd be better to break it into a few smaller independent changes, as long as that's possible and doing so makes sense.

I will be creating a NewTeam struct  for the params passed to CreateTeam and EditTeam, which now differ from the Team response because of the parent(in response) and parent_team_id(in request) fields. https://developer.github.com/v3/orgs/teams/#parameters
I also noticed that the repo_names parameter to CreateTeam is not supported by go-github currently, so it will also go in that struct.

@e-beach Is there anything left to implement? I'm wondering when this branch can be merged to master, and I'm glad to jump in to help if needed.

@alindeman Thanks for the ping. Yes, #741 finished up support for the API, and this can be merged.
/cc @shurcooL @gmlewis .

OK, merging NestedTeamsPreview branch to master.

Merging got sidetracked - checking on status with @elliott-beach.
Meanwhile, there is a new GitHub API announcement:
https://developer.github.com/changes/2017-10-13-update-the-nested-teams-preview/
This means that around line 34 of orgs_teams.go:
// Default is "secret".

should be changed to:
// Default is "closed".

This documentation change can happen in a separate PR.


Ellipse tool Semi or Full option only applies to interpretation of Axes typed values, labels incorrect

The Ellipse tool has Semi or Full Ellipse Type input values.
If I choose Semi, set an angle of 45 and type a major axis value of 500 Meters and a minor axis value of 250 Meters, I get an output ellipse labeled
"Major Axis: 500 M
Minor Axis 250 M
Orientation Angle 45 Degrees"
If I click elsewhere for a new ellipse, choose Full, set an angle of 45 and type a major axis value of 500 Meters and a minor axis value of 250 Meters, I get an output ellipse labeled exactly the same:
"Major Axis: 500 M
Minor Axis 250 M
Orientation Angle 45 Degrees"
But it is half as long and half as wide.

The input values were interpreted as being the full Major Axis length and the full Minor Axis length.
The labels (at least) should be updated to be
Semi-Major Axis: 500 M
Semi-Minor Axis 250 M
for Semi
and
Major Axis: 500 M
Minor Axis 250 M
for Full.
Testing on ArcMap 10.6, with Distance and Direction 2.1.1

The Semi ellipses are labeled incorrectly. With input of 300 m for Major axis, using Semi option, the length of the ellipse is 600 m.

This is also an issue with the combined add-in, Military Tools 2.0

@BobBooth Was this an issue in 10.3.1-10.5.1?

This problem still exists, ArcMap <IP_ADDRESS>21 Military Tools 2.0

The problem is the labeling for the ellipses created using Semi option. They are labeled with the value used in the input boxes for major and minor axes, but with the Semi option, the ellipse that is actually created has Major and Minor axes that are really 2x as large.
This seems like a minor fix, to make the label process aware of whether the Semi or Full option was used.
@kgonzago  @csmoore

Addressed in PR #513 - ready to QA/QC after merge. Labels look like now with same values and semi/full ellipse type applied

removing QC - Verify Checklist - there was already a section in the checklist test for ArcMap that the tester draw an ellipse using "semi" and ensures the measurement and labels are correct and then does the same thing for "full".

Verified this issue no longer exists with ArcMap <IP_ADDRESS>21 and Distance and Direction add-in <IP_ADDRESS> or with ArcMap <IP_ADDRESS>21 and Military Tools 3.0 build 23 (5Mar)


Midnight Commander - mouse wheel is not working

Subj. I think this is after Windows 14371 update & mb new console updates.
Far Manager also MWheel is not working, but in legacy concole all fine. Can't check MC in legacy cause Bash need new console.
And may be exists any reg key to fix this asap?

Pretty sure bash.exe does not support mouse input yet, even in 14371.  I checked the changelogs.
I wrote up a kinda slick workaround using rxvt-unicode-256color in my answer to this:
https://github.com/Microsoft/BashOnWindows/issues/531

Also Shift key does not work for me in mc (f.ex. Shift+F4)...

I believe this should be in insiders by now, @SerjCh can you confirm?

@zadjii-msft I know that you guys at the console team don't have your own little release notes page, but maybe for now you could ask Russ to post your release notes up with the WSL ones? I ask because this happened one other time, when the WSL team posted up that there were no changes one week, and then Rich posted up the 24-bit color info, which was technically true that there was no upgrade to WSL but a huge upgrade to the console.

@zadjii-msft i'm on win 8.1 and Ubuntu now, sorry =) have no insider build atm

As of 14965 this is working beautifully!

Fantastic, I'll close this then.
@fpqc to be honest, there haven't been a whole lot of feature updates recently that would need any release notes posted, mostly bugfixes and work going on behind the scenes. The only reason this feature didn't have a post is due to us losing track of which release it actually came out in


[HOLD for payment 2024-10-30] Add RBR reason to LHN debugging

As discussed here, let's add the reason a given report is showing an RBR in the LHN to the reports debug information. Similar to what we do for GBRs.
cc @pac-guerreiro
Issue OwnerCurrent Issue Owner: @puneetlath

Hi! I’m Pedro Guerreiro from Callstack - expert contributor group. I’d like to work on this task!

Hey, yesterday I opened a draft PR for this so you can see my progress while I work on this issue 😄
Here is what remains to be done:

[ ] Add RBR reason test cases in DebugUtilsTest.ts
[ ] Add screenshots
[ ] Add QA testing steps

Today's update:

[x] Add RBR reason test cases in DebugUtilsTest.ts

Todo:

[ ] Fix unit test for when there are transaction thread violations
[ ] Add screenshots
[ ] Add QA testing steps

Thanks for these updates!

The PR is now ready for review! 😄
Go ahead @DylanDylann

I just applied the suggested changes by @puneetlath and @DylanDylann.
The PR is ready for a new review 😄

The PR was finally merged 🙌

The regression test is covered here

@DylanDylann I'm going to have each of the debug mode PRs be a milestone on one Upwork job. Just to make things easier for me to pay.
The offer for is here: https://www.upwork.com/nx/wm/offer/new/1039087488. I've added 3 PRs as milestones so far. I'll add the others as milestones as we go.
Please ping me here when you've accepted.

@puneetlath Accepted 🙏

Paid this one. Thanks y'all!


Stack affixed items

I'd like to specify two ion-affix items, the first is a menu bar for operations, the second is a grouped list of ng-repeat items. Is this possible?

This project is not maintained anymore. We cancelled our free-time hobby project with Ionic because of too much changed recently in our personal lives and we don't have enough time at all.
I would be happy to reference anyone who would fork the project and maintain it.


pickers.lua throws an error for telescope installation when the option is disabled

Telescope installation is optional (and experimental), but causes the adapter to fail if it's not installed.
Could it be possible to throw error only if the option is enabled?
https://github.com/thenbe/neotest-playwright/blob/f61463f5c74d53fc5975b7e086b7c6e9356d9215/src/pickers.lua#L3-L5
→
if not has_telescope then
  if options.experimental.telescope.enabled then error('nvim-telescope/telescope.nvim is not installed') end
  return
end

Now, it should only show an error if experimental.telescope.enabled = true.


Car unrecognized Toyota Highlander 2019

Describe the bug
After installing comma two and connecting the display says Dashcam mode Car unrecognized
How to reproduce or log data

Expected behavior
This model is in the list of supported, so I ordered from online shop comma.ai
Device/Version information (please complete the following information):

Device: comma two
Dongle ID: 922bcfdc7c1e117d
Route: 922bcfdc7c1e117d |2020-12-19
Timestamp: [19 December
Version: 0.8
Car make/model: Toyota Highlander 2019 safety sense  US manufacturing for  Russian market
Engine is down forced to 249hp, unlike US version

Additional context

Fingerprinted added in d6caca943308ff96c96f6750cb7763f577240925. If you switch to master or master-ci, your car should now be recognized.

Fingerprinted added in d6caca9. If you switch to master or master-ci, your car should now be recognized.

Thanks for fast fix.
How do I switch to master? I have v 0.8.0 automatically installed from setup process.