fix: Normalise *.sh File Endings

SUMMARY
Windows users encounter problems running the docker-compose commands
to run an instance of Superset.
The reason for this is line-endings for the *.sh files that are
mounted and used in the command sections for the superset images.
Many Windows users will check the repository out with line endings set
to CRLF. When mounted in to the *nix-based containers, these line
endings are not understood, leading to errors such as:
/usr/bin/env: bash\r: No such file or directory

The addition of a .gitattributes file resolves this issue by telling
git to always resolve these files with LF line endings.
fixes #10132
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

I wasn't sure if a *.sh text eol=lf would be accepted as it's a broader brush change, hence why I have opted for a more targetted docker/**/*.sh text eol=lf.

/testenv up

/testenv up


Making Grav stateless

In reference to this post by @rhukster in https://github.com/getgrav/grav/issues/1767#issuecomment-426647637 — (I'm relaying this message from our backend devs, so bear with me with any inaccuracies in terms etc!)
For whatever reason (probably not Grav related), sometimes PHP, Nginx, or AWS instances can just randomly break or die, which is the main reason why we've been trying to setup two identical nodes running behind a load balancer. So, if one of the instances fails, the system automatically switches to the working node.
However, at the moment Grav doesn't support stateless server instances, that is, cache file naming (mostly images) will vary between otherwise identical server nodes. This could be solved by using session persistence, which ensures files will only be loaded from one of the nodes for the length of that session, but this is somewhat archaic and also breaks some things, like CDN's whole site acceleration we'd like to use. The trend, apparently, has been to keep the session state outside the server for years now.
So, in short, while we've been moving mountains to create a system where everything is robust, fault-tolerant, and auto healing, but unfortunately, there's still a single node that acts as a gateway between this robust system and the world that doesn't yet support this in a satisfactory way.
Do you think this could be solved using some method of file naming that's not dependent on outside circumstances (server the instance is running on)? Possibly using hashes of the file itself, and maybe incorporating necessary file parameters. In our (developers') view, this would allow Grav to scale better — and make it a truly flat file, stateless platform, removed from "the application server territory" (Wordpress…)
Thanks for any thoughts on this!

Thanks for the info @jlehtinen i'm going to discuss this with @mahagr to see what we can do to improve this.

@jlehtinen I need some clarifications on how your system is set up. So you have two servers behind a load balancer, where both of them have an identical installation of Grav, but are independent -- meaning that they have both local copies of the files?
In Grav, images are dynamically created on request, which means that the image only exists in a single node or you need to use CDN to serve the images (or have a way to get a copy of the file from the proper server after it has been generated). I think the easiest way to fix this is to create a reverse proxy setup to load the missing images from the other server.

Thank you @rhukster and @mahagr for looking into this, really appreciate it. I'll forward the question to our devs and let you know!

Jään odottelemaan vastaustasi! (I'll be waiting for the response)

Mahtavaa! Awesome! 😃

Has there been any progress on this front? Evaluating this product for a client but not being able to load balance it across many server nodes is a non-starter..
Perhaps this issue could be renamed to Load balancing support or product scale out.


Azure.Core 2.0: Update HttpMessage, ResponseClassifier, and RequestOptions

Description
Many of the basic Azure.Core types now have analogous types in the System.ClientModel library.  In order to follow the DRY engineering principle, we plan to update Azure.Core to reuse functionality from these types, using either inheritance or adapters in most cases.
This PR makes the following changes:

Azure.Core HttpMessage inherits from System.ClientModel PipelineMessage
Azure.Core ResponseClassifier inherits from System.ClientModel PipelineMessageClassifier
Azure.Core RequestContext inherits from System.ClientModel RequestOptions

Design Motivation

HttpMessage must inherit from PipelineMessage so users can write a single pipeline policy that will work in both Azure.Core and System.ClientModel pipelines.
ResponseClassifier must inherit from PipelineMessageClassifier so the logic to classify a response as an error can live in one place in the transport.
RequestContext should inherit from

Context
This PR is a smaller chunk of https://github.com/Azure/azure-sdk-for-net/pull/41773 to make it easier to review.  In addition, it this PR targets the feature/azure.core-2.0 feature branch because we cannot move the Azure.Core 2.0 integration into main until after System.ClientModel 1.1.0 is GA.

API change check
API changes are not detected in this pull request.


Outbound mail for to different Mail server with postal but Authentication Error:550 exist

I want to send mails beween to mail  servers by the help of postal mail server . In this connect the postal and any other mail server. postal is send the mail to the other mail server as an client . HERE is the scenario:

mail client send the mail  to the recipient in between the sender and receiver two mail server is exist .
a) postal mail server
b) any other mail server
postal accept mail from the sender and send it to the second mail server, now the postal mail server is  worked as an client of the second mail server.
3.second mail server is accept or receive the mail from the postal mail server, and send to the real receiver.
receiver accept the mail and read it the information.
This is my  work scenario.

Error:
but in between the two mail server the postal mail  server always send the Error , "550 Authentication required" , the postal mail server hold the my mail every time and suspense the mail id .
Here is any solution  for this that i can connect the any  mail server  to each  other and send the mail to the any receiver without any connection down and Authentication.

Please include a description of your problem and how you are trying to use Postal.

I'm using the postal in my own network with default configuration.
when i'm send the mail by single postal mail server then the mail delivered to the receiver properly .
means
my mail  ----> postal mail server --> receiver  (delivered properly).
This is an default behavior.but my working is,
my mail --> postal mail server --> other mail server --> receiver (delivered properly).
BUT in both mail server 550: Authentication Error Exist , and postal says for "Hard Fail " and suspense my mail ip.

I'm using the other mail server as an smtp_relay of the postal mail server.
smtp_relays:
hostname: vps.highfashion.biz
port: 25
username: vps
password: jhgt6&((^%GGFRYEuje55

from_address<EMAIL_ADDRESS>ssl_mode: Auto

Is it any way that postal not using the authentication between the mail servers.

Have a look at https://github.com/atech/postal/issues/48

[authentication on SMTP relays] isn't supported. You should configure your relay to allow connections from the IP of your Postal server.

#48 says that  i also configure the relay in the other mail server, if i understand write , but how to configure the relaying in postal

Is it any smtp forward feature available for the postal


Grid search

*Issue #265
*Description of changes: Adding GridSearcher and baseline for it (Unit test haven't included)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This does not contain support for the HPs other than Categorical yet - either me or Jack will have a follow up PR to support rest of hp types.

Right now the order of configs to be enumerate is as follow:

Default (shuffle_config = True), the order is random
if shuffle_config = False, the hyperparameter specified first in the config space will be explore first.
For example:

config_space = {'hp1': [1,2,3], 'hp2': [4,5], 'hp3': [6,7]}
order: (1, 4, 6), (2, 4, 6), (3, 4, 6), (1, 5, 6), (2, 5, 6), (3, 5, 6), (1, 4, 7), (2, 4, 7), (3, 4, 7), (1, 5, 7), (2, 5, 7), (3, 5, 7)

Left one minor comment, but overall LGTM. We would need for someone from core maintainers to review.


Re-Key private folder failing

I lost a harddrive, and re-installed my OS. At the same time, I installed keybase on the new install.
I followed the prompts, and was able to open private folders shared to me with other people. As everything seemed to be working, I then revoked my old device and paperkey. I then generated a new key.
At that point I attempted to open my private folder and saw this:

I then decided to use the paper key to start the re-keying process ($ keybase rekey paper). When entering it in, everything looks like it's working, but that popup still appears, and my private folder still seems empty.
$ keybase rekey status
No TLFs need rekeying.
$ keybase version
Client:  1.0.18-20170209165653+17b641d
Service: 1.0.18-20170209165653+17b641d

my log id: aca6504859fbfd05ba6c361c

cc: @songgao  can you take a look at this one?

I am already looking.  @miketweaver it looks like you created that paper key (nation anxiety) today, after revoking your other paper keys?  This folder was never keyed for your current paper key.  Does that sound right?  Why did you revoke your old paper key (specifically swim scene)?

@strib That sounds exactly right.
The revocation of the old paper key swim scene was because of a mis-understanding of the paperkey system. I've since reviewed the documentation and have a better understanding of paperkeys. I still have record of the old paper key.

Thanks.  Do you have data in that folder you need to recover, or is it ok to reset the folder completely?
@maxtaco @patrickxb: is there any way to restore a wrongly-revoked paper key, or input it using keybase rekey?

no, we'd have to build that

@strib Well, I have the data encrypted elsewhere, though it would take me a few days to get access to it. I'd rather not have to go get it, but it is recoverable. I understand the mistake was on my part for incorrectly revoking that key and am completely fine with resetting the folder, if needed.

It looks like there's no way to recover that data, without us building something new into our software, which would take significantly longer than a few days I think.
We definitely need to get better about warning you on the CLI when you're about to revoke a key that will cause you to lose access to your private data.  I know we've talked about it, not sure what the status is.  Sorry we let you get into this mess.
Resetting seems like the best option to me, unless you're willing to dive into the code and somehow trick your local client into accepting the revoked paper key.  If you want me to proceed with the reset, please run this command on an currently-valid keybase device, and substitute the current date and time where indicated:
keybase sign -m "<DATE_AND_TIME>: Please reset folder /keybase/private/bashninja because all the devices that have access have been revoked."

and post the results here.

BEGIN KEYBASE SALTPACK SIGNED MESSAGE. kXR7VktZdyH7rvq v5wcIkHbsF0EYND zNhOJyZlGqcWH22 xDErfIHwsiYd4UA KDAyNh40HKu7B58 7iOFpoUZwSIPGOr gLNdeNXKpvPD9G9 GMcuAN1XSBlJEN7 n6XwofIcOx1A8tg nLCBVlOx1eTC8Ku cjAfb1FH2dhB5HQ opcnbcFcZSxRAPg WUkhbFUkEwVAUkc LLDFNRRUwJcT8sE mQspO7f5LThCulN 7tpmOVAMX9a27TL ZhHGSVH7FfEGN0o 6qoP0WFLYdzNjiY xLJyVz1HqvF1x9i rJBDZDAMtfpNABQ eNo2Lvhn5JaNDLB wX7MWE0Po1DGxzH i6aSrK3SAItsrFO 3EjYklxxyMFwKUv MRoT0y2zuGbg9R6 RYD9ueNHQSaviAg vWHOeUb8DRpx25y oZRrlnsZCgLnyoG yWcfLmmY9p4ffd0 PNF6HztBDfkN9hW 0e. END KEYBASE SALTPACK SIGNED MESSAGE.

Ok, it should be reset now.  Please check it out and close this if everything seems ok.


Added  svg images for the buttons, cloud and progress dots bar.

Added svg images for the buttons, cloud and progress bar needed for… travelMethod page.
Folders the changes will take place :
1.public/Images/clouds
2.public/Images/transportmode-icons
3.pulic/Images/progress-bar

trello card for this task : https://trello.com/c/z50v3GrA/297-dev-travel-method-selection-page

The svg images looks good to me @Amutha37 :+1:
Happy to merge this PR if no further changes are needed

Yes you can .👍
On Tue, 8 Mar 2022 at 7:50 pm, hqtan @.***> wrote:

The svg images looks good to me @Amutha37 https://github.com/Amutha37 👍
Happy to merge this PR if no further changes are needed
—
Reply to this email directly, view it on GitHub
https://github.com/CodeforAustralia/council-emissions-calculator/pull/67#issuecomment-1061543159,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKV7DNDXVTNQOJ5OGLATNY3U64IEFANCNFSM5QE5DQDA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***
com>


net: Remove check for k_delayed_work_cancel

k_delayed_work_cancel now only fail if it hasn't been submitted which
means it is not in use anyway so it safe to reset its data regardless
of its return.
Signed-off-by: Luiz Augusto von Dentz<EMAIL_ADDRESS>

Will also conflict with https://github.com/zephyrproject-rtos/zephyr/pull/1130/commits/71f7a0f23fc19dcc43507be598f1acf1c771b502 .
Otherwise, this seems ok in the light of the recent change, but I have the same concern as with this comment: https://github.com/zephyrproject-rtos/zephyr/pull/1130#discussion_r133385619 . It's not related to this change per se, as the same issue existed before. I'm just not sure if this may increase race condition exposure window. For example, commit message says "k_delayed_work_cancel now only fail if it hasn't been submitted". What happens if delayed work started to execute, got preempted, and then k_delayed_work_cancel() got called? Is this not possible?

The handler is called only after the K_WORK_STATE_PENDING is cleared:
            /* Reset pending state so it can be resubmitted by handler */
	if (atomic_test_and_clear_bit(work->flags,
				      K_WORK_STATE_PENDING)) {
		handler(work);
	}

So nothing will happen if k_delayed_work_cancel is called after this.

@jukkar Ive updated the patch fixing the other instances that you mentioned.


Bug: debug bar in development mode conflicts with HTMX

PHP Version
8.2
CodeIgniter4 Version
4.3.3
CodeIgniter4 Installation Method
Composer (using codeigniter4/appstarter)
Which operating systems have you tested for this bug?
Linux
Which server did you use?
apache
Database
mysql  Ver 15.1 Distrib 10.11.2-MariaDB, for Win64 (AMD64)
What happened?
I have shared the details on the forum
https://forum.codeigniter.com/showthread.php?tid=87812
the code is really basic since at this level is a proof of concept
model
    public function AjaxSearch($query)
    {
        if($query != '')
        {
            $this->like('email', $query);
            $this->orLike('name', $query);
            $this->orLike('subject', $query);
            $this->orLike('custom', $query);
            $this->orLike('note', $query);
            $this->orderBy('lastactivity', 'DESC');

            return $this->findAll(5);
        }
        return;
    }

view
<?= $this->section('content') ?>

  Search Contacts

         Searching...

<input class="form-control" type="search"
       name="search" placeholder="Begin Typing To Search Users..."
       hx-post="<?= site_url('admin/trova') ?>"
       hx-trigger="keyup changed delay:500ms, search"
       hx-target="#search-results"
       hx-indicator=".htmx-indicator">

<?= $this->endSection() ?>

controller
    public function index()
    {
        $output="";

        helper('form');

        // Checks whether the form is submitted.
        if (! $this->request->is('POST')) {
            // The form is not submitted, so returns the form.
            return view("admin/ticket/trova");
        }

        $post = $this->request->getPost(['search']);

        // Checks whether the submitted data passed the validation rules.
        if (! $this->validateData($post, [
            'search' => 'required|max_length[10]|min_length[3]',
        ])) {
            // The validation fails, so nothing to do.
            echo "CIAO";
        }

        $this->ticketModel = new \App\Models\TicketObjModel();

        $data = $this->ticketModel->AjaxSearch($post['search']);

        $output .= '

                Ticket
                Oggetto
                Nome
                Email
                Stato Lav

';

        if(count($data) > 0)
        {
            foreach($data as $ticket)
                {
                $output .= '

                        id.'">'.'visualizza
                        '.$ticket->subject.'
                        '.$ticket->name.'
                        '.$ticket->email.'
                        '.$ticket->dept_id.'

';
                }
        }
        else
        {
         $output .= '

             No Data Found

';
        }
        echo $output;
    }

Steps to Reproduce
see the code and see the forum
https://forum.codeigniter.com/showthread.php?tid=87812
Expected Output
I have shared the details on the forum
https://forum.codeigniter.com/showthread.php?tid=87812
Anything else?
I have shared the details on the forum
https://forum.codeigniter.com/showthread.php?tid=87812

Do you use https://github.com/michalsn/codeigniter-htmx ?

Hello
no , as I have done for Bootstrap , I have just included the htmx minified js in the header of the main default template page
what is the difference?
Thank you

what is the difference?

If you don't use it, you have the issue like this.
If you use HTMX with CI4, I recommend you install it.
Read https://michalsn.github.io/codeigniter-htmx/

Sharp!
I knew aboutand used the codeigniter-htmx, thoug I supposed it was a facilitation for an automatic implementation, and I have succesfully run the demo.
Probably it is better to think about add some warning on both the sites

Codeigniter user guide
Codeigniter-HTMX page ( I'll send an email to Michal )

in fact neither on the Codeigniter-HTMX page it is given the idea that using this "extension" is a must, otherwise pseudo-bugs like this may happen
Thank you

The issue has nothing to do with CodeIgniter since HTMX is a third-party library. Please don't expect CodeIgniter to be fully compatible out of the box with every library out there.
CodeIgniter-HTMX is not required to use HTMX. Although it helps - debug bar is one of these scenarios. Even though it's not rendered it works. Just search for the debugbar-link response header.


Velocity blowup in channel model?

I'm trying to code a simple 2D channel model in v0.17.0 where the periodic dimension is the flat dimension. I keep experiencing seemingly spontaneous velocity blowup during spin-up despite changing parameters/removing most forcing. Here is an example:
Nx = 1
Ny = 256
Nz = 32
Lx = 1000e3
Ly = 1000e3
Lz = 4e3
N² = 1e-5
Δp = 1e-5 #will set to be a function of y
end_time = 1day

# ## Define a forcing function
pressure_gradient(x, y, z, t) = Δp / Lx
pressure_gradient_forcing = SimpleForcing(pressure_gradient)

## Instantiate the model
model = ChannelModel(
                   grid = RegularCartesianGrid(size = (Nx, Ny, Nz), x = (0, Lx), y = (-Ly/2, Ly/2), z=(-Lz, 0)),
                closure = ConstantIsotropicDiffusivity(ν=100, κ=100),
               coriolis = FPlane(f=1e-5),
                tracers = (:b,),
               buoyancy = BuoyancyTracer(),
                forcing = ModelForcing(v=pressure_gradient_forcing)
)

## Set initial condition.
b₀(x, y, z) = N² * z
set!(model, b=b₀)

## A wizard for managing the simulation time-step.
wizard = TimeStepWizard(cfl=0.2, Δt=1.0, max_change=1.1, max_Δt=90.0)

Thanks for reporting this @masonrogers14!
In this case the pressure_gradient(x, y, z, t) = Δp / Lx forcing function may keep unrealistically accelerating u forever but I think the blowup is not related to that as we tried other forcing functions too. And decreasing the magnitude of Δp did not slow the blow up down.
I'm somewhat concerned that this issue may be related to PRs #572 and #573 so we should definitely investigate.

Whats the stability condition associated with diffusivity for this problem?

I get
julia> Δz = 4e3 / 32
125.0

julia> ν = 100
100

julia> Δt = Δz^2 / ν
156.25

So your time-step has to be substantially smaller than 156 s to be stable. 90 s may be pushing it... does reducing the maximum time-step size stabilize the problem?

Yes we tried reducing the time step to a constant Δt=1 and Δt=1e-2 and it still blows up in the same number of iterations, suggesting to me that it wasn't a time-stepping issue.
It blows up in ~20 iterations so Δt is still pretty small.

@glwagner suggested that recomputing w from continuity could be an issue here. We should try time-stepping w explicitly and running the example again.

Reducing time steps for the example I shared solved the problem but fails for a more authentic example. Here is a better example, where I (very loosely) have a 2D y-z model with x-wind forcing in the southern hemisphere:
Nx = 1
Ny = 256
Nz = 32
Lx = 1000e3
Ly = 1000e3
Lz = 4e3
N² = 1e-5
end_time = 1day

## Wind stress BC
wind_stress(x,y,t) = -1e-5*sin(2π*y/Ly) * (y<0)
wind_stress_bf = BoundaryFunction{:z, Cell, Cell}(wind_stress)
velocity_bcs = ChannelBCs(top=BoundaryCondition(Flux, wind_stress_bf))

## Instantiate the model
model = ChannelModel(
                   grid = RegularCartesianGrid(size = (Nx, Ny, Nz), x = (0, Lx), y = (-Ly/2, Ly/2), z=(-Lz, 0)),
                closure = ConstantIsotropicDiffusivity(ν=100, κ=100),
               coriolis = BetaPlane(rotation_rate=1/day, latitude=0, radius=6400e3), #2π/day?
                tracers = (:b,),
               buoyancy = BuoyancyTracer(),
    boundary_conditions = BoundaryConditions(u=velocity_bcs)
)

## Set initial condition.
b₀(x, y, z) = N² * z
set!(model, b=b₀)

## A wizard for managing the simulation time-step.
wizard = TimeStepWizard(cfl=0.2, Δt=1.0, max_change=1.1, max_Δt=.001)

@glwagner -- explicitly timestepping w unfortunately did not solve the problem, but I'll keep looking into it

Don't know if this is the problem, but the wind stress BoundaryFunction should be specified at Face, Cell; eg change the line with wind_stress_bf to
wind_stress_bf = BoundaryFunction{:z, Face, Cell}(wind_stress)

This is because the u velocity component is located at (Face, Cell, Cell) in (x, y, z) on the staggered grid.

Note there are also a few changes to the script that would need to be made if the intention is to run on the GPU.

Thanks @glwagner, I fixed the BoundaryFunction specification but am still getting blowup at iteration 23. I don't currently intend to run on a GPU but will keep that in mind

I think I might be narrowing down the issue to implementation of boundary conditions. Perhaps I'm misunderstanding how ChannelModel works? The following code works for at least 10 days:
Nx = 1
Ny = 256
Nz = 32
Lx = 1000e3
Ly = 1000e3
Lz = 4e3
N² = 1e-5
end_time = 10day

# ## Creating boundary conditions
wind_stress(x,y,t) = -1e-5*sin(2π*y/Ly) * (y<0)
wind_stress_bf = BoundaryFunction{:z, Face, Cell}(wind_stress)
velocity_bcs = HorizontallyPeriodicBCs(top=BoundaryCondition(Flux,wind_stress_bf))
buoyancy_bcs = HorizontallyPeriodicBCs(bottom=BoundaryCondition(Gradient, N²))

## Instantiate the model
model = Model(
                   grid = RegularCartesianGrid(size = (Nx, Ny, Nz), x = (0, Lx), y = (-Ly/2, Ly/2), z=(-Lz, 0)),
                closure = ConstantIsotropicDiffusivity(ν=100, κ=100),
               coriolis = FPlane(f=1e-5),
                tracers = (:b,),
               buoyancy = BuoyancyTracer(),
    boundary_conditions = BoundaryConditions(b=buoyancy_bcs, u=velocity_bcs)
)

## Set initial condition.
b₀(x, y, z) = N² * z
set!(model, b=b₀)

## A wizard for managing the simulation time-step.
wizard = TimeStepWizard(cfl=0.2, Δt=1.0, max_change=1.1, max_Δt=20)

It fails after 10 iterations or so with .001s time steps when the Model is replaced with a ChannelModel and the HorizontallyPeriodicBCs are replaced with ChannelBCs.

 Makes sense that it blows up very quickly no matter what.
Changing to
 boundary_conditions = ChannelSolutionBCs(b=buoyancy_bcs, u=velocity_bcs)

fixed it for me and now your example time steps fine on my laptop.

This is the box model modified to use the correct ChannelSolutionBCs that I'm able to time step:
using Printf

using Oceananigans
using Oceananigans.Diagnostics

using Oceananigans: Cell, Face

Nx = 1
Ny = 256
Nz = 32
Lx = 1000e3
Ly = 1000e3
Lz = 4e3
N² = 1e-5
end_time = 10day

# ## Creating boundary conditions
wind_stress(x,y,t) = -1e-5*sin(2π*y/Ly) * (y<0)
wind_stress_bf = BoundaryFunction{:z, Face, Cell}(wind_stress)
velocity_bcs = ChannelBCs(top=BoundaryCondition(Flux,wind_stress_bf))
buoyancy_bcs = ChannelBCs(bottom=BoundaryCondition(Gradient, N²))

## Instantiate the model
model = Model(
                   grid = RegularCartesianGrid(size = (Nx, Ny, Nz), x = (0, Lx), y = (-Ly/2, Ly/2), z=(-Lz, 0)),
                closure = ConstantIsotropicDiffusivity(ν=100, κ=100),
               coriolis = FPlane(f=1e-5),
                tracers = (:b,),
               buoyancy = BuoyancyTracer(),
    boundary_conditions = ChannelSolutionBCs(b=buoyancy_bcs, u=velocity_bcs)
)

## Set initial condition.
b₀(x, y, z) = N² * z
set!(model, b=b₀)

## A wizard for managing the simulation time-step.
wizard = TimeStepWizard(cfl=0.2, Δt=1.0, max_change=1.1, max_Δt=20.0)

cfl = AdvectiveCFL(wizard)
dcfl = DiffusiveCFL(wizard)

while model.clock.time < end_time
    update_Δt!(wizard, model)

    time_step!(model; Δt=wizard.Δt, Nt=10)

    u, v, w = model.velocities
    u_max = maximum(abs, interior(u))
    v_max = maximum(abs, interior(v))
    w_max = maximum(abs, interior(w))

    t = model.clock.time
    @printf("Time: %s, Δt: %.2e CFL: %.2e, dCFL: %.2e, max (u, v, w): (%.2e, %.2e, %.2e)\n",
            prettytime(model.clock.time), wizard.Δt, cfl(model), dcfl(model), u_max, v_max, w_max)
end

@masonrogers14 Just expanding on a note by @glwagner on max_Δt: as diffusion is time stepped explicitly in Oceananigans, the maximum time step is limited by the stability criterion for the heat equation
Δt < Δz^2 / κ

In practice you'll want Δt to be significantly below that limit, probably by a factor of 5x or 10x (to be safe).

@ali-ramadhan Thanks so much! I'm inclined to say the problem is resolved and will do more tests to make sure. Also the stability condition makes sense; I wasn't sure what the time stepper handled and what one has to address explicitly in the model

Awesome! I'll close this issue then.

Also the stability condition makes sense; I wasn't sure what the time stepper handled and what one has to address explicitly in the model

The TimeStepWizard will make sure your CFL number (advective stability criterion) is below e.g. 0.2 but won't do anything about the diffusive CFL, although we could modify it to take into account both advective and diffusive stability criteria.


GET items in document library does not include .docx or .xlsx

Hello, I am new to using the SharePoint API but I am having difficulty getting a list of items in our document library. When I GET _api/Web/Lists(guid'my_guid')/items it only returns the .doc files in the library, the .docx and .xlsx files are not included. I can GET /files, but I need the metadata about each file which I understand is the use for /items. It seems like this is a bug. Thank you.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e5a8f160-c2fd-8692-1c3f-2c5c44c7a286
Version Independent ID: 2d7064f8-409c-4465-3fbb-bd6a4c2806f5
Content: Working with lists and list items with REST
Content Source: docs/sp-add-ins/working-with-lists-and-list-items-with-rest.md
Product: sharepoint
GitHub Login: @VesaJuvonen
Microsoft Alias: vesaj

I can get data about .docx items if I do GET https://{site_url}/_api/web/lists/GetByTitle('Test')/items({item_id})

The .docx and .xlsx items show up if I name each ID individually as a filter like the following. Considering we have 400 documents I don't think this is the preferred way to do it.
https://rapidmachiningsolutionscom.sharepoint.com/sites/RapidMachiningSolutionsLLC/_api/Web/Lists/getbytitle('RMS QUALITY MANAGEMENT SYSTEM')/items?$filter=(Id eq 0 or Id eq 1 or Id eq 2 or Id eq 3 or Id eq 4 or Id eq 5 or Id eq 6 or Id eq 7 or Id eq 8 or Id eq 9 or Id eq 10 or Id eq 11 or Id eq 12 or Id eq 13 or Id eq 14 or Id eq 15 or Id eq 16 or Id eq 17 or Id eq 18 or Id eq 19)


Create diagram for the architecture of the managing + managed system

First draft:

Not really implementation related. I am closing this issue.


search in files triggers runaway rg.exe

VSCode Version: Code 1.18.0 (dcee2202709a4f223185514b9275aa4229841aa7, 2017-11-08T21:22:49.932Z)
OS Version: Windows_NT x64 10.0.16299
Extensions:

Extension
Author (truncated)
Version

Ionide-fsharp
Ion
3.12.1

python
ms-
0.8.0

cpptools
ms-
0.14.2

csharp
ms-
1.13.0

Steps to Reproduce:

run a text search (Ctrl-Shift-F) in a folder with very large files.
rg.exe can be seen churning away and I can't figure out how to cancel the search. Clearing the search box did not help.

Reproduces without extensions: Yes/No

You should be able to cancel the search by pressing escape. How large are the files? Are there symlinks in the folder?

I don't remember for sure but I think escape did not cancel (my first instinct would be to hit escape, but I may not have tried that).  I will try to repro at my first opportunity. There are several multi-GB text files in the folder, no symlinks.   I think a better UX might be to skip searching these files unless the user explicitly chooses to, for instance by showing in the search pane "this file skipped because it is large, click here to search"

On windows we set a max filesize of 300MB, so it should be skipping those anyway. If you can make it happen consistently, you could narrow it down by excluding some folders.

I'm going to close as no-repro.  Escape seems to be working fine.  If I can repro again I'll re-open.


Compile natalie.swift for performance

https://github.com/Homebrew/homebrew/pull/41649 cc @ldiqual

yes, because why not.
This is good case for Homebrew because it can be easily precompiled and installed. It's harder to manage it without pkg manager so it remain as script by default.


Issue building with Metro / Expo

I'm trying to build an app that is running through Expo but am getting a weird error. I'm currently using 0.4.6-beta Whenever I try to open the app I receive an error message that getSanitizedData is undefined when using it in nimble-emoji-index If I change the inclusion of getSanitizedData to be ../../utils instead of just .. everything works fine.
Has anyone else experienced this?

Hey @bchaney sorry for the late response!
We've not tested emoji-mart-native with Expo apps, did you find a solution? :)
I'm hoping to spend some time over the next couple months going through all issues etc and getting the lib to v1.0. It would be great to get this issue solved as well for that :)

Using emoji-mart-native with latest expo.
Everything works fine.

Will close for now, if you can still replicate @bchaney let me know and I'll re-open

For what it's worth, I'm now able to replicate on the latest version of Expo (though for some reason it does not replicate in a Snack, not sure if those are built differently or something). Our fix was just to fork and change this import from .. to ../ (https://github.com/aha-app/emoji-mart-native/pull/1). I don't have a good explanation for the issue, but happy to submit a PR if you want since this should make no logical difference anywhere else.

@schneidmaster please do :)


Runtime theme changing problems on Avalonia 11

If you install 3.0.0-preview* version and setup theme changing at runtime you can get troubles with, for example, TextBox colors (and left side bar in our demo):

This is known error and i don't know how to fix it. I think what that is something at Avalonia's side.
I figured out some workarounds:

You can set UseCompositor = false and UseDeferredRendering = false at your BuildAvaloniaApp method:

Make sure what you creating proper PLATFORMOptions, where PLATFORM is your platform actually.
You can use InvalidateVisual at root element of scene (or at elements what incorrectly painted). After that you should trigger actual repainting of everything - for example, change window size

Also, i need your help to find out exactly what causes this behavior, create a minimal representative example, and help the Avalonia developers fix it (or fix it on our end, but I have no idea). All ideas, PR, examples and other warmly welcomed.

I thought UseDeferredRendering wont affect this.
might we need research our theme applying procedure(((
I can try to addressing the reason of this glitch and fix workaround(if possible)

Wait if InvalidateVisual helps then it means procedure cannot notify avalonia that resources has changed
use Dispatcher invoking notify changes workaround?

Interesting fact: if we replace <TextBlock Classes="Body2" Text="Home" /> in ListBox in demo's MainWindow with just Home text - it will be change colors fine.
Here is gif:

<ListBox Classes="NoScroll" Name="DrawerList"
         Focusable="{Binding ElementName=LeftDrawer, Path=LeftDrawerOpened}">
  <TextBlock>Home</TextBlock>
    Home
    Buttons
    ...

Seems like, if we reset theme at runtime, all controls start working fine.
Step by step:

Controls (TextBlock, TextBox) doesn't react to theme changing
Remove MaterialTheme from App.Styles completely
Add back MaterialTheme to App.Styles
Control are reacting to theme changes fine now
But this is doesn't work for controls which created after theme reattaching. (for example, we have buggy controls at Home tab, do reattach, buggy controls fixed, after that we switch to Fields (TextBox'es) tab, everything doesn't work property for textboxes)

Seems like i figured out it in more details

Fixed with Avalonia 11 preview 5.


Support arbitrary metadata in reusable workflow inputs

We need to support arbitrary metadata the user wants to associate with its release, like the version, arch, etc as part of the reusable workflow input arguments.
These input can be set in the package descriptor of the attestation. If we have to use purl to pack all this, we'll offload its computation to the caller using callback PURLToPackageDesc() and PackageDescToPURL(). We will need to reserve certain field names like environment to simplify verification by the deployment attestation (this is mostly relevant for containers)

more generally, a reusable workflow takes as input:

package name
subjects, including their sha256. For containers, it's a single digest
package-metadata (version, arch, etc)

(1) and (3) are used to crate the package desc (in current code) or purl (if we switch to that).
(1) package is matched against the policy package name (without changes?)
(2) is used to populate the attestation subjects


[BUG]: PublishSymbols@2 failing with RequestExistsException

Task name
PublishSymbols@2
Task version
2.223.0
Environment type (Please select at least one enviroment where you face this issue)

[ ] Self-Hosted
[X] Microsoft Hosted
[ ] VMSS Pool
[ ] Container

Azure DevOps Server type
dev.azure.com (formerly visualstudio.com)
Azure DevOps Server Version (if applicable)
No response
Operation system
Windows Server 2022
Task log
"C:\hostedtoolcache\windows\VSOSymbolClient\19.222.33801.1.fe91ca4186\lib\net45\symbol.exe" publish --service "https://MY_ADO_ORG.artifacts.visualstudio.com" --name "Symbols_Core" --directory "C:\a\2\s" --expirationInDays "36530" --patAuthEnvVar SYMBOL_PAT_AUTH_TOKEN --fileListFileName "C:\Users\AzDevOps\AppData\Local\Temp\tmp6F4E.tmp" --indexableFileFormats ""Default"" --tracelevel verbose --globalretrycount 2
[Symbol App][VERBOSE] 2023-06-23T09:40:41.6873882+00:00  Version: 19.222.33801.1 built by: releases/M222 (fe91ca4186)
[Symbol App][VERBOSE] 2023-06-23T09:40:41.6873882+00:00  Commandline: "C:\hostedtoolcache\windows\VSOSymbolClient\19.222.33801.1.fe91ca4186\lib\net45\symbol.exe"
[Symbol App][VERBOSE] 2023-06-23T09:40:41.6873882+00:00  Environment: DotNetReleaseDword=533325
[Symbol App][VERBOSE] 2023-06-23T09:40:41.6873882+00:00  Performing operation...
[Symbol App][INFO]    2023-06-23T09:40:42.2967961+00:00  ApplicationInsightsTelemetrySender will correlate events with X-TFS-Session 99d2cf2b-764b-4260-9c6c-b375e0ede31a
[Symbol App][VERBOSE] 2023-06-23T09:40:42.2967961+00:00  Started ITelemetrySender ApplicationInsightsTelemetrySender.
[Symbol App][VERBOSE] 2023-06-23T09:40:42.3123769+00:00  PublishOperation starting
[Symbol App][VERBOSE] 2023-06-23T09:40:42.3592870+00:00  Authenticating with PAT
[Symbol App][VERBOSE] 2023-06-23T09:40:42.3592870+00:00  Credentials acquired
[Symbol App][VERBOSE] 2023-06-23T09:40:42.4061846+00:00  ArtifactHttpClientFactory.CreateVssHttpClient: SymbolHttpClient with BaseUri: https://MY_ADO_ORG.artifacts.visualstudio.com/, MaxRetries:5, SendTimeout:00:10:00
[Symbol App][VERBOSE] 2023-06-23T09:40:42.5467640+00:00  ArtifactHttpClientFactory.VerifyConnectionAsync: SymbolHttpClient.GetOptionsAsync starting
[Symbol App][VERBOSE] 2023-06-23T09:40:43.2033016+00:00  ArtifactHttpClientFactory.VerifyConnectionAsync: SymbolHttpClient.GetOptionsAsync completed with InitialRequestSucceeded
[Symbol App][VERBOSE] 2023-06-23T09:40:43.3751477+00:00  Symbol.CreateRequestAsync starting
[Symbol App][VERBOSE] 2023-06-23T09:40:43.6720480+00:00  ArtifactHttpRetryMessageHandler.TraceHttpRequestFailed: https://MY_ADO_ORG.artifacts.visualstudio.com/_apis/Symbol/requests, HttpStatusCode.Conflict, activity c993c72f-5eeb-4114-a2f0-10bcfc7b5527
[Symbol App][INFO]    2023-06-23T09:40:43.6720480+00:00  ArtifactHttpRetryMessageHandler.SendAsync: https://MY_ADO_ORG.artifacts.visualstudio.com/_apis/Symbol/requests attempt 1/6 failed with StatusCode Conflict, IsRetryableResponse False
[Symbol App][VERBOSE] 2023-06-23T09:40:44.3068006+00:00  Symbol.CreateRequestAsync failed after 0.9270253 seconds with RequestExistsException
[Symbol App][VERBOSE] 2023-06-23T09:40:44.3068006+00:00  Microsoft.VisualStudio.Services.Symbol.WebApi.RequestExistsException: Request 9516a0302416425c04f6a237b09b94ded6c18ca626490ab62273a8654c0b4a2d exists.

Multiple errors like below:

[Symbol App][ERROR]   2023-06-23T09:40:46.2935277+00:00  Failed processing C:\a\2\s\packages\boost_wserialization-vc<IP_ADDRESS>.0\lib\native\boost_wserialization-vc142-mt-gd-x32-1_77.pdb: ClientKey: boost_wserialization-vc142-mt-gd-x32-1_77.pdb/95C147233ECD4CD3858C97595C1E48611/boost_wserialization-vc142-mt-gd-x32-1_77.pdb
[Symbol App][INFO]    2023-06-23T09:40:46.2935277+00:00  Microsoft.VisualStudio.Services.Symbol.WebApi.RequestSealedException: Request 9516a0302416425c04f6a237b09b94ded6c18ca626490ab62273a8654c0b4a2d is sealed. Only expirationDate may be modified.

Relevant log output
[Symbol App][VERBOSE] 2023-06-23T09:40:44.3068006+00:00  Microsoft.VisualStudio.Services.Symbol.WebApi.RequestExistsException: Request 9516a0302416425c04f6a237b09b94ded6c18ca626490ab62273a8654c0b4a2d exists.

Microsoft.VisualStudio.Services.Symbol.WebApi.RequestSealedException: Request 9516a0302416425c04f6a237b09b94ded6c18ca626490ab62273a8654c0b4a2d is sealed. Only expirationDate may be modified.

Aditional info
Since Friday 23rd June our builds have been failing on the PublishSymbols@2 task with errors around RequestExistsException, the last build that worked was using PublishSymbols 2.220.1 on 22nd June.

The failing builds from 23rd June are using 2.223.0.

It seems there has been a regression with this new version or there is a new undocumented flag we need to provide?

Our pipelines looks like below, names redacted. For now we have set these to continueOnError so we can continue with regular builds.
    - task: PublishSymbols@2
      inputs:
        SearchPattern: '**\?(*.pdb)'
        SymbolServerType: 'TeamServices'
        SymbolsProduct: 'OurProduct'
        SymbolsArtifactName: 'OurSymbolsName'

Digging into this further I think the change between 2.220.1 and 2.223.0 that is breaking things is due to the --name argument passed to symbol.exe.
Previously it was actually ignoring the SymbolsArtifactName set in the yaml? So you ended up with something like:
--name "project/pipeline/master_<IP_ADDRESS>/62548/133fb1cc-9c15-4dcf-bef1-d7fade4a2645"
Now it just uses SymbolsArtifactName explicitly which means you get a clash?
The documentation does not state that SymbolsArtifactName should be unique. But it seems our fix is to just no longer set that parameter and we'd be back to how it was in 2.220.1
https://learn.microsoft.com/en-us/azure/devops/pipelines/tasks/reference/publish-symbols-v2?view=azure-pipelines

@KrisWragg-Certara thanks for all the details, I was hitting the exact same issue for the same reason. I'm also going to try removing the SymbolsArtifactName property.

@KrisWragg-Certara thanks for all the details, I was hitting the exact same issue for the same reason. I'm also going to try removing the SymbolsArtifactName property.

Hopefully it resolved your issues, its sorted things for us.

This happened to our pipeline as well. Not a cool unannounced / undocumented change!

We were also affected by this issue. Issue fixed by pin the Azure task just like @dg-abryant mentioned:
- - task: PublishSymbols@2
+ - task<EMAIL_ADDRESS>

My workaround was to set it to a unique name:
  SymbolsArtifactName: 'Symbols_$(BuildPlatform)_$(BuildSystem)_$(Build.BuildNumber)' # Adding BuildNumber to have a unique SymbolsArtifactName everytime the pipeline runs.


Add WaitForCondition and WaitUntilComplete ibgu functions

@klaskosk @josclark42 Could you please review when you have a moment? Thanks!

/lgtm


remove unused var from trapFocus.keydown fn

Fixes https://github.com/Shopify/theme-scripts/issues/28

Member -> Contributor 🎊


Added memory bandwidth performance counters in sparse adagrad kernel

@ddkalamk please review and merge

( Hmm, it looks like this PR is overriding the revised Makefile. This can be intentional, but perhaps also result from just not resolving conflicts. )

I used the latest Makefile @ddkalamk  was using for this kernel, overrode the earlier one.

@ddkalamk was outdated, can you please use the latest makefile and merge it with the changes of @ddkalamk ?

I reverted Makefile to use the revised version.

done --added libxsmm malloc/free

@alheinecke I removed _mm_malloc calls completely. Please review again. thanks

Looks good to me...

Thank you!  I will merge asap.


Add hit_back_faces property to RayCast3D

This adds the hit_back_faces parameter, found in PhysicsRayQueryParameters3D, as a property to the RayCast3D node.
For reasons that are not obvious to me this query parameter was left out of the RayCast3D node in #54857, which is causing some friction when using Godot Jolt, as Jolt's notion of back-faces include all shapes, including convex shapes, leading to users having to do their ray-casting manually, using intersect_ray, when they run up against this discrepancy and want to disable this parameter.
(The documentation was copied from the equivalent parameter in PhysicsRayQueryParameters3D.)

That ASan CI failure looks to be related to #78749 and not caused by this PR.

Thanks!

Hit from inside still not work.


Running batch mode from the command line, column heading error

Hello,
I am trying to run Pyradiomics using the batch mode in the command line. I have typed in the following:
pyradiomics <path/to/image> <path/to/output>
I am getting the following error:
E: radiomics.script: Required column "Image" not present in input, unable to extract features...
My input file is a csv file which contains 2 columns; the image and the mask. The first cell of each column contains the headings "Image" and "Mask", and the rest of the rows below contain the paths to the files.
Has anyone else had this problem?
Thanks

What is the list separator character used? PyRadiomics expects this to be ,. You can visualize this by opening the file using a simple text editor (e.g. notepad). Be aware that PyRadiomics is also case-sensitive for the column headers.

The separator that is used is a comma. These are the first 2 lines in my csv file:
Image,Mask
C:\Users\atamb\Desktop\MRIs\T1_mask\T1Images\ACC_T1.nrrd,C:\Users\atamb\Desktop\MRIs\T1_mask\T1Masks\ACC_T1_brain_mask.nrrd

Did you specify the -o parameter before the path to output? This is required when running PyRadiomics, otherwise it might be confused with running in single case extraction mode.

Yes that is correct. What version of PyRadiomics and Python are you using?
If I copy the line you posted, I am unable to reproduce the error. Can you share the actual csv file you use? I don't need the image/mask files themselves.

What happens if you try the testCases.csv file included in the repository (under examples)?

I couldn't attach a csv file so I have converted it to a tab delimited txt file:
t1_batch.txt
I tried the testCases.csv example and it works perfectly, so there is definitely just something wrong with my input file I think.
I'm wondering if maybe there's something wrong with how I have specified the paths (I have specified the full path)

Can you replace the following in radiomics/scripts/__init__.py? (L163-169)
original:
        # Check if required Image and Mask columns are present
        if 'Image' not in cr.fieldnames:
          self.logger.error('Required column "Image" not present in input, unable to extract features...')
          return None
        if 'Mask' not in cr.fieldnames:
          self.logger.error('Required column "Mask" not present in input, unable to extract features...')
          return None

replacement:
        # Check if required Image and Mask columns are present
        if 'Image' not in cr.fieldnames:
          self.logger.error('Required column "Image" not present in input (found %s), unable to extract features...', cr.fieldnames)
          return None
        if 'Mask' not in cr.fieldnames:
          self.logger.error('Required column "Mask" not present in input (found %s), unable to extract features...', cr.fieldnames)
          return None

This will at least print out what columns it did find in your CSV. I am starting to have an idea where it may be going wrong.

This is your file, comma delimited. Can you try it after changing the extension back to .csv?
t1_batch.txt

I changed the init.py file in this directory:
C:\Users\atamb\Anaconda3\Lib\site-packages\radiomics\scripts
and it didn't make a difference to the error. It is still saying:
(base) C:\Users\atamb\Desktop\MRIs>pyradiomics C:\Users\atamb\Desktop\MRIs\t1_batch.csv -o results.csv -f csv
[2020-06-06 20:11:42] E: radiomics.script: Required column "Image" not present in input, unable to extract features...
Maybe I am changing the wrong thing?
I also tried the file that you resent and it isn't working either. I might need to uninstall and reinstall pyradiomics and re-try it. I'm just not sure about this as it works fine when I run it for only one MRI

@AT3432984, Somehow it is reading your CSV file wrong. I don't really know where the error is located, as I'm unable to reproduce the error. My advice would be indeed to re-install pyradiomics and re-test. If that doesn't work, you could try to download the repository and run python setup.py develop, which installs pyradiomics to run form that repository, allowing you to debug more easily.

No worries, thank you so much for your help

I have met the same problem when batch processing, and the one approach to solve it might be to save the input csv file with UTF-8 code instead of  UTF-8 BOM. (becasue I created the csv file by Excel ) It could be modified by save as in Notepad.  Hope Helpful!

I had the same issue, I was saving the excel file as the wrong type of .csv file. Make sure to save it as "CSV (comma delimited) (*.csv)". There are a number of CSV types availble on Excel.

I want to run pyradiomics using terminal for batch processing. any help?


skip feature not considering redirects

Whilst the newly added skip feature does work, it will not work if you call a redirect as the static variable will default back (this is what I believe is happening anyway).
If this is the case, I need to use Session::flash as this already works the way we are wanting.

Session::flash is now being used and works as expected. Redirects will now successfully skip checks if instructed to do so.


How to store a Gaussian class inside a code How to save as a Gaussian ply for other rendering tools to visualize the 3Gaussian splatting of this project

How to store a Gaussian class inside a code How to save as a Gaussian ply for other rendering tools to visualize the 3Gaussian splatting of this project

Sorry for the late reply. You can save Gaussian ply file with this function.


Automated cherry pick of #2629: fix: incorrect import path of options pkg

Cherry pick of #2629 on release/2.12.
#2629: fix: incorrect import path of options pkg

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.12@5162ba0). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release/2.12   #2641   +/-   ##
==============================================
  Coverage                ?   7.15%
==============================================
  Files                   ?     458
  Lines                   ?   72515
  Branches                ?       0
==============================================
  Hits                    ?    5192
  Misses                  ?   66892
  Partials                ?     431

Flag
Coverage Δ

#aFlag
7.15% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5162ba0...8cbb08b. Read the comment docs.

/lgtm
/approve


Overriding parse() behaviour?

@HansKristian-ARM
I've run into an issue where it seems the cleanest fix is to override behaviour while parse() is running...but, since parse() is called directly from the Compiler constructor, there is no opportunity to override any behaviour.
Specifically...MSL does not allow a specialized constant to be used as an array length. Therefore, if a constant is used as an array length, I want to turn off the SPIRConstant::specialization flag for that constant in CompilerMSL.
From what I can see...the easiest place to do this is in the parse() function when OpTypeArray is processed:
	<...>
	auto *c = maybe_get<SPIRConstant>(ops[2]);
	mark_as_array_length(c);
	bool literal = c && !c->specialization;

	arraybase.array_size_literal.push_back(literal);
	arraybase.array.push_back(literal ? c->scalar() : ops[2]);
	arraybase.parent_type = ops[1];

where the mark_as_array_length () function would do nothing in Compiler...but in CompilerMSL, it would turn off the SPIRConstant::specialization flag. The rest of the existing code above would then automatically use the literal value of the constant as the array length...and so would all other uses of the constant for deriving array indexes, etc.
But alas...the overridden mark_as_array_length () function is not called because parse() is running in the superclass constructor. Similarly...I can't set an option flag value (eg. backend.allow_array_length_specialization) anywhere in a subclass that would affect behaviour within the OpTypeArray section of the parse() function itself within that subclass.
Does it make sense to move the calling of parse() into the compile() function instead of the constructor, in order to allow overridden behaviour during parsing?
Otherwise...I'm going to have to write an ugly and costly function to hunt down all the constants and figure out which ones are used by arrays...and then turn off the specialization flag accordingly...AND convert the array length values to literals after all.

This is related to #287 as well. I was thinking it might be useful to move the other way and split parse out of the compiler class entirely, which could simplify the class hierarchy issues mentioned.

Right, the compiler constructor will be run so that virtual functions cannot work. As mentioned in #287 making the parsing dependent on backend is a bit problematic because this will break any hope of reusing compiler output.
Fixing the virtual stuff is pretty easy if we just defer the parsing to the subclass constructor, but I would like to keep the parsing verifyably backend neutral if possible.
Would it be possible to add an unordered_set in Compiler which marks which spec constants are used as array sizes, and CompilerMSL can trivially fix this up in its constructor or compile()?
Also, you cannot really turn array sizes into literals in parse(). Spec constants mean that you will have to resolve array sizes to literals in compile-time in MSL does not support this. Of course, at that time you can emit pure constants since you should have all spec constant information.

@HansKristian-ARM
I understand your interest in keeping parse() backend-neutral...and that makes sense until we find a compelling reason not to.
I thought about creating an unordered-set to keep track of constants that are used as array lengths, but I thought a more integrated (and easier to understand) mechanism might be to add a is_used_as_array_length flag to SPIRConstant which can be set during parse() OpTypeArray...and then, in a  CompilerMSL compile() pre-processing stage, used to turn specialization off on any SPIRConstant instance for which that is set.
I think I'll make running this a CompilerMSL API context switch too...so that this mechanism can be turned on or off at runtime. Specialized array-lengths is the kind of thing that Apple might introduce at some point (I'll file a request), and so might become unnecessary for some future platform or OS versions.

Adding a field which explains its usage to SPIRConstant also works, I'm fine with that.

Stale issue, closing.


ast: implement SensitiveStmtNode for BRIEStmt

What problem does this PR solve?
Implement SensitiveStmtNode for BRIEStmt so SHOW PROCESSLIST won't leak secrets from the destination parameters.
What is changed and how it works?
Check List
Tests

Unit test

Code changes
Side effects
Related changes

LGTM


Robotic / metallic noise on S letters

Hi, this is really a wonderful project, so far it is the one that has the best quality compared to its alternatives, incredible how well it works with small datasets (in my case 9 minutes of clean singing), and how well it recreates the voice timbre.
I only have one question, is it normal that in the S letters or breaths there is a metallic noise? is it produced by the vocoder? I have trained my model for a longer time thinking that the noise would go away, but it sounds exactly the same, either with 20 minutes of training or more than 1 hour. Do I need to do a longer training? How many epochs do you recommend?
Thanks and congratulations for the project!

Well, on the contrary, you may want to try a shorter training instead😂. A small dataset cannot cover all tones thus the longer you train, the more details in the base model you lost.

If you have more data (20m+) and train for longer you can potentially smooth out the roboticness slightly. Don't forget to equip the .NPY and .INDEX trained (sometimes .NPY greatly helps reduce the robotic noises) but in some rare cases .INDEX can introduce a lisp (Zundamodel)
I find DIO trained voice models to have a softer robotic sound than default HARVEST and the sound quality is about the same.
Changelog indicates future plans for a possible improvement in reducing it further. "Collect breath wav and add it to the training set to correct the problem of breath changing sound and electronic sound "

If you have more data (20m+) and train for longer you can potentially smooth out the roboticness slightly. Don't forget to equip the .NPY and .INDEX trained (sometimes .NPY greatly helps reduce the robotic noises) but in some rare cases .INDEX can introduce a lisp (Zundamodel)
I find DIO trained voice models to have a softer robotic sound than default HARVEST and the sound quality is about the same.
Changelog indicates future plans for a possible improvement in reducing it further. "Collect breath wav and add it to the training set to correct the problem of breath changing sound and electronic sound "

Thanks for your answer! I use the file total_fea.npy and one called Added.index, (since that is how it is pointed in the gradio interface) and that's how the model sounds. There is an .Index called trained, but if I select it the model just "sings" similar to a pure tone with background noise. Therefore, I concluded that the added.index was the right one. Is this correct?

I'm honestly not entirely sure of the 'correct' one to use (trained or added) since I'm only a week into RVC- but haven't really noticed a difference between the two. Use the one that works better than the other for your voice. 🤣
Sometimes index helps my models and changes the breathing quite a bit and other voice models don't have much of an effect (I also swap between 32k / 16k) which also changes the robotic sounds / breathing slightly on some models.
You really have to find the sweet spot for your own voice and data / always seems to behave differently. DIO actually only benefits one of my models more than the others/improvement is minuscule. Hopefully the future planned update fixes this for good so we just have to be patient and pray. 😊

Hello to all @Mixomo  @fumiama  @Tybost  @ath  @hiwanz
Could you tell me how do you guys make sure the VOICE created with the .pth files become LESS robotic and MORE human? What other tools do you use? Where do you use your models.pth files? What other techs and ideas?
Please tell me!
Please
Thanks.

I found that running a de-esser on the end result does wonders.
Alternatively, you just open it up in Audacity, duplicate the channel, run one through a low-pass filter (6000 Hz, 48db), one through a high-pass filter (again, 6000 Hz, 48 db), run the latter channel through heavy compression, make it quiet, then merge them back together.


Stylecop

Only 2291 Warnings ‾\(ツ)/‾

Only 212 Warnings now!

Ok all the low hanging fruit is gotten.  Mostly this. and naming and whitespace.
I'm now going to work through each class and solve the warnings 'per class' and review the tests at the same time.

0 warnings! +9380-5,378 and 13 days of hacking.  But has been insightful and added some new tests and minor refactoring (like removing redundant parameters).
https://github.com/gui-cs/TerminalGuiDesigner/compare/5f7a468b5ffb87aca7a331b033207049b83d99e6...e795ad6b7369cc30b5c719be001d56dcf9b410bc


fixed B3 hex encoding issues with trace identifiers.

Lower numbers represented in HEX where not prefixed with 0's so not adhering to B3 standard which requires:

traceid's 32 hex chars in case of 128bit / 16 hex chars in case of 64 bit
spanid & parentspanid: 16 hex chars

closes #97

@basvanbeek could you add a version tag?


Make the deadlock detection timeout configurable

What was changed:
Make the fixed deadlock detection timeout configurable.
Why?
We see that some code in our workflows takes longer to execute during the first run, most likely due to hotspot compilation combined with other containers starting up.
This may happen to any workflow and is not related to calling Thread.sleep or anything similar. Making the default timeout configurable gives users the option to adapt the threshold. Setting TEMPORAL_DEBUG=true is not desirable as it would disable a useful feature.
Checklist

Closes issue: None, but it's related to https://github.com/temporalio/sdk-java/pull/296

How was this tested:
Workflow with a >1000ms wait time

Any docs updates needed?
Possibly https://docs.temporal.io/docs/java/testing-and-debugging/ is you want to mention it there

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I wonder if it's worth to readjust this value at all, even if you see some errors, they shouldn't be fatal for the workflow and should be gracefully retried.
It's hard to come up with an ideal number here, if you had ability to override this value what would you set it to? @mfateev what do you think?

@vitarb thanks for having a look!
 So this is more of a nice-to-have and I'd agree that having this as a configuration option on the workflow would be more user-friendly.
I altered this PR to extend the timeout to 3000ms and remove the configuration option via env var. I'd appreciate if you would consider the option to make this configurable on the workflow options.

Do you have some data to prove that 3 seconds would be better than 1? If no I would prefer to keep it a 1 second. There is nothing wrong with adding a worker option to make this configurable in my opinion. Would you like to contribute this change as part of this PR or do you want us to do it?

3 seconds would be better for our case but there's no way to determine if that's right for everybody, that's why I think allowing configuration is the way forward.
Until then we'll do some code-prewarming, this alleviates the issue for us. I'll see if we can add the worker config option in a PR but it's not a big priority for us at this moment.


Feature request: Add a shortcut to jump directly to a specific feed (low priority)

Add a g + f shortcut to jump directly to a specific feed (like GMail's go to label shortcut). As in GMail, provide inline auto-completion as the user types the name of the feed.
This is a low priority, convenience feature request. It could be rolled into a larger shortcut update, as well.

Funny, it's been exactly a year since you made this recommendation, and I don't think a day has gone by where I didn't want to just type in the feed I was looking for. I have a feeling this is going to be one of the very next things to be built after I launch social in a few weeks.

Very exciting! Looking forward to it.


Automated Performance Profiler and Optimization Hints for MDK Projects

MDK is a powerful toolkit, but as scripts grow more complex and performance requirements get stricter, optimizing code within Space Engineers' limitations becomes a significant challenge. An integrated Performance Profiler for MDK would allow developers to analyze their scripts’ efficiency in real time or pre-deployment, with tailored hints and suggestions to enhance performance without compromising on functionality.
Space Engineers developers often face performance bottlenecks due to script size limitations and in-game execution constraints. Profiling scripts manually is time-consuming, especially for complex projects that involve various calculations, nested methods, or heavy-use functions. Currently, developers are left to trial-and-error methods or external tools, which don’t fully align with the specific environment and limitations of Space Engineers.
This feature request is for an integrated Performance Profiler and Optimizer that would:
Profile Code for Performance Bottlenecks: Analyze code structure, frequency of method calls, and variable usage to identify sections that could slow down the script in-game.
Provide Optimization Hints: Based on the profiling data, suggest improvements like method inlining, redundant code removal, or recommended minification techniques for specific code sections.
Real-Time Analysis Mode: A testing mode that allows users to run a simulated execution of their script within MDK to see approximate performance impact in real time, even if the game isn’t open.
Efficiency Score and Diagnostics: Assign an efficiency score based on code performance, giving clear diagnostics and suggestions on how to improve. For example, it might recommend turning repeated calculations into constants or consolidating nested methods where feasible.
However, I do foresee the following considerations and challenges:
Space Engineers Execution Limits: MDK would need to account for the unique execution constraints of Space Engineers, so the profiler remains relevant and accurate within the game’s environment.
Profiling Overhead: Ensure that the profiler itself doesn’t significantly increase code overhead, potentially by limiting the analysis scope to development time, with possibly an optional in-game real-time debugger(similar to a Just-In-Time debugger tool).
Complexity vs. Accessibility: While this is an advanced tool, making the output user-friendly is key. The optimizer should provide actionable insights without requiring extensive expertise in optimization.
With these in mind, I propose these following solutions:
Modular Profiling Tools: Allow developers to toggle different profiling tools on and off, focusing on specific performance aspects they want to optimize.
Diagnostic Feedback Loop: After profiling, the tool could provide suggestions, and once these are implemented, developers could re-profile to measure improvement.
Code Refactoring Suggestions: For example, the tool might suggest combining methods, optimizing loops, or reducing allocations for better script performance.
An integrated Performance Profiler and Optimizer would be a valuable addition to MDK, as it would:
Save Development Time: By automating the profiling process, developers can focus on writing features rather than troubleshooting performance issues manually.
Encourage Best Practices: By providing suggestions tailored to the Space Engineers environment, the profiler would promote efficient coding standards.
Improve Script Reliability in-Game: Optimized code would not only perform better but also reduce the likelihood of runtime errors or performance drops in Space Engineers.
Given MDK’s community-driven nature, feedback from developers who routinely work with complex scripts would help refine this feature. Contributions are welcome to expand the profiler’s capabilities or adjust the optimization hints for broader applicability.
Thank you for considering this feature request! I hope you let me know your thoughts, all of you reading this! You took the time to read, may as well let me know! No, seriously! Reply! I want answers!  Do you know who I am?!
Sorry, I just get worked up about debugging.  They say I'm obsessed with optimization. I say "Nah." because that is the most performance cost-effective response.
Soooo..... are you gonna reply to this feature request yet?

Sorry. Wayyyy too much work. Especially since MDK2 is now IDE agnostic so a different set of tools would be required for the different IDEs, primarily Visual Studio, VSCode and Jetbrains Rider.
I am just one man and I'm already a fully employed software engineer. This is a spare-time project.


Should the zones sort themselves?

It seems like while playing, when you just draw a new card it can pop up next to a previous card with the same name. It seems like zones are sorted according to entity id. I'm not sure this is good behavior, should we instead have new cards to a zone always appear last?

There are a couple of different kinds of zones:

I think Hand should definitely be sorted by draw order.
On the Battlefield I guess it makes sense too, though I can't seem to let go of the way they did it in Hearthstone. The difference to HS is of course that card positions actually matter in that game, as opposed to Cardshifter.
Non visible zones like Cards: nothing to do here.

This would probably be fairly simple to implement in the Vue.js client.

With Vue this would be very easy. Just have a computed property that can be sorted or not sorted.


Migrate "Change Time Zone" from wiki

Migrating the "Change Time Zone" page from the wiki to jenkins.io.
Links

https://github.com/jenkins-infra/jenkins.io/pull/3379

@allcontributors please add @Taeloz for documentation

Thanks for your contribution!


⚠ Bofrost.be has degraded performance

In b262854, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 982 ms

Resolved: Bofrost.be performance has improved in 154195b after 9 minutes.


Atomic numeric update operations support in Go Client (increment/decrement/multiply/divide)

/bounty $25

@Shubham8287 Sure, go ahead and take this one :) Yes, please implement similar to TS SDK.

@Shubham8287, Right, fields/update.go is where changes should go.
You Just need to add corresponding fields, similar to https://github.com/tigrisdata/tigris-client-go/blob/main/fields/update.go#L31 .
Please mind the json tag here which is what will be marshalled: "$divide" and "$increment" in your example above.
Also corresponding setters should be implemented, similar to:
[Object scope] https://github.com/tigrisdata/tigris-client-go/blob/main/fields/update.go#L63
[Package scope] https://github.com/tigrisdata/tigris-client-go/blob/main/fields/update.go#L83

@Dasio Buddy, not sure what made you work on this but the issue was assigned to me and I was about to raise a PR for this. We should respect basic rules to work on open source just to avoid things like deduplication of efforts.

Sure go ahead, I was just testing Algora. You have started 2 weeks ago and no PR.
I was looking at several issues, and users just assign issues without any work. But yeah you are right.

Hi, @Shubham8287 how far along are you with the implementation? If you still need to make progress, then it would be better to let @Dasio proceed with this.

I am fine, Let @Dasio go ahead with this.
for @Dasio first of all, I think maintainers should care about timelines, they know the priorities better and Algora should decide about a number of issues at the time not us and rather we should .

You are just assigning issues to yourself and don't leave anything to others and then even simple issues are blocked for multiple weeks without any good reason.
Not sure, what analysis made you say this. I have 2 other issues assigned to me, One is in review for a long time and the other is pretty big and expected to take time. I have ~3 closed issues, and all of them took about ~2 days (including a task with Tigris as well). though I do not need to justify any of this to you.
I am here to do Engineering and learn, not to argue. Good luck!

Sorry maintainers for spamming here.

hey everyone, this is ioannis, one of the founders at algora. our sincere apologies for everyone's inconvenience here, it's our fault, we'll do a better job of marking in progress and giving status updates. we already updated our bot reply for new bounties, it now asks to use a /attempt #236 command to notify everyone, and we'll prevent folks from using /attempt in multiple bounties of the same org. this is all new and we appreciate your input and the opportunity to improve the workflow with your feedback, thanks in advance for the understanding

@Shubham8287, thanks for the flexibility. We appreciate your contributions and would love to see them continue.
P.S. we do not have any issues with multiple issues being worked on by the same contributor


Mobile Support / Responsive Design

Description

Automatically adapt its layout based on the screen size and orientation (portrait or landscape).
Be touch-friendly, with larger buttons and touchable elements.
Prioritize essential information, ensuring it's easily accessible on smaller screens.
Utilize collapsible menus and sections to minimize clutter and enhance navigation on mobile devices.

Have you provided an initial effort estimate for this issue?
I have provided an initial effort estimate

I would like to suggest that the next Layout Manager could support a hierarchical model, so one could group components inside flex sublayouts - inside each other - in different combinations of row /columns (flex-direction:row and flex-direction:column) , which might be enough to meet most needs.

FYI @joepavitt

Thanks @walterjj! I've just pushed the foundational model for Dashboard 2.0 in this PR which includes a new layout architecture vs. Dashboard 1.0
Each "Page" within the Dashboard UI's will have a new option - "Layout". We then have a /layouts folder with a collection of different layout options.
Each layout takes the collection of widgets passed to the given page and that "Layout Manager" then chooses how to display said widgets.
My thinking here is that by having multiple "layout" options, we could have something super simple to get 80% of people off the ground, through to more complex configurations that allow for customisations but may have a slightly steeper on-boarding curve.

Good @joepavitt! may be if  a ui_group can have a also a "parent" property, or a "group" property instead of "tab"  or "page" ,  that future layouts could use these properties in order  to implement a nested hierarchy!

A critical aspect of mobile / responsive design for my existing Node-RED dashboard is for the table gadget to switch to card view on mobile sized screens.
Tables with more than 2-3 columns that are more than 20 or so wide are simply too wide to view on a mobile sized view port.
As the view port becomes more portrait vs landscape, to have the table gadget switch to a card view becomes critical to eliminate horizontal scrolling.
See the last three Tweets for an example:
https://twitter.com/thebaldgeek/status/1664755773329780736?s=20

Thanks for the insight @thebaldgeek - will be sure to make that a feature

Generally speaking, we have responsive design already now in place. With the specific request above re: tables, we have https://github.com/FlowFuse/node-red-dashboard/issues/76 opened to cover this.


regression - ensemble.CountryCodeSelector widget does not show the selected country code anymore

see this - https://studio.ensembleui.com/app/nLEcmxcORmCec1CrAgvG/screen/cBEjFoPXstpjNRYkWZZW
or just paste this EDL-
View:
  styles:
    useSafeArea: true

  # Optional - set the header for the screen
  header:
    titleText: Home

  # Specify the body of the screen
  body:
    Column:
      styles:
        padding: 24
        gap: 8
      children:
        - Text:
            text: Hi there!
        - ensemble.CountryCodeSelector
     ```

1. select a country code from the dropdown
2. it doesn't show the selected item

the actual issue is that the country selector widget has repeated values which is not allowed by dropdowns. This is because some countries share the same country code such as Canada and US (+1). The fix is to handle it properly in the country selector implementation.

I am unable to find related code for this. Would appreciate any help navigating to that widget.
cc @kmahmood74 @TheNoumanDev


Add support for bicycle:dismount.

Add support for the vehicle tag for bicycles and foot.
Theses changes were triggered by issue #695.

Thanks! I think I'll have time this week to look through all the nice work of you :) Sorry for all the delay ...

Sorry again for the delay - now merged!


Remove Clipboard.js dependency

We don't need another JS package to implement "copy to clipboard" action.

Fixed in https://github.com/liyasthomas/ludacris/commit/09be00608a4c54788cdd4028169c6546b850762f


JOIN and query_as!

How do you handle joined rows with the query_as! syntax? I tried specifying a tuple but it doesn't work and I didn't find any example anywhere.

@alucryd can you give an example of what you're trying to do?

Sure thing, this is the select I'm talking about: https://github.com/alucryd/oxyromon/blob/a3b7b1ff10473a7ac9c689166dafb502616435b8/src/database.rs#L593
Had to narrow the select to return only the roms columns, or else query_as! would complain because there were more columns than fields in the struct. Also scratched my head for a while when using the non macro version because the returned Rom struct contained fields from the joined games table which wasn't obvious at first.
So how do you tell sqlx that the returned rows contain 2 structs? diesel uses a tuple in this case but I could't find the sqlx equivalent.

I'm in the process of trying to figure this out as well, based on the examples in #1014 I think the following is supposed to work:
struct CombinedStruct {
    a_result: A,
    b_result: B,
}

query_as!(CombinedStruct,
    r#"SELECT a as "a_result!: A", b as "b_result!: B"
       FROM first_table as a INNER JOIN second_table as b ON a.some_col = b.other_col"#
).fetch_all(conn).await?;

This assumes the A and B structs are derived with sqlx::Type.  You can also change a as " with something like ((a.col1, a.col2) as "

@Kruptein what errors are you running into with the above? Just the one from #1031 or something else too?

I get
implementation of `sqlx::Decode` is not general enough
`std::option::Option<std::string::String>` must implement `sqlx::Decode<'0, Postgres>`, for any lifetime `'0`...
...but `std::option::Option<std::string::String>` actually implements `sqlx::Decode<'1, Postgres>`, for some specific lifetime `'1`

which seems to just be the same Option decode problem.
My struct also gets flagged with a warning "unnecessary braces around function argument", if I add the sqlx::Type derive, but unsure if that's a problem

My struct also gets flagged with a warning "unnecessary braces around function argument", if I add the sqlx::Type derive, but unsure if that's a problem

Yeah, that's also kind of a bug in the macros. Maybe adding #[automatically_derived] will be enough to fix it. Worst case the generated code will have to disable that lint.


orchestrator should be able to save opa config bundles to Google (or S3 or Azure or any OCI)

Notes:

Create bucket on GCP.
Create access token/credential with read access to bucket.
Create access token/credential with write access to bucket.
[Test] Add bundle file to bucket (first time manual upload for testing).
[Test] Configure OPA server to read from GCP bucket with the appropriate config using read credentials.
[Code] Docker deploy OPA server with GCP bundle config.
[Code] Hexa Admin/Orchestrator should read in OPA integration config with write credentials for GCP bucket.
[Code] Hexa Orchestrator should write policy to GCP using the integration key.
Verify everything works in unison.

@wfernandes I'm getting this error on startup:
hexa-demo-config   | 2022/11/09 21:44:01 Found server host <IP_ADDRESS>:8889
opa-server         | error: config error: invalid keys configuration: no keys provided for key ID jwt_signing_key

@ggebel Oh. We updated the local docker setup to use GCS as the bundle server. I can provide you the env vars to set in order to get that working. But we can discuss at standup to decide if for the local docker setup, we should just use the local bundle server instead of GCS.


Alot of duplicates

Hi there! Love the script its amazing but for some reason im getting many duplicates with the exact same variations. How can i resolve this issue?
Could it be the way im defining the rarities?
Under one group I can use multiple #tags; like one layer can have #100 and the other between 1-80 (#1, #5, #15, #30 and #100 beeing the highest etc.)
Thank you!

Noticed on your video on youtube (https://www.youtube.com/watch?v=YAexk-Qjtt0&t=1473s) at the sent time (24m 33s) you click on your number 9 generated image then on number 10 and those two are exactly the same. Is this a bug of some sort, since you say at some point in the video that it should never take the same combination twice.
Sorry for the multiple posts but thought this information would be critical to your investigation :)

Confirmed , even you create just tow folders with 2 layers in each one , the app gives you duplicates , any solution please ?!


Enable GPU for MatMul float64

Enabled GPU registration for MatMul operations of type double. This partially addresses #1140.
I realize that this is a very small change, I wanted to become familiar with the pull request process before making moderately big changes.

Can one of the admins verify this patch?

Did you test this out locally, by any chance?

Yes, tested it using the following:
bazel test -c opt --test_verbose_timeout_warnings --config=cuda //tensorflow/python:matmul_op_test

Cool, thanks!  This used to not work because we compiled an Eigen version of contraction which didn't support double, but cublas supports it, so we're all good.
@tensorflow-jenkins test this please

I'm going to work on making float64 work on the GPU for other ops as well. Would you prefer pull requests for each op separately, or multiple ops at once?
I'm sorry if this is the not the right forum for me to be asking this. In case it isn't, is there some place someone new like me could ask questions?

Keeping it manageable is always good!  Doing classes of ops at a time is fine -- you can probably do a bunch of related ops at once so they're easy to test and verify together.    This is a fine forum to ask about this, since it's about development / new code features.

This is weird. The test passes on my machine, don't know what's wrong. I tested it again.

Going to try one more time, the test that failed wasn't the 'double' one...
test this please, @tensorflow-jenkins

Sorry, I was on vacation, can you rebase?

@vrv I think I messed up the rebase, it is giving me all the commits that weren't there in my branch. How do I fix it?

I'm not sure, I generally do (on the dev branch);
git fetch upstream
git rebase upstream/master
git push -u origin $branch

You might want to start again in a new PR if it's too messy to undo for you

Right, I'm closing this. Will send out a new PR.


contribution ?

Hey,
Don't you want to contribute to the initial project instead ? I'm 100% okay with contributions, it would be easier
Have a nice day

Hey there,
I am not very familiar with how contributing works. If you can point that out I can do that sure.


Idn fix

Q
A

Is bugfix?
✔

New feature?
✔

Breaks BC?
❌

Fixed issues
❌

I don't think this should be a requirement.


Upgrade to mypy 0.590 & distribute py.typed file for API

These are pretty tiny commits, but are separate issues:

the mypy upgrade had no issues as far as I could tell, but seemed good to isolate;
the py.typed file and installation seems relevant to the API package.

@eeshangarg This seems to be a reasonable minimal packaging change, but I'm not as familiar with the packaging intricacies as you :) Do you have a recommended test method for this?

@neiljp I think one way to test the packaging would be to upgrade zulip.git repo to use it; we have a bit of code that depends on the python-zulip-api module, and we could see if it type-checks.

I think it's safe enough to merge this; that'll make it easier to do the testing.


upload annotation coco 1.0 using API

Hello Guys
I tried to upload annotations in coco format using the api: http://cvat-....com:8080/api/tasks/46/annotations/?format=COCO%201.0'
Cod:
url = f"{host_cvat}/api/tasks/{task_id}/annotations/?format={data_format}"
with open(annot_json_path, encoding='utf-8') as annot_json:
    annot_json_data = json.load(annot_json)

payload = json.dumps({
"annotation_file": annot_json_data # ou [annot_json_data]
})
headers = {
'accept': '*/*',
'Content-Type': 'application/json',
'Authorization': f'Token {Token}'
}

response = requests.request("PUT", url, headers=headers,
                            data=payload
                           )

But when I upload the files I get the following error:
{"annotation_file":["The submitted data was not a file. Check the encoding type on the form."]}
if I use this in request: files={'annotation_file': open(f'./{annot_json_path}', 'r')}
return this error: '{"detail":"JSON parse error - Expecting value: line 1 column 1 (char 0)"}'
The json file not have problem, Because ai can upload using the IDE, but not using API.
I need your help please.
Thanks

Hi. Please check the CLI for an example.

Is it necessary for the file to be zipped? or a json? Thanks.

No, it depends on the format. You can find information about accepted files here. For COCO format, you can send a json or a zip.

I'll close the issue. Please feel free to reopen if there are any other questions.


CSM - data belong to subsystems will not be restored correctly

After adding the SpatialData serialization to the CSM I checked if the CSM stores if data is added to it by a subsystem during a merge. It seems like this is not the case. So restoring the original subsystems using unmerge will add no data to them even though it was present before merging.
I think we can treat it as low priority since we do not have any external users yet and we haven't really used the unmerge function so far.

good to know, thanks
I agree on your assessment, we should keep this in mind for now

This is identical to #494 which has already a linked PR. Closing here


Add ACL support

See #264

I have no idea how to unit-test this feature.

Try running the existing tests first. They're failing under Travis, so it's highly likely the changes in this PR broke something.
Once you figure out what's wrong, try fixing it. That should give you a good feel for how smart_open performs testing, so at that point, you should be able to come up with a way to test the new ACL feature. If not, let me know.

Closing as #264 describes a workaround.


Make params variables

This all looks good. Only think I'm wondering is whether there's a better name for the _STRUCT named tuples. Would it make sense to call them e.g. GridParameters (so we name them like a class rather than a constant)?

Good idea. I changed to GridParamType since GridParameters is quite close the grid_params variable that gets created when instantiating the namedtuple. Does that sound ok?


add server closed error

hi, I'd like you to give me a chance to handle server error.
I read #1778 and checked your code snippets.  I'd like to handle error as below.
I think server closed error can be treaded as normal termination but I think it's a little hard for someone who is not familiar with quic-go internal.

func (l *MyListener) Accept() error {
	for {
		sess, err := ln.Accept()
		if err == quic.ErrServerClosed {
			return nil
		}
		if err != nil {
			return err
		}
		go handleSession(sess)
	}
}

As I explained in #1778, I don't see any need to expand our API here.
Do you have any new information to add to that discussion?

Closing this PR for now. As mentioned in https://github.com/lucas-clemente/quic-go/issues/1778#issuecomment-529322513, I'm happy to revisit the introduction of a new error code (or an interface, or something similar) when a compelling use case is presented.
My reluctance to introduce something now is that we're trying hard to keep quic-go's API as small and as simple as possible.


Triple entry of polls in dev branch

As shown, in master all the polls have single entries, while in dev all polls are entered three times. This is not a ui bug, since the rpc calls also return the seperate polls with burnamount and recipient appended to the title, meaining they are each read three times from the application cache.

I remember this from long time ago and IIRC it was since fixed. Are you running the latest version? Did you use the Load History button? It does not occrue on my build.

This is using Load History, screenshots are from a master and dev branch build. Rpc calls do the same.

This is a regression from the AppCache double map rewrite. We will now store 3 different entries in the cache. Converting polls and votes to objects would remedy this but in the meantime we will have to do a textual verification to discard burn and recipient similar to this.

Recipient and BurnAmount entries are never used (grep). I suggest removing it from MemorizeMessage. This also saves some bytes in AppCache.

Note to self: Cherry pick #1062 to staging and then close.


How would you go about creating multiple channels and rest api per channel

Im confused as to how the rest server knows which channel to use, since it uses the connection profile from the rest api "networks/${NETWORK_ID}/connection_profile" - however this can and does return multiple channels when you have more than one.
How does the rest server know which channel to use, when its just given a card and i cant see how the card is bound to a channel ?
Thanks

Straight from the Hyperledger Composer documentation - in the connection profile, you can define multiple channels, but Composer can only work with 1 channel.
This defines the various Hyperledger Fabric peers and orderers that are participating on a specific channel as well as the role of the peers. IMPORTANT Hyperledger Composer can only work with 1 channel, so you need to ensure that only a single channel is defined in this section even though the document can support multiple channel definitions.```

You can read more about this here: https://hyperledger.github.io/composer/latest/reference/connectionprofile

Hope that helps.


Control connection should try to reconnect in a more persistent way

Right now, when the control connection fails for any reason, the driver goes over other addresses and tries to reestablish it, but it only does so once. In a corner case when the list of known nodes contains only 1 working node, this mechanism will always fail if metadata fails to be fetched from this working connection once, even if it's a transient, temporary failure. The heuristics for reconnecting should be modified to try harder - because failing to establish a control connection results in killing the whole session.

Closing as invalid for now (ref: #399)


How To Get Value of Select Element?

I am trying to get the value of a select element.
I have tried element(by.id('select_id').$('option:selected').getText(), but I am getting an error that 'option:selected' is not a supported selector.
Thanks in advance!

You should be able to use option:checked.
That said, your question is better suited for StackOverflow or Gitter. If that does not help, lease ask a question there with the 'protractor' tag or post in the Gitter Channel.
From the the getting help section of the README:

Please ask usage and debugging questions on StackOverflow (use the "protractor" tag) or in the Angular discussion group. (Please do not ask support questions here on Github.)

Ok thanks @NickTomlin very helpful! I apologize for not directing my question to the appropriate forum.

Ok thanks @NickTomlin very helpful! I apologize for not directing my question to the appropriate forum.

Not a problem at all :) just trying to keep the issue queue clean. If you wouldn't mind closing the issue that would be lovely. Thanks!

option:checked will not work in PhantomJS, as it is missing support for the :checked selector. However, what will work (fsvo) is:
var select = element(by.id('select_id'));
return select.getAttribute('value')
  .then(function (i) {
    return select.element(by.css('option[value="' + i + '"]')).getText();
});


chore(dal, sdf): Refactoring the Asset Authoring experience behind a client

This keeps it inline with Func Authoring and will allow us to test the pieces in isolation rather than needing to go through SDF for testing

bors merge

bors merge


[do not squash] various signin improvements

To help with QA for this, I've temporarily pointed dev Auth0 to this PR environment's auth-frontend. Need to revert that before merging.

undone


Reuse JSDOM instances across targets

I've been investigating a performance problem we ran into at Airbnb
the last couple of days. We have some components that end up with
very very large dependency graphs, which makes the webpack bundle
quite large. Looking at the CI output, it seems to take about 2 min
to bundle, which isn't the most terrible thing. But, then I've
noticed that the timings for the targets are pretty crazy. Look at
these logs:
[2020-06-17T19:36:15Z] image_analytics was not bootstrapped
[2020-06-17T19:36:37Z]   - chrome-medium ✓ (22034.4ms)
[2020-06-17T19:38:38Z] No examples found for target chrome-mediumPlus, skipping
[2020-06-17T19:38:38Z]   - chrome-mediumPlus ✓ (4.0ms)
[2020-06-17T19:41:05Z] p3_defer_modals was not bootstrapped

Here chrome-medium had examples, so it took snapshots and that took
a while which makes sense. mediumPlus didn't have examples, so it
took no snapshots. Happo says that mediumPlus took 4ms, but if you
look at the timestamps in the log lines, you can see that it
actually took 2 minutes.
I believe that the time spent on empty targets is in initializing
the JSDOM and loading up the webpack bundle. Since we have 6
targets, this adds up to 12 minutes of overhead per job just for
loading the bundle, and another 12 if we have to check out previous
SHA. This is much too long.
I think we can improve performance by reusing the JSDOM instance for
all of the targets. In the example above, this should save us about
10 minutes on a run where the previous SHA report exists, and 20
minutes on a run where the previous SHA report does not exist.
One potential issue that could arise from this is if there is any
side-effecty code in the bundle that looks at the viewport size when
it is first executed, that will no longer work quite right since we
run the bundle and then resize the window later.
In order to preserve backwards compatibility with other DomProvider
plugins, like the puppeteer plugin, I left in the width/height in
the initialization call, and included a guard around the resize call
in case it does not exist yet. We should clean these up in the next
breaking change.

Looking at the test failures I see this:
FAIL  test/integrations/react-test.js (19.096s)
  ● with multiple targets › produces the right number of snaps in each target
    TypeError: Cannot redefine property: width
        at Function.defineProperties (<anonymous>)
      81 |     this.dom.window.outerWidth = this.dom.window.innerWidth = width;
      82 |     this.dom.window.outerHeight = this.dom.window.innerHeight = height;
    > 83 |     Object.defineProperties(this.dom.window.screen, {
      84 |       width: { value: width },
      85 |       availWidth: { value: width },
      86 |       height: { value: height },

      at JSDOMDomProvider.resize (src/JSDOMDomProvider.js:83:12)
      at processSnapsInBundle (src/processSnapsInBundle.js:20:19)
      at generateScreenshots (src/domRunner.js:164:45)

I've run into this issue before, and I don't know of a workaround (yet).

Btw, if you want to iterate quickly on this locally, you can run yarn test --watch react-test -t multiple (remember to run yarn build --watch as well in a different terminal).

After trying this out on our codebase, I'm nervous about merging it. We noticed a number of diffs where state from a different target had spilled over into other targets. For the most part this was okay, but I think it will make Happo more confusing to work with and may make rendering some things not possible. This was mostly problematic for code that read the viewport size and expected it to not change.


FHIR Authentication wrap up, --> Part Two <--

Continuation of ticket https://github.com/CDCgov/prime-reportstream/issues/659
Finish the end to end testing:
Testing new:
create a new sender, with the public key. Put the sender inside the 'ignore' organization and test the logic to:
-> communicate with a backend secured endpoint without a token
-> communicate with a backend secured endpoint with an invalid token
-> obtain a new token and use it to communicate with a backend secured endpoint
cleanup: delete the sender when the test is finished.

Done.   Merged in, and moved to cli/tests