Support launching a HBMixedLambdaApplication as either HTTP or Lambda

This PR allows users to conform to HBMixedLambdaApplication (both HBApplicationProtocol and HBLambda). This allows running in either mode, through a getter. The example implementation toggles based on a value in the HBEnvironment.
Naming is very much open for discussion, I'm far from happy with this name

Can we close this now, anyway with the Source associatedtype this won't be possible anymore


Curve Texture Editor Iemprovments

I notice its not possible to increase the length of the handles in the curve editor. It would be nice if there was a key (ctrl or alt) that would allow the user to increase the length of the bezier handles.
Also there needs to be a way to increase the size of the editor, possibly even to open it where the 3D/Scripting main window is to allow for fine control. Currently we can make it wide, but cannot increase the height.

Also an option to preview the curve as a repeating loop to check the in's and out's of the curve :)

Note that a curve cannot have overhangs, and allowing to make handles longer would no longuer guarantee that (it's the same in Unity3D).

It could be useful to have this open where the animation editor lives. As I know there are curves in there and that system works pretty well

Feature and improvement proposals for the Godot Engine are now being discussed and reviewed in a dedicated Godot Improvement Proposals (GIP) (godotengine/godot-proposals) issue tracker. The GIP tracker has a detailed issue template designed so that proposals include all the relevant information to start a productive discussion and help the community assess the validity of the proposal for the engine.
The main (godotengine/godot) tracker is now solely dedicated to bug reports and Pull Requests, enabling contributors to have a better focus on bug fixing work. Therefore, we are now closing all older feature proposals on the main issue tracker.
If you are interested in this feature proposal, please open a new proposal on the GIP tracker following the given issue template (after checking that it doesn't exist already). Be sure to reference this closed issue if it includes any relevant discussion (which you are also encouraged to summarize in the new proposal). Thanks in advance!


gui dbITerm selection

Fixes #3409
I am having some trouble getting clang-tidy to run locally, but I want to finish with this issue first.
BTW I asked some questions on the issue page if someone could take a look at those! thanks

I'm not sure why iterm selection is tied to iterm labels.  You should be able to select the iterms even if the labels aren't visible.

Selection seems odd - when I click on an instance it seems all the iterms are overlapping.  Repeated clicking cycles through all of them, even those not under the cursor

Now the ITerms are selectable depending on their Instances.
My logic for checking overlap of rectangles was wrong. It should work fine now.
I tested this change with nangate45 gcd. For the VSS and VDD ITerms, the placement of the labels doesn't seem to align completely with where you can select the ITerm. I think the text may have been translated too far.


Fix the device spec file creation in rdma exclusive mode

when using exclusive mode in RDMA if we restart the device plugin it will find the right rdma device if the device is allocated.
this change makes the file creation when we get a new allocation and not in the device plugin initialization

Hi @e0ne @ykulazhenkov @rollandf @zeeke can you please take a look on this fix please?

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

8 of 12 (66.67%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 74.647%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/resources/pool_stub.go
0
1
0.0%

pkg/resources/server.go
2
5
40.0%

Totals

Change from base Build<PHONE_NUMBER>5:
0.02%

Covered Lines:
2114

Relevant Lines:
2832

💛  - Coveralls


Opens 404 Page

Opens 404 page when running repo on a repository that hasn't push current branch to origin.

Navigate to local Git repository in the terminal
Create a new test branch git checkout -b my-test-branch
Run repo
Observe

Expected: Should open Github on branch
Actual: Opens error 404 page

Resolved


Cargo audit findings

cargo audit is complaining about the following dependencies:

atty v0.2.14
webpki v0.22.0
webpki v0.21.4
rustls v0.100.0

None of these seem super critical to fix: either DoS (we have a lot of DoS potential vectors in our own code) and the atty exploit only works on windows. Let's still try to get rid of them, but we have the time to coordinate with e.g. the ongoing project to update the rust-bitcoin dependency (#2667) which will likely unblock newer electrum-client versions.

Closing in favor of #3049 since most items here were fixed.


[Enchancement] Adding TTA mode

First of all thanks very much for this Excellent Fast program of waifu2x concept
anyway, i would like to suggest adding TTA mode to clean up artifacts of original image AS included in waifu2x-caffe
i tested out your program on very bad JPEG full of artifacts , but the results wasn't cleaned up properly even while setting denoise level on 3  although caffe actually cleaned up everything and produced such an excellent upscaled image but with more time (5 minutes) on the other hand
I hope your program succeed in every result from now on
My Best Regards

tta mode implemented https://github.com/nihui/waifu2x-ncnn-vulkan/commit/6651aa5c8754066c149f0058192ebdc20217cab1


Error when flashing initial .yaml to Wemos D1 mini

I am fairly new when it comes to ESPHome. I have been using a bed scale that I flashed using arduino but it hasn't been very reliable and I wanted to try it with ESPHome. I changed the info in the .yaml that I know but, I guess I don't know what else to change. Below is the errors I get. Any help I can get would be greatly appreciated.
`INFO ESPHome 2024.5.0
INFO Reading configuration /config/esphome/bed-scale.yaml...
INFO Generating C++ source...
INFO Compiling app...
Processing smartscale (board: d1_mini; framework: arduino; platform<EMAIL_ADDRESS>HARDWARE: ESP8266 80MHz, 80KB RAM, 4MB Flash
Dependency Graph
|-- ESP8266WiFi @ 1.0
|-- ESP8266mDNS @ 1.2
Compiling .pioenvs/smartscale/src/main.cpp.o
Compiling .pioenvs/smartscale/lib67b/ESP8266WiFi/ESP8266WiFi.cpp.o
Compiling .pioenvs/smartscale/lib67b/ESP8266WiFi/ESP8266WiFiAP.cpp.o
src/main.cpp:37:36: error: 'floatGPIO' was not declared in this scope
37 | globals::RestoringGlobalsComponent auto_tare_difference;
|                                    ^~~~~~~~~
src/main.cpp:37:45: error: template argument 1 is invalid
37 | globals::RestoringGlobalsComponent auto_tare_difference;
|                                             ^
/config/esphome/bed-scale.yaml: In function 'void setup()':
/config/esphome/bed-scale.yaml:146:65: error: 'floatGPIO' was not declared in this scope
146 |     name: "Smart Scale HX711 Value"
|                                                                 ^
/config/esphome/bed-scale.yaml:146:74: error: template argument 1 is invalid
146 |     name: "Smart Scale HX711 Value"
|                                                                          ^
/config/esphome/bed-scale.yaml:147:25: error: request for member 'set_component_source' in ' auto_tare_difference', which is of non-class type 'int'
147 |     internal: False
|                         ^
/config/esphome/bed-scale.yaml:149:25: error: request for member 'set_name_hash' in ' auto_tare_difference', which is of non-class type 'int'
149 |       # apply auto_tare difference
|                         ^~~~~~~~~~
/config/esphome/bed-scale.yaml: In lambda function:
/config/esphome/bed-scale.yaml:61:29: error: request for member 'value' in '* auto_tare_difference', which is of non-class type 'int'
61 |           id(auto_tare_difference) = id(initial_zero) - id(smart_scale_hx711_value_raw).state;
|                             ^~~~~
/config/esphome/bed-scale.yaml: In lambda function:
/config/esphome/bed-scale.yaml:91:36: error: request for member 'value' in '* auto_tare_difference', which is of non-class type 'int'
91 |       return id(auto_tare_difference);
|                                    ^~~
/config/esphome/bed-scale.yaml: In lambda function:
/config/esphome/bed-scale.yaml:132:98: error: request for member 'value' in '* auto_tare_difference', which is of non-class type 'int'
132 |                     - lambda: 'return id(smart_scale_hx711_value_raw).state < (id(initial_zero) - id(auto_tare_difference));'
|                                                                                ^~~~~
/config/esphome/bed-scale.yaml: In lambda function:
/config/esphome/bed-scale.yaml:136:29: error: request for member 'value' in '* auto_tare_difference', which is of non-class type 'int'
136 |                         id(auto_tare_difference) += 10;
|                             ^~~~~
/config/esphome/bed-scale.yaml: In lambda function:
/config/esphome/bed-scale.yaml:140:29: error: request for member 'value' in '* auto_tare_difference', which is of non-class type 'int'
140 |                         id(auto_tare_difference) -= 10;
|                             ^~~~~
/config/esphome/bed-scale.yaml: In lambda function:
/config/esphome/bed-scale.yaml:150:40: error: request for member 'value' in '* auto_tare_difference', which is of non-class type 'int'
150 |       - lambda: 'return x + id(auto_tare_difference);'
|                                        ^~~~~
In file included from src/esphome/components/api/api_connection.h:7,
from src/esphome.h:3,
from src/main.cpp:3:
src/esphome/core/application.h: In instantiation of 'C* esphome::Application::register_component(C*) [with C = int]':
/config/esphome/bed-scale.yaml:148:46:   required from here
src/esphome/core/application.h:183:50: error: static assertion failed: Only Component subclasses can be registered
183 |     static_assert(std::is_base_of<Component, C>::value, "Only Component subclasses can be registered");
|                                                  ^~~~~
Compiling .pioenvs/smartscale/lib67b/ESP8266WiFi/ESP8266WiFiGeneric.cpp.o
*** [.pioenvs/smartscale/src/main.cpp.o] Error 1
========================== [FAILED] Took 3.62 seconds ==========================
`

Could be that you are compiling for the wrong board type.
Did you change the platform configuration to match your board?
Can you post your config?

I actually just found the issue, I had some extra text in the code somehow, see below:
- id: auto_tare_difference     type: floatGPIO     restore_value: yes     initial_value: '0'
Not sure how GPIO got in there next to float but after removing it, it of course works fine.
Thanks for responding.

Could be that you are compiling for the wrong board type. Did you change the platform configuration to match your board? Can you post your config?

Okay well, now I was able to sucessfully flash it but now it stays offline. Below is my config.
`## Node configuration ##
esphome:
name: bed
platform: ESP8266
board: d1_mini
globals:

id: initial_zero
type: float
restore_value: yes
NOTE: make sure to align this value to the one used in "calibrate_linear" below!
initial_value: '-481989'

id: auto_tare_enabled
type: bool
restore_value: yes
initial_value: 'true'

id: auto_tare_difference
type: float
restore_value: yes
initial_value: '0'

wifi:
fast_connect: False  # needed for hidden SSID
networks:
- ssid: xxxx
bssid: 'xxxx'
password: xxxx
hidden: false
#manual_ip:
static_ip: <IP_ADDRESS>
gateway: <IP_ADDRESS>
subnet: <IP_ADDRESS>
api:
password: "qgPSetaocBbDSIaTjgKOY8d7os/iG7Z58r86rL/JWcI="
Enable logging
logger:
level: ERROR
ota:
password: "2168c2d5c2d16e65d12c415f69963752"
status_led:
pin:
number: GPIO14
inverted: True
button:
Button used to initiate a manual tare

platform: template
id: smart_scale_manual_tare_action_switch
name: "Smart Scale Manual Tare Action"
icon: mdi:scale-balance
on_press:

lambda: |-
id(auto_tare_difference) = id(initial_zero) - id(smart_scale_hx711_value_raw).state;

switch:
Switch to enable/disable the auto tare feature

platform: template
id: smart_scale_continuous_tare_enabled
name: "Smart Scale Continuous Tare Enabled"
lambda: |-
return id(auto_tare_enabled);
turn_on_action:

lambda: |-
id(auto_tare_enabled) = true;
turn_off_action:
lambda: |-
id(auto_tare_enabled) = false;

Sensor Configuration
sensor:
template sensors from global variables

platform: template
id: smart_scale_initial_zero
name: "Smart Scale Initial Zero"
lambda: |-
return id(initial_zero);
update_interval: 1s

platform: template
id: smart_scale_auto_tare_difference
name: "Smart Scale Auto Tare Difference"
lambda: |-
return id(auto_tare_difference);
update_interval: 1s

sensors imported from home assistant

platform: homeassistant
id: homeassistant_initial_zero
entity_id: input_number.smart_scale_initial_zero
on_value:
then:
- lambda: |-
id(initial_zero) = x;

RAW Scale input

platform: hx711
id: smart_scale_hx711_value_raw
internal: True
dout_pin: GPIO2
clk_pin: GPIO3
gain: 128
update_interval: 0.2s
filters:

quantile:
window_size: 10
send_every: 1
send_first_at: 1
quantile: .9
on_value:
then:

sensor.template.publish:
id: smart_scale_hx711_value
state: !lambda 'return id(smart_scale_hx711_value_raw).state;'
if:
condition:
and:
- lambda: 'return id(auto_tare_enabled);'
# current smart scale value is below approx. 10KG (raw value -275743) aka nobody is standing on the scale
- lambda: 'return id(smart_scale_hx711_value).state < 10.0;'
then:
- if:
condition:
# current raw scale value is below expected zero value
- lambda: 'return id(smart_scale_hx711_value_raw).state < (id(initial_zero) - id(auto_tare_difference));'
then:
# INcrease Auto-Tare offset to slowly align real zero value with expected zero value
- lambda: |-
id(auto_tare_difference) += 10;
else:
# DEcrease Auto-Tare offset to slowly align real zero value with expected zero value
- lambda: |-
id(auto_tare_difference) -= 10;

Mapped value to KG

platform: template
id: smart_scale_hx711_value
name: "Smart Scale HX711 Value"
internal: False
filters:
apply auto_tare difference

lambda: 'return x + id(auto_tare_difference);'

apply rough calibration

calibrate_linear:
retrieve these values by evaluating the raw values with loads of known mass.
note that a bigger difference between measurements usually results in higher resolution,
so measure 0 Kg and the highest known mass you have (like f.ex. your own weight, measured by a normal scale with good accuracy)

-481989 -> 0
1339163 -> 88.3

map values below 0.1 to 0 (to decrease value changes due to random fluctuation)

lambda: |-
if (x <= 0.1) {
return 0.0;
} else {
return x;
}

unit_of_measurement: kg
accuracy_decimals: 2
the sensor will automatically update through the 'sensor.template.publish' call
update_interval: never`

Ok, well I was able to successfully flash it but it now stays offline. I've tried changing the WiFi info but no luck. Below is the config:
`## Node configuration ##
esphome:
name: bed
platform: ESP8266
board: d1_mini
globals:

id: initial_zero
type: float
restore_value: yes
NOTE: make sure to align this value to the one used in "calibrate_linear" below!
initial_value: '-481989'

id: auto_tare_enabled
type: bool
restore_value: yes
initial_value: 'true'

id: auto_tare_difference
type: float
restore_value: yes
initial_value: '0'

wifi:
fast_connect: False  # needed for hidden SSID
networks:
- ssid: -mywifi-
bssid: 'xx:xx:xx:00:d0:71'
password: xxxx
hidden: false
#manual_ip:
static_ip: <IP_ADDRESS>
gateway: <IP_ADDRESS>
subnet: <IP_ADDRESS>
api:
password: "qgPSetaocBbDSIaTjgKOY8d7os/iG7Z58r86rL/JWcI="
Enable logging
logger:
level: ERROR
ota:
password: "2168c2d5c2d16e65d12c415f69963752"
status_led:
pin:
number: GPIO14
inverted: True
button:
Button used to initiate a manual tare

platform: template
id: smart_scale_manual_tare_action_switch
name: "Smart Scale Manual Tare Action"
icon: mdi:scale-balance
on_press:

lambda: |-
id(auto_tare_difference) = id(initial_zero) - id(smart_scale_hx711_value_raw).state;

switch:
Switch to enable/disable the auto tare feature

platform: template
id: smart_scale_continuous_tare_enabled
name: "Smart Scale Continuous Tare Enabled"
lambda: |-
return id(auto_tare_enabled);
turn_on_action:

lambda: |-
id(auto_tare_enabled) = true;
turn_off_action:
lambda: |-
id(auto_tare_enabled) = false;

Sensor Configuration
sensor:
template sensors from global variables

platform: template
id: smart_scale_initial_zero
name: "Smart Scale Initial Zero"
lambda: |-
return id(initial_zero);
update_interval: 1s

platform: template
id: smart_scale_auto_tare_difference
name: "Smart Scale Auto Tare Difference"
lambda: |-
return id(auto_tare_difference);
update_interval: 1s

sensors imported from home assistant

platform: homeassistant
id: homeassistant_initial_zero
entity_id: input_number.smart_scale_initial_zero
on_value:
then:
- lambda: |-
id(initial_zero) = x;

RAW Scale input

platform: hx711
id: smart_scale_hx711_value_raw
internal: True
dout_pin: GPIO2
clk_pin: GPIO3
gain: 128
update_interval: 0.2s
filters:

quantile:
window_size: 10
send_every: 1
send_first_at: 1
quantile: .9
on_value:
then:

sensor.template.publish:
id: smart_scale_hx711_value
state: !lambda 'return id(smart_scale_hx711_value_raw).state;'
if:
condition:
and:
- lambda: 'return id(auto_tare_enabled);'
# current smart scale value is below approx. 10KG (raw value -275743) aka nobody is standing on the scale
- lambda: 'return id(smart_scale_hx711_value).state < 10.0;'
then:
- if:
condition:
# current raw scale value is below expected zero value
- lambda: 'return id(smart_scale_hx711_value_raw).state < (id(initial_zero) - id(auto_tare_difference));'
then:
# INcrease Auto-Tare offset to slowly align real zero value with expected zero value
- lambda: |-
id(auto_tare_difference) += 10;
else:
# DEcrease Auto-Tare offset to slowly align real zero value with expected zero value
- lambda: |-
id(auto_tare_difference) -= 10;

Mapped value to KG

platform: template
id: smart_scale_hx711_value
name: "Smart Scale HX711 Value"
internal: False
filters:
apply auto_tare difference

lambda: 'return x + id(auto_tare_difference);'

apply rough calibration

calibrate_linear:
retrieve these values by evaluating the raw values with loads of known mass.
note that a bigger difference between measurements usually results in higher resolution,
so measure 0 Kg and the highest known mass you have (like f.ex. your own weight, measured by a normal scale with good accuracy)

-481989 -> 0
1339163 -> 88.3

map values below 0.1 to 0 (to decrease value changes due to random fluctuation)

lambda: |-
if (x <= 0.1) {
return 0.0;
} else {
return x;
}

unit_of_measurement: kg
accuracy_decimals: 2
the sensor will automatically update through the 'sensor.template.publish' call
update_interval: never`

I'm not sure if all the other info such as "bssid" and whatever else is needed or not but I changed it to the following format and it goes online now.
  ssid: !secret wifi_ssid
  password: !secret wifi_password```

Sorry, one more thing, I tried exposing the raw sensor to home assistant by changing True to False but I am not seeing the sensor anywhere in home assistant. Do you know where I should see it?

It should be listed in:
Settings -> Devices & Services -> Entities (Tab) -> Search for "smart scale"

It should be listed in: Settings -> Devices & Services -> Entities (Tab) -> Search for "smart scale"

Thank you again for replying, but that's where I was looking, it's just not there. I've changed it to "False", saved and flashed it and tried restarting HA but it still doesn't show up. I of course could be doing something else wrong :)

Hmm, indeed I also cannot see it. Seems like something changed on the ESPHome side since this definitely worked at some point.
I have updated the configuration to include a diagnostic sensor that will show the initial raw sensor value of the HX711 chip. This value will only update a single time when the ESP boots up. If you want to get a new value while the ESP is still on you can trigger an update using the "manual tare" button action. Otherwise simply reboot the ESP to get a new value.
See #27
Let me know if that helps.

Okay so, I wasn't able to get that sensor to show up, so I just created another one (shown below) and had it return the raw value. After that, it showed up and I was able to get everything working correctly now. Hopefully it was the correct return value I was looking for, it does seem to work good now so I am assuming it was. Thanks again for your help.
- platform: template
    id: smart_scale_value_raw2
    name: "Smart Scale Value Raw2"
    lambda: |-
      return (int((id(smart_scale_hx711_value_raw).state)));
    update_interval: 0.2s

Hmm, indeed I also cannot see it. Seems like something changed on the ESPHome side since this definitely worked at some point.
I have updated the configuration to include a diagnostic sensor that will show the initial raw sensor value of the HX711 chip. This value will only update a single time when the ESP boots up. If you want to get a new value while the ESP is still on you can trigger an update using the "manual tare" button action. Otherwise simply reboot the ESP to get a new value.
See #27
Let me know if that helps.

Lol, I didn't see your reply until after sending my last one. Thank you for looking into it and I will add the new sensor you created and if I have any issues, I will try what you said.
Thanks!

@ryknow27 No worries :smile:
I would recommend to use the solution I created in #27 or at least to remove the sensor you created after you have finished the calibration, since updating this sensor every 0.2 seconds will cause a lot of network traffic that is not necessary and might even cause problems for other devices on the network.
Good to hear you found a solution and that it works well :nerd_face:

@markusressel Sorry to bother you again but do you know if the lovelace card still works? I've tried installing it a few time but I keep getting "Custom element doesn't exist: multiple-entity-row." I have installed per the instructions for the card but haven't had any luck. I was about to bring up an issue on that github but thought I would ask here first.

I am still using it, so I would assume it does. I have it installed years ago though.

Okay, I was able to get it to install but I am now getting the following:

I left out the entity: input.number.weight_markus info as I'm not sure how you created that entity. Is that the reason it wouldn't work?

Should have asked earlier as well but would you mind sharing how/where you created the entity for Markus's weight?

"input_number.weight_markus" is a custom "input number" entity defined through the home assistant configuration yaml.
See: https://www.home-assistant.io/integrations/input_number/
The value of this input number is updated through an automation that looks for the scale value to be above a certain threshold for a certain amount of time (3 seconds or something like that).
With this setup I can step on the scale at any time, wait a couple of seconds and my current weight will be saved in the history of this entity.

Regarding the error: multiple entity row requires both a main entity definition as well as a list of entities to show next to it. You seem to be missing thr main entity (the one shown on the right end, which will also dictate the behavior of the card).

Regarding the error: multiple entity row requires both a main entity definition as well as a list of entities to show next to it. You seem to be missing thr main entity (the one shown on the right end, which will also dictate the behavior of the card).

Thank you, I'll look into that!

I am closing this, since the original issue is fixed. Feel free to open another issue if anything comes up.


Mobile - Account Summary - Tabbed navigation

Figma:
https://www.figma.com/file/bZh7tOiLm6Ls9Hl4RL6qMC5X/Augur-Redesign?node-id=7245%3A0
Notes:

Horizontal scrolling tabbed navigation
Each 'card' from the desktop version is it's tab on mobile
Note: 'Notifications' displays a red dot when there are any new notifications

is there no terms and conditions footer on this page for mobile?

@cillianhunter0 please rvw

Couple of padding issues and note on the styling underline of the active page. Details:

Red dot for notification doesn't seem to be appearing either, but not sure if that's because I've already 'viewed' the notification?

the red dot hasn't been added. thought that would go in with the mobile notification view tickets.

moved the red dot for new notifications here https://github.com/AugurProject/augur/issues/1510


Fix buffer overflow handling for string_body and mutable_body

issue #553

It needs to be all squashed down into one commit

It needs to be all squashed down into one commit

Ouch.
Closing this pull request?
New branch from master again.
All changes.
One commit.
New pull request?

What? No! You can squash it from the command line. Try
git remote add upstream git@github.com:vinniefalco/Beast.git
git rebase -i upstream/master

or you can use
git reset 1e8be328
git add -A
git commit --amend

When you push to your remote use
git push -f

Do i need
git add -A
?
There are no new files to commit.
But i have new files in workspace, e.g. .project

I don't know what .project is. If you used git reset you should have modified files in you working directory. Try resetting back to your original branch and then do the interactive rebase  (git rebase -i)

See https://github.com/vinniefalco/Beast/commits/op

WTH?! git push did close the pull request?!

No worries, take your time and have patience, this will work.


Data from the Telegram node is overwritten (Taking a picture and sending it via telegram)

Hello!
Describe the Issue
I try to integrate node-red-contrib-telegrambot with node-red-contrib-hikvision-ultimate to send a image from hikvision camera to a telegram user.
my goals are:

Send an image from a closed circuit camera to a fixed telegram subscriber when an event occurs
Give the possibility to a telegram user to request an image with the command /getImage from a closed circuit camera

point 1  ✔
I was able to do it using the "picture node" of Hikvision-Ultimate and setting after the picture node a function:
msg.payload = {}

msg.payload.chatId = XXXXXXXX  //TelegramUserId
msg.payload.content = msg.forEmail;
msg.payload.type = 'photo';
msg.payload.caption = "l'immagine che ho acquisito"

return msg;

point 2  ❌
Here i've a problem, because the picture node overvrite all the content of the msg.
If a user writes to the bot, I have to save the chatID to reply to the same user (my bot reply to many users).
I save the payload of telegram node to a variable "msg.backup", but nothing remains after the picture node.
Is it possible that the image node keeps the contents of the previous msg?
Hikvision-Ultimate Version

1.0.62

Are you running node-red behind homematic, docker or anything similar?

Node-Red running alone in Ubuntu 20.04.4 LTS linux-virtual-machine on vmware
Node v: 16.14.2

Thanks

Ciao Ale
Long story short: you need that the input messages that goes to the hikvision picture node, is passed through and sent to the output, toghether with the picture?

Ciao @Supergiovane,
Yes, in short:
If you can keep the input messages that don't interfere with the node it's better.
Otherwise I have implemented the join node between the before and after the picture node.

Bravo, ti avrei suggerito la stessa cosa. Domani ci lavoro.

<EMAIL_ADDRESS>è nelle palette, con la modifica che hai richiesto. Guarda il changelog per sapere dove viene messo il messaggio originale.

Scusa se scrivo qui.
Visto che hai esperienza con hikvision, sei disponibile a sentirci brevemente?
Non mi è chiaro come attivare il line crossing.


Upgrade vulnerable lodash (again)

It seems lodash again has a severe vulnerability before 4.17.13
More info about the vulnerability: https://github.com/lodash/lodash/pull/4336
Current version of lodash in package.lock: 4.17.11 (https://github.com/oncletom/crx/blob/master/package-lock.json#L1712)
A previous vulnerability fix was done here: https://github.com/oncletom/crx/issues/89, I guess this one can be done the same way.

Hey @th0rgall, thank you for signaling this dependency issue.
The only not-up-to-date dependency is a dev one, github-changes.
<EMAIL_ADDRESS>/Users/oncletom/workspace/crx
├─┬<EMAIL_ADDRESS>│ └─┬<EMAIL_ADDRESS>│   └──<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>│ ├─┬<EMAIL_ADDRESS>│ │ └──<EMAIL_ADDRESS>│ ├──<EMAIL_ADDRESS>│ └─┬<EMAIL_ADDRESS>│   └──<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>│ └──<EMAIL_ADDRESS>└─┬<EMAIL_ADDRESS>  └─┬<EMAIL_ADDRESS>    ├─┬<EMAIL_ADDRESS>    │ └──<EMAIL_ADDRESS>deduped
    ├─┬<EMAIL_ADDRESS>    │ └──<EMAIL_ADDRESS>deduped
    └─┬<EMAIL_ADDRESS>      └──<EMAIL_ADDRESS>deduped

The new patch release should be automatically published online in a few minutes.


Encryption performance in Matter on ESP chips

Turning my BLE Mesh bulb on/off with Matter is taking 5.1 seconds. Turning the same bulb on/off with nRF Mesh app is so fast I can't see a delay. The delay is in the Matter code, not the BLE code.  I am using C3, is this how slow encryption is on the C3, 5.1s?  ESP32 is 3.2 seconds for same code.
How much difference does adding ATECC608B in make? I don't have an ESP32-WROOM-32SE. I have some ATECC608B maybe I can wire one in.  Is there a similar C3 based module in the works?  The IDF menuconfig for ATECC608B only appears to support TLS and Matter is not using TLS.  So new work would need to be done in IDF to support ATECC608B in Matter.
There is a 3.1 second gap between these messages: (1.9 seconds on ESP32)
I (377033) chip[SC]: Received Sigma3 msg
E (377103) chip[SC]: The device does not support GetClock_RealTimeMS() API: 6c.  Falling back to Last Known Good UTC Time
I (380203) chip[IN]: Prepared unauthenticated message 0x3fc97f24 to 0x0000000000000000 (0)  of type 0x40 and protocolId (0, 0) on exchange 2611r with MessageCounter:9712725.
I (380213) chip[IN]: Sending unauthenticated msg 0x3fc97f24 with MessageCounter:9712725 to 0x0000000000000000 at monotonic time:<PHONE_NUMBER>05CD27 msec

And a 1.37 second gap between these two:  (0.94 seconds on ESP32)
I (375563) chip[SC]: CASE matched destination ID: fabricIndex 1, NodeID 0x0000000000007283
I (376933) chip[IN]: Prepared unauthenticated message 0x3fc97f24 to 0x0000000000000000 (0)  of type 0x31 and protocolId (0, 0) o

pause.log

I wired my ATECC608B into a WROOM but it doesn't want to work. Maybe it is bad, I have not used it in five years so I ordered some new ones.  I tried to get examples/peripherals/secure_element/atecc608_ecdsa working. If I'm reading things correctly this chip support works with MBED TLS so Matter will pick it up automatically once it is working. If you can test on your end before my new parts arrive that would be useful.

I set my ESP32 to use 240Mhz clock.  Now it runs in 2.6 seconds. This really needs to be under one second to make consumers happy. Hopefully when my ATECC608B arrives it will be enough to get down to one second.
I still think one second is still ridiculously slow for an IOT device. The encryption being used in Matter is excessive.

How do I get the idf to build a release version of CHIP in esp-matter?

This is not as dire as I though it was. It is accurate for the first interaction with the device, if you keep the session open to the device subsequent interactions are faster.
Please adjust the documentation to reflect using chip-tool in interactive mode:
./chip-tool interactive start
Also explain that first time session is made it takes about 5 seconds, then if you keep the session open subsequent command run in 1.1 to 1.5 seconds. This needs to be explained to ensure customers come to the right conclusion on ESP Matter performance.

Chip tool prints timestamps on its log messages, you can just read it off from the screen.
In interactive mode, to toggle bridged BLE light:
ESP32 240Mhz -- 1.14 seconds
ESP32C3 -- 1.52 seconds
No bridge
ESP32C3 -- 1.2 seconds
These may not be totally accurate, I'm not sure what chip-tool is doing for 0.8 seconds before it sends the first packet. This performance is a lot better, but I would still like to see it faster. Consumers are not going to be happy until it is under one second.

I see, for multiple attempts, the time required is around 0.3 sec for the light example on ESP32-C3 (using the same chip-tool timestamp prints)

I would not be surprised if the 1.3s I was see in the evening yesterday was 2.4Ghz saturation around me from people streaming TV. I am get 0.3 this morning when everyone has gone to work.

This is an experiment worth doing

I was getting these messages on the ESP last night, none this morning,
I (14979567) wifi:bcn_timout,ap_probe_send_start

This message is seen when STA misses the beacon. Generally, it can happen when the AP is far away or sometimes when the Wi-Fi network is crowded

I don't see any huge problem now with encryption speed. If you wanted to reduce that initial 5 seconds I suspect an ATECC608B would help.  The other bug references documenting how to properly test this.


[discussion] How to compose two onnx model in onnxscript?

Hi
My goal is to merge multiple onnx models and create a single one. It is possible in onnx via onnx.compose. But the syntax seems simpler in onnxscript. So I would like to know how to do that here. I notice that the onnx model can be converted to str by onnxscript.proto2python. But how to get the representation in onnxscript?
Thanks

cc @gramalingam @justinchuby
It this is doable, I wonder if we need to add this function into ONNX IR. It could be interesting.

IR
This is very much doable, but we are a few steps away from providing some high level apis for this.

onnxscript.proto2python should be how you get the representation in onnxscript. Could you elaborate?


Add update of generative and reranker moduleconfig

Codecov Report
Attention: Patch coverage is 94.64286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 93.92%. Comparing base (3f68082) to head (7ea2089).
Report is 142 commits behind head on main.

Files with missing lines
Patch %
Lines

weaviate/collections/classes/config.py
93.18%
3 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1376      +/-   ##
==========================================
- Coverage   94.38%   93.92%   -0.47%
==========================================
  Files         220      221       +1
  Lines       20956    21277     +321
==========================================
+ Hits        19779    19984     +205
- Misses       1177     1293     +116

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Delivery.Timestamp is "0001-01-01 00:00:00 +0000 UTC" ever time

Hello,
I  try to get date time of regarding message is provided by RabbitMQ. But the date time is not correct very time. This is bug or I missed a point on here ?

	msgs, err := ch.Consume(
		conf.GetNameOfQueue(),    // queue
		conf.GetNameOfConsumer(), // consumer
		false, // auto-ack
		false, // exclusive
		false, // no-local
		false, // no-wait
		nil,   // args
	)

	go func() {
		for d := range msgs {
			log.Info(d.Timestamp.String()) // "0001-01-01 00:00:00 +0000 UTC"
		}
	}()

We cannot tell since you haven't shared any publisher code. Wireshark can reveal what's being sent by RabbitMQ, which would be extremely valuable to have when investigating this.


Ask when leaving form

I want to merge this change because it adds confirmation when leaving unsaved changes in form.
Fixes #2284
Screenshots

Pull Request Checklist

[ ] Privileged views and APIs are guarded by proper permission checks.
[ ] All visible strings are translated with proper context.
[ ] All data-formatting is locale-aware (dates, numbers, and so on).
[ ] Database queries are optimized and the number of queries is constant.
[ ] The changes are tested.
[ ] The code is documented (docstrings, project documentation).
[ ] GraphQL schema and type definitions are up to date.

I'd make both buttons non-default and consider reversing the order of buttons so that the right-most option is not to lose data.

Like this?

I'd change the content to something more user-friendly. What do you think about these:

title - "Unsaved changes"
description - "You have unsaved changes on this page. Are you sure you want to leave without saving"?

@dominik-zeglen
I think both your version and mine can work. I think addition of info that you can lose the changes is beneficial so I would keep that.
Buttons are basically the same.
Modal title is quite long in your proposition.

I too prefer the title Unsaved Changes, short and precise :+1:


Make easy understand for ReleaseComponent fields input.

It was not friendly only with id for ReleaseComponent, instead provide
two option: one is object id, the other is resource's unique_together
fields. Both of them need to be input as a dict.
Impact endpoints include: component-groups and release-component-relationships
JIRA: PDC-905

Generally this looks good to me. I would like it if there were more error handling. It doesn't warn when extra fields are included in the dict specifying the component. It will accept the following without any error: {"id": 1, "release": "hello-1.0", "name": "bash", "global_component": "bash"} (in this case anything but id is ignored, but that is not obvious).

I admit that it was a lazy solution not causing application crash as some un-predict exception happens. There was a case in my mind, which also mentioned in your second comment, but a little different. with all fields input or at least id and its unique_together fields, but the value of id is not same as this resource id, DoesNotExist can't catch this exception.
Anyway, I will put more error handling.

Haven't rebase the code. I will do it when review pass from team.

I'm not sure if it should be even more strict and report error on any unrecognized key. It will still accepts these wrong inputs:
{"foo": "bar"}
{"iid": 1, "release": "foo"}

with message saying it can't find a release component.
This is still invalid, but will be accepted (release is ignored):
{"id": 1, "release": "foo"}

that will need more checks, thinking about it.

:+1:

Looks more elegant.

Just two questions.

Is it ok to create relationship between id:1 and id:1?
Is it ok to create relationship between id and unique together

@simozhan what relationship?

@simozhan

There is probably no point in putting a component in a relationship with itself. But I don!t know if it needs a validation.
Yes, those are just two ways of specifying which component to use, they should be interchangeable.


New interface

Example:
params = get_conf_params("../examples/GaN-SNAP-LAMMPS/")

# Get DFT data
dft_train_data, dft_val_data = generate_data("dft", params)

# Get reference data
ref_train_data, ref_val_data = generate_data("ref", params)

# Get potential learning problem (e.g. A β = b)
snap_prob = learning_problem(dft_train_data, ref_train_data, params)

# Solve potential learning problem (e.g. β = A \ b)
snap = solve(snap_prob, params)

# Validate potentials, forces, and stresses
validate(snap, dft_val_data - ref_val_data)

Configuration file
[dft]
dft_model LennardJones
ε 0.643
σ 2.390

[reference]
reference_model ZBL
ε0 55.26349406
e -1.602176634e-19
zi 31.0
zj 7.0
r_inner 1.0
r_outer 3.5

[learning]
potential SNAP_LAMMPS
fit_forces false
no_atoms_per_type 96 96
no_atoms_per_conf 192
no_atomic_conf 61
no_train_atomic_conf 48
rcut 3.5
ntypes 2
twojmax 6

[solver]
solver BBO

I think is better to unify the potential learning problem and the potential.
This is the new interface:
params = get_conf_params("../examples/GaN-SNAP-LAMMPS/")

# Get DFT data
dft_train_data, dft_val_data = generate_data("dft", params)

# Get reference data
ref_train_data, ref_val_data = generate_data("ref", params)

# Get potential learning problem (e.g. A β = b)
snap = learning_problem(dft_train_data, ref_train_data, params)

# Solve potential learning problem (e.g. β = A \ b)
learn(snap, params)

# Validate potentials, forces, and stresses
validate(snap, dft_val_data - ref_val_data, params)


Main

Added 3 examples:
subscriber
publisher and subscriber
service: addtwoints

@Acuadros95
Can this PR be approved?

This is awaiting approval,
Simple button click!

Closing as some of the review comments were not resolved.


Selected Date is wrong, 1 hour behind so selecting 9th September actually gives 8th September 23:00

https://jsfiddle.net/ce23h89r/
Selecting a date will cause the date picker to show the previous date and a time of 23:00 rather than the selected date.
Your Environment

flatpickr version used: 4.6.2
Browser name and version: Chrome 76.0.3809.132 and IE 11.295.18362.0
OS and version:  Windows 10 Pro 18362.295

We noticed this today as well. Very strange! Dates picked using flatpickr have the wrong timezone. In my case, I'm seeing GMT-0800 (Pacific Standard Time), but it's GMT-0700 (Pacific Daylight Time) here (and new Date gives dates in GMT-0700). I only noticed this today, but I am certain it wasn't doing this last week...

Appears to be a problem only with dateFormat: 'Z' option. I wonder if it fixes itself when not within the summer time timezone change


Make Python 3 compatible: "except" notation

Thanks for your PL, it's been merged and the module will get updated shortly.


[CssSelectorComplexBridge] Load article from page using provided cookie

Describe the bug
When the option "Load article from page" is selected, the bridge does not use provided cookie to get article content.
To Reproduce
Steps to reproduce the behavior:

Register in a website that requires login at every page. For example torrent tracker zamunda.net
Set website url. In this case: https://zamunda.net/bananas
Copy cookie data from browser request headers
Set article entry selector. In this case: table.responsivetable:nth-child(1) > tbody:nth-child(1) > tr > td:nth-child(2)
Set link selector. In this case: a.notranslate
Select "Load article from page"
Set "Selector to select article element" to: html

Expected behavior
Instead of returning the articles page, for every link found, the bridge returns the website's login page. As if you're not authorized.
Additional context
I apologize in advance if for some reason is intended that way and it's not a bug.

@LarsStegman @ORelio

I don't maintain this bridge but I think #3870 should be enough to fix this.
I'd suggest having @LarsStegman review the PR, I did not test the code.


Unit Tests for improved test coverage

Will it be helpful if I write some unit tests for certain modules to improve overall tested code coverage.

@mfarid sure! You can start with small PR and few tests!

@artem-zinnatullin Thanks a lot for quick response, I will start with a small PR with few tests, just as you suggested.

@mfarid great! Just curious with what class do you want to start? :smile:

@artem-zinnatullin I have not identified any specific class as of now, if you would like me to target something specific, please let me know. Otherwise, once I start with some tests I will update this ticket with the same.

I have a solution! We have tests coverage which seems to be broken for last
month because flucking Gradle things, let me fix test coverage measurement
and then we'll see what classes need more tests, okay?
On Mon, Dec 14, 2015, 07:49 Mohd Farid<EMAIL_ADDRESS>wrote:

@artem-zinnatullin https://github.com/artem-zinnatullin I have not
identified any specific class as of now, if you would like me to target
something specific, please let me know. Otherwise, once I start with some
tests I will update this ticket with the same.
—
Reply to this email directly or view it on GitHub
https://github.com/pushtorefresh/storio/issues/571#issuecomment-164342263
.

--
@artem_zin

Sounds great, thanks.

@mfarid yay! You can now pull the repository and run ci.sh and then find Jacoco reports about test coverage in module/build/reports/ for each module!

Thanks @artem-zinnatullin I appreciate it.
Ii will start with a small module and send out a PR to you soon.

Great, thanks @mfarid! You can start even with one or two tests so code review will be fast :)

Looks like this one can be closed :)


ionic serve -l is broken

System Info
Cordova CLI: 6.4.0
Ionic Framework Version: 2.0.0-rc.2
Ionic CLI Version: 2.1.8
Ionic App Lib Version: 2.1.4
Ionic App Scripts Version: 0.0.43
ios-deploy version: Not installed
ios-sim version: 5.0.11
OS: OS X El Capitan
Node Version: v7.1.0
Xcode version: Xcode 8.0 Build version 8A218a
When running ionic serve --lab from the terminal this is the output:

ionic-hello-world@ ionic:serve /Users/aaronhernandez/Documents/IonicProjects/simpletabtest
ionic-app-scripts serve "--lab"

[18:16:43]  ionic-app-scripts 0.0.43
[18:16:44]  watch started ...
[18:16:44]  build dev started ...
[18:16:44]  clean started ...
[18:16:44]  clean finished in 3 ms
[18:16:44]  copy started ...
[18:16:44]  transpile started ...
[18:16:45]  transpile finished in 1.57 s
[18:16:45]  webpack started ...
[18:16:45]  copy finished in 1.67 s
[18:16:48]  webpack finished in 3.09 s
[18:16:48]  sass started ...
[18:16:49]  sass finished in 811 ms
[18:16:49]  build dev finished in 5.50 s
[18:16:49]  watch ready in 5.53 s
[18:16:49]  dev server running: http://localhost:8100/
When the browser launches it tries to go here:
http://localhost:8100//__ion-dev-server/ionic_lab.html
Displayed on the page is:
Cannot GET //__ion-dev-server/ionic_lab.html
Not sure what's happening here. I can still emulate either platform and deploy to devices fine but the lab just simply doesn't work. As an alternative I can launch the lab from the "Ionic Lab" desktop app and it works fine.

Same issue. My system info:
Cordova CLI: 6.4.0
Ionic Framework Version: 2.0.0-rc.2
Ionic CLI Version: 2.1.8
Ionic App Lib Version: 2.1.4
Ionic App Scripts Version: 0.0.43
ios-deploy version: 1.9.0
ios-sim version: 5.0.11
OS: OS X El Capitan
Node Version: v6.9.1
Xcode version: Xcode 8.1 Build version 8B62

This might help...
https://forum.ionicframework.com/t/ionic-serve-lab-dont-work-in-rc2/69862

Please verify your package.json
https://github.com/driftyco/ionic-app-scripts
"scripts": {
"build": "ionic-app-scripts build",
"watch": "ionic-app-scripts watch"
},
Remove "ionic-build"

package.json and remove "ionic:serve"
"scripts": { "ionic:build": "ionic-app-scripts build", "ionic:serve": "ionic-app-scripts serve" },
Remove "ionic:serve"
"scripts": { "ionic:build": "ionic-app-scripts build" },


Updating notes for rc.2

DO NOT MERGE UNTIL RC.2 RELEASE
Description

Update notes to rc.2
Keeping a single link for a clearer CTA
Links updated to the context of the note (same page but in the rc version)

Issue reference
Closes #1029

https://docs.dapr.io/getting-started/install-dapr-kubernetes/ will need the update as well


webostv often sees TV as off

Home Assistant release with the issue:
0.103.6
Last working Home Assistant release (if known):
unknown (my TV is new)
Operating environment (Hass.io/Docker/Windows/etc.):
ESXi Host
CentOS 7
Docker
Integration:
webostv
Description of problem:
I use the webostv media player integration to automate power on/off my amp and switch inputs on my amp but the integrations often sees the TV as off but is is playing.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
  - platform: webostv
    name: LG TV
    host: <IP_ADDRESS>

State tracking for webostv should be significantly improved in 0.104


(doc): suggest change the doc in plugin settings

          Actually, I found that if I get rid of "Test Page" so that the name is just "Tangerine", it works! I'd just suggest changing the documentation to specify you need to put the entire page name in the field, not just a word.

Originally posted by @MentalBrain in https://github.com/YU000jp/logseq-plugin-panel-coloring/issues/15#issuecomment-1595169302

https://github.com/YU000jp/logseq-plugin-panel-coloring/commit/f8f3a4c3cab8d501cd15706049410866f15e52f3


Using postman to test endpoints

Hey,
i tried to create endpoints with arguments :
the http request in the request look like this :
Request URL: http://localhost:8000/wildcard/deleteEducationObject/[123]
i'm trying to use PostMan to test the requests, what documentation should i check to see how url are constructed ?
thanks again

Hi @worms19,
You can test by using the Wildcard client:
// Node.js

// The Wildcard client works in Node.js as welll
const {endpoints} = require('@wildcard-api/client');

[testDelete, test2].forEach(test => test());

async function testDelete() {
  const id = 123;
  await endpoints.addEducationObject({id, title: "Learn about ..."});
  let educationObjects = await endpoints.getAllEducationObjects();
  assert(educationObjects.some(obj => obj.id===id));
  await endpoints.deleteEducationObject(id);
  educationObjects = await endpoints.getAllEducationObjects();
  assert(!educationObjects.some(obj => obj.id===id));
}

function test2() {
  /* another test */
}

Does that work for you?
Wildcard aims to fully abstract away anything related to HTTP and serialization; you shouldn't have to know about these things. If you're curious how things work I'm happy to elaborate :-)
Rom

Feel free to re-open if this is still an issue and/or if you have questions :-).


Vega 64 - Voltage not applying after PC restart

Checklist

[X] The problem is not listed in the hardware support matrix as a known limitation
[X] I've included a debug snapshot if the issue is related to hardware configuration

Bug description
Hello,
There's an issue on my machine with changing the voltage value, if I change the voltage and I restart the pc the voltage value is gonna be reverted to the default one 1.2v, the only way to fix this temporarely is to do these steps:
1 - Revert all the values to default
2 - Restart the pc
3 - Apply the new voltage value
In this case the new GPU voltage value is gonna be applied, but the moment I need to restart the pc then the same problem will arise.

LACT-sysfs-snapshot-20240606-223901.tar.gz
I've attached a screenshot and the debug snapshot as well,
Thank you
System info
- LACT version: lact-libadwaita 0.5.4-2
- GPU model: AMD Radeon RX Vega 64
- Kernel version: Linux PC-archlinux 6.9.3-arch1-1 #1 SMP PREEMPT_DYNAMIC Fri, 31 May 2024 15:14:45 +0000 x86_64 GNU/Linux
- Distribution: Arch Linux

After the system boots and the voltage value is not applied, can you try restarting the service (sudo systemctl restart lactd) - does it change anything?
I'm also unable to reproduce this on a Vega 56.

I tried to issue the command but it doesn't change the behavior, the voltage is still locked at 1.2v even though I've set 1.1v in the app.
This is a screenshot right after the pc booted,

This one instead after I run and close a game, it seems like the voltage and memory clock value gets locked at the highest power state.

Hmm, it looks like the voltage is actually configured (as you can see in the sliders - those show the value from the GPU, not just what you've configured it to before), but the problem is that the GPU doesn't always use this voltage.
LACT does not control specifically what voltage the GPU runs on, it just sets the voltage values at the appropriate p-states, and then the GPU clocks itself according to those p-states. So I'm afraid this is a GPU firmware issue, and there's not much that can be done on LACT's side.
You can also try changing the performance level or disabling certain power states to see if it changes this behaviour.

Same problem exist on my vega56.

But in addition the voltage isnt changed at all even after i try to reapply the setting.

@mbrowars could you be more specific which version you're currently running, and with which version it worked before?

@ilya-zlobintsev Im sorry but I wasnt able to find a hint for the last working version. As it turns out it was enough to delete the the /etc/lact/config.yaml and reinstall the tool. Now everything works fine again. I might have messed things up in the config.


remove mboukhalfa and furkatgofurov7 from approvers

Remove mboukhalfa and furkatgofurov7 from approvers in Nordix repos.

/cc @kashifest


Allow for PKCE flow without client secret + add docs

The PKCE flow according to RFC 7636 allows for secure authorization without the requirement to provide a client secret for the OAuth app.
It is implemented in Gitea since #5378 (v1.8.0), however without being able to omit client secret.
Since #21316 Gitea supports setting client type at OAuth app registration.
As public clients are already forced to use PKCE since #21316, in this PR the client secret check is being skipped if a public client is detected. As Gitea seems to implement PKCE authorization correctly according to the spec, this would allow for PKCE flow without providing a client secret.
Also add some docs for it, please check language as I'm not a native English speaker.
Closes #17107

Do you have a client i can test against in recommendation?

Do you have a client i can test against in recommendation?

Not really.... you can use one of the web-based oauth tools like https://oauthdebugger.com/ or the cli, but I do not know what else could be used

Added a test for PKCE with public client.


CORS issues making requests from Buf Studio

Describe the bug
CORS issues prevent Buf studio from making requests to the GRPC endpoints.
To Reproduce
https://buf.build/studio/penumbra-zone/penumbra/main/penumbra.core.component.shielded_pool.v1alpha1.QueryService/DenomMetadataById?target=https%3A%2F%2Fgrpc.testnet.penumbra.zone&selectedProtocol=grpc-web&share=swqq5lJQUEosLk4t8UxRslIAcYECmXl5qUVArpJHuJFroXFoVFiwU0lJfmh5aKa%2Bb2iJq3lRkVFoqLl%2BqIepgUFSZYG5v2OyrRJQby1XLQA
Fails in Firefox and iOS safari
Expected behavior
Making requests should just work

Try again. I've implemented CORS headers on the grpc service for testnet, but not (yet) for preview:
❯ curl -I https://grpc.testnet.penumbra.zone
HTTP/2 200
access-control-allow-credentials: true
access-control-allow-headers: accept,x-grpc-web,x-user-agent,content-type,user-agent
access-control-allow-origin: https://buf.build
content-type: application/grpc
date: Fri, 03 Nov 2023 22:50:43 GMT
grpc-status: 12
content-length: 0

❯ curl -I https://grpc.testnet-preview.penumbra.zone
HTTP/2 200
content-type: application/grpc
date: Fri, 03 Nov 2023 22:50:46 GMT
grpc-status: 12
content-length: 0

You should therefore be able to use Buf Studio with the testnet grpc, but not with preview grpc. Can you confirm? Once the CORS config is solid, I'll add a PR to this repo to make sure it's always added, so it'll stick around, even on preview re-deploys.

Initial report shows working in Safari. I'm leaving this issue open as a reminder to update preview to match.

Headers are serving:
❯ curl -I https://grpc.testnet.penumbra.zone
HTTP/2 200
access-control-allow-headers: accept,x-grpc-web,x-user-agent,content-type,user-agent
access-control-allow-origin: https://buf.build
content-type: application/grpc
date: Mon, 06 Nov 2023 22:35:23 GMT
grpc-status: 12
content-length: 0

❯ curl -I https://grpc.testnet-preview.penumbra.zone
HTTP/2 200
access-control-allow-headers: accept,x-grpc-web,x-user-agent,content-type,user-agent
access-control-allow-origin: https://buf.build
content-type: application/grpc
date: Mon, 06 Nov 2023 22:35:26 GMT
grpc-status: 12
content-length: 0

via automatic deploy in https://github.com/penumbra-zone/penumbra/actions/runs/6777204344

We don't want to special-case Buf Studio, we want GRPC to work from arbitrary web contexts.

Ah, I misunderstood. In that case, we'll want:

access-control-allow-origin: *
access-control-allow-headers: *

Which seems to have decent support cross-browser.

This is still broken. Steps to reproduce:

pd testnet join
pd start --home ... & cometbft start --home ...
Set endpoint to http://localhost:8080 in Buf Studio
Get "CORS Missing Allow Origin" (in Firefox, and presumably other browsers).

We can't fix this by special casing for Buf studio specifically or for the testnet infrastructure Penumbra Labs happens to run. The node software has to work out of the box.

https://docs.rs/tower-http/0.4.4/tower_http/cors/struct.AllowOrigin.html#method.any
2nd example block https://docs.rs/tonic-web/latest/tonic_web/index.html#enabling-tonic-services
https://docs.rs/tonic-web/latest/src/tonic_web/lib.rs.html#128-155

OK, we should be good to go here. I've added CORS support inside pd, and removed the RP middleware. When running locally, I'm able to use Buf Studio against http://localhost:8080 just fine, although for the SimulateTrade RPC to work, I have to provide --enable-expensive-rpc to pd start. I'm also able to run the same against https://grpc.testnet-preview.penumbra.zone, so I'm closing this issue, but don't hesitate to reopen if I've missed something.


Test Runner hangs intermittently, datacollector.exe appears deadlocked

Description

Intermittently during our build process our unit tests seem to hang.  All individual tests have <20s timeouts applied to them, and it appears a test is not currently running, even though the test process is still executing.  After 1 hour (overall build timeout) the build fails.
Debugging seems to indicate that datacollector.exe is hanging when trying to handle a child process exiting while the tests are running.

Steps to reproduce

Intermittently reproducible, anecdotally related to unit tests that spawn subprocesses

Expected behavior

Tests do not hang.

Actual behavior

Tests hang.  DataCollector.exe always has the following callstacks:

Thread 1

0:004> !CLRStack
OS Thread Id: 0xb44 (4)
Child SP               IP Call Site
000000f332aff0f8 00007ffbb572f0e4 [HelperMethodFrame_1OBJ: 000000f332aff0f8] System.Threading.WaitHandle.WaitOneNative(System.Runtime.InteropServices.SafeHandle, UInt32, Boolean, Boolean)
000000f332aff220 00007ffb9b4be98b System.Threading.WaitHandle.InternalWaitOne(System.Runtime.InteropServices.SafeHandle, Int64, Boolean, Boolean)
000000f332aff250 00007ffb9b4be95e System.Threading.WaitHandle.WaitOne(Int32, Boolean)
000000f332aff290 00007ffb3de69726 Microsoft.VisualStudio.Diagnostics.Logging.LoggerEngine.Stop(Boolean)
000000f332aff310 00007ffb3de66342 Microsoft.VisualStudio.TraceCollector.CommonDataCollector+LoggerWrapper.LoggedProcess_Exited(System.Object, Boolean)
000000f332aff360 00007ffb9b503423 System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
000000f332aff430 00007ffb9b5032b4 System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
000000f332aff460 00007ffb9beb1425 System.Threading._ThreadPoolWaitOrTimerCallback.PerformWaitOrTimerCallback(System.Object, Boolean)
000000f332aff610 00007ffb9d406d93 [GCFrame: 000000f332aff610]
000000f332aff808 00007ffb9d406d93 [DebuggerU2MCatchHandlerFrame: 000000f332aff808]
0:004> ~5s

Thread 2

0:005> !CLRStack
OS Thread Id: 0x51cc (5)
Child SP               IP Call Site
000000f332cfe408 00007ffbb572f0e4 [GCFrame: 000000f332cfe408]
000000f332cfe548 00007ffbb572f0e4 [GCFrame: 000000f332cfe548]
000000f332cfe588 00007ffbb572f0e4 [HelperMethodFrame_1OBJ: 000000f332cfe588] System.Threading.Monitor.Enter(System.Object)
000000f332cfe680 00007ffb3de5d9fd Microsoft.VisualStudio.TraceCollector.CommonDataCollector+LoggerWrapper.SendMessage(MessageCreator, Boolean)
000000f332cfe730 00007ffb3de4d7ce Microsoft.VisualStudio.TraceCollector.CommonDataCollector.DispatchMessage(MessageCreator)
000000f332cfe7a0 00007ffb3de64dd8 Microsoft.VisualStudio.TraceCollector.CommonDataCollector.OnTestCaseEnd(System.Object, Microsoft.VisualStudio.TestPlatform.ObjectModel.DataCollection.TestCaseEndEventArgs)
000000f332cfea98 00007ffb9d406d93 [DebuggerU2MCatchHandlerFrame: 000000f332cfea98]
000000f332cfedd8 00007ffb9d406d93 [HelperMethodFrame_PROTECTOBJ: 000000f332cfedd8] System.RuntimeMethodHandle.InvokeMethod(System.Object, System.Object[], System.Signature, Boolean)
000000f332cfef50 00007ffb9b513e60 System.Reflection.RuntimeMethodInfo.UnsafeInvokeInternal(System.Object, System.Object[], System.Object[])
000000f332cfefc0 00007ffb9b4e2519 System.Delegate.DynamicInvokeImpl(System.Object[])
000000f332cff010 00007ffb3de4b472 Microsoft.VisualStudio.TestPlatform.Utilities.MulticastDelegateUtilities.SafeInvoke(System.Delegate, System.Object, System.EventArgs, System.String)
000000f332cff070 00007ffb3de4aeea Microsoft.VisualStudio.TestPlatform.Common.DataCollector.TestPlatformDataCollectionEvents.RaiseEvent(Microsoft.VisualStudio.TestPlatform.ObjectModel.DataCollection.DataCollectionEventArgs)
000000f332cff0c0 00007ffb3de648db Microsoft.VisualStudio.TestPlatform.Common.DataCollector.DataCollectionManager.TestCaseEnded(Microsoft.VisualStudio.TestPlatform.ObjectModel.DataCollection.TestCaseEndEventArgs)
000000f332cff130 00007ffb3de5ee59 Microsoft.VisualStudio.TestPlatform.CommunicationUtilities.DataCollection.DataCollectionTestCaseEventHandler.ProcessRequests()
000000f332cff180 00007ffb3de4e57d Microsoft.VisualStudio.TestPlatform.CommunicationUtilities.DataCollection.DataCollectionRequestHandler.b__22_0()
000000f332cff1e0 00007ffb9b54ca96 System.Threading.Tasks.Task.Execute()
000000f332cff220 00007ffb9b503423 System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
000000f332cff2f0 00007ffb9b5032b4 System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
000000f332cff320 00007ffb9b54cd35 System.Threading.Tasks.Task.ExecuteWithThreadLocal(System.Threading.Tasks.Task ByRef)
000000f332cff3d0 00007ffb9b54c463 System.Threading.Tasks.Task.ExecuteEntry(Boolean)
000000f332cff410 00007ffb9b5425f2 System.Threading.ThreadPoolWorkQueue.Dispatch()
000000f332cff8a8 00007ffb9d406d93 [DebuggerU2MCatchHandlerFrame: 000000f332cff8a8]

Diagnostic logs

TBD

Environment

Please share additional details about the test environment.
Windows 10
0:000> lm v m vstest*
Browse full module list
start    end        module name
00820000 00844000   vstest_console   (deferred)
Image path: C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\IDE\CommonExtensions\Microsoft\TestWindow\vstest.console.exe
Image name: vstest.console.exe
Browse all global symbols  functions  data
Has CLR image header, track-debug-data flag not set
Image was built with /Brepro flag.
Timestamp:        EFCF0EB1 (This is a reproducible build file hash, not a timestamp)
CheckSum:         00029D14
ImageSize:        00024000
File version:     15.0.27924.0
Product version:  15.0.27924.0
File flags:       0 (Mask 3F)
File OS:          4 Unknown Win32
File type:        1.0 App
File date:        00000000.00000000
Translations:     0000.04b0 0000.04e4 0409.04b0 0409.04e4
Information from resource tables:

Hi @mayerj, I am not able to infer much from the stack trace you've provided. Could you turn on the --diag option and upload the logs here.
It would be even more helpful if you could share a sample project which runs into such problems.

I have the diagnostic traces, but I'm a little reticent to upload them here, as there are a lot of product specific paths and references in them.  Is there some way to share them privately?

@mayerj, can you provide your email on here? If that's not possible then I would suggest posting it on developer community, you can limit access to attachments on developer community to only be visible by folks at microsoft

@karanjitsingh Just checking, you did not get the logs yet, right?
@mayerj Did you get a chance to create an issue on developer community? or is there any other way you want us to access the logs, please let us know.
Please update this thread, so we understand what state we are in.

@singhsarab Yep, haven't received the logs

@singhsarab Yep, haven't received the logs

@mayerj Is there some support ID that you are using to track the case ?

Closing this as user has already opened premier support case.


Stop handle expansion due to missing unreferenced flag in summary

Fixes: https://github.com/microsoft/FluidFramework/issues/5055
1.) The server does not return unreferenced flag in the summary returned, currently. However this may change in future.
2.) So when we expand the handle with the cached summary tree, we are not able to set the unreferenced flag in the expanded tree.
3.) So disable the handle expansion for now.

This should be tested to make sure that the unreferenced flag is not lost anymore.

This should be tested to make sure that the unreferenced flag is not lost anymore.
Actually this is more of server side operation as they mark the tree as referenced if we expand the handle. So if we don't expand the handle server would not be marking them as referenced. So lets see when the FFX takes this change.


Cannot strip ARM binaries

I am using this action to cross-compile a CLI application (called hoard) for multiple platforms. When compiling for the armv7-linux-androideabi target, I got the following error:
strip: Unable to recognise the format of the input file `hoard'

I am not sure if there is a way to strip these binaries or if stripping should be skipped for them, but either solution would be nice so I can distribute downloads for Android platforms.

Update: Just got this with the aarch64-unknown-linux-gnu target, so I'm thinking this may be for ARM or even foreign architectures in general.

Thanks for the report!
We probably need to skip strip if a target with a different architecture than the host is specified.
Or, I think it is possible to make the strip work on those architectures, but it requires additional dependencies (e.g., on arm-linux-gnueabihf-strip via gcc-arm-linux-gnueabihf, aarch64-linux-gnu-strip via gcc-aarch64-linux-gnu).
So it might be better to use them when they are available and warn when they are not.

Fixed in v1.1.0.


Drawer: fix focus bug

Please make sure these boxes are checked before submitting your PR, thank you!
ref: #19902

[x] Make sure you follow Element's contributing guide (中文 | English | Español | Français).
[x] Make sure you are merging your commits to dev branch.
[x] Add some descriptions and refer relative issues for you PR.

Hey, I am the contributor who contributed this component, the original idea of adding tabindex to title is because we want the screenreader to read the title content for the users who uses screenreader device, but I did have made a mistake on adding tabindex towards the container.

The change itself was legit though, but still, I think you do not need to remove the nextTick operation because that's how it works, also I didn't add trap-focus for this component, which needs trap the focus(keyboard navigation) inside this content.

Hi, Thanks for your reply. In my opinion that tabindex can improve keyboard accessibility. For screen reading we should use aria-label or role attributes to improve accessibility. So I removed the tabindex from the title.

For dialog or drawer components I think trap-focus is necessary. We have the same opinion about this. And like the bootstrap antd material ui they all have implementations for it.

For dialog or drawer components I think trap-focus is necessary. We have the same opinion about this. And like the bootstrap antd material ui they all have implementations for it.

The change is legit, adding trap-focus functionality would be a great upgrade.

For dialog or drawer components I think trap-focus is necessary. We have the same opinion about this. And like the bootstrap antd material ui they all have implementations for it.

The change is legit, adding trap-focus functionality would be a great upgrade.

This feature may be updated next time 😄


Failed to boot web server image from the test suite

Running this command from the test suite:
sudo qemu-system-x86_64 -nographic -m 1024 -snapshot -accel kvm:hvf:tcg /tmp/osbuild-7nc58zbl/web-server.qcow2 -net nic,model=rtl8139 -net user,hostfwd=tcp::8888-:8888

results in the following error:
error: ../../grub-core/fs/fshelp.c:257:file
`/osbuild-px27al9e/tmp6_9916qr/tree/boot/vml
inuz-5.0.9-301.fc30.x86_64' not found.
error: ../../grub-core/loader/i386/pc/linux.c:413:you need to load the kernel
first.

Press any key to continue...

  Failed to boot both default and fallback entries.

Press any key to continue...

Did you include a kernel? test/1-create-base.json doesn't have one defined.
When I do that, I still cannot boot the image, because grub resolves the path to the kernel in /boot by looking at /proc/self/mountinfo and using the source path of the mount. It resolves it all the way to the host. Haven't found a solution to this yet that doesn't involve copying the full tree to a path that's not bind-mounted.

No, but I thought it was included in @Core, but it is not (https://pagure.io/fedora-comps/blob/master/f/comps-f30.xml.in#_598). btw do you know when this bug was introduced? It used to work ...

Nothing automagically included kernel before, so it is strange that this broke. Was it part of @Core in the past? Have we switched from f29 to f30?

It wasn't: https://pagure.io/fedora-comps/blob/master/f/comps-f29.xml.in#_711

Then I'm all out. Maybe worth bisecting? The /proc/self/mountinfo thing is less mysterious, I did change things here, and I'll look into that, so don't worry about bisecting that.

I haven't found a way to work around grub2-mkrelpath, so here's a hack that works: https://github.com/osbuild/osbuild/pull/73
The image boots now, but I don't get a login prompt.

I think this is fixed now.


[feature request] add *.f file to track all HDL files + compile order

@mikaelsky has suggested (in some issue I cannot find right now) to add a "*.f" file that list all required HDL files in their according compile order. This file could be consumed by synthesis tools to ease correct project setup.
Open questions:

where to put this file?
what format to use?
what is the "right" / "best" compile order?

As always, help with this is highly appreciated! :wink:

Normally we had the .f file(s) in parallel with the RTL files, or if you have a lot of sub-dirs for RTL functions at the root. In our case we don't so just in the RTL directorty.
Here is a simple write up of what a .f (dot-f) file is from Icarus Verilog: https://iverilog.fandom.com/wiki/Command_File_Format. This is basically an industry standard right now, which is supported by all commercial tools and some open source EDA tools.
In our case I made quite a few .f files, such that I could add in features or not via .f as well.
Compile order really only matters for top level files. So for us that meant when you get to an entity that uses other entities it should be compiled after. In the case of the core it would be something like:

neorv32_fifo.vhd // note me I'm very early in list as I'm being used in the controller.
neorv32_cpu_control.vhd
neorv32_cpu_alu.vhd
neorv32_cpu.vhd

Normally we had the .f file(s) in parallel with the RTL files, or if you have a lot of sub-dirs for RTL functions at the root. In our case we don't so just in the RTL directorty.

So in this case this would be rtl, right?

Here is a simple write up of what a .f (dot-f) file is from Icarus Verilog: https://iverilog.fandom.com/wiki/Command_File_Format. This is basically an industry standard right now, which is supported by all commercial tools and some open source EDA tools.

I like that format and I'm glad that comments are supported. That might help to make things a little less obscure. 😅

In our case I made quite a few .f files, such that I could add in features or not via .f as well. [...] Compile order really only matters for top level files.

How would be handle this here?
One core for each rtl sub-folder? Individual files for each of the processor_templates, system_integration wrappers, testbenches, ... ?

Note that GHDL has command elab-order to "Display ordered source files". So, the compile order file can be autogenerated/autoupdated in CI instead of maintaining it manually. See https://ghdl.github.io/ghdl/using/InvokingGHDL.html#cmdoption-ghdl-elab-order.

I've copied in the set of .f files I use in this branch: https://github.com/mikaelsky/neorv32/tree/file-list-example
Fair warning I haven't kept it up to date as I'm only using the core itself, everything else incl. bus-fabric is in-house custom verilog to fit our application.
For Vivado we have 2 scrips, a pre-parsing script that reads in the .f file chain and creates a flat list of just files. This is then read in using this simple .tcl addition:
# Define filesets
set vhdl_filelist {}

# Need to pre-process the .f files into 1 file with no comments etc.
# Read in fpga vhdl file list
set fp [open "./fpga_list.f" r]

   while {[gets $fp line] >= 0} {

   lappend vhdl_filelist $line

   }
close $fp

add_files -norecurse $vhdl_filelist
set_property library neorv32 [get_files $vhdl_filelist]

@mikaelsky I am not proposing to require users to call GHDL in order to get .f files, but for NEORV32 developers to use GHDL to either keep those files up to date or check/test that those files are up to date.
As a rule of thumb, code files which need to be manually updated and are not tested do tend to get out of sync. Hence, for quality purposes they need to be either autogenerated or, if manually generated, they need to be automatically tested. GHDL is helpful in either case.

We get some odd-ball parsing errors (e.g. use string types) that was root-caused to be caused be the move away from component declarations in the code base (A move I support 100%) combined with the source files being read in out of dependency order.

I also encountered this problem when working with some "non-mainstream" FPGA tools. It's a real nightmare 😅

As a rule of thumb, code files which need to be manually updated and are not tested do tend to get out of sync. Hence, for quality purposes they need to be either autogenerated or, if manually generated, they need to be automatically tested. GHDL is helpful in either case.

I like this idea. But would we implement that?
Let GHDL emit a file/hierarchy list within some CI workflow and then push that to main or open a dependabot-like pull request?
But one step after another.
At first we should try to integrate GHDL's elab-order command in some script (main makefile?) to convert the output into something similar to the *.f files provided by @mikaelsky. 🤔

Let GHDL emit a file/hierarchy list within some CI workflow and then push that to main or open a dependabot-like pull request?

I believe that's not necessary. It would be enough to just execute the target in the main makefile and check if the content changed. Similar to a linter. Don't need CI to automatically update the main branch, because that's something we prefer humans to do.

At first we should try to integrate GHDL's elab-order command in some script (main makefile?) to convert the output into something similar to the *.f files provided by @mikaelsky.

Yes, this is the main feature I'm thinking about. That would already allow to automatically test if something changed and take action if needed.

That would be a really cool feature, I think.
It would make setting up the rtl files much easier and we drop all the hard-to-follow hierarchy stuff in https://stnolting.github.io/neorv32/#_vhdl_file_hierarchy :wink:


Previous selected result are removed from the results list when selecting another result if searching chinese word in the "Search" tab

Type: Bug

Search chinese word in the "Search" Tab, and make sure there are results.
Select a result to view it in the editor
Then select another result

The expected behavior is that vscode keep the results list untouched, while the actual behavior is vscode will remove the previous selected result from the results list
VS Code version: Code 1.80.2 (2ccd690cbff1569e4a83d7c43d45101f817401dc, 2023-07-27T20:40:28.909Z)
OS version: Windows_NT x64 10.0.22621
Modes:

System Info

Item
Value

CPUs
AMD Ryzen 7 4800H with Radeon Graphics          (16 x 2895)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
15.36GB (4.46GB free)

Process Argv
--folder-uri file:///c%3A/Users/jhy/** --crash-reporter-id 243344f5-c2ee-4352-8e68-5e1d7abc56d9

Screen Reader
no

VM
0%

Extensions (20)

Extension
Author (truncated)
Version

ng-template
Ang
16.1.4

catppuccin-vsc
Cat
2.7.0

vscode-eslint
dba
2.4.2

css-flexbox-cheatsheet
dzh
3.3.3

gitlens
eam
14.1.1

EditorConfig
Edi
0.16.4

prettier-vscode
esb
10.1.0

auto-rename-tag
for
0.1.10

svg
joc
1.5.3

svn-scm
joh
2.17.0

indent-rainbow
ode
8.3.1

material-icon-theme
PKi
4.29.0

material-product-icons
PKi
1.5.0

vscode-fileutils
sle
3.10.3

code-spell-checker
str
2.20.5

sort-json
Thi
17.0.1

vscodeintellicode
Vis
1.2.30

vim
vsc
1.25.2

gistfs
vsl
0.4.1

pretty-ts-errors
yoa
0.5.0

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
pythonvs932:30410667
vsclangdc:30486549
c4g48928:30535728
dsvsc012:30540252
pynewext54:30695312
azure-dev_surveyone:30548225
vsccc:30803844
282f8724:30602487
f6dab269:30613381
a9j8j154:30646983
showlangstatbar:30737416
vsctsb:30748421
03d35959:30757346
pythonfmttext:30731395
pythoncmv:30756943
fixshowwlkth:30771522
hideindicator:30785051
pythongtdpath:30769146
i26e3531:30792625
gsofa:30797621
pythonnosmt12:30797651
pythonnoceb:30797650
e537b577:30795824
dsvsc013:30795093
dsvsc014:30804076

I can't seem to repro, see the gif below.

Does this happen in all your projects with extension disabled?

So here are steps which I reproduce the issue in a test project:

there are some files in the project, and there are chinese words, let's say '测试', in these files, meanwhile, there are also chinese words like '测试服务' in these files, which contains '测试', but not equal to the '测试'.
when search '测试‘ with the Match Whole Word enabled, the search results will contain '测试服务', then selecting the '测试服务'
when selecting the next result, the previous result will be removed.

and I reproduce it with my windows pc and mac
the video is recorded in mac
https://github.com/microsoft/vscode/assets/48473551/d0e1ea58-fa25-4cd8-b701-1c78c4afb65c

It seems I can get it to reproduce with these steps:

have one file with

测试服务
测试

and another with just
测试

turn case sensitivity and match whole word on and put 测试 in the query box
reload the window
go to search viewlet and make search
notice that it finds 测试服务 despite it not matching whole word (there aren't boundary characters around 测试) :bug:
if you perform another search with the file open, the result disappears.

This is actually a duplicate of https://github.com/microsoft/vscode/issues/27280
/duplicate https://github.com/microsoft/vscode/issues/27280


Fix merges

Fix revert mistakes with rebase

Just merge this please... @csepulveda7 😢

Please, @csepulveda7

You no merge yet :heart: Please wait, @csepulveda7


Removed underscores, fixed lat and lon usage in cartesian_cords

This was a small fix for issue #1519 . I am not able to validate the cartesian_cords at this moment. Could allocate more time for that if desired.
I wasn't sure what N was in cartesian_cords function and if the lon should be lat, so I tried to look it up and came across this PDF. Here it lists N in a different format but on wikipedia it lists the actual used (simplified) method for N, derived from the one in the PDF. So here I also had to change lon to lat.
The (c/a)^2 in the PDF is obtained by using 1-e^2, where e^2 = 1 - (c / a) ** 2.
Leaving this info just in case.

The first test fail correspond to mix up of lat and lon.
The test expects lat = 38.43, lon = 41.2. As I can confirm with orbit_predictor package llh2ecef. Resulting in:
(3764.2586478469702, 3295.3593385548143, 3942.9452857930723)

The test result somehow corresponds to inputs lat = 41.2, lon = 38.43. Resulting in:
(3764.859301272756, 2987.2016749669842, 4179.160715400216)

I am not familiar with your standards for order of lat and lon. el_cords shows 2 u.deg values but I am unable to say which is which. Maybe the unit test input is wrong way round and puts it in the lat, lon order, while cartesian_cords  does currently expect lon, lat order.

Thanks a lot for this pull request @applysomesky!

I am not familiar with your standards for order of lat and lon.

Let's settle on (lon, lat) forever, since it resembles (x, y) and also because it's the right way.

I wrote a small script that runs the corrected cartesian_cords versus llh_to_ecef  from orbit_predictor package.
It produces the same results for the same lon, lat.
__ orbit_predictor llh_to_ecef __
lon: 38.43, lat: 41.2
result op [3764.86, 2987.2, 4179.16]
__ poliastro cartesian_cords __
el_cords (lon,lat): (38.43, 41.2, 0)
result pa [3764.86, 2987.2, 4179.16]

However the unit test for the el_cords expects something else, which is:
expected_cords unit test: [3764258.64785411, 3295359.33856106, 3942945.28570563]

Switching the lat and lon on input in both functions results in the same outcome as the unit test expects:
__ orbit_predictor llh_to_ecef __
lon: 41.2, lat: 38.43
result op [3764.26, 3295.36, 3942.95]
__ poliastro cartesian_cords __
el_cords (lat,lon): (38.43, 41.2, 0)
result pa [3764.26, 3295.36, 3942.95]

This strongly suggest the unit tests switched lat and lon as input on its creation.

This strongly suggest the unit tests switched lat and lon as input on its creation.

Sounds like it, yes. Do you want to make the change in the test as well? If I understand correctly, that should fix the CI.

I will have a go at it.

The last one failing is test_h_calculation_near_lat_singularity.
In the last commit I found a mistake in cartesian_to_ellipsoidal when lat == 0.0, it listed x in the numerator whilst on wikipedia and literature (source no. 6 on wiki page) for example it lists sqrt(x**2 + y**2). So I changed that, and on my machine produces the correct result, converting forth and back from Geodetic to Cartesian and back.
It does not fail on the lat == 0.0, but as follows:
Falsifying example: test_h_calculation_near_lat_singularity(
    lat=<Quantity 5.e-324 rad>,
)

I am personally not sure how to solve this at the moment. Maybe I can reiterate on cartesian_to_ellipsoidal and see if there is another small mistake. It seems to produce wrong results for values for lat smaller than 5e-315, but correct results at values bigger than that.
Love to hear your thoughts.

An option would be to make 2 test_h_calculation_near_lat_singularity tests, one for the positive and one for the negative side such that we can limit the smallest number to be bigger than about 5e-315. Not sure if testing smaller numbers has any use. Problem is that if someone uses a latitude smaller than that the function will return a wrong value for h.
Otherwise one can convert latitudes smaller than 5e-315 to 0, with a user warning. Also not sure if that is desirable.

Thank you for your perseverance here. These numerical errors near singularities are tricky. 1e-300 is ridiculously small, maybe we can set the cutoff at 1e-18 or 1e-5 even! I'd be against conversion, if possible.

So just to be clear, so you want to limit the unit test inputs?
In which case we need to apply that limit somehow in this part of the test:
@settings(deadline=None)
@given(
    lat=with_units(
        elements=st.floats(min_value=-1e-2, max_value=1e-2), unit=u.rad
    ),
)

This might mean that the function behaves incorrectly if a user uses a value smaller than 1e-315, if that ever happens.

So just to be clear, so you want to limit the unit test inputs?

Rather than that, replace the lat == 0.0 check inside the function with something more flexible, like abs(lat) < 1e-18. I am hoping that the function is continuous and that we don't see further test failures? Just left a comment on where exactly we could do the change.

Using the latitude of 5e-315 rad did not produce errors on my machine with the proposed change.
I just want to note that the back and forth conversion at these small numbers for latitude results in very small changes in the latitude.

I also observed that cartesian_to_ellipsoidal returns lat, lon, h, so in the wrong order that what is to be expected (lon, lat, h) 🙃.
Changing this would require probably the unit test to be rewritten as well, and might have implications for backwards compatibility.

Glad it's working finally 🎉

Changing this would require probably the unit test to be rewritten as well, and might have implications for backwards compatibility.

I'm happy if you want to pursue that change too (we are not that careful about backwards compatibility outside the Orbit and Ephem objects, which are the true public API), but I'm also happy to merge already 🙂

Let me fix it, I like consistency :)

Superseded by gh-1547 (just rebased on top of main to solve the merge conflicts), thanks a lot @applysomesky! 🙌🏽


Fix initialization of input code page

Currently, the code uses WM_INPUTLANGCHANGE to detect a change to the language in which text is being input, but the initial input code page is assumed to be the system one (CP_ACP). This might not be true, see
https://stackoverflow.com/questions/1291509/how-to-get-the-code-page-of-the-current-keyboard-layout

Fixed by 2bae63198206933b39737b9564fd5b24c4b69bfb


Fixed Hass Alarm panel translations (in addition to alarm panel fix and motion sensor addition)

Sorry for the mess with PRs, feels to me like dev is not synced with master. Let me know what you want me to do. And did I do the translations properly? I did not spend too much trying to figure it out.

Hi, translations are fine.
The Motion sensor will also need a translation, but if you haven't worked with the string-files, I can add them.
Thank you for the work!


Dump not applying transformation with no error emitted

It seems possible to encounter a case when despite a transformation is defined it is not applied and no error is emitted. Shouldn't user be warned if a transformer is not being applied?
greenmask_config.yml file:
dump:
  pg_dump_options:
    dbname: host=localhost user=wna dbname=bireporting
    load-via-partition-root: true
storage:
  type: directory
  directory:
    path: /Users/wna/Developer/
  transformation:
    - schema: public
      name: backlog_entry_value
      transformers:
        - name: RandomFloat
          params:
            column: "value"
            min: 0.0
            max: 10.0
            precision: 2

./greenmask dump --config=greenmask_config.yml
./greenmask list-dumps --config=greenmask_config.yml

+---------------+---------------------------+-------------+----------+-----------------+----------+-------------+-------------------+
|      ID       |           DATE            |  DATABASE   |   SIZE   | COMPRESSED SIZE | DURATION | TRANSFORMED |      STATUS       |
+---------------+---------------------------+-------------+----------+-----------------+----------+-------------+-------------------+
|<PHONE_NUMBER>081 | 2024-08-24T10:41:45+02:00 | bireporting | 26.5 MiB | 8.5 MiB         | 00:00:00 | false       | done              |
+---------------+---------------------------+-------------+----------+-----------------+----------+-------------+-------------------+

A part of metadata.json file. Notice transformers is null.
{
    "startedAt": "2024-08-24T10:41:45.081384+02:00",
    "completedAt": "2024-08-24T10:41:45.816925+02:00",
    "originalSize": 27828141,
    "compressedSize": 8912949,
    "transformers": null,
    "database_schema":
    [
        {
            "schema": "public",
            "name": "backlog_entry_value",
            "oid": 16409,
            "columns":
            [
                {
                    "idx": 2,
                    "name": "value",
                    "type_name": "numeric(10,2)",
                    "canonical_type_name": "numeric",
                    "type_oid": 1700,
                    "num": 3,
                    "not_null": false,
                    "length": 655366,
                    "type_length": -1,
                    "is_generated": false,
                    "overridden_type_name": "",
                    "overridden_type_oid": 0,
                    "overridden_type_size": 0
                },
    [...]

I was not able to find the root cause of the issue in reasonable time.

Hi! Thank you for reporting. You've set the transformation in the wrong object (in storage) instead of dump. It should be this way
dump:
  pg_dump_options:
    dbname: host=localhost user=wna dbname=bireporting
    load-via-partition-root: true
  transformation:
    - schema: public
      name: backlog_entry_value
      transformers:
        - name: RandomFloat
          params:
            column: "value"
            min: 0.0
            max: 10.0
            precision: 2
storage:
  type: directory
  directory:
    path: /Users/wna/Developer/

Try it

However, I agree that it would be helpful to report this issue. I'll consider how to fix it.

Thank you! Such a silly mistake.
Does this mean numeric(precision,scale) type is not supported?
2024-08-24T11:20:11+02:00 ERR ValidationWarning={"hash":"","meta":{"AllowedTypes":["float4","float8"],"ColumnName":"value","ParameterName":"column","SchemaName":"public","TableName":"backlog_entry_value","TransformerName":"RandomFloat","TypeName":"numeric(10,2)"},"msg":"unsupported column type","severity":"error"}
2024-08-24T11:20:11+02:00 FTL cannot make a backup error="context error: fatal validation error"

Yes, it does but only the v0.2b1 version or the current development version in the main. For v0.2b1 version and current main you can use RandomNumeric transformer that has wider configuration options such as decimal.
For the latest version 1.14 you can try to override the type of the table in the config using the next
transformation:
    - schema: public
      name: backlog_entry_value
      columns_type_override:
        value: "numeric"
      transformers:
        - name: RandomFloat
          params:
            column: "value"
            min: 0.0
            max: 10.0
            precision: 2

The details are here

@wnatrifork FYI ^

I've added a fix in MR #177. So in a new release if the unknown option was provided it will be reported.

Thank you. I using a compiled version of the tool from main branch:
wna@Wojciechs-MBP: greenmask % ./greenmask --version
greenmask version a2ecc2cdae5af10e9443ccdab61987f31bd3ade6 2024-08-20T11:49:00Z

I have used random numeric transformer as advised:
  transformation:
    - schema: public
      name: backlog_entry_value
      transformers:
        - name: RandomNumeric
          params:
            column: "value"
            min: 0.0
            max: 10.0
            decimal: 2

and received following error when trying to restore:
2024-08-24T12:15:57+02:00 WRN unable to restore table error="error post streaming handling: error from postgres connection: numeric field overflow A field with precision 10, scale 2 must round to an absolute value less than 10^8. (code 22003)"

I converted the dump from directory format to human readable SQL and found:
--
-- Data for Name: "backlog_entry_value"; Type: TABLE DATA; Schema: "public"; Owner: "wna"
--

COPY "public"."backlog_entry_value" ("unique_id", "created", "value", "author_name", "author_email", "backlog_entry_id") FROM stdin
dc673f92-404d-4873-ba36-779da5947748	2020-05-25 08:22:27.179153	-55142080548242225025.74	<redacted_username>	<redacted_email>	33cd6668-6dd7-4059-95a1-e5ae03027c04

value is not kept in <min, max> bounds. This seems to be a bug.

@wnatrifork The MR #177 is merged. I hope this will fix this implicit issue

Thank you for reporting. I will check shortly

@wnatrifork
That's definitely a bug. It will be fixed today/tomorrow.

@wnatrifork MR #178 should close your issue

I confirm RandomNumeric transformer keeps value within defined bounds. Thank you


Fix CLI grammar

I know this is a very minor thing, but correct grammar makes it easier to understand.

Thanks!


⚠ Fetchers has degraded performance

In d9dffcb, Fetchers ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 277 ms

Resolved: Fetchers performance has improved in 039a2fb.


Update scenario-desktop-acquire-token-wam.md

#label:"aq-pr-triaged"

#sign-off

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.


all invokes are asynchronous due to "typeerror"

when i invoke a new action, it invokes async instead of sync - there's an error posted to the console:

verified, but this only seems to affect the webpack builds.


Copies of reference/ value field are not handled

In KiCad one can add a copy of the value and reference fields with user text fields that have the text %R, REF**, %V or VAL**. This tool does not handle this at all. (%R is still displayed as %R instead of being displayed as the reference assigned to the footprint in question)
This feature is heavily used in the official library. (Every footprint has a copy of the reference field on the fab layer)

Interesting, I didn't really notice this. Will fix.
Are there other substitutions or is that all of them? Is a comprehensive list documented somewhere?

Hm I can't find a way to repro this. When components on pcb are actually linked to schematic component they seem to automatically pick up the right text and are displayed correctly in bom render.
Only time when I get REF** on bom is when pcbnew also shows REF**, i.e. I just plopped a footprint directly in pcbnew instead of importing it from schematic so it does not have a reference or a value.
Can you add some steps on how to get incorrect text in bom, which is different from what is in pcbnew?

I have the main reference of my personal footprints on the fab layer and the copy on the silk layer.
Here the screenshots of my small test project:

And the test project it self.
iactive_bom_test.zip
My kicad version is:
Application: kicad
Version: (5.0.0), release build
Libraries:
wxWidgets 3.0.3
libcurl/7.54.1 OpenSSL/1.0.2l zlib/1.2.11 libssh2/1.8.0 nghttp2/1.23.1 librtmp/2.3
Platform: Windows 7 (build 7601, Service Pack 1), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8)
Boost: 1.60.0
OpenCASCADE Community Edition: 6.8.0
Curl: 7.54.1
Compiler: GCC 7.1.0 with C++ ABI 1011
Build settings:
USE_WX_GRAPHICS_CONTEXT=OFF
USE_WX_OVERLAY=OFF
KICAD_SCRIPTING=ON
KICAD_SCRIPTING_MODULES=ON
KICAD_SCRIPTING_WXPYTHON=ON
KICAD_SCRIPTING_ACTION_MENU=OFF
BUILD_GITHUB_PLUGIN=ON
KICAD_USE_OCE=ON
KICAD_USE_OCC=OFF
KICAD_SPICE=ON
I am running windows 7

Thanks for great bug report!


[SPARK-3229] spark.shuffle.safetyFraction and spark.storage.safetyFraction is not documented

@andrewor14 Thank you for these info.


Update navigation.cjsx

Removed link to Best of 2016 event.
Note:  I know that there were some CSS styling changes made to allow for this link to be added to the top nav of classification.  I don't know whether that needs to be undone, or if those changes can be left in place to accommodate an additional link in the future.

I adjusted the height of the navigation menu when browsing on mobile sized browsers. I can leave it as is... there's just a bit of extra space. However, if we get feedback that it looks odd, then I can readjust the height back to what it was.


 Just wondering if anyone could shred a light on this... I've imported all Novocaine files to my project and renamed the files that will use Novocaine to .mm Just this error on RingBuffer.h refuses to go away during compiling:
RingBuffer.h:31:1: Unknown type name 'class'; did you mean 'Class'?
Parse Issue: RingBuffer.h:31:17: Expected ';' after top level declarator
Is it anything I could be missing, like a compiler setting or a flag option somewhere else? I'm using Xcode 8.33 and iOS deployment target 10. Thanks in advance.

@aldeed That didn't solve the problem

A working solution is provided in #17


Replace HTML in includes folder

Contributes to #25479. Inspired by https://dev.azure.com/ceapex/Engineering/_workitems/edit/467273.

Looks good to me, :shipit: when you're ready.

Thanks for reviewing!


Fix flaky secretcache tests

Please provide a description for what this PR is for: https://github.com/istio/istio/issues/22236
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[X ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@lei-tang: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
bdf168ffdd11e03a28ab18f879901c49433d2b8f
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
bdf168ffdd11e03a28ab18f879901c49433d2b8f
link
/test lint_istio

unit-tests_istio
bdf168ffdd11e03a28ab18f879901c49433d2b8f
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
9105f1fafe0d66cc6a97e7393532283ba780eaf7
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn The PR has been revised. Please take a look.

In response to a cherrypick label: new pull request created: #22284


Ensure key-consistency in non-transactional, distributed Hazelcast/Infinispan

When transactions are disabled in these systems, we need to ensure that key-consistency is guaranteed when the transactional configuration calls for it (in locking and id allocation) and must ensure that this is signaled to the storage backend so it ensures key-consistency in distributed setups. Locally this is trivial but in distributed setups we need to use distributed locks whatever is provided by the underlying data store to ensure consistency per key.

I believe Hazelcast / Infinispan support was provisional and has since been dropped.  Is this still needed ?