Transfers where we wrap asset are logging with incorrect wallet/contract address?

Describe the bug
I'm not seeing all latest transfers for my wallet 0x6d91e35d502fb6f654992283e6e4f397fc23dc2c
in connectscan  https://amarok.connextscan.io/address/0x6d91e35d502fb6f654992283e6e4f397fc23dc2c
It seems to be splitting out the Optimism source transfers where we need to wrap ETH, because we are logging the 'To:' contract in here as the Caller https://optimistic.etherscan.io/tx/0x27eb3abf96648ef82be55e2b49953f4759971335fb3f69c73af16710505ddef8
My missing transfers are under that contract here: https://amarok.connextscan.io/address/0xb0eef3e1de973d045c3858e072c540299585252d
So is reflecting these Optimism transfers in the Latest Transfers section still
But when you click out to 'See More' it links to my wallet
https://amarok.connextscan.io/address/0xb0eef3e1de973d045c3858e072c540299585252d

For Arbitrum seeing similar weirdness
My wallet is 0x6d91e35d502fb6F654992283e6E4f397fC23DC2c

The transfer is
https://amarok.connextscan.io/tx/0xf09ad6a535681c3f44debce58509f976e1e7556e4fbc710344e5db473f3d063e
Caller:
0x20c2a9430baa7251eb9143cbe80ac3968893d06c
https://arbiscan.io/tx/0xad7242b42965e929acb8d7360432d8f6759136b8a12cec653378d86536821ec4

not sure if related to #2642

This one is because it's coming from the Multisend contract. Unfortunately, the "caller" of the xcall in this case will always be the Multisend contract.
If we want, the UI could implement some custom logic to always consider the originating EOA from the bridge UI as the sender and then we can display the right transfers under each EOA.

IF i understand this would help users see all their transfers together
But I think this has some bigger data cleanliness/quality implications beyond the UI
In many cases we will want to analyze unique users over time and related data on-chain  (ex/ https://twitter.com/HopProtocol/status/1608960136604962817)
It will likely incorrectly show one of our biggest users as the Multisend contract, unless we always join a weird way? Can we even do that still?

Each xcall transaction still has record of the EOA that originally sent the call so we can use this on UI side to display the "sender" and filter all of an EOA's transfers correctly. If our tracking system uses the "from" address in the same way, we can get to unique addresses.

The "tracking system" above could be carto... I'm not sure what other resources we'd have available as a team for this kind of thing. We'd have to use some database for recording this, otherwise the user will be consuming a provider to check tx by tx (since presumably, it's easy enough to get all xcall tx hashes) who the EOA caller was, which would be massively inefficient.

The UI displays the data getting from getTransfersByUser.

Oops I submitted a dup #2931 , fixed there also.


Got wrong data from files (mix information from diferent tables)

I'm using your excel library with the last null safety update (2.0.0-null-safety-3)
at the moment to read the data from diferent table some of this data is from diferent table in the same file
I do a simple example to replicate this issue and verify the data on xlsx file, you can check it here ->  https://github.com/JERV-code/excel-test
I hope this could help you to find the problem.

@JERV-code I got the issue, It will. be fixed soon,
Actually I saw the raw code and structuring of the file and it was misusing the sharedStrings.xml and not using it in the way it used to do.
I will improve the parser of the excel so that it can see the updated indexing of the reused string if the sharedString file in excel is duplicating it,
Thanks fore reporting this issue.

let me know if I can do something to solve the problem.

@JERV-code Thanks for asking, but it's cool as I'm looking into this,
This issue is specific to your excel file only, seems like it's an older version excel file as newest the excel structure is not like this and is much more optimised by removing the duplication.

@JERV-code
excel: ^1.1.5 might work for you, #73
but it is not optimised for large dataset and might take long time processing
Null-safety migration have more optimised code,
I'll look into a way to keep the speed constant while hitting the special edge case of the excel files.

ok, I Undertand.
Could you share with me a file that works without problem in this version ? ... it is to get a file base to use, thank you.

@JERV-code @HoedlRein
Hey, are you still experiencing this issue on the latest version 2.0.1?


Add c5d and m5d node types to AWS eu-central-1

Add c5d and m5d node types to AWS Frankfurt (eu-central-1)
Description
The AWS Frankfurt region (eu-central-1) now has c5d and m5d node types available. Make them accessible in libcloud.
Status
Done, ready for review.
Checklist (tick everything that applies)

[ ] Code linting (required, can be done after the PR checks)
[ ] Documentation
[ ] Tests
[ ] ICLA (required for bigger changes)

Codecov Report

Merging #1238 into trunk will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           trunk   #1238   +/-   ##
=====================================
  Coverage   86.3%   86.3%
=====================================
  Files        351     351
  Lines      67892   67892
  Branches    5977    5977
=====================================
  Hits       58592   58592
  Misses      6861    6861
  Partials    2439    2439

Impacted Files
Coverage Δ

libcloud/compute/constants.py
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d5eb6f...20c1ffa. Read the comment docs.

Hello @cure, and thank you for your interest in the project.
This file is generated and should not be edited manually. We use python contrib/scrap-ec2-sizes.py > libcloud/compute/constants.py to generate it. If the scripts fails to add your changes, that means we need to update the script. :)

Thanks @pquentin. I ran python contrib/scrap-ec2-sizes.py > libcloud/compute/constants.py and it does indeed add the c5d/m5d types for eu-central-1. Is this script run manually? Or is it run before each release? Should I update this pull request with the output of the command?

@cure Thank you! The script is indeed run before each release. (To be fair, it is so recent that we never used it in a real release!).
Since we're planning to release libcloud soon, it would be nice to update the PR to contain the output of this command, yes!

@pquentin no problem, I've pushed an updated branch. I see that the script introduces a spurious trailing space on most of the lines it changed.

Oh, that's bad! It seems surprising that the script did that. Do you think you can remove them, maybe manually for now?

Sure thing, done.

@cure Thanks! Merged in trunk. ✨


Can't update packages' versions.

After creating a new project, cd into the project directory and yarn install cause starting failure.

Seems the latest version TypeScript causes this problem.

I use create-cycle-app my-awesome-cyclejs --flavor cycle-scripts-one-fits-all --yarn, this command installs<EMAIL_ADDRESS>automatically.

I failed to fix the typescript version to 2.8. I will fix that

Done now


DONOTMERGE Fix: For mac non-docker GPU builds fix handling of test concurrency.

@mrry This should fix mac-gpu tests.
@yifeif, let me test this. After that we should also cherrypick this into r0.11.
@caisq I keep messing up this change, please feel free to point out any problems or concerns you see.

http://ci.tensorflow.org/job/tensorflow-pull-requests-mac-gpu/2/
Let's see if this one can execute the tests correctly.

LGTM

To make sure if the cpu issue is a flake or not,
Jenkins, test this please.


Add AsyncSceneOutline

bevy_xpbd have AsyncSceneCollider  which initializes all colliders from meshes after scene loading.
It would be convenient to provide something like AsyncSceneOutline component and a system that listens for SceneInstanceReady event and for all entities with AsyncSceneOutline inserts InheritOutlineBundle to all their children.

Good idea, thanks. Added by 87df3aaf708e6c64b1340d137aeb481506c01bff.

@komadori Thanks! But I see that you use SceneSpawner. I think it's slover to iterate over all scenes. Instead you can just listen for SceneInstanceReady events.

I suggested the marker component initially, but they decided on the event, so I edited the issue.
After using it for some time, I found it quite convenient.

Yes, I saw. Thanks for working on it. I think it will use some kind of per-entity event/observer pattern in the future once Bevy has support for it, and that will be the best solution.


challenge stuck on pending dial tcp: lookup  on : no such host

issuer.yaml
apiVersion: certmanager.k8s.io/v1alpha1
   kind: ClusterIssuer
   metadata:
     name: letsencrypt-prod
   spec:
     acme:
       # The ACME server URL
       server: https://acme-v02.api.letsencrypt.org/directory
       # Email address used for ACME registration
       email<EMAIL_ADDRESS>       # Name of a secret used to store the ACME account private key
       privateKeySecretRef:
         name: letsencrypt-prod
       # Enable the HTTP-01 challenge provider
       #http01: {}
       solvers:
       - selector: {}
         http01:
           ingress:
             class: traefik

ingress
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: traefik-web-ui
  namespace: kube-system
  annotations:
    kubernetes.io/ingress.class: "traefik"
    certmanager.k8s.io/cluster-issuer: "letsencrypt-prod"
    certmanager.k8s.io/acme-challenge-type: http01
spec:
  tls:
  - hosts:
    - omt.traefikui.com
    secretName: traefik-ui
  rules:
  - host: omt.traefikui.com
    http:
      paths:
      - backend:
          serviceName: traefik-web-ui
          servicePort: web

challenge
Name:         traefik-ui-2866269153-0
Namespace:    kube-system
Labels:       acme.cert-manager.io/order-name=traefik-ui-2866269153
Annotations:  <none>
API Version:  certmanager.k8s.io/v1alpha1
Kind:         Challenge
Metadata:
  Creation Timestamp:  2019-06-11T06:12:34Z
  Finalizers:
    finalizer.acme.cert-manager.io
  Generation:  4
  Owner References:
    API Version:           certmanager.k8s.io/v1alpha1
    Block Owner Deletion:  true
    Controller:            true
    Kind:                  Order
    Name:                  traefik-ui-2866269153
    UID:                   e58c9408-8c0f-11e9-b4c5-049fca8e1048
  Resource Version:        1239884
  Self Link:               /apis/certmanager.k8s.io/v1alpha1/namespaces/kube-system/challenges/traefik-ui-2866269153-0
  UID:                     e786e737-8c0f-11e9-b4c5-049fca8e1048
Spec:
  Authz URL:  https://acme-v02.api.letsencrypt.org/acme/authz/8Q6gzhwzW00S_hYHJMUHW-DF0OIq4-i3GZcIHeJ89-c
  Dns Name:   omt.traefikui.com
  Issuer Ref:
    Kind:  ClusterIssuer
    Name:  letsencrypt-prod
  Key:     jcMBYJwqIvQlnm8y2a6dBneFRFonJetkDkH93oWwF4U.sq-eztnhYteof8-DDJrB0q0Me-qB7TYlOpuloxPi2Vo
  Solver:
    Http 01:
      Ingress:
        Class:  traefik
    Selector:
  Token:     jcMBYJwqIvQlnm8y2a6dBneFRFonJetkDkH93oWwF4U
  Type:      http-01
  URL:       https://acme-v02.api.letsencrypt.org/acme/challenge/8Q6gzhwzW00S_hYHJMUHW-DF0OIq4-i3GZcIHeJ89-c/16921018933
  Wildcard:  false
Status:
  Presented:   true
  Processing:  true
  Reason:      Waiting for http-01 challenge propagation: failed to perform self check GET request 'http://omt.traefikui.com/.well-known/acme-challenge/jcMBYJwqIvQlnm8y2a6dBneFRFonJetkDkH93oWwF4U': Get http://omt.traefikui.com/.well-known/acme-challenge/jcMBYJwqIvQlnm8y2a6dBneFRFonJetkDkH93oWwF4U: dial tcp: lookup omt.traefikui.com on <IP_ADDRESS>:53: no such host
  State:       pending
Events:        <none>

it seems like to lookup the traefik-ingress-host in kube-dns service！！Of course it does not exist
kubernetes 1.14.2
cert-manager 0.8.0

it seems like to lookup the traefik-ingress-host in kube-dns service！！Of course it does not exist

So this is as expected, and it should exist. cert-manager does not create DNS A records for you, it is your job to create the A record for omt.traefikui.com pointing at the IP address of your Ingress controller.

I'm going to close this as I think your configuration is incorrect. The #cert-manager channel on slack.k8s.io is helpful for attempting to debug your config before opening an issue about it, so that we can keep this issue board for bug reports and feature requests 😄
Feel free to reopen if you think there is still a bug in cert-manager that can be fixed here!

@munnerz actually I am getting the same issue. And I am quite sure of the error since it's a "no such host" error and I can reach it easily.
E1005 11:35:20.883814       1 sync.go:183] cert-manager/controller/challenges "msg"="propagation check failed" "error"="failed to perform self check GET request 'http://kintocloud.com/.well-known/acme-challenge/AdTZppUutYuiH_WA9kHV56l4mufmbVmuZE41LAUTRas': Get http://kintocloud.com/.well-known/acme-challenge/AdTZppUutYuiH_WA9kHV56l4mufmbVmuZE41LAUTRas: dial tcp: lookup kintocloud.com on <IP_ADDRESS>:53: no such host" "dnsName"="kintocloud.com" "resource_kind"="Challenge" "resource_name"="kintocloud-cert-1072522747-0" "resource_namespace"="istio-system" "type"="http-01"

http://kintocloud.com/.well-known/acme-challenge/AdTZppUutYuiH_WA9kHV56l4mufmbVmuZE41LAUTRas

Hi,
Im gettign following error for my GKE cluster. My domain is registered in godaddy.com
My question what is causing below error and is this something I need to do  on gopdaddy.com so that these well-known thing can be verified
cert-manager/controller/challenges "msg"="propagation check failed" "error"="failed to perform self check GET request 'http://www.abc.com/.well-known/acme-challenge/AZl_evY1PscNKi95EdfFNuYG_Gl75-Hi8we7Efbyy7I': Get http://www.abc/.well-known/acme-challenge/AZl_evY1PscNKi95E3EFNxcdfl75-Hi8we7Efbyy7I: dial tcp: lookup www.abc.in on <IP_ADDRESS>:53: no such host" "dnsName"="www.abc.com" "resource_kind"="Challenge" "resource_name"="abc-3611830638-3386842356-1600275291" "resource_namespace"="default" "type"="http-01"

I believe anyone who use same DNS zone for cluster internal suffix and exposed service (i.e. you use k8s.example.com and exposing a service via /(app.)?k8s.example.com/) will be hit by this. Let's see if #1292 ever got fixed ...

@alemonmk I don't know why you crossed that text out -- that was exactly my problem.

@EternalDeiwos Actually I found the proper way: unset these and point to any server that can resolve your names.

I had the same issue on GKE – I get no such host error but after some time (~5 minutes or so) challenge passes successfully. My cluster and app domains shared the same root domain. After I've changed cluster domain the issue resolved.
@alemonmk could you please clarify about your solution? you remove dnsPolicy in the certmanager pod and add dnsConfig? I tried that but it didn't work for me.

For any visitors from the future... I was encountering the same error as described in this issue, however, it was because the cert-manager self-checks try to resolve using NodePort by default, even if one isn't exposed.
I'm using MetalLB, so changing serviceType to ClusterIP worked for me 🤷♂  Hopefully that helps someone else!
See https://cert-manager.io/docs/configuration/acme/http01/#servicetype

it seems like to lookup the traefik-ingress-host in kube-dns service！！Of course it does not exist

So this is as expected, and it should exist. cert-manager does not create DNS A records for you, it is your job to create the A record for omt.traefikui.com pointing at the IP address of your Ingress controller.

works for me. I changed the setting in domain seller and works. Thanks


Monorepo

Coverage remained the same at 91.579% when pulling 9d9836c9bf37621d1ab008035a0b7e435a3111f0 on monorepo into 9e650f8144338e2cf9819b166add1bb138f3a058 on master.

Coverage remained the same at 91.579% when pulling 8e4cdb956609d25eb0be59eb3db4d30bbd683a08 on monorepo into 9e650f8144338e2cf9819b166add1bb138f3a058 on master.


How to use webp-hero with Angular 7?

Hi! we tryed to use this awesome lib in our Angular 7 Project. We added it to polyfill.ts but it isnt working. It simply do nothing. When a webp is loading simply nothing happens.

@SvenBudak — hello my friend, i hope we can resolve this for you
could you post some example HTML or JS of how you've included and used webp-hero into your project?
webp-hero needs to be installed in two steps:

include the webp-hero library onto your page or into your application
instantiate a WebpMachine and run the polyfillDocument method

for now while you are setting it up, you can leave the polyfills out of the equation, because those are intended to support IE11
hopefully with more information we could resolve this issue
cheers! :wave:

Hi! we tryed to use this awesome lib in our Angular 7 Project. We added it to polyfill.ts but it isnt working. It simply do nothing. When a webp is loading simply nothing happens.

Step1: Add to providers in app.module.ts
import {WebpMachine} from "webp-hero"

@NgModule({
  declarations: [AppComponent],
  providers: [ WebpMachine ],
  imports: [
    BrowserModule,
  ],
  bootstrap: [AppComponent]
})
export class AppModule {}

Step2: Add to contructor in app.component.ts
import { Component, OnInit } from '@angular/core';
import {WebpMachine} from "webp-hero";

@Component({
    selector: 'app-root',
    templateUrl: './app.component.html',
    styleUrls: ['./app.component.scss']
})
export class AppComponent implements OnInit, OnDestroy {
    constructor(private webp: WebpMachine ) {
         this.webp.polyfillDocument();
     }
    ngOnInit() {}

}

Ouh wow! Thanks for this awesome support! i will show this my friend and test this tomorrow.
Is there any way to limit this function to Safari, Safari Mobile and IE11? Is there any kind of browser detection includet that i can set with any kind of config?

Ouh wow! Thanks for this awesome support! i will show this my friend and test this tomorrow.
Is there any way to limit this function to Safari, Safari Mobile and IE11? Is there any kind of browser detection includet that i can set with something like a config?

`import { Component, OnInit } from '@angular/core';
import {WebpMachine} from "webp-hero";
@Component({
selector: 'app-root',
templateUrl: './app.component.html',
styleUrls: ['./app.component.scss']
})
export class AppComponent implements OnInit {
constructor(private webp: WebpMachine ) {
 }
ngOnInit() {
    this.nableWebpOnUnSupportBrowsers();
}

private enableWebpOnUnSupportBrowsers(): void {
     if (/msie\s|trident\/|edge\//i.test(window.navigator.userAgent)) {
     this.webp.polyfillDocument();
     }
}

}`

Yeah it's sadly not working because the URL param thing..

Hi , i just try to integrate it in my angular 7 app like it described above , i try with last with dev.23 , dev.21
same issue in IE 11 and Edge too :
Edge say : Can't resolve all parameters for WebpMachine: (?).
IE 11 say :  ';' unexpected
Regards,

@coderbase-it — hmm, that is strange
the webp hero demo itself is still working in ie11, so this must be something about the way webp hero is installed in your angular app
could you perhaps show us a more exact error, with line numbers in the stack trace, and also quote the code that is throwing the exception?
i suspect perhaps, it might work better if you ensure that the polyfills are loading before webp-hero is, i wonder since it sort of looks like this angular issue https://github.com/angular/angular/issues/13609 shows some kind of relation to polyfills
webp-hero comes with a polyfill that you can use for ie11<EMAIL_ADDRESS>

@coderbase-it WebpMachine needs to be provided with different syntax to what @Lobasya used - the following will work:
export function webpMachineFactory() {
  return new WebpMachine();
}
// ...
providers: [
  { provide: WebpMachine, useFactory: webpMachineFactory }
]
/// ...

I've implemented a working proof-of-concept of webp-hero with Angular (currently 8, but would work with lower versions), using a couple of Directives.
Example: https://github.com/alexisbmills/angular-universal-state-transfer-demo/pull/4
The main implementation is in the WebpPolyfillModule and usage of Directives are in UserComponent. I've had to extract a bit of the private logic of webp-hero to apply the polyfill, similar to polyfillImage, using Angular's Renderer2.

housekeeping here; i don't really understand this issue, but it seems like it's more about using angular than webp-hero specifically
i think i'll close it -- if anybody's still affected by this issue, just let me know!
👋 chase

I agree. In the evaluation of webp-hero for angular I've developed a reusable library for Angular projects (using webp-hero) - https://github.com/turnstileweb/ngx-webp-polyfill
ng-webp-polyfill utilises webp-hero's decode (webp -> png) logic but leaves the DOM manipulation to Angular.

@alexisbmills — fantastic work!
i've just created #29 to set my intention to add a note about ngx-web-polyfill in the webp-hero readme
cheers, thanks for contributing!
:wave: chase


Marker message with an Angular directive (like ng-controller)

Hi, I want to create a new marker with a message. The message is an html string including a div with an ng-controller directive. Here is my JS code :
var drawMarkerWhitPopup = function(name, point, icon, popupContentFile) {
        var promise = $http.get(popupContentFile);
        promise.success(function(response) {
            var message = $compile(response)($scope);
            $scope.markers[name] = {
                lat: point.lat,
                lng: point.lng,
                draggable: true,
                icon: icon,
                message: message[0],
                focus: true,
            };
        });
}

And Here is my HTML file inserted in the marker message :

Title

Where is my mistake?

This is old - lots of code changes including compileMessage:true


A0-1323: Extend Runtime API to handle AlephBFT version

Description
This extends the AlephSessionApi Runtime API, to handle the AlephBFT version. Storage items, getters, a setter and the declaration and implementation of appropriate methods are provided.
The solution is based on a u32 version. The scheduled version change is persisted as a StorageValue -> AlephBFTScheduledVersionChange. This value stores the information about a scheduled AlephBFT version change, where version_incoming is the version to be set and session is the session on which the new version will be set. A pallet_session::Session_Manager is implemented to check whether a scheduled version change has moved into the past and, if so, to record it as the current version StorageValue -> AlephBFTVersion. When a version change is recorded as the current version, AlephBFTScheduledVersionChange is cleared.
Importantly, we can always reschedule a version change, and an already set version change may move into the past as time goes by. The value of the current_session is needed to check whether the version change needs to be recorded as the current version.
In order to cancel a scheduled version change, we need to use the version change setter (scheduler) and schedule a version change which will actually not change the current version.
Type of change
Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)

Checklist:

I have added tests
I have created new documentation

Based on a fruitful conversation with @fixxxedpoint and @kostekIV, I am converting this back to draft, as we have converged on an alternative and potentially more robust scheme to handle version updates.

Is there a possibility to include some info from this PR description into pallet aleph's readme? In order to have the idea implemented in the PR reflected somewhere that we'll have dynamic versioning of dependencies in aleph-bft. After some thought, it's not intuitive to me we can have library A and can depend on the same library B in two different versions. Thanks to Cargo it is possible, as Rust encodes crate id in the mangled symbol (https://rust-lang.github.io/rfcs/2603-rust-symbol-name-mangling-v0.html).

Is there a possibility to include some info from this PR description into pallet aleph's readme? In order to have the idea implemented in the PR reflected somewhere that we'll have dynamic versioning of dependencies in aleph-bft. After some thought, it's not intuitive to me we can have library A and can depend on the same library B in two different versions. Thanks to Cargo it is possible, as Rust encodes crate id in the mangled symbol (https://rust-lang.github.io/rfcs/2603-rust-symbol-name-mangling-v0.html).

Sure thing, I added an edited description.

My last doubt is regarding naming in this pallet. We want to use versioning not only for alephBFT but also for signature aggregation, and who knows what else in the future. I think its safe to use a more generic name here like schedule_finality_version_change or schedule_consensus_version_change instead of schedule_aleph_bft_version_change.
We ideally want to avoid changing the names ever, because it is in the runtime.
What do you think @timorl and @kostekIV ?

Sounds good, either name is fine to me.

The names you propose sound good, although it's a bit strange that these two things (abft & justifications) get conflated – to be clear I don't have a better solution and this one seems alright, just the versioning will correspond to "official" versions in a strange way.
At the same time I'm worried about the arguments you use – changing names of functions in the runtime (or other changes there for that matter) shouldn't be that disastrous and we should probably spend some time figuring out how to do this better. I think I already mentioned this a long time ago, but it got forgotten... I'll add a task.

Changing the names of runtime calls is fine (if these are sudo calls, because only we need to adapt), but changing the names in the runtime API is imho VERY non-trivial, because you need to add some compatibility layer in the host, otherwise a runtime update with new API would crash the node.
We should probably add this compatibility layer when writing the host part of compatibility.
That being said -- let's avoid changing names anyway, and use consensus or finality here (I would vote for the latter, as this is the nomenclature used by substrate and nicely reflects what apehbft+aggregator do).

Changing the names of runtime calls (=extrinsics) is fine (if these are sudo calls, because only we need to adapt), but changing the names in the runtime API is imho VERY non-trivial, because you need to add some compatibility layer in the host, otherwise a runtime update with new API would crash the node.
We should probably add this compatibility layer when writing the host part of update logic.
That being said -- let's avoid changing names anyway, and use consensus or finality here (I would vote for the latter, as this is the nomenclature used by substrate and nicely reflects what apehbft+aggregator do).

finality it is :)

Ehh. I approved but now I see that spec_version has not been bumped. Why is that?

First time working on anything in the runtime. Have corrected this just now.

You must also bump transaction_version -- these things are in the PR checklist exactly because we don't want to miss them :/

You must also bump transaction_version -- these things are in the PR checklist exactly because we don't want to miss them :/

This should be OK now.

@DamianStraszak I have performed some final tests and there is one case that bothers me. Not a bug per se, but worth considering nonetheless.  Whenever you use next_session_finality_version, you have to make sure that your call comes after the update_version_change_history call from the SessionManager. Otherwise, the returned version for the next session will not be correct for the session when the change takes hold. I can change this behavior to always return the correct version number at the cost of introducing a storage item. Any thoughts?


UmfpackLU.solve should not convert ALL of B to dense.

Currently, UmfpackLU.solve converts ALL of B to dense before running solve. It doesn't need to do this and it creates a problem when dealing with very large matrices, (50000 x 50000)+. I am doing the following in my code and it keeps memory usage under much better control. Previously, I was running out of memory on a 62GB hpc node. Here is my solution:
def lusolve(lu, B):
    if B.shape[0] < 30000:
        X = sparse.csc_matrix(lu.solve(B))
    else:
        cols = list()
        for j in xrange(B.shape[1]):
            col = lu.solve(B[:,j])
            cols.append(sparse.csc_matrix(col))
        X = sparse.hstack(cols)
    return X

For smaller matrices converting all of B to dense is faster, however for larger ones doing it 1 column at a time is much better. It may be more efficient to pre-allocate a sparse matrix rather than using hstack. I haven't tested that.

Good idea, thanks. The UmfpackLU.solve() loops over the individual columns anyway, you are right.
Instead of switching the behaviour on an arbitrary value, what about adding a new kwarg 'return_sparse'(?) to UmfpackLU.solve(), or a new method UmfpackLU.lusolve_sparse()?

I would vote for Umfpack.solve_sparse(B) with basically the implementation above (minus my check). So it would look like this:
def solve_sparse(self, B):
    cols = list()
    for j in xrange(B.shape[1]):
        col = self.solve(B[:,j])
        cols.append(sparse.csc_matrix(col))
    X = sparse.hstack(cols)

OK, agreed. I have to finish other things now - will get to it ASAP. Or, PR welcome!

This is fixed by 3d5cd82047da524ba277ace473d9107737e35212.


WIP: Use cql-translation-service-client library

Updates the pathway builder to use the cql-translation-service-client library.
convertCQL and convertBasicCQL implementations are now delegated to the library.  Some type assertions are used because the builder library and ctsc libraries provide their own typings for things like ElmLibrary.
I also removed the test for convertBasicCql because it relied on mocking the global.fetch, and the ctsc library doesn't use fetch.  I wasn't sure the best way to change the mock to make this work without looking into the libraries implementation, so I figured for now I'd just delete it.
Some resources on the gymnastics used to re-export CqlLibraries.
WIP until https://github.com/mcode/cql-translation-service-client/pull/4 is merged and a new version is published to NPM

FYI the client has been updated to 0.6.0 on NPM https://www.npmjs.com/package/cql-translation-service-client


Reduce the amount of front matter in the Blazor Call an API doc

Description
This article has a lot of front matter before it really starts to discuss the scenario of making an API call from a component.
Can we remove or reduce this front matter and get to the article's topic quicker? The front matter currently includes a lot of stuff that is covered elsewhere and isn't strictly related to calling an API from Blazor.
Currently the doc covers the following before getting into calling an API, which seems excessive:

Defining server-side vs client side
Describing how interactive render modes are applied
Describing that client-side is public and can be decompiled and inspected
Pointers to project structure docs
Instructions on how to run the Blazor samples
A note about nullability support
A note that the article is pivoted for WebAssembly and Server content

Page URL
https://learn.microsoft.com/en-us/aspnet/core/blazor/call-web-api?view=aspnetcore-8.0
Content source URL
https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/blazor/call-web-api.md
Document ID
c7e59a08-1c60-32c2-75fd-33cb77ff7a5d
Article author
@guardrex

Yes, but note that this much content was only going to be here for the 8.0 release in order to "train" devs on BWAs and the major doc change from hosting model to render mode language, along with some of the other mentions (e.g., NREs). This front matter is in most of the articles for this purpose for this release only. My plan was to strike most of it at (or near) 9.0.
Fortunately, the front matter is placed via an INCLUDE, so an update will update all articles in one shot.

A note that the article is pivoted for WebAssembly and Server content

IIRC, that came about I think in a discussion with you a long time ago when it wasn't clear where the WASM JSON helpers were covered when you land on this article's sever pivot. We can resolve that problem if I place a PAIR of articles here in a node (folder) and drop the pivot in a single article. Would you like me to do that?

UPDATE: Per the other issue, going back to a single (long) article will also solve the problem on surfacing JSON helpers.

Yeah, I'd prefer to keep this as one article. Let's see what we can do to simplify the content to keep the length under control.


gtg: init at 0.4.0 (Getting Things GNOME)

Motivation for this change
Adding Getting Things GNOME as requested here #93370.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/getting-things-gnome-modulenotfounderror-no-module-named-gi/8439/4

https://github.com/NixOS/nixpkgs/pull/94710


Add Ruby 3.3 to CI matrix

This PR adds Ruby 3.3 to CI matrix

Looks like we need to update the bundle for this to pass.

Thank you! It seems that nokogiri version 1.16.0 or higher is required.

nokogiri-1.14.0-x86_64-linux requires ruby version < 3.3.dev, >= 2.7, which is
incompatible with the current version, 3.3.0

@dhh Good to merge?


Prepare new prerelease

This is a tracking issue for releasing a new version of Fabruic. The primary request for the new release is updating dependencies to the rustls 0.20 release.

#34

Good to go!

This has been released. https://github.com/khonsulabs/fabruic/releases/tag/v0.0.1-dev.3


[DO NOT MERGE] Allow a type implementing phy::Device to contain borrowed data

Previously, a limitation of Rust's type system required a device to
implement phy::Device<'a> for all lifetimes, including 'static, to
be able to call methods on iface::Interface. This prevented types
implementing phy::Device<'a> from containing any borrowed data.
Now that Rust supports GATs (generic associated types), it is possible
to lift this restriction and allow implementations of phy::Device<'a>
which contain borrowed data.

This is not yet ready to merge. It requires GATs in stable which is set to be released in Rust 1.65 on 3rd Nov.

I haven't checked the code diffs, but this sounds similar to https://github.com/smoltcp-rs/smoltcp/pull/572 ?

It's exactly the same. I even looked at the list of open PRs before starting this. Oh well.
Closing in favour of the existing #572.


[docs] Add instructions for Bun package manager

[x] I have followed (at least) the PR section of the contributing guide.

I'm not sure this request will have wide support yet. Let's start by creating a new issue and gauging interest through votes.


Add appbar to agreement creation

DOD:

[ ] Add an appbar with same background/transparent background and a divider to agreement creation flow
[ ] Add the agreement's name on the left side
[ ] Add a stepper and display the current step in the middle
[ ] add a close button on the right side

is there figma for this?


apt-key deprecation breaking java petclinic installer script

Running through the petclinic installer step (via multipass in my case):
curl -sSL https://dl.signalfx.com/splunk-otel-collector.sh > /tmp/splunk-otel-collector.sh && \
sudo sh /tmp/splunk-otel-collector.sh --with-instrumentation --deployment-environment $(hostname)-petclinic --realm $REALM -- $ACCESS_TOKEN

Results in this error:
Warning: apt-key is deprecated. Manage keyring files in trusted.gpg.d instead (see apt-key(8)).
curl: (60) SSL certificate problem: self-signed certificate
More details here: https://curl.se/docs/sslcerts.html

Skipping fluentd resolves it (--without-fluentd), but at the expense of the log observer steps necessary in later stages of the workshop.

Investigating a move to the OTel FileLog receiver instead of Fluentd for this workshop. This would negate the requirement to have Fluentd installed.

@bblinder Can this issue be closed? Many thanks!

OTel Collector 0.80 fixes the issue


Plugin for adding monitor into cluster

Current coverage is 85.72% (diff: 100%)

Merging #81 into master will not change coverage

@@             master        #81   diff @@
==========================================
  Files            58         58
  Lines          3735       3735
  Methods           0          0
  Messages          0          0
  Branches        345        345
==========================================
  Hits           3202       3202
+ Misses          448        446     -2
- Partials         85         87     +2

Powered by Codecov. Last update bc599a8...f3ee2a3


vtctl SetShardTabletControl doesn't do what it says

Either the command needs to be fixed or the documentation.

There is no --blacklisted_tables flag, it's called --tables
If I specify --remove I expect the table to be removed from the blacklist, instead the entire tablet_controls record seem to be removed

Fixing the doc there: https://github.com/youtube/vitess/pull/2357


LVOSV2 test server

How can I test the LVOSV2 test set?

Hello, thanks for your interest. We haven't had the plan to release the LVOS V2 test server. We will release the code for evaluation of valid set within this week. For the LVOS V2 test set, we will keep it for the challenge purpose. You can evaluate the ability of your model by using the validation set.
Feel free to contact me or raise the issue if you have any question.
Bests,
Lingyi

Thanks! Could the evaluation code of v1 be used to validate the v2?

Indeed, the evaluation code for v2 is similar to that of v1 for semi-supervised vos. However, due to the unseen video list is loaded through txt file, if you don't have the txt file for v2, you can not evaluate your model correctly. Besides, we also optimize the code to speed up the evaluation process.
Bests,
Lingyi

Looking forward to it!
Best,
MDS

Sry, we don't have the plan to release the code of OneTracker. The code of OneTracker is extremely simple. I think you can reproduce it based on ViPT easily.  If you have any question about OneTracker, feel free to contact me through email, and you can find my email from my homepage or the paper of OneTracker. Thanks for your interest on our works!

Hi, we have released the evaluation code for LVOS V2, and you can find it at here. You can set the lvos_path to switch the evaluation for v1 or v2. Please see this repo for more details.
If you have any question, feel free to let me know.
Best regards,
Lingyi

I will close it for now. Feel free to open it in case of future questions!


analysis framework

TODO on diurnal cycle

[ ] Add an agg argument to the diurnal cycle, so to aggregate to LCZ, of station (= no aggregation)
[ ] Analysis creator func in the dataset class
[ ]

[ ] test the error bands for all the diurnal aggregation functions

[ ] Convert the observation to hourly values before computing diurnal cycles.

Ready for merging if #98 is split in separate ones


Better Error Reporting / Eliminated "Silent Fails"

Is your feature request related to a problem? Please describe.
This is from one of my colleagues in proserv/Traction:

when an established rollup doesn't work (for whatever reason... bad data, unavailable records, something something) there's no kind of notification or warning that you need to take a look at it.  As a result, your reporting can be wrong for a really long time until someone thinks to take a deeper look into it and analyse the numbers themselves...

Describe the solution you'd like

If we can get a notification of some kind, error log generated, something - then we could build a process around that and get someone looking into an issue...

Notification can have:

Rollup name/ID
Parent record
Child record(s)
Issue description (in plain English)
Date

Describe alternatives you've considered

Error logs exist in scheduled incremental run mode but no others. This suggested error handling would extend to all run modes, including full schedule, realtime, Apex, etc.
Currently need to create manual exception reports and see where the discrepancies lie, somewhat defeating the purpose of the managed package and causing data trust issues

Additional context

Idea for how to fix: Error handling API for NPSP
Colleague said he had a problem with a consulting client where a lot of rework was needed because there were DLRS discrepancies and no  way to see where they were. He currently does not recommend the tool to clients.

@MelanieTolomeo do you have details about what kind of silent fails are occurring? What causes errors so we can narrow in on them?
Right now this issue is too vague to be actionable.


[WIP] Swap mapper to stochastic swap

This PR tries to remove the old swap mapper and move it towards only passes. But there are some tests that are failing :(

Closing for now, because several issues in the StochasticSwap pass.


Playground crashes immediately upon opening after iOS 14 update

Please, provide the details below:
Did you search for the problem in other open issues in this repo?
Yes, there was nothing pertaining to this specific issue.
Tell us about the problem
Recently updated my iPhone to iOS 14.1, and now the Playground app immediately crashes
Did you try it outside of {N} Playground?
This is pertaining to {N} Playground itself, not applicable.
Which browser are you using?
iOS app
Are there any errors/warnings logged in your browser console?
Cannot view console on iPhone
Which platform(s) does your issue occur on?
iOS
Are there any entries logged in the Device Logs tab?
N/A
Please provide the following information shown in the devices tab in the playground:

iPhone XS
iOS 14.1

Please tell us how to recreate the issue with as much detail as possible.
Open the app on an iPhone running iOS 14.1

I have the same issue. Just updated to ios 14.1 and the playground app doesn’t start, just crashes. Tried reinstalling playground and preview but not fixed

Same issue.

Same Issue

+1

+1

An update is now available. See https://twitter.com/NativeScript/status/1325994280003891200


Jumping between scenes stops module from working

See title. The module doesn't render the combat numbers anymore.

Fixed in 6058d5f06d5feb167eb48eb6d18f784c15429d49.


Set the gamemode for players based on their user group

Description
Automatically set the gamemode of a player based on his user group
Proposed Behaviour
For example, I have two groups called visitor and player. Whenever a player joins the server, the plugin will check the user group of that player, if the player belongs to the visitor group, the plugin will automatically set the gamemode of that player to adventure (If it's not adventure already). If the player belongs to player group, the plugin will set the gamemode of that player to survival.
Extra Details
I'm not sure if this should be posted here, if this is not the type of feature that luckperms will implement, please correct me and I will look for other plugins, thank you

This is something I personally find to not fit into a "permission manager". The plugin called "Conditional Events" can do this.

This is likely out of scope for LuckPerms. If you want players to be unable to build, you should use a plugin that does that, such as WorldGuard.

Like i said, I'm not sure if this is the type of feature that will be implemented in luckperms. I will take a look at the conditional events plugin, thanks for replying me!


[Bug] Multiple Add Column rendering problem in ^7.2

Summary of problem or feature request
Multiple Add Column with view or HTML String is not rendering very well.
It's only show one of table file as button and other is show as string.
ps: It's work well with ~6.0 but not work with ^7.2
Code snippet of problem
$query = Role::all();
return Datatables::of($query)
            ->addColumn('firsttest', function ($role) {
                  return '<button>Test</button>';
            })
            ->addColumn('secondtest', function ($role) {
                  return '<button>Test Two</button>';
            })->make(true);

System details

Operating System : MACOS
PHP Version : 7.1
Laravel Version : 5.4
Laravel-Datatables Version ^7.2

Expected behavior on v7. See upgrade guide for details. You need to use rawColumns to render html.

Thank, it's work


[Task]: Issues related to redesigning of query components to make them responsive

Is there an existing issue for this?

[X] I have searched the existing issues

SubTasks

[ ] EVALUATED VALUE dialog is overlapping on the query setting text input page. Please refer to the attached SS:-

[ ] Edit icon button is overlapping with the 3dots on the query text input page. Please refer to the attached SS:-

[ ] API editor page at the bottom all the headers are overlapping with each other. SS:-

Note:
Creating this ticket to just keep the track of the issues which are to be fixed later on as part of multipane changes.

won't fix - project cancelled


[general] Was 4.2.0 retagged?

Please, before submitting a new issue verify and check:

[ ] I tested it on latest raylib version from master branch
[x] I checked there is no similar issue already reported
[ ] My code has no errors or misuse of raylib

Issue description
I tried to redownload Raylib to check the Homebrew download still works. The Homebrew package was updated on August 12th, and the hash of the current download does not match. The GitHub page also says the 4.2.0 release was done on the 13th.
The git manual says re-tagging is "the insane thing" to do so I'd like to make sure the release isn't compromised.
Environment
macOS 13.3
Issue Screenshot

https://github.com/Homebrew/homebrew-core/actions/runs/4258446794/jobs/7409748532
Code Example
wget https://github.com/raysan5/raylib/archive/4.2.0.tar.gz
sha256sum 4.2.0.tar.gz

Then you'll notice the hash isn't 5fd2e7d825f345924800c38291f44423bcbcc036bd72fa2e3abedfc54e5b68b5 as Homebrew recorded it on the 12th of August.

Yes, it was. I'll try to avoid "insane behaviours" in future releases.


[HxGridColumn] Binding HxGridColumn Visibility to HxSwitch or HxCheckbox

I'm trying to optionally Hide some HxGridColumns, with the Visibility bound to a HxSwitch. The problem I have is that the first time the Checked-State is changed, the column visibility is not changed. Any Checked-Change afterwards triggers a visibilty change, but it is out of sync with the bound value.
I'm using a current dotnet 8 Blazor with InteractiveServer Rendering.
Here is my example, which doesn't work:
@page "/TestPage"

@rendermode InteractiveServer

TestPage

<HxSwitch @bind-Value="ShowAllColumns" Text="Show All Columns"></HxSwitch>
<HxCheckbox @bind-Value="ShowAllColumns" Text="Show All Columns"></HxCheckbox>

<HxGrid TItem="RowEntry" DataProvider="GetGridData" >
    <Columns>
        <HxGridColumn HeaderText="FirstColumn" ItemTextSelector="entry => entry.FirstColumn" Visible="ShowAllColumns"></HxGridColumn>
        <HxGridColumn HeaderText="SecondColumn" ItemTextSelector="entry => entry.SecondColumn"></HxGridColumn>
        <HxGridColumn HeaderText="ThirdColumn" ItemTextSelector="entry => entry.ThirdColumn" Visible="ShowAllColumns"></HxGridColumn>
    </Columns>
</HxGrid>

@code {
    [Parameter] public bool ShowAllColumns { get; set; }

    public record RowEntry(string FirstColumn, string SecondColumn, string ThirdColumn);

    private Task<GridDataProviderResult<RowEntry>> GetGridData(GridDataProviderRequest<RowEntry> request) {
        return Task.FromResult(request.ApplyTo(new[] {
            new RowEntry("A1", "B1", "C1"),
            new RowEntry("A2", "B2", "C2"),
            new RowEntry("A3", "B3", "C3"),
        }));
    }
}

It seems that the IsVisible state change is only reflected after the column-visibility check is already done in GetColumnsToRender.

I successfully reproduced the issue reported (BlazorAppTest/HxGrid_Issue705_Test).

It is a bug (possibly caused by the design of HxGrid where the columns are rendered first to allow their usage as templates for the grid rows).
For now, as a simple workaround you can use this code to achieve the effect you expect:
<HxGrid TItem="RowEntry" DataProvider="GetGridData">
	<Columns>
		@if (ShowAllColumns)
		{
			<HxGridColumn Order="1" HeaderText="FirstColumn" ItemTextSelector="entry => entry.FirstColumn"/>
		}

		<HxGridColumn Order="2" HeaderText="SecondColumn" ItemTextSelector="entry => entry.SecondColumn" />

		@if (ShowAllColumns)
		{
			<HxGridColumn Order="3" HeaderText="ThirdColumn" ItemTextSelector="entry => entry.ThirdColumn" />
		}
	</Columns>
</HxGrid>

Please note the Order parameter, which ensures the right order of the columns if rendered conditionally.
cc @jirikanda

(TBD: Consider marking the Visible parameter obsolete. Still the issue should be resolved as it obviously not only affect the Visible, but also other parameters of the HxGridColumn.)


ALF Automation

Brackets: Please merge this pull request created by ALF. @ArturOledzki @pantkowiak @rajjain FYI

Thanks @rawat11
Merging.


decode() got unexpected keyword argument 'verify'

I'm not sure why its causing this issue. I followed all the necessary steps and when i try to access my api endpoint it returned a internal server error 500

When i remove the Permission Classses IsAuthenticated and the problem goes away and also when i remove verify parameter from backend.py and token.py it also goes away but i don't want to remove the verify parameter because its there to verify the jwt tokens.
This is my API

Just got the same issue

Thx it works, I was just reading the opened issue


AVRO-2561: Bump hadoop dependency.

There has been several point releases in Hadoop since 2.7.3.
This bumps the version to 2.7.7 to fix a bug when using avro-tools and some recent JDKs.  See https://issues.apache.org/jira/browse/AVRO-2561 for an error which occurs when the java.version reported by the JDK is less than three characters.
Alternatively, we could switch to the -Phadoop3 profile for the default build.
Jira

[X] My PR addresses the following Avro Jira issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"

https://issues.apache.org/jira/browse/AVRO-2561
In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Tests

[X] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Testing over all possible providers of all versions of JDK would be prohibitively expensive!
Commits

[X] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[ ] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain Javadoc that explain what it does

I think we can do this for Avro 1.10. WDYT @iemejia ?

Just for info -- as a commercial distribution, Cloudera 6.0 has included Hadoop 3.0 since August 2018.  This isn't necessarily the best barometer to indicate what users are actually using, but it's reasonable for Avro to bump for 1.10!
If there were an Avro 1.9.2, bumping to 2.7.7 would probably be the lowest impact.
I mentioned in the JIRA that a really good solution would be to bypass all hadoop dependencies when reading/writing from a local file and avoid the question entirely.  Would you like me to give that a try, or create a separate JIRA?

LGTM.
It may still be too early to move to Hadoop 3 in particular because neither of the main downstream projects e.g. Spark or Flink do officially support Hadoop 3 yet. Also other distributions e.g. EMR, Dataproc are still Hadoop 2.x based.
Also let's not forget that Hadoop is a provided dependency for Avro and we have CI in place to validate that we are compatible with both Hadoop 2 and 3 (validated in the tests with a maven profile). So if users still run on Hadoop 3 things should work as expected if they provide the hadoop 3 jars. So probably better to wait a bit more.

@RyanSkraba minor annoyance, can you please verify the JIRA number, it looks like a different one, and add the explicit hadoop version in the title of the commit/issue. Thanks.

Hello!  The JIRA is the correct one.  The title of the JIRA describes the symptom... but the underlying problem is the ancient hadoop dependency and some versions of Java after JDK 1.8.


Updated supported version of MicroProfile to 5.0

According to https://helidon.io/docs/v3/#/mp/introduction

Helidon MP includes a compatible implementation of Eclipse MicroProfile 5.

(and not 3.3).

Hi, did you sign the OCA ?

Yes, I signed the OCA (this past weekend), it's under review.

/trigger

/oca-checked


make sure nothing is setting _ref in store

it looks like the preloader might still be setting the _ref in the stores of some components (or possibly the server-side saving). make sure we remove this when populating the store

seems to have been cleared up

actually, I spoke too soon. the issue wasn't _refs in the store, but rather child component data not being removed when doing cascading PUTs (e.g. when creating new components). fixed in commit 73a5125


Key error

I'm getting a KeyError while doing searches:
from steam import Steam
from apikeys import steamCreds
s = Steam(steamCreds)
a = s.apps.search_games('Isaac')

returns
KeyError                                  Traceback (most recent call last)
Cell In[59], line 1
----> 1 a = s.apps.search_games('Isaac')

File c:\Code\Miniconda3\envs\test\lib\site-packages\steam\apps.py:50, in Apps.search_games(self, term)
     48 for l in links:
     49     app = {}
---> 50     string_id = l["data-ds-appid"]
     51     href = l["href"].replace("\\", "").replace('"', "")
     52     app["id"] = int(string_id.replace("\\", "").replace('"', ""))

File c:\Code\Miniconda3\envs\test\lib\site-packages\bs4\element.py:1519, in Tag.__getitem__(self, key)
   1516 def __getitem__(self, key):
   1517     """tag[key] returns the value of the 'key' attribute for the Tag,
   1518     and throws an exception if it's not there."""
-> 1519     return self.attrs[key]

KeyError: 'data-ds-appid'

Here's the version I'm running
python-steam-api          1.0.7
Python 3.10.8
bs4 4.11.1
Works fine with certain searches, 'terr' as in the docs works. Throws this error often though.
Also throws a warning, if it's relevant (even when it works)
c:\Code\Miniconda3\envs\test\lib\site-packages\steam\apps.py:45: GuessedAtParserWarning: No parser was explicitly specified, so I'm using the best available HTML parser for this system ("lxml"). This usually isn't a problem, but if you run this code on another system, or in a different virtual environment, it may use a different parser and behave differently.

The code that caused this warning is on line 45 of the file c:\Code\Miniconda3\envs\test\lib\site-packages\steam\apps.py. To get rid of this warning, pass the additional argument 'features="lxml"' to the BeautifulSoup constructor.

@crystallikelaw will take a look tomorrow morning and try to replicate the issue. Will let you know when I patch it up!

@crystallikelaw Hey I was able to fix the issue and just patched python-steam-api  1.08 has the fix now. I added a retry decorator to have max tries of at least 3 times to make the HTTP request. But the main problem is that the Steam API does not have the capability to search for games/apps for some reason. So I ended up scrapping for that data and converting it to json basically.
So when searching for apps/games I was under the impression that each item that comes back has data-ds-appid attribute. But it does not some items have bundle IDs that I was not handling properly. For the time being, Only apps/games will be searched. Will think about handling bundles appids later!
Thank you for reaching out

@deivit24 Thanks so much for the quick fix! And yeah, I noticed about the API lacking search. I was looking for a fix and ended up using Steam's search suggestions API code here (Setris' example script, relevant function below though it's incomplete)
It handles bundles and packages too, if it's of any help. Thanks again!
# https://codereview.stackexchange.com/questions/248006/game-scraper-for-steam

SEARCH_SUGGEST_API = "https://store.steampowered.com/search/suggest"

def get_game_information(games: List[str]) -> Dict[str, Optional[SteamItem]]:
    game_to_info = {}

    with requests.Session() as session:
        for game in games:
            params = {"term": game, "f": "games", "cc": "US", "l": "english"}
            response = session.get(SEARCH_SUGGEST_API, params=params)
            response.raise_for_status()

            # get first search suggestion
            result = BeautifulSoup(response.text, "html.parser").find("a")

            if result:
                bundle_id = result.get("data-ds-bundleid")
                package_id = result.get("data-ds-packageid")
                app_id = result.get("data-ds-appid")

                if bundle_id:
                    name = result.find("div", class_="match_name").get_text()
                    bundle_data = deserialize_bundle_data(
                        result["data-ds-bundle-data"]
                    )
                    app_ids = extract_app_ids(bundle_data)
                    app_names = lookup_app_names(session, app_ids)
                    price = extract_bundle_price(bundle_data)

                    info: Optional[SteamItem] = SteamBundle(
                        bundle_id=int(bundle_id),
                        name=name,
                        price=price,
                        application_names=app_names,
                    )
                elif package_id:
                    info = get_package(session, package_id)
                elif app_id:
                    info = get_game(session, app_id)
                else:
                    info = None
            else:
                info = None

            game_to_info[game] = info

    return game_to_info

@crystallikelaw Ahhh nice might use something like this since this has all the known apis for this steam API. Thank you! Also if you ever feel like contributing then feel free to fork it! No pressure :p


Invariant Violation: Invalid prop fontSize of type string supplied to StyleSheet generated, expected number.

Hi,
I'm getting the following error:
Invariant Violation: Invalid prop `fontSize` of type `string` supplied to `StyleSheet generated`, expected `number`.

StyleSheet generated: {
  "fontSize": "1.5em",
  "lineHeight": 24,
}
This error is located at:
    in StyledNativeComponent (created by Styled(Text))
    in Styled(Text) (at myfile.js:23)

This is what I have at line 23:
<Text
          fontSize='1.5em'
          lineHeight={24}
          height={32}
    >

is putting em not supported? But I see the README having description of it being available.

Not sure what’s happening, but if you’re using React Native, I believe you have to use numbers without units

Yes I'm using React Native.

https://facebook.github.io/react-native/docs/height-and-width

All dimensions in React Native are unitless, and represent density-independent pixels.

Thanks, this helps!


⚠ Bofrost.de has degraded performance

In 7857d5d, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 817 ms

Resolved: Bofrost.de performance has improved in a65aa1f after 6 minutes.


Error with commas in margins

This plugin is awesome, for starters. ;)
I'm on a Mac with German localization and therefore, the decimal separator is a comma and not a point. The grid options in certain situations come up with 0,0 by default, which causes an error if not corrected to 0 or 0.0 manually.
Maybe you can do some sort of parsing on the input, that would be great!
By the way…Sketch has the same problem, for instance when calculating widths etc.

@dinko fixed with https://github.com/preciousforever/sketch-data-populator/commit/5f9dd947fe56bb92f384d0f8750adf3493c5115d

@dinko it's in the "development" branch. could you check it out and let us know if this fix works for you?

Sure, will try!

The fix works, thx!

@lukas77me can you merge?

Done


Allow file: with @libsql/client/web

When locally developing with Cloudflare Workers it would be cool if I could use a local sqlite instance with file:
Here is how local sqlite is implemented in Miniflare https://github.com/cloudflare/miniflare/blob/master/packages/shared/src/sqlite.ts

I'm not sure what's the proper solution here, because we have some contradictory requirements:

The @libsql/client/web import is explicitly intended to use only the Web-standard APIs (fetch and WebSocket)
The normal @libsql/client import will not work on Workers, because it uses Node bindings to SQLite
Miniflare aims to emulate Workers as closely as possible, so we need to use hacks to escape the simulation and use Node bindings to SQLite.
These hacks will likely not work when Miniflare uses the workerd runtime and not Node.

In other words, I understand that using a SQLite database for local development of Workers would be quite convenient, but it goes against the point of Miniflare, which aims to locally provide the same environment as Workers. I'm not sure how to resolve this; maybe we could provide a Worker-specific import such as @libsql/client/worker, which would support the Miniflare-specific hacks allowing the use of file: URLs locally?


add get endpoint

@osmandin New PR to address DOS-154. I also added a title property to the Digital Object class and related methods, though they don't seemed to be properly setting the title for the Digital Object, which remains null(see the commented out assert statement in ObjectServiceIT.java)

@osmandin All tests are working now

Updates made


Fix CONTRIBUTING.md link

The link is expired and I guess this is the right entry point for new contributors?

@googlebot I signed it!


Categories displaying wrong because of vue-virtual-scroller

I use this package in Quasar Framework dialog:
<q-dialog v-model="emojiPickerDialog">
	<emoji-picker :data="emojiIndex" :emojiSize="24" :native="true" @select="selectEmoji"></emoji-picker>
</q-dialog>

Here is what I get, emoji categories are not displayed properly:

BUT, when I enter any string in the search field:

And then press backspace until the search field is empty again, all goes as it should be:

I believe it's because of vue-virtual-scroller. Or maybe I am wrong?
Possible solution: remove or make vue-virtual-scroller optional as suggested in #52

@apasov I am not 100% sure this is because of virtual scroller, but it might be, I'll need to check it. Do you have by chance some minimal working example that I can run locally and debug?
Also, when the picker is rendered initially, do you see any errors in the console (there might be some if this is a javascript problem, otherwise might be related to css).

@apasov I've added a QDialog example to the demo app - https://serebrov.github.io/emoji-mart-vue/

It works fine for me, although I am not sure if I am using it the same way as you, when I just tried to insert the <picker>.. inside the <q-dialog>, it was empty, so I used body slot to show the content:

QDialog Example

      <q-btn label="Open QDialog" @click="emojiPickerDialog = true" />

    <q-dialog v-model="emojiPickerDialog">
      <template v-slot:body>
        <picker :data="index" :emojiSize="24" :native="true"></picker>
      </template>
    </q-dialog>

So I am still not sure if this issue is related to #52.

@serebrov
No, I don't see any js errors in console.
I created a working example:
https://github.com/apasov/emoji-mart-vue-error-reproduction
Please test on your local machine.
For me it almost always works wrong, especially with dev console open and mobile screen simulation in Chrome. Sometimes as if by accident it displays properly, but after you close the popup and re-open it it gets broken again.

@apasov thanks a lot for the example app, I see the issue now. I had a feeling I saw something very similar some time ago and after googling I found a link, to my surprise, to this repository :)
This is the same issue as in #50 and it is related to the virtual scroller: due to the animation of the dialog on open, virtual scroller doesn't get correct sizes for its elements (emoji categories), so the result is the overlap.
One workarond is to disable dialog animation, as mentioned in #50.
Another one is to wait a bit for animation to complete and then render the emoji picker:
<template>
    <q-btn color="primary" label="Select emoji" @click="showDialog"/>

    <q-dialog v-model="emojiPickerDialog">
        <q-card-section>
          <emoji-picker v-if="dialogRendered" :data="emojiIndex" :emojiSize="24" :native="true" @select="selectEmoji"></emoji-picker>
        </q-card-section>
    </q-dialog>
</template>

And one more solution, without v-if and looks nicer for the user, but relies on vue-virtual-scroller internals to trigger the scoller update:
<template>

          <emoji-picker ref="picker" :data="emojiIndex" :emojiSize="24" :native="true" @select="selectEmoji"></emoji-picker>
</template>

@serebrov  thank you for the quick fix!
Aha, I see #50 is also related to Quasar Dialog.
I used StaticPicker and it just worked perfectly.
Maybe later I will try some of the workaronds, but currently StaticPicker is good enough for my project.
Thanks again!


screenrecord detection

Hi, this is a very handy and useful library thank you very much. Please make a screen record observer too if possible.

Not sure if it's possible technically.


I have 2 problems.

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
OS Version:

Steps to Reproduce:

I wrote a sample post. I don't want to see the error red line at the bottom of the text. How can I do it.

There are 2 problems under the problems. Even if there is an error in the code, I don't want to see the error notification under the problems. How can I do it.

Sel language mode to Plain Text

Dil modunu Düz Metin olarak ayarlayın

Sir, I couldn't. Can you tell me with a photo?

@coder65536 Please try changing the language mode to Plain Text otherwise file an issue against Python extension if you want to configure the problems

Sir, I made prose, but the tools in this photo are not visible. The vehicles in this photo I want should appear. But underlined errors and errors should not appear in the problems section next to the terminal .


[QUESTION] - Connection is auto closed after some time. How to keep the connection alive?

It seems the connection is dropped after a minute or two.
Here's a pcap file for the requests
connection-dropped.zip
How can I make sure the connection is alive until I stop?
Also How can I rebind the connection in case the connection is closed?
Related video: https://storyxpress.co/video/ks0714xl10giqbkct

https://github.com/M2MGateway/go-smpp/blob/6c6ef183a2dd9e8ff6b928b5127244d9a48b0b7e/cmd/smpp-receiver/main.go#L84-L89

suggest, yourself implementation connection manage "class", replace my conn.go implementation

If you do not like the default conn.go implementation, you can easily replace it.

from README

@septs Thanks I'll try it. I'm trying to implement multiple session per SMSC along with throttling

@septs I noticed that I could avoid constant rebinding if I set EnquiryInterval (30 sec) lower than EnquiryTimeout (1 min)


Uncaught (in promise): TypeError: scrollIntoViewIfNeeded is not a function

I'm getting following error, as well on local project where I'm implementing ng2-tour, as in demo-project forked from github...
EXCEPTION: Uncaught (in promise): TypeError: scrollIntoViewIfNeeded is not a function
TypeError: scrollIntoViewIfNeeded is not a function
    at TourAnchorNgBootstrapDirective.showTourStep

(scroll-into-view-if-needed version 1.1.0)

Should be fixed in version 0.1.6 via PR #12 .  Let me know if its still broken.

issue seems to be fixed. Thanks a lot
(off topic / fyi: on https://isaacplmann.github.io/ng2-tour/ there's a new exception thrown. On my local machine I don't have that problem)

Thanks for the heads up.  I’ll look into that.

On May 15, 2017, at 9:13 AM, Benedikt Beun<EMAIL_ADDRESS>wrote:
issue seems to be fixed. Thanks a lot
(off topic / fyi: on https://isaacplmann.github.io/ng2-tour/ https://isaacplmann.github.io/ng2-tour/ there's a new exception thrown. On my local machine I don't have that problem)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/ng2-tour/issues/18#issuecomment-301470843, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0lQAOJtmE4_PJ3BRMtDIhdPIOnMozNks5r6E-JgaJpZM4NbGeS.


Use prefixed commands rather than flags #63

added prefixed commands with prefix g:simplenote_prefix
fixed misprint in doc/simplenote.txt

Thanks for doing this! If @mrtazz approves I'd like to have these prefixed commands be the default:

Update the command references in README and doc
Hardcode the command names instead of using g:simplenote_prefix

I'll try to take a look over this weekend.

Actually made good progress soon. If I don't finish it up soon I'll push what I have to this pull request so you can at least see what I'm in the middle of doing.

As promised, just pushed the work-in-progress stuff. Snowed under with work at the moment so it's taking me longer than expected to finish this off.

What the hell, that branch doesn't seem to work at all now. I need some un-tired time to do this.

Ok, I've started sorting out the mess I've made. I should hopefully get something pushed up later today.
Wooo... opensource can be embarrassing.


Infinite scroll loader being displayed when table data filtered

Describe the bug
With the Column Filter feature built in #8, we can now filter table data by selecting values from a dropdown. This results in infiniteLoader being displayed indefinitely.
To Reproduce
Steps to reproduce the behaviour:

Click on F on any column.
Select a filter value

Expected behavior
If filtered data does not require scroll, we should not show loading data.
Screenshots

Desktop (please complete the following information):

OS: macOS
Browser: Chrome, Safari, Firefox
Version: latest

Additional context
I think we should redo the infinite loading logic and make it simpler.

@samrith-s , using infinite scrolling with local data filtering isn't a valid use case. In order for them to work together filtering must take place on BE which should return an updated total filtered row count.
For now I think the easiest fix is simply to make a few demo pages: one for filtering and one for infinite scroll.

@dmitriy-kudelko We have decided to move the filtering to the user. So now we will not do the filtering. But the infinite scroller stuck at the bottom issues is not related to filtering. If we reduce the rows count to 3-4, then also we face the same issue.

Ok. But this is a different issue really which has nothing to do with the description above. I'll check this when I have time - should be easy to fix.


[webapi] Update xml to support subcase mode for sse

Impacted tests(approved): new 12, update 0, delete 0
Unit test platform: Crosswalk for Android 15.44.384
Unit result summary: pass 66, fail 11, block 2
https://crosswalk-project.org/jira/browse/XWALK-4770

Though such kind of update makes the commit history ugly, we have to accept it firstly because separating them will be a waster of time.
@kangxu and @haoxli will make 2 new pull requests for the rest test suites to be updated: one is for the XML files format and the other is for real change. Therefore, merge this PR as-is.


Path Mapping is not properly work

RxJS version:
6.0.0-alpha.3
Code to reproduce:
import { of } from 'rxjs';
import { map } from 'rxjs/operators';
import { ajax } from 'rxjs/ajax';
import { websocket } from 'rxjs/websocket';
import { TestScheduler } from 'rxjs/testing';

with webpack configuration for _esm5 described in doc/pipeable-operators.md#build-and-treeshaking
FYI: reproduced in webpack 3.11.0 & 4.0.0-beta.2
Expected behavior:
All import paths are mapped into _esm5 directory.
Actual behavior:
All import paths are mapped into root directory, not in _esm5.
Additional information:
import { of } from 'rxjs/index';
import { map } from 'rxjs/operators/index';
import { ajax } from 'rxjs/ajax/index';
import { websocket } from 'rxjs/websocket/index';
import { TestScheduler } from 'rxjs/testing/index';

works as expected.

cc @jasonaden

Hi @berlysia !
As this is quite a while ago, is it probably already solved?
If yes please close that one. Otherwise please give a quick update of the current status.

This issue is already solved in v6.0.0 and also in v6.5.3. :sparkles:


Rename databases in DO to more easily distinguish prod vs staging

DigitalOcean doesn't (yet) support renaming databases.
See this community forum answer and this idea (feature request).

…but this is already solved using tags.

Closing this issue.


Add Netlify configuration

Allows us to deploy the front-end with a fair amount of ease.
We can use a service (Netlify) to automatically publish our front-end with every commit. The current drawback is we need different .env files depending if we're production or development. For now we can do this manually.
We can talk about adding more automation/scripts later on.
Changes:

added config that will allow netlify to automatically build from our git
added options to Django to open CORS up to everything

An example of a deployment (should work if you have your local Django running)

I'll merge this in in a few days if no reviews come in


added create table sql

Should we improve the tables in our database? It looks like three separate tables. Or should we use this one first and improve it later?

Should we improve the tables in our database? It looks like three separate tables. Or should we use this one first and improve it later?

it's for the current stage and only for users, chargers and accounts. please do not use it for other services

Thanks for the clarification


Driver not working with JamVM

Hello,
I'm using this driver in a embedded system. If i launch it with java -jar MyProgramm.jar it is working (but really slow)
I chose JamVM for performance reasons, but when i invoke it with: java -jamvm -jar MyProgramm.jar
i get the exception not found java.lang.ClassNotFoundException: org.sqlite.JDBC. The library is in the package inside MyProgramm.jar. I also tried giving the -classpath with -classpath ".:sqlite-jdbc-<IP_ADDRESS>.jar" but is also not working.
Any experience with JamVM and this library ? Or any idea why is it not working?
Thank you

I like the juxtaposition of these two phrases....

... this driver ...  is working (but really slow)
I chose JamVM for performance reasons

Sorry, I have no experience with JamVM.  Clearly this sounds like a JamVM issue.  Is that even actively developed anymore?

JamVm is compact but slow. Its a bytecode interpreter. So it doesn't surprise me if your code is slow.

I'm afraid, but I think we won't solve this issue.


A conditional directive in profiles

I don't want these to be a reimplementation of existing automations. That would confuse users, make debugging harder, and add complexity. I think the way to think about a conditional directive is "why did the user {change a setting, start/stop/pause a job} in the UI?"
Some use cases (ignoring technical limitations):

if the turbidostat is running too frequently and not able to keep up with a high growth-rate culture, we should increase the volume removed.
if running a chemostat, and the OD drops below some threshold, we risk washing out the culture. We should reduce the volume / increase the duration.
If OD exceeds some threshold, then start chemostat.
In a phage set up, start feeding / chemostat when the source bioreactor (full of bacteria) exceeds some OD target.

I like the github actions style:
common:
  stirring:
    actions:
      - type: start
        hours_elapsed: 0.0
        options:
          target_rpm: 400.0
      - type: update
        hours_elapsed: 0.025
        if: <some conditional as a string>
        options:
          target_rpm: 800.0

The conditionals can be like <job_name.published_setting> {==,<=,<,>,>=} <some value>. This is becoming really complex!

if the turbidostat is running too frequently and not able to keep up with a high growth-rate culture, we should increase the volume removed.

type: update
if: p:growth_rate_calculating:growth_rate.growth_rate > 1.5
hours_elapsed: 24
options:
  volume: 2.0

if running a chemostat, and the OD drops below some threshold, we risk washing out the culture. We should reduce the volume / increase the duration.

type: update
if: p:od_reading:od1.od <= 1.0
hours_elapsed: 6
options:
  duration: 60

If OD exceeds some threshold, then start chemostat.

dosing_control:
  type: start
  if: p:od_reading:od1.od >= 5
  hours_elapsed: 12
  options:
    automation_name: chemostat
    duration: 20.0
    volume: 1.0

In a phage set up, start feeding / chemostat when the source bioreactor (full of bacteria) exceeds some OD target.

pioreactors:
  phage:
    jobs:
      dosing_control:
        type: start
        if: source:od_reading:od1.od >= 5
        hours_elapsed: 12
        options:
          automation_name: chemostat
          duration: 20.0
          volume: 1.0
  source:
    jobs:
      dosing_control:
        type: start
        hours_elapsed: 0
        options:
          automation_name: chemostat
          duration: 20.0
          volume: 1.0


saving relations through associated _id?

Sorry if this has been asked/answered before, but is it possible to save an associated record bij having its _id (uuid) in the attributes, same as ActiveModel? I suppose this is a very SQL-y thing to ask, but a lot of exposed API and web forms rely on this behaviour.
Book.create(author_id: '1f2b30efwf23e3')

I think that it's done by giving it a key matching the association name containing an array of ids.
Book.create(authors: [1f2b30efwf23e3'])

Thanks, that (mostly) works. But in playing around with this I ran into a strange bug. Consider the following testcase and the error below.  I update the author by object here, but the same error occurs when updating by author.id. Is there something I'm doing wrong (I am 1 day into neo4j)?
require "test_helpers"

class Reader
  include Neo4j::ActiveNode
  has_one :out, :book, origin: :reader
  property :name
end

class Book
  include Neo4j::ActiveNode
  has_one :in, :author, type: :written_by
  has_one :in, :reader, type: :reading
  property :title
end

class Author
  include Neo4j::ActiveNode
  has_many :out, :books, type: :wrote
  property :name
end

class AssociationsTest < Minitest::Test

  def setup
    @book = Book.create(title: "Book")
    @author = Author.create(name: "Author")
    @author_2 = Author.create(name: "Author 2")
    @reader = Reader.create name: "Reader"
    @reader.book = @book
  end

  def teardown
    # Reader.destroy_all
    # Book.destroy_all
    # Author.destroy_all
  end

  def test_passes
    @reader.book.update_attributes author: @author_2
    assert_equal @author_2, @reader.book.author
  end

  # passes only when teardown is enabled
  def test_fails
    reader = Reader.find_by name: "Reader"
    reader.book.update_attributes author: @author_2
    assert_equal @author_2, reader.book.author
  end

end

When I run this test I get this error:
Error:
AssociationsTest#test_fails:
TypeError: no implicit conversion of Symbol into Integer
  /vendor/bundle/gems/neo4j-core-5.0.0/lib/neo4j-server/cypher_response.rb:104:in `[]'
  /vendor/bundle/gems/neo4j-core-5.0.0/lib/neo4j-server/cypher_response.rb:104:in `looks_like_an_object?'
  /vendor/bundle/gems/neo4j-core-5.0.0/lib/neo4j-server/cypher_response.rb:78:in `map_row_value'
  /vendor/bundle/gems/neo4j-core-5.0.0/lib/neo4j-server/cypher_response.rb:81:in `block in map_row_value'
  /vendor/bundle/gems/neo4j-core-5.0.0/lib/neo4j-server/cypher_response.rb:81:in `map!'
  /vendor/bundle/gems/neo4j-core-5.0.0/lib/neo4j-server/cypher_response.rb:81:in `map_row_value'
  /vendor/bundle/gems/neo4j-core-5.0.0/lib/neo4j-server/cypher_response.rb:71:in `block (2 levels) in row_pair_in_struct'
  /vendor/bundle/gems/neo4j-core-5.0.0/lib/neo4j-server/cypher_response.rb:70:in `each_pair'
  /vendor/bundle/gems/neo4j-core-5.0.0/lib/neo4j-server/cypher_response.rb:70:in `block in row_pair_in_struct'
  /vendor/bundle/gems/neo4j-core-5.0.0/lib/neo4j-server/cypher_response.rb:69:in `tap'
  /vendor/bundle/gems/neo4j-core-5.0.0/lib/neo4j-server/cypher_response.rb:69:in `row_pair_in_struct'
  /vendor/bundle/gems/neo4j-core-5.0.0/lib/neo4j-server/cypher_response.rb:62:in `block (2 levels) in to_node_enumeration'
  /vendor/bundle/gems/neo4j-core-5.0.0/lib/neo4j-server/cypher_response.rb:41:in `block in each'
  /vendor/bundle/gems/neo4j-core-5.0.0/lib/neo4j-server/cypher_response.rb:183:in `block in each_data_row'
  /vendor/bundle/gems/neo4j-core-5.0.0/lib/neo4j-server/cypher_response.rb:183:in `each'
  /vendor/bundle/gems/neo4j-core-5.0.0/lib/neo4j-server/cypher_response.rb:183:in `each_data_row'
  /vendor/bundle/gems/neo4j-core-5.0.0/lib/neo4j-server/cypher_response.rb:40:in `each'
  /vendor/bundle/gems/neo4j-core-5.0.0/lib/neo4j-server/cypher_response.rb:60:in `block in to_node_enumeration'
  /vendor/bundle/gems/neo4j-core-5.0.0/lib/neo4j-core/query.rb:201:in `each'
  /vendor/bundle/gems/neo4j-core-5.0.0/lib/neo4j-core/query.rb:201:in `each'
  /vendor/bundle/gems/neo4j-core-5.0.0/lib/neo4j-core/query.rb:201:in `each'
  /vendor/bundle/gems/neo4j-core-5.0.0/lib/neo4j-core/query.rb:239:in `map'
  /vendor/bundle/gems/neo4j-core-5.0.0/lib/neo4j-core/query.rb:239:in `pluck'
  /vendor/bundle/gems/neo4j-5.0.0/lib/neo4j/active_node/query/query_proxy_enumerable.rb:52:in `pluck'
  /vendor/bundle/gems/neo4j-5.0.0/lib/neo4j/active_node/has_n.rb:175:in `previous_association_proxy_results_by_previous_id'
  /vendor/bundle/gems/neo4j-5.0.0/lib/neo4j/active_node/has_n.rb:150:in `block in association_proxy'
  /vendor/bundle/gems/neo4j-5.0.0/lib/neo4j/active_node/has_n.rb:136:in `block in association_proxy_cache_fetch'
  /vendor/bundle/gems/neo4j-5.0.0/lib/neo4j/active_node/has_n.rb:135:in `fetch'
  /vendor/bundle/gems/neo4j-5.0.0/lib/neo4j/active_node/has_n.rb:135:in `association_proxy_cache_fetch'
  /vendor/bundle/gems/neo4j-5.0.0/lib/neo4j/active_node/has_n.rb:148:in `association_proxy'
  /vendor/bundle/gems/neo4j-5.0.0/lib/neo4j/active_node/has_n.rb:353:in `block (2 levels) in define_has_one_setter'
  /vendor/bundle/gems/neo4j-core-5.0.0/lib/neo4j/transaction.rb:82:in `run'
  /vendor/bundle/gems/neo4j-5.0.0/lib/neo4j/active_node/has_n.rb:353:in `block in define_has_one_setter'
  /vendor/bundle/gems/active_attr-0.8.5/lib/active_attr/mass_assignment.rb:41:in `block in assign_attributes'
  /vendor/bundle/gems/active_attr-0.8.5/lib/active_attr/mass_assignment.rb:39:in `each'
  /vendor/bundle/gems/active_attr-0.8.5/lib/active_attr/mass_assignment.rb:39:in `assign_attributes'
  /vendor/bundle/gems/active_attr-0.8.5/lib/active_attr/mass_assignment.rb:56:in `attributes='
  /vendor/bundle/gems/neo4j-5.0.0/lib/neo4j/shared/persistence.rb:122:in `update'
  /test/associations_test.rb:46:in `test_fails'

That is interesting! Definitely a bug. I have a hunch about what's going on but give me a moment to get this setup on my end to confirm.

Returning arrays appears to be broken within transactions. I think I have a fix, just need a few more minutes to test it.

https://github.com/neo4jrb/neo4j-core/pull/213 will fix this. Once tests pass, I'll release it as neo4j-core 5.0.1, then I'll do a new release of this gem with the same version number.

Released 5.0.1, let us know if you have any trouble.

Fantastic, what a response. Works for me now.
But back on topic, I now need to be converting lots of abc_id and abc_ids attributes to abc / abcs. Is there maybe a hook or callback in neo4j that allows me to do that globally or do I have to implement something myself at the controller level?

There's nothing at the moment that will do that for you. https://github.com/neo4jrb/neo4j/blob/72320a3b817e526947ed7f8684062fb3d2c83477/lib/neo4j/active_node/property.rb#L15 is as far as it goes right now. If this is something that ActiveRecord provides, it'd be nice to implement it in the gem.

If this is something that ActiveRecord provides, it'd be nice to implement it in the gem.

I would go as far as calling it one of the defining characteristics of AR. I am talking about the association reflection (translating _id and _ids to relations) of course, not so much about the sequence of callbacks it provides.
To me providing an explicit way of relating via id vs relating via object is more elegant too, compared to neo4jrb's current combined solution.

Allright, this doesn't seem to get much traction so I will close the issue. But I reiterate: calling this gem 'ActiveRecord compliant' and not support this feature is a bit of a stretch. But we can work around it, so it's not a huge deal.

I wouldn't say that it doesn't have traction, it's just not something that can happen in 72 hours. ActiveModel compliance and ActiveRecord compliant are a bit different -- we claim the former, not the latter, though we're always interested in closing the gap between their public API and ours.
As an open source project with only a few regular contributors, it's sometimes tough to balance our day jobs, our personal projects/priorities within the gem, and requests from issues. If something is of high priority to you but it doesn't seem like it is to us, I think the best thing to do is work on a pull request to add the feature, or stop by the Gitter chat room during the day to poke us for action.

Sorry, I didn't mean to come across as unappreciative or overly critical, I greatly admire and value the work you are doing. But I have seen this issue brought up by several people on this list over a longer period of time without much success, so that's why I closed the issue.
BTW, on the home page it says "It tries to follow API conventions established by ActiveRecord", so I guess that's where the expectation comes from? Thanks again, and I will see about that PR.

It's ok, and I totally understand that it's frustrating to feel like something should work and it just doesn't. You're right, this has been requested for a long time. We'd love for it to be in there but there's been a lot of ground to cover over the past year+.
Association reflection is something that I started working on a long time ago. I was pursuing support for one of the nicer form helper gems and found that there was just too much work to be done in one sitting. My lack of familiarity with ActiveRecord and its internals definitely didn't help. The researched yielded a few small features for the gem but I couldn't go all the way. I think we're in a much better place now to implement more of the features that AR relies on to provide this stuff, but it'd definitely help if you and/or other AR-users who need the features were either at the wheel or helping us along.

Gotcha.  FYI: I am looking into using neo4j&ruby in a high profile production setting so I have a vested interest to make neo4jrb as good as it can be. For now I am working around the _id limitation by converting the incoming params hash, but it sure would be nice if it worked out of the box.
So since this is my actual day job, I will definitely look into this and try to move it forward. Any pointers on where to possibly make the necessary changes would be greatly appreciated.

On 28 jun. 2015, at 22:52, Chris Grigg<EMAIL_ADDRESS>wrote:
It's ok, and I totally understand that it's frustrating to feel like something should work and it just doesn't. You're right, this has been requested for a long time. We'd love for it to be in there but there's been a lot of ground to cover over the past year+.
Association reflection is something that I started working on a long time ago. I was pursuing support for one of the nicer form helper gems and found that there was just too much work to be done in one sitting. My lack of familiarity with ActiveRecord and its internals definitely didn't help. The researched yielded a few small features for the gem but I couldn't go all the way. I think we're in a much better place now to implement more of the features that AR relies on to provide this stuff, but it'd definitely help if you and/or other AR-users who need the features were either at the wheel or helping us along.
—
Reply to this email directly or view it on GitHub https://github.com/neo4jrb/neo4j/issues/845#issuecomment-116333317.

Awesome! That's great to hear. I'm also using it in a similar setting and get to spend time during the day fixing things and adding stuff that seems reasonable, but we're a Sinatra environment with a JSON API so things like this tend to be off my radar.
When you have time, pop into the Gitter room and I can point you in the right direction. Brian and I are usually there all day during the workday. In the meantime, you could possibly hack this into https://github.com/neo4jrb/neo4j/blob/72320a3b817e526947ed7f8684062fb3d2c83477/lib/neo4j/active_node/property.rb#L15. You might also want to investigate creating the #{association}_id methods when the association is defined, https://github.com/neo4jrb/neo4j/blob/master/lib/neo4j/active_node/has_n.rb, but the whole "handling-of-non-persisted-nodes" things might make things tricky.


[presets] Add clang install to bots that test indexstore-db/sourcekit-lsp

At a minimum, we need to install libIndexStore to enable testing the indexer, but it's better to also include clang, clangd, and libcxx, since (a) this makes these bots closer to the config of the "package" bots, and (b) this lets us enable all of our indexer tests that require clang[d]. This commit copies the swift-install-components and llvm-install-components from the package bots.
In addition to the sourcekit-lsp/indexstore-db PR test bots, this affects the following bots that test indexstore-db and didn't already install clang:

Linux

incremental
incremental long test
swiftpm PR test

macOS

PR test
PR smoke test
incremental
swiftpm PR test

Based on looking at recent build logs for the package bots, this should only add <5 seconds to the incremental build.

@swift-ci please smoke test

@swift-ci please build toolchain

@swift-ci please test

Heads up @hyp and @shahmishal.

Build failed
Swift Test Linux Platform
Git Sha - 284650b5f91fd2549cbbe5046a5d690c696728a2

macOS Toolchain
Download Toolchain
Git Sha - 284650b5f91fd2549cbbe5046a5d690c696728a2
Install command
tar -zxf  swift-PR-26300-340-osx.tar.gz --directory ~/

Build failed
Swift Test OS X Platform
Git Sha - 284650b5f91fd2549cbbe5046a5d690c696728a2

Linux Toolchain (Ubuntu 16.04)
Download Toolchain
Git Sha - 284650b5f91fd2549cbbe5046a5d690c696728a2
Install command
tar zxf  swift-PR-26300-261-ubuntu16.04.tar.gz
More info

@swift-ci please smoke test

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 284650b5f91fd2549cbbe5046a5d690c696728a2

Build failed
Swift Test Linux Platform
Git Sha - 284650b5f91fd2549cbbe5046a5d690c696728a2

@benlangmuir do you think we can get away without installing libcxx? I'm not sure what kind of tests you have in mind though.

@hyp if we install clang in the toolchain it will get used when building sourcekit-lsp/indexstore-db, which needs the c++ headers.  Just for testing we could maybe find a workaround, but it's simpler and probably more robust for our bots to behave more like the package bots.

@swift-ci please test

@swift-ci please smoke test


Generate SQL - unwrap

It would be greate to export SQL statements in 1 line without line wraping:
INSERT INTO table (a, b, c) VALUES (1, 2, 3);
INSERT INTO table (a, b, c) VALUES (4, 5, 6);
...

This should be an optional feature then.

Yes, it would be great to have such an option.
With this (1 statement is 1 line) layout it's much easier to modify the generated script with a multiline editor like Notepad++ for example.

I agree - 1 insert per line is much more readable and manageable than having it split in 3 lines. If some people prefer it in split form then this should be an option.

This is already supported.
Just set parameter "Data rows per statement" to 1.

Oh, I see it's only available from the  / Export Table Data menu.
It would be great to have a similar option on the "Generate SQL" option as well,
because then the selected rows/columns are much easier to be given.

Yes, "Generate SQL" option is very convenient and it would be great to have one-line inserts there.
Also, after adding rows to a table and pressing "Script" before saving it would also be good to have one-line inserts. It's strange but this script shows 2-line inserts now while "Generate SQL" creates 3-line inserts.

Ah, do you mean line feeds in INSERT queries? We could add special option for "compacting": queries.
That's easy to implement:

But this won't work in case of Script preview.

Cool, thanks Serge!

Wonderful!


C# - enable GRPC_CSHARP_SUPPORT_SYSTEM_MEMORY on the net45 TFM

Context: https://github.com/grpc/grpc/pull/19460#issuecomment-505898866

This will switch the net45 assembly to using Span<> internally, which seems to be fine (based on previous discussion on #19460), but we haven't verified yet if that still works on Unity (when il2cpp is used).

CC @apolcyn @juntaoluo @JamesNK

If things go well, this will be superseded by https://github.com/grpc/grpc/pull/19569 (which also gets rid of a lot of complexity).

Superseded by https://github.com/grpc/grpc/pull/19569


docs: improve README to fix #5

@dfabulich if you have time, would you mind reviewing this update to the README and tell me what you think? You can preview it directly at https://github.com/arxanas/git-branchless/tree/readme

This is a huge improvement!

Thanks for looking it over :)


add alias gh=git help

I've renamed the alias to ghh because it conflicted with several tools, see 76821f50.


docs: Update Node.js builder docs

Adds a "known issues" section.
Adds instructions on how to custom publish without using the publish action.

Related #2322

We haven't GAed the Node.js builder yet
On Fri, Aug 4, 2023, 01:44 laurentsimon @.***> wrote:

@.**** approved this pull request.
Also update
https://github.com/slsa-framework/slsa-github-generator#builders to say
nodejs is now GA
—
Reply to this email directly, view it on GitHub
https://github.com/slsa-framework/slsa-github-generator/pull/2282#pullrequestreview-1561493327,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAMBCJSMHSHNU2ECKJNMETXTPIOVANCNFSM6AAAAAAZFRWHRI
.
You are receiving this because you authored the thread.Message ID:
@.***
com>

We haven't GAed the Node.js builder yet

I thought the release was to GA it...

We haven't GAed the Node.js builder yet

I thought the release was to GA it...

This release is to fix some blocking bugs.


Correction on password expiration

Hi
On the Azure AD 2.0 password expiration section, shouldn't it be firstly to use Connect-AzureAD ? Then to use Set-AzureAdUser?
It currently has the on-prem connection steps I think?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 05282aa8-ae14-117b-5885-7d851ee66b89
Version Independent ID: 85abe13c-d34c-f42c-e273-a69be8cd991e
Content: Create resource accounts for rooms and shared Teams devices - Microsoft Teams
Content Source: Teams/rooms/with-office-365.md
Service: msteams
GitHub Login: @cazawideh
Microsoft Alias: czawideh

Thank you for submitting feedback and contributing to the docs. We are currently investigating this.