Improve handling of peers that aren't synced

When evaluating the fitness and usefulness of an outbound peer, the code would incorrectly calculate the amount of time that the peer spent in a non-useful state.
This commit, if merged, corrects the calculation and makes the timeout values configurable by server operators.
Two new options are introduced in the 'overlay' stanza of the config file. The default values are:
[overlay]
max_unknown_time = 5 minutes
max_insane_time = 90 seconds

Can we use something other than "insane", at least in the new code / options? Some suggestions that capture the same intent as well or better: "noncompliant", "unsynced", "divergent", "misaligned", "offtrack", "different"...

If we are going to change "insane", I vote for "divergent"

Plaid?  Maybe not. ;-)

FWIW, I'm wondering what evidence we have that server operators will want to use the new config options.  If there isn't significant evidence of their utility I'd be inclined to not include them.

FWIW, I'm wondering what evidence we have that server operators will want to use the new config options. If there isn't significant evidence of their utility I'd be inclined to not include them.

I hear you. Chances are that most operators will not use these new options and that's fine. However, operators of high-capacity hubs may feel inclined to adjust things; also we (Ripple) will probably be using these options to adjust the behavior of our servers.

FWIW, I'm wondering what evidence we have that server operators will want to use the new config options. If there isn't significant evidence of their utility I'd be inclined to not include them.

It would certainly benefit default hubs. On the zaphod pool, there are valuable slots that are occupied by peers of insane/unknown status. Some for a very long period of time.
In relation to this, what could be the possible mechanism to ensure that they don't reconnect immediately? Thereby setting the time counter back to zero.

I'm not seeing any unit tests being added in this pull request.  The code coverage report also shows that the new SECTION_OVERLAY handling in Config.cpp is not touched by tests.  Seems like that ought to be fixed before this pull request is merged.

Using grep shows that there are still references in the code to "sane", "insane".  Some of the files include LedgerMaster.cpp, Ledger.cpp, Application.cpp, and PeerImp.cpp.  Here's a commit where I attempted to address the cases that I found: https://github.com/scottschurr/rippled/commit/fe67f191196e6c7ec444c0e04d4ff58f9f3fedaf
BTW, all of the references to "sanity" look fine.

I'm not seeing any unit tests being added in this pull request. The code coverage report also shows that the new SECTION_OVERLAY handling in Config.cpp is not touched by tests. Seems like that ought to be fixed before this pull request is merged.

Thanks! I'll add unit tests for the config changes. The PING/PONG handlers can't be tested via unit tests since they require networking.

While it might be nice to see "minutes" and "seconds" written somewhere, I personally prefer sticking to SI units (so only "seconds"). See for example the "90 seconds" default value instead of "1.5 minutes" or "1 minute 30 seconds".
On the sane/insane naming debate: an "insane" peer currently is just likely on a different chain or at least on a fork of the current one. "divergent" or "forked" (might sound to much like an euphemism for "fucked" to native speakers?) also would be the ones that I can think of. You could also just call them "byzantine"?

While it might be nice to see "minutes" and "seconds" written somewhere, I personally prefer sticking to SI units (so only "seconds"). See for example the "90 seconds" default value instead of "1.5 minutes" or "1 minute 30 seconds".

I’m happy to limit this to only seconds; my thought was that “15 minutes” is better than “900 seconds” but it does add complexity and confusion. For example “5 minutes 17 seconds” isn’t supported: it’s either “minutes” or “seconds”.
In fact, removing the unit and just leaving a number simplifies things and avoids weird corner cases too (e.g.: “1 seconds” or “75 second” or “15 sec”)

On the sane/insane naming debate: an "insane" peer currently is just likely on a different chain or at least on a fork of the current one. "divergent" or "forked" (might sound to much like an euphemism for "fucked" to native speakers?) also would be the ones that I can think of. You could also just call them "byzantine"?

I think Byzantine has implications in this space that may or may not apply here. I am ok with “diverged”, “unknown” and “converged” and will stick with those unless someone has a concrete and well-justified objection.

FWIW, the most recent push has a unit test failure on MacOS.  If I run build/rippled --unittest=Config I get the following results:
ripple.core.Config legacy
ripple.core.Config database_path
Loading: "testSetup12/rippled.cfg"
Skipping rm dir: test_db1
ripple.core.Config validator keys
ripple.core.Config validators_file
Skipping rm dir: test_cfg6
Skipping rm dir: test_cfg7
Skipping rm dir: test_cfg8
Skipping rm dir: test_cfg9
Skipping rm dir: test_cfg9
Loading: "testSetup12/rippled.cfg"
Loading: "testSetup13/rippled.cfg"
Loading: "testSetup13/rippled.cfg"
ripple.core.Config amendment
ripple.core.Config overlay: unknown time
#10 failed: Config_test.cpp(1103)
ripple.core.Config overlay: diverged time
327ms, 1 suite, 7 cases, 252 tests total, 1 failure

Also, as noted above, I think this introduces non-versioned API changes that would, most likely, break known consumers of this API. It may not be a significant number of consumers and I think the changes are surmountable but at a minimum we would need to include details in the release notes that would clarify the actions necessary to adapt to the changes.

@scottschurr thanks for commenting again; I had forgotten about this PR. Out of sight, out of mind...
@mDuo13: what would your preferred solution here? Simply documenting the change? Having a versioned API is going to be a challenge because we do not have any idea about RPC versioning at the point of the actual code change, nor a particularly easy way of passing a hint in, without requiring significant changes along the call-chain.

@nbougalis Would it be possible to add a "post-processing" step to the actual API method (Peers.cpp) to add the "sanity" field with the appropriate values if the command is using API v1? It looks like that method already walks through the peer list and adds or modifies some fields.

I can look into it, @mDuo13.

I notice that the pull request has not yet addressed @mDuo13's concerns about the unversioned API change.
FWIW, arguing that it is hard to get the current API version down to the place that is generating the JSON is not really true, as far as I can see...

The JsonContext knows the apiVersion: https://github.com/ripple/rippled/blob/develop/src/ripple/rpc/Context.h#L50
doPeers() therefore knows the API Version, since it is passed a JsonContext: https://github.com/ripple/rippled/blob/develop/src/ripple/rpc/handlers/Peers.cpp#L31
doPeers() directly calls Overlay::json(): https://github.com/ripple/rippled/blob/develop/src/ripple/rpc/handlers/Peers.cpp#L36
Overlay::json() directly calls Peer::json(): https://github.com/ripple/rippled/blob/develop/src/ripple/overlay/impl/OverlayImpl.cpp#L1004
Peer::json() directly generates the JSON in question: https://github.com/ripple/rippled/blob/develop/src/ripple/overlay/impl/PeerImp.cpp#L361-L374

If we were to pass the apiVersion from doPeers() to Overlay::json() to Peer::json() the change in text would be easy to version.
I'm not arguing that passing the API version into members of the Overlay tree is pretty.  But in my view the real squeak in this wheel comes from two elements of the Overlay tree directly producing JSON that is emitted to the user.  As long as

random locations in our code base produce user facing JSON (and they are ubiquitous),
and we support API versioning (which we started claiming we do within the last year),

then passing the apiVersion down through call chains will be inevitable.
Here's a commit (lacking unit tests) that outlines the changes described above: https://github.com/scottschurr/rippled/commit/bdad6651088fdd48980489914c921109e4867306

I appreciate you doing this fix @scottschurr. For the record, I think that it's important to point out two things: (1) that this is an admin API so it has limited impact and (2) I suspect that it's almost always called via command line, where the API cannot be specified anyways.
My own fix, rather than passing anything in Overlay::json, was to simply add a post-processing step in doPeers(). So I'll adopt that, fold it into here and re-sign everything.

@scottschurr, @mDuo13: I've pushed a fix directly in the rollup PR to address the issue: https://github.com/ripple/rippled/pull/3675/commits/0a7d81c5d4531c214377b54ed44ccec346e36792.
Without the fix:
{
   "result" : {
      "cluster" : {},
      "peers" : [
         {
            "address" : "<IP_ADDRESS>:51235",
            "ledger" : "35F1522A2A0AC39E2B029B3851242872BA13647AFE71C8847E49FAB4625CD3AD",
            "load" : 4,
            "metrics" : {
               "avg_bps_recv" : "0",
               "avg_bps_sent" : "0",
               "total_bytes_recv" : "29753",
               "total_bytes_sent" : "29480"
            },
            "network_id" : "0",
            "protocol" : "XRPL/2.1",
            "public_key" : "n9J8pZGRGZBuVKKPzwVUgnaLZV7SfjfemUqNSsDG9gsapZyVXfh2",
            "track" : "unknown",
            "uptime" : 0,
            "version" : "rippled-1.6.0"
         }

With the fix:
{
   "result" : {
      "cluster" : {},
      "peers" : [
         {
            "address" : "<IP_ADDRESS>:51235",
            "complete_ledgers" : "59921001 - 59941001",
            "ledger" : "4181476CF2905FA88EA8BDF3F9DAAF94668CBCFCD307A14F9CD534D22EF5A1E9",
            "load" : 8,
            "metrics" : {
               "avg_bps_recv" : "2723",
               "avg_bps_sent" : "789",
               "total_bytes_recv" : "82605",
               "total_bytes_sent" : "25627"
            },
            "network_id" : "0",
            "protocol" : "XRPL/2.1",
            "public_key" : "n94DPGNHA8rEVHKHDm8mqVe8pjrHCgk3CzfWaFCEABGZqq9cNJJm",
            "sanity" : "unknown",
            "track" : "unknown",
            "uptime" : 3,
            "version" : "rippled-1.6.0"
         }

(accidental close, sorry)

@mDuo13, I'm good with this fix if you are.  Waddya think?

I missed this originally, but yes, with those changes, it's good. :+1:

I missed this originally, but yes, with those changes, it's good. :+1:


fix AtomicBox by deprecating it and implementing it with a CAS loop

Motivation:
Atomic references cannot easily be maintained correctly because the
load operation gets a pointer value that might (before the loader gets
a change to retain the returned reference) be destroyed by another
thread.
Modifications:

Deprecate AtomicBox
Implement NIOCASLoopBox with functionality similar to AtomicBox (but
implemented using a CAS loop :( ).

Result:

fixes #1286
fixes #1283

Compilation fails on CI:
18:21:28 [9/23] Compiling NIOConcurrencyHelpers atomics.swift
18:21:28 /code/Sources/NIOConcurrencyHelpers/atomics.swift:22:25: error: use of unresolved identifier 'pthread_yield'
18:21:28 let sys_pthread_yield = pthread_yield
18:21:28                         ^~~~~~~~~~~~~
``

@weissi Ok, instead of pthread_yield, which is non-standard, it should use sched_yield


Plugin idea: rate-limit based on query complexity

Based on: https://github.com/dotansimha/envelop/pull/474#issuecomment-885756213

Hi we wanted to implement using envelop complexity rate limit similar to https://shopify.engineering/rate-limiting-graphql-apis-calculating-query-complexity  (additional example in Monday API rate limit)
A bit more context on our use case, we open public GraphQL API and want that each api token will have budget per timeframe like minute/hour.

@idanwe I already started working on this, but haven't gotten back to it yet, I hopt to pick it up soon. This is something we really need for everyone!

@idanwe I just opened a pull request for this over here: https://github.com/dotansimha/envelop/pull/671
I did not start writing any documentation, but you can already have a look at the test cases :)
I think this plugin should replace https://github.com/dotansimha/envelop/pull/474 as it supports both being used to apply complexity rules for a single operation as well as apply complexity rules over a timeframe. The latter is opt-in.


Just question about iOS 18 HomeKit electric measure feature

Will this be working in HomeKit iOS 18 out of the box as we feed with the plugin HomeKit but only able to see it in EVE app for now? Just curiosity, I cannot find any definitive answer out of there online. We are few bunch happily using EVE app with Shelly 3em :) maybe you tried with iOS 18 beta or something...
Thanks

https://github.com/produdegr/homebridge-3em-energy-meter/issues/23

#23

thanks


Add reproducer for config cache failure using Kotlin lambda to configure enterprise plugin

@bot-gradle test ACC

OK, I've already triggered AllConfigCacheTestsReadyForMerge build for you.

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.


Mac M1 works with bazel github releases but not bazelisk auto-installed bazel

I got errors about using go toolchain using bazelisk
ERROR: While resolving toolchains for target //:gazelle-runner: no matching toolchains found for types @io_bazel_rules_go//go:toolchain
ERROR: Analysis of target '//:gazelle' failed; build aborted: no matching toolchains found for types @io_bazel_rules_go//go:toolchain
but when I installed using bazel install script it worked.
Both were same versions.

It's likely that you're switching between x86 and arm64 bazel versions, and hitting https://github.com/bazelbuild/bazel/issues/15350
You likely need to bazelisk clean --expunge, and rebuild, and if it still doesn't work maybe you need to update rules_go if your version isn't new enough to support arm64 macs?

Doesn't seem related to Bazelisk. As Keith pointed out, upgrading rules_go is usually the way to go here.


Getting URLResolve Error after choosing a server.

Getting URLResolve Error after choosing a server. Can't play any episodes.

Update to latest ResolveURL should fix it. If there’s still an issue then it’s on your end. Perhaps ISP blocking.


Confirm - design for createIndex

The current create index command (for regular indexes on text, numbers etc) looks like :
{
    "createIndex": {
        "name" : "users_country",
        "definition" : {
            "column" : "country",
            "options": {
                "ascii" : "true"
                }
        }
    }
}

NOTE: the options are under the definition element, the options are only there for text/ascii indexes and they are ascii, normalize, caseSensitive.
This is per the design from sept.
But looking at this, it looks like "Unnecessary Nesting" (TM) and perhaps we should have they under the definition ?
Other than UN (see above) there is already an options clause for the command, so this is also a case of "Double Options" (TM)
{
    "createIndex": {
        "name" : "users_country",
        "definition" : {
            "column" : "country",
            "options": {
                "normalize" : "true"
                }
        },
        "options": {"ifNotExists": true}
    }
}

My 2 centers: I would expect options to be a top-level property rather than as definition.options in this case. Not a dealbreaker either way, just that's what I would expect as a developer integrating against this API.


Graciously handle pdudameon errors

Currently boardswarm panics if pdudaemon returns an error. Make it a little more gracious and bubble up an error instead.
This is not currently a problem, since pdudaemon will not return errors until https://github.com/pdudaemon/pdudaemon/pull/158 is merged.
Fixes: boardswarm/boardswarm#81

@sjoerdsimons I think I made the commit message better.

looks like the commit message still says "pdudameon" instead of "pdudaemon" :)

looks like the commit message still says "pdudameon" instead of "pdudaemon" :)

@sjoerdsimons I completely missed that it was spelt incorrectly, even on a second time, can I kindly ask if you mention "typos" that you specifically call out what they are as that would stop one extra round of back-and-forth? I've fixed it now anyway :-)


Footnotes do not render as numbers, but as bullet points

I've noticed that footnotes written in markdown, e.g. [^1] neither display as superscripts in the body texts, nor do the companion notes display as numbers.  Instead, they are all bullet points.  Furthermore, clicking on a body footnote will not redirect to the note at the bottom of the page, but will return to the homescreen.  Looking at the HTML and CSS files that Hugo generates, I can't seem to find any indication of why this happens, although I have compared it to another Hugo theme that doesn't have this issue.
Here's the HTML used in Cocoa Enhanced:

FOOTNOTE TEXT
 [return]

The HTML matches that generated by other themes that render the footnotes as numbers, and looks fine, but perhaps there is something wrong with the definitions in the CSS file, the js files, or something else?  Screenshot attached.

Hi !
Thanks for your issue, I will investigate it !

So it was a bit of CSS yes, and a bit of HTML configuration for the anchors links.
The <base> tag was bringing a bit of mess, so I removed it and adapted links with absolute paths in order to make it works. Images have to be absolute too now so be careful !
Fixed in b89ca391a6c290bb2f3c75c906d5c5b379e55296


Dashboard fixes

What does this PR do?

fix visual bugs on donations dashboard

How this should be tested?

go to http://localhost:3000
open donation dashboard

@JeanVegaD check this


Creating authentication named routes

I'd like to create named routes for sign-in links like '/auth/twitter', to avoid using hardcoded URLs. Is there a way to add this to my routes.rb for omniauth and have it reference the appropriate controller/action from the gem?

You could do something like this:
match '/auth/:provider', to: lambda{|env| [404, {}, ["Not Found"]}, as: 'auth'

And you would then be able to call auth_path('twitter')


Kafka usability check

For more information see the link below.
https://github.com/ballerina-platform/ballerina-standard-library/blob/main/docs/library-development-process.md#usability-check

Fixed issue https://github.com/ballerina-platform/ballerina-standard-library/issues/1661

Closing since the identified usability issues are fixed for now


The user can choose what he wants to sync

💡 Is your feature request related to a problem? Please describe.
In the Settings, the user can choice what he wants sync, with false and true values.
💡 Describe the solution you'd like

If the user wants not sync settings, that data will not will be uploaded to your gist.
If the user wants not sync extensions, that data will not will be uploaded to your gist.
If the user wants not sync key binds, that data will not will be uploaded to your gist.

💡 Additional context
Nothing additional!

This can be done by adding a setting like sync.excludeSettings which is a list of settings that are not supposed to be synced.
For example, to exclude font setting,
{
    "sync.excludeSettings": [
        "editor.fontSize"
    ]
}

Something similar can be implemented for keybindings and extensions as well.

Custom Sync for settings.json
If you are looking to exclude the settings keys from being sync.  See the details here :
https://github.com/shanalikhan/code-settings-sync/wiki/Sync-Pragmas#ignore-settings
Custom Sync for Extensions
If you want to disable the extension sync, set sync.syncExtensions to false to disable the extensions.
If you want to remove some extensions from sync process. Add your extension complete name in ignoreExtensions ( Settings Sync Global Settings - check readme )
Custom Sync for keybindings
I'm open for PR. This feature needs to be added.

For keybindings, i would like you to be-specific with your scenarios and example about what you are looking to achieve.

I think it would be better if we use @sync-ignore like implementation for keybinding.json.
Something like https://gist.github.com/njkevlani/d79973d50258fe4312786b198746da3f#file-keybindings-json

If you want to remove some extensions from sync process. Add your extension complete name in ignoreExtensions ( Settings Sync Global Settings - check readme )

I can't figure out what "complete name" is for any given extension, can you please clarify?

@MstrBlonde
"complete name" = Unique Identifier without publisher id.
for example see https://marketplace.visualstudio.com/items?itemName=Shan.code-settings-sync
Unique Identifier: Shan.code-settings-sync
So the "complete name" = code-settings-sync

Yes this can be done for keybindings.json.
P.S : Public edit is enabled for Wiki. If you guys think documentation can be improved, just edit those pages and improve it, that would be great help to other users :)

@shanalikhan
Functions processBeforeUpload and processBeforeWrite are used to add functionality Sync Pragmas in settings.json.
I think we can use processBeforeUpload and processBeforeWrite for this purpose as well. Or do I have to rewrite similar functions with some changes?
If the same functions can be used for both settings.json and keybindings.json, I'll just change the variable name where ever appropriate and use them for keybindings.json as well.
LMK.

No these function should work for all of the content string that will be passed.
You just need understand how these functions are being called in which location for settings.json and implment the calling layout for keybindings.json
Make sure you write the test cases for it.
If you are working on to implement this issue, it would be great if you can look into other ticket as well regarding keybindings.json - https://github.com/shanalikhan/code-settings-sync/issues/515.

Will open a PR by this weekend :)

How do I run test? This Method for test fails on master branch

@njkevlani can you fix fail test method also, i think some PR broke it.

I have released new version of Settings Sync v3.3.0 fixing this issue. Im closing this ticket let me know if u guys run into some problem.
Anyone can improve public wiki to help community


CSS Nesting

Previous: https://github.com/Fyrd/caniuse/pull/6579, https://github.com/Fyrd/caniuse/issues/6583
Now Safari TP 162 is here as well:

Enabled CSS Nesting (258564@main, 258560@main)

Creating this draft PR to keep track with the intention of letting it sit here until the time is right.
CC @romainmenke

What are you waiting for until "the time is right"?
Why not publish now?

Ah, I read the comment about not providing browser implementation data until after a specification is finished.
I don't think that makes sense. It doesn't match what Can I Use normally does. Please do update the Nesting page with the data for Safari Technology Preview 162.

Yeah I was under the impression that the discussions meant it might not be enabled in Chrome after all, so that was the reason for caution there. If that's not in dispute then no, I don't see any reason not to mark it as supported if indeed it's there.


Ac 519 human readable output for tx

Fixed inconsistencies in cli output to allow scripting.  Created scripts for testing cli command in accordance with the test matrix.

Doesn't the script prompt the user to build the cli if it isn't there?   I guess the script could check and see if which sed returns a valid file name.
On Tuesday, November 16, 2021, 03:24:40 PM CST, bunfield @.***> wrote:
@bunfield requested changes on this pull request.
This PR should be cancelled in favor of AC-237-scripts-for-version-0-2
In scripts/cli_create_id.sh:

issue the account generate command to the specified server

-ID=$cli account generate -s "http://$1/v1"
+if [ -z $1 ]; then

acc="$($cli account generate -j 2>&1 > /dev/null | /usr/bin/jq .name | /usr/bin/sed 's/"//g')"

on ubuntu 18.04 sed is located in /bin/sed
In scripts/test_case_2.6.sh:

@@ -0,0 +1,54 @@
+#!/bin/bash
+#
+# test case 2.3
+#
+# create an adi from another adi
+# server IP:Port needed unless defaulting to localhost
+#
+# set cli command and see if it exists
+#
+export cli=../cmd/cli/cli

probably should ensure the cli is built, maybe?
go run ../cmd/cli/main.go might be an option, but that will be very slow if doing loops.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

Wrong branch.


solution for -- Print alternate elements of an array || Print Elements of Array

Can you update the number of problems solved in the top contributors list


Installation on macOS needs better instructions

I'm trying to install TLAPS on macOS following the instructions provided at https://tla.msr-inria.inria.fr/tlaps/content/Download/Binaries/MacOS.html
I successfully installed the binary in the default location. I'm stuck with the last part:
You will need to add the location of the TLAPS.tla file to the list of libraries used by the Toolbox.
To do this, open the Toolbox and go to "File > Preferences > TLA+ Preferences".
Add the directory where TLAPS.tla is located to the list of library path locations.
If you have the default installation, this directory is /usr/local/lib/tlaps/.

At this point, the "add directory" doesn't show usr as a valid choice, thus making impossible to add it to TLA Toolbox:

Searching for TLAPS.tla or tlaps path,  doesn't work.
System Information
macOS Catalina 10.15.4 (19E287)
TLAPS: 1.4.5
TLA Toolbox. This is Version 1.6.0 of 10 July 2019 and includes:

SANY Version 2.1 of 23 July 2017
TLC Version 2.14 of 10 July 2019
PlusCal Version 1.9 of 10 July 2019
TLATeX Version 1.0 of 20 September 2017

TLAPS installation details
/usr/local/bin is in PATH.
> cd /usr/local/lib/tlaps
> ls -lsa
total 2896
drwxr-xr-x   36 502   wheel   1.1K Apr 18 15:30 .
drwxr-xr-x  494 502   wheel    15K Apr 18 15:30 ..
-rw-r--r--    1 502   wheel   7.4K Feb 28 16:26 Bags.tla
-rw-r--r--    1 502   wheel   9.3K Feb 28 16:26 BagsTheorems.tla
-rw-r--r--    1 502   wheel    11K Feb 28 16:26 BagsTheorems_proofs.tla
drwxr-x---    6 root  wheel   192B Apr 18 15:30 Cantor1.tlaps
-rw-r--r--    1 502   wheel    19K Feb 28 16:26 FiniteSetTheorems.tla
-rw-r--r--    1 502   wheel    41K Feb 28 16:26 FiniteSetTheorems_proofs.tla
-rw-r--r--    1 502   wheel   1.3K Feb 28 16:26 FiniteSets.tla
-rw-r--r--    1 502   wheel    28K Feb 28 16:26 FunctionTheorems.tla
-rw-r--r--    1 502   wheel    45K Feb 28 16:26 FunctionTheorems_proofs.tla
-rw-r--r--    1 502   wheel   3.3K Feb 28 16:26 Functions.tla
lrwxr-xr-x    1 502   wheel    14B Feb 28 16:25 Isabelle -> Isabelle2011-1
drwxr-xr-x   16 502   staff   512B Feb 28 16:25 Isabelle2011-1
-rw-r--r--    1 502   wheel   8.8K Feb 28 16:26 NaturalsInduction.tla
-rw-r--r--    1 502   wheel    20K Feb 28 16:26 NaturalsInduction_proofs.tla
-rw-r--r--    1 502   wheel   848B Feb 28 16:26 RealTime.tla
-rw-r--r--    1 502   wheel    18K Feb 28 16:26 SequenceOpTheorems.tla
-rw-r--r--    1 502   wheel    34K Feb 28 16:26 SequenceOpTheorems_proofs.tla
-rw-r--r--    1 502   wheel   2.4K Feb 28 16:26 SequenceOps.tla
-rw-r--r--    1 502   wheel   9.1K Feb 28 16:26 SequenceTheorems.tla
-rw-r--r--    1 502   wheel    11K Feb 28 16:26 SequenceTheorems_proofs.tla
drwxr-xr-x   23 502   wheel   736B Dec 11  2017 TLA+
-rw-r--r--    1 502   wheel    21K Feb 28 16:26 TLAPS.tla
-rw-r--r--    1 502   wheel    16K Feb 28 16:26 WellFoundedInduction.tla
-rw-r--r--    1 502   wheel    31K Feb 28 16:26 WellFoundedInduction_proofs.tla
drwxr-xr-x    9 502   wheel   288B Feb 28 16:26 bin
drwxr-xr-x    3 502   wheel    96B Feb 28 16:26 emacs
drwxr-xr-x   20 502   wheel   640B Feb 28 16:22 examples
drwxr-x---    3 root  wheel    96B Apr 18 15:30 heaps
-rwxr-xr-x    1 502   wheel   996K Feb 28 16:26 un-inst
-rw-r--r--    1 502   wheel   4.9K Feb 28 16:26 zenon.v
-rw-r--r--    1 502   wheel   6.0K Feb 28 16:26 zenon_coqbool.v
-rw-r--r--    1 502   wheel    47K Feb 28 16:26 zenon_equiv.v
-rw-r--r--    1 502   wheel   7.9K Feb 28 16:26 zenon_focal.v
-rw-r--r--    1 502   wheel   1.3K Feb 28 16:26 zenon_induct.v

Workaround
Add a symbolic link for /usr/local/lib/tlaps in a known location visible from TLA Toolbox, such as your home directory.
> cd ~
> ln -s /usr/local/lib/tlaps tlaps

A perhaps more "Mac-native" way to achieve this is to reveal the directory in the Finder (Go -> Go to Folder ... then enter /usr/local) and add that directory to your Favorites in the sidebar. It is then accessible whenever a file browser shows up. I find it frequently useful to be able to access /usr/local and similar Unixish directories that MacOS tries to hide from you.
Stephan

On 18 Apr 2020, at 16:05, Nicholas Fiorentini<EMAIL_ADDRESS>wrote:
Workaround
Add a symbolic link for /usr/local/lib/tlaps in a known location visible from TLA Toolbox, such as your home directory.

cd ~
ln -s /usr/local/lib/tlaps tlaps
https://user-images.githubusercontent.com/45690027/79639812-43241a00-818e-11ea-80e0-c0f38f1ffe7c.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/tlaplus/tlapm/issues/7#issuecomment-615877229, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABZCW5NMY3F4CK5GGDLCPBLRNGXQ7ANCNFSM4MLLOBKA.

In fact, when you are in the Select the library path location dialog, you can simply hit the / key and it will open a text box where you can type any path you want, including /usr/local/lib/tlaps:

This is a general feature of MacOS "open file" dialogs.

In fact, when you are in the Select the library path location dialog, you can simply hit the / key and it will open a text box where you can type any path you want, including /usr/local/lib/tlaps

Thanks! Didn't know this feature.


Implement multiple external IDs for participants and samples

Adds new participant_external_id and sample_external_id tables to record additional external IDs for a participant/sample — the table can potentially have several rows for each participant/sample. The participant and sample table's external_id fields are migrated to the new tables and the columns renamed so no code can use them (but not removed, as that would interfere with the table versioning).
Further additions to be finalised as the effects of this ripple across the metamist code base…
Addresses #139.
The representation follows that of assay etc: instead of a simple external_id: str field, we now have external_ids: dict[str, str]: a dictionary of external_organisation → external_id pairs. One of these is designated the PRIMARY_EXTERNAL_ORG and represented by having the '' empty string as its key. This corresponds to the previous single external_id.
Upsert methods take a similar external_ids: dict[str, str | None] | None optional dictionary.
When the upsert is an insert creating a new participant/sample, external_ids must be non-None and contain a primary '' entry with a non-None external_id value; it may contain other additional pairs, and any pairs with value None are ignored.
When the upsert is an update to an existing participant/sample, external_ids may be None indicating no changes are being made to any external ids. Otherwise it contains entries to be updated: None values indicate that the external id for that key is to be deleted, and non-None values provide a new value to update that key to. (The value may not be None for the primary key, ''.)
TODO: Find somewhere appropriate to document this in the metamist source code!

The following are source files that either have “sample” in their filename or whose contents match /external_?id/ case insensitively, together with notes as to whether they need updating for this PR.
(NA = not applicable, false positive match; “lower” indicates that this is a wrapper layer, needed behaviour changes will occur due to code changes in lower layers; “one” is generally an indication that ~1 instance of external_id will need updating but others can remain unchanged.)
NA	README.md
NAlower	api/graphql/loaders.py
TODO?	api/graphql/schema.py  # GraphQLSample probably do ext_ids JSON a la Assay
NA	api/routes/assay.py
NA	api/routes/family.py
PROB NA	api/routes/participant.py
NAlower	api/routes/sample.py
DONE	db/project.xml
DONE	db/python/connect.py
NA	db/python/enum_tables/sample_type.py
NA	db/python/layers/assay.py
NA	db/python/layers/family.py
one?	db/python/layers/participant.py
TODO	db/python/layers/sample.py  # Mostly LOWER, but check upsert_sample()
one?	db/python/layers/search.py
NA	db/python/layers/seqr.py
um...	db/python/layers/web.py
NA	db/python/tables/analysis.py
NA	db/python/tables/assay.py
NA	db/python/tables/family.py
NA	db/python/tables/participant.py
DONE	db/python/tables/project.py
DONE	db/python/tables/sample.py
DONE	db/python/tables/sequencing_group.py
NA	etl/extract/main.py
NA	etl/test/test_etl_load.py
TODO	metamist/api/sample_api.py
NA	metamist/audit/README.md
	metamist/audit/audit_upload_bucket.py
	metamist/audit/generic_auditor.py
	metamist/model/body_get_samples.py
	metamist/model/nested_sample.py
	metamist/model/sample_search_response_data.py
	metamist/model/sample_upsert.py
	metamist/parser/generic_parser.py
	metamist/parser/sample_file_map_parser.py
NA	metamist_infrastructure/README.md
NA	models/models/assay.py  # Has multiple external_ids args
NA	models/models/family.py
NA	models/models/participant.py
TODO	models/models/sample.py  # Probably convert to multiple external_ids args
one?	models/models/search.py  # Maybe update SequencingGroupSearchResponseData
NA	models/models/sequencing_group.py  # Has multiple external_ids args
NA	models/utils/sample_id_format.py
	sample_metadata/api/sample_api.py
	sample_metadata/model/body_get_samples.py
	sample_metadata/model/nested_sample.py
	sample_metadata/model/new_sample.py
	sample_metadata/model/sample_batch_upsert.py
	sample_metadata/model/sample_batch_upsert_body.py
OKAY?	sample_metadata/model/sample_search_response_data.py  # All already plural
	sample_metadata/model/sample_type.py
	sample_metadata/model/sample_update_model.py
	scripts/20230420_sequencinggroupmigration.py
	scripts/arbitrary_sm.py
	scripts/back_populate_sequences.py
	scripts/create_test_subset.py
	scripts/fix_family_ids.py
	scripts/fix_participant_ids.py
	scripts/fix_pbmc_sample_participant.py
	scripts/parse_existing_cohort.py
	scripts/parse_participant_meta.py
	scripts/parse_sample_file_map.py
	scripts/parse_vcgs_manifest.py
	scripts/sync_seqr.py
	test/data/generate_data.py
	test/data/generate_seqr_project_data.py
	test/test_analysis.py
	test/test_assay.py
	test/test_audit_log.py
	test/test_generic_auditor.py
	test/test_get_participants.py
	test/test_graphql.py
	test/test_import_individual_metadata.py
	test/test_metamist.py
	test/test_models.py
	test/test_parse_existing_cohort.py
	test/test_parse_generic_metadata.py
	test/test_parse_ont_sheet.py
	test/test_pedigree.py
	test/test_sample.py
	test/test_search.py
	test/test_sequencing_groups.py
	test/test_update_participant_family.py
	test/test_upsert.py
	test/test_web.py
NA	tob_metadata_harmonisation.py
NA	update_sample_status/main.py  # Entirely commented out
HMMM	web/src/pages/family/FamilyView.tsx  # Displays sample eid
NA	web/src/pages/family/FamilyViewTitle.tsx
NA?	web/src/pages/project/ProjectGrid.tsx
TODO	web/src/pages/sample/SampleView.tsx  # Displays sample eid
NA	web/src/shared/components/AssayInfo.tsx  # Demonstrates assay eid list
OKAY?	web/src/shared/components/Header/Search.tsx  # Maybe line 271 needs changing

Codecov Report
Attention: Patch coverage is 77.34375% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 77.31%. Comparing base (3073a28) to head (9155de7).

Files
Patch %
Lines

db/python/tables/participant.py
48.64%
19 Missing :warning:

db/python/tables/sample.py
70.96%
9 Missing :warning:

db/python/layers/participant.py
50.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #659      +/-   ##
==========================================
+ Coverage   77.30%   77.31%   +0.01%
==========================================
  Files         157      157
  Lines       13010    13065      +55
==========================================
+ Hits        10057    10101      +44
- Misses       2953     2964      +11

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Yep, definitely time for people to start taking a look at this — so thanks for having a quick look.
One of my earlier drafts said “TODO add documentation of what the dict[str,str] means” and I still haven't got around to that. Yep, on the basis that external_ids are already non-optional (have I got that right?), the idea is that the empty-string-named one corresponds to the existing primary default external_id and must always be present. Will do re writing up the rules.

Cool, cool… I was expecting to have some more tests newly merged in from dev that will need updating for multiple external_ids… 😅


MP4 Automator not working with rar?

Hi! The MP4 Automator is awesome! But i have a small problem, when downloading rar-files, i tell my deluge to extract the rar, but MP4 is not delayed so it runs 1 time and thats it, how can i delay Mp4 automator  to wait for files to be unpacked before it does it things? I have search all of the net for a solution! Im using Mp4 automator with radarr/sonarr.

You might be better off using completed download handling in Sonarr/Radarr and then letting the processing be done after those apps finish instead of after deluge finishes to avoid issues with RAR files
From: Kristofferyx
Sent: Friday, May 3, 2019 2:56 AM
To: mdhiggins/sickbeard_mp4_automator
Cc: Subscribed
Subject: [mdhiggins/sickbeard_mp4_automator] MP4 Automator not working withrar? (#1005)
Hi! The MP4 Automator is awesome! But i have a small problem, when downloading rar-files, i tell my deluge to extract the rar, but MP4 is not delayed so it runs 1 time and thats it, how can i delay Mp4 automator to wait for files to be unpacked before it does it things? I have search all of the net for a solution! Im using Mp4 automator with radarr/sonarr.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I fail to understand how to set that up, english is not my native language and im having a hard time understanding how, and in wich order i should set up it to work. Do you have a guide or can point me in the right direction?

There isn’t a clear guide, no.
What programs are you currently using in your setup besides deluge? I can maybe help give more specific advice if you tell me that information
From: Kristofferyx
Sent: Friday, May 3, 2019 11:06 AM
To: mdhiggins/sickbeard_mp4_automator
Cc: Michael Higgins; Comment
Subject: Re: [mdhiggins/sickbeard_mp4_automator] MP4 Automator not workingwith rar? (#1005)
I fail to understand how to set that up, english is not my native language and im having a hard time understanding how, and in wich order i should set up it to work. Do you have a guide or can point me in the right direction?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Sorry, I use Radarr, Sonarr, fetching from trackers with Jackett. Then i used the MP4 automator set up as seen on your github and tell deluge to execute the .bat file. When downloading rar files Mp4 automator gets executed instantly and then dissapers.. I hope we find a solution :)

So you can just disable delugePostProcess all together, just don’t set it up, and then turn on “Completed Download Handling” in the settings for Radarr and Sonarr and see if that works
From: Kristofferyx
Sent: Friday, May 3, 2019 11:13 AM
To: mdhiggins/sickbeard_mp4_automator
Cc: Michael Higgins; Comment
Subject: Re: [mdhiggins/sickbeard_mp4_automator] MP4 Automator not workingwith rar? (#1005)
Sorry, I use Radarr, Sonarr, fetching from trackers with Jackett. Then i used the MP4 automator set up as seen on your github and tell deluge to execute the .bat file. When downloading rar files Mp4 automator gets executed instantly and then dissapers.. I hope we find a solution :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

I will try that now, Thanks!

@mdhiggins It works! Thanks so much!
I have another question, is it possible to hardcode the subs to the movies instead of adding them to a container?

Hi @mdhiggins I have a similar issue, it seems files were downloaded but not yet extracted. I'm using SABnzbd and use sonarr.
I tried combinations of enabling/disabling the Completed download handling and postSonarr script but it didn't work.
Here is a log of the SAB post process:
2019-05-23 20:20:37 - SABPostProcess - INFO - Performing conversion
2019-05-23 20:20:37 - SABPostProcess - INFO - Overriding output_dir to /tvshows.
2019-05-23 20:20:37 - SABPostProcess - INFO - Ignoring file /tvshows/Afro.Samurai.S01E02.720p.BluRay.x264-SEMTEX/sem-ass01e02.r04.
2019-05-23 20:20:37 - SABPostProcess - INFO - Ignoring file /tvshows/Afro.Samurai.S01E02.720p.BluRay.x264-SEMTEX/sem-ass01e02.r05.
2019-05-23 20:20:37 - SABPostProcess - INFO - Ignoring file /tvshows/Afro.Samurai.S01E02.720p.BluRay.x264-SEMTEX/sem-ass01e02.par2.
2019-05-23 20:20:37 - SABPostProcess - INFO - Ignoring file /tvshows/Afro.Samurai.S01E02.720p.BluRay.x264-SEMTEX/sem-ass01e02.vol15+16.par2.
2019-05-23 20:20:37 - SABPostProcess - INFO - Ignoring file /tvshows/Afro.Samurai.S01E02.720p.BluRay.x264-SEMTEX/sem-ass01e02.srr.
2019-05-23 20:20:37 - SABPostProcess - INFO - Ignoring file /tvshows/Afro.Samurai.S01E02.720p.BluRay.x264-SEMTEX/sem-ass01e02.vol00+01.par2.
2019-05-23 20:20:37 - SABPostProcess - INFO - Ignoring file /tvshows/Afro.Samurai.S01E02.720p.BluRay.x264-SEMTEX/sem-ass01e02.r07.
2019-05-23 20:20:37 - SABPostProcess - INFO - Ignoring file /tvshows/Afro.Samurai.S01E02.720p.BluRay.x264-SEMTEX/sem-ass01e02.r10.
2019-05-23 20:20:37 - SABPostProcess - INFO - Ignoring file /tvshows/Afro.Samurai.S01E02.720p.BluRay.x264-SEMTEX/sem-ass01e02.vol01+02.par2.
2019-05-23 20:20:37 - SABPostProcess - INFO - Ignoring file /tvshows/Afro.Samurai.S01E02.720p.BluRay.x264-SEMTEX/sem-ass01e02.vol03+04.par2.
2019-05-23 20:20:37 - SABPostProcess - INFO - Ignoring file /tvshows/Afro.Samurai.S01E02.720p.BluRay.x264-SEMTEX/sem-ass01e02.r03.
2019-05-23 20:20:37 - SABPostProcess - INFO - Ignoring file /tvshows/Afro.Samurai.S01E02.720p.BluRay.x264-SEMTEX/sem-ass01e02.vol31+08.par2.
2019-05-23 20:20:37 - SABPostProcess - INFO - Ignoring file /tvshows/Afro.Samurai.S01E02.720p.BluRay.x264-SEMTEX/sem-ass01e02.rar.
2019-05-23 20:20:37 - SABPostProcess - INFO - Ignoring file /tvshows/Afro.Samurai.S01E02.720p.BluRay.x264-SEMTEX/sem-ass01e02.r08.
2019-05-23 20:20:37 - SABPostProcess - INFO - Ignoring file /tvshows/Afro.Samurai.S01E02.720p.BluRay.x264-SEMTEX/sem-ass01e02.r09.
2019-05-23 20:20:37 - SABPostProcess - INFO - Ignoring file /tvshows/Afro.Samurai.S01E02.720p.BluRay.x264-SEMTEX/sem-ass01e02.r06.
2019-05-23 20:20:37 - SABPostProcess - INFO - Ignoring file /tvshows/Afro.Samurai.S01E02.720p.BluRay.x264-SEMTEX/sem-ass01e02.r00.
2019-05-23 20:20:37 - SABPostProcess - INFO - Ignoring file /tvshows/Afro.Samurai.S01E02.720p.BluRay.x264-SEMTEX/sem-ass01e02.vol07+08.par2.
2019-05-23 20:20:37 - SABPostProcess - INFO - Ignoring file /tvshows/Afro.Samurai.S01E02.720p.BluRay.x264-SEMTEX/sem-ass01e02.r02.
2019-05-23 20:20:37 - SABPostProcess - INFO - Ignoring file /tvshows/Afro.Samurai.S01E02.720p.BluRay.x264-SEMTEX/sem-ass01e02.r01.
2019-05-23 20:20:37 - SABPostProcess - INFO - Ignoring file /tvshows/Afro.Samurai.S01E02.720p.BluRay.x264-SEMTEX/Afro.Samurai.S01E02.720p.BluRay.x264-SEMTEX.nzb.
2019-05-23 20:20:37 - SABPostProcess - INFO - Passing /tvshows directory to Sonarr.
2019-05-23 20:20:37 - autoprocess.sonarr - INFO - Sonarr notifier started.
2019-05-23 20:20:37 - autoprocess.sonarr - INFO - Requesting Sonarr to scan directory '/tvshows'.
2019-05-23 20:20:37 - autoprocess.sonarr - INFO - Sonarr response: queued.

My solution was to add a script that unrar everything before doing the conversion, for anyone who passes by. atm it's a bash script but if I pythonize it, I'll make a PR


remove non-existing script

Coverage remained the same at 100.0% when pulling f4b5fa1fdfd4ae7035ec93e42eb76417cd7ab4b5 on fix-script into 931bb82165c53c14c6aa68e0f1e14cb4e5742bf7 on master.


ITFlow is redirecting to spam

ITflow.biz is either redirecting to spam, or a domain landing page.

It's out :)


feat(AppHeaderLogo): logo button AppHeaderElement

Overview
@katiezutter and I are breaking down our mega AppHeader PR into smaller PR's containing the new components we added. This PR tackles the AppHeaderLogoItem and its related types + tests.

PR Checklist

[ ] Related to designs:
[ ] Related to JIRA ticket: EGG-643
[ ] I have run this code to verify it works
[ ] This PR includes unit tests for the code change

📬Published Alpha Packages<EMAIL_ADDRESS>
📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://5fff70ea754ac05ff730a838--gamut-preview.netlify.appDeploy Logs

🚀 Styleguide deploy preview ready!https://5fff70ea754ac05ff730a838--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages<EMAIL_ADDRESS>
📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://5fff72b61405a15a7d15a10b--gamut-preview.netlify.appDeploy Logs

🚀 Styleguide deploy preview ready!https://5fff72b61405a15a7d15a10b--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages<EMAIL_ADDRESS>
📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://5fff7e5d7c8b0d6d97f13031--gamut-preview.netlify.appDeploy Logs

🚀 Styleguide deploy preview ready!https://5fff7e5d7c8b0d6d97f13031--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-labs@7.7.5-alpha.44cbeb.0<EMAIL_ADDRESS>
📬Published Alpha Packages:@codecademy/gamut-labs@7.7.5-alpha.44cbeb.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6000a8515b82a750de2a306c--gamut-preview.netlify.appDeploy Logs

🚀 Styleguide deploy preview ready!https://6000a8515b82a750de2a306c--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-labs@7.7.5-alpha.b77ba3.0<EMAIL_ADDRESS>
📬Published Alpha Packages:@codecademy/gamut-labs@7.7.5-alpha.b77ba3.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6000b9973984be6d046e9896--gamut-preview.netlify.appDeploy Logs

🚀 Styleguide deploy preview ready!https://6000b9973984be6d046e9896--gamut-preview.netlify.appDeploy Logs

I know I'm late, but I have a general question re: storybook, i saw that "storybook/stories/labs" wasn't there anymore, was that because it was all cleared out or is the idea we should distinguish now by declaring the "source" in each story? @codecaaron

I know I'm late, but I have a general question re: storybook, i saw that "storybook/stories/labs" wasn't there anymore, was that because it was all cleared out or is the idea we should distinguish now by declaring the "source" in each story? @codecaaron


Retrying failed payment doesn't update cycle_ends_at on subscription

Retrying failed payment  doesn't update cycle_ends_at on subscription when the payment succeeds.
Reproduction steps:

Let Cashier create a payment for a new subscription cycle.
Set the payment status to failed. The subscription_ends_at now has a date and the cycle_ends_at is now null.
Retry the same payment and now set the payment status to paid.

subscriptions_ends_at is now null again, but cycle_ends_at (and scheduled_order_item_id) is also null. These should be reverted to the old values right? At least that's what I understand from the docs:

On a successful payment retry, the subscription will be reactivated, continuing the billing cycle as it was before.

Hi @siegerhansma ,
Thank you for reporting.
Can you share a code sample so we can reproduce the issue?

Hey Sander,
It's a bit difficult in this case, because of the manual steps you need to take on the Mollie side in test mode (setting the payment status). I have included reproduction steps in the issue description. Please let me know if you need any more information or if something is unclear.

Hi @siegerhansma ,
Ok, let me double check that I am getting this right because there's a lot happening here:

Your billable model is on an active subscription.
When running cashier:run, a mandated payment is attempted at Mollie.
Using the Mollie API, you have manually set this payment status as failed.
Mollie was able to call your application using your webhook (you can check this in the Mollie dashboard).
Cashier locally marked the payment and order as failed, and immediately cancelled the subscription.
You have used the $order->retryNow() method to generate a new payment.
Using the Mollie API, you have manually set this retry payment status as paid.
Mollie was able to call your application using your webhook (you can check this in the Mollie dashboard).
Cashier locally marked the payment and order as successful.
Resuming the subscription did not go as expected (cycle_ends_at, scheduled_order_item_id).

Is this correct? Am I missing any steps?

@sandervanhooft Yep, that's correct. Thanks for the quick summary!

This here seems to be the culprit:
https://github.com/mollie/laravel-cashier-mollie/blob/d8d5ba12ee0356eb8e66b3a11cd0072940e2af09/src/Subscription.php#L560-L575

@ciungulete can you pick this one up?

@sandervanhooft  @ciungulete  Any updates on this one?

I fix it here #135

Thanks!

This is also the solution to this problem: https://github.com/mollie/laravel-cashier-mollie/issues/74


Support System.Boolean

Obvious ones are:

IsTrue
IsFalse
IsEqual

what's the point of IsEqual having two above methods?

IsTrue/False is like hardcoding value, and IsEqualTo provides you an ability to parametrise it


 Also includes example files for these types of requests.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[y ] The title of the PR is clear and informative.
[y] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[y ] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[ ] If applicable, the PR references the bug/issue that it fixes.
[y ] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[ y] I have read the contribution guidelines.
[y ] My spec meets the review criteria:

[ y] The spec conforms to the Swagger 2.0 specification.
[ y] The spec follows the guidelines described in the Swagger checklist document.
[ y] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

@simongdavies new APIs

@ravbhatnagar

Looks good

@molly-moen Please also take a look at our model validation - it found a load of mismatches between the examples you provided and the specification.


[BACKLOG-36199] Fix for prepopulating file name

:x: Build failed in 21m 16s
Build command:
mvn clean verify -B -e -Daudit -amd -pl \
plugins/file-open-save-new/core

:exclamation: No tests found!
Errors:
Filtered log (click to expand)

script returned exit code 1

:information_source:  This is an automatic message


Test client init error

[Current coverage][cc-pull] is 89.95%

Merging [#448][cc-pull] into [master][cc-base-branch] will increase coverage by 0.07%

@@             master       #448   diff @@
==========================================
  Files            18         18
  Lines          1274       1274
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           1145       1146     +1
+ Misses          129        128     -1
  Partials          0          0

[][cc-pull]

Powered by Codecov. Last updated by [aaa27e2...2660a31][cc-compare]
[cc-base-branch]: https://codecov.io/gh/bigchaindb/bigchaindb/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/bigchaindb/bigchaindb/compare/aaa27e2ac7c3aa593a28f056ded1316cd586ea4d...2660a3191b540757c5fb3f634c8120af56835d3d?src=pr
[cc-pull]: https://codecov.io/gh/bigchaindb/bigchaindb/pull/448?src=pr

:+1:


The change you wanted was rejected

After a recent update, I can no longer login with chrome... I get the following error:

I can however login with firefox.
Chrome version: 75.0.3770.100
Firefox Version: 68.0.1

If it works with one browser and not with the other I would suspect that one of the extensions installed is causing this. Can you try it in an incognito windows in chrome and/or disable all your extensions?

Just tried in incognito with no extensions... same result. Pulling up the console shows the following error:
Failed to load resource: the server responded with a status of 422 (Unprocessable Entity)

Are you using two reverse proxies? I just remembered I have the same issue with a different rails application that is proxied twice and I never got around fixing it.

If there is a reverse proxy built into the docker image, I guess I am. But I didn't have any issues a month ago when I last logged in. Any idea how to resolve?

No, the docker images don't come with a reverse proxy. So are seeing this problem when Huginn in docker directly?
When I start the container with docker run -it --rm -p 3000:3000 huginn/huginn I have no issues logging using Chrome.

It appears if I go directly to the the port it does allow me to login. However this is not a feasible for me on a regular basis with how my networks are setup, so I need to get this working again through the proxy like it was. Is there something I need to check to make sure the proxy is passing something that huginnn needs or not passing something it doesn't want?

When was the last time you updated Huginn? If id had been some time setting those headers in your proxy configuration might help: https://github.com/rails/rails/issues/22965#issuecomment-172929004

I usually update Huginn every month (Or at least check for an update every month).
That issue you referenced seems to not apply to my issue. Furthermore, in thinking more on this, it seems it cannot be an issue with the proxy, because it works just fine in other browsers. I'm thinking it has to deal with some recent update with the Chrome code, but I'm not sure what, or why it isn't playing nice with Huginn.

I can really pinpoint which update changed the behavior, but trust me it's the proxy configuration. You said the login works when bypassing the proxy and accessing the Huginn docker container directly and I saw the exact same behavior on my other Rails application: Login worked on Firefox but gave the "The change you wanted was rejected" error on Chrome.
For me the fix was to pass the X-Forwarded-Proto header from the first proxy to the Rails application server in the configuration of the second proxy, if you are just using one proxy the configuration in the issue should work.

OK, I did, I'm wrong.
However it does appear that if you are using HA proxy, you have to add the config to the back-end server, not the front-end, to work.
Thank you for taking the time to help a stubborn old guy like me!

Thank you, I had the same issue. I do update regularly, but only after the last update (6 days ago) I encountered this exact issue. I am running a Docker image behind a nginx reverse proxy, which also terminates SSL.
In case anyone else is looking for this, I added these headers (based on a post linked above) and it worked.
        location / {
                proxy_pass http://<IP_ADDRESS>:31337;
                proxy_set_header  Host $host;
                proxy_set_header  X-Forwarded-For $proxy_add_x_forwarded_for;
                proxy_set_header  X-Forwarded-Proto $scheme;
                proxy_set_header  X-Forwarded-Port $server_port;
                proxy_set_header  X-Forwarded-Host $host;
        }

For HAProxy add the following to your Backend configuration:
  option forwardfor
  reqadd X-Forwarded-Proto:\ https

For info, this problem also arises when you use the Cloudflare proxy in addition to a reverse proxy. (So it counts as a double proxy)

Hi, can you clarify why double proxy is an issue here and if you know a fix? Thank you!

For info, this problem also arises when you use the Cloudflare proxy in addition to a reverse proxy. (So it counts as a double proxy)

Hi, can you clarify why double proxy is an issue here and if you know a fix? Thank you!

I'm sorry, I don't remember anything from this issue any more.
I just checked my cloudflare config and my traefik config but can't see anything special that I did there.
Cloudflare is proxying the subdomain and traefik has the same config as my other services.
I can seem to access my huginn service through the browser.
Sorry I can't be more of help.
I don't actively use huginn that much any more.


KAFKA-13522: add position tracking and bounding to IQv2

Fill in the Position response in the IQv2 result.
Enforce PositionBound in IQv2 queries.
Update integration testing approach to leverage consistent queries.

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Looks good, thanks John!

The test failures are unrelated:

Build / JDK 11 and Scala 2.13 / kafka.security.authorizer.AclAuthorizerWithZkSaslTest.testAclUpdateWithSessionExpiration() | 16 sec | 1

Build  / JDK 8 and Scala 2.12 /  org.apache.kafka.streams.integration.NamedTopologyIntegrationTest.shouldRemoveNamedTopologyToRunningApplicationWithMultipleNodesAndResetsOffsets

Thanks for the reviews, all!


Fix docker compose error and improve developer experience

After discussion with @calvinrp, we reached a consensus that improving the local development experience and documentation is important to make more developer participate in this project. This pull request resolves the following issues and makes some improvements:

Update Dockerfile with the following improvements

Fix previous docker build error
Update Rust and Debian base image to the latest version
Enable docker buildx cache for faster build time
Follow docker image best practice by installing minimal dependencies and running with non-root user

Update docker-compose.yaml and docker-compose.postgres.yaml to fix deployment error

Use the docker compose secret feature to manage confidential environment variables
Watch file changes and rebuild the container during local development

Add CONTRIBUTING.md to explain the local development process
Remove the old infra directory

This looks good, but trying to run locally. The docker container for the warg-server is bound to the port but isn't responding to my HTTP requests. For both the in memory and Postgres implementations. Not sure what is going on. Still investigating.

Thank you!
This looks good, but trying to run locally. The docker container for the warg-server is bound to the port but isn't responding to my HTTP requests. For both the in memory and Postgres implementations. Not sure what is going on. Still investigating.

Found the issue! In Docker, <IP_ADDRESS> is “this container” not “this machine”. We need to bind the warg-server to <IP_ADDRESS> instead of <IP_ADDRESS>. Pushed that change.


Add init fill-config-transformer CLI command

Description

This command reads the Hugging Face model name and revision from the initialize.components.transformer.encoder_loader config section, fetches its config from the HF Model Hub and fills in the entry point parameters for the same.
Types of change

New feature
Checklist

[x] I confirm that I have the right to submit this contribution under the project's MIT license.
[x] I ran the tests, and all new and existing tests passed.
[ ] My changes don't require a change to the documentation, or if they do, I've added all required information.

I could run the CLI command for the prefilled config snippets, but there's still no way for users to get to an initial config:
nlp.add_pipe("curated_transformer")

or
spacy init config -p curated_transformer

both fail with:
Config validation error
curated_transformer.model -> vocab_size	field required
{'@architectures': 'spacy-curated-transformers.XlmrTransformer.v1', 'piece_encoder': {'@architectures': 'spacy-curated-transformers.XlmrSentencepieceEncoder.v1'}, 'with_spans': {'@architectures': 'spacy-curated-transformers.WithStridedSpans.v1'}}

I could run the CLI command for the prefilled config snippets, but there's still no way for users to get to an initial config:

Fixed in #20.

I think that this command should include an option to fill in both the model loader and the piecer.
Right now (with the vocab_size) I get this far:
$ spacy init config -p curated_transformer config.cfg
$ spacy init fill-config-transformer config.cfg
ℹ Updating config for Curated Transformer pipe

'curated_transformer'

✘ Pipeline config does not have a valid model loader configuration for
the 'curated_transformer' Curated Transformer component

I feel like I should be able provide something like xlm-roberta-base as a command-line option to get the full [initialize] block? I don't think it needs to go beyond supporting HF models (similiar to the rest), but some way to get to a full config that I can then use with spacy train?

I feel like I should be able provide something like xlm-roberta-base as a command-line option to get the full [initialize] block? I don't think it needs to go beyond supporting HF models (similiar to the rest), but some way to get to a full config that I can then use with spacy train?

Added.

And I think fill-config-transformer is going to be a confusing name and make it not obvious it's for curated_transformer only. Not that there are a lot of good choices...
Let's see, to get started:

fill-curated-config
fill-curated-transformer

I don't like the way that fill doesn't mean quite the same thing as in fill-config, but the alternatives are probably worse.

Can you tell the user based on the downloaded model which kind of architecture they probably need? (Like, I was even confused by the naming of something that looks like bert but wasn't.)

I've expanded the error message to display either the expected HF model type for the given curated transformers architecture (in case the type of the HF model is not supported) or the correct curated transformers architecture (if the HF model type is supported).

I don't like the way that fill doesn't mean quite the same thing as in fill-config, but the alternatives are probably worse.

I was actually thinking the same earlier. What about update instead of fill? 🤔

I was actually thinking the same earlier. What about update instead of fill? 🤔

I'd still keep fill as the grand majority of the fields being added are actually missing in the config, i.e., there are no keys for them (as opposed to updating the values of existing keys).


Code from Will Spooner to improve sub population_structure.

Instead of using hardcoded regex for ':ALL', now looks for leaf node of population hierarchy and works it's way up. Therefore will work for population structures of varying depth.

Hi Dan / @willmclaren, is this for release 85 ? Steve

We don't need it, so I guess up to @dbarrell ?

You are right - you only need it if you want to display sub populations from a species that does not have the exact same sub population structure as human does, so ensembl doesn't need it whilst you only have transcript haplotypes for human. However this makes it generic to any sub population depth so it would be good to merge in for the future 🔮

Ok, I'll take this diff, merge it into master now (as it's on a very wrong branch because of the delay), and close the pr.

Ok, I've taken a look at the code and @willmclaren and @ens-ap5 have extensively modified the point at which the patch would be applied, so it's no longer a no-brainer. Does this still need applying? Is it worth reworking the patch?

Hi Dan (S) Dang looks like I missed this. It would be really good if it could be applied else I'm going to have to re-write this at every release and make another PR

We can't merge this pull request directly because of Will's changes (mine are irrelevant, they're just caused by moving this module from its original plugin). Since I'm not familiar with the underlying data and API, I think @willmclaren  needs to look at it. It's only a few lines so could be done manually with little effort.

Will has written a compatible replacement.

Thanks Folks!


refactor: general refactor/fixes

This PR:

Fixes the utility function getDecoratorName. Currently, it throws an error if you try to get a name of a decorator that isn't a call expression; (porting from #794)
Fixes the assertMultipleAnnotated helper (Currently it doesn't work well as I mentioned in other issues/PRs);
Changes Boolean checks to the utility function isNotNullOrUndefined (I've added a mini explanation in that file);
Adds a tslint rule to enforce file names casing as camelCase;
Removes the tslint unused rule variable-name;
Adds missing angular decorators in utils;
Normalizes the enums, constants, interfaces and types names to Angular-*;

By the way, what's the convention about utils? Should we put every helper into the utils file or we should try to separate in small files?

Not a big fan of packages called utils in general. If the file grows too much, we should probably think of a better way to organize the helpers.

friendly bump :)

@wKoza would you be able to help reviewing? I'm on the road for the next two weeks.

@rafaelss95 , I'll take a look at this next week.


Fixing Vulnerabilities

[x] No CHANGELOG update needed
Please look at the commits to view each file's details and their objectives.

hey @4k4xs4pH1r3 thanks for proposing these checks!
would you please confirm that you intend to sign the CLA? unfortunately we're unable to accept contributions without the CLA.
also, can you show us any examples of the output? i've heard of many of these tools and am interested to see the sorts of things they'll bring to capa.

hey @4k4xs4pH1r3 thanks for proposing these checks!
would you please confirm that you intend to sign the CLA? unfortunately we're unable to accept contributions without the CLA.
also, can you show us any examples of the output? i've heard of many of these tools and am interested to see the sorts of things they'll bring to capa.

@williballenthin Yes, I already signed the Google CLA.
The objective of this pull request is this= https://github.com/mandiant/capa/pull/1706#issuecomment-1674120460
And the output will notify You about fixes here https://github.com/notifications; this is the implementation of the below=
1. Security (Standard: Robust Security Measures)
Implement robust AutoDevSecOps security measures throughout the Software Development Life Cycle (SDLC) to protect the integrity and confidentiality of the code and data to be under compliance with Static Application Security Testing (SAST),  Dynamic Application Security Testing (DAST), Interactive Application Security Testing (IAST), Runtime Application Self-Protection  (RASP), Infrastructure as Code (IaC) Scanning, Breach and Attack Simulation (BAS), Dependency Scanning, Container Scanning, Secret Detection, Coverage Fuzzing, API Fuzzing, Cluster Image Scanning security tests and other future SDLC solutions that help to protect the pipelines.
Conduct regular Security code reviews, security scans, Threat modeling: and penetration testing to identify and address vulnerabilities.
Follow security best practices and standards, considering access controls, authentication, encryption, and secure coding practices.
2. Compliance (Standard: Adherence to Industry Regulations and Standards)
Adhere to industry regulations and standards related to data security, privacy, and any other applicable compliance requirements.
Ensure the development and deployment processes align with relevant legal and regulatory frameworks.
Establish mechanisms to track and demonstrate compliance, such as maintaining audit logs and documentation.
Implement relevant frameworks, such as GDPR, HIPAA, PCI-DSS, ISO2700x, SOC 2, and all the others required by the countries/industries/applications to protect customer data and maintain legal compliance.
Like this=

this is neat @4k4xs4pH1r3 I would like to enable these scans. i've added a few comments inline. let me know if you're able to address them; otherwise, we can take a stab as we have time.
thanks!

this is neat @4k4xs4pH1r3 I would like to enable these scans. i've added a few comments inline. let me know if you're able to address them; otherwise, we can take a stab as we have time.
thanks!

hello @williballenthin  done

CLA failure is due to the Mend.io bot. i'll see if i can register/fix that with the CLA checker.

@4k4xs4pH1r3 i'm happy and excited to merge this PR; however, it doesn't seem to work as-is (see CI failures) and since i dont yet know the systems, im not prepared to try to fix them. would you please help us get to a known-good state so that we can merge and maintain from there?

@4k4xs4pH1r3 i'm happy and excited to merge this PR; however, it doesn't seem to work as-is (see CI failures) and since i dont yet know the systems, im not prepared to try to fix them. would you please help us get to a known-good state so that we can merge and maintain from there?

@williballenthin sure i'll fix those, working on them now, thank you.

Hey @4k4xs4pH1r3, is initiative still ongoing?

Hey @4k4xs4pH1r3, is initiative still ongoing?

Hello @mr-tz yes I'm working on this, I'll back to You soon

hi @4k4xs4pH1r3
Thanks for your continued work on this PR. At this time I'm not comfortable with the changes. There are too many new checks added. This is a problem for a few reasons:

we don't know nor trust the source of all the actions, so incorporating them into our CI pipeline introduces a supply chain risk to our project.
many of the pipelines obviously don't apply to our project, like the C++ and Ruby linters for our pure Python code.
the CI steps take time and resources, consuming our quota and slowing us from getting relevant notices.

That being said, there are still some useful nuggets in here. If you would prune the PR to a handful of key changes then I'd be willing to consider those.

Closing this to prevent new (and maybe cancel existing) Checks workflow runs.
Please create a new PR with appropriate changes as per Willi's comment.


[DNM] 1665 soft delete support users

Context
Depends on https://github.com/DFE-Digital/apply-for-postgraduate-teacher-training/pull/1504

We've recently added the ability to delete support users, but we need to retain the records for the audit history to work correctly so soft deletion is the better option.
Changes proposed in this pull request

Adds the paranoia gem
Applies soft deletion to SupportUser model

Guidance to review

Link to Trello card
https://trello.com/c/AYxmAxXj/1665-offboarding-from-support

Things to check

[x] This code doesn't rely on migrations in the same Pull Request
[x] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[x] API release notes have been updated if necessary
[x] New environment variables have been added to the Azure config

This looks great, but I notice the author of paranoia has deprecated his own gem! Should we consider discard instead? https://github.com/rubysherpas/paranoia/blob/core/README.md https://github.com/jhawthorn/discard#why-not-paranoia-or-acts_as_paranoid

Looking good! Comment above and inline

Closing for now to find an alternative to using paranoia gem

adds paranoia to his list of weirdly named ruby libraries


[build-script-presets] Build llvm backends required to run lldb test

rdar://problem/42920398

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci please smoke test

@shahmishal let's see how long this takes.

@swift-ci please clean smoke test macOS


replace apc panel with wires panel

About the PR

removes some of APC legacy, replaces apc panel with wires panel
Media

Changelog

imo ensuring that a battery can be inserted/removed is crucial for an APC but might be out of scope for this PR, but both of these should be done at some point:

port the APC visualizer to a system
add a battery insertion/removal step to the APC

Given that this PR isn't actively removing the ability to add/remove batteries, I don't see why that should block merging this PR.

Mostly so I know this won't prevent adding it in the future.

If the fear is just that it will conflict with the deconstruction graphs or something like that, the graph can always just be changed to require that the battery has to be pried out first.


是否支持把规则 转换成 SQL语句？

目前能把字符SQL语句转换为节点形式的Java对象，方便取SQL语句的各个部分，有没有可能反过来，把节点形式的Java对象转换为SQL语句？
例如：
{"rules":[
{"field":"OrderDate","op":"less","value":"2012-01-01"},
{"field":"CustomerID","op":"equal","value":"VINET"}
]
,"op":"and"}
转换为：where OrderDate < 2012-01-01 and CustomerID='VINET'

Please change to English.

I want to use JSQLParser  to transform Data Rule into SQL statement.
example:
Data Rule:
{"rules":[
{"field":"OrderDate","op":"less","value":"2012-01-01"},
{"field":"CustomerID","op":"equal","value":"VINET"}
]
,"op":"and"}
change to SQL statement:
where OrderDate < 2012-01-01 and CustomerID='VINET'

I am not sure, if I understand you. JSqlParser is a parser for SQL statements. Do you want it to build a JSqlParser object hierarchy?
I would use a yaml parser like snakeyml and then build up an sql string, traversing the yaml object hierarchy.

Should I close this issue?

yes
<EMAIL_ADDRESS>发件人： Tobias
发送时间： 2018-10-19 03:26
收件人： JSQLParser/JSqlParser
抄送： bjzhangyongbin; Author
主题： Re: [JSQLParser/JSqlParser] 是否支持把规则 转换成 SQL语句？ (#692)
Should I close this issue?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Flatbox firmware ignoring custom pin layout on most recent releases

Prerequisites
Please check the following before posting an issue / bug report.

[x] I am running the latest version of the firmware found HERE
[x] I have checked the documentation HERE and found no answer
[x] I checked to make sure that this issue has not already been filed HERE
[x] I am reporting the issue to the correct repository

Context
Please provide all relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

Firmware Version: 0.7.3/0.7.2
Name of device: FlatboxRev5
Link to where you purchased the device: N/A
Is this a custom build?: No
Operating System: Windows 11
Browser: Firefox

Expected Behavior
The FlatboxRev5 Firmware should properly map the pin layout defined in the BoardConfig.h. e.g. START should be the left most tactile switch.
Current Behavior
Pin layout is using the default GP2040-CE layout. Since the Flatbox does not use the default start button pin at all the web interface is inaccessible. Home is the leftmost tactile switch and START is missing.
Steps to Reproduce

Put board into BOOTSEL mode
Load firmware  GP2040-CE_0.7.3_FlatboxRev5.uf2 or  GP2040-CE_0.7.2_FlatboxRev5.uf2 to the board
Restart board and test buttons

Misc
The BoardConfig.h itself seems to properly define the layout but is being ignored for some reason.
I also tried compiling from source myself and the resulting GP2040-CE_0.7.3_FlatboxRev5.uf2 was still ignoring the custom layout.
Firmware 0.7.1 uses the custom layout properly.

Hi @MGStan0 ,
Can you perform a full Nuke and put the latest Rev 5 UF2 on and see if the issue persists?

That seems to have done it. Now I'm really curious why 0.7.1 worked without nuking.


Select Kernel not finding python interpreter

When I click 'Select Kernel' in a notebook, it can't find my python interpreter, but when I use Python: Select Interpreter, it's able to find my python version. I don't recall this happening before.

Update: I pressed the refresh button in the Select a Python Environment quickpick and it seemed to detect my python then. But without doing that, I couldn't see it appear (as seem in the gif).

Please could you enable logging as follows:

Open settings & go into Jupyter->Logging
Change the value to verbose
Reload VS Code,
Attempt to repro the issue & then copy the output from the Jupyter output panel.


Updated link to match the Godot version used by GDPaho (v3.5)

When I checked the documentation, the link originally provided leads to the official Godot docs about compiling for latest Godot version (+v4.x).
Nevertheless, GDPaho is oriented to be used with Godot v3.5, so I updated the link to point to the v3.5 docs.
I consider this necessary because accessing to the latest doc and using the version switching option will point to a broken link:

Have a nice day! 😊

Thanks !


Added Lithuanian translation

https://lt.wttr.in/Moon works now.
Thank you very much for the contribution.


HLSL results different from FastNoise2 (SIMD) results

Dear @Auburn,
I would like to know if HLSL and FastNoise2 SIMD could produce the exact same values given the same parameters?
My use case is to use it for procedural terrain generator and since all recent PC have both a dedicated GPU and an integrated GPU I would like to use HLSL compute shader on iGPU when possible and fallback to SIMD on CPU when not (for instance, server side or old PCs).
I tried on my AMD Ryzen 9 7940HS w/ Radeon 780M Graphics and the difference is huge. But the results differs.
// For 4096 * 4096 2D OpenSimplex2
Compute shader took : 0.117000 ms
SIMD took : 2462.604980 ms

I checked if this was an issue from my implementation but when using NoiseTool and your example website and the results differ as well.

Would love to get the same values 🙏
EDIT: Additionally do you think we could build the same SmartNode tree in HLSL?

The 2 libraries use different hashing functions for performance reasons. If you brought the FN2 hashing function over to FNL they should give the same output. I remember that someone in the past had done this already, it was discussed on discord.
Unrelated but the problem with your plan is that most iGPUs get disabled when running a dedicated GPU, unless explicitly enabled in bios

In FN2 HashPrimesHB is used for cellular noise and domain warping, so you'd need implement that too if you need those to match. But otherwise you just need to convert HashPrimes and GradCoord functions you posted above to HLSL


Add a simple-to-understand example for online DPO

This PR adds a simple-to-understand example for online DPO

🔥

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Training also works with the dummy example


Fixed many small phpcs issues

This pr fixes many small phpcs issues

This shall be ready now, since 2.5 is out

I rebased the branch, should be good to merge!

@acrobat I rebased and applied this to master, thanks a lot!


Solutions refactor

@rubenvanassche hi, why am i getting a lot of warnings?
Warning: Ambiguous class resolution, "Spatie\LaravelIgnition\Solutions\GenerateAppKeySolution" was found in both "/vendor/spatie/error-solutions/legacy/laravel-ignition\Solutions\GenerateAppKeySolution.php" and "/vendor/spatie/laravel-ignition/src\Solutions\GenerateAppKeySolution.php", the first will be used.
Warning: Ambiguous class resolution, "Spatie\LaravelIgnition\Solutions\LivewireDiscoverSolution" was found in both "/vendor/spatie/error-solutions/legacy/laravel-ignition\Solutions\LivewireDiscoverSolution.php" and "/vendor/spatie/laravel-ignition/src\Solutions\LivewireDiscoverSolution.php", the first will be used.
Warning: Ambiguous class resolution, "Spatie\LaravelIgnition\Solutions\MakeViewVariableOptionalSolution" was found in both "/vendor/spatie/error-solutions/legacy/laravel-ignition\Solutions\MakeViewVariableOptionalSolution.php" and "/vendor/spatie/laravel-ignition/src\Solutions\MakeViewVariableOptionalSolution.php", the first will be used.
Warning: Ambiguous class resolution, "Spatie\LaravelIgnition\Solutions\RunMigrationsSolution" was found in both "/vendor/spatie/error-solutions/legacy/laravel-ignition\Solutions\RunMigrationsSolution.php" and "/vendor/spatie/laravel-ignition/src\Solutions\RunMigrationsSolution.php", the first will be used.
Warning: Ambiguous class resolution, "Spatie\LaravelIgnition\Solutions\SolutionProviders\DefaultDbNameSolutionProvider" was found in both "/vendor/spatie/error-solutions/legacy/laravel-ignition\Solutions\SolutionProviders\DefaultDbNameSolutionProvider.php" and "/vendor/spatie/laravel-ignition/src\Solutions\SolutionProviders\DefaultDbNameSolutionProvider.php", the first will be used.
Warning: Ambiguous class resolution, "Spatie\LaravelIgnition\Solutions\SolutionProviders\GenericLaravelExceptionSolutionProvider" was found in both "/vendor/spatie/error-solutions/legacy/laravel-ignition\Solutions\SolutionProviders\GenericLaravelExceptionSolutionProvider.php" and "/vendor/spatie/laravel-ignition/src\Solutions\SolutionProviders\GenericLaravelExceptionSolutionProvider.php", the first will be used.
Warning: Ambiguous class resolution, "Spatie\LaravelIgnition\Solutions\SolutionProviders\IncorrectValetDbCredentialsSolutionProvider" was found in both "/vendor/spatie/error-solutions/legacy/laravel-ignition\Solutions\SolutionProviders\IncorrectValetDbCredentialsSolutionProvider.php" and "/vendor/spatie/laravel-ignition/src\Solutions\SolutionProviders\IncorrectValetDbCredentialsSolutionProvider.php", the first will be used.
Warning: Ambiguous class resolution, "Spatie\LaravelIgnition\Solutions\SolutionProviders\InvalidRouteActionSolutionProvider" was found in both "/vendor/spatie/error-solutions/legacy/laravel-ignition\Solutions\SolutionProviders\InvalidRouteActionSolutionProvider.php" and "/vendor/spatie/laravel-ignition/src\Solutions\SolutionProviders\InvalidRouteActionSolutionProvider.php", the first will be used.
Warning: Ambiguous class resolution, "Spatie\LaravelIgnition\Solutions\SolutionProviders\LazyLoadingViolationSolutionProvider" was found in both "/vendor/spatie/error-solutions/legacy/laravel-ignition\Solutions\SolutionProviders\LazyLoadingViolationSolutionProvider.php" and "/vendor/spatie/laravel-ignition/src\Solutions\SolutionProviders\LazyLoadingViolationSolutionProvider.php", the first will be used.
Warning: Ambiguous class resolution, "Spatie\LaravelIgnition\Solutions\SolutionProviders\MissingAppKeySolutionProvider" was found in both "/vendor/spatie/error-solutions/legacy/laravel-ignition\Solutions\SolutionProviders\MissingAppKeySolutionProvider.php" and "/vendor/spatie/laravel-ignition/src\Solutions\SolutionProviders\MissingAppKeySolutionProvider.php", the first will be used.
Warning: Ambiguous class resolution, "Spatie\LaravelIgnition\Solutions\SolutionProviders\MissingColumnSolutionProvider" was found in both "/vendor/spatie/error-solutions/legacy/laravel-ignition\Solutions\SolutionProviders\MissingColumnSolutionProvider.php" and "/vendor/spatie/laravel-ignition/src\Solutions\SolutionProviders\MissingColumnSolutionProvider.php", the first will be used.
Warning: Ambiguous class resolution, "Spatie\LaravelIgnition\Solutions\SolutionProviders\MissingImportSolutionProvider" was found in both "/vendor/spatie/error-solutions/legacy/laravel-ignition\Solutions\SolutionProviders\MissingImportSolutionProvider.php" and "/vendor/spatie/laravel-ignition/src\Solutions\SolutionProviders\MissingImportSolutionProvider.php", the first will be used.
Warning: Ambiguous class resolution, "Spatie\LaravelIgnition\Solutions\SolutionProviders\MissingLivewireComponentSolutionProvider" was found in both "/vendor/spatie/error-solutions/legacy/laravel-ignition\Solutions\SolutionProviders\MissingLivewireComponentSolutionProvider.php" and "/vendor/spatie/laravel-ignition/src\Solutions\SolutionProviders\MissingLivewireComponentSolutionProvider.php", the first will be used.
Warning: Ambiguous class resolution, "Spatie\LaravelIgnition\Solutions\SolutionProviders\MissingMixManifestSolutionProvider" was found in both "/vendor/spatie/error-solutions/legacy/laravel-ignition\Solutions\SolutionProviders\MissingMixManifestSolutionProvider.php" and "/vendor/spatie/laravel-ignition/src\Solutions\SolutionProviders\MissingMixManifestSolutionProvider.php", the first will be used.
Warning: Ambiguous class resolution, "Spatie\LaravelIgnition\Solutions\SolutionProviders\MissingViteManifestSolutionProvider" was found in both "/vendor/spatie/error-solutions/legacy/laravel-ignition\Solutions\SolutionProviders\MissingViteManifestSolutionProvider.php" and "/vendor/spatie/laravel-ignition/src\Solutions\SolutionProviders\MissingViteManifestSolutionProvider.php", the first will be used.
Warning: Ambiguous class resolution, "Spatie\LaravelIgnition\Solutions\SolutionProviders\RouteNotDefinedSolutionProvider" was found in both "/vendor/spatie/error-solutions/legacy/laravel-ignition\Solutions\SolutionProviders\RouteNotDefinedSolutionProvider.php" and "/vendor/spatie/laravel-ignition/src\Solutions\SolutionProviders\RouteNotDefinedSolutionProvider.php", the first will be used.
Warning: Ambiguous class resolution, "Spatie\LaravelIgnition\Solutions\SolutionProviders\RunningLaravelDuskInProductionProvider" was found in both "/vendor/spatie/error-solutions/legacy/laravel-ignition\Solutions\SolutionProviders\RunningLaravelDuskInProductionProvider.php" and "/vendor/spatie/laravel-ignition/src\Solutions\SolutionProviders\RunningLaravelDuskInProductionProvider.php", the first will be used.
Warning: Ambiguous class resolution, "Spatie\LaravelIgnition\Solutions\SolutionProviders\SolutionProviderRepository" was found in both "/vendor/spatie/error-solutions/legacy/laravel-ignition\Solutions\SolutionProviders\SolutionProviderRepository.php" and "/vendor/spatie/laravel-ignition/src\Solutions\SolutionProviders\SolutionProviderRepository.php", the first will be used.
Warning: Ambiguous class resolution, "Spatie\LaravelIgnition\Solutions\SolutionProviders\TableNotFoundSolutionProvider" was found in both "/vendor/spatie/error-solutions/legacy/laravel-ignition\Solutions\SolutionProviders\TableNotFoundSolutionProvider.php" and "/vendor/spatie/laravel-ignition/src\Solutions\SolutionProviders\TableNotFoundSolutionProvider.php", the first will be used.
Warning: Ambiguous class resolution, "Spatie\LaravelIgnition\Solutions\SolutionProviders\UndefinedLivewireMethodSolutionProvider" was found in both "/vendor/spatie/error-solutions/legacy/laravel-ignition\Solutions\SolutionProviders\UndefinedLivewireMethodSolutionProvider.php" and "/vendor/spatie/laravel-ignition/src\Solutions\SolutionProviders\UndefinedLivewireMethodSolutionProvider.php", the first will be used.
Warning: Ambiguous class resolution, "Spatie\LaravelIgnition\Solutions\SolutionProviders\UndefinedLivewirePropertySolutionProvider" was found in both "/vendor/spatie/error-solutions/legacy/laravel-ignition\Solutions\SolutionProviders\UndefinedLivewirePropertySolutionProvider.php" and "/vendor/spatie/laravel-ignition/src\Solutions\SolutionProviders\UndefinedLivewirePropertySolutionProvider.php", the first will be used.
Warning: Ambiguous class resolution, "Spatie\LaravelIgnition\Solutions\SolutionProviders\UndefinedViewVariableSolutionProvider" was found in both "/vendor/spatie/error-solutions/legacy/laravel-ignition\Solutions\SolutionProviders\UndefinedViewVariableSolutionProvider.php" and "/vendor/spatie/laravel-ignition/src\Solutions\SolutionProviders\UndefinedViewVariableSolutionProvider.php", the first will be used.
Warning: Ambiguous class resolution, "Spatie\LaravelIgnition\Solutions\SolutionProviders\UnknownValidationSolutionProvider" was found in both "/vendor/spatie/error-solutions/legacy/laravel-ignition\Solutions\SolutionProviders\UnknownValidationSolutionProvider.php" and "/vendor/spatie/laravel-ignition/src\Solutions\SolutionProviders\UnknownValidationSolutionProvider.php", the first will be used.
Warning: Ambiguous class resolution, "Spatie\LaravelIgnition\Solutions\SolutionProviders\ViewNotFoundSolutionProvider" was found in both "/vendor/spatie/error-solutions/legacy/laravel-ignition\Solutions\SolutionProviders\ViewNotFoundSolutionProvider.php" and "/vendor/spatie/laravel-ignition/src\Solutions\SolutionProviders\ViewNotFoundSolutionProvider.php", the first will be used.
Warning: Ambiguous class resolution, "Spatie\LaravelIgnition\Solutions\SuggestCorrectVariableNameSolution" was found in both "/vendor/spatie/error-solutions/legacy/laravel-ignition\Solutions\SuggestCorrectVariableNameSolution.php" and "/vendor/spatie/laravel-ignition/src\Solutions\SuggestCorrectVariableNameSolution.php", the first will be used.
Warning: Ambiguous class resolution, "Spatie\LaravelIgnition\Solutions\SuggestImportSolution" was found in both "/vendor/spatie/error-solutions/legacy/laravel-ignition\Solutions\SuggestImportSolution.php" and "/vendor/spatie/laravel-ignition/src\Solutions\SuggestImportSolution.php", the first will be used.
Warning: Ambiguous class resolution, "Spatie\LaravelIgnition\Solutions\SuggestLivewireMethodNameSolution" was found in both "/vendor/spatie/error-solutions/legacy/laravel-ignition\Solutions\SuggestLivewireMethodNameSolution.php" and "/vendor/spatie/laravel-ignition/src\Solutions\SuggestLivewireMethodNameSolution.php", the first will be used.
Warning: Ambiguous class resolution, "Spatie\LaravelIgnition\Solutions\SuggestLivewirePropertyNameSolution" was found in both "/vendor/spatie/error-solutions/legacy/laravel-ignition\Solutions\SuggestLivewirePropertyNameSolution.php" and "/vendor/spatie/laravel-ignition/src\Solutions\SuggestLivewirePropertyNameSolution.php", the first will be used.
Warning: Ambiguous class resolution, "Spatie\LaravelIgnition\Solutions\SuggestUsingCorrectDbNameSolution" was found in both "/vendor/spatie/error-solutions/legacy/laravel-ignition\Solutions\SuggestUsingCorrectDbNameSolution.php" and "/vendor/spatie/laravel-ignition/src\Solutions\SuggestUsingCorrectDbNameSolution.php", the first will be used.
Warning: Ambiguous class resolution, "Spatie\LaravelIgnition\Solutions\UseDefaultValetDbCredentialsSolution" was found in both "/vendor/spatie/error-solutions/legacy/laravel-ignition\Solutions\UseDefaultValetDbCredentialsSolution.php" and "/vendor/spatie/laravel-ignition/src\Solutions\UseDefaultValetDbCredentialsSolution.php", the first will be used.


Adding State of Maryland

Just added Montgomery County, MD in #902 but then realized there's a state layer already referenced in #726 with coverage of the same area.  However, this shapefile source is a different data url as #726 was one the troublesome Esri portal sources.  Does not cover entire State so some other individual county sources may be added.
If we're not including duplicates introduced by overlapping state and county sources then we'll need to figure out a way to rectify that.

Overlapping datasets is OK. We'll end up with duplicate rows in the dataset but we'll worry about that later.

@iandees Great.  This can be merged then

Cool, I was waiting for the tests to pass and will merge away now.


Add region and service AWS destination auth config

Work in progress: https://github.com/hookdeck/terraform-provider-hookdeck/pull/116
Docs
https://hookdeck.com/docs/api#update-a-destination#update-a-destination

Dashboard

Hey @leggetter, just wondering how I can take this on. It seems the codegen is working but the SDK is not fully updated?

@alexluong I've updated the codegen to use the API spec in source control to ensure that all assets are based of off content in source control. This has stopped the codegen failing.
The current Go SDK release does support service and region.
See https://github.com/hookdeck/terraform-provider-hookdeck/pull/116

Makes sense, in that case it seems you can take it from here, right?

Makes sense, in that case it seems you can take it from here, right?

if you have a mo, I could do with a review of #116 to see why the output seems to skip the region and service.

Fixed in https://github.com/hookdeck/terraform-provider-hookdeck/pull/116


[2.1|3.0] Factory-Muffin support for fixture generation

or something with simililar behavior
https://github.com/thephpleague/factory-muffin
http://codeception.com/docs/modules/DataFactory
pros:

more flexible than current fixture generator
relation dependencies supported too
useful  for full database seeding (for acceptance/functional tests) as well as partial seeding for unit tests and  in-place seeding

cons:

don't know

I think we'll need abstraction layer for fixture generator.


feat: support Gatsby 4

Description

This PR adds support for Gatsby 4 by updating the peer dependency version. The plugin should already be compatible with Gatsby 4 so this PR just makes it explicit.
All dev-and-e2e dependencies have been updated to support Node 17 as used in Travis CI.

Checklist: New Feature

[ ] The target branch is beta. This is important for our CI/CD config.
[x] Each commit follows the conventional commit spec format: e.g. chore(readme): fixed typo. See the end of this file for more information.
[ ] Any breaking changes are specified on the commit on which they are introduced with BREAKING CHANGE in the body of the commit.
[ ] If this is a big feature with breaking changes, consider opening an issue to discuss first. This is completely up to you, but please keep in mind that your PR might not be accepted.
[x] Run unit tests to ensure all existing tests are still passing
[ ] Add new passing unit tests to cover the code introduced by your PR
[ ] Update the readme
[ ] Add some steps so we can test your cool new feature!

Thanks @frederickfogerty! That revert was to cover up a mistake once I figured out how to run the e2e tests locally. 😅


use pf-tabs in React project will get error

Description of the issue
When I use pf-tabs in a React project, it will show errors in console, and pf-tabs is not be able to render as expected
The other components like pf-tab and pf-tab-panel works good

Impacted component(s)

pf-tabs

Steps to reproduce
https://stackblitz.com/edit/vitejs-vite-sq6x63?file=src/App.tsx
Expected behavior

Screenshots

Related issues

This issue still present in latest v2.2.1 @bennypowers
https://stackblitz.com/edit/vitejs-vite-d4qjyz

Thanks for the report. The problem is here https://github.com/patternfly/patternfly-elements/blob/933a0d6dd06c33d43291e5ed0ab87914fefd9a67/elements/pf-tabs/BaseTabPanel.ts#L10
i will issue a pr soon, as I'm travelling

please try with https://github.com/patternfly/patternfly-elements/releases/tag/%40patternfly/elements%402.2.2


update issue.go documentation for %n

Closes #1972
Summary of change

Adds a line explaining the use of %n to the --format description.

Thanks, but closing in favor of https://github.com/github/hub/pull/1976 where I also add the documentation about %n to hub release and hub pr commands, as well as adding the documentation about %% (and fixing a bug in the process)


Rename extras to prep

DI source

Rename extras to prep
Add contexts to docstrings
Make wrong-mode pushforward and pullbacks return the right array type (fix #482)
Get rid of maybe_inner, maybe_outer and maybe_dense_ad by adding dispatches for inner, outer and dense_ad on AbstractADType

DI docs

Rename extras to prep

Codecov Report
Attention: Patch coverage is 19.59545% with 636 lines in your changes missing coverage. Please review.

Project coverage is 12.02%. Comparing base (097930a) to head (248a6c9).

Files with missing lines
Patch %
Lines

...entiationInterfaceTest/src/tests/benchmark_eval.jl
0.00%
68 Missing :warning:

...tionInterfaceTest/src/tests/type_stability_eval.jl
0.00%
56 Missing :warning:

...entiationInterfaceFastDifferentiationExt/onearg.jl
0.00%
51 Missing :warning:

...tiationInterfaceTest/src/tests/correctness_eval.jl
0.00%
48 Missing :warning:

...t/DifferentiationInterfaceForwardDiffExt/onearg.jl
0.00%
32 Missing :warning:

...ext/DifferentiationInterfaceSymbolicsExt/onearg.jl
0.00%
32 Missing :warning:

...faceZygoteExt/DifferentiationInterfaceZygoteExt.jl
0.00%
31 Missing :warning:

...ntiationInterfacePolyesterForwardDiffExt/onearg.jl
0.00%
26 Missing :warning:

...ationInterfaceSparseMatrixColoringsExt/jacobian.jl
0.00%
22 Missing :warning:

...entiationInterfaceFastDifferentiationExt/twoarg.jl
0.00%
21 Missing :warning:

... and 28 more

:exclamation:  There is a different number of reports uploaded between BASE (097930a) and HEAD (248a6c9). Click for more details.
HEAD has 51 uploads less than BASE

Flag
BASE (097930a)
HEAD (248a6c9)

DI
45
3

DIT
10
1

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #491       +/-   ##
===========================================
- Coverage   97.87%   12.02%   -85.85%
===========================================
  Files         107       92       -15
  Lines        4322     4134      -188
===========================================
- Hits         4230      497     -3733
- Misses         92     3637     +3545

Flag
Coverage Δ

DI
18.05% <25.70%> (-80.26%)
:arrow_down:

DIT
0.14% <0.00%> (-96.82%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


fix: typo

This is a breaking change, for the record, since nodes are renamed, which breaks downstream queries.

Oh, I didn't know. Shall I close this then? It's not really important to fix this.

Just make it fix! and explicitly list the change to grammar.js. (It's embarrassing enough to have this fixed now that it's our problem.)


parse rawXML into document only once

I noticed that getDocument parses the contents of rawXML for each invocation of extractString.
Here I'm using a setter for rawXML to parse rawXML once after changing its value so that getConfig can now return this prepared Document. Current unit tests pass and even run a tiiiiny bit faster than before.

thanks a lot!