Unable to determine hardware version. I see: Hardware	: BCM2835

Getting below error
Unable to determine hardware version. I see: Hardware : BCM2835

expecting BCM2708 or BCM2709

which raspberry are you using?
seems to be related to "wiring-pi" unable to determine your raspberry pi version.
regards
Tristan

Raspberry pi 3 Model B running raspbian-jessie-lite 4.9.16-v7

Okay.. i researched you issue
it seems to be related to the new Kernel Version 4.9
there is already an issue in the Wiring-Pi Module:
https://github.com/WiringPi/WiringPi-Node/issues/70
hopefully the will update Wiring-Pi soon..
or we have to switch to another GPIO library which is better maintained.

thanks, i will try on older version of kernel.

i changed to a fixed wiringpi library
https://github.com/firsttris/mfrc522-rpi/commit/20b2fe60b8da27912992e1bf425f290a1deefea7
should be working now on Kernel Version 4.9

thanks, i will check and confirm.

4.9.35-v7+ #1014 SMP Fri Jun 30 14:47:43 BST 2017 armv7l GNU/Linux
does not work for me

i used 1.2 snap shot and upgraded . iupdated etc then it worked for me

com.pi4j
pi4j-core
1.2-SNAPSHOT

oss-snapshots-repo
Sonatype OSS Maven Repository
https://oss.sonatype.org/content/groups/public

true
always

java -Dpi4j.linking=dynamic ....


Do not filter COLORTERM

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?

COLORTERM can be used by editors, which are called by brew edit.

COLORTERM can be used by editors

Which editors? What does it do?

In fact, any program can make use of COLORTERM to check if the terminal supports truecolor, like using TERM to check the capability.
I used "editors" as an example because my .vimrc uses the env variable to check the truecolor support and switch features.

In fact, any program can make use of COLORTERM to check if the terminal supports truecolor, like using TERM to check the capability.

Any program can use any arbitrary variable, sure.

I used "editors" as an example because my .vimrc uses the env variable to check the truecolor support and switch features.

So in this case you mean it's actually just your local configuration? If so, set HOMEBREW_COLORTERM and check that instead.
Passing on this, sorry.

COLORTERM is a common environmental variable that is automatically set by terminal emulators, and is the de-facto way for programs to check if a terminal supports truecolor support.
https://github.com/termstandard/colors#checking-for-colorterm
Though I use that just for tweaking my editor, that is more potential.


Unable to build latest dev

Unable to build latest dev - getting 100s of NU errors causing failed restores.
Followed the Wiki steps for troubleshooting without any success
Installing Microsoft.Extensions.DependencyInjection 2.1.0-preview3-32037.
C:\Code\EntityFramework\samples\OracleProvider\src\OracleProvider\OracleProvider.csproj : error NU1603: Microsoft.EntityFrameworkCore.Oracle depends on Microsoft.Extensions.DependencyInjection (>= 2.1.0-preview1-27399) but Microsoft.Extensions.DependencyInjection 2.1.0-preview1-27399 was not found. An approximate best match of Microsoft.Extensions.DependencyInjection 2.1.0-preview1-27562 was resolved. [C:\Code\EntityFramework\EFCore.sln]
C:\Code\EntityFramework\samples\OracleProvider\src\OracleProvider\OracleProvider.csproj : error NU1605: Detected package downgrade: Microsoft.Extensions.DependencyInjection from 2.1.0-preview3-32037 to 2.1.0-preview1-27562. Reference the package directly from the project to select a different version.  [C:\Code\EntityFramework\EFCore.sln]
C:\Code\EntityFramework\samples\OracleProvider\src\OracleProvider\OracleProvider.csproj : error NU1605:  Microsoft.EntityFrameworkCore.Oracle -> Microsoft.EntityFrameworkCore.Relational -> Microsoft.EntityFrameworkCore -> Microsoft.Extensions.DependencyInjection (>= 2.1.0-preview3-32037)  [C:\Code\EntityFramework\EFCore.sln]
C:\Code\EntityFramework\samples\OracleProvider\src\OracleProvider\OracleProvider.csproj : error NU1605:  Microsoft.EntityFrameworkCore.Oracle -> Microsoft.Extensions.DependencyInjection (>= 2.1.0-preview1-27399) [C:\Code\EntityFramework\EFCore.sln]
  Restore failed in 9,2 sec for C:\Code\EntityFramework\samples\OracleProvider\src\OracleProvider\OracleProvider.csproj.

Steps to reproduce
Get latest dev
Run : build.cmd /t:Compile from command line
Further technical details
EF Core version: Latest dev
Database Provider: N/A
Operating system: Win 19
IDE: N/A (VS 15.6)

@ErikEJ  it can be a problem on your end.
I just built latest dev using build /t:Package.
Did you try, what described here https://github.com/aspnet/EntityFrameworkCore/wiki/Getting-and-Building-the-Code in Solving common build errors section?

Thanks, I did follow the troubleshooting steps, no luck

@ErikEJ we were seeing something similar on Friday too, but now it works for us. Can you try again?

I will, thanks!


Handle newlines in blocks caused by conflict with goimports

Multi-line comments separated with newlines cause conflicts with goimports.
Given:
package proc

import (
	"github.com/a/b"
	"github.com/local/foo"

	// A multi-line comment explaining what this dependency
	// is used for or what it initializes.
	_ "github.com/client/auth"
)

sections:
  - Standard
  - Default
  - Prefix(github.com/local)

The result is:
package proc

import (
	"github.com/a/b"
	// A multi-line comment explaining what this dependency
	// is used for or what it initializes.
	_ "github.com/client/auth"

	"github.com/local/foo"
)

But goimports will format it as:
package proc

import (
	"github.com/a/b"

	// A multi-line comment explaining what this dependency
	// is used for or what it initializes.
	_ "github.com/client/auth"

	"github.com/local/foo"
)

This means that the two cannot be used together, e.g. with golangci-lint.

If you want gci work with goimports, you should add Prefix(github.com/a) and Prefix(github.com/client), since they are belonged to the same type but a different way to group.

Although there is a conflict, golangci-lint would return a definite result. Also, you can skip use GCI for some files with golangci-lint config.

Yes, that is one workaround. Still, the actual gci invocation has to be adapted to ignore that one file.
It would be great if golangci-lint could apply the fixes from gci like with goimports for example

Actually goimports would add an empty line before comments(not only for multi-lines)  which break the sections from gci:
"fmt"
// test1
"go/test1"
// test2
"go/test2"

to
"fmt"

// test1
"go/test1"
// test2
"go/test2"

I really do not like this behavior of goimports

A workaround is that put comments after import.
I do not know why goimports does it.

Close now since no plan to fix, unless more users require it.

This currently is still pretty broken for us. While we can get it working by moving the comment inline ("foo.bar" // my comment), this is not auto-fixed so we end up with much developer pain.

@howardjohn I think you can try without goimports, since its import completion is useless in most cases.

goimports is a requirement for our use cases

@howardjohn I am working on compatible with goimports, also I want to know how you use GCI, single or within golangci-lint？

We use in golangci-lint primarily but I personally use it directly as well
(faster)
On Mon, Aug 29, 2022, 7:55 PM Loong Dai @.***> wrote:

@howardjohn https://github.com/howardjohn I am working on compatible
with goimports, also I want to know how you use GCI, single or within
golangci-lint？
—
Reply to this email directly, view it on GitHub
https://github.com/daixiang0/gci/issues/76#issuecomment-1231081835, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXI7T5OG436HYB7OGTTV3VZ3ZANCNFSM53SB6AEQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

@howardjohn @avorima could you give the smallest GO file to reproduce it?

My initial issue comment would be such an example, but I think the main problem for me was the general handling of comments of gci. These problems have since been fixed and I can live with having to move comments inline.
# If you're looking at this file in a different repo and want to make a change, please go to the
# common-files repo, make the change there and check it in. Then come back to this repo and run
# "make update-common".

service:
  # When updating this, also update the version stored in docker/build-tools/Dockerfile in the istio/tools repo.
  golangci-lint-version: 1.38.x # use the fixed version to not introduce new linters unexpectedly
run:
  # timeout for analysis, e.g. 30s, 5m, default is 1m
  deadline: 20m
  build-tags:
  - integ
  - integfuzz
  # which dirs to skip: they won't be analyzed;
  # can use regexp here: generated.*, regexp is applied on full path;
  # default value is empty list, but next dirs are always skipped independently
  # from this option's value:
  #   	vendor$, third_party$, testdata$, examples$, Godeps$, builtin$
  skip-dirs:
  - genfiles$
  - vendor$

  # which files to skip: they will be analyzed, but issues from them
  # won't be reported. Default value is empty list, but there is
  # no need to include all autogenerated files, we confidently recognize
  # autogenerated files. If it's not please let us know.
  skip-files:
  - ".*\\.pb\\.go"
  - ".*\\.gen\\.go"

linters:
  disable-all: true
  enable:
  - goimports
  - gofumpt
  - gci
  fast: false

linters-settings:
  gci:
    sections:
      - standard # Captures all standard packages if they do not match another section.
      - default # Contains all imports that could not be matched to another section type.
      - prefix(istio.io/) # Groups all imports with the specified Prefix.
  goimports:
    # put imports beginning with prefix after 3rd-party packages;
    # it's a comma-separated list of prefixes
    local-prefixes: istio.io/

issues:

  # Maximum issues count per one linter. Set to 0 to disable. Default is 50.
  max-per-linter: 0

  # Maximum count of issues with the same text. Set to 0 to disable. Default is 3.
  max-same-issues: 0

Will constantly add and remove the extra line

Or remove --fix and it will fail on gci or goimports depending on space exist or not exist

We just bumped into this in https://github.com/caddyserver/caddy/pull/6252 FYI

@mholt thanks for input, I recommand run goimports then gci as README said.

But then it will fail goimports.


Bug fix/curb aardvark foxx cthulhu

This is an attempt to fix the underlying issue in #9719.

These are all untested and I haven't built the frontend yet to check if they actually work.
@hkernbach This PR is based on your PR so merging will merge it into your PR, not devel.


Update exifrenamer to 2.1.3

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

@gobinathm Already created a pull request for this one: https://github.com/caskroom/homebrew-cask/pull/33585

Closed in favour of https://github.com/caskroom/homebrew-cask/pull/33585 as it was made ~20 minutes earlier.


Remove coffee-script MUC

Hello,
It appears as if the coffee to js compiler for the MUC plugin is working. See this PR and this one. See also this PR that generated a massive diff for a small change.
I feel like removing the coffee script and cleaning up the JS will lower the barrier of entry and make PRs easier to digest and less complicated.
I'm more than happy to do this, however I'm seeking opinions.
Thanks!

Yes please!

Please open a pr for this in the new repo and refer this issue.


Endpoint promoted from Beta to Stable, showing up as untested in APISnoop

Description of the Issue:
During the update of the APISnoop website it have been discovers that one endpoint in release 1.19 show up as newly introduced to stable without a conformance test.
Endpoint list:
readNetworkingV1NamespacedIngressStatus
Initial discovery:

Several Ingress endpoints where promoted by PR #89778 17 June 2020 from Beta to Stable
PR #91996 promote the conformance tests for the Ingress endpoints
The test can be found here

Target outcome for this issue:
Determine if:

[x] The endpoint was promoted, but not covered by the test
[x] The endpoint is covered by the test but there is an issue in how the audit events are being gathered.

Proposed Initial steps
Bring the issue under the attention of the owners of PR #89778 & #91996 for feedback.

have reached out to see if this test should have covered the endpoint and it's not being picked up in the audit logs, or if it truly just snuck in.  Will update this ticket based on ensuing conversation.

The endpoint was missed in the Promotion PR from Liggitt's team.
Fixed by @heyste in #93038
/close


Optimize miner payment interaction conctract for gas use

The contract I made https://etherscan.io/address/0x5c2cD95CF750B8f8A4881d96F04bf571A07042B1#code could be improved. Nick and Federico had some ideas about this. Iirc:

use fallback function instead of named function
use assembly for call

This is now tracked in the gp-v2-contracts repo


Improve logic for finding an rmantree

Even if the $RMANTREE is set to a valid rmantree, the addon would fail to load if there's no /opt/pixar or if the rmantree doesn't contain "RenderManProServer" somewhere in it's path.
This change guards against failure if there's no /opt/pixar (or analogous directory on other platforms), determines the version by parsing $rmantree/bin/prman -version instead of the path itself, and streamlines the code to guess the newest installed rmantree.
The later also fixes a bug wherein the scan to try to find the newest rmantree wasn't correctly checking subdirectories of the base relative to the base directory (it was missing a os.path.join(base, d)).

Thanks. AEK.  I thought about using something like the Version variable in prman.py but prman -version would work as well.


remove duplicate keys from builders

Description
remove duplicate keys from builders
Testing
tox results
 108 passed, 1 skipped in 2.02 seconds

Coverage remained the same at 81.746% when pulling 2727dd8506a7dcf19a824a744799534d4b2c2e43 on mprince:duplicate into 38050094e7fca3feef259b0463b0233a58f845f4 on mayn:master.


Show QEMU version in buildlog

Hi,
For debugging purpose it would be nice to print the qemu version in the log file.

Can one of the admins verify this patch?

Can one of the admins verify this patch?


modal.blade.php   BUG

You need to clear w-full, otherwise the size attribute will not take effect and will cause full screen in Windows windows.

Thanks @hupengtao. Will push an update to fix that.

Can you please post a screenshot of how the modal is currently displayed for you?

@hupengtao fixed in 2.5.7.
composer update


Add staticcheck static analyzer

What is the purpose of the change
Add staticcheck static analyzer to the project. It caught some minor stuff that our linter did not, minor stuff, fixed in this PR.
Install locally with go install<EMAIL_ADDRESS>I couldn't figure out how to make staticcheck run on the whole project, so I added a short bash script to run staticcheck in each relevant directory.
How to run it
make staticcheck

This looks like the right approach, but the action is failing for some reason  https://github.com/Stride-Labs/stride/runs/7941585193?check_suite_focus=true
It might be a path issue?
staticcheck /home/runner/work/stride/stride/scripts-local/../x
./scripts-local/staticcheck.sh: line 13: staticcheck: command not found

Updated, GH CI staticcheck is working now! The check fails, but that's OK, I made it non-required since it is a very strict linter and we cannot and should not make all the suggested changes today, rather strive to make them over time.


Zuul routes not working with serviceId but working with URL Part 2

Hi,
I'm developing a Micro services application with Zuul , Config Server and Eurika, consuming Rest services from another server.
When I use Zuul with  url: the services are route correctly, but when I use Eurika and serviceID, zuul raise exceptions.
The services Aviones is listed on Eureka and Zuul is also listed in Eurika, for that reason I consider that Zuul has connection with Eurika.
Using Postman application, I send the request hit and correctly the Rest service Aviones, the problem is in the way back inside of Zuul.
With this configuration Zuul works
---
ribbon:
  ConnectTimeout: 30000
  ReadTimeout: 990000
  maxAutoRetries: 1
  MaxAutoRetriesNextServer: 2
  eureka:
    enabled: false
server:
  port: 8080
zuul:
  ignoredServices: '*'
  routes:
    aviones:
      path: /aviones/**
      url: "http://localhost:8686/"
      stripPrefix: false
    autos:
      path: /autos/**
      url: "http://localhost:8777/"`

With this configuration Zuul doesn´t work
---
ribbon:
  ConnectTimeout: 30000
  ReadTimeout: 990000
  maxAutoRetries: 1
  MaxAutoRetriesNextServer: 2
  eureka:
    enabled: true
server:
  port: 8080
zuul:
  ignoredServices: '*'
  routes:
    aviones:
      path: /aviones/**
      serviceId: aviones
      stripPrefix: false
    autos:
      path: /autos/**
      serviceId: autos
      stripPrefix: false
hystrix:
  command:
    default:
      execution:
        isolation:
          strategy: THREAD
          thread:
            timeoutInMilliseconds: 20000

Like I said prior, please provide a project that recreates the problem.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.

Hello,
I have the same problem. I may provide you the projects.
Best regards.


Could not enable GCServer for F# Interactive

Changing fsi.exe.config and fsiAnyCPU.exe.config to enable GCServer doesn't work for F# Interactive in VS2017 with Visual F# Tools night build.
To reproduce:

Open fsi.exe.config and fsiAnyCPU.exe.config (with admin) and add the following

    <gcConcurrent enabled="true" />
    <gcServer enabled="true" />

Open VS2017 and open F# Interactive, and verify:

System.Runtime.GCSettings.IsServerGC;;

The result is false no matter how fsi.exe.config and fsiAnyCPU.exe.config is changed.
However open fsi.exe in command line, it shows true for GCServer.

Expected behavior
GCServer should be enabled.
Actual behavior
GCServer is not enabled.
Known workarounds
No workaround found.
Related information

Windows 10 with Creators Update
.NET Framework 4.6 and F# 4.1
Visual Studio 2017 Profession with Visual F# Tools nightly build

Changing fsi.exe.config and fsiAnyCPU.exe.config to enable GCServer doesn't work for F# Interactive in VS2017 with Visual F# Tools night build.

Which fsi.exe.config are you changing?  If you are running the nightly build, then AFAIK Visual F# tools run the fsi.exe from under a path something like
C:\Users\dsyme\AppData\Local\Microsoft\VisualStudio\15.0_088a6328\Extensions\faqeurj5.za1

I didn't know that's the one. Thanks a lot I confirm it works.


:robot: Add sharphound.vm

Automated PR from https://github.com/mandiant/VM-Packages/issues/407 :rocket:

Category for this should be Information Gathering

Not sure what the hell I was thinking with that one lol


Enhance MiKo_3107: NUnit 'TestCaseSource' values should not use Moq condition matchers 'It.Is...'

Moq's condition matchers It.Is... are valid for verification or setup on Moq mocks but they should not be used for normal NUnit TestCaseSource data as they simply return null.
We should report a warning in case we detect one of them in such test case source data.
This should be done by enhancing MiKo_3107

Inspect NUnit's TestCaseData class usage for constructor parameters and Returns method arguments.


Make device selector on support UI a combobox

Background
We have enough devices that finding one with the selector tool is tricky. Changing to a combobox (like the organization search) would be better.
Action requested
Change the device dropdown in the "edit/add device" internal superuser admin UI to a combobox. (Not the facility form, though we should probably also reevaluate that one)
Acceptance Criteria
Internal device edit page uses a combobox

Update: the ask is to change the device selector to a combobox application-wide (i.e. also in the facility settings page.)

@emmastephenson Just want to confirm, the places that should now be a combo box are in 2 places, the facilities management page for admins and the edit device page for superadmins:

Apologies for the delayed reply; can confirm that those are the two components that need to be updated!

After discussing with @kenieh, we are going to hold off on refactoring the Manage Devices section on the Manage Facilities page (for org admins). We need some user validation before changing the design.
I suggest we move away from the initial idea of using combo boxes in the Manage Device section due to the complexity of implementing local state to properly handle multiple devices, addition, and deletion. Instead, we can use the MultiSelect component that already exists in SimpleReport. This component was built out based on combobox, and is used on the "Edit existing testing device" page (in the super admin view) for selecting SNOMED Code and Supported Diseases. It would look like this:

See a video of the application here:
https://user-images.githubusercontent.com/89797785/189739508-66419858-a3a3-435c-8080-9463ecd688cb.mov
Code changes for this implementation are on branch george/4124-device-selection.
We'll proceed with refactoring to use a combobox on the "Edit existing testing device" page (in the super admin view), and will spin out a new ticket for this suggested change
cc: @emmastephenson

Thank you for the detailed update George! I'll save questions on the Manage Facilities page for the new ticket :)

New ticket for org admin page


paper-dialog-scrollable is broken: sizingTarget is not set correctly

Here is an example in Plunker: https://plnkr.co/edit/9nzSNs7Kd04IfStwnHuh?p=preview
Summary
Create a popup paper-dialog with a scrollable content as in this example from the Polymer docs. See that when the browser window is not big enough to fit the entire dialog contents, the scrollable behaviour is broken.
Expected behaviour
The opened paper-dialog fully fits into the browser window even when the size of the window is not enough to display all of the 'Lorem ipsum...' text. The 'Lorem ipsum...' text is fully contained within a scrollable div.
Actual behaviour
The opened paper-dialog sets its height based on the 'Lorem ipsum...' text height regardless of the browser window size. If the window size is not big enough to fit all the text, the bottom of the dialog continues below the screen border and becomes invisible. Scrolling does not work (even though there is content below, you could not scroll down.
Investigation
The correct behaviour of the paper-dialog-scrollable relies on the value of the sizingTarget property of the paper-dialog element. It needs to be set to the #scrollable <div> inside the paper-dialog-scrollable component.
The paper-dialog-scrollable's ready() method is the place where this would normally happen when angular2-polymer is not involved (see the _ensureTarget() method here)
However, when the angular2-polymer is used, that update to the the paper-dialog's sizingTarget property is detected and reversed. This happens inside the ngDoCheck() hook of the PolymerElement object corresponding to the paper-dialog component (see the line 260).

Thanks for the detailed issue description!
Looks like sizingTarget doesn't have notify: true which in this case results in a situation where the angular2 component doesn't get notified that the value was changed inside _ensureTarget().
It's a tricky thing, since technically an element should not notify about changes to it's property coming from the outside – but in this case the new value isn't coming from the app but a parent element.


Updating docs for getNumberType

Fixes https://github.com/googlei18n/libphonenumber/issues/1512
CL?

Ah, seen it. All good :)
No merging until after release freeze is lifted.


firestore, bigquery, Others? ('_RSAPrivateKey' object has no attribute 'sign')

It looks like the new version of google-auth released 2 days ago is causing an issue with at least firestore and bigquery which is the ones I've tested.
Here's the stack trace for firestore:

File "/home/fgervais/tensorflow_21_nov_2017/lib/python3.5/site-packages/google/cloud/firestore_v1beta1/query.py", line 588, in get
for index, response_pb in enumerate(response_iterator):
File "/home/fgervais/tensorflow_21_nov_2017/lib/python3.5/site-packages/grpc/_channel.py", line 347, in next
return self._next()
File "/home/fgervais/tensorflow_21_nov_2017/lib/python3.5/site-packages/grpc/_channel.py", line 341, in _next
raise self
grpc._channel._Rendezvous: <_Rendezvous of RPC that terminated with (StatusCode.UNAVAILABLE, Getting metadata from plugin failed with error: '_RSAPrivateKey' object has no attribute 'sign')>

pip3 install google-auth==1.3.0 solves the problem.
It might be specific to the way I instantiate the client I'm not sure.
I'm using:
db = firestore.Client.from_service_account_json(
    "firebase-adminsdk.json")

It's because the new release of google-auth tries to use the cryptography
library if it's available. I'll investigate this soon. Can you tell me
which version of cryptography you have?
On Sat, Feb 10, 2018, 7:19 AM Francois Gervais<EMAIL_ADDRESS>wrote:

It looks like the new version of google-auth released 2 days ago is
causing an issue with at least firestore and bigquery which is the ones
I've tested.
Here's the stack trace for firestore:
File
"/home/fgervais/tensorflow_21_nov_2017/lib/python3.5/site-packages/google/cloud/firestore_v1beta1/query.py",
line 588, in get
for index, response_pb in enumerate(response_iterator):
File
"/home/fgervais/tensorflow_21_nov_2017/lib/python3.5/site-packages/grpc/_channel.py",
line 347, in next
return self._next()
File
"/home/fgervais/tensorflow_21_nov_2017/lib/python3.5/site-packages/grpc/_channel.py",
line 341, in _next
raise self
grpc._channel._Rendezvous: <_Rendezvous of RPC that terminated with
(StatusCode.UNAVAILABLE, Getting metadata from plugin failed with error:
'_RSAPrivateKey' object has no attribute 'sign')>
pip3 install google-auth==1.3.0 solves the problem.
It might be specific to the way I instantiate the client I'm not sure.
I'm using:
db = firestore.Client.from_service_account_json(
"firebase-adminsdk.json")
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/google-cloud-python/issues/4867,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPUc_yG7FNMnTXSxjCdBTLF98l9wiCsks5tTbOOgaJpZM4SA9jc
.

cryptography==1.2.3

That's pretty old. Can you try a version > 2.0? It seems we need to add an
additional check and not use old versions of cryptography.
On Sat, Feb 10, 2018, 8:45 AM Francois Gervais<EMAIL_ADDRESS>wrote:

cryptography==1.2.3
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/google-cloud-python/issues/4867#issuecomment-364670364,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPUc_rHbUvSQMaLkjnYF3HURykhKQ6cks5tTcfBgaJpZM4SA9jc
.

Good call. I did a pip upgrade which installed cryptography version 2.1.4.
With that version google-auth 1.4.0 works fine.

Closed by https://github.com/GoogleCloudPlatform/google-auth-library-python/pull/243


How do push from serverside when i have developed my app to galaxy.meteor.com

Its said that you can use the meteor shell to do notifications from the server side. But as far as I know this is not possible on a deployed instance.  I dont have accounts on my app, so how should I send notifications without allowing anyone to  send notifications to anyone from the browser?

use the allow / deny rules - more details in the /docs folder


fix(labware-library): fix CSS in link button

Overview
When we migrated from webpack to vite we had to copy a bunch of old preprocessed css from libraries that weren't actual css and it looks like we (meaning I) copied one incorrectly. Good catch @alexjoel42
closes RQA-3170
Changelog

Fix CSS in link button

Review requests
See bug in ticket, but the "Read the custom labware guide" button should be back now in labware creator
Risk assessment
Low

@shlokamin LGTM! Confirmed this branch the issue is fixed


jobliststubs command

I need to read job summaries even after the nomad GC deleted them, current implementation stores the full job json, but it lacking job summary.
This PR adds new command jobliststubs to read https://www.nomadproject.io/api/jobs.html#list-jobs only

fixed the PR, replaced the channel between base and jobs interfaces with function call

ping

think it looks fine, merging :)

thank you

thanks


preventOutline throws exception if map is wrapped in div with tabindex=-1

I ran into this because we display maps in Bootstrap Modals which have tabindex=-1
See: http://jsfiddle.net/skalb/rgfdk25j/3/
As a workaround, adding tabindex="0" to the div#map element fixes it.

Thanks! Should be fixed in theory, can you confirm?

Looks good, thanks!


Some events don't show up on the correct day

Using Calendar Flyout v 2.0.3 on Windows 11
I'm in (UTC-07:00) Mountain Time zone. When a day is selected, the calendar displays some events from the previous day. Clicking on the events correctly shows the event details, including the correct date/time, but they appear on the wrong day. I think it's a timezone issue with Calendar Flyout because it's only the meetings at the end of the day that show up on the next day.
I did a test where I created events the prior day starting at 1p UTC-07:00 on Feb 9, and those events at 5p and later appeared on Feb 10:

Hello, thanks for reporting the issue. Yeah, I'm testing version 2.0.4 with a fix for that. Sorry for the problem.


Failure to git the submission history of pcl.rb

I want to install  the old version of pcl (pcl 1.8.1) by homebrew. The latest version is pc l 1.9.1. So I went to check the commit history of the pcl.rb. Hope to find the commit version of pcl1.8.1. So I clicked the “history” button for pcl.rb。
in this new page(https://github.com/Homebrew/homebrew-core/commits/master/Formula/pcl.rb) ,Shown a hint “Sorry, this commit history is taking too long to generate. Refresh the page to try again, or view this history locally using the following command:”
git log master -- Formula/pcl.rb
But I can't successfully execute this command.A fatal appears:
git log master -- Formula/pcl.rb
fatal: bad revision 'master'
Can someone help me find the old version(pcl 1.8.1) of the pcl.rb please?
I will be very grateful.

Hi.
I would recommend to clone the repo somewhere on you hard disk:
git clone https://github.com/Homebrew/homebrew-core.git
Then you can run git log on the pcl file, or use gitk.
Use git checkout to checkout the older version.
For these kind of support questions it is better to ask help on https://discourse.brew.sh.
Please always fill out the issue template when opening an issue here!


docs: add Zhengcai Cloud on-premise best practise of sealer

docs: add Zhengcai Cloud on-premise best practise of sealer
@lllwan
Signed-off-by: Allen Sun<EMAIL_ADDRESS>

lgtm


Fail to add external packages

For reasons I dont know, govendor got stuck at the error:
$ govendor add +external
Error: Package "github.com/pressly/omnibed/vendor/github.com/golang/protobuf/proto" already in vendor.

See https://gist.github.com/pkieltyka/59b31d93f42a0d96fade for some console output. The only way I could move past this is to fork and patch by skipping the error and allowing the program to continue  https://github.com/pkieltyka/govendor/commit/37312afdb04c5fe3d33979d70fb37deae87c2b0e

I agree this is an issue. I know roughly what is causing it and will have a resolution soon.

@kardianos unfortunately I'm still getting this error. .. see console output:
[peter@pak ~/Dev/go/src/github.com/kardianos]$ cd govendor
[peter@pak ~/Dev/go/src/github.com/kardianos/govendor]$ git pull
remote: Counting objects: 19, done.
remote: Compressing objects: 100% (19/19), done.
remote: Total 19 (delta 9), reused 0 (delta 0), pack-reused 0
Unpacking objects: 100% (19/19), done.
From github.com:kardianos/govendor
   77090b8..2ac4e85  master     -> origin/master
 * [new branch]      direct     -> origin/direct
Updating 77090b8..2ac4e85
Fast-forward
 README.md | 11 ++++++++++-
 run.go    | 11 +++++++----
 2 files changed, 17 insertions(+), 5 deletions(-)
[peter@pak ~/Dev/go/src/github.com/kardianos/govendor]$ go install .
[peter@pak ~/Dev/go/src/github.com/kardianos/govendor]$ z omnibed
[peter@pak ~/Dev/go/src/github.com/pressly/omnibed]$ rm -rf vendor
[peter@pak ~/Dev/go/src/github.com/pressly/omnibed]$ govendor init
[peter@pak ~/Dev/go/src/github.com/pressly/omnibed]$ govendor add +external
Error: Failed to copy package "/Users/peter/Dev/go/src/github.com/stretchr/testify/vendor/github.com/davecgh/go-spew/spew/" -> "/Users/peter/Dev/go/src/github.com/pressly/omnibed/vendor/github.com/davecgh/go-spew/spew": open /Users/peter/Dev/go/src/github.com/pressly/omnibed/vendor/github.com/stretchr/testify/vendor/github.com/davecgh/go-spew/LICENSE: no such file or directory
[peter@pak ~/Dev/go/src/github.com/pressly/omnibed]$ govendor add +external
Error: Package "github.com/pressly/omnibed/vendor/github.com/golang/protobuf/proto" already in vendor.

you'll notice there are 2 errors there though, the first for some reason fails to copy a package, but a second attempt of running add +external gets past that error, and runs up against another bug.

ah, different error. I'll look into the license copy error.
On Mon, Feb 22, 2016 at 6:42 AM Peter Kieltyka<EMAIL_ADDRESS>wrote:

you'll notice there are 2 errors there though, the first for some reason
fails to copy a package, but a second attempt of running add +external gets
past that error, and runs up against another bug.
—
Reply to this email directly or view it on GitHub
https://github.com/kardianos/govendor/issues/86#issuecomment-187210810.

This should be fixed (someone filed issue #88, which is the issue).
I'm not confident it fixed the second error, but I'd like to do one at a time. Would you mind re-testing?

Bingo :)


mssql::protocol::pre_login::Encrypt is private

I know you literally implemented this 4 days ago, but I'm trying to connect to an Azure SQL Database with MssqlConnectOptions and the encrypt method takes an instance of mssql::protocol::pre_login::Encrypt which is private. I think this has to be a bug, right?

Thanks for letting me know, and sorry for the delay !

Thanks for letting me know, and sorry for the delay !

No problem. I just used a connection string with the encrypt options as a workaround.


WebP encoded image filesize isn't reduced as expected.

Using the glide library with Statamic, when I select convert images to webP using glide, the file size ends up being the same as converting to png.
If I convert the same image to the same dimensions with ImageMagick using the command line, the same outputted webP image is roughly half the size of the image from glide.
**I'm pretty sure Statamic is using v 1.1 of glide. The docs seem to indicate webP encoding should work in this version. Am I mistaken? Or is this a known issue?

Nevermind — just saw in the releases on git that Webp encoding wasn't added until v1.4. Would be nice if this was clearer in the glide documentation!


Play audio only

I'm looking for a way to cast videos (like youtube videos) to my receiver without it turning on my TV through CEC. This would allow me to play videos as if they were playing to a chromecast audio, it would urn on my receiver when I cast through CEC, but not turn the TV on (which is what a regular chromecast does).

Hi @retorquere , I was looking for the same kind of feature. I gave it a try by redirecting the audio flow to the headphone jack output. This is far from being elegant in term of resources' usage but give a good result.
See https://www.raspberrypi.org/documentation/configuration/audio-config.md

Thanks. I'm not sure what I want to do is possible at all -- it looks like HDMI inherently sends audio/video at the same time (in the same packets); if that's so "audio-only HDMI" does not exist.
The reason why I wanted to do this via HDMI is that I want the cast device to turn on my AV receiver (which requires CEC) but then not have the TV that's also connected to the receiver turn on. From the looks of it, this will require getting an AV receiver where I can selectively disable CEC passthrough. Not even sure these exist. That, or an AV receiver that can detect activity on the optical or analog audio-in (also not sure whether these exist).

Hey guys,
the omx player is automatically called with the parameter '-o both', which (at least for me) results into the effect that the video and sound are played via the TV if it is switched on and also via the headphone jack.
If both work in parallel I didn't test because this is not a use case for me.

Hey guys,
the omx player is automatically called with the parameter '-o both', which (at least for me) results into the effect that the video and sound are played via the TV if it is switched on and also via the headphone jack.
If both work in parallel I didn't test because this is not a use case for me.

Hey guys,
the omx player is automatically called with the parameter '-o both', which (at least for me) results into the effect that the video and sound are played via the TV if it is switched on and also via the headphone jack.
If both work in parallel I didn't test because this is not a use case for me.

Ok, I checked it.
Output on the TV via HDMI and parallel output on the headphone jack works"

Hey guys,
the omx player is automatically called with the parameter '-o both', which (at least for me) results into the effect that the video and sound are played via the TV if it is switched on and also via the headphone jack.
If both work in parallel I didn't test because this is not a use case for me.

Ok, I checked it.
Output on the TV via HDMI and parallel output on the headphone jack works"


All Comments Don't Load

Attempting to load comments in this issue only loads up to the following comment.
The last two comments aren't loaded. Not sure if it's due to the newness of those comments, or something else, like number of comments.

Think it's because of paging (#29), and should be fixed in the next beta. Right @rnystrom?

Yup! Submitted a build w/ this fix to the App Store as well as Testflight. Fixed soon 😄


Register with Julia

@JuliaRegistrator register

Error while trying to register: Register Failed
@azraq27, it looks like you are not a publicly listed member/owner in the parent organization (WiredBrains-Lab).
If you are a member/owner, you will need to change your membership to public. See GitHub Help

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/91438
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v1.0.0 -m "<description of version>" 65dc5801634f45e1ffe257afbdf6c76e26d63afe
git push origin v1.0.0

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/92792
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v1.0.1 -m "<description of version>" 14cb8f11644e9e8a4a01937ead7181edee355005
git push origin v1.0.1

Also, note the warning: This looks like a new registration that registers version 1.0.1.
Ideally, you should register an initial release with 0.0.1, 0.1.0 or 1.0.0 version numbers
This can be safely ignored. However, if you want to fix this you can do so. Call register() again after making the fix. This will update the Pull request.

@JuliaRegistrator register

Registration pull request updated: JuliaRegistries/General/92792
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v1.0.1 -m "<description of version>" 3d663b808d9a3d053f2c0e50385a400c5ca38da8
git push origin v1.0.1

Also, note the warning: This looks like a new registration that registers version 1.0.1.
Ideally, you should register an initial release with 0.0.1, 0.1.0 or 1.0.0 version numbers
This can be safely ignored. However, if you want to fix this you can do so. Call register() again after making the fix. This will update the Pull request.

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/93103
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v1.0.2 -m "<description of version>" 1d3743728abcf4aab1fea3d3251c4948fae5cb33
git push origin v1.0.2

Also, note the warning: This looks like a new registration that registers version 1.0.2.
Ideally, you should register an initial release with 0.0.1, 0.1.0 or 1.0.0 version numbers
This can be safely ignored. However, if you want to fix this you can do so. Call register() again after making the fix. This will update the Pull request.


JEI causes crash when trying to view recipes

When I was looking up the recipe for the reactor casing and uses for the tough alloy it causes the client to crash.
Here is the crashlog.
The game crashed whilst rendering item
The game crashed whilst rendering item
Error: java.lang.ClassCastException: it.unimi.dsi.fastutil.ints.Int2ObjectOpenHashMap cannot be cast to gnu.trove.map.hash.TIntObjectHashMap

Which version of Forge are you using? The connected textures mod has an issue with later versions of Forge, and what I imagine is happening is that the game is crashing when showing the recipe from the transparent casing (which uses CTM).
I let them know about this a few days ago, so the devs are aware :)


[BUG]: AzurePowershellV5 initialization variables leak to the script

Task name
AzurePowershellV5
Task version
5.288.0
Environment type (Please select at least one enviroment where you face this issue)

[X] Self-Hosted
[X] Microsoft Hosted
[ ] VMSS Pool
[X] Container

Azure DevOps Server type
dev.azure.com (formerly visualstudio.com)
Azure DevOps Server Version (if applicable)
No response
Operation system
Windows
Task log
Write-Host "endpoint: "
$endpoint
Write-Host "vstsAccessToken: "
$vstsAccessToken

Relevant log output
2023-10-12T12:55:19.4773816Z endpoint:
2023-10-12T12:55:19.4775876Z {
2023-10-12T12:55:19.4776151Z     "Url":  "https://management.azure.com/",
2023-10-12T12:55:19.4776509Z     "Data":  {
2023-10-12T12:55:19.4776883Z                  "subscriptionId":  "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx",
2023-10-12T12:55:19.4777226Z                  "environment":  "AzureCloud",
2023-10-12T12:55:19.4777701Z                  "creationMode":  "Manual",
2023-10-12T12:55:19.4778206Z                  "scopeLevel":  "Subscription",
2023-10-12T12:55:19.4778518Z                  "subscriptionName":  "XXXXX-XX-XXX",
2023-10-12T12:55:19.4778842Z                  "environmentUrl":  "https://management.azure.com/",
2023-10-12T12:55:19.4779173Z                  "galleryUrl":  "https://gallery.azure.com/",
2023-10-12T12:55:19.4779550Z                  "serviceManagementUrl":  "https://management.core.windows.net/",
2023-10-12T12:55:19.4779902Z                  "resourceManagerUrl":  "https://management.azure.com/",
2023-10-12T12:55:19.4780649Z                  "activeDirectoryAuthority":  "https://login.microsoftonline.com/",
2023-10-12T12:55:19.4781006Z                  "environmentAuthorityUrl":  "https://login.windows.net/",
2023-10-12T12:55:19.4782945Z                  "graphUrl":  "https://graph.windows.net/",
2023-10-12T12:55:19.4783146Z                  "microsoftGraphUrl":  "https://graph.microsoft.com/",
2023-10-12T12:55:19.4783386Z                  "managementPortalUrl":  "https://manage.windowsazure.com/",
2023-10-12T12:55:19.4783622Z                  "armManagementPortalUrl":  "https://portal.azure.com/",
2023-10-12T12:55:19.4783881Z                  "activeDirectoryServiceEndpointResourceId":  "https://management.core.windows.net/",
2023-10-12T12:55:19.4784134Z                  "sqlDatabaseDnsSuffix":  ".database.windows.net",
2023-10-12T12:55:19.4784355Z                  "AzureKeyVaultDnsSuffix":  "vault.azure.net",
2023-10-12T12:55:19.4784601Z                  "AzureKeyVaultServiceEndpointResourceId":  "https://vault.azure.net",
2023-10-12T12:55:19.4784836Z                  "StorageEndpointSuffix":  "core.windows.net",
2023-10-12T12:55:19.4785022Z                  "EnableAdfsAuthentication":  "false"
2023-10-12T12:55:19.4785194Z              },
2023-10-12T12:55:19.4785336Z     "Auth":  {
2023-10-12T12:55:19.4785488Z                  "parameters":  {
2023-10-12T12:55:19.4785690Z                                     "tenantid":  "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx",
2023-10-12T12:55:19.4785906Z                                     "authenticationType":  "spnKey",
2023-10-12T12:55:19.4786218Z                                     "serviceprincipalid":  "***",
2023-10-12T12:55:19.4786529Z                                     "serviceprincipalkey":  ***
2023-10-12T12:55:19.4786695Z                                 },
2023-10-12T12:55:19.4786866Z                  "scheme":  "ServicePrincipal"
2023-10-12T12:55:19.4787002Z              }
2023-10-12T12:55:19.4787141Z }
2023-10-12T12:55:19.4805269Z vstsAccessToken:
2023-10-12T12:55:19.4809057Z ***

Aditional info
Invocation CoreAz.ps1 inject that script to the current execution context, which cause that their parameters leaked to final script (endpoint, connectedServiceNameARM, vstsAccessToken and isPSCore).

Because parameters are strong typed they forcing to use this type, so if in final script we wanted assign object to the same named $endpoint variable (which name is so general that could be often), it will be converted to string automatically - see bug https://github.com/microsoft/azure-pipelines-tasks/issues/18917 - and cause breaking change if we expect behind variable object.

This came in 5 version of task and applied only for Windows, linux use Node to initialize modules so AzurePowerShell.ps1 is not called there.

Invocation CoreAz.ps1 via '&' not '.' could solve problem in https://github.com/microsoft/azure-pipelines-tasks/blob/620be0da9e15ac3b8efc532253d003c371c1c320/Tasks/AzurePowerShellV5/AzurePowerShell.ps1#L98C32-L98C32

Related to #18917


Error when config "armeabi-v7a-hard-softfp with NEON"

Hi sh1r0, sorry to bother you, Error occurred when compile "armeabi-v7a-hard-softfp with NEON"
here is the log
Reversed (or previously applied) patch detected!  Skipping patch.
1 out of 1 hunk ignored
ERRORCould not find libsupc++.a for a chosen platform.
-- Configuring done
-- Generating done
-- Build files have been written to: /home/caffe/caffe-android-lib/boost/build
Scanning dependencies of target boost_atomic
[  0%] Building CXX object CMakeFiles/boost_atomic.dir/boost_1_56_0/libs/atomic/src/lockpool.cpp.o
In file included from /home/caffe/caffe-android-lib/boost/boost_1_56_0/libs/atomic/src/lockpool.cpp:15:0:
/root/android-ndk-r12b/sources/cxx-stl/gnu-libstdc++/4.9/include/cstddef:44:28: fatal error: bits/c++config.h: No such file or directory
#include <bits/c++config.h>

Please refer to  https://github.com/sh1r0/caffe-android-lib/issues/57#issuecomment-255511524 and #68, thanks.


[ Star Tree Indexes ]: Pinot StarTree On-Heap Off-Heap

Added on-heap & off-heap implementation of star tree.

Codecov Report

Merging #2987 into master will increase coverage by 0.27%.
The diff coverage is 80.79%.

@@            Coverage Diff            @@
##           master   #2987      +/-   ##
=========================================
+ Coverage   69.93%   70.2%   +0.27%
=========================================
  Files         913     937      +24
  Lines       43288   44271     +983
  Branches     5917    6033     +116
=========================================
+ Hits        30274   31082     +808
- Misses      10984   11133     +149
- Partials     2030    2056      +26

Impacted Files
Coverage Δ

...ore/startree/v2/AggregationFunctionColumnPair.java
53.84% <ø> (+53.84%)
:arrow_up:

...ot/core/data/readers/PinotSegmentColumnReader.java
66.03% <ø> (ø)
:arrow_up:

...kedin/pinot/common/segment/StarTreeV2Metadata.java
0% <0%> (ø)

...rator/filter/StarTreeIndexBasedFilterOperator.java
82.65% <0%> (-14.36%)
:arrow_down:

.../pinot/core/segment/index/SegmentMetadataImpl.java
83.8% <100%> (+2.24%)
:arrow_up:

.../com/linkedin/pinot/core/startree/v2/TreeNode.java
100% <100%> (ø)

...va/com/linkedin/pinot/core/startree/v2/Record.java
100% <100%> (ø)

...or/impl/fwd/SingleValueVarByteRawIndexCreator.java
70.58% <100%> (+3.92%)
:arrow_up:

.../core/indexsegment/mutable/MutableSegmentImpl.java
66.95% <100%> (+0.09%)
:arrow_up:

...n/pinot/core/startree/v2/StarTreeV2DataSource.java
100% <100%> (ø)

... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 688ba11...3437f39. Read the comment docs.

closed, check https://github.com/linkedin/pinot/pull/3077


Change super admin scope

Allow Super admins to view forms accross organisations
Trello card https://trello.com/c/iZ4Itleq/1226-without-autocomplete-update-forms-list-page-so-that-super-admins-can-see-edit-all-forms-across-all-departments

This PR gives super admins the permissions to list, view and modify all forms.
It also changes the super admins home page to let them easily list forms from other organisations. There currently isn't a way for them to list forms owned by trial users which are not owned by an organisation.
A few points to note:

Super admins see an extra column, Created by, which shows which user first created the form. If that isn't available, "Unknown" is shown. Editors and trial users don't see the column.
The list of organisations only shows organisations with a least one user to cut down on the size of the list.

Things to consider when reviewing

Ensure that you consider the wider context.
Does it work when run on your machine?
Is it clear what the code is doing?
Do the commit messages explain why the changes were made?
Are there all the unit tests needed?
Has all relevant documentation been updated?

Hi hi! The line above the organisation selection field should read:
Change which organisation’s forms you’re viewing
Also I note that there's an additional heading for the table ( forms) so we have the same heading twice. Presumably this is for accessibility reasons? I think we probably want to keep these two titles unique from each other though - also for accessibility?
Just thinking we could change the first one to: You’re viewing  forms
That would tie in nicer with the line of text beneath it as well as making it unique from the table heading.
What you think? cc. @hazalarpalikli

thanks - I'll update the hint text.
You are right, I kept the table caption (the second heading) as it describes the table. The first one is the really the label for the select list so can't be used for the overall list of forms. Is something more question texty better?

Yes good shout @hannahkc , it would make more sense to change the first title 'you are reviewing' especially for the screen readers. i'll make sure to update the designs as well with this

Just did a quick mock up. I second what Tom says maybe the first title needs to be a question?

Oh sorry - I put some angle brackets in my previous message that made the text disappear. Sorry!
To clarify, I think the content should be (using GDS as the org example):
You're viewing Government Digital Service forms
Change which organisation’s forms you’re viewing
Government Digital Service forms

Yes it makes sense to me now :) So it needs to look like this

You're NOT you are please.

Opps thank you! @hannahkc  Deleted the previous comment to avoid confusion :) this is how it needs to look @thomasiles


samples/tfm_integration: Compilation fails ("unexpected keyword argument 'rom_fixed'")

Describe the bug
Compilation fails for all TFM samples on various targets:
Samples:

samples/tfm_integration/psa_crypto
samples/tfm_integration/tfm_ipc
samples/tfm_integration/psa_protected_storage
samples/tfm_integration/tfm_regression_test
samples/tfm_integration/tfm_psa_test

Targets:

mps2_an521_ns
lpcxpresso55s69_ns
stm32l562e_dk_ns
nucleo_l552ze_q_ns

To Reproduce
Steps to reproduce the behavior:

mkdir build; cd build
cmake -DBOARD=board_xyz
make
See error

Expected behavior
Compilation should succeed
Impact
Blocking
Logs and console output
Traceback (most recent call last):
  File "/local/mcu/zephyrproject/modules/tee/tfm/trusted-firmware-m/bl2/ext/mcuboot/scripts/wrapper/wrapper.py", line 128, in <module>
    wrap()
  File "/local/home/frq07517/.local/lib/python3.6/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/local/home/frq07517/.local/lib/python3.6/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/local/home/frq07517/.local/lib/python3.6/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/local/home/frq07517/.local/lib/python3.6/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/local/mcu/zephyrproject/modules/tee/tfm/trusted-firmware-m/bl2/ext/mcuboot/scripts/wrapper/wrapper.py", line 111, in wrap
    security_counter=security_counter)
TypeError: __init__() got an unexpected keyword argument 'rom_fixed'
ninja: build stopped: subcommand failed.

Environment (please complete the following information):

OS: (e.g. Linux, MacOS, Windows): Linux
Toolchain (e.g Zephyr SDK, ...): zephyr-sdk-0.13.0
Commit SHA or Version used: v2.7.0-rc2-12-g9fa1f6edca

Additional context
Add any other context about the problem here.

I've just tested this with 0.13.0 (though the OS X builds as a quick test since I have that setup), and with west it seems ro work fine:
$ west build -p auto -b mps2_an521_ns zephyr/samples/tfm_integration/psa_crypto/ -t run
...
*** Booting Zephyr OS build v2.7.0-rc2-41-g357ec64b36cd  ***
[00:00:00.001,000] <inf> app: app_cfg: Creating new config file with UID 0x1055CFDA7A
[00:00:03.779,000] <inf> app: att: System IAT size is: 545 bytes.
[00:00:03.779,000] <inf> app: att: Requesting IAT with 64 byte challenge.
[00:00:05.693,000] <inf> app: att: IAT data received: 545 bytes.

Switching to manually calling cmake with ninja I get:
$ cd samples/tfm_integration/psa_crypto
$ mkdir build && cd build
$ cmake -GNinja -DBOARD=mps2_an521_ns ..
$ ninja
$ ninja run
...
*** Booting Zephyr OS build v2.7.0-rc2-41-g357ec64b36cd  ***
[00:00:00.001,000] <inf> app: app_cfg: Creating new config file with UID 0x1055CFDA7A
[00:00:03.779,000] <inf> app: att: System IAT size is: 545 bytes.
[00:00:03.779,000] <inf> app: att: Requesting IAT with 64 byte challenge.
[00:00:05.693,000] <inf> app: att: IAT data received: 545 bytes.

With make I get:
$ cmake -DBOARD=mps2_an521_ns ..
$ make -j8
...
[ 18%] Built target linker_zephyr_prebuilt_script_target
make[1]: *** [zephyr/arch/arch/arm/core/aarch32/cortex_m/CMakeFiles/arch__arm__core__aarch32__cortex_m.dir/all] Error 2
[ 18%] Built target isr_tables
[ 18%] Built target arch__arm__core__aarch32__cortex_m__cmse
make[1]: *** [zephyr/arch/arch/arm/core/aarch32/CMakeFiles/arch__arm__core__aarch32.dir/all] Error 2
make: *** [all] Error 2

So this seems to be specific to make ... ninja still works.
Thanks for the heads up, though. I've only been testing with ninja and west.

@erwango I'm not getting the same error with make, though. Your error seems to be related to the signing script, which may need to be updated to take into account recent changes to TF-M? Can you try running the west command and see if that works for you, and also making sure you're using the latest signing script?
It's the imgtool here: https://docs.zephyrproject.org/latest/guides/tfm/requirements.html#software-requirements
Something may have also changed there that isn't being handled properly (in the Zephyr repo or locally).

@microbuilder Thanks for the quick feedback.
I didn't mention, but I was using west build actually.
On your advice, I've updated my pip3 packages (but I forgot to check what was the previous status).
And ... I'm getting the same error.
$ python3 -m pip show imgtool
Name: imgtool
Version: 1.6.0
Summary: MCUboot's image signing and key management
Home-page: http://github.com/JuulLabs-OSS/mcuboot
Author: The MCUboot committers
Author-email<EMAIL_ADDRESS>License: Apache Software License
Location: /local/home/frq07517/.local/lib/python3.6/site-packages
Requires: cbor, click, intelhex, cryptography
Required-by:

Note that I'm getting a strange warning when calling pip3 directly. Not sure if this can have an impact.
$ pip3 show imgtool
WARNING: pip is being invoked by an old script wrapper. This will fail in a future version of pip.
Please see https://github.com/pypa/pip/issues/5599 for advice on fixing the underlying issue.
To avoid this problem you can invoke Python with '-m pip' instead of running pip directly.

u try updating to the most recent version of imgtool? I think we might need to update the documentation as well. I see you're on 1.6.0, but this may be too old for 1.3.0. I'll look at the TF-M docs myself to see what they require.

The TFM doc you pointed actually specifies "imgtool>=1.6.0"; so it might require an update indeed.
Anyway, updated to v1.7.0 now, and the error persists.

Strange that in the issue description "make" is invoked, but this shows up the log output:

ninja: build stopped: subcommand failed.

Could not reproduce ninja vs Make problem.
r```
m -rf build/ && cmake -H. -Bbuild -DBOARD=mps2_an521_ns -G"Unix Makefiles"
Including boilerplate (Zephyr base): /home/sebo/ncs/zephyr/cmake/app/boilerplate.cmake
CMake Deprecation Warning at /home/sebo/ncs/zephyr/cmake/app/boilerplate.cmake:37 (cmake_policy):
The OLD behavior for policy CMP0079 will be removed from a future version
of CMake.
The cmake-policies(7) manual explains that the OLD behaviors of all
policies are deprecated and that a policy should be set to OLD only under
specific short-term circumstances.  Projects should be ported to the NEW
behavior and not rely on setting a policy to OLD.
Call Stack (most recent call first):
/home/sebo/ncs/zephyr/share/zephyr-package/cmake/ZephyrConfig.cmake:24 (include)
/home/sebo/ncs/zephyr/share/zephyr-package/cmake/ZephyrConfig.cmake:35 (include_boilerplate)
CMakeLists.txt:5 (find_package)
-- Application: /home/sebo/ncs/zephyr/samples/tfm_integration/tfm_ipc
-- Zephyr version: 2.7.0-rc2 (/home/sebo/ncs/zephyr), build: v2.7.0-rc2-41-g357ec64b36cd
-- Found Python3: /usr/bin/python3.8 (found suitable exact version "3.8.10") found components: Interpreter
-- Found west (found suitable version "0.11.1", minimum required is "0.7.1")
-- Board: mps2_an521_ns
-- Cache files will be written to: /home/sebo/.cache/zephyr
-- ZEPHYR_TOOLCHAIN_VARIANT not set, trying to locate Zephyr SDK
-- Using toolchain: zephyr 0.13.0 (/home/sebo/zephyr-sdk-0.13.0)
-- Found dtc: /home/sebo/zephyr-sdk-0.13.0/sysroots/x86_64-pokysdk-linux/usr/bin/dtc (found suitable version "1.6.0", minimum required is "1.4.6")
-- Found BOARD.dts: /home/sebo/ncs/zephyr/boards/arm/mps2_an521/mps2_an521_ns.dts
-- Generated zephyr.dts: /home/sebo/ncs/zephyr/samples/tfm_integration/tfm_ipc/build/zephyr/zephyr.dts
-- Generated devicetree_unfixed.h: /home/sebo/ncs/zephyr/samples/tfm_integration/tfm_ipc/build/zephyr/include/generated/devicetree_unfixed.h
-- Generated device_extern.h: /home/sebo/ncs/zephyr/samples/tfm_integration/tfm_ipc/build/zephyr/include/generated/device_extern.h
-- Including generated dts.cmake file: /home/sebo/ncs/zephyr/samples/tfm_integration/tfm_ipc/build/zephyr/dts.cmake
Parsing /home/sebo/ncs/zephyr/Kconfig
Loaded configuration '/home/sebo/ncs/zephyr/boards/arm/mps2_an521/mps2_an521_ns_defconfig'
Merged configuration '/home/sebo/ncs/zephyr/samples/tfm_integration/tfm_ipc/prj.conf'
Configuration saved to '/home/sebo/ncs/zephyr/samples/tfm_integration/tfm_ipc/build/zephyr/.config'
Kconfig header saved to '/home/sebo/ncs/zephyr/samples/tfm_integration/tfm_ipc/build/zephyr/include/generated/autoconf.h'
-- The C compiler identification is GNU 10.3.0
-- The CXX compiler identification is GNU 10.3.0
-- The ASM compiler identification is GNU
-- Found assembler: /home/sebo/zephyr-sdk-0.13.0/arm-zephyr-eabi/bin/arm-zephyr-eabi-gcc
CMake Warning at /home/sebo/ncs/zephyr/CMakeLists.txt:722 (message):
No SOURCES given to Zephyr library: drivers__pinmux
Excluding target from build.
-- Configuring done
-- Generating done
-- Build files have been written to: /home/sebo/ncs/zephyr/samples/tfm_integration/tfm_ipc/build
sebo@sebo:~/ncs/zephyr/samples/tfm_integration/tfm_ipc$ make -C build/
make[2]: Leaving directory '/home/sebo/ncs/zephyr/samples/tfm_integration/tfm_ipc/build'
make[2]: Entering directory '/home/sebo/ncs/zephyr/samples/tfm_integration/tfm_ipc/build'
[ 97%] Building C object zephyr/CMakeFiles/zephyr_final.dir/misc/empty_file.c.obj
[ 98%] Building C object zephyr/CMakeFiles/zephyr_final.dir/isr_tables.c.obj
[100%] Building C object zephyr/CMakeFiles/zephyr_final.dir/dev_handles.c.obj
[100%] Linking C executable zephyr.elf
Memory region         Used Size  Region Size  %age Used
FLASH:       16932 B       512 KB      3.23%
SRAM:        7224 B         1 MB      0.69%
SRAM1:          0 GB         4 MB      0.00%
IDT_LIST:          0 GB         2 KB      0.00%
Generating files from zephyr.elf for board: mps2_an521_ns
make[2]: Leaving directory '/home/sebo/ncs/zephyr/samples/tfm_integration/tfm_ipc/build'
[100%] Built target zephyr_final
make[1]: Leaving directory '/home/sebo/ncs/zephyr/samples/tfm_integration/tfm_ipc/build'
make: Leaving directory '/home/sebo/ncs/zephyr/samples/tfm_integration/tfm_ipc/build'
sebo@sebo:~/ncs/zephyr/samples/tfm_integration/tfm_ipc$ git show HEAD
commit 357ec64b36cd84ca87660407e67eb0cb1cfe932b (HEAD, us/main)

@erwango Just to be sure, have you tried a west update to make sure you're using the right version of the TF-M module, and that bl2/ext/mcuboot/scripts/wrapper/wrapper.py is in sync with the rest of Zephyr?

@erwango Just to be sure, have you tried a west update to make sure you're using the right version of the TF-M module, and that bl2/ext/mcuboot/scripts/wrapper/wrapper.py is in sync with the rest of Zephyr?

I think it's ok from this point of view:
=== updating mcuboot (bootloader/mcuboot):
HEAD is now at 70bfbd21 merge: synchronize up to 85da97f + cherry-pick upstream bugfixes for LTS 2.7.0

Compilation succeeds after imgtool uninstall/reinstall.
Closing the issue. Thanks @microbuilder for the support.


Whatsapp Icon

Icon name
whatsapp
Use cases
i need this icon for links to whatsapp. can't believe it wasn't here in the first place
Design ideas

Checklist

[X] I have searched if someone has submitted a similar issue before and there weren't any. (Please make sure to also search closed issues, as this issue might already have been resolved.)
[X] I have searched existing icons to make sure it does not already exist and I didn't find any.
[X] I am not requesting a brand logo and the art is not protected by copyright.
[X] I am not requesting an icon that includes religious, political imagery or hate symbols.
[X] I have provided appropriate use cases for the icon(s) requested.

WhatsApp is a brand owned by Meta, its brand guidelines explicitly prohibit the alteration of its logo:

You may not modify the WhatsApp Brand Resources in any way, including changing the design or combining the WhatsApp Brand Resources with other words or images. You shouldn't modify any colors in our logos.

That's why we don't carry this logo nor will it be added, please also refer to #1582 #1526 #1527 #94 & #670


Add logging exporter for metrics

I have completed the issue #5678 @ShadowySpirits , now broker and proxy could export metrics in terminal.

Codecov Report

Merging #6234 (f7d0271) into develop (543c118) will increase coverage by 0.00%.
The diff coverage is 12.12%.

:exclamation: Current head f7d0271 differs from pull request most recent head c8f1c9a. Consider uploading reports for the commit c8f1c9a to get more accurate results

@@            Coverage Diff             @@
##             develop    #6234   +/-   ##
==========================================
  Coverage      43.18%   43.19%
- Complexity      8851     8858    +7
==========================================
  Files           1094     1094
  Lines          77184    77216   +32
  Branches       10070    10076    +6
==========================================
+ Hits           33334    33351   +17
- Misses         39684    39694   +10
- Partials        4166     4171    +5

Impacted Files
Coverage Δ

.../rocketmq/broker/metrics/BrokerMetricsManager.java
11.80% <0.00%> (-0.42%)
:arrow_down:

...he/rocketmq/proxy/metrics/ProxyMetricsManager.java
6.45% <0.00%> (-0.63%)
:arrow_down:

.../org/apache/rocketmq/proxy/config/ProxyConfig.java
44.73% <25.00%> (-0.14%)
:arrow_down:

.../java/org/apache/rocketmq/common/BrokerConfig.java
27.97% <42.85%> (+0.05%)
:arrow_up:

...controller/impl/DefaultBrokerHeartbeatManager.java
82.27% <0.00%> (-3.80%)
:arrow_down:

...ketmq/proxy/grpc/v2/channel/GrpcClientChannel.java
49.07% <0.00%> (-2.78%)
:arrow_down:

...ent/impl/consumer/DefaultLitePullConsumerImpl.java
67.53% <0.00%> (-0.62%)
:arrow_down:

.../org/apache/rocketmq/store/ha/DefaultHAClient.java
61.34% <0.00%> (-0.52%)
:arrow_down:

...che/rocketmq/test/lmq/benchmark/BenchLmqStore.java
50.24% <0.00%> (-0.50%)
:arrow_down:

...he/rocketmq/client/trace/AsyncTraceDispatcher.java
83.65% <0.00%> (-0.49%)
:arrow_down:

... and 11 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add the possibility to use the bot in groups

It would be useful to use it in groups. Sometimes the group's members are interested in some topics and have the top weekly topics directly in the group would be very convenient.

Added support in ce79f9bcb346bb118962f878a424ae35e3556d5d


Use window for pointerevents

Description
I have a TresCanvas with a lower z-index that is under the main content on my site. I got around this in native Three by using events based on window pointer events. I don't see a way to do this in Tres.
Suggested solution
Add a prop to TresCanvas like window-size (window-pointer?) to use window pointer events instead of attaching events to the canvas itself
Alternative
No response
Additional context
No response
Validations

[X] I agree to follow this project's Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.

Hey @acvigue . Thanks for the feature request.
Maybe someone else can help in the meantime, but this sounds like it might fit in well with what I've been working on for v4 or after, depending on what the team thinks.
I'll add this to my list, anyway.

Hi! Thanks. Yeah, I'm using nuxt 3 with native threejs and just use window.createeventlistener("pointermove" / "pointerenter" / "pointerleave") instead of tying the events directly to the canvas element.


winwave: deadlock in callback function

Hi !
I found a deadlock in winwave/play.c and winwave/src.c.
Microsoft documentation for waveOutProc function says that:

Applications should not call any system-defined functions from inside a callback function, except for EnterCriticalSection, LeaveCriticalSection, midiOutLongMsg, midiOutShortMsg, OutputDebugString, PostMessage, PostThreadMessage, SetEvent, timeGetSystemTime, timeGetTime, timeKillEvent, and timeSetEvent. Calling other wave functions will cause deadlock.

The problem seems to affect only some audio driver.
ref:
http://lists.creytiv.com/pipermail/re-devel/2015-December/000876.html
https://msdn.microsoft.com/en-us/library/windows/desktop/dd743869(v=vs.85).aspx

are you able to reproduce this deadlock ?
can you please find out exactly which functions we are calling and from where,
(that is illegal) ?
if you are able to reproduce the deadlock bug, let us first find out if the PLAY or SOURCE
if affected. Then if you could add some debug printing inside the relevant callback functions,
and run baresip until it deadlocks.

Both PLAY and SOURCE are affected.
Baresip hangs on wave* functions in the callback, in this case waveOutUnprepareHeader or waveInUnprepareHeader.
Here a patch that works for me:
play.c
--- baresip-old/modules/winwave/play.c	2016-07-30 07:25:56.006530541 -0500
+++ baresip-new/modules/winwave/play.c	2016-07-31 23:44:05.404646959 -0500
@@ -24,6 +24,9 @@
 	size_t inuse;
 	auplay_write_h *wh;
 	void *arg;
+	HANDLE thread;
+	volatile bool run;
+	CRITICAL_SECTION crit;
 };

@@ -32,14 +35,13 @@
 	struct auplay_st *st = arg;
 	int i;

-	st->wh = NULL;
+	if (st->run) {
+		st->run = false;
+		(void)WaitForSingleObject(st->thread, INFINITE);
+	}

-	/* Mark the device for closing, and wait for all the
-	 * buffers to be returned by the driver
-	 */
-	st->rdy = false;
-	while (st->inuse > 0)
-		Sleep(50);
+	st->wh = NULL;
+//	st->rdy = false;

 	waveOutReset(st->waveout);

@@ -50,43 +52,59 @@
 	}

 	waveOutClose(st->waveout);
+	DeleteCriticalSection(&st->crit);
 }

-static int dsp_write(struct auplay_st *st)
+static DWORD WINAPI dsp_write(LPVOID arg)
 {
+	struct auplay_st *st = (struct auplay_st *)arg;
 	MMRESULT res;
 	WAVEHDR *wh;
 	struct mbuf *mb;
+	size_t inuse;

-	if (!st->rdy)
-		return EINVAL;
+	while (st->run) {
+		Sleep(5);

-	wh = &st->bufs[st->pos].wh;
-	if (wh->dwFlags & WHDR_PREPARED) {
-		return EINVAL;
-	}
-	mb = st->bufs[st->pos].mb;
-	wh->lpData = (LPSTR)mb->buf;
+		EnterCriticalSection(&st->crit);
+		inuse = st->inuse;
+		LeaveCriticalSection(&st->crit);

-	if (st->wh) {
-		st->wh((void *)mb->buf, mb->size/2, st->arg);
-	}
+		if (!st->rdy)
+			continue;

-	wh->dwBufferLength = mb->size;
-	wh->dwFlags = 0;
-	wh->dwUser = (DWORD_PTR) mb;
+		if (inuse == WRITE_BUFFERS)
+			continue;

-	waveOutPrepareHeader(st->waveout, wh, sizeof(*wh));
+		wh = &st->bufs[st->pos].wh;
+		if (wh->dwFlags & WHDR_PREPARED)
+			waveOutUnprepareHeader(st->waveout, wh, sizeof(*wh));

-	INC_WPOS(st->pos);
+		mb = st->bufs[st->pos].mb;
+		wh->lpData = (LPSTR)mb->buf;

-	res = waveOutWrite(st->waveout, wh, sizeof(*wh));
-	if (res != MMSYSERR_NOERROR)
-		warning("winwave: dsp_write: waveOutWrite: failed: %08x\n",
-			res);
-	else
-		st->inuse++;
+		if (st->wh)
+			st->wh((void *)mb->buf, mb->size/2, st->arg);
+
+		wh->dwBufferLength = mb->size;
+		wh->dwFlags = 0;
+		wh->dwUser = (DWORD_PTR)mb;
+
+		waveOutPrepareHeader(st->waveout, wh, sizeof(*wh));
+
+		INC_WPOS(st->pos);
+
+		res = waveOutWrite(st->waveout, wh, sizeof(*wh));
+		if (res != MMSYSERR_NOERROR)
+			warning("winwave: dsp_write: waveOutWrite: failed: %d\n", res);
+		else {
+			EnterCriticalSection(&st->crit);
+			st->inuse++;
+			LeaveCriticalSection(&st->crit);
+		}
+
+	}

 	return 0;
 }
@@ -99,7 +117,6 @@
 				     DWORD_PTR dwParam2)
 {
 	struct auplay_st *st = (struct auplay_st *)dwInstance;
-	WAVEHDR *wh = (WAVEHDR *)dwParam1;

 	(void)hwo;
 	(void)dwParam2;
@@ -111,11 +128,9 @@
 		break;

 	case WOM_DONE:
-		/*LOCK();*/
-		waveOutUnprepareHeader(st->waveout, wh, sizeof(*wh));
-		/*UNLOCK();*/
+		EnterCriticalSection(&st->crit);
 		st->inuse--;
-		dsp_write(st);
+		LeaveCriticalSection(&st->crit);
 		break;

 	case WOM_CLOSE:
@@ -197,7 +212,7 @@
 		       auplay_write_h *wh, void *arg)
 {
 	struct auplay_st *st;
-	int i, err;
+	int err;

 	if (!stp || !ap || !prm)
 		return EINVAL;
@@ -210,17 +225,20 @@
 	st->wh  = wh;
 	st->arg = arg;

+	InitializeCriticalSection(&st->crit);
+
 	err = write_stream_open(st, prm, find_dev(device));
 	if (err)
 		goto out;

-	/* The write runs at 100ms intervals
-	 * prepare enough buffers to suite its needs
-	 */
-	for (i = 0; i < 5; i++)
-		dsp_write(st);
+	st->run = true;
+	st->thread = CreateThread(NULL, 0, dsp_write, st, 0, NULL);
+	if (!st->thread) {
+		st->run = false;
+		err = ENOMEM;
+	}

- out:
+out:
 	if (err)
 		mem_deref(st);
 	else

src.c
--- baresip-old/modules/winwave/src.c	2016-07-30 07:25:56.006530541 -0500
+++ baresip-new/modules/winwave/src.c	2016-07-31 23:43:09.741572469 -0500
@@ -24,6 +24,9 @@
 	size_t inuse;
 	ausrc_read_h *rh;
 	void *arg;
+	HANDLE thread;
+	volatile bool run;
+	CRITICAL_SECTION crit;
 };

@@ -32,6 +35,11 @@
 	struct ausrc_st *st = arg;
 	int i;

+	if (st->run) {
+		st->run = false;
+		(void)WaitForSingleObject(st->thread, INFINITE);
+	}
+
 	st->rh = NULL;

 	waveInStop(st->wavein);
@@ -44,32 +52,60 @@
 	}

 	waveInClose(st->wavein);
+	DeleteCriticalSection(&st->crit);
 }

-static int add_wave_in(struct ausrc_st *st)
+static DWORD WINAPI add_wave_in(LPVOID arg)
 {
-	struct dspbuf *db = &st->bufs[st->pos];
-	WAVEHDR *wh = &db->wh;
+	struct ausrc_st *st = (struct ausrc_st *)arg;
 	MMRESULT res;
+	struct mbuf *mb;
+	WAVEHDR *wh;
+	size_t inuse;

-	wh->lpData          = (LPSTR)db->mb->buf;
-	wh->dwBufferLength  = db->mb->size;
-	wh->dwBytesRecorded = 0;
-	wh->dwFlags         = 0;
-	wh->dwUser          = (DWORD_PTR)db->mb;
+	while (st->run) {
+		Sleep(1);

-	waveInPrepareHeader(st->wavein, wh, sizeof(*wh));
-	res = waveInAddBuffer(st->wavein, wh, sizeof(*wh));
-	if (res != MMSYSERR_NOERROR) {
-		warning("winwave: add_wave_in: waveInAddBuffer fail: %08x\n",
-			res);
-		return ENOMEM;
-	}
+		EnterCriticalSection(&st->crit);
+		inuse = st->inuse;
+		LeaveCriticalSection(&st->crit);
+
+		if (!st->rdy)
+			continue;
+
+		if (inuse == READ_BUFFERS)
+			continue;
+
+		wh = &st->bufs[st->pos].wh;
+		if (wh->dwFlags & WHDR_PREPARED)
+			waveInUnprepareHeader(st->wavein, wh, sizeof(*wh));
+
+		mb = st->bufs[st->pos].mb;
+		wh->lpData          = (LPSTR)mb->buf;
+
+		if (st->rh)
+			st->rh((void *)wh->lpData, wh->dwBytesRecorded/2, st->arg);
+
+		wh->dwBufferLength  = mb->size;
+		wh->dwBytesRecorded = 0;
+		wh->dwFlags         = 0;
+		wh->dwUser          = (DWORD_PTR)mb;

-	INC_RPOS(st->pos);
+		waveInPrepareHeader(st->wavein, wh, sizeof(*wh));

-	st->inuse++;
+		INC_RPOS(st->pos);
+
+		res = waveInAddBuffer(st->wavein, wh, sizeof(*wh));
+		if (res != MMSYSERR_NOERROR)
+			warning("winwave: add_wave_in: waveInAddBuffer failed: %d\n", res);
+		else {
+			EnterCriticalSection(&st->crit);
+			st->inuse++;
+			LeaveCriticalSection(&st->crit);
+		}
+
+	}

 	return 0;
 }
@@ -82,14 +118,10 @@
 				    DWORD_PTR dwParam2)
 {
 	struct ausrc_st *st = (struct ausrc_st *)dwInstance;
-	WAVEHDR *wh = (WAVEHDR *)dwParam1;

 	(void)hwo;
 	(void)dwParam2;

-	if (!st->rh)
-		return;
-
 	switch (uMsg) {

 	case WIM_CLOSE:
@@ -101,13 +133,9 @@
 		break;

 	case WIM_DATA:
-		if (st->inuse < (READ_BUFFERS-1))
-			add_wave_in(st);
-
-		st->rh((void *)wh->lpData, wh->dwBytesRecorded/2, st->arg);
-
-		waveInUnprepareHeader(st->wavein, wh, sizeof(*wh));
+		EnterCriticalSection(&st->crit);
 		st->inuse--;
+		LeaveCriticalSection(&st->crit);
 		break;

 	default:
@@ -177,10 +205,6 @@
 		return EINVAL;
 	}

-	/* Prepare enough IN buffers to suite at least 50ms of data */
-	for (i = 0; i < READ_BUFFERS; i++)
-		err |= add_wave_in(st);
-
 	waveInStart(st->wavein);

 	return err;
@@ -209,8 +233,20 @@
 	st->rh  = rh;
 	st->arg = arg;

+	InitializeCriticalSection(&st->crit);
+
 	err = read_stream_open(st, prm, find_dev(device));
+	if (err)
+		goto out;
+
+	st->run = true;
+	st->thread = CreateThread(NULL, 0, add_wave_in, st, 0, NULL);
+	if (!st->thread) {
+		st->run = false;
+		err = ENOMEM;
+	}

+out:
 	if (err)
 		mem_deref(st);
 	else

Few notes:

I removed all pre-buffering lines code
st->rdy is needed yet ?
unplug/plug the microphone will not cause baresip to freeze anymore but we should make baresip detect that and reactivate the microphone on the current call ?
Sleep(5) = tmr timeout of rx ; Sleep(1) = tmr timeout of tx, maybe there is a better way to do that

@GGGO could you please create a PR with the patch above ?

Hi @alfredh,
Sorry for the late reply.
Last time I used baresip, it crashed and I don't know yet if it's related to my patch or to the new multi-line support in Baresip.
Right now I've no time to debug but I hope to come back on this soon.
Do you use baresip on windows ?

Hi @GGGO
I am not using Windows, I have tested baresip compiled with Mingw32 and running
baresip.exe with WINE. This seems to work quite well. Also multiple simultaneous
calls seems to work (using PCMU at 8000Hz)
I will close this issue for now, please reopen or create a new issue once
you are back, and:

please test a clean baresip on windows, if there is a crash then please
provide the full config and log.

please create a new PR for the above patches, I am happy to test it
if I can apply them cleanly.


Istio-1.13.2 not support K8S 1.21 dualStack ReadinessProbe failed

Bug Description
When I installed istio version 1.13.2 in kubernetes version 1.21, the health check of istio ingress gateway failed all the time. Because the health check through IPv6 + port failed all the time, I looked at the IPv4 address of pod and it was successful
Version
[root@wxjd-csy-vm-os01-bcapp-master01 ~]#  istioctl version
client version: 1.13.2
control plane version: 1.13.2
data plane version: 1.13.2 (1 proxies)

[root@wxjd-csy-vm-os01-bcapp-master01 ~]#  kubectl version --short
Client Version: v1.21.5-eki.0
Server Version: v1.21.5-eki.0

Additional Information

i used install command
istioctl install  --set hub:8086=nexus.cmss.com/paas-pcb2/service-mesh/istio  --set profile=default

English is very poor. It's the first time to post a question on GitHub. I hope the powerful person can give a reply. Thank you

@wangyj-tc did a bit more testing on IPv4 only cluster as well, I still see the readines probe failed error and I think that is really the timing issue.

Dual stack is not yet supported, see https://github.com/istio/istio/issues/37533

@wangyj-tc @howardjohn I did some more testing with dual stack and ipv6 only clusters, with a bit increased initial delay on the ingressgateway and a bit change to helloworld test app (which for some reason does not bind to both ipv4 and ipv6 address, with a bit change to the app itself, it does bind to both ipv4 and ipv6 addresses), from what I can see everything is working. This is based on istio 1.13.2.

s, with a bit increased initial delay on the ingressgateway and a bi

Is there a plan for when it will be supported?

@wangyj-tc @howardjohn I did some more testing with dual stack and ipv6 only clusters, with a bit increased initial delay on the ingressgateway and a bit change to helloworld test app (which for some reason does not bind to both ipv4 and ipv6 address, with a bit change to the app itself, it does bind to both ipv4 and ipv6 addresses), from what I can see everything is working. This is based on istio 1.13.2.

Can you briefly describe the place where it was remodeled? Or some screenshots would be better

@wangyj-tc you can use the following yaml to increase the initial delay of readiness probe.
istioctl install -y -f - <<EOF
apiVersion: install.istio.io/v1alpha1
kind: IstioOperator
metadata:
  namespace: istio-system
spec:
  components:
    ingressGateways:
    - name: istio-ingressgateway
      enabled: true
      k8s:
        overlays:
        - kind: Deployment
          name: istio-ingressgateway
          patches:
          - path: spec.template.spec.containers[0].readinessProbe.initialDelaySeconds
            value: 15
EOF

in terms of the verification, I used the istio hello world deployment, but there were some issues due to the python app behaves differently with using default port vs explicitly specified port. Fortunately by using some env variables and reconfiguring the entrypoint, one can force the app to bind to both ipv4 and ipv6 addresses so that the app will work on dual stack. here is what I have. I will include the entire deployment for completeness. The key is to use env and change the container entry point so that the port is explicitly specified.
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: helloworld-v1
  labels:
    app: helloworld
    version: v1
spec:
  replicas: 1
  selector:
    matchLabels:
      app: helloworld
      version: v1
  template:
    metadata:
      labels:
        app: helloworld
        version: v1
    spec:
      containers:
      - name: helloworld
        image: docker.io/istio/examples-helloworld-v1
        resources:
          requests:
            cpu: "100m"
        env:
        - name: FLASK_RUN_PORT
          value: "5000"
        - name: FLASK_RUN_HOST
          value: "::"
        - name: FLASK_ENV
          value: "development"
        - name: FLASK_APP
          value: "/opt/microservices/app.py"
        command: ["flask", "run"]
        imagePullPolicy: IfNotPresent #Always
        ports:
        - containerPort: 5000

@wangyj-tc btw, even in ipv6 only k8s, the deployment of istio and hello world tests will still work.

more info to show you that the control plane is working fine with ipv6 setup.
ubuntu@u2004:~$ kg -n istio-system all
NAME                                        READY   STATUS    RESTARTS   AGE
pod/istio-ingressgateway-57746c8ddb-l5dfg   1/1     Running   0          2m57s
pod/istiod-5b6d7d4cb5-kw9mm                 1/1     Running   0          3m9s

NAME                           TYPE           CLUSTER-IP         EXTERNAL-IP                   PORT(S)                                      AGE
service/istio-ingressgateway   LoadBalancer   fd00:10:96::91f5   fc00:f853:ccd:e793::255:200   15021:30330/TCP,80:30463/TCP,443:32369/TCP   2m57s
service/istiod                 ClusterIP      fd00:10:96::2023   <none>                        15010/TCP,15012/TCP,443/TCP,15014/TCP        3m9s

NAME                                   READY   UP-TO-DATE   AVAILABLE   AGE
deployment.apps/istio-ingressgateway   1/1     1            1           2m57s
deployment.apps/istiod                 1/1     1            1           3m9s

NAME                                              DESIRED   CURRENT   READY   AGE
replicaset.apps/istio-ingressgateway-57746c8ddb   1         1         1       2m57s
replicaset.apps/istiod-5b6d7d4cb5                 1         1         1       3m9s

NAME                                                       REFERENCE                         TARGETS         MINPODS   MAXPODS   REPLICAS   AGE
horizontalpodautoscaler.autoscaling/istio-ingressgateway   Deployment/istio-ingressgateway   <unknown>/80%   1         5         1          2m57s
horizontalpodautoscaler.autoscaling/istiod                 Deployment/istiod                 <unknown>/80%   1         5         1          3m9s

@wangyj-tc you can use the following yaml to increase the initial delay of readiness probe.
istioctl install -y -f - <<EOF
apiVersion: install.istio.io/v1alpha1
kind: IstioOperator
metadata:
  namespace: istio-system
spec:
  components:
    ingressGateways:
    - name: istio-ingressgateway
      enabled: true
      k8s:
        overlays:
        - kind: Deployment
          name: istio-ingressgateway
          patches:
          - path: spec.template.spec.containers[0].readinessProbe.initialDelaySeconds
            value: 15
EOF

in terms of the verification, I used the istio hello world deployment, but there were some issues due to the python app behaves differently with using default port vs explicitly specified port. Fortunately by using some env variables and reconfiguring the entrypoint, one can force the app to bind to both ipv4 and ipv6 addresses so that the app will work on dual stack. here is what I have. I will include the entire deployment for completeness. The key is to use env and change the container entry point so that the port is explicitly specified.
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: helloworld-v1
  labels:
    app: helloworld
    version: v1
spec:
  replicas: 1
  selector:
    matchLabels:
      app: helloworld
      version: v1
  template:
    metadata:
      labels:
        app: helloworld
        version: v1
    spec:
      containers:
      - name: helloworld
        image: docker.io/istio/examples-helloworld-v1
        resources:
          requests:
            cpu: "100m"
        env:
        - name: FLASK_RUN_PORT
          value: "5000"
        - name: FLASK_RUN_HOST
          value: "::"
        - name: FLASK_ENV
          value: "development"
        - name: FLASK_APP
          value: "/opt/microservices/app.py"
        command: ["flask", "run"]
        imagePullPolicy: IfNotPresent #Always
        ports:
        - containerPort: 5000

First of all, thank you for your answer. I also tested it and found that it doesn't work, and I don't quite understand how a 15-second delay in the health check will affect the results.

I choose a large value was to make sure that value makes the probe wait long enough for the system to get everything ready such as pulling container images. If the long wait is not helping, most likely you have some other issues. In terms of getting control plane up running and sidecar injected as I have stated above are working in an environment I setup. Your environment may have been different, if the larger wait time won't help, there must be some other issues, the default wait is 1 second which in some situations may not be enough.

@litong01 i get same issues with you , is there any way to solve it?

@wangyj-tc hi, i get same issues with you , have you found any way to solve it?


Adding Adafruit Bluefruit to list of supported devices.

Also, creating list of supported devices.
Not yet tested!

Tried to run against my Adafruit Blulfruit Board. Find the device on USB but get "error: error while reading from serial port: Operation timed out" not sure whats wrong. Needs more investigation.

Getting a response from the Board: [13, 10, 119, 114, 105, 116, 101, 32, 116, 104, 105, 115, 13, 10, 48, 32, 91, 48, 46, 48, 48, 32, 109, 86, 93, 13, 10, 48, 32, 91, 48, 46, 48, 48, 32, 109, 86, 93, 13, 10] So the Error 'Operation timed out' seams to be a bit misleading.


h3: make GREASE numbers more uniform

We've had many compliments during interop testing on our use of very large values when sending greasy things. The generation of these values is "uniform random" but the frequency of these compliments made me suspicious. I knocked together a quick dummy program to test things over 100000 iterations:
grease_value() on master
0.00020000020000019998'th percentile of data is<PHONE_NUMBER>685247 with 2 samples
0.0005000005000005'th percentile of data is<PHONE_NUMBER>370495 with 3 samples
0.001000001000001'th percentile of data is<PHONE_NUMBER>740991 with 5 samples
0.0024000024000024'th percentile of data is<PHONE_NUMBER>9481983 with 14 samples
0.0051000051000051'th percentile of data is<PHONE_NUMBER>8963967 with 27 samples
0.011700011700011701'th percentile of data is<PHONE_NUMBER>7927935 with 66 samples
0.0237000237000237'th percentile of data is<PHONE_NUMBER>75855871 with 120 samples
0.0472000472000472'th percentile of data is<PHONE_NUMBER>51711743 with 235 samples
0.097000097000097'th percentile of data is<PHONE_NUMBER>03423487 with 498 samples
0.1968001968001968'th percentile of data is<PHONE_NUMBER>606846975 with 998 samples
0.4031004031004031'th percentile of data is<PHONE_NUMBER>213693951 with 2063 samples
100'th percentile of data is<PHONE_NUMBER>427387903 with 995968 samples

this shows a slight skew towards the maximum allowed value.
I substituted the RAND_bytes() call for a Rust random call, and the results start to look way more uniform (unfortunately I only captured 10000 iterations):
grease_value() alternative
0.030003000300030006'th percentile of data is<PHONE_NUMBER>21311 with 3 samples
0.040004000400040006'th percentile of data is<PHONE_NUMBER>685247 with 1 samples
0.1000100010001'th percentile of data is<PHONE_NUMBER>370495 with 6 samples
0.22002200220022'th percentile of data is<PHONE_NUMBER>740991 with 12 samples
0.37003700370037007'th percentile of data is<PHONE_NUMBER>9481983 with 15 samples
0.8000800080008'th percentile of data is<PHONE_NUMBER>8963967 with 43 samples
1.69016901690169'th percentile of data is<PHONE_NUMBER>7927935 with 89 samples
3.2603260326032606'th percentile of data is<PHONE_NUMBER>75855871 with 157 samples
6.410641064106411'th percentile of data is<PHONE_NUMBER>51711743 with 315 samples
12.8012801280128'th percentile of data is<PHONE_NUMBER>03423487 with 639 samples
25.272527252725276'th percentile of data is<PHONE_NUMBER>606846975 with 1247 samples
49.874987498749874'th percentile of data is<PHONE_NUMBER>213693951 with 2460 samples
100'th percentile of data is<PHONE_NUMBER>427387903 with 5012 samples

This should also shave a few bytes off requests/responses due to varints, but I doubt that is a major perf win.
If we prefer to use SSL library functions for proper uniformality, we either need more hand-rolled code, use BN_rand_range or something else(?).

Needed to add -lm for the C examples, which implies that this introduces a knock-on dependency for all users of libquiche. That's annoying.

It's also kind of annoying that we pull in 11 or so new dependencies for just a single call:
   Compiling autocfg v0.1.6
   Compiling rand_core v0.4.2
   Compiling rand_core v0.3.1
   Compiling rand_jitter v0.1.4
   Compiling rand_os v0.1.3
   Compiling rand_isaac v0.1.1
   Compiling rand_xorshift v0.1.1
   Compiling rand_hc v0.1.0
   Compiling rand_chacha v0.1.1
   Compiling rand_pcg v0.1.2
   Compiling rand v0.6.5

We can probably build something much simpler based on the existing rand functions we have. See e.g. the "Integer only w/ re-rolls" method in https://codereview.stackexchange.com/a/159760

It's also kind of annoying that we pull in 11 or so new dependencies for just a single call:
   Compiling autocfg v0.1.6
   Compiling rand_core v0.4.2
   Compiling rand_core v0.3.1
   Compiling rand_jitter v0.1.4
   Compiling rand_os v0.1.3
   Compiling rand_isaac v0.1.1
   Compiling rand_xorshift v0.1.1
   Compiling rand_hc v0.1.0
   Compiling rand_chacha v0.1.1
   Compiling rand_pcg v0.1.2
   Compiling rand v0.6.5

We can probably build something much simpler based on the existing rand functions we have. See e.g. the "Integer only w/ re-rolls" method in https://codereview.stackexchange.com/a/159760

Try to make a different approach: https://github.com/cloudflare/quiche/tree/grease-uniform-using-ring
I didn't create a PR, but it's a simple patch. Please take a look. Not sure I am doing it correctly...

I changed this add rand::rand_u64_uniform() as suggested, PTAL.


do_batch_norm in webQSP

Batch norm greatly improved training speed for MetaQA. Could you explain why you set do_batch_norm to 0 for WebQSP (lead to more training epoches and patience)? What if we set it to 1? And how much can RelScore improve the results?

Didn't you use batch norm in KGE of WebQSP either?

Batch norm greatly improved training speed for MetaQA. Could you explain why you set do_batch_norm to 0 for WebQSP (lead to more training epoches and patience)? What if we set it to 1? And how much can RelScore improve the results?

For WebQSP we used the KGE training implementation of https://github.com/uma-pi1/kge rather than our own implementation derived from https://github.com/ibalazevic/TuckER. This is because they have optimized their code for large KGs. Their implementation does not used batch norm, and we found through experimentation that training embeddings without batch norm but question embedding with batch norm doesn't yield good results: either do both or none. So we did not use batch norm in WebQSP.
The improvement resulting from RelScore can be found in Table 5 of our paper.

Didn't you use batch norm in KGE of WebQSP either?

No, since we used a different KGE implementation (as described above) which doesn't do batch norm.


Can't build project if using @FormDataRequest - Symbol() not available

Bug Report
Current behavior
Can't build Nest app when adding @FormDataRequest decorator to @Post method in the controller.
Error message:
[ExceptionHandler] Nest can't resolve dependencies of the FormDataInterceptor (?, Reflector). Please make sure that the argument Symbol() at index [0] is available in the UserModule context.
Potential solutions:
app_1           | - If Symbol() is a provider, is it part of the current UserModule?
app_1           | - If Symbol() is exported from a separate @Module, is that module imported within UserModule?
app_1           |   @Module({
app_1           |     imports: [ /* the Module containing Symbol() */ ]
app_1           |   })|
 at Injector.lookupComponentInParentModules (/usr/src/app/node_modules/@nestjs/core/injector/injector.js:188:19)
app_1           |     at async Injector.resolveComponentInstance (/usr/src/app/node_modules/@nestjs/core/injector/injector.js:144:33)
app_1           |     at async resolveParam (/usr/src/app/node_modules/@nestjs/core/injector/injector.js:98:38)
app_1           |     at async Promise.all (index 0)
app_1           |     at async Injector.resolveConstructorParams (/usr/src/app/node_modules/@nestjs/core/injector/injector.js:113:27)
app_1           |     at async Injector.loadInstance (/usr/src/app/node_modules/@nestjs/core/injector/injector.js:46:9)
app_1           |     at async Injector.loadInjectable (/usr/src/app/node_modules/@nestjs/core/injector/injector.js:64:9)
app_1           |     at async Promise.all (index 6)
app_1           |     at async InstanceLoader.createInstancesOfInjectables (/usr/src/app/node_modules/@nestjs/core/injector/instance-loader.js:61:9)
app_1           |     at async /usr/src/app/node_modules/@nestjs/core/injector/instance-loader.js:29:13
app_1           |     at async Promise.all (index 4)
app_1           |     at async InstanceLoader.createInstances (/usr/src/app/node_modules/@nestjs/core/injector/instance-loader.js:27:9)
app_1           |     at async InstanceLoader.createInstancesOfDependencies (/usr/src/app/node_modules/@nestjs/core/injector/instance-loader.js:17:9)
app_1           |     at async /usr/src/app/node_modules/@nestjs/core/nest-factory.js:90:17
app_1           |     at async Function.asyncRun (/usr/src/app/node_modules/@nestjs/core/errors/exceptions-zone.js:18:13)
app_1           |     at async NestFactoryStatic.initialize (/usr/src/app/node_modules/@nestjs/core/nest-factory.js:88:13)

Expected Behavior
Build should work.
Nest version: 7.6.15
Typescript: 4.0.2

After trying a few things I realized the issue is solved when adding the import NestjsFormDataModule to the same module the controller was located in. Before this I only had NestjsFormDataModule as an import in the top-level app module

Might be a good idea to update the docs


Bump @nextcloud/vue from 4.2.0 to 5.0.0

Required for https://github.com/nextcloud/server/pull/29796
I didn't test yet.

Superseded by #15.


21w37a JFR forwardport

Forwardported (is that a word?) the JFR mappings from #2582 - you can diff the patch file of this and that PRs in WinMerge, ignore (field|method)_\d+ and compare, I guess.
JFR uses a lot of records; while they do feature mojang names in methods the names used here are all from #2582 PR. There are new things like path arg becoming reader due to type change, fromEvent/toStatistics etc.
Method for forwardporting: Ctrl+C from the original patch.  Took 90min or so.

Just a heads up Player has said he is looking into matching and porting the exp mappings over, so it might not be a bad idea to hold on porting any more over.
Glad to see the record remapping seems to be working, I think there is still room for improvement, possibly expanding engima's format to combine the field and method mappings into one, and then writing out the 2 when exporting to other formats. Would need some discussion first however.

Now this PR is 100% new-in-21w37a stuff