Gerrit: Make the gitilesBaseUrl mandatory

This patch makes the Gerrit UrlReader throw an exception if the gitilesBaseUrl is not set. To opt out of this set the env variable DISABLE_GERRIT_GITILES_REQUIREMENT.
Hey, I just made a Pull Request!
This is as discussed in #22500.
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[x] All your commits have a Signed-off-by line in the message. (more info)

We probably want to mention the (soon) mandatory Gitiles dependency in the documentation.

@tudi2d Check this comment by @Rugvip that decribes this change.


Improvemnt: Beautify the readme file [fixes #4]

Improvemnt: Beautify the readme file [fixes #4]

Thank You for your contribution @najeebkp


rendering of uib-typeahead on chromium browser fails with "Cannot read property 'originalExp' of undefined"

Bug description:
Rendering of uib-typeahead directive fails on chromium browser with error:
angular.js:14199 TypeError: Cannot read property 'originalExp' of undefined
    at Scope.scopePrototype.$watch (<anonymous>:1:5644)
    at new <anonymous> (ui-bootstrap-tpls.js:6755)
    at Object.invoke (angular.js:4771)
    at $controllerInit (angular.js:10592)
    at nodeLinkFn (angular.js:9469)
    at compositeLinkFn (angular.js:8810)
    at compositeLinkFn (angular.js:8813)
    at compositeLinkFn (angular.js:8813)
    at nodeLinkFn (angular.js:9545)
    at compositeLinkFn (angular.js:8810)

This only happens with chromium browser. I checked Firefox 54.0 on Linux, Firefox 54.0.1 on Mac, Chrome 59.0.3071.115 on Mac, Safari 10.1.1 on Mac and Opera on Mac, they all work fine.
edit: just installed official google chrome for linux (Version 59.0.3071.115 (Official Build) (64-bit)) / same error there
All my previously working typeahead fields have failed. On debugging this issue, I discovered that the examples from the documentation also fail in chromium browser. It's obviously some weird interaction between ui-bootstrap and the chromium browser. I really don't know whom to take this up with.
Steps to reproduce the issue:
use chromium browser Version 59.0.3071.109 (Developer Build) Built on Ubuntu , running on Ubuntu 16.04 (64-bit) or chrome for Linux  (Version 59.0.3071.115 (Official Build) (64-bit)).
head to documentation page https://angular-ui.github.io/bootstrap/#!#typeahead
have a close look at the "Asynchronous results" example. You'll see the directive break and find the 'originalExp' error on the console.
Version of Angular, UIBS, and Bootstrap
my own setup:
AngularJS: 1.5.11
UIBS: bower 2.5.0
Bootstrap: boostrap-css  3.3.4
and whatever you are currently using on the documentation platform.

Did some more digging, because it was such a bizare bug, turns out, the "AngularJS Birbal" chrome extension was at fault.


Work in if section or new option for kafka_log

Thanks for the module! But, please, add the ability to work inside if. This will help to cancel the logging of some requests:
server {
  set $kafka_log 1;
  location / {
    if ($uri_match_trackers) {
      set $not_logging T;
    }
    if ($arg_is_attributed = 0) {
      set $not_logging "${not_logging}T";
    }
    if ($not_logging = "TT") {
      set $kafka_log 0;
    }
    if ($kafka_log) {
      kafka_log kafka:test '{"timestamp":"$msec"}';
    }
    proxy_pass http://tracker;
  }
}

Now I get the error:
nginx: [emerg] "kafka_log" directive is not allowed here

The configuration can be like this:
server {
  kafka_log kafka:test '{"timestamp":"$msec"}';
  location / {
    if ($uri_match_trackers) {
      set $not_logging T;
    }
    if ($arg_is_attributed = 0) {
      set $not_logging "${not_logging}T";
    }
    if ($not_logging = "TT") {
      kafka_log off;
    }
    proxy_pass http://tracker;
  }
}

I have the same problem.

You can do it by using a variable for topic and having it evaluate to an empty string when you don't want to send the message. If topic is empty, the module doesn't send a message.


Newest release is not compatible with Spring-Boot version 3.0.0

I would like to upgrade to spring-boot 3.0.0 and am currently using lettucemod version v3.1.6.
However I am running into some incompatabilities.
The current implementation of the autoconfiguration seems to be incompatible.
Would be awesome if you could have a look! :)

Spring Boot 3 autoconfiguration was added in LettuceMod 3.2.1 (Thanks @zcw159357)


Proposed update to default className

I propose that there is a default theme selected upon start. This makes it just a little bit easier when starting using vex for a few people. In my case I use brunch to bake vex into all of my stuff. I would love to not have a setup phase for vex if I am content with the plain vex-theme-os.

Would it possible to make the default vex-theme-default? Mainly because the theme name has default in it? :trollface:

Would be much more :trollface: if the default theme wasn't the default theme ;)

Fair point :sweat_smile:
Let me just double check that this and https://github.com/HubSpot/vex/pull/124 works alright and I'll have them merged in ASAP.
Thanks again for these changes! :smiley_cat:

Thank you for the quick replies!

Hey y’all, I love the spirit of this, but I want to take a step back and explain the rationale before we go ahead with it. (I’m not opposed, but I think more discussion is needed.)
First off, the idea behind breaking of vex from vex.dialog is because the thinking is that other open source libraries may want to build on vex due to its (hopefully) minimal/slim/efficient/to-the-point architecture.
Along this line, I always intended that the minimal code required to run the project was vex.js and vex.css, and I believe the docs make a reference to this. However, highly recommended (if not officially “required”) that one of the theme files be included when using vex dialog. With all of that in mind, I think this change might be more appropriate for the default options object in vex dialog as opposed to vex.
That being said, if we make it clear that the new minimal set of required files includes vex.js, vex.css and vex-theme-default.css, then I would be more inclined to support this change PR as currently written.

I think having no default class name is a good check for anyone that includes vex and is wondering why the dialogs don't look good. Add a theme! Even if it is a default.


[BEAM-3735] Copy mobile-gaming sources in to archetypes

DESCRIPTION HERE

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
[ ] Write a pull request description that is detailed enough to understand:

[ ] What the pull request does
[ ] Why it does it
[ ] How it does it
[ ] Why this approach

[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

+R: @alanmyrvold

@lukecwik I talked to Huygaa and modified the code. It will only copy game examples including injector and utils instead of all stuffs from */complete/. Please review when you get a moment. Thanks~

@lukecwik Are you happy with this now?


Add custom control option for RuleGroup component

This pull request allow to customize the RuleGroup component. As Rule component is a part of it, it's now accessible when using this module. Furthermore, I fixed an issue with copy-webpack-plugin (caused by the recent package upgrade).

Codecov Report

Merging #141 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #141   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           13        13
  Lines          267       267
  Branches        23        23
=========================================
  Hits           267       267

Impacted Files
Coverage Δ

src/QueryBuilder.jsx
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53d596e...5be4dae. Read the comment docs.

Thanks, @rbalaine!  Does this resolve #133?

@jakeboone02 Thanks for your comments, I'm fixing that. It doesn't fix #133, only RuleGroup is now customizable. But I saw that artenator did it on his fork, he could make a Pull Request for it.


Some docker containers don't automatically start up after reboot

After a reboot, docker compose did not automatically start some containers -- namely caddy, homeassistant, samba, traefik.
The root-cause could be found with sudo journalctl -u docker:
Dec 20 10:20:52 hulk dockerd[1794]: time="2024-12-20T10:20:52.852774736+01:00" level=warning msg="Failed to allocate and map port: failed to bind port <IP_ADDRESS>:445/tcp: Error starting userland proxy: listen tcp4 <IP_ADDRESS>:445: bind: cannot assign requested address"
Dec 20 10:20:52 hulk dockerd[1794]: time="2024-12-20T10:20:52.852866327+01:00" level=warning msg="Failed to allocate and map port: failed to bind port <IP_ADDRESS>:80/tcp: Error starting userland proxy: listen tcp4 <IP_ADDRESS>:80: bind: cannot assign requested address"
Dec 20 10:20:53 hulk dockerd[1794]: time="2024-12-20T10:20:53.054044984+01:00" level=warning msg="Failed to allocate and map port: failed to bind port <IP_ADDRESS>:80/tcp: Error starting userland proxy: listen tcp4 <IP_ADDRESS>:80: bind: cannot assign requested address"
Dec 20 10:20:53 hulk dockerd[1794]: time="2024-12-20T10:20:53.058178040+01:00" level=warning msg="Failed to allocate and map port: failed to bind port <IP_ADDRESS>:445/tcp: Error starting userland proxy: listen tcp4 <IP_ADDRESS>:445: bind: cannot assign requested address"

These docker compose services use a specific IP for their port binding, which apparently does not work fast enough after a reboot. While the systemd docker.service has After and Wants set to network-online.target, this seems to be not fully reliable.

Root cause might be related to this bug? https://github.com/coreos/bugs/issues/1966
Checking with systemd-analyze plot > output.svg showed that network-online.target was available at 31.7s, with quite a few services coming before docker is started at 32.4s, taking 5.463s after that. The actual containers seem to start even later, with the problematic ones starting roughly 3s later (comparing the journalctl output timestamp).
One solution might be to add an ExecStartPre=/bin/sleep 5 to the systemd docker.service -- not nice, and probably only 99% safe. This can also be done with a systemd override file, so a docker update won't undo the change.
Another solution hinted at in this StackOverflow comment might be to switch my interfaces from allow-hotplug to auto?

Third option might be to switch to static IP addresses, as possibly dhcp is too slow? Not sure how to debug this atm.

Another possible Debian bug link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1029352

Commit https://github.com/Benny-Git/homeserver/commit/a2302c0612a23d710315519b7405831271442723 might have fixed this issue, as confirmed via a simple reboot.
Not 100% sure however, as that issue never occured in the past on reboots.
If it occurs again, one of the other options might be needed.


DUPLO-25632 TF:ASG: Terraform plan is failing for duplocloud_asg_profiles (Data Source)

Overview
Bug fix asg profile datasource
Summary of changes
Typo fix at data duplocloud_asg_profiles
This PR does the following:

fixed attribute typo of network_interface and volume
...

Testing performed

[ ] Using unit tests
[ ] Manually, on my local system
[ ✓] Manually, on a remote test system

Describe any breaking changes

...

Task linked: DUPLO-25632 TF:ASG: Terraform plan is failing for duplocloud_asg_profiles (Data Source)


Trying to build rel/1.1.0 locally: 'TaskCache' is inaccessible due to its protection level

I've cloned this repository, opened Identity.sln in Visual Studio 2017 (Version 15.2 (26430.14) Release, pro edition, to be precise) and tried to compile, but it fails here with the error 'TaskCache' is inaccessible due to its protection level..
My ultimate goal is to obtain debugging symbols so I can step into ExternalLoginSignInAsync and figure out why my login attempt fails, but just activating Microsoft Symbol Servers and adding https://nuget.smbsrc.net to symbol sources didn't help, so I'm trying to add a source reference instead.
How can I get past these errors, so I can step through the method and see what's going on?

What else are you building? You're going, at a minimum, also compile in https://github.com/aspnet/Common/tree/rel/1.1.0/src/Microsoft.Extensions.TaskCache.Sources

Hm, I didn't build anything but the sources from this repo. I'll try again after also building that.
Do they have to reside in some special relation to each-other on the file system? Is it documented somewhere that there's a dependency on building that locally, too?

i hava some question, did you get it? why Microsoft Dever did not care it?

@kangze I actually never managed to build this locally, mostly because I figured out what my real problem was anyway (I only needed a local build to step through with the debugger).


Add support for str and int Enum

👋 @mitchelllisle (hope there's room for another Mitch here 😂)
Changes

Added support for Enum mixed with int or str

Default behaviour for data generation is to generate data for all Enum values

Updated docstrings and documentation, black reformatting stuff
Minor refactor of existing code (mainly SparkModel methods)

To do
Once the proposal is accepted and all comments are resolved:

[x] Bump minor version
[x] Add enum docs to README.md

@mitchstockdale Thanks for contributing! This looks like a good addition. Only things before I merge:
The docs are auto generated from the README.md. So instead of altering the docs/index.md file, simply add the new documentation to the README and the docs will automatically get updated when I do a new release (The docs/index.md file technically doesn't need to be populated at all since its auto generated)

Cool, thanks @mitchelllisle! Ready for re-review


Add additional bank configuration items

For a prettier generation of bank letters and other bits used in examples:

Added a French template based on implementation guide with French example from ABACUS Research SA.

Expand the bank config to include:

"bankFullName" used in the INI letter's which are sent to the bank.

"bankShortName" used in the filename for the generated letters and in other places if needed.

"languageCode" used for determining which template to use for the bank (currently "en" and "de" are supported).

"storageLocation" can be used to specify a local or network path where to store downloaded files.

In bankLetter.js: Use the current script folder as output for the bank's letter in HTML format instead of the user/os homedir folder.

Signed-off-by: Herman van Hazendonk<EMAIL_ADDRESS>

@nanov I will expand the examples with usage of "storageLocation" after this and other PR's are merged.

The only comment I have here, is why introduce braking change and remove bankName instead of just adding bankFullNme or alternatively bankShortName ( seems and the current one should bet the full one already ), and defaulting the one to the other if not present? ( ie. bankShortName =  bankShortName || bankFullName ).

The only comment I have here, is why introduce braking change and remove bankName instead of just adding bankFullNme or alternatively bankShortName ( seems and the current one should bet the full one already ), and defaulting the one to the other if not present? ( ie. bankShortName = bankShortName || bankFullName ).

bankShortName would be a name that doesn't contain any whitespace, so either the BIC or an abbreviation that could then be used in generated filenames for example (such as bank letter or downloaded CAMT/MT940 files). I will expand the examples a bit once this has been merged.
I thought to change bankName into bankFullName to avoid any confusion and it's more clear. Similar like you changed the config items from "serverAddress" into "url" and "keyStorage" into "keyStoragePath".

I thought to change bankName into bankFullName to avoid any confusion and it's more clear. Similar like you changed the config items from "serverAddress" into "url" and "keyStorage" into "keyStoragePath".

leaving bankName as is and NOT introducing breaking changes seems a cleaner solution.

I thought to change bankName into bankFullName to avoid any confusion and it's more clear. Similar like you changed the config items from "serverAddress" into "url" and "keyStorage" into "keyStoragePath".

leaving bankName as is and NOT introducing breaking changes seems a cleaner solution.

Yes and no ;) I can update bankName to bankFullName in everywhere it occurs (so the various js files related to BankLetter (which is the only place it's being used anyway for the moment). Or keep it bankName, up to you in the end.

@nanov This should be good to go now


docs: add reference docs for useEmbeddedDiscoveryService feature

Add reference for the new useEmbeddedDiscoveryService feature to the cluster templates reference docs.
Feature PR: https://github.com/siderolabs/omni/pull/105

/m

/m


Put -getinfo on API

Currently the only way of getting information about the node is running the following command on the command-line:
lbrycrd-cli -getinfo
Please, also provide a JSON RPC interface, for example with getinfo method:
curl --user myusername --data-binary '{"jsonrpc": "1.0", "id":"curltest", "method": "getinfo", "params": [] }' -H 'content-type: text/plain;' http://<IP_ADDRESS>:9245/

Regards,
Melroy

I think getinfo only exists on old versions of lbrycrdd and has been replaced with other things. Apart from that I'll let someone else answer the rest of the issue.

You are right. Let's just use: getblockchaininfo & getnetworkinfo methods.


WIP: 3-ci-srv-04: [no-test] Check for NPM dependency updates

Check for any outstanding update of point version of any outstanding NPM package dependency

[ ] npm-update

npm-update in progress on 3-ci-srv-04.
Log: https://logs.cockpit-project.org/logs/npm-update-1014-20200622-125151/


List all airnode-examples integrations and reference functionality in relevant locations

Based on AN-273 and this thread, all airnode-examples should be listed and links to relevant airnode-examples integrations included where relevant.

Hi @dcroote, this looks very good to me. From the user's perspective, this seems insanely practical as these have been next to invisible, really. Big kudos!


Add tracing details

Could you please add tracing details in Readme file? This will help troubleshoot issues as we can't take fiddler to track calls.

Thanks @mrkarMSFT - just to clarify - would you like me to include instructions on setting up a logger and turn of network trace logging into the README?
Or did you mean something else by tracing? (e.g. distributed tracing)

@annatisch - Yes. Please include the instructions on setting up a logger and turn of network trace logging into the README file so that it helps with debugging.

any update on this?


visualizer: use arxiv.org/abs/ instead of arxiv.org/

Small tweak to use a more direct URL for arxiv.org preprints

This is working much better indeed, I think because there is a redirection https://arxiv.org/abs/arxiv:0910.2050 -> https://arxiv.org/abs/0910.2050 and I am not removing the arxiv: prefix in the url.


The "Auto Insert Semicolons" doesnt work

I tried this on alot of places but it doesn't work for me
using C++ version 23
Clion 2022.2
Actionable version 3.11.0
idk if this helps even

Hi, that's only for java.

oh okay thank you, will you make it for C++ or other places?

I want to, but have no plans ...

okay well thank you for the info!


Add the Kotlin language ;)

Just add the Kotlin language on your project please =)
Else I like this project !

If you are referring to the large image in the rich presence Kotlin is already supported. Although the version (v0.2.0) that adds those images has been released about 2 days ago it hasn't been approved by Jetbrains yet and won't appear in the IDE's plugin browsers until then.
You can already download it from the release page though.

Ohh Sorry, I don’t view it 😊.
Good luck !
Provenance : Courrier pour Windows 10
De : Aljoscha Grebe
Envoyé le :dimanche 3 décembre 2017 15:05
À : Almighty-Alpaca/Intellij-Discord-Integration
Cc : tim54000; Author
Objet :Re: [Almighty-Alpaca/Intellij-Discord-Integration] Add the Kotlinlanguage ;) (#6)
If you are referring to the large image in the rich presence Kotlin is already supported. Although the version (v0.2.0) that adds those images has been released about 2 days ago it hasn't been approved by Jetbrains yet and won't appear in the IDE's plugin browsers until then.
You can already download it from the release page though.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast.
https://www.avast.com/antivirus


Automatic PR from RestAPI-PR2037

Generated from RestAPI PR: https://github.com/Azure/azure-rest-api-specs/pull/2037

Codecov Report

Merging #1641 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1641      +/-   ##
==========================================
+ Coverage   56.13%   56.14%   +<.01%
==========================================
  Files        3956     3956
  Lines       94940    94954      +14
==========================================
+ Hits        53296    53310      +14
  Misses      41644    41644

Impacted Files
Coverage Δ

...zure/keyvault/models/deleted_certificate_bundle.py
100% <ø> (ø)
:arrow_up:

...yvault/azure/keyvault/models/deleted_key_bundle.py
100% <ø> (ø)
:arrow_up:

...e-keyvault/azure/keyvault/models/storage_bundle.py
41.66% <ø> (ø)
:arrow_up:

...keyvault/azure/keyvault/models/certificate_item.py
100% <ø> (ø)
:arrow_up:

...e/keyvault/models/certificate_create_parameters.py
100% <ø> (ø)
:arrow_up:

...ult/azure/keyvault/models/sas_definition_bundle.py
50% <ø> (ø)
:arrow_up:

...ult/azure/keyvault/models/deleted_secret_bundle.py
100% <ø> (ø)
:arrow_up:

...yvault/azure/keyvault/models/issuer_credentials.py
100% <ø> (ø)
:arrow_up:

...zure-keyvault/azure/keyvault/models/secret_item.py
100% <ø> (ø)
:arrow_up:

...lt/azure/keyvault/models/key_restore_parameters.py
100% <ø> (ø)
:arrow_up:

... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40fa36d...779ac72. Read the comment docs.

Closing this pull request as new changes are going to be merged into keyvault_1.0_preview.


Implement new dex component (WIP)

Closes #2398

Although this is still a WIP, I'd prefer to merge it now in order to be able to split out the dex into a component crate (#2288)


Run Accessibility Developer tools over new site

See the Chrome Accessibility Developer Tools and the library

Completed for main pages


Please reintroduce a supply cap (hear me out)

This isn't about wanting to make money or making the price "go to the moon". This about creating trust in the currency.
If Dogecoin supply is unlimited, then it will lose value even MORE than regular fiat. This is because sure the governments print money, but its nowhere near as linear and constant as Doge. They print it when they need it. Doge is printed constantly.
Overall setting a cap would just expand Doge to more people. It would be more "safe" in terms of value.
I will probably get destroyed here in comments for saying something everyone has been saying, but I just think this should still be subject to discussion.

Please join the discussion here: https://www.reddit.com/r/dogecoindev/comments/la1hk3/continuation_of_1674/


[YUNIKORN-1677] move to simple go based web server for e2e tests.

What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - http://yunikorn.apache.org/community/how_to_contribute
What type of PR is it?

[ ] - Bug Fix
[x] - Improvement
[ ] - Feature
[ ] - Documentation
[ ] - Hot Fix
[ ] - Refactoring

Todos

[ ] - Task

What is the Jira issue?

Open an issue on Jira https://issues.apache.org/jira/browse/YUNIKORN/
Put link here, and add [YUNIKORN-Jira number] in PR title, eg. [YUNIKORN-2] Gang scheduling interface parameters

How should this be tested?
Screenshots (if appropriate)
Questions:

[ ] - The licenses files need update.
[ ] - There is breaking changes for older versions.
[ ] - It needs documentation.

Thank you @craigcondit for review, addressed the comments now.


⚠ Bofrost.be has degraded performance

In 702c72a, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1721 ms

Resolved: Bofrost.be performance has improved in 0a50000.


[Feature request] I would like to exclude workspace folders from search when I press Ctrl + P

On a workspace, I would like to exclude workspace folders to find quickly the only file of a folder during the search when I press Ctrl + P. For example:

You can see three files with the same name of different three apps of two folders. I would like to exclude the folder Django so I can click that only file once in a millisecond, I would not need to move my mouse to click gusbemacbe.co.nz folder's file settings.py or would not need to jump three times in few seconds.
The settings files.exclude does not solve because it excludes all three files with the same name. And search.exclude does not exclude that folder Django, maybe because it is a workspace.

It sounds like maybe you want to configure files.exclude for that file just in one workspace folder by setting it in .vscode/settings.json for that workspace

No, I want to exclude the folders from the search.
I have Django and gusbemacbe.co.nz folders added to the workspace, but I need to exclude Django, even if it continues being added to the workspace.

You can configure files.exclude with * (maybe **/*) in that folder to exclude it. Not an elegant solution. You can also type few characters from the folder name that you want to include in the search in quick open to filter to that folder.


Refactor SetupSuite/SetupTest/TearDownTest usage in tests

Refactor how we use SetupSuite, SetupTest, and TearDownTest in our test suites to avoid some repetition for the artifact tests that use bucket storage
Unify the naming of the method used to delete buckets
Split BaseTestSuite setup between SetupSuite (runs once per test suite) and SetupTest (runs once per test)

I have one general question - do we really need such improvement? It seems like Yes and Not. +82 lines and - 93 lines, just -11 lines and all of this changes just for artifacts logic.

I made some additional changes to share more logic between the bucket storage providers, which now makes it look worse in terms of "line changes" 😬 (+179 −173). However I think this will help a lot when we introduce other bucket storage providers, and when we implement artifact proxying (which would introduce quite a few additional test suites).
I'm happy to park it for now if we don't feel like it's useful!

Actually my changes bring more issues than they solve, I'll close this!


Tag new release

@JuliaRegistrator register()

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/1096
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if Julia TagBot is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.2 -m "<description of version>"<PHONE_NUMBER>861cf5210580f45f8431d4544da0e8
git push origin v0.1.2


The structure of early/earlier/later/further on

Could this be something like ago where you have a head preposition that requires modification?

A while ago, we found another example.
Later on, we find another example.
Further on/down/over, we find another example.
A little way on/down/over, we find another example.
*A little way, we find another example.
*On/down/over, we find another example.
A while later/ago/back/after, we found another example.
Later/*Ago/*Back/*After, we found another example.
Later/Further on, we find another example.
Later/*Further, we find another example. [Further is ungrammatical if it means "as we proceeded"; of course grammatical if "furthermore".]
Earlier on, we found another example.
Earlier, we found another example.
Later still, we found another example.
*Still, we found another example. [Ungrammatical unless "still" has a different meaning.]
Further on/down/over/up/away/afield/north, we find another example.
Down/Up/Away/?North/*On/*Over/*Afield, we find another example.
A little way on/down/over/up/away/afield/north, we find another example.
long/#far ago
#long/far back

For the later still example, it seems clear that later is the head and still is a modifier.
For the other cases, I suspect there's a paper to be written. :)
Three days on/in, the experiment was showing no signs of success. Like a little way on etc. It's an extent + direction construction. Neither the extent nor the direction can be omitted.
Earlier on, etc.: the preposition can be omitted, but not "earlier". Arguably this means "earlier" is the head and "on" a complement in the AdvP.
CGEL p. 708 notes: "The complement of from often contains on or onwards (from that time on/onwards)"
Early/late + PP: see also UniversalDependencies/UD_English-EWT#390

With ago, I'm not convinced by the "mandatory modifier" analysis in CGEL. Everywhere else, mandatory dependents are called complements. Clearly ago/hence/back are unlike most prepositions; it seems simple enough to say they have an exceptional (postpositional) order w.r.t. their complement.
"Ago", unlike the others, cannot be premodified by right/just (a moment just before/*ago).
OTOH, I guess we have to consider how this interacts with other constructions. Consider extraction/stranding:

They will get married in a year.
?How long will they get married in?
In how long will they get married?
the amount of time they will get married in
They got married after a year.
?How long did they get married after?
How long after did they get married?
the amount of time they got married after
She was born a year before (they got married).
*How long was she born before (they got married)?
How long before (they got married) was she born?
*the amount of time she was born before (they got married)
They got married a year ago.
*How long did they get married ago?
How long ago did they get married?
*the amount of time they got married ago

In the above cases "X ago" patterns more like "X before" than "in/after X" (where X is the duration).
If we were to go with the CGEL analysis that the duration before "ago" is not a complement, then I would rather treat its function as simply "dependent" as opposed to "modifier".

To be clear, the mandatory modifier analysis is SIEG2's. CGEL and SIEG1 have a pre-head complement analysis.

Oops OK

Why, though, shouldn't shortly work with ago as a modifier?

I am wondering if long is exceptional.
Shortly or significantly can precede before, but not ago. Same with much.
Note also expressions where long occurs where an NP like "a long time" would normally be expected: for long, before long, it won't take long

CGEL p. 574 also looks relevant


Reports: File name clash (pathFormatted) for specific request names

Executing Gatling with the following simulation class reproduces the error:
import io.gatling.core.structure.ScenarioBuilder
import io.gatling.http.request.builder.HttpRequestBuilder

import io.gatling.core.Predef._
import io.gatling.http.Predef._

class FileNameClashExampleSimulation extends Simulation {

  val httpProtocol = http
    .baseUrl("http://computer-database.gatling.io/")
    .doNotTrackHeader("1")
    .acceptLanguageHeader("en-US,en;q=0.5")
    .acceptEncodingHeader("gzip, deflate")

  val request1: HttpRequestBuilder =
    http("Delete:16d8a886-add8-49ec-a481-1b41579256e9")
      .get("/")
  val request2: HttpRequestBuilder =
    http("Delete:bdfd117c-ee42-4572-b07c-a7e79da131ef")
      .get("/")

  val scn: ScenarioBuilder = scenario("Delete")
    .group("Delete") {
      exec(request1).exec(request2)
    }

  setUp(
    scn.inject(atOnceUsers(1))
  ).protocols(httpProtocol)
}

(To make is simpler and easier to reproduce, the above class is based on an official Gatling example, but request naming and grouping are crucial here - that's why an actual "get" is named "Delete")
Running the simulation (and generating the report) results in  stats.json file containing 2 entries with the same pathFormatted:
{
...
path: "Delete / Delete:16d8a886-add8-49ec-a481-1b41579256e9",
pathFormatted: "req_delete---delete-2038e",
...

path: "Delete / Delete:bdfd117c-ee42-4572-b07c-a7e79da131ef",
pathFormatted: "req_delete---delete-2038e",
...
}

The filename (identified by pathFormatted) clash is probably caused by this particular line.
Below is why I think so (pseudocode, based on actual debugging):
toFileName("Delete / Delete:16d8a886-add8-49ec-a481-1b41579256e9") -> "delete---delete-2038e"
toFileName("Delete / Delete:bdfd117c-ee42-4572-b07c-a7e79da131ef") -> "delete---delete-2038e"

Going further:
md5("Delete / Delete:16d8a886-add8-49ec-a481-1b41579256e9") -> "2038e890f5c02e8e3013c509971a5e7d"
md5("Delete / Delete:bdfd117c-ee42-4572-b07c-a7e79da131ef") -> "2038e922d60680ca0ed4e78e087cc2a0"

so taking just first 5 chars of md5 results in a collision in this particular situation.

Thanks for fixing this so quickly!


Explanation of HVAC_ACTION being removed

Describe the bug
I am wondering why the 'HVAC_action' attribute has been removed?
Expected behavior
I expect the 'HVAC_action' attribute to be available.

Since 0.9.1 it seems 'hvac_action' attribute has been removed, with no (in my opinion) good reason. I have seen the Removed climate HVAC_ACTION to respect HA climate entity rules changelog entry, but find it strange that removing information is seen as a good thing. Especially when that extra information doesnt 'get in the way' or 'hurt' users who weren't/aren't using it anyway.
I've noticed a few integrations having to change things (usually not for the better) to fit in with some silly rules/specifications. I understand the need for consistency, and certain attributes should be mandatory for a device class, but removing extra information seems daft to me. Is there something I am missing?

Just did a quick search, and it seems there is no issue with HVAC_ACTION being allowed..
https://developers.home-assistant.io/docs/core/entity/climate/

In Home Assistant HVAC_ACTION should represent "what device is doing" and should be used if is different from HVAC_MODE, for example the device mode is COOL  but the action is IDLE because target temperature is reached, then could change in action COOLING again when temperature go over target.
LG API do not allow to identify current action, so at the end HVAC_ACTION would be only a mirror of the HVAC_MODE, for this reason I removed this following HA dev guideline and because in my opinion it make sense.
So my question is: why you need this information if it is identical to HVAC_MODE?

The information isn't identical though, it's different ('cool' vs 'cooling' etc) and I was using it in automations. I am aware I could create a template etc to add this functionality back, but I see it as a bad move to provide less data. I think any data we can get from the LG API should be accessible to end users, as there is no telling what weird and wonderful things people can do with that data.

The information isn't identical though, it's different ('cool' vs 'cooling' etc) and I was using it in automations

Just different word, not different device status. You can base your automation on HVAC_MODE and obtain identical results.

I think any data we can get from the LG API should be accessible to end users

And that's what I try to do. But LG API do not provide information about HVAC_ACTION. But if one day this information will be available, I will be happy to manage it.

Close this issue, thing that the question has been answered.


Add IceServer and use it in Configuration

This PR adds support to username and password, thus TURN (#16). A relay candidate was found by adding a TURN server with this update so I think it's working!

Thanks!


rename args in CmdFunctions to be consistent with existing CLI arg naming conventions in pulsar

Motivation
Currently the CLI arg naming conventions is not consistent with that of the rest of Pulsar cli args
Modifications
Rename args to use dashes to separate words instead of camel case.  Kept existing cli args for backwards compatibility purposes and hid them
Will also do this for CmdSink and CmdSource when everyone is on board with is change

rerun integration tests

rerun cpp tests


Client for getting a specific task with header updates

What

Client for endpoint /jobs/{id}/tasks/{taskname}
response header updates for eTag functionality
swagger doc updates

How to review

code sense check
CI pass

Who can review

Anyone

I've just noticed that the ETag is currently being returned in the body but not in the header of the /jobs//tasks endpoint. This means that when the PostTasksCount function tries to get the  header named "ETag" (in line 115 of sdk/v1/client.go) it will not find any header with that name.


Subnet delegation

Content around Subnet Delegation is very thin. There's a brief summary, but no real explanation of what this feature does or guides on how to use it.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b8332806-35c4-26e5-56e6-0286d728ad45
Version Independent ID: ce76cee4-5629-7439-309c-9b9705891b57
Content: Add, change, or delete an Azure virtual network subnet
Content Source: articles/virtual-network/virtual-network-manage-subnet.md
Service: virtual-network
GitHub Login: @jimdial
Microsoft Alias: jdial

@jtuliani Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

Hi @jtuliani Thanks for your patience. I'm sending a request to the subject matter expert now.

Thanks for the feedback, we'll work on adding content to better describe the functionality.

Hi @jtuliani
Mario has a backlog item for this content now, but my guess is it will not get in until the new year. I'm going to request that this issue be closed, but comment in it with any questions.
#please-close
@TravisCragg-MSFT

@jtuliani We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.

@TravisCragg-MSFT There seems to be no way to remove a delegation from a subnet using the CLI:
az network vnet subnet update -g vnetResourceGroupName --vnet-name vnetName --name subnetName --delegations ''
az network vnet subnet update: error: argument --delegations: expected at least one argument
az network vnet subnet update -g vnetResourceGroupName --vnet-name vnetName --name subnetName --delegations ' '
The service name   specified on delegation /subscriptions/subscriptionIDgoeshere/resourceGroups/ReG_Network_NL-Amsterdam-2_001/providers/Microsoft.Network/virtualNetworks/VNet_NL-Amsterdam-2_Strategic-IT-Services-D_001/subnets/Cont-Access_D-9_None/delegations/0 is not valid. Valid value(s) are: Microsoft.Web/serverFarms,Microsoft.Sql/servers,Microsoft.ContainerInstance/containerGroups,Microsoft.Netapp/volumes,Microsoft.HardwareSecurityModules/dedicatedHSMs,Microsoft.ServiceFabricMesh/networks,Microsoft.Logic/integrationServiceEnvironments,Microsoft.Batch/batchAccounts,Microsoft.Sql/managedInstances,Microsoft.Web/hostingEnvironments,Microsoft.BareMetal/CrayServers,Microsoft.BareMetal/MonitoringServers.
Why was I trying to do this? I am trying to remove the delegation to ACI (Microsoft.ContainerInstance/containerGroups), and selecting "None" in the Portal throws this error:
Failed to save subnet 'subnetName'. Error: 'Subnet vnetResourceGroup/providers/Microsoft.Network/virtualNetworks/vnetName/subnets/subnetName'>vnetName/subnetName requires any of the following delegation(s) [Microsoft.ContainerInstance/containerGroups] to reference service association link /subscriptions/subscriptionIDgoeshere/resourceGroups/vnetResourceGroup/providers/Microsoft.Network/virtualNetworks/vnetName/subnets/subnetName/serviceAssociationLinks/acisal.'

@amandadebler I am able to add and remove subnet delegation without an issue on a test environment. this is likely failing due to your Service Association Link named "acisal".
A Service Association Link is part of your AKS deployment, and that will likely need to be removed first.

@TravisCragg-MSFT I think it might be a problem with the "az aks disable-addons --addons virtual-node" operation, which appeared to be successful in the CLI, but didn't actually remove the virtual node or change the subnet.
What is the correct Azure CLI expression for removing a subnet delegation? Removing a Service Association Link, or does that have to be initialized by the service in question?
Virtual nodes for AKS: https://docs.microsoft.com/en-us/azure/aks/virtual-nodes-cli
My report on this: https://github.com/MicrosoftDocs/azure-docs/issues/25771


proxy: Support unix sockets

Resolves #4167

Code looks good to me but can we add some system tests? We already have tests for tcp, so adding unix socket should be pretty straight forward.

I added tests for unix <-> unix, tcp <-> unix, and unix <-> tcp.

@monstermunchkin, see the discussion on IRC and:

https://paste.ubuntu.com/p/pfRQ9q8rk5/
https://paste.ubuntu.com/p/Rp5kX257y4/

@brauner can you take over this branch given that @monstermunchkin will be away for a bit?

On Mon, Jun 04, 2018 at 09:56:44PM -0700, Stéphane Graber wrote:

@brauner can you take over this branch given that @monstermunchkin will be away for a bit?

yes

Go 1.5 gets us:
# github.com/lxc/lxd/shared
/lxc-ci/build/tmp.90DKZYe20o/tmp/go-build702230250/github.com/lxc/lxd/shared/_obj/_cgo_main.o:(.data.rel+0x0): undefined reference to `NULL'
collect2: error: ld returned 1 exit status

Not sure what's that referring to exactly....

Why do we care about go 1.5?

Ah, you likely meant go 1.9. :)

jenkins: test this please

Closing this and opening a a new PR. This one has gotten messy.


move file refactoring doesn't work with network folder

clone https://github.com/microsoft/pylance-release/tree/main/testing/single
create a network folder NetworkFolder to the single folder
open //NetworkFolder/single in vscode
follow instructions on https://github.com/microsoft/pylance-release/blob/main/testing/single/src/moveFile.py

expected:
file is moved and all references to it is updated.
actual:
nothing happens.
...
it also repro with 2023.12.1 so, not a regression. but it works fine with regular folder.

This looks like a duplicate of #5399 which I have a fix for. But I'm confused about why #5399 says it's a regression from 2023.12.1 and this one says it's not a regression.

no idea. path given by move file from vsocde and move symbol from us might use different path casing? since move file, path comes from vscode, and move symbol uses path we have in program (decl)? and path in decl could either from LSP request or our file system

Oh, I missed the "move file" vs. "move symbol" difference. This is not a dupe. The behavior is better with my fix for #5399, in that the rename preview is available, and when the rename is applied the import in renameByModule.py gets updated, but moveFile.py is not actually moved. We show "Moving moveFile.py" in the status bar with spinning arrows for about a minute and then this message box appears:

it works as expected with @debonte 's change. I am not getting the permission issue. his share might not have full permission such as creating a file but just have changing content.


vector<future > does not work gracefully with dataflow, when_all and unwrapped

// Assume these definitions throughout:
hpx::future<boost::uint64_t> T;
std::vector<hpx::future<double> > U;

// I want to be able to use vectors of futures as arguments to my continuations;
// the vectors of futures will not be the only arguments, however. This does not
// seem to work with HPX currently.

// cfl0; HPX-free call signature. Enables the use of existing "local" kernels
// (e.g. small grains of work which are highly optimized - stuff that we don't
// want to break down into smaller chunks). Facilitates integration with legacy
// code without interface changes; this is an important point for large, existing
// codebases.
double cfl0(boost::uint64_t step, std::vector<double> u)

// cfl1; Call signature I am currently able to use with when_all d
double cfl1(boost::uint64_t step, std::vector<hpx::future<double> > U);

// Won't compile; when_all/dataflow do not take vectors of futures for the tuple
// call signature. You can pass a vector of futures if it is the only argument;
// otherwise things seem to break.
when_all(step, u);
dataflow(unwrapped(cfl0, step, u);

// Won't work; the second argumenet passed to the continuation is a vector
// of futures, not a vector of values.
when_all(step, when_all(u)).then(unwrapped(cfl0));
dataflow(unwrapped(cfl0), when_all(u));

// Won't work; the 'step' argument needs 1 level of unwrapping, and the 'U'
// argument needs 2 levels of unwrapping. unwrapped() does not support
// mixed levels of unwrapping.
when_all(step, when_all(u)).then(unwrapped2(cfl0));
dataflow(unwrapped2(cfl0), step, when_all(u));

// Works. Ugly. Forces me to use the cfl1 call signature (or write another
// wrapper - but that would be redundant since we have unwrapped). The
// cfl1 signature is not acceptable, because it has an hpx::future in it; it is
// not an "HPX free" call signture.
when_all(step, when_all(u)).then(unwrapped(cfl1));
dataflow(unwrapped(cfl1), step, when_all(u));

// Another major limitation; we only take std::vectors. Why not std::list, or
// arbitrary Containers. I feel like perhaps we need to go the Spirit route, to
// some degree; we need a (much simpler) attribute grammar, which
// supports nested futures and containers of futures.

Moving this to the next milestone. This requires more discussions and decision making before it can be fixed.

Is there something to be done here now that #2741 and #2829 are merged?

I think we can close this as the issue has been addressed by #2829.


[CT-930] dbt snapshot works with click

Resolved by https://github.com/dbt-labs/dbt-core/pull/6640


Adding SchemaGroup to EventHub resource model

This is a test PR on adding SchemaCollection to Eventhub resource model.

/azp run automation - sdk

Can one of the admins verify this patch?

@hmlam Please fix the referencing failure in CI

/azp run automation - sdk

/azp run automation - sdk

Please take a look at the questions I added.

@hmlam Any update on this PR?

The feature is now going to be in public preview milestone, so I think I will abort this one (that modify the stable version) and open a PR that modify the preview spec.

Hi, @hmlam. The PR has be closed for a long time and it's related branch still exist. If no further used for over 14 days, I will delete this related branch. Please tell me if you still need this branch.

Hi, @hmlam. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.


Missing link to INSTALL on homepage

I am trying to install Gleam and there is no link to the Installing Gleam on the homepage.
I think an "INSTALL"  in the top menu will work as it will be available throughout the website.

Hello! We will do something like this once the installation section has been overhauled. Thank your


Support for OpenTelemetry

Feature Description
OpenTelemetry is an open standard designed to unify signals coming from an application. It allows for tracing requests and operations, sending logs from the application and gathering and sending prometheus metrics.
Potentially it would allow for removing prometheus in favor of opentelemetry (go library does have setting for prometheus style endpoint though I've yet to test it) and having the option to find long running operations quicker with tracing.
I'd like to work on this (though it might take a while) and I have a "demo" of such integration here, with only tracing support.
Screenshots
No response

Please have more discussion here before proposing a pull request.
Traditionally, I would like to collect logs from the disk log file rather than sending logs to the remote directly. I haven't read all the documentation of OpenTelemetry but I want to know how it works for logs.

I think it needs more discussion.
If there is a chance, I'd like to totally decouple the 3rd dependency to avoid bloat Gitea binary.
There are various "tracing" or other tools and there will be more, if we added this, then should or shouldn't we add others?
So before starting the work, I'd like to clarify:

Does it really help to trace the useful metrics and resolve real world problems?
Is it to decouple the dependency, for example: make Gitea just outputs some JSON logs and use log collector to send them to other tools?

Thank you for the details. I also have some experiences for "app performance tracing" (I used to build a web app serving millions of user per day and the QPS is around thousands), I also used some tracing tools and built some tracing frameworks, so I could fully agree with the ideas behind OpenTelemetry.
I also used GitLab for long time, GitLab packed a whole grafana into their deployment, and they have their own diagnosis tools.
So if let me design a roadmap for Gitea, I think the key problem is how to benefit most end users if we introduce a new mechanism.

Gitea indeed needs some mechanisms to help to diagnose performance problems

I can see there are still many performance related problems
At the moment there is no easy way to figure out the root problems
Performance tracing needs a lot of work, for example, add some necessary tracer calls correctly.

At the moment, Gitea is not like GitLab

GitLab always requires users to setup a lot of services to run, so it's not surprising that they could pack grafana into its package.
But Gitea is designed to be a lightweight system (almost zero dependency), so if we introduce the OpenTelemetry dependency but end users couldn't use it out-of-box, I think it departs from Gitea's goals.
I do not think it is feasible to tell end users that "please install other softwares to report the performance problem".

Then the question is: how to satisfy these requirements? Gitea needs tracing tools, and end users need to report performance problems conveniently. In my mind, the roadmap could be like this:

Refactor Gitea's code first, to make it have basic "signals" support, and we need to make end users could report without external dependency (unless we change our mind now and make end users always deploy Gitea with a complex docker container which contains everything)
Add shim interfaces to the "signals" support
If some advanced users would like to use OpenTelemetry or something similar, they could use the "interfaces" to build their own instance.
If one day, Gitea is not lightweight anymore and must be deployed like GitLab, then we can integrate everything into one container.

After 1.23 gets a stable release (maybe in 1 or 2 weeks), I think we could start some initial work for the performance tracing. Then we could try to get OpenTelemetry support, either source-code-level optional (build from source code/tag), or config-level optional (enable by config option), or mandatory.

I started some initial work here: https://github.com/wxiaoguang/gitea/commit/8e615fe1f484a141cee565274f327b1f9b3bdcc9
Quite simple, it introduces our shim-layer and builtin tracer. The interface is designed to be OpenTelemetry-like.
Will try to do some improvements and make it really work before proposing a PR: the real challenge is how to correctly trace the performance problems (especially in the db and git package). Maybe it would take about one week.

Hmm ... it seems somewhat cumbersome to add a lot of ctx, span := tracer.Start(repo.Ctx, "CommitTree"). I think I could have some ideas about how to improve it. At least, by my recent " Refactor pprof labels and process desc #32909 ", git.Command.Run is able to know its caller.
ps: I am still working on some refactoring PRs, I think we could have enough preparation first, then the following work could be easier.

Thank you for this issue. As for the related code you linked to, due to its licensing, I have a personal policy of not looking at that repo to ensure that I don't violate any of the licenses.
It's funny that you opened this issue, as a part of some performance work, and some chance encounters with some folks from honeycomb, I have been investigating this for some time, and have some (less than stellar) code that I put together as a proof of concept to show that it could be done. I've pushed my code, so that others can also look at it too, and perhaps get this in.
I share the same feelings as @wxiaoguang about the cumbersome boilerplate of wrapping many things with tracer.start/etc.., but sadly, other than some ebpf auto-profiling things that exist for otel, that seems to be the approach for adding otel to golang programs. Thankfully the two libraries I've chosen for middleware for db & HTTP, alleviate that. Sadly, for our git module we are likely to have to do the wrapping ourselves.

I am still working on some preparations, so please review and approve my recent refactoring PRs, then we will have the builtin performance tracer soon. Then, at least, advanced users could introduce their tracers from source code level.

Sadly, for our git module we are likely to have to do the wrapping ourselves.

If you read my recent PRs, then you could know that: no sad, no need. I have a complete design to make the system right and light, but I need to do some refactorings first.

I have pushed my work for "builtin tracer":  WIP: Support performance trace #32973 .
It has initial http/db/git support, and a simple list in admin UI

@TheFox0x7 thanks! I'll checkout your code in the link above. I'm sure your statement here is sufficient, and enough people get emails from this tracker that there is some record of your statement should something catastrophic happen to GitHub (knock on wood it doesn't).
@wxiaoguang thanks! I hadn't checked out your code yet. The code in my PR was stashed in my local repo for a while and figured it'd be better to push it up since it can be added to this discussion.

First thing, circling back a bit - why not implement SpanExporter interface as internal backend?

Sorry but I didn't get the point .... could you elaborate?
I think our shim-layer won't implement any "real" OpenTelemetry interfaces, because the OpenTelemetry's interfaces have quite heavy and complex dependencies. So by current design, users could implement the "traceStarter" and register it to operate on the spans directly.
If you think "SpanExporter" is useful, could you provide some pseudocode to describe how to use it?

In my mind the otel integration could be like this:

type traceOtelStarter struct{}

type traceOtelSpan struct {
	otelSpan otel.Span
}

func (t *traceBuiltinSpan) end() {
	t.otelSpan.End()
}

func (t *traceBuiltinStarter) start(ctx context.Context, traceSpan *TraceSpan, internalSpanIdx int) (context.Context, traceSpanInternal) {
	ctx, span := tracer.Start(ctx, traceSpan.name)
	return ctx, &traceBuiltinSpan{ts: traceSpan, otelSpan: span}
}

func init() {
	globalTraceStarters = append(globalTraceStarters, &traceOtelStarter{})
}


Guesser can crash on inaccurate rounding

In the rounding in for linear_lookup, this line can crash with an InexactError:
https://github.com/SciML/FindFirstFunctions.jl/blob/9f69a2d0779410cd58e20cf7396c4a9ffea86448/src/FindFirstFunctions.jl#L243
This is presumably if the second argument float is too big to be rounded to any particular integer given its precision. I propose falling back to idx_prev[] in this case.

Would it make sense to use typemax (maybe typemin, respectively) or lastindex in that case instead?

Ah that makes sense


Fix for component testing

Hi!
If someone will test VueVirtualDragList in component test using e.g. Vitest then this line will fail -> https://github.com/mfuu/sortable-dnd/blob/ab5f10b74733f5184f269d20cc63d87aa5669c19/src/utils.js#L52
because pre=undefined
For me it works when I add some default (webkit at last line)
  const pre = (Array.prototype.slice
    .call(styles)
    .join('')
    .match(/-(moz|webkit|ms)-/) ||
    (styles.OLink === '' && ['', 'o']))[1] || 'webkit';

So I'm thinking about how to handle it because otherwise it isn't possible to test components that use this library under the hood. WDYT?

This issue has been resolved in version 0.6.10 and later.


Splitting left or right changes line-height

When I try to split a window right or left, the line-height for my terminal windows gets all messed up (http://dsh.re/8f28d). Works fine if I only split up or down.

Can you confirm that when you resize just a little Atom, everything get back to normal ?

Actually things seem to be working pretty much normal now, it just happens when I initially split the screen.

Yeah spilt doesn't trigger the right resize event. Dup of #113


[harvester node driver] user can't provision rke1 cluster, node is stuck in exit 0 loop

Rancher Server Setup

Rancher version:v2.6-head(06e19b0)
Installation option (Docker install/Helm Chart):docker

If Helm Chart, Kubernetes Cluster and version (RKE1, RKE2, k3s, EKS, etc):

Proxy/Cert Details:n/a

Information about the Cluster

Kubernetes version:v1.21.5-rancher1-1
Cluster Type (Local/Downstream):downstream

If downstream, what type of cluster? (Custom/Imported or specify provider for Hosted/Infrastructure Provider): harvester node driver

Describe the bug

user can't provision rke1 cluster using harvester node driver

To Reproduce

create harvester setup
import harvester into rancher via virtualization management
enable harvester node driver
use harvester node driver to provision single node (all roles) rke1 cluster

Result
node in exit 0 status for 30 minutes, deletes the node, and all future nodes have the same issue. occasionally will show this error message for ~1 second:

Expected Result

harvester node driver should be able to provision an rke1 cluster
Screenshots

Additional context

rke2 is working with the same settings

there is no option for harvester cloud provider in rke1, so this is the only difference I could spot

I cannot reproduce the issue in Rancher v2.6.1-rc5 and Harvester v0.3.0-rc1. @slickwarren Can you re-test?

on 2.6.1-rc5 using harvester 0.3.0-rc1:

rke1 deployment is working (single node, all roles)
rke1 deployment dedicated role-per-node -- also working as expected


Villager trading (WIP)

Allowing the bot to trade with villagers.
This seems to already be a thing in mineflayer but was not implimented to mindcraft: trader.js from mineflayer repo
added the !trade command (WIP)
added the !showtrades command
added the !showVillagers command.
 Looking into improving it. Currently it does not trade even if it has the resources. If anyone can fix it I would appreciate it but I will look into it soon.

looks good 👍

I know this is wip but a couple suggestions:

remove the !showVillagers command and include your villagers list in the !entities command
make sure your indentation is with 4 spaces, not 2

I might just close this because I can't figure out how to fix the errors. Unless anyone else wants to work on it?

I'm 90% sure it's a plug in issue


Setup first pipeline for repo

This MR is a bit cheeky and does several things

Reorganizes the repo so theres no unnecessary "electionReminders" folder
Sets up a pipeline to run prettier on new merge questions and pushes to main.


V3 SDK with bulk execution performs worse than V2 SDK using BulkExecutor

Describe the bug
When upserting documents to a manual throughput container, the V3 .NET SDK performs consistently worse than the V2 SDK using the bulk executor.
Not only is it slower, but it also frequently throws a CosmosException with the status code TooManyRequests.
To Reproduce
See this minimalistic sample project.
Run it while running the cosmos DB emulator with rate limiting enabled. The sample project will create a test database and container.
Alternatively, change the accountEndpoint and accountKey to point at a live cosmos account, and observe the same behavior.
Expected behavior
I would expect the V3 SDK to perform at least as well as the V2 SDK.
Actual behavior
The V3 SDK is slower, and often throws a CosmosException with the status code TooManyRequests.
Environment summary
SDK Version: 3.35.3
OS Version: Windows 11

Hi @gonzaleznicolas,
I have two questions glancing at your sample code.

What is the intent of using Parallel.ForEach when "enqueueing" the async tasks? This kind of creates an artificial lock contention - the call to UpsertItemAsync because not awaited is synchronous without any I/O operations and will be very quick. Usually I would expect the "enqueueing" of the async tasks to haven sequentially on a single thread into a List that doesn't need to be any of the Concurrent lists - will avoid the lock contention and the Parallel.ForEach won't help you much anyway.

Usually when doing bulk processing the 429-retry policy gets configured to retry forever - the main goal of bulk is to saturate the throughput - so, throttling from the backend is kind of wanted - and so, allowing retries longer than the default policy of at most 9 retires in at most 30 seconds is often preferred. You can change the max. retry attempts to a higher number here - https://github.com/Azure/azure-cosmos-dotnet-v3/blob/391c3d9872aff6615c00dffaa313aaa7013b69a0/Microsoft.Azure.Cosmos/src/CosmosClientOptions.cs#L282-L332

Last comment - usage of bulk really is an improvement to keep saturating the provisioned throughput (RU/s) - when just updating very small number of documents, bulk can result in higher latency. The background is that in bulk mode the client will enqueue updates per physical partition and only send them to the backend in a bulk request after 100ms - or when the number of documents reaches a certain size. So, when you update very small number of documents in Bulk mode, the latency might actually be a bit higher. Bulk Mode is meant to optimize for throughput - not best latency when doing point operations or update very small number of documents.

This is also summarized here: https://learn.microsoft.com/en-us/azure/cosmos-db/nosql/how-to-migrate-from-bulk-executor-library

Hi @FabianMeiswinkel. Thank you for your prompt reply.
I have addressed your recommendations on the updated repository.
Regarding the Parallel.ForEach, I removed it.
Regarding the retry policy, I did what you suggested and increased the MaxRetryAttemptsOnRateLimitedRequests, and MaxRetryWaitTimeOnRateLimitedRequests. That solved the "TooManyRequests" cosmos exception. It is no longer thrown.
However, the V3 SDK still takes consistently longer than the S2 SDK to perform the exact same upsert operation.
To address your last point, I increased the number of documents significantly (and also the provisioned throughput of the container). I did this so that we are no longer talking about a "very small number of documents". And still, I see the V3 SDK taking about twice as long as the V2 SDK to perform the bulk upsert.
I also tried setting the V3 SDK to "AllowBulkExecution = false" (with the smaller amount of documents), but that made it even slower.
As an experiment, I set the container's throughput to autoscale. In this scenario, the V3 SDK does perform very well. Which is in line with your statement that "usage of bulk really is an improvement to keep saturating the provisioned throughput (RU/s)".
However, what I need is to upsert the documents that I need to upsert as quickly as possible with the manually provisioned throughput of my container. And it seems that the V2 BulkExecutor does a much better job of throttling itself than the V3 SDK. So is that something that the V3 SDK is just not capable of? Or do you have any further suggestions?


Unable to bind to IPV6 address

When I'm trying to bind a publish socket on ipv6 as following:
import zmq
c = zmq.Context()
s = c.socket(zmq.PUB)
s.bind('tcp://[2602:ff96:9::9dce:3092]:5060')

I got the follow error:
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "zmq/backend/cython/socket.pyx", line 444, in zmq.backend.cython.socket.Socket.bind (zmq/backend/cython/socket.c:4089)
  File "zmq/backend/cython/checkrc.pxd", line 21, in zmq.backend.cython.checkrc._check_rc (zmq/backend/cython/socket.c:6248)
zmq.error.ZMQError: No such device

How can I solve this? Thanks a lot!

Sorry, I should have found the solution myself. The answer is that I need:
c.setsockopt(zmq.IPV6,1)

Glad you got it! I'm not sure why this isn't enabled by default in libzmq.


DP-1.4 : Adding deviation for scheduler commit

DP-1.4 : Adding deviation for scheduler commit

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 56.211%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1181

Relevant Lines:
2101

💛  - Coveralls

/gcbrun


Add labels to fetch package

Closes #425

I added the request method in the labels and changed the naming scheme a bit, thinking we might adopt this naming scheme in other places (such as @effection/process) as well?


OSSM-1442: IOR: Ignore UPDATE events if resourceVersions are the same

For some obscure reason, it looks like we may receive UPDATE events with
the new object being equal to the old one. As IOR always delete and
recreate routes when receiving an UPDATE event, this might lead to some
service downtime, given for a few moments the route will not exist.
We guard against this behavior by comparing the resourceVersion field
of the new object and the one stored in the Route object.

/test unit

/retest

For some obscure reason, it looks like we may receive UPDATE events with the new object being equal to the old one.

Could this be caused by xns-informer? If so, we may have similar issues elsewhere.

I don't know. @rcernich suggested that this could possible indeed.
The problem with this PR is that we don't enforce the desired state upon an UPDATE event if the object's resourceVersion is the same as the one we have in memory. Quoting Rob:

... the reconciler should force the managed resource to match the desired state, so if we get an update request for a Gateway, we should still verify that the created Route reflects the desired state (e.g. the user hasn't modified the Route)

One possible fix to this is to add a second level comparison: If the objects are the same, perform an get() request on the OCP API just to make sure the object wasn't modified. This has the disadvantage of performing an API request, which could be too much at some point. A solution for this would be using a cache store, but this requires a bigger refactor of the IOR code.
Comments?

/retest

@luksa, are you saying that xns-informer is not generating the correct event types for resyncs?

I spent some time looking at this and the error logs mentioned in the issue. I believe it might be caused by a reconnect in the reflector. But let me explain:

just before the UPDATE events come in, our leader election lock logs: error retrieving resource lock servicemesh/ior-leader: etcdserver: leader changed - it doesn't report that it lost leadership, though, so this is just the result of a period check if we're still the leader. one of those checks has failed because etcd leader changed.
Likely, our WATCH on Routes is also dropped as a result of that etcd leader change, forcing the reflector to resync
The reflector will re-list all resources from the last known resourceVersion, causing these UPDATE events

I'm not entirely sure if that's the cause, but if it is, then the method of comparing resourceVersion makes sense and is a viable fix. I will ask the customer for more debug logs

/test unit

/retest


Remove deprecated adapterPosition

From RecyclerView's documentation:
        /**
         * @return {@link #getBindingAdapterPosition()}
         * @deprecated This method is confusing when adapters nest other adapters.
         * If you are calling this in the context of an Adapter, you probably want to call
         * {@link #getBindingAdapterPosition()} or if you want the position as {@link RecyclerView}
         * sees it, you should call {@link #getAbsoluteAdapterPosition()}.
         */

        @Deprecated
        public final int getAdapterPosition() {
            return getBindingAdapterPosition();
        }

This PR replaces getAdapterPosition with getBindingAdapterPosition.

It's been nice seeing this method go from getPosition() to getAdapterPosition() and now getBindingAdapterPosition(). Can't wait till it changes to getUltimatePositionInTheAdapter() 😆

Thank you for contributing!


CMakeLists.txt doesn't support installing the library

Describe the bug
CMakeLists.txt is only compatible with use via FetchContent, not with the default idiomatic method of installing the package.
Additional context
Read about CMake installation support, for example, here.

@eyalroz Thanks for bringing this up. Didn't realize this problem before.
Filed https://github.com/BowenFu/matchit.cpp/pull/77 to fix this.


[DOC] Missing link to R DataFrame API doc

Merged build triggered.

Merged build started.

Test build #44749 has started for PR 9394 at commit 2361e6e.

Test build #44749 has finished for PR 9394 at commit 2361e6e.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n  *         logInfo(s\"Hive class not found $e\")\n  *         logDebug(\"Hive class not found\", e)\n

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44749/
Test PASSed.

@shivaram

On this note can we update the roxygen doc for DataFrames ? http://spark.apache.org/docs/latest/api/R/DataFrame.html seems pretty incomplete.

why don't we point to http://spark.apache.org/docs/latest/sparkr.html for now instead?

@felixb Other docs for Scala, Java and Python toward API documents. So I thought it might be better to make it indicate toward http://spark.apache.org/docs/latest/api/R/DataFrame.html too.

Yeah but the DataFrame.html doesn't seem very useful the way it is right now -- can you just update the roxygen docs in this PR as well ?

@shivaram Sure. I'll submit.

Merged build triggered.

Merged build started.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44871/
Test FAILed.

This failure does not seem to be related to the patch.

Jenkins, retest this please

Merged build triggered.

Merged build started.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44878/
Test FAILed.

Jenkins, retest this please

Merged build triggered.

Merged build started.

Test build #44880 has started for PR 9394 at commit 0a29085.

Test build #44880 has finished for PR 9394 at commit 0a29085.

This patch fails some tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44880/
Test FAILed.

Merged build finished. Test FAILed.

I think this error is related
First time using roxygen2 4.0. Upgrading automatically...
Error: Failure in roxygen block beginning DataFrame.R:23
Mismatched braces: "@seealso \{createDataFrame}, \link{jsonFile}, \link{table}"
Execution halted

it should be @seealso \link{createDataFrame}

Merged build triggered.

Merged build started.

Test build #44896 has started for PR 9394 at commit 0607334.

Test build #44896 has finished for PR 9394 at commit 0607334.

This patch fails some tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44896/
Test FAILed.

The latest error is
Error: Failure in roxygen block beginning DataFrame.R:23
@export may only span a single line

@Lewuathe you can verify this locally using ./R/create-docs.sh before submitting to Jenkins

@shagunsodhani Thank you But that error was not occurred on local.
Anyway I can update it.

Merged build triggered.

Merged build started.

Test build #44903 has started for PR 9394 at commit 818b34f.

Test build #44903 has finished for PR 9394 at commit 818b34f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44903/
Test PASSed.

Thanks @Lewuathe -- LGTM. This is good to go if you can revert the change to the DESCRIPTION file.

Merged build triggered.

Merged build started.

Test build #44976 has started for PR 9394 at commit 12f3a74.

Test build #44976 has finished for PR 9394 at commit 12f3a74.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44976/
Test PASSed.

Thanks again. Merging this

@felixcheung  @shivaram Thank you so much!


Adopt http\type\dictionary from cadl ranch

Adopt https://github.com/Azure/cadl-ranch/tree/main/packages/cadl-ranch-specs/http/type/dictionary

Fix: https://github.com/microsoft/typespec/issues/4210


[DONT MERGE] Kafka POC

Related Issue
https://issues.redhat.com/browse/ACM-6555
Description of changes

POC using kafka
Indexer PR: https://github.com/stolostron/search-indexer/pull/106

/test all


Remove the use of HasFactory trait from RequestResponseLog Model class

The trait Illuminate\Database\Eloquent\Factories\HasFactory has been introduced in Laravel v8. It does not exist in Laravel v7.

Good point - made this change. See v1.1.0


Minor changes for "official" release

This PR follows discussions here, here and here, plus a couple via email.
I did not change what is needed for a new release (like bumping the version in setup.py), but I already ran all the clts stuff which are needed for regenerating the data.
In detail, the changes are:

Removed the conflicting diacritics for rounded/more-rounded and unrounded/less-rounded; only those related to the rounding feature are now used, as per IPA, further changes in terms of compression, protrusion, labialization of consonants, etc. are postponed to the next version

Added a normalization for ɝ

Implemented @LinguList solution for the bug of tones on vowels not properly handled (#96)

Added all the linguolabials that someone might require, which includes all of those on Wikipedia (even the one from Coatlán Zapotec described as "mimesis for a pig drinking water")

Added the code by @LinguList that allows to generate dataset statistics from the command-line (clts dstats)

Thanks, I'd say this is okay, feel free to merge.


Doc Question

Hi, I'm wondering if you happen to know where someone can find a doc of the play.eslgaming api?

sorry, I don't know


Clarify git install instructions

Here's a patch which clarifies the git install instructions:
diff --git README.md README.md
index 7a109aa..712b138 100644
--- README.md
+++ README.md
@@ -125,10 +125,10 @@ Homebrew installation is not supported. If you have issues with homebrew-install

 If you have `git` installed (requires git v1.7+):

-1. clone this repo in the root of your user profile
+\1. clone this repo in the root of your user profile
   - `cd ~/` from anywhere then `git clone https://github.com/creationix/nvm.git .nvm`
-1. check out the latest version with `git checkout v0.33.5`
-1. activate nvm by sourcing it from your shell
+\2. `cd ~/.nvm` and check out the latest version with `git checkout v0.33.5`
+\3. activate nvm by sourcing it from your shell: `source nvm.sh`

 Now add these lines to your `~/.bashrc`, `~/.profile`, or `~/.zshrc` file to have it automatically sourced upon login:
 (you may have to add to more than one of the above files)

Thanks, would you mind making a PR so I can review it that way?

Sorry, I don't have push permissions on this repo.

@belandJibo the typical way it's done is to fork the repo, make the change on a branch on your fork, and make the pull request from there.

That seems like a waste of space and time for a three-line documentation change that can be plainly read above, but here you go: https://github.com/creationix/nvm/pull/1636

Thanks!


kill-back-to-indentation doesn't work right

kill-back-to-indentation in init-editing-utils file doesn't work right for me. It will delete the whole line when I using C-M- or M-x kill-back-to-indentation.

Weird - it works perfectly for me. Can you provide steps to reproduce, please?

I picked some dot el file in lisp directory for myself in emacs configuration. Function named kill-back-to-indentation is provided by init-editing-utils.
I write hahah[some whitespace], and then invoke this function. It kills the whole line.
Emacs version: GNU Emacs 26.1

Please show us how your line is indented during your test.

Could the docstring be slightly ambiguous. It says "Kill from point back to the first non-whitespace character on the line".  This could mean (in a left-to-right language like Lisp) kill back to the leftmost non-whitespace char or kill back to the rightmost non-whitespace char. It actually kills back to the leftmost. In context with the name of the function it is not ambiguous, but a little tricky to read.
I can't suggest an improvement at the moment: sometimes English is more difficult than code.

In line 4 of the following code, the indentation is column 3 (the letter 'd' is the first non-whitespace character in the line.) So the command kills everything between column 3 and point.
# a class
class Foo
  # a method
  def bar
  end
end

Animation below:

Oh I see. thanks for you help. I misunderstand this function. It works right!

Yep, it's perhaps not super clear. This function uses the built-in "back-to-indentation" command, which uses the same "first non-whitespace character on the line" phrase, so I probably copied the wording from there.


Assets folder's structure

When an inspector project is initialized, create an assets folder.
Inside the assets folder create a folder with name identical to project's name. It is the default asset package.
main.composite should be placed in the default asset package's folder.
In asset inspector's folder tree, do not show "File System" and "assets", display only the folder of default asset package.
Imported builder's assets should be placed in assets/builder folder.

Related to https://github.com/decentraland/sdk/issues/708


Live Webkit window OSX

I was not able to get this running on OSX using the command on https://splash.readthedocs.io/en/stable/kernel.html#live-webkit-window Maybe they are different on OSX (and I have tried some other from the Internet), but it never worked.
Is there anyone who has this working? I would be great to be able to interact with Splash while it's running.

Could you please close this issue and report it on https://github.com/scrapinghub/splash?


HDDS-9802. Tool to fix corrupted snapshot chain

What changes were proposed in this pull request?
In the past, we have seen many instances (HDDS-8530, HDDS-8832, and recently HDDS-10524) when SnapshotChain corruption was causing OM to get stuck on restart. Lots of bugs related to snapshot chain corruption have been fixed but we still issue some occurrences here and there (HDDS-10524 is a very recent one).
This change is to implement a tool that can be used to repair the snapshot chain corruption once a corrupted entry is identified.
The idea for this tool is from HDDS-8100. This change also provides a base setup for HDDS-8100 and can be extended to provide support for other cases HDDS-8101, HDDS-8824, HDDS-10295, etc.
What is the link to the Apache JIRA
HDDS-9802
How was this patch tested?
Tested it on the docker.

Thanks, @adoroszlai and @aswinshakil for the review.


feat(crd): update vm-dhcp-controller crd manifests

Add declarative validations and some additional fields to support agent upgrades
Ref:

harvester/vm-dhcp-controller#18
harvester/vm-dhcp-controller#23

do we even need to publish the crds? the controller already has the crds packaged as bindata and will apply the manifests at upgrade.


Add creator GUI skeleton

Thanks, sure I will fix this the next week.

Good job, we manage to make the first merge :)


Add rbx-2.6.0, rbx-2.7.0, rbx-2.8.0, rbx-2.9.0

Also, support Rubinius linking against Homebrew openssl due to OS X not shipping with system OpenSSL headers anymore.

:+1:


Recursively open new pages => Error: Protocol error (Target.createTarget): Target closed.

Steps to reproduce
Tell us about your environment:

Puppeteer version: ^5.5.0
Platform / OS version: Windows 10
Node.js version: v13.14.0

What steps will reproduce the problem?
Here is my code :
const getAllUrl = async (browser, urlList, urlListCrawled) => {
    if(urlList.length > 0){
        const page = await browser.newPage();
        const url = urlList.shift();
        if(urlListCrawled.includes(url)){
            getAllUrl(browser, urlList, urlListCrawled);
        }
        await page.goto(url);
        await page.waitForSelector('body');
        const allHrefs = await page.evaluate(() =>
            [...document.querySelectorAll('a[href*="specificurl"]')].map(link => link.href)
        );

        urlListCrawled.push(url);
        urlList = [...urlList,...allHrefs];

        //await page.close();
        getAllUrl(browser, urlList, urlListCrawled);
    } else {
        return urlListCrawled;
    }
}

const scrap = async () => {
    const browser = await puppeteer.launch({ headless: false });
    let urlListCrawled = [];
    let urlList = ["mywebsiteurl"];
    const result = await getAllUrl(browser, urlList, urlListCrawled);
    browser.close();
    return result;
}

scrap()
  .then(value => {
        console.log('The end');
        console.log(value);
  })
  .catch(e => console.log(`error: ${e}`))

What is the expected result?
I want to make a function that crawl my website to check all URLs, this is why I made it recursive, because I retrieved new URLs on the fly. So, I want Puppeteer to check all urls in "urlList" until it's empty, and then return the list of urls crawled.
What happens instead?
My script stop and the error below show up in my console. My function getAllUrl is called one time, retrieve some urls, and then, when it's called another time with the new list, it stop at "const page = browser.newPage()" and then, it get out of getAllUrl to "browser.close()", and in the console log I have "The end" and "Undefined" insted of my list of urls crawled. I tried to put "await page.close();" after calling another time my function but it's not working.
(node:22592) UnhandledPromiseRejectionWarning: Error: Protocol error (Target.createTarget): Target closed.
    at C:\Tools\crawler\node_modules\puppeteer\lib\cjs\puppeteer\common\Connection.js:71:63
    at new Promise (<anonymous>)
    at Connection.send (C:\Tools\crawler\node_modules\puppeteer\lib\cjs\puppeteer\common\Connection.js:70:16)
    at Browser._createPageInContext (C:\Tools\crawler\node_modules\puppeteer\lib\cjs\puppeteer\common\Browser.js:221:53)
    at BrowserContext.newPage (C:\Tools\crawler\node_modules\puppeteer\lib\cjs\puppeteer\common\Browser.js:500:30)
    at Browser.newPage (C:\Tools\crawler\node_modules\puppeteer\lib\cjs\puppeteer\common\Browser.js:214:37)
    at getAllUrl (C:\Tools\crawler\app\cssCrawler.js:22:38)
    at getAllUrl (C:\Tools\crawler\app\cssCrawler.js:59:9)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async scrap (C:\Tools\crawler\app\cssCrawler.js:95:20)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:22592) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promi
se which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli
_unhandled_rejections_mode). (rejection id: 1)
(node:22592) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-ze
ro exit code.

Ps : Sorry if my English is not perfect, I'm French.

Inside getAllUrl(), try to replace getAllUrl(browser, urlList, urlListCrawled); with return getAllUrl(browser, urlList, urlListCrawled); — otherwise all recursive calls except the last return a Promise that resolves in undefined.

Damn, you are right.
It works perfectly now, thans you !


Comprehensive Documentation of Contract Usage

There should be an example driven documentation of how contracts are to be used that we can link to from e.g. the requires, ensures, stub_verified, proof_for_contract attribute documentation.

Also documentation for old for history expressions


Line chart not rendering on iOS

In some cases simple line charts that work fine on desktop browsers are not rendering on iOS.  An example of this issue can be found in the "samples" directory: line.html.  It appears to throw an error when the Chart() constructor is called because subsequent javascript is not being executed; however, no error is thrown in any desktop browser.  The behavior is the same on Safari and Chrome on iOS.

Is there any solution for fix this bug? I have a similar issue with bar chart.

I cannot reproduce this on iOS 9.3.2


Convert to canvas coordinates point exception

The lines are not drawn at the location of the mouse point,as follow:

CSS：
.crysan-canvas-main canvas {
  ....
  width: 1100px;
  height: 800px;
 ....
}

Canvas height and width should not be set in CSS.
Beause,Css only change the canvas element 's width and height,not change drawing surface.
Set the element width and height correctly as follow：
$(".crysyan-designer").CrysyanDesigner({
       canvas: {
           width: 800,
           height: 500
       }
   }, callback);

About Canvas element size versus drawing surface size(wiki)

A canvas actually has two sizes: the size of the element itself and the size of the element’s drawing surface. Setting the element's width and height attributes sets both of these sizes; CSS attributes affect only the element’s size and not the drawing surface.

By default, both the canvas element’s size and the size of its drawing surface is 300 screen pixels wide and 150 screen pixels high. In the listing shown in the example, which uses CSS to set the canvas element’s size, the size of the element is 600 pixels wide and 300 pixels high, but the size of the drawing surface remains unchanged at the default value of 300 pixels × 150 pixels. When a canvas element’s size does not match the size of its drawing surface, the browser scales the drawing surface to fit the element (which may result in surprising and unwanted effects).

Example on setting element size and drawing surface size to different values:


Revert "Add flag to prevent builders from running as root"

This reverts commits 31c87068865edcafe754e0a83c67f2903d5000d6 and 5d118bd5f36bac6d9dc1aa80b3cb81992ea42b31.
The no-root flag will be re-implemented as a flag specifying which users to allow

@bparees ptal

[test]

lgtm [merge]


[SPARK-38561][K8S][DOCS][FOLLOWUP] Add note for specific scheduler configuration and fix typos

What changes were proposed in this pull request?
Add note for specific scheduler configuration and fix typos
Why are the changes needed?
We addressed some comments on https://github.com/apache/spark/pull/35955 when backport to 3.3 branch.
Does this PR introduce any user-facing change?
No, doc only
How was this patch tested?

SKIP_API=1 bundle exec jekyll serve --watch

@srowen Thanks for review,  I'm not a native speaker, lack the mastery of words. I'm so sorry about back and forth due to tiny typo.

Merged to master (conflicted with 3.3)


[CW-22139] feat(sui): support sui derive address

Task linked: CW-22139 [SDK] implementation recover address


Error in function CreateMirrorBars

Description

I recently just logged back into retail and the UI did not work. I then proceeded to try and reinstall the UI and it did reinstall. But the same issue persisted.
Version Number

KkthnxUI-DF-10.4.7-Release
Steps to Reproduce

Step 1: Download
Step 2: Start Game & Login to Character
Step 3 Thats it really.
Step 4

Expected Behavior

Preferably that the UI loads as usually.
Actual Behavior

The UI does not load as usually. It does however load the FPS, MS counters and that is about it
Only KkthnxUI Enabled

This is the only addon i have, so it would be realtime situation.
Additional Information

Error Log

Message: Interface/AddOns/KkthnxUI/Init.lua:316: Error in function CreateMirrorBars: ...ns/KkthnxUI/Modules/Blizzard/Elements/MirrorBars.lua:7: attempt to index local 'bar' (a nil value)
Time: Thu Jul 20 17:47:43 2023
Count: 1
Stack: Interface/AddOns/KkthnxUI/Init.lua:316: Error in function CreateMirrorBars: ...ns/KkthnxUI/Modules/Blizzard/Elements/MirrorBars.lua:7: attempt to index local 'bar' (a nil value)
[string "=[C]"]: in function `error'
[string "@Interface/AddOns/KkthnxUI/Modules/Blizzard/Core.lua"]:21: in function `OnEnable'
[string "@Interface/AddOns/KkthnxUI/Init.lua"]:316: in function `func'
[string "@Interface/AddOns/KkthnxUI/Init.lua"]:177: in function <Interface/AddOns/KkthnxUI/Init.lua:172>

Locals: (*temporary) = "Error in function CreateMirrorBars: ...ns/KkthnxUI/Modules/Blizzard/Elements/MirrorBars.lua:7: attempt to index local 'bar' (a nil value)"

Fixed download latest Curse!


GPU parallel inference

Is your feature request related to a problem? Please describe.
Models greater than the GPU memory capacity cannot be currently run in inference, whilst parallel implementations in training exist.
Describe the solution you'd like
Implement parallel inference, allowing anemoi models to be distributed across several GPUs.
Describe alternatives you've considered
No response
Additional context
No response
Organisation
ECMWF

Additional context: This also has a use case for running inference on AWS (KNMI), where it would be preferable to request multiple smaller GPU instances and combine the GPU memory through model sharding. When requesting an AWS instance with sufficient memory to run without model sharding, you typically get an instance with multiple GPUs of which only one is used


Add auth flow option to KeyOpts.

Summary

This change adds an option for callers to manually select the fulcio
auth flow to go through. This allows callers that don't fit into the
default heuristic to have some control over how cosign is invoked.
For now, this is only added as a KeyOpt and not a flag, since this is
currently only needed by tools calling the cosign libraries, not cosign
itself. Flags can be added on later if needed.
This change should not have any impact on existing cosign behavior.
Because there are no unit tests for fulcio.NewSigner at the moment,
this is difficult to test in a way that isn't trivial. This is probably a good
target to improve coverage as part of https://github.com/sigstore/cosign/issues/1385
Signed-off-by: Billy Lynch<EMAIL_ADDRESS>Ticket Link

Fixes https://github.com/sigstore/cosign/issues/1785
Release Note

Users calling cosign via library can set the fulcio interactive flow used with KeyOpts.

Codecov Report

Merging #1827 (150e47b) into main (e74f180) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1827      +/-   ##
==========================================
- Coverage   33.02%   32.98%   -0.05%
==========================================
  Files         147      147
  Lines        9347     9350       +3
==========================================
- Hits         3087     3084       -3
- Misses       5906     5911       +5
- Partials      354      355       +1

Impacted Files
Coverage Δ

cmd/cosign/cli/fulcio/fulcio.go
21.42% <0.00%> (-0.68%)
:arrow_down:

pkg/cosign/tuf/client.go
61.68% <0.00%> (-0.82%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e74f180...150e47b. Read the comment docs.


use client-go to interact with the cluster in container and optimize code

Signed-off-by: zhy76<EMAIL_ADDRESS>
Describe what this PR does / why we need it
After this PR, if e2e test failed, we can view the failed pod log, which is very helpful for us to debug.
for example:

Does this pull request fix one issue?

#2013
Describe how you did it
Describe how to verify it
Special notes for reviews

Codecov Report
Base: 17.72% // Head: 17.72% // No change to project coverage :thumbsup:

Coverage data is based on head (eb1cbe0) compared to base (2cd5bb8).
Patch has no changes to coverable lines.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2014   +/-   ##
=======================================
  Coverage   17.72%   17.72%
=======================================
  Files         105      105
  Lines        9469     9469
=======================================
  Hits         1678     1678
  Misses       7563     7563
  Partials      228      228

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

gosec / golang-security-action shows：

It has nothing to do with the code I changed, seems like a bug? How do I solve these problem?

gosec / golang-security-action shows：  It has nothing to do with the code I changed, seems like a bug? How do I solve these problem?

its gosec lint, i will fix it today.

PTAL

/test all


Update concept-authentication-methods.md

Adding clarification on the alternate phone method authentication method when voice call is enabled for users. Testing shows that the alternate phone method is only available for MFA and not SSPR.

@Justinha
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Remove focus rings from filter checkboxes

Here's the current look.

There's no use of the focus element, except accessibility. We do not support accessibility at the moment. I suggest we remove focus rings from these checkboxes.

Fixed in https://github.com/neu-fi/turkiye-relief-dao/pull/68


Mamba is deeper but narrower than typical models of the same size

Looking at the 3B (2.8B) models, Mamba has 64 layers, whereas GPT-Neo, OPT, and RWKV only have 32.
Is model depth a confounding factor to Mamba's amazing performance? Are there checkpoints available for a Mamba 3B with 32 layers but twice the hidden-dim?

As mentioned in the README
The layer count of Mamba doubles that of a Transformer with similar size, as two Mamba blocks are needed for each "layer" (MHA block + MLP block) of a Transformer.

Ah, sorry I missed that!


Semantic Highlighting: Mutability of mut self is not always propagated

If the parameter is fn(mut self, ...) as opposed to fn(&mut self, ...) then the usage of self is not marked as mutable as it would for other variables.
Correct propagation on &mut self:

Incorrect propagation on mut self:

This is the part my pr https://github.com/rust-analyzer/rust-analyzer/pull/5345 didn't implement yet unfortunately as it wasn't trivial to do it seems(unless I missed something). It seems like the self local is cast down to a shared reference/immutable value if it is being used as such in the db.


Have an option to save more than the last 10 runs for specific jobs

Some jobs, namely the artifact ami jobs, run more than once when triggered. The base ami job specifically runs 15 times once it is triggered, which makes the 10 run history that argus saves insufficient.
Please add an option to save a history of more than 10 of the latest runs per job.

I plan to implement this when working on refactoring TestRuns component - a button that allows you to load more runs for a test, in case you want to check the history, each consecutive press would add 10 more runs to the dash.

@k0machi isn't this done already?

Looks like it