[Feature request] Unlock Professional mode from the start

Describe the feature you'd like to see added
Pretty straightforward - add the option to unlock the highest difficulty without beating the game first.

I love this game, but I can't make myself play it without Professional Mode. It's so disappointing. Enabling professional mode from the start would also come with the added benefit of being able to play professional mode WITHOUT any of the overpowered weapons, like the Chicago Typewriter.
It would make challenges much more exciting. I'd be willing to donate to anyone that can figure out how to make this work and updates the mod.

Seems we mostly had everything in place for this, just needed some extra code to allow the menu to be reloaded while keeping any flags updated by the user.
Should be working on the trainer branch now (build at https://github.com/nipkownix/re4_tweaks/suites/9282871280/artifacts/435151529), just open re4_tweaks menu UI -> Trainer -> Flag Editor -> choose EXTRA from the dropdown, and there you can choose what things you want to unlock.
After editing the flags you need to back out of the main menu to the RE4 logo/"press any key" screen, then the unlocks from the flags should be applied.


feat: tel state noticer to query for tel updates

Working towards TEL Observers - made some changes to make TSN behave same as KSN with a noticer that will fetch any remaining items.
This isn't fully complete as I need some feedback - I'm really not sure if we are meant to escrow notices of new events that we haven't received yet.
Looking back in the history, we did this for KSN too but changed it in #441 and #538 so thinking it might make sense for TSN to behave the same way so that we can have efficient TEL observers. So I've made some changes there to be more like KSN.
If this isn't the right approach, we need to do something to trigger fetching of tels - the telquery calls for escrows aren't right atm for the same reason as #865 - no src so messages are never sent.

@pfeairheller can you advise if this change to make tsn match ksn is on the right path? thanks!


Schema's scalar_overrides type annotation.

Following scalars revamping, Schema signature appears outdated.
Applying mypy on example:
from datetime import datetime, timezone
import strawberry

# Define your custom scalar
EpochDateTime = strawberry.scalar(
    datetime,
    serialize=lambda value: int(value.timestamp()),
    parse_value=lambda value: datetime.fromtimestamp(int(value), timezone.utc),
)

@strawberry.type
class Query:
    @strawberry.field
    def current_time(self) -> datetime:
        return datetime.now()

schema = strawberry.Schema(
  Query,
  scalar_overrides={
    datetime: EpochDateTime,
  }
)
result = schema.execute_sync("{ currentTime }")
assert result.data == {"currentTime":<PHONE_NUMBER>}

yields
example.py:20: error: Dict entry 0 has incompatible type "Type[datetime]": "Type[datetime]"; expected "object": "Union[ScalarWrapper, ScalarDefinition]"  [dict-item]
Found 1 error in 1 file (checked 1 source file)

I'd say that since scalars are now cast to their own type, the value part of the dict Union[ScalarWrapper, ScalarDefinition] is outdated.


⚠ SceneTime has degraded performance

In 41073d7, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 1486 ms

Resolved: SceneTime performance has improved in e6f494b after 19 minutes.


Cursor jumps while updating VScode Settings

There is a funny behavior under Windows when a VsCode Setting is edited and the next setting clicked, the cursor jumps back to the  first setting (maybe the "Update settings" runs in background). It takes several clicks till the second field can be edited. The behavior is also not always reproducible.

Interesting bug.
I can't reproduce this on my setup (Linux-based).
And I think this behavior is a bug in VS code, as Open-Needs IDE does not execute any code for this.
The settings fields are based on JSON configuration only.
On Linux, I have another bug, which deactivates my arrow keys left and right, after some not yet so clear events.
Only a restart helps. The same behavior I have on the MS Teams app.
Both tools MS Teams and VS Code are based on Electron.
So maybe Electron is also for this bug the problem.
I'm not sure, but I'm afraid that Open-Needs IDE can't do anything to solve this bug.

See to be general VS Code bug. Other settings are affected as well.


Extension periodically refreshes the file under review, resetting the view position

Description

Install both GitHub Pull Requests (v0.50.0) and https://marketplace.visualstudio.com/items?itemName=eamodio.gitlens (v12.2.2).
Open a pull request in the extension and begin reviewing a file
Proceed with review for about 1-2 minutes

Expected behavior: editor view position is only affected by user actions (e.g. navigation commands, scrolling)
Actual behavior: editor view position is periodically reset, disrupting the review.
Note that this behavior only occurs when both the GitLens and GitHub extensions are enabled. When I disable the GitLens extension, the bad behavior stops. I am not sure which extension is to "blame" in this scenario, so I'm taking the liberty of filing a bug both here and at gitkraken/vscode-gitlens#2259.
VS Code Version
Version: 1.72.0 (user setup)
Commit: 64bbfbf67ada9953918d72e1df2f4d8e537d340e
Date: 2022-10-04T23:20:39.912Z
Electron: 19.0.17
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19044
Sandboxed: No
Git Version
git version 2.30.0.windows.2
Logs, Screenshots, Screen Captures, etc
This recording roughly shows the bad behavior, which occurs once every 1-2 minutes. Note that several different activity indicators are popping up in the left sidebar before the editor tab goes blank and refreshes.

I haven't yet been able to reproduce this issue. I'll keep an eye out for it.

And now I was just able to repro it.

@alexr00 is this a GHPR issue?

@eamodio I found a GHPR issue that caused it. I don't know why the issue would only repro with Gitlens. I would assume that was a fluke as it didn't occur 100% of the time for me.

Do you we know when this fix is going available in the insiders build?
As it also appears reset comments, which is a bit of a PITA :-)

@jpspringall the fix has been in the pre-release build of the extension (which requires that you use VS Code Insiders) for about 2 weeks.


fix(ui-shell): remove close icon

removes the close icon (consumers can add it back with an ngIf on their end, not needed with the updated carbon styles)
updates the header to take a route

It's not clear to me that the close icon is part of the carbon specs ... it doesn't appear to be 😕 https://www.carbondesignsystem.com/components/UI-shell-right-panel/code


Handle unknowns completely

This PR combines  this existing branch with the updates made here.
Hopefully this comprehensively handles unknown DICOM elements.
(Note: this PR also contains the changes from my PR currently up)

Suggestion: this PR may read cleaner if you branch off of the existing changes branch and add on top as needed. I'm not sure if this PR needs the changes from your other PR #233, but if not then that will probably be the cleanest way to setup and review the salient changes in this PR (and make it less likely to be stale as changes are made in the other PRs etc)! You can also probably rebase your new branch to incoporate the changes already merged into main (or if needed I can rebase s/read-un-as-sq).


check please, customer feature added

Reviewed and approved. Code changes look good. The pull request is now ready to be merged. Well done!

done


Transparent background not supported for PDF output

When transparent background is used via:
layout = {
    "plot_bgcolor": "rgba(1,1,1,0)",
    "paper_bgcolor": "rgba(1,1,1,0)"
}

Saving the image as PDF output with the kaleido engine does not produce transparent background.
Nevertheless, transparent background does work in the following scenarios:

PNG output with the kaleido engine
PNG output with the orca engine
PDF output with the orca engine

Thanks for the report!


CI: Post-merge testing fails in 'image_prune' task

/kind bug
Description
The 'image_prune' task only runs on master, post-merge and
is currently failing for all builds.  This is because it
references a non-existent image.  The person with access
to add/enable this image is on PTO.  Fix this by temporarily
using a hand-built image until an automatic build can be added.
Steps to reproduce the issue:

Merge pull-request

Describe the results you received:
The CI task 'image_prune' always fails.
Describe the results you expected:
The CI task 'image_prune' always passes.

@baude when you get back, and settled, let me know.  We just need a quay.io image and build added identical to the others, but for docker build -t quay.io/libpod/imgprune:latest -f contrib/imgprune .  Then my temp. workaround commit can be reverted.


Remove root cache

Motivation
RootCache may become unnecessary after merging SSZ v2.

From https://github.com/ChainSafe/lodestar/issues/3998
See https://github.com/ChainSafe/lodestar/pull/4374 for a performance test

Marking as draft to decide first if this is a good idea
Description

Remove RootCache

After discussing with @tuyennhv RootCache still provides a noticeable performance improvement even with ssz v2, so we are keeping the optimization


More on python 3 compatibility

Making errors visible and avoiding "catch pokémon" anti-pattern.
Making it to work in python 2 and 3 (now for sure).
I tried to catch ConnectionRefusedError, but it is just in python3. It seems both python 2 and 3 has socket.error and ConnectionRefusedError depends on it.

Please, wait. Another issue with line.partition. I will solve it as soon as I could.

It should be working now.

Now it is fine.

Taking A look

👻 🐮


About Transformer decoder Pixel decoder

Hi,
Unfortunately, I didn't find your email address as the author, so I had to ask a dissertation-related question here
Which structure of SAM's mask decoder does the Transformer decoder and pixel decoder mentioned in the paper refer to? Because I don't think SAM should have the ability to assign a class to each pixel?
If so, you can send it to me directly at<EMAIL_ADDRESS>Looking forward to further communication with you!

Sure! I will contact you through my email<EMAIL_ADDRESS>


Remove Interact dependency

Interact is a hefty dependency that will be rarely used - only when visualizing rewriting trajectories within a Jupyter notebook. Because of this, the dependency should be optional via Requires.jl.

You should probably remove the manifest entirely. You can check it into a subfolder for the examples if you want to ensure that someone can get a working manifest for reproducing the examples, but the main package shouldn't have a manifest


Tensor Size Mismatch and setup_caches Assertion Error in generate.py

Self Checks

[X] This is only for bug report, if you would like to ask a question, please head to Discussions.
[X] I have searched for existing issues search for existing issues, including closed ones.
[X] I confirm that I am using English to submit this report (我已阅读并同意 Language Policy).
[X] [FOR CHINESE USERS] 请务必使用英文提交 Issue，否则会被关闭。谢谢！:）
[X] Please do not modify this template :) and fill in all the required fields.

Cloud or Self Hosted
Self Hosted (Source)
Steps to reproduce
python tools/llama/generate.py
--text "要转换的文本"
--prompt-text "你的参考文本"
--prompt-tokens "fake.npy"
--checkpoint-path "checkpoints/fish-speech-1.4"
--num-samples 1
--compile
✔ Expected Behavior
codes_0.npy
❌ Actual Behavior
Traceback (most recent call last):
  File "/fish-speech/tools/llama/generate.py", line 703, in <module>
    main()
  File "/home/user/.pyenv/versions/miniconda3-latest/envs/py310-nix-fishspeech/lib/python3.10/site-packages/click/core.py", line 1157, in
__call__
    return self.main(*args, **kwargs)
  File "/home/user/.pyenv/versions/miniconda3-latest/envs/py310-nix-fishspeech/lib/python3.10/site-packages/click/core.py", line 1078, in
main
    rv = self.invoke(ctx)
  File "/home/user/.pyenv/versions/miniconda3-latest/envs/py310-nix-fishspeech/lib/python3.10/site-packages/click/core.py", line 1434, in
invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/user/.pyenv/versions/miniconda3-latest/envs/py310-nix-fishspeech/lib/python3.10/site-packages/click/core.py", line 783, in i
nvoke
    return __callback(*args, **kwargs)
  File "/fish-speech/tools/llama/generate.py", line 687, in main
    for response in generator:
  File "/fish-speech/tools/llama/generate.py", line 488, in generate_long
    y = generate(
  File "/home/user/.pyenv/versions/miniconda3-latest/envs/py310-nix-fishspeech/lib/python3.10/site-packages/torch/utils/_contextlib.py", l
ine 116, in decorate_context
    return func(*args, **kwargs)
  File "/home/user/.pyenv/versions/miniconda3-latest/envs/py310-nix-fishspeech/lib/python3.10/site-packages/torch/utils/_contextlib.py", l
ine 116, in decorate_context
    return func(*args, **kwargs)
  File "/fish-speech/tools/llama/generate.py", line 245, in generate
    empty[:, :T] = prompt
RuntimeError: The expanded size of the tensor (0) must match the existing size (275) at non-singleton dimension 1.  Target sizes: [9, 0].
 Tensor sizes: [9, 275]

# line ~ 608
@click.option("--max-new-tokens", type=int, default=1024) # change here to 1024

It will be fixed soon.

Thanks for fixing it. When invoking setup_caches, instead of hardcoding max_seq_len, is it possible to set the value dynamically:
max_seq_len = model.config.max_seq_len if hasattr(model, "config") else 2048

Yes, certainly. :)


Simple RCCL all_sum test script triggers Memory access fault by GPU node-1

System information

Have I written custom code: No
OS Platform and Distribution: Ubuntu 18.04.2
TensorFlow installed from: binary(pip install tensorflow-rocm)
TensorFlow version: 1.13.1
Python version: 3.6
ROCm/MIOpen version: 2.2 + 1.7.1
GPU model and memory: VEGA 64 x 2

Describe the current behavior
A simple test script using rccl.all_sum(or other RCCL ops?) causes segmentation fault.
A tensor is assigned to each GPU device, then use all_sum to compute a sum with collective operation.
Describe the expected behavior
I think it should run without segmentation fault.
Here is an equivalent code in NCCL.
At least I have confirmed this NCCL version of script works well on NVIDIA platform(1080 Ti + 1070. CUDA 10 + TensorFlow 1.13.1).
import tensorflow as tf

from tensorflow.python.ops import nccl_ops
import numpy as np

def network(x):
    with tf.device('/gpu:1'):
        x1= tf.reshape(x, [-1, 4, 4])
    with tf.device('/gpu:0'):
        x0= tf.reshape(x, [-1, 4, 4])
        x0 = nccl_ops.all_sum([x0,x1])
        result = tf.identity(x0)
        return result

x = np.random.ranf(size=[2, 4, 4])
y_pre = network(x)
with tf.Session() as sess:
    sess.run(tf.global_variables_initializer())
    ret = sess.run(y_pre)
    print(ret)

Code to reproduce the issue
import tensorflow as tf

import tensorflow.contrib.rccl as rccl
import numpy as np

def network(x):
    with tf.device('/gpu:1'):
        x1= tf.reshape(x, [-1, 4, 4])
    with tf.device('/gpu:0'):
        x0= tf.reshape(x, [-1, 4, 4])
        x0 = rccl.all_sum([x0,x1])
        result = tf.identity(x0)
        return result

x = np.random.ranf(size=[2, 4, 4])
y_pre = network(x)
with tf.Session() as sess:
    sess.run(tf.global_variables_initializer())
    ret = sess.run(y_pre)
    print(ret)

Other info / logs
$ python test.py
2019-03-24 17:02:21.063273: I tensorflow/core/platform/cpu_feature_guard.cc:141] Your CPU supports instructions that this TensorFlow binary was not compiled to use: SSE4.1 SSE4.2 AVX AVX2 FMA
2019-03-24 17:02:21.070210: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1531] Found device 0 with properties:
name: Vega 10 XT [Radeon RX Vega 64]
AMDGPU ISA: gfx900
memoryClockRate (GHz) 1.59
pciBusID 0000:28:00.0
Total memory: 7.98GiB
Free memory: 7.73GiB
2019-03-24 17:02:21.070517: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1531] Found device 1 with properties:
name: Vega 10 XT [Radeon RX Vega 64]
AMDGPU ISA: gfx900
memoryClockRate (GHz) 1.59
pciBusID 0000:2b:00.0
Total memory: 7.98GiB
Free memory: 7.73GiB
2019-03-24 17:02:21.071182: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1642] Adding visible gpu devices: 0, 1
2019-03-24 17:02:21.071344: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1053] Device interconnect StreamExecutor with strength 1 edge matrix:
2019-03-24 17:02:21.071358: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1059]      0 1
2019-03-24 17:02:21.071365: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1072] 0:   N N
2019-03-24 17:02:21.071370: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1072] 1:   N N
2019-03-24 17:02:21.071475: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1189] Created TensorFlow device (/job:localhost/replica:0/task:0/device:GPU:0 with 7524 MB memory) -> physical GPU (device: 0, name: Vega 10 XT [Radeon RX Vega 64], pci bus id: 0000:28:00.0)
2019-03-24 17:02:21.144138: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1189] Created TensorFlow device (/job:localhost/replica:0/task:0/device:GPU:1 with 7524 MB memory) -> physical GPU (device: 1, name: Vega 10 XT [Radeon RX Vega 64], pci bus id: 0000:2b:00.0)
Memory access fault by GPU node-1 (Agent handle: 0x5565e0e43340) on address 0x7fc29f400000. Reason: Page not present or supervisor privilege.
Aborted (core dumped)

gdb trace
51	../sysdeps/unix/sysv/linux/raise.c: No such file or directory.
(gdb) bt
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
#1  0x00007ffff7805801 in __GI_abort () at abort.c:79
#2  0x00007fffb610bd4d in ?? () from /opt/rocm/hsa/lib/libhsa-runtime64.so.1
#3  0x00007fffb610c9dd in ?? () from /opt/rocm/hsa/lib/libhsa-runtime64.so.1
#4  0x00007fffb60d0637 in ?? () from /opt/rocm/hsa/lib/libhsa-runtime64.so.1
#5  0x00007ffff7bbd6db in start_thread (arg=0x7fffa1727700)
    at pthread_create.c:463
#6  0x00007ffff78e688f in clone ()
    at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Hi @syoyo , Ubuntu18.04.2 is not supported by ROCm2.2, the related comment is here:
https://github.com/RadeonOpenCompute/ROCm/issues/731#issuecomment-472782999
Could you make sure your system can run HIP unit test correctly before trying tensorflow?
https://github.com/ROCm-Developer-Tools/HIP/tree/master/tests

Ubuntu18.04.2 is not supported by ROCm2.2, the related comment is here:
RadeonOpenCompute/ROCm#731 (comment)

I have confirmed same error happens on Ubuntu 16.04(2 Polaris'). FYI I'm using kernel 4.15 on Ubuntu 18.04.2

Could you make sure your system can run HIP unit test correctly before trying tensorflow?

I've faced build failure of HIP tests(by following procedure of HIP tests readme)
Probably need to find a way to compile HIP tests without AMP support
/home/syoyo/work/HIP/tests/src/kernel/hipLanguageExtensions.cpp:34:10: fatal error: 'amp.h' file not found
#include <amp.h>
         ^~~~~~~
1 error generated.
/home/syoyo/work/HIP/tests/src/kernel/hipLanguageExtensions.cpp:34:10: fatal error: 'amp.h' file not found
#include <amp.h>
         ^~~~~~~
1 error generated.
CMake Error at /home/syoyo/work/HIP/build/install/cmake/FindHIP/run_make2cmake.cmake:18 (file):
  file failed to open for reading (No such file or directory):

    /home/syoyo/work/HIP/build/CMakeFiles/directed_tests.kernel.hipLanguageExtensions.dir/tests/src/kernel/directed_tests.kernel.hipLanguageExtensions_generated_hipLanguageExtensions.cpp.o.depend.pre

CMake Error at directed_tests.kernel.hipLanguageExtensions_generated_hipLanguageExtensions.cpp.o.cmake:134 (message):
  Error generating
  /home/syoyo/work/HIP/build/CMakeFiles/directed_tests.kernel.hipLanguageExtensions.dir/tests/src/kernel/./directed_tests.kernel.hipLanguageExtensions_generated_hipLanguageExtensions.cpp.o

CMakeFiles/directed_tests.kernel.hipLanguageExtensions.dir/build.make:63: recipe for target 'CMakeFiles/directed_tests.kernel.hipLanguageExtensions.dir/tests/src/kernel/directed_tests.kernel.hipLanguageExtensions_generated_hipLanguageExtensions.cpp.o' failed
make[3]: *** [CMakeFiles/directed_tests.kernel.hipLanguageExtensions.dir/tests/src/kernel/directed_tests.kernel.hipLanguageExtensions_generated_hipLanguageExtensions.cpp.o] Error 1
CMakeFiles/Makefile2:5675: recipe for target 'CMakeFiles/directed_tests.kernel.hipLanguageExtensions.dir/all' failed
make[2]: *** [CMakeFiles/directed_tests.kernel.hipLanguageExtensions.dir/all] Error 2
make[2]: *** Waiting for unfinished jobs....
[  2%] Built target directed_tests.kernel.inline_asm_vadd
[  3%] Built target directed_tests.kernel.hipTestConstant
[  3%] Built target directed_tests.kernel.hipGridLaunch
[  4%] Built target directed_tests.kernel.hipLaunchParmFunctor
[  5%] Built target directed_tests.kernel.hipPrintfKernel
[  5%] Built target directed_tests.kernel.hipTestMemKernel
[  6%] Built target directed_tests.kernel.hipLaunchParm
CMakeFiles/Makefile2:79: recipe for target 'CMakeFiles/build_tests.dir/rule' failed
make[1]: *** [CMakeFiles/build_tests.dir/rule] Error 2
Makefile:175: recipe for target 'build_tests' failed

I have also tried to compile RCCL sample program
https://github.com/ROCmSoftwarePlatform/rccl
and also got a memory access fault error.
So, it looks RCCL itself is not yet supported on ROCm 2.2?

Filed an issue at RCCL repo: https://github.com/ROCmSoftwarePlatform/rccl/issues/59

Hi @syoyo , thanks for the additional information.
Please aware RCCL support in TF1.13 and ROCm2.3 is experimental.
For multi-GPU training, we recommend using CPU as the parameter servers for better stability and performance.

Please aware RCCL support in TF1.13 and ROCm2.3 is experimental.

Oh, I see. I saw this comment from you and I thought RCCL is now available and working in ROCm: https://github.com/ROCmSoftwarePlatform/tensorflow-upstream/issues/155#issuecomment-461932571
I can use CPU node for corrective operation for a while, but official RCCL support in TensorFlow is highly expected.

Thanks @syoyo , appreciate your comment. Will update when we have mature TF-RCCL solution available.
Closing this ticket for now.

We will have a mature RCCL support starting ROCm2.6... Stay tuned.

@ajitmaths Awesome! Good to hear of it! > RCCL support starting ROCm2.6


Update dependencies, fix phpstan, allow symfony 5

Pull Request Test Coverage Report for Build 41

3 of 4 (75.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 58.947%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/Git/GitCommandFactory.php
0
1
0.0%

Totals

Change from base Build 36:
0.0%

Covered Lines:
56

Relevant Lines:
95

💛  - Coveralls


About OpenYurt RoadMap, whole picture design and long-term plan.

It is good that OpenYurt 0.4.0 RoadMap was released out. The planned features are quite attractive.
However, I believe It will be better if the detailed feature description or design can also be opened and tracked through Github issues. so the community can know more detail on what is ongoing, and that is easier for people to involve in the project.
And another suggestion is that we even can start with the discussion on the future release plan basing on the whole picture of and the long time plan. I think that is quite important for the long-term development of the opensource project.  :)

+1 for tracking the detailed feature through the git issue. @rambohe-ch @Fei-Guo, what do you think?

Thanks for the suggestion. Sure, the feature owners will create issues beforehand and ask for volunteers. We usually don't set a goal that needs 6 month+ efforts because there are too many uncertainties and it is hard to track progress. Since the core openyurt architecture is already stable, most of the short term changes are going to be enhancement features like we have listed in the roadmap.
In terms of long term plans, there are thoughts of enhancing openyurt with more platform features such as CI/CD, edge compute resource provisioning and so on, but nothing has been decided yet. It is certainly welcome for the community uses to speak up their own thoughts and requirements so that we can discuss them via github issues or community meetings.

@Walnux Thank you for kindly suggestion. I think the feature owners will create issues after tomorrow's community meeting(2.24), and details of feature will also be discussed. I'm looking forward to your coming to OpenYurt community meeting.

+1 for tracking the detailed feature through the git issue.

May be we can start with this two features first.
Add Cloud Native IOT Device Management API definition.
Support IOT Device Management that comply with cloud native IOT API
We can later add our initial discussion to the issues.

+1 for tracking the detailed feature through the git issue.

May be we can start with this two features first.
Add Cloud Native IOT Device Management API definition.
Support IOT Device Management that comply with cloud native IOT API
After create the issue, we can add our initial discussions to the thread.

@yixingjia +1 for two features take steps firstly.


Styling flags

Add styling options to the CLI that control how types and variables in generated WitcherScript are named.
Proposals:

[ ] conversion of case styles. Preferred style should be set separately for Groups, Vars and OptionArrays. Available styles: snake case, camel case, pascal case, default (don't change the style).
[ ] if SettingsMaster prefix should be applied to Groups end Enums

Use convert_case crate

Closed due to #12


Allow changing the HDR tonemap

Description

Expose the tonemapper property of PostProcessStageCollection to allow changing the tonemap used when HDR is turned on

Updated the HDR sandcastle to have a dropdown to switch this

Create a new tonemap for the PBR Neutral Tonemap from Khronos

I think this one looks really good so I switched to use it as the default but I'm open to changing that.

[x] Need to confirm how to test this as I got the color it's rendering but I don't know if it's correct...

Issue number and link
part of #12126

Testing plan

Check the updated HDR sandcastle and test the various tonemaps (local, ci)

Author checklist

[x] I have submitted a Contributor License Agreement
[x] I have added my name to CONTRIBUTORS.md
[x] I have updated CHANGES.md with a short summary of my change
[x] I have added or updated unit tests to ensure consistent code coverage
[x] I have updated the inline documentation, and included code examples where relevant
[ ] I have performed a self-review of my code

We should switch to the Khronos PBR Neutral Tone Mapper for models as well. Should be a small change here:
https://github.com/CesiumGS/cesium/blob/349364c3b2ae3b6dbebe46ac78fdf728c06b4072/packages/engine/Source/Shaders/Model/LightingStageFS.glsl#L118-L124

@ggetz updated based on your comments, thanks. The biggest thing I've changed was a slight overhaul on the tests to actually test multiple colors as you suggested using small helper function. It may change the stacktrace a bit as you mentioned but the extra withContext helps a lot tracking down what number actually failed and it'd be really messy to duplicate those everywhere

@jjspace I see quite a few failing specs when running locally:
1) renders tileset with custom up and forward axes
     Scene/Cesium3DTileset
     Expected 107 to be less than 64.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:705:27 <- Build/Specs/SpecList.js:147593:27
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 107 to be less than 64.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:706:27 <- Build/Specs/SpecList.js:147594:27
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>

2) sets colorBlendMode
     Scene/Cesium3DTileset
     Expected 115 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3335:25 <- Build/Specs/SpecList.js:149683:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 115 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3336:25 <- Build/Specs/SpecList.js:149684:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 58 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3351:25 <- Build/Specs/SpecList.js:149694:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 43 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3364:25 <- Build/Specs/SpecList.js:149704:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 73 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3384:25 <- Build/Specs/SpecList.js:149719:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 48 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3398:25 <- Build/Specs/SpecList.js:149730:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 94 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3420:25 <- Build/Specs/SpecList.js:149747:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 251 to be less than 251.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3428:25 <- Build/Specs/SpecList.js:149753:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 106 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3431:25 <- Build/Specs/SpecList.js:149756:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 115 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3439:25 <- Build/Specs/SpecList.js:149762:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 115 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3440:25 <- Build/Specs/SpecList.js:149763:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 73 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3449:25 <- Build/Specs/SpecList.js:149770:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 43 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3462:25 <- Build/Specs/SpecList.js:149780:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>

3) sets colorBlendMode when vertex texture fetch is not supported
     Scene/Cesium3DTileset
     Expected 115 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3335:25 <- Build/Specs/SpecList.js:149683:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 115 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3336:25 <- Build/Specs/SpecList.js:149684:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 58 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3351:25 <- Build/Specs/SpecList.js:149694:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 43 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3364:25 <- Build/Specs/SpecList.js:149704:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 73 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3384:25 <- Build/Specs/SpecList.js:149719:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 48 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3398:25 <- Build/Specs/SpecList.js:149730:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 94 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3420:25 <- Build/Specs/SpecList.js:149747:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 251 to be less than 251.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3428:25 <- Build/Specs/SpecList.js:149753:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 106 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3431:25 <- Build/Specs/SpecList.js:149756:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 115 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3439:25 <- Build/Specs/SpecList.js:149762:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 115 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3440:25 <- Build/Specs/SpecList.js:149763:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 73 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3449:25 <- Build/Specs/SpecList.js:149770:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 43 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3462:25 <- Build/Specs/SpecList.js:149780:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>

4) sets colorBlendMode for textured tileset
     Scene/Cesium3DTileset
     Expected 115 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3335:25 <- Build/Specs/SpecList.js:149683:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 115 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3336:25 <- Build/Specs/SpecList.js:149684:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 58 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3351:25 <- Build/Specs/SpecList.js:149694:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 43 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3364:25 <- Build/Specs/SpecList.js:149704:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 73 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3384:25 <- Build/Specs/SpecList.js:149719:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 48 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3398:25 <- Build/Specs/SpecList.js:149730:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 93 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3420:25 <- Build/Specs/SpecList.js:149747:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 251 to be less than 251.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3428:25 <- Build/Specs/SpecList.js:149753:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 105 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3431:25 <- Build/Specs/SpecList.js:149756:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 115 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3439:25 <- Build/Specs/SpecList.js:149762:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 115 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3440:25 <- Build/Specs/SpecList.js:149763:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 73 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3449:25 <- Build/Specs/SpecList.js:149770:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 43 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3462:25 <- Build/Specs/SpecList.js:149780:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>

5) sets colorBlendMode for instanced tileset
     Scene/Cesium3DTileset
     Expected 115 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3335:25 <- Build/Specs/SpecList.js:149683:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 115 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3336:25 <- Build/Specs/SpecList.js:149684:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 58 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3351:25 <- Build/Specs/SpecList.js:149694:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 43 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3364:25 <- Build/Specs/SpecList.js:149704:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 73 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3384:25 <- Build/Specs/SpecList.js:149719:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 48 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3398:25 <- Build/Specs/SpecList.js:149730:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 94 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3420:25 <- Build/Specs/SpecList.js:149747:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 251 to be less than 251.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3428:25 <- Build/Specs/SpecList.js:149753:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 106 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3431:25 <- Build/Specs/SpecList.js:149756:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 115 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3439:25 <- Build/Specs/SpecList.js:149762:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 115 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3440:25 <- Build/Specs/SpecList.js:149763:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 73 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3449:25 <- Build/Specs/SpecList.js:149770:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 43 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3462:25 <- Build/Specs/SpecList.js:149780:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>

6) sets colorBlendMode for vertex color tileset
     Scene/Cesium3DTileset
     Expected 115 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3335:25 <- Build/Specs/SpecList.js:149683:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 115 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3336:25 <- Build/Specs/SpecList.js:149684:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 58 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3351:25 <- Build/Specs/SpecList.js:149694:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 43 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3364:25 <- Build/Specs/SpecList.js:149704:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 73 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3384:25 <- Build/Specs/SpecList.js:149719:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 48 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3398:25 <- Build/Specs/SpecList.js:149730:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 94 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3420:25 <- Build/Specs/SpecList.js:149747:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 251 to be less than 251.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3428:25 <- Build/Specs/SpecList.js:149753:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 106 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3431:25 <- Build/Specs/SpecList.js:149756:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 115 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3439:25 <- Build/Specs/SpecList.js:149762:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 115 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3440:25 <- Build/Specs/SpecList.js:149763:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 73 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3449:25 <- Build/Specs/SpecList.js:149770:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 43 to be less than 25.
    at <Jasmine>
    at packages/engine/Specs/Scene/Cesium3DTilesetSpec.js:3462:25 <- Build/Specs/SpecList.js:149780:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>

8) grey
     Scene/PostProcessStageCollection HDR tonemapping Reinhard
     without HDR: Expected to render [127,127,127,255], but actually rendered [128,128,128,255].
    at <Jasmine>
    at validateTonemapper (packages/engine/Specs/Scene/PostProcessStageCollectionSpec.js:414:50 <- Build/Specs/SpecList.js:212703:51)
    at UserContext.<anonymous> (packages/engine/Specs/Scene/PostProcessStageCollectionSpec.js:436:11 <- Build/Specs/SpecList.js:212721:11)
    at <Jasmine>

9) grey
     Scene/PostProcessStageCollection HDR tonemapping Modified Reinhard
     without HDR: Expected to render [127,127,127,255], but actually rendered [128,128,128,255].
    at <Jasmine>
    at validateTonemapper (packages/engine/Specs/Scene/PostProcessStageCollectionSpec.js:414:50 <- Build/Specs/SpecList.js:212703:51)
    at UserContext.<anonymous> (packages/engine/Specs/Scene/PostProcessStageCollectionSpec.js:478:11 <- Build/Specs/SpecList.js:212754:11)
    at <Jasmine>

10) red
     Scene/PostProcessStageCollection HDR tonemapping Modified Reinhard
     without HDR: Expected to render [127,0,0,255], but actually rendered [128,0,0,255].
    at <Jasmine>
    at validateTonemapper (packages/engine/Specs/Scene/PostProcessStageCollectionSpec.js:414:50 <- Build/Specs/SpecList.js:212703:51)
    at UserContext.<anonymous> (packages/engine/Specs/Scene/PostProcessStageCollectionSpec.js:485:11 <- Build/Specs/SpecList.js:212761:11)
    at <Jasmine>

11) green
     Scene/PostProcessStageCollection HDR tonemapping Modified Reinhard
     without HDR: Expected to render [0,127,0,255], but actually rendered [0,128,0,255].
    at <Jasmine>
    at validateTonemapper (packages/engine/Specs/Scene/PostProcessStageCollectionSpec.js:414:50 <- Build/Specs/SpecList.js:212703:51)
    at UserContext.<anonymous> (packages/engine/Specs/Scene/PostProcessStageCollectionSpec.js:492:11 <- Build/Specs/SpecList.js:212768:11)
    at <Jasmine>

12) blue
     Scene/PostProcessStageCollection HDR tonemapping Modified Reinhard
     without HDR: Expected to render [0,0,127,255], but actually rendered [0,0,128,255].
    at <Jasmine>
    at validateTonemapper (packages/engine/Specs/Scene/PostProcessStageCollectionSpec.js:414:50 <- Build/Specs/SpecList.js:212703:51)
    at UserContext.<anonymous> (packages/engine/Specs/Scene/PostProcessStageCollectionSpec.js:499:11 <- Build/Specs/SpecList.js:212775:11)
    at <Jasmine>

13) grey
     Scene/PostProcessStageCollection HDR tonemapping Filmic
     without HDR: Expected to render [127,127,127,255], but actually rendered [128,128,128,255].
    at <Jasmine>
    at validateTonemapper (packages/engine/Specs/Scene/PostProcessStageCollectionSpec.js:414:50 <- Build/Specs/SpecList.js:212703:51)
    at UserContext.<anonymous> (packages/engine/Specs/Scene/PostProcessStageCollectionSpec.js:512:11 <- Build/Specs/SpecList.js:212787:11)
    at <Jasmine>

14) grey
     Scene/PostProcessStageCollection HDR tonemapping ACES
     without HDR: Expected to render [127,127,127,255], but actually rendered [128,128,128,255].
    at <Jasmine>
    at validateTonemapper (packages/engine/Specs/Scene/PostProcessStageCollectionSpec.js:414:50 <- Build/Specs/SpecList.js:212703:51)
    at UserContext.<anonymous> (packages/engine/Specs/Scene/PostProcessStageCollectionSpec.js:530:11 <- Build/Specs/SpecList.js:212804:11)
    at <Jasmine>

15) grey
     Scene/PostProcessStageCollection HDR tonemapping PBR Neutral
     without HDR: Expected to render [127,127,127,255], but actually rendered [128,128,128,255].
    at <Jasmine>
    at validateTonemapper (packages/engine/Specs/Scene/PostProcessStageCollectionSpec.js:414:50 <- Build/Specs/SpecList.js:212703:51)
    at UserContext.<anonymous> (packages/engine/Specs/Scene/PostProcessStageCollectionSpec.js:553:11 <- Build/Specs/SpecList.js:212826:11)
    at <Jasmine>

16) renders with HDR when available
     Scene/Scene
     Expected 250 to equal 0.
    at <Jasmine>
    at packages/engine/Specs/Scene/SceneSpec.js:839:25 <- Build/Specs/SpecList.js:221163:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>
     Expected 250 to equal 0.
    at <Jasmine>
    at packages/engine/Specs/Scene/SceneSpec.js:840:25 <- Build/Specs/SpecList.js:221164:25
    at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
    at <Jasmine>

@ggetz thanks for catching those, I forgot to run all tests and had only verified the new ones work. It seems HDR is not possible in CI? if it is then i'm surprised those ones passed...? Either way they should all be updated now with the new colors as we discussed in person.
I also updated the changelog to hopefully account for everything now.

Thanks @jjspace! I pushed a small change to the specs to allow for a 1-byte tolerance in the render tests. This allowed all the specs to pass on my machine.

Looks awesome! 😎


Add dcos-net setup script, repository cleanup and diagnostics script update

This pull request adds the following updates:

Add dcos-net setup script
Dynamically generate DC/OS dianostics servicelist.txt file with all the running DC/OS agents
Update README
Update spartan-agent-setup.ps1  to reflect the latest changes
Repository clean-up
Remove default IIS website listening on port 80

@yakman2020, @soccerGB, @paulcallen Please review and merge if everything looks fine.

@soccerGB, just included this commit in the PR: https://github.com/dcos/dcos-windows/pull/27/commits/0c5cd34838eebd56874561bc1e0eb8d526eb4e88
This is a cleaner logic to determine the monitored services by diagnostics. Please take a look at it.

I triggered a test right now. If this succeeds, we can merge.

The addition of 2017 runtime installation routine looks good.

@soccerGB Everything looks good. We can merge this.


Bot execute

Hi,
I don't now how to execute the bot ? where execute it and how ?
I can compile it but y don't see executable file.
And how to connecte it with the website ?

#427 #527


pyls refusing to provide diagnostics for files outside first project directory

Not sure if this is a limitation of the LSP plugin or the pyls server, but figured it was worth documenting.
Using python-language-server version 0.11.1, and LSP version 0.4.1.
Steps to reproduce:

Open a new Sublime window
Add a second folder to the project
Enable debug logging for the LSP plugin
Enable the LSP for the project
Open a python file under the second folder
Check the console for LSP: Skipping diagnostics for file /.../second/hello.py  it is not in the workspace

Hi Steven, it's good you found the issue from the logs.
There was some discussion much earlier about supporting multiple folders in https://github.com/tomv564/LSP/issues/33.
As you found in your PR, there are some unknowns in supporting multiple workspaces in LSP - perhaps we can make a subset of LSP work well under clear conditions.

Ok. Didn't see that issue when I was browsing through to see what was causing this.
I think there's some confusion in both the code and the discussion as to what is a LSP workspace vs a Sublime workspace. I'll see about at least adding some comments to the code to clarify that.

It's good this comes up for discussion, I don't expect people to dig through all the old issues :)
We might see some inspiration from VS Code:
https://code.visualstudio.com/docs/editor/multi-root-workspaces
One issue with this package is how configuration is applied:
We only define one set of language server settings in a sublime-project, which has to take care of potentially multiple different root folders.

The reason I opened a ticket is because completion, symbol search, hover, etc worked, but diagnostics didn't. Which definitely surprised me that some language server features would be supported but others not. Probably a good idea to explain the caveat on diagnostics (and other affected features) in the readme.
It does make sense that if you're going to start a separate language server per-project folder, then you'd want to push a different configuration for each one. But at first, I'd just reuse the project config for each folder. Adding an extra level of configuration to be applied (global, user, project - currently) feels like it should be the second half of this.


Set VisualStudioVersion property when no subtoolset is defined.

In previous versions of MSBuild, there is almost always a subtoolset that adds a VisualStudioVersion property.  Since there is most likely not a subtoolset now, we need to add VisualStudioVersion if its not already a property.

@dotnet-bot test OSX Build for CoreCLR please

This will fix https://github.com/Microsoft/msbuild/issues/1678 as well as #2117.

@dotnet-bot test Windows_NT Build for CoreCLR please


first-commit

Update documentation to share on KF documentation website

I have read the CLA Document and I hereby sign the CLA

BTW, I encourage you to use https://github.com/markdownlint/markdownlint to check your Markdown syntax. There is a Visual Studio Code plugin that embeds it to make it really easy to use.


fix: #896 App of apps being overwritten by image-updater

Fixes https://github.com/argoproj-labs/argocd-image-updater/issues/896

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.64%. Comparing base (e06eb69) to head (4b62385).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #918      +/-   ##
==========================================
- Coverage   74.70%   74.64%   -0.06%
==========================================
  Files          31       31
  Lines        3922     3913       -9
==========================================
- Hits         2930     2921       -9
  Misses        856      856
  Partials      136      136

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

the real changes are captured in the screenshot below. findApplicationByName function is deleted and inlined into GetApplication, and the element type of matchedApps is changed from pointer to Application.

We should put out a 0.15.1 with this fix asap.

thanks @jannfis . I'll cherry-pick bug fixes to release-0.15 branch and work on the v0.15.1. https://issues.redhat.com/browse/GITOPS-5813


feat(license): add license header to all go files and and ci for chec…

…king license in new files
Fixes #22
Notes for reviewer
I have create a fresh branch and make changes in this, before i think i messed up something.
Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

@sagikazarmark  can you please review this pr


Status bar regression after enhancing log configurability

See original issue on GitLab
In GitLab by [Gitlab user @tristanvb] on Mar 6, 2018, 13:41
My timestamps in the status bar are now missing brackets, e.g.:
00:12:08[Build:core-deps/WebKit.bst]

In GitLab by [Gitlab user @tristanvb] on Mar 6, 2018, 13:41
[Gitlab user @jmacarthur] I think this one belongs to you.

In GitLab by [Gitlab user @jmacarthur] on Mar 6, 2018, 13:48
assigned to [Gitlab user @jmacarthur]

In GitLab by [Gitlab user @jmacarthur] on Mar 7, 2018, 11:52
mentioned in merge request !308

In GitLab by [Gitlab user @jmacarthur] on Mar 8, 2018, 15:23
Fixed in 9f6ced45.

In GitLab by [Gitlab user @jmacarthur] on Mar 8, 2018, 15:23
closed


Django

Will Django Web Application count as a python project, for this repository?
@OfficialAhmed @geekcomputers

My friend I can't really tell. It's not like the repo about a collection of python scripts, its the owner's work they get to choose what goes in this repo. Adding new scripts is not mentioned in the readme file, you have to ask the owner

Yes, you are right.
I am trying to organize the repository for more formal and practical and using best practices and standards to do so.
Like, all sorted.
But, he seems not to pull requests those changes.
He only pulls file changes somewhere in 10- 20 range, I guess.

@geekcomputers Craig Can you tell me about this query please?

@geekcomputers

@geekcomputers


Duplicate switches in Labs section of settings

Some Labs options have duplicated switches. See attached screenshot:

I believe this is a duplicate of Issue 13, which has been fixed.

Correct, didn't notice that - thanks for the heads up!


Fix component names

I found that ellipsis components' names are not correct.

HorizontalEllipsis -> EllipsisHorizontal
VerticalEllipsis -> EllipsisVertical

Fixed them.

@rhysd Thanks and good catch!


Refactor: remove /pills from /atoms and cleanup Pill

Summary
Closes #7075
Changelog
- Reorganize folders
- Add missing types

Testing
Platforms

Please select any platforms where your changes have been tested.

Desktop

[ ] MacOS
[ ] Linux
[ ] Windows

Mobile

[ ] iOS
[ ] Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...
Checklist

Please tick the following boxes that are relevant to your changes.

[ ] I have followed the contribution guidelines for this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or modified tests that prove my changes work as intended
[ ] I have verified that new and existing unit tests pass locally with my changes
[ ] I have verified that my latest changes pass CI workflows for testing and linting
[ ] I have made corresponding changes to the documentation

I close this PR to reopen a new one and make sure we don't mess with unnecessary files :pray:


CSS fixes for hr, blockquote, and ol

Minor CSS fixes when using withBasicStyles()
Fixes #30

ok, let's start from this step, improve the solution later (on demand). thank you!


@MainActor warnings when calling startRunning/stopRunning on background thread

Hi Paul,
Would you mind adding these two flags to your Package.swift?
I'm facing @MainActor warnings that startRunning/stopRunning did not got called on the main thread.
for target in package.targets {
  if target.type == .binary { continue }
  target.swiftSettings = target.swiftSettings ?? []
  target.swiftSettings?.append(
    .unsafeFlags([
      "-Xfrontend", "-strict-concurrency=targeted",
      "-Xfrontend", "-enable-actor-data-race-checks"
    ], .when(configuration: .debug))
  )
}

Hello! Feel free to open a PR to suggest your changes, and we'll be happy to review it and merge it.


Suggestion about kernels for gp_optimize

I've had a good first experience with skopt!
One thing tha that came up was tuning of the kernel for gp opt. I realize you can pass in your own GP, but a few suggestions on how the default. Currently you have:
https://github.com/scikit-optimize/scikit-optimize/blob/master/skopt/optimizer/gp.py#L227
 if base_estimator is None:
        cov_amplitude = ConstantKernel(1.0, (0.01, 1000.0))

        if is_cat:
            other_kernel = HammingKernel(
                length_scale=np.ones(space.transformed_n_dims))
            acq_optimizer = "sampling"
        else:
            other_kernel = Matern(
                length_scale=np.ones(space.transformed_n_dims),
                length_scale_bounds=[(0.01, 100)] * space.transformed_n_dims,
                nu=2.5)

    base_estimator = GaussianProcessRegressor(
        kernel=cov_amplitude * other_kernel,
        normalize_y=True, random_state=rng, alpha=0.0, noise=noise,
        n_restarts_optimizer=2)

I'm thinking that having the default values / range for the length_scale  be normalized to the range of the parameters would be a good idea.
Also, in addition to the noise argument it could be useful to have an argument that specifies roughly the variability of the function value in the domain of the search. This is provided by the ConstantKernel now. Depending on the application 0.01 might not be small and 1000 might not be large and 1 might not be a good starting point. Maybe the user could provide something like fcn_small and fcn_large  and ConstantKernel( (small+large)/2, (0.01*(large-small), 1000.0*(large-small)).

I've had a good first experience with skopt!

Great, thanks!

I'm thinking that having the default values / range for the length_scale be normalized to the range of the parameters would be a good idea.

The parameters are normalized to the (0, 1) range here. Also, beyond that the length_scale is tuned internally in sklearn so as to maximize the log-likelihood of the data, the values that you supply are just the initial values. (This has been a source of confusion multiple times, see: https://github.com/scikit-learn/scikit-learn/issues/8358

I think my comment also applies to your "variability-in-function" suggestion, In general, you can inspect the kernel parameters by doing gp.kernel_.get_params() after model fitting.

I realize the GP optimizes those hyper parameters, but I didn't realize it was doing this rescaling.
for length scale:
We had to tune the GP kernel to get good results (however that was using the ask/tell API as in this:
https://github.com/cranmer/active_sciencing/blob/reintegration/bayesopt.py
I'm not sure if the normalization of the parameters to (0,1) applies there or if we would have to do it by hand. Maybe that's why we had to tune it.
for "variability in function I also see that you can inspect the parameter of the kernel and provide a custom kernel. Maybe that's enough, but it does seem that the user can provide a generic hint as to roughly the range of the variability of the function without them having good insight into how to construct an appropriate GP kernel given that information. However, I also understand you might not want to add this complication to the API.

Whoops, nice catch! I opened https://github.com/scikit-optimize/scikit-optimize/issues/400 to track that.


Release for multiple Scala versions by default

closing this, the setting is already part of Publishing.scala


feature(List): added list component

Pull Request Test Coverage Report for Build #31

12 of 13 (92.31%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.2%) to 98.765%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

packages/List/src/List.js
7
8
87.5%

Totals

Change from base Build #30:
-1.2%

Covered Lines:
32

Relevant Lines:
33

💛  - Coveralls


WIP: containerized gadgets: Add build/tag/push/pull/list command

WIP: containerized gadgets: Add build/tag/push/pull/list command

ig build --prog-amd64 ./gadgets/trace_tcpconnect_x86.bpf.o --prog-arm64 ./gadgets/trace_tcpconnect_arm64.bpf.o --definition ./gadgets/trace_tcpconnect.yaml ghcr.io/burak-ok/test:latest
This builds the given eBPF ELF files and the definition file into an oci image and saves it on the filesystem
ig tag ghcr.io/burak-ok/test:latest ghcr.io/burak-ok/test2:latest
Adds the second tag to the image referenced by the first tag
ig list
List all local tagged oci images on the filesystemREPOSITORY                     TAG                          DIGEST
ghcr.io/burak-ok/test2         latest                       18e0a9df8e44
ghcr.io/burak-ok/test          latest                       18e0a9df8e44

ig push ghcr.io/burak-ok/test:latest
Pushes the locally tagged image to the given remote repository
ig pull ghcr.io/burak-ok/test:latest
Pulles the tagged image from the given remote repository to the local filesystem

The viper library was added for reading env variables/config. It has excellent support for cobra too as @flyth mentioned.
This is not not the best integration of the library but this PR is more about the ig push command than the viper library.
Using the docker auth is on the to-do list
How to use
One has to set the IG_REGISTRY_USERNAME and IG_REGISTRY_PASSWORD env variables. For ghcr.io i used my github name for the username and an auth token for the password.
Alternativly one can use a config file in the current directory or in ~/.ig/ named config.yaml with the following format:
registry:
  username: "burak-ok"
  password: "ghp_UseYourOwnToken"

Example
$ go run ./cmd/ig/... build --prog-amd64 ./gadgets/trace_tcpconnect_x86.bpf.o --prog-arm64 ./gadgets/trace_tcpconnect_arm64.bpf.o --definition ./gadgets/trace_tcpconnect.yaml ghcr.io/burak-ok/test:latest
$ go run ./cmd/ig/... push ghcr.io/burak-ok/test:latest

which results into https://github.com/users/burak-ok/packages/container/package/test
$ crane manifest ghcr.io/burak-ok/test:latest | jq .
{
  "schemaVersion": 2,
  "mediaType": "application/vnd.oci.image.index.v1+json",
  "manifests": [
    {
      "mediaType": "application/vnd.oci.image.manifest.v1+json",
      "digest": "sha256:5719faf80e2a1d574aea3c643c648502e5e616b09f8b90a8b7fedd0caa748f2e",
      "size": 590,
      "platform": {
        "architecture": "amd64",
        "os": "linux"
      }
    },
    {
      "mediaType": "application/vnd.oci.image.manifest.v1+json",
      "digest": "sha256:bfc3b708670972b9bd0f1d7e64b3f3772c677e0791d39dffa4b9cfa47031ff4f",
      "size": 590,
      "platform": {
        "architecture": "arm64",
        "os": "linux"
      }
    }
  ]
}

Example for amd64:
$ crane manifest ghcr.io/burak-ok/test@sha256:5719faf80e2a1d574aea3c643c648502e5e616b09f8b90a8b7fedd0caa748f2e | jq .
{
  "schemaVersion": 2,
  "config": {
    "mediaType": "application/config.image.inspektor-gadget.io+yaml",
    "digest": "sha256:eb71861c0a5d5ca9a706fffa20fead54f64a1624dfeef5d334a8a3c2462c4c37",
    "size": 628,
    "annotations": {
      "org.opencontainers.image.title": "config.json"
    }
  },
  "layers": [
    {
      "mediaType": "application/ebpf.oci.image.config.v1+binary",
      "digest": "sha256:059d8c8c3a726b24965cb454a4d7cef563b92c26ac7aa17a9aba6d1512f5bc24",
      "size": 866264,
      "annotations": {
        "org.opencontainers.image.authors": "TODO: authors",
        "org.opencontainers.image.description": "TODO: description",
        "org.opencontainers.image.title": "program.o"
      }
    }
  ]
}

I think it's a good foundation for the work we want to do, however I think we should have a more docker-like experience. I was thinking about (related to https://github.com/inspektor-gadget/inspektor-gadget/pull/1856):
# builds an image stored locally (as docker build does)
$ ig build --prog myprog.bpf.c --definition foo.yaml myimage:latest

# tag with remote OCI registry url
$ ig tag myimage:latest ghcr.io/foo/myimage:v1

# show existing images
$ ig image list
# TODO: should we provide delete?, etc?

# push to remote registry
$ ig push ghcr.io/foo/myimage:v1

# pull image to local cache
$ ig pull ghcr.io/foo/myimage:v99

# run image (it'll be automatically pulled if not present)
$ ig run ghcr.io/foo/myimage:v99

I suppose we can use<EMAIL_ADDRESS>to handle the local image cache.

Please read the updated PR description
I added the following commands:

ig build
ig tag
ig list (Without image prefix since we don't have any other image based operations. Can be easily moved later if needed)
ig pull
ig push

ig-run is not implemented yet

Wouldn't it be possible to get a flag for the eBPF object file and one for the architecture?
$ ig push --prog ./foo/bar.io --arch arm64

When building the image I need both ELF files and there a differentiation has to happen. Something with --arch would be needed twice then for a multiarch image

I suppose we can use<EMAIL_ADDRESS>to handle the local image cache.

For locally stored images one has to use<EMAIL_ADDRESS>instead. I also though that this could be a way to ship Inspektor Gadget with preloaded gadgets for environments without internet or connections to outside registries.
For now it is stored in ~/.ig/oci-store. I thought about having a fallback to an in-memory store for cases where there is no home directory (some servers). So at least the gadget can be loaded and be ran. Of course this in-memory store makes only sense for ig run

I'm in agreement with @mauriciovasquezbernal here. This should be a clean and familiar experience. People already know how to work with containers, let's build on that.
Additionally, I'd like to see us have conventions for building. For example, a user should be able to run ig build in a directory and ig build should do a couple things.

Check for a gadget.build file. If that file is found we should the use the information within to build the the gadget.
If that file is not found and there is a .c file (BPF code) and a definition with the same name, build that.
If none of those are found, exit with an explanation.

This allows gadget builders to easily have a gadget.build file along side the code checked into the repo with all the build instructions included.
We should of course offer arguments to override, but that should not be the default and preferred experience.

Check for a gadget.build file. If that file is found we should the use the information within to build the the gadget.

How are you imagining this file? I think it can be a very simple version of Dockerfile, more like a build script that tells ig build the right commands to invoke to build the eBPF objects. I'm even wondering if we could simplify it and just use a Makefile.

Should I remove ig pull completely? With #1875in mind we probably don't need (and want) OCI images on the "client" side.
What would be the use case for ig pull then?

I think it can still be useful for ig when https://github.com/inspektor-gadget/inspektor-gadget/issues/1681 is implemented. Also, in the kubectl-gadget case it could be useful for pre-pulling the images, but we should change the logic to pull that in each node and not on the client.

How are you imagining this file? I think it can be a very simple version of Dockerfile, more like a build script that tells ig build the right commands to invoke to build the eBPF objects. I'm even wondering if we could simplify it and just use a Makefile.

I checked bumblebee's implementation and I think we can follow a very similar approach: It has a build command like bee build INPUT_FILE REGISTRY_REF [flags]. Some interesting things are:

Build is done by using a build script. A default one is provided but can also be changed. (--build-script)
It's possible to compile using the tool chain installed in the local machine or by using a builder docker image provided by the project. (--local option)
It's possible to build the ebpf objects without generating the oci image. (--binary-only)

Update:

Files are moved out of the containerized-gadgets subfolder
Default path for oci-store and config.json (auth) is /var/lib/ig
Added ig login ghcr.io based on https://github.com/containers/common/blob/main/pkg/auth/auth.go#L87

Btw, we have a login command, we should have a logout too. But it can be handled later on.

Added

Looking good overall. Just small comments. I am having issues testing it via complied ig command. (go run -exec sudo ./cmd/ig ... works fine):

Running it with GODEBUG=netdns=go ig image.... should work. Analysis still has to be done why.

Also, if I build with -tags osusergo netgo static_build (reference) it also works fine. But I am not sure if that is right solution.

The introducing commit seems to be https://github.com/containerd/containerd/commit/efc5df577382e4990c16348f4db4b55563d9177e

When compiling containerd binaries statically, linker rightfully
complains:
+ make BUILDTAGS=static_build 'EXTRA_FLAGS=-buildmode pie'
'EXTRA_LDFLAGS=-extldflags "-fno-PIC -static"'
🇩 bin/ctr
/tmp/go-link-343047789/000000.o: In function
`_cgo_b0c710f30cfd_C2func_getaddrinfo':
/tmp/go-build/net/_obj/cgo-gcc-prolog:46: warning: Using 'getaddrinfo'
in statically linked applications requires at runtime the shared
libraries from the glibc version used for linking

The same error appears for ctr, containerd, and containerd-stress
binaries.
The fix is to use Go's own DNS resolver functions, rather than
glibc's getaddrinfo() -- this option is turned on by netgo build
tag.
See https://golang.org/pkg/net/ (look for "Name Resolution") for
more details.
Signed-off-by: Kir Kolyshkin<EMAIL_ADDRESS>

Compiling gives me the same messages:
➭ go build -ldflags "-extldflags '-static'" github.com/inspektor-gadget/inspektor-gadget/cmd/ig
# github.com/inspektor-gadget/inspektor-gadget/cmd/ig
/usr/bin/ld: /tmp/go-link-774727284/000032.o: in function `pluginOpen':
/_/plugin/plugin_dlopen.go:19: warning: Using 'dlopen' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
/usr/bin/ld: /tmp/go-link-774727284/000013.o: in function `mygetgrouplist':
/_/os/user/getgrouplist_unix.go:15: warning: Using 'getgrouplist' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
/usr/bin/ld: /tmp/go-link-774727284/000012.o: in function `mygetgrgid_r':
/_/os/user/cgo_lookup_cgo.go:45: warning: Using 'getgrgid_r' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
/usr/bin/ld: /tmp/go-link-774727284/000012.o: in function `mygetgrnam_r':
/_/os/user/cgo_lookup_cgo.go:54: warning: Using 'getgrnam_r' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
/usr/bin/ld: /tmp/go-link-774727284/000012.o: in function `mygetpwnam_r':
/_/os/user/cgo_lookup_cgo.go:36: warning: Using 'getpwnam_r' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
/usr/bin/ld: /tmp/go-link-774727284/000012.o: in function `mygetpwuid_r':
/_/os/user/cgo_lookup_cgo.go:27: warning: Using 'getpwuid_r' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
/usr/bin/ld: /tmp/go-link-774727284/000009.o: in function `_cgo_cbcce81e6342_C2func_getaddrinfo':
/tmp/go-build/cgo-gcc-prolog:58: warning: Using 'getaddrinfo' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking

Thanks for finding https://github.com/containerd/containerd/commit/efc5df577382e4990c16348f4db4b55563d9177e it. Looks good to me. Can you please create a commit with message like https://github.com/containerd/containerd/commit/efc5df577382e4990c16348f4db4b55563d9177e and then we should be good. We can always revisit it in case we have any issues.


AutoHotkey

I've programmed AutoHotkey to rewire my "home" and "end" keys which works great, but with the latest Visual Studio Code it does not work.  Here are my AutoHotkey mappings:
PrintScreen::Home
Insert::End
RCtrl::PrintScreen

The above script worked correctly with prior versions of Visual Studio Code.  And to reiterate, those mappings still work correctly elsewhere (such as the Sublime editor or in notepad).

VSCode Version: 1.5.2
OS Version: Windows 10 Enterprise, 64bit

Steps to Reproduce:

Open Visual Studio Code.
Open any file with text in it.
Try using AutoHotkey shortcuts / hotkeys.

The AutoHotkey hotkeys will not work.

I've now upgraded to VSCode 1.5.3, and this problem has been resolved!

Unfortunately, the problem has returned. I am now using VSCode 1.11.2.  This is the same problem, with the same autohotkey mapping.
I saw in another thread someone suggesting a change to vscode configuration:
"keyboard.dispatch": "keyCode"
A "keyboard.dispatch" is not a valid "user settings" or "workspace settings" option for me.

@brentarias
So this AutoHotkey script worked in VSCode 1.10.2 -- https://az764295.vo.msecnd.net/stable/8076a19fdcab7e1fc1707952d652f0bb6c6db331/VSCode-win32-1.10.2.zip
But does not work anymore in VSCode 1.11.2 ?
On Windows, we are always dispatching on keyCode, that's why the setting is invalid and the keybindings changes should have no impact on dispatching on Windows.

Yes is works correctly on the 1.10.2 version (as you provided in the link) but does not work on 1.11.2.

I just updated to vscode 1.12.0.  The problem is fixed (again)!

I just updated to vscode 1.12.1.  The problem is back again!

@brentarias This makes no sense to me. There was no code change between 1.12.0 and 1.12.1 except for fixing a packaging issue.

I am now using version 1.12.2.  The problem is resolved (fixed) again.
I can't explain this either.  I'm simply reporting what I see.

@brentarias Could there be something else on your system (unrelated to VS Code) that might make an impact. Or perhaps this works / stops working only under certain circumstances? (e.g. using it at the beginning of a line, at the end of a line, in the middle of text, etc.)

I've tried experimenting with when and where this works or does not work.  It always works in OneNote, as well as Skype, Discord, and Slack desktop clients.  It always works in (browser window) gmail, notepad, git bash prompt, Windows Subsystem for Linux (WSL) bash prompt, and the cmd.exe prompt. It works inside this markdown / form input that I'm typing in right now.
It does not work at the powershell prompt, in SSMS, or in Visual Studio 2015.
VSCode is the only place it sometimes does or does not work...all determined by changing versions of VSCode (as my reports have indicated).  Re-loading VSCode or rebooting the machine does not change the behavior.
It does not matter where in a line I use the command: beginning, end, middle...if it works it works completely correctly.  If it does not work, it simply does not work at all.
The behavior is not "flaky".  For example, I said that it started to work again in 1.12.2.  It has continued to work successfully in 1.12.2 all day long (I give VSCode a huge beating all day) and is working right now in VSCode.  Only changing versions of VSCode has influenced the behavior.

On StackOverflow, I've found the solution to this problem: https://stackoverflow.com/questions/1890351/why-is-visual-studio-catching-key-events-before-autohotkey

If ahk and the target app are not running under the same privileges (or user) ahk won't intercept/simulate keyboard events properly. In my case, visual studio was run with administrator (elevated) privileges while the ahk script was run as the currently logged on user.
Either of the following solved the problem:

Running both vs and ahk as the current user
Compiling the script and running both vs and the compiled app as administrator

For me, running AHK as administrator fixed the issue!

Closing for now, as there appears to be no changes to be done in VS Code.


Tensor parallel

I want to use tensor parallel with lookhead, but I do not find the  config to start the tensor parallel, can you give me an example?

Tensor parallel is not compatible with lookhead yet.
You can choose only to use tensor parallel (and no lookahead). L28-L35 in your figure is an example if you set GPUS larger.

Is tensor parallel available now?


Fast-serve update to match the most recent changes.

Q
A

Bug fix?

New feature?

New sample?

Related issues?

What's in this Pull Request?
The recent updates in the fast-serve tool introduced some additional performance improvements as well as setup simplicity. This PR introduces support for the latest version of fast-serve.

@s-KaiNet thanks again! This is now merged


[Feature Request]_Pinn_File_Loading

Description
Implement a mechanism for loading pinning files into the AyonUsdResolver
Rationale
TODO

[x] Pinning file loading into the cache
[x] disconnect cpp API from resolver at startup

Proposed Solution
No response
Alternatives Considered
No response
Additional Context
No response
Impact
No response
Assumed Complexity
No response
Impact Scale
No response
Other tools that get touched
No response
Is there an existing issue with this?

[X] I have searched the existing issues

Are there any labels you wish to add?

[X] I have added the relevant labels to the bug report.

this is finished as of merge for Feature/23 feature request pin file loading


List linked

Hi
I have 2 dropdown. dropdown 1 and dropdown 2.
I would like generate the items of the dropdown 2 in function of the items selected in the dropdown 1.
I don't know how I can build this.
If you can help me,
Thanks.
Franck

@fsebbah You can set options for dropdown2 onselect event of one item from first dropdown. I have attached example how you can set dropdown2 on selection of dropdown1.
Plunkr:
http://plnkr.co/edit/DfGN12QPHLjqaD4UgF2D?p=preview

Hi Ashviniv,
Thanks for you example and for AngularJS Dropdown Multiselect.
Can you say if it's possible to apply css style ?
Thanks,
Franck

@fsebbah Yes you can apply css style to multiselect dropdown. You just have to add buttonClasses: "btn btn-success" or any style you want to add in the settings attribute.
I have updated the above plunkr with css style applied on it.


Enterprise 128 Support Missing

Hi,
Happy New Year!
According to the wiki the Enterprise 64 and 128 are supported however there's no entry in es_systems.cfg and the core is not in the retroarch's core folder.
Is this a documentation error or was it intended to be available?
ER

Happy New Year to you as well.  Did you update to at least the 12/15/2023 update of ArkOS?

Not yet.  I will when I get home so I can make a backup of the SD CARD.

I bit the bullet and did the upgrade.  Looks like it worked well.

Yea those should be done from time to time to get new OS updates.  Those updates don't include retroarch or retroarch32 core updates.  You an do those directly from within retroarch.  You can see the changelog for OS updates for your particular device here: https://github.com/christianhaitian/arkos/wiki/Changelogs

Gotcha.   I'm thinking about adding TRS-80 Coco / XRoar siupport.  This device is amazing and your OS takes it over the top!


Update User's guide “convert-a-c++-program”

Automatically generated by Netlify CMS

Hi @timkaler  I have implemented a way to display attribution to Intel and Cilk Arts. If you think this article should credit them, then could you please find the new switch in the CMS editor ("provide attribution to Intel and Cilk Arts") or manually add attribution: true to the front matter. If you set the field to true, then the attribution still won't actually display until this PR is merged with the main branch. (A little more info is at #62.) Thank you.

Hi @timkaler would it be OK with you if I edited this article? Based on feedback we heard from Charles (e.g., use cilk_scope and make it more conversational) I could go through the whole thing, and then maybe we could ask Alex or Charles to give it a final review before publishing.
There is a lot of good content in here, so I hope we can publish it soon.

Thanks @timkaler for this excellent draft. I reviewed and made small stylistic changes along a few lines listed below.
I think this is good to go after we make sure that our qsort.cpp example is consistent across this article and the Cilkscale user's guide. This includes inline code, related discussion points, and the Cilkscale plots. @ailiop would you like to review these two with that in mind?
My sylistic edits:

Less formal (more "conversational")
More consistent with the Cilkscale user's guide
Adding a "Discussion" section, which holds the part about improving performance of partition

@ailiop and @timkaler could one of you please review this to make sure it's ready for publication? Thank you. (I edited it many months ago and it fell through the cracks.)
https://deploy-preview-102--sage-licorice-6da44d.netlify.app/doc/users-guide/convert-a-c-program/


Added SystemGenerator and tests

This adds SystemGenerator, a wrapper for generating OpenMM systems from Topology objects with prespecified options.

Local tests pass, so merging.


Max: OP parameters only displays what is attached to the container

Changelog Description
The OP parameter in 3dsmax only displays what is currently attached to the container while deleting while you can see the items which is not added when you are adding to the container.
Additional info
n/a
Testing notes:

launch Max with OP
create instance
Go to OP Parameters -> Add to Container
Add something
Add again and it will only display the items which are not added into container
Go to OP Parameters -> Delete from Container
It will only display what is currently attached to the container

@LiborBatek the update would filter out the container or any container objects.

Code is looking good. @LiborBatek when you confirm function in DCC, we're ready for merge

yeah it works ok.

There need to be resolved the issue when add to the container:
Steps to reproduce this error:

create some objects and select few and hit "Add" to Container (model Instance in my case)
repeat and hit "Add" for adding more objects
Error appears

It should be fixed now after removing the duplicated line in maxscript.


[8pt] Add memory profile to new GMS pages

Memory profiling system exists in FIM3 as an optional use system. This needs to be added to most new GMS pages.

The memory profiler system has not been used in a few years and we are now about to shut it down.


Bug: focus on Orte-Layer

After searching for a place, the page always focuses/centres on the searched place, even if I select another place by clicking on the place with the mouse. E.g. if I search for Salzburg and then move the map to the east and click on Burgenland, the map resets it's focus on Salzburg.

fixed in https://github.com/acdh-oeaw/youbeon-frontend/commit/9aaa8aa5470f7fc900098278f3417fa50587fac6


Unexpected behaviour with array of hashes

Describe the bug
Reusing a schema directly in the the array macro produces an unexpected exception when passed bad data.
To Reproduce
NestedHash = Dry::Schema.Params {
  required(:code).filled(:string)
}

Parent = Dry::Schema.Params {
 required(:nested).array(NestedHash)
}

## Exception
result = Parent.call(nested: [[]])
/vendor/ruby/3.0.0/gems/dry-logic-1.2.0/lib/dry/logic/predicates.rb:25:in `key?': undefined method `key?' for []:Array (NoMethodError)

If you correctly pass it in an array of hashes it will happily work
Expected behavior
Should work the same as the long form expression; or not work at all.
Parent = Dry::Schema.Params {
  required(:nested).array(:hash).each(NestedHash)
}
result = Parent.call(nested: [[]])

My environment
Running the latest and greatest versions of dry-schema (1.9.2)

What about required(:nested).array(:hash, NestedHash)?

Yes, this syntax also works in my scenario.

OK so this is because passing a schema to array(...) doesn't assume a hash type check. It's tempting to say this should be  the default though because that's your natural assumption when you want to apply a schema to array member.

I guess can a schema by anything but a hash? if not than i think setting :hash would be a sensible default.
Judging by the exception; dry-schema itself thinks that a schema should be a hash.

Yes it assumes a hash but that's just because applying a schema doesn't have hash? check applied by default, there's a reason for this - predicates must be granular because otherwise you'd lose the ability to perform fine-grained checks. ie maybe you want to check if something is a hash, has 3 keys and then apply a detailed schema (for whatever reason).
Anyhow, that's why we have macro methods that combine complex checks for you :) Like I said, passing an instance of a schema could assume you want hash? check as well. Looks like it's not consistent with the #call API though, because if you ie do schema.call(nil) it would not crash and return a failure that defined keys are missing.
I need to dig into this more to figure out a good solution, but it sounds like a 2.0.0 task, because it may potentially be a breaking change.


Tabular: Added Adaptive Early Stopping

Issue #, if available:
Description of changes:

Added Adaptive Early Stopping to LightGBM.

TODO:

[ ] Benchmark

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Job PR-1042-1 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1042/1/index.html

Job PR-1042-3 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1042/3/index.html


counter of container /sys/class/net/eth0/statistics/rx_packets not increase

Is there an existing issue for this?

[x] I have searched the existing issues

What happened?
We are faced with the following problem. The problem is reproduced as follows:

deploy any pod
ping the pod address 10 times per second
the counter /sys/class/net/eth0/statistics/tx_packets is growing correctly - ~ 10 per second
counter /sys/class/net/eth0/statistics/rx_packets - not growing

Has anyone encountered such a problem? (The problem is not related to the node, because if the pod uses the hostNetwork parameter, the counter will work correctly)
Cilium Version
1.13.2
Kernel Version
5.14.0-168.el9.x86_64
Kubernetes Version
1.27.1
Sysdump
No response
Relevant log output
No response
Anything else?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

The problem is that we use cAdvisor to collect network statistics on containers. cAdvisor focuses on counters inside the /sys/class/net/eth0/statistics/ folder. Because of this, we do not get correct network statistics on containers at the network level.

Okay, this is unlikely to change I think. You can try disabling features which bypass the host network stack, at the cost of lower throughput. The other option would be to see whether our metrics can help: https://docs.cilium.io/en/stable/observability/metrics/
Otherwise it might be nice to document this fact so that others with the same question can benefit.

Can you provide guidance on disabling the features that are causing this issue? Is it still possible to use BPF and have these metrics be correct?

This has been fixed in the kernel via<EMAIL_ADDRESS>(this one specifically<EMAIL_ADDRESS>)

@borkmann Thanks! Closing this.


Implement NMODL kinetic schemes

Like it says on the tin!
Step 1: extend modcc to parse them.

Subsumed by #60


feat: resetQueries refetches active queries

This is a follow up to #1375 that, I think, makes resetQueries more useful and less surprising.

Excellent :)

:tada: This PR is included in version 3.2.0-beta.39 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Doesn’t work for newer versions

This plugin and as most Snipcart plugins don’t work with Gatsby anymore. From what I can tell, any version about 3.0.6 will not work in Gatsby. Unless I’m doing this wrong please find a fix as this isn’t really usable with the default values.

@MrRobotjs yes the latest version doesn't work. I'm using the default which is 3.0.15 and it works fine for now.

Curious why this doens't work on versions above 3.0.6? What changed in snipcart to make this plugin not work?

Curious why this doens't work on versions above 3.0.6? What changed in snipcart to make this plugin not work?

I look that soon

I look that soon

Thanks. That would be great.

Thanks. That would be great.

Any update? None of the plug-ins support new versions which is a huge issue. 3.0.28 fixes an issue where users weren’t able to reset their password because the “forgot your password?” didn’t exist. I’d look into it myself but I’m sadly not experienced enough to tackle this issue.

i have test just now the 3.0.28 version and i haven't problem. What bug have you ?


Incorrect info in the swagger

Inside the schema of a creature, resistances, weaknesses and speeds display "additionalProps", while they should be key:value pairs

We should reuse this issue to tackle the growing amount of random data spewed by the swagger. This could be done either by specifying directly a description, default values, examples OR by finding some convenient macros to handle special types


Fixed few minor typos

Fixed a few typos and duplicated words.

Awesome, thanks. I'm going to review this.

@Thraka Hi Andy. When the updates look okay, please sign off to get the pull request into the approval workflow. Thanks.

#sign-off


Destructuring assignment and variable declaration conformance tests

Conformance for spec change 4.17.1, 5.1.2 [See] (https://github.com/Microsoft/TypeScript/pull/1878)

While it's not valid, it would certainly be useful to have tests for binding pattern variable declarations with no initializers as we discussed today.


Entries aren't properly quoted

If an entry contains a comma, it will be interpreted as two (or more) entries. Desired behavior would be to surround the entry in quotation marks (which Excel will correctly process). Furthermore, quotation marks are also not properly encoded, though they are much less likely to be used. (They must be duplicated to be properly interpreted)
Examples:

input
CSV

high, mid, low
"high, mid, low"

said "super awesome"
said ""super awesome""

supposedly "simple, fast, and cute"
"supposedly ""simple, fast, and cute"""

Fixed by 5b22888


Use dynamic spaces for running consumer tests

Currently, the consumer tests are failing because of the parallel deployments to the same cf space. On the other hand, the test project still uses the old classic mta build tool.
Hence, this PR uses cloudmta build tool and creates dynamic spaces, deploys and deletes them in the end.

The master branch is not the one that is tested. Rather it is the 'piper-test-cap' branch that needs to be adjusted.

On the other hand, the test project still uses the old classic mta build tool.

I got the impression this was on purpose. Do we need to change this for the dynamic space creation to work?

Dynamic space usage works regardless of the build tool. But, I would like to clean it up. @marcusholl already clarified that it was not intentional and also change was made long ago somewhere near February.

@marcusholl already clarified that it was not intentional and also change was made long ago somewhere near February.

Story behind this is: When we started with introducing the new mbt toolset we had to ensure that - for the time being - the old toolset was always used, like it was the case at that point in time for the customers. We also suggested for the customers to explicitly denote the old version. In the meantime the new version is out for a longer period of time and it is time to switch also the example project to the new toolset since I expect the waste majority of customers are using the new new toolset as well.

I will run the one cosumer test for this test case locally on my machine to check if it works... (Of course it would be better to have that automated)

I will run the one cosumer test for this test case locally on my machine to check if it works... (Of course it would be better to have that automated)

I have tested it from my end already. Ofcourse, you can also test it.

@o-liver Do you still have any concerns w.r.t to this PR? We have already checked that the pipeline works.


Remove direct dependency on decorator package

Closes https://github.com/dwavesystems/dwave-networkx/issues/212
No longer depend on decorator directly. Newer NetworkX packages also remove their dependency so for those versions it won't be installed at all.
I did remove some of the (IMO) unneeded documentation, but I left the previous implementation more-or-less intact. Probably there is some refactoring that could be done there as well but if it isn't broken...

Codecov Report

Merging #213 (3f73497) into main (34ae89a) will increase coverage by 0.11%.
The diff coverage is 89.28%.

@@            Coverage Diff             @@
##             main     #213      +/-   ##
==========================================
+ Coverage   71.32%   71.43%   +0.11%
==========================================
  Files          29       29
  Lines        1761     1768       +7
==========================================
+ Hits         1256     1263       +7
  Misses        505      505

Impacted Files
Coverage Δ

dwave_networkx/utils/decorators.py
90.62% <89.28%> (+2.62%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34ae89a...3f73497. Read the comment docs.


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/114613

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/114821

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/117278

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/117434