Support account:setup in a non interactive mode

Currently the account:setup command is marked with a forceInteractiveMode flag.
It would be great if it will support also a non interactive mode to enable calling it using JS in one shot.

This feature enhancement is already under consideration. We are currently evaluating different options/approaches. Thanks for bringing this up.

@alii-gator do you have any rough estimation when it will be implemented?

@omrilit Unfortunately at this point we are not able to give any estimate. But it's something we are actively looking into. So stay tuned for any updates on this.

any update on this please?

this is very stupid, I don't understand how you could not consider it in an initial stage. It makes the tool useless for any automation tool.

@omrilit , this is already in our backlog and it will be as soon as we can deliver it, this is the first iteration of this tool and we are working to improve the experience. Thank you for sharing this need, it definitely validates implementation and it will be there.

@bretislav , We will release the update as soon as we get it done. We are working in our release cycles and since this is the first time for us to expose a product as open-source, we still need to align some processes before pushing changes as fast as it might be expected. Thanks for the patience, we will improve in time.

@adamkundrat I guess that you can read what I expose above, and please the next time do not refer to our efforts as something stupid. If you have questions or suggestions, they can be done in another tone.  For what it worth, this is the first version of something completely new and we are aware of this opportunity of improvement, it will be solved as soon as possible.

@omrilit
This is now fixed/available in latest version
get the latest npm package version 1.1.0
checkout account:ci command

1.1.0 is a massive improvement. Good work and thanks!


Anexia Provider: Configure dns servers

What this PR does / why we need it:
Add dns server configuration to vm definition
What type of PR is this?

/kind feature
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:

Anexia Provider: Enable up to 4 custom dns entries

Documentation:

NONE

@ahmedwaleedmalik we'd love to get a backport of these changes in v1.5.4

/cherry-pick release/v1.56

/cherry-pick release/v1.54

/retest

/retest

/retest

/override pull-machine-controller-e2e-aws-spot-instance
unrelated


Support for 3rd party layouts

Many great external and 3rd party layouts exist for Cytoscape.js, for example:

Dagre: https://github.com/cytoscape/cytoscape.js-dagre
Euler: https://github.com/cytoscape/cytoscape.js-euler
Spread: https://github.com/cytoscape/cytoscape.js-spread
Klay: https://github.com/cytoscape/cytoscape.js-klay

In order to be used, they need to be added as a dependency to the Dash Cytoscape package, i.e. modify the source code located at src/lib/Cytoscape.react.js. If we do this, the distribution will become heavier, but worth it if many people use those.
Is this a feature that the community would be interested in? Please let us know in this thread!

We might find the Klay layout interesting to have.

Yes! :) That would definitely be a very useful inclusion according to me. Thanks @xhlulu

Yes! Dagre or sugiyama layouts are very nice for control-flow diagrams

@vetertann Could you share me the link to sugiyama layout?

@xhlulu Oh, sorry. I only meant that Dagre is based on techniques from the Sugiyama paper. I don't know any other sugiyama implementation for cytoscape..Except for yFiles, but those are not free.
(Support for iGraph might be a "tough" workaround though: it has sugiyama layout, I use it with Dash cytoscape only as layout generator, and the results are great)

@vetertann @Akronix @vivekvs1 I've opened a working branch for the external layout! I've added a few of the officially supported 3rd party layouts to dash-cytoscape. Here it is: https://github.com/plotly/dash-cytoscape/tree/external-layout-experiments
Please check out the usage-events.py and usage-elements.py to see the layouts in action! It is not deployed on Pypi so you will have to clone and create your own venv. Please read the CONTRIBUTING and README for more details on the setup.
I can't merge it yet, since I'll need to run some tests, and optimize the package size and the startup time. For now, feel free to try out the WIP version and lmk your thoughts!

Wow thanks @xhlulu. That was very fast. I shall give it a try and update.

That was fast:) thank you!

This issue will be closed once https://github.com/plotly/dash-cytoscape/pull/46 will be merged.

@xhlulu  Just tried our the new layouts- just amazing. Really love the 'dagre' layout. Very smart presentation!


Angular static page Przyjdź na dyżur

Static page "przyjdź na dyżur" moved to Angular. #637

Codecov Report

Merging #774 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #774      +/-   ##
==========================================
+ Coverage   91.55%   91.56%   +0.01%
==========================================
  Files          99      100       +1
  Lines        2830     2834       +4
  Branches        7        7
==========================================
+ Hits         2591     2595       +4
  Misses        230      230
  Partials        9        9

Impacted Files
Coverage Δ

frontend/src/app/static/office/office.component.ts
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ce3af7...4668dda. Read the comment docs.


GitHub: create issue templates

Add issue templates for bug reports, feature requests and questions.

@EmileRolley, you might need to rewrite your git history before @yurug merge. Maybe only one single commit is needed.

@EmileRolley, you might need to rewrite your git history before @yurug merge. Maybe only one single commit is needed.

I think using the Squash and merge option is good enough no?


Updated for Swift 4.0.2, removed character references.

Removed character references and updated references to swift 4.0 to swift 4.0.2. Also updated Travis to latest Xcode release (Xcode 9.1).

Codecov Report

Merging #38 into master will not change coverage.
The diff coverage is 60%.

@@           Coverage Diff           @@
##           master      #38   +/-   ##
=======================================
  Coverage   73.42%   73.42%
=======================================
  Files           3        3
  Lines         444      444
=======================================
  Hits          326      326
  Misses        118      118

Flag
Coverage Δ

#SwiftKueryPostgreSQL
73.42% <60%> (ø)
:arrow_up:

Impacted Files
Coverage Δ

Sources/SwiftKueryPostgreSQL/Utils.swift
89.47% <100%> (ø)
:arrow_up:

...SwiftKueryPostgreSQL/PostgreSQLResultFetcher.swift
88.23% <50%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95b5378...253f31d. Read the comment docs.


refactor: use AsyncDIspose

This is not going to work in Jest until it defines Symbol.dispose and Symbol.asyncDispose in the test environment in a stable version (currently available since v30-alpha.3)
jestjs/jest#14888


[FR] Localize term Cloud Computing

Localize term Cloud Computing in french language

@guillaumebernard84 will localize this term

Fixed by #2272


set attributes is not updated to database while calling save with patch option

hi all, I found that there is weird issue on save & set
and the version of bookshelf.js is 0.10.3
// js code
const model = await Model.forge({ id: 5 }).fetch();
model.set('attr_a', 'some value');
await model.save({ attr_b: 'some value' }, { patch: true });

above operations only update attr_b to database.
In other ORM such as ruby's ActiveRecord, it will update both attr_a & attr_b
// ruby code
model = Model.find(5);
model.attr_a = 'some value';
model.attr_b = 'some value';
model.save!

Does it make sense that changed attributes should be updated to database no matter what these attributes are changed by set or save method ?

According to the docs, the patch option when set to true:

Only save attributes supplied in arguments to save.

So it's working as intended. If you leave out the patch option it will probably do what you expect.

@ricardograca thank you for reply, I've read that docs before.
let me clarify my question again,
Is it better that calling save() with patch option not only "save attributes supplied in arguments to save()" but also "save attributes changed through set()" ?
In my opinion, it will make virtual attributes less powerful if patch option only supplied in arguments of save()
// definition of user
const User = Base.extend({
  tableName: 'users',
  hasTimestamps: true,
  virtuals: {
    password: {
      get() {
        return '';
      },
      set(value) {
        const cryptedPassword = bcrypt.hashSync(value, config.auth.bcryptSalt);
        this.set('encrypted_password', cryptedPassword);
      },
    },
  }
}

// example for user who want to change password
const user = User.forge({ id: 5 }).fetch();
user.set('password', 'new-password-here');
await user.save();  // it will encrypt password and save it to encrypted_password column.

if we called save with patch option
await user.save(null, { patch: true });

it will throw a error since password is not defined in user schema.

thanks for reply, I've read that docs before.
let me clarify my question again:
Is it better that calling save() with patch option not only update attributes passed to save() method but only includes previous changed attribute through set() method ?

So, your use case for this is that you use set() to set some values but don't save the mode, and then later on when saving you add some more attributes to be changed? I don't see the advantage of using patch: true in that case. Is it just a performance issue?

Closing this since the wanted effect can easily be achieved by a small change to the original code:
const model = await Model.forge({ id: 5 }).fetch();
model.set('attr_a', 'some value');
model.set('attr_b', 'some value');
await model.save(null, { patch: true });

Hi! I understand that the issue is closed. Still, I wanted to say that I faced the exact same situation, and this issue actually helped me.
The docs are very clear indeed, @ricardograca. But it still took me a while to figure out what was happening.
I think this behaviour can come off as unexpected, specially if the model has "saving" handlers setting some of its values. This was my case - I was doing some math operation and setting the result as the model's attribute value. It was working fine - except when updating a model instance. The calculated field was not being updated, even though the handler was updating it, and the attribute was marked as changed before the save -- which seemed strange to me.
Buuuut, you know, the docs are correct. Just thought I would present an use case for this.

Right, so what do you propose @marianacapelo? Reword the documentation to make it clearer? Or maybe just remove the {path: true} option since it's value is debatable?

I'm really sorry for the delayed response...
I didn't get a chance to test this, but would it be wrong to save all the updated attributes with the {patch: true} option? This way we would still be respecting the "patch" action, and not leaving updated values behind.

@marianacapelo Can you provide a code example of you use case?

@ricardograca, here's a sample for my use case.
In both save actions (insert and update with patch option) the calculatePrice handler is called, and unit_price attribute is correctly updated and marked as changed, but the patching only takes into account the attributes sent as argument for the save method - and so the unit_price value is not updated in the last case.
/**
 * Model for item table - with AI `id`, numeric `unit_price_wo_tax`, `tax` and `unit_price` fields, etc.
 */
const Item = Bookshelf.Model.extend({
  tableName: 'item',

  initialize() {
    this.constructor.__super__.initialize.apply(this, arguments);
    this.on('saving', this.calculatePrice);
  },

  /**
   * Calculates and assigns unit_price attribute value.
   */
  calculatePrice(model, attrs, options) {
    const priceWithoutTax = this.get('unit_price_wo_tax');
    this.set('unit_price', priceWithoutTax + priceWithoutTax * this.get('tax'));
    console.log(this.hasChanged('unit_price')); // always logs true
  },
});

// Creating item instance
const instance = await Item.forge().save(
  { unit_price_wo_tax: 10, tax: 0.23 },
  { method: 'insert' }
);
console.log(instance.attributes); // shows unit_price of 12.3

// Fetching item instance and updating unit price without tax
const sameInstance =  await Item.forge({ id: instance.get('id') }).fetch();
await sameInstance.save({ unit_price_wo_tax: 100 }, { method: 'update', patch: true });
console.log(sameInstance.attributes); // shows unchanged unit_price of 12.3

@marianacapelo You don't actually need the patch: true option in that case. If you leave it out you get the results that you need. The only use case for that option is performance.
So, on one hand I think it makes sense to change the patch functionality to use only changed attributes, and it's an easy change to make. On the other hand that would break backwards compatibility and it's possible someone has the opposite use case, that is, is expecting only the attributes passed to save() to be present in the query, but somehow I doubt it.
I'll reopen this and add it to the version 1.0 project for consideration.

patch: true is really handy to avoid race condition
if you have model updated in few places at the same time (happens for user entity pretty often) you can get some property overridden
End up with my own attempt of implementing save fuctionality:
async saveModel(attributes?: Partial<CustomUserModelAttributes>, options?: SaveOptions) {
    if (options) {
        return super.save(attributes, options);
    }

    if (attributes) {
        this.set(attributes);
    }

    if (this.hasChanged()) {
        await super.save(this.changed, { patch: true });
        // dirty hack
        if (attributes) {
            Object.keys(attributes).forEach(key => {
                (this as any)._previousAttributes[key] = attributes[key];
            });
        }
    }
}

The problem is if you call set then save with patch: true and check _previousAttributes you'll see old value, so all consequence call of mine saveModel method fails.
Maybe this can be fixed on library level

Why were you expecting previousAttributes to have anything other than the previous attributes?

sorry, probably I described situation not so clear
let's imaggen our model has 'notes' field:
const user = await User.byEmail(email);
console.log('1', user.attributes.notes); // => 1 null

await user.save({notes: 'Test'}, { patch: true });
console.log('2', user._previousAttributes.notes); // => 2 null

await user.refresh();
console.log('3', user._previousAttributes.notes); // => 3 Test

I am expecting on the second step to get "Test" not null.
I agree that playing with private variable is not so good, but I do it just to investigate reason of next issue:
if I call after second step user.set({notes: null}) then user.hasChanged() will return false which breaks everything for me, so I have to do this hack with manually updating previousAttributes

Ok, so your actual problem is that hasChanged() returns false even though you just changed the value of notes to null. Seems like a bug to me, but is not related to this issue (I think).

Alright, agree. I initially thought that it was due to { patch: true } but additional investigation shows that without this option it works the same way.
so created a new issue - #2087

Ok, let's continue discussion here.
My deeper investigation shows that issue with hasChanged() is actually due to the problem with previousAttributes(), though
set method of base model.js
ModelBase.prototype.set = function(key, val, options) {
  if (key == null) return this;
  let attrs;

  // Handle both `"key", value` and `{key: value}` -style arguments.
  if (typeof key === 'object') {
    attrs = key;
    options = val;
  } else {
    (attrs = {})[key] = val;
  }
  options = _.clone(options) || {};

  // Extract attributes and options.
  const unset = options.unset;
  const current = this.attributes;
  const prev = this.previousAttributes();

  // Check for changes of `id`.
  if (this.idAttribute in attrs) this.id = attrs[this.idAttribute];
  else if (this.parsedIdAttribute() in attrs) this.id = attrs[this.parsedIdAttribute()];

  // For each `set` attribute, update or delete the current value.
  for (const attr in attrs) {
    val = attrs[attr];
    if (!_.isEqual(prev[attr], val)) {
      this.changed[attr] = val;
    } else {
      delete this.changed[attr];
    }
    if (unset) {
      delete current[attr];
    } else {
      current[attr] = val;
    }
  }
  return this;
};

Inside loop - `if (!_.isEqual(prev[attr], val)) {

it compares provided attributes with value from previousAttributes()
since previousAttributes kept unchanged at this point isEqual return false (it is keeping null and we are trying to set null)
changed object left unchanged;
hasChanged relies on changed object

Can you include hasChanged() in an example? Because I still can't visualize exactly what your problem is.

const user = await User.byEmail(email);
await user.save({notes: 'Test'});
user.set('notes', null);
console.log(user.hasChanged());

Output is false

you can do it with any property, just try to set it to the default value on line 3

Got it. That helps, thanks.


Start of the code review process 👋

Hello Prabesh 👋 , thank you for your effort on the code submission. I am Olivier from Nimble, and I am happy to be the reviewer for our code review session.
During the review process, I would like to know more about your decisions, so I will create issues in some areas where there could be more improvements regarding your submission. Since solving every possible problem would take too long, I will prioritize the most important ones.
At the same time, please keep in mind that this is a bi-directional process, and I would love to hear back from you as well. Therefore, do not hesitate to ask questions or share your opinions about the implementation (if any) during the process.
We expect the code review process to be completed within 2-3 days. As a result, please make sure you are responsive during this process. If you need more time, please let us know as soon as possible so we can plan accordingly.
If we are aligned on any issue, and you would like to correct them, please address the issue using a proper git flow (creating a new branch, opening a Pull Request (PR) per issue, and merging the code when you are ready), and I will follow up on those fixes. Just so you know, you don't have to close any of my created issues after merging your PRs; I will help verify and close them for you once they pass. 😇
In the end, I do hope that you find the process enjoyable. Good luck and happy coding. 🤘

@Prabeshpd I have completed the first review round of code reviews and would like your feedback on the open issues. Please check the other repositories.
Since this submission has many components, it would be best to provide a Docker-based or equivalent to ensure all dependencies can be set up (Postgres, RabbitMQ, and Redis)

Dear Oliver,
Thank you for your response and first round of code review. I will
certainly go through the comments and reply back to you. I was thinking of
making a docker-compose file to run the project. I was on a tight deadline
as I was busy completing my regular office duties as well so could not make
a docker file.
I will commit it and go through the other issues as well.
Warm Regards,
Prabesh Dahal
On Mon, May 29, 2023 at 10:47 AM Olivier Robert @.***>
wrote:

@Prabeshpd https://github.com/Prabeshpd I have completed the first
review round of code reviews and would like your feedback on the open
issues. Please check the other repositories.
Since this submission has many components, it would be best to provide a
Docker-based or equivalent to ensure all dependencies can be set up
(Postgres, RabbitMQ, and Redis)
—
Reply to this email directly, view it on GitHub
https://github.com/Prabeshpd/web-scraper-frontend/issues/7#issuecomment-1566546305,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJMWCLYKAFWB7LAUBSJ2DEDXIQUU5ANCNFSM6AAAAAAYSJYQOY
.
You are receiving this because you were mentioned.Message ID:
@.***>

I have addressed the issues. Can you please go through them? @olivierobert

I have reviewed the changes 👍 I would need you to review and provide at least some feedback to the open issues on this repository 😅 It would be great if we can wrap up the code review today or tomorrow at the latest.

@olivierobert  I have created PR and merge them for most of the issues mentioned. I have replied on the latest comment as well. Can you take a look at it?

I have now completed the review of all open issues. It is thus time to wrap up the code review. We appreciate your efforts during this process. Our team will contact you shortly.


Remove device category from upgrades

Pull Request summary:

Simplified usage of upgrades by removing DeviceCategory and DeviceType from SoftwareAction and PartitionManager
Moved common part (InstallSpecification) of SoftwareAction and PartitionManger to utils/upgrades_helper
Removed DeviceVersionPayload  from set/remove partitions methods. It generates automatically, user passes just DataSequence of devices. Optionally user can pass partition argument, if no - current partiton will be set as default/all available partitions will be removed
Add SoftwareAction to api_container
add validator to check if all devices have same personality

Checklist:

[x] Make sure to run pre-commit before commiting changes
[x] Make sure all checks have passed
[x] PR description is clear and comprehensive
[x] Mentioned the issue that this PR solves (if applicable)
[x] Make sure you test the changes

This issue was migrated from an old repository: https://github.com/CiscoDevNet/catalystwan/pull/208


Album art

Hello, in this issue I have told the user that stagger is not able to change images embedded in an mp3, and provided a workaround. Am I right about this?
And, if I am, would you be willing to provide some guidance towards a PR implementing this?

Stagger does support adding/changing/removing album art; initializing an APIC frame (or setting the "picture" property of a tag) with a value containing the filename of a JPEG or PNG file should work.
It is also possible to retrieve image data stored in the tag and to update it to data stored in memory, without writing it out to a file — the unit test suite contains examples how to that.
Thing thing should be documented better :-)

Ha! good to know :) I'll try to work out how to expose this functionality through greg, and let you know if I am not able to find my way through the relevant code.


Update Wiki on benchmarking with various providers

The Wiki needs to be updated once feature-serverless-framework-deployment is merged into main. Some notes on things that can be updated/included:

How the user interfaces with the tool (experiment JSON file)
How to deploy using various providers (preparing raw-code specific to providers, env variables etc.)
Obtaining results

Closed as documentation for all supported providers on main has been added to the Wiki.


Show percentages %

Hello,
Many thanks for the amazing graph package. I wonder if it's possible to show percentages%. For example, instead of 0.08, the labels may have the options to show 8.00%.
Many thanks!

Plotting percentages in Stata graphics is a real challenge. Personally, I consider it the 'Achilles heel' of Stata. But, I agree that to have the choice between reporting fractions (percentages) like: 0.15 or .15 or 15% (and controlling decimals like 15.1% or 15.12%) is so very much 'standard functionality' that is bizar that we have to resort to 'heavy lifted coding' to get such things done in Stata. Especially rounding fraction results for percentages is most awkward.
Asjad, I have my own 'crude' solutions that I could share for inspiration should you have to start from scratch for this.

added in v1.4


Disable scrolling when the modal is open

Describe the feature
At least for me on mac the website is still scrollable even if the modal is opened. IMO it is common sense that the website scroll should be blocked when a modal is opened.
FYI - I'm open to create a MR for this but please add some feedback of your thoughts
Sidenote for me: keep iOS in mind when developing this feature.
Additional information

[X] Would you be willing to help implement this feature?

Final checks

[X] Check existing discussions and issues.

Good idea, imho. Consider using headlessui/dialog, I'd say :bulb:

Good idea, imho. Consider using headlessui/dialog, I'd say 💡

Do you think headlessui could bloat the module unnecessarily? IMO installing a ui-library should be discussed as the module over all could then probably need a refactor?
Nevertheless I think the scroll-disable feature can also be added without installing a third-party (just FYI).
What do you think?

see https://github.com/dargmuesli/nuxt-cookie-control/discussions/228#discussioncomment-10656009


Please stop pushing broken releases

Description of the new feature / enhancement
Please, please stop pushing broken releases to auto update.
Factually every other update some part of this tool is broken in a way that makes it unusable (Forces downgrade).
This time it is FancyZones and dozens of user waste time when they notice it isn't working.
This is supposed to be a "productivity maximizing" tool.
Please leave the testing to thous who want to do that and dont make everyone a tester by default.
Thank you.
Scenario when this would be used?

Supporting information
No response

Thanks for completely ignoring the point I made.

This was not a bug report. (And there are plenty reports about FancyZones being broken already.)
No one cares about the version number or expects this to be stable polished piece of software.
Disabling auto update does not address the problem at all it just make people stuck on an old version.


ESP-IDF v3.3 release upgrade

Description

Integration of ESP-IDF v3.3 stable release
Release notes:
https://github.com/espressif/esp-idf/releases/tag/v3.3
Checklist:

[X] I have tested my changes. No regression in existing tests.
[X] My code is Linted.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/bot run checks

/bot run checks


Add license and authoring information to all the files

Try to keep the ASL license as short as possible.
https://issues.apache.org/jira/browse/LEGAL-124
The header is:
# Licensed under the terms of http://www.apache.org/licenses/LICENSE-2.0
and about the authors and copyright:
# Author/s (©): <name of the author/s>
Not sure if the © introduces problems. Probably we can just use (c).

I think it is useful to add to all files because the code could be reused in other places and it this case, it is useful to have tracking information about it.

Done in 0.11.0 version:
https://github.com/juntosdesdecasa/mcthings/commit/e7187f740c7a6fdd258062fcf5e64bc3b2b9dabf


update_tags quirk for this one DOI

Dunno what happened here. The script seems to work fine for other DOIs, just not 10.1093/nar/gkae559.

Confirming that it works now!


Update advanced-config.md

The profiler configuration is in https://github.com/signalfx/splunk-otel-java/blob/main/profiler/README.md -- do you think we should integrate it into the docs/ directory?
cc @breedx-splk

The field expected a 1:1 match of GH docs and official docs.

The profiler configuration is in https://github.com/signalfx/splunk-otel-java/blob/main/profiler/README.md -- do you think we should integrate it into the docs/ directory? cc @breedx-splk

I definitely don't want to maintain it in two places. Seems weird to have it in /docs when it could be living closer to the implementation (like it is now).


Selecting Clang as the kit compiles with /usr/bin/c++ (g++)

Brief Issue Summary
I noticed that the binary c++ was being used for compilation with the clang kit as opposed to clang++ on Linux. Investigating this, I found that "scan for kits" populates an entry for clang with an empty CXX variable.
cmake-tools-kits.json is populated as follows:
[
  {
    "name": "Clang 10.0.0",
    "compilers": {
      "C": "/usr/bin/clang-10"
    }
  },
  {
    "name": "GCC 9.1.0",
    "compilers": {
      "C": "/usr/bin/gcc",
      "CXX": "/usr/bin/g++"
    }
  },
  {
    "name": "GCC 9.3.0",
    "compilers": {
      "C": "/usr/bin/gcc",
      "CXX": "/usr/bin/g++"
    }
  },
  {
    "name": "GCC for i686-w64-mingw32 9.3.0",
    "compilers": {
      "C": "/usr/bin/i686-w64-mingw32-gcc-9.3.0"
    }
  },
  {
    "name": "GCC for x86_64-pc-linux-gnu 9.3.0",
    "compilers": {
      "C": "/usr/bin/x86_64-pc-linux-gnu-gcc-9.3.0"
    }
  },
  {
    "name": "GCC for x86_64-w64-mingw32 9.3.0",
    "compilers": {
      "C": "/usr/bin/x86_64-w64-mingw32-gcc-9.3.0"
    }
  }
]

which clang++ reports /usr/bin/clang++ on my system.

Expected:

Clang kit variable CXX is populated with /usr/bin/clang++ (or whatever is correct)
Selecting Clang kit compiles with clang++

Apparent Behavior:

Selecting Clang as the kit compiles with /usr/bin/c++

Platform and Versions

Operating System: Arch Linux
CMake Version: 3.17.2
VSCode Version: 1.44.2
CMake Tools Extension Version: 1.3.1
Compiler/Toolchain: clang 10.0.0

For some reason the extension is not finding your clang++ compiler.
Please share the log created during the scan for kits operation. It will contain the clang++ path that the extension is looking at ("Detected Clang compiler:").

CMake Tools log
2020-05-15T20:37:17.798Z [debug] [kitsController] Rescanning for kits
2020-05-15T20:37:17.798Z [debug] [kit] Scanning for Kits on system
2020-05-15T20:37:17.800Z [debug] [kit] Skipping scan of not existing path /home/caleb/.local/bin
2020-05-15T20:37:17.800Z [debug] [kit] Found 0 kits in directory /home/caleb/.local/bin
2020-05-15T20:37:17.800Z [debug] [kit] Scanning directory /home/caleb/.scripts for compilers
2020-05-15T20:37:17.800Z [debug] [kit] Scanning directory /home/caleb/.bin for compilers
2020-05-15T20:37:17.800Z [debug] [kit] Scanning directory /home/caleb/.cargo/bin for compilers
2020-05-15T20:37:17.802Z [debug] [kit] Scanning directory /usr/local/sbin for compilers
2020-05-15T20:37:17.803Z [debug] [kit] Scanning directory /usr/local/bin for compilers
2020-05-15T20:37:17.803Z [debug] [kit] Scanning directory /usr/bin for compilers
2020-05-15T20:37:17.803Z [debug] [kit] Scanning directory /var/lib/flatpak/exports/bin for compilers
2020-05-15T20:37:17.803Z [debug] [kit] Scanning directory /usr/lib/jvm/default/bin for compilers
2020-05-15T20:37:17.803Z [debug] [kit] Scanning directory /usr/bin/site_perl for compilers
2020-05-15T20:37:17.803Z [debug] [kit] Scanning directory /usr/bin/vendor_perl for compilers
2020-05-15T20:37:17.804Z [debug] [kit] Scanning directory /usr/bin/core_perl for compilers
2020-05-15T20:37:17.814Z [debug] [kit] Found 0 kits in directory /home/caleb/.scripts
2020-05-15T20:37:17.814Z [debug] [kit] Found 0 kits in directory /home/caleb/.cargo/bin
2020-05-15T20:37:17.814Z [debug] [kit] Found 0 kits in directory /home/caleb/.bin
2020-05-15T20:37:17.814Z [debug] [kit] Found 0 kits in directory /usr/local/bin
2020-05-15T20:37:17.815Z [debug] [kit] Found 0 kits in directory /usr/local/sbin
2020-05-15T20:37:17.815Z [debug] [kit] Found 0 kits in directory /var/lib/flatpak/exports/bin
2020-05-15T20:37:17.818Z [debug] [kit] Found 0 kits in directory /usr/lib/jvm/default/bin
2020-05-15T20:37:17.818Z [debug] [kit] Found 0 kits in directory /usr/bin/site_perl
2020-05-15T20:37:17.818Z [debug] [kit] Found 0 kits in directory /usr/bin/vendor_perl
2020-05-15T20:37:17.820Z [debug] [kit] Found 0 kits in directory /usr/bin/core_perl
2020-05-15T20:37:17.842Z [debug] [kit] Testing Clang binary: /usr/bin/clang
2020-05-15T20:37:17.843Z [debug] [kit] Testing Clang binary: /usr/bin/clang
2020-05-15T20:37:17.852Z [debug] [kit] Testing Clang binary: /usr/bin/clang-10
2020-05-15T20:37:17.852Z [debug] [kit] Testing Clang binary: /usr/bin/clang-10
2020-05-15T20:37:17.885Z [debug] [kit] Testing GCC binary: /usr/bin/gcc
2020-05-15T20:37:17.908Z [debug] [kit] Testing GCC binary: /usr/bin/i686-w64-mingw32-gcc
2020-05-15T20:37:17.920Z [debug] [kit] Testing GCC binary: /usr/bin/i686-w64-mingw32-gcc-9.3.0
2020-05-15T20:37:17.998Z [debug] [kit] Testing GCC binary: /usr/bin/x86_64-pc-linux-gnu-gcc
2020-05-15T20:37:18.010Z [debug] [kit] Testing GCC binary: /usr/bin/x86_64-pc-linux-gnu-gcc-10.1.0
2020-05-15T20:37:18.021Z [debug] [kit] Testing GCC binary: /usr/bin/x86_64-w64-mingw32-gcc
2020-05-15T20:37:18.031Z [debug] [kit] Testing GCC binary: /usr/bin/x86_64-w64-mingw32-gcc-9.3.0
2020-05-15T20:37:18.048Z [debug] [kit] Detected GCC compiler: /usr/bin/x86_64-w64-mingw32-gcc-9.3.0
2020-05-15T20:37:18.048Z [debug] [kit] Detected GCC compiler: /usr/bin/x86_64-w64-mingw32-gcc
2020-05-15T20:37:18.048Z [debug] [kit] Detected GCC compiler: /usr/bin/x86_64-pc-linux-gnu-gcc-10.1.0
2020-05-15T20:37:18.049Z [debug] [kit] Detected GCC compiler: /usr/bin/x86_64-pc-linux-gnu-gcc
2020-05-15T20:37:18.049Z [debug] [kit] Detected GCC compiler: /usr/bin/i686-w64-mingw32-gcc-9.3.0
2020-05-15T20:37:18.049Z [debug] [kit] Detected GCC compiler: /usr/bin/i686-w64-mingw32-gcc
2020-05-15T20:37:18.050Z [debug] [kit] Detected GCC compiler: /usr/bin/gcc
2020-05-15T20:37:18.050Z [debug] [kit] Detected Clang compiler: /usr/bin/clang-10
2020-05-15T20:37:18.050Z [debug] [kit] Detected Clang compiler: /usr/bin/clang
2020-05-15T20:37:18.051Z [debug] [kit] Found 9 kits in directory /usr/bin
2020-05-15T20:37:18.051Z [info] [kit] Found Kit: Clang 10.0.0
2020-05-15T20:37:18.051Z [info] [kit] Found Kit: Clang 10.0.0
2020-05-15T20:37:18.051Z [info] [kit] Found Kit: GCC 10.1.0
2020-05-15T20:37:18.051Z [info] [kit] Found Kit: GCC for i686-w64-mingw32 9.3.0
2020-05-15T20:37:18.052Z [info] [kit] Found Kit: GCC for i686-w64-mingw32 9.3.0
2020-05-15T20:37:18.052Z [info] [kit] Found Kit: GCC for x86_64-pc-linux-gnu 10.1.0
2020-05-15T20:37:18.052Z [info] [kit] Found Kit: GCC for x86_64-pc-linux-gnu 10.1.0
2020-05-15T20:37:18.052Z [info] [kit] Found Kit: GCC for x86_64-w64-mingw32 9.3.0
2020-05-15T20:37:18.052Z [info] [kit] Found Kit: GCC for x86_64-w64-mingw32 9.3.0
2020-05-15T20:37:18.053Z [debug] [kitsController] Saving kits to /home/caleb/.local/share/CMakeTools/cmake-tools-kits.json
2020-05-15T20:37:18.053Z [debug] [kitsController] Saving new kits to /home/caleb/.local/share/CMakeTools/cmake-tools-kits.json
2020-05-15T20:37:18.054Z [debug] [extension] [8460] cmake.scanForKits finished (returned undefined)
2020-05-15T20:37:18.055Z [debug] [kit] Reading kits file /home/caleb/.local/share/CMakeTools/cmake-tools-kits.json
2020-05-15T20:37:18.067Z [info] [kit] Successfully loaded 7 kits from /home/caleb/.local/share/CMakeTools/cmake-tools-kits.json

Hi, I have the same Issue on the same Platform and adding clang++ manually changes nothing.

It looks like some strange cmake bug because -DCMAKE_CXX_COMPILER=clang++ works while -DCMAKE_C++_COMPILER=clang++ does not.

Hi, I have the same issue, adding clang++ manually changes nothing. I noticed that cmake is called with DCMAKE_C++_COMPILER=clang++ instead of DCMAKE_CXX_COMPILER=clang++ which does not work.

I had the same issue as well. Currently working around the issue by manually changing the clang 10 entry in cmake-tools-kit.json to read:
  {
    "name": "Clang 10.0.1",
    "compilers": {
      "C": "/usr/local/bin/clang-10",
      "CXX": "/usr/local/bin/clang++" // Changed to path where clang++ is located
    }
  }

What's odd is that I only just started having this issue with clang-10 being selected as a kit.

@caradhras2 do you still have an issue if you change the "C++" property under "compilers" to "CXX" in your Kit?

@Eric-Brown thank You.
Appending "CXX" line works for me.


Missing values for SendClaimsIn option

As shown in the example here: https://docs.microsoft.com/en-us/azure/active-directory-b2c/identity-provider-linkedin-custom?tabs=applications#obtain-an-email-address
There is an extra supported option for "SendClaimsIn" - URL.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6dff7a38-a459-4eb9-22fe-d225eeac5e34
Version Independent ID: c3e92211-d07e-edec-3a08-eb68a26859bb
Content: Define a RESTful technical profile in a custom policy - Azure AD B2C
Content Source: articles/active-directory-b2c/restful-technical-profile.md
Service: active-directory
Sub-service: b2c
GitHub Login: @msmimart
Microsoft Alias: mimart

Adding to using the SendClaimsIn=URL value:

The resulting request verb is GET
Allows you to specify a {claimName} syntax in the ServiceUrl metadata value, where {claimName} is an indicated PartnerClaimType for an InputClaim on the Technical Profile.

<Metadata>
  <Item Key="ServiceUrl">https://some-root-url.com/{substitutionValue}/something</Item>
  <Item Key="SendClaimsIn">Url</Item>
</Metadata>
<InputClaims>
  <InputClaim ClaimTypeReferenceId="myClaimName" PartnerClaimType="substitutionValue"/>
</InputClaims>

Where myClaimName has a value of "foo", results in a GET to https://some-root-url.com/foo/something

This feature and another one related to the dynamic service Url is in public/private preview. We'll document it later this year.
#please-close

Thank you @yoelhor - should the other document be updated then to indicate it is using Preview features?


Training in Introduction to scVI

hi,senior.I found that the code ran with the following error:
Traceback (most recent call last):
File "DataLoading.py", line 22, in
gene_dataset = CortexDataset(save_path=save_path, total_genes=558)
File "/home/admin301/anaconda3/envs/pytorch/lib/python3.7/site-packages/scvi/dataset/cortex.py", line 50, in init
delayed_populating=delayed_populating,
File "/home/admin301/anaconda3/envs/pytorch/lib/python3.7/site-packages/scvi/dataset/dataset.py", line 1346, in init
self.populate()
File "/home/admin301/anaconda3/envs/pytorch/lib/python3.7/site-packages/scvi/dataset/cortex.py", line 69, in populate
X = np.asarray(rows, dtype=np.int).T[1:]
File "/home/admin301/anaconda3/envs/pytorch/lib/python3.7/site-packages/numpy/core/_asarray.py", line 85, in asarray
return array(a, dtype, copy=False, order=order)
ValueError: setting an array element with a sequence.
and i don't know how to solve it?

Hello,
I would ensure the save_path is correct. If you're running the tutorial notebook please ensure that the working directory of the notebooks is the same directory that the notebook is in.

I'm very thanks for your reply.At first,the file "DataLoading.py" is under the directory of "/home/admin301/chenjian/scVI/"(D1),and then i move it to the path as "/home/admin301/chenjian/scVI/data/"(D2) and it ran successfully and output a folder called data.(about data,the former is from the "Data Loading Tutorial",the later is in this tutorial).I was puzzled by a question here that I ran the "Data Loading Tutorial" in the directory of D1 and ran the "Training" of basic usage in D2 and both worked.so why the "Training" couldn't work in D1?whether these two tutorials are independent of each other?

I am not clear as to what you mean by DataLoading.py. This is not a file in our repository. Loading dataset objects depends on the save path in many instances, so ensuring that the save path is correct is critical.

the file "DataLoading.py" include codes of Loading the data&Training the model.I didn't use jupyter but pytorch to ran these codes


Remove unused check

The linter is complaining about isReferenceAllowed not being used as a result of https://github.com/cilium/cilium/commit/cd826fd3a275ca4841bf8e62f37da9931980cd28
The isReferenceAllowed check is now defined in operator/pkg/gateway-api/helpers/referencegrants.go, I have removed the unused version.
<!-- Enter the release note text here if needed or remove this section! -->

/test

/test-backport-1.13

Failed tests are due to wrong comand used, all requried tests are passed, reviews are in.
ci-l4lb-1.13 is not related to this change. Marking this ready to merge.


CodeQL Action error: invalid source release: 17

My workflow make a CodeQL but it fails on Autobuild command by error error: invalid source release: 17. https://github.com/navikt/sokos-pdl-proxy/actions/runs/4533719188/jobs/7986911677#step:5:93.
I followed documentation and its says if the Autobuild command fail, I can replace with my own command:
# Autobuild attempts to build any compiled languages (C/C++, C#, Go, or Java).
      # If this step fails, then you should remove it and run the build manually (see below).
      - name: Autobuild
        uses: github/codeql-action/autobuild@v2

      # ℹ Command-line programs to run using the OS shell.
      # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun

      # ✏ If the Autobuild fails above, remove it and uncomment the following
      #    three lines and modify them (or add more) to build your code if your
      #    project uses a compiled language

      #- run: |
      #     make bootstrap
      #     make release

So i replaced the command with this custom command:
      - name: Autobuild
        run: |
          ./gradlew clean build shadowJar

But it still fails. Is this a bug or am I missing something?

It looks like you are using Java and you have not set up the correct JDK to build your code. See the actions/setup-java action. Add the step before you run codeql-action/init. You can use this action to make sure that the workflow job uses the correct java version for your build.

Wierd. Because I have the same workflow in 2 another repo and it works. https://github.com/navikt/sokos-ktor-template/blob/master/.github/workflows/security.yaml. This one I have not defined JDK to build my code before codeql-action/init ? I can try set as you says, but do I really need to define it when its works without?

I'm not sure. I think this is the easiest fix to try first. If this doesn't work, I'll take a deeper look.

It works :) Thank you :)


feat(aws-ec2): add support for ICMP protocol's classification Types & Codes to SecurityGroupRule

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

thanks @rix0rr and @eladb.


Firestarter

Mage's Firestarter may display:

a Spell Activation Overlay (TBD)
a Glowing Action Button: Flamestrike (undoubtedly)

After careful consideration, Firestarter will use the Impact texture, on "Top" position, at 0.8 scale (80%).
The Impact SAO will use the Lock and Load texture. This means the Impact talent no longer uses the Impact texture. This decision was taken because:

Firestarter is such an important talent in Wrath in both PvE and PvP, whereas Impact is only used in PvP
the Impact texture was designed by Blizzard for Cataclysm, but the Impact talent was reworked between Wrath and Cata
with the current talents, Impact texture suits Firestarter very well, and the Lock and Load texture suits Impact very well

All in all, we should remember that Spell Alerts were designed for Cataclysm talents. It makes sense to use eponymous appearances (i.e. Impact texture for Impact talent) when talents are mostly identical between Wrath and Cata. But both Firestarter and Impact are drastically different between these expansions, so we should not stick to use a texture solely based on its filename.
As for the 80% scale factor, this was a logical adjustment because the Impact texture feels way too heavy, compared to other effects displayed in this position.

Fully implemented in #62.


Create installer for Windows

As a IDEasy user, I want to install the product via a graphical installer so that I can easily be guided through the installtion with only few clicks.
Acceptance criteria

Installer first screen shows the license of IDEasy with scrollbar and the user can read it and either click Cancel or Accept & Continue. Cancel aborts the installation and Accept & Continue proceeds to the second screen.
Installer shows second screen to choose the installation location ($IDE_ROOT) with and Install button at the bottom and above a description with the following options with radio-button selection .

C:\projects (pre-selected default)
D:\projects (if D: drive is present, a permanent disc like HDD or SSD and has at least 1GB free disc space)
custom with ability to browse to a custom folder. If this option is selected the Install button gets disabled (grayed out), the custom folder has to be chosen and the path must exist and not contain spaces or special characters (only [a-zA-Z0-9]+ for folders). Also the path must not be longer than 32 characters. Only if all these criteria are met the Install button gets enabled.

When the user has clicked on Install the installation is started:

Contents are installed to $IDE_ROOT (so we have $IDE_ROOT/_ide/bin/ideasy.exe, etc.)
Environment variable (user) PATH is extended with value of ;$IDE_ROOT\_ide\bin
Environment variable (user) IDE_ROOT is set in Windows to value of $IDE_ROOT.
The file %USERPROFILE%\.bashrc is created if not existing and we append the line alias ide="source $IDE_ROOT/_ide/bin/ide" where $IDE_ROOT is the resolved path in MSYS syntax (e.g. /c/projects instead of C:\projects) followed by the line source $IDE_ROOT/_ide/completion and finally the line ide.
Registry entries are added for Explorer integration

The installer features uninstallation via standard Windows Settings that reverts all changes made during the installation.

For the registry entries see old devonfw-ide sources:

https://github.com/devonfw/ide/blob/master/scripts/src/main/resources/system/windows/windows-terminal/devon-wt-gitbash.reg
https://github.com/devonfw/ide/blob/master/scripts/src/main/resources/system/windows/windows-terminal/devon-wt-cmd.reg
https://github.com/devonfw/ide/blob/master/scripts/src/main/resources/system/windows/windows-terminal/devon-wt-ps.reg
See also https://github.com/devonfw/ide/blob/master/scripts/src/main/resources/system/windows/windows-terminal/README.asciidoc

Suggested solution for the installer is to create an MSI package from the results of the current windows package with the features specified above.
Note
I removed the suggested feature:

Installer checks that Git and git-bash are installed. If not, an error Popup is shown and the installation cancelled.

We will solve this later. We still have to decide if this will be solved in our IDEasy (CLI) in Java or it should go to the OS specific installer parts.

Example Screenshot of License Agreement from Git:

different installation programs we could use:
IzPack:
advantages:

Free and Open Source, as it is licensed under the GNU LPGL
Cross-Platform: Supports the creation of installation packages for Windows, macOS, and Linux
Java-Based: Particularly well-suited for Java applications, as it is written in Java
Flexibility: Allows the creation of customizable installation processes

disatvantages:

Configuration is done via XML, which may take some time to learn
User Interface: The graphical user interface isn’t as refined as those found in some paid tools

InstallBuilder
advantages:

Cross-Platform: Supports Windows, macOS, and Linux, making it easier to distribute your software
Flexible Customization Options: Offers numerous options for customizing installation processes and user interfaces
Easy Integration: Allows integration of scripts to add custom logic to the installation process
Good Documentation: Provides comprehensive documentation and support, making it easier to get started

disatvantages:

Paid Versions: While a free version is available, many advanced features are only included in the paid versions
Complexity: Configuration can become complex with extensive customizations and may require some learning time
Installer Size: The installers created can be larger than those made with some other tools, which may affect distribution
Limited Features in the Free Version: The free version may not offer all the features needed for comprehensive installations

Install4j Community edition
advantages:

Free to use
Cross-Platform
Java-Specific Features: Designed specifically for Java applications, allowing for easy integration of Java runtime environments
Customizable Options: Offers a range of customizable installation options, including the ability to add custom scripts

disadvantages:

Limited Features: The Community Edition lacks many advanced features found in the commercial versions, such as integrated update mechanisms and certain deployment options
Learning Curve: While the interface is user-friendly, some advanced functionalities may still require a learning period
Installer Size: The installers produced can be larger than those created with some other installation tools
No Commercial Support: Community Edition users may not have access to the same level of support and documentation as paid users

If anyone picks up this ticket again, they might want to check the two linked draft pull requests


when data columns more than 26 columns , how can I export it

Prerequisites

[ ] Have read and understood: https://github.com/Maatwebsite/Laravel-Excel/blob/3.1/.github/SUPPORT.md
[ ] Checked if your Laravel Excel version is still supported: https://docs.laravel-excel.com/3.1/getting-started/support.html#supported-versions
[ ] Checked that your question isn't already asked before.
[ ] Filled in the entire issue template

Versions

PHP version:
Laravel version:
Package version:

Description

Additional Information
Any additional information, configuration or data that might be necessary to reproduce the issue.

Can. you fill in the issue template please


[ENG-356] Update Storage Usage for WB APIv2 move/copy hooks

Purpose
Add the storage usage caching to our new v2 Waterbutler storage hooks.
Changes

simple changes to perform_file_action to update the cache.
tests.

QA Notes

Nothing user facing here.
Remember caches are often None if they've expired, sometimes this makes it seem broken when debugging.

Documentation
Just test comments
Side Effects
None that I know of.
Ticket
https://openscience.atlassian.net/browse/ENG-356

Looks great! 🛥


Easier way to install on Linux needed.

Some people have stated they still have problems getting Twister installed on Linux. Can you please create a Deb package to install Twister and also add Twister to the software manager on Linux. Those two ways to install Twister would make it a lot easier for people.

Please check twister.net.co downĺoad page:
http://twister.net.co/?page_id=23

I checked out the links but those are PPA's and a lot of people hate using PPA's. I don't even use them. Here's an example picture of what Twister needs.

@Snarkly I'm not a debian user, I don't know how to get twister into this "Software Manager". Maybe we need to lobby some Debian maintainer to do it?

Why can't they download the .deb from this PPA channel and install it manually?
Example:
https://launchpad.net/~podshumok/+archive/ubuntu/twister-core-daily/+build/13306247

Thanks, I didn't know about that link. I'll post that link on Twitter.

I only stumbled across Twister a few hours ago and I'm not at all familiar with the code but I wanted to quickly try it out and I have to whole heartedly agree that as I understand the installation process is very developer centric !
Has anyone looked at creating a snap and add it to Ubuntu's Snap store  and/or a Redhats Flatpak and/or Appimage ? , though its not as smooth to use and update as Snap or Flatpak.
You may ned some bash script just to check is snapd or flatpack is already installed because some distros come only with one or the other by default eg. Linux mint has Flatpak but not Snaps so you have to  $ sudo apt install snapd
.deb and PPA's will be around for a while but Snaps/ Flatpak / Appimage(?) are the future as they are containerised so allow multiple versions of the same app in the system for example.
I've never installed or used Twister and I've only  a basic understanding of Snaps though I do install stuff via it, but if you want I'll  have a go at doing a snap for Twister?
Please no guarantees but happy to try.  My only question would you be comfortable putting Twister in this list?
Also if you look at how the Signal messenger app is installed they have a script to copy
curl -s https://updates.signal.org/desktop/apt/keys.asc | sudo apt-key add -
echo "deb [arch=amd64] https://updates.signal.org/desktop/apt xenial main" | sudo tee -a /etc/apt/sources.list.d/signal-xenial.list
sudo apt update && sudo apt install signal-desktop

Likewise Ring which has R.S been involved also has a script
sudo sh -c "echo 'deb https://dl.ring.cx/ring-nightly/ubuntu_18.04/ ring main' > /etc/apt/sources.list.d/ring-nightly-main.list"
sudo apt-key adv --keyserver pgp.mit.edu --recv-keys A295D773307D25A33AE72F2F64CD5FA175348F84
sudo add-apt-repository universe
sudo apt-get update && sudo apt-get install ring-all

You can see that esentially both of them add a repo to the clients source list then update and upgrade to install.
Personally I think Snaps or Flatpak is the way to go both from an ease of installation , mantanence and marketing perspective.
Anyhow please let me know if I've said anything useful and I'll take a look ;)


Priority between output.externals and resolve.alias config

Details
alias: {
  react: 'react-native',
},

If we want to make react alias to react-native, and the alias behaviour will affected by externals config
bundle
In bundle mode, the autoExternal is default set to true, so react will be externals to ^react($|\\/|\\\\).
So the alias config is invalid after externals set.
We should set autoExternal: false or set output.externals to make alias work
output: {
  externals: {
    react: 'react-native',
  },
},

bundleless
In bundleless mode, we use externals like below to generate bundleless output.
https://github.com/web-infra-dev/rslib/blob/4b5f674789059bea3456e1105cb3cf9b051912d7/packages/core/src/config.ts#L506
So the react request is callback here, so alias config is invalid after externals set.
We need to set output.externals to make alias work, and the alias config turn out to be logic that won't be executed
output: {
  externals: {
    react: 'react-native',
  },
},

Add docs in source.alias and 	output.external to explain the relationship between each other.

bundle: use source.alias to alias, note the effect of autoExternal
bundleless: use output.external to alias

https://lib.rsbuild.dev/config/rsbuild/source#sourcealias


How to select attributes for training (epochs , max_history , batch_size)

Rasa Core version: 0.8.5
Python version:  2.7
Operating system (windows, osx, ...): Ubuntu 17.10
Issue:
How can we change these attributes.  as default epochs: 100 , max_history is 3 and batch size is 20.
what are the basic guidelines we should keep in mind to handle these things because these 3 attributes gives clear impact on dialogue.
Can someone explain the logic behind these 3 in reference to our core and dialogue stories.

if set max_history longer than story length, what is the max_history value?


PIP-255: Support for Idempotent Commit and Abort.

Motivation
Currently, commit and abort operation are not idempotent, which will result into message duplication described in issue https://github.com/apache/pulsar/issues/19629.
Goal
Make commit and abort idempotent, with this feature we can ensure that there is no message duplication and message lost when producing in transaction.
API Changes
None.
Implementation
Analysis
The main challenge to make commit and abort operation idempotent is that, broker will remove txnMeta from txnMetaMap as soon as the transaction is committed or aborted successfully. As there are multiple commit/abort requests trigger by client or broker itself due to transaction time out, the subsequent request will meet TransactionNotFound exception because broker do not hold the txnMeta corresponding transaction.
Such situation may occurs that producer produce messages with transaction and commit the transaction txn1, the transaction txn1 is committed successfully in broker but the producer receive exception, which will be considered as a signal that the transaction txn1 is committed failed by producer. So producer will resend messages in txn1 with a new transaction txn2, which will result into message duplication.
Solution 1: persist txnMeta for transactionTimeout time.
The straightforward solution is to persist the txnMeta for transactionTimeout time. Every transaction has the property of transactionTimeout configured by client, after which the transaction in OPEN status will be set to TIME_OUT, and TC will try to abort the transaction actively.
If TC persist txnMeta for transactionTimeout time, in other words, TC do not remove txnMeta from txnMetaMap as soon as the transaction is committed or aborted, then TC can query the transaction status for subsequent commit/abort request based on txnMetaMap, which could resolve the problem.
We could analyze solution1 deeper.

Client start transaction txn1 at T0, and may issue multiple commit/abort requests at T1, T2, T3. T1 is not close to transactionTimeout, while T2 is close to transactionTimeout. T3 is greater than the transactionTimeout.

If client try to commit/abort at T3 for the first time, it cannot issue the commit request as the transaction has timed out.
If client try to commit/abort at T1 for the first time, client will receive correct response and set the transaction status to COMMITTED or ABORTED. As a result, the subsequent commit/abort request will be discarded by client because client know that the transaction txn1 has been COMMITTED or ABORTED.
If client try to commit/abort at T2 for the first time, client could issue the commit request req1 to TC as the transaction do not time out yet. When the request come to TC, txn1 may be timed out as T2 is very very close to transactionTimeout. As a result, TC try to abort txn1 actively ( called req2 ) and there will be two concurrent commit/abort process req1 and req2.

If req1 is faster than req2, then client will commit successfully.
If req2 is faster than req1, then TC will abort txn1 and remove txnMeta from txnMetaMap instantly, which result into that the subsequent request req1 fail with TransactioinNotFound. Though client receive the exception, the consistence of transaction can still be guaranteed as txn1 is aborted in TC and client consider txn1 commit failed.

In a word, we can ensure transaction consistence with solution1.
Alternatives
No response
Anything else?
No response

The PIP number is duplicated with https://github.com/apache/pulsar/issues/19705

I am not sure that PIP solves some problems; let's see the above process:

client sends a commit request to TC
TC changed txn1 to Committing status then broker down
the client will check the txn1 status in a loop
when the txn1 timeout, the client will think this transaction has been committed fail.
broker restart, changed txn1 to committed status

in this situation, we still cannot guarantee that messages will not be sent repeat

I am not sure that PIP solves some problems; let's see the above process:

client sends a commit request to TC
TC changed txn1 to Committing status then broker down
the client will check the txn1 status in a loop
when the txn1 timeout, the client will think this transaction has been committed fail.
broker restart, changed txn1 to committed status

in this situation, we still cannot guarantee that messages will not be sent repeat

After client commit txn1, txn1 will not be set as TIME_OUT. Only when the txn1 be in OPEN state can it be set to   TIME_OUT state.
org.apache.pulsar.client.impl.transaction.TransactionImpl#run

There may be situation similar to your concerns. For example, if broker take to much time to restart and result into long unavailable time, the client will throw following exceptions:

2023-03-08T18:33:12,415+0800 [pulsar-client-internal-17-1] ERROR org.apache.pulsar.testclient.PerformanceProducer - Commit transaction:(7,206446) failed with exception :
java.util.concurrent.CompletionException: org.apache.pulsar.client.api.PulsarClientException$TimeoutException: Could not get response from transaction meta store within given timeout.

As client will wait the commit request for at most 30s default, if the unavailable time is longer than 30s, the client will throw exceptions above. At this situation,  the client could not know the correct status of transaction, so it should retry to commit the transaction (query the state of txn1).
I have implement such logic in PerformanceProducer. https://github.com/apache/pulsar/pull/19781
                                        if (arguments.isEnableTxnTest) {
                                            int retryTimes = arguments.retryTimes;
                                            if (isTimeOutException(exception)) {
                                                for (int i = 0; i < retryTimes; i++) {
                                                    try {
                                                        transaction.commit().get();
                                                        handleTxnOnCommitted(transaction);
                                                        break;
                                                    } catch (Exception e) {
                                                        if (!isTimeOutException(e)) {
                                                            break;
                                                        }
                                                    }
                                                }
                                            }
                                            if (transaction.getState() != Transaction.State.COMMITTED) {
                                                totalSent.add(-handleTxnOnAborted(transaction, messageFormatter,
                                                        arguments.baseDirToSaveResendTxnData));
                                            }
                                        }

There may be situation similar to your concerns. For example, if broker take too much time to restart and result into long unavailable time, the client will throw following exceptions:

2023-03-08T18:33:12,415+0800 [pulsar-client-internal-17-1] ERROR org.apache.pulsar.testclient.PerformanceProducer - Commit transaction:(7,206446) failed with exception :
java.util.concurrent.CompletionException: org.apache.pulsar.client.api.PulsarClientException$TimeoutException: Could not get response from transaction meta store within given timeout.

if client down, and then client restart also will send the repeat message right?

In most of time, the unavailable time is limited, so retrying policy is effective, users can control the max times to retry. I wonder whether the retrying logic should be implemented into the TransactionImpl instead of implemented by users themselves.

at the Pulsar Transaction in this time, I think make it for users to implement is better, Because it is best not to add this extra config until we have fully designed it

if client down, and then client restart also will send the repeat message right?
When client is shutdown, it should persist unfinished transactions and reconstruct TransactionImpl object to commit again, or message duplication will occurs.

When client shutdown, it should persist unfinished transactions to a local snapshot and reconstruct TransactionImpl object with snapshot to commit again when restarted, or message duplication will occur.

I have a question, if you open a txn then client down, the txn only can wait txn timeout to end right?

I have a question, if you open a txn then client down, the txn only can wait txn timeout to end right?

If a txn is opend and client shutdown before client commit it , we can just let the txn time out, which is consistent.
However, if this txn have been committed in broker but client do not receive the response and update the txn state before shutdown, we should reconstruct TransactionImpl object to query the txn state to know the correct state of txn.
We need to know whether the transaction is committed successfully in broker. If commit fail, client should resend messages in failed txn with a new txn. If commit successfully, client do not need to resend.

for the point one, I am investigating how to solve the problem of zombie transaction
for the point two, I think transaction should have a retention time, timeout is timeout, it can't represent the transaction need to retention. becasue some users don't need to check the transaction status again. So it's better to add a metadata in to the transaction like retention time is better.

If the retention time is 0, when the transaction timeout, the transaction can be removed from the memory and storage directly.
If the txn ended, we should check the txn can be removed from memory and storage by retention time.

I have a question, if you open a txn then client down, the txn only can wait txn timeout to end right?

If a txn is opend and client shutdown before client commit it , we can just let the txn time out, which is consistent.
I am investigating how to solve the problem of zombie transaction
However, if this txn have been committed in broker but client do not receive the response and update the txn state before shutdown, we should reconstruct TransactionImpl object to query the txn state (that is commit again) to know the correct state of txn.
We need to know whether the transaction is committed successfully in broker. If commit fail, client should resend messages in failed txn with a new txn. If commit successfully, client do not need to resend.

I think transaction should have a retention time, timeout is timeout, it can't represent the transaction need to retention. becasue some users don't need to check the transaction status again. So it's better to add a metadata in to the transaction like retention time is better.
If the retention time is 0, when the transaction timeout or ended, the transaction can be removed from the memory and storage directly.
If the txn ended, we should check the txn can be removed from memory and storage by retention time.

I am investigating how to solve the problem of zombie transaction

what is the problem of zombie transaction?

I think transaction should have a retention time, timeout is timeout, it can't represent the transaction need to retention. becasue some users don't need to check the transaction status again. So it's better to add a metadata in to the transaction like retention time is better.
If the retention time is 0, when the transaction timeout or ended, the transaction can be removed from the memory and storage directly.
If the txn ended, we should check the txn can be removed from memory and storage by retention time.

It do. Set a retention time for transaction is more flexible. But it is user's responsibility to configure a appropriate value that is suitable to their situations.  For example, set a pretty large retention time will occupy large memory usage, while set a pretty small value may meet TransactionNotFound exceptions.
The defect of Solution1 persist txnMeta for transactionTimeout time. is that, client may shutdown for long time, and the txnMeta have been removed from broker. For example, set transactionTimeout to 10s, and client shutdown for 20s, client will meet TransactionNotFound exceptions when restarted. But with retention mechanism, user can set retention time to 30s based on shutdown time 20s, so client can access to the txnMeta and will not throw TransactionNotFound exceptions.
Should i split PR #19662 into two PR? One for fixing Expect Txn (7,24726) to be in COMMITTING status but it is in COMMITTED status, other for fixing TransactionNotFound exceptions, which deserve discussion for better solution.

@thetumbled hi, I discussed with penghui, he said that because the txn in TopicTransactionBuffer has been recorded aborts txn(if transaction retention in tc, tc use memory will increase in the txn retention time), so may we should continue to discuss until the solution is perfect


Can't navigate linked tutorials in IBM quantum lab

What is the current behavior?
Following what has been reported on slack and in #1215 , documentation seems a bit broken right now.
A work around to access the notebooks is to navigate in ibmqx to the tic-tac-toe menu > quantum lab.
There are folders for the tutorials and textbook (thanks!). But it seems that any links these might have will not be able to reach its destination. Example: qiskit-tutorials/start_here.ipynb

This is now resolved.  Thanks for reporting.

thank you, for fixing it 😄


updating deps, removing wip, fix close

[DOC] Removed WIP from readme

[VERSION] Bumped to 0.0.26, also bumped min versions for node-nats and node-nuid deps to current ones

[FIX] If nats close is called, the close is also triggered on stan, but response from close request to stan is waited for. Also request for close is made using a timeout.

[FIX] Test for reconnect needed to invoke a timeout as the reconnect would ignore the reconnecting client.

[Updated] nats-streaming-server image pulled for tests.

[Updated] node-nats and nuid dependencies

Coverage decreased (-0.3%) to 95.745% when pulling 25315387c2de96cad1203e99a91a0ae53706d5b5 on non-wip into 702afc65df06cc5a669039650ba0bd1003f33b10 on master.

Coverage decreased (-0.3%) to 95.745% when pulling 3dc6b974716a6b3417ee96b8cfaa442abe855f62 on non-wip into 702afc65df06cc5a669039650ba0bd1003f33b10 on master.

Lib changes look good.


Replace hard coded line separators with system specific ones in SMT checker

Hard coded \n results in false-positive assertion failures and confusing error messages in SMT checker when using Z3 on Windows.
The output log was: java.lang.AssertionError: assertion failed: Unexpected output: unsat but unsat is actually an acceptable output.
Contributor Checklist

[ ] Did you add Scaladoc to every public function/method?
[ ] Did you add at least one test demonstrating the PR?
[ ] Did you delete any extraneous printlns/debugging code?
[x] Did you specify the type of improvement?
[ ] Did you add appropriate documentation in docs/src?
[x] Did you state the API impact?
[x] Did you specify the code generation impact?
[x] Did you request a desired merge strategy?
[ ] Did you add text to be included in the Release Notes for this change?

Type of Improvement

bug fix

API Impact
No.

Backend Code Generation Impact
No.

Desired Merge Strategy

Squash: The PR will be squashed and merged (choose this if you have no preference.

Release Notes

Reviewer Checklist (only modified by reviewer)

[ ] Did you add the appropriate labels?
[ ] Did you mark the proper milestone (3.2.x, 3.3.x, 3.4.x, 3.5.0) ?
[ ] Did you review?
[ ] Did you check whether all relevant Contributor checkboxes have been checked?
[ ] Did you mark as Please Merge?

Awesome! Could you please also make a PR to fix this in FIRRTL?
https://github.com/chipsalliance/firrtl/blob/master/src/test/scala/firrtl/backends/experimental/smt/end2end/EndToEndSMTSpec.scala#L186

Awesome! Could you please also make a PR to fix this in FIRRTL?
https://github.com/chipsalliance/firrtl/blob/master/src/test/scala/firrtl/backends/experimental/smt/end2end/EndToEndSMTSpec.scala#L186

Here we go!
firrtl#2281


Hacktoberfest 2022

Add icons to make it more attractive in Readme.md

thanks for your time.
don't forget to ⭐ us please
😉

Thnks


V2 - Action Sheet opening Alert freezes app

Note: for support questions, please use one of these channels:
https://forum.ionicframework.com/
http://ionicworldwide.herokuapp.com/
Short description of the problem:
When opening a modal from an action sheet button, everything works as expected.  The modal opens, and the action sheet goes away.
When opening an alert (in my case, a radio alert), the action sheet does not close and the app essentially freezes in the action sheet state.
What behavior are you expecting?
I would expect the behavior between the modal and alert opened from an action sheet button click handler to function the same.  I would expect that functionality be to hide the action sheet and open the new modal/alert/whatever.
See short video showing issue here.
https://drive.google.com/file/d/0B6QFxGN0X4L_N3ZMZ1E2Z1N6d0k/view?usp=sharing
The video does not show accepting an option, but the same behavior is triggered when accepting an option.
Steps to reproduce:

Create an action sheet
Add a cancel button
Add a button that opens a modal
Add a button that opens an alert
Execute the code and click the button to launch the modal, observe.
Execute the code and click the button to launch the alert, observe how the app essentially freezes and the action sheet cannot be removed.

isolationDetails(isolation) {
	    var isolationId = null;
	    if ( isolation ){
	        isolationId = isolation.id;
	    }
	    let isolationDetailsModal = Modal.create(IsolationDetails, {
	        isolationId: isolationId,
	    });
	    isolationDetailsModal.onDismiss(data => {
			if ( data && data.isolationId ){
				this.associateHazardWithIsolation(data.isolationId);
			}
			else{
				// refresh the existing list just to be safe
				this.loadIsolationsForHazard(this.selectedHazard.id);
			}
	    });
	    this.nav.present(isolationDetailsModal);
	}

	addIsolationClicked(){
		let actionSheet = ActionSheet.create({
			title: "Isolations",
			buttons: [
				{
					text: "Create New Isolation",
					handler: () => {
						this.isolationDetails();
					}
				},
				{
					text: "Choose Existing",
					handler: () => {
						this.chooseExistingIsolation();
					}
				},
				{
					text: "Cancel",
					style: "cancel",
				}
			]
		});
		this.nav.present(actionSheet);
	}

	async chooseExistingIsolation(){
		// choose an existing isolation, so load all Isolations
		var isolations = await this.isolationHydrater.loadAllHydratedIsolations();
		let alert = Alert.create();
		for ( var isolation of isolations ){
			alert.addInput({
				type: "radio",
				label: `${isolation.isolationType.name} - ${isolation.equipment.name}`,
				value: isolation.id
			});
		}
		alert.addButton({
			text: "CANCEL",
			handler: data => {
				//console.log("Cancel clicked");
			}
		});
		alert.addButton({
			text: "OK",
			handler: data => {
				console.log(`Selected Isolation ID is: ${data.isolationId}`);
			}
		});
		this.nav.present(alert);
	}

Other information: (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)
Nothing interested is logged
Which Ionic Version? 1.x or 2.x
2.x
Run ionic info from terminal/cmd prompt: (paste output below)
Your system information:
Cordova CLI: 6.0.0
Gulp version:  CLI version 3.9.0
Gulp local:
Ionic Version: 2.0.0-beta.3
Ionic CLI Version: 2.0.0-beta.19
Ionic App Lib Version: 2.0.0-beta.9
ios-deploy version: 1.8.3
ios-sim version: 5.0.4
OS: Mac OS X El Capitan
Node Version: v4.2.3
Xcode version: Xcode 7.2.1 Build version 7C1002

I created a simple demo environment and tried to reproduce the issue that you're observing.
I had to replace the async-code with Promises because it didn't run otherwise (and I'm not sure how to make the async-code working in Plnkr).
It seems that everything works as expected (i.e. the problem cannot be reproduced). Maybe I missed something or made a mistake in the code though. Feel free to update it as needed.

Thanks for doing that @iignatov.  I'll look into the issue a bit more and see if I can isolate it.  Thanks for your help!

Thanks for the help @iignatov

@iignatov
I tried showing a basic alert with the example as in your code, but in the line
this.nav.present(alert)

I get the error

Error TS2339: Property 'present' does not exist on type 'NavController'
Am I missing something?


Remove debug print statement from CbAS

Given that FLEXS is supposed to be a package, it doesn't make sense to have raw print statements that can't be turned off inside of default implementations.

Great, thank you for catching this!


Adding Pakistan Map

This pull request is for adding the Pakistan Map along with it's constituencies

Hi and thanks for your contribution!
Before merging I had a few requests/questions:

Could you rebase onto the latest branch of master and recommit. It looks like your commits remove several of our existing maps.
What's the difference between Pakistan, Pakistan - New & Testing? Probably remove testing, and unless there is a good reason to have both Pakistan & Pakistan - New, can we just stick with one?
Rather than adding that mockIdField function, it'd be better to just update the topojson files with the proper ids.

If you can address these items I'd be happy to get this merged in

Yeah I figured, will work on those changes right away


libcamera-detect: Fix bug shown up by CompleteRequest move vs. copy f…

…ixes
The CompletedRequest gets (correctly) moved now rather than copied, so
you can't look in the metadata after sending it to the preview, you
must do it before.
Signed-off-by: David Plowman<EMAIL_ADDRESS>

@naushir This is the fix for my cat spy-cam!


Resizing image with a transparent background generates a thin white line in the output

I'm resizing images to generate versions in different sizes - some larger and others smaller than the original, but always the same aspect ratio.
This is the code I'm using to resize the image:
    await sharp(data)
        .resize(size)
        .png()
        .toFile(fileName);

When resizing a PNG with a transparent background, the output image gets a thin white line where the transition from the alpha channel happens.
This is the original image:

And this an example output:

At first sight, they seem exactly the same but when rendering the example output on top of a background with the same colour, we get this:

A zoomed-in version:

I was able to produce an image without the issue by using the nearest kernel:
    await sharp(data)
        .resize(size, size, {kernel: 'nearest'})
        .png()
        .toFile(fileName);

But the quality of the output image is much worse, as expected.
Flattening the image also removes the thin white line:
    await sharp(data)
        .resize(size)
        .flatten({background: '#3A81FE'})
        .png()
        .toFile(fileName);

But is also undesirable, as we don't know which colour the background will look like before hand.
I also tried other approaches, like setting the background colour on resize, other resize kernels, flattening the image with a transparent alpha channel,  but without luck.
This also happens with other images. I was able to reproduce with an SVG image as input.
Overall, any other approaches I could try?

Hi, thanks for the report, I can reproduce this using sharp v0.25.4 / libvips v8.9.1 but luckily this appears to work with the forthcoming libvips 8.10.0 so I think it might have been due to https://github.com/libvips/libvips/pull/1592
You can test this locally by installing sharp from the lovell/sharp#zoom work-in-progress branch.

v0.26.0 now available.


add sequence level metadata

Seems natural to have metadata at the sequence level rather than just the event level.

yeah, this is great.  One slight concern though is serialization.  This is definitely an object that should be serializeable.  If a user adds a complex python object here, it will in some cases break that.  Of course that will only affect that user, and will only occur when they're using useq in a context that actually does require serialization (such as a remote CMMCore, or over ZMQ for example) ... but we might want to consider how that would be handled, or whether we also now need to let the user declare how objects should be serialized

yeah, this is great. One slight concern though is serialization. This is definitely an object that should be serializeable.

hmm indeed. Though important to note that this PR doesn't introduce that issue as it already existed on the MDAEvent.  did we just never run into that limit when using remote, or were the pyro serializers better at handling complex python objects than json.dumps?


usb: testusb: Add README to the sample

The readme mostly combined from the PR #7435
Signed-off-by: Andrei Emeltchenko<EMAIL_ADDRESS>

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@296dab3). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #11431   +/-   ##
=========================================
  Coverage          ?   48.37%
=========================================
  Files             ?      265
  Lines             ?    42192
  Branches          ?    10137
=========================================
  Hits              ?    20412
  Misses            ?    17703
  Partials          ?     4077

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 296dab3...d509362. Read the comment docs.

@carlescufi Updated


export 'proxyWithHistory' (imported as 'ph') was not found in 'valtio-history' (module has no exports)

We are trying to add valtio-history to out project and we get the following error.

Out project is a monorepo using turborepo. the following is our package.json
{
  "name": "mapmap-client",
  "version": "10.5.10",
  "private": true,
  "dependencies": {
    "@cassiozen/usestatemachine": "^1.0.1",
    "@convertkit/slate-keymap": "^0.1.10",
    "@emotion/css": "^11.11.2",
    "@fortawesome/fontawesome-svg-core": "^6.4.2",
    "@fortawesome/free-brands-svg-icons": "^6.4.2",
    "@fortawesome/free-solid-svg-icons": "^6.4.2",
    "@fortawesome/react-fontawesome": "^0.2.0",
    "@hassanmojab/react-modern-calendar-datepicker": "^3.1.7",
    "@headlessui/react": "^1.7.17",
    "@mantine/hooks": "^6.0.9",
    "@plasmicapp/react-web": "^0.2.210",
    "@plasmicpkgs/antd5": "^0.0.204",
    "@stripe/react-stripe-js": "^2.2.0",
    "@stripe/stripe-js": "^2.1.3",
    "@tanstack/react-query": "^4.35.7",
    "@tanstack/react-query-devtools": "^4.35.7",
    "@use-gesture/react": "^10.3.0",
    "axios": "^1.5.0",
    "chart.js": "^4.4.0",
    "chroma-js": "^2.4.2",
    "eslint-plugin-node": "^11.1.0",
    "eslint-plugin-prettier": "^5.1.3",
    "fast-xml-parser": "^4.3.2",
    "feather-icons-react": "^0.6.2",
    "idb-keyval": "^6.2.1",
    "immer": "^10.0.3",
    "localforage": "^1.10.0",
    "lottie-react": "^2.4.0",
    "postcss": "^8.4.29",
    "randomstring": "^1.3.0",
    "react": "^18.2.0",
    "react-chartjs-2": "5.2.0",
    "react-dnd": "^16.0.1",
    "react-dnd-html5-backend": "^16.0.1",
    "react-dom": "^18.2.0",
    "react-resizable": "^3.0.5",
    "react-router-dom": "^6.15.0",
    "react-scripts": "^5.0.1",
    "react-selecto": "^1.26.1",
    "react-transition-group": "^4.4.5",
    "sass": "^1.66.1",
    "slate": "^0.94.1",
    "slate-history": "^0.93.0",
    "slate-react": "^0.99.0",
    "stream": "^0.0.2",
    "timers": "^0.1.1",
    "timers-browserify": "^2.0.12",
    "uuid": "^9.0.1",
    "valtio": "^1.11.3",
    "valtio-history": "^0.2.0",
    "valtio-persist": "^1.0.2",
    "xml2js": "^0.6.2"
  },
  "devDependencies": {
    "@tanstack/eslint-plugin-query": "^4.36.0",
    "@types/chroma-js": "^2.4.3",
    "@types/react": "^18.2.0",
    "@types/react-dom": "^18.2.14",
    "@types/react-resizable": "^3.0.7",
    "@types/uuid": "^9.0.7",
    "autoprefixer": "^10.4.15",
    "node-polyfill-webpack-plugin": "^2.0.1",
    "postcss-cli": "^10.1.0",
    "prettier": "3.0.3",
    "re-resizable": "^6.9.11",
    "tailwindcss": "^3.3.3",
    "typescript": "^5.0.4"
  },
  "scripts": {
    "dev": "react-scripts start & npm run watch:css",
    "build": "react-scripts build",
    "test": "react-scripts test",
    "eject": "react-scripts eject",
    "watch:css": "postcss -w src/css/input.css -o src/css/output.css",
    "format": "prettier --cache --list-different --write ."
  },
  "browserslist": {
    "production": [
      ">0.2%",
      "not dead",
      "not op_mini all"
    ],
    "development": [
      "last 1 chrome version",
      "last 1 firefox version",
      "last 1 safari version"
    ]
  }
}

From out research we have learned It seems to be an error regarding the webpack build.
The package is working on our other projects and empty projects.

I wonder if this is similar to https://github.com/jotaijs/jotai-optics/issues/14.

Additionally can you also state more environment info like node version as well

reading the error a bit more..its saying the our index file is not specifying the file extension of the utility
currently our file has
export * from './history-utility';

can you try to manually update it in your node_modules folder to
export * from './history-utility.js';

let me know if that works.

ive also found this related to the error
https://webpack.js.org/configuration/module/#resolvefullyspecified
please try to adjust this configuration and see if the error is resolved

version 0.2.1 was just released..please let me know if this works for you.

Thank you layton. this update solved the error 🕺


dagger: 0.2.28 -> 0.2.29

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/dagger/dagger/releases.
meta.description for dagger is: "A portable devkit for CICD pipelines"
meta.homepage for dagger is: "https://dagger.io"
meta.changelog for dagger is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.2.29 with grep in /nix/store/hm2n3sa92j8zisy33gvzsalpz2hkqsax-dagger-0.2.29
found 0.2.29 in filename of file in /nix/store/hm2n3sa92j8zisy33gvzsalpz2hkqsax-dagger-0.2.29

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
dagger

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/hm2n3sa92j8zisy33gvzsalpz2hkqsax-dagger-0.2.29 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A dagger https://github.com/r-ryantm/nixpkgs/archive/b60ee0eb0b63fd721c41be7a74529ab85e77b9eb.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/hm2n3sa92j8zisy33gvzsalpz2hkqsax-dagger-0.2.29
ls -la /nix/store/hm2n3sa92j8zisy33gvzsalpz2hkqsax-dagger-0.2.29/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

dagger

Maintainer pings
cc @jfroche @sagikazarmark for testing.


readme format

Pull Request Test Coverage Report for Build 104

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 27.871%

Totals

Change from base Build 103:
0.0%

Covered Lines:
500

Relevant Lines:
1794

💛  - Coveralls


composer issue

I am testing my app on both php 7 and hhvm.
I have successfully installed the relevant mongodb.so extension.
composer require "mongodb/mongodb=^1.0.0@beta"
I noticed that when I use php 7 to run composer update, it installs mongodb/mongodb (1.0.0-beta2).
The same code running MongoDB then works on php 7 BUT does not work on HHVM:
error: Fatal error: Call to undefined method MongoDB\\Driver\\Manager::getReadConcern() in /home/vagrant/Code/ICO2/vendor/mongodb/mongodb/src/Collection.php on line 105
When I use hhvm to run composer update, it removes 1.0.0-beta2 and installs 1.0.0-beta1.
The same code then WORKS on php 7 and hhvm.
What is going on? Is there are breaking change in the beta2 library?

This is due to the ReadConcern class not yet being implemented in the HHVM driver (see: HHVM-145). @derickr and I actually spoke about this earlier in the week, and it's definitely on his radar before tagging a 1.1.x release candidate.
On a somewhat unrelated note: we've been holding off on a stable release for HHVM due to an outstanding memory corruption bug we've been tracking.

I'm going to close this out as HHVM driver 1.1.0RC1 has been released and is now consistent with the 1.1.x API of the PHP driver). HHVM's memory corruption bug still has not been resolved, which is why it's an RC instead of stable release. Feel free to follow up if there's still an issue.


Rename phpstan.neon -> phpstan.dist.neon

Per https://phpstan.org/config-reference#config-file:

The usual practice is to have phpstan.neon.dist or phpstan.dist.neon
under version control, and allow the user to override certain settings
in their environment (on their own computer or on a continuous
integration server) by creating phpstan.neon that’s present in
.gitignore file.

I picked phpstan.dist.neon for consistency with
.php-cs-fixer.dist.php config (#5691).
I didn't add the file to .gitignore because I actually want to know if there starts being a new file under that name and see it in git...

Confirmed this new config file location is used in https://github.com/dependabot/dependabot-core/actions/runs/3041184101/jobs/4898047993#step:6:6746:
 Note: Using configuration file /opt/composer/v1/phpstan.dist.neon.


Multithreading support

Allows for very basic multithreaded sampling using the psample(model, alg, samples, chains) function. Requires Julia 1.3 or higher.
using Turing

@model gdemo() = begin
    s ~ InverseGamma(2,3)
    m ~ Normal(0, sqrt(s))
    1.5 ~ Normal(m, sqrt(s))
    2.0 ~ Normal(m, sqrt(s))
end

chains = psample(gdemo(), MH(), 1000, 4)

Output:
Object of type Chains, with data of type 1000×3×4 Array{Union{Missing, Real},3}

Iterations        = 1:1000
Thinning interval = 1
Chains            = 1, 2, 3, 4
Samples per chain = 1000
internals         = lp
parameters        = m, s

2-element Array{ChainDataFrame,1}

Summary Statistics

│ Row │ parameters │ mean    │ std      │ naive_se  │ mcse      │ ess     │ r_hat   │
│     │ Symbol     │ Float64 │ Float64  │ Float64   │ Float64   │ Any     │ Any     │
├─────┼────────────┼─────────┼──────────┼───────────┼───────────┼─────────┼─────────┤
│ 1   │ m          │ 1.15737 │ 0.823153 │ 0.0130152 │ 0.0242592 │ 871.953 │ 1.00229 │
│ 2   │ s          │ 2.0536  │ 1.67389  │ 0.0264665 │ 0.0516064 │ 1097.88 │ 1.00373 │

Quantiles

│ Row │ parameters │ 2.5%      │ 25.0%    │ 50.0%   │ 75.0%   │ 97.5%   │
│     │ Symbol     │ Float64   │ Float64  │ Float64 │ Float64 │ Float64 │
├─────┼────────────┼───────────┼──────────┼─────────┼─────────┼─────────┤
│ 1   │ m          │ -0.405005 │ 0.674982 │ 1.13412 │ 1.63625 │ 2.74961 │
│ 2   │ s          │ 0.604815  │ 1.15447  │ 1.62179 │ 2.46583 │ 5.92489 │

It seems to work trivially with all the samplers, since the model and the sampler are deepcopied for each thread:
chains = psample(gdemo(), NUTS(), 1000, 4)

Output:
Object of type Chains, with data of type 500×11×4 Array{Union{Missing, Real},3}

Iterations        = 1:500
Thinning interval = 1
Chains            = 1, 2, 3, 4
Samples per chain = 500
internals         = acceptance_rate, hamiltonian_energy, is_accept, log_density, lp, n_steps, numerical_error, step_size, tree_depth
parameters        = m, s

2-element Array{ChainDataFrame,1}

Summary Statistics

│ Row │ parameters │ mean    │ std      │ naive_se  │ mcse      │ ess     │ r_hat   │
│     │ Symbol     │ Float64 │ Float64  │ Float64   │ Float64   │ Any     │ Any     │
├─────┼────────────┼─────────┼──────────┼───────────┼───────────┼─────────┼─────────┤
│ 1   │ m          │ 1.11925 │ 0.808271 │ 0.0180735 │ 0.0246458 │ 967.523 │ 1.00123 │
│ 2   │ s          │ 2.04593 │ 1.76884  │ 0.0395526 │ 0.064614  │ 1091.36 │ 1.00281 │

Quantiles

│ Row │ parameters │ 2.5%      │ 25.0%    │ 50.0%   │ 75.0%   │ 97.5%   │
│     │ Symbol     │ Float64   │ Float64  │ Float64 │ Float64 │ Float64 │
├─────┼────────────┼───────────┼──────────┼─────────┼─────────┼─────────┤
│ 1   │ m          │ -0.493255 │ 0.622198 │ 1.10681 │ 1.60489 │ 2.73904 │
│ 2   │ s          │ 0.585433  │ 1.06458  │ 1.55281 │ 2.41384 │ 6.69643 │

How should we handle the tests on this one? Restrict the psample tests to only 1.3+ or something? Anyone see any obvious parallel problems I may have caused?

Is the random number generator thread-safe in Julia 1.3? It isn't currently.

I think so? I'm not sure, though. From the blog post:

The approach we’ve taken with Julia’s default global random number generator (rand() and friends) is to make it thread-specific. On first use, each thread will create an independent instance of the default RNG type (currently MersenneTwister) seeded from system entropy. All operations that affect the random number state (rand, randn, seed!, etc.) will then operate on only the current thread’s RNG state. This way, multiple independent code sequences that seed and then use random numbers will individually work as expected.
If you need all threads to use a known initial seed, you will need to set it up explicitly. For that kind of more precise control, or better performance, we recommend allocating and passing your own RNG objects (e.g. Rand.MersenneTwister()).

That's cool. But the blog post seems to be talking about calling rand and its family without the rng argument. I think if you pass the rng argument explicitly things may be different. Just to be sure, try sampling 4 random numbers in a parallel and serial loop starting from the same deepcopied rng. Then check if:

Any 2 numbers generated by the parallel loop are the same
The numbers generated by the parallel and serial loop are the same or not, allowing a different order.
If 1 is true, then a race condition happened. If 2 is true, then no race condition happened but the same rng was used by all threads. I suspect 1 may be false but 2 is true.

Using the non-global rng gives the same values for the serial and threaded implementations, without a deep copy.
With a deep copy, the threads all generate identical values.
With the global range, they are independent samples.
Using RandomDevice as a rng provides completely separate samples in both threaded and serial implementations (with no deepcopy).

Currently this PR doesn't perform any deep copying of the rng -- it just uses either the GLOBAL_RNG (which is threadsafe) by default, or it accepts whatever the user passes in without making a copy. If they pass in RandomDevice then they'll get random samples, but if they set a seed manually with MersenneTwister then all the draws will be the same if you sort and compare them between the threaded/serial versions, though the threaded version will have a scalar multiple more draws because of the number of chains sampled.
It looks like the deepcopy is the wrong way to go for the rng, which is good, because I don't have to change anything. The default GLOBAL_RNG is safe, but custom seeds might cause a bit of trouble.
I have a question on the concerns for sample validity on that. Let's say I draw five random numbers two ways. One is parallel, one is serial. In the end, the same set of random numbers are generated but in a different order. Does this invalidate the sample or otherwise cause some kind of numerical issue?
Perhaps by default we should use the initial range to set one seed for each chain, which will maintain reproducibility regardless of the number of chains. Something like
seeds = [rand(rng, UInt) for _ in 1:n_chains]

Threads.@threads for i in 1:n_chains
    crng = MersenneTwister(seeds[i])
    # do chain stuff
end

Alright, I've addressed @mohamed82008's notes by pre-generating a vector of seeds, one for each chain. The seeds are on a per-chain basis because I wanted to ensure that each chain was sampled deterministically (according to it's seed) regardless of how many threads were used -- if you run psample with only two threads but you ask it to sample four chains, you will get the exact same result as if you had used 1, 10, or 30 threads. There's some additional code in there to make sure that the chains are all ordered in the same way every time.
There's some tests in here, but they'll only run on 1.3+, so I've hardcoded that restriction into the testing suite.
I'm ready for a formal review.


Flip Tile Small Bug With Button Size

Buttons stay stuck selected after tapping them on phone (like the animation stays enlarged). Fix this

Duplicate ticket, closing