Question about the mismatch between semantic images and RGB images

Habitat-Lab and Habitat-Sim versions
Habitat-Lab: 0.2.2
Habitat-Sim: 0.2.2
Docs and Tutorials
Did you read the docs? YES
Did you check out the tutorials? YES
Perhaps your question is answered there. If not, carry on!
❓ Questions and Help
Mismatch of semantic images and RGB images.
I use the Object-Nav for MP3D configs to create a simple demo and the configs are listed as follows:
ENVIRONMENT:
  MAX_EPISODE_STEPS: 500
SIMULATOR:
  TURN_ANGLE: 30
  TILT_ANGLE: 30
  ACTION_SPACE_CONFIG: "v1"
  AGENT_0:
    SENSORS: ['RGB_SENSOR', 'DEPTH_SENSOR', 'SEMANTIC_SENSOR']
    HEIGHT: 0.88
    RADIUS: 0.18
  HABITAT_SIM_V0:
    GPU_DEVICE_ID: 0
    ALLOW_SLIDING: False
  SEMANTIC_SENSOR:
    WIDTH: 256
    HEIGHT: 256
    HFOV: 79
    POSITION: [0, 0.88, 0]
  RGB_SENSOR:
    WIDTH: 256
    HEIGHT: 256
    HFOV: 79
    POSITION: [0, 0.88, 0]
  DEPTH_SENSOR:
    WIDTH: 256
    HEIGHT: 256
    HFOV: 79
    MIN_DEPTH: 0.5
    MAX_DEPTH: 5.0
    POSITION: [0, 0.88, 0]
TASK:
  TYPE: ObjectNav-v1
  POSSIBLE_ACTIONS: ["STOP", "MOVE_FORWARD", "TURN_LEFT", "TURN_RIGHT", "LOOK_UP", "LOOK_DOWN"]
  SENSORS: ['OBJECTGOAL_SENSOR', 'COMPASS_SENSOR', 'GPS_SENSOR']
  GOAL_SENSOR_UUID: objectgoal
  MEASUREMENTS: ['DISTANCE_TO_GOAL', 'SUCCESS', 'SPL', 'SOFT_SPL']
  DISTANCE_TO_GOAL:
    DISTANCE_TO: VIEW_POINTS
  SUCCESS:
    SUCCESS_DISTANCE: 0.1

DATASET:
  TYPE: ObjectNav-v1
  SPLIT: val
  DATA_PATH: "/home/henry/Desktop/dataset/rl_envs/habitat-lab/data/datasets/objectnav/mp3d/v1/{split}/{split}.json.gz"
  SCENES_DIR: "/home/henry/Desktop/dataset/rl_envs/habitat-lab/data/scene_datasets/"

And the python code are listed as follows:
import habitat
import cv2
import numpy as np
from habitat_sim.utils.common import d3_40_colors_rgb
import os
os.environ["MAGNUM_LOG"] = "quiet"
os.environ["HABITAT_SIM_LOG"] = "quiet"
def make_rgb(rgb_obs):
    return rgb_obs
def make_semantic(semantic_obs):
    semantic_image = np.zeros((semantic_obs.shape[0],semantic_obs.shape[1],3),np.uint8)
    semantic_image = np.resize(d3_40_colors_rgb[semantic_obs.flatten()%40],semantic_image.shape)
    return semantic_image
def make_depth(depth_obs):
    heatmap = cv2.applyColorMap((depth_obs*255.0).astype(np.uint8), cv2.COLORMAP_HOT)
    return heatmap

config = habitat.get_config("./config/imagenav_mp3d.yaml")
env = habitat.Env(config=config)
obs = env.reset()
while not env.episode_over:
    while True:
        key = cv2.waitKey(1)
        if key == 97:
            action = 2
            break
        elif key == 100:
            action = 3
            break
        elif key == 119:
            action = 1
            break
        cv2.imshow("image",obs['rgb'])
        cv2.imshow("semantic",make_semantic(obs['semantic']))
        cv2.imshow("depth",make_depth(obs['depth']))
    obs = env.step(action)

But the output semantic images seem to be captured from a top-down view, maybe I got the wrong configuration?

https://github.com/facebookresearch/habitat-sim/issues/1808


Nested Documents

How to use mongo connector to indexing fields of embedded documents for solr? For example the field StreetName of:
{
  "_id" : ObjectId("52fa3674395d4602b8be4a1b"),
  "AddressDirectory" : {
    "Owner" : "Mayank",
    "Age" : "24",
    "Company" : "BIPL",
    "Address" : {
      "HouseNo" : "4",
      "StreetName" : "Rohini",
      "City" : "Delhi"
    }
  }
}

The manual says the connector flattens the nested documents but in solr I cant see the flatted field StreetName.

Hi, is it possible to keep existing structure in MongoDB for Solr? Solr supports multivalues so I have an array in Mongo and expect Solr to insert array as well, copyField solution is not an option for me because I have a lot of dynamic fields and I can't define all fields in my schema.xml. So it's really critical to have ability to insert arrays like:
 "category_ids" : [
NumberLong(2),
NumberLong(13),
NumberLong(14),
NumberLong(15),
NumberLong(16),
NumberLong(37)
]

Hi Anna,
Mongo Connector automatically unwinds arrays. For the rationale behind
this, see
https://github.com/10gen-labs/mongo-connector/issues/148#issuecomment-48931974.
This is not configurable right now.
On 5/29/15 14:28, Anna Vakulchyk wrote:

Hi, is it possible to keep existing structure in MongoDB for Solr?
Solr supports multivalues so I have an array in Mongo and expect Solr
to insert array as well, copyField solution is not an option for me
because I have a lot of dynamic fields and I can't define all fields
in my schema.xml. So it's really critical to have ability to insert
arrays like:
|"category_ids" : [
NumberLong(2),
NumberLong(13),
NumberLong(14),
NumberLong(15),
NumberLong(16),
NumberLong(37)
]|
—
Reply to this email directly or view it on GitHub
https://github.com/10gen-labs/mongo-connector/issues/89#issuecomment-106940349.


Option to only attempt API connection manually

It would be nice to have the option to have the plugin only attempt to connect to the webui API when I manually tell it to. Such as a "Connect" button under the Endpoint text box.
I use Photoshop frequently for things other than just stable diffusion, but if I open Photoshop while the webui is not running, I get a disruptive error telling me that it failed to connect. I would prefer if it would not even try connecting unless I tell it to.
Perhaps it could have a checkbox for automatically connecting so that users who only use Photoshop for this plugin can continue using it like before.

Yes, I booted mine up to do some things without SD being loaded and that popup hit me.  Annoying, so maybe a checkbox in settings to have it or turn it off forever would be nice.

Changed the logic of connecting - if your endpoint was inserted before then the plugin will only try to connect after clicking the 'Generate' button. If you do not have an endpoint, then it will try to connect after inserting it. The same is for models, so #19 is fixed too.


how does swr work with useEffect??request many times when props change.

it‘s my first time to use this library. useSWR('/api/data', fetchData) will excute when App props changes. how can i use useEffect let it only work in componentDidMount..it seems not work in  useEffect.
import useSWR from 'swr'
import fetchData from './fetch-data'

function App () {
  const { data } = useSWR('/api/data', fetchData)
  // ...
}`
expect
`import useSWR from 'swr'
import fetchData from './fetch-data'

function App () {
useEffect(() => {
 const { data } = useSWR('/api/data', fetchData)
  // ...
}, [])
}

You can't call hooks inside useEffect: https://reactjs.org/docs/hooks-rules.html#only-call-hooks-at-the-top-level
Instead you can do this:
function App () {
  const [mounted, setMounted] = useState(false)
  const { data } = useSWR(mounted ? '/api/data' : null, fetchData)

  useEffect(() => {
    setMounted(true)
  }, [])
}

When key is null, SWR will pause itself. It's also explained here https://github.com/zeit/swr#key-as-a-function.

@quietshu Maybe I'm missing the intent here, but wouldn't fetch happen on every rerender this way? (since mounted is going to be always true)

@moroshko nope, SWR isn't like the normal fetch call. It will reuse the result, and only fetch again in certain cases by default (for example if you refocus on the window).

@shuding My fetched URL changes depending on some <select>. How does SWR handle that without useEffect?
That is... how can I accomplish something like below if I can't nest useSWR?
const [selectOption, setSelectOption] = useState()

useEffect(() => {
  useSWR(`https://api.example.com/${selectOption}`) // 🚨 can't nest hooks
}, [selectOption])

return (
  <select>...</select>
)

@corysimmons you can just remove that useEffect:
const [selectOption, setSelectOption] = useState()
useSWR(`https://api.example.com/${selectOption}`)

return (
  <select>...</select>
)

@shuding Awesome. btw I like your Github quote and domain name. Thanks for the nice library!

I'm having this same issue.  I'm using the setMounted technique shown above.  However, I still see network requests to my SWR endpoint when I change another property on the component and render gets called.  Maybe SWR always makes the call in DEV mode?

RevalidateOnFocus make SWR run a new fetch every time the tab recover focus, when you focus on the browser DevTools the tab lose focus, when you click again in the page it will recover the focus and revalidate the data triggering a new request.


Add a way to dismiss PopupMenu elements

In native Android apps, like the YouTube app, context menus are closed when the device orientation changes.
In React Native apps instead, when having a PopupMenu open and rotating the device, the PopupMenu is not dismissed and appears in a wrong position on the screen.
This PR exposes a dismissPopupMenu method to allow the application to dismiss any open PopupMenu:
UIManager.dismissPopupMenu()

@miguelsm should we rather aim to dismiss the popup when the screen is rotated or very least fix the position on rotation?

@chirag04 That would also work for this particular use case. I've tried dismissing the popup from the NativeViewHierarchyManager.updateLayout method and it works fine. Doing it this way would require fewer changes in the code than my original commit (just that one file). The only drawback I see in dismissing the popup menus this way is that it wouldn't allow for dismissing them programatically from the app.

Rebased, thank you.
On Tue, Jan 30, 2018 at 5:57 PM Héctor Ramos<EMAIL_ADDRESS>wrote:

@hramos requested changes on this pull request.
Please rebase.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/pull/15636#pullrequestreview-92659261,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAqVEIYkHNsGsChtYekRrWOtF32iOqs3ks5tP1fogaJpZM4PBeoK
.


An official release that builds out of the box on macOS again

I'm running into https://github.com/projectatomic/skopeo/issues/380 and although I can use the workaround in there, but https://github.com/projectatomic/skopeo/pull/382 has a fix for it from a couple of months ago, but it isn't included in any tagged version. Can we get a "release" that builds out of the box on Darwin?

Yeah, a release should happen soon at least for #416.
Could you also check that #406 works for you, please?

With 0.1.28:
$ cd ~/Go/src/github.com/projectatomic/
$ mv skopeo skopeo0
$ tar xf ~/t/skopeo-0.1.28.tar.gz
$ mv skopeo{-0.1.28,}
$ cd skopeo
$ make binary-local
…
$ ./skopeo --override-os linux inspect docker://busybox|head
{
    "Name": "docker.io/library/busybox",
…

Building seems to work as documented; please reopen this if that’s not the case.


How to ask for scope in the request, scope must be presented on the initial request.

The scope is hardwired to profile. This means that the dialog that comes from google tells the user that the calling application does not want the users email (for instance).
In other words line 149 has
try response.redirect("https://accounts.google.com/o/oauth2/auth?client_id=(clientId)&redirect_uri=(callbackUrl)&scope=profile&response_type=code")
the scope hard wired.
This needs to be settable from the app calling for authentication.
Further if we change line 149 to include the email scope, and add the returned email address from google to the UserProfile on line 120, the Kitura-Credentials  above this will remove the email.
The rebuild of the UserProfile happens on lines 70 - 74 in
https://github.com/IBM-Swift/Kitura-Credentials/blob/master/Sources/Credentials/Credentials.swift
Since the Kitura-Credentials rebuilds the profile, it seems like that is a bug, but I'm not sure on that.

Yes, the scope is hard wired and we only keep the user id and name.
I will try to make both the scope and user profile configurable.

I created an issue in Kitura for this problem - IBM-Swift/Kitura#888

@tomandersen This should be fixed now, could you please verify?

Sorry - can't verify with a code test right now, as we are not actively using Kitura swift, but the code looks like it should do the trick. Thanks.


Task incrementation issues

It appears that on the 3rd or so task of a job incrementing fails.  The next task it pulls up tends to be either the same task or a the first task of the job, or just a garbage task that makes no sense.

After much searching I found that the cur pointer in job gets moved somewhere completely different when a new job is pointed and no longer points to the correct task.


Adding a tiny UI element to depictions screen to distinguish from category

Summary:
Our new depictions screen seems very similar to the category selection screen. I think our long term users can find this confusing. We can add some UI element to distinguish it from category screen.
My suggestion is displaying a text before user enters any input, saying "We have a new feature to enter depictions, yaaay!" or some more proper explanation :)

I was wondering if we should display the name of the step at the top of the screen (i.e. "Step 2 of 4: Depicts", "Step 3 of 4: Categories"), along with associated tooltips (as an "i" icon at the side).

I agree, we should display names.

From what I understand, you want to add an icon "i" of tooltips that explains what each step does, if nobody has done it, could I do it?

@PaulinaQuintero We want the name of the step and then a tooltip. So for instance in your screenshot, the title would have "Step 3 of 4: Add categories ["i"]".

Hi @PaulinaQuintero , do you have an update on this?

Hi, I would like to try and solve this issue. @misaochan
Also, for adding "Categories" there is already a tag inside strings.xml but for Depicts I could not find one. I could find Depictions though.. So I was wondering, if I add an extra string in strings.xml, won't we need to add that for all the translations? Do some steps need to be followed for that?

Hi @anadi198 thanks for your interest. No we don't need to add translations for all these languages. They are translated explicitly, we only edit the default file.

Okay thank you for clarifying.
tvTitle.setText(getString(R.string.step_count, callback.getIndexInViewFlipper(this) + 1,                 callback.getTotalNumberOfSteps()));
So from what I've understood, I need to add ": Categories" and such inside those, and then put tvTitle inside a horizontal LinearLayout on the end side of which is the tooltip icon. Is that the correct way?

@PaulinaQuintero We want the name of the step and then a tooltip. So for instance in your screenshot, the title would have "Step 3 of 4: Categories ["i"]".

Also what do I show when the tooltip is clicked?

Also what do I show when the tooltip is clicked? @misaochan

@sivaraam @nicolas-raoul Any thoughts on what text we should put in the "depicts" tooltip?

I see the following description for depicts in Commons:Structured data

Under the Structured data tab, you can indicate what is portrayed ("depicted") in the file.

... and Commons:Depicts seems to have a more detail about depicts about it.
Combining that information with the way in which we phrase the other tooltips in the upload flow, the following would be my suggestion:

Please choose all the items that this image portrays. Be as specific as you can. If the image portrays multiple items, choose them all. Do not choose generic tags if more specific tags are available.

Thanks @sivaraam , that looks good to me. :) @anadi please feel free to use the above text for the tooltip.

Hi @anadi198 , are you still working on this?

Hi @misaochan, I got caught up with some work after my last comment. But I would like to give this a try. I'll try to fix it tonight and then let you know.

Thanks @anadi198 , please let us know how it goes. :)

@misaochan I had a look and have a few questions:

How do I update R.string.step_count to, for example, have : %3$s since it starts giving me ~100 errors in all the translation files(I really hope the answer is not what I'm thinking it is :D)
What text do I show when tooltip is pressed for Categories and such? Is there something already available somewhere?
Just to confirm, the steps other than Depicts are: Categories, Media License and Upload Media Details, right?

I'm new so I don't know much about the project, sorry!

@anadi198 If it is warnings you can safely ignore them. If it is errors, have you tried https://stackoverflow.com/a/11444141/226958 maybe?
You are right about the 4 steps.
Here are tooltips for each:

Media details: Please write a short caption that says what your picture shows. In the description, say what makes the picture interesting or typical or rare, and explain the context, visible or not. Use exact terminology as much as you can.
Depictions: Please find and select all concepts that this image portrays. Be as specific as you can. If the image portrays multiple items, choose them all within reason. Do not choose generic tags if more specific tags are available. (thanks sivaraam for the great wording!)
Categories: Please select the appropriate categories. Unlike depictions, categories are only in English. (it would be great to explain how categories differ conceptually from depictions (which are perpendicular rather than a tree) but I could not find the right word, this can be improved in the future.
License: Commons makes your pictures reusable and adapted by everyone. Do you want to waive all rights? Do you want to be attributed? Do you want adaptations to use the same license?

I don't remember whether we have a policy about using "please". Anyway that can easily be changed later.

Okay thank you for the clarifications. The "errors" were indeed just warnings.
There are two ways of adding icon at the end of a TextView(as far as I know), one is to use the drawableEnd property and the other is using a separate ImageView inside a parent layout. Since setting the onClick isn't simple for the first choice and the second one adds layers to the UI, I would like to know which one I should go with. @misaochan

If we were to use TextInpuLayout endIcon then I think it might overlap with the progress indication so if you think that looks better we might have to move the progress indication elsewhere

@nicolas-raoul  we can place the icon inside the TextInputEditText and on the side of progress bar like this.

If no one works now then I want to take this issue.

Hi @gouri-panda , I guess @anadi198 is working on this task currently. You can fin a new task to work on if you like to:) The it comes to the question of @anadi198 , you can implement the solution you liked most, any changes can be made during PR review stage.

I can't log in to my Commons Beta account, it keeps giving a 502 under maintenance message. It hasn't fixed for the past few hours. Did I do something wrong? Sign up or forgot password, none seem to work.
Request from - via deployment-cache-text06.deployment-prep.eqiad.wmflabs, ATS/8.0.8 Error: 502, Next Hop Connection Failed at 2020-11-11 17:05:31 GMT
Sorry for posting this here if there's some better place for it.

@anadi198 can you login via web interface? Can you login to prod account? Are you sure you are not blocked and password is correct?

I can log in to the prod version (from Google Play) just fine. @neslihanturan

I had a look and although not exactly as same as mine I found a similar closed issue, recommending to install the prod debug build which I did and now I've tested that my changes indeed to work. I think further questions/corrections will be best made in the PR so I'll be opening one.


Loss over a padded and masked sequence

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 19.10
TensorFlow installed from (source or binary): pip
TensorFlow version (use command below): v2.1.0-rc2-17-ge5bf8de
Python version: 3.7

Describe the current behavior
The data I'm working on is a collection of sequences of different length. I have padded all the sequences to the same length and written an LSTM model that uses masks to ignore the padded part of the data.
The loss at each step is given by the sum of the losses at all points in the sequences divided by the total length of the sequences, original + padded part.
Describe the expected behavior
I expected the loss to be given by the sum of the losses at all points in the sequences divided by the total length of the original sequences, discarding the padded part.
Is this the intended behavior? And are the two fundamentally equivalent, from the point of view of the backprop algorithm?
Standalone code to reproduce the issue
import numpy as np
import tensorflow as tf
from tensorflow.keras import Model
from tensorflow.keras.layers import LSTM

# Config
N = 32
T = 10
n = 2
mask_value = -1.
tf.random.set_seed(1)
np.random.seed(1)

# Data creation
X = np.ones((N, T, n)) * mask_value
Y = np.ones((N, T, 1)) * mask_value
for i in range(N):
    l = np.random.randint(1, T)
    value = np.random.random([l, n])
    X[i, :l] = value
    Y[i, :l] = np.array([sum(v) > 0.5 * n for v in value])[:, None]

class MyModel(Model):
    def __init__(self, n, mask_value, *args, **kwargs):
        super().__init__(name='MyModel', *args, **kwargs)
        self.mask_value = mask_value
        self.n = n
        self.LSTM = LSTM(self.n, return_sequences=True, activation='linear')
        return

    def call(self, inputs, training=None, mask=None):
        mask = tf.cast(tf.reduce_sum(inputs - self.mask_value, axis=-1), tf.bool)
        x = self.LSTM(inputs, mask=mask)
        return x

model = MyModel(n, mask_value)
model.build(input_shape=(N, T, n))
model.compile(
    optimizer='adam',
    loss='binary_crossentropy',
    metrics=['accuracy'],
)
model.summary()

mask = 1 - tf.cast(tf.reduce_all(tf.equal(X, mask_value), axis=-1), tf.float32)
loss_unmasked = tf.reduce_mean(tf.keras.losses.binary_crossentropy(Y, model.predict(X)))
loss_masked_1 = tf.reduce_sum(tf.keras.losses.binary_crossentropy(Y, model.predict(X)) * mask) / tf.reduce_sum(mask)
loss_masked_2 = tf.reduce_sum(tf.keras.losses.binary_crossentropy(Y, model.predict(X)) * mask) / (N * T)
print(f"model.evaluate(X, Y): {model.evaluate(X, Y)[0]:.2f}\n"
      f"loss_unmasked       : {loss_unmasked:.2f}\n"
      f"loss_masked_1       : {loss_masked_1:.2f}\n"
      f"loss_masked_2       : {loss_masked_2:.2f}"
      )

Got similar values with TF v2.1 and TF v2.2.0-rc4. Please find the attached gist. Thanks!

Yes, this is the behavior I see as well: the loss given by the model is equal to loss_masked_2. However, I believe it should be equal to loss_masked_1. Let me explain why this might be problematic.
For example, let's consider two identical data points. With the current implementation their contribution to the loss changes depending on the batch they find themselves in. Let us say that the first one is in a batch which has been padded to length N and contributes to the total loss of a quantity L; if the second one is padded to length 2N, its contribution to the loss will be L / 2. This seems contradictory with the whole idea of masking.
After delving a bit more into the training loops, I suspect that it doesn't impact the training anyway because the value shown is actually never used. However, it reports incorrect information to the user.

Was able to reproduce the issue in TF 2.5 and Nightly versions.Please find the gist here.

Hi There,
This is a stale issue. As you are using an older version of tensorflow, we are checking to see if you still need help on this issue. Please test the issue with the latest TensorFlow (TF2.7 and tf-nightly). If the issue still persists with the newer versions of TF, please feel free to open it in keras-team/keras repository by providing details about the issue and a standalone code to reproduce the issue. Thanks!
Please note that Keras development has moved to a separate Keras-team/keras repository to focus entirely on only Keras. Thanks!


Adding JavaScript to the application

Adding JavaScript to the application as well as my first for loop.

all done


[RTL] Flop exc_req in controller to ease timing

Fixes #305
@udinator would you be able to run some tests on this change?  I've done some basic tests to ensure exceptions continue to function but if you had something more in-depth to try out that would be useful.

Hi @GregAC - I ran tests that use illegal instructions and ebreak to trigger exceptions, with your modifications to the controller, and these are all passing successfully!
With regards to the above discussion with @vogelpi about not setting the exception request when transitioning out of the FLUSH state into DECODE or something else, I'm seeing the following occur:

The instruction at PC=0x8000068e is illegal, so when it gets into the decode stage of the pipeline, it triggers an exception. As per what you said above, exc_req_q is high during FLUSH state, but then remains high afterwards in DECODE state, until the first instruction of the exception handler code (at PC=0x80013000) moves into the pipeline decode stage, as the illegal instruction still remains in the decode stage. This is something that should not happen based on your description of the intended behavior, correct?

@udinator thanks for the test.  Interesting observation, doesn't actually mean there's a functional issue but I think this is slightly surprising behaviour.  The root cause of the issue is the illegal instruction output of the decoder isn't being qualified with the valid.  Some new testing would be appreciated.
So this PR is now two commits:

Factor instr_valid into the illegal instruction and illegal dret signals
Flopping things to break the timing path.  Realised I also needed to flop illegal_insn (otherwise it's used directly in the FLUSH stage and the value of pc_set depends upon leaving a long path in)

I've been playing with yosys and I believe I've now got rid of all of the long paths going into pc_set.  yosys is what highlighted the need for illegal_insn to be flopped.

@GregAC , the fixes you made to factor instr_valid into the illegal instruction signals seemed to work, the resultant waveforms for my illegal instruction test now look like below:

However, I'm noticing the same situation with exc_req being held high after the FLUSH state occurring for all other exception as well, an example using ebreak exceptions is below:

Of course, this is by no means a functional issue, just wanted to bring it to your attention, as the behavior of all other exceptions is still the same as before, maybe factoring instr_valid into ebreak_insn and ecall_insn would work also to normalize the new behavior?

Thanks @udinator.  I believe this latest version should cover everything now (or at least a good deal more than before!).
The first commit (Keep instr in ID valid for FLUSH state) is a bigger change than it used to be so I'll wait for input for @imphil and @vogelpi .  They're both away so may not get this merged til next week.
In the meantime another test would be appreciated.

@GregAC, I tested the exc_req_q changes using illegal instruction, ebreak, and ecall exceptions, and everything looks good to me now! Thanks for all of the changes.

@GregAC can you rebase this and fix the remaining small comments from Pirmin to get it over the finish line?


fix: prevent abuse against bosses and raids

Closes #11 (this PR is more broad)

Thankyou so much for getting this fixed. Disabling specific areas seems like the best approach for complying with Jagex guidelines
Closes issue #10


Get top-level path from git itself

This patch fixes #150. Feel free to edit.

Coverage remained the same at 95.413% when pulling 33f5a36a28bc077644a0a590f229b2e2edabbadb on nvasilakis:master into a84bdc87aabf79493343a366872ab204a62b1613 on observing:master.

This PR would most likely solve the issues I'm having, would love to se it getting merged


[DOCS] Explicitly state that to use external files lazyLoad MUST be set to true

Is your feature request related to a problem? Please describe.
I was getting a headache trying to figure out why the site wouldn't load the messages, until I tried to set lazyLoad to true and it worked (and broke again when setting it to false).
Describe the solution you'd like
Don't know if this behavior is intended. I don't expect it to change, but the documentation should state it more clearly if it is supposed to work this way.
Currently the docs mention external files only in case of lazy loading.
I personally don't have any issue with lazy loading the messages, but on the other hand I wonder if there's any case for wanting to load all translations right away. I don't see why it should not work, but it's not a request.
I would expect instead that the documentation addressed the topic of using external files directly, maybe with a specific paragraph somewhere regardless of lazy loading.
Describe alternatives you've considered
NA
Additional context
Willing to submit PR but I'm new to the project and didn't want to mess up the structure of the docs without asking for feedback and suggestions first.

Update various places in documentation to hopefully make this more clear.


[hoodie.account] implement HoodieAccountLocalChangesError in account.signOut

When calling hoodie.account.signOut() while having local changes that cannot be synced before signing out, due to a request error or because the user is unauthenticated, reject with HoodieAccountLocalChangesError and message: There are local changes that could not be synced to the server.

related: #194 #195 #262

closing in favor of https://github.com/hoodiehq/hoodie-client/issues/83


The README should have very basic building steps

In addition to the wiki link, it should also tell you the current basic build steps
Signed-off-by: John Floren<EMAIL_ADDRESS>

I'm assuming you tested it :=)
LGTM


Support rfc6901 syntax

Expressing the path to a JSON key is being standardized by the IETF with RFC6901 ("JSON Pointer"). I wanted to check if there are any plans to support the syntax proposed by that RFC and if so, what needs to be done to support that.

I haven't encountered RFC6901 before now. But from a cursory look the syntax seem similar to gison. Perhaps all that's needed is a path conversion function that converts the "JSON Pointer" slash syntax to gjson syntax.
#/name/first -> name.first


📃: Add a Task Manager App

🔴 Title : Task Manager
🔴 Tech stack : HTML, CSS, JS
🔴 Objective : To organize task
🔴 Summary : Basic app to add, remove and complete daily tasks
📸 Screenshots

✅ Details to Include When Taking the Issue:
Name : Mehendi Sil
Participant Role (Specify the Open Source Program name, e.g., GSSOC, Hacktoberfest, etc.): gssoc-ext, hacktoberfest

Happy Contributing! 🚀
Wishing you all the best on your open source journey. Enjoy! 😎

The project already exist, Do not be demotivated and raise a new issue.


Add common prefix functions to lib/strings

This extracts @go.common_prefix from libexec/glob, and adds @go.remove_common_path_prefix. I originally created these commits during the course of implementing #123 and #124, when I thought that ./go complete needed to do some path manipulation. They still seem like generally useful functions (even though I'm not using @go.remove_common_path_prefix yet).

Coverage increased (+0.03%) to 95.321% when pulling 6c4daa67a19c1506917dfe3e99c3ec4273fa353c on strings into e953cd267bc1757362cd3f447d76d4499e27cfe5 on master.


Quick Shape explaination

Hello, could you please explain the shape of the output of neck(). 384,248,216 doe this mean each voxel (248 in y and 216 in x have 384 associated features?)

In paper, Figure 2. Network overview. After input feature is extracted feature by backbone, the scale of feature map is (batch_size, 6C, W/2, H/2). And the C is 64,  so 64*6 = 384.


Add house to community not working

🐛 Describe the bug

Add house to community not working

⚠ Current behavior

Page does not do anything when trying to add house to community

This seems to be working fine in React Application. This issue can be closed

Thanks for the update @saraogipraveen and @Tobi406. Let us close this.


Fix nested attributed intrinsic

As reported in #12 by @thecb4:
A standalone XML element with attributed intrinsic works. When it's embedded in another element, it fails.
// This passes
  let previewTime =
  """
  <?xml version="1.0" encoding="UTF-8"?>
  <preview_image_time format="24/999 1000/nonDrop">00:00:17:01</preview_image_time>
  """.data(using: .utf8)!

  let decoder = XMLDecoder()
  decoder.errorContextLength = 10

  let metadata1 = try decoder.decode(PreviewImageTime.self, from: previewTime)
  print(metadata1)

// this does not pass
  let preview =
  """
  <?xml version="1.0" encoding="UTF-8"?>
  <app_preview display_target="iOS-6.5-in" position="1">
    <preview_image_time format="24/999 1000/nonDrop">00:00:17:01</preview_image_time>
  </app_preview>
  """.data(using: .utf8)!

  let metadata2 = try decoder.decode(AppPreview.self, from: preview)
  print(metadata2)

structs:
struct AppPreview: Codable {
  var displayTarget: String
  var position: Int
  var previewImageTime: PreviewImageTime
  // var dataFile: DataFile

  enum CodingKeys: String, CodingKey {
    case displayTarget = "display_target"
    case position
    case previewImageTime = "preview_image_time"
    // case dataFile = "data_file"
  }
}

struct PreviewImageTime: Codable, DynamicNodeEncoding {

  var format: String
  var value: String

  enum CodingKeys: String, CodingKey {
    case format
    case value
  }

  static func nodeEncoding(forKey key: CodingKey) -> XMLEncoder.NodeEncoding {
    print("node encoding")
    switch key {
      case CodingKeys.format:
        return .attribute
      default:
        return .element
    }
  }
}

@thecb4 this should be now fixed and is verified with a test based on the code you've provided. Please let me know if this is still reproducible for you in master.

Works!
output now
AppPreview(displayTarget: "iOS-6.5-in", position: 1, previewImageTime: test.PreviewImageTime(format: "24/999 1000/nonDrop", value: "00:00:17:01"))


Invalid connection

I'm trying to integrate DetoxIPC to open a communication channel between an app and an associated UI Testing runner app.
I fire up the server on the runner app and the client in the main application.
When I try to send a message to the remoteObject _DTXIPCDistantObject:47 is launching an exception because _connection.isValid is false.
I pushed a sample project that replicates the issue here: https://github.com/tcamin/DetoxIPC/tree/master/Issue/testIPC2
I added a podspec to integrate the library.

The order of your code is incorrect. You first launch your app in your tested project, which attempts connection to a non-existent service name "MyService".
Instead, create the server connection in the tester app before launching your application there. The connection should then succeed.

I might think about somehow making the API symmetrical at both sides, and have the first connection become the master, and if an existing connection exists, make the created a slave. But that will still not solve your issue because you attempt to call a method which is not yet exposed in your tested app.

Thanks again for taking a look, working great! One last question, is it expected that it cannot be compiled on physical devices (arm64)?

I’m not sure, I haven’t tried. What error message do you get?

It is not finding symbols for NSConnection. When linking I'm getting:
Undefined symbols for architecture arm64:
  "_OBJC_CLASS_$_NSConnection", referenced from:
      objc-class-ref in DTXIPCConnection.o
  "_NSConnectionDidDieNotification", referenced from:
      -[DTXIPCConnection _commonInit] in DTXIPCConnection.o
      -[DTXIPCConnection initWithRegisteredServiceName:] in DTXIPCConnection.o
      -[DTXIPCConnection _slaveDidConnectWithName:] in DTXIPCConnection.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

I see. I’m not sure, perhaps NSConnection is not available on iOS. It’s not a priority for us because we test on simulators, but I’ll take a look.

Any particular reason why you made - (id)synchronousRemoteObjectProxyWithErrorHandler:(void (^)(NSError * _Nonnull))handler unavailable?

It’s not implemented yet.


assert tags using acktest.tags

Description of changes:

change tag assertion to use test-infra utility methods

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/lgtm

@jljaco @RedbackThomson @A-Hilaly why were tests re-run yesterday for this PR that was merged 8 months ago?

@jljaco @RedbackThomson @A-Hilaly why were tests re-run yesterday for this PR that was merged 8 months ago?

🤷🏼♂  <-- My best guess

@jljaco @RedbackThomson @A-Hilaly why were tests re-run yesterday for this PR that was merged 8 months ago?

Oh so I ran a random ProwJob in the cluster just to make sure it was working. It was something that was lying around on my machine, I didn't pay too much attention to what PR was behind it. Guess you found it out

@jljaco @RedbackThomson @A-Hilaly why were tests re-run yesterday for this PR that was merged 8 months ago?

Oh so I ran a random ProwJob in the cluster just to make sure it was working. It was something that was lying around on my machine, I didn't pay too much attention to what PR was behind it. Guess you found it out

ahhh, gotcha :) figured it was something to do with the testing you were all doing on the Prow upgrade... now I know! thanks!


Filter by date

I'd like to be able to see the events that are within a given date range

closed with pr #14


Update 2

Seek reviews please
@malapheev

Hi @bethdilts,
Thanks for that aprooval!!!!!
Have a good day sir !

Read me


Clean up unittest deprecations and warnings

This PR cleans up a number of warnings and notices in the tests.
Motivation and Context

Needed to get aquatinted with the test infrastructure. Aside from that, general maintenance and keeping things neat.
Have you tested this? If so, how?

Tested locally with tox -e py36-nonhdfs and tox -e py27-nonhdfs.

Thank you so much!!!
Can you just fix the flake8 error? (also check why py27 fails)

@xoob, this is a really good PR which I would like to merge, can you just fix the flake8 error?

I'll take a shot at it this weekend.

On Fri, Jun 30, 2017 at 3:08 AM -0700, "Arash Rouhani"<EMAIL_ADDRESS>wrote:
@xoob, this is a really good PR which I would like to merge, can you just fix the flake8 error?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

looks awesome!

@Tarrasch @erikbern All tests and flake8 now pass.
Unrelated to the changes in this PR, the py27-cdh and py36-cdh suites time out after 50 minutes. This seems to happen on master too.

The commit message quality was quite mixed, but overall I thought it might be useful to keep the whole commit history as some commits were particularly useful to be able to introspect in isolation. So did a rebase-merge here. :)
Thanks a lot for this contribution. This greatly increases the code quality in luigi!

@Tarrasch Which commit messages worked for you and how would you improve the other ones?

@xoob good question! These are my opinion and they are by no means better than anyone else's:

I really liked the first one. As it has a clear description and useful details in the body
Actually I definitely liked most of your commits
I found one to have >20 lines of text in body. Which might feel not so scroll friendly in some views, and I doubt anybody is going to read all that, and it is maybe obvious from the actual code change.
I prefer flake8 fixes to not be separate, but I do it myself too, because it's so hard to amend them in later.
The last 3 commits seem to say the same thing and should probably have been only 1 (unless I'm mistaken).

Are any of these thoughts useful as feedback? :)

@Tarrasch Very useful, thanks. I could have amended and force-pushed the last three commits (and possibly the flake8 changes too), which I'll do next time. Appreciate the feedback.

I could have amended and force-pushed the last three commits

Not everyone is so responsive and to iterate on their commits. Thanks for your cooperation. ^^


Add user dictionary labels to ignore built-in attributes

Via the user dictionary, words can be labeled as attribute markers (Negation, Unit, Sentiment,...). However, it is not possible to ignore the built-in markers. We would like to get this extra option.
Implementing this will involve several steps:

Define UDIgnore-labels in the engine, so that they can be used in user dictionaries.
Extend all language models that support user dictionaries with labels and rules to interpret the new labels.

This issue concerns step 1.

I tested the implementation in branch DP-3340 through a preliminary (unreleased) adaptation in the English language model and user dictionary, and I can confirm that it works. Thank you!

I see that this is in master now, so I'm closing this issue.


Which python files are about RPN and ROI pooling layer in your Faster RCNN code?

Thank you share your work! I am studying your code. I found a RPN and ROI pooling layer are set in Faster RCNN, I searched your code file but not found them.  Which python files are about RPN and ROI pooling layer in your Faster RCNN code? Please instruct me. Thank you very much!

It is in the network definitions.. you can search for vgg16 for example.


local variable 'lidar' referenced before assignment

The following error occurs while writing the segmented point cloud :
error.log

Hello @AbdelghaniTamort,
Thanks for your feedback. This error should be corrected in the next version 0.1.6. I'll release it in a week.


Superfluous quotes in lockfile

metadata:
  content_hash:
    osx-arm64: '"e90c2ee71ad70fc0a1c8302029533a7d1498f2bffcd0eaa8d2934700e775dc1d"'

Generated with Pixi 0.0.8

It may also make sense to add a version to the lockfile similar to how pnpm does it. https://github.com/mamba-org/setup-micromamba/blob/2ee1938ba9ff3b184b94f8bdd4a0b0cd9976bbe9/pnpm-lock.yaml#L1
NPM does it as well in their package-lock.json https://github.com/puppeteer/puppeteer/blob/9a814a365644a1e404eb36266a08f579bb2c26ac/package-lock.json#L3

Thanks @jonashaag ! I fixed the issue in rattler. Should be included in the next release of pixi.
@pavelzw We implemented the conda-lock file format which also doesn't include a version.
This is a bit off-topic but pixi also doesn't use the content-hash at all, there are better ways to solve the problems the content-hash was meant to solve. It is also already possible with the current format. That is what we are using in pixi.
We propose removing the field altogether, see https://github.com/conda/conda-lock/issues/432.


De-allocation crash after upgrading to 2.18.0

Up until recently I was using sol 2.17.1 (with C++-compiled Lua 5.3), and today I decided to upgrade to 2.18.0.
Without any changes to my code, my application now crashes when sol2 tries to destroy a usertype. The code that crashes is the following:
template <typename T>
inline int usertype_alloc_destroy(lua_State* L) {
	void* rawdata = lua_touserdata(L, 1);
	T** pdata = static_cast<T**>(rawdata);
	T* data = *pdata;
	std::allocator<T> alloc{};
	alloc.destroy(data); // <-- crashes here with read access violation
	return 0;
}

Maybe it's my debugger tripping, but it looks like the data pointer points to invalid data.

There's been a few cases of double-delete that popped up recently. I solved it on one instance but I still need to look more closely at what's going on.

Possible repro;
#include <sol.hpp>

#include <iostream>

class Entity {
public:
    ~Entity() { std::cout << "WHAT" << std::endl; }
};

int main()
{
    sol::state lua;
    lua.open_libraries();
    lua.new_simple_usertype<Entity>("Entity");
    sol::function test = lua.do_string(R"(
return function(e)
end
)");

    {
        Entity e;
        test(e); // same with std::ref(e)!

        lua.collect_garbage(); // destroys e for some reason
    }

    system("pause");
}```

Reference tables were being given the regular metatable (that is, one without the * in its name) and then calling the destructor on honest, hardworking usertypes. It seemed to only affect things in the simple_usertype case, at least here.
It's fixed and I need to push a new release since this is a back-breaking bug.

Fixed.


BUG: vocalpy.segment.ava occassionally can set last segment > length of sound in samples

because we convert from last offset time in seconds, computed from the spectogram time bins, back to sample number, using samplerate
I think this is an edge case that only happens because of vocalpy doing the extra work of converting to sample number for returning a Segments.
I determined this was happening with one of the edge cases and looked at the difference -- we give ourselves 408 "extra samples" with this one example. I should confirm this is true for all the other cases that raise the error.
Assuming it's true, we should check for it in a post-condition and fix when it happens.

After so more detective work, I think I have determined this is an edge case, that happens specifically when
By finding a file that throws this error and then manually inspecting inside a call to vocalpy.ava.segment, I can see that the last value of t itself, as returned by scipy.signal.stft is actually greater than the duration of the sound.
((Pdb)) t
array([0.0000000e+00, 2.0480000e-03, 4.0960000e-03, ..., 9.9962880e+00,
       9.9983360e+00, 1.0000384e+01])
((Pdb)) t[-1]
10.000384
((Pdb)) t[-1] * sound.samplerate
2500096.0
((Pdb)) sound.samples
2499585
((Pdb)) sound.duration
9.99834
((Pdb)) offsets[-1] - sound.duration
0.0020439999999997127

So when this happens, and the algorithm finds that the last time bin of the spectrogram is a segment offset, then we will already have a segment that is longer than the sound itself, before the function does anything to convert to sample number, etc.
Long story short: edge case, not our fault, we should just catch and fix


Cookies are not set by Javascript document.cookie (iOS)

Cookies sent by backend are stored, but not the ones set by app itself.
The following code:
document.cookie = "notified=1; path=/; expires=Tue, 19 Jan 2038 03:14:07 GMT";
console.log(document.cookie);

returns empty string ("").
Angularjs $cookies.put doesn't work either.
Also, in Safari web inspector, localhost cookies list stays empty.
Tested on iOS 12.4 device with cordova-plugin-ionic-webview v.5.0.0. No issue on Android.

Me too.Have you solved this problem?

@rootgrandfather Unfortunately no, rewrited my code to use local storage instead of cookies.

@July- Ok,maybe that's the final way.

Updating webiew and saw this bug.  Any fix with cookies.  The reason I was using cookies is so I can set them to expire in a day vs local store that stays forever,  or have to store a time and calculate things.
What is the fix/work around for this for cookies?   Any idea?


[testplan] Align milestone/stage terminology

This vendors OT into Ibex and alignes the milestone -> stage terminology.

This will have to be vendored back into OT once merged.


New package: TypedLazilyInitializedFields v0.1.0

Registering package: TypedLazilyInitializedFields
Repository: https://github.com/loganhotz/TypedLazilyInitializedFields.jl
Created by: @loganhotz
Version: v0.1.0
Commit: 0fdecb62c353111ed3010b81ad9393e056a56c0b
Reviewed by: @loganhotz
Reference: https://github.com/loganhotz/TypedLazilyInitializedFields.jl/issues/1#issuecomment-1806437170
Description: LazilyInitializedFields.jl with supertypes

This package is being registered because a PR made to LazyInitializedFields.jl (https://github.com/KristofferC/LazilyInitializedFields.jl/pull/32) wasn't reviewed. I suspect we can just get that PR merged instead of needing to create a whole new fork for this, so I'm going to leave a blocking comment, but I'll remove my block if Kristoffer won't accept your PR @loganhotz, does that sound good?
Kristoffer's bio on Github explicitly says "Message me on the JuliaLang Slack if you need something urgently. I sometimes declare "notification bankruptcy" and clean out all notifications. Keep pinging.", so I think there's a good chance he just missed your PR.

Yes that sounds great - I was hoping to work on this economics project in my own little corner, so I initially wanted to avoid bothering such a major person in the Julia community. I’ve pinged him on the JuliaLang slack.
Thank you for your help, Mason! Best,
Logan

On Nov 10, 2023, at 5:53 PM, Mason Protter @.***> wrote:
This package is being registered because a PR made to LazyInitializedFields.jl (KristofferC/LazilyInitializedFields.jl#32 https://github.com/KristofferC/LazilyInitializedFields.jl/pull/32) wasn't reviewed. I suspect we can just get that PR merged instead of needing to create a whole new fork for this, so I'm going to leave a blocking comment, but I'll remove my block if Kristoffer won't accept your PR @loganhotz https://github.com/loganhotz, does that sound good?
Kristoffer's bio on Github explicitly says "Message me on the JuliaLang Slack if you need something urgently. I sometimes declare "notification bankruptcy" and clean out all notifications. Keep pinging.", so I think there's a good chance he just missed your PR.
—
Reply to this email directly, view it on GitHub https://github.com/JuliaRegistries/General/pull/95144#issuecomment-1806535385, or unsubscribe https://github.com/notifications/unsubscribe-auth/APM7QHU3WFHPIKIV32OZBC3YD2V7BAVCNFSM6AAAAAA7GWRVSKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBWGUZTKMZYGU.
You are receiving this because you were mentioned.


JAVA-3103: Update shaded-guava/guava to 32.0.1

Depends on https://github.com/datastax/java-driver-shaded-guava/pull/11 + new version of shaded-guava being published

Move to PR from fork: #1710


Add skeleton PostgreSQL connector

resolves #1252

👍🏾

[Current coverage][cc-pull] is 74.91% (diff: 33.33%)

Merging [#1273][cc-pull] into [master][cc-base-branch] will decrease coverage by 0.04%

@@             master      #1273   diff @@
==========================================
  Files           190        191     +1
  Lines         11160      11170    +10
  Methods       10920      10929     +9
  Messages          0          0
  Branches        111        112     +1
==========================================
+ Hits           8366       8368     +2
- Misses         2794       2802     +8
  Partials          0          0

Powered by Codecov. Last update [00659cd...5ee7854][cc-compare]
[cc-base-branch]: https://codecov.io/gh/quasar-analytics/quasar/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/quasar-analytics/quasar/compare/00659cdcbe0fe5cde21963c0db3337510f75c63d...5ee7854dd6d998d472d952941c8209250d99e19c?src=pr
[cc-pull]: https://codecov.io/gh/quasar-analytics/quasar/pull/1273?src=pr


change the formatting slightly

This was mostly done to assist in displaying the DNS errors.

This should be added in #11


How can I avoid 401 error with useFetch and http basic auth, when SWR enabled

Hello, I have the newest Nuxt (v3.14.159) and nuxt-security (v2.0.0) packages .
When I call useFetch to a server route, in a page, where SWR is enabled, I get a 401 because of the http basic auth. When I manually include the headers in the request it works, but what is the Nuxt/nuxt-security intended way to do this?
Thank you and kind regards

Hey there,
The main intention behind Basic Auth in this module is to block accessing certain page/subpages but it also works for all server endpoints which does not render any route.
Have you maybe tried excluding this server route in exclude option? https://nuxt-security.vercel.app/documentation/middleware/basic-auth#exclude
There is also an issue for route based Basic Auth but it was not implemented yet.


Case Insensitive Filter

Add case case insensitive filtering

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[BEAM-2774] Remove a test case from VcfIO.

Missing fields in samples is not consistently enforced by PyVCF.
Particularly, the cparse.pyx implementation ignores additional arguments
while the python implementation in parser.py throws an error.
@jkff

Looks good, thanks!


AIORpcError connection reset errors from Qdrant

System Info
Python:3.11-slim-bullseye base docker image
Langchain version: 0.0.348
qdrant-client: 1.7.0
Qdrant database 1.7.1 (deployed on AWS cluster)
Reproduces regardless of prefer grpc true or false
Who can help?
@agola11 @hwchase17
Information

[ ] The official example notebooks/scripts
[ ] My own modified scripts

Related Components

[ ] LLMs/Chat Models
[ ] Embedding Models
[ ] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[ ] Document Loaders
[X] Vector Stores / Retrievers
[ ] Memory
[ ] Agents / Agent Executors
[ ] Tools / Toolkits
[X] Chains
[ ] Callbacks/Tracing
[X] Async

Reproduction

Use ConversationalRetrievalChain with Qdrant vectordb
Use async acall interface
Maybe wait some idle time (15 min?)

You will experience a lot of errors from Qdrant:
AioRpcError of RPC that terminated with: status = StatusCode.UNAVAILABLE details = "recvmsg:Connection reset by peer" debug_error_string = "UNKNOWN:Error received from peer {created_time}" >, type: AioRpcError
It's ok after retry of the request but this causes significant delay in response
Expected behavior
Connection recovery for the vectordb should be handled by LangChain internally and ideally understand what causes the connection issues and resolve it

@dosu-bot Response isn't handled properly as I except the connection to be recovered if needed automatically by LangChain and also inspect the source of the connection issues

cc @kacperlukawski any idea what's going on here?

Hey @orgroman. Can we get some code snippets of Qdrant's instantiation or calls that you're performing, which could help reproduce this issue?


Support for pointer_to_address instruction [ISSUE# 81]

Changes to handle pointer_to_address instruction

Resolves Issue 81.

So, I looked at the two instructions address_to_pointer and pointer_to_address and these 2 instructions are conversion instructions even though the types are internal. In the PR https://github.com/themaplelab/swift/pull/138 I made that change address_to_pointer and I think we should do that here too! Just add:
jobject ConvertedTypeNode = Wala->makeConstant(CovertedType.c_str());
jobject RawPointerCastNode = Wala->makeNode(CAstWrapper::CAST, ConvertedNode, ConvertedTypeNode);

In addition to @mmroz comments, please resolve the merge conflicts before I approving this PR.

@karimhamdanali, everything resolved. Please take a look if it's okay now.

Thanks @taufique71. @mmroz, do these changes address your concerns as well?

Looks good!


Help and brainstorm

I find the hills a bit boring. The kind of go up and come down at +/- same rate, and look like stars on lower regions count. Overall they look not so nice. How I could spice it up by not killing performance and load times?

My drawing engine is a bit limited, I can do only triangles (connect 3 verts etc). What would you advice in this situation, to draw an evaluated map (not flat veronoi)

And more islands!

I think the hills are boring. I wrote in the blog post:

This needs more work, as I’m still mildly unhappy with the results. Since this was a 1 week experiment, I decided I should work on other things, and come back to this if I had time.

I don't have any more ideas right now.

This code uses WebGL so it renders everything with triangles only. I don't like the way it looks but I don't have any ideas for improving it. I like the way mapgen4 looks, but I wasn't able to make the sphere look the same way. The rendering in mapgen4 relies on it being a 2d flat output.

There are no islands because of the way the elevations are assigned with plate tectonics. I think there are many different types of islands you may want, and each one would use different algorithms. You can probably add these by modifying the elevations after the main elevation algorithm runs. You might want to browse Here Dragons Abound, as Scott has written several nice blog posts about island creation.


Update: request to find template recursively

The method for retrieving template files has been updated.
This allows users to organize their templates in the following directory structure.
/template
├── markdown
│   ├── temp1.md
│   ├── temp2.md
│   └── temp3.md
└── lua
├── temp1.lua
├── temp2.lua
└── temp3.lua
Files are retrieved recurrently using file extensions, so they can be used in the same way as before.
Telescope's file search algorithm has been updated as well.

I don't like this structure and glopath is slow. luv is fast.

I see.
Thanks.


UI - Service Catalog Item tree not showing open/close images

We had this issue in all of the trees recently after some style changes.  I just noticed now that the Catalog nodes in the Service Catalogs and Catalog Items trees don't have the expander image:

After clicking on a Catalog Item on the right, the expander shows up, but just for the one parent Catalog:

There may be other trees with this symptom . . . I see something similar in Automate, but will open a separate issue for that.

@dclarizio I think this is not a styling issue, the expander is not present because the tree node somehow has no children during the rendering and receives a dynatree-connector class. When I click on the child on the right, the node after rendering has some children and it has also a dynatree-expander class.
https://github.com/ManageIQ/manageiq/blob/master/app/assets/javascripts/dynatree/jquery.dynatree.js#L272

@skateman you were right, it just looked similar to the previous problem.  Harpreet and I noticed it was caused by another change.


fix(service-worker): bind fetch to globalThis

This PR fixes #3176 correctly. It was not working with #3200.
I added a test but it's full of mocks and probably not much useful. Feel free to remove it 😅
Ideally an e2e test is needed.
The author should do the following, if applicable

[x] Add tests
[x] Run tests
[x] bun run format:fix && bun run lint:fix to format the code
[ ] Add TSDoc/JSDoc to document the code

Hi @sapphi-red Thank you for the PR.

I added a test but it's full of mocks and probably not much useful. Feel free to remove it 😅

I think it's good to use the mocks.

Ideally an e2e test is needed.

Exactly. If we decide to add it, we can put it into the runtime-tests. But we don't have to hurry.

I've left one comment. Please check it!

@sapphi-red
Looks good to me! Thank you for your contribution. I'll merge this and release a new version.


Update the title for the API to match repo

Update the title for the Api - it is used in the generated client code.

@gmcculloug  - as discussed


Bacteria only works with ECS; possible to use generic WB1.3 WHDL setup?

The “Bacteria” music disk fails when run from the normal WHDL setup, but works if you switch to ECS in MiSTer.
Would the general WB1.3 setup that we use for some of the disk mags be able to address this?

Nope

Re-opening since we now know that it works with killaga "whdload Bacteria.slave" will fix the issue.

Fixed


chore: add dist diff checker workflow

:pencil: Description
Verifies that the dist/ directory is maintained correctly with each new PR.

:tada: This PR is included in version 1.1.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


33 schnittstellen definieren und festhalten

Description
This PR added a Markdown doc describing the planned architecture of the vehicle agent.
Fixes #33
Time invested

Marco Riedenauer: 10h
Niklas Vogel: 10h
Simon Erlbacher: 10h
Julian Graf: 20h

Type of change

Added docs

Does this PR introduce a breaking change?
No, only added to docs
Most important changes
doc/01_general/04_architecture.md
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works (might be obsolete with CI later on)
[x] New and existing unit tests pass locally with my changes (might be obsolete with CI later on)

Oh and maybe Übersicht.jpg should be changed in overview.jpg.

Oh and maybe Übersicht.jpg should be changed in overview.jpg.

Fixed in 3f8ef00137e56173f50a933439c7fa21ba3738a6

Overall a great summary of the planned architecture. Everything is clear for me!
Only thing which has to be fixed are the linter error's, but they can probably be fixed automatically (b5 markdown:fix).
Time to review ~45 min.

Der Linter beschwert sich, dass die maximale Zeilenlänge in der Tabelle am Ende des Dokuments überschritten wird. Ich weiß allerdings nicht, wie das behoben werden kann, da in der Tabelle keine Zeilenumbrüche eingefügt werden können.

@Julian-Graf we should change the configuration there to allow longer lines in case of tables.
You can just change the rule MD013 build/docker/mdlint/.markdownlint.yaml:
MD013:
  line_length: 300
  tables: false

Sorry for the problems! All other linter errors can be fixed with b5 markdown:fix ;)

Sounds good, thanks

@Julian-Graf we should change the configuration there to allow longer lines in case of tables.
You can just change the rule MD013 build/docker/mdlint/.markdownlint.yaml:
MD013:
  line_length: 300
  tables: false

Sorry for the problems! All other linter errors can be fixed with b5 markdown:fix ;)

This PR might need minor changes to ensure interface definitions are consistent with PR #61 (Issue #46)

TODO: Sammelkomponente im Acting einfügen

TODO: in PR #61 kam auf, dass hier eine zusätzliche Verbindung für das Lanelet Modell von dem Preplanning zurück zur Predicting-Unit ergänzt werden sollte

TODO: Supify emergency

The file build/docker/mdlint/.markdownlint.yaml doesn't exist anymore. Where can I make these changes now, @timdreier?

@Julian-Graf we should change the configuration there to allow longer lines in case of tables.
You can just change the rule MD013 build/docker/mdlint/.markdownlint.yaml:
MD013:
  line_length: 300
  tables: false

Sorry for the problems! All other linter errors can be fixed with b5 markdown:fix ;)

@Julian-Graf it was moved to the root. It's located now in .markdownlint.yaml :)


Evan Aparri Period 4 | Create Performance Task Grading 2

Submission 1

Reporting Category
Student Score
Collegeboard Score
Comments

Purpose Program and Function
0
0
Student stated the function of the program not the purpose

Data Abstraction
0
0
The list was shown but it was not sufficiently exlpained on how it achieved the program's purpose

Managing Complexity
0
0
A list was shown but the stuednt did not show how it was used to manage complexity in the program

Procedural Abstraction
0
0
The student showed that the procedure had at least one parameter, which was fully described and implemented, but since it was not two parameters, he didn't get the point.

Algorithm Implementation
0
0
Sequencing, selection, and iteration are shown but the student did not describe them sufficiently

Testing
1
1
Calls, conditions, and results are fully stated and reflected in the video.

Submission 2

Reporting Category
Student Score
Collegeboard Score
Comments

Purpose Program and Function
1
1
Function and purpose clearly stated

Data Abstraction
1
1
The list's function was fully described on how it was used.

Managing Complexity
1
1
Complexity was described in great detail and was shown in the program's code

Procedural Abstraction
1
1
The procedure and functionality is shown, and it is fully described.

Algorithm Implementation
1
1
Sequencing, selection, and iteration are all shown and the steps are well detailed.

Testing
1
1
The call, conditions, and results are all stated.

Submission 3

Reporting Category
Student Score
Collegeboard Score
Comments

Purpose Program and Function
0
0
Collegeboard said the student did not meet all the criteria for the point. Specifically when the student attempted to describe the program's purpose. He merely stated the program's function in a simple way. The student met all other criteria besides the one mentioned.

Data Abstraction
0
1
The second code segment did not demonstrate the usage of the list.

Managing Complexity
1
1
The list was illustrated to handle complexity and the explanation was provided in an extensive manner.

Procedural Abstraction
1
1
The procedure and how it was used was demonstrated and a thorough explanation was provided.

Algorithm Implementation
1
1
Sequencing, selection, and iteration were all shown. The steps were extremely detailed.

Testing
1
1
All the calls, conditions, and results are shown.

Submission 4

Reporting Category
Student Score
Collegeboard Score
Comments

Purpose Program and Function
1
1
The video showed the input, how the program functions and the output it produces, making the purpose of the program clear.

Data Abstraction
1
1
The list is shown and its functionality is also shown. It is also clearly described.

Managing Complexity
1
1
List manages complexity and is fully described.

Procedural Abstraction
1
1
The code segment displays the procedure and its usage and provides a thorough explanation of its functionality.

Algorithm Implementation
1
1
Multiple while loops and if statements are utilized in the code segment. The steps of the algorithm are explained in a very thorough manner.

Testing
1
1
All calls, conditions, and results are all shown.


[rt.openssl.org #4025] Bug? DTLS server does not respond if HelloVerifyRequest message lost

Migrated from rt.openssl.org#4025 (status was 'open')
Requestors:

<EMAIL_ADDRESS>
Attachments:

test-lost-helloverifyrequest.c

From<EMAIL_ADDRESS>on 2015-08-28 20:52:49:
I originally found this in version 1.0.1e, but this also appears to be
present in the latest master branch of the git repository.

If a DTLS server has been configured to require a cookie exchange, it
appears the server never retransmits the HelloVerifyRequest message if the
client sends another ClientHello with sequence number zero and no cookie.
But, this means that if the HelloVerifyRequest message from the server is
lost (it's UDP, so anything can happen), the client will never be able to
connect.

Is this intentional behavior?  I can imagine this may be an attempt to
thwart a DoS attack, but it seems the attacker has to do as much work as
the system under attack by resending the ClientHello again.

I am attaching source code (in C) for a small (single source file) test
program to reproduce this.  The test program uses separate read and write
datagram BIOs to simulate a lost UDP datagram.  After the program sends
the initial ClientHello and fails to read the HelloVerifyRequest, the user
is prompted to press "enter."  When the user does so, the program replaces
the read BIO in the SSL object with the correct BIO and retries
SSL_connect.  In a wireshark trace, one can see that the server never
resends the HelloVerifyRequest in reply.  (Pass the server IP address and
port as command line parameters.)

I have tested this with "openssl s_server" running on localhost:

% ./apps/openssl version
OpenSSL 1.1.0-dev xx XXX xxxx

% ./apps/openssl s_server -cert keycert.pem -accept 5555 -dtls1

Then:

% test-lost-helloverifyrequest <IP_ADDRESS> 5555

- Ken

From<EMAIL_ADDRESS>on 2015-08-29 09:10:28:
> On 28 Aug 2015, at 22:52, Ken Ballou via RT<EMAIL_ADDRESS>wrote:
>
> I originally found this in version 1.0.1e, but this also appears to be
> present in the latest master branch of the git repository.
>
> If a DTLS server has been configured to require a cookie exchange, it
> appears the server never retransmits the HelloVerifyRequest message if the
> client sends another ClientHello with sequence number zero and no cookie.
> But, this means that if the HelloVerifyRequest message from the server is
> lost (it's UDP, so anything can happen), the client will never be able to
> connect.
>
> Is this intentional behavior?  I can imagine this may be an attempt to
> thwart a DoS attack, but it seems the attacker has to do as much work as
> the system under attack by resending the ClientHello again.
The server isn't retransmitting the HelloVerifyRequest message, the client
should retransmit the ClientHello. See
https://tools.ietf.org/html/rfc6347#section-3.2.1

Best regards
Michael
>
> I am attaching source code (in C) for a small (single source file) test
> program to reproduce this.  The test program uses separate read and write
> datagram BIOs to simulate a lost UDP datagram.  After the program sends
> the initial ClientHello and fails to read the HelloVerifyRequest, the user
> is prompted to press "enter."  When the user does so, the program replaces
> the read BIO in the SSL object with the correct BIO and retries
> SSL_connect.  In a wireshark trace, one can see that the server never
> resends the HelloVerifyRequest in reply.  (Pass the server IP address and
> port as command line parameters.)
>
> I have tested this with "openssl s_server" running on localhost:
>
> % ./apps/openssl version
> OpenSSL 1.1.0-dev xx XXX xxxx
>
> % ./apps/openssl s_server -cert keycert.pem -accept 5555 -dtls1
>
> Then:
>
> % test-lost-helloverifyrequest <IP_ADDRESS> 5555
>
> - Ken
> <test-lost-helloverifyrequest.c>_______________________________________________
> openssl-bugs-mod mailing list
><EMAIL_ADDRESS>> https://mta.openssl.org/mailman/listinfo/openssl-bugs-mod_______________________________________________
> openssl-dev mailing list
> To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

From<EMAIL_ADDRESS>on 2015-08-29 12:11:32:
I'm sorry if I did not explain myself well.

The message flow I observed and am trying to describe is:

ClientHello ---------------------->
                            x----------------- HelloVerifyRequest
ClientHello ---------------------->
ClientHello ---------------------->
ClientHello ---------------------->
ClientHello ---------------------->
(and the sound of crickets chirping on the server side is deafening).

I do understand that the server does not RETRANSMIT the
HelloVerifyRequest (and I do understand the reason for that).  What I am
describing is a failure to RESPOND to a retransmitted ClientHello.

                     - Ken

On 8/29/2015 5:10 AM, Michael TÃ¼xen via RT wrote:
>> On 28 Aug 2015, at 22:52, Ken Ballou via RT<EMAIL_ADDRESS>wrote:
>>
>> I originally found this in version 1.0.1e, but this also appears to be
>> present in the latest master branch of the git repository.
>>
>> If a DTLS server has been configured to require a cookie exchange, it
>> appears the server never retransmits the HelloVerifyRequest message if the
>> client sends another ClientHello with sequence number zero and no cookie.
>> But, this means that if the HelloVerifyRequest message from the server is
>> lost (it's UDP, so anything can happen), the client will never be able to
>> connect.
>>
>> Is this intentional behavior?  I can imagine this may be an attempt to
>> thwart a DoS attack, but it seems the attacker has to do as much work as
>> the system under attack by resending the ClientHello again.
> The server isn't retransmitting the HelloVerifyRequest message, the client
> should retransmit the ClientHello. See
> https://tools.ietf.org/html/rfc6347#section-3.2.1
>
> Best regards
> Michael
>> I am attaching source code (in C) for a small (single source file) test
>> program to reproduce this.  The test program uses separate read and write
>> datagram BIOs to simulate a lost UDP datagram.  After the program sends
>> the initial ClientHello and fails to read the HelloVerifyRequest, the user
>> is prompted to press "enter."  When the user does so, the program replaces
>> the read BIO in the SSL object with the correct BIO and retries
>> SSL_connect.  In a wireshark trace, one can see that the server never
>> resends the HelloVerifyRequest in reply.  (Pass the server IP address and
>> port as command line parameters.)
>>
>> I have tested this with "openssl s_server" running on localhost:
>>
>> % ./apps/openssl version
>> OpenSSL 1.1.0-dev xx XXX xxxx
>>
>> % ./apps/openssl s_server -cert keycert.pem -accept 5555 -dtls1
>>
>> Then:
>>
>> % test-lost-helloverifyrequest <IP_ADDRESS> 5555
>>
>> - Ken
>> <test-lost-helloverifyrequest.c>_______________________________________________
>> openssl-bugs-mod mailing list
>><EMAIL_ADDRESS>>> https://mta.openssl.org/mailman/listinfo/openssl-bugs-mod_______________________________________________
>> openssl-dev mailing list
>> To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev
>

From<EMAIL_ADDRESS>on 2015-08-29 12:38:04:

On 29/08/15 13:11, Ken Ballou via RT wrote:
> I'm sorry if I did not explain myself well.
>
> The message flow I observed and am trying to describe is:
>
> ClientHello ---------------------->
>                             x----------------- HelloVerifyRequest
> ClientHello ---------------------->
> ClientHello ---------------------->
> ClientHello ---------------------->
> ClientHello ---------------------->
> (and the sound of crickets chirping on the server side is deafening).
>
> I do understand that the server does not RETRANSMIT the
> HelloVerifyRequest (and I do understand the reason for that).  What I am
> describing is a failure to RESPOND to a retransmitted ClientHello.

The reasons for this are a little complicated I think.

When DTLS was first integrated into OpenSSL it was (and still is)
largely based on the TLS code. In particular the whole handshake is very
connection oriented. Each message in the handshake is given a message
sequence number (not to be confused with the record sequence number). So
typically you get:

ClientHello (no cookie, seq = 0) ---------->
                                 <---------- HelloVerifyRequest (seq 0)
ClientHello (cookie, seq = 1)    ---------->
                                 <---------- ServerHello (seq 1)
                                             etc

In this very connection oriented way of looking at things the server
receives the original ClientHello and responds with the
HelloVerifyRequest. It then increments its counter to expect message
sequence number 1 next from the client. Anything less than sequence
number 1 is ignored as a retransmit of a message that the server has
already dealt with. Normally (for other messages) a lost message isn't a
problem because the server will retransmit the messages its already sent
if it doesn't get the message its expecting from the client within a
given timeout period. In this case however the RFC expressly prohibits
the retransmission of the HelloVerifyRequest. Therefore where the
original HelloVerifyRequest gets lost the server is stuck waiting for
message sequence 1 to arrive, whilst the client is stuck waiting for the
HelloVerifyRequest to be retransmitted (which is never going to happen),
whilst retransmitting its original seq=0 ClientHello which the server is
ignoring.

This connection oriented perspective was never the way that a
HelloVerifyRequest was intended to be used. The server is supposed to
handle these in a completely stateless way, i.e. it waits for a
ClientHello (seq=0) to arrive; sends back a HelloVerifyRequest; and then
instantly forgets anything about that and waits for the next ClientHello
(seq=0) to arrive. Only when it sees a ClientHello (seq=1) with a valid
cookie does the server form a connection and the handshake proceeds as
normal.

To deal with this stateless way of handling the
ClientHello/HelloVerifyRequest a new function was introduced (way back
in OpenSSL 0.9.8) called DTLSv1_listen. In the original connection
oriented way of doing things a server would just call SSL_accept (or
some other function that ultimately calls that) and waits for the
handshake to complete. In this stateless way of operating a server
application is supposed to call DTLSv1_listen until a ClientHello with a
valid cookie is received, and only *then* is it supposed to call SSL_accept.

The bug here I think is that when DTLS support was originally added to
s_server the DTLSv1_listen function had not been created yet. When
DTLSv1_listen was later added, s_server was never updated.

So, in summary, I believe this to be an s_server bug, not a libssl bug.
We should update s_server to use DTLSv1_listen (and coincidentally I
have a patch for the master branch knocking around somewhere to do just
that...I'll dig it out).

Matt

1.1.0 now has a "-listen" option for s_server. Closing.


graphql?

https://github.com/intuit/graphql-xtext/blob/master/com.intuit.graphql.parent/com.intuit.graphql/src/com/intuit/graphql/GraphQL.xtext

one can achieve the same with text breaks. with current usage, its better not to make it complex.
POST 'https://api.spacex.land/graphql'
json({
    "query":
        """{
          company {
            ceo
            coo
            cto_propulsion
            cto
            """
            // "employees"
            """
            founded
            founder
            launch_sites
            name
            summary
            test_sites
            valuation
            vehicles
          }
        }
  """,
  "variables":null}
)```


chore: bdd-gh-1581635034 to 0.0.1

chore: Promote bdd-gh-1581635034 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


[1.9] Warning beep on alt+w pane swap.

Steps to Reproduce

Open files on two panes. Vertical panes in this case.
Attempt to press alt+w to swap panes.

I have a warning noise beep every time I press alt+w which is deemed as very annoying that would stop me from using it.
Expected behavior: No sound effect per pressing alt+w to swap pane.
Actual behavior: Warning sound beeps per pressing alt+w to swap pane.
Versions
Brackets 1.9
build 1.9.0-17312 (release 189f6d39a)
build timestamp: Tue Mar 21 2017 10:29:45 GMT+0000
Windows 8 64-bit

Not sure why this is happening, might be because Windows by default maps alt+letter shortcuts to the menu bar, so if you type alt+f, it opens the file menu etc. You could try overriding the pane swap shortcut to a different one in keymap.json which can be opened using Debug > Open User Key Map:
{
    "documentation": "https://github.com/adobe/brackets/wiki/User-Key-Bindings",
    "overrides": {
        "<desired key>" : "cmd.switchPaneFocus"
    }
}

@haslam22 Is alt+w the only default keymap for pane swap?

@dmxt It appears so, the feature was added pretty recently in #12853


Using lambda_hook_sdk  in lambda (lambda hook)

Trying to use hook.set_message(event, message) under lambda_hook_sdk, but it only changes the messages under event.res.result, not the event.res.message. Therefore, the changes I applied to the message using hook.set_message don't reflect on the bot.
Reference:
https://github.com/aws-solutions/qnabot-on-aws/blob/main/docs/lambda_hooks/lambda_hook_sdk.MD
Scenario:
First, I used hook.get_message(event) to retrieve the message:
{
"plainText": "Thank you, dan! 😄",
"markDown": "Thank you, dan! 😄"
}
Then, I used hook.set_message(event, message) where my message is:
{
"plainText": "Thank you, Dan! 😄",
"markDown": "Thank you, Dan! 😄"
}
However, when I tried chatting with the bot, it still responded with "Thank you, dan! 😄"

Hi @dangollayan
Thanks for reporting this. We'll look into this and get back to you

Hey @dangollayan, can I ask how you set up your lambda hook function? You are right in that set_message changes event.res.result and not event.res.message. In order to return back event.res.result, you must override event.res.message at the end of you lambda function by putting (as an example):
event.res.message = event.res.result.a
or you can also use the get_message()
event.res.message = hooks.get_message(event).plainText

thanks @michaelin-96, that's what I actually did, I manually changed the value from event.res.message. I just thought that if you use the set_message, it will be the actual output message.

I agree, that confused me at first as well. I did look into the unit tests and other example lambda hook code, and I believe that is the intended use for set_message().
The documentation for lambda hook sdk could use a bit of update/clarification and I plan to update it in future releases! Thanks!

Thank you @michaelin-96 !!!


Add / New error message added for user rejected transaction on wallet

Trello card: https://trello.com/c/jw4bXigZ/452-bring-error-improvement-to-nft-hooks
Closes #98
After this merge, could change O-mee and remove extra function which has been implemented on https://github.com/liteflow-labs/o-mee/pull/435#discussion_r1051770697

I'm not sure this makes sense the formatting of the error is just to format the error not transform and change the behavior of the error.

I'm not sure to follow, the function already transform an Error object to a string.

Right now if an application wants to get the original message, they can't.

That's basically what the function is already doing. The recursive call to extract the deepest error's message already loose the original error which is the top one.

The big question I have with formatError is: does it make sense to have it in the hooks package?
The current use of this function is to create an error message that can be display to the user. This is UI stuff and should be in starter-kit.

Agree. That kind of goes in the same direction where this should be as close to the UI as possible.
Also, I believe most of the utils are not actually used in the hook, so could/should be moved and then in that case, this seems unnecessary, and the current way to have that in the app is the proper way like it's done already in the related issue

I'm good to merge this PR and quickly move this and other helper functions directly in the starter-kit.


Fall back to CPU for non-UTC months_between

This fixes #11798
But really it works around it and I filed https://github.com/NVIDIA/spark-rapids/issues/11800 to put in a proper fix eventually.

build


What is the Overall Compute Footprint of the Pipeline?

Hi @yl4579!
Many thanks for your repo and the paper.
In the paper I have found the following statements:

We train our model for 150 epochs, with a batch size of 10 two- second long audio segments.

Using Parallel WaveGAN vocoder, our model can convert an audio clip hundreds of times faster than real time on Tesla P100, which makes it suitable for real- time voice conversion applications.

I understand that GAN training is tricky and that mileage may vary depending on the machine used, but in our practice we mostly measure compute required in GPU-days based on some popular GPUs, namely 1080 Ti / 3090 / V100 / A100 etc.
This of course very crude and assumes that code is "perfect" and GPU is not "waiting" and that there are no other delays (i.e. validation, start-up time, etc), that CPU resources are adequate and that there are no IO blocks.
But I have not found anywhere in the paper and the issues, what was the approximate compute footprint of this pipeline for:

The whole VC part with  a GAN, discriminators, etc;
F0 network;

As for STT I know from practice how long they train.
Thank you in advance!

Sorry for the late reply. I was pretty busy at the end of my semester. I will make the F0 training code available by the end of this month. As for StarGANv2-VC training, it took approximately 2 days to train on a Tesla P100 for 150 epochs with a batch size of 5. You may increase the batch size to make the training faster.

Many thanks for the info!


chore(native_blockifier): remove unnecessary checks

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.22%. Comparing base (a34e203) to head (47d6b19).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1964      +/-   ##
==========================================
+ Coverage   78.18%   78.22%   +0.04%
==========================================
  Files          62       62
  Lines        8820     8809      -11
  Branches     8820     8809      -11
==========================================
- Hits         6896     6891       -5
+ Misses       1486     1480       -6
  Partials      438      438

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add Linux Mint 17.x and 13 support to install.sh

Works on my machine:
DISTRIB_ID=LinuxMint
DISTRIB_RELEASE=17.2
DISTRIB_CODENAME=rafaela
DISTRIB_DESCRIPTION="Linux Mint 17.2 Rafaela"

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "patch-1" git@github.com:edsfocci/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Hi @edsfocci,
Thanks for teh contribution but there is already some work for the support : here #15001 :wink:

Thanks @edsfocci, I think there's another PR currently that is intended to solve this in a more generic way; https://github.com/docker/docker/pull/15001
Could you give  https://github.com/docker/docker/pull/15001 a test, and check if that works for you?

(Sorry for the duplicate commenting, our comments just crossed.. LOL

Signed-off-by: Ed Solis<EMAIL_ADDRESS>

I already installed; any uninstall script?

Good one, I think apt-get purge docker-engine would do the removal, but won't remove the apt repo. Perhaps the blog post can give you some pointers there http://blog.docker.com/2015/07/new-apt-and-yum-repos/

Eh, it's alright I guess; if the other commit is more accepted (https://github.com/docker/docker/pull/15001), I'll let him have it.
I haven't specifically tested the file on my computer, but I've tested the lsb_release commands and the outputs seem to look good for my machine ("ubuntu" and "trusty" for upstream release). Also, according to their checklist, Linux Mint looks like it's tested as working (https://github.com/docker/docker/pull/15001#issuecomment-125721830).

Thanks @edsfocci, and thanks so much for contributing, even if it didn't get merged, it's really appreciated :+1:


Change in the last paragraph in load balancing types

Application Gateway can reach private endpoint using its instance IP and public endpoints using its frontend public IP. If there's no frontend public IP provisioned, we will assign one by default.
Also a slight change in DNS name resolvable in the first paragraph of same section.

@surajmb : Thanks for your contribution! The author, @abshamsft, has been notified to review your proposed change.

#sign-off


Migrate CI to GHA

Migrate CI to GHA

This is passing in my fork: https://github.com/kokosing/trino-maven-plugin/actions/runs/4054466677/jobs/6976331969

Tested with https://github.com/kokosing/trino-maven-plugin/pull/1


mark windows and macos chrome dev mode as flaky

Description
We need to roll through a type fix to the webkit inspection protocol package - this is used by both the flutter_tool and webdev package to connect to chrome.
https://github.com/google/webkit_inspection_protocol.dart/blob/fc34408804f02199bc01acc5762a450a1d44c758/lib/webkit_inspection_protocol.dart#L46

Landing on red to fix build


Basic MIPS ELF support

I'm not sure if you're looking for feedback on this, or how you're approaching this, but I think the ideal way to do initial support for this is to generate a .o file using llvm, and then implement whatever is needed so that the objcopy example in this crate can preserve all the information in the .o file.

With stubbed-out relocation parsing, objcopy now works properly. The objdump output also makes sense. Let me know if you want me to properly implement relocations, but the current state should be enough for what I need.


Support for JapaneseDate

I've added a type handler for the JapaneseDate.
Please review this.

Thank you, @kazuki43zoo !
Just curious, are you going to use this type handler in your solutions?

Thanks for merging !!

Just curious, are you going to use this type handler in your solutions?

I never use yet. However, Wareki is used on government system(http://www.kantei.go.jp/) etc... in Japan.

I see. It might be useful in a solution using Wareki for both input and output.
Thank you for a reply! 😄


Different Order book  behavior of swaps and futures

Theoretically swaps of tick size 0.1 compared to futures 0.01, thus swaps of ask1 volume = sum of ask 1- 10 of futures.
In reality, swaps have much thicker ask1 and bid1 volume compared against sum of ask1-10 and bid1-10 of futures.
Why this fundamentally different behavior between swaps and futures?
Best regards,
Ingyu

This thickening of ask1 and bid1 in swaps compared to those of futures is also shared in Eth  Quarterly and Swap.

Eth and BCH order books are more evenly spaced compared BTC's excessive concentrations on ask1 and bid1.   Order books of equity and S&P, Nasdaq and Dow Jones futures show evenly spaced ask and bid.  One way to understand this peculiarity of BTC is to accept and to profit from this concentrations on ask1 and bid1.  Still intuitive reasoning why focus on ask1 and bid1 in BTC can be extremely useful.

Hi @igkoh The tick with 0.01 in swap compared to 0.001 in futures can provide better liquidity. The liquidity is better now.

We will feedback this advice and discuss it later.


Error at dragging img on icon

If IS is not started they following error occurs at dragging images on the icon:

Fixed in 7a57205383d00266662bc3e3e6d39de43f120479


Please make a release

Go expects a released version for go mod to produce reliable builds. It would be sufficient to make a tag with a name v0.0.1.

Done, see https://github.com/cncf/udpa/releases/tag/v0.0.1.

Can you add a tag go/v0.0.1 per https://golang.org/ref/mod#vcs-version? Don't ask me why go is so weird.


Upgrade to terminal_size v0.2

That version uses different dependencies to libc and winapi. So, doing this now without changing our own dependencies just adds more dependencies to compile time for not much benefit.

Will you accept a revision that does the version upgrade of terminal_size
and also ports console over to rustix and windows-sys? If so please reopen.
On Mon, Sep 19, 2022 at 4:29 AM Pavan Kumar Sunkara <
@.***> wrote:

That version uses different dependencies to libc and winapi. So, doing
this now without changing our own dependencies just adds more dependencies
to compile time for not much benefit.
—
Reply to this email directly, view it on GitHub
https://github.com/console-rs/console/pull/133#issuecomment-1250720052,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGXSIBQ2YQG3R3AHKW4AMLV7AP6FANCNFSM6AAAAAAQPX6S7I
.
You are receiving this because you authored the thread.Message ID:
@.***>

Thanks! I'll take a look at this when I can.

Ah, never mind. I'm afraid I just won't have the time.


[BUG]Registration is Set to Not Require a Password, but Actually Prompts "Password Must Be at Least 6 Characters

Description:
When using Casdoor for user registration, we have set up the backend to not require a password during the registration process. However, after the user enters their phone number and verification code, the system still prompts that "Password must be at least 6 characters." This results in an inconsistency between the settings and actual behavior.
Steps to Reproduce:

Open the Casdoor registration page.
Enter a valid phone number and verification code.
Attempt to register.

Expected Behavior:
When the backend is set to not require a password, users should be able to register successfully without receiving a password-related error prompt.
Actual Behavior:
Despite the backend being set to not require a password, users still receive an error prompt stating "Password must be at least 6 characters" during registration.
Screenshots:

@leo220yuyaodog

Thank you so much for resolving the bug so efficiently. It's now working.


Fixes login path to support configured base path

fixes #46

I don't know what's wrong with the build. Tests run fine on my machine. Can you help @tchiotludo ?

My Travis build is wrong on pull request, my fault.
Good fix I think, I will look if I missed other one and fix Travis
Thanks 😉

Thanks @tchiotludo, do you mind creating a new release?

In the dev release they is also new bugfix like this one : #42 that was blocked by a micronaut issue micronaut-projects/micronaut-core#1532 that was just fix 1 hour ago.
I will look this evening if I could use a snapshot release to have this fix included before the release of the new version (I think they have a 3 weeks sprints)

Release done without the fix, the snapshot release is not an option but it's better than now !
Thanks

Thanks a bunch!


com.pingcap,tikv.key : bug fix reslove bug of cannot encode row key with non-long type ref: #2290

Signed-off-by: qidi1<EMAIL_ADDRESS>What problem does this PR solve?
Issue Link

https://github.com/pingcap/tispark/issues/2290
when create table with BITINT UNSIGNED primary key,and run a sql which has range in primary key.A exception will happend.

What is changed and how it works?
We have a special treatment for BIGINT UNSIGNED. The BIGINT UNSIGNED is cut into two ranges to discuss, one range is [0,MaxInt64] and one is [MaxInt64+1,MaxUint64].
Check List
Tests

Unit test

Code changes

Has exported function/method change

Side effects
Related changes

Detailed Design
We have a special treatment for BIGINT UNSIGNED. The BIGINT UNSIGNED is cut into two ranges to discuss, one range is [0,MaxInt64] and one is [MaxInt64+1,MaxUint64].
The detail design is divided into two main parts:

Separate treatment of [0,MaxInt64]and [MaxInt64+1,MaxUnit64].
Special treatment for  do not having upper bound or lower bound.

Separate treatment of [0,MaxInt64]and [MaxInt64+1,MaxUnit64]

StartKey

When  StartKey small than MaxInt64
startKeys[0]=RowKey.toRowKey(id,new IntHandle(bigDecimal.longValue()));
startKeys[1]=RowKey.toRowKey(id,new IntHandle(max.longValue()+1));
if (r.lowerBoundType().equals(BoundType.OPEN)) {
     startKeys[0] = startKeys[0].next();
}

	StartKeys[0] is request StartKey,StartKey[1] is MaxInt64+1.

When StartKey bigger than MaxInt64
startKeys[0]=RowKey.toRowKey(id,new IntHandle(max.longValue()));
startKeys[1]=RowKey.toRowKey(id,new IntHandle(bigDecimal.longValue()));
startKeys[0]=startKeys[0].next();
if (r.lowerBoundType().equals(BoundType.OPEN)) {
       startKeys[1] = startKeys[1].next();
}

	StartKey[0] will be bigger than MaxInt64,StartKeys[1] is request StartKey.

EndKey

When  EndKey small than MaxInt64
endKeys[0]=RowKey.toRowKey(id,new IntHandle(bigDecimal.longValue()));
endKeys[1]=RowKey.toRowKey(id,new IntHandle(max.longValue()+1));
if (r.upperBoundType().equals(BoundType.CLOSED)) {
    endKeys[0] = endKeys[0].next();
}

	EndKeys[0] is request EndKey,EndKeys[1] is MaxInt64+1.Since EndKey is open interval,the MaxInt64 will not appears in our request.

When EndKey bigger than MaxInt64
startKeys[0]=RowKey.toRowKey(id,new IntHandle(max.longValue()));
startKeys[1]=RowKey.toRowKey(id,new IntHandle(bigDecimal.longValue()));
startKeys[0]=startKeys[0].next();
if (r.lowerBoundType().equals(BoundType.OPEN)) {
       startKeys[1] = startKeys[1].next();
}

		EndKeys[1] is request EndKey,EndKeys[0] is bigger than MaxInt64+1,

Special treatment for  do not having upper bound or lower bound
when we do not having upper bound or lower bound,we have to add some special treatment of it.

no upper bound and no lower bound:
do same as before.

having lower bound but no upper bound:

not BigDecimal:
do same as before

BigDecimal:
endKeys[0]=RowKey.toRowKey(id,new IntHandle(Long.MAX_VALUE));
endKeys[1]=RowKey.createBeyondMax(id);
// since range is left-closed and right-open interval,
// we have to use next to inclusive Long.MAX_VALUE.
endKeys[0]=endKeys[0].next();

no lower bound but upper bound:

not BigDecimal:
do same as before.

BigDecimal:
The StartKeys[0] should be -INF,StartKeys[1] should be MaxInt64+1.
I feel hard to know the type of data before come to upper bound,so adding StartKeys[1] has been put off until processing upper bound.
if(bigDecimal.compareTo(max)>0){
     endKeys[0]=RowKey.toRowKey(id,new IntHandle(max.longValue()));
     endKeys[1]=RowKey.toRowKey(id,new IntHandle(bigDecimal.longValue()));
     endKeys[0]=endKeys[0].next();
      if (r.upperBoundType().equals(BoundType.CLOSED)) {
           endKeys[1] = endKeys[1].next();
      }
}else{
      endKeys[0]=RowKey.toRowKey(id,new IntHandle(bigDecimal.longValue()));
      endKeys[1]=RowKey.toRowKey(id,new IntHandle(max.longValue()+1));
       if (r.upperBoundType().equals(BoundType.CLOSED)) {
              endKeys[0] = endKeys[0].next();
        }
 startKeys[1]=RowKey.toRowKey(id,new IntHandle(max.longValue()+1));

Check this https://github.com/pingcap/tispark/pull/2291#issuecomment-1108390798, you should also fix this bug

@shiyuhang0  PTAL

@qidi1 check the CI, it seems like some tests failed

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/merge


ModuleNotFoundError: No module named 'setuptools.command.build'

Hi there! I faced this strange error in my CI: https://app.travis-ci.com/github/LostInDarkMath/pedantic-python-decorators/jobs/586586853
It fails only with Python 3.9 and 3.10. 3.7 and 3.8 are working fine:
https://github.com/LostInDarkMath/pedantic-python-decorators/pull/71/checks?check_run_id=9091764326
Do you have an idea what's wrong here? Thanks in advance!

Should be solved with the upcoming version, as setuptools is no longer an explicit dependency.


Add a mesh simplifier

SimplifyModifier should do the trick: https://stackoverflow.com/a/41571483/1544937
Demo: https://threejs.org/examples/#webgl_modifier_simplifier
Code: https://github.com/mrdoob/three.js/blob/dev/examples/webgl_modifier_simplifier.html

Partly done as of this commit: f033b6b45763b1dc37307fbaf58f209fe16719a5
The lib is now available but mesh methods should also be added.