Flash messages not showing after logging out a user.

With a clean install of advanced app.  Open frontend (and backend) siteController.
Add
Yii::$app->session->setFlash('success', 'You have been successfully logged out!');
to line 107 of frontend/siteController
and Add
Yii::$app->session->setFlash('success', 'You have been successfully logged in!');
to line 91 before the return $this->goBack(); call.
Login and see the successfully logged in message.
Logout and notice there is no successfully logged out message.
Happens the same in the backend as well.
I have a working version I downloaded / updated at:-
"time": "2015-09-24 23:06:03".
(working) meaning I get my flash messages displayed as expected.
Just for some reason my new apps don't display them.
I can see from the logs that the flash messages are being set in the POST logout.
Just not being displayed in the GET index page.
I tried using $this->redirect(['site/login']); as well with the same results.

Sessio is destroyed after calling logout method tahts why you dont see any flash messages after redirect
You can call Yii::$app->user->logout(false); if you dont want to session will be destroyed
But i am unsure is it rght way or not

I thought that as soon as you call:-
Yii::$app->session->setFlash(...
It automatically creates a new session?
So logout kills the 'user' session, but setting flash message immediately afterwards will create a new session for basic application functionality.
If I use Yii::$app->user->logout(false);. Does it still retain private information about the user (like username, email etc.)?  Or just their publically available info (like ip, browser etc.)?

This code works correct for me
    public function actionLogout()
    {
        Yii::$app->user->logout();
        Yii::$app->session->setFlash('success', 'Success');

        $this->redirect(Yii::$app->getUser()->loginUrl);
    }

But if i call setFlash before logout it doesnt work

If it doesnt work for you please write which version of yii do you use and show us full version of your action

Your example is exactly the same I've implemented.  Because it wasn't working, I tested it out with a clean install of the advanced app.
I did exactly as you described above (which falls on line 107 of frontend/siteController when clean install).
example:-
/**
 * Logs out the current user.
 *
 * @return mixed
 */
public function actionLogout()
{
    Yii::$app->user->logout();

    Yii::$app->session->setFlash('success', 'You have been successfully logged out!');
    return $this->redirect(['site/login']);
    // return $this->goHome();
}

This fails to render the flash message.  Though the following does render the flash message:-
/**
 * Logs in a user.
 *
 * @return mixed
 */
public function actionLogin()
{
    if (!\Yii::$app->user->isGuest) {
        return $this->goHome();
    }

    $model = new LoginForm();
    if ($model->load(Yii::$app->request->post()) && $model->login()) {
        Yii::$app->session->setFlash('success', 'You have been successfully logged in!');
        return $this->redirect(['site/index']);
        // return $this->goBack();
    } else {
        return $this->render('login', [
            'model' => $model,
        ]);
    }
}

Again, this is a clean install of yii2 advanced app.  Nothing else has been applied except for the addition of the 2 setFlash messages.

Can someone else confirm this is the case with a fresh install of the advanced app please?  If it doesn't behave for you as I've described, I'll continue looking into my environment (which is windows 7 running wempserver 'nginx').
Thanx again for any confirmations / rebuttles.

Verified.
Updated my app that worked using composer update (had to change "bower-asset-library": "vendor/bower" to "bower-asset-library": "vendor/bower-asset") and the flash message now doesn't get displayed when a user logs out.

So it worked on Yii 2.0.6 and broke in current dev version of 2.0.7?

Correct

Is that when the bower asset directory name changed?

Sorry @SilverFire.
The previous version could be earlier than 2.0.6...*unsure.

Is that when the bower asset directory name changed? (2.0.6 - 2.0.7)

that name should not have changed, if it did it was not caused by yii, but maybe by a composer update that broke it.

Just today I got the 60 day warning about Composer needing an update.  I applied that update 'before' updating the working application.

Issue confirmed.
Session is lost in case it has been destroyed and then reopened.
This happens because after being reopened session rerturns new session cookie value to the browser, while session_id() value remains to be the same. Check following 'logout' code:
public function actionLogout()
    {
        var_dump($_COOKIE); // session coookie value = sess_id#1

        var_dump(Yii::$app->getSession()->getId()); // outputs: sess_id#1

        Yii::$app->user->logout();

        Yii::$app->session->setFlash('success', 'You have been successfully logged out!');
        Yii::$app->session->set('logout', __METHOD__ . ' at ' . date('Y-m-d H:i:s'));

        var_dump(Yii::$app->getSession()->getId()); // outputs: sess_id#1 !!!

        exit;
    }

While network console indicates response from 'POST logout' containing 'Set-Cookie: PHPSESSID=sess_id#2' !!!
I am unsure why this happens.

The walk-around could be the regenerating session ID before return logout response:
public function actionLogout()
    {
        Yii::$app->user->logout();

        Yii::$app->session->setFlash('success', 'You have been successfully logged out!');
        Yii::$app->session->set('logout', __METHOD__ . ' at ' . date('Y-m-d H:i:s'));

        Yii::$app->session->regenerateID(); // Enforce new session ID usage

        return $this->goHome();
    }

In this case 2 'Set-Cookie' headers are passed to response and session_id() value updated.

http://php.net/manual/ru/function.session-regenerate-id.php#107323

It seems that new session ID cookie is sent once session_destory() is invoked.
The possible fix can be setting session ID to null manually at Session::destroy():
public function destroy()
    {
        if ($this->getIsActive()) {
            @session_unset();
            @session_destroy();
            @session_id(null); // unset cached session ID
        }
    }

This works for me, but I am unsure if this is a correct way.

Since we have not better ideas, I think we can do as @klimov-paul suggested


converted if() throw convention to require()/assert()/revert()

Converted if()/throw to require() or assert() and plain throw to revert().
Precondition checks use require() and inline action failures are checked with assert()
Passes tests using npm test with internal testrpc
NOTE: Apologies for the whitespace foo introduced by my Atom editor.  If that's a pain I can try to clean it up.

Can we please merge this?

Thanks @yarrumretep!


CSV import & export

Could we get a possibility to import and export CSV files?
The advantages of CSV files are that it is easier to show the difference in a version control system and that you can edit CSV with a lot of applications like Excel, Numbers, Open Office and more.

Import/Export via GUI or just via script?

Via GUI, I'd say where currently the Excel export/import is

can you try the latest build from http://vsixgallery.com/extension/43b35fe0-1f30-48de-887a-68256474202a/ ?

I just made a simple code review. Not sure how to test it with Visual Studio

Just switch Export Mode to Text on the configuration tab


🚨 Critical Security Vulnerability: Potential Remote Code Execution (RCE) via compileToFunction 🚨

Vue version
latest
Link to minimal reproduction
latest
Steps to reproduce
🚨 Critical Security Vulnerability: Potential Remote Code Execution (RCE) via compileToFunction 🚨
Description
The current implementation of the compileToFunction method in the runtime compiler poses a severe security risk due to the use of new Function for dynamically executing JavaScript code. This vulnerability enables remote code execution (RCE) if untrusted templates are provided, either directly or through DOM elements.
Affected Code
The issue stems from the following segment in compileToFunction:
const { code } = compile(template, opts);

const render = (
  __GLOBAL__ ? new Function(code)() : new Function('Vue', code)(runtimeDom)
) as RenderFunction;

This uses new Function to execute the generated code. If an attacker controls the template input or manipulates the DOM to include malicious content, they can inject and execute arbitrary JavaScript code in the application's context.
How the Vulnerability Occurs

Template Compilation from Untrusted DOM:
When a template string starts with #, it pulls content directly from the DOM:
if (template[0] === '#') {
    const el = document.querySelector(template);
    template = el ? el.innerHTML : ``;
}

An attacker could inject malicious scripts into a DOM element that gets compiled and executed by new Function.

Untrusted Template Strings:
If an unvalidated or user-controlled template string is passed to compileToFunction, it could inject arbitrary JavaScript into the compiled code.

Exploitation Examples
Example 1: Malicious DOM Injection
If an attacker gains control over the DOM (e.g., via an XSS vulnerability), they could inject a malicious script into the template:
<div id="malicious-template">
    {{ constructor.constructor('alert("Hacked!")')() }}
</div>

Using:
compileToFunction('#malicious-template');

The innerHTML is directly compiled and executed, triggering the alert.
Example 2: Injected Template String
If the application accepts user-controlled template strings:
const userTemplate = '{{ constructor.constructor("alert(\'Hacked!\')")() }}';
compileToFunction(userTemplate);

This will compile and execute the injected JavaScript.
Why This Is Severe

Critical Impact: Successful exploitation allows attackers to execute arbitrary JavaScript, potentially compromising user data, stealing session tokens, or even pivoting to server-side attacks via exposed APIs.
High Likelihood: The vulnerable behavior occurs with both DOM-based templates (el.innerHTML) and directly provided templates, making the attack surface large.

Recommended Fix
To mitigate this issue:

Avoid new Function: Instead, use a safer approach to execute templates, such as using a WebAssembly-based sandbox or static template pre-compilation during the build process.
Validate and Sanitize Templates: Strictly enforce validation and sanitization of any templates or DOM content before compiling them.
Warn Users: Clearly document that untrusted templates or DOM content must never be passed to the runtime compiler.

Proposed Code Fix
A simple guard to prevent untrusted template execution:
if (!isTrustedSource(template)) {
    throw new Error("Untrusted template detected!");
}

Or enforce pre-compilation at build time:
if (__DEV__) {
    throw new Error("Templates must be pre-compiled in production builds.");
}

Immediate Actions

Investigate and implement a fix to eliminate new Function.
Release a security advisory warning developers about the critical impact of passing untrusted templates.
Backport fixes to all affected versions.

Versions Affected
All versions of Vue using runtime template compilation (@vue/compiler-dom).
Urgency
Critical. Immediate action required. Exploiting this vulnerability enables full control of the application environment.

Please let me know if further details or assistance are required to resolve this issue.
What is expected?
.
What is actually happening?
.
System Info
System:
    OS: Linux 6.1 Debian GNU/Linux 12 (bookworm) 12 (bookworm)
    CPU: (8) x64 Intel(R) Xeon(R) CPU E3-1505M v5 @ 2.80GHz
    Memory: 3.46 GB / 7.65 GB
    Container: Yes
    Shell: 5.9 - /usr/bin/zsh
  Binaries:
    Node: 22.12.0 - /usr/bin/node
    Yarn: 1.22.22 - /usr/bin/yarn
    npm: 10.9.2 - /usr/bin/npm
    pnpm: 9.15.0 - /usr/bin/pnpm

Any additional comments?
No response

This is not a valid attack vector because you need to invoke the function with arbitrary user-provided template, which is the No.1 thing we warn users against in our security guide: https://vuejs.org/guide/best-practices/security.html#rule-no-1-never-use-non-trusted-templates


Add OCI Data Science Model Deployment Embedding Integration

Description
Oracle Cloud Infrastructure (OCI) Data Science is a fully managed, serverless platform for data science teams to build, train, and manage machine learning models in Oracle Cloud Infrastructure.  his PR introduces a new embedding integration with Oracle Cloud Infrastructure (OCI) Data Science Model Deployment endpoints. The integration allows generating text embeddings asynchronously or synchronously, leveraging the OCI Signer for authentication.
llama_index_test_base.pdf
New Package?
Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

[X] Yes
[ ] No

Version Bump?
Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

[X] Yes
[ ] No

Type of Change
Please delete options that are not relevant.

[X] New feature (non-breaking change which adds functionality)
[X] This change requires a documentation update

How Has This Been Tested?

[X] I performed thorough manual testing
[X] I added new unit tests to cover this change
[ ] I believe this change is already covered by existing unit tests

Suggested Checklist:

[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] I have added Google Colab support for the newly added notebooks.
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[X] I ran make format; make lint to appease the lint gods

Hi @logan-markewich,
I wanted to kindly ask for your help with the review of this PR. The changes introduce integration for invoking Embedding models on OCI Data Science, and I’d greatly appreciate your feedback and insights.
Additionally, I’ve encountered an issue with failing tests during the CI pipeline due to the absence of the oracle-ads library, despite it being listed in the pyproject.toml file. All the tests pass locally without any problems. It seems the oracle-ads library is not being installed in the CI environment before running the tests. It looks like that poetry doesn't take into account the pyproject.toml dependencies.
When you have time, could you please take a look at this and share your thoughts on what might be causing this discrepancy? Your guidance would be incredibly helpful.
Thank you in advance for your time and support!

@mrDzurb seems like pants doesn't want to install this. I think our CICD is missing some system level dependency. Might take some time to figure out whats going on

Hi @logan-markewich, thanks for taking a look on this.
It seems that adding the following rule to the BUILD file resolved the test failures for Python 3.9:
poetry_requirements(
    name="poetry",
    module_mapping={"oracle-ads": ["ads"]},
)

However, the tests for Python 3.10, 3.11, and 3.12 are still failing, but for a different reason. Maybe just restarting the tests will help. The logs don't give any clues what is failing.

pants is hiding the true error it seems -- probably some system level issue, or an issue with some tricky dependency that needs a particular c compiler or something. Maybe I'll just disable tests for all but python 3.9

I've temporarily removed the oracle-ads dependency. If the user doesn't have this library installed, they will receive a comprehensive error message with guidance on the necessary steps to resolve the issue. Hopefully this will help to pass the tests. Meanwhile i will try to reproduce the problem on my local environment to see which libraries cause the conflict.


Initial registered server using environment variables.

Update the start and template scripts to allow an environment variable with an initial registered server.

If you run the template version several time, it will continuously post the same client/ehr pair to the database every time, and you wind up with several versions of the same client.
This is more of an oversight with how that part of the code is written.
This should check for duplicates before posting, and if there is one, PUT instead. But PUT requests aren't currently serviced in the backend, so that needs to get implemented at some point.
Either that, or the POST endpoint needs to do that for us on the backend and ensures no duplicates.

Yes, I did see that this could be a problem but decided to ignore it for now since the template would be used on docker and will reload from scratch each time assuming that the db.json was not included in the docker container to begin with. I will take a look again at fixing this though.


What about having OrangeClock on Orange Pi instead of Raspberry Pi?

Isn't mine a legit question? :D

Sorry for the late reply.I did not know the OrangePI ecosystem until now.

I will close this issue because I could not find a version like the pico from orange pi

I will close this issue because I could not find a version like the pico from orange pi

I will close this issue because I could not find a version like the pico from orange pi


Incorrect config file updated using the updateConfig function when cwd is missing a trailing slash

Environment
Node: v20.8.1
c12: 2.0.0-beta.1
Reproduction
This issue was identified in the nuxt repo: https://github.com/nuxt/nuxt/pull/28797
Link to reproduce the issue: https://stackblitz.com/edit/stackblitz-starters-ea59nb?file=README.md
Describe the bug
Without a trailing slash at the end of cwd, the updateConfig ends up modifying the wrong file.
Additional context
No response
Logs
No response

Thanks for nice report. fixed in latest 1.x (and v2 beta)

5b0c89ca1d16a8ee5b043d905135a9e81bc5c842


Tables dis-oriented while running kubescape in windows environment (powershell/cmd)

Describe the bug
Tables dis-oriented while running kubescape in Windows environment (powershell/cmd)
Environment
OS: Windows 11 Pro
Version: v2.0.173
Steps To Reproduce
Steps to reproduce the behavior:

Install Kubescape on Windows environment
open Powershell OR CMD shell
Run any kubescape command

Expected behavior
See output data clear without "special" characters
Actual Behavior
output lines are dis-oriented and powershell/cmd replace shell colors with un-cleared characters
e.g.
←[1;36m[info] ←[0m←[mKubescape scanner starting
←[0m←[1;36m[info] ←[0m←[mInstalling host scanner
←[1;36m[info] ←[0m←[mDownloading/Loading policy definitions
←[1;91m[fatal] ←[0m←[mframework 'CIS' not found
←[0m

Additional context
Occurred in Windows operation system only.
Working workaround --> add parameter '--disable-color' for each kubescape running command

Hi,
This is happening because your Windows power shell does not support the Kubescaoe colored output.
You can overcome this by running Kubescape with the --disable-color flag.


feature/se-11-testing

Test:

[x] user cannot upload file bigger than maximum upload size - it should be 4GB
[x] admin see input field:

[ ] user don't see that input field
[x] upload the file bigger than maximum upload size - wiki: https://github.com/dataquest-dev/DSpace/wiki/Submission-extensions

I am missing info about max size of uploading
It's not intuitive to resolve this issue by using Bitstream redirect URL
How do I upload bigger file? Hint and wiki were not helpful for me - where I should upload file?
Bitstream redirect URL does not work
Example: /temp/file.png: highlighting the required part

bitstreamURL must be abs path to the tomcat/temp folder: /usr/local/tomcat/temp

Create a user for testing: https://github.com/dataquest-dev/dspace-angular/issues/57

@Paurikova2 the test user is created, you can test it.

It is not possible to deposit new item only with file added by bitstream. It requires file in part Uploads file.

Deposit new item only with file added by bitstream works.

Tested


Unable to login G email

I'm trying to log in to my G Suite Gmail account and every time it says "Authentication error" and "client_id" is missing. Attaching a screenshot for reference.

I downloaded the app. I'm not sure the version, I deleted it. I'm having Mac

We've built MacOS release. You can try it.


sort queues and courses (by name)

find some type of logical sorting for the queues and courses on the homepage. alphabetical order may make the most sense.

yup! still on this one :)


Do not terminate stream::SelectAll until the completion of all streams

Fixes #1626

Thanks for the quick fix!


Add a Salesforce Functions builder variant

We want to move Salesforce Functions buildpacks to their own builder image variant to more cleanly separate the two use cases (particularly given that Salesforce Functions is now deprecated), and prevent a number of issues (such as builds on the functions build system being able to pass detection even when the match against a non-functions buildpack).
For more details, see:
https://salesforce.quip.com/MoDFAX3MEf8b
The first stage of this is to create the new builder image variant.
This new variant is only being published to the internal private registry, since it's only being used by Kodon (the SF CLI no longer supports using containers to run functions).
Once it's released, we can then switch Kodon to using the new tag, deploy Kodon to all functions spaces, and then finally remove the functions buildpacks from heroku/builder:22.
We'll also need to adjust the CNB release automation so that it updates the new image variant too:
https://github.com/heroku/languages-github-actions/blob/8f1d3319996df5ec9eb3b4c9c7c0d5de78fa9dba/.github/workflows/_buildpacks-release.yml#L315
GUS-W-14179967.

Note to self: When this is ready to be merged, also adjust the required status checks in the branch protection settings.

Branch protection list of required CI checks updated.


Discuss how we can better help stream encoding / packaging teams test their streams themselves

As a development team we would like to provide better tools so that encoding / packaging teams can test their streams themselves.
Acceptance criteria

The matter has been discussed.
Dedicated issues have been created if needed.

Tasks

[ ] Discuss.
[ ] Create issues.

DRM stream testing
Android and web demos provide a way to set a certificate / license URL. This feature is currently not available on Apple platforms but a task exists, see


Unexpected migration error

Hello, guys.
I'm facing this problem when I try to import in Azure.
[E][17:47:26] Unexpected migration error.
[Microsoft.VisualStudio.Services.WebApi.VssServiceResponseException] Microsoft.VisualStudio.Services.WebApi.VssServiceResponseException: The resource cannot be found.

And later, many and many lines of errors...
Perhaps I have to install the Visual Studio?
Could you help me?
Tks!

I'm taking a guess here, but I think that the most likely culprit is the Azure DevOps connectivity. Make sure that you are using the correct credentials, your token has the proper scopes and is not expired, no issues  with proxy or firewall, etc...
Check that the ADO URL is written correctly in the command and that the project name is correct in the config.


Web- Workspace - Find a member search field has different padding from other search fields

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go https://staging.new.expensify.com/
and login
Go to Workspace \ Manage members
Compare padding of "Find a member" search field with other search fields across the app

Expected Result:
Padding should be the same across the app
Actual Result:
Find a member search field has different padding from other search fields
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/235457742-55ae84b1-a2e4-40ba-8278-41022ef6deda.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause _ Internal Team
Slack conversation:
View all open jobs on GitHub

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Proposal
Please re-state the problem that we are trying to solve in this issue.
On Workspace manage meber page, find a member search field has different padding from other search fields
What is the root cause of that problem?
Here we are using the placeholder for the showing the find member text, and other pages use the label prop for showing the floating placeholder label
What changes do you think we should make in order to solve the problem?
We should replace the placeholder prop with the label prop here
https://github.com/Expensify/App/blob/a7863493a03970cdc0687621ec40dc75aea99477/src/pages/workspace/WorkspaceMembersPage.js#L407-L412
label={this.props.translate('optionsSelector.findMember')}

Result

This is duplicate of https://github.com/Expensify/App/issues/18158

Agreed, closing as duplicate.


The exaplnation is strightforward, very good tutorial

Quantum superposition principle is explained without get the reader confused

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d7575d10-c405-8e24-3487-008d2338b756
Version Independent ID: 030f289f-4280-def3-598b-615883282486
Content: Create a Quantum Random Number Generator - Microsoft Quantum
Content Source: articles/quickstarts/qrng.md
Product: quantum
GitHub Login: @bromeg
Microsoft Alias<EMAIL_ADDRESS>

Thank you very much for your feedback! We are working to expand a bit the tutorial to also show how to create random integers using an external host program. Stay tuned!


 I'm having trouble figuring out why this change would be beneficial to the majority of users of matchmedia since, from a web perspective, we generally measure in pixels.

We can assume that the screen size is less than 7 inches of the device is a mobile phone, or tablet. with pixels can not make a similar judgment.

This library was intended to be a polyfill for window.matchMedia, which has pretty great support now. If you're using this project to target mobile devices you may want to use the native browser API instead since the support should be there.


Failed running script liphonenumber-generate-metadata

Hi I'm trying to create a custom metadata but I get the following error:
`
root@ip-172-31-5-150:/home/ubuntu/libphonenumber-js# npm run-script libphonenumber-metadata

><EMAIL_ADDRESS>libphonenumber-metadata /home/ubuntu/libphonenumber-js
> libphonenumber-generate-metadata metadata.min.json --extended

sh: 1: libphonenumber-generate-metadata: not found

npm ERR! Linux 3.13.0-112-generic
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "run-script" "libphonenumber-metadata"
npm ERR! node v7.8.0
npm ERR! npm  v4.2.0
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR<EMAIL_ADDRESS>libphonenumber-metadata: `libphonenumber-generate-metadata metadata.min.json --extended`
npm ERR! spawn ENOENT
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>libphonenumber-metadata script 'libphonenumber-generate-metadata metadata.min.json --extended'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the libphonenumber-js package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     libphonenumber-generate-metadata metadata.min.json --extended
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs libphonenumber-js
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls libphonenumber-js
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /root/.npm/_logs/2017-03-29T23_04_03_471Z-debug.log
root@ip-172-31-5-150:/home/ubuntu/libphonenumber-js#`

Yes, it says:
sh: 1: libphonenumber-generate-metadata: not found

Which means exactly what it is: libphonenumber-generate-metadata executable is not found.
The readme says:

First, add metadata generation script to your project's package.json

So, this npm script should be added to the project's  package.json, not to libphonenumber-js's package.json.

Ok thanks for clearing that up. I'm using the Standalone version and I would like to use a custom metadata. I think it would be helpful to mention that in the README.
Is there a way I can customise the Standalone version's metadata?

Not understand your question
On Fri 31 Mar 2017 at 01:09 onlineautoparts<EMAIL_ADDRESS>wrote:

Ok thanks for clearing that up. I'm using the Standalone version and I
would like to use a custom metadata. I think it would be helpful to mention
that in the README.
Is there a way I can customise the Standalone version's metadata?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/halt-hammerzeit/libphonenumber-js/issues/62#issuecomment-290559695,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAdH70bX8fqGNrDW5H3kTPoGI1eL_tl4ks5rrCglgaJpZM4MtrA1
.

Sorry I've reworded my question, I hope is clear this time:
[EDITED]
Ok thanks for clearing that up.
I'm using the Standalone version of libphonenumber (the one that does not use any bundlers). I'm calling libphonenumber using Javascript and JQuery for example:
<script> function validateNumber(value){ return libphonenumber.isValidNumber(value,$("#countryCode").val()); } </script>
I found that the phone number "23423423423" is valid in several countries. I would like to use the extended version of the metada at least for Australia and New Zealand.
Is there a way I can customise the Libphonenumber Standalone version's metadata and use the "browser-build" so that I can add to my website ?

For this case, follow the instructions in the Standalone section of the readme, and prior to building the bundle do:
npm run metadata:generate RU,US extended

See the runnable/generate.js file for reference.
That will probably work.


bug: throwing from streambuf::underflow() causes very strange behavior

Here a claim was made -- "we are not using exceptions, but you are free to use them in your code".
Well, for starters since AWS SDK uses libstd -- it certainly throws std::bad_alloc (e.g. when making a copy of a std::string). I am not sure what is the effect of "-fno-exceptions" here -- abort or lack of proper stack unwinding, but in any case it will be a surprise.
Nevertheless I decided to check second portion of this claim -- data I push to S3 is sourced elsewhere. And that elsewhere can fail (e.g. network went down). Which means my custom std::streambuf::underflow() override throws exception. And when this happens I observe this:

on Windows -- operation immediately fails with "can't connect to endpoint"

on Linux -- operation hangs until s3requestTimeoutMs (1 minute in my case) expires and then fails with "can't connect to endpoint"

in both cases my exception doesn't "bubble up" into my code, something catches it.

I am not sure if SDK state is good at this point -- did it properly unwind all related stacks?

what I am supposed to do in underflow() in case of an error?

I've attached logs, they are kind of curious...
win_log.zip
linux_log.zip
P.S. I use v1.0.59. Please, let me know if this issue is already fixed in newer version.

If you are using exceptions, you need to not compile with -fno-exceptions. You can't safely turn them off in windows.
If you want to throw an exception from your code and handle it in your code, that should work provided you have a try{} catch{} in your calling code.
Given the default implementations, On Linux, libcurl will wait until we send it data and if we take too long will timeout.
On windows, we are able to immediately fail the operation. None of this has anything to do with exceptions though.
I don't think anything threw an exception in your case, the iostream::read call failed and we were able to fail the overall operation.

If you are using exceptions, you need to not compile with -fno-exceptions.

I don't. AWS SDK cmake script uses it by default (on Linux) and I don't know how to avoid it without modifying aforementioned script.

I don't think anything threw an exception in your case, the iostream::read call failed and we were able to fail the overall operation.

I definitely threw an exception (just added throw std::runtime_error("AAA") into my_streambuf::underflow(). Something (not me) was catching that exception. I'll check it again tomorrow.
Also, you may want to look at windows log in original post -- looks like there is access to uninitialized memory (see send error).
In general -- are you saying that on Linux there is no way to handle this without timing out? i.e. if smth goes wrong it'll take entire timeout for me to get back from related function call? So, on one hand I need large timeout when uploading large data (operation fails if it takes too long, even if it makes progress) and on the other hand I need smaller timeout to be able to discover problems early. :-\

Spent some time in debugger (on Windows) today. Exception is caught in iostream library, in read() method there is a piece that uses this macro:
 #define _CATCH_IO_END	_CATCH_ALL	/* catch block for _Myios */ \
	_Myios::setstate(ios_base::badbit, true);	/* set badbit and rethrow */ \
	_CATCH_END

The thing is it rethrows only if any bit of exceptions mask is set. My copy of C++11 draft standard has this in <IP_ADDRESS>.p4:

If one of these called functions throws an exception, then unless explicitly noted otherwise, the input function sets badbit in error state. If badbit is on in exceptions(), the input function rethrows the exception
without completing its actions, otherwise it does not throw anything and proceeds as if the called function
had returned a failure indication.

Sigh... I hate iostreams even more now.
The fact that AWS SDK is compiled with -fno-exceptions (on Linux) doesn't matter because libstdc++ isn't linked statically.
Guess I'll set exceptions mask and see how it goes... There are outstanding questions still:

You can't safely turn them [exceptions] off in windows.

May I assume that AWS SDK is compiled with exceptions support on windows? (I am referring to nuget packages published on nuget.org)

If you are using exceptions, you need to not compile with -fno-exceptions.

Is there a cmake flag on Linux that allows me to remove -fno-exceptions from compiler cmd line?

If my AWS SDK library compiled with -fno-exceptions -- is it safe for exception to be propagated from basic_streambuf::underflow() to catch clause in my code? i.e. will it unwind portion of stack belonging to AWS SDK library?

P.S. I think you need to check why log contains garbage (only on Windows) when underflow() throws.

May I assume that AWS SDK is compiled with exceptions support on windows?
Yes. Turning it off, does not prevent windows from throwing, it only turns off stack unwinding... which would be bad.
Is there a cmake flag on Linux that allows me to remove -fno-exceptions from compiler cmd line?
No, but we can add one.
If my AWS SDK library compiled with -fno-exceptions -- is it safe for exception to be propagated from basic_streambuf::underflow() to catch clause in my code? i.e. will it unwind portion of stack belonging to AWS SDK library?
No, but the library itself is exception safe, so when we allow you to turn exceptions back on, then it will be safe to throw.

library itself is exception safe, so when we allow you to turn exceptions back on, then it will be safe to throw.

How do you provide data to libcurl? If it is done through a call back of some sort -- it may not be safe to throw from underflow() -- exception will have to propagate through portion of stack owned by libcurl (which is written in C?) and it may not like it.
In any case -- here is what outstanding (as I see it):

a CMake option is needed to control -fno-exceptions flag
fix problem with libcurl so that it fails operation immediately if read() fails (exception or failbit) instead of waiting until timeout expires
check why log contains garbled data (on Windows) if stream read() fails

I can file these as separate issues, if you prefer. Should I?

Hello?

we're adding a ALLOW_EXCEPTIONS cmake option and then enclosing all c interop that touches C++ to #ifdef try catch  around it. We'll let you know when it's done.

Thank you. What you are going to do with exception thrown from places like streambuf::underflow()?
I checked and indeed -- propagation of C++ exception through C stack is bad. I'll have to come up with some other way to deal with errors in my streambuf overrides. I wish you guys used some custom mechanism for feeding data -- you'd be dictating it's behavior (and it would be much simpler than one iostreams have). Every time I have to deal with them it is PITA. Way too over-engineered.
Can you check why (when stream get bad()) on Windows build random data gets logged?
Similarly for Linux build -- bad stream causes long delay and eventual timeout. Basically, if something went wrong on data retrieval side -- I can't quickly fail upload.
Thank you.

Hi, has anything changed wrt issues raised in this thread? Namely:

Need ALLOW_EXCEPTIONS CMake option (to remove -fno-exceptions flag on Linux)

handling exceptions escaped from iostream object (especially those thrown while inside of libcurl callback) -- you will be forced to catch these (to prevent propagation through C stack), how they will be ultimately reported?

if related iostream::read() call fails (during upload) on Linux we end up sleeping for entire request timeout (which can be very long)

on Windows when there is a problem with HTTPS connection (e.g. SSL error) log often generates "SendRequest: ". It is a problem when you intercept SDK logging and write it elsewhere. I've recently upgraded to v1.1.50 -- problem is still here

I have a related question on exceptions. I am working on Linux and I'm willing to enable exceptions. Say I want to use a custom memory allocator that might occasionally run out of memory. Is it safe to throw std::bad_alloc assuming I catch it in the application calling code? Will it cause any resource leaks (sockets, file descriptors, memory, etc.)?

@zvd1509 Yes, on assumption that SDK doesn't have related bugs and your exception doesn't unwind stack owned by C code (e.g. throwing from curl callback)

@crusader-mike regarding SDK I guess my question is whether it is designed to support exception throwing (a separate question is whether it was properly tested in this scenario)? Regarding curl callbacks, are they expected to allocate memory using a custom allocator?

SDK is compiled with exceptions on Windows, so likely it is fine with exceptions.
About curl callbacks -- SDK can call your code from curl callbacks (e.g. your own streambuf implementation). You potentially could do anything in your code and if related iostream (also in your total control) is configured to allow exceptions to escape -- you'll end up with C++ exception unwinding C stack. There were talks about preventing such things in SDK code, but I don't know if it was ever done.
Plus, curl may not be the only way to create this situation... I didn't follow SDK progress for a long time...

@zdv1509 FYI - nothing happened wrt preventing C++ exception from unwinding curl stack. See this.


Add content types, try2

File [Content_Types].xml was in mode 0o444 when we tried to overwrite it.  Add write permission with chmod(path, 0o644).
Should fix #45.

Thanks. I'll merge this and then think of the CI + version bump.


Missing licenses

This repo has missing licenses for the Photon design scheme and the Photon icon set. It would also be nice if we could find the license for Wikitionary's logo.

This has been addressed in the photon-poc branch.


Java Rabbitmq Client can consume message from  dotnet send message?

emmmmmm,Can Java Rabbitmq Client consume message from  dotnet send message?

It should be able to consume the message. If it's sent from MassTransit, the envelope format is documented and you an always view the JSON format in the RabbitMQ Management Console.
http://masstransit-project.com/MassTransit/advanced/interoperability.html

Okey,Thank U for your help! very nice!


Auto-import not working in module within the same file

struct Struct;
fn main() {}

mod mud {

    fn func() {
        let struct_instance = $0
    }
}

In this case, Struct is not suggested in the completions. However, if I move the mud module to another file, It works.

Interesting to note here is also that for
mod mud {
    struct Struct;
    fn func() {
        $0
    }
}

we do complete the local Struct, but also the flyimport version which is obviously not required in this case. May or may not be related.


Iteration is not usable

I'm trying to loop over an NDArray coordinates, and it seems like iteration needs an overhaul.

NDArray is not iterable (so for (x of my_ndarray) and Array.from(myNdArray) throw errors)
NDIter's implementation of the iterable protocol seems to iterate over only the linearized indices (i.e. Array.from(new NDIter(my_ndarray)) gives [0,1,...], even if the ndarray is multidimensional)
NDIter has properties that are length 32 (V_MAXDIMS) even when the array it's iterating over has fewer dimensions.
NDIter has extraneous properties which obscure how to use it.
NDIter's string representation uses the name f (I think because it is derived from minified code) and is excessively verbose.

import {
  NDIter, range,
} from "./dist"

const myNdArray = range(100, 1, 130).reshape(2, 3, 5)
const myIter = new NDIter(x)
for (let i = 0; i < 17; ++i){ myIter.next() }
console.log(myIter)

prints:
f {
  x: array([
    [
      [ 100, 101, 102, 103, 104 ],
      [ 105, 106, 107, 108, 109 ],
      [ 110, 111, 112, 113, 114 ]
    ],
    [
      [ 115, 116, 117, 118, 119 ],
      [ 120, 121, 122, 123, 124 ],
      [ 125, 126, 127, 128, 129 ]
    ]
  ], dtype=float64),
  shape: [
    2, 3, 5, 0, 0, 0, 0, 0, 0,
    0, 0, 0, 0, 0, 0, 0, 0, 0,
    0, 0, 0, 0, 0, 0, 0, 0, 0,
    0, 0, 0, 0, 0
  ],
  shapem1: [
    1, 2, 4, 0, 0, 0, 0, 0, 0,
    0, 0, 0, 0, 0, 0, 0, 0, 0,
    0, 0, 0, 0, 0, 0, 0, 0, 0,
    0, 0, 0, 0, 0
  ],
  strides: [
    15, 5, 1, 0, 0, 0, 0, 0, 0,
     0, 0, 0, 0, 0, 0, 0, 0, 0,
     0, 0, 0, 0, 0, 0, 0, 0, 0,
     0, 0, 0, 0, 0
  ],
  backstrides: [
    15, 10, 4, 0, 0, 0, 0, 0, 0,
     0,  0, 0, 0, 0, 0, 0, 0, 0,
     0,  0, 0, 0, 0, 0, 0, 0, 0,
     0,  0, 0, 0, 0
  ],
  length: 30,
  lengthm1: 29,
  nd: 3,
  ndm1: 2,
  index: 17,
  coords: [
    1, 0, 2, 0, 0, 0, 0, 0, 0,
    0, 0, 0, 0, 0, 0, 0, 0, 0,
    0, 0, 0, 0, 0, 0, 0, 0, 0,
    0, 0, 0, 0, 0
  ],
  pos: 17,
  factors: [
    15, 5, 1, 0, 0, 0, 0, 0, 0,
     0, 0, 0, 0, 0, 0, 0, 0, 0,
     0, 0, 0, 0, 0, 0, 0, 0, 0,
     0, 0, 0, 0, 0
  ]
}

NDArray is not iterable (so for (x of my_ndarray) and Array.from(myNdArray) throw errors)

Yes, maybe we should expose something like this:
[Symbol.iterator]() {
  return new NDIter(this)
}

NDIter's implementation of the iterable protocol seems to iterate over only the linearized indices (i.e. Array.from(new NDIter(my_ndarray)) gives [0,1,...], even if the ndarray is multidimensional)

Yes, this is by design since most of the functions in core/ are using the linearised indices. The coordinates are currently accessible using iter.coords. This might not be intuitive. I am open to discussing changing the API if can result in improved DX.

NDIter has properties that are length 32 (V_MAXDIMS) even when the array it's iterating over has fewer dimensions.

Yeah, I actually meant to change a while back but if I remember correctly it caused issues with NDMultiIter. Might give it another shot soon.

NDIter has extraneous properties which obscure how to use it.

Yeah, the documentation can be improved here. It is heavily inspired by numpy (see https://numpy.org/doc/stable/dev/internals.code-explanations.html#n-d-iterators).

NDIter's string representation uses the name f (I think because it is derived from minified code) and is excessively verbose.

Hmm, this is weird. Should be fixed.

NDIter's implementation of the iterable protocol seems to iterate over only the linearized indices (i.e. Array.from(new NDIter(my_ndarray)) gives [0,1,...], even if the ndarray is multidimensional)

Yes, this is by design since most of the functions in core/ are using the linearised indices. The coordinates are currently accessible using iter.coords. This might not be intuitive. I am open to discussing changing the API if can result in improved DX.

The linearized indices are not very useful. If that's what you really want, you can typically just iterate over a.data.keys(). I figure if your array has a shape, you probably intend to use it, not just treat the data as one-dimensional.

Yeah, the documentation can be improved here. It is heavily inspired by numpy (see https://numpy.org/doc/stable/dev/internals.code-explanations.html#n-d-iterators).

In Python, nditer is awkward to use and it doesn't translate well at all to JavaScript.
I'm thinking something along the lines of:
// if you need something fancy, yield an object handle to each element.
// note I wrote this so that the handles remain valid after the iterator advances.
// It might make sense to keep one handle and update it destructively.
NDArray.prototype.iter = function* () {
	const ndim = this.shape.length
	const data = this.data
        const it = new NDIter(this)
	while (!it.done()) {
		const offset = it.pos
		yield {
                        offset,
			byteOffset: offset * data.BYTES_PER_ELEMENT,
			index: it.index,
			coords: it.coords.slice(0, ndim),
			get: () => data[offset],
			set: (value) => { data[offset] = value },
		}
		it.next()
	}
}

// iterate over coordinates and values. I think this should be the default iterator:
NDArray.prototype[Symbol.iterator] = NDArray.prototype.entries = function* () {
        for (const v of this.iter()){
                yield [v.coords, v.get()];
        }
}

I could also see an argument that iteration should be over a single axis, not all axes (e.g. should yield matrix rows).

What is the performance of Symbol.iterator?
Iteration is a good programming idiom, and theoretically can have good performance, but in practise I don't know when it comes the latest benchmarks. I don't know how much of a function call overhead there is when using iteration, if it is substantial then I expect that over time the JavaScript compilers within engines such as V8 and SpiderMonkey will improve and there will be much less overhead for using this technique.

What is the performance of Symbol.iterator?

I want to start out by saying this is the wrong question. Benchmarks don't matter if the API does not make it easy to write correct code.
There's a conceptual tension between an axis being:

Geometric (e.g. i=0 is east, i=1 is north, i=2 is up. You might even have some covariant and some contravariant axes!)
A grid-structured domain (images, GIS, cellular automata; i=0 is 0 meters, i=100 is 100 meters)
A completely unstructured domain (particle simulation; i=0 is the 0th particle, i=1000 is the 1000th particle)

It's not clear which of these vectorious is trying to be good at, and what an iterator should expose depends heavily on this! It might even be some combination. For instance, a list of particles might each have some mass and some velocity.

Iteration is a good programming idiom, and theoretically can have good performance, but in practise I don't know when it comes the latest benchmarks. I don't know how much of a function call overhead there is when using iteration, if it is substantial then I expect that over time the JavaScript compilers within engines such as V8 and SpiderMonkey will improve and there will be much less overhead for using this technique.

Anyway, I spent way too much time microbenchmarking and here's what I found:

The performance of Symbol.iterator itself is negligible. The performance of a generator is more overhead, but nothing my code would probably notice.

On a 1000 element Array on my computer:

Looping with for() data[i], for-of, or reduce is about 2 microseconds (must be some magic optimization with reduce!)

Looping with forEach or an iterator object is about 7 microseconds

Looping with a generator (function *) is about 40 microseconds.

If instead of an Array, I loop over a Float32Array or Float64Array, for-of and reduce take about 12 microseconds, though for() data[i] still takes about 2 microseconds.

To be fair, the iterator is written mainly for internal use. My plan was to write one version in JS and another with same API in C/rust/wasm for performance critical applications, similar to the nblas/nlapack-bindings but life (work) kind of got in the way.
It's an interesting idea to expose different iterators for different purposes.

but life (work) kind of got in the way.

I kinda figured. It feels like NDArray was an attempt to generalize over vectors and matrices, but it doesn't seem like this library can do much with n>2!

It's an interesting idea to expose different iterators for different purposes.

Yeah. They also have very different memory patterns:

linear algebra generally needs random access since different axes mix when you apply a linear transformation
raster data needs local access for computing stuff in some local access
discrete particles need sequential access to evolve independently (and maybe to update some spacial index or local structure)

I'm sure there's a very rich theory of API design waiting to be discovered!

Also, benchmarking with only 1000 elements might yield confusing results, try 1M for better comparisons.

1M elements is not something I really use. If I had something that big and needed performance, I'd probably (1) use a plain array instead of a typed array or a wrapper class and (2) use the GPU or worker threads to squeeze out that performance. But this was just a curiosity-driven exploration on very synthetic code, and the results did not seem confusing: https://gist.github.com/rotu/799f0608bd3ede48b9f8f1280876fb05
Maybe I could see 1M elements if I had highly structured data (e.g. tensor networks, joint probability distributions, or particle-particle interaction simulations) but this library can't do some things that would be necessary there (in particular, tensor contractions!)


[Token Update] - Update of typeBodyDefaultLarge

Description
The composite semantic token typeBodyDefaultLarge needs to be fixed ; it does not embed the good value
Motivation & Context
typeBodyStrongLarge and typeBodyDefaultLarge have the same values and should not ; typeBodyDefaultLarge should have a lighter weight

📣 New TestFlight ALPHA upload available 🚀
Please, get the new build from TestFlight app, or contact the project maintainers if you don't have access.

Display name: OUDS Showcase ALPHA (191)
Version: 0.4.0
Build number:<PHONE_NUMBER>
Build tag: 7bdc6b8
Build type: ALPHA
Build details (GitHub): 191

cc @B3nz01d @pylapp @ludovic35 @Tayebsed93 @mccart77
This is an automated message sent with love and Fastlane from our CI/CD pipeline 🤘

this issue is just an example as all font style do not differentiate strong and default. This token update needs to be corrected on all styles

I let you check if the things must be updated and create dedicated issue(s) @B3nz01d

ℹ Released with version v0.4.0 🚀


Short solution needed: "Redis eval example" (lua-redis)

Please help us write most modern and shortest code solution for this issue:
Redis eval example (technology: lua-redis)
Fast way
Just write the code solution in the comments.
Prefered way

Create pull request with a new code file inside inbox folder.
Don't forget to use comments to make solution explained.
Link to this issue in comments of pull request.

Redis eval example


Create thank_contributors.yaml

Just a fun experiment to highlight the contributors from the past month hopefully helping contributors to feel appreciated and recognized.

Proposed Changes

Create a monthly issue thanking contributors from the past month for what they have done.

Readiness Checklist
Author/Contributor

[x] If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

[x] Label as breaking if this is a large fundamental change
[x] Label as either automation, bug, documentation, enhancement, infrastructure, or performance

Worth running this in CI, without creating issues to simulate a sort of dry-run mode?

Tested locally instead of in CI so I'm confident in the changes.


Feature: Remove Clear Reservation Button when user is logged into RemoteLab Host

Make the clear reservation button a little less "obvious". Functionality should still be there, but only to be used as part of a support / trouble shooting workflow.


Use matrix on CI

Update build-and-test workflow to use matrix strategy, gradle wrapper, and conditions for uploading reports only in one matrix target.

@lehvolk on JDK 8, the following test finds only 81 usages of Runnable:
@Test
fun `find usages of Runnable#run method`() {
    runBlocking {
        val ext = cp.usagesExt()
        val runMethod = cp.findClass<Runnable>().declaredMethods.first()
        assertEquals("run", runMethod.name)
        val result = ext.findUsages(runMethod).toList()
        assertTrue(result.size > 100) { "usages (${result.size}) = $result" }
    }
}

(jacodb-core/src/test/kotlin/org/jacodb/testing/features/BaseSearchUsagesTest.kt:142)
(last line was modified to show actual usages)
This test does not fail on JDK 11 and 17, so we I assume there are truly more than 100 usages of Runnable in standard library on higher jdks. Probably, previous CI was not failing because it used jdk+fx package (for jdk8 and jdk19) which probably contains more than 100 usages of Runnable in total due to inclusion of JavaFX stuff. However, using jdk+fx only to satisfy such test is ridiculous. Maybe lower the amount to 50 in this test? If I understand correctly, any number of found usages higher than 0 already proves the correctness of 'findUsages' method.


feat: add option to display file limit in kb or mb

Codecov Report

Merging #371 into v2.1 will decrease coverage by 2.34%.
The diff coverage is 23.52%.

@@            Coverage Diff             @@
##             v2.1     #371      +/-   ##
==========================================
- Coverage   58.33%   55.98%   -2.35%
==========================================
  Files         243      244       +1
  Lines        3972     3899      -73
  Branches      610      544      -66
==========================================
- Hits         2317     2183     -134
- Misses       1518     1582      +64
+ Partials      137      134       -3

Impacted Files
Coverage Δ

.../components/design-system/utils/human-file-size.ts
22.22% <22.22%> (ø)

...ts/design-system/molecules/drop-zone/drop-zone.tsx
19.73% <25%> (+0.01%)
:arrow_up:

src/frontend/components/actions/list.tsx
34.48% <0%> (-31.24%)
:arrow_down:

src/frontend/hooks/use-current-admin.ts
50% <0%> (-25%)
:arrow_down:

...components/design-system/molecules/logged-user.tsx
64.28% <0%> (-21.43%)
:arrow_down:

...end/components/property-type/default-type/list.tsx
60% <0%> (-20%)
:arrow_down:

...rontend/components/property-type/datetime/list.tsx
40% <0%> (-20%)
:arrow_down:

...c/frontend/components/property-type/array/show.tsx
42.85% <0%> (-19.65%)
:arrow_down:

...rontend/components/property-type/textarea/show.tsx
33.33% <0%> (-16.67%)
:arrow_down:

...end/components/design-system/atoms/placeholder.tsx
66.66% <0%> (-16.67%)
:arrow_down:

... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8b28e7...e3301a2. Read the comment docs.


Introduce storage factory framework and composable CLI

Main changes:

instead of --span-storage.type CLI flag the storage type is only read from env variable SPAN_STORAGE (and optionally DEPENDENCY_STORAGE)
CLI options only include flags relevant to the selected storage type(s)
introduce storage.Factory interface for creating different storage components like spanstore.Reader
introduce meta-factory plugin/storage.Factory that instantiates concrete factories based on the above env vars
concrete factories may implement plugin.Configurable interface that allows them to define custom CLI flags and to be initialized from Viper
removed a lot of duplicated code for storage initialization in collector/query/standalone

Related to #422, #608
TODO:

[ ] get a general agreement on the approach
[ ] add missing unit tests for new functionality

Coverage decreased (-0.3%) to 99.65% when pulling 7fc4b695f66f0b385a743917b95f48b50bd6523c on storage-factory into d7d1c74fa74f77d2c7faa50a0c568f979d9a30fd on master.

Coverage decreased (-1.04%) to 98.957% when pulling b024a6d57a48eab0cfce67a4ac5861eb7e9c1064 on storage-factory into d7d1c74fa74f77d2c7faa50a0c568f979d9a30fd on master.

Coverage remained the same at 100.0% when pulling e1891fe367a3af1883a83bb3e28959dfcaebdaad on storage-factory into d7d1c74fa74f77d2c7faa50a0c568f979d9a30fd on master.


Use built-in suspense cache

Once it is released, I'll refactor this to use the built-in suspense cache: https://github.com/reactwg/react-18/discussions/25
For the cache, I'll probably do some sort of nested cache structure, where the top-level cache key is the provider itself, and then under that we can construct whatever cache keys we want. I think it'd make sense to eventually do some sort of cache eviction when an item is no longer retained (similar to how Relay does it), as otherwise we'll have infinite cache growth.
The Provider component will also likely be wrapped in a Cache, as all components underneath should share a unique cache. One implication is that nested providers may have slightly odd caching behavior, but I think the toplevel cache key being the provider will (mostly) solve that.

Going to close this for now. Once these APIs are actually released, I'll re-implement our caching based on it.


Last batch of tests for now.

Changes Unknown when pulling 8a9cff1a27aa767e0145a55cfa4d34db01f73516 on tests-galore into ** on master**.


[VS Code] An error occurred while sending the request.

Error:
An error occurred while sending the request.
Steps to Reproduce:

Hit Sign In
Sign in with microsoft account
Receive ready to collaborate message
Return to VS Code
Get the message in bottom right

##Steps taken

Changed from Ethernet to wifi
Changed networks
Restarted vscode
Rebooted
Had another dev try on a different machine (same issue)

Version Data

extensionName
VSLS

extensionVersion
0.3.395

protocolVersion
2.2

applicationName
VSCode

applicationVersion
1.25.1

platformName
MacOS

platformVersion
16.7.0

Jon and I are trying to figure out if this is related to our network/security at our office, but liveshare was working just yesterday for us and now its not.

Unable to connect to the remote server. TrackingId:e17301c8-aa37-4ad8-951a-54743ec5ba9e, Address:sb://vsls-prod-ins-use-private-relay.servicebus.windows.net/e8fa53f1672dc536788344a051580cb88f31--abc12c11-095a-4bb7-bebb-367bac5de2db, Timestamp:7/17/18 4:27:54 PM

Version Data

extensionName
VSLS

extensionVersion
0.3.395

protocolVersion
2.2

applicationName
VSCode

applicationVersion
1.25.0

platformName
MacOS

platformVersion
16.7.0

logs.zip

@crstamps2 @jonsgreene Can you check to see whether you have Auto Proxy Discovery enabled in your System Preferences -> Network settings (underneath Advanced, then Proxies)? When we've seen this error on macOS, it has typically been caused by automatic proxy detection not working well. We intend to fix this, however, it would be useful to know if disabling it unblocks you to use Live Share or not.

It was not enabled at all.

@crstamps2 From your logs it seems like connecting to our Relay via the proxy failed. Currently for relay connection we don't have support for AD authenticated proxy, and proxy servers that send back content as chunked format instead of using content-length header. Are either of these cases true for you? To unblock, you can set the connection mode to Direct (Direct will work if you and the other collaborator are on the same network, and not having NAT devices inbetween you).
We haven't gotten feedback on the prevalence of different types of proxies, once you confirm the proxy setup you have, it would help us to prioritize how we can support your scenario. Thanks for using Live Share!

@lostintangent @Priya91 I happen to come in today and tried again and its working from my end. I captured the logs for you, not sure if they would show anything different.
successful_logs.zip

We were able to get live share to work about 20 percent of the time. Most times I have to restart my machine in order to get a good session. If I close the working session and start a new one it will fail for the reason above. Here are some additional logs of the failure.
20180821_093620_Launcher.log
20180821_133619_15348585794140_VSCode.log
20180821_133625_Agent.log

@jonsgreene Thanks for the report, we utilize the proxy settings the users set with env variables https_proxy, that's what several other frameworks like node.js also use. Glad you were able to identify the issue, this is by design.

Closing the issue as it's resolved, please re-open if there is additional action items to be followed up on.


typo: prefered -> preferred

Note: I didn't try and test to see if this is a product bug with the typo in the code vs. a docs issue

@nschonni : Thanks for your contribution! The author, @mikeblome, has been notified to review your proposed change.

It's an idea. This is one of the things IntelliSense, or your build, will catch for you in case you inadvertently spell it correctly instead of as specified, so I'm not terribly worried about it. And it's definitely not getting fixed in source after more than a decade like this.


Handle GPG keys without intermediate GitHub Actions

Coming from https://github.com/iterative/terraform-provider-iterative/pull/285#pullrequestreview-817110372, should work as-is, although it hasn't been tested yet.

I was about to push an identical PR :D


Unity Intellisense not working at all anymore.

I have created multiple Unity projects, but to no avail. Console keeps logging whenever I type (more later), and I have tried updating to 1.23.6 beta and downgrading to 1.23.2. I have updated all of the Unity packages involving it, and the Unity version I am using is 2020.1.4f1.
Normal basic C# suggestions are coming up, like public and int but no unity objects like Transform or etc.

On load of OmniSharp, username redacted

Starting OmniSharp server at 11/9/2020, 11:06:59 AM
    Target: /Users/REDACTED/FPStry2/FPStry2.sln

OmniSharp server started.
    Path: /Users/REDACTED/.vscode/extensions/ms-dotnettools.csharp-1.23.2/.omnisharp/1.37.1/run
    PID: 17213

[info]: OmniSharp.Stdio.Host
        Starting OmniSharp on MacOS 10.14.6 (x64)
[info]: OmniSharp.Services.DotNetCliService
        DotNetPath set to dotnet
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Located 1 MSBuild instance(s)
            1: StandAlone 16.8.0 - "/Users/REDACTED/.vscode/extensions/ms-dotnettools.csharp-1.23.2/.omnisharp/1.37.1/omnisharp/.msbuild/Current/Bin"
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        MSBUILD_EXE_PATH environment variable set to '/Users/REDACTED/.vscode/extensions/ms-dotnettools.csharp-1.23.2/.omnisharp/1.37.1/omnisharp/.msbuild/Current/Bin/MSBuild.exe'
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Registered MSBuild instance: StandAlone 16.8.0 - "/Users/REDACTED/.vscode/extensions/ms-dotnettools.csharp-1.23.2/.omnisharp/1.37.1/omnisharp/.msbuild/Current/Bin"
            CscToolExe = csc.exe
            MSBuildToolsPath = /Users/REDACTED/.vscode/extensions/ms-dotnettools.csharp-1.23.2/.omnisharp/1.37.1/omnisharp/.msbuild/Current/Bin
            CscToolPath = /Users/REDACTED/.vscode/extensions/ms-dotnettools.csharp-1.23.2/.omnisharp/1.37.1/omnisharp/.msbuild/Current/Bin/Roslyn
            BypassFrameworkInstallChecks = true
            MSBuildExtensionsPath = /Users/REDACTED/.vscode/extensions/ms-dotnettools.csharp-1.23.2/.omnisharp/1.37.1/omnisharp/.msbuild
[info]: OmniSharp.Cake.CakeProjectSystem
        Detecting Cake files in '/Users/REDACTED/FPStry2'.
[info]: OmniSharp.Cake.CakeProjectSystem
        Could not find any Cake files
[info]: OmniSharp.MSBuild.ProjectSystem
        Detecting projects in '/Users/REDACTED/FPStry2/FPStry2.sln'.
[info]: OmniSharp.Script.ScriptProjectSystem
        Detecting CSX files in '/Users/REDACTED/FPStry2'.
[info]: OmniSharp.Script.ScriptProjectSystem
        Could not find any CSX files
[info]: OmniSharp.WorkspaceInitializer
        Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.CSharpFormattingWorkspaceOptionsProvider, Order: 0
[info]: OmniSharp.WorkspaceInitializer
        Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.Completion.CompletionOptionsProvider, Order: 0
[info]: OmniSharp.WorkspaceInitializer
        Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.RenameWorkspaceOptionsProvider, Order: 100
[info]: OmniSharp.WorkspaceInitializer
        Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.ImplementTypeWorkspaceOptionsProvider, Order: 110
[info]: OmniSharp.WorkspaceInitializer
        Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.BlockStructureWorkspaceOptionsProvider, Order: 140
[info]: OmniSharp.WorkspaceInitializer
        Configuration finished.
[info]: OmniSharp.Stdio.Host
        Omnisharp server running using Stdio at location '/Users/REDACTED/FPStry2' on host 17113.
[info]: OmniSharp.OmniSharpWorkspace
        Miscellaneous file: /Users/REDACTED/FPStry2/Assets/PlayerMove.cs added to workspace

I used to get this on editing a file, but it doesn't seem to happen now, but that's probably because i am currently on 1.23.2.
[info]: OmniSharp.Roslyn.CSharp.Services.Completion.CompletionService Could not find document for file:  /Users/REDACTED/FPStry2/Assets/PlayerMove.cs
I have seen. similar issues and tried fixes, but to no avail.
Specs: MacBook Air 2017 13-inch
If this breaks any rules, inform me and I'll fix it.

Just got something new:
[fail]: OmniSharp.MSBuild.ProjectLoader
        The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks
[warn]: OmniSharp.MSBuild.ProjectManager
        Failed to load project file '/Users/REDACTED/FPStry2/Assembly-CSharp.csproj'.
/Users/REDACTED/FPStry2/Assembly-CSharp.csproj
/Users/REDACTED/.vscode/extensions/ms-dotnettools.csharp-1.23.6/.omnisharp/1.37.3/omnisharp/.msbuild/Current/Bin/Microsoft.Common.CurrentVersion.targets(1180,5): Error: The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks

[fail]: OmniSharp.MSBuild.ProjectManager
        Attempted to update project that is not loaded: /Users/REDACTED/FPStry2/Assembly-CSharp.csproj

Nevermind, my fix was either

Completely uninstalling and reinstalling the extension
Updating Visual Studio from their website

it was one of them, not sure which because I did both.


HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests.

…quests.
What changes were proposed in this pull request?
OMVolumeCreateRequest.java L159:
omClientResponse =
new OMVolumeCreateResponse(omVolumeArgs,volumeList, omResponse.build());
We add this to double-buffer, and double-buffer flushThread which is running in the background when picks up, converts to protoBuf and to ByteArray and write to rocksDB tables. So, during this conversion(This conversion will be done without any lock acquire), if any other request changes internal structure(like acls list) of OmVolumeArgs we might get ConcurrentModificationException.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2344
How was this patch tested?
Ran TestOzoneRpcClient which tests this code path and also added a new test for clone method.

Other test failures seem unrelated.

+1 pending CI. Thanks @bharatviswa504  for the offline discussion and update.

Thank You @xiaoyuyao for the review.
Test failure in OzoneNativeAuthorizer is failing now, as we return new Objects. This object is previously passing because we used to have references and used to update the same references. But now we changed to return copy object, and the Old Api's update DB not cache. The test is failing.  I have disabled this test for now. I will open a new jira to fix this.

Thank You @xiaoyuyao for the review.
Test failure in OzoneNativeAuthorizer is failing now, as we return new Objects. This object is previously passing because we used to have references and used to update the same references. But now we changed to return copy object, and the Old Api's update DB not cache. The test is failing. I have disabled this test for now. I will open a new jira to fix this.

@bharatviswa504 Since the test is failing due to the changes in this PR, I think it would be great if we can fix the test here as we already know the cause. If this jira is a blocker and need to commit urgently then it is even better to fix it in this PR.

Thank You @xiaoyuyao for the review.
Test failure in OzoneNativeAuthorizer is failing now, as we return new Objects. This object is previously passing because we used to have references and used to update the same references. But now we changed to return copy object, and the Old Api's update DB not cache. The test is failing. I have disabled this test for now. I will open a new jira to fix this.

@bharatviswa504 Since the test is failing due to the changes in this PR, I think it would be great if we can fix the test here as we already know the cause. If this jira is a blocker and need to commit urgently then it is even better to fix it in this PR.

Thank You, Dinesh for the comments. I have fixed the test case.

/retest

@bharatviswa504 Thanks for quick turn around. I verified in my local and seems fine. +1 pending CI, will merge once done.

Thanks @xiaoyuyao for reviews and @bharatviswa504 for contribution. This has been merged to master.


Gangs Wars

Сколько часов нужно, чтобы найти код для этой игры?
How many hours does it take to find the code for this game?

How can I close it?

How can I close it? When I set the minigame to false it doesn't stop

U have to false the "Promo" as well in .env


Does not work on Android.

Ive beein trying to get this to work on android. I have a link.xml but it still does not seem to be working at all.

Managed to get it working with the. https://lhkmarcus.com/2020/04/05/how-to-use-aws-sdk-in-unity-2019/ His link and manifest are the wrong way round. And you need to add a androidmanifest.


Task Sequence does not deploy properly following instructions exactly.

Following these directions exactly does not result in a properly working system.
After completing SCCM Deployment, the computer does somewhat work but things like the keyboard filter is not turned on, and you can use narrator as well.
The first issue is the major one that the windows features are NOT getting installed. This prevents things like the keyboard filter from working correctly. Which compromises the entire security of the system.
The second issue is also a security risk of not turning off narrator, however not a bad as the first one.
I have detailed the exact failures below.
Windows features are not getting installed using the Unattend.xml Sysprep Package.
During the Task Sequence it looks like you want to install these features:
<package action="configure">
<assemblyIdentity name="Microsoft-Windows-Foundation-Package" version="10.0.15063.0" processorArchitecture="amd64" publicKeyToken="31bf3856ad364e35" language="" />
<selection name="Client-DeviceLockdown" state="true" />
<selection name="Client-EmbeddedLogon" state="true" />
<selection name="Client-EmbeddedBootExp" state="true" />
<selection name="Client-EmbeddedShellLauncher" state="true" />
<selection name="Client-KeyboardFilter" state="true" />
<selection name="Internet-Explorer-Optional-amd64" state="false" />
<selection name="MediaPlayback" state="false" />
<selection name="WindowsMediaPlayer" state="false" />
<selection name="Xps-Foundation-Xps-Viewer" state="false" />
<selection name="WorkFolders-Client" state="false" />
<selection name="SMB1Protocol" state="false" />
<selection name="SearchEngine-Client-Package" state="false" />
<selection name="Printing-Foundation-Features" state="false" />
<selection name="FaxServicesClientPackage" state="false" />
<selection name="Printing-Foundation-InternetPrinting-Client" state="false" />
<selection name="Printing-XPSServices-Features" state="false" />
<selection name="Printing-PrintToPDFServices-Features" state="false" />
<selection name="Microsoft-Hyper-V-Hypervisor" state="true" />
<selection name="Microsoft-Hyper-V-All" state="true" />
<selection name="Microsoft-Hyper-V" state="true" />
The problem is they are not actually getting installed, as this technique does not look to work.
Correct me if I am wrong here, but you usually have to do this either by updating the WIM itself, or adding steps for DISM servicing during the install.
During the Setup and Configure SRS Application Task Sequence the final install and configuration of the Skype account is not completing properly
The part that is not completing properly is:
Finalsetup.ps1 calls -> Initialize.ps1 as its last step.
Initalize.ps1 then runs the following sequence:
Runs the config.cmd script – Completes Successfully (based on the spot checks I did in the various registry locations)
Loads the HKU\Skype Hive
Imports SkypeUser.Reg – DOES NOT IMPORT
Unloads the hive
Extends Monitor
Imports SkypeRoomSystemFinalSetup.reg – Completes
Schedules – NightlyReboot.ps1 – Completes
Schedules - Logon.ps1 – Completes
Registers The Event Log – Completes
-Kevin

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 29b0551a-0c9b-8934-5e4b-d34fe292ec8e
Version Independent ID: 1e19dcb0-59cd-5e9f-0afc-e30bc4cbf80f
Content: Deploy Skype Room Systems by using System Center Configuration Manager
Content Source: Skype/SfbServer/deploy/deploy-clients/room-systems-scale.md
Product: skype-for-business-itpro
GitHub Login: @Turgayo
Microsoft Alias: jambirk

FYI we tried this both in a production environment and in a built from scratch with latest SCCM Test environment as well.

Thank you @kevinkrautle .
I've reproduced that issue you are experiencing. With the OS build 1709, the unattended.xml file should be updated to use 10.0.16299.15.
assemblyIdentity name="Microsoft-Windows-Foundation-Package" version="10.0.15063.0" processorArchitecture="amd64" publicKeyToken="31bf3856ad364e35" language=""
assemblyIdentity name="Microsoft-Windows-Foundation-Package" version="10.0.16299.15" processorArchitecture="amd64" publicKeyToken="31bf3856ad364e35" language=""
In your case, unattend.xml fails to apply and none of these components are installed. I'll update the guidance and fix that issue.
This line needs to be updated with the latest build information whenever a new OS build support is released. We'll take care of that.

resolved in https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/pull/589#event-1754406299

I rebuilt the task sequence from scratch with the latest MSI which is <IP_ADDRESS> with extracting the Enterprise version from the WIM.
####: Extract the Windows Enterprise Image
dism /export-image /sourceimagefile:H:\sources\install.wim /destinationimagefile:E:\Win10ENTBare.wim /sourceindex:3 /compress:max /checkintegrity
In the Task Sequence I have made sure the Unattend.xml Version is set to: 10.0.16299.15
After doing this multiple times, I have verified the process does not work. I have tested in both a domain join senerio, and a workgroup deployment.
To test an idea, I enabled the Windows-Features offline using DISM.
Note - I did this on the standalone enterprise edition extracted wim.
####: Offline Feature Adjustment
Dism /Mount-Image /ImageFile:"E:\SoakLabsSCCMShare\SkypeRoomSystemV2\SRSv2-Take2\OperatingSystems\Win10ENTBare-V2.wim" /Name:"Windows 10 Enterprise" /MountDir:C:\DISM\offline
Dism /Image:C:\DISM\offline /Enable-Feature /FeatureName:Client-DeviceLockdown
Dism /Image:C:\DISM\offline /Enable-Feature /FeatureName:Client-EmbeddedLogon
Dism /Image:C:\DISM\offline /Enable-Feature /FeatureName:Client-EmbeddedBootExp
Dism /Image:C:\DISM\offline /Enable-Feature /FeatureName:Client-EmbeddedShellLauncher
Dism /Image:C:\DISM\offline /Enable-Feature /FeatureName:Client-KeyboardFilter
Dism /Image:C:\DISM\offline /Disable-Feature /FeatureName:Internet-Explorer-Optional-amd64
Dism /Image:C:\DISM\offline /Disable-Feature /FeatureName:MediaPlayback
Dism /Image:C:\DISM\offline /Disable-Feature /FeatureName:WindowsMediaPlayer
Dism /Image:C:\DISM\offline /Disable-Feature /FeatureName:Xps-Foundation-Xps-Viewer
Dism /Image:C:\DISM\offline /Disable-Feature /FeatureName:WorkFolders-Client
Dism /Image:C:\DISM\offline /Disable-Feature /FeatureName:SMB1Protocol
Dism /Image:C:\DISM\offline /Disable-Feature /FeatureName:SearchEngine-Client-Package
Dism /Image:C:\DISM\offline /Disable-Feature /FeatureName:Printing-Foundation-Features
Dism /Image:C:\DISM\offline /Disable-Feature /FeatureName:FaxServicesClientPackage
Dism /Image:C:\DISM\offline /Disable-Feature /FeatureName:Printing-Foundation-InternetPrinting-Client
Dism /Image:C:\DISM\offline /Disable-Feature /FeatureName:Printing-XPSServices-Features
Dism /Image:C:\DISM\offline /Disable-Feature /FeatureName:Printing-PrintToPDFServices-Features
Dism /Image:C:\DISM\offline /Enable-Feature /FeatureName:Microsoft-Hyper-V-Hypervisor
Dism /Image:C:\DISM\offline /Enable-Feature /FeatureName:Microsoft-Hyper-V-All
Dism /Image:C:\DISM\offline /Enable-Feature /FeatureName:Microsoft-Hyper-V
Dism /Image:C:\DISM\offline /get-features
Dism /Unmount-Image /MountDir:C:\DISM\offline /Commit
After running through the sequence again, the windows features are getting installed which fixes the most important problem which is the keyboard filter and windows features is not getting installed.
The second problem with the registry keys not getting imported SkypeUser.Reg still does not work. I can see it in the logs that it's not working. Looking at the logs might be a few other related things as well, but the reg key is the only one I noticed that was actually wrong when checking.
The third problem which I found matches the other github case the script erroring out installing SRS for the admin account. This error does pop up during the deployement sequence as well which I got on video. Fortunately it does not matter as its just for the admin account, which means I will just ignore the error. (Needs to be documented though)  https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/209
Thanks,
-Kevin

The task sequence has been updated to resolve all these issues.


Replace setting columns with join in SegmentEncoder

IMPORTANT: Please do not create a Pull Request without creating an issue first.
Before submitting (must do checklist)

[x] Did you read the contribution guide?
[x] Did you update the docs? We use Numpy format for all the methods and classes.
[ ] Did you write any new necessary tests?
[ ] Did you update the CHANGELOG?

Type of Change

[ ] Examples / docs / tutorials / contributors update
[ ] Bug fix (non-breaking change which fixes an issue)
[x] Improvement (non-breaking change which improves an existing feature)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes
#323.
Related Issue
#323.
Closing issues
Closes #323.

Codecov Report

Merging #331 (1379f6b) into master (2fb5fc6) will decrease coverage by 33.11%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           master     #331       +/-   ##
===========================================
- Coverage   87.51%   54.39%   -33.12%
===========================================
  Files          97       97
  Lines        4781     4780        -1
===========================================
- Hits         4184     2600     -1584
- Misses        597     2180     +1583

Impacted Files
Coverage Δ

etna/transforms/segment_encoder.py
41.66% <0.00%> (-58.34%)
:arrow_down:

etna/commands/__init__.py
0.00% <0.00%> (-100.00%)
:arrow_down:

etna/commands/backtest_command.py
0.00% <0.00%> (-96.43%)
:arrow_down:

etna/commands/forecast_command.py
0.00% <0.00%> (-92.00%)
:arrow_down:

etna/commands/__main__.py
0.00% <0.00%> (-87.50%)
:arrow_down:

etna/commands/resolvers.py
0.00% <0.00%> (-80.00%)
:arrow_down:

etna/analysis/outliers/density_outliers.py
22.72% <0.00%> (-75.00%)
:arrow_down:

etna/transforms/statistics.py
27.50% <0.00%> (-71.67%)
:arrow_down:

etna/transforms/filter.py
28.57% <0.00%> (-71.43%)
:arrow_down:

etna/analysis/outliers/median_outliers.py
25.00% <0.00%> (-70.84%)
:arrow_down:

... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fb5fc6...1379f6b. Read the comment docs.


Links don't work in the new UI

If an object is a link/relationship, in the old UI you could click on it and go to the relevant Infoton. In the new UI the browser tries to load as a page and CM-Well navigation is lost.
Steps to recreate:
Load TRCS from permid.org
Navigate to Adhesives
http://locahost:9000/permid.org/1-4294951936
Try and navigate to the broader topic
Interestingly this doesn't incur on internal servers, so I suspect the old_ui query string param might be to blame?

I think this was fixed, if you will try it agin using the latest version it seems to be working


Replace Travis badge with Github Actions

Closes #3

Well done, thank you!

Hi @adnathanail I did a mistake and force-pushed to the master, so your changes were overwritten. I'm sorry for my dumb mistake 😢


Bug report: Blinking not working when exported

Describe the bug
A clear and concise description of what the bug is. Blinking not working when exported to XR animator
To Reproduce
Steps to reproduce the behavior:

Set up simple blink morph keys in the VRM addon panel
Export VRM to XR animator
Make sure that auto blink is on in XR animator

Expected behavior
The blink feature normally creates an auto blink moment, now it is not happening as intended. Previous models blink shapekeys worked, but newer attempt do not.
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information)
Windows

OS: [e.g. Windows, macOS, Ubuntu Linux, ...]
Blender [e.g. 2.93.5, 3.1.2, ...]
Addon Version [e.g. 2.4.7, 2.3.8, ...]

Additional context
If I need to download 4.2 to fix this or do things differently, I have no problem, I just am not sure why this recently started happening when I did an iteration with the blinks.
Add any other context about the problem here.

Blender 4.1 , VRM 2_20_65 (newest version from the website), Windows OS
On Mon, Jul 22, 2024 at 7:10 AM saturday06 @.***> wrote:

Thank you for the report!
For investigation purposes, could you please tell me the version of
Blender, the version of the VRM addon, and your OS?
—
Reply to this email directly, view it on GitHub
https://github.com/saturday06/VRM-Addon-for-Blender/issues/525#issuecomment-2243062048,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BIEBMRPQCIHLK45WPSZ5I6DZNUHFDAVCNFSM6AAAAABLHFSJ5KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBTGA3DEMBUHA
.
You are receiving this because you authored the thread.Message ID:
@.***>

I have tested the vrm exported file in both XR animator and Vseeface and
neither version does blinking even when auto blink is turned on.
On Mon, Jul 22, 2024 at 12:06 PM Victoria D @.***> wrote:

Blender 4.1 , VRM 2_20_65 (newest version from the website), Windows OS
On Mon, Jul 22, 2024 at 7:10 AM saturday06 @.***>
wrote:

Thank you for the report!
For investigation purposes, could you please tell me the version of
Blender, the version of the VRM addon, and your OS?
—
Reply to this email directly, view it on GitHub
https://github.com/saturday06/VRM-Addon-for-Blender/issues/525#issuecomment-2243062048,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BIEBMRPQCIHLK45WPSZ5I6DZNUHFDAVCNFSM6AAAAABLHFSJ5KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBTGA3DEMBUHA
.
You are receiving this because you authored the thread.Message ID:
@.***>


The production schema

Starting work on have a separate production schema

Done

Added the production schema, only owner_type = "production" can go into the production schema, and only owner_type != "production" can go into the default and other schemas
dregs ls will now search the default (or passed schema) and the production schema for each query
No docs directly relating to production in this PR, but there is a docs update PR open I will add into about it to
Currently querying is the same, to query production you connect to the production schema, to query the default schema you connect to the default schema

To do
Think about dependencies between datasets in different schemas. I'll leave this to a new PR.


Mr minor changes

I got sick of having red squiggly's so I updated our eslint based off of the eslint.js file that April's team has. I also changed the title in index.html from "Empty Project" to "Brassicaceae"

 ESLint bugs


Path3D (bi)normal computation edge case fix

Regarding: the computation of normals and binormals of Path3D
The computation:
For each segment, the tangent (forward axis) is taken and crossed with the previous binormal (up axis) to get a normal.
The problem:
If the previous binormal is along the same axis as the tangent, the normal will be zero, as will the derived binormal.
The fix:
Use the normal of the previous segment

Pinging @jbousquie / @BabylonJSGuide  for review


[BUG] Clarifying storage needs on C drive for Set-AksHciConfig

Describe the bug
The storage requirements on C drive are not clear. When running Set-AksHciConfig as such:
Set-AksHciConfig -vnet $vnet -imageDir "N:\AKS-HCI\Images" -cloudConfigLocation "N:\AKS-HCI\Config" -nodeConfigLocation "N:\AKS-HCI/" -enableDiagnosticData -Verbose

... renders this:
Not enough disk space is available on drive 'C:'.

My expectation was using all options pointing to another drive, the footprint on C drive would not be a problem. At the very least, required free space on C should be documented, as well as how C drive storage is consumed further on.
To Reproduce
Steps to reproduce the behavior:
Run Set-AksHciConfig with little space left on C drive.
Expected behavior
When setting imageDir, cloudConfigLocation and nodeConfigLocation to a drive different than C, storage on C drive should not be a concern.
Screenshots
Not applicable.
Environment (please complete the following information):
(Get-WmiObject Win32_OperatingSystem).Version
10.0.17763
(Get-WmiObject Win32_OperatingSystem).Caption
Microsoft Windows Server 2019 Datacenter

Additional context
None.
Collect log files
None available (before Set-AksHciConfig).

Can you please try the latest GA build?

Can you also pass -workingDir as N:<somedir>
Can you also do get-akshciconfig | ConvertTo-Json -Depth 10

@polarapfel  Please let us know if the above command line change resolved the issue

Closing bug due to no response. please reopen if the above solution does not work.


Codify doesn't deal well with unknown resource types

I tried running naml codify on an ObjectBucketClaim resource:
apiVersion: objectbucket.io/v1alpha1
kind: ObjectBucketClaim
metadata:
  name: example-obc
spec:
  generateBucketName: example-obc
  storageClassName: openshift-storage.noobaa.io

I was expecting it to fail due to an unknown resource type, but to my surprise it didn't emit any errors. The resulting main.go has no resources (and does not compile).
It would be nice if naml codify would emit an error (and fail) when it is unable to successfully convert the input.

This one is hard.
So naml codify was never originall intended to guarantee anything.
The feature was intended to be just a "good first step" to helping teams get away from yaml. In other words - expecting folks to be able to fix things like compile time issues after code is generated is kind of... well... that was kind of the idea?
The problem comes in where we have multiple resources. If we have 10 resources, and we support 9 of the 10, what should we do? Does the program error? Or do we just get the user the best thing we can? For our original use case of helping teams get away from YAML, I think 9/10 is better than 0/10 if that makes sense?
In other news, it's easy to add support for new objects - only takes a minute - i can take a stab at getting you support for ObjectBucketClaim really quick.

If we have 10 resources, and we support 9 of the 10, what should we do?

How about emitting a warning on stderr that you've encountered an unknown resource type and are ignoring it? That way you still process 9/10 resources, but you also avoid surprising the person running codify, which seems like it's worth something.

but that sounds like it should be a relatively simple change

It is!

if I were to submit that as a PR would you accept it?

Yes! I would love the help! Please open as many PRs as you would like, and feel free to vet them here in the issue tracker as well. Happy to let you contribute as much as you want.

Unfortunately, I already coded this before I read your response.
You can look at #107
If you want to give me a 👍🏻 I would love your review before I merge it and cut a new release.

If you want to give https://github.com/kris-nova/naml/releases/tag/v1.0.3 a try it should do what you are looking for 🙂


Add unrestricted and base workspace to e2e tests

Resolves #3702
How is this addressed

Add unrestricted anmd airlock  worksapces to e2e tests
[ ] Update CHANGELOG.md if needed

/test

/test

/test

/test-force-approve
Cannot test until merged. Have tested as far as I can.

/test-force-approve


feat(audit-log): add audit-log table

Codecov Report

Merging #71 (847715a) into master (9d9016a) will increase coverage by 2.98%.
The diff coverage is 82.14%.

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   37.52%   40.51%   +2.98%
==========================================
  Files          25       26       +1
  Lines         477      506      +29
  Branches       43       44       +1
==========================================
+ Hits          179      205      +26
- Misses        285      289       +4
+ Partials       13       12       -1

Impacted Files
Coverage Δ

src/app/devices/audit-log/audit-log.component.ts
82.14% <82.14%> (ø)

src/app/devices/kvm/kvm.component.ts
69.23% <0.00%> (+4.52%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d9016a...847715a. Read the comment docs.


Necessity of RunFilterParameters in Microsoft.Azure.Management.DataFactory.ActivityRunsOperationsExtensions.QueryByPipelineRun

public static ActivityRunsQueryResponse QueryByPipelineRun(this IActivityRunsOperations operations, string resourceGroupName, string factoryName, string runId, RunFilterParameters filterParameters);
In the above signature, once we have a runId, shouldn't the filterParameters be redundant? As I understand, for a given resource, factory and runId, there will be exactly one response. The filterParameters don't seem to serve any purpose. In fact it can be a source of error when the parameter does not match the runId attributes.

Thank you for your feedback.  Tagging and routing to the team member best able to assist.

Thank you for your question, re-routing to a team member to assist.

@LijuanZ Please help on this, thanks!

@shhafiz @shawnxzq this is by design, note that it's to return ActivityRunsQueryResponse, this method is to list all activity runs for the provided pipeline run. The runId parameter is for pipeline run id, while the filterParameters is to provide further filters on activity runs. 1 pipeline run id is mapped to 1 pipeline run, but can contain multiple activity runs. Thanks!

@nisha-bhatia  Could you please help close this issue as I don't have permission? Thanks!

@nisha-bhatia @jsquire Please help close this, thanks!


Some unstable features can't be used without CLI options

Problem
Since https://github.com/rust-lang/rust/pull/83820 #[link_args] attribute was removed. According to specification of that PR new crates should use build scripts with code like that:
println!("cargo:rustc-link-arg-bins={}", arg);

However, the problem is that extra-link-arg is mentioned in the documentation of cargo unstable features, but can't used in cargo-features. So, you can only pass it as CLI option right now.
Steps (it is assumed that you are using x86_64-pc-windows-msvc toolchain)

git clone --branch=fix-link-args https://github.com/Frago9876543210/min-sized-rust-windows.git
cd min-sized-rust-windows
cargo build --release

Lot of warning: cargo:rustc-link-arg-bins requires -Zextra-link-arg flag as result.
The only way to bypass that problem is custom aliases or manually adding -Zextra-link-arg everywhere.
Possible Solution(s)
Make possible to fallback cargo-features to -Z <feature-name> instead of hardcoded values here?
https://github.com/rust-lang/cargo/blob/e0f9643b0f238d7d2bb7682bad37a0b82d17b704/src/cargo/core/features.rs#L218-L219
Notes
Output of cargo version:
cargo 1.53.0-nightly (65d57e6f3 2021-04-04)

Output of rustc -V --verbose:
rustc 1.53.0-nightly (b0c818c5e 2021-04-16)
binary: rustc
commit-hash: b0c818c5e0fa37251d9fda2f656bf1041a2e1e1d
commit-date: 2021-04-16
host: x86_64-pc-windows-msvc
release: 1.53.0-nightly
LLVM version: 12.0.0

Hi!  Using cargo-features still requires -Zunstable-options, so command-line flags will still be required. It might be possible to support cli flags in the config, but would that address your use case even if you still have to pass -Zunstable-options?

This can be configured in .cargo/config.toml:
[unstable]
extra-link-arg = true

See: https://github.com/rust-lang/cargo/issues/8127


use PouchDB changes feed for events again

THIS IS WORK IN PROGRESS
This is already working, but needs some coordinated updates to pouchdb-hoodie-sync and @hoodie/store-client. We currently emit change events based on pouchdb-hoodie-sync in @hoodie/store-client/lib/subscribe-to-sync-events.js, but with this PR we would trigger two changes. If we implement https://github.com/hoodiehq/discussion/issues/105#issuecomment-281256753, we can probably get rid of pouchdb-hoodie-sync altogether, as it will be reduced to only a few simple methods.
closes #93, closes hoodiehq/camp#13

I’m merging this into the next branch so we can wait with merging it in actual master as we have some more breaking changes coming up


How to access/init the window

Hello,
I'm trying to use this package in a react application.
However, when mounting my component with Enzyme, I'm getting an error related to window:
yarn run v1.3.2
$ ts-node -O '{"module": "commonjs"}' src/features/runner.ts

/ui/node_modules/element-react/dist/npm/es5/libs/utils/popper.js:48
        module.exports = factory();
                         ^
ReferenceError: window is not defined

Is there a way to set the environment like with jest --env=jsdom for instance?
Thanks!

Hello,
This is code that feature detects the context... so I think I can change how this works to remove any problems.
I'll fix this as soon as I can.
Thanks for raising it.