Attempt at fixing "de-dupe cover" breaking chapters

should fix #742
(also fixing general page spread alignment)

Wouldn't it be simpler to just add a offset of 1 on this line?
https://github.com/ciromattia/kcc/blob/master/kindlecomicconverter/comic2ebook.py#L534

Wouldn't it be simpler to just add a offset of 1 on this line if the option is checked?
https://github.com/ciromattia/kcc/blob/master/kindlecomicconverter/comic2ebook.py#L534

maybe i did something wrong but doing it that way if the first page is a chapter (aka "cover" for example) its instead just a copy of the last chapter again

Oh that's because the -1 index is the last item of a list in python.
e.g.
long_list = [1,2,3]
print(long_list[-1])

prints 3
So some additional logic to skip the first chapter if its only one page. Or clamp it to zero if multiple pages.

someone more capable than me should probably take this over if another approach is preferred^^

Went ahead and opened a PR please review and test.

The last PR fixed the bookmark drift (while also deleting first bookmark).
Could you explain on a high level what this code is doing?

i will close this for now, cause at this point it would likely clash with the fix you implemented already.
this had 2 fixes in one. the first one was simply trying correcting the page order for spreads, where the original code would put the page following a spread on the wrong side. (this needs more fixing in general anyway, cause depending on which spread splitting option you chose, this is even more borked, both in the original code and in my fixing attempt, which only fixes some of the issues)
the other one was for the chapters being off with dedupecover. instead of duplicating the first image as a cover page, it just sets the first image as the cover and sets the metadata accordingly. the original dedupe code just removed the (duplicate) cover file after its been added but doesnt handle the resulting page number discrepancy (to my limited understanding anyway)

I see, this PR was a little complicated to review since it had multiple fixes. I might revert my change later if neccessary.
Are you still interested in fixing this:

the original code would put the page following a spread on the wrong side.

Pretty sure what we need to fix this is to assign kcc-a files the rendition:page-spread-center property like here:
https://idpf.org/epub/fxl/#ex4
KCC only does left and right for kcc-b and kcc-c files.

@bust4cap OK made a couple PRs that might affect this

@bust4cap the sync fork button on the GitHub website on your branch is the way to merge master without weird stuff appearing in files changed.

im terrible with github, sorry.
anyway, page alignment is fixed with your pull requests in every way i could find, yes

@bust4cap

ref #784

Please test if this does what you expect, instead of deleting the cover just change the initial page alignment to shift rest of book over.
and is there any remaining problems from your original PR?


Dutch National Flag Algorithm Cpp

I want to contribute Dutch National Flag Algorithm based code .Could you please assign it to me under hactoberfest23.

I wish to contribute. Kindly assign me this.

i wish to contribute, kindly assign me the task @Shrejal123


Remove the exponentiationOperator-plugin as it is now in es2016

This enables it by default now.

can do the same for trailingFunctionCommas, dono if you want that in a separate one

we should deprecate classConstructorCall too

Current coverage is 96.91% (diff: 100%)

Merging #98 into master will not change coverage

@@             master        #98   diff @@
==========================================
  Files            19         19
  Lines          2922       2922
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           2832       2832
  Misses           90         90
  Partials          0          0

Powered by Codecov. Last update b649671...1ad826d

I also started restructuring and renaming the test dirs
-- es2015
-- es2016

at first i wanted to do something like
--es
  -- 2015
  -- 2016

but babel-helper-fixtures is limited to how deep one can nest dirs, so I did the first solution.
Gonna do all in this PR.

I'm not sure how to proceed with classConstructorCall probably we can just remove it with the next major. Should we log a warning if it is used already?

Yeah we would remove it in the next major - just not sure given we would need to update babel too.


Spilling library fails on asan

https://nda.ya.ru/t/BHQ9CIRn7AKhWv
https://github.com/ydb-platform/ydb/blob/7037279ff0c2da803f38354b1ed0c34c2cd3791d/ydb/library/yql/core/spilling/storage/ut/storage_ut.cpp#L1
TYDBLibrarySpillingTest
AddressSanitizer: heap-use-after-free

Temporary disable asan check: https://github.com/ydb-platform/ydb/issues/12513


Correcting visitor question from checkbox to radio

What is the context of this PR?
Fixes https://github.com/ONSdigital/eq-survey-runner/issues/649

@jonnyshaw89 rebase against master?


strapi API

Could we create an API with strapi to power our sites?

Build services and reuse them for other projects.
Have access to node and npm.
CRON tasks...

Can you tell me a use case  - specifically, how will this improve our workflow?

It could be used as an alternative to WordPress using JavaScript instead of PHP.
I like the current approach of using static sites and markdown. Let's put this aside.

It could be used as an alternative to WordPress using JavaScript instead of PHP.

This isn't an improvement; it's a sidestep. I think let's close this for now. Agreed.


NanoHTTPD is shutdown

What?
I'm using NanoHTTPD to launch a web server on an Android device. It works well but sometimes I receive an exception message NanoHttpd Shutdown in the line fi.iki.elonen.NanoHTTPD$HTTPSession in execute at line 714 .
I've been looking for that exception bug I haven't found any useful information. Is that a bug of the server? How could it be fixed?

It's probably not a sign of an error. The ClientHandler receiving a SocketException just means the TCP connection was closed by a client (browser) or the server (in case HTTP 1.1 keepalive is not supported).

@elonen but is it needed to restart the server in that case. I have to keep it alive during the app lifecycle. Otherwise the webview will fail in the content load.
Thanks for you response :)

You mean an exception closes the whole server process? ServerRunnable.run() should keep on accepting new connections when a single one is closed. Does it exit on your implementation and if so, by what kind of exception?


Implement load/save function

Add a load/save function

*.isf
*.svg

Allow to use a shortcut to perform a quicksave with incremental naming


adds travis support

an example output can be seen at https://github.com/ohadlevy/web-ui/pull/1
(linking to https://travis-ci.org/ohadlevy/web-ui/builds/423581566)

Build status on master branch works well.
Means, travis CI is triggered:

for PRs
on merge


add a limit/timeout to how long performScript will wait for the FileMaker window object

right now the setInterval never ends.  I copied this code from FMOnReady (Stephan Casas), and I think we should modify it a little to timeout eventually and clearInterval

Here's a function that can await FileMaker until a timeout is reached:
const checkForFileMaker = async (timeoutInms) => {
  return new Promise((resolve, reject) => {
    let interval;
    let timeout;
    try {
      interval = setInterval(() => {
        if (typeof window.FileMaker === 'object') {
          clearTimeout(timeout);
          resolve(true);
        }
      }, 10);
      timeout = setTimeout(() => {
        clearInterval(interval);
        resolve(false);
      }, timeoutInms);
    } catch (error) {
      clearInterval(interval);
      clearTimeout(timeout);
      reject(error);
    }
  });
};

https://github.com/jwillinghalpern/fm-gofer/commit/0cf88657aaebbbf479feef21a066cb13dd45cd24


Issues with HEAD and Crystal 1.6

On 20e585dd00352b0261b5ba3eb9e2b41a9f8fa029 (current HEAD):
crystalline % shards
Resolving dependencies
Fetching https://github.com/hugopl/version_from_shard.git
Fetching https://github.com/spider-gazelle/priority-queue.git
Fetching https://github.com/samueleaton/sentry.git
Fetching https://github.com/spider-gazelle/bisect.git
Installing version_from_shard (1.2.4)
Installing bisect (1.2.1)
Installing priority-queue (1.0.1)
Installing sentry (0.3.2 at cd86128)
(base) russ@hilaptop crystalline % env LLVM_CONFIG=/opt/homebrew/Cellar/llvm/15.0.1/bin/llvm-config crystal build ./src/crystalline.cr  -o ./bin/crystalline --release --no-debug -Dpreview_mt
Showing last frame. Use --error-trace for full trace.

In /opt/homebrew/Cellar/crystal/1.6.0/share/crystal/src/compiler/crystal/semantic/cover.cr:7:22

 7 | getter matches : ZeroOneOrMany(Match)
                      ^------------
Error: undefined constant ZeroOneOrMany
crystalline %

Presumably this is something todo with Crystal 1.6 and crystal-lang/crystal#12405...

Hey @ukd1,
Thanks for reporting the issue, I just released v0.7.0 which should be compatible with crystal 1.6.0.

Thanks @elbywan, will pull and try 👍🏻

Worked fine, and FYI on M1 Max;
% time env<EMAIL_ADDRESS>crystal build ./src/crystalline.cr --threads 10 -o ./bin/crystalline --release --no-debug -Dpreview_mt
env<EMAIL_ADDRESS>crystal    280.40s user 2.51s system 99% cpu 4:44.12 total
(base) russ@hilaptop crystalline %


feat: breaking plugins to mods to reduce boilerplate code

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

64 of 225 (28.44%)  changed or added relevant lines in 11 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.0%) to 68.69%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

models/job.go
0
1
0.0%

instance/service.go
9
11
81.82%

job/service.go
0
3
0.0%

meta/job_adapter.go
18
21
85.71%

store/local/job_spec_adapter.go
5
8
62.5%

instance/context.go
3
19
15.79%

models/plugin.go
3
136
2.21%

Totals

Change from base Build<PHONE_NUMBER>:
1.0%

Covered Lines:
4039

Relevant Lines:
5880

💛  - Coveralls


SVG files not being displayed in build but are in dev

Describe the bug
when you use an svg it's not displayed in the release binary but it is in during the dev process .
Steps To Reproduce
Use an SVG in a img tag
Build the app in release mode
Run the app
SVG file not displayed
You can clone this repo
Expected behavior
SVG file should be displayed as it is in dev mode
OS : Windows

The tauri version in that repo seems pretty old.
I updated and run it in the release build and it could show the svg.

My bad I didn't see that, I ran yarn tauri deps update and it told me it was up to date. Trusted that blindly :/ I bumped the version by hand in package.json and Cargo.toml rebuilt the app and everthing worked !
Closing


Add custom fonts, fontsize, timing, timing functions for better customization

Also add possibility to make filename longer without line break.
Cool library!

awesome


First 45 finalized edition chunks ready

@raffazizzi @mdlincoln @Rikkm  A heads-up that I've (at last!) prepared our sampling of finalized edition chunks, now committed to this repo (fv-data). My last step for this process is now to output the new "spine" to get the new edition pointers started.
I'm sorry about the length of time this took! It has been some thorny XSLT work, but I seem to have corrected many processes for setting <seg> markers that were problematic with our preliminary work last summer. You may want to check out the new files to get a sense of how they look, and I hope I'll have the new spine files ready to point into this files very shortly. I'll post here again when these are ready.

@raffazizzi @Rikkm  @mdlincoln Okay! The spine files are ready to go, and I think my pointers are good (for all but the S-GA edition).

The new spine directory is here: https://github.com/PghFrankenstein/fv-data/tree/master/standoff_Spine
The  new edition files are here: https://github.com/PghFrankenstein/fv-data/tree/master/edition-chunks

You'll notice I currently have super-fragmented spine files (as in C08a through C08j files) when I had to "micro-chunk" some collation units to improve the alignment. We can pretty easily pull those into a single (C08) file, but my @xml:id's are now derived from those "micro-chunk" letter designations, so I thought it might be just as well to keep the spine files micro-chunked super-fine for the moment.
So ids in C08a are numbered from 1 to however many in that microchunk, and we start numbering over again in C08b. Here's an example: In the spine file for C08e, here's the very first app, with two rdgGrp elements inside, holding two sets of variant readings:
 <app xml:id="C08e_app1">
        <rdgGrp xml:id="C08e_app1_rg1" n="['<p/>', 'i']">
                <rdg wit="fMS"><ptr target="https://raw.githubusercontent.com/PghFrankenstein/fv-data/master/edition-chunks/P5-fMS_C08.xml#C08e_app1-fMS"/></rdg>
       </rdgGrp>
      <rdgGrp xml:id="C08e_app1_rg2" n="['<p/>i']">
                 <rdg wit="f1818"><ptr target="https://raw.githubusercontent.com/PghFrankenstein/fv-data/master/edition-chunks/P5-f1818_C08.xml#C08e_app1-f1818__I"/><ptr target="https://raw.githubusercontent.com/PghFrankenstein/fv-data/master/edition-chunks/P5-f1818_C08.xml#C08e_app1-f1818__F"/></rdg>
                <rdg wit="f1823"><ptr target="https://raw.githubusercontent.com/PghFrankenstein/fv-data/master/edition-chunks/P5-f1823_C08.xml#C08e_app1-f1823__I"/><ptr target="https://raw.githubusercontent.com/PghFrankenstein/fv-data/master/edition-chunks/P5-f1823_C08.xml#C08e_app1-f1823__F"/></rdg>
                <rdg wit="fThomas"><ptr target="https://raw.githubusercontent.com/PghFrankenstein/fv-data/master/edition-chunks/P5-fThomas_C08.xml#C08e_app1-fThomas__I"/><ptr target="https://raw.githubusercontent.com/PghFrankenstein/fv-data/master/edition-chunks/P5-fThomas_C08.xml#C08e_app1-fThomas__F"/></rdg>
                  <rdg wit="f1831"><ptr target="https://raw.githubusercontent.com/PghFrankenstein/fv-data/master/edition-chunks/P5-f1831_C08.xml#C08e_app1-f1831__I"/><ptr target="https://raw.githubusercontent.com/PghFrankenstein/fv-data/master/edition-chunks/P5-f1831_C08.xml#C08e_app1-f1831__F"/></rdg>
                   </rdgGrp>
</app>

PS: Note that there are sometimes multiple pointers inside a <rdg> where segs are fragmented around the element hierarchies in the edition files.


s" and S" do not behave the same way inside a colon definition.

It seems to be interpreting s" as a word, but it is not parsing up to the following " character. See documentation change: 4b44d24cb66891e819c09194e2086212397604d4

Fixed with d152fc3


Segmentation fault compiling 1.39.0 core (OSX/clang9)

Compiled mrustc with clang 9.0 on Mac OS X 10.6.8 then compiling LIBS fails. Any ideas with this backtrace?
$ mrustc rustc-1.39.0-src/src/libcore/lib.rs -o output-1.39.0/libcore.rlib --crate-name core --crate-type rlib -C emit-depfile=output-1.39.0/libcore.rlib.d --crate-tag 0_0_0 -g --cfg debug_assertions -O -L output-1.39.0 --edition 2018

Program received signal EXC_BAD_ACCESS, Could not access memory.
Reason: KERN_INVALID_ADDRESS at address: 0x0000000000000000
0x0000000102171ee1 in __dynamic_cast ()
(gdb) bt
#0  0x0000000102171ee1 in __dynamic_cast ()
#1  0x00000001002eac46 in (anonymous namespace)::check_coerce_tys (context=@0x7fff5fbfcdc0, sp=@0x100919280, dst=@0x10526a0a8, src_r=<value temporarily unavailable, due to optimizations>, context_mut=0x0, node_ptr_ptr=0x7fff5fbfc7c0) at src/hir_typeck/expr_cs.cpp:4718
#2  0x00000001003056c8 in (anonymous namespace)::check_ivar_poss__fails_bounds (context=<value temporarily unavailable, due to optimizations>, ty_l=@0x105943e20, new_ty=@0x105f62fd8) at src/hir_typeck/expr_cs.cpp:5466
#3  0x00000001002da5e0 in (anonymous namespace)::check_ivar_poss (context=@0x7fff5fbfcdc0, i=<value temporarily unavailable, due to optimizations>, ivar_ent=@0x117d559f0, fallback_ty=<value temporarily unavailable, due to optimizations>) at src/hir_typeck/expr_cs.cpp:6244
#4  0x00000001002d43e3 in Typecheck_Code_CS (ms=@0x7fff5fbfdc90, args=@0x117b480d8, result_type=@0x117b480f8, expr=@0x117b48100) at src/hir_typeck/expr_cs.cpp:7109
#5  0x00000001002c440f in (anonymous namespace)::OuterVisitor::visit_function (this=0x7fff5fbfdc88, p={parent = 0x7fff5fbfd878, ty = 0x0, trait = 0x0, trait_params = 0x0, name = 0x103b082fc "into_ref", crate_name = 0x0, wrapped = 0x0}, item=@0x117b48020) at src/hir_typeck/expr_visit.cpp:208
#6  0x000000010020eb8d in std::__1::__tree_next_iter<std::__1::__tree_end_node<std::__1::__tree_node_base<void*>*>*, std::__1::__tree_node_base<void*>*> () at src/hir/visitor.cpp:133
#7  0x000000010020eb8d in std::__1::__tree_iterator<std::__1::__value_type<RcString, HIR::TypeImpl::VisImplEnt<HIR::Function> >, std::__1::__tree_node<std::__1::__value_type<RcString, HIR::TypeImpl::VisImplEnt<HIR::Function> >, void*>*, long>::operator++ () at src/hir/visitor.cpp:845
#8  0x000000010020eb8d in std::__1::__map_iterator<std::__1::__tree_iterator<std::__1::__value_type<RcString, HIR::TypeImpl::VisImplEnt<HIR::Function> >, std::__1::__tree_node<std::__1::__value_type<RcString, HIR::TypeImpl::VisImplEnt<HIR::Function> >, void*>*, long> >::operator++ () at /opt/local/libexec/llvm-9.0/include/c++/v1/map:802
#9  0x000000010020eb8d in HIR::Visitor::visit_type_impl (this=0x7fff5fbfdc88, impl=@0x117b4bc20) at src/hir/visitor.cpp:131
#10 0x00000001002c3614 in (anonymous namespace)::OuterVisitor::visit_type_impl (this=0x7fff5fbfdc88, impl=@0x117b4bc20) at src/hir_typeck/expr_visit.cpp:155
#11 0x000000010020d2ce in std::__1::__wrap_iter<std::__1::unique_ptr<HIR::TypeImpl, std::__1::default_delete<HIR::TypeImpl> >*>::operator++ () at /opt/local/libexec/llvm-9.0/include/c++/v1/iterator:1860
#12 0x000000010020d2ce in (anonymous namespace)::visit_impls<HIR::TypeImpl> () at mrustc-727335b8de4dc913cec76d9456661ac80bff87c4/src/hir/visitor.cpp:20
#13 0x000000010020d2ce in HIR::Visitor::visit_crate (this=0x7fff5fbfdc88, crate=@0x119291c30) at src/hir/visitor.cpp:40
#14 0x00000001002c331e in (anonymous namespace)::OuterVisitor::~OuterVisitor () at src/hir_typeck/expr_visit.cpp:257
#15 0x00000001002c331e in (anonymous namespace)::OuterVisitor::~OuterVisitor () at mrustc-727335b8de4dc913cec76d9456661ac80bff87c4/src/hir_typeck/expr_visit.cpp:109
#16 0x00000001002c331e in Typecheck_Expressions (crate=<value temporarily unavailable, due to optimizations>) at src/hir_typeck/expr_visit.cpp:258
#17 0x0000000100003b0b in CompilePhaseV<main::$_24> () at mrustc-727335b8de4dc913cec76d9456661ac80bff87c4/src/main.cpp:623
#18 0x0000000100003b0b in main (argc=<value temporarily unavailable, due to optimizations>, argv=<value temporarily unavailable, due to optimizations>) at crate_ptr.hpp:622

Looks like it's in the logic that tries to advance through blocks when handling coercions. (That line number doesn't match current HEAD, so hard to be fully sure).
Could you run with the environment variable MRUSTC_DEBUG=Typecheck Expressions set? That will give a bit more information as to the situation that causes the crash (you can use the script log_get_last_function.py to extract just the failing function from that log)

Backtrace with HEAD:
(0.08 s) Typecheck Outer: DONE
Typecheck Expressions: V V V

Program received signal EXC_BAD_ACCESS, Could not access memory.
Reason: KERN_INVALID_ADDRESS at address: 0x0000000000000000
0x000000010217cee1 in __dynamic_cast ()
(gdb) bt
#0  0x000000010217cee1 in __dynamic_cast ()
#1  0x00000001002ea702 in (anonymous namespace)::check_coerce_tys (context=@0x7fff5fbfcd90, sp=@0x10091c470, dst=@0x1023f8e68, src_r=<value temporarily unavailable, due to optimizations>, context_mut=0x0, node_ptr_ptr=0x7fff5fbfc790) at src/hir_typeck/expr_cs.cpp:4714
#2  0x0000000100305384 in (anonymous namespace)::check_ivar_poss__fails_bounds (context=<value temporarily unavailable, due to optimizations>, ty_l=@0x105733bb0, new_ty=@0x1052c7898) at src/hir_typeck/expr_cs.cpp:5462
#3  0x00000001002da0e8 in (anonymous namespace)::check_ivar_poss (context=@0x7fff5fbfcd90, i=<value temporarily unavailable, due to optimizations>, ivar_ent=@0x118404740, fallback_ty=<value temporarily unavailable, due to optimizations>) at src/hir_typeck/expr_cs.cpp:6240
#4  0x00000001002d3eeb in Typecheck_Code_CS (ms=@0x7fff5fbfdc60, args=@0x1177d3c58, result_type=@0x1177d3c78, expr=@0x1177d3c80) at src/hir_typeck/expr_cs.cpp:7105
#5  0x00000001002c3e9f in (anonymous namespace)::OuterVisitor::visit_function (this=0x7fff5fbfdc58, p={parent = 0x7fff5fbfd848, ty = 0x0, trait = 0x0, trait_params = 0x0, name = 0x103aee3cc "into_ref", crate_name = 0x0, wrapped = 0x0}, item=@0x1177d3ba0) at src/hir_typeck/expr_visit.cpp:208
#6  0x000000010020ec1d in std::__1::__tree_next_iter<std::__1::__tree_end_node<std::__1::__tree_node_base<void*>*>*, std::__1::__tree_node_base<void*>*> () at src/hir/visitor.cpp:133
#7  0x000000010020ec1d in std::__1::__tree_iterator<std::__1::__value_type<RcString, HIR::TypeImpl::VisImplEnt<HIR::Function> >, std::__1::__tree_node<std::__1::__value_type<RcString, HIR::TypeImpl::VisImplEnt<HIR::Function> >, void*>*, long>::operator++ () at src/hir/visitor.cpp:845
#8  0x000000010020ec1d in std::__1::__map_iterator<std::__1::__tree_iterator<std::__1::__value_type<RcString, HIR::TypeImpl::VisImplEnt<HIR::Function> >, std::__1::__tree_node<std::__1::__value_type<RcString, HIR::TypeImpl::VisImplEnt<HIR::Function> >, void*>*, long> >::operator++ () at /opt/local/libexec/llvm-9.0/include/c++/v1/map:802
#9  0x000000010020ec1d in HIR::Visitor::visit_type_impl (this=0x7fff5fbfdc58, impl=@0x1177d7610) at src/hir/visitor.cpp:131
#10 0x00000001002c30a4 in (anonymous namespace)::OuterVisitor::visit_type_impl (this=0x7fff5fbfdc58, impl=@0x1177d7610) at src/hir_typeck/expr_visit.cpp:155
#11 0x000000010020d35e in std::__1::__wrap_iter<std::__1::unique_ptr<HIR::TypeImpl, std::__1::default_delete<HIR::TypeImpl> >*>::operator++ () at /opt/local/libexec/llvm-9.0/include/c++/v1/iterator:1860
#12 0x000000010020d35e in (anonymous namespace)::visit_impls<HIR::TypeImpl> () at /opt/local/var/macports/build/_Users_emiller_macports.local_lang_mrustc/mrustc/work/mrustc-d36280157ce8f3128f3855bbd39c5e5c3acf91c7/src/hir/visitor.cpp:20
#13 0x000000010020d35e in HIR::Visitor::visit_crate (this=0x7fff5fbfdc58, crate=@0x118e67980) at src/hir/visitor.cpp:40
#14 0x00000001002c2dae in (anonymous namespace)::OuterVisitor::~OuterVisitor () at src/hir_typeck/expr_visit.cpp:257
#15 0x00000001002c2dae in (anonymous namespace)::OuterVisitor::~OuterVisitor () at /opt/local/var/macports/build/_Users_emiller_macports.local_lang_mrustc/mrustc/work/mrustc-d36280157ce8f3128f3855bbd39c5e5c3acf91c7/src/hir_typeck/expr_visit.cpp:109
#16 0x00000001002c2dae in Typecheck_Expressions (crate=<value temporarily unavailable, due to optimizations>) at src/hir_typeck/expr_visit.cpp:258
#17 0x000000010000362b in CompilePhaseV<main::$_24> () at /opt/local/var/macports/build/_Users_emiller_macports.local_lang_mrustc/mrustc/work/mrustc-d36280157ce8f3128f3855bbd39c5e5c3acf91c7/src/main.cpp:623
#18 0x000000010000362b in main (argc=<value temporarily unavailable, due to optimizations>, argv=<value temporarily unavailable, due to optimizations>) at crate_ptr.hpp:622

It looks like the crashing line is:
https://github.com/thepowersgang/mrustc/blob/d36280157ce8f3128f3855bbd39c5e5c3acf91c7/src/hir_typeck/expr_cs.cpp#L4714
Maybe it's an issue with the compiling / run-time version of clang / LLVM? (9.0.1, compiled by MacPorts)
I tried turning on the debugging output but it is fairly cumbersome; let me know if you still need it.

It looks like this is addressed by #192

Added a set of assertions and located the cause. check_coerce_tys is called with an empty node in check_ivar_poss__fails_bounds (... which I would have seen if I was looking at that backtrace properly).
Applying my own version of #199 with relevant assertions.

I think we should be able to close this now that a fix is in.


[idyntree] Update to 12.4.0

[x] Changes comply with the maintainer guide.
[x] SHA512s are updated for each updated download.
[x] The "supports" clause reflects platforms that may be fixed by this new version.
[x] Any fixed CI baseline entries are removed from that file.
[x] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

Interestingly, I first accidentally forgot to update the hash, and the CI was green. Nevertheless, this is fixed now.

Interestingly, I first accidentally forgot to update the hash, and the CI was green. Nevertheless, this is fixed now.

Well, the old hash is the key to the cache, and it usually has a cache hit.


Multiple outdated announcements can be made when the user stops typing into the character count.

Description of the issue
Multiple count messages can get 'queued up' and announced when the user stops typing into the character count. Some of these messages will be outdated, and do not reflect the latest 'count'.
https://user-images.githubusercontent.com/121939/147126319-a96b7f62-bc78-49a9-be23-42f032045d6d.mov
Steps to reproduce the issue

Go to https://govuk-frontend-review.herokuapp.com/components/character-count/preview
Type multiple characters into the box quickly, then pause

Actual vs expected behaviour
Expected behaviour: Only one count message should be announced, and it should reflect the current number of remaining characters in the textarea.
Actual behaviour: Multiple count messages are announced in:

JAWS 2021.2103.174 / Chrome 96
JAWS 2021.2103.174 / Firefox 95
NVDA 2021.2 / Chrome 96

This also happens occasionally in JAWS 2021.2103.174 / IE 11 and with VoiceOver / Safari 15.2 (macOS Big Sur).
It did not seem to occur with NVDA 2021.2 / Firefox 94 or VoiceOver / Safari (iOS 15.2).
Environment (where applicable)

Operating system: As above
Browser: As above
Browser version: As above
GOV.UK Frontend Version: v4.0.0

I think this is also related to, and compounded by, #2485.

I've looked at this as part of #2539 and made some attempts to debounce the update of the counter until after the user has stopped typing for a short period of time.
Unfortunately this is being undermined by the bugfix we have in place for Dragon Naturally Speaking, which forces an update to happen every one second if the textarea value has been changed. This plus debouncing does reduce the number of announcements being queued up, but it doesn't resolve it completely or prevent stuttering in the readout.

Unfortunately this is being undermined by the bugfix we have in place for Dragon Naturally Speaking, which forces an update to happen every one second if the textarea value has been changed. This plus debouncing does reduce the number of announcements being queued up, but it doesn't resolve it completely or prevent stuttering in the readout.

Could we keep a timestamp of the last time the count message was updated because of a key event, and then only trigger an update from the one second interval if that timestamp is more than one second ago? That way the interval timer should be a no-op if the keyboard events are firing as you'd expect when Dragon isn't involved… I think?


Since arc is quite a commonly used function, why not add it to Raphael?

Since arc is quite a commonly used function, why not add it to Raphael?

I certainly would love to see this as a native feature, as opposed to relying on a additional library that includes more than this one function.


check_box ignores help

<%= f.check_box :stuff, help: "Provides stuff" %>

does not render the help text.

Yes, this is a bit tricky due to how check boxes are rendered by Bootstrap. To display help and error message for a check box you need to wrap it in a form_group, like this:
<%= f.form_group :stuff do %>
  <%= f.check_box :stuff, help: "Provides stuff" %>
<% end %>

This is already documented in the README, here: https://github.com/bootstrap-ruby/rails-bootstrap-forms#checkboxes-and-radios

@mattbrictson 's answer is a bit wrong in that the help option needs to be on the form group not on the checkbox. But it is documented as he has stated.

Thanks, @nodrog. We had a lot of challenges with the positioning of help and errors for Bootstrap 4, since it changed in significant ways. See #418, #419, #436, #448, #444, #454, etc. I think we have it right now, but if you're seeing wrong behaviour, please let us know how to reproduce the problem, and we'll look at it.


Squashed and mashed version of PR#10

Made to build and tests seem to run but some "make" tasks still fail.

cAdvisor seems to be for containers, which is different from systemd units.
Besides, the total memory used by a systemd unit is useful information.
Limits information (like max file descriptors) is less useful when you sum it over multiple processes. What does it mean if  a group of 5 processes uses 10% of its limit (of anything)? One process may be close to its own limit and others might not.

Actually, there is no functional difference between containers and units, when it comes to cgroup resource reporting.


LoRA for downstream task tuning

Hi, Lyken17 , thank you for sharing wonderful works,
I would like to customize the VILA for downstream task tuning and find the LoRA args in https://github.com/Efficient-Large-Model/VILA/blob/90eda3dc4a9fad021a7adae59cd1a3f8bce78b23/llava/train/args.py#L75
Can I use lora by adding in scripts:
--lora_enable True --lora_r 128 --lora_alpha 256 --mm_projector_lr 2e-5 \

lora is supported, but we do not recommend using LoRA for finetuning. Performance is not as good as directly finetuning.

the lora args should be comptaible by default. But as @yaolug mentioned, we haven't measure the performance yet and acc degradtion is expected.

Thank you for confirmation

@hzhang57 Hi ,Have you fine-tuned successfully? I encountered the following error during training:
Traceback (most recent call last):   File "/cfs-allenxmzhu/workspace/VILA/llava/train/train_mem.py", line 36, in <module>     train()   File "/cfs-allenxmzhu/workspace/VILA/llava/train/train.py", line 410, in train     trainer.train()   File "/root/miniconda3/envs/vila/lib/python3.10/site-packages/transformers/trainer.py", line 1537, in train     return inner_training_loop(   File "/root/miniconda3/envs/vila/lib/python3.10/site-packages/transformers/trainer.py", line 1672, in _inner_training_loop     model, self.optimizer = self.accelerator.prepare(self.model, self.optimizer)   File "/root/miniconda3/envs/vila/lib/python3.10/site-packages/accelerate/accelerator.py", line 1198, in prepare     result = self._prepare_deepspeed(*args)   File "/root/miniconda3/envs/vila/lib/python3.10/site-packages/accelerate/accelerator.py", line 1537, in _prepare_deepspeed     engine, optimizer, _, lr_scheduler = deepspeed.initialize(**kwargs)   File "/root/miniconda3/envs/vila/lib/python3.10/site-packages/deepspeed/__init__.py", line 165, in initialize     engine = DeepSpeedEngine(args=args,   File "/root/miniconda3/envs/vila/lib/python3.10/site-packages/deepspeed/runtime/engine.py", line 309, in __init__     self._configure_optimizer(optimizer, model_parameters)   File "/root/miniconda3/envs/vila/lib/python3.10/site-packages/deepspeed/runtime/engine.py", line 1184, in _configure_optimizer     self.optimizer = self._configure_zero_optimizer(basic_optimizer)   File "/root/miniconda3/envs/vila/lib/python3.10/site-packages/deepspeed/runtime/engine.py", line 1474, in _configure_zero_optimizer     optimizer = DeepSpeedZeroOptimizer_Stage3(   File "/root/miniconda3/envs/vila/lib/python3.10/site-packages/deepspeed/runtime/zero/stage3.py", line 300, in __init__     self._setup_for_real_optimizer()   File "/root/miniconda3/envs/vila/lib/python3.10/site-packages/deepspeed/runtime/zero/stage3.py", line 382, in _setup_for_real_optimizer     self.initialize_optimizer_states()   File "/root/miniconda3/envs/vila/lib/python3.10/site-packages/deepspeed/runtime/zero/stage3.py", line 892, in initialize_optimizer_states     self._optimizer_step(i)   File "/root/miniconda3/envs/vila/lib/python3.10/site-packages/deepspeed/runtime/zero/stage3.py", line 817, in _optimizer_step     self.optimizer.step()   File "/root/miniconda3/envs/vila/lib/python3.10/site-packages/torch/optim/lr_scheduler.py", line 68, in wrapper     return wrapped(*args, **kwargs)   File "/root/miniconda3/envs/vila/lib/python3.10/site-packages/torch/optim/optimizer.py", line 373, in wrapper     out = func(*args, **kwargs)   File "/root/miniconda3/envs/vila/lib/python3.10/site-packages/torch/optim/optimizer.py", line 76, in _use_grad     ret = func(self, *args, **kwargs)   File "/root/miniconda3/envs/vila/lib/python3.10/site-packages/torch/optim/adamw.py", line 184, in step     adamw(   File "/root/miniconda3/envs/vila/lib/python3.10/site-packages/torch/optim/adamw.py", line 335, in adamw     func(   File "/root/miniconda3/envs/vila/lib/python3.10/site-packages/torch/optim/adamw.py", line 509, in _multi_tensor_adamw     grouped_tensors = Optimizer._group_tensors_by_device_and_dtype([   File "/root/miniconda3/envs/vila/lib/python3.10/site-packages/torch/optim/optimizer.py", line 397, in _group_tensors_by_device_and_dtype     return _group_tensors_by_device_and_dtype(tensorlistlist, with_indices)   File "/root/miniconda3/envs/vila/lib/python3.10/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context     return func(*args, **kwargs)   File "/root/miniconda3/envs/vila/lib/python3.10/site-packages/torch/utils/_foreach_utils.py", line 42, in _group_tensors_by_device_and_dtype     torch._C._group_tensors_by_device_and_dtype(tensorlistlist, with_indices).items() RuntimeError: Tensors of the same index must be on the same device and the same dtype except step tensors that can be CPU and float32 notwithstanding


Will support iOS?

ios support ?

iOS support will be coming soon.

Any luck with this yet?

Actually - this package supports both - android and ios.
Also changes app name.
https://pub.dev/packages/rename

Hi, any support for iOs yet ?
I think the package is good but without a complete rename (including android/ios a least) I think a lot of developers will not use it.
The rename package doesn't work always well.

but still the pub.dev says it supports all platform.

I do have plans to support iOS. Will be doing it this or next month.
It's a side project and I rarely use it but do contribute to it occasionally, I will be back to full speed soon.

Will be doing it this or next month.

Any update to this? :)

Will be doing it this or next month.

@atiqsamtia, any update to this? :)

@atiqsamtia, any update on this?

Have you check package_rename_plus?

iOS support is now LIVE on pub dev version 1.3.0


3762-integrate listing-block headline with with TOC

Configured the listing-block by adding the tocEntry function used by block-toc to generate the table of content
https://user-images.githubusercontent.com/104510089/221514697-77061332-7552-43c9-b220-1a5e7798c402.mov

ah... I'm not sure why we're going this route. We (at least I assume it's a general "we") don't want to include the actual listed items in the Toc, just the block headline.

@tedw87 could you please take a look at @davisagli suggestions? Thanks!

I haven't checked the code lately, but as far as I understand, the conceptual problem is this: do we want a block to be able to return multiple TOC entries? To which I'd say: yes, of course!

@tiberiuichim I agree with that conceptually, but I would not add it without applying it to a concrete use case to make sure we're designing the right interface for configuring it, and we don't have that use case in the listing block, so I would not add it in this PR. Maybe I'm being too careful.
The particular concern I have with the implementation here is that the caller of tocEntry has to account for the fact that it can return 2 different types. It would be better to make the return type consistent (i.e. always a list of entries). But that's not backwards compatible. So maybe the path forward is to make a new function called tocEntries and deprecate tocEntry.

@davisagli @sneridagh @tiberiuichim
I added a new function that can be defined in blocks configuration (tocEntries) that returns an array of entries. The old one (tocEntry) can still be used and is also required for backward compatibility. check here
I also added a new helper function getBlocksTocEntries that can be used to get the entries of a BlocksForm.
Example of usage:
config.blocks.blocksConfig.columnsBlock.tocEntries = (blockData, data) => {
  const columns = blockData.data.blocks_layout.items || [];
  let entries = [];

  columns.forEach((column) => {
    const { blockDataFormEntries } = getBlocksTocEntries(
      {
        ...blockData.data.blocks[column],
      },
      data,
    );
    entries = [...entries, ...blockDataFormEntries];
  });

  return entries;
};


Support return value

This allows js function to declare return values either as a single Value, or as an array of Value. This will generate new output parameters to the behavior that will be set when return is called.

Interesting. I was thinking it would be more like how the in-game editor works to just put any return values as parameters and modify them in the function body. But that's pretty weird for js developers.

That would probably work, but would be extremely weird when reading the code. And as you already made the decision to use out parameter for predefined functions, I think going with this is good enough. There is of course a performance cost as this mostly imply a copy of each output parameter, but I am wondering if we can solve this later on with code optimizations.


Only start stopwatch when dataTableShowLogs && kDebugMode is true

Now every build a stopwatch is created in debug and release mode.
If the properties dataTableShowLogs && kDebugMode are not true, it's created and started every build.
This is unnecessary.

Quick fix:
Now

  @override
  Widget build(BuildContext context) {
    var sw = Stopwatch();
    sw.start();

    ...

    sw.stop();

    if (dataTableShowLogs && kDebugMode) {
      debugPrint('DataTable2 built: ${sw.elapsedMilliseconds}ms');
    }

How it could be
    Stopwatch? sw;

  @override
  Widget build(BuildContext context) {
     if (dataTableShowLogs && kDebugMode){
     sw = Stopwatch();
     sw.start();
     }

...

    if (dataTableShowLogs && kDebugMode) {
      sw.stop();
      debugPrint('DataTable2 built: ${sw.elapsedMilliseconds}ms');
    }

And also pls add a property to disable the debug completely


Add Optitype tool.

Adds the Optitype tool to annotation.yml.
Installation sequence for tool-installers

[ ] Test using @galaxybot test this
[ ] Inspect CI output for expected changes
[ ] Deploy using @galaxybot deploy this if test install was successful
[ ] Merge this PR

@galaxybot test this

@galaxybot deploy this


Error: Failed to read config file "/Users/…/.vscode/extensions/streetsidesof tware.code-spell-checker-spanish-2.3.4/@cspell/dict- es-es/cspell-ext.json"

Hi, I must've accidentally deleted something when doing npkill maintenance in my machine.
Everytime I open a project in VSCode I get the following message and most of the words are not recognized and are marked as error with blue skwiglys.
"/Users/…/.vscode/extensions/streetsidesof tware.code-spell-checker-spanish-2.3.4/@cspell/dict- es-es/cspell-ext.json" imported by "/Users/…/.vscode/extensions/streetsidesof tware.code-spell-checker-spanish-2.3.4/cspell- ext.json"

I tried installing cspell and running cspell link list and the list appears empty. Is there a way I can download or generate the missing file?

@moitorrijos,
That must be frustrating.
The easiest fix is to just delete the folders: ~/.vscode/extensions/streetsidesoftware.code-spell-checker-spanish* and re-install the extension.
Trying to install the dictionary separately and linking it isn't really advised.


Feature request: support high resolution metrics

Is your feature request related to a problem? Please describe.

Amazon CloudWatch announced support for high resolution metric extraction from structured logs (EMF). Customers can now provide an optional StorageResolution parameter within the EMF specification with a value of 1 or 60 (default) to indicate the desired resolution (in seconds) of the metric.
We should consider adding support for this new optional parameter to Metrics.
The EMF log should have this format:
{
  "_aws": {
    "CloudWatchMetrics": [
      {
        "Metrics": [
          {
            "Name": "Time",
            "Unit": "Milliseconds",
            "StorageResolution": 60 // <- new key
          }
        ],
        ...
      }
    ]
  },
  "Time": 1
}

As part of this issue we should also update the API docs, documentation, and unit/integration tests.
Describe the solution you'd like

import software.amazon.lambda.powertools.metrics.Metrics;
import software.amazon.cloudwatchlogs.emf.logger.MetricsLogger;

public class MetricsEnabledHandler implements RequestHandler<Object, Object> {

    MetricsLogger metricsLogger = MetricsUtils.metricsLogger();

    @Override
    @Metrics(namespace = "ExampleApplication", service = "booking")
    public Object handleRequest(Object input, Context context) {
        // Publish a metric with standard resolution i.e. StorageResolution = 60
        metricsLogger.putMetric("SuccessfulBooking", 1, Unit.COUNT, Resolution.STANDARD);
        // Publish a metric with high resolution i.e. StorageResolution = 1
        metricsLogger.putMetric("SuccessfulBooking", 1, Unit.COUNT, Resolution.HIGH);
        // The last parameter (storage resolution) is optional
        metricsLogger.putMetric("SuccessfulBooking", 1, Unit.COUNT);
    }
}

Describe alternatives you've considered

Additional context

This feature depends on a major version upgrade of aws-embedded-metrics-java v4.1.0.
The upgrade involves a breaking change, described in https://github.com/awslabs/aws-lambda-powertools-java/issues/944.


update README

I updated the document. If it is unnatural, please correct.

ref: https://github.com/ndmitchell/hlint/issues/472

Thanks! Looks great.


aboute the main.py

Hi,
there are no arguments "args.distributed"  in the coda file "mian.py" i think. Hope your reply ,thanks!

args.distributed is assigned in "utils.init_distributed_mode", which is called from main.py here :
https://github.com/saic-fi/edgevit/blob/master/src/main.py#L173
still, this line has a silly issue but does not break things. I will fix it in the next commit:
https://github.com/saic-fi/edgevit/blob/master/src/main.py#L193

Hi,
    Thank you for your earnest reply ,which would be really helpful to me！Since I am a beginner ,i modified a little bit by learning, and it can be realized smoothly and i will also refer to your reply.
---Original---
From: @.>
Date: Sat, Mar 18, 2023 03:57 AM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [saic-fi/edgevit] aboute the main.py (Issue #7)
args.distributed is assigned in "utils.init_distributed_mode", which is called from main.py here :
https://github.com/saic-fi/edgevit/blob/master/src/main.py#L173
still, this line has a silly issue but does not break things. I will fix it in the next commit:
https://github.com/saic-fi/edgevit/blob/master/src/main.py#L193
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

Hi，
    Can i know what is the reason for your choice of channel transformation，since your channels of each block is  [36,72,144,288]？Thanks!
---Original---
From: @.>
Date: Sat, Mar 18, 2023 03:57 AM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [saic-fi/edgevit] aboute the main.py (Issue #7)
args.distributed is assigned in "utils.init_distributed_mode", which is called from main.py here :
https://github.com/saic-fi/edgevit/blob/master/src/main.py#L173
still, this line has a silly issue but does not break things. I will fix it in the next commit:
https://github.com/saic-fi/edgevit/blob/master/src/main.py#L193
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


feat(pixels): add my new pixel

Checklist

[x] I ran npm test locally and it passed without errors.

[x] I only edited the _data/pixels.json file.

[x] I entered the username in the pixels.json that I'm also using to create this pull request.
[x] I acknowledge that all my contributions will be made under the project's license.

close


Sometimes a bunch of my files are duplicated and a 2 is appended to the filename

This is a very strange issue when I'm using visual studio, sometimes some of my files get duplicated and there's a 2 at the end of the name of the file. For instance mod.mk gets duplicated to create a file called "mod 2.mk"

@aaronbuchwald can you help confirm

you are using VS Code, other than Visual Studio
Do you run into the same issue when you have extensions disabled?

I am using Visual Studio Code version 1.43.1 on Mac OSX. The issue occurs somewhat randomly, so I have not tried turning off extensions to see if the issue still occurs.

I am getting the EXACT same issue with duplicated files and with 2 (and sometimes a 3 at the end). I noticed the issue when I was on version 1.40.2 and I updated it today on 1.43.2 and the same happened. Random amounts of files get duplicated when I open the Visual Studio Code or if my Mac goes to sleep mode or stand by. Please help me with this!


Can I have multiple editor instances?

So, right now, I'm trying to have multiple notes. I'm also trying to set the initialContent to the saved content in the database. But the editor only seems to be working in one note.
It does work if I pass in a custom DEV_SERVER_URL with that note id, but I'm afraid this is going to cause some memory and scalability issues. Is there a better way of doing this?

I do have it working when showing multiple editor instances. I am using the advanced setup so I do have some extra Tiptap plugins installed.
On 12-06-2024, at 14:23, Adnan @.***> wrote:

So, right now, I'm trying to have multiple notes. I'm also trying to set the initialContent to the saved content in the database. But the editor only seems to be working in one note.
It does work if I pass in a custom DEV_SERVER_URL with that note id, but I'm afraid this is going to cause some memory and scalability issues. Is there a better way of doing this?
—
Reply to this email directly, view it on GitHubhttps://github.com/10play/10tap-editor/issues/133, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AD4CJQRQO2KTXCDTIQNVDTDZHCGYLAVCNFSM6AAAAABJG4J2UCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGM2DSNBTGMZDSOI.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

Hey, TenTap should work with many editor instances, you do need a new editor instance for each editor (useEditor)
DEV_SERVER_URL should only be used when developing with the advanced setup.
If no content is being displayed something must have failed inside the web-view could you should us the error? This is how you can inspect web-view logs:
https://github.com/react-native-webview/react-native-webview/blob/master/docs/Debugging.md#debugging-webview-contents

This is the error I get

This is the error I get

This error should be fixed on the latest version. What version are you on, could you try updating?

Closing for now, lmk if it persists

Still the same problem, experiencing it quite frequently. I'm using the latest version.
Here's the package.json file
{   "name": "editor-test",   "version": "0.0.1",   "private": true,   "scripts": {     "android": "react-native run-android",     "ios": "react-native run-ios",     "lint": "eslint .",     "start": "react-native start",     "test": "jest"   },   "dependencies": {     "@10play/tentap-editor": "^0.5.3",     "@expo/vector-icons": "^14.0.2",     "@react-native-async-storage/async-storage": "^1.23.1",     "@react-native-voice/voice": "^3.2.4",     "@react-navigation/bottom-tabs": "^6.5.20",     "@react-navigation/native": "^6.1.17",     "@react-navigation/stack": "^6.3.29",     "@types/react-native-vector-icons": "^6.4.18",     "axios": "^1.7.2",     "lodash": "^4.17.21",     "moment": "^2.30.1",     "react": "^18.2.0",     "react-native": "0.74.1",     "react-native-gesture-handler": "^2.16.2",     "react-native-modal": "^13.0.1",     "react-native-reanimated": "^3.12.0",     "react-native-safe-area-context": "^4.10.4",     "react-native-screens": "^3.31.1",     "react-native-swipe-list": "^0.0.2",     "react-native-vector-icons": "^10.1.0",     "react-native-webview": "^13.10.2"   },   "devDependencies": {     "@babel/core": "^7.20.0",     "@babel/preset-env": "^7.20.0",     "@babel/runtime": "^7.20.0",     "@react-native/babel-preset": "0.74.83",     "@react-native/eslint-config": "0.74.83",     "@react-native/metro-config": "0.74.83",     "@react-native/typescript-config": "0.74.83",     "@types/react": "^18.2.6",     "@types/react-test-renderer": "^18.0.0",     "babel-jest": "^29.6.3",     "eslint": "^8.19.0",     "jest": "^29.6.3",     "prettier": "2.8.8",     "react-test-renderer": "18.2.0",     "tailwindcss": "^3.3.2",     "typescript": "5.0.4"   },   "engines": {     "node": ">=18"   } }

Could you provide a minimal reproducible example?

We can see this on very old android devices @adn0n can you verify iOS is working for you?
I see:
Scheme is missing its top node type ('doc')

Might be related to
https://github.com/react-native-webview/react-native-webview/issues/1609

 This is the error I get

I'm getting this exact error. I have a FlatList that renders a component that eventually renders a RichText component. I don't have multiple RichText in a single component but I noticed that only on Android some of the RichText rendered in the list throw this error. I have the very basic implementation of the RichText from here
I'm testing on a Pixel 8 Pro running latest Android version.

I've found a way to reproduce this consistently.
It happens on some androids - I am using Pixel 5 API 32 Android 12L Emulator, and it only happens when reopening the app, and mounting the editor for the first time, will work on a fix

I've found a way to reproduce this consistently. It happens on some androids - I am using Pixel 5 API 32 Android 12L Emulator, and it only happens when reopening the app, and mounting the editor for the first time, will work on a fix

In case it can by any helpful, I found this thread where an alternative prop is being exposed, I'm going to patch locally and see if I have better results

Should be fixed on 0.5.11 - let us know if this solves the case for you - if you are using the advanced setup you will need to update you index.ts https://10play.github.io/10tap-editor/docs/setup/advancedSetup#step-4---add-indexhtml-advancededitortsx-and-indextsx

Working fine now, thank you!


feat: A second GlobalTag

Tell us about your concept
A second GlobalTag, which is smaller than the main GlobalTag, is below the normal GlobalTag, but is only available to promoters, partners and team members.
This would be another reason why GlobalTags should be supported (:

Maybe we will think about something like that in the future when we grow bigger but right now I don't really see the point of allowing players to set a second tag. Also it's would bloat the player tags a bit in my opinion.


Fancy Zones for Virtual Desktops / Workspaces

Description of the new feature / enhancement
Please add the ability to have different Fancy Zones for each virtual desktop.
Scenario when this would be used?
Developers use virtual desktops to isolate different workspaces such as coding, communication, server management, entertainment etc. It would be great to have Fancy Zones support layouts of each of these spaces. As it stands now, the zones are only changeable per monitor.
Supporting information
No response

This is already possible if it is not working please add your bugreport to #20222
/dup


Fix/force

Closes #42

Codecov Report

Merging #47 into master will not change coverage by %.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #47   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            3         3
  Lines          182       184    +2
=========================================
+ Hits           182       184    +2

Impacted Files
Coverage Δ

peridynamics/model.py
100.00% <100.00%> (ø)

peridynamics/integrators.py
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ff750a...fdc25fa. Read the comment docs.


xiwi: code-insiders: not found

@headmelted  Thank you for all the work you've done thus far....  I wanted to share my issue.
Entering /mnt/stateful_partition/crouton/chroots/code-oss-chroot...
xiwi: code-insiders: not found
Unmounting /mnt/stateful_partition/crouton/chroots/code-oss-chroot...
Sending SIGTERM to processes under /mnt/stateful_partition/crouton/chroots/code-oss-chroot...

Any help would be greatly appreciated,
Eric Faris

I have found the issue to be missing architecture types within the chromebook.sh.  I have an ASUS C302C that has an ARCH of "x86_64".  This ARCH type is not in the script, thus pointing me to the code-insiders folder, instead of code-oss.  I cleared the "code" alias and repointed the alias to "code-oss".  Everything works as expected now!


Update and rename README.rst to README.md

I changed the rst file to md and made some changes to Readme

Arranged them in a specific order
Hided all the links with appropriate words 3.Added a banner ( I found it on the internet ) its not the official banner

Thank you !

Thanks for this patch, however we don't want to change format of the README file.


Issue getting first proof of concept running

Hey there,
Running though the book as my new gig is running terraform but i seem to be running into an issue with the initial busybox webserver,
its not a huge deal as i get what its meant to do, but figured id mention it as its the first example that may deter devs that have a less exp from going further thinking they may have done something wrong
attached is what i came up with incase its something silly on my part
provider "aws" {
  region = "us-east-2"
}

resource "aws_instance" "example1" {
  ami           = "ami-0c55b159cbfafe1f0"
  instance_type = "t2.micro"

  tags = {
    Name = "example1"
  }

  vpc_security_group_ids = [aws_security_group.example1_instance.id]
  key_name               = "phyzical-ssh-key"
  user_data              = <<-EOF
                            #!/bin/bash
                            echo "Hello, World" > index.html
                            nohup busybox http -f -p 8080 &
                            EOF
}

resource "aws_security_group" "example1_instance" {
  name = "example1-instance"

  ingress {
    from_port   = 8080
    to_port     = 8080
    protocol    = "tcp"
    cidr_blocks = ["<IP_ADDRESS>/0"]
  }

  ingress {
    from_port   = 22
    to_port     = 22
    protocol    = "tcp"
    cidr_blocks = ["<IP_ADDRESS>/32"]
  }
}

resource "aws_key_pair" "phyzical-ssh-key" {
  key_name   = "phyzical-ssh-key"
  public_key = file("~/.ssh/id_rsa.pub")
}

output "instance_ip" {
  description = "The public ip for ssh access"
  value       = aws_instance.example1.public_ip
}

if i jump on the server that is initialized and try to manually start busybox i get the following;
sudo busybox http -f -p 8080

http: applet not found

my google fu suggests its PATH issues/ compile issues with the image itself. but i could not succeed and have decided just progress further on in the book

lol.. nvm sorry. its httpd not http


Updating Mapping

Hey looks good to me, double checking that you want to use ReceiptType.Receipt and not ReceiptType.Original?

Thank you gchatz22. I would like to use "ReceiptType.Original" instead

Feel free to change it with another commit


[1.16.3] dupe bug/deletion bug

woodenutilities-1.0.4-1.16.3
forge-35.0.7
DUPE

have items in bag
open bag gui
remove items
move bag to a different slot in your inventory
close bag gui
open bag gui to see all the original items still there

DELETE

have nothing in bag
open bag gui
add items in
move bag to a different slot in inventory
close bag gui
notice all your stuffs is gone :cry:

Hmm. So, when the bag is moved from one slot to another the data freaks out... Working on it :+1:

35.0.7 is 1.16.4, on 34.1.x the bug don't exist, or I can't reproduce it.

oops sorry lol yea MC 1.16.4

Hello,
some additional informations about the backpack:

shift clicking items in the backpack work only for the filled slots in the picture below:

sometimes I can shift click items from the hotbar in the backpack and sometimes not

I didn't wanted to open a new issue, because this is related to the backpack, I hope it is okay. :D
Forge: 35.0.14
WU: 1.0.5
MC: 1.16.4

Yeah @TheSnowyChickens no worries, We will look at and get it fixed soon

@TheSnowyChickens your bug is fixed.
@MasterSloth1 your bug is fixed too.
You both let me know if something isn't working correctly pls.

Nice, ty. 👍

Okay, found something new: @lazynessmind

new backpack picked from the creative menu
-> I have the backpack in the first slot
-> I open the backpack
-> I close the backpack
-> I open the backpack
-> aaaannnnd it's gone

I can't right click him again (with inventory closed), I need to reconnect or right click the slot first.

In vanilla, you can take a item and shift - double click with it on other items, so put them all (same item type) in the next inventory.
-> I can't do that with your backpack, not in and not out of the backpack

Thanks for letting me know


Remove client-params example

3.0.0 seems to have dropped support for this.
User-Agent can now be passed via headers, see https://github.com/cburgmer/buildviz/commit/d6f5c81f666384e8fef0515a6912e68d3783f78a

Merged, thanks!


wrong acceleration speed compute

In current pixi-particles , the code about acceleration speed is like this:
this.velocity += this.acceleration * deltaTime;

this.position = this.velocity * deltaTime;

It's wrong.
The right way is :
var newVelocity = this.velocity +  this.acceleration * deltaTime;

this.position = ( newVelocity + this.velocity) / 2 * deltaTime;

this.velocity = newVelocity;

x is  delta position (displacement),
t is delta time.
V0 is old velocity,
Vt is  new velocity.

While that is a more accurate way of calculating positional changes, it would complicate the code a little (and potentially slow it down by adding more if/elses) as we don't always have acceleration. I think that the current method is close enough, unless deltaTime is extremely large, which would be bad in its own right.

There is no more if/elses.
		//handle movement
		if(this._doNormalMovement)
		{
			let deltaX;
			let deltaY;

			//interpolate speed
			if (this._doSpeed)
			{
				let speed = this.speedList.interpolate(lerp) * this.speedMultiplier;
				ParticleUtils.normalize(this.velocity);
				ParticleUtils.scaleBy(this.velocity, speed);

				deltaX = this.velocity.x * delta;
				deltaY = this.velocity.y * delta;
			}
			else if(this._doAcceleration)
			{
				const oldVX = this.velocity.x;
				const oldVY = this.velocity.y;

				this.velocity.x += this.acceleration.x * delta;
				this.velocity.y += this.acceleration.y * delta;

				if (this.maxSpeed)
				{
					let currentSpeed = ParticleUtils.length(this.velocity);
					//if we are going faster than we should, clamp at the max speed
					//DO NOT recalculate vector length
					if (currentSpeed > this.maxSpeed)
					{
						ParticleUtils.scaleBy(this.velocity, this.maxSpeed / currentSpeed);
					}
				}

				deltaX = (oldVX + this.velocity.x) / 2 * delta;
				deltaY = (oldVY + this.velocity.y) / 2 * delta;
			}
			else
			{
				deltaX = this.velocity.x * delta;
				deltaY = this.velocity.y * delta;
			}

			//adjust position based on velocity
			this.position.x += deltaX;
			this.position.y += deltaY;
		}

It just does  more + & / & =  :
				deltaX = (oldVX + this.velocity.x) / 2 * delta;
				deltaY = (oldVY + this.velocity.y) / 2 * delta;

you said "unless deltaTime is extremely large"
In fact , many game use 30fps , the timeStep(deltaTime) === 33ms.
it's already so big for some fast particles.


Created and updated timestamps for pastes and files

Possible to use git for this, but at what performance cost? Investigate.

[x] Created
[ ] Updated

Created timestamps added in https://github.com/jkcclemens/paste/commit/04c318ab5d4c622d49ae41ec7a13495290746ca0.

Current implementation of updated timestamps is solely based on HEAD in the repository.
I think that an updated_at column should be added to each paste in the database, and it should be set whenever the row is modified (metadata is stored only in the database).
Then, when the updated date is request, the column and the repository can be checked, returning whichever is newer.


Videos won't load

I use a simple config file with bind-to and a secret.
Texts and images work well, but videos don't.

Update: videos work on Abdroid and Telegram Desktop. This must be a bug in the iOS app.

I've also met with this bug and tried to fix it at least 3-4 times with different fixes. It seems yeah, something wrong there.

Did you have this problem in iOS? >For me it only occurs in iOS.

Yes, I also use iOS and have absolutely the same behavior


[DevTools / JS / Get Started / (3) Paused On Correct Line]

16th line

Hi @RamPrasath77 I need more information about the issue you're seeing. If you want to give more, I am happy to help.


Can not find the codes for composite structure

Hey, nice work!
Now I have some trouble understanding your codes. I have read all your modifications and didn't find the codes for composite structure which connects 2 similar backbones. TBH, I am not very familiar with Caffe or Caffe2, so this may be my own issue.
Could you point out the file I need to read for it?
Thanks ahead for your time.

Hell,the modification can be finded in detectron/model/fpn.py and Resnet.py发自我的iPhone------------------ Original ------------------From: Yamin05114<EMAIL_ADDRESS>Wed,Feb 5,2020 5:52 PMTo: PKUbahuangliuhe/CBNet<EMAIL_ADDRESS>Subscribed<EMAIL_ADDRESS>Re: [PKUbahuangliuhe/CBNet] Can not find the codes for compositestructure (#18)Hey, nice work!
Now I have some trouble understanding your codes. I have read all your modifications and didn't find the codes for composite structure which connects 2 similar backbones. TBH, I am not very familiar with Caffe or Caffe2, so this may be my own issue.
Could you point out the file I need to read for it?
Thanks ahead for your time.
—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or unsubscribe.
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/PKUbahuangliuhe/CBNet/issues/18?email_source=notifications\u0026email_token=ANEFSZSNQ4VYHCWUO7X2X63RBKD7JA5CNFSM4KQH7JF2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ILE27OA",
"url": "https://github.com/PKUbahuangliuhe/CBNet/issues/18?email_source=notifications\u0026email_token=ANEFSZSNQ4VYHCWUO7X2X63RBKD7JA5CNFSM4KQH7JF2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ILE27OA",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]


Workflow / event pods block scale down

Checklist

[X] Double-checked my configuration.
[x] Tested using the latest version.
[X] Used the Emissary executor.

 Both workflow and event pods block the cluster scale down due to Pod is blocking scale down because it has local storage and Pod is blocking scale down because it's not backed by a controller in GKE:

What is the best practice here? Both these warning suggest adding a safe-to-evict annotation - is this safe to add?
Worth noting that both CPU and memory utilisation are low:

Additionally, we've implemented pod disruption budgets to reduce the chance of voluntary disruption of workflow pods. In the meantime are investigating internally if this could be one factor blocking the scale down after a surge.
Diagnostics
This can be reproduced by kicking off +100 workflows that sleep for 1000+ seconds.
We see ~13k logs / hour on local storage scale down issues:

And ~100 logs / hour on the no controller scale down issue:

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

It looks like more related to the GKE issue.

+1 to @sarabala1979. Does not seem like an Argo issue. Please re-open if you have more info.

Hello, no one answered his question though, GKE needs pods to be managed by something deployment, statefulset etc or else use the safe-to-evict annotation. Is this argo orchestrator pod safe to evict ?

Is this argo "orchestrator" pod safe to evict ?

Yes, the Controller is designed to be resilient to restarts as it stores all state in its managed CRs. Intermediate state, such as Pod changes, may be missed during downtime however. See also the "High Availability" documentation


[ci skip] adding user @thewchan

Hi! This is the friendly automated conda-forge-webservice.
I've added user @thewchan as instructed in #9.
Merge this PR to add the user. Please do not rerender this PR or change it in any way. It has [ci skip] in the commit message to avoid pushing a new build and so the build configuration in the feedstock should not be changed.
Please contact conda-forge/core to have this PR merged, if the maintainer is unresponsive.
Fixes #9

@conda-forge/core merge request, thanks!


[UseSelection] fails on nullable relationship

Describe the bug
[UseSelection] compiles a query to an anonymous type, which breaks nullable optional relationships in EF Core.
To Reproduce
Model:
public class Foo
{
  public long Id { get; set; }
  public Bar? Bar { get; set; } //Bar is optional
}

public class Bar
{
  public long Id { get; set; }
  public string Name { get; set; } = default!; //Name is required
}

Query:
query
{
  foos
  {
     id,
     bar
     {
       id,
       name
     }
  }
}

Result:
"errors": [
    {
      "message": "Cannot return null for non-nullable field.",
      "locations": [
        {
          "line": 7,
          "column": 9
        }
      ],
      "path": [
        "foos",
        0,
        "bar",
        "name"
      ],
      "extensions": {
        "code": "EXEC_NON_NULL_VIOLATION"
      }
    }
  ]

Expected behavior
"data": {
    "workOrders": [
        {
          "id": 6,
          "requester": null
        },
        {
          "id": 5,
          "requester": {
            "id": 1,
            "name": "Sam"
          }
        },
        {
          "id": 4,
          "requester": {
            "id": 2,
            "name": "John"
          }
        }
      ]
    }

Problem
The query is compiled to the equivalent of:
context.Foos.Select(f => new
  {
      Id = f.Id,
      Bar = new { f.Bar.Id, f.Bar.Name }
  });

Because the selection is anonymous, EF has no idea that Bar should be null, and the result violates the GraphQL schema.
Solution
EF allows for null checks in the selection, which should mitigate the issue
context.Foos.Select(f => new
  {
      Id = f.Id,
      Bar = f.Bar == null ? null : new { f.Bar.Id, f.Bar.Name }
  });

HC Version: 11.0.0-preview.118
EF Core: 3.1.3

Hi @DorianGreen
Thank you for opening this issue.
I am surprised that EF translates this like this.
We are not creating anonymous types though
It is
context.Foos.Select(f => new
  {
      Id = f.Id,
      Bar = new Bar() { Id = f.Bar.Id, Name = f.Bar.Name }
  });

I will look into this :+1:

@PascalSenn , Thanks for the clarification.
The issue is, that EF will issue a left join from Foo to Bar, resulting in Id = 0 and Name = null.
In the current selection, a new Bar will be created even if it should be null.
The added null check will translate to a isnull(f.BarId) selection.

I have found a workaround for this issue.
I have updated Foo to:
public class Foo
{
  private Bar? _bar;

  public long Id { get; set; }
  public Bar? Bar
    {
       get => _bar == null ? null : _bar.Id == 0 ? null : _bar;
       set => _bar = value;
    }
}

This is really a hack around how EF Core handles nested selections and not a HC specific issue.
It would still be nice if the SelectionVisitor could insert a null check like the query I showed above, but it may not work with other IQueriable providers.
You can close this issue if it is not something you'd want to tackle in HC.

@PascalSenn I have ran into an issue with my workaround.
It will only work if the field selection contains bar.Id

@DorianGreen  didn't have time to look into this properly the past few days. Will do this weekend :+1: I think this is a fix we can provide

Fixed in V11 and V10


API bugfix

This fixes the issues seen in test.
The curl to test that the Master API is up now does not need to see an OK, but checks for a zero exit code.

I would, but this is specifically to circumvent the problem when the API is up, but a 403 is returned.

I would, but this is specifically to circumvent the issue where the API is up but returns a 403.


Allow weighting when the dependence functions are fit

I'm submitting a ...

[ ] bug report
[x] feature request
[ ] code improvement request

Expected behavior
How should it work (with the bug fixed or the feature implemented)?
Currently the dependence functions are fitted using least squares with python's function curve_fit (https://docs.scipy.org/doc/scipy/reference/generated/scipy.optimize.curve_fit.html). No weighting is used. It might be useful to apply weights that are 1/parameter such that the parameter values are normalized. Otherwise, for example in the shown case (panel b), in % much stronger deviations are accepted for low values than for high values.

This feature has been implemented as part of the work on the paper entitled "Global hierarchical models for wind and wave contours: Physical interpretations of the dependence functions".
In the distribution description data structure a new key is available to use weighting: 'do_use_weights_for_dependence_function': True
A full description of a model fit look like this:
dist_description_hs = {'name': 'Weibull_Exp',
'fixed_parameters': (None, None, None, 5),
# shape, location, scale, shape2
'dependency': (0, None, 0, None),
# shape, location, scale, shape2
'functions': ('logistics4', None, 'alpha3', None),
# shape, location, scale, shape2
'min_datapoints_for_fit': 50,
'do_use_weights_for_dependence_function': True}
Here is a full example: https://github.com/ahaselsteiner/2020-paper-omae-hierarchical-models/blob/master/compute_contours_datasets_def.py
This functionality is available with viroconcom 1.3.9 and higher.


The sentence "Any of these cases trigger [...] restart" is unclear.

In the first item, it says "Any of these cases trigger [...] the source slot to restart." Does it mean that if any one of them exist, then the source slot(s) will be restarted. Does it also mean that conversely, if none of them exist then the source slot(s) would not be restarted? I guess my issue is that I feel like I am having to infer more than I should.
FWIW, what I am trying to do is prevent a restart during a swap since our application happens to be very cache-oriented and needs to warmup prior to taking traffic. I can make the app settings identical if needed to do this, but not 100% sure if this is what the copy is trying to communicate.
Anyway, thanks in advance!
Mike
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: f6e09089-1ae2-8943-5ce2-9d48f458c81f
Version Independent ID: ba780cba-f604-b0a4-a81a-23c7d2384762
Content: Set up staging environments - Azure App Service
Content Source: articles/app-service/deploy-staging-slots.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin

@emu7800
Thanks for your feedback! We will investigate and update as appropriate.


memory fixes

[x] defer loading animation data
[x] eagerly clear payloads in chainAction
[x] defer emojimart
[x] defer phone number
[x] defer requires in icons
[x] dont load all of lodash in reducers/fs
[x] disallow full lodash in webpack build
[x] thin out some data structures that just contained empty data (empty bio/fullname etc)

People page load mem in dev:
Master: 60mb => Pr: 52mb

@keybase/react-hackers bump


iOS cookies

Hi, I am using this plugin(capacitor-community-http) in a framework7 application with capacitorJs and Vuejs. For the API I am using Laravel Sanctum (all this in local host). I am trying to use the cookie authentication which first call the endpoint /sanctum/csrf-cookie, the answer should run the Set-Cookie and store the csrf token as a cookie on the browser. On the web everything works as expected saving the cookies but on IOS for some reason is not saving the cookies so my future requests don’t include the csrf token and can’t access the api.
I have tried to include the domain in the info.plist, adding the webfetch include credentials, changing host name in the config, etc. I have tried a lot so far but can’t get it to work.
Does someone have an example of how they achieve this or have any idea why it might not be working on IOS ?

Hello, I have the same problem with Ionic (Angular, Capacitor).
It works on Android but not on IOS.
Someone has a workaround ?
Thanks

@mikmikmik for the most part I got cookies working with making a few changes to my headers and calling get/set cookie probably more than needed. Can check out my SO post here.
https://stackoverflow.com/questions/72045698/capacitor-ios-using-cookie-based-auth

@billpull thanks I'll have a look. My problem is a bit different it's about the refresh_token cookie.


⚠ Bofrost.de has degraded performance

In 91b8949, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1132 ms

Resolved: Bofrost.de performance has improved in 925cc30 after 13 minutes.


[Android] Provide a PopupMenu component

Currently there is no way to specify an overflow menu icon for Navigator.NavigationBar (or is there?). I can add a custom button, sure, but I cannot find a way to show a menu. Does such a functionality exist?
The Menu component is widely used on Android, and it'll be awesome to have it.

Can you please use Stack Overflow to ask questions and tag them with react-native? http://stackoverflow.com/questions/tagged/react-native
Many people from the community hang out on Stack Overflow and will be able to see your question. Using Stack Overflow for questions also helps us use Github issues to keep track of bugs that need to be fixed.

@mkonicek Hmm... I guess no menu component exists for Android? May be I should change the title. This is more of a feature request than just a question.

@satya164 Do you mean something like the Android Spinner? http://developer.android.com/intl/zh-cn/guide/topics/ui/controls/spinner.html
It's planned for one of the future releases: https://facebook.github.io/react-native/docs/known-issues.html

There's also http://developer.android.com/intl/zh-cn/reference/android/widget/PopupMenu.html

You probably mean this one, right? http://i.stack.imgur.com/j67fB.gif

@mkonicek Yes. I'm talking about the popup menu. I should change my title :)
Adding an overflow icon is not an issue since I can add any custom view. Popup menu is the one. Thanks :)

For now, you can make your own custom button for the navigation bar.
Speaking of the menu, you'd need to build a separate menu or modal dialog separately and use the button as a trigger to open a menu.

@hedgerwang Unfortunately, the Modal component is not yet implemented for Android.
I cannot build a menu either, as everything is overflow: hidden and cannot be changed. Hence there cannot be content larger than the container.

You can make a large container that is transparent and has pointerEvents="box-none" on it, and put a smaller, visible view inside.
Also Modal is intended for hybrid apps. If you are using only React Native, I recommend you use a Navigator w/out NavigationBar.

@ide I'll try it out. I actually need a PopupMenu, not a modal. I'll try to make a native component and send a pull request.

@ide @satya164 Why don't the React Native docs for Modal say "Android is not supported"?  This is frustrating.

@niftylettuce want to send a PR to clarify this in Modal's docblock?

@ide Don't really have time, trying to crank out a project.

When Modal component is worked for android also.Thanks

+1

+1

+1
For anyone looking for a quick replacement, react-native-dialogs is a good solution that plugs into native dialogs.

+1
Some way to force a component to the front of the "stack" would be even more helpful, since it'd apply to more than just the Dialog spec.

@Ehesp Totally agree. We used to have a JS-based solution internally but later realized a native implementation works better in hybrid apps (apps where only parts are built with React Native).
Here is the JS implementation, feel free to try it out: https://gist.github.com/mkonicek/1a8bd7253e3257687228
It hooks into the Portal here: https://github.com/facebook/react-native/blob/master/Libraries/ReactIOS/renderApplication.android.js#L92
I believe we started working on a native implementation of Modals internally. @AaaChiuuu do we use it in any fb app it ready to be open sourced?

Oh man, I don't think anyone currently uses it. In fact, it got broken when we removed BaseViewPropertyApplicator so styles weren't properly applied to the host view. I really, really wish I could get on this to unblock you guys but my hands are all tied with internal integration and it sounds like the London side of our team is getting stretched too. Krzysztof attempted a fix before he left but it seemed pretty hard to him.
If the community could take this on that would be amazing. The gist of the current implementation before the breakage is creating an Android Dialog in the ReactModalHostView extends ViewGroup and attaching a newly defined DismissEvent to the Dialog in the addEventEmitters(...) of ReactModalHostManager extends ViewGroupManager<ReactModalHostView>.

Thanks for the update @AaaChiuuu!
Here's the code, if anyone has bandwidth to ship it that would be awesome!
https://gist.github.com/mkonicek/00453ec3f6c965b93afd
https://gist.github.com/mkonicek/58c7c9824987a54bfc54

Lets get it in!

I'm confused here... How does a Modal differ from the Alert API?

@Ehesp You can render views inside a Modal.

Ah nice. What about the original request here though? If we want a popout menu/spinner coming from the navbar, do we achieve that with positioning a Modal, or is it a separate thing?

@Ehesp I doubt it'll be easy. BTW there is a third party component available for dropdowns - https://www.npmjs.com/package/react-native-dropdown-android , if it serves your purpose

Yeah I've taken a look at that, not very customisable though by the looks of it.
I think the main problem is there seems to be no way to "force to front". Things like FABs, Spinners, Bottom Sheets are possible but are always required to be at the end of the render stack, rather than being able to "pop to top".

Modal DOES work for Android -- you just have to use Portal instead and sniff the Platform.
Check out what I did with https://github.com/niftylettuce/react-native-loading-spinner-overlay - it overlays a spinner (basically a modal) on top of both Android and iOS platforms

@Ehesp There is a way to force to front :+1: see https://github.com/niftylettuce/react-native-loading-spinner-overlay

BTW I'm currently working on making <Modal /> work on Android. Will post soon.

@mkonicek do you have an approximate release date for Android's Spinner component? I'm porting an app to Android and I would like to leverage if I have to drop a custom solution or not.
Or if you need help I could give a hand, although I do not have any Android experience.

@alvaromb I don't think anyone is working on it.

But... it's on the roadmap @satya164 https://facebook.github.io/react-native/docs/known-issues.html

@alvaromb Yeah, it's on the roadmap, so it'll be worked on eventually :)
PR is much welcome. But first let's confirm if this component exists internally, then someone could share the code which will make it easier for you.
cc @mkonicek

@alvaromb Ok, so seems this component existed internally and was just open sourced - 18437093f2664beedd3239bb525d7daa3f2bcdbd

@satya164 +1 that stuff all day long. This should be in 0.18, if it works fine :D

@satya164 How are you getting on with implementing the Android Modal?

@Ehesp PR is here - #5320

Hey @satya164, how it is goin' with PopupMenu?

We have a Picker now, since 0.19.
Haven't put it into a NavigationBar yet, but it looks like that could already work.

@wvengen yup, but how it can be used with the button instead of picker text field (or what it is)?

@terrysahaidak That's a good point. As a somewhat ugly workaround I'm now using a Picker with an opacity of zero and a fixed width, positioning a button on top of it (though not in a NavigationBar). I'd love it to be possible to specify an element for rendering the Picker button, perhaps something for a new issue.

context popupMenu is already exposed on UIManager. I have a small wrapper that adds a vertical hamburger menu and shows the popup on it like the youtube app.
import React from 'react-native';
import Icon from 'react-native-vector-icons/Ionicons';

import styles from './styles';

const {
  View,
  UIManager,
  findNodeHandle,
  TouchableOpacity,
} = React;

const ICON_SIZE = 24;

class PopupMenu extends React.Component {
  handleShowPopupError = () => {
    // show error here
  };

  handleMenuPress = () => {
    const { actions, onPress } = this.props;

    UIManager.showPopupMenu(
      findNodeHandle(this.refs.menu),
      actions,
      this.handleShowPopupError,
      onPress,
    );
  };

  render() {
    return (
      <View>
        { this.props.children }
        <TouchableOpacity onPress={this.handleMenuPress} style={styles.touchableContainer}>
          <Icon
            name="android-more-vertical"
            size={ICON_SIZE}
            color={'grey'}
            ref="menu"
          />
        </TouchableOpacity>
      </View>
    );
  }
}

PopupMenu.propTypes = {
  actions: React.PropTypes.array.isRequired,
  onPress: React.PropTypes.func.isRequired,
  children: React.PropTypes.object.isRequired,
};

export default PopupMenu;

<PopupMenu actions=['1', '2'] onPress={() => { // }}>
      <YourListItem .... />
</PopupMenu>

@chirag04 AWESOME! Thanks a lot!

@mkonicek @satya164 I will let you guys close this.

@chirag04 this should be mentioned in the docs I think.

@terrysahaidak can you PR?

@wvengen  is it possible to invoke the click/tap programmatically for the picker? If so, we could have a zero sized picker, and prompt it by hooking any other events (instead of overlapping views).
Sorry for hunting workaround here, urgently need such an option menu (as an equivalent to actionsheet in iOS), and the picker has all the right attributes I need.

@kkgelu What kind of problem do you have with @chirag04's solution? I use it in react-native-material-ui and it works well.

@xotahal my bad... I rushed to try wvengen's solution. @chirag04 's solution is absolutely brilliant.
If you don't want that wrapper, this is a minimal example you can try:
      UIManager.showPopupMenu(
        findNodeHandle(this.refs.viewOnWhichToPopup),
        ["Option 1", "Option 2"],
        () => console.log("something went wrong with the popup menu"),
        (e, i)=> console.log(e + " : " + i),
      );

Output:
03-30 20:29:56.522  4023  4275 I ReactNativeJS: itemSelected : 0
03-30 20:29:59.085  4023  4275 I ReactNativeJS: itemSelected : 1

It works everywhere!
Last, I'll remember to turn to UIManager for things next time, let's hope the team don't change it.. ^_^

Why the actions argument of UIManager.showPopupMenu() must be array of strings?

thank @chirag04 but It's in UIManagerModule.java of the Android part of React Native, so this will only work on Android.

As @warmhug mentioned, since actions must be an array of strings, styling a menu item appears to be impossible. This makes UIManager.showPopupMenu unusable when you need to indicate which item is active. Furthermore, it seems that the menu can only fly in from the top left and there are no customization options available to change this. @chirag04 any solutions to these issues? For the time being, I am going to try and use Modal.

With the <Picker> element there is no onSelect event, only onChange. Play store uses this PopupMenu for the triple dot menus. I am still looking for a popup menu package, my goal is to use it like this:
const selected = await PopupMenu.show(this.ref.viewToWhichItShouldBeAnchored, { options:... });

Similar to the Alert api - https://facebook.github.io/react-native/docs/alert.html - with the nuance of being able to give it a ref to which view element to anchor to.
Does anyone have such a thing?


Document data products

[x] Document the new Fw/Dp model and classes.
[x] Document the new code generation, including the layout of the containers.

Done in commit 73fb71800d99bfd5b6aaea4f7d048038fa12aacc.


you can't redefine the primary key column 'id'.

Hi,
I'm getting this error when running rake db:migrate. My migration looks like this
class CreateArticles < ActiveRecord::Migration
  def change
    create_table :articles do |t|
      t.uuid :uuid, :primary_key => false
      t.string :title
      t.text :text

      t.timestamps null: false
    end
    add_index :articles, :id
  end
end

and my model class is
require 'activeuuid'

class Article < ActiveRecord::Base
  include ActiveUUID::UUID
end

If i don't set the :id as primary key, the db is migrated correctly but the id is not generated using UUID.
what did I do wrong ?

I forgot to add :id => false in
create_table :articles, :id => false do |t|
...

@JanC question - it's old I know. But what's the reason you initially had an ":id" in the migration? Did you add id:integer? And if so, ist that even necessary to add, or the values already have an id?

to be honest I don't remember what I ended up doing :)


Please consider fixing issues detected by repository checker

Notification from ioBroker Check and Service Bot
Dear adapter developer,
I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter smartthings for common errors and appropiate suggestions to keep this adapter up to date.
This check is based the current head revisions (master / main  branch) of the adapter repository
Please see the result of the check below.
ioBroker.smartthings
   -
ERRORS:

[ ] :heavy_exclamation_mark: [E026] "{'engines': {'node'>='16'}}" is required at package.json, "{'engines':{'node'>='18'}}" is recommended
[ ] :heavy_exclamation_mark: [E157] js-controller 3.0.0 listed as dependency but 4.0.24 is required as minimum, 5.0.19 is recommended. Please update dependency at io-package.json.
[X] :heavy_exclamation_mark: [E951] .npmignore found but "files" is used at package.json. Please remove .npmignore.

WARNINGS:

[ ] :eyes: [W034] @iobroker/adapter-core 3.1.4 specified. 3.1.6 is recommended. Please consider updating dependencies at package.json
[ ] :eyes: [W040] "keywords" within package.json should contain "ioBroker"
[ ] :eyes: [W127] Missing suggested translation into uk of "common.titleLang" in io-package.json.
[ ] :eyes: [W134] Missing suggested translation into uk of "common.desc" in io-package.json.
[ ] :eyes: [W135] "common.tier" is required in io-package.json. Please check https://github.com/ioBroker/ioBroker.docs/blob/master/docs/en/dev/objectsschema.md#adapter.
[ ] :eyes: [W154] Missing suggested translation into ru,pt,nl,fr,it,es,pl,uk,zh-cn of some "common.news" in io-package.json.
[ ] :eyes: [W181] "common.license" in io-package.json is deprecated. Please define object "common.licenseInformation"
[ ] :eyes: [W184] "common.main" is deprecated and ignored. Please remove from io-package.json. Use "main" at package.json instead.
[ ] :eyes: [W184] "common.materialize" is deprecated for admin >= 5 at io-package.json. Please use property "adminUI".
[ ] :eyes: [W184] "common.title" is deprecated and replaced by "common.titleLang". Please remove from io-package.json.
[ ] :eyes: [W951] .npmignore found but "files" is used at package.json. Please remove .npmignore.

SUGGESTIONS:

[ ] :pushpin: [S522] Please consider migrating to admin 5 UI (jsonConfig).

Please review issues reported and consider fixing them as soon as appropiate.
Errors reported by repository checker should be fixed as soon as possible. Some of them require a new release to be considered as fixed. Please note that errors reported by checker might be considered as blocking point for future updates at stable repository.
Warnings reported by repository checker should be reviewed. While some warnings can be ignored due to good reasons or a dedicated decision of the developer, most warnings should be fixed as soon as appropiate.
Suggestions reported by repository checker should be reviewed. Suggestions can be ignored due to a decision of the developer but they are reported as a hint to use a configuration which might get required in future or at least is used be most adapters. Suggestions are always optional to follow.
You may start a new check or force the creation of a new issue at any time by adding the following comment to this issue:
@iobroker-bot recheck
@iobroker-bot recreate
Please note that I (and the server at GitHub) have always plenty of work to do. So it may last up to 30 minutes until you see a reaction. I will drop a comment here as soon as I start processing.
Feel free to contact me (@iobroker-bot) if you have any questions or feel that an issue is incorrectly flagged.
And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.
your
ioBroker Check and Service Bot
@mcm1957 for evidence
Last update at Fri, 13 Sep 2024 04:38:38 GMT based on commit 0921ba9cef4d6b62375f339126457f3429d0448f
ioBroker.repochecker 3.0.4

This issue has been updated by ioBroker Check and Service Bot
The following issues have been fixed
[E951] .npmignore found but "files" is used at package.json. Please remove .npmignore.
:thumbsup:Thanks for fixing the issues.
The following issues are new and have been added
[W951] .npmignore found but "files" is used at package.json. Please remove .npmignore.

This issue has been updated by ioBroker Check and Service Bot
The following issues have been fixed
[W184] "common.main" is deprecated and ignored. Please remove from io-package.json. Use "main" at package.json instead.
:thumbsup:Thanks for fixing the issues.
The following issues are new and have been added
[W184] "common.main" is deprecated and ignored. Please remove from io-package.json. Executable is defined by entry "main" at package.json.

This issue has been updated by ioBroker Check and Service Bot
The following issues have been fixed
[W184] "common.main" is deprecated and ignored. Please remove from io-package.json. Use "main" at package.json instead.
:thumbsup:Thanks for fixing the issues.
The following issues are new and have been added
[W184] "common.main" is deprecated and ignored. Please remove from io-package.json. Executable is defined by entry "main" at package.json.


Menu keyboard focus incorrect when handling menu mnemonics

Describe the bug
The keyboard focus appears to be incorrect when handling menu mnemonics in Avalonia. Instead of keyboard events going to the currently active menu items, the keyboard events seem to be routed to the root menu.
To Reproduce
Steps to reproduce the behavior:
The following fragment creates a menu in Avalonia:
<Menu DockPanel.Dock="Top">
	<MenuItem Header="_File">
		<MenuItem.Items>
			<MenuItem Header="_Open" />
			<MenuItem Header="_Hamburgerize" />
			<MenuItem Header="-" />
			<MenuItem Header="E_xit" />
		</MenuItem.Items>
	</MenuItem>
	<MenuItem Header="_Help">
		<MenuItem.Items>
			<MenuItem Header="_About" />
		</MenuItem.Items>
	</MenuItem>
</Menu>

Note how the top-level _File menu has an F mnemonic, and both the top-level _Help menu and the sub-menu item _Hamburgerize have H mnemonics.

Press Alt-F. The file menu pops up as expected
Press H to select _Hamburgerize

Result:
The _File menu is unexpectedly closed and the  _Help menu is popped up.
Expected behavior
Since the _File menu is active, I expect it to have keyboard focus. The H keystroke should be handled by the submenu, and cause the _Hamburgerize menu item to invoke its associated command. The same problem occurs for both the Alt-F H and Alt-F Alt-H keyboard sequences.
Screenshots
Right after Alt-F is pressed:

Right after H or Alt-H is pressed:

Desktop (please complete the following information):

OS: Windows 10.0.19042
Avalonia Version: since at least 0.10.0

I've attached a sample source project that exhibits the problem:
AvaBug.zip

This is actually kinda complicated to fix with our current access key support, as we have no concept of access key scopes currently. WPF does have them, but the API (and implementation) is pretty hacky so I think we'd be better to go with UWP's access key API.

Having said that, I hate that this issue exists so much that I think I have a hackfix for now.

Is there any progress on this issue?
Or, is there any workaround?


Add simple_lambda_call fixer

#4460

I wonder if this fixer should have a risky option that forces unpacking of arrays where we can't be sure they are not associative?
https://3v4l.org/KYknb

I love assoc arrays... good point :+1:

I love assoc arrays... good point +1

Maybe prepend a ...array_values() ?
https://3v4l.org/WUcFR

Another case to be careful converting:
call_user_func($foo, $foo = 'bar');

If you expand this, the order of evaluation changes...

I note this example because it occurs in a real codebase: laravel/framework!

Ha, nicely spotted !


DACT-1052 Fixing stop screen appearing after authentication

https://companieshouse.atlassian.net/browse/DACT-1052

Would it be possible to write a test class for this middleware?


linux: simplify uv_uptime()

Drop support for old kernels. Assume support for CLOCK_BOOTTIME.

This tripped me whilst trying to install on rhel7.9. Is there any chance CLOCK_BOOTTIME can be added back?

It's always using CLOCK_BOOTTIME now but I think you're asking if the conditional can be put back? No, there's no reason, it's been around since linux 2.6.39. Like I said in the other pull request, you probably need to straighten out your build environment.


More tests

A list of tests I'd like to add:

[ ] huak lint ops tests
[ ] huak test ops tests

Ha. dup. #42


Fix include order for cpplint

Relates to https://github.com/ament/ament_lint/pull/324

Looks like using double-quotes (1d0820f) satisfies both old and new versions of cpplint , so I don't think we need to branch.


[Issue]: Holy branch wrong error message on secondary ability cooldown

Info
In the current versions (v1.0.0 and v1.1.0), the LVL you need for this ability is LVL 50 but in the next update it will be already available at LVL 20 and the ultimate ability at LVL 80 instead of LVL 100!
To Reproduce
If you are over LVL 20/80 and use the secondary/ultimate ability of the holy branch and activate it again when it is on cooldown, it says "Secondary/Ultimate Ability available at LVL 20/80"
Expected behavior
If the item is on cooldown it should normally say that it is on cooldown and not that it isnt available at this LVL.
Additional context
This will be fixed in the next update. :D

I just saw that this situation as described in "To Reproduce" is actually more complicated if you are on LVL 80. It works for the sec ability but not the ult ability.

Okay i was dumb i made a mistake when i set the new LVL restriction for the new update


Add documentation about missioncontrol

Please add documentation about app so that its easy to understand all features of your app so that developer can do task easy.

Yes, @gitshbhts how will i get content for the documentation

Hi I would like to ask if this issue is still open to take up?

Greets, is this issue still open?

Can I work on this?

can i work on this ?


[hint needed] Node-Red on readonly-system

Hi,
I recently migrated my Node-Red setup to a standard raspberry-pi, from [https://github.com/rdmtc/RedMatic]. My "special" use-case is the challenge that in a normal situation I would like to run the Pi read-only to protect the SD card.
So I have to change/update my flows from time to time, which of course requires write access to save the changes (what a surprise :) ). Can you give me a hint / step in the right direction as to whether this can be implemented in any way in Node-Red or where I should look for this? Not to mention the fact that using context-storage will also need consideration.
As an example: For system updates via APT, I found the possibility to add the appropriate remount commands to the APT-Update-Script so that the updates can be installed (simplified: pre: remount RW, post: remount RO).
Would this approach be an idea to add this option to the Node-Red scripts as well, or is the checkin of changes in the flows mapped somewhere in a binary which cannot be manipulated?
Of course I also thought of moving the node-red-directory to a mounted USB-storage, but I am currently looking for alternatives.
Thank you & best regards
Julius

Hi @jhaake2308 - as our issue templates point out, we prefer general how-to type questions/discussions to happen over on the forum - discourse.nodered.org. There is a much larger user-community over there who can help with this type of question, rather than rely on the small group who manage the issues on the core repo.

Hi @jhaake2308 please take your question to https://discourse.nodered.org/
Please note, the guys on the forum are super helpful but since this is probably more of a OS / File System type question their may not be too many answers.

sorry for botherin you,.. :) my thought concerning asking the question here was due to the specific issue of checking in changes in the flows which for me is the core-thing of NR. So no offence, will go to the forum :). BR Julius