deps: replace msgpack-lite with msgpackr

Problem

msgpack-lite is not active since 2016.

It also may be slow: https://github.com/neovim/node-client/issues/78

msgpackr claims to be fast: https://www.npmjs.com/package/msgpackr

Solution
If replacing msgpack-lite with msgpackr is low effort, could be worth doing.

I think it's only a dev dependency? We just directly call into node-client for communication. Not sure why it's a dev dep tho.

Oops I missed that. Ok, this is low priority then. Though maybe we could eliminate that dep as you said.


Update stories test

Fix test class title
Add new test for single story

Fix test class title
Add new test for single story

@Anmolbansal1 Codacy issues :p

@wdevon99 check now :+1:


Are there any plans to support visjs timeline methods?

http://visjs.org/docs/timeline/#Methods
The component currently does not pass a ref for me to call these methods on.

Is it possible to call setWindow , on the timeline ?

@allenylzhou We do support the main methods setOptions, setItems, setSelection etc, but it's in a react declarative style - via prop config. The whole purpose of this module is to abstract away visjs timeline into a more declarative pattern. We don't support all methods currently, but happy to take suggestions and PRs to support more.
@Ezekiah If you pass start/end props along with animate, the component will use setWindow to apply those values

Is this possible to use Zoom in and zoom out methods ?


Versions patch

Description
This overlays on my previous one and fixes layout issues on the install page. Must merge my other layout PR too. #9718
Checklist
Essentials

[ ] Passed code style checking (make lint)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[ ] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
[ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

Could you separate your changes between this PR and #9718?


05A Write All OD Pairs with Geodesic Distance

What are the "X field in ZCTA file" and "Y field in ZCTA file" used for? Are they used to calculate the geodesic distance?
and what should I input for the "OD pair field name in the table"?

"Are they used to calculate the geodesic distance?"
Yes. They are used for geodesic distance.
"The intra-zonal travel cost matrix should be appended to merge all OD matrices at three levels."
The data itself is too special. It requires other datasets to calculate compares to all other pairs. If you really want we can append it to the bottom of the file. And it will be kinda hard to locate,


Obsolete nucleic acid-templated transcription

nucleic acid-templated transcription is an unnecessary grouping class, it only has 2 children, 'DNA-templated transcription' and
'RNA-templated transcription', these would be fine direct children of 'RNA bioynthetic process' and keep 'part of' some 'gene expression' from the parent.
Thanks, Pascale

Out of ignorance, are there any non-templated forms of RNA synthesis that are biologically important? If there were, then a grouping class to distinguish them from the templated ones might be useful.

Poly-A tails?

We are not proposing to obsolete 'RNA biosynthetic process'  (GO:0032774) - just the its child, the grouping term  'nucleic acid-templated transcription'

Right. The question is whether we gain something by keeping children of 'RNA biosynthetic process' (GO:0032774) as grouping terms to distinguish, e.g., templated from non-templated RNA biosynthesis.

@pgaudet
Hi, just for the records, this is the thread that lead to the creation of GO:0097659 nucleic acid-templated transcription:
https://github.com/geneontology/go-ontology/issues/11369
See you soon,
Paola


remove '[>' '<]' in uncommented lines

Fix issue #170
The bug was first introduced in commit f98f73221cfc4068757d51630eb6471e9bbc0765.
Since $line may be updated in case 1 or case 2 (see the code), hence $indxLeft, $indxLeftAlt, $indxRight, $indxRightAlt must be updated after the if block.

Hey @knight42 thanks for the contribution. I've recently been added as a maintainer to this project and would like to get this issue resolved. Unfortunately this patch has merge conflicts and doesn't work in it's current format. Most of the file types you added are duplicates of previous PR's that have now been merged. Besides those which I could easily resolve, there are also some issue with the main code now that a bunch of other PR's have been merged.
Any chance I could get you to take a look at this, rebase it and master, and fix it up for merging?

@alerque It seems that this problem has been solved in the latest nerdcommenter and I'd like to close this PR.

Thanks for coming round to review @knight42, but please see my comment on #170. I'm not sure we've licked this quite yet.


moved Github Icon

Appreciate the chance to do this :)

Sorry the issue has already been assigned
You could try the other issues or suggest an issue


Use clamping on color scales

Color scales use d3-scale under the hood, and can allow interpolation out of specified color endpoints. These should use the clamp option to prevent these color overflows.

Correction: clamping is used, but not for safe log scale generation (i.e., avoidance of 0)


[QUERY] How to use the OpenTelemetry AzureMonitorLogExporter

Library name and version
Azure.Monitor.OpenTelemetry.Exporter
Query/Question
How can I use the .AddAzureMonitorLogExporter() extension method when it's private and does not get referenced anywhere in the library? see https://github.com/Azure/azure-sdk-for-net/blob/Azure.Monitor.OpenTelemetry.Exporter_1.0.0-beta.3/sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/AzureMonitorExporterLoggingExtensions.cs
Alternatively, I would register the AzureMonitorLogExporter myself but also that is private and not referenced anywhere it the library with a meaningful way to access it. https://github.com/Azure/azure-sdk-for-net/blob/Azure.Monitor.OpenTelemetry.Exporter_1.0.0-beta.3/sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/AzureMonitorLogExporter.cs
Is there a way to export the logs to Application Insights with OpenTelemetry?
Environment
No response

@RakeshMohanMSFT I have found that when you use Application Insights with the OperationCorrelationTelemetryInitializer the logs that are logged with ILogger and the traces collected with the AzureMonitorTraceExporter end up in the same End-to-end transaction due to the same Operation ID.
This workaround however still does not use the AzureMonitorLogExporter. Thanks for looking into it.

serviceCollection.AddLogging(builder => builder.AddApplicationInsights(instrumentationKey, a =>
                {
                    a.TrackExceptionsAsExceptionTelemetry = true;
                }));

serviceCollection.Configure<TelemetryConfiguration>(config => config.TelemetryInitializers.Add(new OperationCorrelationTelemetryInitializer()));

serviceCollection.Configure<TracerProviderBuilder>(t =>
             {
                 t.AddAzureMonitorTraceExporter(o =>
                 {
                     o.Diagnostics.IsLoggingEnabled = true;
                     o.ConnectionString = connectionString;
                 });
             });


Various gradle files updates

Changes:

Updated Gradle from 6.4.1 to 6.5.1
Updated shadow from 5.1.0 to 6.0.0
Updated proguard from 6.1.1 to 7.0.0
Changed 'compile' configuration with proper 'implementation' and 'api' configurations

thank you!

Glad to help! ☺

Also as I opened this PR Gradle 6.6 was released 😅


have the CVO manage CRDs from the api image

/hold
must merge together with https://github.com/openshift/cluster-config-operator/pull/379
While the vendored level in cluster-config-operator matches, these can show green simultaneously.  When that happens, we need to manually merge both to avoid future conflicts.

launch openshift/cluster-config-operator#379,openshift/api#1666 worked

https://github.com/openshift/installer/pull/7666 switching the installer rendering to use openshift/api has tested green and is ready to make the switch
https://github.com/openshift/api/pull/1666 and https://github.com/openshift/cluster-config-operator/pull/379 have clusterbot tested together fine. They hand off the CVO management of CRDs (and others) from cluster-config-operator to api image.
https://github.com/openshift/cluster-config-operator/pull/349 switches the featuregate setting from using the vendored copy from to using openshift/api.  It tested green until it openshift/api updated without a (yet) merged openshift/cluster-config-operator update, so the machine-config-operator mismatched until they rematch. But in combination with the rendering change linked above they will match ok.
Manually merging to get a batch.


update message pointer class to PayloadS3Pointer

Versions > 1.1.0 of  Java SQS extended client uses PayloadS3Pointer class instead of MessageS3Class
https://github.com/awslabs/amazon-sqs-java-extended-client-lib/issues/13

Thanks @rishi-dhar! I'll cut a new release tomorrow

@rishi-dhar I'm going to have to make some more modifications to support this. Specifically, I will have to allow users to set the version of the amazon-sqs-java-extended-client to conform to. I'll default it to the new version, but if I don't allow for using the old version then this update may break some folks. Additionally, without the setting a central process handling multiple queues would not be able to deal with a mix of clients on the other side (especially if the user doesn't have control over the other side clients).
I'm going to reject this PR tomorrow and do this in the main branch instead of asking you to make all of the changes required...


Fix #247 - unneeded symfony/yaml dependency

Do you have composer V1? You can fetch it and install using the following

php -r "copy('https://getcomposer.org/installer', 'composer-setup.php');"

php -r "if (hash_file('sha384', 'composer-setup.php') === '756890a4488ce9024fc62c56153228907f1545c228516cbf63f885e036d37e9a59d27d63f46af1d4d07ee0f76181c7d3') { echo 'Installer verified'; } else { echo 'Installer corrupt'; unlink('composer-setup.php'); } echo PHP_EOL;"

php composer-setup.php --version=1.10.20 --filename=composer-v1

php -r "unlink('composer-setup.php');"

Then you can update with php composer-v1 update

I ended up just editing the composer.lock API version back to what it was before so it doesn't break your processes, after verifying that the only change of substance to the .lock file was moving yaml and ctypes from packages to packages-dev.


Make hints less obtrusive

Move hints below the canvas?
Also, clickable buttons to trigger the commands that make sense? Eg zoom to fit via button or double click, but not something like panning via button click which doesn't make sense.

Reopened as #22 and #23


Document why setup-pixi is so slow when uploading cache

Looks like this is actually a bug https://github.com/actions/toolkit/issues/1578

Awesome 🚀


[Event Change] Report 20 "Calc. and Post VAT Settlement" - OnCloseVATEntriesOnAfterPostGenJnlLineReverseChargeVATSales

Hey
currently there is no way to reflect the changes from custom code on the report itself using the event OnCloseVATEntriesOnAfterPostGenJnlLineReverseChargeVATSales
can you please add GenJnlLine2 to the event OnCloseVATEntriesOnAfterPostGenJnlLineReverseChargeVATSales, also change GenJnlLine to be passed as reference?
Old:
[IntegrationEvent(false, false)]
    local procedure OnCloseVATEntriesOnAfterPostGenJnlLineReverseChargeVATSales(var VATEntry: Record "VAT Entry"; GenJnlLine: Record "Gen. Journal Line"; var GenJnlPostLine: Codeunit "Gen. Jnl.-Post Line"; VATPostingSetup: Record "VAT Posting Setup"; PostSettlement: Boolean; var ReversingEntry: Boolean; DocNo: Code[20]; PostingDate: Date)
    begin
    end;

New:
    [IntegrationEvent(false, false)]
    local procedure OnCloseVATEntriesOnAfterPostGenJnlLineReverseChargeVATSales(var VATEntry: Record "VAT Entry"; var GenJnlLine: Record "Gen. Journal Line"; var GenJnlLine2: Record "Gen. Journal Line"; var GenJnlPostLine: Codeunit "Gen. Jnl.-Post Line"; VATPostingSetup: Record "VAT Posting Setup"; PostSettlement: Boolean; var ReversingEntry: Boolean; DocNo: Code[20]; PostingDate: Date)
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Emaillink

Hey there! So you want to contribute to FirebaseUI? Before you file this pull request, follow these steps:

Read the contribution guidelines.
Run ./gradlew check to ensure the Travis build passes.
If this has been discussed in an issue, make sure to mention the issue number here. If not, go file an issue about this to make sure this is a desirable change.
If this is a new feature please co-ordinate with someone on FirebaseUI-iOS to make sure that we can implement this on both platforms and maintain feature parity.

This PR looks like it was opened by mistake.  Closing.


For expression feature, I deploy 3.2.4 and argo submit expression-destructure-json.yaml, the value is not replaced

run "argo submit expression-destructure-json.yaml"
I check the pod log, it shows
"{{=jsonpath(workflow.parameters.config, '$.a')}}{{=jsonpath(workflow.parameters.config, '$.b')}}{{=jsonpath(workflow.parameters.config, '$.c')}}"
workflow.parameters.config are not replaced

@liujiong1982 I am not able to reproduce.  in 3.2.4 branch. Can you check the your. CLI version? Please provide the controller logs

argo: v0.0.0-dev-kc-7
BuildDate: 2021-11-19T01:29:47Z
GitCommit: 47a5208e9c940abb014c08847179865a5b227f49
GitTreeState: clean
GitTag: v0.0.0-dev-kc-7
GoVersion: go1.17.3
Compiler: gc
Platform: linux/amd64

@liujiong1982 I am not able to reproduce. in 3.2.4 branch. Can you check the your. CLI version? Please provide the controller logs

argo: v0.0.0-dev-kc-7
BuildDate: 2021-11-19T01:29:47Z
GitCommit: 47a5208
GitTreeState: clean
GitTag: v0.0.0-dev-kc-7
GoVersion: go1.17.3
Compiler: gc
Platform: linux/amd64

That is a dev version, can you please try again with latest?


More.data

Proposal for Data Storage and Transfer.  This is likely to be how all sections will be configured, if the team decides to take this route.
Includes fixes in #11

Before this can be merged, the updates in #11 must go first.


imported `react' is permanently hidden by definition of package react in package scalajs

Hello, thanks for your work and for a great software!
I have found impossible to follow readme for example project:
$ git clone https://github.com/apollographql/react-apollo-scalajs.git
$ cd react-apollo-scalajs
$ sbt example/fastOptJS::startWebpackDevServer

gives
[info] Loading global plugins from /home/user/.sbt/1.0/plugins
[info] Loading settings from plugins.sbt ...
[info] Loading project definition from /home/user/react-apollo-scalajs/project
[info] Updating ProjectRef(uri("file:/home/user/react-apollo-scalajs/project/"),
"react-apollo-scalajs-build")...
[info] Done updating.
[warn] Found version conflict(s) in library dependencies; some are suspected to
be binary incompatible:
[warn] 	* org.scala-js:sbt-scalajs:0.6.21 is selected over 0.6.19
[warn] 	    +- default:react-apollo-scalajs-build:0.1.0-SNAPSHOT (scalaVersion=2
.12, sbtVersion=1.0) (depends on 0.6.19)
[warn] 	    +- ch.epfl.scala:sbt-scalajs-bundler:0.9.0 (scalaVersion=2.12, sbtVe
rsion=1.0) (depends on 0.6.19)
[warn] Run 'evicted' to see detailed eviction warnings
[info] Loading settings from build.sbt ...
[info] Loading settings from build.sbt ...
/home/user/react-apollo-scalajs/tests/build.sbt:18: warning: value RuntimeDOM in
trait DependencyBuilders is deprecated (since 0.6.20): Requesting a DOM-enabled
JS env with `jsDependencies += RuntimeDOM` or `requiresDOM := true` will not be
supported in Scala.js 1.x. Instead, explicitly select a suitable JS with `jsEnv
`, e.g., `jsEnv := new org.scalajs.jsenv.jsdomnodejs.JSDOMNodeJSEnv`.
jsDependencies += RuntimeDOM % Test
                 ^
[info] Loading settings from build.sbt ...
[info] Loading settings from build.sbt ...
[info] Loading settings from build.sbt ...
[info] Set current project to apollo-scalajs (in build file:/home/user/react-apo
llo-scalajs/)
[info] Updating core...
[info] Done updating.
[info] Updating react...
[info] Done updating.
[info] Updating example...
[info] Done updating.
[info] Compiling 11 Scala sources to /home/user/react-apollo-scalajs/core/target
/scala-2.12/classes ...
[info] /home/user/react-apollo-scalajs/core/src/main/scala/com/apollographql/sca
lajs/link/Observable.scala:26:73: magnolia: could not find any direct subtypes o
f trait UndefOr
[info]                 error: ObjectOrWritten[js.UndefOr[js.Any => Unit]] = js.u
ndefined,
[info]                                                                         ^
[info] Done compiling.
[info] Compiling 4 Scala sources to /home/user/react-apollo-scalajs/react/target
/scala-2.12/classes ...
[info] Done compiling.
[info] Compiling 5 Scala sources to /home/user/react-apollo-scalajs/example/targ
et/scala-2.12/classes ...
[error] /home/user/react-apollo-scalajs/example/src/main/scala/com/apollographql
/scalajs/AuthorView.scala:3:34: object react is not a member of package com.apol
lographql.scalajs.com.apollographql.scalajs
[error] import com.apollographql.scalajs.react.Query
[error]                                  ^
[warn] /home/user/react-apollo-scalajs/example/src/main/scala/com/apollographql/
scalajs/AuthorView.scala:5:32: imported `react' is permanently hidden by definit
ion of package react in package scalajs
[warn] import slinky.core.annotations.react
[warn]                                ^
[error] <macro>:8:34: not found: value Query
[error]     def render(): ReactElement = Query(AuthorQuery, AuthorQuery.Variable
s(props.id))(_.data.map(d => div(d.author.toString)).getOrElse(h1("loading!")))
[error]                                  ^
[error] <macro>:8:40: not found: value AuthorQuery
[error]     def render(): ReactElement = Query(AuthorQuery, AuthorQuery.Variable
s(props.id))(_.data.map(d => div(d.author.toString)).getOrElse(h1("loading!")))
[error]                                        ^
[error] <macro>:8:53: not found: value AuthorQuery
[error]     def render(): ReactElement = Query(AuthorQuery, AuthorQuery.Variable
s(props.id))(_.data.map(d => div(d.author.toString)).getOrElse(h1("loading!")))
[error]                                                     ^
[error] /home/user/react-apollo-scalajs/example/src/main/scala/com/apollographql
/scalajs/Main.scala:3:34: object react is not a member of package com.apollograp
hql.scalajs.com.apollographql.scalajs
[error] import com.apollographql.scalajs.react.ApolloProvider
[error]                                  ^
[error] /home/user/react-apollo-scalajs/example/src/main/scala/com/apollographql
/scalajs/Main.scala:30:7: not found: value ApolloProvider
[error]       ApolloProvider(client)(
[error]       ^
[error] /home/user/react-apollo-scalajs/example/src/main/scala/com/apollographql
/scalajs/PostsView.scala:3:34: object react is not a member of package com.apoll
ographql.scalajs.com.apollographql.scalajs
[error] import com.apollographql.scalajs.react.Query
[error]                                  ^
[warn] /home/user/react-apollo-scalajs/example/src/main/scala/com/apollographql/
scalajs/PostsView.scala:5:32: imported `react' is permanently hidden by definiti
on of package react in package scalajs
[warn] import slinky.core.annotations.react
[warn]                                ^
[error] <macro>:8:34: not found: value Query
[error]     def render(): ReactElement = Query(AllPostsQuery)(res => res.data.ma
p(d => div(d.posts.toList.flatten.flatten.map(post => div(key := post.id.toStrin
g)(h1(post.title.getOrElse[String]("???")), h2(post.votes.getOrElse(0).toString)
, UpVote(post.id))))).getOrElse(h1("loading!")))
[error]                                  ^
[error] <macro>:8:40: not found: value AllPostsQuery
[error]     def render(): ReactElement = Query(AllPostsQuery)(res => res.data.ma
p(d => div(d.posts.toList.flatten.flatten.map(post => div(key := post.id.toStrin
g)(h1(post.title.getOrElse[String]("???")), h2(post.votes.getOrElse(0).toString)
, UpVote(post.id))))).getOrElse(h1("loading!")))
[error]                                        ^
[error] /home/user/react-apollo-scalajs/example/src/main/scala/com/apollographql
/scalajs/UpVote.scala:3:34: object react is not a member of package com.apollogr
aphql.scalajs.com.apollographql.scalajs
[error] import com.apollographql.scalajs.react.Mutation
[error]                                  ^
[warn] /home/user/react-apollo-scalajs/example/src/main/scala/com/apollographql/
scalajs/UpVote.scala:5:32: imported `react' is permanently hidden by definition
of package react in package scalajs
[warn] import slinky.core.annotations.react
[warn]                                ^
[error] <macro>:8:34: not found: value Mutation
[error]     def render(): ReactElement = Mutation(UpVoteMutation)((mut, res) =>
button(onClick := (() => mut(UpVoteMutation.Variables(props.postId))), disabled
:= res.loading)(div(if (res.loading) "upvoting" else "upvote!")))
[error]                                  ^
[error] <macro>:8:43: not found: value UpVoteMutation
[error]     def render(): ReactElement = Mutation(UpVoteMutation)((mut, res) =>
button(onClick := (() => mut(UpVoteMutation.Variables(props.postId))), disabled
:= res.loading)(div(if (res.loading) "upvoting" else "upvote!")))
[error]                                           ^
[error] /home/user/react-apollo-scalajs/example/target/scala-2.12/src_managed/ma
in/graphql.scala:7:54: type GraphQLQuery is not a member of package com.apollogr
aphql.scalajs.com.apollographql.scalajs
[error] object AuthorQuery extends com.apollographql.scalajs.GraphQLQuery {
[error]                                                      ^
[error] /home/user/react-apollo-scalajs/example/target/scala-2.12/src_managed/ma
in/graphql.scala:15:45: object gql is not a member of package com.apollographql.
scalajs.com.apollographql.scalajs
[error]   val operation = com.apollographql.scalajs.gql(operationString)
[error]                                             ^
[error] /home/user/react-apollo-scalajs/example/target/scala-2.12/src_managed/ma
in/graphql.scala:36:56: type GraphQLQuery is not a member of package com.apollog
raphql.scalajs.com.apollographql.scalajs
[error] object AllPostsQuery extends com.apollographql.scalajs.GraphQLQuery {
[error]                                                        ^
[error] /home/user/react-apollo-scalajs/example/target/scala-2.12/src_managed/ma
in/graphql.scala:45:45: object gql is not a member of package com.apollographql.
scalajs.com.apollographql.scalajs
[error]   val operation = com.apollographql.scalajs.gql(operationString)
[error]                                             ^
[error] /home/user/react-apollo-scalajs/example/target/scala-2.12/src_managed/ma
in/graphql.scala:64:57: type GraphQLMutation is not a member of package com.apol
lographql.scalajs.com.apollographql.scalajs
[error] object UpVoteMutation extends com.apollographql.scalajs.GraphQLMutation
{
[error]                                                         ^
[error] /home/user/react-apollo-scalajs/example/target/scala-2.12/src_managed/ma
in/graphql.scala:73:45: object gql is not a member of package com.apollographql.
scalajs.com.apollographql.scalajs
[error]   val operation = com.apollographql.scalajs.gql(operationString)
[error]                                             ^
[warn] three warnings found
[error] 18 errors found
[error] (example / Compile / compileIncremental) Compilation failed
[error] Total time: 23 s, completed Jul 20, 2018 7:36:29 PM
$

I have tried to separate project "example" and rename it's internal package "com.apollographql.scalajs" to "foobar" to exclude possible collisions, but it was not a success.
If confirmed, it could deeply disappoint newcomers, but considering that some time ago all was working and it's somehow connected with new versions, solution should be simple.
Thanks in advance.

Found it.
For modern apollo-codegen (e.g. 0.20.2) you need to comment this line in build.sbt
sbt.IO.writeLines(graphQLScala, s"package $namespace" +: sbt.IO.readLines(graphQLScala))
because it already generates package name, so this hack is not needed.


feat: GreyScale Filter & Canvas Rendering

Description

 Changed Image Rendering to Canvas-based
 Added GreyScale Filter
Made Save Button Functional
Improved Button Animations

Checklist

[x] I am making a proper pull request, not spam.
[x] I've checked the issue list before deciding what to submit.

Related Issues or Pull Requests
Change Image Rendering Method https://github.com/gdscjgec/Image-Editor/issues/10
Add Black and White Filter https://github.com/gdscjgec/Image-Editor/issues/8

Please put this on hold, i noticed some bugs in Chrome which did not pop up in FireFox, attempting to resolve.

Fixed it :)

@vigneshd332 Good Work, keep it up


fix Torlock provider

this fixes Torlock provider not returning any results.

@ShlomiD83 please also do the same for torrentfunk and yourbittorrent (change direct url to backend (which was changed to different domain) to frontend url). your trick works for them as well since all those 3 are the same, as we can see, the only difference is design, but they have same source of torrent files.

@antonsoroko can you please check if I did to correctly?

looks good. now wait for elgatito to merge it.


Fix landing page layout

The news items in general have shitty layout as the images get smushed together and it really doesn't look nice.
The avatar also gets overlayed with the news if not enough space is there.
For some reason, you can scroll on the main page, even if there's nothing to scroll.

Since only on thing is remaining, closing this in favor of #46.


Explain rate limiting

From the documentation is not clear how this library handles rate-limiting.
What happens if I try to fetch too much data, too fast. Will it internally pause until it's safe to continue? So, for me -as a library user- will be transparent and I'll get my data eventually?
Thanks!

Since https://github.com/PLhery/node-twitter-api-v2/pull/47 is merged, you now have some explaination of rate limit handling inside this lib :)


TODO for someone with superpower: invite BEP032 leads/members to the organization

ATM just

[x] @SylvainTakerkart
[x] and invite julia.sprenger of univ-amu.fr

if could right away add to https://github.com/orgs/bids-standard/teams/bep032/members - would be appreciated

@sylvaintakerkart added to BEP-032 and invited. @yarikoptic bumped to org owner.

thank you @effigies !

yep, thanks @effigies !


Inspirational libraries

https://evergreen.segment.com/
https://ant.design/

Brother, Your idea is great, Thank you for creating this.
Let us know how we can contribute,
Take MUI also as an Inspirational library. -> https://mui.com/

My thoughts. (Currently experiencing this problem)

We have a lot of CSS libraries, like Material Design, TailwindCss, Bootstrap, and many libraries.

I think we could create core component functionalities, which can plug with any CSS framework. I am not exactly sure Papanansi is the same idea. I just shared my thoughts. Available for brainstrome. **

Thanks for your comments, my plan right now is to be able to bring a version with 0 styles and let the user be able to style everything they wanted.
más you will see every element in the dom comes with a BEM selector and all the colors and more variables are CSS custom properties

@KalanaPerera I'm starting to add bugs with thelp wanted, maybe them inspire you.

@KalanaPerera I'm starting to add bugs with help wanted, maybe them inspire you.

Sure, I will have a look. thanks for letting me know.


Contract Viewer

The goal is to add a Contract Viewer tab with better functionalities than etherscan, ideally independent of etherscan and open source.
See demo video here:
https://x.com/high_byte/status/1743294802022609172?s=20
Things I've added:
ui components live in /components/ContractViewer.ts. I use shadcn components which live in the /@ folder, mui-tree-viewer element, and monaco editor. I think most of the CR should focus here since I'm no react developer.
api endpoint in /pages/api/getContract.ts to fetch etherscan contract information
utilities to flatten solidity source code (with small caveat of not yet supporting named imports) in /util/flatten.ts
utilities to parse etherscan info in /util/EtherscanApi.ts and /util/EtherscanParser.ts (in the end we want to support sourcify too)
reworked the solidity compiler web worker - supports selecting compiler version & generally just nicer smaller code.
I ended up using abi & storageLayout from solc, not using ast anymore at this moment.

Thanks for fixing the build @hananbeer (it also works for me locally now) 😄 Stability also seems a lot better with this versions so that's great 🎉
Some things I noticed:
We have this loading thing at the bottom when a contract is loaded - is this meant to be included ? (I think it would be nice to have, but then it should likely be higher up on the page)

When pressing send on the any of the functions it seems to result in a error and nothing happens 🤔

Before on function click it would find the function inside the file - is this feature removed now ?

fixed progress bar
send seems to work for me. which wallet are you using?
yes this feature is removed because it required parsing the ast instead of abi. now it would be ambiguous to do that so I just don't. need to search with ctrl+f and figure out which is the correct function.

Superseded by https://github.com/smlxl/evm.codes/pull/318


Address bar loses focus when scrolling web page.

Steps to reproduce:

Open any web page.
Click on address bar.
Start scrolling web page.

Expected result:
I'm not sure.
It seems to me one of the following should happen:

Address bar loses focus and the keyboard disappears.
Address bar keeps focus.

Actual result:
Address bar loses focus but the keyboard does not hide.

Thanks for reporting this @AndrewR8 I think the expected result proposal 1 could fit pretty well here.

Closing this issue, thanks for the contribution @AndrewR8


AppNagService

#1069
Service that allows an app to register to nag the user to review the app after a certain period of time or launches.
A couple notes on the code:

I put it in the Template10.Services.MarketplaceService namespace as that seemed appropriate even though most other services seem to have a 1:1 between namespace and service
AppNagService took dependencies on IDialogService, IFileService and IMarketplaceService. I don't see other examples of inter-service dependencies so not sure what patterns you prefer there. Those dependencies can be passed to the service constructor as interfaces so it should support IoC.

I did create a sample app, not included in this pull request, that I can create a PR for if this gets merged.

Cool. Let's remove "Nag" from it, and the files. And let's make the service Sealed.
Good work.

Looking closer. Let's make IMarketplaceService and all the other files nested INSIDE the rot MarketplaceService namespace.

Cool. Let's remove "Nag" from it, and the files.

How does AppReviewService sound?

Looking closer. Let's make IMarketplaceService and all the other files nested INSIDE the rot MarketplaceService namespace.

Can you clarify that? Not sure what you are requesting.

Let's do an about-face here. Let's call it NagService. Let make it reusable, though. Let's make it so, if your app has an updagrade and you want the user to upgrade, use the NagService. If your app has new data to download, use the NagService. And, if your app needs reviw, use the NagService. Just like you have it, but the key (for one) will need to change and be customizable (somehow). This make sense? A totally reusable NagService for any use case.
Template10.Services.NagService.INagService;
[sealed] Template10.Services.NagService.NagService : INagService;
Then we also need a MarketplaceService, almost 100% of what you already have. This will use the NagService. Which, I realize s almost where you were originally heading.
Template10.Services.MarketplaceService.IMarketplaceService;
[sealed] Template10.Services.MarketplaceService.MarketplaceService : IMarketplaceService;
Here's a note: a helper, fundamentally, can be used in any project. A service is specific, and might need to be re-implemented. A service uses the helper. The helper is just a simplification of another API or set of API. WHy do we have a helper? To simplify a complex implementation - but it is NEVER specific to a project. A service, on the otherhand, is always specific. If it is generic and reusable, that's jsut a coincidence and a bonus. It's also why it is sealed!

Was thinking along these lines originally so have some ideas on how to make it work.

Maybe a napkin drawing before you code it all up?

Here's the basic sketch in some roughed out stubs:
This class describes the nag and is how user code sets up a specific nag reminder:
public class Nag
{
    public string Id { get; set; }

    public bool AllowDefer { get; set; }

    public string MessageTemplate { get; set; }

    public string NoButtonText { get; set; } = "No, thanks";

    public string TitleTemplate { get; set; }

    public string YesButtonText { get; set; } = "Yes";

    public string DeferButtonText { get; set; } = "Not now";

    public Action NagAction { get; set; }
}

Id is how nag state would be indexed on the filesystem in order to manage the user's response, or lack thereof, to a nag e.g.  "Template10.Services.NagService.{Id}.json"
Two thoughts on how to specify Id: 1) Let the user specify the id and make sure their app's nag ids are unique. 2) SHA1 hash of the MessageTemplate. I'm leaning toward the hash as it is less for user code to manage, and the message template really is the unique element of a particular nag within the scope of an app.
There might be the need to allow user code to persist state with the nag to handle cases like: you've nagged the user to upgrade before, and they responded, but now there is a new upgrade. How does the app know to ignore the previous response and nag again? Squirreling away the last version nagged about with the response state is one way an app could manage that sort of scenario. I haven't thought that all the way through yet though.
INagService looks something like this, probably with some additions to allow nag responses to be inspected, reset or deleted:
public interface INagService
{
    Task Register(Nag nag, int launches, TimeSpan duration);

    Task Register(Nag nag, int launches);

    Task Register(Nag nag, TimeSpan duration);
}

The implementation of INagService is essentially the current AppReviewNagService code extended to support 1-n nags.
In regards to your point about Service vs Helper: though I am picking up what you're laying down, I'm not sure what changes in current PR code structure would better fit that approach. Is it that the AppReviewNagService has those 3 service dependencies and should avoid those in favor of instantiating the helper classes for file system/dialogs/marketplace internal to the service implementation? This would make the service project specific and it wouldn't need to worry about dependency management, but I'm not positive that is the direction you were heading. If there is a specific example that would help this code better fit the design philosophy of the project just let me know.

Looks great. Prob need to make Id a private set and pass it in the constructor to force the developer to use it properly. Otherwise, I think I would write it like this. Thanks for the up front effort here. ANd, yeah, I think Nag is an okay term here.

Cool. Should be able to get to it after the 4th. I'm thinking we should close this PR and I'll open a new one with the refactored implementation.


feat: Use new search endpoint in FE and add search filter operation selection

Summary of Changes
This change has three major sections that are all included together for compatibility:

Work done by @allisonsuarez to have the frontend service point to the new search endpoint.
Search input filters now accept comma separated values rather than only a single value.
When a comma to separate multiple filter terms is typed in any input filter box, a AND/OR toggle will appear, allowing the user to specify whether they are filtering by all of the entered filter terms in the same results, or just looking for at least one of the terms in the results.

Some design decisions to note:

There is a new optional frontend config in the BaseFilterCategory called allowableOperation. If it is not set, the default behavior will allow both AND and OR operations for filtering. If it is set to FilterOperationType.OR, only the OR filter operation will be enabled for that category, which can be used when each search result would only ever include one of the filter terms in the category - e.g. a given table would only have one source database. If it is set to FilterOperationType.AND, only the AND filter operation will be enabled for that category.
A special type called FilterOptions was used to keep track of which checkbox filters were checked or unchecked where a true value meant it should be checked and a false value unchecked. Since now the input filters accept multiple values, this type was removed and the checkboxes are handled the same way as the input filters, where the name of the checkbox being included in the filter means it should be checked and any not included are unchecked.
Since there is now only one search API call per search rather than one per resource, when a search action for a specific resource is taken, only that resource has its state updated from the response to avoid clearing out the previous search for the other resources.
Previously, clearing filters would trigger an empty search in order to clear out the results. With the new API, this was causing an error because it did not expect to get empty searches, so instead of doing an unnecessary API call when clearing filters it will just clear the results state instead.

Tests
Various changes were made to JS tests to account for changes to the way the frontend data is handled with filtering, such as checkboxes using a list of values rather than a special type to make it more consistent with the input filters. New tests were added for the AND/OR toggle behavior.
Documentation
frontend/docs/application_config.md was updated to account for the renamed filter category types, along with fixing outdated links.
CheckList
Make sure you have checked all steps below to ensure a timely review.

[X] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[X] PR includes a summary of changes.
[X] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[X] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain docstrings that explain what it does

Another way of doing this on an immutable way would be:
      // Remove the categoryId from the filters if the new value is empty
      const {[categoryId]: remove, ...updatedResourceFilters} = filterState[resourceType];

      newFilters = {
         ...filterState,
         [resourceType]: updatedResourceFilters,
      };

This would avoid the 'delete', that is a mutating operation (although made on a copy of the object)

@Golodhros I did it this way at first actually, but found I was getting a linting error because the remove is an unused variable. I didn't know if it was preferable to do it like this but then disable the no-unused-vars check for this spot?

Another way of doing this on an immutable way would be:
      // Remove the categoryId from the filters if the new value is empty
      const {[categoryId]: remove, ...updatedResourceFilters} = filterState[resourceType];

      newFilters = {
         ...filterState,
         [resourceType]: updatedResourceFilters,
      };

This would avoid the 'delete', that is a mutating operation (although made on a copy of the object)

@Golodhros I did it this way at first actually, but found I was getting a linting error because the remove is an unused variable. I didn't know if it was preferable to do it like this but then disable the no-unused-vars check for this spot? I figured the delete on the copy of the object was a middle ground to avoid linting issues but not directly mutating the original, but let me know if it's better the other way.

I see, try using '_' instead of rest, does that remove the warning?
If not, I would go ahead and disable the rule on this line!


Change order of getWidthFrom calculation to prevent innaccurate widths

This is to fix inaccurate widths being applied from getWidthFrom, under specific conditions:

box-sizing of the container is border-box
the container has left or right padding
the element being stickied is being used as getWidthFrom

Under these conditions, when the sticky element is changed to position:fixed, it's width becomes equal to the width of the container + left/right padding on the container (due to border-box). This can lead to unexpected widths being applied to the stick element. Calculating the width from getWidthFrom before setting position:fixed fixes this issue.

I think commit a429b78f from PR #148 addresses this issue. In that commit the width is applied exactly once, at once with position: fixed.

Hi all,
I´d like to know if the effect can stop working when it reaches a certain resolution, for example 991px. Thank you and sorry for my english.


Performance Test Suite

Crawl a Github corpus, register dependencies, possibly integrate library dependencies (e.g. pip or rubygems) in one or more languages.


Releasing the binaries fails during signing

The binaries are failing to be published with cp: cannot stat '*.sig': No such file or directory.
See https://github.com/containerd/runwasi/actions/runs/8367106882/job/22908797456 for example

we've been fixed by https://github.com/containerd/runwasi/pull/532 and the PR that came directly after that


Document best practices for file-based nodes in user guide

What changes were proposed in this pull request?
This PR adds a new topic to the user guide, describing best practices for notebook/script based pipeline nodes.

Closes #1703
How was this pull request tested?
Reviewed the output of make docs
Developer's Certificate of Origin 1.1
   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Content is ready for first review. Only the placeholder images need to be replaced.

Added link to pipelines topic and used generic/typed pipeline terminology in intorduction.


imx9_lpuart: use small lock in arch/arm(64)/src/imx9/imx9_lpuart.c

Summary
imx9_lpuart: use small lock in arch/arm(64)/src/imx9/imx9_lpuart.c
reason:
We would like to replace the big lock with a small lock.
Impact
imx9_lpuart
Testing
ci

[Experimental Bot, please feedback here]
No, this PR does not fully meet the NuttX requirements.  While it provides some information, it lacks crucial details.
Here's what's missing:

Summary:  The summary is too vague. It needs to explain why a smaller lock is desired (e.g., performance improvement, reduced interrupt latency).  It also needs to describe how the change is implemented (e.g., replacing nxsem_wait with nxsem_trywait, using a spinlock instead of a semaphore).
Impact: The impact section is severely lacking.  It simply repeats "imx9_lpuart."  It needs to address all the points listed in the requirements template.  For example:

Is new feature added? Is existing feature changed?  This is a change to an existing feature.
Impact on user:  Potentially yes, if the change affects performance. This needs to be investigated and documented.
Impact on build: Likely no, but this should be explicitly stated.
Impact on hardware: Specific to the imx9 architecture.
Impact on documentation:  Potentially yes, if the locking behavior is documented.
Impact on security/compatibility:  These need to be addressed, even if the answer is no.

Testing: "ci" is insufficient.  The testing section needs to include:

Specific build host details (OS, compiler version, etc.).
Specific target details (board, configuration).
Actual logs demonstrating the behavior before and after the change.  Simply stating "ci" doesn't provide any evidence that the change works as intended.

The PR needs significant revision to meet the NuttX requirements.  It needs to be more specific and provide detailed information about the change, its impact, and the testing performed.


Spliterator improvments

fix for NPE on empty source
add NPE when action is missing (required by contract)
declare characteristics

@mariuszs
Thanks again for your contributions.


Adding Astropy usage script

The script is full of hacks to circumvent the github API rate limit and the search result limitations to 1000 entries.
Surely, this script should go into a subdirectory, but I wasn't sure whether "demographics" is the best place or starting a new one.
The results from running the script the week prior 18/04/18 are stored in a pickled dictionary, here: https://drive.google.com/file/d/1g1I4UTFaN5zQkYl0aipEcjFdbdvNDria/view?usp=sharing

Let's merge it now as a documentation of where the numbers came from for the triangular figure. Improvements to this brute force method is expected for the future.


bevy_ui doesn't compile without the bevy_text feature

Bevy version
main branch: c24520cb72f98
What you did
cargo check --package bevy_ui --no-default-features

What went wrong
Compilation error (several)
error[E0432]: unresolved import `crate::widget::TextFlags`
 --> crates/bevy_ui/src/node_bundles.rs:4:22
  |
4 |     widget::{Button, TextFlags, UiImageSize},
  |                      ^^^^^^^^^ no `TextFlags` in `widget`

error[E0412]: cannot find type `Without` in this scope
   --> crates/bevy_ui/src/widget/image.rs:137:22
    |
137 |         (With<Node>, Without<UiImage>),
    |                      ^^^^^^^ not found in this scope
    |
help: consider importing one of these items
    |
1   + use bevy_ecs::prelude::Without;
    |
1   + use crate::Without;
    |

error[E0599]: the method `before` exists for fn item `fn(Local<'a, f64>, Query<'b, 'c, &Window, With<...>>, ..., ..., ...) {update_atlas_content_size_system}`, but its trait bounds were not satisfied
   --> crates/bevy_ui/src/lib.rs:163:54
    |
163 |             widget::update_atlas_content_size_system.before(UiSystem::Layout),
    |                                                      ^^^^^^ method cannot be called due to unsatisfied trait bounds
    |

Why it's happening
bevy_text is marked as optional = true in the bevy_ui Cargo.toml. And there is several #[cfg(feature = "bevy_text")] that indicates it is intended to be possible to run bevy_ui without bevy_text.
When I use the --no-default-feature, bevy_text is removed as a dependency, and the feature flag "bevy_text" is also removed.

Put in a pr a while ago #8760 I think

Still doesn't fix the compilation error. There is more than a single compilation error.

Can we get this checked for by CI? It seems like every time there is a non-trivial UI change it gets broken again.

Can we get this checked for by CI? It seems like every time there is a non-trivial UI change it's going to get broken again.

It's a fairly difficult choice. On one hand, we should make sure bevy compiles with all possible combination of feature flags, on the other hand, it's going to eat CI time like crazy.
@mockersf

Compiling each crate individually without default features wouldn't add a lot, but currently there's no easy way to get a list of all crates in the workspace, so that's a bit painful to set up in CI.
A few crates are checked without default features: https://github.com/bevyengine/bevy/blob/7aa0a47607ce369c96b1ad271095a7bb47f171f8/.github/workflows/validation-jobs.yml#L162


Graphql support

Would love to see graphql support!

There's no reason that GraphQL doesn't work with AdonisJs.
You can take a look at this demo: https://youtu.be/UBGzsb2UkeY?t=14m20s

Agree with @RomainLanz, not something I want to create a official provider for. It can be integrated like any other node module.
Closing, please feel free to open in case of any specific questions.

@RomainLanz, @thetutlage, can you show example, how use graphql with adonis, adonis models etc. ?

This template may help: https://github.com/hailwood/adonis-graphql
...however I recon it wouldn't be too hard to port laravel-graphql seeing as this is a package for Laravel and Adonis is pretty heavily inspired by it.

I agree with @7ammer here that porting one of the official laravel packages would be a better idea.
My repository really is a proof of concept with the hardest thing being the use of generators which requires some weird syntax to work with the promise-expecting graphql packages.

@hailwood, your repo has been great to read through. Not sure I would have worked out the generators bit. It's a bit of a new concept for me.


all func.sync() in funcs decorated by async.task

also, make async.task a function to pass inspect.getargspec, and allow calling synchronously with func.sync()

Description

GitHub Issues
#603 related

if you want to test calling lambda, you can set AWS_REGION and AWS_LAMBDA_FUNCTION_NAME as environment variables, and use placebo to mock some boto calls.

Coverage increased (+0.2%) to 79.204% when pulling 4acee319ea6ece3fa3a6a2ba1758e634235cc03d on schuyler1d:async_sync into 2bed81287c13957201b4a8915f11e1469c481e57 on Miserlou:master.

Coverage decreased (-20.7%) to 58.291% when pulling 4acee319ea6ece3fa3a6a2ba1758e634235cc03d on schuyler1d:async_sync into 2bed81287c13957201b4a8915f11e1469c481e57 on Miserlou:master.

Coverage decreased (-20.7%) to 58.291% when pulling 4acee319ea6ece3fa3a6a2ba1758e634235cc03d on schuyler1d:async_sync into 2bed81287c13957201b4a8915f11e1469c481e57 on Miserlou:master.

Coverage decreased (-20.7%) to 58.291% when pulling 4acee319ea6ece3fa3a6a2ba1758e634235cc03d on schuyler1d:async_sync into 2bed81287c13957201b4a8915f11e1469c481e57 on Miserlou:master.

Coverage increased (+0.4%) to 79.399% when pulling 7680d8268cc6e190b63b1a5d99be35b8dd500f06 on schuyler1d:async_sync into 2bed81287c13957201b4a8915f11e1469c481e57 on Miserlou:master.

Coverage increased (+0.4%) to 76.185% when pulling a386b54e2bc026741f51d9c77450b7047ab82e56 on schuyler1d:async_sync into a23eb6ac90b5bb6f57f4aea8657cac28f9b1b9e7 on Miserlou:master.

Coverage increased (+0.4%) to 76.185% when pulling a49e8e2294de3d6edc19474aa2d1e8ad8154a3cc on schuyler1d:async_sync into a23eb6ac90b5bb6f57f4aea8657cac28f9b1b9e7 on Miserlou:master.

fixes #834
some explicit feedback of what more we need on this would be helpful

This is the third time I'm looking at it and I think I'm getting closer to wrapping my head around it.
_run_async is still missing a docstring. More generally though, I'd like to see the parent comment replaced with something explanatory about the whole code path. I just think it looks too much like voodoo. (I'm not normally strict about this, but if we could use Google Style Python Docstrings here that'd help me out.)
  I added a 'lifetime of an async function' document on the header, which I hope de-voodoos some of it (and also helps future changes, including future-me :-)

Coverage increased (+0.4%) to 72.34% when pulling d2533326fcfa0aea5a7262372f9c9ea79de062da on schuyler1d:async_sync into 78bb301b43755a8627f5080386f966909db4eeec on Miserlou:master.

Okay, this is a really good looking PR now!
I'm going to manually test this, but I think we should be able to get this merged in shortly. Thanks for being so accommodating @schuyler1d


Unable to use absolute file path on mingw64 with NetCDF 4.8.1

the version of the software with which you are encountering an issue

NetCDF 4.8.1

environmental information (i.e. Operating System, compiler info, java version, python version, etc.)
Window 10, mingw64 gcc (version 10.1.0)

a description of the issue with the steps needed to reproduce it

The C file below works with NetCDF 4.7.4 but it produces an error with Error: No such file or directory with NetCDF 4.8.1.
I am debugging an issue for the Julia NetCDF package which today upgraded to 4.8.1. Linux and Mac OS X are fine.
In Julia, all C packages are cross-compiled from a Linux host. I was able to reproduce the issue indepdently of Julia.
This file is the sample simple_xy_wr.c file with an adapted filename to show the error.
#include <stdlib.h>
#include <stdio.h>
#include <netcdf.h>

/* This is the name of the data file we will create. */
/* fails in 4.8.1; works in 4.7.4 */
#define FILE_NAME "C:\\Users\\ALEXAN~1\\AppData\\Local\\Temp\\foobar.nc"

/* works 4.8.1 */
/*#define FILE_NAME "..\\AppData\\Local\\Temp\\foobar.nc"*/

/* works 4.8.1 */
/*#define FILE_NAME "Test\\foobar.nc"*/

/* We are writing 2D data, a 6 x 12 grid. */
#define NDIMS 2
#define NX 6
#define NY 12

/* Handle errors by printing an error message and exiting with a
 * non-zero status. */
#define ERRCODE 2
#define ERR(e) {printf("Error: %s\n", nc_strerror(e)); exit(ERRCODE);}

int
main()
{
   /* When we create netCDF variables and dimensions, we get back an
    * ID for each one. */
   int ncid, x_dimid, y_dimid, varid;
   int dimids[NDIMS];

   /* This is the data array we will write. It will just be filled
    * with a progression of numbers for this example. */
   int data_out[NX][NY];

   /* Loop indexes, and error handling. */
   int x, y, retval;

   /* Create some pretend data. If this wasn't an example program, we
    * would have some real data to write, for example, model
    * output. */
   for (x = 0; x < NX; x++)
      for (y = 0; y < NY; y++)
	 data_out[x][y] = x * NY + y;

   /* Always check the return code of every netCDF function call. In
    * this example program, any retval which is not equal to NC_NOERR
    * (0) will cause the program to print an error message and exit
    * with a non-zero return code. */

   /* Create the file. The NC_CLOBBER parameter tells netCDF to
    * overwrite this file, if it already exists.*/
   if ((retval = nc_create(FILE_NAME, NC_CLOBBER, &ncid)))
      ERR(retval);

   /* Define the dimensions. NetCDF will hand back an ID for each. */
   if ((retval = nc_def_dim(ncid, "x", NX, &x_dimid)))
      ERR(retval);
   if ((retval = nc_def_dim(ncid, "y", NY, &y_dimid)))
      ERR(retval);

   /* The dimids array is used to pass the IDs of the dimensions of
    * the variable. */
   dimids[0] = x_dimid;
   dimids[1] = y_dimid;

   /* Define the variable. The type of the variable in this case is
    * NC_INT (4-byte integer). */
   if ((retval = nc_def_var(ncid, "data", NC_INT, NDIMS,
			    dimids, &varid)))
      ERR(retval);

   /* End define mode. This tells netCDF we are done defining
    * metadata. */
   if ((retval = nc_enddef(ncid)))
      ERR(retval);

   /* Write the pretend data to the file. Although netCDF supports
    * reading and writing subsets of data, in this case we write all
    * the data in one operation. */
   if ((retval = nc_put_var_int(ncid, varid, &data_out[0][0])))
      ERR(retval);

   /* Close the file. This frees up any internal netCDF resources
    * associated with the file, and flushes any buffers. */
   if ((retval = nc_close(ncid)))
      ERR(retval);

   printf("*** SUCCESS writing example file simple_xy.nc!\n");
   return 0;
}

The code is compiled in a MSYS2 shell as follows:
$ gcc -o simple_xy_wr_nc481 -I/c/Users/Alexander\ Barth/.julia/artifacts/ae78b073115f5cca9ab13a23994bdd930ecfe887/include/ simple_xy_wr2.c -L/c/Users/Alexander\ Barth/.julia/artifacts/ae78b073115f5cca9ab13a23994bdd930ecfe887/lib -lnetcdf

Alexander Barth@alex-laptop MINGW64 /c/Users/Alexander Barth/Downloads
$ ./simple_xy_wr_nc481.exe
Error: No such file or directory

The path /c/Users/Alexander Barth/.julia/artifacts/ae78b073115f5cca9ab13a23994bdd930ecfe887/ contains the NetCDF 4.8.1 library.
Prior to all tests, I checked that the file to be written does not exists (any more).

You may have to apply the patches by hand rather than using the commit.

Thanks a lot! tst_diskless6.exe passes now:
[...]
PASS: tst_max_var_dims.exe
PASS: tst_formats.exe
PASS: tst_def_var_fill.exe
PASS: tst_err_enddef.exe
PASS: tst_default_format.exe
PASS: tst_diskless6.exe
PASS: run_cdf5.sh
[...]

Unfortunately, I have now these errors (later in the test suite):
PASS: test_parse.sh
FAIL: test_meta.sh
FAIL: test_data.sh
FAIL: test_fillmismatch.sh
FAIL: test_raw.sh
============================================================================
Testsuite summary for netCDF 4.8.1
============================================================================
# TOTAL: 5
# PASS:  1
# SKIP:  0
# XFAIL: 0
# FAIL:  4
# XPASS: 0
# ERROR: 0
============================================================================
See dap4_test/test-suite.log
Please report to<EMAIL_ADDRESS>============================================================================

Attached is the corresponding test-suite.log file.
test-suite.log
They seem to be related to the fact, that I disabled utilities (ncdump and friends). I will enable ncdump and report back.
Thanks again!

Here are some "failed" test concerning ncdump:
PASS: tst_inttags.sh
PASS: run_tests.sh
PASS: tst_64bit.sh
PASS: ref_ctest.exe
PASS: ref_ctest64.exe
FAIL: tst_output.sh
PASS: tst_lengths.sh
PASS: tst_calendars.sh
PASS: run_utf8_tests.sh
FAIL: tst_nccopy3.sh
PASS: tst_nccopy3_subset.sh
PASS: tst_charfill.sh
PASS: tst_iter.sh
PASS: tst_formatx3.sh
PASS: tst_bom.sh
PASS: tst_dimsizes.sh
PASS: run_ncgen_tests.sh
PASS: tst_ncgen4_classic.sh
PASS: test_radix.sh
PASS: test_rcmerge.sh
PASS: tst_null_byte_padding.sh
FAIL: test_unicode_directory.sh
FAIL: test_unicode_path.sh
PASS: tst_fileinfo.sh
PASS: tst_hdf5_offset.sh
PASS: tst_inttags4.sh
PASS: tst_netcdf4.sh
PASS: tst_fillbug.sh
FAIL: tst_netcdf4_4.sh
PASS: tst_ncgen4.sh
PASS: tst_h_scalar.sh
PASS: tst_nccopy4.sh
PASS: tst_nccopy5.sh
PASS: tst_grp_spec.sh
PASS: tst_mud.sh
PASS: tst_formatx4.sh
PASS: run_utf8_nc4_tests.sh
FAIL: run_back_comp_tests.sh
PASS: run_ncgen_nc4_tests.sh
PASS: test_scope.sh
PASS: tst_inmemory_nc3.sh
PASS: tst_nccopy_w3.sh
PASS: tst_inmemory_nc4.sh
PASS: tst_nccopy_w4.sh
PASS: tst_ctests.sh
PASS: test_keywords.sh
============================================================================
Testsuite summary for netCDF 4.8.1
============================================================================
# TOTAL: 46
# PASS:  40
# SKIP:  0
# XFAIL: 0
# FAIL:  6
# XPASS: 0
# ERROR: 0

I am wondering if the test case is a bit too strict, as I see these differences:
209c209
<  f1 = -3.402823e+38 ;
---
>  f1 = -3.402823e+038 ;

test-suite.log

I can fix the precision problem. But fixing the e+038 vs e+38 problem is trickier.

IN looking at the build file, I see some of these are disabled if running under windows.
I expect that they should be disabled under mingw as well.
Can you do the "uname" command under mingw and send me the result?

Short answer MINGW64_NT-10.0-19041 in the shell that I used so far.
Long answer: MSYS2 seems to come with 3 different launchers: MINGW32, MINGW64, MSYS2 (i.e. shells in a terminal with some environment variable setup; https://www.davidegrayson.com/windev/msys2/, https://www.msys2.org/wiki/Launchers/). They have all different unames.

launcher
uname

MINGW32
MINGW32_NT-10.0-19041

MINGW64
MINGW64_NT-10.0-19041

MSYS
MSYS_NT-10.0-19041

Sorry if this is confusing!

Fixed by https://github.com/Unidata/netcdf-c/pull/2138

Thank you for this PR! I applied it manually on the version 4.8.1, but I get the error:
/bin/sh ../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I..  -I../include -I../include -I../oc2  -I../libhdf5  -I../libdap2 -I../oc -I../libdap4 -I../libsrc4 -I../libnczarr   -fno-strict-aliasing -MT libnetcdf_la-nc_initialize.lo -MD -MP -MF .deps/libnetcdf_la-nc_initialize.Tpo -c -o libnetcdf_la-nc_initialize.lo `test -f 'nc_initialize.c' || echo './'`nc_initialize.c
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -I../include -I../include -I../oc2 -I../libhdf5 -I../libdap2 -I../oc -I../libdap4 -I../libsrc4 -I../libnczarr -fno-strict-aliasing -MT libnetcdf_la-nc_initialize.lo -MD -MP -MF .deps/libnetcdf_la-nc_initialize.Tpo -c nc_initialize.c  -DDLL_EXPORT -DPIC -o .libs/libnetcdf_la-nc_initialize.o
mv -f .deps/libnetcdf_la-nc_initialize.Tpo .deps/libnetcdf_la-nc_initialize.Plo
/bin/sh ../libtool  --tag=CC   --mode=link gcc  -fno-strict-aliasing -version-info 19:1:0 -no-undefined  -Wl,--export-all-symbols -o libnetcdf.la -rpath /mingw64/lib libnetcdf_la-nc_initialize.lo ../libdispatch/libnetcdf2.la ../libdispatch/libdispatch.la ../libsrc/libnetcdf3.la  ../libhdf5/libnchdf5.la  ../libdap2/libdap2.la ../oc2/liboc.la ../libdap4/libdap4.la ../libsrc4/libnetcdf4.la ../libnczarr/libnczarr.la  -lhdf5_hl -lhdf5 -lm -lz -lcurl
libtool: link: gcc -shared  .libs/libnetcdf_la-nc_initialize.o  -Wl,--whole-archive ../libdispatch/.libs/libnetcdf2.a ../libdispatch/.libs/libdispatch.a ../libsrc/.libs/libnetcdf3.a ../libhdf5/.libs/libnchdf5.a ../libdap2/.libs/libdap2.a ../oc2/.libs/liboc.a ../libdap4/.libs/libdap4.a ../libsrc4/.libs/libnetcdf4.a ../libnczarr/.libs/libnczarr.a -Wl,--no-whole-archive  -lhdf5_hl -lhdf5 -lz -lcurl  -Wl,--export-all-symbols   -o .libs/libnetcdf-19.dll -Wl,--enable-auto-image-base -Xlinker --out-implib -Xlinker .libs/libnetcdf.dll.a
C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.1.0/../../../../x86_64-w64-mingw32/bin/ld.exe: ../libdispatch/.libs/libdispatch.a(libdispatch_la-drc.o):drc.c:(.text+0x103): undefined reference to `assert'
collect2.exe: error: ld returned 1 exit status
make[2]: *** [Makefile:581: libnetcdf.la] Error 1
make[2]: Leaving directory '/home/Alex/netcdf-c/liblib'
make[1]: *** [Makefile:729: all-recursive] Error 1
make[1]: Leaving directory '/home/Alex/netcdf-c'
make: *** [Makefile:574: all] Error 2

But adding, #include <assert.h> in the file libdispatch/drc.c solves this compilation issue.
For some strange reasons, the test tst_output.sh still gets called (and fails), despite I have this change:
diff --git a/ncdump/Makefile.am b/ncdump/Makefile.am
index 8b527aa6..244cc7a3 100644
--- a/ncdump/Makefile.am
+++ b/ncdump/Makefile.am
@@ -72,8 +72,8 @@ bom tst_dimsizes nctrunc tst_rcmerge

 # Tests for classic and 64-bit offset files.
  ISCYGWIN
-TESTS += test_unicode_directory.sh  test_unicode_path.sh
-endif
-
 if LARGE_FILE_TESTS
 TESTS += tst_iter.sh
 endif
@@ -107,9 +103,9 @@ check_PROGRAMS += tst_vlen_demo

 # Tests for netCDF-4 behavior.
  ISMINGW
+if !
The other problem is that this Makefile.am test is not working right.

if ! ISMINGW
if ! ISCYGWIN

Try changing to the following in ncdump/Makefile.am.

if !ISMINGW
if !ISCYGWIN

and see if that fixes the problem,

fixed

With this change (and rerunning ./bootstrap, I am not sure if this was necessary), I can confirm that the test tst_output.sh is now skipped. I still see now an issue in tst_nccopy4.sh.
I am wondering if it would not be better to have a CI system testing mingw64. This would speed up significantly the testing and for you it would be much clearer to see what change did results in which outcome. I would be glad to help to set this up.
PASS: tst_ncgen4.sh
PASS: tst_h_scalar.sh
FAIL: tst_nccopy4.sh
PASS: tst_nccopy5.sh
PASS: tst_grp_spec.sh
PASS: tst_mud.sh
PASS: tst_formatx4.sh
PASS: run_utf8_nc4_tests.sh
PASS: run_ncgen_nc4_tests.sh
PASS: test_scope.sh
PASS: tst_inmemory_nc3.sh
PASS: tst_nccopy_w3.sh
PASS: tst_inmemory_nc4.sh
PASS: tst_nccopy_w4.sh
PASS: tst_ctests.sh
PASS: test_keywords.sh
============================================================================
Testsuite summary for netCDF 4.8.1
============================================================================
# TOTAL: 40
# PASS:  39
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0
============================================================================
See ncdump/test-suite.log
Please report to<EMAIL_ADDRESS>============================================================================
make[4]: *** [Makefile:1518: test-suite.log] Error 1
make[4]: Leaving directory '/home/Alex/netcdf-c/ncdump'
make[3]: *** [Makefile:1626: check-TESTS] Error 2
make[3]: Leaving directory '/home/Alex/netcdf-c/ncdump'
make[2]: *** [Makefile:1732: check-am] Error 2
make[2]: Leaving directory '/home/Alex/netcdf-c/ncdump'
make[1]: *** [Makefile:1405: check-recursive] Error 1
make[1]: Leaving directory '/home/Alex/netcdf-c/ncdump'
make: *** [Makefile:731: check-recursive] Error 1

Alexander Barth@alex-laptop MINGW64 /home/Alex/netcdf-c
$ cd ncdump/

Alexander Barth@alex-laptop MINGW64 /home/Alex/netcdf-c/ncdump
$ cat test-suite.log
=========================================
   netCDF 4.8.1: ncdump/test-suite.log
=========================================

# TOTAL: 40
# PASS:  39
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0

.. contents:: :depth: 2

FAIL: tst_nccopy4
=================

*** Testing compound types some more.
*** creating another compound test file tst_comp2.nc...ok.
*** Tests successful!

No such file or directory
Location: file nccopy.c; line 2018
FAIL tst_nccopy4.sh (exit status: 1)

Is it possible to set up a github action to test mingw?

@DennisHeimbigner Somebody just needs to codify the steps it takes to setup the environment and build netcdf for Windows. But yes, GitHub actions has support for Windows, Linux (ubuntu), and macOS.

Ward- have any idea how to approach this?

@dopplershift I'll look, it may be a little stale but these directions were written and distributed when cmake support was originally introduced.  The primary issue (at the time, based on the feedback we received) was the overhead of setting up Visual Studio + compiling the required libraries by hand was a big lift for users who wanted to just use the libraries, not necessarily develop against them.  I'll take a look at refreshing this and see what libraries still need to be compiled by hand vs. which ones can be linked against or installed by a package management system like conda, although if they are using conda to install dependencies perhaps they should just use it to install libnetcdf altogether.
@DennisHeimbigner Yes, I'll take a look at the Github Actions platform environments.  Saying it has support for 'Windows' is a bit nebulous, insofar as sometimes people say Windows when they mean Visual Studio (which is the habit I'm trying to break), and others use it to mean literally any of the popular development environments (MSYS+MinGW, CMD+MinGW, Powershell+MinGW, Cygwin) existing within a Windows OS environment.
In either case, we need to automated more Windows platform testing, regardless of the dev. environment, and perhaps that will be the next priority after the current writing project is in a good place.

Well in this case GitHub actions supporting Windows means you can start up a VM, that happens to be pre-populated with a bunch of dev packages. You can of course install on top of that pretty much whatever you feel like.

In this case all we need is a windows machine running mingw. I don't think that requires
using visual studio at all.

@DennisHeimbigner That is correct.  I will take a look at the Github Actions documentation and see what I can set up.

Here is an attempt from my side:
https://github.com/Alexander-Barth/NetCDF-CI-Builder/blob/main/.github/workflows/ci.yml
https://github.com/Alexander-Barth/NetCDF-CI-Builder/blob/main/ci-build.sh
Which is directly based on this:
https://www.msys2.org/docs/ci/
Msys2 provides a github action which make this quite easy to do.

Ok, I have a working mys/mingw action workflow.
It is disclosing a number of issues that need fixing.

I am tearing my hair out over this.

In julia we are still using NetCDF 4.7.4 but there are some issues (https://github.com/Alexander-Barth/NCDatasets.jl/issues/162, https://github.com/Alexander-Barth/NCDatasets.jl/issues/145) in this version which are solved in NetCDF 4.8. The julia package NetCDF.jl from @meggart uses the same NetCDF compiled library and also currently at 4.7.4.
It would be great if we could update to a newer version (also for Zarr support). Unfortunately, Windows/mingw prevents us from upgrading. Have some of the changes mentioned in this thread already being integrated in the main branch?

As far as I know, this is fixed by https://github.com/DennisHeimbigner/netcdf-c/commit/55a2643cac438cb0815242f48137114b99d36185
Thanks a lot!


Panic while fetching drm fdinfo

Hey!
Great project, I wanted to give it a try but hit this error:
thread 'main' panicked at src/drm_fdinfo.rs:240:23:
index out of bounds: the len is 1 but the index is 1
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

I'd want to contribute a fix but I'm not sure what drm_fdinfo is and how to circumvent the error :)

Hi @orhun, thanks for the report and for testing! Sorry about the issue. I'm guessing you don't have an Intel GPU, do you? I haven't been able to test it with an AMD one yet, but it shouldn't break (I thought). Do you mind sending me the backtrace? I'll take a look later tonight to fix it and probably put in README the current vendor support more clearly.

Hey @ulissesf, I tried this on my AMD machine and was able to reproduce it.  I hacked in a debug! call to print the lines being split:
[2024-10-31T18:01:02Z DEBUG qmassa::drm_fdinfo] LINE: "drm-memory-vram:\t16700 KiB"
[2024-10-31T18:01:02Z DEBUG qmassa::drm_fdinfo] LINE: "drm-memory-gtt: \t8192 KiB"
[2024-10-31T18:01:02Z DEBUG qmassa::drm_fdinfo] LINE: "drm-memory-cpu: \t0 KiB"
In other words, a couple of the values have a pesky extra space after the colon, so the splitting on ":\t" isn't working.
-            let kv: Vec<&str> = l.split(":\t").collect();
+            let kv: Vec<&str> = l.split(":").collect();
             let k = kv[0];
-            let v = kv[1];
+            let v = kv[1].trim();

seems to get it past this, though it might split too much if there are colons on the right hand side.
Once up, however, it doesn't display any process, memory, or frequency info, but presumably that's just amdgpu support missing.

Hey @ulissesf, I tried this on my AMD machine and was able to reproduce it.  I hacked in a debug! call to print the lines being split:
[2024-10-31T18:01:02Z DEBUG qmassa::drm_fdinfo] LINE: "drm-memory-vram:\t16700 KiB"
[2024-10-31T18:01:02Z DEBUG qmassa::drm_fdinfo] LINE: "drm-memory-gtt: \t8192 KiB"
[2024-10-31T18:01:02Z DEBUG qmassa::drm_fdinfo] LINE: "drm-memory-cpu: \t0 KiB"
In other words, a couple of the values have a pesky extra space after the colon, so the splitting on ":\t" isn't working.
-            let kv: Vec<&str> = l.split(":\t").collect();
+            let kv: Vec<&str> = l.split(":").collect();
             let k = kv[0];
-            let v = kv[1];
+            let v = kv[1].trim();

seems to get it past this, though it might split too much if there are colons on the right hand side.
Once up, however, it doesn't display any process, memory, or frequency info, but presumably that's just amdgpu support missing.

Hi @kaydenl, thanks for debugging it! I got one AMD card borrowed to look at this over the weekend. I'll get your changes and some others in this area so we don't create more strings than needed and trim key/value to be more robust.
Yes, amdgpu support is missing, but I'll add the basics this weekend.

Hey guys, yup, I have an AMD GPU, sorry for not making clear while submitting the issue. Glad to hear that you're going to add support for it!

@orhun and @kaydenl, I've merged a fix and a couple of other improvements to get as much data from amdgpu's DRM fdinfo files right now. Let me know if it works for you as well (I tested with an AMD RX 7600M tonight). I will add some of the amdgpu driver-specific info over the weekend.
I went with a different fix, @kaydenl, as we indeed can have more colons in some of the key-value info (e.g. drm-pdev). Let me know what you think.

Can confirm that the fix is working, thanks!


Google.Apis.Oauth2.v2 NuGet Error

Hi
I'm trying to install Google.Apis.Oauth2.v2 via NuGet in SQL Server Data Tools for Visual Studio 2013, but I get the below error:
Attempting to resolve dependency 'Google.Apis (= 1.10.0)'.
install-package : Updating 'Google.Apis 1.22.0' to 'Google.Apis 1.10.0' failed. Unable to find versions of 'Google.Apis.Oauth2.v2, Google.Apis.Auth' that are compatible with 'Google.Apis 1.10.0'.
At line:1 char:1

install-package Google.Apis.Oauth2.v2

  + CategoryInfo          : NotSpecified: (:) [Install-Package], InvalidOperationException
  + FullyQualifiedErrorId : NuGetCmdletUnhandledException,NuGet.PowerShell.Commands.InstallPackageCommand

Could you explain what you mean by "in SQL Server Data Tools"? It's not clear to me why SQL Server Data Tools would be wanting to use Google.Apis. What kind of project is this for?
The more context you can give, the more likely it is that we'll be able to help.

Hi
I am trying to write an SSIS package that downloads data from a Google Sheet, I am trying to utilise the Script Component as per http://stackoverflow.com/questions/30469058/google-gdata-client-gdatarequestexception-authentication-suddenly-fails-in-old. This requires Google.Apis.Oauth2.v2, and when I try and install the package from https://www.nuget.org/packages/Google.Apis.Oauth2.v2/ I get teh error in the first post.

Okay, thanks for the extra information. I don't know anything about SSIS packages, including which version of .NET they target, but you might want to try making sure everything is using the 1.10.0 packages. (I don't know at what point you were getting that error, or what you'd already installed before then.)

The client libraries only work with .Net 4.5  you need to figuer out what version MSSql server2013
The dlls need to be in GAC
Program Files (x86)\Microsoft SQL Server\120\DTS\PipelineComponents
Program Files\Microsoft SQL Server\120\DTS\PipelineComponents
Program Files\Microsoft SQL Server\120\DTS\Connections
Program Files (x86)\Microsoft SQL Server\120\DTS\Connections

Assuming that i am remember correctly i think 2013 is 120 cant remember of the top of my head.

Although projects targeting .NET4.0 should work, it's deprecated and unsupported.
As previously mentioned, Google.Apis v1.10.0 was the last version of the package to support .NET4.0 so v1.10.0 of Google.Apis is correct.
Did you start the project targetting a version of .NET greater than 4.0? Then re-target to .NET4.0? That would explain how Google.Apis v1.22.0 was installed. possibly starting with a fresh project targeting .NET4.0 may help.
I have no knowledge of SSIS or scripting environments, so can't help with any issues related to that.

I tried to get it to work the other day. I don't think that the dts api is going to support this library the framework is to different.

Closing for now, as SSIS/.NET4.0 are environments we don't support.


npm install -g not creating shell/cmd files

I've install nvm under c:\nvm and it uses c:\nodejs to symlink to the node version folder.
I've switched to Node v0.10.31
I now run npm install -g something but npm fails to create the C:\nodejs\something and C:\nodejs\something.cmd files.   Am I missing a configuration settings?
Confirmed that npm is running c:\nodejs\npm

Ok ... Found that the problem was with the package I was installing.  Claimed to have a CLI but did not declare it in package.json.


ngx-translate-extract translation placeholders should not suppress falling back to the default language

I'm submitting a ...  (check one with "x")
[ ] bug report => check the FAQ and search github for a similar issue or PR before submitting
[ ] support request => check the FAQ and search github for a similar issue before submitting
[x] feature request

Current behavior
We use ngx-translate-extract to keep translation files in sync, which automatically inserts a mapping to "" for new keys, which is convinient for the translator, but suppresses the ngx-translate fallback to the default language.
Expected/desired behavior
To handle pending translations more gracefully, it would be nice if the translation placeholder inserted by ngx-translate-extract would cause a fallback to the default language at runtime.
I therefore propose that "" be considered undefined by TranslateDefaultParser.getValue().
Reproduction of the problem
Default language:
{
  "My Tasks": "My Tasks"
}

Used Language:
{
  "My Tasks": ""
}

Expression {{'My Tasks' | translate}} should yield "My Tasks" rather than "".
What is the motivation / use case for changing the behavior?
Sometimes our translators take a little time, and it is better to serve our testers/users with a label in the wrong language than no label at all.
Please tell us about your environment:

ngx-translate version: 6.0.0
Angular version: 2.x.x
Browser: all

Workarounds include:

replacing "" by null at build or translation load time
not committing placeholders to version control by reverting the changes done by ngx-translate-extract after sending the file to the translator, and only commit the fully translated files.

As Sam points out in #509, there are valid usecases for empty translations, so I've changed my workflow to revert after sending files for translation.


Sync photos with desktop

okay, have a look here @andrewxhill

oop, one sec

k, tmp flow added, see long commit msg


secret variables evaluated in bash deploy script

this:
deploy:
  bash:
    command: curl --data "build=true" -X POST https://registry.hub.docker.com/u/my/image/trigger/$$DOCKER_BUILD_TOKEN

gets evaluated and $$DOCKER_BUILD_TOKEN is replaced by the actual value set through the GUI. Even when the GUI states those are "secret" variables.
Even when logged out, I can see the real value in the public log output.

@JeanMertz the $$ notation does a find / replace in the yaml file. It is intended primarily for things like notifications, which are executed in pure Go code.
For deployments, which get converted to shell scripts, you can simply refer to the environment variable directly in your script ($DOCKER_BUILD_TOKEN instead of $$DOCKER_BUILD_TOKEN):
deploy:
  bash:
    command: curl ..../$DOCKER_BUILD_TOKEN

@bradrydzewski awesome thanks.
Totally unrelated (but maybe too simple to open a new issue):
Is it possible to have drone use the ENTRYPOINT script of an image when starting the build container?

@JeanMertz it would not be possible. Drone overrides the Entrypoint in order to execute the build script.


Claim information security

I have a multi tenant application where users share the same database, separating information only with a TenantId type column
public class SampleEntity
{
   public int Id {get;set;}
   public string Name {get;set;}

   public int TenantId {get;set;}
}

Currently I use asp.net identity in an mvc application
I store the TenantId of the user logged in to Claim, and every request and access to the database I use TenantContext.TenantId where it returns the tenantId that is in the Claim
public static int? TenantId
      {
          get
          {
              var claimsPrincipal = Thread.CurrentPrincipal as ClaimsPrincipal;
              var tenant = claimsPrincipal.Claims.FirstOrDefault(c => c.Type == AppClaimTypes.TenantId);
              int tenantId;
              if (!int.TryParse(tenant.Value, out tenantId))
              {
                  return null;
              }
              return tenantId;
          }
      }

In asp.net Identity, by default the cookie is encrypted and I do not worry about leaving the TenantId in Claim
In IdentityServer, my Claims is encrypted? Should I encrypt the token? Currently I use integer as primary key,
How it is information that has great importance, should I use it as guid?
What would be the best way to store tenantId?
Which way should I go? I am a layman in identityserver and I do not want to expose this fault

This seems to be a general question about IdentityServer - not a bug report or an issue.
Please use StackOverflow for that. This has the advantage that questions and answers can be easily found by search engines, and that there are more people answering questions than just us.
For IdentityServer3
https://stackoverflow.com/questions/tagged/?tagnames=identityserver3&sort=newest
For IdentityServer4
https://stackoverflow.com/questions/tagged/?tagnames=identityserver4&sort=newest
For commercial support
https://identityserver.io/


[T3A3][W14-A1]Brehmer Chan Xi Quan

Some code adapted from #218

@Krumbles Please look through the comments and close the PR


Can't run "dotnet" command on Terminal

Problem encountered on https://dotnet.microsoft.com/en-us/learn/dotnet/hello-world-tutorial/install
Operating System: macos
Provide details about the problem you're experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.

What error message do you get?

After i installed dotnet 6.0 and try to run "dotnet". My terminal give me a message like this :
zsh: command not found: dotnet

@billzayy this error shows up if you try to run dotnet on a terminal window that was open while you were installing the SDK in another terminal window, or via the UI. You need to close the terminal window and open a new one to ensure the environment variables are refreshed with the location of the dotnet executable.
@mairaw maybe the tutorial should describe the error message users would see in macos and unix. The error message isn't the same as in Windows when an executable is not found.

That's a good idea @carlossanlop. So the 'dotnet' is not recognized as an internal or external command is only for Windows machines?

@carlossanlop thanks for your support ! but can i ask what is the different between .NET SDK x64 & .NET SDK Arm64 ? Because after i tried to install a x64 version and still didn't run on MacOS. But i installed Arm64 version and it run now.

Oh, i get this! Thanks for your support @mairaw & @carlossanlop. My problem is solved !

That's a good idea @carlossanlop. So the 'dotnet' is not recognized as an internal or external command is only for Windows machines?

That is correct, @mairaw . I opened a new issue to track this request. https://github.com/dotnet/core/issues/7245
We can close this now since it has been solved.


:bug: Regex to avoid substring matching on route paths

This updates the formatPath function to use a regex pattern that matches :k followed by either a / or the end of the string ($). This way, it won't inadvertently replace parts of other placeholders.
Resolves #1335

No unit test?! :wink:

No unit test?! 😉

Added some and moved the util to the utils file.


Issue with indexing dates

Hi, my model has two MySQL date columns, start_date and end_date stored as "Y-m-d", in addition to Laravel's created_at and updated_at.
In order for me to get them to display on the front end I need this line in my model:
protected $dates = ['start_date', 'end_date'];

I'm trying to integrate Laravel Scout with this driver but am running into an issue during index:
Creating index for App\Models\Report...
In Carbon.php line 582:
  Data missing

Likewise, when trying to search the model I get this:
InvalidArgumentException
Data missing

The source of the problem seems to be these setters:
    /*
     * Convert start date to valid timestamp before adding to database.
     *
     * @param $value
     */
    public function setStartDateAttribute($value)
    {
        $this->attributes['start_date'] = Carbon::createFromFormat('m/d/Y', $value);
    }

    /**
     * Convert end date to valid timestamp before adding to database.
     *
     * @param $value
     */
    public function setEndDateAttribute($value)
    {
        $this->attributes['end_date'] = Carbon::createFromFormat('m/d/Y', $value);
    }

Which I use because the date picker data is flashed in the format m/d/Y and then converted on persistence.
How can I get around this?

@gmask  Can you Log the $value and output here

What I don't get is why that mutator is even a concern of the indexer, since a mutator is only used on update of a new record?
Here is a tinker instance of the first record:
>>> $report = App\Models\Report::first();

=> App\Models\Report {#982
    id: 1,
    author_id: 3,
    customer_id: "555",
    job_number: 123456,
    contact_name: "Foo Bar",
    contact_phone: "555-123-4567",
    start_date: "2017-11-06",
    end_date: "2017-11-10",
    active: 1,
    created_at: "2017-11-07 06:36:06",
    updated_at: "2017-12-12 10:08:21",
}

>>> var_dump($report->created_at);

object(Illuminate\Support\Carbon)#975 (3) {
    ["date"]=>
    string(26) "2017-11-07 06:36:06.000000"
    ["timezone_type"]=>
    int(3)
    ["timezone"]=>
    string(19) "America/Los_Angeles"
}

And here's how these records are created, $value is start_date and end_date before being converted to a Carbon timestamp.
>>> $report = new App\Models\Report;
=> App\Models\Report {#981}
>>> $report->start_date = "12/13/2017";
=> "12/13/2017"
>>> $report->start_date;
=> Illuminate\Support\Carbon @1513184688 {#975
     date: 2017-12-13 09:04:48.0 America/Los_Angeles (-08:00),
   }
>>>


Getting Full code from Model Builder

Hello
I am working in ML.NET to create a image classification model, and I got interested in the Model Builder code consumption. I have used the Model Builder to train a simple model and then consumed it to get a generated code in C# console form. As I understood when consuming the Model Builder generates 4 files: consumption file, training file, zip file with the actual model, and the main program.cs file. When launched, the program executes program.cs file which invokes consumption file which gets data for the model from zip file. So training file is not used in its default state and is present only for possibility of retraining the model in future.
I am curious about getting the code for the program which created the zip file, namely the original pipeline training algorithm, which transforms data, chooses the classification algorithm/method, performs training and saves the model. Is it possible to get this code? Retraining the model is not an option for me because I want to generate lots of small concrete models, rather than having one huge universal model.
I couldn't find any function that actually creates new model saves it to zip file.
Correct me please, if I am wrong
Thanks in advance

@luisquintanilla Can you take a look at this question?

Hi @NarwhalRoger
Model Builder is powered by our AutoML API. Here's a few sample notebook showing how to use it.
https://github.com/dotnet/csharp-notebooks/blob/main/machine-learning/03-Training and AutoML.ipynb
https://github.com/dotnet/csharp-notebooks/blob/main/machine-learning/E2E-Classification with Iris Dataset.ipynb
Hope this helps.


Correct minikube restriction: sch_netem is loaded by default in v1.6.

Signed-off-by: Laura Henning<EMAIL_ADDRESS>What problem does this PR solve?
The restrictions for minikube are not up to date: netem related chaos can be run in default minikube vm in versions >= 1.6 now
What is changed and how does it work?
I did a PR to minikube to make a tool called pumba work, which also uses tc netem. I noticed the kernel module was missing, and minikube guys accepted my PR to add it :)
This is just a change to the README of this project, so I ran no additional tests.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

Merging #236 into master will decrease coverage by 3.4%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
- Coverage   47.05%   43.64%   -3.41%
==========================================
  Files          23       18       -5
  Lines        1037      685     -352
==========================================
- Hits          488      299     -189
+ Misses        481      353     -128
+ Partials       68       33      -35

Impacted Files
Coverage Δ

controllers/timechaos_controller.go

pkg/ptrace/ptrace.go

api/v1alpha1/timechaos_types.go

pkg/time/time.go

pkg/ptrace/cwrapper.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e50dccc...ffc2f59. Read the comment docs.

Wow! Thank you🎉

@LaumiH thank you very much


Update index.html

Listed my fav foods in the body

listed

merged

merged and deleted the branch

pulled and deleted

merged

mensioned pull request

i cant do #11 merging.
On Sun, Jun 13, 2021 at 11:25 PM github-learning-lab[bot] <
@.***> wrote:

@.**[bot] approved this pull request.
Step 11: Merge your third pull request
Those links are looking great, @pvsneha https://github.com/pvsneha.
Go ahead and merge this pull request. Don't forget to delete your branch!
⌨ Activity: Merge the list and links

Click on Merge pull request below.
Click on Confirm merge.
Click on Delete branch.

I'll respond when you've merged this pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pvsneha/intro-html/pull/7#pullrequestreview-682432533,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQUDLEREXJVWF3IYHSHUA63TSTWKNANCNFSM46T6IK2A
.


Enable deptry

Move some of the testing requirements from the main group to the dev group since they're only used for tests.

Codecov Report
Patch and project coverage have no change.

Comparison is base (febdb25) 86.48% compared to head (4eb74a1) 86.48%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #665   +/-   ##
=======================================
  Coverage   86.48%   86.48%
=======================================
  Files           9        9
  Lines         407      407
  Branches       76       76
=======================================
  Hits          352      352
  Misses         35       35
  Partials       20       20

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Ginkgo CI: validate that test coverage is equivalent to old framework

Parent: #1839
Validate that existing tests are properly migrated over to have equivalent test coverage. Ensure that each test has adequate logs that describe what is going on:
Runtime tests:

[ ] 00-check-generated-dockerfile.sh

@ianvernon - cc @tgraf we will not need this with the new Dockerfile setup I think; I think we can get rid of this.

[ ] 00-fmt.sh

We will keep this as is.

[ ] 00-no-newlines-in-log-call.sh

We can keep this as is I think.

[ ] 00-pull-docker-images.sh

This should be done as part of the Packer scripts. TODO: add this ticket

[ ] 00-script-linter.sh

This can be left as is.

[ ] 01-ct.sh

@tgraf @aanm

[ ] 02-perf.sh

@tgraf

[ ] 03-docker.sh

@tgraf

[ ] 05-cni.sh

@tgraf

[ ] 06-lb.sh

@ianvernon @borkmann @tgraf

[ ] 07-kafka.sh

@manalibhutiyani @tgraf

[ ] 08-nat46.sh

@jrajahalme

[ ] 09-perf-gce.sh

@aanm  - this is not ran in our tests. Is this needed as part of the Cilium repo?

[ ] 10-proxy.sh

@jrajahalme

[ ] 11-getting-started.sh

@ianvernon

[ ] 12-policy-import.sh

@ianvernon @tgraf @scanf

[ ] 13-fd-open.sh

@aanm

[x] 13-monitor-filtering.sh

@scanf

[ ] 14-policy-enforcement-docker.sh

@ianvernon

[ ] 15-check-container-id.sh

@scanf

[ ] 16-cidr-ingress-policy.sh

@jrajahalme @ianvernon

[ ] 17-cilium_policy-id-remove.sh

@scanf

[x] 17-multiple-monitors.sh

@scanf

[ ] 18-kvstore-fail.sh

@scanf

[ ] 19-identity-get.sh

@ashwinp

[ ] 20-cidr-limit.sh
[ ] 21-ct-clean-up.sh

@aanm

[ ] 20-identity-list.sh

@ashwinp @ianvernon

[ ] 96-restore-endpoints.sh

@aanm

[ ] 97-clean-leftovers.sh

@aanm

[ ] 98-documentation-link-check.sh

@scanf

K8s tests:

[ ] 00-gsg-test.sh

@ianvernon

[ ] 00-setup-kubedns.sh

I don't think this is necessary anymore in the new setup we have. We can add a function that checks for kube-dns to be setup if need be. @aanm please confirm.

[ ] 001-policy-enforcement.sh

@ianvernon - this was removed in the bash script tests, so we can remove this test in the K8s tests as well to increase the speed of the build.

[ ] 01-guestbook-test.sh

@aanm this test was not migrated. please confirm equivalent functionality exists in the K8s tests.

[ ] 02-cnp-specs.sh

@aanm this test was not migrated. please confirm equivalent functionality exists in the K8s tests.

[ ] 99-restore-state.sh

@aanm

The Kubernetes tests are not ported over directly. However, the functionality being tested is stated to be equivalent. These should be given extra care in validating.

Went through the monitor test LGTM.

I have tagged the people whose names appear in git blame for each test. This is not a direct assignment for each tagged person to migrate each test. The person(s) tagged should go through the Ginkgo tests and see if the test has been migrated correctly / appropriately or not. If it hasn't, create a GitHub issue. We can then distribute load accordingly. I'm open to other ideas about how to approach this as well.

If we move the pull docker images script into the packer script, does that mean it is not fetching the latest images for every full test run? I think it makes more sense to have it in the provision script so we use the latest images.

@scanf - I'm open to having the script to pull the images as part of the provisioning step. We can periodically update the VMs on Vagrant Cloud to have the latest version of the images if they have changed to increase the throughput of the build as well.

The merging of https://github.com/cilium/cilium/pull/2940 means that this can be closed :-)


fix(error-handling): handle 404 in cross bp

handle NoRecordFound in cross blueprint
remove print statement
r? @MurphyMarkW

+1


Temporarily fix expires_in for access token response

Note: This can be reverted when Spring Security 5.6 is released.
Closes gh-281

Thanks for the PR @sjohnr ! This is now in main.


Redirect to zfmodules.com

Request http://modules.zendframework.com/feed redirects to http://zfmodules.com/, should be http://zfmodules.com/feed . We need to keep old paths to keep compatibility

as the redirect comes from a different zend server where we have no control this is a task for @weierophinney. can you do this please?

@weierophinney
Any idea?

Odd -- we actually keep the path when redirecting:
RewriteCond %{HTTP_HOST} ^modules.zendframework.com$
RewriteRule ^.* https://zfmodules.com$1 [L,R=301]


Discuss: Improvements to the goniometer definition / scan definition interface

As a user of nexgen the interface around call_writers and the goniometer and scan definitions is a bit confusing. Particularly:

The starts, ends and increments specification in the goniometer dictionary does not give enough information to fully describe a scan e.g. a grid scan needs to know which axis we're scanning over first and whether we're snaked
The scans I provide do give this information but I still have to provide the start, end, increment too even if I provide a scan
I appreciate that a oscillation scan is needed at the nexus file level but I shouldn't need to create/specify one myself
Using classes rather than dictionaries leaves less room for error

As an example I would suggest something like:
@dataclass
class AxisDefinition():
    name: str
    depends_on: Optional[AxisDefinition]
    vector: Point3D
    type: MovementTypeEnum
    unit: pint.unit.Unit
    offset: float
    initial_position: float

@dataclass
class Goniometer():
    axes: List[AxisDefinition]

    def __post_init__():
        #Some validation here that geometry actually makes sense

def write_file(gonio: Goniometer, scan: scanspec.Spec, ...)
      # Note scan should only contain axes that are moving, otherwise AxisDefinition.initial_position assumed constant

More than happy to discuss other ideas though

It's somewhat a balance between conciseness and the complete generality of the NX definitions, but I think it can be made to align with both.

scanspec

Is?

scanspec

Is?

https://github.com/dls-controls/scanspec
Is this?

Sorry, yes, that.