[JOSS Review]: Use entry point for getting started

Summary
Instead of requiring users to manually download a folder of data and a script from the repository, develop a simple command-line interface and a test or setup console script which automates this process.
Detailed design
A command such as $ reho setup would download (or copy from the installed package) the required data and scripts to the current folder and then execute them.
Notes and comments
No response

Thank you for this suggestion. Entry points for test have been added.
https://github.com/IPESE/REHO/commit/4a63b03aec4f85ae097582e4bd1ab2c3b5d03e0c
The "Checking proper installation" section of the documentation has been updated accordingly.
https://reho.readthedocs.io/en/main/sections/5_Getting_started.html#checking-proper-installation

Entry points consist of:
reho-run-test
reho-plot-test
reho-examples-test

and allow to verify the proper installation of REHO and that all examples are running (https://github.com/IPESE/REHO/commit/3860931485cd3de224461d0d6f58c16d82d498af)


#120 removed log4j.properties

Please, release a new version without this file.

Thanks for this change.


Switching master to use GO "long long" instead of "int64_t"

This is already in dtk-3.0.

Codecov Report

Merging #484 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #484   +/-   ##
=======================================
  Coverage   96.09%   96.09%
=======================================
  Files         118      118
  Lines        8792     8792
=======================================
  Hits         8449     8449
  Misses        343      343

Impacted Files
Coverage Δ

packages/Interface/test/tstFortran_API.f90
97.69% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06dab06...19edc07. Read the comment docs.


Impact
cxd32_uart
Testing
ci

[Experimental Bot, please feedback here]
No, this PR does not fully meet the NuttX requirements. While it provides some information, it lacks crucial details and depth in several areas.
Here's a breakdown of the missing information:

Summary:  While it mentions using a small lock, it doesn't explain why this is necessary. What problem does it solve? What are the benefits? It also needs to specify how the change works.  What big lock is being replaced? What small lock is being used?  What code is modified? Finally, it needs to link related NuttX issues if applicable.

Impact: The PR only mentions cxd32_uart, which is presumably the affected driver. However, it needs to explicitly answer all the impact questions (user, build, hardware, documentation, security, compatibility) with "YES" or "NO" and provide descriptions where necessary.  Just stating cxd32_uart doesn't tell us anything about the impact.  Does this change the driver's API?  Does it require board configuration changes? Does it affect other drivers?

Testing: Simply stating "ci" is insufficient. The PR needs to specify the actual build hosts and targets used for testing. It also needs to provide meaningful testing logs before and after the change, demonstrating the issue the change addresses and verifying that the change fixes the issue.  "ci" implies Continuous Integration, but the actual test environments and results must still be reported in the PR.

In short, the PR needs to be significantly more detailed and explicit to meet the NuttX requirements.  It should clearly explain the motivation, implementation, and impact of the change, and provide verifiable testing results.

@hujun260 please fix the compiler error.

@hujun260 please fix the compiler error.

ok


Feature allure test results views (#1)

Hi, guys!
Due to some reasons existing Tests statistics functionality does not suit us (it's our custom test framework problem with generating valid test result data when executing tests in parallel), but Allure reports are generated correct.
So I did this PR with implemenation of Allure report results parsing (allure-report.zip is generated with help of 'Allure Jenkins Plugin') and generating grid, chart and trend based on new data source.
mvn spotless:apply - done
mvn verify - pass with no errors
Generated hpi file is installed on local Jenkins, in general it works fine (picture with an example attached below)

PS
Also I did few improvements in allure views, which could be usefull in existing test views:

in allurestatistics.jelly added 'if' based on job.isBuilding() - if true, then build row is blinking
in AllureTrendChart and AllureUtil used job.getLastCompletedBuild() - that also improves statistics when Dashboard is build during some builds are building (and no test results exists yet).

@TobiX please, have a look once you get a chance. Thank you.

Is there a reason this should live in the core dashboard view plugin? AFAICS, this uses published extension points, so I'd suggest to put this into a new plugin. See https://www.jenkins.io/doc/developer/publishing/requesting-hosting/ on how to get a new plugin into the Jenkins update center.
Another tip: Using server-side rendered charts is deprecated, it would probably be a good idea to use ECharts for new charts instead (See https://github.com/jenkinsci/echarts-api-plugin#echarts-jenkins-plugin - which reminds me that I need to convert the charts here also...)


Question : Carousel Vertical Orientation?!

is there any way to use Carousel with Orientation="Vertical" (images list from top to bottom)??

Nice feature. Could you explain more what will be the disposition from the layout point of view? How many items do you want to show, for example? Maybe you can attach a screenshot?


Update requirements to latest versions of equests and nest-asyncio

Updated requirements.txt and pyproject.toml to latest versions of requests and nested-asyncio and built a pip wheel which I installed in a local project that uses this module, script ran just fine with the updated versions of these two modules 🙂
Thanks Ed for putting this repo out there is was EXACTLY what I was looking for, doing lots of requests to Rainforest to pull product data and this perfect for the job!

Hey Ed thanks! Yes I will definitely let you know if I have other things to suggest. When will this update show up in PyPI, if you know not sure what the publication to PyPI process looks like!
-Mike

On Oct 22, 2024, at 9:42 AM, edjones84 @.***> wrote:
Thanks Michael, this looks good! Glad the repo is of use to you, happy to discuss future improvements.
—
Reply to this email directly, view it on GitHub https://github.com/edjones84/hyper-requests/pull/1#issuecomment-2429482497, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3VEUJBOWSWWSCP5COWDDE3Z4ZP5PAVCNFSM6AAAAABQMPYZASVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRZGQ4DENBZG4.
You are receiving this because you authored the thread.


bumb libsqlite3-sys

This has already been done on the 0.7-dev branch: https://github.com/launchbadge/sqlx/pull/2094

Oh, perfect! Thanks.


fix: key frame extraction dev-1513

Issue Number: DEV-1513
Pull Request Checklist
Basic Requirements
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix: represents bug fixes
[ ] Refactor: represents production code refactoring
[ ] Feature: represents a new feature
[ ] Documentation: documentation changes (no production code change)
[ ] Chore: maintenance tasks (no production code change)
[ ] Style: styles updates (no production code change)
[ ] Test: all about tests: adding, refactoring tests (no production code change)
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Does this PR change client-test-data?

[ ] Yes (don't forget to update the JS-LIB team about the change)
[x] No

Other information
This PR contains fixes which prevent the key frame extraction and matrix file creation of the two files:
https://github.com/dasch-swiss/4124-xmlperformance-testdata/blob/main/bitstreams/0.1.mp4
https://github.com/dasch-swiss/4124-xmlperformance-testdata/blob/main/bitstreams/100.mp4
Both files suffer from two different bugs:

Fixes processing of very short moving images (0.1.mp4)
The file is too short for any frame to be extracted with the previous implementation which assumed at least five keyframes to be extracted. Change the script to start extracting keyframes at time unit 0, i.e. the beginning of the file and use the first extract frame as the start of the matrix instead of a later possibly non existing one.

Fix rounding error in calculation of number of matrix files to created (100.mp4)
For some reason the calculation of the number of matrix files was rounded from 0.8... to 2 where the next bigger integer should be 1

Before merging I should probably remove the huge .mp4 from the test_data folder as @jnussbaum pointed out to me. Keeping them for now for a convenience for our reviewers.

in the PR title, "DEV" should be all-caps and in parentheses :)

LGTM, jsut a minor remark: you added test data but no test, is that correct? Would it be possible to add a test for the 2 issues?

I will remove the "test_data/*.mp4" files before merging. I did not add any tests because:

There where no test present for it which I could easily extend.
This is a more elaborate workflow and unit testing bash scripts is very hard to do.


Added pub sub example

Description
Add support for appcallback and pub-sub example.
Issue reference
This PR will close: #17
Checklist

[x] Add appcallback.proto
[x] Code compiles correctly
[x] Implement AppCallback server for subscription
[x] Create Publish sample
[x] Add/update documentation
[x] Add convenient layer for AppCallbackServer
[x] Fix clippy/lint warnings
[x] End-to-end tests passing

@rylev Thank you for your comments.
For appcallback, I was trying to do something similar to client.rs where the trait DaprInterface provides a convenient abstraction on top of DaprClient trait (generated from proto). However, in this case since an application is responsible for providing server implementation as opposed to just allowing pass through to API calls, I am not sure how to approach this. Do you have any pointers on how to go about this?

@youngbupark This PR is ready to be reviewed. Thanks


⚠ ClamAV has degraded performance

In 07814b7, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 80 ms

Resolved: ClamAV performance has improved in 1a3d75f after 11 minutes.


Issue with progress color on wave

I noticed that sometimes the progress image has the wave and background color switched... after many test and research, I had to add in JustWave.class right after the imagecopy, this :
imagepalettecopy($this->progressImg, $this->waveImg);
(without this, sometimes both palette were not identical, messing with the imagecolorset).
hopefully it will help

Thank you very much for noticing. The issue has been corrected.


[BUG]Unexpected container offset in header

Information

Apktool Version (apktool -version) - 2.10.1_20241110
Operating System (Mac, Linux, Windows) - Windows 11
APK From? (Playstore, ROM, Other) - ROM
Java Version (java --version) -  <IP_ADDRESS>

Stacktrace/Logcat
"Exception in thread "main" java.lang.RuntimeException: java.util.concurrent.ExecutionException: com.android.tools.smali.dexlib2.util.DexUtil$InvalidFile: Unexpected container offset in header
at brut.androlib.ApkDecoder.decode(SourceFile:0)
at brut.apktool.Main.main(SourceFile:0)
Caused by: java.util.concurrent.ExecutionException: com.android.tools.smali.dexlib2.util.DexUtil$InvalidFile: Unexpected container offset in header
at java.base/java.util.concurrent.FutureTask.report(FutureTask.java:122)
at java.base/java.util.concurrent.FutureTask.get(FutureTask.java:191)
... 2 more"
Steps to Reproduce

apktool  --use-aapt1 -b -p
apktool  --use-aapt1 -d -p

Frameworks
If this APK is from an OEM ROM (Samsung, HTC, LG). Please attach framework files
(.apks that live in /system/framework or /system/priv-app)
APK
If this APK can be freely shared, please upload/attach a link to it.
https://cloud.mail.ru/public/WVtg/vofudoRVp
Questions to ask before submission

Have you tried apktool d, apktool b without changing anything? Yes
If you are trying to install a modified apk, did you resign it?
Are you using the latest apktool version? Yes

After parsing the application again, this error occurs. Everything comes together the first time. An error occurs if you edit smali. But apktool 2.93 coped with all the tasks.

Tracking upstream - https://github.com/google/smali/issues/80


Marathon SD: Add __meta_marathon_port_ordinal

This label was added in:
https://github.com/prometheus/prometheus/pull/2865/commits/d7f8e227a80b0ea3f652f51d4a5e1afa3aeb092e

Can you put this change against the next-release branch please?

@brian-brazil: My bad, I intended to. Will rebase locally.

Superseded by https://github.com/prometheus/docs/pull/775


Display deprecation version at top-level.

This should (hopefully, I can't get the cargo make command working) display the deprecation version at the top level (without having to hover) replicating the behaviour of the current site.

The deprecation warning is added yet, but the version is not displayed. Just was an styilistic choose. I think that currently there is a padding problem:

I think that the best first issue to resolve should be that you could properly set the development environment. What are the problems that you're experiencing trying to execute cargo make? Maybe we need to update the CONTRIBUTING.md file first (see the Setup section).

I think it's mostly to do with Windows / PowerShell.
The single speech marks in the commands were throwing errors, and I was able to amend them locally just to get it working somewhat. Will add more details when I'm back at my personal laptop.

The deprecation warning is added yet, but the version is not displayed.

Yeah, the PR was just to bring in line with existing site. Mostly an excuse for me to tinker with the code 😅
I don't mind the current approach, providing it's accessible.

OK, so... can we close this?


Error Line 289 when trying to load plugin (Maya 2019)

Can't load the plugin in Maya 2019. I get this error when I try:
// Error: file: C:/Program Files/Autodesk/Maya2019/scripts/others/pluginWin.mel line 289:  (glTFExport) //  // Warning: file: C:/Program Files/Autodesk/Maya2019/scripts/others/pluginWin.mel line 289: No initializePlugin() or initializePlugin2() function

I am currently getting the exact same error.

Hey guys.  Thanks for opening this issue.  I was not able to reproduce this on Maya 2019 for Windows ( Cut ID:<PHONE_NUMBER>15).  Some things we can try to gather more info might be:
Can you load the plugin with this MEL command?  If not, what's the error in the script editor:
loadPlugin "glTFTranslator"
Does running an export via Python only work?  Here's a Python test to run:
import glTFExport    glTFExport.export(r"C:\Temp\test.glb", resource_format='bin', anim='keyed', vflip=True)

Hey @ryanreptoid and @WillemvdPijl.  Thanks for opening this issue.  I was not able to reproduce this on Maya 2019 for Windows ( Cut ID:<PHONE_NUMBER>15).
Make sure you followed the instructions correctly in the README for installing the plugin.  If you are trying to browse to the plugin through the Plug-In Manager, then make sure you are loading the glTFTranslator.py and NOT glTFExport.py.  That was the only way I was able to reproduce that error you pasted into your comment.
If it's still not working, some things we can try to gather more info might be:
Can you load the plugin with this MEL command?  If not, what's the error in the script editor:
loadPlugin "glTFTranslator"
Does running an export via Python only work?  Here's a Python test to run:
import glTFExport    glTFExport.export(r"C:\Temp\test.glb", resource_format='bin', anim='keyed', vflip=True)

I'm pretty sure this was user error trying to load the plugin.  Closing for now.  Please reopen if this is still a problem.

Warning: file: E:/Autodesk/Maya2019/scripts/others/pluginWin.mel line 910: Could not load E:/Autodesk/Maya2019/plug-ins/mtoa/2019/plug-ins/mtoa.mll as a plug-in //

Warning: file: E:/Autodesk/Maya2019/scripts/others/pluginWin.mel line 910: Could not load E:/Autodesk/Maya2019/plug-ins/mtoa/2019/plug-ins/mtoa.mll as a plug-in //
when i tring to load mtoa.mll , it has this warning,wish for help


AppVeyor build broken

The AppVeyor build is broken:
Build started
echo System architecture: %PLATFORM%
System architecture: x64
appveyor DownloadFile "http://ml.ignorelist.com/wodi/8/wodi%WODI_ARCH%.tar.xz" -FileName "C:/wodi%WODI_ARCH%.tar.xz"
Error downloading file: Unable to connect to the remote server
Command exited with code 2

apparently because Wodi is no longer available.
@fdopen: any thoughts on the best way to get the Windows CI working again without Wodi?

Fixed by #298.


Added ChangePrice endpoint

Added ChangePrice endpoint (I know this is inconsistent naming, just following the display for the api call in the assignment)

One bug that still needs to be fixed before merge: when calling /api/GetCart/{id}, it returns the stock alongside quantity in the cart. This is because the ModelToDTO for CartItems uses the ProductDTO as the base

One bug that still needs to be fixed before merge: when calling /api/GetCart/{id}, it returns the stock alongside quantity in the cart. This is because the ModelToDTO for CartItems uses the ProductDTO as the base

What's that got to do with the ChangePrice? Create a new issue and/or pr.


Add Plan block for the control plane VMs to the example Terraform configs for Azure

What this PR does / why we need it:
Problem Overview
If a VM is using an image that comes from the Azure Marketplace, the VM must have a Plan block defined and populated, otherwise, provisioning fails with the following error:
│ Error: Code="VMMarketplaceInvalidInput" Message="Creating a virtual machine from Marketplace image or a custom image sourced from a Marketplace image requires Plan information in the request. VM: '<redacted>'."

This wasn't a problem before because we only supported Ubuntu until #2266, and Ubuntu doesn't require Plan to be specified.
Problem Statement
Depending on where the image is coming from, the Plan block:

MUST NOT be preset if the image is a built-in Azure image (i.e. not coming from the marketplace)

You can't provide null or empty strings, the block must be omitted entirely
Ubuntu and CentOS are those images in our case

MUST be present if the image is coming from the marketplace

RHEL, Rocky Linux, and Flatcar are images coming from the marketplace

We need to make Terraform to omit the Plan block if OS is Ubuntu or CentOS, and populate the block if it's an image coming from the marketplace.
Solution
This is not easy out of the box with Terraform. I decided to utilize Dynamic Blocks since this seems to be the only way you can dynamically set or remove a block.
To make Dynamic Blocks work, the object must be iterable, i.e. you can't use a simple object, you have to use a list or a map.
The image_references variable has been changed:

Information about the image is moved to a new nested object (image)
A new nested object (plan) type of list is added with information about the Plan

If a Plan is not supposed to be used, the list is empty
If a Plan is supposed to be used, the list must contain ONLY ONE Plan to be used

We have no validation for this, but I don't think anyone should provide more than one Plan

This approach seems to integrate very well with the dynamic Plan block.
What type of PR is this?
/kind bug
Does this PR introduce a user-facing change? Then add your Release Note here:
NONE

Documentation:
NONE

/test pull-kubeone-e2e-azure-default-install-containerd-v1.24.3
/test pull-kubeone-e2e-azure-centos-install-containerd-v1.24.3
/test pull-kubeone-e2e-azure-rhel-install-containerd-v1.24.3
/test pull-kubeone-e2e-azure-rockylinux-install-containerd-v1.24.3
/test pull-kubeone-e2e-azure-flatcar-install-containerd-v1.24.3

/test pull-kubeone-e2e-azure-default-install-containerd-v1.24.3
/test pull-kubeone-e2e-azure-centos-install-containerd-v1.24.3
/test pull-kubeone-e2e-azure-rhel-install-containerd-v1.24.3
/test pull-kubeone-e2e-azure-rockylinux-install-containerd-v1.24.3
/test pull-kubeone-e2e-azure-flatcar-install-containerd-v1.24.3

/test pull-kubeone-e2e-azure-centos-install-containerd-v1.24.3
/test pull-kubeone-e2e-azure-flatcar-install-containerd-v1.24.3

/test pull-kubeone-e2e-azure-flatcar-install-containerd-v1.24.3

/test pull-kubeone-e2e-azure-flatcar-install-containerd-v1.24.3


Separation of privileges

#608 and prior work introduces RBAC support for KubeVirt.
In order to make it more secure we want to use different ServiceAccounts for different components.
This issues is about introducing them.

We have some baseline separation, thus closing this bug.
If needed then we can reopen a more specific one.


Owl-Stage width increase to huge width px.

Hello, I am using this for my Liferay website. I have this working perfectly in my Liferay Portlet but one thing. When the window screen size decrease 767px or less I notice Owl-Stage width generate to 23kPX. I can't figure out why? How do I fixed this bug?

I fixed it. For any future personnel who might run into something similar. Just customized the Media Queries to exact window.

Which CSS files did you edit?


Revert incorrect remove of cmake_generator support.  ...

Only windows msvc default cmake_generator are removed.
Windows mingw and cygwin cmake_generator default are kept.

Coverage decreased (-0.02%) to 76.93% when pulling b9789f31d51a1bd07b5d629d36d3943c26bd9892 on xpol:master into a19af6d438247812e07528a1b18781d7f04863eb on keplerproject:master.

Coverage decreased (-0.02%) to 76.93% when pulling b9789f31d51a1bd07b5d629d36d3943c26bd9892 on xpol:master into a19af6d438247812e07528a1b18781d7f04863eb on keplerproject:master.

Thank you!


Please publish master

I'm updating our dependencies and are getting the following warning after updating imagemin to v6.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
Current version of img-loader package.json:
https://github.com/vanwagonet/img-loader/blob/25c4e7af11a7759647e3b846275b19c84b099e14/package.json#L31
Master version  of img-loader package.json:
https://github.com/vanwagonet/img-loader/blob/9bab77b6c52e01bebd59d8196a62b9ef848569ae/package.json#L31

Sorry about that. Published 3.0.1.

Nice and fast reply!


[SPARK-39165][SQL][3.3] Replace sys.error by IllegalStateException

What changes were proposed in this pull request?
Replace all invokes of sys.error() by throwing of IllegalStateException in the sql namespace.
This is a backport of https://github.com/apache/spark/pull/36524.
Why are the changes needed?
In the context of wrapping all internal errors like asserts/illegal state exceptions (see https://github.com/apache/spark/pull/36500), it is impossible to distinguish RuntimeException of sys.error() from Spark's exceptions like SparkRuntimeException. The last one can be propagated to the user space but sys.error exceptions shouldn't be visible to users in regular cases.
Does this PR introduce any user-facing change?
No, shouldn't. sys.error shouldn't propagate exception to user space in regular cases.
How was this patch tested?
By running the existing test suites.
Authored-by: Max Gekk<EMAIL_ADDRESS>Signed-off-by: Max Gekk<EMAIL_ADDRESS>(cherry picked from commit 95c7efd7571464d8adfb76fb22e47a5816cf73fb)
Signed-off-by: Max Gekk<EMAIL_ADDRESS>

Merging to 3.3. Thank you, @HyukjinKwon and @cloud-fan for review.


soc: arm: xilinx_zynq7000: Re-organize SoC data and init code

Re-organize the Zynq-7000 SoC family/series/model/device tree configuration data so that:

Board definitions can distinguish between the single-core (XC7ZxxxS)
and dual-core (XC7Zxxx) ARM Cortex-A9 models. Further descriptions
of on-chip resources, in particular relating to the programmable logic
capabilities if support of this functionality is to be implemented,
can be added at a later time.
Separate SoC initialization code exists for the two series, so that
the init code of the XC7Zxxx series can consider SMP while the init
code of the single-core XC7ZxxxS series doesn't have to.
Device drivers which don't have to distinguish between the single-
and double-core series of the SoC family can use a common configuration
item whenever the pre-processor is used to enable Zynq-7000-specific
code.
The "cpus" node is removed from the device tree at SoC level and is moved
to the respective board's device tree instead. This shift prevents the need
to have a separate SoC device tree for the single- and dual-core Zynq models,
as the only difference between those files would be 1 vs. 2 CPU cores. While
the different models within the Zynq-7000 series differ when it comes to I/O
pin count and programmable logic resources, the smaller, single-core XC7ZxxxS
models have exactly the same peripheral feature set as the larger dual-core
XC7Zxxx models.

The following other components are affected by this change:

Xilinx UART driver
Xilinx GEM Ethernet driver
QEMU Cortex-A9 board defconfig & dts files
Zynq-7000 dts file
The required modifications of these components are contained in this package.

Codecov Report

Merging #40314 (9886bdc) into main (a612fbd) will increase coverage by 0.50%.
The diff coverage is 64.22%.

:exclamation: Current head 9886bdc differs from pull request most recent head 7095d00. Consider uploading reports for the commit 7095d00 to get more accurate results

@@            Coverage Diff             @@
##             main   #40314      +/-   ##
==========================================
+ Coverage   50.61%   51.12%   +0.50%
==========================================
  Files         602      604       +2
  Lines       70305    70771     +466
  Branches    16183    16298     +115
==========================================
+ Hits        35586    36181     +595
+ Misses      28951    28641     -310
- Partials     5768     5949     +181

Impacted Files
Coverage Δ

include/net/net_pkt.h
85.94% <ø> (ø)

include/net/socket.h
100.00% <ø> (ø)

kernel/poll.c
82.07% <0.00%> (+0.56%)
:arrow_up:

subsys/bluetooth/host/gatt.c
8.69% <ø> (ø)

subsys/net/ip/igmp.c
33.33% <0.00%> (ø)

subsys/net/l2/ieee802154/ieee802154_frame.h
0.00% <ø> (ø)

subsys/net/lib/dns/mdns_responder.c
23.18% <0.00%> (ø)

subsys/net/lib/sockets/sockets_tls.c
0.74% <0.00%> (-0.03%)
:arrow_down:

subsys/net/ip/icmpv6.c
29.90% <12.50%> (ø)

subsys/net/ip/ipv6_nbr.c
33.07% <31.48%> (+0.23%)
:arrow_up:

... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d17a4b...7095d00. Read the comment docs.

Oh well, looks like re-basing the branch has gone completely wrong again.


Feature/planning incomes

Fixes #23
Proposed Changes

Add model for income log
Add context functionality to create and update an income

Pull Request Test Coverage Report for Build 161

5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 88.194%

Totals

Change from base Build 158:
0.4%

Covered Lines:
127

Relevant Lines:
144

💛  - Coveralls


Server crash with latest client (in testbed)

When testing PR #7, I get the following error in the testbed, running the server in --enroll mode and the latest client on a Pixel 4a:
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x5dbce7]

goroutine 16 [running]:
main.parseAttestEK(0xc000136c30)
	/root/src/protocol.go:98 +0x1a7
main.registration(0xc000013860?, 0xc0000495d0)
	/root/src/protocol.go:115 +0x113
main.ultrablueProtocol(0xc0000a0480?)
	/root/src/protocol.go:250 +0xde
created by main.getConnectionState
	/root/src/state.go:95 +0x185

The last message I see on the Android side is Getting EkPub and EkCert.
This does not happen when running the server outside of the testbed. My guess is that this comes from the fact that I don't have clean build of the testbed, so my server and client are out-of-sync.
However, the server should not crash, even if the client sends garbage data. We should investigate this crash and makes sure the server handles the situation properly.

This is due to the fact that virtual TPMs does not ships EK certificate, and I din't checked for it.

Please keep your mkosi.output somewhere so we can investigate this, is there a way you can send it to me ?

Confirmed that it crashes even with a clean build.


DataTable Documentation is extremely confusing

Most people will be getting their data from a REST API through HTTP.  There needs to be information on how this ties into the table component.  What is the DataSource class?  Where is the documentation on it?  Currently there is not enough information provided to the end user to connect these dots.

PR for this in progress #5766

I do agree there should be more documentation on this issue. If you are looking for how to implement server data with data-table this an example how you replace the ExampleDatabase class :
`export class ExampleDatabase {
/** dataChange stores the data for the cdk/md tables */

dataChange: BehaviorSubject<UserData[]> = new BehaviorSubject<UserData[]>([]);
get data(): UserData[] { return this.dataChange.value; }

/** Make sure to pass your http service to the constructor of the export class**/
constructor(private studentService: StudentService, private router: Router, private http: Http) {
    this.getStudents();
}

/** Your getter method for the class service **/
getStudents() {
this.studentService.getStudents().subscribe(
accountData => this.onLoad(accountData),
error => this.handleError(error)
);
}

private handleError(errorMessage: string) {
alert("Error: " + errorMessage);
}
/** Method adds server data into the dataChange **/
private onLoad(accountData) {
  let body = accountData;

/**You can  any method for looping through your server JSON response. I just use a for loop.*/
  for (var x = 0; x < body.count; x++) {
      const copiedData = this.data.slice();
      copiedData.push({ id: body.students[x].id, name: body.students[x].firstName + " " + body.students[x].lastName, username: body.students[x].username });
      this.dataChange.next(copiedData);
  }

}

}`

HTTP example is coming through soon. For more details on the implementation and background of the table, be sure to check out the cdk-table docs at https://material.angular.io/guide/cdk-table
If you have any suggestions on how the docs could be more informative or intuitive, please feel free to open up a PR that we can review and discuss.


Getting this to run without installing .NET 2.0

I had to just make the following change to get POLUtils to run in .NET4.0 (instead of installing .NET 2.0, yuck):

Create a file, called POLUtils.exe.config
Put this in the file:

<configuration>
  <startup>
    <supportedRuntime version="v4.0"/>
  </startup>
</configuration>

This is just a band-aid until someone actually goes ahead and ports this to a later version of .NET because I can't imagine this will be backwards compatible forever. I've only tested exporting item's icons, but I imagine not all functionality works in .NET 4.0 without porting the code over. If this doesn't work for you, install .NET 2.0, I guess.

Updated it to .NET 4.8, please open another issue if you find anything that broke.

Will do. Thank you.


ARROW-13191: [Go] allow external schema in ipc readers

This slightly changes the newReader to accept passed in schema as
I believe is the intent.
It also removes the existing behavior where the newReader uses a passed
in schema merely for compatibility checking.
I didn't augment tests here as there doesn't appear to be any existing
reader tests, and I didn't see an obvious place to look for canonical
messages for validating message behaviors.

And now I try to work out arrow testing. :)

@zeroshade do you have thoughts here?  Being able to pass in an external schema is useful in some contexts.
Would it be workable to have the following logic:
if (passedInSchema) {
  message = readMessage()
  if (message.isSchema) {
    validate(message.schema, passedInSchema)
    message = readMessage()
  }
}

Make sense?

@emkornfield For your suggestion, you're saying to put that logic in the next() function?
It could work, though I dislike having that check on every time it pulls the next message. What is the actual use case for passing in an external schema? Should we just expect that if there's an external schema passed in that there shouldn't be a schema message? This also ties a bit into the discussion going on in the Dev mailing list about dynamic schema changing. If we want to allow changing schemas we'd have to check on each message whether or not the message was a schema message to indicate a new schema for the subsequent messages. Currently the streaming format is defined as always having a schema message followed by the rest, the only case I can think of for passing in an external schema would be to change readers part-way through the same stream which would indicate that there's no expectation of a schema message.
Unless there's a context/use case I'm not thinking of (you'd know better than I @emkornfield), I don't like the idea of putting a check in the next function for this, but the only other thing i can think of would be to implement a way for the reader to essentially queue up the message it read in the case that it's not a schema message so that the next call to next() returns that first message before continuing to read from the stream, which I like better than checking on every call to next.
So i kind of rambled a bit there, but I think that made sense?

Unless there's a context/use case I'm not thinking of (you'd know better than I @emkornfield), I don't like the idea of putting a check in the next function for this, but the only other thing i can think of would be to implement a way for the reader to essentially queue up the message it read in the case that it's not a schema message so that the next call to next() returns that first message before continuing to read from the stream, which I like better than checking on every call to next

We have an api in BQ that returns a schema and then a stream of records separately.  So its not so much replacing the schema as an easy way to provide a new one.
Recently, we added in a returned schema on the first ReadRows response.  @shollyman would this make plumbing easier or obviate this change?

The issue is the difference in abstractions.  In other languages, there exists a concept of a single master "reader" which is schema aware, and which to which we supply a series of independent recordbatches which can then be decoded.
In java, the construct looks like like VectorSchemaRoot and VectorLoader, where the schema information is held by the root and the loader is for managing the incoming set of batches.
In python, we've used the pyarrow.Table and from_batches() to similar effect, though I see there's also a pyarrow.ipc.read_record_batch which similarly accepts a schema and message.
I'm not finding a similar abstraction in the Go library.   My initial thought was, based on the existing WithSchema option, that an ipc.Reader could be used as a lightweight reader we instantiate for each batch.  But the problems with how to deal with schema behavior seems to indicate a different construct is warranted.  Should there be a BatchReader or similar construct that can retain a schema, and methods appropriate for passing in messages?

@shollyman any thoughts on were you want to take this?

@shollyman is this still something we should be looking at?

What is the status of this PR? cc @zeroshade @guyuqi

Closing this very old PR, seems like the flight changes made the necessary augmentations to process.


Release candidate 1.7

Description of PR
This PR adds the highlights for the new release, adds a deprecation warning for require_variable(), removes compute_bias() previously marked as deprecated, and adds a test.

Published on test-pypi successfully, see https://test.pypi.org/project/pyam-iamc/1.7.0rc1/


misspelling issues in zh-cn doc

https://docs.astro.build/zh-cn/core-concepts/astro-components/#%E7%BB%84%E4%BB%B6%E5%8F%82%E6%95%B0
In this paragraph:

Astro 组件可以定义和接受参数。 然后，这些参数可用于组件模板以呈现 HTML。 可以在 frontmatter scsipt 中的 Astro.props 中使用。

frontmatter scsipt should be frontmatter script

Thanks for pointing this out @hanxiao790, would you like to make a PR making this change? It's a way for us to acknowledge your contribution since GitHub will pick up your profile picture and add it to our Getting Started page's Face PIle. 🙌
If not, let me know and I'll work on it!

@Yan-Thomas Thanks! This is just a minor spelling error, you fix it is OK.


provision.sh doesn't work

I need to deploy splash in an environment without docker, but I have encountered a problem according to the tutorial. It will report an error when executing the installation script. How can I solve it?
Executing command: prepare_install sed: -i: No such file or directory sed: /etc/apt/sources.list: No such file or directory Command failed (exitcode: 1), exiting...

The manual installation instructions are for Ubuntu 16.04.
If you are using a different distribution, you have these options:

Install Docker.
Switch to Ubuntu 16.04.
Figure out how to reproduce what the manual installation scripts do in your distribution.

I strongly suggest option 1 :slightly_smiling_face:


Allow excluding some paths from scanning

terrascan version: v1.15.2
Operating System: Linux_x86_64

Description
Terrascan should allow explicitly specifying files/directories to exclude from scanning.
One of terraform config dependency modules (happens to be terraform-google-workload-identity, but doesn't really matter) comes with a bunch of examples in its directory that show up under .terraform/<my obj name>-workload-identity/examples/acm-terraform-blog-part3/config-root/wordpress-bundle.yaml.
Some of these example files don't pass terrascan scans, which is expected. We also really have no control over examples' contents, so end up getting lots of terrascan findings in these /examples/ subdirectories under .terraform.
While the underlying issue in this case is including examples in the module distribution, a reasonable solution is to complement the -d flag that specifies directories to consider with another one to provide the list or pattern of directories to exclude from scan.

Having precisely the same problem. The terrascan returns too many HIGH violations related to the example directory. And we really don't need the terrascan to scan on these dirs.

Any update? It's coming up to 2 years and this would be a great feature to have.


Upgrade Service Auto Restart is not taken into account

When I upgrade a service and I check option Auto Restart "Always", service keeping "never (Start Once)"

Useful
Info

Versions
Rancher v0.63.0 Cattle: v0.155.0 UI: v0.94.0

Access
localauth admin

Route
service.new

Duplicate of https://github.com/rancher/rancher/issues/3707. Verified fixed in v1.0.0-rc4

thank you :+1:


EntityStore.upsertMany should also have an update hook

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Performance issue
[X] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior
Currently EntityStore.upsertMany() does not use any pre-action hook like EntityStore.update() does with EntityStore.akitaPreUpdateEntity().
Expected behavior
It would be really helpful to also have such a hook for EntityStore.upsertMany(), like e.g. EntityStore.akitaPreUpsertMany().
What is the motivation / use case for changing the behavior?
I have to manually add an idKey before adding or updating Entities in the store, which I usually do within the hook methods, but can't do in this case.
I guess this is a quite common use case for the hook methods (like seen in #196 ), so maybe you could add this feature to a future version of Akita :-)
Environment

Angular version: 8.0.0

Thanks!
I am currently adding Akita step-by-step to a quite large Angular application. We had many cluttered and inconsistent custom StateServices all over the code base. Akita seemed like a perfect fit for our existing app, as it is similar to how we handled states before. It does not have such an immense influence on the whole app architecture like ngrx does. So Akita seems like the better fit for our use case. Thanks for open-sourcing it! So far its a breeze to use it 👍

You are crazy! Thank you so much! 👍

I just updated Akita to take advantage of this great addition. Unfortunately it turned out, that the moment at which the pre-action hooks are called, is too late to be used for adding the idKey to the entity. Akita is checking whether the entity already exists in the store by checking the new entities' idKey. In my case the idKey is still missing at the time of that check. Thus it always adds the entity and never updates it. Do you see any solution for this issue? I know you need to check which path to go. On the other side, I can't use the upsertMany-hooks as they are now :/

How can Akita check if the entity exists in the store?

What I meant was this check within upsertMany():

Yes, I know, that's my question. If we don't have the id, how we can check that it exists?

Yeah, you are right. Thats also what I meant. The point is, that the behaviour is different from the other methods. If I only update an entity, I can add the idKey within the hook and it works just fine. Sure, there you do not need to check, whether it already exists. Nevertheless, from an outside perspective it is unclear why it behaves differently.

That's a logical problem, sorry I couldn't help.

At least it would be helpful, if the docs would point out, that the hooks for upsertMany expect the idKey to be existant. In #196 you recommended using the hooks exactly for this use case. Now, for upsertMany it doesn't work like this.
Another solution could be, to have a different hook for upsertMany.
I think this is a legitimate point, isn't it?

to have a different hook for upsertMany

And how would you solve the isExists issue?

I mean, how you expect to use an upsert method when you can provide a way to verify whether the entity exists or not?

Maybe we can add through the options parameter the following:
for (const entity of entities) {
  const e =  options.beforeCheck(entity);
  const id = e[this.idKey];

  if (hasEntity(this.entities, id)) { }

Does it make sense?

Yes, it would solve the problem of adding a missing key :)
What's wrong with having a hook like akitaPreCheckEntity to be consistent with the current hooks?

Yes, just checked whether it would solve the issue. I will add it.

Yeah I'd like, for sure! I guess I can do that at sunday :)


Include correct header for malloc related functions.

The C malloc() functions require inclusion of stdlib.h
This fixes compilation on FreeBSD.

Coverage remained the same at 92.31% when pulling 2ce6748e79818cec82e604afaecd985741332a00 on ahacking:master into 9c3accb784d94d5fce1a2bc9b73486c0605ee80b on sass:master.

Thanks for the contribution. :+1:
I have left some comments, PTAL.

Moved <stdlib.h> to common header and rebased.

Coverage remained the same at 92.59% when pulling 5f6c802acf18c69a74c7a9b84d5c33321d433893 on ahacking:master into 11804177cabc5c5016976d4b0fcfc678ca562360 on sass:master.

@am11 Including <stdio.h> is correct.  Failing to include <stdlib.h> means malloc() (if not being defined fortuitously through some indirect include) will be treated as returning int which is wrong. It may still 'work' if you're lucky when sizeof(int) == sizeof(void*).
Taking the responsible approach when using malloc/calloc/free is to include <stdlib.h> as per the C standard. If we were including for example a Linux/glibc non-standard header like <malloc.h> then yes that deserves being surrounded in an #ifdefguard, but putting a platform specific guard for an expressly portable inclusion is a bad idea and just increases risk of bad things happening and also creates unnecessary maintenance.
I am finding that master of node-sass generates a Segmentation Fault with my app.scss. I have run the tests and whilst there is a timeout failure with the huge test,  there isn't a segfault, so my app.scss is triggering a regression (it works fine with 1.x). I haven't been able to determine where or what in the code is causing the problem yet but if I can isolate the cause I will open a separate issue.

@ahacking, thanks! :tada:
Regarding the issue, please open it in the issue tracker with steps to reproduce the error: Sass code, command you used to execute etc.

@ahacking, note that it could be due to the unsupported language features in the .scss file. Usually segfaults are due to LibSass code (but not necessarily).


[fix][test] Fix running ClusterMetadataSetupTest in IDE

Motivation
Running ClusterMetadataSetupTest fails in IntelliJ since the tests is invalid.
Modifications
Fix the test
Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.29%. Comparing base (bbc6224) to head (b192d7e).
Report is 693 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #23492      +/-   ##
============================================
+ Coverage     73.57%   74.29%   +0.71%
- Complexity    32624    34384    +1760
============================================
  Files          1877     1943      +66
  Lines        139502   146974    +7472
  Branches      15299    16191     +892
============================================
+ Hits         102638   109191    +6553
- Misses        28908    29356     +448
- Partials       7956     8427     +471

Flag
Coverage Δ

inttests
27.31% <ø> (+2.73%)
:arrow_up:

systests
24.37% <ø> (+0.05%)
:arrow_up:

unittests
73.66% <ø> (+0.82%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 653 files with indirect coverage changes


chore: added docusaurus documentation

I found the docs a bit hard to consume through github, so this is basically just a copy over from the readme to a more structured docusaurus page.
Only missing thing as far as I can tell is updating the social card and logo.svg.
Should be easier to maintain and update these docs too.
Preview:

The docs have been added to a subfolder, docs. You can read more about deploying with docusaurus here.

I'll maybe look into this in the future again, but for now I don't have the time.


no expand tab in question

Hello,
I just switched to alloy  from promtail, and started using this plugin.
Could you explain me the need to disable tab expansion in ftplugin/alloy.vim ?
Form me this is a style question that should be left to the plugin user, not a need of the file format. Or did I miss something ?

Hi, disabling tab expansion aligns with how the Alloy syntax formatter works (alloy fmt / alloy format), where it takes the opinionated stance that files should be tab indented, avoiding arguments around how many spaces to indent. Enforcing tabs for indentation also allows users to pick their own tab width.

Ok, makes sense if that's the formatter's default.
A bit surprising, while most of the tools/languages I use use spaces,  but I can live with that.


Linux build error when using glfw

On Archlinux I am getting the following error when compiling with HELLOIMGUI_USE_GLFW_OPENGL3.
/usr/bin/ld: external/hello_imgui/external/libglad.a(glad.c.o): undefined reference to symbol 'dlclose@@GLIBC_2.2.5'

I can fix this by linking with dl, but perhaps this should be fixed in the library directly:
https://github.com/pthom/hello_imgui/blob/4ae3507a96ef5483efe76ca5579c61be215f00df/src/hello_imgui/CMakeLists.txt#L108

Hi, thanks for letting me know! This problem did not occur on Ubuntu; anyhow, since the fix is harmless, I fixed in 6e5e420 (for both sdl and glfw).


redis_streams input: do not copy message body to metadata

Documentation on redis_streams input says that the body_key key from received entry is extracted as raw message. All other keys will be stored in the message as metadata.
https://www.benthos.dev/docs/components/inputs/redis_streams#body_key
This change should make behavior to confirm the documentation.
Also it will allow to log an entry metadata without logging the body (which can be too large to log) using following config:
pipeline:
  processors:
    - log:
        message: '${! meta() }'

Thanks in advance.

Looks good, thanks @citrin!


[Feature Request] World Interaction Single-Slot recipes

Hi! If it is not too much trouble, could you add this to your mod, it would be useful to me ;)

This doesn't seem like a world interaction recipe, what is the interaction if an item simply is changing?

In fact, if we're talking about interacting with the world, I'd personally consider something like "Ore+ Pikcaxe = Raw Material" or something like that. That would be nice, because when you have a bunch of mods, it's not clear whether a specific material is mined somewhere, or is in a dungeon, or whatever.


Compile snapshot_assembly with sdk root set in Xcode

Description
With the upcoming support for Apple Silicon ARM simulators, App.framework can no longer contain architectures for both iphoneos and iphonesimulator since they need to be build against different SDKs, but they can no longer be lipod together (lipo complains both binaries contain arm64 and fails).
Primarily this is a problem when building the debug stub framework:
https://github.com/flutter/flutter/blob/cb67513f29dbf7f41818c9eb8cc42d845e243fca/packages/flutter_tools/lib/src/build_system/targets/ios.dart#L106-L111
And in flutter build ios-framework that smush together plugin frameworks.

Output App.framework to different iphoneos and iphonesimulator directories - done with https://github.com/flutter/flutter/pull/69699.
Refactor the build system to take either the iphoneos and iphonesimulator SDK from Xcode instead of trying to guess from the architectures (to stop assuming x86 == simulator).  Use it for aot (this PR).
Remove lipoing from debug stub framework step and only use the requested iphoneos or iphonesimulator SDK, not for both.  Refactor flutter build ios-framework as needed (next PR).
Deprecate flutter build ios-framework --universal - https://github.com/flutter/flutter/pull/69720
Deprecate flutter build aot - https://github.com/flutter/flutter/issues/49562

This PR actually doesn't change any behavior, but I did steps 2 and 3 at the same time and the patch is too large to easily review.  Some of this will make more sense on the next PR.
Related Issues
Support https://github.com/flutter/flutter/issues/69334

😮 TIL you can quote multiple code lines' permalinks


REPO-4398: added proxy nginx.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


running gcc failed: fork/exec /usr/bin/gcc: cannot allocate memory

I'm trying to run it in a digital ocean droplet using Ubuntu 15.10 and when I'm getting the bot with the command
go get github.com/hammerandchisel/airhornbot/cmd/bot
Appears this message
running gcc failed: fork/exec /usr/bin/gcc: cannot allocate memory
Any idea why is this happening? I'm new on Go but very interested on learning more about it and your project seems like an excelent example.

Hi. This means you ran out of memory trying to compile. :( I would
recommend using a bigger droplet to compile. Then down sizing
https://www.digitalocean.com/community/tutorials/how-to-downgrade-digitalocean-droplets
On Sun, Apr 17, 2016 at 9:08 PM, Diego Garcia Mendoza <
<EMAIL_ADDRESS>wrote:

I'm trying to run it in a digital ocean droplet using Ubuntu 15.10 and
when I'm getting the bot with the command
go get github.com/hammerandchisel/airhornbot/cmd/bot
Appears this message
running gcc failed: fork/exec /usr/bin/gcc: cannot allocate memory
Any idea why is this happening? I'm new on Go but very interested on
learning more about it and your project seems like an excelent example.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/hammerandchisel/airhornbot/issues/7


Removing a check for infix expression element from specs2 test configuration creation

This pull request removes the check for ScInfixExpr from the test configuration for scala2 (see #155). This fixes a bug that prevents right-clicking and running the individual tests.
This is caused due to the element which is right-clicked will usually be the Literal identifier (i.e. "the test name"). An additional lookup for the parent ScInfixExpr is needed to get the actual test case element. This PR adds this lookup.
In addition, some APIs were tweaked to reduce the dependance on the Scala types.

Can one of the admins verify this patch?

Ok, this probably relates to the bug #168, relating to the finding of existing configurations. There's a check in BlazeScalaJunitTestClassConfigurationProducer which also checks for ScInfixExpr. I'll investigate more and update the bug with more information.

Merged internally, now to export to github.

Thanks!
On Thu, 30 Nov 2017 at 19:17 Chaoren Lin<EMAIL_ADDRESS>wrote:

Merged internally, now to export to github.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bazelbuild/intellij/pull/167#issuecomment-348257562,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABUIFwLwYnZ3tYH8NzH15N8tvcGlKj7Cks5s7uM-gaJpZM4QrUVg
.


Add layout for Book posture and supports dual-screen devices.

This adds a new layout for book postures, at the moment restricting the player on one half of the screen to avoid having controls too close to the hinge making them difficult to touch:

The left pane is currently left empty.
This PR also adds support for dual-screen devices (isSeparating == true and State == FLAT reusing TableTop and Book layouts to avoid drawing content over the hinge.

Updated the book layout with some information on the left half:

Note: screencapture is from a dual screen device and the black vertical spacer is positioned where is the hinge.


sync: up to v1.20.0

Details

https://github.com/goreleaser/goreleaser/releases/tag/v1.20.0
https://github.com/goreleaser/goreleaser/releases/tag/nightly

fixed, v0.1.16


WIP Try efmt formatter

Tried https://github.com/sile/efmt formatter.
To discuss if we like this formatter more.
Minuses:

no max line limit (?)
2 lines between tests (!!)
it is in rust. Fast, but if we wanna add some formatting options (i.e. use one line instead of two) - we would have some fun time learning another language.

The old formatter link: https://github.com/WhatsApp/erlfmt
Do not merge, please. I am just trying to show the diff :)
Another formatter: https://github.com/esl/cets/pull/16
Emacs formatter with a rebar3 plugin: https://github.com/esl/cets/pull/17

Could close, it is PR for demo only.


Fix metric error for MAE, MSE, RMSE

shape error:
If eval_metric='mse', there will be a error message like:
ValueError: Shape of labels (128, 1) does not match shape of predictions (128, 10)

The reason is that the following lines in metric.py for MAE, MSE, RMSE fucntions:
check_label_shapes(label, pred, shape=1)

force label and pred have exactly the same shapes. While in this case, label is (128,1), pred is (128,10), it is broadcastable. Hence these checks should be removed.
Whether two ndarray's are broadcastable can be automatically checked by numpy, hence we do not need to add extra codes.
PS: This pull request also allows directly use eval_metrix=mx.metric.Accuracy() for model.fit().
MAE, MSE, RMSE are not calculated correctly:
The loss scales should not change with different batch sizes. The original implementation is not calculated correctly. The losses are increasing as the batch sizes decrease! And this bug has been fixed.

ive fix my MAE metric code long time, i thought its mine problem...


Compression method in layer dedup code in pulp_push plugin should be configurable

See method in compress plugin.
If its not specified we should fall back to:

method defined in compress plugin
gzip

Note, its not a priority - pulp currently supports gzip only

Pulp support is gone


RcManager watches pods and RCs instead of polling every 10s

This PR is essentially a replication manager rewrite that does the following:

Replication manager watches all pods and rcs.
Pods wake up their rcs through a reverse lookup based on namespace, label/selector matching.
Rcs that are still waiting on pod creates/deletes don't perform a full sync. This is achieved through the concept of expectations.
Even if it isn't time for a full sync, status.replicas is updated with each pod notification.
Replication manager retries updates to status.replicas.
Different rcs sync via concurrent goroutines. All but one of the RCs managing a single pod are ignored.

I just realized this is risky, we can't blindly assume the watch will transmit before our next poll. We need to actually update the store or keep track of what we've created/deleted till it shows up in the reflector.

That's an interesting observation. I have one idea:
Currently with each create/delete we also update RC status. So maybe we can create/delete pods only if the pods watch version is greater or equal to RC version? AFAIU that would mean that we must have noticed creation/deletion of pods from the previous run.
A nice property is that it's completely separate for each RC so this algorithm should not slow down anything.
Do you think it'd work?

The resource version comparison fix would probably work, but I want to avoid it for a couple of reasons (relying on etcd as a store, won't work with shards).
The tldr version of what I'm really trying to do is to get the watcher of pods to cause an rc sync when pods die, and get the rcs to handle their own syncing based on reported number of pods (for the normal reasons like spec.replica change) without needing a periodic poll (currently it polls every 5-10s, it will still have a periodic resync from the reflector but that will only happen ~60s). Ironing out some implementation details, expect a follow up pr soon.

This pr is hard to get in piecemeal, so I'm looking for feedback. I have solutions to the watch latency problem and how to allow pods to invoke corresponding rcs. I can elaborate if it isn't clear how I'm going to use these constructs in setting up twin informers.

I don't understand. Is the problem that your proposal have to be implemented in one big PR, or that there is a problem with the proposal itself?
I'd really like to move this forward.

So this should be mostly ready for primetime, waiting on @lavalamp for review. e2e passes and I still need to add a few unittests/think through corner cases, but for the most part it works to a degree that I'm satisfied with. Removing WIP.

I've seen a few places where we rely on status.Replicas (integration tests, kubectl stop -> so e2e etc) and it's relatively easy to just retry for a bit, so I've added that in. Can remove if reviewers prefer otherwise.
/cc @davidopp

I got about halfway through-- more later.

PTAL. the half that you reviewed y/day is where most of the logic lies, the rest of it is pretty simple :)

Mostly small stuff this time around. If you can run e2e, that'd be good. I also think we should add some testing for our controllers in test/integration but maybe that can come later.

Haha I already ran e2e ~3 or 4 times. We don't have an e2e that will catch latencies though, which is what will really happen if there's a bug in say, the expectations logic. the ttl will just expire and things will work. I plan to add something in follow up prs.

PTAL, fyi I also renamed replication_controller_utils to controller_utils because I plan to share it with the job controller.

LGTM, just a couple nits. Could you run & report master CPU usage for the e2e density/thrash tests (they don't run automatically)-- the latter should stress the replication controller code. This is a pretty high risk change so I just want to be very careful.

I ran density with 2 nodes and 30, 50 pods per node, it ran ok. currently spinning up a 30 node cluster to try the same. After some thinking, this is the potential negative impact of this PR (tldr is with a bad network we can create/delete replicas without reason and fail to update status.replicas, so anything tracking this very closely will fail):

Starting multiple rcs will result in pods being created in parallel, might lead to higher load (previously, each new rc was invoked serially)
If the same rc ever ends up in the syncHandler twice (reentrant rc), things will get weird. We use the work queue to prevent this.
There might be a lack of responsiveness in replica management, in some cases, as documented: https://github.com/GoogleCloudPlatform/kubernetes/issues/7369
Status.Replica updates can sometimes be slower, specifically, we currently retry for 100ms to update it, if these fail, subsequent pod notifications will sync it. For the last pod, it will remain inaccurate till the periodic resync every 30s (previously it would get fixed in ~5-10s).
Overlapping controllers will be ignored (previously we let them fight it out)
If the watch latency is high (>2m), the expectations will expire based on ttl and we might end up creating/destroying pods unnecessarily.
Dropped pod watch events will not be rectified till the pod resync (5m), previously these would rectify themselves every relist (5-10s)

The cpu usage for 2 nodes 30/50 pods wasn't alarming. will report with the more extensive test case when i have data.

Point 4 is the only one that concerns me-- are you sure that's possible? It updates the status every time the RC gets put in the queue? So it should get updated every time a pod changes.
Point 1-- I think the client is rate limited so I wouldn't worry about this.

yes, should get updated everytime a pod changes. If the rc creates 5 pods, the status.replicas should hit 5 on the fifth pod. If for some reason it fails on the sync from the fifth pod (becase of CAS or whatever), we won't get into the sync function for that rc again till the next 30s periodic resync for rcs.

If for some reason it fails on the sync from the fifth pod (becase of CAS or whatever), we won't get into the sync function for that rc again till the next 30s periodic resync for rcs.

You mean if writing the RC's status fails? Ah. IMO you should either do a proper GET/PUT loop, or reenqueue the RC in that case.

i have a get/put loop that times out in 100ms (https://github.com/GoogleCloudPlatform/kubernetes/pull/6866/files#diff-44bba2c68a6ea2b4ca0dbb7f4465828eR285). A requeue might be cleaner, but with many rcs will also take longer to fix itself. thoughts?

I think it's fine as is for the moment. Other things writing to replication controllers should be pretty rare.

There is a weird situation today that probably doesn't matter much but is worthy of mention. The get/put loop above will succeed but not insert the new rc back into the store. So the pod updates that happen between the successful status.Replicas update and the same status.Replicas watch event will try the same update with a stale rc, fail, perform the Get, and succeed.
If we requeued, they'd keep failing the update till the rc watch event.
The tradeoff here is n-failed updates till the rc watch event (requeue) or 1 failed update+1get per pod in the interim (retry). I think the latter is better, but might warrant a slight increase in that retry timeout. Thoughts?

I think the watch should be relatively fast compared to the speed at which this eats through its queue. I think a retry as per my previous comment should be OK for now, and what you have should be fine until you make a followup PR.
Coveralls is not very clear about what it doesn't like.
LGTM

Thanks for the review!

I think the watch should be relatively fast compared to the speed at which this eats through its queue.

I've seen watch latencies O(minutes) with 20 nodes and ~1000 pods, when I do something like delete all of them in one shot. I have logging that should surface such slowness, we can make iterative improvements.


This is awesome. Can we make this an NPM package?

hey @chitalian! Thanks for the suggestion. I suppose so, but unfortunately, I don't have time to work on that currently or in the foreseeable future.
I will leave this open in case somebody else would like to help with that.


STORM-1285 port backtype.storm.command.get-errors to java

STORM-1285
Please look at the implementation of getComponentErrors() since it simplifies the origin logic.

Minor comment. Looks good otherwise.

Thanks for reviewing. I address your comments.

+1. Build failure is in storm-hive, unrelated to this change.

Minor comment, +1 once addressed.

@abhishekagarwal87 @satishd
Thanks for the review. I addressed all of comments.


Implementing optimistic updates with McFly

I was trying to work through how to implement optimistic updates with McFly (Fluxxor has a very good example of why we would need this). The main problem is that McFly actions dispatch a single payload, while optimistic updates require actions to dispatch multiple payloads (example: addTodo dispatching ADD_TODO, ADD_TODO_SUCCESS, and ADD_TODO_FAILURE).
One possible approach is to implement those extra payloads (ADD_TODO_SUCCESS, ADD_TODO_FAILURE) as separate McFly actions. Then, in the top-level action (addTodo) you can (a) immediately return the optimistic payload (ADD_TODO) and (b) fire off an AJAX request that dispatches the extra payloads.
What do you think? Should we add documentation to the project about this? I was thinking maybe a link in the README to a wiki page, or we can add it directly in the README.

I think that implementing optimistic updates using separate actions is perfectly fine.
An other option would be to add a dispatch(action) method to the actions object. This way, an action method could call this.dispatch(action) whenever they want to dispatch something.

I think that implementing optimistic updates using separate actions is perfectly fine.
An other option would be to add a dispatch(action) method to the actions object. This way, an action method could call this.dispatch(action) whenever they want to dispatch something.


Partner Dashboard - Add Map of all Partner locations for a Partner

A partner can have many partner locations. Would be nice, when selecting the Partner and going to the Partner dashboard, to see them all on a map, and then allow the partner location to be selected for update / viewing.


Vickel: Watch bluetick1kennels.com

Vickel requests the watch of the watch_keyword bluetick1kennels\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

bluetick1kennels\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


Bug Report - Intermittent Screen Resolution Change Issue in GitHub Actions Workflow

Description
I'm encountering an intermittent issue with screen resolution changes in a GitHub Actions workflow running on macOS-latest. The problem seems to be related to VMWare Tools and Paravirtual devices, as indicated by the error message: "Device PreExisted [00000001000002c6] Apple Paravirtual device"

GitHub Actions runner: macOS-latest
failed run: https://github.com/mohit-sculptsoft/github-azure-ss/actions/runs/6588410554/job/17900601440
Platforms affected

[ ] Azure DevOps
[X] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] macOS 11
[X] macOS 12
[ ] macOS 13
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
Failed Run Link : https://github.com/mohit-sculptsoft/github-azure-ss/actions/runs/6588410554/job/17900601440
Is it regression?
No
Expected behavior
I expect to be able to change the screen resolution as part of my GitHub Actions workflow.
Actual behavior
The screen resolution change does not work consistently. It sometimes succeeds, but at other times, I receive the error message related to VMWare Tools.
Repro steps
Here are the steps to reproduce the issue:

Run the GitHub Actions workflow on macOS-latest.
Attempt to change the screen resolution using VMWare Tools.

Look like new error for same repro in your previos report. So I close this as duplicate https://github.com/actions/runner-images/issues/8606


404 error for the jar download link

hi !
I have a 404 error when i try to download the plugin.
thanks.

updated the link with correct URL
https://github.com/sivasamyk/graylog-plugin-input-jmx/releases/download/v1.0.0/graylog-plugin-input-jmx-1.0.0-SNAPSHOT.jar


[Spike] - tauri os notifications

for #15 we need OS notifications, purpose of this note:
figure out how customizable are the notifications within tauri
ask Altalogy UX team to help design mining notifications to be shown

what I found:
it's possible to show a text notification on all platforms
for linux and windows it's also possible to show our icon in the notification, provided that we can get an absolute path to an image, which (I think) should be possible through from backend
on my machine it rendered a purple icon that I pointed to manually

however, macOS does not allow for icon modification, it will show a default one:

sources:
library that tauri uses for notification: https://docs.rs/notify-rust/latest/notify_rust/struct.Notification.html#method.icon
transcript of answer to my icon question on tauri discord:


Testing OpenSIEM Creds on MAC, added space

Description
Please provide a description of your proposed changes - providing obfuscated log/code examples is highly encouraged.
Related Issues
Are there any Issues to this PR?
Todos
Are there any additional items that must be completed before this PR gets merged in?

[ ]
[ ]

Creds Test - closing out


Migration to Azure App Service

Can you provide simple tutorial, how to convert code like this:
Windows.Storage.ApplicationData.Current.LocalSettings.Values(valueName) = value
to Azure App Service?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6ebfd899-c97f-fdb8-1778-8b5165d42bac
Version Independent ID: 2f7b0b36-e540-1e51-5de2-0ebdf0aad1df
Content: ApplicationData.RoamingSettings Property (Windows.Storage) - Windows UWP applications
Content Source: winrt-api-build/xml/Windows.Storage/ApplicationData.xml
Product: uwp
Technology: winrt-reference
GitHub Login: @GrantMeStrength
Microsoft Alias: jken

That is an excellent idea, thanks. I'll add that to our project backlog.

Tracked internally as USER STORY 711960

In the meantime, does this help? https://learn.microsoft.com/en-us/azure/azure-app-configuration/

Strange... Seems like it is not completed - there is no sample how to convert UWP app settings to Azure App Service. At least, there is no step by step, detailed "how-to" accessible.


[FEATURE] Properly support tab-scoped sessions

Is your feature request related to a problem? Please describe.
I usually use tabs as different projects, or specific UI layouts (eg: diffview, neogit, etc) and for that I remove the tabpages from sessionoptions, but then closing the tab leaves me with a lot of buffers related to that session open, which could be closed.
I know that plugins like https://github.com/xolox/vim-session#tab-scoped-sessions implement this feature, so I just thought that it would be very nice to have that as well :)

Hey @caenrique I think this technically already works? You'd need to remove tabpages from your sessionoptions that way a session would only work for the particular tab you are in. Exactly like they mention it in the link you linked.

@caenrique so I just learned that Neovim has h tcd for setting a working directory locally for a tabpage.
This is promising as it means it would be somewhat easier to support tab scoped sessions.
I still don't have a clear implementation plan in mind but progress is progress :)

I posted #189 as my use case is different. I have a single session for my project, but have lots of tabs open, each with their own working directory for sub folders inside my project. Because I work on web sites, it could be templates, sass files and javascript for example.
But after reading this issue again even though the use cases are different the underlying issue and solution might be the same.
As I posted there it's possible to use :tcd to give a tab it's own working directory, but also :lcd which gives a window it's own working directory, when working with splits.
The way to get the setting for each is like this:
vim.fn.getcwd() - get's the local cwd, so :lcd
vim.fn.getcwd(-1) - get's the tab cwd, so :tcd
vim.fn.getcwd(-1,-1) - get's the global cwd, so :cd

in all those cases if a more specific cwd hasn't been set then the function will return the next one up.
SO if you've never used :tcd or :lcd then using vim.fn.getcwd() will return the global cwd as set with :cd.
For that reason changing the code in Lib.escaped_session_name_from_cwd() to use vim.fn.getcwd( -1,-1) would make no difference for people who don't use :lcd or :tcd but would fix this issue for people who do.
It would still be nice to have this as an option but I'm going to fork the project and try out this "fix" for myself and see if there are any unwanted side effects.

Here is my fork with just getcwd() changed to getcwd(-1,-1) in Lib.escaped_session_name_from_cwd().
It now works exactly as I'd want.
https://github.com/TC72/auto-session
This isn't in a state for me to ask you to pull it, it's a change in behaviour which might not be what some people want.
My feeling is this wouldn't break people's workflows but I can't be 100% on that.
If it would cause issues then this would need to be added as an option so people can choose how getcwd() works.
Also, I'm also only changing getcwd() in one place right now, but it's used in other places.
I guess it'd just be the same code in each case.
auto-session.lua - suppress_session()
auto-session.lua - is_allowed_di()
auto-session-library.lua - legacy_session_name_from_cwd()

It's also used in several places in auto-session-autocmds.lua, in all cases it's for logging debug messages.
And finally in the README.md it's used in an example of how to update the directory of a session in nvim-tree.
@caenrique do you want to try this fork to see if it fixes your issue?

Hey! Sure I'll give it a try this afternoon :)

Hey! Sure I'll give it a try this afternoon :)

Hey @caenrique,  did you ever get a chance to try this?

Hey, Sorry that I didn't answer back 😅
Yes, I tried this, and no, it doesn't fix mi issue, but that's ok.
I've realized that what I wanted to do is too involved anyway


Need to test out the ParseOpenPosition class with real data..

Will need to open a small trade to test if it works or not.

test that all the needed data is returned
test that the data can be used to create the sell order.

Testing complete, worked with a one contract call position.


desikan atlas confusion

We have several files at several scales/resolutions for the desikan atlas. Some appear to be different from others, and less-goodly. This is bad.
DoD: get to the bottom of it and have a single desikan atlas which I then propagate across all scales.

https://github.com/neurodata/desikan
:fire:


Authentication Errors

Please verify that this bug has NOT been raised before.

[X] I checked and didn't find a similar issue

Describe the bug*
Yesterday I attempted to update inventree to 14.0. Ran into the docker image issue that was fixed in 14.1. This morning I was able to update to inventree and the docker containers are all up and running.
Issue is that any time I try and complete an action of any kind from any account (our other users are also having this issue), I get an authentication failure error and am then logged out. Additionally, I am not able to login from a fresh browser into any of the accounts (admin orotherwise).
Steps to Reproduce

Attempt to update to 14.0
Update to 14.1
Attempt to login or complete any action

Expected behaviour
I expected to be able to login to inventree and complete actions allowed to my user.
Deployment Method

[X] Docker
[ ] Bare metal

Version Information
Version Information:
InvenTree-Version: 0.14.1
Django Version: 4.2.10
Commit Hash: df0bb34
Commit Date: 2024-03-05
Database: postgresql
Debug-Mode: False
Deployed using Docker: True
Platform: Linux-5.4.0-171-generic-x86_64-with
Installer: DOC
Active plugins: [{'name': 'InvenTreeBarcode', 'slug': 'inventreebarcode', 'version': '2.0.0'}, {'name': 'InvenTreeCoreNotificationsPlugin', 'slug': 'inventreecorenotificationsplugin', 'version': '1.0.0'}, {'name': 'InvenTreeCurrencyExchange', 'slug': 'inventreecurrencyexchange', 'version': '1.0.0'}, {'name': 'InvenTreeLabel', 'slug': 'inventreelabel', 'version': '1.0.0'}, {'name': 'InvenTreeLabelMachine', 'slug': 'inventreelabelmachine', 'version': '1.0.0'}, {'name': 'InvenTreeLabelSheet', 'slug': 'inventreelabelsheet', 'version': '1.0.0'}, {'name': 'DigiKeyPlugin', 'slug': 'digikeyplugin', 'version': '1.0.0'}, {'name': 'LCSCPlugin', 'slug': 'lcscplugin', 'version': '1.0.0'}, {'name': 'MouserPlugin', 'slug': 'mouserplugin', 'version': '1.0.0'}, {'name': 'TMEPlugin', 'slug': 'tmeplugin', 'version': '1.0.0'}]
Please verify if you can reproduce this bug on the demo site.

[ ] I can reproduce this bug on the demo site.

Check your config.yaml file under trusted_origins and try adding your URI to the list.

Forbidden (Origin checking failed - https://inventree.lionpowerusa.com does not match any trusted origins.): /set-password/
Django 4.x has stricter CORS rules than 3.x. Check your config.yaml file under trusted_origins and try adding your URI to the list.

Thank you a ton. That has fixed the issue.


Broken Link

The link for "Read WCAG reports for all our products and services." is broken.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e0368ee0-d8ae-cae1-c4a8-40c1e755b920
Version Independent ID: 3ad2d527-8a1c-55c1-a40b-6b3876b468df
Content: Web Content Accessibility Guidelines - Microsoft Compliance
Content Source: microsoft-365/compliance/offering-WCAG-2-1.md
Product: microsoft-365-enterprise
GitHub Login: @robmazz
Microsoft Alias: robmazz

@millh0use - thanks for the feedback, updating the topic with the correct link (https://cloudblogs.microsoft.com/industry-blog/government/2018/09/11/accessibility-conformance-reports/).


check if hasVibrator

prevent crashes on devices without vibrate support

see https://github.com/junina-de/react-native-haptic-feedback/issues/72

@mkuczera
https://developer.android.com/reference/android/os/VibrationEffect#createPredefined(int)
Android Q is not Android O
Please revert your changes in the PR

Hi, sorry, just wanted to comment and was distracted. I will adjust today some places to match the methods to the corresponding vibrate actions on android with a proper fallback down to api level 26. @pinpong

Heh heh.


[release/1.4] runtime/v2/runc: fix the defer cleanup of the NewContainer

Signed-off-by: Iceber Gu<EMAIL_ADDRESS>(cherry picked from commit 5e484c96139d2e4c93a277ff0c0caf815acb466f)
Signed-off-by: Iceber Gu<EMAIL_ADDRESS>cherry-pick: https://github.com/containerd/containerd/pull/5206

@fuweid ptal

@Iceber please rebase to make CI happy :)

@fuweid CI is :green_circle:


Integrate commissioner and device clusters with operational credentials

Problem
Need to call cluster APIs to send operational credentials to the device.
Summary of Changes
This PR updates commissioner to

Request OpCSR after SPAKE2p handshake completion.
On receiving OpCSR, generate the Operational Credentials, and send it to the device

The device code is updated to implement cluster servers for operational credentials and trusted root certificates.
On receiving the certificates, the device stores them in the AdminPairingTable, and persists to the KVS.

rebased

@andy31415 @saurabhst  ?

Seems we did not enable operational credential server on apps except all-cluster-app.


Compilation problems

I encountered the following problems when compiling. How can I solve these problems? Thank you！

Hello,
This is a warning message (the argv argument of execve being NULL), not an error. Seeing your logs, you should have two executable files, ./poc and ./get_root.
Thanks for opening the issue, we have updated the code to get rid of the warning.


Deduplicate menu position calculation

Would you mind rebasing the PR onto the latest master?

Rebased and extracted the handling of showing the popup into its own class. Declutters Maccy.swift a bit. Also found a member variable (window) that wasn't used.


CVE-2023-2976

Please, no.
The only place where we should have a Guava dependency is in oak-shaded-guava. All other dependencies should go in the not too distant future.


⚠ Secret Website 3 has degraded performance

In 3f8629e, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 2016 ms

Resolved: Secret Website 3 performance has improved in efa9c9a.


DOCs for Expose a SOAP service as a REST API

Purpose
Adding doc for exposing SOAP service as a REST API

This PR will close as we referred it in https://github.com/wso2/docs-apim/pull/156


Improper ground states for Harmonic Oscillator

Glauber states are generated for a harmonic oscillator instead of the more conventionally standard ladder states.

Solved in reimplementation.


Computed fields not displaying in the front end

Discussed in https://github.com/statamic-rad-pack/runway/discussions/403

Originally posted by mefenlon January 15, 2024
I just upgraded from v5 to v6. I am now having issues with the computed fields displaying in the front end.
Using the dosumentation, https://runway.duncanmcclean.com/blueprints#content-computed-fields, I have an attribute defined in my model. On the backend, the blueprint is configured as computed and it displays just fine.
In my Model
    public function fullName(): Attribute
    {
        return Attribute::make(
            get: function () {
                return "{$this->display_title} {$this->sort_title}";
            }
        );
    }

In my blueprint
          -
            handle: full_name
            field:
              input_type: text
              antlers: false
              type: text
              display: Title
              icon: text
              listable: hidden
              instructions_position: above
              visibility: computed
              replicator_preview: true
              duplicate: false
              hide_display: false

In the front end, I am unable to list the attribute.
show.antlers.html
    {{ sort_title }} displays fine |
    {{ display_title }} displays fine |
    {{ full_name }} nothing
```</div>

I am working through the upgrade. Just one thing of note, your example has the computed field as a public function and the Laravel example uses protected function. Maybe something that shoul be noted in the documentation.
use Illuminate\Database\Eloquent\Casts\Attribute;

public function fullName(): Attribute
{
    return Attribute::make(
        get: function () {
            return "{$this->first_name} {$this->last_name}";
        }
    );
}

Laravel's example
use App\Support\Address;
use Illuminate\Database\Eloquent\Casts\Attribute;

/**
 * Interact with the user's address.
 */
protected function address(): Attribute
{
    return Attribute::make(
        get: fn (mixed $value, array $attributes) => new Address(
            $attributes['address_line_one'],
            $attributes['address_line_two'],
        ),
    );
}

Feel free to PR the docs.


got error when file too large

The following error occurs when a file is larger than APP_MAX_FILE_SIZE.
Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client

I did the following steps:

Change APP_MAX_FILE_SIZE in  docker-compose.yml to 100
docker compose up
curl -X POST http://localhost:8080/api/v1/scan -F<EMAIL_ADDRESS>| jq
Response is returned, but an error occurs after a little while

logs from containers:
node:internal/errors:496

    ErrorCaptureStackTrace(err);

    ^

Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client

    at new NodeError (node:internal/errors:405:5)

    at ServerResponse.setHeader (node:_http_outgoing:648:11)

    at ServerResponse.header (/clamav-rest-api/node_modules/express/lib/response.js:794:10)

    at ServerResponse.send (/clamav-rest-api/node_modules/express/lib/response.js:174:12)

    at ServerResponse.json (/clamav-rest-api/node_modules/express/lib/response.js:278:15)

    at /clamav-rest-api/src/routes/scan.js:30:30

    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {

  code: 'ERR_HTTP_HEADERS_SENT'

}

How can I work around the error?

Hi,
The APP_MAX_FILE_SIZE parameter should be provided in bytes. 100B can be too small to let CRA work properly.
Try to change this value to something more realistic: 10MB  should be a good starting point
10 * 1024 * 1024 = 10485760
APP_MAX_FILE_SIZE=10485760
The value in the example docker-compose.yaml file is 25MB for single file to scan

@benzino77 Thanks for your comment.
I set APP_MAX_FILE_SIZE to 10MB (10485760) and tried a file larger than 10MB but got the same error.
api response:
{
  "success": false,
  "data": {
    "error": "File size limit exceeded. Max size of uploaded file is: 10485760 KB"
  }
}

If you set a limit to 10MB and send file greater then 10MB... well it is correct behavior.
APP_MAX_FILE_SIZE is the upper size limit of a file which can be accepted by CRA.

@benzino77 Container restarts when an error occurs. Is it also correct behavior for the container to exit?

Sorry to hear it.
What is your setup? Are you trying to start CRA on docker or on k8s? Have you tried to use sample configuration from examples directory?
I've just tested CRA on docker and k8s on my side using samples provided in examples directory. Works without any problem - no restarts on uploading files exceeding size limit
For docker I'm on version:
docker --version
Docker version 25.0.3, build 4debf41

in case of k8s I've performed tests on 1.24.3 and 1.28.3 also works without restarts when file size limit is exceeded:
minikube profile list
|----------|-----------|---------|--------------|------|---------|---------|-------|--------|
| Profile  | VM Driver | Runtime |      IP      | Port | Version | Status  | Nodes | Active |
|----------|-----------|---------|--------------|------|---------|---------|-------|--------|
| cluster1 | docker    | docker  | <IP_ADDRESS> | 8443 | v1.28.3 | Running |     1 |        |
| minikube | docker    | docker  | <IP_ADDRESS> | 8443 | v1.24.3 | Stopped |     1 | *      |
|----------|-----------|---------|--------------|------|---------|---------|-------|--------|

I tried CRA on Docker using samples provided in examples directory.
I use the same docker version.
docker --version
Docker version 25.0.3, build 4debf41

Hmm. That is strange. I just tested CRA on two different environments and it works as expected. Can you provide more details about your setup?
What architecture you are running on? x86_64? ARM64 (Apple M1/M2/Mx)?
What OS you are running underneath? Windows? Linux? MacOS?
Do you introduce any changes to sample docker-compose.yaml file included in examples directory?

I am using MacOS. I tried it in the following environments.

x86_64
ARM64(Apple M2)

All environments use Docker image benzino77/clamav-rest-api:1.2.2.
After a minute or two after the request, an error log is output and the system restarts. In some cases, it restarts immediately.
APP_MAX_FILE_SIZE in docker-compose.yaml is changed to 10485760.  No other changes other than this.

I have been trying to reproduce your problem but without luck.
I have setup CRA on two different machines with docker. Set the max upload file to 1MB and upload random files in a loop to CRA to scan them. Most of the files exceeded APP_MAX_FILE_SIZE. I haven't observed restarts.
Is it a "plain" docker installation or you introduce some "tweaks" in docker.json file?

I think that finally I was able to reproduce your problem. Check the new docker image pushed to docker hub.

Close this issue as there is no response from the reporter.


[Bug][apiserver] fix apiserver create rayservice missing serve port

Why are these changes needed?
The rayservice need indicate the serve port for exposing the ray serve service, in the default raycluster template we are missing the serve port, here we need add it at the service part.

Checks

[x] I've made sure the tests are passing.
Testing Strategy

[ ] Unit tests
[x] Manual tests
[ ] This PR is not tested :(

If the KubeRay API server has any unit tests, it would be good to add a unit test for this PR.
(If there are no unit tests, you should track adding unit tests.)

Thank @scarlet25151 for your contribution! In addition, do you mind adding some unit tests or describing more details about the manual tests? Thank you!

@kevin85421 Thank you for your advise, I think as creating ray cluster there is a UT, but for creating rayjob and rayservice, we do not have UT yet, I think we can create an issue to add the UT and I'm willing to contribute on that part.
Talking back to the manually test we can follow the instruction in https://github.com/ray-project/kuberay/tree/master/apiserver#create-ray-service-in-a-given-namespace and I use that case to create a rayservice,
curl --location --request POST '<IP_ADDRESS>:31888/apis/v1alpha2/namespaces/ray-system/services' \
--header 'Content-Type: application/json' \
--data'{
  "name": "chenyu-test-1",
  "namespace": "ray-dev",
  "user": "chenyu.jiang",
  "serveDeploymentGraphSpec": {
      "importPath": "serve.ray_serve_model",
      "runtimeEnv": "https://github.com/ray-project/test_dag/archive/c620251044717ace0a4c19d766d43c5099af8a77.zip\"\n",
      "serveConfigs": [
      {
        "deploymentName": "OrangeStand",
        "replicas": 1,
        "userConfig": "price: 2",
        "actorOptions": {
          "cpusPerActor": 0.1
        }
      },
      {
        "deploymentName": "PearStand",
        "replicas": 1,
        "userConfig": "price: 1",
        "actorOptions": {
          "cpusPerActor": 0.1
        }
      },
      {
        "deploymentName": "FruitMarket",
        "replicas": 1,
        "actorOptions": {
          "cpusPerActor": 0.1
        }
      },{
        "deploymentName": "DAGDriver",
        "replicas": 1,
        "routePrefix": "/",
        "actorOptions": {
          "cpusPerActor": 0.1
        }
      }]
  },
  "clusterSpec": {
    "headGroupSpec": {
      "computeTemplate": "default-template",
      "image": "hub.byted.org/kuberay/ray:2.0.0",
      "serviceType": "NodePort",
      "rayStartParams": {
            "port": "6379",
            "node-ip-address": "$MY_POD_IP",
            "dashboard-host": "<IP_ADDRESS>",
            "metrics-export-port": "8080"
        },
       "volumes": []
    },
    "workerGroupSpec": [
      {
        "groupName": "small-wg",
        "computeTemplate": "default-template",
        "image": "hub.byted.org/kuberay/ray:2.0.0",
        "replicas": 1,
        "minReplicas": 0,
        "maxReplicas": 5,
        "rayStartParams": {
                "node-ip-address": "$MY_POD_IP"
            }
      }
    ]
  }
}'

@scarlet25151 Can you create an issue to track UT per Dmitri's request?

@scarlet25151 Can you create an issue to track UT per Dmitri's request?

Yes, already created #754

discussed with @scarlet25151 offline, this patch LGTM. regarding @DmitriGekhtman 's comment, @scarlet25151 will add test cases in a separate patch.


feat: Improve CI

I added some extras to make it more efficient (so less CO2 🎁)
This is inspired by a config I'm using daily 😄
If you have any question, let me know!

Aww dude, thanks so much ! I had an idea of that I could cache this stuff, and that concurrent builds were a problem, but I hadn't found a sensible solution.
Happy merging in 👍


Not able to see git as source control in vs code

Type: Bug
I have git installed locally but not able to see it as a source code provider in vs code
VS Code version: Code 1.82.2 (abd2f3db4bdb28f9e95536dfa84d8479f1eb312d, 2023-09-14T05:59:47.790Z)
OS version: Darwin x64 23.4.0
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-1038NG7 CPU @ 2.00GHz (8 x 2000)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
4, 5, 5

Memory (System)
16.00GB (0.04GB free)

Process Argv
--crash-reporter-id 6ffd7230-370a-438b-b178-dfc2257f37e4

Screen Reader
no

VM
0%

Extensions (42)

Extension
Author (truncated)
Version

html-snippets
abu
0.2.1

project-manager
ale
12.8.0

ng-template
Ang
17.3.1

gitignore
cod
0.9.0

doxdocgen
csc
1.4.0

vscode-eslint
dba
2.4.4

git-extension-pack
don
0.1.3

githistory
don
0.6.20

gitlens
eam
2024.3.3105

prettier-vscode
esb
10.4.0

auto-close-tag
for
0.5.15

code-runner
for
0.12.1

vscode-pull-request-github
Git
0.72.0

vscode-angular2-emmet
jak
2.0.3

better-cpp-syntax
jef
1.17.2

mongodb-vscode
mon
1.5.0

vscode-docker
ms-
1.29.0

remote-containers
ms-
0.315.1

remote-ssh
ms-
0.106.5

remote-wsl
ms-
0.81.9

cmake-tools
ms-
1.17.17

cpptools
ms-
1.19.9

cpptools-extension-pack
ms-
1.3.0

remote-explorer
ms-
0.4.1

color-highlight
nau
2.8.0

material-icon-theme
PKi
4.34.0

vscode-thunder-client
ran
2.20.3

java
red
1.28.1

LiveServer
rit
5.7.9

html5-boilerplate
sid
1.1.1

sonarlint-vscode
Son
4.4.1

cmake
twx
0.0.17

incredibly-in-your-face
Vir
1.0.2

intellicode-api-usage-examples
Vis
0.2.8

vscodeintellicode
Vis
1.3.1

vscode-java-debug
vsc
0.57.0

vscode-java-dependency
vsc
0.23.3

vscode-java-pack
vsc
0.25.15

vscode-java-test
vsc
0.40.1

vscode-maven
vsc
0.44.0

google-java-format
wx-
0.0.1

vscode-open-in-github
ziy
1.3.6

(1 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256860
vscorecescf:30445987
vscod805:30301674
binariesv615:30325510
vsaa593cf:30376535
py29gd2263:30899288
c4g48928:30535728
azure-dev_surveyone:30548225
962ge761:30959799
pythongtdpath:30769146
welcomedialogc:30910334
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
pythontestfixt:30902429
pythonregdiag2:30936856
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
pythontbext0:30879054
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
d6fi2104:30959263
cppperfnew:31000557
d34g3935:30971562
bg6jg535:30979843
ccp2r3:30993541
dsvsc020:30976470
pythonait:31006305
7ghi1836:30988842
dsvsc021:30996838
g1icg217:30999571

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.87.2. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

/gifPlease

Thanks for reporting this issue! Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, .gif files are preferred as they are displayed inline on GitHub. You may find https://gifcap.dev helpful as a browser-based gif recording tool.
If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording (Developer: Toggle Screencast Mode in the command palette). Lastly, please attach this file via the GitHub web interface as emailed responses will strip files out from the issue.
Happy coding!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


First inference service example not working in v0.11

/kind bug
What steps did you take and what happened:
[A clear and concise description of what the bug is.]
I am following the first inference service example but it is not working in v0.11, getting following error when I send the request.
{"error":"Expected 2D array, got scalar array instead:\narray=nan.\nReshape your data either using array.reshape(-1, 1) if your data has a single feature or array.reshape(1, -1) if it contains a single sample."}

What did you expect to happen:
following response is expected:
{"predictions":[1,1]}

What's the InferenceService yaml:
[To help us debug please run kubectl get isvc $name -n $namespace -oyaml and paste the output]
kubectl create namespace kserve-test

kubectl apply -n kserve-test -f - <<EOF
apiVersion: "serving.kserve.io/v1beta1"
kind: "InferenceService"
metadata:
  name: "sklearn-iris"
spec:
  predictor:
    model:
      modelFormat:
        name: sklearn
      storageUri: "gs://kfserving-examples/models/sklearn/1.0/model"
      resources:
        limits:
          cpu: 100m
          memory: 1Gi
        requests:
          cpu: 100m
          memory: 1Gi
EOF

Anything else you would like to add:
When I use the runtimes in v0.10.0, it works fine.
Environment:

Istio Version: 1.17.3
Knative Version: v1.11.0
KServe Version: v0.11
Kubeflow version:
Cloud Environment:[k8s_istio/istio_dex/gcp_basic_auth/gcp_iap/aws/aws_cognito/ibm]
Minikube/Kind version:
Kubernetes version: (use kubectl version): v1.26.7
OS (e.g. from /etc/os-release):

@lizzzcai Have you tried setting the  Content-Type: application/json during curl request ?

Hi @sivanantha321 , thanks for your reply. with -H "Content-Type: application/json" it is working. However, in v0.10, it is working even without the header.

@lizzzcai I myself not sure what broke this behaviour. I think it may be related to this PR https://github.com/kserve/kserve/pull/2524.
@yuzisun Should we consider it as a bug ?

I think the request is supposed to set the right content type although it is optional, otherwise it is hard for server to guess the right type and support other content types like raw bytes for images. It has been noted as a breaking change in the 0.11 release note.

I think the request is supposed to set the right content type although it is optional, otherwise it is hard for server to guess the right type and support other content types like raw bytes for images. It has been noted as a breaking change in the 0.11 release note.

Thanks @yuzisun for your reply. Just checked that it is in the release note, it makes sense now. I will close this issue.