Example does not demonstrate how to use autofac

The readme.md page in the root does demonstrate how to inherit from AutofacNancyBootstrapper but does not tell how to register component. From my experience with autofac, you create a builder, register components using it, and than create a container. In the examples, container is already provided and it is not obvious how to get builder.
Would be nice to amend example to register some fake component.

I'm not sure it's our responsibility to document Autofac usage (this is Autofac-specific, not Nancy or the bootstrapper).
In this case, it's trivial, so I'll give it a shot. :smile:
It works like this, (almost) exactly like you said:
var builder = new ContainerBuildeR(); // you create a builder

builder.RegisterType<Service>().As<IService>().SingleInstance(); // register components using it

builder.Update(container); // and then update the container

The bootstrapper also provides an extension method, Update, so you can do
container.Update(builder => builder.RegisterType<Service>().As<IService>().SingleInstance());

:+1:

Ok, I realize now that I was trying to do something too advanced, but still not too unusual. I had a module with params of the same type:
class RestServer: NancyModule {
    public RestServer(string a, string b) {...}

So I was trying to register INancyModule on my own, and hit all kind of problems. From which stage module needs to be registered, ConfigureRequirestContainer or ConfigureApplicationContainer, is it instance or singleton registration, to TinyIoC stack overflow and not resolving what seems to be a valid registration.
On one hand registering NancyContainer is an internal nancy affair and advanced move, but on other hand, creating and registering module is what nancy usage starts with. Situation when a module needs to resolve 2 params of the same type is not an exotic one. But perhaps it is better question for StackOverflow, feel free close this issue than.


MuiBadge

Badge Component

@manikandanmohan10 or @Antony-M1  Please review the code and merge into the main branch


don't define reads services if reads-deployment isn't specified

closes #1342
We don't always have reads deployments on demos which aren't on the production cluster. This changes the behavior of the demo ingress creation script to only create reads services and Ingress paths if you specify a reads deployment.

Superseded by https://github.com/broadinstitute/gnomad-browser/pull/1634


Improvement: Product export doesn't consider media URL

Please use the media URL instead of the base URL in the image URLs:

This should have been fixed in #101.


[2.4] wait for dockerInfo to be set before creating node plan

Problem:
creating node plan with empty dockerRootDir results into wrong kubelet's process
https://github.com/rancher/rancher/issues/26790

@superseb @StrongMonkey
Changing the approach a little.
DockerInfo gets synced on the node each time agent requests for a node plan. There's no point in returning error in controllers or in GetDockerInfo because retry there isn't going to fix anything + spam logs. I've changed logic to wait for Node.Status.DockerInfo to be set on before getting and setting the node plan.
The second commit is for issue that's happening because of this wrong node plan. First node is stuck in registering and on addition of other nodes, rkeConfig changes and toUpgradeCluster becomes true because registering node now has the right node plan (dockerInfo got synced).
This issue shouldn't happen now, but let's say node is stuck in registering state for some other reason, any subsequent rke up shouldn't result into workers upgrade because of change in this node plan -- so I'm ignoring registering nodes.

Makes sense to me, should we add a logline for each found condition to trace down the cause of not getting a node plan?

Also build failed


E2e/add workaround for race condition (#4799)

Pull request opened by the merge tool on behalf of #4799

Merged in d1c1947c47c14c906c36348247e84d59388fbd32


Bug when removing nested elements from HAMT (Hash Array Mapped Trie)

The issue is in the minus method on the BitsetNode class - when is data removed from indirectly referenced (nested nodes) the new child is not properly represented in the resulting Node.
Running TopicTest::disconnectAllStreamsAndReconnect a large number of times reproduces the issue.

Released in 10.0.0-M2


Document trap precision

The RISC-V spec gives us some flexibility how precise traps should be. We need to document our current behavior.
I'd expect all traps to be precise, but we should double-check with the code.

There have been some fairly recent updates to the RISC-V privileged spec which provide some clarity on behavior here. We should check Ibex complies with the latest version.


Encoded values do not match after upgrade to 5.3

Describe the bug
After upgrading graphhopper to 5.3, adding TagParser to encodingManagerBuilder makes different configuration on first run, and on next runs, which resolves in "Encoded values do not match" error.
Difference is in shift value (and version)
Graphhopper config: surface|version=782288784|bits=4|min_value=0|negate_reverse_directionfalse|index=0|shift=4|store_both_directions=false
Graph: surface|version=778378475|bits=4|min_value=0|negate_reverse_directionfalse|index=0|shift=0|store_both_directions=false
Before everything worked, because I could create EncodingManager from code. Now there is no way of doing this.
Also after hours of debugging I saw that in first run only one EncodedValue is created for Surface (from TagParser). In next run there are two, from TagParser AND from DefaultEncodedValueFactory
To Reproduce
Create Graphhopper from version 5.3 using Java code with OSMSurfaceParser:
 return GraphHopper().apply {

            ...

            val surfaceParser = OSMSurfaceParser()

            encodingManagerBuilder.add(surfaceParser)

            importOrLoad()
        }

For the first run, everything works and I get surface on results. In the next load, error occures
Expected behavior
There should be no error, like in the previous versions
System Information
GraphHopper version 5.3
Screenshots & Logs
To create Graphhopper instance, I am using custom EncoderFactory, Elevation provider and profiles, but it should not be relevant.
Thanks for help, and thanks for that great library ;) Hope we can resolve this issue

The first thing I would try is calling importOrLoad, instead of load, on your second run. I'll try to reproduce this error, is the code you shared really all I need?

I didn't know that I should use "load" on second run.

Yes, I think you should not except in a few special cases where you have to unfortunately. Can you share some runnable code that reproduces your error?

Oh I see. Yes I was using importOrLoad always
Code below is enough to make it crash on second run:
 fun issueForGithub(graphDirectory: File, osmDataFile: File): GraphHopper {         return GraphHopper().apply {             osmFile = osmDataFile.absolutePath             graphHopperLocation = graphDirectory.absolutePath             profiles = listOf(Profile("car"))             val surfaceParser = OSMSurfaceParser()             encodingManagerBuilder.add(surfaceParser)             importOrLoad()         }     }
only dependency I am using is this:
implementation("com.graphhopper:graphhopper-core:5.3")

2.3

Ok just for the record here is the code that reproduces the error in Java:
    @Test
    void issue2617() {
        {
            GraphHopper hopper = new GraphHopper();
            hopper.setOSMFile(BAYREUTH)
                    .setGraphHopperLocation(GH_LOCATION)
                    .setProfiles(new Profile("car"));
            hopper.getEncodingManagerBuilder()
                    .add(new OSMSurfaceParser());
            hopper.importOrLoad();
        }
        System.out.println("load");
        {
            GraphHopper hopper = new GraphHopper();
            hopper.setOSMFile(BAYREUTH)
                    .setGraphHopperLocation(GH_LOCATION)
                    .setProfiles(new Profile("car"));
            hopper.getEncodingManagerBuilder()
                    .add(new OSMSurfaceParser());
            hopper.importOrLoad();
        }
    }

hopper.getEncodingManagerBuilder() was added in #2281 so it did not exist in GH 2.x and was added for GH 3.0. The way you use the method causes the surface encoded value to be added twice to the encoding manager (and it does not throw an error). Basically this does not throw an error, but the encoded value strings will be different (I used max_width instead of surface but that does not matter):
    @Test
    public void issue2617() {
        EncodingManager.Builder emBuilder = EncodingManager.start();
        emBuilder.add(new OSMMaxWidthParser());
        EncodingManager em = emBuilder.build();
        String emString1 = em.toEncodedValuesAsString();

        emBuilder = EncodingManager.start();
        emBuilder.add(new OSMMaxWidthParser());
        // from graph.encoded_values
        emBuilder.add(MaxWidth.create());
        em = emBuilder.build();
        String emString2 = em.toEncodedValuesAsString();

        assertEquals(emString1, emString2);
    }

In the first run only the parser is added to the encoding manager builder, but in the second run first the encoded values are added (taken from graph.encoded_values in the properties file) and then because of the added parser the surface encoded value is added again. This bug already exists since #2281. Anyway, in current master hopper.getEncodingManagerBuilder() was already removed.
So your workaround of not adding the parser for the second run is indeed a good idea. Maybe a safer way is using the init() method before calling importOrLoad. This way you avoid the code path that involves the EncodedValueFactory (also see #2438  if you are really interested), because the encoding manager will already be built in the init() method. For example you can add the surface encoded value like this (use the same for both runs):
hopper.init(new GraphHopperConfig().putObject("graph.encoded_values", "surface,max_width,..."));
hopper.importOrLoad();

But be careful when you combine the init method with the different setter methods of the GraphHopper class. When in doubt call the init method first so it does not overwrite the results of the setter method calls, see also this comment: c79bb964b42fb9416fb719ec22c1c6ae575b7a39

Thanks for your response. I prefer not to use init() because of no type safety properties, but I understand issue and if adding TagParser only once is good idea, then I'll stick with it.
Could you provide some example how should it be done in new version (which you refer as current master)?
I could not find any "fresh" example of how to add new TagParser or modify EncodingManager.
Maybe new method in RoutingExample.java?

You should be able to find examples for most things in GraphHopperTest.java or GraphHopperOSMTest.java, for you specific version.

should it be done in new version (which you refer as current master)?

The current master is working most of the time, but can be subject to frequent changes and currently everything regarding the EncodingManager is moving quite fast, so I'd still recommend to use version 5.3 in most cases. Version 6.x will be released around September.
For current master the way to modify the EncodingManager ist to use setFlagEncoderFactory, setEncodedValueFactory and setTagParserFactory to define what kind of FlagEncoders, EncodedValues and TagParsers shall be available and then use setFlagEncodersString and setEncodedValuesString to define which ones should be activated. But also note that the meaning of the EncodingManager changed. It used to include the tag parsers, but now it only include encoded values and everything related to OSM parsing is in a new class called OSMParsers, which is not needed at all for the second run. Also the EncodingManager is loaded from disk in the second run, so there is no longer a need to make sure it is the same in the first and second run.
If all you want to do is adding the surface encoded value you do not need to do anything at all, because it is always added by default.

Sounds great! In current version it was really difficult to understand which code should I use to tell what is available, and which configures what should be created.
About "If all you want to do is adding the surface encoded value you do not need to do anything at all, because it is always added by default", you are talking about new version which will be out around September? Because on 5.3 surface is not encoded by default

Sounds great! In current version it was really difficult to understand which code should I use to tell what is available, and which configures what should be created.

Yes, documentation etc. still needs to be updated for GH 6 as there have been many changes and even more might follow. Maybe the GraphHopper class will be removed entirely.

Because on 5.3 surface is not encoded by default

Yes, you are right, the surface encoded value is not in the list of default encoded values. Neither for 5.3 nor for master: https://github.com/graphhopper/graphhopper/blob/af5ac0b0ae024da4b23966b1eef480508b5eedbb/core/src/main/java/com/graphhopper/routing/util/EncodingManager.java#L271-L284

which code should I use to tell what is available, and which configures what should be created.

Like I said, what is available is defined in FlagEncoder/EncodedValue/TagParserFactory and what is created in flagEncoders/encodedValuesString. Except the fact that the EncodingManager.Builder adds some default encoded values as well, which I think it should not. Does this not make sense, or which version did you think was difficult to understand?

Anyway, after reading your description of version 6.x, it doesn't matter, because it will be changed anyway ;)

It still matters, because feedback like yours helps improving the project, thanks!


Add "cosign attest" command!

Signed-off-by: Dan Lorenc<EMAIL_ADDRESS>

TODO:

[ ] Tests
[ ] Verification
[ ] Docs

Dropping the WIP here, basic attest and verify-attestation flows are in, working, and documented!


Inconsistently resolving console commands

Laravel Version: 5.7.17
PHP Version: 7.2
Database Driver & Version: not relevant

Description:
(I'm working on a way to assertCommandCalled.)
While working on https://github.com/laravel-zero/laravel-zero/issues/178, I noticed that commands called via another command are resolved directly, and not via Illuminate\Foundation\Console\Kernel (which is the normal entry point).
Steps To Reproduce:
More info coming soon.

Heya. From what I understand this is the normal behavior? Feel free to re-send this in as soon as you have the "more info".


Quick question

Hey @innocenat, great tool!
I'm interested in acquiring the tool. How best can I reach you?

Not sure what you mean by "acquiring". It's already open sourced under the most open license I could ever think off. You are free to use it however you liked.
If you want to acquire the primary domain https://kindle-epub-fix.netlify.app/ to add ads, etc, then my answer is a firm no.

Hey. I understand you don't want to turn this into a commercial tool. Me neither!
My proposal is to keep this free-forever, but would redirect/host it under my domain. So if people find my other services relevant then they might give it a try. Totally fine if they don't.
My point is it would work the way you wanted, and would not add any annoyance to the users.
Would you interested in a chat?

Unless it pertains to sensitive information, I prefer all conversion to be in public. If you do have sensitive information, my email address is available in the Git commit information.

My proposal is to keep this free-forever, but would redirect/host it under my domain.

It is currently hosted under netlify because it was just a quick project when I began, so I didn't think much of it. I do have my own domain and server to host it myself should somehow netlify become paid service.

So if people find my other services relevant then they might give it a try. Totally fine if they don't.

How about you link your service, and if I find it relevant, then I link to you?

Great. Let's discuss all in public then. FYI, I've been building my startup in public, so big fan of transparency and all.
So why am I doing this?
I've been growing an indie product called KTool (https://ktool.io). It's a tool to send web articles, newsletters & RSS feeds to Kindle.
One of my grow strategy is to build free tools and give it away to gain traffic to the main product. People who are not interested in my product can use the tool for free, no ads, no BS. But some of those visitors might find my product useful and decide to buy. Win - Win.
Some of my free tools I launched:

Send Hacker News discussion to Kindle: https://ktool.io/hacker-news-to-kindle
Send Reddit thread to Kindle: https://ktool.io/reddit-to-kindle
Send AZW3 to Kindle wirelessly: https://ktool.io/azw3-to-kindle

As you can see, none of these tools include ads, and do not require an account.
I want to "acquire" the kindle-epub-fix tool because people find it useful, and the audience is a great fit for my product.
People are already linking to your page, so what I want is to host it under my domain (for SEO gain), and do a redirect from your current netlify page.
Alternatively, I'd love to have a link on your current page to my tool. Maybe as a sponsorship. Although this way, I do not have the SEO gain.
Let me know what you think

I have definitely have heard of KTool before and while I haven't used it I have heard great thing about it. This does definitely make me less skeptics about this entire discussion. (Sorry about that)
I am willing to link to KTool without any compensation since I do genuinely think it's a great service. Please feel free to send a pull request adding your link in a manner you think is acceptable. At this point I am still reluctance to just redirect to your domain, sorry.
Just an additional note, though, if other Kindle related services that I deemed good enough also asked to be linked, I am likely to also accept them as well.
To be honest this tool's popularity has been been blown up kinda beyond my initial expectation and I honestly don't know what is the best option to proceed. I also don't have a lot of time to invest in it, either. It is currently hosted on Netlify free plan so I don't even have analytics on how many people access it each month.

As you can see, none of these tools include ads, and do not require an account.

I don't see a way to access the free tools from the KTool landing page. In fact, I haven't found any direct link to the free tools anywhere else on the website. Maybe I missed something?
If not, this feels like a free sponsorship to a paid tool which does require an account, on the basis that there are "free" tools hosted on the site, but which will never actually be found unless someone comes to this thread or happens to find the specific pages via google.
Is my assumption incorrect?
If not, I suggest reverting this disingenuous change or paying @innocenat an advertising fee (probably backdated, as I couldn't find a link to the free tools anywhere on wayback archive between May 2023 and now).
If my assumption is incorrect, I suggest adding prominent links to the free tools, at least for those visiting using the kindle-epub-fix referrer link.

If my assumption is incorrect, I suggest adding prominent links to the free tools, at least for those visiting using the kindle-epub-fix referrer link.

 I will add the links soon.
And did you read the whole thread?  I will add the links soon.

Hmm... it's hard to give you the benefit of the doubt on that statement, since it's been a year since your original request, plus your wording here directly contradicts your comment today:

One of my grow strategy is to build free tools and give it away to gain traffic to the main product. People who are not interested in my product can use the tool for free, no ads, no BS. But some of those visitors might find my product useful and decide to buy.

Saying that visitors to your site will enjoy your free tools and use them without BS, with some converting to paid members, is almost impossible if you never actually guide visitors to your free tools, right? Anyone over the past year who has visited your site from the kindle-epub-fix.netlify.app website has had no chance to use those free tools because you were too "lazy" to link to them, right? Yet you weren't too lazy to come here, make an issue, follow up, open a PR, and add a link to a domain you don't own, right?

And did you read the whole thread? I wanted to pay but @innocenat declined (thank you again)

The payment was declined because of the assumption that you were helping to provide (other) free tools to those visiting the kindle-epub-fix.netlify.app site, which is in line with @innocenat's principles & [un]license for this app. But I'd argue that you instead worded your reply in a way that used good faith to get out of paying for the backlink, and that you're trying to do it again by adding "(thank you again)" to the end of the above statement.
I think we both know what's going on here, and I think the right thing to do is to be up-front about it. You've already gotten almost a year of free linking, and since you use a referral query, I'd be interested in you sharing how much traffic you've gotten from kindle-epub-fix.netlify.app (since you've claimed you're open here and this isn't for your own personal gain). Those stats can then be used to determine what a fair market value of the advertising would have been, if @innocenat had all of the pertinent info when he entered into the agreement (since he said he doesn't have analytics).

Hmm... it's hard to give you the benefit of the doubt on that statement, since you've had a year to add the links

I stopped working on KTool exactly 1 year ago and this is only one of my many attempts at marketing. I don't even remember until you posted a message (which triggered a notification of course)

Saying that visitors to your site will enjoy your free tools and use them without BS, with some converting to paid members, is almost impossible if you never actually guide visitors to your free tools, right

I never promise this to random website visitors. I explained to @innocenat what I meant when I said "acquiring" this tool, and what was my marketing strategy with full transparency. It's his decision to agree with my proposal or not. And if he's not happy with any of my proposal, he can remove the link any time. I don't understand your problem here.
What are you accusing me of, exactly? Manipulating others? I wish I had such skill 😅

I think the right thing to do is to be up-front about it.

What is not up-front about my intention, I don't understand. I proposed to aquire the tool in the first place, and if not possible, hopelly I could sponsor it. To which @innocenat declined. And he was so kind that he said he will add the link to the tool, and any other tools if they are good (not just KTool)

I'd be interested in you sharing how much traffic you've gotten from kindle-epub-fix.netlify.app

About 1050 visitors. At 2% visit → signup conversion rate, that 21 signups. At 3% signups → paid conversion rate, that's less than 1 paid customer. And at $5/mo average order value, that's less than $60. And at 5% monthly churn rate, that's $30.
This is the reason I stopped working on KTool because it's not profitable for me.

Those stats can then be used to determine what a fair market value of the advertising would have been

I agree in principal, but please note that there is no business agreement in this case. I wish @innocenat agreed to my initial proposal of acquiring this tool, but he didn't want to and I respect that.


feat(interview-prep): Porting Rosetta problems

Pre-Submission Checklist

[x] Your pull request targets the staging branch of freeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[x] You have only one commit (if not, squash them into one commit).
[x] All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

[ ] Small bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[x] Tested changes locally.
[ ] Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #XXXXX
Description

@NitronR, thank you for porting over more problems!
Just a couple of things:
First, could you update your PR so that the format is like this?
    {
      "title": "I before E except after C",
      "description": [
        "The phrase    \"I before E, except after C\" is a widely known mnemonic which is supposed to help when spelling English words.",
        "Using the words provided, check if the two sub-clauses of the phrase are plausible individually:",
        "

\"I before E when not preceded by C\".

\"E before I when preceded by C\".

",
        "If both sub-phrases are plausible then the original phrase can be said to be plausible.",
        "Write a function that accepts a word and check if the word follows this rule. The function should return true if it follows the rule otherwise false."
      ],
      "solutions": [
        "function IBeforeExceptC (word)\n{\n\tif(word.indexOf(\"c\")==-1 && word.indexOf(\"ie\")!=-1)\n\t\treturn true;\n\telse if(word.indexOf(\"cei\")!=-1)\n\t\treturn true;\n\treturn false;\n}\n"
      ],
      "tests": [
        {
          "text": "'IBeforeExceptC should be a function.'",
          "testString": "assert(typeof IBeforeExceptC=='function','IBeforeExceptC should be a function.');"
        },
        {
          "text": "'IBeforeExceptC(\"receive\") should return a boolean.'",
          "testString": "assert(typeof IBeforeExceptC(\"receive\")=='boolean','IBeforeExceptC(\"receive\") should return a boolean.');"
        },
        {
          "text": "'IBeforeExceptC(\"receive\") should return true.'",
          "testString": "assert.equal(IBeforeExceptC(\"receive\"),true,'IBeforeExceptC(\"receive\") should return true.');"
        },
        {
          "text": "'IBeforeExceptC(\"science\") should return false.'",
          "testString": "assert.equal(IBeforeExceptC(\"science\"),false,'IBeforeExceptC(\"science\") should return false.');"
        },
        {
          "text": "'IBeforeExceptC(\"imperceivable\") should return true.'",
          "testString": "assert.equal(IBeforeExceptC(\"imperceivable\"),true,'IBeforeExceptC(\"imperceivable\") should return true.');"
        },
        {
          "text": "'IBeforeExceptC(\"inconceivable\") should return true.'",
          "testString": "assert.equal(IBeforeExceptC(\"inconceivable\"),true,'IBeforeExceptC(\"inconceivable\") should return true.');"
        },
        {
          "text": "'IBeforeExceptC(\"insufficient\") should return false.'",
          "testString": "assert.equal(IBeforeExceptC(\"insufficient\"),false,'IBeforeExceptC(\"insufficient\") should return false.');"
        },
        {
          "text": "'IBeforeExceptC(\"omniscient\") should return false.'",
          "testString": "assert.equal(IBeforeExceptC(\"omniscient\"),false,'IBeforeExceptC(\"omniscient\") should return false.');"
        }
      ],
      "id": "5a23c84252665b21eecc7eb0",
      "challengeType": 5,
      "releasedOn": "June 8, 2018",
      "files": {
        "indexjs": {
          "key": "indexjs",
          "ext": "js",
          "name": "index",
          "contents": [
            "function IBeforeExceptC(word) {",
              "  // Good luck!",
            "}"
          ],
          "head": [],
          "tail": []
        }
      }
    },

The line breaks between strings in all the arrays and objects just makes it easier to read and maintain.
Also, I went ahead and updated the description of "I before E except after C". You could just copy and past that over the other text.
I'm still reading through the other descriptions to see if they can be updated. I'll leave more comments if I find anything.

Changes are done. Also fixed some other descriptions.

@NitronR, thank you for making all of those changes. I really like the method you used in the IBAN challenge to render the
! I'll keep that in mind next time.
I made a couple of minor changes to the descriptions, just spacing and sentence order, really. Seems like there's a problem with the Travis CI tests, though. Going to see what the problem is there before merging.

Sorry about that.  Thanks for fixing it!
Pulled your PR and tested again locally. Everything seems to be fine. @raisedadead, @Bouncey, would it be alright to merge this? Or should we wait for Travis build to pass?

@NitronR, thank you for your patience. The Travis builds are working again! Thank you for your contribution, and looking forward to the next. :sparkles:


Add support for Python 3.12

Related to #787 - we tried it but vtk was blocking the update.

Great to see interest for python 3.12 so early ! The latest rc  comes with python 3.12 support. Could you give it a try and report related issues at
https://gitlab.kitware.com/vtk/vtk/-/issues ?

Okay sounds like it "works" :)
We are only doing smoke testing - checking that the package builds and that we are able to import its version. Our main dev versions are Python 3.9 to 3.11. This is just to provide support for Python 3.12 on a best-effort basis. Thanks @ChristosT for pointing out the current 9.0.3rc2 release.
I am curious... when is the actual 9.3.0 release expected?

That's hard to tell . Depends on how the rc goes and if any issues are reported. If everything goes well the final release should be in a few weeks.

Thanks @RobPasMue for taking care of this first set of testing. It will be halpful for all our other repos.

I am curious... when is the actual 9.3.0 release expected?

vtk 9.3.0 is available on pypi

Yep!! Dependabot was so kind that opened #854 for us =) Thanks @ChristosT!


Validation: fix missing descriptions #1

Global effort to fix validation errors
The Content & Learning team is fixing build validation errors on docs.microsoft.com. This effort will eliminate potential accessibility, security, and usability issues. This PR includes only build validation fixes and does not change other content. I’d very much appreciate your timely review and feedback on these changes I’ve suggested. Thanks!

Hi @adegeo, this PR is ready for review.


Hello. Thank you for the repository. Can I use only one GPU please?

Hi, thank you for your interest. A batch size of 4 is required to train our SFA.
If the GPU memory can hold a batch size of 4, training with one GPU should be OK.


Thuang add ref to button

This PR is needed to work with our Tooltip component per https://material-ui.com/components/tooltips/#custom-child-element. Essentially if we supply a child element to Tooltip that's NOT MUI component, we'll need to forward ref 💡 😄 👌 !
PTAL thank you!

Anytime, @phoenixAja ! Thanks for spotting this use case!


Allow managing logging levels from winsw.xml

It is a follow-up to #69 .
Currently the logging level for log appenders are hardcoded, which is not good.

Not a blocker for 2.0

Once #213 is integrated, it will be possible to manage logging via a separate configuration file. I intend to say "this is fine for MVP"


Implement first-time user flow

Implement first-time user flow from our latest Figma:
https://www.figma.com/file/0uL6s79o21jwUFZz16Dr8b/Covid-Watch---App-v1.8?node-id=760%3A561
(When you open the Figma press the Present button to see how it should work.)

Should this take precedence over developing UI tests? If so, I can work on this


KYLIN-3461 metastore.sh refresh-cube-signature not updating cube sign…

Can one of the admins verify this patch?


[YUNIKORN-1407] Adding Chinese translation of App Placement Rules

What is this PR for?
I translate the page App Placement Rules to Chinese
What type of PR is it?

[x] - Task

What is the Jira issue?

Open an issue on Jira https://issues.apache.org/jira/browse/YUNIKORN-1407/

How should this be tested?
Screenshots (if appropriate)
Questions:

[ ] - The licenses files need update.
[ ] - There is breaking changes for older versions.
[ ] - It needs documentation.

Thank @yangwwei and @0yukali0 for your review, I updated the content based on "requested changes" and put it in a new commit!


Server Crash Ticking Entity.

Issue description: Started with players unable to join, Once the server auto restart it refused to reboot, Crash at ever attempted to start.
What happens: Server Crashes
What you expected to happen: It not to crash
Steps to reproduce:
1.Load  my edited direwolf20 pack and world and watch it fail to start
2.
3.
...
Version (make sure you are on the latest version before reporting):

Minecraft: 1.12.2
Forge: <IP_ADDRESS>68
Refined Storage: 1.5.28

Does this issue occur on a server? [yes/no] Yes
If a (crash)log is relevant for this issue, link it here:
##https://pastebin.com/GbMNe0A1
[pastebin/gist/etc link here]
If I missed something up sorry. Also if ya need more let me know.

Duplicate of #1580


Adding CPU preprocessing to the benchmark

This PR adds the CPU preprocessing (implemented in TorchVision) to the BM_efficientnet benchmark.

CI MESSAGE: [10003340]: BUILD STARTED

CI MESSAGE: [10003340]: BUILD PASSED

CI MESSAGE: [10008269]: BUILD STARTED

CI MESSAGE: [10008269]: BUILD PASSED

CI MESSAGE: [10008727]: BUILD STARTED

CI MESSAGE: [10008879]: BUILD STARTED

CI MESSAGE: [10008727]: BUILD PASSED

CI MESSAGE: [10008879]: BUILD PASSED


[MB-17020] Update transportation offices' shipping offices

Jira ticket
Summary
Follow-up from https://github.com/transcom/mymove/pull/11387 and https://github.com/transcom/mymove/pull/11399.
The last step before deleting the transportation offices listed in this spreadsheet is to update all transportation offices whose shipping office is in that list of TOs to be deleted. The new shipping offices info (provided by Danny) is listed here. This PR updates the shipping offices to reflect the spreadsheet.
When this PR is merged, there should be no more dependencies on the TOs to be deleted, and will be followed up by a (hopefully final) PR to delete those TOs.
Database
Any new migrations/schema changes:

[ ] Follows our guidelines for Zero-Downtime Deploys.
[ ] Have been communicated to #g-database.

Messages

:book:
:link: MB-17020

  Generated by :no_entry_sign: dangerJS against e15bfde17582a69381a87040d6fce33ec3e87bd0


doc: fix arrow direction in comment for PGame.le_trans_aux

For reference, the comment was added here: https://github.com/leanprover-community/mathlib/commit/68452ec1998ff62f33a613e8e36fea3b7e307002

Thanks! :tada:
bors merge


fix(opentelemetry-operator): remove CPU limit from contianers

Having default values makes it impossible to remove the CPU limits since the default values will always be merged in with anything set by the user. Setting CPU limits are considered an anti pattern ref. https://komodor.com/learn/kubernetes-cpu-limits-throttling/

@Starefossen if you're not using this chart as a subchart you can do:
resources:
  limits:
    cpu: null
    memory: 512Mi

But we can follow the same pattern/reasoning as https://github.com/open-telemetry/opentelemetry-helm-charts/pull/745


RuntimeError: arguments are located on different GPUs at /opt/conda/conda-bld/pytorch_1532581333611/work/aten/src/THC/generated/../generic/THCTensorMathPointwise.cu:314

I want to know how to deal with this kind of error.Thank you very much!
the error is:
RuntimeError: arguments are located on different GPUs at /opt/conda/conda-bld/pytorch_1532581333611/work/aten/src/THC/generated/../generic/THCTensorMathPointwise.cu:314

Did you modify the device option in config.py ?


[FLINK-28679][hive] Use fixed version for hive-service-rpc

What is the purpose of the change
*Use fixed hive server2 version. Because the different version of hiveserver2 has different interfaces. Currently, the hive connector uses reflection to get the classes in the hive jar with different versions. However, it doesn't work for the hiveserver2 endpoint because the hiveserver2 endpoint needs to implement the interface in the dynamic hive jars. To solve this, we may need to introduce a Proxy to delegate the different requests to a hive-free server.
Verifying this change
I have run mvn clean install -T 4 -DskipTests -Pskip-webui-build -Phadoop3-tests,hive3 in my local environment. The problem in the issue doesn't appear.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Please link a build with the hadoop3 profile active to verify that this works.

Thanks for pointing it out. But I find I can not run the nightlies script in my azure pipeline.  It reports
Variables:
  SECRET_S3_BUCKET:
    Parsing expression: <variables.IT_CASE_S3_BUCKET>
    Evaluating: variables['IT_CASE_S3_BUCKET']
    Expanded: Null
    Result: ''
  SECRET_S3_ACCESS_KEY:
    Parsing expression: <variables.IT_CASE_S3_ACCESS_KEY>
    Evaluating: variables['IT_CASE_S3_ACCESS_KEY']
    Expanded: Null
    Result: ''
  SECRET_S3_SECRET_KEY:
    Parsing expression: <variables.IT_CASE_S3_SECRET_KEY>
    Evaluating: variables['IT_CASE_S3_SECRET_KEY']
    Expanded: Null
    Result: ''
  SECRET_GLUE_SCHEMA_ACCESS_KEY:
    Parsing expression: <variables.IT_CASE_GLUE_SCHEMA_ACCESS_KEY>
    Evaluating: variables['IT_CASE_GLUE_SCHEMA_ACCESS_KEY']
    Expanded: Null
    Result: ''
  SECRET_GLUE_SCHEMA_SECRET_KEY:
    Parsing expression: <variables.IT_CASE_GLUE_SCHEMA_SECRET_KEY>
    Evaluating: variables['IT_CASE_GLUE_SCHEMA_SECRET_KEY']
    Expanded: Null
    Result: ''

Could you give me some hints on how to run the test with the hadoop3 profile in azure?
[1] https://dev.azure.com/1059623455/Flink/_build/results?buildId=313&view=logs&j=b1fcf054-9138-5463-c73c-a49979b9ac2a

When running personal CI, change https://github.com/apache/flink/blob/master/azure-pipelines.yml#L80 to https://github.com/apache/flink/blob/master/tools/azure-pipelines/build-apache-repo.yml#L127.
For PRs, change https://github.com/apache/flink/blob/master/tools/azure-pipelines/build-apache-repo.yml#L73 to https://github.com/apache/flink/blob/master/tools/azure-pipelines/build-apache-repo.yml#L127.

@zentol The CI test passes with the hive3 profile. Could you spend some time reviewing the PR? Thanks a lot.

The misc module passes both in the hive3 and hive2 profiles.


Type safety fix

This brings back type comparisons to Value - they must not be removed because Unsafe.As here is used to completely bypass type safety which Value was previously upholding manually by reinterpreting the object reference as either concrete object type or as concrete struct box. Removing that safeguard results in code that can derference arbitrary type A as arbitrary type B, which breaks type safety and can lead to e.g. reinterpreting a struct box with object references as a class with non-object reference fields, writing junk into them, which best case scenario will lead to early AccessViolationException or ExecutionEngineException or in the worst case to silent memory corruption.
I'd like to apologize for introducing this early on as a performance optimization that, technically speaking, "approaches to the problem optimally, doing exactly as much work as required, no more no less", but comes with learning curve. I have re-added the correct the type checks and wrote a comment for better context. Lessons learned.
Also, I'm saddened to see the dispatch by enum value going away - type match switches are not compatible with nice jump table optimizations (in pretty much any language).

Yes, I spent quite some time debating the dispatch switch with myself :)
But in the end I didn't feel like it made a big enough difference in performance to justify the added code gymnastics and maintenance burden. I never liked the dynamic payload design.
Proper sum types would be optimal, and I have a feeling they're coming soon.

Proper sum types would be optimal, and I have a feeling they're coming soon.

The earliest they would arrive at is likely .NET 11 - it's a very big feature in terms of impact on the ecosystem.

But in the end I didn't feel like it made a big enough difference in performance to justify the added code gymnastics and maintenance burden. I never liked the dynamic payload design.

There are a few ways to use the current design of your choice while also dispatching by enum value. This is commonly done by having both the list of opcodes as independent types but also an enum which describes all opcodes that there are. I'm going to take a stab at it a bit later to see which form of "opcodes as objects that implement an interface/inherit base class" is faster while retaining current level of convenience.

Please, be my guest!
I've been staring at the alternatives for long enough to get slight tunnel vision.


Re-running tests

Re-testing with tiny-lru & updating README.md & data.csv
Fixes #4

Merged 'cause I assume github is not fun on a phone.


php-debug: Rebuild for icu4c

php-debug: Rebuild for icu4c

:beers: @BrewTestBot has triggered a merge.


fix: update README.md

Added some of the requirements to the Readme

This won't get merged, the lint check fails because this PR needs to have a single commit. The commit title Not the PR title Must follow this convention http://docs.kubeinit.com/contributing.html#linting-commits
To have this passing, just squash the 2 commits into a single one, and adjust the tile like:
fix: update README.md

I just cherry-picked your commits and made the fixes, closing in favor of https://github.com/Kubeinit/kubeinit/pull/311


Correct Tile row and col number

After using gdal2tiles2.py to cut tiles, the row and column number of the generated image starts from 0 and 0 by default. Can I input the longitude and latitude to make the row and column number correct? At the same time, in this case, the upper left corner of the image is taken as the starting point of slice by default. However, the upper left corner of any image is not exactly located in the upper left corner of a bounding rectangle under the leaflet slicing rule. Is there any way to crack it?

In this coordinate system lat and lng are pixels. Tiles start at 0,0 from the upper left corner. I don't understand what is wrong with the numbering of the tiles? As well as I have not understood your problem you try to fix.


Readme and documentation updates

There are quite a substantial batch of updates here. Highlights:

New README.md that is hopefully much more friendly, and highlights some great new V1 features like the Sandbox
Updates to the ASCII art repo detail (in README and docs)
New docs landing page
New main architecture diagram
Combining Maintainers section into Contributors section
Renaming Key concepts to Understanding FireFly
New doc article summarizing what FireFly is - Introduction to Supernodes
New doc article on Public and Permissioned Blockchain
New slides
New screenshots

Codecov Report

Merging #708 (3330469) into main (c9ae803) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 3330469 differs from pull request most recent head 135f4d6. Consider uploading reports for the commit 135f4d6 to get more accurate results

@@            Coverage Diff            @@
##              main      #708   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          323       323
  Lines        19887     19887
=========================================
  Hits         19887     19887

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9ae803...135f4d6. Read the comment docs.

Big thank you for all the type checking! 🙇
I punted for Web3


Publication experiment

This PR contains experiments on estimating the publication delay/determining which category has the fastest publication rate. I also updated the preprint to published mapper so I can have more accurate results. The time to publication is a reburish of Marvin's lifeline curves.

Cool analysis! I didn't think about looking at number of versions. I guess you could also use different preprint versions as a gold set for your distance/embedding matching algorithm (I'm not sure if you already did that or already found a good way to set the cutoff for the matches).
If you're interested in including the version_count_vs_publication_time figure in the manuscript, you might want to consider something like a ridgeplot where you do a KDE plot for each version count. Mostly because I've always wanted an excuse to do a ridgeplot but never had a good use. I could help make the figure if you want.
I might have also chosen a hexbin plot for the article_distance_vs_publication_time figure, mainly cause I like hexagons and I'm more of a seaborn guy than a plotnine guy.
One thing I thought might be interesting is seeing if any of your principal component dimensions are strongly correlated with time to publication. Or even coloring your embedded documents with time to publication.
For the time_to_published_refurbished nb and half life analysis, it might also be worthwhile to calculate the half life for papers that eventually get published which would get around some categories that never reach 50% publication rate.
Let me know if you want help with anything.
Thanks,
~M


update readme

Link to the Expo installation discussion

Axel thanks for the PR, but wouldn't it be better to directly include a withMMKV.ts config plugin in this repository? That way the user doesn't have to manually download and add it, it's just a simple expo install react-native-mmkv command

Oh yeah it would be much better! But this solution is very sketchy, it's only temporary. I don't know what to do. I might try to find some time to do this but I'd prefer working on a better solution instead.


Can't hightlight Assembly Language correctly

Assembly language coloring is wrong. I use MIPS Assembly Syntax highlighter for my MIPS file. After pasting as either RTF/HTML, the highlight result was really wrong.
It should be similar to this format:

But it is actually like this:

i have the same problem

It should be fixed in this Pull Request


ADD[#133]: Add docker cheatsheet link

Be noted that 133 is the issue ID

What is the purpose of the change

This pull request adds a link to the Docker cheatsheet to the README.md file in the topic/docker directory. This will provide users with a quick and easy way to access comprehensive information about Docker.

Adding a link to the Docker cheatsheet to the README.md file in the topic/docker directory will make it easier for users to find and use this resource. This will help users to learn more about Docker and to use it to build and deploy their applications.

Thanks @dcompanykrish

@tungbq ,Thank you for merging my PR! I appreciate your feedback and will make sure to  enhance the content in the future.


Allow the user to pass in weekly count data

Goal
Current formulation requires count data to be daily. Want to allow the user to pass in weekly count data.
Requirements

[ ] allow the user to specify that the counts being passed in are weekly sums (not just observations on a single day of the week)
[ ] modify model to either take in daily or weekly data, and produce either daily or weekly forecasts

Context

@akeyel 's suggestion + likely necessary change for shifting reporting requirements

I'd suggest you do this by adding an additional accumulate functionality vs changing the input (i.e daily but with NAs and in model aggregation). You can then add helper functions for users to make specifying this easier.

So suggestion would be if the user has weekly data, provide helper functions and examples in the vignette to show how to convert weekly data to daily to pass into the wwinference() wrapper function.
I would think the best thing to do here would be to set the weekday effect rather than estimate it? So we would want the user to indicate that the data in its original form was weekly rather than just say a very weird reporting effect of daily data.

you can do it that way but as its multiplicative it won't quite be right. Its better to explicitly aggregate


QTooltip "self" prop issue

Came across an odd bug today I thought I should point out.
The quasar component QTooltip has a prop which is "self", but when trying to set that python understandably doesn't like it...
The error thrown is: TypeError: __init__() got multiple values for argument 'self'
I assume this will affect all quasar components with a "self" prop (but I haven't tested this), I had a quick search in quasarcomponents.py and can see that these components all have that prop:

QMenu
QPopupProxy
QTooltip
QPopupEdit

Thanks for this. Did you try setting this attribute after initializing the instance?
t = jp.QTooltip(...)
t.self = 'bottom left'

I think it should work based on the error you are getting.

I hadn't tried that but it works, thank you!


add proposed example usage

Let me know if you'd like to merge this as-is and iterate, or if you're planning on pushing a new version first.
In general, we need to decide who should have merge permission here too.  I shouldn't be the only one.

Either way is fine.. I was going to update for capability-sets but didn't get around to it yet.  I could also do that as another pull-req on top.


External helpers doc: this → self

In the source, the helpers are assigned to self, not this.
https://github.com/babel/babel/blob/5b89849f432cfc034860f495b5001039123e7754/packages/babel-helpers/src/helpers.js#L297

thanks!


How to leave nested zones?

I am forking over multiple levels the current zone and want to achieve to return to the parent zone.
Root
| -> Zone A
|   | -> Zone B

Zone A gets forked from Root and Zone B gets froked from A.
I am using Observables and have noticed that the execution of the success callback in Zone A is called in Zone B.
Is there a way to leave Zone B?

@CSchulz , can you post some sample code? thanks.

Here it is, I was too fast with creating the issue. :laughing:
http://plnkr.co/edit/mOVNKiBAGTQD6KWFg8dg?p=preview

@CSchulz , you can use the Zone you want at any time, in this case, you can just do like this.
http://plnkr.co/edit/TzzzUfeuLngcEzziOBFF?p=preview

Hum, I don't see a real difference just some more logging statements, right?
I want to see in line 56 Zone A instead of Zone B. The inner Zone B should be left and Zone A should handle the success callback of the outer Observable.
http://plnkr.co/edit/Z1oEA3FxAPQoyMw9dqT4?p=preview

@CSchulz , sorry , I didn't click save....
http://plnkr.co/edit/8bsipFXxgzACdOSN6mlb?p=preview

Thanks. So it is okay to directly access the parent?
Would it not be nice to have the possiblity to "leave" the current zone per command like Zone.current.leave to force an exit.

I use Zone.parent to just for convenience, you can keep the zone which forked with name A and use zoneA here.
And in fact, it is not leave, the real result is
Root
-> Zone A
-> Zone B
-> Zone A
-> Zone B
-> ZoneA
-> Root
(we don't put angular zone here to simplify this issue)
So, I believe there is no way to force to leave current zone until  current invoke/invokeTask finished or error occurs.


Built-in JavetProxyConverter: Better error reporting

Hey so when I first started using the very first versions of Javet back in version 0.x.x I needed to proxy a java API so it could be called from javascript. Back then, Javet did not have this feature, so I created my own way to do it, which was very time consuming and error prone. Nowadays I was reading the Javet documentation I noticed that Javet now supports this with JavetProxyConverter which is great! I noticed it even supports function overloading even though javascript doesn't, by making all functions in javascript take varArgs and then resolving them at runtime to the appropriate java method.
However it doesn't report any errors or warnings and doesn't even throw any exceptions when calling a method with missmatched parameter count or  wrong parameter types. I understand this can't be detected on javascript side because all proxied methods take varArgs, but it can be detected on the java side. And in my opinion it should, otherwise this hides many errors.
An example:
public class TestObj {

    public void test(){
        System.out.println("Called test");
    }
    public void test(int v){
        System.out.println("Called test2 ");
    }
}

try (NodeRuntime v8Runtime = V8Host.getNodeInstance().createV8Runtime()) {
       File f = new File("main.js");
       JavetProxyConverter c = new JavetProxyConverter();
       v8Runtime.setConverter(c);
       TestObj t = new TestObj();
       v8Runtime.getGlobalObject().set("testObj", t);
       v8Runtime.getExecutor(f).execute();
}

main.js:

testObj.test(1,2,3); //silently fails with no error or warning and continues execution
testObj.test();
testObj.test(2);
console.log("After test");

This prints:
"Called test"
"Called test2"
"After test"
In my opinion it should stop execution on the first call to testObj.test(1,2,3) because no such method exists and it should report an error message about wrong parameter count and the same should be done if the parameter types are the wrong type. Like I said I understand this is not possible to do on Javascript script side, because all proxied functions are varArgs but on the Java side in ScoredExecutable.java, it seems like it's already doing all those checks, but when the totalScore is 0 it doesn't report why its 0. I think all cases where totalScore = 0, it should report the corresponding error and stop execution. It would be very helpful to have the line number aswell where that error happened too.
I understand we can already create our own JavetProxyConverter but my suggestion is about improving the current built-in proxy  converter. What do you think?

Thank you for reporting this and sharing your thoughts. That makes sense.
Calling a JS function with arguments mismatch is valid with the rules as follows.

If input argument size  > function argument size, truncate the input argument size to the function argument size.
If input argument size < function argument size, append the input arguments with undefined till its size matches the function argument size.
Do not report error at all.

Javet follows these rules a few years ago. I guess what you discovered is more like a bug. It's supposed to call the most appropriate Java function with the rules above. Somehow, it doesn't. I think it's a bug and will fix it.
Please let me know if that works for you, or if you have any questions.

Hmm I see. For me error reporting is the priority, I'd like to avoid implicit behaviour if possible. The reason is, usually when I want to proxy java objects, this means I'm trying to expose some API's only available in Java, to the node.js world, so node.js users can consume my Java APIs. When a user is consuming a new API that they are not familiar with, my priority is for them to learn it, learn the function names, how many params each takes, argument types etc... I want for them to know as soon as possible when they're doing something wrong, I dont want to hide it. I think most people when using a java proxy converter, probably have the same goals. I would prefer if the built-in proxy converter worked this way, but if there's demand for implicit behaviour like the rules you mentioned, maybe a sort of "ProxyMode" feature can be introduced, like: "ProxyMode.LAX" and "ProxyMode.STRICT", where "LAX" would work with the rules like you described and "STRICT" would correctly report miss-matching parameter count or parameter types. What do you think?

I think the current behavior is to return undefined, and yes, it can throw an error instead.


[NEW ALGORITHM] ADD Factorial (Iterative) Algorithm

Issue will be closed if:

You mention more than one algorithm. You can create a separate issue for each algorithm once the current one is completed.
You propose an algorithm that is already present or has been mentioned in a previous issue.
You create a new issue without completing your previous issue.

Note: These actions will be taken seriously. Failure to follow the guidelines may result in the immediate closure of your issue.

Name:
[Factorial (Iterative)]
About:
Propose a new algorithm to be added to the repository

Labels:
new algorithm, gssoc-ext, hacktoberfest, level1

Assignees:

[x] Contributor in GSSoC-ext
[x] Want to work on it

Hi
Can you please assign me to this issue?
Thank you


[CMT-1016-1392] Article Request: Building with Yearn — hack the future of DeFi

We need to add farrahmay's article "Building with Yearn — hack the future of DeFi"
Type: [article]
Link to the original article: Building with Yearn — hack the future of DeFi

pr: https://github.com/yearn/yearn-comms/pull/1400


pubsub: support auto-named subscriptions.

Fixes #748
Related https://github.com/GoogleCloudPlatform/gcloud-ruby/issues/193
Currently, the JSON API doesn't create subscriptions unless a name is given. However, the docs suggest they do. This is a PR prepared for when the Pub/Sub auto-named subscription feature is supported.

We can revisit this if we get some clarity around https://github.com/GoogleCloudPlatform/gcloud-ruby/issues/193.


[🐞] If Signal is used by useTask$ it doesn't re-render should it work that way?

Which component is affected?
Qwik Runtime
Describe the bug
On button clicking I set value of Signal to true, If Signal is true, I want to hide button until task is completed, it works with useVisualTask$ but doesn't work with useTask$, am I doing something wrong?
check out reproduction url https://stackblitz.com/edit/qwik-starter-sbzklc?file=src%2Froutes%2Findex.tsx,package.json
export const ServerTask = component$(() => {
  const page = useSignal(1);
  const loading = useSignal(false);
  useTask$(async ({ track }) => {
    track(page);
    if (loading.value) {
      await new Promise((r) => setTimeout(r, 1000));
      loading.value = false;
    }
  });
  const increase = $(async () => {
    page.value++;
    loading.value = true;
  });
  return (
    <>
      {page.value} - {loading.value ? 'loading...' : 'loaded!'}
      <br />
      {!loading.value && <input type="submit" onClick$={increase} />}
    </>
  );
});

Reproduction
https://stackblitz.com/edit/qwik-starter-sbzklc?file=src%2Froutes%2Findex.tsx,package.json
Steps to reproduce
No response
System Info
npx envinfo --system --npmPackages<EMAIL_ADDRESS>--binaries --browsers

Additional Information
No response

Looks like there's an issue with the useVisibleTask example too. The page count doesn't increase.

Looks like there's an issue with the useVisibleTask example too. The page count doesn't increase past 2.

I didn't saw it at first, but you are right, maybe that's also a bug?
I have edited the code
    {!loading.value && (
      <input
        type="submit"
        value="Button that works only one time with useVisibleTask$, but always with useTask$, why?"
        onClick$={increase}
      />
    )}
    <input
      type="submit"
      onClick$={increase}
      style={`${loading.value && 'background:red;'}`}
    />

I wanted to take another look and try a few things. It seems the use of await inside useTask is causing the bug. I created an example repo with 3 example components. The only difference between each component is the code within the useTask.
https://stackblitz.com/github/tuurbo/qwik-task-bug?file=src%2Froutes%2Findex.tsx

I think I encounter a similar bug in the QwikCityProvider in line 504. The update call routeLocation.isNavigating = false; is triggered, but useTask$ is not always notified. It works with useVisibleTask$ for me.

Let's wait until v2 alpha is out to check if the bug still exists there. In the mean time it would be very helpful to create the repro in https://qwik.dev/playground so that it's easy to test with the alpha

this works as expected because of how promises work
here is the correct way to handle true/false loading
          onClick$={[
            $(async () => {
              await setLoading(true);
            }),
            $(async () => {
              await increase();
              await apiCall();
            }),
            $(async () => {
              await setLoading(false);
            })
          ]}

https://qwik.dev/playground/#f=7VhRb9NADP4rVnhIxtq0G5rQ2hUkYE9ITGIgHhBCaZpuEW0SJS0bmvrf%2BWxf7i5LNybxhEQe1sR39tk%2B33ef5xXN8YvT031VM7B3rrwJrg3IiBW6HqkrazBv3tTlDd99ZnbQ22H5Dp5Yi5pY4Qoz50p0dGDHlHjoIL9qslmXH9ac0NHAfK4AB9j0CS2TVZOpdKc%2FrQYOHArpJ7QY1M0UzaRdMy%2F4XAKPZ%2BQ7S%2BpMzIseHk5Fwu8xUGRrJT5hCXk4HHh6A0%2BDg%2BQj52LNNgxoTLFkZRvOvITFpOh5YiZgtnljFzomAddvE1wqbE8B3I%2Bnd9FGUS3DjiRE9YCOxuPxAaxa27j9LekyVu8MkdpZ85hEKvRyKMJ7SZI5nSxxZsxMc8bcWDvkXCHKlxTZ0lQ0MOqj5%2FLQu4vzyw%2Bf6MvFx%2FekouejB9yZZ2BPoBxVHnp%2BaKpMOiNJxj7lZAmutl%2FX7W4k5fmgjQWOCdRNwfZj4SAu90SBH%2BtfzAyln3f5ecwR%2FHBi2xzri0n1A3CHlsIQ7qBKFlqwJ9XtlL4vca8Nb7L86nrDNbxaTElEDS5XnNqXmBQ4rDu%2FrYSNTsDWmHxoi0LgnCBnZ9pKvFoDSnJwmLOREQgha2hT6qkV4id4osw1pvZENSDPYH%2FpdVJgVKGuKEPWDH9lTUiLrTQ3y%2BSHbD6lSGRskZcbpz9GvAZPzYvhvITna0Q4ZuEjIX9ueMVQ6iNEAA1YgT1Z2CfmePBvDvIJYpVuV1Wdb2IyBHeEO9FQ3bSEIhNY0DqrD02Y4P5H8goz1yA%2BZf30oI4lADQcFVgiUHWVcTz4O1zktTJd9I7larsupnSVVG3IoE9XxVA4qmoN0TLWmymKoMZdAcPVLaHg8wU9S9O0TZxR9xIkfauC%2FJ2DgF3HczPLgqWZ2GLjawqwvQFNKCjKoKeqVWa%2FgVhgM7NAxYEnb9uuWdc%2BH5H2sU3k3VdPSnuh1z09dOCLSc6ge3YH7RX3dIvtLaZg1R%2FvYNnfLbUXUXyT3uc3P2OmUe9aTbd1U6JIAmmSsjroOlRWSZpvUI7393kcn2CXLRmQldG1cIvs1nRbTwZhXC20%2FxXpnw%2FHtv5T5H%2BSIv8G
the reason why the example before only worked with .then() is that it was a side-effect
apiCall().then(() => {
  setLoading(false);
});

the signal was fired async after apiCall finishes the task


I am a participant trying my best to navigate through  git

I am a participant trying to navigate through git

Try git fetch on your branch

Then git pull
Then git merge main
Then fix the issue and then commit and push @WatchTower-Technology

Ok I’ll try it out . Thank you.
On Sat, Jun 8, 2024 at 9:24 PM, Ayoola Abdulqudus @.***>
wrote:

Try git fetch on your branch

Then git pull
Then git merge main
Then fix the issue and then commit and push @WatchTower-Technology
https://github.com/WatchTower-Technology

—
Reply to this email directly, view it on GitHub
https://github.com/Markson17/MLSA-GitHub-Practice/pull/5#issuecomment-2156171997,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BH2KSSRM5M7FRS67TCJMEMTZGNSBLAVCNFSM6AAAAABJAFCO4CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJWGE3TCOJZG4
.
You are receiving this because you were mentioned.Message ID:
@.***>


GitLab request source lacks new_comment parameter in update_pull_request

Report
What did you do?
I'm trying to setup danger to work with GitLab EE installation. However, I'm getting a crash due to lack of new_comment argument in update_pull_request method of GitLab request source. Here's the call site.
I'm using Fastlane to run danger and I'm faking CI environment with Fastlane. Basically my lane is just fakes environment & calls danger(verbose: true).
What did you expect to happen?
I expected comments to be posted to my MR on GitLab.
What happened instead?
[!] Exit status of command 'bundle exec danger --verbose' was 1 instead of 0.
bundler: failed to load command: danger (/Users/nkasyanov/.rbenv/versions/2.3.1/bin/danger)
ArgumentError: unknown keyword: new_comment
  /Users/nkasyanov/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/danger-3.5.5/lib/danger/request_sources/gitlab.rb:100:in `update_pull_request!'
  /Users/nkasyanov/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/danger-3.5.5/lib/danger/danger_core/dangerfile.rb:247:in `post_results'
  /Users/nkasyanov/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/danger-3.5.5/lib/danger/danger_core/dangerfile.rb:277:in `run'
  /Users/nkasyanov/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/danger-3.5.5/lib/danger/danger_core/executor.rb:27:in `run'
  /Users/nkasyanov/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/danger-3.5.5/lib/danger/commands/runner.rb:66:in `run'
  /Users/nkasyanov/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/claide-1.0.1/lib/claide/command.rb:334:in `run'
  /Users/nkasyanov/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/danger-3.5.5/bin/danger:5:in `<top (required)>'
  /Users/nkasyanov/.rbenv/versions/2.3.1/bin/danger:23:in `load'
  /Users/nkasyanov/.rbenv/versions/2.3.1/bin/danger:23:in `<top (required)>'

Your Environment

Which CI are you running on? — locally, faking Jenkins environment, though
Are you running the latest version of Danger? — Yes, 3.5.5

Looks right, you want to send us a PR adding that arg? to the gitlab provider?

@orta I'll try to make one!

Rockin' we got instructions to get started here

Hmmm I didn't expected that to happen, thank you!


SW-3937 Add project ID, name to reports

Update the database schema to allow project-specific reports.
The logic for writing the reports and for populating them with the correct
information will follow in other changes.

Merge activity

Dec 12, 6:56 PM: @@sgrimm started a stack merge that includes this pull request via Graphite.


Async test exit directly without any error

Here is a test case modified from https://github.com/nvim-lua/plenary.nvim/blob/master/TESTS_README.md, it is  expected failed after 10 seconds
describe("test", function()
    it("async", function()
        local co = coroutine.running()
        vim.defer_fn(function()
            assert(false, "should error")
            coroutine.resume(co)
        end, 10000)
        coroutine.yield()
    end)
end)

I run with neotest +neotest-plenary, which just exist without any error, here is output

========================================
Testing:        /tmp/nvim/xxx_spec.lua

[Terminal closed]

Maybe a issue related to  coroutine or api-fast, I am a little confused with them

@rcarriga  Sorry to bother you.
Could you merge this PR, It is really useful.


Graph Based Games

How would I go about using this for a graph based game like risk?

@werner-duvaud any advice?

Hi,
Indeed, I think it could be interesting to transform the networks into graph neural networks to work with graph data. You have to change the models.py file.
About the risk game, for the moment MuZero is rather oriented for games with 2 players who play in turn.

@datavistics did you ever implement an example with a GCN ?


Add support for LocalDate

As per the comment at http://joel-costigliola.github.io/assertj/assertj-joda-time.html, I'd like to request support for LocalDates to be added.
I just migrated some code to use a LocalDate instead of a DateTime since the time aspect was not actually needed and was simply causing issues. While migrating some tests I was surprised to find out only LocalDateTime and DateTime were supported, not LocalDate (or others such as DateMidnight and LocalTime).

That is a missing piece indeed.
Want to contribute it ?


CLN: Handle optional invoice fields

Fixes https://github.com/lnbits/lnbits/issues/2055
Never coded python before, so I had to wing it, but at least it works.

Can confirm https://github.com/lnbits/lnbits/pull/2056/commits/eef03f225296dccc9c9ae1a1842931ed327fa41c works for me. I had actual (not just theoretical) issues with description, bolt11, and amount_msat being unset, and now it works.


EfficientNET.onnx does not run in TensorRT

Hi,
I've got this error for running the converted EfficientNet from PyTorch to Onnx in TensorRT:
Traceback (most recent call last):
  File "tensorrt_python.py", line 59, in <module>
    context = engine.create_execution_context()
AttributeError: 'NoneType' object has no attribute 'create_execution_context'

Can anybody help me?
TensorRT version: 6.1.05
Pytorch: 1.1.0
Onnx: 1.5.0

There was an error during engine creation hence engine is None. You have to provide more information how your engine is created because engine creation can fail for various reasons.

There was an error during engine creation hence engine is None. You have to provide more information how your engine is created because engine creation can fail for various reasons.

See, I convert b2 model to onnx and check results, It looks good.
But when I load the onnx model using tensorRT， it outputs many warnings and costs much longer time than convert resnet50.

Note the environment :
Windows 10 x64   GPU 1650 CUDA10,  pytorch 1.1.0 TensorRT 7.0
The output logits are different from the onnx out ( which are the same as pytorch ).
I also try to read some documents about tensorRT， But can not solve this issue.

There was an error during engine creation hence engine is None. You have to provide more information how your engine is created because engine creation can fail for various reasons.

I use tensorRT python sample for creating the engine.
def build_engine_onnx(model_file):
    with trt.Builder(TRT_LOGGER) as builder, builder.create_network() as network, trt.OnnxParser(networ$
        builder.max_workspace_size = common.GiB(1)
        builder.max_batch_size =32
        # Load the Onnx model and parse it in order to populate the TensorRT network.
        with open(model_file, 'rb') as model:
            parser.parse(model.read())

I had a problem with converting the EfficientNet from PyTorch to ONNX.  ONNX can't export SwishImplementation. I use this line to convert.
model.set_swish(memory_efficient=False)
Is it possible this layer causes the problem?

Finally, I could run the efficientNet model using this environment:
TensorRT 7
ONNX 1.5.0
Pytorch 1.3.0
torchvision=0.4.2

@Soroorsh  hey did you give any output names? i am getting the same error

@Soroorsh hey did you give any output names? i am getting the same error

Hey,
I'm sorry for the belated answer,
I've used this code:
  model_name = 'efficientnet-b0'     model = EfficientNet.from_pretrained(model_name)     model.set_swish(memory_efficient=False)     model.eval()     dummy_input = torch.randn(1, 3, 224, 224)     torch.onnx.export(model, dummy_input, "efficientnet-b0.onnx",['input0'])

Do you get non zero outputs when do inference with TensorRT.
For me at least although it converts fine to TensorRT my outputs are always zero.
Using a trained network and a real image for onnx conversion. Infeence in PyTorch and onnx works but for the same input in TensorRT I always get a 0 tensor

@kochsebastian Even I am facing the same issue with TensorRT model. As soon as I convert the onnx model to tensorRT version, the performance drops completely.


Minor improvements to docker build config

Fix warnings related to absolute path in docker assembly
Update docker-maven-plugin to current version
Remove some unnecessary deps

retest this please

LGTM, thanks @pgier !


The board column tests don't cleanup after themselves.

Possibly related to openshiftio/openshift.io#4299

Codecov Report

Merging #2278 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2278   +/-   ##
=======================================
  Coverage   69.41%   69.41%
=======================================
  Files         175      175
  Lines       16407    16407
=======================================
  Hits        11389    11389
  Misses       3924     3924
  Partials     1094     1094

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4909a90...c066a28. Read the comment docs.


Error - cannot convert bool* to int*

Using current master branch, I get
Attempting on building on ubuntu 22.04 using CMAKE_CXX_STANDARD=14 and CMAKE_BUILD_TYPE=Release
raygui/src/raygui.h:1946:34: error: cannot convert ‘bool*’ to ‘int*’ in assignment
 1946 |     if (active == NULL) active = &temp;
      |                                  ^~~~~
      |                                  |
      |                                  bool*

Manually changing temp to int solves it, but I don't get it

Sorry, invalid ticket - it was not on master


fix: add a container class to css rule

The container-1D34oG has the default background color in the friends tab, located on the homepage.

Fixed in 3f47725d08a15bb7a15089b003cccb6cbc9430c3


docs(rust): make node commands short docs clearer

Current Behavior
When finding what I can do with ockam nodes in command line, I was given short descriptions for commands, but from those descriptions I assumed different usage than what is actually expected.
E.g. based on description Stop Nodes I expected the ockam node stop to stop all nodes. Wrong assumption of course, but still, making the description Stop a node would reveal the intent much better, at least for me.
Proposed Changes
Just changed the short docs for the command line, aligned with how I understood those commands.
Checks

[x] All commits in this Pull Request are signed and Verified by Github.
[x] All commits in this Pull Request follow the Ockam commit message convention.
[x] I accept the Ockam Community Code of Conduct.
[ ] I have accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam-contributors repository.

The last point remains unchecked until this PR is accepted.

@elvanja this is great, thank you.

@elvanja before we can merge please

[ ] Accept the Ockam Contributor License Agreement by adding your Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam-contributors repository.

The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a PR, this will make the commit as verified.

Accept the Ockam Contributor License Agreement

@mrinalwadhwa done in https://github.com/build-trust/ockam-contributors/pull/159


Make a list of fixes for cloud.gov IdP UX

We need better error messaging & form validation to provide better services to our IdP users on par with other parts of the platform.
This will be touching a few different applications.

Shibboleth cloud.gov IdP
UAA cg-uaa
Accounts cg-uaa-extras

Acceptance criteria:

[x] Screencast walking through current state is available in Google Drive: https://drive.google.com/drive/folders/0B_a71ksF1BfnMVRGTEV2dUxHbjg
[x] A list of recommended fixes are in a Github issue

We're going to groom this later today at 3pm with the Navigator team.
cc: @suprenant

Should this try to cover as well 18F/cg-product#496?

Notes from Atlas/Navigator discussion today: https://docs.google.com/document/d/1XCK1qbd0d15oIvSFyPAmlDBYToxZZyDOo6UH5aziK_k/edit

Bret and I discussed this a bit further after the meeting last week. Even if our migration plan is shifting, we do want to still do some user-testing around the invitation-and-provisioning process so that we have a shared understanding of how stable/usable it is for mass-migration purposes.
That said, we don't want to dedicate a huge amount of time beyond that to fixing things found which might throw off other work, though if we can provide some lift and possibly clean up some minor/cosmetic fixes, that would be good.
cc @thisisdano @vz3 @line47

I'm uploaded the screencast to Google Drive ✌

Removed Atlas label as the rest of this one falls on Navigator

@rogeruiz can we still expect those additional requested screencasts from you? If we could get one for Change Password and also Forgot Password, that would be helpful.

Finishing up these videos today. Had to redeploy staging-shibboleth metadata.

Super, thanks @rogeruiz!
FYI @vz3 @thisisdano

Talking about this now in grooming. Thinking we could use some content help and could use @vz3 to lead this so we can see some progress in this sprint or next.

Starting notes here.

Can we place this message on the actual login page?

Remove bottom section including login, create account link (assuming it doesn't work), and reset password.
Change top copy to something like:

Select your sign in method.

Link "Forgot your password?" to /reset-password page.
Need help doesn't seem to do anything. Remove or link to email or GitHub.
Clear prior granting… language unclear. Try something like "I no longer want my information release to Cloud.gov" if this is needed, but it seems like something that really should not go here. Consider moving to account view.

Change header to: "Forgot your password"
Consider adding additional copy here with the instructions that are in the email.

Submitting your password here will reset your password. After you have logged back in, you can change your password.

Change "Send email" to "Send temporary password"

Good

Try something like (though @brittag should def weigh in on this one):
Subject line

Your cloud.gov password has been reset

Body

We have received a request to reset your cloud.gov password. If you did not send this request, please disregard this message.
To reset your password:

Verify your email address here and we will send you a temporary password.
Log in with your temporary password, and you will be prompted to change your password.

Please note that step 2's copy does not match up to how the process currently works. Please address that.

Entering an invalid email results in a non-descriptive Internal Server Error

Entering an invalid email results in a non-descriptive Internal Server Error

Header: Request a temporary password.

Header: Here is your temporary password.
Perhaps include copy button. When I tried double clicking, additional whitespace appeared after the password. Could this be fixed by placing the password in an HTML form field or something?

Same note as before. Can this be incoporated into the next screen?

Same notes as before.

Same notes as before.

Invalid token doesn't result in an error. Please provide feedback.
Consider more instructions here.

When you created your account, you associated it with a multi-factor authorization code generator like Authy or Google Authenticator. Please open the application and enter the token code.

Same notes as before

Consider sending straight to dashboard and adding 'invite users' and 'account settings' functionality to dashboard. Unless…

This is all the info that's in account settings? The 'profile' stuff is not useful unless we add a password reset button here, which I believe is expected behavior.

Let's hyperlink this where the "reset password" links are.

Real time password validation would be very nice.

Fine

Fine but link back to account page would be nice.

@vz3 nice! Is there any other feedback you feel would be helpful (@mogul @thisisdano) before we close this one up and file away the work?

Thanks! Unfortunately we can't make the warning part of the following view due to compliance requirements.
The content changes all make sense. Any recommendations on swapping out images and styling @thisisdano ?

There's a placeholder for this work in PI9

https://app.mural.ly/t/gsa6/m/gsa6/1483852699525


Validation state of overall form

I really like your idea of implementing validation as a mixing instead of configuring it with vue directives in the tempaltes, as most others do.
But one question: I want the "Save" button in my forms to be deactivated until the whole form, ie all fields in the form, become valid.  How would I query for this "overall validity" in your library?
Do I need to create a 'validation group' for the whole form?   Shouldn't there be a global $isValid boolean in the returned $v ?

You have to use validation groups for that purpose. I have done exactly same functionality in my project, please look at this:  https://github.com/mubaidr/SPA-asp.net-api-vuejs-/tree/master/MBO

@Doogiemuc
The root $v object contains $invalid, $dirty and $error values, just like all the keys inside of it:
{
    "example-data-key": {
        "required": true,
        "$invalid": true,
        "$dirty": true,
        "$error": true
    },
    "$invalid": true,
    "$dirty": true,
    "$error": true
}

For your save button, you could simply bind the disabled attribute like so:
<button :disabled="$v.$invalid">Save</button

Like @mubaidr mentioned, you could also use validation groups if your logic depends on specific fields being valid before enabling.
Cheers.


Overriding visibility-plugin

Would you take a PR to enable overriding the visibility plugin via an option in a toJSON call?
Something like user.toJSON({ visibility: false }) ignores the hidden, visible attributes on the model. Or maybe even allowing overrides so you could do user.toJSON({ hidden: ['password'] }) which would override any hidden, visible attributes on the model.

@bsiddiqui Yes, that is a great idea.
Github doesn't allow PRs against the wiki, but if you just paste the documentation into this issue thread I'll update the wiki after merging the PR.

The project leadership of Bookshelf recently changed. In an effort to advance the project we close all issues older than one year.
If you think this issue needs to be re-evaluated please post a comment on why this is still important and we will re-open it.
We also started an open discussion about the future of Bookshelf.js here https://github.com/bookshelf/bookshelf/issues/1600. Feel free to drop by and give us your opinion.
Let's make Bookshelf great again

Any updates here?

@brunocascio No update. If you want to write and submit a PR for this, I would be happy to review and see how it fits into the future releases of bookshelf.

I created #1699 for the visibility: false feature, let me know what you think

Reopened due to renewed interest in fixing it.


First 12 addProduct messages are silently dropped

Expected Behavior
addProduct should work from the first message
Current Behavior
Our default data does not increment the product_id sequence, resulting in dataloss for the first 12 products
Relevant log output
No response
Steps to Reproduce

Setup stack
Send addProduct
Repeat 11 times
13 product shows up in db

Context (Environment)
This will affect customers !
Possible Solution
No response
Version
v0.9.x
Anything else?
No response

Fixed in #1126


crossbeam-epoch's use of offsetof is unsound

See:

https://github.com/Gilnaa/memoffset/issues/9
https://github.com/rust-lang/rfcs/pull/2582#issuecomment-504334939

cc @RalfJung

In particular, on Rust 1.33+, the way offset_of is unsound causes real misbehavior.

Thank you for reporting this.  May I ask how urgent this issue is for the Rust compiler team?  Is it okay for us to wait for @Gilnaa fixing the memoffset crate, or it'd be better for us to fix it now?

Looking at Cargo.lock rustc's reverse dependency tree to memoffset is:

memoffset 0.2.1

crossbeam-epoch 0.3.1

crossbeam-deque 0.2.0

rayon-core 1.4.1

rayon 1.0.1

installer 0.0.0
rls 1.37.0

rustc-rayon 0.2.0

rustc 0.0.0
rustc-ap-rustc_data_structures 491.0.0
rustc_data_structures 0.0.0
rustc_driver 0.0.0
rustc_interface 0.0.0
rustdoc 0.0.0

rustc-rayon-core 0.2.0

rustc 0.0.0
rustc-ap-rustc_data_structures 491.0.0
rustc_data_structures 0.0.0
rustc-rayon 0.2.0 [elided rev deps]

crossbeam-epoch 0.7.0

crossbeam-deque 0.6.3

tokio-threadpool 0.1.10

tokio 0.1.14

rls 1.37.0

tokio-fs 0.1.15

tokio 0.1.14

rls 1.37.0

cc some of these authors:

@cuviper @nikomatsakis (rayon)
@Xanework (rls)
@alexcrichton (rustc-ap-rustc_data_structures)
@carllerche (tokio-threadpool, tokio, tokio-fs)

This is going to take a bit of time to coordinate, I think.
While std::mem::MaybeUninit<T> will hit stable on 2019-07-04 and will make the probability of exploitable UB lower, the macro will still remain unsound. That said, we should mitigate where we can.

While std::mem::MaybeUninit will hit stable on 2019-07-04 and will make the probability of exploitable UB lower

Only if the macro gets changed to use it though.

FWIW the latest rayon uses newer crossbeam, but as tokio shows, that memoffset dependency remains.

Hi @RalfJung, is this issue closed by #402?

@jeehoonkang yes it is, thanks!
Would be nice to get a release of the fixed crossbeam-epoch so that we can get the affected memoffset out of the compiler's dependency tree.

I agree.  Let's track the issue of a new release at #164.
Closing this issue.  Thank you!


Validation error: Impurity reasons of overriding methods must be subset of impurity reasons of overridden methods

Basic example: If the overridden method is pure, the overriding method must be pure as well:
package tests.validation.other.declarations.functions.purePropagates

class MyOpenClass {
    @Pure fun pureFunction1()
    @Pure fun pureFunction2()
    fun impureFunction1()
}

class MyClass sub MyOpenClass {
    // $TEST$ no error "One of the supertypes of this class declares a pure function with this name, so this must be pure as well."
    @Pure fun »ownPureFunction«()
    // $TEST$ no error "One of the supertypes of this class declares a pure function with this name, so this must be pure as well."
    fun »ownImpureFunction«()

    // $TEST$ error "One of the supertypes of this class declares a pure function with this name, so this must be pure as well."
    fun »pureFunction1«()
    // $TEST$ no error "One of the supertypes of this class declares a pure function with this name, so this must be pure as well."
    @Pure fun »pureFunction2«()
    // $TEST$ no error "One of the supertypes of this class declares a pure function with this name, so this must be pure as well."
    @Pure fun »impureFunction1«()
}

:tada: This issue has been resolved in version 0.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
npm package (@latest dist-tag)
v0.4.0
GitHub release

Your semantic-release bot :package::rocket:


"src" in "exclude" in tsconfig.json disables TypeScript settings in Sublime editor

Sublime Text editor (build 3103) with Typescript plugin (0.1.12) doesn't apply tsconfig.json settings for .ts files from src folder.
Due to this, the editor highlights wrong errors. For example,

Experimental support for decorators is a feature that is subject to change in a future release. Specify '--experimentalDecorators' to remove this warning.

If src is removed from exclude in tsconfig.json, the editor is working as intended.

This seems like a limitation in Sublime Text's TypeScript plugin and not related to the seed.
As temporal workaround you can remove src from exclude but generally this config is required for the speed-up workaround for Windows.

It appears that the secondary tsconfig.json file located in src/client messes with Sublime. If you open up one of the e2e scripts (about.component.e2e.ts for example) it doesn't understand what describe, browser, element, etc are. If you delete that tsconfig.json file, it does.

@zachallen - In my experience the support from best to worst === VisualStudio Code / Atom / WebStorm / Vim / Sublime for TypeScript
The support in sublime is lacking to say the least.

The editor (tested in Sublime and VS Code) cannot get typings with tsconfig.json in src (src\client) folder. To solve it, create typings.d.ts with /// <reference path="../typings/browser.d.ts" /> in src (src\client).

I can confirm that the issue mentioned above by @htdt also is the case in Intellij (Webstorm) and adding the typings.d.ts into src/client resolves the issue. Any reason why this file should not be part of the seed?


TypeError: l['$adagio-location'] is undefined

I have an error in my embed .mxl
[error] TypeError: l['$adagio-location'] is undefined
and here is link (SECOND frame)...
http://elib.pl.spb.ru/search_result_full?data=eyJ0eXBlX3MiOiBbIjEyMDAwIl0sICJ0ZXJtIjogWyJkZjBmZmFlZDc4NDBmZjQzYzhiYzJhYmQxOTRhYTA0MiJdfQ==#nota
But it is absolutely correct when I import .mxl to flat.io
https://flat.io/score/65573383c1ff184a0775b637-stehe-still
firefox 119.0.1 x64
(in chrome I have another error [Vue warn]: Error in 5: "TypeError: Cannot read properties of undefined (reading 'timePos')")

@cyrilcoutelier Can you please check?

Hi @jenia0jenia ,
The link you sent, http://elib.pl.spb.ru/search_result_full?data=eyJ0eXBlX3MiOiBbIjEyMDAwIl0sICJ0ZXJtIjogWyJkZjBmZmFlZDc4NDBmZjQzYzhiYzJhYmQxOTRhYTA0MiJdfQ==#nota, is not working for me.
I will need more context.
Can you give me more context on how you are using our Embed API? This way it will be easier for us to reproduce
the issue, and either fix it on our side, or explain the correct API usage.
Thank you in advance!
Best,
Cyril

Closing, issue inactive for more than 1 year.


Bigger Kensetsu icon

The new icon is 10% larger, and priority has been given to the central glyph to ensure it is centered on the menu button

@shlavik Hey! The commit was cherry picked due to the CI processing. This PR might be closed. Thank you!


fix(package): handle empty command string

:tada: This PR is included in version 9.0.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Blazor WebAssembly Not Support Firefox 52

Hi
Are You Support Blazor WebAssembly In Mozilla 62v ?
aspnet core
Blazor WebAssembly 5v
@guardrex
thanks

Probably not ... that's very old. The product unit favors support for the latest versions per our guidance in ...
https://learn.microsoft.com/aspnet/core/blazor/supported-platforms


Turn on More linters

- misspell
- prealloc
- unparam
- nakedret

Signed-off-by: Daniel J Walsh<EMAIL_ADDRESS>

Finally got this to pass all tests.  @baude @giuseppe @vrothberg @jwhonce @QiWang19 PTAL

LGTM


Add support for FUTEX_{WAIT,WAKE}_BITSET

FUTEX_WAIT_BITSET and FUTEX_WAKE_BITSET are extensions of FUTEX_WAIT and FUTEX_WAKE that allow tagging each waiting thread with up to 32 'labels', and then only wake up threads that match certain labels. The non-bitset operations behave like their bitset was fully set (u32::MAX), meaning that they'll wait for anything, and wake up anything.
The only other difference is that FUTEX_WAIT_BITSET uses an absolute timeout instead of an relative timeout like FUTEX_WAIT.
Often, FUTEX_WAIT_BITSET is used not for its bitset functionality, but only for its absolute timeout functionality. It is then used with a bitset of u32::MAX.
This adds support for only that use case to Miri, as that's all std currently needs. Any other bitset is still unsupported.
Update: This adds full support for both these syscalls.

This adds support for only that use case to Miri, as that's all std currently needs. Any other bitset is still unsupported.

It was pretty easy to add full support for these syscalls. I've updated the PR.

It was pretty easy to add full support for these syscalls. I've updated the PR.

Lol, I think I know that feeling. ;) Thanks a ton!

Could you put 306ba8357fb36212b7d30efb9eb9e41659ac1445 into the rust-version file? Then CI will tell us if this also makes Mutex work again in Miri.

I like green CI. :)
@bors r+

:pushpin: Commit 4fdda315cc1d2175a1c49617eb342cdffe8c351f has been approved by RalfJung

:hourglass: Testing commit 4fdda315cc1d2175a1c49617eb342cdffe8c351f with merge 0e2def5c122f3149e1d43dfc368d3d1aeeb0191b...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 0e2def5c122f3149e1d43dfc368d3d1aeeb0191b to master...


Adding Melos for monorepo management

See #680 for details. Let me know if the update to the root readme should be moved or copied to any of the individual project readmes. I was on the fence about doing so but it seems potentially annoying to maintain setup instructions in each individual package as the repo grows. Maybe just add a line to each one saying to refer to the root readme to set up your development environment?
Closes #680.

My plan is to get this PR and the AttributedText PR merged after the next couple releases, because we're almost done with a couple deliverables.
BTW, it looks like Windows tests are failing in CI

My plan is to get this PR and the AttributedText PR merged after the next couple releases, because we're almost done with a couple deliverables.

Cool, I'll keep the branches up to date with main in the meantime.

BTW, it looks like Windows tests are failing in CI

Well this is annoying. Turns out there was a bug introduced in Dart 2.17.0 that causes concurrent pub get processes to fail (dart-lang/pub#3420). They merged a fix back in May but it still hasn't reached the Dart SDK stable channel. I'll investigate a workaround for now.

Yeah, I'd like to get this in, but can we start with the attribution range change?

I'm going to close this because it's so out of date. We still want this. I'll probably refactor for Melos before the next major release. That will be a different PR.


Update .gitignore for .ipynb_checkpoints

This PR includes the .ipynb_checkpoints directory in the .gitignore.

@abooton Since you're on a roll... fancy taking this on? It's trivial :wink:

@trexfeathers Fancy merging this?

Makes sense, I'm merging it


[Python] Build in Amazon Linux 2023 fails

Describe the bug, including details regarding any error messages, version, and platform.
I'm trying to build a slim version of PyArrow, so that it fits in an AWS Lambda function. The base Docker image is public.ecr.aws/lambda/python:3.12, which is an Amazon Linux 2023 OS (based on Fedora).
Building from the Dockerfile below, it fails when trying to create a wheel file. The error message I've got is:
/var/task/arrow/python/setup.py:34: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
  import pkg_resources
/var/lang/lib/python3.12/site-packages/setuptools/__init__.py:80: _DeprecatedInstaller: setuptools.installer and fetch_build_eggs are deprecated.
!!

        ********************************************************************************
        Requirements should be satisfied by a PEP 517 installer.
        If you are using pip, you can try `pip install --use-pep517`.
        ********************************************************************************

!!
  dist.fetch_build_eggs(dist.setup_requires)
/var/lang/lib/python3.12/site-packages/setuptools_scm/git.py:135: UserWarning: "/var/task/arrow" is shallow and may cause errors
  warnings.warn(f'"{wd.path}" is shallow and may cause errors')
running build_ext
creating /var/task/arrow/python/build
creating /var/task/arrow/python/build/temp.linux-x86_64-cpython-312
-- Running cmake for PyArrow
cmake -DCMAKE_INSTALL_PREFIX=/var/task/arrow/python/build/lib.linux-x86_64-cpython-312/pyarrow -DPYTHON_EXECUTABLE=/var/lang/bin/python3 -DPython3_EXECUTABLE=/var/lang/bin/python3 -DPYARROW_CXXFLAGS= -DPYARROW_BUILD_CUDA=off -DPYARROW_BUILD_SUBSTRAIT=off -DPYARROW_BUILD_FLIGHT=off -DPYARROW_BUILD_GANDIVA=off -DPYARROW_BUILD_ACERO=on -DPYARROW_BUILD_DATASET=on -DPYARROW_BUILD_ORC=off -DPYARROW_BUILD_PARQUET=on -DPYARROW_BUILD_PARQUET_ENCRYPTION=off -DPYARROW_BUILD_GCS=off -DPYARROW_BUILD_S3=off -DPYARROW_BUILD_HDFS=off -DPYARROW_BUNDLE_ARROW_CPP=on -DPYARROW_BUNDLE_CYTHON_CPP=off -DPYARROW_GENERATE_COVERAGE=off -DCMAKE_BUILD_TYPE=release /var/task/arrow/python
-- The C compiler identification is GNU 11.4.1
-- The CXX compiler identification is GNU 11.4.1
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- System processor: x86_64
-- Performing Test CXX_SUPPORTS_SSE4_2
-- Performing Test CXX_SUPPORTS_SSE4_2 - Success
-- Performing Test CXX_SUPPORTS_AVX2
-- Performing Test CXX_SUPPORTS_AVX2 - Success
-- Performing Test CXX_SUPPORTS_AVX512
-- Performing Test CXX_SUPPORTS_AVX512 - Success
-- Arrow build warning level: PRODUCTION
-- Using ld linker
-- Build Type: RELEASE
-- CMAKE_C_FLAGS:  -Wall -fno-semantic-interposition -msse4.2  -fdiagnostics-color=always  -fno-omit-frame-pointer -Wno-unused-variable -Wno-maybe-uninitialized
-- CMAKE_CXX_FLAGS:  -Wno-noexcept-type  -Wall -fno-semantic-interposition -msse4.2  -fdiagnostics-color=always  -fno-omit-frame-pointer -Wno-unused-variable -Wno-maybe-uninitialized
-- Generator: Unix Makefiles
-- Build output directory: /var/task/arrow/python/build/temp.linux-x86_64-cpython-312/release
-- Found Python3: /var/lang/bin/python3 (found version "3.12.0") found components: Interpreter Development.Module NumPy
-- Found Python3Alt: /var/lang/bin/python3
CMake Error at CMakeLists.txt:268 (find_package):
  By not providing "FindArrow.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "Arrow", but
  CMake did not find one.

  Could not find a package configuration file provided by "Arrow" with any of
  the following names:

    ArrowConfig.cmake
    arrow-config.cmake

  Add the installation prefix of "Arrow" to CMAKE_PREFIX_PATH or set
  "Arrow_DIR" to a directory containing one of the above files.  If "Arrow"
  provides a separate development package or SDK, be sure it has been
  installed.

-- Configuring incomplete, errors occurred!

PS: I've tried building from PR #34234 as suggested on issue #34240 , but got the same result.
Component(s)
Python

Could you also show the build log of the following part?
RUN mkdir arrow/cpp/build && \
    pushd arrow/cpp/build && \
    cmake -DCMAKE_INSTALL_PREFIX=$ARROW_HOME \
        -DCMAKE_INSTALL_LIBDIR=lib \
        -DCMAKE_BUILD_TYPE=Release \
        -DARROW_BUILD_TESTS=OFF \
        -DARROW_COMPUTE=OFF \
        -DARROW_CSV=OFF \
        -DARROW_DATASET=ON \
        -DARROW_FILESYSTEM=ON \
        -DARROW_HDFS=OFF \
        -DARROW_JSON=OFF \
        -DARROW_PARQUET=ON \
        -DARROW_WITH_BROTLI=OFF \
        -DARROW_WITH_BZ2=OFF \
        -DARROW_WITH_LZ4=OFF \
        -DARROW_WITH_SNAPPY=ON \
        -DARROW_WITH_ZLIB=OFF \
        -DARROW_WITH_ZSTD=OFF \
        -DPARQUET_REQUIRE_ENCRYPTION=OFF \
        .. && \
    make -j4 && \
    make install && \
    popd

Sure, here it is: https://pastebin.com/dvTAYhy9
Given that the part you asked for generated over 1,000 lines, I've decided to share the entire log in an external link.
Please let me know if there's any additional info that I could provide to support debugging this issue.

Thanks.
-- Installing: /var/task/arrow/cpp/build/$(pwd)/dist/lib/cmake/Arrow/ArrowConfig.cmake

is the problem. $(pwd) isn't expanded. Could you use a static path instead of $(pwd)?

No update.
Can we close this as stalled?

Sorry for the late response. Yes, please - feel free to close this issue. Thank you for pointing out the $(pwd) typo.

Sorry for the late response. Yes, please - feel free to close this issue. Thank you for pointing out the $(pwd) typo.