Missing URL constructor definition

Currently:
interface URL {
    revokeObjectURL(url: string): void;
    createObjectURL(object: any, options?: ObjectURLOptions): string;
}
declare var URL: URL;

Should be:
interface URLConstructor {
    hash: string;
    search: string;
    pathname: string;
    port: string;
    hostname: string;
    host: string;
    password: string;
    username: string;
    protocol: string;
    origin: string;
    href: string;
}
interface URL {
    revokeObjectURL(url: string): void;
    createObjectURL(object: any, options?: ObjectURLOptions): string;
    new(url: string, base?: string): URLConstructor
}
declare var URL: URL;

URL spec is here: https://url.spec.whatwg.org/#api

Where is the URL interface currently defined? I can't find it.

it is defined in lib.d.ts.

It doesn't seem to be in lib.d.ts.

GitHub isn't showing the whole file. It cuts off around 11k lines but URL is defined on line 14455

look at the raw view: https://raw.githubusercontent.com/Microsoft/TypeScript/master/bin/lib.d.ts

@mhegazy - is this simply a case of modifying the lib.d.ts type definition? In which case, are you accepting PRs?

Actually @zhengbli I see your recent comment
Just out of interest, in general how do you determine support within browsers/Javascript VMs? Is there a definitive reference? Your comment in this instance seems to suggest the check was 'by hand'.

Here is the living standard for it https://url.spec.whatwg.org/#constructors
On Oct 9, 2015 2:13 PM, "Paul Jolly"<EMAIL_ADDRESS>wrote:

Actually @zhengbli https://github.com/zhengbli I see your recent comment
https://github.com/Microsoft/TypeScript/issues/3753#issuecomment-119321813
Just out of interest, in general how do you determine support within
browsers/Javascript VMs? Is there a definitive reference? Your comment in
this instance seems to suggest the check was 'by hand'.
—
Reply to this email directly or view it on GitHub
https://github.com/Microsoft/TypeScript/issues/2583#issuecomment-146847238
.

@myitcv the lib.d.ts is generated from a spec file produced by Edge, and we make manual changes if something is not quite right with the spec or it is Microsoft specific. We are trying to keep the changes as compatible as possible. There is not a "definitive reference" per se, it is all open to discussion.

@zhengbli - thanks, however I was asking about something slightly different. Specifically this comment:

after trying out on various browsers, we found that the constructor of interface URL is not supported in both IE and Spartan

Reading this it sounds like the tests were carried out by hand. I was wondering if in fact there is a definitive reference you use for what functions/etc are supported in each browser?
The MDN pages have a browser compatibility section, but I don't know how up-to-date/accurate these are.
Incidentally, what is "Edge"?

Oh, for constructors I just open the javascript console in the browser, and run something like new URL() and see what happens. If it gives me an error message, so apparently it is not supported.
Edge is the new Microsoft browser coming with windows 10.

URL constructor is a living standard already. We use it in our code together with polyfill for IE. Is this a reason for not adding it to lib.d.ts that it is not yet supported in IE?

Specifically, this spec. (And its public domain polyfill.) It's an exposure of the internals used to drive the browser's File/Blob URL APIs. Chrome and Firefox implement the living standard pretty well, and it turns out to be really useful to have a URL parser when working on the web. Much neater than using an img or a tag, anyway.

@weswigham agreed.

@weswigham @zuzusik using polyfill is a fair point. And as adding a constructor and instance methods is not a breaking change, it might be fine to do that. I'll send a PR to add them. FYI I'm working on open source the script to generate lib.d.ts soon, so later changes could be accepted on that repo.

Now that the script is to generate the library is open source, PRs are welcomed. Here is some documentation for adding new types to lib.d.ts: https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md#contributing-libdts-fixes

Btw, Edge now support URL constructor - does it mean lib.d.ts can be just regenerated from Edge spec as stated above?

We refresh the definition file from that of IE/Edge every few month. we have not done this in a while. @zhengbli has something in the pipeline, not sure if it includes this change though.

Hmm... wouldn't it be possible to somehow automate this? For example, auto-generate lib.d.ts from WebIDLs?

This is what is happening in https://github.com/Microsoft/TSJS-lib-generator. PRs are always welcomed to make the generation more efficient/standard-compliment.

Oh cool, thanks for the link to the repo! But as for "we refresh the definition every few months" - is there any chance to automate this part (as pre-release script for TypeScript?) so that lib.d.ts would be always up-to-date?

These files come from IE/Edge. so we do it when they have a new version available; so we have little control over that. @zhengbli can talk more about the specifics of the next update.. i think he already picked up a new version.

We are taking another updates after 1.8, as it is very likely that the changes will be big and break many places. Automating the process is definitely possible, however as the spec files are generated from internal builds of Edge, the APIs may not be available yet in the released version. Therefore it makes more sense to review the changes manually now and reduce the interval of updating the spec files in the future.

however as the spec files are generated from internal builds of Edge, the APIs may not be available yet in the released version

I don't really see how is that a problem - just because public release of Edge doesn't support some new spec APIs natively, that doesn't mean people don't use those APIs (through polyfills, in other browsers, etc.) and doesn't mean they don't want those definitions as soon as they're available... Or am I missing something?

@RReverser, I am not sure i understand the problem or the proposal here.
We have lib.d.ts that is generated from the IE/Edge IDL files. @zhengbli updates they, usually quertelly/semi anally.
These definition files may not contain all APIs, or include addtional non-standard ones, or ones that are not standard-complient, for that, we have three files: https://github.com/Microsoft/TSJS-lib-generator/blob/master/inputfiles/overridingTypes.json, https://github.com/Microsoft/TSJS-lib-generator/blob/master/inputfiles/addedTypes.json and https://github.com/Microsoft/TSJS-lib-generator/blob/master/inputfiles/removedTypes.json that we use to make the output correct.
The PR to add URL constructor for instance is using these fiels, see: https://github.com/Microsoft/TSJS-lib-generator/pull/44.
so am i missing something?

or include addtional non-standard ones, or ones that are not standard-complient

Gotcha - this was the part I wasn't aware about and thus asked

Or am I missing something?

(I thought it's just that internal builds contain APIs that are not released yet, but are fully spec-compliant and still could be used for TS)

I am on TS 1.8.9 and this is almost April now, haven't you generated new version yet?

@NekR, PRs are welcomed. see more information in https://github.com/Microsoft/TypeScript/issues/2583#issuecomment-171478734

As an update, this issue should be fixed by https://github.com/Microsoft/TypeScript/pull/7619
We recently took a new drop of the XML spec which has the correct definitions for URL.

Great, thanks for the update.

@zhengbli When may we see the fix? The latest release 1.8.10 doesn't have it.

It is already in master: https://github.com/Microsoft/TypeScript/blob/35b8b42b554d2b98230320b727b452d0abe9aaae/src/lib/dom.generated.d.ts#L11740
it should be in next release.


[FLINK-25819][runtime] Reordered requesting and recycling buffers in order to avoid race condition in testIsAvailableOrNotAfterRequestAndRecycleMultiSegments

What is the purpose of the change
This PR fixes NetworkBufferPoolTest.testIsAvailableOrNotAfterRequestAndRecycleMultiSegments
Brief change log

Reordered requesting and recycling buffers in order to avoid race condition in testIsAvailableOrNotAfterRequestAndRecycleMultiSegments
*Added new test for 'Insufficient number of network buffers' scenario into NetworkBufferPoolTest *
CodeStyle correction for NetworkBufferPoolTest

Verifying this change
It is test
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Please pay attention to the last commit where the global test timeout was removed

@flinkbot run azure

@akalash Do you mind creating a backport for 1.14?

@dawidwys, good idea. I will do that


Preservation of vector database

The vector database seems to be cleared when Docker and the Nvidia AI Workbench are shutdown.  Anyone know how to preserve and reload the vector database between instantiations?

Comments on in the NVIDIA forum are pointing folks at https://github.com/NVIDIA/nim-anywhere

@fewarren - i'm doing a little research on how the preservation should work.
What are some of your requirements?

I am not clear on what you mean by "preservation".
Fred
On Thursday, September 26, 2024 at 06:58:05 AM PDT, JT Casablanca<EMAIL_ADDRESS>wrote:

@fewarren - i'm doing a little research on how the preservation should work.
What are some of your requirements?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

AFAIK
The vector database holds the vectors representing the RAG documents.  I don't want to have to reload the vector database (upload docs) every time I start the same project.
The current project is running an in memory database.  The other project is running a standalone container with a mounted file system that holds the docs.  That file system is available across restarts.  (I'm typing this from memory so I could be thinking of another project)

Hi Joe,
I ran into the same problem and switched to the mounted file system approach.  That solved the persistence issue.  The second problem for me is that the existing Nvidia example code is extremely slow and unreliable when loading more than a few PDF files into the Milvus database.  I am exploring an alternate approach that would allow for a full scale load into the database.  I made some progress but then got deflected and am just now getting back to the issue.  I found an example that I am trying to adapt:
GitHub - ruslanmv/How-to-load-PDF-files-into-Milvus-by-using-Spark: How to ingest and embed PDF files at scale using Spark for Retrieval Augmented Generation. We will walk through the steps required to set up the environment, install the necessary co
|
|
|
|  |  |
|
|
|
|  |
GitHub - ruslanmv/How-to-load-PDF-files-into-Milvus-by-using-Spark: How ...
How to ingest and embed PDF files at scale using Spark for Retrieval Augmented Generation. We will walk through ...
|
|
|
It may be possible to adapt this to run locally.  I am still undecided as to whether to stick with the Nvidia platform or switch totally to this alternative one.  It is critical to find a fast way to load a local file based Milvus database to create a system that is usable.
I hope you make good progress towards your goals.
Fred
On Thursday, September 26, 2024 at 08:34:10 AM PDT, Joe Freeman @.***> wrote:
AFAIK
The vector database holds the vectors representing the RAG documents. I don't want to have to reload the vector database (upload docs) every time I start the same project.
The current project is running an in memory database. The other project is running a standalone container with a mounted file system that holds the docs. That file system is available across restarts. (I'm typing this from memory so I could be thinking of another project)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>


item is undefined when managing databases

Full error with redacted path
fatal: [alpine-dns]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'item' is undefined\n\nThe error appears to have been in '/home/jtl/<snip>/ansible-mysql/tasks/dbs.yml': line 2, column 3,

My playbook looks like this
---
- hosts: alpine-dns
  roles:
      - ansible-mysql
  vars:
      mysql_dbs:
          name: pdns
          state: present
      mysql_root_password: changme
      mysql_db_users:
          - name: pdns
            password: changeme
            state: present
            privs:
                - db: pdns
                  host: <IP_ADDRESS>
                  table: "*"
                  priv: ALL

@jtl999 Thanks for reporting this. The issue was that the task to create the dbs was missing the with_items: "{{ mysql_dbs }}" and has now been resolved.

Yes I figured that out myself and was going to do a PR.
Thanks anyways.


x/sys/windows: NewCallback function does not work

What version of Go are you using (go version)?
go1.9 windows/amd64
on Windows8.1
Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
GOARCH=amd64
GOHOSTARCH=amd64
GOHOSTOS=windows
GOOS=windows
What did you do?
package main

import (
    syswin "golang.org/x/sys/windows"
    // "syscall"
)

var (
    kernel32DLL = syswin.NewLazySystemDLL("kernel32.dll")
    user32DLL = syswin.NewLazySystemDLL("user32.dll")

    procGetCurrentThreadId = kernel32DLL.NewProc("GetCurrentThreadId")
    procSetWindowsHookEx = user32DLL.NewProc("SetWindowsHookExW")
    procCallNextHookEx = user32DLL.NewProc("CallNextHookEx")
)

var hook uintptr

func main() {
    if err := kernel32DLL.Load(); err != nil {
        panic("kernel32.dll not found")
    }
    defer syswin.FreeLibrary(syswin.Handle(kernel32DLL.Handle()))

    if err := user32DLL.Load(); err != nil {
        panic("user32.dll not found")
    }
    defer syswin.FreeLibrary(syswin.Handle(user32DLL.Handle()))

    thread_id, _, _ := procGetCurrentThreadId.Call()

    // use syscall instead of syswin here, and the code will work
    hook, _, _ = procSetWindowsHookEx.Call(2, syswin.NewCallback(callbackFunc), 0 , thread_id)
}

func callbackFunc(code, wparam, lparam uintptr) uintptr {
    ret, _, _ := procCallNextHookEx.Call(hook, code, wparam, lparam)
    return ret
}

What did you expect to see?
NewCallback function in x/sys/windows working correctly as in syscall
What did you see instead?
# command-line-arguments
golang.org/x/sys/windows.NewCallback: call to external function
main.main: relocation target golang.org/x/sys/windows.NewCallback not defined
main.main: undefined: "golang.org/x/sys/windows.NewCallback"

@jeetp96 I don't think golang.org/x/sys/windows.NewCallback ever worked. Did it ever?
Why don't you use syscall.NewCallback instead?
I think we should just delete golang.org/x/sys/windows.NewCallback. What do you think, @ianlancetaylor?
Alex

@alexbrainman This is the first time I'm using golang.org/x/sys/windows.NewCallback, so I don't know if it ever worked earlier. https://golang.org/pkg/syscall/ says to migrate to golang.org/x/sys, and that's what I was trying to do.
Now that you suggest deleting golang.org/x/sys/windows.NewCallback, and because it's suggested to migrate to golang.org/x/sys, I would like to propose something. Would it be possible to call syscall.NewCallback from golang.org/x/sys/windows.NewCallback and return that as a result?
golang.org/x/sys already imports syscall. By doing what I proposed, developers using golang.org/x/sys would not have to import syscall just for the NewCallback function.

I'm sorry for that closing and reopening - in the comment box, I thought "Close and comment" meant close the preview and comment.

Would it be possible to call syscall.NewCallback from golang.org/x/sys/windows.NewCallback and return that as a result?

Yes, that should, probably, work. Would you like to try and fix it yourself? This https://golang.org/doc/contribute.html is how to contribute.
Alex

I would love to try and fix it. I'll read the guidelines and start working on it.

@alexbrainman, I noticed there is a func newCallback(fn interface{}) (cb uintptr, err error) inside golang.org/x/sys/windows/svc/service.go. It also calls syscall.NewCallback but with an added recover() call. I guess that extra bit of code allows the execution not to panic in case the callback function isn't acceptable? not sure.
I could fix the windows.NewCallback to

Call the above function (I know it's an unexported name... I'll make some more changes).
But then that would change the function signature from func NewCallback(fn interface{}) uintptr to func NewCallback(fn interface{}) uintptr, error. And I guess that would not play well with the Go1 rules?

Call syscall.NewCallback directly. This would not change the function signature, and the execution may panic.

I guess that extra bit of code allows the execution not to panic in case the callback function isn't acceptable?

Correct. syscall.NewCallback(f) can panic if f is not acceptable function. It was, probably, a mistake to panic instead of returning error from syscall.NewCallback, but it cannot be changed now.

I could fix the windows.NewCallback to
...

I would go for option 2. For consistency sake.
Alex


 corner case for nd4j dataset with vector

Signed-off-by: eraly<EMAIL_ADDRESS>What changes were proposed in this pull request?
We don't check for ranks when creating a dataset. We allow users to create a dataset from vectors which works fine till you call numExamples. This is a simple fix with reshape in the constructor.
How was this patch tested?
Unit test added
Quick checklist
The following checklist helps ensure your PR is complete:

[X] Eclipse Contributor Agreement signed, and signed commits - see IP Requirements page for details
[X] Reviewed the Contributing Guidelines and followed the steps within.
[X] Created tests for any significant new code additions.
[ ] Relevant tests for your changes are passing.

DO NOT merge yet.
What is the correct interpretation when features/labels are vectors? I would have expect this to be a minibatch size 1 and the size of the vector to be the num of features...Appears that is not the case in the code.

With this code DataSetTest.testSplitTestAndTrain fails and looking at this test it seems like we are creating a dataset with vectors and treating it as a minibatch > 1... Not sure if this is intentional or leftover from when didn't allow rank = 1.

Closing this - we'll add rank 2 minimum checks instead: https://github.com/eclipse/deeplearning4j/issues/8868


golang support

Hi, I would be interested to add support for golang. However, it seems the generator is quite tailored for the C nature with h files and c files. What would be from the architectural point of view the required changes to adapt the core generator classes to be more generic with respect to the configuration for other languages? There are, for example, no header files in go. Thanks for any pointer.

well, browsing through the code it seems the generator is a bit too C flavored to be a good basis for adding golang for it.


⚠ Bofrost.at has degraded performance

In 89319d6, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1872 ms

Resolved: Bofrost.at performance has improved in be82d74.


Missing 2 integration tests for working demos

Fixes https://github.com/quasar-analytics/quasar/issues/3271

@djspiewak Alisa is OOO, can you take over? I think it is easy PR.

I'm back today, so I'm happy to grab this.

thx @alissapajer !


run: use the syscall package instead of execing mount/umount

I feel like there's some unfortunate reason why this is a bad idea but can't think of why....

Update README.md to remove mount reference

Maybe false memory. LGTM after readme fix.


annotation type not applicable to this kind of declaration

Summary
While running ./gradlew generateApolloSources the generated files for one of my mutations seems to a type class incorrectly.  It builds with ./gradlew succesfully, but when Making Project it fails.
Build fails with error: annotation type not applicable to this kind of declaration
Description
I build with four queries.
mutation SignUpBarber($input: NewBarber!) {
    signUpBarber(input: $input) {
        response
        error
    }
}

query GetAllBarbers{
    getAllBarbers{
        barberID
        firstName
        lastName
    }
}

mutation RefreshToken($input: RefreshTokenInput!) {
    refreshToken(input: $input) {
        response
        error
    }
}

mutation LoginBarber($input: Login!) {
    login(input: $input) {
        response
        error
    }
}

The mutation that throws the error is LoginBarber.
RefreshToken mutationis quite similar, but it does not throw the error in question.
The error lies in this code
 public LoginBarberMutation(com.snipsnap.android.barbershop.type. @NotNull Login input) {
    Utils.checkNotNull(input, "input == null");
    variables = new LoginBarberMutation.Variables(input);
  }

While the mutation for RefreshToken looks like this and produces no error
 public RefreshTokenMutation(@NotNull RefreshTokenInput input) {
    Utils.checkNotNull(input, "input == null");
    variables = new RefreshTokenMutation.Variables(input);
  }

public LoginBarberMutation(com.snipsnap.android.barbershop.type. @NotNull Login input)
throws the annotation type not applicable to this kind of declaration error.
Version
Provide a version of library on which the problem occurred.
Android Studio 3.6.3
classpath("com.apollographql.apollo:apollo-gradle-plugin:1.3.3")
implementation("com.apollographql.apollo:apollo-runtime:1.3.3")
Let me know if y'all need additional information. Ty in advanced!

Can you try with version2.0.1 to make sure it's not already fixed in the latest version?
It looks like there might be a name clash between the Login input and potentially another Login class in the same file or package. Are there other Login classes in your project?

I have upgraded to 2.0.1
I have deleted the generated files and initiated a shift+shift search for files matching Login.
The result is attached as an image.

This was before I ran ./gradlew generateApolloSources  to make sure there were no other Login classes. However, the same errors with Login persist.

So I just went ahead and renamed the input to UserLogin, downloaded the new schema, and generated apollo sources, and everything seems to be working as expected.
Thanks for the assistance!
I don't know if I should close since it's not like this bug is fixed. Maybe it's common sense not to name the input and mutation the same? I'll leave that up to y'all!

Thanks for the follow up. That does sound weird indeed. Let's keep this open for the time being.

It turns out a field of the mutation is called login and that will generate an inner class named Login:
mutation LoginBarber($input: Login!) {
    login(input: $input) { // This here will create a `Login` inner class that will clash with the input type
        response
        error
    }
}

I tried to reproduce by tweaking the schema but somehow it generates working code:
https://github.com/martinbonnin/apollo-android/blob/bug-2246-annotation-in-package-name/apollo-compiler/src/test/graphql/com/snipsnap/android/barbershop/LoginBarberMutation.java#L61

Was there an additional mistake on my side then?
I was under the impression that the input type should not be named the same as the field. But, from your code, it looks like that will still generate working code.

Javapoet is smart enough to use qualified names to avoid name clashes so it "should" work. But that space before the annotation looks a bit suspicious...

The same bug happened with me when I added "androidx.navigation:navigation-safe-args-gradle-plugin" classpath to the project gradle file

@LobnaMazhar good catch! Looks like it happens with JavaPoet 1.12.1 (apollo-android depends on JavaPoet 1.9.0). I'll investigate a bit more.

Hello :) Just ran into this while adding the "androidx.navigation:navigation-safe-args-gradle-plugin" classpath to my project. Do you know if there's any way to work around it?
Thanks!

@rcosteira79 switching to Kotlin models (generateKotlinModels.set(true)) will certainly be the easiest workaround.

Reproducer on 2.x https://gist.github.com/martinbonnin/dc40d65595921e692463a200ff9bbe3c
Test case on 3.x: https://github.com/apollographql/apollo-android/pull/3390
Closing as it doesn't happen in 3.x anymore.


fix: tally grpc query

Closes: #XXX
What is the purpose of the change
For the grpc query, we used to just log errors and continue. During the sdk v50 upgrade, we for some reason changed to returning errors. This brings back the old logic.
Pre sdk v50 logic for comparison https://github.com/osmosis-labs/osmosis/blob/8c89343e3b09dcba9a0f45ce0ea872fc4d8fe2a8/x/superfluid/keeper/stake.go#L551-L594

Thank you so much


[labs] When publishing we also need to include some files form the development folder

As per the exports map
see https://github.com/Polymer/lit-html/issues/1728
Description
Exports points to a development scoped-registry-mixin.js but it's missing from published npm package.
"exports": {
    ".": {
      "development": "./development/scoped-registry-mixin.js",
      "default": "./scoped-registry-mixin.js"
    }
  },

@lit-labs/scoped-registry-mixin
1.0.0-pre.1
Compilation error
Could not load<EMAIL_ADDRESS>

@googlebot I fixed it

@justinfagnani signed the google cla agreement twice and already got commits elsewhere I am not sure what’s happening with it, perhaps co authoring is causing it ?

This pr is fine with my cla https://github.com/Polymer/lit-html/pull/1727


fix compile error

Description
[Describe what this change achieves]
Issues Resolved
new method add by this PR
https://github.com/opensearch-project/ml-commons/pull/1818/files#diff-f3f27d4e953486c2798c6edef8641779b3211dabbe5374c5bfe1737b3aab2f25
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

There seems a flaky test in workflow result: https://github.com/opensearch-project/skills/actions/runs/7456381157/job/20286930811?pr=114.
Let's get this PR merged first and fix it in follow up PR


Consider atomics that load when analyzing live stores in ADCE (#1956)

Sorry. Forgot to check this passed CI. I will hammer on this until it passes.

Now passes CI.


[TEMP][ci]Conditionally turn off multi tasking for arm64

Trying to conditionally turn off multi tasking build just for ARM64.
Also apply the fix to the release CI.

https://github.com/microsoft/PowerToys/pull/21957/commits/78f5345c64d40902b61626305f60107f2b8f8dd1 Runs for this commit pass on release CI as well.


{Network} az network cross-region-lb address-pool: Migrate to Codegen V2

Related command

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Network


Add validation of the request body parameters

Response validation should validate the body parameters.

Hi, @pipermerriam do you have any news on this?

I don't but I'd like to get it in soon. Unfortunately, I have a bunch of stuff stacked up right now that is higher priority.  Probably 2 weeks before I can dive back into this for anything other than bug fixes.
if someone were to want to implement this themselves, I would happily give guidance and feedback on it.  Feel free to poke me again in a week or so about this.  I do care about getting this in soon and pestering is a good way to get me to work on this.


Resources -> StackOverflow | What about Custom Policies?

The link in the menu links to the azure-ad-b2c SO tag.  What about the identity-experience-framework tag?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 245ef8a4-a811-19b7-676c-aa9b82e2126f
Version Independent ID: ad2ec743-2aa7-b3c7-3350-2986a78d7c90
Content: What is Azure Active Directory B2C?
Content Source: articles/active-directory-b2c/active-directory-b2c-overview.md
Service: active-directory-b2c
GitHub Login: @davidmu1
Microsoft Alias: davidmu

@spottedmahn Thanks for your feedback! We will investigate and update as appropriate.

@spottedmahn Thanks for the feedback! I have assigned the issue to the author to investigate and update as appropriate.
@davidmu1 The Stack Overflow link in Resources goes to SO site and show all threads related to SO tag - azure-ad-b2c. The request is to include identity-experience-framework tag as well.

Added identity-experience-framework to the link.
#please-close

nice, thanks!


Not able clear the last searched text on SearchBar

I am facing issue in clearing the search text. I have a requirement to clear the previously searched text when user wants to search for the second time. Could you please help me to achieve this functionality?

The same issue for me, it works the first time I try to clear it but the second time it won't work any longer.


Initial release of yet another plugin

Here are the features in initial release.

[x] Generate app/licenses.yml automatically
[x] Escape library name with colon
[x] checkLicenses/generateLicensePage/generateLicenseJson tasks do not throw any exception
[x] Libraries not in dependencies are available
[x] Prefer licenses.yml to pom.xml
[x] Keep libraries order in licenses.yml, also in output
[x] Use not plugin/template files but project/template files if exist
[x] Introduce layout.css, header.html and footer.html
[x] Application information in header
[x] generateLicenseYml task
[x] Support more major OSS licenses
[x] Support mixed licenses
[x] Improve example project
[x] Enable to expand/collapse license section
[x] Define Bintray user and key in metadata

Then here are tasks to release.

[x] README.md
[x] README.ja.md
[ ] Qiita (after merge)

LGTM 🎉


feat: Simple Configmap Validation Checks - Part 6

Reason for Change:
This PR adds two simple checks to the tuning configmap - makes sure based on the method specified (LoRa or QLoRa) the correct params are included. Also checks to make sure all the sections specified in the configmap are recognized.

Codecov Report
Attention: Patch coverage is 43.82022% with 50 lines in your changes are missing coverage. Please review.

Project coverage is 61.83%. Comparing base (fde6369) to head (1fa9e68).
Report is 6 commits behind head on main.

Files
Patch %
Lines

api/v1alpha1/params_validation.go
42.10%
30 Missing and 14 partials :warning:

api/v1alpha1/workspace_validation.go
53.84%
5 Missing and 1 partial :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #355      +/-   ##
==========================================
- Coverage   62.89%   61.83%   -1.06%
==========================================
  Files          14       15       +1
  Lines        1307     1386      +79
==========================================
+ Hits          822      857      +35
- Misses        447      476      +29
- Partials       38       53      +15

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add #37. EveryoneCanContribute Demo as Resource

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
8 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.5%) to 93.17%

Files with Coverage Reduction
New Missed Lines
%

pkg/api/server.go
8
73.33%

Totals

Change from base Build<PHONE_NUMBER>:
-0.5%

Covered Lines:
1487

Relevant Lines:
1596

💛  - Coveralls


CCM-11696-Docs-for-budget-groups

Created a new page for budget groups.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app


feature: report an error if -race is not working

Did you check docs and existing issues?

[X] I have read the documentation.
[X] I have searched the existing issues.

Is your feature request related to a problem? Please describe.
Hey,
creating this feature request in case somebody will face the same in the future.
If cgo is not enabled/available then with default configuration tests will be skipped silently with not much help in the logs to narrow down the issue.
In my particular case I am using NixOS and did not had gcc package installed that's required for cgo to work. More about it: Using cgo on NixOS
To easily reproduce you can:

run CGO_ENABLED=0 nvim
try to run any test

anyways, thanks for your work on the plugin!
Describe the solution you'd like to see.
Race flag should probably not be enabled by default or at least return an error if it fails, currently the only issue that can be seen is exit code 2 in the debug logs.
Describe alternatives you've considered.
If race kept as default might be nice to have information about it in the readme that it might be the reason tests are failing silently.
Additional context
No response

I'll look into this, thank you!
I think just in general that if there's any error when attempting to run a test, there should be a more clear notification/log with the error.
About using -race, do you mean that cgo is required when running go test -race ./...?

Yes to use -race you must have cgo enabled and on non-Darwin systems have C compiler as per go docs
Also this is not strictly related to this issue, but error reporting in general can be improved. For example when trying to run a test that does not compile (syntax issue for example) it defaults to returning a generic tests were skipped message: Test(s) not associated (not found/executed): { "list_of_skipped_tests" } other neotest adapters usually mark those tests as failed and you can see the reason why it failed in the output. In this case it would be nice to see the build error.

Yes, 100% agreed. I've thought about this many times myself while using the plugin (I use it on a daily basis). But just to confirm then, this really isn't limited to -race and instead we can rename the issue into being more generic on simply becoming better at reporting when the test command itself returns a non-zero code?

Sure, I just noticed the -race thing first. I think if you were to output the text from go test to neotest ouptut on non-zero code and mark the test as failed it would solve all of the above.

Ok, this was actually a little tricky... but if you have the time, please give #176 a try by defining the branch in the adapter:
{
  "fredrikaverpil/neotest-golang",
  branch = "output-on-failure",
},


Allow Public Bucket Policy

what

Set restrict_public_buckets to the same value as var.block_origin_public_access_enabled

why

Only restrict public access on the bucket if we're blocking public access. Otherwise Cloudfront will not be able to access the bucket

references

Corrects bug created by #284

/terratest

/terratest


fix n repetitions in display bar

From:
|----glum: initialization (0 / 3 reps)
|----glum:   0.0% (0 / 3 reps)
|----glum:   1.0% (0 / 3 reps)
|----glum:   2.0% (0 / 3 reps)

To:
|----glum: initialization (1 / 3 reps)
|----glum:   0.0% (1 / 3 reps)

thx @mathurinm


[TASK] Transfer governor with signed public key proposal

function transferOwnershipWithSignature(bytes memory publicKey, bytes memory sig) public {
        bytes memory prefix = "\x19Ethereum Signed Message:\n20"; //the length is probably not correct for now
        bytes32 pubKeyHash = keccak256(publicKey);
        address newOwner = address(uint160(uint256(pub_key_hash)));
        require(isSignatureFromGovernor(abi.encodePacked(prefix, abi.encodePacked(newOwner)), sig), "Governable: caller is not the governor");
        _transferOwnership(newOwner);
 }

Question: should I assume that publicKey is the uncompressed 64 byte public key?

Yes


Pavan test 1

Pull Request

@pavanrb If you are experimenting with Github, please don't use our production systems to tinker with pull requests (Spring Boot and the guides).


Allow using localhost for mailer

I would like to be able to use the localhost, or a different non-authenticated mailer to send out notifications, etc. It seems not possible at the moment, unless I am missing something.

Have you used the configuration?

see http://gogs.io/docs/advanced/configuration_cheat_sheet.html#mailer

@matrixise yes. It doesn't allow to use localhost (using a local instance of postfix or sendmail) for that. It requires a server (authentication, etc.).

This config does not work with you?
[mailer]
HOST = <IP_ADDRESS>

@matrixise is it working for you? I bet it is not.

disable the verify of your certificate

@matrixise now you are talking, thanks! Had to do:
SKIP_VERIFY = false
and that worked.

welcome

Quick note to whoever finds this : it seems recent versions of gogs require the port too, on the HOST; I had to use HOST = <IP_ADDRESS>:25 for it to work.


really useful! could you consider adding authentication/authorization features to the router?

Had same task, implemented custom directive:
Alpine.directive(
  "authredirect",
  async (el, { expression, value }, { Alpine, cleanup }) => {
    const authed = value === "authed";

    function redirectionHandler({ detail }) {
      if (authed === detail.hasAuth && expression !== Alpine.$router.path) {
        Alpine.$router.replace(expression);
      }
    }

    redirectionHandler({ detail: { hasAuth: !!Alpine.store("auth").token } });

    window.addEventListener("authchange", redirectionHandler);

    cleanup(() => window.removeEventListener("authchange", redirectionHandler));
  }
);

To set up this you just need to create event authchange on auth changes in auth store
Alpine.store("auth", {
  token: Alpine.$persist(false).as("session_token"),
  async signIn() {
     // Getting token from somewhere...

    this.token = data.access; // Setting token
    this._alertAuthChange();
  },
  async signOut() {
    this.token = false;
    this._alertAuthChange();
  },
  _alertAuthChange() { // Call this one every time you change token in auth
    window.dispatchEvent(
      new CustomEvent("authchange", { detail: { hasAuth: !!this.token } })
    );
  },
});

And use directive like
// Pug template but in html is same
template(x-route="/sign")
  div(x-authredirect:authed="/") // Will redirect to main page if token exists

template(x-route="/")
  div(x-authredirect:unauthed="/sign") // Will redirect to auth page if token removed

It might not be the very best solution, but it works :)

Hi @devhandler
I always like to render different templates for different login states, instead of redirecting states in the URLs.
But of course you can implement it in your own way, like @zdllucky did.


Unable to select Voltage on ZY12PDN post upgrading with zy12pdn-oss Master branch

Hi,
I have bought ZY12PDN which was working perfectly, i wanted to add current limit circuit so that Source charger 9Mac 61W) doesn't trip. But after upgrading with this code, ZY12PDN no longer able to select any voltage than 5V. Led color still changes on pressing the button.
On debugging i found that sourceCaps array was empty. Can you please help me with this?

That's difficult to diagnose without access to the real hardware.
Since the LED colors still change, it's very unlikely that sourceCaps is empty. More likely, it's an artifact of debugging.
How do you debug? The debug pins overlap with the I2C pins. So with the regular ZY12PDN it's not possible to debug it once a charger has been connected. Well, you can. But the I2C communication will no longer work.

Thanks for lookikg into this. I was able to fix the problem by changing the mcu frequency to 32mhz in platform.ini file, it seems the one i bought had hk mcu (it's chinese clone of stm32) and works on 32mhz.
Debugging: I persisted all the parameters that I was interested into eeprom and then read it through STMCubeProgram software. Code is still not working for the power sources which can act as both source and sink. I still have to debug that, but i thought this maybe the limitation of the code.

The code is written for a device that acts as a power sink only. But it should be capable of handling both power sources and dual role devices at the other end of the USB cable. I will look into it...

I think a can reproduce the problem with a laptop. But it'll take me some time to setup my debugging for investigating it in more detail.

I have to correct myself. The tests with the laptop are working correctly, and are not very helpful as the laptop only outputs 5V. So I cannot reproduce it.
What exact device do you have problem with? I assume it's not the Apple 61W power supply anymore as it does not support dual role.
When writing debug information to the EEPROM: Are you sure it does not take too long? If you exceed certain time limits, the power supply will start over with the communication. This is another reason it's so difficult to debug.
For debugging, you can define the build flag -D PD_DEBUG and then use debug_log(). It will write the debug output as serial output to PA2 (you need to solder a wire to it). The baud rate is 115,200 bps. This debugging is quite safe as it uses DMA and is unlikely to interfere with timing.

Looks like I'm having a similar issue.
Tried two different PD chargers from Anker, with stock firmware all four of my boards worked fine.

Then I broke the second board because I accidentally fried it by connecting 3.3V to the GND pin.
I've successfully flashed the other two boards with the (unmodified) firmware, but when I now connect them to a charger they only ever output 5V. The LED changes correctly when I press the button, but the output voltage doesn't.
I don't think my soldering skills are good enough to solder a wire to the PA2 debug pin to get any logs.
I tried adding board_build.f_cpu = 32000000 to the platformio.ini file (no idea if that's the correct parameter, just found that on Google) but that didn't help either.
Any other ideas?

I've tested a variety of chargers and cables and experienced the described effect once. But I couldn't repeat it.
So there is likely an issue with the firmware (e.g. an incorrect timing). But it will be very difficult to find it. What's the exact charger model you're experiencing the issue?
Chaning board_build.f_cpu most likely has no effect at all.

"exact charger model" is a bit of a difficult question with Anker products as they keep making new revisions of products under the same name :P
The first one is a variant of the Anker PowerPort+ Atom III that came with one of my Anker powerbanks and has only a USB-C port instead of a USB-C and a USB-A port.
The other charger I tested is the Anker PowerPort Atom III Slim, the variant with two USB-C and two USB-A ports (which according to Anker also supports PPS).
Both of these chargers support PD, and both of the chargers worked just fine on the ZY12PDN with stock firmware. The cable I'm using is a cheap one from AliExpress which has worked fine with all other chargers/devices.

In a recent shipment from China, I got ZY12PDN boards using a "domestic" XM1008F6P6 microcontroller (instead of a STM32F030F4). Which one do your boards have?

The ones in my most recent shipment have the XM one, too (but I haven't tested these yet). "XM1008F6P6 2116BT". As for the old ones I had / tested when I commented on this issue, no matter what camera I use and how much editing I do, I cannot "decipher" the text on that chip - so it's probably a different fake chip instead of the legit STM32 one. Damnit.
I'd guess it says something like "GKIGK - 32F03FP6 - CHN122RQA". It does have the STM logo, but apparently the whole text is in a much worse quality than on the original one (according to photos on the internet).

The board with the XM1008F6P6 MCU – as delivered – didn't correctly work with the power supply I've used (Anker PowerPort Atom III Slim). I could successfully switch up to 20V. But with the next button press, the LED went off and the voltage stay at 20V. Further button presses didn't have any effect.
This open-source software could be uploaded without any problem. The XM1008F6P6 chip seems to be fully compatible with original STM part.
In further tests (with an board with an STM MCU), I could likely reproduce your problem several times. The problem is obviously that the board incorrectly goes into configuration mode. The configuration mode is apparent as cycling through the colors also includes the purple color, which is not used in the other modes.
@Leseratte10 Can you check if you your board enters configuration mode too?

BTW: I have a copy of the original firmware (from a board of 2nd half of 2020). If anyone is interested, let me know.

@Leseratte10 Can you check if you your board enters configuration mode too?

Looks like it does. I've attached it to a charger, plugged it in, switched to Yellow (9V), held the button down until the LED went off, then unplugged it. Plugged it back in, and it starts red. Then when I push the button, it cycles through yellow, green, light blue, dark blue, purple, then back to red.

I've pushed several changes that increase the robustness and compatibility with different power supplies. They will likely fix your issues:

Better button debouncing so voltage spikes while connecting to power supply cannot trigger configuration mode
USB PD communication is active even in configuration mode (to prevent USB PD supply from resetting power)
Configuration mode now blinks LED constantly to indicate the mode
Improved compatibility with USB PD 3.0 (e.g. for Anker PowerPort Atom III Slim)
Limit maximum voltage to 20V (as some power supplies go higher, e.g. Anker PowerPort Atom III Slim goes to 21V)
Fixed timer button that would delay start of PD communication


Implement API route for up-voting existing posts

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
As a developer, I want to add the routing for upvoting an existing post. See method in wiki
Describe the solution you'd like
A clear and concise description of what you want to happen.

Add a /api/post/{id}/upvote implementation to API routes

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
N/A
Additional context
Add any other context or screenshots about the feature request here.

Closing as it is a subtask of #41


Improve default foregrounds for Tango schemes

Followup on ea61aa3b.
The default foreground in the iTerm2 defaults for the Tango Dark color
scheme is too bright, use the value for ANSI 7 (white) instead.
Signed-off-by: Rafael Kitover<EMAIL_ADDRESS>References
#5305
PR Checklist

[ ] Closes #xxx
[x ] CLA signed. If not, go over here and sign the CLA
[ ] Tests added/passed
[ ] Requires documentation to be updated
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Sorry, I should have really done this in the original PR.

Perhaps not, pure black on pure white always works, but for a lower contrast option we can use ansi 7 (white or gray) or ansi 8 (dark gray). I will test all 3 combinations and give you my impression.

I tested Tango Light with these 3 foreground values and I came to the conclusion that ANSI 8 (dark gray) looks best as the foreground color.
It just looks nicer and more like you'd expect a black on white browser page to look like.
I have updated the commit accordingly.

Thank you. :smile:


Server continues to run after the terminal is closed

Bug?:
Server continues to run after closing the terminal window.
Proposed Solution:
Sever should automatically shut down once the terminal window is closed.

This is most likely being caused by a different signal besides SIGINT being sent when the terminal is closed.


'make init' => Cannot find package 'esbuild' && overmind: No such file or directory

Thanks for making this available!
cloned and ran make init
GoShip$ make init
make reset
docker-compose down
make up
docker-compose up -d --remove-orphans
[+] Running 12/2
 ✔ cache 7 layers [⣿⣿⣿⣿⣿⣿⣿]      0B/0B      Pulled                                                            6.7s
 ✔ mailpit 3 layers [⣿⣿⣿]      0B/0B      Pulled                                                              3.9s
[+] Building 0.0s (0/0)                                                                       docker:desktop-linux
[+] Running 3/3
 ✔ Network goship_default    Created                                                                          0.0s
 ✔ Container goship_cache    Started                                                                          0.1s
 ✔ Container goship_mailpit  Started                                                                          0.1s
sleep 3
make build-js
npm run build

><EMAIL_ADDRESS>build
> node build.mjs

node:internal/modules/esm/resolve:844
  throw new ERR_MODULE_NOT_FOUND(packageName, fileURLToPath(base), null);
        ^

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'esbuild' imported from /Users/bartonhammond/projects/go/GoShip/build.mjs
    at packageResolve (node:internal/modules/esm/resolve:844:9)
    at moduleResolve (node:internal/modules/esm/resolve:901:20)
    at defaultResolve (node:internal/modules/esm/resolve:1121:11)
    at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:396:12)
    at ModuleLoader.resolve (node:internal/modules/esm/loader:365:25)
    at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:240:38)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:85:39)
    at link (node:internal/modules/esm/module_job:84:36) {
  code: 'ERR_MODULE_NOT_FOUND'
}

Node.js v21.1.0
make[1]: *** [build-js] Error 1
make: *** [init] Error 2

so I did npm install and ran make init again with the following:
GoShip$ npm install
npm WARN deprecated<EMAIL_ADDRESS>Rimraf versions prior to v4 are no longer supported
npm WARN deprecated<EMAIL_ADDRESS>Rimraf versions prior to v4 are no longer supported
npm WARN deprecated<EMAIL_ADDRESS>Glob versions prior to v9 are no longer supported
npm WARN deprecated<EMAIL_ADDRESS>Glob versions prior to v9 are no longer supported
npm WARN deprecated<EMAIL_ADDRESS>Glob versions prior to v9 are no longer supported
npm WARN deprecated<EMAIL_ADDRESS>Glob versions prior to v9 are no longer supported
npm WARN deprecated<EMAIL_ADDRESS>This is a stub types definition. expect provides its own type definitions, so you do not need this installed.

added 891 packages, and audited 892 packages in 24s

131 packages are looking for funding
  run `npm fund` for details

15 vulnerabilities (3 low, 6 moderate, 6 high)

To address issues that do not require attention, run:
  npm audit fix

Some issues need review, and may require choosing
a different dependency.

Run `npm audit` for details.
GoShip$ make init
make reset
docker-compose down
[+] Running 3/2
 ✔ Container goship_cache    Removed                                                                          0.1s
 ✔ Container goship_mailpit  Removed                                                                          0.4s
 ✔ Network goship_default    Removed                                                                          0.0s
make up
docker-compose up -d --remove-orphans
[+] Building 0.0s (0/0)                                                                       docker:desktop-linux
[+] Running 3/3
 ✔ Network goship_default    Created                                                                          0.0s
 ✔ Container goship_cache    Started                                                                          0.0s
 ✔ Container goship_mailpit  Started                                                                          0.0s
sleep 3
make build-js
npm run build

><EMAIL_ADDRESS>build
> node build.mjs

Svelte entry points: [ 'javascript/svelte/main.js' ]
▲ [WARNING] NotificationPermissions has unused export property 'addSmsSubscriptionEndpoint'. If it is for external reference only, please consider using `export const addSmsSubscriptionEndpoint` [plugin esbuild-svelte]

    javascript/svelte/components/NotificationPermissions.svelte:20:13:
      20 │   export let addSmsSubscriptionEndpoint = "";
         ╵              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  The plugin "esbuild-svelte" was triggered by this import

    javascript/svelte/main.js:3:36:
      3 │ import NotificationPermissions from "./components/NotificationPermissions.svelte";
        ╵                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

▲ [WARNING] NotificationPermissions has unused export property 'deleteSmsSubscriptionEndpoint'. If it is for external reference only, please consider using `export const deleteSmsSubscriptionEndpoint` [plugin esbuild-svelte]

    javascript/svelte/components/NotificationPermissions.svelte:21:13:
      21 │   export let deleteSmsSubscriptionEndpoint = "";
         ╵              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  The plugin "esbuild-svelte" was triggered by this import

    javascript/svelte/main.js:3:36:
      3 │ import NotificationPermissions from "./components/NotificationPermissions.svelte";
        ╵                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

▲ [WARNING] NotificationPermissions has unused export property 'phoneSubscriptionEnabled'. If it is for external reference only, please consider using `export const phoneSubscriptionEnabled` [plugin esbuild-svelte]

    javascript/svelte/components/NotificationPermissions.svelte:22:13:
      22 │   export let phoneSubscriptionEnabled = false;
         ╵              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  The plugin "esbuild-svelte" was triggered by this import

    javascript/svelte/main.js:3:36:
      3 │ import NotificationPermissions from "./components/NotificationPermissions.svelte";
        ╵                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

▲ [WARNING] Unused CSS selector "dialog::backdrop" [plugin esbuild-svelte]

    javascript/svelte/components/PwaInstallButton.svelte:145:2:
      145 │   dialog::backdrop {
          ╵   ~~~~~~~~~~~~~~~~

  The plugin "esbuild-svelte" was triggered by this import

    javascript/svelte/main.js:6:29:
      6 │ import PwaInstallButton from "./components/PwaInstallButton.svelte";
        ╵                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Build completed successfully
make build-css
npx tailwindcss -i ./styles/styles.css -o ./static/styles_bundle.css
Browserslist: caniuse-lite is outdated. Please run:
  npx update-browserslist-db@latest
  Why you should do it regularly: https://github.com/browserslist/update-db#readme

Rebuilding...

🌼   daisyUI 4.7.2
├─ ⚠  Error  Invalid color  in tailwind.config.js
├─ ✔ 2 themes added             https://daisyui.com/docs/themes
╰─ ★ Star daisyUI on GitHub     https://github.com/saadeghi/daisyui

Done in 616ms.
make seed
go run cmd/seed/main.go
go: downloading entgo.io/ent v0.14.0
go: downloading github.com/rs/zerolog v1.29.1
go: downloading ariga.io/atlas v0.20.1-0.20240321075817-75fd3b1accbf
go: downloading github.com/eko/gocache/v2 v2.3.1
go: downloading golang.org/x/crypto v0.26.0
go: downloading github.com/getsentry/sentry-go v0.26.0
go: downloading github.com/go-redis/redis/v8 v8.11.6-0.20220405070650-99c79f7041fc
go: downloading github.com/go-playground/validator/v10 v10.16.0
go: downloading github.com/hibiken/asynq v0.24.1
go: downloading github.com/jackc/pgx/v4 v4.18.1
go: downloading github.com/labstack/echo-contrib v0.15.0
go: downloading github.com/labstack/echo/v4 v4.11.4
go: downloading github.com/mattn/go-sqlite3 v1.14.23
go: downloading github.com/stripe/stripe-go/v78 v78.6.0
go: downloading github.com/ziflex/lecho/v3 v3.5.0
go: downloading github.com/jackc/pgx v3.6.2+incompatible
go: downloading github.com/minio/minio-go/v7 v7.0.67
go: downloading github.com/AfterShip/email-verifier v1.3.3
go: downloading github.com/deckarep/golang-set/v2 v2.6.0
go: downloading github.com/orsinium-labs/enum v1.3.0
go: downloading firebase.google.com/go/v4 v4.14.1
go: downloading github.com/SherClockHolmes/webpush-go v1.3.0
go: downloading github.com/aws/aws-sdk-go-v2 v1.18.1
go: downloading github.com/aws/aws-sdk-go-v2/config v1.18.27
go: downloading github.com/aws/aws-sdk-go-v2/service/sns v1.20.13
go: downloading github.com/gofrs/uuid v4.2.0+incompatible
go: downloading google.golang.org/api v0.183.0
go: downloading github.com/disintegration/imaging v1.6.2
go: downloading github.com/spf13/viper v1.17.0
go: downloading github.com/XiaoMi/pegasus-go-client v0.0.0-20210427083443-f3b6b08bc4c2
go: downloading github.com/bradfitz/gomemcache v0.0.0-20220106215444-fb4bf637b56d
go: downloading github.com/vmihailenco/msgpack v4.0.4+incompatible
go: downloading golang.org/x/sys v0.23.0
go: downloading github.com/a-h/templ v0.2.771
go: downloading github.com/resend/resend-go/v2 v2.5.0
go: downloading github.com/nats-io/nats.go v1.33.1
go: downloading github.com/gabriel-vasile/mimetype v1.4.2
go: downloading github.com/leodido/go-urn v1.2.4
go: downloading golang.org/x/text v0.17.0
go: downloading golang.org/x/net v0.28.0
go: downloading github.com/gorilla/context v1.1.1
go: downloading github.com/stretchr/objx v0.5.2
go: downloading github.com/cespare/xxhash/v2 v2.2.0
go: downloading github.com/dgryski/go-rendezvous v0.0.0-20200823014737-9f7001d12a5f
go: downloading github.com/jackc/pgconn v1.14.0
go: downloading github.com/jackc/pgtype v1.14.0
go: downloading github.com/json-iterator/go v1.1.12
go: downloading github.com/klauspost/compress v1.17.7
go: downloading github.com/minio/md5-simd v1.1.2
go: downloading github.com/minio/sha256-simd v1.0.1
go: downloading github.com/redis/go-redis/v9 v9.0.3
go: downloading github.com/robfig/cron/v3 v3.0.1
go: downloading github.com/hbollon/go-edlib v1.6.0
go: downloading github.com/prometheus/client_golang v1.17.0
go: downloading github.com/aws/smithy-go v1.13.5
go: downloading cloud.google.com/go/firestore v1.15.0
go: downloading github.com/aws/aws-sdk-go-v2/credentials v1.13.26
go: downloading cloud.google.com/go v0.114.0
go: downloading github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.13.4
go: downloading github.com/aws/aws-sdk-go-v2/internal/ini v1.3.35
go: downloading github.com/aws/aws-sdk-go-v2/service/sso v1.12.12
go: downloading github.com/aws/aws-sdk-go-v2/service/ssooidc v1.14.12
go: downloading github.com/aws/aws-sdk-go-v2/service/sts v1.19.2
go: downloading github.com/hashicorp/hcl/v2 v2.18.1
go: downloading github.com/zclconf/go-cty v1.14.1
go: downloading github.com/aws/aws-sdk-go-v2/internal/configsources v1.1.34
go: downloading golang.org/x/image v0.15.0
go: downloading github.com/cenkalti/backoff/v4 v4.3.0
go: downloading gopkg.in/tomb.v2 v2.0.0-20161208151619-d5d1b5820637
go: downloading k8s.io/apimachinery v0.26.2
go: downloading github.com/jackc/pgproto3/v2 v2.3.2
go: downloading github.com/jackc/pgio v1.0.0
go: downloading github.com/nats-io/nkeys v0.4.7
go: downloading github.com/nats-io/nuid v1.0.1
go: downloading github.com/rs/xid v1.5.0
go: downloading github.com/golang/protobuf v1.5.4
go: downloading google.golang.org/protobuf v1.34.1
go: downloading github.com/jackc/chunkreader/v2 v2.0.1
go: downloading github.com/jackc/pgpassfile v1.0.0
go: downloading github.com/jackc/pgservicefile v0.0.0-20221227161230-091c0ba34f0a
go: downloading github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
go: downloading github.com/modern-go/reflect2 v1.0.2
go: downloading github.com/klauspost/cpuid/v2 v2.2.6
go: downloading github.com/beorn7/perks v1.0.1
go: downloading github.com/prometheus/client_model v0.4.1-0.20230718164431-9a2bf3000d16
go: downloading github.com/prometheus/common v0.44.0
go: downloading github.com/prometheus/procfs v0.11.1
go: downloading github.com/MicahParks/keyfunc v1.9.0
go: downloading github.com/golang-jwt/jwt/v4 v4.5.0
go: downloading golang.org/x/oauth2 v0.21.0
go: downloading cloud.google.com/go/storage v1.41.0
go: downloading github.com/go-openapi/inflect v0.19.0
go: downloading github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.4.28
go: downloading github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.9.28
go: downloading github.com/pelletier/go-toml/v2 v2.1.0
go: downloading google.golang.org/genproto v0.0.0-20240604185151-ef581f913117
go: downloading github.com/googleapis/gax-go/v2 v2.12.4
go: downloading google.golang.org/grpc v1.64.0
go: downloading github.com/pegasus-kv/thrift v0.13.0
go: downloading github.com/sirupsen/logrus v1.9.3
go: downloading gopkg.in/natefinch/lumberjack.v2 v2.0.0
go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.4
go: downloading cloud.google.com/go/longrunning v0.5.7
go: downloading google.golang.org/genproto/googleapis/rpc v0.0.0-20240604185151-ef581f913117
go: downloading google.golang.org/genproto/googleapis/api v0.0.0-20240604185151-ef581f913117
go: downloading cloud.google.com/go/compute/metadata v0.3.0
go: downloading cloud.google.com/go/iam v1.1.8
go: downloading go.opencensus.io v0.24.0
go: downloading go.opentelemetry.io/otel/trace v1.27.0
go: downloading go.opentelemetry.io/otel v1.27.0
go: downloading cloud.google.com/go/auth v0.5.1
go: downloading cloud.google.com/go/auth/oauth2adapt v0.2.2
go: downloading go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.52.0
go: downloading github.com/google/s2a-go v0.1.7
go: downloading github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da
go: downloading go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.52.0
go: downloading github.com/googleapis/enterprise-certificate-proxy v0.3.2
go: downloading go.opentelemetry.io/otel/metric v1.27.0
go: downloading github.com/felixge/httpsnoop v1.0.4
go: downloading github.com/go-logr/logr v1.4.2
go: downloading github.com/go-logr/stdr v1.2.2
make watch
overmind start
make[1]: overmind: No such file or directory
make[1]: *** [watch] Error 1
make: *** [init] Error 2

Did brew install tmux & brew install overmind
Ran make watch:
GoShip$ make watch
overmind start
make: overmind: No such file or directory
make: *** [watch] Error 1
GoShip$ make down
docker-compose down
[+] Running 3/2
 ✔ Container goship_mailpit  Removed                                                                          0.4s
 ✔ Container goship_cache    Removed                                                                          0.2s
 ✔ Network goship_default    Removed                                                                          0.0s
GoShip$ make up
docker-compose up -d --remove-orphans
[+] Building 0.0s (0/0)                                                                       docker:desktop-linux
[+] Running 3/3
 ✔ Network goship_default    Created                                                                          0.0s
 ✔ Container goship_mailpit  Started                                                                          0.0s
 ✔ Container goship_cache    Started                                                                          0.0s
sleep 3
air
watch-go        | make[1]: air: No such file or directory
watch-go        | make[1]: *** [watch-go] Error 1
watch-go        | Exited with code 2
watch-js        | Interrupting...
watch-css       | Interrupting...
watch-go-worker | Interrupting...
watch-js        | make[1]: *** [watch-js] Interrupt: 2
watch-css       | Exited with code 0
watch-go-worker | Exited with code 0
watch-js        | Exited with code 0
make: *** [watch] Error 2

Ran go install github.com/air-verse/air@latest
Started new shell (MacOS)
GoShip$
GoShip$
air
watch-go        | make[1]: air: No such file or directory
watch-go        | make[1]: *** [watch-go] Error 1
watch-go        | Exited with code 2
watch-js        | Interrupting...
watch-css       | Interrupting...
watch-go-worker | Interrupting...
watch-js        | make[1]: *** [watch-js] Interrupt: 2
watch-go-worker | Exited with code 0
watch-js        | Exited with code 0
watch-css       | Exited with code 0
make: *** [watch] Error 2
GoShip$

This is first time ever using golang so I'm lost.

so added the following to .zshrc
alias air='$(go env GOPATH)/bin/air
Then reopen terminal and run make watch:
air
watch-go        | make[1]: air: No such file or directory
watch-go        | make[1]: *** [watch-go] Error 1
watch-go        | Exited with code 2
watch-css       | npx tailwindcss -i ./styles/styles.css -o ./static/styles_bundle.css --watch
watch-js        | Interrupting...
watch-css       | Interrupting...
watch-go-worker | Interrupting...
watch-css       | make[1]: *** [watch-css] Interrupt: 2
watch-js        | make[1]: *** [watch-js] Interrupt: 2
watch-go-worker | Exited with code 0
watch-css       | Exited with code 0
watch-js        | Exited with code 0
make: *** [watch] Error 2

So I try just entering air.
GoShip$ air

  __    _   ___
 / /\  | | | |_)
/_/--\ |_| |_| \_ v1.61.1, built with Go go1.23.2

mkdir /Users/bartonhammond/projects/go/GoShip/tmp
watching .
watching cmd
watching cmd/seed
watching cmd/web
watching cmd/worker
watching config
watching config/firewalls
watching data
watching dbs
watching deploy
watching deploy/kamal
!exclude e2e_tests
watching ent
watching ent/emailsubscription
watching ent/emailsubscriptiontype
watching ent/emojis
watching ent/enttest
watching ent/fcmsubscriptions
watching ent/filestorage
watching ent/hook
watching ent/image
watching ent/imagesize
watching ent/invitation
watching ent/lastseenonline
watching ent/migrate
watching ent/migrate/migrations
watching ent/monthlysubscription
watching ent/notification
watching ent/notificationpermission
watching ent/notificationtime
watching ent/passwordtoken
watching ent/phoneverificationcode
watching ent/predicate
watching ent/profile
watching ent/pwapushsubscription
watching ent/runtime
watching ent/schema
watching ent/sentemail
watching ent/user
!exclude javascript
!exclude node_modules
watching pgvector-image
watching pkg
watching pkg/context
watching pkg/controller
watching pkg/domain
watching pkg/funcmap
watching pkg/htmx
watching pkg/middleware
watching pkg/repos
watching pkg/repos/emailsmanager
watching pkg/repos/mailer
watching pkg/repos/msg
watching pkg/repos/notifierrepo
watching pkg/repos/profilerepo
watching pkg/repos/pubsub
watching pkg/repos/storage
watching pkg/repos/subscriptions
watching pkg/routing
watching pkg/routing/routenames
watching pkg/routing/routes
watching pkg/services
watching pkg/tasks
watching pkg/tests
watching pkg/types
!exclude pwabuilder-ios-wrapper
!exclude scripts
watching seeder
watching static
watching styles
watching templates
watching templates/components
watching templates/emails
watching templates/helpers
watching templates/layouts
watching templates/pages
!exclude testdata
!exclude tmp
building...
/bin/sh: templ: command not found
failed to build, error: exit status 127
running...
/bin/sh: /Users/bartonhammond/projects/go/GoShip/tmp/main: No such file or directory
Process Exit with Code: 127

So installed templ with go install github.com/a-h/templ/cmd/templ@latest and added alias templ='$(go env GOPATH)/bin/templ' to .zshrc and restarted terminal
When I do make watch the final display is this:
air
watch-go        | make[1]: air: No such file or directory
watch-go        | make[1]: *** [watch-go] Error 1
watch-go        | Exited with code 2
watch-js        | Interrupting...
watch-css       | Interrupting...
watch-go-worker | Interrupting...
watch-js        | make[1]: *** [watch-js] Interrupt: 2
watch-css       | Exited with code 0
watch-js        | Exited with code 0
watch-go-worker | Exited with code 0
make: *** [watch] Error 2
GoShip$

Hey @bartonhammond, sorry for the late reply. Seems to me like your go path is not set, hence why templ is not working after installing it with go install github.com/a-h/templ/cmd/templ@latest (there shouldn't be a need to set an alias in your shell env). You might need to add something like the following in your .zshrc:
export GOPATH=$(go env GOPATH)
export GOBIN=$GOPATH/bin
export PATH=$PATH:$GOBIN

Let me know if that helps.


[Linter panic] Fixing TCH003 fails when no TYPE_CHECKING block exists and exempt-modules is empty

I'm not sure that it's the place to ask since this bug appears to be caused by [tool.ruff.lint.flake8-type-checking]. Anyway, with the configuration
[tool.ruff]
target-version = 'py311'
ignore = ['all']
select = ['TCH']

[tool.ruff.lint.flake8-type-checking]
exempt-modules = []

invoking
python3.11 -m ruff file.py --fix --unsafe-fixes

on
from __future__ import annotations

from typing import Final
from collections.abc import Mapping

Const: Final[Mapping] = {}

fails with
panicked at /home/runner/work/ruff/ruff/crates/ruff_text_size/src/range.rs:48:9:
assertion failed: start.raw <= end.raw
Backtrace:    0: <unknown>
   1: <unknown>
   2: <unknown>
   3: <unknown>
   4: <unknown>
   5: <unknown>
   6: <unknown>
   7: <unknown>
   8: <unknown>
   9: <unknown>
  10: <unknown>
  11: <unknown>
  12: <unknown>
  13: <unknown>
  14: <unknown>
  15: <unknown>
  16: __libc_start_main
             at /usr/src/debug/glibc-2.26-lp<IP_ADDRESS>.x86_64/csu/../csu/libc-start.c:308
  17: <unknown>

But the following succeeds:
from __future__ import annotations

from typing import TYPE_CHECKING, Final
from collections.abc import Mapping

if TYPE_CHECKING:
    from collections.abc import Sequence

Const: Final[Mapping[str, Sequence]] = {}

and gets reformatted as
from __future__ import annotations

from typing import TYPE_CHECKING, Final

if TYPE_CHECKING:
    from collections.abc import Mapping
    from collections.abc import Sequence

Const: Final[Mapping[str, Sequence]] = {}

I think it's because the TYPE_CHECKING block does not exist yet that it's like that. However, if the block is empty and only typing imports exist, it also fails:
from __future__ import annotations

from typing import TYPE_CHECKING, Final

if TYPE_CHECKING:
    pass

Const: Final[float] = 1

Now, if I change
[tool.ruff.lint.flake8-type-checking]
exempt-modules = []

to
[tool.ruff.lint.flake8-type-checking]
exempt-modules = ['typing']

it works as intended.
Environment
Platform:              linux; (Linux-5.3.18-lp152.106-default-x86_64-with-glibc2.26)
Python version:        3.11.6 (main, Nov 29 2023, 14:46:32) [GCC 7.5.0])
Python implementation: CPython
ruff version:          0.1.8

I think it is probably related to #5331 (feel free to close it if you think it's a duplicate)


fix: remove trailing whitespace in filename

Hi Team,
That's a rare one, which blocks the repository even being checked out on Windows systems, because Windows does not support trailing whitespace in filenames. So assuming the affected file has not been deliberately named with three trailing spaces to make the app somehow vulnerable, renaming it to remove the trailing whitespace allows the repository to be used by Windows users as well:

Expected - "test-apps/jira-damn-vulnerable-forge-app/.eslintrc"
Actual - "test-apps/jira-damn-vulnerable-forge-app/.eslintrc   "

Cheers,
Steffen
PS: I confirm that Utoolity has signed the CLA for corporate contributors 2018-03-05 (looks like I might need to update it to add the GitHub username of all designated employees though).

Following the CLA prompts seems to indicate that the GitHub usernames of our designated employees might not be on file yet, so given the form states that "if you have previously signed the CLA and would like to update your details, please email us", I've submitted a request to add our GitHub users to our existing CLA (looks like a manual process and might take a bit accordingly).

LGTM


Editing branch PR for new api-led core journey

Please note that only these files are ready for review:

api-led-design.adoc
api-led-develop.adoc
api-led-overview.adoc
api-led-prerequisites.adoc
api-led-test.adoc (One section, marked, isn't ready for review, so if you want to skip this one, feel free)

Comments addressed in https://github.com/mulesoft/docs-general/pull/57


dupe errors calling Java declaration from JS

I have this code in the IDE:
class Ceylon() {
    Java();
}

On the illegal call to Java(), I get this message duplicated 6 times:
Cannot call Java declarations in Javascript

@chochos wait, i may have already fixed it.

Hrm, no, not fixed. @51b2df00d1f4d8f7ebb8d233a449dfa92eed91b2 reduced the errors for 6 to 3. :-/
Do your worst @chochos...

And this Java() call is a Java method? or just an illegal declaration?

A java class.

I'm making good progress with this in the typechecker, so if you don't mind I'll take this off your hands and make the necessary changes in the JS backend as well, is that ok with you @chochos ?

I think this can be closed now.

Agreed. Thanks!

Cool!

Reopening this again because my changes for ceylon/ceylon-spec#1423 has made this reappear. Not sure how it could happen though, setting a breakpoint clearly shows each error is only added once.

@quintesse are you working on this?

Well, it's right at the top of my list, but I'll probably need some help from @davidfestal (I think it has become an IDE issue, or at least it only appears there)

So this was actually the "fault" of the JVM backend: in the IDE JS is compiled first, which adds its errors to the tree and then when the JVM compiler is finished its reports all errors it encounters in the tree that way duplicating the JS ones (why 3x? Dunno, but it's fixed so I don't care why right now ^^)
So now in the error reporting we ignore errors added by the JS backend (luckily I added that info to the error messages some time ago)


Crash on text input

Issue type: Client crash

:bug: Bug

Short description:
Crash when putting text into scripting field.

Steps to reproduce the problem:

Network with script storage, script terminal.
Open and click in typing field. When key (This case "f") is pressed, client crashes

Expected behaviour:

Versions:

This mod: integratedscripting-1.19.2-1.0.0-31
Minecraft: 1.19.2
Forge: 43.3.5

Log file: https://pastebin.com/YVe169Hq

Thanks for reporting!


Update some icons

Specifically:

The icon used on the roku launch screen (and channel store eventually...) needs to actually say Plex. Shawn has a file we should use.
The ATV client uses a nicer looking prefs icon, hopefully we can steal it.

I've updated the main icon. The prefs icon from the ATV client got mixed reviews on the grid screen so I haven't made that change. The icon I like the least is probably the search icon.


BelongsToSelect request loop

Package
filament/forms
Package Version
v2.10.27 (latest)
Laravel Version
latest
Livewire Version
latest
PHP Version
PHP 8.1
Bug description
In our current project we got strange behavior with a BelongsToSelect what turned out to be so many Filament requests on the background.
I set up a clean branch with only the things necessary to reproduce this error.
Visually:

Steps to reproduce

clone branch https://github.com/basepack/filament-forms-request-loop
change the sqlite database path in the supplied .env file: DB_DATABASE=/Users/CHANGME/Sites/filament-forms-request-loop/database.sqlite
link the folder with Valet and open: https://filament-forms-request-loop.test
open Chrome network tab and search for 1
enjoy :)

Relevant log output
No response

Same as #1872 ?

Same as #1872 ?

@danharrin looks like the same underlying issue, this issue is about the BelongsToSelect and #1872 is about BelongsToManyMultiSelect.

Please downgrade to Alpine v2.9.0, and report back if this fixes it. I think https://github.com/alpinejs/alpine/commit/260679bec16f44c891b2c2082d020b53cc834eee is causing this issue.
I've just released a new admin panel version that locks Alpine to this version, and it works.
I will get in contact with the Alpine team.

alpinejs/alpine#2729

Fixed by https://github.com/alpinejs/alpine/commit/d061f2d66011ab9ebeea8b4f21defb2e810ac624.


Create prio mechanism for admin reindexing commands

Update ReindexTask format for admins for the following scenarios:

put a limit of commands to be pushed front by admin in order not to block for too much time other tasks from indexer queue
create a priority mechanism when 2 admins push commands in the queue (add a timestamp field for id for task) or when an admin pushes multiple reindex commands to see which one should be executed first.

@mariacarmina is this done? a pr seems to be merged

This is not implemented and not assigned as well. It is a nice to have feature for reindexing tasks to be performed in a prio mechanism


I'm going to explore pattern-replacement instead.


How to programatically use this without logback.xml?

I'm trying to integrate Papertrail with a Java framework called Dropwizard which uses YML for configuration rather than logback.xml.
I'm trying to programmatically configure papetrail/logback-syslog4j and pass in the config it needs. I've done this and yet Papertrail fails silently without any logs.
Here is a the method I've tried to use:
@Override
    public Appender<ILoggingEvent> build(LoggerContext context, String applicationName,
                                         LayoutFactory<ILoggingEvent> layoutFactory,
                                         LevelFilterFactory<ILoggingEvent> levelFilterFactory,
                                         AsyncAppenderFactory<ILoggingEvent> asyncAppenderFactory) {
        final Syslog4jAppender<ILoggingEvent> syslogAppender = new Syslog4jAppender<>();
        final TCPNetSyslogConfig syslogConfig = new TCPNetSyslogConfig();

        syslogConfig.setIdent(ident);
        syslogConfig.setHost(host);
        syslogConfig.setPort(port);
        syslogConfig.setFacility(facility.toLowerCase(Locale.ENGLISH));
        syslogConfig.setSendLocalName(sendLocalName);

        syslogAppender.setName("papertrail-syslog-tls");
        syslogAppender.setContext(context);

//        layoutFactory.build()

//        syslogAppender.setLayout(new ch.qos.logback.classic.PatternLayout());
        syslogAppender.setLayout(layoutFactory.build(context, TimeZone.getTimeZone("UTC")));
        syslogAppender.addFilter(levelFilterFactory.build(threshold));
        getFilterFactories().forEach(f -> syslogAppender.addFilter(f.build()));
        syslogAppender.setSyslogConfig(syslogConfig);

        syslogAppender.start();

        return wrapAsync(syslogAppender, asyncAppenderFactory);
    }

@darrenhaken it looks like your issue was unintentionally empty. Could you edit it and add/re-add the more detailed explanation?

@troy see the original post

@darrenhaken: While Papertrail wrote and OSS'ed this in the interest of making an open standard (syslog) easier to adopt, it's not otherwise Papertrail-specific or Papertrail-related. We just try our best to be useful :) That said, @eric has the most experience with this, so if he knows the answer, he'll jump in.

I haven't tried using this outside of with a logback.xml. The code looks reasonable, but I don't know a lot about the internals of logback.

@troy and @eric thanks for chipping in, shame we can't resolve it

@darrenhaken 2 ideas come to mind to troubleshoot this:

try a different appender. Do you see any logs? If so, it's specific to this appender or to something it does (like SELinux blocking traffic from the JVM process)
run strace against the JVM while generating a log message, and see where it leads :)


fix: add registry-url in setup-node step

:tada: This PR is included in version 1.0.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Dev

@ashwinar @brtal   - This PR is to merge the OAuth tutorial and related doc fixes into the master branch.
Again, I'm not sure why this PR shows a bunch of commits that have already been merged from dev.  The only new stuff is in the last commit that  D45 wdc oauth update (#310)  …  https://github.com/tableau/webdataconnector/pull/310

Coverage remained the same at 98.913% when pulling 63e681c206fb01b39fd890e24191abacec31fea5 on dev into<PHONE_NUMBER>cb6d846fa8b4b1b0a4aaf1fe7fe70f on master.


NLU Evaluation - error when writing results back to spreadsheet

I've been trying to use nlu-evaluation/nlu_evaluation.ipynb to evaluate if there will be any changes when our bots are changed from standard to advanced NLU type.
When running the "Fill and Run" part it connects to the spreadsheet to read data, run evaluations successfully, but when writing results back to the spreedsheet the error below is thrown. At the same time spreadsheet is wiped for all data, the only thing that remains are the two sheets Agent Dataset and Summary.
Console output:
Using API endpoint `europe-west3-dialogflow.googleapis.com:443`
Worksheet `Summary` does not exist. Creating...
Getting flow mapping...done
Found 1 flows.
Getting page mapping...done
Started evaluation.
Evaluated 2 / 2 utterances.
---------------------------------------------------------------------------
APIError                                  Traceback (most recent call last)
[<ipython-input-5-0c65015985a5>](https://localhost:8080/#) in <cell line: 33>()
     31 creds, _ = default()
     32 print(f"### Running evaluation on agent {agent_label_1} ###\n")
---> 33 run(creds, agent_label_1, project_id_1, region_1, agent_id_1, language_code_1, spreadsheet_url, dataset_tab, summary_tab)
     34
     35 if use_second_agent:

4 frames
[<ipython-input-4-976eabb0be55>](https://localhost:8080/#) in run(creds, agent_label, project_id, region, agent_id, language_code, spreadsheet_url, dataset_tab, summary_tab)
    275   dataset = evaluate_dataset(session_client, flow_client, page_client, dataset, agent_label, project_id, region, agent_id, language_code)
    276
--> 277   write_dataset(spreadsheet_info['dataset_worksheet'], dataset)
    278   write_summary(spreadsheet_info['summary_worksheet'], dataset, agent_label, timestamp, dataset_tab)

[<ipython-input-4-976eabb0be55>](https://localhost:8080/#) in write_dataset(dataset_worksheet, dataset)
    251
    252   dataset_worksheet.clear()
--> 253   dataset_worksheet.update(range_name=([dataset.columns.values.tolist()] + dataset.values.tolist()), values=None)
    254
    255

[/usr/local/lib/python3.10/dist-packages/gspread/worksheet.py](https://localhost:8080/#) in update(self, values, range_name, raw, major_dimension, value_input_option, include_values_in_response, response_value_render_option, response_date_time_render_option)
   1237         }
   1238
-> 1239         response = self.client.values_update(
   1240             self.spreadsheet_id,
   1241             full_range_name,

[/usr/local/lib/python3.10/dist-packages/gspread/http_client.py](https://localhost:8080/#) in values_update(self, id, range, params, body)
    166         """
    167         url = SPREADSHEET_VALUES_URL % (id, quote(range))
--> 168         r = self.request("put", url, params=params, json=body)
    169         return r.json()
    170

[/usr/local/lib/python3.10/dist-packages/gspread/http_client.py](https://localhost:8080/#) in request(self, method, endpoint, params, data, json, files, headers)
    121             return response
    122         else:
--> 123             raise APIError(response)
    124
    125     def batch_update(self, id: str, body: Optional[Mapping[str, Any]]) -> Any:

APIError: {'code': 400, 'message': "Unable to parse range: 'Agent Dataset'![['Flow Display Name', 'Page Display Name', 'Utterance', 'Expected Intent', 'Frequency', 'Detected Intent TestBot1', 'Confidence TestBot1', 'Results TestBot1'], ['Default Start Flow', 'Start Page', 'bil', 'test.intent.1', 1, 'test.intent.1', 1.0, 'PASS'], ['Default Start Flow', 'Start Page', 'mc', 'test.intent.2', 1, 'test.intent.2', 1.0, 'PASS']]", 'status': 'INVALID_ARGUMENT'}

Spreadsheet before run:

@AngryBalloon, thanks for letting us know. I fixed the issue in PR #543 and tested, the notebook should behave as expected now and write the output to the appropriate Agent Dataset and Summary sheets.

Thanks @koverholt, I can confirm that it works from my end as well!
And thanks for sharing that link :)


[CI] CI for the switch target is broken

devkitpro made new release for their pacman and somehow our CI won't work well after that.
CI says:
:: Synchronizing package databases...
error: failed retrieving file 'dkp-libs.db' from downloads.devkitpro.org : The requested URL returned error: 403
error: failed to update dkp-libs (unexpected error)
error: failed retrieving file 'dkp-linux.db' from downloads.devkitpro.org : The requested URL returned error: 403
error: failed to update dkp-linux (unexpected error)
error: failed to synchronize all databases
dpkg: error processing package devkitpro-pacman (--install):
 installed devkitpro-pacman package post-installation script subprocess returned error exit status 1
Errors were encountered while processing:

The command we use on CI works well on my local, perhaps it's signing keys issue on CI?
I disabled the tests for that target as it isn't essential but it'd be great if we could revive it.
CC #1812

You shouldn't be using pacman on CI, we provide docker images for this purpose - https://hub.docker.com/u/devkitpro

@WinterMute Oh, I'll use it instead, thanks!


Update README.md

Codecov Report

Merging #20 (edefbfe) into master (61d3eaa) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #20   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61d3eaa...edefbfe. Read the comment docs.


[QE]Testing Farm document evaluation and experience

Prepare for adding Testing farm resource as github action testing machine.
https://issues.redhat.com/browse/CRC-265

The normal way of using the testing farm is to upload the TMT test plan, and then the plan is executed by the testing farm. We can't get the machine IP/password from the testing farm.
So move to another way of using the testing farm:

add a machine from the testing farm as a self-hosted runner in GitHub
use the self-hosted running to request machines from testing farming. We can get the machine info in this way.
With the machine info, we can continue to install CRC and run tests on the machine from the testing farm.


Weird 'this' scoping issue and even weirder fix

TypeScript Version:  2.4.1
Code
import * as React from 'react';
import * as ReactDOM from 'react-dom';

type QueryLoaderProps = {
  queryLoadingComponent: React.ComponentType;
};

export const safelyRenderQuery = <OwnProps extends { data: T }, T> ( // tslint:disable-line:no-any
    Component: React.ComponentType<OwnProps>,  // tslint:disable-line:variable-name
  ) => {
  return class HOC extends React.PureComponent<OwnProps & QueryLoaderProps> {
    public render(): JSX.Element {
      debugger;
      const { data, queryLoadingComponent, ...ownProps } = this.props;
      if (data != undefined) {
        return <Component data={data} {...ownProps} />;
      } else {
        return <text>Loading...</text>;
      }
    }
  };
};

// tslint:disable-next-line:variable-name
const MyComponent = (props: { data: string }) => <text>{props.data}</text>;
// tslint:disable-next-line:variable-name
const QueryLoadingComponent = () => <text>Loading...</text>;

// tslint:disable-next-line:variable-name
const RenderMe = safelyRenderQuery(MyComponent);

ReactDOM.render(
  <RenderMe data={'string'} queryLoadingComponent={QueryLoadingComponent}/>,
  document.getElementById('root'));

Actual behavior:
this.props is not recognized as an object, so the spread operator for ...ownProps is not valid. The compiler complains about this, which is fine, except that it should know this.props is an object type.
Expected behavior:
this.props should be recognized as an object that we can use the spread operator to pull props from.
The Fix
import * as React from 'react';
import * as ReactDOM from 'react-dom';

type QueryLoaderProps = {
  queryLoadingComponent: React.ComponentType;
};

export const safelyRenderQuery = <OwnProps extends { data: T }, T> ( // tslint:disable-line:no-any
    Component: React.ComponentType<OwnProps>,  // tslint:disable-line:variable-name
  ) => {
  return class HOC extends React.PureComponent<Omit<OwnProps, 'data'> & { data: T | undefined } & QueryLoaderProps> {
    public render(): JSX.Element {
      debugger;
      const { data, queryLoadingComponent, ...ownProps } = this.props;
      if (data != undefined) {
        return <Component data={data} {...ownProps} />;
      } else {
        return <text>Loading...</text>;
      }
    }
  };
};

// tslint:disable-next-line:variable-name
const MyComponent = (props: { data: string }) => <text>{props.data}</text>;
// tslint:disable-next-line:variable-name
const QueryLoadingComponent = () => <text>Loading...</text>;

// tslint:disable-next-line:variable-name
const RenderMe = safelyRenderQuery(MyComponent);

ReactDOM.render(
  <RenderMe data={'string'} queryLoadingComponent={QueryLoadingComponent}/>,
  document.getElementById('root'));

Omitting the data property and adding it back in as possibly undefined fixes the issue. The real concern I have is why this fix works.

Spread currently works only on object types only, not generics, not unions/intersections. https://github.com/Microsoft/TypeScript/issues/10727 tracks adding this support.

So it turns out the Omit<> essentially pulls of properties and applies them to a new blank type. So we can equivalently do
type ForceObject<T> = {[P in keyof T]: T[P]};

Essentially, it precludes the possibility that T is a function-like object with properties attached, which is a possibility with T extends {blah: any}
The ForceObject annotation is the cleaner workaround for now.

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.


Default functions are called in super classes - override mechanism inconcistency in GDSript

I could see a recurring issue that cause confusion amon users and inconsistency in GDScript. I propose to create a roadmap to handle and fix the issue and also backward compatible with old projects.
Calling default functions in super class should happen manually by using ._()
From docs:
"Remember that default functions like _init, and most notifications such as _enter_tree, _exit_tree, _process, _physics_process, etc. are called in all base classes automatically. So there is only a need to call the function explicitly when overloading them in some way."
It was a bad strategic decisions for default functions. It is against override mechanism. It forces hacking.
For example: I had to introduce ignore boolean flags and condition checks to _input(event) methods in super classes.
Godot is getting mature. GDScript should do the same.
Thinking about backward compatibility:
[Proposal]
What about a compiler/editor settings that could change that to industry standard behavior?
The release note could clarify this so old project could work too. Maybe it could be fixed in higher release like 4.0.
Story behind this issue:
From Reduz:
"callbacks get called at all levels, back when we had Squirrel programmers
used to forget calling the parent functions all the time for callbacks they
handled different and it was kind of a mess. "
Reply: beginner users won't use heavy inheritance at the beginning. Advanced users and heavy project would use it. Heavy projects would require programming skills anyway.
Recurring issue with good points in it read them:
https://github.com/godotengine/godot/issues/20349
https://github.com/godotengine/godot/issues/6500
https://github.com/godotengine/godot/issues/23286

I agree. The current system makes it slightly easier to call overrided methods, at the cost of making it more difficult to not call them. Calling an overrided method is always simple and easy; not calling one should also be easy, but isn't.

Not only is this behavior currently inconsistent, but also makes proper use of inheritance much more difficult than it should be. The fact that you can not properly override _ready or _process when extending a class that already defines them is very silly.

I strongly disagree. I think the current behavior is the best possible solution for the problem. It makes it easy for everyone to execute something without worrying about whether or not you are overridding something or not, and thus stays really easy for beginner. Also, this is the most common use case, calling the parent function there all the time would be a pain for everyone.
If you need an overridable behavior, simply define your own my_process() function, call it in the parent class and override it if you want. It is a simple workaround that can be used when you really need an overridable behavior (which is rarely the case)
Having two possibilities is a bad idea too, there is no such crazy thing as a "depends on an option language". That would make creating tutorials a lot harder.

@groud , one problem i have found is that _ready() executes on the parent first, but _process and _physics_process() executes on the child first. It's kind of confusing for a begginer like me.
Is this too an intended behaviour, @reduz ?

Yes, it due to how things are processed in Godot.
If it is not already, it should be documented.
Regarding the initial problem, I think someone (in an issue I cannot find) suggested to mention a dedicated function type the documentation. Something stating that a function is in fact a notification, and thus cannot be overridden.

One comment to the settings dependent behavior:
Java has options to compile sources to different versions like 1.4 or 1.8. Godot could have 3.1 or 4.0. It solves the worries about backward compatibility and removes the burden of old limitations. I understand that it generates complexity and also would create hard time in git.
Such a solution works in the industry.

There is not really much else to discuss about, it just needs to be implemented.

I found this very confusing coming from other more traditional languages. Besides breaking normal OO convention, it makes some things quite difficult to do! All that to say, I'd fully support this even knowing it'd be a breaking change.

Actually I believe it will be better for beginners too, as now it will be clear to them who call what when. I mean come on, gdscript is the only language that does that kind of stuff.

@creeperdeking On the other hand, changing this will break all tutorials. Are you prepared to deal with the flood of support requests? :wink:

I don't think there are many tutorials that deal with inheritance at all, much less so with function overriding. So I'm still in favor of someone implementing this.

will break most tutorials

I don't think most of Godot tutorials use this.

I just hit this issue, because I wanted to be sure that my super method is called. That is how unintuitive this method is. I see the reason, adds some security, but it still looks icky.

Closing in favor of https://github.com/godotengine/godot/issues/29271, as feature proposals are now tracked in the Godot proposals repository.

Yyy, closing in favor of itself? :/

@Zireael07 Fixed :slightly_smiling_face:


Replace opscode from folder names, hardcodes of chef-server.rb, chef-server-running.json, chef-secrets.json

Replacing Chef trademarks where possible.
Related PR`s:

https://github.com/chef/chef/pull/12513 # Chef 18
https://github.com/chef/chef/pull/12519 # Chef 17
https://github.com/chef/chef/pull/12520 # Chef 16
https://github.com/chef/chef/pull/12539
https://github.com/chef/chef/pull/12540
https://github.com/chef/chef/pull/12541
https://github.com/chef/chef_backup/pull/42
https://github.com/chef/omnibus-ctl/pull/83
https://github.com/chef/omnibus-ctl/pull/84

Description
This changes required to make open-sourcing of ChefServer possible (Cinc project).

At a minimum I think we need to see that the output (it can be snipped) of chef-server-ctl test or even chef-server-ctl test --all is successful.  [NOTE: I tried to run an adhoc and planned to run umbrella after, but these apparently don't play nice with forks]

Pipeline Information -
Adhoc - https://buildkite.com/chef/chef-chef-server-main-omnibus-adhoc/builds/3947
Umbrella -

Maybe that failure will be fixed if we update the Chef gem? The const is present:
https://github.com/chef/chef/blob/main/chef-utils/lib/chef-utils/dist.rb#L115

Maybe that failure will be fixed if we update the Chef gem? The const is present:
https://github.com/chef/chef/blob/main/chef-utils/lib/chef-utils/dist.rb#L115

Yes, should we go ahead and bump it in this PR or do it in a different PR? The latest 16 release should include the constant (v16.17.51)

@aleksey-hariton @lbakerchef @marcparadise @jashaik I have created #3205 to replace this PR which should have the final fixes (hopefully). This is created from our shared repo which will make it easier for our group to push any additional fixes to.

Closing in favor to https://github.com/chef/chef-server/pull/3205