No public ingress endpoint created for workload when ingress is created natively

Steps to reproduce:

Create deployment, service and ingress having service as a target, natively, using kubectl.
Go to rancher UI/API to see the workoload.

Bug: public endpoint exposed via ingress, not present on the workload.
@orangedeng we should make sure that for ingress created locally - the one that would not have the rancher ingress status annotation - public endpoints are being created.
Here are the yml files that can be used to reproduce the bug:
apiVersion: v1
kind: Service
metadata:
  name: nginx-service
  labels:
    k8s-app: nginx-service
spec:
  ports:
  - port: 80
    targetPort: 80
    protocol: TCP
    name: http
  selector:
    k8s-app: nginx-service
---
apiVersion: v1
kind: ReplicationController
metadata:
  name: nginx-service
spec:
  replicas: 5
  selector:
    k8s-app: nginx-service
  template:
    metadata:
      labels:
        k8s-app: nginx-service
    spec:
      terminationGracePeriodSeconds: 60
      containers:
      - name: nginx-service
        image: nginx:latest
        ports:
        - containerPort: 80
---
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: test
spec:
  backend:
    serviceName: nginx-service
    servicePort: 80

@alena1108 As long as your ingress example is using default backend, I think the major issue is how we show default backend endpoint in workload. I tested ingress with host/path rules and it turns out alright. Here is the example ingress resource I tested ok.
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: t2
  namespace: default
spec:
  rules:
  - http:
      paths:
      - backend:
          serviceName: nginx-service
          servicePort: 80
        path: /aoo

@orangedeng can we run more tests to ensure that the pubic endpoints get updated on every native ingress use case. If all tests pass, please close the issue

apiVersion: v1
kind: Service
metadata:
  name: nginx-service
  labels:
    k8s-app: nginx-service
spec:
  ports:
  - port: 80
    targetPort: 80
    protocol: TCP
    name: http
  selector:
    k8s-app: nginx-service
---
apiVersion: v1
kind: ReplicationController
metadata:
  name: nginx-service
spec:
  replicas: 5
  selector:
    k8s-app: nginx-service
  template:
    metadata:
      labels:
        k8s-app: nginx-service
    spec:
      terminationGracePeriodSeconds: 60
      containers:
      - name: nginx-service
        image: nginx:latest
        ports:
        - containerPort: 80
---
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: test2
  namespace: default
spec:
  backend:
    serviceName: nginx-service
    servicePort: 80
  rules:
  - host: test.com
    http:
      paths:
      - backend:
          serviceName: nginx-service
          servicePort: 80
        path: /doo
  - host: test2.com
    http:
      paths:
      - backend:
          serviceName: nginx-service
          servicePort: 80
        path: /

@sangeethah this is an example for all kind of ingress backend. Default backend won't be set as a public endpoint. The other rules for host/path will show in workload public endpoint.

@sangeethah
as a verification, lets just make sure that we test ingress created by not using rancher API/LB UI, get public endpoints assigned. The endpoints will get created for hostname/path rules only. Keeping that in mind, we can test:

deploying ingress using kubectl and yml file
deploying ingress via rancher - make it point to the service - export yml -> Deploy new ingress using import yml. Make sure new ingress gets endpoints.

Tested with v2.0.0-rc1
Scenario 1:
When ingress ( and Service/Replication controller) is created using remote kubectl , When ingress gets synced to rancher-server , workload has public endpoints created as expected.
apiVersion: v1
kind: Service
metadata:
 name: k8test2
 labels:
   k8s-app: k8test2-service
spec:
 ports:
 - port: 81
   targetPort: 81
   protocol: TCP
   name: http
 selector:
   k8s-app: k8test2-service
---
apiVersion: v1
kind: ReplicationController
metadata:
 name: k8testrc2
spec:
 replicas: 2
 selector:
   k8s-app: k8test2-service
 template:
   metadata:
     labels:
       k8s-app: k8test2-service
   spec:
     terminationGracePeriodSeconds: 60
     containers:
     - name: testcontainer
       image: sangeetha/testnewhostrouting
       ports:
       - containerPort: 81
---
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
 name: ingress2
 annotations:
   http.port: "83"
spec:
 rules:
 - host: foo.bar.com
   http:
     paths:
     - path: /service3.html
       backend:
         serviceName: k8test2
         servicePort: 81

Scenario 2:
Deploy ingress via rancher UI and  make it point to the service ( by having the workload have a nodeport which results in service entry created for it).
Export this ingress.
Using remote kubectl - use  the exported ingress file to create a new ingress that points to a different service entry that was created by rancher ( service entry relating to a workload deployment with nodeport).
Scenario 3:
Deploy ingress via rancher UI and  make it point to the service ( by having the workload have a nodeport which results in service entry created for it).
Export this ingress.
Using import at namespace scope - use  the exported ingress file to create a new ingress that points to a different service entry that was created by rancher ( service entry relating to a workload deployment with nodeport).
In all the above cases , workload has public endpoints created as expected.


Hijacks default right click behavior (can't view native context menu)

Describe the bug
Right now this component hijacks the right click event, making the native context menu impossible to view. From the readme, it looks like this should require a modifier key as well.
This should require, or support the option to require, a modifier to open the context menu on right click
To Reproduce
Steps to reproduce the behavior:

Right click
The click to component menu opens instead of the native context menu

Expected behavior
There should be a way to view the native context menu as well (either with a modifier to show the click-to-react-component menu, or a modifier to show the native context menu.
Desktop (please complete the following information):

OS: macOS 12.3.1
Browser Chome
Version 100.0.4896.127

Ah we were on 1.0.6, but this is resolved in 1.0.8. Apologies for the noise! ❤


fix(api): ensure passed in pipette and labware names are lowercased

Overview

Changelog

Review requests

Risk assessment

Current dependencies on/for this PR:

edge

PR #11661   👈

This comment was auto-generated by Graphite.


ember-exam auto discovery

Right now you have to manually set PERCY_PARALLEL_TOTAL if you use ember-exam to split tests—we could probably grab a split number from exam and combine it with things like CIRCLE_NODE_TOTAL to make using Percy's support for parallel suites a bit easier.

This has been partially addressed in #39 — it will at least work now, though still requires manually setting PERCY_PARALLEL_TOTAL


Create new github project for docs

Split github projects to be either for development or for documentation.

New GitHub project "Documentation" is added.


Address issues #217 #219 #220 #221

The find highest peaks tool has a number of flaws in its logic. The current workflow is to:

invert the elevation model
run the Flow Direction to enable sink areas to be determined
create points from the sink areas to determine the original elevation values
then select all the elevation values with the top (x) values (x being the number of peaks the user wants)

The issues this workflow has is that if you have adjacent raster cells forming one sink area each of the individual pixels is going to be turned into a individual peak (hence this issue and #219).
The next problem is then if you select all the peaks that match the top x values the result could be higher than x (if you have multiple peaks of the same value). Instead you only want to select the top x values (second part of issue #217).
So I think the solution is to turn the sink areas to a polygon feature class then create a point feature class from this, as this will ensure that you only get a single central point if the single area is over a number of pixels.
Once you are at the stage of selecting the number of required points, do not select points that have values equal to the highest points but only select the top amount required

@adgiles Can you resolve conflicts before merge?


Does not work

This action doesn't seem to work properly in my use case...
It runs without error but for this configuration it does not set needs-updating to true when the base image was updated, any idea why would that be?

@jacklul you can't access the output directly if the action it's in a different job, you would need to set the output of the job, something like:
jobs:
  check:
    runs-on: ubuntu-latest
	outputs:
      image-needs-updating: ${{ steps.check.outputs.needs-updating }}
    steps:
      - name: Docker Image Update Checker
        id: check
        uses: lucacome/docker-image-update-checker@v1
        with:
          base-image: pihole/pihole:latest
          image: jacklul/pihole:latest
        if: ${{ github.event_name == 'schedule' }}

  build:
    needs: check
    if: ${{ github.event_name != 'schedule' || needs.check.outputs.image-needs-updating == 'true' }}
    runs-on: ubuntu-latest
    steps:
      - name: Checkout
        uses: actions/checkout@v2

Actually this makes sense, thank you very much!


Tutanova

tutanoTA, not nova. but files are at least the right name..

ok gonna close this and open the last one with both updates in...


Replace all compilation uses of iree-translate with ireec.

ireec is used for e2e compilation. iree-translate is used to test specific translations (i.e. hal executable, vm IR, etc).

ireec allows deprecated arguments previously used in iree-translate so it should be a drop-in replacement for users.
It supports a new --output-format= argument that defaults to vm-bytecode
It fails if no files are specified (read from stdin with '-').

iree-translate still works like it always did with this change. A subsequent change will scale it back to just the translations needed for testing (not e2e compilation), which should make it a good deal smaller and cheaper to build.
This is mostly a find/replace with specific fixups for VM and HAL tests that were testing translations.

(mentioned on discuss but this was probably the right place instead) can we call this iree-compile instead? having a different naming scheme from the existing tools is unergonomic (it'd break iree tab completion as now it'll be ireec and iree-*)

Grumble, grumble - this has actually been ireec in the released binaries for a long time. All I am doing is bringing the internal dev tools up to speed.

we can't close https://github.com/google/iree/issues/3817 unless it's called iree-compile 😆
good point about tab completion, but I'm also fine with the main user-facing tool having a different naming scheme from the compiler test tools

I'm not :)

(mentioned on discuss but this was probably the right place instead) can we call this iree-compile instead? having a different naming scheme from the existing tools is unergonomic (it'd break iree tab completion as now it'll be ireec and iree-*)

Grumble, grumble - this has actually been ireec in the released binaries for a long time. All I am doing is bringing the internal dev tools up to speed.

we can't close #3817 unless it's called iree-compile 😆 good point about tab completion, but I'm also fine with the main user-facing tool having a different naming scheme from the compiler test tools

They should be the same and I'll change it, but I want consensus. I do not believe the longer name is more ergonomic for users, personally.

This is the same debate used by people to justify things like fsck and having all their variable names be <=3 letters long - "whatever, users will learn our arbitrary naming, they'll thank us when they are trying to google for something that the name is ambiguous and they need to randomly refine things, or that when they are trying to manage their PATH we add a bunch of random stuff" - consistency is key. There's no reason in a new project to be self-inconsistent.

(I don't feel super strongly about this particular tool, but this is one of dozens we have and more we will grow to have - if the thinking of people really is "yolo we don't care about consistency" that bothers me)

(I don't feel super strongly about this particular tool, but this is one of dozens we have and more we will grow to have - if the thinking of people really is "yolo we don't care about consistency" that bothers me)

I don't feel that strongly about it. More of a "this has been a thing for a while (and actually had been reviewed multiple times now) and if we're changing it, doing so with intention (and I'm going on vacation shortly and would like to land it in the next couple of days)."
The path of least resistance that I will probably take is to accede to your viewpoint, but I just want to make sure. I do not want to rename this again :)

"yolo we don't care about consistency"

When I named it this way a year ago, I was more aligning it with the consistency I would expect with such tools as an end user. It wasn't yolo'd or under-considered, but the reasons are fuzzy and based on preference.

PTAL

Comments addressed. CI is having cross compilation issues I'm having trouble seeing what is going on. Still need to look at that.

PTAL - I think this is ready to land.

Ok, this is ready to land for real now. Added a CAPI test that was necessary to notice that had a similar LLVMIR translation issue.


Adds additional detail about uninstall

What's changed, or what was fixed?

Adds detail about uninstall on Mac & Windows

Fixes: googlecodelabs/your-first-pwapp#164
Target Live Date: ASAP

[ ] This has been reviewed and approved by (NAME)
[X] I have run npm test locally and all tests pass.
[X] I have added the appropriate type-something label.
[X] I've staged the site and manually verified that my content displays correctly.

:+1:

:tada: This has been pushed live to https://developers.google.com/web/


[go_router] GoRouter remove query parameter when app loaded/refreshed

Is there an existing issue for this?

[X] I have searched the existing package issues
[X] I have read the guide to filing a bug

What package does this bug report belong to?
go_router
What target platforms are you seeing this bug on?

Yes
Dependency versions
pubspec.lock
  go_router:
    dependency: "direct main"
    description:
      name: go_router
      sha256: e156bc1b2088eb5ece9351bccd48c3e1719a4858eacbd44e59162e98a68205d1
      url: "https://pub.dev"
    source: hosted
    version: "12.0.1"

Steps to reproduce

Create app using go_router
Build to web
on chrome input url in tab browser `localhost:port/home?q=test'

Expected results
when page loaded query parameter not get removed
`/home?q=test'
Actual results
notice that when app loaded, query parameter get removed
localhost:port/home
Code sample
Code sample
void main() async {
  MainModule.init();
  WidgetsFlutterBinding.ensureInitialized();
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return MaterialApp.router(
      routerConfig: AppRoute.router,
      title: "Flutter Playground",
  }
}

class AppRoute {
  AppRoute._();

  static final GoRouter router = GoRouter(
    debugLogDiagnostics: true,
    initialLocation: "/home",
    routes: [
      GoRoute(
        path: "/home",
        builder: (context, state) {
          final query = state.uri.queryParameters["q"] ?? "";
          return Scaffold(
            appBar: AppBar(
              title: const Text("Home Screen"),
            ),
            body: Center(
              child: Text(
                  "Query Data : ${query.isEmpty ? "Empty" : query}",
               ),
            ),
          );
        },
      ),
    ],
  );
}

Screenshots or Videos

Screenshots / Video demonstration
https://github.com/flutter/flutter/assets/52802172/ab7e66bd-022c-405a-82da-5fb0f87efc34

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.10.6, on macOS 13.0.1 22A400 darwin-arm64, locale en-ID)
    • Flutter version 3.10.6 on channel stable at /Users/dandisupriyadi/Documents/Repsitory/Flutter/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision f468f3366c (4 months ago), 2023-07-12 15:19:05 -0700
    • Engine revision cdbeda788a
    • Dart version 3.0.6
    • DevTools version 2.23.1

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
    • Android SDK at /Users/dandisupriyadi/Library/Android/sdk
    • Platform android-34, build-tools 33.0.1
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14C18
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)

[✓] IntelliJ IDEA Community Edition (version 2022.3.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.80.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.74.0

[✓] Connected device (3 available)
    • iPhone 14 (mobile) • E729289D-2328-479D-8001-E7E098242ECE • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-2 (simulator)
    • macOS (desktop)    • macos                                • darwin-arm64   • macOS 13.0.1 22A400 darwin-arm64
    • Chrome (web)       • chrome                               • web-javascript • Google Chrome 118.0.5993.117

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Thanks for filing the issue. I can reproduce this issue on the latest version go_router: ^12.0.1. The issue doesn't occur on version 12.0.0. This seems to be caused by 12.0.1 change:
Fixes deep-link with no path on cold start.

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.13.9, on macOS 14.0 23A344 darwin-x64, locale en-VN)
    • Flutter version 3.13.9 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision d211f42860 (7 hours ago), 2023-10-25 13:42:25 -0700
    • Engine revision 0545f8705d
    • Dart version 3.1.5
    • DevTools version 2.25.0

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio Giraffe.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A240d
    • CocoaPods version 1.13.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.3)
    • Android Studio at /Applications/Android Studio Giraffe.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.83.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.74.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 14.0 23A344 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 118.0.5993.117

[✓] Network resources
    • All expected network resources are available.

• No issues found!

[!] Flutter (Channel master, 3.16.0-18.0.pre.91, on macOS 14.0 23A344 darwin-x64, locale en-VN)
    • Flutter version 3.16.0-18.0.pre.91 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision e12d1a798c (6 hours ago), 2023-10-29 15:00:30 -0700
    • Engine revision 84dcb4fb93
    • Dart version 3.3.0 (build 3.3.0-71.0.dev)
    • DevTools version 2.28.1
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio Giraffe.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A240d
    • CocoaPods version 1.13.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.3)
    • Android Studio at /Applications/Android Studio Giraffe.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.83.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.74.0

[✓] Connected device (3 available)
    • iPhone (mobile) • d9a94afe2b649fef56ba0bfeb052f0f2a7dae95e • ios            • iOS 15.7.9 19H365
    • macOS (desktop) • macos                                    • darwin-x64     • macOS 14.0 23A344 darwin-x64
    • Chrome (web)    • chrome                                   • web-javascript • Google Chrome 118.0.5993.117

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

I can confirm this behavior. It only happens at 12.0.1 but nor on 12.0.0

@chunhtai, I can confirm this behavior as well. It breaks the Firebase Auth email link login functionality completely. 12.0.0 was fine.

On Android
I get a / route match the first time and then if I go back to my emails and press the link again, it works and there are query params.

App is open and triggers an email link to be sent
Switch to the email app without killing it
Press the login link
Switches to the app and state.matchedLocation is / with no query params, state.uri is also the same.
Switch to the email app again
Press the login link
Switches to the app and now everything works, there is a path and query params.

This is with Android App Links.

I confirm that the problem still occurs on version 12.1.0.

Can confirm! Working as expected on 12.0.0 but broken on all later versions.


AnimatedCrossFade not animating shrink

Steps to Reproduce
Change container width
Supposed problematic code
https://github.com/flutter/flutter/blob/b8a2456737c9645e5f3d7210fba6267f7408486f/packages/flutter/lib/src/widgets/animated_cross_fade.dart#L221-L231

Code sample
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  static const String _title = 'Flutter Code Sample';

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: _title,
      home: Home(),
    );
  }
}

class Home extends StatefulWidget {
  Home({Key key}) : super(key: key);

  @override
  _HomeState createState() => _HomeState();
}

class _HomeState extends State<Home> {
  bool first = false;

  void _setState() {
    setState(() {
      first = !first;
    });
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: Column(
          mainAxisSize: MainAxisSize.min,
          children: [
            AnimatedCrossFade(
              crossFadeState: first
                ? CrossFadeState.showFirst
                : CrossFadeState.showSecond,
              duration: const Duration(milliseconds: 300),
              firstChild: Container(
                color: Colors.blue,
                width: 100.0,
                height: 50.0,
              ),
              secondChild: Container(
                color: Colors.red,
                width: 50.0,
                height: 50.0,
              ),
            ),
            MaterialButton(
              child: Text('press'),
              onPressed: _setState,
            )
          ],
        ),
      ),
    );
  }
}

Expected results: AnimatedCrossFade always change its size
Actual results: AnimatedCrossFade animates grow but never animates shrink

Logs
n/a

Analyzing issues...
No issues found! (ran in 2.8s)

[√] Flutter (Channel master, 2.3.0-2.0.pre.219, on Microsoft Windows [Version 10.0.19041.985], locale ru-RU)
    • Flutter version 2.3.0-2.0.pre.219 at C:\dev\src\flutter
    • Upstream repository git@github.com:nt4f04und/flutter.git
    • Framework revision aa9b2d914c (17 hours ago), 2021-05-14 14:54:03 -0700
    • Engine revision 5c33fa9113
    • Dart version 2.14.0 (build 2.14.0-117.0.dev)

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at C:\Users\danya\AppData\Local\Android\sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.7.7)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.7.30621.155
    • Windows 10 SDK version 10.0.19041.0

[√] Android Studio (version 4.1.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] IntelliJ IDEA Community Edition (version 2020.3)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2020.3.3
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart

[√] VS Code (version 1.56.2)
    • VS Code at C:\Users\danya\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.22.0

[√] Connected device (4 available)
    • sdk gphone x86 (mobile) • emulator-5554 • android-x86    • Android 11 (API 30) (emulator)
    • Windows (desktop)       • windows       • windows-x64    • Microsoft Windows [Version 10.0.19041.985]
    • Chrome (web)            • chrome        • web-javascript • Google Chrome 90.0.4430.212
    • Edge (web)              • edge          • web-javascript • Microsoft Edge 90.0.818.46

• No issues found!

Noticed it happens only for width

Hi @nt4f04uNd
Thanks for filing the issue!
Reproduced on the following channels

stable
master

✅
✅

Check flutter doctor -v outputs for each channel below

flutter doctor -v
[✓] Flutter (Channel stable, 2.0.6, on Microsoft Windows [Version 10.0.19042.964], locale en-US)
    • Flutter version 2.0.6 at C:\Users\Taha\Code\flutter_stable
    • Framework revision 1d9032c7e1 (2 weeks ago), 2021-04-29 17:37:58 -0700
    • Engine revision 05e680e202
    • Dart version 2.12.3

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at C:\Users\Taha\Code\SDK
    • Platform android-30, build-tools 30.0.3
    • Java binary at: C:\Users\Taha\Code\android-studio\jre\bin\java.exe
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[✓] Visual Studio - develop for Windows (Visual Studio Community 2019 16.9.5)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.9.31229.75
    • Windows 10 SDK version 10.0.19041.0

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions).

[✓] VS Code (version 1.56.2)
    • VS Code at C:\Users\Taha\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.22.0

[✓] Connected device (4 available)
    • SM M025F (mobile) • R9ZR205XX0A • android-arm    • Android 11 (API 30)
    • Windows (desktop) • windows     • windows-x64    • Microsoft Windows [Version 10.0.19042.964]
    • Chrome (web)      • chrome      • web-javascript • Google Chrome 90.0.4430.212
    • Edge (web)        • edge        • web-javascript • Microsoft Edge 89.0.774.63

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 2.3.0-2.0.pre.240, on Microsoft Windows [Version 10.0.19042.964], locale en-US)
    • Flutter version 2.3.0-2.0.pre.240 at C:\Users\Taha\Code\flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision e364e30c90 (2 hours ago), 2021-05-16 19:40:00 -0700
    • Engine revision 193be59942
    • Dart version 2.14.0 (build 2.14.0-edge.a527411e5100a0a4f48c4009087a1b988aa784af)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at C:\Users\Taha\Code\SDK
    • Platform android-30, build-tools 30.0.3
    • Java binary at: C:\Users\Taha\Code\android-studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[✓] Visual Studio - develop for Windows (Visual Studio Community 2019 16.9.5)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.9.31229.75
    • Windows 10 SDK version 10.0.19041.0

[✓] Android Studio (version 4.2.0)
    • Android Studio at C:\Users\Taha\Code\android-studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)

[✓] VS Code (version 1.56.2)
    • VS Code at C:\Users\Taha\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.22.0

[✓] Connected device (4 available)
    • SM M025F (mobile) • R9ZR205XX0A • android-arm    • Android 11 (API 30)
    • Windows (desktop) • windows     • windows-x64    • Microsoft Windows [Version 10.0.19042.964]
    • Chrome (web)      • chrome      • web-javascript • Google Chrome 90.0.4430.212
    • Edge (web)        • edge        • web-javascript • Microsoft Edge 89.0.774.63

• No issues found!

A fix would look like:
    return Stack(
      clipBehavior: Clip.none,
      alignment: Alignment.center,
      children: <Widget>[
        Positioned(
          key: bottomChildKey,
          child: bottomChild,
        ),
        Positioned(
          key: topChildKey,
          child: topChild,
        ),
      ],
    );

https://user-images.githubusercontent.com/33294549/120894158-ecd29e80-c60e-11eb-88f5-f18ca1cf13f8.mp4
This would just require a test case for a PR.

Why is that a fix though, isn't AnimatedCrossFade supposed to animate the size?

Why is that a fix though, isn't AnimatedCrossFade supposed to animate the size?

Sorry for the misunderstood. I meant the code I posted above is the fix that the framework needs :)
(Posted the code here for later use, or if someone wants to fix this). I will try to open PR if I get a chance to.

For whoever fixes that: the problem relies in the AnimatedSize, which constrains the bigger child, but doesn't do expansion of the smaller one. Therefore the bigger child ends up being smaller that its actual size so we can see the animation, but the smaller child just has its base size all the time

I am able to reproduce this issue on the latest stable and master channels. Hence, the issue still persists.
Code Sample
  flutter doctor -v
[✓] Flutter (Channel master, 3.11.0-2.0.pre.55, on macOS 13.3 22E252 darwin-arm64, locale en-NG)
    • Flutter version 3.11.0-2.0.pre.55 on channel master at /Users/dammya/fvm/versions/master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 835b892d7f (4 days ago), 2023-05-07 01:30:22 +0530
    • Engine revision 23f730efbf
    • Dart version 3.1.0 (build 3.1.0-83.0.dev)
    • DevTools version 2.23.1

[✓] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
    • Android SDK at /Users/dammya/Library/Android/sdk
    • Platform android-33, build-tools 32.1.0-rc1
    • ANDROID_HOME = /Users/dammya/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2022.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.78.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.50.0

[✓] VS Code (version 1.78.0)
    • VS Code at /Users/dammya/.Trash/Visual Studio Code 20.07.05.app/Contents
    • Flutter extension version 3.50.0

[✓] Connected device (4 available)
    • sdk gphone arm64 (mobile)  • emulator-5554                        • android-arm64  • Android 11 (API 30) (emulator)
    • iPhone 14 Pro Max (mobile) • D7F3302D-D66F-4B89-B8CF-DBEE1CDB5449 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-4 (simulator)
    • macOS (desktop)            • macos                                • darwin-arm64   • macOS 13.3 22E252 darwin-arm64
    • Chrome (web)               • chrome                               • web-javascript • Google Chrome 112.0.5615.137

[✓] Network resources
    • All expected network resources are available.

• No issues found!

[✓] Flutter (Channel stable, 3.10.0, on macOS 13.3 22E252 darwin-arm64, locale en-NG)
    • Flutter version 3.10.0 on channel stable at /Users/dammya/fvm/versions/stable
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 84a1e904f4 (2 days ago), 2023-05-09 07:41:44 -0700
    • Engine revision d44b5a94c9
    • Dart version 3.0.0
    • DevTools version 2.23.1

[✓] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
    • Android SDK at /Users/dammya/Library/Android/sdk
    • Platform android-33, build-tools 32.1.0-rc1
    • ANDROID_HOME = /Users/dammya/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2022.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.78.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.50.0

[✓] VS Code (version 1.78.0)
    • VS Code at /Users/dammya/.Trash/Visual Studio Code 20.07.05.app/Contents
    • Flutter extension version 3.50.0

[✓] Connected device (4 available)
    • sdk gphone arm64 (mobile)  • emulator-5554                        • android-arm64  • Android 11 (API 30) (emulator)
    • iPhone 14 Pro Max (mobile) • D7F3302D-D66F-4B89-B8CF-DBEE1CDB5449 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-4 (simulator)
    • macOS (desktop)            • macos                                • darwin-arm64   • macOS 13.3 22E252 darwin-arm64
    • Chrome (web)               • chrome                               • web-javascript • Google Chrome 113.0.5672.92

[✓] Network resources
    • All expected network resources are available.

• No issues found!

May be related: https://github.com/flutter/flutter/issues/77469


test: Add timeline test report

Timeline report aggregates all the typical information you will need into one report. Run tests and have a nice timeline of events you can look back at to further verify everything looks ok.

Codecov Report

Merging #848 into master will decrease coverage by 0.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #848      +/-   ##
==========================================
- Coverage   78.89%   78.64%   -0.25%
==========================================
  Files          67       67
  Lines        3316     3316
  Branches      703      703
==========================================
- Hits         2616     2608       -8
- Misses        700      708       +8

Impacted Files
Coverage Δ

components/Form/Password.js
88.09% <0%> (-2.39%)
:arrow_down:

core/sagas/inputs.js
70.4% <0%> (-2.05%)
:arrow_down:

components/Notifications/Notification.js
68.25% <0%> (-1.59%)
:arrow_down:

components/Modal/CreateBlueprint.js
93.61% <0%> (-1.07%)
:arrow_down:

core/sagas/blueprints.js
73.46% <0%> (-1.03%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 641663f...c6b2d24. Read the comment docs.


Remove jmt dependency from SDK package

Currently, the Sovereign SDK re-exports the jmt package and exposes one trait which depends on it (TreeWitnessReader). Since the SDK is supposed to be agnostic about what state commitment is used by implementers, we should remove that dependency. We should be able to move all of the relevant functionality into the sov-state package.

@citizen-stig suggests that we should replace SimpleHasher with https://docs.rs/digest/latest/digest/trait.Digest.html. I think that's a good idea, since Digest is more standard

@preston-evans98 actually it is your idea and I am totally onboard with that.


Day 13- Adding Info about Constructors and Destructos

Select the Day of Content
Day 13
What information is missing?
Information about the Constructors and Destructors should be added.
I have read the existing issues and the contributing guidelines.

@subhadipbhowmik Please assign me this issue. I have contributed day-12 OOPS content, so you can be assured that I will provide good content for this project.


Pause emulation on tab blur

Browsers heavily throttle non-active flags. This is especially bad with the gametank emulator's web build as this often leads to deeply cursed audio as the audio processor is not given enough time to run.
This pr adds some simple, idempotent functions to gte.cpp to pause and resume emulation.  These functions are exported for use through emscripten. The browser uses a visibilitychange event on the page to call PauseEmulation or ResumeEmulation respectively.
Lmk what your thoughts on this pr are. I didn't see any other functions specifically for controlling the emulator's paused state, so I'm not sure I'm pausing everything I need to.
Note on <iframe>s: According to mdn, iframes inherit the visibility status of their containing page. This means that if you tab away from an itch page with an emulator running the embedded emulator iframe also receives the visibilitychange event. I haven't updated the embedded shell in this pr to also feature pausing functionality, but I could if you want.

Update: pause/ resume functionality has been added to the embedded shell

Looks good! I think adding it to the embed shell as well would be reasonable

Looks good! I think adding it to the embed shell as well would be reasonable

It's been added!


[Feature]: Support new ASL choice comparators

Adding new choice state comparators that were added to the Amazon States Language specifications. https://states-language.net/
These include:

StringMatches
IsNull, IsPresent, IsString, IsNumeric, IsBoolean, IsTimestamp
StringEqualsPath, StringLessThanPath, StringGreaterThanPath, StringLessThanEqualsPath, StringGreaterThanEqualsPath, NumericEqualsPath, NumericLessThanPath, NumericGreaterThanPath, NumericLessThanEqualsPath, NumericGreaterThanEqualsPath, BooleanEqualsPath, TimestampEqualsPath, TimestampLessThanPath, TimestampGreaterThanPath, TimestampLessThanEqualsPath, TimestampGreaterThanEqualsPath

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: StepFunctionsPythonSDK-integtests
Commit ID: 16177d781f204914cf58cf8f5106fb3fbb9d6660
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: StepFunctionsPythonSDK-integtests
Commit ID: 9518733af1918567d8744a83a53e4d43c1435f68
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: StepFunctionsPythonSDK-integtests
Commit ID: 1f7d4e30006a9378faa0b4949875a99196249d0a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: StepFunctionsPythonSDK-integtests
Commit ID: 61fff47231b8378063f3becf015d275c8c95798b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: StepFunctionsPythonSDK-integtests
Commit ID: 6fd4480e7be376bca3689ecc506f6f31148a0784
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: StepFunctionsPythonSDK-integtests
Commit ID: b5d55f24ee8341a029318e666c046a5f6f68b400
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Send a message on telegram: "Forbidden: bot is not a member of the supergroup chat"

I am trying to send a message on a chat on telegram.
I want telegram setups to be done only with the official UI as I want it to be possibly done by by an end user.
Here are telegram setup I do:

I created the bot XXXXXXX_bot with Botfather by getting the token: no problem
I created a Channel:

click "new channel"
channel name: TestChannel
click "Next"
select "Private channel"
click "Save"
Add my bot XXXXXXX_bot
Click "Make admin"
Click "Save"

I create the chat:

open the channel TestChannel
on the channel menu, select "Manage Channel"
click on "Add a group" in the discussion
click on "Create a new group"
group name: TestChannelChat
click "Create"
click "Save"

I add the bot to the new group:

open the group TestChannelChat
on the right panel, I click "add member"
Add my bot XXXXXXX_bot
click "Add"
right click on the newly added user in the chat and select "Promote to admin"
click "Save"

Here is the setup of admins of the channel:

At the end of the day, the setup of the chat/group is the following in the telegram UI:

Then I make my dotnet console application:
dotnet new console -o TestTelegram
dotnet add package Telegram.Bot

In program.cs, I put the following:
using System;
using System.Threading.Tasks;
using Telegram.Bot;

namespace TestTelegram
{
    public static class Program
    {
        public static async Task Main()
        {
            var bot = new TelegramBotClient("XXXXXX MY BOT TOKEN XXXXXXXXXXX"); // No pb here
            var me = await bot.GetMeAsync(); // No pb here
            var chat = await bot.GetChatAsync("@TestChannelChat"); // No pb here
            await bot.SendTextMessageAsync(chat.Id, $"{me.Username} is awake"); // Exception is raised here!!!
            Console.ReadLine();
        }
    }
}

I get the following exception at the line the tries to send a message: bot is not a member of the supergroup chat
Exception has occurred: CLR/Telegram.Bot.Exceptions.ApiRequestException
An exception of type 'Telegram.Bot.Exceptions.ApiRequestException' occurred in System.Private.CoreLib.dll but was not handled in user code: 'Forbidden: bot is not a member of the supergroup chat'
   at Telegram.Bot.TelegramBotClient.<MakeRequestAsync>d__54`1.MoveNext()
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at TestTelegram.Program.<Main>d__0.MoveNext() in /home/stephane/Documents/Sources/TestTelegram/Program.cs:line 15

I also made the following (to bypass the actual chat and directly publish a message in the channel):
using System;
using System.Threading.Tasks;
using Telegram.Bot;

namespace TestTelegram
{
    public static class Program
    {
        public static async Task Main()
        {
            var bot = new TelegramBotClient("XXXXXX MY BOT TOKEN XXXXXXXXXXX");
            var me = await bot.GetMeAsync();
            var chat = await bot.GetChatAsync("@TestChannel");
            await bot.SendTextMessageAsync(chat.Id, $"{me.Username} is awake");
            Console.ReadLine();
        }
    }
}

And I get the following exception instead (nearly the same): bot is not a member of the channel chat
Exception has occurred: CLR/Telegram.Bot.Exceptions.ApiRequestException
An exception of type 'Telegram.Bot.Exceptions.ApiRequestException' occurred in System.Private.CoreLib.dll but was not handled in user code: 'Forbidden: bot is not a member of the channel chat'
   at Telegram.Bot.TelegramBotClient.<MakeRequestAsync>d__54`1.MoveNext()
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at TestTelegram.Program.<Main>d__0.MoveNext() in /home/stephane/Documents/Sources/TestTelegram/Program.cs:line 15

One simple question: how to post a message on telegram with dotnet???

the chat id should be recovered by getting last updates on the bot user.

the chat id should be recovered by getting last updates on the bot user.


Error message with a job finished

One line summary of the issue here.
Expected behavior
I do expect the crawler do its job and successfully exit.
Actual behavior
Once the crawler got the job finished I do get this error message:
Steps to reproduce the behavior
I have used this simple python script:
# example.py

from nyawc.Options import Options
from nyawc.Crawler import Crawler
from nyawc.CrawlerActions import CrawlerActions
from nyawc.http.Request import Request

def cb_crawler_before_start():
    print("Crawler started.")

def cb_crawler_after_finish(queue):
    print("Crawler finished.")
    print("Found " + str(len(queue.get_all(QueueItem.STATUS_FINISHED))) + " requests.")

def cb_request_before_start(queue, queue_item):
    print("Starting: {}".format(queue_item.request.url))
    return CrawlerActions.DO_CONTINUE_CRAWLING

def cb_request_after_finish(queue, queue_item, new_queue_items):
    print("Finished: {}".format(queue_item.request.url))
    return CrawlerActions.DO_CONTINUE_CRAWLING

options = Options()

options.callbacks.crawler_before_start = cb_crawler_before_start # Called before the crawler starts crawling. Default is a null route.
options.callbacks.crawler_after_finish = cb_crawler_after_finish # Called after the crawler finished crawling. Default is a null route.
options.callbacks.request_before_start = cb_request_before_start # Called before the crawler starts a new request. Default is a null route.
options.callbacks.request_after_finish = cb_request_after_finish # Called after the crawler finishes a request. Default is a null route.

crawler = Crawler(options)

target = raw_input("[-] Target please:= ")

crawler.start_with(Request(target))

Error message:
Crawler finished.
global name 'QueueItem' is not defined
Traceback (most recent call last):
  File "/root/Desktop/attack_platform_combined/attack_platform_2/recon/crawler/not-your-average-web-crawler/nyawc/Crawler.py", line 208, in __crawler_finish
    self.__options.callbacks.crawler_after_finish(self.queue)
  File "crawler.py", line 13, in cb_crawler_after_finish
    print("Found " + str(len(queue.get_all(QueueItem.STATUS_FINISHED))) + " requests.")
NameError: global name 'QueueItem' is not defined

Is there anything which I can do / it can be done to have this fixed up?
Thanks!

Hello @Os3r3um,
Thank you for the extensive report. I think you need to import the QueueItem at the top of your file.
from nyawc.QueueItem import QueueItem
This import should be available across all the N.Y.A.W.C examples. If you copied this piece of code from somewhere, could you let me know where you found it?
Thanks.

Hi, thanks for the tip.
I got the original code from here:
https://tijme.github.io/not-your-average-web-crawler/latest/getting_started.html
Also, do you have a docker version of this? It will be simply amazing if this crawler would have a docker version. :)

At the moment I don't have a Docker version of N.Y.A.W.C because I don't use Docker myself.
But feel free to do a merge request.


Add ability to customize whether the bot is deafened on join or not.

Purpose? I don't believe selfDeaf changes anything regarding whether the bot can receive voice from users or not.

It seems like a wasteful API property and really serves no purpose besides being visual. I really don't see a reason to implement this. Receive data is discarded anyways. Is a tiny icon really that important?

As @strangenesX said, its purely cosmetic but still, i would like to see this property be added. I really have no idea at all why people are opposing this, its just a neat customization feature.

Self-Deafening most definitely does not affect whether bots can receive voice data from speaking users @NovusTheory


Layout changes for Arrow

This PR cherry-picks from the Arrow branch with all the changes to block layout and alignment.
All buffers are now aligned at 8-byte boundaries as opposed to at attribute size. Extra space is reserved for hot-cold access control and metadata for Arrow

This PR resolves the segfault I've found in master while writing TPC-C. It looks like the calculations for BlockLayout isn't quite right after introducing varlens to the system. This can be confirmed by looking at the MemorySafety and Alignment TAS tests and noting that their random layouts don't use varlen attributes. This branch addresses those test changes and appears to have the fix. Would like to get this reviewed and merged ASAP.

I can't reproduce the performance regressions on data_table_benchmark locally. The random read benchmarks are actually faster for me, as opposed to on Jenkins. We may need to revisit how to properly evaluate Data Table since it's so low level in the system, and minor changes seem to wildly swing its benchmarks that don't really manifest when you exercise the system through higher-level interfaces.


feature: Added is_available property to AwsDevice

Issue #, if available:
#269
Description of changes:
Added property is_available to AwdDevice that parses the availability window and current device status to return a boolean flag if the device is currently available.
Testing done:
Added unit tests in test_aws_device.py that mock various datetime values to test the various possible combinations of device windows. Ran tox to run unit test, linters, and docs.
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General

[x] I have read the CONTRIBUTING doc
[x] I used the commit message format described in CONTRIBUTING
[x] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

[x] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[x] I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@surfkansas Thank you for this contribution. We are planning to merge but it's currently held up by independent changes. No further action needed from you here.


unexpected: closing PR closes all PRs for the commit not the branch

if i have two prs:
- #1 fix: [ABC-123] do-something
- #2 invalid branch name

and they have different branches:
- #1 fix: [ABC-123] do-something
     fix/ABC-123-do-something
- #2 invalid branch name
     invalid-branch-name

But both those branches point to the same commit ref:
- #1 fix: [ABC-123] do-something
     d280cce fix/ABC-123-do-something
- #2 invalid branch name
     d280cce invalid-branch-name

This ends up doing the following:

closes both PRs
leaves a comment on both PRs
deletes the invalid-branch-name branch

Expectations:

closes PR #2
leaves a comment on PR #2
deletes the invalid-branch-name branch

Is there something I'm missing?

Then when i run this action with:
# ./pkg/format-prtitle/action.yml

name: Enforce branch name conventions

description: This will close pull requests that do not follow the branch naming conventions

inputs:
  ValidationPattern:
    description: acceptable branch name regex
    required: false
  ValidationCommand:
    description: a command to run that returns exit code 0 for success or exit code 1 for failure
    required: false
  HelpUrl:
    description: A url to display that provides more detailed information to the user
    required: false
  GithubToken:
    description: should we use context or fetch the latest title
    required: false
    default: ${{github.token}}
  BranchName:
    description: name of the branch to test
    required: true

runs:
  using: "composite"

  steps:
    - name: Test branch with pattern
      if: inputs.ValidationPattern != '' && inputs.ValidationCommand == ''
      uses: actions/github-script@v6
      env:
        PATTERN: ${{inputs.ValidationPattern}}
        BRANCH: ${{inputs.BranchName}}
      with:
        github-token: ${{inputs.GithubToken}}
        script: |
          const validator = new RegExp(process.env.PATTERN);
          validator.test(process.env.BRANCH)
            ? process.exit(0)
            : process.exit(1);

    - name: Test brach with command
      if: inputs.ValidationPattern == '' && inputs.ValidationCommand != ''
      shell: bash
      run: ${{inputs.ValidationCommand}}

    - name: create additional information link
      if: failure()
      shell: bash
      env:
        HELP_URL: ${{inputs.HelpUrl}}
      run: |
        [ -n "${HELP_URL}" ] && {
          echo "MORE_INFORMATION='For more information see: ${HELP_URL}'" >> $GITHUB_ENV
        } || {
          echo "MORE_INFORMATION=''" >> $GITHUB_ENV
        }

    - name: Add/Update Help Comment
      if: failure()
      uses: peter-evans/close-pull@v2
      with:
        token: ${{inputs.GithubToken}}
        delete-branch: true
        comment: |
          The branch name used is invalid.

          To fix this, please rename your branch locally and open a new pull request.

          ```
          $ git branch -m <correct branch pattern>
          ```

          ${{env.MORE_INFORMATION}}

which will be run in a workflow like so:
# .github/workflows/code-review-titles.yml

name: CodeReviewTitles

on:
  pull_request:
    types: ['opened', 'edited', 'reopened', 'ready_for_review', 'synchronize']

concurrency:
  group: ${{ github.workflow }}-${{ github.ref }}
  cancel-in-progress: true

jobs:
  Format:
    runs-on: ubuntu-latest

    permissions:
      pull-requests: write
      issues: write
      contents: read
      repository-projects: write

    steps:
      - uses: actions/checkout@v3

      - name: get branchpattern
        id: branchpattern
        uses: actions/github-script@v6
        with:
          github-token: ${{secrets.OUR_BOT_TOKEN}}
          script: return require("./.validate-branch-namerc").pattern
          result-encoding: string

      - name: Close PRs with invalid branchnames
        uses: ./pkg/enforce-branchname
        with:
          ValidationPattern: ${{steps.branchpattern.outputs.result}}
          BranchName: ${{github.head_ref}}

      - uses: ./pkg/format-prtitle
        with:
          Pattern: ${{steps.branchpattern.outputs.result}}
          GithubToken: ${{secrets.OUR_BOT_TOKEN}}

      - uses: ./pkg/setup-tooling

      - uses: ./pkg/setup-pnpm

      - uses: ./pkg/commitlint-prtitle
        with:
          InstallCommitLint: false
          FetchTitle: true
          GithubToken: ${{secrets.OUR_BOT_TOKEN}}

Hi @airtonix

leaves a comment on both PRs

The only way the action could do that is if it's being run for both PRs. It can only deal with one PR number at a time. So if a comment is being made, that is a pretty clear signal that the action is being run for that PR number. Check your logic for when the action is run.


[WIP] Add profiler under a flag

Adding an evaluation profiler, enabled via a command line flag (/profileevaluation:file).
When turned on, it generates a report after the build finishes. See documentation/evaluation-profiling.md for more details

@smera,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla2.dotnetfoundation.org.
It will cover your contributions to all .NET Foundation-managed open source projects.
Thanks,
.NET Foundation Pull Request Bot

@smera, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, .NET Foundation Pull Request Bot

This is looking really good!!
Minor thing, I like that xmake knows how to parse the params to turn on the profiling and create the logger, but I don't think writing the file should be there. That should happen on shutdown like a normal file logger would. So the logger is just something that happens to listen for that data and writes it out in the default format it knows about.
@KirillOsenkov seems like we should just add this to the binary logger file. Would be easy to do, and could even have a nice visualization someday? And we're changing the format anyway seems no harm in adding that. So in that case maybe /prof by itself would turn the feature on but not attach the ProfileLogger? And then the binary logger would pick them up and write them to the file? So you would build msbuild /bl /prof. And later you could msbuild msbuild.binlog /prof:file.md to get the default experience. I'm also curious what perf impact this has if we should force /prof on when /bl is specified similar to other things. But we'd need some numbers to know that. My guess is it's not that bad though, esp. when you're doing a debug build.
@mmitche any idea what's wrong with our CI? None of the jobs are reporting status apparently. Not sure how to debug that without links to them.

FYI for the binary logger:
https://github.com/Microsoft/msbuild/blob/e122c897f6c7fe10ac07b01c19110d8b03bfd818/src/Build/Logging/BinaryLogger/BuildEventArgsReader.cs#L205-L216
and
https://github.com/Microsoft/msbuild/blob/237db30c73369928c3e7cc563d1c18eb0a114ef8/src/Build/Logging/BinaryLogger/BuildEventArgsWriter.cs#L127-L132
Need to update the version as well since this is (another) breaking change.

They look like they are reporting now.

@AndyGerlicher ci2 was offline for a bit while a server move was happening.

I've filed https://github.com/Microsoft/msbuild/issues/2768 to track this.
Would indeed to be nice to serialize this info to the .binlog if available. @smera if you have cycles would be awesome if you could get to it (perhaps as part of a separate PR). I can come down and explain how binlog serialization works, it's not hard. We can maybe even write it together.

@Andy Gerlicher, moved the saving part to the logger

In reply to: 348609891 [](ancestors = 348609891)

I'll try to address that as a separate PR

In reply to: 348642187 [](ancestors = 348642187)

@dotnet-bot test this please
Odd they all timed out except the full framework build...

@dotnet-bot test this please

@dotnet-bot test this please

@dotnet-bot test this please

@dotnet-bot test Windows_NT Build for CoreCLR please

Green CI!!! :)


Single Signin between MVC & SPA

I have a functional Identity Server, a MVC app using Hybrid Flow and a React SPA using Authorization Code Flow (using oidc-client).
Both the apps are work fine with Identity Server, however when a user logs into the SPA and after being authorized visits the MVC app, the user still shows as being not logged in. He needs to click on the Login button upon which he is redirected to the IDS and then redirected back to the MVC app (not asked for credentials - which is fine).
Is it expected behavior for the MVC app to not know that the user has already logged into the Identity Server? If not, what could I be doing wrong?
If it is expected behavior, does Identity Server support back channel login which I can use to check if the user is logged in and generate a claims principal?
I've already implemented a back channel logout which seems to be working fine.
Thanks
Vishal

I did some more reading and it seems this is normal behaviour since the client itself needs to be authenticated. Which brings me to the second point. How does something like you tube know when you've logged into Gmail that the user is logged in.
Will opening up a check session iframe help to determine if that the OP has a valid login?

This seems to be a general question about IdentityServer - not a bug report or an issue.
Please use one of the our free or commercial support options
See here for more details.
Thanks!


PlaybackTrackChanged event fires multiple time and returns inaccurate data

Describe the Bug
The PlaybackTrackChanged fires twice on the first song I play, then 3 times on any other song that is not at index 0. Here's what it looks like:

Playing first song in queue
Here I expect nextTrack to equal 1. position is always 0

 LOG  {"position": 0, "track": 0, "type": "playback-track-changed"}
 LOG  {"nextTrack": 0, "position": 0, "type": "playback-track-changed"}

Selecting next song manually
Here I expect nextTrack to equal 2. position is still always 0. The first event always returns but with no nextTrack property

 LOG  {"position": 0, "track": 0, "type": "playback-track-changed"}
 LOG  {"nextTrack": 0, "position": 0, "type": "playback-track-changed"}
 LOG  {"nextTrack": 1, "position": 0, "track": 0, "type": "playback-track-changed"}

Steps/code To Reproduce
I have a list of song rows and when clicking any row, the player is reset, tracks are re-added from the current screen, player skips to the next track, and then play. This is all done inside a generator function from mobx-state-tree (see async actions), hence the yield instead of await, which is similar to redux-saga.
const tracks = songData.reduce(s => ({
  acc.push({
    id: s.id,
    url: s.mp3,
    title: s.title,
    artist: s.artist,
    duration: s.duration,
}, acc)

yield TrackPlayer.reset()
yield TrackPlayer.add(tracks)
const trackIndex = self.songIds.indexOf(song.id)
yield TrackPlayer.skip(trackIndex)
yield TrackPlayer.play()

Environment Info:
System:
    OS: macOS 12.2.1
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
    Memory: 35.80 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.14.0 - ~/.asdf/installs/nodejs/16.14.0/bin/node
    Yarn: 1.22.17 - /usr/local/bin/yarn
    npm: 8.3.1 - ~/.asdf/plugins/nodejs/shims/npm
    Watchman: 2<IP_ADDRESS> - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.11.2 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 21.4, iOS 15.4, macOS 12.3, tvOS 15.4, watchOS 8.5
    Android SDK:
      API Levels: 29, 30
      Build Tools: 30.0.2, 32.0.0
      System Images: android-Tiramisu | Google APIs Intel x86 Atom_64
      Android NDK: Not Found
  IDEs:
    Android Studio: 2021.1 AI-211.7628.21.2111.8193401
    Xcode: 13.3/13E113 - /usr/bin/xcodebuild
  Languages:
    Java: 11.0.11 - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 17.0.2 => 17.0.2
    react-native: 0.67.2 => 0.67.2
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Version 2.1.3
Simulator, IOS 13.7 on iPhone 11
How I can Help
What can you do to help resolve this?
Have you investigated the underlying JS or Swift/Android code causing this bug?
Can you create a Pull Request with a fix?

@andrewdang17 Do you have the ability or interest to do some deeper investigation here? Happy to provide some guidance!

@jspizziri yes that would be great!

@andrewdang17 awesome, let me know what questions you have. Looking forward to your PR!

@andrewdang17 after doing a little bit of digging here it looks like this is only an issue with RepeatMode.Track, can you confirm?

@andrewdang17 just submitted a fix for this issue: https://github.com/doublesymmetry/react-native-track-player/pull/1482

Hi, I am having this issue with Android and beyond the repeat mode.
Actual behavior:

I initialize the TrackPlayer (setupPlayer)
Then I subscribe to the "playback-track-changed" event
I add a track to the Player, then the event is fired twice
When the track changes, the event is fired but in some occasions (random) the is fired twice

Expected behavior:

When the trackPlayer is created (or reseted) and a track is added, the event is fired once
When the trackPlayer is playing and the current track changes, the event is fired once

Environment:
TrackPlayer version: 2.1.3
React-Native version: 0.67.3
Android Emulator Device: Google Pixel 3a API 30, Android 11.0 Google Play.

fixed via https://github.com/doublesymmetry/react-native-track-player/pull/1501

Hello, I am using 2.1.3 of React Native Track Player and the event PlaybackTrackChanged is firing numerous times for a single track. Has this issue been completely solved?

The most problematic thing about this event is the fact that it‘s both unpredictable and inconsistent between platforms.
I have an update logic based on the queue advancing, that due to the lack for a better api, I must solve by observing Event.PlaybackTrackChange and calling TrackPlayer.getCurrentTrack in it. To then execute the logic, I must compare the result to a ref of the last call to that handler.
It's a giant mess and gets even messier, when I have to reset the queue due to the user rearranging the items in the app.
Now with that working I then run into the new issues due to android and ios having different occurrences of this event.
This all would've been so much easier if we just had hooks to receive the current track and the queue.
Perhaps eventually I'll try to contribute to this repo myself, however until then, I must first find a way to get this working with the current APIs (have been on it for quite a bit 😦)


Merging annotation table and image table ID data type and format issue

Hello! I am using the dlpy API as well as CAS actions in a computer vision project. Me and my colleagues have correctly prepared the labeling data and have brought in the images into CAS using the code below.

We are running into a problem when trying to merge the label table with the image table. Even though I explicitly changed the format and data type of the column we are merging on in both tables to make sure they're the same we are still getting the error that the ID columns aren't the same data type or format (reference the below screenshots for specific error and format).

This error is not in the documentation and I can't seem to find the solution anywhere else online. Please let me know if you need additional information. Thank you for your help in advance!

Try "$30.". I never use CHAR before. Pay attentions to formattedLength. It looks they still do not match.

@buhrowcr have you tried what @sasxianhu suggested? thanks


Duplicate snippet problem

Your extension comes with C# snippets. I use my own snippets so I do not want duplication of snippets. Of course I can disable all your snippets one by one but it's difficult. Please add setting, something like:
"csharp-snippet-productivity.EnableSnippets": true/false

Hi @BachiMjavanadze , this is a tricky one. There is a ticket open for Microsoft to add a feature on vscode in which we could select and disable specific snippets, built-in and user made. As you said, you can enable or disable visibility in each individual one, is a pain, I know. The whole idea of extensions is, to have snippets separated from your extension, so that you could decide to install or not. In my case, when I created the extension I decided to create a bundle with everything necessary for the user to develop in C# within vscode, which also includes the snippets I provided. If the snippets are not good enough, please let me know, I can create/modify to make the snippets even better.
Now, if you really want a final solution, not just for my extension but for other extensions that you are annoyed by, you can use this extension here: https://marketplace.visualstudio.com/items?itemName=svipas.control-snippets
It is an extension that gives you the capability to enable or disable built in or custom made snippets.

Thank you for sharing me Control Snippets  extension. it is an awesome extension. I did not know about it.
I didn't check your snippets because I always prefer my own, but as you have a goal to do all in one extension, I will check it


ac-image in Internet Explorer 11 stretches from max-width 100% but does not adjust height

Platform

JavaScript

Author or host
Web Chat, related to https://github.com/microsoft/BotFramework-WebChat/issues/1944
Version of SDK
1.2
Issue
(card json is provided at the bottom)
On Chrome, an Adaptive Card renders as expected (with Web Chat host config):

However, when shown in Internet Explorer 11, the image is stretched and also has an invisible overflow that causes the card to display as much larger than expected:

Note that the image is stretched and the card no longer appears immediately above the input.
When inspecting the image, unchecking max-width: 100% shows the image in full size, showing that height is unadjusted when max-width is applied, making the image larger than the card's original borders.

This is reproduced on the Adaptive Card visualizer:

Below is the json for the card in this example:
{
    "type": "AdaptiveCard",
    "body": [
        {
            "type": "ColumnSet",
            "columns": [
                {
                    "type": "Column",
                    "items": [
                        {
                            "type": "TextBlock",
                            "text": "Airports"
                        },
                        {
                            "type": "TextBlock",
                            "spacing": "None",
                            "size": "ExtraLarge",
                            "weight": "Bolder",
                            "text": "Sea-Tac"
                        },
                        {
                            "type": "TextBlock",
                            "spacing": "None",
                            "text": "3 ★★★☆☆ (856) · $$$$",
                            "isSubtle": true
                        },
                        {
                            "type": "TextBlock",
                            "size": "Small",
                            "text": "**Steve G. said** \"Another day, another airport.\"",
                            "wrap": true
                        }
                    ],
                    "width": 2
                },
                {
                    "type": "Column",
                    "items": [
                        {
                            "type": "Image",
                            "url": "https://upload.wikimedia.org/wikipedia/commons/2/23/Deltalax_%28cropped%29.jpg"
                        }
                    ],
                    "width": 1
                }
            ]
        }
    ],
    "actions": [
        {
            "type": "Action.OpenUrl",
            "title": "More Info",
            "url": "https://www.portseattle.org/sea-tac"
        }
    ],
    "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
    "version": "1.0",
    "speak": "three of five stars, 856 reviews, Extremely Expensive. Steve G said, \"Another day, another airport\""
}

Great bug find and report @corinagum! What's the priority of this issue?

For Web Chat this is low priority. :)  I went ahead and edited our broken card with a different (smaller) image to avoid causing this issue.

@dclaux could you help take a first stab ? What i am unclear about is why the browser would come into the picture if the JS library is the same ? Also do we want to support IE11 at this point? @andrewleader / @matthidinger thoughts?

IE11 is not a supported browser


Environment Object Type XB can not be converted to Transport Object Type

Dependency determination created an abend as this type could not be translated.
Object causing the issue was FUGR FACI.

Thought I had fixed this in https://github.com/abaplint/abaplint-sci-client/pull/124.
https://github.com/abaplint/abaplint-sci-client/blob/master/src/deps/zcl_abaplint_deps_find.clas.abap#L289
Is this where is dumps?

It dumped already on the line before. The Type XB did not convert.
Also the fuba call on around 300 did not get the correct input and always failed.
See #151

Merged


Features for Panache Reactive

Hi,
I've started to port Panache Reactive and found the following methods I used to call on EntityManager or the JPA Query to be missing:

Query.setLockMode (the one taking no alias and a JPA lock enum). It appears not trivial to call the present version with aliases because the code paths differ, so not sure they're equivalent
Query.setHint
Query.getQueryOptions (required to get current paging info)
Multi<T> Query.getResuls() for streaming results, but that one's probably planned for later and I can probably emulate it by wrapping the Uni<List> result for now

If those first three are easy to support, can we get them please?

Damn, so the very first actual user of this stuff is the guy who's using all the features where I said to myself "oh, nobody every uses that".

What is it that you're passing to setHint()?

I have given you two of your wishlist items, completely without any sort of testing at all.

Thanks :)

So to summarize where we're at on this one:

Query.setLockMode is done.
Query.setHint() is implemented but not exposed, because I can't find any hints where are meaningful for use:

the vertx client doesn't have timeouts yet
there is no notion of a fetch size
we have a setComment() method, no need for a hint for that
likewise, we have methods for setting the flush mode and lock mode
I have not tested fetch plans with queries, and if/when we do, I would add a method for it
we don't support the query cache yet (at least, we have not tested it), and when we do I would add methods for this

I have not done anything about getQueryOptions(). The only relevant options are first/max result, so perhaps I should just add getters for those two settings.
Streaming results is #153.

I have not done anything about getQueryOptions(). The only relevant options are first/max result, so perhaps I should just add getters for those two settings.

Now I've added getters in 6ad870b3512ebc35bcbe5be2588c493f1b678c2a.
@FroMage may I close this issue please?

Actually I just noticed you didn't give me setLockMode(LockModeType) which takes the JPA lock mode enum (not the Hibernate enum). Is that on purpose?

Yes, it's on purpose because Hibernate actually has a couple of extra very specific LockModes that JPA doesn't have (UPGRADE_NOWAIT and UPGRADE_SKIPLOCKED) and because the other enums (CacheMode and FlushMode are also from org.hibernate).
Now, I wouldn't object to overloading those methods to accept the JPA version if it would help.

Now, I wouldn't object to overloading those methods to accept the JPA version if it would help.

(On the other hand, that might not help much, since the getters would still be returning the org.hibernate version.)

I mean, ATM I'm calling:
            jpaQuery.setLockMode(LockModeConverter.convertToLockMode(lockModeType));

and downstream, you do the exact opposite :(

Oh, damnit, I should have checked what we use the getQueryOptions method for, it turns out we use it to reset paging:
//            RowSelection options = jpaQuery.unwrap(org.hibernate.query.Query.class).getQueryOptions();
//            options.setFirstRow(null);
//            options.setMaxRows(null);

Sorry about this, I got confused about what this code did, that's my fault. The normal setters don't seem to allow for disabling paging.

and downstream, you do the exact opposite

I don't. Internally Hibernate converts all LockModeTypes to LockModes.

The normal setters don't seem to allow for disabling paging.

They do, I think: you set first to 0 and maz to Integer.MAX_VALUE. I believe that that is documented :-)

They do, I think: you set first to 0 and maz to Integer.MAX_VALUE. I believe that that is documented :-)

Huh. IIRC when this PR got merged, the reporter reported still seeing LIMIT/OFFSET clauses in the db query when using that method. But perhaps my memory is wrong.

LimitHelper.hasFirstRow  agrees with you, but LimitHelper.hasMaxRows doesn't.

LimitHelper.hasFirstRow agrees with you, but LimitHelper.hasMaxRows doesn't.

In fairness, the JPA spec is a bit ambiguous. It does say that getMaxRows() returns MAX_VALUE when not set, but it doesn't say what setting MAX_VALUE does.
I would prefer to change Hibernate to interpret MAX_VALUE as no limit.

and downstream, you do the exact opposite

I don't. Internally Hibernate converts all LockModeTypes to LockModes.

Oh wait. You're right, inside the Query they do get converted to the LockModeType. And then back to LockMode later on, I suppose. Pfff.

and downstream, you do the exact opposite

I don't. Internally Hibernate converts all LockModeTypes to LockModes.

Oh wait. You're right, inside the Query they do get converted to the LockModeType. And then back to LockMode later on, I suppose. Pfff.

Oh but only for the one with no alias. Sheesh.

Hahaha OMG the Query converts the LockMode to a LockModeType and then back to a LockMode.

Hahaha OMG the Query converts the LockMode to a LockModeType and then back to a LockMode.

Fixed.

I have not tested fetch plans with queries, and if/when we do, I would add a method for it

I tested this, and ORM itself has a rubbish implementation (n+1 selects) so I won't expose it for now. (If I'm not mistaken, this will be fixed in H6.)

we don't support the query cache yet

I've opened #247 to capture this.

Closing this one, since the remaining work is in #153 and #247.
@FroMage if something else is still missing please let me know.


[Feature] Adding a new Card

Description
I want to add a new 3-D Animated card in Cards Component.
Card will contain a image, heading and some information.
Normally card will show image with heading.
On hovering it will display the informations with beautifull animation.
I am already working on it i will complete it soon.
Kindly assign this to me under IWOC2024.
Screenshots
No response
Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[X] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

Carry on @Prince-kushwaha-2004


ConfigurationBuilder fails to load custom appsettings file

Is this a Bug or Feature request?:
Bug
Steps to reproduce (preferrably a link to a GitHub repo with a repro project):
docker run -ti -p 80:80 -e ASPNETCORE_ENVIRONMENT=Docker bdparrish/test:0.1 (<-- local repo)
Description of the problem:
The web application fails to load a varibale from appsettings.Docker.json file.  If I change the command to the following, then it will pickup the appsettings.Development.json file and load the same variable.  The files are the exact same except for the filename change.
docker run -ti -p 80:80 -e ASPNETCORE_ENVIRONMENT=Development bdparrish/test:0.1
Version of Microsoft.AspNetCore.Mvc or Microsoft.AspNetCore.App or Microsoft.AspNetCore.All:
Microsoft.AspNetCore.All: 2.0.8

Issue was a bad configuration that overwrote the initial configuration in the DbContext.


Optionally declare network interfaces in driver config …

…useful for when you need an eth0 and an eth1 for mockup/testing.

Hi @ssplatt - any chance I could get some feedback on this and then get it merged if it's acceptable?  Thanks.


postNewUserMessageWithPubSub() now returns a promise on user_message_new

postUserMessageWithPubSub() now returns a promise that gets resolved when we receive the user_message_new event.
The return type associated with the Promise is a UserMessageType.

addressed all your comments @spolu

:+1:


mariadb: adds prometheus metrics sidecar container

Adds prom/mysqld-exporter sidecar container to expose
a metrics endpoint for prometheus. The exporter should be
enabled using metrics.enable=true while deploying the
chart.
Bumps the chart version to 0.7.0

@sameersbn I am pretty interested in this PR and I definitely hope it gets merged soon (if only to push the trend of having built-in prometheus monitoring into the standard charts).
Question though : you don't seem to expose the metric port 9104 in the service and therefore, despite the annotations that tell prometheus where to scrape, the mariadb service wouldn't expose the metrics port, no?

@dadicool The idea is to deploy prometheus in the same cluster as the mariadb deployment, in which case the 9104 port does not need to be exposed. I wrote a short blog post about this setup https://medium.com/bitnami-perspectives/monitoring-a-mariadb-server-using-prometheus-and-grafana-5ee3d1c5360e. Hope you find it useful.

ping @mgoodness

updated!

/lgtm


create docker environment

I'm glad to hear that you're interested in my work. Due to issues with your server environment, if you've been having trouble with the installation, could you package the virtual environment into a Docker container? Thank you very much.

Sorry, I didn't understand your question. Did you encounter any issues while installing the environment?


Typo in line 49

Typo in line 49:  "targetingCatergories" instead of "targetingCategories" .. which makes the template fails.

We've removed this file


fix(behavior_velocity): fix interpolation add missing last point

Signed-off-by: tanaka3<EMAIL_ADDRESS>Related Issue(required)
#500
Description(required)
add missing last point of spline interpolation of planning util
before

after

Review Procedure(required)
launch psim and see path interpolation with psim
To visualize interpolated path set occlusion spot param method: "occupancy_grid" and enable flag

@takayuki5168
can you take a look at this?
Related PR(optional)

Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.

[x] Read commit-guidelines
[x] Assign PR to reviewer

If you are adding new package following items are required:

[ ] Documentation with description of the package is available
[ ] A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.

[ ] Commits are properly organized and messages are according to the guideline
[ ] PR title describes the changes

Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.

[ ] All open points are addressed and tracked via issues or tickets

CI Checks

Build and test for PR / build-and-test-pr: Required to pass before the merge.
Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the [guidelines][clang-tidy-guidelines].
Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@takayuki5168
can you take a look at this?

-[x] release note


Improve setup process

The current setup process has a number of steps that must happen before getting started that aren't well described in the README or code, including setting up accounts for API keys, app-specific setup, and installing required python dependencies. Also, the setup process could benefit from moving some inline configs to a .env. (and hiding properly via .gitignore).
This PR adds all of these and also updates the README accordingly. It doesn't change the scripts to keep things straightforward, except to use the newly defined env vars.

@peterw I should have opened an issue but went ahead with some small tweaks to improve the setup process. Lmkwyt.

thanks, merged.


Update to new format

Thanks @Orin-Thomas the TOC was already created within a branch and the deployment & demos instructions were converted into markdown.


Aesthetics and  design

I like your module but I got 2 problems with it.

font or maybe div its squeezed in to small box with don't really match other modules, its there any chance that you will give me any idea where can change the size of the font?

Just in my option the text should be displayed in one line

i want to achieve something that looks like this:

if you can point me at some direction where can i personalize the module.

Did you ever figure this out?

Hey guys, that's a good idea. Unfortunately I currently have very limited time to work on any non-work non-family topics :)
I'll try to have a look at it.

I had the same thought and I made some style changes to the js so that it looks more like the calendar module.

There are some more changes I made because I wanted to display walking times and some other things. I left the routes on two lines. I initially wanted to change it to a single line, but then figured it's much easier to read on two seperate lines, especially as I added more information on the route
The important part is changing the className
span.className = "normal bright";
and
span.className = "xsmall dimmed";
in the renderLeg and renderStep function
it initially wouldn't load the main css file for me and I copied it into the localtransport directory, then it worked. I am not sure that is necessary though.
In order to add the fade effect, I appended all the routes to a list, sorted that list by arrival time and then applied opacity to the list elements. I adapted that code from the calendar module:
      routeArray.sort(function(a, b) {
        return parseFloat(a.arrival) - parseFloat(b.arrival);
      });
      var e = 0;
      for(var dataKey in routeArray) {
        var routeData = routeArray[dataKey];
        var routeHtml = routeData.html;
        // Create fade effect.
        if (this.config.fade && this.config.fadePoint < 1) {
           if (this.config.fadePoint < 0) {
               this.config.fadePoint = 0;
           }
           var startingPoint = Nrs * this.config.fadePoint;
           var steps = Nrs - startingPoint;
           if (e >= startingPoint) {
               var currentStep = e - startingPoint;
               routeHtml.style.opacity = 1 - (1 / steps * currentStep);
           }
        }
        ul.appendChild(routeHtml);
        e += 1;
      }
      wrapper.appendChild(ul);

happy to post the full code once it's cleaned up :-)

Looks good, would be nice to have a "compact" mode where the width is less than 250px.

I have a configuration variable that toggles walking on or off - same for the stations. So one can have a compact mode...
I cleaned the code, forked your project and uploaded it. (Obviously it's an all in one commit now)
Still need to figure out how I can allow you to merge the fork back into your project. (Sorry, I am new to GitHub)

@GHLasse , is there a way i can change script to pull bus schedule now rather than an hour later? All the timings i am getting are almost an hour later. Nice work btw. Thank you

@Rian9771 not sure why you would get the timings to be an hour later. Google should accept the key departure_time=now. Works fine for me. I actually never changed that part of the code.
Maybe make sure that you have your timezone set correctly? Also make sure to test this during the day, when there are busses going more often than once an hour. Lastly: Google doesn't suggest any busses you can't reach anymore.
That's all I can think of. Hope it helps :-)

@GHLasse , i have looked at the config file/scripts but i do not see a place where i could define a timezone. Where would i see this? I have not changed anything else. No matter what i use for "origin" or "destination", all timings are close to an hour ahead. Super Weird!

@Rian9771: I meant the timezone in your raspberry pi. But check out the line
params += '&departure_time=now';
requesting google to deal with the departure time.
Can you post your full configuration? That way I can try to reproduce the error...

@GHLasse , the TZ on the pi is setup correctly. Other modules that use TZ values are working fine. I remember seeing "params += '&departure_time=now';" on the config file and i have not changed it and i believe it is still set to "now" as i would like to keep getting new arrival times. I was browsing google API documentation and did notice a way to pass timezone values but i have not been able to figure that out yet. Would be awesome if you could point me to the right direction. Thanks.

Hey :-)
thanks for your work - i notice the notification doesnt work when the module is active - and i cant found the problem
do you have an idea ?
thanks

@tiduspup is this related to this issue or rather a new issue?
Can you explain what exactly the problem is in a bit more detail? I used notifications to debug other modules I created (Note to myself: I should start uploading them to GitHub) and it worked fine. In fact another module displayed a lot of notifications on my MM the other day.


fix for #73

Please check whether the changes are sufficient.

Correct docker-compose version fixed the issue.