182120562 - Use Firestore aggregate data to render 3D view...

@lublagg - I added a bunch of utility functions, and updated the Three D view to use the student data.
However:  It doesn't appear to be working. The first render creates the mesh with default values, but then when the collection documents come in, the mesh doesn't update. We might have to work on this together on Monday.
I put in some debugging (json of the aggregate geometry vertex data) to show that the vertexes are being updated, but the ThreeJS view isn't updating...
I think we are close.


docs: update the lists of UEFI targets

I think it probably makes sense to remove the "this crate currently has only been tested with..." line from the readme since the crate also works fine with the i686 target, but that should probably wait until tests for that target have been added to the CI.

Thanks, the changes look good!


Implement an overload of confirmation() that takes an unbounded range.

Unbounded ranges are not meaningful when used with confirmation() because any confirmation count matches. As well, the ... operator produces an instance of UnboundedRange which is a non-nominal type and cannot conform to RangeExpression. It may be non-obvious to a developer why ... doesn't work as the expectedCount argument to that function when other range operators work as expected.
This PR implements a stub overload of confirmation() that takes an unbounded range. The stub overload is marked unavailable and cannot be called.
Example usage:
await confirmation("Stuff happens", expectedCount: ...) { stuff in
  // ...
}

Generated diagnostic:

🛑 'confirmation(:expectedCount:sourceLocation::)' is unavailable: Unbounded range '...' has no effect when used with a confirmation.

As a reminder, using a range expression with confirmation() is an experimental feature and has not been API-reviewed.
Checklist:

[x] Code and documentation should follow the style of the Style Guide.
[x] If public symbols are renamed or modified, DocC references should be updated.

@swift-ci please test

@swift-ci please test

Self-reviewing (tsk.)


Command for brew to run after install to check for service restart

I made a command that the brew test step can run keybase check which will trigger a service restart if service is running and client version > service. It doesn't trigger service install and noops if service not installed so should be ok for main brew tap.

Doesn't compile on windows / linux ^

I think it's best to do this automatically on every command line run, and not as a separate command
see CORE-2102 and CORE-1989 in Jira.

ok closing as not what we want

maybe we can still use this to restart service in brew so it won't need to auto restart later?


Otterscan's DS block view doesn't work against zq2

.. partly because of the wrong field names in BlockChainInfo, partly because GetDsBlock is not yet implemented.

we'll remove the DS block list and only show TX blocks for now

Duplicate of https://github.com/Zilliqa/otterscan/issues/39


catch onboard errors and faster css bundling

This PR catches errors in the onboard flow, which prevent's crashes.

Also fixes a few webpack warnings / faster css bundling.
Removes some unused imports.

If an async back-end call would fail, it will be catched and logged inside a catch block. Letting the rest of the code execute fine.


Sort option triggers erratic behavior on big collections

What happened?
Collection example:
https://canary.kodadot.xyz/rmrk/collection/08C79124CAC59DC643-BOREDBARRO?collectionId=08C79124CAC59DC643-BOREDBARRO
https://canary.kodadot.xyz/ksm/collection/e63e926f7db5997e5c-STGR?collectionId=e63e926f7db5997e5c-STGR&sort=instance_ASC&page=2
https://github.com/kodadot/nft-gallery/assets/36627808/59e2b698-eb0c-408b-b569-4f5f6550c341
Please reproduce in steps
Go to specified collection -> sort by any of the options -> scroll down, wait -> scroll down
Expected Behavior
this should not happen :)
What browsers are you seeing the problem on?
Desktop Chrome, Desktop Firefox
At which address did you encounter bug?
canary.kodadot.xyz
Are you logged in?
No
Which wallet you are using?
No response
At which chain did you encounter bug?
No response
Screenshots
^
|
Relevant log output
No response
Payment link for reward
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

might be related with #5702

👋🏻


Flake8 rule 'E901' reported an invalid point

Flake8 reported an invalid point for the rule E901, with the messge SyntaxError: invalid syntax.

Debug information:
Atom version: 1.12.9
Flake8 version: 2.5.4 (pep8: 1.7.0, mccabe: 0.2.1, pyflakes: 1.1.0) CPython 3.5.2 on Linux

Please update your flake8 version (pip install -U flake8). This particular error should be fixed in flake8>=3.2.1.

Closing due to a lack of response, if you are still having issues after updating flake8 please provide code to reproduce this!


fix: add composer.json

I set discussions to the main bootscore repo disucssions

@sean-au please check https://github.com/bootscore/bs-swiper/pull/19/commits/23fc194766fe22bbd74c3034e14beafde9447e83

https://packagist.org/packages/bootscore/bs-swiper


INP001 failing even after adding __init__.py to the relevant folder

I updated to ruff v0.0.229, and added INP to the list of linters I would like to run.
After running the new version it failed with the below error (which was correct);
src/xxx.py:1:1: INP001 File `src/xxx.py` is part of an implicit namespace package. Add an `__init__.py`.

I added __init__.py to the src folder, and yet.. I'm seeing the same error.
I did an experiment, and I added in a different branch __init__.py to the src folder before running ruff, and indeed there is no INP001 failure, I then deleted the __init__.py from the src file, and this time when I ran ruff I didn't encounter any INP001 failure.
If I'm not missing anything (which usually I do :-)), it seems that something is cached and not being cleared correctly

Mmm yeah, good call, this definitely breaks our caching model, since it's a per-file check that depends on other files.
You can run Ruff with -n or --no-cache for now. It shouldn't be much of a noticeable difference. Let me think on how to fix this.

(This was a bit premature -- #2077 is a good change, but this issue is still possible with that alone.)

This seems to be still happening in 0.0.275. I have to run ruff with --no-cache or delete the cache manually for the solved INP001 warnings. Has the bug regressed or am I missing something ?

Probably a regression, we made some changes to the cache recently.

(Created a new issue: https://github.com/astral-sh/ruff/issues/5449.)


remove old drag-target

remove old drag-target to prevent a lot of drat-target after re-init several times.

remove old drag-target to prevent a lot of drat-target after re-init several times.

@DanielRuf This looks good to me, but @zhaoyao91 Is this an issue that happens a lot?

Could be simplified. We could check with .lenth if the element already exists and append it if not.
But this here works too and also looks good to me.

This has been taken care of in the sidenav rewrite for v1

@acburst can you link the commit which fixes it?


[WIP] Updated MQTT connector docs

PR description
The documentation updated for MQTT connector.
Link checker
The links will be checked by the build agent automatically once you create or update your PR.
You can use the following command to check the broken links locally.
docker run --rm -it --network=host --name=linkchecker ghcr.io/linkchecker/linkchecker --check-extern --no-warnings http://<IP_ADDRESS>:4000/

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.3 out of 4 committers have signed the CLA.:white_check_mark: samson0v:white_check_mark: ArtemDzhereleiko:white_check_mark: ashvayka:x: d2eightYou have signed the CLA already but the status is still pending? Let us recheck it.


spec: remove facet ref from core

Problem
There are $ref: facets/... references in core OpenLineage.json. This breaks compatibility with JSON Schema specification.
Solution
Remove references from core OpenLineage.json. Add spec tests.
One-line summary:
Remove references to facets in core spec.
Checklist

[x] You've signed-off your work
[x] Your pull request title follows our guidelines
[x] Your changes are accompanied by tests (if relevant)
[x] Your change contains a small diff and is self-contained
[ ] You've updated any relevant documentation (if relevant)
[x] Your comment includes a one-liner for the changelog about the specific purpose of the change (if necessary)
[x] You've versioned the core OpenLineage model or facets according to SchemaVer (if relevant)
[x] You've added a header to source files (if relevant)

SPDX-License-Identifier: Apache-2.0
Copyright 2018-2023 contributors to the OpenLineage project

Files with _after prefix are the ones generated with changes in this PR:
$ diff src/main/java/io/openlineage/client/OpenLineage.java src/main/java/io/openlineage/client/OpenLineage_after.java
875c875
<       this.schemaURL = URI.create("https://openlineage.io/spec/2-0-1/OpenLineage.json#/$defs/RunEvent");
---
>       this.schemaURL = URI.create("https://openlineage.io/spec/2-0-2/OpenLineage.json#/$defs/RunEvent");
1947c1947
<       this._schemaURL = URI.create("https://openlineage.io/spec/2-0-1/OpenLineage.json#/$defs/RunFacet");
---
>       this._schemaURL = URI.create("https://openlineage.io/spec/2-0-2/OpenLineage.json#/$defs/RunFacet");
2096c2096
<       this._schemaURL = URI.create("https://openlineage.io/spec/2-0-1/OpenLineage.json#/$defs/InputDatasetFacet");
---
>       this._schemaURL = URI.create("https://openlineage.io/spec/2-0-2/OpenLineage.json#/$defs/InputDatasetFacet");
2184c2184
<       this.schemaURL = URI.create("https://openlineage.io/spec/2-0-1/OpenLineage.json#/$defs/JobEvent");
---
>       this.schemaURL = URI.create("https://openlineage.io/spec/2-0-2/OpenLineage.json#/$defs/JobEvent");
3392c3392
<       this._schemaURL = URI.create("https://openlineage.io/spec/2-0-1/OpenLineage.json#/$defs/DatasetFacet");
---
>       this._schemaURL = URI.create("https://openlineage.io/spec/2-0-2/OpenLineage.json#/$defs/DatasetFacet");
4398c4398
<       this._schemaURL = URI.create("https://openlineage.io/spec/2-0-1/OpenLineage.json#/$defs/JobFacet");
---
>       this._schemaURL = URI.create("https://openlineage.io/spec/2-0-2/OpenLineage.json#/$defs/JobFacet");
5509c5509
<       this.schemaURL = URI.create("https://openlineage.io/spec/2-0-1/OpenLineage.json#/$defs/DatasetEvent");
---
>       this.schemaURL = URI.create("https://openlineage.io/spec/2-0-2/OpenLineage.json#/$defs/DatasetEvent");
6365c6365
<       this._schemaURL = URI.create("https://openlineage.io/spec/2-0-1/OpenLineage.json#/$defs/OutputDatasetFacet");
---
>       this._schemaURL = URI.create("https://openlineage.io/spec/2-0-2/OpenLineage.json#/$defs/OutputDatasetFacet");

$ diff src/main/java/io/openlineage/server/OpenLineage.java src/main/java/io/openlineage/server/OpenLineage_after.java produces no differences.


Support for Windows platform

I'm not sure if this is even possible, but it would nice if this supported Windows platform.  I know that Cordova for Windows is simply a wrapper for WinJS, so it would probably depend upon whether or not WinJS allows overriding URI remap and file IO handling.

Sorry, I have no plan to support for Windows at the moment.
welcome pull requests.

Windows support would be much appreciated :+1:


fix(test): update region names

#223  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @NathanFlurry and the rest of your teammates on  Graphite


[Event Request] - OnBeforeUpdUnPrice in Table 111 "Sales Shipment Line"

Hello, please consider adding the following event to Table 111 "Sales Shipment Line"
    [IntegrationEvent(false, false)]
    local procedure OnAfterGetSalesOrderHeader(var SalesOrderHeader: Record "Sales Header"; var SalesInvHeader: Record "Sales Header")
    begin
    end;

and raise it accordingly inside "InsertInvLineFromShptLine" procedure:
...
...
        TransferOldExtLines.ClearLineNumbers;

        repeat
            ExtTextLine := (TransferOldExtLines.GetNewLineNumber("Attached to Line No.") <> 0);

            if (Type <> Type::" ") and SalesOrderLine.Get(SalesOrderLine."Document Type"::Order, "Order No.", "Order Line No.")
            then begin
                if (SalesOrderHeader."Document Type" <> SalesOrderLine."Document Type"::Order) or
                   (SalesOrderHeader."No." <> SalesOrderLine."Document No.")
                then
                    SalesOrderHeader.Get(SalesOrderLine."Document Type"::Order, "Order No.");

                **OnAfterGetSalesOrderHeader(SalesOrderHeader, SalesInvHeader);**

                PrepaymentMgt.TestSalesOrderLineForGetShptLines(SalesOrderLine);
                InitCurrency("Currency Code");

                if SalesInvHeader."Prices Including VAT" then begin
                    if not SalesOrderHeader."Prices Including VAT" then
                        SalesOrderLine."Unit Price" :=
                          Round(
                            SalesOrderLine."Unit Price" * (1 + SalesOrderLine."VAT %" / 100),
                            Currency."Unit-Amount Rounding Precision");
                end else begin
                    if SalesOrderHeader."Prices Including VAT" then
                        SalesOrderLine."Unit Price" :=
                          Round(
                            SalesOrderLine."Unit Price" / (1 + SalesOrderLine."VAT %" / 100),
                            Currency."Unit-Amount Rounding Precision");
                end;
...
...

Thank you!

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 49390.


flakey npd tests in sig-node ci jobs

I've documented at k/k repo before realizing this has it's own repo. Maybe you can help me debug?
https://github.com/kubernetes/kubernetes/issues/94493
Are these tests supposed to be running outside of the ci-npd jobs?
Do they need to be ignored?
Is there some special setup that is done?
Should they be marked [serial] or [disruptive]?

these tests might be added as NPD runs as a default on kubernetes. I will try to debug the issue. I dont think there is any special setup done here.

@vteratipally can you comment on why serial is needed? What tests do that wouldn't run in parellel? Can the un-parallellable resources be named somehow to separate tests?

Yes can we can try to separate the tests to parallelable resource because I believe that these tests are based on the event logs. I can give it a try

CC: @ForestCold and @vteratipally FYI


chore: adding basic example of usage in raw scenario + moving integration tests

Instead of having single e2e test suite, that limits to one electron configuration, I have added examples directory, that will hosts multiple different usage scenarios (and integrations with external libs). On top of it, it will run integration suite on all the examples, so it will be easier to spot any potential integration mistakes, especially when dealing with middleware config

:tada: This PR is included in version 2.0.0-alpha.9 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


feat(v2): better docs metadata

Motivation
This PR is an attempt to make our docs data structure to be more efficient while achieving the same functionality. This should solve scalability problem #1782

Delete useless metadata
Colocate related metadata better
Previously, we have something called docsMetadata that contains all the metadata of all docs pages. It is used as a lookup table for certain doc page to convert id into its corresponding metadata like title and permalink. This poses a huge problem because as the number of docs grow bigger, the client bundle size will increase linearly.

Current docu v2 docs for example, the docsMetadata itself is alrd ~15kb

With this PR, the docsMetadata is just ~2kb

In fact, this PR makes our build time much faster and consume less memory as well
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan

Website prev and next button is working properly
The docs sidebar is still working like previously
Changed test passes

that's why I added legacy to the name. Do you think that approach is necessary?
i think it will be hard to maintain two plugins with different component

see whether we can improve the sidebar with this also.
actually the sidebar has been improved also. instead of doing the lookup table client side, we do it server side (at build time) instead. The sidebar component will only receive a very-easy-to-digest props

i think it will be hard to maintain two plugins with different component

I don't intend to maintain the legacy one, just keep it there. But I guess we could just move things now. Only users who swizzled the doc components need to re-implement their doc components because the data structure has changed. No that many people swizzled I think.

actually the sidebar has been improved also.

Ah I meant the React component, to collapse categories if the page is not active, expand when item is active. I could tackle this later :)

Ah I meant the React component, to collapse categories if the page is not active, expand when item is active. I could tackle this later :)

Sure thing. To find current page you might want to pass location props to the sidebar as well.
https://github.com/facebook/docusaurus/blob/e7ba8af6d9e83b89f967acaa53a218a8efdfa31d/packages/docusaurus-theme-classic/src/theme/DocLegacyPage/index.js#L27
- <DocLegacySidebar docsSidebars={docsSidebars} sidebar={sidebar} />
+ <DocLegacySidebar location={location} docsSidebars={docsSidebars} sidebar={sidebar} />

The sidebar content data structure will look like this. It's only either category or link type
[
      {
        "type": "category",
        "label": "Guides",
        "items": [
          {
            "type": "link",
            "label": "Creating Pages",
            "href": "/docs/creating-pages"
          },
          {
            "type": "link",
            "label": "Styling and Layout",
            "href": "/docs/styling-layout"
          },
          {
            "type": "category",
            "label": "Docs",
            "items": [
              {
                "type": "link",
                "label": "Markdown Features",
                "href": "/docs/markdown-features"
              },
              {
                "type": "link",
                "label": "Sidebar",
                "href": "/docs/sidebar"
              }
            ]
          },
          {
            "type": "link",
            "label": "Blog",
            "href": "/docs/blog"
          },
          {
            "type": "link",
            "label": "Analytics",
            "href": "/docs/analytics"
          }
        ]
      }
    ]

I'm working on it now, have a PR almost up!


secretName is undocumented

How does it work? It's documented that is can be used https://www.jaegertracing.io/docs/1.14/operator/#secrets-support but not what its intent is: to provide a key-value pair for username-password, or to provide ENV vars that gets fed the container?

The secret support is generic can have many purposes. One of them could be to host the certs required to enable TLS in different components, like when acting as a client to an Elasticsearch cluster, or the certs to use as a server on gRPC ports. Then, you can combine the secret with volumes/volume mounts to have them available as local files in the container, and pass this path as a CLI parameter to the component.
This example shows how volumes can be combined with the configuration of a component (badger, in this case): https://github.com/jaegertracing/jaeger-operator/blob/master/deploy/examples/with-badger-and-volume.yaml .
But I agree with you: we need to better document how the secret should look like for concrete use cases.
Cases that we could document:

[ ] Certs to use in the gRPC listeners
[ ] Client certs to use as Elasticsearch client

The first one (gRPC) is an easy one, so, I'm tagging this as "good first issue". The second one (Elasticsearch client) is a bit harder and involves understanding the following code:
https://github.com/jaegertracing/jaeger-operator/blob/master/scripts/cert_generation.sh
https://github.com/jaegertracing/jaeger-operator/blob/master/pkg/storage/elasticsearch_secrets.go

It's not just storage in one component that gets affected; it's the:

elasticsearch client in collector
elasticsearch index cleaner
elasticsearch spark_dependencies/k8s Job

And one more case:

[ ] ES_PASSWORD and ES_USERNAME: this is especially relevant since the elasticsearch operator by default sets the elastic user with an auto-generated password; only for demos would it make sense to have this operator deploy an ES cluster (IMO)

ES documentation already contains explanation that secret can be used for user password.
The secret docs could explain that values are passed as ENV variables that jaeger can consume.


add generate-package-code

Codecov Report

Merging #167 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
+ Coverage   76.53%   76.57%   +0.03%
==========================================
  Files          40       40
  Lines        2779     2783       +4
==========================================
+ Hits         2127     2131       +4
  Misses        521      521
  Partials      131      131

Impacted Files
Coverage Δ

packages/bytes.go
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f3628d...fa5a8ff. Read the comment docs.

At present, we only take bytes as an example of pr. If you think ok, I will add other packages.

If I understand correctly, you want to add an example how to use package?
If so, I think it should be done similar to this:
https://github.com/mattn/anko/blob/master/vm/exampleBasicOperators_test.go
I will do one for sort soon.

No, I mean maybe these standard packages can be done by generating code, because each package may have updates, and it is considered difficult to detect and update the code.
Then I just give the generated code and use bytes as the sample code. If I can, I will use the code to generate the code under the wrong package.

I now see what this is doing, very cool. The concept is great. :)
I am not sure if it will work in all cases. In particular, packages that have new methods adding to them, like sort as an example. There is a sort 1.8 build. Also note that some packages have appengine build constraints/tags.
It should at least be able to use as a good starting template for checking what we have or adding new packages.

It is difficult to create a portable package file using this tool. Because syscall has different methods depending on OS. So I think that it must have a dictionary or whitelist.

can use makefile to make only specific packages use the generated code

Might be better for how it is now to remove the makefile and just run it manually as wanted. Great tool, can do lots with it, just not full automatic.

@Chyroc
Could you please fix bytes?

I have resolved the conflict, but there are still some problems.
Columns such as
	json.Number // type Number string
	time.Nanosecond // const Nanosecond  Duration = 1

are a type or a var, but they are not structs, so they cannot use AAA{}. At the moment I have added them to the blacklist, but I don't think this is a good way. Maybe we should support this type, but what should we do?

time.Nanosecond is already added:
https://github.com/mattn/anko/blob/master/packages/time.go

I think something like this will work:
PackageTypes["encoding/json"] = map[string]interface{}{
"Number": json.Number(""),
}
Also can check out Signal:
https://github.com/mattn/anko/blob/master/packages/os.go

Note that the build tests are failing because json.Valid was not added until go 1.9

I have a problem: The type of import is now through:
1, bytes.Buffer{} imported in this way,
2, the type of non-structure is imported in this way
var signal os.Signal
reflect.TypeOf(&signal).Elem()

Whether to continue this way, or unified as the second way

interface can be nil. For example, This is typed nil.
v := io.Writer(nil)

A note, I think this code should try to handle all the cases. This code is great for generating a template that can be updated by hand.

how to deal with math.MaxUint64, it return constant<PHONE_NUMBER>3709551615 overflows int in my machine

Should be able to just convert it to a uint64.
https://github.com/golang/go/issues/19621
https://github.com/golang/go/issues/23086

Have you read up on Build Constraints?
https://golang.org/pkg/go/build/
Looks like there are extra Build Constraints that are not wanted.
For example:
// +build go1.8,!go1.10
Which means build if (1.8 or greater) OR (not 1.10 or great), which probably not what we are going for.

Also there is the custom build tag appengine which I believe is used to create the engine for the web site. So // +build !appengine needs to be accounted for.

Yes, I read ~
The comma means and and the space means or, so the // +build go1.8,!go1.10 meaning here is 1.8 and above, but does not include 1.10
For example, the function init_math:
// +build go1.8,!go1.10 will build under 1.8/1.9 in file packages/math.18.go
// +build go1.10 will build under 1.10 in file packages/math.110.go
and they called by file packages/math.go
Take the function init_encoding_json for example:
// +build go1.8,!go1.9,!go1.10 will build under 1.8 in file packages/encoding.json.18.go
// +build go1.9 go1.10 will build under 1.9/1.10 in file packages/encoding.json.19.110.go
and they called by file packages/encoding.json.go

Also, how are you checking what version each of the newly adding functions and types are in?

Looking at json.Valid, that should be // +build go1.9 and the other file should be // +build !go1.9.

Maybe we can run ./cmd/generate-std-packages/run.sh in the ci test. If there is a change in the code, there is a new file, and ci should fail.
Of course, it can also be performed manually on a regular basis (so as not to block other people's pr)

While we are only testing 1.8, 1.9, 1.10 in travis, still want to try to be compatible to lower versions when/if possible. That means trying to figure out which version functions and types were added, for all the newly added functions and types.

Note https://github.com/mattn/anko/issues/49 for overflows int issue.

Should we first create maps of all packages and then add functions or variables one by one.
then add
l.Lock()
if Packages["name"] = nil {
Packages["name"]  = make(map[string]interface{})
}
l.Unlock()

This avoids the need to create two file builds similar to the appengine environment

We are adding functions or variables one at a time, don't think a lock is needed. Not seeing how this avoids the need for build files.
If you want to have only have two appengine build files, can have those file sets a flag, then use that flag to set the data.

run such code to generate code:
#!/bin/bash

mkdir go && cd go

for i in 1.6.4 1.7.6 1.8.7 1.9.6 1.10.3
do
   echo "download go $i ing."
   wget https://dl.google.com/go/go$i.linux-amd64.tar.gz && tar zxvf go$i.linux-amd64.tar.gz && mv go $i
   rm go$i.linux-amd64.tar.gz
   echo "done."
done

cd ..

find packages | grep -vE '_test|Engine' | grep '/' | xargs rm

go run cmd/generate-std-packages/*.go -go16 ./go/1.6.4/bin/go -go17 ./go/1.7.6/bin/go -go18 ./go/1.8.7/bin/go -go19 ./go/1.9.6/bin/go -go110 ./1.10.3/bin/go && gofmt -s -w ./packages/*

@MichaelS11 @mattn please see again, thank you.

I leave this to @mattn
I was fine with the simple starting template and making changes by hand.

I don't have strong opnion, Is it possible to make composite literal like?
Packages["bytes"] = map[string]interface{}{
   ...
}

should i add // Code generated by cmd/generate-std-packages. DO NOT EDIT. on the head of file


Could the code train now without convergence ?

I found adding the cross attention module would make the training become unstable. The G loss raised to NaN.

Now I'm trying unconditional generation with self-attention.

或许我们可以加个联系方式讨论一下？

不好意思，假期没看git，有啥好的想法直接在issue里讨论吧，这样大家都可以看到😃


Improve/standardize rate limiting logic in Monitor

This PR uses Guavas Suppliers.memoizeWithExpiration() for caching, replacing the manual caching logic. This allows us to:

Remove synchronized from the get methods since Suppliers.memoizeWithExpiration() is thread safe
Remove the class-level maps that were previously being used for caching. Now, the fetch() methods that update the data, directly return the data instead of using these maps. These fetch() methods are called directly from the suppliers now.
Remove the age-off logic that was being done in the fetch() methods. It should be noted that the functionality has slightly changed. Since we just re-create a new map whenever the data is refreshed in the fetch() methods, there are no old values that need to be aged off.

Remove the age-off logic that was being done in the fetch() methods. It should be noted that the functionality has slightly changed. Since we just re-create a new map whenever the data is refreshed in the fetch() methods, there are no old values that need to be aged off.

That is a nice simplification.

Yea definitely nice to be able to remove some code. Wasn't sure if this would be an issue though since before, the maps would contain values that would only be aged off after they were 15 minutes old. And now, since the data is recreated once every minute, all of the returned data will only ever be that old. Not too sure what the implications of this are or what the old values were being used for.

Wasn't sure if this would be an issue though since before, the maps would contain values that would only be aged off after they were 15 minutes old.

I misread that code when I was reviewing.  I thought they were aging off after 15 milliseconds, so did not think it was an issue. But its actually 15 minutes. It would be good to understand that change in behavior a bit better.  So it seems like some things used to hang around for 15 minutes in the monitor display even after they were gone?

So it seems like some things used to hang around for 15 minutes in the monitor display even after they were gone?

Yea, so after looking at the code a bit more I think that the purpose of the age-off logic was to remove entries whose server was no longer present. The code that collects this data iterates through each server returned from context.instanceOperations().getTabletServers() and uses the HostAndPort of that server as the key in the map. So if there is new data for that server, the old data will just be replaced, but in the case where there is some data for a server and then that server dies, then it will not be replaced by anything. So after 15 mins, if the server did not come back up, those entries will be aged off. It seems like we want to keep this functionality so I'm going to work on adding this age-off functionality back.

@DomGarguilo for these these dead servers that hang around in the monitor for 15mins, do you know if their last contact time continues to increase in monitor display?

@DomGarguilo for these these dead servers that hang around in the monitor for 15mins, do you know if their last contact time continues to increase in monitor display?

Okay so i was a bit mistaken. The info for servers that have dies did stick around in the map and then it depends on what the calling code does with it. For example, ScansResource sets up the rest endpoint for scans and it filters the data to only return scans from tservers that are alive, where as for scan server scans, it will return all of the data in the map. This means that if a scan server dies, as long as the 15 min age-off window has not passed, scans that were running on that scan server will still be displayed. This is just one example of how this potentially stale data is used in the monitor. I am taking a look at the other usages of this data that is kept around. I am not sure why we want to keep this data around on the monitor for scan servers but not for tservers.

Regarding my previous comment:
I looked into the other spots where data was being pulled from these maps in the Monitor code (tserverScans, sserverScans, and allCompactions). Unless I am missing something, the only one that seems to use this stale data before it is aged off is the scan servers scenario outlined above. This leads me to believe that we might not need to keep this age off functionality unless it is deemed necessary for the scan server scans info.


Documentation and some usability tweaks to the new subscriptions model

Got hosed with testing project renames:( I put in a separate PR


Fix issue #8 - incorrect build order for install

When installing to a custom prefix, use make clean install PREFIX=/...
rather than make && make install PREFIX=/... as the latter will not
correctly replace PREFIX in i3lock-next-helper.c. This commit adds
to Makefile so that it correctly builds when installing to a custom
PREFIX.
ie. The install rule now depends on $(TARGET) and i3lock-next will be
built correctly by using make clean install.

Won't this build as root if the user runs make install as root?

Umm... Yes, actually. I didn't consider that. Oops.
A simple but hacky solution for this would be to prefix every install in the include rule of the Makefile with sudo:
install: all
    @echo Stripping unneeded symbols from binary
    @strip --strip-unneeded $(BIN_DIR)/$(TARGET)
    @sudo install -m 755 -d $(DESTDIR)$(PREFIX)/bin
    @sudo install -m 755 -d $(DESTDIR)$(LIBEXECDIR)/$(SCRIPT)
    @sudo install -m 755 -d $(DESTDIR)$(DATAROOTDIR)/$(SCRIPT)
    @echo Installing script, binary, and data
    @sudo install -m 755 scripts/$(SCRIPT) $(DESTDIR)$(PREFIX)/bin/$(SCRIPT)
    @sudo install -m 755 $(BIN_DIR)/$(TARGET) $(DESTDIR)$(LIBEXECDIR)/$(SCRIPT)/$(TARGET)
    @sudo install -m 644 data/* $(DESTDIR)$(DATAROOTDIR)/$(SCRIPT)/
    @echo Replacing PREFIX in i3lock-next script
    sudo sed -i 's_PREFIX=/usr/local_PREFIX=\$(PREFIX)_' $(DESTDIR)$(PREFIX)/bin/$(SCRIPT)
    @echo Install to $(DESTDIR)$(PREFIX) complete

As I understand, the user will only be prompted to enter their password once in this process.

I don't see this as a viable long-term solution, if you have any more contributions feel free to raise an issue or another pull request.


Will the paging algorithm breach a full query on all resources?

Here's the code copied for Example #1 of an optimized grouping approach:
When subscriptionId.Count is divisible by groupSize, will the last iteration leads to currSubscriptionGroup be null, and query all available subscriptions for the credential?
// RECOMMENDED
var header = /* your request header */
var subscriptionIds = /* A big list of subscriptionIds */

const int groupSize = 100;
for (var i = 0; i <= subscriptionIds.Count / groupSize; ++i)
{
    var currSubscriptionGroup = subscriptionIds.Skip(i * groupSize).Take(groupSize).ToList();
    var userQueryRequest = new QueryRequest(
        subscriptions: currSubscriptionGroup,
        query: "Resources | project name, type");

    var azureOperationResponse = await this.resourceGraphClient
        .ResourcesWithHttpMessagesAsync(userQueryRequest, header)
        .ConfigureAwait(false);

  // ...
}

For example, groupSize = 100, itemCount = 100, subscriptoinIds.Count / groupSize = 1;
Iteration 0: will query subscription ids indexed 0 to 99 (100 items);
Iteration 1: subscriptionIds.Skip(100).Take(100).ToList() => List.Empty <=== Will this cause returning resources?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1d581716-3b0e-fe98-411c-4c68adc86f82
Version Independent ID: 608549b3-64dc-162a-9853-0ad766fa1ca7
Content: Guidance for throttled requests - Azure Resource Graph
Content Source: articles/governance/resource-graph/concepts/guidance-for-throttled-requests.md
Service: resource-graph
GitHub Login: @timwarner-msft
Microsoft Alias: timwarner

Thanks for the feedback! We are currently investigating and will update you shortly.

@timwarner-msft  Can you please provide your insights on this issue?

@xiaomi7732 I'm still waiting to hear back from an engineering team member. Thanks, Tim

Unfortunately your issue wasn't reviewed in a timely manner. I'm closing this issue, but if you feel that it's still a concern, please post a comment or submit a new issue.
#please-close


Qingwei/min candlestick

Coverage decreased (-0.1%) to 40.362% when pulling 789929a695ea4d614b7635aa90b0e09fbe80a8ba on qingweibinary:qingwei/min_candlestick into 044207d7f2e04b86f440ef6b01c7da7779a15fba on binary-com:master.


Fix formatting bug in CLI output

The supported barcode types weren't output on invalid type due to broken conversion from % formatting to .format()

Fix is up @dlenski :)

And version 1.4.1 is out with it: https://pypi.org/project/treepoem/


Can't use multilingual search with english and french

I'm french and I saw the "multilingual search" option, so I wanted to be able to search items in French while still having the game in English. I can't move English to the top bcs his position is locked. Then, I tried to enable French language and did shift + F3 + J to switch language but when language switch, French language is disabled so I can't search in French.
Do you have a solution ? Ty :)
(Sry I'm french and I don't have a very good english :/ )

Move English (United Kingdom) or any other English above French.

Ty :)


Update banner image

The banner image is outdated by now, it still shows "pre-alpha".

We can either design a complete new one or just try to cut out the note. Anybody can think of a good way to synchronize it automatically with the main project? @Cervator @rzats @msteiger

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/38592141-update-banner-image?utm_campaign=plugin&utm_content=tracker%2F715506&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F715506&utm_medium=issues&utm_source=github).

Just noticed this myself while watching https://www.youtube.com/watch?v=2F_bQVBazi8 and found this issue :-)
I would just cut out the "Pre-Alpha" entirely. Really the launcher should only care about the launcher which has long since been released properly. You can pick different game release types via the drop-downs anyway.

Here. I designed a simple template of the banner you were talking about in case you do make a new one. You can add the logo to it if you want. Also, I put the version number on it, but put it so that it would be easy to remove or change.

Hi @MrFireAlarm and thanks for banner - it doesn't really fit in with any of our existing styles or colors though. I'm not opposed to changing the logo beyond just chopping off the version tag but it should probably be closer to the existing version in that case :-)
We could use some volunteers helping with overall look-and-feel with logos, banners, and so on overall, but in the meantime and for smaller stuff probably easier just to do the minimal changes. If we do any big overall change it would need to applied in most/all places at once (game, launcher, crash reporter, forum, splash site, social networks, wikis, etc)

OK, I see. I would be happy to help with design whenever you need said volunteers. Also, question: I've seen the voxel demos in GitHub, but is this game available online, or do you need to download it?

Voxel demos? Terasology is a downloadable game you can play in multiplayer, if that helps. There isn't an in-browser version since Oracle discontinued Java Applets.

Oh, Oracle is causing me pain. (I'm on a Chromebook)

I am still seeing the old banner image also when loading the launcher.

Will

@WH1CRT: hi! This particular issue is still not fixed (though there are several pending designs for the logo).


Unwrap deploy_ceph call()

Reverts https://github.com/fusor/mig-ci/commit/a02d74999e20bbaac0056929879addf50df370cc "CEPH=false, Cannot invoke method call() on null object"
Addressed in https://github.com/fusor/mig-ci/pull/129

Closing PR because its addressed in #129 after rebase with https://github.com/fusor/mig-ci/pull/129/commits/f4570c7733fe8845a364af9e79fc0d20a19839d0


USHIFT-2391: remove FDO scenario

The original intent of the scenario was to test going from a base
image without MicroShift to an image that failed to come up, roll back
to the original image, then upgrade again to an image that worked. The
test was ensuring that MicroShift deleted the database during that
second upgrade so that any corrupt data would not cause an issue with
the new rollout. We subsequently removed that behavior, and updated
the FDO scenario so that it deploys 2 images that both fail. We don't
consider that a useful scenario.
/assign @pmtk

/retest-required


ROI issues

Various issues/suggestions:

[x] Don't see a need to have circles and hexagons as options
[x] The typical selection size of the rectangle would encompass the whole spectrum vertically. It would be nice to have this as the default when you select a rectangle.
[x] I'm finding the three handles on the ROI boxes rather clunky to use. Would prefer to have handles on the corners if that's an option.

Check out the latest master and let me know how you feel about the changes.


[Feature Request] Light Mode

Since there are those (myself included) that find light mode easier on the eyes, this would be a welcome addition.
A slight off-white would be a good option for those that also find the default material design you light mode blinding.

Arru has light theme, but it only looks at device configuration, defaulting to dark theme on devices that don't support it
So I added an in-app theme switching as part of #18
I don't really use light theme, anywhere really, so it was a bit of an afterthought till now
#18 tries to improve it somewhat, but I don't really feel like it's good
Feedback would be appreciated

Thanks, I'll make sure to test it out and leave feedback once the next version is released.
That is certainly understandable.

I have tested the new version, and it is working well.
I have a few other things that are preventing me from using the app (like support for multiple currencies), however those shall be addressed via separate issues.
Regardless, thank you very much, you are doing a great job.


fix: add angular validation

Before (the change)
After (the change)

[x] I have read and followed the setup steps
[x] I have created necessary unit tests
[x] I have tested the functionality in Angular.

Steps needed to test

:tada: This PR is included in version 3.0.0-alpha.8 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 3.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 5.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.27.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.17.0-alpha.111 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 5.0.0-alpha.10 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Source code for Demo

Where is source code for https://adminjs-demo.herokuapp.com/admin ?

https://github.com/SoftwareBrothers/adminjs-example-app


[BUG] Old issue (#870) hasn't been fixed

Context

ElasticDump version: 6.82.2
Elasticsearch version: 8.1.1
Node.js version: v14.17.6

Describe the bug
I raised this issue. Then I update ElasticDump version to 6.82.2 and test again, but that issue hasn't been fixed. I have same output when running command.
I checked your commit. I think that encodeURIComponent function return a string: 'undefined'. So 'undefined' || '_doc' still equal 'undefined'.
Please check this issue again. Thank you.

It should actually be undefined, not 'undefined'. I'll have a look, apologies.

Sorry about, in a rush to resolve the issue, I mixed up the bracket matching. Thanks for testing this, will be adding tests for this in the future. Thanks again and my apologies
6.82.3

Thank you. After updating with version 6.82.3, my issue has been fixed. Now I can use --delete flag.
And I want to notice about another small issue. To use a specific query with multielasticdump, we must use --searchBody flag. But in README.md file, you wrote '--searchbody`. I think that you need edit that file.

Thanks for the update

https://github.com/elasticsearch-dump/elasticsearch-dump/commit/ad925be8dc7281e731acb1314ac3d0d17f128c95 doc updated


Set encoding to utf-8

Closes #1
On windows, the default encoding is not utf-8 which causes the read_text to fail.

Added to pavelzw/pythonji-2 since this is apparently not maintained anymore.


Unclear meaning of toggle

This is more of a question rather than feature request. What is the meaning of the toggle between the API_LOCAL call name and the require entity name? It seems to change the entity text into "$QuoteItem". Is this the equivalent of the cosmetic LUIS toggle between entity/token view or something else?

Correct, it's simply a visualization convenience to toggle the view between showing the Entity names and substituted Entity values.   It has not impact on training.


merge with BEWELCOME

I don't understand why couchers exists, when BeWelcome.org was created due to couchsurfing.com commercialization and was an opensource replacement?
Why create Couchers when BeWelcome exists? Why not join your efforts together and make BeWelcome a better replacement rather than reinventing the wheel and taking "surfers" from the other site?
Work together, not separate.

Hi @dimensionc132, welcome to Couchers.
This topic is better suited for the community forum, and there are already some discussions on it there:
https://community.couchers.org/search?q=bewelcome


update wsk api docs remove experimental

Thanks @akrabat for the comments, I will address them.

Looks much better 😀

LGTM :+1:

I should have read @akrabat's feedback first :D

@rabbah thank you chief editor on shift for the review

@rabbah please re-review


The latest filter could not be loaded due to image cache

I found there is no delete command  on the webassemblyhub.io website，so  I don't want to change tags to generate a bunch of junk. Then I always use the same tag to push image  to the webassemblyhub.io, this ok, it can overwrite the old image.
But when I deploy it, I found wasme use the old cache by ref key. And wasme not update the cache.
here
func (c *CacheImpl) Add(ctx context.Context, ref string) (digest.Digest, error) {
	if img := c.cacheState.findImage(ref); img != nil {
		desc, err := img.Descriptor()
		if err != nil {
			return "", err
		}
		return desc.Digest, nil
	}
//....
}

try to clear cache, but it doesn't success
kubectl  exec  wasme-operator-5b7788d9bb-2wb27   -n wasme -- /usr/local/bin/wasme cache  webassemblyhub.io/kowalski/modify-body:v0.3  --clear-cache=true --port=0

so I must delete the configmap and wasme-cache pod to update cache.
This is unreasonable， because you can't stop the user from updating the image with same tag.
How to solve this？

good question - we are updating the caching mechanism and will see how to best address cache updates; the problem is that you do want to cache the tags in most cases, so we will have to think on how best to accomplish this


Rootless network

https://github.com/containers/podman/issues/2488#issuecomment-468429239
https://wiki.opennms.org/wiki/ICMP
Podman - Networking 3/3
echo 0 9999999 > /proc/sys/net/ipv4/ping_group_range from https://github.com/landley/toybox/issues/111#issuecomment-599267495
https://github.com/containers/common/blob/main/docs/containers.conf.5.md#network-table

podman run -it --rm busybox /bin/sh -c 'ping -c 5 google.com'

I'm running on Arch Linux WSL-2, id shows:
uid=1000(mwoodpatrick) gid=1000(mwoodpatrick)
I am able to ping localhost, dns.google.com without issue.
 cat /proc/sys/net/ipv4/ping_group_range
shows
0       2000000
but when I run:
podman run -it --rm busybox /bin/sh -c 'ping -c 5 google.com'
I get:
PING google.com (<IP_ADDRESS>): 56 data bytes
ping: permission denied (are you root?)

What do I need to do to get this to work?

Totally missed your comment here @mwoodpatrick sorry for that, not so used to track github notifications.
The problem is that it misses the capability CAP_NET_RAW.
podman run busybox sh -c 'ping -c 3 <IP_ADDRESS>'

Outputs:
PING <IP_ADDRESS> (<IP_ADDRESS>): 56 data bytes
ping: permission denied (are you root?)

So it was broken for me too. Probably this was just saved as a way to trigger this error.
Adding the required capability:
podman run --cap-add CAP_NET_RAW busybox sh -c 'ping -c 3 <IP_ADDRESS>'

Outputs:
PING <IP_ADDRESS> (<IP_ADDRESS>): 56 data bytes
64 bytes from <IP_ADDRESS>: seq=0 ttl=255 time=62.911 ms
64 bytes from <IP_ADDRESS>: seq=1 ttl=255 time=66.129 ms
64 bytes from <IP_ADDRESS>: seq=2 ttl=255 time=64.300 ms

--- <IP_ADDRESS> ping statistics ---
3 packets transmitted, 3 packets received, 0% packet loss
round-trip min/avg/max = 62.911/64.446/66.129 ms

Note: change it from google.com to <IP_ADDRESS> because it "works" the same even without internet, I mean the initial permission denied error is replicable even if internet is turned off.


Asdk24 patch 3

Why:
Closes [issue link]
What's being changed:

Check off the following:

[ ] For workflow changes, I have verified the Actions workflows function as expected.
[ ] For content changes, I have reviккewed the style guide.
No

Аавв

Кава

Мавар

good

good


Manual Deployment of Web Part Browser Access #33

Hi,
Due to complex SharePoint Online architecture at a customer we have deployment the Web Part using the manual process. This works perfectly fine but we are seeing the following behavior on different browsers, it is always worth noting that the App Catalog resides on one site collection with a vanity domain and the sites reside on another site with a different vanity domain so the automated deployment was not possible:
IE 11 (aware this is not really compatible) - able to access the web part but no media
Chrome (the browser of choice for the customer) - this errors with a message "Failed to load the componen (AppCatalogURLfor thewebpart) Original Error: Failed to load URL. There was a network problem. This may be a problem with a HTTPS certificate. Make sure you have the right certificate"
New Edge - Works fine throughout for one person only; not other
I am focused on this being a client setting, possibly policy or proxy related. Just need confirmation that you have not seen this before or there is nothing else I should be thinking about here.

Yes, we are aware of this limitation for support of vanity domains unless the app catalog and the sites that it served in are in the same vanity URL. This is a limitation of the SharePoint Framework and not of learning pathways itself.

Thanks Julie- are you aware of any workarounds?

The only workaround I'm aware of, but have no personally tested, is turning on the Public CDN, which then puts the code that needs to be loading into the page in a publicly accessible URL thereby avoiding the security issue.
https://docs.microsoft.com/en-us/microsoft-365/enterprise/use-microsoft-365-cdn-with-spo?view=o365-worldwide


[VL] spark url_decode function support

What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
(Fixes: #ISSUE-ID)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

@gaoyangxiaozhu  please update your PR description following the template.

could you help re-trigger for the build fail task ?  @yma11 / @zhouyuan

cc @jackylee-ch to note this.


Disable label/text input for color controller

I wouldn't like to show the color string, which appears on the color controller. I checked in the ColorController.js and it seems that it will always add a input field for the purpose.
Is there any way to achieve the above?

I further observed the following:

If I disable myController.__input, it disables the color controller and it cannot function.
I tried to set the color of input to the same as selected color, so it is not visible to the user in onFinishChange, but onFinishChange is never called for ColorController as reported in #65.
Also, tried to set color for input in onChange as follows:
colorController.onChange(function(value) {  colorController.__input.style.color = value;  });

However, it doesn't affect the label either.
Right now, i am short of ideas for this.

I further observed the following:

If I disable myController.__input, it disables the color controller and it cannot function.
I tried to set the color of input to the same as selected color, so it is not visible to the user in onFinishChange, but onFinishChange is never called for ColorController as reported in #65.
Also, tried to set color for input in onChange as follows:

    colorController.onChange(function(value) {
        colorController.__input.style.color = value;
    });

However, it doesn't affect the label either.
Right now, i am short of ideas for this.

I wanted to hide the labels as well. After looking through dat.gui.js from the build folder... I got working :)

Replace this line-
textShadow: this.__input_textShadow + 'rgba(0,0,0,0.7)'
with this:
textShadow: this.__input_textShadow + 'rgba(0,0,0,0.0)'

Replace these two lines:
color: 'rgb(' + flip + ',' + flip + ',' + flip +')',
textShadow: this.__input_textShadow + 'rgba(' + _flip + ',' + _flip + ',' + _flip +',.7)'
with this:
color: this.__color.toString(),
textShadow: this.__input_textShadow + 'rgba(0,0,0,0.0)'

Hope this helps someone out there.

I wanted to hide the labels as well. After looking through dat.gui.js from the build folder... I got working :)

Replace this line-
textShadow: this.__input_textShadow + 'rgba(0,0,0,0.7)'
with this:
textShadow: this.__input_textShadow + 'rgba(0,0,0,0.0)'
Replace these two lines:
color: 'rgb(' + flip + ',' + flip + ',' + flip +')',
textShadow: this.__input_textShadow + 'rgba(' + _flip + ',' + _flip + ',' + _flip +',.7)'
with this:
color: this.__color.toString(),
textShadow: this.__input_textShadow + 'rgba(0,0,0,0.0)'

Hope this helps someone out there.

This almost fixed it, but I needed to tweak it a bit to get it to work:

I still replaced this line-
textShadow: this.__input_textShadow + 'rgba(0,0,0,0.7)'
with this:
textShadow: this.__input_textShadow + 'rgba(0,0,0,0.0)'

I replaced these two lines:
color: 'rgb(' + flip + ',' + flip + ',' + flip +')',
textShadow: this.__input_textShadow + 'rgba(' + _flip + ',' + _flip + ',' + _flip +',.7)'
with this instead:
color: this.__color.toHexString(),
textShadow: this.__color.toHexString()


Fails to start when have plugins ApplicationLogs or SimplePolicy

v<IP_ADDRESS> fails on startup with Unhandled Exception: System.TypeLoadException: Method 'Configure' in type 'Neo.Plugins.LogReader' from assembly 'ApplicationLogs, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' does not have an implementation.
at System.Reflection.RuntimeAssembly.GetExportedTypes(RuntimeAssembly assembly, ObjectHandleOnStack retTypes)
at System.Reflection.RuntimeAssembly.GetExportedTypes()
at Neo.Plugins.Plugin.LoadPlugins(NeoSystem system)
at Neo.Shell.MainService.OnStart(String[] args)
at Neo.Services.ConsoleServiceBase.Run(String[] args)
at Neo.Program.Main(String[] args)

Issue occurs because of different versions of neo-cli and plugins. Using the same version resolves the issue


make relevant commands say the starting seats of players

Game end notification (game start notification as well? Or is it already sorted by seat and thus trivial?)
/parse

Done for /parse but not game start/end notification


kubectl config set-cluster --certificate-authority forces relative path

What happened:
Assuming the kube config file is in the standard path %USERPROFILE%\.kube\config, using kubectl config set-cluster minikube --certificate-authority=C:\\Users\\username\\.minikube\\ca.crt will persist certificate-authority: ..\.minikube\ca.crt for the cluster in the kube config. I found an issue explaining that this was done intentionally https://github.com/kubernetes/kubernetes/issues/75552, but it breaks some kubectl functionality, namely kubectl config view --flatten run in the user's home directory produces the output:
error: open C:\Users\.minikube\ca.crt: The system cannot find the path specified.

Note that I am using minikube for simplicity with the example/repro, but this issue exists regardless of the cluster you are attempting to configure.
What you expected to happen:
kubectl config view --flatten should work and not be broken with this relative path, since it is correct relative to the .kube/config file. But in my opinion, kubectl should also not assume it knows better and change the path passed in by the user, the user may have a specific reason for supplying an absolute path and I think kubectl should just respect the input provided by the user.
How to reproduce it (as minimally and precisely as possible):
Have an existing kube cluster in your context named minikube and set as the current context.
Have a minikube ca cert available in the standard path %USERPROFILE%\.minikube\ca.crt
Manually set the certificate authority for the cluster using an absolute path:
kubectl config set-cluster minikube --certificate-authority=C:\\Users\\[username]\\.minikube\\ca.crt

Now the following command will fail because of the relative path for the certificate authority in the kube context.
kubectl config view --flatten

Environment:

Kubernetes client and server versions (use kubectl version): 1.31.0
OS (e.g: cat /etc/os-release): Windows 11 amd64

Is this only a windows issue? I see the issue that you've linked that explains the logic but it doesn't seem like that issue is quite the same as what you're experiencing. Because this was done intentionally, if this is a problem in other OS's then we will not change this behavior, but if it is just a problem for Windows we likely have a Windows specific bug we need to investigate.
Alternatively you could store the cert itself directly in the config file if that is acceptable.
/triage needs-information

Thanks for looking at this @mpuckett159
It does just seem to be a problem on Windows, I haven't tested macOS, but I just tested Linux and the absolute path to the certificate was respected and not changed to a relative path when running:
kubectl config set-cluster minikube --certificate-authority=/home/[username]/.minikube/ca.crt
For my part, I don't think it would be a good idea to decide for the user that what they meant to do was put the cert data into the kube config when the user was trying to set the path to the certificate. Like I said originally, what makes the most sense to me is to respect the instruction the user provided.

No I mean it is possible to put the cert there explicitly today if you want instead of just using the file path.
Ok since this is a windows bug I'll accept and we can work on locating the issue and fixing it.
/triage accepted

I think this might be the issue: https://github.com/kubernetes/client-go/blob/53c7e93bf282a011512dee21bf4acb71b49aca1c/tools/clientcmd/loader.go#L632
The check to know if the path would require backsteps is not cross-platform compatible.


Feat: update correct binding for KV

Summary
So I tried to implement this worker but it is not working as expected, turns out I need to do 2 things

Bind the KV namespace in Dashboard UI
Bind the KV namespace in wrangler
Access the key using binding valueexport default {
   async fetch(request, env, ctx) {
     const value = await env.NAMESPACE.get("first-key");

     if (value === null) {
       return new Response("Value not found", { status: 404 });
     }
     return new Response(value);
   },
 };

Solution

Assume the wrangler.toml binding is
[[kv_namespaces]]
binding = "YOUR_KV_NAME_SPACE"
id = "<kv-namespace-id>"

Then access the key in code via
const authKeySecret = await env.YOUR_KV_NAME_SPACE.get('AUTH_KEY_SECRET');

@thesalikkhan please tell me if this make sense and it need to be updated the code, I'll make a PR for this

Using a KV Namespace for the auth key isn't recommended since it's unencrypted. It should be stored as an encrypted env variable from the worker settings. You don't need to bind that in wrangler.toml since its already associated with the specific worker.
I made a mistake while writing the README, which is now corrected. Thank you for bringing this to my attention.


Utilize pixman for efficient pixel manipulation

According to issue #6, I replace original image compositing and trapezoid rasterization with Pixman function. Briefly, include:

pixman_image_composite: image compositing
pixman_fill_rect: use pixman_image_fill_rectangles to fill the image with retangles
pixman_image_fill_boxes: span is filled with the boxs

Close #6
We compare the results of the original method with those rewritten using the Pixman library:
(Left image: original method, and right image: Pixman method)

Hello world:

Calculator(Original):

Viewer(Original):

Multi-demo(Original):

Consider the performance test program below (apps/perf.c)
#include <assert.h>
#include <stdio.h>
#include <string.h>
#include <sys/time.h>
#include <time.h>

#include "twin.h"

#define TEST_PIX_WIDTH 1200
#define TEST_PIX_HEIGHT 800

static twin_pixmap_t *src32, *dst32;
static int twidth, theight, titers;

static void test_argb32_source_argb32(void)
{
    twin_operand_t srco = {.source_kind = TWIN_PIXMAP, .u.pixmap = src32};
    twin_composite(dst32, 0, 0, &srco, 0, 0, NULL, 0, 0, TWIN_SOURCE, twidth,
                   theight);
}

static void test_argb32_over_argb32(void)
{
    twin_operand_t srco = {.source_kind = TWIN_PIXMAP, .u.pixmap = src32};
    twin_composite(dst32, 0, 0, &srco, 0, 0, NULL, 0, 0, TWIN_OVER, twidth,
                   theight);
}

static void do_test(const char *name, void (*test)(void))
{
    struct timeval start, end;
    unsigned long long sus, eus;
    char spc[128];
    char *s;
    int i;

    printf("%s", name);

    gettimeofday(&start, NULL);
    for (i = 0; i < titers; i++)
        test();
    gettimeofday(&end, NULL);
    sus = (unsigned long long) start.tv_sec * 1000000ull + start.tv_usec;
    eus = (unsigned long long) end.tv_sec * 1000000ull + end.tv_usec;

    s = spc;
    for (i = strlen(name); i < 40; i++)
        *(s++) = ' ';
    *s = 0;
    printf("%s %f sec\n", spc, ((float) (eus - sus)) / 1000000.0);
}

#define DO_TEST(name) do_test(#name, test_##name)

static void do_tests(int width, int height, int iters)
{
    twidth = width;
    theight = height;
    titers = iters;

    DO_TEST(argb32_source_argb32);
    DO_TEST(argb32_over_argb32);
}

static void do_all_tests(const char *title)
{
    printf("[ %s: 10x10x1000000 ]\n", title);
    do_tests(10, 10, 1000000);

    printf("[ %s: 100x100x20000 ]\n", title);
    do_tests(100, 100, 20000);

    printf("[ %s: 200x200x10000 ]\n", title);
    do_tests(200, 200, 10000);

    printf("[ %s: 1200x800x200 ]\n", title);
    do_tests(1200, 800, 200);

    printf("\n");
}

int main(void)
{
    /* Create some test pixmaps */
    src32 = twin_pixmap_from_file("assets/tux.png", TWIN_ARGB32);
    assert(src32);
    dst32 = twin_pixmap_create(TWIN_ARGB32, TEST_PIX_WIDTH, TEST_PIX_HEIGHT);
    assert(dst32);

    /* fill pixmaps */
    twin_fill(dst32, 0x80112233, TWIN_SOURCE, 0, 0, TEST_PIX_WIDTH,
              TEST_PIX_HEIGHT);

    /* pre-touch data */
    test_argb32_source_argb32();

    do_all_tests("Pixmap");

    return 0;
}

Enable it by turning off the existing demo programs. (You might integrate the above into apps/main.c though.)
--- a/Makefile
+++ b/Makefile
@@ -109,7 +109,7 @@ endif
 ifeq ($(CONFIG_DEMO_APPLICATIONS), y)
 target-y += demo-$(BACKEND)
 demo-$(BACKEND)_depends-y += $(target.a-y)
-demo-$(BACKEND)_files-y = apps/main.c
+demo-$(BACKEND)_files-y = apps/perf.c
 demo-$(BACKEND)_includes-y := include
 demo-$(BACKEND)_ldflags-y := \
        $(target.a-y) \

Reference test results with the builtin compositing:
[ Pixmap: 10x10x1000000 ]
argb32_source_argb32                     0.130208 sec
argb32_over_argb32                       0.273309 sec
[ Pixmap: 100x100x20000 ]
argb32_source_argb32                     0.025439 sec
argb32_over_argb32                       0.431355 sec
[ Pixmap: 200x200x10000 ]
argb32_source_argb32                     0.087813 sec
argb32_over_argb32                       0.839746 sec
[ Pixmap: 1200x800x200 ]
argb32_source_argb32                     0.022176 sec
argb32_over_argb32                       0.395362 sec

Promote Pixman option in Kconfig:
--- a/configs/Kconfig
+++ b/configs/Kconfig
@@ -16,6 +16,18 @@ config BACKEND_SDL

 endchoice

+choice
+    prompt "Renderer Selection"
+    default RENDERER_BUILTIN
+
+config RENDERER_BUILTIN
+    bool "Built-in pixel manipulation"
+
+config RENDERER_PIXMAN
+    bool "Pixman based rendering"
+
+endchoice
+
 menu "Features"

 config LOGGING
@@ -39,10 +51,6 @@ config CURSOR
     bool "Manipulate cursor"
     default n

-config PIXMAN
-    bool "Pixman to pixel manipulation"
-    default y
-
 endmenu

 menu "Image Loaders"

Once the RENDERER_PIXMAN option is enabled, the built-in pixel manipulation code should not be compiled, and you should ensure that all rendering is done through the Pixman path.

Pixman is a low-level library for pixel manipulation, including image compositing and trapezoid rasterization. It serves as the backend for Cairo's in-memory rendering surface and is a binary dependency of Cairo. Mado can be seen as a simplified version of Cairo, and the proposed change introduces an efficient rendering path as an optional feature for faster vector graphics. The original pixel manipulation code should be retained for resource-constrained environments, with the potential for integration into the Linux kernel as an in-kernel vector graphics module.
The proposed change adds a configurable option to switch between the built-in (or classical) renderer and the Pixman-based renderer. Applications using Mado should maintain source-level compatibility. The action items for this pull request include:

Implement pixman_image_composite, pixman_fill_rect, pixman_image_fill_rectangles, etc., within Mado's internal implementation, ensuring no changes to the public API and maintaining source-level compatibility.
Develop a simple performance benchmark program to validate and measure the efficiency of pixel manipulations, enabling comparisons between the built-in and Pixman-based renderers. This task can be done in another pull request.
Ensure the conditional build system works as expected, generating the necessary renderer-specific code without unnecessary code bloat when configured.

Build failure with Clang:
src/poly.c:258:17: error: call to undeclared function '_span_fill'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
  258 |                 _span_fill(pixmap, y, x0, a->x);
      |                 ^
1 error generated.

I am experiencing rendering precision issues when switching from the built-in renderer to the Pixman-based one.

[ ] The built-in renderer

[ ] The Pixman-based renderer

As shown in the diagrams above, the splines rendered using the Pixman-based path are not as accurate as those rendered with the built-in renderer.

Evaluate the feasibility to replace the primitive operations, such as _twin_rgb16_source_argb32, _twin_argb32_over_argb32, and _twin_argb32_source_argb32, with Pixman counterpart. Eventually, the file src/primitive.c can be omitted if Pixman-based render path is selected.

https://github.com/sysprog21/mado/pull/55#issuecomment-2394969749
It results from _span_fill in pixman.c. I don't add new _span_fill method which uses pixman function.

I don't add new _span_fill method which uses pixman function.

Show preliminary benchmark results for comparison purposes.

https://github.com/sysprog21/mado/pull/55#issuecomment-2395457975

_span_fill with pixman function in /src/pixman.c

_span_fill with the builtin method in poly.c

(Notice that we test in the pixman configuration)

https://github.com/sysprog21/mado/pull/55#issuecomment-2394989348

Evaluate the feasibility to replace the primitive operations, such as , , and , with Pixman counterpart. Eventually, the file can be omitted if Pixman-based render path is selected._twin_rgb16_source_argb32``_twin_argb32_over_argb32``_twin_argb32_source_argb32``src/primitive.c

According to pixman.h, the in or over operator don't exist in public API. Because _twin_rgb16_source_argb32, _twin_argb32_over_argb32, and _twin_argb32_source_argb32 are lower-level functions, we can only call pixman_image_composite (which can replace twin_composite in draw.c) to use in or over operation.

According to pixman.h, the in or over operator don't exist in public API. Because _twin_rgb16_source_argb32, _twin_argb32_over_argb32, and _twin_argb32_source_argb32 are lower-level functions, we can only call pixman_image_composite (which can replace twin_composite in draw.c) to use in or over operation.

Can you provide preliminary benchmark results for evaluation purpose?

According to pixman.h, the in or over operator don't exist in public API. Because _twin_rgb16_source_argb32, _twin_argb32_over_argb32, and _twin_argb32_source_argb32 are lower-level functions, we can only call pixman_image_composite (which can replace twin_composite in draw.c) to use in or over operation.

Can you provide preliminary benchmark results for evaluation purpose?

The following results come from this test code:
# built-in method
[ Pixmap: 10x10x1000000 ]
argb32_source_argb32                     0.076773 sec
argb32_over_argb32                       0.130076 sec
[ Pixmap: 100x100x20000 ]
argb32_source_argb32                     0.065616 sec
argb32_over_argb32                       0.176866 sec
[ Pixmap: 200x200x10000 ]
argb32_source_argb32                     0.147732 sec
argb32_over_argb32                       0.352873 sec
[ Pixmap: 1200x800x200 ]
argb32_source_argb32                     0.058365 sec
argb32_over_argb32                       0.458145 sec

# pixman
[ Pixmap: 10x10x1000000 ]
argb32_source_argb32                     0.162651 sec
argb32_over_argb32                       0.149407 sec
[ Pixmap: 100x100x20000 ]
argb32_source_argb32                     0.020530 sec
argb32_over_argb32                       0.053927 sec
[ Pixmap: 200x200x10000 ]
argb32_source_argb32                     0.051592 sec
argb32_over_argb32                       0.132560 sec
[ Pixmap: 1200x800x200 ]
argb32_source_argb32                     0.041629 sec
argb32_over_argb32                       0.058690 sec

The following evaluation results come from this test code:
# built-in method
[ Pixmap: 10x10x1000000 ]
argb32_source_argb32                     0.076773 sec
argb32_over_argb32                       0.130076 sec
# pixman
[ Pixmap: 10x10x1000000 ]
argb32_source_argb32                     0.162651 sec
argb32_over_argb32                       0.149407 sec

Can you explain the test item 10x10x1000000?

The following evaluation results come from this test code:
# built-in method
[ Pixmap: 10x10x1000000 ]
argb32_source_argb32                     0.076773 sec
argb32_over_argb32                       0.130076 sec
# pixman
[ Pixmap: 10x10x1000000 ]
argb32_source_argb32                     0.162651 sec
argb32_over_argb32                       0.149407 sec

Can you explain the test item 10x10x1000000?

The following results show that it results from the allocation of pixman_image_t for src and dst in 'twin_composite' of pixman.c:

In small compositing size, the variation of the time consumption for pixman method is less than built-in method:

#Pixman
[ Pixmap: 7x7x1000000 ]
argb32_source_argb32                     0.169647 sec
argb32_over_argb32                       0.144932 sec
[ Pixmap: 9x9x1000000 ]
argb32_source_argb32                     0.151711 sec
argb32_over_argb32                       0.150564 sec
[ Pixmap: 11x11x1000000 ]
argb32_source_argb32                     0.169914 sec
argb32_over_argb32                       0.160988 sec
[ Pixmap: 13x13x1000000 ]
argb32_source_argb32                     0.172802 sec
argb32_over_argb32                       0.163671 sec
[ Pixmap: 15x15x1000000 ]
argb32_source_argb32                     0.194813 sec
argb32_over_argb32                       0.191646 sec
[ Pixmap: 17x17x1000000 ]
argb32_source_argb32                     0.183014 sec
argb32_over_argb32                       0.186015 sec
//////////////////////////////////////////////////////
#builtin
[ Pixmap: 7x7x1000000 ]
argb32_source_argb32                     0.054997 sec
argb32_over_argb32                       0.089470 sec
[ Pixmap: 9x9x1000000 ]
argb32_source_argb32                     0.070971 sec
argb32_over_argb32                       0.121374 sec
[ Pixmap: 11x11x1000000 ]
argb32_source_argb32                     0.088222 sec
argb32_over_argb32                       0.162219 sec
[ Pixmap: 13x13x1000000 ]
argb32_source_argb32                     0.112656 sec
argb32_over_argb32                       0.224784 sec
[ Pixmap: 15x15x1000000 ]
argb32_source_argb32                     0.130276 sec
argb32_over_argb32                       0.281983 sec
[ Pixmap: 17x17x1000000 ]
argb32_source_argb32                     0.161015 sec
argb32_over_argb32                       0.345266 sec

We find that the allocation of src and dst consumes 0.06 sec (with iters = 1000000) approximately if we comment on 'twin_composite' of pixman.c

[ Pixmap: 7x7x1000000 ]
argb32_source_argb32                     0.073393 sec
argb32_over_argb32                       0.067797 sec
[ Pixmap: 9x9x1000000 ]
argb32_source_argb32                     0.074549 sec
argb32_over_argb32                       0.062425 sec
[ Pixmap: 11x11x1000000 ]
argb32_source_argb32                     0.062554 sec
argb32_over_argb32                       0.063226 sec

When compositing with smaller size, the allocation time of src and dst is larger proportion in total time consumption. Only doing pixman_image_composite in twin_composite result is close to built-in method:

[ Pixmap: 10x10x1000000 ]
argb32_source_argb32                     0.076398 sec
argb32_over_argb32                       0.078906 sec
[ Pixmap: 100x100x20000 ]
argb32_source_argb32                     0.020046 sec
argb32_over_argb32                       0.054756 sec
[ Pixmap: 200x200x10000 ]
argb32_source_argb32                     0.050169 sec
argb32_over_argb32                       0.133911 sec
[ Pixmap: 1200x800x200 ]
argb32_source_argb32                     0.046361 sec
argb32_over_argb32                       0.059155 sec

Generally, the results with pixman method are better than the built-in method.

Generally, the results with pixman method are better than the built-in method.

We should integrate the performance suite before merging the proposed Pixman-based renderer to analyze its performance behavior and identify any regressions. Please submit a separate pull request for that purpose.

I plan to merge this pull request for further performance evaluation. Meanwhile, I would create new issue(s) to address pixman specific work. Some of them would be as following:

Evaluate the feasibility to replace the primitive operations, such as _twin_rgb16_source_argb32, _twin_argb32_over_argb32, and _twin_argb32_source_argb32, with Pixman counterpart.
the file src/primitive.c can be omitted if Pixman-based render path is selected.
Benchmarking! Locate the performance hotspot.

Rebase the latest main branch, resolve conflicts, and highlight the switch between the built-in renderer and the Pixman-based implementation. For RISC-V platforms without vector or SIMD extensions, the built-in renderer offers simplicity and works well. On modern CPU architectures with rich ISA extensions, Pixman provides faster pixel manipulation, making the switch to the Pixman-based implementation advantageous.

Could I refer to part of your sentence as a reference and include it in the commit message?

Could I refer to part of your sentence as a reference and include it in the commit message?

Sure! It is collaboration.

Thank @Bennctu for contributing!


(maint) Moves various VB options out of disk_path logic

Looks like these got moved into the if logic for disk_path accidentally around v2.8. This means that you can no longer use these options without adding disk_path logic in later versions of Beaker. This moves them back into their own section.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/1154/
Test FAILed.

Please update commit message with (MAINT) tag.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/1181/
Test FAILed.

retest this please

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/1191/
Test FAILed.

Failure unrelated to patch.


Content bot

this PR includes the changes needed to make the content bot (claim bot) work again on discord.
Due to the explorer API no longer working I had to resort in using lbry-decoder which will have to run on the server alongside the bot, otherwise it won't work.
more info are here: https://github.com/filipnyquist/lbry-decoder
comments?

@nikooo777 yes, happy the lbry-decoder is working! I´ll get this merged and deployed today, just need to get a lbry-decoder instance up on the server.

Merged as we need it up and running, changes will be done to make it fit more perfect.


[Text detection] Training step is very slow?

I use 2x 1080Ti or 8x GTX TITIAN X computer to train a model by using this repo code, but the model.fit function is very slow on the machine. I try to find why and change the code, the speed still can't be improved. The Intuition tells me that this speed is not normal.

@FLming you can try to disable ExponentialMovingAverageCallback


Please add Swift 5 support.

Hi @long1eu,
As of Release 6.0.0, we now support Swift 5 and Xcode 10.2: https://github.com/mongodb/stitch-ios-sdk/releases/tag/6.0.0.
Let us know if you encounter any other issues.


Feat(eos_cli_config_gen): VRRP timer delay and IPv4 version CLI options

Enhancement summary
Add support for VRRP timer delay reload command per VRID
Which component of AVD is impacted
eos_cli_config_gen
Use case example
Reload switch in VRRP switch which also consumes a BGP full routing table. As BGP still processes all the routes switch must be prevented to become VRRP master
Describe the solution you would like
   # New improved "vrrp" data model to support multiple IDs
    vrrp_ids:
      - id: < vrid >
        timers:
          delay:
            reload: < integer >

Describe alternatives you have considered
No response
Additional context
PR incoming
Contributing Guide

[X] I agree to follow this project's Code of Conduct

Anything mission for this one @ClausHolbechArista @carlbuchmann ?


修复 CollectionUtils类toStringMap方法没有检查 pairs 参数是否为空.

CollectionUtils类toStringMap方法没有检查 pairs 参数是否为空 in #5100.
添加如下代码
if (pairs == null || pairs.length == 0) {
return parameters;
}
resolve #5100

Codecov Report

Merging #5102 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #5102      +/-   ##
============================================
- Coverage     64.08%   64.03%   -0.05%
- Complexity      452      455       +3
============================================
  Files           769      769
  Lines         33261    33263       +2
  Branches       5249     5250       +1
============================================
- Hits          21314    21300      -14
- Misses         9516     9531      +15
- Partials       2431     2432       +1

Impacted Files
Coverage Δ
Complexity Δ

...org/apache/dubbo/common/utils/CollectionUtils.java
88.78% <100%> (-0.74%)
0 <0> (ø)

.../apache/dubbo/qos/protocol/QosProtocolWrapper.java
65.85% <0%> (-17.08%)
0% <0%> (ø)

.../apache/dubbo/remoting/transport/AbstractPeer.java
58.69% <0%> (-10.87%)
0% <0%> (ø)

.../rpc/protocol/dubbo/LazyConnectExchangeClient.java
56.47% <0%> (-2.36%)
0% <0%> (ø)

.../dubbo/remoting/transport/netty4/NettyChannel.java
64.77% <0%> (-2.28%)
0% <0%> (ø)

...he/dubbo/registry/multicast/MulticastRegistry.java
67.87% <0%> (-1.81%)
0% <0%> (ø)

...dubbo/metadata/support/AbstractMetadataReport.java
72.83% <0%> (-1.74%)
0% <0%> (ø)

...pache/dubbo/remoting/transport/AbstractServer.java
47.91% <0%> (-1.05%)
0% <0%> (ø)

...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java
90.65% <0%> (+0.93%)
17% <0%> (+1%)
:arrow_up:

...he/dubbo/remoting/transport/netty/NettyServer.java
73.21% <0%> (+3.57%)
9% <0%> (+1%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79c6166...cdaf4dd. Read the comment docs.


Cannot iterate over union of types (used to be possible in Ts-2.3)

TypeScript Version:  2.5.2
Code
type TypeDescription<T> = {[prop in keyof T]: undefined };

function getAllProperties<T>(typeDesc: (T|TypeDescription<T>)): ReadonlyArray<keyof T>
{
    const props: Array<keyof T> = [];

    for (var iPropName in typeDesc)
    {
        props.push(iPropName);
    }

    return props;
}

Expected behavior:
Should compile file (used to be in Ts-2.3)
Actual behavior:
Compile errors with "The right-hand side of 'for ... in'  ...".

T extends object or T extends {} should avoid the error for now.

Please, don't fix the new correct behaviour. It's been a bug in the compiler that has allowed this unsafe iteration.

Agreed, this doesn't seem like a bug.


RDK-29959:New Plugin MaintenanceManager.

Reason for change: Added new Plugin MaintenanceManager.
Test Procedure: Refer to Jira Ticket.
(cherry picked from commit d1aab72d803945cd33ceae7132feb68fd9cb03ef)
DELIA-49986: Handle status and abort flag
Handle all the status, abort flags.Update docs.
(cherry picked from commit cf3cf33fbe89dd25861b4dc419c5ffdca5d8d7a6)
DELIA-50086: Rework on MaintenanceManager
Reason for change: Added thread and other modifications as per design.
Test Procedure: Refer Main ticket
(cherry picked from commit 253cf924db4ad92025d715ac0b925c9997ebcab5)
RDKTV-6021: MaintenanceManager Fixes
Reason for change: Autoreboot was not happening earlier during
Solicited maintenance.Maintenance activity status shows started due to
older design.start maintenance api is blocked due to waiting for DCM.
removed the same.
(cherry picked from commit 74b7b4700cf6d171cd2aaf1b35d493cf46f45646)
RDK-29274:Thunder APIs for AutoReboot
Reason for change: Added new method for
fwPendingReboot,fwAutoReboot & fwDelayReboot.
'{"jsonrpc":"2.0","id":"3","method":"org.rdk.System.2.fireFirmwarePendingReboot","params":{}}'
'{"jsonrpc":"2.0","id":"3","method":"org.rdk.System.2.setFirmwareRebootDelay","params":{"delaySeconds":int seconds}}'
'{"jsonrpc":"2.0","id":"3","method":"org.rdk.System.2.setFirmwareAutoReboot","params":{"enable":bool enableFwAutoreboot}}'
Test Procedure: Refer to Jira Ticket.
(cherry picked from commit e0ad193f168b823f46acc6fdf7a7f443544249e4)
(cherry picked from commit b86ae925eabed9aabb786a7b10940394921dd4d4)
(cherry picked from commit a145cf3cddb2934f90b4151b569a65ee654f72ac)

Cleaning up older PRs. Please create new PR on latest sprint if required.


[Core][OTel] Propagate library name/version to tracing plugin

Propagating SDK meta information for tracing
Problem
For distributed tracing, there are a few pieces of information that we'd like to propagate to created spans:

package name and version (for tracer instrumentation scope)
associated resource provider (as az.namespace attribute)

Examples from this list: Microsoft.Storage, Microsoft.OperationalInsights, etc.
See https://github.com/Azure/azure-sdk-for-python/issues/9256 for more information.

The primary entry point for span creation for most SDKs is through the distributed_trace and distributed_trace_async decorators which only get access to the function each decorator is wrapping. While package name and version (in most cases) can be determined heuristically, the resource provider value can not reliabily be determined. We need a way for all this information to be readily available.
Proposed solution

Add a RESOURCE_PROVIDER constant to the base of all SDK packages inside _version.py or a new file like _about.py. This value will contain the corresponding value for each SDK.
Make the generation of this constant a part of the Python code generation process by adding some flag (like --resource-provider/--provider) when using autorest.

Can make it required in autorest, so that when developers regen, the user will know to set this value. Can also add these values to swagger files as a one-time effort for all relevant SDKs.

Also, generate a PACKAGE_NAME constant (given by the --package-name flag) that has the pip-installable package name of the libary (i.e. azure-storage-blob). Since package_name is already an autorest argument, we can also propagate the value here to make determining the package name very straightforward.
Update guidelines that notes the existence and purpose of these constants.

What this PR does
This PR makes the assumption that VERSION, RESOURCE_PROVIDER, and PACKAGE_NAME are in each SDK's _version.py file. These constants can be discovered and checked inside the distributed_trace and distributed_trace_async decorators by searching the decorated function module names until a _version module is found.  See PR code in common.py.
Sample _version.py:
VERSION = "12.16.0b1"
RESOURCE_PROVIDER = "Microsoft.Storage"
PACKAGE_NAME = "azure-storage-blob"

This information is then extracted and passed to the created spans. The package name and version are passed to the the span constructor, while the resource provider value is added as an attribute with key az.namespace.
For the case of span creation inside DistributedTracingPolicy, we infer the values by checking the current span which will generally be a span created from inside one of the decorators.
Alternative solutions

Another solution could be to make a "module/package name" -> "Resource provider" dictionary (e.g. { "azure.storage.blob": "Microsoft.Storage", "azure.ai.language.conversations": "Microsoft.CognitiveServices", ...} in core that the decorators can check based on the function base modules, However, I'd rather we not have to maintain this dictionary, and we leave the responsibility of providing a resource provider to each SDK developer.

Additional Context

The .NET SDK has a required --provider flag (see here) where users are expected to pass in the project's associated resource provider.

Ref: https://github.com/Azure/azure-sdk-for-python/issues/25838

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-core

@lmazuel @johanste @annatisch Feedback on this would be most appreciated. 😸


image links in notebook don't work in Watson Studio

Get broken images in Watson Studio.  I don't think there was any step that would download these files. Probably should used full URLs to github content.
Configuring the output as line chart, the visualization looks as follows:

PixieDust presents visualisations of DataFrames using Matplotlib, Bokeh, Brunel, d3, Google Maps and, MapBox. No code is required on your part because PixieDust presents simple pull-down menus and a friendly point-and-click interface, allowing you to configure how the data is presented:

and other images/ references

The original notebook was developed to run in a local environment and therefore used local file references. I'll update the notebook to href the images in github, to make this work as expected in local and cloud environments.

Delivered by #8. All images should now be displayed in the notebook.


Documentation wrong for vaultUri

Report
The documentation is wrong for vaultUri, in the documentation here: https://keda.sh/docs/2.11/concepts/authentication/ it is vaultURI
This results in this error:

Error: UPGRADE FAILED: error validating "": error validating data: [ValidationError(TriggerAuthentication.spec.azureKeyVault): unknown field "vaultURI" in sh.keda.v1alpha1.TriggerAuthentication.spec.azureKeyVault, ValidationError(TriggerAuthentication.spec.azureKeyVault): missing required field "vaultUri" in sh.keda.v1alpha1.TriggerAuthentication.spec.azureKeyVault]

Expected Behavior
correct documentation
Actual Behavior
incorrect documentation
Steps to Reproduce the Problem
read the documentation and follow the example
Logs from KEDA operator
Error: UPGRADE FAILED: error validating "": error validating data: [ValidationError(TriggerAuthentication.spec.azureKeyVault): unknown field "vaultURI" in sh.keda.v1alpha1.TriggerAuthentication.spec.azureKeyVault, ValidationError(TriggerAuthentication.spec.azureKeyVault): missing required field "vaultUri" in sh.keda.v1alpha1.TriggerAuthentication.spec.azureKeyVault]
KEDA Version
2.11.1
Kubernetes Version
1.24
Platform
Microsoft Azure
Scaler Details
No response
Anything else?
No response

I guess it's a typo because in the authentication page is correct https://keda.sh/docs/2.11/authentication-providers/azure-key-vault/
Thanks for reporting this typo 😄 Could you open a PR in docs repo fixing it?


ZED works with v2 or not?

I followed the google doc, and install everything until I do the single camera tracking.
roslaunch tracking single_camera_tracking_node.launch
The ZED is working when I do:
/usr/local/zed/tools/ZED\ Diagnostic
However,
in  roslaunch tracking single_camera_tracking_node.launch,
I got:
Freenect2Impl] enumerating devices...
[Freenect2Impl] 7 usb devices connected
[Freenect2Impl] found 0 devices
Error: no Kinect2 devices found!
Initialization failed!

Zed integration has been recently completed.


Issue 455: correcting publish run command

Change log description
Updated the publish_check.yml to publish pravega-client
Purpose of the change
Fixes #455
What the code does
Running publish command for different packages separately.
How to verify it
All test should pass.

We're currently processing your upload.  This comment will be updated when the results are available.


Chinese translation; Add countdown style current time manipulations; Add and edit connectors

Rewrite and enrich several connectors according to wiki.

Please next time use several PRs for each change (translations, connector improvements etc). It's really hard to review all these changes in one PR.

Sorry for put everything in single PR as this is the first time I use git and alike for collaboration.
Now I've separated them #1428 #1429 #1430 #1431 #1432 , hope I'm doing this right.


Make DockPanelSkin internal of each themes

Currently we still expose DockPanelSkin via DockPanel control directly. This makes it very difficult to tailor this skin class to meet the needs of each themes.
For example, VS2012 has tool window tab separators, which do not exist in VS2013/2015. Not to mention that VS2003/2005 use a completely different set of elements.
Once this item could be implemented, each themes should have their own skin classes and further customization can be theme alone.

Initially, Extender is now moved to themes.


Migrate to Swift 3.2

This pull requests migrates the project to be compatible with Swift 4. Though the codebase is now compatible to be marked with the Swift 4 build setting, the compiler flag is set to Swift 3.2 for now so that backwards compatibility may be maintained with Xcode 8.3
As Xcode 9 has the nice new feature to mirror the xcodeproj directory structure to that of the on-disk structure, the directory structure has changed a bit (this was also necessary as Xcode 9 saw dead file references when opening the existing project).
Currently, the module structure mimics the conceptual structure of the podspec:
Source code for Interstellar lives in Sources/Interstellar and since Warpdrive is really an extension for Interstellar, the code lives at Sources/Interstellar/Warpdrive

Hey, thanks for your commit. I just have to check backwards compatibility with Xcode 8 and then I'm ready to merge!

Hey, I've checked the project on Xcode 8. Somehow the playgrounds don't work anymore (Xcode 8 complains about missing files, Xcode 9 gives some errors in the logs).

Ahh, I forgot to check the playgrounds. I can attend to that sometime before the weeks end. Thanks for checking out my branch ;-)

Hey @JensRavens, Looks like they were just missing the import statements. They should be working for both Xcode 8.3.3 and Xcode 9-beta now.

Hey @JensRavens , I'll be on vacation for the next 2 weeks, so just wanted to revisit this before I leave and see if there were any additional changes you'd like to see.
Cheers.

Just a note regarding your last change: The import statement was left out intentionally - This way you need to build the project before you can use the playground. Instead the playground had a copy of all source files included, therefore it can be distributed independently.

Hi @JensRavens , I didn't fully understand your last comment. Without the import statement, the playground spits out the following error message with Xcode 8 (after building the OSX target and executing the playground)
error: 0 Preface.xcplaygroundpage:2:18: error: use of unresolved identifier 'Observable'
let observable = Observable("User")

Even with the imports, the project needs to be built before the playground will run, so I'm not sure what optimization you are describing when saying "it can be distributed independently".

Hey @JensRavens . I wanted to circle back and see about getting this merged. I'm very happy to make the necessary changes so that the codebase is in the state you'd like it to be in. I'm unsure about what should be changed at this point as, to me, it seems without the import that the playgrounds don't execute.

Hi @JensRavens sorry to keep bothering, but I'd like to revisit this PR and see what the next steps are on my end. As I mentioned in my comment above, I'm unsure about what the desired fix is for the playground and the import statements, which I believe are necessary to execute the playground.

Thanks for insisting on this! 👍
I've merged this manually after some changes via #63.
The issue basically came to life by a change on how playgrounds work: Before code from the sources dir was automatically loaded, now it's done via an explicit import. To keep backwards compatibility I just referenced the files in the source-dir of each page (which still have the old behaviour of not needing the import). This way you can just copy the playground file and distribute it independently (which I need for my teaching classes).
Thanks for all your work!

I see! Thanks for revisiting this, and also thanks for the explanation about the change to playgrounds. Hope you have a nice week!


feat: DEVHAS-234: Add 2 scenarios to e2e-demos

Description

Importing user applications (some other applications that do not come from the stack starter project) that do not contain devfile and dockerfile
Importing user applications (some other applications that do not come from the stack starter project)  that only contain a dockerfile but no devfile

Issue ticket number and link
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:

[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
[ ] I have updated labels (if needed)

cc @elsony @johnmcollier

/retest

@dirgim @jinqi7 can u help me to debug why snapshot is failing?

/retest

/retest


[MNOE-474] Update locales for review frontend

@ouranos Updated locales for review frontend

Merging in 3.3 branch