Unexpected destination of JMPIF with while expressions

Describe the bug
I used while and slicing ([7:]) in a method, and the compiled JMPIF jumped to another method
How to Reproduce
In https://github.com/Hecate2/neo-ruler/blob/4384c7a4a26fad2ea7c0fcb89a92a3869c839b17/ruler.py#L167
we have the function collectFees:
@public
def collectFees() -> bool:
    """
    THIS API IS NOT OPERABLE FOR NOW
    wrong JMPIF instruction, maybe related to slicing
    """
    # no need to check witness
    iterator = find(b'feesMap')
    fee_receiver = get(FEE_RECEIVER_KEY)
    while iterator.next():
        token_bytes = cast(bytes, iterator.value[0])
        token_bytes = token_bytes[7:]  # cut 'feesMap' at the beginning of the bytes
        token = cast(UInt160, token_bytes)
        fee_amount = cast(int, iterator.value[1])
        if fee_amount > 0:
            feesMap.put(token, 0)
            assert call_contract(token, 'transfer', [executing_script_hash, fee_receiver, fee_amount, 'Collect Fees'])
    return True

The expression while iterator.next(): is compiled as
# Code ruler.py line 175: ""
0638 LDLOC0
0639 SYSCALL 9C-08-ED-9C # System.Iterator.Next
0644 JMPIF 78 # pos: 764, offset: 120

The instruction JMPIF 78 wrongly leads to another function get_pair_attribute:
0764 CONVERT 28
0766 RET
# Method End .get_pair_attribute

Maybe this problem is related to the slicing operation token_bytes = token_bytes[7:]. When I do not slice anything, there is no compilation problem (though I cannot implement my desired logics without slicing).
The contract's functions of fees, deposit, repay and collect can be automatically tested with https://github.com/Hecate2/neo-ruler/blob/flashLoan/tests/fee_rpc_test.py , using a private blockchain and RpcServer Plugin. Correct contract_hash should be filled in https://github.com/Hecate2/neo-ruler/blob/flashLoan/tests/utils.py .
Platform:

OS: Windows 10 x64
Version: neo3-boa v0.8.1 with the latest merging commit 16afcd1db41e771e6e30e0c1a5d1c253c345de6c on June 2
Python version: Python 3.7

(For correct business logic, I still have to put feesMap[token] = 0 along with call_contract(token, 'transfer'..., but this is not related to this issue)

If I write collectFees like this:
    while iterator.next():
        token_bytes = cast(bytes, iterator.value[0])
        # token_bytes = token_bytes[7:]  # cut 'feesMap' at the beginning of the bytes
        token = cast(UInt160, token_bytes[7:])
        fee_amount = cast(int, iterator.value[1])
        if fee_amount > 0:
            feesMap.put(token, 0)
            assert call_contract(token, 'transfer', [executing_script_hash, fee_receiver, fee_amount, 'Collect Fees'])
    return True

There would be an error reported during compiling:
ERROR: 210:11 - Internal compiler error. KeyError: 775

and the dumped while iterator.next(): still goes to the wrong function:
# Code ruler.py line 175: ""
0654 LDLOC0
0655 SYSCALL 9C-08-ED-9C # System.Iterator.Next
0660 JMPIF 5A # pos: 750, offset: 90

and the destination functions are of more crazy errors:
# Method Start .get_pair_attribute
0747 INITSLOT 00-02 # 0 local variables, 2 arguments
0750 CONVERT 28
0752 RET
# Method End .get_pair_attribute
# NO MORE INSTRUCTIONS FOR get_pair_attribute!

Another sample:
    while iterator.next():
        token_bytes = cast(bytes, iterator.value[0])
        token_bytes = token_bytes[7:]  # cut 'feesMap' at the beginning of the bytes
        token = cast(UInt160, token_bytes)
        fee_amount = cast(int, iterator.value[1])
        if fee_amount > 0:
            feesMap.put(token, 0)
            assert call_contract(token, 'transfer', [executing_script_hash, fee_receiver, fee_amount, 'Collect Fees'])

ERROR: 210:11 - Internal compiler error. KeyError: 777

# Method Start .get_pair_attribute
0749 INITSLOT 00-02 # 0 local variables, 2 arguments
0752 CONVERT 28
0754 RET
# Method End .get_pair_attribute
# Method Start ._insert_pair
0755 INITSLOT 01-09 # 1 local variables, 9 arguments
# Code ruler.py line 219: ""
0758 LDSFLD 07
0760 SYSCALL 9B-F6-67-CE # System.Storage.GetContext
0765 SYSCALL 92-5D-E8-31 # System.Storage.Get
0770 DUP
0771 ISNULL
0772 JMPIFNOT 07 # pos: 779, offset: 7
0774 DROP
0775 PUSHDATA1 # as text: ""
0777 CONVERT 28
0779 CONVERT 21
0781 STLOC0
0782 LDARG0
0783 PUSHDATA1 61-63-74-69-76-65 # as text: "active"
0791 LDLOC0
0792 CALL_L E8-FC-FF-FF # pos: 0, offset: -792
0797 LDSFLD 08
0799 SWAP
0800 OVER
0801 PUSH1
0802 PICKITEM
0803 SWAP
0804 CAT
0805 SWAP
0806 PUSH0
0807 PICKITEM

Another example where ruler.py cannot be compiled:
    while iterator.next():
        token_bytes = cast(bytes, iterator.value[0])[7:]
        token = cast(UInt160, token_bytes)
        fee_amount = cast(int, iterator.value[1])
        if fee_amount > 0:
            # feesMap.put(token, 0)  # This must be commented out for now. Otherwise get_pair_attribute would be broken
            assert call_contract(token, 'transfer', [executing_script_hash, fee_receiver, fee_amount, 'Collect Fees'])
    return True

ERROR: 176:22 - Internal compiler error. AttributeError: 'Slice' object has no attribute 'lineno'


[CI/Build] 0.4.0.post1, fix sm 7.0/7.5 binary

Upgrade to 0.4.0.post1, to include the fix of sm 7.0/7.5 binary in prebuilt wheels.

should fix https://github.com/vllm-project/vllm/issues/3764


Introduce the simpleBuffer as implementation of the httputil.BufferPool.

Description
description_with_details_and_reasoning
Type of change

[x] Bug fix
[ ] New feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Non-code changes (update documentation, pipeline, etc.)

Flags

[ ] Breaks backward compatibility
[ ] Requires a documentation update
[ ] Has untestable code

Related issue/PR
Delete this section if there are no issues or pull requests that relate to this pull request.

Fixes #issue
Closes #PR

Checklist

[x] Followed the guidelines in the CONTRIBUTING document
[ ] Added prefix [skip ci]/[ci skip]/[no ci]/[skip actions]/[actions skip] in the PR title if necessary
[x] Tested and linted the code
[x] Commented the code
[ ] Made corresponding changes to the documentation
[ ] Passed all pipeline checking

Checklist for maintainer

Use Squash and merge
Double-confirm the merge message has prefix [skip ci]/[ci skip]/[no ci]/[skip actions]/[actions skip]
Delete the branch after merge

There are some bugs in the infra package

Unnecessary reset process.

https://github.com/AthenZ/authorization-proxy/blob/4bc56bbbf670d016cd84167662c26a674a959953/infra/buffer.go#L64
The copyBuffer function in the httputil.ReverseProxy package checks the length of the slice that given as argument(buf), and if the length of the slice is 0, it makes a slice as 32 * 1024 (32KB).
The authorisation-proxy (infra package) always reset the slice length to 0 before put it to the pool, this means that the buffer size is always 32KB when copying.

Incorrect comparison conditions.

https://github.com/AthenZ/authorization-proxy/blob/4bc56bbbf670d016cd84167662c26a674a959953/infra/buffer.go#L74
Even if a slice with the same capacity as buffer.size is put, a new slice will be created.
Since httputil.ReverseProxy does not change the slice size, results in memory allocation every time a response is copied.
The impact of this issue is limited, you probably can't notice it if you don't specify a large value for bufferSize (see result of memory usage).
In this PR, a new simpleBuffer is introduced to solve the above problem.
The current implementation of BufferPool is overkill because the httputil.Reverseproxy does not resize the slice used to copy the response.
However the current implementation has been left, it could be used for other purposes.
e.g. memory usage
before

bufferSize
requests/sec
duration
max rss (kb)

419430400
1/s
1s
440288

419430400
1/s
10s
1669664

419430400
100/s
1s
18902020

419430400
100/s
10s
27421440

after

bufferSize
requests/sec
duration
max rss (kb)

419430400
1/s
1s
435296

419430400
1/s
10s
441516

419430400
100/s
1s
3351424

419430400
100/s
10s
6216764

👍 LGTM


Voting does sometimes not work properly

I down-voted the comment beginning with "It's only wrong when" in https://notabug.io/t/videos/comments/4e49fcb07adc30625e28bac6ec61ef95aabb6b02/thoughts-did-mama-go-overboard-with-this-a-whoopin-or-nah . When loading this site, at first it displays -1, but then switches to -0. I have tested it on two devices, one of which was used for down-voting the comment.
Also, sometimes a post that has a score bigger than 0 in the listing gets a score of 0 (+0, -0) when you click on it. And if I recall correctly, sometimes your vote does not get accounted in both the listing and the post itself.

Thanks for the report
Some listing data is cached in the service of performance, there are some issues right now with comment threads requesting data too often and in a way that might lead to the reversal of seen points.
I'll keep this open till that issue is fixed and we'll see if it improves it.

0.7.0-3 live on notabug.io (what will eventually become 0.7.1) should improve comment data loading behavior and I think will reduce this issue.
It's still normal to vote, see it register, refresh and see it disappear for a bit though; this is the cacheing.

This should be resolved now.


Update ImageAlpha cask to latest version.

See https://twitter.com/pornelski/status/336639773382950913

Thank you for the contribution. It was merged directly as d76de41a9cbb062987c84f199f228d4a94b205ed to keep commit history cleaner. Your contribution is still credited to you.


[BUG] Certs and directory /var/lib/rancher/rke2/server/tls/kube-scheduler and /var/lib/rancher/rke2/server/tls/kube-controller-manager missing

Rancher Server Setup

Rancher version: 2.7.3
Installation option (Docker install/Helm Chart): HELM

K3S v1.25.9+k3s1

Information about the Cluster

Kubernetes version: v1.25.9+rke2r1
Cluster Type (Downstream):

If downstream, what type of cluster? (Custom/Imported or specify provider for Hosted/Infrastructure Provider):
Custom
Node VM OS Ubuntu 22.04

User Information

What is the role of the user logged in? Admin

Describe the bug
When creating a new custom cluster via Rancher's UI, the nodes that I try to add are stuck in "reconcilling" sate.
To Reproduce

Create a new cluster on Rancher UI following documentation:
https://ranchermanager.docs.rancher.com/reference-guides/cluster-configuration/rancher-server-configuration/rke2-cluster-configuration
All parameters to default except:
Kubernetes Version: v1.25.9+rke2r1
Container Network: Calico
NGINX Ingress: Selected or not I had the same problem

Register a node
Keep all roles selected in step 1
Select "Insecure" in step 2
Copy and paste the cmd to the first node

Result
The node stay in "reconcilling" state with this message: "Waiting for probes: kube-apiserver, kube-controller-manager, kube-scheduler"
Command to obtain logs on the node:
sudo journalctl -u  rancher-system-agent.service -f
Logs obtained:
May 24 13:26:56 s001kubed01 rancher-system-agent[16705]: time="2023-05-24T13:26:56Z" level=error msg="error loading CA cert for probe (kube-scheduler) /var/lib/rancher/rke2/server/tls/kube-scheduler/kube-scheduler.crt: open /var/lib/rancher/rke2/server/tls/kube-scheduler/kube-scheduler.crt: no such file or directory" May 24 13:26:56 s001kubed01 rancher-system-agent[16705]: time="2023-05-24T13:26:56Z" level=error msg="error while appending ca cert to pool for probe kube-scheduler" May 24 13:26:57 s001kubed01 rancher-system-agent[16705]: time="2023-05-24T13:26:57Z" level=error msg="error encountered during parsing of last run time: parsing time \"\" as \"Mon Jan _2 15:04:05 MST 2006\": cannot parse \"\" as \"Mon\"" May 24 13:26:57 s001kubed01 rancher-system-agent[16705]: time="2023-05-24T13:26:57Z" level=error msg="error loading CA cert for probe (kube-controller-manager) /var/lib/rancher/rke2/server/tls/kube-controller-manager/kube-controller-manager.crt: open /var/lib/rancher/rke2/server/tls/kube-controller-manager/kube-controller-manager.crt: no such file or directory" May 24 13:26:57 s001kubed01 rancher-system-agent[16705]: time="2023-05-24T13:26:57Z" level=error msg="error while appending ca cert to pool for probe kube-controller-manager" May 24 13:26:57 s001kubed01 rancher-system-agent[16705]: time="2023-05-24T13:26:57Z" level=error msg="error loading CA cert for probe (kube-scheduler) /var/lib/rancher/rke2/server/tls/kube-scheduler/kube-scheduler.crt: open /var/lib/rancher/rke2/server/tls/kube-scheduler/kube-scheduler.crt: no such file or directory" May 24 13:26:57 s001kubed01 rancher-system-agent[16705]: time="2023-05-24T13:26:57Z" level=error msg="error while appending ca cert to pool for probe kube-scheduler" May 24 13:27:01 s001kubed01 rancher-system-agent[16705]: time="2023-05-24T13:27:01Z" level=error msg="error encountered during parsing of last run time: parsing time \"\" as \"Mon Jan _2 15:04:05 MST 2006\": cannot parse \"\" as \"Mon\""
Directories "/var/lib/rancher/rke2/server/tls/kube-controller-manager" and "/var/lib/rancher/rke2/server/tls/kube-scheduler" are indeed missing. So are the CRTs (not even misplaced)
Expected Result
The node get registered automatically
Thanks for your help 😄

I get this error, but I catted the file, it does indeed exist . So as @Oats87  mentioned it was transient
Checking the kubelet log I see that the Calico overlay is never starting. I tried everything I could to try work out why this was happening to no avail. Eventually I read a stack overflow post  which mentioned that it is likely due to resource starvation. I updated my memory on the node to 4 gigs from 2 and it started working
I used the same config as you  @flhelfer

Jul 07 12:07:43 k8s13ms1 rancher-system-agent[23909]: time="2023-07-07T12:07:43Z" level=info msg="[Applyinator] Running command: sh [-c rke2 etcd-snapshot list --etcd-s3=false 2>/dev/null]"
Jul 07 12:07:43 k8s13ms1 rancher-system-agent[23909]: time="2023-07-07T12:07:43Z" level=info msg="[Applyinator] Command sh [-c rke2 etcd-snapshot list --etcd-s3=false 2>/dev/null] finished with err: <nil> and exit code: 127"
Jul 07 12:07:44 k8s13ms1 rancher-system-agent[23909]: time="2023-07-07T12:07:44Z" level=error msg="error while appending ca cert to pool for probe kube-scheduler"
Jul 07 12:07:44 k8s13ms1 rancher-system-agent[23909]: time="2023-07-07T12:07:44Z" level=error msg="error while appending ca cert to pool for probe kube-controller-manager"
Jul 07 12:07:44 k8s13ms1 rancher-system-agent[23909]: time="2023-07-07T12:07:44Z" level=error msg="error loading x509 client cert/key for probe kube-apiserver (/var/lib/rancher/rke2/server/tls/client-kube-apiserver.crt//var/lib/rancher/rke2/server/tls/client-kube-apiserver.key): tls: failed to find any PEM data in certificate input"
Jul 07 12:07:44 k8s13ms1 rancher-system-agent[23909]: time="2023-07-07T12:07:44Z" level=error msg="error while appending ca cert to pool for probe kube-apiserver"
Jul 07 12:07:44 k8s13ms1 rancher-system-agent[23909]: time="2023-07-07T12:07:44Z" level=info msg="[K8s] updated plan secret fleet-default/custom-c7ffee61e8c4-machine-plan with feedback"
Jul 07 12:07:44 k8s13ms1 rancher-system-agent[23909]: time="2023-07-07T12:07:44Z" level=error msg="error encountered during parsing of last run time: parsing time \"\" as \"Mon Jan _2 15:04:05 MST 2006\": cannot parse \"\" as \"Mon\""
Jul 07 12:07:44 k8s13ms1 rancher-system-agent[23909]: time="2023-07-07T12:07:44Z" level=error msg="error while appending ca cert to pool for probe kube-scheduler"
Jul 07 12:07:44 k8s13ms1 rancher-system-agent[23909]: time="2023-07-07T12:07:44Z" level=error msg="error while appending ca cert to pool for probe kube-controller-manager"
Jul 07 12:07:44 k8s13ms1 rancher-system-agent[23909]: time="2023-07-07T12:07:44Z" level=error msg="error loading x509 client cert/key for probe kube-apiserver (/var/lib/rancher/rke2/server/tls/client-kube-apiserver.crt//var/lib/rancher/rke2/server/tls/client-kube-apiserver.key): tls: failed to find any PEM data in certificate input"
Jul 07 12:07:44 k8s13ms1 rancher-system-agent[23909]: time="2023-07-07T12:07:44Z" level=error msg="error while appending ca cert to pool for probe kube-apiserver"
Jul 07 12:07:49 k8s13ms1 rancher-system-agent[23909]: time="2023-07-07T12:07:49Z" level=error msg="error encountered during parsing of last run time: parsing time \"\" as \"Mon Jan _2 15:04:05 MST 2006\": cannot parse \"\" as \"Mon\""
Jul 07 12:07:49 k8s13ms1 rancher-system-agent[23909]: time="2023-07-07T12:07:49Z" level=error msg="error loading x509 client cert/key for probe kube-apiserver (/var/lib/rancher/rke2/server/tls/client-kube-apiserver.crt//var/lib/rancher/rke2/server/tls/client-kube-apiserver.key): tls: failed to find any PEM data in certificate input"
Jul 07 12:07:49 k8s13ms1 rancher-system-agent[23909]: time="2023-07-07T12:07:49Z" level=error msg="error while appending ca cert to pool for probe kube-controller-manager"
Jul 07 12:07:49 k8s13ms1 rancher-system-agent[23909]: time="2023-07-07T12:07:49Z" level=error msg="error while appending ca cert to pool for probe kube-apiserver"
Jul 07 12:07:49 k8s13ms1 rancher-system-agent[23909]: time="2023-07-07T12:07:49Z" level=error msg="error while appending ca cert to pool for probe kube-scheduler"
Jul 07 12:07:54 k8s13ms1 rancher-system-agent[23909]: time="2023-07-07T12:07:54Z" level=error msg="error encountered during parsing of last run time: parsing time \"\" as \"Mon Jan _2 15:04:05 MST 2006\": cannot parse \"\" as \"Mon\""
Jul 07 12:07:54 k8s13ms1 rancher-system-agent[23909]: time="2023-07-07T12:07:54Z" level=error msg="error loading x509 client cert/key for probe kube-apiserver (/var/lib/rancher/rke2/server/tls/client-kube-apiserver.crt//var/lib/rancher/rke2/server/tls/client-kube-apiserver.key): tls: failed to find any PEM data in certificate input"

rancher v2.7.5
kubernetes v1.26.6+rke2r1

Got same issue on rancher v2.6.13.
k8s versions: v1.22.17+rke2r1, v1.23.17+rke2r1

Got same issue on
rancher v2.6.10
k8s versions: v1.22.17+rke2r1, v1.23.15+rke2r1, v1.24.9+rke2r2
ubuntu 20,04.6 lts

Same here:
Rancher 2.7.5
v1.24.15+rke2r1
ubuntu 22.04.2

Same problem here
Rancher 2.7.5
v1.26.5+rke2r1
redhat 8.7
docker client: 23.0.1
docker server: 19.03.14

Same problem here
Rancher 2.7.5
v1.26.6+rke2r1
Ubuntu 22.04.2

Actually, I think I found the problem, when we provision a dual stack cluster with the rancher UI, we can't use dual stack pod/service cidr because we can't register the node with multiple IP (bogus for tcp listen because the text is like "fc00::1,<IP_ADDRESS>"). And when I try to register the node with only one IP, I get an error telling me that the node ip has to be of the same family of the pod cidr (ipv4 + ipv6). Doesn't make any sense.

Same issue
Rancher 2.7.5
v1.26.6+rke2r1
Ubuntu 22.04

I fixed the issue with disabling IPv6 IP-addresses on master nodes. When the first node was bootstrapped it tried to connect with two other node with IPv6 and failed. After disabling all works fine.

I fixed the issue with disabling IPv6 IP-addresses on master nodes. When the first node was bootstrapped it tried to connect with two other node with IPv6 and failed. After disabling all works fine.

In my env, I need the dual-stack ip addresses.

I fixed the issue with disabling IPv6 IP-addresses on master nodes. When the first node was bootstrapped it tried to connect with two other node with IPv6 and failed. After disabling all works fine.

In my env, I need the dual-stack ip addresses.

You can check my repo where I've fixed the issue (WORKING DUAL STACK !!), if you intend to use this code as is, you have to change the rancher agent version to v2.7-head on line 40 (var VERSION) of the file cmd/agent/main.go

I fixed the issue with disabling IPv6 IP-addresses on master nodes. When the first node was bootstrapped it tried to connect with two other node with IPv6 and failed. After disabling all works fine.

In my env, I need the dual-stack ip addresses.

You can check my repo where I've fixed the issue (WORKING DUAL STACK !!), if you intend to use this code as is, you have to change the rancher agent version to v2.7-head on line 40 (var VERSION) of the file cmd/agent/main.go

And you may also want to use the kubelet arg --node-ip=:: to make kubelet advertise his IPv6 in k8s Node object.

I've created PR https://github.com/rancher/rancher/pull/42422 for fixing dual stack cluster creation

I fixed the issue with disabling IPv6 IP-addresses on master nodes. When the first node was bootstrapped it tried to connect with two other node with IPv6 and failed. After disabling all works fine.

In my env, I need the dual-stack ip addresses.

You can check my repo where I've fixed the issue (WORKING DUAL STACK !!), if you intend to use this code as is, you have to change the rancher agent version to v2.7-head on line 40 (var VERSION) of the file cmd/agent/main.go

TKS

Same problem here
Rancher 2.7.6
v1.26.7+rke2r1
Centos7.8
I tried disabling the IPv6 of the node, but I still couldn't register the node.

Same problem here
Rancher 2.7.é
v1.25.7+rke2r1
rh8.6
I tried disabling the IPv6 of the node, but I still couldn't register the node.
Any idea ?

@Riadh-Tlidjine @qRainBirdp A PR is open about this (very easy to integrate given the code changes) since a month, but the developers don't care much about it because they haven't responded yet. Even though this problem is critical and shouldn't be in first place because IPv6 is almost my age. Shameful

Can also confirm, on 2.7.6 (centos 7) and RKE2 downstream cluster 1.24. IPv6 is already disabled on my VMs and still can observe the issue

Hi, good news, we have find the root cause,
We had the options "noexec" on /var mountpoint in /etc/fstab, so some execution scripts could'nt be executed.
/dev/mapper/rootvg-var  /var                    ext4    defaults,noexec,nosuid,nodev 1 2
This is because we are using already hardened RHEL iso version.

The Problem still occurs and it is not a fstab error

Same problem.

Same issue, mostly default parameters used.

same issue on Rancher 2.7.9, Calico, 1.26.8+rke2r1

Same here.

It's interesting that this problem occurs (at least in my case) only when I'm using RockyLinux 9.2... I tried the exact same stack but this time Ubuntu 20.04.6LTS and everything went as it should.

With Ubuntu 22.04 it doesn't work for me.

Had the same issue with ubuntu 22.04
Feb 02 11:47:58 ip-172-31-0-143 rancher-system-agent[17366]: time="2024-02-02T11:47:58Z" level=error msg="error while appending ca cert to pool for probe kube-controller-manager"
Feb 02 11:47:58 ip-172-31-0-143 rancher-system-agent[17366]: time="2024-02-02T11:47:58Z" level=error msg="error loading CA cert for probe (kube-scheduler) /var/lib/rancher/rke2/server/tls/kube-scheduler/kube-scheduler.crt: open /var/lib/rancher/rke2/server/tls/kube-scheduler/kube-scheduler.crt: no such file or directory"

For us, we had to manually created the etcd user and additionally make sure to set the kernel parameters https://docs.k3s.io/security/hardening-guide#set-kernel-parameters
Kubernetes 1.24.17 - cis 1.6

if your cluster is ready ,just use Import Existing -> Generic (or somethink you want) -> Registration

This also happens to me with
Rancher v2.8.2, RKE2 v1.27.12+rke2r1, calico
Downstream Cluster: RKE2, v1.27.12+rke2r1, , calico
Registered 3 etcd / control nodes, 3 workers
First node partially registers but then gets into an error loop of

dial tcp <IP_ADDRESS>:6443: connect: connection refused

and cannot proceed.
this has happened on multiple downstream clusters (RKE2 and K3s) and happens no matter which installed components or roles I choose.
The only fix I have found is to wait long enough and reboot the node trying to register.  Eventually it will delete old pods, delete old containers, and try again.
TLDR, if you see this in the logs when running
tail -f /var/lib/rancher/rke2/agent/logs/kubelet.log just keep rebooting until it properly registers.

This is still an issue with k8s 1.28.8-rke2r1 and Rancher 2.8.3
This still fixes it for me.
timeout 1 openssl s_client -connect <IP_ADDRESS>:10259 -showcerts 2>&1 | grep -A 19 -m 1 'BEGIN CERTIFICATE' | sudo tee /var/lib/rancher/rke2/server/tls/kube-scheduler/kube-scheduler.crt
timeout 1 openssl s_client -connect <IP_ADDRESS>:10257 -showcerts 2>&1 | grep -A 19 -m 1 'BEGIN CERTIFICATE' | sudo tee /var/lib/rancher/rke2/server/tls/kube-controller-manager/kube-controller-manager.crt

Also seeing the same issues using Rancher v2.8.3 during an upgrade from RKE2 v1.27.6+rke2r1 to v1.27.13+rke2r1

To add some additional context, we managed to upgrade each patch version from v1.27.6+rke2r1 to v1.27.12+rke2r1 without any issues. The problem for us is introduced with the change set between v1.27.12+rke2r1 and v1.27.13+rke2r1.

We are also facing this same issue.
Racher Version: v2.8.4

Hosted via Docker on Ubuntu Server 24.04 LTS

Cluster Config:

Tested Kubernetes Version: v1.28.9+rke2r1 and v1.26.15+rke2r1
Tested Container Network: Calico and Cilium

All Nodes and the rancher server are hosted on Hyper-V using Ubuntu Server LTS 24.04 within the same V Switch.

For me it was VPS provider firewall

@asaura08
hmmm maybe then it was net policies for us too...
cc @kgtw

Had the same issue with ubuntu 22.04.
If you started rancher server with docker run, please note the version compatibility of rancher and docker, see here: https://www.suse.com/suse-rancher/support-matrix/all-supported-versions/rancher-v2-8-5/,
For example, rancher 2.8.5, when I use docker 27.1.1, it's not OK, but when I switch to docker 24.0.9 , it's OK.

In my case, the issue was likely related to networking. Although I haven't fully researched it yet, it seems that the server I tried to register could reach Rancher but couldn't access the internet (both are in the same subnet), possibly due to a misconfigured default gateway

In my case, the issue was likely related to networking. Although I haven't fully researched it yet, it seems that the server I tried to register could reach Rancher (the server and rancher are in the same subnet) but couldn't reach the internet, likely due to a misconfigured default gateway.

How did you solve this problem?

In my case, the issue was likely related to networking. Although I haven't fully researched it yet, it seems that the server I tried to register could reach Rancher (the server and rancher are in the same subnet) but couldn't reach the internet, likely due to a misconfigured default gateway.

How did you solve this problem?

I fixed the internet connectivity by fixing the default route (I had two, I had to remove the incorrect one using ip route del default via <IP_ADDRESS> command). This is very specific to my setup, however, the gist is that if you get this issue - check you internet, ensure your machine can download k3s/rke.

It might not be related to the exact same problem that OP had, but our problem was resolved after removing the extra host-path mounts for control-plane components. Something changed between v1.27.12+rke2r1 and v1.27.13+rke2r1 where automatic discovery was happening for host-paths based on the components args/configuration inside the containers, this was resulting in multiple mounts within the pod spec for the same paths.
Removing the following configuration from RKE2 configuration was the fix:

kube-apiserver-extra-mount
kube-scheduler-extra-mount
kube-controller-manager-extra-mount
kube-proxy-extra-mount
etcd-extra-mount

Had the same issue with ubuntu 22.04. If you started rancher server with docker run, please note the version compatibility of rancher and docker, see here: https://www.suse.com/suse-rancher/support-matrix/all-supported-versions/rancher-v2-8-5/, For example, rancher 2.8.5, when I use docker 27.1.1, it's not OK, but when I switch to docker 24.0.9 , it's OK.

Many thanks. I followed your suggestion and it worked (docker 26.0.1, Ubuntu 24.04)

I met there is a scene and the type of situation, I use the docker run to start the rancher, started using the parameters - e CATTLE_SYSTEM_DEFAULT_REGISTRY=harbor.xxx.com: 55001/proxy_dockerhub.

This parameter ensures that my rancher server pulls images from my private repository, which is built with goharbor. When I was at the rancher UI new cluster, there is a registries parameters, will be the default fill harbor.xxx.com: 55001/proxy_dockerhub, I use the default.

When a node is added to a cluster, My journalctl -xu rancher-system-agent -f repeatedly error Certs and the directory/var/lib/rancher/rke2 / server/TLS/kube - the scheduler and The/var/lib/rancher/rke2 / server/TLS/kube - controller - manager missing, then I found the/var/lib/rancher/rke2/server/TLS not generated.

At the same time, I noticed that rancher-system-agent would start the rke2-server service, so I looked at journalctl -xu rke2-server-f, I see the error level=fatal msg="failed to parse system-default-registry: registries must be valid RFC 3986 URI authorities: Harbor.xxx.com: 55001/proxy_dockerhub, rk2 server did not rise.

At this point I realized that there was a registry format problem, that the url should not have a path behind it, and when I used docker registry to rebuild a proxy and support https, everything went back to normal. Of course, registries also supports other advanced parameters when adding cluster, which can also solve this problem, but I didn't realize it at the time.

I wonder if we should perform a matching and interception on rancher ui to ensure that registry meets the format requirements, or check and report errors in Rancher-system-agent

[ ] docker: 24.0.9

[ ] rancher: 2.8.5

[ ] rke2: v1.28.11+rke2r1

Have to go back to this issue =))) When a master node is added on same as the machine that installed rancher, it runs OK but when register another machine to the cluster, it stills stuck at [INFO ] configuring bootstrap node(s) custom-ff8710372642: waiting for probes: etcd, kube-apiserver, kube-controller-manager, kube-scheduler, kubelet.
On the node that i want to add, the rke2-server is failed to start with this log:
Aug 19 07:58:31 k8s03 systemd[1]: rke2-server.service: Unit process 241451 (containerd-shim) remains running after unit stopped.
Aug 19 07:58:31 k8s03 systemd[1]: Failed to start Rancher Kubernetes Engine v2 (server).

And the rancher-system-agent just keep repeating [K8s] updated plan secret fleet-default/custom-[number]-machine-plan with feedback as follows
Aug 19 08:08:51 k8s03 rancher-system-agent[250471]: time="2024-08-19T08:08:51Z" level=info msg="[Applyinator] Command sh [-c rke2 etcd-snapshot list --etcd-s3=false 2>/dev/null] finished with err: <nil> and exit code: 1"
Aug 19 08:08:56 k8s03 rancher-system-agent[250471]: time="2024-08-19T08:08:56Z" level=info msg="[K8s] updated plan secret fleet-default/custom-ff8710372642-machine-plan with feedback"
Aug 19 08:08:56 k8s03 rancher-system-agent[250471]: time="2024-08-19T08:08:56Z" level=error msg="[K8s] received secret to process that was older than the last secret operated on. (69678 vs 70659)"
Aug 19 08:08:56 k8s03 rancher-system-agent[250471]: time="2024-08-19T08:08:56Z" level=error msg="error syncing 'fleet-default/custom-ff8710372642-machine-plan': handler secret-watch: secret received was too old, requeuing"
Aug 19 08:11:53 k8s03 rancher-system-agent[250471]: time="2024-08-19T08:11:53Z" level=info msg="[Applyinator] No image provided, creating empty working directory /var/lib/rancher/agent/work/20240819-081153/c8de93a2ee2e8bc39534226a16d3e12a629f7ea58c5d00aa2076b26588c4bf52_0"
Aug 19 08:11:53 k8s03 rancher-system-agent[250471]: time="2024-08-19T08:11:53Z" level=info msg="[Applyinator] Running command: sh [-c rke2 etcd-snapshot list --etcd-s3=false 2>/dev/null]"
Aug 19 08:11:53 k8s03 rancher-system-agent[250471]: time="2024-08-19T08:11:53Z" level=info msg="[Applyinator] Command sh [-c rke2 etcd-snapshot list --etcd-s3=false 2>/dev/null] finished with err: <nil> and exit code: 1"
Aug 19 08:11:58 k8s03 rancher-system-agent[250471]: time="2024-08-19T08:11:58Z" level=info msg="[K8s] updated plan secret fleet-default/custom-ff8710372642-machine-plan with feedback"
Aug 19 08:11:58 k8s03 rancher-system-agent[250471]: time="2024-08-19T08:11:58Z" level=error msg="[K8s] received secret to process that was older than the last secret operated on. (70659 vs 71636)"
Aug 19 08:11:58 k8s03 rancher-system-agent[250471]: time="2024-08-19T08:11:58Z" level=error msg="error syncing 'fleet-default/custom-ff8710372642-machine-plan': handler secret-watch: secret received was too old, requeuing"

idk what just happened but i just simply delete every thing using which with rancher-system-agent, rke2-server and relevant things. After that, delete all that, also delete /var/lib/rancher and systemctl daemon-reload to reset or simply reboot.
Afterwards, re-install rancher, i assume, on node 1. The version that I installed is
- docker: 24.0.9
- rancher: stable (v2.8.5)
- kubernets: v1.28.11 +rke2r1
- ubuntu: 22.04

Install with the given registration on node 2, through stills can't find ca-cert, however, it runs:
Aug 19 14:14:09 k8s03 rancher-system-agent[2673]: time="2024-08-19T14:14:09Z" level=error msg="error while appending ca cert to pool for probe kube-controller-manager"
Aug 19 14:14:09 k8s03 rancher-system-agent[2673]: time="2024-08-19T14:14:09Z" level=error msg="error loading CA cert for probe (kube-scheduler) /var/lib/rancher/rke2/server/tls/kube-scheduler/kube-scheduler.crt: open /var/lib/rancher/rke2/server/tls/kube-scheduler/kube-scheduler.crt: no such file or directory"
Aug 19 14:14:09 k8s03 rancher-system-agent[2673]: time="2024-08-19T14:14:09Z" level=error msg="error while appending ca cert to pool for probe kube-scheduler"
Aug 19 14:14:09 k8s03 rancher-system-agent[2673]: time="2024-08-19T14:14:09Z" level=info msg="[K8s] updated plan secret fleet-default/custom-ff8710372642-machine-plan with feedback"
Aug 19 14:14:09 k8s03 rancher-system-agent[2673]: time="2024-08-19T14:14:09Z" level=error msg="error loading CA cert for probe (kube-controller-manager) /var/lib/rancher/rke2/server/tls/kube-controller-manager/kube-controller-manager.crt: open /var/lib/rancher/rke2/server/tls/kube-controller-manager/kube-controller-manager.crt: no such file or directory"
Aug 19 14:14:09 k8s03 rancher-system-agent[2673]: time="2024-08-19T14:14:09Z" level=error msg="error while appending ca cert to pool for probe kube-controller-manager"
Aug 19 14:14:09 k8s03 rancher-system-agent[2673]: time="2024-08-19T14:14:09Z" level=error msg="error loading CA cert for probe (kube-scheduler) /var/lib/rancher/rke2/server/tls/kube-scheduler/kube-scheduler.crt: open /var/lib/rancher/rke2/server/tls/kube-scheduler/kube-scheduler.crt: no such file or directory"
Aug 19 14:14:09 k8s03 rancher-system-agent[2673]: time="2024-08-19T14:14:09Z" level=error msg="error while appending ca cert to pool for probe kube-scheduler"
Aug 19 14:14:14 k8s03 rancher-system-agent[2673]: time="2024-08-19T14:14:14Z" level=info msg="[K8s] updated plan secret fleet-default/custom-ff8710372642-machine-plan with feedback"
Aug 19 14:16:21 k8s03 rancher-system-agent[2673]: time="2024-08-19T14:16:21Z" level=info msg="[K8s] updated plan secret fleet-default/custom-ff8710372642-machine-plan with feedback"

There also some references useful for me: 41125, compatible version and certification
Pardon me if i'm wrong :sweat_smile: and my markdown is a little bit limited :stuck_out_tongue:

I'm experiencing this with a customer attempting to create a k3s cluster via Rancher.
k3s 1.30.6
Rancher 2.9.2
rancher-system-agent[1637075]: time="2024-12-10T14:33:17-05:00" level=error msg="error loading CA cert for probe (kube-scheduler) /var/lib/rancher/k3s/server/tls/kube-scheduler/kube-scheduler.crt: open /var/lib/rancher/k3s/server/tls/kube-scheduler/kube-scheduler.crt: no such file or directory"

In fact /var/lib/rancher/k3s/server/tls/kube-scheduler/kube-scheduler.crt does not exist in this environment, and all other certs necessary do exist.
Here are some lines from the provisioning log in Rancher
[INFO ] waiting for at least one control plane, etcd, and worker node to be registered
[INFO ] waiting for viable init node
[INFO ] configuring bootstrap node(s) custom-9bdc82db3aed: waiting for agent to check in and apply initial plan
[INFO ] configuring bootstrap node(s) custom-9bdc82db3aed: error applying plan -- check rancher-system-agent.service logs on node for more information, waiting for agent to check in and apply initial plan

Reading through the thread here it seems there isn't in a consensus on what can cause this problem directly other than "network issues". I was able to recreate the issue in my lab reusing a node from a previous cluster and then using a node with a clean install the node joins successfully, not sure what the common denominator is.

I'm experiencing this with a customer attempting to create a k3s cluster via Rancher.
k3s 1.30.6 Rancher 2.9.2
rancher-system-agent[1637075]: time="2024-12-10T14:33:17-05:00" level=error msg="error loading CA cert for probe (kube-scheduler) /var/lib/rancher/k3s/server/tls/kube-scheduler/kube-scheduler.crt: open /var/lib/rancher/k3s/server/tls/kube-scheduler/kube-scheduler.crt: no such file or directory"

In fact /var/lib/rancher/k3s/server/tls/kube-scheduler/kube-scheduler.crt does not exist in this environment, and all other certs necessary do exist.
Here are some lines from the provisioning log in Rancher
[INFO ] waiting for at least one control plane, etcd, and worker node to be registered
[INFO ] waiting for viable init node
[INFO ] configuring bootstrap node(s) custom-9bdc82db3aed: waiting for agent to check in and apply initial plan
[INFO ] configuring bootstrap node(s) custom-9bdc82db3aed: error applying plan -- check rancher-system-agent.service logs on node for more information, waiting for agent to check in and apply initial plan

Reading through the thread here it seems there isn't in a consensus on what can cause this problem directly other than "network issues". I was able to recreate the issue in my lab reusing a node from a previous cluster and then using a node with a clean install the node joins successfully, not sure what the common denominator is.

Follow Certification did solve the problem for me. Here is my path to it.


Subject Area term category and glossary apis should be able to take a project parameter

Hi @immmus , I wonder if you would like to do this this issue. I would like it if the subject area API for Term, Category and glossary (and their subtypes) could take an optional project summary attribute, in a similar way to the way we pass in an associated Glossary.  So for example Term would have an extra
private GlossarySummary glossary =null;
private ProjectSummary project =null;
The glossary author view services would need to be updated in line with this.
After this issue is in,  I will then enhance the presentation server to pass in a glossary project when I create Terms , Categories or Glossary.

Hi @immmus , I wonder if you would like to do this this issue. I would like it if the subject area API for Term, Category and glossary (and their subtypes) could take an optional project summary attribute, in a similar way to the way we pass in an associated Glossary. So for example Term would have an extra
private GlossarySummary glossary =null;
private ProjectSummary project =null;
The glossary author view services would need to be updated in line with this.
After this issue is in, I will then enhance the presentation server to pass in a glossary project when I create Terms , Categories or Glossary.
The server would then create the relationship to the project and the caller would not need to issue more than one api call.
The javadoc will need to updated as part of this change and appropriate new error messages be added and the FVT enhanced
Let me know and I will assign you the issue.

Hi @davidradl, I until I do not quite understand what exactly is meant by Project entities and how in general Term, Category and Glossary should interact with it :(

If you will tell me more details about this and I will understand I will try to do it with pleasure:)

@immmus  Great:-) As background,  there is a user interface called the presentation server (written is javascript - you do not need to change this !). It calls Subject Area view services (OMVS) that calls subject Area Access services (OMAS). In the Ui we set a default glossary and a default project.
At the moment when we create a Term we supply a Term object (you will have seen this in the code I think). the create Term supplies a json payload like this
{
"name":"BBB2 Attr",
"description":"test term 2 ",
"spineAttribute": true,
"glossary":
	{

	"guid":"4491ee7e-da36-419f-8ba3-af7d87a04a73"
	}
}

I would like to extent the Term object so it could be created like this :
{
"name":"BBB2 Attr",
"description":"test term 2 ",
"spineAttribute": true,
"glossary":
	{

	"guid":"4491ee7e-da36-419f-8ba3-af7d87a04a73"
	}
},
"project":
	{
	"guid":"4491ee7e-da36-419f-8ba3-af7da04a7344"
	}
}

you will notice that Term is defined like this
public class Term extends GovernedNode implements Serializable {
    private static final Logger log = LoggerFactory.getLogger(Term.class);
    private static final String className = Term.class.getName();

    private String summary =null;
    private String abbreviation =null;
    private String examples =null;
    private String usage =null;

    private GlossarySummary glossary =null;

The ideas being that the caller only needs to issue one call (createTerm) rather than 2 (create term and create project scope relationship).
So we need to create a new class ProjectSummary (similar to GlossarySummary)
And Add this line to Term ProjectSummary project=null;
Be aware Terms have a subtype activity and Project has a sub type GlossaryProject - that the caller should be using.
In the same way we should add a ProjectSummary to Category and Glossary, and allow the containing entity to be updated / replaced with it.
Does this make sense? I am hoping to make use of the this parameter in the UI.
Note that internally the project attribute in Term should be mapped to a ProjectScope relationship - which we you will need to create. See what we do for glossary in createTerm in SubjectAreaTermHandler.
I am hoping to have this in place in the next couple of weeks is that going to be ok - if you do not have time - I can do it.

@immmus Great:-) As background, there is a user interface called the presentation server (written is javascript - you do not need to change this !). It calls Subject Area view services (OMVS) that calls subject Area Access services (OMAS). In the Ui we set a default glossary and a default project.
At the moment when we create a Term we supply a Term object (you will have seen this in the code I think). the create Term supplies a json payload like this
{
"name":"BBB2 Attr",
"description":"test term 2 ",
"spineAttribute": true,
"glossary":
	{

	"guid":"4491ee7e-da36-419f-8ba3-af7d87a04a73"
	}
}

I would like to extent the Term object so it could be created like this :
{
"name":"BBB2 Attr",
"description":"test term 2 ",
"spineAttribute": true,
"glossary":
	{

	"guid":"4491ee7e-da36-419f-8ba3-af7d87a04a73"
	}
},
"project":
	{
	"guid":"4491ee7e-da36-419f-8ba3-af7da04a7344"
	}
}

you will notice that Term is defined like this
public class Term extends GovernedNode implements Serializable {
    private static final Logger log = LoggerFactory.getLogger(Term.class);
    private static final String className = Term.class.getName();

    private String summary =null;
    private String abbreviation =null;
    private String examples =null;
    private String usage =null;

    private GlossarySummary glossary =null;

The ideas being that the caller only needs to issue one call (createTerm) rather than 2 (create term and create project scope relationship).
So we need to create a new class ProjectSummary (similar to GlossarySummary)
And Add this line to Term ProjectSummary project=null;
Be aware Terms have a subtype activity and Project has a sub type GlossaryProject - that the caller should be using.
In the same way we should add a ProjectSummary to Category and Glossary, and allow the containing entity to be updated / replaced with it.
Does this make sense? I am hoping to make use of the this parameter in the UI.
Note that internally the project attribute in Term should be mapped to a ProjectScope relationship - which we you will need to create. See what we do for glossary in createTerm in SubjectAreaTermHandler.
I am hoping to have this in place in the next couple of weeks is that going to be ok - if you do not have time - I can do it.

Hi, now I'm doing other task, but I will try to do it. If I will have problems I will inform )
Just as I understand it, project should not be a mandatory parameter for creating entities, because not everyone needs it. Correctly?

@immmus Yes - project is not mandatory parameter.
If we get a Term / category glossary and it has a project we should include it in the response

Hi @davidradl , while thinking over the best way to accomplish this, I wondered: "Do you need to check when creating the Term or Category the compliance of the Glossary project and the specified projects when creating the above entities?"
For example we can see below at slide that ParentCategory's glossary and ChildCategory's glossary are different. It's normal??

@immmus Sorry I have just spotted your question. A parent category does not need to be in the same glossary as the child category. We want it to be flexible. For example there may be a glossary with top level categories in and the glossaries per country that include country specific child categories. This will all depend on how an organization arranges its semantic data. Egeria has suggested using subject areas which is one way to arrange semantic information we think can be used effectively for governance. Also a term does not need to be in same glossary as the categories it belongs to.

@immmus Sorry I have just spotted your question. A parent category does not need to be in the same glossary as the child category. We want it to be flexible. For example there may be a glossary with top level categories in and then have glossaries per country that include country specific child categories. This will all depend on how an organisation arranges its semantic data. Egeria has examples of using subject areas, which is one way to arrange semantic information we think can be used effectively for governance. Also a term does not need to be in same glossary as the categories it belongs to.

Okay. Thank you)


Check CI pipelines don't contain secrets

Before we make the CI pipelines public, we should ensure the output of all CI pipelines doesn't contain secrets.
Master is already checked, we need to check all the others.

I've checked all the pipelines and found only one instance of a pipeline containing secret: Packet pipelines were printing the API token to stdout. I fixed that and rotated the token.
I think we're ready to make the pipelines public. I'll do that now.


Enable/disable sound notification setting

It would be great to have a slider to turn on/off sound notifications. And also to choose a custom sound to play.

yeah, please upgrade to the latest release
https://github.com/eatgrass/obsidian-pomodoro-timer/releases/tag/1.0.6

Excellent, thanks a lot!
What if turning off notification sound would also hide custom sound setting?

Hi @vaygr

What if turning off notification sound would also hide custom sound setting?

If you turn off the notification sound, it simply mutes all notifications. no matter if you've got a custom sound set up or not.

Yeah, I understand. That's just to make settings page look neater. Similar to what happens to logging when you set it to None.

Thanks, that's a good suggestion, will do it in the next release


[Hotfix] Dragging a file or folder onto a file now uploads to its parent.

Purpose
Fixes #3509
If drop target is a file change the target to its parent.

Closed in favor of https://github.com/CenterForOpenScience/osf.io/pull/3523


botbuilder-ai is incompatible with QNA maker v5.0-preview.1

My bot is unable to generate an answer from QNA Maker v5.0-preview.1 because the auth headers sent by the botbuilder-ai library are not compatible with the headers that the preview QNA Maker is expecting.
Example
The botbuilder-ai currently sends the following auth headers:
"Authorization": f"EndpointKey {endpoint.endpoint_key}",
"Ocp-Apim-Subscription-Key": f"EndpointKey {endpoint.endpoint_key}",

however, the v5.0-preview.1 QNA Maker only expects the following auth header:
"Ocp-Apim-Subscription-Key": "<endpoint-key>",

Basically, the string "EndpointKey " before the actually key is redundant with v5.0-preview.1 version as defined in the QNA Maker Docs.
Version
4.13.0
Describe the bug
QNA Maker preview handles auth headers differently than previous versions.
To Reproduce
Steps to reproduce the behavior:

Create a qna maker bot. Even though the sample uses version: 4.11.0 the error is still applicable.
Retrieve your QNA Maker v5.0-preview.1 endpoint, key and KB info and store them as env variables.
Run your bot and connect to it using the bot framework emulator.
Ask a question.

Expected behavior
The qna maker bot should be able to talk to QNA Maker regardless of its version.
Additional context
I will submit a PR for your consideration.

@Fl4v you are correct in that the SDK doesn't support v5 preview version of the QnA Maker API, however this is not unusual--generally, we don't fold in APIs that are still in preview, because of their instability--if they change something, it could break us, and then in turn customers down the line.
See:

Add Microsoft.QnAMakerDialogV2 action to consume qnamaker v5.0 runtime API issue to track progress of when we bring support to v5 QnA APIs
Facing Issue while hitting QnA Service using botbuilder-ai on how to use the latest GA API (v4) of QnA Maker with our SDK

As for your PR, thank you for looking into the SDK, however I don't see the team taking this right now, given the above. Additionally, the changes you suggest would break as soon as QnA Maker API changes to a different version, whether it be GA v5 or preview.2, for example.
If you are keen on using v5-preview version of QnA API right now, then you are more than welcome to clone a copy of the python SDK and implement your custom changes yourself, and use the custom SDK in your bot

Hi @Zerryth, no worries, thanks for your reply. I have closed my PR. I might send a new one for better error handling.


Allow for GPU-ID specification on CLI

Closes https://github.com/huggingface/accelerate/issues/543 by adding a --gpu_ids param to both the CLI as well as config, and has the CLI launcher utilize it as a result. This essentially just sets CUDA_VISIBLE_DEVICES dynamically before launching code
If need for it to occur in notebook_launcher is desired, I'll expand this further

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@pacman100 correct, this is solely for NVIDIA GPUs, I'll specify that in the info description for it


example with HTTP2_PLAIN doesn't work

I get this error:
    throw new Error('options.pfx or options.key and options.cert are required!
          ^
Error: options.pfx or options.key and options.cert are required!
    at Object.createServerTLS [as createServer] (/Users/davidbjorklund/projects/foo/node_modules/http2/lib/http.js:564:11)
    at Object.<anonymous> (/Users/davidbjorklund/projects/foo/node_modules/http2/example/server.js:20:20)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Function.Module.runMain (module.js:497:10)
    at startup (node.js:119:16)
    at node.js:906:3

is  { plain: true } not supported?

The example is fixed but the documentation around server still exists.  It is unclear that your default server is TLS unless you look at the exports and see it mapped to TLS.  The confusion is further compounded by the documentation in the same file http.js.  It says you can pass either.  Which is true for the function, but not for what is exported.   These comments are called the public API but this really is not true or is out of date.

@molnarg The documentation needs updating. {plain: true} (as other have pointed out) does not work. To start a server that accepts connections over TCP user needs to use http2.raw.createServer(handler).


Limit de $q_orders results

We limit this query to avoid having an IN query with thousands of unnecessary order ids.
I have multiplied the limit by 4 to minimize the case where products have been disabled.
But having hundreds of IDs in the order ID list or thousands or even hundred of thousands ID in this list (for big shops) make the whole difference between a query that runs a few ms and a query that runs for seconds.
Fixes PrestaShop/PrestaShop#20874

Hello I created this issue here : https://github.com/PrestaShop/PrestaShop/issues/20874
I'm adding ORDER BY RAND() because of the ORDER BY RAND() present in the query for the products line 306.
If I don't add the ORDER BY RAND() in the first query it will always select the same orders to find cross sellings from.

Here you have also the pull request for the core : https://github.com/PrestaShop/PrestaShop/pull/20916

Hi @djbuch,
Please resolve the Conflicting files.
Thanks!

Hello
Since we had no news from you for more than 30 days, I'll close this pull request. Feel free to ask to re-open when it will be possible to fix the conflicting file
Thank you!


Authentication failed on sending a mail

I can login and receiving mails with no problem
but when I want to send a new message it gives me "Authentication failed"
in the JS console the resposne is error code Json {"Action":"SendMessage","Result":false,"ErrorCode":102,"ErrorMessage":"","Time":56}
if I goes into other webmail like virtualmin I can send mails with no problem ...
thanks,

Using php mail() function (beta in <IP_ADDRESS>) is a workaround that issue.

The problem seems fixed for me.  Maybe OVH changed its settings or there was a bug and it has been fixed.

Just try with my OVH server, and still get the same error message...

Just try with my OVH server, and still get the same error message...

It is working for me also. Good news ! @Think-It did you update your rainloop ?

@grotesque42 : Yes, I've v<IP_ADDRESS>. Good, no ?

Anyone with this issue ?

Yes, I have met a similar problem when using a mail function.

@Think-It  I have the same version and it works but without the php mail. Here is my configuration which is working well :

Like @grotesque42, no more problem with SMTP in v<IP_ADDRESS> ! Thanks !

@grotesque42 : I'm using my own imap/smtp server.
I have try to set "localhost" or "mydomain.com". The "TEST" button become green each time I try it.
By the way, my config work perfectly with Thundetbird and my email app on Android. =(

@grotesque42 : I'm using my own imap/smtp server.
I have try to set "localhost" or "mydomain.com". The "TEST" button become green each time I try it.
By the way, my config work perfectly with Thundetbird and my email app on Android. =(

@Think-It  I can't help you, I am using OVH shared server... good luck.

Hi,
sorry to come back to it but I have the same problem.
Installed Rainloop on an OVH mutualized web hosting.
I have the message "Authentication failed" randomly:
Next exception 'MailSo\Smtp\Exceptions\LoginBadCredentialsException' with message '555 sorry, too many emails [mail137] (#5.7.1)'
This message is surprising as I don't have a limited number of email allowed and mostly because I don't send a lot of emails (4 or 5 max a day).

There is a real  authentication issue with some server configs (especially on OVH servers).
The Rainloop team should investigate on it.

Yes... I'm back with the same problem again....(ovh shared hosting, last version of RainLopp, failed authentification).

I have same problem with this logs
SMTP[NOTICE]: exception 'MailSo\Smtp\Exceptions\LoginBadMethodException' with message 'MailSo-Smtp-Exceptions-LoginBadMethodException (SmtpClient.php ~ 264)' in /var/www/webmail/rainloop/v/<IP_ADDRESS>3/app/libraries/MailSo/Smtp/SmtpClient.php:264

UP ?

I am facing the same problem above. Could we reopen the issue?


Add the ability to get the full header vertx-web matched when a route is selected

Current
Currently, Vert.x-web only matches Accept and Content-Type headers by their main component as specified in the MIME type specification.
Vert.x's API is only capable of returning the portion of the Content-Type that was matched ignoring all the parameters that were sent among the MIME type.
Problem
If I want to make a program that handles different output depending on the MIME type, I have to process the accept header myself searching for the matched Content-type.
Use Cases
These are hypothetical use-cases I see for implementing this.

Different handlers for different charsets.
Different handlers for different API versions for that Content-Type (or Accept). Minimalistic example:
Content-Type: application/json;v=1
{
"thing1" : {
"thing1.1" : "a",
"thing1.2" : "b"
},
"thing2" : {
"thing2.1" : {
"thing2.1.1" : "c"
}
}
}

vs:
Content-Type: application/json;v=2
{
	"thing1.1" : "a",
	"thing1.2" : "b",
	"thing2.1.1" : "c"
}

I can do this if you accept
I've seen Vert.x's code where it parses the Content-Type header and I have an idea how to implement this such that, if no parameters are specified in either Route.produces() or Route.consumes(), it should not get any significant performance loss.
I'm open for any questions you may have about this.

Wrong project

Wrong project. Moved to: https://github.com/vert-x3/vertx-web/issues/442


NLL numbers on popular datasets

Can anyone report the NLL numbers on popular datasets like CIFAR-10, ImageNet, and CelebA? My results are different in scale from those reported in the literatures.

In CelebA-HQ  I got -6.5.


Not checking all lease entries

In the get_lease_info function you construct a get request for only one lease, but a single IP address can have multiple lease entries. The CLTT for the leases (for the same IP address) it not guaranteed to be the same.
The fix should be to retrieve them all for a given IP address and go through them to find the newest CLTT.

Agreed, I've enhanced the check_in_use() method to check for multiple leases, but also if the match_client is MAC_ADDRESS I am verifying the lease is for the same Mac/hardware address. (v0.1.2) Please verify that this appears to be working in your environment as expected. Thank you for the feedback.

By the way I have also updated the output to support CSV (to file) or table to console.

Please re-open if you see any issues


IC-637: Notify Slack after deployments

What does this pull request do?
Notify Slack after deployments.
They will look similar to

What is the intent behind these changes?
To raise awareness when deployments happen (and fail (although that does not seem to work yet)).

Thank you!


chore: fix dev clickhouse migrations & storage engine

Fixes RVT-4061

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1350  👈
#1348
#1347
#1345
#1344
#1343
#1342
#1341
#1340
#1339
#1338
#1337
#1336
#1335
#1334
#1333
#1332
#1329
#1328
#1327
#1322
#1321
#1320
#1319
#1318
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @NathanFlurry and the rest of your teammates on  Graphite


Develop tests for alt_allele_prob_file and est_alt_allele_prob with multiple metafounders

@RosCraddock @gregorgorjanc
Relate to #142, #149
Tasks to do:

[x] A functional test to see if we can read alternative allele frequency and estimate the alternative allele frequency correctly for one or more than one metafounders.

Subtest Name
alt_allele_prob_file
est_alt_allele_prob
main_metafounder
Description
Complete

default
x
x
x
Test the default values of the alternative allele frequency without any input or estimation with multiple metafounders
√

alt_allele_prob_file_single
√
x
x
Test the input option alt_allele_prob_file for a single metafounder, we need the test output to be different when the alt_allele_prob_file is given
√

alt_allele_prob_file_multiple
√
x
x
Test the input option alt_allele_prob_file for multiple metafounders, we need the test output to be different when there is only a single metafounder
√

est_alt_allele_prob_single
x
√
x
Test the option est_alt_allele_prob for a single metafounder, we need a test data input such that we can infer exact alternative allele frequency from it
√

est_alt_allele_prob_multiple
x
√
x
Test the option est_alt_allele_prob for multiple metafounders, we need a test data input such that we can infer exact alternative allele frequency from it and test output to be different when there is only a single metafounder
√

both
√
√
x
Test the case when both options are used, whether the inputted alternative allele probabilities are used as a starting point for alternative allele probabilities estimation
√

incorrect_pedigree
√
x
x
Test case when a metafounder is written incorrectly as not a founder in the pedigree file
√

default_metafounder
x
x
x
Test case when 0 is being used as parents and no main metafounder is being provided as input, test whether 0 would be replaced by the default MF_1
√

main_metafounder
x
x
√
Test if the input option main_metafounder is working, requiring an input pedigree file with both metafounders and 0 as parents
√

incorrect_main_metafounder
x
x
√
Test case when the input meta_founder does not start with MF_, whether an error would be raised
√

incorrect_metafounder_in_file
√
x
x
Test case when the names of input metafounders in the input alternative allele probability file do not start with MF_, whether an error would be raised
√

[ ] Additional accuracy tests to see if the provided/estimated alternative allele frequency can improve the accuracy:

[ ] a test with single metafounder and user-provided alternative allele frequency
[ ] a test with multiple metafounder and user-provided alternative allele frequency
[ ] a test with multiple metafounder and estimated alternative allele frequency

Best if @RosCraddock works on this alongside you @XingerTang

@RosCraddock @gregorgorjanc
Relate to #142, #149
Tasks to do:

[x]  A functional test to see if we can read alternative allele frequency and estimate the alternative allele frequency correctly for one or more than one metafounders.

Subtest Name	alt_allele_prob_file est_alt_allele_prob main_metafounder	Description	Complete
default	x	x	x	Test the default values of the alternative allele frequency without any input or estimation with multiple metafounders	√
alt_allele_prob_file_single	√	x	x	Test the input option alt_allele_prob_file for a single metafounder, we need the test output to be different when the alt_allele_prob_file is given	√
alt_allele_prob_file_multiple	√	x	x	Test the input option alt_allele_prob_file for multiple metafounders, we need the test output to be different when there is only a single metafounder	√
est_alt_allele_prob_single	x	√	x	Test the option est_alt_allele_prob for a single metafounder, we need a test data input such that we can infer exact alternative allele frequency from it	√
est_alt_allele_prob_multiple	x	√	x	Test the option est_alt_allele_prob for multiple metafounders, we need a test data input such that we can infer exact alternative allele frequency from it and test output to be different when there is only a single metafounder	√
both	√	√	x	Test the case when both options are used, whether the inputted alternative allele probabilities are used as a starting point for alternative allele probabilities estimation	√
incorrect_pedigree	√	x	x	Test case when a metafounder is written incorrectly as not a founder in the pedigree file	√
default_metafounder	x	x	x	Test case when 0 is being used as parents and no main metafounder is being provided as input, test whether 0 would be replaced by the default MF_1	√
main_metafounder	x	x	√	Test if the input option main_metafounder is working, requiring an input pedigree file with both metafounders and 0 as parents	√
incorrect_main_metafounder	x	x	√	Test case when the input meta_founder does not start with MF_, whether an error would be raised	√
incorrect_metafounder_in_file	√	x	x	Test case when the names of input metafounders in the input alternative allele probability file do not start with MF_, whether an error would be raised	√

[ ]  Additional accuracy tests to see if the provided/estimated alternative allele frequency can improve the accuracy:

[ ]  a test with single metafounder and user-provided alternative allele frequency
[ ]  a test with multiple metafounder and user-provided alternative allele frequency
[ ]  a test with multiple metafounder and estimated alternative allele frequency

Additional Accuracy Tests:

a test with single metafounder and user-provided alternative allele frequency
a test with multiple metafounder in segregated lineages and user-provided alternative allele frequency
a test with multiple metafounder with overlapping lineages and user-provided alternative allele frequency
a test with multiple metafounder in segregated lineages and estimated alternative allele frequency
a test with multiple metafounder iwith overlapping lineages and estimated alternative allele frequency


Multi-line Julia Code

When working in VSCode, multi-line code runs if you run the whole cell, but if the code is split over multiple lines and you use the CMD + Enter / Ctrl + Enter to run a single-line, it only attempts to run the one line and breaks.
With the chunk below, hitting Ctrl+Enter on the first line:
randn(
    10
)

Results in this error:
julia> randn(
ERROR: syntax: incomplete: premature end of input
Stacktrace:
 [1] top-level scope
   @ code:1

Multi-line but not whole-chunk execution would be very handy. Thanks for the great plugin so far though!

I believe this problem also occurs outside of Julia.
I was editing R the other day and needed to run it in code block units.

Yes in both cases the plugin doesn't have the syntactic awareness to run the next statement (only lines). I believe in the case of R the interpreter will prompt for the next line but in Julia is yields an error.

I can't verify, but it might be fixed thanks to 0ac9f340a5cf1b9af10aecc097601fb27a98f034 released in v1.54.0.

No, this doesn't yet work for Julia. I tried to make it work by executing the language-julia.executeCodeBlockOrSelectionAndMove command from the Julia extension, however an error occurred (it may be that it didn't like that qmd rather that jl was where the command was executed from)

I asked a similar question in Quarto CLI: https://github.com/quarto-dev/quarto-cli/discussions/3679
Do we have a solution to execute multiline statement like in RStudio?


"Unirea" is listed in the drop-down menu

Description:
"Unirea" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Unirea" in the search bar.

Expected results
The location is listed in the drop-down menu as "Unirea, Alba (Unirea)".


2 Algorithms added

Added 2 algorithms under array section:
1. Binary search in an array
2. Largest Sum Contiguous Subarray (Kadane's Algorithm)

Added explanation


Arming via ring alarm pad and opening a door triggers the need to bypass the sensors

Alarmo Version
v1.9.6
HA Version
2022.10.2
Bug description
So I'm using a ring keypad to control my alarmo instance, and when I arm the alarm in away mode, and open a door that has a an aqara magnet sensor mounted to it, the ring keypad goes into a state where it asks for confirmation to bypass the sensor. I assume this has to do with something in alarmo as I noticed the same behaviour a while back when a change was made to define a sensor as a door or a tamper and I accidentally had it set as a tamper
Steps to reproduce

Arm alarmo via the ring keypad, pressing the "away" button
Opening any door that has a magnet sensor connected to it.

Relevant log output
No response

I found the "use exit delay" when looking at the advanced settings.


Add github deployment to Travis

It seems redundant to store release .jar files both on Maven Central and Github.


Scroll to top using status bar does not work in iOS 13

You can test on https://github.com/cozzin/Toaster/tree/feature/scrollToTopIssue

Struggling with the same issue.

This issue is resolved in iOS 13.2


Floating point exception (core dumped) with onednn opt on tensorflow backend

As shown in this colab, the kernel, not the program, crashes if the OneDNN OPT is on and the output tensor shape contains a zero dimension.
As discussed in tensorflow/tensorflow#77131, and also shown in the above colab, we found that the error disapeared after downgrading from keras 3.0 to keras 2.0.
Therefore, I think some errors are introduced when updating from keras 2.0 to keras 3.0.

Hi @Shuo-Sun20 -
Thanks for reporting the issue. But this issue because of  floating-point round-off approaches to different numerical result when trying to enable oneDNN optimizations with tensorflow.
By changing this line os.environ['TF_ENABLE_ONEDNN_OPTS'] = '1' to os.environ['TF_ENABLE_ONEDNN_OPTS'] = '0' will resolve the error.
As this issue is more related to tensorflow-core onednn, so you can raise new issue in tensorflow repo.


Merge branch 'main' into doc-latest

main:
(maint) Add 8.1.1 release notes
(maint) Elaborate on 8.1.0 release notes
(maint) Elaborate on 7.14.0 release notes
Set clj-parent=5.5.1
(PDB-5675) update supported platforms
(maint) Update version to 8.1.2-SNAPSHOT
(maint) Update version to 8.1.1 for release

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.3 out of 4 committers have signed the CLA.:white_check_mark: steveax:white_check_mark: austb:white_check_mark: jonathannewman:x: rbrwYou have signed the CLA already but the status is still pending? Let us recheck it.


Change details view orientation and hide columns on resize

Description
New in this PR:

Grids switch to mobile view based on details view size.
Details view now defaults to vertical orientation.
GridColumnManager is now a component. It's easier to update page state and have dispose automatically called when a component.
Resource grid mobile view now hides type and shows state.

Fixes https://github.com/dotnet/aspire/issues/5435
Demo:

[!TIP]
There are a lot of whitespace changes. Best reviewed with whitespace disabled.

Checklist

Is this feature complete?

[x] Yes. Ready to ship.
[ ] No. Follow-up changes expected.

Are you including unit tests for the changes and scenario tests if relevant?

[x] Yes
[ ] No

Did you add public API?

[ ] Yes

If yes, did you have an API Review for it?

[ ] Yes
[ ] No

Did you add <remarks /> and <code /> elements on your triple slash comments?

[ ] Yes
[ ] No

[x] No

Does the change make any security assumptions or guarantees?

[ ] Yes

If yes, have you done a threat model and had a security review?

[ ] Yes
[ ] No

[x] No

Does the change require an update in our Aspire docs?

[ ] Yes

Link to aspire-docs issue:

[x] No

Microsoft Reviewers: Open in CodeFlow

/azp run


Kraken pair issues

I'm having an issue with kraken not getting DASH/EUR pair. Here's the error output:
`Trades error:
Error: Kraken API returned error: Query:Unknown asset pair
at Request._callback (C:\Users\tvasconcelos\Desktop\zenbot\node_modules\kraken-api\kraken.js:155:34)
at Request.self.callback (C:\Users\tvasconcelos\Desktop\zenbot\node_modules\request\request.js:188:22)
at emitTwo (events.js:106:13)
at Request.emit (events.js:191:7)
at Request. (C:\Users\tvasconcelos\Desktop\zenbot\node_modules\request\request.js:1171:10)
at emitOne (events.js:96:13)
at Request.emit (events.js:188:7)
at IncomingMessage. (C:\Users\tvasconcelos\Desktop\zenbot\node_modules\request\request.js:1091:12)
at IncomingMessage.g (events.js:292:16)
at emitNone (events.js:91:20)
at IncomingMessage.emit (events.js:185:7)
at endReadableNT (_stream_readable.js:974:12)
at _combinedTickCallback (internal/process/next_tick.js:80:11)
at process._tickCallback (internal/process/next_tick.js:104:9)
getTrades() returned no trades, --start may be too remotely in the past.`
Anyone with this problem?

If i try backfill and change selector to kraken.DASH-EUR is works and fetches data, but on trade it throws error: could not find product
anyway i can solve this?

solved it by changing the products json on kraken. in the pair DASH / EUR, change ZEUR to EUR

@talvasconcelos Sounds like the same issue I reported here #352. Some of the currency pairs just do not work correctly in trade, but back-fill appears to work.
The products.json update does not fix this from my experience, #354

Hi, same for me, any solution ?

Kraken API incorrectly reports pairs... which ones are you have problems with?

https://github.com/carlos8f/zenbot/pull/469


CI for unpaired Hedge's g on R and website not matching

Hi there,
Thank you again for making this great package available. I have found that the outcomes for the 95% CI of unpaired Hedge's g shared control comparisons have been consistently different between the web app and R (v0.3.9999), with R giving a slightly wider CI. For instance, for comparisons between groups A and B from the data attached in the csv file, the outcome from R is 0.205 [95CI  -0.833; 1.21] while the website gives 0.205 [95.0%CI -0.74, 1.18]. Could this be another potential bug with R? Which outcome would be the correct one?
DATA.csv
Thanks in advance for your help.

Hi @heathium ,
The web app uses the Python package to produce the output, rather than the R package.
Random number generation is used during the resampling for the CI computation. R and Python have different implementations of their random number generators, such that even setting the same seed will result in different outputs. See here for more info. Thus, the output from dabestr and the web app will never match exactly. (If you want the results to match, consider using the Python package.)
Specifically for your dataset, B only has N=4, so the divergences between R and Python outputs will be greater. In our own testing, with N >= 10, the divergence between the CIs begins after the second decimal place.
Hope this helps,
Joses

Hi Joses,
Thank you so much for answering. I was just concerned seeing that the numbers did not match. I will not worry about it anymore and just use the CI calculated from R.


Network function

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[x] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month. - Aug 2022
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month. - July 2022
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.

[x] SDK of .NET (need service team to ensure code readiness)
[x] SDK of Python
[x] SDK of Java
[x] SDK of Js
[x] SDK of Go
[x] PowerShell
[ ] CLI
[ ] Terraform
[ ] No refresh required for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[x] Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

[x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in a stable version
[ ] Removing properties in a stable version
[ ] Removing API version(s) in a stable version
[ ] Updating API in a stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

The first commit needs to be the previous api version and the new changes should only be added in the subsequent commits. Can you put the older API version as the base in the first commit, and update it to a new version in later commit? So that reviewers can review the diffs between API version.
This is explained in detail here (If using Open API which is recommended) https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/208/OpenAPI-Hub-Adding-new-API-version or here(For manual process) : https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/83/Manual-Process-Adding-new-API-version .
Please remove the "ARMChangesRequested" tag once you have fixed this issue.

The first commit needs to be the previous api version and the new changes should only be added in the subsequent commits. Can you put the older API version as the base in the first commit, and update it to a new version in later commit? So that reviewers can review the diffs between API version.
This is explained in detail here (If using Open API which is recommended) https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/208/OpenAPI-Hub-Adding-new-API-version or here(For manual process) : https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/83/Manual-Process-Adding-new-API-version .
Please remove the "ARMChangesRequested" tag once you have fixed this issue.

I have added 1 commit for the old api version (https://github.com/Azure/azure-rest-api-specs/pull/19888/commits/25d9784cba50b60fa12b262aef7d4da5b50763a7) and another one for the new api version (https://github.com/Azure/azure-rest-api-specs/pull/19888/commits/2be0f35303c3d0ec22e8fec21089a8dd4ccbb2df)

Hi @kukulkarni1 when will the new api-version be deployed?

Hi @kukulkarni1 when will the new api-version be deployed?

Hi @msyyc, ETA for the operation that is failing (/providers/Microsoft.NetworkFunction/operations) is Aug 30th. This is the task: https://msazure.visualstudio.com/One/_workitems/edit/14981956/ . However, this part has not been changed in our new swagger. It is part of the ARM API review tasks that we are working on.


seccomp: relax restrictions depending on --cap-add

Fix #976

@AkihiroSuda out of curiosity, how/why does those changes fix the issue of ptrace failing due to seccomp when we only changed the order of applying certain opts?

@AkihiroSuda out of curiosity, how/why does those changes fix the issue of ptrace failing due to seccomp when we only changed the order of applying certain opts?

Because the seccomp profile generator depends on .Process.Capabilities.Bounding .
https://github.com/containerd/containerd/blob/eaf286224b0144dd11c0e68c131d5dd9ebf52a23/contrib/seccomp/seccomp_default.go#L524


Ecs integration

Hi, we released ShinyProxy 3.1.0 today, which contains full support for ECS. It's based on this contribution, but was extended and fully integration in ShinyProxy. Thank you again for your contribution!


Problem on tutorial get_started.py

When I run the get_started.py tutorial, the following errors occur:
/tools/tvm/dmlc-core/include/dmlc/logging.h:308: [10:48:17] src/codegen/codegen.cc:27: Check failed: bf != nullptr Target cuda is not enabled
It seems that cuda is NOT enabled when tvm is compiled. But I indeed enabled cuda when tvm is compiled. The following is the config.mk file of Tvm:
USE_CUDA = 1
CUDA_PATH = /usr/local/cuda
USE_CUDNN = 1
One more thing which is sure is that cuda is correctly installed at /usr/local/cuda. Other softwares such as torch\tensorflow can run correctly with cuda.
So, what is the problem? Thank you very much.
Other:
OS: ubuntu 14.04
Cuda: 8.0
CuDnn: 5.0

try to do a make clean, and build cuda again. The error message indicates that the CUDA is not enabled, it means this file never get compiled https://github.com/dmlc/tvm/blob/master/src/codegen/build_cuda.cc#L11

Yeah, the problem is CUDA is not enabled. I have re-built it several times before I post this issue.  I also  traced the runtime registry process in which llvm, OpenCL, verilog are all registered except CUDA.
Maybe the last thing I could do is to re-clone it from GitHub.

I solved the problem by directly revising the Makefile.
I now still do not know why the following code in Makefile will NEVER succeed: ifeq ($(USE_CUDA), 1).  When I print the value of USE_CUDA, the output is real 1, but it still will NOT execute the ifeq branch and so the -DTVM_CUDA_RUNTIME=0 will always be set.
Really amazing... Anyone can tell me why?
Anyway, it is a good news.

hmm, i do not know what is happening on your makefile, please let us know if you find a good fix to this issue

for now i am going to close this since the original issue has been resolved

I know why ifeq will always fail: there is a blank after USE_CUDA = 1!  I'm used to delete some characters in vi by x, after which the cursor will forward one character. At this time, if I continue to insert words with out any additional operation, a blank will exist.
So naive mistake!

tvm/src/codegen/codegen.cc:27: Check failed: bf != nullptr Target llvm -device=tracing is not enabled
But the log of make is :
-- Build with RPC support...
-- Build with Graph runtime support...
-- Build VTA runtime with target: sim
-- Found CUDA_TOOLKIT_ROOT_DIR=/usr/local/cuda-9.0
-- Found CUDA_CUDA_LIBRARY=/usr/local/cuda-9.0/targets/x86_64-linux/lib/stubs/libcuda.so
-- Found CUDA_CUDART_LIBRARY=/usr/local/cuda-9.0/lib64/libcudart.so
-- Found CUDA_NVRTC_LIBRARY=/usr/local/cuda-9.0/lib64/libnvrtc.so
-- Found CUDA_CUDNN_LIBRARY=/usr/local/cuda-9.0/lib64/libcudnn.so
-- Found CUDA_CUBLAS_LIBRARY=/usr/local/cuda-9.0/lib64/libcublas.so
-- Build with CUDA support
-- Build with cuDNN support
-- Build with cuBLAS support
-- Use llvm-config=/usr/bin/llvm-config-6.0
-- /usr/lib/llvm-6.0/include
-- Found LLVM_INCLUDE_DIRS=/usr/lib/llvm-6.0/include
-- Found LLVM_DEFINITIONS= -DNDEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS
-- Found TVM_LLVM_VERSION=60
-- Build with LLVM
-- Set TVM_LLVM_VERSION=60
-- Configuring done
-- Generating done
So, it is very strage. Can you any idea ?


mixer lint errors still exist

Even with updating go runtime for linters to 1.9.x (see https://github.com/istio/istio/pull/1798), I see following (possibly new) lint errors for mixer. We should fix this.
mixer/adapter/svcctrl/distValueBuilder.go:42:1:warning: sizeOption is unused (deadcode)
mixer/adapter/svcctrl/handler.go:89:19:warning: method HandleApiKey should be HandleAPIKey (golint)
mixer/adapter/svcctrl/reportbuilder.go:148:1:warning: generateErrorCount is unused (deadcode)
mixer/adapter/svcctrl/reportbuilder.go:156:1:warning: generateBackendLatencies is unused (deadcode)
mixer/adapter/svcctrl/reportbuilder.go:37:1:warning: reportBuilder is unused (deadcode)
mixer/adapter/svcctrl/svcctrl.go:102:49:warning: error strings should not be capitalized or end with punctuation or a newline (golint)
mixer/adapter/svcctrl/svcctrl.go:108:16:warning: error strings should not be capitalized or end with punctuation or a newline (golint)
mixer/adapter/svcctrl/svcctrl.go:114:52:warning: error strings should not be capitalized or end with punctuation or a newline (golint)
mixer/adapter/svcctrl/svcctrl.go:125:25:warning: "postive" is a misspelling of "positive" (misspell)
mixer/adapter/svcctrl/svcctrl.go:43:19:warning: method SetApiKeyTypes should be SetAPIKeyTypes (golint)
mixer/adapter/svcctrl/svcctrl.go:80:49:warning: error strings should not be capitalized or end with punctuation or a newline (golint)
mixer/adapter/svcctrl/svcctrl.go:85:49:warning: error strings should not be capitalized or end with punctuation or a newline (golint)
mixer/adapter/svcctrl/testhelper.go:80:1:warning: mockConsumerProjectIDResolver is unused (deadcode)
mixer/adapter/svcctrl/testhelper.go:92:1:warning: compareJSON is unused (deadcode)
mixer/pkg/adapter/requestData_test.go:53:9:warning: should not use basic type int as key in context.WithValue (golint)
mixer/pkg/cache/cache.go:15:1:warning: package comment should be of the form "Package cache ..." (golint)
mixer/pkg/cache/cache_test.go:91::error: possible formatting directive in Error call (vet)
mixer/pkg/cache/lruCache.go:1:1:warning: package comment should be of the form "Package cache ..." (golint)
mixer/pkg/cache/ttlCache.go:1:1:warning: package comment should be of the form "Package cache ..." (golint)
mixer/pkg/config/handler_test.go:1::warning: file is not gofmted with -s (gofmt)
mixer/pkg/config/handler_test.go:1::warning: file is not goimported (goimports)
mixer/pkg/config/validator.go:1::warning: file is not gofmted with -s (gofmt)
mixer/pkg/config/validator.go:1::warning: file is not goimported (goimports)
mixer/pkg/config/validator.go:794::warning: line is 163 characters (lll)
mixer/pkg/expr/func.go:1::warning: file is not gofmted with -s (gofmt)
mixer/pkg/expr/func.go:1::warning: file is not goimported (goimports)
mixer/pkg/il/evaluator/checker.go:1::warning: file is not gofmted with -s (gofmt)
mixer/pkg/il/evaluator/checker.go:1::warning: file is not goimported (goimports)
mixer/pkg/il/evaluator/checker.go:38:1:warning: receiver name e should be consistent with previous receiver name c for checker (golint)
mixer/pkg/il/runtime/externs.go:1::warning: file is not gofmted with -s (gofmt)
mixer/pkg/il/runtime/externs.go:1::warning: file is not goimported (goimports)
mixer/pkg/il/runtime/externs.go:37:5:warning: exported var ExternFunctionMetadata should have comment or be unexported (golint)
mixer/pkg/il/runtime/externs.go:55:6:warning: func externIp should be externIP (golint)
mixer/pkg/il/runtime/externs.go:62:6:warning: func externIpEqual should be externIPEqual (golint)
mixer/pkg/il/testing/tests.go:32:5:warning: exported var TestData should have comment or be unexported (golint)
mixer/pkg/il/testing/util.go:26:10:warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
mixer/pkg/mock/server.go:30:6:warning: exported type Server should have comment or be unexported (golint)
mixer/tools/codegen/pkg/interfacegen/generator.go:35:2:warning: exported const ResourceMsgTypeSuffix should have comment (or a comment on this block) or be unexported (golint)

cc: @geeknoid @manlinl @mandarjog @ozevren @guptasu FYI

These are all new and slipped in because the linters haven't been running.
On Mon, Nov 20, 2017 at 4:11 PM, Jun Mukai<EMAIL_ADDRESS>wrote:

cc: @geeknoid https://github.com/geeknoid @manlinl
https://github.com/manlinl @mandarjog https://github.com/mandarjog
@ozevren https://github.com/ozevren @guptasu
https://github.com/guptasu FYI
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/1802#issuecomment-345873405, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AVucHXv13qDfP2cEo45FGA8AVhuQd_6Pks5s4hU3gaJpZM4QlF1H
.

I can fix these (most of it is in il code anyways). However, I'd like to do
so after I land my next 2 PRs, to avoid excessive merge issues.
On Mon, Nov 20, 2017 at 4:22 PM, Martin Taillefer<EMAIL_ADDRESS>wrote:

These are all new and slipped in because the linters haven't been running.
On Mon, Nov 20, 2017 at 4:11 PM, Jun Mukai<EMAIL_ADDRESS>wrote:

cc: @geeknoid https://github.com/geeknoid @manlinl
https://github.com/manlinl @mandarjog https://github.com/mandarjog
@ozevren https://github.com/ozevren @guptasu
https://github.com/guptasu FYI
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/1802#issuecomment-345873405, or
mute
the thread
<https://github.com/notifications/unsubscribe-auth/
AVucHXv13qDfP2cEo45FGA8AVhuQd_6Pks5s4hU3gaJpZM4QlF1H>
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/1802#issuecomment-345875491, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AQR8I_KPBQEfX86EB89PYybCKNPCYvhlks5s4hfZgaJpZM4QlF1H
.

@geeknoid @jmuk  Do we really need to fix all of these (may be in other directories too) before enabling the linter ? Can we enable linter now and start barking only if new linter errors happen. Otherwise by the time @ozevren fixes this list, there will be more and we will keep playing catchup game. Can we enforce linter now ?

We should make presubmit to fail for lint errors once we clean up lint errors. Note that there are not only mixer errors but also pilot and security errors.

I will take care of linter error in svcctrl adapter code. Some lint error should have been fixed. But I agree with @guptasu, linter in presubmit should ignore existing problem.

Some of the linter errors in svcctrl like this one
mixer/adapter/svcctrl/handler.go:89:19:warning: method HandleApiKey should be HandleAPIKey (golint)
is because the conflict between Go and proto message convention.  HandleApiKey is generated code, I don't think it is possible (or worth) to fix. Can we get an exemption on such thing?

@manlinl I think that's okay. Make a comment to suppress lint errors (// nolint: golint). see https://github.com/alecthomas/gometalinter#comment-directives

My outstanding cache PR fixes the issues from mixer/pkg/cache.
On Tue, Nov 21, 2017 at 10:59 AM, Jun Mukai<EMAIL_ADDRESS>wrote:

@manlinl https://github.com/manlinl I think that's okay. Make a comment
to suppress lint errors (// nolint: golint). see
https://github.com/alecthomas/gometalinter#comment-directives
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/1802#issuecomment-346126890, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AVucHaSnJQGOpnaNcqWn8A_JstolPFbeks5s4x2ogaJpZM4QlF1H
.

@manlinl -- please update lintconfig_base.json (and lintconfig.json) in the toplevel directory when you fix the lint errors. Currently the lint errors are suppressed because mixer/adapter/svcctrl is in the "exclude" section.
Now lint warnings causes presubmit to fail, so once that's enabled again, no more such failures will come in.

@jmuk since lintconfig.json is a generated file, do you think we can eliminate it completely and not require the users to update both lintconfig and lintconfig_base ?

created https://github.com/istio/istio/pull/1869

svcctrl adapter linter issues are all fixed. And linter is re-enabled on mixer/adapter/svcctrl folder.


Version 0.5.0

Breaking Changes:

The random module is now a submodule of the instructions module.
The structures::paging module was split into several submodules:

The NotGiantPageSize, PageRange, and PageRangeInclusive types were moved to a new page submodule.
The PhysFrameRange and PhysFrameRangeInclusive types were moved to a new frame submodule.
The FrameError and PageTableEntry types were moved to a new page_table submodule.
The MapperFlush, MapToError, UnmapError, and FlagUpdateError types were moved to a new mapper submodule.

The structures::paging module received the following changes:

The Mapper::translate_page function now returns a Result with a new TranslateError error type.
The NotRecursivelyMapped error type was removed.

The instructions::int3 function was moved into the instructions::interrupts module.
Removed some old deprecated functions.
Made modifications of the interrupt stack frame unsafe by introducing a new wrapper type and an unsafe as_mut method.

Other Changes:

Added a new structures::paging::MappedPageTable type that implements the Mapper trait.
Added a software_interrupt macro to invoke arbitrary int x instructions.
Renamed the ExceptionStackFrame type to InterruptStackFrame.

Pre-published as version 0.5.0-alpha.2

I tried to use this branch on my project and I ended up with multiple error[E0658]: use of unstable library feature 'try_from' (see issue #33417), originating from the file https://github.com/rust-osdev/x86_64/blob/next-version/src/addr.rs, yet unchanged by your recent commits.
I did not get this problem on the master branch, and a simple #![feature(try_from)] in https://github.com/rust-osdev/x86_64/blob/next-version/src/lib.rs would probably solve the issue.
Although is it strange that I get these errors and not you apparently.
Should I create a PR ?

The feature was stabilized in recent nightlies so that #![feature(try_from)] is no longer recognized.

My bad, I did not know about that.
Since this version includes breaking changes, you'll have to modify the code of https://github.com/phil-opp/blog_os in consequence.
I have already started to adapt my own version of the OS, maybe I could try to work your OS as well.

Since this version includes breaking changes, you'll have to modify the code of https://github.com/phil-opp/blog_os in consequence.

Yes, although the required changes should be fairly minimal.

I have already started to adapt my own version of the OS, maybe I could try to work your OS as well.

I think it's easier for me to do it since a lot of branches need to be updated all at once (master and most of the post_XX branches). But thanks a lot for offering your help!

Published as version 0.5.0


Split JSON Out of Swiftz

@mpurland's recent pull requests have made it clear to me that it would be more useful to have JSON exist outside of this framework.  Because it remains the one component that doesn't interact all that much with Swiftz as a whole, and is the last thing that requires Foundation, I figure it would do just fine as a standalone framework.
Names, comments, criticisms, objections?

:+1:
No idea what it should be called, though…

I think you are right, it is the only section of Swiftz that requires Foundation and is completely separate in principle from the rest of the library. We could separate it out. I think there are a couple of paths.

Separate out JSON parsing as-is into a different framework with Swiftz as a dependency. (implicitly also Swiftx and Operadics). Perhaps we could call it Swiftj?

Use a separate framework like Argo for JSON parsing. There would be a migration and backwards compatibility problem with this approach.

I was thinking the 2nd, as we've had so much success with it in the past (see Concurrent, Focus, Swiftx).  If users still wish to use Swiftx and Swiftz, they can update their cartfiles and pods as much.

@CodaFi To clarify, do you mean to separate the Swift JSON parsing in Swiftz into a separate framework (like you are saying with Concurrent, Focus, Swiftx, etc) or to deprecate/remove it entirely and give a migration path to users of Swiftz to use another library like Argo?

I mean we create our own package and keep everything within the typelift ecosystem following the models of those aforementioned frameworks, then deprecate Swiftz's stuff and put out a new point-release.

Also, seeing as you've probably got more edits of that code than anyone (probably even Max at this point), I think you deserve admin access to anything we create.  Even to TypeLift if you're up for it?

@CodaFi I'm up for it, thanks. Any thoughts about the name of the new package?

Great!
OK, well Aeson, Jason, and JSON would be too blatant a violation of others' work. Continuing the greek trend

Thessalus, son of Jason
Tyro, father of Aeson, grandfather of Jason
Promachus, brother of Jason

Or just something with a hard J in the front.

I like those ideas. Tyro or Thessalus would be good. Also, we could consider Zetes (The Boreads, brothers Calais and Zetes) "They were Argonauts and played a particularly vital role in the rescue of Phineus from the harpies." since it contains a z.

Another option along the same lines would be Alcimede.

I like Tyro for length, Zetes for the pun, and Alcimede because she's a badass.  Any more, or start narrowing?

I think these are good options. I also like Tyro for the length, Zetes because of the inclusion of z, and Alcimede sounds good.

Oh, I've always wanted to name something Janeway.

XD

Janeway would be alright. JWay would sound a little too much like a Java framework.

Well, @mpurland you have the rights to do whatever you like right now.  Go ahead and pick a name and a make a new repository.
Would you like us to close out all the existing pull requests and try again on the new repo after it's made, or would you prefer we merge first and ask questions later?

@CodaFi Thanks. Yes, let's merge what is currently there (if it makes sense) and then start using the latest in master as a base. What do you think?

:+1:  Let's do it.

@CodaFi This is a first pass. I'll create the official repository after I can put a little more time into it. Take a look here: https://github.com/mpurland/Tyro

I believe it's ready to be reviewed (https://github.com/mpurland/Tyro). Let me know what you think. I've added Travis CI integration and have ~75% test code coverage so far. I'll be adding more tests later with exact tests around the same json-data as Aeson and performance tests around large json data sets.

:boat: See https://github.com/typelift/Tyro


@coderabitai title

Summary by CodeRabbit

New Features

Introduced a new indentation style setting for more consistent code formatting across the project.
Added plugins for automated code quality checks and formatting, enhancing the project's build and reporting capabilities.
Implemented a code style checking mechanism to ensure adherence to specified guidelines.

Improvements

Enhanced project maintainability and readability through automated code formatting practices.

@coderabbitai title