DB errors are not sent forward

Bug report

[x] I confirm this is a bug with Supabase, not with my own application.
[x] I confirm I have searched the Docs, GitHub Discussions, and Discord.

Describe the bug
I'm using a database trigger on the storage.objects table to sum up file sizes per bucket into a different table. When the quota is exceeded the database trigger raises an exception to not allow the upload:
RAISE EXCEPTION 'Storage quota for tenant exceeded' USING MESSAGE = 'Storage quota for tenant exceeded', DETAIL='Storage quota for tenant exceeded', HINT='Upgrade your plan';

I assumed the message of the exception would be passed on by the storage api but instead i receive:
{
   message: 'Internal Server Error',
   statusCode: '500',
   error: 'internal'
}

The message from the database seems to be swallowed here for no apparent reason:
https://github.com/supabase/storage-api/blob/27c3b388a45be1fafdc51706be9c60349a9f5255/src/storage/database/knex.ts#L526-L556
To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:

Create db trigger for objects table that raises exception
try uploading a file

Expected behavior
If the SQL exception contains details, they whould be passed on like:
{
   message: 'Storage quota exceeded',
   statusCode: '500',
   error: 'internal'
}

Could work similiar to here: https://github.com/supabase/gotrue/pull/404
System information

OS: ubuntu 22
Browser (if applies): firefox
Version of supabase-js: 2.22.0
Version of Node.js: 16.20.1

Additional context

https://github.com/supabase/gotrue/pull/404

Hi, @soudis this is somewhat international since we don't want to accidentally leak information returned from the error message from the database.
However, a good thing we can add is to return the link which points to a log line for you to inspect the error in more details, what do you think?

this is somewhat international since we don't want to accidentally leak information returned from the error message from the database.

@fenos this concern was mentioned in supabase/auth as well, but it was decide at the time that the error message can be sent under specific conditions. ~ Refer this comment
However, this no longer works for some reason. I'm unsure if there was a reason this was removed or it it's a bug, but I've opened an issue reporting it as a bug.
I'd really like if this was possible with Supabase Auth, I don't have a requirement for this feature in Supabase Storage (at least not for now), but I mentioned this because I thought the behaviour (whatever has been decided) should be consistent.

Hi, @soudis this is somewhat international since we don't want to accidentally leak information returned from the error message from the database.

Hi @fenos,
Something is definitely not right - it's leaking info for me.
This is a function that I'm using in storage RLS for selecting a file:
DECLARE
    user_subscription_exists boolean;
BEGIN
    SELECT EXISTS (
        SELECT 1 FROM subscriptions WHERE u_id = auth.uid()
    ) INTO user_subscription_exists;

    IF NOT user_subscription_exists THEN
        RAISE EXCEPTION 'NO_ACTIVE_SUBSCRIPTION' USING ERRCODE = 'P0001';
    END IF;

    RETURN user_subscription_exists;
END;

In my app, after trying to upload a file with the RLS not meeting the criteria:
const { data, error } = await supabase.storage(...)
console.log(error)

...I'm getting the following:
{"code": "DatabaseError", "error": "DatabaseError", "message": "insert into \"objects\" (\"bucket_id\", \"metadata\", \"name\", \"owner\", \"owner_id\", \"version\") values ($1, DEFAULT, $2, $3, $4, $5) - NO_ACTIVE_SUBSCRIPTION", "statusCode": "500"}```

Hi, @soudis this is somewhat international since we don't want to accidentally leak information returned from the error message from the database.

Hi @fenos, Something is definitely not right - it's leaking info for me.
This is a function that I'm using in storage RLS for selecting a file:
DECLARE
    user_subscription_exists boolean;
BEGIN
    SELECT EXISTS (
        SELECT 1 FROM subscriptions WHERE u_id = auth.uid()
    ) INTO user_subscription_exists;

    IF NOT user_subscription_exists THEN
        RAISE EXCEPTION 'NO_ACTIVE_SUBSCRIPTION' USING ERRCODE = 'P0001';
    END IF;

    RETURN user_subscription_exists;
END;

In my app, after trying to upload a file with the RLS not meeting the criteria:
const { data, error } = await supabase.storage(...)
console.log(error)

...I'm getting the following:
{"code": "DatabaseError", "error": "DatabaseError", "message": "insert into \"objects\" (\"bucket_id\", \"metadata\", \"name\", \"owner\", \"owner_id\", \"version\") values ($1, DEFAULT, $2, $3, $4, $5) - NO_ACTIVE_SUBSCRIPTION", "statusCode": "500"}```

me too


Error when attempting to end incident

What version of Node.js are you using?
16.13.1
What version of npm are you using?
8.3.0
What operating system are you using?
Linux (ubuntu 20.04)
Describe the Bug

Occurs when I attempt to end the incident, I've tried refreshing and attempting again and get the same result.
Expected Behavior
The incident should close down and end.
To Reproduce
No response

Not an API error. Looks like the API isn't online yet?

It's odd that its reporting a CORS error but only for this specific request?

Not an API error. Looks like the API isn't online yet?

If the API wasn't online I wouldn't be able to access the dashboard and clock on etc though?

hm, weird. Works fine for me

Did the API crash?

Not that I can see - I can perform every single other action. I don't usually have issues with closing incidents either? It's really odd that its just that specific action.

Here is what is output in the console when I attempt to close.

hmmm, weird. Are you able to increase the max body size for your hosting?

hmmm, weird. Are you able to increase the max body size for your hosting?

I've set it to no limit:
client_max_body_size 0;
No change unfortunately, same error.

hm, will debug this

Looks like there was a default set. I've bumped this to 500kb, are you able to try that. Simple update should suffice

Looks like there was a default set. I've bumped this to 500kb, are you able to try that. Simple update should suffice

That's fixed it! Thank you.

alright, cool!


Most dialogs broken.

Asset browser, appearance, and blueprints dialogs throw an exception when opened:
TypeError: 'NoneType' object is not subscriptable

Fixed by 6e5e2f9.


XML code view is too small

The XML code view currently scrolls unnecessarily within a small dialog, I'd prefer it to use the whole height of the screen.
In open-scd we used style="width: 80vw; height: calc(100vh - 240px);" on the ace-editor custom element, maybe something similar could be done here.

Resolved in https://github.com/OpenEnergyTools/scl-wizarding/commit/f479251eaed4b865b101bbe40ef142b92ee39c6a .


addField with params not working

I have a deep form and call addField with an object of params.  I can see that my app's form state is updated with the new field and the correct values, but when I render them the values don't reflect the app state- they're empty, as though addField was called with no parameters.
e.g.:
@reduxForm({
	form: "itemTest",
	fields: [
		"items[].foo"
	]
})
...
<button type="button" onClick={this.props.fields.list.addField({foo: "bar"})>click</button>

{this.props.fields.list.map((item) =>
{...item.foo.value}
)}

This isn't my actual code, so I might have made a typo, but the point I'm trying to make is that the "li" contents is undefined, even though the app's form state looks correct

I played with the example code and if the field is a string array, it works fine (e.g., addField("foo")), but not if it's an object.
I tried changing the example to add an object to the "add child" button:
          <button onClick={event => {
            event.preventDefault(); // prevent form submission
            children.addField({name: "foo", age: 123});    // pushes empty child field onto the end of the array
          }}> Add Child
          </button>

You can see the form state has the correct value but the edit box does not.

I've traced it down to lib/reducer.js:56:
  var newValue = { value: value };

If I change the line to:
  var newValue = (value === Object(value) ? value : { value: value });

and change the object I pass in to store values under a "value" subkey like this:
children.addField({name: {value: "foo"}, age: {value: 123}});

then it works, though ideally redux-form would do that transformation for me.

Looks like this is already fixed:
https://github.com/latentflip/redux-form/commit/01a7f2657c8c206aac8d353f31bc084891d6baf7


syscall/js: js.Func loses reference, so using removeEventListener(event, callback) is impossible in WebASM

Go version
go version go1.22.5 linux/amd64
Output of go env in your module/workspace:
GOOS="js"
GOARCH="wasm"

(the rest is not related, obviously)

What did you do?
The js.Value that is used behind the scenes does not allow to remove previous event listeners, because the method requires a reference to the callback function which isn't possible in go's syscall/js.Value implementation.
The internal .ref property seems to be lost along the way, no matter which way you want to call the removeEventListener method. Even when using a wrapper object with a handleEvent() method, the reference to that object (instance) seems to get lost, too.
As there's no way to use Call("removeEventListener", *js.Value) I think this is an implementation bug that's incompatible with the removeEventListener API of Web Browsers.
What did you see happen?
The reduced test case, which shows a clickable element which should not be clickable after a second:
https://github.com/cookiengineer/golang-issue-68865
In the reduced test case, the removeEventListener() method call silently fails, and actually doesn't do anything, because I'm assuming that the method gets called outside the WebASM context with the wrong reference (and a new wrapped object/value).
What did you expect to see?
As I think this is an implementation bug, I'm assuming that the syscall/js.Value.Call() method at some point should accept *js.Value as function parameters and be able to use those outside the WebASM context in the Web Browser's sandbox.
But I don't know much about the internals other than what I was able to read and understand, so I could be totally wrong in my assumption. If so, please elaborate how to use removeEventListener() or how to use  js.Func references correctly.

https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/removeEventListener :
The removeEventListener() method of the EventTarget interface removes an event listener previously registered with EventTarget.addEventListener() from the target. The event listener to be removed is identified using a combination of the event type, the event listener function itself, and various optional options that may affect the matching process; see Matching event listeners for removal.
you're not matching the eventlistener correctly (the useCapture arg).
Unlike many projects, the Go project does not use GitHub Issues for general discussion or asking questions. GitHub Issues are used for tracking bugs and proposals only.
For questions please refer to https://github.com/golang/go/wiki/Questions


Update default_rules.json

Add some new key formats that seem to have existed in the dark and dusty corners of history

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

LGTM!


Async uploading does not change the code from 425 to 200

steps:

start ocis localy with env: OCIS_INSECURE=false STORAGE_USERS_OCIS_ASYNC_UPLOADS=true
upload file

The uploading succeeds, but I don't have the file in the UI

wait and reload page

Expected: file should become 200 after some time. file is visible on UI
Actual: no file (regardless of size). response code remains 425 after waiting
if you start ocis with OCIS_INSECURE=true env works correct

@fschade @kobergj Can you check on viktors findings?

Already did. Events in storage-users need OCIS_INSECURE for now. That seems to be a flaw in events implementation, but it this not happen on other services. Maybe something is just configured wrong. I'll need to check

It was the postprocessing service, not storage users. Anyways here is the fix: https://github.com/owncloud/ocis/pull/5269

Fix landed


Bug with AnimationDrawable in Android 4

The bug exists in Android 4.* as far as I know, it's not reproducible in Android 5.*. It broke in API 15 and 17.
If you put a AnimationDrawable as a drawable to the ImageViewTouch, the animation does only start in Android 5.
I guess it's sort of a timing problem, I could work around by wasting with the object stack.
Example animation-list:
<?xml version="1.0" encoding="utf-8"?>
<animation-list
    android:id="@+id/led_animation_1"
    android:oneshot="false"
    xmlns:android="http://schemas.android.com/apk/res/android">
        <item android:drawable="@drawable/test1" android:duration="150" />
        <item android:drawable="@drawable/test2" android:duration="150" />
</animation-list>

Example code how it works in Android 5 but not in Android 4:
        this.imageView = (ImageViewTouch) view.findViewById(R.id.step_led_image);
        this.imageView.setDisplayType(ImageViewTouchBase.DisplayType.FIT_TO_SCREEN);
        this.imageView.setScaleEnabled(true);

        AnimationDrawable frameAnimation = (AnimationDrawable) getResources().getDrawable(R.drawable.led_animation_1);

        this.imageView.setImageDrawable(frameAnimation);
        frameAnimation.start();

How it actually works in Android 4:
        this.imageView = (ImageViewTouch) view.findViewById(R.id.step_led_image);
        this.imageView.setDisplayType(ImageViewTouchBase.DisplayType.FIT_TO_SCREEN);
        this.imageView.setScaleEnabled(true);

        AnimationDrawable frameAnimation = (AnimationDrawable) getResources().getDrawable(R.drawable.led_animation_1);

        this.imageView.setImageDrawable(frameAnimation);

        this.imageView.setBackground(frameAnimation);

        AnimationDrawable test = (AnimationDrawable) this.imageView.getBackground();
        test.start();

        this.imageView.setBackground(null);

The first one should be the good way, the second one is a dirty hack and not a solution, don't use that code or you end in hell.
But it's here to show the problem. The first code sticks at frame[0] in Android 4 but works well in 5. The second one sets the same drawable as background and as drawable, that results in some references. If I use getBackground to get my object back, I can run play on it and both starts! I guess we need a function like getImageDrawable, to fix it in a better way for Android 4.
I could implement that, if you like. I leave that here for discussion.

Btw. the first code works fine with just using an ImageView.


no worksheet evaluation

Describe the bug

worksheets are not evaluating and showing the results as virtual text
To Reproduce Steps to reproduce the behavior:

Open a scala project with an sbt file and everything
Verify that various LSP/Metals-related functionality is working (go to def, show help, etc.)
Open an existing *.worksheet.sc file
Autocomplete still works in it, and the lsp status bar says it's evaluating, but there is no virtual text showing the evaluations

Expected behavior
virtual text shows the value of lines of code
Screenshots

no virtual text

but yes autocomplete

Installation:

Operating system: macOS
Nvim version: NVIM v0.5.1
Commit of nvim-metals: ab78a00c1db8c8b
Metals version: metals 0.10.6-M1

Additional context
my configs
vim.lsp.set_log_level("debug")
local nvim_lsp = require('lspconfig')

local servers = { "rust_analyzer", "tsserver", "pylsp" }
for _, lsp in ipairs(servers) do
  nvim_lsp[lsp].setup {
    capabilities = require('cmp_nvim_lsp').update_capabilities(vim.lsp.protocol.make_client_capabilities()),
    flags = { debounce_text_changes = 150 },
    on_attach = function(client)
      require'aerial'.on_attach(client)
    end,
  }
end

"""" NVIM-METALS: config for scala language server, metals
" useful for restarting metals
nnoremap <leader>ore :!rm -rf .metals .bloop project/metals.sbt<CR>:MetalsRestartServer<CR>
" silence messages about stuff I think?
set shortmess-=F

_G.metals_config = require("metals").bare_config
_G.metals_config.capabilities = require'cmp_nvim_lsp'.update_capabilities(vim.lsp.protocol.make_client_capabilities())
_G.metals_config.settings = { showImplicitArguments = true }
_G.metals_config.init_options.statusBarProvider = "show-message"
_G.metals_config.on_attach = function(client, bufnr) require'aerial'.on_attach(client) end

augroup lsp
  autocmd!
  autocmd FileType scala,sc,sbt lua require("metals").initialize_or_attach(_G.metals_config)
augroup END

Search terms
worksheet
evaluation
virtual text
completion

I'm getting a huge stack trace in my .metals/metals.log
The stack trace starts with this:
java.lang.NoClassDefFoundError: scala/tools/nsc/reporters/Reporter$Severity


Replace RabbitAutoConfiguration with local RabbitConfiguration

Relies on https://github.com/spring-projects/spring-boot/pull/26982/files
@wilkinsona
Fixes #187

@garyrussell @sabbyanandan this one is ready for review.

LGTM; but shouldn't we rename RabbitServiceAutoConfiguration ?

Thx @garyrussell . I too agree we should rename it to RabbitBinderConfiguration as that is what it really is. This would be inline w/ its SCSK counterpart.
I just was not sure about putting it in w/ this current proposal.

Yes; it's ok to do it in this PR.


How to resize images??

New to hugo.
I can't use
![](image_url ?200x200)
or
![](image_url =200x200)
or
{: "height = 200" "width = 200"}
or
<img src= "image_url" style= "zoom:90" / >
I can use those in vs code or typora, but can't in hugo!
I can't find answer use google either.
So can anyone just tell me how to resize image in hugo?This just drive me crzy.

Please use https://discourse.gohugo.io/ for questions/troubleshooting. Also see  Hugo Documentation.


Scale file meta-data

Design a new Scale file meta-data system.
Each item here could result in one or more new issues.

Add the capability for jobs to have meta-data added to input files (this will replace the current "parse results" system). Look at including which meta-data attributes came from which algorithm+version. Look at having some type of "source" section that gets propagated from file to file.

Also look at how new trigger rules should work against the new meta-data (eventually replacing the current "data type" system).

Consider storing meta-data with the actual files depending on the broker (as a file for NFS, as meta-data in S3, etc)

Consider including meta-data when files are passed as input.

This issue has resulted in the creation of the following issues:
#1160 - parsing input/output file meta-data
#1156 - passing input file meta-data to jobs
#1034 - designing recipes to contain other recipes and have conditional branching (filters), then recipes will be used to replace the current trigger system


04-create-dax-calculations-in-power-bi-desktop.md

English:
The second will be the Date table.
Current Translation:
第二個是 [日期] 資料表
Suggested Translation:
第二個是 Date 資料表
Description:
The name of table should be English. Global check

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Run bugfix tool and waiting for result.


[FEAT] - Readarr - convert ebook types and remove the need for calibre

Do what calibre does without being calibre

This is the wrong tool for that job. That need something more like unpackerr that does it on download. Unfortunately calibre is the only tool that does this, and I have no idea how it does it.


1.3.0+1.19.2

i think your fork is outdated; there's quite a few conflicts

i think your fork is outdated; there's quite a few conflicts

Not quite as I actually built off 1.19.3's branch, and backported from there because I think that it was a rewrite.

There's probably been some commits though.

There's a bit of a critical bug in this backport from testing that a friend found, I'll get to fixing it in a tad.

what was the bug?

It's probably just on my end but I forgot to nullcheck playerList

Don't merge yet, as I'm awaiting a crashlog from my friend.

Sorry, but i no longer have interest in upkeeping this PR.


Updated Dashboards from grafana.db

Just exported all dashboards from the database to make sure they are the same even if you don’t use the included grafana.db.
You put so many great thoughts into the dashboards, this just makes it easier for people to use that.
Thanks for sharing your work!

Thanks for the update @0ff !


Update zio-streams, zio-test, zio-test-sbt to 2.0.16

About this PR
📦 Updates

dev.zio:zio-streams
dev.zio:zio-test
dev.zio:zio-test-sbt

from 2.0.15 to 2.0.16
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "dev.zio" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "dev.zio" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #352.


Download Location Issue

Version : 0.9.0 (0.95.2)
OS : Antergos 16.4 (Kernel 4.6.4)
Sometimes i download Torrents to Portable Devices , example if the location is set to /media/USB
If the usb is disconnect or usb is unmounted (now the /media/USB is not present)
Whennew torrent is added to Web Torrent, the file starts downloading without showing any error  & i cannot find the file in any location
To show location error or revert back location to /home/user/Download
The torrent kept downloading

Duplicate of #646.


test: add e2e tests for windows

Two notebooks fail because they currently cannot run on Windows: https://github.com/kili-technology/kili-python-sdk/actions/runs/3620652184/jobs/6103126008
I had to modify the pytest command since glob patterns don't seem to be working on Windows.

for medical_imaging.ipynb have you tried replacing .jpeg by .jpg ?
for frame_dicom_data.ipynb no idea (apart from printing stuff to debug through the CI action)

frame_dicom_data.ipynb fails because of the !apt-get install unzip and !unzip -o ~/Downloads/TCGA-LUAD.zip -d ~/Downloads/ > /dev/null
I'm still not sure why medical_imaging.ipynb fails


re-organize gitops cmds to dedup codes

This PR re-organizes gitops sub-commands to

remove duplicated codes #2946
fix persistent flags problems

Signed-off-by: Chanwit Kaewkasi<EMAIL_ADDRESS>

@chanwit I'm going to close this just now, feel free to reopen if you want to pick it back up


Fix broken function get_current_style in Styles subsystem

Function contained code with invalid syntax, and wrong variable return.
New code calls the method appropriately and makes a check for validity of the retrieved style.

Thanks!


add clean of apt lists in apt installs command

This should reduce the size of container images. Still requires testing.


Adds test of Enum.HasFlag related tests.

To support case in nanoFramework/Home#730.
Description
Added two new test methods.
Motivation and Context

Resolves nanoFramework/Home#730

How Has This Been Tested?
Tests were executed
Screenshots
Types of changes

[x] Improvement (non-breaking change that improves a feature, code or algorithm)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Config and build (change in the configuration and build system, has no impact on code or features)
[ ] Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

@SandorDobos seems that we've had the same idea at the same time. 😆
I've also made several improvements in the Enum Tests. As it seems less work, care to add this test to #130 ?

I revoke this PR and recreate it on up2date codebase.


New derives: From and Deref

It's often useful to wrap a single type into a new one, to be able to add new methods, provide more documentation and possibly type safety.
For example,
pub struct Inches(f32);
pub struct Meters(f32);

This way if the units are used incorrectly we get a type error. Fortunately there is no space overhead as well. This is very similar to newtype in Haskell.
I'm proposing that we consider being able to derive From and possibly Deref for structs with exactly one field. For the above example, adding #[derive(From, Deref)] above Inches would generate the code:
impl From<f32> for Inches {
  fn from(x: f32) -> Self {
    Inches(x)
  }
}
impl Deref for Inches {
  type Target = f32;
  fn deref(&self) -> &Self::Target {
    &self.0
  }
}

These or similar derives would significantly reduce boilerplate when creating wrapper types, thus encouraging their use.
EDIT: fixed i32 => f32

Possibly this could be done as a macro, though.

Not sure if it's any good, but there is a crate that does just that: https://github.com/JelteF/derive_more

Disclaimer: I might come across a little rude because english isn't my first language and text isn't very good at conveing emotion in the first place. I'm not writing with animosity towards you - literally the contrary!

I think I'm against this, for the following reason: Syntax and implications.
#[derive(From, Deref)] could confuse many people. Deriving from a very generc trait and making it only legal for rather specific types is odd. I mean what would happen if one attempts to derive these traits for invalid types? "Sorry, your type is not tall enough to ride this ride derive from this trait". Is this really a good idea? Do we really want these specific auto-impls in derive? If I derive from something, I expect to always get a predictable implementation, without errors (excluding other trait requirements, like Eq => PartialEq).
Also I think automatically implementing From for newtypes is not a good idea either. Isn't the point of newtypes to ensure that the data they wrap cant be passed / used somewhere wrong? In other words, binding meaningless data types to specific, statically checked, meaning? Let me reuse your Inches / Meters example:
Let's imagine we have derived From and Deref for both Inches and Meters (or implemented it manually, doesn't really matter). There's nothing stopping me or anyone else from doing stuff like this:
let inches = Inches(123.0);

// Somewhere, in the dark corners of your codebase:
let meters = Meters::from(*inches);

// Rather than:
let meters: Meters = inches.into();
// Or
let meters = inches.into_meters();

The from-derive variant avoids explicit conversion of the data and would probably introduce bugs to our code.
I believe it's vital to design your API or code generally in such a way, that it cannot be used incorrectly (Scott Meyers, anyone?). From and Deref would make it very easy to use it incorrectly.

Wow, I really don't know how to keep it short. What do you guys think?

Deriving from a very generc trait and making it only legal for rather specific types is odd.

As far as I know, #[derive(Copy)]/Clone/Default/Eq/Ord/etc are only legal on types that contain only other Copy/Clone/Default/Eq/Ord/etc types. So this is nothing new.

The from-derive variant avoids explicit conversion of the data and would probably introduce bugs to our code.

If you have a newtype/wrapper for which the obvious, trivial conversion is invalid, wouldn't you simply not use this feature and not have this problem? It's not that hard to write similarly broken From impls today.

automatically implementing From for newtypes

I believe the proposed feature is meant to be opt-in, like existing derive annotations. Most of your post simply doesn't make sense to me; it sounds as if you're talking about an opt-out feature that users would have to know to avoid, rather than an annotation that doesn't do anything until you explicitly add it.

As far as I know, #[derive(Copy)]/Clone/Default/Eq/Ord/etc are only legal on types that contain only other Copy/Clone/Default/Eq/Ord/etc types. So this is nothing new.

True, but what I was talking about was #[derive(From / Deref)] mandating a syntactically specially formed struct (a tuple struct with only one field). What would a programmer, who's unfarmiliar with the derive, think when they came across #[derive(From)]? Would it be clear what it does?
I'd prefer if we would choose more distinct names for the derives, something like #[derive(NewtypeFrom)], but thats not possible I think. How about a custom attribute #[WrapperType], which would implement both Deref and From? That would be totally fine with me.

If you have a newtype/wrapper for which the obvious, trivial conversion is invalid, wouldn't you simply not use this feature and write a correct From impl maually? [...]

Yup, that's what I was trying to show with my snippet, although I was doing it the other way around with Into.
Comments?

Deref seems quite reasonable, and conveniently there's already a feature that defined "the one field that matters, even if there are extra ZST markers": repr(transparent).  (That probably doesn't work if every field is a ZST, but Deref to a ZST feels like an uncommon enough scenario that it doesn't worry me.)
From I'm more torn about.  If one can derive From, it feels like one should also be able to derive Into, but that's something we tell people not to implement (if possible).  So what I really want for a newtype that has an invariant is InnerFromSelf, but that feels meh.
I remember seeing "we should have explicit support for declaring a newtype" expressed before, but can't seem to fine it...

Deriving From automatically derives Into. If I recall correctly, you get an error if you attempt to derive Into yourself. I don't see the problem there.

@scottmcm I think deriving From is enough; Into will be auto-impled (as @iitalics pointed out). But I do like the idea of InnerFromSelf except maybe it makes more sense as IntoInner instead.

There is a derive_deref crate with ~68000 downloads for now, and I believe this is a good evidence that #[derive(Deref)] is in demand.
Personally I've been implementing a trivial Deref each time for a newtype, where I use newtype construction for a flow control between interfaces rather than for hiding an internal representation.

The fact that a crate can already reliably do this and also the fact that this isn't an essential part of letting the ecosystem pick a "standard" datatype for something means that this seems like a low priority.
Not that I'm against the idea, but if there's already a crate for it, what does putting it into core gain us?

@Lokathor That same argument can be made for all of the built-in derives in Rust.

It would be interesting to survey the uses of derive_deref. In particular, how many of its uses are "real" Derefs as opposed to using Deref as a workaround for the lack of delegation.
It's also not clear to me that "If the type of that field is a reference, the reference will be returned directly." is the correct default behavior for Deref impls in general.
Unfortunately I don't have the time myself to investigate either point.

Yes, I'd worry that #[derive(Deref)] encourages deref polymorphism, which bring subtle problems.  At least the variance issues should not be problematic here, right?  I suppose Deref/DerefMut have some history with soundness bugs too, but again not with such simple derives probably.
I think rust should first sort out both (a) delegation in general and (b) convenient newtype delegation across many traits.  I think (b) could reasonable precede (a) if done properly outside std/core, like maybe the newtype_derive crate, but convenient precise arithmetic, Fn, etc. delegation should be preferred over Deref/DerefMut.

@burdges

Yes, I'd worry that #[derive(Deref)] encourages deref polymorphism

In my opinion, I'd worry that the existence of Deref trait itself encourages deref polymorphism, not the absence of #[derive(Deref)] implementation ;)
Kind of, it doesn't stop anyone to implement a little boilerplate impl Deref for MyType, and it doesn't stop using external crates implementing Deref.

I think rust should first sort out both (a) delegation in general and (b) convenient newtype delegation across many traits. I think (b) could reasonable precede (a)...

Yes, agree, if I understand you correctly. I think that seems like newtype could be a main motivation to have a quick #[derive(Deref)] over it. By the way, derive_deref works with limitations that the struct should have only a 1 field (newtype).


yo i get info yk but like i dont get a zip i get a war file which asks for a password i got the file from go file

Please help me discord Q1CKS1LVER#9938
how me get info i got a weird black something war file asking for a password to archive it. Please help

When you first used the grabber, it asked you to set a password for the archive. If you set nothing, the default password is blank123

oh thats weird asf i typed the password just n and worked xd maybe cuz when it asked me y/n i put n so thats the pass idrk but ty for ur help:D


Issue with HPKP configuration

Hello, i've tried to use the HPKP configuration in web.config:
<nwebsec>
    <httpHeaderSecurityModule xmlns="http://nwebsec.com/HttpHeaderSecurityModuleConfig.xsd" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="NWebsecConfig/HttpHeaderSecurityModuleConfig.xsd">
      <redirectValidation enabled="true" />
      <securityHttpHeaders>
        <public-Key-Pins max-age="30" includeSubdomains="true">
          <certificates>
            <add thumbprint="FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF"/>
          </certificates>
          <pins>
            <add pin="Base64 pin"/>
          </pins>
        </public-Key-Pins>
      </securityHttpHeaders>
    </httpHeaderSecurityModule>
  </nwebsec>

My issue is that i got the following error:
Configuration Error

Description: An error occurred during the processing of a configuration file required to service this request. Please review the specific error details below and modify your configuration file appropriately.

Parser Error Message: HPKP configuration error. Details: Attempt by security transparent method 'NWebsec.Modules.Configuration.HpkpCertConfigurationElement.get_SpkiPinValue()' to access security critical method 'System.Security.Cryptography.X509Certificates.X509Certificate.Reset()' failed.

Assembly 'NWebsec, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=3613da5f958908a1' is marked with the AllowPartiallyTrustedCallersAttribute, and uses the level 2 security transparency model.  Level 2 transparency causes all methods in AllowPartiallyTrustedCallers assemblies to become security transparent by default, which may be the cause of this exception.

I have installed Nwebsec from nuget package manager.
Is this particular scenario documented in any other place?

Hm, haven't seen that one before. Which framework version are you targeting?

Target framework: .NET Framework 4.5

Turns out there is an issue with the permissions. The fix will be included in the next release.

It should be ok if you get the latest version. Feel free to reopen this issue if you run into further problems.


Using in Objective-C project

I am working on Objective-C project with xCode 8.
I am not sure how I can use this pod in Obj-C project.
Basically, how can I create Client for configuration?
If you have sample code, please share me some code part.
Thanks

Duplicate of https://github.com/Constantine-Fry/das-quadrat/issues/27#issuecomment-252148912
@billy84  Can you close this?

Ok


[Explicit Module Build] Add compiledModuleCandidates to the module dependency graph.

To match outputted structure from: https://github.com/apple/swift/pull/32956
Actual logic support to come.

@swift-ci please test


Support formsy-react v1.1.2

Please upgrade formsy-material-ui  to support formsy-react v1.1.2, so we can finally use React v16. This is the only package that prevents us from upgrading atm
Related to #240

given its now 12th April, its not looking good @Fandekasp 👎

I've just managed to completely bypass the use of this (now unsupported) module simply by using the withFormsy HOC available from the formsy-react component.  This passes in the necessary prop-based methods of  getValue and setValue to hook yourself manually into the Formsy form.  It took a little bit of rejigging, but not much really.  There is a very good example of how to use withFormsy on the formsy-react npm/git page.  hope this helps you/everyone

Is this still maintained? Any chance someone wrote this with formsy-react 1.x?


Outlined textfield border label cutoff when centering a div

When

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

The outlined text field has a gap in the middle of the text field with the border over the word
Expected Behavior 🤔
The outlined text field border should have a gap in the border where the text is at the top
Steps to Reproduce 🕹

Steps:

https://codesandbox.io/s/strange-golick-1tqqw?file=/src/Demo.js

Context 🔦

Your Environment 🌎

Tech
Version

| Material-UI | v4.11.0  |
| React       | 16.13.1        |
| Browser     |  Chrome       |
| TypeScript  |   3.9.5      |
| etc.        |         |

@Codetalker777 Thanks for raising and the reproduction. What do you think of this fix?
diff --git a/packages/material-ui/src/OutlinedInput/NotchedOutline.js b/packages/material-ui/src/OutlinedInput/NotchedOutline.js
index 638a936f2..4f0279d91 100644
--- a/packages/material-ui/src/OutlinedInput/NotchedOutline.js
+++ b/packages/material-ui/src/OutlinedInput/NotchedOutline.js
@@ -9,6 +9,7 @@ export const styles = theme => {
   return {
     /* Styles applied to the root element. */
     root: {
+      textAlign: 'left',
       position: 'absolute',
       bottom: 0,
       right: 0,
@@ -24,7 +25,6 @@ export const styles = theme => {
     },
     /* Styles applied to the legend element when `labelWidth` is provided. */
     legend: {
-      textAlign: 'left',
       padding: 0,
       lineHeight: '11px', // sync with `height` in `legend` styles
       transition: theme.transitions.create('width', {
@@ -36,7 +36,6 @@ export const styles = theme => {
     legendLabelled: {
       display: 'block',
       width: 'auto',
-      textAlign: 'left',
       padding: 0,
       height: 11, // sync with `lineHeight` in `legend` styles
       fontSize: '0.75em',

Do you want to work on a pull request? :)

Sure I can handle this PR :)

@Codetalker777 Thanks for raising and the reproduction. What do you think of this fix?
diff --git a/packages/material-ui/src/OutlinedInput/NotchedOutline.js b/packages/material-ui/src/OutlinedInput/NotchedOutline.js
index 638a936f2..4f0279d91 100644
--- a/packages/material-ui/src/OutlinedInput/NotchedOutline.js
+++ b/packages/material-ui/src/OutlinedInput/NotchedOutline.js
@@ -9,6 +9,7 @@ export const styles = theme => {
   return {
     /* Styles applied to the root element. */
     root: {
+      textAlign: 'left',
       position: 'absolute',
       bottom: 0,
       right: 0,
@@ -24,7 +25,6 @@ export const styles = theme => {
     },
     /* Styles applied to the legend element when `labelWidth` is provided. */
     legend: {
-      textAlign: 'left',
       padding: 0,
       lineHeight: '11px', // sync with `height` in `legend` styles
       transition: theme.transitions.create('width', {
@@ -36,7 +36,6 @@ export const styles = theme => {
     legendLabelled: {
       display: 'block',
       width: 'auto',
-      textAlign: 'left',
       padding: 0,
       height: 11, // sync with `lineHeight` in `legend` styles
       fontSize: '0.75em',

Do you want to work on a pull request? :)

Looks like good fix to me!

pull request https://github.com/mui-org/material-ui/pull/21665


Change more pipelines to use the wheel build to perform their tests after wheel is functional

@dimitri-tenstorrent relevant for tox work

This is related to the tox work.


Terminal consumes a lot of CPU when editing in vim

VSCode Version: 1.35.0
OS Version: kubuntu 19.04

Steps to Reproduce:

open vscode full screen, terminal should be big enough
open file with name env.conf and content below in vim
terminal will feel slow, code process consumes 100% cpu of 1 core.

screencast

content:
#JAVA_HOME=/usr/java/jdk1.6
HADOOP_OPTS=-Djava.net.preferIPv4Stack=true

#LD_LIBRARY_PATH=/usr/local/gcc-4.7.3/lib64
LD_LIBRARY_PATH=/usr/local/lib64

CXX=/usr/local/bin/g++
CC=/usr/local/bin/gcc

#PATH=/usr/local/lib/ccache/:/usr/local/gcc-4.7.3/bin/:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
PATH=/usr/local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
CCACHE_COMPRESS=true
CCACHE_SLOPPINESS=no_system_headers
# CCACHE_DISABLE=true

Noticed since 1.34 I guess

Does this issue occur when all extensions are disabled?: Yes/No

Can you open devtools and run a perf timeline while editing vim, save it and upload it? That should show what functions it's busy in.

Done
Profile-20190611T150659.json.txt.gz

Are you using a network drive or something? I see a lot of blocking readdir calls taking very long:

No, I'm using local drive definitely. No matter If I edit this file in /home partition or in /usr/etc - it still feels slow

Same issue happening here. The bigger the terminal gets, the slower vim becomes. Please find information about my environment below; I hope it helps:

Operation System: Mac OS 10.14.6
VSCode:

Version: 1.37.1
Commit: f06011ac164ae4dc8e753a3fe7f9549844d15e35
Date: 2019-08-15T16:16:34.800Z
Electron: 4.2.7
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Darwin x64 18.7.0

This issue and the duplicate issue that was closed have something in common: https://github.com/microsoft/vscode/issues/79547
The integrated terminals in both these issues have a lot of text that look like paths. So I believe offering an option to turn off the terminal.links feature in integrated terminal can be a temporary stop gap measure to let people continue to use the integrated terminal while waiting for a better fix.

Done, try out terminal.integrated.enableFileLinks in Insiders. I'll keep this open for a more robust solution in the future (detecting slowness, auto disabling for network drives, etc.), maybe with reverting to linkifying all potential paths without validation.

Is this feature available in the insders version? i tried it today but the editor said terminal.integrated.enableFileLinks is an "Unknown Configuration Setting". The version I tried is September 2019 (version 1.39) on OSX.
Am I missing something?

@yuqian90 it should be in today's build yes, looks like you tried before our daily build went out.

Thanks @Tyriar  started trying the insider version with"terminal.integrated.enableFileLinks": false. Works like a charm so far.

@yuqian90 great!

@Tyriar I have been using the insider version for a few days. So far I have not seen the previous problem where Code Helper use a lot of CPU and dtruss shows lots of stat64 operations. However, I still saw at least twice vscode froze (I could not save modified files or open new files, but the editor looks normal otherwise).
Maybe the terminal.integrated.enableFileLinks is not the only issue. I'll try to come up with perf timeline when I have time.

@yuqian90 that sounds like it would be another issue, maybe one of the existing electron-related ones? I haven't seen any freezing like that on my mac.

Let's call this fixed with the new setting now.

I gave a try to the new option this morning, but it doesn't seem to change anything on my system; vim is still very slow and one of the Code Helper process uses near 100% of my CPU 😕
Mac OS 10.15
Version: 1.39.0
Commit: 9df03c6d6ce97c6645c5846f6dfa2a6a7d276515
Date: 2019-10-09T06:57:43.593Z
Electron: 4.2.10
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Darwin x64 19.0.0

@stouf looks like you're seeing the slowness with drawing background colors for all cells, https://github.com/xtermjs/xterm.js/issues/2033 should hopefully fix that one eventually.

@Tyriar Great! Thank you for the reference, I'll follow 🙂


Fix rename import

Actually, we should adjust the code below that to use the BrowserRouter component, as that's what the text above it says. This import should be left alone.


Fixes: #648 Reassigned id to duplicates

Fixes: #648
Assigned new id 37 and 38.

@thesanjeevsharma should I assign id 14 and 16 instead of 37 and 38 because they have not been assigned to anyone yet.

Bucky has already fixed the id. Closing this.


Fix incorrect generation of count on selectables

Closes #1202
cc @earney

@earney this was a bit hairy ... happy to walk you through how and why the fix works if you want

Phillip,
I'll take a look at the bug fix, and if I have any questions, I'll let you
know.
Thanks!
On Thu, Aug 13, 2015 at 10:40 AM, Phillip Cloud<EMAIL_ADDRESS>wrote:

@earney https://github.com/earney this was a bit hairy ... happy to
walk you through how and why the fix works if you want
—
Reply to this email directly or view it on GitHub
https://github.com/ContinuumIO/blaze/pull/1206#issuecomment-130732958.

@llllllllll any more comments here?

I think we are good.  Thanks for working on this!
On Thu, Aug 13, 2015 at 12:05 PM, Phillip Cloud<EMAIL_ADDRESS>wrote:

@llllllllll https://github.com/llllllllll any more comments here?
—
Reply to this email directly or view it on GitHub
https://github.com/ContinuumIO/blaze/pull/1206#issuecomment-130762420.

lgtm


Can someone help me develop a animated bg change event?

Describe your problem here.
Hello I was wondering if someone could help me script a animated bg change event for nicos rap bots! It would be so helpful if possible!
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No response

`
function onCreate()
     makeLuaSprite('stage1', 'bg', 0,0)
      addLuaSprite('stage1', false)

      makeLuaSprite('stage2', 'bg2', 0,0)

end
function onStepHit()
if curStep == 1 then
addLuaSprite('stage2', false)
end
end
`

thx


Upload fails: internal server error

Hi there!
I'm writing an application to upload images to deviantart; the authentication step goes fine and I can receive the access token, but when I try to upload a photo to stash/submit I get this as reply:
{"error":"server_error","error_description":"Internal Server Error.","status":"error"}

Is the server down, or could the problem be due to my request? And could the error message be made more helpful?

Found out the issue: it's necessary to specify the file name of the uploaded file.

Can you please provide some code i am getting that problem too. @mardy

@ananmelkonyan When building the form-data request, make sure you inglude both the filename and name parameters, like this: https://stackoverflow.com/a/46150309/6113088
If you are doing that already, then your problem is probably different, and I cannot be of help. :-)

@mardy thank you for quick reply,
here my debug array
`Array
(
[title] => test file
[artist_comments] => 1
[file] => CURLFile Object
(
[name] => zebra_8.jpg
[mime] => image/jpeg
[postname] => zebra_8.jpg
)
[access_token] => access_token

)`
if your code php can you provide more details? :)

@mardy or if you can provide me request build part

Sorry @ananmelkonyan, my code is in C++/Qt, so I'm afraid it wouldn't be of help.

Dear @mardy its ok i can read c++, need just see configuration on file output, i followed your suggest but its throw me server error.


Ability to disable/omit crossorigin HTML attribute on link and script tags

Is your feature request related to a problem? Please describe.
I'm facing an issue where production resources (js + css) included from the vite_javascript_tag are blocked due to CORS errors - specifically because crossorigin=anonymous is default setting here. This is problematic when assets are on served via a cdn for example and a site is hosted from a different domain.
Describe the solution you'd like
Could we have a way to opt out of or disable setting crossorigin on the generated <script> and <link> tags?
crossorigin="use-credentials" does not seem to work, and crossorigin="" maps to anonymous.
Describe alternatives you've considered
The only alternative that currently comes to mind is for us as users of vite_ruby is to configure headers on the resources server to allow the cross origin request from the site domain(s).
Additional context
For compatibility reasons, we are using vite_rails_legacy.

Hi Devon!
You can use crossorigin: nil to skip the attribute:
vite_typescript_tag 'application', crossorigin: nil

renders
<script src="/vite-dev/assets/application.2bcd08cf.js" type="module"></script>
<link rel="modulepreload" href="/vite-dev/assets/example_import.57b991ca.js" as="script">
<link rel="stylesheet" href="/vite-dev/assets/application.c9d9ac92.css" media="all">

If using crossorigin: nil does not work in your use case, please share a minimal repo with the same Rails version you are using and I can take a look.
Have in mind that I created vite_rails_legacy for migration purposes, but I'm not using it myself, and I have little interest in supporting it.

That did the trick, thank you @ElMassimo! And also thanks for the note re: vite-rails_legacy - hopefully we will not be using it for too long.

Just noticed that you work in Vimeo! By any chance do you know Max Jacobson?

@ElMassimo indeed I do! @maxjacobson is my manager :)

👋🏻 heh hey guys

Hi @ElMassimo ,
I am also facing this issue and added crossorigin:nil to the script. But the browser sets Fetch Metadata Request Headers like Sec-Fetch-Mode :cors to the request and this still causes CORS errors while fetching the script.
Note script is on a different domain and hosted on CloudFront CDN . Can you suggest any way we can prevent browser from adding this Fetch Metadata Request Headers ?

@pranaybinju Haven't run into that situation. I'd recommend checking in StackOverflow, or opening a Discussion providing more details, so that it's easier to find your post, and other people can help you 😃

@pranaybinju Haven't run into that situation. I'd recommend checking in StackOverflow, or opening a Discussion providing more details, so that it's easier to find your post, and other people can help you 😃

Hi @ElMassimo
I posted this query on StackOverflow and it seems that type=module which gets added to the script is causing the CORS issue. Is there any way to remove it or any other value to add for it to bypass this?

No, all scripts in Vite will be type=module, except when @vitejs/plugin-legacy is used.
Removing it would cause the bundled code to stop working.

@pranaybinju
I also had this issue also using CloudFront CDN. Adding a Response Policy under my distribution resolved the problem. Leave the type as module as mentioned above.


feat: add semantic_release

fix: https://github.com/casbin/k8s-gatekeeper/issues/26

@PokIsemaine fix:


Migrate react-scripts to v5.

Currently, react-scripts at version 5 or later breaks, giving the following issue:
$ npm start

><EMAIL_ADDRESS>start
> react-scripts start

Invalid options object. Dev Server has been initialized using an options object that does not match the API schema.
 - options.allowedHosts[0] should be a non-empty string.
...

react-scripts must therefore be set to version 4.0.3 to avoid this issue. This issue likely occurs because of the "proxy": "http://localhost:5000" used in package.json, see https://stackoverflow.com/questions/70374005/invalid-options-object-dev-server-has-been-initialized-using-an-options-object

looks like this has been resolved?


Conditional formatting errors when setting an invalid date string

Description
Invalid DateTime strings cause conditional formatting errors that result in an unrecoverable state.
NOTE: #1091 and #1106 should fix related issues. Might be good to wait until those are merged before working on this fix.
Steps to reproduce

Load a table with a DateTime column
Table Options -> Conditional Formatting -> Add New Rule
Select date column, "is exactly", "blah" for condition
Set Style to something other than "No formatting"

Expected results
Invalid DateTime strings should not be applied

Done button should be disabled
Auto formatting should not be applied
No error should be shown

Actual results
Formatting is auto-applied for invalid date format and a "Unable to open table. Error" is shown
Versions
Engine Version: 0.22.0
Web UI Version: 0.30.1
Java Version: 17.0.6
Barrage Version: 0.5.0

@dsmmcken it looks like we do support shorter date time formats as long as they have the TZ.
e.g. 2023-02-23 NY works fine.
Do we want to keep this restriction, or should we default to the local time zone if none is provided?

It looks like the Java code supports a discreet set of timezone codes. In io.deephaven.time.TimeZone, we have the following enum:
TZ_AL(DateTimeZone.forID("America/Anchorage")),
TZ_AT(DateTimeZone.forID("Canada/Atlantic")),
TZ_BT(DateTimeZone.forID("America/Sao_Paulo")),
TZ_CE(DateTimeZone.forID("Europe/Berlin")),
TZ_CH(DateTimeZone.forID("Europe/Zurich")),
TZ_CT(DateTimeZone.forID("America/Chicago")),
TZ_ET(DateTimeZone.forID("America/New_York")),
TZ_HI(DateTimeZone.forID("Pacific/Honolulu")),
TZ_HK(DateTimeZone.forID("Asia/Hong_Kong")),
TZ_IN(DateTimeZone.forID("Asia/Kolkata")),
TZ_JP(DateTimeZone.forID("Asia/Tokyo")),
TZ_KR(DateTimeZone.forID("Asia/Seoul")),
TZ_LON(DateTimeZone.forID("Europe/London")),
TZ_MN(DateTimeZone.forID("America/Chicago")),
TZ_MOS(DateTimeZone.forID("Europe/Moscow")),
TZ_MT(DateTimeZone.forID("America/Denver")),
TZ_NF(DateTimeZone.forID("Canada/Newfoundland")),
TZ_NL(DateTimeZone.forID("Europe/Amsterdam")),
TZ_NY(DateTimeZone.forID("America/New_York")),
TZ_PT(DateTimeZone.forID("America/Los_Angeles")),
TZ_SG(DateTimeZone.forID("Asia/Singapore")),
TZ_SHG(DateTimeZone.forID("Asia/Shanghai")),
TZ_SYD(DateTimeZone.forID("Australia/Sydney")),
TZ_TW(DateTimeZone.forID("Asia/Taipei")),
TZ_UTC(DateTimeZone.UTC);

When we run an expression such as convertDateTime('2020-01-01 NY'), the TZ_NY, we parse the NY and map to the TZ_NY. There doesn't seem to be support for any timezones outside of these enum values. As far as I can tell, we don't have any way to validate these shorthand timezone enum values in the frontend, so we can't really tell if a given date string is valid until it passes or fails on the backend.

We can use dh.i18n.TimeZone.getTimeZone() –
dh.i18n.TimeZone.getTimeZone('TEST'); // throws "java.lang.IllegalArgumentException: Unsupported time zone TEST"
dh.i18n.TimeZone.getTimeZone('NY'); // returns a JsTimeZone object

I have added datetime + timezone parsing for frontend validation.
There is an open bug https://github.com/deephaven/deephaven-core/issues/3472 to address an issue with the query engine's current timezone support.


Human readable address format of Jörmungandr has changed

Release
Operating System
Cause

next
Windows & OSX & Linux)
Code  v Configuration v Environment v Human v Unknown

Context
The user-facing encoding of Jörmungnadr addresses is bech32 which contains an human readable part (hrp) and a data part. Previously jcli used ta as hrp for the testnet network, and ca as hrp for the mainnet network.
Now 1) jcli uses ca when generating addresses regardless of network, 2) it provides a way for users to change hrp as they want, and 3) doesn't care which one is used when decoding
Relevant thread: https://input-output-rnd.slack.com/archives/CCPKJ93Q9/p1565775119035900

Steps to Reproduce

Input addresses to the wallet via the CLI or API
Get the wallet to output addresses via the CLI or API

Expected behavior

Wallet reads addresses with any Human Readable Part.
Wallet defaults to using ca as Human Readable Part, even on testnet, for output.

Unconfirmed: Should the wallet remember the Human Readable Part for all addresses? Otherwise a user may input a ta1s4... address and get ca1sw... back.
Actual behavior
Actual behaviour is unconfirmed, but likely wrong.

---
Resolution Plan

PR

Number
Base

#?
develop

QA

@Anviking Thanks for opening this.
Although Jörmungandr doesn't enforce any particular hrp for addresses anymore, I think we (as a user-facing app) still should. The node has a free format, precisely for allowing clients to choose one that is relevant for them. Since the encoding doesn't really interfere with the binary format, there's not much worry to have about addresses we would get from the node / network itself (unencoded). So, bech32 only occurs at the edge of our system:

The API
The config file

and for those, I'd find it clearer to keep the visual discrimination in the hrp.  Though, that's a product decision to be confirmed.

Discussion: https://input-output-rnd.slack.com/archives/GBT05825V/p1571838723033200?thread_ts=1571837252.031500&cid=GBT05825V

So it appears that this is confusing quite a lot of people when playing with the explorer and the wallet. Being consistent with Jörmungandr and the explorer would help dispelling this confusion. Will do.

lgtm!


FLUID-5757: First round of a new Preferences Framework tutorial

@jobara: This pull request is dependent on the Infusion example code in https://github.com/fluid-project/infusion/pull/629 – that should be merged first.
This tutorial should suffice to replace the tutorial that's already there. I'm currently looking at those pages to make sure that any information that's there finds an appropriate home before we remove them, but I though that a review of this new file could get started while I do that.

Just a note: I also still need to work on the mobile version of the 'callout' boxes.

Dana commented in the channel:  the in-line pins seem like they'd be easy to miss - I wonder if we made them the same size as the pins you have in the boxes, and have them in-line with the text (i.e. not superscripted)? if we keep them pointing toward the word and possibly also do something on hover & focus (highlight the callout box in some way) I think this will make it clear what they are referring to. In mobile perhaps we could have them open up over the text on touch? (in this case they'd def need to be bigger)

@jobara: FYI, I'm keeping my github pages version up-to-date with this branch, so you can see the deployed version here: http://acheetham.github.io/infusion-docs/infusion/development/tutorial-creatingAPreferencesEditorUsingThePreferencesFramework/PrefsFramework.html

@jobara I think I've addressed your lastest coments.

@jobara I've responded to your comments and updated to the latest master. I've restructured the folders and filenames a bit to clean it up, so please a) see if it makes seems like a reasonable improvement, and b) didn't break any links :-)

@jobara, I've updated the tutorial (and associated code pull request) to reflect the discussions around the primary schema and namespacing.

Merged at 00013849f2f06bccd2b89246a00c280a6544a0b8


Replace execution_timeout with timeout in sensor

Use timeout instead of execution_timeout in Async Sensors for deferrable timeout arg
Sensors have a timeout parameter. This only matters for sensors in reschedule mode. timeout controls the maximum time allowed for the sensor to succeed. If the timeout is breached, AirflowSensorTimeout will be raised and the sensor fails immediately without retrying. So when we defer for sensor we need to send timeout rather than sending execution._timeout.
Inherited BaseSensorOperator because the timeout is a parameter in that class, so we inherited that and use it when we defer.
Closes #513

Use timeout instead of execution_timeout in Async Sensors for deferrable timeout arg
Closes #513

Can you explain why timeout is used  instead of execution_timeout and why the BaseSensorOperator is inhertited

Use timeout instead of execution_timeout in Async Sensors for deferrable timeout arg
Closes #513

Can you explain why timeout is used instead of execution_timeout and why the BaseSensorOperator is inherited

Sensors have a timeout parameter. This only matters for sensors in reschedule mode. timeout controls the maximum time allowed for the sensor to succeed. If the timeout is breached, AirflowSensorTimeout will be raised and the sensor fails immediately without retrying. So when we defer for sensor we need to send timeout rather than sending execution._timeout.
Inherited BaseSensorOperator because the timeout is a parameter in that class, so we inherited that and use it when we defer.

Can you test once after this changes

I tested all the sensor dags after the changes. I can retest if needed.

Sensors have a timeout parameter. This only matters for sensors in reschedule mode. timeout controls the maximum time allowed for the sensor to succeed. If the timeout is breached, AirflowSensorTimeout will be raised and the sensor fails immediately without retrying. So when we defer for sensor we need to send timeout rather than sending execution._timeout.
Inherited BaseSensorOperator because the timeout is a parameter in that class, so we inherited that and use it when we defer.

Copying this in the description

LGTM @pankajkoti @phanikumv @pankajastro what do you guys think?

@phanikumv can you please take a look at the PR review changes ?

@rajaths010494 I hope you have addressed the Review comments on this PR, Need your confirmation?

@rajaths010494 I hope you have addressed the Review comments on this PR, Need your confirmation?

Yes, I have addressed the review comments and also rebased the branch.

Waiting for the release to close this


GC+: Mark and Sweep

Enable mark and sweep functionality for uncommitted GC

It might be better to allow just a mark at first phase. @johnnyaug


Automate pypi release

This will be added once 0.0.1 is uploaded to pypi

Combined this PR into #9


Add components section to improve reusability through referencing within the spec

It's currently possible to compose a workflows document and reference other workflow documents, but referencing capabilities of steps and/or reusing step inputs across workflows or steps is limited.
The current scope and referencing of inputs and outputs for steps and workflows is described by the following picture:

Defining workflow inputs, steps and/or step inputs under a global components section (similar to OpenAPI) could bring better reusability through referencing.
Proposal for Components within the Workflows Specification
Components
Holds a set of reusable objects for different aspects of the Workflows Specification. All objects defined within the components object will have no effect on the workflow unless they are explicitly referenced from properties outside the components object.

Field Name
Type
Description

inputs
Map[string, Schema Object]
An object to hold reusable JSON Schema objects to be referenced from workflow inputs. Remark: possibly trimmed down version of OAS Schema Object

steps
Map[string, Step Object]
An object to hold a reusable Step Objects.

parameters
Map[string, Parameter Object]
An object to hold reusable Parameter Objects

possibly trimmed down version of OAS Schema Object

@frankkilcommins what would be the rationale for a cut-down schema object? We have got ourselves into a right state in OAS with subset-superset-sidesets before.

I added reference objects just now. Incorporating them into Steps and Parameters was no problem. However, because the workflowInputs is defined to be a JSON Schema object, it's a little more difficult - we need to embed reference objects inside that JSON Schema. Can we modify workflowInputs to something like an array of JSON Schema or reference object? Something like [JSON Schema | Reference Object].

@shaisachs doesnt the schema object allow $refs anyway?

I think so... But I guess we need to mention that in the system and provide some examples.


Print content of columns for gtest

Feature Request
Is your feature request related to a problem? Please describe:

Describe the feature you'd like:

Print content of columns for gtest. BTW, It's just for the convenient of debug, so it can only be used in gtest.
Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

/assign


do not relay only on ctypes.util.find_library

there are situations where find library does not work, there are also people that do not want to install (make install) to standard paths. Provide a way how to specify location of so/dll

fixed in https://github.com/scgbckbone/python-secp256k1/pull/5/f


Deepdream for Mobilenet V2 COCO model

I'm trying deepdream_visualization on ssdlite_mobilenet_v2_coco model by modifying the tf_cnnvis_Example3.ipynb. I have set the input layer to FeatureExtractor/MobilenetV2/MobilenetV2/input and visualisation layer to import/FeatureExtractor/MobilenetV2/layer_19_2_Conv2d_5_3x3_s2_128/BatchNorm/batchnorm/add_1
Given these layers, deepdream_visualization generated uninterpretable image as shown below

I'm not sure if I have chosen the correct layers for input and visualization. Any pointers on this would be very useful
Thanks

Modified notebook for ssdlite_mobilenet_v2_coco model can be found in https://github.com/endeepak/tf_cnnvis/blob/master/examples/tf_cnnvis_Example3.ipynb
Changes can be found in commit https://github.com/endeepak/tf_cnnvis/commit/96d7a452de40fd28aa743d059bd2e0d0af18a6e2#diff-3d2ac2a68d31d5613fd599622217b371

I was able to figure out the correct input and output layers using tools/graph_transforms:summarize_graph from tensorflow docs. I'm currently stuck with issue https://github.com/InFoCusp/tf_cnnvis/issues/26
Layer name changes can be found here https://github.com/endeepak/tf_cnnvis/commit/93d4d2ed1f72158baa4c72857e7d4db091ebdc46

Hi @endeepak
Sorry for the late reply. Thanks to your model, we were able to figure out the cause for the NoneType error in issue #26. It occurs when one of the layers/ operations in the model does not have a gradient defined for it. In this case, forward pass and hence activation visualization would work fine but back propagation or de convolution would not work and hence gives the NoneType error.

Closing this for lack of activity. Reopen if needed.


Upgrade version.jooq 3.14.11 -> 3.14.12

This PR contains the following updates:

Package
Update
Change

org.jooq:jooq-meta-extensions
patch
3.14.11 -> 3.14.12

org.jooq:jooq-codegen-maven
patch
3.14.11 -> 3.14.12

org.jooq:jooq-meta
patch
3.14.11 -> 3.14.12

org.jooq:jooq-codegen
patch
3.14.11 -> 3.14.12

org.jooq:jooq
patch
3.14.11 -> 3.14.12

[ ] If you want to rebase/retry this PR, check this box.

Suggested commit message:
Upgrade jOOQ 3.14.11 -> 3.14.12

See:
- https://www.jooq.org/notes
- https://github.com/jOOQ/jOOQ/compare/version-3.14.11...version-3.14.12


dear owner

Hi can you please leave your skype and email address im trying to get in touch with you

Making it visible in profile for a few minutes.

Visible now. Check my profile.


[[FEATURE REQUEST]] Batch Edit: Add to Library function // Playlist: Add to Library function

Awesome app, been following for a while.
Quick suggestion about adding a new functionality.  Selecting an individual song not in your "My Library", you can select "Add to library" as an option.  But when you select more than one song, that option disappears.  This is true for both GPMDP and Google's own web player.
There is also currently no option to "Add to Library" for entire playlists.
Is there any way to add songs in groups or by entire playlist, to the My Library?
This would make my music browsing so much easier, because then I can just stay in the "My Library" pane and sort/browse the contents of playlists as well.
Thanks!!!

This is something that should be directed at Google Play Music itself. Unfortunately adding code for this would be very challenging, and the code would break spontaneously for even minor changes to the music web service.  Overall not something that would be supported by this project.

Cool, thanks for the quick reply! Cheers man.

In agreement with @jostrander


Read info from USB disks

Hi, smartctl is able to read S.M.A.R.T info from sata disks connected via USB adapter.
Would be cool if crazydiskinfo could do the same.

crazydiskinfo uses libatasmart which says in it's readme:

libatasmart supports classic ATA/IDE disks (i.e. /dev/hda) as well as ATA disks that are connected through a SCSI layer (SAT) (such as a SATA /dev/sda).
USB disks generally don't support SAT and thus generally cannot be queried for S.M.A.R.T. data.

So crazydiskinfo would need to turn to something like smartmontools to support USB.


support object storage module with replication

Describe the Feature
module: object storage module
version:
oci version:
description: This feature gives the ability to create object storage replica

There was no option to change the type of issue only a bug was available


CB-14193 - Validate for stopped/unreachable FreeIPA before upgrade

This code includes:

extra validation flow step for checking FreeIPA status
little simplification of SdxStatusService#getShortStatusMessage not to write out the same message multiple times

Thank you both @tiborpopovics and @foldik


Modify streams

These changes are for the admin page managing streams tab.

removeStreams will be done in a separate PR
streams query will be done in a separate PR
enabled field will be added to streams table in a separate PR

With update I still have:


fix: create executables in correct package

PR summary
This PR adjusts the "pkg" command so that it is ultimately run only in
the validator package.
Signed-off-by: Phil Adams<EMAIL_ADDRESS>PR Checklist
General checklist
Please make sure that your PR fulfills the following requirements:

[ ] The commit message follows the Angular Commit Message Guidelines.
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] Dependencies have been updated as needed
[ ] .secrets.baseline updated as needed?

Checklist for adding a new validation rule:

[ ] Added new validation rule definition (packages/ruleset/src/rules/*.js, index.js)
[ ] If necessary, added new validation rule implementation (packages/ruleset/src/functions/*.js, updated index.js)
[ ] Added new rule to default configuration (packages/ruleset/src/ibm-oas.js)
[ ] Added tests for new rule (packages/ruleset/test/*.test.js)
[ ] Added docs for new rule (docs/ibm-cloud-rules.md)

:tada: This PR is included in version 0.44.4 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 0.96.5 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:


check the size of HTTP3 HEADERS frames before allocating

Codecov Report

Merging #2085 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2085      +/-   ##
==========================================
+ Coverage   85.56%   85.57%   +0.01%
==========================================
  Files          99       99
  Lines        7221     7228       +7
==========================================
+ Hits         6178     6185       +7
  Misses        762      762
  Partials      281      281

Impacted Files
Coverage Δ

http3/server.go
52.83% <100%> (+1.61%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2133d01...363de01. Read the comment docs.


[schema registry] set release date and update README

Set changelog release date and update README:

aka.ms link for setting up service (will get populated later)
correct logging info
removed unnecessary header and clean up some text in credentials part

EDIT: Removed tests.yml changes from this PR as there is no additional coverage over nightly CI if we run in playback, I will start a new PR with tests.yml when service is ready.

/check-enforcer evaluate

/check-enforcer override

/check-enforcer evaluate

/check-enforcer reset


Add TypeScript versions blog

Description
Checklist:

[x] I have reviewed the style guide.
[x] If blogging, I have reviewed the blogging guide.
[ ] I have manually confirmed that all new links work.
[ ] I added aliases (i.e., redirects) for all filename changes.
[ ] If making css changes, I rebuilt the bundle.

Thank you for the thoughtful review @mikhailshilkov! I updated the PR with your suggestions.


add pyproject.yaml

since pip 10, pyproject.yaml is supported. It can be used to have pip
install numpy before running setup.py. So we can remove custom numpy
injection logic.

Thanks! What will happen for people with older pip? Can you add a pip version as a requirement?

they will have to install numpy first or upgrade pip

you cannot add pip min version, same as setuptools

@akshayka what do you think? I really appreciate the contribution, and it is cleaner, but I'm hesitant to break the installation for old versions of pip.

Is the NumPy injection a big issue? I suspect most people using CVXPY will already have NumPy installed, whereas many people might not have pip 10, which is only a year old. So the lesser of two evils, at least right now, might be to keep things as is, even if adding a pyproject.toml file is the correct thing to do.

if you git blame I added this header injection myself, but later found this better solution. So this was failing already for those who don't have numpy installed.

Oh, I wasn't aware of the history of the injection logic --- thanks for your contributions! :)
pip 10 seems like it came out just over a year ago (https://pip.pypa.io/en/stable/news/#id119). I wouldn't be surprised if many folks haven't upgraded yet, but I have no data on this. Have pip 10 / pyproject.toml's been adopted widely / how can we find out if they've been adopted widely?

Could we leave the numpy injection and also have the pyproject.toml file? Maybe that would help with #724.

yes, i think it does help with #724, at least in my local tests

Ok, I added a pyproject.toml. I'll leave the numpy injection as it is in case people don't have pip 10. Thanks for your contribution!


[YUNIKORN-2609] Improve visual style of the Web UI

What is this PR for?
Improve visual style of the Web UI
The full design can be previewed on this link: [ DESIGN ]

Fix padding/margin values
Add rounding on elements to match the design (menu selection, dropdowns, etc)
Fix font weight on visual elements to match the design

Detail:

Sidebar navigation UI
Header right top help button change icon
Global => Form Field (Input, Select) to be density
Dashboard page

Chart Card title & content => padding
Chart Card title => font size & font weight
Application Status & Container Status chart-legend => font weight

Applications page

Table header row =>  font weight

Nodes page

Table header row =>  font weight
indicator field => fix align & remove extra gap

What type of PR is it?

[x] - Improvement

What is the Jira issue?
YUNIKORN-2609
Screenshots (if appropriate)

Before
After

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 35.71%. Comparing base (5856427) to head (dd2558c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #213   +/-   ##
=======================================
  Coverage   35.71%   35.71%
=======================================
  Files           2        2
  Lines          56       56
=======================================
  Hits           20       20
  Misses         33       33
  Partials        3        3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Hold this PR for a few days to see if @dcoric or @wilfred-s  have capacity to double confirm.

+1 LGTM I have tested it locally and it looks good.

Only committers should be adding +1/-1 to comments.


Render hidden - allow user to change cookie settings

Hey,
can you add option to render the form, but don't show it?
I can render if cookie consent is not set, but after this the form is not redered at all. I want to have a clickable button, so user can bring the form up and change cookie settings anytime.

As far as I know the form is rendered when you want it to be rendered. So if you change the check when it should be rendered or put a "hidden" element around it, you should be able to achive what you want, no?

Yeah, that's one option - second is to do a ajax call rendering form when needed. Thanks. :)


docs(suspensive.org): fix typo Image -> SuspenseImage

Overview

fix typo Image -> SuspenseImage

AS-IS

TO-BE

PR Checklist

[x] I did below actions if need

I read the Contributing Guide
I added documents and tests.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.25%. Comparing base (9ecaa7b) to head (4b0c77b).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1148   +/-   ##
=======================================
  Coverage   75.25%   75.25%
=======================================
  Files          62       62
  Lines         594      594
  Branches      117      117
=======================================
  Hits          447      447
  Misses        137      137
  Partials       10       10

Components
Coverage Δ

@suspensive/utils
47.16% <ø> (ø)

@suspensive/react
95.74% <ø> (ø)

@suspensive/react-query
67.66% <ø> (ø)

@suspensive/react-query-4
0.00% <ø> (ø)

@suspensive/react-query-5
0.00% <ø> (ø)

@suspensive/jotai
0.00% <ø> (ø)

@suspensive/cache
98.23% <ø> (ø)

@suspensive/react-image
80.39% <ø> (ø)


Use IsAllowed in non generated code

Description
Remove deprecated Allowed method and replace it with IsAllowed
Testing Performed
CI

Current dependencies on/for this PR:

master

PR #2800

PR #2726

PR #2722

PR #2750

PR #2751

PR #2752

PR #2774

PR #2775

/retest

/retest

/retest

/retest

Graphite Merge Job
Current status: ⏳ Queued to merge
This pull request is currently queued to be merged as part of a stack.
This comment was auto-generated by Graphite.

Job Reference: KaXF6lRV7xj8fvvZbgOl


Nativefier broken, does not work anymore

Description
All of a sudden Nativefier stopped working. I tried to update nativefier to the newest version, nothing :/
nativefier spits out an error everytime you try to build an app, even with $ nativefier --version.
Specification:
$ nativefier --version
/usr/local/lib/node_modules/nativefier/node_modules/electron-packager/index.js:3
const common = require('./common')
^^^^^
SyntaxError: Use of const in strict mode.
    at exports.runInThisContext (vm.js:73:16)
    at Module._compile (module.js:443:25)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/source/build/buildMain.js:2:1)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)

I really hope this can be fixed!

Ok, could fix it by using this one .
Sorry, could have looked up this solution earlier, I didn´t see there was a similar issue.


cockroach dump Iteration 2

Background: https://airtable.com/tblD3oZPLJgGhCmch/viw5Jsp2TrY3it9Yr/recYPruH2ox7mKZOg
PM: @rolandcrosby
Eng: @mjibson

Moved out of scope for 2.2.


Unable to generate self signed cert

When I start kube-apiserver, I could see the log complain about the permission to create /var/run/kubernetes and unable to generate self signed cert.
Jan 13 14:14:51 dhcp-9-197.nay.redhat.com kube-apiserver[15354]: E0113 14:14:51.002554   15354 apiserver.go:260] Unable to generate self signed cert: mkdir /var/run/kubernetes: permission denied
Jan 13 14:14:51 dhcp-9-197.nay.redhat.com kube-apiserver[15354]: E0113 14:14:51.002597   15354 apiserver.go:266] Unable to listen for secure (open /var/run/kubernetes/apiserver.crt: no such file or directory); will try again.

#chown kube:kube /var/run

solve this issue.

@ouyanggh -- are you using some of the cluster start scripts under cluster/...?  If so, we should probably make sure we fix that up.


Import batch problems

Hello All.
maatwebsite excel Version 3.1
it works fine without WithBatchInserts
While using batch import i get Duplicate entry 'X' ( while X changes as i refresh page )
below i set few images from my code .
so Question is  , what i`m doing wrong ? File for import is too big so it uses up to 5-8m , so trying to speed it up ... any suggestions ?

<?php

namespace App\Imports;

use App\Promo;
use Carbon\Carbon;
use Maatwebsite\Excel\Concerns\Importable;
use Maatwebsite\Excel\Concerns\ToModel;
use Maatwebsite\Excel\Concerns\WithHeadingRow;
use Maatwebsite\Excel\Concerns\WithBatchInserts;
use Maatwebsite\Excel\Concerns\WithChunkReading;

class PromosImport implements ToModel, WithHeadingRow ,WithBatchInserts ,WithChunkReading
{
    use Importable;

    private $code;

    private $amount;

    private $type = 'PERCENT';

    private $active = 1;

    private $active_date;

    private $per_user;

    private $count = 1;

    public function __construct($options)
    {
        $this->amount = $options->amount;
        $this->active_date = Carbon::parse($options->activeDate)->format("Y-m-d H:m:s");
        $this->per_user = $options->per_user;
        if (strpos($options->amount, '%') === false) {
            $this->type = 'CURRENCY';
        } else {
            $this->amount = str_replace('%', '', $this->amount);
        }
    }

    /**
     * @param array $row
     *
     * @return \Illuminate\Database\Eloquent\Model|null
     */
    public function model(array $row)
    {
        $code = str_replace('#', '', $row['piradi_nomeri']);
        return Promo::updateOrCreate(
            ['code' => $code],
            [
                'amount' => $this->amount,
                'type' => $this->type,
                'active' => $this->active,
                'active_date' => $this->active_date,
                'count' =>$this->count,
                'per_user' => $this->per_user,
            ]);
    }

    public function batchSize(): int
    {
        return 1000;
    }
      public function chunkSize(): int
    {
        return 1000;
    }
    // public function headingRow(): int
    // {
    //     return 2;
    // }
}

In the docs, it is stated that:

When using ToModel you should never save the model yourself, as that will break the batch insert functionality.

You're using return Promo::updateOrCreate(

@GlennM So there is no way this to work as is ?

@snowket not with batch inserts. We cannot batch insert a create or update.


fuse: Add directory entries . and ..

The restic fuse mount does not include the directory entries . and .., which are not necessary for browsing the snapshots via fuse (so cd .. works just fine), but this may be confusing for users.
This issue tracks adding those entries.

I will investigate this.

Ok, cool!

For the backup tree, it is working.
However, there is one problem remaining.
The generated directories (representing the snapshots) and the snapshots dir should have a sound inode that do not collide with the inodes for the files and dirs in the backup.

Hm, good point. Maybe use very small inode numbers? Or a mapping table that does translation in case there is a conflict?

Yes, a translation table was also my thought.
All in all it requires quite some work:

mapping table to avoid inode collision
the current code (mainly snapshot.go) collapses three things:

serve as fuse root
provide snapshots dir
provide the dirs for the individual snapshots

So far, I separated the last two parts.
It will take some time ...

Sure, no rush. Let me know when you need feedback on sample code or so.

Well, after some thinking, I discovered the following:
Restic backups can come from multiple physical disks. So, the same inode can actually refere multiple, and different, files. This can happen if these files are on different disks.
In principle, this is represented in the meta data of the backup, namely in the inode and dev field.
Fuse (at least the bazil implementation) only supports the inode field for stat.
So, I guess there should be a generation of the fuse inod, based upon the inode/dev metadata in the backup.
Problem: both the inode and dev fields in the backup meta data are uint64, whereas the inode field in fuse is also uint64.
Any suggestions how to deal with this?

Hm, you're right. I think we need a global mapping table for this use case anyway, so we can assign a different inode when a collision occurs (e.g. orig_inode XOR orig_device or so)

The problem is even worse; multiple snapshots of the same disk (in time) have files with the same inode and device combination. They are however all accessable via the same fuse mount. Therefore the inodes are nout unique across the fuse file system.
The overall problem is that inodes (represented as an uint64) of different disks and/or snapshots should be mapped into one fuse inode space (also uint64). Obviously, we can end up in the situation that are more inodes than fit into one uint64 space, theoretically 2^64*#disks*#snapshots.
The practical side of the problem is that ext4 seems to have 32 bits for the inode.
So my proposal the following:
1 The 64 bits of the uint64 that is used to represent the inode is used as follows:

bits 57-64 9 (snapshot bits) are used to represent the snapshot id (via a mapping table of the restic snapshot ID and the snapshot bits), the mount point, and the "snapshots" dir. This allows for 2^8-2 (254) snapshots accessible via fuse. This seems to me a reasonable amount.
bits 50-57 (device bits) are used to represent the device id as stored in the metadata, again with a mapping table between the bits and the device id. This allows for max 256 disks in a restic backup.
bit 49 is used to indicate the use of bits 1-48. 0 means inode based on derivation, 1 means inode based on mapping tables
bit 1-48 i used to represent inodes as they come from the meta data. Since ext4 seems to have 32 bits for inodes, this fits easily. In case the inode is > 2^48, mapping tables are used. I think the need for mapping tables is very limited.
If bit49 == 0 then the fuse inode is calculated as inode (bit1...48) | device-bits | snapshot bits
if the inode of the metadata > 2^48, then it is mapped into a mapping table, which gives another 2^48 to deal with such exceptions.

The advantage of this solution is that in normal cases we can calculate the fuse inode by using the inode in the meta data, the device id, and the snapshot. This avoids time consuming table lookups. In case we run out of inode space there is a facility to deal with these situations (bit49=1).
What do you think?

Oh, that's indeed a bigger problem than I imagined. To be honest, I think your proposal is too complex. What about just having a lookup table for ALL inodes, e.g. like this:
type inodeKey struct {
     Snapshot uint64
     Inode uint64
     Device uint64
}

var inodes = make(map[inodeKey]uint64)

Then compute the key as follows:
key.Snapshot = crc64(snapshot.ID)
key.Inode = node.Inode
key.Device = node.Dev

And assign a new random inode and use that for the remainder of the fuse session:
inodes[key] = rand.Uint64()

(access syncronisation is missing here, obviously)

I see two problems hete:

You should build a table for all files. In any serious filesystem that can become large, with all the performance problems that come with that.
The solution I propose calculates the inode on the fly, and requires only a table for exceptions, which should not occur for ext4 filesystems at all. 2. Randomly assigning has the (limited) danger of inode collisions

I've fixed this issue in #1048, I'm using a deterministic pseudo-random inode-calculator provided by the fuse library: http://godoc.org/bazil.org/fuse/fs#GenerateDynamicInode


feat: update to use Termwind for command output

This is a full re-write (in progress) of the rendered lists in Termwind. Hopefully this also closes #9, as it will standardise all of the commands to use similar output.

Looks good! I'll try it out later today 👍

Thanks! Sorry, didn't mean to rush you. I just realised you may have forgotten about it (and was hoping to release a new version, as v2.7.0 isn't compatible with PHP 8.1 👍🏻

You know what, I'll already merge and tag it 👍


Fix #3578: Author photo's get squashed when the bio is long

#3578
Addressed the issue, plus also addressed single long strings breaking the page.
Mutual issue

PR's commit also solves this issue

Awesome stuff, @shaz13. I'll have to wait for @petele to come back from vacation to review this. Please be patient, we probably will be able to get this in by end of next week or something :)

Also cc @paulkinlan because I think he should use your description in the future

Sure. I can wait 😊


Reportback view more fixes

Fixes #3848
Fixes #3908
This update fixes the logic with the View More button for the Reportback Gallery. There was a slight bug in the logic that was affecting the script knowing whether there were some last stragglers in the amount of Approved RBs in stock.
Also tested the script using different bundleSize and requestSize values and works great now. Increased the requestSize to 60, so the script gets a larger JSON file from the API.
@DoSomething/front-end

Looks great! :ship:


Upgrade CPM

I got this flagged warning
-- CPM: Adding package<EMAIL_ADDRESS>(v3.7.6_build_18)
CMake Warning (dev) at /usr/local/share/cmake-3.30/Modules/FetchContent.cmake:1953 (message):
  Calling FetchContent_Populate(vst3sdk) is deprecated, call
  FetchContent_MakeAvailable(vst3sdk) instead.  Policy CMP0169 can be set to
  OLD to allow FetchContent_Populate(vst3sdk) to be called directly for now,
  but the ability to call it with declared details will be removed completely
  in a future version.
Call Stack (most recent call first):
  build/cmake/CPM_0.38.6.cmake:1004 (FetchContent_Populate)
  build/cmake/CPM_0.38.6.cmake:798 (cpm_fetch_package)
  libs/clap/clap-wrapper/cmake/base_sdks.cmake:103 (CPMAddPackage)
  libs/clap/clap-wrapper/cmake/wrap_vst3.cmake:51 (guarantee_vst3sdk)
  clients/clap-first/CMakeLists.txt:35 (target_add_vst3_wrapper)
This warning is for project developers.  Use -Wno-dev to suppress it.

so upgrade CPM
which is now on 0.40.2

I guess I mentioned this in the PR but I used the wrong keyword, this can be closed now.

Oh it will close when next hits main. GitHub closes when an issue hits the default branch automatically if you use fixes or closes


Is this project working?

Hi! I think it has been 4 years and Actually I do not know is it working.
I was looking how to get area wise vehicle profile in OSM.
If you could help then please :100:

The code works, except perhaps for small changes in how OpenStreetmap represents map information.

how OpenStreetMap represents map information.
Did not get it.
I was using graphhopper {code}and jsrpit open source lib but problem is that I good accuracy of ETAs

If recently there have been any minor modifications in details of the XML format that OpenStreetmap uses, then those have not been reflected in this package yet.

Thaks you. Looking at issue I raised. Will get help. See you in some time.


Issues for contacts.html (from prototyping/views)

[ ] need to revamp whole page
[ ] need to have links back to the calendar and all that

General formatting and positioning of elements is done.


Automatically select from templates when new note is created

I would absolutely love it if we could have the feature that this new plugin provides
https://github.com/numeroflip/obsidian-auto-template-prompt

My issue with aforementioned plugin is that it doesn't come with YAML tags. Especially, not having template-filename means I can't have e.g. date-based file names automatically.

Nice idea! In the dev version, I've made it so that you can trigger the templates from anywhere, so it won't do it automatically with new files, but you can decide to add a new template at any point - hopefully that helps?


the postfix_map command should be run has a standard management command

No need to generate postfix_maps from the modoboa-admin script.
If you use a standard command, you can get the app context and avoid passing the --db-url parameters and plugins list (you can use settings.DATABASES and settings.MODOBOA_APPS).
You'll also be able to use the orm to generate maps (and avoid typo and other stupid bugs)
For instance, this will generate the correct query for the autoreply plugin:
>>> str(Transport.objects.filter(domain='%s').values('method').query)
'SELECT `postfix_autoreply_transport`.`method` FROM `postfix_autoreply_transport` WHERE `postfix_autoreply_transport`.`domain` = %s'

Using the ORM is a great idea but I don't agree with the --dburl parameter. It is required since you can use different users/credentials to access the database. For example, one user for modoboa, one user for postfix, etc.

Then settings can be used as default

Finally, I think using the ORM to output queries is not possible:
http://stackoverflow.com/questions/8112554/printing-django-queryset-sql-with


terraform_fmt.sh doesn't respect excludes

pre-commit has the ability to exclude files either globally or per hook.
The terraform_fmt.sh accepts a list of files to format.  However, it ends up simply running terraform fmt on the dirname of all the files.  This means if a file which is explicitly excluded in the .pre-commit-config.yaml file is sitting in the same directory as a file which is not excluded, it'll end up getting formatted.
The terraform_fmt.sh script should stop trying to be clever and simply run terraform fmt against the files explicitly handed to it and nothing more.

Can someone review this?

Works fine with the latest version
repos:
- repo: https://github.com/antonbabenko/pre-commit-terraform
  rev: v1.62.3
  hooks:
  - id: terraform_fmt
    exclude: environment\/.*$

\.terraform\/.*$ excluded globally from Aug 2019


[Bug]: Missing roles on token

Preflight Checklist

[X] I could not find a solution in the documentation, the existing issues or discussions
[X] I have joined the ZITADEL chat

Environment
ZITADEL Cloud
Version
No response
Database
None
Database Version
No response
Describe the problem caused by this bug
We saw this problem only once, but as it looks like an inconsistency, I thought I want to report it to you.
After the login using your login-form, we get the access_token from the code-exchange. This works perfectly fine, except once we got no roles within the token (which then in our app leads to an error screen).
Doing a new login we got the proper roles again.
Here is the content of the token where we missed the roles:
{
  "aud": [
    "XXXXXXXXXXXXXXX@micromate",
    "XXXXXXXXXXXXXXX@micromate",
    "XXXXXXXXXXXXXXX@micromate",
    "XXXXXXXXXXXXXXX@micromate",
    "XXXXXXXXXXXXXXX"
  ],
  "exp":<PHONE_NUMBER>,
  "iat":<PHONE_NUMBER>,
  "iss": "XXXXXXXXXXXXXXX",
  "jti": "V2_269380088506630730-at_269512542009720164",
  "nbf":<PHONE_NUMBER>,
  "sub": "119811590336930228",
  "urn:zitadel:iam:org:domain:primary": "micromate.ai",
  "urn:zitadel:iam:user:metadata": {
    "createdOn": "UHJvZHVjdGlvbg",
    "initialized": "dHJ1ZQ"
  }
}

And here the token how it usually looks like:
{
  "aud": [
    "XXXXXXXXXXXXXXX@micromate",
    "XXXXXXXXXXXXXXX@micromate",
    "XXXXXXXXXXXXXXX@micromate",
    "XXXXXXXXXXXXXXX@micromate",
    "XXXXXXXXXXXXXXX"
  ],
  "exp":<PHONE_NUMBER>,
  "iat":<PHONE_NUMBER>,
  "iss": "XXXXXXXXXXXXXXX",
  "jti": "V2_269943626686082197-at_269943626686147733",
  "nbf":<PHONE_NUMBER>,
  "sub": "119811590336930228",
  "urn:zitadel:iam:org:domain:primary": "micromate.ai",
  "urn:zitadel:iam:org:project:XXXXXXXXXXXXXXXXXXXXX:roles": {
    "LEARNER": {
      "<roleid>": "XXXXXXXXXXXXXXXXXXXX"
    },
    .... <- here are some more roles, I removed them to simplify the example
  },
  "urn:zitadel:iam:user:metadata": {
    "createdOn": "UHJvZHVjdGlvbg",
    "initialized": "dHJ1ZQ"
  }
}

We did not add/remove roles during this time. So I would expect to get the same roles.
I think this is not super urgent, as it works 99.9999% of the time, but maybe as a hint that there may be something somewhere wrong? Let me know if you need any further information.
To reproduce
We cannot reproduce this.
Screenshots
No response
Expected behavior
No response
Operating System
No response
Relevant Configuration
No response
Additional Context
No response

Hey @sschoeb
This might have been an issue with 2.53.0. We noticed something similar and did a fix: https://github.com/zitadel/zitadel/pull/8046
Thanks for reporting. We'll close it since it should be fixed now.


c variant

The new variant now reads the whole file at once, just like the other implementations. It is now pretty similar to the golang variant, as far as it is possible in C.

Thx a lot. Really appreciate all the contribution. :)
BR


Not compatible with latest Python 3.10+

Report
Is it possible to install with version compatible with latest python? Otherwise it's hard to work with updated pacakges like scvi-tools that require python >3.10.
> pip install pertpy
ERROR: Ignored the following versions that require a different python version: 0.1.0 Requires-Python >=3.8.0,<3.10; 0.2.0 Requires-Python >=3.8.0,<3.10; 0.3.0 Requires-Python >=3.8.0,<3.10
ERROR: Could not find a version that satisfies the requirement pertpy (from versions: none)
ERROR: No matching distribution found for pertpy

Version information
No response

We've already addressed this and you will be able to install it with Python 3.10 with the next release! In the meantime you can install pertpy from the development branch.
pip install git+https://github.com/theislab/pertpy.git@development

should do the trick if I recall correctly. Sorry for the inconvenience until then!

Thank you very much!