Why did I not think of this before?!? :-)

Hi @Yomguithereal ,
This is freakin' awesome. We need a "rehydrate" type of method on the tree. Do the following:

Set up a hot loading webpack workflow, f.ex. use my boilerplate:

svn export https://github.com/christianalfoni/webpack-express-boilerplate/trunk ./dir

Install Baobab, react etc.

Create a state.js file:

export default {
 text: 'hey'
};

In your main.js file:

import Baobab from 'baobab';
import state from './state.js';

let tree = new Baobab(state);

if (module.hot) {

  module.hot.accept('./state.js', function () {
    let newState = require('./state.js');

    // This should be easier to do
    Object.keys(newState).forEach(function (key) {
      tree.set(key, newState[key]);
    });
  });

}

Now hook up some Component and start changing the state.js file

Voila! Hot application updates using Baobab. Combining this with react-hot-loader you do not only get hot updates on component changes and their internal state, but you also get it on application state

Think of the development flow. You can put your application in any state using a state.js file for Baobab and you can develop your components using that state, also hot-reloading! This is a game changer I think :-)

Have to do some work on releasing listeners etc., so should end up as a baobab-hot plugin for Webpack, but yeah... you get the feel of it :-)

Okay, I have been researching a bit. How would you feel about me setting up a new repo: baobab-hot-loader? This will allow the hot patching to work "out of the box". A challenge though is that the mixins needs some added behaviour to patch changes to the cursors/facets added to the components. I am a bit unsure of the best strategy for this:

baobab-react detects baobab-hot-loader and extends functionality on the mixins

baobab-hot-loader requires baobab-react and "configures it to do hot loading"

Anyways, it is just a matter of finding the best solution, but it will require the mixins to be able to "reset" themselves by doing a diff on the cursors/facets object attached to the component.
Anyways, this is really awesome stuff! With baobab-hot-loader  and react-hot-loader we can create a completely fluent experience of building applications. No more "click click click" to get to the state you need, just change your state file and you are there!

Okay, I created a video on this to show off the concept, and also general Baobab stuff. I found a bug in react-hot-loader during testing so I hope that gets pulled soon.
Hot loading application state with Baobab and Webpack
I got the normal mixins running with this, so need to expand to the decorators, wrappers etc.
And watch out for a pull request :-)

Hello @christianalfoni, I need some time to check all this out but one thing I notice is this:
// This should be easier to do
Object.keys(newState).forEach(function (key) {
  tree.set(key, newState[key]);
});

What about this:
tree.set(newState);

This actually works.

Okay, I had some time to check this out. Looks very cool indeed! I ought to try webpack hot loading etc. You can of course go ahead and create baobab-hot, I don't see why I should prevent you from doing so :-).
I don't understand the part about mixins reloading very well however. I don't know if this can help you but facets have an undocumented refresh method that can be use to, well... refresh them. I use it in the mixins, for instance, when new props are received. Example.

Hi @Yomguithereal ,
I did some more work on this and created pull request. It works very well now in a "none intrusive" way. So if the mixins get that pull request baobab-hot-loader is free to optimize on its end. Only change to mixins is a componentWillUpdate where it checks if baobab-hot-loader has flagged them as "hot". If so it does a check and updates.
Using webpack I think even the flag check is removed because it will always be false.

Okay, so got repo, https://github.com/christianalfoni/baobab-hot-loader, updated now with some documentation. Also got the DIFF logic in there so that any changes done through running application code will not be overridden when you change the state of the tree from the file :-)


CHANGED: ABS, SIGN, LOG -> IMMUTABLE

The functions were marked as STABLE. However, they can be changed to IMMUTABLE.
REASON:

The functions designated are not conducting a database lookup. Rather, the value passed in as an argument is used by the function to determine the type and value to return.
No mutation occurs in the course of using the functions.
Possible function arguments are taken into consideration during function implementation to be within a certain range. Thus, the return values are to be as expected during usage.

Thank you! But these changes were already merged as a part of a separate PR.


MPI preliminaries for examples

... and various changes to logging
Big diff as based on mpi-next (#629 )

Merged.


podman and macvlan, can't reach pod

Describe the bug
Im trying to setup a router with nixos and want to use podman with macvlan to also host some small services.
The pod gets an IP of the kea server on the same Host.
But it isn't reachable and can't reach the network.
Steps To Reproduce
Steps to reproduce the behavior:

Setup router like here https://francis.begyn.be/blog/nixos-home-router
Setup podman with macvlan dhcp like here https://github.com/NixOS/nixpkgs/issues/250263
Run a pod

Expected behavior
Pod should be able to reach network and network should be able to reach pod.
Maybe there is an issue with nftables. But a computer connected to a physical switch on lan works.
Thanks for help
Additional context
podman config:
  virtualisation = {
    podman = {
      enable = true;
      dockerCompat = true;
      defaultNetwork.settings = {
        driver = "macvlan";
        network_interface = "lan";
        ipv6_enabled = false;
        internal = false;
        dns_enabled = false;
        ipam_options = {
          driver = "dhcp";
        };
      };
    };
  };

  systemd.sockets."netavark-dhcp-proxy" = {
    description = "Netavark DHCP proxy socket";
    socketConfig = {
      ListenStream = "%t/podman/nv-proxy.sock";
      SocketMode = 0660;
    };
    wantedBy = [ "sockets.target" ];
  };

  systemd.services."netavark-dhcp-proxy" = {
    description = "Netavark DHCP proxy service";
    after = [ "netavark-dhcp-proxy.socket" ];
    requires = [ "netavark-dhcp-proxy.socket" ];
    wantedBy = [ "multi-user.target" "netavark-dhcp-proxy.socket" ];
    path = [ pkgs.netavark ];
    startLimitIntervalSec = 0;

    serviceConfig = {
      Type = "exec";
      ExecStart= "${pkgs.netavark}/bin/netavark dhcp-proxy -a 30";
    };
  };

nftable rules
        table inet filter {
          chain output {
            type filter hook output priority 100; policy accept;
          }

          chain input {
            type filter hook input priority filter; policy drop;

            # accept any localhost traffic
            iifname lo accept

            # Allow trusted networks to access the router
            iifname {
              "wan", # disable when final
              "lan"
            } counter accept

            # Allow networks to access the dns and dhcp
            iifname {
              "lan",
              "server",
              "smart",
              "multimedia"
            } udp dport { 53, 67, 68 } counter accept
            iifname {
              "lan",
              "server",
              "smart",
              "multimedia"
            } tcp dport { 80, 443, 853 } counter accept

            iifname "wan" ct state { established, related } accept comment "Allow established traffic"
            iifname "wan" icmp type { echo-request, destination-unreachable, time-exceeded } counter accept comment "Allow select ICMP"
            iifname "wan" counter drop comment "Drop all other unsolicited traffic from wan"
          }

          chain forward {
            type filter hook forward priority filter; policy drop;

            # enable flow offloading for better throughput
            # ip protocol { tcp, udp } flow offload @f

            # multimedia airplay
            iifname "multimedia" oifname { "lan" } counter accept

            # lan and vpn to any
            # TODO: disable wan when finished
            iifname { "wan", "lan" } oifname { "lan", "server", "multimedia", "smart" } counter accept

            # Allow trusted network WAN access
            iifname {
              "lan",
              "server",
              "multimedia",
              "smart"
            } oifname {
              "wan",
            } counter accept comment "Allow trusted LAN to WAN"

            # Allow established WAN to return
            iifname {
              "wan",
            } oifname {
              "lan",
              "server",
              "multimedia",
              "smart"
            } ct state { established, related } counter accept comment "Allow established back to LANs"
          }
        }

        table ip nat {
          chain prerouting {
            type nat hook prerouting priority filter; policy accept;
          }

          # Setup NAT masquerading on the ppp0 interface
          chain postrouting {
            type nat hook postrouting priority filter; policy accept;
            oifname { "wan" } masquerade
          }
        }

After digging around a bit i found why this is happening.
Macvlan doesn't allow to communicate with the host.
For everyone with the same problem:
https://stackoverflow.com/questions/49600665/docker-macvlan-network-inside-container-is-not-reaching-to-its-own-host#answer-64360858


Published build should not include propTypes

Best practice is to exclude propTypes declarations in build versions of components

Fixed via #385.


yarn sets $NODE env variable to the node version from nix which breaks some usages

Describe the bug
nixpkgs.yarn (or nixpkgs.nodePackages.yarn) sets $NODE to a specific node version, which will it error out when used in a project that has strict engine requirements inside package.json
Steps To Reproduce
I created a simple repo to be able to reproduce this issue https://github.com/ahmedelgabri/nix-yarn-issue

make sure to install nixpkgs.yarn & nixpkgs.fnm (or nvm)
Clone the repo
Run fnm use --install-if-missing to install the version from .nvmrc file
Validate that you get the correct version node -v & which node should point to the node coming from fnm
Run yarn start, it shouldn't run & you will get this error

error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version ">= 16". Got "14.18.1"
error Commands cannot run with an incompatible environment.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Run this command

yarn env | grep -E "\"(NODE|npm_node_execpath|npm_config_user_agent)\""

The output should look like this
"NODE": "/nix/store/d37aprv8pxqpslag1yq6n0q2q0fnpqwg-nodejs-14.18.1/bin/node",
"npm_node_execpath": "/nix/store/d37aprv8pxqpslag1yq6n0q2q0fnpqwg-nodejs-14.18.1/bin/node",
"npm_config_user_agent": "yarn/1.22.17 npm/? node/v14.18.1 darwin x64",

The problem is that nix sets the NODE environment variable to the nix node executable, which then yarn picks up and sets npm_node_execpath to the same value.
I tried to search the repo to find where exactly this is happening but I couldn't really find it.
Overriding NODE is not the solution because this doesn't affect npm_config_user_agent & will still error out.
So doing this doesn't work
export NODE=$(which node) yarn start

It will result in the same error here
error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version ">= 16". Got "14.18.1"
error Commands cannot run with an incompatible environment.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

because the output looks like this
"NODE": "/Users/ahmed/.fnm/node-versions/v16.13.0/installation/bin/node",
"npm_node_execpath": "/Users/ahmed/.fnm/node-versions/v16.13.0/installation/bin/node",
"npm_config_user_agent": "yarn/1.22.17 npm/? node/v14.18.1 darwin x64", # this is not correct still

This problem doesn't happen if yarn is installed using homebrew or directly curl -o- -L https://yarnpkg.com/install.sh | bash.
This is the result when using yarn which is installed using homebrew
"NODE": "/Users/ahmed/.fnm/node-versions/v16.13.0/installation/bin/node",
"npm_node_execpath": "/Users/ahmed/.fnm/node-versions/v16.13.0/installation/bin/node",
"npm_config_user_agent": "yarn/1.22.17 npm/? node/v16.13.0 darwin x64",

Expected behavior
That yarn works correctly & switch NODE, npm_node_execpath & npm_config_user_agent when the node version is changed.
Additional context
Add any other context about the problem here.
Notify maintainers
@DamienCassou (sorry if you are not the maintainer but I couldn't mention anyone from the maintainer list)

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-darwin"`
 - host os: `Darwin 21.1.0, macOS 10.16`
 - multi-user?: `no`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.4pre20210326_dd77f71`
 - channels(ahmed): `"darwin, nixpkgs-21.05pre286546.2cca79be09c"`
 - nixpkgs: `/nix/store/vpgzs19895khmlgjryi4y9w7cd2br1m5-source`

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

I have no clue about this issue, I'm sorry.
/cc @offlinehacker @screendriver

nix why-depends ".#yarn" ".#nodejs" --all
/nix/store/yg5c88hv8p37rd1nm2s7ly6hp8jq9byh-yarn-1.22.17
└───libexec/yarn/bin/yarn.js: …#!/nix/store/rdagrwgmq8n9jcs5iq5xpcxcxnh0lcc7-nodejs-14.18.1/bin/node../* esl…
    libexec/yarn/bin/yarnpkg: …#!/nix/store/rdagrwgmq8n9jcs5iq5xpcxcxnh0lcc7-nodejs-14.18.1/bin/node.require…
    libexec/yarn/lib/cli.js: …#!/nix/store/rdagrwgmq8n9jcs5iq5xpcxcxnh0lcc7-nodejs-14.18.1/bin/node.module.…
    → /nix/store/rdagrwgmq8n9jcs5iq5xpcxcxnh0lcc7-nodejs-14.18.1

there's a nodejs14 shebang in those
#!/nix/store/rdagrwgmq8n9jcs5iq5xpcxcxnh0lcc7-nodejs-14.18.1/bin/node

@Artturin any clue how can this be changed? looking at the derivation it seems like something happens at the build phase because the install phase is a simple symlinking https://github.com/NixOS/nixpkgs/blob/5715d5b507362b1d9c87317d874e47e33b0eabd6/pkgs/development/tools/yarn/default.nix

I'm seeing the exact same issue using the nodejs-16_x and yarn packages as of c11d08f02390aab49e7c22e6d0ea9b176394d961. I have the following in my package.json:
  "engines": {
    "node": ">=16"
  },

But I'm seeing the following when trying to run yarn:
[nix-shell:~/dev/cuddlefish/next]$ node --version
v16.13.0

[nix-shell:~/dev/cuddlefish/next]$ yarn run dev
yarn run v1.22.17
error next@: The engine "node" is incompatible with this module. Expected version ">=16". Got "14.18.1"
error Commands cannot run with an incompatible environment.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

which is obviously a contradiction. I have no idea where 14.18.1 is coming from besides the fact that it is the current nodejs version for the nixpkgs commit I'm on.

Any known workaround for this?

@samuela override doesn't solve the problem if you work with different projects & everyone requires a different node version this will still break.

Totally, it's just a hack for the time being. I'd still like to see this resolved properly as well!

With overlay:
nixpkgs.overlays = [(
  self: super: {
    yarn = super.yarn.override {
      nodejs = pkgs.nodejs-16_x;
    };
  }
)];

@thall This doesn't solve the problem. Because now yarn will not work with any project that's using an older version
https://github.com/NixOS/nixpkgs/issues/145634#issuecomment-973978780
The reason why the shebang should stay the same is this, yarn will work as expected in any project & picking up the project version correctly.

The override works for pkgs.yarn but not pkgs.nodePackages.yarn.

@thall This doesn't solve the problem. Because now yarn will not work with any project that's using an older version
#145634 (comment)

@ahmedelgabri  Yes, I know that, its not a solution, just a workaround that I wanted to share.

I've also this problem, @ahmedelgabri, and I've fixed it in a shell.nix to have a reproducible local environment for each project:
New project:
{ pkgs ? import <nixpkgs> {
  overlays = [(
    self: super: {
	  yarn = super.yarn.override {
	    nodejs = pkgs.nodejs-18_x;
	  };
    }
  )];
} }:
  pkgs.mkShell {
    nativeBuildInputs = with pkgs; [
      nodejs-18_x
      yarn
    ];
    buildInputs = [ ];
}

Other, older, project, does not need the overlay:
{ pkgs ? import <nixpkgs> { } }:
  pkgs.mkShell {
    nativeBuildInputs = with pkgs; [
      nodejs-16_x
      yarn
    ];
    buildInputs = [ ];
}

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/how-to-use-pnpm-with-recent-nodejs/21867/1

The override works for pkgs.yarn but not pkgs.nodePackages.yarn.

To resolve this (also useful for e.g. nodePackages.pnpm) it can be achieved by overlaying the default nodejs package:
overlays = [ (self: super: {
    nodejs = pkgs.nodejs-16_x;
}) ]

which is then used to build nodePackages, so nixpkgs.nodePackages.pnpm will be using that version of nodejs:
$ pnpm node --version
v16.17.1

seems to be using the wrong version
$ yarn node -v
yarn node v1.22.18
v14.20.1
...

workaround
$ node `which yarn` node -v
yarn node v1.22.18
v18.9.1

I was in the process of creating a new issue but luckily discovered this so I'll share my thoughts/findings here:

The decision to symlink yarn to bin/yarn.js instead of bin/yarn makes it impossible invoke yarn directly using a custom node version.
The official yarn package has yarn as a shell script and yarn.js as a node script
bin/yarn
#!/bin/sh

bin/yarn.js
#!/usr/bin/env node

Additionally, yarn.js will use whichever node version is first on the path.
HOWEVER, after being nixified, the #! expressions become hard-coded and we lose the dynamic nature of the original:
fresh install of yarn
$ nix-shell -p yarn

$ which yarn
/nix/store/xblz3z89rsnfmmj1zyji3n3v2rvrp2m4-yarn-1.22.19/bin/yarn

check path-installed commands
$ ls -l `dirname \`which yarn\``

total 0
lrwxr-xr-x 1 root nixbld 27 Dec 31  1969 yarn -> ../libexec/yarn/bin/yarn.js
lrwxr-xr-x 1 root nixbld 27 Dec 31  1969 yarnpkg -> ../libexec/yarn/bin/yarn.js

check #! settings of installed commands
$ head -1 `dirname \`realpath \\\`which yarn\\\`\``/yarn{,.js}

==> /nix/store/xblz3z89rsnfmmj1zyji3n3v2rvrp2m4-yarn-1.22.19/libexec/yarn/bin/yarn <==
#!/nix/store/ka6rabx4lz7m3habrjhh8hvbgxbz8r98-bash-5.2-p15/bin/sh

==> /nix/store/xblz3z89rsnfmmj1zyji3n3v2rvrp2m4-yarn-1.22.19/libexec/yarn/bin/yarn.js <==
#!/nix/store/kvlngvm6agicknyj02m93zbql3g39kw2-nodejs-18.15.0/bin/node

So when yarn.js is invoked directly, it will ALWAYS use whichever version of node is hard-coded in the #!.
However, if we could invoke the yarn shell script, it will check the path for which node version to use.
My recommended fix:
Modify the nix pkg installation steps to symlink yarn to the yarn shell script and not the yarn.js node script.
Additionally, I think hard-coding the #! in the yarn.js script is a bit of a bug, but not sure if there's a configuration option in the nixpkg to skip the fixup for that script?

Adding that the bug is still affecting things in NixOS 24.05 sadly

I think I will close the issue because, at the time I opened this, I was new to Nix and was a bit more used to things installed globally with Homebrew and stuff…
3 years later I don't think this is a bug, because things like nix shell or flakes devShells are better to manage project dependencies locally and not in a global way. and this is how I work now, I don't install anything globally.
Any project I'm working on either has shell.nix or flake.nix which is automatically loaded with direnv and will use yarn with the same node version I use with nix like what @j-a-m-l or @thall suggested above.


Increase maxWaitForLoad timeout to 5 seconds

Lighthouse reports have been failing with a timeout error (see thread). This PR attempts to get around this error by allowing up to 5 seconds wait time for testing the pages loaded.
Changes

Increase maxWaitForLoad timeout to 5 seconds.

Testing

yarn lighthouse should pass… or we can merge and see how it goes on GitHub actions and revert if necessary.

This started failing again last night, running against this page on mobile:
Fri, 23 Apr 2021 00:43:35 GMT status Loading page & waiting for onload
Fri, 23 Apr 2021 00:43:40 GMT waitFor:warn Timed out waiting for page load. Checking if page is hung...
Fri, 23 Apr 2021 00:43:41 GMT waitFor:warn Page appears to be hung, killing JavaScript...
Fri, 23 Apr 2021 00:44:11 GMT status Disconnecting from browser...
Fri, 23 Apr 2021 00:44:11 GMT ChromeLauncher Killing Chrome instance 17694
Runtime error encountered: Waiting for DevTools protocol response has exceeded the allotted time. (Method: Emulation.setScriptExecutionDisabled)
LHError: PROTOCOL_TIMEOUT
    at Timeout._onTimeout (/home/runner/work/cfgov-lighthouse/cfgov-lighthouse/node_modules/lighthouse/lighthouse-core/gather/driver.js:399:21)
    at listOnTimeout (internal/timers.js:554:17)
    at processTimers (internal/timers.js:497:7)
error Command failed with exit code 1.


SuperCollider notes

This thread will deal with ideas and tips for working with Animatron from SC.

I added a setup.scd file in the repo (1993ad5) that can be loaded by SC scripts to set things up for Animatron. It defines the required OSCdefs, the n variable (our usual NetAddr for n.sendMsg()) and a new x function, which will eXecute a space-separated OSC command string, for (IMHO) a nicer workflow.
x.("/load cube")
x.("/create c1 cube")
x.('/say c1 "Hello there!"') // can send also it a 'symbol', which means you
                             // don't have to escape the quotation marks...
x.("/say c1 \"Hello there!\"") // ...otherwise do this

The above would be the same as this "old way," but requiring fewer commas and quotes:
n.sendMsg("/load", "cube")
n.sendMsg("/create", "c1", "cube")
n.sendMsg("/say", "c1", "Hello there!")


DB Startup Config File - values not utilized

Hi,
I am trying to override the default values when starting the mysql server using the --config parameter and yaml config definition as described in
the docs. (Example below)  The file is apparently loaded (I performed a test using a non-existent file name which did generate a file not found error), yet all of the default values are still being utilized.  I changed the user name, timeouts, etc., yet the original defaults are still be used on startup.  What am I missing here?
behavior:
read_only: false
autocommit: true

user:
name: root
password: ""

listener:
host: localhost
port: 3306
max_connections: 1
read_timeout_millis: 30000
write_timeout_millis: 30000

databases: []

Chris,
This is when running dolt sql-server, correct?
Can you paste the exact command you're running and any output?

Here is the info Zach with the command at the end after illustrating file contents.
Thanks,
Chris
5ss2rn2:ip-to-country cwhelan$ ls -l
total 8
-rw-r--r--  1 cwhelan  staff  204 Nov 13 07:44 mysql.conf
5ss2rn2:ip-to-country cwhelan$ cat mysql.conf
log_level: info
behavior:
read_only: false
autocommit: true

-user:
name: toot
password: ""

listener:
host: localhost
port: 3306
max_connections: 1
read_timeout_millis: 40000
write_timeout_millis: 40000
5ss2rn2:ip-to-country cwhelan$ dolt sql-server --config mysql.conf
Starting server with Config HP="localhost:3306"|U="root"|P=""|T="30000"|R="false"|L="info"

Hi Zach,
Just wondering when you may have an opportunity to look into this issue?
Regards,
Chris

Hi Chris,
I think what's happening is that you don't have correct indentation correct in your YAML file. The lines after behavior:, user: and listener: need to be indented, or else they aren't consider part of those config blocks, which they need to be for them to be properly evaluated. I get the same behavior when I use your yaml as above, with no indentation on any line.
Try with this file (preserve indentation):
log_level: info

behavior:
  read_only: false
  autocommit: true

user:
  name: toot
  password: ""

listener:
  host: localhost
  port: 3306
  max_connections: 1
  read_timeout_millis: 40000
  write_timeout_millis: 40000

Thanks Zach, that was it!  Sometimes I really despise YAML!


Is there a Discord for useDapp? Would help immensely

Hi guys,
I find myself having a bunch of questions about useDapp. Not all questions are appropriate for Github issues.
Is there a Discord where we can ask questions? It would be a great way to receive support from useDapp developers, the community, but also a way to contribute support.
If there is no Discord, can one be created?
Thank you for considering this request.

Try https://discord.gg/ppFxC3E44X and #usedapp-support

@marekkirejczyk how about opening the discussion section in github (and disable the wiki)?

I think about creating a slack channel. The reason is that our company is using slack and it would provide  the biggest chance od someone responding.

Is https://discord.gg/ppFxC3E44X  the official useDapp discord?
If not, please consider creating a useDapp Discord. Most the GH issues here could be resolved on Discord.

please create an official discord. People using useDapp could interact with each other

The official useDApp discord is https://discord.gg/ppFxC3E44X


sapling? update

do these functions exist for groth16
using your latest downlod.
zen-cli z_getnewaddress sapling
error code: -1
error message:
z_getnewaddress
Returns a new zaddr for receiving payments.
Arguments:
Result:
"horizenaddress"    (string) The new zaddr
Examples:

zen-cli z_getnewaddress
curl --user myusername --data-binary '{"jsonrpc": "1.0", "id":"curltest", "method": "z_getnewaddress", "params": [] }' -H 'content-type: text/plain;' http://<IP_ADDRESS>:8232/

Sapling addresses are not enabled yet. Should be enabled in next upgrade cycle.

Pending Sapling implementation on main chain.


fix(contact-info): use item layout instead of list item

fix(contact-info): use item layout instead of list item

Obligatory GIF (super important!)

:hammer_and_wrench: Type Of Change

These types will increment the version number on release:

[x] Fix
[ ] Feature
[ ] Performance Improvement
[ ] Refactor

These types will not increment the version number, but will still deploy to documentation site on release:

[ ] Documentation
[ ] Build system
[ ] CI
[ ] Style (code style changes, not css changes)
[ ] Test
[ ] Other (chore)

:book: Jira Ticket
https://dialpad.atlassian.net/browse/DLT-1563

:book: Description
Updates the recipe Contact Info to use directly DtItemLayout, without going through DtListItem.

:bulb: Context
This component was based on List Item before we had Item Layout. Makes more sense this way (we just want the layout).
Nothing changes visually, and all the properties that were there are still there except the id, which is not needed if it's not part of a list.
You see there's a new Percy screenshot but that is only because the route changed, but I ran the visual tests before changing the route and it passed.
I also tested some examples in the product with npm link. Could not test them all, but no differences are expected.

:pencil: Checklist

For all PRs:

[x] I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
[x] I have reviewed my changes.
[ ] I have added all relevant documentation.
[x] I have considered the performance impact of my change.

For all Vue changes:

[ ] I have added / updated unit tests.
[x] I have made my changes in Vue 2 and Vue 3. Note: you may sync your changes from Vue 2 to Vue 3 (or vice versa) using the ./scripts/dialtone-vue-sync.sh script.
[ ] I have validated components with a screen reader.
[x] I have validated components keyboard navigation.

For all CSS changes:

[ ] I have used design tokens whenever possible.
[ ] I have considered how this change will behave on different screen sizes.
[ ] I have visually validated my change in light and dark mode.
[ ] I have used gap or flexbox properties for layout instead of margin whenever possible.

If new component:

I am exporting any new components or constants:

[ ] from the index.js in the component directory.
[ ] from the index.js in the root (either packages/dialtone-vue2 or packages/dialtone-vue3).

[ ] I have added the styles for the new component to the packages/dialtone-css package.
[ ] I have created a page for the new component on the documentation site in apps/dialtone-documentation.
[ ] I have added the new component to common/components_list.cjs in packages/dialtone-vue2 and packages/dialtone-vue3
[ ] I have created a component story in storybook
[ ] I have created story / stories for any relevant component variants in storybook
[ ] I have created a docs page for the component in storybook.
[ ] I have checked that changing all props/slots via the UI in storybook works as expected.

:crystal_ball: Next Steps
More improvements can be done to Contact Info to make it more flexible. New ticket for that coming soon.

Can you validate this right slot content and remove it if empty please? I've seen it has always been there with no content


Add notes to plantings in backend.

Basics

[ ] I added a line to changelog.md
[x] The PR is rebased with current master.
[ ] Details of what you changed are in commit messages.
[ ] References to issues, e.g. close #X, are in the commit messages and changelog.
[ ] The buildserver is happy.

Checklist

[ ] I have installed and I am using pre-commit hooks
[ ] I fully described what my PR does in the documentation
[ ] I fixed all affected documentation
[ ] I fixed the introduction tour
[ ] I wrote migrations in a way that they are compatible with already present data
[ ] I fixed all affected decisions
[ ] I added automated tests or a manual test protocol
[ ] I added code comments, logging, and assertions as appropriate
[ ] I translated all strings visible to the user
[ ] I mentioned every code or binary not directly written or done by me in reuse syntax
[ ] I created left-over issues for things that are still to be done
[ ] Code is conforming to our Architecture
[ ] Code is conforming to our Guidelines
[ ] Code is consistent to our Design Decisions
[ ] Exceptions to any guidelines are documented

Review

[ ] I've tested the code
[ ] I've read through the whole code
[ ] I've read through the whole documentation
[ ] I've checked conformity to guidelines

About the names quicky before we finish this:
Seeds already has the field notes, that's why I also called it notes for plants everywhere. I suggest calling it planting_notes (plural)  in PlantingDto.

Alright I think this is ready to merge @markus2330

@horenso thx! Simply set the label "please merge"  once you think everything is ready. In this case I think, however, that the approval of @danielsteinkogler is pending and the build server has not completed yet.
@danielsteinkogler please approve


AVRO-3693: Include structName in invalid union type exception text

AVRO-3693 This is a small enhancement request for the avrogencpp code generator, to help identify a deserialisation issue better. When a structure sent by avro contains unions and a union part of a message is de-serialized without checking first that it is present, invalid type for union is thrown. However it does not identify which union. It could include the structName in the exception, then it would be possible to tie down the exception to the precise union that got the error.
While making this change I took the opportunity for a couple of other minor changes:
Below the copyright notice there is now a notice that this code has been produced by the avrogencpp code generator.
The include guard avoids double underscore followed by uppercase letter since that is reserved for use by compiler implementors and clang-tidy complains about it.

What is the purpose of the change
(For example: This pull request improves file read performance by buffering data, fixing AVRO-XXXX.)
Verifying this change
(Please pick one of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Extended interop tests to verify consistent valid schema names between SDKs
Added test that validates that Java throws an AvroRuntimeException on invalid binary data
Manually verified the change by building the website and checking the new redirect

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Thank you for the contribution, @marlowa !


Add full stop to 'addFirstPaymentMethod' copy

Details
Copy change that adds a full stop to the end of the copy for adding a payment method, both in English and Spanish.
Fixed Issues

$ https://github.com/Expensify/App/issues/5817/
Tests
Log in to app on a new account (or with an account that doesn't have a payment method set up)
Navigate to payments.
Confirm the copy for adding a new payment method has a full stop at the end in both English and Spanish
QA Steps
Log in to app on a new account (or with an account that doesn't have a payment method set up)
Navigate to payments.
Confirm the copy for adding a new payment method has a full stop at the end in both English and Spanish
Tested On

[x] Web
[ ] Mobile Web
[ ] Desktop
[ ] iOS
[ ] Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

🚀 Deployed to staging by @Gonals in version: 1.1.7-26 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


video call to hammer out some things?

Would folks be interested in having a video call sometime to discuss:

moving the demo code to its own repo #338
Separation of driver interface from high level library #348
branch naming #339
equivalent APIs for EV3-G motor and sensor blocks
micropython vs. cpython...how exactly do we want to handle supporting both

It feels like there is enough to discuss that it would be far faster to do a call than it would to hash everything out via comments on issues/PRs.
What timezone is everyone in?  I am on the US east coast.

Why not, it sounds fun. I am on Europe/Moscow time (UTC+3).

Yeah, I'm up for it. I can't say I have a particularly good track record with these things (slept through the last one :laughing:) but I think it's a good idea. I'm in PST (UTC-7 or -8, depending on DST). The 11-hour offset makes things interesting!

I could do tomorrow (sat sept 9th) at 4:00pm UTC? If not maybe we aim for a weekday next week.

That'll be a bit tight for me... can we shoot for sometime next week, excluding Monday? 9:00 is fine though.

Yep I can do Tues, Wed or Thursday at that time.

4pm UTC works for me on any week day.

I am unable to join - but support all of the work you are doing together to make this happen. Please make sure you properly credit yourselves with this work - just because the repo is on my GitHub area and I'm not actively contributing😏

I'd join too (CEST here). 4:00PM UTC would be okay.

Cool...if you guys/gals can send me your email addresses I'll setup a call for Tuesday at 4pm UTC

<EMAIL_ADDRESS>

kaelin_laundry at hotmail.com

<EMAIL_ADDRESS>

david at lechnology dot com, or if you are doing a google hangout extraspecialdave at gmail dot com

Here are the notes from the meeting:

Branch naming

Banch off current master for ev3dev-jessie
Continue on master + develop for Stretch
Versioning: jessie releases after moving onto stretch will require suffix

Autogen

Could remove autogen only on Jessie and maintain manually
Stretch would become primary supported platform for autogen spec

Performance: sysfs vs. character device (external)
Separating demos into individual repo

Would enable downloading all demos as ZIPball
Ship demos as Debian package

Preinstall
Installs demos to /home/robot/demo?

High-level API

Each block in EV3-G would have an equivalent class in Python (e.g., motor block -> motor object)
Keep existing internal API available, but document friendly methods primarily
Further investigation:

Build wiki page with mapping of current API to EV3-G blocks
Build friendly functions so that their argument names aren't dependent on internal sysfs names

Micropython vs cpython

Micropython-first, but we support cpython
Further investigation:

Replacement for display and sound APIs

Pre-compile module?
Future video calls?

I'm going to go ahead and update various issues that we discussed as well as open new ones for a few of the above points.


Fi 948 migrate profile validation from program

This PR moves the profile validation tests along with the terminology changes from program to community. I pretty much just copied over the files and whatever other code was needed to make everything run and to pass all the tests. I think special attention needs to be payed to the hl7_validator.rb, terminology.rb, and tasks.rake changes as I'm not really sure if all those changes are necessary/correct.
Before you start testing, make sure you have the newest version of the bloom filters under resources/terminology/validators/bloom.

I get this error in all of the profile validation tests:

Fatal Error: undefined method `any?' for nil:NilClass
NoMethodError
lib/app/utils/terminology.rb:250:in `validate_code',
lib/app/sequence_base.rb:965:in `block (2 levels) in resources_with_invalid_binding',
lib/app/sequence_base.rb:795:in `block (2 levels) in resolve_element_from_path',
lib/app/sequence_base.rb:784:in `block in resolve_element_from_path',
lib/app/sequence_base.rb:784:in `each',
lib/app/sequence_base.rb:784:in `find',
lib/app/sequence_base.rb:784:in `resolve_element_from_path',
lib/app/sequence_base.rb:795:in `block in resolve_element_from_path',
lib/app/sequence_base.rb:793:in `each',
lib/app/sequence_base.rb:793:in `resolve_element_from_path',
lib/app/sequence_base.rb:936:in `block in resources_with_invalid_binding',
lib/app/sequence_base.rb:932:in `map',
lib/app/sequence_base.rb:932:in `resources_with_invalid_binding',
lib/modules/uscore_v3.1.0/us_core_practitioner_sequence.rb:137:in `block (2 levels) in <class:USCore310PractitionerSequence>'

We may want to make a ticket to look at the performance of this code once it's merged. These changes make the US Core tests take 50% longer for me.

I get this error in all of the profile validation tests:

Fatal Error: undefined method `any?' for nil:NilClass
NoMethodError
lib/app/utils/terminology.rb:250:in `validate_code',
lib/app/sequence_base.rb:965:in `block (2 levels) in resources_with_invalid_binding',
lib/app/sequence_base.rb:795:in `block (2 levels) in resolve_element_from_path',
lib/app/sequence_base.rb:784:in `block in resolve_element_from_path',
lib/app/sequence_base.rb:784:in `each',
lib/app/sequence_base.rb:784:in `find',
lib/app/sequence_base.rb:784:in `resolve_element_from_path',
lib/app/sequence_base.rb:795:in `block in resolve_element_from_path',
lib/app/sequence_base.rb:793:in `each',
lib/app/sequence_base.rb:793:in `resolve_element_from_path',
lib/app/sequence_base.rb:936:in `block in resources_with_invalid_binding',
lib/app/sequence_base.rb:932:in `map',
lib/app/sequence_base.rb:932:in `resources_with_invalid_binding',
lib/modules/uscore_v3.1.0/us_core_practitioner_sequence.rb:137:in `block (2 levels) in <class:USCore310PractitionerSequence>'

I didn't run into this issue. You may need to update your bloom filters in the resources/terminology folder.


update mir-algorithm version

Note that's probably better to add a new version and not remove the old one. We work on the premise that every link should be reproducible, and that would not be treu for urls created with the old version that expect that version and not the new one. Would great if you put the old one back :)

Like @RabsRincon we'd like existing URLs to always work, so leaving the old version is required. If you change the PR to be an add of the new version instead we can merge this in.

Hm.. So then we may want to be more selective about which versions are added. (perhaps not add every new minor version update)

Right: it's a trade off and tricky to get right. URLs are forver...it's
been a bane of my life so far in CE!
On Wed, Oct 11, 2017 at 5:39 PM Johan Engelen<EMAIL_ADDRESS>wrote:

Hm.. So then we may want to be more selective about which versions are
added. (perhaps not add every new minor version update)
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/mattgodbolt/compiler-explorer/pull/579#issuecomment-335969254,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAmsdcoEMQZe9g8VBY9xGeT1F_vxRXKcks5srUO1gaJpZM4P18a-
.

What I'm thinking is that this is just an UI problem.
If I can come up with an idea to "bundle" libs on their own sub-dropdown maybe, then we can add as many versions as we want, because the only visible one would just be the name, and only after you click in the one you're interested you'd get to choose a version

Looking good, thanks!
Hopefulty I can get the improvished dropdown sooner than later! 👍


Add support for scoped modules

@TabDigital/ping-api
Didn't support scoped modules, because it thought the module name for @foo/bar was @foo.

nice one :+1:


Feature request: mapping for get only lists

Could we add a mapping option for get only lists?
It is useful for when an object is doing the list initialization themself and only exposing a getter for the list.
In my case, I am using protobuf/grpc which generates types with only a getter for the list. And filling the list should be done with Add/Addrange, it would be nice if the mapping for this can be generated.
e.g. the following objects
    public class Hello
    {
        public string Message { get; set; }
        public List<string> Names { get; set; }
    }
    public class Hello3
    {
        public string Message { get; set; }
        public List<string> Names { get; } = new List<string>();
    }

   [MappingInterface]
    public interface IGreeterServiceMapper
    {
        Hello3 MapHello3(Hello hello);
    }

current generated result
        public virtual Hello3 MapHello3(Hello hello)
        {
            return new GrpcService1.Hello3()
            {
                Message = hello.Message
            };
        }

would like to have the following code generated
        public virtual Hello3 MapHello3(Hello hello)
        {
            var hello3 = new GrpcService1.Hello3()
            {
                Message = hello.Message
            };
            hello3.Names.AddRange(hello.Names);
            return hello3;
        }

Right now it's impossible without huge redesign. Mappings for methods with signature Hello3 MapHello3(Hello hello) are generated as a single expression. To achieve the same result as you propose a multi-statement output is required. This is on my TODO list but I can't promise if or when this will be implemented.

@cezarypiatek I can make a pull request of my code (wip), this already generates the above code without breaking any other tests.

cool, please do that, I will take a look at that

@cezarypiatek can you check if the following syntax works correctly? At least it doesn't give me any syntax errors:
public virtual Hello3 MapHello3(Hello hello)
        {
            return new GrpcService1.Hello3()
            {
                Message = hello.Message,
                Names = {
                    hello.Names
               }
            };
        }


Syncing files failed on Apple M1

What happened?
Let the error messages go first:
E0710 01:51:02.257212   41773 v2.go:151] io: read/write on closed pipe
Sync Error on /home/wxw/docker/devspace-quickstart-nodejs: Sync - connection lost to pod my-namespace/devspace-quickstart-nodejs-8589bb75b8-njmnh-devspace:  command terminated with exit code 126

I followed the official tutorial to set up Devspace.
Everything worked well but this command: devspace dev, which reported the errors I posted.
What did you expect to happen instead?
It should sync the files between the container (pods) and local path.
How can we reproduce the bug? (as minimally and precisely as possible)
Just run devspace dev
Local Environment:

DevSpace Version: devspace version 5.14.3
Operating System: macOS (Apple M1)
Deployment method: helm

Kubernetes Cluster:

Cloud Provider: minikube
Kubernetes Version: GitVersion:"v1.20.7"

Anything else we need to know?
Output from kubectl get pods
NAME                                                   READY   STATUS    RESTARTS   AGE
devspace-quickstart-nodejs-8589bb75b8-njmnh-devspace   1/1     Running   0          20m

Output from kubectl get services
NAME                         TYPE        CLUSTER-IP      EXTERNAL-IP   PORT(S)    AGE
devspace-quickstart-nodejs   ClusterIP   <IP_ADDRESS>   <none>        3000/TCP   22m

Complete logs
[info]   Using namespace 'my-namespace'
[info]   Using kube context 'minikube'
[info]   Waiting for pods...
[info]   Starting sync...
[info]   Inject devspacehelper into pod my-namespace/devspace-quickstart-nodejs-8589bb75b8-njmnh-devspace
[info]   Start syncing
[done] √ Sync started on /home/wxw/docker/devspace-quickstart-nodejs <-> . (Pod: my-namespace/devspace-quickstart-nodejs-8589bb75b8-njmnh-devspace)
[error]  Sync Error on /home/wxw/docker/devspace-quickstart-nodejs: Sync - connection lost to pod my-namespace/devspace-quickstart-nodejs-8589bb75b8-njmnh-devspace:  command terminated with exit code 126
[info]   Sync stopped
[info]   Restarting sync...
[info]   Waiting for pods...
[info]   Starting sync...
E0710 02:10:10.146895   47118 v2.go:151] io: read/write on closed pipe
[info]   Inject devspacehelper into pod my-namespace/devspace-quickstart-nodejs-8589bb75b8-njmnh-devspace
[info]   Start syncing
[done] √ Sync started on /home/wxw/docker/devspace-quickstart-nodejs <-> . (Pod: my-namespace/devspace-quickstart-nodejs-8589bb75b8-njmnh-devspace)
[error]  Sync Error on /home/wxw/docker/devspace-quickstart-nodejs: Sync - connection lost to pod my-namespace/devspace-quickstart-nodejs-8589bb75b8-njmnh-devspace:  command terminated with exit code 126
[info]   Sync stopped

/kind bug

@wxw-matt thanks for creating this issue! Is this closed through #1495 ?

@wxw-matt thanks for creating this issue! Is this closed through #1495 ?

Yup, this issue has been fixed as well


how to set id field with primary_key but without autoincrement ?

how to set id field with primary_key but without autoincrement ?
type Model struct {     ID         int64gorm:"AUTO_INCREMENT:no;" sql:"bigint;NOT NULL;primary_key;"    CreateTime time.Time     UpdateTime time.Time }
it will code:
CREATE TABLE "users" ("id" integer primary key autoincrement NOT NULL)
i will the code is:
CREATE TABLE "users" ("id" bigint primary key NOT NULL)

+1

Has the same issue
Migrate with primary column with int type will create table has auto increment
type Realtime struct {
	DeviceID uint16 `gorm:"primary_key:yes;column:deviceID"`
	Data     string `gorm:"type:text;not null"`
}

func (r *Realtime) TableName() string {
	return "Realtimes"
}

+1

Refer PR #1643


version 6.5.2 works,but version 9.2.4 crash with  uncaught exception 'NSUnknownKeyException', reason: '[<RCTView 0x7fbd7aecf380> valueForUndefinedKey:]: this class is not key value coding-compliant for the key active.'

2019-03-02 09:49:39.764385+0800 MoonFM[37390:6532468] *** Terminating app due to uncaught exception 'NSUnknownKeyException', reason: '[<RCTView 0x7fbd7aecf380> valueForUndefinedKey:]: this class is not key value coding-compliant for the key active.'
*** First throw call stack:
(
	0   CoreFoundation                      0x000000010af0e1bb __exceptionPreprocess + 331
	1   libobjc.A.dylib                     0x000000010dc0b735 objc_exception_throw + 48
	2   CoreFoundation                      0x000000010af0dd29 -[NSException raise] + 9
	3   Foundation                          0x000000010b3a7cd9 -[NSObject(NSKeyValueCoding) valueForUndefinedKey:] + 226
	4   Foundation                          0x000000010b3a6b21 -[NSObject(NSKeyValueCoding) valueForKey:] + 284
	5   Foundation                          0x000000010b496f63 -[NSFunctionExpression expressionValueWithObject:context:] + 807
	6   Foundation                          0x000000010b48defe -[NSComparisonPredicate evaluateWithObject:substitutionVariables:] + 239
	7   Foundation                          0x000000010b49012c _filterObjectsUsingPredicate + 380
	8   Foundation                          0x000000010b48ff26 -[NSArray(NSPredicateSupport) filteredArrayUsingPredicate:] + 278
	9   MoonFM                              0x0000000107f1ac37 -[RNSVGGroup hitTest:withEvent:] + 1367
	10  MoonFM                              0x0000000107f3f41d -[RNSVGSvgView hitTest:withEvent:] + 797
	11  MoonFM                              0x0000000107bf79d4 -[UIView(React) reactTagAtPoint:] + 68
	12  MoonFM                              0x0000000107c05237 -[RCTTouchHandler _recordNewTouches:] + 1031
	13  MoonFM                              0x0000000107c06c7d -[RCTTouchHandler touchesBegan:withEvent:] + 157
	14  UIKitCore                           0x000000011974c5d5 -[UIGestureRecognizer _touchesBegan:withEvent:] + 240
	15  UIKitCore                           0x0000000119c4cd0c -[UITouchesEvent _sendEventToGestureRecognizer:] + 287
	16  UIKitCore                           0x0000000119740798 __47-[UIGestureEnvironment _updateForEvent:window:]_block_invoke + 64
	17  UIKitCore                           0x00000001197408e3 -[UIGestureEnvironment _deliverEvent:toGestureRecognizers:usingBlock:] + 276
	18  UIKitCore                           0x000000011974071d -[UIGestureEnvironment _updateForEvent:window:] + 200
	19  UIKitCore                           0x0000000119bb078a -[UIWindow sendEvent:] + 4058
	20  UIKitCore                           0x0000000119b8e394 -[UIApplication sendEvent:] + 352
	21  UIKitCore                           0x0000000119c635a9 __dispatchPreprocessedEventFromEventQueue + 3054
	22  UIKitCore                           0x0000000119c661cb __handleEventQueueInternal + 5948
	23  CoreFoundation                      0x000000010ae73721 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
	24  CoreFoundation                      0x000000010ae72f93 __CFRunLoopDoSources0 + 243
	25  CoreFoundation                      0x000000010ae6d63f __CFRunLoopRun + 1263
	26  CoreFoundation                      0x000000010ae6ce11 CFRunLoopRunSpecific + 625
	27  GraphicsServices                    0x00000001140be1dd GSEventRunModal + 62
	28  UIKitCore                           0x0000000119b7281d UIApplicationMain + 140
	29  MoonFM                              0x000000010597e1e4 main + 132
	30  libdyld.dylib                       0x00000001121d8575 start + 1
)
libc++abi.dylib: terminating with uncaught exception of type NSException

I run into the same issue when having react native animation in svg. The app crashed with same error after I clicked the svg chart
"react": "16.6.1",
"react-native": "0.57.5",
"react-native-svg": "^9.2.4"

Can you make a reproduction?

I'm getting the same with:
"react": "16.8.3",
"react-native": "0.59.1"
"react-native-svg": "9.3.3"
Totally recognize this is less useful than putting together a minimal reproduction (which I'll try to do a bit later after getting this release out...). The issue I'm seeing is actually on touching any SVG whose touch events aren't being grabbed by something else already. Trying to get the production app out, so my temporary, ugly hack is surrounding SVG in a View with pointerEvents="none".
Drop in replacement for most files that stops the crashes from happening:
import RNSvg from 'react-native-svg';

const Svg = ({ props }) => (
  <View pointerEvents="none">
    <RNSvg {...props} />
  </View>
);

@j-wang Interesting. Could you possibly have non svg elements inside the svg element?

Hmm... I have non-SVG elements alongside or above, but not within. I have some fairly minimal components where all I had in them were SVGs, Gs, and a Path.
I originally thought it was an issue with Animated or TouchableOpacity, but removing them didn't do anything to prevent the crashing from happening, and hitting a straight up curvy line still crashed the app. This is only on iOS, btw. Android was working fine without any changes.

@j-wang Can you try the fix from here: https://github.com/react-native-community/react-native-svg/commit/ec9637bcc5b43633eaa3413c99001ac4da946104
--- ios/Elements/RNSVGGroup.m	(revision cdf862ba73b0e17e574bfc25970f6363915128d2)
+++ ios/Elements/RNSVGGroup.m	(revision ec9637bcc5b43633eaa3413c99001ac4da946104)
@@ -174,7 +174,7 @@
     }

     if (!event) {
-        NSPredicate *const anyActive = [NSPredicate predicateWithFormat:@"active == TRUE"];
+        NSPredicate *const anyActive = [NSPredicate predicateWithFormat:@"self isKindOfClass: %@ AND active == TRUE", [RNSVGNode class]];
         NSArray *const filtered = [self.subviews filteredArrayUsingPredicate:anyActive];
         if ([filtered count] != 0) {
             return [filtered.lastObject hitTest:transformed withEvent:event];

Yes, fixed! Let me try a few more of them, but the "unit test" I had before is now no longer crashing.

Great! Well, then it certainly seems like you have non svg elements inside some svg element, otherwise this shouldn't be possible. Perhaps I should add some warnings in dev mode, giving some indication of what and where it is.


[Snyk] Fix for 1 vulnerabilities

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

packages/pwa-kit-runtime/package.json

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Breaking Change
Exploit Maturity

658/1000  Why? Proof of Concept exploit, Recently disclosed, Has a fix available, CVSS 5.3
Regular Expression Denial of Service (ReDoS) SNYK-JS-SEMVER-3247795
Yes
Proof of Concept

(*) Note that the real score may have changed since the PR was raised.

Commit messages

Package name: cross-env
    The new version differs by 1 commits.

61ebf59 fix: bumped cross-spawn to version 7.0.0 (#211)

See the full diff

Package name: semver
    The new version differs by 5 commits.

e7b78de chore: release 7.5.2
58c791f fix: diff when detecting major change from prerelease (#566)
5c8efbc fix: preserve build in raw after inc (#565)
717534e fix: better handling of whitespace (#564)
2f738e9 chore: bump @ npmcli/template-oss from 4.14.1 to 4.15.1 (#558)

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)

W-13673737


bug: ionicPushRegister affected by App Transport Security (iOS9)

Type: bug
Platform: ios 8 webview
Had to disable ATS (https://gist.github.com/mlynch/284699d676fe9ed0abfa) for ionicPushRegister to work. ionicPushRegister otherwise returns an SSL error.

Greetings @johnrobertcobbold!
My sensors indicate that you need to update your issue through our custom issue form. We are now requiring all issues to be submitted this way, to ensure that we have all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
I will have no choice but to close this issue if it is not resubmitted through the form. Please fill out the rest of the form, so that I may use my friendly robot powers to assist you.
Thank you!

Greetings @johnrobertcobbold!
I've closed this issue because my sensors indicated it was old and inactive, and may have already been fixed in recent versions of Ionic. However, if you are still experiencing this issue, please feel free to reopen this issue by creating a new one, and include any examples and other necessary information, so that we can look into it further.
Thank you for allowing me to assist you.


Autocomplete filterOptions limit "More options"

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Summary 💡
The Autocomplete filterOptions supports a "limit" attribute.
It would be great if there was a "moreOptionsText" or "optionsLimitHiddenText" attribute or something similar on the autocomplete that would let you notify the user there were more options available when they hit the filter limit.
This would be equivalent to the "noOptionsText" attribute.

@scottfr You can customize the component to display this information.

Thanks for the reply!
How would one customize the component to do something this? I see a number of render attributes like renderOption, but not something at would allow me to add a message at the end of the options lists.


Error in AssignCells function

Hello,
I'm trying out Celesta on my own dataset, and getting an error as follows on the AssignCells step of the protocol
[1] "Start calculating the scoring function."
Error in apply(activation_prob_to_use[, non_NA_index], 1, function(x) (1 -  :
dim(X) must have a positive length
Any idea what may be causing this?

Hi I am also having the same error, any help?
[1] "Proportion of cells changed assignment in the last iteration: 0.000427813587359535"
[1] "Total cells to be assigned in the current round: 1904"
[1] "Start calculating the scoring function."
Error in apply(current_scoring_matrix[unassigned_cells, cell_type_num],  :
  dim(X) must have a positive length
In addition: Warning messages:
1: In current_cell_type_assignment[, previous_level_round] == previous_level_type :
  longer object length is not a multiple of shorter object length
2: In current_cell_type_assignment[, previous_level_round] == previous_level_type :
  longer object length is not a multiple of shorter object length
3: In current_cell_type_assignment[, (round - 1)] == previous_level_type :
  longer object length is not a multiple of shorter object length
4: In current_cell_type_assignment[, previous_level_round] == previous_level_type :
  longer object length is not a multiple of shorter object length
5: In current_cell_type_assignment[, (round - 1)] == previous_level_type :
  longer object length is not a multiple of shorter object length
6: In current_cell_type_assignment[, previous_level_round] == previous_level_type :
  longer object length is not a multiple of shorter object length
7: In current_cell_type_assignment[, (round - 1)] == previous_level_type :
  longer object length is not a multiple of shorter object length

Hi, the issue is with the input signature matrix which was not properly set up. In the Lineage_level column, the first number is a round indicating the order for CELESTA to identify the subtypes from "ONE" main cell type identified in the previous round with level up of lineage. For example, in the first round, you identified tumor cells and immune cells,  in the second round, you can either identify subtypes of tumor cells or subtypes of immune cells, but not both. If you choose to identify subtypes of immune cells in the second round, you need to identify subtypes of tumor cells in the third round.
I have also provided a suggested cell type signature matrix and emailed it to you. I ran it using the default parameters, and I could run it without any error. Hope it can be helpful to clarify the set up.

Hello, I'm trying out Celesta on my own dataset, and getting an error as follows on the AssignCells step of the protocol
[1] "Start calculating the scoring function." Error in apply(activation_prob_to_use[, non_NA_index], 1, function(x) (1 - : dim(X) must have a positive length
Any idea what may be causing this?

If you can provide your two inputs as Jose, it would be helpful for troubleshooting.

Hi I am also having the same error, any help?
[1] "Proportion of cells changed assignment in the last iteration: 0.000427813587359535"
[1] "Total cells to be assigned in the current round: 1904"
[1] "Start calculating the scoring function."
Error in apply(current_scoring_matrix[unassigned_cells, cell_type_num],  :
  dim(X) must have a positive length
In addition: Warning messages:
1: In current_cell_type_assignment[, previous_level_round] == previous_level_type :
  longer object length is not a multiple of shorter object length
2: In current_cell_type_assignment[, previous_level_round] == previous_level_type :
  longer object length is not a multiple of shorter object length
3: In current_cell_type_assignment[, (round - 1)] == previous_level_type :
  longer object length is not a multiple of shorter object length
4: In current_cell_type_assignment[, previous_level_round] == previous_level_type :
  longer object length is not a multiple of shorter object length
5: In current_cell_type_assignment[, (round - 1)] == previous_level_type :
  longer object length is not a multiple of shorter object length
6: In current_cell_type_assignment[, previous_level_round] == previous_level_type :
  longer object length is not a multiple of shorter object length
7: In current_cell_type_assignment[, (round - 1)] == previous_level_type :
  longer object length is not a multiple of shorter object length

files can be downloaded here: https://filetransfer.mdc-berlin.de/?u=DxZaa8wM&p=UTUztNAv

Hi, the issue is with the input signature matrix which was not properly set up. In the Lineage_level column, the first number is a round indicating the order for CELESTA to identify the subtypes from "ONE" main cell type identified in the previous round with level up of lineage. For example, in the first round, you identified tumor cells and immune cells, in the second round, you can either identify subtypes of tumor cells or subtypes of immune cells, but not both. If you choose to identify subtypes of immune cells in the second round, you need to identify subtypes of tumor cells in the third round.
I have also provided a suggested cell type signature matrix and emailed it to you. I ran it using the default parameters, and I could run it without any error. Hope it can be helpful to clarify the set up.

Hi, I believe I have the lineage levels set up so that I'm only identifying subtypes from one main cell types per row:

I'm still encountering the same error message:

Hi, I believe I have the lineage levels set up so that I'm only identifying subtypes from one main cell types per row:
I'm still encountering the same error message:

For each round (the first number under the Lineage_level), CELESTA needs at least two cell types/subtypes, because the assignment is based on the higher probabilities. In this case, for round 3, there is only Tumor (3_2_6) cell, and that's why it caused the error. I would suggest putting Tumor cells in round 1, for example, on the round 1, having immune, tumor and non-immune/tumor cells. Or you only need immune and tumor on the first round, the rest of the cells will be assigned to unknowns.

I made the update you suggested and the same error message remains

I made the update you suggested and the same error message remains

Then it must be something else causing the error which is not obvious to see from only the lineage information. Can you please share the whole inputs if possible, including the full signature matrix and imaging data. Also it would be help to know at which round the error occurred.

matrix_for_reference.csv
There are several issues with your data. (1) It seems that your data have been transformed, even the X and Y coordinates, which is not right. Please double check your outputs from segmentation.
(2)The default transformation in CELESTA is ArcSinh, but only on expressions, not the X and Y columns. If you want to transform your own data, you need to set transform_type = 0 in the CreateCelestaObject( ) function. But still, the X and Y columns should not have any transformation. Please plot the cells using the X and Y coordinates to double check them.
(3) Your cell-type signature matrix has too many NAs. Some of the NAs are not right. For example, in your immune cells, you only have "1" for CD45, and NA for everything. CELESTA does not assign cell types based on only one marker, but based a combination of markers. In your case, you should at least set PANCK for "0" for immune cells, because PANCK is a general tumor marker. The error you got was because CELESTA did not have enough information to calculate a probability only based on one marker. Please see my attached signature matrix for reference. I changed some of the NAs to 1 or 0, but I don't know which tissue your data it is, so there may be more that can be changed to provide more accurate information on the cell types.

Sure! I included the matrix, the data file, and the r-script
https://drive.google.com/file/d/16sq05C0TMpUbJXXNpb2PH4v2wg5FYO8d/view?usp=sharing

matrix_for_reference.csv
There are several issues with your data. (1) It seems that your data have been transformed, even the X and Y coordinates, which is not right. Please double check your outputs from segmentation.
(2)The default transformation in CELESTA is ArcSinh, but only on expressions, not the X and Y columns. If you want to transform your own data, you need to set transform_type = 0 in the CreateCelestaObject( ) function. But still, the X and Y columns should not have any transformation. Please plot the cells using the X and Y coordinates to double check them.
(3) Your cell-type signature matrix has too many NAs. Some of the NAs are not right. For example, in your immune cells, you only have "1" for CD45, and NA for everything. CELESTA does not assign cell types based on only one marker, but based a combination of markers. In your case, you should at least set PANCK for "0" for immune cells, because PANCK is a general tumor marker. The error you got was because CELESTA did not have enough information to calculate a probability only based on one marker. Please see my attached signature matrix for reference. I changed some of the NAs to 1 or 0, but I don't know which tissue your data it is, so there may be more that can be changed to provide more accurate information on the cell types.

Dear @weiruo16,
I am very sorry for the late reply, I now understand the lineage writing, thank you for taking your time!

@weiruo16
I was able to take in your points and get the code working on this dataset, thank you! The X and Y coordinates ended up being correct, they were just large because they represented slide coordinates for a subset of cells from a single TMA core.

@weiruo16
I was able to take in your points and get the code working on this dataset, thank you! The X and Y coordinates ended up being correct, they were just large because they represented slide coordinates for a subset of cells from a single TMA core.

That makes sense! Thanks for explaining it.


Resolve issue with plugin version 1.2.0

Encountered an issue with version 1.2.0 of this plugin:
Check results with 1.2.0:
$ruby ./check-dns-1-2-0.rb -s <IP_ADDRESS> -d google.com -r <IP_ADDRESS>
Check failed to run: undefined method `answer' for #<Array:0x895b73c>, ["/opt/sensu/embedded/lib/ruby/gems/2.3.0/gems/sensu-plugins-dns-1.2.0/bin/check-dns.rb:215:in `check_ips'", "/opt/sensu/embedded/lib/ruby/gems/2.3.0/gems/sensu-plugins-dns-1.2.0/bin/check-dns.rb:185:in `block in check_results'", "/opt/sensu/embedded/lib/ruby/gems/2.3.0/gems/sensu-plugins-dns-1.2.0/bin/check-dns.rb:165:in `each'", "/opt/sensu/embedded/lib/ruby/gems/2.3.0/gems/sensu-plugins-dns-1.2.0/bin/check-dns.rb:165:in `check_results'", "/opt/sensu/embedded/lib/ruby/gems/2.3.0/gems/sensu-plugins-dns-1.2.0/bin/check-dns.rb:229:in `run'", "/opt/sensu/embedded/lib/ruby/gems/2.3.0/gems/sensu-plugin-1.4.2/lib/sensu-plugin/cli.rb:58:in `block in <class:CLI>'"]

Output of 1.1.0 version of this plugin:
$ruby ./check-dns-1-1-0.rb -s <IP_ADDRESS> -d google.com -r <IP_ADDRESS>
DNS OK: Resolved UNCHECKED google.com A included <IP_ADDRESS>

Some debug information:
--/lib/ruby/gems/2.3.0/gems/dnsruby-1.60.0/lib/dnsruby/ipv6.rb:93: `cannot interpret as IPv4 address: "MY_HOSTNAME"' (ArgumentError)
	from /opt/sensu/embedded/lib/ruby/gems/2.3.0/gems/dnsruby-1.60.0/lib/dnsruby/resolver.rb:513:in `set_config_nameserver'
	from /opt/sensu/embedded/lib/ruby/gems/2.3.0/gems/dnsruby-1.60.0/lib/dnsruby/resolver.rb:458:in `block in initialize'
	from /opt/sensu/embedded/lib/ruby/gems/2.3.0/gems/dnsruby-1.60.0/lib/dnsruby/resolver.rb:453:in `each'
	from /opt/sensu/embedded/lib/ruby/gems/2.3.0/gems/dnsruby-1.60.0/lib/dnsruby/resolver.rb:453:in `initialize'
	from /opt/sensu/embedded/lib/ruby/gems/2.3.0/gems/sensu-plugins-dns-1.2.0/bin/check-dns.rb:126:in `new'
	from /opt/sensu/embedded/lib/ruby/gems/2.3.0/gems/sensu-plugins-dns-1.2.0/bin/check-dns.rb:126:in `resolve_domain'
	from /opt/sensu/embedded/lib/ruby/gems/2.3.0/gems/sensu-plugins-dns-1.2.0/bin/check-dns.rb:228:in `run'
	from /opt/sensu/embedded/lib/ruby/gems/2.3.0/gems/sensu-plugin-1.4.2/lib/sensu-plugin/cli.rb:58:in `block in <class:CLI>'
/opt/sensu/embedded/lib/ruby/gems/2.3.0/gems/dnsruby-1.60.0/lib/dnsruby/ipv6.rb:93:          raise ArgumentError.new("not numeric IPv6 address: " + arg)

I haven't dig into diff between versions 1.1.0 and 1.2.0, though.
My environment:
Ruby version:
ruby --version
ruby 2.3.0p0 (2015-12-25 revision 53290) [i686-linux]

Gem version:
gem --version
2.6.6

OS: Ubuntu 12.04 i386 Kernel: 3.2.0-55-virtual
This host is pretty old and support term for 12.04 have already ended. So, if this issue is related to an outdated environment, please, advise and close this issue.
Thanks!

I'm seeing this same issue on Ubuntu 16.04 and 14.04

Here is the diff of 1.1.0 and 1.2.0: https://github.com/sensu-plugins/sensu-plugins-dns/compare/1.1.0...1.2.0 When I have some time tonight I will try to look into it if someone has not.

https://github.com/sensu-plugins/sensu-plugins-dns/pull/15

released: https://rubygems.org/gems/sensu-plugins-dns/versions/1.2.1

@grem11n @Qsick can you please validate the hotfix works for you?

@majormoses 1.2.1 is working properly for my configuration.  Thanks for the quick fix.

no problem, this is why we want to start adding testing to catch these regressions...

@majormoses I can confirm, that version 1.2.1 works on Ubuntu 12.04 i386 as well
Thank you for fixing this bug!


Lead Follow Up action on Car_Configuration__c

What is missing from the application? Please describe.
During the broadcast around the 14:30 mark there was a demo of a Lead Followup Flow that was initiated from the Configuration page.  I'm not seeing the action or the flow in the code base.
Describe the solution you'd like
A couple things in that flow I'm interested in - first, I'd like to see the new property editor that was released in Winter '21.  And on the last page of the flow there is an option to share the PDF with customer - I'm interested in how that's done.
Describe alternatives you've considered
N/A
Additional context

I think I'm going to get an answer on Twitter from @muenzpraeger .


Renames input title param to caption in section header

Description
Fixes #1820
Notes (out of scope, known isues, hints for reviewing code, ...)  (optional)
...
Test cases

[ ] Case 1:

Given I am the usual user
When I go to this page
Then I click on "Edit permissions"
And I hover on "Can View"

[auto-generated message] E2E test report on: https://algorea-static.s3.eu-central-1.amazonaws.com/branch/feature/change-title-param-in-section-header/playwright-report/index.html


Extension for Web Browser

I'm trying to use this for a non-gallery application. Specifically it's an internal application. When the person tries to open the application they are told to install the My Apps Secure Sign-in Extension. Is there a way where the external user doesn't need to install the extension?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1f8cb0a2-6df6-06d6-8cda-df18c0b2f32f
Version Independent ID: e452da86-6fd9-0919-2f87-74a196b72c43
Content: What is Azure Active Directory B2B collaboration?
Content Source: articles/active-directory/b2b/what-is-b2b.md
Service: active-directory
GitHub Login: @msmimart
Microsoft Alias: mimart

Thanks for the feedback! We are currently investigating and will update you shortly.

@chendley80 To sign in to password-based single sign-on, you must use the extension. After the extension is installed, you can sign in to it to enable additional features by selecting Sign in to get started. Refer to this document for more details - My Apps Secure Sign-in Extension.

@chendley80 Please let us know if you have any further query in this regard else we will move ahead to close this issue. Thanks.


Update NodeJS bounds

I released a new version of NodeJS.jl that updates the version of node used to v12.13.0. Ideally you would test whether your package works with that newer version of node, and then merge this here. You might also want to adjust the bounds in the general registry if you think that older versions of your package are also functional with the new release of NodeJS.jl.

Thanks  a  lot for the heads up! I've  tested this locally and it works fine. I've merged your branch in #298 so will close the PR here but thanks again for it!


<EMAIL_ADDRESS>params from withRouter prop is always empty (using a hashHistory)

Version
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Test Case
https://codesandbox.io/s/7y8pj28rrj
Steps to reproduce
Use a router (ConnectedRouter) with react-router-reduxwith a hashHistory from history. See the code codesandbox for the setup.
Expected Behavior
withRouter() hoc  should provide match.params to the encapsulated component, as it does for a Route.
Actual Behavior
withRouter() match.params object is always empty

The params are only provided to the route they are defined on. They aren't global. This is expected behavior.

But the doc says:

You can get access to the history object's properties and the closest 's match via the withRouter higher-order component. withRouter will pass updated match, location, and history props to the wrapped component whenever it renders.

!?

The closest Route's ancestor component. It doesn't work in the other direction (children) because they could define conflicting params at any point in the tree.


Popover update

Fixes #151
Make popover scrollable, displayed on click, and hidden on click anywhere else.

@ekongobie Good. i found one more issue in this - When the input box is selected (which is by default) and then we click on the popover button, it doesn't show the pop over. Only when clicked again, the pop over appears. Can you look into it?
Also, I just noticed that we have manually added the content in each popover. Changing this pop over would require extra efforts. Can you look into this and propose a new way to load this content? Let me know if you need more info/help regarding this.
Also, I noticed that we manually

@rtgdk I am looking into the "click" issue.
The default trigger for the popovers is the "click" action, so I can remove that option completely.
Concerning the popover content, we can definitely read that from a text file.
On it!

@rtgdk I have solved the popover click issue. However, inorder to solve this, the dismissal of the popover is only done when we click "outside", that is, not on the popover icon. Please test for convenience. I also removed the help text from the javascript and put is in a python file; and then I passed the help text to javascript through form field attributes.

@ekongobie Thanks for working on this!

@ekongobie If you could resolve the merge conflicts, I'll go ahead and merge this PR.


Feat/add jira to sample app

Add jira overview widget to sample app
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[x] Screenshots attached (for UI changes)

Installation guide: https://github.com/RoadieHQ/backstage-plugin-jira
How it looks like:
https://www.loom.com/share/f7b76b8e3bdf46b68aadb0fa61abf6ff

Another thought is that i'm not sure that it's valuable in the example-app in the repo. Maybe we could add it with some data to the backstate demo but not sure it brings any value in it's current state?

Hey @benjdlambert. The idea of the PR is to enable a discussion about whether or not it makes sense to have in the sample app. Totally agree that it might make more sense in the demo if we back it off to a JIRA project with some demo data.

Yeah I think with this proxy config too if it's added to the sample app people will have to have a JIRA_URL to start the app which is a little annoying.
Thinking this would be best placed on the demo site with a fake jira project or something to show the features if anything.

@benjdlambert 👍  Probably best to close this.


Update README.md to add Rhea biped

Added Rhea bipedal robot to list of bipeds.

I'd be delighted to add Rhea to this list! However I think its motion control software is not open source for now (@G-Levine correct me if I'm wrong) so not within the scope (this guideline) of this particular list.
Note that Rhea is already in the related Awesome Robot Descriptions list.

In response to your question @stephane-caron, I’ve published the motion control code for Rhea here, but I haven’t decided on a license for it yet.


Enable configuration JSON to specify api_url

Currently, we use the default api_url, which corresponds to a non-existent server.
We should instead support specifying this from the local analysis configuration JSON.

We can at least change this to mskcc1.foldingathome.org for now.


Heroku deployment with docker images

Deploy Docker images to Heroku for master and develop.
Show both links in Readme.
Also show build status of both.

Something I already found out towards this end:
We have to adjust the Dockerfile's CMD entry, to not overwrite Heroku's PORT environment variable, e.g.:
CMD cd /conquery && NODE_ENV=production node app/server
We also have to set a publicPath in the webpack.production.config.js (this is independent from Heroku, I actually assumed that I had fixed this already...)
publicPath: '/'


Add customizable top and bottom to v2.0.0

The top and bottom configurations didn't make it into the initial v2.0.0 release. Basically, we want to support:
var tracker = ScrollTracker({
  top: '.header',
  bottom: '.footer'
});

Hi Dan,
I think v2.0 has a problem with document height values. In my site when my page load fires all scroll events together :
25 % at 200px
50% at 400px
75% at 600px
100% at 800px
but my real document height is 3000px but document.body returns 800px.
Seems like in some point of the code, is using document.body or document.documentElement for height value instead of using function docHeight() that fix height values.
This behaviour doesn't happen on version 1.2. ;)

@aviveros can you share the page in question and your config settings? I'll take a look right away.
Thanks!

Hi Dan,
Thanks for your message, but my page is not public yet.
Our html is a mess and it could be cause that strange behaviour. I just want to mention to you, because if happens again in other projects
About setting, I just import json file , and use basic settings :
`tracker.on({
percentages: {
every: [25]
}
}, function(evt) {
console.log(evt.data.label); // > "25%"
console.log(evt.data.depth); // > 500
});`
Thanks

If you discover the reason for the issue, I'd love to help (definitely unhappy to hear about this).

I seem to be having the same or similar issue with a default installation of 2.0.4 code via GTM container with nothing else in it and no configuration option changes.
It fires all the events at the same time as if the page was very short.
It seems to be determining the current depth correctly, but the overall height of the page incorrectly. Here's an example:
http://recipetest.quantable.com/scroll_fresh.html
thanks!

This was a fun little rabbit hole!
Long story short, your example fails because it doesn't have a DOCTYPE declaration (e.g. <!DOCTYPE html>. This messes with the behavior of Element.clientHeight - it returns the visible height instead of the total height of the element. Add the DOCTYPE and all will be well. Hat tip to @id-pogni!
The larger issue is that this behavior should be accounted for. I'm working on a fix!

Great, thanks! Indeed it does work when I specify a doctype.
Unfortunately my real-world example page for deployment still fails in the same way, and it does have a doctype and is in standards mode:
http://recipetest.quantable.com/test.html

So the other way this fails is if body { height: 100% } is in the styles:

Hoping to fix both! Changing the contextHeight check to use docHeight() instead of document.body.clientHeight might do it, but I've got some tests for nested contexts that are failing at present.


Update scala3-library, ... to 3.3.3

About this PR
📦 Updates

org.scala-lang:scala3-library
org.scala-lang:scala3-library_sjs1

from 3.3.0 to 3.3.3
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-lang" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-lang" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, version-scheme:semver-spec, commit-count:1

Superseded by #623.


Allow nan values in indicate_error

Description
It would be nice if indicate_error has an option to skip nan values in the input data. Currently, means and stds are not drawn if there is a nan value.
Steps to reproduce
import numpy as np
import proplot as plot

x = np.arange(10)
rng = np.random.default_rng()
y = rng.standard_normal((100, 10))
y[5, 5] = np.nan

fig, ax = plot.subplots()
ax.plot(x, y, means=True)

Actual behavior: [What actually happened]

Proplot version
0.6.4

This was simple to fix -- just changed np.mean, np.percentile, and np.std calls to np.nanmean, np.nanpercentile, and np.nanstd (83ee1eb). These nan functions also seem to correctly handle masked ndarrays.

Hi @lukelbd, it seems like this issue appears again in v0.8.0. It does show the mean value but not standard deviation anymore.

Thanks -- this got lost in the plot.py refactor. Just pushed a 2-line fix, you can install the development version.


pubsub.get_message timeout vs disconnection

Both cases (timeout and disconnection) make pubsub.get_message return None, making it difficult to discriminate between them. For instance, I have the following code:
while True:
    start = time()
    msg = await pubsub.get_message(True, timeout=PING_PERIOD)
    if not msg and time() - start < PING_PERIOD:  # i.e., disconnected
        break
    if not msg:
        send_ping()

Instead, we could use a sentinel to indicate a timeout happened:
tos = object()
while msg := await pubsub.get_message(True, timeout=PING_PERIOD, timeout_sentinel=tos):
    if msg is tos:
        send_ping()

Having the default value of timeout_sentinel to be None would maintain backwards compatibility.
@NoneGG what do you think? If you like the idea, I can implement it and send you a PR.
Cheers, and thank you for your work.

@dmbasso Maybe we can just raise the timeout/disconnected error when it happens? (we can offer an option to descide whether the error can be raised when client is initialized)

Yes, that would work too. Please tell me if you need any help implementing this feature.

@dmbasso I read related code again and found both ConnectionError and TimeoutError get proceeded in pubsub._execute, is it necessary for uplayer to know these things?

By "uplayer" do you mean the function that calls pubsub.get_message? In my case, I just need to know that a timeout happened, and I consider CancelledError and ConnectionError as the end of a session (so no need to distinguish between those). Probably the best would be to raise all of them, and let the uplayer deal with it. Especially the CancelledError, since it means the coroutine should end, but the signal gets discarded in line 118.

@dmbasso Maybe we can offer an option for user to descide if these error should be raised?

@NoneGG Sounds good to me.


FFProbe Version Too Old

Hi,
I am getting the following error;
"Your FFProbe version is too old and does not support -help option, please upgrade."
I am not sure how to upgrade. I have searched around but not finding threads for your particular package.

The problem was my development environment. I am using XAMPP. Setting LD_LIBRARY_PATH="/usr/bin" just before export LD_LIBRARY_PATH in /opt/lampp/bin/envvars fixed the issue.


推理速度

大佬有在iphone上实测推理速度吗？

I don't know CoreML which is Apple' deep learning framework, so I don't to inference mobileone network at Apple.


Implement Kotlinx immutable collections

Because Map<*> is a mutable type, it is unstable and badly affects compose performance, we should use Kotlin immutable collections' ImmutableMap instead.
Refer: https://betterprogramming.pub/optimizing-recomposition-in-jetpack-compose-stability-system-f8ec0c92de33

Is this ever gonna get merged?

Instead of adding an addition dependency here, why not just mark the Lyricist object as Immutable? IMO it should be enough, and would avoid adding an additional dependency (that's still in alpha) to the library.

I agree that @Immutable should be enough and made this change on 1.5.0. If for any reason it don't fix the recomposition/performance issue we can try the immutable collection approach.
Thank you everyone!


Remove useless return

Hi @MathiasReker,
For this PR, I would rather leave these classes untouched.
The first one (Tools14) is deprecated and would accept only critical bug fixes, and the second one is a external lib which does not need to be updated manually in my opinion. If it needs some changes, it should be applied on the original project.


[Units of measusing] A validation message is not consistent to required, when Unit name and Short name are empty

Date Time
06-09-2021 13:55
Priority
Low
Environment:
OS: Windows 10 x64
Browser Google Chrome 91.0.4472.77
Reproducible: always
Build found: 20210607.1
Pre-conditions
An admin is logged in and on the page 'Admin'
Steps to Reproduce

Go to 'Unit of measuring' page
Click on 'Add unit'button
Click on 'Add' button
Pay attention on the calidation message under the 'Unit name' field

The same with the edit function:

Go to 'Unit of measuring' page
Click on 'Edit' near one of the units
Delete Data from the 'Unit name' and 'Short name'
Click on 'Add' button
Pay attention on the calidation message under the 'Unit name' field

Actual result
There are the following messages ' 'unit Name' must not be empty,' under the 'Unit name' edit box and ' 'short Name' must not be empty.' under the 'Short name' edit box.
Expected result
The 'Unit name' and 'Short name' are in red. There are the following validation messages under the edit boxes 'Unit name should not be empty'/'Short name should not be empty'
Screenshots
Add

Edit

User story and test case links E.g.: "User story #347  Test case #635 #636"
Labels to be added "Bug", Priority Low, Severity Minor, Type UI

Names changed. The red line will not give any additional information to the user


Used with keyword which is considered idiomatic for accessing resou…

…rces.
Apart from that, also made changes in comment format for uniformity.
Signed-off-by: Vishal Pancholi<EMAIL_ADDRESS>

@vishaaal Can you explain why it is required?

It is a good practice to use with keyword when handling resources that needs to be closed either. I though it'll improves the quality of the code.

Congratulations @vishaaal  for your PR getting merged! Thanks for taking part in OpenEBS Hackfest.
Fill up the doc form to get the Hackfest T-Shirt and Swags
https://docs.google.com/spreadsheets/d/1TZYIdERnD72YPeUsdS5hDfI6xgXXCax4-DHpXh-o6r0/edit?usp=sharing
Looking for some more awesome contributions from you and win more prizes


Reset the tint

That should be acceptable; as if you set it on one map; it follows you to the next one.

Thinking about it; it probably would have been better if I put it under the clear Transfer Info method instead as the lights turn all black when you first load the map in. But I wanted everything to line up perfectly and having stuff in two different spots didn't see right.

I also updated the wrong file. 🤦♀


System ContextMenu on titlebar cannot be disabled

Describe the bug
i want to disable system ContextMenu on titlebar i used winproc or subclass and i can get msg for WM_NCRBUTTONDOWN:
switch (Msg)
{

    case WindowMessage.WM_NCRBUTTONDOWN:
        if (wParam.ToInt32() == HTCAPTION)
        {
            return IntPtr.Zero;
        }
        break;
}

but system ContextMenu still opened and can not be disabled. also i found out that if we use custom titlebar we can not HTCAPTION and we should only use WM_NCRBUTTONDOWN.
anyway is this a bug? or is there  a way for doing this?

Steps to reproduce the bug
1.disable system context menu on titlebar
Expected behavior
No response
Screenshots
No response
NuGet package version
Windows App SDK 1.4.2: 1.4.231008000
Packaging type
Packaged (MSIX), Unpackaged
Windows version
Windows 11 version 22H2 (22621, 2022 Update)
IDE
Visual Studio 2022
Additional context
No response

@Gaoyifei1011 using
case
WindowMessage.WM_SYSMENU:
   {
       return 0;
   }

fixed both issues, double right click and maximize tnx

Yesterday I found out that the message was handled incorrectly. Instead of WM_NCRBUTTONDOWN, WM_NCRBUTTONUP should be handled. The latest code has been updated in my app (no need to change the window style to hide the app window menu at this time).
https://github.com/Gaoyifei1011/GetStoreApp/blob/master/GetStoreApp/Views/Windows/MainWindow.xaml.cs

@Gaoyifei1011 using
case
WindowMessage.WM_SYSMENU:
   {
       return 0;
   }

fixed both issues, double right click and maximize tnx

Yesterday I found out that the message was handled incorrectly. Instead of WM_NCRBUTTONDOWN, WM_NCRBUTTONUP should be handled. The latest code has been updated in my app (no need to change the window style to hide the app window menu at this time).
https://github.com/Gaoyifei1011/GetStoreApp/blob/master/GetStoreApp/Views/Windows/MainWindow.xaml.cs

I also addressed an issue where the window size can be accidentally modified by dragging the top border when the window is maximized


feat: add unknown fields in mesgdef structs

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.94%. Comparing base (e344207) to head (ef4d3c2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #468   +/-   ##
=======================================
  Coverage   99.94%   99.94%
=======================================
  Files          42       42
  Lines        3697     3697
=======================================
  Hits         3695     3695
  Misses          2        2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Implement quickcheck::Arbitrary for IPLD type for testing

ChainSafe's project Forest recently added property testing for serialization/deserialization of datatypes after finding a typo one day. We've been using quickcheck and need to implement Arbitrary on some of these types. In order to clean up our codebase from using Ipld wrappers, we'd like to push them upstream into the respective repositories.
The tracking issue can be found https://github.com/ChainSafe/forest/issues/2130
Thanks!

This is the continuation of https://github.com/ipld/libipld/pull/157 which has to be closed.
@vmx Could you give an approval, so that this PR could proceed to checks?

@tyshko5 For quicker turnaround times, it could make sense that you enable the CI on your fork, so that you can make sure things pass before you do a PR.

@vmx Do you need support for thumbv6m-none-eabi target?

@vmx cargo-apk was updated yesterday, and became unusable (e.g. --workspace flag isn't working). Unfortunately the previous, working version was yanked, so CI will constantly fail, unless you temporary don't turn of android builds
Other than that the PR is ready

@vmx cargo-apk was updated yesterday, and became unusable (e.g. --workspace flag isn't working). Unfortunately the previous, working version was yanked, so CI will constantly fail, unless you temporary don't turn of android builds
Other than that the PR is ready

If the PR is ready then it should no longer be marked as a draft.

Would you please also add .shrink()? Perusing the quickcheck sources I recently found an easier way to shrink the List and Map cases: Ipld::List(v) => Box::new(v.shrink().map(Ipld::List))

Would you please also add .shrink()? Perusing the quickcheck sources I recently found an easier way to shrink the List and Map cases: Ipld::List(v) => Box::new(v.shrink().map(Ipld::List))

Done

@vmx @rkuhn The CI failures appear to be unrelated to these changes.

LGTM!

@lemmih indeed. I've opened https://github.com/ipld/libipld/pull/169. A review would be great.

@tyshko5 I've merged a fix for the Android build issues. If you rebase (also feel free to squash all commits in a single one), the CI will hopefully be green.

Yay, CI is green.
@lemmih and @rkuhn may I ask you for a final review as I know very little about arbitraries. Once you both approve I think it's ready to go.


Update Juriba.Platform.psd1

We are allowing contributions for now with limited review whilst we learn what common practices, approach and recommendations we can follow prior to promoting these modules to our customers.

Manual Tasks Checklist

[*] Increment module version number in /Juriba.Platform/Juriba.Platform.psd1
[x] Add new functions to 'FunctionsToExport' in /Juriba.Platform/Juriba.Platform.psd1

Error in creation


Any chance on C++ support?

The readme pages only talks about C headers, so I guess C++ headers aren't supported. Any chance of support in the future? Would it be hard to add it?

One could convert this project to use CppHeaderParser instead. I've had fairly good luck using it to parse C++.

If you got it to work, could you publish it as a open source project?

I've used it to parse C++, I've not used it to convert C++ to PXD.