Maintainable international address parsing

Currently, I'm converting free-form US addresses to Shippo data using mucky regexes and a whole mess of if-else logic. I'm presently adding UK address parsing to this, growing the complexity. This won't be maintainable as a third country comes in.
The parsing logic in a human's head does a bunch of lifting:

Grab country from the address string or detect the (so far, US) country from, e.g., postal code
The address schema and postal code regex is country-dependent: for example, UK addresses don't include a state/province.

It would be overkill but a learning project to graduate from  to a principled parsing of an address string in the inventory spreadsheet to a row of Shippo CSV. (That's on brand: this whole repo is overkill but a learning project!)
Some resources:
https://tomassetti.me/parsing-in-python/

At the cost of complexity (separately building a C library) and bulk (the library seems to involve a 1.8 GB machine learning model), the canonical solution might be https://github.com/openvenues/pypostal, which implements a globally tested address parser using NLP techniques.

I've added UK and IE by now, and will soon add FR. The little abstraction I built for this feels adequate.

Reopening - French addresses (for which the postal code lives before the city) don't hold up to the brittle tree I've built, and I'm starting to think I need fancier methods, like a bona fide tokenizer and parser.


Compiler bug when a macro uses run() with spaces in the path

Try the following examples, lifted more or less straight from the docs:
directory with spaces/print_gotten_string.cr:
macro get_version
    {{ run("./get_string").stringify }}
end

puts get_version

directory with spaces/get_string.cr:
puts "Hi!"

Running crystal run print_gotten_string.cr errors out with the following message:
can't specify arguments in both, command and args without including "${@}" into your command
???
???
???
???
???
???
???
???
???
???
???
???
???
???
???
???
???
???
???
???
???

Error: you've found a bug in the Crystal compiler. Please open an issue, including source code that will allow us to reproduce the bug: https://github.com/crystal-lang/crystal/issues

It looks like Process.prepare_argv is getting the parts of the path as arguments instead of the entire path being passed in as the command.

Changed title to reflect the fact that it doesn't error out gracefully.

Should have been fixed by https://github.com/crystal-lang/crystal/pull/5543 , but probably not released in some of the past releases because of GitFlow.

There has only been the release of 0.24.2 since the merge and that did only include some bugfixes but not #5543
But I can confirm this issue is fixed in master.

Terrific, thanks!


Quest Helper not working

@Zoinkwiz

Switched on Quest helper and its not changing the colors of text when i have that item or skill or quest requirement done.

@Patlegend2021 can you please share your logs so I can see what happened? After that, try closing and opening Runelite and see if that fixes it for you.

Navigate to %userprofile%.runelite\logs on Windows or $HOME/.runelite/logs on Linux and macOS to get your logs.

@Zoinkwiz  oh it just fixed itself with an update :) thank you

Could you still share the logs? Would be good to see what caused it to happen.

client.log

Thanks, a fix to stop this should now be live!


Feature Request: Expose stable docker image tags: 'latest' and 'master'

Issue resolved. New releases publish to 'latest' docker image tags.


Cannot find type 'RCTEventDispatcher' in scope

Bug cannot find type 'RCTEventDispatcher' in scope
Platform

Which player are you experiencing the problem on:

iOS
Android

React native info output:
System:
OS: macOS 12.6
CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
Memory: 669.03 MB / 16.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 19.2.0 - /usr/local/bin/node
Yarn: 1.22.19 - /usr/local/bin/yarn
npm: 6.14.4 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
Managers:
CocoaPods: 1.11.3 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 22.2, iOS 16.2, macOS 13.1, tvOS 16.1, watchOS 9.1
Android SDK:
API Levels: 23, 25, 26, 27, 28, 29, 30, 31, 33
Build Tools: 28.0.3, 29.0.2, 29.0.3, 30.0.0, 30.0.2, 30.0.3, 31.0.0, 33.0.0
System Images: android-26 | Google Play Intel x86 Atom, android-28 | Google APIs Intel x86 Atom, android-28 | Google Play Intel x86 Atom, android-29 | Google Play Intel x86 Atom
Android NDK: Not Found
IDEs:
Android Studio: 2020.3 AI-203.7717.56.2031.7678000
Xcode: 14.2/14C18 - /usr/bin/xcodebuild
Languages:
Java: 13.0.2 - /usr/bin/javac
npmPackages:
@react-native-community/cli: 7.0.4 => 7.0.4
react: 17.0.2 => 17.0.2
react-native: 0.68.2 => 0.68.2
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
Library version:  "react-native-video": "v6.0.0-alpha.4",
Steps To Reproduce

npm install react-native-video
pods install
react-native run-ios
...

Expected behaviour

To run the application

RCTEventDispatcher is part of React-Core.
I don't have the issue on react-native 0.64 version
And I don't think this is reproduced on basic sample from this repo.
RCTEventDispatcher is included in : RCTEventDispatcherProtocol
Let me know if it helps, It is not the first time this issue is reported

Hey, by the documentation it says that we need to be on > 0.68.2 react-native to use 6.alpha.4 . I saw that in some commits it's fixed but is this fix in the last version? Not sure about that. What do you suggest with that " RCTEventDispatcher is included in : RCTEventDispatcherProtocol " ?

Sadly i cannot sent demo because our code is private. The application is being used by 250k users overall  with around 20m users total.

Yes, sorry. So I was using 5.2.0 and just updated to the latest one because I'm facing another issue which I want to investigate with the latest version. The issue is when the user is on full screen on iOS and there is a notification, modal or pop up ( just example how we bug it is we connect the phone to the charger and the pop up "Trust device" comes up) the phone is freezing and the only way to get out is to kill the app or restart the phone. Black screen is appearing. So I Just updated to the latest version which is : "react-native-video": "v6.0.0-alpha.4" .  npm version 6.14.4.
Using pure component and import of VIdeo from react-native-video.
`
<Video
source={{ uri: streamUrl }}
muted={mutePlayer}
onFullscreenPlayerDidDismiss={onExitFullScreen}
ref={(ref) => {
this.player = ref;
}}
resizeMode="cover"
pictureInPicture={false}
fullscreen={isFullScreen}
style={videoStyle}
/>
                    </TouchableOpacity>`

When I run pod install i do get :
Installing PromisesSwift (2.1.1)
Installing react-native-video 6.0.0-alpha.4 (was 5.2.0)
When I run the application I receive :
node_modules/react-native-video/ios/Video/RCTVideo.swift:98:26: cannot find type 'RCTEventDispatcher' in scope
init(eventDispatcher:RCTEventDispatcher!) {

node_modules/react-native-video/ios/Video/RCTVideo.swift:24:34: cannot find type 'RCTEventDispatcher' in scope
private var _eventDispatcher:RCTEventDispatcher?

Thank for you fast replies, I appreciate them .

please don't mix issues :)
So you still have the same issue on 6.0.0-alpha.4. It is strange...
I am a newbie in ios dev, but I merge master with my corporate fork and I don't have this issue...
On my laptop I also have the same xcode version:
% xcodebuild -version
Xcode 14.2
Build version 14C18
notice that this issue is a duplicated of: https://github.com/react-native-video/react-native-video/issues/2946

maybe you can try this : https://stackoverflow.com/questions/42204295/integrating-existing-app-ios-react-rcteventdispatcher-h-file-not-found-on-reac

I did tried this and i'm receiving the same :
/Users/roberto.tsvetanov/Documents/All-Repositories/Janus/janus-frontend-mobile/node_modules/react-native-video/ios/Video/RCTVideo.swift:98:26: cannot find type 'RCTEventDispatcher' in scope
init(eventDispatcher:RCTEventDispatcher!) {

Sadly. Well I can use 5.2.1 but still cannot get 6 version working :(

I had the same issue.
Wasn't able to reproduce it properly in a clean repo.
A workaround was to patch the package by adding the import to #import "RCTEventDispatcher.h" in the ios/Video/RCTVideo-Bridging-Header.h file.
index 77815e4e48403a71431aa0df5383ef7c5ae795b9..586eec111034c6488fe928c11a86189cd5ce2f2c 100644
--- a/ios/Video/RCTVideo-Bridging-Header.h
+++ b/ios/Video/RCTVideo-Bridging-Header.h
@@ -1,5 +1,6 @@
 #import <React/RCTViewManager.h>
 #import "RCTVideoSwiftLog.h"
+#import "RCTEventDispatcher.h"

 #if __has_include(<react-native-video/RCTVideoCache.h>)
 #import "RCTVideoCache.h"

I am also experiancing this issue. When building via yarn ios I get this error.
The following build commands failed:
SwiftEmitModule normal x86_64 Emitting\ module\ for\ react_native_video (in target 'react-native-video' from project 'Pods')
(1 failure)
but building on xcode I get the RCTEventDispatcher.h not found.
building with:
Xcode 14.2
Build version 14C18
"react-native": "0.71.3",

I am not able to reproduce it with XCode 15 and<EMAIL_ADDRESS>

Feel free to reopen ticket if it still occurs for you


[Feature Request]: Adding contact us in "Restaurant Website"

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
I want to add contact us section in restaurant website
like this:
Use Case
It would be helpful for users if they can contact the owner
Benefits
No response
Add ScreenShots

Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[ ] I'm a SSOC'24 contributor
[X] I have starred the repository

@apu52 Please assign it to me , I have created PRs for all my previous issues


Scheduled/Reconciled filter buttons do not work in Firefox (59)

Name of Defective Feature
Toggle Scheduled and Reconciled Transaction Buttons
System Settings (Required)

ToolKit Version: 2.3.0
Operating System (Mac/Windows/Etc): Windows 10
Browser (Chrome/Firefox/Safari): Firefox.
Browser Version: 59.0.2 64 bit
Other Extensions: None.

Export of Toolkit Settings (Bottom Left of Settings Page)

Settings Export
[{"key":"goalIndicator","value":true},{"key":"highlightNegativesNegative","value":true},{"key":"l10n","value":"0"},{"key":"pacing","value":"0"},{"key":"popupCalculator","value":false},{"key":"reports","value":false},{"key":"AdditionalColumns","value":true},{"key":"RunningBalance","value":"0"},{"key":"CheckNumbers","value":false},{"key":"AdjustableColumnWidths","value":false},{"key":"AutoDistributeSplits","value":true},{"key":"CalendarFirstDay","value":"0"},{"key":"ChangeEnterBehavior","value":false},{"key":"ClearSelection","value":true},{"key":"CustomFlagNames","value":false},{"key":"EasyTransactionApproval","value":true},{"key":"AccountsEmphasizedOutflows","value":false},{"key":"LargerClickableIcons","value":true},{"key":"ReconciledTextColor","value":"1"},{"key":"RightClickToEdit","value":true},{"key":"RowHeight","value":"1"},{"key":"ShowCategoryBalance","value":false},{"key":"SpareChange","value":false},{"key":"SplitKeyboardShortcut","value":true},{"key":"SplitTransactionAutoAdjust","value":true},{"key":"AccountsStripedRows","value":true},{"key":"SwapClearedFlagged","value":false},{"key":"ToggleSplits","value":true},{"key":"ToggleTransactionFilters","value":"1"},{"key":"DisableToolkit","value":false},{"key":"BudgetProgressBars","value":"0"},{"key":"CategoryActivityCopy","value":false},{"key":"CategoryActivityPopupWidth","value":"2"},{"key":"CheckCreditBalances","value":true},{"key":"DaysOfBuffering","value":true},{"key":"DaysOfBufferingHistoryLookup","value":"0"},{"key":"DisplayTargetGoalAmount","value":"2"},{"key":"EnableRetroCalculator","value":true},{"key":"EnlargeCategoriesDropdown","value":true},{"key":"EnterToMove","value":true},{"key":"GoalWarningColor","value":true},{"key":"HideAgeOfMoney","value":false},{"key":"CurrentMonthIndicator","value":false},{"key":"IncomeFromLastMonth","value":"0"},{"key":"MonthlyNotesPopupWidth","value":"2"},{"key":"QuickBudgetWarning","value":false},{"key":"RemovePositiveHighlight","value":false},{"key":"RemoveZeroCategories","value":false},{"key":"ResizeInspector","value":false},{"key":"RowsHeight","value":"1"},{"key":"SeamlessBudgetHeader","value":true},{"key":"StealingFromFuture","value":true},{"key":"TargetBalanceWarning","value":true},{"key":"ToBeBudgetedWarning","value":true},{"key":"ToggleMasterCategories","value":true},{"key":"AccountsDisplayDensity","value":"0"},{"key":"BetterScrollbars","value":"1"},{"key":"BudgetQuickSwitch","value":false},{"key":"CollapseSideMenu","value":false},{"key":"ColourBlindMode","value":false},{"key":"EditAccountButton","value":"2"},{"key":"GoogleFontsSelector","value":"4"},{"key":"HideAccountBalancesType","value":"0"},{"key":"HideHelp","value":true},{"key":"HideReferralBanner","value":false},{"key":"ImportNotification","value":"2"},{"key":"NavDisplayDensity","value":"1"},{"key":"PrintingImprovements","value":true},{"key":"PrivacyMode","value":"0"},{"key":"ShowIntercom","value":true},{"key":"SquareNegativeMode","value":false},{"key":"CompactIncomeVsExpense","value":true},{"key":"TransactionGridFeatures","value":true},{"key":"CreditCardEmoji","value":false},{"key":"DisplayTotalMonthlyGoals","value":false},{"key":"Pacing","value":"0"},{"key":"ViewZeroAsEmpty","value":false}]

Steps to Reproduce the Behavior

Go to any account.
Click either of the buttons to toggle scheduled or reconciled transactions.

Expected Behavior
That the filter would be change to show/hide the specified transactions.
Actual Behavior
Nothing at all. And there is no error logged in the console.

Any update on this issue? Still remains a problem for me too using latest version of plugin v2.3.2 and latest version of Firefox v59.0.2

@lawrence-dol @Jagstyles I plan on tackling firefox related bugs tomorrow! Hope to have some fixes for ya'll coming out this week.

Got the update today of the YNAB Toolkit, issue still remains.

Yep, haven't had time to tackle it yet.

Hey @lawrence-dol @Jagstyles the fix for this should be in our current release! If you notice the issue still exists and you're definitely running the newest version of the toolkit, please reopen! Thanks!
Please note, all browser can take up to an hour to provide updates to all users. You can force an update if it's available for you by going to chrome://extensions and clicking the "Update" button. Firefox users can go to about:addons, click the setting cog, and click "Check for updates...".

@joshmadewell : Confirmed working in 2.4.1, thanks. Note that I had to manually request the addon to update, so if others remain on 2.4.0 for a while, doing that might help.


Add progressive TypeScript compilation

Fixes

Fixes #175 by @sarayourfriend
Description

Replaces jsconfig.json with a tsconfig.json that mirrors Gutenberg's with some changes to accomodate not being a composite project.
Currently this only checks a single file, basically in an effort to minimize the size of this PR while also still proving that it does work as intended. I had to make a small update to the type declarations in this file to get the compiler to pass. Hooray for type feedback! 🎉
Future work will include slowly adding each file in src/composables to the include array. We can also start running the type checker on other parts of the codebase like the services 🙂 I would propose doing this in small isolated bits and pieces to avoid having to make too many changes in a single PR to address the inevitable error here and there.
Testing Instructions

Checkout the PR and run npm run types. Everything should come back without an error. Next, update use-event-listener-outside.js to include a type error. For example, add the following somewhere in the file:
/** @type {string} */
const foo = null

This is a type error becuase you can't assign null to a string. Your IDE should pick this up and give you some squiggly lines or a warning (however your IDE normally picks up compilation errors). You should now also be able to run npm run tsc and have it report back the error to you.

Checklist

[ ] My pull request has a descriptive title (not a vague title like Update index.md).
[ ] My pull request targets the default branch of the repository (main) or a parent feature branch.
[ ] My commit messages follow best practices.
[ ] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[ ] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

npm run format:test is warning on the tsconfig.json file, however...


Make teleport command work in multiplayer.

Contains
Make teleport command work in multiplayer.
API wise, character teleports can now be simply triggered on the server side by sending a CharacterTeleportEvent to the entity. So implementing a portal should be much simpler now.
How to test
Use the teleport command as remote client.
Outstanding before merging
Can be merged after #1619 so that @HashCode55  does not have to do the merging.
@HashCode55: I started trying it out (because I was curious) before I read your reply and when I read it I was almost done. I hope you don't mind that I created this pull request.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.terasology.org/job/TerasologyPRs/490/
Hooray Jenkins reported success with all tests good!

I tested this in a headless server/remote client scenario.  Works great.  Also,  I like the new event,  I must admit I have avoided anything teleport-y bceause of the complexity of doing this.
Ill wait till after #1619 to merge this.
Also... flo, your github branches are taking over my branch list!  :D

Also... flo, your github branches are taking over my branch list! :D

Haha yes, so much this :D
Thanks for the quick fix!

With #2217 now potentially being problematic due to the server/client stuff should we go ahead and merge this first?
With a release scheduled Sunday I'd rather stay safe on stability, can merge the other one after.

yes, since it is clear that the other issue will take longer, please merge this.

Tests out great with headless server + 2 clients, merged :-)
Thanks!


check filter state when call c Api from Go.

we just panic here, when returning a invalid status from C.
after https://github.com/mosn/envoy-go-extension/issues/47, Go will recover with 500 status local reply.


Wrong query in case of empty variables

Same as https://github.com/vkolgi/json-to-graphql-query/issues/19 but for __variables
where if we initialize it with {} it will generate the query with ()

closing this as it was already fixed in https://github.com/vkolgi/json-to-graphql-query/pull/47
I was using an old fork


Fix typo in control module

Fix typo in the control module.
Please merge this with the following pull request simultaneously.
https://github.com/tier4/autoware_launcher.iv.universe/pull/91

I'm considering the merge timing, please wait for that.


Calling an environment modifying target from another target will not modify the target

With or without #81, calling one target from another, never modifies the environment after calling. This could either be a feature or a burden.
Which should it be? @scott-vsi
a)
  justify b
  echo ${FOO-}
  ;;
b)
  export FOO=bar
  ;;

This would not echo bar

echo bar

Ok. Let's call this a bug, and fix it. If the use want to have the subshell, they can add the ()


Changes In Working Hours

Related Task:

https://github.com/buerokratt/Buerokratt-Chatbot/issues/914

Closed to open a new pr aganist v2.0.2


Youtube embeds lose control once clicked

If you press play on a youtube embed, your mouse is no longer recognized by it, and it acts funny

This only affects videos on the right hand side because of column count

Hmm, perhaps we should just address the column issue if that would fix this bug too.

Yeah exactly, working on that now!


Documentation image migration

NOTE: This is a PR into the material-docs branch for #295.
On this branch, I moved the doc images folder from here:
/docs/blender_docs/images

to here:
/images

By placing these images in the root of our repo, GitHub markdown will link them correctly for viewing on GitHub.
I didn't include this change directly in my other PR, because I know @donmccurdy was thinking about removing these from this repo longer-term.  Moving them makes a nice improvement in readability here, although we still want to direct normal users to the full Blender Manual, not here.
So I'm fine with either merging this or discarding this, whatever's best.

For example:  https://github.com/KhronosGroup/glTF-Blender-IO/blob/image-migration-test/docs/blender_docs/io_gltf2.rst#normal-map

thanks!


Custom Index added for each tasks to support multiple tasks in same row

In order to allow multiple tasks to be allowed in a single row, custom_index can be added to the task object.

Thanks! Please remove the package.json changes. Also, could you add an example?

If you resolve the conflicts, we can merge this. Thanks!


rc_visard: 3.3.0-1 in 'noetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository rc_visard to 3.3.0-1:

upstream repository: https://github.com/roboception/rc_visard_ros.git
release repository: https://github.com/roboception-gbp/rc_visard-release.git
distro file: noetic/distribution.yaml
bloom version: 0.10.7
previous version for package: 3.2.4-1

rc_hand_eye_calibration_client

No changes

rc_pick_client
* remove load_carrier and ROI services
* remove load_carrier parameters

rc_silhouettematch_client
* remove ROI services

rc_tagdetect_client

No changes

rc_visard

No changes

rc_visard_description

No changes

rc_visard_driver

No changes

Holding for Noetic sync


[Accessibility] [Keyboard Navigation] Fix the focus indicator on the Clear State popup dialog

Fixes ADO Issue: #63996
Describe the issue
If users Navigate on the File menu item and select the Clear State option and a pop-up appears and focus land on the OK button but the keyboard focus indicator is not visible on the Ok button, then it would be difficult for users to understand where the focus indicator landed.
Actual behavior:
Navigating on the File menu item and select the Clear State option and a pop-up appears and the keyboard focus indicator lands on the OK button but visually keyboard focus indicator is not visible on the Ok button.
Expected behavior:
Navigating on the File menu item and select the Clear State option and a pop-up appears and the keyboard focus indicator lands on the OK button, So visually keyboard focus indicator should be visible on the Ok button.
Repro Steps:

Open Bot Framework Emulator installed on the system.
Bot Framework Emulator Application with Welcome screen opens.
Navigate on the welcome screen and select Create a New BOT configuration link.
New BOT Configuration dialog opens.
Navigate on the dialog and enter inputs in edit fields then select the save and connect button.
Navigate to File Menu on the ribbon and select it.
File menu opens, navigate to Clear state menu item and select it.
Dialog box with warning message opens, navigate on the dialog box.
Verify the keyboard focus indicator is visible on the OK button or not.

Changes included in the PR

Removed the default button configuration from the message box dialog so the OK button can be focused

Screenshots
Focus indicator

Test cases executed successfully
emulatorCommands

Coverage remained the same at 67.866% when pulling 68a0e9434a27bfd52810504b182bfa4c836a0bc0 on southworks:external/southworks/fix/clear-state/fix-button-focus into a09833d1b09d244ea22f51b77bf53ed763ce2ab4 on microsoft:main.


add open with wallet to invoice page

I've added an additional link, so users can tap to pay open their wallets to pay the invoice which is very useful specially on Android phones where you can select open with app.
This is halfway between making the QR clickable and doing a whole new design with additional copy/tap to open buttons which would change the nice clean UI.
I hope you'll consider it. I'm happy to make any changes as well.
Here's a simple demo video: https://www.youtube.com/watch?v=H1t-eQjiltM
reference discussion: https://twitter.com/nicolasburtey/status/1411754381280694273?s=20

@pseudozach Thanks for the contribution!

thanks for merging happy to help!

@bumi the same thing you were suggesting

whoot, nice! that's great, very useful to use it.
(now we only need to add WebLN )


can't get latex of a model

should this work? (on the 1682master branch of gpkit-models)
In [1]: from gas_hale_rebuild6 import GasPoweredHALE

In [2]: m = GasPoweredHALE()

In [3]: m.latex()
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-3-b847b3044a3b> in <module>()
----> 1 m.latex()

/Users/whoburg/MIT/dev/gpkit/gpkit/constraints/base.pyc in latex(self, excluded)
     66             cstr = constraint.subconstr_latex(excluded)
     67             if cstr is None:
---> 68                 cstr = constraint.latex(excluded)
     69             if cstr[:6] != "    & ":  # require indentation
     70                 cstr = "    & " + cstr + " \\\\"

/Users/whoburg/MIT/dev/gpkit/gpkit/constraints/single_equation.pyc in latex(self, excluded)
     43         latex_oper = self.latex_opers[self.oper]
     44         return ("%s %s %s" % (self.left.latex(excluded), latex_oper,
---> 45                               self.right.latex(excluded)))
     46
     47     def sub(self, subs, value=None):

AttributeError: 'int' object has no attribute 'latex'

Looks like one of the monomial constraints has a non variable side? But
this should work, yeah.
On Apr 12, 2016 00:36, "Warren Hoburg"<EMAIL_ADDRESS>wrote:

should this work? (on the 1682master branch of gpkit-models)
In [1]: from gas_hale_rebuild6 import GasPoweredHALE
In [2]: m = GasPoweredHALE()
In [3]: m.latex()---------------------------------------------------------------------------AttributeError                            Traceback (most recent call last) in ()----> 1 m.latex()
/Users/whoburg/MIT/dev/gpkit/gpkit/constraints/base.pyc in latex(self, excluded)
66             cstr = constraint.subconstr_latex(excluded)
67             if cstr is None:---> 68                 cstr = constraint.latex(excluded)
69             if cstr[:6] != "    & ":  # require indentation
70                 cstr = "    & " + cstr + " \\"
/Users/whoburg/MIT/dev/gpkit/gpkit/constraints/single_equation.pyc in latex(self, excluded)
43         latex_oper = self.latex_opers[self.oper]
44         return ("%s %s %s" % (self.left.latex(excluded), latex_oper,---> 45                               self.right.latex(excluded)))
46
47     def sub(self, subs, value=None):
AttributeError: 'int' object has no attribute 'latex'
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/hoburg/gpkit/issues/647

[ ] also unit test the underlying issue once determined

test (1 >= Variable()).latex()


[udp] forbid udp duplicate open

This commit forbid opening a UDP socket twice.

@jwhui Comments are resolved now. PTAL again.


Another code to print meetings list on PDF

Hello, I am not sure if I should ask here...
I dont remember when, but maybe 2 years ago. I saw a conference about a module that generate more elaborate PDF from a TSML.
is there someone who know about it?
Thank you

There are two options I am aware of: the Code for Recovery PDF service (actively maintained/developed), and a PDF plugin developed by another individual.


Liquid: Check pre-requisities for liquid creation (if there are any aromas)

Also on empty liquid list and empty aromas show Buy Aroma instead of new Liquid.

Obsolete.


Pipelining

https://realpython.com/blog/python/web-scraping-and-crawling-with-scrapy-and-mongodb/

https://github.com/Coll3ctions/scrapy-elasticsearch


Internal review: dev-apis: platform: Add target for nRF5340 and nRF9160

Add tgt_dev_apis_tfm_nrf which can be used for both nRF5340 and nRF9160.
Most of the porting is offloaded to the project that includes this.
Signed-off-by: Øyvind Rønningstad<EMAIL_ADDRESS>

cc @ioannisg @anangl @magnev @andvib @frkv


Add a UI indicator for database creating

When importing a JSON file, there should be a visual indicator present while the database is being created. This should probably also disable features that shouldn't be accessible until the database is created (for example, DataTables and Node View).

Merged into develop


Occasional "Null timestamp in input" during realtime ingestion

We use druid 0.10.0 and tranquility-kafka to do realtime ingestion. Occasionally, we see NPE in realtime task log, and the error message looks fairly strange.
io.druid.java.util.common.parsers.ParseException: Unparseable timestamp found!
        at io.druid.data.input.impl.MapInputRowParser.parse(MapInputRowParser.java:75) ~[druid-api-0.10.0.jar:0.10.0]
        at io.druid.segment.realtime.firehose.EventReceiverFirehoseFactory$EventReceiverFirehose.addAll(EventReceiverFirehoseFactory.java:192) ~[druid-server-0.10.0.jar:0.10.0]
Caused by: java.lang.NullPointerException: Null timestamp in input: {timestamp=1505203571000, reach=0, passImpression=1, passReach=0, frequencyFilter=0, click=0, impres...
        at io.druid.data.input.impl.MapInputRowParser.parse(MapInputRowParser.java:67) ~[druid-api-0.10.0.jar:0.10.0]
        ... 54 more

From the error message, it's obvious that the timestamp column "timestamp" does exist and has a valid value, but Druid says "Null timestamp in input" anyway.

Related code in TimestampSpec.java
// remember last value parsed
private ParseCtx parseCtx = new ParseCtx();

public DateTime extractTimestamp(Map<String, Object> input)
{
  return parseDateTime(input.get(timestampColumn));
}

public DateTime parseDateTime(Object input)
{
  DateTime extracted = null;
  if (input != null) {
    if (input.equals(parseCtx.lastTimeObject)) {
      extracted = parseCtx.lastDateTime;
    } else {
      ParseCtx newCtx = new ParseCtx();
      newCtx.lastTimeObject = input;
      extracted = timestampConverter.apply(input);
      newCtx.lastDateTime = extracted;
      parseCtx = newCtx;
    }
  }
  return extracted;
}

In this case, input of parseDateTime can't be null (timestamp column exists!), and timestampConverter.apply never returns null. So it looks like parseDateTime can't return null but it  did happen occasionally.

It seems that TimestampSpec is used inside "/push-events" endpoint of EventReceiverFirehose, so there can be concurrent usage of it. But the implementation is not thread-safe, there is a race condition of ParseCtx.

Fixed by #4791.


Extending Map with wrong number of type arguments shows no error

TypeScript Version:  3.2.0-dev.20181017
Code
class MyMap extends Map<string> {}

Expected behavior:
Error: No base constructor has the specified number of type arguments.
Actual behavior:
No error.
Issue was introduced by #25374. The issues it fixed, #23551 and #25362, seem to work fine even if I revert the change. CC @sandersn to confirm that JS class augmentation has been fixed and #25374 can be reverted.

I change I made recently made sure that base type nodes lookup accounts for jsdoc everywhere, instead of a few places. That's probably what fixed the original issues. Reverting the lib changes seems like the right thing.
I can't find the PR right now, though.


Models defined with sa.Table not accessable in shell context

The shell context script only filters the models defined with Model, but not sa.Table, can we modify to access them as well?
https://github.com/miguelgrinberg/microblog-api/blob/main/api/app.py#L42-L50

This project uses the ORM, so plain tables are not an important part of it and it is not really necessary that there is access to them in the shell. The tables in this project exist to support many-to-many relationships only, they are not intended to be accessed.


Test updates and clean ups

Test cases for Schedules as well as clean up on Events

Codecov Report

Merging #195 (3bac20c) into master (dba554c) will increase coverage by 4.13%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #195      +/-   ##
============================================
+ Coverage     40.78%   44.92%   +4.13%
- Complexity      644      682      +38
============================================
  Files           184      178       -6
  Lines          3653     3528     -125
  Branches        418      405      -13
============================================
+ Hits           1490     1585      +95
+ Misses         2082     1841     -241
- Partials         81      102      +21

Impacted Files
Coverage Δ

.../main/java/seedu/address/model/event/Schedule.java
45.87% <0.00%> (+45.87%)
:arrow_up:

.../seedu/address/model/event/UniqueScheduleList.java
66.10% <0.00%> (+50.84%)
:arrow_up:

src/main/java/seedu/address/model/event/Event.java
84.61% <0.00%> (+84.61%)
:arrow_up:

...model/event/exceptions/EventNotFoundException.java
100.00% <0.00%> (+100.00%)
:arrow_up:

...l/event/exceptions/DuplicateScheduleException.java
100.00% <0.00%> (+100.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dba554c...3bac20c. Read the comment docs.


create base project structure

skeletal base project structure
base API for getting list of races for the game
needs refactoring and more improvements, DB schema updation

merged


Add helper methods for rotating Transforms

Objective
Users often ask for help with rotations as they struggle with Quats.
Quat is rather complex and has a ton of verbose methods.
Solution
Add rotation helper methods to Transform.

Ping @bitshifter for review.

CI failure is a little funny since it is my code giving a warning... but it's from a different PR that is already merged.
Anyways, new rust stable release, yay!

bors r+


Preferred networks aren't used with a co-branded card when user does not select a network themselves in CardForm component

Describe the bug
The list of preferred networks that should be used to process payments made with a co-branded card isn't used when user does not select a network themselves in CardForm component. For PaymentSheet it works.
To Reproduce
Steps to reproduce the behavior:

Configure CardForm component with preferredNetworks={[CardBrand.Mastercard, CardBrand.Visa]} props
Enter co-branded card test number<PHONE_NUMBER>001001
Add card
Properties card.networks.preferred = null and card.display_brand = "cartes_bancaires" while they should be equal to "visa"

Expected behavior
Preferred networks should be used.
Screenshots

Smartphone (please complete the following information):

Device: iPhone 15 Pro (simulator)
OS: iOS 17.4

Additional context

@stripe/stripe-react-native = 0.37.1

@charliecruzan-stripe


License script failing

$ ../../../third_party/dart/tools/sdks/dart-sdk/bin/dart lib/main.dart --src ../../.. --out ../../../out/licenses --golden ../../ci/licenses_golden/
Collecting licenses for third_party
1713 of 6218 ██░░░░░░░░ 28% (0 missing licenses)  .../vm/compiler/frontend/kernel_binary_flowgraph.h    error searching for copyright in: ../../../third_party/dart/runtime/vm/compiler/frontend/kernel_to_il.cc
unmatched potential copyright and license statements; first twenty lines:
----8<----
// Copyright (c) 2016, the Dart project authors.  Please see the AUTHORp file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
#include "vm/compiler/aot/precompiler.h"
#include "vm/compiler/frontend/kernel_to_il.h"
#include "vm/compiler/backend/il.h"
#include "vm/compiler/backend/il_printer.h"
#include "vm/compiler/frontend/kernel_binary_flowgraph.h"
#include "vm/compiler/frontend/kernel_translation_helper.h"
#include "vm/compiler/frontend/prologue_builder.h"
#include "vm/compiler/jit/compiler.h"
#include "vm/kernel_loader.h"
#include "vm/longjump.h"
#include "vm/object_store.h"
#include "vm/report.h"
#include "vm/resolver.h"
#include "vm/stack_frame.h"
----8<----
Seems to be from https://github.com/flutter/engine/commit/a56467ed74d94a34f46498e902a13b09b8c0aa0a

@a-siva

The problem is the "p" after AUTHOR in https://github.com/dart-lang/sdk/blob/1a260925ef3ca9a1cfc9a685c19fc60b2681e317/runtime/vm/compiler/frontend/kernel_to_il.cc#L1

How come this does not show up when running flutter/ci/licenses.sh file?
( setenv PATH /usr/local/google/home/asiva/workspace/flutter-roll/engine/src/third_party/dart/tools/sdks/dart-sdk/bin:$PATH ; flutter/ci/licenses.sh )

Upstream fix: https://dart-review.googlesource.com/c/sdk/+/87986

@a-siva flutter/ci/licenses.sh only runs for third_party if the hash of that directory doesn't match what's in ci/licenses_golden/licenses_third_party. If the hash has already been updated to the new content of third_party and you run the script again, it skips re-scanning that directory and you will not see the warning again.

We may want to change the license script to not produce a new golden file if there are unmatched licenses to avoid this situation in the future.

Could we do a dart roll with the fix to get the license script going?

reverted the Dart roll for now.


RO-4034 Update OSA SHA for apt_repo fixes [newton-rc]

In order to bring the fixes in to ensure that apt_repository
changes are properly applied and the cache updated, the OSA
SHA is being bumped. See the following bug for more details:
https://bugs.launchpad.net/openstack-ansible/+bug/1750656
(cherry picked from commit affe6386750df2bc83be2985fd12ad6ace511c3e)
Backport of https://github.com/rcbops/rpc-openstack/pull/2869
Issue: RO-4034

Thanks @git-harry - I have no idea how that happened. Updated to include the right thing.


findCastOf can return more matches than requested

Describe the bug
Ask for one show, get two shows back.
To Reproduce
./findCastOf.sh casablanca
I found 10 shows titled "Casablanca"
 1) imdb.com/title/tt10497826	movie	Kasablanka	Casablanca	2019
 2) imdb.com/title/tt0135830	movie	Casablanca	Casablanca	1961
 3) imdb.com/title/tt0034583	movie	Casablanca	Casablanca	1942
 4) imdb.com/title/tt10399586	movie	Casablanca	Casablanca
 5) imdb.com/title/tt7230762	short	Casablanca	Casablanca	2015
 6) imdb.com/title/tt4241196	short	Casablanca	Casablanca	2014
 7) imdb.com/title/tt3682804	short	Casablanca	Casablanca	2013
 8) imdb.com/title/tt0411217	short	Casablanca	Casablanca	2003
 9) imdb.com/title/tt0303279	short	Casablanca	Casablanca	2002
10) imdb.com/title/tt0084994	tvSeries	Casablanca	Casablanca	1983
11) imdb.com/title/tt0047719	tvSeries	Casablanca	Casablanca	1955
12) Skip "Casablanca"
13) Quit

Pick 3) imdb.com/title/tt0034583	movie	Casablanca	Casablanca	1942
This is the result:
Adding: imdb.com/title/tt0034583	movie	Casablanca	Casablanca	1942

These are the shows I found:
imdb.com/title/tt0034583   movie  Casablanca  Casablanca  1942
imdb.com/title/tt10497826  movie  Kasablanka  Casablanca  2019

Expected behavior
These are the shows I found:
imdb.com/title/tt0034583   movie  Casablanca  Casablanca  1942

Additional context
You want to find a match on either field 3 or 4 so that either
./findCastOf.sh Acquitted
or
./findCastOf.sh Frikjent
result in
These are the shows I found:
imdb.com/title/tt3582458  tvSeries  Acquitted  Frikjent  2015

There are actually two shows found.  Kasablanka and Casablanca. The difference with Acquitted and Frikjent is that they both have the same tconst, so they don't resolve as two.
It doesn't seem possible to automatically resolve this. Best I can do is report the extra match and allow the user to remove the one they don't want.


API ListActionTasks is not sorted chronologically

Description
These are currently randomly sorted. Can they be updated to be sorted in reverse chronological order, i.e. the same as the Web UI?
https://github.com/go-gitea/gitea/blob/ec771fdfcdbc74320b1ef0252444aa5cddd50a04/routers/api/v1/repo/action.go#L562-L565
Gitea Version
1.22.0+rc1-106-gedbf74c418
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
Via the helm chart
Database
None

It's sorted by created time. I don't think it's a bug maybe an enhancement is better.

Hi Lunny, I’m not seeing it being sorted that way when I call the API, and
if you look at the source code I linked to you see there is no order clause
given to the FindAndCount method
On Fri, 24 May 2024 at 1:02 PM, Lunny Xiao @.***> wrote:

It's sorted by created time. I don't think it's a bug maybe an enhancement
is better.
—
Reply to this email directly, view it on GitHub
https://github.com/go-gitea/gitea/issues/31066#issuecomment-2128425381,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADSZ4R25KN2O5NPN5E6PVTZD2UVVAVCNFSM6AAAAABIGXMI76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRYGQZDKMZYGE
.
You are receiving this because you authored the thread.Message ID:
@.***>

Yes, there is no explicit order clause in FindAndCount. So the database should have a default one. Commonly it should be the id asc which is the same order as the created.

I’m not sure what the confusion is here but you’re saying that the endpoint
is sorted and I’m telling you it’s not
On Fri, 24 May 2024 at 2:02 PM, Lunny Xiao @.***> wrote:

Yes, there is no explicit order clause in FindAndCount. So the database
should have a default one. Commonly it should be the id asc which is the
same order as the created.
—
Reply to this email directly, view it on GitHub
https://github.com/go-gitea/gitea/issues/31066#issuecomment-2128481259,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADSZ4TKWZRBFWVJIKESHQ3ZD23WXAVCNFSM6AAAAABIGXMI76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRYGQ4DCMRVHE
.
You are receiving this because you authored the thread.Message ID:
@.***>

the web runtime correctly does a FindAndCount with ordering declared:
https://github.com/go-gitea/gitea/blob/ec771fdfcdbc74320b1ef0252444aa5cddd50a04/routers/web/shared/actions/runners.go#L77-L85
the API runtime does not:
https://github.com/go-gitea/gitea/blob/ec771fdfcdbc74320b1ef0252444aa5cddd50a04/routers/api/v1/repo/action.go#L562-L565

following up on request from @lunny in discord

Could you give some proposals which order options should the API provide

I propose that the API should return the workflow_runs in the same order that the web runtime currently sorts the list, ie. add IDOrderDesc: true
@chesteripz @wolfogre do you have any thoughts?

you’re saying that the endpoint is sorted and I’m telling you it’s not

In the absence of an explicit ORDER BY clause, different databases may return query results in varying orders due to their unique underlying implementations and optimizations.
So I believe @mattfysh did meet a "random" order result via API.

I propose that the API should return the workflow_runs in the same order that the web runtime currently sorts the list

It makes sense. I think we can just drop the option IDOrderDesc, since it will be useless if it always true, and it is what FindRunOptions and FindScheduleOptions do.
So #31150


dockerclient: implement --chown for ADD/COPY

Fixes #187.

/retitle dockerclient: implement --chown for ADD/COPY

LGTM
@umohnani8 @TomSweeneyRedHat PTAL

LGTM
It took me a hot minute to figure out what was going on in the conformance test, that's pretty nifty.

Eek, that last line in the Dockerfile isn't relevant, and it's just dumb luck that the util-linux package provided a /usr/bin/script that kept the test from failing to build.


Output incorrectly aligned

I've been using scip to establish that everything works with my 'RPi serial output to USB cable' setup.  Having configured both my Pi3 and my Pi4 to display messages on boot, I've run each multiple times and the output is great.  I love the way that everything appears to be exactly the same as on the Pi's monitor, even down to the colour-coding of the green OK message and the red 'busy' characters you see.  Nice job!
I've been using the command line:
scip /dev/ttyUSB0 115200

and comparing it with:
sudo python3 -m serial.tools.miniterm /dev/ttyUSB0 115200

For the RaspberryPi boot messages, scip is much better to look at.
So, then I moved to rust-raspberrypi-OS-tutorials/05_drivers_gpio_uart
When I use Python's miniterm with:
sudo python3 -m serial.tools.miniterm /dev/ttyUSB0 921600

I get
--- Miniterm on /dev/ttyUSB0  921600,8,N,1 ---
--- Quit: Ctrl+] | Menu: Ctrl+T | Help: Ctrl+T followed by Ctrl+H ---
[0] mingo version 0.5.0
[1] Booting on: Raspberry Pi 3
[2] Drivers loaded:
	  1. BCM PL011 UART
	  2. BCM GPIO
[3] Chars written: 117
[4] Echoing input now

When I use scip with:
scip /dev/ttyUSB0 921600

I get:
Welcome to scip.
To exit type <Enter> + ~ + .
or unplug the serial port.
[0] mingo version 0.5.0
					   [1] Booting on: Raspberry Pi 3
													 [2] Drivers loaded:
																			  1. BCM PL011 UART
					 2. BCM GPIO
								[3] Chars written: 117
													  [4] Echoing input now

Am I missing a parameter?

That's a bug in mingo (the Pi tutorial OS). It should be sending \r\n as a line ending on serial ports: this corresponds to "carriage return" (go to the beginning of the line) followed by "line feed" (go down to the next line). It instead just sends \n, leading to this behavior. There's a kludge in the miniterm provided with the tutorial to handle this, but the right way is to just fix the OS.
It's pretty easy to fix it yourself if you dig around in the mingo code. Otherwise, please be patient and we'll get the new setup with some fixes up as soon as we can find time.

I'm going to close this as not scip's bug, but do please file a bug against https://github.com/rust-embedded/rust-raspberrypi-OS-tutorials.


Provide an option to make the gap between side-by-side editors smaller

Type: Feature Request
When I enter side-by-side editing with multiple tabs, I tend to stack around 2-4 at a time. There is always a big gap between them and I was wondering if that gap could be made smaller through settings.

VS Code version: Code - Insiders 1.70.0-insider (13ba7bb446a638d37ebccb1a7d74e31c32bb9790, 2022-07-22T05:30:08.726Z)
OS version: Darwin arm64 21.5.0
Modes:

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


add HN sections

Adding HN sections (i.e past, show, ask) would be convenient to browse the website with ease. To me, it's the last feature that this project lacks before it becomes the best HN front-end.

I've been thinking about adding Show for a while, might as well add the rest.
I'll open up a PR in a day or two!
Glad you're liking the app!

Hey, hope you're doing well.
Just a little bump since it's been more than a month and you still haven't open a PR.

Hey! I've been swamped with work and a different project I've been working on so couldn't push it out. I have a working branch for this up, just requires a few design tweaks before I release it. Most likely by the weekend!

Added in #27


Missing cert mountpoint with Citadel, SDS and Vault CA

(NOTE: This is used to report product bugs:
To report a security vulnerability, please visit https://istio.io/about/security-vulnerabilities/
To ask questions about how to use Istio, please visit https://discuss.istio.io
)
Bug description
I've deployed K8S 1.13 in EKS along with Istio 1.2.4 using Hashicorp Vault 1.0.0 to issue certificates however after following all of the mTLS and Vault documentation the istio-proxy sidecars for the sample bookinfo and httpbin deployments do not get certificates.  Vault is setup correctly.

2019-08-22T01:24:47.889739Z	info	Monitored certs: []string{"/etc/certs/cert-chain.pem", "/etc/certs/key.pem", "/etc/certs/root-cert.pem"}
2019-08-22T01:24:47.889781Z	info	PilotSAN []string(nil)
2019-08-22T01:24:47.891394Z	info	Opening status port 15020
2019-08-22T01:24:47.891656Z	info	Starting proxy agent
2019-08-22T01:24:47.891817Z	warn	watching /etc/certs encountered an error no such file or directory
2019-08-22T01:24:47.891826Z	info	Received new config, resetting budget

On the node agent:

2019-08-22T00:56:39.154111Z	info	created Vault client for Vault address: http://xxxxx:8200, TLS: true
2019-08-22T00:56:39.284102Z	info	SDS gRPC server for workload UDS starts, listening on "/var/run/sds/uds_path"
2019-08-22T00:56:39.284187Z	info	Start SDS grpc server
2019-08-22T00:56:59.975030Z	info	Root cert has changed

Also logs from httpbin istio-proxy sidecar:

2019-08-22T19:57:16.388206Z	info	Monitored certs: []string{"/etc/certs/cert-chain.pem", "/etc/certs/key.pem", "/etc/certs/root-cert.pem"}
2019-08-22T19:57:16.388217Z	info	PilotSAN []string(nil)
2019-08-22T19:57:16.388282Z	info	Opening status port 15020
2019-08-22T19:57:16.388319Z	info	Starting proxy agent
2019-08-22T19:57:16.388414Z	warn	watching /etc/certs encountered an error no such file or directory
2019-08-22T19:57:16.388421Z	info	Received new config, resetting budget

Affected product area (please put an X in all that apply)
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[x ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Expected behavior
I would expect the normal behavior as per the documentation.  Certificates should be issued from Vault CA and provisioned to envoy sidecars.
Steps to reproduce the bug
Version (include the output of istioctl version --remote and kubectl version)
istioctl version --remote

client version: 1.2.4
citadel version: 1.2.4
egressgateway version: 94746ccd404a8e056483dd02e4e478097b950da6-dirty
galley version: 1.2.4
ingressgateway version: 94746ccd404a8e056483dd02e4e478097b950da6-dirty
nodeagent version:
nodeagent version:
pilot version: 1.2.4
policy version: 1.2.4
sidecar-injector version: 1.2.4
telemetry version: 1.2.4
kubectl version

Client Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.3", GitCommit:"2d3c76f9091b6bec110a5e63777c332469e0cba2", GitTreeState:"clean", BuildDate:"2019-08-19T11:13:54Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"13+", GitVersion:"v1.13.8-eks-a977ba", GitCommit:"a977bab148535ec195f12edc8720913c7b943f9c", GitTreeState:"clean", BuildDate:"2019-07-29T20:47:04Z", GoVersion:"go1.11.5", Compiler:"gc", Platform:"linux/amd64"}

How was Istio installed?
Followed this doc: https://istio.io/docs/tasks/security/vault-ca/
Environment where bug was observed (cloud vendor, OS, etc)
EKS in AWS
Additionally, please consider attaching a cluster state archive by attaching
the dump file to this issue.

@lei-tang

Can you set the logging level to be debug (or trace) on Node Agent and Istio Proxy and share the logs?

have the same problem with vault 1.2.2 istio 1.2.7 kubernetes 1.13
logs for sidecar:
2019-11-01T08:09:26.640436Z     info    Monitored certs: []string{"/etc/certs/root-cert.pem", "/etc/certs/cert-chain.pem", "/etc/certs/key.pem"}
2019-11-01T08:09:26.640450Z     info    PilotSAN []string(nil)
2019-11-01T08:09:26.640590Z     info    Starting proxy agent
2019-11-01T08:09:26.640592Z     info    Opening status port 15020

2019-11-01T08:09:26.640839Z     warn    watching /etc/certs encountered an error no such file or directory
2019-11-01T08:09:26.640850Z     info    Received new config, resetting budget
2019-11-01T08:09:26.640854Z     info    Reconciling retry (budget 10)
2019-11-01T08:09:26.640861Z     info    Epoch 0 starting
2019-11-01T08:09:26.680717Z     info    Envoy command: [-c /etc/istio/proxy/envoy-rev0.json --restart-epoch 0 --drain-time-s 45 --parent-shutdown-time-s 60 --service-cluster frontend.default --service-node sidecar~<IP_ADDRESS>~frontend-v1-64f5df57b7-nxzb8.default~default.svc.cluster.local --max-obj-name-len 189 --local-address-ip-version v4 --allow-unknown-fields -l warning --component-log-level misc:error --concurrency 2]
[2019-11-01 08:09:26.702][17][warning][config] [bazel-out/k8-opt/bin/external/envoy/source/common/config/_virtual_includes/grpc_stream_lib/common/config/grpc_stream.h:86] gRPC config stream closed: 14, no healthy upstream
[2019-11-01 08:09:26.702][17][warning][config] [bazel-out/k8-opt/bin/external/envoy/source/common/config/_virtual_includes/grpc_stream_lib/common/config/grpc_stream.h:49] Unable to establish new stream
2019-11-01T08:09:27.786552Z     info    Envoy proxy is ready
[2019-11-01T08:11:12.481Z] "GET / HTTP/1.1" 503 UF,URX "-" "TLS error: 268435581:SSL routines:OPENSSL_internal:CERTIFICATE_VERIFY_FAILED" 0 91 54 - "-" "curl/7.64.0" "ebf2c9b9-7774-41fa-9523-b32f0598ab23" "backend" "<IP_ADDRESS>:80" outbound|80||backend.default.svc.cluster.local - <IP_ADDRESS>:80 <IP_ADDRESS>:38780 -

strace log of sidecar when runing curl command form my pod1 to svc2
default_words: "backend.default.svc.cluster.local"
default_words: "Fri, 01 Nov 2019 09:14:28 GMT"
default_words: "91"
default_words: "origin.ip"
default_words: "kubernetes://frontend-v1-64f5df57b7-nxzb8.default"
default_words: "istio://default/services/backend"
default_words: "UF,URX"
default_words: "/"
default_words: "4a90eec06a1c5392"
default_words: "curl/7.64.0"
default_words: "d221499db9266da54a90eec06a1c5392"
default_words: "backend"
default_words: "dafab4c5-9e18-40b8-a9ff-2e56c9ed1f9f"
default_words: "backend.default.svc.cluster.local:80/*"
default_words: "x-envoy-decorator-operation"
default_words: "*/*"
default_words: "kubernetes://backend-v1-67998dbc89-zfqpv.default"
global_word_count: 221
repeated_attributes_semantics: INDEPENDENT_ENCODING

[2019-11-01 09:14:29.546][42][trace][connection] [external/envoy/source/common/network/connection_impl.cc:458] [C29] socket event: 2
[2019-11-01 09:14:29.546][42][trace][connection] [external/envoy/source/common/network/connection_impl.cc:543] [C29] write ready
[2019-11-01 09:14:29.546][42][debug][connection] [external/envoy/source/common/network/connection_impl.cc:552] [C29] connected
[2019-11-01 09:14:29.546][42][debug][client] [external/envoy/source/common/http/codec_client.cc:64] [C29] connected
[2019-11-01 09:14:29.546][42][debug][pool] [external/envoy/source/common/http/http2/conn_pool.cc:96] [C29] creating stream
[2019-11-01 09:14:29.546][42][debug][router] [external/envoy/source/common/router/router.cc:1219] [C0][S15513228436385723905] pool ready
[2019-11-01 09:14:29.546][42][trace][http2] [external/envoy/source/common/http/http2/codec_impl.cc:667] [C29] send data: bytes=24
[2019-11-01 09:14:29.546][42][trace][connection] [external/envoy/source/common/network/connection_impl.cc:394] [C29] writing 24 bytes, end_stream false
[2019-11-01 09:14:29.546][42][trace][http2] [external/envoy/source/common/http/http2/codec_impl.cc:613] [C29] about to send frame type=4, flags=0
[2019-11-01 09:14:29.546][42][trace][http2] [external/envoy/source/common/http/http2/codec_impl.cc:667] [C29] send data: bytes=27
[2019-11-01 09:14:29.546][42][trace][connection] [external/envoy/source/common/network/connection_impl.cc:394] [C29] writing 27 bytes, end_stream false
[2019-11-01 09:14:29.546][42][trace][http2] [external/envoy/source/common/http/http2/codec_impl.cc:555] [C29] sent frame type=4
[2019-11-01 09:14:29.546][42][trace][http2] [external/envoy/source/common/http/http2/codec_impl.cc:613] [C29] about to send frame type=8, flags=0
[2019-11-01 09:14:29.546][42][trace][http2] [external/envoy/source/common/http/http2/codec_impl.cc:667] [C29] send data: bytes=13
[2019-11-01 09:14:29.546][42][trace][connection] [external/envoy/source/common/network/connection_impl.cc:394] [C29] writing 13 bytes, end_stream false
[2019-11-01 09:14:29.546][42][trace][http2] [external/envoy/source/common/http/http2/codec_impl.cc:555] [C29] sent frame type=8
[2019-11-01 09:14:29.546][42][trace][http2] [external/envoy/source/common/http/http2/codec_impl.cc:613] [C29] about to send frame type=1, flags=4
[2019-11-01 09:14:29.547][42][trace][http2] [external/envoy/source/common/http/http2/codec_impl.cc:667] [C29] send data: bytes=241
[2019-11-01 09:14:29.547][42][trace][connection] [external/envoy/source/common/network/connection_impl.cc:394] [C29] writing 241 bytes, end_stream false
[2019-11-01 09:14:29.547][42][trace][http2] [external/envoy/source/common/http/http2/codec_impl.cc:555] [C29] sent frame type=1
[2019-11-01 09:14:29.547][42][trace][connection] [external/envoy/source/common/network/connection_impl.cc:394] [C29] writing 797 bytes, end_stream false
[2019-11-01 09:14:29.547][42][trace][http2] [external/envoy/source/common/http/http2/codec_impl.cc:555] [C29] sent frame type=0
[2019-11-01 09:14:29.547][42][trace][connection] [external/envoy/source/common/network/connection_impl.cc:543] [C29] write ready
[2019-11-01 09:14:29.547][42][trace][connection] [external/envoy/source/common/network/raw_buffer_socket.cc:66] [C29] write returns: 1102
[2019-11-01 09:14:29.547][42][trace][connection] [external/envoy/source/common/network/connection_impl.cc:458] [C29] socket event: 2
[2019-11-01 09:14:29.547][42][trace][connection] [external/envoy/source/common/network/connection_impl.cc:543] [C29] write ready
[2019-11-01 09:14:29.548][42][trace][connection] [external/envoy/source/common/network/connection_impl.cc:458] [C29] socket event: 3
[2019-11-01 09:14:29.548][42][trace][connection] [external/envoy/source/common/network/connection_impl.cc:543] [C29] write ready
[2019-11-01 09:14:29.548][42][trace][connection] [external/envoy/source/common/network/connection_impl.cc:496] [C29] read ready
[2019-11-01 09:14:29.548][42][trace][connection] [external/envoy/source/common/network/raw_buffer_socket.cc:23] [C29] read returns: 43
[2019-11-01 09:14:29.548][42][trace][connection] [external/envoy/source/common/network/raw_buffer_socket.cc:37] [C29] read error: Resource temporarily unavailable
[2019-11-01 09:14:29.548][42][trace][http2] [external/envoy/source/common/http/http2/codec_impl.cc:352] [C29] dispatching 43 bytes
[2019-11-01 09:14:29.548][42][trace][http2] [external/envoy/source/common/http/http2/codec_impl.cc:415] [C29] about to recv frame type=4, flags=0
[2019-11-01 09:14:29.548][42][trace][http2] [external/envoy/source/common/http/http2/codec_impl.cc:430] [C29] recv frame type=4
[2019-11-01 09:14:29.548][42][trace][http2] [external/envoy/source/common/http/http2/codec_impl.cc:415] [C29] about to recv frame type=4, flags=1
[2019-11-01 09:14:29.548][42][trace][http2] [external/envoy/source/common/http/http2/codec_impl.cc:430] [C29] recv frame type=4
[2019-11-01 09:14:29.548][42][trace][http2] [external/envoy/source/common/http/http2/codec_impl.cc:415] [C29] about to recv frame type=8, flags=0
[2019-11-01 09:14:29.548][42][trace][http2] [external/envoy/source/common/http/http2/codec_impl.cc:430] [C29] recv frame type=8
[2019-11-01 09:14:29.548][42][trace][http2] [external/envoy/source/common/http/http2/codec_impl.cc:371] [C29] dispatched 43 bytes
[2019-11-01 09:14:29.548][42][trace][http2] [external/envoy/source/common/http/http2/codec_impl.cc:613] [C29] about to send frame type=4, flags=1
[2019-11-01 09:14:29.548][42][trace][http2] [external/envoy/source/common/http/http2/codec_impl.cc:667] [C29] send data: bytes=9
[2019-11-01 09:14:29.548][42][trace][connection] [external/envoy/source/common/network/connection_impl.cc:394] [C29] writing 9 bytes, end_stream false
[2019-11-01 09:14:29.548][42][trace][http2] [external/envoy/source/common/http/http2/codec_impl.cc:555] [C29] sent frame type=4
[2019-11-01 09:14:29.548][42][trace][connection] [external/envoy/source/common/network/connection_impl.cc:458] [C29] socket event: 2
[2019-11-01 09:14:29.548][42][trace][connection] [external/envoy/source/common/network/connection_impl.cc:543] [C29] write ready
[2019-11-01 09:14:29.548][42][trace][connection] [external/envoy/source/common/network/raw_buffer_socket.cc:66] [C29] write returns: 9
[2019-11-01 09:14:29.552][42][trace][connection] [external/envoy/source/common/network/connection_impl.cc:458] [C29] socket event: 3
[2019-11-01 09:14:29.552][42][trace][connection] [external/envoy/source/common/network/connection_impl.cc:543] [C29] write ready
[2019-11-01 09:14:29.552][42][trace][connection] [external/envoy/source/common/network/connection_impl.cc:496] [C29] read ready
[2019-11-01 09:14:29.552][42][trace][connection] [external/envoy/source/common/network/raw_buffer_socket.cc:23] [C29] read returns: 125
[2019-11-01 09:14:29.552][42][trace][connection] [external/envoy/source/common/network/raw_buffer_socket.cc:37] [C29] read error: Resource temporarily unavailable

@gudeyang1 From the logs you posted, I did not see any errors related to certificate provisioning but your log shows a certificate verification failure as follows. You may want to dump the certificate chains and the CA bundles of the source Envoy and the destination Envoy to check whether the certificate chains of the source Envoy and the destination Envoy can be validated through their CA bundles.
[2019-11-01T08:11:12.481Z] "GET / HTTP/1.1" 503 UF,URX "-" "TLS error: 268435581:SSL routines:OPENSSL_internal:CERTIFICATE_VERIFY_FAILED" 0 91 54 - "-" "curl/7.64.0" "ebf2c9b9-7774-41fa-9523-b32f0598ab23" "backend" "<IP_ADDRESS>:80" outbound|80||backend.default.svc.cluster.local - <IP_ADDRESS>:80 <IP_ADDRESS>:38780 -

Can  you show me the way  how to dump
 certs from Enovy,i'm new  to Istio  do  i  need  to modify the code  of Envoy for debugging?thansks
发自我的iPhone
------------------ Original ------------------
From: lei-tang<EMAIL_ADDRESS>Date: Sat,Nov 2,2019 1:24 AM
To: istio/istio<EMAIL_ADDRESS>Cc: gudeyang1<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [istio/istio] Missing cert mountpoint with Citadel, SDS and Vault CA (#16486)
@gudeyang1 From the logs you posted, I did not see any errors related to certificate provisioning but your log shows a certificate verification failure as follows. You may want to dump the certificate chains and the CA bundles of the source Envoy and the destination Envoy to check whether the certificate chains of the source Envoy and the destination Envoy can be validated through their CA bundles.
[2019-11-01T08:11:12.481Z] "GET / HTTP/1.1" 503 UF,URX "-" "TLS error: 268435581:SSL routines:OPENSSL_internal:CERTIFICATE_VERIFY_FAILED" 0 91 54 - "-" "curl/7.64.0" "ebf2c9b9-7774-41fa-9523-b32f0598ab23" "backend" "<IP_ADDRESS>:80" outbound|80||backend.default.svc.cluster.local - <IP_ADDRESS>:80 <IP_ADDRESS>:38780 -
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

and also, if enable SDS , is secret generated by Istio  like istio.io/key-and-cert will be useless?  sidecar doesn't mount the secret in pod at /etc/certs

When SDS is enabled, the workload certificates are not read from k8s secrets like "istio.io/key-and-cert".
The SDS code of Envoy is at: https://github.com/envoyproxy/envoy/tree/master/source/common/secret.


it does not download

it does not download on windows...and even if it does sometimes it hides the downloaded content...but other than that it's perfect you my great sir out done yourself i'll make sure to get you a cup of coffee

This is still a WIP project, I'm aware that sometimes there could be some issue, I'm actively working and them.
Thanks for you feedback!

Should be fixed in the latest versions, there was a bug in the youtube_explode_dart api, but now should be fixed


Improve CollisionObject/CollisionObject2D warning message

Clarified wording - message was somewhat misleading and unclear.
Fixed it's -> its

Could now be amended to remove the already merged s/it's/its/ fix.

Could now be amended to remove the already merged s/it's/its/ fix.

Bump :)

Merged manually as a5688ccd9.


Explore static library support (for e.g. iOS)

This isn't terribly useful right now, but will become useful once the .NET SDK gains full support for Apple platforms like iOS and watchOS that only support static linking.
This will require significant work in Zig, especially for cross-compilation.
See: https://github.com/ziglang/zig/issues/5145

As far as how this should work from the user perspective, I think there should just be an MSBuild property that informs the SDK which kind of library to build. NativeAOT has already introduced the NativeLib property for this; the name is a bit unfortunate, but there is probably value in standardizing on it. It accepts Shared (default) and Static. We might extend it to also accept Both.

This is complicated somewhat by needing to invoke zig ar/zig lib to actually create the static library for C/C++ projects.


Increase max-age for HSTS to recommended default

HSTS is now supported by all the major browsers
http://caniuse.com/#search=Strict Transport Security

Hi,
15768000 = 6 months; which is recommended as part of the Mozilla Security standards / generator https://mozilla.github.io/server-side-tls/ssl-config-generator/ , https://wiki.mozilla.org/Security/Server_Side_TLS#HSTS:_HTTP_Strict_Transport_Security
I
There's not really much to lose or gain increasing to 12 months; but I'll accept that the section on HSTS needs expanding to include a mention of preload + include subdomains. Subdomains was left out intentionally as at the time it was common for people to use "azure cloud services" which had a default azure domain but didn't support ssl. Setting subdomains would break all the other sites living under the main domain.
I won't merge this as I'll have to apply the change across all of the other files but i'll leave it open as a ref


fix(compiler): do not prioritize using local functions over functions called through module qualifiers

This is seemingly solving the issue because when the ocaml name is qualified, the erlang name also will be. I would need to understand the Texp_ident contents to see what to check in the typedtree before even translating the name to erlang instead to fix properly, but I was having a hard time debugging ocaml code.
Relates to #58

@ostera I looked at this again and am I not sure if I can come up with anything better here. This seems to be solving this particualr issue though, so marking as ready for review :)


terminal vim support

Hey @Wutzara do you plan on adding support for terminal vim? (iTerm)
The theme is beautiful!

Sorry i dont think i will add support for terminal vim. I just use neovim with true color support as my terminal vim which allows me to use the theme in terminal too.


modulepath argument in bolt.yaml for multi-platform host

This request refers to running a bolt command on a Linux/Mac host laptop versus a Windows 10 host machine.
bolt.yaml Doc page: https://puppet.com/docs/bolt/latest/bolt_configuration_options.html#sample-bolt-configuration-file
We need to document the following about the modulepath argument in bolt.yaml:
modulepath: "./modules":"./site-modules" # the ':' (colon) separator works only on Linux/Mac host machine
modulepath: "./modules";"./site-modules" # the ':' (semi-colon) separator works only on Windows 10 host machine
modulepath: ["./modules","./site-modules"] # the array syntax '[]' and ',' (comma) separator works on both Linux/Mac & Windows 10 host machine

We should always show the array in examples and mention the string format only in describing why it's limiting.

Closed by #1885


issue in pause

as you can see I can't pause sometime. then I deleted the download with X icon then start again downloading and there is a problem. when the first time there is a problem.
it's iPhone 8 real device.
isolated_download_manager_flutter: ^1.0.3
 isolated_download_manager: ^1.0.3

data in static Map<String, String> links
    "ali imran":
        "https://download.quranicaudio.com/quran/abdullaah_3awwaad_al-juhaynee//003.mp3",

[✓] Flutter (Channel stable, 3.7.12, on macOS 13.3.1 22E772610a darwin-x64, locale en-TR)
    • Flutter version 3.7.12 on channel stable at /Users/mirzali/fvm/versions/3.7.12
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 4d9e56e694 (8 weeks ago), 2023-04-17 21:47:46 -0400
    • Engine revision 1a65d409c7
    • Dart version 2.19.6
    • DevTools version 2.20.1

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.12.0

[✓] VS Code (version 1.79.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.66.0

[✓] HTTP Host Availability
    • All required HTTP hosts are available

https://github.com/starkdmi/download_manager/assets/49102327/60d56084-2624-46a3-9e04-0e026280f876

@Shahmirzali-Huseynov, thank you for all the info, can confirm the issue on my environment, seems like a race condition in DownloadManager when fastly sending pause/resume commands.

@starkdmi Actually, I remember one time it happens when I do normally not like the video 😅(I did it just for catching the issue fastly).

Even at normal speed there is a time required to start/resume the downloading (like 1 to 5 sec - server processing and response). I will address the issue soon 👌

Great 👍


Not seeing health bar or selection circle

I am having an issue where I do not see either health bars or selection circles for my units. I have been referencing both documentation and the example project. The example works fine but my own project does not, I see a health bar for a brief moment on launch and then never again, the selection circle never appears. I am not sure if maybe I missed something but I have cross referenced and theoretically have the exact same setup as the example. The example project is working as expected, I can only assume maybe there is an extra step that isn't in the documentation.
This is in the same version of UE5 (p2) for both my project and the example.

Does your selection circle have a material set?
There is a shipped Circle found in the plugin content. Also make sure, that you have selected the correct player controller which is in charge for the selection.
Also your Inputs could be a problem. Check, if you have copied the inputs from the demo project

I had a material set and everything.
I did eventually figure it out. The draw size of the circle is based on the collision component of the units. Basically after lots of testing, you need to put capsule collision on the unit, which will determine circle size. This cannot be anything other than capsule from the looks of it.

Good to know

Also the Decal only projects on other actors. So if your actor is not on the ground, then you can't see the decal


Don't store the first X characters of a post as bookmark.Title

When not explicitly setting the title of a bookmark, do not set the Title field in the store.  Leave this Title field empty and instead grab the post.Message when filtering and printing bookmarks.

allows MaxTitleCharacters = 30 to be set in config and varied at runtime

commited https://github.com/jfrerich/mattermost-plugin-bookmarks/commit/24e99f54fe9a25dbe23cdfdc7ddcb747e9d1a89b


removal of leading white-space in top-of-file comment

using ruff vscode plugin,  default configuration but with:
[tool.ruff]
line-length = 160
indent-width = 4

Before code format:
#!/usr/bin/env python3
"""Returns with exitcode 1 if /....., otherwise 0 (success)
    description bla bla description
    description bla bla description
"""

after code format:
#!/usr/bin/env python3
"""Returns with exitcode 1 if /....., otherwise 0 (success)
description bla bla description
description bla bla description
"""

All leading whitespace in comments up top seems to be removed, however, in raw-strings that are assigned to a variable, this does not happen.

I believe this is by design. The formatter normalizes docstrings, and a string expression at the top of a file is a docstring.

The docstring can change the behaviour of the program, such as with docopt, so I think there should at least be a way to disable this ?

This looks like a duplicate of #10396
You can disable this with # fmt: skip as discussed there.

You are correct, this is a duplicate, I did not find it because I did not look for 'docstring' as a keyword, silly me, thank you for pointing that out.
However, I think it is not a reasonable solution to annotate all python files with tool-specific annotations, I see there is an issue #4276 for this on the Black repo. They are also of the opinion that modifying user data is allowed by a code formatter.
I'm not sure I follow this logic, any change that have a runtime effect is a bug to me. I will go back to autopep8, feel free to close this issue.


possible issue in the relative step error computations in case of variable step-size integrators

I am not 100% on this because you are using slightly different step size computation formulae. In step computation routine for each integrator (variable-step), you compute the step errors as this
xerr = sum (h*e(i)*F(i))
Then in step size computation routine (rklib_module.F90) , the max_err is computed like this
max_err = abs(xerr*h/tol)
So you are saying that step error for your integrators is O(h^2) and not O(h). Is that correct? Since you have included so many different algorithms so it may be you are using a different step size formulae than what is more typically used (esp. with DOP54 and DOP853). In case your formula is correct then you can close this issue.

I need to look and see what I did... my idea was you could have different step size selection logic depending on the options you set.

Yes you can. I just wanted to confirm that this is a correct local error computation formula that uses the second power of h and not first. Did you find this formula in some paper?


OpenQASM Technical Steering Committee solicitation of Candidates

What is the expected behavior?

Candidates for the 3 OpenQASM Technical Steering Committee seats open in the December 2024 - January 2025 election should post here indicating their interest.
Candidates should already be contributors to OpenQASM in this repository with accepted PRs, but may make contributions before election period.
If you wish to be a candidate for a seat on the OpenQASM Technical Steering Committee, please read carefully the Governance Document to determine your interest and eligibility.
Statements of Intent like these will be solicited from eligible aspirants.

The 3 candidates are the incumbents

Serwan Asaad
Lev Bishop
Blake Johnson

Please post candidate statements below.

The OpenQASM TSC having heard no nominations is about to proceed to elect 3 members from a slate consisting of the 3 incumbents whose seats are up for election and who have indicated their willingness to continue their TSC membership.
Candidates, please post your election statements in this issue!
Anyone who has successfully contributed a PR to the openqasm/openqasm repository is an elector. If any elector has not this year received email invitations to the OpenQASM TSC online meetings, that means the Secretary does not have your email address! Please email<EMAIL_ADDRESS>if you are an elector and believe we don't have you on the email list for the election!

My election statement:
I am pleased to run for another 2 year term on the OpenQASM TSC. I am a Distinguished Engineer at IBM Quantum, with responsibilities in our low-level software stack and with building infrastructure for quantum error correction. Since 2020, I have driven efforts to engage the quantum community in collaborative development of OpenQASM to ensure that it captures the needs of a broader set of stakeholders. These efforts included recruiting the initial Technical Steering Committee members and creating the governance rules.
In the next term, I look forward to exploring the interaction of OpenQASM with a new era in which many quantum hardware vendors are starting to offer error correction capabilities. I expect the "native" instruction sets of this new era of hardware to look quite different to the physical gate sets which are common today. We will need to examine OpenQASM's ability to represent these new instruction sets and evolve the language accordingly.

I'm waiting one more day to hear from "lost" electors and will bring up the online election tonight or tomorrow

The election is open.

@jwoehr This is my election statement:
I am pleased to express my willingness to continue my role as OpenQASM3 Technical Steering Committee member for another two-year term.
After Dor Israeli's departure, I assumed the role of TSC member for the remainder of his term. Participating in the decision-making process regarding the OpenQASM3 language has been an enlightening experience. The discussions topics have spanned a wide range, from straightforward decisions to highly controversial ones. However, all these discussions share a profound underlying purpose: defining and refining a quantum language that acts as a standard, one that can bridge the gap between high-level quantum applications and their execution on quantum hardware, ultimately pushing the field of quantum computing forward.
Looking ahead, there are several key topics in OpenQASM that I would like to explore further. One major topic is facilitating how OpenQASM3 can effectively interface with different control-hardware vendors, which would support its widespread adopting as the de facto standard. A second direction I would like to explore is how hybrid classical-quantum computing can be combined with OpenQASM3. I believe this is becoming increasingly important for quantum computing, and therefore OpenQASM3 needs a strategy for addressing these requirements. I am excited about the opportunity to continue contributing to the advancement of OpenQASM3, and I am committed to ensuring it meets the emerging challenges and requirements.


wrap React.PropsWithChildren

https://github.com/DefinitelyTyped/DefinitelyTyped/commit/55dc209ceb6dbcd59c4c68cc8dfb77faadd9de12
children is removed on React 18
Thanks for submitting a pull request!
Please confirm you have linted your code and fixed any issues:

[x] I ran yarn run fix on my PR and fixed any formatting issues

execute result. None were relevant to this fix.
% yarn run fix
yarn run v1.22.10
$ yarn run prettier && yarn run lint
$ prettier --write --loglevel=warn "**/*.js"
$ eslint . --ext .js

/path/to/react-native-swipe-list-view/SwipeListExample/example.js
  46:29  warning  Inline style: { backgroundColor: "mode === type ? 'grey' : 'white'" }  react-native/no-inline-styles

/path/to/react-native-swipe-list-view/SwipeListExample/examples/actions.js
   84:40  warning  Inline style: { backgroundColor: 'lightgreen' }  react-native/no-inline-styles
   91:44  warning  Inline style: { backgroundColor: 'lightgreen' }  react-native/no-inline-styles
  142:44  warning  Inline style: { backgroundColor: 'lightgreen' }  react-native/no-inline-styles
  159:29  warning  Inline style: { flex: 1 }                        react-native/no-inline-styles

/path/to/react-native-swipe-list-view/SwipeListExample/examples/per_row_config.js
  35:31  warning  Missing radix parameter  radix

/path/to/react-native-swipe-list-view/SwipeListExample/examples/sectionlist.js
  21:31  warning  '_' is already declared in the upper scope  no-shadow

/path/to/react-native-swipe-list-view/bin/dev.js
  42:44  warning  'err' is already declared in the upper scope  no-shadow

/path/to/react-native-swipe-list-view/components/SwipeRow.js
  634:28  warning  Inline style: { zIndex: 2 }  react-native/no-inline-styles
  648:28  warning  Inline style: { zIndex: 2 }  react-native/no-inline-styles

/path/to/react-native-swipe-list-view/types/flowtypes.js
  2:0  warning  Unexpected unlimited 'eslint-disable' comment. Specify some rule names to disable  eslint-comments/no-unlimited-disable
  2:1  warning  ESLint rules are disabled but never reported                                       eslint-comments/no-unused-disable

✖ 12 problems (0 errors, 12 warnings)

✨  Done in 4.68s.

Please provide information on what your PR achieves and any issues that it addresses:
https://github.com/DefinitelyTyped/DefinitelyTyped/commit/55dc209ceb6dbcd59c4c68cc8dfb77faadd9de12
children is removed on React 18. So I add.

Can this be merged please?

I need it too u.u

@jemise111 Would you review/merge/release this for us?

I was also expecting this PR to be merged.
You can fix it on your own using patch-package !
Steps are also really well described in this video.

I was also expecting this PR to be merged.
You can fix it on your own using patch-package ! Steps are also really well described in this video.

Thank you, I will try it while await for merge

I also need this fix


refactor imports for java 8

[Current coverage][cc-pull] is 44.05%

Merging [#27][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master        #27   diff @@
==========================================
  Files             6          6
  Lines           168        168
  Methods           0          0
  Messages          0          0
  Branches         22         22
==========================================
  Hits             74         74
  Misses           94         94
  Partials          0          0

Powered by Codecov. Last updated by [e1dd19e...e2a4628][cc-compare]
[cc-base-branch]: https://codecov.io/gh/SxMShaDoW/embeddable-badges-plugin/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/SxMShaDoW/embeddable-badges-plugin/compare/e1dd19e58c4808cdd27e088007f5dea26fe0d4a5...e2a4628dd559d480020037db496e982b35befa72
[cc-pull]: https://codecov.io/gh/SxMShaDoW/embeddable-badges-plugin/pull/27?src=pr


how much RIVE script is supported?

I understand this is based off a fork of RIVE script, but I'm wondering what features you support.
for example are variables supported?
https://github.com/dcsan/rivescript-js/blob/master/eg/brain/clients.rive
I tried this:
! var name = Suzie

+ hi *
- hi! my name is <bot name>

# output
You> hi

Bot> hi! my name is <bot name>

I don't know rivescript but it would help before i debug to know if this is expected.
I did look in the fixtures but couldn't see any examples of variables.
also this syntax for "learning things"
http://www.rivescript.com/docs/Tutorial.html#learning_things
update: as in #19  it seems there are some syntax differences, so maybe i just need to know what those are.
also if there were any example .ss files that would greatly help to see what can be done!
RIVEscript refs

https://www.kirsle.net/rivescript
JS port https://github.com/kirsle/rivescript-js
JS 'brain' examples: https://github.com/kirsle/rivescript-js/tree/master/eg/brain
Rivescript tutorial: http://www.rivescript.com/docs/Tutorial.html#name
RIVE vs AIML http://www.rivescript.com/aiml
RIVE test suite https://github.com/kirsle/rivescript-js/blob/master/eg/testsuite.rive

quick follow up - so you're using the Rivescript code as is, so pretty much all the stuff listed here should work, at a minimum?
http://www.rivescript.com/docs/tutorial
or did you rewrite big chunks? I'm just wondering if I should get hacking with Rivescript while some of the bugs in the topics etc are worked out.

It is completely re-written. Some of the ideas have been carried over. Read the docs on superscriptjs.com to get a better idea.


fix(tier4_dummy_object_rviz_plugin): fix missing dependency

Description
tier4_dummy_object_rviz_plugin uses Boost, but it hasn't been declared as a dependency in package.xml
Related links
Parent Issue:
https://github.com/autowarefoundation/autoware-deb-packages/actions/runs/11663346804/job/32471666820?pr=101

How was this PR tested?
Notes for reviewers
None.
Interface changes
None.

Effects on system behavior
None.

NOTE: It's used in this line for example: https://github.com/autowarefoundation/autoware.universe/blob/3a92654309cc68cddd3b5c686352af522b1d4fc7/simulator/tier4_dummy_object_rviz_plugin/src/tools/interactive_object.hpp#L67


Add #[allow(missing_docs)] to the generated code

This enables users which don't have a separate module for errors (e.g. because they don't have that many) to use the macro in conjunction with #![deny(missing_docs)].

Well, it would be better to add documentation for the generated items ^^
Closing for https://github.com/brson/error-chain/issues/61


status of seabird(s) entangled

As a [researcher] I want [the app to offer the app-user the chance to log the status of the entangled seabird(s)]
_ allow multiple options to be selected for the one submission of entangled seabird(s): 'alive', 'injured' and 'dead'_

Entanglement not being treated separately from other observations.


Provide the option to get the username and used password in WithSubscriptionInterceptor() and WithApplicationMessageInterceptor().

This is needed for https://github.com/chkr1011/MQTTnet/issues/664 and https://github.com/chkr1011/MQTTnet/issues/668:

With one set of user and pass ANY client ID can be used.

Currently, these functions only return the client id. If my project (https://github.com/SeppPenner/NetCoreMQTTExampleJsonConfig) should use the username and password on subscription or publish, I don't know how to do this in another way. Any suggestions, @chkr1011?

Hi,
the problem is that this data is not correlated. So the data you need was only part of the initial CONNECT packet. So the requested data must be kept and forwarded to later subscription contexts.
As far as I can see this is no trivial change. I will try to find a solution.
Best regards
Christian

As far as I can see this is no trivial change. I will try to find a solution.

That's what I was afraid of :D

I think it should be easy let me have a look at it,

I exposed the complete connect packet that way a user can use the credentials, clientid, wether its a tls connection or some other information provided with the mqtt v5 user properties

I made this change in the newest commit on develop. I am not very happy with it because it seems to be a little bit hacky.

I changed this again and now it is perfect (in my humble opinion) 😄

Now there is a dictionary available in the session object. This works similar as in ASP.NET. This items dictionary is exposed in all interceptors and validators. So you can now "move" data from the initial connect like the username or password to that dictionary. When interception an application message etc. you can read your value from that dictionary and use it. This also allows much more things than exposing the username and password hard coded.
You can for example query access rights upon connect and store the access rights in the session items. When subscribing you only need to read that from the items instead of loading it from a slow source like a file, DB etc.
I also exposed that to MQTTnet.Server. So the session items are also exposed to Python Scripts and can be used the as well.

Now there is a dictionary available in the session object. This works similar as in ASP.NET. This items dictionary is exposed in all interceptors and validators. So you can now "move" data from the initial connect like the username or password to that dictionary. When interception an application message etc. you can read your value from that dictionary and use it. This also allows much more things than exposing the username and password hard coded.
You can for example query access rights upon connect and store the access rights in the session items. When subscribing you only need to read that from the items instead of loading it from a slow source like a file, DB etc.
I also exposed that to MQTTnet.Server. So the session items are also exposed to Python Scripts and can be used the as well.

I will try this and build it into the example projects.

I can confirm that this works as expected in the latest beta version.


Kalish/platform/hl7 diff prototype

This PR create a command line tool that will diff two HL7 messages and print the differences in the console.
Test Steps:

Pick any two files, note the changes, then run the following command and make sure it also finds those changes:
./prime hl7data -c file/path/number/1 -s /file/path/number/2

Changes
Added a command line tool that diffs 2 hl7 files.
Checklist
Testing

[x] Tested locally?
[ ] Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
[ ] (For Changes to /frontend-react/...) Ran npm run lint:write?
[ ] Added tests?

#10795

nice diff tool, did some QA on some edge cases:
t1.hl7:
MSH|^~&||Any facility USA^90D4900850^CLIA|<IP_ADDRESS>.1|<IP_ADDRESS>.1|20210623161533.2340-0400||ORU^R01^ORU_R01|911909|P|2.5.1|||NE|NE|USA|UNICODE UTF-8
SFT|Centers for Disease Control and Prevention|0.1-SNAPSHOT|PRIME ReportStream|0.1-SNAPSHOT||20210622
FTS|1
BTS|25
t2.hl7:
MSH|^~&||Any facility USA^90D4900850^CLIA|<IP_ADDRESS>.1|<IP_ADDRESS>.1|20210623161533.2340-0400||ORU^R01^ORU_R01|911909|P|2.5.1|||NE|NE|USA|UNICODE UTF-8
SFT|Centers for Disease Control and Prevention|0.1-SNAPSHOT|PRIME ReportStream|0.1-SNAPSHOT||20210622
FTS|1
BTS|25
BTS|25
BTS|25
note the 3 dup BTS at the tail, not sure if t1.hl7 and t2.hl7 are semantically equivalent, but at least they look different.

out of scope comment:
ever think of extend the diff tool into a lossless-ness checker, e.g. source message source,hl7 (HL7 v2) got translated into target.fhir (FHIR R5), and the tool should be able to check: all info in source HL7 message presents as element in target FHIR resource (json), HL7 segments are order sensitive, and the target FHIR resource should retain equivalent semantics of such order in the target FHIR resource.
Currently I guess it is a manual practice to exam that an HL7 message is faithfully converted to it's FHIR equivalent.

out of scope comment:
there are 3rd party open source diff tool, e.g. the one from HAPI FHIR:
https://hapifhir.github.io/hapi-hl7v2/hapi-testpanel/hl7v2filediff.html
not sure the quality of it though..., if it's time tested and have good review..., might want to wrap it as a gradle task

Tried it with slightly different docs and it does work. Feedback:

The paths need to be absolute, that should be stated somewhere
The instructions on how to use it, and explanation on the output should be in some doc

Tried it with slightly different docs and it does work. Feedback:

The paths need to be absolute, that should be stated somewhere
The instructions on how to use it, and explanation on the output should be in some doc

I will add both to the help text. Thank you for the feedback!

nice diff tool, did some QA on some edge cases:
t1.hl7:
MSH|^~&||Any facility USA^90D4900850^CLIA|<IP_ADDRESS>.1|<IP_ADDRESS>.1|20210623161533.2340-0400||ORU^R01^ORU_R01|911909|P|2.5.1|||NE|NE|USA|UNICODE UTF-8 SFT|Centers for Disease Control and Prevention|0.1-SNAPSHOT|PRIME ReportStream|0.1-SNAPSHOT||20210622 FTS|1 BTS|25
t2.hl7:
MSH|^~&||Any facility USA^90D4900850^CLIA|<IP_ADDRESS>.1|<IP_ADDRESS>.1|20210623161533.2340-0400||ORU^R01^ORU_R01|911909|P|2.5.1|||NE|NE|USA|UNICODE UTF-8 SFT|Centers for Disease Control and Prevention|0.1-SNAPSHOT|PRIME ReportStream|0.1-SNAPSHOT||20210622 FTS|1 BTS|25 BTS|25 BTS|25
note the 3 dup BTS at the tail, not sure if t1.hl7 and t2.hl7 are semantically equivalent, but at least they look different.

Great catch! Should be fixed now


Why are tab bars aligned to center adjusted?

Issue Report Checklist

[ ] Searched the issues page for similar reports
[ ] Read the relevant sections of the Spyder Troubleshooting Guide and followed its advice
[ ] Reproduced the issue after updating with conda update spyder (or pip, if not using Anaconda)
[ ] Could not reproduce inside jupyter qtconsole (if console-related)
[ ] Tried basic troubleshooting (if a bug/error)

[ ] Restarted Spyder
[ ] Reset preferences with spyder --reset
[ ] Reinstalled the latest version of Anaconda
[ ] Tried the other applicable steps from the Troubleshooting Guide

[ ] Completed the Problem Description, Steps to Reproduce and Version sections below

Problem Description
What steps reproduce the problem?

What is the expected output? What do you see instead?
Paste Traceback/Error Below (if applicable)

PASTE TRACEBACK HERE

Versions

Spyder version: 5.4.2
Python version: 3.9.14
Qt version: 5.15.2
PyQt version: 5.15.7
Operating System name/version: Darwin 21.6.0

Dependencies

PASTE DEPENDENCIES HERE

Not sure if this is new in Spyder but the file tabs in the tab bar are "center aligned".  They used to be "left aligned".  Not a huge quirk but no other IDEs have their tabs center aligned so I would like to revert this somehow in the Spyder settings.  The same thing also occurs for Console tabs.
Spyder version: 5.4.2

Last used Spyder version: 5.3.1

Hey @BJWiley233, thanks for reporting. This was reported before on issue #20504 and we'll try to fix it in our next version (5.4.3), to be released next month.

I'm going to close your issue as a duplicate of that one.

Ah ok they called it "pane tabs" instead of "tab bar" so couldn't find it in my search 😄.  Thanks.


Edge eventlistener support

Description
adds EventListener support to the Edge shim
Purpose
making .addEventListener('icecandidate') and friends work.
version considerations
(not sure if we should have those?)
Not urgent, but should be a minor version. I have some more Edge stuff that i want to merge as well.

LGTM


Inconsistent handling of bugs with no test patches

Bugs with no test patches are inconsistently handled. Sometimes the patch is missing from the patches directory or the patch exists but is empty.
Examples:

Empty patch: Cli 7 (link)
Missing path: Mockito 1 (file doesn't exist)

I would suggest we keep the test patch even if it is empty.  An empty test patch give me some confidence that the procedure to collect it was at least executed.
@Thomsch, could you please

Check whether the bug-mining procedure keeps empty test patches.
Push the missing empty patches.

Thanks in advance.

Hi Jose, thank you for the reply.

I couldn't find any mention in the bug-mining procedure (here, and here) that keeps empty test patches.
I created https://github.com/rjust/defects4j/pull/525 to add the missing files. Let me know if you also want me to commit the Python script I used to create the files and in which folder to place it.

Thanks @Thomsch.
I don't think we would need to push that Python script, we would need however to understand whether the scripts used in the bug-mining procedure generate empty test patches when there isn't any change in the tests directory.  In other words, if one would try to mine the Lang project today, would this line https://github.com/rjust/defects4j/blob/master/framework/bug-mining/initialize-revisions.pl#L191 generate empty test patches for Lang-{15, 25, 49}?

If yes, then you will only need to include the missing empty test patches in your pull request #525.
If no, then you will need to (1) fix the script used in the bug-mining procedure so that it keeps/generated empty test patches and (2) include the missing empty test patches in your pull request #525.

Hi @jose, sorry it took so long to get back. Summer was busy.
From what I understood and tested, export-diff in  https://github.com/rjust/defects4j/blob/master/framework/bug-mining/initialize-revisions.pl#L191 creates an empty patch of 0 bytes if the files are not changing. The only case where the file is not generated is when the git diff or svn diff fails.
I updated the pull request #515 with zero-byte patches.


Add bulk conversion method to FxRatesArray

Signature should be FxRatesArray.convert(DoubleArray values, Currency fromCurrency, Currency toCurrency), returns DoubleArray

Fixed by https://github.com/OpenGamma/Strata/commit/8d887823747553f79f9834a6a51a8463599ab9d8


Themes are not updating

When I updated my theme using hte Github theme selector the theme is not beign applied.

Im having the same problem. Did you solve  it?

Same here. Am I missing something?

I'm having the same problem, can't find any way to solve it.

What are the themes you are trying to switch to?

@elijahcruz12 :
All of available github themes - Cyaman, Slate, Merlot, etc... - are not working.
I am not sure if I am missing something or not. Trying to change theme through repository settings. It just change _config.yml file (https://github.com/Klepeto/klepeto.github.io/commit/1495ac6ffbcdde43cc6fe7cf3ccf35ba547c7096). Seems too easy to work to me (??)

Same issue.

Setting a theme manually in _config.yml or via the theme chooser in options does not appear to any affect.

Same issue.

Same thing here. Any news on how to solve it?

Found the solution:   delete your _layouts/default.html file.

@nyurik That is the solution as far as I can see. I will check further now into what causes the change.

Thanks @nyurik this works

@cisnhn It depends on the theme you're using. It might provide some means to customise the navigation bar via the config file or an include. Check the documentation for the theme.
If this functionality is not available, you could try importing the theme files into your repository and modifying them there.

@ldjb Thank you! I will try it.