Deprecate VM's spec.running in favor of run strategies

Run Strategies were introduced back in 2019: https://github.com/kubevirt/kubevirt/pull/2070.
As written in the user guide [1], the reason Run Strategies were introduced is to allow for greater variation of user states which is impossible with spec.running which is limited in nature because it's of a boolean type.
After more than 5 years it is time to start deprecating this field which is limited and redundant.
Roughly, the steps to achieve this deprecation are:

Add documentation about this field being deprecated and/or raise a warning when it is being used.
Stop using this field in:

Production code.
Unit / functional tests.
Templates.
And more.

Visibly warn the community about removing this field.
Remove the field.

This issue is for tracking this effort, which will probably take a while, mainly because the field is extensible used by Kubevirt.
[1] https://kubevirt.io/user-guide/compute/run_strategies/

This is not the first removal proposal.
With a few proposals for removal - ie slirp also in the past - we are now - to me more than in an exception case - breaking semver.
How about having a discussion to discuss the fields that should be removed, and then proposing a v2 in order to do the removal in a semver compatible way.
cc @EdDev

I think these are fair examples.
They have helped us in the past, but maybe the wind is changing.
My recommendation would be to collect these examples

slirp
(bindings overall?)
floppy
running
resources.*

and cover them in a proposal to move to v2, this would dramatically simplify the removal of those fields WITHOUT sacrificing on our semver committment.

Thank you for opening this issue.
The slirp binding deprecation involved removal and indeed broke semver commitment. However, it was a classic candidate for such an exception because as far as we know, no one uses it.
It is pretty rare to identify unused features/fields, therefore the exception is a good fit.
This case is different in the usage. We know it is used and therefore harder to reason for an exception to drop it.
However, deprecation can be forwarded without removal. I.e. document, mark in code and raise warnings when used.
Raising this topic in the community meeting and continue discussing this in design proposal will be great.

I'd be very happy to see the deprecation (though not removal!) of running as a proof-of-concept, to be followed by a repeatable plan for everything else.
We should avoid introducing possibly-conflicting "knobs" to our API. And when we realize we have multiple possibly-contradicting ways to express the same thing in the API, we should guide our users to the right API.

I've opened a new issue https://github.com/kubevirt/common-templates/issues/581 about it in common-templates to replace it with spec.runStrategy.

/remove-lifecycle stale

/remove-lifecycle stale
On Sun, Dec 1, 2024 at 9:15 AM kubevirt-bot @.***>
wrote:

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually
close.
If this issue is safe to close now please do so with /close.
/lifecycle stale
—
Reply to this email directly, view it on GitHub
https://github.com/kubevirt/kubevirt/issues/11993#issuecomment-2509628139,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAUMACBU4RHGQMXGGUNWX32DLASVAVCNFSM6AAAAABIMLJC5KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBZGYZDQMJTHE
.
You are receiving this because you were mentioned.Message ID:
@.***>


problem in wordpress,

I'm sure the js file is intergrated in wordpress, but it always says:
Uncaught TypeError: $(...).pickmeup is not a function...

Please check up to date readme, PickMeUp is free from jQuery dependency for a long time now, hence it is no longer available as plugin and there is no $(...).pickmeup


windows blurbehind effect isn't working on windows 10

windows blurbehind effect isn't working on windows 10. I'm trying add blur effect to my application windows, but itn't display it.

Does it work in sciter.exe (wsciter.exe now)? If yes, then the problem is with the manifest.


Transfer variant may not be blank.

Describe the Bug
We face on our Server at the moment a crash in a specific region.
I was able to insulate the region and was able to load it in a singleplayer world without any another mod.
Reproduction Steps

Download the Save  or the Prismlauncher instance
Load the CrashBelts world
If you spawn at the worldspawn, tp to tp @s -455 140 -1476
Game should crash after loading some chunks.

Expected Result
Don't crash
Screenshots and Videos
No response
Crash Report or Log
https://gist.github.com/dakiba/c307a5c5d871b1906fd0ab33a5a95122
Operating System
Linux Server & Linux Desktop
Mod Version
0.5.1c
Minecraft Version
1.19.2
Other Mods

Additional Context
Tested with 1.20.1 and 0.5.1d too. Same crash.
I will try to find now the exact block that cause the issue and will update this ticket, if I find any future information.

With Not Enough Crashes, there is a info more for this event:
Block Entity NBT: {Casing:"NONE",Controller:{X:-485,Y:141,Z:-1477},Covered:0b,Index:0,Inventory:{Items:[{Angle:190,InDirection:4,InSegment:11,Item:{Count:1b,id:"minecraft:andesite"},Offset:0.009259259f,Pos:2.4958339f,PrevOffset:0.009259259f,PrevPos:3.0291672f},{Angle:34,InDirection:4,InSegment:7,Item:{Count:1b,id:"minecraft:andesite"},Offset:-0.13518518f,Pos:3.4958339f,PrevOffset:-0.13518517f,PrevPos:4.029167f},{Angle:20,InDirection:4,InSegment:8,Item:{Count:1b,id:"minecraft:andesite"},Offset:-0.14814815f,Pos:4.495834f,PrevOffset:-0.14814813f,PrevPos:5.029167f},{Angle:327,InDirection:4,InSegment:10,Item:{Count:1b,id:"minecraft:air"},Offset:0.13611111f,Pos:6.029167f,PrevOffset:0.13611111f,PrevPos:6.029167f},{Angle:290,InDirection:4,InSegment:9,Item:{Count:1b,id:"minecraft:andesite"},Offset:0.101852834f,Pos:7.029167f,PrevOffset:0.10183714f,PrevPos:7.5625005f},{Angle:320,InDirection:4,InSegment:7,Item:{Count:1b,id:"minecraft:andesite"},Offset:0.35f,Pos:7.5625f,PrevOffset:0.35f,PrevPos:7.5625f},{Angle:187,InDirection:4,InSegment:8,Item:{Count:1b,id:"minecraft:andesite"},Offset:-0.01641941f,Pos:8.029167f,PrevOffset:0.35f,PrevPos:8.5625f},{Angle:199,InDirection:4,InSegment:12,Item:{Count:1b,id:"minecraft:andesite"},Offset:0.017592564f,Pos:9.029167f,PrevOffset:0.01759256f,PrevPos:9.095834f},{Angle:182,InDirection:4,InSegment:9,Item:{Count:1b,id:"minecraft:andesite"},Offset:0.35f,Pos:9.5625f,PrevOffset:0.35f,PrevPos:9.5625f},{Angle:343,InDirection:4,InSegment:10,Item:{Count:1b,id:"minecraft:andesite"},Offset:0.1641977f,Pos:10.095834f,PrevOffset:0.1641977f,PrevPos:10.095834f},{Angle:80,InDirection:4,InSegment:11,Item:{Count:1b,id:"minecraft:andesite"},Offset:0.03133355f,Pos:11.095834f,PrevOffset:0.03133355f,PrevPos:11.095834f},{Angle:238,InDirection:4,InSegment:13,Item:{Count:1b,id:"minecraft:andesite"},Offset:0.054177754f,Pos:12.095834f,PrevOffset:0.054177754f,PrevPos:12.095834f},{Angle:100,InDirection:4,InSegment:12,Item:{Count:1b,id:"minecraft:andesite"},Offset:0.35f,Pos:12.5625f,PrevOffset:0.35f,PrevPos:12.5625f},{Angle:27,InDirection:4,InSegment:15,Item:{Count:1b,id:"minecraft:andesite"},Offset:-0.14169113f,Pos:13.295835f,PrevOffset:-0.14169113f,PrevPos:13.295835f},{Angle:158,InDirection:4,InSegment:13,Item:{Count:1b,id:"minecraft:andesite"},Offset:0.35f,Pos:13.5625f,PrevOffset:0.35f,PrevPos:13.5625f},{Angle:175,InDirection:4,InSegment:14,Item:{Count:1b,id:"minecraft:andesite"},Offset:0.16086504f,Pos:14.295835f,PrevOffset:0.16086504f,PrevPos:14.295835f},{Angle:79,InDirection:4,InSegment:16,Item:{Count:1b,id:"minecraft:andesite"},Offset:-0.094732784f,Pos:15.029168f,PrevOffset:-0.094732784f,PrevPos:15.029168f},{Angle:217,InDirection:4,InSegment:15,Item:{Count:1b,id:"minecraft:andesite"},Offset:0.35f,Pos:15.5625f,PrevOffset:0.35f,PrevPos:15.5625f},{Angle:2,InDirection:4,InSegment:17,Item:{Count:1b,id:"minecraft:andesite"},Offset:-0.16622426f,Pos:16.02917f,PrevOffset:-0.16622426f,PrevPos:16.02917f},{Angle:113,InDirection:4,InSegment:16,Item:{Count:1b,id:"minecraft:andesite"},Offset:0.35f,Pos:16.5625f,PrevOffset:0.35f,PrevPos:16.5625f},{Angle:264,InDirection:4,InSegment:17,Item:{Count:1b,id:"minecraft:andesite"},Offset:0.35f,Pos:17.5625f,PrevOffset:0.35f,PrevPos:17.5625f}],PositiveOrder:0b},IsController:1b,Length:20,Network:{Capacity:294912.0f,Id:-125344331591534L,Size:398,Stress:32256.0f},Source:{X:-486,Y:141,Z:-1477},Speed:-256.0f}

I am not sure what help you want.  you have a borked entity. you can temporarily use the neruina mod (server-side) to auto-remove borked ticking entities.

Oh thx! Didn't know about that mod! That helpes in the future, I just removed the block now with amulet. But that mod is a good way to get a stable server. Thx

good. please consider closing this issue.

huh? the mod neruina is just a workaround. The bug is still not fixed. If we place a belt at exact this position, the error still happens. I Don't think that this issue should be closed.

can you show a screenshot of the area after the ticking block entity has been removed?

This is weird.

a belt shouldn't get into this state
if it does, there's failsafe code.
will have to debug the save, thanks for providing it


Parser stuck on Screen Mode Escapes

I know screen mode escapes are not supported and I don't need them to be parsed, however I noticed that the parser gets stuck on screen mode escapes (starting with \x1b[= or \x1b[?). I don't know whether the right handling of these would be to leave them as they are or remove them. Here is a test function that gets stuck:
#[test]
fn test_screen_modes() {
    let bytes: Vec<u8> = b"\x1b[?25hAAABBB".to_vec();
    let output = Ok(Text::from(Spans::from(Span::styled(
        "\x1b[?25hAAABBB",  // or "AAABBB"
        Style::default()
    ))));
    assert_eq!(bytes.into_text(), output);
}

Can you check #17 and see if that fixes the issue ?

I removed the escape sequences as I want to give only readable text as output


add infer hex

Adds the hex for tidymodels/infer!

[x] I have converted fonts to outlines in the .svg
[x] My PNG has dimensions 2521 x 2911

The svg is rather large is there any way you could simplify/generalise the borders of the tree?

Yup, you got it! svg file size from 1.5 MB to 350 KB in 206600f.


How do I create a local RAG worflow? (with ollama embedding model?)

Is the an example workflow where I can load files  in comfyui and then use an ollama embedding model to do rag with an LLM (ollama)

It's coming ... https://www.loom.com/share/34768ceb54d94f789ab57cee57e8460e?sid=3803d380-9ac1-4066-a173-cf370907e108

To! I'm working on a pretty major refactor of the configs this week, and then will release both that and the configs at the same time.
Also got a lot of customer meetings this week so my time will be a bit tight :)

It's available now - in the examples folder:
https://github.com/griptape-ai/ComfyUI-Griptape/blob/main/examples/retrieval_augmented_generation.png

thank you so much! will be super helpful!


Does the Project work for models other than Faster Rcnn such as yolo?

i noticed that there is  yolo in ur ERD/mmdet/models/detectors/yolo.py.  Does the incremental learning method apply to yolo?  i would appreciate ur answers and suggestions

+1

i noticed that there is yolo in ur ERD/mmdet/models/detectors/yolo.py. Does the incremental learning method apply to yolo? i would appreciate ur answers and suggestions

Have you found a good solution to this problem?


category file isn't always created

$ afew -vv --learn spam -- tag:spam
DEBUG:root:executing [u'dbacl', u'-T', u'email', u'-l', u'/home/adborden/.local/share/afew/categories/spam']
DEBUG:root:Executing query u'tag:spam'

$  ls ~/.local/share/afew/categories/
important

I have 6 messages tagged as spam. Will dbacl not create a category file if there's not enough data?

It seems that afew does not create the ~/.local/share/afew directory either.


Database.ExecuteSqlCommand returns void?

Hi... in EF6 Database.ExecuteSqlCommand had a int return type that represented the number of records affected... now in EF7 however it returns void... is that they way it should be???? is there another way in EF7 to execute a command and get the number of records affected???? I am trying to avoid raw ado.net code... thanks

Already fixed in our current code base :smile: https://github.com/aspnet/EntityFramework/blob/2bc7eaa29cc57f7d550ab4eeba24b07c940595a2/src/Microsoft.EntityFrameworkCore.Relational/RelationalDatabaseFacadeExtensions.cs#L41

thanks @rowanmiller ....


net: Conn hangs with SetReadDeadline

What version of Go are you using (go version)?

$ go version
1.13

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/harsha/.cache/go-build"
GOENV="/home/harsha/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/harsha/mygo"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/harsha/.gimme/versions/go1.13.linux.amd64"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/harsha/.gimme/versions/go1.13.linux.amd64/pkg/tool/linux_amd64"
GCCGO="/usr/bin/gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/harsha/mygo/src/github.com/minio/minio/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build110074343=/tmp/go-build -gno-record-gcc-switches"

What did you do?
~https://play.golang.org/p/Xpw5O5EsXQv~
https://play.golang.org/p/C-Jdtg6Wr9M

$ NO_TIMEOUT=0 go run /tmp/http.go

<?php
$homepage = file_get_contents('http://localhost:1234/');
echo $homepage;
?>

~ for i in $(seq 1 5); do /usr/bin/time -f "%E" php7.2 http.php 1>/dev/null; done
0:05.04
0:00.06
0:05.02
0:05.05
0:05.04

What did you expect to see?
No hangs with following code
$ NO_TIMEOUT=1 go run /tmp/http.go

<?php
$homepage = file_get_contents('http://localhost:1234/');
echo $homepage;
?>

~ for i in $(seq 1 5); do /usr/bin/time -f "%E" php7.2 http.php 1>/dev/null; done
0:00.03
0:00.01
0:00.01
0:00.01
0:00.01

What did you see instead?
Hangs up to the SetReadDeadline timeout
$ NO_TIMEOUT=0 go run /tmp/http.go

<?php
$homepage = file_get_contents('http://localhost:1234/');
echo $homepage;
?>

~ for i in $(seq 1 5); do /usr/bin/time -f "%E" php7.2 http.php 1>/dev/null; done
0:05.04
0:00.06
0:05.02
0:05.05
0:05.04

This is another variant of the same issue https://github.com/golang/go/issues/21133 and the work-around presented works still.
import (
	"net"
	"sync/atomic"
	"time"
)

// QuirkConn - similar to golang net.Conn struct, but contains a workaround of the
// following the go bug reported here https://github.com/golang/go/issues/21133.
// Once the bug will be fixed, we can remove this structure and replaces it with
// the standard net.Conn
type QuirkConn struct {
	net.Conn
	hadReadDeadlineInPast int32 // atomic
}

// SetReadDeadline - implements a workaround of SetReadDeadline go bug
func (q *QuirkConn) SetReadDeadline(t time.Time) error {
	inPast := int32(0)
	if t.Before(time.Now()) {
		inPast = 1
	}
	atomic.StoreInt32(&q.hadReadDeadlineInPast, inPast)
	return q.Conn.SetReadDeadline(t)
}

// canSetReadDeadline - returns if it is safe to set a new
// read deadline without triggering golang/go#21133 issue.
func (q *QuirkConn) canSetReadDeadline() bool {
	return atomic.LoadInt32(&q.hadReadDeadlineInPast) != 1
}

The question I have is why this workaround is needed at all. Is it not expected to SetReadDeadline() right before the read operation? but why does it work some times?  It also looks like there may be some performance implications on doing something like this.

The program you showed us doesn't look at NO_TIMEOUT at all.  Are you showing us the exact code that you are testing?

@ianlancetaylor my bad here is the right example
https://play.golang.org/p/Xpw5O5EsXQv

Had to update the example, updated the right link.

If c.SetReadDeadline(time.Now().Add(c.readTimeout)) in your example is commented out, deadlock still occurs.  Consider resolving the problem with your customization of net.Listener and/or net.Conn first.

If c.SetReadDeadline(time.Now().Add(c.readTimeout)) in your example is commented out, deadlock still occurs. Consider resolving the problem with your customization of net.Listener and/or net.Conn first.

@av86743 I don't think so it does here is how I tested the shared code.
package main

import (
	"log"
	"net"
	"net/http"
	"os"
	"time"
)

// timeoutableConn
type timeoutableConn struct {
	readTimeout time.Duration
	net.Conn
}

func (c *timeoutableConn) Read(b []byte) (n int, err error) {
	if c.readTimeout > 0 {
		//c.SetReadDeadline(time.Now().Add(c.readTimeout))
	}
	n, err = c.Conn.Read(b)
	return n, err
}

// customListener returns timeoutable net.Conn
type customListener struct {
	net.Listener
}

func (l *customListener) Accept() (conn net.Conn, err error) {
	c, e := l.Listener.Accept()
	if e != nil {
		return nil, e
	}
	return &timeoutableConn{Conn: c, readTimeout: 5 * time.Second}, nil
}

func main() {
	var l net.Listener
	l, err := net.Listen("tcp", ":1234")
	if err != nil {
		log.Fatal(err)
	}

	if os.Getenv("NO_TIMEOUT") != "1" {
		l = &customListener{l}
	}

	_ = http.Serve(l, http.HandlerFunc(
		func(w http.ResponseWriter, req *http.Request) {
			buf := []byte(`<IP_ADDRESS>	localhost
<IP_ADDRESS>	backspace

# The following lines are desirable for IPv6 capable hosts
::1     ip6-localhost ip6-loopback
fe00::0 ip6-localnet
ff00::0 ip6-mcastprefix
ff02::1 ip6-allnodes
ff02::2 ip6-allrouters

<IP_ADDRESS>    ceph-1
<IP_ADDRESS>    ceph-2
<IP_ADDRESS>    ceph-3
<IP_ADDRESS>    ceph-4
<IP_ADDRESS>    ceph-5
<IP_ADDRESS>    ceph-6
<IP_ADDRESS>    ceph-7
<IP_ADDRESS>    ceph-8

`)
			w.Write(buf)
			w.(http.Flusher).Flush()
		}))
}

~ go run /tmp/t.go

~ for i in $(seq 1 10); do /usr/bin/time -f "%E" php7.2 http.php 1>/dev/null; done
0:00.03
0:00.01
0:00.01
0:00.01
0:00.01
0:00.01
0:00.01
0:00.01
0:00.01
0:00.01

So no hangs if that code is commented out.  Add the code back.
~ <for i in $(seq 1 10); do /usr/bin/time -f "%E" php7.2 http.php 1>/dev/null; done
0:05.02
0:00.04
0:00.01
0:05.01
0:05.04
0:05.01
0:00.01
0:00.01
0:05.01
0:05.01

So there is no issue in the code itself, I am not sure how are you testing it.

... I am not sure how are you testing it.

Run on playground.

Run on playground.

Playground doesn't run HTTP service @av86743 its a nacl container :-)

Playground doesn't run HTTP service etc.

First: Why put your example in playground if it is not runnable from there?
Second: An original example from #21133 with your setting of port :1234 is runnable from playground all right.
Third: #21133 was closed without any intention to fix anything in net/http.  Why do you want to present it differently as:
// QuirkConn - similar to golang net.Conn struct, but contains a workaround of the
// following the go bug reported here https://github.com/golang/go/issues/21133.
// Once the bug will be fixed, we can remove this structure and replaces it with
// the standard net.Conn

@av86743 because original was never addressed, what I wanted to shed light on is that the workaround provided was also not correct because.
It basically disabled SetReadDeadline() altogether and that exactly what shouldn't happen. Setting deadlines repeatedly shouldn't cause hangs in the first place and the workaround is also wrong because it basically just disabled the SetReadDeadline() code.

First: Why put your example in playground if it is not runnable from there?

This is an odd argument, the intention is to show code how to reproduce it. This issue also talks about how to reproduce it using the command line using PHP code. I don't know what made you think that you can run in the playground and also run PHP code to reproduce this.

Second: An original example from #21133 with your setting of port :1234 is runnable from playground all right.

The original example added client code, which I didn't want to add because you need to use PHP to reproduce this issue not Go HTTP client. Please follow what I pasted above on how to reproduce it.

Second: An original example from #21133 with your setting of port :1234 is runnable from playground all right.

This is not a question and as such, it does not require your response.  This is statement of a fact contrary to what you have earlier stated (I quote):

Playground doesn't run HTTP service @av86743 its a nacl container :-) any long-running go-routines such as HTTP service are rejected.

... This issue also talks about how to reproduce it using the command line using PHP code. ... you need to use PHP to reproduce this issue not Go HTTP client. ...

If you are not able to reproduce whatever it is without involving PHP, why do you claim that problem is on the go side and not on the PHP side?

@harshavardhana It's documented in #21133 why your code doesn't work, and what the workaround is. If the workaround has problems, you should open a new issue with code that demonstrates them.
Note curl is a better test client; not that many folks have PHP installed.
P.S. you don't have to respond to every comment you get on an issue :-)

If you are not able to reproduce whatever it is without involving PHP, why do you claim that problem is on the go side and not on the PHP side?

Right now its just PHP - I haven't explored enough to show you if there are other clients out there which reproduce this issue - the reason is that without deadlines the code works fine. That makes me wonder that the issue is in Go - either deadlines don't work the way we want or we are using it wrong. Some explanation that would help in the documentation.

@harshavardhana It's documented in #21133 why your code doesn't work, and what the workaround is. If the workaround has problems, you should open a new issue with code that demonstrates them.

Fundamental reasoning is why does one need a workaround in the first place, the issue is closed as if the bug is in our custom net.Conn implementation which doesn't seem to be the case unless our usage of deadlines are dead wrong - if that is the case I am happy to change the implementation instead of applying a workaround. So any guidance on that area would be much appreciated.

Please re-read #21133.

... without deadlines the code works fine.  ... either deadlines don't work the way we want or we are using it wrong. ...

When read deadline is not set in customizedConn.Read, current implementation of net/http uses very short implicit deadline and time-outs almost instantly.  What you call "code works fine" is actually "problems are not given sufficient time to manifest".

When read deadline is not set in customizedConn.Read, current implementation of net/http uses very short implicit deadline and time-outs almost instantly. What you call "code works fine" is actually "problems are not given sufficient time to manifest".

Okay, understood @av86743 - with that analogy it would certainly also mean that writing custom wrappers for net.Conn with deadlines is generally not advisable and can lead to issues - also come in the way.
Would it be possible to document such a thing? Because we shot ourselves in the foot without realizing this would come in the way as per net.Conn documentation.

Is there an intent to document this on why writing custom net.Conn's with deadlines won't work in reality with net/http?

sounds like this was a problem in user code.


When creating the first game, it only works on the second attempt

the first time the server returns 202, meaning that Organiser::create() has been called, but no new game has been created.
this is quite obvious, as the game created message returns way too quick for a new database to be created

How can we solve this? Shouldn't the message wait for a response from the backend?

some kind of response on ``Organiser::create```whether the game has been created. currently it returns void

also the first game isn't created, which is also wrong, since all the neccissary values have been supplied

It is not saved to the database? Could you debug this as I don't have my mysql workspace ready until monday

For the Organiser::create I would propose a boolean return  through a null check on the game as the gamecreator returns null when the game can't be created

not saved to the database, no new database created.

This then will have to wait until monday when I can properly investigate again

#134

currently i cant reproduce this on the current master


fix(zh-doc): fix incorrect command in document

Description
I found the mistake in zh document(includes zh-CN and zh-TW), this PR includes these changes that fix incorrect command in zh document.
Checklist

[ ] I have run cargo make pr-flow
[x] I have reviewed my own code
[ ] I have added tests

It just a change for update incorrect command in document, so there is not have to run cargo make pr-flow and add test cases.

Thanks!


MS4 Feedback Session

Feedback for Group 8

Notes from [Saira] on Feedback on the analysis:

Analysis 1:

[x] add titles to your visualizations.
[x] use markdowns to add insights after your plots.
[x] highlight your work for each milestone with a markdown title and add a conclusion that shows how did you answer your research question.

Analysis 2:

[x] use markdowns to add insights after your plots.
[x] highlight your work for each milestone with a markdown title and add a conclusion that shows how did you answer your research question.

Analysis 3:

[x] use markdowns to add insights after your plots.
[x] highlight your work for each milestone with a markdown title and add a conclusion that shows how did you answer your research question.

Contracted Grade

What is your contracted grade?

A

Are you on track to satisfy all the requirements of your contracted grade?

Yes, Make changes mentioned in all of your open issues. Please review the details of each contracted grade here and if you have questions, come see the instructor or the Project TAs for more details.

Completed MS4 Feedback Session


Orthographic

TODO

[x] panning with orthographic camera not good
[x] screenshots broken (for orthographic camera)
[x] fix hyperball impostor (just noise) -> will likely be removed (#118)
[x] fix sphere impostor (bounding box too small)
[x] fix cylinder impostor (flickering)

fantastic


sklearn-compatible interface

I think it would be great to have this feature, as I think sklearn is often used for tabular data. I tried to use skorch, but skorch does not allow TensorFrames and did not work well.
(examples/tutorial.py)
from skorch import NeuralNetClassifier

net = NeuralNetClassifier(module=model, max_epochs=args.epochs, lr=args.lr,
                            device=device, batch_size=args.batch_size,
                            classes=dataset.num_classes, iterator_train=DataLoader,
                            iterator_valid=DataLoader, train_split=None)
net.fit(train_dataset, y=None)

Traceback (most recent call last):
  File "\examples\tutorial.py", line 346, in <module>
    net.fit(train_dataset, y=None)
  File "\site-packages\skorch\classifier.py", line 165, in fit
    return super(NeuralNetClassifier, self).fit(X, y, **fit_params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "\site-packages\skorch\net.py", line 1319, in fit
    self.partial_fit(X, y, **fit_params)
  File "\site-packages\skorch\net.py", line 1278, in partial_fit
    self.fit_loop(X, y, **fit_params)
  File "\site-packages\skorch\net.py", line 1190, in fit_loop
    self.run_single_epoch(iterator_train, training=True, prefix="train",
  File "\site-packages\skorch\net.py", line 1226, in run_single_epoch
    step = step_fn(batch, **fit_params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "\site-packages\skorch\net.py", line 1105, in train_step
    self._step_optimizer(step_fn)
  File "\site-packages\skorch\net.py", line 1060, in _step_optimizer
    optimizer.step(step_fn)
  File "\site-packages\torch\optim\optimizer.py", line 373, in wrapper
    out = func(*args, **kwargs)
          ^^^^^^^^^^^^^^^^^^^^^
  File "\site-packages\torch\optim\optimizer.py", line 76, in _use_grad
    ret = func(self, *args, **kwargs)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "\site-packages\torch\optim\sgd.py", line 66, in step
    loss = closure()
           ^^^^^^^^^
  File "\site-packages\skorch\net.py", line 1094, in step_fn
    step = self.train_step_single(batch, **fit_params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "\site-packages\skorch\net.py", line 993, in train_step_single
    y_pred = self.infer(Xi, **fit_params)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "\site-packages\skorch\net.py", line 1517, in infer
    x = to_tensor(x, device=self.device)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "\site-packages\skorch\utils.py", line 104, in to_tensor
    return [to_tensor_(x) for x in X]
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "\site-packages\skorch\utils.py", line 104, in <listcomp>
    return [to_tensor_(x) for x in X]
            ^^^^^^^^^^^^^
  File "\site-packages\skorch\utils.py", line 118, in to_tensor
    raise TypeError("Cannot convert this data type to a torch tensor.")
TypeError: Cannot convert this data type to a torch tensor.

I think the following changes are needed:

Add an ability to convert from DataFrame to TensorFrame without much prior information.
Create a wrapper that passes Tensor to skorch or create a scikit-learn compatible estimator specifically for this package.

I am sorry, but I cannot take much time to assist in creating this feature, so if it is not possible, please close this.

You can convert a DataFrame to TensorFrame easily with
dataset = Dataset(df, col_to_stype=col_to_stype, target_col="y")
dataset.tensor_frame

See tutorial.

Thanks for your suggestion! I think this is great to add. Setting this as P2 feature, as we first want to prioritize more stype support https://github.com/pyg-team/pytorch-frame/issues/88.

Is someone already working on that?

No, as far as I know. Let us know if you are interested!

Yes, I'm interested.

@MacOS Great, thank you! It'd be good to complete this feature by the end of January. Would that be possible?

@weihua916 As of now, yes.

I have tried this and it seems to be very difficult.
As a quick fix that isn't pretty, the following seems necessary:

Rewrite to_tensor_ to bypass `TensorFrame.
Add index = torch.sensor(index) to torch_frame.DataLoader.collapse_fn to make it return TensorFrame instead of list[TensorFrame].

However, I don't know how to pass the validation dataset.

:thinking:
Thank you for looking into this, @34j! I was about to start working on it.

Add an ability to convert from DataFrame to TensorFrame without much prior information.

I would have simply converted the DataFrame to TensorFrame internally, work with it, and if requested, return the DataFrame again. This means, of course, that one has to track what was given. Or am I missing something?

Create a wrapper that passes Tensor to skorch or create a scikit-learn compatible estimator specifically for this package.

This seems to be very big and unrealistic because we would have to make all estimators compatible with scikit-learn, which is a lot to ask for. At the moment, scikit-learn is an optional dependency.
May I ask you, @34j, to post a self-contained example (or examples) that what qualify pytorch-frame as being sklearn-compatible?

@34j Is fine with me!
So we drop the second part of your request then, correct?

Heads up everyone, I started working on it. I already merge the PR draft of @34j into my fork.
Would be nice if you guys would be available in case I have questions. :)

May I ask you what is your question

Heads up everyone, I started working on it. I already merge the PR draft of @34j into my fork.
Would be nice if you guys would be available in case I have questions. :)

May I ask you what is your question

So far none. I meant just in case.
Sorry for the delay at all, but I had personal matters to deal with. I'm confident that I can submit a PR this month.

Hi all,
short update, unfortunately, I got sick, hence again a delay. Should I still work on it?

Hi all,
short update, unfortunately, I got sick, hence again a delay. Should I still work on it?

I think it should continue. Are you still working on this part? Otherwise I can take over.

Yes, still working on it @qychen2001!

Yes, still working on it @qychen2001!

That's great! This feature is really important, looking forward to your PR.

Sorry but I have almost completed this feature in #375 and am just waiting for @weihua916 's review.

Sorry but I have almost completed this feature by myself in #375 (as MacOS seemed to be sick) and am just waiting for @weihua916 's review. However, the styling work for pre-commit by MacOS I referred certainly helped this.

That's fantastic! But I'm still concerned about the relationship between skorch and sklearn, can your PR directly support models in sklearn such as svm?

Excuse me but what do you mean by relationship? skorch works perfectly, trust me plz

can your PR directly support models in sklearn such as svm?

sklearn models already has sklearn-compatible interface apparently


XTheadFMemIdx: No parens?

As I pointed out in #6, there are some inconsistencies in XTheadMemIdx.
XTheadFMemIdx does not have such inconsistencies in the manual but replacing rs1 with (rs1) may be an option to keep consistency with other RISC-V instructions.
Is not having parens around rs1 is intentional?  If not, we should fix both the manual and GNU Binutils (I can handle the GNU Binutils part).

As I mentioned in the https://github.com/T-head-Semi/thead-extension-spec/issues/6
I will fix the document. And if you can fix in the GNU Binutils, I will would really appreciate it.


Uncheck all doesn't update

I have this implemented with a nullable field and when I check some options and save the resource it works well. Then if I go back and uncheck all the boxes and save the resource doesn't update. Says it's successful but the boxes are still checked.

Hi @dannydinges.  Yep, I've now replicated this locally.  Will push up a fix for this later today.  Thanks for the report

@dannydinges - this should now be resolved in the latest version (v0.0.5)

Thanks! Appreciate the quick fix.


Fix build break on Linux

Use size_t instead of int in vec_mode so that the comparison
between histogram.size() and the value doesn't conflict with
respect to sign. The values should always be natural numbers
(array indices) so size_t is appropriate.

Without this, on Linux we get this build error:
turicreate/src/unity/toolkits/activity_classification/sequence_iterator.cpp: In function 'double turi::sdk_model::activity_classification::vec_mode(const flex_vec&)':
/builds/turi/turicreate/src/unity/toolkits/activity_classification/sequence_iterator.cpp:42:29: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
         if(histogram.size() < (value + 1)){


Some models don't work in C++.

I'm trying to run DirectML via onnxruntime, but some models don't work in C++ sample.

My exection environment

In C++

OnnxRuntime DirectML : version==1.15.1
DirectML : version==1.12.0
Graph optimization level : ORT_DISABLE_ALL
MemPattern : Disable
Execution mode : ORT_SEQUENTIAL

In Python

Python version==3.9.18
onnxruntime-directml==1.15.1

One of the models that does not work is the one below.

Code for model creation
import os
import torch
import torch.nn as nn

model_name_onnx = 'model_avg_512.onnx'

class simple_model(nn.Module):
    def __init__(self):
        super().__init__()
        self.avg_pool_01 = nn.AvgPool2d((2,2), stride=(2,2), padding=0)

    def forward(self, img):
        y0 = self.avg_pool_01(img)

        return y0

model = simple_model()

input0 = torch.tensor(torch.randint(255, size=(1, 1, 512, 512)), dtype=torch.float32)
y = model(input0)

input_names = ['input0']
output_names = ['output']
dynamic_axes = {'input0': {0: 'batch_size'}, 'output': {0: 'batch_size'}}

torch.onnx.export(
        model,
        (input0),
        model_name_onnx,
        export_params=True,
        opset_version=11,
        input_names=input_names,
        output_names=output_names,
    )

Input size: [1x1x512x512]
Layer information: single average_pool2d layer only

kernel_size: (2,2)
strides: (2,2)
padding: (0,0)

opset_version==11

The above model works fine with the Python sample, but it does not work with the C++ sample.
Also, the model with the input size changed to [1x1x256x256] works correctly with both Python and C++ samples.
Is this a known issue?
My goal is to make the model work with input size [1,1,1080,1920].
I'd be grateful for any help, thanks!

@jstoecker
Good day!
My colleague @c-m-k-miyoshi faced this issue, if it's possible, may I check that there is any workaround or fix?
This issue will delay our customer Acer to release their latest AI PC, according to the schedule, this feature should be provided in the mid of Jan 2024.

@jstoecker
May I check there is any update?


Do not include private or confidential information in this issue.

Is this a feature or a bug?

[ ] Feature (request for enhancement, new functionality)
[x] Bug (something is broken)

Which version of rpc-openstack does this issue relate to?

[x] master
[ ] newton-14.0
[ ] mitaka-13.1
[ ] liberty-12.2

What happened?

In certain instances the logstash log fills with nonsensical timestamp parse errors.

What were you doing when it happened?

Happens just after a deploy

What did you expect to happen instead of what actually happened?

Logstash works correctly

Is this an issue with the ELK roles in general? Maybe something we could pull in from the OSA community?


2x speed audio lag

Existing Issues

[X] I have searched for existing issues, this is not a duplicate.

Unmodded Twitch

[X] I have checked and this issue only occurs using bttv-android and not with the unmodded Twitch App

What happened?
Audio on 2x speed seems to buffer where the video plays but the audio freezes as if the audio is playing faster than the video
bttv-android version
v0.43.0-beta
android version
14
device
Rog phone 8 pro
Anything else?
No response

Sounds like the same issue as #691? Either way, as we don't mess with the video / audio processing, there is little to be done here.


⚠ Bofrost.de has degraded performance

In bf84976, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1174 ms

Resolved: Bofrost.de performance has improved in 61510d8 after 2 hours, 55 minutes.


feat(image): creat image from pixels and buffer

@homu r+

:pushpin: Commit b57eb7a has been approved by MichaelHirn

:hourglass: Testing commit b57eb7a with merge 7f13c24...

:sunny: Test successful - status


develop_FW-871 Standalone SPI project for openmote-B

I just created two files , a header file and main file for using SPI bus.

No sure I understand. Is this code now working? All I see are two empty txt files. I must be missing something.

Hi Thomas,
They're just for testing , Mina was showing how to upload a file just to
get familiar with that.
Thanks
Le ven. 27 mars 2020 à 16:03, Thomas Watteyne<EMAIL_ADDRESS>a
écrit :

No sure I understand. Is this code now working? All I see are two empty
txt files. I must be missing something.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/openwsn-berkeley/openwsn-fw/pull/505#issuecomment-605048947,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AO6ZFECBLKI5EK6NEYQAEXTRJS52VANCNFSM4LVBYU2A
.


Frames from a previous test/suite are being added to the next test/suite

Describe the bug
The last frame from the previous test is incorrectly saved as the first frame of the current test.
On the last test, a screenshot was taken after the call to ffmpeg.
I'm not sure where to start looking to help diagnose this issue as it appears to be a sync problem.
Log
I have trimmed some of the incoming commands as I don't believe they add value.
--- New suite: Test Suite 1 ---

--- New test: Test 1 ---
Incoming command: /session/:sessionId/screenshot => [screenshot]
- Screenshot!! (frame: 0)
Incoming command: /session/:sessionId/screenshot => [screenshot]
- Screenshot!! (frame: 1)
Incoming command: /session/:sessionId/screenshot => [screenshot]
- Screenshot!! (frame: 2)
Incoming command: /session/:sessionId/screenshot => [screenshot]
- Screenshot!! (frame: 3)
ffmpeg command: "ffmpeg.exe" ...

--- New suite: Test Suite 2 ---

--- New test: Test 1 ---
Incoming command: /session/:sessionId/screenshot => [screenshot]
- Screenshot!! (frame: 4)
Incoming command: /session/:sessionId/screenshot => [screenshot]
- Screenshot!! (frame: 0)
Incoming command: /session/:sessionId/element/55a8bedc-cca0-4e40-bdfc-9f70884dec4b/text => [text]
ffmpeg command: "ffmpeg.exe" ...

--- New suite: Test Suite 3 ---

--- New test: Test 1 ---
Incoming command: /session/:sessionId/screenshot => [screenshot]
- Screenshot!! (frame: 1)
Incoming command: /session/:sessionId/screenshot => [screenshot]
- Screenshot!! (frame: 0)
ffmpeg command: "ffmpeg.exe" ...
Incoming command: /session/:sessionId/screenshot => [screenshot]
- Screenshot!! (frame: 1)
Incoming command: /session/:sessionId => [:sessionId]

To Reproduce
I'll attempt to create an example repo and update this issue soon
Expected behavior
Frames from a previous test/suite shouldn't be added to the current test/suite
Environment (please complete the following information):

wdio-video-reporter version: 3.4.0
WebdriverIO version: 8.0.13
Mode: WDIO Testrunner
If WDIO Testrunner, running sync/async: async
Node.js version: v18.12.1
NPM version: 8.19.2
Browser name and version: Chrome 109

@Diazole thanks for raising the issue. Mind providing a minimal reproducible example to help us investigate the issue?

Closing due to inactivity.


Save it with blog post title

It would be nice if we can save it with blog post title

Resolved in v0.0.5


Cleanup ResourceExport if exported Service has no available Endpoints

Refine ServiceExport controller to watch Endpoints events to
ensure that Service kind of ResourceExport can be removed
when the exported Service no longer has available Endpoints,
or skip writing ResourceExport if there is no Endpoints at the beginning.
Fixes #4055
Signed-off-by: Lan Luo<EMAIL_ADDRESS>

/test-multicluster-e2e

/test-multicluster-e2e

/test-multicluster-e2e

/test-multicluster-e2e
/skip-all

/test-integration

/test-integration


The latest docker image hasn't been uploaded to Docker Hub

According to the log of the latest build, there has been an error while publishing the docker image.
docker login -u="$DOCKER_USERNAME" -p="$DOCKER_PASSWORD"
WARNING! Using --password via the CLI is insecure. Use --password-stdin.
Error response from daemon: Get https://registry-1.docker.io/v2/: unauthorized: incorrect username or password

I assume that the username or the password set to the env are wrong.
Could you check the values just in case?

That was actually done to test some stuff out and left out on purpose. Unfortunately, if you look at the earlier releases, the overall build with aws and docker images and pushes, takes too long and travis terminates our job as it exceeds allowed time. So I'm thinking about possible ways of breaking up the jobs but haven't had a chance to spend much time on this task.

@havetisyan Hi Henry,
Thank you for the answer.
I wasn't thinking about the allowed time.
Should I close this issue?
Perhaps, we can just leave this until we eventually take some actions for it.
Thank you,
Chris


Problem: Cannot use angular2-template-loader with webpack-env.d.ts

For use webpack APIs (like require.context()), webpack-env.d.ts is needed.
The definition includes its own require.
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/webpack/webpack-env.d.ts#L21
It returns a value as T. so require() returns the type {}.
error TS2345: Argument of type '{ selector: string; template: {}; }' is not assignable to parameter of type 'ComponentMetadataType'.
  Types of property 'template' are incompatible.
    Type '{}' is not assignable to type 'string'.

idea
Maybe, The loader should replace templateUrl to <string>require(...).

Oh interesting. I'll welcome a pr and tests for this absolutely.

Does anyone have a workaround for that?
I also feel that replacing stuff with <string>require(...) might interfere with tslint (and tslint-loader) setting of treating such constructs an error. But not sure about this last piece

@TheLarkInn  I also think that given the fact that this project's primary consumers are Webpack users, you should really be recommending to install @types/webpack-env

The correct way to require a string with webpack-env.d.ts is
require<string>(...)


Add Restack as a way to deploy Chatwoot on Kubernetes

I would like to add detailed documentation of how to deploy Chatwoot with Restack either under Deploying with Kubernetes or under Deployments as a separate page.
It will look something like this.
Let me know if you have any suggestions about the format.

@kuberaspeaking Moved this to docs repo as it is the right place for the discussion.
@vishnu-narayanan Any thoughts here on how @kuberaspeaking can move forward?

@kuberaspeaking This gives a 404 https://www.restack.io/docs/deploy-appsmith-on-kubernetes

@vishnu-narayanan we have taken it down temporarily but we will put it back up soon.

@vishnu-narayanan the page is up


Rename allows recursive renames, which break file system

os0 = pyfakefs.fake_filesystem.FakeOsModule(fs)
path0 = "/Volumes/ramdisk/test"
path1 = path0 + "/alpha"
try: os0.rename(path0,path1)
except: pass
result = os0.path.isdir(path0)
print result
At this point, result is False, and something seems deeply wrong (the rename dies due to going over maximum recursion depth).  The right response for rename would be what os does:
Traceback (most recent call last):
File "bug7os.py", line 6, in
os0.rename(path0,path1)
OSError: [Errno 22] Invalid argument
(and not modifying the file system)

This looks valid.

If I prevent this problem by not trying renames of X to X (which has always been a tricky thing, I remember at NASA "finding" this bug on a file system that hadn't actually gotten to me yet, just reading interface control documents, and asking what happened on rename(X,X) with directories), and disallow renames with src or dst as directory, rename seems to be ok now.  Clear those up and we can probably test with unrestricted renames.

If even NASA doesn't get this right, we may be excused ;)


server.root not working as expected

From #support channel:
It looks like it's saying errors are different because they have a different file path. Our file paths include the hash of the artefact that is currently deployed, so these always change every deploy. Or is it because there's a different id? Although I would have thought ID detection in error messages would be Rollbar's bread and butter...

@jessewgibbs I believe the filepath is used for default fingerprinting. So if a unique artifact id is being used in the path, it will create problems with fingerprinting. I believe the best workaround is to use custom fingerprinting - they can, for example, ignore the unique artifact name and replace it with a * character before sending errors to Rollbar.


Prevent submit inside a form.

Prevent submit when emoji picker is used inside a form.
Context
Currently if picker is embedded in to a form element the undefined buttons submit the form.
This change will prevent that by adding type="button"
Summary
Preventing form submission on emoji/group click.
Relevant Technical Choices
Added type="button" to emoji and group buttons.
Checklist

[✔] I have tested this code to the best of my abilities

Duplicate: https://github.com/delowardev/vue3-emoji-picker/pull/22

Thanks for your contributation.


Why doesn't .map or .forEach expose an index?

Both of these functions are actually on Iterable, and inherited through List.
It is possible to have an Iterable without a definitive length (or index, of any sort). For example, imagine a virtual-scrolling list. Of course, it is very easy to write such functionality yourself, if you'd like:
void forEachIndex<T>(Iterable<T> elements, void Function(T, int) forEach) {
  var i = 0;
  for (final element in elements) {
    forEach(element, i++);
  }
}

void example(Iterable<String> elements) {
  forEachIndex(elements, (e, i) {

  });
}

You might also find following this useful: https://github.com/dart-lang/sdk/issues/9991, then you'd do:
import 'package:your_package/your_package.dart';

void example(Iterable<String> elements) {
  elements.forEachIndex((el, i) { ... });
}

The asMap method probably does what you want.
  var thing = [5,4,3,2,1];
  thing.asMap().forEach((k, v) => print("$k : $v"));

0 : 5
1 : 4
2 : 3
3 : 2
4 : 1

 items: [
            ["HOME", Icons.home],
            ["MESSAGE", Icons.message],
            ["READ", Icons.chrome_reader_mode],
            ["ACITIVTY", Icons.local_activity],
            ["ME", Icons.person],
          ]
              .asMap()
              .map<int, BottomNavigationBarItem>(
                  (k, v) => MapEntry(k, _genBottomBarItem(k, v[0], v[1])))
              .values
              .toList(),


Request::sendPhoto raises "Telegram returned an invalid response"

Hi,

Operating system: Linux 2.6.32-openvz-042stab123.1-amd64 #1 SMP Wed Mar 22 15:22:33
PHP version: 5.6.30-0+deb8u1 (64bit); apache2handler; Linux
PHP Telegram Bot version: 0.45.0 and 0.44.0
Using MySQL database: yes
MySQL version: 5.5.55-0+deb8u1-log
Update Method: Webhook or getUpdates
Self-signed certificate: yes or no

Expected behaviour
Request::sendPhoto should send image, as it worked till today
Actual behaviour
Request::sendPhoto raises "Telegram returned an invalid response! Please review your bot name and API key"
But if I use sendMessage against, all is working well.
Extra details
I tried to create another bot, just using the same code and different apikey and all is going well, even sendPhoto method.
So, in summary, sendPhoto doesn't work ONLY with specific bot.
Could somebody help me?
Thanks

Strange thing, after several hours it is working normally again. I don't really think that it is some kind of limits, due to a very small number of hits. So, what was it?

This could be a temporary blip from Telegram, possibly due to their update to API version 3.1.
Not sure.
I'll close off here, as it seems to be solved again, but if it keeps on happening, just reopen here 👍

@arc92 What version of the bot are you using?


Add a new

Duplicates ❌

[X] I have searched the existing icons or assets and requests.

Which Figma library is concerned?
Vitamin Icons
Remix icon check (only for icons)

[X] I have searched if the icon is already available on Remix.

Icon or Asset name
Logout-box
Icon or Asset description

Icon or Assets keywords
No response
Icon or Asset author
No response
Icon or Asset SVG code
<svg>...</svg>

Are there any other important details?
No response

Icon published on Figma (in dev libraries to come)


[top_earlgrey] Reduce number of PRINCE half rounds for main SRAM scrambling

This PR contains multiple commits to reduce the number of PRINCE half rounds for the main SRAM scrambling from 3 back to 2 as used for Earlgrey ES. This is done to reduce timing pressure.
The scrambling parameters of the other scrambled memory primitives (retention SRAM, ROM, OTBN IMEM & DMEM) are not touched by this PR.
This PR supersedes #24376 as it also includes the required tooling changes. #24376 is intentionally left untouched to allow comparing the RTL changes as #24376 has already been absorbed by the PD team last week, i.e., we must not change the RTL beyond #24376.
For reference, the PRs where we increased the number of scrambling rounds in the past are:

https://github.com/lowRISC/opentitan/pull/22425
https://github.com/lowRISC/opentitan/pull/22948

CHANGE AUTHORIZED: hw/ip/sram_ctrl/data/sram_ctrl.hjson
CHANGE AUTHORIZED: hw/ip/sram_ctrl/rtl/sram_ctrl.sv
CHANGE AUTHORIZED: hw/top_earlgrey/data/top_earlgrey.hjson
CHANGE AUTHORIZED: hw/top_earlgrey/rtl/autogen/top_earlgrey.sv
This is an ECO PR confirmed by the PD team.

To ensure there are no inadvertent changes compared to what the PD team is working with, I git diff'ed hw/ip/sram_ctrl/rtl/sram_ctrl.sv and hw/top_earlgrey/rtl/autogen/top_earlgrey.sv w.r.t. PR #24376: that diff is empty. :heavy_check_mark:

CHANGE AUTHORIZED: hw/ip/sram_ctrl/data/sram_ctrl.hjson
CHANGE AUTHORIZED: hw/ip/sram_ctrl/rtl/sram_ctrl.sv
CHANGE AUTHORIZED: hw/top_earlgrey/data/top_earlgrey.hjson
CHANGE AUTHORIZED: hw/top_earlgrey/rtl/autogen/top_earlgrey.sv
This is an ECO PR confirmed by the PD team.

Many thanks for this well-designed and -structured PR, @vogelpi! The changes LGTM and are aligned with discussions/decisions.
Just one question: What evidence on the DV side (top- and block-level tests) do we have that this works as intended?

Thanks for your review @andreaskurth . We have the following tests running in CI:

top-level:

chip_sw_power_virus: does some back door accesses into the main SRAM to communicate with the C side
chip_sw_sram_scrambled_access: does back door accesses into all scrambled SRAMs to test the scrambling, including error generation

block-level:

SRAM_CTRL_MAIN smoke test: tests the SRAM_CTRL configuration (2 half rounds) used for the main SRAM, including backdoor accesses
SRAM_CTRL_RET smoke test: tests the SRAM_CTRL congfiguration (3 half rounds) used for the retention SRAM, including backdoor accesses

There is also a C++ model of the scrambler hw/ip/prim/dv/prim_ram_scr/cpp/scramble_model.cc that is not touched by this PR. My understanding is that we only use this C++ model for OTBN block-level Verilator simulation. OTBN uses the default setting of 3 half rounds. This model is also run in CI.

From a security side, this has been approved already by @johannheyszl . For details refer to this doc.


[5.8] Add contracts for model factory and factory builder

Packages that have custom implementations of the Eloquent model factory and factory builder run into issues when factory methods change or new methods are added.  This pull request adds interfaces to ease maintaining feature parity with the base Eloquent factory.
Laravel Doctrine has run into this in the past.  I think this would also help projects with in house alterations to the factories.
I'm not sure if would count as a breaking change or not.  If I need to change the target branch to master I can.

Closing pending inactivity.

@taylorotwell I've made the suggested changes.

@garret-gunter the interface still extends from ArrayAccess

Merge request isn't updating the files.
https://github.com/garret-gunter/framework/commit/e0d3b752e304941df5f5e925daef60e94bcbb34d

@garret-gunter it's not force push, because there is no message about force push on github

Maybe I force pushed wrong.  Should I open a new merge request with the changes?

@garret-gunter feel free


duff: fix syntax error causing ugly error message (no failures)

Minor fix to remove confusing error message from build log.

Seems ok, travis passed, thanks.


No support for Python2?

Is it intentional or Python2 support is dropped for neomake? Currently in
document I don't see how I can configure neomake to check grammar mistakes in
Python2 code.

it's actually covered in the docs, just search python inside the doc, here
you can add autocmd! BufWritePost * Neomake in your vimrc to enable neomake for all filetypes, after write, and then you open up a .py file with neovim, :w and the error signs should show.
if still not working, could you verify that neomake_python_enabled_makers are installed on your system? like pylint, pep8?

They are installed. Actually I have both python2 and python3's version installed. The problem is, when I invoke Neomake, only Python3 version's pylint is called. And I may get error message like No () after print, since I mainly code in Python2.7.
Syntastic actually specified an variable g:syntastic_python_python_exec for me to specify if it's Python2 or Python3 version I prefer. Yet I don't see equivalent variable here.

I am using Arch linux, by the way. So by default, python in my system specifically mean python3. If I want to use python2 I have to explicitely use command python2 or python2.7. Hope this information helps.

it seems pylint may be installed through pip3 rather than python2's pip? can you try to install pylint for python 2, perhaps, using pip2 if it's on your system

OK, I have installed pylint and pylint2 on my system from Arch repository. I don't want to use pip to install them because I don't want conflicting command name mess up my root folder.
Command pylint --version will return
pylint 1.5.4,
astroid 1.4.4
Python 3.5.1 (default, Mar  3 2016, 09:29:07)
[GCC 5.3.0]

Command pylint2 --version will return
pylint2 1.5.4,
astroid 1.4.4
Python 2.7.11 (default, Mar  3 2016, 11:00:04)
[GCC 5.3.0]

I wonder if I should try adding pylint2 into my g:neomake_enabled_makers. I didn't try because it generate error message in syntastic.

Did you find a solution to this problem? I am in the exact same situation.

No. Adding pylint2 to g:neomake_enabled_maker will prompt error message:
Error detected while processing function neomake#Make..<SNR>150_Make..neomake#GetMaker:
line   41:
E121: Undefined variable: maker
E116: Invalid arguments for function deepcopy(maker)
E15: Invalid expression: deepcopy(maker)

Or did I do something wrong? I mean, I see no instruction in your document on how to enable specifically Python2's syntax checking if both Python2 and Python3 are available on the machine. Or is it not implimented yet?

There is no "pylint2" maker, so adding it the the list of enabled makers doesn't do anything useful. You would need to create a new maker named pylint2 and place it in with the other makers.
The easiest solution to run pylint2 instead of pylint(3) is probably:
let g:neomake_python_enabled_makers = ['pylint']
let g:neomake_python_pylint_exe = 'pylint2'

Thanks, it works.


US 01.04.01

As a player, I want to see my highest and lowest scoring QR codes.
Acceptance Criteria

Display the highest scoring code in a place that is easily visible to the player
In the list of codes attached to an account player should be able to sort the codes based on score
Display of highest scoring code should update when a new highest scoring code is found

Unknowns

Where will highest score be displayed, main page or account page

Story Points

1
Display the highest scoring code
Have a way to view codes based on score, attached to account view

Risk Level

Medium
Need to be able to sort code objects
Have the display of the highest scoring code update if a higher scoring code is found

Sorting functionality is still not implemented


Add API endpoints useful for minimizing disk usage on mobile apps

It would be useful to have an API endpoint that gives the user the top level information needed to show the list of measurements for a given report_id.
The API called should give a report_id in input and get back the top level information including:

The inputs tested
Which ones had anomalies and the anomaly color
For each anomaly the metadata for rendering the UI of the individual measurement

This is done.


fix(win): incorrect isElectronApp logic

Ref: https://github.com/electron/electron/blob/13e601e35c43ad640fbe2bfea57e9a054f1dca4c/shell/common/node_bindings.cc#L595-L596

Thanks!
I did a little tweak to make it also compatible with old versions.


Fix regression introduced in #965.

It's not your fault! We didn't cover these cases with tests before. All you can do is keep the tests cases that do exist green, and you did that.

Can someone from @rspec/rspec review this?

looking


Step 3 - guiding questions - conditionals

Each time we ask them if something is hazardous, it should followup by asking what the hazard is if they answered yes. This doesn't always happen.
To simplify, let's have an open text box after each of these questions, and change the yes/no/I don't know to "Yes (fill in the hazards below)" / "No (fill in evidence of no hazard below)" / "I don't know".

To just have a text box, make a question that is " " (just a space). Can only have one per section. BUT could do multiple spaces maybe, see if that will work for a unique identifier?


Dialogue Bug with Mac Build in "actions"

Describe your bug here.
Basically everytime I try to play a song when adding a mods folder, the dialogue is buggy as in the song starts before dialogue is finsihed
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Lua
What is your build target?
Mac
Did you edit anything in this build? If so, mention or summarize your changes.
no

This is a duplicate

what do you mean duplicate

someone alr made this issue

what do you mean duplicate

Not the first issue about it

i really want it to be fixed so bad because i really want to play mod without the issue of dialogue being buggy


Clarify the difference or usage of Workspaces to App

Your definition or opening of an APP also describes a Workspace. This text requires either clarification or differ enation between App and Workspace. Also whether a APP can use one or more Workspaces. Talk to usage, security business problem being solved by implementing an APP

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fe16182b-c80c-4cc3-da85-bf6fb0fe152f
Version Independent ID: 6b92afe7-dfda-39b3-455c-e886b27e3d70
Content: What is a Power BI app? - Power BI
Content Source: powerbi-docs/consumer/end-user-apps.md
Service: powerbi
Sub-service: pbi-explore
GitHub Login: @mihart
Microsoft Alias: mihart

Hi @devman2k, thanks for your comments about the article. I am forwarding it on to the doc author for consideration.

Hi @devman2k ,
You make some good points!  I've updated the article and set it to republish.  Take a look later this week and let me know if you think it still needs more detail.
Thank you
The DOCS team

Thank you!!!
Thanks,
Bryan
Bryan Tuttle
President
MCT,MCSD,MCDBA,MCAD
CodeRight Inc.
20 Marion Drive
Tewksbury, MA 01876
Phone:<PHONE_NUMBER>

From: Michele Hart @.>
Sent: Monday, August 23, 2021 2:33 PM
To: MicrosoftDocs/powerbi-docs @.>
Cc: Bryan Tuttle @.>; Mention @.>
Subject: Re: [MicrosoftDocs/powerbi-docs] Clarify the difference or usage of Workspaces to App (#3049)
Hi @devman2khttps://github.com/devman2k ,
You make some good points! I've updated the article and set it to republish. Take a look later this week and let me know if you think it still needs more detail.
Thank you
The DOCS team
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/powerbi-docs/issues/3049#issuecomment-904013688, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB37BSCN6LKAM2B64CVYK6TT6KIBPANCNFSM444SFG6A.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email.


Requirements.txt underscores instead of dashes

https://github.com/intel/intel-extension-for-transformers/blob/main/intel_extension_for_transformers/neural_chat/requirements.txt
Uses underscores intel_extension_for_pytorch
but it should be dashes  intel-extension-for-transformers ??

Different projects

Here's a screenshot of install instructions for the other library, its showing as dashes.
Yes they are different, but issues appears to remain

From: kevinintel @.>
Sent: Tuesday, March 26, 2024 12:43:39 AM
To: intel/intel-extension-for-transformers @.>
Cc: Sarkis, Anthony @.>; Author @.>
Subject: Re: [intel/intel-extension-for-transformers] Requirements.txt underscores instead of dashes (Issue #1421)
Different projects
—
Reply to this email directly, view it on GitHubhttps://github.com/intel/intel-extension-for-transformers/issues/1421#issuecomment-2019579499, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BGKVHGXSTFUGGRTWYGFHPKLY2ERKXAVCNFSM6AAAAABFH5T4VWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJZGU3TSNBZHE.
You are receiving this because you authored the thread.Message ID: @.***>

It would not a problem, please try tagain

Could be related to python version. Appears 3.12 is not supported.
Added to this existing ticket on other repo
https://github.com/intel/intel-extension-for-pytorch/issues/525#issuecomment-2023251003
FYI it's showing as dashes here so not sure why this is being treated differently for this context
https://pypi.org/project/intel-extension-for-pytorch/

@anthony-intel  Thanks for sharing! Actually intel_extension_for_pytorch package supports both intel_extension_for_pytorch and intel-extension-for-pytorch on PyPI (not only IPEX, but also ITREX and other similar named projects). What you found here https://pypi.org/project/intel-extension-for-pytorch/ is because Pypi will replace _ with -, but eventually they are the same product.
Let's keep tracking here https://github.com/intel/intel-extension-for-pytorch/issues/525#issuecomment-2023251003
If it's okay for you, please close the ticket in ITREX.

Thanks for update!


Adding name arguement in kubeadm-config.yaml

In AWS cloud platform, omitting the name while initializing etcd cluster
causes "Couldn't find local name "$HOSTNAME in the initial cluster configuration"
It seems that the etcd tries to find short hostname, not the FQDN hostname.
To avoid this, passing the name explicitly to etcd configuration solved the problem.
related issue1
related issue2

/assign @chuckha @detiber

/approve


Pin 'mpmath<1.4' in CI

Temporarily address https://github.com/pytorch/vision/issues/8292

The wheel building jobs are still failing but the unittest jobs are running, which is a net improvement, merging. Thanks for the quick stamp @vfdev-5


Update parameters

Description
Updated some parameters:
-Negative electrode OCP functions for Chen2020, Chen2020_plating and O'Regan2021 parameter sets now have an addiional term to capture the behaviour at high stoichiometry
-Chen2020_plating no longer uses a lookup table, so is now much faster
-Changed one parameter in the Ecker2015 positive electrode OCP function to better fit the data (R^2 is now 0.999)
-Corrected exchange current density in both electrodes for Ecker2015
Fixes # (issue)
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

[ ] New feature (non-breaking change which adds functionality)
[x] Optimization (back-end change that speeds up the code)
[x] Bug fix (non-breaking change which fixes an issue)

Key checklist:

[x] No style issues: $ flake8
[x] All tests pass: $ python run-tests.py --unit
[x] The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.
Further checks:

[x] Code is commented, particularly in hard-to-understand areas
[ ] Tests added that prove fix is effective or that feature works

I merged these changes into the branch used for partially reversible plating and for some reason this fixes the specific error that prevents this pull request being merged. I'm therefore closing this one.


Pages for networks / participant organizations, scoping

(NB: this is not identical to the use of the term "network" in e.g. issues 381 and 69, where we refer to regional sections of the GBIF network)
Rationale: Data publisher registration and data publication through GBIF happens via GBIF Participant nodes, who i.a. endorse new publishers in their domain. For country participants, visibility and credit is given to the node in the country pages. Typically, all datasets of a publisher registered under and endorsed by a country Participant will be assigned to that country. Associated Participant organizations, on the other hand, are frequently thematically focussed, and are involved with the mobilization and publication of data across a wider geographic area. They also typically are involved with only specific datasets from a wide range of publishers, who publish other data as well that are not relevant to the associated Participant's thematic focus. For this type of Participant, appropriate visibility and credit needs to be given at a similar level as for country Participants.
To date, a very basic representation is given, including a short descriptive text for the network and a list of relevant datasets. The information which datasets are relevant to include in that list is manually maintained. Example: https://demo.gbif.org/network/2b7c7b4f-4d4f-40d3-94de-c28b6fa054a6
Elements to include:

Title and description of the network
contact information
a list of relevant datasets
map of occurrences from all datasets
literature citations of reported data use (DOI)

Issues to address / discuss:

Terminology: we use "network" for different entities, which is confusing:
-- GBIF participation as a whole (https://demo.gbif.org/the-gbif-network)
-- an Associated Participant who acts as an endorsing node and acts on behalf of a network of data publishers on their side (https://demo.gbif.org/network/2b7c7b4f-4d4f-40d3-94de-c28b6fa054a6)
-- potentially: a bracket for a thematic collection of datasets, without explicit Participant status (e.g. country-slices of eBird)
main menu structure: where to include?
network visibility on individual dataset pages ("is member of: ..."/"contributes to: ...")
clarity on different hierarchical entities across data publication and GBIF participation, e.g. OBIS as a data publisher / an associate participant / a network -

Nice! I would add

split by publisher & stats
definition of network (at least for internal use)
related to visibility - formula to autogenerate the citation for the dataset belonging to a network "proudly delivered to you via..." or a more serious version, I propose

to change
Chatzigeorgiou G, Faulwetter S (2016). Polychaetes from two subtidal rocky shores of the North coast of Crete, collected for the NaGISA project 2007-2008. Version 1.2. Hellenic Center for Marine Research. Sampling_event Dataset https://doi.org/10.15468/b7dt2n accessed via GBIF.org on 2017-07-21.
to
Chatzigeorgiou G, Faulwetter S (2016). Polychaetes from two subtidal rocky shores of the North coast of Crete, collected for the NaGISA project 2007-2008. Version 1.2. Hellenic Center for Marine Research via OBIS. Sampling_event Dataset https://doi.org/10.15468/b7dt2n accessed via GBIF.org on 2017-07-21.
The shortest version I can imagine is to add " via [abbreviated network name]" after the name of publishing organisation.

The simplest approach to this as a starting point would be simply to say we give it the same elements as the current publisher page on demo.gbif.org, which gives us all of the content described by Andrea plus stats (datasets, occurrences). I do not agree that the network should be included in the auto-generated citation for the simple reason that a dataset can belong to more than one network, and 'via' implies an exclusive association. It should be enough to ensure that dataset pages include a list of which network(s) the dataset belongs to. I am also not so sure about splitting by publisher - how would that work? We can't list publishers associated with the network since some publishers will have datasets in several networks or none. As long as the listed datasets include publisher name in the information displayed on the network page, that should be enough.


fix: return empty invoice if no upcoming invoice

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 41.43%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5987

Relevant Lines:
14451

💛  - Coveralls


Wiki installation updates, general cleanup

General cleanup for older stuff, clarifications, audio streaming on linux - pipewire by default with script, roadmap update

If noone else has objections, this can be merged.

I noticed couple of things off, let me quickly edit

done


Add Docusaurus WIP repo

It's just about ready - here is @bigolboyyo's personal repo that needs to be moved
just needs a dev review from @shreeup @connor-cs @airbr
To Do

[ ] Someone please claim this in a comment below for Friday release @shreeup @connor-cs @airbr

[ ] Add notice in README that it's not the live website, but a testing site for our migration available at docusaurus.climatetechhandbook.com (Password: test)

[ ] Ensure it runs locally and README makes sense for new dev contributors

[ ] Anything I'm missing?

Updated with disclaimer and transferred ownership. Please feel free to still proofread and make suggestions and changes.
https://github.com/climate-tech-handbook/docusaurus-cth


feat: add a new action 'pre-commit-autoupdate'

Description

It's useful for updating .pre-commit-config-optional.yaml and .pre-commit-config-ansible.yaml
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Worked: https://github.com/autowarefoundation/autoware/pull/3050#issuecomment-1319674776


upd(mangohud): 0.7.0 -> 0.7.1

Yes, there's breaking changes in develop, see pacstall/pacstall#1038

Don't update manually, all the necessary changes to pacscripts will be made when develop is merged into master.

Don't update to the new changes for now, all the necessary changes to pacscripts will be made when develop is merged into master.

The exception should be minor and major releases/hotfixes.

Does I need to add incompatible with develop to make it able to merge ?
Sorry for all the questions.

Does I need to add incompatible with develop to make it able to merge ?
Sorry for all the questions.

No, sorry, idk what I was talking about then 😆 Let's just go back to before I said that.

Does I need to add incompatible with develop to make it able to merge ?
Sorry for all the questions.

No, sorry, idk what I was talking about then 😆 Let's just go back to before I said that.

No problem. I have reverted, I think it's all good to merge:)


📝 Ingestion: Define Maintenance Procedure

User Story
As an AP product engineer
I need/want/expect to… keep the ingestion service up to date
So that… we maintain a secure service
Value / Purpose
This is our default position but required more consideration in this case as the service relies on container images being releases within specified repositories
Useful Contacts
Gary + Jacob W
User Types
Analytical Platform Engineering
Hypothesis
No response
Proposal
No response
Additional Information
Lambda images in the solution are created in analytical-platform-ingestion-transfer + analytical-platform-ingestion-scan (and in future analytical-platform-ingestion-notify).
Simply merging dependabot pull requests into the repositories will not make them take effect in the service itself.
Once a change is made to the container a new release must be created (example).
Once this is done successfully, the lambdas which use the image must be updated to use the latest release. (example)
Definition of Done

[x] Update documentation to outline steps required to keep this service up to date. The steps are noted above.

Completed as per this PR.


Edited Readme

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Closes #XXXXX

Hi Thanks for the PR @profread
Unfortunately, We can't merge as is because of the merge conflict. Also you are unable to resolve the same because you have created the PR from the master branch, which has kind of soiled your fork.
Here are our guidelines for contributing, which we highly recommend to understand the workflow.
Thanks.

Okay Will check the guideline again
Adeyemi Ridwan
On Thu, 12 Mar 2020, 14:51 mrugesh<EMAIL_ADDRESS>wrote:

Hi Thanks for the PR @profread https://github.com/profread
Unfortunately, We can't merge as is because of the merge conflict. Also
you are unable to resolve the same because you have created the PR from the
master branch, which has kind of soiled your fork.
Here are our guidelines for contributing
https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md,
which we highly recommend to understand the workflow.
Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/freeCodeCamp/freeCodeCamp/pull/38359#issuecomment-598196710,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AH73UHTMJ3EDMPWVYRUYRPTRHDSHVANCNFSM4LGJIVHQ
.


CppUMock for static inline functions defined in headers

Hi,
Is there a clean way to mock functions defined in headers? Embedded platforms usually define a lot of their sdk functions in such manner and when mocks are provided they obviously clash as the functions are defined twice.
Thank you

Interesting question.
The thought that comes to mind is to have the functions not implemented in a class declaration but outside that, perhaps in a separate file.
When use a #if HAVE_INLINE_FUNCTIONS in the header file and include that file when set. Then in the cpp file, include that file when not set.
That does require some changes to the production code but it allows you to not have the functions inline for test, which would make it then easier to stub out.

Indeed it would be very interesting to have a clean way to do this.
There is an interesting issue in the neighborhood [1] [2]. The idea is to regenerate the header file and remove all inlines, then include this header instead of the original one when mocking.
[1] https://github.com/ThrowTheSwitch/CMock/pull/261
[2] https://github.com/ThrowTheSwitch/CMock/issues/150

Hmm, I don't think that we want to generate different header files within CppUTest. We chosen to not have any pre/post processing scripts other than the normal C-preprocessor.

One way i got around was to define the constant that guards the header (so that the content of that header does not get included) and then define the header just with the interfaces i'm interested in. Obviously, this requires work to define all the typedefs the header.

I'm not sure how this would work. Could you give an example?

One way i got around was to define the constant that guards the header (so that the content of that header does not get included) and then define the header just with the interfaces i'm interested in. Obviously, this requires work to define all the typedefs the header.

So you have to modify the third party sdk?

So let's say i want to mock sdk.h which has something along these lines
#ifdef SDK__H_
#define SDK__H_
static inline void function() { }
#endif

i'll write my own sdk.h
// mock stuff etc
void function() { }

When i compile the code i pass -DSDK__H_ to the compiler.
This way, if I have a file that includes sdk.h, it will not include the inline functions but the ones in my own 'sdk.h' where i mock things.
Does that make sense?

Headers with static functions defined need to have header guards. The idea is to

This way, the sdk.h file does not need to be touched. However, whatever is defined in there and used in the code, would need to be copy pasted in the sdk.h that has  the mocks

Ah, you misuse the include guard. Nasty. Smart :) Thanks. I had never thought of doing that. But the duplication is awkward though.

I tried this approach in my project and it not so painful to do that, thanks for the hack!
Let's say I have two vendor dependencies nrf_soc.h and nrf_sdm.h where there is static inline function definitions in there.
I usually have a cmake helper function to create tests, like:
create_test(
        NAME test_foo

        SOURCES_FILE
        # the production code under test
        ${PROJECT_SOURCE_DIR}/path/to/my_production_cod_under_test.c

        # the needed mocks
        ${PROJECT_SOURCE_DIR}/tests/unittests/mocks/nrf_soc.c
        ${PROJECT_SOURCE_DIR}/tests/unittests/mocks/nrf_sdm.c

        # the test runner
        test_foo.cpp

        DEFINITIONS
        # hacked included guards, will be added to the target definitions (target_compile_definition())
        NRF_SOC_H__
        NRF_SDM_H__

        INCLUDE_DIRS
        # include directory where there is nrf_soc.h and nrf_sdm.h which are modified header file (static inline is removed)
        # will be add to the include directories (target_include_directories())
        ${PROJECT_SOURCE_DIR}/tests/unittests/include
)


duckdb sources have anonymous access

The parser.AnalyzeConnectors function will ignore the project's "default connector", which is currently hard-coded to DuckDB, but that wasn't configured for the rill env configure command.


 I'm happy tp provide detailed logs as private message.

Hello Thomas,
Thanks for the bug report!
Following your sample and false-positives, there is pending MR #39 that should fix this :

.map files are now considered as static files in the http-logs parsers
http-crawl-non_statics now does a distinct on the filename (last part of path) rather than the whole path + query

I'll let you know as soon as it's merged so that we can see if it properly solves it.

Hello Thomas,
It has been merged, you should be able to try the new configuration
cscli update
cscli  upgrade collection crowdsecurity/nginx --force

Please let me know when/if you see the issue is solved !
note: --force is required because the hub doesn't bump the collection's version when a subitem is updated so far

Thanks, works perfectly.


[FLINK-13125][docs] Make PubSub stability warning more prominent

What is the purpose of the change
Make the warning on the GCP PubSub connector stability more prominent

Build has passed on my private travis: https://travis-ci.org/rmetzger/flink/builds/554735004
@flinkbot approve all


Sort Service Templates by Csp in listServiceTempalates

The order of shown service templates on 'Catalog' and 'Services' are different.

I will fix it.


chongdata跑路了么

... 没跑路必要，只是没时间运营。。
On Sat, Aug 8, 2020, 8:05 PM williamking5<EMAIL_ADDRESS>wrote:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/JinpengLI/gpu_shared_platform/issues/1, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAZNIDMXQKP3TP7IRRIWLW3R7WHXNANCNFSM4PYYQRMQ
.


[BUG] "Doom" on initial screen looks bad after change font size

Describe the issue
"Doom" on initial screen looks bad after change font size [screenshot]
Steps to reproduce
Add (setq doom-font (font-spec :size 14)) to config.el and restart emacs

Without a :family specified in that font-spec, I'm not sure what font Emacs falls back to, but it is one of your system defaults. In this case, it's a variable-width font (i.e. a non-monospace font). The dashboard (and most of Emacs, for that matter), expects characters to have a fixed width.
To fix this, specify a monospace font:
(setq doom-font (font-spec :family "Fira Code" :size 14))

Or change your system default font.

You're right! after add :family "Fira Code" DOOM looks beautiful. Thanks a lot!


How to use WriteTo and AuditTo side-by-side

I wish to implement both logging and audit capabilities in my app. To date I've set up the logging part by specifying settings in the Serilog WriteTo section of appsettings.json and by setting the Logger property of the static Log entry point to a logger instance created from the settings in this file. For example:
Log.Logger = new LoggerConfiguration()
	.ReadFrom.Configuration(Configuration)
	.CreateLogger();

The logging aspect of things works fine. I now wish to add an audit capability to my app for which I understand I can use an appropriately configured audit sink using AuditTo instead of WriteTo?
I've read elsewhere in regard to other sinks that to reduce the performance impact of audit logging, a separate logging pipeline should be created for audit logging vs. regular diagnostic logging? For example something like:
Log.Logger = new LoggerConfiguration()
	.ReadFrom.Configuration(Configuration)
	.CreateLogger();

var auditLogger = new LoggerConfiguration()
    .ReadFrom.Configuration(MyAuditConfiguration)
    .CreateLogger();

Log.Information("Not audited");
auditLogger.Information("This is audited");

Is this approach a way to proceed with Serilog.Sinks.MsSqlServer?
Is it possible to store the WriteTo and AuditTo configurations in the same file and apply only the relevant section to the relevant logger instance? If so how?
Is it possible for both loggers to write to the same table or is this not advised?
I'm using Serilog.Sinks.MsSqlServer (5.4.0) and Serilog.AspNetCore (3.2.0).
Thanks.

Hi @dctempus. Thanks for the question.
Yes, I think the separation with two different configs, as shown in your sample above would be a proper way to go. I have not tested this though. But I think this question is not specific to this sink. So, if you wan't to be sure, I recommend you to ask over at the Serilog.Sinks.Configuration or the Serilog main repo.

Thanks for the reply. Will do.


GFortran in debug mode flags calls to HDF-EOS2 gdrdfld function with inconsistent buffer types

Bug Description
When compiling with gfortran in debug mode, syntax errors will be reported for subroutines that call the HDF-EOS2 'gdrdfld' function with inconsistent buffer types.
For example, in ldt/DAobs/GLASSlai/readGLASSlaiObs.F90, there are two calls to gdrdfld for AVHRR and MODIS data (depending on user settings).  The AVHRR buffer array is of type integer2, but for MODIS it is of type integer1.
gdrdfld is implemented in C, and is specified to treat the buffer argument as a void pointer (e.g., type is ignored).  So this is not illegal per se.  However, if gfortran is being used to debug other code, the compiler will not compile this code.
A partial solution is to disable HDF-EOS2 when compiling.  But a better solution is needed if the user actually needs that library.
A better solution would be to write simple customized wrapper functions to gdrdfld in Fortran 90 (with an interface block containing module procedure declarations), and call gdrdfld within those wrapper functions.  If only a single gdrdfld call occurs in each wrapper function, then I don't expect gfortran to report a problem.
Steps to Replicate
Run the LDT configure script with a GNU module (e.g., lisf_7.5_gnu_11.2.0_impi_2021.4.0), select Optimization level -2 (strict checks), and select use HDFEOS.  Then compile LDT.

Still TODO.

I am currently compiling LISF 7.5.1 and I came across the same problem about gdrdfld. I checked the codes that used gdrdfld using
grep -rnw '/path/LISF/' -e 'gdrdfld'

and found that same problem exist in these codes:

I checked the /ldt/make/Makefile and found the following lines:
ifeq ($(LIS_ARCH),linux_gfortran)
# For MPI
LDT_historyMod.o: LDT_historyMod.F90
        $(FC) $(FFLAGS) -fallow-argument-mismatch $(HEADER_DIRS) $<
# For HDF-EOS2
readGLASSlaiObs.o: readGLASSlaiObs.F90
        $(FC) $(FFLAGS) -fallow-argument-mismatch $(HEADER_DIRS) $<
readNASA_AMSREsmObs.o: readNASA_AMSREsmObs.F90
        $(FC) $(FFLAGS) -fallow-argument-mismatch $(HEADER_DIRS) $<
endif

This is when I found that my LIS_ARCH was set to linux_ifc. After changing it to LIS_ARCH=linux_gfortran, the mismatch in types can be ignored by gfortran. Hope this could provide some hints.