'WithConcreteTypeDynamicRegistrations' results in unintended instantiation

Using the WithConcreteTypeDynamicRegistrations(), when injecting a range of class, where no registrations has been added, results in instantation of an item.
Other scenarios:

When using WithAutoConcreteTypeResolution the issue does not occur.
If item has been registered, then issue does not occur.
Other range interfaces (IList, ICollection etc.) results in same issue.
Injecting a range of interfaces (eg. IThing), the issue does not occur.

Setup:
class Program
{
  void Main()
  {
    var rules = Rules
        .Default
        //.WithAutoConcreteTypeResolution()
        .WithConcreteTypeDynamicRegistrations();

    var container = new Container(rules);
    container.Register<MyRegistry>();

    var registry = container.Resolve<MyRegistry>();
  }
}

class MyRegistry
{
  public MyRegistry(IEnumerable<Thing> things)
  {
    /* 'things' contains a single thing */
    Debugger.Break();
  }
}
class Thing
{
  Guid Id { get; set; }
}

Expected Behavior:
'things' should be empty.
Current behavior:
'things' contain a single item.

@A-Kjeldgaard, thank you for the example and the detailed description. I will look.

@A-Kjeldgaard What do you mean by this?

If item has been registered, then issue does not occur.

If I am registering Thing then it will appear in the injected collection as intended.
As I understood, you would like to avoid automatic concrete type instantiation with WithConcreteTypeDynamicRegistrations, right?
BTW, WithAutoConcreteTypeResolution works this way because they do not Wrappers in general, including the collection one.

My expectation is: if there is no registrations where the service type is type Thing, then no elements should appear when injecting a collection/enumerable/list.
If I add registrations for Thing, I would expect one item in the injected collection for each registration added.
Examples of registrations:
container.RegisterInstance(new Thing { Id = Guid.NewGuid() });
container.RegisterDelegate(rc => new Thing { Id = Guid.NewGuid() });
container.Register<Thing>();

Side note:
If I was to inject Thing directly, as such:
public MyRegistry(Thing thing) { ... }

Then I would expect the container to instantiate an instance of Thing.


Does not work - only opens empty regular tab

IncognitoTab: 1.1 (2015-03-26)
Xposed version: 3.0 alpha2
Chrome stable: 42.0.2311.111
OS: Cyanogen OS 12.0 Based on Android 5.0.2
Xposed log:
05-07 21:28:49.286 E/Xposed  (18193): de.robv.android.xposed.XposedHelpers$ClassNotFoundError: java.lang.ClassNotFoundException: com.google.android.apps.chrome.utilities.FeatureUtilitiesInternal
05-07 21:28:49.286 E/Xposed  (18193):   at de.robv.android.xposed.XposedHelpers.findClass(XposedHelpers.java:52)
05-07 21:28:49.286 E/Xposed  (18193):   at org.ollide.xposed.incognitotab.ChromeUtils.isDocumentMode(ChromeUtils.java:16)
05-07 21:28:49.286 E/Xposed  (18193):   at org.ollide.xposed.incognitotab.MethodHooks$1.afterHookedMethod(MethodHooks.java:45)
05-07 21:28:49.286 E/Xposed  (18193):   at de.robv.android.xposed.XposedBridge.handleHookedMethod(XposedBridge.java:670)
05-07 21:28:49.286 E/Xposed  (18193):   at com.google.android.apps.chrome.document.ChromeLauncherActivity.onCreate(Unknown Source)
05-07 21:28:49.286 E/Xposed  (18193):   at android.app.Activity.performCreate(Activity.java:5933)
05-07 21:28:49.286 E/Xposed  (18193):   at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1105)
05-07 21:28:49.286 E/Xposed  (18193):   at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2282)
05-07 21:28:49.286 E/Xposed  (18193):   at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2389)
05-07 21:28:49.286 E/Xposed  (18193):   at android.app.ActivityThread.access$900(ActivityThread.java:147)
05-07 21:28:49.286 E/Xposed  (18193):   at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1296)
05-07 21:28:49.286 E/Xposed  (18193):   at android.os.Handler.dispatchMessage(Handler.java:102)
05-07 21:28:49.286 E/Xposed  (18193):   at android.os.Looper.loop(Looper.java:135)
05-07 21:28:49.286 E/Xposed  (18193):   at android.app.ActivityThread.main(ActivityThread.java:5254)
05-07 21:28:49.286 E/Xposed  (18193):   at java.lang.reflect.Method.invoke(Native Method)
05-07 21:28:49.286 E/Xposed  (18193):   at java.lang.reflect.Method.invoke(Method.java:372)
05-07 21:28:49.286 E/Xposed  (18193):   at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:898)
05-07 21:28:49.286 E/Xposed  (18193):   at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:693)
05-07 21:28:49.286 E/Xposed  (18193):   at de.robv.android.xposed.XposedBridge.main(XposedBridge.java:117)
05-07 21:28:49.286 E/Xposed  (18193): Caused by: java.lang.ClassNotFoundException: com.google.android.apps.chrome.utilities.FeatureUtilitiesInternal
05-07 21:28:49.286 E/Xposed  (18193):   at java.lang.Class.classForName(Native Method)
05-07 21:28:49.286 E/Xposed  (18193):   at java.lang.Class.forName(Class.java:308)
05-07 21:28:49.286 E/Xposed  (18193):   at external.org.apache.commons.lang3.ClassUtils.getClass(ClassUtils.java:823)
05-07 21:28:49.286 E/Xposed  (18193):   at de.robv.android.xposed.XposedHelpers.findClass(XposedHelpers.java:50)
05-07 21:28:49.286 E/Xposed  (18193):   ... 18 more
05-07 21:28:49.286 E/Xposed  (18193): Caused by: java.lang.ClassNotFoundException: Didn't find class "com.google.android.apps.chrome.utilities.FeatureUtilitiesInternal" on path: DexPathList[[zip file "/data/app/com.android.chrome-1/base.apk"],nativeLibraryDirectories=[/data/app/com.android.chrome-1/lib/arm, /vendor/lib, /system/lib]]
05-07 21:28:49.286 E/Xposed  (18193):   at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:56)
05-07 21:28:49.286 E/Xposed  (18193):   at java.lang.ClassLoader.loadClass(ClassLoader.java:511)
05-07 21:28:49.286 E/Xposed  (18193):   at java.lang.ClassLoader.loadClass(ClassLoader.java:469)
05-07 21:28:49.286 E/Xposed  (18193):   ... 22 more
05-07 21:28:49.286 E/Xposed  (18193):   Suppressed: java.lang.ClassNotFoundException: com.google.android.apps.chrome.utilities.FeatureUtilitiesInternal
05-07 21:28:49.286 E/Xposed  (18193):       at java.lang.Class.classForName(Native Method)
05-07 21:28:49.286 E/Xposed  (18193):       at java.lang.BootClassLoader.findClass(ClassLoader.java:781)
05-07 21:28:49.286 E/Xposed  (18193):       at java.lang.BootClassLoader.loadClass(ClassLoader.java:841)
05-07 21:28:49.286 E/Xposed  (18193):       at java.lang.ClassLoader.loadClass(ClassLoader.java:504)
05-07 21:28:49.286 E/Xposed  (18193):       ... 23 more
05-07 21:28:49.286 E/Xposed  (18193):   Caused by: java.lang.NoClassDefFoundError: Class not found using the boot class loader; no stack available

I can confirm this, although I installed 1.0 version (beta) and it works. So there must be something wrong with the 1.1 version...

Oh, thanks :+1:

I can confirm this too, with both v1 and v1.1.
Xposed version: 3.0 alpha2
Chrome stable: 43.0.2357.93
ROM: CloudyG3 2.3 (Android 5.0.0)
Any fix estimation?

Two years old, but I'mma just add it still doesn't work. If anyone for any alternatives, do tell.

@oxwivi Check out Firefox Focus, it's a better non-xposed replacement.

@krokofant, I've used and given up on it before once again seeking solutions like this. It's Webkit-based for some reason despite being from Mozilla and its tab mechanism is plain horrible.


Add support for additional labels for service

Describe the feature:
Ability to add additional labels on services .
Describe a specific use case for the feature:
I'm using a kubernetes operator which reads labels from the service and creates ingresses on the basis of those labels. So I need to have the ability to add additional labels on the services.

@jmlrt any idea when this will be released?

This should be released for 7.4.2 or 7.5.0 in november.
Le mer. 30 oct. 2019 à 07:36, Usama Ahmad<EMAIL_ADDRESS>a
écrit :

@jmlrt https://github.com/jmlrt any idea when this will be released?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/elastic/helm-charts/issues/342?email_source=notifications&email_token=ACBPJT4VVTHHQ3KKUCTPMYLQRETOZA5CNFSM4JD6EWWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECTCERQ#issuecomment-547758662,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACBPJT3TTVQNPGDP3GPIIU3QRETOZANCNFSM4JD6EWWA
.


How do you change the calendar layout to vertical mode?

What do you do to change the calendar to scroll vertically?

@RayZhuAU I am looking for the same thing, since you closed this issue, did you find the solution?

@idilgun calendarView.scrollDirection = .vertical

Thanks @patchthecode

@idilgun cool. If this library has saved you months of coding then consider leaving a Star ★ Github rating. It will be greatly appreciated. Cheers 🍻

updated to: calendarView.direction = .vertical
Thanks! I was really about to look for a new pod but I found this answer which solved the problem of vertical scroll :)))

@tungfam thanks. I will update this!!

@patchthecode  is it possible to make the calendar to scroll vertically + continuously (not discretely).
In other words the calendar like standard apple calendar on iOS, where when you scroll vertically it's shows months not discretely but kind of "together". Hope my bad explaination was clear :)

@tungfam Hey I think one thing that could save you a lot of headaches is the tutorials -> https://github.com/patchthecode/JTAppleCalendar
Specifically, the part in the tutorials you are looking for is located here -> https://patchthecode.github.io/CalendarScrolling/
It shows you all the scrolling modes you can do with the library. Is your solution located in there? Let me know.

@patchthecode thanks a lot! that's what was needed :) next time i better go through all tutorials then ask ..

@tungfam haha. its cool man. If you have any further questions, then just ask :)


Added Lithuania to list of Eurozone countries

Lithuania is a member of Eurozone from 1st of January, 2015.
This PR fixes it :)

Coverage remained the same at 83.151% when pulling f6971cb1653cb6dafbb7f371c7be14119eed573a on artisavotins:master into 54c282903e28cf75e3cdb2d6c1c318bb8b956f31 on lsbardel:master.

👍


update gisce/ooui to v2.6.3-alpha.1

Automated changes by create-pull-request GitHub action

:tada: This PR is included in version 2.11.0-alpha.5 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.12.0-alpha.1 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.14.0-alpha.1 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add a curl example command to fetch messages

In the app settings it might be useful for quicker evaluation by providing a auto-generated curl command, similar to the one here on Homebrew or commonly used in GitHub README.

Example command:
curl -H "X-API-Key: 4QvACM53LdzTqABCDEF5MXoIB8uCwmEfRrwRp" https://onlaunch.kula.app/api/v0.1/messages

or as a template:
curl -H "X-API-Key: <API-KEY>" <HOST-SCHEME>://<HOST>/api/v0.1/messages

Closing this, because users will hardly call the API directly but instead use the SDKs


This isn't a global issue, I can successfully connect to other servers and send messages to users on them. According to compliance.conversations.im, the remote server is running Prosody 0.11.
Then when I was checking logs for more errors, I found that a server I can successfully communicate on is also returning the same error occasionally (2019-03-12 01:54:52 💥 [ERR] s2s/server:94 - lookup _xmpp-server._tcp.chat.404.city on <IP_ADDRESS>:53: no such host). The remote server with the intermittent error is running  ejabberd 18.12.1-2~bpo9+1.
Maybe it's something I can tweak in the config? s2s section of jackal.yml is the same as in the example:
s2s:
    dial_timeout: 15
    dialback_secret: s3cr3tf0rd14lb4ck
    max_stanza_size: 131072

    transport:
      bind_addr: <IP_ADDRESS>
      port: 5269
      keep_alive: 600

Also, it looks like I can receive messages from the server that lookup always fails for.

Ok, I did some more debugging, it looks like the error is when it runs net.LookupSRV("xmpp-server", "tcp", "riotcat.org"). Possibly an occurance of this bug.
Other failed debugging to try to get around this bug, as hinted at by comments in the bug linked above:

setting limit of open files to unlimited (/etc/security/limits.conf)
changing to possibly faster dns servers (to decrease chance of timeout, tried google's <IP_ADDRESS> and cloudflare's <IP_ADDRESS>)

It's probably a combination of how the server in question set up its DNS, and how go handles DNS lookups. Not sure if there's a way around this. Besides maybe a hack to try using the system's 'dig' command (if present) if the lookup by net.LookupSRV fails.

Yes, you are right. Right now, if the service fails trying to do the SRV lookup we do not fallback to the standard XMPP port...
https://github.com/ortuman/jackal/blob/master/s2s/dial.go#L31-L40
Thanks for reporting. I'll update the issue as soon as the patch is applied.

This commit should fix the issue...
https://github.com/ortuman/jackal/commit/e7bb957e67ba0664d3517d30f1a48b8cf3dec4f1
Available on master branch, please @waveletlet could you confirm it's working now? Thanks! 🙏

I also talked to the person running the server, and they told me they only set xmpps-client/xmpps-server, to force secure connections as described in XEP-0368, might be good to also try something like d.srvResolve("xmpps-server", "tcp", remoteDomain) for that case (which is probably the preferred case, anyway).

Looks like it works now! But I'm not seeing this warning log.Warnf("srv lookup error: %v", err) in the log, should I be? The remote server admin said they'd add the SRV record so I'm not sure if it'd trigger the error or not anymore. (dig still isn't giving me a SRV record for them, though.)


Display current operation in status bar

Currently, we have a region at the top which displays the current operation.
However, this region is using the "diff" format. For instance, Creation of files are displayed like this:
--- a/dev/null
+++ b/path/to/new/file

It would be better to have a single, more explicit, line:
Creation of `path/to/new/file`

and similarly for other operations: rename, deletion, ...
This requires to replace the string_of_operation function in interactive_viewer.ml into a function that takes a value of type Patch.operation and creates the relevant string from the value.

Hello @panglesd , please assign me to this

Hi @Dezzy12,
Have you been able to setup OCaml and build and run the project ?

I successfully built and tested the tool on some personal sample project initialised with git

Fantastic ! The issue is assigned to you :)

Fixed by #27


Android Basics: Viewmodel and State in Compose

The variable “usedWords” just appear suddenly，don't have any defination previously， either in starter code or  in any introduction before this variable first appear。

The variable “usedWords” just appear suddenly，don't have any defination previously， either in starter code or in any introduction before this variable first appear。

usedWords will be explained later

Thanks , I have been seen that it just as you said. :-)


deny list for Keyboard Manager

Description of the new feature / enhancement
For App-specific shortcuts, I think it should be better that it has a blacklist mechanism allows user to specifies Apps that don't use Keyboard Manger's mapping.
Scenario when this would be used?
I map "ctrl+t" to "win+1", which open the Terminal application. But in some editors, like vscode, idea... I also need "ctrl+t" to open the built-in terminal instead of the Terminal app.
Supporting information
No response

Tweaked title for inclusiveness

There are lots of applications which have their own ways of managing shortcuts (IDEs, Adobe Suite, Excel, ...), so it would be nice to be able to exclude them from the keyboard manager mappings

I agree. I have done some serious remapping, because I want my PC to feel like working on a Mac. But now most games close when I use command+Q (actual keys alt or windows+Q).
Blacklisting would be much handier than whitelisting (a single app)

inclusiveness

Using the search term "is:issue is:open Keyboard Manager exclude", you will find out that people have been asking for this feature for 2.5 years, do you have a plan or a deadline?

/dup #8809


Dependencies does not get copied on Windows machine

Hi, this is my very first bug report, so please go easy on me if I missed any details :)
On my Windows 7 Parallel machine I've got following environment
- ruby 2.0.0p481 (2014-05-08) [i386-mingw32]
- hologram (1.2.0)

Also with actual machine with following environment with exactly same folder structure
- ruby 1.9.3
- hologram (1.2.0)

With following folder structure
Base--
     |-css
     |-scss
     |-js
     |-images

and following config.yml file:
source:
    - ./scss
    - ./js
destination: ./docs
documentation_assets: ./doc_assets
dependencies:
  - ./css
  - ./images

When I run hologram config.yml, i get following warnings:
Warning: Could not copy dependency: ./css
Warning: Could not copy dependency: ./images
Build completed. (-:

Hologram builds fine with _header and _footer and everything seems to be working except for copying folders declared in dependencies
I copied the entire folder to my Mac with following setup and everything worked fine (including dependencies copying):
- ruby 2.0.0p451 (2014-02-24 revision 45167) [universal.x86_64-darwin13]
- hologram (1.2.0)

Not exactly sure what the issue is, maybe something to do with my permission? (I was running command prompt in admin mode) or maybe issue with folder structure?

I am still experiencing this bug with an installation I conducted today. I apologize in advance for my newb comment markdown skills.
Installation process:
Prep work:
On my first attempt to run gem install hologram I received an error pertaining to "redcarpet" so I followed the instructions in the error and:

Went to http://rubyinstaller.org/downloads/
Downloaded https://github.com/downloads/oneclick/rubyinstaller/DevKit-tdm-32-4.5.2-20111229-1559-sfx.exe
Installed according to instructions on https://github.com/oneclick/rubyinstaller/wiki/Development-Kit

After that prep work, I proceeded with the actual install of what I needed:

I ran gem install redcarpet with success.
I ran gem install hologram with success.

Environment:
OS: Windows 7 Pro 64-bit
ruby -v
ruby 1.9.3p55 (2014-11-13) [i386-mingw32]

redcarpet -v
Redcarpet 3.2.2

hologram -v
hologram 1.2.0

Could this be an issue with the version of Ruby I am using?

Can you try the development version of hologram? It should be fixed there (you can use the specific_install gem to aid this (https://github.com/rdp/specific_install). I'm hoping to relase 1.3 today or tomorrow so optionally you could wait until then.

Hi,
I am also seeing this bug,
Running:
Windows 10
ruby 1.9.3p551 (2014-11-13) [i386-mingw32] (with DevKit)
Redcarpet 3.3.4
hologram 1.4.0
I have also tried with running Ruby 2.2.4 (x64 & x86 versions).
Any ideas form me try?
Thanks in advance!


Versions <= 3.2: av_position and av_previous_position capped at maxInt for livestreams

When tracking livestream video plays, AV-Playback-time is always zero, because the timestamps of av_position and av_previous_position options, used to calculate the delta between trackings, are always parsed and handled as int.
Therefore, when both values exceed maxInt, the delta is always zero, resulting in EBVS trackings (AV-Playback-time: 00:00:00.000)

Hi,
If I understand well, you try to use a timestamp as a cursor position. Our processing expects a relative position from the beginning of the playback. Please see our answer there #10
Don't hesitate to get back should you need.


Fallback if animation never starts

Before
If animate.css doesn't load the whole app will not start because animationend is never triggered.
After
animate.css is a nice-to-have, the app will still pretend like the animations are taking place

any reason you changed the duration arg?

setTimeout only takes millis so I just wanna use millis everywhere. Can't pass 1s or 300ms to setTimeout


TAJO-1346: Run ADD PARTITION after storing column partitioned table.

Currently, If new partitions are added to HDFS by ColPartitionStoreExec, CatalogStore will not be aware of these partitions. So, Tajo need to run ALTER TABLE table_name ADD PARTITION on each of the newly added partitions automatically.

Not yet added test cases.

I added unit test cases. For your information, some codes would be removed after finishing TAJO-1345.


Adds support for schema variables

🏭 Adds support for #236. Allows to define variables per schema configuration or per target.
🛑 Requires xcproj PR #227 to be merged.
⚠ Needs reverting a change in Package.swift.
To a future reviewer: thanks in advance, you are awesome! 👍 🍻

Hi @yonaskolb, I did all the requested updates.
Unfortunately, I could not make integration tests pass on my local machine after updating xcproj version to a master one. The tests fail with EXC_BAD_ACCESS with a too deep recursion nest level. This behaviour is reproducible on a master branch with xcproj dependency bumped to master branch of the main repository.

@turekj thanks for highlighting the recursion issue in xcproj. I've fixed it here https://github.com/xcodeswift/xcproj/pull/237
One the next xcproj release is done we can merge this 👍

xxproj 4.1.0 is now released

@turekj, are you able to update the xcproj package, so we can get this merged? If not, or I don't hear back by tomorrow I'll merge and then fix in master 👍

@yonaskolb I will handle that today/tomorrow! 👍

@yonaskolb ready to go! 🎉


Create function to set position and zoom to show all markers

SUMMARY
a google maps api have this function, you pass a array with coordinates and function calculates and set coordinates to show all markers
see about this in this link:
(https://developers.google.com/maps/documentation/javascript/reference/map#Map.fitBounds)
DETAILS
In my job I'm developing a app who use map to show a vehicles' trackers in a map who refresh each 3 minutes, we use a function fitBounds in web application but I'm have problems in app.
thak you :)
PLATFORMS

[x] Android
[x] iOS
[x] UWP

You can use listed code.
Position[] positions = /* your pin's positions */;
Bounds bounds = Bounds.FromPositions(positions);
await map.MoveCamera(CameraUpdateFactory.NewBounds(bounds, 10));

It worked, thank you :)


ClosedGenericMatcher reduced alloc

Is an internal static class that doesn't seem to be referenced except in tests so probably either dead code; or testing code - but for completeness....

Hi @benaadams, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

@benaadams this is a shared source project used in the MVC and Razor repos. Do you have any numbers demonstrating your changes improve performance in a real scenario using at least Razor?

Func<Type, bool> matchesInterface allocates a closure per call to capture Type interfaceType so moved that out into static Func<Type, Type, bool> MatchesInterface
However queryType.GetTypeInfo().ImplementedInterfaces.FirstOrDefault only passes a single argument, hence the need for the closure; so changed the Linq to a foreach.
Its not perfect as its still going to allocate on the ImplementedInterfaces IEnumerable for the foreach as it would have done for the Linq; but I had it hanging around - ok if you take it or leave it.

@benaadams that's not enough for a change here. Does anything about the current implementation show up in a profile using Razor or MVC features that use this code?

I'm guessing its a cached resolve that's once per setup rather than per page/request? So doubtful it would show up in a profile and would be an unneeded optimisation.
If its something that could be called per request though; I can dig a bit deeper...?

Closing as not aware of it being in a hot path.

Just when you think you are safe... someone necroposts!

And we have a player...

No, nothing to see here - move along....
.GetInterfaces() should probably returning a cached Type[] though, but that is elsewhere

@benaadams - we're going to fix this in MVC by not calling into it as often. When in doubt do less work.

Can't cache it further down as array's contents could be altered; which would muck up reflection quite heavily :(
Could static dictionary it; but that would mean it would need to be cleared on any dynamic loading/recomplilation?


Listview scroll event conflicts with FlutterOverlayWindow drag,

I'm having the same issue as well

@Ahmadu-Suleiman @X-SLAYER  Did you solve it？😊

Yeah, I change the overlay flag anytime I want to scroll the list view

@Ahmadu-Suleiman  Can you give us a minimal case？🙏

You just need to set the enableDrag parameter to false, this will remove drag ability but will allow you to scroll your list view, I'm not on my computer to provide a concrete example but you can easily play around with the methods that allow you to change the enableDrag value.


3 features: broadcast more events, add strategy name to the broadcast event.data, add networkTimeoutSeconds to StaleWhileRevalidate

Library Affected:
workbox-strategies
Browser & Platform:
"all browsers".
Issue or Feature Request Description:
Some of our pages use the StaleWhileRevalidate strategy. There does not seem to be a way to specifically request to bypass the cache if we know that the page has changed. In those cases, displaying the cached page for a few seconds before refreshing it with the newly fetched data (using broadcastUpdate) confuses the user who is also not expecting to see old data.

The simplest approach would probably be to purge all of the previously cached responses if you have a way of knowing that they're no longer valid.
For instance, if you use cacheName: 'page-cache' along with your stale-while-revalidate strategy, once you detect that they're no longer fresh, you could use caches.delete('page-cache') to clear everything out. You could run that code from either inside of the service worker, or from the context of your client web app, since the Cache Storage API is exposed on the window object.
Alternatively, you could write a custom plugin that used the cachedResponseWillBeUsed lifecycle method to determine whether a cached response is fresh or not, and return null if you have determined that it's stale. But I think it would be cleaner to just purge everything at the point in time that you determine the previous responses are no longer fresh.
Hopefully that gives you something to go on. I'm going to close this issue, but if there's a reason why those suggestions don't work, we can revisit.

Hello Jeff,
Indeed, when we know that the page has changed, we purge the cache using the Cache Storage API before fetching that url, so that StaleWhileRevalidate has no choice but to fetch from the network and the user does not first see an old cached version.
What happens though if at that moment the device goes offline (I'm in Cambodia where the network is often erratic)? Nothing loads but now things are worse, we removed the cached version so there is nothing left to show (－‸ლ)  !
After thinking about this, I believe that the following could be the answer:

allow strategies to use broadcastUpdate to broadcast more events:

1a.  StaleWhileRevalidate: "I found a cached version" (type: 'CACHE_FOUND')

page displays cached version (or perhaps chooses not to show anything yet)

2a: or StaleWhileRevalidate: "I did find any cached version"  (type: 'CACHE_NOT_FOUND')

StaleWhileRevalidate: "Now, I am trying to fetch an updated version"  (type: 'FETCHING_FROM_NETWORK')

page displays an "updating" banner

3a StaleWhileRevalidate: "I was able to fetch from the network"  (type: 'FETCHING_SUCCESS')

page stops displaying the "updating" banner

3b. or StaleWhileRevalidate: "darn, the network is down!" (type: 'FETCHING_ERROR')

page displays some message i.e "network error, this is a cached version" (and displays the cached version if it was not already displayed in step 1)

if (3a):
4a. StaleWhileRevalidate: "... and I found a cool updated version"  (type: 'CACHE_UPDATED')

page updates content (this one is already possible with broadcastUpdate)

4b: StaleWhileRevalidate does not find anything new. Nothing is broadcasted.
In other words, the feature request is to allow StaleWhileRevalidate, NetworkFirst and CacheFirst to use the broadcastUpdate.Plugin to broadcast more events. Example:
"CACHE_FOUND"
"CACHE_NOT_FOUND"
'FETCHING_FROM_NETWORK"
"FETCHING_SUCCESS"
"FETCHING_ERROR"
"CACHE_UPDATED"

@jeffposnick let me know if it makes sense to open 3 new tickets for this?

Hey @goyavo thanks for the detailed suggestions. I think your use case is totally valid; though, rather than adding a (potentially endless) list of new update events to broadcast, I think we can address this issue in a more generic way by making it easier to customize what data gets sent in the broadcast update plugin as well as making it easier (in general) for code in the SW to talk to the window.
Here are two existing issues that I believe will help address your use case:

Make it easier to customize the broadcast update payload. https://github.com/GoogleChrome/workbox/issues/1878
Make it easier to generically send messages between the SW to the window. https://github.com/GoogleChrome/workbox/issues/1848

What do you think?

Hello @philipwalton,
#1878, indeed sounds like something similar, on the condition that workbox-broadcast-cache-update could start broadcasting events from the very beginning, such as "1a: StaleWhileRevalidate found a cached version" (see my previous timeline), and not only once the newResponse from your example was fetched. Would it really be a endless list of update events? My previous post had 5 new events out of a total of 6 (since CACHE_UPDATED already exists).

Hi there,
Workbox is moving to a new engineering team within Google. As part of this move, we're declaring a partial bug bankruptcy to allow the new team to start fresh. We realize this isn't optimal, but realistically, this is the only way we see it working. For transparency, here're the criteria we applied:

For PRs, we closed everything that doesn't target the current v7 branch.
For Issues, we closed everything that was created before 2024.

Thanks, and we hope for your understanding!
The Workbox team


[FEAT][1/2] Support Iceberg renaming of columns

Summary
Support field_id renaming of Parquet files along the codepath:

IcebergScanOperator
Generates ScanTasks, each containing the field_id_mapping: Arc<{i32: Field}>
Propagated to workers through the ScanWithTask instruction object
Micropartitions are created with MicroPartition::from_scan_task
This then calls into read_parquet_into_micropartition
a. If statistics are available, it will create an unloaded MicroPartition by creating a new ScanTask (hydrated with statistics) and then calling MicroPartition::new_unloaded(new_scan_task).
b. Otherwise, it falls back into read_parquet_bulk, which has been modified to correctly handle field_id_mapping

This PR ensures that when data/statistics are read from Parquet files, we correctly apply renaming according to field_id_mapping.
Reviewer Notes
A lot of the errors caught/triggered by this PR has to do with mismatches between the fields (names/metadata) on our schemas and on our Series objects.
Keeping those two in sync is fairly challenging with the way our code is currently structured.
The approach taken to try and fix this is:

Try to use the same logic for field_id renaming across Series and Schemas
When reading data from Parquet -> arrow2 -> Daft Series/Schema, perform a post-processing step to remove any field metadata that was retrieved from the Parquet files.

However I do think that this is a fairly error-prone situation. Not sure what the best approach is though.
Drive-By
Refactors to clean-up MicroPartitions/ScanTasks and schemas:

Refactored MicroPartition::new_unloaded: it no longer accepts a schema argument; instead internally it will just use the ScanTask's .materialized_schema()
Refactored read_parquet_into_micropartition to significantly reduce code deduplication

Remaining todos:

[x] Fix logic with column pruning (need to apply column pruning after applying the field ID mappings)
[x] Perform correct renaming for statistics parsing from Parquet metadata
[x] Perform recursive renaming for Series and for Schema

Closing in favor of better approach in https://github.com/Eventual-Inc/Daft/pull/1990


Implement Subscriptions

Implement the concept of a subscription to a pipe. Pipes can support any number of subscriptions. Entities, and other processors, may subscribe to a subscription. This corresponds roughly to a consumer group in Kafka.

Connectors have replaced pipes and pipes are direct connections between inlets and outlets. This fact implies a subscription. The model does not need to have subscriptions as we regard that as an implementation details. Not all streaming mechanisms use the concept.


convert largefileupload to tsx

Part of overall transition to ts

I converted largefileupload file to tax but I'm not exactly sure what it is for. If it's for ing-models, for some reason I can't choose the img-models tab because something seems to be wrong with Transforms.js


chore(main): release 0.16.0

:robot: I have created a release beep boop
0.16.0 (2023-04-10)
Features

intro: 完善 {\app 的意义} & {相关技术与应用现状} (a90ce6f)

Bug Fixes

intro: correct ref (2a93d14)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/CCXXXI/thesis/releases/tag/v0.16.0 :sunflower:


Fix typo

Duplicate # in color definition.

thanks for the PR. I probably need to do another scrub through for things like that!


Add rate-limiter to the login endpoint

Closes #711
To test, build locally and run your any of your Pelican server and go to https://<hostname>:<port>/view/login/index.html
Hit Confirm button without typing any username. If you hit it slowly (not double click), then you should get 400 error. If you double-click or triple click, then you should get 429 error indicating too many requests.

Could you switch to golang.org/x/time/rate perhaps?  I was planning on using it elsewhere:
https://github.com/PelicanPlatform/pelican/pull/705/files#diff-4f90d3c881e24d44c38cce40e200654acfd79622cf17bea2fd7b557aa9c58bc1R49-R62
Avoids the redis dependency.

@bbockelm It should be doable to use golang.org/x/time/rate but gin-rate-limit is more flexible as it limits the rate by a key per request (IP in our case). I didn't find the built-in rate package to have the equivalent which means we need to build the key support ourselves.

Gotcha.  How much larger does the binary become with this new dependency?

Gotcha. How much larger does the binary become with this new dependency?

The size of the built binary didn't seem to change. It's 42.1MB for both main branch and my feature branch. But the size seems to be doubled compared to the 7.5.0 release artifact.


Tweak line wrappings in two recent blogs

Only tweaked long lines in these 2 blogs:
content/en/blog/_posts/2023-01-05-retroactive-default-storage-class.md
content/en/blog/_posts/2023-02-06-k8s-gcr-io-freeze-announcement.md

/approve


Rendering PDF via wkhtmltopdf

After setting DIV dimensions and adding the webtoolkit prototype hack, it renders a PDF, but all characters and vector segments are rendered over each other at the upper left corner of the DIV. Any idea how to fix this? Thanks a lot...
Code used:
Function.prototype.bind = Function.prototype.bind || function (thisp) {
    var fn = this;
    return function () {
        return fn.apply(thisp, arguments);
    };
};

var data = {
  labels: ['Mon', 'Tue', 'Wed', 'Thu', 'Fri'],
  series: [
    [5, 2, 4, 2, 0]
  ],
  width: 800,
height: 150,
};

new Chartist.Line('#chart', data);

Did you ever figure out? @tkubec


Be able to select agent queue with matrix, similar way as container

Provide a way to select agent queues with matrix the same way as containers described here:
Container jobs - Multiple jobs
Use case - I have .NET Core library that needs to be built and tested on all platforms - Windows, Linux & Mac. Right now I can solve it with Job reuse with parameters but I think matrix would be more "natural" and less verbose way to do that
Moved from here: #1815

We're working on adding this scenario soon. Next one or two sprints. Our sprints are 3-weeks long, and then take another 3 weeks to roll out to all accounts.

@vtbassmatt fyi, a request for multi-job

@VasiliyNovikov
Agreed.  Just tried to do the same thing myself.   A 'matrix variable' seems to be visible or usable everywhere but when used with vmImage...

@MSP-Greg we're fixing that now. We're moving strategy expansion earlier in the process so that it can be used with vmImage.

@vtbassmatt: Do you know when this new behavior should be live?  Is there an open issue tracking this work (this issue was closed 17 days ago)?

It slipped into this sprint, and we have 2 more weeks to go. Then it will start rolling out across the service.

@vtbassmatt: Would it make sense to re-open the issue until the fix is deployed?

We use these issues to discuss and track work remaining on our team. Deployments are provided for us, so there's not a lot of value in keeping a bug around waiting for that. Arguably we closed this one too early since we hadn't yet committed the code, which is leading to the extremely long delay between "issue closed" and "fix observable in practice". We'll try to be more diligent about that.

It's rolling out this week and into next.


Please help me to solve the following error problem.  Can you write more than 64 characters in OpenSSL command?  I get the following error: problems making Certificate Request<PHONE_NUMBER>416:error:0D07A097:asn1 encoding routines:ASN1_mbstring_ncopy:string too long:a_mbstr.c:158:maxsize=64

Reproduction Steps

Error Log

Environment

CDK CLI Version      :
CDK Framework Version:
RFDK Version:
Deadline Version:
Node.js Version:
OS               :
Language (Version):

Other

This is :bug: Bug Report

Duplicate of: https://github.com/aws/aws-rfdk/issues/1039


Updated to 5 and it broke our conversions

We had to roll back and looking at the changes and breaking changes I did not see anything that would ruin what we were doing.
sh "json2csv -i some-data.json -c some-fields.json -o some-data.csv"
What ends up happening is we get an error saying that the format on the fields.json is wrong then if we use -f flag to try and work around it that will work but im curious why it would complain and the version 4.5.4 is fine.
Here is what is in the fields.json
[
  "Name",
  "Id",
  "AppID-Tag"
]

Using --config the json of the config should be
{
  "fields: [
    "Name",
    "Id",
    "AppID-Tag"
  ]
}

Good to know thanks. You might add that snip on the readme as a complete config sample. Ill try this.

Closing since it has been answered.
Feel free to reopen if there is anything else.


Removed ambient color from point light

Fixes #642

SonarQube analysis reported 15 issues

 3 major
 11 minor
 1 info

Top 10 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 ScriptManager.cpp#L647: Memory leak: value
 ScriptManager.cpp#L651: Memory leak: value
 ScriptManager.cpp#L655: Memory leak: value
 AncientFungus:LGEPR: Cppcheck cannot find all the include files (use --check-config for details)
 RenderManager.cpp#L332: Variable 'name' is assigned a value that is never used.
 RenderManager.cpp#L342: The function 'GetAnimations' is never used.
 RenderManager.cpp#L360: The function 'GetDirectionalLights' is never used.
 RenderManager.cpp#L399: The function 'GetMaterials' is never used.
 RenderManager.cpp#L417: The function 'GetMeshes' is never used.
 RenderManager.cpp#L437: The function 'GetPointLights' is never used.


[fr]Remove on-premises-vm section

Ref: https://github.com/kubernetes/website/pull/23500
/kind cleanup

/lgtm
/approve


Some references to files are missing in stack trace when browser.wait is used.

Stacktrace is not having the reference to actual file name from where the error is triggered for the protractor.

Version: 4.2.1
Protractor version: 5.1.2

Spec reporter configuration:
jasmine.getEnv().addReporter(new SpecReporter({spec: {displayStacktrace: true,}}));
Sample spec:
it('Protractor stacktrce issue', async () => {     const helper = new SearchHelper();     await helper.doSearch('test'); });
search-helper.ts:
async doSearch(text) {     await browser.get('http://google.com');     await browser.wait(EC.visibilityOf(element(by.name('q1'))), 10000, 'No Element found');     await element(by.name('q1')).click(); //invalid locator   }
1. Stack trace:
✗ Protractor stack trace issue       - Failed: No Element found       Wait timed out after 10007ms       Wait timed out after 10007ms           at WebDriverError (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/error.js:27:5)           at TimeoutError (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/error.js:238:5)           at /usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/promise.js:2107:17           at process._tickCallback (internal/process/next_tick.js:109:7)       From asynchronous test:        Error           at Suite.<anonymous> (/Users/e2e/sample-spec.ts:27:3)           at Object.<anonymous> (/Users/e2e/sample-spec.ts:15:1)           at Module._compile (module.js:570:32)           at Module.m._compile (/Users/node_modules/ts-node/src/index.ts:392:23)           at Module._extensions..js (module.js:579:10)           at Object.require.extensions.(anonymous function) [as .ts] (/Users/node_modules/ts-node/src/index.ts:395:12)
2. If we comment browser.wait statement then the stacktrace is
✗ Protractor stack trace issue       - Failed: No element found using locator: By(css selector, *[name="q1"])           at WebDriverError (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/error.js:27:5)           at NoSuchElementError (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/error.js:168:5)           at elementArrayFinder.getWebElements.then (/usr/local/lib/node_modules/protractor/lib/element.ts:851:17)           at process._tickCallback (internal/process/next_tick.js:109:7)Error           at ElementArrayFinder.applyAction_ (/usr/local/lib/node_modules/protractor/lib/element.ts:482:23)           at ElementArrayFinder.(anonymous function) [as click] (/usr/local/lib/node_modules/protractor/lib/element.ts:96:21)           at ElementFinder.(anonymous function) [as click] (/usr/local/lib/node_modules/protractor/lib/element.ts:873:14)           at SearchHelper.<anonymous> (/Users/e2e/search-helper.ts:14:34)           **at step (/Users/e2e/search-helper.ts:32:23)           at Object.next (/Users/e2e/search-heper.ts:13:53)           at fulfilled (/Users/e2e/search-helper.ts:4:58)**           at process._tickCallback (internal/process/next_tick.js:109:7)       From asynchronous test:        Error           at Suite.<anonymous> (/Users/e2e/sample-spec.ts:27:3)           at Object.<anonymous> (/Users/e2e/sample-spec.ts:15:1)           at Module._compile (module.js:570:32)           at Module.m._compile (/Users/node_modules/ts-node/src/index.ts:392:23)           at Module._extensions..js (module.js:579:10)           at Object.require.extensions.(anonymous function) [as .ts] (/Users/node_modules/ts-node/src/index.ts:395:12)
Observe the 2nd stack trace, it has references to search-helper file but it's not there in the first stack trace. It's very important to have this reference in stack trace for debugging.

This issue seems related to protractor and not jasmine-spec-reporter.
Can you try both of your cases without jasmine-spec-reporter in order to validate or invalidate this hypothesis?

@bcaudan Ok, without spec reporter I don't see any stack trace at all. But I see the same issue if I  remove spec reporter and used jasmine console reporter. Seems it's not the issue with spec reporter. Thanks.


Update MD file on new branch 2017-11-10_13-26-58

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/content1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Invalid operators, but with ALL operators

All my expressions (on Windows) throw the "Invalid operator" exception and I can't figure out why. Here's the error:
`C:\msys64\mingw64\bin\g++.exe -fdiagnostics-color=always -g C:\Users\Jg_747\iCloudDrive\Desktop\Progetti\Pseudo\Current\Pseudo.cpp -o C:\Users\Jg_747\iCloudDrive\Desktop\Progetti\Pseudo\Current\Pseudo.exe
In file included from C:\Users\Jg_747\iCloudDrive\Desktop\Progetti\Pseudo\Current\cparse/builtin-features.inc:27,
from C:\Users\Jg_747\iCloudDrive\Desktop\Progetti\Pseudo\Current\Pseudo.cpp:43:
C:/Users/Jg_747/iCloudDrive/Desktop/Progetti/Pseudo/Current/cparse/builtin-features/functions.inc: In function 'cparse::packToken builtin_functions::default_type(cparse::TokenMap)':
C:/Users/Jg_747/iCloudDrive/Desktop/Progetti/Pseudo/Current/cparse/builtin-features/functions.inc:104:8: error: reference to 'INT' is ambiguous
104 |   case INT: return "integer";
|        ^~~
In file included from C:\Users\Jg_747\iCloudDrive\Desktop\Progetti\Pseudo\Current\Pseudo.cpp:38:
C:\Users\Jg_747\iCloudDrive\Desktop\Progetti\Pseudo\Current\cparse/shunting-yard.h:38:3: note: candidates are: 'cparse::tokType cparse::INT'
38 |   INT = 0x22,   // == 0x20 + 0x2 => Integral numbers.
|   ^~~
In file included from C:/msys64/mingw64/x86_64-w64-mingw32/include/minwindef.h:163,
from C:/msys64/mingw64/x86_64-w64-mingw32/include/windef.h:9,
from C:/msys64/mingw64/x86_64-w64-mingw32/include/windows.h:69,
from C:/msys64/mingw64/x86_64-w64-mingw32/include/rpc.h:16,
from C:/msys64/mingw64/x86_64-w64-mingw32/include/urlmon.h:7,
from C:\Users\Jg_747\iCloudDrive\Desktop\Progetti\Pseudo\Current\Pseudo.cpp:35:
C:/msys64/mingw64/x86_64-w64-mingw32/include/winnt.h:289:15: note:                 'typedef int INT'
289 |   typedef int INT;
|               ^~~
In file included from C:\Users\Jg_747\iCloudDrive\Desktop\Progetti\Pseudo\Current\cparse/builtin-features.inc:27,
from C:\Users\Jg_747\iCloudDrive\Desktop\Progetti\Pseudo\Current\Pseudo.cpp:43:
C:/Users/Jg_747/iCloudDrive/Desktop/Progetti/Pseudo/Current/cparse/builtin-features/functions.inc:105:8: error: reference to 'BOOL' is ambiguous
105 |   case BOOL: return "boolean";
|        ^~~~
In file included from C:\Users\Jg_747\iCloudDrive\Desktop\Progetti\Pseudo\Current\Pseudo.cpp:38:
C:\Users\Jg_747\iCloudDrive\Desktop\Progetti\Pseudo\Current\cparse/shunting-yard.h:39:3: note: candidates are: 'cparse::tokType cparse::BOOL'
39 |   BOOL = 0x23,  // == 0x20 + 0x3 => Boolean Type.
|   ^~~~
In file included from C:/msys64/mingw64/x86_64-w64-mingw32/include/windef.h:9,
from C:/msys64/mingw64/x86_64-w64-mingw32/include/windows.h:69,
from C:/msys64/mingw64/x86_64-w64-mingw32/include/rpc.h:16,
from C:/msys64/mingw64/x86_64-w64-mingw32/include/urlmon.h:7,
from C:\Users\Jg_747\iCloudDrive\Desktop\Progetti\Pseudo\Current\Pseudo.cpp:35:
C:/msys64/mingw64/x86_64-w64-mingw32/include/minwindef.h:131:15: note:                 'typedef int BOOL'
131 |   typedef int BOOL;
|               ^~~~
In file included from C:\Users\Jg_747\iCloudDrive\Desktop\Progetti\Pseudo\Current\cparse/builtin-features.inc:29,
from C:\Users\Jg_747\iCloudDrive\Desktop\Progetti\Pseudo\Current\Pseudo.cpp:43:
C:/Users/Jg_747/iCloudDrive/Desktop/Progetti/Pseudo/Current/cparse/builtin-features/operations.inc: In constructor 'builtin_operations::Startup::Startup()':
C:/Users/Jg_747/iCloudDrive/Desktop/Progetti/Pseudo/Current/cparse/builtin-features/operations.inc:362:28: error: reference to 'BOOL' is ambiguous
362 |     opMap.add({UNARY, "!", BOOL}, &UnaryNotOperation);
|                            ^~~~
In file included from C:\Users\Jg_747\iCloudDrive\Desktop\Progetti\Pseudo\Current\Pseudo.cpp:38:
C:\Users\Jg_747\iCloudDrive\Desktop\Progetti\Pseudo\Current\cparse/shunting-yard.h:39:3: note: candidates are: 'cparse::tokType cparse::BOOL'
39 |   BOOL = 0x23,  // == 0x20 + 0x3 => Boolean Type.
|   ^~~~
In file included from C:/msys64/mingw64/x86_64-w64-mingw32/include/windef.h:9,
from C:/msys64/mingw64/x86_64-w64-mingw32/include/windows.h:69,
from C:/msys64/mingw64/x86_64-w64-mingw32/include/rpc.h:16,
from C:/msys64/mingw64/x86_64-w64-mingw32/include/urlmon.h:7,
from C:\Users\Jg_747\iCloudDrive\Desktop\Progetti\Pseudo\Current\Pseudo.cpp:35:
C:/msys64/mingw64/x86_64-w64-mingw32/include/minwindef.h:131:15: note:                 'typedef int BOOL'
131 |   typedef int BOOL;
|               ^~~~
In file included from C:\Users\Jg_747\iCloudDrive\Desktop\Progetti\Pseudo\Current\cparse/builtin-features.inc:29,
from C:\Users\Jg_747\iCloudDrive\Desktop\Progetti\Pseudo\Current\Pseudo.cpp:43:
C:/Users/Jg_747/iCloudDrive/Desktop/Progetti/Pseudo/Current/cparse/builtin-features/operations.inc:362:14: error: cannot convert '' to 'cparse::opSignature_t'
362 |     opMap.add({UNARY, "!", BOOL}, &UnaryNotOperation);
|     ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from C:\Users\Jg_747\iCloudDrive\Desktop\Progetti\Pseudo\Current\Pseudo.cpp:38:
C:\Users\Jg_747\iCloudDrive\Desktop\Progetti\Pseudo\Current\cparse/shunting-yard.h:360:32: note:   initializing argument 1 of 'void cparse::opMap_t::add(cparse::opSignature_t, cparse::Operation::opFunc_t)'
360 |   void add(const opSignature_t sig, Operation::opFunc_t func) {
|            ~~~~~~~~~~~~~~~~~~^
La compilazione è terminata con errore/i.`

I am assuming this issue is related to the other one, that you informed me that is already solved. So I will close this one too.
If this is not the case feel free to ask me to reopen it.


Escape cell delimiters in regexp on cops naming page

To use a cell delimiter in a table cell as a literal character, it must always be escaped.

Hmm, that's going to be tricky - the docs about config are auto-generated from the yaml configuration file, but if we change this there it would break the regexp.

Another option you have is to change the table cell delimiter/separator to something that won't conflict or use an attribute reference. See https://docs.asciidoctor.org/asciidoc/latest/tables/data-format/#escape-the-cell-separator

Thanks for the information. I've opened https://github.com/rubocop/rubocop/pull/11135 to update documentation generator with [separator=¦].

Superseded by #11135.


List functions and test cases

#122
Refreshing debugger text editor content when the window is activated

award lock9 200 points

https://neoscan.io/transaction/d04f6a252c11c952b350305868684f86e369da5fac38ffad2a71dc44b6491e8b


Have an export to pandas option

This would mostly be straightforward.
For examples of how to do the charts within pandas dataframe, see https://twitter.com/jonathanrlarkin/status/1503591106939867137?s=11 and https://twitter.com/jonathanrlarkin/status/1503591106939867137?s=11.
See also the plottable package

This doesn't make sense for the structure of the data.


Make azimuth user own the /data volume

Tested with local build, works:
azimuth@ws-2-workstation:~$ ls -ld /data/
drwxr-xr-x 4 azimuth azimuth 4096 Feb 22 15:46 /data/
azimuth@ws-2-workstation:~$


VisualScript callable nodes not getting updated- Fix

Fixes #37173
Bug:- VisualScript callable nodes were not getting updated when the properties
of their corresponding visualscript function nodes were changed.
Reason:- method_cache of the callable nodes was not getting updated when their corresponding function node was updated.
Based on PR:-  #37872
In this PR, I've refactored the code, making it easier to debug.
Results:

@theoway
Am I missing something? I do not see a difference between PR37872 and this PR

@theoway
Am I missing something? I do not see a difference between PR37872 and this PR

Both are same. I had actually closed the first PR by mistake, that's why made this one.

Closing as we just removed VisualScript for 4.0, so this can no longer be evaluated as is.
The VisualScript module has been moved to https://github.com/godotengine/godot-visual-script with the aim that it might be ported to a GDExtension if there are interested contributors to do so. Further work to improve the features could be done on that repository too (so currently there isn't anyone dedicated to maintain this repository, it will depend again on whether some contributors step up to do so).


C# client, also get JSON string

Is there a way to also get the JSON string besides the deserialized object?

I cannot see how this would be possible. Would a change like this be a solution for this?
https://github.com/stigc/NSwag/commit/8a7d0bf4f9bff0282b2832dc2859ca245022098a

Or maybe ProcessResponse(client_, response_); should be move to after the content has been buffered as a string and then responseData_ should be provided as well.
ProcessResponse(client_, response_, responseData_)

There is no easy way to do this (e.g. no setting) but maybe you can do this by overwriting templates and stripping away lots of features:
https://github.com/RSuter/NSwag/wiki/Templates

IMO it should be possible out of the box. The purpose is for logging where it would be nice to have the original JSON,

Yes I still need the POCOs and then have the plain JSON for logging.
Moving the partial function call ProcessResponse to the point where the client has the JSON string makes sense to me.

Ref: https://github.com/RSuter/NSwag/issues/1333
Would be good if we also support base class

Yes or just make it as callbacks on an interface. To start with could we make a ProcessResponse partial function after the JSON string is buffered?


Precompile the library to CommonJS.

Trying to run tests with Jest doesn't work after importing foundation-sites on the component.
#2937

👍  on this.

The change made in #10864 doesn't fix the referenced create-react-app issue (facebook/create-react-app#2937) - The problem is with the jQuery import (import $ from jQuery';).
To recreate:

Create a react app with the standard commands:

npx create-react-app my-app
cd my-app
npm start

Add a reference to the develop branch of foundation-sites in package.json:

yarn add zurb/foundation-sites#develop

Edit src\App.js and add the following:

import { Foundation } from "foundation-sites/js/foundation.core";

run yarn test. output is as follows:

 FAIL  src\App.test.js
  ● Test suite failed to run

    C:\Users\bob.walker\dev\my-app\node_modules\foundation-sites\js\foundation.core.js:3
    import $ from 'jquery';
    ^^^^^^

    SyntaxError: Unexpected token import

      at new Script (vm.js:51:7)
      at Object.<anonymous> (src/App.js:4:19)

Test Suites: 1 failed, 1 total
Tests:       0 total
Snapshots:   0 total
Time:        5.685s
Ran all test suites related to changed files.

Changing all the imports in the foundation source (under my app's node_modules) to import {$} from jQuery; fixes it for me, but I tried forking and making this change in the foundation-sites project, but I get test failures that I don't get before the change. Happy to investigate further if someone can provide guidance?

@bobwalker99 foundation-sites/js/foundation.core is the source file and will always be in ES6+. Please use the following instead to import Foundation from the precompiled dist file:
import { Foundation } from 'foundation-sites';

Or to get the core only:
import { Foundation } from 'foundation-sites/dist/js/plugins/foundation.core';

I don't see how using import {$} from jQuery; would fix anything.


Increase ATX limits again

Motivation
With Epoch 13 we expect the number of ATXs to increase above our limits again. This update ensures that nodes can still process the data.
Changes

increased limits to handle more ATXs

Test Plan
n/a
TODO

[x] Explain motivation or link existing issue(s)
[x] Test changes and document test plan
[x] Update documentation as needed
[x] Update changelog as needed

bors merge

bors merge


[🐛 Bug] Experiencing a website timeout for https://jraph.readthedocs.io/en/latest/.

Expected behavior
The link to jraph's documentation should take me to a Read the Docs website.
Experienced behavior
Unfortunately, am bouncing between a timeout and an HTML-only formatted version of the docs. 😞

Hey Paige,
I am not able to replicate this - would you be able to check again now?


ESM modules in monaco-editor-core don't have source maps

Is it expected? Debugging ts code in the dev tools would be nice.

same problem


time literals can now mix units

https://github.com/influxdata/influxdb/pull/6597
Probably should update some examples to use this, nothing urgent.

Database management page

Not always valid:
> create retention policy bargle on mydb duration 3d4h replication 1 shard duration 2h
ERR: error parsing query: found 4h, expected REPLICATION at line 1, char 51

Form a 1.0 cluster

not always valid, so closing.


Typo in mongodb-sink.properties file leads to BadRequest exception

In the mongodb-sink.properties file the KCQL configuration parameter is connect.mongo.sink.kqcl instead of connect.mongo.sink.kcql. This leads to a BadRequest exception.

@leschekhomann can you open a PR?

@andrewstevenson Done.


Loading fails on STM32F0

I use st-util with a GCC toolchain on eclipse and when I try to load the program to the board (STM32F0 Discovery) it fails. I have to unplug the USB cable then restart the uploading and after that it works perfectly. I used to use st-util with STM32F103/107 devices without any problem so it should be a compatibility issue with this specific hardware. Here is what I get when it fails :
2013-05-17T14:44:58 INFO src/stlink-common.c: Loading device parameters....
2013-05-17T14:44:58 INFO src/stlink-common.c: Device connected is: F0 device, id 0x20006440
2013-05-17T14:44:58 INFO src/stlink-common.c: SRAM size: 0x2000 bytes (8 KiB), Flash: 0x8000 bytes (32 KiB) in pages of 1024 bytes
2013-05-17T14:45:01 INFO src/stlink-common.c: Attempting to write 1024 (0x400) bytes to stm32 address: 134217728 (0x8000000)
Chip ID is 00000440, Core ID is  0bb11477.
KARL - should read back as 0x03, not 60 02 00 00
init watchpoints
Listening at *:4200...
GDB connected.
recv: qSupported:qRelocInsn+
query: Supported;qRelocInsn+
send: PacketSize=3fff;qXfer:memory-map:read+
recv: Hg0
send:
recv: ?
send: S05
recv: Hc-1
send:
recv: qC
send:
recv: qAttached
query: Attached;
send:
recv: qOffsets
query: Offsets;
send:
recv: g
send: 00000000dc000020dc0000200a000000e80100200a0000000044014001000000004801402f000000ffffffffffffffff03000000100f00201953000836370008
recv: qXfer:memory-map:read::0,fff
query: Xfer;memory-map:read::0,fff
Xfer: type:memory-map;op:read;annex:;addr:0;length:4095
send: m<?xml version="1.0"?><!DOCTYPE memory-map PUBLIC "+//IDN gnu.org//DTD GDB Memory Map V1.0//EN"     "http://sourceware.org/gdb/gdb-memory-map.dtd"><memory-map>  <memory type="rom" start="0x00000000" length="0x8000"/>  <memory type="ram" start="0x20000000" length="0x2000"/>  <memory type="flash" start="0x08000000" length="0x8000">    <property name="blocksize">0x400</property>  </memory>  <memory type="ram" start="0x40000000" length="0x1fffffff"/>  <memory type="ram" start="0xe0000000" length="0x1fffffff"/>  <memory type="rom" start="0x1fffec00" length="0xc00"/>  <memory type="rom" start="0x1ffff800" length="0x10"/></memory-map>
recv: qXfer:memory-map:read::27a,d85
query: Xfer;memory-map:read::27a,d85
Xfer: type:memory-map;op:read;annex:;addr:634;length:3461
send: l
recv: m8003736,4
send: 102df9d1
recv: m20000f00,40
send:<PHONE_NUMBER>53000838370008250000810200000015000000540f0020533f000800e100e0f9ffffff00440140010000000000000000e100e003000000f9380008
recv: qTStatus
query: TStatus;
send:
recv: qfThreadInfo
query: fThreadInfo;
send:
recv: qL1200000000000000000
send:
recv: qRcmd,72657365742068616c74
query: Rcmd,72657365742068616c74;
KARL - should read back as 0x03, not 60 02 00 00
init watchpoints
Rcmd: reset
send: OK
recv: vFlashErase:08000000,00005c00
FlashErase: addr:08000000,len:5c00
send: OK
recv: vFlashWrite:8000000:
binary packet 196 -> 196
send: OK
recv: vFlashWrite:80000c8:µL}x
binary packet 16347 -> 16104
send: OK
recv: vFlashWrite:8003fb0:h    êI
h
íKhêI
h
íKhê
binary packet 6590 -> 6488
send: OK
recv: vFlashWrite:8005908:Ò
binary packet 4 -> 4
send: OK
recv: vFlashWrite:800590c:…
binary packet 4 -> 4
send: OK
recv: vFlashWrite:8005910:
binary packet 316 -> 316
send: OK
recv: vFlashDone
flash_do: block 08000000 -> 5c00
flash_do: page 08000000

Flash page at addr: 0x08000000 erased2013-05-17T14:45:01 INFO src/stlink-common.c: Finished erasing 1 pages of 1024 (0x400) bytes
2013-05-17T14:45:01 INFO src/stlink-common.c: Starting Flash write for VL/F0 core id
2013-05-17T14:45:01 INFO src/stlink-common.c: Successfully loaded flash loader in sram
2013-05-17T14:45:09 ERROR src/stlink-common.c: flash loader run error
2013-05-17T14:45:09 ERROR src/stlink-common.c: run_flash_loader(0x8000000) failed! == -1
cannot recv: -2

send: E00
recv: qL1200000000000000000
send:
recv: m20000f00,40
send:<PHONE_NUMBER>53000800000020250000210200000015000000540f0020533f000800e100e0f9ffffff00440140010000000000000000e100e003000000f9380008

Could this be verified if it works now with v1.2.0 or from master ?

Closing due to inactivity of original issuer. Feel free to open a new issue if the problem exists with v1.2.0 or current master. Thank you for your contribution.

This still remains unverified.

@bacam and @lestofante: May I ask you for some help to verify this is working since release v1.2.0? I am currently reviewing old issues and leftovers to ensure proper solutions have been found and that tickets can be allocated to the correct milestones.

Unfortunately my board is in a building that's closed for the foreseeable future.

Thx for replying. No problem. We can come back to it at a later time should there be no alternative to it.

Fixed in commit 079a154f5f78c66a16653e62cfdf8674d9b34d90 which added support for this board type.

@bacam: No further help needed anymore, as I found the related fix.
The problem of lestofante is something different not related to this topic.


Only one module directory can be specified

I want to exclude node_modules directories in current directory and parent directory. But only one  directory can be specified.

Version 2 supports additionalModuleDirs as an option


Large amount of queries in wagtail admin

Issue Summary
I have noticed that sometimes wagtail admin is very slow when DEBUG=True. Quick look into django-debug-toolbar shows hundreds of queries.
Steps to Reproduce

Install wagtail with debug_toolbar
Add simple custom Page into models.py

    class MyPage(Page):
          pass

Run server
Open wagtail admin and create MyPage
Save MyPage and open edit view again  - you will see around 60 SQL queries in the debug_toolbar
Submit for moderators approvals and then open page in edit view - now you will see around 400 queries

I have confirmed that this issue can be reproduced as described on a fresh Wagtail project: Yes

Technical details

Python version:  3.8.2.
Django version:  3.1.6.
Wagtail version: 2.12.

Short investigation showed that function current_workflow_state is called few hundreds times.
For example function current_workflow_task_state trigger function current_workflow_state 4 times per one call.
If I wrap current_workflow_task in cached_property decorator then number of queries goes down to 60.
Is it known issue? Shell I send a PR?

I wonder if this is something that recently got worse?  I just noticed it as well and put in this PR #6878

Hi @dest81
This is a good note, thanks for bringing this up.
So this is going to largely depend on the page you're viewing. If you're viewing the Images section (listing page) with 100 images per page, that's going to get very costly very quickly (especially when running renditions against each one for the first time).
Likewise, on views that list lots of pages, or semi-custom views like using Wagtails ModelAdmin where you can define your own fields, this can get expensive as well.
Middleware and context processors can play a role in adding queries as well.
On a fresh install with ~100 pages and ~100 images and ~100 documents (any number is fine to test) are you still seeing 100's of database queries? Or is this only on an existing installation?

Hi @KalobTaulien,
This is on fresh installed instance. I added simple custom page model (without images) into models.py and create one object of it. Issue I am talking about can be seen only if you open EditPage view and page is submitted for moderators approvals.
So it's not about list view, that's why I found it very strange. @femto113 PR would work, I was going to send similar.
I think it is safe to use cached_property as page is not going to be change during opening in edit mode.
However maybe you want to know what is calling 400 times current_workflow_task function...
I didn't spend too much time investigating it as I wasn't sure it is unknown issue.
As I wrote in the description function current_workflow_task_state
triggers four times so if we improve it number of queries will be 3 times lower. But it won't make sense if we will use cached_property decorator with current_workflow_task.

My first guess would be the reference in PagePermissionsTester.page_locked, it wouldn't surprise me if it gets touched a lot by various pieces of the UI deciding which controls to show
https://github.com/wagtail/wagtail/blob/e05081a1abe0f98666f3c8702265ce38c811a0e5/wagtail/core/models.py#L3313

Maybe became a (bigger) issue with this commit? https://github.com/wagtail/wagtail/commit/f4a1467b7e38a1571ba94f68923bd66229640030

@femto113 Out of interest, do you see any improvement after disabling the debug_toolbar.panels.templates.TemplatesPanel panel from django-debug-toolbar? You can do this using the DEBUG_TOOLBAR_PANELS setting.

@ababic I don't have the debug toolbar enabled (or even installed).

Fixed in b215573 + parents via #6946. Thank you all!


Any support available on oracle db connect?

Actually no and it's not plan today.

Not planned in 2020 ?

please add support for oracle.

Technically speaking, this is not the concern of Strapi. Bookshelf relies on Knex, and Knex does support Oracle. However, you will have to be a little bit creative.
First, you will have to install the Oracle Client:
# yarn add oracledb

Then, you will have to patch node_modules\strapi-connector-bookshelf\lib\knex.js:
*** knex.js     2020-09-18 19:04:57.901164900 +0800
--- "knex copy.js"      2020-09-18 19:06:01.012209000 +0800
***************
*** 19,26 ****
    'mysql2',
    'sqlite3',
    'mariasql',
!   'oracle',
!   'strong-oracle',
    'mssql',
  ];

--- 19,25 ----
    'mysql2',
    'sqlite3',
    'mariasql',
!   'oracledb',
    'mssql',
  ];

***************
*** 98,103 ****
--- 97,103 ----
              ssl: _.get(connection.settings, 'ssl', false),
              timezone: _.get(connection.settings, 'timezone', 'utc'),
              filename: _.get(connection.settings, 'filename', '.tmp/data.db'),
+             connectString: _.get(connection.settings, 'host'),
            },
            ...connection.options,
            debug: _.get(connection.options, 'debug', false),

But consider that the CTO of Strapi, aka @lauriejim, was so pissed about adding Oracle support, so I assume he had some beef with Oracle before. Based on that, I doubt even if I tried to submit a PR he will immediately close it anyway.
If you do not want to modify the source code manually everytime, you can also 1. map oracledb dependency to oracle using symlink or 2. make a postinstall script to patch it automatically. If you go approach 1, make sure to not use the settings under connector but instead do it like this:
module.exports = ({ env }) => ({
  defaultConnection: "default",
  connections: {
    default: {
      connector: "bookshelf",
      settings: {
        client: "oracle" // ONLY IF you use the dependency swapping/symlink method
      },
      options: {
        useNullAsDefault: true,
        connection: {
          user: "admin",
          password: "attack at dawn",
          host: "db202008101919_high",
        },
      },
    },
  },
});

This will unfortunately override all connection settings.
But even after that you will still be blocked: You are going to face this
[2020-09-18T10:58:12.579Z] debug ⛔ Server wasn't able to start properly.
[2020-09-18T10:58:12.580Z] error Error: Undefined binding(s) detected when compiling SELECT. Undefined column(s): [core_store.id] query: select * from (select "core_store".* from "core_store" where "core_store"."key" = ? and "core_store"."type" = ? and "core_store"."value" = ? and "core_store"."id" = ?) where rownum <= ?
    at Oracledb_Compiler.toSQL (E:\strapi\my-project\node_modules\knex\lib\query\compiler.js:101:13)
    at Builder.toSQL (E:\strapi\my-project\node_modules\knex\lib\query\builder.js:76:44)
    at E:\strapi\my-project\node_modules\knex\lib\runner.js:30:36
From previous event:
    at Runner.run (E:\strapi\my-project\node_modules\knex\lib\runner.js:25:16)
    at Builder.Target.then (E:\strapi\my-project\node_modules\knex\lib\interface.js:14:43)
    at processImmediate (internal/timers.js:456:21)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

I don't know what it is and I will update the status if me/you could make a breakthough.

Actually no and it's not plan today.

@lauriejim , Do you accept PR for oracle support. Some organizations are heavily invested and may not switch to another database system with failover, replication and all that stuff just to have CMS.

Actually no and it's not plan today.

@lauriejim , Do you accept PR for oracle support. Some organizations are heavily invested and may not switch to another database system with failover, replication and all that stuff just to have CMS.

@stevefan1999-personal , @maulik-modi
You can't put a CLOB in the WHERE clause. From the documentation:

Large objects (LOBs) are not supported in comparison conditions. However, you can use PL/SQL programs for comparisons on CLOB data.

"value" clob null
where "core_store"."key" = :1 and "core_store"."type" = :2 and "core_store"."value" = :3


Application Menu is tilled when not suppose to be

Hi this probably has an easy solution or just something to add to the ignorelist but I cant seem to fix it
Symptom
when i press the hamburger to get to the application menu it opens as a separate tiled window instead of just floating. if i press the shortcut to float it, it returns to the correct position.
How to Reproduce

Launch 'any qt app that has an application menu'
Press key 'application menu button'
See menu tiled

Expected behavior
menu is not tiled and is
Environment

Distro: [fedora 40]
KWin version: [6.1.4]
Krohnkite version: [e7f7851]

Notes
Iv tried to debug with the logs on startup but couldn't find the window name.
what happens:

expected:

Iv tried to debug with the logs on startup but couldn't find the window name.

https://github.com/anametologin/krohnkite/issues/7#issuecomment-2126501798
Try use logs to find appropriate window to filter or lay out it here.
What dolphin version, my version - 24.05.2 and I haven't any such problem.

I dont think this is something to do with dolphin like i said it happens with all applications that have an application menu on the titlebar

Iv tried to debug with the logs on startup but couldn't find the window name.

sorry for the confusion, what I meant here is that I could not find krohnkite at all in the logs, I tried again today but it does not appear there. I have done these steps maybe i am doing something wrong:

open krohnkite settings
enable Debug new Windows
reboot
open ksystemlog (journal log)
hit ignore button
search for krohnkite (nothing appeared)
open window, tile it and float it but still nothing appeared in the logs

I have also tried with Print debug messages on and to open ksystemlog with root privlages but still could not find the logs.
I used to have the original Krohnkite extention but recently moved to this repo, could that have an affect?
thank you very much for your time, very appreciated!

I have done these steps maybe i am doing something wrong

if you have scrupulously followed all the points and do not see any results and krohnkite works that problem in you system. May be logs switched off i don't know, nevertheless you need the logs so I can help you.

I have also tried with Print debug messages on and to open ksystemlog with root privlages but still could not find the logs.

KWin works with user rights, you need that user

I used to have the original Krohnkite extention but recently moved to this repo, could that have an affect?

I don't think so. You remove the old one and install the new one that's it.

turns out its called kded6, maybe it could be added to the ignore windows by class list


Where is the Passport.js implementation?

Hey there, love this project!
I was wondering if there were plans to re-implement Passport.js after it was removed in #109 after converting to TypeScript.
Currently there doesn't appear to be an auth mechanism implemented by default, while there are still many references to the user object.

@tylervick if you need just commonly used authentication methods - email/password, phone, magic link, Google / Facebook / Apple, then you may not need Passport.js. You can take advantage of a 3rd party authentication provider such as Firebase Auth, yet store user accounts inside of the application database.
In the case with Firebase Auth, you would add a trigger for [Sign In] button looking somewhat like this:
mutation SignInMutation($idToken: String!) {
  signIn(idToken: $idToken) {
    me {
      id
      email
      displayName
    }
  }
}

const history = useHistory();
const [signIn] = useMutation(signInMutation);

async function handleSignIn() {
  const provider = new firebase.auth.GoogleAuthProvider();
  provider.addScope("email");
  provider.addScope("profile");

  // Open sign in dialog and get Firebase ID token
  const { user } = await firebase.auth().signInWithPopup(provider);
  const idToken = await user.getIdToken();

  // Sign in into the API using that token and reload the page
  signIn({
    variables: { idToken },
    onCompleted() {
      history.replace(history.location);
    }
  });
}

signIn, signOut mutations can be found in api/mutations/auth.ts.
And the actual implementation is located in an auth middleware for Express api/auth.ts.


Fela is overriding styles as components get rendered

Version: 6.0.2
Environment: DOM
Type: Bug / General

Description
Something really weird is happening with Fela in react storybook.  As I click on various stories and render new components the other components styles get overridden.
See attached gif:

Button component:
import React, { Component } from 'react';
import PropTypes from 'prop-types';
import { combineRules, createComponent } from '@covered/rio-style-fela';

const raised = ({ raised = false, theme: { shadow } }) => ({
  boxShadow: raised ? shadow.button : 'none',
});

const color = ({ secondary, emphasis, theme: { colors } }) => ({
  background: secondary
    ? colors.secondary
    : emphasis ? colors.emphasis : colors.primary,
});

const base = ({ theme }) => ({
  color: theme.colors.white,
  padding: '10px 14px',
  border: 'none',
  borderRadius: 100,
  letterSpacing: 1,
  fontFamily: theme.fonts.primary,
  fontWeight: theme.fonts.bold,
});

const rules = combineRules(base, raised, color);

export default createComponent(rules, 'button');

Provider:
import React, {
  Component,
  Children,
  isValidElement,
  cloneElement,
} from 'react';
import PropTypes from 'prop-types';
import createRenderer from './createRenderer';
// import { render } from 'fela-dom';
import { Provider } from 'react-fela';
import { theme } from '@covered/rio-style-const';
import { ThemeProvider } from '@covered/rio-style-fela';

class StyleProvider extends Component {
  static propTypes = {
    children: PropTypes.node,
    // Inject override
    renderer: PropTypes.object,
    // Renderer environment settings
    dev: PropTypes.bool,
    perf: PropTypes.bool,
    debug: PropTypes.bool,
  };

  render() {
    const { renderer, children, dev, perf, debug, ...restProps } = this.props;
    const providerRenderer = renderer || createRenderer({ dev, perf, debug });
    const child = Children.only(children);

    return (
      <Provider renderer={providerRenderer}>
        <ThemeProvider theme={theme}>
          {isValidElement(child)
            ? cloneElement(child, { ...restProps })
            : child}
        </ThemeProvider>
      </Provider>
    );
  }
}

export default StyleProvider;

Can you please give me a working repository? I got no time to create an example myself with just those snippets. I feel like it's the same issue as #412. If I got a example repo, I can test it and maybe fix for both.

Yeah don't worry about it, it's definitely something I'm doing wrong will close these for now.

I dont think so. This might be an actual issue! If you could ping me on Gitter, i might be able to help

Hey @rofrischmann the problem was in this line:
    const providerRenderer = renderer || createRenderer({ dev, perf, debug });

If you look above my StyleProvider was creating a new renderer on every render so when I looked at new 'stories' in react story it was setting all the styles of the other stories to the latest one I viewed.
Once I created a single renderer and passed it in as a prop everything was fixed.  I think that is what was going on but either way it works now!

Oh I see. Thanks for your reply! I guess we will add a storybook example soon, so other ppl don't struggle with the same issues anymore :)


home swiper not slide automatically

Summary
The home page swiper does not slide automatically, please fix or add this feature.
Please confirm the following

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.

Available on Release 1.5.1


How to visualize and save OBJ?

Hi @hturki !
I was trying to compile mega-nerf-viewer but was stuck in the final stage. Do you have any idea about this problem?
OS: Ubuntu 20.04
gcc version: 9.4.0 (Ubuntu 9.4.0-1ubuntu1~20.04.1)
cmake: 3.24.1
libtorch libx11-dev_1.6.9-2ubuntu1.3_amd64
cuda: 11.6
I have successfully compiled mega-nerf-viewer. Then I ran the following commands with one NVIDIA Tesla A100:
./mega-nerf-viewer ../../OCTREE_PATH.npz --model_path ../../building-pixsfm-8.pt

Thanks!

Have u sloved this problem? I also wonder this solution, could u share your answer?


Auth: add endpoint type parameter support

What this PR does / why we need it:
It allows to specify a service endpoint type: e.g. admin, public, internal.
Which issue this PR fixes
fixes #713
Special notes for your reviewer:
Release note:

Auth: add endpoint type parameter support

/ok-to-test

@kayrus Could you update this PR with changes requested ?

@ramineni will do a bit later

/close
please reopen if you would like to work on this again.


Typos/spelling errors in XML doc comments and source. #Hacktoberfest

Going for a nice t-shirt.
Here's some typos/spelling errors I found in this repo.
Happy #Hacktoberfest :smiley_cat: :fearful: :skull_and_crossbones: :moon: :bat:
Thanks,
Brian
:boom: :fire: "Set it ablaze like a candle wick... Light it up, light it up..."

Thanks for the contribution @bchavez


csTools dies after changing the layout disposition when the active tool is in an intermediate state

Bug Report
Describe the Bug
Cornerstone tools dies after changing the layout disposition when the active tool is in an intermediate state.
What steps can we follow to reproduce the bug?

Choose any study.
Set the layout to 2x1.
Select the Angle tool.
Click on the second viewport.
Set the layout to 1x1.

After that point, no tools will work anymore.
I will be happy to make a PR for this if you help me find out what the cause is 😬.

👋 Hi @arthur-miller
When a cornerstone-tools annotation tool is not finalized, it sets an internal property that prevents new click events from triggering the eventDispatcher. It looks like we need to check for cornerstonenewimage and cornerstoneelementdisabled events to unset this check.
Here are some examples where we set/check the isToolLocked property:

https://github.com/cornerstonejs/cornerstoneTools/search?q=isToolLocked&unscoped_q=isToolLocked

The places that need to listen for those events are the same places where we set isToolLocked = false, namely "manipulators" (what we call interactions with annotation "handles"):

https://github.com/cornerstonejs/cornerstoneTools/blob/e38e2f5c81b0f83cca5a29a03334bee287028a8a/src/manipulators/moveNewHandle.js#L178
https://github.com/cornerstonejs/cornerstoneTools/blob/e38e2f5c81b0f83cca5a29a03334bee287028a8a/src/util/findAndMoveHelpers.js#L120

Another consideration is "how do we clean up unfinished annotation data?" as you orphan it by doing this.

I hope that at least provides some context. I'm open to discussing workarounds or alternative fixes.

Hello Danny!
Thank you for the guidance. I'll make a PR on Cornerstone Tools in the next few days.

Thank you for your past contributions and for raising this issue related to legacy versions of our OHIF Viewer. Your time and effort have been invaluable in helping us improve the product.
We wanted to update you that our development focus has shifted to OHIF Viewer v3, which is now available for testing on viewer-dev.ohif.org. This site is deployed from our master branch and incorporates new features, optimizations, and bug fixes. If you're still using viewer.ohif.org, it's worth noting that this is deployed from our release branch and may not have the latest updates. You can read more about our branching strategies here.
Given the move to Version 3, we are closing older issues that pertain to Versions 1 and 2, as we are no longer providing support for those versions. If you find that the issue you've raised is still relevant in Version 3, we encourage you to reopen this issue or create a new one for proper triage.
Thank you for your understanding and continued support.


Consider allowing call to NIOThreadPool.start() while pool is already running

Expected behavior
Based on the docstring for NIOThreadPool.start ("Start the NIOThreadPool if not already started"), and that calling shutdown multiple times is shown to be safe in the tests, I assumed a repeated call to start would also be safe/a no-op.
Actual behavior
The assertion here is triggered.
My use case is that I'd like to lazily start the thread pool the first time I use it without having to track whether I already called start.
This seems like a pretty small code change, or alternatively, a small documentation change to clarify repeated calls to this method are unsafe, and I'd be happy to make a PR either way.
Steps to reproduce
Call start twice.
If possible, minimal yet complete reproducer code (or URL to code)
let threadPool = NIOThreadPool(numberOfThreads: 1)
threadPool.start()
threadPool.start() // triggers assertion

SwiftNIO version/commit hash
2.11.1
Swift & OS version (output of swift --version && uname -a)
Apple Swift version 5.1.3 (swiftlang-1100.0.282.1 clang-1<IP_ADDRESS>)
Target: x86_64-apple-darwin18.7.0
Darwin kaitlin.fios-router.home 18.7.0 Darwin Kernel Version 18.7.0: Sat Oct 12 00:02:19 PDT 2019; root:xnu-4903.278.12~1/RELEASE_X86_64 x86_64

Thanks for the bug report @kmahar . Definitely either the docs or the code are wrong ☺.
I’m not sure which to fix right now. Allowing double-start would come with extra questions such as what to do with a start when it comes whilst a shutdown is ongoing. Currently, we fatalError there, but should we ignore that too?
Usually, I’d say start and shutdown calls should be balanced but it would be really easy to just ignore a double start, so we could do that too...
Opinions @Lukasa , @glbrntt , @Davidde94 ?

I agree that balanced start/shutdown calls is nicer, however we should be probably first update the code to be inline with the expected behaviour from the docs. If/when this is done we could push a new release (with new docs) that enforce 1:1 start/shutdown.

I’m inclined to say that either we should require that start be called only once, or allow unbalanced and arbitrary numbers of calls. Either of these two cases is easy to tolerate in code, but the in-between case (“balanced but arbitrary count”) is a bit more awkward.

For the actual use case in question, couldn't we just introduce an "auto start" mode? (Such that it would then be like MTELG.)
If so then I think I'd lean towards requiring that start is only called once.

Seems like the consensus (which incidentally aligns with other uses in NIO) is to make it very strict and require exactly one start followed by exactly one stop.

Thank you all for getting back to me! Requiring one start + one stop seems reasonable.
I've also realized that lazily starting it isn't actually a good idea for what I'm doing anyway so as of now I have no need for an auto-start feature.

Closing this issue now since we are allowing to call start() multiple times. This was fixed with https://github.com/apple/swift-nio/pull/1572


Netlify Failing to Deploy Blog

Netlify Failed Deployment
Spent time searching for possible causes of the failed Netlify deployment. I cannot find anything within the code.

Yeah! That was from a trial a did last week / two weeks ago where I moved the markdown files to the public folder / deleted it from blog content / routed things differently. I fixed all of that now.
Everything should work locally now, however, the page still won't display on Netlify.


Tips for debugging BindValidRequest() errors?

Problem statement
I'm trying to debug an issue with a bad POST handler. The problem seems to stem from BindValidRequest in operations.post_foo.go during the o.context.Respond() call.
I'd like to find the offending portion of the input data. Or some details on where the input parameter unmarsaling occurs (I looked at https://github.com/go-swagger/go-swagger/blob/master/design.md do no avail)
Looking at the stack trace leads me to go-openapi/middleware/context.go but no particulars what might be going on.
2016/12/02 17:45:05 http: panic serving <IP_ADDRESS>:35882: runtime error: invalid memory address or nil pointer dereference
goroutine 12 [running]:
net/http.(*conn).serve.func1(0xc42074a300)
        /usr/local/go/src/net/http/server.go:1491 +0x12a
panic(0x8c9b80, 0xc4200120b0)
        /usr/local/go/src/runtime/panic.go:458 +0x243
code.foo.com/MyCo/mosaics-api/vendor/github.com/go-openapi/runtime/middleware.(*Context).Respond(0xc420700980, 0xc0ffa0, 0xc4206de340, 0xc42066e0f0, 0xc420013990, 0x1, 0x1, 0xc42001b180, 0x8ca8a0, 0xc420446600)
        /home/sandy/go/src/code.foo.com/MyCo/mosaics-api/vendor/github.com/go-openapi/runtime/middleware/context.go:438 +0x7b1
code.foo.com/MyCo/mosaics-api/server/restapi/operations.(*PostMosaicExperimentalMosaics).ServeHTTP(0xc42031a660, 0xc0ffa0, 0xc4206de340, 0xc42066e0f0)
        /home/sandy/go/src/code.foo.com/MyCo/mosaics-api/server/restapi/operations/post_mosaic_experimental_mosaics.go:49 +0x34d
code.foo.com/MyCo/mosaics-api/vendor/github.com/go-openapi/runtime/middleware.NewOperationExecutor.func1(0xc0ffa0, 0xc4206de340, 0xc42066e0f0)
        /home/sandy/go/src/code.foo.com/MyCo/mosaics-api/vendor/github.com/go-openapi/runtime/middleware/operation.go:24 +0x69
net/http.HandlerFunc.ServeHTTP(0xc420107b50, 0xc0ffa0, 0xc4206de340, 0xc42066e0f0)
        /usr/local/go/src/net/http/server.go:1726 +0x44
code.foo.com/MyCo/mosaics-api/vendor/github.com/go-openapi/runtime/middleware.NewRouter.func1(0xc0ffa0, 0xc4206de340, 0xc42066e0f0)
        /home/sandy/go/src/code.foo.com/MyCo/mosaics-api/vendor/github.com/go-openapi/runtime/middleware/router.go:89 +0x478
net/http.HandlerFunc.ServeHTTP(0xc42078f680, 0xc0ffa0, 0xc4206de340, 0xc42066e0f0)
        /usr/local/go/src/net/http/server.go:1726 +0x44
code.foo.com/MyCo/mosaics-api/vendor/github.com/go-openapi/runtime/middleware.Redoc.func1(0xc0ffa0, 0xc4206de340, 0xc42066e0f0)
        /home/sandy/go/src/code.foo.com/MyCo/mosaics-api/vendor/github.com/go-openapi/runtime/middleware/redoc.go:72 +0xac
net/http.HandlerFunc.ServeHTTP(0xc42078f800, 0xc0ffa0, 0xc4206de340, 0xc42066e0f0)
        /usr/local/go/src/net/http/server.go:1726 +0x44
code.foo.com/MyCo/mosaics-api/vendor/github.com/go-openapi/runtime/middleware.Spec.func1(0xc0ffa0, 0xc4206de340, 0xc42066e0f0)
        /home/sandy/go/src/code.foo.com/MyCo/mosaics-api/vendor/github.com/go-openapi/runtime/middleware/spec.go:45 +0x8b
net/http.HandlerFunc.ServeHTTP(0xc42078f840, 0xc0ffa0, 0xc4206de340, 0xc42066e0f0)
        /usr/local/go/src/net/http/server.go:1726 +0x44
net/http.serverHandler.ServeHTTP(0xc420791980, 0xc0ffa0, 0xc4206de340, 0xc42066e0f0)
        /usr/local/go/src/net/http/server.go:2202 +0x7d
net/http.(*conn).serve(0xc42074a300, 0xc109a0, 0xc420744340)
        /usr/local/go/src/net/http/server.go:1579 +0x4b7
created by net/http.(*Server).Serve
        /usr/local/go/src/net/http/server.go:2293 +0x44d

The code in context.go
430 >---if err, ok := data.(error); ok {
431 >--->---if format == "" {
432 >--->--->---rw.Header().Set(runtime.HeaderContentType, runtime.JSONMime)
433 >--->---}
434 >--->---if route == nil || route.Operation == nil {
435 >--->--->---c.api.ServeErrorFor("")(rw, r, err)
436 >--->--->---return
437 >--->---}

438 >--->---c.api.ServeErrorFor(route.Operation.ID)(rw, r, err)

439 >--->---return
440 >---}

... which kinda leaves me at a dead-end.

Is it the same spec from your previous issues?
Can you share the request you make that triggers this?

Slightly different https://gist.github.com/SandyWalsh/5987303142bea7bf5d41c07476dccf76
curl -i     -H "Accept: application/json"     -X POST     -d '{"id": "123e4567-e89b-12d3-a456-426655440000", "renditions": [], "bbox": {}, "coordinate_system": "coordinates", "first_acquired": "2006-01-02 15:04:05", "last_acquired": "2006-01-02 15:04:05", "product_type": "basemap", "name":"My mosaic"}'      http://<IP_ADDRESS>:8000/v1/mosaic/experimental/mosaics

I was hesitant to post the whole thing since it doesn't help me learn the flow of data through the system (give a man a fish, etc). Was really looking for tips that you use for debugging these sorts of problems.
But I do appreciate you looking into it.

The error from ServeErrorFor seems to be
validation failure list:
unsupported media type "application/x-www-form-urlencoded", only [application/json] are allowed

ah you have to add a Content-Type header to your request.
This is a bug because it should return a 4xx status code

Thanks ... was very close to that myself (almost caught a fish ;)

It would be nice to get some debug level logging around that ServeErrorFor() line. For example, now I'm getting
parsing body body from "" failed, because json: cannot unmarshal object into Go value of type string
when I issue
curl -i     -H "Accept: application/json" -H "Content-type: application/json"     -X POST     -d '{"id": "123e4567-e89b-12d3-a456-426655440000", "renditions": [], "bbox": {}, "coordinate_system": "coordinates", "first_acquired": "2006-01-02T15:04:05Z", "last_acquired": "2006-01-02T15:04:05Z", "product_type": "basemap", "name":"My mosaic"}'      http://<IP_ADDRESS>:8000/v1/mosaic/experimental/mosaics

... and it's tricky to determine what the offending field is.

Found it: "bbox": "" ... not "bbox": {} ... trial and error

Stumbled today on that very old one...
Out of curiosity, I wanted to figure it out by myself.
Given the spec provided in the above gist,

omitting the Content-Type application/json header results in a 415 error, as expected
the offending property type ("bbox": {}) is properly detected by the validator, returns a "400 bad request"
the validation error message is explicit about what is wrong with that message
providing the correct header and the correct input passes validation (reaches the "not implemented" handler)
no panic occurred even with wrong input or headers

Although we sure could improve the server handler by providing more debugging instrumentation,
I think this may be closed now.

Stumbled today on that very old one...
Out of curiosity, I wanted to figure it out by myself.
Given the spec provided in the above gist,

omitting the Content-Type application/json header results in a 415 error, as expected
the offending property type ("bbox": {}) is properly detected by the validator, returns a "400 bad request"
the validation error message is explicit about what is wrong with that message
providing the correct header and the correct input passes validation (reaches the "not implemented" handler)
no panic occurred even with wrong input or headers

Although we sure could improve the server handler by providing more debugging instrumentation,
I think this may be closed now.


Remove Consul from "The Internal flow of processing" section diagram in about.md

All logos are vectors in the source file.
Description
This changes the "Internal flow of processing" diagram in About.md since Consul has been removed. Tested by previewing the markdown, and added the source file as well (draw.io source file, draw.io is open sourced Apache-2.0, hosted as well as offline available).
Related issue and scope

[X] I opened an issue to propose and discuss this change (#3207)

My changes affect the following components

[ ] API
[ ] Controller
[ ] Message Bus (e.g., Kafka)
[ ] Loadbalancer
[ ] Invoker
[ ] Intrinsic actions (e.g., sequences, conductors)
[ ] Data stores (e.g., CouchDB)
[ ] Tests
[ ] Deployment
[ ] CLI
[ ] General tooling
[X] Documentation

Types of changes

[X] Bug fix (generally a non-breaking change which closes an issue).
[ ] Enhancement or new feature (adds new functionality).
[ ] Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

[X] I signed an Apache CLA.
[ ] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[ ] I added tests to cover my changes.
[ ] My changes require further changes to the documentation.
[X] I updated the documentation where necessary.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@d61748f). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #3638   +/-   ##
=========================================
  Coverage          ?   74.59%
=========================================
  Files             ?      126
  Lines             ?     5982
  Branches          ?      397
=========================================
  Hits              ?     4462
  Misses            ?     1520
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d61748f...9b653c7. Read the comment docs.

Not sure why one of the builds in the build matrix failed, this is just a doc change...

@shazron should be fine after #3642 is merged.

Ah ok @shazron different readme problem, scancode changed and is out of this repo

Rebased. All checks pass.

Sweet 👍 @shazron