[stable/prometheus-operator/] Unable to create ingress for grafana

Describe the bug
Getting issues creating grafana ingress
Error: release prometheus-operator failed: Ingress.extensions "prometheus-operator-grafana" is invalid: spec: Invalid value: []networking.IngressRule(nil): either `backend` or `rules` must be specified

Version of Helm and Kubernetes:
Server: &version.Version{SemVer:"v2.14.1", GitCommit:"5270352a09c7e8b6e8c9593002a73535276507c0", GitTreeState:"clean"}

Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.2", GitCommit:"52c56ce7a8272c798dbc29846288d7cd9fbae032", GitTreeState:"clean", BuildDate:"2020-04-21T01:25:41Z", GoVersion:"go1.13.10", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"15+", GitVersion:"v1.15.11-gke.15", GitCommit:"8ce551a0c972a9f113e326df0537aa3f1798d93e", GitTreeState:"clean", BuildDate:"2020-05-05T18:38:03Z", GoVersion:"go1.12.17b4", Compiler:"gc", Platform:"linux/amd64"}

Which chart:
Prometheus-Operator
What happened:
When installing the operator with grafana enabled the bug occurs
What you expected to happen:
The Ingess for grafana is created
How to reproduce it (as minimally and precisely as possible):
helm install stable/prometheus-operator --name prometheus-operator --namespace prom-test --set alertmanager.enabled=false --set grafana.ingress.enabled=true
Anything else we need to know:
Works perfectly fine for prometheus.ingress.enabled=true and can deploy and change service backend to prometheus-operator-grafana which works correct.

Hi Dave,
After prometheus.ingress.enabled=true is set to true, what url shall I use to login Prometheus? I still had to use ip and port to login.
This is my custom values.yaml file for overriding the default config. I enabled ingress.
prometheus:
ingress:
enabled: true
prometheusSpec:
replicas: 1
retention: 24h
image:
tag: v2.18.1
zz@ZhangsodMacBook Prometheus-operator % kubectl get po
NAME                                                   READY   STATUS    RESTARTS   AGE
alertmanager-demo-prometheus-operator-alertmanager-0   2/2     Running   1          83m
demo-grafana-78bc94db5-vnsng                           2/2     Running   0          83m
demo-kube-state-metrics-5b9db77dc-5pxv4                1/1     Running   2          83m
demo-prometheus-node-exporter-q6dh9                    1/1     Running   1          83m
demo-prometheus-operator-operator-7fd745b994-sggf5     2/2     Running   0          83m
prometheus-demo-prometheus-operator-prometheus-0       3/3     Running   2          56m
Zhang

On Jun 8, 2020, at 7:37 AM, Dave Pewsey<EMAIL_ADDRESS>wrote:
Describe the bug
Getting issues creating grafana ingress
Error: release prometheus-operator failed: Ingress.extensions "prometheus-operator-grafana" is invalid: spec: Invalid value: []networking.IngressRule(nil): either backend or rules must be specified
Version of Helm and Kubernetes:
Server: &version.Version{SemVer:"v2.14.1", GitCommit:"5270352a09c7e8b6e8c9593002a73535276507c0", GitTreeState:"clean"}
Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.2", GitCommit:"52c56ce7a8272c798dbc29846288d7cd9fbae032", GitTreeState:"clean", BuildDate:"2020-04-21T01:25:41Z", GoVersion:"go1.13.10", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"15+", GitVersion:"v1.15.11-gke.15", GitCommit:"8ce551a0c972a9f113e326df0537aa3f1798d93e", GitTreeState:"clean", BuildDate:"2020-05-05T18:38:03Z", GoVersion:"go1.12.17b4", Compiler:"gc", Platform:"linux/amd64"} ```
Which chart:
Prometheus-Operator
What happened:
When installing the operator with grafana enabled the bug occurs
What you expected to happen:
The Ingess for grafana is created
How to reproduce it (as minimally and precisely as possible):
helm install stable/prometheus-operator --name prometheus-operator --namespace prom-test --set alertmanager.enabled=false --set grafana.ingress.enabled=true
Anything else we need to know:
Works perfectly fine for prometheus.ingress.enabled=true and can deploy and change service backend to prometheus-operator-grafana which works correct.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/helm/charts/issues/22711, or unsubscribe https://github.com/notifications/unsubscribe-auth/APB7QOIGYQ3AYBXOSVVYPBDRVTZRXANCNFSM4NYPCGWQ.

I can confirm this issue.
Using GKE
Kubernetes Version:
Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.3", GitCommit:"2e7996e3e2712684bc73f0dec0200d64eec7fe40", GitTreeState:"clean", BuildDate:"2020-05-21T14:51:23Z", GoVersion:"go1.14.3", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"16+", GitVersion:"v1.16.8-gke.15", GitCommit:"9cabee15e0922c3b36724de4866a98f6c2da5e6a", GitTreeState:"clean", BuildDate:"2020-05-01T21:47:04Z", GoVersion:"go1.13.8b4", Compiler:"gc", Platform:"linux/amd64"}

Helm Version:
version.BuildInfo{Version:"v3.2.3", GitCommit:"8f832046e258e2cb800894579b1b3b50c2d83492", GitTreeState:"clean", GoVersion:"go1.13.12"}

From my investigation this seems to be caused by the used Grafana Chart with the ingress.hosts being an empty list. There I can reproduce the same behaviour:
$ helm install grafana stable/grafana -f grafana.yaml
Error: Ingress.extensions "grafana" is invalid: spec: Invalid value: []networking.IngressRule(nil): either `backend` or `rules` must be specified

with grafana.yaml:
ingress:
  enabled: true
  hosts: []

Which is the default: https://github.com/helm/charts/tree/master/stable/prometheus-operator#grafana


Add clustermanagementaddon resource

Signed-off-by: Jian Qiu<EMAIL_ADDRESS>

@qiujian16 can you link an issue to this PR?

The unit-test is failing since the CRD ClusterManagementAddOn is not available at runtime.
This CRD is rather installed when the cluster-manager CR is installed.
In order to get this to pass the test, we would either need to refactor how the ClusterManagementAddon is installed, or add the ClusterManagementAddon CRD to our list of CRDs which is installed at runtime.

@qiujian16 After discussing w/ squad, since the CRD is not in place before applying the ClusterManagementAddon resource, and since the ClusterManager CR installs the ClusterManagementAddon CRD, would it be possible to close out this PR and have ClusterManager install the ClusterManagementAddon work-manager resource?

ClusterManager is to install the crd  of ClusterManagementAddOn but not a certain CR. Is it possible that we can apply this  resource after ClusterManager is installed?


Set up SSO via Authentik

We need to use Authentik's proxy provider to have nginx lock every page behind an auth_request to said proxy provider. Some services may need some additional integration configuration to give Authentik the ability to grant service-specific authorizations, but this is the core of the idea here.
┆Issue is synchronized with this Trello card by Unito

 Set up SSO via Authentik


Provide a mechanism to physically delete messages automatically and periodically with a plugin to notify the deletion operation

https://github.com/turms-im/turms/commit/799d3fa7f83e1c57a2c2aab2ea7154555dc5807a


Top Stories/Recent & Stories by Subject

Title/Image/Caption all clickable within a button directing users to specific pre-existing topic search.
Acceptance Criteria (AC):

[x] Create data display function
[x] Display titles
[x] Display images
[x] Display captions
[x] Create buttons
[x] Add any necessary styling to styles.css
[x] Create a pull request for the above requirements

Closed via api-styling-&-refactor branch


Kinect Azure joint coordinate picture doesn't match actual API behavior

The joint coordinate picture does not match actual joints of API. For example

from hip left -> foot left the picture shows 6 joints. However, the API only has 4.
from Pelvis -> head. Picture shows 6 joints yet API has only 5.
picture is missing joints nose, eye, ear, etc. There is value in these to be in the picture. Given they are in close proximity, I recommend a zoom-in head view pasted into the bottom right of the overall picture

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bfd96838-87c8-c27e-f8ee-a2db651ba463
Version Independent ID: ab4d754c-e83f-7d20-cd8c-690033684406
Content: Azure Kinect body tracking joints
Content Source: articles/kinect-dk/body-joints.md
Product: kinect-dk
GitHub Login: @qm13
Microsoft Alias: quentinm

Thanks for the feedback and bringing this to our notice . At this time we are reviewing the feedback and will update the document as appropriate .

@diablodale  I have assigned the issue to the content author to evaluate and update as appropriate.

@AshokPeddakotla-MSFT Please close as this is captured in AKDK GitHub bug #1414 https://github.com/microsoft/Azure-Kinect-Sensor-SDK/issues/1414

@qm13 Thanks for the confirmation.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Add maps route

Closes #20

Just scrolling through PRs, you might want to know: A route for the map view already exists as of #32 (or more specifically https://github.com/hpi-swt2/compass-portal-blue/pull/32/commits/043b7adee649ec839a1d0351c63cb106c21f63f7) - there is just no way to access it though the UI at the time of writing

Just scrolling through PRs, you might want to know: A route for the map view already exists as of #32 (or more specifically 043b7ad) - there is just no way to access it though the UI at the time of writing

@niklasmohrin We know. Our goal for this sprint is to create a spike solution for an indoor map. We knew that there already was a subpage for a map created by the other team, but we thought that making them compatible this early in the spike would be no good towards the simplicity of our spike. We therefore chose to add a second route for the spike. But I agree that this isn't made clear from the title of the PR or the linked issue, I'll change them.


Cannot add RSS and News Slider on the same page

I am trying to add 2 web parts on the same Classic page, but only one displays at a time. I am able to add and configure both, but only one displays after saving the page.

Thanks @joancloete for your feedback. I will investigate it.

OK Thanks @joancloete. I didn't identify a workaround, but the issue is known. I will fix it for the next release. Thanks for this report.

Hi, thank you for the feedback! I have tested it on the modern pages as well, hoping to get more than one web part on a page. I received an error message this time on the news web part:
"Unite Gallery Error: You have some jquery.js library include that comes after the gallery files js include.
This include eliminates the gallery libraries, and make it not work.
To fix it you can:
1. In the Gallery Settings -> Troubleshooting set option: Put JS Includes To Body option to true.
2. Find the double jquery.js include and remove it."

Hi @joancloete. Yes you're right, the problem comes from the fact that the jQuery library is loaded several times. Webparts with a jQuery plugin are blocked because jQuery is reset. I corrected the problem in version 1.0.2 which is available for download. The fix is a little dirty, but I worked to a cleaner version in the future. Thanks again for this bug report.

Thank you very much! I am now able to add more than one web part on the modern and classic pages.


[Bug]: domain go.step.sm/crypto lost resolution

Steps to Reproduce
We can't resolve de domain go.step.sm it's not possible resolve and because that it is not possible synv the lib.
Your Environment

OS - ANY
Version - ANY

Expected Behavior
resolve de domain go.step.sm
Actual Behavior
name resolution fail to domain go.step.sm
Additional Context
Other way to solve this behavior it's change the package the module from  go.step.sm/crypto to github.com/smallstep/crypto
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

Hey @gustavofagundes, we're aware and are working on solving this. Are you not using the Go modules proxy?

@hslatman unfortunataly not.

The domain does resolve correctly again, so the temporary issue should be resolved now.
We've spoken about moving away from go.step.sm for our Go modules, not just this time, but also the previous time a similar problem occurred. It's likely we'll migrate to using github.com/smallstep/crypto sometime soon. I'll keep this issue open for a bit, so that I don't forget to bring it up in our next open source triage meeting.


name tables relative to transformations

This updates the naming of tables/contexts to use names relevant to the performed transformation, such as "Filter of ____" or "Count of ___".
Note that with this approach names can get pretty unwieldy pretty quickly, if you are heavily composing transformations.

This is really good and I think really increases the readability of the table names in the screenshot. However, I agree that as they get longer in may get unwieldy. Do you think it would help or hinder readability if we added some sort of punctuation for grouping? So instead of having
Compare of Flatten of Running Mean of Table1 and Difference From of Table2
we could have
Compare of [Flatten of [Running Mean of Table1] and [Difference From of Table2]


I cannot train because of the datasets

how do i create pmi image? thanks for any help

数据集感觉给得不完整呀


Upgrade chart to use Kong 2.0

Current default appears to be 1.4:
https://github.com/Kong/charts/blob/b1131b662d0d81248ca03c781e0609a1cbc66288/charts/kong/values.yaml#L38
It is understandable that this might not be top priority for the chart, but it should be done sooner or later.

@hbagdi Will the new version of the chart including 2.0 by default include support for configuring the new status interface and using it with readiness/liveness probes and the ServiceMonitor?

new status interface and using it with readiness/liveness probes and the ServiceMonitor?

Not yet. We have not moved to the new Status interface yet because there is still a significant userbase which is running Kong 1.3 and below versions, which don't have the status interface. You can easily tweak the configuration of probes to use status interface.
And non-breaking changes (totally possible) for status interface support to this chart are welcome!

there is still a significant userbase which is running Kong 1.3 and below versions

That makes sense, thanks for explaining.

And non-breaking changes (totally possible) for status interface support to this chart are welcome!

I'll see what I can put together, and be sure to contribute it if it's any good.

Version 1.3.0 of the Kong chart is now released, resolving this issue.


Support config defaults using .pip-tools.toml or pyproject.toml

Supports use of a .pip-tools.toml, pyproject.toml, or other explicitly specified TOML file to set configuration defaults for pip-compile and pip-sync.
Fixes #604.
Contributor checklist

[X] Provided the tests for the changes.
[X] Assure PR title is short, clear, and good to be included in the user-oriented changelog

Maintainer checklist

[ ] Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
[ ] Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@j00bar you can't trigger CI until you have at least one commit in the repo..

I'll also approve the CI in just a bit to see how it's doing...

The PyPy failures seem unrelated... Though, they'll probably need sorting out separately before this PR could be mergeable. I wonder if bumping the interpreter version would have any effect.

Thank you for the detailed feedback!

I've added support and preference for a .pip-tools.toml file.
I've implemented the best practices and conventions you referenced.
I've made the dependency on toml apply only pre-3.11 - the tests still require the external toml library, as tomllib reads only but does not yet write.
I've updated the README to document the new configurability.

@j00bar I apologize that this all came off quite overwhelming — my reviews are often like this when I get excited, which causes people to think I'm too nitpicky... This is a collaboratively-maintained project, meaning that hundreds of people have maintenance privileges. Though, only a few maintain specific Jazzband projects consistently.  It could've remained unreviewed for some while otherwise. Of course, there's always a chance somebody would step in to give extra feedback.
Some bits I commented are optional, but nice to have. Others stand firm ground. In particular, that decoupling request.
You mentioned that it'changing it would require rewriting tests substantially but I don't see why — could you clarify what you foresee? I must've missed some implications, eh?
Finally, there's no time pressure to iterate on feedback. But since you mentioned that you'd postpone further commits, would it be okay if I committed something to your branch myself to ease the burden?

@j00bar I've addressed some of the comments and I'm making a pause now. Maybe I'll get back to this later, or maybe you will. There's some extra discussions that happened FYI, please check them out and respond as you have time.

@chrysle creating merge commits in PR branches brings contributors pain. It's best not to add them for the sake or adding, especially since there's clearly more things to do here and this causes unnecessary disruptions on shared branches like this.

Apologies @webknjaz
I wanted to fix the RTD build. I will remember this for the future.

I wanted to fix the RTD build.

It'd be fixed on the next commit by itself, I think. Most CI-like systems use the ephemeral merge commit of PR branches into main which combines states of both.
If anything, I'd go for using the rebase setting of the branch update, but only if the PR was about to be merged so that the contributing experience isn't messed up by force pushes.

@j00bar I'll need to dedicate more time to reviewing this, but there's one pattern I noticed that has to be fixed — your docstrings use single backticks for things that should be marked as inline code. In RST, unlike MD, these must be double backticks. The single ones have different semantics. There's currently no sane way to have MD in docstrings and RST is the only thing virtually any Sphinx-based project is able to consume.

@j00bar looks like you accidentally re-reverted 4980a8f (#1863).

Thanks for the updates! It may take me some time to review the PR — I got ill 🤒 and my brain is rather defunct atm..
Though, if I'm not answering for too long, feel free to ping me. TIA!

I got ill 🤒

Damn. Feel better, friend. The PR will wait.

Thanks, y'all! I'm mostly fine now, so I'll try to review the updates.

@j00bar with the rst to md conversion, there's a conflict with the readme now that needs solving.

Rebased and translated the README changes to Markdown. :+1:

With this, how does one ensure no arguments from configuration files interfere with what's manually run (and visible) on the command line? Do we need to specify --config /dev/null, if that works, to prevent surprises, and ensure consistent behavior with the current release?

Also, are the config-file defaults merged with what's explicitly passed on the command line, or entirely replaced if any options (or args?) are passed?

@AndydeCleyre The order of precedence, from highest to lowest:

Explicit command-line parameter
Config file
Hard coded defaults

So if you specify something on the command-line, it overrides whatever is in the config file. If you specify something in the config file, it overrides whatever is hard coded into pip-tools.
For settings with multiple values, there's no merging. It follows the order of precedence.
Does that make sense?

That makes sense but it doesn't clear up the questions for me.

If I have the option cert specified in the config file, and I pass --annotation-style=line on the command line, will the cert option be used?
If I want to run pip-compile with the program's defaults, even if there exists a hidden .pip-tools.toml file in the current directory (i.e. I want it to act as pip-compile does in the current release), is it now necessary that I change all current calls of arg-less pip-compile to pip-compile --config /dev/null? Will that work? Is that the only way to achieve this?

These are great points. It's probably worth adding said test cases to make the expectations explicit. It might be nice to document this too and implement a --no-config..

If I have the option cert specified in the config file, and I pass --annotation-style=line on the command line, will the cert option be used?

Yes. Each parameter follows the order of precedence independently. The full configuration, like most command-line utilities, uses a mosaic of command-line set arguments, config file arguments, and hardcoded defaults.

If I want to run pip-compile with the program's defaults, even if there exists a hidden .pip-tools.toml file in the current directory (i.e. I want it to act as pip-compile does in the current release), is it now necessary that I change all current calls of arg-less pip-compile to pip-compile --config /dev/null? Will that work? Is that the only way to achieve this?

It might be nice to... implement a --no-config

I don't agree. Projects use these config files to set defaults that should apply to the whole project to make the preferred way of compiling/syncing requirements be the easiest way to compile/sync requirements. That encourages consistency transparently. As the steward of many projects and having to have created automation to fail a PR when it fails consistency in the compiled requirements, I want it as laborious as possible to deviate from the project's default settings. And if there are deviations I often make, I'm going to make an additional config file with a non-default config file name.
But you're a maintainer of this one - it's up to you if you want that - but I'm not interested in helping with that one.

@AndydeCleyre I wonder why is this backwards incompatible?

I still don't know the answer to this question, but this is what I was thinking of:

If I want to run pip-compile with the program's defaults, even if there exists a hidden .pip-tools.toml file in the current directory (i.e. I want it to act as pip-compile does in the current release), is it now necessary that I change all current calls of arg-less pip-compile to pip-compile --config /dev/null? Will that work? Is that the only way to achieve this?

I still don't know the answer to this question

@AndydeCleyre
I'm inclined to think that this update does not represent a breaking change. The current update does not interfere with pip-compile's default behavior, nor does it require any modifications to existing calls. Running pip-compile without any arguments will still function as it does in the current release and shouldn't break any existing pipelines, as there were no configurations before.
However, I believe we should consider adding support for --no-config (similar to how it's done in wget or ripgrep) in the upcoming version and resolve other concerns.
Are there any objections if I remove the corresponding label and proceed with the version 6.14.0 (#1892) release process?

Released as part of pip-tools v6.14.0.

Hey @j00bar, FYI there's some post-release adjustment and bugfixing efforts going on, in case you wanted to keep an eye on the changes, here's some:

https://github.com/jazzband/pip-tools/pull/1893
https://github.com/jazzband/pip-tools/pull/1896
https://github.com/jazzband/pip-tools/issues/1902
https://github.com/jazzband/pip-tools/issues/1903
https://github.com/jazzband/pip-tools/pull/1904

When using .pip-tools.toml, does there need to be a [tool.pip-tools] section, or should the values be top-level with no section header? Whichever the case, can it be noted somehow in the README?

@AndydeCleyre

When using .pip-tools.toml, does there need to be a [tool.pip-tools] section, or should the values be top-level with no section header?

See these lines:
https://github.com/jazzband/pip-tools/blob/776c3fa3d8b2da155eed7eb9a5b164f78937987a/piptools/utils.py#L656-L657
Maybe this could be simplified for .pip-tools.toml.

Whichever the case, can it be noted somehow in the README?

I think it's explained properly under the configuration section.

Maybe this could be simplified for .pip-tools.toml.

That was the original implementation which, in review, was rejected in favor of consistency.

Thanks. I thought there was a discussion about making it like ruff, but I can't find it so maybe dreamed it. From ruff's docs:

As an alternative to pyproject.toml, Ruff will also respect a ruff.toml (or .ruff.toml) file, which implements an equivalent schema (though in the ruff.toml and .ruff.toml versions, the [tool.ruff] header is omitted).

Thanks. I thought there was a discussion about making it like ruff, but I can't find it so maybe dreamed it. From ruff's docs:

As an alternative to pyproject.toml, Ruff will also respect a ruff.toml (or .ruff.toml) file, which implements an equivalent schema (though in the ruff.toml and .ruff.toml versions, the [tool.ruff] header is omitted).

FTR, that discussion that you're recalling was about the need to have the section header in all of the files or not. It was you who mentioned Ruff in that context: https://github.com/jazzband/pip-tools/pull/1863#discussion_r1187752607.
And I made an argument that it's more consistent to have this header in all files: https://github.com/jazzband/pip-tools/pull/1863#discussion_r1188761535. It makes it easier to copy the section over between different files. And now I think that when the end-users want to have several sections in their non-pyproject config, they can only do so when there are sections in the file.


RFC: Postfix for wrappers

Feature wrappers enables zero cost wrappers. Those implement core::cmp::{PartialEq, PartialOrd, Ord} (where applicable) by forwarding to camigo::{CamiPartialEq, CamiOrd}. They also implement Deref and friends.
Names of those wrappers start with the same name as what they wrap (for example, String), because that part of the wrapper's name is what matters to the developer.
For the second part of the name I've considered: Wrap, Core, Std, Ord (or Eq for types that can't be ordered) - all confusing. I resort to Cami.
Any other views?

N/A anymore


MWPW-136847 add query-index config for uk

Add query index for uk
Resolves: MWPW-136847
Test URLs:

Before: https://main--express--adobecom.hlx.page/express/
After: https://MWPW-136847-query-index-uk--express--adobecom.hlx.page/express/

Codecov Report

Merging #289 (9d59727) into stage (47ed500) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            stage     #289   +/-   ##
=======================================
  Coverage   47.19%   47.19%
=======================================
  Files          31       31
  Lines        9359     9359
=======================================
  Hits         4417     4417
  Misses       4942     4942

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Debugger

In order to be able to debug within intelliJ.
A first step would be:
To create a server compatible with java debugging that connects to javascript or haxe debuggers and transforms commands and results.
Another step could be to create a intelliJ plugin that directly connects to proper debugger protocol.

Miss to reference these:
https://github.com/jtransc/jtransc/commit/2ebb260465e1db86a88f125a4abecc0469e60013
https://github.com/jtransc/jtransc/commit/64c2a055121cc4d7fe4dfd89f6a104f0dd8a13dd
https://github.com/jtransc/jtransc/commit/9a4be242f1436a4c5f912da309bb6078c5c35ca0
https://github.com/jtransc/jtransc/commit/498379ab37028e3217574dcd3c0dce67c1e50779
https://github.com/jtransc/jtransc/commit/3f722d3ccc6b118c159dacf11fe1a64afc7a8098
https://github.com/jtransc/jtransc/commit/ebee740ee5e843d5eb2fbdfd9373b75df017f546
https://github.com/jtransc/jtransc/commit/457858e8e178511c2ab4297dbf0f1c60def13da1
https://github.com/jtransc/jtransc/commit/f933762708155f6c753cedf4af42529d1ded98e1
https://github.com/jtransc/jtransc/commit/4630b3a070b932233069fbfa8d9847873824861f
https://github.com/jtransc/jtransc/commit/cd25ec900d8b9ab4a1904b35592288e2582d612e
https://github.com/jtransc/jtransc/commit/dbb1a209814fc0e392c83918045bf0d41203e5a0
https://github.com/jtransc/jtransc/commit/476f237ed111ca7f8d9577a3b318be809b355765
https://github.com/jtransc/jtransc/commit/2b36a81892be9cbef22f4b72772c3edec4f34278


Changing cursor to pointer when hovered over Get Set Go[FEATURE]

Right Now Get Set Go button doesn't have hover effect of cursor to pointer. I want to work on this issue.

A similar issue has already been raised #130


Merge 0.17 into master

@lorefnon After this is merged, it might make sense to start first merging changes that are relevant to 0.17 into 0.17 branch, and then to merge with master via direct 0.17 -> master pull requests. Still gonna cause conflicts in some cases (e. g. when touching typings that had their type converted from Bluebird to Promise), but hopefully will simplify usual cases.

Can we expect the ts extension fix to be included in this release or just the next one?

@dgadelha How urgently do you need it? I can cut a 0.17 release with it now, or including the migration extension fix in a couple of days.

Not so urgent, no problem if it takes a few days.


Add this to NPM?

Looks fit for purpose. Why don't you open it up as a package?

Good idea, I'll add it to NPM this weekend. I'll add JSDoc to it as well.

Don't worry, I haven't forgotten about this. I just finished polishing the code, adding stuff to it and documenting it with examples. Unfortunately, Facebook revoked my user_photos permissions, because I forgot to resubmit it, so I'm going to reapply so I can fully test out all of my changes and create an official version 1 I'll submit to NPM.

@D-Marc1 want me to be a contributor? Happy to review and finesse

I just updated repo to convert to promises, add JSDoc with examples, add a getProfilePicture() method and reorganize the file structure.  That would be awesome if you could review my changes. You can simply download the repo with my demo and change the addId on index.html. I couldn't figure out how to document the public properties I used, but I'll look into that as well.

It's on NPM now https://www.npmjs.com/package/facebook-javascript-all-photos.


Improve the Functions docs

We currently support a number of different ways to fetch existing resources or properties of resources:

Getter functions
Provider functions
Provider methods
Output methods (e.g., those called from within serialized functions, like .get())
Probably others?

Our existing docs, however, don't do a great job of explaining exactly how these functions are different and what use cases they solve. We should review these pages and look for ways to improve them -- e.g., consolidating where it makes sense, cross-referencing where it may not, and providing additional explanation and examples that better illustrate how to use them in practice.

@cnunciato Does this need to go on the Docs board instead of the DevRel board?


How to solve the problem of size mismatch?

Hi,
Thank you very much for your help, I successfully obtained MSVD_C3D.hdf5.
When I replaced MSVD_InnceptionV4.hdf5 with MSVD_C3D.hdf5 in RecNet and ran python train.py-c configs.train_stage1, I had a size mismatch error.
RuntimeError: size mismatch, m1: [5600 x 4096], m2: [1536 x 256] at /pytorch/aten/src/THC/generic/THCTensorMathBlas.cu:266
I don't know how to adjust the size, can you help me solve the problem?
Specific error contents are as follows:
Epoch 1

[TRAIN]
Traceback (most recent call last):
  File "train.py", line 166, in <module>
    main()
  File "train.py", line 137, in main
    C.reg_lambda, C.recon_lambda, C.gradient_clip)
  File "/home/RecNet/utils.py", line 52, in train
    output, feats_recon = model(feats, captions, teacher_forcing_ratio)
  File "/home/RecNet/.env/local/lib/python2.7/site-packages/torch/nn/modules/module.py", line 489, in __call__
    result = self.forward(*input, **kwargs)
  File "/home/RecNet/models/caption_generator.py", line 110, in forward
    teacher_forcing_ratio)
  File "/home/RecNet/models/caption_generator.py", line 36, in forward_decoder
    output, hidden, attn_weights = self.decoder(output.view(1, -1), hidden, feats)
  File "/home/RecNet/.env/local/lib/python2.7/site-packages/torch/nn/modules/module.py", line 489, in __call__
    result = self.forward(*input, **kwargs)
  File "/home/RecNet/models/decoder.py", line 53, in forward
    feats, attn_weights = self.attention(last_hidden, feats)
  File "/home/RecNet/.env/local/lib/python2.7/site-packages/torch/nn/modules/module.py", line 489, in __call__
    result = self.forward(*input, **kwargs)
  File "/home/RecNet/models/temporal_attention.py", line 20, in forward
    Uv = self.U(feats)
  File "/home/RecNet/.env/local/lib/python2.7/site-packages/torch/nn/modules/module.py", line 489, in __call__
    result = self.forward(*input, **kwargs)
  File "/home/RecNet/.env/local/lib/python2.7/site-packages/torch/nn/modules/linear.py", line 67, in forward
    return F.linear(input, self.weight, self.bias)
  File "/home/RecNet/.env/local/lib/python2.7/site-packages/torch/nn/functional.py", line 1354, in linear
    output = input.matmul(weight.t())
RuntimeError: size mismatch, m1: [5600 x 4096], m2: [1536 x 256] at /pytorch/aten/src/THC/generic/THCTensorMathBlas.cu:266

Hi,
I think that's because the sizes of the InceptionV4 (1536) and C3D (4096) features are different. You can add a few lines in here, as follows
class FeatureConfig:
    models = [ "MSVD_InceptionV4" ]
    size = 0
    for model in models:
        if 'InceptionV4' in model:
            size += 1536
        elif 'C3D' in model:
            size += 4096
        else:
            raise NotImplementedError("Unknown model: {}".format(model))

Thank you very much for your help.
When I modified it according to your suggestion, I encountered a new problem. I tried to fix it, but I felt that my ability could not solve the problem.
RuntimeError: The size of tensor a (4096) must match the size of tensor b (1536) at non-singleton dimension 1
Specific error contents are as follows:
Epoch 1

[TRAIN]
Traceback (most recent call last):
  File "train.py", line 166, in <module>
    main()
  File "train.py", line 137, in main
    C.reg_lambda, C.recon_lambda, C.gradient_clip)
  File "/home/RecNet/utils.py", line 59, in train
    losses.global_reconstruction_loss(feats, feats_recon, keep_mask=(captions != PAD_idx))
  File "/home/RecNet/losses.py", line 24, in global_reconstruction_loss
    l2_loss = F.mse_loss(x, x_recon)
  File "/home/RecNet/.env/local/lib/python2.7/site-packages/torch/nn/functional.py", line 2151, in mse_loss
    ret = (input - target) ** 2
RuntimeError: The size of tensor a (4096) must match the size of tensor b (1536) at non-singleton dimension 1

First of all, it seems that your code is not the newest, as I modified the codes so that the reconstructor is not used in the first stage of training. If you get the latest code, the problem will be fixed.
Second, you should have changed this line for a global reconstructor or this line for a local reconstructor, which seems to be better to be just set to match the dimension of features we use. I'll fix it right away.

Thank you for your help. This problem has been solved.


DotSpatial Plugin ShapeEditor not working

Hi to all
I'm new on DotSpatial, and I'm checking about this fantastic plugin ShapeEditor. but It appears not working as well, I attempt to create new Shape, and I save as ShapeFile, then, Adding new point, but it doesn't adding anything.
Does you help us?
Kind regards
PD: Sorry for my bad english!

Sorry!!. I will create a issue into a DotSpatial codePlex!.. Sorry!!


Add "docs" metadata to pubspec

At some point, we plan to hook up automated Dartdoc-generated docs for packages. But, in addition to that, many packages also maintain their own documentation web sites. It would be nice if those could be easily linked to from a package's page.
One simple fix is to add another field to the pubspec similar to "homepage" that specifies a documentation URL. If present, pub.dartlang.org will include that link on the package's sidebar.

This issue has been moved to dart-lang/pub#421.


Detect entrypoint when one is not provided

When running wrangler dev, if no entrypoint is provided, wrangler should check for one in the following places.

main/module in package.json.
build.upload.main in wrangler.toml.

Alternate proposal - we should only have explicit CLI args for entry. Copied from https://github.com/cloudflare/wrangler2/pull/258#issuecomment-1016289886:
I'm deeply concerned with the ambiguity we've introduced. wrangler dev can now point to either something hidden inside a wrangler.toml file somewhere, or an index.js file locally, or (not implemented yet) the main field in a parent package.json, or (not implemeted yet) the entry field in wrangler.toml, and there's no way to tell without running the command. We should resolve this before we ship to GA.
imo, we should deprecate build.upload.main, not implement the proposed entry field, and not read from package.json. We should only have explicit path in CLI.

This probably deserves a deeper discussion, let's take it up during the meeting.

ping

Deciding against this, for the reasons you outlined.


(PUP-11166) Remove unnecessary Dir.chdir

Commit fecf5d69 called Dir.chdir followed by Dir.glob('*'). Commit 6d499bde
switched to Dir.entries, but didn't remove the Dir.chdir.

nit: I think the last clause in the commit message:

but didn't remove the glob
should be:
but didn't remove the Dir.chdir

jenkins please test this with servertests

Thanks @justinstoller, updated!

jenkins please test this with servertests

jenkins please test this with servertests

Two :+1: and beaker tests passed so I'm merging


[WIP] Support custom address broadcasting for ringpop to work in k8s

What changed?
 Ringpop is initialized with the address that the service instance (container) is going to listen on and it gets advertised to peers. This is problematic because listen address of replicas are not unique and cannot be used to communicate peer to peer.
Local listen address (BIND_ON_IP) should be set to <IP_ADDRESS> and the pod's ip address (10.x.y.z) should be used to join the ring for p2p. Pod's IP address is accessible by other pods in the k8s cluster.
This PR introduces ringpop.broadcastAddress config which will make ringpop work in k8s environments.
For example:

History-service-container-replica-1:
listens and serves on <IP_ADDRESS>:7934
broadcasts itself to peers as <IP_ADDRESS> (its own pod ip)

History-service-container-replica-2:
listens and serves on <IP_ADDRESS>:7934
broadcasts itself to peers as <IP_ADDRESS> (its own pod ip)

A headless k8s service can be used for discovery which will return list of pod ips 10.x.y.z.
This can be achieved on K8s by passing pod's IP address as an env variable.
 - name: BIND_ON_IP
    value: <IP_ADDRESS>
 - name: BROADCAST_ADDRESS
    valueFrom:
       fieldRef:
          fieldPath: status.podIP

Ringpop config would look like this:
ringpop:
    name: cadence
    broadcastAddress: <IP_ADDRESS>
    bootstrapMode: dns
    bootstrapHosts:
    - cadence-history-headless.namespace.svc.cluster.local:7934
   ..

Other misc changes:

Added backoff retry for ringpop bootstrap initialization
Added self addr/identity/ip tags to hashring view log

How did you test it?

Locally built a cadence image and tried it on a K8s cluster.
WIP: ringpop provider unit tests - they don't exist at all so adding from scratch

Is there any kind of K8s concept of hostname that can be used to refer to the instance rather than introducing an awareness of the container's own hostport/ip? I'm not sure this would work in mesh-networks  (Not that I have any experience with them)?
also, why do we need to bind on <IP_ADDRESS>? Wouldn't binding on the same IP as what's exposed work?

Is there any kind of K8s concept of hostname that can be used to refer to the instance rather than introducing an awareness of the container's own hostport/ip? I'm not sure this would work in mesh-networks (Not that I have any experience with them)?
also, why do we need to bind on <IP_ADDRESS>? Wouldn't binding on the same IP as what's exposed work?

This setup is more typical in K8s. Binding on <IP_ADDRESS> makes it easier to serve requests targeted to IPs/dns etc. Also makes it possible to port-forward for debugging.
There's a concept of pod name which can be passed as env variable similar to pod ip. It can't be used as resolved address. Pod IP is the way to go because that's what headless k8s service will return (used by dns provider)


Review and gather feedback around latest form wireframes

Description
Definition of done

[x] Present and get feedback from core team
[x] Present and get feedback from IER + ELS [6/27]
[ ] Feedback from VOT + HCE [7/1]
[x] Feedback from DRS  [Friday 6/28] - EOS ppt not in deep dives
[x] Feedback from SPL + CRM + FCS [6/27] - FCS & CRM ppt not in deep dives
[ ] EOS

Attachments

iNvision form experience
Form presentation for section walkthrough

from @Jacklynn : UX research on dropdown - they tend to be less usable, especially for long lists of unfamiliar items (types of respondents vs as opposed to country names) https://www.nngroup.com/articles/drop-down-menus/

(for internal use only) https://web-silly-alligator.app.cloud.gov/form/1-fierce-flamingo

@AvivaOskow to update the invision link on this card

I can separate these out into smaller tasks


Templates not working properly

After the latest update loading a import at for example:
/imports/dropdown/dropdown.html
Just returns the entire meteor app.
I have the latest of everything and angular2-polyfills, angular2-runtime, and angular2-compilers installed.
I'm not seeing the "Compiling html template" message anymore.
Pretty big problem, any ideas @barbatus ?

Use relative paths for the node resolution mode. And please read docs casually.

And please read docs casually.
Worked fine in the last version, latest update just broke the app

again, same type of language I don't think belongs here.
please stop.

?? What type of language are you referring to?
Again you condescending tell me to read the docs when there's nothing in the docs about this, and expect me to accept that as a response.

I didn't say who said the bad comments.
If you see that the conversation is going to a wrong place, even if it's not your fault, please email me.


Single test file causing "heap out of memory"

🐛 Bug Report
Jest is crashing when running a single test file. Example failing CI log can be found here.
Issue seems to be related to the following function being called many times:
const waitForAsync = (delay = 20) => new Promise(resolve => setTimeout(resolve, delay));

To Reproduce

Checkout the branch

git clone https://github.com/andyrichardson/tipple.git
cd tipple
git checkout 03819cf06bd9a750d7958c5d0332607d6d3860ce

Run tests

npm run test -- --watch useFetch

Expected behavior
Tests run and at the very worst, fail.
Actual behaviour
Tests crash and don't terminate until a heap error.
Link to repl or repo (highly encouraged)
See above
Additional info

Commenting out the await waitForAsync(); calls on lines 234/237 causes the test to complete

Running any tests in isolation causes tests to complete

Calling global.gc() after each test does not resolve the issue.

Run npx envinfo --preset jest

Note: this is failing on macOS and Linux

Paste the results here:
  System:
    OS: macOS 10.14.5
    CPU: (12) x64 Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz
  Binaries:
    Node: 8.12.0 - ~/.nvm/versions/node/v8.12.0/bin/node
    Yarn: 1.12.3 - ~/.nvm/versions/node/v8.12.0/bin/yarn
    npm: 6.9.0 - ~/.nvm/versions/node/v8.12.0/bin/npm
  npmPackages:
    jest: 24.8.0 => 24.8.0

Would appreciate if someone can update the tags for this issue as a repro has already been provided 👍

Hey! I've inspected the code and isolating the test run to this test only makes it pass:
--- a/src/useFetch.test.tsx
+++ b/src/useFetch.test.tsx
@@ -220,7 +220,7 @@ describe('on invalidation', () => {
   });
 });

-describe('on cache change', () => {
+describe.only('on cache change', () => {
   let instance: renderer.ReactTestRenderer;

   beforeEach(() => {

Looks like you have issues somewhere in your code, so for now I'd say it's not a problem with Jest. Closing.

@thymikee thanks for taking a look 👍
You're totally right, isolating each of those tests or only running some of them succeeds. But I'm not sure how you came to the conclusion that this issue is not a problem with jest?
If there was a problem with my code, jest should fail or time out, right? Running the reproductin, you'll see that jest is crashing and never terminating.
Please reopen 📂

It's likely not the tested code, but tests/test setup itself. At any point in time your tests should work when you rearrange them – i.e no implicit dependencies on following test cases should be present. Maybe you mock something and forget to unmock for example?
I'm happy to reopen once you can prove it's actually Jest fault on a minimal viable case. Also, if you think Jest can make better job at debugging such issues, please create a PR or a feature request :)

@thymikee I also have come across this problem on urql. If you can give me some pointers as to where in the repro this might be going wrong that would be hugely appreciated. There aren't any implicit dependencies in the reproduction or in urql.
There's a diff here demonstrating the changes needed to make jest crash (you'll only need to look at the useQuery or useSubscription hook). In this example, the broken tests occur after refactor of a utility function into a hook. I suspect the added depth to the stack is somehow related.

Quick update on my findings - no actual progress but it looks like these issues are somehow related to the instantiation of Promises.
The original issue demonstrates how instantiating multiple Promises inside a test file (see the waitForAsync example) causes jest to crash and become unresponsive.
After tracing the calls in the urql reproduction, it looks like jest outright stops responding when creating an instance of a Promise (on this line).

Interesting, does it happen with jest-circus as well (alternative runner for Jasmine)? https://github.com/facebook/jest/tree/master/packages/jest-circus

Yep it does indeed. I'm starting to think the issue is somehow related to react-testing-renderer hogging the main thread with an endless while loop - although I'm not sure as I would have expected the jest timeout to terminate the tests even if react-test-renderer were to continue running.

@SimenB @jeysal thoughts?

Done lots of tests w/ async and react-test-renderer but never seen something like this, no idea where it could come from without digging deep, sorry 😐

I would have expected the jest timeout to terminate the tests even if react-test-renderer were to continue running

It won't, Jest basically does a setTimeout to enforce the test timeout too, adhering to standard event loop usage - there's no thread or process or something running that'd send a signal to forcibly exit an infinite loop, so something like that seems like a probable cause

Wanted to follow up on this - I've seen problem on many different projects since reporting this (my own and other people's).
Pretty sure it's a memory leak - #7874


[WARN  tini (20)] Tini is not running as PID 1 and ... warning when newly committed container started.

Recreation steps:

$ x11docker --xpra -f  --home -c --sudouser --user=RETAIN --pulseaudio --sharedir=$HOME/Downloads ucberkeley/firefox-browser-gui

then while that container running with new terminal connect with:

$ docker exec -it x11docker_X100_a622ed_ucberkeley-firefox-browser-gui bash

then in this terminal make some changes for example:

$ sudo apt update

$ sudo apt-get install software-properties-common

test installation with:

$ sudo add-apt-repository

installation successful.
then close that connected terminal or don't close it won't change the outcome, and with new terminal

$ docker commit "containerid" some/imagename

it should create the new image.
then close or don't close the container it won't change the outcome and try to start a new container from your newly created image:
with one of these:

$ x11docker --xpra -f  --home -c --sudouser --user=RETAIN --pulseaudio --sharedir=$HOME/Downloads some/imagename
or
$ x11docker --xpra -f  --home -c  --user=RETAIN --pulseaudio --sharedir=$HOME/Downloads some/imagename
or
$ x11docker --xpra -f  --home -c  --pulseaudio --sharedir=$HOME/Downloads some/imagename
or
$ x11docker --xpra -f  --home -c --pulseaudio --sharedir=$HOME/Downloads some/imagename

the output is like this:

[WARN  tini (20)] Tini is not running as PID 1 and isn't registered as a child subreaper.
Zombie processes will not be re-parented to Tini, so zombie reaping won't work.
To fix the problem, use the -s option or set the environment variable TINI_SUBREAPER to register Tini as a child subreaper, or run Tini as PID 1.
[WARN  tini (34)] Tini is not running as PID 1 and isn't registered as a child subreaper.
Zombie processes will not be re-parented to Tini, so zombie reaping won't work.
To fix the problem, use the -s option or set the environment variable TINI_SUBREAPER to register Tini as a child subreaper, or run Tini as PID 1.
[WARN  tini (48)] Tini is not running as PID 1 and isn't registered as a child subreaper.
.
.
:

then terminate the process with frustration and  ctrl + c then go to https://github.com/mviereck/x11docker/issues/new to create a new issue and win back your sanity.
Also this warning is not a just a warning and container does not function as it should be.

Ok, I see ...
I'll check it out.
As a first shot, try to run the new image with --init=none.

Ok, I see ...
I'll check it out.
As a first shot, try to run the new image with --init=none.

Warning is gone gone but issue continues. This time there are no warnings but also there is no window even though xpra indicator indicates that there is a one. I don't know if 2 cases related to same cause or have different causes. also

x11docker note: Found 'USER 1000:1000' in image.
If you want to run with user 1000:1000 instead of host user me,
than run with --user=RETAIN.

this note on recently created image container can be a clue for you.

I did some tests, it affects arbitrary images regardless of used options.
The issue seems to be a recursive call of /x11docker/x11docker.CMD.sh that is part of the CMD in the origin container and also gets created in the new container.
I have no idea yet how to allow docker commit and to avoid the recursion, I'll think over it.
Another approach:
Instead of docker commit build a new image with a Dockerfile, e.g.
FROM ucberkeley/firefox-browser-gui
RUN apt-get update
RUN apt-get install -y some-packages

A new image created this way will work without issues.

I've had a closer look and don't see a good and clean way to resolve this.
I recommend to create new images with docker build instead as outlined above.
The latest commit to master branch detects this situation and exits with an error instead of running into the recursion loop.
Sorry that I cannot provide a better solution. Thank you for reporting this issue!

To explain the issue:
The problem is that x1docker containers run with CMD command /x11docker/x11docker.CMD.sh. This is a dynamically generated script shared from host.
An image created with docker commit contains this command as CMD to execute, but does not contain the shared script. Running this new image with x11docker generates a file
/x11docker/x11docker.CMD.sh that recursively runs /x11docker/x11docker.CMD.sh.

I forgot this one:
docker commit stores command /x11docker/x11docker.CMD.sh although it does not exist in the created image.
You can use images created with docker commit from x11docker container, but must provide an image command to avoid the recursion.


NULL pointer 'rule->actionset'

At several places in the code, we access 'rule->actionset' without checking if it isn't NULL.
Although we may expect that it's never NULL, this is explicitely checked in the same files/functions at some other places.
Unless it's assessed that it can't be NULL, we must add a check.
In case it really can't be NULL, all checks that it isn't should be removed (and a comment could be added to indicate that).
PS: I was checking this because I have some crashes under high load (unless I removed compila optimization).
List of (possible) problems:
apache2_config.c: 242, 244, 895, 896, 914
re.c: 1634, 1908, 2143
re_operators.c: 2843, 3151, 3443

Indeed that is a good practice to check if a variable is null or not before use it. I see no reason why do not have those checks inplace.

Modification is under our buildbots

Merged at https://github.com/SpiderLabs/ModSecurity/commit/aab128f810dcb8b557d3435fba703805a732b298 https://github.com/SpiderLabs/ModSecurity/commit/96756533bae550df3db929b6bb281d713b8509b3
Thanks.


install istio on vm, but cann't found vm info when exec command kubelet get pod

i install istio on vm, when execute command 'kubectl get pod -A`, not found vm node
install document: https://istio.io/latest/docs/setup/install/virtual-machine/
only view the VM information by executing the command
root@sxf-virtual-machine:/home/sxf# istioctl proxy-status
NAME                                                    CDS        LDS        EDS        RDS          ISTIOD                      VERSION
istio-eastwestgateway-6fd76487d6-kn8nm.istio-system     SYNCED     SYNCED     SYNCED     NOT SENT     istiod-5bdf585695-c5fsq     1.10.3
istio-ingressgateway-697dc5b889-5l6tm.istio-system      SYNCED     SYNCED     SYNCED     NOT SENT     istiod-5bdf585695-c5fsq     1.10.3
vm1.vm                                                  SYNCED     SYNCED     SYNCED     SYNCED       istiod-5bdf585695-c5fsq     1.11.0

why?

VMs do not create pods. A WorkloadEntry represents a single VM workload and is roughly equivalent to pod


v23 does not support "extends" (TS6096)

Issue

I have a tsconfig.json that uses the extends property:
{
  "extends": "../tsconfig",
  "compilerOptions": {
    "module": "CommonJS",
    "removeComments": false,
    "resolveJsonModule": false,
  }
}

Using ts-jest v23 the following error is thrown:
Some errors occurred while attempting to read from /Users/mattyclarkson/git/github/ef-carbon/url/test/tsconfig.json: message TS6096: File '../tsconfig' does not exist.

Works with v22.

Expected behavior

Should allow extended configurations

Output from your debug log

No Output

Link to a minimal repo that reproduces this issue

https://github.com/ef-carbon/url

Optional (but highly recommended) - Configure Travis (or your favorite system) with the minimal repo

CircleCI is working on the repository

I also noticed this when upgrading from 22.4.6 to 23. I think there must be something in v23 that breaks this extend. I think we should check why this is broken but not in 22.4.6

@ahnpnl have to check, but if TS moved from a require() to a readFile(Sync), then removing the extension would break. But typescript also would break when invoking tsc.

@huafu I don't actually run tsc with the test/tsconfig.json, it's just for testing so it's the one that ts-jest sees. However, I do have a lint/tsconfig.json that TS Lint reads that has exactly the same extends property and accepts it fine. Maybe the way that ts-jest uses the readConfig API might be different to the way tsc and TS Lint do it? It's odd that TS would break backwards compatiblity like that. The manual even shows to not include the .json

thanks @mattyclarkson for the info on tslint, I'll look at the given reader there to see which one they use and will try to use

@mattyclarkson it is fixed in 23.1.2, just checked:

I guess the problem is back.  Tried a variety of path revisions, no luck so far.  For me it's occurring as a validation warning when running jest --coverage:
"Unknown option "extends" with value "../../tsconfig.json" was found.
This is probably a typing mistake. Fixing it will remove this message."
Using:
jest: 28.1.3
ts-jest: 28.0.8


Add support to GithubEntityProvider for including (or excluding) Github repositories by topic

Hey, I just made a Pull Request!
This PR is one possible implementation of #13329 which is something I've been after for some time.
For orgs that are larger, they may have many repos that are not relevant to Backstage such as practical tests, experiments, team-specific helper tools and more.
Personally I prefer to explicitly exclude repos based on a topic while @timja expressed interest in the opposite so while this PR adds a topic filter, it also adds a toggle for determining whether the presence of that topic should exclude or include any locations from being created.
Based on the discussion in that issue, it seems like there is probably potential for a search-based provider down the track for even more dynamic queries but for now, this PR suits the use case that I have personally.
I believe this should help with rate limiting as well. Let's say you have say; 2000 repos but you only care about 500 of them.
You will still end up using 20 calls (100 per page) to iterate through all of the repos but you can still avoid 1500 locations which translates into 1500 API calls for something that you're not using so I think overall, it's a benefit but not as much as say; a search based provider or webhooks.
I'll also note that I intentionally didn't bother fetching more than the first 100 topics because I feel like having a repo with 100 topics is pretty rare for the vast majority of users? 🤷
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Aww, documentation check failed because I used the word hackathon as an example 😭

@jhaals It looks like the E2E test failed due to the Backstage logo SVG? 😅 Besides that, this PR is ready for a re-review


4.9 regression with in operator: object is incorrectly narrowed to never

Bug Report

🔎 Search Terms

🕗 Version & Regression Information

This changed between versions 4.8 and 4.9

⏯ Playground Link

Playground link with relevant code
💻 Code

export const checkIsTouchDevice = () =>
    "ontouchstart" in window ||
    "msMaxTouchPoints" in
        // ❌ Unexpected TS error: Property 'navigator' does not exist on type 'never'
        window.navigator;

I've reduced it down to this:
declare const obj: { a: unknown; b: unknown };

"a" in obj ||
    "prop" in
        // ❌ Unexpected TS error: Property 'b' does not exist on type 'never'
        obj.b;

This is an effect of #50666.
The error in the second example looks correct. The type { a: unknown, b: unknown } specifies that property a is always present, and thus the false branch of || is assumed to be unreachable. If you change the declaration to a?: unknown, the false branch is assumed to be reachable (which produces a different error because obj could be a non-object).
However, we do have an issue in the first example. The window variable has type Window & typeof globalThis and the ontouchstart property is indeed marked optional in the Window type. However, typeof globalThis is constructed from the types of all global var declarations, and it isn't possible to mark those optional. So, the var declaration for ontouchstart in lib.dom.d.ts causes the checker to assume the window.ontouchstart property is always present. And that causes the problem. Looks like we need to imply optionality when the global variable type includes undefined.

… property a is always present, and thus the false branch of || is assumed to be unreachable …

Couldn’t this be a problem for feature tests?  i.e. testing for existence of methods or properties that are always-present according to the types, but the program wants to gracefully degrade if the browser doesn’t support them.  That’s what I assumed the ontouchstart check in the OP was, actually.

Well, there's sort of a gray area when it comes to non-optional properties of type unknown or types that include undefined. We could limit the narrowing to only happen in cases where the type unequivocally indicates the property can't be undefined and therefore must be present.

Hmm, turns out our compiler itself actually contains code that depends on narrowing based on in checks for properties that can be undefined. So, it seems we need to stay with the absence of a ? modifier being an indicator that a property is always present and such that in tests for that property can guide narrowing.


We allow only first-party and affiliated apps to be redirected to when installing libraries. We'll also be redesigning the installation flow, soon.
If you want to install excalidraw.com libraries from your custom app, the best bet right now would be to install from the github directly.


Cubify all command

L->C
A->C
V->C
H->C
Q->C
S->C
T->C

This usecase is need for getting prepared paths for my tweening library.
This feature i am request for GUI, not JS

I don't think I'll get to this. Shape Shifter users don't need to care about the specific types of commands that are being used... they only care that the commands are converted into something that is in a compatible format and that can be morphed.
Are you sure your tweening library can't convert everything to cubic bezier curves instead?

No my tween lib just changes number


User Can Find Help & Report Bugs

Success looks like:

README has a clear instructions on how to report bugs/issues (such as the Github issue tracker).

How to get help during the business day if the app is not working (an email address, slack group, etc.).

Failure looks like:

User has no idea how to report bugs in the app, so they are not reported and can go unnoticed by our team for weeks or months
A user (such as an IBMer) need to show the app to a customer but the app is not working (maybe because a service name changed that the app uses) and they have no idea how to get help.

README has the info


[WIP] Functional tests

@kdodia is this ready to be reviewed?

@brittainhard This is ready for review; tests pass locally. Once I learn how to get Travis to run Selenium tests it'll be ready to merge.


gas & water meter not appearing in HA energy dashboard

According to HA the integration fails to show in the dashboard because of incorrect statistics and tells me to notify the developer of the following about statistics: https://developers.home-assistant.io/docs/core/entity/sensor/#long-term-statistics
Energy seems to work fine and can be selected as a source in the dashboard, but both the gas and water meter cannot.
When comparing the three meters, all necessary information seems to be present, the only difference I see is energy is state_class "total" vs gas & water have state_class "total_increasing"? Could that be the issue or is there something else?

Strange, I have my pixometer watermeter sensor connected to the energy dashboard of Home Assistant.
Maybe some sensor statistics might need to be cleaned within HA, as I only recently fixed the state_class.
Within Menu Developer > Statistics, could you check if there are not warnings with a 'Fix this' option that may resolve this issue for you?

 I simply repaired the pixometer items and could add them to energy dashboard after that! Thanks


Python requirements install fail - ERROR: Could not find a version that satisfies the requirement

Note from @isc-tleavitt: most likely the need here is to make the --only-binary=:all: flag configurable in IPM.

The specific error is:
56.61 ERROR: Could not find a version that satisfies the requirement pyiceberg==0.8.0 (from pyiris-iceberg) (from versions: 0.0.1, 0.1.0rc1, 0.1.0rc2, 0.1.0, 0.2.0rc0, 0.2.0rc1, 0.2.0, 0.2.1rc0, 0.2.1, 0.3.0rc1, 0.3.0rc2, 0.3.0, 0.4.0rc1, 0.4.0rc2, 0.4.0)
56.71 ERROR: No matching distribution found for pyiceberg==0.8.0

The problem is in the flags provided to pip:
50.32 Running command=$lb("python3","-m","pip","install","-r","requirements.txt","-t","/usr/irissys/mgr/python/","--python-version","3.10.12","--only-binary=:all:")

I have solved by not installing via IPM. It does seem like there are wheels for all platforms and versions, (https://pypi.org/project/pyiceberg/0.8.0/#files). I'm not sure that this is a bug in IPM, but can't quite figure out why pip can only see up to version 0.4.0, which is from july of 2023. I upgraded pip, but that did not fix.

I also find this mystifying. @isc-shuliu could you take a quick look when you get some spare cycles?

Repo for this: https://github.com/isc-patrick/pyiris-iceberg

Hunch: I think the issue is probably the --only-binary=:all: flag; https://github.com/apache/iceberg-python/actions/workflows/python-release.yml?page=4 seems to indicate that the build process started as of 0.5.x which lines up with the point where the list of versions you see ends.
It would be helpful to know if pip install, not via IPM, with the --only-binary=:all: flag hits the same issue on the environment where you see this. Looking at the actual contents of the artifact from https://github.com/apache/iceberg-python/blob/main/.github/workflows/python-release.yml there are fewer wheels than I'd expect from looking at the CI workflow's definition - macosx_10 and macosx_11 (nothing higher) and no arm64 linux.
From an IPM perspective, it would be nice if the --only-binary=:all: flag was configurable.

pip install outside of IPM still has the same problems, if using the --only-binary=:all:. I should have been more clear in my initial post. By args to pip, I meant the --only-binary=:all: and --python-version 3.10.12 args, and by solved by not installing with IPM I meant removing those args.

This is tricky. We usually need the --python-version flag to ensure we're installing a distribution compatible with the embedded python. Yet, one can't specify --python-version without setting --only-binary/--no-binary.
I'll make them optional for now but a better solution is required in the future.

Some notes:

When IPM calls out to pip install, it doesn't know the python version associated with the pip executable. By default, pip looks for packages with its own python version, which can be incompatible with the embedded Python of IRIS.
pip supports --python /path/to/python/venv/ or --python /path/to/python/interpreter to manage environment of a given python interpreter. However, while IRIS doesn't comply with Python interpreter interface (meaning you can't run a python script with irisdb myscript.py).
pip also supports --python-version=<version>. But this must be used together with --only-binary=:all:. More importantly, --only-binary=:all: does what it says. It won't default back to source distribution even if binary distribution isn't found.
pip also supports --no-binary=:all:. This will force compilation of C extensions, which is almost always a bad idea:

The compilation tools and libraries may not be found on target systems
The build processes may fail if the build scripts are not well-maintained
Even if it works, compilation is very time consuming and may lack many optimizations

Ultimately, pip was not developed to support IRIS Embedded Python. Here are some ways to try:

Run pip install from embedded python: import pip; pip.main(["install", "-r", "requirements.txt", ...]). Caveat: a) This is discouraged by pip developers. b) We'll need to add a [ language = python ] method
Check pip's python version against embedded python version. If they match, the --python-version and --only-binary flags are no longer needed.
Allow users to choose among 3 options --python-version=3.y.z --only-binary=:all:, --no-binary=:all:, or no flags at all. I'm not sure which is the best default.

I think a combination of 2 and 3 is probably the way to go.


[Unity][TARGET] Updates vulkan codegen for DeclBuffer

This PR updates vulkan codegen to support for DeclBuffer. We also disabled subgroup operations.
This is because we find that on Nvidia GPU subgroup were detected to be 8 and the generated code for softmax produces wrong results.
Setting it to be 32(the typical size of CUDA warp) also does not produce the right result.
We directly hard set the value to 1 to be ensure correctness. The team can revisit this behavior later.

Note: i find this when trying vulkan on stable diffusion models on cuda, so sending to unity first for hotfix, we can cherrypick to main.

Some steps to reproduces for those who are interested, in the web-stable-diffusion repo.
Without this patch will error at softmax op
python build.py --target "vulkan -from_device=1"
python build.py --target "cuda"
python tests/debug/compare_lib.py --stage vae --cmp vulkan

FYI @Lunderberg @masahi

Interesting.  What GPU/driver is this on?  (On my local RTX 3070, both subgroupSize and cudaDevAttrWarpSize return 32.)
Also, is there a specific version of web-stable-diffusion that is required to reproduce the issue?  I'm getting an error when calling relax.transform.RemoveUnusedFunction (here in build.py), as this function was removed in https://github.com/apache/tvm/pull/14336.

Mine was on RTX 4080, not sure about the driver. We are updating the script and can report back once it is ready
| NVIDIA-SMI 525.89.02    Driver Version: 525.89.02    CUDA Version: 12.0     |


no DW pose estimation node

Hi there 👋
Fresh install of this amazing repo but no DW pose estimation node

Thanks a lot

pip install onnxruntime
pip install onnxruntime-gpu

solved the issue


refactor metrics; add multiple functions metrics. Closes #182

niceee, does this output metrics for each? looks like it aggregates them all into one. I think outputting the metrics per-function would be most useful (similar to the list output), since you'd usually want to see if any functions are problematic and hitting throttling etc

make sense, fix in a moment

@tj done

:DDD


Make it possible to use early access builds of OpenJDK

Motivation is to start testing with JDK9, and to be able to run our community build with betas of JDK8 minor releases.
There is an Ubuntu package that downloads and installs JDK9. This appears to be actively maintained. It requires add-apt-repository ppa:webupd8team/java.
https://launchpad.net/~webupd8team/+archive/ubuntu/java
https://launchpad.net/~webupd8team/+archive/ubuntu/java/+packages
Alternatively, we could grab a binary ourselves:
curl -L --verbose https://home.java.net/download/java/jdk9/archive/115/binaries/jdk-9-ea+115_linux-x86_bin.tar.gz

And make that available on the system.
Chef's java cookbook supports an install from a URL, too. See "Production Deployment with Oracle Java" on https://supermarket.chef.io/cookbooks/java.
I've no idea which way to go, so /assign to @adriaanm.

The java cookbook assumes a single JDK, so it's mostly a matter of getting the packages installed. The workers are on ubuntu, so that should be easy. The chef recipe for install java packages is called... java-packages (modulo some underscores).

For now, I've manually installed JDK 9 ea on the behemoths in $HOME/usr/lib/jvm/jdk-9.
I've also exported rt.jar into $JAVA_HOME/scala-ext. With snapshot builds of SBT, or with the yet to be released 0.13.14, this enables:
% export JAVA_HOME=$HOME/usr/lib/jvm/jdk-9
% export PATH=$JAVA_HOME/bin:$PATH
% sbt -Dscala.ext.dirs=$JAVA_HOME/scala-ext
[info] Loading global plugins from /home/jenkins/.sbt/0.13/plugins
[info] Loading project definition from /home/jenkins/code/scratch/project
[info] Set current project to scratch (in build file:/home/jenkins/code/scratch/)
> sbtVersion
[info] 0.13.14-b646662
> eval System.getProperty("java.specification.version")
[info] ans: String = 9
> consoleQuick
[info] Starting scala interpreter...
[info]
Welcome to Scala version 2.10.6 (Java HotSpot(TM) 64-Bit Server VM, Java 9-ea).
Type in expressions to have them evaluated.
Type :help for more information.

scala> System.getProperty("java.specification.version")
res0: String = 9

we have Java 9 now. we aren't using Chef anymore, manual JDK installs are fine.

This has continued to be fine. Sample ticket showing what's involved with upgrading: https://github.com/scala/community-build/issues/1492


Convert mocked VSCode tests into integration tests PoC

I created a small test framework on top of VSCode extension testing runner and playwright tests, extending the existing tests-integration suite.
The main idea is to be able to evaluate VSCode-side code from playwright tests, in a similar way as Page.evaluate / Page.evaluateHandle. Besides, I also introduced the VSCodeHandle to keep remote references to VSCode objects that those functions may return, as well as registering local listeners over remote EventEmitters.
Another nice thing with this approach is that using a library as sinon (I use it to decorate some vscode behaviour) is as simple as installing it with npm install and dynamically import it in the VSCode function to evaluate.
With all this, I was able to create proxies with similar API to the existing mocked VSCode and converting test specs to use the integration library is as easy as changing the import, basically.

Could you help me understand how you intend to be using this? We already have a test harness that scales well enough to allow for large number of tests with options matrices. The idea behind the integration tests is that extension does not fail miserably in the production, they were not intended to be used for correctness testing.

It was just an exercise, to see if it was feasible.
When I was extending the mocked vscode for the embedded trace viewer, I wondered if it was possible to use vscode itself. I then realized that you already had those integration tests, and so I just tried to fill the gaps.

I'll close it as outside of the scope.


Update OG-USA doc

This updates the OG-USA doc to include the open economy options and the gov't interest rate wedge.

Codecov Report

Merging #510 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #510   +/-   ##
=======================================
  Coverage   65.94%   65.94%
=======================================
  Files          48       48
  Lines        5714     5714
=======================================
  Hits         3768     3768
  Misses       1946     1946

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db218e6...7bde4ee. Read the comment docs.


[BUG] Flakehell doesn't respect per-file-ignores specified in .flake8 config file

So I tried to use per-file-ignores to ignore a specific error (S101 in tests).
When I run flake8 command, the setting is respected but when I run flakehell lint, it also lists those errors that I marked as ignored.
I checked that another option, ignore, is respected equally in both commands so I assume that the issue is somehow related to this option specifically.

Oh, it's a duplicate of #34.


added fetchX smarty functions for db queries from template

Fetch data from the database using the smarty functions:

fetchOne - fetches a single value from the specified column of a row
fetchRow - fetches the first row from the specified table
fetchAll - fetches all rows from the specified table

The following parameters are available

var - required for fetchRow and fetchAll, defines the variable the resulting array will be stored in
select - may either be of type string or array, specifies the columns to be fetch, required for fetchOne
from - required for all functions, specifies the table to be fetched from
where - must be of type array, must contain key value pairs in the format of '[column][operand]' => value
order - must be of type array, must contain key value pairs in the format of '[column]' => '[ASC][DESC]'
offset - must be of type integer, sets the offset for the first result
limit - must be of type integer, sets the limit of results

Examples
{* Fetches the price of the last article added to basket of the current user *}
{fetchOne select="price" from="s_order_basket" where=["modus =" => 0, "sessionID =" => $smarty.session.Shopware.sessionId] order=["id" => "DESC"]}

{* Fetches the name and description of the 5th to 15th article *}
{fetchAll var="articles" from="s_articles" offset=5 limit=10}
{foreach $articles as $article}
    Article: {$article.name} - {$article.description}<br>
{/foreach}

{* Fetches the last order's id and ordernumber *}
{fetchRow var="order" select=["ordernumber", "id"] from="s_order" where=["status !=" => -1] order=["ordertime" => "DESC"]}
{$order.id} - {$order.ordernumber}

Although I dislike having queries in the template it will help out a lot for small solutions.
I do not like the way how the where expressions are made (or I misunderstand them). If I read it correctly the where array is understood as key value pair whereas key is the prefix and value is a bound parameter. How should an in-expression be written? How should I compare column1 with column2?
I'd like to see the exceptions be wrapped in a FroshTemplateExtension specific exception to have it more obvious in an exception that is caused by this plugin.

You can use in-expressions like this:
{fetchAll var="articles" from="s_articles" where=["id IN" => [3, 6, 9]]}

I realize it's a little clunky to have the column and expression within a single string. I just fear that abstracting expressions further might lead to an overblown documentation when each expression needs to be documented. Also it should be noted that this whole feature needs to be treated with care, obviously don't use user inputs for setting column and expression etc.

As for using two columns in an expression, I would suggest omitting the value and writing the whole expression in the key e.g. ['column1 = column2' => null]

I have fear what template developers does with that. I am thinking about a case, where the theme developer could open a new security issue

Yes, I knew you would say that because I know your stance on that issue. 😂  But may I ask you to provide an example? The only real risk I see would stem from theme developers compiling raw user inputs as smarty syntax.  While giving away the contents of your database at this point (which, of course, would be worse enough), at least you wouldn't be able to inject malicious sql. I tried to break it in every way but couldn't get any statements to be executed aside from the select statement.    Imagine a frontend designer just fixing a thing in a small agency. Sees this plugin in the shop and sees that it can be used to read somethings from the database. I can see it happening.
An other topic. What about caching? Can I break caches so data will always be loaded from the database? Or the other way around? How can I ensure it is cached?

Well, I disagree, I can't provide software for toddlers. I'm talking about people that think {include file="string:"|cat:$smarty.request.foobar} is a good idea.  You can only go so far protecting users from themselves before becoming paranoid and removing any kind of customization.
About caching. Queries that are identical, judging by the provided parameters, are being "cached" during runtime only. For example: Lets say you iterate over products and want to fetch the name of the related category by id. Some products will share the same category id so I execute that query with only once, store the result and return it on the next iteration that includes the same category id within the service.
So there is no cache between requests and I think that should be expected, since I think it's the point of querying the database directly to retrieve live data. You wouldn't cache queries you fire within your controller actions, right? If you want and need caching, that's what the http cache is for.

That is fair point. I guess then there should be at least a hint in the readme that SQL injection is a thing and it is possible with this plugin to have ones if missused. I guess then there you can still say: RTFM ;)
Sorry for using the term cache in an abstract way. I was thinking about the http cache. I expect it to use the http cache but can I also break the http cache with just your extension? Or do I have to make my template an action then?

@shyim how about an option in the plugin configuration to enable/disable the fetchX functions coupled with a tooltip explaining potential risks? could be disabled by default, so theme developers that feel insecure about these functions could leave them disabled.

@dneustadt Would be nice :blush:


colors/onenord.vim missing

I think if you create an empty file or one with just a comment for "colors/onenord.vim", then the color scheme will show up is the color scheme completions.
I use the colorscheme switcher plugin, and that definitely won't pick up this scheme because of the missing file.

Hey, what colorscheme switcher are you using? That way I can test it out since it seems to show up for me when doing :colorscheme and :Telescope colorscheme.

https://github.com/xolox/vim-colorscheme-switcher
On Sat, Dec 24, 2022, 2:17 AM Ryan Mehri @.***> wrote:

Hey, what colorscheme switcher are you using? That way I can test it out
since it seems to show up for me when doing :colorscheme and :Telescope
colorscheme.
—
Reply to this email directly, view it on GitHub
https://github.com/rmehri01/onenord.nvim/issues/58#issuecomment-1364477470,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADCZLJSRBJXPUAPH4OW4DDWO2PPJANCNFSM6AAAAAATIJVBCY
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hmm, adding an empty file doesn't seem to work for me, did it for you? Replacing colors/onenord.lua with colors/onenord.vim does seem to do it for me. It also seems like the plugin doesn't work for other lua colorschemes like tokyonight, I'm guessing for the same reason.

Well, the plugin lets you configure a helper command rather than "colorscheme".  I guess that's because some of the newer color schemes, especially lua based ones, have different ways to setup/initialize.  However, the switcher code looks like it is just looking in the "colors" folders for .vim files to get a list of color schemes.
This is my helper command.  I just put the empty "onenord.vim", the switcher finds it.  If I don't, the switcher doesn't find it.
I'm not sure how you're supposed to iterate over color schemes in neovim, so I'm not sure if the colorscheme plugin really is supposed to have a "colors/NAME.vim", by convention, or if that was just a fragile approach taken by the switcher plugin.  In the latter case, I could ask that plugin author to update the switcher code.

Ah I see, thank you for the clarifications! I see that in the neovim documentation, both vim and lua files are allowed, colors/{name}.(vim|lua) so it might just be an issue of this plugin being originally written for vim and not neovim.

Closing for now since it seems like an issue with the plugin being written for vim and not neovim


Streaming exec output isn't working with Boltwash

If I try something like
wash bolt/group/target > wexec . tail -f /var/log/syslog

I get no output.  So live streaming results isn't working.

Actually this might be a problem in Wash itself.

Ok, got the raw invocation and piped it through less and I get the same buffering issue. So not an issue with Wash.

Turns out it's https://github.com/ddollar/foreman/wiki/Missing-Output.


INS command doesn't work in header

When reporting a bug, please provide:

A small reproducible example consisting of the code and .docx template you used.
A screenshot of the result you get and an explanation as to why this result is unexpected.
Information about your compiler toolchain version (e.g. Angular, Webpack, etc.).
Information about your runtime environment (which browser, Electron, or NodeJS version).

I have the following header in my template document with the same command at the end of the same page :

I get the following as a result for the header when downloading :

Is it not a feature to work with the header/footer of a document or am I doing something wrong here ?

That should just work. I wrote an extra test for this just to be sure. Can you check what you are doing differently from this test https://github.com/guigrpa/docx-templates/blob/946cdad1feff1c4756d1585afa953ba8279db1ec/src/tests/templating.test.ts#L1187 that uses this template https://github.com/guigrpa/docx-templates/blob/946cdad1feff1c4756d1585afa953ba8279db1ec/src/tests/fixtures/insertInHeaderAndFooter.docx and report back?

Great to hear that it has been resolved. Thanks for posting the solution. 👍


Added admin_reset_user_password implementation

Hi, I've added a pretty basic admin_reset_user_password implementation. Many corner cases in this area are still unexplored, and I will perhaps attempt to pursue them later on. In particular:

Check user pool AutoVerifiedAttributes  impact on the unverified email/phone number exception
Same for AccountRecoverySetting
Check if, and how does ConfirmSignUp call affect email_verified and phone_number_verified (There's priority - cognito sends OTP to top priority channel, and then 'verifies' it once user sends it back maybe?)
Check if these attributes show up at all in get_user, before OTP is sent - eg. after admin_create_user

I also have a few questions:

Is there any particular reason for the user statuses to be defined as such a strange dictionary instead of an enum?
Are there any plans to add some kind of a spy endpoint for moto server? For example you can check sent emails via importing SES backend in python code, but there's no way to accomplish that in server mode I think?
How about adding a simple Cognito Hosted UI mock?

Awesome - thanks for the PR @nluk!

* Is there any particular reason for the user statuses to be defined as such a strange dictionary instead of an enum?

Not that I can see - an enum should do the job as well

* Are there any plans to add some kind of a spy endpoint for moto server? For example you can check sent emails via importing SES backend in python code, but there's no way to accomplish that in server mode I think?

* How about adding a simple Cognito Hosted UI mock?

There is a dashboard for the MotoServer (http://localhost:5000/moto-api/) that shows the current data/models that are stored, and serves as rudimentary debugging tool.
The scope of Moto (mocking every boto3-service) is already quite large as it is, so I'm hesitant to expand that scope even more by introducing dedicated spy endpoints or hosted UI's. It's definitely useful, just too much for us to maintain.
If you are already using ServerMode, it may be worth checking out LocalStack. They add a lot of features on top of Moto, and I wouldn't be surprised if they have an option to intercept emails for example.


Dates handling

It is necessary to solve date handling - insert new dates and delete old one ?

Or better have active dates and select them  with an easy query?

Or better have active dates and select them  with an easy query?

Fetch only > now ( added by @jan-stanek )
Maybe it will be not necessary to delete, maybe just to add a lot of dates and filter for next 30 days :)

Fetch only > now ( added by @jan-stanek )
Maybe it will be not necessary to delete, maybe just to add a lot of dates and filter for next 30 days :)

[x] Fetch only > now
[ ] add a lot of dates and filter for next 30 days

[x] Fetch only > now
[ ] add a lot of dates and filter for next 30 days


About current lyrics

Add a context menu "About current lyrics" showing the source (or maybe even automatically show it somewhere?).
From #51

As requested in #189, we could also show when the lyrics were retrieved (or at least last modified)

Edit the Lyric Info Panel -
Suggestion -
Type			Un/Synced
Source			Retrieved from Metadata tags/URL		<--  Remove `@ SYNCEDLYRICS`
Downloaded		YYYY-MM-DD HH:MM:SS				<--  Remove `@ SYNCEDLYRICS`
Edited			Never/YYYY-MM-DD_HH:MM:SS

Current -
Synced lyrics
Retrieved from Metadata tags @ SYNCEDLYRICS
First retrieved from Metadata tags at YYYY-MM-DD HH:MM:SS @ SYNCEDLYRICS
Never edited

Retrieved from Metadata tags @ SYNCEDLYRICS

@jacquesh [Bug] Lyric Info Panel counts opening manual search as edit

Open an issue.


fix fix arm p0 and p0 memlimit error

Proposed changes

fix arm p0
fix date type error

p0 memlimit error
(1) limit cache mem usage
(2) add mem_limit to 43%

Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

p0 machine environment has not been modified, mem limit error failed, it should be a commit that caused the query memory usage to increase.
We should locate this commit and confirm whether it is reasonable.

Of course, currently modifying be conf mem limit can avoid block p0

p0 machine environment has not been modified, mem limit error failed, it should be a commit that caused the query memory usage to increase.
We should locate this commit and confirm whether it is reasonable.

I had test history commit submit by reset --hard, It also had the memlimit error.  So i think it probability  p0 machine environment problem.

One machine in our workflow may run three tests at the same time, so 43% may have problems

Is the teamcity test script change or can we reduce the test parallel？ I test history commit 2 weeks  ago but also has memlimit error.


[Question] In page templates

Hey guys,
I was wondering you could give me some tips on implementing "in-page" templates.
Let me explain what i'm talking about using a simple example. Let's say a sever renders a page with a list of products for a category. Once a page is loaded i'd like to reuse the markup representing a single product and render a list of products for another category using Aurelia's repeater. I'm looking for a way to enhance a page behaviour without duplicating a markup on client side.
I have few ideas how to implement it i.e. extracting the markup from loaded page and passing it to custom-element implementing InlineViewStrategy.
I'm just curious if Aurelia has some functionality that could make the process easier / smarter? What would be your approach to solve problem like that?
Any help highly appreciated!

Please ask questions at gitter.im/aurelia/discuss

Sorry for posting it here, but I find it difficult to get any answers on a non-standard questions on Gitter channel.

@tszarzynski then SO should be a better option. Issues are for bug, featureds, etc. There is an aurelia tag on SO, use it and then post the link on gitter.


Added post request service call, changing type logo, refactoring [dynamicTypeLogo]

What was the feature/problem?
{Please write here}
How does this PR address the above feature/problem?
{Please write here}
Check lists (check x in [ ] of list items)

[ ] Test passed
[ ] Coding style (indentation, etc)

Additional Comments (if any)
{Please write here}

Codecov Report

Merging #12 into master will increase coverage by 0.43%.
The diff coverage is 75.94%.

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
+ Coverage   89.86%   90.29%   +0.43%
==========================================
  Files          19       19
  Lines         217      237      +20
  Branches       13       14       +1
==========================================
+ Hits          195      214      +19
- Misses         18       19       +1
  Partials        4        4

Flag
Coverage Δ

#api
95.91% <ø> (ø)
:arrow_up:

#ui
86.33% <75.94%> (+1.45%)
:arrow_up:

Impacted Files
Coverage Δ

ui/src/app/App.js
100% <ø> (ø)
:arrow_up:

ui/src/services/WishDetailsService.js
100% <100%> (ø)
:arrow_up:

ui/src/childinfo/ChildInfo.js
65.38% <65.38%> (ø)
:arrow_up:

ui/src/wishDetails/WishDetails.js
95% <95%> (-5%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9e0db0...9ea8242. Read the comment docs.


Result of video recording is rotated 90 degrees

Hello.
I'm configuring YPImagePicker for my video taking app. The only problem I get is the video is getting rotated to left, even if I didn't intend to do that. Here is my config code
var config = YPImagePickerConfiguration()
config.libraryMediaType = .video
config.onlySquareImagesFromCamera = false
config.showsFilters = true
config.shouldSaveNewPicturesToAlbum = true
config.albumName = "Vibe"
config.screens = [.video, .library]
config.startOnScreen = .library
config.wordings.libraryTitle = "Library"
config.videoCompression = AVAssetExportPresetMediumQuality
config.videoExtension = .mp4
config.videoRecordingTimeLimit = 30 // 30 seconds
config.videoFromLibraryTimeLimit = 30 // 30 seconds

// Build a picker with your configuration
let picker = YPImagePicker(configuration: config)

// Single Photo implementation.
picker.didFinishPicking { [weak self] items, _ in
  if let videoURL = items.singleVideo?.url as NSURL? {
      if let splashImage: UIImage = UIImage.getVideoImage(url: videoURL) {
          self?.composePresenter?.updateComposeVideo(url: videoURL, splashImage: splashImage)
      } else {
          Toast(text: "Can't retrive video, please try again", duration: Delay.short).show()
      }
  }

  picker.dismiss(animated: true, completion: nil)
}

present(picker, animated: true, completion: nil)

I have the same problem with this.

Also looks like this doesn't happen when config.showsFilters = false

Well the culprit seems to be assetByTrimming called in YPVideoFiltersVC, I am experimenting at the moment :)

Well looks like I've found the fix :)
    func assetByTrimming(startTime: CMTime, endTime: CMTime) throws -> AVAsset {
        let timeRange = CMTimeRangeFromTimeToTime(startTime, endTime)
        let composition = AVMutableComposition()
        do {
            for track in tracks {
                let compositionTrack = composition.addMutableTrack(withMediaType: track.mediaType,
                                                                   preferredTrackID: track.trackID)
                try compositionTrack?.insertTimeRange(timeRange, of: track, at: kCMTimeZero)
            }
        } catch let error {
            throw YPTrimError("Error during composition", underlyingError: error)
        }

        // Reaply correct transform to keep original orientation.
        if let videoTrack = self.tracks(withMediaType: .video).last,
            let compositionTrack = composition.tracks(withMediaType: .video).last {
            compositionTrack.preferredTransform = videoTrack.preferredTransform
        }

        return composition
    }

How do I override this function btw? or is it available on newer version?

@lewisloofis I'm going to update the version with the fix, I'll let you know when it's live :)

@lewisloofis @pngo-hypewell  it should be good as of 3.1.1
https://github.com/Yummypets/YPImagePicker/releases/tag/3.1.1
👍

@s4cha The 3.1.1 version works well so far.

🎉


Make ClusterBootstrapTokenCreated known again

In previous changes the cluster bootstrap token has been removed, but due to the nature of event sourcing the events are still in the history. Therefore it is not a viable solution to remove the handling of those events. Readded a dummy handler again.

Coverage decreased (-0.3%) to 56.376% when pulling c9b03c2a295d430f651b032b837cf4285411fe1d on fix/bootstrap-token-event-unknown into f98e55f6cfc2481484522e8cbc64d71c1fd23590 on main.


Choosing the word between the guild rank and the guild

Is your feature request related to a problem? Please describe.
If a guild is named "Champs dorés" and my rank is "marchand" it appears as "marchand de Champs dorés" which makes no sense.
Describe the solution you'd like
Could you add a box like for the name and eyes color, but for the word between the guild rank and the guild name ?
Describe alternatives you've considered
Or a dropdown list of word or group of words we could use like "de, de la, du, des, etc..."

Hey. A few reasons why we're not looking to do this:

We're supporting a few languages and this would require to look up grammar details for all of them.
The selected format would then have to be sent over comms, which while not taking a lot of bandwidth, is still only for a minor aesthetic detail.
This doesn't work across languages.


Patch missing 'limits' in facebook-clang-plugins #1407

Hopefully resolves https://github.com/facebook/infer/issues/1407
Signed-off-by: Andrew V. Jones<EMAIL_ADDRESS>Please see CONTRIBUTING.md for how to set up your development environment and run tests.

Confirmed -- now builds successfully! 🎉

Thanks for the patch!


glTF Serializer: Added procedural texture to prevent premultiplication of alpha when exporting opaque models to glTF

Added procedural texture to prevent premultiplication of alpha when exporting opaque models to glTF
Used the Babylon default material instead of omitting and using the glTF default material
Refactored to use promises in more functions to support the async shader call

Ah makes sense, I’ll make a pass through everything (leaving the airport now)

Made the update to the other functions


No items in Codespaces.

Whenever I open these kinds of activities from Mindtap, it wouldn't open fully the file and it will only show the Companion window
Version: 1.89.1
Commit: dc96b837cf6bb4af9cd736aa3af08cf8279f7685
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36 OPR/<IP_ADDRESS>
Embedder: codespaces

it's unclear what you mean. pls create an issue for codespaces.