Try and fix pyvista figures with GitHub Actions

I have split this issue off from #287. That PR highlighted that pyvista plotting works correctly on circleci, but all sphinx-gallery figures turn out as black squares when using GitHub Actions.  See previous discussion https://github.com/mne-tools/mne-nirs/pull/287#issuecomment-860561772 and https://github.com/mne-tools/mne-nirs/pull/287#issuecomment-860725288
I have confirmed this is not a issue with pyvista running on GitHub Actions. See point 3 below.

In the CircleCI you can see the correct figure is presented at the bottom of this page. https://1282-254026779-gh.circle-artifacts.com/0/dev/pull/297/auto_examples/general/plot_01_data_io.html#custom-data-import
However, in the GitHub Actions build it is just a black square. You can see this by downloading the documentation artefact from the build at https://github.com/mne-tools/mne-nirs/pull/297/checks?check_run_id=2827440875 and going to refs-11/pull/297/merge/auto_examples/general/plot_01_data_io.html
To check that GitHub Actions has pyvista installed correctly I have added a minimal pyvista command to the GitHub action, and it correctly generates a 3d figure. See the screenshot artefacts in the above action. And https://github.com/pyvista/test-pyvista-gh-action/pull/3

@GuillaumeFavelier do you have any suggestions as to what else I can investigate to find the underlying issue here?

Codecov Report

Merging #297 (6d3bd81) into master (d3f0bc6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #297   +/-   ##
=======================================
  Coverage   97.48%   97.48%
=======================================
  Files          47       47
  Lines        1270     1270
  Branches      172      172
=======================================
  Hits         1238     1238
  Misses         13       13
  Partials       19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3f0bc6...6d3bd81. Read the comment docs.

Hm... The plots of the pyvista 3d backend use PyQt5 so I would remove:
      PYVISTA_OFF_SCREEN: True
      PYVISTA_USE_IPYVTK: True

because AFAIK, true off_screen rendering is not supported with PyVistaQt.
Also I see that you test the standard Plotter of PyVista (which is used only by the notebook 3d backend) but testing BackgroundPlotter might be a better test. Something like:
python -c "import pyvistaqt; pyvistaqt.BackgroundPlotter(show=True)"

From mne-python: https://github.com/mne-tools/mne-python/blob/main/.circleci/config.yml#L125
Sorry if my comments are confusing, I can clarify if you have a question

Thanks for taking a look @GuillaumeFavelier. I removed PYVISTA_OFF_SCREEN and PYVISTA_USE_IPYVTK  as you suggested, and added python -c "import pyvistaqt; pyvistaqt.BackgroundPlotter(show=True)" as test. However, the pyvista figures are still rendering as just black. I noticed you had some success over at https://github.com/ja-che/hidimstat/pull/25, do you have any additional suggestions based on that PR as to what I might look further in to?

I noticed you had some success over

I'm sorry @rob-luke, it ended up being a failure. I basically just reproduced the issue of this PR. As of now, I still do not have a clear idea of causes this.
I can only focus on the differences between the Circle env and GitHub Actions/Ubuntu :thinking:

Thanks for letting me know @GuillaumeFavelier, I might put this on hold then and just not demo the 3d functionality.
Thanks for the help! 🙏

I created https://github.com/GuillaumeFavelier/pyvista_github_actions to continue to investigate independently of mne-nirs.

From I can see from the generated artifacts, it works for basic pyvista/pyvistaqt so I can only narrow the research on plot_stc/brain_scraper.

THANK YOU @GuillaumeFavelier!! I will follow you in your new repo


binary stl files starting with "solid" in its header

some binary stl files starts with "solid" in its header that confuses a parser which depends on "solid" to tell if it is ascii or binary

Sure, I'd do the pull. I had completely forgotten about this project and honestly can't remember how far I got. So I can't guarantee that my library does what you need for your STL viewer program, but I'm happy to help where I can.

hi chris,
no worries about my program, i used your code as i find it among the more 'tidy' implementations and in fact it is one of the implementations that works pretty well. while developing my STL viewer (which uses this STL parser) i downloaded various STL files/models from http://www.thingiverse.com/ and tried them out.
initially it leaves me somewhat puzzled that many STL files actually worked well, while some STL files wouldn't load. There and then i debugged the program and noted that some binary STL files starts with "solid" in it, this 'confuses' the parser as normally "solid" is used to identify an ascii STL file. after looking up the web, with some hints i reimplemented the logic to more accurately distinguish if a stl file is ascii or binary, the 'secret' is that for an ascii stl file, the next line needs to start with "facet".
the resulting codes here is some rather tuned codes as i tested against a dozen different files from http://www.thingiverse.com/ and this time round all of them works.
i contributed the code back to your repository as i think this would be generally useful, not just for my little viewer app. you may like to check out my stl viewer app as it is based on this parser. i've added you as a collaborator/developer in my stl viewer app, as well as this fork, you could literally edit the codes if you want to

I see. Thank you very much! I'll check out the viewer when I have the time. Best of luck!


Prepare 1.1.0

Test our release process and containers labeling.

Changes Unknown when pulling 967607084f781fd353cb672f788598a308548d29 on prepare-1.1.0 into ** on master**.

Changes Unknown when pulling 3e1f53a768642a21628fffac74eea25c0b87aadf on prepare-1.1.0 into ** on master**.

Changes Unknown when pulling 177bd5cc08d37c689371ee33a2a1c7723a500aec on prepare-1.1.0 into ** on master**.


x/tools/internal/lsp: add tests for constant completion

There are currently no tests for completion of constants.

Is this still relevant? Where should I look at to pick up on this?

Yes it is! Basically we need tests for completion when the item being completed is a constant. For an example of how the test format looks, you can check out https://github.com/golang/tools/blob/master/internal/lsp/testdata/bar/bar.go.in or any of the files in the testdata directory. Basically, items that should appear in the results get marked as "item" and then to trigger a completion test, we add the "complete" marker. The testing framework is quite complex, so feel free to ask me any questions on here.


Add ExcludeTransitiveDependency recipe

Add a recipe to exclude transitive gradle dependencies.

Cross linking an alternative interpretation in

#3689


error: could not build Objective-C module 'Realm'

Hi,
I was friendly told in https://github.com/realm/realm-cocoa/issues/1280 to open a new issue, since that one was already closed (it doesn't appear to be solved).
Goals
Use realm in a framework target
Expected Results
Compiles
Actual Results
Doesn't compile:
/xxxxxx/Pods/Realm/Realm/module.modulemap:2:21: Umbrella header 'Realm.h' not found
Could not build Objective-C module 'Realm'
Steps to Reproduce
Podfile:
use_frameworks!

#framework
target 'Providers' do
    pod 'QorumLogs'
    pod 'Alamofire', '~> 4.0'
    pod 'Valet'
    pod 'RealmSwift'
    pod 'Reachability', '~> 3.2'
    pod 'Starscream'
end

target 'my_ios_target' do
    platform :ios, '8.0'
    pod 'SwiftValidator', :git => 'https://github.com/i-schuetz/SwiftValidator.git', :branch => 'remove_delegate_callback'
    pod 'SwiftCharts', :git => 'https://github.com/i-schuetz/SwiftCharts.git'
    pod 'Google/SignIn'
    pod 'SwipeView', '~> 1.3.2'
    pod 'CMPopTipView', '~> 2.0'
    pod 'KLCPopup', '~> 1.0'
    pod 'ChameleonFramework/Swift', :git => 'https://github.com/ViccAlexander/Chameleon.git'
    pod 'HockeySDK'
    pod 'QorumLogs'
end

target 'my_osx_target' do
    platform :osx, '10.10'
    pod 'Nimble', '~> 5.0.0'
end

#performance
post_install do |installer|
    puts("Update debug pod settings to speed up build time")
    Dir.glob(File.join("Pods", "**", "Pods*{debug,Private}.xcconfig")).each do |file|
        File.open(file, 'a') { |f| f.puts "\nDEBUG_INFORMATION_FORMAT = dwarf" }
    end
end

Version of Realm and Tooling
ProductName:	Mac OS X
ProductVersion:	10.12.1
BuildVersion:	16B2555
/Applications/Xcode.app/Contents/Developer
Xcode 8.1
Build version 8B62
/Users/xxxxxx/.rbenv/shims/pod
1.2.0.beta.1
Realm (2.1.1)
RealmSwift (2.1.1)
/bin/bash
GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin16)
/usr/local/bin/carthage
0.18.1
(not in use here)
/usr/bin/git
git version 2.9.3 (Apple Git-75)
Additional notes

I'm moving part of my code to a framework (embedded). Before of this everything (same code, dependencies/versions, environment) was working.

None of the solutions from https://github.com/realm/realm-cocoa/issues/1280 helped.

Thanks!

I have this issue as well but with a much simple pod file and Xcode project:
Steps to Reproduce:

Create new Xcode project with macOS/Cocoa Application
Create new pod file with the following contents:
Run Pod update or pod install
Open the workspace
Select the macOS app scheme and build

project 'RealmPodTest.xcodeproj'

target 'RealmPodTest' do
  platform :osx, '10.12'
  use_frameworks!
  pod 'RealmSwift'
end

post_install do |installer|
  installer.pods_project.targets.each do |target|
    target.build_configurations.each do |config|
      config.build_settings['SWIFT_VERSION'] = '3.0.2'
    end
  end
end

Current workaround

Find all Realm header files and select them in the left are of xcode
In the right area of Xcode change their Target Membership permission from Project to Public
Compile again

@jeffreybergier this is with CocoaPods 1.2.0.beta.1, Xcode 8.1 and Realm Swift 2.1.1 as well?

@jpsim
Version 8.2 beta (8C30a)
Cocoapods 1.0.0
Realm, 2.1.1
RealmSwift, 2.1.1

Adding a screenshot of the error if that helps. @i-schuetz if this is a different error than you're getting, let me know and I'll open a new Issue and stop hijacking yours :)

@jeffreybergier yes, same issue!

In my case moving Realm's header files to public didn't help. Also not setting "Always search user paths" to yes. Path in user header search paths seems to be correct ("${PODS_ROOT}/Realm/include"). Also adding this to the header search paths instead didn't help. Just trying out things.

I moved them in the build phases... under "Headers" you can drag & drop all the headers from project to public. Impossible to miss any.

@jeffreybergier Actually, there is a difference between my error and yours (your first screenshot). The framework with the error at the left in my case is the framework I'm trying to build instead of  RealmSwift. The rest is the same.

Hmm. I created a new project, with the same configuration (1 framework that uses Realm and main project uses framework) and podfile contents and it works. Double checked that the Realm version is the same (2.1.1), headers are marked as "project", etc.
How can I debug this, I really don't want to have to move everything to a new project, it's quite a lot...

@i-schuetz I see. Ok. I'm going to open a new issue for the issue I am seeing. Unfortunately I don't know enough about your project to help debug. But best of luck.

@jeffreybergier no worries, thanks! the question was directed to the general/maintainers.
I'm getting the feeling that I'll have to re-create the project.
For now I reverted to my monolithic project, still works :)

Could reproduce exactly the same issue with the same project, on a brand new hard drive with updated macOS version, Xcode...
@jeffreybergier's workaround also didn't work here.
My new specs:
ProductName:	Mac OS X
ProductVersion:	10.12.2
BuildVersion:	16C67
/Applications/Xcode.app/Contents/Developer
Xcode 8.2
Build version 8C38
/usr/local/bin/pod
1.1.1
Realm (2.1.1)
RealmSwift (2.1.1)
/bin/bash
GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin16)
(not in use here)
/usr/bin/git
git version 2.10.1 (Apple Git-78)

Final update: I got it working by using a separate project instead of only separate target.
For completeness, I didn't need any workarounds to get it working with this new configuration.

@jeffreybergier It doesn't reproduce in my env, CocoaPods 1.1.1, Xcode 8.2, Realm 2.1.1. Could you make sure again the issue reproduces?

@kishikawakatsumi I just tried it with cocoapods 1.1.1 and it worked fine. It must be an issue with 1.0.0. I suppose we can close the issue. Thanks for looking into it!

I'm getting the same error as @jeffreybergier, running Cocoapods 1.1.1. My headers are set to Public, but that didn't change anything. I'm getting this error only after including RLMSupport.swift.


Main view height is not updated when device-orientation changes

In landscape mode, the children view (main view) seems to have longer height than it should be. The problem is that the height of the main view is defined in a stylesheet, and it's not updated when orientation changes (line 427-431):
    styles.main = Object.assign({
      position: 'absolute',
      top: 0,
      height: this.state.viewport.height, // this is not updated when orientation changes
    }, {borderWidth:0}, this.props.styles.main)

To solve this problem, the style of the main view (line 371) need to be style={[this.stylesheet.main, {height: this.state.viewport.height, width: this.getMainWidth()}]} instead of style={[this.stylesheet.main, {width: this.getMainWidth()}]}. Would you please test it out and verify it? Thanks.

The situation is reversed when starting the application in landscape mode. After switching to portrait, main view covers only a part of the screen. The solution proposed by @realjamie works in both cases.

Thanks @mboguc . I just made a pull request  https://github.com/root-two/react-native-drawer/pull/92


Improve compatibility checks and experience for unsupported versions of PHP

Feature Description
We have become aware that the plugin currently doesn't support each possible combination of PHP & WordPress. We don't currently support below 5.6, however the experience for those in that group is quite poor (as detailed below) and should be improved
It is worth noting that PHP usage below 5.6 is quite low:
5.4 -> 2.7%
@swissspidy to rewrite this exactly how he likes..
PHP 5.2

PHP 5.3

PHP 5.4

Alternatives Considered

Additional Context

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

Created a POC #5071 .

Having sometime to think over our current solution, I have rethought it.

The Compatibility class should be removed from the web stories namespace, converted to use PHP 5.2 standard and should be manually included and instantiated in the web-stories.php.
web-stories.php work in PHP 5.2.
The admin notice and CLI notice  should be moved to web-stories.php. Admin notices and cli notices, should also include WP and PHP checks.
If checks do not pass, the namespace and autoload files should not be bootstrapped.
All checks from activation and deactivation hooks should be removed. ( These will not be required, as we are doing these checks earlier ).
The plugin should always activate, no matter what version of PHP or WP you are using. But if it current setup is not compatible, all the plugin will do is show the admin notice. The user will not see the stories menu item or any other UI from stories.

SGTM! 💯


Add open_file() RPC method

Reassigning to grin so that he can give feedback on how this fits into the renaming.

I agree - abstract the OS differences as much as possible. Also happy to combine this with reveal. Maybe it should be called file_open and it could take an open_in_folder option.
I'm also concerned about security here. Do we really want the daemon opening whatever it's told to open? Shouldn't it check that this is a file it knows about, that its in the downloads folder, etc.

Re: Job's idea, both of us and Jeremy have kicked it around and we decided to split the difference--create a new module called something like file_utils with functions revea()l and open() that have separate switch statements.

Re: Grin's security concerns, the best way to handle this would be to pass in a (file name || sd_hash) instead of a path.* This is a more intuitive API anyway.
* Although Jack pointed out today that SD hash doesn't quite work as a unique ID for entries in the file manager; you could have 2 files with the same SD hash. Same with claim ID. We're now planning to create a new unique ID field that will replace SD hash in most API calls. Not sure if that will end up getting merged before this PR or not.

Closing this, work continues in #410


minor typo fixes

Did you fix the documentation for the new spelling?

there wasn't any documentation to fix, it's just some minor typo fixes.

Looks Good to me.


Using SubComponent with react-redux useDispatch hook

Using v7?
Describe the bug
I using<EMAIL_ADDRESS>with react-redux. When I using Sub Component with useDispatch from react-redux - my expandable component is closing
To Reproduce
Code:
const renderRowSubComponent = React.useCallback(({ row }) => {
    dispatch({ type: "test " });
    return (
      <pre
        style={{
          fontSize: "10px"
        }}
      >
        <code>{JSON.stringify({ values: row.values }, null, 2)}</code>
      </pre>
    );
  }, []);

Codesandbox!
codesandbox

It's hard to debug or help when we can't really see what's happening in your code, could you give a more detailed code example, showing how you're using react-table and the subComponent?
The CodeSandbox isn't working, you'll have to initialize the store and wrap the app in react-redux's <Provider>.

Yeah, please open a new issue with more information, or you could also ask this question on https://spectrum.chat/react-table.  Thanks!


Content issue

[Enter feedback here]
Hi,
When the documentation details the features of the service why do not you use the same terminology as it is in the table.
The table show the feature availability by plan and the "Features" section would provide a 2-3 sentences description for each of them using the same name as in the table. Now the feature names and descriptions are two different things.
BR,
Ferenc

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 51177002-b38a-3a94-2696-7bfdb89d2c94
Version Independent ID: 90751729-6d69-314c-4c76-e720f916043e
Content: Azure DDoS Protection Standard Overview
Content Source: articles/ddos-protection/ddos-protection-overview.md
Service: virtual-network
GitHub Login: @aletheatoh
Microsoft Alias: yitoh

Thanks for the feedback! I have assigned the issue to the content author to investigate this and update the document as appropriate.

@SaiKishor-MSFT Please can you remove the virtual-network/svc label and assign the ddos-protection/svc label to this issue. Thanks!
@aletheatoh Please can you review this PR and update content as appropriate. Thanks!

#assign @AbdullahBell


nanorepeat "freezing"

Hi there,
I am running nanorepeat on some ONT bam files with the following command:
nanoRepeat.py -i $bam -t bam -d ont_sup -r $genome -b $bed -c 20 -o $output
where $bed contains 6,841 entries and $bam is a ~100G file.
The issue I am experiencing is that after some hours of running, nanorepeat seems to freeze. While at the beginning of the run I could see in the output folder tmp subfolders like ${sample}.NanoRepeat_temp.chr8-20707547-20707710-AAGA, now in the output folder there is only a subfolder named ${sample}.details. However, the program is still running, the last operation appears to have been done more than 6 hours ago and no *tsv file has been generated.
I have tried to repeat the analysis on a SR bed file containing 10 entries and everything run smoothly. Might this perhaps be linked to the big size of BAM (~100G) and BED (7k entries) files?
I have increased the memory up to 500gb, but nothing changed.
Do you have any idea on what is going on?
Thanks in advance,
Federico

Hi Federico,
Thanks for your feedback. NanoRepeat might be stuck in a specific repeat region. Can you locate this region? You can find it in the stderr output.
like this:

By the way, please try to use -c 8 instead of -c 20. When using more than 8 threads, the speed improvement is minimal, but the I/O load is very high.

Hi,
thanks a lot for the feedback and suggestion, I am now running with -c 8. It indeed seems that nanorepeat gets stuck at a specific repeat. It has been stuck at the repeat chr5-15642016-15642309-ACATACAC for 16h. I could certainly try to remove this repeat from my input file and re-run it. I have no problem in doing that, but I was wondering whether you have a guess on why this happens. Is this random or you think this particular repeat might be problematic?
Thanks a lot,
Federico

I'm not sure because I haven't seen the reads in this repeat. It might be due to an high sequencing depth, or these reads might contain very long repeats. Is it convenient for you to check the region in IGV? (you can use samtools view to extract the reads of a specific region so that you dont' need to download the whole bam file from the server)
By the way, it looks like chrY-87448334-87448375-A is finished. It might be another one. It is a little bit difficult to locate the problematic repeat because there are 20 parallel processes and the output of these parallel processes are mixed. But you can separate them using the process id (e.g.  [Process 04] )
Thanks,
Li

Hi Li,
thanks a lot for the support. I have finally identified the issue: I had some duplicated simple repeats in my input file (the first 4 columns were the same, the fifth was different) and this, somehow, made the program stuck. Removing these duplicates, everything run smoothly.
Thanks,
Federico


full support kde explorer - dolphin

Type: Feature Request
vs code does not open my dolphin explorer(which contains my prefered entry points) for select file or folder
VS Code version: Code 1.89.0 (b58957e67ee1e712cebf466b995adf4c5307b2bd, 2024-05-01T02:08:25.066Z)
OS version: Linux x64 6.5.0-28-generic Kubuntu 22.04
Modes:

expected file selector like in telegram desktop

/duplicate https://github.com/microsoft/vscode/issues/231173


Replace gbif-metadata-profile dependency with registry

What version of the provider software are you using?
2.1.1

Please provide any additional information below.

The gbif-metadata-profile project has effectively been merged into the Registry project.

gbif-metadata-profile is hosted in SVN at https://code.google.com/p/gbif-common-resources/source/browse/gbif-metadata-profile/
whereas the Registry project is hosted in GitHub: https://github.com/gbif/registry

Once the IPT uses the Registry instead of the gbif-metadata-profile project, in SVN
we need to:

-Tag the trunk
-Delete trunk so that only tags directory remains
-Delete all branches

Original issue reported on code.google.com by kyle.braak on 2014-07-08 11:43:31

It would be a very invasive change to replace this dependency. Not anticipating more changes to the metadata profile in the near future, it is preferred just to maintain gbif-metadata-profile. Closing as won't fix.


update README.md

[Current coverage][cc-pull] is 100%

Merging [#553][cc-pull] into [master][cc-base-branch] will not change coverage

@@           master   #553   diff @@
====================================
  Files          28     28
  Lines         439    439
  Methods       111    111
  Messages        0      0
  Branches        0      0
====================================
  Hits          439    439
  Misses          0      0
  Partials        0      0

Powered by Codecov. Last updated by [4371b1a...e8e1eb0][cc-compare]
[cc-base-branch]: https://codecov.io/gh/eugene-matvejev/battleship-game-api/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/eugene-matvejev/battleship-game-api/compare/4371b1a7bb84ae31ae5256da2e576efcda205534...e8e1eb06595e71ceabe7d31b94c93568b3e90245?src=pr
[cc-pull]: https://codecov.io/gh/eugene-matvejev/battleship-game-api/pull/553?src=pr


simplify some ternaries

Apology, wrong tagging of the issues. This should be the fixes for issue #782 instead.


Star Rating

Adding feature #61 to Boosted v5.
Preview: https://deploy-preview-887--boosted.netlify.app/docs/5.1/forms/checks-radios/#star-rating
Didn't know where to put disabled state of this component.
Dark version of this component may be removed with the resolution of #917
DoD
Development

[x] Should match specs (eg. either the Web UI Kit or any pattern from the WAI — or both…)
[x] Docs added:

including the "Sass" part using scss-docs shortcode
in /about/overview/#custom-components if it is a new Orange custom component
in /gettings-started/introduction/#components if it is a new Orange custom component that requires JavaScript (and Popper)
in /customize/overview#csps-and-embedded-svgs if it is a new Orange custom component that includes embedded SVGs in our CSS
in /forms/validation/?#supported-elements if it is a new Orange custom component that is a form control
in /forms/overview/ if it is a new Orange custom component that is a form control

[x] Check (and fix) RTL version
[x] Run linters
[x] Run compilers
Tests added for JS-side
Run tests
[ ] Cross-browser test:

Firefox ESR
Latest Edge, Chrome, Firefox, Safari
iOS Safari
Chrome & Firefox on Android

[ ] Clean up the branch using rebase -i
[ ] Commited with feat(…): … message
Mention it in Migration Guide (if back-from-v4): renamed variables, changes in markup requirement,  etc.

Reviews

[x] Code review
[x] A11y review
[ ] Design review

In order to import everything but star rating system, please comment the last line.
@import "../../Orange-Boosted-Bootstrap/scss/functions";

@import "../../Orange-Boosted-Bootstrap/scss/variables";
@import "../../Orange-Boosted-Bootstrap/scss/maps";
@import "../../Orange-Boosted-Bootstrap/scss/mixins";
@import "../../Orange-Boosted-Bootstrap/scss/root";

@import "../../Orange-Boosted-Bootstrap/scss/helpers/visually-hidden";
@import "../../Orange-Boosted-Bootstrap/scss/forms/form-check";
@import "../../Orange-Boosted-Bootstrap/scss/forms/form-control";
@import "../../Orange-Boosted-Bootstrap/scss/forms/form-range";
@import "../../Orange-Boosted-Bootstrap/scss/forms/form-select";
@import "../../Orange-Boosted-Bootstrap/scss/forms/form-text";
@import "../../Orange-Boosted-Bootstrap/scss/forms/input-group";
@import "../../Orange-Boosted-Bootstrap/scss/forms/labels";
@import "../../Orange-Boosted-Bootstrap/scss/forms/validation";
@import "../../Orange-Boosted-Bootstrap/scss/forms/star-rating";

Hi, Here are my design comments.

For the large version, reduce the spacing between the stars by 2px.
For the small version, reduce the spacing between the stars by 1px.

Regarding the behaviour, now I've seen it working with the state changes, I think it would be better if the pressed state changes to orange. I appreciate this is different to what is specified in the Sketch artboards. Thanks

Hi, I modified some things to fit your comment @Franco-Riccitelli.
However, the orange star on focus will be hard to implement with the actual version. I think that it'll be easier for each project to implement it if they want so.


CAMEL-12666: Create push tag operation

Operation "createTag" must be able to work with mandatory parameters tagName and remoteName. Example section documentation was updated.

Feel free to open it.

This is a common way to write producer in camel components.

Merged on master. We'll work on refactoring later. Thanks.


ravedude: nano: Support nano boards flashed with optiboot and 115200 baudrate

Adds support for Arduino nano boards which are flashed with optiboot and have a default upload speed of 115200. Ref: https://github.com/arduino/ArduinoCore-avr/commit/1b14cc07331268e95eddcce2cc67e29ed667e62f

it works on my Arduino Nano, if this PR will be merged, it would be a good addition!

it works on my Arduino Nano,

That might be the signal this merge request was waiting for ...


[BUG] - Remove blog from jumbotron when not in use

Describe the bug
We aren't going to use the blog feature, but there's no way in the config to not have "Blog" show up in the jumbotron div.
To Reproduce
Steps to reproduce the behavior:

Working on upgrading Page it to the Limit site to 1.14.1
Added no additional settings to config.toml for the blog feature
Blog shows up in jumbotron and results in a 404

Expected behavior
If the blog section isn't initialized in config.toml, there should be no mention of a blog on the site.
Screenshots

Desktop (please complete the following information):

OS: OS X
Browser: chrome and firefox
Hugo version v0.74.3

Additional context
I copied some code out of head_includes.html to suppress the blog button, and that seems to work. I don't know if that is the best way to do it though.
I added
{{ if eq .Section "blog" }}
at line 75 and an end at line 81

oh snap. This should be fixed soon. Sorry!

I am pushing up a PR now to fix this; had to do something a little different but I think it works!

There'll be a fix released in the next 10 min or so!


Mapping AWS regions and S3 bucket region

Part of:

https://github.com/kubernetes/k8s.io/issues/3411

From https://github.com/kubernetes-sigs/oci-proxy/issues/39, we identified which region the traffic come the most but we need to ensure redirection for traffic coming from regions not listed.
We could also assume the rest of regions are served from only 1 bucket but they is a risk of high latency during image pulling.
Draft:

regions
bucket name
bucket location

us-east-1

us-east-1

ca-central-1, us-east-2

us-east-2

us-west-1

us-west-1

us-west-2

us-west-2

ap-south-1, me-south-1

ap-south-1

ap-northeast-1, ap-northeast-2

ap-northeast-1

ap-east-1, ap-southeast-1

ap-southeast-1

eu-central-1, eu-south-1

eu-central-1

eu-west-1, af-south-1

eu-west-1

eu-north-1, eu-west-2, eu-west-3

eu-west-2

Not listed:
ap-southeast-3
ap-northeast-3
ap-southeast-2
sa-east-1
I'll update the table as soon I have more data
/sig k8s-infra
/area artifacts
/priority important-soon
/milestone v1.25
/assign @BenTheElder

cc @jaypipes

Not listed:
ap-southeast-3
ap-northeast-3
ap-southeast-2
sa-east-1

I would guess:

ap-southeast-3 => ap-southeast-1
ap-northeast-3 => ap-northeast-1
ap-southeast-2 => ap-southeast-1
sa-east-1 => us-east-1

cc @jaypipes

Not listed:
ap-southeast-3
ap-northeast-3
ap-southeast-2
sa-east-1

I would guess:
* ap-southeast-3 => ap-southeast-1

* ap-northeast-3 => ap-northeast-1

* ap-southeast-2 => ap-southeast-1

* sa-east-1 => us-east-1

@BenTheElder yep, that works. +1
Keep in mind the amount of traffic coming from these regions is very low.

Looking at the Data Studio report all four regions <2% total

So the remaining bit then is just mapping the regions to their bucket names, then we can update https://github.com/kubernetes-sigs/oci-proxy/blob/main/cmd/archeio/app/buckets.go

[this issue is blocked on the buckets being up and ready, so don't jump into working on this one just yet]

xref #76 the staging deployment should run in the same regions so we can get realistic latency results vs production and these buckets

this was done in https://github.com/kubernetes-sigs/oci-proxy/pull/82


Redesign Team section on mobile view

The carousel view for our team section is outdated and difficult to maintain.
AC:

Redesign team section for mobile view (screen width < 600px)
Implement design in code


chore: update sepolia.ts to include Lodestar bootnode

Motivation
To contribute to bootnode diversity. Sepolia bootnode is ready for connections.
Description
This PR adds a new bootnode ENR:
enr:-KG4QJejf8KVtMeAPWFhN_P0c4efuwu1pZHELTveiXUeim6nKYcYcMIQpGxxdgT2Xp9h-M5pr9gn2NbbwEAtxzu50Y8BgmlkgnY0gmlwhEEVkQCDaXA2kCoBBPnAEJg4AAAAAAAAAAGJc2VjcDI1NmsxoQLEh_eVvk07AQABvLkTGBQTrrIOQkzouMgSBtNHIRUxOIN1ZHCCIyiEdWRwNoIjKA

to our list of bootnodes for Sepolia.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

We should add our ENR to the public list too

We should add our ENR to the public list too

opened a PR for that https://github.com/eth-clients/sepolia/pull/83

:tada: This PR is included in v1.20.0 :tada:


Create cs.brazcubas.edu.br

Add sub domain Faculdade Braz Cubas Brazil

@renatolaq lib/domains/br/cs.brazcubas.edu.br: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@renatolaq First stage of verification passed, official domain for Universidade Braz Cubas CST Empreendedorismo is cs.brazcubas.edu.br as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@renatolaq Thank you for your patience while waiting for a review and processing your request. Pull request merged.


feat: Copy resources to build directory

Copies resources to build directory
Fixes #112

Seems to work as expected


Trailing whitespace at the end of generated lines

Have noticed this mainly on result = ... lines that are generated.
For example:
  # TODO: auto-generated
  describe '#invoiced?' do
    it 'invoiced?' do
      spot = described_class.new
      result = spot.invoiced?

      expect(result).not_to be_nil
    end
  end

I believe this whitespace may be coming from here:
https://github.com/tjchambers/rspec-kickstarter/blob/master/lib/rspec_kickstarter/erb_templates.rb#L19
here:
https://github.com/tjchambers/rspec-kickstarter/blob/master/lib/rspec_kickstarter/erb_templates.rb#L72
and here:
https://github.com/tjchambers/rspec-kickstarter/blob/master/lib/rspec_kickstarter/erb_templates.rb#L107

Thanks for your report. This has been fixed in version 1.0.6.


npc icons for bank tags

Can we have the option to use the npc icons that are shown for slayer tasks for bank tag icons?
I'd like to be able to do tags for each slayer assignment.

You can do this but you will have to export a tag, change the first ID which resembles the icon of the tab to one of the task ones (you can grab from here) and then import the tag again.

i'll go ahead and do that thanks, would be nice to be able to do it through the client like regular tags though.

duplicate https://github.com/runelite/runelite/issues/6021


Adverse events file: changes the header field report_count to count or data_pipeline

Adverse events file has the header
chembl_id	critval	event	llr	report_count
the data pipeline raises an exception with report_count. It expected "count".
Change the header file or the data_pipeline.
@mkarmona : what do you prefer?

@cmalangone I guess we should stick to a more uniformly way of naming things when is possible. If we have the option to change so let's try to apply something like this (balanced between meaningful and keeping short)
event
report_count -> count
llr -> logLR
critval -> criticalValue

@cmalangone This has to be changed here
Furthermore, this changes have to be propagated to MrTarget pipeline too

Please, keep in mind you will be affecting the 2 FE versions if endpoints change their name. Just a reminder to follow up on them if changes are implemented.

@d0choa I will only break the former one as for the new FE the api is already encapsualted. I am just talking about data output. See here and the GraphQL object will remain the same as it is, see here.

I've changed it so that report_count is now count and works with the existing data pipeline.
Let me know if we want to make more significant renaming changes.

Thanks to @JarrodBaker to fixing the bug.
I keep this issue open and next release @JarrodBaker and I can try to follow @mkarmona indication.

Sounds like a plan!

@cmalangone careful with changes here that have to be in sync with the new API beta . Just to keep an eye on it

@mkarmona, @cmalangone   The commit above has not yet been merged into master as it implements Miguel's suggestion:
event -> name
report_count -> count
llr -> logLR
critval -> criticalValue
I don't know if any of the renaming is going to break anything down-stream.

It is ok. Go for it @JarrodBaker

Ticket closed as work merged into master of etl-openfda-faers repo
See https://github.com/opentargets/platform-etl-openfda-faers/pull/15 for more details


refactor: automatically reorder imports using prettier-plugin-organize-imports

Motivation
Fixes #313
Change Summary

Adds the prettier-plugin-organize-imports dependency
Reorders the existing imports in the src directory

Merge Checklist
Choose all relevant options below by adding an x now or at any time before submitting for review

[x] The title of this PR adheres to the conventional commits standard
[ ] The PR has been tagged with the appropriate change type label(s) (i.e. documentation, feature, bugfix, or chore)
[ ] Changes to the protocol specification have been merged

@grayliquid thanks! you'll need to sign your commits before merging

merged, thank you!


static.md uses an effect as a guard

In static.md:
  case request @ GET -> Root / path if List(".js", ".css", ".map", ".html", ".webm").exists(path.endsWith) =>
    static(path, request)

We shouldn't be performing effects in a guard during routing.  It's fine for this to be HttpRoutes, but HttpRoutes.of, which lifts a partial function, is not the way to do it.
Fixing this is a good way to start thinking about types.  Volunteers?

I'm trying to remember why I had a problem with this.  The guard is pure.  I think it was already fine?


[BUG]When view commit detail it returns 500

Gitea version (or commit ref):1.13.0+dev-183-gbc4f7ba69
Git version:
Operating system:
Database (use [x]):

[ ] PostgreSQL
[ ] MySQL
[ ] MSSQL
[ ] SQLite
[X] Not relevant

Can you reproduce the bug at https://try.gitea.io:

[X] Yes (provide example URL) https://try.gitea.io/sakalabid77/CaraMerawatAlatLab/commit/0c57fe15ce3a806afb1730fb9ed551cb0866bf4f,
https://try.gitea.io/matze1128/Virus_Programm_Matthias/commit/ad2488328cbc7bae3cc1ab184fa422f77bdef205
...
[ ] No
[ ] Not relevant

Log gist:

Description
After my test. I suspect this issue may be caused by this pr (#11847).
This issue is same to  #11868
Please have a review.
Screenshots

This is
2020/06/12 12:27:54 ...uters/repo/commit.go:317:Diff() [E] commit.GetTagName: exit status 128 - fatal: No names found, cannot describe anything.
From  #11846


Problem updating shelly plugin - file cannot be renamed

I have installed a fresh docker copy of matterbridge and installed/configured the shelly plugin. I see there is an upgrade available, see screenshot below. But when I apply this I get an error when a file is renamed, also see below.

As a test, I tried to rename the file manually and I get the following:
docker exec matterbridge mv '/usr/local/lib/node_modules/matterbridge-shelly/CHANGELOG.md' '/usr/local/lib/node_modules/.matterbridge-shelly-qZ4KFENC/CHANGELOG.md'
mv: cannot move '/usr/local/lib/node_modules/matterbridge-shelly/CHANGELOG.md' to a subdirectory of itself, '/usr/local/lib/node_modules/.matterbridge-shelly-qZ4KFENC/CHANGELOG.md'

Thats an npm bug somehow ... I've seen that before. delete this directory /usr/local/lib/node_modules/.matterbridge-shelly-qZ4KFENC/ manually and try again

Many thanks for the speedy suggestion.  No joy though I'm afraid.  I tried the same for the zigbee plugin.  I did with and without restarting matterbridge with the same result.

Hi,
I'm currently on holiday so no access to my network.
But I would try also this:
docker exec -it matterbridge /bin/bash

inside the shell
npm -g install matterbridge-shelly matterbridge-zigbee2mqtt

Perfect - works very well.  Many thanks

Hi,
thanks for the feedback.
Lately this npm or docker issue has been reported more than once.
I don't understand why...
@Apollon77 do you know something more? The fronted just spawn the same command... nothing changed there since months.

We also have that a lot. Seems to happen in some cases where npm just leaves some temporary dirs existing after an action and then has issues when it sees them again. We added a cleanup command which deletes all this.


TOC for cited_report template

A table of contents may be nice at some point:
((* block predoc *))
    ((( super() )))
    ((* block tableofcontents *))\tableofcontents((* endblock tableofcontents *))
((* endblock predoc *))

Refcerences:

https://tex.stackexchange.com/questions/5019/table-of-contents-using-article-and-report-classes
https://tex.stackexchange.com/questions/403217/make-toc-title-look-like-report-class-in-an-article

Set feature where TOC can be toggled on and off by adding an entry into the notebook metadata.


[Add] Aggiunto il flowchart

Description
Problem Solved
Please include the name of the problem solved
NOTE: only one pull request per problem is accepted.
Also, if a pull request solves multiple problems, only one of the solved problems will be add to the user points (and therefore the leaderboard)
Dependencies and Reason
List any dependencies that are required for this solution and the reason why you used these dependencies
List of Developers
This solution has been implemented by the following Developers:

@GithubProfileTag

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] My changes generate no new warnings
[ ] I have checked my code and corrected any misspellings

NOTE: the PR have to be labelled in-progress until the work is complete, the PR will be checked, reviewed and merged only after being labelled as complete

Il file contiene un HTML che rende impossibile la visualizzazione del FlowChart tramite software come Flowgorithm.
Per visualizzare il FlowChart ho bisogno di un XML


drop Go 1.7 support

https://github.com/shogo82148/go-sql-proxy/issues/23

Coverage increased (+0.4%) to 62.171% when pulling eb13d3be21faa5f509a95069861c8c0365f9d619 on drop-go17-support into 8daca4f94f6aa188f48d0536ef26ef75b1cc86b7 on master.

Coverage increased (+0.4%) to 62.171% when pulling eb13d3be21faa5f509a95069861c8c0365f9d619 on drop-go17-support into 8daca4f94f6aa188f48d0536ef26ef75b1cc86b7 on master.

Good Bye Go 1.7...


add button to share on twitter

#270

Hey @origranot ,
I made the changes with your recommendations, let me know if there is anything left to improve

@dav-q
Can you please fix the conflicts?

@dav-q
Can you please run the formatter?

@dav-q Can you please run the formatter?

in my local files?


[cinder-csi-plugin] Bump driver version

This PR bumps driver version ahead of 1.21 release.

What this PR does / why we need it:
Which issue this PR fixes(if applicable):
fixes #
Special notes for reviewers:

Release note:

NONE

/test cloud-provider-openstack-unittest

/lgtm

/approve
/lgtm


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-k8s-27-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 2958

Questions ?
Please refer to the Backport tool documentation


[BUG] Failed to parse yaml when tag exist

Describe the bug
Failed to parse yaml when !!python/tuple tag exist
To Reproduce
Steps to reproduce the behavior:

Prepare pipeline.yaml including !!python/tuple
Run Runner.from_yaml()

Expected behavior
Make runner instance successfully
Full Error log
If applicable, add full error log to help explain your problem.
ConstructorError: could not determine a constructor for the tag 'tag:yaml.org,2002:python/tuple'

Code that bug is happened
If applicable, add the code that bug is happened.
node_lines:
- node_line_name: retrieve_node_line
  nodes:
  - modules:
    - module_type: hybrid_cc
      normalize_method: mm
      target_module_params: !!python/tuple
      - embedding_batch: 256
        embedding_model: openai
        top_k: 3
      - bm25_tokenizer: porter_stemmer
        top_k: 3
      target_modules: !!python/tuple
      - vectordb
      - bm25
      top_k: 3
      weight: 0.47000000000000003
      ...

runner = Runner.from_yaml("./1/pipeline.yaml")

Desktop (please complete the following information):

OS: Linux (Ubuntu 20.04)
Python version: 3.11

According to this link, we need to change yaml.safe_load to yaml.full_load. It works on my local.

@rjwharry
I have one question.
Why do you need use !!python/tuple at target_module_params??

It was automatically generated, so I thought that AutoRAG was adding it when extract pipeline.yaml

I check that pyyaml add tag automatically.
import yaml

test = {
    "test": (1, 2)
}
print(yaml.dump(test))

# Result
test: !!python/tuple
- 1
- 2

My pyyaml version is 6.0.1

How about using yaml.safe_dump() instead of yaml.dump()?
import yaml

test = {
    "test": (1, 2)
}
print(yaml.safe_dump(test))

# Result
test:
- 1
- 2


"Collapse unchanged regions" looks disabled

Testing #186213

Should use a toggle state instead, or a new icon. You can see it looks the same as the other disabled action

I agree, but then this also applies to the "toggle whitespace" button.

I'd prefer to have an icon per state. That's how we have done it in other toolbars (like output scroll lock).

Mockup with a toggled state.
Having an icon per state makes sense for the lock icon, because the reverse icon metaphors make intuitive sense. This is not the case for the whitespace and fold icon here though.
cc @daviddossett

We do use toggle elsewhere. One easy example:

I'm still in favor of a toggle border, but @jrieken has to agree.
Alternatively, we can explore other icons.
Or we leave it as is.

No, I don't need to agree (but also not to like it). If you wanna explore https://github.com/microsoft/vscode/issues/186403#issuecomment-1621283112 or something similar go ahead but we should be aware that this is also open to extensions, so we need to deal with every (contributed) button looking like this in the future

Mockup with a toggled state.
Having an icon per state makes sense for the lock icon, because the reverse icon metaphors make intuitive sense. This is not the case for the whitespace and fold icon here though.
cc @daviddossett

I think this approach looks good to me
It is more aligned with the vs code current design and should be replaced the current find widget toggle ui

Verification steps:

Notice that in the diff editor buttons have a background now to indicate their toggled state:


Called on_block_announce with a bad PeerId

I'm trying to debug this error log being printed at the moment.
For example, here is a selection of logs concerning a faulty peer:

2020-04-09 05:28:04.113 main-tokio- DEBUG sub-libp2p  Libp2p => Connection (ConnectionId(TaskId(48824)),Listener { local_addr: "/ip4/<IP_ADDRESS>/tcp/30333", send_back_addr: "/ip4/<IP_ADDRESS>/tcp/46740" }) to Qmar25qYxcoLzPuzHDZ9nM7o38mNPqnKrZaksf3aY8rdM8 closed.
2020-04-09 05:28:04.113 main-tokio- DEBUG sub-libp2p  Libp2p => Disconnected(Qmar25qYxcoLzPuzHDZ9nM7o38mNPqnKrZaksf3aY8rdM8): Was disabled.
2020-04-09 05:29:16.519 main-tokio- DEBUG sub-libp2p  Libp2p => Connection (ConnectionId(TaskId(48992)),Listener { local_addr: "/ip4/<IP_ADDRESS>/tcp/30333", send_back_addr: "/ip4/<IP_ADDRESS>/tcp/47480" }) to Qmar25qYxcoLzPuzHDZ9nM7o38mNPqnKrZaksf3aY8rdM8 established.
2020-04-09 05:29:16.520 main-tokio- DEBUG sub-libp2p  Libp2p => Connected(Qmar25qYxcoLzPuzHDZ9nM7o38mNPqnKrZaksf3aY8rdM8, Listener { local_addr: "/ip4/<IP_ADDRESS>/tcp/30333", send_back_addr: "/ip4/<IP_ADDRESS>/tcp/47480" }): Incoming connection
2020-04-09 05:29:16.520 main-tokio- DEBUG sub-libp2p  PSM <= Incoming(Qmar25qYxcoLzPuzHDZ9nM7o38mNPqnKrZaksf3aY8rdM8, IncomingIndex(24268)).
2020-04-09 05:29:16.520 main-tokio- DEBUG sub-libp2p  PSM => Accept(IncomingIndex(24268), PeerId("Qmar25qYxcoLzPuzHDZ9nM7o38mNPqnKrZaksf3aY8rdM8")): Enabling connections.
2020-04-09 05:29:16.520 main-tokio- DEBUG sub-libp2p  Handler(PeerId("Qmar25qYxcoLzPuzHDZ9nM7o38mNPqnKrZaksf3aY8rdM8")) <= Enable
2020-04-09 05:29:17.146 main-tokio- DEBUG sub-libp2p  Handler(PeerId("Qmar25qYxcoLzPuzHDZ9nM7o38mNPqnKrZaksf3aY8rdM8")) => Endpoint Listener { local_addr: "/ip4/<IP_ADDRESS>/tcp/30333", send_back_addr: "/ip4/<IP_ADDRESS>/tcp/47480" } open for custom protocols.
2020-04-09 05:29:17.146 main-tokio- DEBUG sub-libp2p  External API <= Open(PeerId("Qmar25qYxcoLzPuzHDZ9nM7o38mNPqnKrZaksf3aY8rdM8"))
2020-04-09 05:29:17.146 main-tokio- TRACE sync  Connecting Qmar25qYxcoLzPuzHDZ9nM7o38mNPqnKrZaksf3aY8rdM8
2020-04-09 05:29:17.146 main-tokio- TRACE sync  New peer Qmar25qYxcoLzPuzHDZ9nM7o38mNPqnKrZaksf3aY8rdM8 Status { version: 6, min_supported_version: 3, roles: AUTHORITY, best_number: 1807687, best_hash: 0x0b5673dee66fa81b6c6d81bc9259865deda933b4c11d297e252bb160bf07c1c5, genesis_hash: 0xb0a8d493285c2df73290dfb7e61f870f17b41801197a149ca93654499ea3dafe, chain_status: [] }
2020-04-09 05:29:17.146 main-tokio- DEBUG sync  Connected Qmar25qYxcoLzPuzHDZ9nM7o38mNPqnKrZaksf3aY8rdM8
2020-04-09 06:03:42.423 main-tokio- DEBUG sub-libp2p  Libp2p => Connection (ConnectionId(TaskId(51883)),Listener { local_addr: "/ip4/<IP_ADDRESS>/tcp/30333", send_back_addr: "/ip4/<IP_ADDRESS>/tcp/49894" }) to Qmar25qYxcoLzPuzHDZ9nM7o38mNPqnKrZaksf3aY8rdM8 established.
2020-04-09 06:03:42.423 main-tokio- DEBUG sub-libp2p  Handler(Qmar25qYxcoLzPuzHDZ9nM7o38mNPqnKrZaksf3aY8rdM8,ConnectionId(TaskId(51883))) <= Enable secondary connection
2020-04-09 06:03:42.677 main-tokio- DEBUG sub-libp2p  Libp2p => Connection (ConnectionId(TaskId(51883)),Listener { local_addr: "/ip4/<IP_ADDRESS>/tcp/30333", send_back_addr: "/ip4/<IP_ADDRESS>/tcp/49894" }) to Qmar25qYxcoLzPuzHDZ9nM7o38mNPqnKrZaksf3aY8rdM8 closed.
2020-04-09 06:03:42.678 main-tokio- DEBUG sub-libp2p  External API <= Closed(Qmar25qYxcoLzPuzHDZ9nM7o38mNPqnKrZaksf3aY8rdM8)
2020-04-09 06:03:42.678 main-tokio- TRACE sync  Qmar25qYxcoLzPuzHDZ9nM7o38mNPqnKrZaksf3aY8rdM8 disconnected
2020-04-09 06:03:49.304 main-tokio- DEBUG sync  Received block announcement 0x3e521bdd4f3b6bdb16e3c545b0bd7acb79a4686e8acf0d5305c301f8f7038462 with number 1808030 from Qmar25qYxcoLzPuzHDZ9nM7o38mNPqnKrZaksf3aY8rdM8
2020-04-09 06:03:49.305 main-tokio- ERROR sync  💔 Called on_block_announce with a bad peer ID

(I made the effort to find all the entries that are possibly relevant to this peer, but the logs are huge and it's not impossible that I have missed some)
(also, feel free to copy-paste these logs for better readability)
It seems to me that:

A first connection to Qmar25qYxcoLzPuzHDZ9nM7o38mNPqnKrZaksf3aY8rdM8 is established with task ID 48992.
The PSM approves it.
We report to the external API that the substream has been opened.
A second connection with task ID 51883 gets established to the same peer.
That second connection (task ID 51883) gets closed shortly after (200ms)
We report to the external API that the substream has been closed.

The last step seems wrong to me, as the first connection should still be alive. I didn't find anything in the logs about task ID 48992 other than what is above.
cc @romanb is that related to https://github.com/libp2p/rust-libp2p/pull/1546?

Doesn't seem to happen anymore on my Google Cloud node after #5595 :tada:

This issue is still happening when trying to submit an extrinsic from a light client to a full node.
The logs on the client are:

[2020-04-19T13:30:10Z INFO  substrate_subxt] Creating Extrinsic with genesis hash 0xe42e94e47797345248579ed3a74bedba4edbc129938df79391247e14cc0abd29 and account nonce 8
[2020-04-19T13:30:10Z INFO  substrate_subxt::rpc] Submitting Extrinsic `0xb6c05835dab6fc26bfc7ac535d542b83dedb90a2b4c0b4bc3457f09c48f559c2`
[2020-04-19T13:30:10Z DEBUG substrate_subxt::rpc] Events storage key "26aa394eea5630e07c48ae0c9558cef780d41e5e16056765bc8461851072c9d7"
[2020-04-19T13:30:10Z DEBUG jsonrpc_core::io] Response: {"jsonrpc":"2.0","result":1,"id":4}.
[2020-04-19T13:30:10Z DEBUG yamux::connection] 0b1771be: new outbound (Stream 0b1771be/21) of (Connection 0b1771be Client (streams 6))
[2020-04-19T13:30:10Z DEBUG multistream_select::dialer_select] Dialer: Proposed protocol: /sup/light/2
[2020-04-19T13:30:10Z DEBUG sc_network::protocol::light_client_handler] no peer available to send request to
[2020-04-19T13:30:10Z DEBUG multistream_select::dialer_select] Dialer: Received confirmation for protocol: /sup/light/2
[2020-04-19T13:30:10Z DEBUG libp2p_core::upgrade::apply] Successfully applied negotiated protocol
[2020-04-19T13:30:10Z DEBUG yamux::connection] 0b1771be: new outbound (Stream 0b1771be/23) of (Connection 0b1771be Client (streams 6))
[2020-04-19T13:30:10Z DEBUG multistream_select::dialer_select] Dialer: Proposed protocol: /sup/light/2
[2020-04-19T13:30:10Z DEBUG multistream_select::dialer_select] Dialer: Received confirmation for protocol: /sup/light/2
[2020-04-19T13:30:11Z DEBUG libp2p_core::upgrade::apply] Successfully applied negotiated protocol

and the logs of the full node
2020-04-19 15:30:09.919 main-tokio- DEBUG afg  Round 1978: precommits: 2/2/2 weight, 2/2 actual
2020-04-19 15:30:10.533 main-tokio- DEBUG afg  Finding best chain containing block 0xb7d36c4d7935de15c3a8210ac1b3fc762c9b9502c39ad6de458e41932e9cb841 with number limit None
2020-04-19 15:30:10.533 main-tokio- DEBUG afg  Casting prevote for round 1979
2020-04-19 15:30:10.580 main-tokio- DEBUG afg  Announcing block 0xb7d3…b841 to peers which we voted on in round 1979 in set 0
2020-04-19 15:30:10.581 main-tokio- DEBUG sync  Reannouncing block 0xb7d36c4d7935de15c3a8210ac1b3fc762c9b9502c39ad6de458e41932e9cb841
2020-04-19 15:30:10.622 main-tokio- DEBUG sync  Received block announcement 0x4ad0378dc729c4c152bf14bdc4118c7cfd95f61c03f7f23e61d92db31e1c645a with number 456 from QmPEL7emGs49g6dCVDru7q9AF5h1navMvB8aJZJfcf9LCN
2020-04-19 15:30:10.622 main-tokio- ERROR sync  💔 Called on_block_announce with a bad peer ID
2020-04-19 15:30:10.634 main-tokio- DEBUG multistream_select::listener_select  Listener: confirming protocol: /ipfs/kad/1.0.0
2020-04-19 15:30:10.634 main-tokio- DEBUG multistream_select::listener_select  Listener: sent confirmed protocol: /ipfs/kad/1.0.0
2020-04-19 15:30:10.635 main-tokio- DEBUG libp2p_core::upgrade::apply  Successfully applied negotiated protocol
2020-04-19 15:30:10.652 main-tokio- DEBUG sync  Received block announcement 0xb7d36c4d7935de15c3a8210ac1b3fc762c9b9502c39ad6de458e41932e9cb841 with number 454 from QmV34iyTNb4gAG7bSPUrKXT7KTaWq7QWovMs4DP9cchfaj
2020-04-19 15:30:10.694 main-tokio- DEBUG yamux::connection::stream  cd528beb/17: eof
2020-04-19 15:30:10.734 main-tokio- DEBUG multistream_select::listener_select  Listener: confirming protocol: /sup/light/2
2020-04-19 15:30:10.735 main-tokio- DEBUG multistream_select::listener_select  Listener: sent confirmed protocol: /sup/light/2
2020-04-19 15:30:10.741 main-tokio- DEBUG libp2p_core::upgrade::apply  Successfully applied negotiated protocol
2020-04-19 15:30:10.844 main-tokio- DEBUG multistream_select::listener_select  Listener: confirming protocol: /sup/light/2
2020-04-19 15:30:10.844 main-tokio- DEBUG multistream_select::listener_select  Listener: sent confirmed protocol: /sup/light/2
2020-04-19 15:30:10.856 main-tokio- DEBUG libp2p_core::upgrade::apply  Successfully applied negotiated protocol
2020-04-19 15:30:10.888 main-tokio- DEBUG multistream_select::listener_select  Listener: confirming protocol: /sup/light/2
2020-04-19 15:30:10.888 main-tokio- DEBUG multistream_select::listener_select  Listener: sent confirmed protocol: /sup/light/2
2020-04-19 15:30:10.894 main-tokio- DEBUG afg  Completed round 1978, state = State { prevote_ghost: Some((0xb7d36c4d7935de15c3a8210ac1b3fc762c9b9502c39ad6de458e41932e9cb841, 454)), finalized: Some((0xb7d36c4d7935de15c3a8210ac1b3fc762c9b9502c39ad6de458e41932e9cb841, 454)), estimate: Some((0xb7d36c4d7935de15c3a8210ac1b3fc762c9b9502c39ad6de458e41932e9cb841, 454)), completable: true }, step = Some(Precommitted)
2020-04-19 15:30:10.895 main-tokio- DEBUG afg  Round 1978: prevotes: 2/2/2 weight, 2/2 actual
2020-04-19 15:30:10.895 main-tokio- DEBUG afg  Round 1978: precommits: 2/2/2 weight, 2/2 actual
2020-04-19 15:30:10.895 main-tokio- DEBUG afg  Committing: round_number = 1978, target_number = 454, target_hash = 0xb7d36c4d7935de15c3a8210ac1b3fc762c9b9502c39ad6de458e41932e9cb841
2020-04-19 15:30:10.895 main-tokio- DEBUG afg  Completed round 1978, state = State { prevote_ghost: Some((0xb7d36c4d7935de15c3a8210ac1b3fc762c9b9502c39ad6de458e41932e9cb841, 454)), finalized: Some((0xb7d36c4d7935de15c3a8210ac1b3fc762c9b9502c39ad6de458e41932e9cb841, 454)), estimate: Some((0xb7d36c4d7935de15c3a8210ac1b3fc762c9b9502c39ad6de458e41932e9cb841, 454)), completable: true }, step = Some(Precommitted)
2020-04-19 15:30:10.895 main-tokio- DEBUG afg  Round 1978: prevotes: 2/2/2 weight, 2/2 actual
2020-04-19 15:30:10.895 main-tokio- DEBUG afg  Round 1978: precommits: 2/2/2 weight, 2/2 actual
2020-04-19 15:30:10.895 main-tokio- DEBUG afg  Voter Sunshine Node concluded round 1978 in set 0. Estimate = Some(454), Finalized in round = Some(454)
2020-04-19 15:30:10.934 main-tokio- DEBUG libp2p_core::upgrade::apply  Successfully applied negotiated protocol
2020-04-19 15:30:11.198 main-tokio- DEBUG afg  Casting precommit for round 1979

the code to produce these logs is in https://github.com/paritytech/substrate-subxt/pull/91 and  https://github.com/web3garden/sunshine-node/pull/54
and was invoked with the following cli:
./target/release/sunshine-node --base-path /tmp/alice --alice &> /tmp/alice.log
./target/release/sunshine-node --base-path /tmp/bob --bob
cargo run --example reserve_shares_and_watch --features light-client &> /tmp/lightclient.log

Triaging.
To be more precise, the issue is that this remote sends a message on the notifications substream before the main substream is open. In other words, it is the sender that misbehaves.
I don't really know what could cause this from the top of my head, and if it doesn't cause any bug or misbehaviour I'm tempted to finish #5670, which would fix that issue by design.

Switching IP networks is a good way to cause these warnings.  These warnings are not fatal and eventually go away.

I have this error ( ERROR sync 💔 Called on_block_announce with a bad peer ID) with the new version 8.27 ... me and other people. Can i do anything to fix ? is this a problem for my node?

I have this error ( ERROR sync 💔 Called on_block_announce with a bad peer ID) with the new version 8.27 ... me and other people. Can i do anything to fix ? is this a problem for my node?

same here, got the same error (a lot)
2021-01-13 03:08:17  💤 Idle (46 peers), best: #5748541 (0xccfb…3615), finalized #5748538 (0xcbea…380d), ⬇ 1.0MiB/s ⬆ 937.0kiB>
2021-01-13 03:08:18  💔 Called on_block_announce with a bad peer ID
2021-01-13 03:08:18  💔 Called on_block_announce with a bad peer ID
2021-01-13 03:08:18  💔 Called on_block_announce with a bad peer ID
2021-01-13 03:08:18  💔 Called on_block_announce with a bad peer ID
2021-01-13 03:08:18  💔 Called on_block_announce with a bad peer ID
2021-01-13 03:08:18  ✨ Imported #5748542 (0xd5eb…ed1c)
2021-01-13 03:08:19  💔 Called on_block_announce with a bad peer ID
2021-01-13 03:08:19  ♻  Reorg on #5748542,0xd5eb…ed1c to #5748542,0xf9ce…5b11, common ancestor #5748541,0xccfb…3615
2021-01-13 03:08:19  ✨ Imported #5748542 (0xf9ce…5b11)
after restarting service everything is ok..
version
polkadot 0.8.27-381cae23-x86_64-linux-gnu

same here, got the same error (a lot)
2021-01-13 03:08:17  💤 Idle (46 peers), best: #5748541 (0xccfb…3615), finalized #5748538 (0xcbea…380d), ⬇ 1.0MiB/s ⬆ 937.0kiB>
2021-01-13 03:08:18  💔 Called on_block_announce with a bad peer ID
2021-01-13 03:08:18  💔 Called on_block_announce with a bad peer ID
2021-01-13 03:08:18  💔 Called on_block_announce with a bad peer ID
2021-01-13 03:08:18  💔 Called on_block_announce with a bad peer ID
2021-01-13 03:08:18  💔 Called on_block_announce with a bad peer ID
2021-01-13 03:08:18  ✨ Imported #5748542 (0xd5eb…ed1c)
2021-01-13 03:08:19  💔 Called on_block_announce with a bad peer ID
2021-01-13 03:08:19  ♻  Reorg on #5748542,0xd5eb…ed1c to #5748542,0xf9ce…5b11, common ancestor #5748541,0xccfb…3615
2021-01-13 03:08:19  ✨ Imported #5748542 (0xf9ce…5b11)
after restarting service everything is ok..
version
polkadot 0.8.27-381cae23-x86_64-linux-gnu

Same. I get this error a lot, it seems harmless and goes away after a restart.

Same. I get this error a lot, it seems harmless and goes away after a restart.

Same here, running version 0.8.27-2f845699-x86_64-linux-gnu in Azure Container Instance via parity/polkadot:latest
2021-01-25 16:54:08  💤 Idle (51 peers), best: #3499050 (0xffb2…e13b), finalized #3499049 (0x3ea4…71eb), ⬇ 410.1kiB/s ⬆ 174.5kiB/s
2021-01-25 16:54:09  ✨ Imported #3499051 (0x5402…336d)
2021-01-25 16:54:09  ✨ Imported #3499051 (0x5b26…67e0)
2021-01-25 16:54:09  ✨ Imported #3499052 (0x95c9…fede)
2021-01-25 16:54:14  💤 Idle (51 peers), best: #3499052 (0x95c9…fede), finalized #3499049 (0x3ea4…71eb), ⬇ 1.0MiB/s ⬆ 98.8kiB/s
2021-01-25 16:54:15  💔 Called on_block_announce with a bad peer ID
2021-01-25 16:54:16  ✨ Imported #3499053 (0x71b2…ab58)
2021-01-25 16:54:17  ✨ Imported #3499053 (0xb0ea…744d)
2021-01-25 16:54:17  💔 Called on_block_announce with a bad peer ID
2021-01-25 16:54:19  💤 Idle (51 peers), best: #3499053 (0x71b2…ab58), finalized #3499051 (0x5402…336d), ⬇ 643.2kiB/s ⬆ 423.4kiB/s
2021-01-25 16:54:20  ✨ Imported #3499054 (0xd911…09ad)
2021-01-25 16:54:21  💔 Called on_block_announce with a bad peer ID
2021-01-25 16:54:24  💤 Idle (51 peers), best: #3499054 (0xd911…09ad), finalized #3499051 (0x5402…336d), ⬇ 458.8kiB/s ⬆ 198.2kiB/s
2021-01-25 16:54:27  ✨ Imported #3499055 (0x0f42…246e)
2021-01-25 16:54:27  💔 Called on_block_announce with a bad peer ID
2021-01-25 16:54:29  💤 Idle (51 peers), best: #3499055 (0x0f42…246e), finalized #3499052 (0x95c9…fede), ⬇ 421.7kiB/s ⬆ 142.5kiB/s
2021-01-25 16:54:32  ✨ Imported #3499056 (0x7ca0…0029)
2021-01-25 16:54:33  💔 Called on_block_announce with a bad peer ID
2021-01-25 16:54:34  💤 Idle (51 peers), best: #3499056 (0x7ca0…0029), finalized #3499053 (0x71b2…ab58), ⬇ 613.4kiB/s ⬆ 294.8kiB/s
2021-01-25 16:54:37  ✨ Imported #3499057 (0x3527…d20c)
2021-01-25 16:54:39  💤 Idle (51 peers), best: #3499057 (0x3527…d20c), finalized #3499054 (0xd911…09ad), ⬇ 264.7kiB/s ⬆ 130.1kiB/s
2021-01-25 16:54:39  💔 Called on_block_announce with a bad peer ID
2021-01-25 16:54:44  💤 Idle (51 peers), best: #3499057 (0x3527…d20c), finalized #3499054 (0xd911…09ad), ⬇ 472.4kiB/s ⬆ 167.5kiB/s
2021-01-25 16:54:45  💔 Called on_block_announce with a bad peer ID
2021-01-25 16:54:45  ✨ Imported #3499058 (0x0c49…ba03)
After restarting, everything seems ok.

Same here, running version 0.8.27-2f845699-x86_64-linux-gnu in Azure Container Instance via parity/polkadot:latest
2021-01-25 16:54:08  💤 Idle (51 peers), best: #3499050 (0xffb2…e13b), finalized #3499049 (0x3ea4…71eb), ⬇ 410.1kiB/s ⬆ 174.5kiB/s
2021-01-25 16:54:09  ✨ Imported #3499051 (0x5402…336d)
2021-01-25 16:54:09  ✨ Imported #3499051 (0x5b26…67e0)
2021-01-25 16:54:09  ✨ Imported #3499052 (0x95c9…fede)
2021-01-25 16:54:14  💤 Idle (51 peers), best: #3499052 (0x95c9…fede), finalized #3499049 (0x3ea4…71eb), ⬇ 1.0MiB/s ⬆ 98.8kiB/s
2021-01-25 16:54:15  💔 Called on_block_announce with a bad peer ID
2021-01-25 16:54:16  ✨ Imported #3499053 (0x71b2…ab58)
2021-01-25 16:54:17  ✨ Imported #3499053 (0xb0ea…744d)
2021-01-25 16:54:17  💔 Called on_block_announce with a bad peer ID
2021-01-25 16:54:19  💤 Idle (51 peers), best: #3499053 (0x71b2…ab58), finalized #3499051 (0x5402…336d), ⬇ 643.2kiB/s ⬆ 423.4kiB/s
2021-01-25 16:54:20  ✨ Imported #3499054 (0xd911…09ad)
2021-01-25 16:54:21  💔 Called on_block_announce with a bad peer ID
2021-01-25 16:54:24  💤 Idle (51 peers), best: #3499054 (0xd911…09ad), finalized #3499051 (0x5402…336d), ⬇ 458.8kiB/s ⬆ 198.2kiB/s
2021-01-25 16:54:27  ✨ Imported #3499055 (0x0f42…246e)
2021-01-25 16:54:27  💔 Called on_block_announce with a bad peer ID
2021-01-25 16:54:29  💤 Idle (51 peers), best: #3499055 (0x0f42…246e), finalized #3499052 (0x95c9…fede), ⬇ 421.7kiB/s ⬆ 142.5kiB/s
2021-01-25 16:54:32  ✨ Imported #3499056 (0x7ca0…0029)
2021-01-25 16:54:33  💔 Called on_block_announce with a bad peer ID
2021-01-25 16:54:34  💤 Idle (51 peers), best: #3499056 (0x7ca0…0029), finalized #3499053 (0x71b2…ab58), ⬇ 613.4kiB/s ⬆ 294.8kiB/s
2021-01-25 16:54:37  ✨ Imported #3499057 (0x3527…d20c)
2021-01-25 16:54:39  💤 Idle (51 peers), best: #3499057 (0x3527…d20c), finalized #3499054 (0xd911…09ad), ⬇ 264.7kiB/s ⬆ 130.1kiB/s
2021-01-25 16:54:39  💔 Called on_block_announce with a bad peer ID
2021-01-25 16:54:44  💤 Idle (51 peers), best: #3499057 (0x3527…d20c), finalized #3499054 (0xd911…09ad), ⬇ 472.4kiB/s ⬆ 167.5kiB/s
2021-01-25 16:54:45  💔 Called on_block_announce with a bad peer ID
2021-01-25 16:54:45  ✨ Imported #3499058 (0x0c49…ba03)
After restarting, everything seems ok.

This error comes and goes with each release, with a different cause every time.
This time it was introduced in https://github.com/paritytech/substrate/pull/7464 and was fixed in https://github.com/paritytech/substrate/pull/7700. #7700 will be in Polkadot 0.8.28.

This error comes and goes with each release, with a different cause every time.
This time it was introduced in https://github.com/paritytech/substrate/pull/7464 and was fixed in https://github.com/paritytech/substrate/pull/7700. #7700 will be in Polkadot 0.8.28.


Slow response/Process fails to quit

Quite often, Indigo gets slow in responding to Siri requests and I need to reload the plugin to fix it. In the process of reloading, I get the following error: "process (pid 619) failed to quit after polite request -- forcing it to quit now"

Expected Behavior

Siri requests should be implemented quickly without requiring the plugin to be reloaded

Current Behavior

Process takes a long time to implement requests and gives an error when reload attempts to stop it

Steps to Reproduce (for bugs)

Wait for process to get slow and then reload the plugin. I don't know what causes the process to slow down in the first place.
Versions
 1.0.2

Plugin: YourVersion

Configuration

Homebridge Log / Command Output

I was not able to retrieve the log since it hung up when trying to display the very long log. If it's relevant, I'll try again after the problem appears the next time.

Device Simulation Report

No particular device at issue

This is the exact reason there is an acton built into the plugin to allow you to restart one or all of your HKB servers, I suggest you create a schedule that will fire that action off.  Personally I restart mine weekly because a plugin that processes this much data on a regular basis is bound to have little bits of memory that collect up over time.  As a result of restoring my HKB regularly I never have this issue at all.

OK, I’ll give that a try. Thanks!

On Feb 19, 2019, at 9:40 AM, Colorado Four Wheeler<EMAIL_ADDRESS>wrote:
This is the exact reason there is an acton built into the plugin to allow you to restart one or all of your HKB servers, I suggest you create a schedule that will fire that action off. Personally I restart mine weekly because a plugin that processes this much data on a regular basis is bound to have little bits of memory that collect up over time. As a result of restoring my HKB regularly I never have this issue at all.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/Colorado4Wheeler/HomeKit-Bridge/issues/127#issuecomment-465234937, or mute the thread https://github.com/notifications/unsubscribe-auth/AAhhhAMrQQTPWdjlvHn3zmf1qd8ccMTdks5vPDcdgaJpZM4bDgIZ.

I restart mine every day at 4:15 am

C4W - I used to do the same, restarted using the action, but I found more times than not the servers failed to start. Sometimes it was just one of 5, but often all 5 failed to start.  They normally then started with no problems when I turned on the device switch from iOS Touch app.

I can honestly say I’ve never had that problem one time since maybe the early betas of a server not starting.  The fact that they start some time but not others implies other outside factors are at play.  I used to restart mine daily and now only do it weekly because daily just wasn’t needed and every server starts every time.

I recall having a similar issue back in the early days but never since.  However one thing that I have found that does make management and issue solving easier is rather than have 2-3 servers chock full of items I now have about 15 different servers with items for a specific room.. then any time something goes awry it’s much easier to track down what’s causing it.  Perhaps that may help in your situation?

I did a full server mac restart a few days ago, and things are much better
overall, not just indigo, but specifically HKB as well .  I now have this
set to happen once a week, and will check if HKB can now restart with no
problems.
My server is only 4GB so does struggle a little bit.  REgular restarts
should help .
On Wed, 20 Feb 2019 at 13:58 Mike<EMAIL_ADDRESS>wrote:

I recall having a similar issue back in the early days but never since.
However one thing that I have found that does make management and issue
solving easier is rather than have 2-3 servers chock full of items I now
have about 15 different servers with items for a specific room.. then any
time something goes awry it’s much easier to track down what’s causing it.
Perhaps that may help in your situation?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Colorado4Wheeler/HomeKit-Bridge/issues/127#issuecomment-465585308,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUAZ3I6EGHH_Rj4gjD7Mod4bjHotVb14ks5vPVSYgaJpZM4bDgIZ
.

I just looked at the results of using the HB action to restart my HB server. (The action is titled "Restart All Accessory Servers", maybe because I have only one server) Oddly, the restart action was triggered in the early morning but the actual action of shutting down and restarting the server was delayed until about an hour and a quarter later. I tried to execute it manually and the same thing happened although I haven't waited long enough to see if the server actually restarted later.
Pending figuring out what is happening, I switched the scheduled action to reloading the plugin which seems to execute reliably.

I’m with Mike, from the beginning I have always segmented my devices into multiple servers - mostly for my own sanity and redundancy.  My servers mirror my rooms in Indigo, a bedroom server, offices server, etc.  Also keep all sensors on one, all cameras on one and have one security server that can do all security related things like restart the camera server, unlock doors, open the garage - that I schedule to always turn off each day when I go to bed so that there’s not even the most remote chance that someone can trigger a security device when I don’t want it.

Hi again C4W. I've been limping along for a while now reloading HKB every night and it almost always gives the "failed to quit after polite request" after polite request error. Lately my server has been overheating and I've isolated the problem to HKB. Its IndigoPluginHost process goes up to about 80% CPU usage (gradually over the course of several hours I think) and eventually overheats the CPU. I've started monitoring the CPU temperature and automatically reloading the plugin when it exceeds a threshold to prevent the crash, but this is obviously not a good solution.
I haven't been able to isolate the cause to any specific device. I think that its memory usage also creeps up over time, possibly related to a memory leak issue that another user reported in the Indigo forum.
So, I was wondering if anything more has been learned about the cause of this problem with a solution other than reloading the plugin. Of course, if there is any further information I can provide or tests I can run, I'd be more than happy to help. I'll also try to break the devices up into even more servers to see if that helps.
And thanks again for this great plugin! It's one of the most important on my server.
--Dave

I think I may have found what triggers the problem! I have a MagicHome device for a closet LED strip that is controlled via the FluxLED plugin. I noticed a bunch of entries in the HKB log for it so I tried removing the device from HKB. Sure enough, the plugin CPU and memory utilization dropped way down similar to that of other plugins and it has not crept up after a couple of hours now.
Here is an excerpt of the log entries that appear about once per second. No errors, just a lot of entries.
FluxLED HKB log.txt
That said, I don't know why this is happening or if it is even the root cause of the memory and CPU utilization issues. It may just cause them to go up much faster than normal and maybe I'll still have to reload the plugin, just not so often. I'll probably have to leave the device off of HKB since I don't know any way to configure it to solve the problem. Of course, I'll also let the FluxLED developer know what's happening in case he can provide some more insight.
Glad to make some progress on this after so many months!
--Dave

At first blush my guess on this would be that the device is constantly changing and constantly sending status changes back to Indigo non-stop.  This is based on you removing that one device and everything settling down.

Yeah, makes sense and it's probably slowing down my other devices too with so much activity. I'll let you know if I make any progress with the FluxLED developer. Please let me know if you notice anything in the log that sheds more light; I wasn't able to get much out of it. Thanks.


settings: file: Fix flash area erase offset

Incorrect erase start offset has been given.
Signed-off-by: Dominik Ermel<EMAIL_ADDRESS>

Strange that this was never discovered. Nice catch

There are board overlay files, which reconfigure whole flash (from offset 0x0) to be used as LittleFS. And only those boards are allowed in testcase.yaml.


Backend and documentation rewrite

Added better:

Deploy script
Documentation
README
Backend structure and RESTPlus
Travis setup (fast_finish and allow mac to fail)
Backend now restores sessions, for example, if a user still has a browser open after backend restarts.
Minor tweaks to frontend code, which will be replaced anyway.

See individual commits and #3 #4 #5 #6 #7

@Berstad @michaelpande Ready to merge.

It is a Good Idea (tm) to review commit by commit. One commit is 4 000 lines of auto-generated html.


[Model] Support for models with head size 120

Adds support for models with head size 120.
Need to understand this code comment:
    // NOTE(woosuk): To reduce the compilation time, we only compile for the
    // head sizes that we use in the model. However, we can easily extend this
    // to support any head size which is a multiple of 16.

120 is not a multiple of 16. I could not find anywhere in the code where a multiple of 8 does not also work.
Maybe related but doesn't seem like it: https://github.com/vllm-project/vllm/blob/a22dea54d3e80bf069cfeed8002a193ef8b18e1b/csrc/attention/attention_kernels.cu#L200
Discussion here: https://github.com/vllm-project/vllm/discussions/5918

 PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

@WoosukKwon can I ask for insight on the multiple of 16 comment? I haven't been able to find issue with multiples of 8 yet.


Asynchronous or Synchronous scripts?

According to https://rviscomi.github.io/capo.js/user/rules/#-8-asynchronous-scripts
<script async src>
The following scripts were included in the Asynchronous scripts order:
<script type="text/javascript"> document.documentElement.className = 'js'; </script>
<script type="text/javascript" src=""></script>
<script type="text/javascript" src="" id="jquery-migrate-js"></script>

I thought maybe they should have been included in Synchronous scripts?

Could you share a reproducible example using the demo page?
https://rviscomi.github.io/capo.js/user/demo/?url=https://www.example.com/

Not that I can see:

Ok thanks, looks like this is WAI

I'm sorry, what is WAI?

Working as intended

Yeah, asynchronous scripts are specifically defined as script[async], but that script has a data attribute coincidentally named data-cfasync. Data attributes are just ways to stuff information into DOM elements and browsers don't behave any differently when they're encountered.

Thanks, Rick, for the explanation!
WAI !


A canary roadmap

LGTM, assuming it's plain old Java.

@fvaleri any concerns if it is not plain old Java but using some framework like Quarkus for example?

LGTM, assuming it's plain old Java.

@fvaleri any concerns if it is not plain old Java but using some framework like Quarkus for example?

In that case, you should use the tested Quarkus-Kafka extension, so you would get kafka-clients as transitive dependency. For that reason, you risk to wait some more time after a new release in order to get the latest enhancements. Just my 2 cents.

In that case, you should use the tested Quarkus-Kafka extension, so you would get kafka-clients as transitive dependency. For that reason, you risk to wait some more time after a new release in order to get the latest enhancements. Just my 2 cents.

That's a very good point. We aim to have the most up to date Kafka clients and maybe using Quarkus could slow down the process. @tombentley I would take this into account.

I see the proposal mixing the re-implementation in Java (which is something I agree) and some additions which could be done even with the current canary written in Golang.
I am referring mostly to the "Integration examples" section which is something we provide, or "Actionable documentation" which is something we could provide even sticking with Golang.
Even some of the topics in the "Differential observations" could be addressed as well with Golang implementation.

Of course we could do those things in Golang, but the fact of the matter is there's no one active in the community willing to do that in Golang, so it's a moot point. The other positive technical/functionality improvements are, in practice, not separable from the re-implementation.

Use this opportunity to reevaluate the features it is providing if we are going to do a complete re-write

Are the features you'd remove then?

I don't really see it as a problem if the Canary isn't using the very latest client version. The compatibility guarantees are good. We wouldn't always be able to use new RPCs anyway (newer canary but older brokers). The point is more that using the Java clients means we can use newer features in a way that suits us, rather than not being able to because the client library we're using doesn't support them.

@tombentley but what if the Kafka client (in the latest Kafka release) gets a new "feature" that we would like to use immediately in the canary (maybe even because we contributed in the upstream community) but then we can't do until there is a new Quarkus version containing it?

Use this opportunity to reevaluate the features it is providing if we are going to do a complete re-write

Are the features you'd remove then?

I'm not sure I know the current features well enough. But the Proposal reads to me right now as a rewrite in Java. If you considered the functionality and thing it is all great and needed, then its fine and I guess you can mention it. I'm simply trying to point out that it would be a shame to just rewrite it to Java and then think about the features and rewrite it again. So re-considering the current and desired features should be IMHO part of it. I know the re-write to Java is not primarily motivated by changing the functionality. But it is a good chance to re-evaluate it.
In terms of missing functionality, my impression is today that it has a lot of low level details which might be useful for some. But it is missing some high level value such as availability metrics etc. The high-level appeal is IMHO important for regular users who do not understand the low-level numbers. If you look at the dashboard we provide, it does not offer much useful information -> to be honest it didn't convinced even me to install it.

Together with @ppatierno and @tombentley we agreed on keeping this proposal mainly for rewriting Canary to Java and for new metrics and features we'll create a new proposal.
I also added the Changes and removals section.

Triaged on the Strimzi Community call on 25.1.2024: @im-konge might get back to the ideas from this a new new fresh PR, although possibly based on this proposal. This should be closed.


Update golangci-lint to 1.28.3

New release is out, we should update.

I think this is not need now

Yes. Superseded by #772


Clarified difference between GFile and FastGFile.

Fixes #12663

Nagging Assignee @ekelsen: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @ekelsen: It has been 29 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @ekelsen: It has been 44 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @ekelsen: It has been 59 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @ekelsen: It has been 74 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @ekelsen: It has been 89 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.


Scroll to top button needed

Hello @Sar-taj107,
I want to add a small scroll to the top button on the bottom right side of the page. This will be useful for many users even if the list of questions becomes long.  Would love to contribute to this change towards Hacktoberfest. Kindly assign me as I will be doing the PR.

sure @Maaz-Code
thanks for showing your interest to contribute to this repo pls start contributing & also do share this repo with your friend to contribute in HF23


request: parquet source

Hello,
thank you for the very nice tool, do you plan to extend the data source formats with parquet?

I think graphic-walker's position is to be used as a embeddable component, instead of a web app. The datasource connection layer should be implement outside graphic-walker.
But it is still a good idea that graphic-walker provides a seperated progressive data source module can be imported for those who need.


web: add scaffolding for Tilt web UX

Hello @yuindustries, @maiamcc,
Please review the following commits I made in branch nicks/ch1144/react2:
dfd6564eff3428b753de268bae78722fc36590a8 (2018-12-21 15:30:27 -0500)
web: add scaffolding for Tilt web UX


support for 24 word seed phrases

Would love to have that, thanks!

Thanks @jancamenisch, I just released v1.6.2, which should resolve this issue. The generate command now allows a user to specify the bits of entropy using -b. Valid values are 128, 160, 192, 224, 256 for 12-, 15-, 18-, 21-, and 24-word seed phrases, respectively. 128 bits is still the default behavior.


NUTCH-2490 Develop Gradle Core Build for Apache Nutch

This is a WIP for https://issues.apache.org/jira/browse/NUTCH-2940. The work was conducted by @AzureTriple @imanzanganeh @jbsimmon @LilyPerr and @Lirongxuan1 from the 2022 USC Senior CS Capstone Program.
Most of the core build is in place. No plugin sub-projects have been implemented yet.
I intend to continue work on the code build until it is completed. I will then move on to the plugin sub-projects.

I'll squash and merge commits into one when we are ready to merge into master branch.


Look for the appropriate hbs file if handlebars is chosen as the view engine

Mandrill email notifications do not work if handlebars is selected as the view engine.
This doesn't seem to affect any other view engine considering there are no other issues related besides this one:
https://github.com/keystonejs/keystone/issues/1441

@peterpme is this still useful? mind rebasing. I'm revisiting emails.

I had a brain fart and opened up a new PR  >  < #170

I'll close this for now since #170 supersedes it!


[Minecraft] bedrock server not starting after update - execute permission missing

Environment

OS: Ubuntu 18.04.3
CPU: Intel(R) Core(TM) i5-4690 CPU @ 3.50GHz (4C/4T)
AMP Version: v<IP_ADDRESS>, built 02/03/2021 12:23

Expected behaviour
user should be able to update and start application
Steps to reproduce:

create a new minecraft bedrock server
start the instance
go to configuration/minecraft
check server type is bedrock
click 'download/update'
try to start the application
observe that the start action hangs (no errors or progress)

Logs
[08:13:04] [Minecraft:av-admin Error] : Unable to start Minecraft Server
[08:13:04] [Core:av-admin Error]  : Win32Exception
[08:13:04] [Core:av-admin Error]  : [0] (Exception) : ApplicationName='./Minecraft/bedrock_server', CommandLine='', CurrentDirectory='./Minecraft/', Native error= Cannot find the specified file
[08:13:04] [Core:av-admin Error]  :   at Diagnostics.Process.StartWithCreateProcess (Diagnostics.ProcessStartInfo startInfo)
  at Diagnostics.Process.Start ()
  at ModuleShared.AMPProcess.Start ()
  at (wrapper remoting-invoke-with-check) ModuleShared.AMPProcess.Start()
  at MinecraftModule.MinecraftApp.StartGameServer (Boolean autoRetry)

(full log attached)
Workaround

stop the instance
log into server with SSH
go into instance folder / Minecraft
observe that bedrock_server has no 'execute' bit set
sudo chmod +x bedrock_server
start the instance
start the application

AMPLOG.log

Can confirm, same issue over here with fresh install.

This issue has been resolved in the latest update, it manually re-applies the execute bit (for some reason they stopped supplying it pre-set in the archive) so that it functions correctly.


[Bug]: Can't Destroy snowflake_grant_ownership resource when more grants exist

Terraform CLI Version
1.9.8
Terraform Provider Version
0.97.0
Company Name
Easypark
Terraform Configuration
/* This is from a module */
resource "snowflake_database" "this" {
  provider = snowflake.sysadmin

  name    = local.db_name_u
  comment = local.m_comment

  is_transient = local.m_timetravel_range == 0 ? true : false

  data_retention_time_in_days     = local.m_timetravel_range
  max_data_extension_time_in_days = local.m_extend_fail_safe_to

}

# Set ownership of database
resource "snowflake_grant_ownership" "this" {
  provider = snowflake.securityadmin

  account_role_name = var.set_ownership_to

  on {
    object_type = "DATABASE"
    object_name = snowflake_database.this.name
  }

  outbound_privileges = local.m_existing_grants_behavior
}

resource "snowflake_grant_privileges_to_account_role" "sysadmin_admin" {
  provider = snowflake.securityadmin
  count    = var.set_ownership_to != "SYSADMIN" ? 1 : 0

  privileges = [
    "MODIFY",
    "MONITOR",
    "USAGE"
  ]

  with_grant_option = false

  on_account_object {
    object_type = "DATABASE"
    object_name = snowflake_database.this.name
  }

  account_role_name = "SYSADMIN"
}

Category
category:grants
Object type(s)
resource:grant_ownership, resource:grant_privileges_to_account_role
Expected Behavior
When doing anything which will result in snowflake_grant_ownership to be destroyed (even if recreated), the resource would be destroyed and ownership would revert to the original (or previous, or designated, etc.) owner.
Actual Behavior
The destroy fails with error:
Error: An error occurred when transferring ownership back to the original role
  Id: ToAccountRole|"{CurrentOwner}"||OnObject|DATABASE|"{Database}"
  Error: 003036 (23001): SQL execution error: Dependent grant of privilege 'MODIFY' on securable '{Sandbox}' to role 'SYSADMIN' exists.  It must be revoked first.  More than one dependent grant may exist: use 'SHOW GRANTS' command to view them.  To revoke all dependent grants while transferring object ownership, use convenience command 'GRANT OWNERSHIP ON <target_objects> TO <target_role> REVOKE CURRENT GRANTS'.

Steps to Reproduce

Create the resources using the configuration above, assigning ownership (var.set_ownership_to) to any role except SYSADMIN or SECURITYADMIN
Attempt to destroy the resources

How much impact is this issue causing?
Medium
Logs
https://gist.github.com/AaronCoquet-Easypark/f75f47973e4b39cb68b7b28dad47e217
Additional Information
This seems to be similar to #3143, but is distinct from it. Once resolved, I fear that this issue will reveal that #3143 is also present.
Would you like to implement a fix?

[ ] Yeah, I'll take it 😎

Hey @AaronCoquet-Easypark
Thanks for reporting this. It seems like there is an implicit dependency on roles that are preventing Terraform from deleting the ownership resource. I believe that specifying the dependency between the resources in the correct manner should resolve the issue (The order should be specified so create will happen in that order: database -> grant ownership -> grant privileges; then delete will happen in reverse, meaning the privileges to the sysadmin should not break the grant ownership resource). Here's an example:
resource "snowflake_database" "test" {
  name = "grant_ownership_test_database"
}

resource "snowflake_account_role" "test" {
  name = "grant_ownership_test_account_role"
}

resource "snowflake_grant_ownership" "test" {
  account_role_name = snowflake_account_role.test.name
  on {
    object_type = "DATABASE"
    object_name = snowflake_database.test.name
  }
}

resource "snowflake_grant_privileges_to_account_role" "test" {
  depends_on = [ snowflake_grant_ownership.test ]
  account_role_name = "SYSADMIN"
  privileges = [ "USAGE", "MODIFY", "MONITOR" ]
  on_account_object {
    object_type = "DATABASE"
    object_name = snowflake_database.test.name
  }
}

Let me know if that's the case.

Hey @AaronCoquet-Easypark
Could you confirm that my previous message is true and no work is needed on our side? Thanks!


[Feature] Ability to set a list of valid Auth Mechanisms when constructing the SmtpServer

Ability to configure the list of supported Auth mechanisms when configuring the SmtpServer.
Such as to support scenarios listed here https://github.com/rnwood/smtp4dev/issues/852

I would like to see this feature as well but in context of disabling plain auth.


Update akka-http, akka-http-spray-json to 10.2.3

Updates

com.typesafe.akka:akka-http
com.typesafe.akka:akka-http-spray-json

from 10.2.2 to 10.2.3.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.typesafe.akka" } ]

labels: library-update, semver-patch

Superseded by #199.


Truncated output segments

Hey all,
I have been facing an issue with UniLM V1, where the model has been fine-tuned for a Case correction task. Case correction is the problem where the model figures out which words need to be capitalized. The input to the model is all words in Capital case(first character of word Capital) and output being the correct case.
However, the predictions have been truncated. I have used the model within the summarization & questions generation task; however, I observed truncation when the max_seq_length or max_pred were set quite low. Here the max number of tokens in the input & output is 70.
I used the following snippet for fine-tuning and predictions, respectively.

However, I am observing about 10% of cases where the output is truncated like
Model output:

Masked against coronavirus, Shanghai's ballet dancers pirouette and

Correct output

Masked against coronavirus, Shanghai's ballet dancers pirouette and plie

Any help will be appreciated, thanks!

Hi @aretius ,
We haven't encountered the issue before. In the training data, whether there were some examples being truncated? For the case correction task, because we can know the alignments between input and output, we can constrain the candidate predictions and length. The model can be forced to predict the desired number of tokens. Another solution would be trying the new package https://github.com/microsoft/unilm/tree/master/s2s-ft released for s2s fine-tuning.

Thanks for the response @donglixp !
Yes, it is indeed quite weird. I am also attaching a distribution of token length in input.

Just had a few follow-up questions

Is it possible that the model is biased to produce outputs of the average token length of input(since the dataset size is ~8K data points)?
Since the input has all words cased the # of tokens in input and correct output are different. So I am not sure how will we end up constraining the candidate predictions and length. Could you help me with the code piece in the repo that will allow me to do the same?
How is the s2s-ft different from UniLM v1 code piece?

@donglixp I observed that training with a larger dataset reduces the truncation rate to a mere 2%. When having a smaller dataset, can you provide some info on the epochs to run it for?

@aretius For the case correction task, because we can know whether the output is completely decoded, we can forbid the end-of-sequence token until all the desired tokens are emitted. For example, if we found that the current prediction is Masked against coronavirus, Shanghai's ballet dancers pirouette and (i.e., the word plie is missing), we could assign a large negative score for , so that the output won't be truncated.


Api

For this milestone of the Leaderboard project, I did the following: 📑

Create a new game sending a POST request to the Leaderbord API using Postman. 💥
Create submitScores() to  PUT a new score. ✏
Create renderScores() to GET the scores and render them into the UI. 🎭

😎

Thank you!


Biomes

We should star thinking about biomes.

How do we store them? (Maybe, static instances).
How do we figure out, in witch biome player is?
Add spawn rate, include boss event in it (when boss spawns, other enemies must not spawn).
How fast we need react to biome change?

Small update: here is how Terraria detects a biome:

How terraria does it in mods: https://forums.terraria.org/index.php?threads/modding-tutorial-world-generation.47601/

Should add some kind of generation queue, that can be modified from mods.

In progress now, added biome checker in thread, that check current biome every 3 seconds. TODO: draw backgrounds and find music.