CPU and Memory Utilization for TGI

Feature request
This is a request for exposing the cpu and memory utilization metrics for TGI. This will be helpful to autoscale when the load reaches a certain limit.
Also, can anyone help me with the list of metrics provided, I couldn't find it here, https://huggingface.github.io/text-generation-inference/#/Text%20Generation%20Inference/metrics
Motivation
<>
Your contribution
<>

Hi @snps-ravinu , thanks for your feedback!
For CPU and memory utilization, it is probably better to use those from the container runtime (if using k,8s, that would be metrics-server for autoscaling). Is there any particular reason you would need TGI to report those?
We plan to document the metrics exposed by TGI to make them easier to use.


feat(bio): added example when no user is found #144

closes #144

Looks good, I made 1 small suggestion.

Thank you, for your feedback. Adjusted pull request to your suggestion.

Thanks, I forgot about the command prefix.

Thanks, I forgot about the command prefix.

Me too 😂


Remove sed invocation from profiling plugin.

What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.81%. Comparing base (67d4f7a) to head (4fb2105).
Report is 32 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #690      +/-   ##
==========================================
+ Coverage   71.79%   71.81%   +0.01%
==========================================
  Files         271      271
  Lines       40931    41003      +72
==========================================
+ Hits        29388    29446      +58
- Misses      11543    11557      +14

Components
Coverage Δ

crashtracker
20.33% <ø> (-0.09%)
:arrow_down:

crashtracker-ffi
9.07% <ø> (ø)

datadog-alloc
98.73% <ø> (ø)

data-pipeline
91.92% <ø> (+0.32%)
:arrow_up:

data-pipeline-ffi
0.00% <ø> (ø)

ddcommon
82.74% <0.00%> (+0.01%)
:arrow_up:

ddcommon-ffi
69.12% <ø> (ø)

ddtelemetry
59.10% <85.71%> (ø)

ddtelemetry-ffi
22.13% <ø> (ø)

dogstatsd
88.86% <ø> (-0.19%)
:arrow_down:

dogstatsd-client
79.77% <ø> (ø)

ipc
82.65% <94.44%> (-0.04%)
:arrow_down:

profiling
84.30% <ø> (+0.03%)
:arrow_up:

profiling-ffi
77.46% <ø> (+0.03%)
:arrow_up:

serverless
0.00% <ø> (ø)

sidecar
36.09% <33.33%> (+0.02%)
:arrow_up:

sidecar-ffi
0.00% <0.00%> (ø)

spawn-worker
50.36% <ø> (ø)

tinybytes
94.77% <ø> (ø)

trace-mini-agent
72.45% <62.50%> (-0.22%)
:arrow_down:

trace-normalization
98.25% <ø> (ø)

trace-obfuscation
95.77% <ø> (+0.03%)
:arrow_up:

trace-protobuf
77.67% <ø> (ø)

trace-utils
93.08% <57.14%> (-0.21%)
:arrow_down:

Unrelated, but a nitpick that I noticed when playing around with the builder code. Any file not already added in the builder/build directory is ignored 🤷🏼♂
Here's the patch.
diff --git .gitignore .gitignore
index a98646fb..37987d6c 100644
--- .gitignore
+++ .gitignore
@@ -7,7 +7,8 @@
 .idea
 .vs
 .vscode
-build/
+**/build/*
+!/builder/build/*
 cmake-build-debug
 deliverables
 target


Bump msrv to 1.70

Checking MSRV locally is frustrating, because it requires switching toolchain and renaming files, but it is even more frustrating because updating cargo index before 1.70 is so sloooooow.
1.70 switched to sparse cargo index protocol by default, which makes checking the crate much faster. Let's bump MSRV to improve developer experience.
I also added "rust-version" field to Cargo.toml files, because this is the official place to specify MSRV and in the future will be used by Cargo during dependency resolving.
1.70 is over a year old (released on 1st June 2023), so I doubt this bump will cause any problems.
Related: we will need to decide on MSRV policy past 1.0. I propose to settle on 6 month policy (= we only support Rust versions released during last 6 months).
Rust ecosystem seems to not be very conservative on this:

Tokio has the exact same MSRV policy that I propose here: https://github.com/tokio-rs/tokio
time crate guarantess support of current stable and 2 previous versions (= minimum 4 months )
chrono is a bit more conservative, with 1.61 MSRV: https://docs.rs/chrono/latest/chrono/

Pre-review checklist

[x] I have split my patch into logically separate commits.
[x] All commit messages clearly explain what they change and why.
[ ] I added relevant tests for new features and bug fixes.
[x] All commits compile, pass static checks and pass test.
[x] PR description sums up the changes and reasons why they should be introduced.
[ ] I have provided docstrings for the public items that I want to introduce.
[ ] I have adjusted the documentation in ./docs/source/.
[ ] I added appropriate Fixes: annotations to PR description.

I propose to settle on 6 month policy (= we only support Rust versions released during last 6 months)

Then we will not support versions that were released more than 6 months ago. You probably meant that MSRV should be a version that is at least 6 months old (AFAIU, this is the tokio's policy), correct? If so, then I agree that such policy makes sense.

I propose to settle on 6 month policy (= we only support Rust versions released during last 6 months)

Then we will not support versions that were released more than 6 months ago. You probably meant that MSRV should be a version that is at least 6 months old (AFAIU, this is the tokio's policy), correct? If so, then I agree that such policy makes sense.

Yes, you're right, and that is what I'd like to propose.
And just like Tokio, this wouldn't be automatic: if we don't see the benefit in bumping MSRV we can stay on older one for much longer.

@muzarski I updated the description regarding the 6 months policy.


[VS Code] Joining collaboration session: 无法连接到服务器。请检查你是否已连接到 Internet。

<!--
For Visual Studio problems/feedback, please use the Report

Can you please share your logs?
You can access them via the Live Share: Export Logs command from the command palette (ctrl + shift + p) and attach them to this issue.

Thanks for reaching out! This seems to be a duplicate of #1113. Please re-open the issue if you believe that is not the case. Thanks for using LiveShare and please keep the feedback coming!


RDS: Global Cluster not associating secondary clusters

Moto ==4.1.9.dev13
Global cluster's cluster members is missing secondary clusters when a global cluster is assigned a primary cluster.
Replicate -
Create primary cluster with create_db_cluster in us-east-1
Create secondary cluster with create_db_cluster in us-west-2 with the primary cluster's arn as ReplicationSourceIdentifier
*Note that the secondary cluster is now added under the primary cluster's ReadReplicaIdentifiers
Create global database with SourceDBClusterIdentifier as the primary cluster's arn.
The global database will have the primary cluster listed as a cluster member, but the secondary cluster is missing from the list.

This happens regardless of region, if the secondary cluster is created in us-east-1 the bug happens anyway

@bblommers I can take a look at this

@kevho48 I am not able replicate the behaviour for your first scenario. In AWS, if I follow these steps and call describe_global_clusters then only the 1st cluster is listed in GlobalClusterMembers:
import boto3
import json
from time import sleep

c = boto3.client('rds', 'eu-west-1')

cluster_id = 'test1'
db_subnet_group = 'default-vpc-8e69a9e9'

print('creating cluster1')
c.create_db_cluster(
    DBClusterIdentifier=cluster_id, Engine='aurora-mysql',
    DBSubnetGroupName=db_subnet_group, DBClusterParameterGroupName='raf-test',
    MasterUsername='test', MasterUserPassword='MasterUserPassword',
    # AvailabilityZones=['eu-west-1a', 'eu-west-1b']
)

print('creating instance1')
c.create_db_instance(
                DBInstanceIdentifier=f'{cluster_id}-i1',
                DBInstanceClass='db.r5.large',
                Engine='aurora-mysql',
                PubliclyAccessible=False,
                AvailabilityZone='eu-west-1a',
                DBSubnetGroupName=db_subnet_group,
                DBClusterIdentifier=cluster_id,
            )

# wait for instance to come up..
while True:
    resp = c.describe_db_instances(DBInstanceIdentifier=f'{cluster_id}-i1')
    if resp["DBInstances"][0]['DBInstanceStatus'] == 'available':
        break
    sleep(10)

c2 = boto3.client('rds', 'eu-west-2')
cluster_id2 = 'test2'
db_subnet_group2 = 'test'

print('creating cluster2')
c2.create_db_cluster(
    DBClusterIdentifier=cluster_id2, Engine='aurora-mysql',
    DBSubnetGroupName=db_subnet_group2,
    ReplicationSourceIdentifier=f'arn:aws:rds:eu-west-1:1234567890:cluster:{cluster_id}'
)

print('creating instance2')
c2.create_db_instance(
                DBInstanceIdentifier=f'{cluster_id2}-i1',
                DBInstanceClass='db.r5.large',
                Engine='aurora-mysql',
                PubliclyAccessible=False,
                AvailabilityZone='eu-west-2a',
                DBSubnetGroupName='test',
                DBClusterIdentifier=cluster_id2,
            )

# wait for instance to come up..
while True:
    resp = c2.describe_db_instances(DBInstanceIdentifier=f'{cluster_id2}-i1')
    if resp["DBInstances"][0]['DBInstanceStatus'] == 'available':
        break
    sleep(10)

print('creating global cluster')
c.create_global_cluster(
    GlobalClusterIdentifier='global',
    SourceDBClusterIdentifier=f'arn:aws:rds:eu-west-1:1234567890:cluster:{cluster_id}',
)

resp = c2.describe_global_clusters()
print(json.dumps(resp, indent=2, default=str))

Output:
[
  {
    "GlobalClusterIdentifier": "global",
    "GlobalClusterResourceId": "cluster-036bf968fb5480e7",
    "GlobalClusterArn": "arn:aws:rds::1234567890:global-cluster:global",
    "Status": "available",
    "Engine": "aurora-mysql",
    "EngineVersion": "5.7.mysql_aurora.2.11.2",
    "StorageEncrypted": false,
    "DeletionProtection": false,
    "GlobalClusterMembers": [
      {
        "DBClusterArn": "arn:aws:rds:eu-west-1:1234567890:cluster:test1",
        "Readers": [],
        "IsWriter": true
      }
    ]
  }
]

Is this the scenario you had in mind?

that's a little strange, it should have both clusters as global cluster members.

Perhaps I am missing some steps 🤔
If you can reproduce the desired behaviour then please post the steps. Ideally it would  boto3 code to ensure we are both looking at the same stuff.

After running ☝ code and
resp = c.describe_db_clusters()
print('region 1 clusters')
print(json.dumps(resp, indent=2, default=str))

print('region 2 clusters')
resp2 = c2.describe_db_clusters()
print(json.dumps(resp2, indent=2, default=str))

Output, with less relevant fields removed:
region 1 clusters
{
  "DBClusters": [
    {
      "AllocatedStorage": 1,
      "AvailabilityZones": [
        "eu-west-1b",
        "eu-west-1a",
        "eu-west-1c"
      ],
      ...
      "ReadReplicaIdentifiers": [
        "arn:aws:rds:eu-west-2:1234567890:cluster:test2"
      ],
      "DBClusterMembers": [
        {
          "DBInstanceIdentifier": "test1-i1",
          "IsClusterWriter": true,
          "DBClusterParameterGroupStatus": "in-sync",
          "PromotionTier": 1
        }
      ],
      ....
      "DBClusterArn": "arn:aws:rds:eu-west-1:1234567890:cluster:test1",
      ...
    }
  ]
}
region 2 clusters
{
  "DBClusters": [
    {
      "AllocatedStorage": 1,
      "AvailabilityZones": [
        "eu-west-2a",
        "eu-west-2b",
        "eu-west-2c"
      ],
      ...
      "ReplicationSourceIdentifier": "arn:aws:rds:eu-west-1:1234567890:cluster:test1",
      "ReadReplicaIdentifiers": [],
      "DBClusterMembers": [
        {
          "DBInstanceIdentifier": "test2-i1",
          "IsClusterWriter": true,
          "DBClusterParameterGroupStatus": "in-sync",
          "PromotionTier": 1
        }
      ],
      ..
      "DBClusterArn": "arn:aws:rds:eu-west-2:1234567890:cluster:test2",
      ..
    }
  ]
}

Calling create_global_cluster appears to make no difference to the output.

Unfortunaltely AWS is a little inconsistent with cluster states. AWS cluster responses do not contain reference to the global cluster however the describe_global_clusters response should contain all cluster members
Describe global DB response
{     "GlobalClusters": [         {             "GlobalClusterIdentifier": "test-global-database",             "GlobalClusterResourceId": "cluster-77eeee47cce21f24",             "GlobalClusterArn": "arn:aws:rds::586488143756:global-cluster:test-global-database",             "StorageEncrypted": true,             "DeletionProtection": false,             "GlobalClusterMembers": [                 {                     "DBClusterArn": "arn:aws:rds:us-east-1:586488143756:cluster:test-primary-cluster",                     "Readers": [                         "arn:aws:rds:us-west-2:586488143756:cluster:test-secondary-cluster"                     ],                     "IsWriter": true                 },                 {                     "DBClusterArn": "arn:aws:rds:us-west-2:586488143756:cluster:test-secondary-cluster",                     "Readers": [],                     "IsWriter": false,                 }             ]         }     ] }
This global DB has both a primary and secondary cluster with both listed within GlobalClusterMembers
**Only including some of the fields for one of the describe-db-cluster responses (primary cluster) since majority of the fields are the same minus a couple of values or so.
{     "DBClusters": [         {             "AllocatedStorage": 1,             "AvailabilityZones": [                 "us-east-1a",                 "us-east-1c",                 "us-east-1d"             ],             "DBClusterIdentifier": "test-primary-cluster",             "ReadReplicaIdentifiers": [                 "arn:aws:rds:us-west-2:586488143756:cluster:test-secondary-cluster"             ],             "DBClusterMembers": [                 {                     "DBInstanceIdentifier": "test-primary-cluster-i1",                     "IsClusterWriter": false,                     "DBClusterParameterGroupStatus": "in-sync",                     "PromotionTier": 1                 },             ],             "DBClusterArn": "arn:aws:rds:us-east-1:586488143756:cluster:test-primary-cluster",             "GlobalWriteForwardingRequested": false         }     ] }
The boto3 documentation also shows that describe_db_cluster responses only contain two fields related to the global cluster

GlobalWriteForwardingStatus & GlobalWriteForwardingRequested

You should be able to replicate this if you

Create the global database
Create the primary cluster and supply GlobalClusterIdentifier.
Create the secondary cluster and supply GlobalClusterIdentifier param just like the first call

Thanks for trying to clear things up @mayesca. However, without a reliable way to reproduce the desired behaviour I don't have a clear goal to aim for.
Can you provide code to reproduce desired behaviour? Feel free to take inspiration from my previous post https://github.com/getmoto/moto/issues/6260#issuecomment-1559677764

@rafcio19 - Code below but the main difference is order of resource creation outlined in https://github.com/getmoto/moto/issues/6260#issuecomment-1584599054
import boto3
import json
from time import sleep

east_client = boto3.client('rds', 'us-east-1')
west_client = boto3.client('rds', 'us-west-1')

# Create global cluster
print('creating global db')
response = east_client.create_global_cluster(
    GlobalClusterIdentifier='test-global-db',
    Engine='aurora-mysql',
    DeletionProtection=False,
    DatabaseName='test-db',
    StorageEncrypted=False
)

#Wait for primary cluster to be come available
while True:
    resp = east_client.describe_global_clusters(GlobalClusterIdentifier="test-global-db")
    global_clusters = resp.get("GlobalClusters", None)
    if global_clusters and global_clusters[0].get('Status') == 'available':
        break
    sleep(10)

print('creating primary cluster')
east_client.create_db_cluster(
    DBClusterIdentifier="test-primary-cluster", Engine='aurora-mysql',
    GlobalClusterIdentifier="test-global-db",
    MasterUsername='testUsername', MasterUserPassword='testPassword',
)

#Wait for primary cluster to be come available
while True:
    resp = east_client.describe_db_clusters(DBClusterIdentifier="test-primary-cluster")
    db_clusters = resp.get("DBClusters", None)
    if db_clusters and db_clusters[0].get('Status') == 'available':
        break
    sleep(10)

print('creating primary cluster instance')
east_client.create_db_instance(
                DBInstanceIdentifier='test-primary-cluster-i1',
                DBInstanceClass='db.r5.large',
                Engine='aurora-mysql',
                PubliclyAccessible=False,
                DBClusterIdentifier='test-primary-cluster',
            )

# wait for primary cluster instane to come up..
while True:
    resp = east_client.describe_db_instances(DBInstanceIdentifier="test-primary-cluster-i1")
    db_instances = resp.get("DBInstances", None)
    if db_instances and db_instances[0].get("DBInstanceStatus") == 'available':
        break
    sleep(10)

print('creating secondary cluster')
west_client.create_db_cluster(
    DBClusterIdentifier="test-secondary-cluster", Engine='aurora-mysql',
    GlobalClusterIdentifier="test-global-db"
)

# wait for secondary cluster to come up..
while True:
    resp = west_client.describe_db_clusters(DBClusterIdentifier="test-secondary-cluster")
    db_clusters = resp.get("DBClusters", None)
    if db_clusters and db_clusters[0].get("Status") == 'available':
        break
    sleep(10)

resp = east_client.describe_global_clusters(GlobalClusterIdentifier="test-global-db")
print(json.dumps(resp, indent=2, default=str))

Output of code above. I only included the response from describe_global_clusters to show that it includes both the primary and secondary cluster.
(Playground) ☁  Playground  python3 runner.py
creating global db
creating primary cluster
creating primary cluster instance
creating secondary cluster
{
  "GlobalClusters": [
    {
      "GlobalClusterIdentifier": "test-global-db",
      "GlobalClusterResourceId": "cluster-a32a13609beaa797",
      "GlobalClusterArn": "arn:aws:rds::131439663349:global-cluster:test-global-db",
      "Status": "available",
      "Engine": "aurora-mysql",
      "EngineVersion": "5.7.mysql_aurora.2.11.2",
      "DatabaseName": "test-db",
      "StorageEncrypted": false,
      "DeletionProtection": false,
      "GlobalClusterMembers": [
        {
          "DBClusterArn": "arn:aws:rds:us-east-1:131439663349:cluster:test-primary-cluster",
          "Readers": [
            "arn:aws:rds:us-west-1:131439663349:cluster:test-secondary-cluster"
          ],
          "IsWriter": true
        },
        {
          "DBClusterArn": "arn:aws:rds:us-west-1:131439663349:cluster:test-secondary-cluster",
          "Readers": [],
          "IsWriter": false,
          "GlobalWriteForwardingStatus": "disabled"
        }
      ]
    }
  ],
}

@mayesca the recent PR is now available in 4.1.12.dev31 so you could give that a shot. It should cover your use case.
@kevho48  I am not sure the PR covers what you originally requested but I would need a sample code similar to what @mayesca provided to be able to proceed.

@kevho48 did you get a chance to review new moto build to see if it resolves your issue?

I had a look at the description as well, but I couldn't reproduce the problem. I created the two clusters in the console, and then the Global Database via the CLI. AWS displays the same behaviour:
The global database will have the primary cluster listed as a cluster member, but the secondary cluster is missing from the list.

So I'm just going to close this. Happy to reopen this if anyone can provide a reproducible script that showcases the issue.


Would be good to have a message at the end of the firmware upload.... Updated successful (if it's the case I didn't receive it...)

Would be good to have a message at the end of the firmware upload.... Updated successful (if it's the case I didn't receive it...)
Originally posted by @Patlepirate01 in https://github.com/pybricks/support/issues/55#issuecomment-645504130

We didn't add a message, but the progress indicator is moved to the button, so when the progress indicator goes away and no error messages pop up, we know that the flash was successful.

We didn't add a message, but the progress indicator is moved to the button, so when the progress indicator goes away and no error messages pop up, we know that the flash was successful.


unicode literals not work

Feature
In Python source code, specific Unicode code points can be written using the \u escape sequence, which is followed by four hex digits giving the code point. The \U escape sequence is similar but expects eight hex digits, not four.
cpython
Python 3.7.3 (default, Mar 26 2019, 21:43:19)
[GCC 8.2.1 20181127] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> "\u0037"
'7'
>>> "\xac"
'¬'

RustPython
Welcome to the magnificent Rust Python 0.0.1 interpreter 😱 🖖
>>>>> "\u0037"
'\\u0037'
>>>>> "\xac"
'\\xac'

Python Documentation
https://docs.python.org/3/howto/unicode.html#unicode-literals-in-python-source-code

This is a lexer issue. I think the lexer only takes ascii into account at this point for strings, or it does not replace escape code properly.

May I implement this feature?  It is essential if I want to implement some the test for str.isprintable #1024

Sure! Give it your best shot :)

Hi, I don't really know how RustPython works, but unicode literals are tricky to get right (if your goal is to be fully compatible with CPython).
CPython supports unpaired surrogate code points in unicode literals, which are invalid UTF-8.
In the toy rust interpreter I wrote a while ago, I use the wtf8 crate to store this ill-formed UTF-8: https://github.com/ProgVal/rust-python-parser/commit/cd6159b70a546a0f4780a295d74c27e640319765
See also: https://simonsapin.github.io/wtf-8/
Have fun! :)

This is a lexer issue. I think the lexer only takes ascii into account at this point for strings, or it does not replace escape code properly.

True, note that other types of escaping like \x are not implemented.

@ProgVal  Thank you,  I almost there.


fix HTML semantics & styling

use header for the header
use div instead of span for .cc-message, which are flex items; should be block, not inline
use button instead of a[role="button"] for links without href
remove role="button" for links with href

I don't know if the <header> tag is semantically correct in this instance. I'm happy to be shown wrong though.
Also, I think this could be a breaking change for anybody currently using our plugin with an old doctype. E.G. The HTML 4.01 strict doctype <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">. Seeing as we never specified HTML5 in the docs.
Also, I don't think it matters if it's a div or a span, as either way, they are both set to flex. Meaning that neither of them are inline or block. So I think that's a non issue.
I like the <a> to <button> change, but I think such a change could also break any existing styles people may have and I'd rather not risk it, seeing as there is no real need to. Seeing as they have role="button", meaning every semantic analyser in the world will know exactly what it is supposed to be.
I think the aria labels make the HTML semantic enough for accessibility etc. Thanks for the contribution though!!

I understand not using header in case anyone is using HTML 4 strict, but I thought it would be a slight improvement from the ambiguous span. You can take it or leave it. (Although, if you leave it, I would suggest at least using p instead of span.)
Since the .cc-message elements are displayed as a block (every flex item is displayed as a block), I proposed the span -> div change because div would deviate less from browser defaults. By default, almost all browsers already display divs as blocks anyway, so it’s less likely to break people’s styles. For example, on my sites I have a CSS reset sheet that includes span { line-height: 0 } (along with other inline elements) to correct some issues of inline elements breaking vertical rhythm. This stylesheet assumes all spans are displayed inline. If any spans are changed to a block, an additional line-height: inherit; is needed. If you would like to cherry-pick this change, I could submit a separate pull request.
Lastly, I disagree with the “no real need to” change the a to button. Semantically, a button is the correct element to use, since it does something and doesn’t go anywhere. A link provides a promise to the user: that the user could bookmark its reference, open it in a new window, etc. None of which you can do with a button. Google "buttons vs links" for more rationale. Furthermore, the First Rule of ARIA Use states that if you can use a native HTML element, you should. Relying on browser default behavior is not only more user-friendly but also makes your life easier and requires less code.

Interesting response, I'd need time to consider this. Thanks


luci-app-opkg: add warning about upgrading packages

A proposal for a fix for #6413
It is a well-known fact that opkg doesn't check ABI-compatibility between dependencies and upgrading packages in a stable release is therefore not recommended. This commit adds a warning which should help especially new users find more information on why this is and avoiding soft-bricking their device.
See https://openwrt.org/meta/infobox/upgrade_packages_warning for more info, which is the same link that is used in the second paragraph.
Tested on Chrome and Firefox, both desktop and mobile (Android). All CSS used is theme-compatible and should therefore look at least decent across different themes.
BootstrapLight:

BootstrapDark:

Material:

OpenWrt2020:

Not optimal if it causes a pop-up or a button that must be clicked away.

Luci has UI notification API that can be used like:
 ui.addNotification(null, E('p', 'Werning!'), 'error');

Maybe you can use it instead?

Having a pop-up show up every time you navigate to the updates tab will most likely be very annoying to the user.

Please also add warning banners that installing packages and removing packages can cause soft bricks or break access to the ui.

Shall we add more banners and warnings that using openwrt will also
potentially soft brick their devices? 😉
Please also add warning banners that installing packages and removing

packages can cause soft bricks or break access to the ui.

I've updated the PR title, commit message, and screenshots to reflect the suggestion by @jow-

@stokito @systemcrash @jow- is there any other changes we want or does it make sense to start thinking of merging it?

Is it possible to reduce the warning text to a concise nugget? That page is now exploding with lines, colours and text and this does not make it easier to handle.  How about:
Warning! Package operations can break your system.')),
				E('p', _('Read this.').format(

Is it possible to reduce the warning text to a concise nugget? That page is now exploding with lines, colours and text and this does not make it easier to handle. How about:
Warning! Package operations can break your system.')),
				E('p', _('Read this.').format(

Absolutely, I like that idea.

And now... to acknowledge this big warning dialogue.
@yurtpage suggested

Luci has UI notification API that can be used like:
 ui.addNotification(null, E('p', 'Werning!'), 'error');

Maybe you can use it instead?

But maybe something more resilient. Like an 'acknowledge' button, that when clicked, stores a boolean flag in the config that determines whether the warning is shown at page load. We've done our diligence, the user can hide the warning.
What do you think @dannil ?

And now... to acknowledge this big warning dialogue.
@yurtpage suggested

Luci has UI notification API that can be used like:
 ui.addNotification(null, E('p', 'Werning!'), 'error');

Maybe you can use it instead?

But maybe something more resilient. Like an 'acknowledge' button, that when clicked, stores a boolean flag in the config that determines whether the warning is shown at page load. We've done our diligence, the user can hide the warning.
What do you think @dannil ?

Yes, I've actually thought about that too. I think we could do something akin to how the "Confirm" button behaves in warning dialogs (such as when you don't have a password set on your root user), here's an example from nftables:

Do we think it would be necessary to have a checkbox somewhere else (like under the "Configure opkg..." dialog) that would enable users to show the warning again? I personally think it shouldn't be needed.

I believe a nicer way would be: Warning: package operations can break your system (more information). and link the wiki article from more information?
If not, is it possible to move the Read this text to the line before and avoid the line break?

Honestly I think it would be better to make same introduction paragraph as other pages have:

Install additional software and upgrade existing packages with opkg..

Warning! Package operations can break your system

I.e. the warning can be just a sentence in the introduction.
We may add more important notes e.g. about feeds and disk space usage.
Given that this UI messages are more likely to be translated than a Wiki page it will improve cautious of users. That's why we need to add at least a few words that ABI may broken and that core modules shouldn't be updated at all. Yes, wiki explains this better but who reads it?
BTW the article in Wiki is in inbox e.g. in "draft" state. On the wiki itself not so much of information about package management https://openwrt.org/docs/guide-user/additional-software/start

Honestly I think it would be better to make same introduction paragraph as other pages have:

Also good. Less intrusive yet ever present.

Honestly I think it would be better to make same introduction paragraph as other pages have:

Install additional software and upgrade existing packages with opkg..

Warning! Package operations can break your system

I.e. the warning can be just a sentence in the introduction.
We may add more important notes e.g. about feeds and disk space usage. Given that this UI messages are more likely to be translated than a Wiki page it will improve cautious of users. That's why we need to add at least a few words that ABI may broken and that core modules shouldn't be updated at all. Yes, wiki explains this better but who reads it?
BTW the article in Wiki is in inbox e.g. in "draft" state. On the wiki itself not so much of information about package management https://openwrt.org/docs/guide-user/additional-software/start

I like this as well, especially the less intrusive part. Also, I've had trouble to implement a UCI config for opkg (since the package itself doesn't define this I need to do some hacky solution with creating the file from the LuCI app, which I don't like) which can entirely be avoided with the above suggestion.
I'll implement this solution in the following days since it's both much less intrusive and way easier technically to implement since we don't need the while "Hide" logic.

Merged. Thanks @dannil !


feature: import some utils from common_lib to allianceutils

Also CI failing on pre-3.10. We'll need to update to make it compatible - a lot of the type annotations will have to change


Remove not necessary dependency from utbot-spring-sample

Description
Remove not necessary dependency from utbot-spring-sample
How to test
Automated tests
Standard pipeline
Self-check list

[x] I've set the proper labels for my PR (at least, for category and component).
[x] PR title and description are clear and intelligible.
[x] I've added enough comments to my code, particularly in hard-to-understand areas.
[x] The functionality I've repaired, changed or added is covered with automated tests.
[ ] Manual tests have been provided optionally.
[x] The documentation for the functionality I've been working on is up-to-date.

LGTM. Will save memory and reduce directory artefact size.


0.5.0 Coding Conventions

[ ] JSHint configuration to enforce more restrictions
[x] Replacing Tab indentations with 2 spaces indent ( @ilanbiala @simison @codydaig  )
[ ] Code Documentation (jsdoc/ngdoc/whatever you suggest) + every PR will be accompanied with another gh-pages PR to update the project documentation when relevant. ( @codydaig @ilanbiala @simison )

I'd love to see one massive tabs => spaces change right after 0.4.0. Would make it easier later to track 0.5.0 changes.
Tabs/spaces seems to be a very common issue with PLs.

+1 on that. 2 spaces or the tab equivalent is best.

Otherwise this is total bikesheddig but I think this nails it:

Spaces look the same everywhere. Tabs don't.

By documentation do you mean documenting coding conventions or adding jsdoc (or even ngdoc)?

Seems like there's no discussion required on the indentation type (thank god!) - we'll go with 2 spaces indent like the rest of the world (I'll update the item there)
I mean both code documentation as well as general documentation. Code docblock is self-explained. General documentation means that if we merge a PR that makes some change to how things work then it should be accompanied by another gh-pages PR that updated the documentation accordingly. Otherwise we get a big pile of technical debt in documentation.

+1 on docs required to merge a PR as well.

+1 on changed requiring an updates docs PR
+1 on spaces instead of tabs!

+1 docs update requirement. A CONTRIBUTING.md file would come handy. It would briefly explain all this and appear as a link on top the form when adding new issues/PL's. See our page for an example.

@simison I've been wanting to add that CONTIRBUTING.md page for the past 2 weeks but haven't yet gotten to it, so you're welcome to PR it. Generally we need it as a documentation page on gh-pages as well as an actual file.
Most importantly is what the contents of it will be and the guidelines there still need to be worked out. I have more than few already noted down but I'll close that list and we can definitely start with something..

#690 i created an initial CONTRIBUTING.md file thats open for discussion!
@lirantal @simison @ilanbiala

Yep, thanks.
I need to review it first and wanted to add some items to it too, we'll take it in the PR.

Should there be a space between the keyword 'function' and the parameter list ?
I'm seeing some minor inconsistencies. Not a big deal, but it makes merging slightly more complicated when one use "auto-indentation" with his/her favorite code editor.
Random code examples without the space:

https://github.com/meanjs/mean/blob/a66c3fe5a7bf47acfa7a3748a5ca8fe143b58221/gulpfile.js#L178
https://github.com/meanjs/mean/blob/a66c3fe5a7bf47acfa7a3748a5ca8fe143b58221/modules/core/tests/client/menus.client.service.tests.js#L4

Random code examples  with the space:

https://github.com/meanjs/mean/blob/a66c3fe5a7bf47acfa7a3748a5ca8fe143b58221/gulpfile.js#L117
https://github.com/meanjs/mean/blob/a66c3fe5a7bf47acfa7a3748a5ca8fe143b58221/modules/articles/client/controllers/articles.client.controller.js#L9

For reference, the angular team seems to use the "no-space" option, see for example:

https://github.com/angular/angular/blob/7140c9cc341e477843423eeaebe264fe588338f4/tools/check-environment.js#L7
https://github.com/angular/angular.js/blob/master/src/ngRoute/route.js#L236

While the npm team seems to use a space, see for example:

https://github.com/npm/npm/blob/90ac6dc6eebde8cc4de14f194bb69d7d212913a0/lib/cache.js#L161
https://github.com/npm/npm/blob/90ac6dc6eebde8cc4de14f194bb69d7d212913a0/lib/utils/git.js#L19

@vaucouleur Personally, I like to have the space in these cases. It makes it easier for me to read. I agree that one way or the other must be used to avoid painful merges.
Perhaps, the settings in the editorconfig can be decided upon. Not sure if what is there, was previously decided. This file was recently updated to use spaces for indentation.
https://github.com/meanjs/mean/blob/0.4.0/.editorconfig

+1 with @mleanos, I too also prefer to have spaces for function arguments.

Didn't we take care of the tabs -> spaces? The JSHint stuff is currently being discussed in another issue. @lirantal @codydaig @mleanos I think what we should look at is moving the gh-pages branch to a separate repo and setting up a good system for every documentation with PR.

@ilanbiala I'm all for moving the gh-pages to a new repo. It's difficult for me to manage switching back & forth between those branches; part of the reason why I've steered clear of the documentation contributions thus far (and that I'm on Windows). I think we can coordinate documentation syncing with PR's with this repo
I think we did figure out the spaces/tabs issue. If not, then we should definitely address it in the other issue that's being discussed right now.

@ilanbiala That's what I've advocated before!!
Spaces have been addressed. We moved from 4 spaces too 2.

@lirantal if you're not opposed, I think @codydaig might want (?) to take up creating a new repo for the docs and moving them there.

@ilanbiala I'm down!

@lirantal @codydaig I think this issue has been taken care of as far as we can right now, and we'll open new issues as we think of new stuff? Close?

Close

indeed, thanks guys.


ZSTD compression problematic

When exporting embeddings to parquet files we currently use ZSTD compression:
https://github.com/Clay-foundation/model/blob/3f4210ff3160240e73c4d3541962032afef957db/src/model_clay.py#L1002
However, ZSTD compression is not widely supported. Specifically, the version of pyarrow packaged in the AWS SDK for Pandas is not built with support for ZSTD, which yields the following error:
type(err)=<class 'pyarrow.lib.ArrowNotImplementedError'>:
err=ArrowNotImplementedError("Support for codec 'zstd' not built")

This is proving problematic for the Clay vector service at read time.
GeoPandas docs for GeoDataFrame.to_parquet state that the following compression algorithms are available:
compression {‘snappy’, ‘gzip’, ‘brotli’, None}, default ‘snappy’
  Name of the compression to use. Use None for no compression.

@yellowcap - I'd like to request that we switch to a more widely supported compression, such as the default snappy or gzip, in order to facilitate reading/working with Clay embeddings for a wider audience such as those using the AWS SDK for Pandas like the Clay vector service 🤓
Please let me know if you have any questions. Thanks!

Linking to AWS SDK for pandas for reference.
Running into problems importing geopandas directly as a dependency in requirements.txt due to package size limitations imposed on lambda functions:
UPDATE_FAILED: ReadParquetLambdaFunction (AWS::Lambda::Function)
Resource handler returned message: "Unzipped size must be smaller than 86233173 bytes (Service: Lambda, Status Code: 400, Request ID: 5f9f750b-f8fb-4c61-bfc7-02ecb4ba3a22)" (RequestToken: 05ca5f53-f912-68a3-75ab-07ef6d06a3c1, HandlerErrorCode: InvalidRequest)

hence hoping to leverage a pre-built lambda layer. Exploring alternatives...

For context, ZSTD compression was set in https://github.com/Clay-foundation/model/pull/86#discussion_r1423394603, because it results in slightly smaller file sizes and faster read speeds (decompression). Also, please report the version of aws-sdk-pandas that you are using, is it 3.5.2 or an older version? What version of pandas is it running (show using pd.show_versions())?

Running into problems importing geopandas directly as a dependency in requirements.txt due to package size limitations imposed on lambda functions:

What's the limit for AWS Lambda? The PyArrow library used to read Parquet files is known to be quite big (see Drawbacks section under https://pandas.pydata.org/pdeps/0010-required-pyarrow-dependency.html, which mentions PyArrow requiring 120MB, and explicitly calls out this as a potential issue for AWS Lambda). The situation won't improve longer term though, especially for newer versions of Pandas v2.2+, so you might need to look at non-Lambda options if sticking with Pandas+PyArrow.
 Are you trying to ingest the GeoParquet files into some database?

@weiji14 yes, correct. That is the architecture that was proposed here:
https://github.com/Clay-foundation/vector/discussions/3#discussioncomment-7826219
It's unfortunate that the library to simply read a file format should be so large (seems unnecessarily so) though I can appreciate the desire to work with libraries and formats commonly used for data science in interactive notebooks, etc.
I am using the latest version of the AWS SDK for pandas, 3.5.2, via the us-east-1 lamda layer arn for python 3.9 found here:
https://aws-sdk-pandas.readthedocs.io/en/stable/layers.html
arn:aws:lambda:us-east-1:336392948345:layer:AWSSDKPandas-Python39:15
Note: I am able to open parquet files with that version of the library so long as the files have been encoded with compression types
I created a handful of test cases here for the purposes of verifying which compression algorithms are supported:
s3://clay-vector-embeddings/test-cases/compression/
I took one of the v01 embeddings we originally generated with zstd compression and used the gpq command line tool to re-encode it as brotli, gzip, snappy. You can see the results of attempting to call read_parquet on each test case here:

brotli (unsupported) ❌
gzip (supported) ✅
snappy (supported) ✅
zstd (unsupported) ❌

(upon successful read it is rendering the head of the dataframe as HTML for demo purposes).
@weiji14 can you tell me more / point me to more info on the binary encoding format the model is using to encode the geometry field? not sure how to decode that at the moment. thanks!

Yeah, I have been looking at other implementations as well. Geopandas itself is too large to import directly or via a lambda layer. I'll check out that rust based impl with the python bindings, thanks.

Closing as out of date, feel free to re open if appropriate.


Support for maximum number of visible items

Using vaadin-menu-bar I often find me in the situation where I'd like to have a couple of items visible and the rest in the overflow button; something like:
<vaadin-menu-bar max-items="3">

<vaadin-menu-bar max-items="1">

Setting the width CSS property on the menu bar and calling notifyResize() (when doing it dynamically from JS) allows to achieve the desired effect. Would that work for you?

It's the workaround I'm using, but I need to know an approximate width of the items which can depend on the language. I understand I could use a ResizeObserver for each item and then set the width when it changes, but that would be a pain to do e.g. in Flow 🙂

Thanks for your input. Marked as enhancement but we will have to discuss this with a team.
The change should be quite small, but we might postpone it due to other priorities.


Scan after using Scopes function panicks if *gorm.DB object is used for fetching other data.

GORM Playground Link
https://github.com/go-gorm/playground/pull/577
Description
We currently use the Scopes function, admittedly to my dislike, for some common joins or preparing long raw queries. The way we do it, is we first fetch some account attributes and then use them to return a raw query:
func ScopeFunc(id string) func (*gorm.DB) *gorm.DB {
   return func (d *gorm.DB) *gorm.DB {
        someModel := Model{}
        d.Raw("...").Scan(&someModel).Error
        // check error
        ...
       return d.Raw(preparedQuery)
  }
}

With the older version, this worked but after upgrading to 1.24.5, this panics.
It might be useful to note that I noticed in finished_api.go line 512 inside the func (db *DB) Rows(*sql.Rows, error)   we have this block:
	rows, ok := tx.Statement.Dest.(*sql.Rows)   <-- here we get *sql.Row instead of *sql.Rows
	if !ok && tx.DryRun && tx.Error == nil {
		tx.Error = ErrDryRunModeUnsupported
	}

We're not dry run, ok is false so nil result is returned with a nil error cause downstream methods to pass the error check and dereference a pointer that is pointing to nil.

use Session to copy a db when calling finisher_api in Scopes.
I don't know why, but it's okay...
err = DB.Scopes(func(d *gorm.DB) *gorm.DB {
	a := Account{}
	if err := d.Session(&gorm.Session{}).Raw("select * from accounts limit 1").Scan(&a).Error; err != nil {
		return d
	}
	return d.Raw("select * from users limit 2")
}).Scan(&users).Error

@black-06 Yeah that definitely resolved the issue. My understand was that the chain API always takes a copy of the db instance. Though probably some pointers are used and those are just references.
My question is, should we always opt to use Session in similar situations or is this a bug that we should resolve in future.

When nested Scan is executed, the rows identifier will be deleted by mistake.
We may need to use an array to store the type of each query in the nested query.
https://github.com/go-gorm/gorm/blob/master/finisher_api.go#L512
https://github.com/go-gorm/gorm/blob/master/callbacks/row.go#L15

When nested Scan is executed, the rows identifier will be deleted by mistake. We may need to use an array to store the type of each query in the nested query.
https://github.com/go-gorm/gorm/blob/master/finisher_api.go#L512 https://github.com/go-gorm/gorm/blob/master/callbacks/row.go#L15

Fix it in #6143 , but I found another problem.
OK:
var user User
if err := DB.Scopes(func(db *gorm.DB) *gorm.DB {
	var maxID int64
	if err := db.Raw("select max(id) from users").Scan(&maxID).Error; err != nil {
		return db
	}
	return db.Raw("select * from users where id = ?", maxID)
}).Scan(&user).Error; err != nil {
	t.Errorf("failed to find user, got err: %v", err)
}

Wrong:
if err := DB.Scopes(func(db *gorm.DB) *gorm.DB {
	var maxID int64
	if err := db.Model(&User{}).Select("max(id)").Scan(&maxID).Error; err != nil {
		return db
	}
	return db.Where("id = ?", maxID)
}).Scan(&user).Error; err != nil {
	// failed to find user, got err: sql: Scan error on column index 0, name "max(id)":
	// unsupported Scan, storing driver.Value type int64 into type *tests.User
	t.Errorf("failed to find user, got err: %v", err)
}

Because Selects  are not cleaned up in callbacks Execute.
Is this a bug? Or should we not have a nested Scan?

Because Selects are not cleaned up in callbacks Execute.
Is this a bug? Or should we not have a nested Scan?

This is ok for me, because we don't promise to reuse. We just need to ensure that its behavior is consistent inside and outside the Scope.
https://gorm.io/docs/method_chaining.html#content-inner


Hope team to fix compile error error: 'triton_gpu.cmpf' op requires the same encoding for all operands and results in the tutorial file 06-fused-attention.py

Hi team!
When I use the newest version of triton v2.1.0 to compile and run the tutorial 06-fused-attention.py, I find the compile error as follows:
loc(callsite(callsite("path/to/anaconda_env/lib/python3.8/site-packages/triton/language/core.py":1398:21 at "06-fused-attention.py":52:35) at "06-fused-attention.py":168:67)): error: 'triton_gpu.cmpf' op requires the same encoding for all operands and results
Traceback (most recent call last):
  File "06-fused-attention.py", line 552, in <module>
    tri_out = attention(q, k, v, causal, sm_scale).half()
  File "06-fused-attention.py", line 459, in forward
    _attn_fwd[grid](
  File "<string>", line 63, in _attn_fwd
  File "path/to/anaconda_env/lib/python3.8/site-packages/triton/compiler/compiler.py", line 476, in compile
    next_module = compile_kernel(module)
  File "path/to/anaconda_env/lib/python3.8/site-packages/triton/compiler/compiler.py", line 383, in <lambda>
    lambda src: optimize_ttgir(ttir_to_ttgir(src, num_warps), num_stages, arch))
  File "path/to/anaconda_env/lib/python3.8/site-packages/triton/compiler/compiler.py", line 91, in optimize_ttgir
    pm.run(mod)
RuntimeError: PassManager::run failed

the source code of the error is the 7th line like below:
1. if STAGE == 2:
2.     mask = offs_m[:, None] >= (start_n + offs_n[None, :])
3.     qk = qk * qk_scale + tl.where(mask, 0, -1.0e6)
4.     m_ij = tl.maximum(m_i, tl.max(qk, 1))
5.     qk -= m_ij[:, None]
6. else:
7.     m_ij = tl.maximum(m_i, tl.max(qk, 1) * qk_scale)
8.     qk = qk * qk_scale - m_ij[:, None]

and if I change the 7th and 8th line to the equal form, the compile error will not appear
1. if STAGE == 2:
2.     mask = offs_m[:, None] >= (start_n + offs_n[None, :])
3.     qk = qk * qk_scale + tl.where(mask, 0, -1.0e6)
4.     m_ij = tl.maximum(m_i, tl.max(qk, 1))
5.     qk -= m_ij[:, None]
6. else:
7.     qk = qk * qk_scale
8.     m_ij = tl.maximum(m_i, tl.max(qk, 1) * qk_scale)
9.     qk = qk - m_ij[:, None]

So I think this might be a mistake made by the compiler when determining the data type.
By the way, I would like to ask, could you provide some debugging tutorials? For example, how to print data types and other key information. Currently, there is very little information on debugging available online, and I feel a bit lost when trying to address the above-mentioned issues.
Thank you!

this looks like an old bug, please nightly build or building from source with top of tree

this looks like an old bug, please use nightly build or building from source with top of tree

Ok! Thanks!

@ThomasRaoux Hi, when I try to use triton-nightly, I met [CUDA]: device kernel image is invalid.
Can I use the (nightly) version or install triton from source with cuda < 12, say 11.7/11.8?

@ThomasRaoux Hi, when I try to use triton-nightly, I met [CUDA]: device kernel image is invalid. Can I use the (nightly) version or install triton from source with cuda < 12, say 11.7/11.8?

No unfortunately we now have dependencies to cuda 12 so you would need to update your cuda version


Dockerfile: optimize dpkg

docker image no longer contains the .deb file.

Hi @desaintmartin ,
Thanks for your contribution. I updated the Dockerfile to 2.10.0 and merged into master branch.
Regards,
William Ivanski


Fix for updation in MainActivity.js

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request:

Unless you are a React Native release maintainer and cherry-picking an existing commit into a current release, ensure your pull request is targeting the master React Native branch.

Explain the motivation for making this change. What existing problem does the pull request solve?
Prefer small pull requests. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.
Test plan (required)
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.
Make sure tests pass on both Travis and Circle CI.
Code formatting
Look around. Match the style of the rest of the codebase. See also the simple style guide.
For more info, see the "Pull Requests" section of our "Contributing" guidelines.

It looks like your description is missing some necessary information. Can you please add all the details specified in the template? This is necessary to understand why you're making this change.
I am going to close this, but feel free to open a new pull request with the additional information provided. Thanks!


BUG/TST: Improved Compatibility with pysat and Travis CI

Addresses #16.  Numerous updates, including

Updates to pysat syntax compatible with version 2.0.0
Update to Travis CI xenial environment

Added tests for python 3.7
Use of no_sgp4 branch of pysat to streamline

Updates to f2py usage in setup
Fix links in documentation to new pysat organization
Spelling and Whitespace

Updates to f2py were based on apexpy during debugging.  Potentially, these are not needed.

The no_sgp4 is a temporary fix.  We should chat at the next meeting.  I think I have this on the agenda, but I'll double-check.  We could add a function with the old name (season_date_range) that points to the new name (create_date_range) with a deprecation warning to maintain compatibility for now.


feat: Implement support for [data_blobs]/Data modules for service-workers

Turns out we do actually have internal support for binding a data_blob to a service worker. We should leverage it and add data_blobs/Data module support for service-workers.

I don't think this is critical for 2.0 (since no one uses it at all anyway), but would be nice to have to round out the module system support. Added it to the 2.0 milestone anyway.

And of course, we should also add support in miniflare for this.

Filed https://github.com/cloudflare/miniflare/issues/231 with an implementation PR https://github.com/cloudflare/miniflare/issues/231 for miniflare

Pending https://github.com/cloudflare/wrangler2/issues/416#issuecomment-1086751204


How do you actually delete an image? [I have a solution]

I see that many people are having issues with deleting images, especially in Rails (I am using Rails as well). There is a way to get around it.

In the doc titled Server Response, the author asks us to pass the url of the created image, you can
also pass the image's id so the response will look like

{ files: [ { id: 17, url: 'image_url' } ] }

Then, in the uploadCompleted callback, you can get the image's id and set deleteScript

uploadCompleted: function($el, data) {
    var imageId = data.result.files[0].id;
    this.deleteScript = 'api/v1/images/' + imageId; // NOTE: this is my API endpoint to destroy an image
}

Finally, I checked the codebase and I see that the deleteMethod option is never used.
When you remove an image, it runs this method.

Images.prototype.deleteFile = function (file) {
    if (this.options.deleteScript) {
        $.post(this.options.deleteScript, { file: file });
    }
};

It is always sending a POST request. I think it should send a DELETE request (It's not
like we have to send any data anymore, we now have the image's id in the path).
So the ideal scenario would be a DELETE request to api/v1/images/17. However,
to work around this situation, you can just send a POST request to api/v1/images/17. Your
image is now destroyed.
I hope this is useful. Thank you.

However, after you refresh the page the deleteScript will be gone...I am still figuring out if there's a way to keep the deleteScript after refresh.

Argh sorry, something is wrong with this solution. I need to rethink before posting anything.

For the very least, we can assign a data attribute like data-image-id to $el in uploadCompleted, and maybe we can run a cron job to remove unreferenced images in the server.


ValueError: operands could not be broadcast together with remapped shapes [original->remapped]: (2,2)  and requested shape (3,2)

I followed the tutorial to run this library. I tried various Python versions, including Python 3.11, and tested some models (for example, this one).
However, I still receive this error:
ValueError: operands could not be broadcast together with remapped shapes [original->remapped]: (2,2) and requested shape (3,2)
Any help or suggestions would be appreciated. Thank you!

I run into same error, although I am using cuda. It looks like the version of rmvpe model pulled from HF is not compatible somehow. My Copilot explained the error as following, but it is not helpful for me to fix the problem. Maybe, someone could identify the proper version of rmvpe to avoide the error:
The error message is indicating that there is a shape mismatch when trying to broadcast the pad_width to the shape of the salience array in the np.pad function. The np.pad function is trying to pad the salience array with 4 elements on both sides, but it seems like the shape of the salience array is not compatible with the padding operation.
The error is happening in the to_local_average_cents method of the rmvpe class in the inferrvc package. This method is called by the decode method of the same class, which is in turn called by the infer_from_audio method.
Without knowing the exact shapes of the salience array and the pad_width, it's hard to say exactly what the issue is. However, it's possible that the salience array does not have the expected number of dimensions or the dimensions are not of the expected size.
To fix this issue, you may need to check the shape of the salience array before it's passed to the np.pad function and make sure it's compatible with the padding operation. If the salience array is not of the expected shape, you may need to reshape it or adjust the pad_width accordingly.

Hi!
I fixed the error by exporting my audio track as mono. When the audio is input as stereo it gets an additional dimension to the data, hence the shape (2, x, y) where 2 represents stereo.


changed from ssf to frsca

Signed-off-by: pxp928<EMAIL_ADDRESS>Change from SSF to FRSCA based on community meeting

Testing passed. Closing PR


Add table entries for fips 186-5 related to RSA auxiliary probable

primes.

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

@t-j-h I am not sure we should be doing this.

This pull request is ready to merge

Merged.


Unable to install dependent charts for stackstorm helm chart

Installed helm chart however its not success.
helm install stackstorm-k8s-ha .\stackstorm-ha-0.110.0.tgz --namespace=myspace
Depended pods are failing to install due these pods are non-root and hence doesn't have access to directories.
example mongodb pod status:
CrashLoopBackOff: back-off 5m0s restarting failed container=mongodb pod=stackstorm-k8s-ha-mongodb-0_myspace(dfd854f4-05ac-4ce7-be9e-1694f3ac7fb0)
pod logs:
Advertised Hostname: stackstorm-k8s-ha-mongodb-0.stackstorm-k8s-ha-mongodb-headless.myspace.svc.cluster.local
Pod name matches initial primary pod name, configuring node as a primary
mongodb 14:55:30.95
mongodb 14:55:31.00 Welcome to the Bitnami mongodb container
mongodb 14:55:31.00 Subscribe to project updates by watching https://github.com/bitnami/containers
mongodb 14:55:31.00 Submit issues and feature requests at https://github.com/bitnami/containers/issues
mongodb 14:55:31.01
mongodb 14:55:31.01 INFO  ==> ** Starting MongoDB setup **
mongodb 14:55:31.03 INFO  ==> Validating settings in MONGODB_* env vars...
mkdir: cannot create directory '/bitnami/mongodb': Permission denied
Anyone able to fix this issue, can someone help me how to proceed with this and what changes are needed in charts.

Looks like a dependency chart has a reported ticket here. Have you found this to be helping?
https://github.com/bitnami/charts/issues/10354


GPU and DOCKER

That's @phlash 's gpu integration https://github.com/phlash/backscrub/tree/xnnpack-test
discussed in https://github.com/floe/backscrub/issues/79
Add Dockerfile and docker-compose.yml in order to quickly have everything ready to compile the project.
To try it out: Edit docker-compose.yml to set correct arguments and run docker-compose up
Add some more command line arguments
-G to enable GPU
-s to set FPS
-T to set threshold_probability, which was with FIXME comment.
But I didn't notice any change while going from 0.2 to 0.8. Bug?
Accidentally commited the starwars room background.

Having a Docker file doesn't relief you from documenting step-by-step how to setup a proper environment.
Also the GPU options should only be available with builds that enable GPU support. Having such flags available may be part of some compile option list, or may be shown as GPU: unavailable instead of the usual GPU: yes/GPU: no

@SamSpiri thanks for the enthusiasm, glad the GPU hackery worked at all! You might want to break this PR down a bit, there's a quite a lot going on:

Shift to CMake builds - we have a PR for that (#50), not sure where that is with avoiding dependency builds on every call, I simply started there and worked out how to turn on other features in a TfLite build.
Docker wrapper - might be better as a separate git repo that references backscrub as a sub-project. I'm not sure who would look after Docker stuff in this tree :question: so for now you are likely to retain ownership of this for yourself or others who want a Dockerised build.

Docker base image - you've picked Cuda/Nvidia, which is fine if that's what you've got, there will be AMD and possibly others..

backscrub code changes - as discussed in #79, and echoing @BenBE comments above, we haven't made any decision to include GPU acceleration in the main branch or to build with CMake yet. It's now proven to be possible, but we ought to consider user experience (eg: should there be a graceful fallback if GPU is not usable - right now it crashes out?), and any XNNPACK or GPU support relies on a CMake build which is not officially in yet (although I think this will be 'real soon now' :tm: )

Please be patient with us, as we've yet to arrange an IRL conversation to talk this stuff through :smile:

That PR is just a quick share of my progress so far.
I didn't mean to merge in with all that stuff. That's too much for one PR indeed.
I'd wait for the CMake merged in, and than we could base on it for further improvements like XNNPACK and GPU.
I also added background blurring to the mix (only locally yet). Got it from another pull request. And added option to use GPU for blurring. It actually opens the pandora box to do more stuff on gpu. Looking forward - also a mask blending on gpu would be cool.

@SamSpiri can this PR be closed? Now we have CMake builds, you should be in a position to submit various individual changes as suggested above...

closing due to inactivity


Fix c++ fused null default

No need to go through a temp is the node is literal.
Fixes #5554

Looks like this introduces major breakage in 3.0.1: #5643 #5644


[plugins] Integration test failures aren't captured (at least on iOS)

It appears that integration tests somehow regressed in our CI. Example (from https://api.cirrus-ci.com/v1/task/4990437185290240/logs/drive.log):
Running command: "flutter drive -d C2C157E2-4772-42D2-8CEB-8BE5483761D2 --driver test_driver/integration_test.dart --target integration_test/ios_platform_images_integration_test.dart" in /private/var/folders/tn/f_9sf1xx5t14qm_6f83q3b840000gn/T/cirrus-ci-build/packages/ios_platform_images/example
Running "flutter pub get" in example...                            636ms
Warning: Missing build name (CFBundleShortVersionString).
Warning: Missing build number (CFBundleVersion).
Running pod install...                                           1,123ms
Running Xcode build...
Xcode build done.                                           20.8s
flutter: 00:00 +0: load ios bundled image
flutter: file:///Users/admin/Library/Developer/CoreSimulator/Devices/C2C157E2-4772-42D2-8CEB-8BE5483761D2/data/Containers/Bundle/Application/92999D35-B5E6-4DF7-A37B-31E477B4868B/Runner.app/textfile
flutter: 00:01 +1: load ios system images
flutter: 00:01 +1: load ios bundled image
flutter: file:///Users/admin/Library/Developer/CoreSimulator/Devices/C2C157E2-4772-42D2-8CEB-8BE5483761D2/data/Containers/Bundle/Application/92999D35-B5E6-4DF7-A37B-31E477B4868B/Runner.app/textfile
flutter: 00:01 +2: ios system image error case
flutter: 00:01 +2: ios system image error case [E]
flutter:   Invalid argument(s): System image couldn't be found: invalid_symbol
flutter:
flutter: 00:01 +2 -1: (tearDownAll)
flutter: Warning: integration_test plugin was not detected.
flutter:
flutter: If you're running the tests with `flutter drive`, please make sure your tests
flutter: are in the `integration_test/` directory of your package and use
flutter: `flutter test $path_to_test` to run it instead.
flutter:
flutter: If you're running the tests with Android instrumentation or XCTest, this means
flutter: that you are not capturing test results properly! See the following link for
flutter: how to set up the integration_test plugin:
flutter:
flutter: https://flutter.dev/docs/testing/integration-tests#testing-on-firebase-test-lab
flutter:
flutter: 00:01 +3 -1: Some tests failed.
All tests passed.

I'm not sure why the integration test plugin wouldn't have been detected. @dnfield was the flutter test thing a breaking change? I thought flutter drive was supposed to keep working for now.

I can't repro this is a contrived example in a different package, so it seems like the scope is more restricted in some way (which is good news, since it means we aren't missing everything).

This is entirely a false alarm; it was a new test, which incorrectly used test rather than testWidgets, so its failure isn't reported out (per integration_test docs).
(I'll look into adding a check in our tooling that would catch this).


general: LESS_RUN_IN_DEBUG has effect only on first load

Steps to reproduce:

Setup an Invenio pu instance as described by INSTALL.rst, including the demosite.
Have the following additional settings in invenio.cfg:

    (invenio2)~/.virtualenvs/invenio2/var/invenio.base-instance$ cat invenio.cfg
    [...]
    COLLECT_STORAGE = u'flask.ext.collect.storage.link'
    DEBUG = True
    LESS_RUN_IN_DEBUG = False
    ASSETS_DEBUG = True
    DEBUG_TB_INTERCEPT_REDIRECTS = False
    TESTING = True

Run inveniomanage runserver and see that less.js is running:

Reload the page:

Now less.js isn't running anymore:

It should be noted that restarting the server "fixes" the problem for one more load.
It'd be helpful to have this running so that styles can be more easily debugged using source maps, as described for instance here: http://robdodson.me/debug-less-with-chrome-developer-tools/

Regarding the less.js not working.
What I notice is that the first time the page is loaded html source looks like:
<link rel="stylesheet/less" type="text/css" href="/less/user-menu.less"/>
<link rel="stylesheet/less" type="text/css" href="/less/sticky-footer.less"/>
<link rel="stylesheet/less" type="text/css" href="/less/zenodo.less"/>

but the second time:
<link rel="stylesheet" type="text/css" href="/less/user-menu.less"/>
<link rel="stylesheet" type="text/css" href="/less/sticky-footer.less"/>
<link rel="stylesheet" type="text/css" href="/less/zenodo.less"/>
<link rel="stylesheet" type="text/css" href="/css/accounts/login.css"/>

I think the lack of stylesheet/less is causing the problem here, but I'm not sure how to fix that now ;/

Even after fixing this I'm not sure if we'll be able to debug less files.
As described at the page you mentioned:

Important: If you use less.js to compile your LESS in the browser, the techniques we'll be covering will not work for you. Please see this ticket for more information.

Link to the ticket: https://code.google.com/p/chromium/issues/detail?id=285786

Regarding the less.js not working.
Thanks, I didn't notice this. I might investigate its cause, but it has lower priority due to your next observation.

Uh, I didn't notice that as well! Even the author of less.js suggests to fall back to server side compilation: https://github.com/less/less.js/issues/1541.

Well, this line looks suspicious. In fact, removing it fixes this bug, but I'm not sure if it's breaking something else. Will submit a PR.

Great! This change looks really promising ..


Update starknet-rs deps

Converted to draft for now, to ensure we don't break downstream users with new revs until new versions are available for updated deps.


Reduce thread usage

Summary

Remove extraneous sleep from ZookeeperWatcher thread
Use TimerSet to execute scheduled tasks. This primarily allows for multiplexing of threads in order to avoid having many "polling" threads which are primarily idle.
Remove on_expired_session handler for every Zookeeper(Poll)?Watcher and instead, only use one per ZK client (which is shared). This requires a slightly different callback, but works the same.

Note: I am not sure if this complexity is worth the gain. While this reduces the number of threads, the large portion of main memory usage comes from the additional dual-read watchers, which still exist. Perhaps just doing 1 is enough because it's simpler and less risky.
Testing

[x] CI
[x] Testing generated config in HAProxy

# haproxy.cfg contains the generated config from running on the `master` branch
# haproxy-refactored.cfg contains the generated config from this branch

$ egrep -o "server .* id" haproxy.cfg | sort > sorted-servers
$ egrep -o "server .* id" haproxy-refactored.cfg | sort > sorted-servers-refactored
$ diff -s sorted-servers sorted-servers-refactored
Files sorted-servers and sorted-servers-refactored are identical

[x] Threads are reduced. Purple is a "control" host running master, whereas the other two are running this branch of Synapse.

Misc
One clear benefit is that the CPU usage is reduced to somewhere between 33% and 50% of the original (again, purple is running master and other two are running this branch):

Reviewers
@austin-zhu @gmcatsf @Jason-Jian

LGTM, can we add a test to verify the behavior when on_session_expired is actually invoked? I do not seem to find one in current rspec.

I added those tests now @gmcatsf

There are conflicts with current master please resolve them to have a clean CI.


Authorized method always returns false

Inside the authorized? helper method, seems like @auth.provided? and @auth.basic? is not defined.

Ah okay, will fix it.


Proof of concept: Detect writing to non-reactive properties

This is very very early proof of concept right now. If a property in a data object is written to while it's not reactive, a warning is shown. This will later be used only in debug mode, but I haven't added a debug mode check yet. The code will be re-written cleanly once it's confirmed working.
Note: this uses no dirty checking and instead uses ES6 proxies, which is supported only on latest chrome and firefox.
Need help with this:

Pull my branch reactive-warn into your repo.
edit changewatch/index.html with updates
find false positives, etc. Things when it should show warnings but doesn't. Or other edge cases.

Example:

I like the idea - but one problem with proxies is that they become different references and would break cases where the user is doing equality comparisons...

Sigh :( you're right. i confirmed that reference equality isn't preserved.
On the bright side i did learn quite a bit about vue internals from this exercise. I really think this would be a great feature. I am currently out of ideas and am stashing this. Please do see if you can get a nice solution for this problem :)
Closing PR.


[stdlib] Fetching environment variables

Adding two functions:

System.lookupEnv which is a parallel of Haskell's System.Environment.lookupEnv
System.getEnv which is a parallel of Haskell's System.Environment.getEnv

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Miron Markowski seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

💯 Thank you for the PR @MajronMan! Please sign the CLA and we're good to merge :)


⚠ Bofrost.lu has degraded performance

In 295b7df, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1748 ms

Resolved: Bofrost.lu performance has improved in 2eb3c7d after 38 minutes.


Repair runtime problems with mergeddim acquisition

Prerequisites:

[x] Unless it is a documentation hotfix it should be merged against the dev branch
[x] Branch is up-to-date with the branch to be merged with, i.e. dev
[x] Build is successful
[x] Code is cleaned up and formatted

Summary

Switch to two quick joins when setting is_latest instead of one slow join
add merged_key_id indexes
fix bad syntax when logging exceptions
automatically call dbjobs after insert_batch

even better!


Price glitches - add a region selection (filter)?

Seems very circumstantial that you have to sort the list by region and then scroll through all pages until you find your own country flag (or not, as only few regions have price glitches).

Well never mind, you can close this if you want since the purpose is limited.


Invoking a nameless wren function from C

Looking at the call.c test I am struggling to understand how I would execute a Fn instance created from my script, from my C application.
I am doing something similar to the following:
ForeignClass.addCommand("invokeTest", Fn.new {
    ForeignClass.print("Invoked in script!")
})

In my foreign method bind function:
if(signature == "addCommand(_,_)") {
    return [](WrenVM *wrenVm) {
        std::string commandName = std::string(wrenGetSlotString(wrenVm, 1));
        WrenHandle *method = wrenGetSlotHandle(wrenVm, 2);
        std::cout << "Binding method " << commandName << std::endl;

        commands[commandName] = [&](std::vector<std::string> args) {
            std::cout << "HIT HIT HIT HIT" << std::endl;
            wrenCall(wrenVm, method);
        };
    };
}

When I later invoke commands["invokeTest"]({}); I see HIT HIT HIT HIT but then the application segfaults.
I can only see a way to invoke methods in a class or methods that have a name. Is what I'm trying to achieve possible?
I would love to see the API documentation updated with examples! <3

Your error comes that you don't get an handle to the method to invode in slot 2 but the function object.
if(signature == "addCommand(_,_)") {
    return [](WrenVM *wrenVm) {
        std::string commandName = std::string(wrenGetSlotString(wrenVm, 1));
       WrenHandle * fnObject = wrenGetSlotHandle(wrenVm, 2); // you get the object
        std::cout << "Binding method " << commandName << std::endl;

        commands[commandName] = [&](std::vector<std::string> args) {
            std::cout << "HIT HIT HIT HIT" << std::endl;
            WrenHandle * methodHandle = wrenMakeCallHandle(vm, "call()"); // get handle to the method "call"
            wrenEnsureSlots(wrenVm, 1);
            wrenSetSlotHandle(wrenVm, 0, fnObject); // the receiver of the method to be the function object you get as an argument
            wrenCall(wrenVm, methodHandle); // call the "call" method.
        };
    };
}

And you can simplify the addCommand call:
ForeignClass.addCommand("invokeTest") {
    ForeignClass.print("Invoked in script!")
}

does exactly the same thing. It's disturbing at first, but it removes some uglyness (IMO).

@minirop, @munificent, thanks for the help! Got it working correctly thanks to your explanations.


Firebase Storage Images cannot be Cached

Description
I have a xamarin ios project works with DLtoolkit which is used FFImageLoading, firebase storage images cannot not be cached. how can I solve it ?
link example : https://firebasestorage.googleapis.com/v0/b/rinohub.appspot.com/o/receipts%2Ftest%2F5b462211ae298b08f496f128.jpeg?alt=media&token=22a297e0-d71f-4184-9fbd-31c65958d740

Version with issue: <IP_ADDRESS>0
Platform: xamarin.forms

how is that related to this library? you have set your images non public.

I meant the images fetched from firabase was not cached and I found the solution , I put this code to App.cs after initializecomponent();  as described in issue #1083
var config = new FFImageLoading.Config.Configuration
            {
                TryToReadDiskCacheDurationFromHttpHeaders = false
            };
            ImageService.Instance.Initialize(config);

i am curious something why are you trying to cache with token=22a297e0-d71f-4184-9fbd-31c65958d740
I think that you can access it using without token also. is there any reason that you cache it with token?

it is because of that if authentiaction options is set for e-mail and password , you can not access the image without the token. firebase stores images with tokens. no any other option

"you can not access the image without the token. firebase stores images with tokens. no any other option".. this is not correct, you can access images without token if you set up. https://stackoverflow.com/questions/46153828/access-url-without-token-in-firebase-storage?rq=1
but I guess that your purpose is different. you want your images to be private i believe.

2 days to try to find a solution, but image from FireBase could not be cached... Event if with your solution...


Submission FTP Bug Patch (Issue #134)

Description
Please Describe the Bug(s) Fixed and/or the Feature(s) Added:

Made changes for the folders server side to be aligned during initial submission and update submission (no longer getting FTP error)
Changed the useMamba flag to false within nextflow.config (getting error where pandas cannot be found with mamba)

Checklist
Go Through Checklist Below and Place A :heavy_check_mark: (X Inside the Box) if Completed
General Checks

[X] Have you run appropriate tests (unit/integration/end-to-end) to check logic across run environments (Conda/Docker/Singularity on Scicomp/AWS/NF Tower/Local)?
For each relevant configuration:

Can the program run completely through without erroring out?
Does it produce the expected outputs, given the inputs provided?

[X] Have you conducted proper linting procedures?

Numpy formatted docstrings for functions
Comments explaining lines of code
Consistent and intuitive naming conventions for variables, functions, classes, methods, attributes, and scripts
Single empty line between class functions, two lines between non-class functions, and two lines between imports and code body
Camel case formatting for class names

[X] Have you updated existing documentation (README.md, etc.) or created new ones within docs?

CDC Checks

[X] Did you check for sensitive data, and remove any?
[X] If you added or modified HTML, did you check that it was 508 compliant?

Are additional approvals needed for this change? If so, please mention them below:
No.
Are there potential vulnerabilities or licensing issues with any new dependencies introduced? If so, please mention them below:
No.

tested using
nextflow run main.nf -profile test,singularity,virus --output_dir outdirs/sub_testing3 --run_repeatmasker_liftoff true -resume --submission_wait_time


Does attributes params have typechecks?

Hi, I tried HBox and it seems I can mistype params without any flow error, like that for example
<HBox justifyContent="space-between1">

Is this a bug, in what degree flowchecks are implemented currently?

Published as 2.0.1 — thanks for report!


[Question] How do I exclude coverage for files under all folders except src ?

Can you please help me exclude everything below in playwright ct coverage report except src ?
Those are fetched during execution.

{
  entryFilter: {
    "**/your-dist-file.js": true
  },
  sourceFilter: {
    "**/src/**": true
  }
}


Reduced performance between mods

I've done multiple tests and noticed a feature that this mod sometimes loads the game too much.
018da728-a335-76a2-ff47-5e92e1269e3c

By disabling your mod or Late_Game, everything got better. I checked everything on one side, inside the CullFactor configuration

I'm just wondering what's causing such a dramatic drop in productivity? These mods add a couple of things, monsters and some teleport mechanics. Maybe the problem is in the code itself, but it's not for me to judge. But help me figure this out :(
BepInEx-BepInExPack-5.4.2100
ShaosilGaming-GeneralImprovements-1.1.9
Rune580-LethalCompany_InputUtils-0.6.3
PotatoePet-AdvancedCompany-1.1.1
Zaggy1024-OpenBodyCams-1.1.5
Owen3H-IntroTweaks-1.4.5
Evaisa-H ookGenPatcher-0.0.5
Еваиса -LethalLib-0.14.2
Rolevote-The_Fiend-1.0.4
x753-Mimics-2.4.0
AmesBoys-ImmortalSnail-0.6.1
NomnomAB-RollingGiant-2.5.1
jaspercreations-Scopophobia-1.1.1
Ccode_lang-SirenHead-0.2.1
SolidStone- ShockwaveDroneEnemy-0.2.1
x753-Peepers-0.9.6
Mikusch-SkullEnemy-1.0.4
rileyzzz-Skibidi_Toilet-1.0.2
Rdos-LethalGym-1.0.1
VersusWorks-Dynamo_Flashlight-0.1.2
Jordo-NeedyCats-1.1.1
Taker-CannabisCompan й -1.0.3
AinaVT-YippeeScrap-1.0.7
Pinta-PintoBoy-1.0.4
ModusInteractive-Lethal_Trading_Cards-1.0.3
SillySquad-AmogusScrap-1.1.0
Theronguard-Emergency_Dice-1.1.13
Scintesto-Scavenger_Plushie-1.0.6
Scintesto-Monster_Plushies- 1.0.4
Zaggy1024-PathfindingLagFix-1.2.1
DOkge-InventoryFixPlugin-0.0.1
SillySquad-BetterTotalScrap-1.1.0
Sv_Matt-HideModList-1.0.1
Hamunii-JetpackFallFix-2.0.1
NutNutty-SellTracker-1.2.1
AlexCodesGames-Additional КонтентФреймворк-1.0 .3
AlexCodesGames-AdditionalSuits-2.0.0
BatTeam-LethalFashion-1.0.6
tinyhoot-ShipLoot-1.0.0
EliteMasterEric-Coroner-1.6.0
NotAtomicBomb-TerminalApi-1.5.1
Fivetoofive-DetailedScan-1.2.2
kRYstall9-FastSwitchPlayerViewInRadar-1.3. 2
Ozone-Runtime_Netcode_Patcher-0.2.5
Sligili-More_Emotes-1.3.3
TwinDimensionalProductions-CoilHeadStare-1.0.6
Hamunii-JetpackWarning-2.2.0
akechii-DiscountAlert-2.3.0
mrov-LethalRichPresence-0.5.8
willis81808-LethalSettings-1. 4.0
willis81808-HackPad-1.1.3
Evaisa-LethalThings-0.9.4
Malco-Lategame_Upgrades-3.1.1
ButteryStancakes-AccurateStaminaDisplay-2.0.0
Dev1A3-RecentlyPlayedWith-1.0.3
fumiko-CullFactory-0.8.2

Without any kind of logs, I can just guess the kind of issues it can happen to reduce performance:

Error crashing which is not handled til it's shown in the log, leading to stutters.
Functions are implemented with time complexity superior to O(n), leading to possibly exponential time dependant on input.

LGU does have some patches in enemies and players which could affect performance but the best we got is boombox and peeper iteration which only iterates if there's any instance of these objects.
You're absolutely sure that it is LGU that has performance issues and not LethalLib?

I'm just guessing, I was checking on the same side, and there was a slight decrease in performance. I need more information, but I don't have many testers, I check everything alone and make reports, you'll forgive me...


editorial pass https://thenewboston.com/guide/nodes

Stylistic updates re: https://thenewboston.com/guide/node


Clean up using std so it's not stomping namespaces

I think that master should now play namespace-nice. Sadly, I've done this by pulling in another patch, so I have to close yours. In any case, thank you!


Initialization should occur when creating contract

At the moment contract state is initialized through a request, but it should be done when the contract is instantiated. This also will ensure initialization cannot be called more than once for a given contract.

The current proposed approach is a middle ground:

Init calls cannot occur through sending a request, only through calling init in the execution engine
Init calls still are the application's responsibility, and it must ensure init is not called multiple times

This provides a still-functional API to the engine, while limiting the risk that users can trigger initialization by sending a request.


Avoid logging error while log-level is warn

Hi,
I need to send warning messages but not error messages to a Slack channel. How can/should I achieve this? I tried to send false in formatter (as suggested here: https://github.com/winstonjs/winston#filtering-info-objects) but it throws:
(node:11417) UnhandledPromiseRejectionWarning: Error: Request failed with status code 400

Thanks!

Hmm, that's interesting. I'll check to see if there's something that this module needs to do that I'm not doing. Sorry for the inconvenience!

I encountered the same casuistry, so I suggest a custom solution. The following functionalities have been added:

SlackHookOptions formatter can return false to filter out messages
SlackHookOptions formatter types updated
New test configuring SlackHook with a custom formatter that changes the output
New test configuring SlackHook with a custom formatter that filters out the message

Pull request: https://github.com/TheAppleFreak/winston-slack-webhook-transport/pull/14

@_@
Sorry about the delay! Merged #14, so this should be resolved now.


Badge not show when Set minimum point

I have set mininum point of badge to 2000 point (ex.) . When user completed the action till give more 2000 point in dashboard. user still can not claim the badge.

Hi @Joven-B,
The Digital Badge points limit only applies to the CMP points and not Tournament of Teams. You have to earn points in CMP from Leaderboard to be eligible for the badges which are not tied to a tournament and has points limit. If a digital badge is mapped to a Tournament then the user will have to complete that tournament to be eligible for the badge.
Please check the Digital Badge section in the wiki for more details and let us know if you need more information.
Thanks.

Hi @v-saikirang
My digital badge is mapped with point, I'm not sure anything was wrong of me.

Hi @Joven-B,
I see these badges are not mapped to any tournament. This means these points should be earned in CMP from leader board screen. The points in the tournaments will not apply here.


Update Role.php

In case you make this work for Laravel 5.1:
lists() does not return an Array on Laravel 5.1. It needs ->all() to do so.

Thanks for the heads up, I have this implemented and ready for the update to Laravel 5.1~


Support for React Native

Great work! My issue is far more feature request than bug. Would love to see this working with React Native.

+1

@JBerendes  @sagivo  did either of you getting this working with react web?

@JBerendes this library is not for react-web. for this i'll suggest using other tools like simpleRTC etc..

WontFix? Closing it for now.


KAFKA-14273: Kafka doesn't start with KRaft on Windows

Windows does not allow moving a file if a file descriptor is still opened.
Closing the FileOutputStream prior to moving the file fix the issue.

Merged https://github.com/apache/kafka/pull/14354 instead of this PR.


Use StandardCharsets.UTF_8 as default charset in oneway producer demo.

Same as #5132
https://github.com/apache/rocketmq/blob/develop/example/src/main/java/org/apache/rocketmq/example/simple/OnewayProducer.java

please assign it tovme

please assign it to me

please assign it to me

welcome.


Fixed typo in EventLoopFuture docs

"provably" becomes "probably"

This is not a typo. We want the word "provably": that is, you should only not call hop(to:) when you can prove that the hop is unnecessary.

This is not a typo. We want the word "provably": that is, you should only not call hop(to:) when you can prove that the hop is unnecessary.

My mistake! Not a word I've heard used before.
As you were! :)

My mistake! Not a word I've heard used before.
As you were! :)


CFP-34577: per-service load balancing algorithm selection

Discussion in Google Docs or https://github.com/cilium/cilium/issues/34577

cc @cilium/sig-lb

cc @kl52752

@kl52752 Note you can subscribe to issues and pull requests with the button on the side :point_down: :slightly_smiling_face:

LGTM, commented in the Google doc as well, I presume eventually this would need to be updated. From the G doc discussion, looks like we're all on the same page. Happy to help pushing this forward!

I understand that the CFP is now synced to the latest comments on the doc and should be about ready to merge, is that correct?
I added some minor comments below mostly just to line the proposal up with the latest template formats, but this seems like it should be good to merge.

yes the proposal is synced with the doc,
than you for your comments. I responded PTAL


Buffer thread local lifo

@normanmaurer, could such improvement be merged into the master branch ?

@bwzhang2011 should be merged to 4.0/4.1/master

Will be merged once ready

Am 01.04.2015 um 06:13 schrieb Trustin Lee<EMAIL_ADDRESS>@bwzhang2011 should be merged to 4.0/4.1/master
—
Reply to this email directly or view it on GitHub.

@trustin @Scottmitch so I can reproduce the improvement all the time with wrk but it seems like I'm not able to prove it via jmh. Not sure if maybe the cache are not populated by the correct Thread or something else. That said the improvements is there.
WDYT ?

Alsi @nmittler :)

Ready to review, then?

@trustin yes

Am 02.04.2015 um 04:05 schrieb Trustin Lee<EMAIL_ADDRESS>Ready to review, then?
—
Reply to this email directly or view it on GitHub.

I'm just not sure how much time I can burn here, or if I better remove the micro-benchmark and open an issue to track it and may add later one.

@normanmaurer - I agree that we don't want to burn too much time.  I would say sleep on it and if tomorrow nothing clicks then shelve it and open an issue.  I would be nice to be able to use our micro benching framework to demonstrate the improvements though.

@trustin please review again :)

@netkins build

Like I said I will remove the micro-benchmark for now and open another issue to maybe create one once I have an idea about how to write a proper one. Just have no time at the moment to spend days here.

@trustin ping :)

@netkins build

Cherry-picked into 4.0 (30f60ac68ad7e941197cfcf127291da3e11ed611) , 4.1 (3e42292d8b5c995a2a8342a91a2a3c1ec807628a) and master (5519bbcb95b99f9af47129376fe9ce6bf64d4a05)


🐛 [bug]: Can't pass -ignore flag

🐛 What happened?
In one of my workflows, I am using an action with dynamic outputs. Actionlint reports those (as they are not explicitly declared) with the error message
property "deprecated_tests_failure_pattern" is not defined in object type {conclusion: string; outcome: string; outputs: {string => string}} [expression]

I would like to ignore them. Locally, I use
 actionlint -ignore 'property ".+" is not defined in object type'

to achieve this. I tried passing the string to the "flags" input of your action, using
      - name: Run actionlint
        id: actionlint
        uses: raven-actions/actionlint@v1
        with:
          flags: '-ignore "property \".+\" is not defined in object type"'

but I am getting an error "could not read "type"": open type": no such file or directory"
I am no javascript expert, but I assume this is due to https://github.com/raven-actions/actionlint/blob/main/action.yml#L355 splitting the "flags" at every space, completely ignoring the quotes.
🔬 How to reproduce?
Use an action with dynamic output (e.g. https://github.com/joernott/load_testplan/tree/main) and run actionlint on it
🏗 Code Sample / Log
No response
🌌 Environment (actionlint action)
v1.0.2
🌌 Environment (actionlint)
1.6.26
🌌 Environment (GitHub Runner OS)
Linux
📷 Screenshots
No response
📈 Expected behavior
There should be a way to pass multiple ignore patterns to the action, e.g. with a dedicated "input" input.
📎 Additional context
No response
📜 Code of Conduct

[X] I agree to follow this project's Code of Conduct.

You could use the configuration file (.github/actionlint.yaml) instead: https://github.com/rhysd/actionlint/blob/main/docs/config.md#configuration-file

@joernott the new release 1.0.3 should handle it now :)
@bhundven good idea for the workaround :)


Install dependencies hangs

Describe the bug
I created an application and had two instructions "npm install" and "npm run dev". However, on issuing "npm install" the "Install dependencies" appears, no errors, but the application does not progress beyond the "install dependencies"
Link to the Bolt URL that caused the error
https://bolt.new/~/sb1-dydays
Steps to reproduce

npm install
npm run dev

Expected behavior
This is my first execution of the code so I'm not quite sure what is expected. I'm expecting the app to request and image to scan so that it can breakdown and identify individual objects in the the image.
Screen Recording / Screenshot

Platform
Browser name = Safari
Full version = 18.1
Major version = 18
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.1 Safari/605.1.15
performance.memory = undefined
Username = techwardbound
Chat ID = b17ce8709490

Additional context
No response

Found out more. I've done some additional attempts but the system continues to have problems. Install is not hanging anymore, though it does take a while to terminate. I've looked into the logs and it is failing at an attempt to connect to my environment.... I think:
@https://zp1v56uxy8rdx5ypatb0ockcb9tr6a-oci3-1k8l17eo.w-corp-staticblitz.com/blitz.d3acb9e1.js:40:22706
I've attached the log file.
The error appears at time 50 to 56:

50 verbose stack captureLargerStackTrace2@https://zp1v56uxy8rdx5ypatb0ockcb9tr6a-oci3-1k8l17eo.w-corp-staticblitz.com/builtins.ddb8d84d.js:101:5336
50 verbose stack NodeError@https://zp1v56uxy8rdx5ypatb0ockcb9tr6a-oci3-1k8l17eo.w-corp-staticblitz.com/builtins.ddb8d84d.js:101:4151
50 verbose stack ClientRequest@https://zp1v56uxy8rdx5ypatb0ockcb9tr6a-oci3-1k8l17eo.w-corp-staticblitz.com/builtins.ddb8d84d.js:3:2594
50 verbose stack construct@[native code]
50 verbose stack @
50 verbose stack Promise@[native code]
50 verbose stack _0x168309@https://zp1v56uxy8rdx5ypatb0ockcb9tr6a-oci3-1k8l17eo.w-corp-staticblitz.com/blitz.d3acb9e1.js:40:21354
50 verbose stack @
50 verbose stack h@
50 verbose stack @
50 verbose stack @
50 verbose stack @https://zp1v56uxy8rdx5ypatb0ockcb9tr6a-oci3-1k8l17eo.w-corp-staticblitz.com/blitz.d3acb9e1.js:40:22706
51 verbose cwd /home/project
52 verbose Linux 5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.1 Safari/605.1.15
53 verbose node v18.20.3
54 verbose npm  v10.2.3
55 error code ERR_INVALID_PROTOCOL
56 error Protocol "https:" not supported. Expected "http:"

2024-11-18T23_37_57_151Z-debug-0.log
Have I failed to install or configure something?

@techwardbound Bolt.new does not currently support Safari due to limitations in the browser that do not support WebContainers (the core technology that powers Bolt). We are adding a banner to indicate this soon, but in the meantime, please switch to Google Chrome or another Chromium based browser.
Tagging #176

Good to know,
I’ve wasted a whole bunch of tokens trying to get this to build under safari. Any chance of getting some back? Since I didn’t know this was the problem, I can’t really tell how many I’ve used. I only have 7 left now after upgrading to 20 two days ago.
George.

On Nov 20, 2024, at 9:54 AM, Alexander Berger @.***> wrote:
@techwardbound https://github.com/techwardbound Bolt.new does not currently support Safari due to limitations in the browser that do not support WebContainers (the core technology that powers Bolt). We are adding a banner to indicate this soon, but in the meantime, please switch to Google Chrome or another Chromium based browser.
Tagging #176 https://github.com/stackblitz/bolt.new/issues/176
—
Reply to this email directly, view it on GitHub https://github.com/stackblitz/bolt.new/issues/2628#issuecomment-2487002904, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATHLXXHZ5PGUQOFVMYRZFCT2BPFSDAVCNFSM6AAAAABR6USD2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBXGAYDEOJQGQ.
You are receiving this because you were mentioned.

As an update, switching to Chrome on my Mac has resolved the failure to install due to http/https protocol error.
Thank you. Now just need to resolve my other issues.


More blur radius

How can i have blur with more then 25 radius? having motion blur feature can be good!

Hey guys, the new version 0.2.0 has been released, and now you can resolve this issue by using the Modifier.cloudy modifier instead of the Cloudy composable function. You can set unlimited radius values now.


Rerun the songbird jupyter notebook with q2-2019.7-compatible vsns. of q2-types and songbird

(merged in PR addresses this)


Get a DenseVector when do a SparseVector / SparseVector

   val sparseVector1 = new BreezeSparseVector(Array(0, 1, 2), Array(1.0, 2.0, 3.0), 10)
   val sparseVector2 = BreezeSparseVector.fill(10)(2.0)
   val mul = sparseVector1 :* sparseVector2
   val divide = sparseVector1 :/ sparseVector2

   println(mul) // SparseVector((0,2.0), (1,4.0), (2,6.0))
   println(divide) // SparseVector((0,0.5), (1,1.0), (2,1.5), (3,0.0), (4,0.0), (5,0.0), (6,0.0), (7,0.0), (8,0.0), (9,0.0))

I'm honestly unlikely to make this change. All other SV/SV operators return
SVs, and SV /:/ SV is probably a bad idea anyway since you'll get a whole
bunch of NaNs. In your example, you should use a DV of course.
On Tue, May 10, 2016 at 7:50 PM, lionelfeng<EMAIL_ADDRESS>wrote:

val sparseVector1 = new BreezeSparseVector(Array(0, 1, 2), Array(1.0, 2.0, 3.0), 10)
val sparseVector2 = BreezeSparseVector.fill(10)(2.0)
val mul = sparseVector1 :* sparseVector2
val divide = sparseVector1 :/ sparseVector2
println(mul) // SparseVector((0,2.0), (1,4.0), (2,6.0))
println(divide) // SparseVector((0,0.5), (1,1.0), (2,1.5), (3,0.0), (4,0.0), (5,0.0), (6,0.0), (7,0.0), (8,0.0), (9,0.0))
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/scalanlp/breeze/issues/533

thanks, David. i should have used val sparseVector2 = DenseVector.fill(10)(2.0).


implement bloom filter for dseg

This should slightly reduce sync traffic for already synced nodes by effectively requesting only unknown nodes. Since we have 4-5K masternodes, this can save smth like 1-2MB, which is not that much comparing to all another additional data we sync i.e it's not a critical one and can be postponed for later. Proposing this for 12.2.
NOTE: DSEG_FILTER_VERSION should be bumped to match PROTOCOL_VERSION before merge

NOTE: postpone this till next protobump

Hey @UdjinM6, this seems a bit outdated now, did you still want to get this in, or should we still hold off? Or is this even needed anymore?

Yeah, this is not really needed and is going to be deprecated by upcoming changes soon. Closing.


Add Node 10 and 12 to Travis test matrix

10 is currently in LTS and 12 will start LTS in October. It seems
like a good idea to run CI on these versions.

Great, thanks!


visit_detail table not exported

No description provided.

Could you please double check? VISIT_DETAIL_0.csv file was created on my side.


[New Content] Adding Windows configuration for Read-Scale AG

Adding documentation around using SQL Server 2017 feature for read-scale Availability Group between Windows replicas. Only initial version was strictly for Windows to Linux, this covers Windows to Windows.
I found a few things not possible that I think even the Linux version is wrong. Primarily it makes mention us a SQL Server Express edition replica for configuration only replica. However you cannot enable HADR on Express Edition so I'm curious to know how that is even possible.
I have tested building out the Windows to Windows read-scale AG for the purpose of a customer that wanted to test. There are various options for the endpoint authentication much like the normal HA configuration with AGs so I tried to word that the best I could to make it clear.
I followed the same pattern I saw with the Linux version of read-scale using the include files, hope that was the proper method. Please review and let me know what needs to be updated or clarified.

@wsmelton this fresh content is fantastic and very relevant. Thanks for your work bringing this together. Reviewing.

Thank you @wsmelton - #sign-off