Polish codes screen in managing 2FA in newdot

Problem
Here in the 2FA codes screen, we have Copy and Download buttons. We need to add an icon that turns into a check box and provides response that code has been copied or downloaded.
In the main PR, we discussed we'll make a follow up PR to address those issues as it requires updating main Button component.

Solution
Discuss design and implement that
Why it is important
Provide proper response on user action is an important part of the UX

@shawnborton can we please get thoughts on the design.
Also, keeping it daily for now. Feel free to bump it to weekly.

Yup, let's just use buttons with icons and the copy icon can turn into a green check once it has been copied:

Thanks! Should we only turn update copy button or download button too?
I would say both.

Yeah, let's do both!

Thanks sounds good 👍

Hi, Ana from Callstack here 👋 , as mentioned in Slack, I can pick this up!

Proposal
Please re-state the problem that we are trying to solve in this issue.
Make the buttons in 2FA screens have an icon and change icons when they have been pressed
What is the root cause of that problem?
There are two things that need change:

Fix an bug in Button where the iconRight is not being shown if no icon is provided
New component that uses Button and WithDelayToggleButtonState to allow changing the button icon and text when it has been pressed (similar to CopyTextToClipboard but more general and using Button)

What changes do you think we should make in order to solve the problem?

Fix the bug in Button

The conditional for this.props.icon should also include this.props.shouldShowRightIcon
Should apply left margin for the right icon, pass the iconStyles and also apply the small prop to the right icon

Make a new component called ButtonWithDelayToggle that uses WithDelayToggleButtonState and allows passing a checked icon, style and text.

What alternative solutions did you explore? (Optional)
We could go without a new component, but it would require implementing the delay toggle logic directly on the page.
https://github.com/Expensify/App/assets/25725586/1eadddfa-1643-47e9-96d9-07f0896ec3ba

@BeeMargarida thank you for the proposal. Looks good to me!
Just curious if we can reuse this component src/components/ContextMenuItem.js
As we are using this to copy user's personal details on "Details" page

@BeeMargarida thank you for the proposal. Looks good to me! Just curious if we can reuse this component src/components/ContextMenuItem.js As we are using this to copy user's personal details on "Details" page

Hum, we could refactor and make both ContextMenuItem and CopyTextToClipboard use the same base component that contains this logic and then use that same component in this use case.
A question that I have is if we want this new component to be based upon the Button component, or if it's alright to just use Pressable (like in ContextMenuItem and CopyTextToClipboard).

Just curious if we can reuse this component src/components/ContextMenuItem.js As we are using this to copy user's personal details on "Details" page

@MonilBhavsar Hum, we could refactor and make both ContextMenuItem and CopyTextToClipboard use the same base component that contains this logic and then use that same component in this use case.
A question that I have is if we want this new component to be based upon the Button component, or if it's alright to just use Pressable (like in ContextMenuItem and CopyTextToClipboard).

Sounds good to me 👍
It is fine using Pressable. There is no necessary requirement to use Button component.

Got it, I'll use pressable instead then. Do you want me to still fix the iconRight problem mentioned in the proposal?

Yes, let's fix it. We can then test it to avoid regression, to be safe.

Got it, on it!

@MonilBhavsar After checking better, I think migrating ContextMenuItem to this new component is probably not the best idea for several reasons:

The component uses two components: MenuItem and BaseMiniContextMenuItem - this last one is the one that is similar to the new component and that obvious choice to migrate to the new component
The BaseMiniContextMenuItem uses additional style for specific pressable state and does not always include the checked feedback logic
The BaseMiniContextMenuItem is also used in another component MiniQuickEmojiReactions

What do you think?

I see. It makes sense to me. So we go with a new component, in your opinion?

I see. It makes sense to me. So we go with a new component, in your opinion?

A new component makes sense since it would require code duplication and usage of withDelayToggleButtonState. We can reuse that new component in CopyTextToClipboard as well

Sounds good to me 👍 Let's do it

@MonilBhavsar and @BeeMargarida - is it fair to say you will handle this issue https://github.com/Expensify/App/issues/19459 as part of fixing this?
I'd like to close that bug if so.

@michaelhaxhiu yes, the issue will be fixed/or is fixed, as PR is merged

What's the latest here team? Can we close this?

We need to issue payment to @rushatgabhane for reviewing a PR

@adelekennedy I added a bug-zero label as we need to issue payment to @rushatgabhane for reviewing PR.

@rushatgabhane sent offer!

contract sent just waiting it being accepted

Not overdue, waiting for @rushatgabhane to accept the contract.

@rushatgabhane 👋

Oh thanks! So I think we can close this out, correct?

This is new for me - let me see how this works

hmm - I don't think I have access, let me get clarity on how we're supposed to pay these out

@rushatgabhane do you mind resubmitting or posting your steps here? For some reason I can't access it!

thread started here waiting fro Anu and Jason to follow up on next steps

@rushatgabhane anu and jason will approve these! closing for now


Show track downward in TrackScheme Hierarchy View leads to crash

Reproduction

Start Fiji
Plugins > Mastodon
open Mastodon project > open grapher-bug.mastodon (download: https://cloudstore.zih.tu-dresden.de/index.php/s/XgbnqRDgb9jLXLb)
Window > New TrackScheme Hierarchy
Select a branch
View > Show Track Downward > Program crashes

Expected behaviour:
After step 6. "Show Track Downward", the TrackScheme Hierarchy view should zoom to the sub-tree of the selected branch
File for testing:
https://cloudstore.zih.tu-dresden.de/index.php/s/XgbnqRDgb9jLXLb
StackTrace:

UI interaction:

@tpietzsch: Do you think this is because something in the foreground (caused by Show Track Downward) eats up all the memory? And hence the location where the OOM finally occurs is rather arbitrary? Or is this more closely related?

I think you are right. This bug is not related to the spatial index. It just so happened that the spatial index triggered the OutOfBoundsException.
There might be a loop in the graph. The "Show Track Downward" operation does a depth first search to find the roots of the selected sub trees. This depth first search has no detection for loops and it therefor doesn't terminate. I will fix it.

Resolve with #229


Add prototype guide to CONTRIBUTING.md

@meilisearch/integration-team, especially @bidoubiwa for your CIs, is it ok for you regarding the naming convention?

Hey @curquiza, it indeed breaks my script. I'll create an issue on the impacted repositories to update this :) Thanks a lot for the notice

thanks team! bors merge

bors merge

bors merge


No license specified

I would loke to reuse your implementations of the Johnson and Trajan algorithms in a project of mine.
It would be helpful if you specified a license for you code (Preferrably a permissive license like the MIT-License)

Thanks for your feedback. Yes, would Apache 2 license work for you?

Yes, Apache License would be fine, thanks

Done.

Thank you!

welcome. Glad I could help.


Fix: memory overflow for test code

I modify some test param, but it may crash due to the temp vector v in GetKNNRecall is not enough.

/kind improvement

/lgtm


Project status

Hello !
What is the current project status ?

Hello,
it's working and in use by a few projects but it's not actively supported

@Ivshti thanks for reply


build.sh: easier adjustment of VirtualBox settings

added a #Settings section into build.sh to allow easier adjustments of the VirtualBox settings (number of CPUs, memory)

I'll copy over the suggestion I made in a now-closed thread to not lose track of it:

(Optional) We could also take the environment variable from the caller, and setting it to the current value in case it's unspecified:
VIRTUALBOX_CPU=${VIRTUALBOX_CPU:-"4"}

That way, an invocation like VIRTUALBOX_CPU=8 bash build.sh would e.g use 8 cores.
(Same suggestion for VIRTUALBOX_MEMORY.)

I tried writing this up myself as a follow-up PR, but noticed that there's some issues that makes it less trivial than it appears; passing through the variable from the environment is easy, but we currently only apply the sed to edit armbian-build/Vagrantfile the first time we do git clone https://github.com/armbian/build, so subsequent changes to the environment variable won't affect the size of the Vagrant VM used.
Trying to change this and also handle both the case where #vb.memory is commented-out or not leads to a need for a sed expression that is beyond my powers to write quickly. Better yet would be to not have to use the sed at all, in case there's some more flexible mechanism to override Vagrant settings. I've left some trails on a branch below for posterity, but don't have the time to look into it further myself at this time:
https://github.com/digitalbitbox/bitbox-base/compare/master...hkjn:20190513-passthrough-params?expand=1

Yes, I noticed that there are a couple of general design issues that have to be considered, like the sed-issue, environment variables, behaviour of build.sh update or putting the settings into an include file.
I'll leave this to you until you have decided how you want to proceed ;)


Update _session-affinity-by-cookie-process.md

Current document refers to the session affinity cookie as having the name "cflib"; the cookie is currently named "__cflb" per https://developers.cloudflare.com/fundamentals/reference/policies-compliances/cloudflare-cookies/#__cflb-cookie-for-cloudflare-load-balancer-session-affinity (verified in testing earlier today)

Nadant

Nadant

Hello! Thanks for checking and creating the PR 👍


Pull-from-upstream for any git repository

Once the issues listed below are implemented, we should be prepared for a wider adoption of the automation.
Issues to be implemented:

[x] #1907
[x] #1953
[x] #1829
[x] #1956
[x] #1869
[x] #1878

Issues to improve the workflow:

[x] (packit/packit#1915)
[x] (packit/packit#1887)
[x] (packit/packit#1920)
[x] (packit/packit#2035)

Lot of great work was done here!! :rocket: The issues from the list are all implemented, so closing this one.


Continuous "Reference not found from AST node:" errors

Hello, I am facing some issues with the extension.
I have latest vscode, with prettier and motoko extension installed.
I installed latest dfx 0.14.4  following the official guide (curl)
I created a simple project with dfx new sample_project
The vscode extension does not seem to work, no formatting, no inputs, no syntax highligting, intellisense or import actions...
The extension output looks like this after hovering some part of the motoko file:

Any idea?
Do I need to install or configure mops for the extension to work? (I don't have it installed)

I also tried to install prettier-plugin-motoko separately and configure it in a .prettierrc file, without success, but I understand from the extension documentation that shouldn't be needed, am I right?

Happy to help debug. Is this your first time downloading the extension? Also, what operating system are you using?

The extension output looks like this after hovering some part of the motoko file:

The "Reference not found from AST node" messages are actually just debug information, so you can safely ignore them.

I also tried to install prettier-plugin-motoko separately and configure it in a .prettierrc file, without success, but I understand from the extension documentation that shouldn't be needed, am I right?

Yep that's correct; the formatter is built into the extension, so it should work out of the box without installing anything. You should also be okay without installing Mops for the dfx new starter project, so hopefully that helps narrow down the possible causes.

Happy to help debug. Is this your first time downloading the extension? Also, what operating system are you using?

The extension output looks like this after hovering some part of the motoko file:

The "Reference not found from AST node" messages are actually just debug information, so you can safely ignore them.

I also tried to install prettier-plugin-motoko separately and configure it in a .prettierrc file, without success, but I understand from the extension documentation that shouldn't be needed, am I right?

Yep that's correct; the formatter is built into the extension, so it should work out of the box without installing anything. You should also be okay without installing Mops for the dfx new starter project, so hopefully that helps narrow down the possible causes.

Hi again! I am using macOS Ventura, up to date.
After spending some time testing things, now I think I made it working.
It seems some syntax error in the motoko code prevented the auto-formatting to work, I expected to have vscode messages for these kind of issues, like eslint or similar, but I think we are not there yet (not complaining, tho, I appreciate how hard is to build a tool like this).
It is weird because some issues like typos on keywords or wrong imports, show up as problems on vscode, but things like missing semicolon after a expression are not raising an issue apparently (but they prevent auto-formatting to work properly)
The inputs (intellisense) also seem to work.
Another missing part is with imports from the extension, by calling "Motoko: Import Mops Package", the import shows up as not found, but I guess there is already an open issue for that.
I will keep debugging and try to be more specific or helpful reporting issues as I learn and better understand the scope of the extension.
Thank so much for the support and patience.

It seems some syntax error in the motoko code prevented the auto-formatting to work, I expected to have vscode messages for these kind of issues, like eslint or similar, but I think we are not there yet (not complaining, tho, I appreciate how hard is to build a tool like this).

This is very unusual; syntax errors should be showing up in the editor. Thank you for reporting this so we can try and find a solution in case anyone else is also running into this. Did you happen to change anything in the extension settings?

Another missing part is with imports from the extension, by calling "Motoko: Import Mops Package", the import shows up as not found, but I guess there is already an open issue for that.

This feature was contributed very recently by the author of Mops. Pinging @ZenVoich in case he has any suggestions.

Another missing part is with imports from the extension, by calling "Motoko: Import Mops Package", the import shows up as not found, but I guess there is already an open issue for that.

Do you have a mops.toml file in the project root directory?
Does the error appear on the import line or somewhere else?
If you could provide a full error message, that would be helpful.


Stability / connection issues using ESPHome 2023.7.0

I have one of my esp32s that has a bms hooked up that works fine with my phone and a second jkbms without issue that gives this in the logs:
[10:27:23][D][esp32_ble_tracker:245]: Starting scan...
[10:27:23][D][esp32_ble_client:048]: [0] [C8:47:8C:F7:8A:36] Found device
[10:27:23][D][esp32_ble_tracker:213]: Pausing scan to make connection...
[10:27:23][I][esp32_ble_client:064]: [0] [C8:47:8C:F7:8A:36] 0x00 Attempting BLE connection
[10:27:24][D][esp-idf:000]: W (17273) BT_HCI: hcif disc complete: hdl 0x0, rsn 0x3e

[10:27:24][D][esp-idf:000]: W (17494) BT_HCI: hcif disc complete: hdl 0x0, rsn 0x3e

[10:27:24][D][esp-idf:000]: W (17587) BT_HCI: hcif disc complete: hdl 0x0, rsn 0x3e

[10:27:25][D][esp-idf:000]: W (18124) BT_HCI: hcif disc complete: hdl 0x0, rsn 0x3e

[10:27:25][D][esp-idf:000]: W (18128) BT_APPL: gattc_conn_cb: if=3 st=0 id=3 rsn=0x3e

[10:27:25][D][esp-idf:000]: W (18129) BT_APPL: gattc_conn_cb: if=4 st=0 id=4 rsn=0x3e

[10:27:25][W][esp32_ble_client:134]: [0] [C8:47:8C:F7:8A:36] Connection failed, status=133

It will periodically connect, then loses connection, and then never connects again until I restart the esp32.
This worked until recently. And I've tried "recommended" for the esp-idf version, and I've also tried pinning 5.4.0 as the platform version with the same results. Using latest results in errors on build about git.
I also periodically see this in the logs:
[10:27:41][W][esp32_ble_client:134]: [0] [C8:47:8C:F7:8A:36] Connection failed, status=133
[10:27:41][D][esp32_ble_tracker:245]: Starting scan...
[10:27:41][W][jk_bms_ble:365]: [C8:47:8C:F7:8A:36] Not connected
[10:27:41][W][jk_bms_ble:365]: [C8:47:8C:E5:B6:C9] Not connected
[10:27:41][D][esp32_ble_client:048]: [1] [C8:47:8C:E5:B6:C9] Found device
[10:27:41][D][esp32_ble_tracker:213]: Pausing scan to make connection...
[10:27:41][D][esp32_ble_tracker:213]: Pausing scan to make connection...
[10:27:41][D][esp-idf:000]: E (35033) BT_BTM: BTM_BleScan scan not active

[10:27:41][D][esp-idf:000]: W (35035) BT_APPL:  bta_dm_ble_scan stop scan failed, status=0x6

When it does connect I get this:
[10:28:26][I][jk_bms_ble:1158]: Device info frame (320 bytes) received
[10:28:26][I][jk_bms_ble:1210]:   Vendor ID: JK-B2A24S20P
[10:28:26][I][jk_bms_ble:1211]:   Hardware version: 10.X-W
[10:28:26][I][jk_bms_ble:1212]:   Software version: 10.02
[10:28:26][I][jk_bms_ble:1213]:   Uptime: 40668600 s
[10:28:26][I][jk_bms_ble:1214]:   Power on count: 17
[10:28:26][I][jk_bms_ble:1215]:   Device name: Battery 1
[10:28:26][I][jk_bms_ble:1216]:   Device passcode: 1234
[10:28:26][I][jk_bms_ble:1217]:   Manufacturing date: 220403
[10:28:26][I][jk_bms_ble:1218]:   Serial number:<PHONE_NUMBER>
[10:28:26][I][jk_bms_ble:1219]:   Passcode: 0000
[10:28:26][I][jk_bms_ble:1220]:   User data: Input Userdata
[10:28:26][I][jk_bms_ble:1221]:   Setup passcode: 1717
[10:28:27][I][jk_bms_ble:891]: Settings frame (320 bytes) received

Which appears to use the default version for communications according to the docs. (JK_02). Anything else results in weird responses.
I'm also seeing periodic restarts of the esp32s occurring too on this one and a second esp32s that I have running for 2 more bmses.  Is this related?

Which ESPHome release do you use? Please make sure the Android app isn't connected / force closed if you try to talk to the BMS using the ESP. The bluetooth module is able to handle a single connection only. Are you sure the ESP is close enough to the BMS?

2023.7.0 of ESPHome.
No android or ios app running at all and my idevices aren't in range.
The ESP32s are 3 feet away with direct line of sight and worked fine until very recently.

Hmm..  I've no ideas. I cannot update my setup to ESPHome 2023.7.0 at the moment.

+1 on this, I was running esphome 2023.3.2 before and suddenly after some days the second bms did not connect. Use to do reload and if that not solve the problem power of for 20 seconds. As it did not fix the problem I try latest esphome 2023.7.0 but still same problem.  Then I found this open issue and remember when I have done some BMS test before on esphome 2023.6.x and got problem with second BMS after esphome minor release update.
I tested to downgrade per release and it start to work on esphome 2023.6.4 again.

ok, so my problem is detected.
We will have to wait for you to update to version 2023.7.X to fix it.
Thank you.

@jouking I don't if the problem has already been resolved upstream.

@jouking I don't if the problem has already been resolved upstream.

But what is the solution? to downgrade?
I understood that you were going to update to 2023.7.X to solve the problem.

For now downgading ESPHome to version 2023.6.4 is a confirmed workaround.

Based on that information, It must be this issue that was fixed with 2023.6.5 that caused it:
Fix bulk and single Bluetooth parser coexistence esphome#5073 by @bdraco

I've created a new ESPHome issue for it: https://github.com/esphome/issues/issues/4747

Updated Esphome to version 2023.7.1 and the problem is still the same.

I've updated my setup today (without applying the suggested sdkconfig_options yet):
$ esphome run attic-bms-ble.yaml
INFO ESPHome 2023.7.1
INFO Reading configuration attic-bms-ble.yaml...
INFO Updating https://github.com/syssi/esphome-jk-bms.git@main
INFO Generating C++ source...
INFO Compiling app...
Processing attic-bms-ble (board: wemos_d1_mini32; framework: espidf; platform<EMAIL_ADDRESS>
Let's see what happens. :-)

I have the same problem with the BT configuration but on another ESP32 Ethernet. It also fails me and this one fails me more times than the BT.
I have this configuration, any ideas to improve communication?:
esphome:
name: wt32
platform: ESP32
board: esp-wrover-kit
Enable logging
logger:
Enable Home Assistant API
api:
encryption:
key: "xxxxxxx"
ota:
password: "xxxxxxx"
Enable fallback hotspot (captive portal) in case wifi connection fails
ethernet:
type: LAN8720
mdc_pin: GPIO23
mdio_pin: GPIO18
clk_mode: GPIO0_IN
phy_addr: 1
power_pin: GPIO16
Optional manual IP
manual_ip:
static_ip: <IP_ADDRESS>
gateway: <IP_ADDRESS>
subnet: <IP_ADDRESS>
#captive_portal:
external_components:

source: github://syssi/esphome-jk-bms@main
refresh: 0s

uart:
id: uart_0
baud_rate: 115200
rx_buffer_size: 384
tx_pin: GPIO3
rx_pin: GPIO1
jk_modbus:
id: modbus0
uart_id: uart_0
jk_bms:
id: bms0
jk_modbus_id: modbus0
#uart:
tx_pin: 27
rx_pin: 26
baud_rate: 256000
parity: NONE
stop_bits: 1
sensor:

platform: jk_bms
min_voltage_cell:
name: "jkbms_eth min voltage cell"
max_voltage_cell:
name: "jkbms_eth max voltage cell"
min_cell_voltage:
name: "jkbms_eth min cell voltage"
max_cell_voltage:
name: "jkbms_eth max cell voltage"
delta_cell_voltage:
name: "jkbms_eth delta cell voltage"
cell_voltage_1:
name: "jkbms_eth cell voltage 1"
cell_voltage_2:
name: "jkbms_eth cell voltage 2"
cell_voltage_3:
name: "jkbms_eth cell voltage 3"
cell_voltage_4:
name: "jkbms_eth cell voltage 4"
cell_voltage_5:
name: "jkbms_eth cell voltage 5"
cell_voltage_6:
name: "jkbms_eth cell voltage 6"
cell_voltage_7:
name: "jkbms_eth cell voltage 7"
cell_voltage_8:
name: "jkbms_eth cell voltage 8"
cell_voltage_9:
name: "jkbms_eth cell voltage 9"
cell_voltage_10:
name: "jkbms_eth cell voltage 10"
cell_voltage_11:
name: "jkbms_eth cell voltage 11"
cell_voltage_12:
name: "jkbms_eth cell voltage 12"
cell_voltage_13:
name: "jkbms_eth cell voltage 13"
cell_voltage_14:
name: "jkbms_eth cell voltage 14"
cell_voltage_15:
name: "jkbms_eth cell voltage 15"
cell_voltage_16:
name: "jkbms_eth cell voltage 16"
cell_voltage_17:
name: "jkbms_eth cell voltage 17"
cell_voltage_18:
name: "jkbms_eth cell voltage 18"
power_tube_temperature:
name: "jkbms_eth Power tube temperature"
temperature_sensor_1:
name: "jkbms_eth Temperature sensor 1"
temperature_sensor_2:
name: "jkbms_eth Temperature sensor 2"
total_voltage:
name: "jkbms_eth Total voltage"
current:
name: "jkbms_eth Current"
capacity_remaining:
name: "jkbms_eth Capacity remaining"
capacity_remaining_derived:
name: "jkbms_eth capacity remaining derived"
temperature_sensors:
name: "jkbms_eth Temperature sensors"
charging_cycles:
name: "jkbms_eth Charging cycles"
total_charging_cycle_capacity:
name: "jkbms_eth Total charging cycle capacity"
battery_strings:
name: "jkbms_eth Battery strings"
errors_bitmask:
name: "jkbms_eth Errors bitmask"
operation_mode_bitmask:
name: "jkbms_eth Operation mode bitmask"
total_voltage_overvoltage_protection:
name: "jkbms_eth Total voltage overvoltage protection"
total_voltage_undervoltage_protection:
name: "jkbms_eth Total voltage undervoltage protection"
cell_voltage_overvoltage_protection:
name: "jkbms_eth Cell voltage overvoltage protection"
cell_voltage_overvoltage_recovery:
name: "jkbms_eth Cell voltage overvoltage recovery"
cell_voltage_overvoltage_delay:
name: "jkbms_eth Cell voltage overvoltage delay"
cell_voltage_undervoltage_protection:
name: "jkbms_eth Cell voltage undervoltage protection"
cell_voltage_undervoltage_recovery:
name: "jkbms_eth Cell voltage undervoltage recovery"
cell_voltage_undervoltage_delay:
name: "jkbms_eth Cell voltage undervoltage delay"
cell_pressure_difference_protection:
name: "jkbms_eth Cell pressure difference protection"
discharging_overcurrent_protection:
name: "jkbms_eth Discharging overcurrent protection"
discharging_overcurrent_delay:
name: "jkbms_eth Discharging overcurrent delay"
charging_overcurrent_protection:
name: "jkbms_eth Charging overcurrent protection"
charging_overcurrent_delay:
name: "jkbms_eth Charging overcurrent delay"
balance_starting_voltage:
name: "jkbms_eth Balance starting voltage"
balance_opening_pressure_difference:
name: "jkbms_eth Balance opening pressure difference"
power_tube_temperature_protection:
name: "jkbms_eth Power tube temperature protection"
power_tube_temperature_recovery:
name: "jkbms_eth Power tube temperature recovery"
temperature_sensor_temperature_protection:
name: "jkbms_eth Temperature sensor temperature protection"
temperature_sensor_temperature_recovery:
name: "jkbms_eth Temperature sensor temperature recovery"
temperature_sensor_temperature_difference_protection:
name: "jkbms_eth Temperature sensor temperature difference protection"
charging_high_temperature_protection:
name: "jkbms_eth Charging high temperature protection"
discharging_high_temperature_protection:
name: "jkbms_eth Discharging high temperature protection"
charging_low_temperature_protection:
name: "jkbms_eth Charging low temperature protection"
charging_low_temperature_recovery:
name: "jkbms_eth Charging low temperature recovery"
discharging_low_temperature_protection:
name: "jkbms_eth Discharging low temperature protection"
discharging_low_temperature_recovery:
name: "jkbms_eth Discharging low temperature recovery"
current_calibration:
name: "jkbms_eth Current calibration"
device_address:
name: "jkbms_eth Device address"
sleep_wait_time:
name: "jkbms_eth Sleep wait time"
alarm_low_volume:
name: "jkbms_eth Alarm low volume"
manufacturing_date:
name: "jkbms_eth Manufacturing date"
total_runtime:
name: "jkbms_eth Total runtime"
start_current_calibration:
name: "jkbms_eth start current calibration"
actual_battery_capacity:
name: "jkbms_eth Actual battery capacity"
protocol_version:
name: "jkbms_eth Protocol version"

#switch:
- platform: jk_bms
charging:
name: "jkbms_eth Charging"
discharging:
name: "jkbms_eth Discharging"
balancing:
name: "jkbms_eth Balancing"
dedicated_charger:
name: "jkbms_eth Dedicated charger"
text_sensor:

platform: jk_bms
errors:
name: "jkbms_eth Errors"
operation_mode:
name: "jkbms_eth Operation mode"
battery_type:
name: "jkbms_eth Battery type"
password:
name: "jkbms_eth Password"
device_type:
name: "jkbms_eth Device type"
software_version:
name: "jkbms_eth Software version"
manufacturer:
name: "jkbms_eth Manufacturer"

binary_sensor:

platform: jk_bms
balancing:
name: "jkbms_eth balancing"
balancing_switch:
name: "jkbms_eth balancing switch"
charging:
name: "jkbms_eth charging"
charging_switch:
name: "jkbms_eth charging switch"
discharging:
name: "jkbms_eth discharging"
discharging_switch:
name: "jkbms_eth discharging switch"
dedicated_charger_switch:
name: "jkbms_eth dedicated charger switch"

im on esphome  2023.6.4  using JK04 protocoland its working fine.
will this become an issue if I update esphome to  2023.7.1?
thanks
Miguel

Interesting. I'm running on 2023.7 for a month now and never had an issue. :grimacing:
But I did change the scan interval back than...
`
esp32_ble_tracker:
scan_parameters:
interval: 500ms
on_ble_advertise:
then:
- lambda: |-
if (x.get_name().rfind("JK-", 0) == 0) {
ESP_LOGI("ble_adv", "New JK-BMS found");
ESP_LOGI("ble_adv", "  Name: %s", x.get_name().c_str());
ESP_LOGI("ble_adv", "  MAC address: %s", x.address_str().c_str());
ESP_LOGD("ble_adv", "  Advertised service UUIDs:");
for (auto uuid : x.get_service_uuids()) {
ESP_LOGD("ble_adv", "    - %s", uuid.to_string().c_str());
}
}
ble_client:

mac_address: ${mac_address}
id: client0

jk_bms_ble:

ble_client_id: client0
protocol_version: ${protocol_version}
throttle: 0s
id: bms0
`

I cannot reproduce the issue too.

hi all have anyone tried the new esphome version 2023.8.1 to see if the issue has been solved?
thanks
Miguel

I've updated my setup to 2023.8.1 today. Let's see! :-)

I've updated my setup to 2023.8.1 today. Let's see! :-)

2023.8.2 installed.
Im using board: esp32-c3
Lots of Not connected messages in log
after adding
sdkconfig_options:
CONFIG_COMPILER_OPTIMIZATION_SIZE: y
CONFIG_BT_BLE_42_FEATURES_SUPPORTED: y
CONFIG_BT_BLE_50_FEATURES_SUPPORTED: y
CONFIG_ESP_TASK_WDT_TIMEOUT_S: "10"
it became more stable

hi all have anyone tried the new esphome version 2023.9.3 to see if the issue has been solved?
thanks
Miguel

No critical issues on my side:

It appears to be much better now.


W-3217978 - url parameters to dashboard links

Current coverage is 35.95% (diff: 100%)

Merging #105 into 2.0 will decrease coverage by 0.03%

@@                2.0       #105   diff @@
==========================================
  Files           225        225
  Lines         12578      12578
  Methods           0          0
  Messages          0          0
  Branches       2132       2132
==========================================
- Hits           4527       4522     -5
- Misses         7480       7485     +5
  Partials        571        571

Powered by Codecov. Last update fea1612...b206d4f


Dosnt work on web but works perfectly on iOS & android

Describe the bug
So i'm facing this problem where nativewind dosnt work correctly on web but works perfectly on iOS and android, i have created a new project with minimal  settings from expo added nativewind still dosnt work,
To Reproduce
Steps to reproduce the behavior:

Create expo project
add nativewind
add expo web
write a className

The only time it works is by setting only one tailwind variable once more added it stops working
This dosnt work:

import React from "react";
import { Text, View } from "react-native";

export default function App() {
  return (
      <View>
        <Text className="text-red-500 text-3xl">Hello world</Text>
      </View>
  );
}

This works:
import React from "react";
import { Text, View } from "react-native";

>export default function App() {
  return (
      <View>
        <Text className="text-red-500 text-3xl">Hello world</Text>
      </View>
  );
}

Screenshots
With multiple variables

With one variable

babel.config.js:
module.exports = function(api) {
    api.cache(true);
    return {
        presets: ['babel-preset-expo'],
        plugins: ["nativewind/babel"],
    };
};

tailwind.config.js:
/** @type {import('tailwindcss').Config} */
module.exports = {
    content: ["./App.{js,jsx,ts,tsx}", "./screens/*.{js,jsx,ts,tsx}"],
    theme: {
        extend: {},
    },
    plugins: [],
}

package.json:
 {
    "name": "test",
    "version": "1.0.0",
    "main": "index.js",
    "scripts": {
        "start": "expo start --dev-client",
        "android": "expo run:android",
        "ios": "expo run:ios",
        "web": "expo start --web"
    },
    "dependencies": {
        "@expo/webpack-config": "^0.17.0",
        "expo": "~46.0.13",
        "expo-splash-screen": "~0.16.2",
        "expo-status-bar": "~1.4.0",
        "nativewind": "^2.0.11",
        "react": "18.0.0",
        "react-dom": "18.0.0",
        "react-native": "0.69.6",
        "react-native-safe-area-context": "4.3.1",
        "react-native-screens": "~3.15.0",
        "react-native-web": "~0.18.7"
    },
    "devDependencies": {
        "@babel/core": "^7.12.9",
        "tailwindcss": "^3.1.8"
    },
    "private": true
}

Please read the setup instructions for Expo Web https://www.nativewind.dev/quick-starts/expo#expo-web
You need to setup your web project just like a normal Tailwind CSS app.
There is an example in the repo https://github.com/marklawlor/nativewind/tree/main/examples/expo


Resolution v1.1

so now there will be a dropdown for test resolution
a badge is showing either current run resolution (if any) or general resolution for the test
to remove the badge for the test - set the resolution to Not Set
refreshing the page on each resolution setting for now (temp measure, while investigating how to update  the badge dynamically). It's bad UI, but just so that we can start using the functionality while I am trying to fix it.

I am still looking how to update it dynamically. Cause when page loads - we get the resolution from the db. Then we update it with the endpoint, but the page still has the old props... With other things like dark mode we use a var, and then set it's state when updated. But resolution is not that global to the page, it's something specific to each test, so I can't just use that [var, setVar] thing for dynamic update..., cause then I will need to create like 50 vars for each test resolution.
Anyways, in progress on looking for solution, there definitely is something.


question about center loss weight

if we multiply 1./0.0005. Is the center_loss_weight still work?

It is a tricky operation of center loss optimization using SGD. There are two optimizers in model training with center loss. One is for optimizing model parameters, the other one is for optimizing feature centers. When optimizing model parameters, because the center loss is so large at the early epoches that the center_loss_weight matters to decrease the grad of center loss. And when optimizing feature centers by using SGD, the center_loss_weight should be removed. We also did several experiments on the value of center_loss_weight and the choice of whether to  multiply 1./center_loss_weight when optimizing feature centers. We find out that this operation does matters.

Thanks!


Use nexus maven plugin

Use nexus maven plugin for artifact deployment.
JIRA: https://issues.cask.co/browse/CDAP-8048

LGTM


App background is grey on macOS High Sierra

Try the latest version (1.2.1). If it still persists, it’s likely something on Electron’s side and I’ll only be able to test after I upgrade to High Sierra.
Please report back if the new version fixes it.

It's the same still.

Then there is a chance this is something that needs to be fixed on Electron’s side. I should upgrade to High Sierra in the weeks after it comes out, so I’ll take a look then.
If anyone finds the cause and provides a fix in the meantime, I can merge that.

Having the same issue as well

Should be fixed in 1.3.0.


[release-2.5] Fix log container name

https://github.com/stolostron/backlog/issues/24302

/cc @RobDolares


Creator is no longer being set to the depositor by default

In Sufia 7 the creator is no longer being set to the depositor by default.
Is this something we should still be doing?

Duplicate #349


Allow setting the Sentry environment using configuration

Sentry allows using an environment tag to separate environments. Support this in the configuration.

I can work around it.


feat(tests): Add shiny.pytest, shiny.run and shiny.playwright

Fixes #1156
While more documentation will be needed, this will be done in a followup PR. If docs are not met, we can cripple the exposed classes / methods then before release.

Public API being exposed:

shiny

pytest

create_app_fixture()
ScopeName; Fixture levels for scope within pytest (not exposed)
_pytest.py

local_app fixture. Autoloaded via pytest11 entrypoint described in setup.cfg

run

run_shiny_app() -> ShinyAppProc: Run shiny app process
ShinyAppProc: Shiny app process class. Context Manager that calls .close() on __exit__().

playwright

expect

expect_to_change(); Wait until a Locator has updated
expect_attribute_to_have_value()
expect_to_have_class();
expect_not_to_have_class();
expect_to_have_style();

controls

shiny.playwright.controls classes. (Click to expand!)

InputActionButton
InputActionLink
InputCheckbox
InputCheckboxGroup
InputDarkMode
InputDate
InputDateRange
InputFile
InputNumeric
InputPassword
InputRadioButtons
InputSelect
InputSelectize
InputSlider
InputSliderRange
InputSwitch
InputTaskButton
InputText
InputTextArea
OutputCode
OutputDataFrame
OutputImage
OutputPlot
OutputTable
OutputText
OutputTextVerbatim
OutputUi
ValueBox
Card
Accordion
Sidebar
Popover
Tooltip
NavItem
NavsetBar
NavsetCardPill
NavsetCardTab
NavsetCardUnderline
NavsetHidden
NavsetPill
NavsetPillList
NavsetTab
NavsetUnderline
DownloadButton
DownloadLink

Typical typed usage:
from playwright.sync_api import Page

from shiny.playwright.controls import Accordion, InputActionButton, OutputTextVerbatim
from shiny.run import ShinyAppProc

Typical untyped usage:
from shiny.playwright.controls import Accordion, InputActionButton, OutputTextVerbatim

Forgot to add a change log entry


Add prometheus integration

prometheus integration requires patching the juju-created service to expose the metrics port on 8888. A custom scrape job must be defined since the metrics port is different than the default port expected by the prometheus_scrape library.
Added some documentation regarding the relevant relations that are now available as well.

LGTM, can you fix the tests before we merge it? I think you just need to patch the ServicePatch class and rebase

I added the shared workflows to the workflows file to bring this in line with the other CK repositories. Note that the ServicePatch lib requires python 3.8+, so I removed 3.6 and 3.7 from the test matrix.


Update README.asc

Update broken link, gives 404 Not Found when clicked

merged here https://github.com/apache/cassandra/commit/f5a59176f955d8b8842c82328419bfca9747c8c5


How long to beat times are not aligned on bigger font size

Problem still occurs in the latest version

Fixed in v1.0.7


Bugfix/data types

Fixes bug:
ERROR:yfinance:XXX: No timezone found, symbol may be delisted
ERROR:xxx:'list' object has no attribute 'loc'

I'm struggling to understand the problem. Can you submit a bug report using template?

I'm struggling to understand the problem. Can you submit a bug report using template?

The interface says that a ‚pandas.Series‘ is returned, which is not true when the relation is empty.

I understand now. Unit tests would be good. Also, please target dev branch not main #1084

Can you also rebase to dev, tidy up the commit history.

I did already. It tells me that i'ts already update. I don't unterstand what happend here.

You changed the target but haven't rebased. Look at the diff.

I rebased again and force pushed. Hope that helps. Sorry, I'm not experience with rebase. I only merge branches.

Not knowing is fine, but you aren't rebasing. Look at the diff, did you mean to change the version?

$ git branch
* bugfix/data-types
  main

$ git remote -v
origin  https://github.com/mreiche/yfinance.git (fetch)
origin  https://github.com/mreiche/yfinance.git (push)
yfinance        https://github.com/ranaroussi/yfinance.git (fetch)
yfinance        https://github.com/ranaroussi/yfinance.git (push)

$ git log -n 4
commit 77e7be7f8d0c826caa5eefbd8c0d572dad3e080d (HEAD -> bugfix/data-types, origin/bugfix/data-types)
Author: Mike Reiche
Date:   Tue Oct 10 08:25:47 2023 +0200

    Added tests

commit 6b400aaacb91b1bba3818be606650b57cec98114
Author: Mike Reiche
Date:   Mon Oct 9 09:59:25 2023 +0200

    Minor typing fixes

commit c4965fa451f50645cecfab359098f49799a6c0f9
Author: Mike Reiche
Date:   Mon Oct 9 09:53:57 2023 +0200

    Fixed typing bug when series are empty

commit 16305dd7f3175676e15eb6bbfdae73f04b8100c0
Author: Value Raider
Date:   Wed Oct 4 22:03:24 2023 +0100

    Bump version to 0.2.31
$ git fetch yfinance
$ git rebase yfinance/dev
Current branch bugfix/data-types is up to date.
$ git push --force
Everything up-to-date

What I'm doing wrong?

ChatGPT:

Ah, the mysterious case of the unclaimed commit! When you rebase a branch in Git, you're essentially rewriting the commit history. If you find a commit that seems unfamiliar, it might be a result of conflict resolution during the rebase process.

When Git encounters a conflict during rebase, it pauses and asks you to resolve it. If you're not careful, it's easy to accidentally include changes from the wrong commit or overlook something. This could lead to committing changes that weren't originally yours.

To investigate, you can use git log to examine the commit history and git reflog to see the history of branch references. Look for any signs of a merge conflict or unusual commits.

To fix it, you might need to:

Identify the incorrect commit: Check the commit message, changes, and authorship to figure out which commit is the culprit.

Amend or revert the commit: Depending on the situation, you can either amend the commit with the correct changes or revert the commit entirely and then reapply the correct changes.

Remember, it's always a good practice to double-check your changes during a rebase to avoid such surprises. Git can be a tricky beast, but with a bit of detective work, you can usually straighten things out!

Can't you just ignore and merge it?

Ok, I paid the monthly subscription for ChatGPT 4. Quote:

Feel free to go ahead and merge the rebased branch into the target branch when you're ready. If you have any specific concerns or questions about the process, feel free to ask!

Now tell it the commit history still leads back to "main".

I tell you what. I create a new PR and cherry pick my commits.


Inconsistent click events and propagation in chromium browsers

Swiper Version: 6.7.0 or latest as per demo page
Platform/Target and Browser Versions: browser, react

What You Did
Getting click handling inconsistencies in Chromium browsers--Chrome, Brave etc. I can confirm this viewing the demos in Chrome and Brave. Sometimes, the click triggers the slideto, sometimes it triggers pagination, sometimes it does nothing for several clicks--completely inconsistent. It's fine on Safari, but the latest Chrome (Version 91.0.4472.77) is a problem.

Expected Behavior
Clicking a slide should firing the events consistently.
Actual Behavior
Sometimes, the click triggers the slideto, sometimes it triggers pagination, sometimes it does nothing for several clicks. It's fine on Safari, but the latest Chrome (Version 91.0.4472.77) is a problem. This happens in my repo as well as all the demos.

I have a similar issue, where using the fade effect, the first time I click a custom next button, it triggers once and never again

I can confirm the issues described by joebentaylor1995 – even in the current version. It's really annoying we can't use the fade effect in our project for now :(

+1

+1

+1 . In addition, when we add a fade effect - we loose the ability to zoom with doubleclick.

+1. Extremely easily reproduced

+1

+1

+1

Issue is closed because of outdated/irrelevant/not actual/needed more information/inactivity.
If this issue is still actual and reproducible for latest version of Swiper, please create new issue and fill the issue template correctly:

Clearly describe the issue including steps to reproduce when it is a bug.
Make sure you fill in the earliest version that you know has the issue.
Provide live link or JSFiddle/Codepen or website with issue


Add back the accidentally removed plist entry in the app

In #830 at this commit, I removed the entry by accident.
Add it back now, and would need to require @saratchandrakarumuri to do another check for the example in #826 , to make sure it is working correctly right now.

Sorry for the trouble caused 😓 I should've taken another look at files before hitting on the merge button.

I was about to look into that since I couldn't find this sample in our tests. Thanks for the fix

Great! I'll play it safe this time 😅 Please merge after you verify it's OK.


Use reference to const auto

Avoids some unnecessary copies.

I don't see any reason why anything would fail on macOS so I suggest simply re-running the build.


missing annotated_text_pb2

Thank you for your interesting research.
I am working along with Installation now.
I am getting an ImportError in the tox section.

from protos import annotated_text_pb2
ImportError: cannot import name 'annotated_text_pb2'

Hello, the corresponding file annotated_text.proto is present in the tapas/proto folder, so this leads me to believe that the proto file was not compiled successfully, can you check for earlier errors in your run, perhaps the protoc compiler wasn't found?
Otherwise if you can provide a colab to reproduce the error it would help a lot,
Cheers!

Thank you for the quick response.
Before this error, pip install -e . The following error occurred in

This error could be avoided by removing annotated_text_pb2.
Was that a bad idea?


triage: remove all contributors

Description

This issue removes all contributors from the repo. Currently, this feature is not actively utilized, and maintaining it adds unnecessary overhead. The list of contributors is already provided by GitHub in repo itself.
Possible solution(s)

Additional context

Hi @anuragxxd , Can you please provide more details regarding this?

Thank you @psankhe28 for your interest. This issue is currently in the triage stage and hasn't been confirmed for development yet.
@uniqueg  might have more insights on this since he set up the all-contributors system. While I don't believe keeping all-contributors is strictly required, I understand the rationale behind it – in that case this issue could potentially involve fixing aspects related to all contributors.

Thanks @anuragxxd! I very much like the idea of All Contributors, which is much more inclusive and fine-grained compared to the list that is automatically maintained by GitHub. However, I also acknowledge that it's not sustainable as long as we don't automate its use (e.g., via bots that recognize participation through posting of issues, PRs, discussions etc).
So yes, a bit sad to see it go, but given that it's not a priority right now to work out its automation, it's probably best to remove it - at least for now.

Not quite sure how to remove it. Maybe removing the ALL-CONTRIBUTORS-LIST from this file is all it takes?

Not quite sure how to remove it. Maybe removing the ALL-CONTRIBUTORS-LIST from this file is all it takes?

This file too here.

@psankhe28 if you want you can remove these files & revalidate if there are any other places all-contributors exist & make a PR.

Sure, I will work on it.


1823825 | Message fixes | Address validation issues | 46

This PR is for user story 1823825.
Fixed an issue with missing alt text descriptions.
If these changes are not appropriate, please let me know. I'm only trying to clean up validation issues in this repo. So I can easily close this PR or modify it in whatever way is best for the content.

Docs Build status updates of commit ed5224b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

his/core/receiving-messages1.md
:white_check_mark:Succeeded
View

his/core/resource-location-for-open-sscp2.md
:white_check_mark:Succeeded
View

his/core/rqr-and-clear1.md
:white_check_mark:Succeeded
View

his/core/sdlc-multipoint-connections1.md
:white_check_mark:Succeeded
View

his/core/sessions-and-connections2.md
:white_check_mark:Succeeded
View

his/core/shutdown2.md
:white_check_mark:Succeeded
View

his/core/snalink-configuration-information1.md
:white_check_mark:Succeeded
View

his/core/snalink-structure-snadis-2.md
:white_check_mark:Succeeded
View

his/core/status-control-acklua-message1.md
:white_check_mark:Succeeded
View

his/core/status-control-message1.md
:white_check_mark:Succeeded
View

his/core/syncpt-verb-issued-locally2.md
:white_check_mark:Succeeded
View

his/core/syncpt-verb-issued-remotely2.md
:white_check_mark:Succeeded
View

his/core/tcp-enhanced-listener-message-link1.md
:white_check_mark:Succeeded
View

his/core/tcp-enhanced-listener-message-user-data2.md
:white_check_mark:Succeeded
View

his/core/tcp-ip-clients2.md
:white_check_mark:Succeeded
View

his/core/tcp-transaction-request-message-link2.md
:white_check_mark:Succeeded
View

his/core/tcp-transaction-request-message-user-data2.md
:white_check_mark:Succeeded
View

his/core/ti-tcp-ip-load-balancing2.md
:white_check_mark:Succeeded
View

his/core/tn5250-access1.md
:white_check_mark:Succeeded
View

his/core/transaction-integrator-architecture1.md
:white_check_mark:Succeeded
View

his/core/transaction-size-vs-data-throughput2.md
:white_check_mark:Succeeded
View

his/core/transaction-size-vs-transaction-throughput2.md
:white_check_mark:Succeeded
View

his/core/transactional-data-flows-that-support-bounded-recordsets1.md
:white_check_mark:Succeeded
View

his/core/two-phase-commit2.md
:white_check_mark:Succeeded
View

his/core/understanding-cpi-c2.md
:white_check_mark:Succeeded
View

his/core/understanding-peer-to-peer-networking2.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@MandiOhlinger This PR is ready for merge.


why is count way slower than wc -l ?

So I tried this tool for the first time today. Made a quick test to see how fast it was vs linux native gnu tools, and the result was unexpected, am i doing something wrong?
[lunfardo@lunfardo-pc Datasets]$ time xsv count train.csv
125497040
real    0m8,709s
user    0m8,237s
sys     0m0,466s
[lunfardo@lunfardo-pc Datasets]$ time cat train.csv | wc -l
125497041
real    0m1,799s
user    0m0,812s
sys     0m2,404s
[lunfardo@lunfardo-pc Datasets]$ time xsv count train.csv
125497040
real    0m8,652s
user    0m8,142s
sys     0m0,503s
run xsv count twice in case it was a problem of cache or something like that.

Because one line isn't necessarily one record? A record can span multiple lines, so counting csv records requires parsing csv records.
[andrew@Cheetah ~]$ cat /tmp/weird.csv
label,description
foo,"this is
one
field
really
yup"
[andrew@Cheetah ~]$ wc -l /tmp/weird.csv
9 /tmp/weird.csv
[andrew@Cheetah ~]$ xsv count /tmp/weird.csv
1

Upss, my bad, thank you


New install - cannot load such file

The initial setup command doesnt seem to be working.
/Library/Ruby/Gems/2.3.0/gems/xcfit-8.0.0/bin/xcfit:4:in `require': cannot load such file -- xcfit (LoadError)
	from /Library/Ruby/Gems/2.3.0/gems/xcfit-8.0.0/bin/xcfit:4:in `<top (required)>'
	from /usr/local/bin/xcfit:22:in `load'
	from /usr/local/bin/xcfit:22:in `<main>'

Fixed it.
Dont run this command  xcfit setup_xcode_templates from a directory with bundles installed


cFE Integration candidate: 2021-01-19

Describe the contribution
A clear and concise description of what the contribution is.

Include explicitly what issue it addresses [e.g. Fixes #X]

Testing performed
Steps taken to test the contribution:

Build steps '...'
Execution steps '...'

Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.

API Change: xxx (if applicable)
Behavior Change: xxx (if applicable)
Or no impact to behavior

System(s) tested on

Hardware: [e.g. PC, SP0, MCP750]
OS: [e.g. Ubuntu 18.04, RTEMS 4.11, VxWorks 6.9]
Versions: [e.g. cFE 6.6, OSAL 4.2, PSP 1.3 for mcp750, any related apps or tools]

Additional context
Add any other context about the contribution here.
Third party code
If included, identify any third party code and provide text file of license
Contributor Info - All information REQUIRED for consideration of pull request
Full name and company/organization/center of all contributors ("Personal" if individual work)

If NASA Civil Servant Employee or GSFC Contractor on SES II

Address/email/phone and contract/task information (if applicable) must be on file

Else if Company

HAND SIGNED Company CLA must be on file (once per release): Company CLA

Else if Individual

HAND SIGNED Individual CLA must be on file (once per release): Individual CLA

@skliper #905 broke one of the tests.
 The following tests FAILED:
Errors while running CTest
	 70 - cfe-core_sb_UT (Failed)
make: *** [test] Error 8

See https://github.com/nasa/cFS/runs/1759255844

@skliper #905 broke one of the tests.
 The following tests FAILED:
Errors while running CTest
	 70 - cfe-core_sb_UT (Failed)
make: *** [test] Error 8

See https://github.com/nasa/cFS/runs/1759255844

@astrogeco - is it working now that you added #1077?  #905 was marked as dependent.

@astrogeco - is it working now that you added #1077?  #905 was marked as dependent.

@astrogeco - is it working now that you added #1077? #905 was marked as dependent.

Yeah, I found it, sorry!

@astrogeco - is it working now that you added #1077? #905 was marked as dependent.

Yeah, I found it, sorry!

@astrogeco - is it working now that you added #1077? #905 was marked as dependent.

Yeah, I found it, sorry!

I didn't catch the dependency on #1077 because it was in the comments.

@astrogeco - is it working now that you added #1077? #905 was marked as dependent.

Yeah, I found it, sorry!

I didn't catch the dependency on #1077 because it was in the comments.


Add Launchpad link

I've added an example on Apollo Launchpad based on your README, hope you find it useful! https://launchpad.graphql.com/vkvpvznr3

Thanks a lot @stubailo! Launchpad is a great tool for allowing people to explore the library. I really appreciate it!


ci: update code coverage uploader

The bash-based code coverage uploader is deprecated, and the new thing
is v0.2.x... sigh.  In any case, it makes little sense to stay on the
deprecated version.

This change is

I'd still suggest the rm.

Done.


til::rectangle

Summary of the Pull Request
Introduces convenience type til::rectangle which automatically implements our best practices for rectangle-related types and provides automatic conversions in/out of the relevant types.
PR Checklist

[x] In support of Differential Rendering #778
[X] I work here.
[x] Tests added/passed
[x] I'm a core contributor.

Detailed Description of the Pull Request / Additional comments

Automatically converts in from anything with a Left/Top/Right/Bottom or left/top/right/bottom (Win32 RECT)
Automatically converts Console type SMALL_RECT and shifts it from inclusive to exclusive on instantiation
Automatically converts out to SMALL_RECT (converting back to inclusive), RECT, or D2D1_RECT_F.
Constructs from bare integers written into source file
Constructs from a single til::point as a 1x1 size rectangle with top-left corner (origin) at that point
Constructs from a single til::size as a WxH size rectangle with top-left corner (origin) at 0,0
Constructs from a til::point and a til::size representing the top-left corner and the width by height.
Constructs from a til::point and another til::point representing the top-left corner and the exclusive bottom-right corner.
Default constructs to empty
Uses Chromium numerics for all basic math operations (+, -, *, /)
Provides equality tests
Provides operator bool to know when it's valid (has an area > 0) and empty() to know the contrary
Accessors for left/top/right/bottom
Type converting accessors (that use safe conversions and throw) for left/top/right/bottom
Convenience methods for finding width/height (with Chromium numerics operations) and type-converting templates (with Chromium numerics conversions).
Accessors for origin (top-left point) and the size/dimensions (as a til::size).
Intersect operation on operator & to find where two til::rectangles overlap, returned as a til::rectangle.
Union operation on operator | to find the total area covered by two til::rectangles, returned as a til::rectangle.
Subtract operation on operator - to find the area remaining after one til::rectangle is removed from another, returned as a til::some<til::rectangle, 4>.
TAEF/WEX Output and Comparators so they will print very nicely with VERIFY and Log macros in our testing suite.
Additional comparators, TAEF/WEX output, and tests written on til::some to support the Subtract operation.
A natvis

Validation Steps Performed

See automated tests of functionality.

Sample natvis:

See also: #4850, #4897


js[patch]: Store local storage instance on globalThis

Matches LangChain.js, lays groundwork for easier trace handoffs since both can now reference the same AsyncLocalStorage instance.
https://github.com/langchain-ai/langchainjs/blob/main/langchain-core/src/singletons/index.ts#L24

Wait, no we don't want to do this yet, sorry. Needs to be after a potential new JS tracer that uses a RunTree


Question: What does "Average Server RSS" mean?

The term is mentioned in your performance guide. https://github.com/coreos/etcd/blob/master/Documentation/op-guide/performance.md

It's memory usage https://en.wikipedia.org/wiki/Resident_set_size from the top command.

Thx for the quick reply


Add Array Extension for filtered

Add Array Extension for filtered

          2 Warnings

:warning:
Consider adding tests for new extensions or updating existing tests for a modified SwifterSwift extension

:warning:
The source files have been modified. Please consider adding a CHANGELOG entry if necessary.

          4 Messages

:book:
Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.

:book:
iOS: Executed 534 tests, with 0 failures (0 unexpected) in 8.997 (9.718) seconds

:book:
tvOS: Executed 500 tests, with 0 failures (0 unexpected) in 2.085 (2.570) seconds

:book:
macOS: Executed 364 tests, with 0 failures (0 unexpected) in 0.862 (1.184) seconds

SwiftLint found issues
Warnings

File
Line
Reason

ArrayExtensions.swift
167
Lines should not have trailing whitespace. (trailing_whitespace)

ArrayExtensions.swift
174
Lines should not have trailing whitespace. (trailing_whitespace)

ArrayExtensions.swift
181
Lines should not have trailing whitespace. (trailing_whitespace)

ArrayExtensions.swift
187
Lines should not have trailing whitespace. (trailing_whitespace)

ArrayExtensions.swift
194
Files should have a single trailing newline. (trailing_newline)

Errors

File
Line
Reason

ArrayExtensions.swift
169
Variable name should be between 3 and 40 characters long: 'e' (identifier_name)

ArrayExtensions.swift
176
Variable name should be between 3 and 40 characters long: 'e' (identifier_name)

  Generated by :no_entry_sign: Danger

As I said in the other issue, I think the essential functionality of this proposal is deduplication and not filtering.  As such, I would recommend this be named something like withoutDuplicates(for keyPath:)

just cleaning up those old PR's.
@fanglinwei   Closing this one due to inactivity, feel free to reopen :))


Crashes when trying to interact with inaccessible or broken files

Related: #498 #480 #305
Denaro should show an error instead of crashing when interacting with inaccessible or broken file during:

Opening/creating an account
Importing
Adding a receipt

https://github.com/NickvisionApps/Denaro/releases/tag/2023.5.0-rc1


no man page

Lacks documentation other than a basic usage message when run w/o arguments. A man file would be nice.

One could add the manpage from the Debian project: https://sources.debian.net/src/httpie/0.9.2-1/debian/http.1/
It's rather short, but at least there is one. :-)

It seems like the http(1) manpage has been added, but there is issues with it. the headers only option is --headers or -t, but it is --headers or -h for httpie instead.

Tools such as help2man can help generate a man page.

Duplicate of #248

Any tips for good format/tools/workflow for the making a man page?

Word of warning: Downstream Linux redistributors will not care about the man page you generate and in most cases generate one of equal or lesser quality. Further, pip doesn't always have the permissions to install man pages in the correct place. This probably shouldn't be much of a priority.

I would like to re-activate this thread, as httpie is a CLI tool, it seems logical to have a man page for it at hand. The --help suggested by @stefan2904  seems incomplete and I cannot agree with @sigmavirus24, downstream (at least OpenBSD and others) cares about man pages. I do not see a reason not to use a good man page already distributed with the software ...
To the point, my suggestion is to change the README.rst for a proper man page using mdoc, which could be used on all modern UNIX like systems (every linux distro, BSD, MacOSX, and many more). I volunteer for that. But I wanted to ask if you would consider this before investing any time on it.
I would leave a shorter README.[md,rst] with install instructions and some basic examples and the current animations. That will be the "face" on the github repo and can get you started. But I would convert the current documentation to an actual man page, one that can read in detail when needed, in a separate tmux pane or terminal, while actually working with httpie.
Later, that file will have to be maintained as you do now with the rst file.
What do you think ?

@jakubroztocil are you interested in this ?
Thanks.

@pacoesteban why even bother rewriting in mdoc when there is rst2man utility that will generate the appropriate man page?
The python community prefers rst and so we keeping our docs in that would be more maintainable and preserve doc quality.

I brought this back because the current readme is not really structured as a man page. I think it should be something like a refactored mix of the readme and --help. Also, it bugs me every time I have to check docs on this cli tool I use quite often (as @dequis was saying on #248). Besides, the rst2man utility you mention fails to generate the man page (and no, is not because of the images at the front of the file).
Of course is not my intention to try to impose my view on how docs should be to the python community or to this project, and I see little interest on this.
So, do you think the current readme could be modified in a way that some tool like rst2man could be used to generate a man page ? "Not perfect man page is better than no man page".

I'm not a maintainer but I definitely agree that "an imperfect man page is better than none at all". As for my comment, earlier, Debian and Fedora have outright refused to use man pages bundled in projects I've worked on (e.g., OpenStack CLI tooling) in the past. Combine that with the understanding that pip on most Linux distributions is intentionally patched to disallow installation beyond user-scope and you've got the perfect recipe for "This is something that benefits very few people in practice". Especially when you consider that Debian and Fedora variants often pin old versions so adding man pages only helps people a few years in the future.

I have made an alias for man httpie that does open https://httpie.org/doc xD

Would http --help be viable as a manpage? Based on what I see from the discussion here, it seems to me like a better "minimal" option.
But as mentioned, this is kind of a moot point if package maintainers wouldn't use it.
In that respect, I love the @deed02392's solution the most ^_^

Since HTTPie 3.2 comes with man pages, should this issue be closed?

HTTPie now includes man pages — https://httpie.io/blog/httpie-3.2.0 🎉


Prevent file removal errors during project creation

Overview:
This pull request makes a modification to the file removal commands in the apps/cli/bin/index.js script to prevent errors when the files or directories do not exist.
Details:
In the setup function in apps/cli/bin/index.js, the rm command was updated to use the -f (force) option. This change applies to the removal of .github/workflows/cli.yml, .github/workflows/docs.yml, and .github/workflows/vscode.yml files. The -f option will prevent the rm command from throwing an error if the file does not exist, allowing the script to continue its execution.
Reason:
The original script used the rm -rf command for both file and directory removal. However, this can lead to errors when a file does not exist because rm -rf is primarily intended for directory operations.
This pull request modifies the script to use rm -f for file removal and rm -rf for directories. This ensures that the script runs smoothly even if certain files don't exist.
This specific change addresses an issue encountered when creating a new T4 project with yarn create t4-app --supabase, improving the overall user experience by preventing unnecessary errors and interruptions.
Test Plan:
To test the changes, follow these steps:

Pull the changes from this PR.
Navigate to the bin directory with the command cd apps/cli/bin.
Run yarn install to install any necessary dependencies.
Run the script directly using Node.js with the command node index.js --supabase.
The script should execute successfully without any errors related to the removal of non-existent files.

@timothymiller mentioned on Discord that there was a typo in the docs. It should be yarn create t4-app --supabase-auth! I still think this PR could be useful for making the script more robust against missing files. Open to feedback!


Docker container usage

Hey @filiparag awesome job with this script, it's been very helpful to keep my ISP-provided dynamic addresses synced to Hetzner DDNS service for a while now.
I know the systemctl-based script works flawlessly in other setups I have, but today I decided to give the Docker image a try (based on the usage line located in https://hub.docker.com/r/filiparag/hetzner_ddns)
I noticed the following behavior, which I gotta apologize beforehand if this is working as designed, even though I have a strong feeling it is not.

Is this expected to be run as one-shot? Reason I'm asking is if I close the terminal in which the docker was started, the container would exit from docker engine perspective.

Is it expected to post the docker logs directly into the terminal it is started from?

If I stop the container using a second terminal, and then "docker start" it, no logs are seen in the terminal and it behaves as a normal docker, returning to the shell prompt. Also, it keep updating the ip address as expected.

Docker version
root@dock:/opt/scripts# docker -v
Docker version 27.3.1, build ce12230

Ran container from terminal, it does not return the shell prompt, and would post all docker logs into terminal console.

hetzner_ddns.conf contents

Any help or guidance would be appreciated.

Hi, thanks for opening the issue. To answer your questions:
If you run it without the --detach flag, the container shall terminate when the parent (shell) does, and outputs the logs to standard output (active console window). When you stopped and started the container manually, you inadvertently caused it to detach.


Adds README to master

If you have any ideas for word choice changes, or additional content we should have in this README just let me know!  I think this is probably a pretty good start though.

Looks perfect!


Adding Application Insights support to base images

This PR updates the base Node.js images, by adding the Application Insights SDK to them. If the Application Insights integration is enabled for the "hosting" web app (resulting in the ENABLE_APPINSIGHTS env var being set), then the app's startup command will be augmented in order to transparently initialize the Application Insights runtime in-proc. This way, users can enable AI when creating a web app, do a Git push to a default runtime image, and start immediately collecting telemetry, without needing to do anything further. 🚀
If the AI integration feature isn't enabled, then the app will run as usual, with the SDK bits remaining completely inert within the Docker container (similar to the existing default web site bits).
Note: This PR currently only updates the Node 8.1.2 image, in order to get feedback on the implementation. Once the general approach is validated/refined, I'll update the PR to include support for the rest of the default images.
// CC @naziml @nickwalkmsft

Also, I just had a thought - how does this work on an arbitrary customer app that doesn't use AI? Won't the --require fail since they haven't installed it?

@nickwalkmsft Since the Docker image itself includes the AI SDK, the --require will always work. The --require arg can reference an arbitrary JS file/module, and that module can in turn reference NPM dependencies which are relative to it, not the app itself. So when we pre-load initAppInsights.js, and that file calls require("applicationinsights"), that applicationinsights module will be resolved from the directory that initiAppInsights.js is within, not the user code directory.

@nickwalkmsft @naziml Let me know if there's anything else you think should be addressed with this PR. As far as doing some E2E testing, do you think we should just leave this in one Node version and validate the experience a bit further, before replicating it to every Node version? It's already gated behind the ENABLE_APPINSIGHTS env var, but just let me know what you think we should update the PR with support for all Node versions.

@nickwalkmsft Should we close this PR for now and re-discuss it in the future?

Yeah, please go ahead and close. Keep your commits around though; they may be useful later. Thank you!


please support more type of file

Description of the new feature / enhancement
in the monaco feature i hope have more kinds of file it can be open by notepad but cant preview, like .lrc, .csv(iknow open using excel but it can use notepad preview), i hope can customize the file type some useless type was not cover

Scenario when this would be used?
sometime was just want to preview a special kinds of file, but it just show a file info preview, it can be use some current method to preview but just not cover this kinds. at least can be use some orginal method to see the raw data is most basic needs.
Supporting information
No response

Hi @laughtLOOL this looks like a /dup of 22279 so I will be closing as a dup. Feel free to re-open if I misinterpreted your request :)


BiDirectional JIRA Integration (Don't Merge)

Conflicts Resolved. Testing I didn't screw anything up

@aaronweaver @grendel513 @mtesauro ^

@aaronweaver @grendel513 @mtesauro figured out the issues doing one more manual pass and then this will be ready for your reviews

@mtesauro @grendel513 @aaronweaver http://s2.quickmeme.com/img/49/49bd7440ec7c07183a676bf3f0182ee20621c20e5c3442d4bb451c76fe3529e9.jpg
I have a JIRA instance and Dojo instance I can share the creds for when someone is able to review

found a minor issue. fixing

okay @aaronweaver @mtesauro @grendel513  ready for review again

@devGregA Reviewed and merged.


KeyVault docs for enabling soft-delete with PS should have the same warning as the CLI

Enabling soft-delete can't be reversed and the PS docs should add the same warning as the CLI page:

Important
Enabling 'soft delete' on a key vault is an irreversible action. Once the soft-delete property has been set to "true", it cannot be changed or removed.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cd179352-3f2f-f872-fe62-36e55cbc44b5
Version Independent ID: c77b1cd0-6867-e260-dcd7-5c45b1cc86f8
Content: Azure Key Vault - How to use soft-delete with PowerShell
Content Source: articles/key-vault/key-vault-soft-delete-powershell.md
Service: key-vault
GitHub Login: @msmbaldwin
Microsoft Alias: mbaldwin

@tg-msft
Thanks for your feedback! We will investigate and update as appropriate.

@tg-msft thanks for the feedback. I think it's a good idea.
I made a pull request to add this. In the future you can feel free to make your own pull requests as well. https://github.com/MicrosoftDocs/azure-docs-pr/pull/84659
@msmbaldwin


Update font to Red Hat Font

Pull in Red Hat fonts - 3 variations

We will not start work on this issue until we have been notified to continue.

https://github.com/RedHatOfficial/RedHatFont

Hi @mcoker @kybaker -- I have issue #1090 in the pf org repo to update the typography page on the website here.
Can you tell me, is it just a matter of changing any instance of overpass to Red Hat font? Or will I need to update the font weights and sizes?
Also, which link do we want to direct users to for download?
Happy to hop on a quick call about this if it's easier. Thanks!

@stacymcauliffe great question. The new font is actually 2 fonts and we're currently still working out the rules behind which font, font weights, etc to use when. As for the download link I think https://github.com/RedHatOfficial/RedHatFont would probably be best. wdyt @kybaker?

@mcoker @stacymcauliffe  Yes that is the best link. We are still working out the specifics so we can assure there are no broken elements and we maintain consistency across the portfolio.

@kybaker have we firmed anything up since Tuesday or still in progress on specifics?

@rachael-phillips We are still in progress. I am planning to give specifics at the visual design meeting today.

Great! Thank you!

:tada: This issue has been resolved in version 2.18.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update Readme.md

In this pull request:
I Installed react using vite
I created a react todo app
I Installed linters

Hi @tjay1760 ,
Good job on your project 🙏 All functionality you added work.
Optional
You can add more functionality to make your todo app more interesting 👋


Transfer ownership from drivendata user to drivendataorg organization

Post v2, pre v2.1

[ ] Transfer ownership
[ ] Update GitHub pages website to redirect to new website (follow this procedure)
[ ] Update links in README, etc. for V2

Don't change:

V1 README instructions to point to new repo: GitHub should redirect this anyways
V1 README links: these should just redirect, and will be replaced for V2

I'm going to reorder this to put the GitHub Pages step first. I think it's probably safer to get that sorted out separately before the transaction.
The high-level ideas involved are:

Create the user-level GitHub Pages website for the drivendata user (https://drivendata.github.io).
Stop deploying/disable the drivendata/cookiecutter-data-science GitHub Pages
Create a cookiecutter-data-science page on the drivendata user GitHub Pages website, which should end up with the same URL as the old website. Have this new page do HTML meta redirect to the new https://cookiecutter-data-science.drivendata.org/ URL

Make sure that all works.

Just noting here that we needed to "Delete" (not just "Unpublish") the GitHug Pages site before the user Pages version kicked in: https://docs.github.com/en/pages/getting-started-with-github-pages/deleting-a-github-pages-site


Is vllm willing to support models based on other AI frameworks, such as mindspore?

Hello,
we are MindSpore eco-developers! MindSpore is a new open source deep learning training/inference framework that could be used for mobile, edge and cloud scenarios.(You can get a more detailed introduction to MindSpore at: https://www.mindspore.cn/en)
We want to add a MindSpore backend to vllm to expand the MindSpore ecosystem, and at the same time, also make the vllm ecosystem better.
Our team has several software engineers with years of development experience, and we are supported by the team of MindSpore framework developers.
We would like to know if your community accepts models based on MindSpore? and if it is possible, we can discuss the technical details further.

如果支持这些框架，那vllm就走不远了。

如果支持这些框架，那vllm就走不远了。
https://github.com/vllm-project/vllm/issues/3620
Google后续都有将JAX集成到vLLM的想法，为什么我们国内的框架不可以这样做呢？
https://github.com/vllm-project/vllm/issues/7692
现在已经有人提出npu支持vllm，那么将Mindspore集成到vLLM，我理解也是可以的

如果支持这些框架，那vllm就走不远了。

https://github.com/vllm-project/vllm/issues/3620
Google后续都有将JAX集成到vLLM的想法，为什么我们国内的框架不可以这样做呢？
https://github.com/vllm-project/vllm/issues/7692
现在已经有人提出npu支持vllm，那么将Mindspore集成到vLLM，我理解也是可以的

Personally I think it makes more sense for the support for alternative frameworks to stay as a fork of vLLM. For now the scope of vLLM is still limited to PyTorch and we don't have plan to expand to other frameworks.
#3620 as you mentioned is adding support for TPUs with PyTorch XLA rather than supporting JAX directly, and general speaking supporting different hardware is a much different story than supporting other DL frameworks.

Personally I think it makes more sense for the support for alternative frameworks to stay as a fork of vLLM. For now the scope of vLLM is still limited to PyTorch and we don't have plan to expand to other frameworks.
#3620 as you mentioned is adding support for TPUs with PyTorch XLA rather than supporting JAX directly, and general speaking supporting different hardware is a much different story than supporting other DL frameworks.

Thank you very much for your patient reply. We will continue to pay attention to the technical development of vllm and think about the possibility of connecting mindpore with vllm technology.


assets mentioned in angular.json are not getting compressed using compression webpack plugin while using @angular-builders/custom-webpack:browser

🐞 Bug report
Command (mark with an x)
ng build --prod

[ ] new
[x] build
[ ] serve
[ ] test
[ ] e2e
[ ] generate
[ ] add
[ ] update
[ ] lint
[ ] extract-i18n
[ ] run
[ ] config
[ ] help
[ ] version
[ ] doc

Is this a regression?
The issue is introduced once we have migrated to Angular CLI - 11.0.4
It was working fine in Angular CLI - 9.1.12
Description
While using @angular-builders/custom-webpack:browser as a build architect, the assets (mentioned in assets array of angular.json) are not getting compressed using compression-webpack-plugin. On debugging it further, I found that CompressionPlugin taps on emit hook (compiler.hooks.emit.tapPromise) of webpack
Pointing the section from the code of compression plugin.
compiler.hooks.emit.tapPromise({
      name: 'CompressionPlugin'
    }, async compilation => {
      const {
        assets
      } = compilation;

Now till v9 of Angular CLI all the assets were showing up in compilation.assets. But starting from Angular 11, files inside assets are not coming here. And hence CompressionPlugin is not able to take up these files for further processing.
Issues that don't have enough info and can't be reproduced will be closed.
🌍 Your Environment
Angular CLI - 11.0.4
Webpack - 4.46.0
Compression-webpack-plugin - 4.0.1

Hi @aniket7824,
This is expected because since version 10, the copying of assets has been moved outside of Webpack.
Webpack is an implementation detail and using a custom Webpack configuration or specific Webpack features are not supported by the Angular tooling team.
The best resolution would be to compress the assets pre-build and commit them.


testnet: new epoch every 2h with layer duration 2m

the current testnet configuration is too unrealistic. verifying atxs is expensive, we shouldn't create them very often in the public testnets, as it leads to unnecessarily long sync times on resource-restricted machines.
Changes

change the layer to 120s. hare round 10s, 2 iterations of 4 rounds + pre round + wakeup + commitment round should fit in
epoch size is 60 layers, so that atx is generated once in 2h

bors merge


New cname for couchdb-vm2, see INFRA-20435

Because of ASF Infra changes, couchdb-vm2.apache.org is going away and will be replaced by couchdb-vm before August 1st 2020.
This PR adds redirection through a new CNAME, logs.couchdb.org, for the logfile uploader.
It also uses repo-nightly.couchdb.org instead of couchdb-vm2.a.o.
This requires @janl to get the new CNAME in before this can land.
This is a cherrypick of #2982 .

The machine is ready now and just needs the CNAMEs.


API Gateway to Chroma

I have my bd in a fargate of AWS.To communicate to the fargate, i have:
API GATEWAY --> VPC LINK --> ALB --> FARGATE --> CHROMADB
when I want to load my data get this error:
Exception                                 Traceback (most recent call last)
/usr/local/lib/python3.10/dist-packages/chromadb/api/fastapi.py in raise_chroma_error(resp)
628         resp.raise_for_status()
629     except requests.HTTPError:
--> 630         raise (Exception(resp.text))
Exception: HTTP content length exceeded 10485760 bytes.
What options do you recommend to be able to load the data?

Yes, I am adding the embeddings of 3000 sentences at a time, the sentences are very long, they can contain approximately 200 tokens

@eliza910115 HTTP does have limits... if you Google "HTTP content length exceeded 10485760 bytes" you'll see many non-Chroma examples of this. Our clients don't batch for you (yet), can you batch before loading in?

I don't think this is a chroma issue - but an issue in your networking stack, unforutnately API gateway has a max 10MB limit, I would suggest batching your calls, we also have a util to help with this https://github.com/chroma-core/chroma/blob/main/chromadb/utils/batch_utils.py
Closing this out but feel free to reopen if that doesn't help.


fix(compiler-core): v-if key increment also based on other type siblings

Respect child index position in transition group when calculating key
For v-if nodes, they have built-in logic to calculate key based on branches, and it defaults to 0.
Therefore, in BaseTransition, it should respect both key calculation from v-if nodes and their position indexes in TransitionGroup.
close #5761

I will add tests soon


Webcmdlets -AllowInsecureRedirect -> follow HTTP redirects from HTTPS

PR Summary
WebCmdlets add -AllowInsecureRedirect switch to enable HTTPS to HTTP redirect.
System.Net.Http.HttpClient disables insecure redirects, this PR bypasses the problem, unfortunately at the moment I can't find a way to make it honor the -MaximumRedirects flag, so I have disabled using both of them toghether.
I'm eager to receive your feedback on this feature and some input on how to fix and re-enable the -MaximumRedirect flag.
I'm going to add some tests to show what works and what doesn't work yet.

PR Context
Fixes #2896 and #18541

PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[x] Documentation needed

[ ] Issue filed:

Testing - New and feature

[ ] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[ ] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:

[ ] Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
(which runs in a different PS Host).

[ ] Issue filed:

[ ] Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.

[ ] Issue filed:

[ ] Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).

[ ] Issue filed:

[ ] Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[ ] Issue filed:

unfortunately at the moment I can't find a way to make it honor the -MaximumRedirects flag

https://github.com/PowerShell/PowerShell/blob/f5eede60b914a3c124fccf87a201f35e3fc6cdff/src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs#L1045-L1049
This says it is in GetResponse().

-AllowInsecureRedirect should now work with -MaximumRedirect.
I tested it with this code:
0..5 | ForEach-Object {Invoke-WebRequest https://mockbin.org/redirect/300?to=http://mockbin.org/redirect/301?to=https://mockbin.org/redirect/302?to=http://mockbin.org/redirect/303?to=http://mockbin.org/redirect/307?to=https://mockbin.org/status/200 -SkipHttpErrorCheck -AllowInsecureRedirect -MaximumRedirection $_}
0..5 | ForEach-Object {Invoke-RestMethod https://mockbin.org/redirect/300?to=http://mockbin.org/redirect/301?to=https://mockbin.org/redirect/302?to=http://mockbin.org/redirect/303?to=http://mockbin.org/redirect/307?to=https://mockbin.org/status/200 -SkipHttpErrorCheck -AllowInsecureRedirect -MaximumRedirection $_}
Invoke-WebRequest https://mockbin.org/redirect/300?to=http://mockbin.org/redirect/301?to=https://mockbin.org/redirect/302?to=http://mockbin.org/redirect/303?to=http://mockbin.org/redirect/307?to=https://mockbin.org/status/200 -SkipHttpErrorCheck -AllowInsecureRedirect
Invoke-WebRequest https://mockbin.org/redirect/300?to=http://mockbin.org/redirect/301?to=https://mockbin.org/redirect/302?to=http://mockbin.org/redirect/303?to=http://mockbin.org/redirect/307?to=https://mockbin.org/status/200 -SkipHttpErrorCheck

I still have to remove some commented code.

Invoke-WebRequest https://mockbin.org/redirect/300?to=http://mockbin.org/redirect/301?to=https://mockbin.org/redirect/302?to=http://mockbin.org/redirect/303?to=http://mockbin.org/redirect/307?to=https://mockbin.org/status/200 -SkipHttpErrorCheck

Invoke-WebRequest https://mockbin.org/redirect/300?to=http://mockbin.org/redirect/301?to=https://mockbin.org/redirect/302?to=http://mockbin.org/redirect/303?to=http://mockbin.org/redirect/307?to=https://mockbin.org/status/200 -SkipHttpErrorCheck -AllowInsecureRedirect

0..5 | ForEach-Object {(Invoke-WebRequest https://mockbin.org/redirect/300?to=http://mockbin.org/redirect/301?to=https://mockbin.org/redirect/302?to=http://mockbin.org/redirect/303?to=http://mockbin.org/redirect/307?to=https://mockbin.org/status/200 -SkipHttpErrorCheck -AllowInsecureRedirect -MaximumRedirection $_).StatusCode}

Some inconsistent behaviours (increase redirects errors, status code 308) are fixed by PR #18536.

LGTM.

@PaulHigin, please review, thanks!

Is something blocking this PR?

Is something blocking this PR?

Yes, holydays :-)
I hope MSFT team will start active work after Jan 1.
Until that I can consider minor style changes and discuss/review code for already triaged issues.

I think that after this PR is merged I can work on fixing #14531, it should be similar.

@Please open new issue in Docs repository and add reference in the PR description.

@please open new issue in Docs repository and add reference in the PR description.

Done


fix: ensure setting /github/workdir as Git safe directory works always

When running super-linter on in a self hosted runner based on Action Runner Controller in K8s container mode the /github/home directory is not neccesarily mounted. But since we expect this directory to exist super-linter fails to set /github/workspace as a Git safe directory:
2024-10-04 17:58:37 [INFO]   Successfully validated GITHUB_WORKSPACE: /github/workspace
2024-10-04 17:58:37 [DEBUG]   Configuring Git safe directories
2024-10-04 17:58:37 [DEBUG]   Set /github/workspace as a Git safe directory
error: could not lock config file /github/home/.gitconfig: No such file or directory
2024-10-04 17:58:37 [FATAL]   Cannot configure /github/workspace as a Git safe directory.

Making sure this directory exists in container image ensures that under no circumstances we can fail - if the action runner provides /github/home it will be mounted over, and if not we provide a directory where git can actually create the new .gitconfig.

Readiness checklist

In order to have this pull request merged, complete the following tasks.
Pull request author tasks

[x] I checked that all workflows return a success.
[X] I included all the needed documentation for this change.
[X] I provided the necessary tests.
[X] I squashed all the commits into a single commit.
[X] I followed the
Conventional Commit v1.0.0 spec.
[X] I wrote the necessary upgrade instructions in the
upgrade guide.
[X] If this pull request is about and existing issue, I added the
Fix #ISSUE_NUMBER or Close #ISSUE_NUMBER text to the description of
the pull request.

Super-linter maintainer tasks

[ ] Label as breaking if this change breaks compatibility with the previous
released version.
[ ] Label as either: automation, bug, documentation, enhancement,
infrastructure.
[ ] Add the pull request to a milestone, eventually creating one, that matches
with the version that release-please proposes in the
preview-release-notes CI job.

One caveat, which I don't know if you want to accept this: hadolint complains about two immediately adjacent RUN statements, however I took the authority to ignore this finding, since both statements do not have any thought in common. If you think these should be rather one statement feel free to tell me, and I'll amend the commit.

Thanks for this PR. I get the idea behind this fix.
What I don't know, is how the runner you mention configures volume mounts.
For example, when using a GitHub-hosted runners, it mounts:

-v "/home/runner/work/_temp/_github_home":"/github/home"
-v "/home/runner/work/super-linter/super-linter":"/github/workspace"

It also passes -e "HOME", but we don't print it in the debug log, so I can only image that it's set to /github/workspace.
The command that's failing is:
git config --global --add safe.directory "${safe_directory}"

The --global option means:
--global
For writing options: write to global ~/.gitconfig file rather than the repository .git/config, write to $XDG_CONFIG_HOME/git/config file if this file exists and the ~/.gitconfig file doesn’t.

All this considered, I think that a more scalable solution might be to creating the ${HOME} directory at runtime if it doesn't exist, rather than creating it when building the image. This way, we don't expect the ${HOME} to always be /github/home. What do you think?

Figuring out how the volumes are mounted was not that easy - it's specified in https://github.com/actions/runner-container-hooks/blob/73655d4639a62f6e4b3d70b5878bc4367c0a436e/packages/k8s/src/k8s/utils.ts#L18
From having run actions both in GitHub.com and with self hosted runners in GitHub enterprise I've never seen a $HOME stray from /github/home. Sadly I have not yet found any documentation declaring it part of the interface.
You might be correct in that creating the home directory when we need it and it does not exist would work, but it requires us to at some point in the duration decide to create it - which means that there is always a time frame before that in which future changes could introduce a new requirement of the homedir. Creating the homedir as part of the container build ensures that it is present - always, and no matter if it is a volume mount.

Thinking and searching a bit more, I now considered the case that even users can override $HOME. Maybe the best would be to do both approaches simultaneously:

make sure that /github/home exists for 99% of the users
test the return code of git config --global --add safe.directory "${safe_directory}", and if it failed check/create a missing homedir and repeat the command.

Digging more I found these:

https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#file-systems
https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#docker-container-filesystem

The document that /github/home is a reserved name and that it is created for docker based actions. However this is only documented for GitHub hosted runners, not for self-hosted runners. For these actions running without docker there is no guarantee for the home directory to have a stable name, this seems to both apply to runners setup manually and via ARC. But for docker-based actions both the manually setup runners and ARC's docker-in-docker mode adhere to what the documentation documents for GitHub-hosted runners. Only ARC's Kubernetes mode seems to deviate - but by still setting $HOME to /github/home, just not mounting a directory there, however that is the most beneficial mode to run a big image like super-linter (benefiting from the image cache of the K8s nodes, storing the image across runs, where the d-in-d needs to pull the image from the registry on every run).

I btw also asked in actions/runner-container-hooks#181 to clarify why this directory does not get mounted in the ARC K8s mode

Thanks for all this research! Let's see where https://github.com/actions/runner-container-hooks/issues/181 leads us.
Creating the directory at build time might make sense as well because it will get overridden by the volume mount, eventually.

Thanks for the suggestion, it's a very good point to make that consistent. I applied it and rebased ontop of the current main branch. The tests still pass nicely

Thanks for working on this!

No problem! I think the latest commit hasn't run in the CI yet.

Sure, I can have a look


Conflict of ReactiveElement properties and native mixin

on the NavigationDrawer there is a property called ariaModal, which has a default value when constructed. This property is also a native mixin see
this does not affect when rendering in dom, but throws Failed to construct 'CustomElement': The result must not have attributes when created programatically
document.createElement('md-navigation-drawer');

ref

Should be fixed now that the aria update is applied


Add statefulset_fully_available and statefulset_not_fully_available

Add statefulset_is_fully_available and statefulset_is_not_fully_available
Signed-off-by: Rodrigo Menezes<EMAIL_ADDRESS>

Hi, is this PR candidate to be added in next release?
Regards


center all images horizontally

@tpimh this was exactly what I needed for my blog. Thanks for contributing :)

You are welcome :)


Update the help prompt for --icon

Description
Creating an app with an icon on Mac OS following the help prompt results in an app with no icon.
As #53 recommends to use a PNG on Mac OS too, the help prompt should be updated to reflect that.
Steps to reproduce issue

Following the filetype advice in the help prompt:
-i, --icon <value>              the icon file to use as the icon for the app (should be a .icns file on OSX, .png for Windows and Linux)
I created a .icns file for my nativefier app.

Generating the app with nativefier --name "foo" "https://foo.bar" -i icon.icns creates an app with no icon.

Searching for a workaround, I saw in #53 that one should use PNG files for icons regardless of the platform.

Indeed, using a PNG file instead solved the error.

Details

[x] Are you nativefying a public website?
[ ] Feature request? No, docs update
Full nativefier command used to build your app: nativefier --name "foo" "https://foo.bar" -i icon.icns
[x] Version of Nativefier (run nativefier --version): 7.5.4
[x] Version of node.js (run node --version): v6.3.1
[x] OS: Mac OS
[] Error message / stack trace (if any):

@PLNech thanks for the feedback! Sure. Would you try submitting a PR? See #444 for inspiration, there should be just two files to amend :)

@ronjouch sure! See PR #502. I checked the several files changed in #444, but as far as I understand only src/cli.js had to be modified (docs/api.md didn't need changes either).


Fix deprecation warning in test

Fixes the following deprecation warning:

(node:1064250) [DEP0147] DeprecationWarning: In future versions of Node.js, fs.rmdir(path, { recursive: true }) will be removed. Use fs.rm(path, { recursive: true }) instead

Thanks!


Selene does not see element that is under iframe

I have an element that is nester under iframe. I could not find possibility to interact with iframe, or switch to it. Can someone track me how to do it?
Thanks!

Ok, fixed:
browser.driver().switch_to.frame('id_of_iframe') worked for me ;)

Closing!


adding common test framework basics

Pulls code from the main community repo for the framework for functional
integration testing in Python. Adds some basic infrastructure and docs
for setting up a local development environment (for developing
test-infra itself).

@A-Hilaly @RedbackThomson @vijtrip2 OK, so this PR just pulls in some very basic infrastructure from the community repo for a testing framework. Doesn't include the bootstrap/cleanup/conftest.py files yet so isn't functional but this is just to get ideas on splitting out the framework that we can then use in individual service controller repositories (as a Python requirement/dependency)


fix(build): fix arm64 build

Fix build on arm64 platform. Intel-ipsec-mb lib is only specific to
x64_64 platform.
And Mayastor can run on arm64 now, not just x86_64.
Signed-off-by: Xinliang Liu<EMAIL_ADDRESS>This PR is related to Mayastor arm64 support: https://github.com/openebs/mayastor/issues/1063

Ping

bors merge