Losing dataSource on ResolveDataSource

Hi,
I'm trying to use this package, using rockets-starter to understand it.
Each time I try to seed datas, I have this error message :
Cannot read properties of undefined (reading 'name')     at new DataSource (/Users/piman/Sites/manitude/node_modules/typeorm/data-source/DataSource.js:46:29)     at Object.resolveDataSource (/Users/piman/Sites/manitude/node_modules/@concepta/typeorm-seeding/dist/utils/resolve-data-source.js:8:90)
It seems that the object dataSource from 'this.options' is not accessible inside of the resolveDataSource function, even through it exists in the get dataSource()'s function of the seeding-source.js;
Or maybe I'm not creating my seedingSource object correctly.
seeding.ts
import { ApiConfigService } from "./common/api-config/api.config.service";

const { config } = require('dotenv');
const { SeedingSource } = require('@concepta/typeorm-seeding');
const { AppSeeder } = require('./app.seeder');
const { default: DataSource } = require('./ormconfig');

config();

const options = {
  DataSource,
  seeders: [AppSeeder],
  defaultSeeders: [AppSeeder],
}

module.exports =  new SeedingSource(options);

ormconfig.ts
import { DataSource } from 'typeorm';
import { ormConfigFactory } from './common/api-config/typeorm.config';

const source = new DataSource({
  ...ormConfigFactory()
});

export default source;

typeorm.config.ts
import { DataSourceOptions } from 'typeorm';
import { registerAs } from '@nestjs/config';

export const ormConfigFactory = (): DataSourceOptions => {
  return {
    migrationsTableName: 'migrations',
    name: 'default',
    type: 'mysql',
    host: 'localhost',
    port: 3306,
    username: 'myname',
    password: 'mypassword',
    database: 'mydb',
    logging: false,
    synchronize: false,
    entities: ['src/endpoints/**/**.entity{.ts,.js}'],
    migrations: ['dist/migration/**/*{.ts,.js}'],
  };
};

export const ormConfig = registerAs('TYPEORM_MODULE_CONFIG', ormConfigFactory);

plackage.json scripts
"seed:config": "typeorm-seeding config -r ./dist -c src/seeding.js",
    "seed:run": "typeorm-seeding seed -r ./dist -c src/seeding.js"

I apologize for not responding, I was out on vacation and I am just catching up. Did you ever find the solution on your own, or do you still need help?

Hi, i switched to an older version of type-orm
If you find the solution it could be great


tsconfig.json is not being taken in consideration

Visual Studio just stops taking in consideration the tsconfig.json file. I don't have exact steps to reproduce it, but I think it happens once I rename a folder in the project. I'm attaching a screenshot with the result and the options in tsconfig.json

VSCode Version: Version 1.5.3 (1.5.3)
OS Version: MacOS 10.12 (16A323)

There are no indicators of any errors, but there were previously:

Thanks,

One more addition here: it looks that if the file is next to tsconfig.json (in the same folder), it will be processed, but if it is in a subfolder, the rules will be ignored.

@ipeychev thank you for opening this issue. Can you share your tsconfig.json file?

Yes, I attached it with the screenshot, not sure why is it not here. Here is it again:
tsconfig.json.zip

And one more comment (hint):
Angular cli setups a project in such a way, that there are two tsconfig.json. One in the main (root) directory and one in the src directory. I looks like if the file in src directory is missing, this is confusing the IDE.

@ipeychev nothing obvious from the tsconfig.json file. Can you share your workspace?

I don't have workspace settings, but once I added tsconfig.json to the src folder too, it started to work properly, so I'm going to close this issue.
Thanks,


docs: fixed wrong link in zarf site nerd notes page

Description
Link in nerd notes points to the wrong issue.  375 currently points to 376.  Fixed it so it points to the right issue that has the discussion mentioned in the bullet.
...
Checklist before merging

[x] Test, docs, adr added or updated as needed
[x] Contributor Guide Steps followed

Hey - you'll need to rebase and sign your commits with an SSH or GPG key! :)


Markdown id's

How can I add ID's to elements? so that if I click on a link it will link to the part of the page where an element has that id. similar to github readme's?

found a work around :)

can you please provide a solution?

@pleerock See here: https://github.com/rexxars/react-markdown/issues/69


[Add] SQLite database support. Dockerfile. GitHub workflows.

Description
initial version
Checklist

[x] Your code works
[x] The changes are cool
[x] The version is bumped


Sounds

What about sounds on CD complete and sounds on preCD (like beep when remained 2 or 3 or 4 sec)?

I don't think I'm going to add that. It could get annoying and I'm not planning to add any sound for now.


Branch event command

Codecov Report

Merging #64 (41237bc) into master (ada03c9) will decrease coverage by 8.64%.
The diff coverage is 10.67%.

@@             Coverage Diff              @@
##             master      #64      +/-   ##
============================================
- Coverage     65.24%   56.59%   -8.65%
- Complexity      491      498       +7
============================================
  Files            95      106      +11
  Lines          1801     2115     +314
  Branches        218      262      +44
============================================
+ Hits           1175     1197      +22
- Misses          555      841     +286
- Partials         71       77       +6

Impacted Files
Coverage Δ

...ava/seedu/address/logic/commands/EventCommand.java
0.00% <0.00%> (ø)

.../seedu/address/logic/parser/AddressBookParser.java
80.00% <0.00%> (-4.22%)
:arrow_down:

...seedu/address/logic/parser/EventCommandParser.java
0.00% <0.00%> (ø)

...in/java/seedu/address/logic/parser/ParserUtil.java
47.05% <0.00%> (-12.21%)
:arrow_down:

.../main/java/seedu/address/model/event/DateTime.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/model/event/Event.java
0.00% <0.00%> (ø)

...main/java/seedu/address/model/event/EventName.java
0.00% <0.00%> (ø)

...in/java/seedu/address/model/event/Information.java
0.00% <0.00%> (ø)

...odel/event/exceptions/DuplicateEventException.java
0.00% <0.00%> (ø)

...model/event/exceptions/EventNotFoundException.java
0.00% <0.00%> (ø)

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ada03c9...41237bc. Read the comment docs.


CaptureLog and Audit Log Implementation

I am a little bit confused here, and apologize for this being discussed before but I have some questions about the Logging capabilities of Serenity and how best to implement them. I would like to be able to prevent users from deleting information from the database and only show active rows. Additionally, I want to be able to log all insert/update operations. The key here is, I would also like to see the before/after changes of the fields that are updated/deleted. I've looked at the samples for implementing an abstract base class like LoggingRow.cs from Northwind sample, and also looked at the sample in Serene for using [CaptureLog(typeof(SampleLogRow))]. The crux of the issue then, is whether I can and/or should implement both of these systems or just one of them. If I do implement [CaptureLog(...)] attribute for a Row, do I have to create a separate LogRow table for each Entity that I have in my project? Also, if I were to implement CaptureLog, do I need to implement IDeleteLogRow and IIsActiveDeletedRow interfaces as well to prevent deletes, or does that provide the same behavior?
I have created my own abstract base class that implements ILoggingRow, IDeleteLogRow, and IIsActiveDeletedRow like so:
namespace FlowState.Operations.Entities
{
    using Serenity.ComponentModel;
    using Serenity.Data;
    using Serenity.Data.Mapping;
    using System;

    public abstract class OpsLoggingRow : Row, ILoggingRow, IDeleteLogRow, IIsActiveDeletedRow
    {
        protected OpsLoggingRow(RowFieldsBase fields)
            : base(fields)
        {
            opsLoggingFields = (OpsLoggingRowFields) fields;
        }

        [NotNull, Insertable(false), Updatable(false)]
        public Int32? InsertUserId
        {
            get { return opsLoggingFields.InsertUserId[this]; }
            set { opsLoggingFields.InsertUserId[this] = value; }
        }

        [NotNull, Insertable(false), Updatable(false)]
        public DateTime? InsertDate
        {
            get { return opsLoggingFields.InsertDate[this]; }
            set { opsLoggingFields.InsertDate[this] = value; }
        }

        [Insertable(false), Updatable(false)]
        public Int32? UpdateUserId
        {
            get { return opsLoggingFields.UpdateUserId[this]; }
            set { opsLoggingFields.UpdateUserId[this] = value; }
        }

        [Insertable(false), Updatable(false)]
        public DateTime? UpdateDate
        {
            get { return opsLoggingFields.UpdateDate[this]; }
            set { opsLoggingFields.UpdateDate[this] = value; }
        }

        [Insertable(false), Updatable(false)]
        public Int32? DeleteUserId
        {
            get { return opsLoggingFields.DeleteUserId[this]; }
            set { opsLoggingFields.DeleteUserId[this] = value; }
        }

        [Insertable(false), Updatable(false)]
        public DateTime? DeleteDate
        {
            get { return opsLoggingFields.DeleteDate[this]; }
            set { opsLoggingFields.DeleteDate[this] = value; }
        }

        [Insertable(false), Updatable(false)]
        public Int16? IsActive
        {
            get { return opsLoggingFields.IsActive[this]; }
            set { opsLoggingFields.IsActive[this] = value; }
        }

        IIdField IInsertLogRow.InsertUserIdField
        {
            get { return opsLoggingFields.InsertUserId; }
        }

        IIdField IUpdateLogRow.UpdateUserIdField
        {
            get { return opsLoggingFields.UpdateUserId; }
        }

        IIdField IDeleteLogRow.DeleteUserIdField
        {
            get { return opsLoggingFields.DeleteUserId; }
        }

        DateTimeField IInsertLogRow.InsertDateField
        {
            get { return opsLoggingFields.InsertDate; }
        }

        DateTimeField IUpdateLogRow.UpdateDateField
        {
            get { return opsLoggingFields.UpdateDate; }
        }

        DateTimeField IDeleteLogRow.DeleteDateField
        {
            get { return opsLoggingFields.DeleteDate; }
        }

        Int16Field IIsActiveRow.IsActiveField
        {
            get { return opsLoggingFields.IsActive; }
        }

        private OpsLoggingRowFields opsLoggingFields;

        public class OpsLoggingRowFields : RowFieldsBase
        {
            public Int32Field InsertUserId;
            public DateTimeField InsertDate;
            public Int32Field UpdateUserId;
            public DateTimeField UpdateDate;
            public Int32Field DeleteUserId;
            public DateTimeField DeleteDate;
            public Int16Field IsActive;

            public OpsLoggingRowFields(string tableName)
                : base(tableName)
            {
            }
        }
    }
}

If I were to use this interface on a Row, and also provide a [CaptureLog(...)] attribute, would there be redundant information between the CaptureLogRow table and the Row table itself? Thank you for clarifying things for me!

You don't need to implement both IDeleteLogRow and IIsActiveDeleteRow but having both won't hurt anything. I know some users that does this.
If you want to store who deleted row in a separate field, implement IDeleteLogRow.
There is also another possibility. You may have just IUpdateLogRow and IIsActiveDeletedRow in your row, so Update log fields will be used for Insert/Update/Delete.
This is about personal preference. Some want 7 fields, some want 3, some want none.
CaptureLog will only log matching fields in your capture log table. Capture log row already has ChangingUserId (Insert/Update/Delete) and ChangeDate (ValidFrom) fields so you don't have to add these other log fields to capture table if you don't want redundancy. If you do CaptureLog will log them as is.
A little nuance is, unlike ordinary fields, when you update a record and only its UpdateDate changes, capture log won't record that change at all. This is to keep log size minimum for users that presses Save button to close dialogs without changing anything :|

Thank you very much for your clarification @volkanceylan , I think I will be using your suggestion about IUpdateLogRow and IIsAciveDeletedRow. I will also be using CaptureLogRow to capture the changed fields.
To make sure I'm doing this the right way:

Implement interfaces for IUpdateLogRow and IIsActiveDeletedRow on my OpsLoggingRow abstract class like this:

// ...
public abstract class OpsLoggingRow : Row, IUpdateLogRow, IIsActiveDeletedRow
{ ... }

Create and run migrations for adding the UpdateUserId, UpdateDate and IsActive fields to each table to satisfy the interface contracts.
Create and run a migration to create CaptureLog tables for each EntityRow that I want CDC enabled for.
Attribute each EntityRow with [CaptureLog(typeof(someEntityRow))] above the class declaration like so:

// ... other attributes omitted for brevity
[CaptureLog(typeof(WorkloadCaptureRow))]
public sealed class WorkloadRow : OpsLoggingRow, IIdRow, INameRow

Thank you very much for all your help. Once I get this implemented properly, I'll add to the Wiki my (sanitized) code for others to emulate.

You're welcome. Make sure you add IsActive field to your capture log table too, otherwise you won't see "virtual deletes" in capture log as capture log only logs actual deletes. Virtual deletes, e.g. setting IsActive to -1, is logged as an update. CaptureLog is closer to database level logging.

Thank you for helping and clearing this up for me. I'll post code if I can get this plan to implement a change log viewer for all entities up and running.

Hi John, were you able to complete your change log viewer? If so, could you please tell me where I can find the code?
Thanks,
Sanji

No not yet. I've gotten behind with other work, but my plan is to use SignalR along with possibly RxJS on the client side in order to see changes in real-time with filtering/sorting. I'll keep you posted though, maybe you can help with the code if I get stuck

Thanks John, I’ll be monitoring the issues page,
Sanji
From: John Bissonette<EMAIL_ADDRESS>Sent: Wednesday, June 08, 2016 5:17 PM
To: volkanceylan/Serenity
Cc: Sanjeevan, Kanapathipillai (ITSD-ADSB-RCSS-RAS)@CDPH; Manual
Subject: Re: [volkanceylan/Serenity] CaptureLog and Audit Log Implementation (#429)
No not yet. I've gotten behind with other work, but my plan is to use SignalR along with possibly RxJS on the client side in order to see changes in real-time with filtering/sorting. I'll keep you posted though, maybe you can help with the code if I get stuck
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/volkanceylan/Serenity/issues/429#issuecomment-224769285, or mute the threadhttps://github.com/notifications/unsubscribe/AP5yuhW-N0OnoC9haMtDpuCKofYhpQKDks5qJ1uGgaJpZM4Hzg-v.


manifest: Explicitly unspecified attributes for the initial layer directory

Point out that the layer's initial empty directory has unspecified attributes.  Layer authors interested in the ownership and other attributes of the unpacked root directory should explicitly set an entry for it.
Spun off from #318 to focus on a single point.

LGTM

LGTM


Password cannot be entered

the command
walletpassphrase "my pass" 120
does not longer work and end up with:
"JSON value is not an integer as expected"
I will recover my seed using the mnemoric key. But wanted to state this problem before. Attached the log file
Applog.txt.log

Exactly the same Problem here. I notice after command entring and switch back with the Arrow Keys to move the cursor back, that it Jumps. Like there is a special character between the lines. This normal indicates a Copy Past issue, bit the issue allso appear when type the command in. I try to create a GIF to illustrate that more.
https://imgflip.com/gif/4veteg
Also add the Pictures.

I'm 100% shure that there is a space between the pass and the digit.

Exactly the same Problem here. I notice after command entring and switch back with the Arrow Keys to move the cursor back, that it Jumps. Like there is a special character between the lines. This normal indicates a Copy Past issue, bit the issue allso appear when type the command in. I try to create a GIF to illustrate that more.
https://imgflip.com/gif/4veteg
Also add the Pictures.

I'm 100% shure that there is a space between the pass and the digit.

Did you succeed to open the wallet?
Anyways too late about to recover it in full...":(

Did you succeed to open the wallet?
Anyways too late about to recover it in full...":(

Same here. More bugs are coming after updates :(

Same here. More bugs are coming after updates :(

Had the same problem, deleted the app version 2.1.13 on my Mac. Downloaded app release 2.1.12 (from official GitHub) again and now I can send the rewards back to cake.

Had the same problem, deleted the app version 2.1.13 on my Mac. Downloaded app release 2.1.12 (from official GitHub) again and now I can send the rewards back to cake.

Had the same problem, deleted the app version 2.1.13 on my Mac. Downloaded app release 2.1.12 (from official GitHub) again and now I can send the rewards back to cake.

Thanks, worked for me as well.

Had the same problem, deleted the app version 2.1.13 on my Mac. Downloaded app release 2.1.12 (from official GitHub) again and now I can send the rewards back to cake.

Thanks, worked for me as well.

Same here, running the wallet on MacOS Catalina. The wallet suggests to back up before the update, however no such backup is created that could be restored.

Same here, running the wallet on MacOS Catalina. The wallet suggests to back up before the update, however no such backup is created that could be restored.

Hi @salomonkarsten , thanks for your feedback, please give us time to investigate this issue. Thank you.
Hi @kyoungrok0517 @tame81 @Surfer88 could you send your logs please? Thank you.

Hi @dell1503 , thanks for your feedback on the jump, the team is aware of this, it's irrelevant to the original issue. Rest assured that your feedback has been sent to the team. Thank you for your valued feedback.

Hi @salomonkarsten , thanks for your feedback, please give us time to investigate this issue. Thank you.
Hi @kyoungrok0517 @tame81 @Surfer88 could you send your logs please? Thank you.

Hi @dell1503 , thanks for your feedback on the jump, the team is aware of this, it's irrelevant to the original issue. Rest assured that your feedback has been sent to the team. Thank you for your valued feedback.

@tame81 @izzycsy
Yes another issue. If any passwortgeschützt is set the walletbackup file is empty. But I guess is another issue.
Cheers

@tame81 @izzycsy
Yes another issue. If any passwortgeschützt is set the walletbackup file is empty. But I guess is another issue.
Cheers

Hi @salomonkarsten @kyoungrok0517 @dell1503 @Surfer88 @tame81 , update v2.1.15 is out.
Do give a thumbs up to this comment if your issue has been resolved, otherwise, you may reopen this issue with new information (include screenshots) and app logs. Thank you.

Hi @salomonkarsten @kyoungrok0517 @dell1503 @Surfer88 @tame81 , update v2.1.15 is out.
Do give a thumbs up to this comment if your issue has been resolved, otherwise, you may reopen this issue with new information (include screenshots) and app logs. Thank you.


Language services formatting for else on newline

Search Terms

format else
formatted else
fomatter newline
formatting newline

Suggestion
When the formatting option for the opening brace on newline for control blocks is true, it would make sense to have the else on it's online as well.
Use Cases
Using typescript-formatter with VS Code, and from command line.
Examples
My tsfmt.json is:
{
    "baseIndentSize": 0,
    "indentSize": 4,
    "tabSize": 4,
    "indentStyle": 2,
    "newLineCharacter": "\n",
    "convertTabsToSpaces": true,
    "insertSpaceAfterCommaDelimiter": true,
    "insertSpaceAfterSemicolonInForStatements": true,
    "insertSpaceBeforeAndAfterBinaryOperators": true,
    "insertSpaceAfterConstructor": false,
    "insertSpaceAfterKeywordsInControlFlowStatements": true,
    "insertSpaceAfterFunctionKeywordForAnonymousFunctions": false,
    "insertSpaceAfterOpeningAndBeforeClosingNonemptyParenthesis": false,
    "insertSpaceAfterOpeningAndBeforeClosingNonemptyBrackets": false,
    "insertSpaceAfterOpeningAndBeforeClosingNonemptyBraces": true,
    "insertSpaceAfterOpeningAndBeforeClosingTemplateStringBraces": false,
    "insertSpaceAfterOpeningAndBeforeClosingJsxExpressionBraces": false,
    "insertSpaceAfterTypeAssertion": false,
    "insertSpaceBeforeFunctionParenthesis": false,
    "insertSpaceBeforeTypeAnnotation": false,
    "placeOpenBraceOnNewLineForFunctions": true,
    "placeOpenBraceOnNewLineForControlBlocks": true
}

I get results like this:
if(condition)
{
     console.log('condition true');
} else if(otherCondition)
{
     console.log('other condition is true');
} else
{
     console.log('condition not true');
}

For people using "placeOpenBraceOnNewLineForControlBlocks": true, the expected behaviour (IMHO) would be:
if(condition)
{
     console.log('condition true');
}
else if(otherCondition)
{
     console.log('other condition is true');
}
else
{
     console.log('condition not true');
}

Checklist
My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

We are facing the same issue, as reported here and was directed to here by the visual studio code team: https://github.com/microsoft/vscode/issues/111829

Many years have passed. Still nothing.
Not only 'else' is affected but also 'catch' in try-catch blocks.


fix for amax_and_scale_update when reduce_amax=False

FP8GlobalStateManager doesn't have the amax_and_scale_update method. It's probably a typo

/te-ci


nicer TCM properties renderer

add a checkbox to tcm properties entries like github does:

on hover change bg color.

DONE

also applies to any MyList (special treatment of yet selected hovering)
decided not to render ticks on the left side if selected (or simply use a JCheckBox and always render, most intuitiv ui component as well known, but not as good looking).
reason: less is more :)


chore: react apps toolkit npm audit fix [EXT-5924]

Run npm audit fix to address vulnerabilities. Specifically, this will resolve alert #86 as well as vulnerabilities with micromatch and semver packages.

not totally sure, but could be useful to re-run audit fix after merging 2191

I rebased and re-ran npm audit fix and there were no additional changes, so we are good to go 👍


Release 3.0.6

Bumped up release version to 1.0.0.

We should create a release tag after this is merged into master.


Specific richtext links

This PR extends the existing PR: https://github.com/wagtail/wagtail/pull/3425
I added a testcase for rewriting links in the richtext editor

Merged in 6aea6a68569d5df002c901c4e1bca0591078c46f

Thanks @huubbouma, been a busy few weeks.


[docker][TNX] Upgrade to 2.17.0 SDK

Description
Upgrade TNX container to 2.17.0 SDK

If this change is a backward incompatible change, why must this change be made?
Interesting edge cases to note here

possibly upgrade optimum neuron as well

possibly upgrade optimum neuron as well

Optimum will follow separately - optimum changed the way that they save model artifacts and it will be a more involved PR.


FlutterDriver: no way to wait until a screenshot is ready

Collecting a screenshot with driver.screenshot() after calling driver.waitUntilNoTransientCallbacks()  doesn't guarantee that the current frame's display list will have reached the GPU before the screenshot is taken.

I am going to use https://github.com/flutter/flutter/pull/12896 as a non-ideal but hopefully good enough solution for this.


Expose functionality to get peer credentials for a Unix socket on Linux

Caveat: I put this rather randomly in unix/notbsd/linux/other/mod.rs. I know nothing about mips and musl, and I have no idea if this thing also applies to Android. I would guess "yes", but I don't know how to go about testing that assumption. Superficial googling seems to indicate that the constant and struct in question are present in android linux.
Further work: There is a roughly corresponding getsockopt for freebsd and osx (and possibly more bsds?) called LOCAL_PEERCRED. It would be neat to have that supported as well.

Usage example:
extern crate libc;
extern crate unix_socket;

use std::mem;
use std::io::{self, Write};
use std::os::unix::io::AsRawFd;
use unix_socket::{UnixStream, UnixListener};

fn get_peer_credentials(stream: &UnixStream) -> io::Result<libc::ucred> {
    let fd = stream.as_raw_fd();

    unsafe {
        let mut credentials: libc::ucred = mem::zeroed();
        let mut size = mem::size_of::<libc::ucred>() as libc::socklen_t;
        match libc::getsockopt(
                fd,
                libc::SOL_SOCKET,
                libc::SO_PEERCRED,
                &mut credentials as *mut _ as *mut _,
                &mut size as *mut _ as *mut _
        ) {
            val if val < 0 => Err(io::Error::last_os_error()),
            _ => Ok(credentials)
        }
    }
}

fn main() {
    let listener = UnixListener::bind("socket").unwrap();
    println!("Connect to `socket` with for example: nc -U socket");

    for maybe_stream in listener.incoming() {
        let stream = maybe_stream.unwrap();
        let ucred = get_peer_credentials(&stream).unwrap();
        println!("Connected with user {} from process {}", ucred.uid, ucred.pid);
        writeln!(&stream, "Hello {}!", ucred.uid).unwrap();
    }
}

To the failing AppVeyor build, this fails similarly to how it fails on master (doesn't find kernel32.lib), which is probably, and should definitely be, unrelated to this pull request :) (But you probably already realized)

Thanks!


(Bug) Owner can't open manage page

Tested with https://github.com/poanetwork/token-wizard , branch 2.0,
commit 36a6446
Steps:
1.Create 2 tiers crowdsale: allow modify, 1 whitelisted address for each tier
2. Open manage page as a owner and observe
Expected result:

owner should be allowed to see crowdsale parameters on manage page

Actual result :

no crowdsale parameters presents for owner
manage page has regular view for others accounts

Exec ID 0xde86e42acb80985cc6dbb47e231825bb070d140ccce4a27363db55ffb398e430
If you are reporting a problem with Token Wizard, please include the following information:
Which network did you use? (Mainnet, Kovan, Rinkeby, etc.)
Ropsten
If you were able to create it, what is the URL of your crowdsale?
Exec ID 0xde86e42acb80985cc6dbb47e231825bb070d140ccce4a27363db55ffb398e430
Do you have screenshots showing the problem?

Do you see errors in the dev console? If yes, please include a screenshot
logOwner.log

Also reproducible with parameters:
{
"name": "TestSuite2.json",
"ticker": "test2",
"decimals": 18,
"reservedTokens":[
{
"address" :"0xecDFec71AbCD5a612eAf9169B19E907eAA2717d9",
"dimension": "percentage",
"value": 250
},
{
"address" :  "0x56B2e3C3cFf7f3921Dc2e0F8B8e20d1eEc29216b",
"dimension": "tokens",
"value":100000000
}
],
"walletAddress":"0x56B2e3C3cFf7f3921Dc2e0F8B8e20d1eEc29216b",
"gasprice": 1,
"mincap": 1,
"whitelisting":true,
"tiers":[
{
"name":"###1",
"allowModify": true,
"startDate": "01/01/2030",
"startTime": "01:11",
"endDate":"01/01/2031",
"endTime":"02:22",
"rate":20000,
"supply": 250,
"whitelist":[
{
"address": "0xF16AB2EA0a7F7B28C267cbA3Ed211Ea5c6e27411",
"min": 50,
"max": 150
}
]
}]
}

@dennis00010011b I am able to see management page for exec-id 0xde86e42acb80985cc6dbb47e231825bb070d140ccce4a27363db55ffb398e430 without errors:

Could you try it once more from 2.0 branch?
Also, I've created another crowdsale with the similar parameters (exec-id: 0xd8c48a00822ea00f427e0a185f19f8a44729dfb50734804cc4c8f1dc18851299). And I have no issues with it too.

@vbaranov I can't reproduce it now with branch 2.0


InlineQueryResultGame Not recognized

Steps to reproduce
InlineQueryResultGame  is not recognized as a class.
Expected  behavior
Actual behavior
Environment data
NuGet Package Version: 10.4.0
.NET Version: .NET Framework 4.6.2
IDE: VS2015
App: WEB API

Issue resolved with pre-release nuget package

Btw, that type inherits stuff that doesn't really belong to it as per documentations.


Snapping

Issue #14

Extracted defaults

@RareScrap I have scanned your code so far, I have some possible options that can deal with your situation.
For scroll strategies other than ExitUntilCollapsed, they need to modify offsetY which is a member of CollapsingToolbarScaffoldState. The cause derives from the fact that snap behavior is actually a feature of CollapsingToolbarScaffold. I expect the problem would be fixed if you move the snapping methods to ScaffoldState.
And for interrupting animation with user inputs, I think it may be solved by utilizing MutatePriority though it may need some extra researches.

Thank you for your review. I was little busy last weekend. Will done with PR at this weekend.

Great!

There are many TODOs that require your attension. Please comment on each of them so we can discuss them.

Thank you for reminding, I will review it until this weekend!

@onebone what are the plans for merging this PR?

There is a bug in it. I will describe it tomorrow.

Sorry guys, I was too busy to done with it but now I have some time :)

Rooting for that snapping guys! :)

Hi, I created a newer version of the snapping feature here: https://github.com/onebone/compose-collapsing-toolbar/pull/83
PR contains the recorded gifs and you can test it by yourself. For me, it seems like everything is working fine.


Return None when format_code_block may have failed

MacroBranch::rewrite() assumes that when format_code_block() returns Some(s), then s is a correctly formatted code block. Currently this is not the case, format_code_block() may return Some(s) even if if has failed to format the code. This PR tries to fix it by checking the width of each line and if it is not exceeding the max width.
Closes  #2438.

Looks good, but needs rebasing.

Rebased against the master.


Preferences panel

Would be nice to have a preferences panel to do things like:

set a night mode
turn sound effects on and off

The panel could be accessed by a wrench icon that is placed somewhere in a corner.


Next 9105/wrong payment snippet when rabate is added

1. Why is this change necessary?
Display the translated notice instead of snippet key
2. What does this change do, exactly?
Display proper text instead of shippet:

3. Describe each step to reproduce the issue or behaviour.
Steps to reproduce:

Setup shopping cart rule with a. payment type condition
Create a discount applied when rule is valid
Add item to shopping cart, select payment method
(copied from original ticket https://github.com/shopwareBoostDay/platform/issues/40)

4. Please link to the relevant issues (if any).
https://github.com/shopwareBoostDay/platform/issues/40
5. Checklist

[ ] I have written tests and verified that they fail without my change
[X] I have squashed any insignificant commits
[ ] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[ ] I have read the contribution requirements and fulfil them.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.5 out of 13 committers have signed the CLA.:white_check_mark: felixbrucker:white_check_mark: shyim:white_check_mark: t2oh4e:white_check_mark: jleifeld:white_check_mark: soebbing:x: Agreon:x: pantrtxp:x: art4webs:x: muehlhansf:x: belendel:x: PaddyS:x: yannick80:x: rob-webweitYou have signed the CLA already but the status is still pending? Let us recheck it.


Feature/2502 rebrand blui

Fixes PXBLUE-2502 .

Changes proposed in this Pull Request:

[X] @pxblue => @brightlayer-ui

[X] PX Blue => Brightlayer UI

[X] PXBlueColor => BLUIColor

[X] pxb => blui

[X] pxb-blue => brightlayer-ui

[X] PXBlueColor => BLUIColor

[X] pxb-tag => blui-tag

[X] RNPXBVectorIcons => RNBLUIVectorIcons

[X] addPXBlue => addBLUI

[X] addPXBlueIonic => addBLUIIonic

Will raise it again after react-cli, react-native-cli packages available .


vdk-impala: Add validation for queries that doesn't provide lineage info

Why?
Checking for lineage information is gathered from the profile making one more request to the impala server, which in some point the number of requests might be huge, and there might not be any lineage data at all.
What?
Previously there was just a validation for keep-a-live connections. Current commit is adding fine validation also if query is of DCL or some DDL type (REFRESH, COMPUTE, EXPLAIN, etc) which could be frequently used in a data jobs and leading to a huge load on the impala server.
How has this been tested?
Unit and integration tests, also with production-grade queries
What type of change are you making?
Improvement
Signed-off-by: Plamen Kostov<EMAIL_ADDRESS>

The Codacy static code analysis error seems unrelated, impala support COMPUTE stats

@tozka Could you merge this PR?
Thanks!

I had not noticed that htis is a fork. Currently we do not accept PR from forks unless they do not require tests (e.g doc or examples contribution).
Please join VMware organization in Github. You can do it form here: https://upstreamcontrib.eng.vmware.com/oss
Then I will add you as contributor. And you will need to report the PR from a branch instead of a fork.

I've joined the vmware organization

I added you as a contributor. Create a new PR from a branch, and you will be able to merge it.


npm install fails with "The subcommand '../generate' wasn't recognized"

npm install is failing for me on windows
gyp info spawn C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Current\Bin\MSBuild.exe
gyp info spawn args [
gyp info spawn args   'build/binding.sln',
gyp info spawn args   '/clp:Verbosity=minimal',
gyp info spawn args   '/nologo',
gyp info spawn args   '/p:Configuration=Release;Platform=x64'
gyp info spawn args ]
Building the projects in this solution one at a time. To enable parallel build, please add the "-m" switch.
  generated parser
CUSTOMBUILD : error : The subcommand '../generate' wasn't recognized [C:\Users\gsuuon\code\gsuuon\forks\tree-si
tter-fsharp\build\tree_sitter_fsharp_binding.vcxproj]
        Did you mean 'generate'?

  If you believe you received this message in error, try re-running with 'tree-sitter.exe -- ../generate'

      tree-sitter.exe <SUBCOMMAND>

  For more information try --help
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.tar
gets(241,5): error MSB8066: Custom build for '..\grammar.js' exited with code 1. [C:\Users\gsuuon\code\gsuuon\f
orks\tree-sitter-fsharp\build\tree_sitter_fsharp_binding.vcxproj]

If I remove the generate on install:
diff --git a/binding.gyp b/binding.gyp
index 20c4fe5..99bb1cb 100644
--- a/binding.gyp
+++ b/binding.gyp
@@ -14,15 +14,6 @@
       "cflags_c": [
         "-std=c99",
       ],
-      'actions': [
-        {
-          'action_name': 'generate parser',
-          'inputs': ['grammar.js'],
-          'outputs': ['src'],
-          'action': ['tree-sitter', 'generate'],
-          'message': 'generated parser'
-        }
-      ],
     }
   ]
 }

I get error LNK2001: unresolved external symbol tree_sitter_YOUR_LANGUAGE_NAME:
gyp info spawn C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Current\Bin\MSBuild.exe
gyp info spawn args [
gyp info spawn args   'build/binding.sln',
gyp info spawn args   '/clp:Verbosity=minimal',
gyp info spawn args   '/nologo',
gyp info spawn args   '/p:Configuration=Release;Platform=x64'
gyp info spawn args ]
Building the projects in this solution one at a time. To enable parallel build, please add the "-m" switch.
  binding.cc
  parser.c
  scanner.cc
  win_delay_load_hook.cc
     Creating library C:\Users\gsuuon\code\gsuuon\forks\tree-sitter-fsharp\build\Release\tree_sitter_fsharp_bin
  ding.exp
binding.obj : error LNK2001: unresolved external symbol tree_sitter_YOUR_LANGUAGE_NAME [C:\Users\gsuuon\code\gs
uuon\forks\tree-sitter-fsharp\build\tree_sitter_fsharp_binding.vcxproj]
C:\Users\gsuuon\code\gsuuon\forks\tree-sitter-fsharp\build\Release\tree_sitter_fsharp_binding.node : fatal erro
r LNK1120: 1 unresolved externals [C:\Users\gsuuon\code\gsuuon\forks\tree-sitter-fsharp\build\tree_sitter_fshar
p_binding.vcxproj]

Unfortunately this seems like a windows issue, where it parses the generate command in the build step wrong.
Maybe it was fixed by changing the naming in the binding files?
Otherwise, there is not currently much to do about this, other than to add the pre-generated files to another branch

Not sure if you saw this comment but it doesn't look like the pre-built parsers are necessary for using with nvim-treesitter. I'm not sure if they're included for another use-case, but simply removing the build step would unblock using this with nvim on windows

Hi @gsuuon, when I originally experimented with this I could not get the :TSGenerateFromGrammar command to work, since this grammar also requires that the external scanner src/scanner.cc is compiled along with the grammar.
Maybe there is a way around this, but imo the nicest solution would be to setup a ci pipeline generating the parser files on a different branch


Rename RequestMessage to CatalogInventoryTask

The original intention was to remove all wording with mqtt. There are not many remaining except the ones used by mqtt.go which we will keep for a while.
This intention is to rename struct RequestMessage to CatalogInventoryTask because the content comes from catalog inventory's Task table.

@bzwei We have a Request/Response paradigm here so changing it to CatalogInventoryTask we are loosing that. Maybe CloudRequestMessage

CloudRequestMessage is more like MQTTMessage that we are having currently, which represents the request comes via cloud controller. CatalogInventoryTask is a result of direct REST GET from catalog inventory API, so the name is a reflection of the backend model. Is it not?

👍


Fix #233

Purpose
Fix #233
Changes
Apply currency formatting to the Offer Overview. This means prices look natural now (two decimals). Decimal symbol changes to '.' as well.

 Fix issue #233 (currency in offer overview is not displayed correctly)

 Fix issue #233 (currency in offer overview is not displayed correctly)


[WIP] fix: ensure all interop operators are chained correctly

WIP:
https://github.com/ReactiveX/rxjs/pull/5333 is likely a better solution to the problem.

Description:
This PR refactors the fix in #5239 so that it can be applied to all operators - or at least to those that need unsubscription to be chained.
The problem is outlined in the linked issue, but AFAICT the problem is not specific to the finalize operator. For example, the buffer operator's subscriber adds a subscription that depends upon unsubscription being chained correctly:
https://github.com/ReactiveX/rxjs/blob/56e7cebd211d93b9958e1ec508052beb8927604a/src/internal/operators/buffer.ts#L73-L76
And windowTime adds scheduled actions:
https://github.com/ReactiveX/rxjs/blob/56e7cebd211d93b9958e1ec508052beb8927604a/src/internal/operators/windowTime.ts#L189-L206
IMO, all operator subscriptions made within an operator's call method should be made using subscribeAndChainOperator.
ATM, this PR's branch is based on #5239, so it includes that PR's commits. The last two commits are the changes introduced in this PR.
Related issue (if exists): #5239

Closed by https://github.com/ReactiveX/rxjs/pull/5333


write factory.json use utf-8

Description
when I use Hadoop ingestion, some hadoop cluster node did not set system encoding as utf-8, resulting in the following content for factory.json:
:)
^Eú<83>typeQmMapSegmentFactoryû
Historical Node SegmentLoadDropHandler.loadSegment throw JsonParseException, fix this issue by setting write encoding of file.
This PR has:

[x] been self-reviewed.
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[x] been tested in a test Druid cluster.

hmm, I'm confused about why this mattered. In Jackson ObjectMapper, when we do writeValue on an OutputStream, it uses UTF-8. Here is the code from Jackson:
    public void writeValue(OutputStream out, Object value)
        throws IOException, JsonGenerationException, JsonMappingException
    {
        _configAndWriteValue(_jsonFactory.createJsonGenerator(out, JsonEncoding.UTF8), value);
    }

In your case, was this defeated somehow?


feat: add comment-syntax flag

Fixes: #111
Test plan

[ ] Use on something like a python project to do #  as the prefix, instead of //

It checks for the length of the comment syntax provided.


What property to use for schema "contentType"?

I've went trough all schemas again and got confused when I came across the schema for fileRepository. One of the properties is format with count 0 - 1, which confused me. I associated format with file format rather than the actual meaning, which is e.g. to give repository structures such as BIDS. This also explains the coutn of 0 - 1 (which would be weird for file formats since a repository can have files with more than one file format).
So, @lzehl and I talked briefly about it and think we should consider again which properties to use when referring to the schema for contentType. I looked up all the places contentType was referenced and the property used:
metaDataModelVersion --> serializationFormat
metaDataModelVersion --> specificationFormat
modelVersion --> format
softwareVersion --> inputFormat
softwareVersion --> outputFormat
fileRepository --> format
fileBundle --> format
fileInstance --> format
If I am not mistaken, in most cases the association of format with file format actually makes sense except for fileRepository and fileBundle.
Maybe we could find another property name for fileRepository and fileBundle?
@apdavison, @bweyers and @lzehl, what do you think?
@lzehl, did I forget to mention any other questions related to this?

@UlrikeS91 no I think you covered all aspects.
@apdavison & @bweyers : here some options I can think of at the moment:

"dataModel"
"dataModelFormat"
"usedDataStructure"
"fileRepositoryFormat" | "fileBundleFormat"

What do your think? Of course feel free to make a counter suggestion as well.

I don't think this is a problem. We can just keep "format". in @UlrikeS91's example, the contentType of the fileRepository or fileBundle would be something like vnd.bids. Each of the individual files within the repository or bundle can have its own contentType (application/json, for example).

@apdavison : I agree, but we need to be clear in the instructions then. People that are unfamiliar with the concept of data structure formats (such as bids) might assume that "format" should state the formats of the files within that repository/bundle.
Do you have a nice suggestion for such an instruction?

How about "leave blank if this bundle represents just a folder; if the files within the bundle are part of a single entity, such as a BIDS dataset, use the appropriate contentType" ?

Thanks. That helps :) I will maybe switch it around a bit. "single entity" is a bit difficult to understand, maybe
"If files within the bundle are organized and formatted according to a formal data structure use the appropriate contentType. Leave blank otherwise."


Unable to Connect with Power BI Service using PowerShell

I have installed PowerShell for Power BI using following Code.
Install-Module -Name MicrosoftPowerBIMgmt
It is installed successfully.

Now, I used following code-snippet to connect with Power BI Service.
Login-PowerBI
When I executed the code it shows me an error like:
Login-PowerBI : The 'Login-PowerBI' command was found in the module 'MicrosoftPowerBIMgmt.Profile', but the module  could not be loaded. For more information, run 'Import-Module MicrosoftPowerBIMgmt.Profile'. At line:1 char:1 + Login-PowerBI`
+ ~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (Login-PowerBISmiley Frustratedtring) [], CommandNotFoundException
    + FullyQualifiedErrorId : CouldNotAutoloadMatchingModule`
![screenshot_4](https://user-images.githubusercontent.com/41663430/43937993-d5198450-9c7e-11e8-95ff-562315ef29f3.png)
I have also tried to import  module MicrosoftPowerBIMgmt.Profile using following code:

`Import-Module MicrosoftPowerBIMgmt.Profile`

It shows me following error:
Import-Module : Could not load file or assembly 'netstandard, Version=<IP_ADDRESS>, Culture=neutral,
PublicKeyToken=cc7b13ffcd2ddd51' or one of its dependencies. Reference assemblies should not be loaded for
execution.  They can only be loaded in the Reflection-only loader context. (Exception from HRESULT: 0x80131058)
At line:1 char:1
+ Import-Module MicrosoftPowerBIMgmt.Profile
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (Smiley Happy [Import-Module], BadImageFormatException
    + FullyQualifiedErrorId : System.BadImageFormatException,Microsoft.PowerShell.Commands.ImportModuleCommand

Below is a screenshot for the same.

Same Question is posted here as well.
https://community.powerbi.com/t5/Developer/Unable-to-Connect-with-Power-BI-Service-using-PowerShell/m-p/484963#M14886

Also experiencing same problem attempting to Import-Module

Hi all, I had the same issue and for me this issue was resolved when I installed .NET framework https://www.microsoft.com/net/download/dotnet-framework-runtime

Stefvsignup you are awesome...

Thanks for the above @Stefvsignup .  To clarify, my PC had .Net Framework 4.7.02053.  I updated this version to the 4.7.2 Framework and I am now able to connect to the Power BI Service.

Thanks @janelhunt and @Stefvsignup
My Issue has been resolved.
The solution is to upgrade ASP.Net Framework Version as 4.7.2
https://www.microsoft.com/net/download/dotnet-framework-runtime


How to use CST in other tools/languages

Hi,
thanks for driving this project, this will be very useful!
My question is simple (and maybe a feature request):
I want to use the CST data to process it further in Python. We got some tooling for documentation and driver generation, where I wish to extract some module info like name, ports, portwidths, parameters etc.
I could of course use --printtree and read it in as text into python, parse it again in some way and be done with it. But it seems kind of silly to write a parser for a parser output. Is there any 'direct' way how to get this cst into Python? Is it a standardized output which I can access through some library to e.g. get a large dictionary structure which I can browse through or is it some proprietary format invented by this project.
Some guidance would be appreciated.

Hi there.  There is "nothing special" about the CST, it is just a generic LISP structure (tree) of nodes and terminals, and Verilog-specific enums, so in theory it should be easy to export to any foreign language like Python (as a recursive list-of-lists/elements, or tuples/namedtuples) or LISP/Scheme, and tools like SWIG might help.  At the moment, the interface wrapping and object conversion doesn't exist, so we could use some help there.
Note too that the way the CST is built by verilog.y is fragile and prone to change.  Most of the CST construction is done by generic calls to MakeTaggedNode which is like a tuple with a label.  You'll find today that there are some inconsistencies in the way each node is built, but we've been taking the lazy approach of fix-as-needed and gradually adding more Make* functions to the verilog/CST/* library.  The other ongoing work is creating corresponding named accessor functions to descend through subtrees, as opposed to get-element[i].get-element[j]... direct positional access, the purpose being abstracting away the CST structural details when trying to query access information about specific nodes.  Writing those accessor functions today with unit-tests is a little tedious and manual -- you certainly would not want to replicate that effort in multiple languages (C++, Python, LISP).  It would make most sense to specify structural information independent of language, and emit equivalent code in multiple languages (maybe even including the unit-tests).
Does this give you a better picture of where things stand?

Yes, that is insightful. Thanks very much.
I'm currently playing with Pythons anytree library and I've managed to write a relatively compact parser
for the current CST output. I'm now trying to pull out ports, parameters and instances.
On the lower level where it gets to the content this ends up being some rather nasty string manipulation at the moment.
So yes, what is actually needed is a 'structured way' of getting the data out of verible. Towards Python the obvious choice would be a combination of dictionaries and lists/tuples/sets .
I think this is anyway needed if this is going to be a base for e.g. editor plugins which wish to provide a object/module outline, hierarchy overview etc.

More notes:
The CST tree dump was intended for human-eyes and may not have a stable form, and you might filter it down into an easier-to-parse form, for now.  Also know that the CST dump is abbreviated, in that it doesn't show you where nullptrs are, so the textual representation of (node None foo None) appears the same as (node foo).  We could add a printing mode to show the nullptrs pretty easily.
Since you mentioned outline hierarchy viewing, you might be interested in #185 as well.

What crossed my mind is: Instead of providing expensive-to-implement language interfaces a standardized output like JSON would probably work well and should be easy to get with what you already have currently. JSON can be read by existing well-tested libs in almost any language out there.
Anotehr option is XML. In fact there is ipXact, a standard by the spirit consortium, which is basically the indsutry standard for HDL circuit descriptions for IP vendor and exchange purposes.

I'd welcome a JSON or XML emitter.  Anything that depends on a proper schema will take more effort (and probably a proper AST).  Also note that the CST contains preprocessor directives, something that would need to be handled before targeting a standard like ipXact.

I currently lack the bandwidth to go into a full solution for this (and I'm no CPP crack either) but I happily share what I've started so far so others might use it:
import re

import anytree as t

with open("path/to/cst/file/emitted/by/verilog_syntax --printtree", 'r') as f:
    content = f.readlines()

hier = []
nodes = []

tag_re = re.compile("(?<=Node\s\(tag:\s)[^\)]*")  # get the Node tag
info_re = re.compile("(?<=\(#)[^(\)\n)]*")  # get the content of Nodes
pos_re = re.compile("\s@\d*-\d*:\s")  # used to cut out the @xxxx-yyyy: from the content

for line in content[2:]:
    parent = None
    if hier:  # if hierarchy is empty we are the top node and have no parent
        parent = hier[-1]
    if line.lstrip().startswith("Node"):
        nodes.append(t.Node(tag_re.search(line).group(0), parent=parent, content=[]))
        hier.append(nodes[-1])  # new node, so we extend the hierarchy stack
    if line.lstrip().startswith("}"):  # closing node section, ascend in hierarchy
        hier.pop()
    if line.lstrip().startswith("(#"):  # content for the current hierarchy
        match = info_re.search(line).group(0)
        match = pos_re.sub("", match)
        nodes[-1].content.append(match)

assert not hier, "ERROR: Hierarchy stack is not empty, error while parsing!"

for pre, fill, node in t.RenderTree(nodes[0]):
    print("%s%s(%s)" % (pre, node.name, node.content))

This is in no way pretty, super generic or anything, but it helped me getting a python tree object (anytree is really a cool lib) which I can traverse and search for what I need.
For my private pupose I then have a few functions which pull out ports, params and instances and converts them in a format I need for further use.

@markusdd Head's up.  With a19660768f29672f23355a78eaaea2f6e05c9268, the tree dump added a few more annotations, and may require small changes to your tree-dump parser.

@imphil @tgorochowik in you're interested in exporting Verible's syntax trees and related data to another language.
It should be pretty easy to emit python syntax for the CST directly from C++ as well.  (You'll probably want node/leaf enumerations as well.)

Simple idea: make a variant of --printtree that writes out the tree in python object notation:
[SVNode.kModuleDeclaration, [SVNode.kModuleHeader, [...]]

Also provide an enum class with those constants, as generated from verilog_nonterminals.h.:
class SVNode:
  """Syntax tree node enumerations generated from verilog_nonterminals.h."""
  kModuleDeclaration = ...
  kModuleHeader = ...

For the tree leaves, we have a few options: emit strings or byte-offset pairs to denote substring ranges within the larger source text.
In python, read in these forms and eval().
From there, users can do whatever, with the caveat that the CST structure is not yet stable.

Thanks for working on this @tgorochowik @mglb

I think this can be closed, the python helpers are fully usable


where are you?

I miss you, why don't you answer on telegram?
are you OK?
is there any problem which I help you with that?
come on, we are friends, tell something.

:'(
:_(


bug

send ss of nokogiri version  and gemfile.lock you may find that in opt

did u try to overwrite existing one ?

did u see any error before that

fixed


add some basic workspace store tests

Signed-off-by: Sebastian Malton<EMAIL_ADDRESS>

@Nokel81 please resolve conflicts.

@nevalla done, shall I merge?


on windows, mktime would raise Overflow expection for min_datetime

full fix for #63

Thanks, these code would go into next release(0.8.19), including several issues I'm working on.


[WIP] fix: session not filtered by pageviews

fix session not filtered by pageviews
[WIP] fix events not filtered by pageviews
AT present, if we filter events by url/referrer, the db will throw error as we had not from the pageview db. As far as my trials here, I have not found a perfect way without further refactoring the code.
I'll leave the issue here for now and you may close my PR and use your solution at any time (as im a little busy right now and might not have time for this right now TAT)
From my experience.

We should still filter events by referrer in the whole session. However, this is not recorded in the event db and we need to reference that from session db.
We can simple filter events by url in events db, but the current getFilterQuery won't allow us to do this https://github.com/mikecao/umami/blob/8384d6af352a9393310540cf0c02fff3aee64cbc/lib/queries.js#L57
I'll get back to do this ASAP, but feel free to change my commit according to your design :-)

be0c43dcaa7c7c425db2680328b45bb6604880fb has fixed url filter error when there are query strings.
e.g. /foo won't return result from /foo?bar in combined view.
Also, now events can be filtered by url, although i don't consider it a perfect patch.
referrer filter still now working. I'm thinking if we really need filter by referrer and by which referrer, e.g. the whole session, or only on the entry page.

BTW, im thinking if we can use getPageviewMetrics to handle all session/pageview/event metrics. Also, we might be able to drop pageview/events api? Anyhow, it would be a real work to do that..

I'm not sure how we should deal with URLs with query strings and anchors. Maybe we should ask frontend to tell if the url is raw or just part of the url.
Although this patch could resolve the issue of /foo not returning results of /foo?bar and /foo#bar, But this is not expected in raw view.

This is fixed in v1.31.0


gh-701 Make boolean API properties consistent in list view

Fixes #701

@pjmonks Would you be able to rebase this one please - I wouldn't want to do it myself and make mistakes.  Thanks!

@jamesrwelch Branch has been rebased now


The onnx of resnet failed parsed by TensorRT5.0

when using tensorRT 5.0 to load the onnx file exported by pytorch, it will report a error like this:
While parsing node number 16 [Gather -> "33"]:
ERROR: /home/erisuser/p4sw/sw/gpgpu/MachineLearning/DIT/release/5.0/parsers/onnxOpenSource/ModelImporter.cpp:142 In function importNode:
[8] No importer registered for op: Gather
ERROR: failed to parse onnx file

resnet, squeezenet, vgg, inception, googlenet, densenet, alexnet of the torchvision all have this problem

A fix method is #1134

Fixed via https://github.com/pytorch/vision/pull/1134

@fmassa @apache2046 when i use the  x = torch.flatten(x, 1) to generate my new resnet model,there is a new problem happended when i export my model to onnx format:
Traceback (most recent call last):   File "export_onnx.py", line 53, in <module>     main()   File "export_onnx.py", line 47, in main     torch.onnx.export(car.model,input,"gender_thin2.onnx",verbose=True)   File "/home/yusheng.zeng/softmare/Anaconda2.7/lib/python2.7/site-packages/torch/onnx/__init__.py", line 27, in export     return utils.export(*args, **kwargs)   File "/home/yusheng.zeng/softmare/Anaconda2.7/lib/python2.7/site-packages/torch/onnx/utils.py", line 104, in export     operator_export_type=operator_export_type)   File "/home/yusheng.zeng/softmare/Anaconda2.7/lib/python2.7/site-packages/torch/onnx/utils.py", line 287, in _export     proto, export_map = graph._export_onnx(params, _onnx_opset_version, defer_weight_export, operator_export_type) RuntimeError: ONNX export failed: Couldn't export operator aten::flatten
this seems like flatten operation is not exited in torch.onnx module, so what can i do?


Made primary-table-dark responsive

Closes #957 . Made primary-table-dark responsive. Screenshots attached

Good job @Dibyendu303


Update Elements

I would like to align the nav elements properly and make footer more attractive of Home page and all other webpages that have footer.
So Assign it to me.

@sagnik3788 I have aligned all the elements of navigation bar of all webpages and also changed the footer.

@sagnik3788

@kavya020805  the colors in the footer don't look good. Please do not change the color; keep it as it was previously

Ok... @sagnik3788

Hello, @sagnik3788, as I can see from the above comments. I think I can fix this issue.
Please assign this to me.

@sidharth2829 you can start work on it

Thank you.

Hello @sagnik3788, I have made the following the changes.

Realigned the nav-bar icons.

2)Added vertical borders between footer-tags. and top-margin to footer.

Added a hover effect to word "Sagnik" in footer-end.

@sidharth2829 create a pr then i can review your code

ok

Hi @sagnik3788
I would like to enhance the typography and add effects to it as well as to certain images in the card-based layout section.
Kindly assign me the issue under SWOC'24.

@muskan42 you can create a new issue for this

Hi @TeeWrath ! I'm interested in fixing this issue.
Please assign this issue to me.

@sagnik3788   can u assign this issue to me... I am interested in contributing to this project under swoc


[BUG] hostsystem error  for cluster provisioned with vsphere provider

Rancher Server Setup

Rancher version: 2.8.2
Installation option (Docker install/Helm Chart): Helm

If Helm Chart, Kubernetes Cluster and version (RKE1, RKE2, k3s, EKS, etc): RKE2 3-node cluster v1.26.11+rke2r1

Proxy/Cert Details: Ingress with private CA

Information about the Cluster

Kubernetes version: RKE2 v1.26.11+rke2r1
Cluster Type (Local/Downstream): Downstream

If downstream, what type of cluster? (Custom/Imported or specify provider for Hosted/Infrastructure Provider): Rancher provisioned cluster with vsphere provider (provisioned with Rancher v2.7)

User Information

What is the role of the user logged in? (Admin/Cluster Owner/Cluster Member/Project Owner/Project Member/Custom) Admin

If custom, define the set of permissions:

Describe the bug

After upgrading to v2.8.2, when I edit my clusters provisioned with Rancher and the vSphere provider, I see the following error for every pool Machine Pool I have in the cluster.
pool1: The provided value for hostsystem was not found in the list of expected values. This can happen with clusters provisioned outside of Rancher or when options for the provider have changed.

The host field is empty. Because according to the documentation: Specific host to create VM on (leave blank for standalone ESXi or for cluster with DRS). So, I think is a false error.
To Reproduce
Edit one cluster that was previously provisioned with the vsphere provisioner of Rancher and the host field was left blank.
Result
Expected Result
No error
Screenshots

Additional context

Moved to the dashboard repo for us to look at

+1
Fresh new installation of Rancher 2.8.2 via a Helm chart.

/backport v2.8.next1

Adding QA/None since a back port to 2.8.x was filed and QA can test that once there.

Almost the same issue after upgrading to 2.8.2:
The provided value for contentLibrary was not found in the list of expected values. This can happen with clusters provisioned outside of Rancher or when options for the provider have changed.
Only difference: its contentLibrary and not hostsystem for our cluster

Almost the same issue after upgrading to 2.8.2:
The provided value for contentLibrary was not found in the list of expected values. This can happen with clusters provisioned outside of Rancher or when options for the provider have changed.
Only difference: its contentLibrary and not hostsystem for our cluster. I also had to change the vmware credentials and replace the host with its IP address.

@adrianehlinger-it is your cluster configured outside of rancher, like in Terraform? if not, when you check the Edit Config page, is the Library Template field(next to Content Library field) empty?

@momesgin
To give you a little bit more context: I actually run into two errors.
The first one is: InvalidBodyContent: Post "https://<hostname>:443/sdk": dial tcp: lookup <hostname> on <IP_ADDRESS>:53: read udp <IP_ADDRESS>:58404-><IP_ADDRESS>:53: i/o timeout
I fixed this by replacing the host name of our vsphere to its actual IP address in the corresponding cloud credentials, since it seems to have problems with the DNS.
And the second one is the error message with the content library.
We do not configure the cluster outside of Rancher. Also, we do not have any library templates defined in vsphere and its not opted in for the cluster config as you can see in the screenshot below. The creation method is: Deploying from Template (Data Center).

Though, if I edit the cluster as yaml file, I can see an entry for ever pool that says: "contentLibrary":{"type":"string","default":{"stringValue":"","intValue":0,"boolValue":false,"stringSliceValue":null},"create":true,"update":true,"description":"If           you choose to clone from a content library template specify the name           of the           library"}
This error only occurred after upgrading to Rancher 2.8.2. I updated the exact same Kubernetes cluster on Rancher 2.7.4 without any problems (just a few hours before upgrading Rancher itself).

@adrianehlinger-it re the DNS part, I'm not sure if I can help, but as far as I can tell it's unrelated to the contentLibrary error.
The part mentioned in the YAML file is simply schema information. You should see a reference to your vSphere configuration a few lines down under machineConfigRef:
machineConfigRef:
        kind: VmwarevsphereConfig
        name: nc-<your-cluster-name>-<pool-name>-<id>

You should be able to find the values of your configuration in YAML format from this page:
https://<your-host>/dashboard/c/local/manager/rke-machine-config.cattle.io.vmwarevsphereconfig
My guess would be that contentLibrary is set to null or "" there which leads to show the error.
I'm curious to know what options you see in the Content Library dropdown after selecting 'Deploy from template: Content Library' in the Edit Config page.

Yes, I agree with you. The DNS error seems to be unrelated.
For the options that I can see, see screenshot below. The field "library template" seems to not stop "loading", because all I can see is the loading symbol. No actual value is being loaded. Which does make sense since we do not have any content libraries in our vSphere.

Do you have any suggestions what actions to take to fix this error? Or should I simply wait for the Bug Fix?

@adrianehlinger-it Thank you for sharing the information. Unfortunately, you'll need to wait for the fix to be implemented.

@gaktive @nwmac this issue is tied to SURE-7622... Could that be closed as well?


fix Windows Shell Completion error

Sorry, this was already fixed on main (we fixed the setting rather than the documentation). I will cut a release today to get it out.


fix: Unexpected error on simple filter

SUMMARY
Fixes an unexpected error that occurs when interacting with the filter control.
Follow-up of: https://github.com/apache/superset/pull/22084
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
https://user-images.githubusercontent.com/70410625/213812564-f09281e6-6f9e-474f-9e24-3d99830f45be.mov
https://user-images.githubusercontent.com/70410625/213812590-7be324e8-2dc3-4ba9-8fc3-a92a72e70d0e.mov
TESTING INSTRUCTIONS
Check the video for instructions
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

🏷 preset:2023.3


[OSD-12502] handle known error

What type of PR is this?
(bug)
What this PR does / why we need it?
Added logic to eliminate terminating and non existing namespaces so that the controller will not try to create resources in these namespaces.
Which Jira/Github issue(s) this PR fixes?
Fixes # OSD-12502
Pre-checks (if applicable):

[x] Tested latest changes against a cluster
[ ] Included documentation changes with PR

Codecov Report

Merging #124 (b2cb5b5) into master (cad2008) will decrease coverage by 0.03%.
The diff coverage is 75.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
- Coverage   71.81%   71.77%   -0.04%
==========================================
  Files          10       10
  Lines         479      489      +10
==========================================
+ Hits          344      351       +7
- Misses        129      131       +2
- Partials        6        7       +1

Impacted Files
Coverage Δ

.../subjectpermission/subjectpermission_controller.go
91.30% <71.42%> (-1.12%)
:arrow_down:

pkg/controllerutils/controllerutil.go
98.91% <75.00%> (-1.09%)
:arrow_down:

controllers/namespace/namespace_controller.go
87.69% <100.00%> (ø)

/lgtm


Refactor Logging

Problem
Currently Directive::Log exclusively works with println statements by printing to stdout while solving the opcode. This is not ideal as there are multiple ways that someone way want to access logging information in their Noir circuit (writing to file, log traces in memory, etc.). The caller of the VM rather than the VM itself should be handling the logs.
We should refactor the Log directive or simply remove it to use the new Brillig opcode.
Happy Case
Remove Log opcodes entirely
A caller should be able to implement logging using the Brillig opcode. The Brillig opcode has a foreign call instruction that allows the caller to execute and inject information from outside the Brillig VM execution. A caller who wishes to implement logging can generate Brillig bytecode to make a foreign call with the specific type of log they wish to perform (println, write to a file, etc.). The caller would then differentiate based upon the foreign function name what they wish to do with the information provided to the function. The compiler generating the bytecode would have to also include some information such as the ABI of the value they are looking to log for the caller to execute their logging logic upon.
Alternatives Considered
Refactor to a Log ACIR opcode
This would simply store Log information such as witnesses and an ABI which the caller wishes to follow for this data type (single variable, array, struct, etc.). The caller would have access to the solved witness at the end of the ACVM execution and can construct the appropriate log among the solved opcodes.
When the Log directive was first added ACVM did not have an Oracle (foreign call) opcode. This approach was a better alternative to the current way logging is done when the VM did not have an explicit way to handle foreign calls. With the caller able to execute outside logic outside of the ACVM environment logging does not have to be a part of the ACIR explicitly at all.
Additional Context
No response
Would you like to submit a PR for this Issue?
No
Support Needs
No response

@vezenovm whats the status of this?

Finished with this: https://github.com/noir-lang/noir/issues/1615


Error when trying to debug (f# on mono on OS X)

When I try to debug a small hello-world like fsharp 4.0 program like the attached, I get an error "error while processing request '{_request}' (exception: {_exception})" in Visual Code 0.10.1 on OS X 10.10.5 on mono 4.2.1. The associated launch.json file is as follows:
{
"version": "0.2.0",
"configurations": [
{
"name": "Launch",
"type": "mono",
"request": "launch",
"program": "hello2.exe",
"args": ["test","test2","bla"],
"cwd": ".",
"runtimeExecutable": null,
"env": {}
},
{
"name": "Attach",
"type": "mono",
"request": "attach",
"address": "localhost",
"port": 5858
}
]
}
hello2.txt

Same for me, VSCode 0.10.1, linux, using mono C#.

I can repro using a custom .NET language on Linux x86 using v. 0.10.1 as well. This used to work for plain .NET console apps in past versions.

This issue was moved to Microsoft/vscode-mono-debug#2


Disable annoying tooltip in the side bar of Visual Studio Code

This annoying tooltip hides some parts of the side bar (see the screen shot bellow) and I want to disable it.
I checked the options in settings JSON file, there seems to be no way in there.
Is there any way to disable this tooltip?

Please note that this question is about tooltip from side bar, not about tooltips from editor window.

No, it is currently not possible to disable the explorer tooltip.
We can add a setting, thus I will keep this issue open as a feature request and we might add this in the future. Thanks

Glupa odluka, ne mogu da verujem ali sta da se radi...
On Mon, Mar 16, 2020 at 1:53 AM vscodebot[bot]<EMAIL_ADDRESS>wrote:

Closed #82775 https://github.com/microsoft/vscode/issues/82775.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/82775#event-3131186483, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AH3ZI2WYKQ7CNDB64QCLFG3RHV2BJANCNFSM4JB2W5LQ
.

--
Henri Kinaski

Zivot ide dalje, you can't always get what you want kao sto bi Mick jagger rekao.


*: upgrade to go-ipfs v0.13.0 and Go 1.18

This upgrades IPFS to v0.13.0. This also allows us to use Go1.18, which is nice, because 1.16 is deprecated :)

I can not review 'cause I have no write access

Also could we not ditch the docker file and just build locally?

No, I want to keep the dockerfile. I recommend everyone to use it, since building manually is such a giant pain. And as such, we'll use it ourselves and test it in CI :)

My review is worthless in the eyes of github :/

Not anymore! :)


listening for events and handling concurrency issues

[x] 19 Listening for Events and Handling Concurrency Issues

starting event listening and concurrency isshues

concurrency issues handling implemented


fix(#780): terminallogger pretty print should print non-flattened cfg

Current dependencies on/for this PR:

main

PR #783   👈

This stack of pull requests is managed by Graphite.


Option group isn’t created when using nested data set

When using nested data set, option groups aren’t created inside native select element.
I think it’s something related to this chunk of code: https://github.com/Mobius1/Selectr/blob/master/src/selectr.js#L613-L629
optgroup isn’t appended to native select element, it just stays in memory.

Thanks, I'll get a fix out ASAP.


Update the GHA script to account for the new clone location

Description
With the recent change to the cloning mechanism in Crave, the sources are cloned in a slightly different location: Instead of it being inside a solr subdirectory, it will be in the parent.
Fix the GHA yaml to account for this.
Solution
The solr subdirectory is no longer required in the scripts. Remove it
Tests
This GHA should only be merged after the Solr GHA runners are restarted post upgrade to latest Crave version
Checklist
Please review the following and check all that apply:

[x] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
[ ] I have created a Jira issue and added the issue ID to my pull request title.
[x] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
[x] I have developed this patch against the main branch.
[ ] I have run ./gradlew check.
[ ] I have added tests for my changes.
[ ] I have added documentation for the Reference Guide

Error

Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

Error

Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

Yes, this change is preparing for the new Crave infra. The GHA wont pass until we upgrade Crave.
I'm holding off the upgrade for a time when its a bit quiet.
Is there a good time frame when the Solr community isn't doing much?

@uvatbc now :-) or whenever I guess

@uvatbc now :-) or whenever I guess

Upgraded! Can you run this GHA please?

Yay! It worked!

LMK if we should merge.  I recall there was a PR... I thought this one, that you didn't want to actually merge.

Yes this is the PR that I had said we need to not merge until the upgrade is done.
The upgrade is done, and that's the reason why the tests actually work for this one.
It should now be merged.


Refactor external call

Calling external API is awkward and encourages bad module coding.
Supersedes #77

Full removal of ModuleBase#callExternal() will have to waith #81 because some obsolete modules will be removed and not refactored.

Finished in f6f0abd01227e50beb7757879644f0f014653421


Generalized handling of dialogs, bottom sheets, etc. as secondary roots

We need a mechanism by which we can dynamically create what I'm calling secondary roots. These are composables whose node does not render in the corresponding position in the native tree, and whose children render within one of these secondary roots rather than within the primary tree.
These will be widget-like schema objects, but not widgets because we almost certainly want them to go through a different factory. They have properties, events, and children (although perhaps only zero or one, not many). They generate interfaces similar to a widget so the binding procedure is similar.
These will be handled at the level of the entrypoint (TreehouseView for Treehouse, or forthcoming RedwoodView #1116 for Redwood) similar to how UiConfiguration #355 comes "in", or the forthcoming BackHandler #324 goes "out". The entrypoint will somehow mount these bindings to the native UI using the correct platform-specific mechanism (native dialogs, Compose UI dialogs, view controller-driven dialogs, etc.).
The playground app #1362 should have screens which show various dialogs and bottom sheets, including the ability to show multiple at once.
It's important that the enclosing app can set the policy on the behavior of multiple shown at once. Maybe it stacks, maybe it queues. We don't care.

These secondary roots will get their own composition whose parent is the main composition. Need to figure out what this means for things like the Redwood protocol. Probably a monotonic compositionId which defaults to 0 (the primary root / composition) so as to be backwards compatible.

I'm a fan of the name "secondary root", since it makes it clear that it represents its own window/"DOM". In iOS terms, It maps well to the rootViewController property on the UIWindow class.


9923copyrights and cleanup

Update to README for how to publish section

:tada: This PR is included in version 2.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


gg doesn't render rtl and bidi text correctly

There is some problem to render rtl languages text (like arabic, persian, kurdish, hebrew and ...) in gg.
The glypes doesnt render currectly.
Example:
package main

import (
    "github.com/fogleman/gg"
    "log"
)

func main() {
    const S = 1024
    im, err := gg.LoadImage("img.jpg")
    if err != nil {
        log.Fatal(err)
    }

    dc := gg.NewContext(S, S)
    dc.SetRGB(1, 1, 1)
    dc.Clear()
    dc.SetRGB(0, 0, 0)
    if err := dc.LoadFontFace("/home/dariush/Newsify/css/iransans/ttf/font.ttf", 96); err != nil {
        panic(err)
    }
    dc.DrawStringAnchored("سلام", S/2, S/2, 0.5, 0.5)

    dc.DrawRoundedRectangle(0, 0, 512, 512, 0)
    dc.DrawImage(im, 0, 0)
    dc.DrawStringAnchored("سلام", S/2, S/2, 0.5, 0.5)
    dc.Clip()
    dc.SavePNG("out.png")
}

output :

What has happened to this issue? As well, I faced the same problem.
cc: @fogleman

It does not seem to be a gg problem, ss mentioned in https://github.com/golang/go/issues/27281, the text shaping API is not yet implemented in Golang.


Make it clear, explicit, and fail early on query with just external labels.

Addresses https://github.com/improbable-eng/thanos/issues/1305

@bwplotka was this intentional that you've merged this into master-build-fix, not master? :smile:


Add vue-toast-plus

a promise toast  fro vue
evert one will like it by used
please,thank you
the url https://github.com/bill-mark/vue-toast-plus

@bill-mark Please create a PR if this is still relevant


separated bootstrap and material base css

I think is more modular with this structure :
<link href="dist/css/bootstrap.css">
<link href="dist/css/material-design.css">

<script src="dist/js/bootstrap.js"></script>
<script src="dist/js/material-design.js"></script>

For now it's to hard for make extensible with bootstrap

I think the same also, it would be nicer this way. Than we can extend elements more quickly.

For new version, I think this time to separated bootstrap and material base css

JavaScript has been separated in the new version v4.0.0-alpha.1 (current master).
Regarding CSS, I intended to do the same but found that separating bootstrap.css from material.css isn't a practical solution.
For example, bootstrap.css has its own grid system with breakpoints that are different to the breakpoints defined in Material Design Guidelines, so for this module to work, the material.css needs to

stop the grid system triggering new layout at Bootstrap breakpoints:

/* Bootstrap md breakpoint is 768px */
@media (min-width: 768px) {
    .col-md-* {
        float: none;
        width: auto;
        ...
    }
}

set new breakpoints for md according to Material Design Guidelines:

/* Material md breakpoint is 960px */
@media (min-width: 960px) {
    .col-md-* {
        float: left;
        width: ...%;
        ...
    }
}

Again, for material.css to style a component like .btn in this module, it first needs to reset quite a lot of styles it will inherit from .btn in bootstrap.css and then adds new styles on top of it.
The same will basically apply to every single Bootstrap component because material.css is basically restyling them completely.
Therefore, although you have bootstrap.css and material.css separately in the end, the bootstrap.css will be basically useless as the majority of it will be overridden by material.css. Meanwhile, the size of material.css can potentially be doubled as maybe half of it will be resetting styles in bootstrap.css.


dasel version 2.1.1 (and master) documentation uses dasel delete -p rather than dasel delete -r

Describe the bug

Link to Delete command in Documentation

To Reproduce
Steps to reproduce the behavior:
$ echo '{  "email"<EMAIL_ADDRESS>"name": "Tom"}' | dasel delete -p json '.email'
Error: unknown shorthand flag: 'p' in -p

Corrected:
echo '{  "email"<EMAIL_ADDRESS>"name": "Tom"}' | dasel delete -r json '.email'
{
  "name": "Tom"
}

Expected behavior
No error expected, flag -p used appears to be typo.
Desktop (please complete the following information):

On MacOS dasel version 2.1.1

Thanks for raising this 👍

No problem.
On Tue, Jan 31, 2023 at 11:22 AM Tom Wright @.***>
wrote:

Thanks for raising this 👍
—
Reply to this email directly, view it on GitHub
https://github.com/TomWright/dasel/issues/292#issuecomment-1410776312,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADFQCVOWE3FVO7OHKLR5VOLWVFC4PANCNFSM6AAAAAAULPKBFM
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Patrick Delaney
Contact Details
Cell Phone: +1<PHONE_NUMBER>


feat: Create Connection record when receive DidCommV2

Added optional autoCreateConnectionOnPing field into Agent config and implemented corresponding logic - indicating whether we should create connection state records when receiving a trust ping message targeted to the DID in the wallet, but with a non-existing pairwise record
Updated MessageSender: Unified sendDidCommV1message and sendDidCommV2message functions into single method sendMessage.

@TimoGlastra  @genaris  I worked on the comments. Please review the new version.


nix setup?

I’d like to see a default.nix here that allows me to run
``
nix-env -iA vessel -f .
just like I do with `moc`.

Can you do something with nix-shell?
$ nix-shell -p cargo rustc
$ cargo build --release

I won't be using nix to develop this so unless we get a steady stream of contributions from nix users it's going to bitrot (or if there is a way to say "latest nixpkgs" that would maybe work as well?).

Maybe I’ll contribute something. As long as it’s not big and runs in CI it will not bitrot, I assume. For now I fetched the released binary, so not urgent.

Fixed in 2f535898c875a81258caacdef2b6fcb1ce9d2dec


Failed to run the example with version 0.11.0

Here is the output of running github.com/deislabs/oras/examples:
Pushing hello.txt to localhost:5000/oras:test...
time="2021-03-17T23:50:21+08:00" level=warning msg="reference for unknown type: application/vnd.unknown.config.v1+json" digest="sha256:44136fa355b3678a1146ad16f7e8649e94fb4fc21fe77e8310c060f61caaff8a" mediatype=application/vnd.unknown.config.v1+json size=2
time="2021-03-17T23:50:21+08:00" level=warning msg="reference for unknown type: my.custom.media.type" digest="sha256:03ba204e50d126e4674c005e04d82e84c21366780af1f43bd54a37816b6ab340" mediatype=my.custom.media.type size=13
Pushed to localhost:5000/oras:test with digest sha256:d3551d28503fc53dbb2f316bc71f3e0fd27772395c58ff32c35c9f137b70609a
Pulling from localhost:5000/oras:test and saving to hello.txt...
panic: no_name

It is a regression introduced by #230

That is pretty straightforward. Easy enough to fix.
I notice that the example depends on having a local registry at localhost:5000 but doesn't say that anywhere.

@deitch Running a local registry is as easy as docker run -itp 5000:5000 registry.

I took a loot at #230, which fixes #225.
The idea of the hybridStore is that we don't care about the manifest and config in the regular oras pull scenarios, and they should not be presistent on the disk. That's why they are ingested in the memory as they ephemeral.
If a developer indeed want everything persist on the disk, the developer should pass the option oras.WithContentProvideIngester() to the oras.Pull() to override the hybridStore. In this case, OCIStore is suggested for storing everything. Ref: #108

I suggest to revert #230.
@jdolitsky @deitch Any thoughts?

I've submit a PR #249 for a hot fix since it is a critical bug that a manifest won't have a filename and thus pull always fail.

I commented there. Any kind of store should be able to handle any kind of content. If there are kinds of content that it cannot handle, then it has the choice of error or ignore, and that's a choice that should be made at the level of that store. Don't let it be a layer above.
Now, if we want the default to be ignore, rather than error, as @jdolitsky suggested, let's do that.

I commented there. Any kind of store should be able to handle any kind of content. If there are kinds of content that it cannot handle, then it has the choice of error or ignore, and that's a choice that should be made at the level of that store. Don't let it be a layer above.
Now, if we want the default to be ignore, rather than error, as @jdolitsky suggested, let's do that.

OK. I agree with this one. At least, we should try not to block user on default behaviors, especially for CLI users.

PR to change the default behavior here: https://github.com/deislabs/oras/pull/250
This also adds an acceptance test to prevent this in the future