sidebar - optimisation

@fichtner some code optimisations

I‘ll do it manually. It’s just that it’s easier to review if lines that don’t need changes are not changed in the diff. :)

On 19. Nov 2018, at 09:49, René<EMAIL_ADDRESS>wrote:
@opnsenseuser commented on this pull request.
In src/opnsense/www/js/opnsense_theme.js:

   mouseenter: function () {

       $("#navigation.col-sidebar-left").css("width", "415px");

       var that = $(this);

       if (that.next("div").hasClass("in")) {

           /* no action needed */

       } else if ((that.next().is("a")) || (that.is("a:last-child"))) {

           activeremove(this);

       } else {

           var divtop = that.offset().top - $window.scrollTop();

           var divheight = that.next("div").height();

           var currentheight = (divtop + divheight);

           that.trigger("click");

           if (currentheight > winheight) {

               that.next("div").css("margin-top", -divheight - (that.is(layer1_a) ? 3 : 0));

           }

// traverse loaded css files
I actually thought it would be better because you used 2 instead of 4 characters. to undo the whole thing is really difficult. would have to insert everything new. is there a simple possibility? regards rené

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or mute the thread.

I‘ll do it manually. It’s just that it’s easier to review if lines that don’t need changes are not changed in the diff. :)
…
On 19. Nov 2018, at 09:49, René @.**> wrote: @opnsenseuser commented on this pull request. In src/opnsense/www/js/opnsense_theme.js: > - mouseenter: function () { - $("#navigation.col-sidebar-left").css("width", "415px"); - var that = $(this); - if (that.next("div").hasClass("in")) { - / no action needed */ - } else if ((that.next().is("a")) || (that.is("a:last-child"))) { - activeremove(this); - } else { - var divtop = that.offset().top - $window.scrollTop(); - var divheight = that.next("div").height(); - var currentheight = (divtop + divheight); - that.trigger("click"); - if (currentheight > winheight) { - that.next("div").css("margin-top", -divheight - (that.is(layer1_a) ? 3 : 0)); - } + // traverse loaded css files I actually thought it would be better because you used 2 instead of 4 characters. to undo the whole thing is really difficult. would have to insert everything new. is there a simple possibility? regards rené — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.

I'm sorry, I meant it only well. Thank you. what do you use to change the spaces back to 4? or how do you do that? what would be the easiest way? then I can do it myself if that happens again.
best regards rené

i´ll make a new pr!


Cloning a company assistant prevents saving

The scope of the clone is still company (should be personal). As a non builder saving fails and I can't change the scope (however surprising this is)

Was hit while demoing stuff on the computer of one of our users.


Ahammad Shawki <@ahammadshawki8>

Due we close new issues on PR merge and voting is still possible on closed issues I will close this one. Nice Profile btw 🚀


v1 DHCP server says relay doesn't belong to network when it does

I'm submitting a:

[x] Bug report
[ ] Feature request
[ ] Other

Description
The DHCP server emits a log message saying a relay IP isn't in a subnet when it should be. The subnet is defined at <IP_ADDRESS>/18 which is the range <IP_ADDRESS> - <IP_ADDRESS>. The relay IP having issues is <IP_ADDRESS> which is in the range. Another relay <IP_ADDRESS> works just fine. The exact error message is Network not found.
Steps to Reproduce

Define a subnet as <IP_ADDRESS>/18
Use a relay IP of <IP_ADDRESS>

Expected behavior: The server could find the correct subnet from the relay IP.
Actual behavior: Error message "Network not found".
Versions

Managment Interface Version: n/a
DHCP Server Version: v1.2.0

Server code moved to separate repo.


Enable host to local pod connectivity in Windows VXLAN

Description

This PR adds a Host Route policy to the network in Windows VXLAN. This allows a host to communicate with pods on that host. Windows hosts still do not have connectivity with pods running on remote hosts when running VXLAN.
Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

Enable local host to local pod connectivity in Windows VXLAN

@madhanrm

Do not merge this yet. Just creating this PR for now, I haven't super strictly validated it yet

@madhanrm @rajatchopra  this is ready to be reviewed and merged

lgtm

@rajatchopra

Hi @ksubrmnn ,
If a kubernetes svc pointing to the node internal IP in VXLAN mode,  we cannot access the VIP in Windows containers.
It means users cannot access Kubernetes API server in Windows containers.
We have filed an issue in Kubernetes repo https://github.com/kubernetes/kubernetes/issues/79359
Is it expected?


Promote version to v1.5.1

Coverage increased (+0.1%) to 64.472% when pulling 7d774ee5f7d0622f8c29c0e5f001bd39da01b36f on wy65701436:release-1.5.0 into a15738d98fb474cbfe258eaffc356634eecf3108 on vmware:release-1.5.0.


Multiple SQL metrics with auto-generated labels are collapsed into one

When creating a chart and adding multiple "custom SQL" metrics, the frontend seems to truncate them to generate the label. If this truncated label is not unique, then only one of the several metrics will be displayed.
I frequently create multiple metrics like:
SUM(vaccinations) FILTER (WHERE agegroup<=17)
SUM(vaccinations) FILTER (WHERE agegroup BETWEEN 18 AND 39)
SUM(vaccinations) FILTER (WHERE agegroup BETWEEN 40 AND 59)
SUM(vaccinations) FILTER (WHERE agegroup>=60)

All of these will have the same generated label SUM(vaccinations) FILTER (WHERE agegroup...
Workaround
Manually adding distinct labels solves this issue. That's a good idea in any case, but a bit extra work when prototyping.
Expected results
If I add multiple metrics, I want to see multiple metrics in the resulting graph.
Actual results
Only one of many metrics is displayed.
Screenshots

How to reproduce the bug

Create new chart.
Add multiple "custom SQL" metrics with identical first 40 characters.
Run

Environment
(please complete the following information):

superset version: 0.0.0dev; git hash 80c39daa85c9be9e66a2e3cf2c9e2a8e5a74a8d6
python version: 3.9.6
node.js version: 16.8.0
any feature flags active: (no, using default config)

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

I tried to fix this myself, but could not identify the part of code where this "deduplication" of metrics happens.
It seems it's in the frontend somewhere, since only one metric is in the "chart data" request.
If someone has pointers, I'll gladly try to fix it myself and open a PR.

Thanks for flagging @intgr! Tested and reproduced, so this is indeed a bug/regression. I chcked that the request is using untruncated labels, so truncation is happening in the backend. Let me dig where this is happening so you can see if you want to take a stab at fixing it.

I take that back: the label is incorrectly set by the metric popover:

This is happening here: https://github.com/apache/superset/blob/80c39daa85c9be9e66a2e3cf2c9e2a8e5a74a8d6/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilter/index.js#L182
The correct behavior should be to not physically truncate the label, but to handle the overflow with ellipsis. So the appearance should be unchanged like this:

with the label value being untruncated (currently this widens very ugly when exceeding 43 chars):

Ah, I saw that truncation code, but I assumed that was intentional and the fix should be done somewhere else.
I'll give it a shot, thanks.

This issue should not be closed by the stale bot, in my eyes.

Wondering if anyone really wants to keep this open for two reasons:

It's again been roughly a year since the last comment
I/we haven't heard any outcry about this being a major problem
It's right on the line between a bug and a feature request.

I'm going to just close it as stale, but we can re-open if anyone feels strongly ¯\_(ツ)_/¯


api-docs: Add example for BigBlueButton meeting_name parameter.

Also adds a link to the BigBlueButton integration documentation in the endpoint's main description.
Note: Our API documentation rendering expects a documented example for endpoint parameters, so currently rendering this API endpoint doc raises an error.
Screenshots and screen captures:

Updated BigBlueButton create meeting API endpoint documentation

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Looks good, merged, thanks @laurynmm!


Fix table.getCommitActionType() and eliminate compaction API's from HoodieWriteClient

Right now, COW table.getCommitActionType() returns COMMIT and MOR table.getCommitActionType() returns DELTA_COMMIT. However for MOR compaction process, we would like for table.getCommitActionType() to return COMMIT or add some abstraction over table.getCommitActionType() to be able to smartly return the correct action based on the operation. After this, get rid of the startCompaction(..) and commitCompaction(..) API and merge them into startCommit(..) and commit(..) APIs.

#305 should have fixed this


FE: User tracking

User Story
As a user, I would like to be able to log in, stay logged in, and log out so that I can move around the site and see my moods and playlists.
Detailed Description
We can keep track of the user as they move around the website with cookies. We also need to implement a login button and logout button.
Acceptance Criteria

[x] Given a user is logged in, then their name appears on the page
[x] Given a user is logged in, then there is a logout button on the page
[x] Given a user is logged in, then clicking the logout button clears the user data from the page
[x] Given no user is logged in, then a user can click the login button to log in with Spotify
[x] Given the user is not logged in, then there is no user data on the page
[x] Given the user is not logged in, then there is a login button on the home page

Users can now log in with their Spotify account, stay logged in, and log out.


Copy type icons from bandori wiki

It has been using them for years, which means they should be free-to-use.

Closed by 36061a97b1a7cd7b08eae94acf3fc0ecc472409e


Fixes the guides-local-setup link in the docs README

Added a missing .md extension to the guides-local-setup link in the docs README

Thanks!


Request Asus ROG Zephyrus GA403

This laptop is not configured yet. Should I start with GA402 or GA402x? How to make the keyboard backlight adjustable by keyboard shortcut? What do you think?  I myself also have a GA403 model and am disappointment to see there being no option for it here :(

Hi @hatosu , have you tried asus-linux with liurlnux 6.11? I'm using these, and the only think I complain is keyboard LED and slash LED that can't controlled.

Should I start with GA402 or GA402x?

Either or I think, probably 402x if the 403 has a dedicated gpu.

How to make the keyboard backlight adjustable by keyboard shortcut?

Not sure on that one, the 402 and 402x have this for the mic button.

Would also like to see some GA403 support!

+1


TypeError: object of type 'NoneType' has no len()

Mycode :
import sys
import soundfile
import os
import pyaudio
sys.path.append(r'C:\Users\Mashud A Talukdar\AppData\Local\Programs\Python\Python36\Lib\site-packages\porcupine\binding\python')
from porcupine import Porcupine
library_path= 'C:\Users\Mashud A Talukdar\AppData\Local\Programs\Python\Python36\Lib\site-packages\porcupine\lib\windows\amd64\libpv_porcupine.dll'
model_file_path='C:\Users\Mashud A Talukdar\AppData\Local\Programs\Python\Python36\Lib\site-packages\porcupine\lib\common\porcupine_params.pv'
keyword_file_paths=['C:\Users\Mashud A Talukdar\AppData\Local\Programs\Python\Python36\Lib\site-packages\porcupine\resources\keyword_files\windows\alexa_windows.ppn']
sensitivities=[0.5]
handle = Porcupine(library_path, model_file_path, keyword_file_paths=keyword_file_paths, sensitivities=sensitivities)
def get_next_audio_frame():
pass
while True:
pcm = get_next_audio_frame()
keyword_index = handle.process(pcm)
if keyword_index >= 0:
# detection event logic/callback
pass
output :
File "c:/Users/Mashud A Talukdar/Desktop/Python/test.py", line 18, in
keyword_index = handle.process(pcm)
File "C:\Users\Mashud A Talukdar\AppData\Local\Programs\Python\Python36\lib\site-packages\porcupine\binding\python\porcupine.py", line 154, in process
status = self.process_func(self._handle, (c_short * len(pcm))(*pcm), byref(result))
TypeError: object of type 'NoneType' has no len()
please help me sir
i am working on college project and i need a hotword detection in  my python project to start my project

you need to implement "def get_next_audio_frame()" yourself for you platform. it is returning nothing now.

I think the SDK python README should have at least a workable example that everybody can use/edit easily.
Like this one for example.
#!/usr/bin/env python3
import struct
import pyaudio
import pvporcupine

porcupine = None
pa = None
audio_stream = None

try:
    porcupine = pvporcupine.create(keywords=["picovoice", "blueberry"])

    pa = pyaudio.PyAudio()

    audio_stream = pa.open(
                    rate=porcupine.sample_rate,
                    channels=1,
                    format=pyaudio.paInt16,
                    input=True,
                    frames_per_buffer=porcupine.frame_length)

    while True:
        pcm = audio_stream.read(porcupine.frame_length)
        pcm = struct.unpack_from("h" * porcupine.frame_length, pcm)

        keyword_index = porcupine.process(pcm)

        if keyword_index >= 0:
            print("Hotword Detected")
finally:
    if porcupine is not None:
        porcupine.delete()

    if audio_stream is not None:
        audio_stream.close()

    if pa is not None:
            pa.terminate()

https://github.com/Picovoice/porcupine/blob/master/demo/python/porcupine_demo_mic.py


Would it be possible to get the raw scrambled bitstream? (IDFGH-14259)

Is your feature request related to a problem?
We are developing an application using 1Mbps 802.11b mode in which we can extract valid information from very noisy/corrupted frames that would be normally discarded by the driver. For this we use the promiscuous mode reception with the feature allowing to obtain FCS failed frames.
This works, but for this application, we would be able to improve the reception even more if we were able to obtain the raw/unscrambled bitstream (because when a bit in the stream is corrupted, the descrambler can cause that 6 additional bits get also corrupted).
I understand this is a weird request and might not be possible, but well, have to at least try ^_^
Describe the solution you'd like.
We would like to have a promiscuous rx mode in which we can get the scrambled bitstream (i.e. the received bitstream before it goes through the descrambler). We only need it for the 802.11b mode, but if it can be used for other modes two, it doesn't bother.
Describe alternatives you've considered.
For our experimental receiver we use a Blade-RF SDR, that allows us getting the scrambled bitstream. But we would like to be able to achieve it using ESP32-XX MCUs.
Additional context.
No response

Hi @doragasu
Thanks for the feature request.
ESP32 series do not support dump bitstream from RF.


[Suggestion]Multilingual Support

Are there any plans to make this great document available in other languages for all Minecraft creators?
For example, Japanese, Chinese, French, and other languages that are supported by Minecraft.

We are evaluating translating our documentation into other languages. It's something we want to do, but nothing to announce yet.

We now publish articles and tutorials in:
•    de-DE
•    es-MX
•    fr-FR
•    it-IT
•    ja-JP
•    ko-KR
•    zh-CN
We are looking forward to evolving our multilingual offering here. Thank you for the suggestion! Sorry it took so long to fulfill. :)

We now publish articles and tutorials in: • de-DE • es-MX • fr-FR • it-IT • ja-JP • ko-KR • zh-CN We are looking forward to evolving our multilingual offering here. Thank you for the suggestion! Sorry it took so long to fulfill. :)

Could I ask for any chance to edit these translations by community? I see the translating style of the current translations is almost the same with the translations in Bedrock Edition game which contains super large amounts of machine translations, errrors, typos, wrongly picked terms and inconsistencies with JE (maybe especially in zh_CN since zh is one of the languages mostly shouldn't be translated by machine.)
So I have taken an exploration through all translated zh_CN articles, finding that there's still lots of articles machine-translated without any post-edits. Even the titles looks in a mass. Moreover, even in those articles seemingly post-edited, MT errors and wrong terms can be seen everywhere. For example, in Chinese Simplified (China Mainland variant), Add-on should be 附加包 not 附加组件 or 加载项, tick (n.) be 刻 not 节拍, texture be 纹理 not 材质 (as similar as texture pack be 纹理包 not 材质包), material be 材质 not 材料, base be 基 not 基础 (for 基础 it's basic not base). Moreover, Minecraft the word shouldn't be translated as it's a brand name, and GameTest the word shouldn't be translated as it's a feature name, a proper noun, like JavaScript. Moreover, some MC-coined words are translated with inconsistency to community popularly/commonly used ones, like feature (in world generation) should be 地物 not 功能/特征, and volume (referred as a modding subject) should be 功能域 not 卷 (and it doesn't affect other words like volume fog 体积雾, volume light 体积光.
So after all, if the outsourcing translation team is still give so unsatisfactory translations, then in my opinion, it's better to let the community in like JE with Crowdin.


Get chats which are not contacts

In the WhatApp app you can chat with people that are not your contacts(you only see their phone number). Use this API I'm able to get chats with contacts through get_all_chats(). Is it possible to get the 'anonymous' chats?

Just use send_message_to_id function

That is to send messages, correct? But if I already do have such conversations, is it possible to get them through this API?

If the chat is already opened you can get it from get_all_chats

If you don't want to use send_message_to_id, wich is returning allways False (I mean, it sends the message but returns False), you can use get_chat_from_phone_number and then call send_mesage with the serialized id of the returned chat instance.


addon does not compile when using #define OF_USE_LEGACY_VECTOR_MATH 1

thanks a lot for the awesome addon..
i'm using the master version of ofxLaser together with of_v0.10.1 and for a larger project i have to use..
#define OF_USE_LEGACY_VECTOR_MATH 1
and i'm getting this error..
Undefined symbols for architecture x86_64:
"ofxLaser::Manager::drawPoly(ofPolyline_ const&, ofColor_ const&, std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator >)"
i also tried the addon version for 0.98 together with of_v0.10.1 but that causes a lot more of errors..

Hey @sinsynplus I'm glad it's useful! I've had a quick look at this but I have no idea how to fix it. It's something to do with the type of ofPolyline but as I don't fully understand how OF_USE_LEGACY_VECTOR_MATH works under the hood, I'm not sure how to fix it.
FWIW I'm not fully transitioned to glm::vec3 yet when I work and I don't generally get a problem - are you sure you need the OF_USE_LEGACY_VECTOR_MATH flag?
If you have any luck figuring it out, let me know.

Could this be related to this bug : https://github.com/openframeworks/openFrameworks/issues/6463 in which case it may be worth trying with of11 (although I have yet to test ofxLaser on 11)

thanks a lot for your quick reply and your help.. the issue remains with of_v0.11.0..
i probably have to remove/fix the legacy math in my code..
as far as i can tell your addon is working fine with of_v0.11.0.. although i did not connect my etherdream dac/laser the helloLaser example is compiling with OF_USE_LEGACY_VECTOR_MATH set to zero..

Gonna close this for now, unfortunately I don't know enough about how the legacy mode works to fix it.


Add support for HTML  pubdate Attribute

Some publishers in Germany use html5 for pub date and newspaper does not support it so far
url = "https://www.golem.de/news/assassin-s-creed-origins-angespielt-entschleunigt-kaempfen-mit-ubisoft-1706-128386.html"
article = Article(url)
article.download()
article.parse()

article.title
>>> Assassin's Creed Origins angespielt: Ubisoft verschafft den Auftragskillern Ruhepausen

article.publish_date
>>> None

This is an example
<article>
<time datetime="2011-09-28" pubdate="pubdate"></time>
Hello world. This is an article....
</article>

https://www.w3schools.com/tags/att_time_datetime_pubdate.asp proves your point - thanks for doing this dude gr8 work!


Optional parameters in AWS Lambda job type + Business Fields

The parameters "version" and "append_log"  are optional in Control-M for the AWS Lambda job type. However, in the python client these parameters where set as mandatory in the constructor of the LambdaJob class.
Changed the initialisation of these attributes so they default to None. The attributes will not be generated in json if these parameters are not set.
Also added business parameters as part of the set_run_as function of CmJobFlow class. This allows to set business parameters e.g. business_fields=[{"Usercode":"tmo"}].

Will close since new release contains all job types


Specify files for port detection for every detector

What does this PR do?
This PR introduces new functionality for every detector in order to ensure a consistent way of picking files for port detection. It also adds more comments, the required unit tests and updates to the documentation.
Updates
[Consistency]

The ApplicationFileInfo model is expanded to contain the component path and the context. That way it can be the main model used to identify files that may contain information about port detection.

In every detector we add the GetApplicationFileInfos which will return specific ApplicationFileInfo for every framework.

[Performance]

For detectors which are looking inside the entire component to find source code files in order detect ports, the GenerateApplicationFileFromFilters func has been created. This way we are passing a search keyword in order to go through specific files. For example, we are passing ".go" for all golang frameworks as, for port detection, we are interested only for golang files.

[Other Updates]

As each detector has different functionality for port detection, the GetApplicationFileContents and GetApplicationFileBytes in order to fetch the content of each application file as string or bytes.
All models types from detector have been moved to model.go and sorted by name. This way we have a specific place to store all model's code and not have them spread around different modules.
Further refactoring has been made to flaskdetector and djangodetector to ensure that we are looping through application files and not picking them one by one.

Results

Performance wise, for a big project with many components (e.g. https://github.com/openshift/hypershift) we can see big difference in the execution time. The main reason is that for many detectors we are filtering the files that we are parsing in order to detect ports. The results:

# old
$ time ./alizer component ~/github/alizer-tests/hypershift/
...
real	0m4,043s
user	0m4,281s
sys	0m0,368s

# new
time ./alizer component ~/github/alizer-tests/hypershift/
...
real	0m2,556s
user	0m2,909s
sys	0m0,318s

With the new way of defining potential application files we need only to add an item to every detector's GetApplicationFileInfos and not update the whole DoPortDetection func.

Ensuring that all models are stored in the same place and they have detailed naming. For example, the ServerXml from OpenLibertyDetector has been moved to model.go and renamed to OpenLibertyServerXml, in order to be easier identified and found.

Which issue(s) does this PR fix
fixes https://github.com/devfile/api/issues/1151
PR acceptance criteria
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

[x] Unit/Functional tests

[x] Documentation

How to test changes / Special notes to the reviewer

Updates on commenting & documentation have been added. The draft status is now removed

I was just benchmarking the performance improvements locally (using the same hypershift repo) and noticed a strange behavior. When running from the Alizer source code:
☸ ~/w/p/d/alizer on  1151_ft/specific_port_detection [$!?] via 🐹 v1.19.12
$ go build -o alizer alizer.go

☸ ~/w/p/d/alizer on  1151_ft/specific_port_detection [$!?] via 🐹 v1.19.12
$ time ./alizer component /home/asoro/work/tmp/hypershift
[...]
./alizer component /home/asoro/work/tmp/hypershift  18.74s user 1.82s system 123% cpu 16.644 total

But when running the same Alizer binary from the hypershift repo directory, it takes very long:
☸ ~/w/t/hypershift on  main via 🐹 v1.21.0
$ time /home/asoro/work/projects/devfile/alizer/alizer component .
[...]
/home/asoro/work/projects/devfile/alizer/alizer component .  142.18s user 3.05s system 111% cpu 2:10.65 total

Do you have the same issue? Or am I missing something?

@rm3l no locally I have ~5secs if I run it from the directory of Hypershift and ~3secs if I run it from alizer dir

I was just benchmarking the performance improvements locally (using the same hypershift repo) and noticed a strange behavior. When running from the Alizer source code:
☸ ~/w/p/d/alizer on  1151_ft/specific_port_detection [$!?] via 🐹 v1.19.12
$ go build -o alizer alizer.go

☸ ~/w/p/d/alizer on  1151_ft/specific_port_detection [$!?] via 🐹 v1.19.12
$ time ./alizer component /home/asoro/work/tmp/hypershift
[...]
./alizer component /home/asoro/work/tmp/hypershift  18.74s user 1.82s system 123% cpu 16.644 total

But when running the same Alizer binary from the hypershift repo directory, it takes very long:
☸ ~/w/t/hypershift on  main via 🐹 v1.21.0
$ time /home/asoro/work/projects/devfile/alizer/alizer component .
[...]
/home/asoro/work/projects/devfile/alizer/alizer component .  142.18s user 3.05s system 111% cpu 2:10.65 total

Do you have the same issue? Or am I missing something?

@rm3l no locally I have ~5secs if I run it from the directory of Hypershift and ~3secs if I run it from alizer dir

Ok, never mind. Fine then if it is okay on your end. It looks like I am experiencing similar issues with other tools. Thanks for checking!

Ok, never mind. Fine then if it is okay on your end. It looks like I am experiencing similar issues with other tools. Thanks for checking!

np @rm3l! Feel free to ltgm :)


feat: Make sfpowerscripts compatible with the newest sfdx Apple Silicon version

Describe the feature
Be able to install the sfpowerscripts plugin on the newest Apple Silicon sfdx version
To Reproduce
Uninstall current sfdx CLI
Download newest sfdx Apple Silicon version on https://developer.salesforce.com/tools/sfdxcli
Install sfpowerscripts plugin using sfdx plugins:install @dxatscale/sfpowerscripts
Expected behavior
sfpowerscripts plugin installed successfully
Actual behavior
Install plugin failed (see screenshot below)
Screenshots

Platform Details (please complete the following information):

OS: Mac OS 13.2.1
Version [e.g. CLI Version  eg: 1.6.6]  N/A
Salesforce CLI(sfdx cli) Version:  7.188.1
CI Platform: N/A

I didn't try downloading sfpowerscripts though and manually linking it. Perhaps would work?

@petter-eikeland We dont have a M2 machine handy..  Can you try export DEBUG=* and try running any of the sfpowerscripts command, and see which import is breaking

@petter-eikeland I've had a similar issue before with an Intel Mac (2019).
I had to do a full uninstallation and reinstallation of yarn for the installation to work correctly.
Cloning the repo and linking it may work - it may also give a clearer error message.
Could you confirm your node, npm and yarn versions, and whether you're using a package manager to manage installations and versioning like Volta or nvm?

@azlam-abdulsalam Yeah, it's an M1 Max MBP so not an M2 specific issue. I tried again now, and now the plugin installed without any issue! Not sure why
Just to be clear, the sfpowerscripts & sfdx commands did not suddenly stop working. It was the new Apple Silicon version of sfdx that was released 2 weeks ago that I tried that suddenly throwed the yarn error.


Fixing live tests for UploadAsync_ReadOnlyError

After this PR https://github.com/Azure/azure-sdk-for-net/pull/13592 was pushed with the added test, the test I added failed even though it passed CI. I'm trying to fix it with this right now.

There are two unrelated issues here:

A bug in the new HttpWebRequest transport that's being fixed by https://github.com/Azure/azure-sdk-for-net/pull/13750
Usage of instrumented client in ShareFileClient readOnlyClient = new ShareFileClient(new Uri(sasUri.ToString())); that tries to access a live resource even in a playback mode.


pip support

Hey,
I've finally found time to finish the work on making a pip installable package for this project.
I was hoping for you to test the pip package locally and get it merged soon.
There is some meta-data such as author name, email id which is required in setup.py Then you can edit some of the meta info in setup.py so we can publish this package on pypi easily.

@manu-chroma Yes, I plan to do this today. I will let you know my progress.

Good to hear from you!
let me create a PR, it'll contain all the files and new directory structure for the project.
you can make changes in the PR itself or after merging  :)

@manu-chroma opened this one: https://github.com/nmoya/whatsapp-parser/pull/16

It's uploaded!
https://pypi.python.org/pypi/whatsapp-parser/1.0.0
I will update the readme file with the new instructions

oops. I think one other bug slipped my notice. I'll test and patch it in a few hours. the error is with naming convention of the console entry script.
ps: pip install works perfectly.

Glad that pip install worked!
Blame the reviewer!!

@manu-chroma I added you as a collaborator to the project. Let's keep opening PRs and keep with the reviews, just so we can always stay up to date with the changes.

@manu-chroma I added master as a protected branch, so we can't force push to it. PR's going to master will be blocked for review. Since you are also an administrator, you can merge without the review, but it's a good practice to wait for a while.

@manu-chroma I added you as a collaborator to the project.
I'm glad to help and contribute.

Let's keep opening PRs and keep with the reviews, just so we can always stay up to date with the changes. @manu-chroma I added master as a protected branch, so we can't force push to it. PR's going to master will be blocked until review. Since you are also an administrator, you can merge without the review, but it's a good practice to wait for a while.

Sounds alright to me. Opening PR's would be sure that there's code review and only useful code is merged into the master.

btw what name would you suggest for the executable i.e. <executable name> -h
I'm confused between wp_parser and wp_chat

I would go with wp_parser so it's consistent with the name of the package
that the user installed
On Feb 2, 2017 21:46, "Manvendra Singh"<EMAIL_ADDRESS>wrote:

btw what name would you suggest for the executable i.e.
-h
I'm confused between wp_parser and wp_chat
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/nmoya/whatsapp-parser/issues/12#issuecomment-277078202,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABr44Erdf20Rl03BTvjX0l-EE_v7rRfiks5rYkCYgaJpZM4L0Rt1
.

sure, I feel the same.
seems like this one is done now. closing.


Improve memory allocation and validation

This is a general proposal for how the commons-imaging code could better handle allocations to protect against malicious image data causing high memory consumption. The changes do not show any specific exploit or similar.
Even if you don't agree with the exact code changes here, maybe the general concept is still useful? Or feel free to pick what you like, and adjust it.

The general concept here is that allocations go through methods of the Allocator class to make it explicit whether allocations are assumed to be trusted (e.g. when writing image data) or untrusted (when reading image data). Of course this is not completely foolproof, but at least it makes the intentions of the developers more clear.
The methods for untrusted allocations can perform additional validations then, such as restricting the maximum size or when pre-sizing for example an ArrayList to clamp the initial capacity to a reasonable maximum to then see if the (potentially malicious) image data actually provides that many elements.
The other part is the new KnownSizeByteArrayBuilder class which allows building an byte[] with a known size, but without eagerly allocating it to make sure the input data actually contains that many bytes and has not been maliciously crafted. It also avoids the overhead of boxing which a List<Byte> would have, and also due to starting with a known expected size it avoids creating too large temporary arrays in the process, which general "byte array builder" classes might do.
However, possibly that KnownSizeByteArrayBuilder class can be replaced with similar Commons IO classes and methods if you prefer that.
These changes might not cover every aspect where memory allocation could possibly be exploited for a denial of service, but I think they cover at least some. I have not tested the effect this has on performance though.

Originally I provided these changes privately to the commons-imaging maintainers, but apparently did not got any response at all. So I hope at least this way here this adds some value, even if it just serves as inspiration for other changes.
I know that this merge request has conflicts, but I am not planning to resolve them unless there is actually strong interest in these changes. I was already not very happy about getting no feedback at all (despite being asked to "contribute to the solution of this issue") when I originally invested quite some time into this.

@Marcono1234
Thank you for your PR but it conflicts with the current state of the master branch.
As a general process issue, you should start with a smaller PR, 51 files is too much to review for a delicate and likely complex topic.

@garydgregory, yes I know that it has conflicts, and I can try to split this. My main goal was to show the general idea I had, the main important changes are in Allocator and KnownSizeByteArrayBuilder, the other changes then show how this would be applied (and also fix some other small related issues).
However, quoting from the description of this pull request:

I know that this merge request has conflicts, but I am not planning to resolve them unless there is actually strong interest in these changes. I was already not very happy about getting no feedback at all (despite being asked to "contribute to the solution of this issue") when I originally invested quite some time into this.

Thanks anyway for at least having a short look at this already.

1

1


Small Idea (Allow you change the ESP dots color)

Small idea that would be nice: Be able to change the ESP dots color to any color.

(BTW your fix worked)


Possible error in cel_bulirsch for p<0

The numerical integration is not agreeing with the analytic formula in test_cel_vec.jl.  This may be due to singularity at \phi = \sin^{-1}\sqrt{1/(1-p)}.

Indeed; the singularity was causing problems.  When I do a logarithmic spacing in phi on either side, I get good agreement between the analytic cel integral and a numeric integral.


Remove archived features

Description
Remove Materials, Announcement, and Chatkit from refactored code base.
Material codes under components/game & game-dev and containers/game & game-dev is left untouched, and will be removed by game team during their refactoring efforts. For now it will still refer to the old Material codes to make this PR non-breaking.
styles/_chat.scss and styles/_material.scss is left untouched for now until we completely switch to the refactored code base.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[X] Code quality improvements

Checklist
Please delete options that are not relevant.

[X] I have tested this code
[X] I have updated the documentation

Pull Request Test Coverage Report for Build 5084

3 of 7 (42.86%)  changed or added relevant lines in 4 files are covered.
817 unchanged lines in 68 files lost coverage.
Overall coverage decreased (-5.05%) to 35.745%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/pages/index.tsx
0
4
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/components/dropdown/About.tsx
1
85.71%

src/components/dropdown/Help.tsx
1
85.71%

src/containers/notification/NotificationBadge.ts
1
87.5%

src/reducers/states.ts
1
89.19%

src/components/academy/grading/GradeCell.tsx
3
0%

src/components/academy/grading/XPCell.tsx
3
0%

src/components/sourcecast/SelectCell.tsx
4
0%

src/components/workspace/side-content/ToneMatrix.tsx
4
0%

src/utils/paramParseHelpers.ts
4
42.86%

src/commons/sagas/RequestsSaga.ts
5
21.94%

Totals

Change from base Build 5082:
-5.05%

Covered Lines:
5107

Relevant Lines:
12834

💛  - Coveralls

Please fix failing CI before merging PRs.
This PR is giving me Module not found: Error: Can't resolve '@pusher/chatkit-client' in '/home/travis/build/source-academy/cadet-frontend/src/components/chat'.


added delete all button

Hi,
Please review my pr for Hacktoberfest .
Solves Issue #18

Can you please move it to the input box, just right side of it.

Yes sir I will do it tonight sir please give sometime as Im in class now
On Wed, Oct 12, 2022, 11:18 AM Chintan Tripathi @.***>
wrote:

Can you please move it to the input box, just right side of it.
—
Reply to this email directly, view it on GitHub
https://github.com/chintan0513/ToDo-List/pull/22#issuecomment-1275622511,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3L7CKNYHWYN3EIUQUQZSQ3WCZGLFANCNFSM6AAAAAARCVPIYQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Perfect, just update your repo and copy the CSS code from add button.

Added CSS code for delete all button

@chintan0513 I updated the repo and added css code also , please merge my repo.

Kindly update your current branch to the latest one.


lib conflict issue

(fsdet) jonbrkr@iad12-dhcp-142-207-122 few-shot-object-detection % python3 -m demo.demo --config-file configs/COCO-detection/faster_rcnn_R_101_FPN_ft_all_1shot.yaml
--input portraitjpg.jpg --opts MODEL.DEVICE cpu MODEL.WEIGHTS fsdet://coco/tfa_cos_1shot/model_final.pth
[11/18 06:54:51 detectron2]: Arguments: Namespace(confidence_threshold=0.5, config_file='configs/COCO-detection/faster_rcnn_R_101_FPN_ft_all_1shot.yaml', input=['portraitjpg.jpg'], opts=['MODEL.DEVICE', 'cpu', 'MODEL.WEIGHTS', 'fsdet://coco/tfa_cos_1shot/model_final.pth'], output=None, video_input=None, webcam=False)
froze backbone parameters
froze proposal generator parameters
froze roi_box_head parameters
[11/18 06:54:51 fvcore.common.checkpoint]: Loading checkpoint from fsdet://coco/tfa_cos_1shot/model_final.pth
[11/18 06:54:51 fvcore.common.file_io]: URL http://dl.yf.io/fs-det/models/coco/tfa_cos_1shot/model_final.pth cached in /Users/jonbrkr/.torch/fvcore_cache/fs-det/models/coco/tfa_cos_1shot/model_final.pth
OMP: Error #15: Initializing libiomp5.dylib, but found libiomp5.dylib already initialized.
OMP: Hint This means that multiple copies of the OpenMP runtime have been linked into the program. That is dangerous, since it can degrade performance or cause incorrect results. The best thing to do is to ensure that only a single OpenMP runtime is linked into the process, e.g. by avoiding static linking of the OpenMP runtime in any library. As an unsafe, unsupported, undocumented workaround you can set the environment variable KMP_DUPLICATE_LIB_OK=TRUE to allow the program to continue to execute, but that may cause crashes or silently produce incorrect results. For more information, please see http://www.intel.com/software/products/support/.
zsh: abort      python3 -m demo.demo --config-file  --input portraitjpg.jpg --opts  cpu
/Users/jonbrkr/anaconda3/envs/fsdet/lib/python3.7/multiprocessing/semaphore_tracker.py:144: UserWarning: semaphore_tracker: There appear to be 1 leaked semaphores to clean up at shutdown
len(cache))

Please try to reinstall the repo according to the updated installation instructions. If you are still encountering this issue, feel free to reopen the issue.


Bug 2040880: Mark cluster upgradeable to be unknown when we can't connect to vcenter

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2040880

/lgtm


Accept both background-color and background shorthand properties

Describe your problem and - if possible - how to reproduce it
The "Applied Visual Design: Adjust the background-color Property of Text" does not accept if the background shorthand property is used even though both background and background-color have the same effect.
Add a Link to the page with the problem
https://learn.freecodecamp.org/responsive-web-design/applied-visual-design/adjust-the-background-color-property-of-text
Tell us about your browser and operating system

Browser Name: Google Chrome
Browser Version: 67.0.3396.99 (Official Build) (64-bit)
Operating System: macOS High Sierra

If possible, add a screenshot here

Please refer to the discussion on PR #34275 and close this issue. @dakshshah96

Closing this issue, because it has been fixed in beta. Viewable at https://www.freecodecamp.rocks/


fixes bug #153

https://github.com/socraticorg/mathsteps/commit/1083124f163a196d0686677a63a264df41ea5b84#commitcomment-22937523

Ahhh never mind, it introduced some newer bugs.

👍

@aliang8 @ldworkin in the future can you do squash and merge instead of merge? makes the commit history cleaner :) that's what Ahmed and I did and what in general we've been doing so far, but feel free to make an argument for changing it to just merging

@evykassirer yup will squash and merge in the future.


Some issues I ran into while trying this out

Setup a starter site w/ the default CMS setup on Gatsby Cloud. A few things I needed to do to get it running:

change the require.resolve in gatsby-node.js to BlankPage.jsx vs. js component: require.resolve(./src/BlankPage.jsx)
the default cms posts doesn't have a label on posts so the graphql query in the starter broke —

I added labels and it worked oddly now 1/2 the time. It seems like sometimes the labels still weren't fetched so it fail but if I ran things again it would work. Didn't quite figure out the pattern.

hey @KyleAMathews, thanks for sharing these issues, I'll work on getting them addressed!


Merge latest official frontier into our base develop branch

Merge official frontier/master commit 6e2e90833fdb9ee92f8e0a04fe0d217bfe07100d into ssvm.

#20 merge done.


feat : Responsive footer for various screen sizes

I have implemented responsive footer as assigned in the issue #22  for me for gssoc ext and hacktober fest.
Please find the below demo  of implementation
Desktop:

Tablet:

Mobile:

@maniyaom  Please assign me level label also sir.

@laxmanp090404 , everything is perfect, but please center the 'About Us' title in the footer when viewed on mobile.

Ok  @maniyaom  will do it sir.

As assigned I have resolved the footer mobile view issue . Please provide me level1, level2 or level3 label and merge my PR.
Thanks.


Verts of culled faces need no w divide

If all the faces a vertex belongs to are culled, that vertex does not need w divide or viewport transform. Should think about if it's worth it to try to discard/skip those vertices.

Fixed/not applicable in 0.3


Fix edit chat converts text to link when making no changes

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/29225
PROPOSAL: https://github.com/Expensify/App/issues/29225#issuecomment-1757332445
Tests

Go to a chat and add a comment, google.com
Verify google.com is displayed as a link
Edit the message from [google.com](https://google.com) to google.com and save it
Verify google.com is displayed as plain text
Click to edit the message and save it without making changes
Verify the message is not changed and google.com is still displayed as plain text
Edit the message from google.com to google.com http://new.expensify.com and save it
Verify both google.com and http://new.expensify.com are displayed as links
Edit the message from[google.com](https://google.com) [http://new.expensify.com](http://new.expensify.com)

to[google.com](https://google.com) http://new.expensify.com

and save it
Verify that google.com is displayed as link and http://new.expensify.com is displayed as plain text
Click to edit the message and save it without making changes
Verify that the message is not changed and they're displayed same as step 10

[x] Verify that no errors appear in the JS console

Offline tests

Same as tests
QA Steps

Same as tests

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/117511920/04186094-0cb9-442e-b89c-6d12ce806ed2

Android: mWeb Chrome

https://github.com/Expensify/App/assets/117511920/0d0ccef9-12fb-4695-ba5c-045eb1a972d7

iOS: Native

https://github.com/Expensify/App/assets/117511920/33d726c2-aecf-4d3d-a9eb-b08aa24a956a

iOS: mWeb Safari

https://github.com/Expensify/App/assets/117511920/e218ce0f-0fc9-411b-9190-a482fb938a5f

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/117511920/4273789b-5ebb-4b5f-909e-c0529c9b422e

MacOS: Desktop

https://github.com/Expensify/App/assets/117511920/0e2d5a93-4344-41ea-913e-e7f0e8b2de09

@tylerkaraszewski  Friendly bump!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 1.3.87-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 1.3.87-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.87-12 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 1.3.88-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.88-11 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Semantic Completion Snippets

No idea if this is feasible, but it'd be nice to have the ability to tap into semantic suggestions and modify what's inserted when that suggestion is accepted.
Obviously we already have the ability to add our own snippets, but since they aren't semantic, they just appear on character match, causing them to bloat the suggestion list.
Preferably, we could tap into JavaScript's reduce completion, for example. And instead of getting the default snippet, arr.reduce(${0:callbackfn}), we could customize it to get arr.reduce((${1:accumulator}, ${2:currentValue}) => { $0 });

For JS/TS specifically you can add a server plugin that allows you you to do exactly that. As for a generic solution you would need to write an extension that registers a completion item provider that returns semantic snippets. Generic customisations like changing or removing suggestions from extension A by extension B isn't something we want.


The shift and number keys are not triggering the Keyboard change (SwiftUI + UIKit)

Hello,
I am trying to integrate KeyboardKit into my UIKit based project. I feel like maybe because of this some capabilities are not working out of the box anymore. In particular when the shift or numbers keys are pressed the keyboard doesn't change its UI. I was able to debug it, and I see that keyboardContext.keyboardType = newType is called on the Shift release. My suspicion is that in SystemKeyboard the _keyboardContext = ObservedObject(wrappedValue: keyboardContext) is not being called when I integrate the view in my UIKit like this:
let vc = UIHostingController(rootView: SystemKeyboard(controller: viewController, autocompleteToolbar: .none))
guard let keyboardSwiftView = vc.view else  {
    return
}
keyboardView = keyboardSwiftView
keyboardView?.translatesAutoresizingMaskIntoConstraints = false
keyboardView?.backgroundColor = .clear
// Add the view controller to the destination view controller.
viewController.addChild(vc)
addSubview(keyboardView!)
setupKeyboardLayout()
// Notify the child view controller that the move is complete.
vc.didMove(toParent: viewController)

Is there anything that I am missing that can make this work or maybe my observations are wrong. I would appreciate any help or pointers.
Thank you,

Hi @ibakurov
You don't need to do any of that :) You just have to inherit KeyboardInputViewController and you'll get an English keyboard by default, that will adapt to changes in any of the context classes. You can then customize any part of the keyboard that you like.
You can have a look at the demo app for examples.

Thank you @danielsaidi for the response. Let me elaborate on the structure that I have and trying to achieve.
I have my main view controller inherit KeyboardInputViewController. I also have a textfield inside of the viewcontroller, that I want to use KeyboardKit for to type the text into this field (think search field), before performing the search and then letting user interact with the results inside of the keyboard extension, and send them over to the actual input field (message text) where the keyboard is used on the OS level.
In demo example I am looking at KeyboardTextInput and I am following the implementation except that in the demo it is done with SwiftUI, thus I had to do that extra manipulation to embed the SystemKeyboard View into my UIKit view alongside with the search text field.

Ok, I was able to make it work as expected. I had to keep my KeyboardViewController as UIInputViewController, and create another View Controller that inherits KeyboardInputViewController:
class KeyboardHolderViewController: KeyboardInputViewController {
    override func viewWillSetupKeyboard() {
        super.viewWillSetupKeyboard()

        setup { SystemKeyboard(controller: $0) }
    }
}

And then I add is as a subview to my view, and assign as a view controller to my custom class that inherits KeyboardInputComponent

@ibakurov Oh, are you using your keyboard in an app and not a keyboard extension? In that case, I missed that detail 😀


Some formatting is lost when exporting a presentation to .pdf

Describe the bug
Some formatting is lost when exporting a presentation with theme-apple-basic to .pdf:
The public slide show opens the first slide like this:

But the exported presentation's first slide looks like this:

The second slide should look like this:

But it looks like this in the exported file:

Something is going on with font weights and letter spacing.
I guess this issue belongs here, but it could also go under themes.
To reproduce
Steps to reproduce the behavior:

Clone this repo
git checkout dev_gymate
git chekout 80ddf676
cd presentation
slidev export (or slidev export --dark, doesn't matter)
This file is created without any errors

Desktop

OS: macOS 14.4.1
Browser: Safari 17.4.1
Slidev version: 0.48.8

It seems that the font "Helvetica Neue" isn't loaded in the public slide show, but loaded in the export mode.
The font-family of the text is "Helvetica Neue",ui-sans-serif,system-ui,-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,Arial,"Noto Sans",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"

Everything works fine on my Mac machine

It seems that the font "Helvetica Neue" isn't loaded in the public slide show, but loaded in the export mode.

@KermanX I don't think so. I would guess that the public slide show uses Helvetica Neue Bold and the export uses Helvetica Neue Regular with the font weight increased. (I would rule out the fallback to ui-sans-serif or system-ui, which would be SF Pro Display or SF Pro Text in my case.) See the comparison below:

I don't know which one is the intended display method, but the public slide show looks better to me.

The macOS versions of Chrome (123.0.6312.124) and Microsoft Edge (123.0.2420.81) also display the public slide show the same way (incorrectly) as the exported one looks like.

How about using the ----executable-path option?

I've encountered a similar issue where the pdf export was exporting incorrect fonts.
setting waitUntil: networkidle and adding wait: 10000 seem to fix the issue for me.

Running slidev export --wait-until 'networkidle' --wait 10000 unfortunately didn't solve the issue for me.


replace uuid with github.com/google/uuid close #2

replace uuid with github.com/google/uuid close #2

I would rather use https://github.com/gofrs/uuid , but it doesn't matter as long as satori is not used anymore.


Update http4s-dsl to 0.21.23

Updates org.http4s:http4s-dsl from 0.21.22 to 0.21.23.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.http4s", artifactId = "http4s-dsl" } ]

labels: library-update, semver-patch

Superseded by #324.


KeyClient/CryptographyClient should cache auth token

Package Name: @azure/keyvault-keys
Package Version: 4.0.2
Operating system: Mac OS Catalina 10.15.4
[x] nodejs

version: v10.19.0

[x] typescript

version: 3.6.4

Describe the bug
Each sign request using the same CryptographyClient re-acquires the auth token. It'd be more efficient to reduce the network requests by re-using the same token.
To Reproduce
Steps to reproduce the behavior:

Run the cryptography.js from the typescript samples with DEBUG enabled. Update the .env file to leverage a service principal account.
DEBUG=* node dist/cryptography.js
Observe the network requests

azure:identity:info IdentityClient: sending token request to [https://login.microsoftonline.com/7cb7628a-e37c-4afb-8332-2029e418980e/oauth2/v2.0/token]
azure:core-http:info Request: {
"url": "https://login.microsoftonline.com/7cb7628a-e37c-4afb-8332-2029e418980e/oauth2/v2.0/token",
"method": "POST",
"headers": {
"_headersMap": {
"accept": "application/json",
"content-type": "application/x-www-form-urlencoded",
"accept-language": "REDACTED",
"x-ms-client-request-id": "73b2da7e-5416-4338-9bbb-e782ad00d153",
"user-agent": "core-http/1.1.0 Node/v10.19.0 OS/(x64-Darwin-19.4.0)"
}
},
"withCredentials": false,
"timeout": 0,
"keepAlive": true,
"requestId": "73b2da7e-5416-4338-9bbb-e782ad00d153"
}
...
azure:identity:info IdentityClient: sending token request to [https://login.microsoftonline.com/7cb7628a-e37c-4afb-8332-2029e418980e/oauth2/v2.0/token]
azure:core-http:info Request: {
"url": "https://login.microsoftonline.com/7cb7628a-e37c-4afb-8332-2029e418980e/oauth2/v2.0/token",
"method": "POST",
"headers": {
"_headersMap": {
"accept": "application/json",
"content-type": "application/x-www-form-urlencoded",
"accept-language": "REDACTED",
"x-ms-client-request-id": "f0c21b28-9606-4896-ab1b-804f929aee14",
"user-agent": "core-http/1.1.0 Node/v10.19.0 OS/(x64-Darwin-19.4.0)"
}
},
"withCredentials": false,
"timeout": 0,
"keepAlive": true,
"requestId": "f0c21b28-9606-4896-ab1b-804f929aee14"
}

Expected behavior
The auth token should be re-used across the same client until the token expires. There should be a configuration option to specify the token expiry.

@sadasant seems like a good idea

@codyborn Hey! Thank you so much for reporting this! We will make sure to have this fixed by the next release.

We have released a fix for this issue with the versions below:

keyvault-certificates 4.0.1<EMAIL_ADDRESS>keyvault-keys 4.0.3<EMAIL_ADDRESS>keyvault-secrets 4.0.3<EMAIL_ADDRESS>


[JENKINS-40001] Add plugin description to POM.

JENKINS-40001
@reviewbybees, specially @stephenc @olamy @kohsuke

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@recena @jglick done.

🐝

@jglick @stephenc could you please review this?

@stephenc changes done.

@reviewbybees done.


How to manually handle cache expiration?

use [CacheMode::IgnoreRules] How to manually handle cache expiration

Each CacheManager implementation has a delete method you can use to manually delete a cache record by key. You could also potentially add cache bust logic to return a list of cache keys to remove under specified conditions.

Each CacheManager implementation has a delete method you can use to manually delete a cache record by key. You could also potentially add cache bust logic to return a list of cache keys to remove under specified conditions.

Is it possible to add a maximum expiration time? It is used to control response expiration.

I would think it should be possible to add such logic in your application

I would think it should be possible to add such logic in your application

I added a max_ Stale Is this feasible?
https://github.com/xiaohucode/http-cache/commit/f346d0304b9a2f5eb2942d75cc6a5e3cf479e368

i think so but I would want to make a few changes first, if you'd like to open a PR we can work through that there.


Firefox Uncaught ReferenceError: webui is not defined

It seems not possible to use WebUI with firefox atm.
The initial error when with the call_c_from_js example is
Uncaught TypeError: MutationObserver.observe: Argument 1 is not an object.

After calling one of the C functions
Uncaught ReferenceError: webui is not defined

The WebUI Bridge object issue is fixed, and the window look also get fixed.
Thank you for the report 👍


Please stop, or at least make optional, the opening of a page every time the extension is updated

Other extensions offer such functionality, i.e. don't pester the user when s/he would rather they do not.
Thanks.

Sounds like a good idea! I will add an option to open the changelog page if the add-on is updated, but I will leave it disabled by default.

The option is available in the new version 2.4.0 released today.

Good! Thank you! However, where is that option?


Freeze pyjwt version to 0.3.2 this is the last version using PyCrypto

Until PR #315 get ready oauthlib should use version 0.3.2.
This will fix all PRs tests falling

I think you need to cryptography to dependencies.

Closing this, #322 Provides much better solution.


Add WanWan to Contributors list

Thank you all!

@lf2com, I'm quite elated about your PR. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I merged it?
We’ve added a tweet feature to our web app recently. Can you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.

@Roshanjossey, thank you for quick checking and merged my PR. Actually I didn't get any inform about my PR was merged. Maybe it's because I keep this page on my Chrome tag that Github thinks that it doesn't have to tell me. I don't know but anyway, I got it! Thank you again for the response and this tutorial. I'm starting my contribution now!

@lf2com, I’d urge you to continue contributing to other open source projects.
We also have a slack team to help/mentor people trying to contribute to open source projects.
You can join the team by going to https://firstcontributions.herokuapp.com


Icon on every intro

Then rescrap for social media postings

fc540cb (HEAD -> main, origin/main) Pastorals - intro + icon
2fced23 adding journaling
f5ae8c5 Ruth - added intro-icon
d8c49b2 Romans - added intro-icon and real intro
df2c30d Mark - title
45ed790 Mark - added intro-icon
d05b1e4 Genesis - added intro-icon
13ffda1 Apostles added intro-icon + intro
6294244 1689 - added intro-icon


[Feature Request]: Nvidia Triton Tensor RT LLM Integrations

Feature Description
I would like to add support for Nvidia Triton TensorRT LLMs in llama index. There is currently support for several other LLM endpoints and Nvidia has several interesting offerings with their Triton LLM endpoints that I think others would find useful in llama_index.
Reason
There are several implementations of this floating around the internet already. However, end users must "hack" together the solution and build from source. This will allow users to not have to go through those efforts.
Value of Feature
New LLM endpoints that give users more options and control over how they can use llama index and potential keep their data under their own control.

torvalds.dev is analyzing the ticket

torvalds.dev is analyzing the ticket

The issue is a feature request for the integration of Nvidia Triton TensorRT LLMs (Language Model) into the llama index. The user wants to add support for Nvidia Triton TensorRT LLMs in llama index. Currently, llama index supports several other LLM endpoints, and the user believes that Nvidia's Triton LLM endpoints would be a valuable addition.
The reason for this request is that there are already several implementations of this feature available on the internet. However, end users must manually assemble the solution and build it from the source. The proposed feature would eliminate the need for these efforts.
The value of this feature is that it would provide new LLM endpoints, giving users more options and control over how they can use llama index. It could also potentially allow users to keep their data under their own control.
Based on the provided code, the following files seem to be relevant to the issue:

llama_index/llm_predictor/__init__.py: This file initializes the LLM predictor. It might need to be updated to include the new Nvidia Triton TensorRT LLM.

llama_index/llms/llama_cpp.py: This file contains the implementation of the LlamaCPP class, which is a custom LLM. It might serve as a reference for implementing the Nvidia Triton TensorRT LLM.

llama_index/llms/__init__.py: This file initializes the llms module and might need to be updated to include the new Nvidia Triton TensorRT LLM.

llama_index/langchain_helpers/agents/__init__.py: This file initializes the agents module in the langchain_helpers package. It might need to be updated to include the new Nvidia Triton TensorRT LLM.

The following actions should be taken:

Understand the Nvidia Triton TensorRT LLM and how it works.
Design an interface for the Nvidia Triton TensorRT LLM that is consistent with the existing LLMs in llama index.
Implement the Nvidia Triton TensorRT LLM in a new Python class.
Update the llama_index/llm_predictor/__init__.py and llama_index/llms/__init__.py files to include the new Nvidia Triton TensorRT LLM.
Test the new implementation with various use cases to ensure it works as expected.
Document the new feature and how to use it.


Add e2e test to github actions

Closes #102.
This PR adds:

Adds an E2E test workflow
Updated existing work flow definitions to stream line caching

Codecov Report

Merging #106 (b6bb7c8) into main (2c21f51) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #106   +/-   ##
=======================================
  Coverage   39.98%   39.98%
=======================================
  Files          23       23
  Lines        1993     1993
  Branches      449      449
=======================================
  Hits          797      797
  Misses        899      899
  Partials      297      297

Abandoned


rendertarget: remove ngli_rendertarget_read_pixels()

Currently ngli_rendertarget_read_pixels() is only used in the CPU
capture callback of gpu_ctx_gl and can be inlined there. The new logic
is also simpler compared to the previous one since the code cannot be
called in the middle of a render pass anymore.
Moreover, ngli_rendertarget_read_pixels() is not great API-wise and a
similar functionality should be implemented as ngli_texture_download() or
something similar if one needs to download the data of a texture in
various places.

"ngli_rendertarget_read_pixels() is not great API-wise": you may want to elaborate here that (by basically mentioning the modern backend designs).
LGTM anyway

I adjusted the commit description, let me know if it's ok for you.


Implementation details

First, thanks for a very interesting paper. Looking through your code I see that you pass use _build_causal_attention_mask and pass this attention mask to text encoder during training, which indeed seems to make sense. But all official examples in 🤗 diffusers don't provide attention masks to text encoder during training (in TI and DB training scripts), why is that? I also see your comment # the causal mask is important, don't forget it if you try to customize the code Do you think passing this mask could improve the results for vanilla TI training as well? As a side note, in my custom TI training passing attention_mask for padded tokens significantly improves the convergence speed and final results, but now I think that in addition to that causal mask is needed.
Also in the paper you mention segmenting peoples / faces and inpainting then, but I can't see this in the train.py. Also have you tried just applying this mask to predictions, instead of using inpaining? it seems as faster and also potentially better approach. See this for details: https://github.com/cloneofsimo/lora/discussions/96

@drboog Could you please answer another question? In your codebase everything seems to be prepared to train (and use) down_block + mid_block residual together with prompt prediction. Have you tried actually training the residuals? does it work? Or you just left it to publish another paper?


Simplified dropping spatial indexes on MySQL and Oracle.

There is nothing special in dropping spatial indexes on MySQL or Oracle, so we should reuse existing hooks.

buildbot, test on oracle.

@ngnpope Thanks for checking :+1:


Properly cleanup processes and queues for MPRS and Fix pause for prefetch (#1075)

Summary:
Fixes issue about MPRS.finalize when dataloader2.shutdown() is called
Changes

DataLoader2 should always clean up datapipe_iter at shutdown
Guard MPRS to finalize once
Fix the problem of ConnectionError when DataLoader early exits

This is caused by queue is joined when main/worker/dispatching process exits. No more request/response can be passed across processes.

Consumer process shouldn't join the req_queue at exit to make sure producer process can still access the remaining request. And, consumer will close req_queue after clean up to prevent any further request sent to queue.
Produce process shouldn't join the res_queue at exit to make sure consumer process can still access response. And, producer will close res_queue after clean up to prevent any further response sent to queue.

Main (Consumer) <-> Worker (Producer)
Worker (Consumer) -> Dispatching (Producer)

Fix pause API for DataLoader2

Invoke pause lazily until the limit+1 iteration is reached to align with python's iterator behavior.
Make prefetch.pause blocking unless there might be potential racing issue. Main thread is paused but prefetch worker is still trying to fetch data from iter.

Add tests to validate

Pull Request resolved: https://github.com/pytorch/data/pull/1075
Differential Revision: D44168655
Pulled By: ejguan

This is the reland of #1075. To fix the internal test failures, I have to remove the optional pause change to DataLoader2.


Feature/sdk separate package

Description

AEM Headless SDK added
SDK contains functionality to save persistent queries, regular post query, using GET for saved queries, and list all saved queries.
Beside this 4 specific GraphQL methods, SDK contains Auth helpers for DEV and Service token.

window.fetch replaced with AEM Headless SDK

In example app, on page load cached query is used for initial filter, instead of allAdventuresQuery request.

Example node script added for saving persistent query (used for saving initial allAdventuresQuery)

Proxy updated with 4 examples for Basic auth, Bearer token (DEV token) and Service token for AEMaaCS

TODO: SDK will be separate package, so not sure if this should be merged now as is, or we should wait for a package to be released. For now access to https://github.com/adobe/aem-headless-client-sdk is needed
Also added editor config to keep code style consistent.
Motivation and Context

Adds full functionality of AEM GraphQL
Adds Auth examples.
How Has This Been Tested?
SDK has Linter, Unit Tests and e2e tests.
Example React app tested with Local AEM (basic auth for Author) and remote cloud instance (with DEV token auth).
Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

hey @easingthemes, Lets wait until the SDK is an NPM module that is released. It will give us time to update the tutorial and associated documentation.

PR updated with NPM package, ready for review.

ONHOLD. Depends on https://github.com/adobe/aem-guides-wknd-graphql/pull/22


DSD-474: DS Select component with Chakra's Select component

Fixes JIRA ticket DSD-474
This PR does the following:

Updates the DS Select component to use Chakra's Select component.
The deprecated examples were removed.

How has this been tested?
Locally and through Storybook.
Checklist:

[ ] I have updated the Storybook documentation accordingly.
[ ] All new and existing tests passed.

Front End Review:

[ ] View the example in Storybook

Tugboat has finished building the preview for this pull request!
Link:

https://pr683-4ptrkz1hten1qaiftxgelpvngxpsxdw1.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/6144f273b8fde51bddb0adb2

Tugboat has finished building the preview for this pull request!
Link:

https://pr683-4ptrkz1hten1qaiftxgelpvngxpsxdw1.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/6144f273b8fde51bddb0adb2

Tugboat has finished building the preview for this pull request!
Link:

https://pr683-4ptrkz1hten1qaiftxgelpvngxpsxdw1.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/6144f273b8fde51bddb0adb2

Tugboat has finished building the preview for this pull request!
Link:

https://pr683-4ptrkz1hten1qaiftxgelpvngxpsxdw1.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/6144f273b8fde51bddb0adb2

Updated.

Tugboat has finished building the preview for this pull request!
Link:

https://pr683-4ptrkz1hten1qaiftxgelpvngxpsxdw1.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/6144f273b8fde51bddb0adb2


How to categorise functions as seperate modules

I have public functions which are used by classes directly. But these functions appear in the documentation, in the modules.md page which is the index page. How can I seperate all these functions to a seperate file? When I add @category the functions are categorized to the name I give, but are not seperated from index page.

TypeDoc structures your documentation according to the structure of the project itself - if you give TypeDoc an entry point separate from your root index that exports all the functions, it will document what is exported from that entrypoint in its own module.

But the functions lie in seperate files, and they are generated in the Index page. Ideally no documentation, should generate inside Index page isnt it?

I wanted to add a category for functions and it should appear as a folder along with other categories. Would that be possible?

The @category tag is not able to do what you're asking. It's a per-page categorization feature. In TypeDoc 0.23 (beta this weekend, probably), all members are pushed out into their own files, so they won't show up on the index page anymore except as links (might make this configurable).
Today, you can achieve this with something like this:
// functions.ts
export { someFn } from "./foo"
export { someOtherFn } from "./bar"

// classes.ts
export { someClass } from "./foo"
export { someOtherClass } from "./bar"

$ typedoc ./functions.ts ./classes.ts

I tried the beta version 0.23 and the public functions still appear in the overview file which is - modules.md. I am using plugins
typedoc-github-wiki-theme
typedoc-plugin-markdown
typedoc-plugin-merge-modules
Could you suggest something to fix this?

The theme is what controls wherever or not different reflections get their own document. It looks like typedoc-plugin-markdown has an option that changes how that works:
https://github.com/tgreyuk/typedoc-plugin-markdown/blob/f5a82913f14181f3fa59e5012a105461e201ccd4/packages/typedoc-plugin-markdown/src/theme.ts#L339

In that case function should have its own directory isn't it? But in my case, functions appear in the modules.md file. Is this a bug? Or is there a workaround? Could you let me know please.

an option implies you have to turn it on. Without seeing your configuration, I can only presume you haven't turned it on.

Below are the configurations I am using:
"typedocOptions": {
"entryPoints": "./sampleprojects/sampleFolder/",
"entryPointStrategy": "expand",
"out": "doc",
"excludePrivate": true,
"disableSources": true,
"hideBreadcrumbs": true,
"name": "API Doc",
"theme": "default",
"readme": "./doc1/README.md",
"categorizeByGroup": true,
"mergeModulesRenameDefaults": true,
"excludeExternals": true,
"mergeModulesMergeMode": "project"
}
plugins used:
typedoc-github-wiki-theme
typedoc-plugin-markdown
typedoc-plugin-merge-modules

Yep, looks like you didn't turn that option on. "allReflectionsHaveOwnDocument": true

Thanks a lot @Gerrit0 ! :) That worked like magic, have been behind this for long.


Let’s build a new solution for Iranian users.

Describe the bug
My Iranian friends are unable to connect and they get the “incorrect” key error.
To Reproduce
Try to connect to an outline server from
Submit Feedback
We should come up with a solution to ensure the governments can’t detect and block outline.

Thank you for reaching out! If this is still an issue for you, please contact us at support.getoutline.org and include the GitHub issue number so that we can better support your needs.
If you haven’t already, check out the Outline Support Site at support.getoutline.org for access to help articles and more.


add --validate-args option

Hi,
I added a new option called --validate-args on/off that checks if the provided CLI arguments are valid. If they are, it outputs the word true as well as the parsed TimerStart.ToString() value/s to stdout. If the arguments produce an error, false gets send to stdout. I also added the appropriate usage to the help dialog.
To test this in the command line (e.g. cmd.exe) you also need to add |MORE after the function call (e.g. hourglass.exe --validate-args on --title test until 3pm |MORE, because WinForms UI apps don't print their stdout to the console by default. If hourglass.exe is called via e.g. nodeJS with execFile() (for my use case), this is not necessary since it captures stdout by default. I use this for a plugin for Flow Launcher that sets a timer but needs to check if the supplied input is actually valid before presenting any options.
The portable build of hourglass builds with my changes, but the installer version throws an error about the installer program having duplicate symbols. This also happens on the develop branch without any changes. Feel free to ignore the updated workflow file.
I have not updated any of the version info files or anything else, just what was necessary to make this option work.

Could you please provide real use case for this change; looks like it solves your specific problem mostly and might not be of any use for other users?
I could not accept this PR because it doesn't pass build as it should. I also could not ignore changes made to github actions file due to those changes are being the part of PR.
I think that it is better to create console application which does only options check instead of adding such an option to UI.

The use case would be any program that acts as a front end for hourglass that accepts custom user input. This is definitely more of a developer option rather than one needed by regular users though, which is why it isn't included in any of the UI components but CLI only.
Currently the only way to check if a set of arguments is valid is by running hourglass with the provided arguments and have the help dialog pop up. If the user input is to be checked for every entered letter or number, that would result in 10s of dialogs popping up when even one would already be horrible UX. The alternative would be as you said a new console application that checks the arguments and provides the same output as the --validate-args option right now. I feel like this would not be worth it though as any changes to hourglass would need to be added in and cross verified to work the same. Depending on the hourglass version compared to the console app there could be errors as well.
As for the building, the latest commit on your develop branch 31cdd0ba2face2764e98d68cfe120dc9b3e46ca4 without any changes does not build at the moment (here is the same commit in my fork not building). The last build on this repo seems to be 5 months ago, maybe something with the dependencies changed? The error is related to wixtoolset after all.

I fixed build. Please merge/rebase.
Have you considered this? Unfortunately it is just a console app emulation...

Please provide a couple of command lines to test (with | MORE)
Please update readme Command-line section.

I fixed build. Please merge/rebase.
Have you considered this? Unfortunately it is just a console app emulation...

I have looked at that previously, but all the options I found have drawbacks that I would consider worse than having to add |MORE if run from cmd. The AttachConsole version does not block the console, so if called in e.g. a batch script this could mix outputs. The other options have either a console window pop up on startup for a second or need too many changes to the code base.

Please update readme Command-line section.

done.

Please provide a couple of command lines to test (with | MORE)

Hourglass.exe --validate-args on 3pm |MORE

true
until 3 pm

Hourglass.exe --validate-args on --title TEST --always-on-top on 3pm |MORE

true
until 3 pm

Hourglass.exe --validate-args on --multi-timers on 4m16s 3pm |MORE

true
4 minutes 16 seconds
until 3 pm
4 July

Hourglass.exe --validate-args on --wrong-switch on|MORE

false

Hourglass.exe --validate-args on --always-on-top wrong|MORE

false

Hourglass.exe --validate-args on 3km|MORE

false

Looks OK. I need to do some testing.

OK so I just did some more tests myself, the output with |MORE fails if there is already a timer running.

After some more testing, I came to the conclusion that there may just be no nice way to handle this problem. Once the stdout of the first instance of Hourglass is not outputting to the console anymore, i.e. after a timer has been started, any additional instances can't output anything. If you run the first timer with |MORE and run --validate-args in another window, you can see the output in the first console window.
I resorted to a console application that only checks the args, I was hesitant at first because I never worked with C# before this but adapting the Hourglass startup was pretty straightforward once I installed Visual Studio.
I can still see value in adding the --validate-args option to Hourglass, but if you don't want to, considering all the shortcomings of the current method, that is alright too.

Feel free to create PR with console app.

Closed due to technical difficulties.


result = estimator.predict(input_fn=input_fn)

whta is the result for a sentence pair?I run the code ,and am fused the result. I cannot get the prediction

Almost all my predications are around 2.7 ,I‘m confused about that,could u tell me how to solve it.
thank u.


Azure mongodb with node

Those who are not able connect using node. Please use the below code from Guillaume Alouege
The accepted answer dont work for me on mongodb > 3.0.x
This code work for me :
const mongoClient = require("mongodb").MongoClient;
let database = null;
new mongoClient('mongodb://myhost.documents.azure.com:10355/?ssl=true', {
auth: {
user: 'username',
password: 'p@ssword',
}
}).connect(
(err, db) => {
if (err) return console.error(err);
console.log('Database connected');
database = db.db('foo');
});

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 05af42e7-9d86-b794-e133-efbd46665b9c
Version Independent ID: 0af5eead-7620-ea77-efad-c9ec595fae4f
Content: MongoDB connection string for an Azure Cosmos DB account
Content Source: articles/cosmos-db/connect-mongodb-account.md
Service: cosmos-db
GitHub Login: @AndrewHoh
Microsoft Alias: anhoh

@NIVJAIN Thanks for the feedback! We are currently investigating and will update you shortly.

@AndrewHoh Per the following section: Get the MongoDB connection string by using the quick start

Choose your platform (.NET, Node.js, MongoDB Shell, Java, Python). If you don't see your driver or tool listed, don't worry--we continuously document more connection code snippets. Please comment below on what you'd like to see. To learn how to craft your own connection, read Get the account's connection string information.

There is an update needed for this doucment for Node.js and Mongo DB.
Thanks,
Mike

@Mike-Ubezzi-MSFT Andrew is no longer at MSFT, can you assign this issue to me.

@NIVJAIN are you saying the connection strings specified in the portal for Node.js 3.0 driver doesn't work?

@NIVJAIN can you share the version of Node.js driver and version of Node.js that you are using and can you confirm if you have port 10255 is open on your firewall?

Hi,
its a holiday in Singapore, i will let you know by tomorrow.
regards
Jain
On Tue, May 29, 2018 at 1:42 PM, Sneha Gunda<EMAIL_ADDRESS>wrote:

@NIVJAIN https://github.com/NIVJAIN can you share the version of
Node.js driver and version of Node.js that you are using and can you
confirm if you have port 10255 is open on your firewall?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/8126#issuecomment-392658816,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AfcavqKJSfXY2Yiwesh6BztBsz77TSPfks5t3N_ZgaJpZM4TzgNe
.

Hi Sneha,
i am using
node 8.1.0
npm 5.1.1
mongodb  3.0.5 (driver mongo-client)
below is the package.json from my node app
{
"name": "truffle-init-webpack",
"version": "0.0.2",
"description": "Frontend example using truffle v3",
"scripts": {
"lint": "eslint ./",
"build": "webpack",
"start": "node server.js"
},
"author": "Douglas von Kohorn",
"license": "MIT",
"pwd": {},
"engines": {
"node": "8.1.0 "
},
"dependencies": {
"awesome-qr": "^1.2.0",
"azure-storage": "^2.8.0",
"babel-cli": "^6.22.2",
"babel-core": "^6.22.1",
"babel-eslint": "^6.1.2",
"babel-loader": "^6.2.10",
"babel-plugin-transform-runtime": "^6.22.0",
"babel-preset-env": "^1.1.8",
"babel-preset-es2015": "^6.22.0",
"babel-register": "^6.22.0",
"chokidar": "^2.0.1",
"copy-webpack-plugin": "^4.0.1",
"cors": "^2.8.4",
"css-loader": "^0.26.1",
"eslint": "^3.14.0",
"eslint-config-standard": "^6.0.0",
"eslint-plugin-babel": "^4.0.0",
"eslint-plugin-mocha": "^4.8.0",
"eslint-plugin-promise": "^3.0.0",
"eslint-plugin-standard": "^2.0.0",
"ethereum-qr-code": "^0.3.0",
"ethereumjs-tx": "^1.3.3",
"ethereumjs-util": "^5.1.4",
"html-webpack-plugin": "^2.28.0",
"is-port-available": "^0.1.5",
"json-loader": "^0.5.4",
"lightbox2": "^2.10.0",
"mongodb": "^3.0.5",
"node-logger": "0.0.1",
"nodemailer": "^4.4.2",
"primus": "^7.1.1",
"primus-emitter": "^3.1.1",
"qr-image": "^3.2.0",
"qrcode": "^1.2.0",
"style-loader": "^0.13.1",
"truffle-contract": "^1.1.11",
"web3": "^0.20.6",
"webpack": "^2.2.1",
"webpack-dev-server": "^2.3.0",
"ws": "^5.1.0"
}
}
On Tue, May 29, 2018 at 8:21 PM, Sripal Jain<EMAIL_ADDRESS>wrote:

Hi,
its a holiday in Singapore, i will let you know by tomorrow.
regards
Jain
On Tue, May 29, 2018 at 1:42 PM, Sneha Gunda<EMAIL_ADDRESS>wrote:

@NIVJAIN https://github.com/NIVJAIN can you share the version of
Node.js driver and version of Node.js that you are using and can you
confirm if you have port 10255 is open on your firewall?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/8126#issuecomment-392658816,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AfcavqKJSfXY2Yiwesh6BztBsz77TSPfks5t3N_ZgaJpZM4TzgNe
.

@NIVJAIN apologies for the really long delay, we couldn't reproduce the issue you are seeing with the node and MongoDB 3.0.+ versions that you have. If you have port 10255 is open on your firewall, the connection would work with the code shown in portal.
#please-close

Hi Sneha,
you may close the issue
regards
Jain
On Wed, Jul 18, 2018 at 1:45 PM, Sneha Gunda<EMAIL_ADDRESS>wrote:

@NIVJAIN https://github.com/NIVJAIN apologies for the really long
delay, we couldn't reproduce the issue you are seeing with the node and
MongoDB 3.0.+ versions that you have. If you have port 10255 is open on
your firewall, the connection would work with the code shown in portal.
#please-close
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/8126#issuecomment-405815995,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AfcavkiboFAjnhAA61ET3lslvfU5eQisks5uHstugaJpZM4TzgNe
.

#please-close


Treeview menus do not collapse when a user clicks on a non-tree view menu item

How to reproduce:

Click to expand a tree view menu on the side bar.
Click a menu item that is not a tree view (such as a regular menu item)

While the menu item under the tree menu loses its highlight the treeview itself does not.
Here is a screenshot: http://i.imgur.com/cdXbGX5.png
This is a result of expanding the "Applications" tree view, then immediately clicking on "Home". I'm left with two menu items highlighted when it should just be "Home". The menu should probably also collapse.

Thanks for reporting the issue. I'll get to it when I get a chance.

@ciwolsey can you reproduce this behaviour in the adminlte preview https://almsaeedstudio.com/preview ? If I can reproduce it there, I'll take a look at it.

My application is single page. So when a user visits a link only the content area of the page is refreshed. This differs from your multi-page example. The difference is the links on your pages actually cause page refreshes / reloads whereas my app only alters what's inside the content area. The bug doesn't exist in your preview because new requests are sent and the entire menu is reloaded whereas my menu just continues to exist.


disable paste image

Hi i need to know how to disable paste image into the editor.

how do you enable it? I try to find the way enable

@steer629 I think that option is enabled by default.

Hello, I have same problem. Images paste from 'ctrl+v' to editor. How can I disable it?

did you try it? maybe could solve :)
 // set to 'true' this will insert plain text without styling when you paste something into the editor.
  forcePlainTextOnPaste: true,


Cranelift: Crash when compiling pinned reg on x86_64

👋 Hey,
When implementing #4375 I found some crashes when compiling some examples that use the pinned reg on x86_64.
.clif Test Case
test run
set enable_pinned_reg
target x86_64

function %read_write_iadd(i64) -> i64 {
block0(v0: i64):
    set_pinned_reg v0
    v1 = get_pinned_reg.i64
    v2 = iadd_imm.i64 v1, 1
    return v2
}
; run: %read_write_iadd(0) == 1
; run: %read_write_iadd(-1) == 0
; run: %read_write_iadd(0xDEADBEEF_C0FFEEEE) == 0xDEADBEEF_C0FFEEEF

Steps to Reproduce

clif-util test ./the-above.clif

Expected Results
The tests to pass
Actual Results
clif-util crashes seemingly with a regalloc issue.
     Running `C:\Users\Afonso\CLionProjects\wasmtime\target\debug\clif-util.exe test .\lmao.clif`
thread 'worker #0' panicked at 'assertion failed: `(left == right)`
  left: `p15i`,
 right: `p0i`', cranelift\codegen\src\machinst\reg.rs:469:17
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
FAIL .\lmao.clif: panicked in worker #0: assertion failed: `(left == right)`
  left: `p15i`,
 right: `p0i`
1 tests
Error: 1 failure
error: process didn't exit successfully: `C:\Users\Afonso\CLionProjects\wasmtime\target\debug\clif-util.exe test .\lmao.clif` (exit code: 1)

Versions and Environment
Cranelift version or commit: a2197ebbeb207f72b0a26b0fedcc81b43486cd99 (main as of writing)
Operating system: Windows
Architecture: x86_64
Extra Info
In my machine the above fails, but the simplified test commited in #4375 works.
function %read_write(i64) -> i64 {
block0(v0: i64):
    set_pinned_reg v0
    v1 = get_pinned_reg.i64
    return v1
}

But it looks like in CI it failed with:
running 1 test
error: test failed, to rerun pass '-p cranelift-tools --test filetests'
Caused by:
  process didn't exit successfully: `/home/runner/work/wasmtime/wasmtime/target/debug/deps/filetests-28b9c918e0c0996e` (signal: 11, SIGSEGV: invalid memory reference)

cc @cfallin  since this looks like a regalloc issue

I think that probably we should disallow enable_pinned_reg = true from run-tests unless we can adapt the harness to handle the alternate convention (this would include updating the trampolines at least); happy to review a PR for that if you want to tackle it.

I've added a PR to disable it for now. Maybe we can pick it up later, I really want to focus on finishing the interpreter right now.