Shell error - wrong substitution

In exrm/priv/rel/files/boot:382 there is an argument substitution not supported in /bin/sh mode. On the fork I created I replaced the !#/bin/sh invocation to !#/bin/bash as temporary solution, but I guess using generally compatible /bin/sh is there for a reason. Right now any attempt to start server using master causes errors.

@rafal-radziszewski This one slipped past me :(. I've pushed a fix, please let me know if you run into any other issues.

@bitwalker Thanks for so instant reaction! I will test the package as soon as you bump relx (just been updated), so erlware_commons compile on 19.0.

Just did, and pushed a new release to hex (1.0.6) :)

@bitwalker I just tested it and my version got builded with OTP 19. Once again thanks for instantous update.
There is a problem however: though node runs, I don't seem to be able to attach to node using remote_console. I'm not sure if this is exrm issue, so I do not know if I should open another issue. I paste the output in case it would tell you more than me.
{error_logger,{{2016,6,29},{20,52,12}},"~s~n",["beam/beam_load.c(1486): Error loading module binary:\n  there are local calls to the stub for the BIF binary:split/3\n"]}
{error_logger,{{2016,6,29},{20,52,12}},supervisor_report,[{supervisor,{local,kernel_sup}},{errorContext,start_error},{reason,{'EXIT',{undef,[{binary,module_info,[module],[]},{code,'-load_code_server_prerequisites/0-lc$^0/1-0-',1,[{file,"code.erl"},{line,369}]},{code,load_code_server_prerequisites,0,[{file,"code.erl"},{line,369}]},{code,do_start,1,[{file,"code.erl"},{line,325}]},{supervisor,do_start_child,2,[{file,"supervisor.erl"},{line,343}]},{supervisor,start_children,3,[{file,"supervisor.erl"},{line,326}]},{supervisor,init_children,2,[{file,"supervisor.erl"},{line,292}]},{gen_server,init_it,6,[{file,"gen_server.erl"},{line,328}]}]}}},{offender,[{pid,undefined},{id,code_server},{mfargs,{code,start_link,[]}},{restart_type,permanent},{shutdown,2000},{child_type,worker}]}]}
{error_logger,{{2016,6,29},{20,52,12}},crash_report,[[{initial_call,{application_master,init,['Argument__1','Argument__2','Argument__3','Argument__4']}},{pid,<0.33.0>},{registered_name,[]},{error_info,{exit,{{shutdown,{failed_to_start_child,code_server,{'EXIT',{undef,[{binary,module_info,[module],[]},{code,'-load_code_server_prerequisites/0-lc$^0/1-0-',1,[{file,"code.erl"},{line,369}]},{code,load_code_server_prerequisites,0,[{file,"code.erl"},{line,369}]},{code,do_start,1,[{file,"code.erl"},{line,325}]},{supervisor,do_start_child,2,[{file,"supervisor.erl"},{line,343}]},{supervisor,start_children,3,[{file,"supervisor.erl"},{line,326}]},{supervisor,init_children,2,[{file,"supervisor.erl"},{line,292}]},{gen_server,init_it,6,[{file,"gen_server.erl"},{line,328}]}]}}}},{kernel,start,[normal,[]]}},[{application_master,init,4,[{file,"application_master.erl"},{line,134}]},{proc_lib,init_p_do_apply,3,[{file,"proc_lib.erl"},{line,240}]}]}},{ancestors,[<0.32.0>]},{messages,[{'EXIT',<0.34.0>,normal}]},{links,[<0.32.0>,<0.31.0>]},{dictionary,[]},{trap_exit,true},{status,running},{heap_size,987},{stack_size,27},{reductions,224}],[]]}
{error_logger,{{2016,6,29},{20,52,12}},std_info,[{application,kernel},{exited,{{shutdown,{failed_to_start_child,code_server,{'EXIT',{undef,[{binary,module_info,[module],[]},{code,'-load_code_server_prerequisites/0-lc$^0/1-0-',1,[{file,"code.erl"},{line,369}]},{code,load_code_server_prerequisites,0,[{file,"code.erl"},{line,369}]},{code,do_start,1,[{file,"code.erl"},{line,325}]},{supervisor,do_start_child,2,[{file,"supervisor.erl"},{line,343}]},{supervisor,start_children,3,[{file,"supervisor.erl"},{line,326}]},{supervisor,init_children,2,[{file,"supervisor.erl"},{line,292}]},{gen_server,init_it,6,[{file,"gen_server.erl"},{line,328}]}]}}}},{kernel,start,[normal,[]]}}},{type,permanent}]}
{"Kernel pid terminated",application_controller,"{application_start_failure,kernel,{{shutdown,{failed_to_start_child,code_server,{'EXIT',{undef,[{binary,module_info,[module],[]},{code,'-load_code_server_prerequisites/0-lc$^0/1-0-',1,[{file,\"code.erl\"},{line,369}]},{code,load_code_server_prerequisites,0,[{file,\"code.erl\"},{line,369}]},{code,do_start,1,[{file,\"code.erl\"},{line,325}]},{supervisor,do_start_child,2,[{file,\"supervisor.erl\"},{line,343}]},{supervisor,start_children,3,[{file,\"supervisor.erl\"},{line,326}]},{supervisor,init_children,2,[{file,\"supervisor.erl\"},{line,292}]},{gen_server,init_it,6,[{file,\"gen_server.erl\"},{line,328}]}]}}}},{kernel,start,[normal,[]]}}}"}

@rafal-radziszewski this is certainly a separate issue, I wonder if it's related to OTP 19 or something else entirely. A couple of things:

Is the node you are trying to remote console to running? If so, we know the app starts, and the issue is likely in the code which handles connecting remotely.
If not, did you build the release and deploy it using the same OS/Architecture?
Do other commands work? i.e. attach, ping, etc.

I haven't yet made the leap to 19 because my current workload is all on 18 still, and I haven't had the time to really test it out yet, but I'll be finding some time soon to make the switch and iron out these kind of bugs. In the meantime, you'll have to be my eyes and ears ;)

Node is running. I was surprised, but I successfully called cowboy endpoint and got response.
Yes, I used the same architecture. In fact, one of my nodes also works as build server.
Ping works, attach also seems to work.

I'm trying to debug it too.

Well that definitely helps narrow it down, I have to run for a bit, but I'll take a look once I'm at my computer again.

Don't you worry, I'm still amazed by the amount of stuff you work on. If I have any more info, I will message here. Thanks for the assistance!

Also the same problem. Using Ubuntu trusty on AWS.

Same issue here, trying to remote_console. Much thanks for all the great work you do, bitwalker!

I found out what's causing this - the code path has BEAMs which were compiled with earlier Erlang versions, and are thus incompatible with the new version. When it attempts to load BEAMs it needs, it blows up when it encounters the old ones. I was able to reproduce this, and get it to work by blowing away the old release directory and building a fresh release.
I'm going to look in to how to be more precise with adding code paths, so that only those for the current version of the release are added.


configure: allow passing options to mandate features.

If we want to ensure that launch.h is actually found and actually includes launch_activate_socket allow passing options to configure that will error out unless they are found.

CI failure looks unrelated; seems to be an Ubuntu mirror failure.

I dig the overrides.
Though I might squash these options into a single flag after merge. Its not that useful to just force launch.h but no launch_activate_socket api. The two flags mostly existed for pre-yosemite debugging.
Thanks!

:cool:, thanks!


[composer] increase font sizes for phones and ipads; light mode

“light mode”…? @zhenyasav what did you mean?

Related to #4124


maxWidth and page navigation animation (flutter web 2 & 3)

Hi
In my Flutter Web application I set the max width of my app to 800 pixels.
builder: (context, widget) => ResponsiveWrapper.builder(
          ClampingScrollWrapper.builder(context, widget!),
          maxWidth: 800,
          minWidth: 600,
          defaultScale: true,
          breakpoints: [
            ResponsiveBreakpoint.resize(480, name: MOBILE),
            ResponsiveBreakpoint.autoScale(800, name: TABLET),
            ResponsiveBreakpoint.resize(1000, name: DESKTOP),
          ],
          background: Container(color: Color(0xFFccF5F5))),

But when pushing new page, the default slide transition start (or end when back) outside this limit:

To reproduce, juste create a default flutter project, use this package with maxWidth and navigate to a second page.
Regards

I recommend overriding the mobile swipe transition for Flutter Web.
Please see the example in the examples folder for overriding the navigator transition.

Closing issue with the above solution. Feel free to reopen.


net: ip: tcp: Fix kernel crash on idle thread

Fixing kernel crash caused by memory release inside tcp.c, 'tcp_conn_unref' while having a scheduled work item pending.
The issue here is that even calling 'k_work_cancel_delayable', that doesn't mean that an already ongoing execution of one of the handlers is cancelled, that will simply complete.
In some of the handlers, new work items are scheduled, which are then NOT cancelled anymore.
Eventually they will fire and because the memory holding the work items is already memset to 0, they point into nothing-ness...
This caused the idle thread to crash upon invocation of the scheduled work item, see attached image.

Nice find, this could explain the strange issues observed after testing: https://github.com/zephyrproject-rtos/zephyr/pull/61353

Just checking if this solves the whole problem because I think there may be a race condition.
What if the work item is running but gets interrupted right before k_mutex_lock() by tcp_conn_unref(). This function will do all the cleanup (including setting the conn to zero). Then the work item returns to take its k_mutex_lock() to find the conn has been zeroed out.
Perhaps it might be better if all the cleanup is scheduled on the same tcp work queue as a separate task.


Cannot set wallpaper aspect ratio.

Since registry operations for current user are not possible with UWP I'm not able to set wallpaper image ratio to "Adjust" (instead of "Fill"which is the default).
We need an optional parameter to specify aspect ratio in UserProfilePersonalizationSettings.TrySetWallpaperImageAsync(StorageFile) method.
This optional parameter could take the same values offered in Windows 10 wallpaper settings. For recall:

Fill (Default)
Adjust
Stretch
Tile
Center
Extended

Thank you

This feels not so much like feedback specifically about the documentation, but rather like a question, or feedback, about the product. I don't have any additional content for your scenario, over and above what's in the documentation. So it might be worth your pursuing this as a question/feedback about the product. You got here by clicking Send feedback about > This page. If instead you click Send feedback about > This product, then you'll be taken to the right channel to leave product questions/feedback. Thanks!


Integrate direct path with StreamingDataflowWorker code path

Add direct path code branch
R: @scwhittle @arunpandianp

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

back to you @scwhittle thanks!


Chore setup frontend test react 158580405

Pull Request Test Coverage Report for Build 85

57 of 82 (69.51%)  changed or added relevant lines in 11 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+3.7%) to 83.708%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

server/route/user.js
15
16
93.75%

server/controller/menu.js
0
5
0.0%

server/controller/user.js
4
12
33.33%

server/controller/mailer.js
7
18
38.89%

Totals

Change from base Build 51:
3.7%

Covered Lines:
230

Relevant Lines:
261

💛  - Coveralls


Regression on Whatsapp access

Describe the bug
I am failing to run a bridge with a Whatsapp gateway installed. The configuration was running previously and I know from my Matrix server I am running, that Whatsapp has updated the API in the last few days.
To Reproduce
Steps to reproduce the behavior:
I am using a custom docker container to run the matterbridge. The Dockerfile looks like this:
FROM alpinelinux/golang AS builder

RUN go install -tags nomsteams,whatsappmulti github.com/42wim/matterbridge@master

FROM alpine

COPY --from=builder /home/build/go/bin/matterbridge /usr/bin

RUN mkdir /config
VOLUME /config

WORKDIR /config

CMD ["/usr/bin/matterbridge"]

I just need to run this container and mount a matterbridge.toml in /config/matterbridge.toml.
I recreated the container just 5 min ago. The problem just appears when starting the container.
Expected behavior
The container runs and bridges the messages successfully.
Screenshots/debug logs
If applicable, add screenshots to help explain your problem.
Use logs from running matterbridge -debug if possible.
/usr/bin/matterbridge -conf /config/matterbridge.toml -debug
[0000]  INFO main:         [setupLogger:/home/build/go/pkg/mod/github.com/42wim/matterbridge@v1.26.1-0.20240524210809-d16645c9527a/matterbridge.go:104] Enabling debug logging.
[0000]  INFO main:         [main:/home/build/go/pkg/mod/github.com/42wim/matterbridge@v1.26.1-0.20240524210809-d16645c9527a/matterbridge.go:44] Running version 1.26.1-dev
[0000]  INFO main:         [main:/home/build/go/pkg/mod/github.com/42wim/matterbridge@v1.26.1-0.20240524210809-d16645c9527a/matterbridge.go:46] WARNING: THIS IS A DEVELOPMENT VERSION. Things may break.
[0000] DEBUG discord:      [New:/home/build/go/pkg/mod/github.com/42wim/matterbridge@v1.26.1-0.20240524210809-d16645c9527a/bridge/discord/discord.go:62] Using automatic webhooks
[0000]  INFO router:       [Start:/home/build/go/pkg/mod/github.com/42wim/matterbridge@v1.26.1-0.20240524210809-d16645c9527a/gateway/router.go:66] Parsing gateway RuR Main Bridge
[0000]  INFO router:       [Start:/home/build/go/pkg/mod/github.com/42wim/matterbridge@v1.26.1-0.20240524210809-d16645c9527a/gateway/router.go:66] Parsing gateway RuR Schulung
[0000]  INFO router:       [Start:/home/build/go/pkg/mod/github.com/42wim/matterbridge@v1.26.1-0.20240524210809-d16645c9527a/gateway/router.go:75] Starting bridge: matrix.bot_matrixorg
[0000]  INFO matrix:       [Connect:/home/build/go/pkg/mod/github.com/42wim/matterbridge@v1.26.1-0.20240524210809-d16645c9527a/bridge/matrix/matrix.go:92] Connecting https://matrix.org
[0000]  INFO matrix:       [Connect:/home/build/go/pkg/mod/github.com/42wim/matterbridge@v1.26.1-0.20240524210809-d16645c9527a/bridge/matrix/matrix.go:118] Connection succeeded
[0000]  INFO matrix:       [joinChannels:/home/build/go/pkg/mod/github.com/42wim/matterbridge@v1.26.1-0.20240524210809-d16645c9527a/bridge/bridge.go:77] matrix.bot_matrixorg: joining #rauf-und-runter-gaming:matrix.org (ID: #rauf-und-runter-gaming:matrix.orgmatrix.bot_matrixorg)
[0000]  INFO matrix:       [joinChannels:/home/build/go/pkg/mod/github.com/42wim/matterbridge@v1.26.1-0.20240524210809-d16645c9527a/bridge/bridge.go:77] matrix.bot_matrixorg: joining #rauf-und-runter-schulung-kommunikation:matrix.org (ID: #rauf-und-runter-schulung-kommunikation:matrix.orgmatrix.bot_matrixorg)
[0000]  INFO router:       [Start:/home/build/go/pkg/mod/github.com/42wim/matterbridge@v1.26.1-0.20240524210809-d16645c9527a/gateway/router.go:75] Starting bridge: whatsapp.bot
[0002] DEBUG whatsapp:     [Connect:/home/build/go/pkg/mod/github.com/42wim/matterbridge@v1.26.1-0.20240524210809-d16645c9527a/bridge/whatsappmulti/whatsapp.go:81] Connecting to WhatsApp..
17:04:11.137 [Client ERROR] Client outdated (405) connect failure (client version: 2.2412.50)
[0004]  INFO whatsapp:     [Connect:/home/build/go/pkg/mod/github.com/42wim/matterbridge@v1.26.1-0.20240524210809-d16645c9527a/bridge/whatsappmulti/whatsapp.go:106] QR channel result: err-client-outdated
[0005]  INFO whatsapp:     [Connect:/home/build/go/pkg/mod/github.com/42wim/matterbridge@v1.26.1-0.20240524210809-d16645c9527a/bridge/whatsappmulti/whatsapp.go:123] WhatsApp connection successful
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x144a962]

Environment (please complete the following information):

OS: Docker on Archlinux
Matterbridge version: version: 1.26.1-dev
If self compiled: output of git rev-parse HEAD

Additional context
Please add your configuration file  (be sure to exclude or anonymize private data (tokens/passwords))
Mattermost config
[whatsapp]
    [whatsapp.privat]
        # Number you will use as a relay bot. Tip: Get some disposable sim card, don't rely on
        # your own number.
        Number="+49178xxx"

        # First time that you login you will need to scan QR code, then credentials will be saved in
        # a session file.
        # If you won't set SessionFile then you will need to scan QR code on every restart.
        # optional (by default the session is stored only in memory, till restarting matterbridge)
        SessionFile="session-49178xxx.gob"

        # If your terminal is white we need to invert QR code in order for it to be scanned properly
        # optional (default false)
        QrOnWhiteTerminal=false

        # Messages will be seen by other WhatsApp contacts as coming from the bridge.
        # Original nick will be part of the message.
        RemoteNickFormat="[{NICK}@{PROTOCOL}] "

    [whatsapp.bot]
        # Number you will use as a relay bot. Tip: Get some disposable sim card, don't rely on
        # your own number.
        Number="+49155yyyy"

        # First time that you login you will need to scan QR code, then credentials will be saved in
        # a session file.
        # If you won't set SessionFile then you will need to scan QR code on every restart.
        # optional (by default the session is stored only in memory, till restarting matterbridge)
        SessionFile="session-49155yyyy.gob"

        # If your terminal is white we need to invert QR code in order for it to be scanned properly
        # optional (default false)
        QrOnWhiteTerminal=false

        # Messages will be seen by other WhatsApp contacts as coming from the bridge.
        # Original nick will be part of the message.
        RemoteNickFormat="[{NICK}@{PROTOCOL}] "

[discord]
    [discord.rur]
        Token="XXXX
        Server="1225702406466175006"
        AutoWebhooks=true
        RemoteNickFormat="[{NICK}@{PROTOCOL}] "
        # Map threads from other bridges on discord replies
        PreserveThreading=true

[matrix]
    [matrix.bot_matrixorg]
        # Matterbridge does not support encrypted rooms in matrix.
        # Do a MITM attack against the protocol using pantalaimon
        #Server = "http://pantalaimon:8008"
        Server = "https://matrix.org"

        Login="rur-bot"
        Password="XXXX"

        RemoteNickFormat="[{NICK}:{PROTOCOL}] "

        #Whether to send the homeserver suffix. eg ":matrix.org" in @username:matrix.org
        #to other bridges, or only send "username".(true only sends username)
        NoHomeServerSuffix=false

        #HTMLDisable=true

[[gateway]]

    name = "Test Bridge"
    enable = false

    [[gateway.inout]]
        account = "whatsapp.privat"
        channel =<EMAIL_ADDRESS>
    [[gateway.inout]]
        account = "discord.rur"
        channel = "ID:1231638192705372340"

    [[gateway.inout]]
        account = "matrix.bot_matrixorg"
        channel = "#rur-test-nenc-room:matrix.org"

[[gateway]]
    name = "RuR Main Bridge"
    enable = true
    [[gateway.inout]]
        account = "whatsapp.bot"
        channel =<EMAIL_ADDRESS>    [[gateway.inout]]
        account = "discord.rur"
        channel = "ID:1225702406923358219"
    [[gateway.inout]]
        account = "matrix.bot_matrixorg"
        channel = "#rauf-und-runter-gaming:matrix.org"

[[gateway]]
    name = "RuR Schulung"
    enable = true
    [[gateway.inout]]
        account = "discord.rur"
        channel = "ID:1256315520102432829"
    [[gateway.inout]]
        account = "matrix.bot_matrixorg"
        channel = "#rauf-und-runter-schulung-kommunikation:matrix.org"
    [[gateway.inout]]
        account = "whatsapp.bot"
        channel =<EMAIL_ADDRESS>

Hello @IntGrah,
~as I wrote, I am basically using the command go install -tags nomsteams,whatsappmulti github.com/42wim/matterbridge@master to build the go app. Honestly, I am no go developer so I am a bit lost on what was required in order to manually build from the source with the same tags. In fact, I just copied the command from the documentation/wiki/internet.~
~Can you give me a hint on this? I assume, I have to git clone the repo first, then patch said file. How to trigger the build itself?~
In the linked issue I found some hint on how to build a checked out source tree. With the patch as provided by you I was able to at least make whatsapp accept the client again. However, it would be nice if I would not have to patch manually in order to fix this issue :wink:.

Glad you got it sorted. The proper solution would be to update the whatsmeow package, but there are still issues with breaking API changes. The dirty patch is good enough for me and most people for the moment.


Inconsistence result for the same query

I decided to integrate datahorse into my project as an ai-agent. So for each query a csv file is provided to data-horse but sometime for the same query i'm often facing different scenario:

any dataframe returned
a dataframe with a results(some columns) that has not be asked.
for plot different plot rendered for the same query
import error due to some library not installed in my package but needed for datahorse to rendered plot.

bedhind the scene i decided to add "always return the result as dataframe" to reduce the occurence amount of all errors above mentionned.
So how to fix result or plot render or that datahorse try to import not available library?

Thank you for highlighting these concerns. We understand the challenges you are facing, and we want to address each issue:

Inconsistent DataFrames: We recognize that DataHorse, being powered by a large language model (LLM), can return different results for the same query due to the model's dynamic nature. To mitigate this, we are working on standardizing the output schema by defining specific constraints and filters to ensure more consistent DataFrame results. We are also implementing a post-processing step to align the DataFrame with expected columns and structure.

Inconsistent Plot Renderings: Similar to the data inconsistency, the varying plots are a result of the LLM’s flexible interpretation of queries. We are establishing a set of standard plot types and formats for each query to ensure uniformity. Additionally, we will include a normalization step in our post-processing to standardize the plots generated.

Library Dependency Issues: We are aware of the import errors caused by missing libraries. To address this, we will update our documentation to include all necessary dependencies and ensure they are properly managed in our environment. We are also working on handling missing libraries more gracefully by implementing conditional imports.

@SsebowaDisan @poneoneo I reckon setting the seed will generate similar or in some cases the same result which may help in solving the issue here for the llama-8b-8192
Reference used - https://medium.com/@kyfex/groqs-chat-settings-dfbb601efdca
Should I try on the changes needed?

Hello @Sohammhatre10 ,
Thank you for the suggestion about setting the seed! It does sound like a great approach for ensuring more consistent results. I appreciate your willingness to contribute to the project.
If you’d like to help with this, feel free to dive into the implementation based on the reference you shared.
Looking forward to collaborating with you on this!
Best regards,
Disan

I think it's could be great to provide endpoints for user and allow them to change it based on their needs

@poneoneo That'll be great for personalization.

Have tried to clear this using a different caching mechanism and seeding technique. Works well here https://github.com/DeDolphins/DataHorse/pull/9
@SsebowaDisan @poneoneo Hope this solves the issue!


Add proof of concept for the changes endpoint

This PR fixes part of #15.
I have added the changes.rs file, which implements one method to get all the changes for now. I  first wanted to use this PR as a proof of concept and get confirmation, after which I would add more endpoints.
The primary concerns I had were:

I used Option to represent the optional query parameters and created a custom utility function called generate_query_url to get the query string from multiple optional parameters. Does this implementation look good? Should we consider shifting this function to a more "global" crate?
How do I test if the code I added is working? I couldn't see mock servers or integration test infrastructure in the code base.

Hey @kymppi Palease can you review this PR?

@unicodeveloper @kymppi Can you please add the hacktoberfest tag to this repository or the hacktoberfest-accepted label to this PR?

@unicodeveloper @kymppi Can you please add the hacktoberfest tag to this repository or the hacktoberfest-accepted label to this PR?

That was added yesterday.

@unicodeveloper
I can't see the same. It must either be the hacktoberfest tag on the repository or the hacktoberfest-accepted tag on a PR. I can only see the hacktoberfest tag on my PR, causing the same to be excluded from the count.
Also when will this PR be merged? I would love to add additional functionality to this repository once this base PR is merged.

@unicodeveloper Am I missing something? Is there any additional step in getting the PR merged?

We greatly appreciate your contribution. We hope you'll stay with us and continue to be an integral part of this project.
Please consider giving this repo a star and joining our community discord server, if you haven't already, to access more resources and connect with like-minded individuals. Discord Community here 🎉  #Hacktoberfest


[SUPPORT] Deltastreamer commits with a custom checkpoint configuration are skipped if the generated checkpoint matches the previous commit checkpoint

Describe the problem you faced
When running deltastreamer with a custom checkpoint value, e.g. --checkpoint 0, the commit is skipped if the resulting checkpoint value matches the checkpoint value of the previous commit:
21/11/25 13:42:50 INFO DeltaSync: Checkpoint to resume from : Option{val=1637847362361}
21/11/25 13:42:50 INFO DFSPathSelector: Root path => /Users/charlie.briggs/Projects/signal/pipeline/pipeline-spark-jobs/experiments/schema_evolution/output/schema_evolution_parquet/ source limit =><PHONE_NUMBER>854775807
21/11/25 13:42:50 INFO DeltaSync: No new data, source checkpoint has not changed. Nothing to commit. Old checkpoint=(Option{val=1637847362361}). New Checkpoint=(1637847362361)

This prevents re-reading a static dataset into the same Hudi Deltastreamer using the checkpointing mechanism.
To Reproduce
Steps to reproduce the behavior:

Run Deltastreamer using the DFS datasource against a static parquet datasource
Re-run deltastreamer against the same datasource with the same modified timestamps, passing --checkpoint 0 (or any checkpoint value < the previous commit checkpoint)
Observe the commit is skipped

Expected behavior
With the DFS datasource, any files modified since the provided checkpoint timestamp are re-read and upserted, and a commit is made, regardless of the checkpoint timestamp or modified date of the files.
Environment Description
EMR 6.4.0

Hudi version: 0.9.0
Spark version :

3.1.2

Hive version :

Hive 3.1.2

Hadoop version :

Amazon 3.2.1

Storage (HDFS/S3/GCS..) :

S3

Running on Docker? (yes/no) :

no
Additional context
This is a minor issue, but causes some confusion - it is intuitive to me that a checkpoint of 0 should re-read all data possible from the source datasource.
If a file has changed in the source datasource since the previous commit, this technique does seem to work as the commit is not skipped (as the checkpoint has increased from the previously committed checkpoint)

@Limess : So, is the expectation that, if you set checkpoint = 0, deltastreamer should start from scratch as though we are starting deltastreamer for the first time ?
bcoz, from your example, it is working as expected. your resultant checkpoint  Option{val=1637847362361}, matches last checkpoint in commit metadata and hence deltastreamer does not do anything.

if you wish to override the checkpoint, probably you need to set --initial-checkpoint-provider.
https://github.com/apache/hudi/blob/e8473b9a2b5bf0ad9370377899f6a7ea4d1ceba1/hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java#L357

@Limess : So, is the expectation that, if you set checkpoint = 0, deltastreamer should start from scratch as though we are starting deltastreamer for the first time ?

Yes that's the expectation - this is also what currently happens, but where it doesn't match my expectations is that the subsequent commit is skipped so nothing is actually writen.
Intuitively I'd expect that if the checkpoint < the commit timestamp, Hudi should always commit.

if you wish to override the checkpoint, probably you need to set --initial-checkpoint-provider.
https://github.com/apache/hudi/blob/e8473b9a2b5bf0ad9370377899f6a7ea4d1ceba1/hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java#L357

I did look into this and found it hard to understand/use, neither existing implementations match this use case.

gotcha. guess the way you set the checkpoint should work based on this code block
        if (cfg.checkpoint != null && (StringUtils.isNullOrEmpty(commitMetadata.getMetadata(CHECKPOINT_RESET_KEY))
                || !cfg.checkpoint.equals(commitMetadata.getMetadata(CHECKPOINT_RESET_KEY)))) {
          resumeCheckpointStr = Option.of(cfg.checkpoint);

Can you enable debug logs and post it here. In the mean time, I will try to reproduce this locally and will post an update here.

Can you try checkpoint = "val=0"

Can you try checkpoint = "val=0"

To clarify, you're asking me to try  --checkpoint "val=0" using the Deltastreamer CLI?

This worked for me.
First run
nsb$ grep "Checkpoint" /tmp/logs/log23.out
21/12/08 07:47:52 INFO DeltaSync: Checkpoint to resume from : Optional.empty
21/12/08 07:49:35 INFO DeltaSync: Checkpoint to resume from : Option{val=1638825407000}
21/12/08 07:50:35 INFO DeltaSync: Checkpoint to resume from : Option{val=1638825408000}
21/12/08 07:51:46 INFO DeltaSync: Checkpoint to resume from : Option{val=1638825413000}

Stopped deltastreamer and restarted with additional config --checkpoint<PHONE_NUMBER>000
nsb$ tail -f /tmp/logs/log24.out | grep "Checkpoint"
21/12/08 07:54:36 INFO DeltaSync: Checkpoint to resume from : Option{val=1638825407000}
21/12/08 07:56:16 INFO DeltaSync: Checkpoint to resume from : Option{val=1638825408000}
21/12/08 07:57:56 INFO DeltaSync: Checkpoint to resume from : Option{val=1638825413000}

We're not running in continous mode, it looks like the above might be? We're also using DFS datasource.

yea, try giving a valid epoch time. it should work. continuous or non continuous should not matter.

yeah, mine is parquet DFS source.

I plan to close this out as epoch times work. Please re-open if need be.


Find box ctrl+left etc broken by this extension.

Hello! Thanks for the Extension! It's working quite well overall.
The bit that I notice is that when in VS Code's Find field (the Find Widget), the shortcuts for ctrl+left, ctrl+shift+left are broken. The cursor just sits there at the end of the string.
Maybe the fix would be in the keybindings of the extension's package.json? Or maybe in the main extension code. Something that can see when the Find Widget has the focus...
Thanks!

@blalond Good spot. Thanks. I've updated the context for the keybindings, and re-published the extension.
The arrow keys revert to their default behaviour in the FInd widget.


How I can achieve puppet only managed repositories?

Hello guys, I'm about to replace all of my manually managed repositories with the ones managed by puppet completely.
So far so good, by using this module I'm able to populate all the repos via Hiera data (this is what I use) so I can differentiate between os_family, distro, hostname et cetera.
Here the problem arises, because there is nothing about - purge_default_repos, I'm looking forward to see how I can achieve this.
For instance, I want to remove all the repos in /etc/yum.repos.d, then populate the folder with puppet created repos.
I think this can be done with simple exec, or file remove with recursive function for /etc/yum.repos.d, then execute the yum class after this, but because of lack of my knowledge, I'm not sure I'm on the right track.
Any suggestions and examples are more then welcomed.
Thanks in advance.
Affected Puppet, Ruby, OS and module versions/distributions

Puppet: 6.0.0-14focal
Ruby: 2.7+1
Distribution: Ubuntu 20.04.3 LTS
Module version: puppet-yum (v5.3.0)

@KpuCko I use a 'trick' to achieve that: using another directory instead and removing all *.repo files from /etc/yum.repos.d/
# ensure the 'reposdir' value is changed before deploying any repositories
Yumrepo { require => Yum::Config['reposdir'], }

file { '/etc/yum.managed-repos.d':
  ensure => 'directory',
  owner  => 'root',
  group  => 'root',
  mode   => '0755',
}

# changing the default directory to avoid name conflicts with exisiting
#   repository files and to minimize the number of active repositories
yum::config { 'reposdir':
  ensure  => '/etc/yum.managed-repos.d',
  require => File['/etc/yum.managed-repos.d'],
}

# make sure no unnecessary repo files are present
tidy { '/etc/yum.repos.d':
  matches => [ '*.repo' ],
  recurse => true,
  backup  => false,
  require => Yum::Config['reposdir'],
}

# create symlink for team members searching for repo files
file { '/etc/yum.repos.d/you-are-looking-for':
  ensure  => 'link',
  target  => '/etc/yum.managed-repos.d',
  require => File['/etc/yum.managed-repos.d'],
}

The result looks like this:
# ls -l /etc/yum.repos.d/
total 0
lrwxrwxrwx 1 root root 24 Oct 23  2020 you-are-looking-for -> /etc/yum.managed-repos.d

# ls -l /etc/yum.repos.d/you-are-looking-for/
total 56
-rw-r--r-- 1 root root 204 Oct 23  2020 centos_base.repo
-rw-r--r-- 1 root root 212 Oct 23  2020 centos_extras.repo
-rw-r--r-- 1 root root 215 Oct 23  2020 centos_updates.repo

#258 attempted to add support for this, but didn't work. A way that works is here: https://github.com/voxpupuli/puppet-rhsm/pull/125#issuecomment-1204249388

Duplicate of #104 and #94.


Fix the build configuration so that make doesn't need to be repeated

Currently, some build dependency seems missing around the parser and the lexer.  As a result, a single make does not finish the compilation.  In the Travis configuration, make; make; make; make; make; make; make; make compiles the codebase.  This is not ideal.

Hey @pirapira I think this is due to the way BuckleScript handles the generated files for the parser. In https://github.com/pirapira/bamboo/pull/262 these generated files were removed and thus more make statements were needed because the first attempt to compile fails (as the compiler can't find these files).
The reason why I checked them in https://github.com/pirapira/bamboo/pull/260 is because I realized this issue, and then saw a recommendation in the official BuckleScript docs to do so:

It is quite common for programmers to use some preprocessors to generate some boilerplate code during developement.
Note preprocessors can be classified in two categories: one is system-dependent which must be delayed until running on the target machines and the other is system-independent (such as lex, yacc, m4, re2c, etc.) which could be executed anytime.
BuckleScript has built in support for conditional compilation for the second category. Since it is system-independent, we ask users to always generate such code and check it in before shipping, which would cut the dependencies for end users.

Tracking these files in git is not ideal either, but if it helps avoiding these issues in CI, then it might be worth it.

I see.  I didn't know it's the recommendation of BuckleScript.
Anyway, I would like the build system to rebuild all dependent goals once I modify parser.mly or lexer.mll.


IPv6 Support

Allow getaddrinfo to return any addrinfo family (not just AF_INET) then filter down to AF_INET and AF_INET6) only.
Restructured _AddressList internal data to accommodate the 4-tuple of addrinfo for AF_INET6 and the call signatures of some methods on Connection to accept a different addrinfo family.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Object doesn't support #ai

Not sure if it's an awesome_print issue or something my end causing it but when trying display a certain objects fields I just receive the message: (Object doesn't support #ai), for example:
Quote.new
(Object doesn't support #ai)
Any advice would be great thanks as I find awesome_print really useful.

It may be due to delegated method not being resolved, thus returning object is not an instance and awesome_print doesn't know how to handle it.
Try doing object.valid? or object.relation.valid? to check what is returned

same issue here! @mcfoton is right (in my case) belongs_to/delegate to:  ... same message as above.
But, it work's just fine after i expelled gem from Gemfile, no error (ie. in console), unlike with aws gem in Gemfile.

In my case this is occurring with a non-databased backed model. When trying to access foo.errors, I get (Object doesn't support #ai) in console.
class Foo
  include ActiveModel::Model

  attr_accessor :bar

  def initialize(attrs = {})
    super

    @errors = ActiveModel::Errors.new(self)

    @bar = attrs[:bar].presence
  end

  validate :bar_exists

  def bar_exists
    errors.add(:bar, 'is does not exist') unless @bar.present?
  end
end

Which yields:
f = Foo.new
f.valid? # => false
f.errors # => (Object doesn't support #ai)
f.errors.messages # =>
  {
    :bar => [
      [0] "is does not exist"
    ]
  }

If I add an errors reader method and respond with errors.to_h it will respond with a hash and not the error, but that strips away all the other functionality of errors so it's not a suitable solution in this instance.


Function call when 'slickNext' hits end of slider in non-infinite mode

Is there a simple way to call a function whenever I hit next button or use 'slickNext' if the slider has reached the end?
I want to call an AJAX after the slider ends. I tried the 'edge' event but it seem it doesn't work that way, only triggering when i try to swipe the last slide.

Should be testable with the events. Best of luck!


fix: ensure instantiateMVarsProfiling adds a trace node

We add a new Meta.instantiateMVars trace node to the instantiateMVarsProfiling definition used in elabMutualDef, and we replace various uses of plain instantiateMVars with the profiled version (which necessitated pulling up the definition to be higher in the file).
This fixes a "time leak" when profiling large proofs, where instantiating the goal metavariable can take a significant amount of time, that previously would not be accounted for when using the trace profiler.

Hmm, the CI error links to https://leanprover.github.io/lean4/doc/dev/commit_convention.html, which redirects to
https://www.lean-lang.org/lean4/doc/dev/commit_convention.html, which 404s.

!bench to ensure the code doesn't introduce non trivial regressions.

I'm also not exactly sure that this is the proper solution for the instantiateMVars time leak. This is only going to profile it in very specific situations, a more uniform solution seems more desirable to me? But also potentially more threatening to performance.

Fair point. It should be noted that instantiateMVarsProfiling was already a thing, I just expanded its use and ensured it has a trace node so that it shows up in the trace profiler also.
The proper solution would be to add a trace node to instantiateMVars itself, but that is a lot trickier, since Lean.Util.Trace (which defines the trace machinery) imports Lean.MetavarContext (where instantiateMVars lives).

I do understand why you did what you did now. But I do not have enough knowledge about our meta internals to know what exactly would be required here. Someone else from the team would have to weigh in.

awaiting-review
Probably helps if I put that tag on. I'll be away for the next two/three weeks, though, so I won't respond to any review comments until then

awaiting-review


Add SNI client support

#948
What happens if m_HostToVerifySSL is IP instead of hostname?

It's CString& in ZNC.

Several of the related declarations in CZNCSock use the CS_STRING & format but sure I'll change it.

What happens if m_HostToVerifySSL is IP instead of hostname?

That doesn't matter, the server name sent would just be the IP.

Several of the related declarations in CZNCSock use the CS_STRING & format but sure I'll change it.

I meant not just the space, but CString vs CS_STRING, and placement of {
The only other instance of CS_STRING should be fixed though, thanks for pointing it out.


[Grid] Fix prop check for applying wrap-reverse

[x] I have followed (at least) the PR section of the contributing guide.

Closes https://github.com/mui-org/material-ui/issues/30812

Hi.
Thanks for opening the PR.
I can confirm in this codesandbox that the issue is fixed.
Can you add a unit test to prevent this bug from happening again in the future?

No problemo. Unit test has been added. Cheers.

I have pushed a simplification and took a note for v6 (in #30660). We probably want to encourage developers to use flexWrap moving forward: https://mui.com/system/flexbox/#flex-wrap.


feat(api): Add CORS support

Add first-class support for CORS to falcon. Includes a CORS object
for specifying CORS configuration, CORS middleware for applying a
CORS object, and a kwarg to the API class that will take a CORS
object and configure the middleware for you. Allows over-riding
the CORS configuration on a per-resource basis.
Resolves issue #303

Closed and re-opened to add a change suggested by another contributor:
In falcon/api.py:

     self._sinks = []
     self._media_type = media_type

     self._before = helpers.prepare_global_hooks(before)
     self._after = helpers.prepare_global_hooks(after)

   if cors is not None:

       if not isinstance(cors, CORS):

           raise ValueError('cors argument must be an instance of '

                            'falcon.cors.CORS')

       cors_middleware = CORSMiddleware(cors)

       if type(middleware) == list:

its recommended to use isinstance:
if not isinstance(middleware, list):
thanks @ueg1990 !

You are welcome. Hope you do not mind if i send you a few more suggestions....I do not have much experience in frameworks and their internals; so trying to contribute however i can :smile:

@ueg1990 comments / suggestions are always welcome.  I noticed you had some interest in #600 but like I said we can't complete that without Kurt or someone making a decision and editing RTD info.  So if you wanted to do something else related to documentation, a tutorial / howto section on CORS somewhere in the manual would be AWESOME, and I won't have to implement it with this changeset.

Thanks for working on this @lwcolton! We were about to replace our own after hook implementation with something better and it seems we should hold out for this to merge into Falcon.
Any ETA on a merge for your PR?

Haven't heard anything from the core devs yet.
On Wed, Oct 21, 2015 at 4:57 PM, Greg<EMAIL_ADDRESS>wrote:

Thanks for working on this @lwcolton https://github.com/lwcolton! We
were about to replace our own after hook implementation with something
better and it seems we should hold out for this to merge into Falcon.
Any ETA on a merge for your PR?
—
Reply to this email directly or view it on GitHub
https://github.com/falconry/falcon/pull/611#issuecomment-150036714.

--
Sincerely,
Colton Leekley-Winslow
651-242-9559
<EMAIL_ADDRESS>

Hi guys, apologies for the delays. I'm trying to rally the crew to get caught up on all the PRs. Expect reviews soon.

As @kgriffs mentioned, we are actively reviewing this patch. It's large, so please bear with us as we dig in deep on this one. So far, it looks like some great work! Kudos.

@lwcolton hi, why not releasing this as a third party plugin instead (something like falcon-cors, see also pytest-falcon or falcon-oauth in this track)?
CORS is very important feature, but IMHO there is no need to change falcon API for adding CORS support, given that this is at the end only a middleware that will do the job. So IMHO falcon current hooks are enough for a full CORS support :)
Also, I think having a more plugins based falcon ecosystem will help keeping the falcon core small and optimized, also putting less pressure over the core maintainers, that can concentrate about core falcon optimisation and hooks needed by plugins.
Last thing, I'd make the CORS API signature a bit simpler, making the middleware to instantiate itself the CORS class, so the final user only need to create a CORSMiddleware() instance.
What do you think? :)

@yohanboniface Originally Kurt asked for CORS support to be in falcon proper, so that's what I did.  However I do like the idea of a plugin based falcon ecosystem, and I am able to release the CORS feature as a standalone package if thats what the community wants.  Lastly, making CORSMiddleware instantiate a CORS config for you is a good idea and I can definitely add a helper for that.

@painterjd Have you had a chance to review the implementation?
I like the idea of encouraging growth of the ecosystem, as long as we can help community members find what they need; perhaps we could add some notes to the docs that encourage people to search on PyPI for "falcon" to view a list of (potentially useful) add-ons. I hesitate to include a concrete list of packages in the docs, since that might imply favoritism (not to mention the difficulty of keeping that list up to date).
That being said, as a web developer, I would like a way to tell which add-ons are well-tested, and that have been tuned to minimize the amount of overhead they add to the processing of each request. At least in the former case, the usual Travis+Codecov badges can provide some measure of confidence.
Anyway, @lwcolton what do you think about releasing your CORS work as a standalone package? It would be awesome if you could also submit a Falcon doc patch that encourages people to check out (and contribute to) falcon-* packages on PyPI. We might also want to encourage developers to announce major releases of their add-ons on the Falcon mailing list, and to chat about their work in #falconframework.

@kgriffs Yes absolutely I want to release this a falcon-* package! I have some others that are soon to come, great utility libraries for stuff like decoding JSON and HTTP error handling.  All of these are dependencies of an open-source HTTP API framework I'm developing on top of falcon.  The name may change and there isn't enough documentation to show off the cool parts, but here's where I'm at:  https://github.com/lwcolton/falcon_mongo
Anyway, I have one fix for compatibility with sink classes that I need to add, and then I'll get a falcon-cors package on PyPi.  Update with that url coming soon.

@lwcolton cool, I always like to see people building cools stuff on top of Falcon. :smile:

OK, just to bring everyone up to date, I discussed this with a few people in IRC (#falconframework) and we are leaning toward creating a standalone package for this, although it may still live under the falconry umbrella. I'd like to get a final decision on this ASAP.

I second the need for such feature, as a dependency or not.

I am going to release this as it's own package, falcon-cors.  Everything is ready, could a couple of you please take a look and let me know what you think before I do a release:
https://github.com/lwcolton/falcon-cors/tree/develop
You can install it with:
pip install git+https://github.com/lwcolton/falcon-cors.git@develop

@lwcolton excellent, I'll use it in my projects :)
Out of curiosity, why keeping two classes (CORS and CORSMiddleware)? From a quick look, API would be simpler with only CORSMiddleware to implement. But that's a detail :)

Created a dedicated wiki page to start referencing available plugins https://github.com/falconry/falcon/wiki/Plugins cc @kgriffs

@yohanboniface The CORS class is separate because it can be attached to a resource to override cors configuration on a per-resource basis.  Also, one day I hope to create middlewares for other frameworks

@kgriffs Hope you are happy with my decision on how to release this, I agree it had to happen ASAP so folks can start using it.  If I don't get any other feedback by the end of the day I plan on merging develop into master and releasing on pypi as version 1.0.0

OK, I released on pypi.  https://github.com/lwcolton/falcon-cors
This can be closed and so can #303

@lwcolton sounds good, thanks for working on this! You may want to send a note to the mailing list to let everyone know it's available and to ask for additional feedback.


Readme.md - Installation Requirements missing yarn

In the requirements yarn should be added. Here is potential a link to the instructions: Yarn

thanks. fixed


Renamed 'connect' commands to 'login', solving #574

Renamed 'connect' commands to 'login', solving #574

Coverage remained the same at 100.0% when pulling 715e00a4a5c0eb4d2cbb7f950a9a13c80186ee3b on waldekmastykarz:fix-rename-connect into 9d69638494ed8261b1770f6c94c05dc94f99879d on pnp:dev.

Merged manually


Update sketch.rb version to 40

Instructions
Update sketch.rb version to 40

There was a pull request template when you submitted. It must be filled.
If you were not presented a template, you may have submitted via a CLI tool (likely hub). It that was the case, you may wish to see if the tool has a way to let you use the template (hub is working on it).
In either case, please refer to the template and update your comment.
Also, you’re deleting a bunch of things from the cask for no apparent reason, and it does not even pass audit. Please try again.


Fix too agressive Map/MapOf shrinking on deletion leading to out of range panic

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (42e3390) 98.25% compared to head (4550ef2) 98.25%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #113   +/-   ##
=======================================
  Coverage   98.25%   98.25%
=======================================
  Files           8        8
  Lines        1147     1147
=======================================
  Hits         1127     1127
  Misses         16       16
  Partials        4        4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


fix: lets use the user/token in the preview source

so we can always clone the source to remove it

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign jstrachan
You can assign the PR to them by writing /assign @jstrachan in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jstrachan
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jstrachan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Update REAMME.md

Fixed typo.

Hi @anujkumaraurea, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

Small and valid fix. Could you however target this to dev branch as we take all submissions there and merge to master once a month. thx.

Done.


[BUG]: Pushing db.  SyntaxError: Invalid or unexpected token

What version of drizzle-orm are you using?
0.29.3
What version of drizzle-kit are you using?
0.20.10
Describe the Bug
I've just created a turso database and want to push.
I'm getting the following error: SyntaxError: Invalid or unexpected token
paul@Pauls-MacBook-Pro db % pnpm db:push

><EMAIL_ADDRESS>db:push /Users/paul/development/src/golf_cart/packages/db
> pnpm with-env drizzle-kit push:sqlite

><EMAIL_ADDRESS>with-env /Users/paul/development/src/golf_cart/packages/db
> dotenv -e ../../.env -- "drizzle-kit" "push:sqlite"

No config path provided, using default path
Reading config file '/Users/paul/development/src/golf_cart/packages/db/drizzle.config.ts'
drizzle-kit: v0.20.10
drizzle-orm: v0.29.3

/Users/paul/development/src/golf_cart/packages/db/src/schema/.DS_Store:1

SyntaxError: Invalid or unexpected token
    at internalCompileFunction (node:internal/vm:73:18)
    at wrapSafe (node:internal/modules/cjs/loader:1178:20)
    at Module._compile (node:internal/modules/cjs/loader:1220:27)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at newLoader (/Users/paul/development/src/golf_cart/node_modules/.pnpm/drizzle-kit@0.20.10/node_modules/drizzle-kit/bin.cjs:8648:13)
    at Object.newLoader (/Users/paul/development/src/golf_cart/node_modules/.pnpm/drizzle-kit@0.20.10/node_modules/drizzle-kit/bin.cjs:8648:13)
    at extensions..js (/Users/paul/development/src/golf_cart/node_modules/.pnpm/drizzle-kit@0.20.10/node_modules/drizzle-kit/bin.cjs:11176:28)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Module._load (node:internal/modules/cjs/loader:960:12)
    at Module.require (node:internal/modules/cjs/loader:1143:19)

The issue here is that I'm on a mac, so the .DS_Store is automagically created on a new folder?  I think???

/Users/paul/development/src/golf_cart/packages/db/src/schema/.DS_Store:1

I had to remove this file in order for the migration to complete.
Expected behavior
paul@Pauls-MacBook-Pro db % pnpm drizzle-kit push:sqlite
No config path provided, using default path
Reading config file '/Users/paul/development/src/golf_cart/packages/db/drizzle.config.ts'
drizzle-kit: v0.20.10
drizzle-orm: v0.29.3

[✓] Changes applied

Environment & setup
No response

Sorry for the late response!
We will add ignore for .DS_Store, but for now you can just remove it from your folder
Will close this issue, as long as it's resolved and will add this as feature request to the next releases

This is still happening when I run drizzle-kit generate:pg:

drizzle-kit: v0.20.17
drizzle-orm: v0.30.10


Use singular category API param

Fixes

Fixes #1169 by @krysal
Description

This PR replaces plural API parameter categories with singular category, and updates some documentation.
This probably shouldn't be merged until the API fix is deployed because it will break the image category filtering.
Testing Instructions

If you run this as is, filtering by category will return un-filtered result because the production API discards filters that don't exist. If you run it with API from https://github.com/WordPress/openverse-api/pull/583 running locally, you should get filtered results for audio and images.
Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[x] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Noting here that I've marked this PR as low priority because without the deployment of API with the category fix, this would not fix anything, as the singular category parameter would be discarded by the API. And with the API fix deployed, current approach (with categories plural) will still work, and this PR aims for the future version of  the API where categories is deprecated.

Should we mark it back to low?

Honestly, I marked it as critical to highlight the dependency on the API and push the fix there 😆 Wouldn't it be better to use the singular version that we know is not deprecated? or is the intention to keep this open until we deprecated the plural field? 🤔

Great, I understand that it's actually a close to critical issue across the stack. The way the currently deployed API works, using singular category will cause an error, so it's not a good idea to merge this before API is deployed.
After the category fix in the API is deployed (I've merged it just now), both singular and plural versions will work, so then this fix can be applied and deployed.
When we finally change the version from v1, we can finally deprecate the plural categories parameter in the API.

That makes sense. BTW, everything looks good here, I reviewed using the local API with the fix but was almost impossible to find a term with mixed categories results so that could make time to try updating the API sample data too.

@obulat is this blocked until the API is deployed?


not able to select a quick-pick checkbox in the commit: add co author action

commit -> add co-author
type to filter
use the mouse or the keyboard to try to select a user
🐛 it won't work

https://github.com/user-attachments/assets/e06c96d4-9c13-42ad-949a-79fbd8868b2e

@eamodio I believe this is provided by GitLens? gitlens.addAuthors from what I can tell.
This quick pick does something interesting where it listens on selection change and maybe refreshes the data? I can't seem to repro this outside of this quick pick... Can you take a look?

@meganrogge can you open this over at https://github.com/gitkraken/vscode-gitlens/issues ? I'll close this since it's not VS Code... but @eamodio please lmk if you think it's a quick pick bug!

@TylerLeonhardt yeah we try to refresh to keep the selected items at the top of the list (which the quickpick does not make easy). So yeah, please open this on the GitLens repo -- though FWIW, I can't replicate this.


Make the -DFUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION pass tests

Fixes #16428

Please look also here:
https://github.com/openssl/openssl/blob/5327da81f0c70e35bdd8860af9af351313ca4ae2/apps/pkcs12.c#L1137-L1142
this will trip when BMPSTRING with length=0 and data=NULL are now considered "valid".
because of this
https://github.com/openssl/openssl/blob/5327da81f0c70e35bdd8860af9af351313ca4ae2/crypto/pkcs12/p12_utl.c#L45-L59
adding 1 to NULL is undefined, while adding 1 to non-zero object is okay.

Windows CI build failures are unrelated.

IMO this cannot hurt.

No, but I don't like it any better this way, because if wie agree that an asn1 string (NULL,0) is not a valid encoding of an empty string, then it is not right to make some places tolerant to NULL strings and others not.

No, but I don't like it any better this way, because if wie agree that an asn1 string (NULL,0) is not a valid encoding of an empty string, then it is not right to make some places tolerant to NULL strings and others not.

Sorry, I probably missed this. When did we decide (NULL, 0) is not a valid encoding of the empty string? I don't think this is tenable. OpenSSL creates (NULL, 0) empty strings all the time. Every newly-created ASN.1 object is in this state:
https://github.com/openssl/openssl/blob/master/crypto/asn1/asn1_lib.c#L342
https://github.com/openssl/openssl/blob/master/crypto/asn1/tasn_new.c#L317
Outside OpenSSL, a default-constructed std::vector or std::span will happily give you NULL for data(). malloc(0) is allowed to return NULL, and does in many implementations. And if a caller is present with a function that takes pointer/length and wishes to use the empty slice, the natural value for the pointer is NULL.
It is true that memcpy and friends do not handle this right, and you can't compute NULL + 0 (in C; C++ actually fixes this). This is just a mistake in the language, though one C code regrettably needs to work around because some compilers and libcs (GCC and glibc) decided to implement this mistake.
https://www.imperialviolet.org/2016/06/26/nonnull.html
That said, I'm also not a fan of ad-hoc NULL checks. For BoringSSL, we decided workaround around this language flaw piecemeal with too dangerous, so we have OPENSSL_memcpy, etc., inline wrappers that check n == 0 before calling the true function. This is arguably what memcpy should have been. We're saying that, if the compiler can prove n != 0, it is welcome to assume a valid buffer, including non-NULL. Otherwise, it must allow for the no-op case.

Well I did of course not consider a string fully constructed before ASN1_STRING_set is called.
One final request I have:
https://github.com/openssl/openssl/blob/78082769fa8129e3453ee4cb2255feb259846646/apps/pkcs12.c#L1145
Could you please rewrite this to something like
    BIO_printf(out, "%.*s\n", ab->value.utf8string->length, av->value.utf8string->data);

@bernd-edlinger added.
This is master only code.
@paulidale still OK?

Yes, still good.

Marked urgent as this is a potential release blocker and the issue is marked urgent (so the PR should be).

To be merged before the 3.0 branch.

Merged to master. Thank you for the reviews and comments.


Loading overlay disappears too quickly

e.g, before the challenge list has been loaded.

Fixed for challenge list in PR #237


Advanced Chart Index

According to a day trader, additional chart index is attractive feature for traders.
He asked to add some basic index (there are tens of auxiliary index, see https://tradeblock.com/markets/bfnx/xbt-usd/2h  "Technical") into BitShares DEX. These features can be chosen in "Advanced" button (See poloniex's gear button)
The list is as following:

Fib levels (Fibonacci Retracements)
SMA Period
EMA 1 Period
EMA2 Period
Bollinger Band
MACD

(Poloniex provides above)

StochRSI (see bitcoinwisdom)
OBV (On Balance Volume)

IMHO, this has low priority at the moment, but in a long-run it's quite required.

Agreed. I'll mark this as an enhancement but not assign it to a Milestone yet.

This needs to be further broken down, otherwise this issue will just keep getting carried forward.


How can I train svm with my own dataset?

hello
I want to train svm with my own dataset
I wonder about what is Positive_training_set & Negative_training_set
And, in this path, "DATASET\POSITIVE\" & "DATASET\NEGATIVE\", How should I put images, labels, etc?
also, please tell me, what kind of dataset that you used to make "vehicle_detector.yml"
Thanks.

Positive Training Set = It should contain that what you want to detect. For example, if you want to detect and count vehicles, positive training set should contain vehicle images from front and behind view.
Negative Training Set = It should contain except what you want to detect. For example, trees, traffic signs, roads or pedestrians can be negatives for your case.
You should create positive and negative datasets and you should put positive images (jpeg or png) to "DATASET\POSITIVE" path and negative images (jpeg or png) to "DATASET\NEGATIVE" path.
The algorithm needs a lot of positive images (images of vehicles) and negative images (images without vehicles) to train the classifier. Then program will extract features from it automatically.
Be careful about cropping all positive and negative images to same window size (e.g. 24x24).
I created my own dataset. Actually, datasets must be scene specific to reach high accuracy. Therfore, I recommend that you should create your own dataset. To do it automatically, you can use MATLAB, you can click and save images from your scene easily by a MATLAB script. However, you can find public vehicle datasets (you just need images) on the internet.


Prevent memory leaks by unsubscribing to variables, ngOnDestroy

We subscribe to component.valueSelected in auto-complete-directive.ts for example. I think the best practice is to also implement ngOnDestroy and .unsubscribe from observables there.

Yes, exactly. Thanks for the feedback. I will implement it soon. You can also send me a PR if you are in a hurry.

This has been updated with version 0.5.3. Please test.

Looks good on this project. I had trouble pulling in the changes into my own project, however.

Closing, let me know if not fixed.


List the token straight away

Hi, I'd like to know if it possible to add the «List» button, so it would create the token and then list it, so I won't need to manually do it. I guess, it's the most common journey.

Hey @ungarson - this is a great idea.
We will consider adding it as part of the new asset flow as a toggle before creation, to create and list it in a number of ordered transactions.


monitoring bot

usage tfgridmon --wallets wallets.json --env .envfile

env should have

TESTNET_MNEMONIC
MAINNET_MNEMONIC
TFTS_LIMIT='70000'
BOT_TOKEN='telegram token'
CHAT_ID= telegram chat id
MINS='2' checks interval

wallets.json
a simple json file having two lists for mainnet and testnet wallet addresses
{
   "mainnet": [ ] ,
   "testnet": [ ]

   }

should be written in golang

Verified,
I followed the steps to create telegram bot, then created .env and 'wallet.json with info needed and then run make build and bin/tfgridmon -e .env -w wallets.json.
Bot started to send me messages every minute as I specified, Which are warnings that my balance amount is less than threshold specified.


Cow: Watch leathervest.shop

Cow requests the watch of the watch_keyword leathervest\.shop. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

leathervest\.shop has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by VLAZ in Charcoal HQ


Reinsert EF Core usage in UWP projects into documentation

Hi team,
I moved this from here: https://github.com/aspnet/EntityFramework.Docs.pt-br/issues/18
The comments below were machine-translated.
@joaosantana commented 6 hours ago
By adapting the steps described in a solution with a UWP project and a .NET Standard project to the program logic, by running Add-Migration InitialMigrate you receive the following error message:
Startup project 'Recibos' is a Universal Windows Platform app. This version of the Entity Framework Core Package Manager Console Tools doesn't support this type of project. For more information on using the EF Core Tools with UWP projects, see https://go.microsoft.com/fwlink/?linkid=858496
The referenced page is the same, without any information on how to use EF Core tools with UWP projects. as the error message tells you.
Changing the startup project to the .NET Standard project and running the same command returns the following error message:
Startup project 'Recibos.Core' targets framework '.NETStandard'. There is no runtime associated with this framework, and projects targeting it cannot be executed directly. To use the Entity Framework Core Package Manager Console Tools with this project, add an executable project targeting .NET Framework or .NET Core that references this project, and set it as the startup project; or, update this project to cross-target .NET Framework or .NET Core. For more information on using the EF Core Tools with .NET Standard projects, see https://go.microsoft.com/fwlink/?linkid=2034705
This time, the referenced link has sensitive information about the problem, which is the absence of a console project whose function is to be used to run the tools. This scheme was described at https://docs.microsoft.com/ef/core/get-started/uwp/getting-started, which today returns to this page, which in turn does not have any information about using SQLite in UWP applications.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7ac57b24-45aa-e679-6ff9-5a25c369c1ff
Version Independent ID: cc576199-b14c-a135-2291-cc48bf301b4e
Content: Getting Started - EF Core
Content Source: entity-framework/core/get-started/index.md
Product: entity-framework
Technology: entity-framework-core
GitHub Login: @Rick-Anderson
Microsoft Alias: avickers

I'm also experiencing this issue with UWP apps and Entity Framework Core.

The previous page is here https://web.archive.org/web/20190305215707/https://docs.microsoft.com/en-us/ef/core/get-started/uwp/getting-started

See https://docs.microsoft.com/en-us/ef/core/platforms/#universal-windows-platform and also #1838

See https://docs.microsoft.com/en-us/ef/core/platforms/#universal-windows-platform and also #1838

I had read this articlhe. I'm using EF Core 3.0 and Microsoft.NETCore.UniversalWindowsPlatform 6.2.0 already. Not working. I saw the Issue #1838 too. As I stated in my original Issue (https://github.com/aspnet/EntityFramework.Docs.pt-br/issues/18), I'm following the steps described in https://docs.microsoft.com/sv-se/ef/core/get-started/?tabs=netcore-cli and these steps are not working.
I was unable to find the original post, and now it works.
Thank you very much for your search!

@joaosantana you saved my life.
I was unable to find the original post, and now it works.
Thank you very much for your search!

Always a pleasure to be useful to a fellow developer.

@ajcvickers You marked this as closed-duplicate, however the original issue referenced in the Portuguese docs closed their version of the bug, and made this as the primary. Is this issue tracked on another bug?
Also, issue #1838 that you referenced seems to be more about usage within the UWP sandbox (what paths should be used for sqlite), rather than this issue, which specifically has to do with inability to do migrations (and the need to for a .NET Core project do run migrations). As joaosantana linked, a previous version of the Microsoft EF docs included this workaround, but the current ones are missing it.
@joaosantana Thank you for the link.

@iUnknwn We're tracking this holistically with other related things in #1838.

@ajcvickers Thanks for taking care of this. However (at least in my opinion) neither https://docs.microsoft.com/en-us/ef/core/platforms/#universal-windows-platform nor #1838 address this issue. A friend of mine called me for help and spend 15 hours on this issue. After finding this issue, a simple change in the documentation could have avoided that.


Enable golangci-lint nilerr linter, fix errors

I think my golangci-lint update PR will get this new linter working: https://github.com/openshift/release/pull/23023

I think my golangci-lint update PR will get this new linter working: openshift/release#23023

👍 Thanks - I was going to ask you about that 😄 I thought maybe the latest updates to 2.5 etc had updated the golangci-lint version.

/retest

Container test exited with code 2, reason OOMKilled

:thinking:

/retest

Container test exited with code 2, reason OOMKilled

🤔

Cryptic.
golangci-lint run --timeout 10m
make: *** [Makefile:123: golangci-lint] Killed
{"component":"entrypoint","error":"wrapped process failed: exit status 2","file":"prow/entrypoint/run.go:80","func":"k8s.io/test-infra/prow/entrypoint.Options.Run","level":"error","msg":"Error executing test process","severity":"error","time":"2022-01-24T21:07:03Z"}
INFO[2022-01-24T21:07:10Z] Ran for 6m31s
ERRO[2022-01-24T21:07:10Z] Some steps failed:
ERRO[2022-01-24T21:07:10Z]
  * could not run steps: step golangci-lint failed: test "golangci-lint" failed: the pod ci-op-r6jy3sni/golangci-lint failed after 6m25s (failed containers: test): ContainerFailed one or more containers exited

It seems like prow or something timed it out and killed it. Sigh. ☹

The job for another PR succeeded and took 1m 31s. I don't see how just adding the nilerr linter could cause it to take 6m 31s.

Container test exited with code 2, reason OOMKilled

thinking

That means it ran out of memory, perhaps we need to increase the allocated RAM in the job configuration.

Container test exited with code 2, reason OOMKilled

Here's a PR to increase the RAM limits by 50%: https://github.com/openshift/release/pull/25609

/retest

And it's working now :partying_face:

/lgtm

/approve


Render should return this?

It's not an official view convention but I was wondering if the render method should follow ampersand-view and return this after it's done rendering.  Seems confusing to not do so.  I'd be happy to submit a PR with tests if you agree

@mmacaula Good catch! I would agree that all render methods should return this.

Closed by #36.


auto-merge-squash drops all commit messages

Github's squash and merge button suggests all of the commit titles, but strips merge requests. Not sure about [squash] and !fixup commit messages, but would be sensible to strip those as well.

Should we just include a list of commits and their commit messages in the merge commit message, then?

Usually we use squash when a contributor doesn't have a proper commit separation - e.g. create 30 commits as the result of review. So IMO we should pick the PR title / body instead.


[msg] added support for live open auctions in ActiveBids section

🚨 Depends on https://github.com/artsy/metaphysics/pull/751 🚨 ; fixes https://github.com/artsy/collector-experience/issues/493

Fails

:no_entry_sign:

No CHANGELOG added.

TSLint Issues:

:no_entry_sign: config.tsx - prefer-const - Identifier 'metaphysicsURL' is never reassigned; use 'const' instead of 'let'.
:no_entry_sign: config.tsx - prefer-const - Identifier 'gravityURL' is never reassigned; use 'const' instead of 'let'.

  Generated by :no_entry_sign: dangerJS

Nice! 👍


Huge bandwidth consumption of tarball on pub.dev

The large binary GIFs stored in the repo take up a huge amount of space and bandwidth, both while fetching from pub.dev and cloning the git repo. Merely adding the following to .pubignore would reduce the published tarball size on pub.dev from a gigantic 35 MB to just several hundred kilobytes:
cta/
gif/

Hi @arafatamim
Thanks for pointing that out! You're absolutely right — those large binary GIFs were taking up way too much space and weren’t really necessary in the published package.
We’ve already removed them from the package so, closing this issue.


Invoke Botframework Bot deployed on facebook channel from an external website

SDK: .Net Version 4 botframework
I want to invoke my Bot that is deployed on FB messenger with a call from my website. I need to gather some parameters from my users and then redirect them to my Facebook messenger. Based on these parameters I will be making an API call and display carousels to my users on facebook messenger.
So i need to :

pass parameters from the website to messenger
invoke the relevant dialog to display carousels.

thanks in advance

The Microsoft Bot Framework team prefers that how to questions be submitted on Stack Overflow. The official Bot Framework Github repos are the preferred platform for submitting bug fixes and feature requests.
Please post your how-to question on Stack Overflow for the community to assist.


Feature Request: async preprocess

I’m trying to parse some minecraft NBT data with zod. However, in order to do this, one key of the object (item_bytes) first needs to be converted from the binary NBT format to a JSON-like structure.
The best way to implement this in my opinion would be to use zod’s z.preprocess(). Unfortunately, the library I’m using prismarine-nbt only exposes parse as an async function.
As far as I can tell, async preprocessing is not supported right now. I think it would be great if it’s allowed as it would really simplify parsing with async libraries.
I’d suggest either z.preprocess(async () => { /* ... */ }, z.any()) or z.preprocessAsync(async () => { /* ... */ }, z.any()) as I think either would be reasonable from an API standpoint.

Yep, seems like an oversight, should be a quick addition. I'll look into it.

@stale this issue is still relevant

@stale don’t

@stale don't

@stale don't

@stale don’t

A simply workaround:
z.preprocess(
  async (value) => {
    // ...
  },
  z.promise(someSchema), //  Wrap your own schema with a promise schema.
);

Any updates on this?


Bug Fix:

clusteradm clean didn't remove the boostrap-token in kube-system #314
see: https://github.com/open-cluster-management-io/clusteradm/issues/314

Thank you for your contribution!
/assign @ycyaoxdu

/approve

@USER0308 could you please amend your commit with a signature?
git commit -s --amend
git push -f ........

hi, thanks for your contribution! You would need to signoff the commit
git commit --amend -s
git push -f

Hi, @mikeshng ,I have added a signature as you metioned above, please help me to review and check again. Thanks a lot! ^_^

/lgtm


How to check for prompt and include it in response text

Thanks for the great package,
My response is XML and I'm able to get the response (and avoid the endless loop #17 ) by using the below command
$response = $client->execute($command,preg_quote('</response>','/'));

I'm waiting for </response>
However getResponseText() returns everything but the </response> invalidating the xml.
How do I keep the end sequence in the response please?
Thank you!

Hi, sorry for the slow reply.
The current implementation assumes the $prompt is not an important part of the response and chops it off.
As a workaround, you could make your $prompt pattern match the whole response then use $response->getPromptMatches().
Assuming your response looks something like
<response><something attrib="something"><nested></nested></response>

Your prompt could be something like ^<response>.*<\/response>$.
Version 3 is underway and would match your use case better, but it's still a little way off.

Hey John
Thanks for getting back to me, I was simply concatenating </response> on the end of the response text 😜 your solution seems more elegant for now until Version 3! Looking forward to it,
Thank you!


Delete remote branch hangs

Since upgrading from 1.6 to 1.8 deleting a branch sometimes hangs.
~/Projects/repo master
❯ git push origin --delete featureBranch
remote: Updating references: 100% (1/1)

After ctrl+c and pushing the delete again, the branch is gone:
^C
~/Projects/repo master  5m 27s
❯ git push origin --delete featureBranch
error: unable to delete 'featureBranch': remote ref does not exist
error: failed to push some refs to 'https://gitblit/r/repo.git'

I checked the logs, but all I found was a hint of my push in stdout.log
2017-01-25 15:55:54 [INFO ] ARF: authenticated user to repo.git/info/refs?service=git-receive-pack (100)
2017-01-25 15:55:55 [INFO ] ARF: authenticated user to repo.git/git-receive-pack (100)

Any ideas how to get the cause of this problem?

@mystygage I've experienced this on occasions back on a 1.7.1 deployment but it appeared to coincide with an update of the git client.  Could this perhaps be the same for you?  I seem to recall there was a update done on the client file system cache (at least for windows version of git) not sure if it's related somehow.

@paulsputer thanks for your feedback. I use git 2.11.0 on macOS.
I'm 99% sure that I updated git a week or two ago and that my problems with deleting branches started after upgrading to the newest gitblit version. I'll do a rollback to 1.6 and try this again.

After downgrading to 1.6 the problem is gone. Perhaps this problem is also repository related, unfortunately I can't share this repository in a public place.
~/Projects/repo featureBranch
❯ time git push origin --delete featureBranch
remote: Updating references: 100% (1/1)
To https://gitblit/r/repo.git
 - [deleted]             featureBranch
git push origin --delete featureBranch  0.04s user 0.04s system 1% cpu 5.655 total

Hmm.  Difficult to pinpoint.  There have been alot of dependency updates since 1.6.0.  Perhaps a JGit update introduced a regression.  Not sure.  Does it make a difference if you use this syntax?
git push origin :featureBranch

I think it was somehow hardware related... We recently switched to faster hardware and I upgraded gitblit again to 1.8. Now everything works fine


Todo:

finish the window, minimize to tray. (line79)
Modification notification mechanism. (line90)

Modification notification mechanism. (line90)
Finished!


Change Permissions API

Change Permissions API
Fixes #1605, which in turn fixes #1589

Get rid of OPTIONS endpoints for querying permissions

Rolled back change to swagger-java-client which enabled OPTIONS

The /path/workflow/{repository}/permissions endpoint would
previously fail if you weren't an owner. Now:

If you are an owner, returns all permissions for the workflow
If you have non-owner permissions on the workflow, returns
only your permission.
If you have no permission on the workflow, returns 403

In SAM, since only an owner can get the permissions, derive the
current user's permission by seeing what actions she can do.
InMemoryPermissionsImpl wasn't following the contract very closely,
e.g., anybody could have set a permission; now it forces you to be an
owner

Coverage decreased (-8.2%) to 66.155% when pulling 576355c353759a0a962687c1772852f53c4d4068 on feature/1605/permissionsendpoint into eb78c477ff8fbfd80489fd0af4f8d2a1431930a2 on develop.


[Bug] Fix navigation flow

Closes #245
MainActivity handles the flow of the app (navigation) irrespective of the current displayed fragment.  The problem with the current approach was we that we were not respecting the actual nav_graph intended for this purpose.
There are multiple paths for the flow, we need to use different NavDirections based on the current visible fragment. To address that, I've used the NavController to determine which fragment is currently loaded.
Nodes (excluded rest of the fragments here since their behavior is fine):

Start Fragment
Login Screen
Home Screen
Exit

Case 1:
Fresh app install
1 --> 2 --> 3
Back press from 2 or 3 should exit the app
Case 2:
Already logged in
1 --> 3
Back press from 3 should exit the app
Case 3:
Logging out
1 --> 3 --> 2
Back press from 3 or 2 should exit the app

Is the problem that Global actions behave differently than we expect w.r.t. up/back? If so, why doesn't it?

I might be wrong as I couldn't find a similar blog or post but IMO the problem with Global Actions is that it doesn't pop the fragments up in the navigation stack while starting the new fragment.

I might be wrong as I couldn't find a similar blog or post but IMO the problem with Global Actions is that it doesn't pop the fragments up in the navigation stack while starting the new fragment.

I believe that's what this article is saying, actually (skimmed it quickly).

MainActivity handles the flow of the app (navigation) irrespective of the current displayed fragment. The problem with the current approach was we that we were not respecting the actual nav_graph intended for this purpose.

Is this a problem because we need to call the getNavController() on the Fragment we're navigating away from instead of the one provided by the Activity? My understanding is that they're the same instance.
@cketcham in case you have anything to add.

Is this a problem because we need to call the getNavController() on the Fragment we're navigating away from instead of the one provided by the Activity? My understanding is that they're the same instance.

I've fetched NavDirections based on the current visible fragment. For that purpose only, I used the NavController. The instance is same like you said


[BUGFIX] Update hash of wiki_cn_cased and wiki_multilingual_cased vocab

Description
Fix the bug mentioned in #652 . wiki_cn_cased vocab and wiki_multilingual_cased vocab have been converted. Now update the hash code of the relevant vocab.
Checklist
Essentials

[x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[x] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage
[ ] Code is well-documented

Changes
Comments

Job PR-655/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-655/1/index.html

Are there unit tests to validate this?

Ok, I will add unit tests later.

Job PR-655/2 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-655/2/index.html


Move to .NET Standard 2.0

Fixes https://github.com/commandlineparser/commandline/issues/284
I'm from the .NET team and we are currently using this package in of our repos xunit-performance. As we are facing some package downgrades with the existing nuget package I upgraded it to target NS2.0.
Changes:

src assembly commandline.dll now targets netstandard2.0 and the xunit test library commandline.tests now targets netcoreapp2.0 (not 2.1 as I wasn't sure if the CI already uses the 2.1 SDK)
Updated dependencies (xunit, FluentAssertions)
Enable test run in CI. After updating the dependencies 20 tests failed because they are asserting of string which changed by xunit. I recommend removing such flaky tests. I disabled them for now: https://github.com/commandlineparser/commandline/pull/307/commits/f151ae1c35ab094387cd3d2409bbcd7135df441a
Replace Paker with the new in-built PackageReference and copy the 4 used files manually into the project to avoid adding new nuget dependencies
Replace nuspecs with the new in-built csproj attributes
Converge Test projects
Update build scripts

Requirements:

Visual Studio 2017
.NET Core SDK >= v2.0

Please let me know if you have any questions.

Why? When target only netstandard2.0 it brings many dependencies which are included in full framework.

This is resolved with >=net472 when referencing a netstandard2.0 library as it is the first version that doesn't need an additional support targeting pack to fully satisfy the netstandard2.0 surface area.

.NET Framework on Windows 10 is updated with OS itself. For example I have
device (Tablet with sensor) which is used in hardware project. It Win10
version cannot be updated because it connected only with Modbus/Ethernet
devices.
This is why MS make multitarget in projects. Some library must exist in
most major .NET versions
чт, 26 Июл 2018, 19:08 Viktor Hofer<EMAIL_ADDRESS>
Why? When target only netstandard2.0 it brings many dependencies which are
included in full framework.
This is resolved with >=net472 when referencing a netstandard2.0 library
as it is the first version that doesn't need an additional support
targeting pack to fully satisfy the netstandard2.0 surface area.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/commandlineparser/commandline/pull/307#issuecomment-408150211,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIQ7OwPuGANpK_XuVzKxwtfO6dZXyrtsks5uKemYgaJpZM4VYDWr
.

This is why MS make multitarget in projects. Some library must exist in
most major .NET versions

Wrong. The reason why we added multitargeting is convenience. Instead of having several different project files you now just have one and cross-compile.

Some library must exist in most major .NET versions

That's what .NET Standard is for.
I don't have a strong opinion. I can add the net470 tfm is you want so. But first I would like to see a response from one of the project maintainers to understand if and when they are willing to merge this PR.

Thanks for your work on this PR.  Lot of changes but I'm thinking a lot of them are definitely "for the better", since NetStandard-2.0 baseline removes a lot of unnecessary framework probing.
Although I do have exactly one issue of trying to get the library to run on NetFramework-3.5 but it is just a single ask for the time being.
@nemec and i are evaluating this and we're thinking of bumping to v3 just to throw off all the old.  Although I kinda wanted to remove some of the (weird-to-C#-people) F#-isms and introduce a fluent interface similar to Commander (https://www.npmjs.com/package/commander) for the v3 bump, we can probably reserve that for the v4 bump instead.

I just tell about problem which I found.
I have device with Windows 10 (don't remember version but .NET Framework
4.6 work fine). It comes in IP65 and connected to other device with cable.
I cannot update Windows without losing warranty. So I cannot run 4.7 apps
on it.
I asked manufacturer about this - answer was "no problem, we make it even
co cost, but it takes 5 work days". I just recompile all sources on 4.6 and
forget about this problem, it takes less than 10 min.
This is a reason why I think that one of the target frameworks must be .NET
Framework which is shipped with Windows 10 RTM (I don't remember number). I
hate outdated technologies but for Windows 10 .NET Framework update process
can be complicated for embedded devices or devices which a used as embedded
пт, 27 Июл 2018, 22:35 Viktor Hofer<EMAIL_ADDRESS>
This is why MS make multitarget in projects. Some library must exist in
most major .NET versions
Wrong. The reason why we added multitargeting is convenience. Instead of
having several different project files you now just have one and
cross-compile.
Some library must exist in most major .NET versions
That's what .NET Standard is for.
I don't have a strong opinion. I can add the net470 tfm is you want so.
But first I would like to see a response from one of the project
maintainers to understand if and when they are willing to merge this PR.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/commandlineparser/commandline/pull/307#issuecomment-408518575,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIQ7OwRWMzVOzcErAhUFp2IasGsepFkAks5uK2uHgaJpZM4VYDWr
.

@ericnewton76 great to hear. Please let me know what's necessary to get this merged. I really would like to get this into master asap as we internally depend on this library and right now using a forked release.

@ViktorHofer merged your PR into a specific branch: ViktorHofer-netstandard20, just a few questions:
Just wondering whats the correct course of action on these two:

I see several //[Fact] and xunit warns that the associated test should be marked with Fact
Same with //[Theory],

fyi, will finalize this later today.

ok thanks. what about our Paket discussion?

Any updates?

This would be great to have, hitting NETStandard issues here

This is a huge improvement and I would love to see this get merged in ASAP as well. Thanks!

CSharpx is still pre-release since three years. csharpx
So, copying files is better than paket do that job.
With the integration of msbuild 15.1  with nuget and using PackageReference  are becoming better than using Paket.

ping @ericnewton76

Sorry, ran into a hellacious work issue just before a little R&R.
I'll try to push this out sometime this week.

please generate nuget for .net standard 2.0

@ericnewton76 please please please merge
https://github.com/commandlineparser/commandline/issues/351

I  did git clone to the project and merged the branch  'ViktorHofer-netstandard20' on my machine.
The compilation is successful
The unit test is successful for total 326 unit test cases.
I tested the project for  multi-target (net45 and netstandard2.0) and compilation/unit test pass successfully.
The Conflicting files:
The file: 'tests/CommandLine.Tests/CommandLine.Tests.csproj':  no problem  because it's the old project file.
The file 'tests/CommandLine.Tests/Unit/Core/InstanceBuilderTests.cs'  is expected because there are many modification  due to the breaking change of FluentAssertions library version "5.4.1"
For example, the line#127
       ((NotParsed<Options_With_Required_Set_To_True>)result).Errors.ShouldBeEquivalentTo(expectedResult);

is modified by ViktorHofer  to
        ((NotParsed<Options_With_Required_Set_To_True>)result).Errors.Should().BeEquivalentTo(expectedResult);

So I suggest merging 'ViktorHofer-netstandard20'  branch, resolving  the confliction based on the above notes and select (theirs) of ViktorHofer modifications.

Ugh. Really would love to have this. This is a blocking issue for anyone wanting to use this library from .net core.

@moh-hassan oh man, thanks for doing that pull, I've been unable to find some time to devote to it lately.
This really helps me out, knowing that somebody's been able to independently verify it (I have to get latest NetCore even installed yet)
Will respond back here when I can pull a few hours for this.  Should be able to this week! ::Fingers crossed::

@ericnewton76
Glad to hear that Netstandard2.0 is coming soon :)
Let me know for any help needed to publish Netstandard2.0

bump

@ericnewton76 Thanks for such a great library. Is there any ETA on when this will be merged? Currently blocked with netstandard issue

Bump, any news?

Please merge this and release a new NuGet package. 🍺

@ericnewton76 what's the status? I feel kind of neglected.

At some point someone is just going to have to fork this repo and publish a new NuGet package. 😕

I also hope there will be multi-targeting for the nuget package - I think netstandard2.0;net461 should work but I hope the netfx version can be lower (e.g. net45). Or, maybe there could be 2 separate packages, one for .NET Standard (netfx>=472 & netcore) and one for .NET fx (netfx < 472 & maybe netfx < 4).
The point is, .NET fx 4.7.2 is not that popular especially in those old Win7 users. I'm not going to ask every user to install .NET fx 4.7.2 since it's not actually necessary for our functionality. when I set lower .NET fx versions for my project (net461), this lib adds so many System.*.dll to my release. I understand these dlls are just for redirection and are small in size, but it still looks redundant.

I'm not going to ask every user to install .NET fx 4.7.2

Most of your customers/users should have net472 already installed as it's deployed over Windows Update. I don't see any reason to target a lower netfx version?

Well, if a user is still using Win7, you can imagine he/she won't even turn on Windows Update to let MS notice him/her to update to Win10.
Thanks for the reply, and I'm going to handle this problem (compile a net46 version) by myself.

Well, if a user is still using Win7, you can imagine he/she won't even turn on Windows Update to let MS notice him/her to update to Win10.

I wouldn't recommend that as you would be an easy target for tons of exploits. Being online without having the latest security patches (which includes .NET Framework) is like using the metro without having a ticket - risky.

You're definitely right, but some users may just choose to install minimal security updates without any functionality updates like .net, or they uninstall that for some reasons IDK... Anyway, I don't think I can just rely on Windows Update to install netfx 4.7.2 for everyone. And, I would like to see more users using my programs, rather than switching to others just because I require them to install netfx 4.7.2 which has seldom things to do with the actual functionality.

I see. Why not use .NET core instead with which you can deploy the framework together with your app?

The same reason - it looks redundant with many files, and bigger.
Thank you for listening to my complaints. Targeting to lower .net version is a compromise and I should just do it by myself. As a developer, I would be happier if my program runs perfectly from WinXP to Win10, rather than "although .net 4.5 is enough for all functions in my program, you still need .net 4.7 if you don't want to mess up with a bunch of files".
Thanks for developing such a nice library anyway!

The same reason - it looks redundant with many files, and bigger.

You probably want to wait for .NET Core 3.0 where you can link everything down to a single file.

Thanks for developing such a nice library anyway!

I'm not the author 😁

Ah, I fogot what Author means in github issues. Plus there is also a Contributor label. Sorry for that.
But I'm also glad that I can talk about these with a .net team member!


Add some user state to sprites

A field that PXT ignores. we talked about a number but a string (e.g. "name") might be better

I do not understand this issue. If this is till relevant, can you add more info and reopen.

This was referring to a field to maintain some state for a given sprite - examples where it could be used could be in identifying specific sprites of the same kind (e.g. fruits in pacman that award different scores when eaten but otherwise behave the same) or to keep track of values specific to a given sprite - for example, how many times the player has collided with a given obstacle.


Add wdio tests for terra-clinical-application

Summary
Resolves #300
Thanks for contributing to Terra.
@cerner/terra

Any chance we can use a different screenshot to reduce the size? They are pretty large for the content they contain.

Any chance we can use a different screenshot to reduce the size? They are pretty large for the content they contain.

@JakeLaCombe I can test screenshots only for smaller viewports  if you want me to. But we have been testing for all the viewports in the nightwatch tests.