IR failing in the TypePropagation pass.

What happened?
error stack trace: /home/prashant/hxy.mlir:12:13: error: 'arith.constant' op failed to verify that all of {value, result} have same type
    %3223 = linalg.generic {indexing_maps = [#map19, #map8, #map8, #map8], iterator_types = ["parallel", "parallel", "parallel", "parallel"]} ins(%cst_278, %cst_14, %cst_15 : tensor<1x1x1x8xi1>, tensor<2x1024x8x8xf32>, tensor<2x1024x8x8xf32>) outs(%1686 : tensor<2x1024x8x8xf32>) {
            ^
/home/prashant/hxy.mlir:5:1: note: called from
func.func @forward() -> tensor<2x1024x8x8xf32> {
^
/home/prashant/hxy.mlir:12:13: error: failed to run translation of source executable to target executable for backend #hal.executable.target<"llvm", "embedded-elf-x86_64", {cpu_features = "-avx512pf,-tsxldtrk,+cx16,+sahf,-tbm,-avx512ifma,+sha,+crc32,-fma4,+vpclmulqdq,+prfchw,+bmi2,-cldemote,+fsgsbase,-ptwrite,-amx-tile,-uintr,-gfni,+popcnt,-widekl,+aes,-avx512bitalg,-movdiri,+xsaves,-avx512er,-avxvnni,-avx512fp16,-avx512vnni,-amx-bf16,-avx512vpopcntdq,-pconfig,+clwb,-avx512f,+xsavec,+clzero,+pku,+mmx,-lwp,+rdpid,-xop,+rdseed,-waitpkg,-kl,-movdir64b,+sse4a,-avx512bw,+clflushopt,+xsave,-avx512vbmi2,+64bit,-avx512vl,-serialize,-hreset,+invpcid,-avx512cd,+avx,+vaes,-avx512bf16,+cx8,+fma,-rtm,+bmi,-enqcmd,+rdrnd,+mwaitx,+sse4.1,+sse4.2,+avx2,+fxsr,+wbnoinvd,+sse,+lzcnt,+pclmul,-prefetchwt1,+f16c,+ssse3,-sgx,+shstk,+cmov,-avx512vbmi,-amx-int8,+movbe,-avx512vp2intersect,+xsaveopt,-avx512dq,+sse2,+adx,+sse3", data_layout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128", native_vector_size = 32 : index, target_triple = "x86_64-unknown-unknown-eabi-elf"}>
    %3223 = linalg.generic {indexing_maps = [#map19, #map8, #map8, #map8], iterator_types = ["parallel", "parallel", "parallel", "parallel"]} ins(%cst_278, %cst_14, %cst_15 : tensor<1x1x1x8xi1>, tensor<2x1024x8x8xf32>, tensor<2x1024x8x8xf32>) outs(%1686 : tensor<2x1024x8x8xf32>) {
            ^
/home/prashant/hxy.mlir:5:1: note: called from
func.func @forward() -> tensor<2x1024x8x8xf32> {
^
/home/prashant/hxy.mlir:12:13: error: failed to serialize executables
    %3223 = linalg.generic {indexing_maps = [#map19, #map8, #map8, #map8], iterator_types = ["parallel", "parallel", "parallel", "parallel"]} ins(%cst_278, %cst_14, %cst_15 : tensor<1x1x1x8xi1>, tensor<2x1024x8x8xf32>, tensor<2x1024x8x8xf32>) outs(%1686 : tensor<2x1024x8x8xf32>) {
            ^
/home/prashant/hxy.mlir:5:1: note: called from
func.func @forward() -> tensor<2x1024x8x8xf32> {
^
compilation failed

Steps to reproduce your issue
#map0 = affine_map<(d0, d1, d2, d3) -> (0, 0, 0, d3)>
#map1 = affine_map<(d0, d1, d2, d3) -> (d0, d1, d2, d3)>
module {
  func.func @forward() -> tensor<2x1024x8x8xf32> {
    %cst = arith.constant opaque<"elided_large_const", "0xDEADBEEF"> : tensor<2x1024x8x8xf32>
    %cst_0 = arith.constant opaque<"elided_large_const", "0xDDADBEEF"> : tensor<2x1024x8x8xf32>
    %cst_1 = arith.constant dense<[[[[true, true, true, false, true, false, true, false]]]]> : tensor<1x1x1x8xi1>
    %0 = linalg.init_tensor [2, 1024, 8, 8] : tensor<2x1024x8x8xf32>
    %1 = linalg.generic {indexing_maps = [#map0, #map1, #map1, #map1], iterator_types = ["parallel", "parallel", "parallel", "parallel"]} ins(%cst_1, %cst, %cst_0 : tensor<1x1x1x8xi1>, tensor<2x1024x8x8xf32>, tensor<2x1024x8x8xf32>) outs(%0 : tensor<2x1024x8x8xf32>) {
    ^bb0(%arg0: i1, %arg1: f32, %arg2: f32, %arg3: f32):
      %2 = arith.select %arg0, %arg1, %arg2 : f32
      linalg.yield %2 : f32
    } -> tensor<2x1024x8x8xf32>
    return %1 : tensor<2x1024x8x8xf32>
  }
}

Run the above IR with the following command:
iree-compile  --iree-input-type=none --iree-vm-bytecode-module-output-format=flatbuffer-binary --iree-hal-target-backends=dylib --mlir-print-debuginfo --mlir-print-op-on-diagnostic=false --iree-llvm-target-cpu-features=host -iree-llvm-target-triple=x86_64-linux-gnu --iree-stream-resource-index-bits=64 --iree-vm-target-index-bits=64
What component(s) does this issue relate to?
MLIR, Compiler
Version information
Current Main
Additional context
No response

#9867 fixes the compilation, but I dont know if this works end-to-end.... This depends on how LLVM lowers a global static array with i1 types. If LLVM supports this natively, then this should fix the problem. The repro here does not compile e2e due to the opaque constants.

Added a test for i1 constant type. That fails somewhere during binary serialization
<unknown>:0: error: unhandled integer element bitwidth 1 for type 'tensor<4xi1>'
iree-compile: iree/third_party/flatcc/src/runtime/builder.c:1833: flatcc_builder_ref_t *flatcc_builder_table_add_offset(flatcc_builder_t *, int): Assertion `(B->frame[0].type) == flatcc_builder_table' failed.
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
Stack dump:
0.      Program arguments: /usr/local/google/home/ravishankarm/iree/build_debug/tools/iree-compile --output-format=vm-bytecode --mlir-print-op-on-diagnostic=false --iree-hal-target-backends=vmvx --iree-input-type=mhlo /usr/local/google/home/ravishankarm/iree/iree/tests/e2e/regression/linalg_ops.mlir -o check_regression_vmvx_linalg_ops.mlir_module.vmfb --iree-llvm-embedded-linker-path=\"/usr/local/google/ho\
me/ravishankarm/iree/build_debug/third_party/llvm-project/llvm/bin/lld\" --iree-llvm-wasm-linker-path=\"/usr/local/google/home/ravishankarm/iree/build_debug/third_party/llvm-project/llvm/bin/lld\" --mlir-print-ir-after-all --mlir-print-ir-before-all --mlir-disable-threading
Stack dump without symbol names (ensure you have llvm-symbolizer in your PATH or set the environment var `LLVM_SYMBOLIZER_PATH` to point to it):

Need some input from @benvanik about way forward here. If we cannot support a non-splat i1 constant within the dispatch, I can change the type legalization pass that is failing to handle this. Holding off till I hear from Ben, in case there is a different solution.

Is that vmvx?
outside of vmvx it shouldn't be possible for i1 tensor constants to survive to serialization - i1 is not supported in VM land outside of rodata and we do the i1->i8 expansion early: https://github.com/iree-org/iree/blob/c6616e0dc3075fd7b5a6d08ae52f2d1b03bf9cc7/compiler/src/iree/compiler/Dialect/Stream/Transforms/EncodeTensors.cpp#L286.
If this is vmvx we'll likely need something similar. AFK but a print ir after all would be useful to see what op we could cut in at.

This is a case where its a non-splat arith.constant that is inlined into the dispatch. See test case here https://github.com/iree-org/iree/pull/9867/files

K - can't get a dump from my phone :)
But the right way to do this is probably to get us off memref and on to util.buffer in vmvx, which does have lowerings with i1 support. A shorter term workaround would be to do the widening like stream does in MemRefToVM.

Here is the gist dump https://gist.github.com/MaheshRavishankar/cf8057b943a4f00d1dddd446ec2fcdc0
(Also dont look at it form phone this can wait till you are back :) )

eh, fun fact. Doesnt work on any backend. So I will fix the type converter to expand i1 types to i8 types as well.

https://github.com/iree-org/iree/pull/9867 should now work e2e. Passes on all backends.

@MaheshRavishankar https://github.com/iree-org/iree/pull/9867 fixes the issue. Thanks for the fix.


Sync Changes to GitHub not working

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:  Feb 2023 Recovery
OS Version: Windows

Steps to Reproduce:

Commit
Sync changes to Github
Doesn't sync

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.76.1. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Hi, I managed to fix the issue. My Github needed authentication to VS CODE.


Fixed list-s to update schedules before today after the day has passed

Typing list-s after passing 12am today will update schedules today to past schedules.

I think you can remove all calls to sort() in other methods. Sorting here ensures that the list is sorted every time someone gets the schedule list from the addressbook.

Updated in https://github.com/AY2324S1-CS2103T-T17-3/tp/pull/306/commits/e3a3a946157857958c646bd619bdcf983cc8e1b2

I think you can remove all calls to sort() in other methods. Sorting here ensures that the list is sorted every time someone gets the schedule list from the addressbook.

Updated in e3a3a94

Failing test cases, reverted one sort() call in add() method to ensure model returns the correct state of lists. Updated in https://github.com/AY2324S1-CS2103T-T17-3/tp/pull/306/commits/48be313a684e1d273d1ace9a05689f556774d148.

I think you can remove all calls to sort() in other methods. Sorting here ensures that the list is sorted every time someone gets the schedule list from the addressbook.

Updated in e3a3a94

Failing test cases, reverted one sort() call in add() method to ensure model returns the correct state of lists. Updated in 48be313.

Sorry my bad, if this is the case, I think it might just be better to just call sort() for all methods modifying the list as well.

I believe if you pull and merge master into this branch, it should stop failing codecov!


Make a note on deploying new libraries into GAE.

I think it is worth clarifying the docs.
Thanks

Not sure why it's not being deleted sometimes.. maybe it's better to find this bug! :) But for now I'll merge it..


Release 0.3.7

Since the version has been updated in the code and in the changelog, do you mind to release the tar.gz so I can update the brew formula?

No 0.3.7. Was just a mistake in the changelog og the tiling plugin.


theme support

Codecov Report

Merging #82 (57f11e6) into prep-release (b2bfa7b) will increase coverage by 0.25%.
The diff coverage is 62.00%.

@@               Coverage Diff                @@
##           prep-release      #82      +/-   ##
================================================
+ Coverage         46.18%   46.43%   +0.25%
================================================
  Files               120      122       +2
  Lines              4179     4221      +42
================================================
+ Hits               1930     1960      +30
- Misses             2249     2261      +12

Impacted Files
Coverage Δ

src/fullctl/django/views/__init__.py
42.85% <ø> (-1.15%)
:arrow_down:

src/fullctl/django/templatetags/fullctl_util.py
52.50% <13.63%> (-47.50%)
:arrow_down:

src/fullctl/django/admin.py
61.53% <100.00%> (+1.53%)
:arrow_up:

...llctl/django/migrations/0024_auto_20221012_1227.py
100.00% <100.00%> (ø)

...llctl/django/migrations/0025_auto_20221025_1215.py
100.00% <100.00%> (ø)

src/fullctl/django/models/concrete/account.py
89.43% <100.00%> (+1.06%)
:arrow_up:

src/fullctl/django/models/concrete/tasks.py
75.09% <0.00%> (+0.81%)
:arrow_up:

...l/django/management/commands/fullctl_poll_tasks.py
27.17% <0.00%> (+1.13%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


chore: Update auth token for public repo

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Make verbose=False prevent showing "Saving latest checkpoint..."

🚀 Feature
Currently Lightning prints:
[lightning][INFO] - Saving latest checkpoint...

when running training with ModelCheckpoint(verbose=False).
Not sure if it's a bug or intended...
Can we make it to not log that when passing verbose=False?

Sure, just need to check the verbose attribute of the checkpoints here:
https://github.com/PyTorchLightning/pytorch-lightning/blob/38a5fe7af1ba300aa95d7716b5bdee35d52d032b/pytorch_lightning/trainer/training_loop.py#L157-L158
Do you want to open a PR with the fix?

@carmocca I made a PR https://github.com/PyTorchLightning/pytorch-lightning/pull/6419.


[tool] The fallback to the directory name for --project-name is non-obvious for users

Steps to reproduce

flutter create name_bug --platforms=android
mv name_bug name-bug (so that the project directory is not a valid Dart identifier)
cd name-bug
flutter create . --platforms=web
The tool exits with an error about the project name not being a valid Dart name

Expected results
I would expect the tool to take the name field of the pubspec.yaml, and only if that is invalid, go look at the directory name.
We could also improve the error message:

if the pubspec name is invalid, print a warning indicating the pubspec name is invalid and we're going to use the current directory name
if both the pubspec name and directory name are invalid, print a warning indicating that the project name is invalid and that we tried looking at the pubspec name and directory name

Actual results
The tool uses the project directory basename, per https://github.com/flutter/flutter/blob/c63339866d4f7477777e7377bf044f14b743f71c/packages/flutter_tools/lib/src/commands/create_base.dart#L322-L336
but never specified that in the error message, causing some confusion.
Code sample
Code sample
N/A

Screenshots or Video

Screenshots / Video demonstration
N/A

Logs
Logs
navaronbracke@MacBook-Pro-van-Navaron ~ % cd Desktop
navaronbracke@MacBook-Pro-van-Navaron Desktop % flutter create name_bug --platforms=android
Creating project name_bug...
Resolving dependencies in `name_bug`...
Downloading packages...
Got dependencies in `name_bug`.
Wrote 35 files.

All done!
You can find general documentation for Flutter at: https://docs.flutter.dev/
Detailed API documentation is available at: https://api.flutter.dev/
If you prefer video documentation, consider: https://www.youtube.com/c/flutterdev

In order to run your application, type:

  $ cd name_bug
  $ flutter run

Your application code is in name_bug/lib/main.dart.

navaronbracke@MacBook-Pro-van-Navaron Desktop % mv name_bug name-bug
navaronbracke@MacBook-Pro-van-Navaron Desktop % cd name-bug
navaronbracke@MacBook-Pro-van-Navaron name-bug % flutter create . --platforms=web
"name-bug" is not a valid Dart package name.

The name should be all lowercase, with underscores to separate words, "just_like_this".Use only basic Latin letters and Arabic digits:
[a-z0-9_].Also, make sure the name is a valid Dart identifier—that it doesn't start with digits and isn't a reserved word.
See https://dart.dev/tools/pub/pubspec#name for more information.
Try "name_bug" instead.
navaronbracke@MacBook-Pro-van-Navaron name-bug %

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.22.1, on macOS 14.4.1 23E224 darwin-x64, locale
    en-BE)
    • Flutter version 3.22.1 on channel stable at
      /Users/navaronbracke/Documents/flutter
    • Upstream repository git@github.com:navaronbracke/flutter.git
    • FLUTTER_GIT_URL = git@github.com:navaronbracke/flutter.git
    • Framework revision a14f74ff3a (4 weeks ago), 2024-05-22 11:08:21 -0500
    • Engine revision 55eae6864b
    • Dart version 3.4.1
    • DevTools version 2.34.3

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/navaronbracke/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/navaronbracke/Library/Android/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      17.0.10+0-17.0.10b1087.21-11572160)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15F31d
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      17.0.10+0-17.0.10b1087.21-11572160)

[✓] VS Code (version 1.90.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.90.0

[✓] Connected device (3 available)
    • motorola one (mobile) • ZL5228NFL7 • android-arm64  • Android 10 (API 29)
    • macOS (desktop)       • macos      • darwin-x64     • macOS 14.4.1 23E224
      darwin-x64
    • Chrome (web)          • chrome     • web-javascript • Google Chrome
      126.0.6478.62

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Additional context
I had cloned a project through a version control program (i.e. Github Desktop) where I could create a new folder to clone the project in. Since I had given that folder a kebab-case name, I ran into this bug.

Hi @navaronbracke, I believe this is a duplicate of  https://github.com/flutter/flutter/issues/53106
Kindly follow up in the original issue for updates. Please feel free to share your comments in there.
Closing this in favour of the issue linked above.
Thank you


Bug 196: Modals incorrectly displayed on smaller screen resolutions

This PR:

Fixes #196 by allowing user to scroll modal view if it overflows the viewport

Travis automatic deployment:
https://pr284--safereact.review.gnosisdev.com
Storybook book automatic deployment:
https://pr284--safereactstorybook.review.gnosisdev.com

Ideally, it would have some spacing below the modal after scrolling. But because the low screen resolution is not the most common case, I wouldn't put the effort into this right now.


Incorrect dependency type of immutable

Should immutable be peerDependency?
editor-mention is not a plugin nor extension of immutable. This seems like an ordinary dependency to me: https://github.com/react-component/editor-mention/blob/3a566add7abdeffefa099b6650d0ab1e67f930f3/src/model/mentionStore.js#L2
Related issues:
https://github.com/react-component/editor-mention/issues/26
https://github.com/ant-design/ant-design/issues/10710

Fixes https://github.com/react-component/editor-mention/issues/30


Added TCP and strip indices, and TCP outputs to TPprintout instead of…

@valsdav
Merging local changes with updates for offline DB

I think conflicts are only from adjusting printouts to add TCP info and TCP + strip index. I think we can take the atishelmch:ecal_double_weights_11_3_X file versions for the conflicting files. Do you agree?

Hi Abe, I think on the contrary we have to keep the current version. I see that the conflicts are about Tpmode argument around in the code.

I made a mistake - I forgot to include all of our latest commits into the atishelmch branch, which is why TPmode is missing from the strip and TCP constructor arguments.


Add performance test (and also sort data sets for display)

I see you that are sorting the data. Is that for just ease of reading?

I see you that are sorting the data. Is that for just ease of reading?

When new CSVs are loaded, the additional datasets are thrown in the list in an arbitrary place.  When the list is sorted, then all the OpenTargets data (or custom data from similarly named files) will stay grouped together.


can't create /var/log

Can you please replace
chmod -R 777 web/var
with
chmod -R 777 web/var
chmod -R 777 var

@kaurov Thank you very much for this hint. I've changed the readme file.


doc/lua.section.md: update lua documentation

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

todo mention how to update a single package via luarocks nix (as the script is not good enough to allow that + is hard to run successfully)

I wanted to do more but this will be in future PRs, for now this brings the anchors more in line with the rest of the documentation.


Added fibonacci problem as dynamic programming example

IMPORTANT: Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding.
Description
Please describe what changes you have made. #166
Added fibonacci problem as dynamic programming example. Utilizes both memoization and tabulation forms.
For Example:

Added a file(s) named '...' that implements '...'.

Changed the algorithm for performance/readablity/bugs.

Added documentation to the algorithm

Related Issue
This project only accepts pull requests related to open issues.
If suggesting a new feature or change, please discuss it in an issue first.
If fixing a bug, there should be an issue describing it with steps to reproduce.
Please link to the issue here:
How Has This Been Tested? (Optional)
Please describe in detail how you tested your changes.
You can skip this if you have not added any tests.
Screenshots (Optional)
Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

[ ] Bug fix (change which fixes an issue with the algorithm)

[x] New Algorithm (non-breaking change which adds functionality)

[ ] Documentation

Checklist:
Go over all the following points, and put an x in all the boxes that apply.
If you're unsure about any of these, don't hesitate to ask. We're here to help!

[x] My code follows the code style of this project.

[ ] My change requires a change to the documentation.

[ ] I have updated the documentation accordingly.

[x] I have read the CONTRIBUTING document.

Changed to be Fibonacci -> Java -> Fibonacci.java


Password policy is ignored by SDK

If I create a User Pool in Cognito and set a loose password policy, then when I sign up a user with a simple password such as 123456, I will get an exception about the password not following the set policy.
However when AddCognitoIdentity is added with options which set the policy, the user can be created with a simple password.
Since the Cognito service is the decider of the password policy the SDK must fetch the policy from Cognito and user that rather than having some defaults.

Hi,
Thanks for your feedback.
I think I see two different things at play here:
The #1 one is the client side validation which needs to mimic the user pool min/max password length: https://github.com/aws/aws-aspnet-cognito-identity-provider/blob/master/samples/Samples/Areas/Identity/Pages/Account/Register.cshtml.cs#L50
The #2 one is that we actually retrieve the pool password policy and create a password validator based on it. It is injected in the CognitoUserManager and validates the password against the pool policy when creating new users:
https://github.com/aws/aws-aspnet-cognito-identity-provider/blob/master/src/Amazon.AspNetCore.Identity.Cognito/CognitoPasswordValidator.cs
Would you mind sharing the snippet of code of where you add the IdentityOptions to AddCognitoIdentity(). I may have a gap somewhere that I did not think about.
Thank you for providing me this valuable feedback.
Hamza.


Show image on toastr

Hi, I wanna know if is possible put an img tag on a toastr?

What do you mean on? Can you elaborate more?

Maybe you can change css class in options， with background-image ?


flatten crashes due to breakpoints

Snippets to recreate below.  I ran into this problem with WASP-47, but not with HATS-11 (216414930).
lctpf = KeplerTargetPixelFile.from_archive("206103150", cadence="lc",
                                          quality_bitmask='hardest');
lc_m = lctpf.to_lightcurve(aperture_mask=lctpf.pipeline_mask)

lc = lc_m.remove_nans().remove_outliers()

#Remove long term trends
#lc = lc.flatten(window_length=401)
lc = lc.flatten()

ValueError                                Traceback (most recent call last)
<ipython-input-28-5b942d6160ae> in <module>()
      4 #Remove long term trends
      5 #lc = lc.flatten(window_length=401)
----> 6 lc = lc.flatten()
      7
      8 #ax = lc_m[(lc_m.time>mystart) & (lc_m.time<myend)].plot(label='raw')

~/Documents/Documents/K2/learning_lightkurve/latest_lightkurve/lightkurve/lightkurve/lightcurve.py in flatten(self, window_length, polyorder, return_trend, break_tolerance, **kwargs)
    235             trend_signal[l:h] = signal.savgol_filter(x=lc_clean.flux[l:h],
    236                                                      window_length=window_length,
--> 237                                                      polyorder=polyorder, **kwargs)
    238         trend_signal = np.interp(self.time, lc_clean.time, trend_signal)
    239         flatten_lc = copy.deepcopy(self)

~/anaconda3/lib/python3.6/site-packages/scipy/signal/_savitzky_golay.py in savgol_filter(x, window_length, polyorder, deriv, delta, axis, mode, cval)
    335     if mode == "interp":
    336         if window_length > x.size:
--> 337             raise ValueError("If mode is 'interp', window_length must be less "
    338                              "than or equal to the size of x.")
    339

ValueError: If mode is 'interp', window_length must be less than or equal to the size of x.

%debug

I verified that the bugfix merged in #85 has resolved this problem.  Yay!  Closing the issue...


Added pindex to Siger to provide optional prior next key list index for new rotation logic

Codecov Report

Merging #300 (9efc3ce) into development (ea9de5f) will increase coverage by 0.00%.
The diff coverage is 97.50%.

@@             Coverage Diff              @@
##           development     #300   +/-   ##
============================================
  Coverage        92.63%   92.63%
============================================
  Files              116      116
  Lines            35407    35455   +48
============================================
+ Hits             32799    32844   +45
- Misses            2608     2611    +3

Impacted Files
Coverage Δ

src/keri/app/habbing.py
82.67% <ø> (ø)

src/keri/core/coring.py
88.44% <95.65%> (+0.07%)
:arrow_up:

tests/core/test_coring.py
99.94% <98.61%> (-0.03%)
:arrow_down:

src/keri/core/eventing.py
78.93% <100.00%> (ø)

tests/core/test_eventing.py
99.95% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Bug: migration error Class 'Locale' not found

PHP Version
7.4, 8.0, 8.1
CodeIgniter4 Version
4.2.6
CodeIgniter4 Installation Method
Composer (as dependency to an existing project)
Which operating systems have you tested for this bug?
macOS
Which server did you use?
fpm-fcgi
Database
mysql8
What happened?
When I enter the migration command, I get an error.
Class 'Locale' not found
at SYSTEMPATH/CodeIgniter.php:181
Backtrace:
1    ROOTPATH/spark:83
CodeIgniter\CodeIgniter()->initialize()
Steps to Reproduce
php spark migration status
Expected Output
[Error]
Class 'Locale' not found
at SYSTEMPATH/CodeIgniter.php:181
Backtrace:
1    ROOTPATH/spark:83
CodeIgniter\CodeIgniter()->initialize()
Anything else?
No response

Duplicate of #4775, #3294
See https://codeigniter4.github.io/CodeIgniter4/intro/requirements.html#server-requirements

The module installation is already complete.
Installed to suit the conditions.

@smartyoon How did you get the info?

@kenjis info from php74 -m

@smartyoon No, no. My question is: How did you get the output?

 Thanks!

As you know, at least you have two php commands, php and php74.
And these are not the same.


Website Volume Randomly Changing

I have the volume for YouTube set to 1% but this will change to 21% at random, shattering my ears and crushing my dreams of being an astronaut. Hopefully this can be fixed soon ^^

Also having this issue. I was about to create an issue for it, but then I found this open issue.
The volume control is wildly volatile for me, going from 20% to 6% to 32% to 28%. And all that just in about a 30 second span.


No validation for taken pages

Just checking out this project and noticed that while the sign up page checks if a existing restaurant already exists with that name and will show an error under the field, it does not seem to go any further:
I noticed that if you enter a currently used page name for example "signup" as your restaurant name that no error shows. I didn't want to test this incase it caused harm to the site.
With my very very limited js knowledge I had a read through  the code and could only see validation for database items.
It may be worth adding an extra check as to whether that page already exists

Hey @henry3980,
Firstly, Thank you for your interest in TurboMenu and bringing this to our attention.
We will add the necessary checks in place to ensure protected pages can't be used as restaurant names.
On that note, if you would like to get more involved in the development of TurboMenu.
We would be looking forward to working together.
Cheers

Sadly I'm not yet experienced enough to produce anything in your tech stack that would be useful.
I'm techy but haven't worked on websites yet, hence I could see there was no validation but wouldn't be able to build it myself.
If that ever changes I will get involved as it looks like a good project.


[raymath] Hotfix for Vector2Angle() and Vector2LineAngle()

The previous hotfix changed Vector2LineAngle() which was actually returning the correct results, so I reverted that change and now fixed Vector2Angle()

@Murlocohol I had to review some conflicts, please, could you sync to master and verify the merge was correct?


Background Image does not load on 1.21.4

While the mod works, the background image nor the logo doesn't load for some reason.

i'm having the same problem.


Attempt a windows build

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Thanks for working on @SylvainCorlay. Have also been interested in this myself. How would you propose we handle the libsodium issue?

Also not sure if this helps, but maybe there is something to be gleaned from PR ( https://github.com/conda-forge/zeromq-feedstock/pull/8 ).

libzmq ships a CURVE implementation called tweetnacl, so you should be able to use that in the absence of libsodium on Windows.

Closing, super-seeded by #13 .


Disable clippy's unnested_or_patterns lint

This is something that is not available in Rust 1.37.
Signed-off-by: Uli Schlachter<EMAIL_ADDRESS>
So far, this only makes the nightly CI build fail, but before this reaches stable and suddenly breaks the build, let's just deal with this already.

Apparently this was not necessary and can simply be closed.


slice bounds out of range in text-input.go

Hover doctor
$ hover doctor
hover: Hover version v0.41.5 running on darwin
hover: Sharing flutter version
Flutter 1.19.0-1.0.pre • channel dev • https://github.com/flutter/flutter.git
Framework • revision 456d80b9dd (3 weeks ago) • 2020-05-11 11:45:03 -0400
Engine • revision d96f962ca2
Tools • Dart 2.9.0 (build 2.9.0-7.0.dev 092ed38a87)
hover: Flutter engine commit: https://github.com/flutter/engine/commit/d96f962ca21a104b08836f34814eb6b267937511
hover: ⚠ The go-flutter project tries to stay compatible with the beta channel of Flutter.
hover: ⚠     It's advised to use the beta channel: `flutter channel beta`
hover: Finding out the C compiler version
Apple clang version 11.0.3 (clang-1<IP_ADDRESS>)
Target: x86_64-apple-darwin19.4.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
hover: Sharing the content of go.mod
module telefuel/go

go 1.14

require (
        github.com/3d0c/gmf v0.0.0-20190724130615-f4b5acb7db5c
        github.com/go-flutter-desktop/go-flutter v0.41.0
        github.com/go-flutter-desktop/plugins/image_picker v0.1.5
        github.com/go-flutter-desktop/plugins/path_provider v0.4.0
        github.com/go-flutter-desktop/plugins/url_launcher v0.1.2
        github.com/go-flutter-desktop/plugins/video_player v0.0.3
        github.com/pkg/errors v0.9.1
        github.com/skratchdot/open-golang v0.0.0-20200116055534-eef842397966
)
hover: Sharing the content of hover.yaml
application-name: Telefuel
executable-name: ""
package-name: ""
license: ""
target: lib/main_desktop.dart
branch: ""
cache-path: ""
opengl: ""
engine-version: ""
hover: Sharing the content of go/cmd
go/cmd/main.go  go/cmd/options.go       go/cmd/plugin.go        go/cmd/video_player.go

Error output
The issue seems to be caused here: go-flutter@v0.41.0/text-input.go:223
My app exited with the following after clearing the text in a TextController:
$ hover run
hover: ⚠ The go-flutter project tries to stay compatible with the beta channel of Flutter.
hover: ⚠     It's advised to use the beta channel: `flutter channel beta`
hover: Building flutter bundle
hover: Using engine from cache
hover: Compiling 'go-flutter' and plugins
hover: Successfully compiled
hover: Build finished, starting app...
hover: Running text_input_error in debug mode
go-flutter: WARNING error creating the resource window: VersionUnavailable: NSGL: Failed to create OpenGL context
[ERROR:flutter/shell/platform/embedder/embedder_surface_gl.cc(107)] Could not create a resource context for async texture uploads. Expect degraded performance. Set a valid make_resource_current callback on FlutterOpenGLRendererConfig.
[ERROR:flutter/shell/platform/embedder/embedder_surface_gl.cc(107)] Could not create a resource context for async texture uploads. Expect degraded performance. Set a valid make_resource_current callback on FlutterOpenGLRendererConfig.
flutter: Observatory listening on http://<IP_ADDRESS>:50300/
hover: Connecting hover to 'text_input_error' for hot reload
Waiting for Flutter test device to report its views...               9ms
Lost connection to device.
Syncing files to device Flutter test device...                         ⣟panic: runtime error: slice bounds out of range [:-1]

goroutine 1 [running, locked to thread]:
github.com/go-flutter-desktop/go-flutter.(*textinputPlugin).addText(0x43a8ec0, 0xc000000061)
        /Users/kiasaki/code/go/pkg/mod/github.com/go-flutter-desktop/go-flutter@v0.41.0/text-input.go:223 +0x34e
github.com/go-flutter-desktop/go-flutter.(*textinputPlugin).glfwCharCallback(0x43a8ec0, 0xc000100000, 0x61)
        /Users/kiasaki/code/go/pkg/mod/github.com/go-flutter-desktop/go-flutter@v0.41.0/text-input.go:148 +0x55
github.com/go-gl/glfw/v3.3/glfw.goCharCB(0x6975b90, 0x61)
        /Users/kiasaki/code/go/pkg/mod/github.com/go-gl/glfw/v3.3/glfw@v0.0.0-20200420212212-258d9bec320e/input.go:365 +0x51
github.com/go-gl/glfw/v3.3/glfw._cgoexpwrap_9b801eba25a4_goCharCB(0x6975b90, 0x61)
        _cgo_gotypes.go:2612 +0x33
github.com/go-gl/glfw/v3.3/glfw._Cfunc_glfwWaitEventsTimeout(0x3f9999999999999a)
        _cgo_gotypes.go:2437 +0x41
github.com/go-gl/glfw/v3.3/glfw.WaitEventsTimeout(0x3f9999999999999a)
        /Users/kiasaki/code/go/pkg/mod/github.com/go-gl/glfw/v3.3/glfw@v0.0.0-20200420212212-258d9bec320e/window.go:994 +0x2d
github.com/go-flutter-desktop/go-flutter.(*Application).Run.func12(0x3f9999999999999a)
        /Users/kiasaki/code/go/pkg/mod/github.com/go-flutter-desktop/go-flutter@v0.41.0/application.go:351 +0x2d
github.com/go-flutter-desktop/go-flutter.(*EventLoop).WaitForEvents(0xc0000921e0, 0x422d010)
        /Users/kiasaki/code/go/pkg/mod/github.com/go-flutter-desktop/go-flutter@v0.41.0/event-loop.go:120 +0x61b
github.com/go-flutter-desktop/go-flutter.(*Application).Run(0xc0000fc000, 0x0, 0x0)
        /Users/kiasaki/code/go/pkg/mod/github.com/go-flutter-desktop/go-flutter@v0.41.0/application.go:350 +0x11c7
github.com/go-flutter-desktop/go-flutter.Run(0xc0000ca120, 0x3, 0x4, 0x3, 0xc00005df40)
        /Users/kiasaki/code/go/pkg/mod/github.com/go-flutter-desktop/go-flutter@v0.41.0/application.go:26 +0x4d
main.main()
        /Users/kiasaki/code/repos/tmp/text_input_error/go/cmd/main.go:24 +0x188
hover: App 'text_input_error' exited with error: exit status 2

Reproducing
I was able to reproduce the error running https://gist.github.com/kiasaki/79a296498ff48e8cc2e65e46d337cd4a
Typing a bit and then quickly clicking that reset floating action button

I could write a PR with some kind of bounds checking but I'm not familiar enough with the problem space to know if that should be the fix of some more digging is needed to fix the problem at the source.

Fixed in go-flutter v0.41.1 please hover bumpversion.
Thanks for reporting this issue!

Amazing! Thanks for that :D


updated 8th sept blog for office hours

Signed-off-by: 26tanishabanik<EMAIL_ADDRESS>Fixes #57

Also, @26tanishabanik can we please wrap text while submitting so that reviewing is easier?

@26tanishabanik Gentle reminder

We don't have blogs on our OSS website now. They are moved to the marketing website. This blog describes an outdated event.
So, I'm closing this issue.

This is on an outdated events and we don't have blogs on our OSS website now.


Ukrainian translations were added and improved

I reviewed all the previously existed lines and improved many of them. For the rest I just filled what was missed. Still probably not ideal because it's not alway clear what is the context or where it will be displayed. Like "Edit". If it's an button it should be "Радагувати", if it's a command for action then it should sound like "Редагуй". So, I selected the most common options where it was possible.
⚠ I didn't check if the JSON structure is the latest version or not. Just filled what I had in the main branch at the moment

Hey @vlavrynovych , thank you for these!
There are a few new strings for portal available and also the ones related to search that are new since you submitted these.  Would you have time to add them?
You can bring your branch up to date by following these directions: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

Hi again @cathysarisky, done. Let me know if any other help is needed.

@cathysarisky, sorry for the long response time. It was a night for me. But anyway I left a comments and commited the what I believe will work in these cases.

I also want to reference other two pull requests which can be used as an additional source:

https://github.com/TryGhost/Ghost/pull/20586
https://github.com/TryGhost/Ghost/pull/20443


Possible Feature?

Firstly, thank you very much for creating this software.
I was thinking it might be possible to do greyscale images by taking an image and splitting it into say 4 levels of grey. The 4 seperated images could then be burned in sequence at different power levels corresponding to the greyscales.

Sorry for the late reply. Glad you like it.
I really like your idea about adding different shades this way. So, thanks a lot for coming up with it. Currently I'm busy with extending the reporting of the actual progress (progress bar in other words), but haven't gotten time to complete it the past days.
As I will have to study for exams the next month, I can't like really tell you when I get the chance to imlement it.
But may I ask which OS you are using? If it's not such a time consuming task I may add the feature in a seperate branch so you can check it out and compile it yourself.

I run on Arch Linux. No rush for you to implement this, you are doing it for free after all. It should already be possible to do this manually using a capable image editor and running the software in an iterative fashion.
With all the talk of trojans in the software supplied with the neje I am somewhat suprised you software is not getting more attention.

Soo I gave it a first shot. It is far from complete, but you might be interested in its current state. You can grab it from the "grayscale" branch here.
In the current state, EzGraver does not automatically upload each layer (that's how I've called the different levels of gray in a grayscale image as I think it suits pretty well the goal of this functionality). You can see an overview of the transformation with layer "0". The higher values will display only the parts being part of the selected layer.
Due to the lack of automation, you have (for now) to manually cycle through the different layers. Furthermore, for each layer the upload and start buttons have to be invoked manually (don't forget to adjust the burn time ;-)).
So currently, there's not much of benefit over manually splitting the image. Additionally, the number of layers is currently hard-coded to 8 (changing it is easy as I do the calculations anyway, so only an integration into the UI is necessary).
I'd be glad if you give it a short try and tell me if it is going the direction you've imagined.

As I was a little bit ambitious, I have extended the version in the branch, so now you're able to select the number of layers. :-)
Automatic engraving of all layers requires a little bit more effort. It needs setting the burn time for each layer manually and also keeping track of the current engraving process. But I think the current state is pretty neat.

After finally getting the time to do a few tests I released v2.1.0 which adds your requested feature.
It seems the "color" distribution is not always optimal. If there is any demand, I may improve this weakness.


Investigate why a Data Set produces an error in Mauro

See:

NHSDigital/DataDictionaryPublication#548

Had to manually fix a ModelDataType for a data model. The code set that was referenced in the type did not exist anymore. Manually updated the TEST database to fix.
No code changes required, this can be closed.


TickFormat doesn't update

With the option tickFormat i can change the label of my ticks.
But when i try to update my option object with a new tickFormat, the chart uses the old labels.

Found a workaround.
If you set the data and options for a short time to an empty object, the graph will recalibrate itself.
so here is my code snippet
    var refreshGraph = function () {         var graphData = graphController.getGraph();         console.log(graphData);         $scope.options = {};         $scope.data = {};         $timeout(function () {             $scope.options = graphData.options;             $scope.data = graphData.data;         }, 20);     };
And thanks for the great graph =).


Anything we should add to this repo from the ICBO workshop?

This slide presentation was made for the LinkML workshop at ICBO 2022:
https://docs.google.com/presentation/d/1U1acY1czwWt8KlwrCjY_zE_2eg6sV6BC9D0T5xcs1Zo/edit
Should we link to it from this documentation site? Or incorporate any of the figures into this documentation?

There's also now a video of the LinkML workshop: https://www.youtube.com/watch?v=1ukQ7yXdlWc


Allow other audio players in the app to play nicely together!

Allow other audio players in the app to play nicely together!
The problem is when you start recording, and another video player is ON. It'll crash.

@iMagdy Can I close it if you do not have any counter-opinion on my review? I think it would be nicer to implement a separate method (or port react-native-sound's setCategory()` method in this library) if we want to manipulate the AudioSession in the level of this library.

I also agree with @ohtangza. In addition, AVAudioSessionCategoryPlayAndRecord makes player play sound through earpiece if AVAudioSessionCategoryOptionDefaultToSpeaker option is not given.

I get your point. Thanks @ohtangza @ghsdh3409


Add Catch The Robber Game

It's a game of a robber that gets invisible and always changes its position and you have to find and catch him on the screen.
Its working video,
https://user-images.githubusercontent.com/75881393/117304271-2fcc1580-ae9b-11eb-9b6c-d5c9c3238967.mp4

Please @ridsuteri @991rajat  @urvashi-code1255 review this issue.


Checkpoints & logs for COCO & VOC split 2,3

Hello, I saw that you posted the Google drive link for the VOC split 1 training logs and checkpoints. I wonder if you can provide the links for the other settings especially COCO. Thank you very much!

我没找到作者发的训练日志和checkpoint的谷歌云盘链接，你能发我下吗？谢谢！

我没找到作者发的训练日志和checkpoint的谷歌云盘链接，你能发我下吗？谢谢！

Here you go: GoogleDrive
The author mentioned it in this issue: #5

我没找到作者发的训练日志和checkpoint的谷歌云盘链接，你能发我下吗？谢谢！

Here you go: GoogleDrive The author mentioned it in this issue: #5

感谢！


Often long BouncyCastleFipsProvider lock in getDefaultSecureRandom()

The context is a Java 8 JVM where both the BCFIPS and BCJSSE providers are registered (and SunJSSE is not), not in approved-only mode and FIPS mode respectively, using bc-fips-<IP_ADDRESS>.jar and bctls-fips-<IP_ADDRESS>.jar.
In deployments with a lot of traffic, we see quite some wait time for the registered BouncyCastleFipsProvider's lock.  And a large part of these occur while decrypting TLS packets, in RecordStream.decodeAndVerify() -> TlsAEADCipher.decodeCipherText() -> JceAEADCipherImpl.init().
And the ones that seem most time-consuming, are those that go from JceAEADCipherImpl.init() to BouncyCastleFipsProvider.getDefaultSecureRandom(), for example in the following stack trace:
	at java.lang.Throwable.fillInStackTrace(Native Method)
	at java.lang.Throwable.fillInStackTrace(Throwable.java:784)
	-  locked java.lang.IllegalStateException@67772e0c
	at java.lang.Throwable.<init>(Throwable.java:266)
	at java.lang.Exception.<init>(Exception.java:66)
	at java.lang.RuntimeException.<init>(RuntimeException.java:62)
	at java.lang.IllegalStateException.<init>(IllegalStateException.java:55)
	at org.bouncycastle.crypto.CryptoServicesRegistrar.getSecureRandom(Unknown Source)
	at org.bouncycastle.jcajce.provider.BouncyCastleFipsProvider.getDefaultSecureRandom(Unknown Source)
	at org.bouncycastle.jcajce.provider.BaseCipher.engineInit(Unknown Source)
	at org.bouncycastle.jcajce.provider.BaseCipher.engineInit(Unknown Source)
	at javax.crypto.Cipher.init(Cipher.java:1540)
	at org.bouncycastle.tls.crypto.impl.jcajce.JceAEADCipherImpl.init(JceAEADCipherImpl.java:108)
	at org.bouncycastle.tls.crypto.impl.TlsAEADCipher.decodeCiphertext(TlsAEADCipher.java:299)
	at org.bouncycastle.tls.RecordStream.decodeAndVerify(RecordStream.java:253)
	at org.bouncycastle.tls.RecordStream.readFullRecord(RecordStream.java:204)
	at org.bouncycastle.tls.TlsProtocol.safeReadFullRecord(TlsProtocol.java:922)
	at org.bouncycastle.tls.TlsProtocol.offerInput(TlsProtocol.java:1364)
	at org.bouncycastle.jsse.provider.ProvSSLEngine.unwrap(ProvSSLEngine.java:481)
	-  locked org.bouncycastle.jsse.provider.ProvSSLEngine_8@52d8950d
	at javax.net.ssl.SSLEngine.unwrap(SSLEngine.java:626)
[...snipped some of our own code...]
	at java.lang.Thread.run(Thread.java:750)

So from the bctls-fips-<IP_ADDRESS>.jar and bc-fips-<IP_ADDRESS>.jar source code, what seems to happen, is that for every decrypted packet Cipher.init() is called; that always calls BouncyCastleFipsProvider.getDefaultSecureRandom(); that always calls CryptoServicesRegistrar.getSecureRandom(); that by default always throws an IllegalStateException; and inside catch (IllegalStateException e) the caller BouncyCastleFipsProvider.getDefaultSecureRandom() then always creates its own SecureRandom, keeping the lock all the time:
        try
        {
            defRandom = CryptoServicesRegistrar.getSecureRandom();
        }
        catch (IllegalStateException e)
        {
            // See SP 800-90A R1 8.6.7 for setting of Nonce - at least 1/2 security strength bits
            synchronized (this)
            {
                if (providerDefaultRandom == null)
                {
                    SecureRandom sourceOfEntropy = getDefaultEntropySource();

                    // we set providerDefault here as we end up recursing due to personalization string
                    providerDefaultRandom = providerDefaultRandomBuilder
                        .fromEntropySource(sourceOfEntropy, true)
                        .setPersonalizationString(generatePersonalizationString())
                        .build(sourceOfEntropy.generateSeed((providerDefaultSecurityStrength / (2 * 8)) + 1), true, Strings.toByteArray("Bouncy Castle FIPS Provider"));
                }

                defRandom = providerDefaultRandom;
            }
        }

Is this expected behavior?  Or are we expected to call CryptoServicesRegistrar.setSecureRandom() to avoid all this exception-throwing and SecureRandom-creating?
We could find no documentation about that last method.

Note that we tried to set a default SecureRandom in CryptoServicesRegistrar, namely SecureRandom.getInstance("DEFAULT", "BCFIPS"), and that reduced the lock time by a lot, but then things started to fail in BCFIPS approved-only mode threads, with FipsUnapprovedOperationError: FIPS SecureRandom security strength not as high as required for operation: RSA.

Something does not sound right... the setting of providerDefaultRandom should only occur once for a provider so the behavior described makes it sound like multiple providers are being created.
How is the BCJSSE configured?
I'm not entirely sure what's going on with the use of setSecureRandom either, but I thought I should cross the BCJSSE off the list first.

"How is the BCJSSE configured?" Could you clarify?
We do set a few properties for BCJSSE and BCFIPS (will comment with details tomorrow) but nothing around SecureRandom.  (And we tell the JDK via java.security to use urandom and ...NonBlocking..., to prevent entropy issues on our Linux VMs.)

For FIPS you would usually configure it as fips:BCFIPS in java.security - in this case it would be in FIPS mode and using the BCFIPS provider. See section 2.1.1 of https://downloads.bouncycastle.org/fips-java/BC-FJA-(D)TLSUserGuide-1.0.15.pdf (this would apply to 14.1 as well).
One thing urandom and NonBlocking is not FIPS compliant, there's no point in using FIPS mode if you're using these - the application is not FIPS compliant the moment it boots up. It's possible to configure a DRBG chain in the FIPS provider as described with the HYBRID mode in section 2.3 https://downloads.bouncycastle.org/fips-java/BC-FJA-UserGuide-1.0.2.pdf
I'd also recommend looking at rng-tools or haveged to assist with this as well (HYBRID's fine once you're up and running, but a lack of entropy can cause a pause at boot time as well).

No randomness is needed for this operation, so it's at least an issue that the provider thinks it should initialize one at all. Presumably the one-time creation of providerDefaultRandom is not a main contributor, although it would preferably use the static singleton pattern instead of synchronization if possible. Finally the exception-as-return-value should be replaced with something like a tryGetSecureRandom.
However all those things require FIPS provider updates which is a slow turnaround.
https://github.com/bcgit/bc-java/commit/88101267d74d7b63cd92ffdab86c2fbba81792f6 started passing null as the random (instead of a JCE default - and therefore non-FIPS - SecureRandom). That would explain why this has only recently surfaced.
Since BCJSSE has a SecureRandom already available anyway I have changed the code to pass that instead of null. This should at least work around the issue until we get a chance to update the provider.
Just a note in case the original report is misdiagnosed in some way, there was a nearby performance issue addressed by https://github.com/bcgit/bc-java/commit/b25b441db071fd618a351446a4b9d6570dc05906 - that fix would not be present in <IP_ADDRESS> .

Something does not sound right... the setting of providerDefaultRandom should only occur once for a provider so the behavior described makes it sound like multiple providers are being created.

We are pretty sure we are creating only one BouncyCastleFipsProvider instance.
Also, I see no evidence (in the bc-fips-<IP_ADDRESS>.jar and bctls-fips-<IP_ADDRESS>.jar source code) that org.bouncycastle.crypto.CryptoServicesRegistrar.defaultSecureRandom is ever updated, because I see no calls to CryptoServicesRegistrar.setSecureRandom().  So (as long as we don't do anything explicit), CryptoServicesRegistrar.getSecureRandom() will always return null?
In other words, I see no evidence for your "should only occur once"?

How is the BCJSSE configured?
I'm not entirely sure what's going on with the use of setSecureRandom either, but I thought I should cross the BCJSSE off the list first.

For FIPS you would usually configure it as fips:BCFIPS in java.security - in this case it would be in FIPS mode and using the BCFIPS provider. See section 2.1.1 of https://downloads.bouncycastle.org/fips-java/BC-FJA-(D)TLSUserGuide-1.0.15.pdf (this would apply to 14.1 as well). Note: this isn't quite the same as having the module in FIPS mode - it just restricts the JSSE to what is acceptable in SP 800-52.

We have the same code base running BCJSSE from bctls-fips.jar in both in FIPS mode (so 'SP 800-52 mode' as you say, so with fips:BCFIPS, which we're aware is different from running as a FIPS validated module), and elsewhere in its default non-FIPS mode.  This reported issue we encountered in non-FIPS mode (and I don't think we tested it in non-FIPS mode).
Except for that, we run BCJSSE with only

Security property ssl.KeyManagerFactory.algorithm=PKIX
System property org.bouncycastle.jsse.client.assumeOriginalHostName=true

The original comment said you were seeing "that always calls CryptoServicesRegistrar.getSecureRandom(); that by default always throws an IllegalStateException; and inside catch (IllegalStateException e) the caller BouncyCastleFipsProvider.getDefaultSecureRandom() then always creates its own SecureRandom, keeping the lock all the time:"
I gather I wasn't clear about what I said. The providerDefaultRandom variable is a local field in the provider class. Ordinarily you'd expect this to be set once unless multiple threads were making multiple copies of the provider's non-volatile memory at the same time and consistently creating new SecureRandoms, I'm not saying this is impossible, but I can't say we've seen it before - the setting of the variable is being done under synchronized so by rights should actually be done on the "master copy" of the object. The biggest penalty you should be paying is the exception, again if your application results in a lot of calls to getDefaultSecureRandom() - the exception would show up a lot in thread dumps, similar to what is provided in your example but which is not code within the synchronized block as the exception is still being constructed and is not yet caught.
Since you don't have to worry about FIPS compliance, it might be worth trying <IP_ADDRESS> which avoids the exception throwing, and see how your experience is with that. The only caveat I would add on that is that if you have access to the support program you should use the version available through that, although for these purposes the non-cert version on the BC website is probably close enough to the submitted version.

Ah, OK, thanks!  I should have seen that BouncyCastleFipsProvider.providerDefaultRandom is only initialized once, so indeed my statement "inside catch (IllegalStateException e) the caller BouncyCastleFipsProvider.getDefaultSecureRandom() then always creates its own SecureRandom"` was incorrect: That SecureRandom is created only once.
Thanks for letting us know bc-fips-<IP_ADDRESS>.jar avoids / will avoid the IllegalStateException throwing.
So the biggest issue with the current code might be that exception throwing.
Or it may be that no if (providerDefaultRandom == null) check is done before entering synchronized (this)?  It seems that doing if-synchronized-if would avoid a lot of locks here, even though they would be short-lived.
Or whatever solution you think best, of course, like @peterdettman wrote, "it would preferably use the static singleton pattern instead of synchronization if possible."
And @peterdettman thanks for letting us know that a new version of BCJSSE will avoid the call to org.bouncycastle.jcajce.provider.BouncyCastleFipsProvider.getDefaultSecureRandom() altogether:

Since BCJSSE has a SecureRandom already available anyway, so I have changed the code to pass that instead of null. This should at least work around the issue until we get a chance to update the provider.

Either of those fixes should solve this issue for us.

@marnix bctls-fips-1.0.17.jar was just published to the bc-fips-java git repo. It contains the SecureRandom workaround amongst other fixes and features.

Appears completed.


{Feature_Request}  Rating system using HTML CSS

I want to add a rating system
Describe alternatives you've considered

Demo Video/Screenshot (Mandatory )

Contributing under JWOC

can you please explain me more about this??
Like where you want to insert it?

sir basically i want to add an option at the top like given in the following page

sir basically i want to add an option at the top like given in the following page

Is that will be responsive or static

i will try to make it responsive

@daksh1210jain I have assigned you . You have 2-3 days to submit your PR

Daksh jain is my name sir

ok
On Fri, 19 Jan 2024 at 17:59, daksh1210jain @.***>
wrote:

Daksh jain is my name sir
—
Reply to this email directly, view it on GitHub
https://github.com/apu52/Travel_Website/issues/48#issuecomment-1900330836,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3HCIAASHX363W7OINPGX23YPJRMHAVCNFSM6AAAAABB3MVEFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBQGMZTAOBTGY
.
You are receiving this because you modified the open/close state.Message
ID: @.***>


Azure Eventhubs source Kamelet: Add optional eventPosition parameter

Since this is managed as a map, it is probably better to find a different way.


hide sidebar on small screens

especially because in portrait mode, the sidebar toggle button is hidden by the attribution...

(hopefully) fixed with f74f3cec3a309b18194e1a0bccd4344f2fa09f69


Extract external libraries

This PR addresses the fact that there are a few classes tucked away inside ConfigManager.h.
It moves BaseParameter, and it's associated classes, into their own header file. As well as moving the debugging definitions into its own file.
We also introduce a few unit tests to help drive some of the changes.
At present these tests require a ESP8266 and ESP32 board to run the tests against. This is due to the requirement of the Arduino library which ArduinoJson relies upon.
This could be changed to running the tests natively, once ArduinoJson is replaced with a JSON library that is not reliant on Arduino.h header file, allowing us to integrate unit testing into our TravisCI build.
We could still use the current setup, so that we can test ConfigManager against real boards, so this seems like a sane step to make to get the library under test.

@nrwiersma and @cgmckeever
I found that there is an inconsistency between clearing data for Strings and other data types. I've added a test for each, so we can see the difference.
Although I'll leave it with you guys to determine which one is actually correct :)
I think it'd be nice to be able to have some of the core functionality under test, which would help spot small details like this.
One thing that make this a bit interesting is that we have to compile our tests against a development board, as we require ArduinoJson . Which in turn requires the Arduino libraries. We could use a native JSON library to get around this, which would mean our parameter classes could be tested in isolation.
We could then use the current unit test setup to run tests specifically for ConfigManager allowing us to make sure that the core ConfigManager functionality works as expected, per board. Whilst being able to test its dependancies quickly, and separately.
What do you guys think?

Hi,
Thanks for the PR. I am not keen on splitting out separate header files. I dont see it bringing anything to the party.
The tests however are very interesting. I think they will make an great start to a full test suite. I would also like to explore the possibility of switching the json lib.
Would you be open to removing the ConfigManager changes, and make this PR about the test suite?

Heya, soz, I'm just getting back into things.
Sure, I could revert the header extraction, although I do think there's utility in splitting up the files as it makes it easier to test them individually. As well as it's easier to work on the main piece of the library.
As it's pretty standard to have headers in their individual files, so I adopted it here also. To be fair, if I didn't split the definitions out, I'm not sure that little bug would have jumped out at me 😆
I also think that our test files will start getting a little crazy if we have just one file for all class definitions, stepping away more from the standardised way of writing tests, 1 test file per class, and coming up with a alternative to get around our want to keep all definitions and implementation in one file 🤔 🤷♂
I think it's appropriate to start to move the definitions for a number of reasons.

C++ Standardisation
Easier to write tests, as you only need to think about the class at hand
It extracts classes that aren't directly needed by users out of the user space.
Our tests are cleaner as they only focus and require the class definition we're testing.
Class definitions are easier to find and read, as we don't have to skim through ConfigManager.h
Can tests each lib without necessarily needed to rely on the Arduino ecosystem (meaning faster tests)

This will be more relevant once we replace ArduinoJson with a native C++ alternative.

I'll let you have a mull over it, I'll be away for a few more days but I should be around again, after the 16th.

All fair points.
My problem starts when you start shifting things that should be in src into lib which i would argue is technically wrong. I am also not sure that DebugPrint folder is really necessary. Past that, you have made some good points.

@nrwiersma valid point, and apologies for being slow on this. Hopefully I'll make some changes in the coming days :)

@baphled so ..  forgetting about this PR, I started to go down some similar paths with the files .. and then did unroll them as it seemed to over complicate it a bunch. I wish I was able to remember this PR when I started :) .. still working through this?

@nrwiersma ah, that’s no problem. I was planning on finishing this off then got hit by a load of dates to platformio.
I’m curious as to what these complications looked like, but I’m cool for you to drop this if you think it’s not going to improve the Lib :)
Sent from my iPhone

On 2 Aug 2020, at 22:38, cgmckeever<EMAIL_ADDRESS>wrote:

@baphled so .. forgetting about this PR, I started to go down some similar paths with the files .. and then did unroll them as it seemed to over complicate it a bunch. I wish I was able to remember this PR when I started :) .. still working through this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

@baphled I think some of this discussion has made its way over to here

@cgmcrkeeper awesome, much appreciated.
That’s another thing I’ve wanted to address 😁
Sent from my iPhone

On 6 Aug 2020, at 16:52, cgmckeever<EMAIL_ADDRESS>wrote:

@baphled I think some of this discussion has made its way over to here
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.


Remove version: Jackett.Jackett version 0.21.733

404 - release deleted
Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/Jackett/Jackett/releases/download/v0.21.733/Jackett.Installer.Windows.exe
Response Error: The remote server returned an error: (404) Not Found.
(Automated message - build 918)


FR: Deprecated builders, setters, getters, etc should be removed for GA

The GA release should remove @deprecated methods & classes.
For datastore, logging, storage.  (all of them)
For PubSub, the old deprecated things should be removed.

This is a duplicate of https://github.com/GoogleCloudPlatform/google-cloud-java/issues/1569


Return to old development branch

Return to old development branch

🟢 STATUS: APPROVED 🟢
Hello 👋,
Your project is complete! You followed all the requirements, feel free to merge it! 😄
Congratulations! 🎉

Highlights
✔
✔
✔
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Popup view should be lazy loaded

Here is an example
The current implemention is even showSystemAlertNotification = false, popup body is still executed. This could bring some problems in reality:
data struct is set a valid value only if showSystemAlertNotification= true. Since it's not lazy-loaded, a crash happens since self.systemAlertNotification = nil
.popup(isPresented: $showSystemAlertNotification, type: .floater(), position: .top, animation: Animation.spring()) {
                SystemAlert(alert: self.data!)
            }

Hello @golangnext , that's a really good suggestion. However, we are using viewModifier, and the standard lazy view approach doesn't seem to be working here. We are still searching for a solution, but if you have any ideas, fill free to create a pull request.

lazy view is a potential solution?
struct LazyView<Content: View>: View {
    let build: () -> Content
    init(_ build: @autoclosure @escaping () -> Content) {
        self.build = build
    }

    var body: Content {
        build()
    }
}

Yes, that's what I wrote: "we are using viewModifier, and the standard lazy view approach doesn't seem to be working here" :)

I'm thinking maybe we can use a conditional modifier for that, like
extension View {
    typealias ContentTransform<Content: View> = (Self) -> Content
    @ViewBuilder func conditionalModifier<TrueContent: View, FalseContent: View>(
        _ condition: Bool,
        ifTrue: ContentTransform<TrueContent>,
        ifFalse: ContentTransform<FalseContent>
    ) -> some View {
        if condition {
            ifTrue(self)
        } else {
            ifFalse(self)
        }
    }
}

In the last WWDC video about lazy HStack and VStack, Apple specifically notes that you should avoid using lazy unless absolutely necessary. So I think we are not going to make it lazy by default for now.  Have a great day!


Broadcasting for scipy.linalg.solve

New to this, so please excuse me if I do something wrong.
It would be nice if scipy.linalg.solve accepted N>2 dimensional arrays in the same way as numpy.linalg.solve does. http://docs.scipy.org/doc/numpy/reference/generated/numpy.linalg.solve.html

I would like to take this up.

Great! Do you need any more information from me?

what scipy.linalg.solve takes is a Square matrix and it can be of any dimension (N>2 is also acceptable) and it has the same functionality as numpy.linalg.solve.
the equation a x = b is the one in picture ,
where 'a' is always supposed to be a square matrix irrespective of its dimensions and matrix 'b' .
if anything else is to be done please elaborate, it will be kind of you. :)

@ev-br @ilayn users have asked for ND stacks of covariance matrices in scipy.stats. I wrote a wrapper to loop over over the matrices in Python, but it would be better to do this the "right" way - whatever that is. Would you be able to help me implement this for solve_triangular? That would make it easier for someone to follow the pattern for the other linalg functions.

Not sure what the right way is, can probably move the loop to cython + call a relevant lapack function via cython_lapack. If that's what you're after, is easiest to do from a python prototype.

Would you be able to help me implement this for solve_triangular?

The idea was to finish the cursed #12824 and add nD support to all linalg, but, for some reason I don't remember I started from expm (merged) then moved to sqrtm (still local) and then I got hit by a perfect line-up of bugs and compilation issues for about 5 months spanning Cython, pythran, Python, mingw and the meson stuff. Then I got exhausted and stopped all activity (my new job didn't help either).
I think I am close to be able to rebuild SciPy again and sqrtm is practically finished waiting for the tests. It has nD support and also has a few x speed ups. After that, I had eig and svd family lined up in my todo list and then solve family.
If we actually do solve properly, then you won't be needing solve_triangular since you can choose assume_a=tri and be done with it.

Thanks @ev-br @ilayn.
Ugh build issues, especially, are so frustrating. I've been very fortunate that your Windows build instructions have continued to work for me @ilayn - and fingers crossed they continue until Meson supports in-place builds. Thanks again for your updates to those.
If you were to move the solve family` up on the list, the new functionality would certainly be used! Good luck getting the build working again.

I took a look at how expm was done, and it looks like it's doing the looping in Python, so there's not too much performance improvement vs a decorator approach (which also "vectorizes" the function, but does so from the outside).
import numpy as np
from scipy import linalg

@_apply_over_matrices
def my_expm(A):
    assert A.ndim == 2
    return linalg.expm(A)

res = my_expm(A)
ref = linalg.expm(A)
np.testing.assert_allclose(res, ref)

# %timeit my_expm(A) - 954 ms ± 2.85 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)
# %timeit linalg.expm(A) - 809 ms ± 13.8 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

When there are fewer, larger matrices, the difference between the two approaches is smaller.
Would you be interested in reviewing a PR that uses this approach? It can always be improved in the future, but it would be useful as an easy way to get the feature in.

Here is a draft of such a wrapper. It needs to be tweaked for functions like `solve`, which needs to consider `A` and `b`, but this shows the idea.
def _apply_over_matrices(f):
    def _f_wrapper(x, *args, **kwargs):
        x = np.asarray(x)
        if x.ndim <= 2:
            return f(x, *args, **kwargs)

        # The strategy is to ravel the last two dimensions so we can
        # use `np.apply_along_axis` to call the function on each slice.
        # We need to remember the original shape so that we can "unravel"
        # the last two dimensions before calling `f`.
        old_shape = list(x.shape)
        m, n = old_shape[-2:]
        new_shape = old_shape[:-2] + [m*n]

        def _f_on_raveled(x):
            return f(x.reshape((m, n)), *args, **kwargs)

        return np.apply_along_axis(_f_on_raveled, axis=-1,
                                   arr=x.reshape(new_shape))
    return _f_wrapper

Note that bigger gains are possible if we loop in compiled code.
@_apply_over_matrices
def my_inv(A):
    # assert A.ndim == 2
    return np.linalg.inv(A)

res = my_inv(A)
ref = np.linalg.inv(A)
np.testing.assert_allclose(res, ref)

# %timeit np.linalg.inv(A) - 20.4 ms ± 28.7 µs per loop (mean ± std. dev. of 7 runs, 10 loops each)
# %timeit my_inv(A) - 115 ms ± 1.17 ms per loop (mean ± std. dev. of 7 runs, 10 loops each)

Oops, I didn't show the array size before... that's sort of important : ) Added it.

The point of expm overhaul was to gain speed from the internal algorithm and nD array capability was a bonus. The main issue with low-level looping is the C-contigousness that kills all performance if we need to do a copy in case some weird format or non-contiguous input comes. Other than that, as you see, there is not much done in terms of loops. And in fact you can't do much anyways since it is not IO bounded but CPU bounded. Anything that I am hoping in the short term is Cython 3 comes out officially.  Or we go all the way down to C level that goes beyond my skills and to be honest, I am not willing to touch C or Fortran anymore under any circumstances.

This is now resolved.

@ilayn is it? This is about batch matrix input to linalg.solve. it's tracked in general in gh-21466 (so we don't really need this issue anymore), but it doesn't look like solve accepts N-D arrays yet, right?

Didn't we handle nd arrays in that issue? Maybe I misremember it but otherwise i can handle it in a bit?

In the ones that added backslash-like behavior? No - maybe your original PR did, but we removed that when we went pure-Python.

Ah OK my bad then let me open this one again and handle it


A beautiful scroll bar of same color palette

Is your feature request related to a problem? Please describe.
It looks very good to me if a website has a scroll bar of color similar to the website color palette
Describe the solution you'd like
I will add a custom scroll bar of the #2E8555 color, similar to the color of highlighted words.
Describe alternatives you've considered
No response
Additional context
No response

How it will look like:

How it will look like, on hover:

Awesome issue!! Do you want to work on this @Agrim-Sharma174?

Yes, I want to do this!
Just raising the PR.


A hyper without tokio-proto

It would be nice to have hyper working without internally using tokio-proto. It should be possible to do this in a backwards-compatible way at first, such that the server still provides a ServerProto implementation that makes use of the internal stuff, and that can be deprecated in the future.
Motivation

The tokio-proto crate is being de-emphasized.
We can do some things better, specifically for HTTP

We can better detect if a body has a length if we control the Stream
We improve handling of Expect: 100-continue (#838)
We can probably improve performance a little

Errors that are encountered reading, parsing, and writing are kind of just lost.

They are given back to tokio-proto, but it's pretty tricky for a user to get those errors.

It doesn't allow hyper to currently spawn a server that can handle both HTTP/1 and HTTP/2

API
Http::bind_connection(socket, service) -> Connection
Compared to the current bind_connection:

The socket is T: AsyncRead + AsyncWrite.
The service is currently a S: Service.
The addr is not needed anymore. Anyone wanting to know the address can store it on their Service.
The handle is not provided, since it's only purpose was to spawn a task on it. With the desire to separate tokio from being a task executor, we can plan ahead.

The returned type is a Connection<T, S>, which implements Future. Instead of taking a Handle, a user can instead receive this future and spawn it on any executor they desire.
Of course, since bind_connection already exist, this would need a new name. It could be bind_connection2, with the previous deprecated, with the intent to finish the replacement in 0.12.
Or maybe bind_connection itself isn't the best of names. The action of this method is to apply the Http protocol to a connection, aided by the Service to respond to requests.
Connection
This is returned by Http::bind_connection, and implements Future.

Item = ()
Error = hyper::Error

If there are never any errors when processing the connection, the future yields Ok(Async::Ready) when Http says it should close.
If there are errors encountered that would require tearing down the connection, the future returns the Err. Importantly, this allows users to very easily know if there was an error reading or writing the HTTP protocol.
Some unresolved questions:

This could perhaps have the Item be the socket (T) instead, in case there is desire to be able to do something with the socket after HTTP is "done" (perhaps due to a protocol upgrade).
When HTTP/2 is introduced, it is possible to have stream errors which aren't fatal to the connection, but do abort a stream. It wouldn't be feasible to make those stream errors be returned from the Connection future, as it should keep working.

Perhaps Connection shouldn't be a Future directly, but more like a Stream... of Errs...
The Connection could alternatively grow a on_stream_error<F>(callback: F) where F: Fn(hyper::Error) or something...

Server
The current Server type is supposed to be an "easy mode" for starting up a TCP listener and accepting plain text HTTP requests. There is a related proposal (#1322) to make Server accept any kind of listener, and be a Future so users can execute it with their own executor.
Perhaps that proposal should be updated to support this new Connection future:

impl Stream for Server instead of Future.

The Server could be a Stream of already bound Connections.
This would allow someone to use the Server to automatically call Http::bind_connection with a service, and manage graceful shutdown, while still being able to watch for errors that happen in that connection.

We could add some convenience methods to Server, like run_ignore_errors() -> impl Future, so a user could easily just "run" the server without worrying about it being a Stream of Connections.
Usage
Bare bones bind_connection
let http = Http::new();

// we've received a socket and made a service somewhere else
let conn = http.bind_connection(socket, service);
// whatever your executor is
executor.spawn(conn.map_err(move |err| {
    println!("connection [{}] error: {}", addr, err);
}));

Fuller example with a tokio Core and hyper Server
let mut core = Core::new()?;
let handle = core.handle();

let tcp = TcpListener::bind(addr, &handle).map(|listener| {
  listener.incoming()
});
let tls = tcp.and_then(|tcp_streams| {
    tcp_streams.and_then(|(socket, _addr)| {
        TlsAcceptorThing::handshake(socket)
    })
});

let server = tls.map(|tls_streams| {
    let http = Http::new();
    http.serve(tls_streams, || Ok(Echo))
});

let connections = server.and_then(move |srv| {
    // srv is `Server`, so it is a `Stream<Item=Connection>`
    srv.for_each(move |conn| {
        // each connection should be its own task, so spawn it on the executor
        handle.spawn(conn.map_err(|err| {
            println!("http error: {}", err);
        }));
        Ok(())
    })
});

core.run(connections)?;

Meta unresolved questions

Perhaps the naming of types could be improved as well? (Of course, only finish renaming in 0.12)

Currently:

Http is more like a ServerBuilder or ConnectionBuilder...
If the Http were named a builder, Http could replace Connection? Such that Server is a Stream<Item=Http>?

Many people are used to reaching for a Server type, but hyper currently asks you to grab the Http to configure a Server.

(aside)

The tokio-proto crate is being de-emphasized.
@seanmonstar is there any discussion to read on this?

@kamalmarhubi https://github.com/tokio-rs/tokio-rfcs/pull/3 has some background.

(TIL https://github.com/tokio-rs/tokio-rfcs)

cc @alexcrichton @withoutboats
Glad to see things heading this way -- please let me know if we can be of any help.

@aturon I'd certainly welcome any thoughts around the API. Pulling out some questions:

Does it seem bonkers to have a Stream<Item=impl Future>? That is what is suggested by having impl Stream for Server { type Item = Connection }, and impl Future for Connection...

Do the names make sense? Should the names be shuffled some, considering there would (eventually) no longer be a type exposed as a "protocol" (ServerProto)? Perhaps that makes Http more meaningful as a Builder type.

With Connection returning fatal connection errors, it's still possible for stream-specific errors to occur on a Connection that otherwise don't tear down the connection. Thoughts on Connection growing a on_h2_stream_error callback option?
The point here is that one could return a Response, and then part way through flushing it, the client resets the stream (perhaps a cancel notice, perhaps something worse without being a connection error), it would be nice to know if that response were successfully written or not.

I'd like to help work on this, but I would feel like I have a better sense of how everything should fit together once some of our work on h2 and other surrounding libs start to stabilize.
That said, it is good to start writing this down.

#1362 is available, which starts to address this. Specifically, it adds a configuration option to disable the tokio-proto usage in the server and client. It is not enabled by default, until some more testing shows that at least it has fewer bugs than the tokio-proto dispatch does.
Once determined it should be the default, the no_proto methods will be deprecated, along with the ServerProto pieces that are exposed, and we'll try to move towards the naming discussed in here.
The work in #1362 already has some benefits:

Seems to have fixed some bugs around keep-alive.
Can have a small performance gain.
Better errors are returned on both the client and server.


[Mobile] The hero animation is not centred

On mobile, the hero animation is not centered

https://github.com/user-attachments/assets/a7a41ac3-0c49-41d9-ae8c-5a23180a74bf


Add git LSF support

Preview is available here:http://developers-pr157.previews.kube001.services.stellar-ops.com

Preview is available here:http://developers-pr157.previews.kube001.services.stellar-ops.com

Doesn't seem to work with PR previews and current files are not that big to use LFS


Please release 1.1.9

There've been a bunch of changes since 1.1.8 on npm registry; please update

+1

Any news on 1.1.9 release?
Current master contains a bunch of pretty good patches, would be very nice to see them on npm.

After a few more PRs settle we can release 1.2


New CNC I/O Module - Dynamixel Servos

This allows you to control Dynamixel servos. Dynamixel servos are on a bus, so you can connect a lot of them. I put two connectors, because you might have servos on either side of the controller. If your controller VMot is in the Dynamixel power range, you can use that. There is also an external connection to supply that voltage.
Here is a video of a delta running these servos and Grbl_ESP32
I also added a single RC Servo connector, because I had an extra I/O pin.
I'll probably wait to order this until I can join it with another order to save on shipping.

Here is the module.

It can pull servo power from VMot or use an external voltage (the switch).
It has (2) Dynamixel Servo connectors. The servos are on a bus, so you really only need one, but this helps if servos are on either side of the controller.
One normal RC Servo connector.

Still testing right now.

Hi,
Can we use ESP32 GRBL to drive DELTA with this kind of smart servo?
which parameter ?
any machine def example?

There is a partially working example that will be complete within a week or two.  Please be patient.
Here it is running an older version of Grbl_ESP32.
https://www.youtube.com/watch?v=wPDP6ckP0sQ
I cannot provide any free support for using the delta. It is not part of the core Grbl_ESP32 project.

Will wait for this example, thanks


Added python solution for list-comprehensions and updated readme

Issue Number: https://github.com/Riddhi9570/HackerrankPracticeProblems/issues/48
This submission will close the issue #48
Submissions Checklist:

[x] Have you followed the guidelines in CONTRIBUTING.md?
[x] Have you checked there aren't other open Pull Requests for the same hackerrank problem?

[x] Is your file name exactly same as the problem name of hackerrank, followed by the proper extension?
[x] Have you ensured that you have put the files in appropriate folders? (Folders are made according to the subdomain of hackerrank practice problems).

Hacktoberfest Contributor:

[x] Are you a hacktoberfest contributor?

Hackerrank Problem Link: https://www.hackerrank.com/challenges/list-comprehensions/problem?isFullScreen=true

Submitted Hackerrank Solution Link:  https://www.hackerrank.com/challenges/list-comprehensions/submissions/code/293552564

Any other changes you made or something you would like to mention?
Updated Readme File to show the new file and deleted dummy.py

@Pargat-Dhanjal Please mention the issue this PR is related to.

@Riddhi9570 Updated the issue number


Difference between CancellationToken.None and CancellationTokenHelpers.None?

Is there any difference between the two?

No.


any plans for supporting pred_contribs?

Currently XGBoost Python API support pred_contribs in Booster.predict. This option is useful for debugging some certain prediction cases because we can get contributions of each feature and find some explanation for the prediction result.
The API Doc http://xgboost.readthedocs.io/en/latest/python/python_api.html#xgboost.Booster.predict
Related commit https://github.com/dmlc/xgboost/commit/6bd1869026eb66a542ccd8573f1e4b098a8cf7c6
Inspired by http://blog.datadive.net/interpreting-random-forests/
I'm wondering is there any plans for support this feature in this project? Thanks sincerely！

I have a functioning contribution that I'm just about ready to push. I just need some help upgrading gradle as I have to run the contribution by the open-source overlords at my employer.

@bryan-woods Sorry for the late reply and thank you so much for the contribution! I'm not an expert about gradle, but I'm happy to give you as much help as I can. Let me know if you need my help.

@cocorosiekz I too am sorry for the late reply. I just turned my attention back to this topic. Here is the ticket I created: https://github.com/komiya-atsushi/xgboost-predictor-java/issues/30


Fix Accordion on iOS 9

Adaptation of the accordion of the V2 on the V3 to fix the bug when opening the accordion (as I did on v2 https://github.com/framework7io/framework7/pull/2277).
Thank you.

I removed it intentionally as .nextFrame now must do the thing. If it is still the issue for iOS 9 only then we should target it for iOS 9 only, as requesting .clientLeft requires extra resources

Ok, I found the solution. I just tested and it works well on iOS9 and above.

Fixed by #2731


Fix load subtask not being registered leading to false progress values.

Fixes #90076
I'm clearly not 100% sure about my solution but it works. See https://github.com/godotengine/godot/issues/90076#issuecomment-2029203547 and the previous comment for a bit more depth on why this is working

Hey, I just tested this, and as far as I can tell, it solves all the issues from https://github.com/godotengine/godot/issues/90076 while maintaining the improvements from https://github.com/godotengine/godot/pull/87711 in elegant fashion.
For added context, here are a few outputs from my testing:
Case 1:
core\io\resource_loader.cpp:251 - p_path: res://Bistro_v5_2/BistroExterior.fbx
core\io\resource_loader.cpp:252 - p_original_path:
core\io\resource_loader.cpp:253 - original_path: res://Bistro_v5_2/BistroExterior.fbx
core\io\resource_loader.cpp:254 - parent_task_path: res://scene.tscn
core\io\resource_loader.cpp:259 - INSERTED

In the regression, an empty String been inserted in the sub_tasks HashSet. Here, original_path is set to the correct value and the sub task's progress is tracked properly.
Case 2:
core\io\resource_loader.cpp:251 - p_path: res://.godot/imported/BistroExterior.fbx-2cc48855b7169211933e362848048fa2.scn
core\io\resource_loader.cpp:252 - p_original_path: res://Bistro_v5_2/BistroExterior.fbx
core\io\resource_loader.cpp:253 - original_path: res://Bistro_v5_2/BistroExterior.fbx
core\io\resource_loader.cpp:254 - parent_task_path: res://Bistro_v5_2/BistroExterior.fbx
core\io\resource_loader.cpp:262 - NOT INSERTED

This is the scenario https://github.com/godotengine/godot/pull/87711 was meant to fix in the first place. We correctly choose p_original_path over p_path, but inserting it in sub_tasks would result in a stack overflow crash later on due to it sharing its local path with its parent task path. This new PR correctly checks for this and skips it as needed.
Case 3 would be similar to Case 2, but with original_path != parent_task_path. I can't test it now, but this is supposedly what happens in the exported build and it looks to me like that should go through with no issues as well.
Thank you for your contribution and great work!!

Thanks!


Test queues

In what area(s)?

/area administration
/area ansible
/area autoscaling
/area configuration
/area cyclecloud
/area documentation
/area image
/area job-scheduling
/area monitoring
/area ood
/area remote-visualization
/area user-management

Describe the feature

Hi Xavier,
It would be great if we could set a few test queues in azhop. This would let our users run quick jobs without having to wait for node spinup time.
Currently, I'm approximating the behavior by setting a large idle time on some queues, but would be nice to have a setting which actually keeps the nodes alive forever using the slurm setting here: https://learn.microsoft.com/en-us/azure/cyclecloud/slurm?view=cyclecloud-8#excluding-a-partition. Also another common feature of these test queues is a short job timelimit. I don't see a way to set this from cyclecloud right now though, even though it is in /etc/slurm/cyclecloud.conf.
Thanks!
Matt

@matt-chan instead of excluding nodes from partition, I'm thinking on have a parameter to define how many cores/VM should always been on for each queue/partitions.

Hi Xavier, Yes I think that behavior would be best if we could achieve it, but I'm not certain it's possible. I originally tried to make a PR before making this feature request but I couldn't figure out how to do it. I'm not sure Cyclecloud and slurm have that functionality.
Your team is definitely better at this stuff than I am. If you can figure it out, it would be a great feature! Just to make sure we're on the same page, it is the number of idle VMs we want to keep in each queue right? So if there are 5 jobs, and the idle setting is 2 VMs, there should be 7 VMs running in total?

@ltalirz sounds a great start. Need to be run on the scheduler. Also ideally it should read the config file and pickup partition names, number of nodes to allocate.

Also ideally it should read the config file and pickup partition names

This is already how it works; the cronjob is
    - name: set up cronjob for queue warmup
      cron:
        name: "queue-warmup"
        job: "/usr/local/sbin/queue-warmup.sh {{ warmup_queues | map(attribute='name') | join(' ') }}"
        minute: "*/5"
        weekday: 1-5
        user: "root"
        state: "present"
      vars:
        warmup_queues: "{{ queues | selectattr('warmup', 'defined') | selectattr('warmup', 'equalto', true) }}"

Modification for keeping >1 warm nodes will require some modifications (more touching of nodes needed) but should be doable I guess. In practice, 1 node is already a great improvement in user experience and often all you need.


[Infra] Setup lucene snapshot maven repository

A S3 bucket is needed to store snapshot builds of lucene for periodically updating development branches with evolving lucene features. This is supported in RepositoriesSetupPlugin.java and needs to be changed to an OpenSearch S3 bucket.  Builds and publishing artifacts do not need to be automated. Committers and Maintainers should have write access to be able to manually push and update the codebase with updated snapshot builds.

@nknize are we able to use the apache snapshot repo instead? It looks like lucene nightly builds are pushed there. https://cwiki.apache.org/confluence/display/LUCENE/NightlyBuilds

Does this issue belong in https://github.com/opensearch-project/opensearch-build?


Monokai code style and coal dark mode

Pull Request Description
This pull request fixes #27 and #11.
For 11: code colour scheme changed to Monokai. Code scheme is now consistent across all 3 colour schemes.
- Most of the changes are done in rouge-highlight-colorful.css (colorful being the name of the old theme, future refactor should rename this)
- There are some changes (namely the background of the code block in the default theme) made in the minimised style.css.
- For the sepia and dark themes, these changes are made in website.css.
For 27: In process of converting to Coal, translating between the css classes in mdbook and those in gitbook, got a bit more work to do to get full coverage.
Checklist
Please include the following checklist in your PR:

[x] The documentation has been updated if necessary.
[x] All code has been tested where possible.

I think this is good to go for now


Not sending any message

My last issue described a problem with the PHP code because of the versions.
But after deleting those lines including count i accessed the page and yes, i added the yields and besides that i tried to send a message, but clicking the button of "send" it does not do anything.
Hope to get an answer soon, thanks.

For the count issue, if I have some extra time to night, I will fix it to support different version of php. as for the send not sending if you can please share more debug info i.e: console.log from your browser .
mean while my first guess would be :
@yield('scripts')
make sure you load Jquery
check your pusher keys in config/messenger.php

Hello @elbakly,
The keys work and they identify that the user are active. I mean, it actually works.
But the thing is that i added @yield('js-scripts') to the app.blade.php and also de css ones.
Jquery is also being loaded, but give me a second to show you the console of inspect element.

@danilogkir  Great I hope you enjoy it,
adding the jquery has to be done by the user a we don't know if he already have this in his existing setup and if he is using a specific version for any purpose, so this will let them add it knowingly


[Q] Is there a way to style button elements separately?

What would be the correct way (if it is at all possible) to style buttons, e.g., btn and btn-response-status parts as well as the tab-btn classes?
If I use css-file and css-classes attributes I cannot get styles to work.
If I use shadow dom styling I can kind of style buttons like this:
rapi-doc::part(btn-outline) {
    border-color: #0073E5;
    background-color: #FFFFFF !important;
    color: #000000 !important;
}

rapi-doc::part(btn) {
    border-color: #0073E5;
    background-color: #0073E5;
    color: #FFFFFF;
}

rapi-doc::part(btn-response-status) {
    border-color: #0073E5;
    background-color: #FFFFFF;
    color: #000000;
}

rapi-doc::part(btn-selected-response-status) {
    border-color: #0073E5;
    background-color: #0073E5 !important;
    color: #FFFFFF !important;
}

but cannot style the tab-btn since it is not a part and the :host(.tab-btn) wouldn't work.

added more css parts for tabs and tab-buttons

tab-panel
tab-btn-row
tab-btn