Feature: offer a way to determine if a response was sent gzipped

I'd like to understand if a response was gzipped so that I can verify my servers are behaving correctly in tests, but BridgeInterceptor eats the relevant header information. Instead of just stripping headers, it'd be ideal if there were a way to recover 'suppressed headers' or simply determine original encoding of the underlying source, while still getting automatic decoding of the response.

Try this:
Response response = ...
boolean gzip = response.networkResponse().header("Content-Encoding", "").contains("gzip")

Perfect, thanks.


codet5-base.gson.mid-599.idx-29543.2.mutant

No functional changes have been introduced, as the method still returns a SingleTypeFactory instance with the same parameters.


Refactor to represent a nearer real case.

The advantage of using Maven multi-module layouts is to share commons in the parent pom.
This example is using spring-boot-starter-parent as parent pom in the modules and it is not using the parent pom owned by the project, so I think that it is not a good example.
On the other hand, usually, in a multi-module project, Spring and no Spring modules are mixed. In the case of modules that are not related to Spring we don't want any dependency with it.
So I think that it is necessary to refactor this example to:

Refactor parent pom to add common stuff like properties, version, dependency manager for no Spring dependencies, surefire and failsafe configuration, etc.
Refactor Spring modules to use the parent pom in the project and use Spring BOM instead of the  spring-boot-starter-parent.
Add a no-Spring module with no Spring dependencies.

Thoughts??

My concern is that is difficult to find BOM examples working.
Using spring-boot-starter-parent in the parent pom is forcing you to take all Spring dependencies version and other configuration stuff into no-Spring libraries.
If the no-Spring module is an internal library used only for Spring modules, it is not a big issue (but not a good approach in my opinion). But when the library is used by external projects that are not using Spring at all, this approach is not acceptable I think.
In this case, using BOM in Spring modules is the only option.
I think that a lot of people are using the spring-boot-starter-parent in the parent pom too much because find an example of bom is difficult.

There is no “no Spring” module in this project though (and I don’t see the need for it). Even if there was I’d want the parent Pom to manage all dependencies (including spring) so it would make sense to use the starter parent.
I take the point about using a custom parent with a bom. It is likely to be where many projects end up. But this is a “getting started” guide, and I would want to be using the starter parent to get started (and for as long as possible afterwards), just for convenience.

Yes, I know that currently there is no "no Spring" module. What I mean is that it would be a more realistic case with a "no Spring" module.
Anyway, It was a suggestion and if the idea is to have a simple "hello world" then is fine. No really useful in my opinion, but fine for another "hello world".
Thanks for your time.
Thanks anyway.

I arrived at this thread after struggling with the same problem. Did not really know how to resolve the conflict between wanting to share common stuff (esp. library versions) in parent module and not wanting to use spring-boot-starter-parent in the parent module to avoid forcing spring dependencies onto my library modules.
Can't help shake the feeling that this was rather a "Getting started in the wrong direction" guide. Any project large enough to use modules will very soon reach a stage where it will need to address this issue.
Really appreciate @angelcervera for raising the question and his suggestion to use bom.


implement ansicolor=true

Currently ansicolors are not implemented, hence having repl style printed output is non-existence.

partially solve by 63d0e62adf949c38e85ef5dc24893cf49721ff6d


Agenda going forward or back daily and not monthly

I just come onto this project from a previous dev and he has set up big calendar to show one month of events, but when the user clicks on next or previous it only goes ahead or back by one day. How do I change it back to go forward or previous 30 days?
I looked everywhere in the code and I cannot find the option,  I found AgendaWeek and day set to one.  I set it to 4 weeks / 30 days respectively and still has not changed.

I have this same problem. Also, neither the agenda nor the month view renders. Day and week work fine but buggy with the problem that @Zanther describes

@Zanther I had similar requirements. I ended up creating a custom view modelled off Agenda. I used startOf and endOf month calculations throughout to get the outcome I wanted e.g.
import dateMath from 'date-arithmetic' ... const startOfMonth = dateMath.startOf(date, 'month') const endOfMonth = dateMath.endOf(date, 'month') let range = dates.range(start, end, 'day') events = events.filter(event => inRange(event, start, end, this.props))

the prop ya'll looking for is length which tells the agenda how much to show and how much to jump ahead
https://github.com/intljusticemission/react-big-calendar/blob/master/src/Agenda.js#L225-L230


Added SES verified emails list with the specific region.

Coverage remained the same at 70.0% when pulling 0517e96e33a6fc4a5e7206ed3934cdda6a1ff2c3 on swethanaretla:SES into 7c87c52a5487b7703d3775166d11c296cf22b8d1 on MicroPyramid:master.


Cargo test: redundant sections are bloating output by default

Describe the problem you are trying to solve
By default, cargo test can give bloated output for projects that don't have e.g. Doc-tests or other test groups.
I have a small project and have started writing first tests for it. When running cargo test, I get output:
    Finished test [unoptimized + debuginfo] target(s) in 0.02s
     Running target/debug/deps/sorts-6fd673432937221c

running 3 tests
test examine::tests::correct_not_sorted ... ok
test examine::tests::correct_sorted ... ok
test examine::tests::trivial_sorted ... ok

test result: ok. 3 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

     Running target/debug/deps/compare_sorts-06ef0930fe6c2e91

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

   Doc-tests sorts

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

The end of the output has two redundant sections that contribute no information and makes it a harder to get an idea at a glance of what has just happened (admittedly this might be less of a problem with experienced users - they know where to look).
Describe the solution you'd like
I would like either to have sections with 0 tests hidden completely, or at least reduced to single lines "Doc-tests {}: none found" or similar. Definitely not 0 count for many categories, as I must scan them all to make sure all are zero.
Notes
I recognize that this is less of an issue for experienced users that a) use selectors for the test they want to run; b) know where to look in the output. So this benefits beginners more. Streamlining the default behavior should make e.g. live demos easier on the other hand.

Thanks for the report!  Closing as a duplicate of #4324 and #2832.

Thanks for the report!  Closing as a duplicate of #4324 and #2832.


[Bug]: SQLTableRetrieverQueryEngine => "sql" at the start of most SQL statements

Bug Description
SQLTableRetrieverQueryEngine is generating SQL statements with "sql" at the start. For example:
sql
SELECT room$raw.name$ AS room_name, freezer$raw.name$ AS freezer_name
FROM freezer$raw
JOIN room$raw ON freezer$raw.location_id$ = room$raw.id
WHERE freezer$raw.archived$ = false AND room$raw.archived$ = false
ORDER BY room$raw.name$;

This results in GPT-4o stating "It appears there was an error in the SQL query provided".
Version
0.10.36
Steps to Reproduce
Follow https://docs.llamaindex.ai/en/stable/examples/index_structs/struct_indices/SQLIndexDemo/, but place in a streamlit chat app.
Relevant Logs/Tracbacks
No response

No one else has run into this issue?


Error in the doc's for Offline GA

I think there is an error in the doc's, see this link: https://developers.google.com/web/tools/workbox/guides/enable-offline-analytics
In the example you write:
importScripts('https://storage.googleapis.com/workbox-cdn/releases/4.0.0/workbox-sw.js');

workbox.googleAnalytics.initialize();

I think you mean to write this:
importScripts('https://storage.googleapis.com/workbox-cdn/releases/4.0.0/workbox-offline-ga.prod.js');

workbox.googleAnalytics.initialize();

I might be missing something, but I thought I file an issue just in case.
p.s. congrats to all the hard work and bringing out V4.

p.s. congrats to all the hard work and bringing out V4.

Thanks!

I think there is an error in the doc's, see this link:

The documentation is actually correct here. The workbox-sw.js file is just a script loader that loads the other dependencies based on the referenced namespaces, so when you refer to workbox.googleAnalytics, it automatically downloads that script.
You can read more about how workbox-sw works here:
https://developers.google.com/web/tools/workbox/modules/workbox-sw


Travis test the 3 os

Codecov Report

Merging #15 into staging will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           staging    #15   +/-   ##
======================================
  Coverage      100%   100%
======================================
  Files           17     17
  Lines          211    203    -8
======================================
- Hits           211    203    -8

Impacted Files
Coverage Δ

src/invoker/PhpInvoker.js
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 219928c...658b2ff. Read the comment docs.


make_classification_dataset with custom train/test split

Thanks for making this great repo!
I love that make_classification_dataset.py allows you to crop images using the megadetector and create the tfrecords at the same time.  One thing that has not been clear to me is how to specify a specific train/test split rather than having the script automatically split across locations.
Is there a way to do this?

Hi there! Unfortunately that's not possible right now (we're looking to change this in the summer), but as a workaround, you can run the script on your train set and set the split ratio to have zero test images (to create the training tfrecords), and then again on the test set, specifying for there to be zero training images (to create the test tfrecords).

I was getting a nonempty test.json even with a zero training image fraction, which I did not investigate further.  But what I ended up doing was to create custom train.json and test.json files in the cropped dataset, then ran data_management/tfrecords/create_tfrecords_from_coco.py   That appears to have worked.


feat(DataSet): Initial functionality and tests

You can now download a DataSet or complete an existing one with DataSet.objects.create(controller, start, end)

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add a solana_transaction_status::TransactionStatusMeta field to carbon_core::transaction::TransactionMetadata

We have access to that field on TransactionUpdate already from the datasource, so it is a low-hanging fruit to provide more context to processors.
For more context, here's the data inside that type:
#[derive(Clone, Debug, PartialEq)]
pub struct TransactionStatusMeta {
    pub status: TransactionResult<()>,
    pub fee: u64,
    pub pre_balances: Vec<u64>,
    pub post_balances: Vec<u64>,
    pub inner_instructions: Option<Vec<InnerInstructions>>,
    pub log_messages: Option<Vec<String>>,
    pub pre_token_balances: Option<Vec<TransactionTokenBalance>>,
    pub post_token_balances: Option<Vec<TransactionTokenBalance>>,
    pub rewards: Option<Rewards>,
    pub loaded_addresses: LoadedAddresses,
    pub return_data: Option<TransactionReturnData>,
    pub compute_units_consumed: Option<u64>,
}

Exactly what we would need


ignore command if the widget is no longer attached

This change is

Looks good. Will test this as soon as I can.

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io

May I ask what was reason for this change ?
I'm probably doing something wrong, but after this commit the context menu does not work anymore.
I open ContextMenu manually via open() over some Grid, but itemSelect is never invoked since the widget is always detached at that time.
I use the menu this way:
menu = new ContextMenu(someGridInstance, false);
menu.addItem(...)
menu.open(someX, someY);

When I mouseclick on the menu item, the standard Vaadin's (7.6.4)  VMenuBar#itemClick is invoked:
hideParents(true);
menuVisible = false;
Scheduler.get().scheduleDeferred(item.getCommand());

The menu is hidden / detached and when the scheduled command is invoked it is ignored.
Am I doing something wrong or is this a bug ? What's actually meaning of that isAttached() check ?

I retested this with a very simple context menu + item + notification, and it does work. If you're running into problems, please open a new ticket and provide a failing test UI so we can quickly debug and fix the issue.

The reasoning behind the isAttached check is to prevent keyboard shortcuts from triggering the menu item again after it has already closed.


not showing in eve app

Hi,
i think i'm just missing something, but the Plugin is not showing up in Eve or HomeKit.
this is my configuration:
{             "platform": "WeatherPlus",             "name": "WeatherPlus",             "service": "darksky",             "key": "XXXXXXXXXXXXX",             "locationGeo": [                 xxxxxxxxx,                 xxxxxxxxx             ],             "language": "en",             "units": "si",             "forecast": [                 1,                 2,                 3,                 4,                 5,                 6,                 7             ]         }
do i have to add this as accessory?

... had to restart.. sry^^


Add installation of container tools

Signed-off-by: phozzy<EMAIL_ADDRESS>A pull request for issue #320

Hello @phozzy, could you please pull latest master to your branch and I will run validation CI?

Hello @phozzy, could you please pull latest master to your branch and I will run validation CI?

Hi @maxim-lobanov , I did what you asked for. @al-cheb and @kpfleming also noticed that kubic repo supports 18.04 only. So, I removed changes for 16.04 (hope I did it right, since it was quite far ago when I did this PR).

/azp run ubuntu1804

/azp run ubuntu1804

Excellent to see this merged! When will the ubuntu-latest Actions image have these changes?

@kpfleming , Usually, image deployment takes about 1 week.
I will keep issue opened and will notify as soon as it is deployed

@kpfleming , Usually, image deployment takes about 1 week.
I will keep issue opened and will notify as soon as it is deployed

Thanks @maxim-lobanov !


Fix wrong independent version on first time publish

Follow up for #128 to fix the version bump from 2.3.2 to 3.0.0 on the CICS VSCE in https://github.com/zowe/cics-for-zowe-client/commit/17f8b88232eb214f290291c9e2f91504bb271007

Also, it used the lerna.json as a fallback since there was no git tag on the repo 😋

This seems to work as expected
LGTM! 😋
https://github.com/zowe/cics-for-zowe-client/actions/runs/7785494814/job/21228475834


Update model class diagram

Removed arrowheads from composition and aggregation

Pull Request Test Coverage Report for Build 609

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 78.268%

Totals

Change from base Build 606:
0.0%

Covered Lines:
1898

Relevant Lines:
2425

💛  - Coveralls


Detect function usages

Resolves #67

No measurable performance impact:
# before
Benchmark 1: vendor/bin/composer-dependency-analyser
  Time (mean ± σ):      1.448 s ±  0.041 s    [User: 1.243 s, System: 0.203 s]
  Range (min … max):    1.406 s …  1.553 s    10 runs

# after
Benchmark 1: vendor/bin/composer-dependency-analyser
  Time (mean ± σ):      1.448 s ±  0.019 s    [User: 1.253 s, System: 0.193 s]
  Range (min … max):    1.419 s …  1.474 s    10 runs

Should this detect usages of trigger_deprecation() from symfony/deprecation-contracts?
Because for me, it didn't work.

It does not work, because it's a global function referenced with neither FQN nor use statement, i.e. both the following would work.
use function trigger_deprecation;

trigger_deprecation(
    'teamneusta/pimcore-testing-framework',
    '0.13',
    'The "%s" class is deprecated, use "%s" instead.',
    TestKernel::class,
    RootTestKernel::class,
);

or
\trigger_deprecation(
    'teamneusta/pimcore-testing-framework',
    '0.13',
    'The "%s" class is deprecated, use "%s" instead.',
    TestKernel::class,
    RootTestKernel::class,
);

I see. I'll try that when I have some time again. Thx for the quick reply :)

I just tried prepending the \, but it still says symfony/deprecation-contracts is unused.
But now it also detects symfony/contracts as a shadow dependency.
Without leading \:

With leading \:

It just means that symfony/contracts is the actual library where the function gets declared first.

It's probably because one of my dependencies has symfony/contracts as its dependency, and symfony/contracts says it replaces symfony/deprecation-contracts.


Use standardized command parsing library for javaOpts

Fixes #2435
Adds apache commons-exec dependency

hold on, trying something out.


Fix IndexOutOfRange when it places a tile's part out of the world

Hi, i'm starting to learn c#, monogame and English :D, i want to help you in your project and learning in the process, of course, only if you want.

Huh, really wasn't expecting anyone to see this. Either way, looks good - merging. :)


Fixing bugs and maintaining website

Fixing all major and minor bugs and updated overall website issue #120

@mrbhatt2348 Have a look


Fix gcetcbendorsement build

Update ci definition to run gcetcbendorsment tests too.

Note this advances the Golang version from 1.19 to 1.20 and adds a Golang workspace in order to account for the second module that is gcetcbendorsement.
Golang 1.19 has reported vulnerabilities, and go-tpm-tools has advanced its requirement to 1.20, so I'm following suit.


Don't fail when linux ca-bundle file does exist for Palantir CAs. Also support centos

Before this PR
Internally, a service has a build that uses a redhat based linux rather than ubuntu. It does not have /etc/ssl/certs/ca-certificates.crt. Instead it has:
$ ls -l /etc/ssl/certs/
total 16
lrwxrwxrwx 1 root root   49 Sep 30  2021 ca-bundle.crt -> /etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem
lrwxrwxrwx 1 root root   55 Sep 30  2021 ca-bundle.trust.crt -> /etc/pki/ca-trust/extracted/openssl/ca-bundle.trust.crt

It fails with an error that:
Caused by: java.nio.file.NoSuchFileException: /etc/ssl/certs/ca-certificates.crt
	at com.palantir.gradle.jdks.PalantirCaPlugin.linuxSystemCertificates(PalantirCaPlugin.java:124)

After this PR
==COMMIT_MSG==

Support reading Palantir CA from the truststores of Redhat based systems
Do not fail if the system truststore cannot be found on linux
==COMMIT_MSG==

Possible downsides?

Does Files.exists check whether the link exists or the underlying file?

👍 was on a phone when I reviewed, but it does follow links, LGTM

Released 0.30.0


Support multiple Rejsekort cards

Fixes https://github.com/tmrowco/northapp-contrib/issues/395
Currently, the Rejsekort integration doesn't take into account users with multiple cards. As the code was rather inaccessible, I started by documenting most of the current behavior with a bunch of unit tests.
A note on mocking
The unit tests are done by mocking the https layer as this is used internally by superagent. One alternative was to mock superagent either using Jest (but turned out to be rather nasty due to the chained API) or using https://github.com/M6Web/superagent-mock (deemed too inflexible as we want the same route to return different responses).

I'll let you merge

@corradio thanks. I cannot merge, as I don't have write access (makes sense). So I'll let you merge. :)

There's a minor merge conflict in package.json after the other PR got merged :)

I’ll rebase it. 👍


fix: 🐛 add stats transfer report runtime type

Description

Breaking Changes

JIRA Link
DA-1281
Checklist

[ ] Updated the Readme.md (if required) ?

/fast-forward


Keyvault environmental variable reference support

Is your feature request related to a problem? Please describe.
Keyvault reference support. I would like to reference the key vault values exactly the same as if I were creating a function app on an app service plan in the environmental variables.
This is the error I got when I tried:
"Key Vault References are currently not supported for Functions on ACA. Please provide another value."
Describe the solution you'd like
I have sensitive keys/secrets that are stored in an azure keyvault. I want to references these values in a secure way by referencing the keyvault in the function app environment variables. e.g. '@Microsoft.KeyVault(VaultName=keyVaultFullName;SecretName=KeyvaultSecretName)'
https://learn.microsoft.com/en-us/azure/app-service/app-service-key-vault-references?tabs=azure-cli
Describe alternatives you've considered
Going to look into a dapr secret store as an alternative or referencing key vault in the code. not sure if managed identity is used at code level.
Additional context
I appreciate the error message being very explicit as to the issue.

Hi @Perks-of-Being-a-Cauliflower, could you please provide details about which location you've faced the error in, name of the app/resource id?

@Perks-of-Being-a-Cauliflower  - appreciate your response here. Else you can drop me a note to -<EMAIL_ADDRESS>

Sorry for the delayed response. The container/function app was created in Australia East, and the key vault is in Australia South-East (VNETs are peered). The portal had Australia East as an option, so I just assumed that it was supported when I was creating the bicep. I can't see Azure Container Apps in the list you provided so perhaps it's just not supported despite being available in the portal.

Can you email us the resource id and time the error occurred as this is not expected behaviour?

I don't have the original resource because I had to change to a Flex Consumption plan Function app due to time constraints. I will try to dig out the original code from source control.
I did suspect that AustraliaEast was supported. I just double-checked the documentation and the line that mentions that Keyvault references through environment variables not being supported is no longer there so I wonder if support has now been added.
I might try and do another deployment in my own time if/when I find the original code. My understanding was that the subnet delegation didn't allow for VNET-integrated function apps to access the keyvault via environmental variables but perhaps that has been fixed.


Refactor advancing token to avoid duplication, avoid borrow checker issues

Follow on to https://github.com/apache/datafusion-sqlparser-rs/pull/1587
Part of https://github.com/apache/datafusion-sqlparser-rs/issues/1558

@davisp made some great improvements to the Parser API to avoid copies, but now the API for managing tokens is a bit unwieldy. Before we release a new version I would like to improve the API
Speicfically some of the APIs take a &mut self to advance index but return a read only reference to the token. This means the borrow checker is overly stringent and will sometimes think the parser has a mutable borrow outstanding when it doesnt.
I think we can make the APIs easier to use (and thus more likely to use) with a bit of finagling and documentation
See definitions of previous/current/next on https://github.com/apache/datafusion-sqlparser-rs/pull/1617
I am hoping that we can get the API in shape a bit more and then deprecate some of the older style APIs.
Changes:

Introduce advance_token() to advance to the next token and reduce redundancy
Introduce get_current_token(), get_next_token() get_prev_token
Introduce current_token_index
Remove next_token_ref_with_index  and next_token_ref in favor of the above

Not sure I followed the intent of the comment, did it mean potentially replacing this api with something similar called advance or would that have a different behavior?

That is a good question -- yes I think I meant changing this API somehow so it doesn't end up preserving a mutable borrow to return the option.

BTW I spent some time last night and I found indeed it is possible to avoid these APIs. Here is what I came up with:

https://github.com/apache/datafusion-sqlparser-rs/pull/1626#


Fix #358

This avoids get_application directly merging the environment but solely parses the .toml for #358. Whether this is the best solution I'm not too sure, but in my case this is exactly functional for our produtions and fixes the issue.
I've implemented in the way I described in the issue:

My proposal would be to change: avalon.lib.get_application to only read out the toml, but not perform the environment management and leave that up to the action. We will need to read the .toml at least before "running" it to load the icon and color to be displayed in the Launcher

So visually it functions the same, it just now merges the environment at the end upon the call to environ() of the Application class.

Ah, thanks. Well spotted - will look into that and see what it is for. :)

Thanks, will still fix that thing @davidlatwe mentioned and then get ready to merge this.

I changed the call in session.py - I believe currently that module doesn't do anything and at the time was a draft implemented by @mottosso as an idea of turning the current session into a class. Yet it was never thoroughly tested nor used I think.
Maybe we should drop it at some point (to remove the dead code) or implement it if it has a purpose in the foreseeable future.


HeadTags: dochead instead of react-helmet

Well, seems to work better with dochead than react-helmet @SachaG :)
I wrapped the rendering in a component as recommended by the doc in order to have SSR.
The component accept props, which by default are set to the general information of the Telescope.
I removed the old one from Header and placed it in 3 places :

PostPage container to have access to post props.
PostListHeader which is displayed on "basic view".
UserProfile component to have access to a user data.

What do you think of the "placement"?
I'm thinking about using new utils/helpers like Telescope.utils.getLogoUrl() instead of Telescope.utils.getSiteUrl() + Telescope.settings.get("logoUrl");  and Posts.getPostThumbnailUrl() instead of post.thumbnailUrl. It would give a shorthand for access absolute url to logo and postThumbnail (maybe get it from embedly if active?).

Great! And yeah good idea about creating new helpers :)

Actually the current placement of the <HeadTags/> component adds an extra `div, which means an extra space in the Flexbox layout:

Is there any way we could do it without rendering an extra element? Or maybe move it somewhere else at least?

Yep, I do another PR with the headtags rendered in another place + the helpers.


Suppress command exit code error messages

Introduce recipe wide [no-exit-message] annotation to suppress exit
error messages from recipes without suppressing the error code.
Closes #1334

I didn't take a close look, but this looks good. Thanks for writing tests! Let's figure out if this flag should also suppress command echoing.

Nice, let me know when this is ready to review!

@casey, I think it is ready to review. We can update the docs when we agree on the implementation.
I have a couple of concerns here. If we need to add multiple annotations, we are likely to support a syntax like [no-exit-message, annotation2, annotation3] which we can't represent with annotation: Option<Annotation<'src>> any more. It will probably be something like annotations: BTreeSet<Annotation<'src>>. This won't be backward compatible with the json representation. Do you think we should now have annotations: BTreeSet<Annotation<'src>> within the recipe struct even though we currently have only one annotation type?

@casey, I think it is ready to review. We can update the docs when we agree on the implementation.

Nice! I'm just heading out of town for the weekend, so I won't be able to look at this until next week when I get back. Apologies for the delay.

I have a couple of concerns here. If we need to add multiple annotations, we are likely to support a syntax like [no-exit-message, annotation2, annotation3] which we can't represent with annotation: Option<Annotation<'src>> any more. It will probably be something like annotations: BTreeSet<Annotation<'src>>. This won't be backward compatible with the json representation. Do you think we should now have annotations: BTreeSet<Annotation<'src>> within the recipe struct even though we currently have only one annotation type?

Good thinking. One note: The JSON dump format is unstable, i.e., requires the --unstable flag, so it can be changed in backwards incompatible ways if necessary. Although I agree it's a good idea to avoid that if possible.
I actually think that recipes probably shouldn't have a BTreeSet of annotations, but rather they should have a suppress_exit_error_messages: bool field.

Thanks for the review. I agree with all the thoughts. I will be back with the changes in a couple of days.

I am not sure about CompileErrorKind::UnknownAttribute field type. Pushed all other suggestions. Also need to update GRAMMER.md.
Is this OK?
recipe        : attribute? '@'? NAME parameter* variadic? ':' dependency* body?

attribute     : '[' NAME ']' eol

Very nice! Great work, especially for a non-trivial PR that touches the parser!


Make usage of %c optional

Not all console.log implementations support it (React Native)

I'll make option for messages dictionary on this weekend.

Done in 2.1.1.


[Metrics] BLEURT

https://www.groundai.com/project/bleurt-learning-robust-metrics-for-text-generation/

Hello, I would like to work on this issue. Can you suggest some ways to get started?  The link provided in the description is not working anymore.


TS-4724: Modified ts_lua plugin to provide ts.server_request.remove_h…

TS_LUA and InkAPI.cc are modified to create a new ts_lua API to remove host name from URL in GET request to next-tier.

Kit: Could you please back port the commit on to 6.2.x branch if you are satisfied with the changes?

For new API in InkAPI.cc, please email to dev@ for an API review. Thanks.
After that I will continue to review the lua related portion.

Kit: I don't see any responses to the email I have sent to the dev@ email. What can I do to get the attention of required experts to comment?

I think @jpeach and me replied to your email. Did you not get the response??
Check out here -<EMAIL_ADDRESS>

oh and you need to subscribe to the dev@ mailing list to get those emails.

In general, this patch is trying to expose the "nuke_proxy_stuff" functionality as an API. And add lua plugin API for that as well.

Can we achieve the same with TSUrl*Set() APIs ?

If yes, then perhaps we don't need a new API.

If yes, then we can simply expose those TSUrl*Set() APIs through ts-lua plugin APIs.

Kit: Yes, we can achieve the same functionality using "TSUrlSchemeSet" and "TSUrlHostSet". I will expose these two APIs through ts-lua plugin APIs for "server_request". Should I expose TSUrl*Get() APIs too in ts-lua?
Could you please tell me what can I do to the existing pull request? Should I cancel the existing and raise new one? Please help me understand the right procedure.

I think it makes sense. Just make it look similar to "client_request".
I think we can close this one. And please change the title on the jira and open a new pull request with the changes on just ts_lua plugin's "server_request" APIs.
Thanks a lot.

Closing this PR as suggested by Kit. New PR #906 is submitted.


Handle azure oci manifest

Description of this issue (by @deitch):
AzureContainerRregistry actually sanely implements the OCI distribution spec, whereas Docker Hub does not. We ended up relying on the DHub implementation.
when you want to pull a blob, you use endpoint /v2//blobs/
when you want to pull a manifest, you use endpoint /v2//manifests/
What do you do when you have a sha256 but do not know if it is a manifest-type (manifest or index) or something else (layer or config)? The sane thing to do is have it always available via /blob, since a blob is a blob is a blob.
Docker Hub does not do that, it returns an error if what you are requesting is a manifest; Azure returns the content.
Signed-off-by: adarsh-zededa<EMAIL_ADDRESS>

It also is getting build errors.

It also is getting build errors.


Remove a User's ability to "cancel" their RSVP

@mathetos @JasonTheAdams Please remove the option for a user to cancel their RSVP. It actually does not work anyway and it just confuses the User.
We are trying to promote more conversation between a Volunteer (User) and SDRT staff regarding their once-a-week commitment, and the ability for a user to cancel their own RSVP gets in the way of this.
I literally fielded maybe 6 emails today from people saying they tried to cancel on the website but they couldn't so they emailed instead. We don't want people cancelling on the website, we want people to email. And we had 1 email from someone who received a confirmation email for tutoring but thought they had cancelled their RSVP online. VERY CONFUSING.

@JasonTheAdams To clarify, after a user has RSVP'd, they'll see the below message:

The "Cancel Here" is what is not working currently. This is output here:
https://github.com/SDRefugeeTutoring/sdrt-custom-functions/blob/c4519cdc22b7f59bed74ac22dc7ccd1ae2001995/plugin_customizations/tribe_events/tribe_events_customizations.php#L231-L236
Let's just change the wording to:

Need to cancel? Please email our Volunteer Coordinator at<EMAIL_ADDRESS>

Hi @mathetos and @dreazee!
Per Matt's direction, this is all set:

While I was in there I did find why the cancel button wasn't working. In fact, all users, regardless of whether they were marked as attending, would see the message intended for users marked to attend. This bug has been resolved. It still sounded like the new intent is to have users email instead of doing it themselves, so that's how it works now.
Since this was such a minor change I didn't bother to write up a PR and just pushed this straight to production. 🎉

@JasonTheAdams @mathetos  SO AWESOME. Thanks!!


feat: revised hover effect

closes #1134
👷🏻 Changes made

changed the hover effect of the outline buttons.
📸 Screenshots

@coderabbitai review

Important
Auto Review Skipped
Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.
To trigger a single review, invoke the @coderabbitai review command.
Tips
Chat with CodeRabbit Bot (@coderabbitai)
* If you reply to a _review comment_  from CodeRabbit, the bot will automatically respond.

* To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment

* Note: Review comments are made on code diffs or files, not on the PR overview.

* Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)
* `@coderabbitai pause` to pause the reviews on a PR.

* `@coderabbitai resume` to resume the paused reviews.

* `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository.

* `@coderabbitai help` to get help.

* `@coderabbitai resolve` to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.
CodeRabbit Configration File (.coderabbit.yaml)
* You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository.

* The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json).

* If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json`

@coderabbitai review


chore(package.json): :technologist: Added more export endpoints to make importing cleaner.

Updated the build tools to bundle functions, models, and operations as seperate exports to make importing and using easier. Developers will now be able to do import { point } from 'drizzle-postgis/models rather than having to do import { models } from 'drizzle-postgis' and then calling models.point.  Also turned of IIFE builds as they weren't exposed.
InteliSense and other autocompletes will now be able to detect the outputs directly, e.g. "point(...)" can show import point from drizzle-postgis/models as a suggested import action.

This looks good, thanks! If you want to increment the package version number to 1.1.1, it should automatically build and release an update.

Thanks so much!


Wrap tagging endpoints in a feature flag (disabled by default)

CATEGORY
Choose one

[ ] Bug Fix
[X] Enhancement (new features, refinement)
[ ] Refactor
[ ] Add tests
[ ] Build / Development Environment
[ ] Documentation

SUMMARY

Currently the tagging system only has a back-end that's part of the Superset codebase. We would like to be able to disable these endpoints inside of Preset until a front-end is adopted. In order to do that, I have added a feature flag to selectively enable the endpoints provided by TagView. I believe this change will primarily impact the deployment at Lyft (@betodealmeida @DiggidyDave)
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A
TEST PLAN

CI
Ensure endpoints supplied by TagView are not accessible after the change by default
Enable the TAGGING_ENDPONTS feature flag and ensure the endpoints supplied by TagView are operational.

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[X] Introduces new feature or API
[ ] Removes existing feature or API

REVIEWERS
@betodealmeida @DiggidyDave @dpgaspar @craig-rueda

Codecov Report

Merging #9078 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9078   +/-   ##
=======================================
  Coverage   59.45%   59.45%
=======================================
  Files         369      369
  Lines       11752    11752
  Branches     2889     2889
=======================================
  Hits         6987     6987
  Misses       4586     4586
  Partials      179      179

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 540df26...a2e4855. Read the comment docs.

Aha! Thanks @etr2460 I'll reuse the same.


Added hint when using certain tokens in when expressions

Fixes #1801 by adding a hint when a when expression contains tokens that govaluate considers invalid.
Example:
Name:                brackets-test-dl284
Namespace:           argo
ServiceAccount:      default
Status:              Failed
Message:             Invalid 'when' expression '{true} == {true}': Invalid token: '{' (Hint: try wrapping the affected expression in quotes ("))
Created:             Mon Dec 02 09:55:33 -0800 (16 seconds ago)
Started:             Mon Dec 02 09:55:33 -0800 (16 seconds ago)
Finished:            Mon Dec 02 09:55:49 -0800 (now)
Duration:            16 seconds

STEP                                    PODNAME                         DURATION  MESSAGE
 ✖ brackets-test-dl284 (brackets-test)                                            Invalid 'when' expression '{true} == {true}': Invalid token: '{' (Hint: try wrapping the affected expression in quotes ("))
 ├-·-✔ brackets (brackets)              brackets-test-dl284-69222893    8s
 | └-✔ no-brackets (no-brackets)        brackets-test-dl284-1849379471  7s
 ├---✔ no-brackets-test (success)       brackets-test-dl284-1733141821  4s
 └---⚠ brackets-test (success)                                                    Invalid 'when' expression '{true} == {true}': Invalid token: '{' (Hint: try wrapping the affected expression in quotes ("))

This issue arises because govaluate actually requires strings to be quoted – otherwise they are treated as tokens. Up to this point we have hard-coded a workaround to this so that users wouldn't have to always quote their strings:
https://github.com/argoproj/argo/blob/efb748fe35c6f24c736db8e002078abd02b57141/workflow/controller/steps.go#L262-L273
Since the only way to actively solve this (as opposed to passively providing a hint) would be to attempt to quote the strings for the user (which seems like a slippery slope), and we can't force users to quote their strings due to compatibility issues, I came to the conclusion that adding this hint is the best way to solve this problem.

@simster7 Please fixe the build issue.


MacOS: Using official namespaces do not work - 418 "Problems" on default template

Issue Description
This wasn't an issue until just recently.  Every dotnet core project is filled with omnisharp problems.  Noticed this on a project I opened up to continue working on for work (been about 2 weeks since I've worked on it and was working fine previously).  I decided to try creating a default project to see if the issue persisted there and it does.  Just creating a project with
dotnet new webapp

shows 418 problems.  Odd thing is if I go to the project file and save it without any changes, the problems are reduced to 134.  Either way, these are a few of the example problems that are being reported:
The type or namespace name 'System' could not be found (are you missing a using directive or an assembly reference?) [dotnetcore3.1]
The type or namespace name 'Microsoft' could not be found (are you missing a using directive or an assembly reference?) [dotnetcore3.1]
The type or namespace name 'PageModel' could not be found (are you missing a using directive or an assembly reference?) [dotnetcore3.1]

In my project for work where I have 1k+ reported problems, the majority are like so:
The type 'Object' is defined in an assembly that is not referenced. You must add a reference to assembly 'netstandard, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'. [Eclypses.Senet.Server]
The type 'Object' is defined in an assembly that is not referenced. You must add a reference to assembly 'netstandard, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'. [Eclypses.Senet.Client]
The type 'IAsyncDisposable' is defined in an assembly that is not referenced. You must add a reference to assembly 'netstandard, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'. [Eclypses.Senet.Client]

I have read up on this and tried multiple solutions to no avail.

Deleted and reinstalled the omnisharp extension located at ~/.vscode/extensions/ms-dotnettools.csharp-1.23.4
Reinstalled dotnet core 3.1 from the Microsoft website
Added a reference to netstandard in my .csproj file(s) two different ways<!-- THIS METHOD -->
<ItemGroup>
  <Reference Include="netstandard" />
</ItemGroup>

<!-- OR THIS MORE DETAILED METHOD -->
<ItemGroup>
  <Reference Include="netstandard" Version="<IP_ADDRESS>" Culture="neutral" PublicKeyToken="cc7b13ffcd2ddd51" />
</ItemGroup>

<!-- OR THIS MORE DETAILED METHOD WITH VERSION 2.0 -->
<ItemGroup>
  <Reference Include="netstandard" Version="<IP_ADDRESS>" Culture="neutral" PublicKeyToken="cc7b13ffcd2ddd51" />
</ItemGroup>

I've tried modifying my <TargetFramework> tag to <TargetFrameworks> and adding in netstandard in there<!-- THIS -->
<TargetFrameworks>netcoreapp3.1;netstandard2.1</TargetFrameworks>

<!-- OR THIS -->
<TargetFrameworks>netcoreapp3.1;netstandard2.0</TargetFrameworks>

where I read and found out that Roslyn can't deal with multiple target frameworks and defaults to the first one listed
Ran dotnet restore which has no issues restoring but incurs the same problems listed in VSCode as well as red squiggly Intellisense errors/warnings all over every page that tries to use an something from an official namespace
Rebooted computer (hell, sometimes it works?)

The dotnet CLI incurs no issues whatsoever.  If I run dotnet build, it builds correctly with 0 errors/warnings.  I can dotnet run and run the application with no issues.  I can open in Visual Studio and incur no warnings or errors like I do in Visual Studio Code.  It's quite baffling to me.  I'm tempted to bootcamp over to Windows and see if the same issues occur.
Steps to Reproduce
dotnet new webapp
Expected Behavior
No problems reported by omnisharp
Actual Behavior
Shows 418 problems and filling the screen with red IntelliSense squiggles everywhere that there is something using an official namespace.
Logs
When running dotnet build
Microsoft (R) Build Engine version 16.7.0+7fb82e5b2 for .NET
Copyright (C) Microsoft Corporation. All rights reserved.

  Determining projects to restore...
  Restored /Users/cush/Documents/Development/Unofficial/dotnetcore3.1/dotnetcore3.1.csproj (in 101 ms).
  dotnetcore3.1 -> /Users/cush/Documents/Development/Unofficial/dotnetcore3.1/bin/Debug/netcoreapp3.1/dotnetcore3.1.dll
  dotnetcore3.1 -> /Users/cush/Documents/Development/Unofficial/dotnetcore3.1/bin/Debug/netcoreapp3.1/dotnetcore3.1.Views.dll

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:03.75

OmniSharp log

When first loaded up
Starting OmniSharp server at 10/22/2020, 4:46:35 PM
    Target: /Users/cush/Documents/Development/Unofficial/dotnetcore3.1
OmniSharp server started with Mono 6.12.0.
Path: /Users/cush/.vscode/extensions/ms-dotnettools.csharp-1.23.4/.omnisharp/1.37.3/omnisharp/OmniSharp.exe
PID: 5148
    Starting OmniSharp on MacOS 10.15.6 (x64)

    DotNetPath set to dotnet

    Located 2 MSBuild instance(s)
        1: Mono 16.8.0 - "/Library/Frameworks/Mono.framework/Versions/6.12.0/lib/mono/msbuild/Current/bin"
        2: StandAlone 16.8.0 - "/Users/cush/.vscode/extensions/ms-dotnettools.csharp-1.23.4/.omnisharp/1.37.3/omnisharp/.msbuild/Current/Bin"

    Registered MSBuild instance: Mono 16.8.0 - "/Library/Frameworks/Mono.framework/Versions/6.12.0/lib/mono/msbuild/Current/bin"
        CscToolExe = csc.exe
        CscToolPath = /Users/cush/.vscode/extensions/ms-dotnettools.csharp-1.23.4/.omnisharp/1.37.3/omnisharp/.msbuild/Current/Bin/Roslyn

    Detecting Cake files in '/Users/cush/Documents/Development/Unofficial/dotnetcore3.1'.

    Could not find any Cake files

    No solution files found in '/Users/cush/Documents/Development/Unofficial/dotnetcore3.1'

    Queue project update for '/Users/cush/Documents/Development/Unofficial/dotnetcore3.1/dotnetcore3.1.csproj'

    Detecting CSX files in '/Users/cush/Documents/Development/Unofficial/dotnetcore3.1'.

    Could not find any CSX files

    Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.CSharpFormattingWorkspaceOptionsProvider, Order: 0

    Loading project: /Users/cush/Documents/Development/Unofficial/dotnetcore3.1/dotnetcore3.1.csproj

    Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.Completion.CompletionOptionsProvider, Order: 0

    Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.RenameWorkspaceOptionsProvider, Order: 100

    Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.ImplementTypeWorkspaceOptionsProvider, Order: 110

    Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.BlockStructureWorkspaceOptionsProvider, Order: 140

    Configuration finished.

    Omnisharp server running using Stdio at location '/Users/cush/Documents/Development/Unofficial/dotnetcore3.1' on host 4209.

    Successfully loaded project file '/Users/cush/Documents/Development/Unofficial/dotnetcore3.1/dotnetcore3.1.csproj'.

    Adding project '/Users/cush/Documents/Development/Unofficial/dotnetcore3.1/dotnetcore3.1.csproj'

    Update project: dotnetcore3.1

    Queue project update for '/Users/cush/Documents/Development/Unofficial/dotnetcore3.1/dotnetcore3.1.csproj'

    Loading project: /Users/cush/Documents/Development/Unofficial/dotnetcore3.1/dotnetcore3.1.csproj

    Successfully loaded project file '/Users/cush/Documents/Development/Unofficial/dotnetcore3.1/dotnetcore3.1.csproj'.

    Update project: dotnetcore3.1

When deleting obj/ and bin/ directories and reloading the window
  Determining projects to restore...
  Restored /Users/cush/Documents/Work/repos/Eclypses.Senet/Eclypses.Senet.MTE/Eclypses.Senet.MTE.csproj (in 120 ms).
Done: 0.
  Determining projects to restore...
  Restored /Users/cush/Documents/Work/repos/Eclypses.Senet/Eclypses.Senet.Server/Eclypses.Senet.Server.csproj (in 621 ms).
  1 of 2 projects are up-to-date for restore.
Done: 0.
  Determining projects to restore...
  Restored /Users/cush/Documents/Work/repos/Eclypses.Senet/Eclypses.Senet.Client/Eclypses.Senet.Client.csproj (in 481 ms).
  1 of 2 projects are up-to-date for restore.
Done: 0.

  I rarely every make posts on GitHub issues as I usually always find the solution, but I've been working on this for days now and I'm just hoping this is solvable at this point.  I've been using Visual Studio to get my work done but I've got a 500 line VSCode settings.json file for a reason haha.

@cushmatt Sorry about this issue. I had reverted the meaning of "useGlobalMono" to "always" because I was under the belief it shipped with MSBuild 16.8 but in fact it still ships with MSBuild 16.6. This is important because the 3.1.4xx SDKs require MSBuild 16.7 or higher. To fix you problem, set the "omnisharp.useGlobalMono" settings to "never" in VS Code and restart OmniSharp.

@cushmatt Sorry about this issue. I had reverted the meaning of "useGlobalMono" to "always" because I was under the belief it shipped with MSBuild 16.8 but in fact it still ships with MSBuild 16.6. This is important because the 3.1.4xx SDKs require MSBuild 16.7 or higher. To fix you problem, set the "omnisharp.useGlobalMono" settings to "never" in VS Code and restart OmniSharp.
Edit: This setting will be default back to "never" in our next release.

Thank You!!!  That fixed it.  Sounds good, I'm happy it was a simple fix and not something more complex that I had to do in every .csproj file.


Assertion Failed @.../bladebit/cuda/GpuStreams.xpp:571 UploadArry().

Problem in Phase 2 -> Compressing table 2 and 3

Linux Ubuntu 22.04 | 3960x | 256GB Ram | 3060 12GB

On a clean installation Ubuntu Server 22.04.2 is the problem the same

Thanks for the report. This has been fixed, but not yet pushed. Will be fixed in the next release

Fixed in b40fce737fe4d72b7882e9b0cd03f1bf8230a90a


Bump Dependencies #2904937256

Bumps dependencies for product-is. Link : https://github.com/wso2/product-is/actions/runs/2904937256

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.jenkins-is-staging seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


.ipynb

All the .ipnyb files in the course no longer open. Try to work on them, because we can't access the notebooks. Thank you!

Hello @sydneyceed  ,
You encountered some network issue or maybe it was fixed and it is loading the ipnyb file .

@sydneyceed I also got the same error but the error was due to an unstable internet connection.


RHEL-08-010201 task is replacing ClientAliveInterval value with ClientaliveCountMax.

Describe the Issue
RHEL-08-010201 task is replacing ClientAliveInterval value with ClientaliveCountMax, which eliminates the ClientAliveInterval value in the /etc/ssh/sshd_config file.
Expected Behavior
RHEL-08-010201 task should find the ClientAliveInterval line in /etc/ssh/sshd_config and update the configured value with the variable rhel8stig_ssh_session_timeout
Actual Behavior
The ClientAliveInterval line in /etc/ssh/sshd_config is being replaced by ClientAliveCountMax 0.
Control(s) Affected
What controls are being affected by the issue
Environment (please complete the following information):
Additional Notes
Possible Solution
`

name: "MEDIUM | RHEL-08-010201 | PATCH | The RHEL 8 SSH daemon must be configured with a timeout interval"
lineinfile:
path: /etc/ssh/sshd_config
regexp: '(?i)^#?ClientAliveInterval.*'
line: "ClientAliveInterval {{ rhel8stig_ssh_session_timeout }}"
notify: restart sshd
when:
- rhel_08_010201
- rhel8stig_ssh_required
tags:
- RHEL-08-010201
- CAT2
- CCI-001133
- SRG-OS-000163-GPOS-00072
- SV-244525r743824_rule
- V-244525
- ssh
`

hi @rheak
Thank you for taking the time to raise this bug and explaining the issue. We are currently working through the next STIG release and will be adding this as part of the next update.
regards
uk-bolly

hi @rheak
Thanks again for the feedback, this should be resolved in the latest devel branch incorporating the latest stig release updates as well.
I will close this issue over the next week unless you have any questions?
Many thanks
uk-bolly


[ci skip] Add a line before/after a code example

@yui-knk thank you! :heart:

thanks quick response !


Fixes issue 2804 by adding the GROVE_PROFILE_TYPE to the FormProfileController.js

Fixes #2804
What does this PR do?
It fixes an issue where when you view a grove profile type, the type displays 'select' instead of GROVE_PROFILE.
Fixes #2804
Which TC components are affected by this PR?

[ ] Documentation
[ ] Grove
[ ] Traffic Analytics
[ ] Traffic Monitor
[ ] Traffic Ops
[ ] Traffic Ops ORT
[ X] Traffic Portal
[ ] Traffic Router
[ ] Traffic Stats
[ ] Traffic Vault
[ ] Other _________

What is the best way to verify this PR?
Find a grove profile and view the details, you should see type is now GROVE_PROFILE
Check all that apply

[ ] This PR includes tests
[ ] This PR includes documentation updates
[ ] This PR includes an update to CHANGELOG.md
[ ] This PR includes all required license headers
[ ] This PR includes a database migration (ensure that migration sequence is correct)
[ ] This PR fixes a serious security flaw. Read more: www.apache.org/security

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2415/
Test FAILed.

retest this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2416/
Test PASSed.


[ng] fixed height is not working in datagrid

Select one ...  (check one with "x")
[x] bug
[ ] feature request
[ ] enhancement

Expected behavior

Specifying a fixed height should make a datagrid stretch to fill the height.
Actual behavior

The footer is appended right after the last data row, even though in the dom the container is set to the specified height.
Reproduction of behavior

Include a link to the reproduction scenario you created by forking one of the Clarity Plunker Templates:

https://plnkr.co/edit/WMnaRUVmXGLAptIlAlzS?p=preview
Environment details

Angular version: 4.0.1

Clarity version: 0.9.4-patch

OS and version: Mac OS Sierra

Browser: all

@hippee-lee: Is this still bugged or did #905 fix it?

Still a bug relatedf to the fix for #847 fix.


cellClass is not updating instantly

Hi,
Objective : want to highlight edited cell and mark them as red color if value is chnaged.
Editing the grid and change the random cell value.
Add a flag(isDirty = true;) to rowEntity from afterCellEdit.
Based on the isDirty value seting the cellClass to red in columnDefs.
Observation : cellClass is not updating instantly but it's updating the previously edited cellClass when edit another new cell.
code snippet :
$scope.gridModelAssets = {
enableSorting: true,
columnDefs: [
{ name:'fieldName', displayName:"Assets Field Name",enableCellEdit:false, width:'200'},
{ name:'value', displayName: 'Value',width: '200',enableCellEdit:'true', cellFilter:"currency:'&#x20B9 '",
cellClass:function(grid,row,col){
if(row.entity.isDirty){
return 'red';
}
}
}
]
};
$scope.gridModelAssets.onRegisterApi = function(gridApi){
    $scope.gridApiAssets = gridApi;
    gridApi.edit.on.afterCellEdit($scope,function(rowEntity, colDef, newValue, oldValue){
        if(newValue != oldValue){
            rowEntity.isDirty = true;
        }
        $scope.$apply();
        $scope.gridApiAssets.core.refresh();
    });
};

I have the same issue (cellClass not updating instantly). Tried your approach but calling notifyDataChange gives me this error: "Notified of a data change, but the type was not recognised, so no action taken, type was: [object Object]"   I verified that both parameters passed are valid
              if (newValue != oldValue) {
                    rowEntity.dirty = true;
                    gridApi.core.notifyDataChange(gridApi.grid, uiGridConstants.dataChange.EDIT);
                }

I don't think you include gridApi.grid.

It should be gridApi.core.notifyDataChange(uiGridConstants.dataChange.EDIT);


[SPARK-12242][SQL] Add DataFrame.transform method

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47429/
Test FAILed.

Should we add a test and a java version?

Test build #2192 has started for PR 10226 at commit a1fac56.

Test build #2193 has started for PR 10226 at commit a1fac56.

Test build #2193 has finished for PR 10226 at commit a1fac56.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n  * public class JavaIndexToStringExample \n

Test build #2192 has finished for PR 10226 at commit a1fac56.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

I want to add Java API, but we need to decide first do we have an interface for DataFrame -> DataFrame, or just reuse the existing one. What do you think?
I'm going to merge this one first so at least the Scala one can show up in 1.6...


Incompatible function arguments when importing flax.nn: ptopk_patch_selection

To replicate:
conda create -n ptopk python=3.8
pip install -r requirements.txt
python image_classification.py --config <some config> --workdir /tmp

Getting incompatible function arguments error when image_classification.py tries to import flax.nn:
TypeError: jit(): incompatible function arguments. The following argument types are supported:
    1. (fun: function, cache_miss: function, get_device: function, static_argnums: List[int], static_argnames: List[str] = [], donate_argnums: List[int] = [], cache: jaxlib.xla_extension.jax_jit.CompiledFunctionCache = None) -> object

Invoked with: <function _rfft_transpose at 0x7f22f751fdc0>, <function _cpp_jit.<locals>.cache_miss at 0x7f22f751fe50>, <function _cpp_jit.<locals>.get_device_info at 0x7f22f751fee0>, <function _cpp_jit.<locals>.get_jax_enable_x64 at 0x7f22f751ff70>, <function _cpp_jit.<locals>.get_jax_disable_jit_flag at 0x7f22f7526040>, (0, 2)

OS Info:
Ubuntu 20.04.1 LTS

same issue here, and as flax.nn already deprecated so should update to flax.linen too

In my case this is just due to not install cuda and cudnn, after properly install them, everything goes ok

Here's a same mistake when I "import jax" in python, the error info says:
`import jax
Traceback (most recent call last):
File "", line 1, in
File "/usr/local/lib/python3.8/dist-packages/jax/init.py", line 93, in
from . import image
…………
TypeError: jit(): incompatible function arguments. The following argument types are supported:
1. (fun: function, cache_miss: function, get_device: function, static_argnums: List[int], static_argnames: List[str] = [], donate_argnums: List[int] = [], cache: jaxlib.xla_extension.jax_jit.CompiledFunctionCache = None) -> object
Invoked with: <function _rfft_transpose at 0x7f5d7f4f70d0>, <function _cpp_jit..cache_miss at 0x7f5d7f4f7160>, <function _cpp_jit..get_device_info at 0x7f5d7f4f71f0>, <function _cpp_jit..get_jax_enable_x64 at 0x7f5d7f4f7280>, <function _cpp_jit..get_jax_disable_jit_flag at 0x7f5d7f4f7310>, (0, 2)`
and I don't know how to solve it.

You have to installed the required library which is found in the requirement.txt file

pip install flax==0.3.1 jax==0.2.10 works


Amazing 100% Undetectable Virtualbox Machine ?!

Hi hfiref0x
It's amazing how this guy "VektorT13" make a machine 100% undetectable by common detection tools
Do you have any thoughts how he was able to do that ?
Maybe he compiled his own version of virtualbox ?
https://www.youtube.com/watch?v=6Nu14PxpvCQ
https://openssource.info/threads/antidetekt-2018-ot-vektort13-versija-dlja-klientov-servisa.29214/

This is not a forum to exchange or ask anything unrelated. This is feedback form.


Allow for spaces and other special characters in file path to Storybook scripts

What Changed
Changes the mode of execution of the Storybook scripts so that spaces and special characters in the file path don't cause a failure.
How to test

Install the canary version (currently 0.0.10--canary.19b5ac2.0)
Run yarn archive-storybook and yarn build-archive-storybook in a project that that resides inside a directory with a space in its name

Change Type

[ ] maintenance
[ ] documentation
[x] patch
[ ] minor
[ ] major

@tevanoff QA looks good!


Add new option to bundle gem for choosing a CI sevice

Context
At the moment, every gem created with bundle gem will have configuration generated for Travis CI regardless of if you want to or not. When this change was introduced, Travis CI was a clear recommendation for most open source projects to use for testing their projects with. But this is no longer true, there are now lots of different CI services and Travis CI is no longer the clear recommendation it once was.
Changes
This PR introduces a new option to bundle gem for choosing a CI service or just not generating one at all.
Creating gem 'test'...
Do you want to add Continuous Integration to your gem? Adding a CI service to your project helps ensure your project is well tested before shipping your gem to users. Bundler recommends several different services for testing your code. For more information about each service, see:
* Travis CI:      https://travis-ci.org/
* Github Actions: https://github.com/features/actions
* Circle CI:      https://circleci.com/
* Gitlab CI:      https://docs.gitlab.com/ee/ci/

Type 'github', 'travis', 'gitlab' or 'circle' to generate those test files now and in the future. github/travis/gitlab/circle/(none):

I decided to add Github Actions, Gitlab, Circle CI along with Travis CI, which i think covers most services most people will typically go with.
Each service will generate it's own configuration which is ready to use out the box.

@bundlerbot r+

Specs seem to be hanging under Windows? Since this PR adds a new option that prompts for input, and I've never seen those hangs before, it sounds like it could be this PR's fault?


checkIFrames argument error ?

in checkIFrames function
checkIFrames
  checkIFrame(settings[key])
The  argument is settings[key].May be key is right?

I don’t understand your question

I think settings[key] need change to key

Good spot, do you want to male a PR?

Thanks will merge when I get some free time


Cannot deploy with Capistrano 3.5.0 after upgrade to Ruby 2.3.1p112 (2016-04-26 revision 54768)

Worked with Ruby 2.1.  This happens when deploying to multiple servers at once.  Server is Ubuntu 14.04.  Rails 4.2.6.  Same behaviour with Cap 3.2 and master.
It seems be creating self-referencing symlinks for log/log, public/system/system, tmp/sockets/sockets, tmp/pids/pids, tmp/cache/cache, vendor/bundle/bundle
my gemfile
gem 'capistrano', '3.5.0'
gem 'capistrano-sidekiq'
gem 'capistrano-rvm'
gem 'capistrano-bundler'
gem 'capistrano-scm-copy'
Detailed errors
cap aborted!
SSHKit::Runner::ExecuteError: Exception while executing as<EMAIL_ADDRESS>ln exit status: 1
ln stdout: Nothing written
ln stderr: ln: failed to create symbolic link ‘/opt/.../releases/20160720180448/log/log’: File exists
SSHKit::Command::Failed: ln exit status: 1
ln stdout: Nothing written
ln stderr: ln: failed to create symbolic link ‘/opt/.../releases/20160720180448/log/log’: File exists
Tasks: TOP => deploy:symlink:linked_dirs
(See full trace by running task with --trace)
The deploy has failed with an error: Exception while executing as<EMAIL_ADDRESS>ln exit status: 1
ln stdout: Nothing written
ln stderr: ln: failed to create symbolic link ‘/opt/.../releases/20160720180448/log/log’: File exists
** DEPLOY FAILED
** Refer to log/capistrano.log for details. Here are the last 20 lines:
capistrano.log
INFO [87787bde] Finished in 5.780 seconds with exit status 0 (successful).
INFO [70bb86bb] Running ~/.rvm/bin/rvm 2.3.1 do bundle exec rake assets:clean as dmitry@localhost
INFO [70bb86bb] Finished in 17.418 seconds with exit status 0 (successful).
INFO [1812e625] Running ~/.rvm/bin/rvm 2.3.1 do bundle exec rake assets:precompile as dmitry@localhost
INFO [1812e625] Finished in 56.384 seconds with exit status 0 (successful).
INFO [bcc87542] Running /usr/bin/env mkdir -p /opt/amplo/stg/shared /opt/amplo/stg/releases as<EMAIL_ADDRESS>INFO [3c49af83] Running /usr/bin/env mkdir -p /opt/amplo/stg/shared /opt/amplo/stg/releases as<EMAIL_ADDRESS>INFO [ab6ee55a] Running /usr/bin/env mkdir -p /opt/amplo/stg/shared /opt/amplo/stg/releases as<EMAIL_ADDRESS>INFO [3c49af83] Finished in 0.433 seconds with exit status 0 (successful).
INFO [ab6ee55a] Finished in 0.477 seconds with exit status 0 (successful).
INFO [bcc87542] Finished in 0.479 seconds with exit status 0 (successful).
INFO [d0a5aafb] Running /usr/bin/env mkdir -p /opt/amplo/stg/shared/log /opt/amplo/stg/shared/tmp/pids /opt/amplo/stg/shared/tmp/cache /opt/amplo/stg/shared/tmp/sockets /opt/amplo/stg/shared/vendor/bundle /opt/amplo/stg/shared/public/system as<EMAIL_ADDRESS>INFO [036d4589] Running /usr/bin/env mkdir -p /opt/amplo/stg/shared/log /opt/amplo/stg/shared/tmp/pids /opt/amplo/stg/shared/tmp/cache /opt/amplo/stg/shared/tmp/sockets /opt/amplo/stg/shared/vendor/bundle /opt/amplo/stg/shared/public/system as<EMAIL_ADDRESS>INFO [69145663] Running /usr/bin/env mkdir -p /opt/amplo/stg/shared/log /opt/amplo/stg/shared/tmp/pids /opt/amplo/stg/shared/tmp/cache /opt/amplo/stg/shared/tmp/sockets /opt/amplo/stg/shared/vendor/bundle /opt/amplo/stg/shared/public/system as<EMAIL_ADDRESS>INFO [d0a5aafb] Finished in 0.038 seconds with exit status 0 (successful).
INFO [69145663] Finished in 0.039 seconds with exit status 0 (successful).
INFO [036d4589] Finished in 0.042 seconds with exit status 0 (successful).
INFO [791ddedf] Running /usr/bin/env mkdir -p /opt/amplo/stg/releases/20160720191724 as<EMAIL_ADDRESS>INFO [01ac821d] Running /usr/bin/env mkdir -p /opt/amplo/stg/releases/20160720191724 as<EMAIL_ADDRESS>INFO [3a5af02f] Running /usr/bin/env mkdir -p /opt/amplo/stg/releases/20160720191724 as<EMAIL_ADDRESS>INFO [3a5af02f] Finished in 0.028 seconds with exit status 0 (successful).
INFO [01ac821d] Finished in 0.031 seconds with exit status 0 (successful).
INFO [791ddedf] Finished in 0.031 seconds with exit status 0 (successful).
INFO Uploading archive.tar.gz 10.02%
INFO Uploading archive.tar.gz 10.02%
INFO Uploading archive.tar.gz 10.02%
INFO Uploading archive.tar.gz 20.05%
INFO Uploading archive.tar.gz 30.01%
INFO Uploading archive.tar.gz 20.05%
INFO Uploading archive.tar.gz 20.05%
INFO Uploading archive.tar.gz 40.03%
INFO Uploading archive.tar.gz 30.01%
INFO Uploading archive.tar.gz 30.01%
INFO Uploading archive.tar.gz 50.05%
INFO Uploading archive.tar.gz 40.03%
INFO Uploading archive.tar.gz 60.02%
INFO Uploading archive.tar.gz 50.05%
INFO Uploading archive.tar.gz 40.03%
INFO Uploading archive.tar.gz 70.04%
INFO Uploading archive.tar.gz 60.02%
INFO Uploading archive.tar.gz 50.05%
INFO Uploading archive.tar.gz 80.01%
INFO Uploading archive.tar.gz 70.04%
INFO Uploading archive.tar.gz 90.03%
INFO Uploading archive.tar.gz 80.01%
INFO Uploading archive.tar.gz 60.02%
INFO Uploading archive.tar.gz 100.0%
INFO [5b4b855e] Running /usr/bin/env tar -xzf /tmp/tmp.kv2Vm4c575 -C /opt/amplo/stg/releases/20160720191724 as<EMAIL_ADDRESS>INFO Uploading archive.tar.gz 90.03%
INFO [5b4b855e] Finished in 0.614 seconds with exit status 0 (successful).
INFO [ef4235a4] Running /usr/bin/env rm /tmp/tmp.kv2Vm4c575 as<EMAIL_ADDRESS>INFO [ef4235a4] Finished in 0.080 seconds with exit status 0 (successful).
INFO Uploading archive.tar.gz 70.04%
INFO Uploading archive.tar.gz 100.0%
INFO [13660674] Running /usr/bin/env tar -xzf /tmp/tmp.xNKgZ200Pm -C /opt/amplo/stg/releases/20160720191724 as<EMAIL_ADDRESS>INFO [13660674] Finished in 0.596 seconds with exit status 0 (successful).
INFO [51117c6c] Running /usr/bin/env rm /tmp/tmp.xNKgZ200Pm as<EMAIL_ADDRESS>INFO [51117c6c] Finished in 0.047 seconds with exit status 0 (successful).
INFO Uploading archive.tar.gz 80.01%
INFO Uploading archive.tar.gz 90.03%
INFO Uploading archive.tar.gz 100.0%
INFO [e6e1a785] Running /usr/bin/env tar -xzf /tmp/tmp.uJQfuNoStV -C /opt/amplo/stg/releases/20160720191724 as<EMAIL_ADDRESS>INFO [e6e1a785] Finished in 0.559 seconds with exit status 0 (successful).
INFO [96bb1493] Running /usr/bin/env rm /tmp/tmp.uJQfuNoStV as<EMAIL_ADDRESS>INFO [96bb1493] Finished in 0.038 seconds with exit status 0 (successful).
INFO [d95f701a] Running /usr/bin/env echo "" >> REVISION as<EMAIL_ADDRESS>INFO [92fc67ba] Running /usr/bin/env echo "" >> REVISION as<EMAIL_ADDRESS>INFO [a5752527] Running /usr/bin/env echo "" >> REVISION as<EMAIL_ADDRESS>INFO [d95f701a] Finished in 0.026 seconds with exit status 0 (successful).
INFO [92fc67ba] Finished in 0.031 seconds with exit status 0 (successful).
INFO [a5752527] Finished in 0.028 seconds with exit status 0 (successful).
INFO [214b97cd] Running /usr/bin/env mkdir -p /opt/amplo/stg/releases/20160720191724 /opt/amplo/stg/releases/20160720191724/tmp /opt/amplo/stg/releases/20160720191724/vendor /opt/amplo/stg/releases/20160720191724/public as<EMAIL_ADDRESS>INFO [4dd15166] Running /usr/bin/env mkdir -p /opt/amplo/stg/releases/20160720191724 /opt/amplo/stg/releases/20160720191724/tmp /opt/amplo/stg/releases/20160720191724/vendor /opt/amplo/stg/releases/20160720191724/public as<EMAIL_ADDRESS>INFO [c4aa42d6] Running /usr/bin/env mkdir -p /opt/amplo/stg/releases/20160720191724 /opt/amplo/stg/releases/20160720191724/tmp /opt/amplo/stg/releases/20160720191724/vendor /opt/amplo/stg/releases/20160720191724/public as<EMAIL_ADDRESS>INFO [4dd15166] Finished in 0.032 seconds with exit status 0 (successful).
INFO [214b97cd] Finished in 0.031 seconds with exit status 0 (successful).
INFO [c4aa42d6] Finished in 0.034 seconds with exit status 0 (successful).
INFO [a0e1582d] Running /usr/bin/env ln -s /opt/amplo/stg/shared/log /opt/amplo/stg/releases/20160720191724/log as<EMAIL_ADDRESS>INFO [ff0ea545] Running /usr/bin/env ln -s /opt/amplo/stg/shared/log /opt/amplo/stg/releases/20160720191724/log as<EMAIL_ADDRESS>INFO [fae235dc] Running /usr/bin/env ln -s /opt/amplo/stg/shared/log /opt/amplo/stg/releases/20160720191724/log as<EMAIL_ADDRESS>INFO [a0e1582d] Finished in 0.028 seconds with exit status 0 (successful).
INFO [fae235dc] Finished in 0.030 seconds with exit status 0 (successful).

The output:
The deploy has failed with an error: Exception while executing as<EMAIL_ADDRESS>ln exit status: 1
ln stdout: Nothing written
ln stderr: ln: failed to create symbolic link ‘/opt/.../releases/20160720180448/log/log’: File exists

** DEPLOY FAILED
** Refer to log/capistrano.log for details. Here are the last 20 lines:

Would suggest that this is a server problem, not a Ruby version, or Capistrano problem.

Closing since this was cross-posted at Stack Overflow and the OP says it has been fixed.
http://stackoverflow.com/questions/38489364/cannot-deploy-with-capistrano-3-5-0-after-upgrade-to-ruby-2-3-1p112-2016-04-26


Updated JavaEE 7 to individual JavaEE 8 dependencies

JavaEE 8 has been released. Therefore, I updated the dependencies.
I also think that we should depend on individual spec APIs instead of using the full umbrella spec. As we are not officially part of Java EE anymore, we should make our dependencies more explicit.

@chkal ,
I agree. I believe that using the individual ones can bring less problems.

It looks quite good. Thank you @chkal. I think similar like Daniel too.

Looks great :)

I think it is always best to directly refer to single specs instead of umbrellas. But we should take care to refer to the same major and minor versions like the umbrella, so it is guaranteed that running an MVC application on a Java EE server will not fail due to version conflicts.

I think it is ok for now, but make sure that we depend on the Java EE 8 versions. Let's follow the development when Java EE is moved to Eclipse and follow the guidelines set up there.

Merging this one now...


fails dmg sound test

dmg_sound.zip

The currently failing tests are:

8: Length counter behavior while powered off
9: Wavetable RAM read behavior while playing
10: Wavetable trigger behavior while playing
11: Register behavior after power off/on
12: Wavetable RAM write behavior while playing

8 and 11 were easy to fix - they depend on the CPU being able to write to the length counters while the APU is powered off (on DMG only; CGB blocks the writes based on cgb_sound).
9, 10, and 12 seem like they will be much more difficult to fix as they depend on extremely precise CPU/APU timing.


Not working with 1.5.1

I cannot seem to get this plugin to work with the latest version?

Actually it is working I think I must have had some other javascript related problem.


Error in JSON-LD Lab

Found this while doing the EdX course:
Alice      | 2023-04-22 22:05:11,159 aries_cloudagent.messaging.base_handler ERROR Error processing issue-credential v2.0 problem report message
Alice      | Traceback (most recent call last):
Alice      |   File "/home/indy/aries_cloudagent/protocols/issue_credential/v2_0/handlers/cred_problem_report_handler.py", line 43, in handle
Alice      |     context.connection_record.connection_id,
Alice      |   File "/home/indy/aries_cloudagent/protocols/issue_credential/v2_0/manager.py", line 740, in receive_problem_report
Alice      |     message._thread_id,
Alice      |   File "/home/indy/aries_cloudagent/protocols/issue_credential/v2_0/models/cred_ex_record.py", line 268, in retrieve_by_conn_and_thread
Alice      |     post_filter,
Alice      |   File "/home/indy/aries_cloudagent/messaging/models/base_record.py", line 286, in retrieve_by_tag_filter
Alice      |     cls.name, tag_filter, f", {post_filter}" if post_filter else ""
Alice      | aries_cloudagent.storage.error.StorageNotFoundError: V20CredExRecord record not found for {'thread_id': '6a585e79-759a-470a-8ca7-00767b1ad14c'}, {'connection_id': 'fb2bde97-50fc-4e18-a7d4-2149c298d18e'}

proofType corrected


Making java memory configurable

Signed-off-by: Zane Williamson<EMAIL_ADDRESS>Describe your changes
Remove hardcoded memory allocation, and give ability to update jvm parameter.
Testing performed
Tested locally with solrcloud 8.2
Tested to verify present hardcoded value works as default

Great addition.

I'm gonna wait to merge this till after we merge the Collections PR, so that you don't have to even think about rebasing that one again!

I'm gonna wait to merge this till after we merge the Collections PR, so that you don't have to even think about rebasing that one again!

Thanks! sounds like a plan.

Also @swarupdonepudi and I started a public Slack Team for the project, hope you are cool with that?
https://join.slack.com/t/solr-operator/shared_invite/enQtNzY3MTUyMDAxNTY5LTAxNzJiMmZhYjhkOGM1NDdjYWUyMmRkMmE1M2M1Njg2M2MzODFjZDA1ZmViNzM2YTBiYjIwMzQzZWU3YzJhMTQ
Perhaps later we can see about moving to the K8s slack team

Hey @sepulworld , sorry for the delay. Just got back to having internet access. I was ready to merge this, but noticed that you merged in the changes from #26 as well, which I have a few comments for. If you remove those changes, and just keep the memory ones I'll merge it! I'll make my comments on the other PR for you as well, so we can get that merged soon too

Oy, looks like my branch was configured to merge updates in automatically. Im closing this for new patch. https://github.com/bloomberg/solr-operator/pull/27