Document display override classes

What
We should consider documenting our display override classes in the Design System as they help with some very common use cases but are currently hard to find.
  .govuk-!-display-inline
  .govuk-!-display-inline-block
  .govuk-!-display-block
  .govuk-!-display-none
  .govuk-!-display-none-print

Layout seems like the obvious place, probably under "Display override classes" heading (similar to "Width override classes" heading under "Spacing").
Why
To help our users to use things that already exist and save them time from having create their own classes.
Who needs to know about this
Stephen, Chris?
Done when

[ ] We've documented the classes in Layout

DRAFT CONTENT

Display override classes
Occasionally, you might need to override the default way that certain elements display on the page. You can use the display override classes for this.
Using the override classes
Here are the override classes for each of the following CSS display properties:

inline -  .govuk-!-display-inline
inline-block -  .govuk-!-display-inline-block
block -  .govuk-!-display-block
none - .govuk-!-display-none

You can also hide elements from the printed version of the page using .govuk-!-display-none-print.

I like Tim's suggestion. Suggest rejigging a little so it leads with the user tasks.
Override how elements display
You can use display override classes if you need to override how elements display on the page.
Use:

.govuk-!-display-block to display as a block
.govuk-!-display-inline to display inline
.govuk-!-display-inline-block to display as an inline block
.govuk-!-display-inline-none to display... (how do you describe this?)

You can also hide elements from the printed version of the page using .govuk-!-display-none-print.


Fix HTTPS Scheme when using HTTP2

When using HTTP/2.0 the default scheme given is http. Check if the server is running HTTP/2.0 and if TLS is being used.
Resolves issue https://github.com/ant0ine/go-json-rest/issues/202

Thanks for the change! Merging ...


Decide what to do with the connector-ilpv4-api module.

Much of the classes in this module are deprecated. We should figure out what to do with these classes -- maybe we move them to Quilt or Artemis or whatever.

This is completed. Module removed.


No notebook report in VS Code

Not sure if I should open another issue for this, but I also don't see any notebook report when using VS Code:

Originally posted by @dberenbaum in https://github.com/iterative/dvclive/issues/537#issuecomment-1520986820

@daavoo This is local, not codespaces.


add support for mtk phones

Prerequisites

[x] Have you read the wiki?
[ ] Is your device in the supported list?
[ ] Does the device have a Snapdragon SOC which is supported in this repo?

Description
[Description of the bug or feature]
Expected behavior: [What you expected to happen]
Actual behavior: [What actually happened]

Never :trollface:

not msm :)


Filter not working with rows

Title. Filters are not working when using rows. :sob:
without rows: working
with rows: not working

A shame this bug is around. I was messing with it last night wondering why what I was doing wasn't working... so decided to check bugs and here it is.
Do you know of any good workaround for this?

Downgrading to 1.5.8 worked for me.

Sorry about this, looking into it

Downgrading to 1.5.8 doesn't worked for me, i've tried several versions from the 1.5.* : same results.

Just letting you know: I'll be happy if this bug gets fixed but I can't help troubleshooting for now. Since it was urgent I wrote my own solution.

Can you maybe share it with us ?! It was urgent with me too... :-)
2015-12-22 19:55 GMT+01:00 babbelnedd<EMAIL_ADDRESS>
Just letting you know: I'll be happy if this bug gets fixed but I can't
help troubleshooting for now. Since it was urgent I wrote my own solution.
—
Reply to this email directly or view it on GitHub
https://github.com/kenwheeler/slick/issues/1924#issuecomment-166702666.

--
Benjamin Jeanjean
CEO - Gobeliner Fondateur
06 23 75 79 20 -<EMAIL_ADDRESS>--
The Gobeliners http://www.thegobeliners.com
*Agence de communication et d'idées *
462 rue Benjamin Delessert https://goo.gl/maps/x0Pld
77550 Moissy Cramayel https://goo.gl/maps/x0Pld
<EMAIL_ADDRESS>- 09 72 36 42 10
Stay in touch : Facebook http://www.facebook.com/TheGobeliners - Twitter
http://twitter.com/thegobeliners

It's a very specific + quick&dirty solution. You'll be faster writing your
own ;)
On Tue, Dec 22, 2015 at 7:56 PM, Benjamin Jeanjean<EMAIL_ADDRESS>
wrote:

Can you maybe share it with us ?! It was urgent with me too... :-)
2015-12-22 19:55 GMT+01:00 babbelnedd<EMAIL_ADDRESS>
Just letting you know: I'll be happy if this bug gets fixed but I can't
help troubleshooting for now. Since it was urgent I wrote my own
solution.
—
Reply to this email directly or view it on GitHub
<https://github.com/kenwheeler/slick/issues/1924#issuecomment-166702666
.

--
Benjamin Jeanjean
CEO - Gobeliner Fondateur
06 23 75 79 20 -<EMAIL_ADDRESS>--
The Gobeliners http://www.thegobeliners.com
*Agence de communication et d'idées *
462 rue Benjamin Delessert https://goo.gl/maps/x0Pld
77550 Moissy Cramayel https://goo.gl/maps/x0Pld
<EMAIL_ADDRESS>- 09 72 36 42 10
Stay in touch : Facebook http://www.facebook.com/TheGobeliners -
Twitter
http://twitter.com/thegobeliners
—
Reply to this email directly or view it on GitHub
https://github.com/kenwheeler/slick/issues/1924#issuecomment-166702912.

Okay, I will :-)
Thanks @babbelnedd

Any news on this one?

I wrote a fix myself, I do **not ** rely on .slick( 'slickFilter' ) nor I altered the Slick library. Who knows it will be broken again in the future when you update your slick and your fix is not added.
Here you go if someone is interested:
var $slider = $( '.slick-slider' );
var $slider_clone = $slider.clone( true, true ); // add true, true to clone events too!

// When someone clicks on a filter
$( '.filter-item').on( 'click', function(){
    var filter_name = $( this ).text();

    // Create a new clone for the slider items
    var $new_slider = $slider_clone.clone( true, true );

    // Clear current slider
    $slider.slick( 'unslick' ); // Remove slick
    $slider.empty(); // Remove elements

    // Show only filtered items
    if( filter_name == "All" ) {
        $slider.append( $new_slider.find( '.project-item-wrapper' ) );
    } else {
        $slider.append( $new_slider.find( '.project-item-wrapper.' + filter_name ) );
    }

    // Slick slider init or call your function that does it like I do
    init_projecten_slider();
});

Hello guys! Same issue here.
Do you know of any good workaround for this?
I´ve tried this code posted by cannect, but didnt work for me.
In the other thread #1350 (same issue), they said something about using :even to filter... But I have no clue for what this means.
Can you help me?
Thank you!

+1

+1

+1

+1


How to use full width of the canvas regardless of scrollbar

Due to right scroll bar, canvas table width not included scroll area.
Can we scroll area as overlay and let the cells use full width?

@joneit


[HW] ARUN

Name: Arun Gautham Rajarao
Email<EMAIL_ADDRESS>Linkedin Profile: @arun-gautham
Attach the homework step I screenshots below:
SCREENSHOT-URL
DEPLOY-URL
Attach the homework step II screenshots below:

Thanks Arun!

Awesome job Arun. Here's your badge -> https://api.badgr.io/public/assertions/eKnzWcsNTh-9Q1XrOQdHTg?identity__email=arunrajarao%40gmail.com


Simplify splicing

This change removes the ability to rewire inputs directly during splicing,
which is fairly complicated, and instead adds a TypeAwareInputMutator which
behaves like the InputMutator except that it takes type information into
account and attempts to find "compatible" inputs. The idea here is that
splicing with rewiring is roughly equivalent to a simple splicing followed by
an input mutation.

@amarekano PTAL

Some miscellaneous mutator correctness statistics:
[662EF2B7:Fuzzer] Mutator correctness rates: CodeGenMutator: 76.80%, InputMutator: 38.21%, TypeAwareInputMutator: 44.07%, OperationMutator: 70.77%, CombineMutator: 92.54%, JITStressMutator: 88.06%
[50593BBF:Fuzzer] Mutator correctness rates: CodeGenMutator: 68.75%, InputMutator: 63.38%, TypeAwareInputMutator: 66.35%, OperationMutator: 67.57%, CombineMutator: 100.00%, JITStressMutator: 87.93%
[01DD1446:Fuzzer] Mutator correctness rates: CodeGenMutator: 72.14%, InputMutator: 45.98%, TypeAwareInputMutator: 49.18%, OperationMutator: 61.19%, CombineMutator: 94.96%, JITStressMutator: 88.33%
[0235B7D1:Fuzzer] Mutator correctness rates: CodeGenMutator: 65.70%, InputMutator: 42.93%, TypeAwareInputMutator: 42.16%, OperationMutator: 53.47%, CombineMutator: 98.11%, JITStressMutator: 84.38%
[D72D1E10:Fuzzer] Mutator correctness rates: CodeGenMutator: 63.85%, InputMutator: 49.03%, TypeAwareInputMutator: 49.18%, OperationMutator: 56.06%, CombineMutator: 97.60%, JITStressMutator: 79.69%
[E4FA4B61:Fuzzer] Mutator correctness rates: CodeGenMutator: 71.47%, InputMutator: 42.61%, TypeAwareInputMutator: 42.98%, OperationMutator: 54.17%, CombineMutator: 97.67%, JITStressMutator: 92.50%
[862DB6D3:Fuzzer] Mutator correctness rates: CodeGenMutator: 65.96%, InputMutator: 36.84%, TypeAwareInputMutator: 40.00%, OperationMutator: 50.81%, CombineMutator: 98.39%, JITStressMutator: 85.34%
[61060C14:Fuzzer] Mutator correctness rates: CodeGenMutator: 69.26%, InputMutator: 53.61%, TypeAwareInputMutator: 54.84%, OperationMutator: 55.17%, CombineMutator: 100.00%, JITStressMutator: 88.76%
[507A9EE3:Fuzzer] Mutator correctness rates: CodeGenMutator: 66.37%, InputMutator: 44.22%, TypeAwareInputMutator: 50.00%, OperationMutator: 45.08%, CombineMutator: 98.54%, JITStressMutator: 88.00%
[2A647B47:Fuzzer] Mutator correctness rates: CodeGenMutator: 7.21%, InputMutator: 4.06%, TypeAwareInputMutator: 4.66%, OperationMutator: 12.03%, CombineMutator: 8.09%, JITStressMutator: 6.47%
[1FBADE60:Fuzzer] Mutator correctness rates: CodeGenMutator: 71.59%, InputMutator: 39.34%, TypeAwareInputMutator: 52.68%, OperationMutator: 48.67%, CombineMutator: 97.56%, JITStressMutator: 86.84%
[55DE316C:Fuzzer] Mutator correctness rates: CodeGenMutator: 69.23%, InputMutator: 43.37%, TypeAwareInputMutator: 49.62%, OperationMutator: 51.88%, CombineMutator: 96.10%, JITStressMutator: 86.39%
[80B56D91:Fuzzer] Mutator correctness rates: CodeGenMutator: 67.61%, InputMutator: 44.10%, TypeAwareInputMutator: 39.45%, OperationMutator: 48.98%, CombineMutator: 97.48%, JITStressMutator: 88.98%

@amarekano thanks for reviewing! Do you want me to merge this before https://github.com/googleprojectzero/fuzzilli/pull/256 or after?

I think you should go ahead and merge this PR, I'll rebase #256 after that. I've got an unresolved issue with #256 (see latest comment) that I'd like your thoughts on please.


ci: make pr title scopes mandatory.

Motivation
To be able to easily differentiate between PRs on different parts of the project and to make them consistent.

it's not working properly yet


[YUNIKORN-1041] Fix binding of dynamic volumes to pod

What is this PR for?
Fix binding of dynamic volumes to pods. This is broken after YUNIKORN-872. Also add additional error logging.
What type of PR is it?

[x] - Bug Fix
[ ] - Improvement
[ ] - Feature
[ ] - Documentation
[ ] - Hot Fix
[ ] - Refactoring

Todos

[ ] - Task

What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1041
How should this be tested?
Manual testing for now, e2e tests to be added to YUNIKORN-1039.
Screenshots (if appropriate)
Questions:

[ ] - The licenses files need update.
[ ] - There is breaking changes for older versions.
[ ] - It needs documentation.

Error occurring under 0.12.1:

Error gone after fix:

Do you plan to add any UT or e2e test for this?

Do you plan to add any UT or e2e test for this?

Yes, e2e tests will be added in YUNIKORN-1039. Those will take time to develop and this issue is a blocker for 0.12.2 so I don't think we should hold up the fix for the e2e tests to be developed.

bindPodVolumes from the context is called from an event in the task. That task event should have dispatched a failure which I assumed should have failed the whole task which should have triggered a retry etc.
If there was no failure there is an error handling issue. These changes do not change this at all. Does that mean that volume bind failures are not handled at all? Having a warning event does not equate to a failure does it?

task.postTaskAllocated() dispatches a FailTaskEvent if err != nil is returned from context.bindPodVolumes(), so I think we're good there.

Moving forward with this to unblock 0.12.2 release. @wilfred-s, if you have additional concerns, let's address in a follow-up patch for 1.0.0.


Ensure cloudstack-usage debian package is installed after cloudstack-management

Description
This PR ensures cloudstack-usage debian package is installed after cloudstack-management.
Post-install script in cloudstack-usage needs 'cloud' user to be present. 'Cloud' user is created in cloudstack-management post-install script.

Fixes: #7507

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[X] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[X] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[X] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

@benj-n
Normally usage server is deployed on management server host, however, it is not mandatory.

@weizhouapache
I can't see how this relates to the issue. Mandatory or not, IF usage is installed, it should be installed after management.

@benj-n
I mean cloudstack-usage does not depend on cloudstack-management. You can install cloudstack-usage on a server where cloudstack-management is not installed.

@weizhouapache
I get it. Then the management of the 'cloud' user must be included in the post-install of cloudstack-usage package ...

@DaanHoogland
can you review ? this is related to #6825

@weizhouapache I get it. Then the management of the 'cloud' user must be included in the post-install of cloudstack-usage package ...

Yes @benj-n , that is true. I wonder why this would work on other platforms without this. This needs to be fixed in the install procedure for the usage server itself and not by installing the management server. Probably an oversight.

@weizhouapache I get it. Then the management of the 'cloud' user must be included in the post-install of cloudstack-usage package ...

Yes @benj-n , that is true. I wonder why this would work on other platforms without this. This needs to be fixed in the install procedure for the usage server itself and not by installing the management server. Probably an oversight.

agree.
@benj-n
will you make changes on it ?
This need to be fix ed in <IP_ADDRESS>. can you please rebase with 4.18 branch ?

@blueorangutan LLpackage

(testing, not really packaging)

@andrijapanicsb a [LL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [LL]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6051

This PR should be superseded by https://github.com/apache/cloudstack/pull/7559

@benj-n can we close this one?


GeneralExtensions.cs causes compile errors

After installing the latest version of kera lua into my project and configuring the player settings list, I can not even compile the project due to these errors:
`Assets/NLua/Extensions/GeneralExtensions.cs(65,36): error CS1501: No overload for method `GetMethods' takes `2' arguments

Assets/NLua/Extensions/GeneralExtensions.cs(66,35): error CS0411: The type arguments for method `System.Linq.Enumerable.Any<TSource>(this System.Collections.Generic.IEnumerable<TSource>, System.Func<TSource,bool>)' cannot be inferred from the usage. Try specifying the type arguments explicitly

Assets/NLua/Extensions/GeneralExtensions.cs(114,36): error CS1502: The best overloaded method match for `System.Type.GetMethod(string, System.Reflection.BindingFlags)' has some invalid arguments
Assets/NLua/Extensions/GeneralExtensions.cs(114,36): error CS1503: Argument `#2' cannot convert `System.Reflection.BindingFlags' expression to type `System.Reflection.BindingFlags'

Assets/NLua/Extensions/GeneralExtensions.cs(142,34): error CS1501: No overload for method `GetMethods' takes `2' arguments

Assets/NLua/Extensions/GeneralExtensions.cs(161,78): error CS1501: No overload for method `GetMethods' takes `2' arguments

Assets/NLua/Extensions/GeneralExtensions.cs(165,38): error CS1928: Type `object' does not contain a member `ToArray' and the best extension method overload `System.Linq.Enumerable.ToArray<System.Reflection.MethodInfo>(this System.Collections.Generic.IEnumerable<System.Reflection.MethodInfo>)' has some invalid arguments

Assets/NLua/Extensions/GeneralExtensions.cs(165,38): error CS1929: Extension method instance type `object' cannot be converted to `System.Collections.Generic.IEnumerable<System.Reflection.MethodInfo>'

`

Just as an update the problem was that I was trying to build it for webgl.  Trying to build this as either a webgl application or an android application throws either this error or a related 'system.environment' not found error.
I know the author of this asset has stated that his focus is on pc game support, but is there anyway to fix these errors so that I can build and run them on those platforms?

I ran into the same problem, and I seem to have solved it by deleting the file NLua/Platform/BindFlags.cs.


Add NUKE build and GitHub Actions

switching from .NET 5 to .NET 6 to makes things simpler (demos/tests)

@RicoSuter now the logic should be in place, but in order to do publish API keys are required (that is why build on windows-latest fails, it tries to publish), I have configured them as follows for Quartz.NET which has the same logic:

When secrets are in place, it should push to MyGet automatically (if on main, master or nuke branch and no tag present).
When tag is pushed to master it should publish to NuGet, so a test tag could be v11.0-beta-1 for example, this could then be unlisted from NuGet. These are steps that I'm afraid you need to test with your permissions and keys.
Directory.Build.props now contains all shared package information and copy-pasting is no longer needed. There's single VersionPrefix will be used with suffix. Suffix is date for MyGet Release (NJsonSchema.CodeGeneration.CSharp.11.0.0-preview-20211122-1559.nupkg) and for tag-based builds the tag is the version.

Secrets added... what about the failed actions?

Btw, I created discord servers for NSwag and NJsonSchema if you want to chat :-) /cc @jeremyVignelles

I see they are failing because of the myget publish... rerunning... but probably we only want to publish to myget on "master", not in PRs, no?

Ok, seems to be working as expected. Only strange thing: Why is it running the "build" (and MyGet push), shouldnt this run only on master/main/nuke and not on PRs?

Sorry for the delay, I was out riding. This runs against master/main and nuke branch, we can remove the setup now as it's been verified (otherwise we would have needed to merge master to see it in action). I'll push a commit.

Btw, I created discord servers for NSwag and NJsonSchema if you want to chat :-)

I think it needs to be some sort of invite link, using the link https://discord.com/channels/912073155957374976/912073155957374980 directly gives:

Maybe test with incognito?

I've cleaned the PR and ready from my part 🚀

I can confirm that the discord link doesn't work. It doesn't look like an invite link either (invite links are usually in the form discord.gg/....)
Right click on a channel, and click "Invite"

Changed the badges to invite links...


merge from template-arlac77-github

README.md

docs(README): update from template

:tada: This PR is included in version 2.0.133 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[Dewhale] implements #230

[Dewhale] This PR implements #230, created by Dewhale.

[Dewhale]: Based on the provided image and instructions, here is a JSX code snippet for a header with navigation links and dropdown menus for additional items:
This code creates a header with a navigation menu that includes links and a dropdown menu for the "Docs" section. The dropdown contains links to "Introduction," "Installation," and "Typography" pages. The navigation links have hover effects to indicate interactivity. The header has a shadow to distinguish it from the rest of the page content.


Critical typo fixes

Starting with Windows 10 v20H1, a new "Optional updates" page has been added to the Settings app, Windows Update section. However, the corresponding column in this article contained only "No", which seemed strange to me. I found a Microsoft source that said this column must contain "N/A" and "Yes" respectively for the last two rows. (To be honest, I found that Microsoft source first.)
Also, I normalized the capitalization of the heading row of the table and eliminated verbosity. Windows 10 v20H2 is rolling out, so I reflected this fact in the last row.

Thanks @skycommand, we're impressed that you found these nuances not long after we updated this doc page.  Appreciate the assist


[CARBONDATA-2775] Adaptive encoding fails for Unsafe OnHeap if, target data type is SHORT_INT

problem:
[CARBONDATA-2775] Adaptive encoding fails for Unsafe OnHeap if, target data type is SHORT_INT
solution: If ENABLE_OFFHEAP_SORT = false, in carbon property.  UnsafeFixLengthColumnPage.java will use different compress logic. Not the raw compression. In that case, for SHORT_INT data type , conversion need to handle.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[ ] Any interfaces changed? NA

[ ] Any backward compatibility impacted? NA

[ ] Document update required? NA

[ ] Testing done
updated UT. Which will run all adaptive test cases with  ENABLE_OFFHEAP_SORT = false.

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.  NA

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/7438/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/6195/

@ravipesala : please review

LGTM

retest SDV please

retest sdv please

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/6000/

retest sdv please

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/6009/

@kumarvishal09 : PR is ready. please Merge

retest this please

retest sdv please

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/7587/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/6342/

LGTM


Dark theme based on System Theme

Please, go through these steps before you submit a PR.

[x] You've explained what the Pull Request is adding.
[x] You've explained why this is important.

Added them toggle based on system theme, user can choose between whether the theme will change based on the system theme or based on the toggle switch.
Fixed #13

Hey ! @rosekamallove Can you move the js folder to the assets folder . As it would give a clearer outlook to project files workflow.

Okay on it

Done

Works great.
@rosekamallove just a tip, don't add the checkboxes in your PR messages, just the updates themselves will do :)


FIx switcher for final scene.

The final scene is not properly switched to and prevents its puzzle from running.
This is either a script or trigger problem.

Closing as this task is connected to the merged PR #1062.


printMsg Handler does not work when the file is on Sharepoint or One Drive

I am not certain if this affects anything else in your code, but when a file is accessed through One Drive or Sharepoint it causes an error with opening the log file for messages.  The directory path for the App as accessed by Sharepoint uses a URL format:
"https://sharepoint.com/sites/Sitename/Subsite"
The directory you append, "\Logs" does not match the format and gives and error: Bad file name or number.

Hi Kevin, this is an interesting issue. Running from SharePoint might affect other codes though I don't expect any issues too major to be tweaked. Do keep us posted if you find anything else.


Update entity retrieved using Include

Hello,
I am having an issue with EF7 rc1:
First, I retrieve an entity using .Include, like this
var entity = await context.EntitiyA
    .Where(a => a.Id == id)
    .Include(a => a.EntityB)
    .FirstOrDefaultAsync();

Then I change properties in entity, do do:
context.EntityA.Update(entity);
await context.SaveChangesAsync();

At this point, I get an exception, because EF is trying to insert a new record for EntityB table, with entity.EntityB data. (in my case, because PK value was provided for identity column).

@ac-esousa can you include a full code listing that we can use to reproduce the issue (including you entity classes etc.)

Closing as we have not heard back with details


Removed dependency on pydot

Description:
Removed dependency on pydot. (A small update of get_unabbreviated_triples() also sneaked in...
Type of change:

[ ] Bug fix.
[ ] New feature.
[ ] Documentation update.

Checklist:

This checklist can be used as a help for the reviewer.

[ ] Is the code easy to read and understand?
[ ] Are comments for humans to read, not computers to disregard?
[ ] Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
[ ] Has the documentation been updated as necessary?
[ ] Does this close the issue?
[ ] Is the change limited to the issue?
[ ] Are errors handled for all outcomes?
[ ] Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments:

Closing because it is merged into RP #444


Issue [System_Actor] Karma ingestion button

When using the actor plus and minus buttons that we ingested onto the system actor the history log shows missing name, could be how the template is done, this needs to be looked at as it would be helpfull to know what skill was raised. This is fixed but removing will not show the reduction in the history

closed with #26


Upgrade dependencies

As per title, a PR in eventing breaks a test knative/eventing#4843, this should fix it.

/lgtm
/approve

/test pull-knative-sandbox-eventing-kafka-broker-integration-tests


Update automatically

Would it be possible for this to update automatically?  I understand that I can restart the container and it will pull the latest bedrock server version, but I'm not sure how to know when updates are released.  Right now it feels like I have to wait until clients are unable to connect before I'll know.  This isn't ideal because I may not be immediately available when the issue arises.  Thoughts?

Although not ideal, you could use Watchtower to automate updating your server containers. You would need to be careful to schedule Watchtower to run after a backup runs, so you have a known-good copy if there are any issues.

@joshuaganger is right. Instead, something would need to watch the download page like https://github.com/itzg/docker-minecraft-bedrock-server/blob/master/bedrock-entry.sh does and notice when the referenced download URL changes.

Sorry, I should explained myself better.
You can use Watchtower with its scopes and schedules to perform a daily container restart.
To accomplish this, we need to assign each bedrock server container the scope label in docker-compose.yml:
version: '3.4'
services:
  bedrock_server_1:
    image: itzg/minecraft-bedrock-server:latest
    labels:
      com.centurylinklabs.watchtower.scope: bedrock_srv
    environment:
      TZ: "America/Chicago"

Then (either in the same or separate docker-compse.yml) setup Watchtower to run on a daily schedule with the defined scope:
  watchtower:
    image: containrrr/watchtower
    volumes:
        - /var/run/docker.sock:/var/run/docker.sock
    command: --schedule "0 0 3 * * ?" --scope bedrock_srv
    labels:
      com.centurylinklabs.watchtower.scope: bedrock_srv
    environment:
      TZ: "America/Chicago"

The above example will tell Watchtower to run at 3am daily, and only execute against the containers with the defined scope label (bedrock_srv). Similar to performing backups, setting the TZ value is important.
Obviously, this method is not perfect and I still very much support an in-container method of server updates. Also, I am not sure what time of day MCBE updates are normally pushed, as that would impact the schedule. However, this should at least somewhat-automate your server updates.

 Sorry for the spam. :(
I think the "best" way to somewhat-automate updates is to just restart the containers on a schedule. Assuming you use a standardized name for your containers, this can be done by another container using the following docker-compose:
version: '3.7'
services:
  restart_agent:
    image: alpinelinux/docker-cli
    volumes:
      - "/var/run/docker.sock:/var/run/docker.sock"
    command: docker container restart -t 30 $(docker ps --filter name=mc_bedrock_srv* --quiet)
    deploy:
      restart_policy:
        delay: 24h

The name= variable accepts regular expressions. In my case, all of my server containers are prefixed with mc_bedrock_srv, so it is an easy glob.
Note that this runs on a loosely-defined schedule that will shift, which is not ideal. Alternatively, just scheduling a cronjob to run docker container restart -t 30 $(docker ps --filter name=mc_bedrock_srv* --quiet) may work better.

Hi,
is restarting the docker always enough? I am still not clear on when to restart and when to pull a new image. any hint appreciated


[OpenStack] SSH key support with OpenStack provider

Fixes #443.
Changes the OpenStack provider so that:

It creates a keypair based on the given public key.
Uses the created keypair with spawned instances.
Removes the keypair when the kube is deleted.

Coverage decreased (-0.2%) to 55.145% when pulling c1630cee9c7d109e5b2029263ce837880c3ff098 on wtsi-hgi:fix/443-set-os-keypair into 2bd4e007597c4e00ad676854518add3efc364f98 on supergiant:master.

Hi, @colin-nolan, thanks for helping the project along! Have you been able to sign our contributor agreement, yet?
https://www.tfaforms.com/425604

Unfortunately, CLAs cause us massive headaches... Although our culture is to be as open as possible and our software policy is to always distribute with a free license, there is rarely the requirement to give up copyright. As such it is not a well trodden path and it is laced with bureaucracy (it involves manager approval -> committee approval -> approval by someone near the top -> signing by legal department).
This is not to say we won't be able to get approval for the CLA to be signed but we're not going to be able to justify it unless we are sure that we are going to use Supergiant (at the moment, we are preparing it for evaluation). Even then, as you can imagine, it's not going to be a very quick process!
Is it an absolutely requirement for the CLA to be signed? I can imagine it causes problems for almost all corporate developers and subsequently puts them off from choosing the tool/ensuring changes are pushed backed.

@colin-nolan We really appreciate the continued involvement, but currently we do have to have the CLA signed. We're not allowed to take in any pull requests or use the code from them without it.

@colin-nolan want to push it as an individual contribution or do you want to cede all right to me and I'll sign a CLA with it ? :)

@bruno-morel unfortunately both of those options are not possible under the terms of my employment.

Rejecting Pull Please refer to Issue: https://github.com/supergiant/supergiant/issues/489


Master to doc

Codecov Report

Merging #358 into doc will decrease coverage by 0.1%.
The diff coverage is 55.55%.

@@            Coverage Diff             @@
##              doc     #358      +/-   ##
==========================================
- Coverage   31.74%   31.64%   -0.11%
==========================================
  Files          14       14
  Lines         989      986       -3
==========================================
- Hits          314      312       -2
- Misses        622      623       +1
+ Partials       53       51       -2

Impacted Files
Coverage Δ

plugins/notifier/lib.go
1.43% <ø> (ø)
:arrow_up:

plugins/check_event/lib.go
0% <0%> (ø)
:arrow_up:

apis/monitoring/install/install.go
83.33% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8594161...9c35646. Read the comment docs.


ignore, created in error

1.26.x-mercari.1 based version of https://github.com/mercari/orca/pull/1

ignore, created in error


'struct std::array<unsigned char, 64 ' has no member named '_Elems'

hashpp.h: 547  error: 'struct std::array<unsigned char, 64' has no member named '_Elems'.

Hi.
This error is caused by a per-platform implementation of the C++ std::array template class where _Elems may be the name of its internal buffer on one system's implementation of the C++ standard library, but another name on another.
This is my fault for using a platform dependent member and I will fix it as soon as possible.
Thanks.

This should now be fixed. See #13


java.lang.IllegalArgumentException: Bad value in PersistableBundle

Im adding a shortcut for my activity but when using the Parcels.wrap(object) this error appearing. Can add this feature ? Please take a look : PersistableBundle.java

I need a bit more to go on here... could you give me a concrete example?


Improvements / Additions to the base chef-repo

Hello,
This is my first pull request so I apologize in advance if I'm not doing something correctly.
First, I modified the 'chefignore' file to ignore more files by default (it's basically the same as the 'chefignore' automatically generated from 'https://preview.opscode.com/organizations'; however, I think the original 'chefignore' handled svn better so I kept that configuration)
Next, I added sample .chef/knife.rb and .chef/SAMPLE.knife.rb files with lots of comments; hopefully these will make it easier for users to get started in a shared environment.
Finally, I added the new knife.local.rb to the gitignore file (since it's unlikely that users will want to commit this in a shared environment).
Hopefully this is helpful :-)
Thanks,
Nick Henry

Hi,
Sorry for the lack of response on this. This example repository was not really maintained well over time. It's now considered deprecated for the chef generate repo command that is available in ChefDK.
Thank you for the pull request, and I'm sorry no one ever responded.

No problem, thanks Josh!


Consolidate and streamline logic to create an EmbraceSpanImpl instance

Goal

Testing

Release Notes

WHAT:
WHY:
WHO:

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#670  👈
#669
#668
#667
#666
#436
#435 : 1 other dependent PR (#437 )
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bidetofevil and the rest of your teammates on  Graphite


UDF in-sheet IntelliSense

I develop Excel-DNA, an Excel integration project similar to excel-d, but for the .NET languages.
One of the extensions I've made is an add-in that allows in-sheet IntelliSense for UDF functions similar to that displayed for the built-in Excel functions while typing a formula. The IntelliSense extension supports integration by other types of add-ins, not only those made with Excel-DNA. In particular, functions defined in VBA or through the native C API using any other language can also display their function descriptions through the Excel-DNA IntelliSense add-in.
For .xll-based add-ins like those made with excel-d, there are two integration options:

Next to MyAddIn.xll, place a file called MyAddIn.xll.intellisense.xml with some xml markup providing the function and argument descriptions. The xml content will be something like this

<IntelliSense xmlns="http://schemas.excel-dna.net/intellisense/1.0">
  <FunctionInfo>
   <Function Name="MyDLanguageFunction" Description="A function implemented in D"
              HelpTopic="http://www.bing.com" >
      <Argument Name="FirstArg" Description="Whatever you want to put in here" />
      <Argument Name="AnotherArg" Description="Actually the second arg" />
    </Function>
    <Function Name="AnotherFunction" Description="A function described in XML"
              HelpTopic="http://www.bing.com" >
      <Argument Name="FirstArg" Description="Whatever you want to put in here" />
      <Argument Name="AnotherArg" Description="Actually the second arg" />
    </Function>
  </FunctionInfo>
</IntelliSense>

Alternatively, you can create a special (hidden) function in the .xll add-in which is registered as a UDF with Excel and returns an array with the function registration information, as used in the xlfRegister calls to Excel. The registered function name will include a magic Guid that is derived from the .xll path - that's ow the IntelliSense extension find your info function. Details of the magic Guid, format of the table you should return and a sample implementation of the Guid calculation can be found in the RegistrationInfoGuid project.

Finally, after choosing either of the above options, you need to download the ExcelDna.IntelliSense.xll add-in from the GitHub Releases tab. This is the small add-in that provides the actual UI extensions. The (single-file) add-in can be renamed if you want to, and multiple instances (for example those embedded in other Excel-DNA add-ins) will negotiate among themselves to ensure that only one instance (with the latest version) will be active.
If you give the IntelliSense add-in a try and run into any issues with the D integration, I'd be very happy to help.

Hi govert.  Thanks for getting in touch.  I'm a little familiar with Excel-DNA.  Appreciate your thoughts.  @atilaneves  could we work on integrating these optionally ?  Maybe ExcelDNA is defined or not as a version, and if it is the program that generates the .def file also creates the .intellisense.xml file.  Or, it may be cleaner to go with the second option - just return the function registration info via special hidden function.

@Laeeth This can definitely be done.

@govert Thanks for letting me know.  We will do this, but it might take a little time.

@atilaneves ping


[Pager] Upgrade to Snapper 0.3.0

Removes the need to explicitly pass in the endContentPadding as we can rely on the necessary functionality in Lazy* (added in Compose 1.2.0).
Also removed some of the old deprecated overloads for PagerDefaults.flingBehavior(). This is a breaking change, but no one should be using them now anyway.

Is this PR defunct now that snapper is archived? Any plans to move to Compose inbuilt functionality?

I'll let @andkulikov comment on migrating to SnapFlingBehavior. I haven't been able to migrate in Tivi as its fling behavior doesn't quite meet my requirements, but it might work better for a pager. I'll close this PR

Raised https://github.com/google/accompanist/issues/1419 for tracking since this is closed.


Deploy all the examples on a Website

The examples of this tutorial are great. Can anyone create a Webpage with all examples that are online.

Done!
http://examples-wickettutorial.rhcloud.com
Let me know if some examples are missing.


API to test bearer token status

... So we know if we're logged in.

We documented an alternative best practice for this.


Adding/Removing Push Streams While Streaming

Ok, In the Nginx config file I have the following.
...
rtmp {

	# RTMP SERVER CONFIG
	server {
		listen 1935;
		chunk_size 4000;

		application mypush {
			live on;
			allow publish [My IP to lock the Upload];
			push rtmp://live-api.facebook.com:80/rtmp/[Stream Secret];
			push rtmp://a.rtmp.youtube.com/live2/[Stream Secret];
		}
	}
}

My Question is if I Start Streaming and I add or remove some of the push streams then I run the reload command for NGINX will it update while streaming or do I have to disconnect and reconnect to get it change the push targets.
Any Ideas or Comments would be handy.

I had this question too. I noticed that the config changes (i.e the extra destinations) do not reflect until the input stream is stopped and restarted. Any idea how this could be accomplished?

@regstuff @nhalstead
Did any of you guys found a workaround for this?
I'd appreciate any help, thanks.

Unfortunately no. I have not found a way to make this work without restarting the steam that is sending the RTMP stream.

@nhalstead Thanks for answering.
Is it possible to add this feature?
I'm new to nginx and I've no experience in c, but if it's possible I'll try to find someone who is experienced enough.

@AsadTalha That is something I can not answer, I'd like this feature as well but I have not seen an easy approach to do this and I am not phamiular with this codebase to even begin to implement something such as that.

I implement this feature by 3rd software, I do not use nginx's native push feature, I write a PHP & C service to pull and push streams.

@nxtreaming Could you tell me what 3rd software you used?
and also did you combine your PHP & C services with Nginx?

I implemented it by myself.
You can use PHP only, PHP can execute  ffmpeg as well.

I ended up using node's child_process with ffmpeg, It's working as I wanted.

I ended up using node's child_process with ffmpeg, It's working as I wanted.

YES, it's a good choice.

I ended up using node's child_process with ffmpeg, It's working as I wanted.

Same here. Did pretty much the same thing.


Parsing single Hex digits followed by ?

Steps to reproduce the issue
I am trying to parse some Verilog code:
module hexparse();
wire o;
wire a;
wire b;
wire [3:0] i;
assign o = i == 4'hb ? a:b;
endmodule

Expected behavior
Yosys successfully parses the module.
Actual behavior
Yosys errors out:
xyz.v:6: ERROR: syntax error, unexpected TOK_ID

The ? seems to get pulled into the number that is checked against. This only seems to happen for 4'hb and 4'hd, not for others.

https://github.com/YosysHQ/yosys/blob/fda94311ee6e3ec8de0e85e91251a2744673abaf/frontends/verilog/verilog_lexer.l#L242
The Radix characters allowed to appear many times. Shouldn't this be
[0-9]*[ \t]*\'s?[bodhBODH]?[ \t\r\n]*[0-9a-fA-FzxZX?_]+ {

?


Cage Labels

Cage
AHRS Reset
Reset Level
Level

Changed to "Reset /Level" with commit 95ade5a64b8c7d79ab81c6069faccc684b7458f0.


Fix cert rotation for proxyless, don't start SDS

The change also moves the injection template - istio-proxy will be first ( for readability and to avoid confusing people - it is reordered by injector anyways ), and handles the case where GKE cert provider is enabled by user via annotation.

@costinm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test release-notes_istio

lint_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test release-notes_istio

lint_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test lint_istio

gencheck_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test release-notes_istio

lint_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test lint_istio

gencheck_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test gencheck_istio

unit-tests_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test release-notes_istio

lint_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test lint_istio

gencheck_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test gencheck_istio

unit-tests_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test unit-tests_istio

integ-ipv6_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test integ-ipv6_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test release-notes_istio

lint_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test lint_istio

gencheck_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test gencheck_istio

unit-tests_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test unit-tests_istio

integ-ipv6_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test integ-ipv6_istio

integ-distroless_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test integ-distroless_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test release-notes_istio

lint_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test lint_istio

gencheck_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test gencheck_istio

unit-tests_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test unit-tests_istio

integ-ipv6_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test integ-ipv6_istio

integ-distroless_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test integ-distroless_istio

integ-cni_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test integ-cni_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test release-notes_istio

lint_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test lint_istio

gencheck_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test gencheck_istio

unit-tests_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test unit-tests_istio

integ-ipv6_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test integ-ipv6_istio

integ-distroless_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test integ-distroless_istio

integ-cni_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test integ-cni_istio

integ-pilot_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test integ-pilot_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test lint_istio

gencheck_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test gencheck_istio

unit-tests_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test unit-tests_istio

integ-ipv6_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test integ-ipv6_istio

integ-distroless_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test integ-distroless_istio

integ-cni_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test integ-cni_istio

integ-pilot_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test integ-pilot_istio

release-notes_istio
9b8147396774b93197c58ff76146f114ac3e2491
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test gencheck_istio

integ-ipv6_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test integ-ipv6_istio

integ-distroless_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test integ-distroless_istio

integ-cni_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test integ-cni_istio

integ-pilot_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test integ-pilot_istio

release-notes_istio
9b8147396774b93197c58ff76146f114ac3e2491
link
true
/test release-notes_istio

unit-tests_istio
9b8147396774b93197c58ff76146f114ac3e2491
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ipv6_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test integ-ipv6_istio

integ-distroless_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test integ-distroless_istio

integ-cni_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test integ-cni_istio

integ-pilot_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test integ-pilot_istio

release-notes_istio
9b8147396774b93197c58ff76146f114ac3e2491
link
true
/test release-notes_istio

unit-tests_istio
9b8147396774b93197c58ff76146f114ac3e2491
link
true
/test unit-tests_istio

gencheck_istio
9b8147396774b93197c58ff76146f114ac3e2491
link
true
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test integ-cni_istio

integ-pilot_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test integ-pilot_istio

unit-tests_istio
9b8147396774b93197c58ff76146f114ac3e2491
link
true
/test unit-tests_istio

gencheck_istio
9b8147396774b93197c58ff76146f114ac3e2491
link
true
/test gencheck_istio

release-notes_istio
33a60745a32c81454ce6e7cd2647d21d237225df
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test integ-cni_istio

integ-pilot_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test integ-pilot_istio

release-notes_istio
33a60745a32c81454ce6e7cd2647d21d237225df
link
true
/test release-notes_istio

gencheck_istio
33a60745a32c81454ce6e7cd2647d21d237225df
link
true
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test integ-cni_istio

integ-pilot_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test integ-pilot_istio

release-notes_istio
33a60745a32c81454ce6e7cd2647d21d237225df
link
true
/test release-notes_istio

gencheck_istio
33a60745a32c81454ce6e7cd2647d21d237225df
link
true
/test gencheck_istio

integ-distroless_istio
33a60745a32c81454ce6e7cd2647d21d237225df
link
true
/test integ-distroless_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test integ-cni_istio

integ-pilot_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test integ-pilot_istio

release-notes_istio
33a60745a32c81454ce6e7cd2647d21d237225df
link
true
/test release-notes_istio

gencheck_istio
33a60745a32c81454ce6e7cd2647d21d237225df
link
true
/test gencheck_istio

integ-distroless_istio
33a60745a32c81454ce6e7cd2647d21d237225df
link
true
/test integ-distroless_istio

integ-ipv6_istio
33a60745a32c81454ce6e7cd2647d21d237225df
link
true
/test integ-ipv6_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
d7eb0d55bbfd00a7aefce1f157b5f67d29067a62
link
true
/test integ-cni_istio

release-notes_istio
33a60745a32c81454ce6e7cd2647d21d237225df
link
true
/test release-notes_istio

gencheck_istio
33a60745a32c81454ce6e7cd2647d21d237225df
link
true
/test gencheck_istio

integ-distroless_istio
33a60745a32c81454ce6e7cd2647d21d237225df
link
true
/test integ-distroless_istio

integ-ipv6_istio
33a60745a32c81454ce6e7cd2647d21d237225df
link
true
/test integ-ipv6_istio

integ-pilot_istio
33a60745a32c81454ce6e7cd2647d21d237225df
link
true
/test integ-pilot_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
33a60745a32c81454ce6e7cd2647d21d237225df
link
true
/test release-notes_istio

gencheck_istio
33a60745a32c81454ce6e7cd2647d21d237225df
link
true
/test gencheck_istio

integ-distroless_istio
33a60745a32c81454ce6e7cd2647d21d237225df
link
true
/test integ-distroless_istio

integ-ipv6_istio
33a60745a32c81454ce6e7cd2647d21d237225df
link
true
/test integ-ipv6_istio

integ-pilot_istio
33a60745a32c81454ce6e7cd2647d21d237225df
link
true
/test integ-pilot_istio

integ-cni_istio
33a60745a32c81454ce6e7cd2647d21d237225df
link
true
/test integ-cni_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Replace .getRecentEvents with .getRecentEventsSortedByBlockNumber for related events for each card. #3955

Closes #3955

Code execution stats:
After PR
XXX: Took 0.02313709259033203 seconds for contractsAndCards: 408
XXX: Took 0.02388596534729004 seconds for contractsAndCards: 408
XXX: Took 0.05323898792266846 seconds for contractsAndCards: 408
XXX: Took 0.12642109394073486 seconds for contractsAndCards: 984
XXX: Took 0.06773591041564941 seconds for contractsAndCards: 984
Before PR
XXX: Took 0.42520391941070557 seconds for contractsAndCards: 984
XXX: Took 0.020550966262817383 seconds for contractsAndCards: 408
XXX: Took 0.07148492336273193 seconds for contractsAndCards: 984
XXX: Took 0.006186962127685547 seconds for contractsAndCards: 408
XXX: Took 0.07352697849273682 seconds for contractsAndCards: 984
Statistics after loading victor928.eth after delating the app
XXX: Took 5.805492401123047e-05 seconds for contractsAndCards: 0
XXX: Took 0.04068708419799805 seconds for contractsAndCards: 792
XXX: Took 0.04105401039123535 seconds for contractsAndCards: 804
XXX: Took 0.04412400722503662 seconds for contractsAndCards: 840
XXX: Took 0.042948007583618164 seconds for contractsAndCards: 840


remove data export restrictions added for WAMBO project

This removes the  quick and dirty data export restrictions added in #2612 to ensure we didn't leak the the WAMBO project's PII annotation task data.
The WAMBO classification annotation data has been removed from the database via https://gist.github.com/camallen/ca697d8d80002a8d99f7c6a7f4bd48c3. As such the export restrictions can be removed as well.
Review checklist

[ ] First, the most important one: is this PR small enough that you can actually review it? Feel free to just reject a branch if the changes are hard to review due to the length of the diff.
[ ] If there are any migrations, will they the previous version of the app work correctly after they've been run (e.g. the don't remove columns still known about by ActiveRecord).
[ ] If anything changed with regards to the public API, are those changes also documented in the apiary.apib file?
[ ] Are all the changes covered by tests? Think about any possible edge cases that might be left untested.

To be honest...is this worth removing? Is this code that could be abstracted a bit more to be able to turn off exporting problematic projects? There are a couple that I'm thinking of, one that I'm actively debugging, that probably shouldn't under almost all circumstances be exported normally.

To be honest...is this worth removing?

Yes - if you see the history of the PR this was a very dirty workaround for this particular WAMBO project. It blocks downstream systems from working via kinesis stream, stats, caesar etc.
We should remove this functionality as it's not longer being used and adds overhead (code maintenance / query execution times).

Is this code that could be abstracted a bit more to be able to turn off exporting problematic projects?

Yes, though we should do this from a clean slate not based on this work. The plan was/is to revisit the need for this functionality but rearchitect the code to ensure we handle both internal (stream and caesar stats etc) and external (researchers) use cases.

There are a couple that I'm thinking of, one that I'm actively debugging, that probably shouldn't under almost all circumstances be exported normally.

Research teams need their data via self service. It sounds more like a failing of the exporter code vs desired funcationality.

edit: A potential point in favor of removal is Caesar's FetchClassificationWorkers include this where (not ( clause in all their requests. We just had an awful lot of them run to backfill a project and it's probably worth looking into whether that was affecting query time.

where.not is almost never good, however in in this case the not was on the project table supplied with a project_id so should not have made a big impact on the query plan / lookup.

Fair enough. With the recent AACWC issues it seemed worth asking. LGTM.

Yep for sure, it's useful to know that we have in the past / can do this export blocking if we need to in future.


How do I normalize an object of values?

Hi, I got an object like this:
course : {
 modules {
   1: {id: 223},
   2: {id: 123},
   xxx
}

Is there a way I can define a custom function for serializing these modules?
Also, does the API contain a method to go from an object and to it's denormalized state?

I've noticed that arrayOf() will extract ids as keys, but it doesn't nomalise into an array. I have had to use Object.keys() as a workaround.
Keen to hear if there's a better approach.

This should be covered by valuesOf().


Remove relative line numbers and color columns in the match window

Call :setlocal norelativenumber and :set colorcolumn=0 after opening a
new match window so they won't show up in the match split. These extra
commands are not added to the existing commands array, as these are
7.3 features and need some feature detection to make sure they exist
first.

I amended my new patch to the old commit, so the comments have been removed from this pull request. You can still find them on the old commit: 735a3695cca13ef9296507fe8858391a32f240b8
In short: I added some feature detection to make sure your version of Vim supports relativenumber and colorcolumn, since they were added in 7.3. :)

This is broken, but I'll fix it and merge it (it looks like you didn't test it; there is no #exist function defined in the scope that you added your feature detection).

Hey Wincent,
Sorry about that. I did the last commit after I stopped using Command-T, and this proves you shouldn't do that once again. ;)


ieee conf template

we'd talked about adding this guy in a couple months ago, I just hadn't gotten around to doing it until now.

It looks like the two IEEE template directories got hit with MultiMarkdown, with a bunch of LaTeX versions of MMD files being included. Could you remove those files?

Oops. Should be taken care of now.

Thanks for the great work adding another template!


fix(widget-meet): remove duplicate incoming call handler

The incoming call handler is done with the media enhancer which already
is being used by the meet widget.

Deploy preview for hopeful-hamilton-4090b9 ready!
Built with commit 8b270633d2f29908e569c2a4f77b8dd966757f5c
https://deploy-preview-693--hopeful-hamilton-4090b9.netlify.com


Check if useRef variable is not null

Trying to fix the issue of the image below

Closing this PR for now, I'll check in another time


How to use ",," in magit?

What are you trying to achieve?

Additional information

Do you have screenshots/casts of this workflow in another editor or Emacs
distro? (If possible, include names of specific commands or functions from
other editors/emacs distros)

Do you have additional material or links to resources that could help clarify
what you are trying to do?

When in Spacemacs: OK

Searching in issues: not found

System information

Include the output of `M-x doom/info` or `~/.emacs.d/bin/doom info` here.

emacs   version    26.3
        features   NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES THREADS
        build      Sep 02, 2019
        buildopts  (--with-ns '--enable-locallisppath=/Library/Application Support/Emacs/${version}/site-lisp:/Library/Application Support/Emacs/site-lisp' --with-modules)
        windowsys  nil
        daemonp    server-running
doom    version    2.0.9
        build      HEAD -> develop ae75326a4 2020-02-10 02:39:26 -0500
        dir        ~/.doom.d/
system  type       darwin
        config     x86_64-apple-darwin18.2.0
        shell      /bin/zsh
        uname      Darwin 19.3.0 Darwin Kernel Version 19.3.0: Thu Jan  9 20:58:23 PST 2020; root:xnu-6153.81.5~1/RELEASE_X86_64 x86_64
        path       (~/.cargo/bin /usr/local/bin /usr/bin /bin /usr/sbin /sbin /Applications/VMware Fusion.app/Contents/Public ~/anaconda3/bin ~/anaconda3/condabin /usr/local/opt/coreutils/libexec/gnubin ~/.cargo/bin /opt/soft/protoc/bin ~/Code/bin ~/Code/src/github.com/9fans/plan9port/bin /Library/Java/JavaVirtualMachines/jdk-13.0.1.jdk/Contents/Home/bin ~/Code/src/github.com/BurntSushi/ripgrep/target/release ~/.fzf/bin /Applications/Emacs.app/Contents/MacOS/bin-x86_64-10_14 /Applications/Emacs.app/Contents/MacOS/libexec-x86_64-10_14 /Applications/Emacs.app/Contents/MacOS/libexec /Applications/Emacs.app/Contents/MacOS/bin)
config  envfile    envvar-file
        elc-files  0
        modules    (:input chinese :completion company ivy :ui doom doom-dashboard doom-quit hl-todo indent-guides modeline nav-flash neotree ophints (popup +all +defaults) vc-gutter vi-tilde-fringe window-select workspaces :editor (evil +everywhere) file-templates fold rotate-text snippets :emacs dired electric ibuffer vc :term vterm :checkers syntax spell :tools (eval +overlay) (lookup +docsets) magit pdf :lang data emacs-lisp go javascript markdown (org +dragndrop +present) python scheme sh web :config (default +bindings +smartparens))
        packages   (n/a)
        elpa       (n/a)
        unpin      (n/a)

I don't understand where ,, comes from. The keybind to commit has always been ZZ (for evil users) or C-c C-c (everyone). Or ZX/C-c C-k to abort.
Do these keys not work for you?

I don't understand where ,, comes from.

That's how spacemacs does it :thinking:

I don't understand where ,, comes from. The keybind to commit has always been ZZ (for evil users) or C-c C-c (everyone). Or ZX/C-c C-k to abort.
Do these keys not work for you?
EDIT: If you are asking how to bind these keys, you could try:
(map! :map with-editor-mode-map :n ",," #'with-editor-finish)

Sorry, I just used ",,", and took it as granted. Got it, thanks.

No worries! It just caught me by surprise -- I'm not terribly familiar with Spacemacs. In any case, glad we could figure this out! I'll consider this resolved. Cheers!


Fss bug fix: enable FSS to react to DeviceConfig updates and bring itself online

Description of changes:
Enable FSS to react to DeviceConfig updates and bring itself online
Why is this change necessary:
Currently if device provisioning isn't finished, when FSS starts up, FSS will not be able to start and the device won't be picked up by greengrass cloud. Customers have to restart greengrass to have FSS startup.
This fix enables FSS to watch for changes and bring itself up when provisioning completes.
How was this change tested:
Manually installed greengrass with a delay in fleet provisioning. Confirmed that device shows up in greengrass cloud after some time.
Any additional information or context required to review the change:
Checklist:

[ ] Updated the README if applicable
[ ] Updated or added new unit tests
[ ] Updated or added new integration tests
[ ] Updated or added new end-to-end tests
[ ] If your code makes a remote network call, it was tested with a proxy
[ ] You confirm that the change is backwards compatible

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Please name the PR in accordance with conventional commits.


Switching To PHP7

What do you think of using PHP7 instead of PHP5? In my opinion, that would boost the app performance.

This is even more important given that we (LycheeOrg) are dropping support of PHP5 from the 1st of January.
Also the next version of Lychee will be running on Laravel, this means Laravel requirements (>= 7.1.3).


Provide Vars component to more than "code" code blocks.

Currently the <Var> component is only usable in code blocks if:

The code block is using the code syntax,
The line where it's called is a "command" line (begins with $.

While I understand the logic that went into that decision, this component could be much more useful if it were allowed to render on all lines of all code blocks. Starting with the second point above, one may want to use the same content of a  in the output of a command so that it matches what's expected based on input.
More generally, this component could be used to improve the example config snippets we provide in yaml and similarly highlighted code blocks. A prime example (the one that led me here) would be a Var for the Teleport Auth/Proxy server address. Adding this and other key vars relevant to the specific doc could make for config examples that readers can just drag, drop, and go with.

Update: The Var component in code blocks only renders in the command itself, not in the output. This detracts from our ability to use this component in cases where the displayed output of a command is dependent on the value of the Var. See #26636 for an example.

To follow on from this, it would also be nice if the var had more code-like formatting when used in code blocks - at the moment they display in a much larger font than the surrounding code.

As the solution was merged, I returned Vars to the code output on the Register Cluster page that was deleted in https://github.com/gravitational/teleport/pull/26636, I opened PRs in the gravitational/teleport repo.

@alexfornuto seems this issue can be closed after merging returned vars on the Register Cluster page to versions 12 and 13 (already merged for the 14)

Currently we can apply Var blocks to more code blocks than code, syntax highlighting is lost. This is something we'll want to resolve, so rather than create a new issue how about we leave this one open until we can use Var blocks and syntax highlighting in the same block?


Hack Celluloid Out

Specs pass... wanna give it a try?

No, I do not want to try it out. Closing in favor of the far superior https://github.com/emcgee/att_speech/tree/remove_celluloid


enabling clahub for whole organizations rather than just individual repositories

We @Whonix have way too many repositories (~100+)(https://github.com/Whonix). Manually setting @clahub up for each of them would be a huge pain.
Could you add a feature please for setting up clahub for a whole https://github.com/organizations/* such as for example for the whole https://github.com/Whonix/*?

+1 :+1: :+1: :+1:

+1.  Same exact use case.

We have several repos in the Tessel Project which are governed by the same body. It is very likely that a single person will contribute to more than one repo, so having this feature would be greatly appreciated.

Duplicate of #61?

Has any progress been made on this?

Otherwise, can enabling clahub for loads of repositories be automated so I wouldn't have to manually enable this for 100+ repositories?


build: add missing dev deps

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 50.304%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
698

Relevant Lines:
1255

💛  - Coveralls


How to open RGB32F texture ?

I can't find the RGB32F format in bgfx::TextureFormat enum. But how can I load the HDR image?

HDR image is probably in RGBA16F or some other format. Also there is RGBA32F format.


⚠ Samsung has degraded performance

In 6c7bdd4, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 3435 ms

Resolved: Samsung performance has improved in 4054fca.


geckodriver: update to 0.31.0

Description of changes
The current version of Geckodriver on Nixpkgs, 0.30.0, is out of date for the current Firefox on Nixpkgs: https://firefox-source-docs.mozilla.org/testing/geckodriver/Support.html
I switched the source from Mozilla's mercurial repo to github.com/mozilla/geckodriver, where they also put the releases. This seemed easier since they include the Cargo.lock there so we don't need to check it in here.
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

@ofborg test vaultwarden nginx-etag


[FLINK-36390][core] Remove deprecated open(Configuration) method in RichFunction

Thanks for the reveiw.

I have a small question: Why are the OpenContext interfaces empty, while the DefaultOpenContext and WithConfigurationOpenContext are quite simple? Could these simple OpenContext subclass be combined into one?

This is by design: We want to use different implementations to distinguish different cases (passing different combinations of arguments to Open) to avoid incompatible changes to interfaces/classes.

Thanks for the reveiw!


How to read close frame message on client after refusing the handshake from the server

I was wondering if there is a way to include a message from the server in the closing frame when refusing a handshake. In my server, I check the handshake using onWebsocketHandshakeReceivedAsServer(...), and block unwanted connections with a custom message. However, when I test on my client, the code and message sent to onClose(...) after the handshake refusal is always the same:
code: 1002 - message: Invalid status code received: 404 Status line: HTTP/1.1 404 WebSocket Upgrade Failure

I have tried using the following lines in my server when refusing the handshake:
throw new InvalidDataException(4010, "Custom Message Here.");

throw new InvalidDataException(CloseFrame.POLICY_VALIDATION, "Custom Message Here.");

And neither of those seem to work.
Any guidance would be greatly appreciated, thanks!

Hey,
If you are rejecting the handshake in onWebsocketHandshakeReceivedAsServer(), the websocket handshake has not yet been completed.
Throwing an exception will result in a status code != 101 (404).
Clients will have to react to this. But since the handshake is not yet completed, there is no CloseFrame which could contain a close code and close message.
Best regards,
Marcel

Gotcha, so is it safe to assuming there's no way to send a client a message before the handshake completes? If that's not possible, it isn't a huge deal. My end goal would be to inform the clients as to why their connection got refused.

I would guess that most libs will not provide access to http error codes from the handshake.


[BUG]: Fix Generate Button Functionality

PULL REQUEST TEMPLATE
**My PR closes #161
👨💻 What did you do?
I formatted the Quotes.js which removed the unwanted spaces and commas and fixed it and the error that was being shown on the console was also fixed.
Note to reviewers
📷 Screenshots

✔ Check List (Check all the applicable boxes)

[X] My code follows the code style of this project.
[X] This PR does not contain plagiarized content.
[X] The title and description of the PR is clear and explains the approach.
[X] I have read the contribution guideline properly and following the criteria.

thanks for the colaboration,
dont forget to star the repo to help us grow


HTTP/2 Example Needs FullHttpRequest

Motivation:
The HTTP/2 hello world example server should be expecting a FullHttpRequest when falling back to HTTP/1.x mode.
Modifications:

HelloWorldHttp1Handler should process FullHttpRequestObjects
Http2ServerInitializer should insert an HttpObjectAggregator into the pipeline if no upgrade was attempted

Result:
Responses from the HelloWorldHttp1Handler should only come after full HTTP requests are received.

@nmittler - PTAL

LGTM

@Scottmitch one comments... rest looks good

Cherry-picked 4.1 (a7f83aa) master (972b4c6)


build: Add github build actions

CI Vulkan-ExtensionLayer build queued with queue ID 13735.

CI Vulkan-ExtensionLayer build # 37 running.

CI Vulkan-ExtensionLayer build queued with queue ID 13742.

CI Vulkan-ExtensionLayer build # 38 running.

CI Vulkan-ExtensionLayer build # 38 passed.

CI Vulkan-ExtensionLayer build queued with queue ID 13808.

CI Vulkan-ExtensionLayer build # 40 running.

CI Vulkan-ExtensionLayer build # 40 passed.

CI Vulkan-ExtensionLayer build queued with queue ID 13823.

CI Vulkan-ExtensionLayer build # 41 running.

CI Vulkan-ExtensionLayer build # 41 passed.


bug: there is no way to get back to home page

In the settings page, user can't get back to the home page.

User can click on logo icon in header and go back to home page.


Add Redis 2.0 package

Sharing code between Redis and StachExchangeRedis packages. Tested the single functional redis test locally.
https://github.com/aspnet/Home/issues/3536

Also copy over the baseline.netcore.json

Copy or generate a new one? The new one will update the AssemblyIdentity

Copy I think. Run it to make sure it works. We don't want any regressions from 2.1 here even though this is officially a new package.

I am confused about why StackExchangeRedis?

I am confused about why StackExchangeRedis?

@blowdart because we had a mail thread about it 😄 For the actual Redis package there's a naming hierarchy: Org.Product.Feature (or whatever). But in our case there's no hierarchy - it's just the OrgProductFeature variation of a package we have.

@anurse @Tratcher
The public APIs that include redis are class RedisXmlRepository, static class RedisDataProtectionBuilderExtensions with PersistKeysToRedis
Should PersistKeysToRedis be changed to PersistKeysToStackExchangeRedis? Should any others be changed?

PersistKeysToStackExchangeRedis seems like an odd API name to me. Sure, StackExchange is the org that implemented the client, but "Redis" is the name of the storage mechanism. We wouldn't name the API PersistKeysToMicrosoftRedis if we had implemented the Redis client.

I think PersistKeysToStackExchangeRedis is correct (or at least something like it), though it is a mouthful. That it's using StackExchange.Redis is not just an implementation detail - it's the purpose of the API.
And if it was the Microsoft one? I think it probably should say MicrosoftRedis, though in practice we often don't do that. E.g. we just say SqlServer and not MicrosoftSqlServer. We're lazy.

Ok, I see the thinking.
We'll need to update docs, by the way. https://docs.microsoft.com/en-us/aspnet/core/security/data-protection/implementation/key-storage-providers. This API was already documented as PersistKeysToRedis.

I'll do that tomorrow!


Event emitter memory leak

So I've noticed a node memory leak warning after failing a few tests.
Reproduction:
failing more than 10 consecutive tests should trigger the warning to the console
Solution:
I resolved it by using a helper function to ensure only one listener per channel is registered.
If you'd like, I can submit a pull request on it from this branch:
https://github.com/JM-Mendez/jest-electron-runner/tree/event-listener-memory-leak
the relevant changes are:
line #55
lines 111-120

@JM-Mendez pull request would be awesome! (you'll need to sign a CLA though)
also instead of checking for listenerCount we should probably keep some local state like processEventRegistered, because other parts of the test runner hook into process as well and can confuse the counters

Ok, did as you suggested, signed the CLA, and submitted the pull request. Let me know if there's anything else I overlooked.

closed via https://github.com/facebook-atom/jest-electron-runner/pull/15


ES6 Module Support

Hello,
Fantastic tool you've got here. Just wondering if you would considered supporting ES6 modules? I know the final spec wasn't out for a while but it seems like it has stabilized and might be worth considering. There is actually a project called node-detective-e6 as well: https://www.npmjs.com/package/detective-es6
Thanks much!

Hi,
Thanks! If I get time over I'll will absolutely take a look at this. But PRs are always welcomed in the meantime! :)

Support added in v0.5.0 now :)


Drop CocoaPods support?

I hope I don't get shunned 😅, but curious on how many feel about dropping CocoaPods support and just go pure Swift Package? The minimum Xcode version to submit to the App Store is Xcode 12 which is well above the minimum required to use SPM so I don't think supporting legacy is an issue.
Not only will this be less maintenance, but also we could get rid of the .xcodeproj and use only Package.swift (but I suspect there's more reasons than CocoaPods the Xcode project is needed).

Thanks for bringing this up @basememara!
I think there is still a strong case to support CocoaPods -- it is not dead yet. 😊 In fact, every major iOS project I have worked on in the past few years still depends on it, especially for bigger teams at bigger companies.
As you point out: for development you are free to use the Swift Package and ignore the Xcode project, or vice versa.
There is nothing particular about this project that requires CocoaPods. Rather, we distribute the library via both CocoaPods and SPM. Users can choose what works best for their projects.
Currently, there are significant barriers to entirely replacing CocoaPods with SwiftPM for most teams and most non-trivial projects. Until those are fixed, I'm committed to distributing libraries via both SPM and CocoaPods. 😄

We'll see in a few weeks at WWDC if SwiftPM improvements are coming soon. Let's revisit this then, if changes are announced. 😄

Thx for the links and writing those up. You're right there's still a bit of a gap to be filled that CocoaPods is covering. Even getting the lint scripts to run seems a bit of a challenge at the moment with SPM, or even a meta description is just completely absent. Sounds good to table this for another version or two.


Missing migration 0003_alter_cookie_id_alter_cookiegroup_id_and_more

I ran into a problem while trying to convert a site over to docker. I discovered that there is a missing migration 0003.
It would seem that running migrate on a new install will cause an error about the missing file. In a dev or local situation in which it's being run by a privileged user, it's fairly easy to solve by running makemigrations once, which will generate the missing file.
But, in docker, it's common to switch to a non-privileged user before running migrations, and it's generally discouraged from running makemigrations on prod servers. Attempting to run makemigrations as a non-privileged user causes an error when attempting to write out the missing migration file:

PermissionError: [Errno 13] Permission denied: '/usr/local/lib/python3.9/site-packages/cookie_consent/migrations/0003_alter_cookie_id_alter_cookiegroup_id_and_more.py'

So, ideally the migration file needs to be added to the package before that point. It looks like there is a pending PR for this very thing, which is quite convenient. I'm not entirely sure what the process is for approving PR's and getting those changes published out, but I'm willing to learn and help out where able.
In the mean time, my temporary fix which might work for others that are dealing with similar issues, is I just chowned the migrations directory and ran makemigrations. So the end of the dockerfile looks like:
# hack to fix cookie toolbar
RUN chown -R appuser:appuser /usr/local/lib/python3.9/site-packages/cookie_consent/migrations

# change to the app user
USER appuser

# run entrypoint.prod.sh
ENTRYPOINT ["/home/appuser/web/entrypoint.sh"]

and these two lines in entrypoint.sh:
python manage.py makemigrations
python manage.py migrate

This is related to Django's DEFAULT_AUTO_FIELD, which in your project is likely set to something else than "django.db.models.AutoField" and it is affecting cookie-consent because we don't specify it on the app-level.
This setting was added in Django 3.2. I'm working on Django 4.1 and 4.2 support and part of that is specifying this setting at the app config level which will prevent the "missing migration" situation.
Due to publishing issues you will have to install the updated package version from Github rather than PyPI as it will probably take some time for it to be available there :(
P.S. - unrelated, but in your (prod) docker image/container you likely don't want to run makemigrations, only migrate. Migrations are supposed to be generated at development time and checked into version control + your image build.


ci: Split ci jobs

Apply the same strategy from Pact PHP to this project:

Remove php-unit job, instead:
Add integration job:

No need to run on multiple dependency configurations, only highest is enough
Need to run on multiple php versions 8.1 -> 8.3
Disable code coverage
Windows: Because of rar extension can't be installed on PHP 8.2 & 8.3 , only run Integration tests on PHP 8.1

Add unit job:

No need to run on multiple os, only ubuntu is enough
Need to run on multiple php versions 8.1 -> 8.3
Need to run on multiple dependency configurations lowest/highest
Enable code coverage: pcov

Update github actions to remove node's version warnings
No longer limit running checks on pull request on branch main only
Allow cancel previous running jobs

Depend on https://github.com/pact-foundation/composer-downloads-plugin/pull/4

If you could re-base, and simplify to just split Integration and Unit tests, I think this would also be a great addition

dyld[3026]: Library not loaded<EMAIL_ADDRESS>Referenced from<EMAIL_ADDRESS>Reason: tried<EMAIL_ADDRESS>(no such file), '/usr/local/lib/libicuio.74.dylib' (no such file), '/usr/lib/libicuio.74.dylib' (no such file)

Look like the similar error happen again. Let me retry failed job


ibc: use outbound_ics20_transfers_enabled chain parameter

this uses the existing outbound_ics20_transfers_enabled to gate ics20 withdrawals

Discussed with @avahowell & @erwanor : we're going to merge this today, so it's included in v0.70.0 (#4087).


Clicking "Natural" or "Cymbal"  buttons on drums group select erases dynamics flags

Instrument drums
4-lane Pro Drums
Place down 2 or more notes using the note tool
Highlight 2 or more notes with the cursor tool
Click "accent" button. All highlighted notes should show "accent" modifier indicator.
Click "cymbal" button. Note that all available notes become cymbals, but "accent" modifiers have been erased.

Note that this current behaviour does not mirror the reverse behaviour, i.e. setting all cymbals notes to be accents does not clear cymbal flag. Therefore it's expected that accent modifiers should not be erased as setting a note as cymbal or a tom has no relation to dynamics.
@TheNathannator

Side note- "Natural" button should probably be a "Tom" button instead, but I don't overly care too much about that, just something to note.

I can see leaving Natural the way it is having some utility (since dynamics aren't the "natural" state), maybe adding a separate Tom button that doesn't affect dynamics would be good.

I can see leaving Natural the way it is having some utility (since dynamics aren't the "natural" state), maybe adding a separate Tom button that doesn't affect dynamics would be good.

Ended up not going with that since you had already replaced Natural lol, it's also not that hard to just make an extra click to set everything back.


Kokoro mac: Failed to activate the given service account.

I've seen this more than once:
https://github.com/grpc/grpc/blob/9fb4536821da85044339259063e60b95a42d447b/tools/internal_ci/helper_scripts/prepare_build_macos_rc#L34
gcloud auth activate-service-account --key-file=/tmpfs/src/gfile/GrpcTesting-d0eeee2db331.json
ERROR: (gcloud.auth.activate-service-account) Failed to activate the given service account. Please ensure provided key file is valid.

https://sponge.corp.google.com/target?id=b0dfae30-fb7d-4689-9912-7f88fbb6d7b2&target=grpc%2Fmacos%2Fmaster%2Fgrpc_basictests_dbg&searchFor=
Is the activate-service-account actually needed? I though just setting GOOGLE_APPLICATION_CREDENTIALS might be enough.

You're right, good catch.


Error[E0433]: failed to resolve: could not find coreaudio in host

Describe the bug
I try to build a dart interface to the cpal library
When I try to compile my very simple app I get the following error, both on iOS and Android :
SEVERE:    Compiling tau_cpal v0.1.0 (/Volumes/mac-J/larpoux/projmac/tau-cpal/tau-cpal/rust)
SEVERE: error[E0433]: failed to resolve: could not find `coreaudio` in `host`
SEVERE:   --> src/frb_generated.rs:29:17
SEVERE:    |
SEVERE: 29 | use cpal::host::coreaudio::macos::enumerate::*;
SEVERE:    |                 ^^^^^^^^^ could not find `coreaudio` in `host`
SEVERE:    |
SEVERE: note: found an item that was configured out
SEVERE:   --> /Volumes/mac-J/larpoux/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cpal-0.15.3/src/host/mod.rs:11:16
SEVERE:    |
SEVERE: 11 | pub(crate) mod coreaudio;
SEVERE:    |                ^^^^^^^^^
SEVERE:

Steps to reproduce
Here is the cpal sources :

Logs
`Cpal` is a layer under `web-audio-api-rs`.
I need to be able to access this layer, bypassing `web-audio-api-rs`

Expected behavior
No response
Generated binding code
No response
OS
No response
Version of flutter_rust_bridge_codegen
No response
Flutter info
No response
Version of clang++
No response
Additional context
No response

Hmm, looks like that mod is conditionally compiled -> https://github.com/RustAudio/cpal/blob/0da7ae1d426d471cf352550d0048bac91c8bac38/src/host/mod.rs#L10-L11, and we currently do not support such conditional compilation yet.

Close since inactivity, but feel free to reopen if you have any questions!

Hi @fzyzcjy ,
Actually I am very busy working on Flutter Sound maintenance.
Also I’m investigating if I can use lab_sound_flutter.
This is pure c++ and much easier for me to work on because I master c++.
But I haven’t give up with web-audio-api-rs . I just realize now that I can’t hope working on a rust project without learning first the language. I will do this.
‘Also, it is necessary to write a wrapper with dart, and can’t offer directly access to the rust or c++ library. This wrapper will have an api 100% compatible with the api offered by Google for web app. Perhaps it is possible to have a wrapper common for web-audio-api-rs and lab-audio.
Note : Flutter Rust bridge is much more powerful than the generator for C.
The C generator is just C, not C++, so necessary to write an other interface in c.
All this to tell you that I have much work to do, and nothing will be published before next year. I really need to learn rust.

I see. No worries and take your time!
Btw, I wonder what is missing for a 100% web-audio-api up to now - I guess there is https://github.com/fzyzcjy/flutter_rust_bridge/issues/2193; is there anything else? (I can keep them on my list, s.t. for example later maybe I can have a check on them)
P.S. About learning rust: Besides the rust books and exercises, the Rust community is very good (https://users.rust-lang.org/). When I have Rust questions, often someone there reply quickly. So I guess asking there when learning Rust if having a question may also be helpful.


Sample App Crashed Clicking on Send Transaction

Hello Team
I have implemented the sample code provided by the SDK documentation and have replaced the placeholder values with my magic link KEY. However, I have encountered an issue where, after logging in, the app goes to ANR (Application Not Responding) state when attempting to send a transaction, and nothing happens.
I have attempted to resolve this issue by making changes to the relevant method, as shown below, but I have not received any callbacks or indications of progress:
  val receipt = web3j.ethSendTransaction(transaction).sendAsync()
            receipt.whenComplete { ethSendTransaction, throwable ->
                if (throwable != null) {
                    Log.e("Error", throwable.toString())
                } else {
                    Log.d("Magic", ethSendTransaction.transactionHash)
                    mainTabActivity.toastAsync("Transaction complete: " + ethSendTransaction.transactionHash)
                }
            }

Could you please provide me with some guidance on how to resolve this issue? Any assistance you can provide would be greatly appreciated.

Hey @jigarfumakiya, have you pressed the public address button before calling the sendTransaction? It is a prerequisite as the public address is needed as part of the transaction object.
Lmk if the problem still persists

Hey @Ethella
I just wanted to let you know that I clicked the "Get Address" button, and the wallet address was generated successfully. However, when I tried to click "Send Transactions," nothing seemed to happen.
https://user-images.githubusercontent.com/103750692/232763783-d3fed8e8-dc65-4fd8-b8fb-c6fd74f37401.mp4

Hey @Ethella
I just wanted to let you know that I clicked the "Get Address" button, and the wallet address was generated successfully. However, when I tried to click "Send Transactions," nothing seemed to happen.
https://user-images.githubusercontent.com/11865669/232764587-0d49055f-68e1-4b0a-ac77-ba5f4b2e514f.mp4

Hey @Ethella are you guys able to reproduce the issue?

Hi @jigarfumakiya Thanks again for bringing this to our attention. We can reproduce the it and are looking into finding a solution to apply to our demo application.
In the meantime, could you confirm whether or not you see any logs being displayed in Logcat? If not, you might need to move this line above where the Magic object is being instantiated. Let us know what, if any, logs you see being provided.

Thanks, @Ariflo , I will make the changes and get back to you if it works.


Trouble with underscore in apiKey header name

Description
I cannot get the api-key authentication with the name "api_key" for the header.
Expected behaviour
Changing the name in securitySchemes.api_key from api-key to api_key should allow to use (only?) the same name in the header.
Actual behaviour
Using the plain example, I can authenticate both with api-key and with api_key header names; in my project, just api-key works (so only the one that I do not expect to).
Steps to reproduce
Starting from the example for a openapi3 api-key verification, I am trying to change the header name from X-Auth to api_key (for consistency with other non-connexion services). I went into the openapi.yaml file, and changed just this name.
In my file, I copy-pasted the relevant lines.
Additional info:
I am using the gevent server.
The error messages are
INFO:connexion.app:Listening on <IP_ADDRESS>:8081..
INFO:connexion.api.security:... No auth provided. Aborting with 401.

Output of the commands:

python --version: Python 3.8.5
pip show connexion | grep "^Version\:": Version: 2.7.0

I probably found the reason of this: as stated in https://www.gevent.org/whatsnew_1_2.html?highlight=underscore#compatibility, gevent does not allow headers with underscore.


Compression and encryption support

How about..

256-bit AES encryption of databases
snappy, bzip2, lz4 and/or zlib compression of databases

Compression & encryption can be added on top of Bolt by the user. The project's goal is to provide a simple, transactional database and adding additional features complicates the API.


Create a PowerShell script to "install" RAWeb into IIS and perform necessary configuration

I'm thinking an interactive PowerShell script should be included which would ask the user some questions and depending on responses, perform the following:

Install required IIS features
Copy the RAWeb files somewhere:

Into the default web site if desired
Or elsewhere and create a virtual directory

Configure IIS:

Convert RAWeb folder to an application
Configure auth on the auth folder if desired
Check if HTTPS is enabled and if not, offer to generate an appropriate self-signed certificate and enable

Note: I would ideally like this to cater to Win 10, 11, and Server. The PowerShell commands and Windows feature names are different between Windows 10/11 and Server, so the script will need to check and take this into account.

PowerShell script added to the root of the repo. I will close this issue, and any problems with the script should be reported as new issues.