Changelog for checkedint

$ make -C ../dlang.org -f posix.mak pending_changelog
make: Entering directory '/home/andrei/d/dlang.org'
This command will be available soon.
make: Leaving directory '/home/andrei/d/dlang.org'

@wilzbach

This command will be available soon.

-> https://github.com/dlang/dlang.org/pull/1549

@burner looks good?

@burner looks good?

As https://github.com/dlang/dlang.org/pull/1549 hasn't been merged yet and it's a bit hard to manually preview, here's a screenshot:
http://imgur.com/a/Ha6lj

LGTM

Auto-merge toggled on

thx @wilzbach

FWIW I didn't want to nag on this again as I thought it's easily seen in the picture. The changelog format is really, really simple (and equal to the behavior of git commit): the first line is the title, followed by an empty line and then the description (that's the reason why the title seems to be cut-off on the screenshot. It's not a bug!).
(I wanted to go with something more advanced like YAML, which would might have been better because it's more explicit ...)

Auto-merge toggled on

And another FWIW the auto-merge-squash is especially made for cases like this one where you don't want to push all commits for a simple change, but squash them into one commit instead ...

The changelog format is really, really simple (and equal to the behavior of git commit): the first line is the title, followed by an empty line and then the description (that's the reason why the title seems to be cut-off on the screenshot. It's not a bug!).

The changelog tool should enforce that there's a blank line after the title line. Or, alternatively, allow multiple lines for the title, until the first blank line.

Auto-merge toggled off

The changelog tool should enforce that there's a blank line after the title line.

Seems like we haven't been that consistent in the past either:
https://github.com/dlang/phobos/blob/master/changelog/std-utf-decodeBack.dd
(but the changelog tool ignored this violation softly)

Or, alternatively, allow multiple lines for the title, until the first blank line.

Well in case we really want to go in this direction: https://github.com/dlang/tools/pull/220

Auto-merge toggled off

@andralex: I fixed the changelog file manually (title in one line, no REF in the title) and force-pushed the PR, s.t. we can move forward with this.
While I was at it I also rebased the three commits into one.

@wilzbach sorry and thanks for fixing that - I missed the REF part. Thanks for using your powers for good!

The changelog tool should enforce that there's a blank line after the title line.
Seems like we haven't been that consistent in the past either:

-> Fixup & validator: https://github.com/dlang/phobos/pull/5199

@burner as I realized that some bits of the improved GH process might be new, I tried to summarize all changes that came to my mind<EMAIL_ADDRESS>I hope it's partially helpful.


Specify port 8888 when running netlify dev

- Do you want to request a feature or report a bug?
Bug
- What is the current behavior?
Logs display port 8080 instead of 8888
- If the current behavior is a bug, please provide the steps to reproduce.
Here's my terminal output:
~/code/ef/ethereum-org-website « git:(dev)
$ netlify dev
◈ Netlify Dev ◈
◈ Injected build setting env var:  CROWDIN_API_KEY
◈ Starting Netlify Dev with vuepress
Waiting for localhost:8080.
◈ Lambda server is listening on 34567
yarn run v1.19.1
$ vuepress dev docs
..wait Extracting site metadata...
tip Apply local theme at /Users/samrichards/code/ef/ethereum-org-website/docs/.vuepress/theme...
tip Apply theme local ...
tip Apply plugin container (i.e. "vuepress-plugin-container") ...
tip Apply plugin @vuepress/register-components (i.e. "@vuepress/plugin-register-components") ...
tip Apply plugin vuepress-plugin-anonymous-31d57d61 ...
tip Apply plugin @vuepress/active-header-links (i.e. "@vuepress/plugin-active-header-links") ...

● Client █████████████████████████ building (40%) 43/45 modules 2 active
 node_modules/punycode/punycode.js

● Client █████████████████████████ building (40%) 44/47 modules 3 active
 node_modules/webpack/buildin/module.js

ℹ ｢wds｣: Project is running at http://<IP_ADDRESS>:8080/
ℹ ｢wds｣: webpack output is served from /
ℹ ｢wds｣: Content not from webpack is served from /Users/samrichards/code/ef/ethereum-org-website/docs/.vuepress/public

✔ Client
  Compiled successfully in 4.31s

ℹ ｢wds｣: Project is running at http://<IP_ADDRESS>:8080/
ℹ ｢wds｣: webpack output is served from /
ℹ ｢wds｣: Content not from webpack is served from /Users/samrichards/code/ef/ethereum-org-website/docs/.vuepress/public
ℹ ｢wds｣: 404s will fallback to /index.html
success [19:21:00] Build 27830b finished in 4310 ms!
> VuePress dev server listening at http://localhost:8080/

✔ Client
  Compiled successfully in 179.04ms
success [19:21:01] Build b21035 finished in 180 ms! ( http://localhost:8080/ )

It mentions 8080 multiple times but not 8888 once.
- What is the expected behavior?
Can we update the logs to specify port 8888? This will prevent issues like
https://github.com/netlify/cli/issues/583
https://github.com/netlify/cli/issues/589
- Local Environment Information
Paste the results of netlify status --verbose here
 netlify status --verbose
──────────────────────┐
 Current Netlify User │
──────────────────────┘
Name:  Sam Richards
Teams:
  Sam Richards's team: Collaborator
  ethereum:            Collaborator

────────────────────┐
 Environment Info   │
────────────────────┘

  System:
    OS: macOS 10.15
    CPU: (8) x64 Intel(R) Core(TM) i7-4980HQ CPU @ 2.80GHz
  Binaries:
    Node: 10.13.0 - ~/.nvm/versions/node/v10.13.0/bin/node
    Yarn: 1.17.3 - /usr/local/bin/yarn
    npm: 6.9.0 - ~/.nvm/versions/node/v10.13.0/bin/npm
  Browsers:
    Chrome: 77.0.3865.120
    Safari: 13.0.2

────────────────────┐
 Netlify Site Info  │
────────────────────┘
Current site: ethereumorg
Netlify TOML: /Users/samrichards/code/ef/ethereum-org-website/netlify.toml
Admin URL:    https://app.netlify.com/sites/ethereumorg
Site URL:     https://ethereum.org

It seems like the output from Netlify Dev is being overwritten by VuePress CLI.

@samajammin Thanks for reporting this. We'll be looking into.

Thanks @raeesbhatti!


As an artist with loyal customers, I can see customer's repeated payment / commissions

... so that I can start a loyalty program to encourage their purchases.

(I think this is opencus)


Hightouch Git Sync support - Vendor API / Git Discussion

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/3059
Originally created by @tayloramurphy on 2021-11-15 15:15:11

https://hightouch.io/blog/announcing-git-sync-back-your-syncs-with-version-control/
I see a yml file and I think how can we support that in Meltano. Would be interesting to integrate with that and their API https://hightouch.io/docs/integrations/api/

View 1 previous comment from the original issue on GitLab


Automatically detect mime type

I found a little bug when sharing files, in SocialSharing.java you put this line:
// we're assuming an image, but this can be any filetype you like
String localImage = image;
sendIntent.setType("image/*");
But when i try to share an audio file with whatsapp i receive a message from whatsapp like this "The file is not an image" so i changed the code to:
sendIntent.setType("audio/*");
With this change whatsapp receive the audio with no problems. But if i try to share an image it says "The file is not an audio".
I think that would be nice if the plugin detect the mime type automatically.
Thanks.

I tried to share audio files via Whatsapp after editing this code line:
sendIntent.setType("image/*");

to
sendIntent.setType("audio/*");

as suggested by @neuberdesigns but I got a message saying "The file is not an image".
I found that after changing
if (!image.contains("data:image/")) {

to
if (!image.contains("data:audio/")) {

I was able to share audio files but then all files are send as audio files and it's not possible to share other types of files. It was enough for the app that am developing but it would be great to be able to share different types of files: images, audio... I think that is a common issue, for example, see #350

Related issues: #315,  #350

@jrevault do you have a working fork, with this change? Currently I'm working for Android. I changed the line tom send audio in SocialSharing.java.
Do I need to rebuild the plugin?
I call cordova/ionic run android, but seems changes has no effect.

Wow, it's been a long time since I did this change :)
You can find what I changed here :
https://github.com/jrevault/SocialSharing-PhoneGap-Plugin/commit/fe71f7571b06d259f3342cc13f641ea7ea4e4c64#diff-f613706f2334b3dac367e28727fe4060
And yes I think you have to rebuild the plugin...

@jrevault Did you ever send me a PR? Seems a useful addition. I wanted to make it a bit more clean and have you pass in separate params for type and filename but in the meanwhile this looks like a useful workaround.

No sorry I never did.
Actually the code I wrote is generic enough to use the original file name, you should'nt have any change to do...
I just send a PR...

Will work with any share method (whatsapp, messenger), or only with shareViaEmail?

Well it shouldn't be exclusive with shareViaEmail, but I haven't test with whatsapp or messenger.
And as I rewrote my app in full Android, I'm not able to test it anymore....

@EddyVerbruggen, @jrevault
The mime type format suggested by @jrevault works great in Android. But the same causes app crash in iOS. What ia the equivalent change that I need to make in order to have it worked in iOS?
Would be of great help if I can get a solution for this. Thanks.

@EddyVerbruggen
I'm facing the same problem. All my files are shared with fixed file name when using the mime type format in iOS. It would be great to have something like Android. Anyway, is their a workaround to custom file names when sharing in iOS.
Thanks'

I think this issue is resolved, isn't it?
I've looked at the code and in case you send a base64 file you can add the relevant mime type with it...


WebSocket disconnected, error: The handshake request failed with status 101 Web Socket Protocol Handshake

extension HTTPStatus {
  public static func == (lhs: HTTPStatus, rhs: HTTPStatus) -> Bool {
    return lhs.code == rhs.code && lhs.phrase == rhs.phrase
  }
}

static let switchingProtocols = HTTPStatus(code: 101, phrase: "Switching Protocols")

But some other Websocket Server (like Java-WebSocket) returned
code:101,  phrase:"Web Socket Protocol Handshake"
So the Telegraph client can not connect to this server.
The handshake request failed with status 101 Web Socket Protocol Handshake

That error would indicate that the Telegraph client didn't accept the WebSocket server's handshake. That might be caused by an invalid header or otherwise invalid HTTPResponse.
Do you have a small example app for me to replicate the issue?
Or a quick way that I can run the Java-WebSocket server myself?

That error would indicate that the Telegraph client didn't accept the WebSocket server's handshake. That might be caused by an invalid header or otherwise invalid HTTPResponse.
Do you have a small example app for me to replicate the issue?
Or a quick way that I can run the Java-WebSocket server myself?

I replaced:
extension HTTPStatus {
public static func == (lhs: HTTPStatus, rhs: HTTPStatus) -> Bool {
return lhs.code == rhs.code && lhs.phrase == rhs.phrase
}
}
with:
extension HTTPStatus {
public static func == (lhs: HTTPStatus, rhs: HTTPStatus) -> Bool {
return lhs.code == rhs.code
}
}
works well  :-)

Ah that is interesting, the handshake was rejected because the HTTPStatus phrases are different: "Switching Protocols" != "Web Socket Protocol Handshake"
A few minutes ago I've pushed a commit that improves the Equatable implementation of HTTPStatus. Now by default two HTTPStatus values are compared by code unless they are created with strict: true.
Can you try the master branch for me in your project?

@henryhenryhenry3 Did the latest version on master branch resolve your issue?
If so, I'll publish the version.


closes 11646 to fix volume path validations in server side

Closes https://github.com/docker/docker/issues/11646
We added volume validation in server side when creating a container in order to keep consistent to users' expectation when sending request to server remotely.
ZJU community pair: resouer & zhouyuzhe88

Can you please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "11646-fix-volume-path-validations" git@github.com:ZJU-SEL/docker.git somewhere
$ cd somewhere
$ git rebase -i HEAD~2
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

This will update the existing PR, so you do not need to open a new one.

I  can confirm both two authors have signed off.@GordonTheTurtle

@resouer Indeed.
Also would be really good if we can move these validations a bit higher int he stack, before a container is ever created.

@cpuguy83  Code squashed and CI fixed. Please review.
ZJU community pair: yuzhe zhou & resouer

@cpuguy83 This is your kingdom :-) Are you +1 on design, should we move to code review?

Oh yes, sorry, didn't realize this wasn't in code review.

@cpuguy83  Code updated, please review :smile:

Can you add a call to the validation in daemon/start.go just after runconfig.ContainerHostConfigFromJob(job) is called?

@cpuguy83 Code updated, please review
cc:@resouer

Still need to make sure this gets run for both create and start and squash to 1 commit.
Let me know if you need any help! Thanks!

@cpuguy83 Code updated, please review
cc:@resouer

Also still need to squash these commits down: git rebase -i head ~4, and then change pick to squash for the bottom 3 commits, can use just one commit message since we're only really adding one thing.

@cpuguy83  Sorry, I am a little confused here... could you please give a code sample about what you mean?

@cpuguy83 Code updated, please review
ping @resouer

LGTM

@cpuguy83  CI fails again because auto-merge failed, I think we need re-base?

Hmm, looks like there the build escapes test needs to be updated since it is trying to create a volume at a non-absolute path.

@cpuguy83 We have fixed the tests, please ship it!

LGTM again

@resouer @zhouyuzhe88  looks like this needs a rebase

@thaJeztah Rebase done! :smile:

needs rebase so sorry :(

@jfrazelle rebase done ... please ship it ...

@jfrazelle rebase done ... please ship it ...

@crosbymichael does #13025 address this issue?

@calavera it's probably missing a few cases for some of the checks

so, what's the next step? @calavera @crosbymichael

ping @jfrazelle @cpuguy83

@resouer sorry, looks like this needs a rebase (again) :'(
If you can rebase, I'll pester some maintainers, I think this is taking too long.
Thanks for being patient!

There is an ongoing effort that's changing most of the volumes behavior as they know them now. I'm afraid this code will be obsolete as soon as it lands in master and merging it will only complicate things.
I really appreciate that you spent some time on this, but I think we should close this PR for now.

fine then

fine then, @calavera will this fix still needed in up coming volume code? so at least we can keep a eye open on that.

I'm not completely sure, I need to double check. There are too many changes around this code rn, sorry. :pensive:

@calavera I think I just read that the new volume features will be put behind an "experimental" flag, also, it's not "in" yet. Given its a small amount of changes (mostly added tests), it looks simple to "rip" this out again when the volume-changes are merged.
Would the tests still be useful when the new volumes-code is implemented?

Would the tests still be useful when the new volumes-code is implemented?

The validations are different, for instance data:/data is valid with the new volumes in certain cases.

Given its a small amount of changes (mostly added tests), it looks simple to "rip" this out again when the volume-changes are merged.

The new code needs to be ready this week, afaik. So, this will be rewritten in 3 days tops. I'd rather not rewrite any code that's not completely necessary in master rn.

@resouer the volumes refactor is already in master. I think this still can be relevant if you want to finish it. The only validation change would be that data:/data is now valid, since the first part can be the name of a volume.

@calavera Thanks for your remind, I'll moving on.

@resouer Thanks for the patch and for your patience! Can you please rebase?

@resouer sorry could you please rebase? :(

Closing this PR until it moves forward. Please, feel free to reopen it when there is any update in the code.

@calavera  @runcom @icecrime  sorry for a late response as I did not notice the comments here, I'll open a new RP to solve this

@resouer if possible, you can update this PR, be sure to "ping" a maintainer to reopen this PR before pushing, otherwise GitHub will not update the PR

ping @resouer just checking; are you working on this (or a replacement PR)?

@thaJeztah  sorry, im hanging up on other stuff ... so not progress yet

@resouer alright, just checking :+1:


Improve text content argument handling

Check if your initialiser handles positional arguments before assuming the first positional argument should be coerced into a block of text content.

IMHO this is too much magic (too hard to understand the behavior as it breaks encapsulation pretty drastically) and of course it's quite slow.
Also saw the block.binding.receiver above and that's also pretty slow and too magic IMHO.
If it's for fun, please go ahead, but if it's meant to be used project I would advise against getting any caller information and rather make things more explicit and less magic.

Also saw the block.binding.receiver above and that's also pretty slow and too magic IMHO.

The project lives or dies on this, as far as I can tell. But Phlex is already about 3x faster than ActionView and 32% faster than ViewComponent.

Did you measure the effect of this PR on perf? Would be interesting.
Re Proc#binding there are ideas floating around to remove it, because it causes unnecessary overhead for Ruby VMs.
But maybe it's not too bad perf-wise in this case.
From the code it seems you are using it to access the caller's self, right?

From the code it seems you are using it to access the caller's self, right?

Yes, that's right. We need a to-procable object that lets us access the caller.

This PR seems to have no effect on our internal benchmark but it does negatively affect the the view-layer-benchmarks mentioned above.
               phlex:     7047.8 i/s
      view_component:     5326.9 i/s - 1.32x  (± 0.00) slower
               cells:     3444.0 i/s - 2.05x  (± 0.00) slower
            partials:     2458.9 i/s - 2.87x  (± 0.00) slower
            dry_view:      345.9 i/s - 20.37x  (± 0.00) slower

After
               phlex:     6136.2 i/s
      view_component:     5379.7 i/s - 1.14x  (± 0.00) slower
               cells:     3494.1 i/s - 1.76x  (± 0.00) slower
            partials:     2468.5 i/s - 2.49x  (± 0.00) slower
            dry_view:      343.4 i/s - 17.87x  (± 0.00) slower

If checking whether initialize takes positional arguments is slow, perhaps we could just memoize that on the class.

IMHO this is too much magic (too hard to understand the behavior as it breaks encapsulation pretty drastically) and of course it's quite slow.

Let me explain the intended behaviour here.
If I define a component that takes block contents
class CardComponent
  def template(&)
    div class: "rounded drop-shadow p-5", &
  end
end

I should be able to pass that component either a block:
component(CardComponent) { h1 "Hello world!" }

Or a string:
component CardComponent, "Hello world!"

But if I define a component that explicitly takes a positional argument
class NavItem
  def initialize(label, to:)
    @label = label
    @to = to
  end

  def template
    li { a @label, to: @to }
  end
end

Then passing a positional argument shouldn't be received as a block but rather delegated directly to the original initialiser.
component NavItem, "Home", "/"

Isn't it good enough to require component(CardComponent) { "Hello world!" } instead of component CardComponent, "Hello world!"? The block/Proc will be needed anyway, and then mixing initialize and template arguments is no longer a problem.

The called_from = caller_locations(1,1)[0].label.to_sym in Overrides#template is another slow caller info access.

We could get rid of that override by renaming the method to something that doesn't conflict with <template> tags, or having a special case method for <template> tags.
Back to the issue of this PR, we could just forget the implicit first-argument content feature or only allow keyword arguments from component initialisers. Either is acceptable IMO though not ideal.
I am concerned by this though.

Re Proc#binding there are ideas floating around to remove it, because it causes unnecessary overhead for Ruby VMs.

We need a to-procable that yields to the first caller and the only I can see to do that is to use our own block type that holds a reference to the context (self) from the first use.

We need a to-procable that yields to the first caller and the only I can see to do that is to use our own block type that holds a reference to the context (self) from the first use.

So you need the caller self but don't want to pass it explicitly, and just self is not what you want, right?
Potentially you could capture the caller self differently, e.g., with an explicit stack or save/restore pattern.
Maybe there should be Proc#receiver or so.
Why Proc#binding is problematic for optimization is:
def foo
  -> a, b { a + b }
end

Even such a lambda needs to capture the foo frame, because Proc#binding exposes it.
Without Proc#binding, and with a way to check at parse time for Kernel#binding and *eval, we wouldn't need to capture the foo frame here for the lambda. And even if the block captured variables we could just have a box to be able to write those captured variables but not need the full frame.

Yes, the methods that accept blocks check if the block is already a Phlex::Block by checking the binding.receiver. If not a Phlex::Block, they create a Phlex::Block which stores the original block and self.
if block_given? && !block.binding.receiver.is_a?(Phlex::Block)
  block = Phlex::Block.new(self, &block)
end

Phlex blocks respond to to_proc so can be coerced with & and passed down many times as an anonymous block. When the block is yielded, that hits Phlex::Block#call which executes the original captured block against the original captured context.
def call(*args, **kwargs)
  @context.instance_exec(*args, **kwargs, &@block)
end

Proc#receiver would be sufficient for our use-case. Or perhaps a native way to “instance_yield” a block.


Bump pion/dtls

Add fuzzing to pion/dtls

Codecov Report

Merging #687 into master will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #687      +/-   ##
==========================================
+ Coverage   77.58%   77.64%   +0.05%
==========================================
  Files          57       57
  Lines        3632     3632
==========================================
+ Hits         2818     2820       +2
+ Misses        574      573       -1
+ Partials      240      239       -1

Impacted Files
Coverage Δ

sctptransport.go
72.72% <0%> (+1.39%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f257f8a...0e3fd0e. Read the comment docs.


"Field 'type' doesn't have a default value" when saving a model

First: Making sure I'm using the right package
I'm only using the Eloquent ORM (not the whole Laravel framework), and for some reason, I couldn't get your demo work on my project.
Before posting any of my failing code (nothing fancy, just a simple test), I want to know if this package supports the independent Eloquent ORM provided in illuminate/database.
So, is this package meant to be used with the whole Laravel framework or I might have missed something in my demo?
Second: Now, here's my attempt
use Nanigans\SingleTableInheritance\SingleTableInheritanceTrait;

class A extends Model
{
    use SingleTableInheritanceTrait;
    protected $table = "a";
    protected static $singleTableTypeField = 'type';
    protected static $singleTableSubclasses = [B::class];
}
class B extends A
{
    protected static $singleTableType = 'b';
}
// In some other file
$b = new B(); // some inits as well
$b->save(); // This line is throwing an exception

I'm getting this error:

Field 'type' doesn't have a default value

My workaround was to overload the default constructor of the child classes and make sure the appropriate type is set at construct time.
I'm not sure this if this is not breaking somewhere else since I haven't tested it in advanced scenarios.
Use it with that in mind.

i have used this with the illuminate/database with no problem

This seems to be a completely vanilla use case that there are lots of unit tests around that prove it works and only rely on Illuminate. Without a failing test case its hard to reproduce.


[OSF-8099] API citations show wrong names

Purpose
For some unregistered contributors, the API was showing the wrong name.  When there is a new unregistered contributor being added to a project, the API will automatically check if the email being used is already in use by another contributor.  If it is, it'll add the new unregistered contributor's name to a new field under the contributor that already exists.
For citations it will get the first and last name fields of the contributor.  If the contributor is an unregistered contributor with an email that already exists, this can be an issue if the names aren't exactly the same.
Changes
The changes include adding a conditional to the API's logic when making citations.  If the user isn't registered, it will get the unregistered_contributor field instead of the first/last name fields.
For example, the name 'Pasquale Anselmi' in the contributor list shows up correctly.

But in the citation it only shows up as 'P.'

The reason why it wasn't showing up correctly is because it was using the name of the previously entered in contributor name.
In the test example after the changes, the unregistered user 'Pasquale Anselmi' was created using an email that's also being used by another test user:

And the citations show up correctly:

Ticket
https://openscience.atlassian.net/browse/OSF-8099
Notes to QA
The process for testing will be pretty much the same for https://github.com/CenterForOpenScience/ember-preprints/pull/373, but instead of checking the meta tags you'll just be checking the citations:
1.) Create a new preprint
2.) Add an unregistered contributor
3.) Save the preprint and view it.  Make sure that the meta tags are showing the right information for the contributors currently added
4.) Edit the preprint, this time removing the old unregistered contributor and adding a new unregistered contributor with the same email
5.) Save the changes and view the preprint.  Check the contributor list and the names inside the citations to make sure they reflect the current contributors

@baylee-d Could you fix the conflicts on this, please?

@baylee-d One of the tests is failing and seems like it is related to this PR.


make tenant list not tab focusable

This PR fixes #14170
this is a temporary fix for the accessibility issue by making the tenant list not keyboard focusable and opened an issue for @cssuh to understand what do we want to do with the tenant list: https://github.com/microsoft/azuredatastudio/issues/14808

Pull Request Test Coverage Report for Build 669438151

0 of 4 (0.0%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.006%) to 43.387%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sql/workbench/services/accountManagement/browser/accountDialog.ts
0
4
0.0%

Files with Coverage Reduction
New Missed Lines
%

extensions/import/src/wizard/pages/fileConfigPage.ts
1
73.46%

Totals

Change from base Build 669137874:
0.006%

Covered Lines:
25456

Relevant Lines:
53521

💛  - Coveralls


how to get the count of matching nodes for a search?

Dear, i'm really newbie, how to get the count of matching nodes for a search? Thanks!
Thanks & Regards,
Martin.

oh i googled out...
var count = $(".jstree-container-ul li .jstree-search").length;


Plugin is not working with pixel streaming plugin enabled

Game will crash  when it is run when pixel streaming and plugin are enabled in the game.
I have tested it in 3 games. It is enough to have the plugin enabled in the game and run the game with pixel streaming
To reproduce:
Take any game.
Add Simulation plugin as per documentation here.
Enable pixel streaming in the game.
Package the game and run with -PixelStreaming=localhost -PixelStreaming=8888 command line parameters. (Acturally you may try without).
Just keep it running. Within 2-3 minutes the game will crash. Always the same error. Something to do with the GC: Encountered 1 object(s) breaking Disregard for GC assumptions. Please check log for details.
Note; In order to run with pixel streaming you have to run packaged game or run it from the Visual Studio. Pixel streaming is disabled in the editor. Running from visual studio will show more information. All I could guess is, that there is some conflict involving timers and GC.

As a quick and dirty hack, you can try commenting out the UPROPERTY(Transient) ln 33 in UEGeoCoordinates/SimulationPlugin/Source/SimulationModule/Public/SimulationSettings.h
For the next version of this plugin, we changed the global approach to define the referencing settings, and you should not have this issue anymore.

I am also experiencing my game crashing with log message citing "Something to do with the GC: Encountered 1 object(s) breaking Disregard for GC assumptions. Please check log for details."  (I am not using anything related to pixel streaming). I will reply if the suggestion above fixes my issue


Close SMTP connections properly.

Expected behavior
SMTP connections should be properly closed when they are created in an unusable state.
Actual behavior
I found an issue during SMTP testing. When opening a connection, if authentication fails for some reason, we don't close the connection during clean-up.
I think this is unlikely to cause an issue, but it's possible that when setting up and testing a connection we'll be creating lots of sockets and not closing them.
I have a potential fix (and set of tests for this).
Steps to reproduce

Run an SMTP server that doesn't support the requested AUTH method.
Get K-9 to connect to it.
K-9 will send EHLO, get back lack of capability and not close the connection.

See #1649 for a test environment
Environment
K-9 Mail version: master
Android version: N/A
Account type (IMAP, POP3, WebDAV/Exchange): SMTP

Ever got to commit your potential fix? :)

Good question. I'll check!


mongodb id map and gen for prisma issue

@Bekacru
[{
"resource": "/B:/with-better-auth/prisma/schema.prisma",
"owner": "generated_diagnostic_collection_name#0",
"severity": 8,
"message": "Error validating field user in model Session: The relation field user on model Session is missing an opposite relation field on the model User. Either run prisma format or add it manually.",
"source": "Prisma",
"startLineNumber": 35,
"startColumn": 3,
"endLineNumber": 36,
"endColumn": 1
},{
"resource": "/B:/with-better-auth/prisma/schema.prisma",
"owner": "generated_diagnostic_collection_name#0",
"severity": 8,
"message": "Error validating field user in model Account: The relation field user on model Account is missing an opposite relation field on the model User. Either run prisma format or add it manually.",
"source": "Prisma",
"startLineNumber": 45,
"startColumn": 3,
"endLineNumber": 46,
"endColumn": 1
}]
"better-auth": "^0.5.2-beta.2",
"@better-auth/cli": "^0.5.2-beta.2",

Originally posted by @csyedbilal in https://github.com/better-auth/better-auth/issues/215#issuecomment-2423842942

you just need to save it and it'll get formatted properly.

if you have save on format

I don't think this issue is related to Better Auth. Can you explain why you think this is an issue with Better Auth rather than a Prisma issue?


index is undefined in renderItem calls until the 11th item

index is undefined in renderItem calls until the 11th item.
Here is a snack that reproduces the issue.
https://snack.expo.io/S176xY7ZU

I also had a similar issue. I fixed my use case by adding this to my fork:
https://github.com/curiousdustin/react-native-draggable-flatlist/commit/8be6e0012276e784b11ddc26919872316e35f2ac
I think there are cases where the data prop can change without triggering a re-render of all the items. So in my case, data was starting out as and empty array [], and later changing to an array of items. In this case, keyToIndex was not getting set until AFTER the new items had rendered the first time.
Also related to #104

@computerjazz , has this been addressed by any of the recent changes?
Does my hacky fix lead you to a better idea to safeguard this?

@computerjazz, sorry to keep buggin' about this one, but it seems to still be happening.
As mentioned above, I have a fix, but I feel like there is probably a better way.

Added a fallback index setter in 2.3.2, let me know if this solves the issue: https://github.com/computerjazz/react-native-draggable-flatlist/blob/master/src/index.tsx#L793
I'm hesitant to re-render all rows when index changes, as that could cause perf issues if I drag an item from the top to the bottom of a list. Because of this, index can't be 100% trusted to be up-to-date, which is a bummer. I'm considering adding a getIndex() method to renderItem instead, so when you need the index, you can manually get it, but a changing index won't be the trigger of a re-render. Thoughts?

Also, have either of you noticed that Snacks are broken recently? I have to use expo 34 or else I get an error on reanimated import...

Hi, I haven't tried the patch yet. To me it seems to make sense to rerender all visible rows when the drag completes, because that is what FlatList would do if a row was inserted or removed. Thank you

I also can't try this update until next month.
And, I don't regularly use Snacks, sorry, no info there either...

fixed in https://github.com/computerjazz/react-native-draggable-flatlist/releases/tag/v2.3.2
Please open a new issue if still seeing this behavior

Use getIndex()
Like
const renderItem = ({
    item,
    getIndex,
    drag,
    isActive,
  }: RenderItemParams<>) => {
console.log("index",getIndex())
return(
.....
)
}


Continued need for use of tostring() in codebase?

In the pyhf test logs for tests/test_import.py we're seeing a lot of (harmless) warnings of
/opt/hostedtoolcache/Python/3.8.3/x64/lib/python3.8/site-packages/uproot/source/cursor.py:73: DeprecationWarning: tostring() is deprecated. Use tobytes() instead.
return source.data(start, stop).tostring()

where the offending function is
https://github.com/scikit-hep/uproot/blob/634667fad826ec6c86e2df442887b1024c2cfee8/uproot/source/cursor.py#L63-L73
Is there an explicit need for this still in the codebase? If no, would a PR to switch it over be of interest, or should any contributions be left for uproot4?
cc @lukasheinrich @kratsg

Should we just wait on a switch to uproot4 perhaps?

Actually, this is a wake-up call to me that ndarray.tostring is deprecated—I thought I was using a recent version (conda-forge), but I haven't been seeing these warnings. I'll be sure to fix it in Uproot 4. (Its name is clearly a relic of Python 2.)
@kratsg, you're right that that's where development should focus, but I also didn't know that this was an issue, and can not take care of it. Fortunately, these calls are more centralized now because Uproot 4 converts to strings early.
In the other hand, it's also simple enough that it can be fixed in both versions. I'll be using a hasattr to determine whether the version of ndarray had a tobytes attribute before calling it because some allowed versions of NumPy do not. (I'll have to check mine, which is running under Python 3.7, I think.)

Fortunately, these calls are more centralized now because Uproot 4 converts to strings early.

This all sounds good. :+1:

In the other hand, it's also simple enough that it can be fixed in both versions.

If you decide to go this route and would like help on anything, let us know.

I've verified that this is done in all cases. (There's a switch for tobytes vs tostring to support old NumPys, but it happens in a centralized place, so it doesn't add much complexity.)

I've verified that this is done in all cases.

@jpivarski, just to clarify this is now done in uproot4, yes?

That is correct. I closed it because it's done in the new codebase. (The old codebase can have things like this because it's about maintaining functionality that already works for users—it might prevent them from updating to the latest NumPy with the old Uproot, but if they can update NumPy, they can update Uproot.)


ANGLE gives hard-to-understand error about an invalid subscript

When applied to this shader:
https://github.com/mc-imperial/shader-compiler-bugs/blob/master/angle/front-end/invalid-subscript/shader.frag
ANGLE in Google Chrome Version 57.0.2987.110 (64-bit) gives an error saying that there is an invalid subscript:
"
Failed to link shader program.
C:\fakepath(26,1-72): warning X3206: 'clamp': implicit truncation of vector type
C:\fakepath(26,1-74): error X3018: invalid subscript 'z'
Warning: D3D shader compilation failed with default flags. (ps_5_0)
Retrying with skip validation
C:\fakepath(26,1-72): warning X3206: 'clamp': implicit truncation of vector type
C:\fakepath(26,1-74): error X3018: invalid subscript 'z'
Warning: D3D shader compilation failed with skip validation flags. (ps_5_0)
Retrying with skip optimization
C:\fakepath(26,1-72): warning X3206: 'clamp': implicit truncation of vector type
C:\fakepath(26,1-74): error X3018: invalid subscript 'z'
Warning: D3D shader compilation failed with skip optimization flags. (ps_5_0)
Failed to create D3D shaders.
"
The shader is accepted by the Khronos glslangValidator tool, and by Intel's OpenGL drivers.
It might be that an invocation of "clamp" with arguments of types vec3, float and float should actually be rejected.  But if that's the case then it would be better for this to happen at the GLSL level, rather than via an error at the Direct3D level (e.g., it is confusing that the subscript referred to is 'z', when in the original shader 'p' is used).

Reported to ANGLE: https://bugs.chromium.org/p/angleproject/issues/detail?id=1947


Visual design: options to reduce number of arrowheads; borderless boxes with fills?

I know. You offer people an SVG-based solution to rendering syntax diagrams that is far superior to the character-based—in some contexts, "ASCII art"—solution they've been complaining about for years, and... they start complaining! Unbelievable, right?!
Sincere thanks to you and Deborah Pickett.
Some subjective nits about the visual design:

There are too many arrowheads. I think many of the arrowheads are redundant; I think people get the general idea that the default flow is left-to-right. I would like an option that reduced the number of arrowheads to a level similar to that in the previous solution: line start and end, repeat (backwards) arrows.
The box outlines complicate the overall look of the diagrams. While I understand that the box outlines mean that the diagrams can be rendered in black and white, I think that these outlines make the diagrams appear unnecessarily complicated. Too many lines. The diagrams would look simpler if those outlines were replaced by a light fill. I confess I haven't yet had a chance to play with these plugins myself; so perhaps this is simply a case of adjusting the CSS for the corresponding SVG elements?

I'm being very careful about how I word this (as I mentioned in an issue I opened earlier, I develop IBM-brand product documentation, but I don't have direct access to internal IBM forums): I would like to see these SVG syntax diagrams in product documentation in IBM Knowledge Center.
I'm very likely not using the correct search arguments, but so far, I've only found a few examples in KC that look like they were created using this tooling; and these are bitmaps, not SVG:
https://www.ibm.com/support/knowledgecenter/en/SSEPCD_10.1.0/com.ibm.ondemand.administeringmp.doc/doddo006.htm
I was hoping to see some examples in SVG, set in IBM Plex.
Still being careful: why are these diagrams not yet widespread (and presented as SVG) in IBM Knowledge Center? Is there a timeline for deploying this functionality in the corresponding authoring toolchain? (It might be there already, and I just don't know about it.)

Hi @robander,
A few days ago I sent an email to what I think is your address (I won't cite it here!) expanding on this issue, now that I'm able to create these diagrams for myself via an internal IBM system. That email refers to internal IBM terms, which is one reason (but not the only reason) I didn't simply add another comment here.
Did you get that email? Yes/no is all I'm looking for. I wasn't expecting a fulsome reply so soon. I just want to know whether you got it.

Hi - yes, I have the email.
I know you are using these through IBM channels and the best way to handle requests for updates is really to go through your IBM contacts. You may be aware that there has been a lot of activity with diagrams lately, and this version is missing a number of fixes that were recently shipped in our internal version. Other updates are in progress but not yet complete.
I fully intend to catch this code up but at the moment there is simply too much activity with that internal code, and I don't have the time to do dual maintenance by managing + testing updates in both repositories at the same time. Once that internal code has settled down, I'll ensure those changes make their way into this public repository (after they are tested with the base DITA-OT / minus all of the other related plugins we're using internally).

@robander,
It's been 5 days since my previous comment, and I've not heard from you via email, so I've decided to post an updated version of that email here; updated, because I've done more research and experimentation. I've noticed that this repo already refers to DCS—an internal IBM system—so I'm less concerned than I was about mentioning that...
Background to this comment
I’ve started using DCS to format the DITA source of IBM product documentation to HTML and PDF. (I do not yet have the DCS client. I am submitting DITA source to DCS servers.)
I'm more interested in providing suggestions for the formatting of the SVG syntax diagrams in DCS than in DITA OT. That's slightly problematic for me, because I do not know how the code in this public repo is related to the code that DCS uses to format SVG syntax diagrams. I suspect that this repo is a backlevel version of the code used by DCS; for example, I see some differences in the formatting of composite group elements (I need to do more research to clarify this point). Still, the output appears to be close enough to suggest that the code is closely related, and anyway my suggestions apply equally to the output of DCS and this public code.
Again: sincere, heartfelt thanks to the developers of these SVG syntax diagrams for replacing the character-based diagrams that have blighted web-based IBM product documentation for so many years (today, in IBM Knowledge Center). Those character-based diagrams are an eyesore, mainly because they don’t use proper box-drawing characters. That makes them ugly and difficult to read. The new SVG syntax diagrams are more attractive and more readable than those old diagrams in KC.
However, the new SVG syntax diagrams do not represent such a big improvement on syntax diagrams in existing/old PDFs, which do use proper box-drawing characters. Compared to those old diagrams in PDFs, the new diagrams are too busy. Too many lines. Too many arrowheads.
Summary of suggestions
I suggest the following changes:

Remove the round-cornered borders around each item (this differs from my initial thought, which was to replace the black borders with a light-colored fill)
Reduce the number of arrowheads: for example, only at the beginning and end of each row, and for repeating items
Revert the alignment of stacked choices from centered to left
Use the IBM Plex font (Mono? Sans? I’d be interested in other opinions on the use of proportional versus non-proportional text in syntax diagrams)

Details
Too many lines
The boxes (round-cornered borders) around each item unnecessarily complicate the diagrams. The boxes compete for attention with both the railroad and the text. All are rendered in black. This makes the diagrams more difficult to read. It takes more effort to interpret the diagrams; more effort to distinguish between these three types of black strokes. (Here, I’m using the term “stroke” colloquially; I understand that the text is filled.) The diagrams would appear simpler, and be easier to read, without those boxes.
You might argue: these boxes demarcate the text from the railroad. My response: you don't need the additional complication of boxes to do that. A combination of white space and different colors (or, if rendered by a black-and-white printer, different shades) are a better solution. I like the opportunity that SVG presents to relatively easily use different colors to distinguish the purpose of shapes (see the examples at the end).
Too many arrowheads
Many of the arrowheads are redundant. They become noise. I think people get the general idea that the default flow is left-to-right. I would like the number of arrowheads reduced to a level similar to that in the previous solution (pre-DCS): row start and end, repeat (backwards) arrows.
Font: why not IBM Plex?
In DCS-generated PDF, I notice that the new diagrams use the Helvetica Condensed font for keywords, and Helvetica for variables; in HTML, (first choice) Arial. Why not IBM Plex?
Strange spacing in text
Items (keywords, separators, variables, etc.) in compact groups sometimes have extraneous spaces between them. I suspect this is caused by the SVG textLength attribute and associated lengthAdjust attribute, resulting in the space between items being stretched. The visual effect is unsettlingly inconsistent.
Center-alignment of stacked choices reduces readability
In IDWB-generated diagrams, stacked choices are left-aligned. You can scan vertically down a stack of choices and quickly spot differences. For example, different leading keywords; or, if the leading keyword is the same for multiple choices, this left alignment means that you can quickly see subsequent differences. The center alignment used by the new diagrams makes stacked choices less readable; the centering forces you to scan the choices in a zigzag fashion.
Nit: why draw the outline rectangles on top of the text?
SVG renders shapes in document order (there’s no z-order in SVG 1.1). Why do the new diagrams draw the rectangles for the item borders after the corresponding text? That is: why draw the rectangles on top of the text? The effect is that, if you change the rect fill property, that fill paints over the "enclosed" text. Yes, you can work around this by setting a fill opacity, but that’s a kludge.
Examples
With apologies, I chose an example syntax diagram that doesn’t include repeating items.
Old: character graphics set in BookMaster
Captured from a "pre-DCS" PDF; reproduced here to illustrate the generally simpler appearance of these "old" diagrams compared to the new SVG syntax diagrams:

New: SVG syntax diagram
Too busy. All those boxes! All those arrowheads!

Example with some of my suggested changes
No boxes; fewer arrowheads; railroad in a different color (a lighter shade than the text).

Suggestions not in this example, or not completely realized:

The diagram above still contains a few more arrowheads than I'd like. Specifically, the right-facing arrowheads in the middle of some of the rows. I could have manually removed these, but I've left them in more-or-less as a reminder to myself that I've yet to work out how to remove them programmatically.
Choices are still center-aligned; I'd like them left-aligned (as in pre-DCS/pre-SVG diagrams). Again, I haven't worked out how to do this programmatically.

Here's a brief example with a repeating separator:

(Again, I don't want that right-facing arrowhead in the middle of this diagram.)
Discarded experiment: lightly filled boxes
I prefer no boxes, but in case anyone is interested in seeing this:

How I created these "suggestion" example diagrams
I edited the JavaScript in dita-ot-2.5.4\plugins\com.moldflow.dita.syntaxdiagram2svg\js and commented-out most of the calls to generate arrowheads (syntaxdiagram_arrowHead()).
I edited the CSS, either in the generated SVG or in dita-ot-2.5.4\plugins\com.moldflow.dita.syntaxdiagram2svg\xsl\syntaxdiagram2svg.xsl:
.arrow { fill: none; stroke: #8080C0; }
.arrowhead { stroke: #8080C0; fill: #8080C0; }
rect { fill: none; stroke: none; }

I'm a long way off a Git pull request. I'm happy to use my locally tweaked code to generate my own SVGs, but for wider consumption, I'd prefer to implement these suggestions via parameters that can be specified by the user. And that's currently beyond me; I'm not yet familiar enough with the code to do that. Furthermore, I'd like to better understand the relationship between this public repo and the code used by DCS.
Further thoughts
I am strongly tempted, for the product documentation for which I am responsible, to pre-generate SVG syntax diagrams with my suggested tweaks, and to use those SVGs in HTML and PDF output in preference to the "default" SVG generated by DCS. I feel that strongly about the current default look'n'feel. It's just too busy; less readable than the diagrams in the old/existing PDFs.
If the class attribute values for arrowheads in the SVG output were more granular, then I could apply most of my suggestions via CSS.
Request for other opinions
It wouldn't take much to fix what I characterize as "issues"; to apply my suggestions. But I understand that my lone voice—especially, from outside IBM—carries little to no weight.
Does anyone else have any opinion about the current look'n'feel of these SVG syntax diagrams?
I'd be particularly interested in specific arguments:

In favor of the current look'n'feel (that I've described as "too busy")
Against my suggestions

@robander,
I was working on my previous comment for a while, so I didn't see your "yes, I have the email" comment until just now. Thanks for responding!
I'm happy to have added that comment here, for various reasons: it's more up-to-date than my email to you; it's relevant to this public code; I'd like others to be able to judge my suggestions; and, after seeing those existing references to DCS in this repo, I was less concerned about mentioning it here.
Re:

I know you are using these through IBM channels and the best way to handle requests for updates is really to go through your IBM contacts.

I'm grateful for your advice; however, following that advice involves issues that I think are best discussed outside of this public forum. I'll follow up with you via email.

Hi @GrahamHannington, @robander,
I'm thrilled to see that you've been able to extract my syntax diagram code out of DITA-OT 1.3 and breathe new life into it.  I haven't touched this code for ten years but I do remember some of it hazily so feel free to grill me about it.
With respect to the boxes around elements: it's just CSS. If I recall, I went for boxes because they helped to put predictable bounding-boxes around each element, crucial for the JavaScript code to resize and move the elements at render time.  If you remove the boxes (and fill) then you might find weirdness with the placement of standalone commas or other small punctuation-only elements.  IIRC it depended on the platform that the SVG was rendered on.  Boxes made the cross-platform output more predictable.
With respect to the preponderance of arrows: this was always an annoyance which I never solved.  I toyed with the idea of using some kind of heuristic for how necessary a given arrow head was. I concluded that it depended on the number of neighbouring elements, how big they rendered, whether they were simple or compound elements, whether they spanned multiple rows, etc.  In the end I just gave up on it: we weren't using syntax diagrams at Moldflow so it wasn't a priority.
Some context about some of the (justified) nits @GrahamHannington refers to: when I wrote this code, I wasn't very good at SVG, or JavaScript. Also, the tools (primarily Batik and Rhino) that were available at the time had limitations which I had to work around.  You'll have to experiment with the current tools to see whether the limitations were with the tools of the time or my code.  Probably the latter.
Please pass my apologies on to anyone in your respective organizations who have had to deal with my proof-of-concept-quality code.  In my defence, it was super fun to develop.
Deborah

@futzle -- I missed your post in July while I was out of town. So glad to hear from you, and I cannot really convey how appreciative I am of all the work you put into this. I still remember gathering samples of some Uglier Diagrams and being amazed at what you achieved with them. The code here (as of yesterday) was brought up to date with DITA-OT 2.5; I've got a copy now that works against the latest release, 3.3.4, and I'm finally getting around to trying to integrate the last year's worth of tweaks, fixes, and enhancements.
One of those enhancements makes use of CSS changes to remove most of the boxes and arrows. It still uses boxes as the SVG base (for the exact reasons you describe), but puts out a specific class for every type of box, which allows us to then turn off the lines. So the boxes are there, you just can't see them any more. Same goes for the arrows; they're all still there, but I dug in enough to figure out every different way that arrows are generated, use unique classes, and only fill in the important ones.
Anyway - thanks again for all the amazing work you put into this. No apologies necessary, I'm still amazed by how far you got with something called a proof-of-concept 😄
All of the changes mentioned above are part of https://github.com/robander/svg-syntaxdiagrams/pull/12 -- with those updates, marking this issue closed.


Cosmos DB patch and multi-api support

This change introduces patch support in the new API version and splits "createOrUpdate" into "create" and "update". No SDKs have been generated based on this new version yet. The new patch properties are identical to the "update" properties except "locations" is optional and offer type is not a part of the payload.
This change also adds "locations" in the database account response to help resolve https://github.com/Azure/azure-sdk-for-python/issues/6823
This change also enable multiple-api version support for python, java and go libraries. I copied the formatting from other providers, but am not sure how to validate how this works. Most importantly, python code is now generated in subdirectories of the current python project. I am not sure how that will impact the existing code (if it needs to be deleted since it will not be replaced). This change also references a preview version, which is added in https://github.com/Azure/azure-rest-api-specs/pull/7249. This change should be merged after that.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[x] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[x] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Automation for azure-sdk-for-go

Automation for azure-sdk-for-python

Can one of the admins verify this patch?

@ArcturusZhang I think that I have the readme file correct, but it depends on this change - https://github.com/Azure/azure-rest-api-specs/pull/7249. I just added the necessary changes for that new file so that we would not have to open another PR. I'll re-run the automation after that PR is merged (which it is ready to be merged).

@ArcturusZhang I think that I have the readme file correct, but it depends on this change - #7249. I just added the necessary changes for that new file so that we would not have to open another PR. I'll re-run the automation after that PR is merged (which it is ready to be merged).

Sure, thanks!

@ArcturusZhang, I am removing those changes so that SDKs can be generated since we want to expedite this change. @ravbhatnagar can you please re-review this? We are hesitant to leave the method named "CreateOrUpdate".

@shurd - please take a look at the response

@ravbhatnagar I have made the renaming change.


Minor Alignment Fixes

Minor alignment fixes in dashboard & fonts

Thank you @adiralashiva8! you've fixed  #79 in this PR. I added some some unit tests in another PR. Will combine them before release.

Hey @adiralashiva8, there is a minor conflicts with .gitignore can you please pull from this repo's master and rebase it :)

Resolved conflicts please review and merge


How to disable Typescript and Jest?

When I'm entering ...currentThing(), I get:
/home/.../index.js
  0:0  error  Parsing error: Cannot read file '/home/.../tsconfig.json'

After changing it to ...currentThing({ disable: ["Typescript"] }), nothing changes.
After creating an empty tsconfig.json file I get this:
Error: Error while loading rule 'jest/no-deprecated-functions': Unable to detect Jest version - please ensure jest package is installed, or otherwise set version explicitly

After changing it to ...currentThing({ disable: ["Jest", "Typescript"] }), nothing changes.
It's probably just a small thing, but I can't figure it out at the moment.

The config is all but predicated on Typescript and Jest. They are winning the popularity contest, and no one is happy! That is to say, I don't think you can use the config without Typescript and without Jest. After the refactor and new release, I will once again investigate if these can be turned off, but its probably far more effort than it's worth. Like the README says:
WARNING: disable may have unintended consequences as various configs are interdependent (To-do: This need not be so, but fixing it is very annoying).

Indeed, this is doable, but too ridiculously-in-the-weeds to implement. It involves toggling various rules in every config per the plugin. And, because we can not give favoritism to any config, it also means giving the same ability to every config that cross activates / disables rules. Ie, the difficulty of adding this feature is n*n where n is the number of plugins (presently 29).
There is also probably a creative solution to the issue that can reduce this complexity, but i dont have the bandwidth to pursue it. PRs welcome!
I will leave the issue open in case this idea gains steam.


Flaky Jest tests on GH Actions: ERROR  Command failed with exit code 139. Segmentation fault (core dumped)

Run pnpm run jest integration/sqlite -- --maxConcurrency=8

><EMAIL_ADDRESS>jest /home/runner/work/prisma/prisma/src/packages/integration-tests
> jest "integration/sqlite" "--maxConcurrency=8"

PASS src/__tests__/integration/sqlite/introspection.test.ts (5.058 s)
PASS src/__tests__/integration/sqlite/runtime.test.ts (11.211 s)

Test Suites: 2 passed, 2 total
Tests:       114 passed, 114 total
Snapshots:   114 passed, 114 total
Time:        16.533 s
Ran all test suites matching /integration\/sqlite/i.
 ERROR  Command failed with exit code 139.
Segmentation fault (core dumped)
Error: Process completed with exit code 1.

Happens randomly sometimes, should be observed.

List of occurrences:

https://github.com/prisma/prisma/pull/8213/checks?check_run_id=3039580765

This stopped since we merged https://github.com/prisma/prisma/pull/8386.  This makes me believe that it is really not an issue on our end, but who knows? If it happens again, we'll have  it logged into the console.

Still happening unfortunately regularly in PRs :(

Is this still an issue?

I'm going to close this and we can open again if the issue occurs again.


Users with TA role cannot grade students by default in GradebookNG

UNC Chapel Hill patch

This is a Sakai 11 request. Should this be against master instead?

Just tagged this as 11.4. Seems like something we need to get in sooner than later. Thanks, -jp

Need a PR against master not 11.x

We'll address the comments above and resubmit against master

Hey @tawillis, we are interested in getting this in, do you have an updated PR?

I made the code changes, we are currently testing it in our non-prod env. I will resubmit the PR probably in the morning of 5/4

see PR 4378. I submitted against 11.x and not master. If you want this resubmitted against master, it's not going to happen for a long time. I am absolutely swamped with assignment and GBNG issues at the moment.

#4378 , linked PR.
@tawillis , if you put a # in front of the PR number they will automagically be linked.

Hi @tawillis , yeah, that is the process the community uses. First a patch against master, then we verify the fix in master, then it gets merged into the 11 branch (or whatever the current branch is). The "11 status" flag needs to get set to merge for us to pick it up in Jira.
Direct commits against the 11 branch (or any branch) are discouraged, because the patch may not make it back to master, so on the next major release of Sakai, the fix is gone.
I hope that makes sense. Best of luck with your local work.


DistributedEvalSamper hangs at the end of the script when using DDP

Dear author,
Thank you at first for your great work!
I am trying to use your implementation of DistributedEvalSampler for an evaluation purpose, jointly with DDP.
(with shuffle=Flase and no calling of set_epoch(); after calling DistributedEvalSampler for yielding test samples on evaluating a model, my program should be finished)
At the end of the script, my program hangs with charging 100% of GPU utilization in all 2 of 3 GPUs.
(the last device is soley terminated with no errors)
When replaced with DistributedSampler, this is not occurred.
I doubted it is because of the logging (e.g., Wandb) is occurred at rank 0 device,
but it is not the root cause as it is still occurred when I turned off the logging tool.
I wonder if you could point out conditions that I missed, please?
Thank you in advance.
Best,
Adam

Hi @vaseline555,

Is your dataset size divisible by the number of GPUs?
If so, there should be no difference in the behavior of DistributedSampler and DistributedEvalSampler.

Are you using any kind of communication between processes that requires synchronization, i.e., back-propagation?
DistributedEvalSampler does not require any communication between processes and I don't think it will be the source of hanging.
If you are using other synchronization-based operations, they may expect the same dataset length per process.
For example, if your total dataset size is 5 and you are using 3 processes, GPU 0 and 1 will be processing the 2nd item while GPU 2 is done after the 1st iteration.
If you are using a synchronization-based operation, GPU 0 and 1 will be waiting for the response from GPU 2 which will never occur.
When I need to do backpropagation at test time for each item, I turn off synchronization.

self.model.model.G.require_backward_grad_sync = False   # compute without DDP sync

Best,
Seungjun

Dear @SeungjunNah,
Thank you for your detailed answers.
Like you presumed, it is exactly the case 2 that I have faced: uneven inputs are provided across different ranks.
Though there's no typical synchronization operation like backward() except .item() or .detach().cpu(),
the main problem is the position I called torch.distributed.barrier()...
I called it at the end of every iteration, not the end of every epoch.
Thus, when inputs of the rank having less inputs are depleted (which surely has less iterations than others),
it escapes out the evaluation loop faster than others, thereby other ranks are hanging around the barrier...
I fixed it by replacing the barrier to other position (i.e., at the end of epoch), and now things are going well.
While Googling, many people have trouble with treating uneven inputs when using DDP.
(FYI: https://github.com/pytorch/pytorch/issues/38174; https://github.com/PyTorchLightning/pytorch-lightning/issues/3325; https://github.com/pytorch/pytorch/pull/72423), even though I tried using DDP.join() context manager, yours finally worked as a solution. 👍
I would like to thank you again for sharing your implementation of DistributedEvalSampler.
Have a nice day!
Thank you.
Sincerely,
Adam

@DaoD
I don't know where you want to call all_gather but I do all_reduce outside the loop.
In my case, all processes are independent and the communications are done after the loop to collect loss/metric statistics.
In train.py, I compute loss/metrics from the outputs here.
self.criterion(output, target)

Outside the loop, here, I call
self.criterion.normalize()

which is defined here with dist.all_reduce inside.
If you want to call all_gather during the for loop, I think it will hang.
But then, that will be the case you need all processes to work together and that's not an expected use case of DistributedEvalSampler.

@SeungjunNah Thanks for your reply! I will try to use all_gather out of the data loop.


Make the project work with current APIs

Update the use of Avi-on's API to the current v3
Fix incorrect use of avid (this now also supports groups etc)
Add new function for constructing packets that work for both devices and groups
Remove use of deprecated BLEDevices.rssi
Replaced product_ids filtering with a type filter

This looks great, thank you! I no longer have these lights but assuming you have tested this against your devices? If so I will merge and release a new version to pypi.
Don't worry about the linting, I'll try to fix the workflows before merging.

I have tested the create_packet for both devices and groups separately, and ran the following to go through the re-integration back into the halohome project
from halohome import halohome
import asyncio

async def main():
    halohome
    devices = await<EMAIL_ADDRESS>"****")
    connection = halohome.Connection(devices)
    for device in connection.devices:
        device_id = device.device_id
        if device_id == 33069: # the test device I'm targeting
            print(f"found device {device_id}")
            await device.set_brightness(50)
            await device.set_color_temp(2700)

asyncio.run(main())

Didn't you have a home assistant add-on using this at some point, or am I misremembering?

Great, will merge this in today.
Yes, the home assistant integration never got merged. Apparently its bluetooth stack went through a lot of changes, completely breaking this library's usage of bleak. https://github.com/home-assistant/core/pull/58316

I'm going to also extend this with support for groups, and once I get the basics integrated with Home Assistant again, I'll also look at adding polling/subscriptions in order to reflect the state of the devices when acted on externally. After that, discovery of new devices, adding them to the mesh, and removing them will come next.
Wrt HA, I remember that PR now. I'll try first spinning this up as a separate VM integrating with MQTT, and then when I have time to port this to C++, I'll make it work as an ESPHome type of device.
I'm an utter n00b when it comes to python, so hoping that if I can cover extending this library with the core functionality, then maybe someone from the HA community will be able to help with the rest.

@oyvindkinsey Released to pypi 0.6.0, thanks for the changes!


logging: adsp hda backend refinements and additional test

Additional testing showed than when using printk the logger would start sticking and spitting out nulls which is wrong. This seems to have been caused by the initial ipc message to read all the dma buffers on the host.
Removing that, the issue seems to have been solved.
This fixes using the hda log backend with the drivers/can/shell test which previously failed with it.
Signed-off-by: Tom Burdick<EMAIL_ADDRESS>

Somewhat related #49948


Docker for Mac Kubernetes DNS fails to resolve

I'm trying to resolve a Kubernetes internal dns record like fed.apps.svc.cluster.local, but am having issues doing so.
My setup is Docker for Mac (<IP_ADDRESS>), which ships with Docker 18.09.02 and Kubernetes v1.10.11.
The Tiltfile I'm using is pretty basic, each Kubernetes file has a Deployment, Ingress, etc copied from our production setup.
k8s_yaml("00-namespace.yml")

k8s_resource('proxy', './proxy/proxy.yml', port_forwards='9000:9000')
k8s_resource('ach', './ach/10-ach.yml', port_forwards='8080:8080')
k8s_resource('auth', './auth/11-auth.yml', port_forwards='8081:8080')
k8s_resource('ofac', './ofac/13-ofac.yml', port_forwards='8084:8080')
k8s_resource('paygate', './paygate/12-paygate.yml', port_forwards='8082:8080')

When I try and load http://localhost:9000/v1/fed/ping I get back a 502 error with the following from the proxy pod (running a Go HTTP reverse proxy).
2019/03/14 18:16:42.956286 reverseproxy.go:442: http: proxy error: dial tcp: lookup fed.apps.svc.cluster.local on <IP_ADDRESS>:53: no such host

I've looked through the kubedns logs and everything looks okay. Is this a known issue?

Hmmm...I can't think of any Tilt-specific reason why this would fail to resolve.
Are you aware of kubespy? You could try running kubespy trace svc apps/fed and it will check for common misconfiguration issues.
https://blog.pulumi.com/kubespy-trace-a-real-time-view-into-the-heart-of-a-kubernetes-service

Thanks. This was a couple bad configs on my part.


Change image in image component and explain captions

Description
At Style Council, we agreed to bring the example image in the image component into line with the accessibility guidance example. Having 2 examples was confusing and the accessibility guidance example is the better one.
Also add more guidance about captions - agreed at Style Council
Related issue
https://github.com/nhsuk/nhsuk-service-manual/issues/1231
Checklist

[ ] Tested against the NHS.UK frontend testing policy (Resolution, Browser & Accessibility)
[ ] Code follows the NHS.UK frontend coding standards
[ ] Version number has been increased in package.json (using SEMVER)
[ ] CHANGELOG entry - not yet
[ ] Whats new page entry - not yet
[ ] Page updated date - done

@davidhunter08 Would you mind checking this please?
Also, we need to delete the image we currently use from the assets folder: https://assets.nhs.uk/prod/images/S_1017_allergic-conjunctivitis_M15.2e16d0ba.fill-320x213.jpg. Can you help with that, please?

@sarawilcox that image lives on nhs.uk Wagtail assets (uploaded through the CMS admin) so its not something we have in our service manual code base

Thanks @chrimesdev. What do we have to do to get it changed?

Theres nothing we need to do in our code base, as we're now using the new image path (https://assets.nhs.uk/prod/images/S_0318_Bullous_pemphigoid_lesions_.2e16d0ba.fill-320x213.jpg).
That image can stay on the nhs.uk assets as its probably used by some Wagtail places (or possibly somewhere else)

@chrimesdev, sorry - yes, I've just realised that. It is still used in Wagtail. We just won't refer to it.

Looks like we just need the CHANGELOG entry + what's new page entry @sarawilcox, then we're good to go.


Left and Right RGB Images

Before opening a new issue, we wanted to provide you with some useful suggestions (Click "Preview" above for a better view):

Consider checking out SDK examples.
Have you looked in our documentations?
Is you question a frequently asked one?
Try searching our GitHub Issues (open and closed) for a similar issue.

All users are welcomed to report bugs, ask questions, suggest or request enhancements and generally feel free to open new issue, even if they haven't followed any of the suggestions above :)

Required Info

Camera Model
D435

Firmware Version
(Open RealSense Viewer --> Click info)

Operating System & Version
Win 10

Kernel Version (Linux Only)
(e.g. 4.14.13)

Platform
PC

SDK Version
{ legacy / 2.. }

Language
python

Segment
Robot

Issue Description
Since I saw one rgb image ROS topic and the RealSense Viewer shows one rgb image only, I wondered if it is possible to save the left and right images somehow.

Hi @suptimq  Only the left infrared sensor of RealSense cameras can provide an RGB image, and this feature is only supported on some camera models (D405, D415 and the D455-class models such as D455, D455f, D456 and D457).
These models can though show both the 'RGB from left infrared image' and the normal RGB image at the same time.

Hi @MartyG-RealSense Thanks for the quick response! I appreciate the information for D405 and D455-class models. However, could you provide information for D435-class models such as D435 and D435i?
I saw there are a left imager and a right imager https://www.intelrealsense.com/depth-camera-d435/.

The left and right infrared sensors on the D435 / D435i / D435f / D435if models are monochrome and so do not support RGB from left IR mode.  You can stream an RGB-like infrared image from both the left and right sensors if you disable the dot-pattern projection to remove the dots overlaid on the image but it will be in Y8 format rather than RGB and both images will also be black and white.

@MartyG-RealSense how to get the IR images from D405 using the python API? The folllowing will give an error "RuntimeError: Couldn't resolve requests". However, the same worked for D415.
config.enable_stream(rs.stream.depth, W, H, rs.format.z16, fps)
config.enable_stream(rs.stream.color, W, H, rs.format.bgr8, fps)
config.enable_stream(rs.stream.infrared, 1, W, H, rs.format.y8, fps)
config.enable_stream(rs.stream.infrared, 2, W, H, rs.format.y8, fps)

profile = pipeline.start(config)

Hi @wenbowen123  RuntimeError: Couldn't resolve requests means that a custom configuration was requested that the camera was unable to provide.
What FPS are you setting Infrared 1 and 2 to, please?  For example, if they were set to '6' (which D415 supports) then this could cause the RuntimeError on D405 as it supports 5 FPS instead of 6.
Another cause of the error would be if the USB connection on the D405 was being detected as USB 2.1 instead of USB 3, as the right-side Infrared 2 stream is not supported on a USB 2.1 connection, only on USB 3.
Also, which resolution are you using in W and H please?

USB 2.0 seems to be the issue, thanks @MartyG-RealSense !


Remove unused reconnect method

@vrde I think this is probably a remnant of the changes you made for the Connection class? It doesn't look like we're using it (and we probably shouldn't be).

Current coverage is 96.37% (diff: 100%)

Merging #749 into master will increase coverage by 0.05%

@@             master       #749   diff @@
==========================================
  Files            25         25
  Lines          1602       1600     -2
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           1543       1542     -1
+ Misses           59         58     -1
  Partials          0          0

Powered by Codecov. Last update 51c5814...bc6084e


I am suddenly facing this issue

moor_flutter: ^2.0.0
moor: ^2.0.0
build_runner: ^1.3.1
moor_generator: ^2.0.0
Flutter Doctor
[✓] Flutter (Channel stable, v1.9.1+hotfix.6, on Mac OS X 10.15.1 19B88, locale en-GB)
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
[✓] Xcode - develop for iOS and macOS (Xcode 11.2)
[✓] Android Studio (version 3.5)
[✓] VS Code (version 1.40.0)
[✓] Connected device (2 available)
Compiler message:
../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/moor_web.dart:9:8: Error: Not found: 'dart:html'
import 'dart:html';
^
../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/src/web/sql_js.dart:2:8: Error: Not found: 'dart:js'
import 'dart:js';
^
../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/http-0.12.0+2/lib/src/browser_client.dart:6:8: Error: Not found: 'dart:html'
import 'dart:html';
^
../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/src/web/sql_js.dart:42:9: Error: Type 'JsObject' not found.
final JsObject _obj;
^^^^^^^^
../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/src/web/sql_js.dart:57:3: Error: Type 'JsObject' not found.
JsObject _createInternally(Uint8List data) {
^^^^^^^^
../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/src/web/sql_js.dart:70:9: Error: Type 'JsObject' not found.
final JsObject _obj;
^^^^^^^^
../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/src/web/sql_js.dart:122:9: Error: Type 'JsObject' not found.
final JsObject _obj;
^^^^^^^^
../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/http-0.12.0+2/lib/src/browser_client.dart:97:25: Error: Type 'HttpRequest' not found.
void _openHttpRequest(HttpRequest request, String method, String url,
^^^^^^^^^^^
../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/http-0.12.0+2/lib/src/browser_client.dart:32:25: Error: 'HttpRequest' isn't a type.
final _xhrs = new Set();
^^^^^^^^^^^
../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/src/web/web_db.dart:125:17: Error: Getter not found: 'window'.
final raw = window.localStorage[_persistenceKey];
^^^^^^
../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/src/web/web_db.dart:125:17: Error: The getter 'window' isn't defined for the class '_WebDelegate'.

'_WebDelegate' is from 'package:moor/moor_web.dart' ('../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/moor_web.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named 'window'.
final raw = window.localStorage[_persistenceKey];
^^^^^^
../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/src/web/web_db.dart:136:7: Error: Getter not found: 'window'.
window.localStorage[_persistenceKey] = binStr;
^^^^^^
../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/src/web/web_db.dart:136:7: Error: The getter 'window' isn't defined for the class '_WebDelegate'.
'_WebDelegate' is from 'package:moor/moor_web.dart' ('../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/moor_web.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named 'window'.
window.localStorage[_persistenceKey] = binStr;
^^^^^^
../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/src/web/web_db.dart:149:10: Error: Getter not found: 'window'.
if (!window.localStorage.containsKey(_versionKey)) {
^^^^^^
../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/src/web/web_db.dart:152:24: Error: Getter not found: 'window'.
final versionStr = window.localStorage[_versionKey];
^^^^^^
../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/src/web/web_db.dart:149:10: Error: The getter 'window' isn't defined for the class '_WebVersionDelegate'.
'_WebVersionDelegate' is from 'package:moor/moor_web.dart' ('../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/moor_web.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named 'window'.
if (!window.localStorage.containsKey(_versionKey)) {
^^^^^^
../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/src/web/web_db.dart:152:24: Error: The getter 'window' isn't defined for the class '_WebVersionDelegate'.
'_WebVersionDelegate' is from 'package:moor/moor_web.dart' ('../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/moor_web.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named 'window'.
final versionStr = window.localStorage[_versionKey];
^^^^^^
../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/src/web/web_db.dart:159:5: Error: Getter not found: 'window'.
window.localStorage[_versionKey] = version.toString();
^^^^^^
../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/src/web/web_db.dart:159:5: Error: The getter 'window' isn't defined for the class '_WebVersionDelegate'.
'_WebVersionDelegate' is from 'package:moor/moor_web.dart' ('../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/moor_web.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named 'window'.
window.localStorage[_versionKey] = version.toString();
^^^^^^
../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/src/web/sql_js.dart:19:8: Error: Getter not found: 'context'.
if (!context.hasProperty('initSqlJs')) {
^^^^^^^
../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/src/web/sql_js.dart:26:4: Error: Getter not found: 'context'.
(context.callMethod('initSqlJs') as JsObject)
^^^^^^^
../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/src/web/sql_js.dart:26:39: Error: 'JsObject' isn't a type.
(context.callMethod('initSqlJs') as JsObject)
^^^^^^^^
../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/src/web/sql_js.dart:37:53: Error: 'JsObject' isn't a type.
moduleCompleter.complete(SqlJsModule.(module as JsObject));
^^^^^^^^
../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/src/web/sql_js.dart:42:9: Error: 'JsObject' isn't a type.
final JsObject _obj;
^^^^^^^^
../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/src/web/sql_js.dart:50:7: Error: Getter not found: 'context'.
context['db'] = dbObj;
^^^^^^^
../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/src/web/sql_js.dart:50:7: Error: The getter 'context' isn't defined for the class 'SqlJsModule'.
'SqlJsModule' is from 'package:moor/src/web/sql_js.dart' ('../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/src/web/sql_js.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named 'context'.
context['db'] = dbObj;
^^^^^^^
../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/src/web/sql_js.dart:58:45: Error: 'JsFunction' isn't a type.
final constructor = _obj['Database'] as JsFunction;
^^^^^^^^^^
../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/src/web/sql_js.dart:61:14: Error: Method not found: 'JsObject'.
return JsObject(constructor, [data]);
^^^^^^^^
../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/src/web/sql_js.dart:63:14: Error: Method not found: 'JsObject'.
return JsObject(constructor);
^^^^^^^^
../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/src/web/sql_js.dart:61:14: Error: The method 'JsObject' isn't defined for the class 'SqlJsModule'.
'SqlJsModule' is from 'package:moor/src/web/sql_js.dart' ('../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/src/web/sql_js.dart').
Try correcting the name to the name of an existing method, or defining a method named 'JsObject'.
return JsObject(constructor, [data]);
^^^^^^^^
../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/src/web/sql_js.dart:63:14: Error: The method 'JsObject' isn't defined for the class 'SqlJsModule'.
'SqlJsModule' is from 'package:moor/src/web/sql_js.dart' ('../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/src/web/sql_js.dart').
Try correcting the name to the name of an existing method, or defining a method named 'JsObject'.
return JsObject(constructor);
^^^^^^^^
../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/src/web/sql_js.dart:70:9: Error: 'JsObject' isn't a type.
final JsObject _obj;
^^^^^^^^
../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/src/web/sql_js.dart:75:54: Error: 'JsObject' isn't a type.
final obj = _obj.callMethod('prepare', [sql]) as JsObject;
^^^^^^^^
../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/src/web/sql_js.dart:86:16: Error: Getter not found: 'JsArray'.
final ar = JsArray.from(args);
^^^^^^^
../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/src/web/sql_js.dart:86:16: Error: The getter 'JsArray' isn't defined for the class 'SqlJsDatabase'.
'SqlJsDatabase' is from 'package:moor/src/web/sql_js.dart' ('../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/src/web/sql_js.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named 'JsArray'.
final ar = JsArray.from(args);
^^^^^^^
../../Tools/flutter/.pub-cache/hosted/pub.dartlang.org/moor-2.0.1+1/lib/src/web/sql_js.dart:101:71: Error: 'JsArray' isn't a type.
.callMethod('exec', const ['SELECT last_insert_rowid();']) as JsArray;

Can you check whether you're importing package:moor/moor_web.dart anywhere? If you are, replace the import with package:moor/moor.dart

No I am not importing moor_web anywhere in my project. But I am using following packages in my app.
http: ^0.12.0+2
fluro: "^1.5.1" # router
get_it: ^3.0.1
mobx: ^0.3.8
flutter_mobx: ^0.3.3
flutter_swiper: ^1.1.6
font_awesome_flutter: ^8.5.0
flutter_spinkit: "^4.0.0"
shared_preferences: ^0.5.3+4
google_sign_in: ^4.0.11
flutter_facebook_login: ^3.0.0
time_formatter: ^1.0.0
uuid: ^2.0.2
bubble: ^1.1.9+1
emoji_picker: ^0.0.2
cached_network_image: ^1.1.1
moor_flutter: ^2.0.0
moor: ^2.0.0
md2_tab_indicator: ^1.0.2
xlive_switch: ^1.0.5
connectivity_wrapper: 1.0.2
flutter_ringtone_player: ^1.0.3
device_info: ^0.4.1+1

Sorry. It was my mistake. I accidentally imported  moor_web instead of moor while refactoring my code. I wasted 6 hours for this. Thank for indicating issue @simolus3


Update BFF for permissions With new Auditlog create fieldd

Codecov Report

Merging #1503 (cbf1b3d) into main (10c54ca) will increase coverage by 13.86%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             main    #1503       +/-   ##
===========================================
+ Coverage   31.80%   45.66%   +13.86%
===========================================
  Files          54       74       +20
  Lines         827     1360      +533
  Branches       47        0       -47
===========================================
+ Hits          263      621      +358
- Misses        554      724      +170
- Partials       10       15        +5

Impacted Files
Coverage Δ

...MarketParticipant/Dto/PermissionAuditLogViewDto.cs
0.00% <0.00%> (ø)

...arketParticipant/Dto/PermissionAuditLogsViewDto.cs
0.00% <0.00%> (ø)

...ntrollers/MarketParticipant/Dto/UserRoleViewDto.cs
0.00% <0.00%> (ø)

...ntrollers/MarketParticipantPermissionController.cs
0.00% <0.00%> (ø)

...Controllers/MarketParticipantUserRoleController.cs
0.00% <0.00%> (ø)

...i-dh/source/DataHub.WebApi/GraphQL/GraphQLQuery.cs
0.00% <0.00%> (ø)

...-dh/source/DataHub.WebApi/GraphQL/GraphQLSchema.cs
0.00% <0.00%> (ø)

...h/source/DataHub.WebApi/GraphQL/Types/BatchType.cs
0.00% <0.00%> (ø)

...urce/DataHub.WebApi/GraphQL/Types/DateRangeType.cs
0.00% <0.00%> (ø)

.../DataHub.WebApi/GraphQL/Types/PermissionDtoType.cs
0.00% <0.00%> (ø)

... and 23 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[FLINK-19403][python] Support Pandas Stream Group Window Aggregation

What is the purpose of the change
This pull request will support Pandas Stream Group Window Aggregation
Brief change log

Add StreamArrowPythonGroupWindowAggregateFunctionOperator
Add Physical Rule and RelNode

Verifying this change
This change added tests and can be verified as follows:

Add UT PythonGroupWindowAggregateTest
Add IT StreamPandasUDAFITTests

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

@dianfu Thanks a lot for the review. I have addressed the comments at the latest commit.

@dianfu Thanks a lot for the review. I have addressed the comments at the latest commit.


Does it supports window phone 8 and greater versions

I have been finding chart library with zoom and pan supported so I would like to know if your library could be supported for wp8 or not

I have never worked with wp8, I will try it and let you know

@beto-rodriguez  any news ?

@rspl17 sorry I have not test it yet, I have never worked with wp8 I tried but with no success yet :( can you please guide me or test it?

@beto-rodriguez  sure I can help but the UI elements of window phone 8 are different than the window 8 or wpf. At these level I could help you writing UI code if needed but I need to understand the logic behind chart and zooming can you explain me ? here or skype or other place you like....

I will close this, maybe in a future we can reopen it again and try to extend this charts to wp8


Extract FinalHandler::getStatusCode to Utils

Extracted FinalHandler::getStatusCode to Utils::getStatusCode, making it a public static method (per @SpiffyJr). This allows re-use of that logic in custom final handlers.

:+1: - Perfect.