Include return characters in error messages

As a temporary stop-gap in the movement toward more interpretable error messages, it would be extremely helpful in the Python error messages currently printed during processing came with return characters.
The current system, without any visual breaks, is hard to read:

Error Job results: ValueError(Failed to execute: process_sff.py -i /projects/qiita_data/raw_data/521_F5Y487X02.sff -o /projects/qiita_data/working_dir/sl_outPjNqNU; process_sff.py -i /projects/qiita_data/raw_data/521_F5Y487X01.sff -o /projects/qiita_data/working_dir/sl_outPjNqNU; split_libraries.py -f /projects/qiita_data/working_dir/sl_outPjNqNU/521_F5Y487X02.fna,/projects/qiita_data/working_dir/sl_outPjNqNU/521_F5Y487X01.fna -m /projects/qiita_data/working_dir/MMF_768ycmrnE/F5Y487X_MMF.txt -q /projects/qiita_data/working_dir/sl_outPjNqNU/521_F5Y487X02.qual,/projects/qiita_data/working_dir/sl_outPjNqNU/521_F5Y487X01.qual -d -o /projects/qiita_data/working_dir/sl_outPjNqNU --barcode_type golay_12 --max_ambig 6 --max_barcode_errors 1.5 --max_homopolymer 6 --max_primer_mismatch 0 --max_seq_len 1000 --min_qual_score 25 --min_seq_len 200 --qual_score_window 0 --reverse_primer_mismatches 0 --reverse_primers disable; convert_fastaqual_fastq.py -f /projects/qiita_data/working_dir/sl_outPjNqNU/seqs.fna -q /projects/qiita_data/working_dir/sl_outPjNqNU/seqs_filtered.qual -o /projects/qiita_data/working_dir/sl_outPjNqNU -F stdout: stderr: Traceback (most recent call last): File "/home/qiita/qiime/scripts/split_libraries.py", line 411, in  main() File "/home/qiita/qiime/scripts/split_libraries.py", line 408, in main truncate_ambi_bases=opts.truncate_ambi_bases) File "/home/qiita/qiime/qiime/split_libraries.py", line 1289, in preprocess barcode_type, added_demultiplex_field) File "/home/qiita/qiime/qiime/split_libraries.py", line 310, in check_map 'identify problems.') ValueError: Errors were found with mapping file, please run validate_mapping_file.py to identify problems. Usage: convert_fastaqual_fastq.py [options] {-f/--fasta_file_path FASTA_FILE_PATH} [] indicates optional input (order unimportant) {} indicates required input (order unimportant) From a FASTA file and a matching QUAL file, generates a FASTQ file. A minimal FASTQ file omits the redundant sequence label on the quality scores; the quality scores for a sequence are assumed to follow immediately after the sequence with which they are associated. The output FASTQ file will be generated in the specified output directory with the same name as the input FASTA file, suffixed with '.fastq'. A FASTQ file will be split into FASTA and QUAL files, and generated in the designated output directory. Example usage: Print help message and exit convert_fastaqual_fastq.py -h Example: Using the input files seqs.fna and seqs.qual, generate seqs.fastq in the fastq_files directory convert_fastaqual_fastq.py -f seqs.fna -q seqs.qual -o fastq_files/ Example: Using input seqs.fastq generate fasta and qual files in fastaqual directory convert_fastaqual_fastq.py -c fastq_to_fastaqual -f seqs.fastq -o fastaqual convert_fastaqual_fastq.py: error: option -f: file does not exist: '/projects/qiita_data/working_dir/sl_outPjNqNU/seqs.fna' ) Python output: None Standard output: Standard error: Job GEN_DEMUX_FILE: Error Job results: ImpossibleDependency() Python output: None Standard output: Standard error: Job INSERT_PREPROCESSED: Error Job results: ImpossibleDependency() Python output: None Standard output: Standard error:

If visual breaks could be included, that would increase the readability immensely.

Error Job results:
Traceback (most recent call last): File "/home/qiita/qiime/scripts/split_libraries.py", line 411, in  main() File "/home/qiita/qiime/scripts/split_libraries.py", line 408, in main truncate_ambi_bases=opts.truncate_ambi_bases)
File "/home/qiita/qiime/qiime/split_libraries.py", line 1289, in preprocess barcode_type, added_demultiplex_field)
File "/home/qiita/qiime/qiime/split_libraries.py", line 310, in check_map 'identify problems.')
ValueError: Errors were found with mapping file, please run validate_mapping_file.py to identify problems.

Related to https://github.com/biocore/qiita/issues/1115 and https://github.com/biocore/qiita/issues/1269
We should be able to solve all of them at once.


Normalize data and tables

Normalize data and tables so they are not City of Asheville based.  use standards when available

not needed for soft realease


manual changes required after running terraform apply

hey after I run terraform apply it writes in place over my cloud workflow code that I need to then modify and fix.  This has to do with the google_ads table in dataform.json. The formatting for it needs to be _12345560 where this is the string for the ads customer id instead of _123-123-123

Once i make this change the pipeline is able to be ran successfully.

@kingman could you have a look at this, pls?

What is the configuration value you have for dataform_github_repo in your terraform.tfvars file?

This issue could not been reproduced.

additional clarification in the docs/tutorial might be useful to state that Google Ads customer id should be without "-" just numbers


[4.2] Cannot publish package configuration unless it is in the root of the package

If you have a package foo/bar and you store the configuration file in vendor/foo/bar/src/FrameworkIntegration/Laravel/config/config.php, it is not possible to publish this configuration with php artisan config:publish.
Relevant source is in line 85 of \Illuminate\Foundation\ConfigPublisher:
	protected function getSource($package, $packagePath)
	{
		$source = $packagePath."/{$package}/src/config";

		if ( ! $this->files->isDirectory($source))
		{
			throw new \InvalidArgumentException("Configuration not found.");
		}

		return $source;
	}

The source is hardcoded to /src/config in the package folder. This should be updated to pull the location of the config from the service provider which should have registered the location of the assets.

You can override this by passing the path you want as the third param to the package method.

@GrahamCampbell No, unless I'm missing something I don't believe you can?
Passing the third param will load the package configuration properly when in use via \Config::get(), etc. but the ConfigPublisher seems hardcoded to never touch the path registered with the ServiceProvider.
I created an example laravel application here: https://github.com/tpavlek/test-pkg-config.
It contains only the stock laravel installation, plus my package oauth2-twitch. If you try to run php artisan config:publish depotwarehouse/oauth2-twitch you get Configuration not found.
Debugging through the registration of the Service Provider, it is properly set via $this->app['config']->package in \Illuminate\Support\ServiceProvider on line 2991. However, the behaviour of the ConfigPublisher is exactly as I described in the bug report.

Hmmm, well this is already fixed in 5.0 anyway, and there are no plans to make any changes to 4.2's package system. I think 5.0 is much more flexible that 4.2 was both for packages, and for some other things too (pagination for example).

Absolutely.
I plan to migrate as much as possible to 5.0 as soon as it's drop and I'm sure it's not going to break production, but I spent my morning debugging this issue so thought I'd make the tracker aware of it.


 Please review and merge.

@keichi I already review them. I will merge into the master.


[feature request] Increase the size of bending points

Hi,
Is there a way to increase the size of the bending points?
Even though I know they are supposed to be in the middle, it's really hard to find them.
Thanks,

Yes, they are a bit small.
If you'd asked this a year ago I would have said that it's not possible because the bend-point sizes are internal to the Graphical Eclipse Framework (GEF) that Archi uses. But since we forked the GEF code we can modify this type of thing.
There are two types of bend-point - "Create" and "Move".  "Create" bend-points are smaller than "Move" bend-points and the single "Create" bend-point on a connection without any bend-points is not very visible. I think increasing the size of the "Create" bend-point by 1 pixel will help.

Thank you for the tip. I increased the DEFAULT_HANDLE_SIZE in SquareHandle instead. That's even better, it's like an accessibility mode.

Thank you for the tip. I increased the DEFAULT_HANDLE_SIZE in SquareHandle instead. That's even better, it's like an accessibility mode.

DEFAULT_HANDLE_SIZE affects all connection handles. But that's a matter of taste. For the next version of Archi, only the Create handle will be made bigger.

I ended up creating a new menu in preferences to update the handle_size. If you think there's value I'll do a pull req but I don't I did a clean job: I store the value in swtPrefs (AppearancePreferencePage), plus set it in SquareHandle as a static value and then initialize when opening through ArchiWorkbenchWindowAdvisor.postWindowOpen.

I don't want to make drastic changes, so I'll just increase the Create bend-point size.


doced example acl_dryrun command

The lsp server(rust-analyzer) will perfectly show an example of this command.

@mcatanzariti, I would like to clarify with you. What comments do you think would best demonstrate the work of the methods?
My suggestions.

Use ignore to specify in 1-2 lines what the request looks like.

Use # symbols to hide all dependencies for running doc tests.

The first option is short, simple, allows you to easily change this documentation in case of adding a new runtime or possibly a synchronous interface (which is very useful when there is no need for asynchrony or when a thread pool is also suitable).
The second option requires a lot of hidden code, but the tests are passed. But we already have tests covering the code base in tests/ and I just want to quickly look at an example.
Which would be preferable for you? Maybe you have your own option?
I would be happy to add 1-2 lines with the ignore flag
    /// # Example
    /// ```ignore
    /// let result: String = client
    ///    .acl_dryrun("VIRGINIA", "GET", AclDryRunOptions::default().arg("foo"))
    ///    .await?;
    /// assert_eq!(
    ///    "User VIRGINIA has no permissions to run the 'get' command",
    ///    result
    /// );
   ///```
    ///

On the other hand, rust adheres to the rule of strict compliance of the example with its operability. As a Python developer, this approach is new to me. So tell me what's best for this project.

@ArtemIsmagilov,
Interesting discussion, it was also new to me when I started writing Rust code, 2 years ago.
On one hand, I understand the point that having more boilerplate lines than the 2 actual lines that demonstrate the API for the sake of having a test that not only compiles but also does not fail can be really frustrating and it's probably why I don't have so many examples in the documentation.
On the other hand, Rust is the first language that offers me the guaranty that examples exposed in the documentation are not obsolete whenever the API or its implementation evolves.
Maybe it's ok to have ignorable examples to illustrate each Redis command as you are proposing it and at the same time having testable examples for the modules' introduction, as I have already implemented them.
Cheers,
Michaël

great! I used hidden symbols that test the code and at the same time leave only the necessary information for the user. Thanks for your comment

Sorry, documentation test don't pass

@mcatanzariti, Hi! Thanks for the review. It looks like I made a mistake in the tests, in the comments.
Let me fix this


Add examples to show how things are used.

Put in a separate examples folder.

I am working on this.

I'd like to consider moving these to the gist-doc repository so they are not tied to our release schedule. If they are distributed with a release, it creates a lot of additional work to update the examples accordingly. Even if not distributed in a release, I think the implication would be that they are being kept up-to-date with the develop branch, surely to onerous a task when making changes to gist. The gist-doc repo can get out of sync with the current state of gist, either released or in development, without creating confusion as long as it's made clear in the readme. @pwin's documentation in that repo, for example, is not updated on the same schedule as gist.

This is an excellent point.

Closing - examples will reside in gist-doc repo, @uscholdm to create new issue there.

Closing - examples will reside in gist-doc repo, @uscholdm to create new issue there.

Issue created: https://github.com/semanticarts/gist-doc/issues/7

Thank you team for doing this--I can hardly wait to read it, when I get some time.


[REQ] Does bloxstrap work with Roblox account manager or multiple game instances?

Acknowledgement of preliminary instructions

[x] I have read and acknowledged the preliminary instructions.

What idea do you have?
I would like to know if bloxstrap work with Roblox account manager or multiple game instances and how I could do it.

Multiple game instances was dropped for roblox account manager recently.

I would like to know if bloxstrap work with Roblox account manager or multiple game instances and how I could do it.

Just use it normally.

When i use Roblox Account Manager, bloxstrap denys the two roblox instances for some reason and i cant find a solution to this problem. It works perfectly when i dont have bloxstrap installed, but i want to use fastflags.


Demo Web - Performance

Site seems extremely slow and chunky.

most likely because the demo web is hosted in Indonesia. Should be fine when in production server.


Enable Link-Time Optimization (LTO)

Hi!
I noticed that in the Cargo.toml file Link-Time Optimization (LTO) for the project is not enabled. I suggest switching it on since it will reduce the binary size (always a good thing to have) and will likely improve the application's performance a bit.
I suggest enabling LTO only for the Release builds so as not to sacrifice the developers' experience while working on the project since LTO consumes an additional amount of time to finish the compilation routine. If you think that a regular Release build should not be affected by such a change as well, then I suggest adding an additional dist or release-lto profile where additionally to regular release optimizations LTO will also be added. Such a change simplifies life for maintainers and others interested in the project persons who want to build the most performant version of the application. Using ThinLTO should also help to reduce the build-time overhead with LTO. If we enable it on the Cargo profile level, users, who install the application with cargo install, will get the LTO-optimized version "automatically". E.g., check cargo-outdated Release profile.
Basically, it can be enabled with the following lines:
[profile.release]
lto = true

I have made quick tests (Fedora 40): lto = true reduces the binary size for the Release profile from 36 Mib to 24 Mib.
Thank you.
P.S. It's an idea, not an actual issue, so maybe Discussions with the "Ideas" section is a better place to discuss such things (but for now Discussions are disabled in this repo)

Thanks a lot! and I've also enabled Discussions tab :D


session_state parameter is sent in the redirect uri when the user deny the consent

According to the "<IP_ADDRESS>.  Authentication Error Response" section of [1],

Unless the Redirection URI is invalid, the Authorization Server returns the Client to the Redirection URI specified in the Authorization Request with the appropriate error and state parameters. Other parameters SHOULD NOT be returned.

[1] https://openid.net/specs/openid-connect-core-1_0.html#AuthError

Duplicate: https://github.com/wso2/product-is/issues/4018


Tags with 2.1.0a39

Description
Hello,
don't know if it's a bug or if it's just not implemented (yet).
Currently I don't see the set tags anywhere, also the tags created under "Tags" can't be selected either.
Furthermore I get the message "TypeError: Cannot read properties of undefined (reading 'id')" when changing the tags of a document.
Also I can not click on the Pinned Tags.

Expected
Add/ Remove Tags on Folders + Documents and of course see this tags :)
Actual
Tags couldn't be selected and are not visible.
Info:

OS: Win 11
Browser: Edge
Database:  Postgres 14
Papermerge Version: 2.1.0a39

@w4tzmann,
After you complete typing tag name ("Test" - in your example) you need press "Space" or "," (comma) character.
Here is a animated example of adding tags (I press space key to "complete tag creation").

Also I can not click on the Pinned Tags.

Same here. That's a bug.

Furthermore I get the message "TypeError: Cannot read properties of undefined (reading 'id')" when changing the tags of a document.

Can you get more specific here ? I cannot reproduce this part.

Fuck, I knew I had forgotten something.... Thank you!
After pressing Space the tags working (I have tried Enter and Tab.. my bad, sorry).
And maybe it would be good to add an case insensitve option.

Same here. That's a bug.

Opening the URL (https://papermerge-url/search?tags=Test), give me a white page, Edge Dev Tools reports Error 500 strict-origin-when-cross-origin

Can you get more specific here? I cannot reproduce this part.

Be stuipid like me 😁 :
Enter a Tag (without space or comma) > Submit
Now open it again and delte the "tag" and press Submit again

@w4tzmann,
Now, I was able to reproduce it - thanks!
In animated gif below I press "enter" key which sends server side "create tag" without tag name. Actually :thinking: when pressing enter it would be correct to create the tag - at least it would avoid confusion.


fix type declaration

Closes #207

This was the fix I was going to push as a pull request, fixes eta usage for me.


Add calculation function for tweet padding to remove static values

Description
Add a function to calculate the amount of padding necessary to more modularly and accurately calculate the the tweet lengths required. This would remove the reliance on the static tweet padding setting.

There's no point in doing this. It would be needlessly complicated, and we should never be sending more than 99 tweets in a single thread, so we will just be adding a check capping the tweet list length off at len == 99 instead.

we should never be sending more than 99 tweets in a single thread

You say that now... :wink:

This is true. I guess I'll just add an environment variable for this actually, and a quick calculation based on the number of digits for the max tweet thread length. That way we don't have to do any wonky re-calculating and shifting words around between tweets after we get a list we can check the length against. Still a little cludgy but we're only loosing a couple characters this way instead of like 10-15.


[Bug] The status does not change after the job submission fails

Environment Description

StreamX Version: v1.2.2
JVM version (java -version):java 8
OS version (uname -a if on a Unix-like system): centos

Bug Description
An exception is thrown after the job is submitted，the streamx job status keeps starting after  job failed
How to Reproduce
1 . create flink myql cdc sql job ，and mysql user password is incorrect
2.  run job with  remote(standalone) mode
3 . mysql connection failure throws exception  and causes the job to fail
4.streamx job's state  keeps starting

fixed. please use streamx 1.2.2+


Update README.md (Dead link)

The link https://thoughtbot.com/ios?utm_source=github doesn't work anymore

Nice catch! Thanks!


Fix matchLabelKeys example yaml

The spec.template of Deployment YAML is a PodTemplateSpec, so it should be spec.template.spec.affinity instead of spec.template.affinity.
$ k explain deploy.spec.template.affinity
GROUP:      apps
KIND:       Deployment
VERSION:    v1

error: field "affinity" does not exist

$ explain deploy.spec.template.spec.affinity
GROUP:      apps
KIND:       Deployment
VERSION:    v1

FIELD: affinity <Affinity>

...

This is correct.
/lgtm

/lgtm
Good catch!

Preview of updated page: https://deploy-preview-45111--kubernetes-io-main-staging.netlify.app/docs/concepts/scheduling-eviction/assign-pod-node/
I verified that affinity is under deployment.spec.template.spec.affinity
/approve


Try out symlog scale on gender by language plot

symlog scale is linear near zeros and logarithmic for higher values, it might turn out to be good scale for our plots.

While symlog isn't natively supported by Bokeh, having a mixed scale (log on y-axis and linear on x) is turning out to be pretty good.

Pull request #69

Fixed. log Y-axis and linear X-axis does the trick.


Invalid Fortran in Process Library

@tclune - is this valid Fortran?
if (present(a) .and. associated(a)) then

Should this be:
if (present(a)) then
   if (associated(a)) then

Originally posted by @rmontuoro in https://github.com/GEOS-ESM/GOCART/pull/68#discussion_r684301009

Adding this in:
@rmontuoro I talked with @tclune and he agrees this is an issue. For now we will approve (since Intel is at least "working") and merge what is here but I'll make an issue to fix this. I don't want to try and untangle this:
https://github.com/GEOS-ESM/GOCART/blob/58af7747eba91dc597c65485a5e4e781cb25deca/Process_Library/GOCART2G_Process.F90#L3551-L3558
on a Friday afternoon!

I understand and I'm aware that it is working with Intel, but it should be addressed soon.


Logos / themeing

Some updates on the logos/feedback method!
Update to the AnVIL Collection link

@ehumph thanks!!


home-assistant: handle packages with extra requirements

Description of changes
https://github.com/NixOS/nixpkgs/pull/167560#issuecomment-1090978534

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 167630 run on x86_64-linux 1

23 packages built:

ghost
home-assistant-component-tests.androidtv
home-assistant-component-tests.bluetooth_le_tracker
home-assistant-component-tests.samsungtv
home-assistant-component-tests.tradfri
python310Packages.adb-shell
python310Packages.androidtv
python310Packages.meshtastic
python310Packages.pure-python-adb
python310Packages.py3rijndael
python310Packages.pygatt
python310Packages.pytradfri
python310Packages.samsungctl
python310Packages.samsungtvws
python39Packages.adb-shell
python39Packages.androidtv
python39Packages.meshtastic
python39Packages.pure-python-adb
python39Packages.py3rijndael
python39Packages.pygatt
python39Packages.pytradfri
python39Packages.samsungctl
python39Packages.samsungtvws


Does not work in CS2

When using csgo-demoinfo on demos created in cs2 an error will occur:

CDemoFile::Open: crc_test.dem has invalid demo header ID.

When using csgo-demoinfo on demos created in cs2 an error will occur:

CDemoFile::Open: crc_test.dem has invalid demo header ID.

Well it happened to me as well. I checked the hexdump of the demo and found out that there were filled many lines before the header line ID, which should be the first seven bytes of the file (as I can see from my file). Check it out and tell us. For some reason your file is malformed

When using csgo-demoinfo on demos created in cs2 an error will occur:

CDemoFile::Open: crc_test.dem has invalid demo header ID.

Well it happened to me as well. I checked the hexdump of the demo and found out that there were filled many lines before the header line ID, which should be the first seven bytes of the file (as I can see from my file). Check it out and tell us. For some reason your file is malformed

In my case I was extracting 3 files from a .rar. I realized that only the first file was being correctly extracted, I mean, without the filling 0s. So I extract each file at a time and worked just fine.

I move to https://github.com/markus-wa/demoinfocs-golang
It seems to be a lot faster and getting way more love then this repository.


Add with_link and without_link - to match on span links

Thanks for being quick to respond on these contributions @dmathieu !
I don't have any other contributions I plan to make, would it be possible to get a new version of the gem released? Is there anything I can do to help with that? Much appreciated.

I have released 0.0.4.


Unable to access Viptela-Shell from script for version 20.12

Manage Password (Note: Tool doesn't support passwords containing "!") :
Traceback (most recent call last):
File "newsure.py", line 1954, in
version, version_tuple = vManageVersion()
File "newsure.py", line 316, in vManageVersion
version_tuple =tuple([int(i) for i in version_tuple])
File "newsure.py", line 316, in
version_tuple =tuple([int(i) for i in version_tuple])
ValueError: invalid literal for int() with base 10: ''
vmanage:~$
def showCommand(exec_mode_command):
exec_mode_command = exec_mode_command+'\n'
exec_mode_command = exec_mode_command.encode()
p = subprocess.Popen('viptela_cli'.format(args.username), shell=True, stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
p.stdin.write(exec_mode_command) #passing command
stdOutput,stdError = p.communicate()
p.stdin.close()
return stdOutput.decode()
Manage Password (Note: Tool doesn't support passwords containing "!") :

/home/admin/newsure.py(1955)()
-> version, version_tuple = vManageVersion()
(Pdb) print(showCommand('show version'))

(Pdb) version=showCommand('show version')
(Pdb) print(version)
(Pdb)

I have the same issue, also running Manager version 20.12.3.
Traceback (most recent call last):
File "py3_sure.py", line 1953, in
version, version_tuple = vManageVersion()
File "py3_sure.py", line 315, in vManageVersion
version_tuple =tuple([int(i) for i in version_tuple])
File "py3_sure.py", line 315, in
version_tuple =tuple([int(i) for i in version_tuple])
ValueError: invalid literal for int() with base 10: ''


[DOCS] Rename Flink Table Store to Apache Paimon (Incubating) in docs Connectors for Hive SQL Query Engine

Why are the changes needed?

To update docs.
Rename Flink Table Store to Apache Paimon (Incubating) and update in docs under Connectors for Hive SQL Query Engine .
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

Codecov Report

Merging #4607 (695d837) into master (cee2f00) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4607      +/-   ##
============================================
- Coverage     53.34%   53.32%   -0.02%
  Complexity       13       13
============================================
  Files           577      577
  Lines         31584    31584
  Branches       4248     4248
============================================
- Hits          16847    16841       -6
- Misses        13152    13155       +3
- Partials       1585     1588       +3

see 6 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Thanks, merged to master/1.7


[SPARK-34787] Option variable in Spark historyServer log should be displayed as actual value instead of Some(XX)

What changes were proposed in this pull request?
Make the attemptId in the log of historyServer to be more easily to read.
Why are the changes needed?
Option variable in Spark historyServer log should be displayed as actual value instead of Some(XX)
Does this PR introduce any user-facing change?
No
How was this patch tested?
manual test

Can one of the admins verify this patch?

@dongjoon-hyun  done, please help to review it when you are free, thanks!

@dongjoon-hyun This issue has been blocked for a while, could you please help to review it , thanks a lot!

@dongjoon-hyun  redirect to #32189 , the branch in this pr was too old, sorry.

No problem. Thank you for opening a new one. I'll review there, @kyoty .


Fix auto-deploy

It still displays version 1.0.1 in the Chrome web store.
Also noticed a thing. The auto-deploy creates new tags, but it doesn't update the version in manifest.json.

// @paulmolluzzo

@sindresorhus so, two things. First, this won't auto-generate a tag, it just goes through the build step if it's a tagged version. Deployment is dependent on a purposeful release. Second, we still need to manually increment the version number (you would do it in the commit that gets tagged). I can write in a sed command to find/replace the version with the tag number, but it won't get committed by Travis CI back to the repo so that doesn't seem right.
What we'd want to do is modify the manifest when merging a PR (or commit directly to master) so we have a version. Or just make a commit like "Increment Version", then tag that commit and it'll release it that way.
Any thoughts? If you want to have hat sed in he deploy we can do that, but I'd prefer to deploy the  master version, not a modified version of master. It'll be confusing if they don't match.

I'm good with the one tagging first doing a commit to increment the version. Don't think we need any automation for that.

Try that now then. Just commit the increment on master, tag that commit and push. We're on v1.0.4, but with the popover we might want to do v1.1.0 since it's a function. If it doesn't work I can take a look tonight.

Yes, seems to work now :)
@hkdobrev @DrewML Make sure bump the version in manifest.json and commit before tagging.

Glad that worked and sorry I didn't make that clear before.


Strapi plugin deployment and Data model update

Description
After the changes are made for the search functionality on Tag, keyword, and location is done. The enhanced Strapi plugin needs to be deployed on all instances.
Update the data model in all the instances.
Validate the deployment using Postman collection.
Goals

[ ] Strapi plugin deployment on all instances.
[ ] Data model enhancement on all instances.

Expected Outcome
Updated strapi plugin and data model on all instances of Strapi.
Acceptance Criteria

[ ] Updated data model on all instances.
[ ] Update strapi plugin on all instances.
[ ] Validate the deployment using postman collection.
[ ] Validate that data model is reflected.

Current Status:
Deployed Updated Strapi Plugin on following isntance.

MIT-bpp-tourism
MIT-bpp-healthcare
MIT-bpp-retail
MIT-bpp-energy

@em-abee was working on MIT-bpp-hotel so haven't updated that instance.
Data Model Changes was done only in MIT-bpp-tourism . As for other instances didn't had app wasn't allowing to update
This needed to be done on other instances also.
cc: @mayurvir @faizmagic

Adding extra 4 hours to the estimate as time is needed to figure out on how to grant permission to the user to update the data model. And re-deploy all instances again except MIT-bpp-tourism.
cc: @mayurvir @faizmagic @vishi24


i'm using react-native 0.33. but npm install and import react-native-lightbox. but not found this module to using

I don't understand the issue, reopen if you have more information.


[ui.mask]: Adding new option ui-mask-raw to enable/disable binding the raw or view value to the masked input model.

Following the implementation proposed by @Snede in #199 i improved the implementation of this extremely needed feature.
I added a global configuration in the ui.mask module called uiMaskRaw (as suggested by @ProLoser).
If it is set to true (default) the behavior is the same that we have today, the raw value is assigned to the model.
If it is switched off (false) the view value (masked value) is assigned to the model.
I also observes the ui-mask-raw attribute to override this configuration locally, as follows:
<input type='text' ui-mask='(999) 999-9999' ui-mask-raw='false' />

That way you can set the global behavior and the individual input behavior.

This PR seems to be obsolete. Moreover UI.Utils modules was split in individuals repositories. If still valid, please consider re-submitting on the dedicated repository.
See the README for details.


Option 2 needs to be updated to reflect the current user experience

This document is currently out of date and does not reflect the user experience after the CDN was switched from Verizon to Edgio.
For Option 2, there is no drop menu to select the path, you must manually enter it in.
In your example, this starts with /8099D8E/
Another caveat is in the upper right portal of the Edgio portal, it shows your account number but the leading "80" is missing.
For your example, the Edgio portal would only display (99D8E)  but you would need to add "80" in front of it for the first part of your source and destinations in the rewrite rule.
Reference Azure Support Case #2309070040012158

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: be0f8fa5-b31c-17fc-64ee-e1b77f4f1389
Version Independent ID: 24461bb6-a8ac-65e8-db24-fd359cab4130
Content: Using Azure CDN with SAS
Content Source: articles/cdn/cdn-sas-storage-support.md
Service: azure-cdn
GitHub Login: @duongau
Microsoft Alias: duau

@airmnichols
Thanks for your feedback! We will investigate and update as appropriate.

@airmnichols
Thank you for the feedback here. I am linking this issue to a similar issue raised by you here #114448 which is currently assigned to Author for their review.
FYI @duongau


Router fails when jsong response includes arrays

When the jsong response includes arrays, the router mistakenly converts these to undefined atoms. I have created a test to demonstrate the issue. I wanted input from the team before submitting a pull request with my test.
it('should allow arrays in jsong response', function (done) {
	var routeResponse = {
	   "jsong":{
		  "ProductsById":{
			 "KMW39254":{
				"SellingPoints":[
				   "Charges USB powered devices with micro or mini ports.",
				   "Charges in the car or on AC wall outlet.",
				   "Ultra-small and low profile.",
				   "Car charger is one amp-ready for quick smartphone charging."
				]
			 }
		  }
	   }
	};
	var router = new R([
		{
			route: "ProductsById[{keys}][{keys}]",
			get: function (pathSet) {
				return Observable.of(routeResponse);
			}
		}
	]);
	var obs = router.get([["ProductsById", "KMW39254", "SellingPoints"]]);
	var called = false;
	obs.subscribe(function (res) {
		expect(res).to.deep.equals(routeResponse);
		called = true;
	}, done, function () {
		expect(called, 'expect onNext called 1 time.').to.equal(true);
		done();
	});
});

When I run the test, it fails as shown below.
1) Router Unit Core Specific should allow arrays in jsong response:

  AssertionError: expected { Object (jsong) } to deeply equal { Object (jsong) }
  + expected - actual

   {
	 "jsong": {
	   "ProductsById": {
		 "KMW39254": {
  -        "SellingPoints": {
  -          "undefined": {
  -            "$type": "atom"
  -          }
  -        }
  +        "SellingPoints": [
  +          "Charges USB powered devices with micro or mini ports."
  +          "Charges in the car or on AC wall outlet."
  +          "Ultra-small and low profile."
  +          "Car charger is one amp-ready for quick smartphone charging."
  +        ]
		 }
	   }
	 }
   }

Thanks @jhusain $type: "atom" helped

@bcardi, I had the same problem, here's decision: https://gist.github.com/designeng/f00de5e04f27773eaf5c#file-itemsrouter_improved-js-L1-L20

@jhusain, +1 for a better error message. Otherwise we have MaxRetryExceededError.


[5.3] Arr::where() - Simplifies and makes it faster

ARRAY_FILTER_USE_BOTH it's a new flag added to PHP 5.6.

Hum. That's sad ... Breaks just HHVM. 😢

Hum. HHVM 3.9 works fine.
https://3v4l.org/STFXS

That's really HHVM's problem I think.

Yeah, I'm with you.


Various typos and wording fixes

fastq capitalized to FASTQ
Fixed some spelling errors
Two slight rewordings for readability

+1 when fixing 113 in doc/source/api/metadata.rst

Thanks @jmarshall, I did mean to add "make reference". I changed the wording from "reference" to "refer".
-Durations are the most common form of time intervals. They do not reference to
 +Durations are the most common form of time intervals. They do not refer to


Add test(s) for ModCfg::apply_presets()

It's a more complex function that will be a little (but not too much) more difficult to write tests for. Just trying to decide how to go about it...

Added in commit 930eb008.


Add grunt-cli to dev dependencies

Grunt-cli is required for building, but is missing in package.json

Should be closed, fixed with cf9204548980db3750139527663dbd9119d3e661.


Docker images not same as shown in install instructions

Instead of the docker images you mention in the install instructions Docker Images are not the same that are in the ./Docker folder.
Currently I see the following docker images in this folder:

ElasticSearch (with Beats in sub folder)
Jaeger
OpenSearch

Interesting demo! I'm curious about your setup. Could be helpful for a new large-scale project I'm starting.

Hello @philippjbauer thx I will correct this today! I made some changes and forgot to update some maths....
Also i moved all app to folder /src before all was on root...
Sorry for that...

Cool! I'm looking forward to run and poke at it a little bit!

Sorry to hijack the thread... @damikun this repository is awesome. It's called a workshop is there more info on it? As in, is this a scheduled workshop to follow?

@Depechie Thx for writing I have my system where I use this architecture so I make it opensource and more stuff will come out.. This App has officially only this parts (listed down) for now.. But in short time this will be updated with new topics.. A problem is I'm not sure if more stuff will not overkill understanding.. There will be maybe shared record from it.. Unfortunately it is not online kind of workshop..

Configure Logging
Configure Telemetry
Configure Identity
Configure Monitoring


Refactor(options): move clusterPane into options field

Hi,
Follows PR https://github.com/Leaflet/Leaflet.markercluster/pull/819 which introduced clusterPane option.
This PR proposes to move the initialization of clusterPane from the initialize function into the dedicated options field, like most other options.
There is no real need to set it "manually" during initialization phase, instead of letting Leaflet class mechanism retrieve it automatically.
The case of iconCreateFunction option is different because it refers to a function that is defined in the same class. Therefore this function is not accessible until Leaflet finishes preparing the class.
But even that could be worked around, for example by moving that function to file context (it is actually like a static function, it is not related to an instance / it does not depend on this), so that we can refer to it from the options field.
By doing so, the options section would become slightly more easy to understand, but there would be a minor internal change: _defaultIconCreateFunction would no longer be modifiable, but I really doubt someone actually had to modify that default function (iconCreateFunction functionality would still be preserved).
Please let me know should you think that would be worth refactoring as well.

We'll need to mark this as a potentially breaking change, as your change in the example shows.
I doubt there are many codebases this would affect though.
Send over one with the iconCreateFunction change too, pull it out of the class and we can do the same :+1:

Released in 1.2.0


[BUG]: Errors occurred during the pipeline run, see logs for more details.

Describe the bug
"Sometimes, running the command python3 -m graphrag.index --root ./ragtest results in the error 'Errors occurred during the pipeline run, see logs for more details,' even though no configuration changes were made. This issue may occur after restarting the computer. I have tried deleting the original environment and creating a new one. Sometimes it works well, and sometimes it doesn't."
The previous model was running smoothly and had successfully answered my questions. And my Ollama is functioning properly and the model has been downloaded.
I am a beginner, so I might not understand everything fully. Please bear with me

settings.yaml:

log: (ragtest/output/20240716-034934/reports/indexing-engine.log)

indexing-engine.log
Steps to reproduce

Run Lm-studio

chmod +x LM_Studio-0.2.27.AppImage

python3 -m graphrag.index --root ./ragtest

Expected Behavior
I expect the LLM and embedding to process my data correctly
GraphRAG Config Used
No response
Logs and screenshots
No response
Additional Information

GraphRAG Version: 0.1.1 ( pip install graphrag )
Operating System: Ubuntu 22.04
Python Version: 3.12.4
llm: ollama/gemma2:latest
embeddings: lm-studio (nomic-embed-text-v1.5.Q5_K_M.gguf)

To: Jumbo:
how to run chmod +x LM_Studio-0.2.27.AppImage in windows 10?
I can not find LM_Studio-0.2.27.AppImage file in LM_Studio installation directory. If this is a *.exe file?
thanks

To: Jumbo:
I use your setting.yaml, run LM_studio, but python -m graphrag.index --root ./ragtest could not run correctly.
And suggestion about setting.yaml?
in logs, api_key is not recognized.
"llm": {
"api_key": "REDACTED, length 6",
"type": "openai_chat",
"model": "gemma2:latest",
Thanks
Quanling.

To: Jumbo: how to run chmod +x LM_Studio-0.2.27.AppImage in windows 10?
I can not find LM_Studio-0.2.27.AppImage file in LM_Studio installation directory. If this is a *.exe file?
thanks

I use Lm_studio on an Ubuntu system. You can download the Windows version from the official website: https://lmstudio.ai

To: Jumbo: how to run chmod +x LM_Studio-0.2.27.AppImage in windows 10?
I can not find LM_Studio-0.2.27.AppImage file in LM_Studio installation directory. If this is a *.exe file?
thanks

I use Lm_studio on an Ubuntu system. You can download the Windows version from the official website: https://lmstudio.ai

I use windows10. In windows, I just run LM_Studio, I think  this is OK.

To: Jumbo: I use your setting.yaml, run LM_studio, but python -m graphrag.index --root ./ragtest could not run correctly.
And suggestion about setting.yaml?
in logs, api_key is not recognized. "llm": { "api_key": "REDACTED, length 6", "type": "openai_chat", "model": "gemma2:latest",
Thanks

I don't know if you have installed Ollama. I referred to this video: https://youtu.be/BLyGDTNdad0?si=Pvx1og9aD_5fmZa3

I installed graphrag in Docker to avoid this bug.
I am using the official NVIDIA image (CUDA =12.2, Ubuntu22.04, devel)
By the way, LM_Studio can be replaced with llama.cpp.

To: Jumbo: I use your setting.yaml, run LM_studio, but python -m graphrag.index --root ./ragtest could not run correctly.
And suggestion about setting.yaml?
in logs, api_key is not recognized. "llm": { "api_key": "REDACTED, length 6", "type": "openai_chat", "model": "gemma2:latest",
Thanks

I don't know if you have installed Ollama. I referred to this video: https://youtu.be/BLyGDTNdad0?si=Pvx1og9aD_5fmZa3

Hi,Jumbo:
thanks.
in ollama directory, I run
ollama pull gemma2:9b
ollama run gemma2:9b
it works.
but the problem is that when running below command
curl http://localhost:11434/v1/chat/completions
the result is:
404 page not found
this means that gemma2 port is not recognized.

To: Jumbo: I use your setting.yaml, run LM_studio, but python -m graphrag.index --root ./ragtest could not run correctly.
And suggestion about setting.yaml?
in logs, api_key is not recognized. "llm": { "api_key": "REDACTED, length 6", "type": "openai_chat", "model": "gemma2:latest",
Thanks

I don't know if you have installed Ollama. I referred to this video: https://youtu.be/BLyGDTNdad0?si=Pvx1og9aD_5fmZa3

Hi,Jumbo: thanks.
in ollama directory, I run ollama pull gemma2:9b
ollama run gemma2:9b it works.
but the problem is that when running below command
curl http://localhost:11434/v1/chat/completions
the result is: 404 page not found
this means that gemma2 port is not recognized.

Please refer to the official way：https://github.com/ollama/ollama/blob/main/docs/api.md
For example:
curl http://localhost:11434/api/chat -d '{
"model": "gemm2:latest",
"messages": [
{ "role": "user", "content": "hi" }
]
}'

Consolidating alternate model issues here: https://github.com/microsoft/graphrag/issues/657


[WIP] golang: L4 network extension

Commit Message: l4 golang extension
Additional Description: allow using golang to write envoy network filter
Risk Level: low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

/wait on main merge and CI

The L4 extension is not going to replace the L7 one. The different between them is just like the different between envoy's Http::StreamFilter and Network::Filter.
And we do need a separate sandbox for L4, I'll work on this.

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

@phlax @wangfakang @wbpcode @doujiang24 PTAL

@antJack please resolve merge conflicts
Ping @doujiang24 @wangfakang for final review

Looks like this needs a main merge, and needs some comments addressed
/wait

/retest

Ping @doujiang24 @wangfakang

/retest

/retest

ping @wangfakang @doujiang24

/retest

ping @doujiang24 @wangfakang

/retest

ping @doujiang24 @wangfakang

LGTM, as the first step, @wangfakang could take another look.

ping @doujiang24 @wangfakang

PTAL @doujiang24 @wbpcode

@antJack this PR is pretty huge would you mind separating out the sandbox to its own PR please

@antJack this PR is pretty huge would you mind separating out the sandbox to its own PR please

ok

I've placed the sandbox here: https://github.com/antJack/envoy/pull/1
once this pr is ok, I will re-open another one into the envoyproxy:main

once this pr is ok, I will re-open another one into the envoyproxy:main

cool, feel free to open it WIP based on this PR - im happy to start reviewing

cool, feel free to open it WIP based on this PR - im happy to start reviewing

done, I open up a wip with sandbox here: https://github.com/envoyproxy/envoy/pull/27762

This is a huge PR orz. So, I think I can only review it on the weekend. orz
cc @StarryVae could you help me to take a first pass when you have free time?

yeah, thanks.

Mostly commenting because this is out of review SLO (but I see that's been explained already).
But also, might be worth addressing the merge conflicts while you wait for reviewer availability.

@wangfakang @doujiang24 @phlax @wbpcode @StarryVae
Could you please help take a look at this huge PR again?  I would be very grateful for your help.

@wbpcode @phlax I think it's good enough for a first iteration, maybe we could merge it and improve it later?
Now, @antJack have to resolve conflicts again and again, since l7 is also iterating quickly.

@mattklein123 would you mind taking a pass at this ?


When the VM changes state, the context menu of the lifecycle actions is not updated.

Description
When the VM changes state, the context menu of the lifecycle actions is not updated, so a VM has the same actions of the previous state and cannot be transitioned. The VM must be un-selected and re-selected to be updated.
Expected behavior
A clear and concise description of what you expected to happen.
Details

Affected Component: Fireedge
Hypervisor: KVM
Version: 6.5

Progress Status

[ ] Code committed
[ ] Testing - QA
[ ] Documentation (Release notes - resolved issues, compatibility, known issues)

duplicated by #6081


Ignore .git for pdk build

Inspired by https://github.com/puppetlabs/puppet-modulebuilder/blob/main/lib/puppet/modulebuilder/builder.rb#L8-L17
Fix #127

@promasu ah yea this must've happened when we switched to Github Actions for our releases. This makes sense, thanks!


[wip] make everything except extensions autoloadable

@gmcgibbon @rafaelfranca 👋🏻 FYI this is a follow-up after your original autoload work but it uses zeitwerk. I need to tweak zeitwerk loader so that it knows how to deal with extension files (or just move files around a bit). Overall, this looks very promising. Notice that it uses dry-core/configurable/types from main here because those are now autoloadable via zeitwerk as well. Once this one's working too, I'll make dry-validation autoloadable and then we could test it all out 😅 Assuming everything works fine, I'll release all of the things and we should end up with a major boot time speed up ⚡

🎉

I closed this this since it was done in other PRs eventually


[sqla] Adding check for invalid filter columns

CATEGORY
Choose one

[x] Bug Fix
[ ] Enhancement (new features, refinement)
[ ] Refactor
[ ] Add tests
[ ] Build / Development Environment
[ ] Documentation

SUMMARY
This PR fixes an issue where if you specified an invalid column (achievable in the URL) in a simple filter, i.e., not custom SQL, then the filter was simply ignored and the the query would execute sans the filter with no clear indication to the user that the filter wasn't being applied.
This PR applies the same logic as invalid metrics and raises an exception if the column is invalid. Note I added unit tests to cover both the invalid metric and column use cases.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE

AFTER

TEST PLAN

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

REVIEWERS
to: @michellethomas @mistercrunch @williaster

Codecov Report

Merging #7888 into master will decrease coverage by 8%.
The diff coverage is 35.29%.

@@            Coverage Diff             @@
##           master    #7888      +/-   ##
==========================================
- Coverage   73.78%   65.78%   -8.01%
==========================================
  Files         107      461     +354
  Lines       11613    22168   +10555
  Branches        0     2425    +2425
==========================================
+ Hits         8569    14583    +6014
- Misses       3044     7464    +4420
- Partials        0      121     +121

Impacted Files
Coverage Δ

superset/connectors/sqla/models.py
82.67% <35.29%> (+0.2%)
:arrow_up:

superset/assets/src/components/Checkbox.jsx
100% <0%> (ø)

...ations/deckgl/layers/Polygon/PolygonChartPlugin.js
0% <0%> (ø)

...ets/src/dashboard/components/dnd/DragDroppable.jsx
94.59% <0%> (ø)

...c/visualizations/deckgl/layers/Polygon/Polygon.jsx
0% <0%> (ø)

superset/assets/src/components/EditableTitle.jsx
81.53% <0%> (ø)

superset/assets/src/setup/setupPlugins.js
0% <0%> (ø)

...t/assets/src/components/InfoTooltipWithTrigger.jsx
41.66% <0%> (ø)

.../src/dashboard/components/UndoRedoKeylisteners.jsx
9.52% <0%> (ø)

...ts/src/explore/components/ExploreActionButtons.jsx
100% <0%> (ø)

... and 345 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d65b039...0a1ea2e. Read the comment docs.

@williaster I addressed your comments.

@mistercrunch I addressed your comments.


Add chart type: "Custom FusionChart"

Description
This change implements an additional chart type: "Custom FusionChart". This is useful as the FusionChart library has many options which are currently not configurable using the Appsmith interface.
The PR includes a dependency on @fusioncharts/powercharts which I intended to support "Power charts" (https://www.fusioncharts.com/charts#powercharts) though maybe we can opt for leaving out this dependency.
Some notes about the changes:

I have not yet added any documentation, I guess I should right?
Currently the whole chart will re-render on an update which especially on charts with relatively large amounts of data is not so great. It's implemented like this because you can of course update the chart configuration part and not only the data part so only updating the data is not enough on update. Maybe it can be a bit smarter in that we check if the update only changed something in .dataSource.data then we only update the data.
I didn't fully understand how the error messages from the validators work, I did my best trying to make it as similar as possible to the existing validators, just so you know.
For the chart name there is a preference for the chart name text field over the .dataSource.chart.caption field. If the chart name text field is not filled but the .dataSource.chart.caption value is it will use that one though.

Fixes #2647
Type of change

New feature (non-breaking change which adds functionality)
This change requires a documentation update

How Has This Been Tested?
This change can be tested by creating a new chart, select the "Custom FusionChart" option and paste the following configuration.
This should create a chart that would not be possible to configure without this chart type. Additionally other chart types can be tested from the FusionChart documentation (https://www.fusioncharts.com/dev/chart-attributes).
{{{
  type: "column3d",
  dataSource: {
    chart: {
      caption: "Countries With Most Oil Reserves [2017-18]",
      subCaption: "In MMbbl = One Million barrels",
      xAxisName: "Country",
      yAxisName: "Reserves (MMbbl)",
      numberSuffix: "K",
    },
    data: [
      {
        label: "Venezuela",
        value: "290"
      },
      {
        label: "Saudi",
        value: "260"
      },
      {
        label: "Canada",
        value: "180"
      },
      {
        label: "Iran",
        value: "140"
      },
      {
        label: "Russia",
        value: "115"
      },
      {
        label: "UAE",
        value: "100"
      },
      {
        label: "US",
        value: "30"
      },
      {
        label: "China",
        value: "30"
      }
    ]
  }
}}}

This should create the following chart:

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

@all-contributors please add @zegerhoogeboom for code

Hi @zegerhoogeboom These fixes have been release.
This, unfortunately, took a long time to be released as there were many changes introduced over time in the property pane enhancements which needed to be fixed, evaluated and tested. So, we had to keep going back to the branch before it was ready to be released.
We really appreciate your contribution, it has made a high impact on Appsmith and hope to see more contributions from you in the future.

Hi @riodeuno that's awesome!
I'm happy it's released and no worries about the time it took, I've been using the custom fusion charts with pleasure on my own instance for a while now so hope it will be useful to other people wanting to do more advanced charting like me.
We're actually also using 3D charts through Plotly.js within Appsmith which we migrated from a custom made internal tool specifically for that and it's a lot nicer now in Appsmith. I'm happy to contribute it in a PR if you're open for more plotting options but I think I would need some suggestions on how to best do it, currently it's simply loading the Plotly dependency in the index.html meaning it's loaded on any Appsmith page even if Plotly is not used (which will be the case for the majority of users). It would be better to dynamically load the dependency only when it's needed but I'm not sure how to do that.
Sorry for the detour about Plotly, I think I'll reach out on the Discord server once I have a merge-able version for feedback :-)!

Let me get back to you on that I think next week @areyabhishek because at the moment neither is easy (the Appsmith instance is behind a company SSO reverse proxy so not directly reachable). I think I can make screenshots work, just not immediately. I'll get in touch :v:


Compute plot level information from UAV data

Description

Use polygons here: to subset calibrated UAV data to plot level data that can be inserted into BETYdb: https://terraref.ncsa.illinois.edu/bety/api/beta/sites?key=
Add methods as necessary to

github.com/terraref/documentation
cross reference these in https://terraref.ncsa.illinois.edu/bety/methods

Add variables as necessary to https://terraref.ncsa.illinois.edu/bety/variables/new

first search https://betydb.org/variables; we can move existing variables as needed

Create a csv called 'traits.csv' that includes the following columns

sitename (this is the name of the plots, format is MAC Field Scanner Field Plot *** Season 2)
trait name (e.g. NDVI etc. once you have)
n (optional, can be 'effective n' if appropriate)
SD (optional, if available, can be defined in methods documentation)
methods.name

Context
This can be used to insert UAV data into BETYdb.
Further Suggestions / Request for Feedback

Documentation is here: https://pecan.gitbooks.io/betydbdoc-dataentry/content/trait_insertion_api.html

note that the most of the other metadata (site, cultivar, treatments, etc) is already in the database or will be entered separately.

Data can be added to the traits table using either the csv or json format (@gsrohde can help with this)
I (@dlebauer) can help show you how to define the variables and methods

Sounds great ! we'll work on this once we have the finalized shapefile and orthomosaicked UAV data.

@Mamatemenrs and @remotesensinglab could you please create a separate issue defining the deliverables for Rick and his employee what they need to provide (e.g. georeferenced geotiff files for each sensor x flight combination?

Is this waiting on #188 ?

@dlebauer: My understanding on this issue is that Rick Ward wanted to do all processing and upload the summary  statistics to the server.  If this is not the case, please advise, we can do it. Maybe, we should coordinate a meeting with Rick and see what needs to be get done and what he prefers in terms of our involvement. This is an interesting area for my research and pubs as well, so good to talk to Rick on this.

@rickw-ward -  are you planning to do the processing and uploads?  Do we need a teleconference to discuss?

Rick has confirmed that he will do processing and upload

@rickw-ward any updates on this?

Update August 8:  the 2016 Maricopa UAV data needs to be re-run in Pix4D to correct some geo-referencing alignment issues before accurate orthomosaics for each flight are ready to go to ROGER.  This is in process and Rick thinks that corrected sorghum season 2 orthomosaics for 4 spectral flights and 1 thermal flight can be uploaded to a Google directory later today or tomorrow.
Plot-level summary statistics are still the end-goal, but the first near-future goal is to complete the full-field orthomosaics that can go to ROGER then to Clowder.

@dlebauer please follow up

Rick Ward and Sara Harders have re-processed 2016 UAV data in Pix4D and to my understanding orthomosaics are ready.  Is there any standardized way of naming UAV orthomosaics and associated metadata info?  Did KSU establish a method?

Metadata
Make sure this page is up to date: https://terraref.gitbooks.io/terraref-documentation/content/user/protocols-UAV.html
(it can be edited here: https://github.com/terraref/documentation/edit/master/user/protocols-UAV.md)
File Organization
The most important is that everything is organized consistently. It is easy to reorganize and rename as long as the same basic conventions are kept across dates / sensors / data products.
Good enough
organize into directories like
{level}/{sensor}/{date}/{filename}

where

{level} is optional, the important part is that the raw data should be separate from the derived datasets
{sensor} can be the sensor name (e.g. rededge) or data product (e.g. ndvi)
{date} should be in the format YYYY-MM-DD
{filename} can be whatever you have, as long as it is consistent

Not Good Enough
Hopefully it is clear where the current organization can be improved:

The convention we are using for the Field Scanner
This is what we are using for the Field Scanner data. The following would be consistent with our approach to the Field Scanner data, which is defined in https://github.com/terraref/terrautils/blob/master/terrautils/sensors.py (but needs to be documented somewhere, consider this the first draft!)
The format of the directory and filenames is:
directory: {Level}/{sensor}/{date}/{timestamp}/',
filename: {sensor}_{L}_{station}_{timestamp}_{dataproduct}{opts}.{ext}'

where:

{Level} is one of "raw_data", "Level_1", Level_2, ...
{sensor} is the name of the sensor or data product
{date} should be in YYYY-MM-DD format
{timestamp} in the format YYYY-MM-DD_HH-MM-SS. This is optional
{L} is level, but shortened to L1, L2, ...
{station} would be one of ua-mac, ksu, or ...
{data product}
{opts} might be left or right

In the case of the RGB sensor, one of the fullfield stitched files is called:
Level_1/fullfield/2017-05-29/fullfield_L1_ua-mac_2017-05-29_rgb.tif

Level_1 includes the georeferenced stitched images / point clouds. Level 2 would be any further derived products, for example, an NDVI map computed from a Level 1 product that contains Red and Near IR bands or a height map derived from a Level 1 point cloud.

Hi David,
Can you provide a link to the Gdrive folder in the screen shot?
Thanks,
Geoff

Geoff Morris, Assistant Professor
Department of Agronomy | Kansas State University
3004 Throckmorton Plant Science Center | Manhattan KS, 66506
E-mail: gpmorris<EMAIL_ADDRESS>| Web: http://www.morrislab.org
Office:<PHONE_NUMBER> | Cell:<PHONE_NUMBER> | Skype/Google ID: morris.geoff.p
On Sep 21, 2017, at 4:27 PM, David LeBauer <notifications<EMAIL_ADDRESS>wrote:
Metadata
Make sure this page is up to date: https://terraref.gitbooks.io/terraref-documentation/content/user/protocols-UAV.html
(it can be edited here: https://github.com/terraref/documentation/edit/master/user/protocols-UAV.md)
File Organization
The most important is that everything is organized consistently. It is easy to reorganize and rename as long as the same basic conventions are kept across dates / sensors / data products.
Good enough
organize into directories like
{level}/{sensor}/{date}/{filename}
where

{level} is optional, the important part is that the raw data should be separate from the derived datasets
{sensor} can be the sensor name (e.g. rededge) or data product (e.g. ndvi)
{date} should be in the format YYYY-MM-DD
{filename} can be whatever you have, as long as it is consistent

Not Good Enough
Hopefully it is clear where the current organization can be improved:
[screen shot 2017-09-21 at 4 25 04 pm]https://user-images.githubusercontent.com/464871/30719555-918d899a-9ee9-11e7-9843-8a8a415465af.png
The convention we are using for the Field Scanner
This is what we are using for the Field Scanner data. The following would be consistent with our approach to the Field Scanner data, which is defined in https://github.com/terraref/terrautils/blob/master/terrautils/sensors.py (but needs to be documented somewhere, consider this the first draft!)
The format of the directory and filenames is:
directory: {Level}/{sensor}/{date}/{timestamp}/',
filename: {sensor}{L}{station}{timestamp}{dataproduct}{opts}.{ext}'
where:

{Level} is one of "raw_data", "Level_1", Level_2, ...
{sensor} is the name of the sensor or data product
{date} should be in YYYY-MM-DD format
{timestamp} in the format YYYY-MM-DD_HH-MM-SS. This is optional
{L} is level, but shortened to L1, L2, ...
{station} would be one of ua-mac, ksu, or ...
{data product}
{opts} might be left or right

In the case of the RGB sensor, one of the fullfield stitched files is called:
Level_1/fullfield/2017-05-29/fullfield_L1_ua-mac_2017-05-29_rgb.tif
Level_1 includes the georeferenced stitched images / point clouds. Level 2 would be any further derived products, for example, an NDVI map computed from a Level 1 product that contains Red and Near IR bands or a height map derived from a Level 1 point cloud.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/terraref/computing-pipeline/issues/186#issuecomment-331286922, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ATLjZMwsvc36eoXUJD-WOie_BjTN-eqtks5sktSsgaJpZM4KXSFZ.

It's not a public folder so I sent you an invite. These data are Rick's so please don't share  Beyond the team without his permission.

exporting shapefiles covered in this issue: https://github.com/terraref/computing-pipeline/issues/361; the files I generated are here: mac_plots.zip


flutter behind proxy

Impossible to update flutter when it is behind a proxy
error 407
Where to set the http_proxy with flutter ?

https://stackoverflow.com/questions/24021315/network-connection-proxies-in-dart-editor might help

I get that:
Got TLS error trying to find package mockito at https://pub.dartlang.org.
Error: Unable to 'pub upgrade' flutter tool. Retrying in five seconds...```

Env vars for proxy are set.

@danieldaeschle
Are you using self-signed certificates?
See also #15014
@fpitpit did the link help? Is this still an issue?

Yes, self signed Certificates from my company to the proxy server. I can't test it at the moment.

About self-signed certificates. This might apply here too https://github.com/dart-lang/pub/issues/1882#issuecomment-415588527

See also https://github.com/flutter/flutter/issues/16875#issuecomment-384758566


[JENKINS-55582] Turn modules into plugins

Downstream of https://github.com/jenkinsci/ssh-cli-auth-module/pull/9.

superseded by https://github.com/jenkinsci/sshd-module/pull/38


Return a failed status when a test fail

This would allow easier automatisation with the command

What should the error code be?

The default behaviour of rust is to return 1 when you return an Err from the main. So I guess we can continue to return 1.


Use system calls instead of NSUserDefaults when to mark intentional quit

There is a rare crash in the abort handler that we believe is from calling malloc
when the system is already in a memory crash. Using system calls instead of
Obj C functions here may help avoid allocating additional memory when we are in the middle of a crash stack.

Hey @wendylu! Thanks for the PR, and sorry to be a bit slow getting to it.
Overall, this seems reasonable. I added a few pretty nitpicky comments inline. More pressingly, though, this breaks the test suite (specifically, testAbortDoesNotTriggerOutOfMemoryWarning). That's definitely somewhat on me for not having a CI set up for this repo. Would you mind fixing the tests, and adding any you think might be useful, and I'll have another look? Thanks!

@jflinter Appreciate the review! Made some updates and tests pass now. LMK what you think

Cool, LGTM! Thanks!


Risk Filter functionality

Related Issue

Fixes #504
Checklist:

[ ] I have read the contributor's guide.
[ ] I linked an issue in the previous section
[ ] I have commented on the linked issue
[ ] I was assigned the linked issue (not required)
[ ] I have tested the change to the best of my ability against the sandbox or a local build.

Optional items:

[ ] My change adds new text and requires a change to translations.
[ ] My change requires a change to the documentation.
[ ] I have submitted a PR to the documentation repo.
[ ] I was not able to test... (explain below, e.g. you did not have permissions to test a specific feature)
[ ] This change depends O-FISH Realm repository changes (explain below)

Before

After

Hi @mmhuseynov - the filtering behavior works as expected, now there's just a little bit of a problem with the filter showing up more than once - here I have selected Amber and Red, and the filter shows 2 filters on amber and 2 filters on red. Can you fix that please?
Also, do you know why the map doesn't render properly when we use the filter?


Refactoring blazor v2

Pull request that is based on this Pull request with Merging Fixes.
https://github.com/inforithmics/Mapsui/pull/4

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: inforithmics:x: Daniel RomanowskiDaniel Romanowski seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@daniellor Can you sign the CLA?

@inforithmics  I have signed the CLA.


Refactor ranking metric map to be the same as Spark's

Description

Refactor both python and spark ranking metric map to be the same as Spark's.

Rename map_at_k to map which basically the same as Spark's meanAveragePrecision
Add MAP@K map_at_k to be the same as Spark's meanAveragePrecisionAt

Refactor evaluation tests to use the same data fixtures between python and spark tests.

Note: With this changes, some notebook tests are failing.
I'll need to update the expected values for map_at_k metrics for those notebooks, or simply to use map that is our previous map_at_k.
Related Issues

#2002
#1990
#1702
References

Checklist:

[x] I have followed the contribution guidelines and code style for this project.
[x] I have added tests covering my contributions.
[ ] I have updated the documentation accordingly.
[x] This PR is being made to staging branch and not to main branch.

btw, why draft PR triggers tests? @miguelgfierro @anargyri Can we disable that?

btw, why draft PR triggers tests? @miguelgfierro @anargyri Can we disable that?

This might be a solution: https://github.com/orgs/community/discussions/25722 we need to try it. Issue: #2003 2005

@loomlike are the test failures related to the values of the metrics? I vaguely recall that we had found some bugs in the Spark implementation (or they were not matching the definitions), hence our own implementations for some of the metrics.

@loomlike are the test failures related to the values of the metrics? I vaguely recall that we had found some bugs in the Spark implementation (or they were not matching the definitions), hence our own implementations for some of the metrics.

I think the error was coming from test group names (as I changed some of the tests names, e.g. test_python_precision -> test_python_precision_at_k). I changed them in the test group lists. Let's see if that works.
Regarding the MAP, Spark added meanAveragePrecisionAt since v3.0.0. So I changed our map_at_k to be just map and added map_at_k which implements "at_k" parts for both python and spark utils.
Regarding the definition of MAP vs. MAP@K, actually what we had before was just MAP based on Wikipedia definition as well as Spark's implementation.
The community seems to follow the following definition:

AP@k is typically calculated for one user from all recommendations by averaging P@1, P@2, P@3, ... P@k
which the Spark's meanAveragePrecisionAt also follows it (and the codes in this PR also follow that definition).

Good, as long as the evaluation notebooks give the same metrics as before we should be fine.

@loomlike if you get an error on DCO you can go to details and approve it. Only admins can do this. I've approved this one.

@loomlike the issue is fixed https://github.com/recommenders-team/recommenders/pull/2017
Can you please merge the latest staging into your branch before committing?


⚠ Bofrost.de has degraded performance

In bb00273, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1453 ms

Resolved: Bofrost.de performance has improved in 43b6ef8.


File share access with some reflection

This kind of totally fictive situation:
Mainly packages comes from NuGet, but there are also two other scenarios:
a) All the old dll-references are not migrated to NuGet yet.
b) There might be also some proprietary purchased dll-libraries which are not available open-source
So, some reference-files are in some common file-share, network-drive or where ever (like in #54 ).
If I open a dll file with ILSpy, it can tell itself:
// C:\path...\Castle.Facilities.Logging.dll
// Castle.Facilities.Logging, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=407dd0808d44fbdc
// Architecture: AnyCPU (64-bit preferred)
// Runtime: .NET 4.0
And also References:
// mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089
// Castle.Windsor, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=407dd0808d44fbdc
// Castle.Core, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=407dd0808d44fbdc
// System, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089
So, could I include this network path having these dlls ("include subdirectories") to the calculation of the Paket dependency-hierarchy? Would Paket help migrating these to NuGet?

Something like this:
https://gist.github.com/Thorium/ff0d59a914872dde60bf

Updated the source snippet: https://gist.github.com/Thorium/ff0d59a914872dde60bf

I think this sounds like a great feature. Many projects have a lib folder where additional dlls are placed.

Just listing external dlls in paket.dependencies and paket.log would be easy. It is nice-to-know the dependencies for dll-structures. But this benefit is only informational. To get real functional benefits, we should be able to map dlls to the corresponding NuGet-packages.
Mapping to Nuget is trivial for packages that have same dll-name as nuget-id, like:

Microsoft.AspNet.SignalR.Client.dll -> Nuget-id: Microsoft.AspNet.SignalR.Client
Microsoft.Owin.Hosting.dll -> Nuget-id: Microsoft.Owin.Hosting
NServiceBus.Testing -> Nuget-id: NServiceBus.Testing

But then, there are also non-trivials, and some packages contain multiple dlls:

Castle.Services.Logging.Log4netIntegration -> Nuget-id: Castle.Core-log4net
System.Reactive.Core.dll -> Nuget-id: Rx-Core

I don't get this nuget mapping - what's the goal?

I'm using some NuGet packages locally (funnily enough, in a lib folder) - either from private repos or similar - for performance reasons.
What's the use case behind this - either (a) that you have some random DLLs which aren't NuGet compatible, in which case is it even possible to make them look like NuGet packages, or (b) you have some NuGet packages that don't exist in a real NuGet server - in which case you can just use the local file system.

b) is already covered by http://fsprojects.github.io/Paket/nuget-dependencies.html#Path-sources

@forki exactly. and that's exactly what i'm doing now :-)

Well, I'm testing for many things just to manage complex dependency-hierarchies. But I guess the main problem is this:
Let's say that I have (quite typical) enterprise-application, e.g. 50 solutions having 500 csproj-files or more. They use old direct projects reference dll without NuGet, so hint-path in the csproj-file: ........\lib\EntityFramework\EntityFramework.dll (<IP_ADDRESS>)
(ok, bunch of other dlls also, but let this EF be an example for now.)
Now, I have also 20 new projects in this same enterprise application. They also use EntityFramework, but via NuGet. They build to this same bin-folder. If each project\bin would be separate, then I would have 520 copies of EntityFramework.dll in my hard drive.
(Actually there are a few bin folders, separated with the business-boundaries, but whatever: many projects and solutions build to the same bin.)
Managing packages.config-files between different sln-solutions (and syncing to these lib-versions) is painful. I think Paket will handle references between solutions better than NuGet.
Now we know that we can't update those new 20 projects to EntityFramework <IP_ADDRESS> because it would conflict bin with those 500 other projects. But Paket don't know this.
So you suggest downloading those nuget-packages to lib-folder? And make fake ones for the dll's that won't have any?
I don't know how to replace 500 projects to use NuGet without manual work. (Of course I have F#-scripts to manage and modify these 500 .csproj-files so this could be possible.)
My goal is to

Know conflicts: If one dll is upgraded, then in the middle of the work, suddenly I notice that, oh no, it has a reference to new Castle.Core which has to be also upgraded and there is old one in the lib and the new version has breaking changes in some other solution. Paket helps with this one, but only if NuGet is used, right?
Automate. Have little efficient scripts instead of manual work.
To have also these old projects using some kind of package manager to update references.

I close this as file assembly versions do not correspond to the NuGet package versions. So the right solution is to first migrate to NuGet.


After 0.89 upgrade Smartthings switch power attribute not discovered

All working in 0.88.2.  Following Hass.io upgrade to 0.89:
The power attribute of a Smartthings switch was correctly discovered under 0.88.2, but is not discovered at all under 0.89.  (Strange, from the release notes it should be the other way round!)
An observation: it was necessary to re-enter the Smartthings token and then reinstall the Home Assistant smartapp in the Smartthings mobile app as if installing for the first time.  But if the component subscription has been enhanced, perhaps this is necessary.  Note to all: DO keep a record of the Smartthings token you use!

Please read the breaking change section of release note. If you still fell that is a bug, please create a new issue following our issue template.


[Feature Request] - Make URLs in headers clickable

Insomnia Version:

Version 5.16.6
Shell 1.8.4
Node 8.2.1
V8 <IP_ADDRESS>
Architecture x64

Operating System:

Ubuntu 18.04

Details
Hello. I'm using Symfony to build my API, and Symfony uses Headers to set a link to the debug panel.
So, it would be awesome to be able to click on such value.

Oh no, dont't close it please, Mr @stale Bot

Won't be closed now!

Also, I think this would be a great little feature to add 😄

Thanks

Hi Guys,
I have started working on implementing this feature, will update you guys once I complete it.
Thanks.


Document limitation of connected_components and panic early

Fixes https://github.com/PistonDevelopers/imageproc/issues/285
@HeroicKatora I've gone for the easiest (laziest) option for now; I won't bother rewriting the function to handle larger images until I know there's anyone that actually needs this.

Seems like a valid solution until someone encounters the commend :+1:


Screen flickers when start recording

Hi Team,
Thanks for this sdk, its wonderfull.
I am recently facing an issue that the screen flickers as attached in the gif file and the code is very simple, no rerendering.
Help is appreciated.
Pasting the code below
import React, {useRef} from 'react';
import {
  View,
  Platform,
  StyleSheet,
  Text
} from 'react-native';
import DeepARView, {
  CameraPositions,
} from 'react-native-deepar';
import {
  widthPercentageToDP as wp,
} from 'react-native-responsive-screen';

const FilterScreen = () => {
  const deepARRef = useRef(null);

  return (
    <View style={styles.container}>
      <DeepARView
          ref={deepARRef}
          apiKey={API_KEY}
          position={CameraPositions.FRONT}
          onScreenshotTaken={(screenshotPath) => {
            console.log("Screenshot")
          }}
          onVideoRecordingPrepared={() => {
            console.log('onVideoRecordingPrepared');
          }}
          onVideoRecordingStarted={() => {
            console.log('onVideoRecordingStarted');
          }}
          onVideoRecordingFinished={(videoPath) => {
            console.log('onVideoRecordingFinished');
          }}
          onError={(text, type) => {
            console.log('onError =>', text, 'type =>', type);
          }}
          style={{
            width: wp(100),
            height: '100%',
          }}
        />
        <Text onPress={()=>)} style={{position:'absolute',bottom:100, left:10, backgroundColor:'white'}}>Press to record</Text>
    </View>
  );
};

const styles = StyleSheet.create({
  container: {
    flex: 1,
    alignItems: 'center',
    justifyContent: 'center',
  },
});

export default FilterScreen;

Can you try latest version? There is some major changes @agam-colaburate

Thanks @ridvanaltun
I will try it out in a couple of days, but just a side note, I was thinking that the latest version would come with a fix for the very popular issue "Direct local .aar file dependencies are not supported when building an AAR...." in this library where everytime I Install the node module, I have to replace one line in the android level build.gradle of the library as described below -
original -> implementation fileTree(dir: "libs", include: ["*.aar"])
After changing -> implementation(name: 'deepar-3.4.4', ext: 'aar')
Updated dependencies of android level build.gradle looks like
dependencies {
//noinspection GradleDynamicVersion
implementation "com.facebook.react:react-native:+"  // From node_modules
implementation(name: 'deepar-3.4.4', ext: 'aar')
// CameraX core library using the camera2 implementation
def camerax_version = "1.1.0"
implementation "androidx.camera:camera-camera2:${camerax_version}"
implementation "androidx.camera:camera-lifecycle:${camerax_version}"
implementation "androidx.camera:camera-view:${camerax_version}"
// The following line is optional, as the core library is included indirectly by camera-camera2
implementation "androidx.camera:camera-core:${camerax_version}"
}
TIA.

Thanks @ridvanaltun On behalf of agam-colaburate,
I will try it out in a couple of days, but just a side note, I was thinking that the latest version would come with a fix for the very popular issue "Direct local .aar file dependencies are not supported when building an AAR...." in this library where everytime I Install the node module, I have to replace one line in the android level build.gradle of the library as described below -
Original -> implementation fileTree(dir: "libs", include: ["*.aar"])
After changing -> implementation(name: 'deepar-3.4.4', ext: 'aar')

Updated dependencies of android level build.gradle looks like
dependencies {
  //noinspection GradleDynamicVersion
  implementation "com.facebook.react:react-native:+"  // From node_modules
  implementation(name: 'deepar-3.4.4', ext: 'aar')

  // CameraX core library using the camera2 implementation
  def camerax_version = "1.1.0"

  implementation "androidx.camera:camera-camera2:${camerax_version}"
  implementation "androidx.camera:camera-lifecycle:${camerax_version}"
  implementation "androidx.camera:camera-view:${camerax_version}"

  // The following line is optional, as the core library is included indirectly by camera-camera2
  implementation "androidx.camera:camera-core:${camerax_version}"
}

TIA.

Hello @singhagam1,
I'm aware of the existence of this error, but when I tried the solution you suggested, I encountered another error. Additionally, this error does not occur in the projects I'm currently working on or in the sample project within the library.
If we move the .aar file to a remote location like Maven on the Android side, the problem will be resolved, but it requires action from the DeepAR team. In fact, the first issue report in this project is about this topic, and you can check it out here: #1.
When the DeepAR team put the SDK on a remote server, we will completely resolve this problem.
Anyways, there is a package called "patch-package" that you can use in your project to more easily resolve the issue you encountered in this library. If you're not using it, I recommend you to use it.


update ios lib

@edewit @corinnekrych  looks like we need to update the ios lib as well. It's missing the armv7s architecture when build cordova apps on BF.

:tada: awesome, @wei-lee
Not 100% on the actual file name if it should be libpush-sdk-1.1.1.a, after coming from 1.1.0-beta.
But that's minor, especially that the UPS 1.1.1 is coming somewhat soon, I guess the 1.1.1 is reasonable :grinning:

@matzew Oh, I built this version from the master branch of the aerogear-ios repo. Is that version not released yet? Perhaps I should not use this version then?

Ah, nevermind, @wei-lee
https://github.com/aerogear/aerogear-ios-push/releases/tag/1.1.1
:-)
Sorry for that confusion :-)

@matzew no problem at all.

@wei-lee sorry but I merged the release branch back to compat because that one was tested

@edewit no problem at all. Didn't know we already have a fix in another branch. Thanks.


Split check_access_keys method

Type: generic-feature
Why is this change necessary?
This is required in order to allow overriding scores for each of these
issues.
This change addresses the need by:
Splitting the check_access_keys method into 2 separate check_ methods,
one for each issue.
Potential Side Effects:
None

Coverage decreased (-0.02%) to 54.398% when pulling 482f9ac862e1ee6db77f16a184cc08bc18aaae28 on Bridgewater:9968_SplitCheckAccessKey into 83e572a83a9c003efe79399631873b232c7086f6 on Netflix:develop.


Sentry chart

My first chart. Still in progress. Feedback welcome.

Trying to install for testing. Ran
helm dep build
helm install --debug .

Seeing errors
Created tunnel using local port: '36815'
SERVER: "localhost:36815"
CHART PATH: /home/jgarr/src/kubernetes/charts/incubator/sentry
Error: release xrayed-terrier failed: deployments.extensions "xrayed-terrier-sentry" already exists

This is a brand new GKE cluster for testing
$ helm version
Client: &version.Version{SemVer:"v2.2.3", GitCommit:"1402a4d6ec9fb349e17b912e32fe259ca21181e3", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.2.3", GitCommit:"1402a4d6ec9fb349e17b912e32fe259ca21181e3", GitTreeState:"clean"}

Any thoughts?
@lachie83

@rothgar This PR is great to see. This issue is because both the web and worker deployment are being generated with the same name. Try appending the component name to the end. Here's an example -- https://github.com/kubernetes/charts/blob/master/incubator/istio/templates/manager-deployment.yaml#L5. You could also do something like name: {{ template "fullname" . }}-worker

I got this chart to install with the following changes
~/sandbox/kubernetes/charts/incubator/sentry on pr/1226 [!]
$ git d
 incubator/sentry/requirements.lock                 |  6 ++++--
 incubator/sentry/templates/cron-deployment.yaml    |  2 +-
 incubator/sentry/templates/workers-deployment.yaml |  2 +-
 incubator/sentry/values.yaml                       | 20 ++++++++++----------
 4 files changed, 16 insertions(+), 14 deletions(-)

diff --git a/incubator/sentry/requirements.lock b/incubator/sentry/requirements.lock
index 581a112..5679370 100644
--- a/incubator/sentry/requirements.lock
+++ b/incubator/sentry/requirements.lock
@@ -1,15 +1,17 @@
 dependencies:
 - condition: ""
   enabled: false
+  import-values: null
   name: postgresql
   repository: https://kubernetes-charts.storage.googleapis.com/
   tags: null
   version: 0.7.1
 - condition: ""
   enabled: false
+  import-values: null
   name: redis
   repository: https://kubernetes-charts.storage.googleapis.com/
   tags: null
   version: 0.6.0
-digest: sha256:ea6510a357c699082e455250d166978c363f420ee8d589c48492e83b4c376eba
-generated: 2017-06-02T06:18:46.211627938Z
+digest: sha256:dbaa80dbd8326dc559176f3bb5c97723b5a9c6378cd5b01fe3d0787825de9bac
+generated: 2017-06-02T10:11:05.87979944-07:00
diff --git a/incubator/sentry/templates/cron-deployment.yaml b/incubator/sentry/templates/cron-deployment.yaml
index ae212fc..94b9c25 100644
--- a/incubator/sentry/templates/cron-deployment.yaml
+++ b/incubator/sentry/templates/cron-deployment.yaml
@@ -1,7 +1,7 @@
 apiVersion: extensions/v1beta1
 kind: Deployment
 metadata:
-  name: {{ template "fullname" . }}
+  name: {{ template "fullname" . }}-cron
   labels:
     chart: "{{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }}"
 spec:
diff --git a/incubator/sentry/templates/workers-deployment.yaml b/incubator/sentry/templates/workers-deployment.yaml
index 374004b..ed1862b 100644
--- a/incubator/sentry/templates/workers-deployment.yaml
+++ b/incubator/sentry/templates/workers-deployment.yaml
@@ -1,7 +1,7 @@
 apiVersion: extensions/v1beta1
 kind: Deployment
 metadata:
-  name: {{ template "fullname" . }}
+  name: {{ template "fullname" . }}-worker
   labels:
     chart: "{{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }}"
 spec:
diff --git a/incubator/sentry/values.yaml b/incubator/sentry/values.yaml
index 6006b51..08b929d 100644
--- a/incubator/sentry/values.yaml
+++ b/incubator/sentry/values.yaml
@@ -21,17 +21,17 @@ resources:
     cpu: 100m
     memory: 128Mi

-  ## Enable persistence using Persistent Volume Claims
-  ## ref: http://kubernetes.io/docs/user-guide/persistent-volumes/
+## Enable persistence using Persistent Volume Claims
+## ref: http://kubernetes.io/docs/user-guide/persistent-volumes/
+##
+persistence:
+  enabled: false
+  ## If defined, volume.beta.kubernetes.io/storage-class: <storageClass>
+  ## Default: volume.alpha.kubernetes.io/storage-class: default
   ##
-  persistence:
-    enabled: false
-    ## If defined, volume.beta.kubernetes.io/storage-class: <storageClass>
-    ## Default: volume.alpha.kubernetes.io/storage-class: default
-    ##
-    # storageClass:
-    accessMode: ReadWriteOnce
-    size: 8Gi
+  # storageClass:
+  accessMode: ReadWriteOnce
+  size: 8Gi

 ## Configure ingress resource that allow you to access the
 ## Sentry instalation. Set up the URL

~/sandbox/kubernetes/charts/incubator/sentry on pr/1226 [!]
$ helm install .
NAME:   agile-gibbon
LAST DEPLOYED: Fri Jun  2 10:21:44 2017
NAMESPACE: default
STATUS: DEPLOYED

RESOURCES:
==> v1/PersistentVolumeClaim
NAME                     STATUS  VOLUME                                    CAPACITY  ACCESSMODES  STORAGECLASS  AGE
agile-gibbon-postgresql  Bound   pvc-f4c0d081-47b7-11e7-ae3f-000d3a72314b  8Gi       RWO          7s

==> v1/Service
NAME                     CLUSTER-IP    EXTERNAL-IP  PORT(S)         AGE
agile-gibbon-redis       <IP_ADDRESS>  <none>       6379/TCP        6s
agile-gibbon-sentry      <IP_ADDRESS>  <pending>    9000:31719/TCP  5s
agile-gibbon-postgresql  <IP_ADDRESS>   <none>       5432/TCP        5s

==> v1beta1/Deployment
NAME                        DESIRED  CURRENT  UP-TO-DATE  AVAILABLE  AGE
agile-gibbon-sentry         1        0        0           0          4s
agile-gibbon-sentry-worker  2        0        0           0          4s
agile-gibbon-redis          1        1        1           0          4s
agile-gibbon-postgresql     1        1        1           0          4s
agile-gibbon-sentry-cron    1        0        0           0          4s

==> v1/Secret
NAME                     TYPE    DATA  AGE
agile-gibbon-sentry      Opaque  2     7s
agile-gibbon-postgresql  Opaque  1     7s
agile-gibbon-redis       Opaque  1     7s

NOTES:
1. Get the application URL by running these commands:
     NOTE: It may take a few minutes for the LoadBalancer IP to be available.
           You can watch the status of by running 'kubectl get svc -w agile-gibbon-sentry'
  export SERVICE_IP=$(kubectl get svc --namespace default agile-gibbon-sentry -o jsonpath='{.status.loadBalancer.ingress[0].ip}')
  echo http://$SERVICE_IP:9000

I have a job that needs to run once during installation. Is there an example I can look at for this? For a fresh install I need to initialize the database with sentry upgrade

I found the hooks docs (examples also in spinnaker). Added db init and user creation.
Still need

[ ] smtp settings
[ ] persistant storage
[ ] plugins

Just for reference, I'm also running into this issue kubernetes/helm#1769 with the jobs

@lachie83 have an example of disabling sub charts if they're not needed (eg postgres)? I found this https://docs.helm.sh/chart-best-practices/#conditions-and-tags but not sure how to implement that for a subchart. I searched the repo (not very well) and didn't see an example.

Unfortunately you cannot use the conditions on local subcharts only with dependencies as you mentioned above. One way I've see before is to set a global flag in the top chart values.yaml and conditionalize creation of all resources in the subchart on that flag. eg
{{- if .Values.global.postgres.enabled }}
{{ end }}

Does that help?

I think this is at a minimal viable chart.
Can someone test in a different environment for me?

All pods come up and running and the job exits success following an install. How else would you like me to test? Is there something functional I can do?
bailing-possum-postgresql-2744245312-nwv54       1/1       Running   0          6m
bailing-possum-redis-46185774-1w33d              1/1       Running   0          6m
bailing-possum-sentry-884421309-5k861            1/1       Running   0          6m
bailing-possum-sentry-cron-3640742245-4s8pb      1/1       Running   1          6m
bailing-possum-sentry-worker-1644057744-8hwzq    1/1       Running   1          6m
bailing-possum-sentry-worker-1644057744-lfqvd    1/1       Running   1          6m
kubectl get jobs
NAME                     DESIRED   SUCCESSFUL   AGE
bailing-possum-db-init   1         1            7m

Actually it looks like the sentry pod keeps crashing
bailing-possum-sentry-884421309-5k861            0/1       CrashLoopBackOff   4          11m

Here are the logs
*** Starting uWSGI 2.0.15 (64bit) on [Thu Jun  8 06:58:23 2017] ***
compiled with version: 4.9.2 on 02 June 2017 13:28:26
os: Linux-4.4.0-77-generic #98-Ubuntu SMP Wed Apr 26 08:34:02 UTC 2017
nodename: bailing-possum-sentry-884421309-5k861
machine: x86_64
clock source: unix
detected number of CPU cores: 2
current working directory: /
detected binary path: /usr/local/bin/uwsgi
!!! no internal routing support, rebuild with pcre support !!!
your memory page size is 4096 bytes
detected max file descriptor number: 65536
lock engine: pthread robust mutexes
thunder lock: enabled
uwsgi socket 0 bound to TCP address <IP_ADDRESS>:9000 fd 3
Python version: 2.7.13 (default, May 11 2017, 21:39:56)  [GCC 4.9.2]
Set PythonHome to /usr/local
Python main interpreter initialized at 0xd64260
python threads support enabled
your server socket listen backlog is limited to 100 connections
your mercy for graceful operations on workers is 60 seconds
setting request body buffering size to 65536 bytes
mapped 1922048 bytes (1877 KB) for 12 cores
*** Operational MODE: preforking+threaded ***
spawned uWSGI master process (pid: 11)
spawned uWSGI worker 1 (pid: 16, cores: 4)
spawned uWSGI worker 2 (pid: 17, cores: 4)
spawned uWSGI worker 3 (pid: 18, cores: 4)

Actually it looks like the sentry pod keeps crashing

@lachie83 please take  a look on my comments about the resources. This values are too low to sentry start the application.

@lachie83 I think I'm mostly curious about what are requirements for the chart to be merged into the main repo? Are there typical tests that are performed? Are charts checked against k8s clusters in GKE, AWS, Azure?
I'm working on the changes @gianrubio suggested but after that I'm not sure how much else needs to be done before it can be merged.

@rothgar here's the technical checklist on getting it merged
https://github.com/kubernetes/charts/blob/master/CONTRIBUTING.md#technical-requirements
The current charts are tested against a 1.6 cluster running on GKE only. They only test lint and installation through to a running pod. You could also add helm tests which we hope to use eventually. See https://github.com/kubernetes/charts/blob/master/stable/consul/templates/test-config.yaml for example

Other than a readme and sorting out those other comments you should be GTG AFAICT

Thanks for the info. I have a few more changes and need to switch the default password to be randomly generated and print it out in the NOTES. I'll try to get to that today and should be able to finish up the chart.

Okay great -- Just a word of warning RE: random value generation. https://github.com/kubernetes/helm/blob/master/docs/charts_tips_and_tricks.md#be-careful-with-generating-random-values

Alright, this deployed for me on minikube and GKE.
I'd like to add options to not deploy postgres and redis but I'm still not exactly sure how to do that. Otherwise this deploys fine for me.

Can someone go ahead and test this chart? I think it's ready to be merged.

@k8s-bot ok to test

@rothgar Just noticed this chart is under incubator/, which is for charts that use alpha Kubernetes resources. We should do a better job of making that clear. In the meantime, you should move to stable/, though not blocking for this PR.

Thanks for the clarification. I never did know what the difference was.

One last change and we should be gtg

@k8s-bot ok to test

Thanks @rothgar for your first chart!

I can't get this to run if i specify a release name in helm, only
helm install --wait stable/sentry
works, if i specify --name blah then i get a timeout and failure. Looks like the user-create job fails connecting to the database. Is it expected that a release name can't be specified?


Docker pull hangs - never calls callback

I'm using dockerode to pull down images from a private repository. Occasionally - maybe about 10% of the time - dockerode hangs because the modem never calls the callback with the stream. After putting some logging messages into lib/modem.js in the docker-modem dependency, I discovered that a typical pull causes 2 json responses (line 232 of modem.js) followed by a stream response (line 230 of modem.js). When the modem hangs, I don't see a stream response. Tailing the registry logs, I don't see anything out of the ordinary; it looks the same from a successful pull to an unsuccessful one.
I'm not sure if this is an issue with dockerode, docker-modem, docker daemon, or the registry. Is there a good way to find out?

So it appears docker pull hangs only because the i/o timeout was longer than the test timeout that I was running. Looking at the docker logs, this is the error:
ERRO[10608] Error from V2 registry: Get https://registry.thinknode.dev/v2/035088a9398b/math/manifests/sha256:10af39c70b7b7f3bc6d9539c38180d67a626c033487e706e5396d3c5af6c58a8: read tcp <IP_ADDRESS>:443: i/o timeout
ERRO[10608] Handler for POST /images/create returned error: pulling with digest reference failed from v2 registry
ERRO[10608] HTTP Error                                    err=pulling with digest reference failed from v2 registry statusCode=500

This seems to be related to docker/docker#13337 and not at all related to dockerode. Closing.