Test file not found, when not run in root

I have a test project, that includes a package I'm working on in packages/my-library.
The Pest tests I want to execute are in that package. So there is a phpunit.xml in packages/my-library and the tests itself are located in packages/my-library/tests.
I installed the dependencies inside the packges/my-library folder (including pest) and configured the plugin in PhpStorm to point the Pest executable to the packages/my-library/vendor/bin/pest and the Default configuration file to packages/my-library/phpunit.xml.
When I try to run the tests from the command line (outside PhpStorm) vendor/bin/pest it works like expected.
When I try to run the tests from inside PhpStorm it fails. It doesn't matter if I try it on a single test function, a file or the whole folder. The error I get is: Test framework quit unexpectedly
/opt/homebrew/bin/php /.../packages/my-library/vendor/bin/pest --teamcity --configuration /.../packages/my-library/phpunit.xml /.../packages/my-library/tests/Unit/ReplyKeyboardTest.php "--filter=/^P\\Packages\\my-library\\tests\\Unit\\ReplyKeyboardTest::it\screates\svalid\sJSON(\swith\s((data\sset\s\".*\")|(\(.*\)(\s#\d+)?)))?$/"
Testing started at 20:26 ...

Pest 1.21.2

   Pest\Exceptions\ShouldNotHappen

This should not happen - please create an new issue here: https://github.com/pestphp/pest.

- Issue: Test file not found.
- PHP version: 8.1.4
- Operating system: Darwin

  at packages/my-library/vendor/pestphp/pest/src/Exceptions/ShouldNotHappen.php:38
     34▕      * Creates a new instance of should not happen without a specific exception.
     35▕      */
     36▕     public static function fromMessage(string $message): ShouldNotHappen
     37▕     {
  ➜  38▕         return new ShouldNotHappen(new Exception($message));
     39▕     }
     40▕ }
     41▕

      +3 vendor frames
  4   packages/my-library/tests/Unit/ReplyKeyboardTest.php:10
      it("it creates valid JSON", Object(Closure))

Process finished with exit code 1

When I change the Run Configuration for this test and specify the working directory explicitly to be packages/my-library, the framework quits unexpectedly too, but I get no error from Pest. The output is as follows:
/opt/homebrew/bin/php /.../packages/my-library/vendor/bin/pest --teamcity --configuration /.../packages/my-library/phpunit.xml /.../packages/my-library/tests/Unit/ReplyKeyboardTest.php "--filter=/^P\\Packages\\my-library\\tests\\Unit\\ReplyKeyboardTest::it\screates\svalid\sJSON(\swith\s((data\sset\s\".*\")|(\(.*\)(\s#\d+)?)))?$/"
Testing started at 20:30 ...

Pest 1.21.2
PHPUnit 9.5.19 #StandWithUkraine

Tests:
Assertions:  0
Time:  0s

Process finished with exit code 0

For readability and privacy I shortened the paths to the project root.
I'm not sure how I can fix this. Any ideas?

So apparently I need to specify the working directory to fix the big error. (But I'd assume, that the working directory should always be the folder containing the phpunit.xml, right?)
Additionally the second problem is, that the IntelliJ Plugin does not correctly set the --filter argument right. So no test is found (because it does not match), and nothing is run.

@TiiFuchs So the big error you were getting seems like pest itself should handle it to give a better error message 🤔
So the other issue with the filter being generated from root is actually not entirely correct, it is actually generated from the the parent folder of the vendor folder.
https://github.com/pestphp/pest-intellij/blob/8520a87f23a86060a1322d747d882ad204ac4498/src/main/kotlin/com/pestphp/pest/configuration/PestRunConfigurationHandler.kt#L75-L77
This is actually done this way to reflect how pest itself works, however we might have messed it up 😅
Could you try something for me and run vendor/bin/pest --list-tests, so we can see what the actual names of your tests are, so we are sure we generate the filters correctly.
Also does your project contain multiple composer folders? You said you had a packages/my-library/vendor, but do you also have a project/vendor folder?
Phpstorm does not currently support multiple composer projects inside one project.
https://youtrack.jetbrains.com/issue/WI-31260

Yeah of course. Currently the tests are named like this:
PHPUnit 9.5.19 #StandWithUkraine

Available test(s):
 - P\Tests\Unit\ForceReplyTest::it creates valid JSON
 - P\Tests\Unit\ForceReplyTest::it can set known fields
 - P\Tests\Unit\ForceReplyTest::it can set unknown fields
 - P\Tests\Unit\InlineKeyboardButtonTest::it creates valid JSON
 - P\Tests\Unit\InlineKeyboardButtonTest::it can set known fields
 - P\Tests\Unit\InlineKeyboardButtonTest::it can set text via make
 - P\Tests\Unit\InlineKeyboardButtonTest::it can set unknown fields
 - P\Tests\Unit\InlineKeyboardTest::it creates valid JSON
 - P\Tests\Unit\InlineKeyboardTest::it can set unknown fields
 - P\Tests\Unit\InlineKeyboardTest::it can has multiple buttons
 - P\Tests\Unit\InlineKeyboardTest::it can has multiple rows
 - P\Tests\Unit\KeyboardButtonPollTypeTest::it creates any type
 - P\Tests\Unit\KeyboardButtonPollTypeTest::it creates quiz type
 - P\Tests\Unit\KeyboardButtonPollTypeTest::it creates regular type
 - P\Tests\Unit\KeyboardButtonPollTypeTest::it creates unknown type
 - P\Tests\Unit\KeyboardButtonTest::it creates valid JSON
 - P\Tests\Unit\KeyboardButtonTest::it can set known fields
 - P\Tests\Unit\KeyboardButtonTest::it can set text via make
 - P\Tests\Unit\KeyboardButtonTest::it can set unknown fields
 - P\Tests\Unit\ReplyKeyboardRemoveTest::it creates valid JSON
 - P\Tests\Unit\ReplyKeyboardRemoveTest::it can set known fields
 - P\Tests\Unit\ReplyKeyboardRemoveTest::it can set unknown fields
 - P\Tests\Unit\ReplyKeyboardTest::it creates valid JSON
 - P\Tests\Unit\ReplyKeyboardTest::it can set known fields
 - P\Tests\Unit\ReplyKeyboardTest::it can set unknown fields
 - P\Tests\Unit\ReplyKeyboardTest::it can has multiple buttons
 - P\Tests\Unit\ReplyKeyboardTest::it can has multiple rows

It belongs to this repository: https://github.com/php-telegram-bot/fluent-keyboard

For a clearer picture. The folder structure of the project looks like this:
.
├── app
├── bootstrap.php
├── composer.json
├── composer.lock
├── docker-compose.yml
├── handle.php
├── helpers.php
├── logs
├── packages
│  └── fluent-keyboard
│     ├── composer.json
│     ├── composer.lock
│     ├── phpunit.xml
│     ├── src
│     │  ├── FluentEntity.php
│     │  ├── ForceReply.php
│     │  ├── helpers.php
│     │  ├── InlineKeyboard
│     │  │  ├── InlineKeyboardButton.php
│     │  │  └── InlineKeyboardMarkup.php
│     │  ├── ReplyKeyboard
│     │  │  ├── KeyboardButton.php
│     │  │  ├── KeyboardButtonPollType.php
│     │  │  └── ReplyKeyboardMarkup.php
│     │  └── ReplyKeyboardRemove.php
│     └── tests
│        ├── Pest.php
│        └── Unit
│           ├── ForceReplyTest.php
│           ├── InlineKeyboardButtonTest.php
│           ├── InlineKeyboardTest.php
│           ├── KeyboardButtonPollTypeTest.php
│           ├── KeyboardButtonTest.php
│           ├── ReplyKeyboardRemoveTest.php
│           └── ReplyKeyboardTest.php
└── README.md
└── vendor

So there is a root composer.json/vendor folder. But the test part is happening inside packages/fluent-keyboard.
I guess the ComposerLibraryManager.getInstance(project).findVendorDirForUpsource() points to the root vendor folder.

Yeah, so the issue you are having is that you are actually trying to use one phpstorm project for multiple projects.
Unfortunately this is simply just unsupported by the structure of phpstorm. It does not support having multiple projects inside one project.
The official statement from phpstorm would be that you should simply have a phpstorm project for fluent-keyboard. So I have mainly gone with that restriction.
However I do not mind changing this so it works for your project, as I hate this restriction from phpstorm 😆
So just to loop you in, the reason why we do it from the composer path is actually because of this #211.
I am thinking we could change the logic so if the cwd is not the same as the project root path, then we use that as the root path for the filter method, else we use the composer path 🤔
However before building this, I will quickly create a version which uses cwd instead of composer, just to check if it even solves your issues 👍
I have created a new build for you with this change, could you check if it works for you?
Install it manually using
Preferences > Plugins > ⚙ > Install plugin from disk...
PEST PHP-1.3.1-EAP.4.zip

I will try the new build in a few seconds...
In the mean time I tried to run the tests from the project root (configuring phpunit.xml in root project to point to ./packages/fluent-keyboard/tests and installing pest there too.)
This works, for run configuration and run file. But the filter is not correctly generated if you just run a specific test.
vendor/bin/pest --list-tests now results in (shortened):
 - P\Packages\fluentkeyboard\tests\Unit\ForceReplyTest::it creates valid JSON
 - P\Packages\fluentkeyboard\tests\Unit\ForceReplyTest::it can set known fields
 - P\Packages\fluentkeyboard\tests\Unit\ForceReplyTest::it can set unknown fields

Actually this was executed:
/opt/homebrew/bin/php /Users/tii/projects/telegram/php-telegram-bot/vendor/bin/pest --teamcity --configuration /Users/tii/projects/telegram/php-telegram-bot/phpunit.xml /Users/tii/projects/telegram/php-telegram-bot/packages/fluent-keyboard/tests/Unit/ReplyKeyboardTest.php "--filter=/^P\\Packages\\fluent-keyboard\\tests\\Unit\\ReplyKeyboardTest::it\scan\shave\smultiple\srows(\swith\s((data\sset\s\".*\")|(\(.*\)(\s#\d+)?)))?$/"

So it seems Pest generates fluentkeyboard without the -, but the filter keeps the -.
But if I run the complete line from the command line and remove the -, it still does not work. But my understanding of the filter parameter ends there. I don't get the end of the filter stuff... :D

I will try the custom build running from the package folder now...

So regarding the new build:
Running the phpunit.xml: works if the working directory is set to the package folder. If not the following error appears:
   Pest\Exceptions\TestAlreadyExist

  A test with the description `it creates valid JSON` already exist in the filename `/Users/tii/projects/telegram/php-telegram-bot/packages/fluent-keyboard/vendor/bin/pest`.

Running a folder: Same as configuration above.
Running a specific file: Works without explicitly setting the working directory
Running a single test: Same problem with --filter parameter as earlier.
So progress... But not quite there, I guess. 🤔

@TiiFuchs ah thanks for testing it out.
So from this it seems we had two issues for you, the next is related to to us not filtering - aways, as pest apparently does this. 🤔
Haha yeah, the regex generated for the filter is quite complex, the complexity in the end is for making it work with datasets.
I have created a new build for you which filters away -. This at least seem to work for me when testing out locally.
Could you test out this new build and see if it then works for you? 👍
PEST PHP-1.3.1-EAP.5.zip

Yup, the - is gone, and when I specify a Custom Working Dir on each Run Configuration the test functions get executed on its own.
Without the custom working dir the filter is still generated from the root folder (containing Packages/fluentkeyboard).
--filter=/^P\\Packages\\fluentkeyboard\\tests\\Unit\\ForceReplyTest::it\scan\sset\sknown\sfields(\swith\s((data\sset\s\".*\")|(\(.*\)(\s#\d+)?)))?$/
So it's at least able to function properly now. But it's a bit of an overwhelming work if you always have to change the working dir before running it, if you've never run that specific run configuration/test function before. It's not a quick click on the run button besides the function as it is supposed to be (imho).
What are your thought on that?

@TiiFuchs You can change the template so you don't have to do it for every single run configuration 👍
https://github.com/pestphp/pest-intellij/issues/211#issuecomment-970554652
Hmm, I agree. We need to figure out a better path for deciding what the root directory should be, as I also want it to be as simple as just press run 🤔
Just unsure what could be the right way to figure out the root. Maybe we can do it from the path of the pest binary instead?

Shouldn't it be the folder in which the phpunit.xml resides? 🤔
Since the phpunit.xml has relative paths to the tests and how to identify them...
And you can specify the phpunit.xml to use in the Plugin configuration.
At least that sounds logical to me.

plus you could theoretically use a globally installed pest binary and it still would work. (at least in this scenario.)

I don't think pest supports being globally installed 🤔
Hmm, but maybe you are right that we can do it from the path of the phpunit.xml instead. Trying to think of edge-case scenarios, but don't think I have a deep enough knowledge of phpunit.xml to know what you are allowed to do with it 🤔

Sadly my knowledge is limited to here ^^

I'll try and make a build which uses the phpunit.xml file to determine root path and then we can test that out 👍

PEST PHP-1.3.1-EAP.7.zip
@TiiFuchs Could you please try out if this version is still working for you?

Uhhm... I think it behaves like before:
Without specifying a working directory it does not execute the test, although the filter seems to be right this time:
"--filter=/^P\\Tests\\Unit\\KeyboardButtonPollTypeTest::it\screates\sregular\stype(\swith\s((data\sset\s\".*\")|(\(.*\)(\s#\d+)?)))?$/"
P\Tests\Unit\KeyboardButtonPollTypeTest::it creates regular type
Does it get executed from the phpunit.xml path too or did the change only affect the filter generation?
With specifying the working dir, it works. Like it did before.

Haha oops, my bad...
Alright, so lets try again again again... 😅
I have now done so if you have a custom working directory defined that is used, else the the parent dir of phpunit.xml is used
PEST PHP-1.3.1-EAP.8.zip

Nice! This build works like I'd expect it!!! 🎉
Without explicitly configuring the working dir, configuration/dir/file/function tests all work like a charm!!!

Yaaay! 🎉
Alright, I'll try and clean it up a bit and then hopefully in the next week or two have time to tag v1.4.0 💯
Thanks for your help, it's really nice when people are willing to help out solving the issue

This has now been released as the next stable version.
https://github.com/pestphp/pest-intellij/releases/tag/v1.4.0
There might go a couple of days before it's available in marketplace.


can't find the folder "hardware"

Glad to see this excellent work, is the folder hidden for some reason.
is it possible to provide the relevant files, thanks a lot.

Why is it hidden?

Why is it hidden?

haha, I don't know either, can you create a release for this package?

Why is it hidden?

haha, I don't know either, can you create a release for this package?

I think this hidden-stuff is made by your operative system. Upload som printscreen here.


Quadrilateral culling for performance

@mikolalysenko Thanks for such a nice 2d convex hull implementation, it's very fast! Used it for my new concave hull module.
This implementation can be sped up by 2-3 times by filtering out points that are not inside a quadrilateral formed by leftmost, topmost, bottommost and rightmost points before running the monotone algorithm. Here's how I did it on my side, but thought that perhaps it would make sense to move it upstream — what do you think?

Awesome!  I'd definitely take a PR.  If you like, I can also add you as an owner on this repo so you can help triage any issues that come up.


feat: update wallet outcome redirect

List of Changes

update outcome redirect

Motivation and Context
The goal of this PR is to update outcome redirect for app IO with a dedicate link, the app is listening on:

iowallet://*****?outcome=

so prefix  iowallet:// instead http protocol.
How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Maybe, could be useful to update tests to avoid fail (see pipeline)

this PR is an alternative to https://github.com/pagopa/pagopa-infra/pull/1644, to be evaluated with integration tests App IO. The advantage of this last PR is we have more accurate monitoring because we have all app outcome as http traffic, useful to create azure dashboard.

to close ( for now :-) )


Could not install from "node_modules/chimp/cucumber@github:xolvio/cucumber-js" as it does not contain a package.json file

Cannot do npm install
Similar - https://github.com/ansible/ansible/issues/54293 - but also not fixed.
npm ERR! code ENOLOCAL
npm ERR! Could not install from "node_modules/chimp/cucumber@github:xolvio/cucumber-js#cf953cb5b5de30dbcc279f59e4ebff3aa040071c" as it does not contain a package.json file.

npm ERR!      /Users/ms/.npm/_logs/2019-09-15T18_04_15_792Z-debug.log

Full error log
2019-09-15T18_04_15_792Z-debug.log

This is related to Chimp depency package where package.json is missing.
I see that chimp has been splitted into 2 new projects as described here.
But after some tests I figured that the problem is within dependencies build and could only build using node v8.16.2


Windows 11 - Firefox browser -  Incorrect Alert Message for Import Account button

Steps to Reproduce:

Open the app: https://app.joyboy.community/
On the login page
Click on the "Import Account" button.
Observe the alert message displayed.

Expected Result:
The alert message should inform the user that importing an account will add it to their existing accounts, without deleting the current one.
Actual Result:
The alert message incorrectly states: "Creating a new account will delete your current account. Are you sure you want to continue?"
Recommendation:
Update the alert message for the "Import Account" function to accurately reflect its behavior, such as: "Importing an account will add it to your existing accounts. Continue?" This change will improve the user experience and avoid confusion.

@MullerTheScientist I will like to work on this

This error message is correct, importing or creating will delete the current one.


Add description for usage of WP_CACHE_KEY_SALT

Added description for usage of WP_CACHE_KEY_SALT variable in .env.deployer file.
Signed-off-by: Shantanu Deshpande<EMAIL_ADDRESS>

Closing this for now. As a major changes are being done to the repository, this is PR becomes unusable.


WiP: remove attribute removal helper

This pull request is considered "work in progress" but it shows a way how we could get rid of the dreadful AttributeRemovalHelper at the moment two unit tests have been set to ignore, as they are depending on the AttributeRemovalHelper We have to fix them before we can merge this.

I like your solution, because it removes the AttributeRemovalHelper, but maybe the attributes filtering can be done in a custom HTTP message converter?

Is this still WiP?

It's funny that the two failing tests are the same: ShowComplexAttributeFilterSpec and IsoDateFormatSpec. I think you can delete the last one.

They are not the same, they just look like they were :)
The tests are totally useless, because they still base on the old behavior, i.e. serialize the Users as JSON string (filtering it thereby), deserialize them back as a Map and then let Spring serialize them as part of the ScimSearchResult again. Just delete them @wallner
The ISODateFormatSpec, for instance, depends on the fact, that the User has been serialized before, so that the contained java.util.Date is converted to String holding the ISO 8601 formatted date.

@tkrille I don't think this is work in progress any more. It's ready for review.

Then please change the PR's title

I'm fine with this PR. What about you @tkrille ?

I still couldn't manage to look at it. I'm still on #143. But this one will be next.


API proposal for Neighborhood.jl

Hello everyone. Please comment here if you are satisfied with this. I am!
@JonasIsensee @zgornel @altre @dillondaudert @chethega
@KristofferC  we would appreciate your feedback aswell.
If we agree on this I'll add the extention of the API by e.g. NearestNeighbors.jl so that we see how it looks.
EDIT: The "mockup implementation files" ARE OLD!!! Let's first agree on the API and then I update.

Alright, my latest commits implement the full interface for NearestNeighbors.jl (at least for KDTree, if the interface for BallTree is the same then I can just replace KDTree with Union{KDTree, BallTree...}. A lot of improvements were done while I was implementing it for NearestNeighbor. Useful for me is also the inclusion of the Theiler helper functionality.
This general and somewhat universal interface (in a sense independent from the search type) is useful for at least 3 packages of JuliaDynamics. Therefore I won't wait too long here: if noone replies I will merge this over the weekend.

I've integrated the NearestNeighbors interfacing into the actual module. At first I thought it would be nice to have a FileIO kind of feel, where the participating package extends the interface on its own end. But I realize this will be very hard to convince all authors to do this on their end. On the other hand this package will be open to PRs and responsive so anyone can add a new package to the interface without being the author of the contributing package.

Documentation can be previewed here: https://julianeighbors.github.io/Neighborhood.jl/previews/PR5/#

I've just tested this in the most complicated algorithms we have at JuliaDynamics and everything worked out. I'm merging and tagging. Feel free to discuss in other issues in the future.


Trait implementation of adapters that cannot accept a socket address?

A bit new to rust, is there any consideration to how transports can be implemented to take in something that is not of SocketAddr type? I am attempting to implement a unix socket adapter and it takes in a path instead of SocketAddr so my current method will likely ignore the SocketAddr but it will still have to be passed.

Basically here the implementation of fn listen_with(config: TransportListen, addr: SocketAddr)  takes in SocketAddr which only seems to have IPv4 and IPv6 variants and unix sockets may want to be binded to a file path but for now I am ignoring this parameter initially.

As for fixing the ConnectionInfo that is another issue that I am looking into.

I'm going to close this since it seems like on my experiment with a enum that goes between the address types, the SocketAddr for unix sockets is really bad as it doesn't implement any basic traits like Eq or Clone which are needed here even though their underlying types are trivial to derive it for. Likely just going to keep a personal branch of this project that uses a fork of mio for the ugly solution if I need it.


Fixed environment cloning as part of site create-env

Closes #599

holy linter, batman! :+1:

Closes #601


Warning messages (undefined/object) in switch log

Hi
I'm using portals for some time and it works beautifully!
One question remains: in the switch log, I get some warnings, whenever a job is processed by a portal. The warning message is "object" or "undefined".
Is this standard behaviour or is there someting wrong in my setup?

Same problem here!

Still the same problem.


Rename FromBytes::ref_from[_with_elems]

...to ref_from_bytes[_with_elems]. This brings the names in line with the Ref methods of the same names, and avoids the awkward name ref_from_with_elems.
Similarly, rename Ref::unaligned_from to unaligned_from_bytes. We had already renamed unaligned_from_with_elems to unaligned_from_bytes_with_elems.
Makes progress on #871

Codecov Report
Attention: Patch coverage is 73.91304% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 88.22%. Comparing base (27699bb) to head (8d74855).

Files
Patch %
Lines

src/lib.rs
61.53%
5 Missing :warning:

src/deprecated.rs
0.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1278      +/-   ##
==========================================
- Coverage   88.27%   88.22%   -0.05%
==========================================
  Files          14       14
  Lines        5125     5131       +6
==========================================
+ Hits         4524     4527       +3
- Misses        601      604       +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


PayPal link in documentation doesn't work

I have a PayPal account, and even though I've signed in, visiting the link specified in the documentation (:h send-money) just takes me to my account overview.
The link specified is this: https://www.paypal.com/en_US/mrb/pal=XAC62PML3GF8Q

Dan Church wrote:

I have a PayPal account, and even though I've signed in, visiting the link specified in the documentation (:h send-money) just takes me to my account overview.
The link specified is this: https://www.paypal.com/en_US/mrb/pal=XAC62PML3GF8Q

That link is for getting information about PayPal.
The email address mentioned below it is for making payments.
--
ARTHUR: I've said I'm sorry about the old woman, but from the behind you
looked ...
DENNIS: What I object to is that you automatically treat me like an inferior...
ARTHUR: Well ... I AM king.
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

That link is for getting information about PayPal.

Why isn't the link to https://www.paypal.com, or to https://en.wikipedia.org/wiki/PayPal


Unable to deny access to only some files in subfolders

Title
Unable to deny access to only some files in subfolders
Summary
It's no completely clear how to set multiple resources parameter correctly when using wildcards.  But I found no way to do so. Don't know if this is a bug or just not possible currently.
Actual Results
Every file in a subfolder (except /css/, /img/ and /js/) is denied.
Steps to reproduce

Additional Information

I would like to white list access to index.html, menu.html and *.css in subfolders

But you are whitelisting a bunch of resources.  So I would try to define "deny" wild resource and that explicitly whitelist selected resources.
--resources "uri=/*|roles=role-which-doesnt-exist" \
--resources "uri=/index.html|white-listed=true" \
--resources "uri=/menu.html|white-listed=true" \
--resources "uri=/*/*.css|white-listed=true" \

It may need more tweaking.

 Why?

I meant index.html in subfolders, menu.html in subfolders and *.css in subfolders. This files should be accessible without login, but not the other files in subfolders.

You will get deny response only, when role is defined per resource defined AND that roles is not in the user access token. So I would try to define "deny" wild resource and that explicitly whitelist selected resources.

Obviously my question was a bit misleading. With "deny" I meant "redirects to login".

I think the stripped down question is: in which order are these resources evaluated and does is stop after the first match?
	--resources "uri=/*/index.html|white-listed=true" \
	--resources "uri=/*/menu.html|white-listed=true" \
	--resources "uri=/*/*|roles=role1,rol2|require-any-role=true"

Maybe the problem is related with #661 and this is the only problem.

@escoand indeed, in my experience as explained in #661, --resources "uri=/*/menu.html|white-listed=true" is equivalent to --resources "uri=/*|white-listed=true", which does explain this issue too.


atom launches with no workspace or menus after build/install

Prerequisites

[N] Can you reproduce the problem in safe mode?
[Y] Are you running the latest version of Atom?
[N] Did you check the debugging guide?
[Y] Did you check the FAQs on Discuss?
[Y] Are you reporting to the correct repository?
[Y] Did you perform a cursory search to see if your bug or enhancement is already reported?

For more information on how to write a good bug report or enhancement request, see the CONTRIBUTING guide.
Description
After install a new version following guide available at https://github.com/atom/atom/blob/master/docs/build-instructions/linux.md when trying to launch atom interface window doesn't show any workspace or menus, just a blank browser screen, even removing .atom on home directory doesn't solve (as an attempt to fix this behavior).
Steps to Reproduce

Follow steps to install a new version of atom referenced above

$ script/build
Node: v5.6.0
npm: v3.8.0
Installing build modules...
=> Took 638630ms.

Installing apm...
=> Took 134574ms.

Deleting old packages...
=> Took 388ms.

Deduping modules ✓
=> Took 42654ms.

Running "download-electron" task

Running "download-electron-chromedriver" task

Running "build" task

Running "babel:dist" (babel) task

Running "coffee:glob_to_multiple" (coffee) task
>> 333 files created.

Running "prebuild-less:src" (prebuild-less) task
>> 1891 files compiled, 0 files reused

Running "cson:glob_to_multiple" (cson) task
>> 172 files compiled to JSON.

Running "peg:glob_to_multiple" (peg) task
Generating parser from "node_modules/snippets/lib/snippet-body.pegjs"...
Parser "/usr/local/src/atom/out/Atom Beta/resources/app/node_modules/snippets/lib/snippet-body.js" generated in 27ms.

Running "generate-license:save" (generate-license) task

Running "generate-module-cache" task

Running "compile-packages-slug" task

Running "set-version" task

Running "generate-asar" task

Done, without errors.

Execution Time (2016-03-07 13:56:19 UTC)
loading tasks                      23.9s  ▇▇ 5%
download-electron               5m 16.7s  ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ 66%
download-electron-chromedriver     15.6s  ▇ 3%
build                            1m 3.6s  ▇▇▇▇ 13%
coffee:glob_to_multiple             9.6s  ▇ 2%
prebuild-less:src                  33.2s  ▇▇▇ 7%
cson:glob_to_multiple                 5s  ▇ 1%
generate-asar                         7s  ▇ 1%
Total 7m 59.7s

Start atom

A new blank window (without workspace or menus) shows

**** There's no guarantee that these steps will reproduce the bug once it appears to be something about environment.
Expected behavior:
Open editor window with workspace and menus.
Actual behavior:
Open editor window with no workspace or menus just like a blank window browser.
Versions
$ atom --version
1.6.0-beta6-532c45b
$ apm --version
apm  1.6.0
npm  2.13.3
node 0.10.40
python 2.7.3
git 1.9.1

Sorry to hear you're running into trouble! Does Atom also have Chrome Dev Tools open when this happens? Have you tried quitting Atom completely and restarting it in safe mode? (atom --safe) Did you have a stable version of Atom installed before building Atom from source?

@mnquintana
Yes, Chrome Dev Tools open when start atom.
Yes, I've tried safe mode but no positive effect, same behavior repeats.
Yes, I'd a previous stable version installed before, made building from source too.
Important to mention that it's a similar behavior as reported in #4351 but now on linux environment.
Case it helps, more information about my host is pasted below.
$ gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/lib/gcc/i686-linux-gnu/4.8/lto-wrapper
Target: i686-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu 4.8.4-2ubuntu1~14.04.1' --with-bugurl=file:///usr/share/doc/gcc-4.8/README.Bugs --enable-languages=c,c++,java,go,d,fortran,objc,obj-c++ --prefix=/usr --program-suffix=-4.8 --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --with-gxx-include-dir=/usr/include/c++/4.8 --libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --enable-gnu-unique-object --disable-libmudflap --enable-plugin --with-system-zlib --disable-browser-plugin --enable-java-awt=gtk --enable-gtk-cairo --with-java-home=/usr/lib/jvm/java-1.5.0-gcj-4.8-i386/jre --enable-java-home --with-jvm-root-dir=/usr/lib/jvm/java-1.5.0-gcj-4.8-i386 --with-jvm-jar-dir=/usr/lib/jvm-exports/java-1.5.0-gcj-4.8-i386 --with-arch-directory=i386 --with-ecj-jar=/usr/share/java/eclipse-ecj.jar --enable-objc-gc --enable-targets=all --enable-multiarch --disable-werror --with-arch-32=i686 --with-multilib-list=m32,m64,mx32 --with-tune=generic --enable-checking=release --build=i686-linux-gnu --host=i686-linux-gnu --target=i686-linux-gnu
Thread model: posix
gcc version 4.8.4 (Ubuntu 4.8.4-2ubuntu1~14.04.1)

When the dev tools open please click the red "x" with a number next to it, then paste the error here.  Thanks!

Hi, @50Wliu
As requested, messages from console pasted below.
Error: Cannot find module '../build/Debug/nodegit.node'
at Module._resolveFilename (module.js:336:15)
at Function.Module._resolveFilename (/usr/local/share/atom/resources/app.asar/src/module-cache.js:383:52)
at Function.Module._load (module.js:286:25)
at Module.require (module.js:365:17)
at require (/usr/local/share/atom/resources/app.asar/src/native-compile-cache.js:50:27)
at Object. (/usr/local/share/atom/resources/app.asar/node_modules/nodegit/lib/nodegit.js:15:12)
at Module._compile (/usr/local/share/atom/resources/app.asar/src/native-compile-cache.js:103:30)
at Object.defineProperty.value [as .js] (/usr/local/share/atom/resources/app.asar/src/compile-cache.js:208:21)
at Module.load (module.js:355:32)
at Function.Module._load (module.js:310:12)
at Module.require (module.js:365:17)
at require (/usr/local/share/atom/resources/app.asar/src/native-compile-cache.js:50:27)
at Object. (/usr/local/share/atom/resources/app.asar/src/git-repository-async.js:25:16)
at Module._compile (/usr/local/share/atom/resources/app.asar/src/native-compile-cache.js:103:30)
at Object.defineProperty.value [as .js] (/usr/local/share/atom/resources/app.asar/src/compile-cache.js:208:21)
at Module.load (module.js:355:32)
at Function.Module._load (module.js:310:12)
at Module.require (module.js:365:17)
at require (/usr/local/share/atom/resources/app.asar/src/native-compile-cache.js:50:27)
at Object. (/usr/local/share/atom/resources/app.asar/src/git-repository.js:12:24)
at Object. (/usr/local/share/atom/resources/app.asar/src/git-repository.js:428:4)
at Module._compile (/usr/local/share/atom/resources/app.asar/src/native-compile-cache.js:103:30)
at Object.defineProperty.value [as .js] (/usr/local/share/atom/resources/app.asar/src/compile-cache.js:208:21)
at Module.load (module.js:355:32)
at Function.Module._load (module.js:310:12)
at Module.require (module.js:365:17)
at require (/usr/local/share/atom/resources/app.asar/src/native-compile-cache.js:50:27)
at Object. (/usr/local/share/atom/resources/app.asar/src/git-repository-provider.js:8:19)
at Object. (/usr/local/share/atom/resources/app.asar/src/git-repository-provider.js:83:4)
at Module._compile (/usr/local/share/atom/resources/app.asar/src/native-compile-cache.js:103:30)
handleSetupError @ index.js:62
Line referenced above has this code.
...
56  function handleSetupError (error) {
57    var currentWindow = require('remote').getCurrentWindow()
58    currentWindow.setSize(800, 600)
59    currentWindow.center()
60    currentWindow.show()
61    currentWindow.openDevTools()
62    console.error(error.stack || error)
63  }
...

Thanks for the update @Scherer81!  This looks like a duplicate of #10819 - feel free to subscribe there for updates.


[BUG]Timing Issues while destroying the resources created by Terraform

Describe the bug
I am creating a VM using the terraform (https://github.com/harvester/terraform-provider-harvester/blob/master/examples/resources/harvester_virtualmachine/resource.tf). All the resources are created successfully and VM is is running state. During the terraform destroy, the first time the VM is deleted but not the attached volumes as it attempts to delete Volume before the VM is deleted
harvester_ssh_key.t-7a727cc9010b418786cb819a06c76629: Destroying... [id=default/t-7a727cc9010b418786cb819a06c76629]
harvester_virtualmachine.t-4b8ab968b3ce431c9e26d09ee75c0fad: Destroying... [id=default/t-4b8ab968b3ce431c9e26d09ee75c0fad]
harvester_ssh_key.t-7a727cc9010b418786cb819a06c76629: Destruction complete after 0s
harvester_virtualmachine.t-4b8ab968b3ce431c9e26d09ee75c0fad: Destruction complete after 0s
harvester_volume.t-a0e16bd1d40d4a238f5682b75b1c373e: Destroying... [id=default/t-a0e16bd1d40d4a238f5682b75b1c373e]
harvester_network.t-16aa98e6c84a424a9442fba25445a73e: Destroying... [id=harvester-public/t-16aa98e6c84a424a9442fba25445a73e]
harvester_volume.t-d28fd26f4a594b87aa2ec1159cfae254: Destroying... [id=default/t-d28fd26f4a594b87aa2ec1159cfae254]
harvester_network.t-16aa98e6c84a424a9442fba25445a73e: Destruction complete after 0s
╷
│ Error: admission webhook "validator.harvesterhci.io" denied the request: can not delete the volume t-d28fd26f4a594b87aa2ec1159cfae254 which is currently attached to VMs: default/t-4b8ab968b3ce431c9e26d09ee75c0fad
│
│
╵
╷
│ Error: admission webhook "validator.harvesterhci.io" denied the request: can not delete the volume t-a0e16bd1d40d4a238f5682b75b1c373e which is currently attached to VMs: default/t-4b8ab968b3ce431c9e26d09ee75c0fad
After running terraform destroy again, the volumes are deleted
harvester_volume.t-d28fd26f4a594b87aa2ec1159cfae254: Destroying... [id=default/t-d28fd26f4a594b87aa2ec1159cfae254]
harvester_volume.t-a0e16bd1d40d4a238f5682b75b1c373e: Destroying... [id=default/t-a0e16bd1d40d4a238f5682b75b1c373e]
harvester_volume.t-a0e16bd1d40d4a238f5682b75b1c373e: Destruction complete after 0s
harvester_volume.t-d28fd26f4a594b87aa2ec1159cfae254: Destruction complete after 0s
harvester_image.t-b932ad526ec745eeae6da97df56b902d: Destroying... [id=harvester-public/t-b932ad526ec745eeae6da97df56b902d]
╷
│ Error: admission webhook "validator.harvesterhci.io" denied the request: Cannot delete image harvester-public/t-b932ad526ec745eeae6da97df56b902d: being used by volume default/t-d28fd26f4a594b87aa2ec1159cfae254
Third time when I run terraform destroy, the image is deleted
harvester_image.t-b932ad526ec745eeae6da97df56b902d: Destroying... [id=harvester-public/t-b932ad526ec745eeae6da97df56b902d]
harvester_image.t-b932ad526ec745eeae6da97df56b902d: Destruction complete after 0s
Destroy complete! Resources: 1 destroyed.
To Reproduce
Steps to reproduce the behavior:

Create resources which depends on other resources using terraform

Expected behavior
During terraform destroy the resources should be destroyed in the order
Support bundle

Environment:

Harvester ISO version: master
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630):Ipxe Vagrant env

Additional context
Add any other context about the problem here.

@chajain can u provide your tf files?

@chajain can u provide your tf files and terraform-provider-harvester version?
provider.tf
terraform {
required_version = ">= 0.13"
required_providers {
harvester = {
source  = "registry.terraform.io/harvester/harvester"
version = "~> 0.2.2"
}
}
}

provider "harvester" {
kubeconfig = "/root/harv-ter/tests/terraform_test_artifacts/.kube/config"
}
resource_image.tf
resource "harvester_image" "t-6b3c4b2c245f41d889c64c2b41be692d" {
name         = "t-6b3c4b2c245f41d889c64c2b41be692d"
namespace    = "harvester-public"
display_name = "t-6b3c4b2c245f41d889c64c2b41be692d"
url          = "http://download.opensuse.org/repositories/Cloud:/Images:/Leap_15.2/images/openSUSE-Leap-15.2.x86_64-NoCloud.qcow2"
source_type  = "download"
lifecycle {
ignore_changes = all
}
}
esource "harvester_ssh_key" "t-9972659c85444aa3810e48a3baae30f6" {
name        = "t-9972659c85444aa3810e48a3baae30f6"
public_key  = "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAAAgQDE8iu9Z6JlCjKyIgTHhm/A4fLcczIENVd7F0ZgeHZUJyB4Pf/VHZUzIlbbnxM53QaAnUEd6uRn5GTYJ5yeZhqP7JuatROuFmAySSkMCyk/SF6hzPKf8VnzlKc0FKh5wA976KBDZmXtJuLajwZgZVJn2XxnE+OT8bQjn6QYP9OcNQ=="
lifecycle {
ignore_changes = all
}
}
resource_network.tf
resource "harvester_network" "t-ad8be02015c14921ae69dd1635b1f536" {
name      = "t-ad8be02015c14921ae69dd1635b1f536"
namespace = "harvester-public"
vlan_id = 10
lifecycle {
ignore_changes = all
}
}
resource_vm.tf
resource "harvester_virtualmachine" "t-416fbb6a8f004d4ebdc54e1a7cb70773" {
depends_on = [harvester_volume.t-2898d6227a0a495d801c470264fa7afa, harvester_volume.t-97d05a5245f3445b9445a1772d7df844, harvester_network.t-ad8be02015c14921ae69dd1635b1f536]
name        = "t-416fbb6a8f004d4ebdc54e1a7cb70773"
description = "test raw image"
tags = {
ssh-user = "root"
}
cpu    = 1
memory = "2Gi"
start        = true
hostname     = "t-416fbb6a8f004d4ebdc54e1a7cb70773"
machine_type = "q35"
ssh_keys = [
"t-9972659c85444aa3810e48a3baae30f6"
]
network_interface {
name         = "default"
model        = "virtio"
type         = "masquerade"
}
network_interface {
name         = "nic-1"
model        = "virtio"
type         = "bridge"
network_name = "harvester-public/t-ad8be02015c14921ae69dd1635b1f536"
}
disk {
name       = "rootdisk"
type       = "disk"
size       = "10Gi"
bus        = "virtio"
boot_order = 1
existing_volume_name = "t-97d05a5245f3445b9445a1772d7df844"
auto_delete          = false

}
disk {
name = "mount-disk"
type = "disk"
bus  = "virtio"
existing_volume_name = "t-2898d6227a0a495d801c470264fa7afa"
auto_delete          = false

}
cloudinit {
user_data    = "#cloud-config\nchpasswd:\n  list: |\n    root:linux\n  expire: false\nssh_pwauth: true\nusers:\n  - name: root\n    ssh_authorized_keys:\n      - ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAAAgQDE8iu9Z6JlCjKyIgTHhm/A4fLcczIENVd7F0ZgeHZUJyB4Pf/VHZUzIlbbnxM53QaAnUEd6uRn5GTYJ5yeZhqP7JuatROuFmAySSkMCyk/SF6hzPKf8VnzlKc0FKh5wA976KBDZmXtJuLajwZgZVJn2XxnE+OT8bQjn6QYP9OcNQ==\npackage_update: true\npackages:\n  - qemu-guest-agent\nruncmd:\n  - - systemctl\n    - enable\n    - '--now'\n    - qemu-ga\n"
network_data = "#cloud-config\nversion: 1\nconfig:\n  - type: physical\n    name: eth0\n    subnets:\n      - type: dhcp\n  - type: physical\n    name: eth1\n    subnets:\n      - type: dhcp\n"
}
}
resource_volume_image.tf
resource "harvester_volume" "t-97d05a5245f3445b9445a1772d7df844" {
depends_on = [harvester_image.t-6b3c4b2c245f41d889c64c2b41be692d]
name  = "t-97d05a5245f3445b9445a1772d7df844"
size  = "10Gi"
image = "harvester-public/t-6b3c4b2c245f41d889c64c2b41be692d"
lifecycle {
ignore_changes = all
}
}
resource_volume.tf
resource "harvester_volume" "t-2898d6227a0a495d801c470264fa7afa" {
name  = "t-2898d6227a0a495d801c470264fa7afa"
size  = "10Gi"
lifecycle {
ignore_changes = all
}
}
resource_keypair.tf

@futuretea @guangbochen Please cut a new release of terraform-harvester-provider.

@futuretea @guangbochen I installed version 0.2.3 and still see the issues during destroy of virtual machine.  Resources: 3 destroyed.

@chajain  This error occurs because the VM has not been deleted successfully after 15s. Could you please help confirm how long it will take for the VM to be deleted in your environment?

@futuretea On my env it took atleast 20-25 secs to terminate the VM

@chajain Increase timeout to 300s and fix cloud-init bug in release v0.2.5

@futuretea On a 3 node harvester setup we are also encountering the i/o timeout sometimes during creation of a resource or destroy of the resource for images, volumes and networks also.
AssertionError: Failed to run terraform : rc: 1, stdout: bError:Post "https://<IP_ADDRESS>:30443/apis/k8s.cni.cncf.io/v1/namespaces/harvester-public/network-attachment-definitions": dial tcp <IP_ADDRESS>:30443: i/o timeout with harvester_network.t-1de8f15a940b44cb85aaa7007f4eea43 on resource_network.tf line 1, in resource "harvester_network" "t-1de8f15a940b44cb85aaa7007f4eea43":\n\x1b[31m\xe2\x94\x82\x1b[0m \x1b[0m   1: resource "harvester_network" "t-1de8f15a940b44cb85aaa7007f4eea43"
AssertionError: Failed to run terraform : rc: 1, stdout: b'Error:Post "https://<IP_ADDRESS>:30443/api/v1/namespaces/default/persistentvolumeclaims": dial tcp <IP_ADDRESS>:30443: i/o timeout\   with harvester_volume.t-25fc9103bf37446199205322469e1fc0,\ on resource_volume.tf line 1, in resource "harvester_volume" "t-25fc9103bf37446199205322469e1fc0":\n   1: resource "harvester_volume" "t-25fc9103bf37446199205322469e1fc0"
Can you please increase the timeouts for creation and destroy of volumes, images and network resources also.

@chajain

Can you please increase the timeouts for creation and destroy of volumes, images, keypair and network resources also?
There are no any timeout code for these resources.

dial tcp <IP_ADDRESS>:30443: i/o timeout
This should be a network timeout

Tested using the latest terraform-harvester-provider 0.2.5. The VM is created and destroyed successfully using terraform. Used the same resource as mentioned earlier in the Bug.


Feature/authentication

@skeep  Kindly review the pull request and let us know if there are any changes

@skeep changed the variable names


Saving only flagfiles that appear in the --helpshort list?

Is there a way to only get the "key" flags to be outputted by FLAGS.flags_into_string()?
i.e. the ones documented by --helpshort
I would like to "save" the options of a neural network training. However, the FLAGS.* contains hundreds of options that I have never defined. The --help seemed to understand the difference between the full set, and the ones that my application defined.
It wold have to 2x main uses:

re-running the script as it was run before (this part would be fine with the existing "flags_into_string")
manually inspecting the file to look at the used parameter values (this is why the long list of additional flags is very fastidious)

(Transplanted discussion from #57 as per @rickeylev request)

The way --help distinguishes between your app's flags and other flags is designating flags defined by the main module as "key" flags. The main module can also adopt extra flags to be marked as key (this is usually used if you're refactored flags to some common place, but still want them to show up in --help by default).
If you look at the api of FlagsValues (this is the class that flags.FLAGS is), it has a couple functions for getting flags by module names.
In my prior post the "..." were meant as place holders. Replace them with the appropriate bits of code. Here's a slightly revised version:
key_flags = FLAGS.get_key_flags_for_module(module_name)
'\n'.join(f.serialize() for f in key_flags)

I think you want module_name to be the string __main__, though I'm not 100% sure. It'll probably be that or the fully qualified name of your module.
That little join() loop will get you something you can save to disk that --flagfile will be able to read. Its basically what flags_into_string() does internally.
To call flags_into_string() with a custom set of flags defined, you'll have to create a flags.FlagsValue() object, then populate it with the flags you want. I think something like this:
fv = flags.FlagsValues()
for f in FLAGS.get_key_flags_for_module(module_name):
  fv[f.name] = f
fv.flags_into_string()

(This is the same as the prior posting, but assigns the flag into the FlagsValues object in a (I think) more correct way.)
Either way (join() or building a FlagsValues) should give you something you can write to disk that --flagfile will understand.

I see, sorry, I interpreted the ... as a python object :)
Poking around a bit more, I found this:
https://github.com/tensorflow/models/blob/master/research/gan/progressive_gan/train_main.py
And indeed, this works as desired (while "__main__" would not):
import sys
key_flags = FLAGS.get_key_flags_for_module(sys.argv[0])
s = '\n'.join(f.serialize() for f in key_flags)
print('absl user specified flags:\n{}'.format(s))

Glad you found a solution!


Restore Python 36 support

Hi!
There is not much that prohibits to still support Python 3.6 which is still widely supported on Linux distros.
This PE re-enables Python 3.6 support
I also removed some upper bounds on deps to avoid some issues, as highlighted in https://iscinumpy.dev/post/bound-version-constraints/
Thanks for your kind consideration!

Older versions of this library still work with and support Python 3.6. Considering mainline 3.6 support ended on 23 Dec 2021 (and 3.7 on 27 Jun 2023), along with many supporting tools such as pytest, black, pip etc.) all having since dropped both in recent releases, it would be a maintenance nightmare to continue support for unsupported Python versions.


When I use Other in Fields and then use Enum , the generated code is wrong.

[ ] The issue is present in the latest release.
[ ] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

Expected Behavior 🤔

Steps to Reproduce 🕹

package schema

import (
	"entgo.io/ent"
	"entgo.io/ent/schema/field"
	"internal/user"
)

type User struct {
	ent.Schema
}

func (User) Fields() []ent.Field {
	return []ent.Field{
                field.Other("account", &user.User{}),
		field.Enum("state").Values("on", "off"),
	}
}

generate code
type user.State string

other code

Your Environment 🌎

Tech
Version

Go
1.19.4

Ent
0.11.10

Same for JSON as the package imported "internal/user" matches name I believe. Is there a fix for this other than renaming  "internal/user"?


The Documentation state that the resource file usese two-letter culture name and two-letter subculture. This seems to be incorrect.

@LokiMidgard commented on Thu Apr 25 2019

When you package your application's resources, you must name them using the resource naming conventions that the common language runtime expects. The runtime identifies a resource by its culture name. Each culture is given a unique name, which is usually a combination of a two-letter, lowercase culture name associated with a language and, if required, a two-letter, uppercase subculture name associated with a country or region. The subculture name follows the culture name, separated by a dash (-). Examples include ja-JP for Japanese as spoken in Japan, en-US for English as spoken in the United States, de-DE for German as spoken in Germany, or de-AT for German as spoken in Austria. See the National Language Support (NLS) API Reference at the Go Global Developer Center for a complete list of culture names.

Generating a Resource using Visual Studio (2019) and setting language to different simplified chinise versions result in following files

Form1.zh-Hans.resx
Form1.zh-Hans-HK.resx
Form1.zh-Hans-MO.resx

The subculture does not consists of a two-letter subculture code.

Dokumentdetails
⚠ Bearbeiten Sie diesen Abschnitt nicht. Er ist für die Verknüpfung von docs.microsoft.com zum GitHub-Artikel erforderlich.

ID: 4e742bf0-abf8-259c-5194-3687febd38b0
Version Independent ID: 6d1d9bfb-6174-6215-befe-641babe8a746
Content: Verpacken und Bereitstellen von Ressourcen in .NET-Apps
Content Source: docs/framework/resources/packaging-and-deploying-resources-in-desktop-apps.md
Product: dotnet-framework
GitHub Login: @rpetrusha
Microsoft Alias: ronpet

Hi team,
I'm moving this here since the contributor is making a suggestion on the original documentation
best

The documentation indicates that this is usually a combination of a two-letter language code and a two-letter country/region code. I'm going to close this as By Design; the qualification is here is adequate, even if some culture/region names violate the rule.

Thanks for the fast response.
@rpetrusha The documentation also includes some samples.

[...] Examples include ja-JP for Japanese [etc ...]
Could it make sense to include a sample that violate this usally. This would emphasize that there are exceptions.

It might be helpful to add some examples with code that are more than two letters in length, @LokiMidgard. I'll reopen this issue and add it to our backlog, as well as to the community contributor's project.


Long text now wraping

I am having long text and they are partially visible as rest are not visible and get hide

any idea how to fix? 👍

I think I'm having the same problem. Even there is space available, the text is getting hidden.


Matrix Strategy

Adding a strategy to run in 3 regions : eastus, westus2, southcentralus
location parameter was never set in the 03 notebook but added azlocation to set that field when running that notebook.

/azp run ai ml train


Add support for the blif construct .subckt

Hi,
from what I see in the blif parser, it appears that the .subckt
construct is not supported yet.
I would like this supported because Yosys generated .subckt
commands when the -noflatten option was used.
Symptom:
top.blif:42: fatal error: unknown directive
Workaround:
Don't use subckt. (For the yosys flow, don't use the -noflatten option)
PS: Thanks for creating this project. Since there exists a workaround, it might make sense
to close this as won't fix.

This would be reasonable to add.  It might also be useful for non-yosys tools that want to generate .blif files directly.  I'm going to leave it open as an enhancement.  Thanks for the suggestion!

I ran into this issue while working with yosys.
Another workaround that might be helpful to people who aren't happy with avoiding -noflatten for any reason. Instead of writing:
synth_ice40 … -blif <name.blif>

you can flatten your design after synthesis and write it then.
synth_ice40 …
flatten
write_blif -gates -attr -param <name.blif>

FYI Arachne is essentially not maintained at this point as nextpnr is a far more capable replacement.


want to reuse common code and template

It is a wonderful example for go-zero.  And I want  to reuse the common code, could you share the common code as a single git.
Want to reuse:

common code
template （especially db related)

my suggestion

user a significative name not looklook
give a shell or python script to install the template from git

这个获取你可以自己抽离一个独立库使用“go get”导入即可

You can get this by pulling out a separate library and importing it using "go get".


Bug: Cannot create new customer

What are you trying to achieve?
To create new customer.
Steps to reproduce the problem

Execute the following query

mutation CustomerCreate($input: UserCreateInput!) {
    customerCreate(input: $input) {
        errors {
            field
            message
        }
        user {
            email
            firstName
            lastName
        }
    }
}

Returns error message:"To access this path, you need one of the following permissions: MANAGE_USERS"

What did you expect to happen?
If I should to grant permission, I don't know how. Only added from dashboard to staff members.
Logs
No response
Environment
Saleor version:3.18.3

Hi @kesimlimert,
The customerCreate mutation is for the staff users with MANAGE_USERS permission. If you want to create an account as a anonymous user you should use AccountRegister mutation. Please review the docs.


Support libkv.WatchTree chan errors:

libkv.WatchTree returns a channel whose messages represent changes
to the watched tree. In situations where libkv cannot read from the
underlying store, libkv will close the provided channel.
This PR handles this edge case and fixes #238.

Great contribution @advait ! Thanks a lot :)
LGTM

@advait needs a rebase :sweat_smile:

LGTM 🐰
Thanks @advait


update is alpha string algorithm

oh, it's my bad. i'll change it back.

It's ok. I will close this PR now.
Thanks for the effort.


pbjs generated types compatibility.

Hello and excuse me if the answer is obvious as I haven't looked heavily into the inner workings of pbsjs/ts-proto but what is the reason for the switch from .fromJSON to .fromPartial ?
The reason I'm asking is because generated types from pbjs only output the former function while ones from ts-proto output both functions. Thus keeping .fromJSON seems like would aid backwards compatibility.
As it stands we need to update our build pipeline to use ts-proto instead to generate types (which isn't as easy as it sounds) or cosmjs complains with a:
TypeError: type.fromPartial is not a function

Sorry for breaking your code and thanks for bringing this up. It seems like we need a few little case distiinctions on order to support ts-proto generated types and pbjs generated types. I'll create a test that ensures pbjs works.

awesome, thanks!

@clockworkgr could you have a look at #693, especially packages/proto-signing/src/registry.ts?

Released as part of 0.24.0-alpha.26


init

Added script that corresponds with the following KB article:
https://help.pdq.com/hc/en-us/articles/17108550854939-Generating-Inventory-Collections-for-Applications-using-PowerShell


Add Background image and custom button.

Thanks for the awsome control. Is it possible to add Custom image and custom button in alertview ?

You can't right now, but It's easy to fork and add changes, it's made with UIViews, so you can add any UI element as child.


[RESTEASY-1316] - Deprecate Jettison for Jackson

RESTEasy currently rely on Jettison to support JAXB -> JSON conversion. We need to use Jackson to do this job instead. And this is a possible solution:
https://github.com/FasterXML/jackson-modules-base/tree/master/jaxb

The resteasy-link itself doesn't rely on Jettison. But when it's working with JAXB annotated classes together, it relies on Jettison provider:
package org.jboss.resteasy.links.test;

import org.jboss.resteasy.links.RESTServiceDiscovery;
import org.jboss.resteasy.links.ResourceFacade;
import org.jboss.resteasy.links.ResourceID;

import javax.xml.bind.annotation.XmlAccessType;
import javax.xml.bind.annotation.XmlAccessorType;
import javax.xml.bind.annotation.XmlAttribute;
import javax.xml.bind.annotation.XmlElement;
import javax.xml.bind.annotation.XmlRootElement;
import javax.xml.bind.annotation.XmlTransient;

import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;

@XmlRootElement
@XmlAccessorType(XmlAccessType.NONE)
public class ScrollableCollection implements ResourceFacade<Comment> {
   @ResourceID
   private String id;
   @XmlAttribute
   private int start;
   @XmlAttribute
   private int limit;
   @XmlAttribute
   private int totalRecords;
   @XmlTransient
   private String query;
   @XmlElement
   private List<Comment> comments = new ArrayList<Comment>();
   @XmlElement
   private RESTServiceDiscovery rest;
...

How to serialize JAXB object to JSON with JAXB reference implementation? - Stack Overflow

After talking with Alessio, we need to spilt this task into two parts:

Rewrite the RESTEasy tests to remove JAXB classes, so it won't need jettison's JSON output ability. Which will be put into this PR.
The other one is: RESTEASY-2067 Using Jackson to support JAXB json output - JBoss Issue Tracker

Jackson provider has ability to marshal JAXB annotated classes:

However, if I changed dependency in resteasy-link:

Then it will have test failures:

I'm analyzing the failures one-by-one, and will fix them in this PR.

TestLinksInvalidEL.testELWorksWithoutPackageJSON
This test expect the following class will fail the EL validation:

For this test failure, the root cause it that jettison-provider will trigger the EL validation:

We can see from above that AbstractJAXBProvider  finally calls decorateMarshaller method. Here are related classes:

From above we can see the RESTUtils will register EL validation.
If we remove the decorator from AbstractJaxbProvider:

Then we can see the tests failure too by using jettison-provider:

So we need to make jackson-provider to use the decorator to validate the EL expression, and make this test pass.

org.jboss.resteasy.links.test.el.TestLinksNoPackage
The root cause is same with TestLinksInvalidEL.testELWorksWithoutPackageJSON in above.

TestFacadeLinks
TestLinks
These two tests failed because the org.jboss.resteasy.plugins.providers.jackson.ResteasyJackson2Provider.readFrom can't parse the JAXB classes correctly:

The above test failures should be fixed by enabling jackson JAXB provider. But the first step should be removing jettison-provider dependencies from these modules:
$ find . | grep pom.xml | xargs -I% grep -n 'resteasy-jettison' % /dev/null
./resteasy-spring/pom.xml:59:            <artifactId>resteasy-jettison-provider</artifactId>
./resteasy-bom/pom.xml:46:                <artifactId>resteasy-jettison-provider</artifactId>
./resteasy-links/pom.xml:74:            <!--<artifactId>resteasy-jettison-provider</artifactId>-->
./testsuite/unit-tests/pom.xml:45:            <artifactId>resteasy-jettison-provider</artifactId>
./testsuite/integration-tests/pom.xml:181:            <artifactId>resteasy-jettison-provider</artifactId>
./providers/jackson2/pom.xml:37:            <artifactId>resteasy-jettison-provider</artifactId>
./providers/jettison/pom.xml:10:    <artifactId>resteasy-jettison-provider</artifactId>
./distribution/pom.xml:63:            <artifactId>resteasy-jettison-provider</artifactId>
./jboss-modules/pom.xml:174:            <artifactId>resteasy-jettison-provider</artifactId>
./profiling-tests/pom.xml:40:            <artifactId>resteasy-jettison-provider</artifactId>

The jettison dependencies inside:

resteasy-spring
profiling-tests

can be replaced directly.
The jettison dependency inside:

resteasy-jackson2-provider

can be removed.

In conclusion:

resteasy implementations itself doesn't rely on jettison
the resteasy-link usage scenario heavily use the JAXB annotated classes, and uses some functions in jaxb-provider, which is connected with jettison-provider which is not provided in jackson-provider yet.
jackson2-provider provides JAXB marshalling, but doesn't have some specific functions we defined in jaxb-provider(which is used by jettison-provider).

@asoldano Hi Alessio,
Here's what I have done for the first step:

removed jettison-provider from the project
removed jettison tests from integration tests
removed jettison component from boss-modules
disabled a part of resteasy-links tests that using complex JAXB annotations.
replaced jettison-provider with jackson-provider for resteasy-spring.
replaced jettison-provider with jackson-provider for the rest of tests.

The next step is to make jackson2-provider to work with the disabled resteasy-links + complex JAXB annotation related tests.
I feel this option is better than "rewriting the JAXB annotation related resteasy-links tests". The reasons are:

Actually jackson2-provider supports JAXB classes(it's jackson feature), but just not complete yet to support all the functions currently provided by our jaxb-provider + jettison-provider. So it's necessary  for us to add the functions into jackson2-provider for these JAXB use scenarios.
The reason that  the part of disabled resteasy-links tests are not working is not because jackson2-provider doesn't support JAXB annotations. The reason is that these tests contains some EL validations functions. These functions are defined in RESTUtils in jaxb-provider, and it's used by jettison-provider. We can consider this is the "additional" functions provided by us, and it's used by resteasy-link tests(use cases). So we need to make jackson2-provider to support the EL validation too.(The details of the problem can be found in above comments and screenshots).

So my plan for the second step is to improve jackson2-provider so it can work with the part of disabled resteasy-link tests.
Could you please provide some feedback? Thanks!


Semver type definition can't be resolved from @opentelemetry/instrumentation when use rollup bundler

What happened?
Steps to Reproduce
The following is the rollup.config.js I use to create a browser esm bundle.  I also tried to add "@types/semver": "^7.5.6" in my package.json, still doesn't stop the error in Actual Result section
import resolve from '@rollup/plugin-node-resolve';
import commonjs from '@rollup/plugin-commonjs';
import { getBabelOutputPlugin } from '@rollup/plugin-babel';
import sourcemaps from 'rollup-plugin-sourcemaps';
import json from '@rollup/plugin-json';

function getBabelPlugin() {
  return getBabelOutputPlugin({
    // default target to es5
    presets: ['@babel/preset-env'],
    allowAllFormats: true
  });
}

const plugins = [
  sourcemaps(),
  json(),
  resolve({
    browser: true
  }),
  commonjs({
 /** I have to manually create type definition inside my code, because the following error from RequireInTheMiddleSingleton.js from otel
[!] Error: 'Hook' is not exported by node_modules/require-in-the-middle/index.js, imported by<EMAIL_ADDRESS>https://rollupjs.org/guide/en/#error-name-is-not-exported-by-module
<EMAIL_ADDRESS>(27:9)
25:     throw new TypeError(s ? "Object is not iterable." : "Symbol.iterator is not defined.");
26: };
27: import { Hook } from 'require-in-the-middle';
**/
    include: ['node_modules/uuid/**/*','node_modules/shimmer/index.js', 'node_modules/semver/**/*', 'node_modules/require-in-the-middle/index.js']
  }),
  getBabelPlugin(),
];

export default {
  onwarn(warning, warn) {
  // I have to suppress a lot undefined warning from Otel plugins
    if (warning.code === 'THIS_IS_UNDEFINED') return;
    warn(warning);
  },
  input: 'dist/index.js',
  output: [
    {
      format: 'cjs',
      sourcemap: true,
      file: 'dist/bundle.js'
    },
    {
      format: 'esm',
      sourcemap: true,
      file: 'dist/bundle.esm.mjs'
    }
  ],
  plugins
};

Following are relevant typescript compiler options from tsconfig.json
 "module": "es2015",
    "moduleResolution": "node",
    "target": "ESNext",
    "noImplicitAny": true,
    "strictNullChecks": true,
    "noImplicitThis": true,
    "noUnusedLocals": true,
    "noUnusedParameters": true,
    "removeComments": false,
    "preserveConstEnums": true,
    "sourceMap": true,
    "esModuleInterop": false,
    "types": [],
    "outDir": "dist",
    "lib": ["dom", "es5", "es2015.promise", "es2015.collection", "es2015.iterable", "es2019", "es2020.promise"],
    "typeRoots": [],
    "baseUrl": ".",
    "paths": {
      "uuid/v4": ["types/uuid/v4.d.ts"],
      "semver"<EMAIL_ADDRESS>      "shimmer": ["types/shimmer/index.d.ts"],
      "require-in-the-middle": ["types/require-in-the-middle/index.d.ts"],
    }

Expected Result
Generate dist/bundle.esm.mjs
Actual Result
[!] Error: 'satisfies' is not exported by<EMAIL_ADDRESS>imported by<EMAIL_ADDRESS>https://rollupjs.org/guide/en/#error-name-is-not-exported-by-module
<EMAIL_ADDRESS>(44:9)
42: import * as path from 'path';
43: import { types as utilTypes } from 'util';
44: import { satisfies } from 'semver';
             ^
45: import { wrap, unwrap } from 'shimmer';
46: import { InstrumentationAbstract } from '../../instrumentation';
Error: 'satisfies' is not exported by<EMAIL_ADDRESS>imported by<EMAIL_ADDRESS>    at error (/myrepo/node_modules/rollup/dist/shared/rollup.js:198:30)

Additional Details
I tried setup using auto-Instrumentations-web plugin or the individual plugins, see below otel setup code. Both have the same compilation error.
I got the "  'Hook' is not exported by node_modules/require-in-the-middle/index.js" error first.  Then I work around it by copying the following type definition from otel to my code base. However, this shouldn't be the way how down stream consume otel library
declare module 'require-in-the-middle' {
  namespace hook {
    type Options = {
      internals?: boolean;
    };
    type OnRequireFn = <T>(exports: T, name: string, basedir?: string) => T;
    type Hooked = { unhook(): void };
  }
  function hook(
    modules: string[] | null,
    options: hook.Options | null,
    onRequire: hook.OnRequireFn
  ): hook.Hooked;
  function hook(
    modules: string[] | null,
    onRequire: hook.OnRequireFn
  ): hook.Hooked;
  function hook(onRequire: hook.OnRequireFn): hook.Hooked;
  export = hook;
}

After I work around the require-in-the-middle type error, then I got the error from semver. Then I tried to add "@types/semver": "^7.5.6" in my package.json. This doesn't help. Also, I don't think it's the right way to get otel library ESM build in general. Please provide some insight. Thank you!!!
OpenTelemetry Setup Code
const contextManager = new ZoneContextManager()
  const webProvider = new WebTracerProvider({
      resource: new Resource({
        [SemanticResourceAttributes.SERVICE_NAME]: 'my-service',
        [SemanticResourceAttributes.SERVICE_VERSION]: '0.0.1',
      })
    });
    webProvider.addSpanProcessor(new SimpleSpanProcessor(new ConsoleSpanExporter()));
    webProvider.register({
      contextManager: contextManager
    });
    contextManager.enable();

    registerInstrumentations({
      instrumentations: [
        getWebAutoInstrumentations({
          // load custom configuration for xml-http-request instrumentation
          '@opentelemetry/instrumentation-xml-http-request': {
            propagateTraceHeaderCorsUrls: [
              /.+/g,
            ],
          },
          // load custom configuration for fetch instrumentation
          '@opentelemetry/instrumentation-fetch': {
            propagateTraceHeaderCorsUrls: [
              /.+/g,
            ],
          },
        }),
        //new FetchInstrumentation(),
        // new DocumentLoadInstrumentation(),
        // new XMLHttpRequestInstrumentation()
      ],
      tracerProvider: webProvider
    });

package.json
"dependencies": {
    .....
    "@opentelemetry/api": "^1.7.0",
    "@opentelemetry/auto-instrumentations-web": "^0.35.0",
    "@opentelemetry/context-zone": "^1.20.0",
/** I have to ping to 1.19.0 because between @opentelemetry/sdk-trace-base version 1.19.0 and 1.20.0 there is backwards incompatible definition of Span and Tracer **/
    "@opentelemetry/sdk-trace-web": "1.19.0",
    "@opentelemetry/semantic-conventions": "1.19.0",
  ...
"devDependencies": {
....
"@types/semver": "^7.5.6",
....
},
"resolutions": {
    "@opentelemetry/sdk-trace-base": "1.19.0"
  },
}

Relevant log output
No response

Can you have a look at the opentelemetry-sandbox-web-js as we use rollup to construct bundles for web instrumentations.
Here is the rollup configuration that is used their, where we include nodeResolve with the browser:true as well
https://github.com/open-telemetry/opentelemetry-sandbox-web-js/blob/d8fab86386dd3cc207b845a3ea3ea31ed74967ea/rollup.base.config.js#L110-L134

Thanks a lot for the quick response @MSNev I had browser:true in the '@rollup/plugin-node-resolve' plugin config already.  I named the plugin as resolve instead of nodeResolve.  I just tried adding the other 2 flags for nodeResolve. I still get the same error message.
   module: true,
    browser: true,
    preferBuiltins: false

I also tried to change the commonjs plugin to include all node modules as the sandbox-web config, which I don't want to do that for my code.
commonjs({
    browser: true,
    include: 'node_modules/**'
    // include: ['node_modules/uuid/**/*', 'node_modules/semver/**/*', 'node_modules/shimmer/index.js', 'node_modules/require-in-the-middle/index.js']
  }),

That still doesn't help.
Other than that, my rollup.config.js looks pretty similar as the sandbox-web-js.
Any other suggestions?

Thanks a lot for the quick response @MSNev.  I just realize the error message is from the node bundle build, not from the browser one. Sorry about the wrong description in the issue. My app does server side rendering.  I have two rollup.config, one for browser, the other is for node.   The one I pasted in the description is for browser. The following is for Node.
import nodeResolve from '@rollup/plugin-node-resolve';
import commonjs from '@rollup/plugin-commonjs';
import { getBabelOutputPlugin } from '@rollup/plugin-babel';
import sourcemaps from 'rollup-plugin-sourcemaps';
import json from '@rollup/plugin-json';

function getBabelPlugin() {
  return getBabelOutputPlugin({
    presets: [['@babel/preset-env']]
  });
}

const plugins = [
  sourcemaps(),
  json(),
  nodeResolve({
    browser: false,
    exportConditions: ['node']
  }),
  commonjs({
    include: ['node_modules/uuid/**/*', 'node_modules/semver/**/*', 'node_modules/shimmer/index.js', 'node_modules/require-in-the-middle/index.js']
  }),
  getBabelPlugin()
];

export default {
  onwarn(warning, warn) {
    if (warning.code === 'THIS_IS_UNDEFINED') return;
    warn(warning);
  },
  input: 'dist/index.js',
  output: [
    {
      format: 'cjs',
      sourcemap: true,
      file: 'dist/node-bundle.js'
    },
    {
      format: 'esm',
      sourcemap: true,
      file: 'dist/node-bundle.esm.mjs'
    }
  ],
  plugins
};

I tried change the nodeResolve plugin config from browser: false to true. The build got generated.  But that's not going to work for the Node environment.  Do you have example how to create a Node build?
Thanks a lot!!!

Yeah, the sandbox only builds the "browser" bundles (as it's web focused), so we effectively don't use rollup for the node build.
Looking at the semver package versions 7.5.2 and 7.5.4 the satisifies is being "exported" in the index.js, I don't think the @types/semver would help in any way as these are really just the definitions and not the "resolving" of the bundles.
I'm wondering if it's got something to do with the hack required for the import-in-the-middle where rollup is not "finding" the satisifies... So you would need to "pre-declare" that this really does exist like the global node operations, this way it would just add in the usage without validating it -- it's been a long time since I last did something like that so I don't immediately recall the configurations.

Maybe just adding something like the following to the rollup config to "declare" that it exists??? -- guessing
external: ['satisifies'] // <-- suppresses the warning

@MSNev  I tried the external option, it didn't work. However, I did the following hack in the build output of
<EMAIL_ADDRESS>Then the build works.
//import { satisfies } from 'semver';
const satisfies = require('semver');

This indicates that the module import can't resolve the semver package in the parent node_modules under node_modules/@opentelemetry/instrumentation.  But the node require can.
How does your node build work?  I wonder how your build tooling resolve the dependencies from the parent node_modules. Is there any config you can add in the tsconfig.esm.json or the package.json to get node module resolution as require for the downstream consumer?

How does your node build work?

With rollup it doesn't as we only build the browser packages with it, the main repo uses webpack (for testing) and doesn't actually create bundles.
There are however esm definition issues
@dyladan This looks like it might be related to the esm export issues??

I don't think it's related to the esm publishing issues because that only affects node to my knowledge. I think rollup and webpack both support the way we publish our esm modules. In any case, it's being updated anyway.

@dyladan I encounter this error when I try to export a Node format bundle. My application has server side rendering, the build system requires downstream library to publish a bundled Node esm package.  I am working on a library.  Therefore, this is a corner case.  The rollup esm bundle for Browser works, but not Node.
Did you publish a new version to fix the Node publishing problem?  Which library should I update?

No new library has been published for the esm fix yet. I'll try to work on that this week

This looks like a duplicate of #3989. @tsubomii could you have a look at the issue and let us know if this is the same problem? :thinking:

Seems right to consider this a duplicate of #3989 , will close this as it's being tracked elsewhere.


update image retrieval schema to include match field

Update image retrieval schema to include a "match" field

@pj-ms It seems someone else need to review the PR since it's not letting me merge. Can you please take a look?


Add nuel.pw

Hey hey :) It's been a while. My website is back, new and improved. So I figured I'd request to join again.
I've added the webring icon to the About section. (Click on the nuel face.) It's a details/summary tag in disguise, so it's accessible without JavaScript.
I have also made a button to go with my entry.
Hope this is okay, let me know if I need to change anything!

I'm currently away from reliable internet, if you leave your PR open,
I'll review it when I'm back to a wifi internet connection.

My bad! No rush and safe travels :)

Heya! Just a heads up that my link to the webring has now moved this page: https://nuel.pw/more.html
A little less obscure than just a random icon in the about section with no explanation. :)

I love the new look, it had been a while since I last saw your website. It looks great! welcome to the webring :)

Aw, thanks <3 Good to be back!


Update gulp-sass to support node 8.x

Have you tried the examples with updated version of Node (8.X)?

I think is working isn't it?

But maybe I'll downgrade node version with nvm and just use gulp-sass 2.x version because we dont have time to check all

Working previous version (gulp-sass 2.x) with node 6.x


MGMT-19262: Create tekton pipelines for acm 2.13

Description

This will finish the onboarding process for acm 2.13
How was this code tested?

Assignees

/cc @pastequo
/cc @
Links

Part-of MGMT-19262
Checklist

[x] Title and description added to both, commit and PR
[x] Relevant issues have been associated
[x] Reviewers have been listed
[x] This change does not require a documentation update (docstring, docs, README, etc)
[ ] Does this change include unit tests (note that code changes require unit tests)

/retest

/retest

/retest assisted-image-service-mce-downstream-2-13-on-pull-request

/ok-to-test

/retest

closing the pr because konflux didn't like changing the target branch, I'll open a different one


Tag taxonomy project: Q2, tag analysis and deriving a controlled vocab

Follow-on from the work done in Q1 here https://github.com/SingularityNET-Archive/SingularityNET-Archive/issues/87 https://github.com/SingularityNET-Archive/SingularityNET-Archive/issues/144 https://github.com/SingularityNET-Archive/SingularityNET-Archive/issues/145 and https://github.com/SingularityNET-Archive/SingularityNET-Archive/issues/146.
This Issue is for the work to analyse our tags and see if it's possible to create a controlled vocabulary for any elements of it. This is costed in Quarter 2, and the planned completion date is the end of June
See workplan here https://docs.google.com/document/d/14q0GxN0c-QraeSt1Z-bINScd5LJQr275HTjN6C9lyHY/edit?usp=sharing,

In progress - updates to be completed last week of June 2024

Decision - by Archive WG - Discord ID = Archive ID - add this guidance to front page of Archive GitBook

RE: "Discord ID = Archive ID - add this guidance to front page of Archive GitBook": I added
"Note that in meeting summaries, "Discord name= Archive name": that is, we record individual people's involvement in meetings using their Discord names as far as we can. So if you want to search or query the Archives about a particular person, it's best to use their Discord name."

Complete async in August 2024

Suggestion - We add review of new tags to Archive WG meetings
People will be able to add tags but won't be visible until approved.


Feature Request: Adding optional information to the info endpoint.

In our infrastructure we use custom elements of the info endpoint for among other things grafana links. Could you add a function for registering custom fields in the info endpoint?

Hi @mikand13, I'm glad you are asking, because I think what you are asking for is already supported by Pyctuator but isn't documented too good - Pyctuator already lets you to provide a JSON value that's included in the registration.
Please see the comment in https://github.com/SolarEdgeTech/pyctuator/blob/master/pyctuator/pyctuator.py#L76 .
An example can be found at https://github.com/SolarEdgeTech/pyctuator/blob/a1e8ade496c5eb8987f49d11da3bd4e23b830411/tests/fast_api_test_server.py#L30
Can you please try it out and let us know how did it go.
Thanks,
Michael

Ah, nice, will check!

@mikand13 I'm closing this issue for now.
Please re-open with additional info if you need something different.
Thanks

Hi, i didnt have a chance to test this until now. Been on vacation. As I understand it I would expect this to produce values in the /info endpoint?
    metadata=dict(
        serviceLinks=dict(
            metrics="url here"
        ),
        podLinks=dict(
            metrics="url here"
        )
    )

Should be relatively easy to expose it in AppInfo?
        AppInfo(app=AppDetails(name=app_name, description=app_description)),

Hi @mikand13,
While its possible to add an untyped parameter to Pyctuator that will be copied "as is" to the JSON returned from the /actuator/info - I prefer to follow our convention of declaring all the types.
Can you point me to the documentation of spring-actuator (or code) explaining what are the supported attribute so I can evaluate how bad it would be to explicitly support all of them.
Thanks,
Micahel

https://docs.spring.io/spring-boot/docs/current/reference/html/actuator.html#actuator.endpoints
2.10.2
Generally a direct manipulation of the json output.

@mikand13 - moving the discussion/request to a dedicated issue, #53

Ok, reopening the ticket - will post a suggestion soon.

Testing this I added the info at the root of the /pyctuator/info URI so in SBA it looks like this:

The JSON is:
{
  "app": {
    "description": "Demonstrate Spring Boot Admin Integration with Flask",
    "name": "Flask Pyctuator"
  },
  "podLinks": {
    "metrics": "http://xyz/pod/metrics"
  },
  "serviceLinks": {
    "metrics": "http://xyz/service/metrics"
  }
}

@mikand13  is this what you were looking for?

Looks perfect to me 👌

Please upgrade to v0.14.0


Deleting Cookies

I'm trying to delete all cookies before running my tests.
I didn't find how to delete them.
Somebody told me on StackOverflow that I should use session.deleteAllCookies() method. http://stackoverflow.com/questions/19380014/delete-cookies-in-webdriverjs?noredirect=1#comment28721420_19380014
I used:
ptor.driver.session.deleteAllCookies();
but this gives an error: Cannot call method 'deleteAllCookies' of undefined.

For those that arrive here from Google, the correct call is now
browser.manage().deleteAllCookies();

note that ptor is now browser

With protractor 4.0.5, correct call is
browser.driver.manage().deleteAllCookies();

beware that it only clears the cookies for the domain of the current page, so no point in doing that in a beforeEach.

With protractor 4.0.9, in chrome fails:
browser.driver.manage().deleteAllCookies();
Normally I have been deleting all the cookies before each test, but now it not working in chrome, and I still didn't find how to delete them.

browser.driver.manage().deleteAllCookies(); does not work in safari ?


ci: Only trigger release CI if explicitly set

This is a better tested version of what #28535 hoped to achieve
Fix #26830

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

actually - this could resolve #26830 ...

argh - just spotted error - will update ...

done


refactor: Misc int sign change fixes

This is allowed by the language. However, the integer sanitizer complains about it. Thus, fix it, so that the integer sanitizer can be used in the future to catch unintended sign changes.
Fixes #805.

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews
See the guideline for information on the review process.
A summary of reviews will appear here.

Concept ACK.


questions regarding carla closed-loop simulation instructions

I am trying to evaluate the pretrained model inside carla simulator(<IP_ADDRESS>) using the transfuser repository, do I need to place the "carla_agent.py" script inside transfuser folder and test it in the same fashion for testing for "submission_agent", or do I need to change other arguments?

Hey, have you resolve the issue?

I changed those: "export TEAM_AGENT(carla_agent.py path ) and TEAM_CONFIG(carla.ckpt path) " in file local_evaluation.sh in transfuse repository and it worked.

I fogot one thing, you also need to add a planner.py in team_code folder. I got the planner.py in TCP model.

I changed those: "export TEAM_AGENT(carla_agent.py path ) and TEAM_CONFIG(carla.ckpt path) " in file local_evaluation.sh in transfuse repository and it worked.

thanks for your reply！ I have tried and an error raised “leaderboard.autoagents.agent_wrapper_local.AgentError: shape '[196608, 3]' is invalid for input of size 967680". Is there anything I missed？

@betbetliu, thanks for the instructions. Can you please let know where one can find the planner.py file?


added type for program header flags

This PR adds typings for program header flags (segment permissions) as defined in https://refspecs.linuxfoundation.org/elf/elf.pdf

Hey @vincenthouyi , do you have any comments on this?

Hi @phip1611, sorry the code went through a overhaul earlier. Can you rebase to the latest version? Thanks!

@vincenthouyi done


joss review: installation issues

from @flekschas in https://github.com/openjournals/joss-reviews/issues/5651#issuecomment-1641072224

I followed https://mpl-interactions.readthedocs.io/en/stable/install.html#setup-for-jupyterlab-3 and tried to run the Basic Example from https://mpl-interactions.readthedocs.io/en/stable/index.html#basic-example with JupyterLab v4.0.2 on a M1 MacBook but can't get it to work.

Not sure what I might have done wrong or missing, but unfortunately, I didn't get mpl-interactions to work.

Addressing the installation instructions
These seem like issues with your ipympl installation. The installation [jupyter] addition to the installation instructions just makes a best effort to install compatible versions of ipympl and ipywidgets: https://github.com/mpl-extensions/mpl-interactions/blob/10b1a278a0ba952a830ea9e629a06531c0dc47d3/setup.cfg#L42-L44
Did you already have a version of ipywidgets/ipympl installed in your environment, if so it's possible that that led to installation issues which are an unfortunately common issue for ipympl.
For me the following steps led to a working installation for jupyterlab 4.0.3:
mamba create -n test-jlab4 -c conda-forge jupyterlab=4
mamba activate test-jlab4
pip install mpl-interactions[jupyter]

To troubleshoot the ipympl installation I would recommend first printing out the versions as done in the ipympl issue template:
python -c "import sys; print('\n',sys.version); import ipympl; print('ipympl version:', ipympl.__version__)" && jupyter --version && jupyter nbextension list && jupyter labextension list
which gave the following for my working installation

Installed versions
 3.11.4 | packaged by conda-forge | (main, Jun 10 2023, 18:08:17) [GCC 12.2.0]
ipympl version: 0.9.3
Selected Jupyter core packages...
IPython          : 8.14.0
ipykernel        : 6.24.0
ipywidgets       : 8.0.7
jupyter_client   : 8.3.0
jupyter_core     : 5.3.1
jupyter_server   : 2.7.0
jupyterlab       : 4.0.3
nbclient         : 0.8.0
nbconvert        : 7.7.2
nbformat         : 5.9.1
notebook         : not installed
qtconsole        : not installed
traitlets        : 5.9.0
JupyterLab v4.0.3
/home/ian/mambaforge/envs/test-jlab4/share/jupyter/labextensions
        jupyter-matplotlib v0.11.3 enabled OK
        jupyterlab_pygments v0.2.2 enabled  X (python, jupyterlab_pygments)
        @jupyter-widgets/jupyterlab-manager v5.0.8 enabled OK (python, jupyterlab_widgets)

/home/ian/.local/share/jupyter/labextensions
        nbdime-jupyterlab v2.1.1 enabled  X

   The following extensions are outdated:
        jupyterlab_pygments
        nbdime-jupyterlab

   Consider checking if an update is available for these packages.

Using mpl-interactions outside the notebook
You can also use mpl-interactions directly from a python script. Taking that example and running it without the %matplotlib ipympl magic from a python file then one of the other interactive matplotlib backends (e.g. the qt backend) will be chosen by default by matplotlib and two windows should pop up, allowing use of the library without ipywidgets:

Hopefully this will allow testing of the library independent of installation issues with ipympl

Create a fresh environment from scratch works! 🎉 Thanks for the detailed description/response. Will update my review accordingly

Feel free to close this issue :)