Feature Request - Allow deployment to production environment during pull_request

Is your feature request related to a problem? Please describe.
I am currently facing a problem adjusting my workflow using the GitHub Actions SWA deploy component. In my company we have 2 subscriptions, one for testing and another for production. Our current workflow always works by deploying the components to the testing subscription during the pull_request event and deploys to production in another pull_request event (using labels), followed by an automated PR merge (so not on the push event). This makes it impossible to deploy it to the production environment on the testing subscription. It is also a problem during the production deployment on prod sub, since only on the push event the action is expected to update it.
Describe the solution you'd like
I would like to have an optional parameter where I can specify I don't want the default behavior and treat the push and pull_request events in exactly the same way. This way I can put those interactions exactly where I want them on my workflow.
Describe alternatives you've considered
I tried using the production subscription with the staging feature, but this creates a lot of dependencies with other components which do not have this staging feature, making everything too complex to setup without specific changes made to the software just for making it work.
I could also change my workflow to deploy to the production subscription during the push event, but this creates an issue where if something goes wrong on the deployment, the code is already merged to the main branch. This creates another set of problems for us (we prefer the philosophy of deploying first and merging only after it is successful, avoiding these conflicts).

Is this something that is unique to SWA or is it more an issue with your pipeline?

Hello, @diberry. Thanks for the quick comment. This is unique to SWA, as far as I know. The rest of my environment uses AKS and I can freely create my workflow as specified (2 independent subscriptions using pull_request events) without any issues.
The way the current SWA actions component is structured leaves my without any options to make it work on my current workflows, and we really do not want to redesign them entirely because of SWA.

@rtrindvg Can you please share a sample workflow and point out where you're having problems?

Not sure I can make this clear with a sample workflow but I can try:
name: Sample workflow
on:
  pull_request:
    types: [opened, synchronize, reopened, labeled]
    branches:
      - 'main'
    paths:
      - 'ui/my-frontend/**'
      - 'my-backend/**'

jobs:
  ###############
  # WORKFLOW 01 #
  ###############
  start-validations:
    if: |
      github.event.action != 'labeled'
      && github.event.pull_request.draft == false
  # Removed for brevity, linting, unittest and build unrelated to the issue

  ###############
  # WORKFLOW 02 #
  ###############
  # Removed elements from this section related to the label management and the backend deployment

  web-app-deploy-dev:
    if: |
      github.event.action == 'labeled'
      && github.event.pull_request.draft == false
      && github.event.label.name == '✨👍a02-approved-for-dev-deploy'
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
        with:
          submodules: true

      - uses: Azure/static-web-apps-deploy@v1
        with:
          azure_static_web_apps_api_token: ${{ secrets.azure_static_web_apps_api_token }}
          repo_token: ${{ secrets.gh_token }}
          action: 'upload'
          app_location: 'ui/my-frontend'
          api_location: ''
          output_location: 'out'

  ###############
  # WORKFLOW 03 #
  ###############
  web-app-deploy-prod:
    if: |
      github.event.action == 'labeled'
      && github.event.pull_request.draft == false
      && github.event.label.name =='🔥👍b02-approved-for-prod-deploy'
  # Almost the same as the workflow 02, except for an automerge at the end.

As you can see, my current workflow is broken in 3 sequence of actions:

On pull_request open, sync and reopen events, I start the workflow, validating the PR without using any environment (staging or prod).
On pull_request label events, if there is a label approving the deploy to development subscription, we want to publish it there. This is my problem number one. Since I am on a pull_request event, the action creates my deployment in a staging environment inside the app. This works, but it's not ideal, since we want to use the "production" environment of the test subscription.
On the pull_request label event with the production approval label, we have the same issue but now on production. We REALLY do not want to use the staging feature here. We are ready to deploy it. If I change this to a push event, this leads me to an entire rabbit hole of not having an ideal way to deal with failures on the workflow and the commit is already merged to main. (eg. failure on the Cypress end-2-end testing after deployment).

Having an option on the action to allow me to deploy to the production environment on the pull_request event would work perfectly with my entire setup without any major changes.
Another path would be to have another way to upload an SWA, without GitHub integration. As far as I could research, there is no way to do this as of now. Also tried to check for the action to evaluate how hard it would be to change it, but it seems to be closed source.
Hope it is clearer now. Feel free to ask more questions is this is still unclear. I am definitely not an expert on both tools, so if I am missing a critical piece of the puzzle, any help is appreciated.

@rtrindvg It's possible to achieve the behavior you want by modifying your workflow file to include this to the call to the Azure/static-web-apps-deploy@v1 task:
env:
  DEPLOYMENT_PROVIDER: "Custom"
  REPOSITORY_URL: ${{github.event.repository.html_url}}
  BRANCH: ${{github.event.pull_request.head.ref}}
uses: Azure/static-web-apps-deploy@v1
  with:
    azure_static_web_apps_api_token: ${{ secrets.azure_static_web_apps_api_token }}
    repo_token: ${{ secrets.gh_token }}
    # Rest omitted for brevity

By setting the DEPLOYMENT_PROVIDER environment variable to something other than GitHub, you are telling the action that you wish to handle setting all the deployment configuration values yourself, and you don't want it to automatically deploy to a preview environment even though the deployment was triggered from a pull request. Thus, you have to manually specify the repo URL and the branch. By default, with just a branch and a repo URL, the Azure/static-web-apps-deploy@v1 action will deploy to the production environment of the static web app matching the Api token you specified.
This should enable you to deploy to the production environment even during a pull request. Please let me know if it works for you, and thank you for using Static Web Apps. 😄

I'm getting some sort of the same issue.
Can we pass argument type 'env production' directly deploy to my production environment for my development static web app for every PR opened.
I want to use the production environment one as backend API is only attached to that one.
  - name: Deploy
      uses: Azure/static-web-apps-deploy@v1
      with:
        azure_static_web_apps_api_token: ${{ env.swa_key }}
        repo_token: ${{ secrets.GITHUB_TOKEN }}
        action: "upload"
        app_location: "/"
        output_location: "dist"
        arguments: "--env production"

I never went back to say the suggestion from mishapos worked perfectly. I suggest Areej-Ashraf to open a new issue if this is still a problem for you. Closing...


Feature to run outputted executable

CLion really dropped the ball on makefile support. It would be great if additionally to running makefiles, this plugin could help bridge the gap to run the resulting binary executable and debugging it.

In their defense, a) they are working on it, and b) Makefiles are really a horrible format for project configuration, because they are frequently cross-bred with arbitrary bash scripts.
I believe you can work around it by adding external tool to run configuration template.

According to CLion roadmap they are working on native Makefiles support, see https://blog.jetbrains.com/clion/2019/12/clion-2020-1-roadmap/
It is impossible to correctly detect what "outputted executable" is. I'd second @singalen's suggestion and suggest to add a run configuration manually.


Feature request: Build and return SourceInfos when incremental compilation fails

When compilation fails, Zinc throws a xsbti.CompileFailed which contains:

arguments: Array[String]
problems: Array[Problem]

Based on the previous analysis and the CompileFailed instance I am trying to build an accurate description of the entire codebase but I am lacking information.
I don't know which of the old problems are still valid. Typically, a warning in a file is not reported again if the file is not recompiled, but I don't know if the file has been recompiled or not.
Ideally, the CompileFailed exception could contain an instance of SourceInfos which would give us the list of problems, the old ones that are still valid and the new ones.
At least, as an alternative, I would like to know which files have been recompiled.

@Friendseeker Since you closed #1306, should we assume this issue cannot be fixed?

@adpi2 Might want to double check with the Scala 2 compiler folks but I do suspect this problem cannot be fixed. The issue is that the compiler early stops and does not necessarily return a complete list of all problems in the recompiled files.

@adpi2 Glad to hear your assessment. I shall work on getting #1306 merged. This is also a great opportunity to get #1309 merged as both require AnalysisCallback3. As long as we can get #1306 and #1309 merged in quick succession we can avoid the need to introduce AnalysisCallback4.

When we bump the AnalysisCallback, we probably want to send PRs to Scala 2.13 and Scala 3 so the Scala teams don't have to figure out what to change.

Just realized there's still work to do. Need to test the below cases

For mixed scala / java compilation or during compileAllJava workflow

Successful compilation should save java warnings in Analysis
Unsuccessful compilation (during java compile) should also throw an exception containing SourceInfo

@adpi2
c.c. https://github.com/sbt/zinc/issues/932#issuecomment-2395329422
Just want to confirm with you if these are indeed cases that should be covered.

@Friendseeker
Yes indeed, I think we need to cover them both.
About saving the Java warnings in the Analysis, is it not already covered?

@Friendseeker
Yes indeed, I think we need to cover them both.
About saving the Java warnings in the Analysis, is it not already covered?

Scala compilation problems are recorded in Analysis via calling AnalysisCallback.problem2. I was inspecting where the method was called and didn't see the Java compiler calling it.
Maybe Java warnings are already tracked in a way that is different than how Scala warnings are tracked. I will do investigation.

When we bump the AnalysisCallback, we probably want to send PRs to Scala 2.13 and Scala 3 so the Scala teams don't have to figure out what to change.

Hi there! When creating a new AnalysisCallback interface version in the future, please ping me, either here or on Discord (same username). I'm the maintainer of the Zinc integration in the Scala Plugin for IntelliJ IDEA. I will take care of the rest, thanks!


doubleclick on a file with blanks in its name

Happened both with 2.8.035 and 2.8.038
I have defined my Win 10 to open XML Notepad with a doubleclick on a XML file. Usually no problem, but sometimes Win is asking which program I want to use with XML (or with PDF or TXT or ...)
Now I doubleclick on file "d:\a b c.xml", and I get

I press "OK" and get

I press "OK" and

my text editor opens the (non exisiting file "D:\a")
and I get:

and so on ...
It is OK when ..

I use "right mouse - open with" or
doubleclick on a file(path) without blanks or
use "File - open "

Something wrong with ...?

I cannot reproduce this on a clean machine, but you might have some old broken registry entries for previous versions of XML notepad, depending on how you have installed it in the past.  These steps might help:

run the regedit program (comes with windows)
goto "Computer\HKEY_CLASSES_ROOT.xml\OpenWithProgids" and remove any "XmlNotepad.xmlfile" entry there.
goto "Computer\HKEY_CLASSES_ROOT\XmlNotepad.xmlfile" and remove it if it exists.
goto "Computer\HKEY_CURRENT_USER\SOFTWARE\Classes.xml\OpenWithProgids" and remove any "XmlNotepad.xmlfile" entry there.
goto "Computer\HKEY_CURRENT_USER\SOFTWARE\Classes\XmlNotepad.xmlfile" and remove it if it exists.
goto "Computer\HKEY_CURRENT_USER\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\FileExts.xml" and delete UserChoice if it exists.

Now re-start your XML Notepad 2.8.038.  It will automatically re-register the above information correctly.  Now repeat making XML notepad your default application for opening XML files  (and you should not need to use "Look for another app on this PC" for this, the installed XML notepad should show up in this list).
Now try double click test again.

Oh and one more thing, problems with blanks in the name is usually caused by missing double quotes around the %1 argument in the registry entry for XmlNotepad.xmlfile.  But XML notepad has registered this with "%1" for a while now, and when windows creates this entry for the user because the user used "Look for another app on this PC" then it too also puts double quotes around the "%1".  But if you find a registry entry for XmlNotepad.xmlfile that does has %1 instead of "%1", then add the quotes and you should be good.  No need to reboot or anything, the windows explorer always checks the latest registry values.

Thanks Chris
I used "FileTypesMan" from Nirsoft to check and modify the extensions. I had entries from August 2020 without quotes, fixed it and the handling of spaces is OK now.
Nevertheless it was asking again and again "Which software should be opened?". Then I made the regedit-jobs, and it looks OK now.

Great, and I double checked that the current version of XML notepad does put the double quotes around the registry entry as you can see here.


Unable to detect / retile GTK applications

As the title says. I don't necessarily think this is a problem with kwm, as the application I'm attempting to use (CoqIDE) doesn't seem to be detected by Accessibility Inspector either - but I haven't been able to debug this on my own, so I figured I'd come here for help. Is there an obvious gotcha here that you happen to be aware of?
It is totally okay for you to declare this one Somebody Else's Problem.

Kwm fully relies on the accessibility API and applications that does not provide support for this will not be detected. There are probably ways around this, but I have not really looked into it. The same applies to windows running through XQuartz.

Fair. Thanks for the swift answer!


binarysearch.py

Program to perform binary search using the iterative method in python.

Can i take this repository?


[Feature] Implement a "blocked" servers list

📃 Description
In some cases "most" servers available locally are ok but sometimes they're not preferred and shouldn't be used when running a speedtest.

#1438
https://github.com/alexjustesen/speedtest-tracker/discussions/17

This issue will track the research needed to implement a blocked server list as the cli doesn't support this use-case.
🤔 Research
Since the cli doesn't support --exclude anymore we'll need to get a list of local servers first and intentionally choose one while excluding and "blocked" servers.
Options

A list of local servers can be found by running speedtest --servers --format=json which returns a list of servers using Ookla's opinion of which is "best for you".
A list of servers can also be found by hitting the api endpoint https://www.speedtest.net/api/js/servers. This looks close to the "best for you" cli list but does have some variance with my testing.

In my option 1 is likely the best source as it's "probably" the method the cli uses to choose a server anyways.
🚶♂ Steps
If a blocked server list exists take the following steps:

Get a list of servers.
Remove the blocked servers from the list.
Choose the "best" server by using the first one in the list.
Run the speedtest.

This is great news, Alex!  The steps look spot-on, and I like Option 1 for generating a list of servers to choose from for the reason you stated.
This method is essentially the same as that used by another script I use from time to time and it has been very reliable.  It allows the closest servers list to change dynamically as servers come and go over time, while still being able to filter out the slow ones that are identified.
Also, --selection-details (show server selection details) seems to produce the same list of servers as --servers (aka -L), but includes what I believe is the idle latency and in a slightly different format.  I only mention this because if you specify --selection-details, it picks the first server in the list to run the test, so it does appear that the list is an ordered list, although it doesn't appear that the selection it makes is based strictly on latency.
speedtest --servers
Closest servers:

    ID  Name                           Location             Country
==============================================================================
  8862  CenturyLink                    Denver, CO           United States
 15597  BAM Broadband                  Littleton, CO        United States
 16968  Spectrum                       Centennial, CO       United States
 17687  Hitron Technologies Americas   Centennial, CO       United States
 47683  NextLight                      Denver, CO           United States
 16797  Nitel                          Denver, CO           United States
 24079  ALLO - Denver                  Denver, CO           United States
 51010  Highline                       Denver, CO           United States
 23628  Whitesky Communications LLC    Denver, CO           United States
 10051  Comcast                        Denver, CO           United States
  9912  fdcservers.net                 Denver, CO           United States

speedtest --selection-details

   Speedtest by Ookla

Selecting server:
       8862:   1.93 ms; CenturyLink - Denver, CO
      15597:   3.35 ms; BAM Broadband - Littleton, CO
      16968:  41.97 ms; Spectrum - Centennial, CO
      17687:   2.93 ms; Hitron Technologies Americas - Centennial, CO
      47683:   2.61 ms; NextLight - Denver, CO
      16797:   2.56 ms; Nitel - Denver, CO
      24079:   2.94 ms; ALLO - Denver - Denver, CO
      51010:   2.65 ms; Highline - Denver, CO
      23628:   2.99 ms; Whitesky Communications LLC - Denver, CO
      10051:   3.03 ms; Comcast - Denver, CO
       9912:   2.75 ms; fdcservers.net - Denver, CO
      Server: CenturyLink - Denver, CO (id: 8862)
         ISP: CenturyLink

When dumping to json looks like the latency is missing but as long as the order is maintained I suppose that doesn't matter.
{
  "id": 56485,
  "host": "secaucus.nj.speedtest.frontier.com",
  "port": 8080,
  "name": "Frontier",
  "location": "Secaucus, NJ",
  "country": "United States"
},

The latency is outside of the "server" structure:
{"latency":1.1259999999999999,
"server":{
"id":8862,
"host":"denver.speedtest.centurylink.net",
"port":8080,
"name":"CenturyLink",
"location":"Denver, CO",
"country":"United States"
}
}
BUT...I think you can use the simpler speedtest -L to generate the list as you originally suggested; it appears to be the same list of servers in the same order according to my testing.  The only thing I was pointing out is that --selection-details generates the list and runs a test using the first entry, which would indicate that the list is in order of preference, and since that order matches -L, the -L list is likely also in order of preference.  Interestingly, the list is not in order of increasing idle latency as illustrated in my earlier post which indicates that there are likely other factors that go into the ordering process.

Looking forward to this, thanks so much! Also, if there's any chance of being able to configure this via the UI over time, that would feel like a big win as well


[Feature request]: introduce position variable for sbb-toast

Preflight Checklist

[X] I have read the Contributing Guidelines for this project.
[X] I agree to follow the Code of Conduct that this project adheres to.
[X] I have searched the issue tracker for an issue that matches the one I want to file, without success.

Request type
Request for enhancement of a component
It affects the following packages
Components
Functionality
In order to position the toast from the outside we need a css variable to manipulate the position.
It would be enough when we can change the postion:fixed to position: unset
Link to design proposal file
https://www.figma.com/file/0NEb22jBYE2HEmjACXQ9qk/04-Passenger?type=design&node-id=5580-69287&mode=design&t=X6ESamNDnOIUTfYU-0

Closed by #2229


Dev 3067 fix altair x domain

Removed the use of the expressionInterpreter when rendering Vega Lite charts. Using this renderer exposes a bug where a specified x-domain results in charts not rendering correctly. See these threads for more details: https://discuss.streamlit.io/t/time-axis-with-custom-scale/33524 https://github.com/vega/vega/issues/3632
Pinned wheel to 0.40.0 to fix a build error

LGTM. Why is the branch we're using develop?

That's their default branch


Set up continuous benchmarking

It would be awesome to always know:

how the system's performance is on the current dev branch on sample workloads
if we have performance regressions with new commits

Yes!!! Once we have our test machines installed at the office we can do this like snabb-bot does (an external continuation integration tool).

See https://github.com/SnabbCo/snabbswitch/issues/688

Would you be interested in running the second SnabbBot instance?

@eugeneia yes certainly!  we have two machines that are pretty much the same as interlaken and which are mostly idle.  Do you have a NixOS config that automatically runs the SnabbBot?

@wingo I have hacked together a NixOS module that runs SnabbBot as a service (configurable through Nix options): https://gist.github.com/eugeneia/53fe2615c1e90bc778a1
Is that what you were looking for? This is my first Nix expression, so take it with a grain of salt.

Closing ticket as continuous benchmarking of the lwAFTR is currently deployed at:
https://hydra.snabb.co/project/igalia
A detailed description of continuous benchmarking of the lwAFTR can be checked at https://github.com/Igalia/snabb/blob/lwaftr/src/program/lwaftr/doc/continuous-integration.md


Kingfisher causing crash when support activity gets opened

Your SDK is using Kingfisher as pods and it's causing an exception when ever I try to open the support view controller.
The exception is as following:
Thread 8: EXC_BREAKPOINT (code=EXC_ARM_BREAKPOINT, subcode=0xdefe)
    var timeInterval: TimeInterval {
        switch self {
        case .never: return .infinity
        case .seconds(let seconds): return seconds
        case .days(let days): return TimeInterval(TimeConstants.secondsInOneDay * days)
        case .date(let ref): return ref.timeIntervalSinceNow
        case .expired: return -(.infinity)
        }
    }

The exception occurs at the case.days line

@pmusolino @lucamicheli @giannign1 @harrycamelback  can you look into this please

Hi there.
Can you tell me on what version of Xcode do you have this problem?
Are you using the latest version of the SDK?
The crash happens only on a particular version of iOS?

@harrycamelback Hi Harry,
I'm on Xcode 11, I've tested on iOS 10 and 13, and it happens on both. And yes I'm on the latest version of the SDK.

This is really strange, I don't get any crash on Xcode 11.
How do you configured the SDK? How to do you present it?

I think I figured out why the crash happens. I'm using kingfisher as a pod file in my app as well. So there are two binaries now which are causing the crash.
Why exactly is kingfisher being used in customerly? Can we disable it or force it to use the pod present in my app?

Since you are using Kingfisher in your app, you only need to delete the pod on your side, since the SDK import it for all the targets.

@harrycamelback What version is Customerly using for kingfisher?

As you can see from our podspec, we are using v.5.7.0. We will update it into the next release.

@harrycamelback Upon further testing I have found out that this issue still occurs on iOS 10 but is not happening on iOS 13.
Here's a screenshot of what the exception looks like:

@lucamicheli I see that you're the founder of Customerly. We went with your SDK because we believed it would provide a stable solution in our apps however I have found that there are a lot of small bugs in your SDKs. I coordinated with the android developer last month and he was helpful however in our beta testing we have found a couple of other bugs as well. I have opened an issue on the android sdk for more than 2 weeks now, no one replies there.
And there's also an issue on the iOS side as you can see in the issue I posted above.
We're planning on shifting to the paid plan but I am sorry to say, the customer support hasn't been great. If this is how things are going to be then unfortunately we would need to shift to other solutions.
Can you please look into this and ask the devs to please at least reply.
Thank You


[GHSA-wc69-rhjr-hc9g] Moment.js vulnerable to Inefficient Regular Expression Complexity

Updates

Affected products

Comments
Version upgraded to Improve: "Moment.js vulnerable to Inefficient Regular Expression Complexity"

Hi there @ichernev! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.
This change will be reviewed by our highly-trained Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory

Hi,
Evidence & solution is here -
https://security.snyk.io/vuln/SNYK-DOTNET-MOMENTJS-2944237 (Upgrade
Moment.js to version 2.29.4 or higher.)
On Mon, Jul 31, 2023 at 10:54 PM Jon @.***> wrote:

Hey @Subrata19777 https://github.com/Subrata19777, can you elaborate on
the changes your trying to make here?
—
Reply to this email directly, view it on GitHub
https://github.com/github/advisory-database/pull/2559#issuecomment-1658834675,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYZRS552B5CO3DTQIUJVN4LXS7S5FANCNFSM6AAAAAA25Z6H6Y
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Thanks and Regards,
Subrata Dutta
LearningMate
@.*** @.***>
www.learningmate.com Kolkata, West Bengal

Please note that the advisory already refers to version 2.29.4
https://github.com/advisories/GHSA-wc69-rhjr-hc9g

Since we updated it to 2.29.4 then dependabort alert should be resolved ?
On Tue, Aug 1, 2023 at 9:39 PM Jon @.***> wrote:

Please note that the advisory already refers to version 2.29.4
GHSA-wc69-rhjr-hc9g https://github.com/advisories/GHSA-wc69-rhjr-hc9g
—
Reply to this email directly, view it on GitHub
https://github.com/github/advisory-database/pull/2559#issuecomment-1660639312,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYZRS54RMTR73KKLM5PC4OLXTES25ANCNFSM6AAAAAA25Z6H6Y
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Thanks and Regards,
Subrata Dutta
LearningMate
@.*** @.***>
www.learningmate.com Kolkata, West Bengal

Since we updated it to 2.29.4 then dependabort alert should be resolved ?

Yes it should. This may be a bug in dependabot. Let me share this with the relevant team 👍

Okay, thanks.
On Tue, Aug 1, 2023 at 10:13 PM Jon @.***> wrote:

Since we updated it to 2.29.4 then dependabort alert should be resolved ?
Yes it should. This may be a bug in dependabot. Let me share this with the
relevant team 👍
—
Reply to this email directly, view it on GitHub
https://github.com/github/advisory-database/pull/2559#issuecomment-1660715507,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYZRS55TVQKAYHGPBA7TT3TXTEW2BANCNFSM6AAAAAA25Z6H6Y
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Thanks and Regards,
Subrata Dutta
LearningMate
@.*** @.***>
www.learningmate.com Kolkata, West Bengal

👋 This pull request has been marked as stale because it has been open with no activity.  If you do nothing this pull request will be closed eventually by the stale bot. Please see CONTRIBUTING.md for more policy details.


Merge master

Description
As title
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

How Has This Been Tested?
No changes
Checklist:

[ ] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works

Current dependencies on/for this PR:

develop

PR #64   👈

This stack of pull requests is managed by Graphite.


Improvement / Modification of the model

Hi there,
I am looking to improve on the model's structure maybe adding 1 or more layers or something else. How would you suggest I can go about with this?
Also, the link to your paper returns a 403 Forbidden error. Please advise.
Hope to hear back.

The paper link seems to be working well on my side. Please try again or use the cn.arxiv.org site.
On modification, you can design your own architecture and evaluate it using this framework. For architecture design, I suggest you read previous papers (AlexNet, GoogleNet, ResNet, etc) or textbook on this topic.

Alright, thanks!


Unable to work with SCSS files

vscode 1.5.2
vscode-csscomb 2.0.0
Mac OS X 10.11.6
Here's a GIF of it not working in a .scss file and it working in a .css file (note the &._block {} rules that aren't changing):

What other information can I provide? I'm currently running node 6.5.0, if that makes a difference (not sure if it does).

Hello, @arlodesign,
You see something in the console (Help -> Toggle Developer Tools)?

(I didn't know I could turn that on. NEAT.) Looks like it might be an issue in CSSComb itself, actually.

Unfortunately, yes, this is the problem inside CSScomb.
You can provide minimal code example that causes an error?

I found the culprit.
It wasn't working on any of the sass files I tested it on—we must use that a lot. 😊

Well, it's bug in csscomb-4.0.0-alpha, but csscomb-3.1.8 works fine. I can provide the option to select the version of CSScomb (useOldCore: Boolean). But the old version does not support some options.
I think you need to create an issue in the main repository (https://github.com/csscomb/csscomb.js).
Let me know if you are satisfied with this offer or you are already using a different extension.

+1

@bgiraffe, @arlodesign, @danieloprado,
Please, try useLegacyCore option in vscode-csscomb 2.1.0.
===
If you use this extension and satisfied with his work, then please leave a review in the marketplace.

Thank you, it work like a charm, great work!

Awesome. :+1:

It's an open issue in gonzales-pe: https://github.com/tonyganch/gonzales-pe/issues/130


Tag link to GitHub

Link to current member list in GitHub repo

I'm not sure what I did to generate these extra commits, but the result is the single change described.


Does this run on a Mac? Can I call it from within my Rust program?

Description
Thanks for this!
Look forward to getting it working.
I compiled in RustRover & it runs fine, but can't instantiate Brave or Chrome.
Here's a grab from terminal; line 1 gets the error on line 2, line 3 opens Brave successfully so I know the path is correct.
brad@Hutchins debug % ./hxn -b "/Applications/Brave Browser.app" --url https://didi.co
error: Error instantiating browser /Applications/Brave Browser.app
brad@Hutchins debug % /usr/bin/open -a "/Applications/Brave Browser.app" https://didi.co
brad@Hutchins debug %

Am I doing something wrong--or maybe it doesn't run on Macs?
And the end goal: how do I call it from within a Rust program?
(I assume I could just cut & paste the contents of main() in main.rs--but is there an API?)
Thanks!
Brad
Related Documentation or Links
No response

You should pass the binary path like this below.

And the end goal: how do I call it from within a Rust program?
I'm afraid, this is not possible since haylxon is not a (library) rather an application binary.

Thank you!


MSFT_SPDistributedCache Get-TargetResource not returning the status of remote servers

Details of the scenario you try and problem that is occurring:
When calling the Get-TargetResource, it will return the null block if the DC is not enabled on the server on which you are running the script from, which is ok. But the Get-TargetResource function should be able to extract the current state of the DC for a remote server (not the one running the script). Currently, when running the ReverseDSC and calling into the Get-TargetResource function, if the DC is not enabled on the current server, it will never retrieve information about the other servers. We either need to modify the query filter so that it doesn't only filter the Hosts based on the current server name or we need to add an additional parameter (say "ComputerName") that would allow the method to detect the DC service status on that remote SPServer.
The DSC configuration that is using the resource:
N/A
Version of the Operating System and PowerShell the DSC Target Node is running:
Win 2012 R2 / WMF 4
Version of the DSC module you're using:
<IP_ADDRESS>

@NikCharlebois I disagree. All of the logic in all of our resources has always only ever been focussed on running on the server that the code is executing on, and while this would be convenient for your reverse scenario I don't think it's something I want to break in our design approach to fit that one in. @ykuijs what do you think?

I agree with @BrianFarnhill, this has been the focus for all resources.

Thanks @ykuijs - Sorry @NikCharlebois but I'm gonna close this one off. Ping me an email though and we can have a chat about other alternatives that might be able to help you with what you are doing mate.


Add ESP32 + PlatformIO Tutorial and Example

What's new

Added tutorial page for using our stack on ESP32 with PlatformIO.
Added ESP32 + PIO example files.

I would like some feedback on this new tutorial before merging it, ideally, so you can find a draft of it here
Any and all comments would be welcome.
Closes #263

Built "esp32_platformio_object_pool" example, as in the tutorial. Deployed on some ESP32 module. I can see some CAN frames been sent at boot. If I check serial port of ESP32 module it says every 5 seconds:
"E (391530) task_wdt: Task watchdog got triggered. The following tasks/users did not reset the watchdog in time:"
Tried also connected to some tractor's virtual terminal. It do not detect it.

Built "esp32_platformio_object_pool" example, as in the tutorial. Deployed on some ESP32 module. I can see some CAN frames been sent at boot. If I check serial port of ESP32 module it says every 5 seconds:
"E (391530) task_wdt: Task watchdog got triggered. The following tasks/users did not reset the watchdog in time:"
Tried also connected to some tractor's virtual terminal. It do not detect it.

Thanks for this feedback - I will see what I can do. I can sometimes repeat this same symptom, and have seen some successes with replacing some calls to std::this_thread::sleep_for with calls directly to FreeRTOS on ESP32 with vTaskDelay for example. We might have some success #defineing around these when ESP_PLATFORM is defined... or maybe we can use CMake and some clever abstraction to optionally compile in different kind of thread delays (this might be the cleanest solution...).

Hi @AndreaInverardi @ad3154, sorry for the delay, the fix for your issues should already be in the stack: https://github.com/Open-Agriculture/AgIsoStack-plus-plus/pull/91/commits/29fe04ff5d1c9e66880c9d2fc496c0972c0b5744
Basically the fefault FreeRTOS tick is 10ms, but the stack tries to update internally with 4ms by default. Hence the watchdog gets triggered as the thread is never allowed to switch.
There are 2 solutions:

Set the internal tick rate to 10ms in your init: isobus::CANHardwareInterface::set_number_of_can_channels(10)
Increase the tickrate of the your FreeRTOS environment to > 250Hz to match internal tick rate. For PlatformIO with ESP32 this can be done inside the menuconfig: pio run -t menuconfig. component config -> FreeRTOS -> Tick rate (hz), IIRC.

I prefer the latter to minimize platform specific issues, but both should work fine I think

Added updates to the ESP32 instructions to run menuconfig and adjust both the tick rate and some default stack sizes.
When testing on my end this seemed to resolve all instances of runtime crashes I was seeing.
Check out the new section Set up your ESP32’s OS and PThread options in the draft.


updated interfaces, abi, bytecode

Fixed load json issue, merged 2 functions into one.
Updated abi, bytecode functions for simplicity and make it working.
Current issue is fork (child_process) , and will work on it.

[ ] remove React
[ ] remove src
[ ] remove protobuf
[ ] optimize build
[ ] remove solc


Fixed link to allow-from-default-namespace.yml

The link to the allow-from-default-namespace.yml was broken. Fixed  the path.

@christianh814 @pabrahamsson do we need to merge this or close it?


InfluxDB3 Telemetry sender panic

Observed the below panic from the Perf test harness logs while testing PRO,
2024-10-28T01:51:43.585731Z  INFO influxdb3_pro_compactor: starting compaction loop
2024-10-28T01:51:43.586726Z ERROR panic_logging: Thread panic panic_type="unknown" panic_message="Cannot parse telemetry sender url: reqwest::Error { kind: Builder, source: RelativeUrlWithoutBase }" panic_file="/influxdb3/influxdb3_telemetry/src/sender.rs" panic_line=19 panic_column=14

I think generally the ERROR can be ignored, but it could maybe be made less alarming? Assigned to Praveen for when he is back from holiday to take a look since he is most familiar with the telemetry.

Thanks @hiltontj

I can take a look @MaduMitha-Ravi


Enhance ChannelEventRunnable state handle

What is the purpose of the change
Remove ChannelEventRunnable if and switch case.
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

Feel free to reopen if you think it's still needed, thanks.


Add Active Netflix OSS Docs

I would like to add some active Netflix Open Source Projects that have a documentation page that still accepts contributions.

Conductor
Eureka

My bad, I overlooked that :') Is it fine if I append these 2 to the already existing list?

Sure, you can

hi @saintmalik , can you please check my PR #69. Thanks for the opportunity, and really appreciate the work you all are doing here.

Looks like you've closed the PR, why?

Yes, sorry I closed it because it seems I had a broken link, sorry for this, but now I have made proper changes and made a PR again #70.
Sorry for the inconvenience and thank you!


Menu functionality appears to be undocumented for the user

How can I use the menu functionality? There's no --help info, and it's not in the manpage. Is it even complete?
Can I just do this:
cat menu.gb i-can-assure-you-i-ripped-this.gb not-pirated-and-totally-legit-game2.gbc > no-copyright-infringement-here-menu.gbc

and then flash no-copyright-infringement-here-menu.gbc? If so, to which bank?
If the project needs user-facing documentation, I'm happy to write it, as long as it doesn't involve interpreting code lol. I don't do C normally.

Hold on. I think I understand. I just have to pass multiple filenames as the ROM argument. OK.
Please leave this issue open. I'll use it as an attempt to document the features.

closed by 039d321, damn typo


Removing the embedding function of pens.

Why / Balance
Based on my previous PR, and a discussion on Discord about embedding objects into a wall, it simply does not make sense for a pen to be inserted into a METAL wall. I don't think the pen is designed for that at all. We make too many meme changes.
Changelog
No CL.

Syndicate explosive pen is now even more useless... sad day for all syndicate


ldapjs is not handling all errors

We've been getting occasional app crashes with vague outputs referring to events.js and sometimes tcp errors or TLSSocket errors. With such little context it could have been anything which makes an outside connection.
The only way we were able to get details was by adding a catch all for uncaughtException
// the ugly catch all
process.on('uncaughtException', (error) => {
	const { message, stack } = error;
	AppLogger.error({ error: { message, stack } });
});

With this we caught this stack trace
Error: unable to get local issuer certificate
    at TLSSocket.<anonymous> (_tls_wrap.js:1105:38)
    at emitNone (events.js:106:13)
    at TLSSocket.emit (events.js:208:7)
    at TLSSocket._finishInit (_tls_wrap.js:639:8)
    at TLSWrap.ssl.onhandshakedone (_tls_wrap.js:469:38)

Still not enough to pinpoint the culprit but it's a start. So with some trial and error running once piece of code at a time we narrowed it down to one line
const ldapClient = ldap.createClient({ url: ldapAddress });

createClient has no error handler and wrapping it in try catch doesn't do it either!
I suspect other functionality of ldapjs is also not handling for all errors. We have other unknown TCP errors being caught globally and after this discover I'd bet it's ldapjs.

createClient returns an event emitter, which emits error events. This event emitter is where you noramlly will see the TLS error you mentioned above, which commonly is caused by a self-signed certificate while using LDAPS.
Have you tried listening for the errors and handling them?
For example using your code:
const ldapClient = ldap.createClient({ url: ldapAddress });

// Console log errors
ldapClient.on('error', error => {
    console.error(error)
});

Also if you are not closing the client / connection you will likely see some network errors from timeouts. Hope that helps.

⚠ This issue has been locked due to age. If you have encountered a recent
problem that seems to be covered by this issue, please open a new issue.
Please include a minimal reproducible example
when opening a new issue.


weather hat doesn't work anymore

here below errors from terminal

Make sure you don't have anything using BCM 4, you might have 1wire enabled in /boot/config.txt.

Sorry, 1wire was enabled. Now it's work! Thank you very much!


rdl/ureg: Offset and name fixes for I3C RDL files

Automatically generated offsets were not being calculated correctly. If an offset for a register is missing, the RDL spec states that it should round to the next multiple of the register size (which is rounded up to the next power of 2). With this fix, the I3C register offsets match other RDL compiler's output.
This also fixes some TODOs in the code where registers were not being correctly enumerated if they were in sub-sub-blocks, and removes a related workaround (which was creating anonymous register types on-the-fly).
Finally, there are several register name collisions in the I3C Target Transaction Interface, which cause our RDL parser to panic. So, we add the ability to patch the RDL files when they are loaded so that we can rename the registers.
Since these problems only occur in I3C, this is only needed for Caliptra 2.0+.

Thanks!


Invalid prop: type check failed for prop "formConfiguration". Expected Object, got Null

Form is rendering but, getting below error in console.
app.js:193236 [Vue warn]: Invalid prop: type check failed for prop "formConfiguration". Expected Object, got Null

found in

---> <FormRenderer>
       <FormShareable> at resources/js/components/FormShareable.vue
         <App> at resources/js/App.vue

My code is:
<template>

            <FormRenderer
                :form-configuration="formData"
            />

</template>

Hello @abhimanusharma ,
I believe the warning message said it all: Expected Object, got Null. Could you please try to use the Vue-Devtool to see the exact data from your component?
And I do believe if you set the object like this: this.formData = ... => Not reactive. To re-set an object, best thing we should do is using $set of Vue, example here: https://vuejs.org/v2/guide/reactivity.html#For-Objects
        created() {
           axios.get('api/getform'+id).then(response => {
              this.$set(this, 'formData', JSON.parse(response.data.Form.form_data.data));
           }
        },

From vue-devtool this is the exact data:
{"formConfig":{"headline":"Form Xt","subHeadline":null,"isShowHeadline":true,"renderFormTag":false,"formActionURL":null,"formMethod":"POST"},"sections":{"section-6d781ff0-0017-4a36-82cb-e950a1241f0b":{"uniqueId":"section-6d781ff0-0017-4a36-82cb-e950a1241f0b","headline":"First sec","headlineAdditionalClass":null,"subHeadline":"Section starts","subHeadlineAdditionalClass":null,"isShowHeadline":true,"sortOrder":1,"type":"normal","rows":[],"controls":["control-e2a6636f-b4da-4e44-b65a-075ece47175c"]}},"rows":[],"controls":{"control-e2a6636f-b4da-4e44-b65a-075ece47175c":{"uniqueId":"control-e2a6636f-b4da-4e44-b65a-075ece47175c","type":"text","name":null,"label":"Address","subLabel":null,"isShowLabel":true,"placeholderText":null,"containerClass":"col-md-6 md-layout-item md-size-50","additionalContainerClass":null,"additionalFieldClass":null,"additionalLabelClass":null,"defaultValue":null,"validations":[],"rows":3}}}

For both this.$set(this, 'formData', JSON.parse(response.data.Form.form_data.data)); and this.formData = JSON.parse(response.data.Form.form_data.data);
Error remains the same.

Thanks for the info, let me test it to see what's the problem

This is my test result (used your form data above). No error was shown.
I do believe the retrieving data of your process is behind the warning error. Please kindly check it again.

It's been 3 days without any comments. I would like to close this issue. If you have any further detail or issue related to this, feel free to reopen it. Thanks


Fix footer padding

The footer occasionally encroaches on the table and/or Tagboard. Add some padding above the footer to make sure this doesn't happen.

Fixed as of b6587b0278e65784fa69c36d98fc049dc6973008


Add desktopitems for some classic games

Motivation for this change
I'm having a difficult time to convince some of my friends that Linux/NixOS is a good OS for gaming, because these classic games cannot be conveniently started from the KDE/GNOME/XFCE and any other XDG compliant desktop :)
I have already locally created desktop items for them, but maybe it wouldn't hurt to share/upstream them.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 132826 at 038d054d run on x86_64-linux 1

3 packages built successfully:

dhewm3
gzdoom
quakespasm

5 suggestions:

warning: license-missing
Package is missing a license.
Near pkgs/games/quakespasm/default.nix:38:3:
   |
38 |   meta = with lib; {
   |   ^

warning: unclear-gpl
gpl3 is a deprecated license, please check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/games/gzdoom/default.nix:88:7:
   |
88 |       license = licenses.gpl3;
   |       ^

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall.
Near pkgs/games/gzdoom/default.nix:67:5:
   |
67 |     installPhase = ''
   |     ^

warning: patch-phase
patchPhase should not be overridden, use postPatch instead.
Near pkgs/games/dhewm3/default.nix:16:3:
   |
16 |   patchPhase = ''
   |   ^

warning: unclear-gpl
gpl3 is a deprecated license, please check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/games/dhewm3/default.nix:41:5:
   |
41 |     license = lib.licenses.gpl3;
   |     ^

Result of nixpkgs-review pr 132826 run on x86_64-linux 1

3 packages built:

dhewm3
gzdoom
quakespasm

If there are no further comments, I'll merge later today


What are the requirements for the endpoint response to make it work for .updateData?

So, i'm trying to implement simple thing - instead of relying on static JSON file call external service to return JSON object.
So, i have an endpoint that returns the following JSON:
{
    "connections": [
        {
            "class": "normal",
            "metrics": {
                "danger": 10,
                "normal": 3000
            },
            "source": "event-source",
            "target": "INTERNET"
        },
        {
            "class": "normal",
            "metrics": {
                "danger": 10,
                "normal": 3000
            },
            "source": "INTERNET",
            "target": "service-A"
        },
        {
            "class": "normal",
            "metrics": {
                "danger": 10,
                "normal": 3000
            },
            "source": "service-A",
            "target": "INTERNET"
        },
        {
            "class": "normal",
            "metrics": {
                "danger": 10,
                "normal": 3000
            },
            "source": "service-A",
            "target": "service-B"
        },
        {
            "class": "normal",
            "metrics": {
                "danger": 10,
                "normal": 3000
            },
            "source": "INTERNET",
            "target": "event-target"
        },
        {
            "class": "normal",
            "metrics": {
                "danger": 10,
                "normal": 3000
            },
            "source": "event-target",
            "target": "event-subscriber"
        },
        {
            "class": "normal",
            "metrics": {
                "danger": 10,
                "normal": 3000
            },
            "source": "service-B",
            "target": "event-target"
        }
    ],
    "name": "edge",
    "nodes": [
        {
            "class": "normal",
            "displayName": "INTERNET",
            "name": "INTERNET",
            "renderer": "focusedChild"
        },
        {
            "class": "normal",
            "displayName": "EventSource",
            "name": "event-source",
            "renderer": "focusedChild"
        },
        {
            "class": "normal",
            "connections": [
                {
                    "class": "normal",
                    "metrics": {
                        "danger": 10,
                        "normal": 3000
                    },
                    "source": "INTERNET",
                    "target": "service-B"
                }
            ],
            "displayName": "ServiceA",
            "name": "service-A",
            "nodes": [
                {
                    "class": "normal",
                    "displayName": "INTERNET",
                    "name": "INTERNET",
                    "renderer": "focusedChild"
                },
                {
                    "class": "normal",
                    "displayName": "ServiceB",
                    "name": "service-B",
                    "renderer": "focusedChild"
                }
            ],
            "renderer": "focusedChild"
        },
        {
            "class": "normal",
            "displayName": "Service-A",
            "name": "service-A",
            "renderer": "focusedChild"
        },
        {
            "class": "normal",
            "displayName": "EventTarget",
            "name": "event-target",
            "renderer": "focusedChild"
        },
        {
            "class": "normal",
            "displayName": "EventSubscriber",
            "name": "event-subscriber",
            "renderer": "focusedChild"
        }
    ],
    "renderer": "global"
}

cURL output:
* TCP_NODELAY set
* Connected to localhost (::1) port 8080 (#0)
> GET /vizceral-config HTTP/1.1
> Host: localhost:8080
> User-Agent: curl/7.54.0
> Accept: */*
>
< HTTP/1.1 200 OK
< Content-Length: 1729
< Content-Type: application/json; charset=utf-8
< Date: Sat, 14 Apr 2018 20:40:17 GMT
<

My code looks like this:
  beginSampleData () {
    this.traffic = { nodes: [], connections: [] };
    request.get(`https://<service-url>/vizceral-config`)
        .set('Accept', 'application/json')
        .end((err, res) => {
            if (res && res.status === 200) {
                this.traffic.clientUpdateTime = Date.now();
                this.updateData(res.body);
            }
        });
    }

  update () {
      request.get(`https://<service-url>/vizceral-config`)
          .set('Accept', 'application/json')
          .end((err, res) => {
              if (res && res.status === 200) {
                  this.traffic.clientUpdateTime = Date.now();
                  this.updateData(res.body);
              }
          });
    }

  componentDidMount () {
      this.checkInitialRoute();
      this.beginSampleData();

      // Listen for changes to the stores
      filterStore.addChangeListener(this.filtersChanged);
      this.timer = setInterval(this.update.bind(this), 100000);
  }

  componentWillUnmount () {
      filterStore.removeChangeListener(this.filtersChanged);
      clearInterval(this.timer);
  }

But i'm facing the problem, i can't get graph visualized, it stucks loading the graph for some reason:

I do see that vizceral app sends the request to the endpoint and it responds back with appropriate response (you can see that above). However, can't get graph visualized.
Looking forward to get help on this, thanks.

tried to do the same with fetch.get instead of request.get, but didn't work as well.

Tried a bit different approach to make the endpoint return a JSON file, nothing actually changed, UI still hangs.
Detailed response:
*   Trying ::1...
* TCP_NODELAY set
* Connected to localhost (::1) port 8080 (#0)
> GET /config.json HTTP/1.1
> Host: localhost:8080
> User-Agent: curl/7.54.0
> Accept: */*
>
< HTTP/1.1 200 OK
< Content-Disposition: attachment;filename=config.json
< Content-Length: 1704
< Content-Type: application/octet-stream
< Date: Sun, 15 Apr 2018 07:55:45 GMT
<

@denismakogon I'm doing a similar setup - chrome console logs is throwing the allow-origin error for me, so that might be what you're running into as well:
 No 'Access-Control-Allow-Origin' header is present on the requested resource.

@cglewis Try to paste the first function at the beginning of your service - after the app declaration. It could be the issue with the CORS
https://enable-cors.org/server_expressjs.html


Change gRPC comparison IPC link, and use consistent title casing

@JamesNK If ur busy and agree with the suggested changes, I can make the updates. Let me know.


Installers

@vswarnkar there are extra changes in your commit. are those intended?

@vswarnkar there are extra changes in your commit. are those intended?

They were pushed for reference to create another installer for different version

app icon is low res? anything we can do about this

@vswarnkar any reason for the ~3 mins of the app bouncing on application tray? maybe java download..but then a dialog box would have been presented right?

Won't be there in new installer: https://github.com/minima-global/Minima/pull/570/

FYI - I'm need to sort out just merging in the installer files. There is a bunch of stuff in here that shouldn't be merged


Support Django 2.0

This PR handles the changes that broke imports in 2.0:
https://docs.djangoproject.com/en/2.0/releases/2.0/#features-removed-in-2-0

So it looks like codecov is correctly combining reports to include the exception. However, the project currently only "tests" a single version of django / python at a time:
coverage run \
	--source="./letsencrypt" \
	--omit="\
	./letsencrypt/migrations/*,\
	./letsencrypt/admin.py,\
	./letsencrypt/apps.py,\
	./letsencrypt/tests.py,\
	./letsencrypt/urls.py,\
	" \
	example_project/manage.py test \
	--settings=example_project.settings_test \
	&& coverage report
Creating test database for alias 'default'...
System check identified no issues (0 silenced).
.......
----------------------------------------------------------------------
Ran 7 tests in 0.009s

OK
Destroying test database for alias 'default'...
Name                      Stmts   Miss  Cover
---------------------------------------------
letsencrypt/__init__.py       2      0   100%
letsencrypt/models.py        18      2    89%
letsencrypt/views.py          6      0   100%
---------------------------------------------
TOTAL                        26      2    92%

It might be time to investigate using tox with this project locally.

I made a seperate issue to investigate adding tox to the project in issue #60


Fix sandbox image pull retries

Description of changes:
Fixes the retry mechanism for sandbox image pulls.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

is this to prevent the error breaking the service unit so that if the image isnt an ECR registry then it can safely exit?

covered in #1649


GenMatcher, GenMetrics, and MPTSMetrics classes with parameterize-d tests

https://stackoverflow.com/questions/42014484/pytest-using-fixtures-as-arguments-in-parametrize

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

-11 of 46 (76.09%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+7.2%) to 21.121%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/matbench_genmetrics/core.py
35
36
97.22%

src/matbench_genmetrics/cdvae/metrics.py
0
10
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
7.2%

Covered Lines:
95

Relevant Lines:
397

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

35 of 46 (76.09%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+7.2%) to 21.121%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/matbench_genmetrics/core.py
35
36
97.22%

src/matbench_genmetrics/cdvae/metrics.py
0
10
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
7.2%

Covered Lines:
95

Relevant Lines:
397

💛  - Coveralls


Add a NODE_ENV configuration setting for eslint

Addresses #983

Hey @dbaeumer, is there anything I can do to help expedite getting this PR reviewed / merged? 🙂

@dbaeumer Could you review my changes when you get a chance?
I'm really eager to get these changes merged & published, as the only way I can use VSCode at work right now is via the [Extension Development Host] VSCode window spawned by the "Launch Client" launch configuration of this plugin. It works, but it feels silly! 😅

@dbaeumer Could you take a look? I believe I've made all of the requested changes.

@dbaeumer Are we good to merge this?

@dbaeumer @Hirse I noticed the repo ownership changed since I opened this PR… is there anything I can do to get this merged and released? As far as I can tell, it's good to go.

@dbaeumer Sorry to keep nagging, but it's been over a month since I made the changes you requested! Did I miss anything? I'd really like to get this PR merged! 🙏🙏

I've merged the latest upstream changes into the PR branch, and verified that everything is working as expected.

I'd really appreciate some feedback regarding this PR!
By the way, the change requested is on a line that's unaffected by the actual change, which might be why GitHub isn't showing that PR comment as "outdated".

I merged it in but changed env back to let env: { [key: string]: string | number | boolean }. Was there a deeper reason why you remove number and boolean and added undefined. We should not allow undefined as a value in env when setting.

Thanks!! It's been awhile, but I think I made that change because I saw a type error when running the extension in debug mode? I've gotten to know TypeScript a lot better since I wrote that though, I agree that including undefined was a mistake. Although NodeJs doesn't allow process.env to contain values other than string - such values are just coerced to string though, so it's not that big of a deal.
Thanks again!

@mattlubner would you mind provide a default value for NODE_ENV configuration ?
I have met an issue with<EMAIL_ADDRESS>and ejected
debug info:
2022-02-02T09:24:47.689Z eslint:cli-engine Lint /Users/yzg/workspace/test/react-rxjs/src/index.js
2022-02-02T09:24:47.689Z eslint:linter Linting code for /Users/yzg/workspace/test/react-rxjs/src/index.js (pass 1)
2022-02-02T09:24:47.689Z eslint:linter Verify
2022-02-02T09:24:47.689Z eslint:linter With ConfigArray: /Users/yzg/workspace/test/react-rxjs/src/index.js
2022-02-02T09:24:47.693Z eslint:linter Parsing error: [BABEL] /Users/yzg/workspace/test/react-rxjs/src/index.js: Using `babel-preset-react-app` requires that you specify `NODE_ENV` or `BABEL_ENV` environment variables. Valid values are "development", "test", and "production". Instead, received: undefined. (While processing: "/Users/yzg/workspace/test/react-rxjs/node_modules/babel-preset-react-app/index.js")
Error: [BABEL] /Users/yzg/workspace/test/react-rxjs/src/index.js: Using `babel-preset-react-app` requires that you specify `NODE_ENV` or `BABEL_ENV` environment variables. Valid values are "development", "test", and "production". Instead, received: undefined. (While processing: "/Users/yzg/workspace/test/react-rxjs/node_modules/babel-preset-react-app/index.js")
    at module.exports (/Users/yzg/workspace/test/react-rxjs/node_modules/babel-preset-react-app/create.js:58:11)
    at module.exports (/Users/yzg/workspace/test/react-rxjs/node_modules/babel-preset-react-app/index.js:19:10)
    at sync (/Users/yzg/workspace/test/react-rxjs/node_modules/@babel/core/lib/gensync-utils/async.js:38:25)
    at sync (/Users/yzg/workspace/test/react-rxjs/node_modules/gensync/index.js:182:19)
    at /Users/yzg/workspace/test/react-rxjs/node_modules/gensync/index.js:210:24
    at Generator.next (<anonymous>)
    at /Users/yzg/workspace/test/react-rxjs/node_modules/@babel/core/lib/config/full.js:217:21
    at Generator.next (<anonymous>)
    at Function.<anonymous> (/Users/yzg/workspace/test/react-rxjs/node_modules/@babel/core/lib/gensync-utils/async.js:25:3)
    at Generator.next (<anonymous>)

https://github.com/facebook/create-react-app/blob/main/packages/babel-preset-react-app/create.js#L57
if there is no NODE_ENV setted, it will throw an error, I think set to NODE_ENV=development as default  might fix this.


correct ESGF link

esgf.org is non-functioning; see also https://github.com/ESGF/esgf.github.io/issues/6

ping @maxogden

:+1:

good catch. thanks for the patch

hey that rhymed!

+1 rhymes / all the times

:+1: :musical_note:


lose lock info risk

We store lock in separate column family, and we use rocksdb's write_without_wal api to apply raft log. When rocksdb need flush memtable to sstfile, it will choose the column family who's  memtable is bigger than the others, and will only flush this column falimy's memtable to sstfile in this round. This will cause one situation that the default column family's update(data and apply-index info) has flushed to sstfile, but the lock column family's update(lock info) still in memtable, when we shutdown tikv not gracefully, we face the risk of lose lock data.

@siddontang @ngaut @BusyJay


Define conceptual model for questions / widgets / blocks / forms

Not going to close this yet, but I think we've made pretty good progress on this -- may even be considered done.


Unable to read input register values via RS485

Hello,
I'm new to the Modbus protocol and I would like some help in my project.
I'm basically trying to get the voltage data from a power meter using the ESP-12E, RS-485 transceiver, and the Modbus RTU protocol.
The problem is: I'm not able to get any result.
Here's the code I'm using:
#include<ModbusMaster.h>  //include Modbus library
#include<SoftwareSerial.h>
#define MAX485_DE       3 //high to enable
#define MAX485_RE_NEG   2 //low to enable
ModbusMaster node;
void preTransmission()
{
digitalWrite (MAX485_RE_NEG, 1);
digitalWrite (MAX485_DE, 1);
}
void postTransmission()
{
digitalWrite (MAX485_RE_NEG, 0);
digitalWrite (MAX485_DE, 0);
}
void setup()
{
pinMode(MAX485_RE_NEG, OUTPUT);
pinMode(MAX485_DE, OUTPUT);
digitalWrite(MAX485_RE_NEG, 0);
digitalWrite(MAX485_DE, 0);
Serial.begin(115200);
node.begin(1, Serial);
node.preTransmission(preTransmission);
node.postTransmission(postTransmission);
}
void loop()
{
uint8_t resultMain;
resultMain = node.readInputRegisters (0x04,2);
if (resultMain == node.ku8MBSuccess)
{
Serial.println("--------------");
Serial.print("PV Voltage: ");
Serial.println(node.getResponseBuffer(0x01) / 1.0f);
}
delay(1000);
}
I'm attaching the results I'm getting as well as the data sheet from the developer of the power meter.
I would appreciate the help.

I observed following 2 points

your reading required 2 REGISTERS for evaluation of a one parameter(from SHORT column)
your readings will be required to get converted into data_type (here FLOAT - from FORMTO column)

      //for float conversation
      union
        {
          uint32_t i;
          float f;
        }u;
uint8_t result = node.readHoldingRegisters(address, 2); // for 0x03 registers
        Serial.println("Result : " + String(result));
        if (result == node.ku8MBSuccess)
        {
             u.i=(((unsigned long)node.getResponseBuffer(0x01)<<16) | (node.getResponseBuffer(0x00)));// shifting 2nd register to left & stiching with 1st register
        }
        Serial.println("Reading is "+String(u.f));

I observed following 2 points

your reading required 2 REGISTERS for evaluation of a one parameter(from SHORT column)
your readings will be required to get converted into data_type (here FLOAT - from FORMTO column)

      //for float conversation
      union
        {
          uint32_t i;
          float f;
        }u;
        uint8_t result = node.readInputRegisters(address, 2); // for 3000xx registers
        Serial.println("Result : " + String(result));// to get error type
        if (result == node.ku8MBSuccess)
        {
             u.i=(((unsigned long)node.getResponseBuffer(0x01)<<16) | (node.getResponseBuffer(0x00)));// shifting 2nd register to left & stiching with 1st register
        }
        Serial.println("Reading is "+String(u.f));

Hello!
This code worked for my hardware which works with data type FLOAT, bit sequence AB CD.
But I'm not very literate in programming (I'm dunce). How can I make a request (and how to get an answer) for several registers? Registers do not follow sequentially.

I only need registers:
30000-30001
30006-30007
30070-30071
30342-30343
How to redo the code? Need to repeat your example every time for a new address with new variable names? Or is there a more rational way?

store 0,6,70,342 into array & run loop

refer getReading() function of crypt_Mqtt_Modbus_wifiManager


Add wallet by web3 react

Add wallet by web3-react

Commit #5ba276f  to fix some case connect error  of issue #9

please handle this case for Frame

install frame, remove all accounts
try to connect
nothing happen

Magic: this dialog is shown when user attempt to login

Frame: please handle this case:

install frame, remove all accounts
try to connect
nothing happen

Ledge: try to connect without Ledge device -> nothing happen. Expect some dialog to show user that no device detect ... (please check the connector sample)
Magic: this dialog is shown when user attempt to login

So with Frame, Ledger we just need to display the error that the library returns?


Create Git templates

[ ] Contribution Guidelines
[ ] New Issues
[ ] Pull Requests

I already added contribution guidelines from nodejs project, check if its ok


Restore to different locations

One way to do this would be to have an "add redirect" button in the restore screen, where you could configure replacements for parts of the paths. It would probably look a lot like the roots editor from the backup screen.

Demo:


Fix #154: Highlight missing code blocks in docs

Coverage decreased (-1.3%) to 94.406% when pulling b0335d3edc04e65b10743749ddb651726d4401e4 on MarkusH:ticket/154 into 8f4c2774f8848466f1ca5712e0a6c1b8add6be44 on Bouke:master.

Coverage decreased (-1.2%) to 94.824% when pulling 3dcb4d3e9bef2178b3296683436e6e938fa7f646 on MarkusH:ticket/154 into cbf428aaefb04cdeaa293bf562ba9854e29352e0 on Bouke:master.


Light Mode

It seems to have a problem with the clear theme, it does not load the styles correctly.
LARAVEL 10.33.0
VITE v4.5.0
PHP 8.2.8

Hey,
could you please provide more details of your .scss file?
And do you mean the light mode with the clear theme?

I think I now where I have forgotten something. It's the auto theme, which causes this little bug. For now, u can add
`.card {
background-color: #fff !important;
}
input {
background-color: #fff !important;
}`
to your custom.scss.
Then it should be fixed...


Add a restart test to cosine bell

This merge adds a restart test to the cosine bell configuration.  This requires some changes to the validation framework for comparing variables to support the translation that Polaris performs between Omega native dimension and variable names and those for MPAS-Ocean that the Polaris ocean component uses generally.
A small amount of related cleanup is also included.

Checklist

[ ] User's Guide has been updated
[ ] Developer's Guide has been updated
[ ] API documentation in the Developer's Guide (api.md) has any new or modified class, method and/or functions listed
[ ] Documentation has been built locally and changes look as expected
[ ] Testing comment in the PR documents testing used to verify the changes
[ ] New tests have been added to a test suite

The restart test case nearly works but needs a fix for https://github.com/E3SM-Project/Omega/issues/181.

It works!!! Using a test merge of https://github.com/E3SM-Project/Omega/pull/184 with the current Omega develop, the cosine bell restart test passes on Chrysalis!

Testing
I successfully ran both the icos and qu cosine-bell restart tests with both MPAS-Ocean and Omega on Chrysalis.

I need to take care of documentation and adding tests to suites before I merge.

Okay, docs and test suites are up-to-date.


xvfb-run: clean up and update package

Motivation for this change
#72906
Things done
In addition to updating the package I also renamed it from xvfb_run to xvfb-run and added a backwards compatible alias, as xvfb_run is not an intuitive package name to install when trying to run the xvfb-run script.

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"

nix-review result
builder for '/nix/store/5807p8q8islcjxvk7nqziw0frld2pjv4-ping-0.6.0.drv' failed with exit code 1; last 10 log lines:
                    if(tempDataList.contains(variableName)){
                       ^^^^^^^^^^^^
../src/Application.vala:868.25-868.36: error: The name `tempDataList' does not exist in the context of `PingApp.setupSignals._lambda34_'
                        tempDataList[variableName] = new_text;
                        ^^^^^^^^^^^^
../src/Application.vala:869.67-869.78: error: The name `tempDataList' does not exist in the context of `PingApp.setupSignals._lambda34_'
                        testObjs[id].data = Soup.Form.encode_hash(tempDataList);
                                                                  ^^^^^^^^^^^^
Compilation failed: 36 error(s), 8 warning(s)
ninja: build stopped: subcommand failed.
cannot build derivation '/nix/store/m141iwy3anw90ygsrp243kva1xlljkbp-env.drv': 1 dependencies couldn't be built
[1 built (1 failed)]
error: build of '/nix/store/m141iwy3anw90ygsrp243kva1xlljkbp-env.drv' failed
1 package failed to build:
ping

102 package were built:
adapta-gtk-theme almanah amtk autokey balsa calls chrome-gnome-shell contrast coq_8_10 denemo empathy ephemeral epiphany flent fractal gImageReader gajim girara gitg glom gnome-builder gnome-latex gnome-photos gnome-podcasts gnome-usage gnome3.anjuta gnome3.cheese gnome3.devhelp gnome3.geary gnome3.gedit gnome3.gnome-calculator gnome3.gnome-calendar gnome3.gnome-contacts gnome3.gnome-control-center gnome3.gnome-music gnome3.gnome-session gnome3.gnome-shell gnome3.gnome-terminal gnome3.gnome-tweak-tool gnome3.gpaste gnome3.gtksourceview gnome3.gtksourceview4 gnome3.gtksourceviewmm gnome3.libdazzle gnome3.meld gnome3.mutter gnome3.nemiver gnome3.pomodoro gnome3.sushi gnome3.totem gnomeExtensions.gsconnect gobby5 gscan2pdf gtkd gtkpod gtksourceviewmm4 gtranslator gupnptools i3 i3-gaps i3-layout-manager i3-wk-switch jucipp kmymoney libhandy lutris lutris-free mate.mate-applets mate.pluma nasc notejot notes-up ocamlPackages.lablgtk3-sourceview3 pantheon.elementary-code pantheon.elementary-gsettings-schemas pantheon.elementary-onboarding pantheon.elementary-session-settings pantheon.notes-up paperwork polybarFull pspp python27Packages.cartopy python27Packages.i3ipc python27Packages.py3status python37Packages.dogtail python37Packages.i3ipc python37Packages.py3status python38Packages.dogtail python38Packages.i3ipc python38Packages.py3status pytrainer quilter rednotebook sequeler sysprof tepl tilix virtmanager xfce.mousepad xpad xvfb-run zathura

[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after) (210.2M -> 210.1M)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @davidak

Hmm, I'm not sure why this is in my memory, but I thought that xvfb-run actually came from an arch linux developer.

It looks like the first release is in Debian was in 2006 (commit). Arch Linux included the same version in 2009 via c9f8fec3 (related issue) from Debian.
The current version in Arch Linux comes from The T2 SDE Project which is also the current source for this package.
Debian still maintains its own version (history) actively.
Functionally should be still equivalent, but the Debian version uses a more reliable cleanup function and has an improved startup speed.
I just noticed that the Debian version uses a different license (MIT) which needs to be changed.

Only the description could be improved i think.

Good point, I updated the meta values to match the information found on repology.
I also updated the source revision to use the Debian release tag. This gives the version number a better meaning and makes it more relatable to the used commit.

Hmm, the T2 version seems to have introduced an --auto-display flag.
It would be nice if we managaed to upstream the script into xorg itself.

can we get this merged?


e2e Subscription    "with starting CSV" error

Bug Report
e2e Subscription    "with starting CSV" error
https://github.com/operator-framework/operator-lifecycle-manager/runs/4628064669?check_suite_focus=true#step:4:3404
Subscription
  with starting CSV
  /home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/subscription_e2e_test.go:358

[BeforeEach] Subscription
  /home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/subscription_e2e_test.go:57
created the subscription-e2e-mjc8n testing namespace
[It] with starting CSV
  /home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/subscription_e2e_test.go:358
Creating catalog source mock-nginx-vf7pc in namespace subscription-e2e-mjc8n...
Catalog source mock-nginx-vf7pc created
waiting for catalog pod mock-nginx-vf7pc to be available (for sync) - NO_CONNECTION
waiting for catalog pod mock-nginx-vf7pc to be available (for sync) - CONNECTING
waiting for catalog pod mock-nginx-vf7pc to be available (for sync) - TRANSIENT_FAILURE
waiting for catalog pod mock-nginx-vf7pc to be available (for sync) - TRANSIENT_FAILURE
catalog mock-nginx-vf7pc pod with address mock-nginx-vf7pc.subscription-e2e-mjc8n.svc:50051
17:26:19.8094:  (): nil
waiting for sub-nginx-22dj9 to have installplan ref
17:26:20.8107:  (): nil
waiting for sub-nginx-22dj9 to have installplan ref
17:26:21.8102:  (): nil
waiting for sub-nginx-22dj9 to have installplan ref
17:26:22.8103: UpgradePending (nginx-a): &ObjectReference{Kind:InstallPlan,Namespace:subscription-e2e-mjc8n,Name:install-728hg,UID:5994cb0c-655d-465d-89b2-b4835a66bf1d,APIVersion:operators.coreos.com/v1alpha1,ResourceVersion:10338,FieldPath:,}
waiting for sub-nginx-22dj9 to have installplan ref
installplan install-728hg is in phase RequiresApproval
Deleting config map mock-nginx-vf7pc-configmap...
Deleting catalog source mock-nginx-vf7pc...
[AfterEach] Subscription
  /home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/subscription_e2e_test.go:61
collecting the subscription-e2e-mjc8n namespace artifacts as the 'with starting CSV' test case failed
collecting logs in the ./artifacts/ artifacts directory
Storing the test artifact output in the artifacts/subscription-e2e-mjc8n directory
Collecting get catalogsources -o yaml output...
Collecting get subscriptions -o yaml output...
Collecting get operatorgroups -o yaml output...
Collecting get clusterserviceversions -o yaml output...
Collecting get installplans -o yaml output...
Collecting get pods -o wide output...
Collecting get events --sort-by .lastTimestamp output...
tearing down the subscription-e2e-mjc8n namespace

• Failure [58.732 seconds]
Subscription
/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/subscription_e2e_test.go:52
  with starting CSV [It]
  /home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/subscription_e2e_test.go:358

  	Error Trace:	subscription_e2e_test.go:439
  	            				runner.go:113
  	            				runner.go:64
  	            				it_node.go:26
  	            				spec.go:215
  	            				spec.go:138
  	            				spec_runner.go:200
  	            				spec_runner.go:170
  	            				spec_runner.go:66
  	            				suite.go:79
  	            				ginkgo_dsl.go:238
  	            				ginkgo_dsl.go:221
  	            				e2e_test.go:59
  	Error:      	"[{{InstallPlan operators.coreos.com/v1alpha1} {install-6l24h install- subscription-e2e-mjc8n  02bd3ccb-e1e8-498a-8ba5-a3729cd849dc 10347 %!s(int64=1) 2021-12-24 17:26:22 +0000 UTC <nil> %!s(*int64=<nil>) map[] map[] [{operators.coreos.com/v1alpha1 Subscription sub-nginx-22dj9 e35588d9-8d0e-4222-a85a-1a6d5fd2e432 %!s(*bool=0xc001cec74a) %!s(*bool=0xc001cec749)}] []  [{catalog Update operators.coreos.com/v1alpha1 2021-12-24 17:26:22 +0000 UTC FieldsV1 {"f:metadata":{"f:generateName":{},"f:ownerReferences":{".":{},"k:{\"uid\":\"e35588d9-8d0e-4222-a85a-1a6d5fd2e432\"}":{".":{},"f:apiVersion":{},"f:blockOwnerDeletion":{},"f:controller":{},"f:kind":{},"f:name":{},"f:uid":{}}}},"f:spec":{".":{},"f:approval":{},"f:approved":{},"f:clusterServiceVersionNames":{},"f:generation":{}},"f:status":{".":{},"f:catalogSources":{},"f:phase":{},"f:plan":{}}} }]} {  [nginx-a] Manual %!s(bool=false) %!s(int=2)} {RequiresApproval [] [mock-nginx-vf7pc] [nginx-a: nginx-a[operators.coreos.com/v1alpha1/ClusterServiceVersion (mock-nginx-vf7pc/subscription-e2e-mjc8n)] (Unknown) nginx-a: insblh9j.cluster.com[apiextensions.k8s.io/v1/CustomResourceDefinition (mock-nginx-vf7pc/subscription-e2e-mjc8n)] (Unknown)] [] nil <nil> }} {{InstallPlan operators.coreos.com/v1alpha1} {install-728hg install- subscription-e2e-mjc8n  5994cb0c-655d-465d-89b2-b4835a66bf1d 10344 %!s(int64=1) 2021-12-24 17:26:21 +0000 UTC <nil> %!s(*int64=<nil>) map[operators.coreos.com/nginx-mjn2k.subscription-e2e-mjc8n:] map[] [{operators.coreos.com/v1alpha1 Subscription sub-nginx-22dj9 e35588d9-8d0e-4222-a85a-1a6d5fd2e432 %!s(*bool=0xc001ceca1a) %!s(*bool=0xc001ceca19)}] []  [{catalog Update operators.coreos.com/v1alpha1 2021-12-24 17:26:21 +0000 UTC FieldsV1 {"f:metadata":{"f:generateName":{},"f:ownerReferences":{".":{},"k:{\"uid\":\"e35588d9-8d0e-4222-a85a-1a6d5fd2e432\"}":{".":{},"f:apiVersion":{},"f:blockOwnerDeletion":{},"f:controller":{},"f:kind":{},"f:name":{},"f:uid":{}}}},"f:spec":{".":{},"f:approval":{},"f:approved":{},"f:clusterServiceVersionNames":{},"f:generation":{}},"f:status":{".":{},"f:catalogSources":{},"f:phase":{},"f:plan":{}}} } {olm Update operators.coreos.com/v1alpha1 2021-12-24 17:26:22 +0000 UTC FieldsV1 {"f:metadata":{"f:labels":{".":{},"f:operators.coreos.com/nginx-mjn2k.subscription-e2e-mjc8n":{}}}} }]} {  [nginx-a] Manual %!s(bool=false) %!s(int=1)} {RequiresApproval [] [mock-nginx-vf7pc] [nginx-a: nginx-a[operators.coreos.com/v1alpha1/ClusterServiceVersion (mock-nginx-vf7pc/subscription-e2e-mjc8n)] (Unknown) nginx-a: insblh9j.cluster.com[apiextensions.k8s.io/v1/CustomResourceDefinition (mock-nginx-vf7pc/subscription-e2e-mjc8n)] (Unknown)] [] nil <nil> }}]" should have 1 item(s), but has 2
  	Test:       	Subscription with starting CSV

  /home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/vendor/github.com/stretchr/testify/require/require.go:1033

  Full Stack Trace
  github.com/stretchr/testify/require.Len(0x7fe2dc6b3aa0, 0xc00103ec40, 0x2f58a20, 0xc001abcdf8, 0x1, 0x0, 0x0, 0x0)
  	/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/vendor/github.com/stretchr/testify/require/require.go:1033 +0xdb
  github.com/operator-framework/operator-lifecycle-manager/test/e2e.glob..func20.8()
  	/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/subscription_e2e_test.go:439 +0x1208
  github.com/operator-framework/operator-lifecycle-manager/test/e2e.TestEndToEnd(0xc000794780)
  	/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/e2e_test.go:59 +0x2d6
  testing.tRunner(0xc000794780, 0x357d988)
  	/opt/hostedtoolcache/go/1.16.12/x64/src/testing/testing.go:1193 +0xef
  created by testing.(*T).Run
  	/opt/hostedtoolcache/go/1.16.12/x64/src/testing/testing.go:1238 +0x2b3

What did you do?
CI e2e test failed in a pull request
What did you expect to see?
No error
What did you see instead? Under which circumstances?
Error above
Environment

operator-lifecycle-manager version:

Kubernetes version information:

Kubernetes cluster kind:

Possible Solution

Additional context
Add any other context about the problem here.

The test failed where it checks only one installplan is created.  There were 2 installplans there.  Here is the log snippet of the catalog operator in the CI e2e log.  There are 2 worker for the namespace queue.


Add Blur background for iOS 7

Blurred background like original iOS7 have been added!!! You can just use it like what you did before, but the effect is addded.

An alternative solution is now implemented in the latest master.


Optimizing performance | Add shadow enabler

In my app if count nodes more 30+, so then starting freezing and downing performance. The culprit of all this's shadows. I added enabler shadow. And now in my project disabled shadows and i can spawn very more nodes
There was a problem:

Is it everything really necessary? It should be enough to check if the "ShadowColor" key is valid/populated and only in that case instance the shadow effect.

It seems to me that it was natural to create a shadow switch.

It seems to me that it was natural to create a shadow switch.

and what if the switch is true and the shadow color not setted?

This is a good idea for optimizing based on user's preference between appearance/drawing performance - however it may also warrant implementing shadow drawing ourselves - since it's likely we can make assumptions that Qt isn't aware of.


new(modern_probe): Add getuid, getgid, geteuid, getegid

Signed-off-by: David Windsor<EMAIL_ADDRESS>Add modern probes for:

getuid
getgid
geteuid
getegid

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test
/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap-engine-udig

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:
Which issue(s) this PR fixes:

#723
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: dwindsor
Once this PR has been reviewed and has the lgtm label, please assign leogr for approval by writing /assign @leogr in a comment. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

wow man, you are on :fire: I will take a look ASAP!

/hold

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

7dceb70 Merge branch 'master' into add-getuid-modern-probe

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dwindsor: Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dwindsor: Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dwindsor: Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dwindsor: Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

I know conflicts are quite a pain, unfortunately, we will have a conflict in the events_prog_names.h file every time we merge a set of syscalls, so be ready to do that again and again for all your PRs :/

Only some minor details, after that we should be ready on my side.

Also looked through, with the suggested changes from @Andreagit97 , this also looks fine to me.

LGTM label has been added.  Git tree hash: 119cb16e1094a28263b7293fd3d0cfb3b4042152

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: dwindsor, hbrueckner
Once this PR has been reviewed and has the lgtm label, please assign leogr for approval by writing /assign @leogr in a comment. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

yeah this should be ready! but we need to resolve conflicts :(

New changes are detected. LGTM label has been removed.

yeah this should be ready! but we need to resolve conflicts :(

Rebased =)

LGTM label has been added.  Git tree hash: b9909924cff82c49e1bdbdea25062a73491dd0b6

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, dwindsor, hbrueckner
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, dwindsor, FedeDP, hbrueckner
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/unhold


ENH: remove  clean_output_dir parameter

Remove clean_output_dir option. Instead trucate the output file before starting to materialize.

This has been addressed in Morph-KGC v2.0.0.


About the distributed inference

Hi, I saw you upload inference.py. I thought that it can support the inference on multi-gpu. So i wonder how to set the parameter on "--model-device". Thanks so much.

When i set --model-device=cuda, the following error occurred.
RuntimeError: CUDA error: CUBLAS_STATUS_NOT_INITIALIZED when calling cublasCreate(handle)

I update a new version of inference.py and README.md. Now no need --model-device, the scripts will use visible devices to do the inference. Usage of inference.py can refer to https://github.com/hpcaitech/FastFold#inference
For CUDA error, I hope you can provide more hardware details and how you run the code.


About the review data of movies

Hi authors, I currently try to run your code. But there is some missing data called movie2tokenreview_helpful.pkl. Could you share this file with us. Thank you.

是的 我也缺失这个文件


[TRG 1.02] Create an appropriate INSTALL.md, moving GETTING_STARTED.md

Introduction
There is a issue related to the Install.md file which is named getting started.
As mentioned in #31 there is missing important documentation for the end user.
What needs to be done?

[x] Refactor the documentation to describe to the user how can it be installed in a simple way.

The instalation mentioned in the readme needs to be refactored
https://github.com/eclipse-tractusx/digital-product-pass/blob/efd3cd80aa22af1d4ef16430ff3c6b74b13eca10/README.md?plain=1#L83

Resolved in #v1.0.0-rc1!


Fix race in hash build memory tracking

The transfer of memory reservation ownership from the operator context
to the task context was not atomic. Therefore other tasks will observe a
free memory when there actually isn't any, while the hash build is
finishing.

This looks good, but I think there is another one of these for cross joins that needs to be updated.

Curious if we know what versions of Presto this affects?

Versions 0.106 to 0.123

Thanks!


google-guest-agent: 20230726.00 -> 20230821.00

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/GoogleCloudPlatform/guest-agent/releases.
meta.description for google-guest-agent is: Guest Agent for Google Compute Engine
meta.homepage for google-guest-agent is: https://github.com/GoogleCloudPlatform/guest-agent
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 20230821.00 with grep in /nix/store/6v4w11aafifv9hc9g2x7xy8dx803kixb-guest-agent-20230821.00
found 20230821.00 in filename of file in /nix/store/6v4w11aafifv9hc9g2x7xy8dx803kixb-guest-agent-20230821.00

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
google-guest-agent

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/6v4w11aafifv9hc9g2x7xy8dx803kixb-guest-agent-20230821.00 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A google-guest-agent https://github.com/r-ryantm/nixpkgs/archive/140b6ebdccd99e665629e4be9ba51d21cbc4be3b.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/6v4w11aafifv9hc9g2x7xy8dx803kixb-guest-agent-20230821.00
ls -la /nix/store/6v4w11aafifv9hc9g2x7xy8dx803kixb-guest-agent-20230821.00/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

google-guest-agent

Maintainer pings
cc @abbradar for testing.

Result of nixpkgs-review pr 251519 run on x86_64-linux 1

1 package built:

google-guest-agent


How can I display a board inside a popup?

I am trying to create a small n-queen solver and I want to add an interactive board each time a player clicks on the secondary action of a list item.
The thing is that I am not sure how to initiate the board when it is inside the template code.
Please refer to this plunk for a better understanding.

It seems this isn't really a question about chessboard.js so much as it is a question about angular / your specific setup. You might have better luck posting this on StackOverflow.


Filter notifications by Organization/User

📝 Provide a description of the new feature
Similar to Github, we could have logos in the sidebar to filter by organization. Yes, it wouldn't have the same value as GitHub, but we already group by repo, so I suppose the value is already there.

GitHub UI
 Gitify sidebar

➕ Additional Information
No response

Now that we have collapsible headers, I wonder if we can achieve something close to this by adding a notification count badge to our headers (account and repository)

Something like this (or similar)...


2pc: implement new RecordQuery

The new RecordQuery functionality records actual DMLs sent to
MySQL. The old one used to record the requested DML. The actual
DMLs will replay more accurately when re-preparing 2pc transactions.

LGTM