[core] core_drop_files example not working

Please, before submitting a new issue verify and check:

[x] I tested it on latest raylib version from master branch (latest commit: February 24, 2023 at 10:19:25 AM EST)
[x] I checked there is no similar issue already reported

Issue description
Dropped files flash for a frame before disappearing, never actually keeping state.
The IsFileDropped() function returns true in the first frame, allowing LoadDroppedFiles() to fetch the file. It is however true for a second frame so the previous FilePathList is unloaded via UnloadDroppedFiles and we call LoadDroppedFiles() which this time returns an empty FilePathList, effectively preventing the drop files example to work. It is then false as expected on the third frame.
Environment
Tested on the following platforms:

macOS arm64 Safari 16.2
macOS arm64 Firefox 109.0.1
macOS arm64 Chrome 110.0.5481.177
macOS arm64 built from source, latest master commit

Code Example
See the drop files example.

Sorry to bump this but I though the fix would be making IsFileDropped properly return false on the second frame.
I think this would make much more sense (since there are no files being dropped on that frame).

@Lancelotbronner Actually, the redesign is the expected approach. IsFileDropped() returns false after the dropped files are being unloaded from memory.

Of course, and that makes sense, I'm talking about the true which is returned on the frame after files are dropped, which is incorrect because there are no files being dropped, so loading dropped files returns an empty list.

@Lancelotbronner Sorry, I'm afraid I don't understand the issue. IsFileDropped() returns true when there is some file dropped and it's reseted after calling UnloadDroppedFiles(), so, on the next frame it return false again because files have been already processed. I'm testing it on Windows 10.
Please, could you elaborate the issue with more detail?

Maybe the issue doesn't happen on Windows, the issue is as follows:

Frame 1: the files are dropped, true is returned, LoadDroppedFiles returns the filepaths
Frame 2: no files are dropped, true is returned, LoadDroppedFiles returns an empty list of filepaths
Frame 3 onward: no files are dropped, false is returned

The problem is Frame 2, where IsFileDropped wrongly returns true.

@Lancelotbronner Ok, Frame 2 does not happen on Windows. Are you calling UnloadDroppedFiles()? It sets CORE.Window.dropFileCount and consequently IsFileDropped() shouldn't return true on next frame.
In any case, it could be a system issue reporting an empty event, I added a code tweak, just in case, let me know if it solves the issue.

@Lancelotbronner Could you try doing next lines?
FilePathList files;

if (IsFileDropped())
{
    files = LoadDroppedFiles();

    // Copy files.paths as required

    UnloadDroppedFiles(files);
}

In any case, it seems a macOS system issue, probably the WindowDropCallback() is called twice, I don't know why...
It should be debugged carefully but I have no macOS...

If on the copy I myself check if there are available paths to copy then I can workaround the issue easily, but I'll do the careful debugging to see where it goes wrong!

So here's what I observed:

WindowDropCallback is only called once
WindowDropCallback frees previously allocated file paths
LoadDroppedFiles doesn't load anything, it simply gets the currently loaded file paths

So what I was doing
if (IsFileDropped()) { // only true on the frame the file is dropped
  if (files.paths)
    UnloadDroppedFiles(files); // Unload previously loaded files
  files = LoadDroppedFiles(); // Load new dropped files
}

was actually doing
if (IsFileDropped()) { // always true once a file has been dropped
  if (files.paths)
    UnloadDroppedFiles(files); // Unload currently loaded files
  files = LoadDroppedFiles(); // Load empty files
}

On the first frame, since files was empty, it would load the current frame's paths. On the next frame files was no longer empty, unloading the files. On the third frame, IsFileDropped would return false until files were dropped again.
I see two issues which led me to assume the wrong behaviour for these methods

IsFileDropped returns true once files have been dropped until you call UnloadDroppedFiles while I assumed it only returned true on the frame the files were dropped
LoadDroppedFiles gets the currently loaded files while I assumed it loaded the files dropped this frame.

So the "correct" code is
FilePathList files = {};

if (IsFileDropped()) // always true once a file has been dropped
  files = LoadDroppedFiles(); // Get the currently loaded files

// at de-initialization...
UnloadDroppedFiles(files) // unload (globally-tracked by raylib) dropped files if any

I believe the "fix" to this should be to revise the API to be more in line with the actual behaviour and the assumptions made.
The solution I came up with, considering you strive for a simple API for education purpose, is to:

Correct the behaviour of bool IsFileDropped to only return true on the frame files were loaded
Remove FilePathList LoadDroppedFiles() and UnloadDroppedFiles(FilePathList files)
Add char** GetDroppedFiles() and unsigned int GetDroppedFilesCount()
Unload dropped files if any in CloseWindow

I believe this would be the best solution since raylib already does most of the dropped files memory management. This would just correct the API to reflect that and simplify things for the students. It's a very simple migration even on larger projects and could be made non-breaking easily (more on that further down).
Here's the drop files example with the new API, requiring only raylib.h.
const int screenWidth = 800;
const int screenHeight = 450;

InitWindow(screenWidth, screenHeight, "raylib [core] example - drop files");
SetTargetFPS(60);

while (!WindowShouldClose()) {
    BeginDrawing();

    ClearBackground(RAYWHITE);

    if (GetDroppedFilesCount() == 0)
        DrawText("Drop your files to this window!", 100, 40, 20, DARKGRAY);
    else {
        DrawText("Dropped files:", 100, 40, 20, DARKGRAY);

        for (unsigned int i = 0; i < GetDroppedFilesCount(); i++) {
            if (i%2 == 0) DrawRectangle(0, 85 + 40*i, screenWidth, 40, Fade(LIGHTGRAY, 0.5f));
            else DrawRectangle(0, 85 + 40*i, screenWidth, 40, Fade(LIGHTGRAY, 0.3f));

            DrawText(GetDroppedFiles()[i], 120, 100 + 40*i, 10, GRAY);
        }

        DrawText("Drop new files...", 100, 110 + 40*GetDroppedFilesCount(), 20, DARKGRAY);
    }

    EndDrawing();
}

CloseWindow();

If we wanted to make things non-breaking for the current release, the solution would instead be:

Leave bool IsFileDropped as-is
Leave FilePathList LoadDroppedFiles() and UnloadDroppedFiles(FilePathList files) as-is
Add char** GetDroppedFiles() and unsigned int GetDroppedFilesCount()
Unload dropped files if any in CloseWindow

What do you think of this?

Dorry, current behaviour is the expected behaviour. It was already changed.


manifest for python:2.7.14-alpine3.7 not found

There's supposed to be a 2.7.14-alpine3.7 tag per the documentation, but I get this error:
$ docker pull python:2.7.14-alpine3.7
Error response from daemon: manifest for python:2.7.14-alpine3.7 not found

2.7.14-alpine3.6 works fine

Yeah, the amd64 build queue for official images is a bit overloaded right now -- give it a little time and it'll come through (once the build servers get around to python).
See also docker-library/rabbitmq#188, docker-library/ruby#159, c0b/docker-erlang-otp#75, docker-library/official-images#3472, https://github.com/docker-library/wordpress/issues/239, https://github.com/piwik/docker-piwik/issues/70, https://github.com/nodejs/docker-node/issues/571, https://github.com/docker-library/official-images/issues/3653, https://github.com/docker-library/official-images/pull/3622#issuecomment-339838650, https://github.com/docker-library/redis/issues/115, https://github.com/docker-library/rabbitmq/issues/217.

I've filed https://github.com/docker-library/official-images/issues/3835 in order to have a central place to track this problem globally more directly. :+1: :heart:


optimize code

What is the purpose of the change
more concise for code
Brief changelog
more concise for code
Verifying this change
only replace with Math.min()
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

replace with Math.min()

Coverage increased (+0.02%) to 50.869% when pulling<PHONE_NUMBER>9776dd21d528d202f3660c47f94b2a on victorhujt:master into e923a35393a6dfa83677335e96fdb4b063f10d32 on apache:master.

This pull request seems to have no major effect, so I will close it.
If you have any questions, you can resubmit the pull request. But Plz pay attention to the following points:
Firstly, plz submit related issues to link this PR and explain the purpose of PR according to the format.
Second, you need to change the target branch to develop.
Finally, plz name the pull request in the correct format.


Explore use for managing biases in LLMs/textual corpuses

Reducing the bias signal strenght by dilution through generation of inverse, variant and duplicated concept relationships in LLMs/graphs. E.g. women do X, generate complement men do X, blacks do Y, generate variant other races do Y, russians do Z, generate complement other nations do Z
Requires #14?
https://www.theverge.com/2016/3/24/11297050/tay-microsoft-chatbot-racist
https://www.reuters.com/article/us-amazon-com-jobs-automation-insight-idUSKCN1MK08G
https://dl.acm.org/doi/10.1145/3460231.3474241
https://www.technologyreview.com/2020/07/17/1005396/predictive-policing-algorithms-racist-dismantled-machine-learning-bias-criminal-justice/
From: @karllattimer

Notes: proposed to build a multilingual taxonomy/ontology of offensive language and sensitive/taboo topics because it would be fun to make and research and even if it weren’t used in dilution of LLMs. LLM lobotomy comment.. if it wasn’t used for that, it could help companies navigate the minefield of naming their products and local marketing

Offensive language vocabulary


issue-352: support caf --wrapping option

Avg response time
coverage on master

This pull request (PR) is a:

[x] Bug fix
[ ] Feature addition
[ ] Other, Please describe:

I certify that:

[x] I have reviewed the contributing guidelines
[ ] If this PR is a work in progress I have added WIP: to the
beginning of the PR title
[ ] If this PR is problematic for any reason, I have added
DO NOT MERGE: to the beginning of the title
[x] The branch name and title of this PR contains the text
issue-<#> where <#> is replaced by the issue that this PR
is addressing
[x] I have deleted trailing white space on any lines that this PR
touches
[ ] I have used spaces for indentation on any lines that this PR
touches
[ ] I have included some comments to explain non-obvious code
changes
[ ] I have run the tests localy (ctest) and all tests pass
[x] Each commit is a logically atomic, self-consistent, cohesive
set of changes
[ ] The commit message should follow these guidelines:

[ ] First line is directive phrase, starting with a capitalized
imperative verb, and is no longer than 50 characters
summarizing your commit
[ ] Next line, if necessary is blank
[ ] Following lines are all wrapped at 72 characters and can
include additional paragraphs, bulleted lists, etc.
[ ] Use Github keywords where appropriate, to indicate the
commit resolves an open issue.

[x] I have signed  Contributor License Agreement (CLA) by
clicking the "details" link to the right of the licence/cla
check and following the directions on the CLA assistant webpage
[ ] I have ensured that the test coverage hasn't gone down and added new unit tests to cover an new code added to the library

Summary of changes
Summarize what you changed
Rationale for changes
Why did you make these changes?
For contributors and SI team members with code review priviledges

[ ] I certify that I will wait 24 hours before self-approving via
pullapprove comment or Github code review so that someone
else has the chance to review my proposed changes

LGTM
@LaHaine Do you have a particular reason why you want this option over the one we already provide?


Rename -solidity-version parameter suffix with -contracts-version

Change introduced for better understandability of parameter's meaning.
Refs:
https://github.com/keep-network/keep-ecdsa/pull/864
https://github.com/keep-network/tbtc/pull/814
https://github.com/keep-network/tbtc.js/pull/127
https://github.com/keep-network/upstream-builds-query/pull/3
https://github.com/keep-network/coverage-pools/pull/157

NOTE: If changes from https://github.com/keep-network/keep-core/pull/2531 get merged to main before this PR, there will be additional commit here. And if otherwise, additional commit will be needed in https://github.com/keep-network/keep-core/pull/2531.

@michalinacienciala we've got conflicts here.

@michalinacienciala we've got conflicts here.

@nkuba, resolved


Column Title Changes Do Not Persist when using Emojis in Title

Bug report
What is the actual(incorrect) behavior?
When I change the title of the columns, other users do not see it.  If I close the browser and come back, the titles revert to the default titles.
What is the expected(correct) behavior?
Column title changes should be cascaded to other users and should persist to new sessions
Please provide your browser and OS versions:
Google Chrome Version 84.0.4147.105 (Official Build) (64-bit)

@Druage - let me know your thoughts on this one.  If you think its worth implementing I can make the necessary code changes.

it looks like you can type the characters like :-) and those persist but if you enter the unicode characters for the same emoji, it won't persist since the backend data type doesn't currently support unicode characters. Is this something you are still interested in pursuing?

Yes, most websites today support emojis.  Is it high priority...?  Probably not

Seems possible... https://dev.mysql.com/doc/refman/8.0/en/charset-unicode.html

Since we moved to recommending postgres as the preferred database this appears to have been resolved.


ellipticity_ryden04 has a shape mismatch bug

Describe the Bug
The implementation right now keeps sampling values until it gets all positive values -
https://github.com/glass-dev/glass/blob/2eb3e8bd94adf5f25c67a54fba0484a49c38b212/glass/shapes.py#L142-L151
Let's say if mu = [-1.85, -2.85], gamma = 0.89, gamma = 0.222, sigma_gamma = 0.056 -

size = (2,)
eps.shape = (2,)
rng.normal(mu, sigma) will have the shape (2,) because numpy broadcasts the parameters internally

If one value in eps is bad (<0) -

bad = [True, False]
eps[bad].shape = (1,)

then this will not work -
eps[bad] = rng.normal(mu, sigma, size=eps[bad].shape)

as a (2,) array cannot be resized to (1,).

This bug was hidden by the float value is not indexable error when the broadcasting rule was not present.
I am not sure what should be done here. Should we consider using something like truncated normal here?
To Reproduce
from glass import ellipticity_ryden04

while True:
    ellipticity_ryden04([-1.85, -2.85], 0.89, 0.222, 0.056)  # rerun till it errors out

Expected Behaviour
No shape mismatch error.
Actual Behaviour
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
      1 while True:
----> 2     ellipticity_ryden04([-1.85, -2.85], 0.89, 0.222, 0.056)

File ~/Code/UCL/glass/glass/shapes.py:146, in ellipticity_ryden04(mu, sigma, gamma, sigma_gamma, size, rng)
    144 bad = eps > 0
    145 while np.any(bad):
--> 146     eps[bad] = rng.normal(mu, sigma, size=eps[bad].shape)
    147     bad = eps > 0
    148 gam = rng.normal(gamma, sigma_gamma, size=size)

File numpy/random/_generator.pyx:1288, in numpy.random._generator.Generator.normal()

File _common.pyx:621, in numpy.random._common.cont()

File _common.pyx:539, in numpy.random._common.cont_broadcast_2()

File _common.pyx:250, in numpy.random._common.validate_output_shape()

ValueError: Output size (1,) is not compatible with broadcast dimensions of inputs (2,).

Version In Use
main
Additional Context
- Python version: 3.11
- Operating system: macOS

bad = np.where(eps > 0) ?


Think about to fix the issues found by adapter checker

I am an automatic service that looks for possible errors in ioBroker and creates an issue for it. The link below leads directly to the test:
https://adapter-check.iobroker.in/?q=https://raw.githubusercontent.com/smaragdschlange/ioBroker.nuki

[x] [E152] No common.dataSource found in io-package.json
[x] [E605] No actual year found in copyright. Please add "Copyright (c) 2018-2021 smaragdschlange<EMAIL_ADDRESS>at the end of README.md
[x] [E701] No actual year found in LICENSE. Please add "Copyright (c) 2018-2021 smaragdschlange<EMAIL_ADDRESS>at the start of LICENSE

Thanks,
your automatic adapter checker.
P.S.: There is a community in Github, which supports the maintenance and further development of adapters. There you will find many experienced developers who are always ready to assist anyone. New developers are always welcome there. For more informations visit: https://github.com/iobroker-community-adapters/info

Thanks, that all bugs have been fixed.


Cant filter items when using list_and_get method

-[ ] Я уверен, что моя проблема именно в либе fast_bitrix24.
There is just no option to filter the items when using list_and_get method. as the data im getting is so big, it still hits some limit
{'error': 'OPERATION_TIME_LIMIT', 'error_description': 'Method is blocked due to operation time limit.'}

This method is deprecated from 1.6.0.

is there a replacement? or it is just gone?

This method is deprecated from 1.6.0.

is there a replacement? or is it just gone? it seemed to be quite fast compared to the other methods/libraries i have tried

The whole library is a bit more "law-abiding" now.
The user is now heavily penalised for breaking the request rate limits.
So, there is no need to have "pirate" approaches that list_and_get used — "let's bombard the server with requests and dial back when the server starts to fail".
Better use get_all("crm.*.list") now with carefully configured lists of extracted columns and filters. This will save server processing time which is now tracked and limited by the server.


Did you try sshfs ?

Hi there i played a lot like you with all kind of ways to connect the volumes somehow.
I miss my best bet on your list, sshfs... i had the best results connecting the box to the mac, even
mongodb and meteor was able to run.
Hope that helps someone somehow ...

Can you post more info on your setup?

Interesting topic. Maybe there's an option to replace current rsync with osxfuse-based solution?

Does anyone have time to play around with FUSE, sshfs, etc? I'd love to see how they compare with rsync in terms of performance and ease of setup.
FWIW, I played around with a number of syncing solutions years ago in a slightly different context and found all of the two-way solutions--including unison, sshfs, fuse, aerofs, and a bunch of others--to be either too slow or too unreliable (e.g., random files wouldn't sync, errors would show up intermittently, etc). That said, I was syncing between remote systems, so perhaps on the same computer when talking to a Docker VM, it would be a completely different story.

Unfortunately I can only second that notion. At the time I ran MacFUSE, also in different (remote) context, it was completely unreliable. Current bug base of osxfuse isn't very assuring either.

Hi there, i can't remember the exact setup but sshfs was used on the docker image not on the mac.
Here is what i remember so far:

start an ubuntu container

docker run --name u2 -i -t --cap-add SYS_ADMIN --device /dev/fuse ubuntu /bin/bash

install sshfs on the container

apt-cache update
apt-get install sshfs

create a Users directory on the container to emulate behavior of boot2docker

mkdir /Users/
sshfs username@machost:/Users/macUserName /Users -o idmap=user -o uid=$(id -u) -o gid=$(id -g)

Good Luck


Mrtk wireframe and standard shader fix

Overview
Both shaders had errors, at least on Android.
Turned out both were missing one line of code mandatory for proper SinglePassInstancing usage:
https://docs.unity3d.com/Manual/SinglePassInstancing.html
v2f vert (appdata v)
{
    v2f o;

    UNITY_SETUP_INSTANCE_ID(v); //Insert
    UNITY_INITIALIZE_OUTPUT(v2f, o); //Insert
    UNITY_INITIALIZE_VERTEX_OUTPUT_STEREO(o); //Insert

    o.vertex = UnityObjectToClipPos(v.vertex);

    o.uv = v.uv;

    return o;
}

Changes

Fixes: #5844

wasn't quite it...

Thank you for trying this! Did you still see the same shader compilation errors after adding these macros?

@Cameron-Micka I'm not entirely sure. Too late I realized that changing the shader code could immediately remove the error in unity. Only when compiling the shader again via the compile button on the shader in the inspector the error when away.


⚡ Add hashing to core types

Both Base and Table primitives have a unique identifiers but neither of them implements __hash__. This is problematic, because user application might want to want to use the primitives in cached function(lru_cache), but they will not work out of the box without __hash__ function.
I wanted to also add __hash_ to RecordDict, however since it's a dict I can't.
Is there any reason why RecordDict is not dataclass ?

You should be able to use lru_cache with these classes; by default, it will use the object's identity as a hash. Given that Api, Base, etc. are mutable and contain complex state, I'm not sure it's appropriate for two separate instances to be treated as if they are the same object. That could create its own unintended consequences.
If you've run into any specific issues besides passing these into lru_cache, would you mind sharing a minimally reproducible sample of the problem?
Re: RecordDict, previous versions of the library returned dict (prior to implementing types), so we've preserved that for backwards compatibility. We could look into doing that as a breaking change in the future, but we'd probably want to add __getitem__ to reduce the impact on existing library users.

You should be able to use lru_cache with these classes; by default, it will use the object's identity as a hash. Given that Api, Base, etc. are mutable and contain complex state, I'm not sure it's appropriate for two separate instances to be treated as if they are the same object. That could create its own unintended consequences`

Good point, I forgot how stateful the classes are...

If you've run into any specific issues besides passing these into lru_cache, would you mind sharing a minimally reproducible sample of the problem?

Not really, the biggest problem I faced was during retrieving of linked records. Because many linked records are the same in some tables, I just wanted to have some sort of caching.

Re: RecordDict, previous versions of the library returned dict (prior to implementing types), so we've preserved that for backwards compatibility. We could look into doing that as a breaking change in the future, but we'd probably want to add getitem to reduce the impact on existing library users.

Make sense
Closing the PR as I no longer see a common benefit for most of the users.


DSEGOG-362 add a user

Description

an admin should be able to add a user
User react hook form and zod as the dialog has multiple fields

Testing instructions
Add a set up instructions describing how the reviewer should test the code

[ ] Review code
[ ] Check Actions build
[ ] Review changes to test coverage

Agile board tracking
closes DSEGOG-362


Q: can we specify the bot to download images that were sent on a particular date?

so, there were about 30 or 40 images that were sent on a particular day(in this case lets say January 2, 2018) how would you tell the bot to get images that were sent on that exact date?

No, that's currently not a feature, feel free to create a pull request.


EMAIL_USE_SSL in example.

EMAIL_USE_TLS = False doesn't make EMAIL_USE_SSL=True.
But, this is missing in the examples. So, I have added it.

Thank you!


Make generator conda-installable

I would like to be able to do:
source activate root
conda install -c anaconda-notebook generator-nbextension
extension_template [--options]

And if that is complicated, then the last line could instead be:
yo nbextension

but I would prefer not to have to expose the user to yo or any other node, yeoman or nodejs intermediate tooling.

@ijstokes if you are ok with:
conda install generator-nbextension -c anaconda-notebook -c javascript and yo nbextension then we are good :smile:

@malev that is fine with me.  The only surprising bit (but I've never used "yeoman" before) was that I needed to execute the command in a new directory that I created first.  When I tested it I was surprised that it dumped a bunch of files in my current directory.  I expected they would all be encapsulated in a single sub-directory.
Anyway, this is OK for now at least (and maybe that behavior is expected), and the extension that was created worked nicely.  So I'm calling this done.


Reconsider growing strategy in HpackHuffmanDecoder

At the moment we just increase my intialCapacity but it may make sense to double it up to a certain size:
https://github.com/netty/netty/blob/4.1/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackHuffmanDecoder.java#L237

thanks for reporting @normanmaurer! My guess is this will have a measurable impact if the initial size is too small (currently defaults to 32).

@Scottmitch agree... I would say we should double up to 512 bytes . WDYT ? I can do a pr

It will depend upon the use case but can we derive a guess from https://github.com/http2/http_samples or some other sample size? We can start with 512 or 1024 and refine later if you don't have much cycles to investigate.

@Scottmitch good idea... let me check

@Scottmitch here you go https://github.com/netty/netty/pull/6857. I think I will have not much time to long into it in more detail so I just used 1024 for now

1024 sounds like a good start to me ... we can revise/improve later if necessary.

Fixed by https://github.com/netty/netty/pull/6857


syntax error in dockerfile

At the first step where we add ruby version to be complied in Dockerfile (FROM ruby-2.6.2:stretch) throws an error:
Sending build context to Docker daemon  249.7MB
Step 1/1 : FROM ruby-2.6.2:stretch
pull access denied for ruby-2.6.2, repository does not exist or may require 'docker login'

It should be FROM ruby:2.6.2-stretch.

@abhinaykumar Thank you very match for pointing it out. I just fixed that on the post.


[openssl] Update to 1.1.1m

What does your PR fix?
Fixes #22375

Which triplets are supported/not supported? Have you updated the CI baseline?
No

Does your PR follow the maintainer guide?

Yes

Merging once green

@strega-nil-ms looks green ;)

@gracicot thanks! :)


Demo deployment with Stripe: "Invalid Credentials" error message when trying to sign up

I followed all the instructions to deploy this demo, and everything ran successfully. I can see the products information both in APIM and Stripe. When I try to sign up to Developer Portal, I get redirected to the Web App and after entering any type of credentials and hitting the Sign-up button, I always get the "Invalid Credentials" error message
Looking at the Web App logs, I can see a 302 http code when the POST /signUp request is triggered. And this is the response url I get after hitting the Sign-up button:
https://app-apim-monetization.azurewebsites.net/apim-delegation?errorMessage=Invalid credentials&returnUrl=%2F&operation=SignUp&salt=DubYQ0sJC%2F8K3sAIc6TBw2PvW%2Bn4Uk4qD9TnZepMikM%3D&sig=0bkL1gQtCrJzqcC5Z7h1Ja1meewi9M%2Bl4ReSkqJhXdb3btZ1%2Bo0EpammjcyhqDiGuPMEvWELhhuX%2F2l0FFF7Sg%3D%3D
Can you please help me get this issue fixed?

We've not seen any issues like this throughout the development process of this sample. Could it be a cached cookie? Do you have any other diagnostic logs? Did the deployment scripts successfully run without any errors or warnings?
/cc @MikeLarah

Thanks @HowardvanRooijen for your prompt reply. I would understand there could be a caching issue with the sign-in option, but with sign-up? Is there any password validation that maybe I am not being compliant with?
The only thing that I missed was cloning the monetizationModels.json. I just downloaded and executed the stripeInitialisation.ps1 file. The demo deployment was 100% successful and then after initialization, I could see products and pricing models set in Stripe. Not sure if this missing step has to do with my issue though
I'll run all the deployment steps again and see if I run into the same issue. Will let you know in a couple of hours

Hi @HowardvanRooijen I redeployed the demo, this time using the power shell script instead of Azure Portal, and I am getting exactly the same error:  "Invalid Credentials" every time that I want to sign up. This time, I was extremely careful in following all the steps mentioned in the page: https://github.com/microsoft/azure-api-management-monetization/blob/main/documentation/stripe-deploy.md. All the deployment steps were successfully executed. I've been trying to sign up using InPrivate windows to avoid any caching issues
What information can I send in order for you to identify the root cause of the issue? a call may be a faster way of troubleshooting

Following up on this


Set .gitmodules to branch that adds Mermaid charts

Creating this PR to deploy a Vercel preview. No intention of merging.

Closing since I don't need to do further development work on this branch.


Mapping issues

There are a number of mapping issues and mappings that we need to discuss:
I have inserted the table I created detailing the issues. There also appear to be issues with time conversions.

Time in ITK can be sent as current time (ie BST) or UTC.  Nothing in the specs specifies which!  So different suppliers do different things.  All are using an offset however some only use +-ZZ not +-ZZzz. So adaptor needs to assume zz=00 (correct in UK as we have no time zones less than an hour).  Note that some with send +0100 in BST and some will convert to UTC and send +0000.  Adaptor needs to convert and decide which it saves into FHIR for the onward supplier.

ITK Examples to be transformed (2).zip
Attached are various styles of messages

Fixed in 0.8.0 release


[DRAFT] fix (net6): handle RejectedExecutionException happening for ubuntu IO completed operations

/azp run

/azp run

/azp run

/azp run

more changes in the base branch (https://github.com/maksimkim/SpanNetty/pull/34), closing


Add pynxtools-xps as extra install

Following the initial release of pynxtools at https://pypi.org/project/pynxtools-xps/, allow for installing with pynxtools as an extra install.

Currently breaking tests because of ifes_act_tc_data_modeling==0.9 in pyproject.toml, see #263.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 45.768%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3596

Relevant Lines:
7857

💛  - Coveralls


Disable network policy for Keycloak by default

Ensures ingress-controller can connect to Keycloak (provided they are not using host network)
Disable network policy for Keycloak.
Add a warning in the feature explanation page that users should not blindingly activate netpol for Keycloak when also Ingress.

Fixes #19
Regression from #17
Checklist

[x] Keep pull requests small so they can be easily reviewed.
[x] Update the documentation.
[x] Categorize the PR by setting a good title and adding one of the labels:
bug, enhancement, documentation, change, breaking, dependency
as they show up in the changelog
[x] Link this PR to related issues.

@megian this PR also includes the commit to fix the port in the network policy. I figured it makes more sense here.


How do I detect when plugins are finished loading.

I want to override some plugin mappings, that needs to be done after the specific plugin is loaded and since the load is done async the settings are loaded before and had no effect. I can't find a way to achieve this.
Is there any trigger that I can hook to or any place where I can save a .vim file to accomplish this?
The closer I've been to this is to add some .vim files on a custom/after/plugin folder and add a `Plug '~/.vim/custom`` line at the end of the plugin list.
Thanks!

If a plugin ignores your mappings then it's doing it wrong. But anyway, you could do stuff on VimEnter autocmd which is triggered after plugins are loaded. See :help startup.

The plugins are not really ignoring my mappings, what happens is for instance:
if !exists('g:user_emmet_leader_key')
  let g:user_emmet_leader_key = '<c-y>'
endif

So if my g:user_emmet_leader_key definition is loaded after the emmet plugin loads, it won't use my mapping and it will load the default one.
And, for the other case that bothers me: I want to define a mapping and some plugin defines the same mapping, if I can't load my mapping after the plugin load, it won't override the plugin's one.
I've looked at :help initialization (that seems to be the same) in the past, but I missed the VimEnter thing, thanks for that :)
I've managed to load my configs before the plugins load just by sourcing them before the Plug lines and after the plugin loading using VimEnter which is great since now I don't have the problem anymore, but it feels like a hack more than a fix.
Also, (using vim --startup vim.log) I've found that some *.vim files (within the autoload/ folder) are loaded last... is this a vim thing or a vim-plug thing?
Thanks!

So if my g:user_emmet_leader_key definition is loaded after the emmet plugin loads, it won't use my mapping and it will load the default one.

It's because you have your settings in a separate config file which vim treats as another plugin, so it's loaded after your .vimrc is loaded (:help load-plugins). So in that case you have to manually source them, and there's nothing surprising about it.

I want to define a mapping and some plugin defines the same mapping, if I can't load my mapping after the plugin load, it won't override the plugin's one.

This is what I said about plugins doing it wrong. A well-bahaved plugin does not override existing mapping and/or provides <Plug> mappings for easier customization.

Also, (using vim --startup vim.log) I've found that some *.vim files (within the autoload/ folder) are loaded last... is this a vim thing or a vim-plug thing?

It's a vim thing.

Gotcha! thanks for helping me with this.


Fix issue with Gen-release-notes pulling incorrect Canal (calico) version

This issue has been resolved.


Implement null references metrics

https://github.com/yegor256/cam/issues/10

@rultor merge

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@doritosxxx @yegor256 Oops, I failed. You can see the full log here (spent 8min)
+ java -jar /opt/app/jpeek-0.32.0-jar-with-dependencies.jar --help
Usage: <main class> [options]
  Options:
    --help
      Print usage options
    --include-ctors
      Include constructors into all formulas
      Default: false
    --include-private-methods
      Include private methods into all formulas
      Default: false
    --include-static-methods
      Include static methods into all formulas
      Default: false
    --metrics
      Comma-separated list of metrics to include
      Default: LCOM5,NHD,MMAC,SCOM,CAMC
    --overwrite
      Overwrite the target directory if it exists (otherwise an error is
      raised)
      Default: false
    --quiet
      Turn logging off
      Default: false
  * --sources, -s
      Directory with .class files
  * --target, -t
      Output directory

+ locale
LANG=en_US.UTF-8
LANGUAGE=en_US.UTF-8
LC_CTYPE="en_US.UTF-8"
LC_NUMERIC="en_US.UTF-8"
LC_TIME="en_US.UTF-8"
LC_COLLATE="en_US.UTF-8"
LC_MONETARY="en_US.UTF-8"
LC_MESSAGES="en_US.UTF-8"
LC_PAPER="en_US.UTF-8"
LC_NAME="en_US.UTF-8"
LC_ADDRESS="en_US.UTF-8"
LC_TELEPHONE="en_US.UTF-8"
LC_MEASUREMENT="en_US.UTF-8"
LC_IDENTIFICATION="en_US.UTF-8"
LC_ALL=en_US.UTF-8
++ dirname dataset/temp/env-done.txt
+ mkdir -p dataset/temp
+ date +%s%N
Finished, in 4s
+ make lint

+++ lint +++

\u001b[1m/home/r/repo/metrics/ast.py\u001b[m\u001b[36m:\u001b[m148\u001b[36m:\u001b[m1\u001b[36m:\u001b[m \u001b[1m\u001b[31mE302\u001b[m expected 2 blank lines, found 1
\u001b[1m/home/r/repo/metrics/ast.py\u001b[m\u001b[36m:\u001b[m158\u001b[36m:\u001b[m1\u001b[36m:\u001b[m \u001b[1m\u001b[31mE302\u001b[m expected 2 blank lines, found 1
make: *** [Makefile:85: lint] Error 1
container df6f9299a084984f0922b6c5125030a5d92bffd18c2a056b8fd7e1c167c73711 is dead
Fri Oct 27 11:06:53 AM CEST 2023

@doritosxxx the formatting of your Python code is not pefect. Try make clean lint to see this error on your laptop

@doritosxxx I reimplemented your code in 3ebc461, thanks for your contribution!


FAQ for Ops - What's the default log store duration? How to extend the duration?

Organization Name:
Short summary about the issue/question:We want to keep the logs for a long time. Where do we keep the logs for the system and job? How long is the storage period?
OpenPAI Environment:
OpenPAI version:0.8.2
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Hardware (e.g. core number, memory size, storage size, GPU type etc.):
Others:

@JianfeiHu
Refer to #2244


Added Rui Reis' symbolic execution intro article.

The new link is the following one
https://blog.deniable.org/posts/symbolic-execution/


Make FSx Substack depend on ComputeSecurityGroupIngress to keep FSx f…

I encountered a race condition when running ParallelCluster 2.4.0. The FSx Substack was created prior to the updating of the ComputeSecurityGroup rules to allow access within the security group. This resulted in the error:
The file system cannot be created because the default security group in the subnet provided or the provided security groups do not permit Lustre LNET network traffic on port 988 (Service: AmazonFSx; Status Code: 400; Error Code: InvalidNetworkSettings; Request ID: 00c909db-c895-4734-a9ad-636c7355a6f1)
We can ensure that this does not happen if the FSXSubstack resource depends on the ComputeSecurityGroupIngress resource. This pull request fixes that issue.
Issue #, if available:
N/A
Description of changes:
Add DependsOn Condition of ComputeSecurityGroupIngress to FSXSubstack.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Thanks for the pr @jason-mccloskey !
There's a problem here:
The ComputeSecurityGroupIngress has a condition CreateSecurityGroups:
"ComputeSecurityGroupIngress": {
      "Type": "AWS::EC2::SecurityGroupIngress",
      "Properties": {
        "IpProtocol": "-1",
        "FromPort": 0,
        "ToPort": 65535,
        "SourceSecurityGroupId": {
          "Ref": "ComputeSecurityGroup"
        },
        "GroupId": {
          "Ref": "ComputeSecurityGroup"
        }
      },
      "Condition": "CreateSecurityGroups"  # <---- This
    },

The CreateSecurityGroups is dependent on VPCSecurityGroupId which is a user provided parameter.
"CreateSecurityGroups": {
      "Fn::Equals": [
        {
          "Ref": "VPCSecurityGroupId"
        },
        "NONE"
      ]
    },

So if we merge this patch, users who create FSx filesystems with the VPCSecurityGroupId parameter will be stuck in an infinite loop.
I don't have a good solution for you, but open to ideas.


How to rolling update protoactor cluster gracefully?

The feature Multiple Activations, it will causing states overrided by each actors with the same ID when the cluster nodes growing or shrinking. It seems that could be resolved by IdentityLookup.cs https://github.com/AsynkronIT/protoactor-dotnet/issues/543 .
Any suggestions?
btw: I use protoactor-go. I'm experimenting this at https://github.com/AsynkronIT/protoactor-go/issues/404 .

The issue of multiple activations are more or less gone with the introduction of IdentityLookup, e.g. MongoIdentityLookup.
The backing datasource becomes the source of truth.
It does add some spawning overhead, which is noticable when booting up a system, but due to PID caching, becomes negligible once the system is fully running.
This however needs to be ported over to Go.

Replied on the Go issue tracker.


cert-generator.sh fails with an opaque error if certs are already generated.

In particular, if you run cert-generator.sh on a fresh clone, it will print:
Generating BadSSL Certificate Signing Request

Signing BadSSL Default Certificate
Signature ok
subject=/C=US/ST=California/L=San Francisco/O=BadSSL/CN=*.badssl.com
Getting CA Private Key
Error opening CA Private Key ../self-signed/badssl-intermediate.key
139949868869280:error:02001002:system library:fopen:No such file or directory:bss_file.c:398:fopen('../self-signed/badssl-intermediate.key','r')
139949868869280:error:20074002:BIO routines:FILE_CTRL:system lib:bss_file.c:400:
unable to load CA Private Key

@marumari, would you mind handling this? A simple solution would be to check if self-signed/ contains any certs, and exit an error message.
A nicer solution might be to ask and offer to overwrite the old certs.

Sure, I'll take care of it.  :)
On May 18, 2015 9:27:53 PM Lucas Garron<EMAIL_ADDRESS>wrote:

In particular, if you run cert-generator.sh on a fresh clone, it will print:
Generating BadSSL Certificate Signing Request

Signing BadSSL Default Certificate
Signature ok
subject=/C=US/ST=California/L=San Francisco/O=BadSSL/CN=*.badssl.com
Getting CA Private Key
Error opening CA Private Key ../self-signed/badssl-intermediate.key
139949868869280:error:02001002:system library:fopen:No such file or
directory:bss_file.c:398:fopen('../self-signed/badssl-intermediate.key','r')
139949868869280:error:20074002:BIO routines:FILE_CTRL:system
lib:bss_file.c:400:
unable to load CA Private Key

@marumari, would you mind handling this? A simple solution would be to
check if self-signed/ contains any certs, and exit an error message.
A nicer solution might be to ask and offer to overwrite the old certs.

Reply to this email directly or view it on GitHub:
https://github.com/lgarron/badssl.com/issues/41

FYI, the badssl intermediate should have been checked in the entire time (along with the root key).  I'm going to spend some time doing major cleanup on the cert generator; it was one of those dirty quick shell scripts that I made to get going on development in the first place.  :)

FYI, the badssl intermediate should have been checked in the entire time (along with the root key). I'm going to spend some time doing major cleanup on the cert generator; it was one of those dirty quick shell scripts that I made to get going on development in the first place. :)

:-D
While we're on the topic, a good feature would probably to be able to regenerate everything while keeping the root CA.

Right now it keeps the keys around (root, intermediate, and EE) and generates all the certificates anew every time.  There’s no reason why it couldn’t regenerate the intermediate and EE keys every time, but obviously regenerating the root is a giant pita.
We have two plausible options:

make install (or some hypothetical make roots or make keys) deletes the keys in self-signed: this will cause cert-generator.sh to generate all new keys and certs

have cert-generator.sh prompt upon execution, for example:

“Would you like to regenerate the root for badssl.com?  It is recommended you do this for each new installation, for security purposes.  [Y/N]”
And choosing y or Y will delete the keys in self-signed, causing everything to be regenerated.
Personally, I’m leaning a bit towards the former option.  Not just because it’s less work for me — I run cert-generator.sh constantly — but also because I imagine most users will simply stop at make install, if that’s what README.md tells them to do.
On May 18, 2015, at 10:15 PM, Lucas Garron<EMAIL_ADDRESS>wrote:

FYI, the badssl intermediate should have been checked in the entire time (along with the root key). I'm going to spend some time doing major cleanup on the cert generator; it was one of those dirty quick shell scripts that I made to get going on development in the first place. :)
:-D
While we're on the topic, a good feature would probably to be able to regenerate everything while keeping the root CA.
—
Reply to this email directly or view it on GitHub.

make install (or some hypothetical make roots or make keys) deletes the keys in self-signed: this will cause cert-generator.sh to generate all new keys and certs

Yeah, I think it makes sense to do this without prompting.
If for some crazy reason lots of people need to use this project and regenerate certs without losing the old ones, we can consider storing old ones in a backup folder.
One idea I kind of like would be to throw away the root/intermediate keys after signing certs (even better: only keep it in RAM before doing so), so that no one can sign any more certs. Until name constraints become commonly implemented (i.e. never), this is the best assurance that the test root cert won't be used for domains it wasn't intended for.
My main concern is that this requires updating imported test root certs, which is something I'm wary of automating.

If we add a make keys option, should we simply remove the keys and certs that are there in the repository currently, forcing everybody to generate them on first install?  Then we don't need to worry about throwing away the root/intermediate keys, since they can't sign anything of importance.

Yeah, that actually sounds sensible.
It will make it annoying to test in an environment where you can't run openssl – but if you don't know enough to work around it on another server, then arguably you shouldn't be qualified to run this.

I'm still working on this thing, but it's a surprisingly complicated one.    :)

The commit for this is in, in #55!  Take a look, and if you like the way its handled, I'll close this ticket.


wip enable worker rendering

https://github.com/giantswarm/giantswarm/issues/31699

This PR:

adds/changes/removes etc

Testing
Description on how cluster-cloud-director can be tested.

[ ] fresh install works
[ ] upgrade from previous version works

Other testing
Description of features to additionally test for cluster-cloud-director installations.

[ ] check reconciliation of existing resources after upgrading
[ ] X still works after upgrade
[ ] Y is installed correctly

Checklist

[ ] Update changelog in CHANGELOG.md.
[ ] Make sure values.yaml and values.schema.json are valid.
[ ] Update /examples if required.

Trigger e2e tests

/run cluster-test-suites

/run cluster-test-suites

➜  kg app,machine | grep wealdy
app.application.giantswarm.io/wealdy-test-2                        0.59.0-610f3dbdc5b14f3ee2a0a3c550c632eea8c89e37   33m          33m             deployed
app.application.giantswarm.io/wealdy-test-2-app-operator           6.11.0                                            33m          32m             deployed
app.application.giantswarm.io/wealdy-test-2-chart-operator         3.3.0                                             33m          23m             deployed
machine.cluster.x-k8s.io/wealdy-test-2-gh9rw                wealdy-test-2   wealdy9677    vmware-cloud-director://urn:vcloud:vm:939185ee-c04f-465e-89f9-57922935157d   Running   33m   v1.27.14
machine.cluster.x-k8s.io/wealdy-test-2-worker-rc9t6-fkj4n   wealdy-test-2   wealdy8cab    vmware-cloud-director://urn:vcloud:vm:d96e2c71-e8a7-4cd5-aeb6-440b2952961a   Running   33m   v1.27.14
machine.cluster.x-k8s.io/wealdy-test-2-worker-rc9t6-ldznn   wealdy-test-2   wealdy51bf    vmware-cloud-director://urn:vcloud:vm:8583a991-3b9a-429b-bb22-6ac07eb2af1c   Running   33m   v1.27.14
machine.cluster.x-k8s.io/wealdy-test-2-worker-rc9t6-p5scv   wealdy-test-2   wealdy2fe7    vmware-cloud-director://urn:vcloud:vm:bc029efa-0e66-4894-8bac-c8c8d6c293c9   Running   33m   v1.27.14

Cluster running (without default apps):
➜  KUBECONFIG=kubeconfig kg no
NAME         STATUS   ROLES           AGE   VERSION
wealdy2fe7   Ready    <none>          26m   v1.27.14
wealdy51bf   Ready    <none>          26m   v1.27.14
wealdy8cab   Ready    <none>          26m   v1.27.14
wealdy9677   Ready    control-plane   28m   v1.27.14
➜  KUBECONFIG=kubeconfig kg po -A
NAMESPACE     NAME                                        READY   STATUS    RESTARTS   AGE
giantswarm    chart-operator-6b984b6cc8-bbxmp             1/1     Running   0          28m
kube-system   cilium-7nbfr                                1/1     Running   0          26m
kube-system   cilium-g9mx7                                1/1     Running   0          26m
kube-system   cilium-operator-54f7ccf6ff-qz9z7            1/1     Running   0          27m
kube-system   cilium-operator-54f7ccf6ff-wxx2n            1/1     Running   0          27m
kube-system   cilium-qntjm                                1/1     Running   0          26m
kube-system   cilium-wg78v                                1/1     Running   0          27m
kube-system   coredns-controlplane-57d9d5b964-5mjzf       1/1     Running   0          25m
kube-system   coredns-workers-68c57ff486-dxxgf            1/1     Running   0          24m
kube-system   coredns-workers-68c57ff486-xhfpw            1/1     Running   0          25m
kube-system   csi-vcd-controllerplugin-0                  3/3     Running   0          25m
kube-system   csi-vcd-nodeplugin-2vxs2                    2/2     Running   0          24m
kube-system   csi-vcd-nodeplugin-cxpgm                    2/2     Running   0          24m
kube-system   csi-vcd-nodeplugin-ldcn9                    2/2     Running   0          24m
kube-system   etcd-wealdy9677                             1/1     Running   0          28m
kube-system   hubble-relay-57c47f8c78-glfgd               1/1     Running   0          27m
kube-system   hubble-ui-7488cd6d9b-l695p                  2/2     Running   0          27m
kube-system   kube-apiserver-wealdy9677                   1/1     Running   0          28m
kube-system   kube-controller-manager-wealdy9677          1/1     Running   0          28m
kube-system   kube-scheduler-wealdy9677                   1/1     Running   0          28m
kube-system   vmware-cloud-director-ccm-d7ff6b8db-r6nrw   1/1     Running   0          25m

last thought - we can't test this with cluster-test-suites because the proxy configuration needs to be added to the values (gerbil is behind a proxy)


METRON-1364: Add an implementation of Robust PCA outlier detection

Contributor Comments
With short circuiting in Stellar, we have the opportunity to delve into more computationally intensive outlier detection techniques. Generally these would be executed only if simpler outlier detection techniques indicated an outlier (e.g. statistical outlier tests).
As the first one of these supported, I'd suggest a Robust PCA based technique similar to Netflix's Surus. See https://medium.com/netflix-techblog/rad-outlier-detection-on-big-data-d6b0494371cc and https://metamarkets.com/2012/algorithmic-trendspotting-the-meaning-of-interesting/ for more detail.
It should be noted that there are some caveats with this approach around sparsity and orderedness.
Regarding sparsity,this outlier detection algorithm presumes dense output, which is not the case for data spanning profiles (e.g. the profiler does not write out data every period if no data was seen). To deal with this, I am suggesting a modification to the profiler to allow PROFILE_GET to return a default value. That will be done in a separate JIRA (see #871)
Regarding well-orderedness, this is an outlier detector for time series data, so it is sensitive to order to a certain extent. Given its computational intensity, it is likely to be used with a sample of the data to shrink the size of the data. To that end, uniform sampling is not sensible here, but rather a biased sample for recency. Without this, you may get poor results from this outlier detector. This sampler should be done in a separate JIRA, but I will ensure the infrastructure to add it is contributed in METRON-1350 (see #867).
Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:

[x] Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
[x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

[x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?

[ ] Have you included steps or a guide to how the change may be verified and tested manually?

[x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
mvn -q clean integration-test install && build_utils/verify_licenses.sh

[x] Have you written or updated unit tests and or integration tests to verify your changes?

[x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

[ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

[x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:
cd site-book
mvn site

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

How can we test this?

Yep, I owe a manual testing plan.  It's going to essentially be the same instructions as we have for MAD.  I'll also be adding a new use-case as a follow-on that tracks outliers in entropy for netflow data.

Is this still alive?

it's still alive..sorry, I still owe a test plan and a deconflict. This one is more of a labor of love and I was worried that it may be a bit premature and wanted to validate with a real cybersecurity use-case.

I'll test this when it is ready, but if you have other  reviews  keeping you from this, i can wait ;)

as Tribe Called Quest said:  "So what's the scenario"?

Happy to put some effort into running through this/testing if it's ready to go @cestella

Thanks @JonZeolla I am planning to try to get around to cleaning this up a bit this week.  I have some concerns about its interactions with the sampling stellar functions.

Any updates on this PR?

@cestella


Call the callback when the fetch rejects

This ensures that the callback is executed if the fetch is cancelled by the browser. When this happens, the fetch returns a rejected Promise, which should be handled by the callback.

@deleteme Sorry, completely missed this PR ><;;
Seems similar to #21 though, right?

Yes, it is similar. While the implementation in #21 will work, it is inaccurate because the new catch applies to much more than just the rejection of the initial fetch call.

I see, you're right! Want to rebase/review this PR?

Replaced by #22


Merge remote-tracking branch 'refs/remotes/origin/master' into DeadSi…

…x27/master

Misclick? Also, wait a bit before you PR, I will merge in the other guys PR later.. I just didn't get to do that yet.


Index on "Users" section

I am only having issues on the index for the Users section, it is quite strange and I can't find the source of the issue.
Error:
uninitialized constant ActiveRecord::Base::User

render renderer_for(:index)

Below is my admin_user.rb
ActiveAdmin.register AdminUser, :as => "User" do

end

try
ActiveAdmin.register AdminUser, {:as => 'User'} do
end


♻ Refactor Grafana tenant configuration

Our configuration code currently creates all CloudWatch sources as one entity, and then tenant RBAC after, mapping teams to sources.
We should look at moving from source and RBAC being split, to all tenant configuration being contained in one entity.

https://github.com/ministryofjustice/modernisation-platform-environments/pull/4651 was merged which resolves this


Correct default of nestedScrollEnabled

This defaults to false, see https://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollViewManager.java#L188

@javache  I believe we need to backport this down the line to all the versions

@javache I believe we need to backport this down the line to all the versions

Yeah, we should. What's the best way to do that? Send this same PR but target older branches?


proof of concept: rt.live data as signal

proof of concept using the rt.live data as an additional signal:

We've decided as a group that adding a R(t) signal, and/or integrating with rt.live isn't on our roadmap, so let's close this experiment.


Related Content Suggestions

Describe the bug 描述你遇到的错误
Related Content Suggestions at the bottom of a post not working properly
Screenshots 屏幕截图

The behaviour is expected, the post "Related tests" does not have a featured image so no image will show up.

I got this in that case I need to use a default image for every blog post and later change that.


alternative autopilot method

My method consists of few steps:
first: Fly straight up
second: Then when you reach enough altitude you just fly forward
100 blocks up is about 1km forward with right angle, i use -1.1 or -0.9 but i don't think that this is ideal angle

Not really efficient either way, at least not as much as Simon's original design. Anyways, having different autopilots could be pretty nice to optimize for time/fireworks/durability.


Dependencies upgrade and module template sync

Description
This PR aims to update the design token package, which was originally generated from the metamask-module-template. Over time, the package has become outdated and incompatible with mobile and portfolio due to dependency issues, particularly with node versions. This PR addresses these issues by updating the dependencies and aligning the package with the most recent module template using the template sync package.
The upgrade to yarn version 3 also necessitated changes to the GitHub workflow files, which were updated to align with the module template. This alignment should enhance the automation of our releases. Due to the upgraded node and yarn versions, this PR includes numerous other dependency updates, file changes, lint fixes, and the inclusion of config files.
Fixes: #597
Manual Testing Steps
Because mobile and portfolio are using yarn v1 and the design tokens is using v3. It's quite hard to test using yarn link. But if you pull this branch and try to use yarn link on a project that use yarn 3 it will work like the module template.

Clone the https://github.com/MetaMask/metamask-module-template
Pull this branch
Run yarn && yarn build
Back in metamask-module-template
Run yarn link ../path/to/design-tokens
Make sure the design tokens package is in the node_modules folder
import brandColor in to the index.ts file

Other smoke tests

Check GitHub workflows are working as expected
Check storybook works yarn storybook

Screencasts/Screenshots
Screencast below shows yarn link version of the design-tokens to the module-template as a test to ensure that the brandColor object in the v1.13 release is importing and working as intended
https://github.com/MetaMask/design-tokens/assets/8112138/5e5f52c4-3be1-462a-8c02-bbe5f4b5912d

Socket dev security issues should be mitigated by lavamoat as they are all supply chain issues


Prevent nodemon from executing on first run

Currently nodemon will execute the -x commands when it is first ran. This is undesirable in some cases, and I'd like to propose a new flag to prevent this, perhaps --no-first-run. Thoughts?

What does that flag do, didn't see it in nodemon docs after a search? Feel free to make a PR.

Sorry, this is so embarrassing, I raised this issue on the wrong repo!!


crawl other GCP services - cloud run

Hi, are there any other GCP services you want to crawl? Like Cloud Run for example? Is there any mandatoray checks I need to do before including?
Couldn't find any roadmap or something so I would just start with that.

Hi, you can take a look at other already merged PRs to understand what's needed for that. Look at #111 or #40 for examples.

Hi, thanks for the answer. It's not about the understanding but more of the need. I though there is a roadmap or something.
Cheers


Predator Arm has a dismembered wrist and hand in Gazebo 11

Although the Predator Arm works fine in Gazebo 9, not so in Gazebo 11. See the image below and note that the wrist is floating above the arm and the hand is lying on the floor in the back of the UUV:

Initial scan of the error messages suggests that this may be due to a name collision that Gazebo 9 forgives but Gazebo 11 gets mad about:
Warning [Model.cc:212] Non-unique names detected in XML children of model with name[rexrov].
Error [Model.cc:311] Joint with name [predator/wrist] in model with name [rexrov] has a name collision. Please rename this joint.
[Err] [Model.cc:123] Error Code 25 Msg: relative_to name[predator/wrist] is identical to joint name[predator/wrist], causing a graph cycle in model with name[rexrov].
[Err] [Model.cc:123] Error Code 26 Msg: PoseRelativeToGraph error, too many incoming edges at a vertex with name [predator/wrist].

Ah, looks like the errors came from FrameSemantics.cc and were added to sdf9 a while ago in
https://osrf-migration.github.io/sdformat-gh-pages/#!/osrf/sdformat/pull-requests/614/page/1
and https://osrf-migration.github.io/sdformat-gh-pages/#!/osrf/sdformat/pull-requests/613/page/1
So it looks like a matter of migration to sdf9 on 20.04. Probably renaming the joint would be sufficient.


Merge upstream

Codecov Report

Merging #74 into v2-master will decrease coverage by 0.04%.
The diff coverage is 89.02%.

@@              Coverage Diff              @@
##           v2-master      #74      +/-   ##
=============================================
- Coverage      71.96%   71.91%   -0.05%
=============================================
  Files            683      683
  Lines          29462    29458       -4
  Branches        6759     6757       -2
=============================================
- Hits           21201    21186      -15
- Misses          8261     8272      +11


Make build script compatible with Windows

rm is not compatible run with Windows.
I didn't commit the .yarn folder, I think should add to .gitignore and setup after clone.

Looks like it would work on Windows if you used Git bash.

Thank you @vpckso! This repository uses yarn zero-install, so committing the .yarn folder is intentional. I'll go ahead and commit that.


The result is abnormal.

Thanks for your code first.
I used the dataset "fr1/xyz" from Computer Vision Grouphttp://vision.in.tum.de/data/datasets/rgbd-dataset/download to test your code, and used the result "slow.poses", depth images and rgb images to make the point cloud as the image "pointcloud_icp.png". I also used the ground truth to make the point cloud as the image "pointcloud_groundtruth.png". The image "1.png" shows the actual scene.
Why the  point cloud result of ICP is abnormal?

The images order is "1.png", "pointcloud_groundtruth.png", "pointcloud_icp.png".

Looks like you're chaining/using the transformations in the wrong way.

Is each transformation got between the last image and next image?

No, each is in the global coordinate frame.


strange name for program in usage when installing package with command line interfaces using pip

on windows at least, the usage will show the script that pip places in the system directory instead of the raw command name. this may be a result of the way that pip works on windows, but I don't know what to do about it.
so the usage will be Usage: gooch_maf_tools-script.py [OPTIONS] COMMAND [ARGS]...
instead of Usage: gooch_maf_tools [OPTIONS] COMMAND [ARGS]...
and I can't tell if there is any way to override the name of the program in usage for click.

Looking at the code, there doesn't seem to be a way to override the name of the program. Would it be possible to add this option somehow? As right now click is reporting the wrong thing as my program name due to how we run our python code, and it would be nice if I could just provide my custom program name.

Fixed by #1609, but also you've always been able to pass in prog_name when entering a CLI to set the name explicitly.


M3-5881: Add Any/All Option on StackScripts Landing

Description 📝

If an image has any/all as a compatible image, display Any/All as the only Compatible Images in a normal font

Preview 📷

How to test 🧪

Create a Stackscript with any/all as the compatible images in dev
View it from StackScripts landing (http://localhost:3000/stackscripts/account)

curl -X POST \
  -H "Authorization: Bearer [token]" \
  -H "Content-Type: application/json" \
  -d '{ "images": ["any/all"], "label": "test", "script": "#!/bin/bash" }' \
  https://[dev api domain]/v4/linode/stackscripts | json_pp

@HanaXu it is intentional according to the mockups. I'll ask the team what they think


add clean up method for closing rabbitmq connection

fixed eiffel-remrem-publish/issues/23

Coverage decreased (-2.5%) to 26.761% when pulling b4c2b001ce98e2d6267bca4b18eadda32c0c7f1c on closeConn into e02b0e70f914b87c0828668f19f55f7c5b9c0e3e on master.


Disable Sync button

What is this PR for?
Disable Sync button since this dashboard is already HA configurable.
This PR includes

Disable button

What type of PR is it?
Feature
What is the issue?
N/A
How should this be tested?
N/A

Codecov Report

Merging #91 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #91   +/-   ##
=======================================
  Coverage   83.69%   83.69%
=======================================
  Files          42       42
  Lines        2098     2098
=======================================
  Hits         1756     1756
  Misses        342      342

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa4f7e5...f6abfd9. Read the comment docs.

@yuki-mt Thank you for your review.
I am thinking this behavior. At the moment, the current Sync process is too slow.


Add support video/@poster to relativize_paths

Detailed description
Add the selector video/@poster to SELECTORS of :relativize_paths filter in order to relativize the path in poster attribute of video tag.
Example of generated HTML
Before:
<video poster="/assets/example.png">
  <source src="../assets/example.mp4" type="video/mp4">
</video>

After:
<video poster="../assets/example.png">
  <source src="../assets/example.mp4" type="video/mp4">
</video>

References

<video>: The Video Embed element - HTML: HyperText Markup Language | MDN

This looks great, thank you! I’ll add a spec to it, and merge it soon.

I merged this into main: 4b4deaf4b035ab3b71b53d49b3cb4749de2d4de0. The test is in a separate commit: f1d85775e1e7c6d8115b23ae5256ef2ab1110106. Thank you again!

And is now released in Nanoc 4.12.2: https://nanoc.app/release-notes/


update dependabot config

This changes update frequency to monthly- will kelp keep things a bit quieter and the git history tidier.
Adds GitHub Actions updates.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Pull requests should be thought of as a conversation. There will be some back and forth when trying to get code merged into this or any other project. With all but the simplest changes you can and should expect that the maintainers of the project will request changes to your code. Please be aware of that and check in after you open your PR in order to get your code merged in cleanly.
Thanks!

Some of the GitHub Actions are on old versions… with this PR merged it will mean that dependabot will make PRs to update them to latest versions. You’ll see in a minute when this is approved… :-)

Cool! Good to know, thanks @coliff


Improved errors using type reference targets

Fixes #24776
This pull request should improve error messages when assigning type references to union types when a target type contains a type reference whose target type matches the source's.
As an example,
interface A<T> {
    aProp: T;
}

interface B<T> {
    bProp: T;
}

interface C<T> {
    cProp: T;
}

declare const a: A<Foo>;
declare let thing: A<Bar> | B<Baz> | C<Kwah>;

thing = a;

Previously we would report
Type 'A<Foo>' is not assignable to type 'A<Bar> | B<Baz>'.
  Type 'A<Foo>' is not assignable to type 'B<Baz>'.
    Property 'bProp' is missing in type 'A<Foo>'.

Notice that we try to use B<Baz> to explain the incompatibility. Intuitively, we'd assume that A<Bar> is probably what the user wanted to assign to.
With this change, we report a more relevant error:
Type 'A<Foo>' is not assignable to type 'A<Bar> | B<Baz>'.
  Type 'A<Foo>' is not assignable to type 'A<Bar>'.
    Property 'bar' is missing in type 'Foo'.

Currently I'm trying to get this to also work for anonymous types which have a well-associated alias type, however, I might need help there (@weswigham @sandersn).
As future work, we can

use inheritance chains of each type's target, since there may be cases when users relate a Derived to a Base<Foo>
make this work when the source is an intersection types as well
make this work on other type operators

It's odd that only one baseline changed besides the new test, and the change is not an improvement (although not much of a regression since it was quite confusing already).

It's just selecting the first type instead of the last, since both are references to the tuple type.

Oops, what I really meant to say was that it's odd that only one baseline changed. And also the one change isn't an improvement, which isn't odd because it's hard to change things without breaking something. Together, the two things make me wonder whether any more changes exist so that we can know whether they are improvements or not.

I agree; I was pretty disappointed to see the lack of improvement in the existing test suite. Maybe we'll see improvements in the RWC errors though.


Introduce the "comparable" relation

This pull request introduces a new relationship to check whether or not two types are "comparable to" one another. Specifically, it addresses the issues found in #5300 with union types and certain operations.
The new relationship generally subsumes the uses for assignability where we would check whether or not two types were assignable to or assignable from one another. These uses were in checking for compatibility between

the types of the left and right sides of equality/inequality operators (===, !==, ==, !=).
the types of case clause expressions and their respective switch expressions.
the type of an expression in a type assertion with the type being asserted.

Like with other type relations, the comparable relation takes a source and a target. It is the most lenient relation, so types that are assignable are always comparable, but the reverse is not necessarily true. The comparable relation differs from the assignability relation in that if the source is a union type, the relation succeeds provided that each of its constituents are comparable to the target.

@DanielRosenwasser can we close this.

I'm planning to merge this in for the tests as a heads up.


django-stubs helps for typing checks

Thanks for the suggestion! Let's do this :) Shall I make some setup in setup.cfg?

Or please go ahead if you prefer

thanks! merging it


Hot restart remains stuck in Flutter Web stable channel

After any change, hot restart remains stuck in Flutter Web(stable channel) and it's only getting fixed if I refresh from the browser after hot restart.
But when I switched to master channel it's working fine. I hope it's a bug in the stable channel which will be fixed very soon. For now, I am developing in the master channel.
Expected results:
Performing hot restart...
Waiting for connection from debug service on Chrome...
Restarted application in 18,144ms.

Actual results:
Performing hot restart...
Waiting for connection from debug service on Chrome...

Logs

[√] Flutter (Channel stable, 2.0.4, on Microsoft Windows [Version 10.0.19041.867], locale en-IN)
    • Flutter version 2.0.4 at E:\Flutter Development\src\flutter
    • Framework revision b1395592de (9 days ago), 2021-04-01 14:25:01 -0700
    • Engine revision 2dce47073a
    • Dart version 2.12.2

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at E:\Android App Development\Android_SDK
    • Platform android-30, build-tools 30.0.3
    • Java binary at: E:\Android App Development\Android\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Android Studio (version 4.1.0)
    • Android Studio at E:\Android App Development\Android
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] IntelliJ IDEA Community Edition (version 2019.1)
    • IntelliJ at E:\IntelliJ IDEA Community Edition 2019.1
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart

[√] Connected device (2 available)
    • Chrome (web) • chrome • web-javascript • Google Chrome 89.0.4389.90
    • Edge (web)   • edge   • web-javascript • Microsoft Edge 89.0.774.75

• No issues found!

@DevyankShaw
Can you provide a complete minimal reproducible code sample that we can use to replicate this locally ?

A similar issue https://github.com/flutter/flutter/issues/78570 that we weren't able to replicate.

class HomeScreen extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Center(
      child: Text('Home'),
    );
  }
}

Just simply changing the text is not updating after hot restart in Flutter Web stable

@DevyankShaw
Tried your code sample using latest stable on web (flutter run -d chrome), but was able to hot restart everytime I made changes, as below:
https://user-images.githubusercontent.com/67046386/114508241-c2d5af00-9c51-11eb-84d1-cbc1e0323915.mov

flutter doctor -v
[✓] Flutter (Channel stable, 2.0.4, on Mac OS X 10.15.4 19E2269 darwin-x64,
    locale en-GB)
    • Flutter version 2.0.4 at /Users/dhs/documents/fluttersdk/flutter
    • Framework revision b1395592de (7 days ago), 2021-04-01 14:25:01 -0700
    • Engine revision 2dce47073a
    • Dart version 2.12.2

[!] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    ! CocoaPods 1.9.3 out of date (1.10.0 is recommended).
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin
        code that responds to your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To upgrade see
      https://guides.cocoapods.org/using/getting-started.html#installation for
      instructions.

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.55.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.20.0

[✓] Connected device (3 available)
    • SM A260G (mobile)            • 5200763ebcfa861f • android-arm    • Android
      8.1.0 (API 27)
    • Darshan's iphone (mobile) • 21150b119064aecc249dfcfe05e259197461ce23 • ios
      • iOS 14.4.1
    • macOS (desktop)           • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)              • chrome                                   •
      web-javascript • Google Chrome 89.0.4389.114

! Doctor found issues in 1 category.

Actually, i usually run and test flutter apps using the play button in android studio by selecting the appropriate device. But I have checked using latest stable on web (flutter run -d chrome), it's not working. You can check the below snapshot after i made the changes until and unless i explicitly press the refresh button hot restart is not working.
https://user-images.githubusercontent.com/47057254/114737188-62836200-9d64-11eb-9d7f-55a7085b03d1.mp4

flutter doctor -v

[√] Flutter (Channel stable, 2.0.4, on Microsoft Windows [Version 10.0.19041.867], locale en-IN)
• Flutter version 2.0.4 at E:\Flutter Development\src\flutter
• Framework revision b1395592de (13 days ago), 2021-04-01 14:25:01 -0700
• Engine revision 2dce47073a
• Dart version 2.12.2
[√] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
• Android SDK at E:\Android App Development\Android_SDK
• Platform android-30, build-tools 30.0.3
• Java binary at: E:\Android App Development\Android\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
• All Android licenses accepted.
[√] Chrome - develop for the web
• Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe
[√] Android Studio (version 4.1.0)
• Android Studio at E:\Android App Development\Android
• Flutter plugin can be installed from:
https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
[√] IntelliJ IDEA Community Edition (version 2019.1)
• IntelliJ at E:\IntelliJ IDEA Community Edition 2019.1
• Flutter plugin can be installed from:
https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
https://plugins.jetbrains.com/plugin/6351-dart
[√] Connected device (2 available)
• Chrome (web) • chrome • web-javascript • Google Chrome 89.0.4389.128
• Edge (web)   • edge   • web-javascript • Microsoft Edge 89.0.774.75
• No issues found!

@DevyankShaw
So if I understand the issue correctly, instead of directly using flutter run -d chrome from IDE terminal, you are selecting chrome from device list and then clicking on play button to run the app. After that, how are you trying to hot restart ? because if you running not from terminal, then you don't get the options to use r to hot restart.

@darshankawar
While using the play button to run the app, I use Ctrl+S for hot restart

@DevyankShaw
It seem to be specific to Windows, because on Mac, hot restart shortcut is command + \, which hot restarts and updates the screen properly.

I'll try to replicate this on Windows 10 too to confirm.

@darshankawar Yes let me know.

Verified this on Windows 10 and was able to replicate this issue.

Steps to replicate:

Select chrome from device list and hit Run button.
Make changes to the file and use CTRL + S to hot restart which remains stuck and doesn't update the UI.

class HomeScreen extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Center(
      child: Text('Home'),
    );
  }
}

This issue is now resolved in Flutter 2.2, so I am closing this issue


chore: Update setup.py version

Summary of Changes
Updating version again because I made a mistake with the release Tag.
Tests
N/A
Documentation
N/A
CheckList
Make sure you have checked all steps below to ensure a timely review.

[ ] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[ ] PR includes a summary of changes.
[ ] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[ ] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain docstrings that explain what it does

[ ] PR passes make test

need to rebase


Empty :c

Hey,
Was happy to found this repo on Google.... until i saw it's empty! :c
Still thinking about it or no?
Bye

Sorry, don't had much time when I started this project, now I'm back, maybe now I can dedicate some time to the smb and ssh projects.


Update plugin.js

This removes a deprecation warning for webpack 3+ as detailed in #251

Shipped in 3.7.2


Adding in Compositional Data analysis methods

Composition Data analysis is an alternative technique to analyzing compositional data (aka data involving percentages and proportions).
Most of the OTU data that we are dealing with are inherently compositional, and applying some of these techniques would really ease analysis/interpretation of this sort of data.
As far as I can tell, these techniques have not been implemented anywhere in the Python world.
I've started drafting some of these methods here.
  Perhaps once the Contingency Table has been added, I can start porting over some of these methods.

What are the differences between compositional biplots and plain biplots (ie plotting samples as dots and continuous variables as arrows?
The ordination methods used to have (very barebones) 2D biplots and triplots (when plotting samples and sites as dots, plus variables as arrows) through matplotlib, though they ended up removed and we just added a simple scatter plot later.
I agree that recovering (but mainly improving) bi/triplots would be fantastic, and ternary plots look cool.
:+1:

Technically they are exactly the same.
The main difference is that the biplots that I'm proposing have a particular log transformation (called centre log transformation) applied to the OTU percent abundance data.   A standard SVD can be applied to this data to obtain PC coordinates, however, a more correct SVD for compositional data for potentially more accurate results.

I see, thanks! So they'd be useful for contingency table that have relative abundances, and you'd take the element wise logarithm of the table, and then center it. Is there a standard way to deal with null abundances?

Exactly!
So zeros are still a problem with this area - there are a couple of common ways about it.

Multiplicative replacement.
This is a very common approach.  Not only it is simple, but it doesn't seriously distort the non-zero data.
EM
This approach has shown to have less bias - but its a bit more computationally expensive.

I already have the first one coded up.  It may not be a bad idea to also include the second approach.

Thanks for the references, I agree it would be great to have these in skbio!
A correct implementation of EM could be sped up using cython later on, so that's not a big issue. Let me know if I can be of any help! I implemented our ordination methods, though I haven't used them that much, and most had not been implemented in Python or under permissive licenses, so we can end up with a very nice and comprehensive set of tools to analyze this kind of data.

:+1:

@mortonjt, note that I just followed up on the plotting issue on #685.

Perhaps this isn't dependent on the Contingency Table.
If so, I'll be submitting a PR for this really soon.  I'll probably add a new file called skbio.stats.composition
It'll contain the following functionality

closure(mat)
zero_replacement(mat)
perturb(x, y)
perturb_inv(x, y)
power(x, y)
clr(mat)
centre(mat)

These are all of the functions required to create a biplot.
@Jorge-C , @ElDeveloper @antgonza . Would you be willing to review this PR?  Do you think i should split it up?

Yes, I'll have a look!
On (Feb-22-15| 8:14), mortonjt wrote:

Perhaps this isn't dependent on the Contingency Table.
If so, I'll be submitting a PR for this really soon.  I'll probably add a new file called skbio.stats.composition
It'll contain the following functionality

closure(mat)
zero_replacement(mat)
perturb(x, y)
perturb_inv(x, y)
power(x, y)
clr(mat)
centre(mat)

These are all of the functions required to create a biplot.
@Jorge-C , @ElDeveloper @antgonza . Would you be willing to review this PR?  Do you think i should split it up?

Reply to this email directly or view it on GitHub:
https://github.com/biocore/scikit-bio/issues/835#issuecomment-75442715

Thanks!

@mortonjt can this be closed now that #860 is merged?

I'd like to make 1 more PR with the following functionality
clr_inv - inverse clr transform
ilr - isometric log ratio transform
ilr_inv - inverse isometric log ratio transform
inner - Aitchison inner product (tests for orthogonality and is required in ilr)
This PR will be significantly smaller.  But once that's merged, then yes, I think this issue can be closed.

Sounds good, thanks for the details!

Hey,
How are you getting on with this? I actually implemented all these functions myself last week and am happy to look over you prototype / discuss. The prototype is not accessible to me at the moment though.

Hi @jsevo .  Glad that you are interested!
All of the core methods have been implemented as of #860 and #892 - the functions can be found here.
Let me know if you have any trouble using these functions.  Also if you have code for visualizing compositional biplots or ternary plots, I'll be happy to review it.

@mortonjt can this issue be closed now that #892 is merged?

:+1: on closing it
On Tue, Feb 23, 2016 at 11:47 AM, Jai Ram Rideout<EMAIL_ADDRESS>wrote:

@mortonjt https://github.com/mortonjt can this issue be closed now that
#892 https://github.com/biocore/scikit-bio/pull/892 is merged?
—
Reply to this email directly or view it on GitHub
https://github.com/biocore/scikit-bio/issues/835#issuecomment-187871953.

:+1: on closing it


fix: correct regex for Key Vault

as per:
https://github.com/Azure/terraform-azurerm-naming/blob/8a1c8616d4cd05423e53c3260a016919ce0df33d/resourceDefinition.json#L1053C15-L1053C69
& https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/resource-name-rules

just noticed that tf validate doesn't support this regex syntax.. will fix


Mini product card

Description
Added Mini Product Resources card, added video in the Hero Block, modified the design in accordion

Oh I think the e2e is failing due to something else. Merging!


Barcode alignment

Is it possible to align barcode to center ?

I've just added this feature :)
Now images and barcodes are centered by default, but you can also pass the align parameter for left/right alignment.
BTW, the PosTextAlign enum renamed to PosAlign. You have to rename it in your code if you are using it somewhere.
I hope it helps!
I'm going to close this issue, but feel free to reopen it if you have any further questions or ideas!


Firefox m.parseProxyUrl(...) is null

Are you requesting a feature or reporting a bug?
Bug
What is the current behavior?
Get error in firefox
✖ Should have search results for "SBB"

   1) Error on page "https://openwt.com":

      TypeError: m.parseProxyUrl(...) is null

      Browser: Firefox 59.0.0 / Mac OS X 10.13.0

         40 |
         41 |  const searchIcon = owtHomePageModel.searchIcon;
         42 |  const searchInput = owtHomePageModel.searchInput;
         43 |
         44 |  await t
       > 45 |    .click(searchIcon)
         46 |    .typeText(searchInput, 'SBB')
         47 |    .pressKey('enter');
         48 |
         49 |  const searchResultsFirstTitle = owtHomePageModel.searchResultItems.find('.title').nth(0);
         50 |

What is the expected behavior?
No error...
Btw. it runs successful in chrome, safari...
How would you reproduce the current behavior (if this is a bug)?
Run the code below ;)
Provide the test code and the tested page URL (if applicable)
Tested page URL:
process.env.HOST=https://openwt.com
Test code
import { Selector } from 'testcafe';

export default class OwtHomePageModel {
    constructor(
        public aiBanner = Selector('#block-artificialintelligencebanner').find('.title1'),
        public services = Selector('#block-services').find('.service'),
        public searchIcon = Selector('.search-container').find('.fa-search'),
        public searchInput = Selector('.search-container').find('#edit-search-block-form'),
        public searchResultItems = Selector('.search-results').find('.search-result'),
    ) { }
}

const owtHomePageModel = new OwtHomePageModel();

fixture`OWT homepage`
  .page(process.env.HOST);

test.only('Should have search results for "SBB"', async (t) => {

  const firstSearchEntry = 'Empowering the Digitalization of the Gotthard Base Tunnel with Augmented Reality';

  const searchIcon = owtHomePageModel.searchIcon;
  const searchInput = owtHomePageModel.searchInput;

  await t
    .click(searchIcon)
    .typeText(searchInput, 'SBB')
    .pressKey('enter');

  const searchResultsFirstTitle = owtHomePageModel.searchResultItems.find('.title').nth(0);

  await t
    .expect(searchResultsFirstTitle.innerText).contains(firstSearchEntry);
});

Specify your

operating system: OSX
testcafe version: 0.19.1
node.js version: 8.10.0
Firefox: 59.0.2

The fix is published in<EMAIL_ADDRESS>

@LavrovArtem when will version 0.20.0 be released?

@dweber019 I guess it can take one or two weeks

I still have the issue and i am using version 0.20.2.

Hi @SayedShahidi
I cannot reproduce the issue because site markup was changed and test from description now failed.
Could you please provide a simple example to reproduce?


Use pin to create a standalone application instead of pyqt

我想使用pywebio做一个exe程序，作为pyqt的简单替代，我打算使用pin，但是pin是非阻塞的，在程序运行1秒后，它会显示 与服务器连接已断开，请刷新页面重新操作,我该怎么做
I want to use pywebio to make an exe program. As a simple alternative to pyqt, I plan to use pin, but pin is non-blocking. After the program runs for 1 second, it will show that the connection with the server has been disconnected. Please refresh the page and re-operate，What shall I do?

Use pywebio.session.hold() to prevent the application from exiting in script mode.
see doc: https://pywebio.readthedocs.io/en/latest/session.html#pywebio.session.hold


fix(driver): io_uring_params features attribute

What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area driver-kmod

What this PR does / why we need it:
Fix driver build for kernel versions with old io_uring_params struct, lacking features attribute.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

fix(driver): io_uring_params features attribute

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: deepskyblue86
To complete the pull request process, please assign fntlnz after the PR has been reviewed.
You can assign the PR to them by writing /assign @fntlnz in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @deepskyblue86. Thanks for your PR.
I'm waiting for a falcosecurity member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

LGTM label has been added.  Git tree hash: 7eed32e3ad0e765f542f5adee009704c6e15fe79

@deepskyblue86: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

build-libs-arm
a59cfd0cbbd08f7b7b327cb366c165c322325862
link
true
/test build-libs-arm

Full PR test history. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deepskyblue86: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

build-libs-arm
a59cfd0cbbd08f7b7b327cb366c165c322325862
link
true
/test build-libs-arm

build-libs
a59cfd0cbbd08f7b7b327cb366c165c322325862
link
true
/test build-libs

Full PR test history. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deepskyblue86: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

build-libs-arm
a59cfd0cbbd08f7b7b327cb366c165c322325862
link
true
/test build-libs-arm

build-libs
a59cfd0cbbd08f7b7b327cb366c165c322325862
link
true
/test build-libs

build-libs-minimal
a59cfd0cbbd08f7b7b327cb366c165c322325862
link
true
/test build-libs-minimal

Full PR test history. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

New changes are detected. LGTM label has been removed.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: deepskyblue86
To complete the pull request process, please ask for approval from gnosek after the PR has been reviewed.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/test build-libs

@deepskyblue86: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test build-libs

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: deepskyblue86, gnosek
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [gnosek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: deepskyblue86, FedeDP, gnosek
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP,gnosek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: a4d8485c23e947e30172ee8f4e57ddfa117b8665

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, deepskyblue86, FedeDP, gnosek
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP,gnosek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment