Export fix for iOS

The export of file in iOS does not work directly from base64 due to the encoding performed by sharing application in order to add a file as an attachment.
This PR solves it in the following way -

Write file on the disk first
Share through the url of this file
Remove the file as soon as it is shared.

Tested on both Android and iOS


Behavior of pull-request message editor inconsistent with git commit message editor

I use vim for my commit messages and for pull-requests through hub. When editing my commit message, if I realize I've made a mistake and I don't want to commit, and I exit without writing, the commit is aborted. If I do the same thing with hub while creating a pull request, the pull request is created anyways. It seems like the behavior should be consistent with git.
I know that I can delete the pull request message and save instead to abort the pull request, but it is still confusing that it does not work the same way - and it's also extra steps.

@mislav I somehow missed all of these notifications unfortunately :( I was using :q! to quit vim when I wanted to abort the pull-request. Thanks for looking into it, sorry for not following up. I'll use :cq in the future.


Support for Slack Webhook URL's

This works neat but i would suggest you to provide an option for SLACK's Webhook URL's as well to reach wider base of server managers.

Tested and its woking well. Thanks.


LiquidCore base on what v8 version

1、I want to know what version of LiquidCore's current v8 is.
2、whether LiquidCore's support ES6?
3、whether LiquidCore's support TypeScript?

1、I want to know what version of LiquidCore's current v8 is.

On Android:
> process.versions
{
  http_parser: '2.7.0',
  node: '8.9.3',
  v8: '6.1.534.48',
  uv: '1.15.0',
  zlib: '1.2.11',
  ares: '1.10.1-DEV',
  modules: '57',
  nghttp2: '1.25.0',
  openssl: '1.0.2n',
  liquidcore: '0.6.0'
}

On iOS, it is not running V8 at all, but JavaScriptCore:
> process.versions
{
  http_parser: '2.7.0',
  node: '8.9.3',
  uv: '1.15.0',
  zlib: '1.2.11',
  ares: '1.10.1-DEV',
  modules: '57',
  nghttp2: '1.25.0',
  openssl: '1.0.2o',
  jsc: '86<IP_ADDRESS>.1',
  liquidcore: '0.6.0'
}

2、whether LiquidCore's support ES6?

Yes.

3、whether LiquidCore's support TypeScript?

V8 does not directly support TypeScript, but like with anything it can be transpiled to regular javascript.

thanks

i have a need，Android call JS`s function，Pass the JsonObject to JS

Android

 val obj = JsonObject()
 obj.addProperty("lat", 12.13213231231)
 obj.addProperty("lng",<PHONE_NUMBER>1231)
 mJsContext.evaluateScript("changeWayPoint").toFunction().call( null,  obj)

JS segment

function changeWayPoint(waypoint) {
   console.log(waypoint)
}

I found the  waypoint to be null
whether LiquidCore not support Android`s Object to JS ?
whether LiquidCore only support Basic type？eg:(String,Int ...)

LiquidCore does not support JsonObject, but that is a good idea.  But LiquidCore does provide JSObject, which does essentially the same thing:
val obj = JSObject(mJSContext)
obj.property("lat", 12.13213231231)
obj.property("lng",<PHONE_NUMBER>1231)
mJsContext.evaluateScript("changeWayPoint").toFunction().call( null,  obj)

Looks like LiquiCore does not support releasing JSContext

What do you mean?  It will release when it is garbage collected. Just don't hold a reference to it when you're done.

@MRwangqi What's JsonObject? Please point me to a javadoc page. The API is totally different from Android's JSONObject (but the addition is appreciated).


fixing cache timeout setting

the current v0.8.4 fails if the cache timeout setting on the UI is not provided in edit datasource settings view: http://hostname:port/druiddatasourcemodelview/list/
self.cache_timeout causes the exception. The new logic is as follows:

try to find the cache timeout value from the UI
If not then get the default value in the caravel_config.py
If the value is not defined in both config and the UI then set it to 0.

Coverage decreased (-0.1%) to 71.078% when pulling c8b76f19095be3e6996e1f24e210df1eea805b58 on sid88in:fix_attribute_error into d885dd34f9ddb24988de7cab71a347bbdebc99fe on airbnb:master.

Coverage decreased (-0.1%) to 71.047% when pulling e04f212f4aff00de27f68b3a9c1bf80beb3635dd on sid88in:fix_attribute_error into d885dd34f9ddb24988de7cab71a347bbdebc99fe on airbnb:master.

Mmmh, some of that logic is already here:
https://github.com/sid88in/caravel/blob/fix_attribute_error/caravel/viz.py#L217
What kind of stack trace were you getting?

@mistercrunch I have added my stack trace here: https://github.com/airbnb/caravel/issues/207

It's been addressed in another PR, thanks for the PR though!


Deprecate SB elements relative to msg module adaption

Is your feature request related to a problem? Please describe.
Many APIs will be updated for consistency relative to the MSG module, also element scoping improvements (SB doesn't actually care about the header, it just needs to route).
Describe the solution you'd like
Review SB elements for deprecation (mark below), and then deprecate once #726 is in:

[ ] CFE_SB_Msg_t, CmdHdr_t, TlmHdr_t -> CFE_MSG_* maybe... high impact
[ ] CFE_SB_PKTTYPE_* -> CFE_MSG_Type_t
[ ] CFE_SB_CMD_HDR_SIZE -> sizeof CFE_MSG_CommandHeader_t)
[ ] CFE_SB_TLM_HDR_SIZE -> sizeof (CFE_MSG_TelemetryHeader_t)
[ ] CFE_SB_MsgPtr_t (use pointer to structure)
[ ] CFE_SB_MsgPayloadPtr_t (use pointer to payload in structure)
[ ] CFE_SB_Qos_t (not used)
[ ] CFE_SB_Default_Qos (not used)
[ ] CFE_SB_InitMsg -> CFE_MSG_Init
[ ] CFE_SB_MsgHdrSize (get from structure?)
[ ] CFE_SB_GetUserData (get from structure?)
[ ] CFE_SB_GetUserDataLength (get from structure?)
[ ] CFE_SB_SetUserDataLength - use CFE_MSG_SetSize with full message
[ ] CFE_SB_GetTotalMsgLength -> CFE_MSG_GetSize
[ ] CFE_SB_SetTotalMsgLength -> CFE_MSG_SetSize
[ ] CFE_SB_GetMsgTime -> CFE_MSG_GetMsgTime (this gets rid of structure return, similar to #45 issue)
[ ] CFE_SB_SetMsgTime -> CFE_MSG_SetMsgTime
[ ] CFE_SB_TimeStampMsg -> CFE_MSG_SetMsgTime
[ ] CFE_SB_GetCmdCode -> CFE_MSG_GetFcnCode
[ ] CFE_SB_SetCmdCode -> CFE_MSG_SetFcnCode
[ ] CFE_SB_GetChecksum (no use case defined, what do you need it for?)
[ ] CFE_SB_GenerateChecksum -> CFE_MSG_GenerateChecksum
[ ] CFE_SB_ValidateChecksum -> CFE_MSG_ValidateChecksum
[ ] CFE_SB_GetMsgId -> CFE_MSG_GetMsgId
[ ] CFE_SB_SetMsgId -> CFE_MSG_SetMsgId
[ ] CFE_SB_GetPktType -> CFE_MSG_GetTypeFromMsgId
[ ] CFE_SB_SetMsgSeqCnt -> CFE_MSG_SetSequenceCount

Describe alternatives you've considered
Just need to manage these, unique deprecation flag... not all actually need to go, but reduced/simplifies unit testing
Additional context
#711, #726
Requester Info
Jacob Hageman - NASA/GSFC

Marked as ready to discuss, so I know where to focus unit testing (plan to not unit test deprecated elements).

Sounds like GetUserData could still be useful... but could be complicated... MSG doesn't actually know where what you call "user data" may start.  Is it immediately after the "header", which could be primary, extended, secondary.  Is there padding?  MSG itself does not have the full message structure/description.  Might have a better home in whatever packet layout scheme/library ends up being used (if not using structures).

I was hesitant to bring it up in the CCB but this is definitely an area where network encoding and translations need to be considered.

Portable CFS applications should always define their RUNTIME messages as C structures.  This is what is done today.
Those C structures must be padded and aligned appropriately for the compiler/target being used.  This will be the case as long as there aren't any pragma/overrides or other tricks to defeat this alignment (don't do that).
This way it is safe to cast the structure pointer received from the software bus to the "real" type.

So yeah, for CFS apps, they should all access to message payload and fields through the C structure.  They should use sizeof() and offsetof() operators to get the size/offset as needed.  I see nothing wrong with that.  This paradigm also works fine if the C structures are generated by a tool - the code knows no difference.
I think encryption/decryption is orthogonal to this -- totally separate issue and it can coexist with it either way.  Encryption can be done inside software bus (upon send/receive, transparent to apps) or as it goes to/from the network (where it's needed) or localized to an app, where the app defines its "message" as a binary blob, and decrypts it locally to the real data (transparent to SB).  It all is possible, and is unaffected by these accessor APIs as far as I can tell.

would like to be part of splinter

I would also like to be part of splinter, but my only availability is today and tomorrow (7/16).  Otherwise I am not available until Monday 7/27.

Please invite me to the splinter as well.

To extend my previous comment - in case I cannot participate in splinter - I do see the usefulness of these abstract functions when sending/receiving on a network - where you may not have the C structure available - but need to add/strip padding that was not part of the real data.
They aren't currently defined that way because CFE doesn't currently make a distinction (network data is memory data) but we know this doesn't work well when making heterogeneous systems talk to each other.  With data buffers received from a network socket, it is generally not safe to directly cast as a C struct because you don't know the data is aligned properly for the current CPU, among other things.
So I do think its useful if these abstract functions like CFE_SB_MsgHdrSize() and all were defined to assist with dealing with the padding problem - adding or removing the requisite processor-dependent alignment bytes when transferring between network sockets.  So in other words:

MsgHdrSize() function returns the actual/real size of the header without padding
sizeof(struct MsgHdr) reflects the size of the header in memory, including padding.

It's trivial to leave in the CFE_SB_MsgHdrSize, CFE_SB_GetUserData, CFE_SB_GetUserDataLength, CFE_SB_SetUserDataLength w/ minor updates... but I'd still recommend using truth, be it the message structure (for memory) or information from whatever mechanism used to define the layout of data (be on the network or wherever).  Anything implemented now via SB is really just a guess... since it isn't using the actual message structure or layout definition.  It could guess based on the secondary header flag, the version information in the header, etc but all of that is open to redefinition and interpretation of what "User Data" and "Header" means.  If there's heterogeneous header definitions, then SB doesn't really know for sure where anything is, nor does it care.  It just routes messages.
As implemented now MsgHdrSize can easily be wrong in various scenarios (no secondary header, but with VER_2 defined which includes extended header, or if the original message used anything other than the local definition of secondary header), which means all the other functions are just as fragile.  Or arguably worse, since GetUserData just returns the memory location of the message + MsgHdrSize with no regard for possible compiler padding... and so on.  I guess what I'm thinking is it's not worth trying to fix these because I think using truth is better, wherever that truth may come from.
Another way to say it is if for the use case you don't know for sure where the user data is or what the header size is (the structure isn't available and header size unknown), then right now neither does SB.  At least not for sure in an abstract sense.  Much more likely would need to rely on what headers are being used across the entire mission, the actual layout/definition, etc.

Right - I think we are in general agreement.  A CFS app has the C struct definitions of the messages it is sending/receiving, so the "truth" in a CFS app would be sizeof(), offsetof(), etc and any payload field access should be made directly via that C structure.
An entity that is sending/receiving data via a network connection and has to deal with padding should have some sort of API provided by the encoding scheme to identify the size and position of actual data elements, minus padding.  Or better yet, copy the important data according to its own internal header layout to/from a network packet buffer.
So I guess I'm in favor of deprecating the CFE_SB_MsgHdrSize and CFE_SB_GetUserData and related functions.  These aren't exactly ideal in their current form to support padding identification so they'd have to be redefined for that purpose anyway.  Recommend to use the C structure definition and associated operators/primitives for all in-memory runtime manipulation of these messages.

However - I'm still on the fence about "accessor" methods like CFE_SB_Get/SetMsgId, CFE_SB_Get/SetTotalMsgLength, etc.  While I concur these really have nothing to do with SB, I'm not seeing what is really gained by forcing all apps to change to use the CFE_MSG_ equivalent instead.  This will be a headache for uses to update their code.
On the other hand, it is fairly simple to keep these as wrappers in CFE_SB, which not only preserves API compatibility, but also provides another point of flexibility (i.e. you could have more than one framing format and select at runtime).  In other words I don't see it as a bad thing to call a common layer first, which then "dispatches" to the actual CFE_MSG implementation.  And CFE_SB seems as good a place as any for such a dispatcher.

Right - I think we are in general agreement. A CFS app has the C struct definitions of the messages it is sending/receiving, so the "truth" in a CFS app would be sizeof(), offsetof(), etc and any payload field access should be made directly via that C structure.

One model is that what goes into SendMsg and what comes out of RcvMsg() is a generic/general-purpose/protocol-neutral struct that can be interacted with directly without any macros or functions for accessing/setting the fields. Encryption, checksum computation/validation, padding, compression, etc., could all be handled inside of Send/Rcv and we can just say that what is in the struct in memory may have nothing in common with what goes on the bus. (But it's likely that it's exactly the same!) It would be nice, though, for users of the SB API to not have to have any concept of CCSDS headers, just MsgBuf->Timestamp is a platform-specific timestamp, MsgBuf->Id is a generic ID type (uint32, uint64, binary blob, who knows?)
For example (I hope I didn't f*ck up your list, Jake, in my browser it lets me reorder the list in the original issue text. Yikes.):
typedef enum CFE_SB_MsgType
{
cmd, tlm, evt
} CFE_SB_MsgType_t;
typedef struct CFE_SB_Msg
{
CFE_SB_MsgType_t Type;
CFE_SB_CommandCode_t CC; /* could be uint16, byte array, duno /
CFE_SB_MsgID_t ID; / could be uint32, could be a byte array, duno */
OS_Time_t Timestamp;
size_t UserDataSz;
void UserData; / or could be uint8 UserData[maxsz]; */
} CFE_SB_Msg_t;
CFE_SB_PKTTYPE_* -> Msg->Type (command/telemetry/event enum)
CFE_SB_CMD_HDR_SIZE -> remove
CFE_SB_TLM_HDR_SIZE -> remove
CFE_SB_MsgPtr_t -> MsgPtr_t is a generic, non-protocol-specific struct
CFE_SB_MsgPayloadPtr_t -> a field of the Msg struct
CFE_SB_Qos_t -> remove
CFE_SB_Default_Qos -> remove
CFE_SB_InitMsg -> remove [ SendMsg() takes the Msg struct and maps it to an SB-specific struct ]
CFE_SB_MsgHdrSize -> remove
CFE_SB_GetUserData -> Msg->UserData
CFE_SB_Get/SetUserDataLength -> Msg->UserDataSz
CFE_SB_Get/SetTotalMsgLength -> remove
CFE_SB_Get/SetMsgTime -> Msg->Timestamp
CFE_SB_TimeStampMsg -> OS_GetLocalTime(Msg->Timestamp)
CFE_SB_Get/SetCmdCode -> Msg->CC
CFE_SB_Get/Generate/ValidateChecksum -> performed by SendMsg/RcvMsg, not part of Msg
CFE_SB_Get/SetMsgId -> Msg->ID
CFE_SB_GetPktType -> Msg->Type
CFE_SB_SetMsgSeqCnt -> generated by SendMsg(), returned by RcvMsg(), not part of Msg
A second model is that everything goes through getter/setter functions that map the generic datatypes to the protocol-specific internal types, and does such things as validation, byte swapping, packing, whatever is necessary.
Anyways, food for thought.

Reviewed list on 2020-06-28 and updated list.

Reviewed list on 2020-06-28 and updated list.

did you mean 2020-07-28?

@ejtimmon @jwilmot @acudmore you OK with this list?


locale number in tooltip

With Number.prototype.toLocaleString(), tooltip could render more readable number.
By default, it could be the browser locale, with an option to choose a specific one. A more refined option could be the optional object of toLocaleString() who have useful properties.

Good idea.


Fix template error when comment review doesn't exist

Fix #29885

This is a quick and dirty fix for the 500 panic error.
The root problem is that the "review" could be delete, leaving the "comment" has a dangling Review field.


Canaloplasty without Cathether

137760 GLAUCOMA, PRIMARY OPEN ANGLE; POAG
https://www.ncbi.nlm.nih.gov/pmc/articles/PMC9585494/
As the illumination equipment is expensive, surgeons tried different alternatives to replace the microcatheter. Beck first used a 6/ 0 polypropylene suture in circumferential cannulation in 360-degree trabeculotomy for primary congenital glaucoma in 1995 [39]. Later, this technique was described for the treatment of OAG patients [40,41]. After the preparation of the deep scleral flap, the ostia of SC are enlarged by using an OVD and a 6/ 0 polypropylene suture is introduced into the canal. The suture probe is blunt and slightly curved or formed in a double spiral. After circumferential catheterization, the distal tip is exposed at the other ostium and a 10/ 0 prolene suture is fastened to it. On removal, the 10/ 0 prolene suture remains in the canal secured through a slip knot or a four-throw knot. In recent prospective studies [42-44], a twisted 6/ 0 polypropylene suture was used for the cannulation of the SC (Fig. 3). The authors reported that the smooth tip of the loop ensures an atraumatic probing of the SC, while the double helix configuration provides a good rigidity to the suture. According to the authors, the success rate of circumferential cannulation by twisted 6/ 0 sutures is up to 90%, which is not inferior to the previously reported cannulation rates in conventional canaloplasty [16,45] or by the Visco360 and Omni System [46].

added.


The code process does not killed when debug restarted

Issue Type: Bug
I'm using python and pytest for testing and found the follwing issue.
When I'm start a debugging of test the vscode spawns a new process with following agruments: /usr/share/code/code -e delete process.env.ELECTRON_RUN_AS_NODE;require(process.argv[1])
This process is spawned by process:
/usr/share/code/code --nolazy --inspect=25125 /usr/share/code/resources/app/out/bootstrap-fork --type=extensionHost
Expected behavior
Code kills the unnecessary process when debugger is restarted.
Actual behavior
Code doesn't kill the unnecessary process when debugger is restarted. Also the new one process is spawned.
Steps to reproduse

Make a pytest test for function
Discover tests in vscode menu
Add breakpoint to test function
Run debugging of a test
Restart debugging when it stops at breakpoint

Extension version: 2019.6.24221
VS Code version: Code 1.36.1 (2213894ea0415ee8c85c5eea0d0ff81ecc191529, 2019-07-08T22:55:08.091Z)
OS version: Linux x64 5.1.12-300.fc30.x86_64

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz (8 x 3648)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwareoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: disabled_softwareskia_deferred_display_list: disabled_offskia_renderer: disabled_offsurface_synchronization: enabled_onvideo_decode: unavailable_offviz_display_compositor: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
1, 1, 1

Memory (System)
15.51GB (8.23GB free)

Process Argv
--unity-launch

Screen Reader
no

VM
0%

/usr/share/code/code -e delete process.env.ELECTRON_RUN_AS_NODE;require(process.argv[1])

Thanks for reporting this issue. However the Python Extension doesn't spawn such processes as part of the debugger. Please report this issue upstream on VS Code.


支持php8.0+吗?

Your requirements could not be resolved to an installable set of packages.
Problem 1
- Root composer.json requires workbunny/webman-rqueue * -> satisfiable by workbunny/webman-rqueue[0.0.1, 0.0.2, 1.0.0, 1.0.1].
- workbunny/webman-rqueue[0.0.1, ..., 0.0.2, 1.0.0, ..., 1.0.1] require psr/container ^1.1.1 -> found psr/container[1.1.1, 1.1.2] but it conflicts with your root composer.json require (^2.0).
You can also try re-running composer require with an explicit version constraint, e.g. "composer require workbunny/webman-rqueue:*" to figure out if any version is installable, or "composer require workbunny/webman-rqueue:^2.1" if you know which you need.
Installation failed, reverting ./composer.json and ./composer.lock to their original content.
好像不支持php8.0 我用了psr/container(^2.0)

我尝试调整了composer.json，请使用最新版本试试


bossbar players can work without specifying a selector

:tada: This issue has been resolved in version 1.10.5 :tada:
The release is available on:

npm package (@latest dist-tag)
Visual Studio Marketplace
GitHub release

Your semantic-release bot :package::rocket:


[TPC-H] Configure temporary directory in duckdb for out-of-core processing

Closes #1509

This would be a temp directory on the VM? If so, I'd recommend doing something under /scratch so it uses NVMe if present.

This would be a temp directory on the VM? If so, I'd recommend doing something under /scratch so it uses NVMe if present.

Good point, I'll adjust the code to check if we're running on the cloud. I suppose we should create the temporary directory within the workspace of the Dask worker that runs the coiled.function?

I suppose we should create the temporary directory within the workspace of the Dask worker that runs the coiled.function?

Yeah, that would work—dask worker workspace is already set to be in /scratch.

Is there a way I can figure out when NVMe is present? Is it only specific instance types?

It's specific instance types on AWS, in particular, instance types with d in the family, such as m6id or g4dn (plus a few others, such as g5 which does have NVMe).


Firebase not playing nice with Windows

Authentication and creating new accounts is currently broken on Windows. Gotta find out why and fix it.
Error thrown:
[ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: MissingPluginException(No implementation found for method Auth#signInWithEmailAndPassword on channel plugins.flutter.io/firebase_auth)

Support for Windows has been touch and go throughout the development process, as such we have chosen to remove it from the scope of the project


Installing pylyzer through Mason does not work (Neovim)

When I try to install pylyzer through Mason does not seem to work
MasonLog: [ERROR Thu May 11 10:14:39 2023] ...e/nvim/lazy/mason.nvim/lua/mason-core/installer/init.lua:200: Installation failed for Package(name=pylyzer) error=spawn: cargo failed with exit code 101 and signal 0.
Neovim version: 0.9.0
Operating system: Ventura 13 (MacOS M1)
Maybe this is something on my end that I am doing wrong

Move cursor to arrow and pres Enter.
Go to end and show more full log.
The same try to install pylyzer directly in terminal by cargo install pylyzer
and show full log

Nevermind, I was running an older version of Cargo where unzip is an unstable method. Maybe add to the readme that latest version of Cargo is needed, thanks for the help.


Tests fail on Windows

If I run make the tests fail with:
$ make
GO111MODULE=on go test ./...
can't load package: package github.com/projectriff/riff:
main.go:1:1: expected 'package', found cmd
make: *** [Makefile:19: test] Error 1

Modifying Makefile to use GO111MODULE=on go test ./pkg/... and applying #1173 -  I see the following errors:
Summarizing 4 Failures:

[Fail] namespace NamespaceInit [It] should create secret for gcr
C:/Users/trisberg/workspace/projectriff/riff/pkg/core/namespace_test.go:132

[Panic!] namespace NamespaceInit [It] should apply label to namespace resources
C:/Go/src/runtime/panic.go:513

[Panic!] namespace NamespaceInit [It] should fail if the PVC label kustomization fails
C:/Go/src/runtime/panic.go:513

[Panic!] namespace NamespaceInit [It] should support local kubernetes configuration files
C:/Go/src/runtime/panic.go:513

Ran 67 of 67 Specs in 0.241 seconds
FAIL! -- 63 Passed | 4 Failed | 0 Pending | 0 Skipped

Summarizing 2 Failures:

[Fail] Kustomize wrapper [It] customizes remote resources with provided labels
C:/Users/trisberg/workspace/projectriff/riff/pkg/core/kustomize/kustomize_test.go:92

[Fail] Kustomize wrapper [It] customizes local resources with provided labels
C:/Users/trisberg/workspace/projectriff/riff/pkg/core/kustomize/kustomize_test.go:102

Ran 5 of 5 Specs in 1.048 seconds
FAIL! -- 3 Passed | 2 Failed | 0 Pending | 0 Skipped

Summarizing 1 Failure:

[Fail] ResolveTilde [It] resolves ~/ against current user's home directory
C:/Users/trisberg/workspace/projectriff/riff/pkg/fileutils/paths_test.go:61

Ran 59 of 59 Specs in 0.286 seconds
FAIL! -- 58 Passed | 1 Failed | 0 Pending | 0 Skipped

We now have the unit tests running on Windows via Azure Pipelines. Because the tests fail, we ignore the result of the tests. We should strive to remove this flag so that future Windows test failures will be enforced.


Set up CI/CD for DNS-IAC

Background

Set up CI/CD for DNS-IAC
Questions / Assumptions

Acceptance Criteria

[ ] CI/CD for DNS-IAC created

Reference
How to write good user stories

I've added the plan step

Blocked until Jake is back.


Hugo building error "execute of template failed"

Describe the bug
Hi, I will report it because I could not solve it.(And Im not Native English Speaker, Sorry.)
I Commanded hugo, but cant build Site.
error log is here.
Building sites … ERROR 2019/02/20 12:45:33 [jp] page "/root/project/content/posts/flutter_tips_002.md": render of "page" failed: execute of template failed: template: posts/single.html:6:5: executing "posts/single.html" at <partial "head.html" ...>: error calling partial: "/root/project/themes/dream-plus/layouts/partials/head.html:7:50": execute of template failed: template: partials/head.html:7:50: executing "partials/head.html" at <$.Site.Params.author...>: can't evaluate field name in type interface {}
ERROR 2019/02/20 12:45:33 [jp] page "/root/project/content/posts/game_2018_of_the_year.md": render of "page" failed: execute of template failed: template: posts/single.html:6:5: executing "posts/single.html" at <partial "head.html" ...>: error calling partial: "/root/project/themes/dream-plus/layouts/partials/head.html:7:50": execute of template failed: template: partials/head.html:7:50: executing "partials/head.html" at <$.Site.Params.author...>: can't evaluate field name in type interface {}
ERROR 2019/02/20 12:45:33 [jp] page "/root/project/content/posts/flutter_tips_001.md": render of "page" failed: execute of template failed: template: posts/single.html:6:5: executing "posts/single.html" at <partial "head.html" ...>: error calling partial: "/root/project/themes/dream-plus/layouts/partials/head.html:7:50": execute of template failed: template: partials/head.html:7:50: executing "partials/head.html" at <$.Site.Params.author...>: can't evaluate field name in type interface {}
ERROR 2019/02/20 12:45:33 [jp] page "/root/project/content/posts/game_mtga_001_newbie.md": render of "page" failed: execute of template failed: template: posts/single.html:6:5: executing "posts/single.html" at <partial "head.html" ...>: error calling partial: "/root/project/themes/dream-plus/layouts/partials/head.html:7:50": execute of template failed: template: partials/head.html:7:50: executing "partials/head.html" at <$.Site.Params.author...>: can't evaluate field name in type interface {}
Total in 421 ms
Error: Error building site: failed to render pages: [jp] page "/root/project/content/posts/kotlin_tutorial_basic_001.md": render of "page" failed: execute of template failed: template: posts/single.html:6:5: executing "posts/single.html" at <partial "head.html" ...>: error calling partial: "/root/project/themes/dream-plus/layouts/partials/head.html:7:50": execute of template failed: template: partials/head.html:7:50: executing "partials/head.html" at <$.Site.Params.author...>: can't evaluate field name in type interface {}
Exited with code 255

Previously I could deploy it without probleml. (on 27 Dec 2018)
I deployed it after a long absence and failed.
First of all it was said that the version of hugo is old, so I updated dockerImage.
After that, the attached error came out.
How should I do?
Your project
Project repository is here. https://github.com/SasakiYuki/bibo-log
Hugo version
cibuilds/hugo:latest using docker image is this.

@SasakiYuki Dream Plus config variables have been modified, that is the layout of config.toml file has been updated for organizing variables in a better way.
Simply updating your config.toml file will fix the above error. You may refer to the example config as a reference.

thank you for answering!
Is the correct link here ?
I tried trying it, but did it match?
https://github.com/SasakiYuki/bibo-log/commit/0fd67d740e4e9591f9f45e0458e400225562f509

@SasakiYuki Sorry I didn't notice the broken link. I have now fixed the link in my comment. Basically you have to refer to the posts.toml file in the exampleSite folder.

@UtkarshVerma ありがとう！！！ TY!!!
It is solved. Thank you always for a nice update. I will continue to use it!


Regression/bug with OID content verification 1.77->1.78 ?

This used to parse as valid OID with 1.77 with ASN1ObjectIdentifier.fromByteArray(oid):
[TRACE] GPData - Parsing 06092A864886FC6B048000 as OID
Tag 6: 1.2.840.114283.4.0

This also matches the result from https://lapo.it/asn1js/#BgkqhkiG_GsEgAA
With 1.78 I get instead:

Caused by: org.bouncycastle.asn1.ASN1Exception: invalid OID contents
	at org.bouncycastle.provider/org.bouncycastle.asn1.ASN1InputStream.createPrimitiveDERObject(Unknown Source)
	at org.bouncycastle.provider/org.bouncycastle.asn1.ASN1InputStream.buildObject(Unknown Source)
	at org.bouncycastle.provider/org.bouncycastle.asn1.ASN1InputStream.readObject(Unknown Source)
	at org.bouncycastle.provider/org.bouncycastle.asn1.ASN1Primitive.fromByteArray(Unknown Source)
	at pro.javacard.globalplatform@23.08.10-SNAPSHOT/pro.javacard.gp.GPData.oid2string(GPData.java:392)
	... 36 more
Caused by: java.lang.IllegalArgumentException: invalid OID contents
	at org.bouncycastle.provider/org.bouncycastle.asn1.ASN1ObjectIdentifier.createPrimitive(Unknown Source)
	... 41 more

This data comes from hardware and can't be changed. Even if incorrect by content, the visualization/parsing is handy. Is this a bug and/or is it possible to invoke parsing without content verification?

OpenSSL also barfs on this (the last 0x80):
$ echo -n 06092A864886FC6B048000 | xxd -p -r | openssl asn1parse -inform der
    0:d=0  hl=2 l=   9 prim: OBJECT            :BAD OBJECT:[2A864886FC6B048000]

Okay, so the "8000" is the problem - I'm not surprised OpenSSL doesn't like it either - very odd thing for someone to do and definitely a violation of the encoding rules. I've added a system property, "org.bouncycastle.asn1.allow_wrong_oid_enc" which will ignore the specific case of a pointless extension byte.
Now up on https://www.bouncycastle.org/betas actual patch should appear shortly.


[MINOR][K8S] Remove unused local val outstanding  from ExecutorPodsAllocator#onNewSnapshots

What changes were proposed in this pull request?
This pr just remove unused local val outstanding  from ExecutorPodsAllocator#onNewSnapshots, the outstanding > 0 replaced by newlyCreatedExecutorsForRpId.nonEmpty after SPARK-36052 | https://github.com/apache/spark/pull/33492
Why are the changes needed?
Remove unused local val
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Actions
Was this patch authored or co-authored using generative AI tooling?
No

Thanks, merged to master

Thanks @yaooqinn


[GH-15896] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 636

Summary

Replace Javascript variable theme.centerChannelBg with CSS variable
--center-channel-bg for scrollbar-track-color.
Ticket Link

Fixes https://github.com/mattermost/mattermost-server/issues/15895
Related Pull Requests

Screenshots

Hello @tony-ho,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.
This is a standard procedure for many open source projects.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

/check-cla

QA will be done on the PR the merges this campaign branch into master.


After processing, only one or zero image can be obtained.

Thank you for developing such a great tool. I encountered some issues while converting the images, and I would appreciate your guidance. I followed the process shown in this video. Below is the workflow I used for data processing:
I recorded approximately one minute of data using Spectacular Rec and imported the data onto my computer.
After installing the SpectacularAI SDK, I ran the command sai-cli process {data directory} --preview3d --key_frame_distance=0.05 {output directory}
Here is the output log:
Selected device type: ios-tof
parameterSets: ["wrapper-base", "offline-base", "ios-tof"]
{'maxMapSize': 0, 'useSlam': True, 'passthroughColorImages': True, 'keyframeDecisionDistanceThreshold': 0.05, 'icpVoxelSize': 0.05, 'mapSavePath': '/home/songpo/projects/sdk-examples/python/mapping/tmp_data/points.sparse.csv', 'maxKeypoints': 1000, 'optimizerMaxIterations': 30}

I have checked that ffmpeg is working properly, but I'm still unsure about the source of the problem. Could you please provide some guidance?
Here are the original files. https://drive.google.com/file/d/1heyIrhDXy-qnlseIzMKvaXSIB9YVk9km/view?usp=sharing

Thank you for reporting. Currently, the method can fail your object is too close. You should film it from a distance of at least 30  centimeters.
We will improve the error handling related to this in future versions.

This has been improved in the new 1.26.2 release (run pip install -U spectacularAI to update):

Better error message on failed mapping
Separate error messages on failed tracking

Another tip: On iPhone, especially with close object scans, it also makes sense to try mapping without LiDAR. This is possible by adding a --mono fla to sai-cli process, e.g.,
sai-cli process /path/to/recording_XXXX /path/to/output --mono

In any case, it is still recommended to film objects from a minimum distance of 30 centimeters


Zabbix proxy and hiera

Hi,
I have now problem with zabbix-proxy and use of hiera.
Indeed, i receive this error Error: Failed to apply catalog: Validation of Exec[ --port='' --owner='' --template=template0  'zabbix-proxy'] failed: ' --port='' --owner='' --template=template0  'zabbix-proxy'' is not qualified and no path was specified. Please qualify the command or specify a path. at /etc/puppet/modules/postgresql/manifests/server/database.pp:63 Wrapped exception: ' --port='' --owner='' --template=template0  'zabbix-proxy'' is not qualified and no path was specified. Please qualify the command or specify a path.
I use this configuration :
zabbix::proxy::zabbix_server_host: 'xxx.com'
zabbix::proxy::database_type: 'mysql'
zabbix::proxy::zabbix_server_port: '10051'

I have also tried to add this configuration :
zabbix::database::database_type: 'mysql'
zabbix::database::zabbiix_type: 'proxy'
zabbix::database::database_name: 'zabbix-proxy'
zabbix::database::database_user: 'zabbix-proxy'
zabbix::database::database_password: 'test'

But I have got this error Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Duplicate declaration: Class[Zabbix::Database] is already declared; cannot redeclare at /etc/puppet/modules/zabbix/manifests/proxy.pp:408 on node teliboxexpress.local.tec6.net Warning: Not using cache on failed catalog Error: Could not retrieve catalog; skipping run
Have you an idea to what I doing wrong ?
Thank you and have a nice day ;)

Hi Oyabi,
I noticed this:
zabbix::database::zabbiix_type: 'proxy'

It has 2 i in zabbiix_type, but thats not the problem. :-)
Is this an 1 node setup? So the zabbix proxy and the mysql database is running on the same server?
If this is the case, I would use this:
zabbix::proxy::zabbix_server_host: 'xxx.com'
zabbix::proxy::database_type: 'mysql'
zabbix::proxy::zabbix_server_port: '10051'
zabbix::proxy::database_name: 'zabbix-proxy'
zabbix::proxy::database_user: 'zabbix-proxy'
zabbix::proxy::database_password: 'test'

The zabbix::proxy class already does an include of the zabbix::database::<database_type> class, so you won't have to define it again.
Thank you, you also have a nice day! :-)
Kind regards,
Werner

Hi Werner, ;)
I have still this error Error: Failed to apply catalog: Validation of Exec[ --port='' --owner='' --template=template0  'zabbix-proxy'] failed: ' --port='' --owner='' --template=template0  'zabbix-proxy'' is not qualified and no path was specified. Please qualify the command or specify a path. at /etc/puppet/modules/postgresql/manifests/server/database.pp:63 Wrapped exception: ' --port='' --owner='' --template=template0  'zabbix-proxy'' is not qualified and no path was specified. Please qualify the command or specify a path..
I have copy/past your line of code.
I made an includes like this :
---
classes:
  - zabbix::proxy
  # - mysql::server # doesn't work even if I uncomment.

Another question, it's possible to format these line (and zabbix-agent) like zabbix::userparameter ?
zabbix::userparameter::data:
  RAID:
    content: softRaid.status[*], cat /proc/mdstat | grep $1 -B0 -C1 | tail -n 1 | cut -d...

Thank you for your help

Hi Oyabi,
To be honest, I don't know why it gives an error on the postgres. You have specified mysql with this:
zabbix::proxy::database_type: 'mysql'

So, it will be using the mysql as backend.
You don't have something like this in your hiera tree?
classes:
  - postgresql::server

An different setup which may help, what if you use it like this:
classes:
  - zabbix::proxy
  - mysql::server

zabbix::params::database_type: 'mysql'
zabbix::params::proxy_database_name: 'zabbix-proxy'
zabbix::params::proxy_database_user: 'zabbix-proxy'
zabbix::params::proxy_database_password: 'test'
zabbix::proxy::zabbix_server_host: 'xxx.com'
zabbix::proxy::zabbix_server_port: '10051'

We set the params which are included in the zabbix::proxy classes..
The zabbix::userparameter::data should work like you have mentioned.
Kind regards,
Werner

Hi Werner,
it doesn't work either.
I have only put the code you give it to me. (first then second)
It happen to work well with PostgreSQL (no error) thus I think it's a bug with MySQL.

I just pushed the fix for your MySQL issue. Would you please test if the error is gone?

I have test this fix yesterday but I have always this error and I don't know why.
I try to escaped the quotes and I got same result.
I probably can put zabbixproxy as user but it's be better if we can let's default parameter.

Hi Oyabi,
With the latest change I added some quotes, from:
mysql -h ${database_host} -u ${database_user} -p${database_password} -D ${database_name}

to
mysql -h '${database_host}' -u '${database_user}' -p'${database_password}' -D '${database_name}'

So if I read it correctly, this didn't solve your problem.
I'll close this ticket, because the original question is solved and the bug is from puppetlabs-mysql module.
Kind regards,
Werner


index-aware reducer functions

I want to write an interactive index chart where the user specifies the date at which to normalize series. This means I can’t use the built-in first normalize basis; I need to find the appropriate starting value for each series based on the given date. While I could do this outside of Plot, I’d prefer to implement this within the existing normalize transform, which means I want access to the index (I) within the normalize basis method. This PR allows that, maintaining backwards compatibility by checking the length of the reduce function. This applies to both the normalize and window transforms.

Yes, relevant xkcd. I don’t think we can avoid backwards incompatibility entirely but this feels reasonable to me. I would expect people to specify the min (named) reducer instead of passing in d3.min directly, for example.

I should have added this to the map transform, too. This should use a taker instead:
https://github.com/observablehq/plot/blob/42f5d9fdac734c11bf2de5f4e2f72e5b5f0d1bc0/src/transforms/map.js#L78


Issues in installing Pyleecan v1.4.1

Dea Sir/Madam,
Iam trying to install Pyleecan v1.4.1 ( latest version) but my antivirus software ( Norton) is detecting too many viruses.
Can you please help or provide us a safe installable latest exe.

Sure let me try. Further, let me uninstall Norton and try again.

Norton is removed hence I was able to install it and works ok.
Can you please share with me detailed steps to install the full package including python on windows 11?

Hello,
The full procedure is detailed on this page: https://pyleecan.org/get.pyleecan.html
Is you have any questions, it could help us improve this page.
Best regards,
Pierre


pipe to fiona before geojsonio

Following up on issue 71.

p.s. thanks @vincentsarago ! 🙏

Thanks @sgillies, updated to use mercantile shapes --collect
This is a really cool functionality!


Add russian translation link

Hey guys, i've translated this styleguide to russian, can you add link to it ?

Sure!
(Duplicates #19)


ZEELANDIA - API status inactive

ENVIRONMENT: production
URL: https://scrapers.peviitor.ro/
Browser: Chrome
Device: Laptop
OS: Windows 10
STEPS TO REPRODUCE:
Open theURL in the browser
Search for "Zeelandia" company
Press on search button
Click on  "Run Scraper" button
Check  "Status" section
EXPECTED RESULTS:
The scraper runs correctly and the message "Active" is displayed in the "Status" section
ACTUAL RESULTS:
The "Inactive" message is displayed in the "Status" section
ATTACHMENTS:

fixed can you retest?

Retested - all good status 'Active'


fix: swaggerinfo template for instanceNames

Describe the PR
e.g. fix template to generate swaggerInfo variable when --instanceName option is specified
Relation issue
#1133

@Syuparn Would you mind adding a unit test for template rendering output to cover this fix?


Add note that omsagent user must have read access

Add note that omsagent user must have read access to file(s) listed in fileLogs.

@AaronRM : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


query term: regulation of mitochondrial membrane permeability

I don't know what that term means, is there any such thing?
Exact def is
regulation of transport across mitochondrial membrane | exact
but this is not exactly the same thing. I think "regulation of small molecule transport is probably the intended meaning but it is difficult to tell?

OK many annotations are from
GO:0097345    mitochondrial outer membrane permeabilization
http://europepmc.org/abstract/MED/21041309
this does not seem to be equivalent to transport. Isn't the membrane ruptured during apoptosis?
"regulation of permeability" doesn't seem to be the correct way to describe this process?

I believe that biologists that study apoptosis use this term to refer to the disruption in mitochondrial membrane integrity that occurs as part of the apoptotic process. I think a pore is formed. Someone should double-check this.

I think the early steps are caused by an influx of solutes. the process is usually called "membrane permeablization" and to me this is different from "regulation of permeability" but I guess the apoptosis group will have looked into this branch and assume its OK so will close.

It smells like a readout to me... When I quickly scan the annotations I see a lot of apoptotic signaling molecules.

Aren't they are actually regulating "membrane permeablization"  though?
https://www.researchgate.net/publication/44596864_Targeting_mitochondria_for_cancer_therapy/figures?lo=1
(I would't call this 'regulation of membrane permeability", though? I think permeablization and permeability are slightly different).

Right, as far as I can tell what is being measured is the change in membrane permeability, and the definition of 'regulation'  in GO is 'any change in rate, extent... etc' , which causes a lot of confusion.
Pascale

Yes our definition of regulation is much to weak to describe biological regulation.
Bax probably regulates the "solute import" step? which is transport, but the eventual  rupture (permeablization)  seems to be a consequence  of the solute import? so in that case it probably is a "readout"?


Test: Add a test suite for api/news

What would you like to share?
Add a test suite for the news endpoints.
Steps:

Add a new describe block for /api/news/sources inside /__tests__/integration-tests/routes/news.test.js
move the first test suite inside news.test.js to that describe block: it('should return all the articles', async () => {})
Add test suite for all possible scenarios

Additional information

Note
All axios requests are mock inside the __mocks__ folder
Fell free to add more mock data inside that file

Hi there ,
Please assign it to me

Please have a look at PR


Exporting data from postgres gives quotes around character fields that look like numbers when choosing NO quotes in export

Exporting data from postgres gives quotes around character fields that look like numbers when choosing NO quotes in export. Also the header contains quotes. Please make the option available to export without any quotes.

Nb i have this problem on my MAC, did not test it on a Windows laptop yet. I often have to make exports and it is very unhandy when i need to export a mega file of 20mio rows and dbeaver is putting quotes (") around every row. Tried all kind of settings but did not find out how not to get them..

You can use space character as quote to disable quotes:


Release synthtool 0.9.0

This pull request was generated using releasetool.

Release is at https://github.com/GoogleCloudPlatform/synthtool/releases/tag/synthtool-0.9.0


Integration with Kubeflow pipelines

First things first, thanks to open this project!! We are working in a very similar project, and Metaflow is going to help us a lot.
Do you plan to create a kind of integration with Kubeflow Pipelines? For us, this is very helpful to deploy these pipelines in our production environment.

@BAlmeidaS I mentioned this integration with kubeflow in issue Support for Airflow and Kubernetescomment. I really thought that metaflow integration with kubeflow reduce work in integration on Kubernetes.

Yes @SteNicholas I saw the issue, I decided opened mine anyway because I thought that one thing is integration with k8s and deploy an orchestrated pipeline with docker. Another thing is to deploy a Kubeflow pipelines targz (which is similar but not the same thing).

Thanks for opening the issue, @BAlmeidaS . Issues like these are really informative as we go about planning our roadmap.

@BAlmeidaS @
There's different options to integrate with KFP. User could use KFP SDK in metaflow or do something further and change orchestration and computing layer to kubeflow. Do you have some ideas in mind?

Kubeflow's Pipeline features are a little different from Metaflow's DAG features. Kubeflow supports conditional Steps in workflows. Metaflow doesn't have support for conditional flows.

Kubeflow supports conditional branching concept that Metaflow doesn't.  Metaflow could compile to Kubeflow via an intermediate representation (https://github.com/kubeflow/pipelines/issues/3703)

@talebzeghmi I responded in this other thread. Our current integration to AWS Step Functions' State Machine Representation is in PR #202.

The reference implementation for AWS Step Functions is available here now. This should serve as a good starting point for any other scheduler integration.

Sorry for the enormous delay to answer this, I lose the tracking about this project. I was very excited about it when it launched but we developed our own solution to integrate with kfp. Answering @Jeffwan, IMO we could use kfp to deploy via metaflow. User may not notice that she is deploying a pipeline in kubeflow. Even metaflow doesn't having some features that kubeflow pipelines has. What you guys think about it??

Closing this issue given that #992 that addresses #50 has been merged. Kubeflow Pipelines also uses Argo Workflows under the hood so a layer of indirection through Kubeflow Pipelines doesn't really serve much benefit currently.


Multilingual versions

Thank you very much for your open-source code, it's a great tool. I wanted to ask if you have any plans to create a multilingual version? If so, I would be willing to contribute my time and effort to help translate it into Chinese.

i would like to take this issue, i'm currently working on it with i18n-react @Lissy93


link - is_external is not working

Describe the bug
is_external is not working at link.
exist or not, same.
To Reproduce
Steps to reproduce the behavior:

Code/Link to Repo: https://github.com/pynecone-io/pynecone-examples/tree/main/crm
https://github.com/pynecone-io/pynecone-examples/blob/849351687aff0c2325523540289a481a0fcc6cce/crm/crm/pages/index.py#L18

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.

                pc.link(
                    pc.button(
                        "Log in to get started", color_scheme="blue", underline="none"
                    ),
                    href="/login",
                    is_external=True,
                ),

** Specifics (please complete the following information):**

Python Version: Python 3.10.6 - virtualenv
Pynecone Version: 0.1.32
OS:  docker container

Distributor ID: Ubuntu
Description:    Ubuntu 22.04.2 LTS
Release:        22.04
Codename:       jammy

Browser (Optional): whale(crhomium base), safari

Additional context
Add any other context about the problem here.

@LayGPark what are you expecting it to do? according to the docs for is_external "If true, the link will open in new tab."
In my experiments, the link is not opening in a new tab... and I'm actually having trouble even finding a successful next.js snippet that causes a link to open in a new tab.

@masenf  thank you for your answer!
yes, I want to 'open in new tab'
you means this problem is not cause of pyncone, right?

@LayGPark No, this turned out to be a compatibility issue from when pynecone upgraded to Next 13.
I have posted a patch with the fix: https://github.com/pynecone-io/pynecone/pull/1138
You can test if it is working in your environment.

@masenf Ah, ok!
Thank you!
I'll try after release https://github.com/pynecone-io/pynecone/pull/1138 :)


Did you use gpt-4-32k for the evaluation？

If so, how do you handle more than 32K tokens?

I found you used 128k context window


Pre-commit hook staging the other unstaged files

Due to addition of the statement: git add . in pre-commit hook, the files which are not staged to commit is also getting staged.

One resolution to this is:

stash all the unstaged and untracked files using git stash push --keep-index -u
run the modifications and fixes
pop the stash
But still one issue: Partial staging in the same file
Only solution remaining is to use lint-staged


Add new require-meta-default-options rule

Fixes #499.

@JoshuaKGoldberg

it has been shipped in v6.4.0 🎉


Sure about CC0? Are labels CC0? - possible license compatibility issues

e.g. on https://raw.githubusercontent.com/biopragmatics/biomappings/master/src/biomappings/resources/mappings.tsv we have this:
orcid:0000-0003-4423-4370
wikipathways	WP999	TCA Cycle	speciesSpecific	go	GO:0006099	tricarboxylic acid cycle	semapv:ManualMappingCuration	orcid:0000-0003-4423-4370
It is quite unclear which parts of GO (and other CC-BY ontologies) can be turned into CC0 and which ones cannot (a kind of license stacking issue).
This is a major issue w.r.t. importing ontologies into Wikidata.  Some would say that CC-BY is not compatible with CC0.
Maybe we need some kind of new BioOntology Open License.
CC-BY on ontologies creates nightmares, but most resources are afraid of going CC0 (also because of legacy licensing issues).

That's a good point. I hope that we're in the situation where the name is factual knowledge, or this is can fall under "fair use" (though I don't know the legal definition for that)
If someone is upset we are doing this then i guess we can take the labels out

I am upset because I am not confident enough to do the same on Wikidata :)
fair use is quite broad in definition; maybe @andrawaag can add something to the discussion


Look through requirements.txt and get rid of stuff we don't need

I am pretty sure we don't need everything in there.

Part of this is also #13.

As far as I'm concerned, this is a duplicate of #13, so should close this one.


Invalid JSON log format

Expected Behavior
Scan log is in valid JSON format
Actual Behavior
Scan log is in invalid JSON format
Steps to Reproduce the Problem

scan any project with --log-format json
log structure is as following:
{object}
{object}
etc..

Multiple objects on root level are not allowed according to JSON spec. JSON parsers will fail.
It should be:
[
{object},
{object}
]
https://jsonlint.com/
Specifications

Version: 1.3.1
Platform: windows x64
Subsystem:

This is the default behavior of zerolog https://github.com/rs/zerolog#setting-global-log-level
Usually, when you're streaming logs in JSON format you send one object per line.
Because otherwise, you would need to know the entire output before sending any events to format the array.

If you want to wait for KICS to finish and combine the entries using pipes in CLI:
You could use: jq -cs


production: Deploy the bot and worker stack in openshift cluster

Currently we are maintaining aws worker machines for running the precheck/generate jobs (through the remote model endpoints). Deploying the stack on openshift can give us all the goodness of scaling the bot stack. We can possibly run the local generate and serve the model if the cluster provides GPU.

Thinking of the Rosa ET cluster for this with Dave's changes having landed. Thoughts?

Yeah, that's what i was thinking as well. Currently the worker node's IP are explicitly allowed to access the backend sdg service, we need to resolve that issue first to deploy it in the cluster to make it work out of the box.


Handle k8s deprecation of Ingress resources' apiVersion

This PR safeguards against future issues when k8s stops supporting outdated resources using the currently recommended practice of Helm. Related to this PR is https://github.com/jupyterhub/zero-to-jupyterhub-k8s/pull/1718.

LGTM and I learnt a nice way to handle these cases!


Debugging process stopped

Tested versions
i am in 4.1.2
System information
Windows 11
Issue description
When i run a proyect it closed inmediatly and says debugging process stopped, i have closed the proyect and now, when i try to edit the proyect, all the scenes are deleted,
Steps to reproduce
idk
Minimal reproduction project (MRP)
idk

Can you please check, if this also happens in Godot 4.2?
It would help, if you could share a minimal reproduction project, that causes this behavior. Without a reliable way to replicate the problem it is extremely difficult to debug the problem.

Closing due to lack of response, if you provide more information this can be reopened


modules are too long and have too many symbols

Several modules have become quite long which IMO makes them difficult to use and maintain. Obviously modules can be any size and structure, but I think that long files are difficult to navigate, and modules with too many symbols are error prone due to shadowing and namespace collision.

module
number of lines
number of symbols

pvlib.pvsystem
2211
23

pvlib.clearsky
489
13

pvlib.atmosphere
472
6

pvlib.forecast
1113
7

pvlib.irradiance
1949
23

pvlib.location
287
1

pvlib.modelchain
722
3

pvlib.solarposition
840
12

pvlib.spa
1300
50

pvlib.tmy
497
8

pvlib.tools
259
14

pvlib.tracking
523
3

In particular pvsystem, forecast, irradiance and spa are very long and contain a lot of symbols.
I don't know what would be ideal, but IMO I think a maximum of 500 lines and 10 symbols is a good baseline.
The SPA algorithm presents a unique challenge, as this code was ported, so maybe for reference sake, it should stay as it is. However, I think that the very large arrays of coefficients in irradiance and spa take a lot of space. These could easily be moved to HDF5 files using h5py which would have some memory and speed enhancements, but I'll create a related issue for that.
References for large modules and many symbols.

Programmers-SE: Are there any negative side effects of splitting up large modules? [closed]
Wikipedia: God Object
Wikipedia: Anti-Pattern

I agree that it could be better, but I also don't know what would be ideal. Some things I've thought about in the past:

Rename irradiance.py to transposition.py. Move things like aoi, aoi_projection to tools.py, move extraradiation to solarposition.
A "classes" module that implements Location, PVSystem, SingleAxisTracker. Probably would leave ModelChain where it is.
Make the inline documentation less verbose while expanding the narrative-style documentation. Doing this well would take a lot of time.

Further point on documentation: a huge number of those lines are thorough documentation. There are many functions with documentation that's twice as long as the code. Some modules might be 50% documentation.
We created the style guide so that the api-level symbols would at least be uniform, but there are a lot of symbols in the PV world. I'm all for consolidation if you see an opportunity.

@mikofski as far as I understand it, the length of a module is just a matter of taste in python. An indicator for a bad structured project is more the length of classes, methods or functions. Restructuring the whole project includes the danger of creating new bugs. I would rather have a look at the biggest "god" classes/functions and split them step by step. What classes/functions do you have in mind?

Continuing comments from #261 the top level modules can be converted to subpackages which would preserve the current API, but allow more flexibility:
current state:
+-+- pvlib/
  |
  +- irradiance.py  # a big module, how to add even more to this?

becomes:
+-+- pvlib/
  |
  +-+- irradiance/
    |
    +- __init__.py  # import API's from new modules to keep backward compatibility
    |
    +- core.py  # has all of the core methods
    |
    +- decomposition.py  # has all of the decomposition methods
    |
    +- transposition.py  # has all of the transposition methods
    |
    +- ...  # other modules with methods used in irradiance

Then pvlib/irradiance/__init__.py contains the following:
from pvlib.irradiance.core import extraradiation, aoi_projection, aoi, ...
from pvlib.irradance.decomposition import disc, dirint, liujordan, erbs
from pvlib.irradance.transposition import isotropic, haydavies, perez, klucher, reindl, king

# any other symbols used by all irradiance methods

Then break up irradiance into separate modules.
core.py
# code for extraradiation, aoi, etc. that was in irradiance.py

Now when someone wants to add something new to irradiance, they import it into the __init__.py and then either add it to a current module or create a new one.

First, while I don't want to break the API for fun, if it needs to change for the long term health of the library then we should change it. We've broken user code in every 0.x release and I don't intend to stop until we decide on a 1.0. So, don't feel too constrained by the past.
Next, when making the new API docs, it felt pretty natural to break up the irradiance and pvsystem sections into subsections. That's probably a clue that the modules themselves should be chopped up too, though you could certainly take issue with some of the function classifications. I didn't make subsections for atmosphere or clear sky, and I don't think I'd support subpackages for them at this point either. I can imagine a solarposition subpackage that contains spa.py, a new ephemeris.py, and the remaining functionality in core.py. modelchain is long and complicated, but it does something complicated that I don't know how to do otherwise. Some of forecast might end up in iotools.
Concerning implementation, pandas and some other pydata packages use api.py modules instead of __init__.py modules to control their namespaces. I don't know the reasoning behind this other than the "__init__.py should be empty" recommendation, but we should probably look into it.
Finally, we could wait and see if the subpackage approach for io tools actually leads to more people contributing more easily maintained code.

I like the api.py and empty __init__.py idea, very clever. I think the reasoning may be that in general people seem to dislike "dunder" modules and classes probably because they are hard to pronounce, look weird and in general violate the Zen of Python, namely the first 3 lines:

The Zen of Python, by Tim Peters
Beautiful is better than ugly.
Explicit is better than implicit.
Simple is better than complex.

The nice thing about using api.py is that it is very explicit. I usually put this in __init__.py in a commented section called # API. Unfortunately, a Python package has to have __init__.py because that's how Python recognizes packages, but it (__init__.py) can be empty.
I wrote a post that might be related called recommended Python project layout that has links and some of my observations.

Anyone in favor of closing this? I think of this more as a long term strategy discussion than a particular bug that needs fixing or a feature to implement. Maybe continue the discussion in google groups or the wiki?

@mikofski thanks for circling back on this. I agree we should close this.


How to set margin top on all pages?

I created project - https://github.com/golubvladimir/nestjs-generate-pdf
I want to create document with same header on all pages. I created header by element with id pageHeader.
After I set height to 1px in options.
header: {
	height: '1px'
}

I don't know, how to set margin for all pages from header. Now it works only on first page.

I have this problem only on Windows.

I don't think you can set margins explicitly. However, if you apply a margin to the body like so:
body{
  margin: 30px;
}

This will apply a 30px margin around the content inside the document.

It only adds the top margin on 1st page. How to do this at all page


/casket command never loads, only says "OSB is thinking..."

🐛 Bug Report
Happens for any tier, any quantity.

wrong image


Maximum possible value for vjust is too small

The values of vertical text alignment (vjust parameter) are between 0 and 1. But 1 (maximum shift) is sometimes too small to separate points and texts. Look at the example below:
from lets_plot import *
LetsPlot.setup_html()

data = {'x': [0], 'y': [0], 't': ['Point']}

ggplot(data, aes(x='x', y='y')) + \
    geom_point() + geom_text(aes(label='t'), vjust=1)

I think we need either a wider range of admissible values for vjust or a bigger shift corresponding to the value of 1.

We need to support nudge_x, nudge_y parameters (#74).
Also 'label.padding' may help. (https://ggplot2.tidyverse.org/reference/geom_text.html).

We need to support nudge_x, nudge_y parameters (#74).
Also 'label.padding' may help. (https://ggplot2.tidyverse.org/reference/geom_text.html).


Read list of JSON fields encoded in dictionary

add method to get list of fields on InvertedIndexReader

Codecov Report
Patch coverage: 99.12% and project coverage change: +0.01% :tada:

Comparison is base (2d73903) 94.40% compared to head (c3a4015) 94.41%.
Report is 5 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2184      +/-   ##
==========================================
+ Coverage   94.40%   94.41%   +0.01%
==========================================
  Files         322      322
  Lines       63225    63530     +305
==========================================
+ Hits        59688    59983     +295
- Misses       3537     3547      +10

Files Changed
Coverage Δ

src/schema/field_type.rs
78.58% <ø> (ø)

src/core/inverted_index_reader.rs
54.04% <92.30%> (+2.68%)
:arrow_up:

src/aggregation/agg_req_with_accessor.rs
98.25% <100.00%> (+0.05%)
:arrow_up:

src/aggregation/bucket/term_agg.rs
99.14% <100.00%> (+0.03%)
:arrow_up:

src/indexer/mod.rs
100.00% <100.00%> (ø)

... and 12 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Speed up HTTP/2 header iteration

Motivation:
When iterating HTTP/2 headers, the pseudo-headers must always come first in iteration order.
We previously solved this by iterating the headers twice, filtering, and concatenating the two filtered iterations.
This was very slow, but meant we could use the MultiMap pretty much unchanged.
Modification:
Add another pair of linkage references to the entries in the MultiMap.
This doubly-linked list preserves total insertion order, except pseudo-headers are always arranged before normal headers.
We use a handful of fields to keep track of where pseudo-headers start and end, and likewise for normal headers.
For iteration we then use this new chain instead of the bucket-head and entries chains.
Result:
Iteration of HTTP/2 headers is now over 700% faster, but 'add' and 'addAll' methods are slower by 22-44%, when benchmarked with 30 headers.

Visualization of the benchmark results:


Browser chooser

Description of the new feature / enhancement
choose browser to open based on link clicked. Keep default browser unchanged.
Scenario when this would be used?
Some website function well in certain browsers. The user knows this and can set those links or to open up in the right browser
Supporting information
Some solutions exist like https://browserchooser2.com/ but are not maintained well, lack UI and seem complicated for user.

/dup #1642


Issue-add data fetch/clean-up actions

Automated Review Comments
Issues in src/actions/exampleActions.js:

(46, 'Hardcoded string found')
(57, 'Hardcoded string found')

I got it.


Revert shuffling algorithm for block TXs

Motivation
Fixes the error introduced in 1.4.5 that changes the order of the TX shuffle in blocks
Description

reverted shuffle algorithm back to math/rand
shuffling should now behave exactly the same as in 1.4.4

Test Plan

n/a

TODO

[x] Explain motivation or link existing issue(s)
[x] Test changes and document test plan
[x] Update documentation as needed
[x] Update changelog as needed

bors merge


add: support for more than one endpoint

I don't think this needs to be added anymore. These tests are quite heavy so running them on more than 1 endpoint seems quite difficult and inefficient.
Perhaps it could be helpful in the future.


Update code to ensure that currently running job is used a base of bu…

…ilding new job state.
Fix #112

Tested on a new DCOS cluster and no exception was thrown.


Improve README.md

This push request adds direct links from the readme to the wiki and its installation & troubleshooting pages, as well as improves the visual formatting.
I am aware that #16 is working on this same issue, but I wanted to submit this pull request anyway since it also provides a minor visual uplift to the readme.

Thanks!

Thanks!


Writing an infinite loop breaks page until localStorage is cleared

Should probably do something about that.

https://github.com/magwo/elevatorsaga/commit/045d0b247ae2f8f23567ed4085dae8668ec126ea

At least doesn't break page now. Could probably handle infinite loops elegantly by using a web worker that we can terminate, but that's another issue.


Remove Unnecessary Variable

Current Behavior
The variable fd is not used currently.
Expected Behavior
We should remove the variable fd.

@khaIilnafis Thank you for your information.


feat(docs): explain the difference between -tpls and not

Add documentation on the difference between -tpls and the regular
built scripts

Closes #420

Maybe we should link to https://github.com/angular-ui/bootstrap/wiki/FAQ#full-explanation or https://github.com/angular-ui/bootstrap/tree/gh-pages#build-files as well?

That is a good idea - I added in those links to the commit.


AVRO-1882: ConcurrentHashMap with non-string keys fails in Java 1.8

The new MapEntry class removes any dependence on the Map.Entry internal fields which are liable to change between Java versions or between different implementations of Map interface.
Also updated maven-shade-plugin as per this thread

@sachingsachin, this looks fine to me, but I think the maven-shade-plugin change should be done in a separate issue and pull request. Could you open a new issue and separate that change out? Thanks!

@rdblue Removed the shade plugin upgrade. Will open a new ticket and PR for that shortly.

@sachingsachin, I found a couple of other minor things to fix. Once those are done I'll merge this. Thanks for taking the time to fix it!

Thanks @rdblue for looking into this.

@rdblue , its been a month since we collaborated on this.
I have fixed the requested comments.
If you need any help from my side, then let me know.

@sachingsachin, I've committed this. Please close the PR. Thanks for fixing this!

Ryan Blue committed this as https://github.com/apache/avro/commit/420824c13381c4014d102c8e51e231c694ddacf2

@sachingsachin, can you close this PR please? Thanks!


Added Checkers Game

PR Description 📜
Added the Checkers game using HTML, CSS, and JavaScript, bringing the classic board game of strategy and skill to the digital realm.
Checkers, also known as Draughts, is a popular two-player game where opponents strategically maneuver their pieces on a checkered game board.

Fixes #1942

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[x] I have added entries for my game in main README.md
[x] I have added README.md in my folder
[x] I have added working video of the game in README.md (optional)
[x] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

Thank you @abhinav-m22 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Thank you  @abhinav-m22 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Hey @abhinav-m22,
You can't work on a closed issue 👀!
Follow the proper guideline and make a new PR again 😀.
Happy Hacking 💗


Is localtunnel discontinued ?

Due to long time without new version on npm, is localtunnel discontinued?
If so, is there any similar app recomendation ?

Hi @demboscki there is ngrok (similar tool)

try also loophole

FYI ngrok have a simultaneous connnection limit which does not work well with modern apps (on a free tier)

@marcuwynu23 loophole looks some sort of phishing one.
As soon you you run it be it any custom domain you will start receiving requests which will try to access your /.env, /.git/config etc


question about data perturbation

Hello, @xuhongzuo. This is a great work. I am interested with data perturbation(which also called data augmentation in other paper). Data augmentation is a popular work, and this technique is often used in contrastive learning. I noticed that this is used in recent time series anomaly detection work, such as COCA, TFAD. In the paper, you use several simple transformations to generate abnormal samples. Where is the code for this processing?

Great to see u here!
Please see the create_batch_neg function in src/algorithms/couta_algo.py.

@xuhongzuo Thanks.

@xuhongzuo Why not use 1 as a unified anomaly label, but use 1, 2, and 3 to represent collective anomalies, contextual anomalies, and point anomalies respectively? Does this have any impact when doing test evaluation, does the label value represent the importance of the anomaly, and can the anomaly score reflect the type of anomaly?

You find an exceptionally good point!
There is a parameter return_mul_label in this function. We set it as False in our default settings.
During the development of this model, we would like to see whether hierarchical labeling with ordinal regression or multi-class classification can work better than simply binary classification or regression to two extreme values.
Sadly, the empirical results show this modification may fail to bring significantly better results on our datasets. But personally, I think fine-grained labels may give the network clear guidance, this idea is worthy to be explored by investigating new labeling strategies.
Thanks!


overwriting camunda.version does not work (in banner)

I am setting up an example project to test the release candidate. My pom defines camunda.version=7.4.0-SNAPSHOT.
But when I start up a simple SpringBoot application, the banner reads "v7.3.0".
I did not check so far whether this is just an issue with the banner or if I am hard-coded to the 7.3 version.

Probably an issue with the banner. It is filtered during the build to
add the version. My bad! Will fix it!
On 08.09.15 13:04, Jan Galinski wrote:

I am setting up an example project to test the release candidate. My
pom defines camunda.version=7.4.0-SNAPSHOT.
But when I start up a simple SpringBoot application, the banner reads
"v7.3.0".
I did not check so far whether this is just an issue with the banner
or if I am hard-coded to the 7.3 version.
—
Reply to this email directly or view it on GitHub
https://github.com/camunda/camunda-bpm-spring-boot-starter/issues/19.

perfect.

For now I just removed the camunda version


to_rfi() has been modified to use linear gain.

Unit tested. Seems to process our only sample with an existing, different than one linear gain well (the time channel in test/Data004.fcs).

aright looked through code. did not look through tests, tho

I addressed every comment. I'll merge in an hour if there's nothing else.


Fixing graphic = new PIXI.Graphic(); graphic.generateTexture(); throwing errors when using webgl renderer

Was having a nightmare migrating a v3 codebase to v4 until I made this change. Perhaps not the most elegant, but hopefully enough to prompt someone with a better understanding into fixing the generateCanvasTexture function on an un-rendered instance of Graphics while using a WebGL renderer?

13:5  warning  'canvasRenderer' is defined but never used  no-unused-vars

Does just resizing the shared CanvasRenderer when this function is called work? If so, I'd rather do that than create a new one each time this function is called.

I've tried and tried with all variations on resizing the CanvasRenderer/CanvasBuffer/etc but can't get it working without reinstansiating the whole class unfortunately.

Here is a fiddle of essentially copy/pasted of the parts causing the problem. There should be random-ish sized boxes scattered across the canvas in a working example.
http://jsfiddle.net/1py7jgua/2/
Investigations since I reported this have found the culprit, which is that I have a "plugin" i was using which overrided the render function on the webgl and canvas render prototypes. I have a small piece of functionality which is right now at least dependent on overriding that render function, and for some reason is fixed by re-instantiating the canvasRenderer every time.
I would gladly settle for a workaround if this pull request is too detrimental to performance with the re-instantiation change.
Cheeeeeeeeeeers!

Appreciate the help from you awesome guys, and apologies for taking up your time on what is effectively a hack from my part. Alternatively, an undocumented hook into the renderer's render() function would pretty much solve this for me!

the renderers to fire prerender and postrender events when you call render. Is that something that would help?

I think it will! Go ahead and close this, my initial suspicions were that it was a bug with rendering a graphics texture in a webglrender, however it's firmly in the realm of "I can change things on my end" now.
Big ups, you guys are awesome and thanks again for the help! Been using pixi since v2 and won't be stopping any time soon.
You can go ahead and close this 👍 ❤

Your most welcome!


Update docs

What?
I've executed the ./generate_docs.sh script because I've noticed that docs were out of date.
I would advise that every public facing method has comments in the following way so that docs generator can use them, and generate documentation.
Why?
To keep the docs up to date and reduce the confusion.
#beamsteam ❤

CC @pusher/mobile

Closing due to inactivity.


fix localization/Dockerfile to prevent orjson build error

Fix localization/Dockerfile to prevent orjson build error.
pip3 install orjson fails after the recent update of orjson v 3.10.7 released today August 9, 2024.
This change specifies orjson==3.10.6 as a quickfix
Collecting orjson
  ...
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... error
  error: subprocess-exited-with-error

  × Preparing metadata (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [6 lines of output]

      Cargo, the Rust package manager, is not installed or is not on PATH.
      This package requires Rust and Cargo to compile extensions. Install it through
      the system's package manager or via https://rustup.rs/

      Checking for Rust toolchain....
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

Another way to fix orjson installation error.
Installing cargo and maturin before pip install orjson
sudo apt install cargo
sudo pip3 install maturin

Installing cargo on localization docker image requires additional 392 MB disk space.
The following additional packages will be installed:
  libssh2-1 libstd-rust-1.75 libstd-rust-dev rustc
Suggested packages:
  cargo-doc llvm-17 lld-17 clang-17
The following NEW packages will be installed:
  cargo libssh2-1 libstd-rust-1.75 libstd-rust-dev rustc
0 upgraded, 5 newly installed, 0 to remove and 344 not upgraded.
Need to get 98.2 MB of archives.
After this operation, 392 MB of additional disk space will be used.


Fix android crash issue due to wrong refcount abort on A770/A750

The issue root-caused to different compilers' behavior of unique_ptr deletor clang set nullptr firstly and do destruction, but gcc is the opposite.
Tracked-On: OAM-122042

Improper Commit Message
Tracked on not found in commit message,
make sure Tracked-On: Jira-ticket  is present.

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web  for more details.

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web  for more details.

Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web  for more details.


How to show debug track as counter by SQL query result?

As Title.
I am trying to show debug track as counter by SQL query result.
However, it shows like slice view..
Can I show produced query reslut as counter view?
For example, add two original counters at the same time and shows by new debug track.

No this is not currently supported. One workaround is to convert counters to slices and visualize them that way.

Thanks,
Do you have plan to provide line chart like view?
or have some post-editor function for calculating between counters? like counter a / counter b *100 = % of usage.

Do you have plan to provide line chart like view?

At some point yes but it's not too high on our priority list.

Thanks for your kind work


When using flutter for web: Not using HTTPS for downloading of fonts

VM1101:1 Mixed Content: The page at 'https://myappname.codemagic.app/#/' was loaded over HTTPS, but requested an insecure XMLHttpRequest endpoint 'http://fonts.gstatic.com/s/baloobhaijaan/v6/RWmRoKCU5fcqq8fOWNzFLqSjx4ECJmVjC0-V.ttf'. This request has been blocked; the content must be served over HTTPS.

I'm going to do some testing locally to make sure I did not make this in error. My version is pretty far behind, so this might have already been fixed.

Already fixed. Sorry to have filed unnecessarily.


chore: install psc-package via a NPM script

Checklist

[x] the [contributor license agreement][] is signed
[x] commit message follows [commit guidelines][]
[ ] tests are included
[ ] screenshots are included showing significant UI changes
[ ] documentation is changed or added

Description of change
With NPM 7 psc-package is not installed properly. So we created a new NPM script which will downloaded the package and use it.

Looks pretty good, may just want to tweak description to also mention this was triggered due to issues with renovate.

Can I mention this was triggered due to issues with renovate in the merge commit ?

Good to have both places. At least if you just duck up and edit the merge request description it'll be there nice and loud for if we need to reference back to it. And then if you put it in the merge commit it will be nicely there for future prosperity on the quite.

Good to have both places. At least if you just duck up and edit the merge request description it'll be there nice and loud for if we need to reference back to it. And then if you put it in the merge commit it will be nicely there for future prosperity on the quite.

Cool. I have updated the PR description.

Ah GHA is still using NPM 6...

Failed on pulp build...
> pulp build

* Building project in /home/penghai/Edalex/forks/openEQUELLA/autotest/IntegTester/ps
* ERROR: `psc-package` executable not found.


Changed reviews count data format

@sksshouvo I don't understand why you want reviews_count to be a String and not an Integer? Can you please explain why you want to do the change? Also for this to work, you also need to change the datatype in the Business dataclass (we have: reviews_count: int = None)

@sksshouvo I don't understand why you want reviews_count to be a String and not an Integer? Can you please explain why you want to do the change? Also for this to work, you also need to change the datatype in the Business dataclass (we have: reviews_count: int = None)

@amineboutarfi Because when I run the Python script, playwright opens up google chromium with my native language "Bengali" and the number are also in bengla so it returns error.

@sksshouvo makes sense yes. Please update the dataclasee in your PR to also change:
reviews_count: int = None -> reviews_count: str = None
Also don't include CSVs and xlsx in your PR if possible


JSON Lines support?

Describe the bug
I am not able to open a .jsonl file or opening json lines from pasteboard.
To Reproduce
Steps to reproduce the behavior:

Try to open any .jsonl file.
Open dialog does not allow opening file with .json file extension
Try to open json lines using the "New from Pasteboard" option
Got an error saying No valid JSON string is found in pasteboard

Expected behavior
Able to open jsonl file or content
Screenshots

Opening jsonl files will be supported in the next version.


fix: add more browsers to test in

Based upon the browsers we want to support: http://docs.hood.ie/en/hoodieverse/system-requirements-browser-compatibilities-prerequisites-before-getting-started-with-hoodie.html
Does not add IE as our tests wont run on IE for some reason.
:baby_chick:

cool! :ok_hand:


Better PistonAura

maybe a new and better pistonaura with firebypass idk

mmm

who tf uses piston aura meta lol, better remove piston aura. (use gs++ if you use that shitty asf meta)

piston push would be nice as well


Memo comments are listed in memo list

Describe the bug
Hey,
so either this is a undocumented new feature, or it accidentally changes toward 0.18.0:
In the "home" tab memo comments are now listed besides the actual memos

I do understand, that it might be useful to have it like this, but it removes any kind of structure one had with the comments.
I'm using the SQLite backend.
Steps to reproduce
Have a lot of comments on memos
Update to 1.18.0
Open Home Tab
The version of Memos you're using
v0.18.1
Screenshots or additional context
No response

Similar issue here about this same bug: https://github.com/usememos/memos/issues/2595#issue-2034421230
I am also able to recreate this behavior in v0.18.1

Is this a bug rather than a feature?
After upgrading to v0.18.2, I noticed that comments no longer appear in the timeline.
I really love this feature. Can we have an option to choose whether to display it or not?


Feat/freerdp last error name

Added new functions allowing the retrieval of an error name and description similar to the one already present for ERRINFO_*

+1

I think this is rather useful ;).
+1


Remove extra \

Docker warns about empty continuation lines in the newest version.
[WARNING]: Empty continuation lines will become errors in a future release

also fixed in https://github.com/jonas747/yagpdb/pull/434


Exception message in Zend\Stdlib\AbstractOptions should use the actual used setter

The current exception message uses some fabricated setter which is not even used in the actual test in Zend\Stdlib\AbstractOptions line 103.
This PR changes the exception message and makes it use the actual used setter and thus creates a more accurate message. See: https://github.com/zendframework/zf2/issues/7155#issuecomment-71451833

Was thinking about changing the value of $setter itself, but it seems the usage of an actual different $setter value was a minor performance tweak added in https://github.com/zendframework/zf2/commit/f07104142881de54c1131ebb5fabca781f532563.

I know I'm pedantic here, but can haz test?

I added a test for the exception message, but I may hope nobody uses the exception message itself as a way to test which exception is thrown.

may hope nobody uses the exception message itself as a way to test which exception is thrown

Yeah, it's not about that, it's mainly about the usual "cast to string" and such errors ;-)

@Martin-P merged, thanks!
Had to manually apply changes to the develop rebase due to conflicts, no big deal tho.
master: zendframework/zf2@49f3986a5e450f758dc5d337f8e08904c8c3613b
develop: zendframework/zf2@5d6570fda809c68c829e49ca56b599f6972e81bf


fix: schema path checks

fix the getSchema function

Run report for c2a1f608
Total time: 10s | Comparison time: 10.9s | Estimated savings: 853.7ms (7.9% faster)

Action
Time
Status
Info

🟩
SyncWorkspace
0ms
Passed

⬛
SetupNodeTool(~20.12)
1.2s
Skipped

🟩
InstallNodeDeps(~20.12)
7.4s
Passed

🟩
SyncNodeProject(componentSchemas)
0.2ms
Passed

🟩
SyncNodeProject(root)
0.2ms
Passed

🟥
RunTask(componentSchemas:test)
1.4s
Failed

🟩
RunTask(root:test)
1.3s
Passed

Touched files
packages/component-schemas/index.js
packages/component-schemas/test/index.test.js

@GarthDB I cannot reproduce the failing tests locally. It is fine on my machine. Do you know why this fails in the git action env?
Local log:
➜  component-schemas git:(karstens/fix--schema-paths-check) ✗ pnpm moon run :test
▪▪▪▪ tokens:buildTokens (cached from previous run, 8e486338)
▪▪▪▪ componentSchemas:test
▪▪▪▪ root:test
componentSchemas:test |
            root:test |
componentSchemas:test |   ✔ index › getSlugFromDocumentationUrl should return last part of documentationUrl
componentSchemas:test |   ✔ index › getSlugFromDocumentationUrl should return last part of documentationUrl even without trailing slash
componentSchemas:test |   ✔ index › the number of schema returned by getAllSchemas should match the number of schema returned by schemaFileNames
componentSchemas:test |   ✔ index › getAllSlugs should return all component slugs
componentSchemas:test |   ✔ index › getSchemaBySlug should return a schema
componentSchemas:test |   ✔ index › getSchemaFile should fetch schema data
            root:test |   ✔ validate github workflow config files
            root:test |   ─
            root:test |
            root:test |   1 test passed
▪▪▪▪ root:test (1s 33ms, a601bc9d)
componentSchemas:test |   ✔ componentSchemaValidator › Every component schema should validate against the definition
componentSchemas:test |   ✔ componentSchemaValidator › component examples should validate against the definition
componentSchemas:test |   ✔ componentSchemaValidator › component schema should be valid
componentSchemas:test |   ─
componentSchemas:test |
componentSchemas:test |   9 tests passed
▪▪▪▪ componentSchemas:test (1s 117ms, 6a0eb89c)
▪▪▪▪ csvGenerator:test (cached from previous run, 1309f047)

  ✔ basic test
  ─

  1 test passed
▪▪▪▪ tokens:test (cached from previous run, b2011540)

  ✔ deprecateExpress › Deprecate Express should add deprecation metadata to Express tokens
  ✔ drover › Drover should match light variable values
  ✔ drover › Drover should match dark variable values
  ✔ drover › Drover should match darkest variable values
  ✔ checkManifest › check for uuids
  ✔ checkComponentProps › ensure all component tokens are have component data
  ✔ checkId › ensure uuids are unique
  ✔ checkPrivate › ensure all color-palette.json tokens are private
  ✔ schemaValidators › alias › Every token schema should validate against the definition
  ✔ tokenSchemaValidator › Every token should have a $schema property
  ✔ tokenSchemaValidator › Every token schema should validate against the definition
  ✔ tokenSchemaValidator › Schema should compile without errors
  ✔ checkUniqueTokenNames › check for duplicate token names across all token files (268ms)
  ─

  13 tests passed

Tasks: 5 completed (3 cached)
 Time: 1s 562ms

I'm merging this and I'll look at fixing it in the other branch.


Whim does not detect PWAs minimizing/closing

Is there an existing issue for this?

[X] I have searched the existing issues

Behavior
When closing PWA or electron windows on Windows 10, Whim does not trigger a layout.
Config
N/A

Environment
Windows 10 21H2
Steps To Reproduce
N/A
Anything else?
No response

Whim doesn't handle the minimization of windows.


Issue with the video player appearance

Media player takes the whole height of the screen

Apologies for the long period of inactivity on this project. I wanted to inform you that the plugin has been fully rewritten for the v3 release. I'm currently preparing for the beta release. Once it's available, if you encounter similar issues, please don't hesitate to open a new issue. Thank you for your understanding.


PRAW4 To Do List

This list is intended to be updated over time. Some of these items should be broken up into smaller chunks.
If you would like to work on any of the items or a subset of the items please claim it with a comment. We will try to update the associated item with your name within a 24 hour window. All pull requests should be made against the praw4 branch, and should only introduce a single addition (e.g., tests for a single method, porting of one function along with its tests, a documentation page).

[x] 100% test coverage for existing code in praw4 branch
[x] Add BaseList unit tests ref
[x] Refactor WikiPageList to be a wiki attribute on Subreddit objects. Iterating through the wiki pages should be as easy as for wikipage in subreddit.wiki. Fetching a single page should be subreddit.wiki['pagename']. Creating a page might look like subreddit.wiki.new(...).
[x] Refactor Submission flair such that flair submission.flair is its own object.
[x] Test submission hide and unhide.
[x] Moderator actions on a submission should be accessible through submission.mod... for example submission.mod.contest_mode, submission.mod.suggested_sort.
[ ] Fresh documentation
[ ] Port all OAuth features from PRAW < 4 with 100% code coverage

Hello bboe, may I work on the "Fresh documentation" item, please?

@zhifuge, yes please do. Whatever you think would help to make things easier would be very appreciated. If you have questions you can ask here or on the gitter chat: https://gitter.im/praw-dev/praw

Hi zhifuge, Bryce and I came up with a brief proposal previously (see here: https://docs.google.com/document/d/1DmrMsjPrg2qFkC199AczAEvWNZg-Kpq9SS4LoJEjl44/edit?usp=sharing).
Feel free to claim any sections here or just put your name in brackets on the doc.

Hi @DCuddies, I will start with the QuickStart (Getting Started) section.

@zhifuge
Just to clarify a few things.
The reply bot tutorial (https://github.com/praw-dev/praw/blob/praw4/docs/pages/reply_bot.rst) is going to make up the bulk of the getting started section, just because it encompasses most basic praw uses.
However, it'll need to be reformatted, and should include the other things mentioned in the Google Doc above (requirements, etc.) for a final version. So if that's what you'd like to do, go for it!

@DCuddies
Yep! I will try my best. Thanks for the help!


refactor(ast): add line breaks

Code style nit. Add line breaks between some impls.

#3860  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on  Graphite

Trivial change, so merging without review.


Ability to enter manual tuning frequency

The presets are nice but I would find it very useful to enter manual values such as A=399 etc

I note that this is possible via the generic UI on LV2 but on VST this is currently not possible.

Also add to this ability to enter manual volume amount in top right corner.

Also add to this ability to enter manual volume amount in top right corner.

#599
it was made possible to edit tuning frequency using the mouse wheel.

#599
it was made possible to edit tuning frequency using the mouse wheel.


httpreq: unexpected status code: [status code: 400]

Bug Description
While setting up httprequest-lego-k8s charm with nginx-ingress-integrator (v 24.2.0), we're getting a 400 error:

ERROR unit.httprequest-lego-k8s/0.juju-log     2024/09/13 14:08:27 [WARN] [XXX] acme: cleaning up failed: httpreq: unexpected status code: [status code: 400] body: <!doctype html>
ERROR unit.httprequest-lego-k8s/0.juju-log
ERROR unit.httprequest-lego-k8s/0.juju-log
ERROR unit.httprequest-lego-k8s/0.juju-log       <title>Bad Request (400)</title>
ERROR unit.httprequest-lego-k8s/0.juju-log
ERROR unit.httprequest-lego-k8s/0.juju-log
ERROR unit.httprequest-lego-k8s/0.juju-log
Bad Request (400)

ERROR unit.httprequest-lego-k8s/0.juju-log
ERROR unit.httprequest-lego-k8s/0.juju-log
ERROR unit.httprequest-lego-k8s/0.juju-log     2024/09/13 14:08:27 [INFO] Deactivating auth: `https://acme-v02.api.letsencrypt.org/XXX`
ERROR unit.httprequest-lego-k8s/0.juju-log     2024/09/13 14:08:27 Could not obtain certificates:
ERROR unit.httprequest-lego-k8s/0.juju-log     	error: one or more domains had a problem:

How can I resolve this?
To Reproduce
juju deploy httprequest-lego-k8s
juju config httprequest-lego-k8s
juju integrate httprequest-lego-k8s nginx-ingress-integrator
Environment
httprequest-lego-k8s charm is  channel latest/stable , rev  83
Juju controller is 3.5.3, deployed on PS6
Relevant log output
https://pastebin.canonical.com/p/YRMy5VRZGZ/

Additional context
No response

Hi @nsakkos , I'll do my best to help here, but just a heads up I'm only familiar with this charm at a high level, so bear with me.
It looks to me like the Challenge Solver is the thing throwing the error.  This would be whatever you set for httpreq_endpoint in the charm config.
Are you sure that is configured and working correctly? I would presume there are some logs on that service that might help us narrow down what the issue is.

Hi @nsakkos -- I just wanted to bump this and see if you were able to resolve your issue or if you still need any help?

It has been a couple weeks and we don't have enough information to move forward, so I am closing this.
@nsakkos if this becomes an issue again in the future, please feel free to re-open or create a new issue.


control tracing at run time

I'm trying to change the level of tracing at run time (in python). The idea is to be able to turn on/off the tracing in a server without having to restart it (for troubleshooting purposes).
It seems the GRPC_TRACE env is only read once during grpc_init(), and not tracked afterwards.
If tracking is not acceptable, maybe exposing grpc_tracer_init to the API would be better?

It would take a lot to convince me that tracking is worthwhile (it would be quite expensive).
I have considered something like:
grpc_tracer_set_enabled(const char *name, intended enabled);
To allow fine grained control at runtime of individual trace variables.

indeed, when I wrote the op, I already knew tracking would not be acceptable for the reason you mentioned, and it's probably not even needed for this use case. Hence the request for an API.
Your grpc_tracer_set_enabled() proposal would be nice, esp if it came with another method to list the supported traces (which seem dynamic, in the C code).
I see parse() called by grpc_tracer_init() is complaining when an unknown variable is passed in. That should probably be reported as an error code or something..


Move Merkle ledger tests to Alcotest

Compatible version of https://github.com/MinaProtocol/mina/pull/15744

!ci-build-me

!ci-build-me