SRT component

A simple SRT component is very helpful.
If it's shown in an example along with a audio player component that are synced so on scrubbing the player, srt is also adapted, that'd great.
It should also be synced on audio speed (#221)

I guess this one stays in the client project, right?


logged out fair guide scroll view weirdness

From @1aurabrown on July 9, 2014 22:5
Looking through the fair changes, some things i noticed:

on first scroll after entering the personalized guide, scroll view jumps at first (this is visible in both gifs)
dragging up results in the scroll indicator jiggling around (see gif 1)
scroll view has a much bigger height than the actual content, all the content fits well within the bounds of the screen but there is a ton of white space under the content. (see gif 2)
dragging down, the scroll indicator looks pretty weird as a floating bar midway between the top and bottom of the screen -- i propose we just turn off scroll indicators for this view. (see gif 2)

subjective things i noticed but that are not urgent for this release:

when i drag down, my expectation is to enter the expanded map view, but this expectation is not met
i expect to be able to pan the map without entering the expanded map view
i think both these last two things things used to be possible, i'm assuming we changed them for a reason.

Copied from original issue: artsy/eigen-private#1850

The big weird one here IMO is that you can contact the map when you're logged out, doesn't make sense.

no longer relevant


OAuth2 Password Grant possible bug?

Hi,
I'm trying to implement oauth2 password grant by following the docs. When I try to run
http://localhost:3000/oauth/token

POST /oauth/token HTTP/1.1
Host: myapi.com
Content-Type: application/x-www-form-urlencoded
Authorization: Basic <Base64UrlSafe(apiKeyId:apiKeySecret)>

grant_type=password
<EMAIL_ADDRESS>&password=theirPassword

I get back an invalid_request error. However when I try run
https://api.stormpath.com/v1/applications/<APP_ID>/oauth/token

POST /oauth/token HTTP/1.1
Host: myapi.com
Content-Type: application/x-www-form-urlencoded
Authorization: Basic <Base64UrlSafe(apiKeyId:apiKeySecret)>

grant_type=password
<EMAIL_ADDRESS>&password=theirPassword

I get back the intended response.

Hey there!
The OAuth password grant on the express integration is intended on being used by mobile and/or frontend web clients. Thus you DO NOT need to authenticate with your Stormpath API Keys to this endpoint.
You should be able to get OAuth password grant working if you remove the Authorization header in your above mentioned request =]
Let us know if this works for you!

hey @edjiang,
Thanks for the fast response, I tried that initially, but it was giving me back an invalid request.
POST /oauth/token HTTP/1.1
Host: localhost:3000
Content-Type: application/x-www-form-urlencoded
Cache-Control: no-cache

grant_type=password&username=test%40mail.com&password=password

init code:
app.use(stormpath.init(app, {
  expand: {
    customData: true
  },
  web: {
    produces: ['application/json']
  }
}));

Any ideas?

Figured it out. It works if it's json instead of x-www-form-urlencoded:
POST /oauth/token HTTP/1.1
Host: localhost:3000
Content-Type: application/json
Accept: application/json
Cache-Control: no-cache

{
  "grant_type" : "password",
  "username"<EMAIL_ADDRESS>  "password" : "password"
}

Is there an error in the docs? http://docs.stormpath.com/nodejs/express/latest/authentication.html#oauth2-password-grant

No, that's really weird. This endpoint should respond to what you're posting. The only thing I can think is that the @ sign shouldn't be percent encoded? I'll have to take a look tomorrow.

I have a hosted version of express-stormpath you can try hitting at https://stormpathnotes.herokuapp.com. See if you can register and use the OAuth endpoint on there? Code for mine at https://github.com/stormpath/stormpath-express-mobile-notes-example

Ah! I was talking with someone else about a similar issue and figured out (most likely) what's going on with your issue. Are you using body-parser elsewhere in your application? If so, I noticed it messing with the express-stormpath routes for some reason. I'll ask @robertjd to take a futher look into it tomorrow.
Anyways, make sure in your app, either bind body-parser after the stormpath middleware, or, just add:
app.use(bodyParser.json())
app.use(bodyParser.urlencoded({extended: false}))


Issue with /api/docs - server error

Bug description
Server error using "Try it out" for POST in Chat.
Instead of the servers response from the AI we get a "Server Error"
Steps to reproduce
Navigate to http://localhost:8008/api/docs#/chat/ask_a_question_chat__chat_id__question_post
Run a request to a chat ID with chat posting to the API.
Get error.
Environment Information
Standard Docker
Docker version 23.0.3, build 3e7cbfd
Screenshots

Relevant log output
llama_model_load_internal: mem required  = 9807.56 MB (+ 1608.00 MB per state)
llama_init_from_file: kv self size  =  400.00 MB
AVX = 1 | AVX2 = 1 | AVX512 = 1 | AVX512_VBMI = 1 | AVX512_VNNI = 1 | FMA = 1 | NEON = 0 | ARM_FMA = 0 | F16C = 1 | FP16_VA = 0 | WASM_SIMD = 0 | BLAS = 0 | SSE3 = 1 | VSX = 0 |
llama_print_timings:        load time =  6652.89 ms
llama_print_timings:      sample time =     5.39 ms /     9 runs   (    0.60 ms per run)
llama_print_timings: prompt eval time =  6652.85 ms /    48 tokens (  138.60 ms per token)
llama_print_timings:        eval time =  1904.38 ms /     8 runs   (  238.05 ms per run)
llama_print_timings:       total time =  8563.56 ms
INFO:     <IP_ADDRESS>:47420 - "POST /chat/2424af64-773a-4585-85f6-8a2810f7c548/question?prompt=Hello HTTP/1.1" 500 Internal Server Error
ERROR:    Exception in ASGI application
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/uvicorn/protocols/http/httptools_impl.py", line 435, in run_asgi
    result = await app(  # type: ignore[func-returns-value]
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/uvicorn/middleware/proxy_headers.py", line 78, in __call__
    return await self.app(scope, receive, send)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/fastapi/applications.py", line 276, in __call__
    await super().__call__(scope, receive, send)
  File "/usr/local/lib/python3.11/site-packages/starlette/applications.py", line 122, in __call__
    await self.middleware_stack(scope, receive, send)
  File "/usr/local/lib/python3.11/site-packages/starlette/middleware/errors.py", line 184, in __call__
    raise exc
  File "/usr/local/lib/python3.11/site-packages/starlette/middleware/errors.py", line 162, in __call__
    await self.app(scope, receive, _send)
  File "/usr/local/lib/python3.11/site-packages/starlette/middleware/cors.py", line 92, in __call__
    await self.simple_response(scope, receive, send, request_headers=headers)
  File "/usr/local/lib/python3.11/site-packages/starlette/middleware/cors.py", line 147, in simple_response
    await self.app(scope, receive, send)
  File "/usr/local/lib/python3.11/site-packages/starlette/middleware/base.py", line 109, in __call__
    await response(scope, receive, send)
  File "/usr/local/lib/python3.11/site-packages/starlette/responses.py", line 270, in __call__
    async with anyio.create_task_group() as task_group:
  File "/usr/local/lib/python3.11/site-packages/anyio/_backends/_asyncio.py", line 662, in __aexit__
    raise exceptions[0]
  File "/usr/local/lib/python3.11/site-packages/starlette/responses.py", line 273, in wrap
    await func()
  File "/usr/local/lib/python3.11/site-packages/starlette/middleware/base.py", line 134, in stream_response
    return await super().stream_response(send)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/starlette/responses.py", line 262, in stream_response
    async for chunk in self.body_iterator:
  File "/usr/local/lib/python3.11/site-packages/starlette/middleware/base.py", line 98, in body_stream
    raise app_exc
  File "/usr/local/lib/python3.11/site-packages/starlette/middleware/base.py", line 70, in coro
    await self.app(scope, receive_or_disconnect, send_no_error)
  File "/usr/local/lib/python3.11/site-packages/starlette/middleware/exceptions.py", line 79, in __call__
    raise exc
  File "/usr/local/lib/python3.11/site-packages/starlette/middleware/exceptions.py", line 68, in __call__
    await self.app(scope, receive, sender)
  File "/usr/local/lib/python3.11/site-packages/fastapi/middleware/asyncexitstack.py", line 21, in __call__
    raise e
  File "/usr/local/lib/python3.11/site-packages/fastapi/middleware/asyncexitstack.py", line 18, in __call__
    await self.app(scope, receive, send)
  File "/usr/local/lib/python3.11/site-packages/starlette/routing.py", line 718, in __call__
    await route.handle(scope, receive, send)
  File "/usr/local/lib/python3.11/site-packages/starlette/routing.py", line 443, in handle
    await self.app(scope, receive, send)
  File "/usr/local/lib/python3.11/site-packages/fastapi/applications.py", line 276, in __call__
    await super().__call__(scope, receive, send)
  File "/usr/local/lib/python3.11/site-packages/starlette/applications.py", line 122, in __call__
    await self.middleware_stack(scope, receive, send)
  File "/usr/local/lib/python3.11/site-packages/starlette/middleware/errors.py", line 184, in __call__
    raise exc
  File "/usr/local/lib/python3.11/site-packages/starlette/middleware/errors.py", line 162, in __call__
    await self.app(scope, receive, _send)
  File "/usr/local/lib/python3.11/site-packages/starlette/middleware/exceptions.py", line 79, in __call__
    raise exc
  File "/usr/local/lib/python3.11/site-packages/starlette/middleware/exceptions.py", line 68, in __call__
    await self.app(scope, receive, sender)
  File "/usr/local/lib/python3.11/site-packages/fastapi/middleware/asyncexitstack.py", line 21, in __call__
    raise e
  File "/usr/local/lib/python3.11/site-packages/fastapi/middleware/asyncexitstack.py", line 18, in __call__
    await self.app(scope, receive, send)
  File "/usr/local/lib/python3.11/site-packages/starlette/routing.py", line 718, in __call__
    await route.handle(scope, receive, send)
  File "/usr/local/lib/python3.11/site-packages/starlette/routing.py", line 276, in handle
    await self.app(scope, receive, send)
  File "/usr/local/lib/python3.11/site-packages/starlette/routing.py", line 66, in app
    response = await func(request)
               ^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/fastapi/routing.py", line 237, in app
    raw_response = await run_endpoint_function(
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/fastapi/routing.py", line 163, in run_endpoint_function
    return await dependant.call(**values)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/serge/routers/chat.py", line 248, in ask_a_question
    history.add_ai_message(answer)
  File "/usr/local/lib/python3.11/site-packages/langchain/memory/chat_message_histories/redis.py", line 59, in add_ai_message
    self.append(AIMessage(content=message))
                ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "pydantic/main.py", line 341, in pydantic.main.BaseModel.__init__
pydantic.error_wrappers.ValidationError: 1 validation error for AIMessage
content
  str type expected (type=type_error.str)
INFO:     <IP_ADDRESS>:57980 - "GET /chat/2424af64-773a-4585-85f6-8a2810f7c548 HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:57980 - "GET /chat/ HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:57980 - "GET /chat/2424af64-773a-4585-85f6-8a2810f7c548 HTTP/1.1" 200 OK

Confirmations

[X] I'm running the latest version of the main branch.
[X] I checked existing issues to see if this has already been described.

I'm getting this too. Running on an Ampere server, noticed it a week or two ago when my API calls started 500ing. I've had success making new chats and seemingly generating text, but the API fails when it's time to respond to the POST request.
I would post my docker logs, but they look the exact same as OP's.

Same issue here.
The UI works just fine.
The POST route always return an Internal Server Error with the above message. The GET question route works fine but of course the streaming response is quite an inconvenience to work with.
As reported @toasterrepairman I would post my docker log but it is the exact same as the one posted by @snxraven

Any update on this bug?

I've got the same problem. Right now the API is basically not usable sadly.

I'm looking into this issue

@snxraven @odieXin @Kastakin @Kastakin @nsarrazin Fix has bedn pushed. It's available using the main tag until a new release is done.
docker pull ghcr.io/nsarrazin/serge:main


Close panel when touching the shadow

Is it possible to close the panel when the user touches the shadow?

One workaround could be to override dispatchTouchEvent in your activity/fragment view and check if the event is on the shadow or not

Thanks Dany!
To be honest, I was surprised that this is not the default behavior.
When we use an anchor point, is very intuitive try to touch at the shadow to close the panel.
For now, I removed the shadow. It seems that this way is less confusing.

Dupe of https://github.com/umano/AndroidSlidingUpPanel/issues/476

FIxed in https://github.com/umano/AndroidSlidingUpPanel/commit/b69a6bf77e7c9e702815893f85b21703141701e2
Will be released in 3.3.0


Small cleanup

The unreachable code was reachable!

how this even possible or better say where?
Why not hardcoded zero for height?
I think that this may be an issue and height should be ignored.

e.g. call let height = ctx.height(); here
We can use the actual height.
What do you think the issue might be?

Check your URL. There is no such code
Ok
Hard to explain. It more about feeling that what piece of code need height? I don't remember where in params we use height. And the only reason for this context to exists is to read params from store when we create app.
I don't think it's weird to use actual height, but found it strange

I'm saying you could put that code there, then the unreachable code is reached.
I see what you mean, but the reality is it does expose a height method so it's best that it returns a "sensible" height.

If it worries you then see no issue. Last thing, I would ask why you use version of multi store not app block height

In new? The app block height hasn't been set at that point. In fact it gets set to the same height a few lines later.

Not only. We use SimpleContext to read consensus params

There we do use the app block height.

I get it now. There no other "issue"


Add composer repository

This adds a packages.json file which can be read over HTTP from Github by Composer. The previous installation method still works. This packages.json file is maintained manually.
This makes Uplink-PHP behave more like a normal PHP library. This has advantages for a PHP developer managing their project:

composer update can automatically update Uplink-PHP to the latest version

If we release versions which depend on different PHP versions or different PHP libraries, Composer will select the version most compatible with your project.
Unfortunately composer currently only does a limited check on platform compatibility which does not include OS type, instruction set architecture, and glibc version.

I tested this in a project with commands:
composer config repositories.storj/uplink '{
    "type": "composer",
    "url": "https://raw.githubusercontent.com/storj-thirdparty/uplink-php/composer-repository/"
}' &&
composer require storj/uplink

Then it installs v1.3.0. Then I tried out all the released versions:
composer require storj/uplink:0.1.0
composer require storj/uplink:1.0.0
composer require storj/uplink:1.1.0
composer require storj/uplink:1.2.0
composer require storj/uplink:1.3.0

Solves https://github.com/storj-thirdparty/uplink-php/issues/35

Asked Brandon to add Clement to the org.


Fix ActivityWatcher getting registered for Dialog events multiple times

Jira issue:
https://glia.atlassian.net/browse/MOB-2181
Additional info:
ActivityWhatcherForCallVIsualizer was failing to unregister the callback for Glia Alerts because of race condition - it created a new callback and overrode the old one before unregistering the old one from DialogController
Screenshots:

Interesting case.

!merge


VueJS docs need a list of events

There's a few events missing from the documents

@change
@blur

Possibly more events.
I didn't find it in the documents and had a hard time finding the difference between @input and @change (input fires immediately, change fires off when user clicks on a different target)
It would be nice to see a table side by side diagram, showing the conventions used in vue compared to HTML Dom events found here
https://www.w3schools.com/jsref/dom_obj_event.asp

They are just native DOM events. But be aware that different events are triggered on different elements and you should make sure to check what events are supported on the specific element you are using.


Suggestion: Link to package manager instructions?

Right now we link to distribution installation instructions for Node.js and Python. For many end users who aren't familiar with these languages, but are comfortable with a package manager based installation instructions, it may not be evident that they can do so. This is particularly true for Linux where the pages we link to encourage you to install from a tarball or source. But even for, say, macOS, a lot of people will probably want to go with Brew instead.
Should we consider at least mentioning that package managers are an option? I hate to clutter up the pages but I almost wonder if these are better pages to link to, especially for Linux

Node.js: https://nodejs.org/en/download/package-manager/
Python: https://realpython.com/installing-python/

For what it's worth, I just went through installing on a clean Linux container, and those resources were far more helpful than the ones we link to (IMHO).

Additional notes:
pip isn't always installed by default. For example, after apt-get install python3.6, I still had to run apt-get install python3-pip on Ubuntu.
Also, our instructions assume you've installed virtualenv. I don't think that's ever installed by default. You will need to run pip3 install virtualenv (we should list in instructions).


CuboCore.packages: 4.2.0 -> 4.3.0

Motivation for this change
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@ofborg build CuboCore.corekeyboard
@ofborg build CuboCore.corepdf
@ofborg build CuboCore.corestuff

The above 3 packages failed to build on x86_64-linux:
corekeyboard https://logs.nix.ci/?key=nixos/nixpkgs.152579&attempt_id=f5b4c2e6-f423-46b9-9b31-0489d4593cba
corepdf https://logs.nix.ci/?key=nixos/nixpkgs.152579&attempt_id=ad9bf2cf-be56-4270-af86-7e12322305d4
corestuff https://logs.nix.ci/?key=nixos/nixpkgs.152579&attempt_id=25998c4d-497e-4ea1-9b22-25a73072dabd

Strange, I checked everything was build.. I don't have a laptop with me right now. I can fix it only in a week.

The above 3 packages failed to build on x86_64-linux:
corekeyboard https://logs.nix.ci/?key=nixos/nixpkgs.152579&attempt_id=f5b4c2e6-f423-46b9-9b31-0489d4593cba corepdf https://logs.nix.ci/?key=nixos/nixpkgs.152579&attempt_id=ad9bf2cf-be56-4270-af86-7e12322305d4 corestuff https://logs.nix.ci/?key=nixos/nixpkgs.152579&attempt_id=25998c4d-497e-4ea1-9b22-25a73072dabd

I did not have a lot of delayed, now I will try to solve the problem, generally strange I kind of when I felt the commote checked all the packages all mischilding.

All fixed.


Tablet UploadDownload errors compiling

I am currently getting errors when trying to compile the tablet upload and download they can be found below...
Also the tutorial is inaccurate it says:
Copy the downloaded Tablet\UploadDownload\src\webworks directory to your new ext\webworks.io.filetransfer\webworks director
but there is no Tablet\UploadDownload\src\webworks there is only Tablet/UploadDownload/src/Air
Also has anyone got this running on a play book or not?
Everything is Ok
[INFO]                  Parsing command line options
[INFO]                  Parsing bbwp.properties
[INFO]                  Validating WebWorks archive
[INFO]                  Parsing config.xml
[INFO]                  Populating application source
[INFO]                  Compiling WebWorks application
C:\Users\Ludger\AppData\Local\Temp\widgetGen.1015230081323025446362.tmp\webworks
\io\filetransfer\FileTransferExtension.as(148): col: 18 Error: Access of possibl
y undefined property jsObject through a reference with static type webworks.exte
nsion:WebWorksReturnValue.
                    return result.jsObject;
                                  ^

C:\Users\Ludger\AppData\Local\Temp\widgetGen.1015230081323025446362.tmp\webworks
\io\filetransfer\FileTransferExtension.as(198): col: 18 Error: Access of possibl
y undefined property jsObject through a reference with static type webworks.exte
nsion:WebWorksReturnValue.
                    return result.jsObject;
                                  ^

Loading configuration file C:\blackberry\BlackBerry WebWorks SDK for TabletOS 2.
2.0.5\bbwp\blackberry-tablet-sdk\frameworks\air-config.xml
[INFO]                  Packaging the bar file
java.io.FileNotFoundException: C:\Users\Ludger\AppData\Local\Temp\widgetGen.1015
230081323025446362.tmp\pillWhat.swf (The system cannot find the file specified)
at java.io.FileInputStream.open(Native Method)
at java.io.FileInputStream.(Unknown Source)
at net.rim.tumbler.file.FileManager.copyFile(FileManager.java:481)
at net.rim.tumbler.airpackager.AirPackager.run(AirPackager.java:232)
at net.rim.tumbler.WidgetPackager.go(WidgetPackager.java:152)
at net.rim.tumbler.WidgetPackager.main(WidgetPackager.java:77)
[ERROR]                 Air Packager exception occurred
Info: Sending request: Install
Info: Action: Install
Info: File size: 1181083
Info: Installing ...
Info: Processing 1181083 bytes
Info: Progress 2%...
actual_dname::pillWhat293c5ba0c4e33a7a42d6961702c9761.gYABgIWK1ZzkshQ0JUi_6YDGDp
g
actual_id::gYABgIWK1ZzkshQ0JUi_6YDGDpg
actual_version::<IP_ADDRESS>
result::success
c:\blackberry\BlackBerry WebWorks SDK for TabletOS <IP_ADDRESS>\bbwp\blackberry-table
t-sdk\bin>

change them to jsonObject and all should be well :)

Hello Could you give me a example ? dont really know what i need to change
to a json object?

Kind Regards
Ludger R Peters
Email<EMAIL_ADDRESS>Website: http://ludgeronline.info/
On Thu, Dec 8, 2011 at 8:18 AM, bthornton32 <
<EMAIL_ADDRESS>
wrote:

change them to jsonObject and all should be well :)

Reply to this email directly or view it on GitHub:
https://github.com/blackberry/WebWorks-Community-APIs/issues/28#issuecomment-3058417

ah i see what you mean saw your
https://github.com/blackberry/WebWorks-Community-APIs/pull/30
thanks for the support.


ng-add svg-icons file not exists

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior
ng-add adds
import icons from '../assets/svg/svg-icons';

to app.module.ts, but this assets/svg/svg-icons not exists.
What this file supposed to be?
According to README manual steps looks like I need to import each icon?

import { appSettings } from '../svg/app-settings.icon';

@NgModule({
  imports: [
    SvgIconsModule.forRoot({
      icons: [appSettings]
    })
...

We need to update the README. I've created our own tool to extract the SVGs.

We need to update the README. I've created our own tool to extract the SVGs.

It'll be great if you can do it. https://github.com/ngneat/svg-icon/tree/master/svg-generator

It'll be great if you can do it. https://github.com/ngneat/svg-icon/tree/master/svg-generator

I just wanted to update issue. I figured it out.
If there is no svg or only one svg in the folder - it won't create svg-icon.ts in the assets folder

I just wanted to update issue. I figured it out.
If there is no svg or only one svg in the folder - it won't create svg-icon.ts in the assets folder

It'll be great if you can do it. https://github.com/ngneat/svg-icon/tree/master/svg-generator

Ok.
BTW there is something wrong with this folder.
When tried to git clone on windows getting a lot of errors
> git checkout -q --track origin/ng-add-folder
error: invalid path 'svg-generator /.gitignore'
error: invalid path 'svg-generator /.npmignore'
error: invalid path 'svg-generator /ast.ts'
error: invalid path 'svg-generator /generator.ts'
error: invalid path 'svg-generator /index.ts'
error: invalid path 'svg-generator /package-lock.json'
error: invalid path 'svg-generator /package.json'
error: invalid path 'svg-generator /tsconfig.json'
error: invalid path 'svg-generator /types.ts'
error: invalid path 'svg-generator /webpack-plugin.ts'

It'll be great if you can do it. https://github.com/ngneat/svg-icon/tree/master/svg-generator

Ok.
BTW there is something wrong with this folder.
When tried to git clone on windows getting a lot of errors
> git checkout -q --track origin/ng-add-folder
error: invalid path 'svg-generator /.gitignore'
error: invalid path 'svg-generator /.npmignore'
error: invalid path 'svg-generator /ast.ts'
error: invalid path 'svg-generator /generator.ts'
error: invalid path 'svg-generator /index.ts'
error: invalid path 'svg-generator /package-lock.json'
error: invalid path 'svg-generator /package.json'
error: invalid path 'svg-generator /tsconfig.json'
error: invalid path 'svg-generator /types.ts'
error: invalid path 'svg-generator /webpack-plugin.ts'

@NetanelBasal are you sure it's just a readme update? Seems to me svg-icon isn't using svg-generator at all, but svg-to-ts

@NetanelBasal are you sure it's just a readme update? Seems to me svg-icon isn't using svg-generator at all, but svg-to-ts

Yes, that's what I said. I've created our own SVG generator. It also exposes a Wepback plugin.

Yes, that's what I said. I've created our own SVG generator. It also exposes a Wepback plugin.

We should remove the svg-to-ts, and update the README so that people will use it instead

We should remove the svg-to-ts, and update the README so that people will use it instead


Dev to main sync

Developer Name: @sahsisunny

PR's

#1883

Breaking Changes

[ ] Yes
[ ] No

Development Tested?

[ ] Yes
[ ] No

#1883


Could you give an example for converting Hyperts trainning model to PMML file?

I need use the PMML file in java to predict, but I don't know how to convert model trainning by Hyperts to PMML file.
Could you give an example for converting Hyperts trainning model to PMML file?

Sorry, I do not know how to do it. You can learn how to conver a model trained by python, sklearn, or tensorflow to a PMML file. For example. sklearn2pmml package and so on.


Api added for generating the token

UI-backed server responsible for serving HTTP requests right now it's only implementing APIs for used for providers in the future it can expanded for any other feature
UI-backed server has 2 containers running in it
1. Proxy container which is responsible for authorizing the user
2. API server which serves requests via proxy
Proxy is running as a sidecar container to the HTTP server.

@rchikatw I was not able to locate any code that deals with setting up the server as an HTTPS server. This server needs to be secured which means you should have a certificate generated for it, with the proper annotation on the service to generate the certificate. Then the certificate needs to be mounted into the server pod as a file and used when setting up the https server.

There is one lint error that is not my part of the code, I can fix it if any of maintainer/reviewer suggests me.

@nb-ohad Nitin is also fine w/ having the server as part of ocs-operator Dockerfile, seeing the changes I don't think we need a new image and build team wants a discussion if we want to build a new image.

@rchikatw I believe CI is failing in building new image which might need config changes in another repo, I think it's better to build it in same ocs-operator image.

@leelavg I never asked for a different image. We can use the ocs-operator one. I think it is the same for the API server
But this PR is not ready yes

@leelavg I never asked for a different image.

I was told it was discussed we wanted a different image. Yes, I also don't want a separate image.

@rchikatw A general note for a common mistake I saw in the last couple of reviews. Pure logic functions that don't hold a state (like generateOnboardingToken) shouldn't write directly to the log. instead warp any errors with context (using fmt.Errorf) and return them up the call chain until you get to a stateful function that has to deal with a logger. For this PR a good place can be main or the endpoint handler.

/hold

/lgtm

/unhold

/cherrypick release-4.15


Documentation bug: Typo

Is there an existing issue for this?

[X] I have searched the existing issues

Package Version
docs
Current Behavior
https://wagmi.sh/core/chains
In the  documentation section "Supported chains" the list includes "bronos" but believe this should be "cronos".
Expected Behavior
"bronos" and "bronosTestnet" are "cronos" and "cronosTestnet"
Steps To Reproduce
Via https://wagmi.sh/core/chains navigate to to the "Supported chains" section.
Link to Minimal Reproducible Example (StackBlitz, CodeSandbox, GitHub repo etc.)
No response
Anything else?
No response

Feel free to update!


feat(ui): flowbite PR#4 - assistant avatars

Migrates the Assistant Avatars to Flowbite
Deployed on LF-04
LeapfrogAI - Assistants Management - 29 July 2024 - Watch Video

Closed by merging of #862


Add average request per second

Add another column for average requests per second all frameworks can handle

Funding

You can sponsor this specific effort via a Polar.sh pledge below
We receive the pledge once the issue is completed & verified

What do you mean? Didn't we already list this data?

Bun is roughly 2x faster than Deno

Something is not right here

You can try another benchmarking tool and see how it performs, for instance:

bombardier with fast http enabled
http-load-test from uWebSockets repo

@aquapi, please open a new issue and don't edit your original post!


add feature that supports indicator with icon image

hello there!
I just added a little feature that supports indicator with icon image.
Well, this is MY VERY FIRST PR that's been made to public pub.dev package... so ...
FEEL REALLY REALLY FREE to say something that looks weird or buggy to you...!
I'd be honored if this pr could be merged to your package!
thank you!!!

Thank you for your contribution! But unfortunately this pr can not be merged for some reasons.
Here are some reasons:

The library name is changed to vertical_scroll_tabbar_icon
Your idea that using tabbar's indicator property is really good. But you limited indicator as images. I think it can be any types of widget.
If then, path property will be no needed anymore and  isIcon property will be substituted to indicator property which accept widget type value.

If you have any comments, it will be welcomed.
Thank you.

oh I see...! no problem, then in that case, I will just use this forked version in my repo for now!!
thanks for the quick feedback!!!


[Bug] Overall performance degradation noticed since v1.4.5

A user has reported huge delays for the entire application after using v1.4.5. File attached here shows network activity for their self-hosted instance.
appsmith.zip

Need to improve our performance tracking since we are not able to compare this with any benchmarks currently

My colleague thinks the problem may be due to this change, which has made it synchronous, which is also consistent to why we have errors popping up when quickly switching rows or moving to another interaction
We made the storeValue function calls synchronous. You can now access those values directly in any action runs just after creating/updating store values! (#3663)

Hi @mosinuga, that is a valuable insight! Can you share the binding you have with store value in table row change which has the storeValue function call? Also please share the errors you mention here

This is the errors for that quick switching of rows

Hey @mosinuga, thanks for this. Please share the binding you have set in your Table onRowSelected action as well so that I can get a complete picture

Does this help?

@mosinuga, from what I see, this is happening because multiple storeValue calls are running in sync, which is causing the errors. Another question: Are these values you are storing being used in your dropdowns RI_OPY, RI_CSY RI_STATUS, RI_Certainty etc. or the last action ILog_File_Intervention_Count.run()

@hetunandu Do you think reversion to asynchronous is an option? I have just been told that the app is unusable as it takes 30 seconds to load!

We are using the store values because the multi-choice drop-downs cannot feed off the table using the table.selectedRow feature like the other elements of the form. Instead, they need to be separately triggered because we need to collect multiple values into an array. The store value is used in the multiple-choice drop-downs like this

@mosinuga
I think this can be solved without storeValue. I can help you in writing this in an optimised way.  You can ping me there [at]hetu, or if you feel like, you can also email me at hetu[at]appsmith.com

Hey @mosinug, I haven't heard from your colleague regarding this issue on discord. Will it be possible to get in touch this week?

@hetunandu My colleague seems to have been chatting/working with some of your colleagues (Sumit)

Thanks @mosinuga. I have connected with him on discord and discussing the details

Hi 👋 @mosinuga , we've added a few performance updates to appsmith. Your app should be much faster now. Do let us know if you're still facing a problem here


bug(gui-client): Tauri panic FailedToReceiveMessage

Describe the bug
🤷♀
To Reproduce

Reboot the system
Start the GUI
The GUI panics

I don't have a clue. This happened on the Windows Server 2022 VM after a fresh reboot, and I'd been AFK for 10 minutes. So the IPC service was idling smoothly, the system RAM couldn't be corrupted, the GUI just failed to start.
Expected behavior
The GUI should not panic for no reason on a perfectly fine system.
Screenshots / Logs
https://firezonehq.slack.com/archives/C067DSY7TFX/p1718820779141219
Logs are in the internal Slack in case they contain my IP or anything
Platform (please complete the following information)

Component (i.e. macOS client / Linux client / Gateway / Admin portal): GUI Client
Deployment method: (e.g. Docker / Systemd / App Store or N/A): MSI built by GitHub

Observed on:

1.0.9, resource-constrained Windows Server 2022 VM
1.1.2, Windows 11 dev laptop

Additional context
I'm finding a lot of Windows bugs today. I must have been under-testing it before.

Happened just now on 1.1.2 on the Windows dev laptop. Same deal, I checked the logs and after a few minutes restarted the GUI and it was fine

Think this might have been fixed? Could this have been related to the admin rights?

It couldn't have been the admin thing because that always failed before the logs were opened.
I haven't seen it replicate. I wonder if it was a bug in upstream that got fixed


NIFI-8102 TailFile can skip characters if tailing a file on NFS mount

Force the TailFile processor to recreate and reposition the reader
by setting it to null in case of a NulCharacterEncounteredException
Updated the TestTailFile.testNULContent() to not initialize the
processor when calling the second run()

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically main)?

[x] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[x] Have you verified that the full build is successful on JDK 8?
[x] Have you verified that the full build is successful on JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

Thanks @adenes . Changes look good to me. Will wait for the Github Actions to complete and assuming that all is green there i'll go ahead and merge.

Looks like all checked out good, +1 merged to main. Thanks @adenes !


🐳(project) use PostgreSQL instead of SQLite for development and tests

Purpose
Use PostgreSQL instead of SQLite in Development environment.
Proposal

[x] Update docker-compose to start a postgresql container
[x] Install dockerize
[x] Update CircleCI configuration
[x] Don't wait for postgresql container to run linters

Thanks for your feedbacks @lunika !
I addressed all of them.


feat: add option closing-bracket-newline for html

Description
#1707

[html-closing-bracket-newline]

New Option for HTML: closing-bracket-newline

this option decide whether add newline before tag's closing bracket or not
it only worked when tag already has wrapped attributes
so this option can be combined with option wrap-attributes

Before Merge Checklist
These items can be completed after PR is created.
(Check any items that are not applicable (NA) for this PR)

[x] JavaScript implementation
[ ] Python implementation (NA if HTML beautifier)
[x] Added Tests to data file(s)
[x] Added command-line option(s) (NA if
[x] README.md documents new feature/option(s)

@zhaojjiang
That's for the PR.  I'm not sure I understand why a new option is needed.
The issue talks about fixing "wrap-attributes": "preserve".

@zhaojjiang That's for the PR. I'm not sure I understand why a new option is needed. The issue talks about fixing "wrap-attributes": "preserve".

yes, the issue's title is about wrap-attributes, but newline before closing bracket is mentioned:

Please fix "preserved" or add a new option for keeping the line break before the closing angle bracket.

I also need this feature for preserve-aligned please!

so I add a new option to add a newline, and keep wrap-attributes option working as before

@zhaojjiang That's for the PR. I'm not sure I understand why a new option is needed. The issue talks about fixing "wrap-attributes": "preserve".

We can ignore that issue mentioned above, I can edit and remove it from this pr.
I really think this new option closing-bracker-newline is helpful.

with unnecessary format change, maybe another pr


Switched to vanilla bootstrap 3.1.1

Changed to vanilla bootstrap for the CSS
removed uw-ui-toolkit
did the ol' switch-a-ru on a couple imports

All is well in the world of oz.

:+1:

:+1:


Feature request: Adding virtualWAN subnet to subnet discovery

I would like to see the subnet that is used by the virtualWAN to be discovered so that I can associated that with a block that I added.

Hi @pcdiks, I spent quite a bit of time today looking into this, and here are my thoughts...
A traditional Virtual Network in Azure has a relationship like this:
Virtual Network -> Subnet(s) -> Endpoint(s)
When you create a vWAN Hub, you assign Address Space to it, just like a normal Virtual Network. However, it's essentially a "black box". You can put "stuff" in that Address Space, you can "peer" (connect) it to other Virtual Networks, but you can't create Subnets, or do anything directly with the Address Space of that vWAN Hub. In fact, when you "peer" it, that peering is to a mystery subscription that you don't control and have no visibility into.
That said, I completely understand that the Address Space you assign to the vWAN Hub does indeed subtract from your overall Enterprise IP space, and you'd like to account for it within IPAM.
So.....in an ideal world, how best should this look?
Should we just "fake" it and say that a vWAN Hub is essentially a vNET for the purposes of IPAM? Or should there be a special section to handle the strange nuances of vWAN within IPAM?
I'm very interested in how you think this is best represented in the tool.

Hi @DCMattyG , for me the most important part would be that I can remove it from the available addresses so that that subnet is not available for a reservation. Creating a special kind of vnet for the vwan would be nice since you cannot do anything with it.
From my point of view it is not necessary to add any special features to IPAM to handle that vnet.

Hi there @pcdiks, I know it took a while, but support for vWAN Hubs has now been merged in from PR #113.
Please restart your Azure IPAM App Service, and the latest containers should be pulled down. Let us know if you have any issues with the new feature. Enjoy!

Hi, I just updated a couple of my deployments and they work great. Thanks!


[WIP] Forward merge 2.0 dd0bc89 to 2.1

Still WIP because 2.1 scope is not strictly defined. This PR shows that merging 2.0 to 2.1 have only one conflict which is expected and simple.

Forward merge will happen after 2.0.x releases. Close this.


Change flex properties of project summaries

Addresses the concerns listed here:
https://www.figma.com/file/Dev3ulmslbUYJPkaCLDnJm/Innovation.ca.gov-screens?type=design&node-id=2631-1032&mode=design&t=k9BFaNoEAOzwPPOo-0
The flex properties of the "Project Scope" section have been altered to help out on mobile.
Before:

After:

Test page: https://fix-calvcb-page-2.pr.digital.ca.gov/our-work/projects/getting-compensation-to-more-california-crime-victims/


start cluster checks when cluster servelet starts

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1104  👈
#1103
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @BelSasha and the rest of your teammates on  Graphite


Decide on approach for exceptions thrown by public methods

We should decide on a convention we want to follow for exceptions thrown by public methods.
Proposal:

avoid explicitly throwing Exception and RuntimeException. Both are far too general, we should throw exceptions that indicate a specific error case. We're using Exception and RuntimeException in a handful of places at the moment. example
favor Exception over Error for custom exception classes. Conventionally, *Error are not expected to be caught. They are conditions that typically affect the JVM's ability to continue execution. Examples include OutOfMemoryError and StackOverflowError. Error is intended to indicate a serious problem. Example of us using the word Error here
ensure that exceptions thrown from our public api surface are either included as part of java/kotlin or are custom exception classes that come directly from our package as opposed to third party dependencies

We should decide on our approach here and then prioritize implementing the approach before our codebase grows larger.

Super important topic, thanks for raising @mistermoe !
I agree with the first two points.
Re: to

ensure that exceptions thrown from our public api surface are either included as part of java/kotlin or are custom exception classes that come directly from our package as opposed to third party dependencies

How do you do this in practice? For instance, if a dependency throws an custom exception, how can we guarantee that we'll not throw it? We would presumably need to surround most external dependency calls with try/catch blocks, but that's difficult to maintains because: (a) makes code incredibly verbose and (b) it's hard to enforce in PRs.

great point @andresuribe87 . i was feeling 😅 🙈  as i typed that one out.
Typically, what i've done is look at the javadoc/kdoc for method i'm calling to see if the exceptions thrown are documented. if they aren't documented, i click into the implementation to see if custom exceptions are thrown, but this can easily become a blackhole if the method i'm inspecting calls n other methods from other third party dependencies.
you're right, it does seem hard if not impossible to enforce in PRs. The motivation behind that bullet point is primarily two reasons:

if we're throwing custom exceptions from third party dependencies, do we have to declare those dependencies as api instead of implementation so that consumers can actually import the exception?
i think it'd be beneficial for us to know exactly what exceptions are expected from our public api surface.

all that said,  should we choose to adopt that last bullet, i suppose it'd be more of a recommendation, and something we retroactively account for when/if we encounter third party custom exceptions bubbling up. Though it's far less of a concern so long as consumers can actually import the custom exception

if we're throwing custom exceptions from third party dependencies, do we have to declare those dependencies as api instead of implementation so that consumers can actually import the exception?

I think the answer here is that it depends. If we're suggesting that the consumers can do something to handle the exception, then I would say they need to be part of the public API. Otherwise, then hiding it behind the implementation makes sense to me.

i think it'd be beneficial for us to know exactly what exceptions are expected from our public api surface.

I agree! And I think it goes hand in hand with the answer above. One guideline that we could decide on is:

Any expected exceptions MUST be thrown by public API methods. Guidance: ask yourself, can a client reasonably be expected to programmatically recover when the exception is thrown?

Consumers MUST be able to import expected exceptions without changing their gradle files.

All expected exceptions thrown by a public method MUST be marked with the @Throws annotation.
All exceptions marked with the @Throws annotation MUST be tested.

The first bullet point is left as a judgement call (what is an expected exception?) to the author and reviewer of the PR. I don't think there are hard and fast rules here.
Thoughts?

that makes sense to me!

Really good work from @jiyoontbd on this here
I want to add some thoughts with respect to the discussion above regarding exceptions from our dependencies. In a perfect world, our programmatic interface should never expose an exception from a transitive dependency; keyword "perfect" which of course is not attainable. The reasoning being, developers are installing "web5" and therefore have the expectation to develop against web5, and not web5 plus some transitive (and likely lower-level) dependency which the web5 devs decided was a good choice.
The way I would frame this up is two-fold:

Custom exceptions we define for semantic reasoning
"Everything else" 😄

It's the 'ole adage of, "just return a 500 for everything you don't know of."
For (1), these exceptions exist for the purpose of driving SDK consumer logic, which ought to be gracefully handled. Exceptions are good for this, rather than return types because exceptions can bubble-up N-number of calls on the call stack.
For (2), these exceptions are pure failure scenarios, which cannot be gracefully handled and inevitably require human input. This is the "catch-all" exception case, for which, we could define a standard Web5Exception, which is slightly preferred to the standard Kotlin Exception because it adds one additional (albeit small) layer of semantic reasoning for the SDK consumer (basically: "if Web5Exception then something went wrong, but else if Exception then something REALLY went wrong" lol). Within the context of the Web5Exception we would include any useful information from the underlying exception, which would help us diagnose issues caused from transitive dependencies.
So basically, what I'm saying is, every public function in the SDK should be wrapped in a try/catch and within the catch we have conditional logic which goes: if this is one of our custom exceptions then throw it, else throw the catch-all Web5Exception. Which, is something not so easily enforced during code reviewal (easy to forget), but perhaps a tool like detekt has a rule for it.


Assignment 6: Sprint

[ ] Groom the backlog
[x] Update our project board
[ ] Plan the sprint:

[ ] Decide on the sprint goal
[x] Pick tasks
[x] Create a milestone

[ ] Execute the sprint
[ ] Hold a sprint review
[ ] Demonstrate progress to the customer
[ ] Conduct a sprint retrospective

Sprint goal: Complete the cycle of using guest sessions


AUDIT: Error handling should be reviewed

Surfaced from @informalsystems audit of Stride at commit f9736fe0

finding:
id: IF-STRIDE-STAKEIBC-ERRORHANDLING
title: Error handling should be reviewed
severity: Informational
impact: None
exploitability: None
type: Implementation
issue:
status: Unresolved
Involved artifacts

x/stakeibc/keeper/hooks.go
x/icacallbacks/keeper/keeper.go

Description
InitiateAllHostZoneUnbondings and SweepAllUnbondedTokens functions have return values defined but these are not handled in the if block:
if epochIdentifier == "day" {
    // here, we process everything we need to for redemptions
    k.Logger(ctx).Info(fmt.Sprintf("Day %d Beginning", epochNumber))
    // first we initiate unbondings from any hostZone where it's appropriate
    k.Logger(ctx).Info("InitiateAllHostZoneUnbondings")
    k.InitiateAllHostZoneUnbondings(ctx, epochNumber)
    // then we check previous epochs to see if unbondings finished, and sweep the tokens if so
    k.Logger(ctx).Info("SweepAllUnbondedTokens")
    k.SweepAllUnbondedTokens(ctx)
    ...
}

On the other hand, CallRegisteredICACallback returns nil in both cases, the successful one (callback is processed and callback data is removed), and when there is no actual callback data. It's clear that some IBC or ICA transactions don't need to have callback defined but the caller of the function couldn't know if the callback was called and processed or the callback data hasn't been defined.
func (k Keeper) CallRegisteredICACallback(ctx sdk.Context, modulePacket channeltypes.Packet, ack *channeltypes.Acknowledgement) error {
	callbackDataKey := types.PacketID(modulePacket.GetSourcePort(), modulePacket.GetSourceChannel(), modulePacket.Sequence)
	callbackData, found := k.GetCallbackDataFromPacket(ctx, modulePacket, callbackDataKey)
	if !found {
		return nil
	}
	callbackHandler, err := k.GetICACallbackHandlerFromPacket(ctx, modulePacket)
	if err != nil {
		k.Logger(ctx).Error(fmt.Sprintf("GetICACallbackHandlerFromPacket %s", err.Error()))
		return err
	}

	// call the callback
	if (*callbackHandler).HasICACallback(callbackData.CallbackId) {
		k.Logger(ctx).Info(fmt.Sprintf("Calling callback for %s", callbackData.CallbackId))
		// if acknowledgement is empty, then it is a timeout
		err := (*callbackHandler).CallICACallback(ctx, callbackData.CallbackId, modulePacket, ack, callbackData.CallbackArgs)
		if err != nil {
			errMsg := fmt.Sprintf("Error occured while calling ICACallback (%s) | err: %s", callbackData.CallbackId, err.Error())
			k.Logger(ctx).Error(errMsg)
			return sdkerrors.Wrapf(types.ErrCallbackFailed, errMsg)
		}
	} else {
		k.Logger(ctx).Error(fmt.Sprintf("Callback %v has no associated callback", callbackData))
	}

	// remove the callback data
	k.RemoveCallbackData(ctx, callbackDataKey)
	return nil
}

Problem Scenarios
Caller functions could have misleading information based on return value(s) of the calling functions.
Recommendation
For InitiateAllHostZoneUnbondings think about handling the case when there are some failed unbondings, or similar in SweepAllUnbondedTokens if there are failed sweeps from Delegation ICA to Redemption ICA.
In the CallRegisteredICACallback at least consider adding an info log before returning nil if it's expected that some acks do not have an associated callback. The other aproach is to add dummy callback for every IBC tx.

@asalzmann Hey for InitiateAllHostZoneUnbondings  func, I see there r 3 values return is:

succes: true if all host zone is unbonded
successfulUnbondings: list of hostzone unbonded
failedUnbondings: list of hostzone failed to unbond
I see if anyfail unbonding has been moved to the next epoch ( to my understanding ) so basically it has been handled.

should we add counter to prevent certain unbodings to be added back to the next epoch

also in CallRegisteredICACallback if callbackData is not found should we add a log and return a simple err too


fixtures: Add Cameo P2 FC

The Cameo P2 FC has 12 different modes.
This patch adds support for 7 of them, which don't depend on the device setting channel.

Updated PR:

adding dimensions (zero values caused a fail of the CI)

coverage: 32.045% (+0.07%) from 31.971%
when pulling 42de356e38166b04b2b332108c75d4631d8265f1 on cmuellner:cameo-p2-fc
into 2b0e772532098f251fe2c2a9f5619155dc391116 on mcallegari:master.

Thanks for adding the missing modes.
I would have done this as well if you had asked for it.
Thanks for merging!


Fixed redirection from account creation to login

Now when user creates an account, an alert pops up and makes them log in again.

Already done


BroadcastTimeout for Gateway

The Gateway has retry logic for failing ordering nodes, however if an ordering node doesn’t respond, then the Submit call will timeout without allowing other ordering nodes to be tried. This commit implements a BroadcastTimeout that allows individual OSN’s to timeout before the overall Submit timeout expires. Similar logic already exists for calls to endorser peers.
Resolves https://github.com/hyperledger/fabric-gateway/issues/529
Signed-off-by: andrew-coleman<EMAIL_ADDRESS>

@Mergifyio backport release-2.5

@Mergifyio backport release-2.4

@Mergifyio backport release-2.5

@Mergifyio backport release-2.5


docs: update the TOC

Signed-off-by: anupriya0703<EMAIL_ADDRESS>

This is in "draft" mode.

Some of the links (eg. supportability, monitoring) will not work as their corresponding PRs are under review. In order to ensure that this PR isn't merged before the others I have set it as a 'draft'.  cc @avishnu


Dev-Lite Test: Faraday's Electromagnetic Lab 1.0.0-dev.16

Dev-Lite Test
Mentions: @arouinfar @kathy-phet @KatieWoe @Nancy-Salpepi
Simulation links

github repository for issues
phet top-level directory
sim: all_phet.html
phet-io wrapper index

Test Matrix

[x] Tester 1 (Tester = NS , Platform = mac + safari, Time = 2hrs {max 2 hours}
[x] Tester 2 (Tester = KW, Platform = Win 11 Chrome, Time = 2{max 2 hours}

Features included

PhET-iO
Alternative Input
UI Sound
Dynamic Locale
Sonification
Description
Voicing

Focus and Special Instructions

Focus mainly on the PhET brand.  Give the PhET-iO brand a quick look if you have time.

This is a port from the Java version, which you can run using CheerpJ at https://phet.colorado.edu/en/simulations/faraday. Most things look and behave like the Java version.  But there have been some changes, improvements -- and possibly some (gasp) regressions.  So don't hesitate to question behavior if you think it's incorrect or could be improved.

As of this writing, there are only 20 open GitHub issues.  So if you encounter a problem, please have a look at the open issues, to see if it's a known problem or "work in progress".  When in doubt, feel free to create a GitHub issue.

This known bug exists with the icons on the Home screen: https://github.com/phetsims/faradays-electromagnetic-lab/issues/89

For QA...

General features

What to Test

Click every single button.
If there is sound, make sure it works.
Make sure you can't lose anything.
Play with the sim normally.
Try to break the sim.
Try to include browser version numbers
If there is a console available, check for errors and include them in the Problem Description.
Run through the string tests on at least one platform, especially if it is about to go to rc.
Check the Game Up harness on one platform.

PhET-iO features

What to Test

Make sure that public files do not have password protection. Use a private browser for this.
Make sure that private files do have password protection. Use a private browser for this.
Make sure standalone sim is working properly.
Make sure the wrapper index is working properly.
Make sure each wrapper is working properly.
Launch the simulation in Studio with ?stringTest=xss and make sure the sim doesn't navigate to youtube
For newer PhET-iO wrapper indices, save the "basic example of a functional wrapper" as a .html file and open it. Make
sure the simulation loads without crashing or throwing errors.

Accessibility features

What to Test

Specific instructions can be found above.

Make sure the accessibility (a11y) feature that is being tested doesn't negatively affect the sim in any way. Here is
a list of features that may be supported in this test:

Alternative Input
Interactive Description
Sound and Sonification
Pan and Zoom
Mobile Description
Voicing

Test all possible forms of input.

Test all mouse/trackpad inputs.
Test all touchscreen inputs.
Test all keyboard navigation inputs (if applicable).
Test all forms of input with a screen reader (if applicable).

Screen Readers
This sim may support screen readers. If you are unfamiliar with screen readers, please ask Katie to introduce you to
screen readers. If you simply need a refresher on screen readers, please consult the
QA Book, which should have all of the information
you need as well as a link to a screen reader tutorial made by Jesse. Otherwise, look over the a11y view before opening
the simulation. Once you've done that, open the simulation and make sure alerts and descriptions work as intended.

Platforms and Screen Readers to Be Tested

Windows 10 + Latest Chrome + Latest JAWS
Windows 10 + Latest Firefox + Latest NVDA
macOS + Safari + VoiceOver
iOS + Safari + VoiceOver (only if specified in testing issue)

Critical Screen Reader Information
We are tracking known screen reader bugs in
here. If you find a screen reader bug,
please check it against this list.

Keyboard Navigation
This sim supports keyboard navigation. Please make sure it works as intended on all platforms by itself and with a
screen reader.
Magnification
This sim supports magnification with pinch and drag gestures on touch screens, keyboard shortcuts, and mouse/wheel
controls. Please test magnfication and make sure it is working as intended and well with the use cases of the
simulation. Due to the way screen readers handle user input, magnification is NOT expected to work while using a screen
reader so there is no need to test this case.

FAQs for QA Members

There are multiple tests in this issue... Which test should I do first?
Test in order! Test the first thing first, the second thing second, and so on.

How should I format my issue?

We typically assign the developer who opened the issue in the QA repository.

My question isn't in here... What should I do?
You should:

Consult the QA Book.
Google it.
Ask Katie.
Ask a developer.
Google it again.
Cry.

QA is done

Excellent, thank you QA!  Looks like we're in great shape 🎉


BandColors, and example implimentation with youtube

Addresses #144
Since @Noojuno has made it way easier to mess with the auto-embed code, were probably going to start adding more embeds. Were going to want to add logo's of these sites and style them with the appropriate branding colours. As mentioned in #144 we really don't want to have to go out and find all brand colours ourselves. This is where https://brandcolors.net/ comes in. Unfortunately were dealing with a lot of gaming and development specific sites which aren't included. In that case we have to add the colours our-self.
This commit adds.

https://brandcolors.net/ style sheet src/external/BrandColors/brandcolors.less
A readme with details with brandcolor site and issues page. (note: there is no licence on the .less file, probably because all the colors are 'owned' by the brands them selves)
Internal extra site colors (itch. gamejolt, 1h game jam) src/internal/BrandColors/brandcolors.less
Makes Youtube logo use the youtube color

Ignore the diff for src/com/autoembed/youtube.less it's messed up.

What would help in the future if 4-wide-tabs were used instead of 2-spaces.


Add HSLuv color space

The HSLuv color space bounds LCh's chroma component into a "saturation component".
I'm not sure if this project is interested in adding every color space out there, but it does have some popularity, so it would be a welcome addition.
It is defined as a transformation on LCh, so implementation should be straightforward enough. I might look into creating a PR if I can.

Just for clarity, HSLuv is the transformation on  CIELUV LCh, not LCh. The former is the cylindrical form of Luv while the latter is the cylindrical form of L*a*b*.
You'll have to at least implement Luv, CIELUV LCh, and HSLuv. The conversion path is XYZ D65 -> Luv -> CIELUV LCh -> HSLuv.

Hi @facelessuser

The conversion path is XYZ D65....

The conversions to LUV are built into HSLuv, last I checked it was a complete conversion straight from sRGB.
I happen to like HSLuv, it updates Luv with a novel built-in constraint to realizable colors in sRGB. I like Luv in general for its simplicity, lack of purple shift¹, and the fact it has a saturation correlate in addition to chroma*, while CIELAB only has chroma.
And yes, HSLuv is otherwise essentially polar Luv as Lshuv, using the saturation correlate, which has useful advantages over chroma, one being that the saturation control is closer to being an orthogonally independent control of colorfulness or color purity.
¹ Regarding the purple shift

Click to reveal the colorful gradient examples and discussion
Here are some Luv vs Lab examples from a couple years ago, before OKLab, for reference. Everything is D65, using standard CIE math. The top four are polar, and the bottom four are rectangular. For all, the gradients were created doing a simple average of each of the three correlates of which ever space, with the middle being an average of the first and last, and subdividing accordingly.
Pay attention to the top row, second from left, as that is Lshuv, it is IMO the most consistent of all.
TOP, Polar Coordinates:
$Std. HSL,\ \ Lsh_{uv},\ \ LCh_{ab},\ \ LCh_{ab}$
BOTTOM, Cartesian:
$sRGB,\ \ CIE\ xyY,\ \ L^* u^* v^* ,\ \ L^* a^* b^*$
Click to enlarge

Here we see the infamous purple shift in LAB, especially in the rectangular coordinates version. LUV does not have such a plainly obvious shift.
Next

The purple shift in LAB continues to be an issue. Also notice that sRGB is noticeably darker and that the HSL is being more colorful than the rest, but also uneven.
Next Slide — Colorful!

In this case, the polar "hue rotation" direction was reversed, so the color palette of the top row using polar coordinates is suddenly more colorful. Also, the HSL gradient isn't doing too well. The sRGB is still a bit dark, and LAB is still polluting other colors with purple. The LAB LCh is a bit out of whack — but the LUV plots, especially Lsh are still demonstrating consistency
Last slide

What's going on? A pure blue to achromatic gradient can demonstrate unexpected behaviors. Notice the LAB plots and their shifts, but the LUV plots are still doing well, with expected behavior.
So what's wrong with luv?
LUV is widely recognized as bad when used with diffuse, reflected surface colors. This is not in dispute. But as a color chooser for selecting colors for content on self-illuminated displays, it works well, and has advantages as mentioned.
I have reason to believe that part of why Luv does poorly in certain contexts is that the choice of Munsell value for L*, while good with Lab, is not a good fit for Luv, for reasons I am still investigating. Nevertheless Tektronix modified Luv, in particular scaling and axis substantially, for use in one of their professional broadcast color correction systems.... gosh if only I know of some perceptually uniform lightness thingy somewhere.....
Thank you for reading

.
P.S. I use details/summary to make my posts appear much shorter than they really are.

@Myndex I'm not quite sure what you mean by "built into" HSLuv. You have to first get it into one of these spaces to then apply the transform to HSLuv: https://github.com/hsluv/hsluv/blob/master/math/cie.mac.
Is it self-contained in their repo (all of the conversions)? Sure, but the transformation to HSLuv requires you to first get it into LChuv, then transform it to HSLuv. These steps are separate even if they are all done within their repo. I've implemented it here: https://github.com/facelessuser/coloraide/blob/main/coloraide/spaces/luv.py and https://github.com/facelessuser/coloraide/blob/main/coloraide/spaces/hsluv.py.
If you are going to go ahead and add support for HSLuv, you might as well expose Luv and LCHuv as you have to apply the transform from XYZ anyway and not hide it in HSLuv. If you want to hide it all in the HSLuv implementation, you can surely do that, but you deprive people of being able to use Luv/LCHuv directly.
Anyway, I think my statement holds true, but it can be implemented however it is desired here. Personally, I would expose all the color spaces as the full Luv color space can be useful if you are not confined to an sRGB-limited variant of it.

@facelessuser  Ah I misunderstood your point, my bad.
The other color spaces are already here, largely.
CIE Lab, XYZ are already in color.js  ... Luv isn't but uses the same L* as Lab, and the LCh for uv is identical to the LCh for ab. So literally all that's missing is the uv  projection from XYZ... and the HSLuv package...

CIE Lab, XYZ are already in color.js ... Luv isn't but uses the same L* as Lab, and the LCh for uv is identical to the LCh for ab. So literally all that's missing is the uv projection from XYZ... and the HSLuv package...

Yes, all of this could be leveraged, and if that is how it is wanted here, that is fine. I think it would be a shame to  limit support to HSLuv only, but 🤷🏻♂. Either way, I don't think it is difficult to add support for any of these.
The implementation is pretty straight forward. I think to officially claim HSLuv support, you should implement HPLuv as well (per their documentation). They provide tests to confirm your implementation: https://github.com/facelessuser/coloraide/blob/main/tests/test_hsluv/snapshot-rev4.json.


standardize severity_count_text with _

@aentin16 FYI

@shaysw sorry - this will create a small conflict but I had to add it for a FE pr.


charm4py patches

This is ready for review.
Note that all of the code in these commits is inside #if CMK_CHARMPY blocks

Looks good, I just hope all the #ifs and #endifs are in the right place.

Yes, they must be because Charm++ passes verification and I also tested charm4py separately and it also works.


Questions and Suggestions

Dear @lindyhopchris ,
sorry for spamming issues in your repository - i really like the approach and this package looks very (!) powerful. As i am currently looking for a solution to "auto-generate" APIs, and stumbled upon your work, i would like to ask some questions. I hope you may help to tackle these issues and provide answers. Furthermore, some of my questions may also raise additional ideas for upcoming versions and new features.
Please note that I have not digged that much into the code, so some questions may sound stupid or have been discussed in other places (and i haven't read about it). So please apologize :thinking:
Questions

From the docs I read, that you define your Routes like this:

JsonApi::register('default', ['namespace' => 'Api'], function ($api, $router) {
    $api->resource('posts');
});

Are the routes added to the "default" Laravel Router? E.g., can you use the route() commands in order to generate URLs and so on? And does they appear when calling php artisan route:list or does the package use its own (custom) Router that is separate from Laravel?

The $api->resource('posts'); fully auto-generates the common CRUD routes and adds a controller (with a basic implementation to CRUD the resoures). In this case, you use the controller method names like described here ( https://laravel-json-api.readthedocs.io/en/latest/basics/controllers/#custom-controller ). Is it possible to adapt these method names? E.g., I would like to rename the read() method to  readPostById() method or the create to createPost()... Is this possible or is this a naming convention that is "hard-coded" in this package?

How can i add "custom methods" (e.g., with custom routes) to my resource? I know, this may not be JSON:API compliant! But consider the following scenario:
I have a User model that has some basic attributes (username, email, firstname, ...) and complex attributes like settings (e.g., his default language, preferred configuration of the application and so on). In order to manage the "own profile" of the user (i.e., change username, email, firstname, ...) he may PATCH /users/1234 with the appropriate data. However, i would NOT like to send the settings information because this may be done in another workflow / wizard / ... . So i would like to add another route (e.g., PATCH /users/1234/setting) so change these values (just send a json and store it directly within the DB).

How can such routes be added?
How can i "manually" define a custom controller method for this route?
Are the hooks / events automatically assigned (because i change a resource so the updating / updated events may be triggered?)

From what i read, Schemas act as some kind of "output layer"; i.e., they define the structure of mapping "internal models" to "output structures" (similar to Transformers known from Fractal). Is it possible to assign multiple Schemas to one particular Resource? Consider, again, the User example. If a client browses all available Users (e.g., GET /users), I may want to provide only "public" information, like the username, firstname, lastname and so on. However, if the User accesses his own profile (e.g., GET /users/1234), i would like to apply a different Schema - that also provides information about his settings, his email and so on..

Similar to 3) and 4) I would like to ask, if it is possible to define a custom Validator for each route. I can imagine scenarios, where you can create a resource (e.g., register a new User), but you are not allowed to update certain attributes anymore (e.g., you may not change the username after registration!). This would require to have a) different Validators or b) have custom (business) logic to remove certain attributes.

Is there an (automated) approach to generate a fully fledged API doc? I found an older issue discussing this topic. In another project i tried to implement Swagger, but it was very (!) painful, and apidocjs is not actively maintained any more. However, i recently stumbled upon this package here ( https://github.com/saleem-hadad/larecipe ) that may be suitable. Please note that this project does not auto-generate the docs but rather uses markdown in order to generate a UI (it looks quite awesome, i think!)

How would you deal with different "API Realms" in the context of JSON:API? Consider the following example - you have a shop application and you have 2 different roles (customers / managers). In this application you need to show all Products (e.g., GET /products). However, for the customer, this list shall only contain Products that are flagged as is_active = true, while the managers should get all Products. Obviously, for better maintainance you would like to have 2 different controller functions - because it may easily be the case that you would like to apply different sorting strategies for customers in near future; "top-seller" products shall be ordered first, and so on...
From an API perspective, it may be suitable to provide different "realms" for your API URIs (e.g., GET /api/v1/shop/**customers**/products vs GET /api/v1/shop/**managers**/products) that invoke different controller methods. Is this possible and how would you apply such features? I am not even sure if this is JSON:API compliant - i think, the standard does not clearly tell how to deal with such scenarios!

Sorry for the long post and the huge amount of questions; I am quite sure other questions will arise :laughing:
Thank you very much for your time and effort reading / answering my questions!
All the best

Hi! Here's some initial answers.

All the routes are registered via the Laravel router, they all have route names and will all appear in route:list.

There is no ability to renamed the controller methods, though I would be open to adding this feature (however it wouldn't be a top priority at the moment).

Register custom actions via the Laravel router as per the Laravel docs.

Yes schemas are effectively encoders, transformers etc etc - the view layer for your API. They are mapped to PHP objects using the PHP object's class name. You could do what you're talking about but you would have to override some of the internals. I'd need to document how to do this as it isn't totally straightforward because all the schema stuff is actually from the neomerx/jsonapi package.

This is actually possible with the current implementation. The rules methods on the Validators class are passed the record being updated or null if a record is being created. So you can vary the rules based on whether there is a record present or not. You can see that in the examples here:
https://laravel-json-api.readthedocs.io/en/latest/basics/validators/

On the Eloquent adapter there are methods that return fillable fields... those receive the record being created/updated and you can use $model->exists to work out whether it is a create or update operation.

No and no plans at the moment to do this. Maybe in the long term but I think it'll be hideously complex. There's too much other stuff at the moment to work on for me to look at this in the short term.

There are lots of different approaches you can take for doing this. As I've said in another issue we dealt with it in one application by having two APIs. Ultimately it's difficult for me to say what approach to take because it depends a lot on the use case plus how you expect clients to connect to your API. In our use case for example, we have one frontend Javascript application for the admins, and one for the general users, so it was easy to split the backend in to two APIs one that the admin frontend connected to and one that the general user frontend connected to. But in other use cases it might be more complicated than that. Generally this package cannot provide solutions to specific use cases - but we do need to make it easy to implement whatever solution someone designs for their application's use case.

Dear @lindyhopchris ,
thank you very much for your detailled explanation on my questions in this issue. That is a premium-support i guess :laughing:
5:
Yeah, i seen that example. But it only allows to have 2 different validators (one for create and one for update). However, if have different routes to update particular aspects of a model, this may not work. For example, i would like to have a route to update personal details of a user (firstname, lastname, address information) and another route to update his settings (e.g., preferred language), this would both map to the same validator. In this case, my client would need to send the setting fields with the "update personal details" request in order to be compliant..
7:
yeah, thats what i thought as well would be a viable strategy. I will have to think about this in more details..
When thinking about this package and JSON:API in general, another question arises:
8:
How would you deal with "non JSON:API compliant" routes? A typical example would be the /login and /logout routes. To be JSON:API compliant would need to send only a subset of a User object to the API (e.g., the email and password attributes). Would you provide a "new" Resource type for this (e.g, "credentials")? Because actually Credentials would not be a (Laravel / Eloquent) Model but rather be a subset of the User model. Further, if the user is successfully logged in, you should return a Token resource - and again, this does not "really" exist in your application ;) Furthermore, to be compliant you should use the same resource-names in the URL - so actually the client should send a login resource?! and for the DELETE /logout the client would need to send a logout resource to the API - which does, obviously, not exist again ;)
Dont get me wrong - i really (!) really like JSON:API and i adore and admire the effort the community has put into this standard. However, from the developers-point-of-view that provides the API following the standard there are some quirks i don't know how to deal with :disappointed:
That is the main reason why i used Fractal in another project and just "try to follow" the JSON:API standard "as best as possible".. But there were quickly so many exceptions that it feels "wrong"..
Thanks for discussing..

What about just using non-JSON:API endpoints for login/logout? In my opinion it does not make much sense to add resource types for login/logout @johannesschobel.

yeah, of course it isn't really useful to add resource types for the login/logout routes. However, then, these 2 routes would "fall out of the frame" and would behave different - which is quite bad and for other devs interacting with the API frustrating and strange..
Especially when considering that those 2 routes are crucial to nearly every web service application you're building 😆

Yes, they would behave differently. But to be honest, I don't think this is critical. If you use an auth scheme like OAuth for example, there is also a standard which defines how the response should look like. If you document that, link the RFC you're good imo.
There were discussions regarding that topic:
https://discuss.jsonapi.org/t/json-api-response-format-for-non-resource-data-like-oauth-token/74
I personally

@jannis-a  It has no final answer, I am still confused. It seems that I should be follow the RFC's standard and "use the 'application/json' media type as defined by [RFC4627]". A project uses two media types, is it appropriate?

I have a User model that has some basic attributes (username, email, firstname, ...) and complex attributes like settings (e.g., his default language, preferred configuration of the application and so on). In order to manage the "own profile" of the user (i.e., change username, email, firstname, ...) he may PATCH /users/1234 with the appropriate data. However, i would NOT like to send the settings information because this may be done in another workflow / wizard / ... . So i would like to add another route (e.g., PATCH /users/1234/setting) so change these values (just send a json and store it directly within the DB).

@johannesschobel It seems like you are having a misunderstanding of JSON:API specification at these point. The specification supports partial updates:

If a request does not include all of the attributes for a resource, the server MUST interpret the missing attributes as if they were included with their current values. The server MUST NOT interpret missing attributes as null values.
https://jsonapi.org/format/#crud-updating-resource-attributes

That means that there is no need to have different routes to update different parts of a resource. The client could use the same route for both scenarios. There is no need to split up routes accordingly to user interface.

Dear @jelhan ,
i am aware that you can re-use the same endpoint with PATCH verb to "partially" update the resource. However, you may need complex validation patterns and database operations, so it may (!) be useful to split it up into different routes. For example, if you want to store the settings in another database table or whateve..
This may, however, be subject to the specific application / database design..
Further, in my initial post i wrote

I know, this may not be JSON:API compliant!
:laughing:

All the best

Closing this as the original questions are related to a really old version. Feel free to open a new issue if there's still any problems - probably best to open an issue per question too as that's easier to keep track of.


Not getting it to work

import * as d3 from 'd3';
import { Graph } from 'graphlib';
import dot from 'graphlib-dot';
import dagreD3 from 'dagre-d3v4';

const svg = d3
	.select('body')
	.append('svg')
	.attr('width', window.innerWidth)
	.attr('height',window.innerHeight)

var digraph = dot.read("digraph { 1; 2;}");

console.log(digraph.nodes());
console.log(digraph.edges());
console.log(digraph.edge("1", "2"));

svg.append('g');

var renderer = new dagreD3.render();

digraph.children = () => [];
console.log(digraph);

renderer(d3.select("svg g"), digraph);

create-nodes.js:26 Uncaught TypeError: Cannot read property 'select' of undefined
    at SVGGElement.<anonymous> (create-nodes.js:26)
    at Selection.__webpack_exports__.a [as each] (each.js:5)
    at createNodes (create-nodes.js:24)
    at fn (render.js:25)
    at Object.name (index.js:42)
    at __webpack_require__ (bootstrap c4fe5883d869c05f87ce:19)
    at Object.<anonymous> (intersect-rect.js:32)
    at __webpack_require__ (bootstrap c4fe5883d869c05f87ce:19)
    at __webpack_exports__.b (bootstrap c4fe5883d869c05f87ce:62)
    at bootstrap c4fe5883d869c05f87ce:62

I also tried the following example but I'm getting the same error: http://www.samsarin.com/project/dagre-d3/latest/demo/sentence-tokenization.html

Hi Frank,
This is not a dagre-d3v4 issue; both your code and the linked example work when their javascript dependencies are loaded directly. Check your webpack setup -- hopefully you can find the problem there.


Improve back to top with helpers and display fixes

@AndrewGibson27, pretty straight-forward so I'm going to merge, but please feel free to comment if anything comes to mind on this one.


Add profile photo, PPP and update AboutUs.md

Works towards #31, #32, #37

Codecov Report
Base: 72.15% // Head: 72.15% // No change to project coverage :thumbsup:

Coverage data is based on head (3bd4be2) compared to base (7facae9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #43   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add JSS example

/cc @kof who might want to review this
Closes #1

Thanks, will do.

What I would love to see as well is using a separate module with constants for colors, because it shows the possibilities.

Awesome, thanks for going through this! Will update soon

Pushed commits with fixes for the suggestions, will merge for now! Let's do #24 and #25 and iterate on all of the examples with more general fixes.


Remove --progress from webpack

Webpack does not detect if it's run in CI and it's rather spammy to see in all the builds. It probably slows down the builds too.

Milestone, 2.5.0 / 2.6.0 ? Seems to me that it can go whenever regardless of release.


Fetch options for CE and MDL

Check #40

Discard current realization. It will replace with meta tag realization.

Please, let's work only with fetch's headers param. Cases like CORS and others, please, do not consider at this time. Just let's leave headers as an name-space that will not collide with other set of params.

We need this solution at least as an alpha version in order to close an issue related to cache at LocoTech project.

Closing #40


Em amazed patch 1

modify text and file pull request

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement
Learn more about why HashiCorp requires a CLA and what the CLA includes

0 out of 2 committers have signed the CLA.

[ ] Emilie Ying
[ ] emAmazed

Emilie Ying seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.
Have you signed the CLA already but the status is still pending? Recheck it.


fix(TabBar): reinit when adding/removing tabs dynamically.

Fixes #67

I've fixed the check to use the key property array literal for diffing. It's probably an overkill to have it there. Also, the event handlers were not being released so MDCTabFoundation->destory is now called before the TabBar component is reinitialized.
and updated the story to test the dynamic nature of it.

Thank you so much for this! I’ll dig in later today and make sure this gets in the next release.


Update README.md

Added SecKC to Kansas too :)

I am going to update the description text about SecKC as well.  I will submit another PR


ERROR 1017 on EXPO

Target device: (Note: simulators are not supported for running the UIKit)

Device: [e.g. iPhone6]
OS:

[] IOS
[X] Android

OS Version: [11]

App Info

Type:

[] React Native CLI
[X] Expo CLI (using custom development clients)

CLI Version: [SDK 45]

Describe the issue
Hi! I'm using VideoUIKit-React Native.
Following the instructions with only Agora Video Code was working fine after doing expo run:android, but when I move the code to another screen.. there was an error. Seems to connect fine, but an  Error: 1017 appears. Micro and Camera permissions are asked before open video.
To Reproduce
Steps to reproduce the behavior:

Inlcude Video not in main screen.
Run expo run:android

Screenshots

Can you reproduce this with the latest version of the UIKit?


Remove FutureUtil method with standard library equivalent

There are but I started to go down the rabbit hole and realized other stuff was more important today :P


pwa-node debugger launch type with runtimeVersion and nvm causes PATH to be reset

VSCode Version:
Version: 1.50.1
Commit: d2e414d9e4239a252d1ab117bd7067f125afd80a
Date: 2020-10-13T14:44:48.716Z
Electron: 9.2.1
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: <IP_ADDRESS>-electron.0
OS: Linux x64 5.8.0-7625-generic

OS Version:
Distributor ID: Pop
Description:    Pop!_OS 20.10
Release:        20.10
Codename:       groovy

Steps to Reproduce:

Add a launch config that uses pwa-node, runtimeVersion in an environment that uses nvm

node works fine and pwa-node works fine when runtimeVersion is not set.
e.g.
{
            //"type": "node",
            "type": "pwa-node",
            "request": "launch",
            "name": "NodeJS run file",
            "runtimeVersion": "12.13.1",
            "program": "${file}",
            "cwd": "${workspaceFolder}/pkg/angular",
            //"skipFiles": ["<node_internals>/**"],
            "console": "integratedTerminal",
            "resolveSourceMapLocations": [
                "${workspaceFolder}/**",
                "!**/node_modules/**",
                "!**/.yarn/**"
            ],
            "runtimeArgs": [
                "--nolazy"
            ],
            "env": {
                "fos_allow_foreign_node":"yes",
            },
            "outFiles": [
                "${workspaceRoot}/Gruntfile.js",
                "${workspaceRoot}/grunt_tasks/**/*.js",
                "${workspaceRoot}/pkg/**/*.js"
            ],
            "args": [
                "watch",
            ]
        },

Run your node application

console.log('PATH=',process.env.PATH);
process.exit(1);

PATH no longer contains useful locations such as /usr/bin
Process exited with code 1
PATH= /home/jpate/.nvm/versions/node/v12.13.1/bin

Does this issue occur when all extensions are disabled?: Yes
To workaround this issue you can set PATH in the "env" section manually, but it sucks :D

It sounds like you're hitting https://github.com/microsoft/vscode/issues/106537
/duplicate

Cool, the original issue has none of the keywords I was looking for so hopefully this dup helps steer ppl towards Revisit hardcoded timeout for resolving shell environment blocking first window :D


Upgrade to Go 1.22.6 & RBAC fixes

What this PR does / why we need it:
Upgrade to Go 1.22.6 & RBAC fixes.
Which issue(s) this PR fixes:

Fixes #
What type of PR is this?

/kind chore
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:

Upgrade to Go 1.22.6

Documentation:

NONE

/approve

/lgtm


Make sure we have c-jemalloc package

c-jemalloc is needed to have embedded rocksdb. The previous PR removed it accidentally because glide up would have cleared this since it was not present in glide.yaml.

Changes Unknown when pulling 9c8c7ac4ecb50e4d5fb13adf35d4662f14cc4ad3 on fix_rocksdb_embed into ** on master**.

Changes Unknown when pulling 9c8c7ac4ecb50e4d5fb13adf35d4662f14cc4ad3 on fix_rocksdb_embed into ** on master**.


I have created pull request please check pull request for more details.

https://github.com/Bindambc/whatsapp-business-java-api/pull/139

https://github.com/Bindambc/whatsapp-business-java-api/pull/139


Sort import of dependencies and add import linter

Adds import linter with flake8-import-order. Ignoring I201.
Applies isort  -m 7 --sl to all files.

Much needed :). Thank you.


When I visite the web page the content flashes then everything turns black.

I'm trying to self host this on my ubuntu server via docker. I am running it with the following docker-compose.yml
version: "2.1"
networks:
    Net:
        external: true
services:
    RxResume:
        image: amruthpillai/reactive-resume
        container_name: RxResume
        #volumes:
        ports:
            - 5050:80
        networks:
            Net:
        restart: unless-stopped

I can navigate to the page in my browser.  The favicon appears and the content flashes for a moment then everything goes black.
I'm honestly not sure what to do or what the issues it.  I'm using brave and it happens when using edge as well.
Thanks for any help!

dockerhub is not updated.
Similar to #430 , please take a look at this comment: #430  (comment).
For those who need to build v2, here is docker build script with traefik 2 enabled
version: '3.3' services:   resume:     build:       context: https://github.com/AmruthPillai/Reactive-Resume.git       args:         FIREBASE_APIKEY: ""         FIREBASE_APPID: ""         FIREBASE_AUTHDOMAIN: ""         FIREBASE_DATABASEURL: ""         FIREBASE_MEASUREMENTID: ""         FIREBASE_MESSAGINGSENDERID: ""         FIREBASE_PROJECTID: ""         FIREBASE_STORAGEBUCKET: ""     restart: always     networks:       - traefik-public     labels:       - traefik.enable=true       - traefik.docker.network=traefik-public       - traefik.constraint-label=traefik-public       - traefik.http.routers.resume-http.rule=Host(example.com)       - traefik.http.routers.resume-http.entrypoints=http       - traefik.http.routers.resume-http.middlewares=https-redirect       - traefik.http.routers.resume-https.rule=Host(example.com)       - traefik.http.routers.resume-https.entrypoints=https       - traefik.http.routers.resume-https.tls=true       - traefik.http.routers.resume-https.tls.certresolver=le       - traefik.http.services.resume.loadbalancer.server.port=80 networks:   traefik-public:     external: true

dockerhub is not updated.
Similar to #430 , please take a look at this comment: #430 (comment).

Can you be more specific when you say dockerhub isn't updated? I don't see anything in the linked thread about something being out-of-date.

I'm also experiencing this issue.
I've passed the env-variables in my compose file.

Also getting the same with the env variables included.

I have the same behavior. API-key is correct but devtools claim it is wrong

@AmruthPillai do you know if there's any movement/visibility on this particular issue at all?
Thanks!

I don't have visibility into this as I don't really depend on docker for my own deployment or development. But regarding the error, it just has to be how ENV vars are loaded onto the webpack server during build time. I would suggest maybe looking into how Gatsby loads .env variables through Docker.
When I built this, I didn't have self hosting as the number one concern, hence the issues we're facing now. I apologise for that. Will do what I can to sort this out in one of the weekends I get to work on Reactive Resume :)

Would changing the storage to SQLite be a suitable consideration? This would potentially resolve a lot of the self hosting requirements/issues now and in future.

@modem7 SQLite, or even a packaged Postgres bundle along with the app would do wonders. The main reason I didn't go with that approach is authentication. I didn't want to build the whole system from the ground up, and there can be a lot of loopholes when it comes to auth which I didn't want to risk.

@AmruthPillai totally makes sense!
Docker wise at least, many people would use third party auth systems like authelia, so you wouldn't really need to do anything much with that side of things.
At least in my experience, something like an admin endpoint for editing stuff can be very easily secured (even if it's a simple htaccess) (eg /admin), then standard public view wouldn't need to have anything fancy on it (if at all really given the nature of the project).
The issue ofc, comes if you wanted to make a multiple users feature etc later down the line, but even then, either a oauth connector or simple auth would be good ways of potentially looking at it.
Granted, I'm a sysadmin, not a dev, so definitely don't know the scope of how complex it'd be to do this.

I actually didn't know about Authelia. That sounds like a really good package deal to include. I am currently, but slowly, working on refactoring the codebase here to move to NextJS and along the way, fix some things like Docker and over dependency on Firebase as well. I get about $80 monthly bills from this, which is most paid out of my pocket to support the use.
Moving away from Firebase is my eventual aim, at least for the project to sustain. Will definitely consider these open source auth platforms that can be plugged in instead of building it from scratch.

The other potential thing you could do (and arguably probably simpler), is
use nginx to serve the web server side, and include basic auth.
Easy to deal with, not (too much) mucking around, and lots of
implementations out there that use that method, and you can still point
authelia to it as well. Hopefully some c+p the base config from another
project's dockerfile might ease some of the burden.
On Sun, 27 Jun 2021, 21:16 Amruth Pillai, @.***> wrote:

I actually didn't know about Authelia. That sounds like a really good
package deal to include. I am currently, but slowly, working on refactoring
the codebase here to move to NextJS and along the way, fix some things like
Docker and over dependency on Firebase as well. I get about $80 monthly
bills from this, which is most paid out of my pocket to support the use.
Moving away from Firebase is my eventual aim, at least for the project to
sustain. Will definitely consider these open source auth platforms that can
be plugged in instead of building it from scratch.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/AmruthPillai/Reactive-Resume/issues/493#issuecomment-869218280,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABBGACRJLNU7JHPY42ZNMHTTU6BIFANCNFSM45BHRTLQ
.

Closing this in favor of Reactive Resume v3 release.
If you continue to face this issue, please raise a new one and I'll have a look at it as soon as I can.
In the meantime, if you are able to, please consider donating to keep supporting the project: https://www.buymeacoffee.com/AmruthPillai :)
Thank you!


Hridya P Das

DSC TIU Assignment on Android: Dice roller app with total calculator. Finished

resubmission required