Implement streaming preview window

Preliminary implementation of the streaming preview window. Please test and report any bugs. Fix #2212.
# Will start rendering after 200ms, update every 100ms
fzf --preview 'for i in $(seq 100); do echo $i; sleep 0.01; done'

# Should print "Loading preview" message after 500ms
fzf --preview 'sleep 1; for i in $(seq 100); do echo $i; sleep 0.01; done'

# The first line should appear after 200ms
fzf --preview 'date; sleep 2; date'

# Should not render before enough lines for the scroll offset are ready
rg --line-number --no-heading --color=always ^ |
  fzf --delimiter : --ansi --preview-window '+{2}-/2' \
      --preview 'sleep 1; bat --style=numbers --color=always --pager=never --highlight-line={2} {1}'

/ping @p-kolacz @edi9999

I see some issues on some of my custom scripts.
Only the first line is shown even after the preview has fully loaded.
When I start to scroll to the bottom, then I see the second line and the ones after that.
I'm trying to create a simple example.

Actually it can be reproduced simply with the following :
FZF_DEFAULT_OPTS="" ./bin/fzf --preview 'echo "1"; sleep 1; echo 2' --preview-window 'nohidden'

See recording :

You can also reproduce the same issue (probably), with the following :
FZF_DEFAULT_OPTS="" ./bin/fzf --preview 'for i in $(seq 10); do echo $i; sleep 0.13; done'

Here, on my computer, only the first 3 numbers are shown (numbers 1 to 3).
with :
FZF_DEFAULT_OPTS="" ./bin/fzf --preview 'for i in $(seq 10); do echo $i; sleep 0.11; done'

it writes number from 1 to 8.

with FZF_DEFAULT_OPTS="" ./bin/fzf --preview 'for i in $(seq 10); do echo $i; sleep 0.10; done',
everything works fine, so there is something special happening near 1 tenth of a second.

Nice find, 63444b4dee580b65a017eb36d67ada40901433bc should fix that.

I'm also seeing an issue where fzf not terminating the running command when the cursor is moved. Need further investigation.

There's one behavior I'm not sure is intended :
When I run the following :
fzf ./bin/fzf --preview ' yes | head -n 20; sleep 5; echo foo ;  ' --preview-window 'up:nohidden'

It shows the 1/20 while loading, even though the preview does not have a scroll.
After the sleep and the echo foo however, the 1/20 disappears.
I suggest to put only the loading screen in this case.
Maybe to avoid some "jittering", it would make more sense to put the loading on the right of the pagination, or maybe one line below that.

This is the intended behavior as of now. You can see there's a braille character indicating that the stream is open (i.e. ⠋ 1/20). We don't know if the final number of lines will exceed the height of the window or not at this point.
# `⠋ 1/20` disappears when the stream is closed
fzf --preview ' yes | head -n 20; sleep 5; echo foo ;  ' --preview-window 'up:nohidden'

# `1/1020` remains (spinner on the left gone)
fzf --preview ' yes | head -n 20; sleep 5; seq 1000; sleep 1' --preview-window 'up:nohidden'

One idea is to only print ⠋ without numbers before the content overflows.

One idea is to only print ⠋ without numbers before the content overflows.

Yes, exactly, that is what I thought would make more sense, but I also would understand that you'd prefer to keep current behavior.

I have just tested again and it seems to work well for me.

I'm going to merge this as it all seems to be working fine and test it over the next few days. Please let me know if you find any issues.

Yes, sure I will !


As developers, can we help implement the functionality of adding new coins？

When will Luna be added

soon bro


Secrets with GnuPG support

This exposes a new secrets command to help write and reveal secrets with the goal of avoiding any sensitive data in templates or compiled files.
Every new secret requires a token path and recipients which will be written to a file structure generated by the --write argument.
The content of a secret token file contains the GnuPG encrypted secret data and a list of recipient fingerprints.
Example of encrypting the content of files/secret_sauce into the app1/secret1 token:
$ echo "super secret data" > files/secret_sauce
$ kapitan secrets --write app1/secret1 --recipients<EMAIL_ADDRESS>-f files/secret_sauce

Tokens can be used in templates and inventory and will not be revealed when compiled. Any compiled file with secrets will contain the secret token tags instead.
A token tag is in the form of  ?{backend:path/to/secret}. To refer to the secret above, use ?{gpg:app1/secret1}
To reveal secret, the --reveal argument will read a file and resolve the token tags by reading the file structure and decrypting (should the one revealing be a recipient) to stdout only.
The reason for stdout here is to discourage saving revealed files into disk and instead pipe their output into i.e. kubectl apply -f
Example of revealing content with the app1/secret1 token:
$ echo "this string has ?{gpg:app1/secret1}" | kapitan secrets --reveal -f -
this file has super secret data

This solution does not do any key management. That is a problem that the user will need to do by managing his GnuPG keys and settings. The assumption with this solution is that the keys used for recipients are trusted (otherwise python-gnupg will fail).

LGTM once checks pass


issue on boot

What happened?

hello my friend I'm curious if you've ever seen this before and how to fix it this is happening whenever the machine is turned on and the card is attempted to be accessed. machine was working fine for many hours turned it off came back turned it back on then this issue. c702- a=20 x=00 y=FF P=B5 S=F9
Hardware Version
Seventh Prototype (lastest classic hardware)
Firmware Version
0011 / 8011 (add clock driver)
Driver Version
0030 (add support for meta key)
Shell Version
0011 (add support for meta key)
Where are you seeing this problem?
Boot
What computer is this running on?
Apple //e (enhanced / platinum)

Depending on which other cards and software you run, it is possible to accidentally overwrite the firmware on the Apple2-IO-RPi card. Since you have a v7 board, you can change the jumpers to put the EEPROM in read-only mode. I'd recommend trying to rewrite the firmware, then set the jumpers for read-only mode. Actually, you might want to try that with only the A2IORPi card in the system to ensure it doesn't get messed up.

I bought the card pre-assembled can you tell me of a good eprom programmer that I could use.

If the card has the AT28C64B chip on it, you can actually use the Apple II to program the firmware, although it will only program for the slot that the card is located in. After rewriting the firmware, I'd recommend setting the jumper to make it read-only.

would it be possible to get the Flasher onto a floppy image   I did something wrong and now I'm getting this error after shell      Apple2-IO-RPi not found

It looks like it's still booting and you have a valid drive image. The Apple2-IO-RPi not found error is likely caused by corrupt firmware bytes. Try running -UPDATE.FIRMWARE, then set the jumper to read-only mode after. Also, best to try this with no other cards in the system in case there is a conflict and something else tries to write to the EEPROM space.


Split out sidebar categories/tags views

Split the category and tag sidebar views into their own React views.
Review: @freddyrangel, @spicyj

:+1:


Support for Stripe API New Feature Account

Please review documentation below
https://stripe.com/docs/api#account
is there a road map to add support for the rest of the Stripe API

Merged PR #48


Fixed #28265 -- Prevented renderer warning on widgets.render() with **kwargs

Thanks for the review. I have made the suggested edits.


Exeption and fatal shutdown.

It seems to work for hours, but after some inactivity i have this error. I was uploading music and then server stopped.
node: ../nptl/pthread_mutex_lock.c:80: __pthread_mutex_lock: Assertion `mutex->__data.__owner == 0' failed.
Aborted

npm ERR<EMAIL_ADDRESS>start: `node lib/server.js`
npm ERR! Exit status 134
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is most likely a problem with the groovebasin package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node lib/server.js
npm ERR! You can get their info via:
npm ERR!     npm owner ls groovebasin
npm ERR! There is likely additional logging output above.
npm ERR! System Linux 3.2.13-grsec-xxxx-grs-ipv6-64
npm ERR! command "/usr/local/bin/node" "/usr/local/bin/npm" "start"
npm ERR! cwd /home/svandecappelle/groovebasin
npm ERR! node -v v0.10.25
npm ERR! npm -v 1.3.24
npm ERR! code ELIFECYCLE
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR!     /home/svandecappelle/groovebasin/npm-debug.log
npm ERR! not ok code 0

Just wanted to pitch in that on a recent Debian Jessie deployment (with my weird s3-fuse backed library) I hit this also. Thanks again for groovebasin! :+1:

Thanks for the report. I've been making big changes to libgrooveplayer recently, and once those changes are complete I hope I can trouble the both of you to test out the new code and see if it resolves the issue.

I'd love to. It would be vastly easier on my end if packages made it into jessie-backports or similar. :)


Update s2sConfig docs with configurable URLs

As described in https://github.com/prebid/prebid.github.io/pull/477, this will now look something like:
pbjs.setConfig({
    cache: {
        url: "https://prebid.adnxs.com/pbc/v1/cache"
    },
    s2sConfig: {
        ...
        endpoint: "https://prebid.adnxs.com/pbs/v1/auction",
        syncEndpoint: "https://prebid.adnxs.com/pbs/v1/cookie_sync",
        ...
    }
});

All mentions:
ack --ignore-dir=_site 's2sConfig:'
dev-docs/get-started-with-prebid-server.md
73:        s2sConfig: {

dev-docs/modules/s2sTesting.md
43:  s2sConfig: {
116:  s2sConfig: {
141:  s2sConfig: {
181:  s2sConfig: {

dev-docs/publisher-api-reference.md
1165:    s2sConfig: {

@bretg should the examples of s2sConfig on this s2s testing module page also be updated to use the configurable URLs? E.g.,
endpoint: 'https://prebid.adnxs.com/pbs/v1/auction'
syncEndpoint: 'https://prebid.adnxs.com/pbs/v1/cookie_sync'

I assume the answer is yes, but I'm not familiar with the testing syntax and wanted to make sure since you submitted that doc.

This issue is addressed by https://github.com/prebid/prebid.github.io/commit/e698b4e8bdc5bef505a3383ebede66580a49299b


Getting Fatal error: Cannot read property 'messages' of null

Hi,
Overnight, it seems like one of the dependencies from html-angular-validate, w3cjs, got an update from version 0.3.0 to 0.3.1 and a bunch of its own dependencies have changed. From that point on, whenever I try to run htmlangular using grunt-html-angular-validate, I get the following message :
Running "htmlangular:main" (htmlangular) task
Fatal error: Cannot read property 'messages' of null

Process finished with exit code 3

Does that ring a bell to anyone? Is there an easy way to fix this?

Hi @ftdube,
I had the same problem, I just fixed it with these changes:
Prevent undefined options


video/clapper: init at 0.4.0

Motivation for this change
A GNOME media player build using GJS with GTK4 toolkit. The media player is using GStreamer as a media backend and renders everything via OpenGL.
https://github.com/Rafostar/clapper
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@tomfitzhenry 0.4.0 is released! And here is my package: https://github.com/VergeDX/config-nixpkgs/blob/master/packages/gui/clapper.nix

@tomfitzhenry 0.4.0 is released! And here is my package:
https://github.com/VergeDX/config-nixpkgs/blob/master/packages/gui/clapper.nix

Great! 0.4.0 fixes the issues this PR had re the binary using argv[0] to build a resource path (which broke when wrapGapps changed argv[0]).


Worker loader eslint support and documentation

Will have to rebase with master to see the meaningful changes.

Have added eslint overrides to allow usage of self in *.worker files
Added general documentation on usage of works with create-react-app, as well as Typescript specific usage.

Alright have merged changes into this so tests pass now, should be good to merge if you're happy with it @iansu


Fixing AttributeError: 'NoneType' object has no attribute 'error' whi…

The following crash occurs when running out of file handles (related to the ulimit-discussion in issue #489)

Traceback (most recent call last):
File "/home/maraud3r/.cache/pypoetry/virtualenvs/crackmapexec-MRXVD3-M-py3.10/lib/python3.10/site-packages/impacket/nmb.py", line 899, in _setup_connection
sock = socket.socket(af, socktype, proto)
File "/usr/lib/python3.10/socket.py", line 232, in init
_socket.socket.init(self, family, type, proto, fileno)
OSError: [Errno 24] Too many open files
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/maraud3r/GIT/CrackMapExec/cme/protocols/smb.py", line 571, in create_smbv3_conn
self.conn = SMBConnection(self.host if not kdc else kdc, self.host if not kdc else kdc, None, self.args.port, timeout=self.args.smb_timeout)
File "/home/maraud3r/.cache/pypoetry/virtualenvs/crackmapexec-MRXVD3-M-py3.10/lib/python3.10/site-packages/impacket/smbconnection.py", line 80, in init
self.negotiateSession(preferredDialect)
File "/home/maraud3r/.cache/pypoetry/virtualenvs/crackmapexec-MRXVD3-M-py3.10/lib/python3.10/site-packages/impacket/smbconnection.py", line 120, in negotiateSession
packet = self.negotiateSessionWildcard(self._myName, self._remoteName, self._remoteHost, self._sess_port,
File "/home/maraud3r/.cache/pypoetry/virtualenvs/crackmapexec-MRXVD3-M-py3.10/lib/python3.10/site-packages/impacket/smbconnection.py", line 169, in negotiateSessionWildcard
self._nmbSession = nmb.NetBIOSTCPSession(myName, remoteName, remoteHost, nmb.TYPE_SERVER, sess_port,
File "/home/maraud3r/.cache/pypoetry/virtualenvs/crackmapexec-MRXVD3-M-py3.10/lib/python3.10/site-packages/impacket/nmb.py", line 893, in init
NetBIOSSession.init(self, myname, remote_name, remote_host, remote_type=remote_type, sess_port=sess_port,
File "/home/maraud3r/.cache/pypoetry/virtualenvs/crackmapexec-MRXVD3-M-py3.10/lib/python3.10/site-packages/impacket/nmb.py", line 753, in init
self._sock = self._setup_connection((remote_host, sess_port), timeout)
File "/home/maraud3r/.cache/pypoetry/virtualenvs/crackmapexec-MRXVD3-M-py3.10/lib/python3.10/site-packages/impacket/nmb.py", line 905, in _setup_connection
raise socket.error("Connection error (%s:%s)" % (peer[0], peer[1]), e)
OSError: [Errno Connection error (<IP_ADDRESS>:445)] [Errno 24] Too many open files
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "", line 1, in
File "/home/maraud3r/GIT/CrackMapExec/cme/crackmapexec.py", line 257, in main
asyncio.run(
File "/usr/lib/python3.10/asyncio/runners.py", line 44, in run
return loop.run_until_complete(main)
File "/usr/lib/python3.10/asyncio/base_events.py", line 649, in run_until_complete
return future.result()
File "/home/maraud3r/GIT/CrackMapExec/cme/crackmapexec.py", line 105, in start_threadpool
await asyncio.gather(*jobs)
File "/home/maraud3r/GIT/CrackMapExec/cme/crackmapexec.py", line 69, in run_protocol
await asyncio.wait_for(
File "/usr/lib/python3.10/asyncio/tasks.py", line 408, in wait_for
return await fut
File "/usr/lib/python3.10/concurrent/futures/thread.py", line 58, in run
result = self.fn(*self.args, **self.kwargs)
File "/home/maraud3r/GIT/CrackMapExec/cme/protocols/smb.py", line 143, in init
connection.init(self, args, db, host)
File "/home/maraud3r/GIT/CrackMapExec/cme/connection.py", line 65, in init
self.proto_flow()
File "/home/maraud3r/GIT/CrackMapExec/cme/connection.py", line 96, in proto_flow
if self.create_conn_obj():
File "/home/maraud3r/GIT/CrackMapExec/cme/protocols/smb.py", line 585, in create_conn_obj
elif self.create_smbv3_conn(kdc):
File "/home/maraud3r/GIT/CrackMapExec/cme/protocols/smb.py", line 574, in create_smbv3_conn
self.logger.error('SMBv3 connection error on {}: {}'.format(self.host if not kdc else kdc, e))
AttributeError: 'NoneType' object has no attribute 'error'

This little fix will allow cme to keep running.

That is really interesting. Do you have an idea how you run into a situation where self.logger is not set?

I did do some light investigation into it.
But I cannot say what it is.
As I just want to keep on using the tool for now, I have this little fix, but I also want to get to the root cause and understand it. Bear with me.


cast sig does not behave as expected on some inputs

Component
Cast
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
nightly-8478c0841b00789c735df68ad111105fa9204f55
What command(s) is the bug in?
cast sig
Operating System
No response
Describe the bug
This should fail but does not
cast sig "foo(uint999)"
0x54511ad7

This should succeed
cast sig "foo(function() external)"
# panic with 'Illegal abi' message

The root of the  problem is really over in ethers-rs. The parser does not handle function types in human readable ABI and does not make sure the bytes/int/uint sizes are correct, among other things.   ref https://github.com/gakonst/ethers-rs/issues/474
Some more  examples
Arrays with unit sizes are techincally valid solidity
In solidity this expands out to uint[60].
foo(uint[1 minutes] memory)

Arrays have a maximum size in solidity
This gets parsed as correct but is not.
cast sig "foo(uint[99999999999999999])"
0xfece5cb9

Should I have opened this issue in https://github.com/gakonst/ethers-rs/ ? It's really more of a problem there than it is a foundry bug.

cast sig "foo(function() external)"

I don't think it should? You cannot make these functions external, so they will never have a 4byte signature.
The others make sense to me.
There is another issue: Some Cast commands (cast call for example), we cannot use structs. AbiParser supports it, but it really just expands them into tuples. We should probably allow people to pass tuples (even though it is technically invalid) to support people calling functions with structs (and functions that return structs)

@mattsse Assigning you to this since it's the same underlying issue as #2025 and you assigned yourself to that one

function types are currently not supported by ethabi, there's simply not a type variant for them
tracked here https://github.com/rust-ethereum/ethabi/issues/273

If ethabi doesn't add function types then you could just treat them as bytes24 https://docs.soliditylang.org/en/latest/abi-spec.html#types

there are essentially two issues:

encoding/decoding
signature

which is handled here
https://github.com/rust-ethereum/ethabi/blob/451d029c69a1fce7c4d57cc117e985a31dc53627/ethabi/src/param_type/writer.rs#L25-L52
and would require another variant

Should be fixed in #2151, please let me know if it's not!


Fake element direction issue(Can be important)

Minimal example
Some Website's direction is coming from css for example

Your code does not work in this situations. Why you are using left or right? You can use top property I think just like this

I fixed that problem for my site. If you want I can open Pull request.
Or we can remove that fake element after copy why that element stay in the screen I do not understand

Thanks for pointing it out the rtl attribute.
That invisible element is required to facilitate the copying of content, without that one of our features won't work. You can look at the source code for more information.


SDK consumable services implementations

Feature :
Implemented consumable services for all the NimOS endpoints
Details :
1.Developed a template for generating all the NimOS services . The services contains generic method on objects e.g CREATE,MODIFY, DELETE and also contains methods by Name and by Id. It generated additional methods for Object type volume.
2.Create a new template for generating group_service_factory.go which initialises the endpoint services .
3.Change type from GroupService to NsGroupService as it was causing name conflict during Group object generation .
4.Modified volume_service_test.go unit test module to accommodate above changes.
Test :
XXXXXXXXXXXX$ go test
PASS
ok  	github.hpe.com/nimble-dcs/golang-sdk/pkg/service	42.530s

Thanks, @rgcostea for the code reviews. Appreciate it.


Job created by Job hook and None User gets stuck in Pending

Environment

Nautobot version (Docker tag too if applicable): 1.5.21
Python version: 3.10
Database platform, version: postgres
Middleware(s):

Steps to Reproduce

A jobhook is fired by an object update of a device bay
This device bay is updated by something (perhaps another job) with no user associated with the request, unsure exactly the case here as it is very intermittent in this environment

Expected Behavior
The job is run to completion

Observed Behavior
The job is stuck in pending state and never gets to redis
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/kombu/serialization.py", line 41, in _reraise_errors
    yield
  File "/usr/local/lib/python3.10/site-packages/kombu/serialization.py", line 220, in dumps
    payload = encoder(data)
  File "/usr/local/lib/python3.10/site-packages/nautobot/core/celery/__init__.py", line 129, in _dumps
    return json.dumps(obj, cls=NautobotKombuJSONEncoder, ensure_ascii=False)
  File "/usr/local/lib/python3.10/json/__init__.py", line 238, in dumps
    **kw).encode(obj)
  File "/usr/local/lib/python3.10/json/encoder.py", line 199, in encode
    chunks = self.iterencode(o, _one_shot=True)
  File "/usr/local/lib/python3.10/json/encoder.py", line 257, in iterencode
    return _iterencode(o, 0)
  File "/usr/local/lib/python3.10/site-packages/nautobot/core/celery/__init__.py", line 99, in default
    data.update(obj.nautobot_serialize())
  File "/usr/local/lib/python3.10/site-packages/nautobot/utilities/utils.py", line 517, in nautobot_serialize
    data["_user_pk"] = user.pk
AttributeError: 'NoneType' object has no attribute 'pk'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/django/core/handlers/exception.py", line 47, in inner
    response = get_response(request)
  File "/usr/local/lib/python3.10/site-packages/django/core/handlers/base.py", line 181, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/usr/local/lib/python3.10/site-packages/django/views/generic/base.py", line 70, in view
    return self.dispatch(request, *args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/nautobot/core/views/generic.py", line 411, in dispatch
    return super().dispatch(request, *args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/nautobot/utilities/views.py", line 116, in dispatch
    return super().dispatch(request, *args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/django/views/generic/base.py", line 98, in dispatch
    return handler(request, *args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/nautobot/dcim/views.py", line 2267, in post
    device_bay.save()
  File "/usr/local/lib/python3.10/site-packages/django/db/models/base.py", line 739, in save
    self.save_base(using=using, force_insert=force_insert,
  File "/usr/local/lib/python3.10/site-packages/django/db/models/base.py", line 787, in save_base
    post_save.send(
  File "/usr/local/lib/python3.10/site-packages/django/dispatch/dispatcher.py", line 180, in send
    return [
  File "/usr/local/lib/python3.10/site-packages/django/dispatch/dispatcher.py", line 181, in <listcomp>
    (receiver, receiver(signal=self, sender=sender, **named))
  File "/usr/local/lib/python3.10/site-packages/nautobot/utilities/utils.py", line 464, in _curried
    return _curried_func(*args, *moreargs, **{**kwargs, **morekwargs})
  File "/usr/local/lib/python3.10/site-packages/nautobot/extras/signals.py", line 92, in _handle_changed_object
    enqueue_job_hooks(objectchange)
  File "/usr/local/lib/python3.10/site-packages/nautobot/extras/jobs.py", line 1370, in enqueue_job_hooks
    JobResult.enqueue_job(
  File "/usr/local/lib/python3.10/site-packages/nautobot/extras/models/jobs.py", line 799, in enqueue_job
    transaction.on_commit(
  File "/usr/local/lib/python3.10/site-packages/django/db/transaction.py", line 128, in on_commit
    get_connection(using).on_commit(func)
  File "/usr/local/lib/python3.10/site-packages/django/db/backends/base/base.py", line 645, in on_commit
    func()
  File "/usr/local/lib/python3.10/site-packages/nautobot/extras/models/jobs.py", line 800, in <lambda>
    lambda: func.apply_async(args=args, kwargs=kwargs, task_id=str(job_result.job_id), **celery_kwargs)
  File "/usr/local/lib/python3.10/site-packages/celery/app/task.py", line 575, in apply_async
    return app.send_task(
  File "/usr/local/lib/python3.10/site-packages/celery/app/base.py", line 788, in send_task
    amqp.send_task_message(P, name, message, **options)
  File "/usr/local/lib/python3.10/site-packages/celery/app/amqp.py", line 510, in send_task_message
    ret = producer.publish(
  File "/usr/local/lib/python3.10/site-packages/kombu/messaging.py", line 175, in publish
    body, content_type, content_encoding = self._prepare(
  File "/usr/local/lib/python3.10/site-packages/kombu/messaging.py", line 268, in _prepare
    body) = dumps(body, serializer=serializer)
  File "/usr/local/lib/python3.10/site-packages/kombu/serialization.py", line 219, in dumps
    with _reraise_errors(EncodeError):
  File "/usr/local/lib/python3.10/contextlib.py", line 153, in __exit__
    self.gen.throw(typ, value, traceback)
  File "/usr/local/lib/python3.10/site-packages/kombu/serialization.py", line 45, in _reraise_errors
    reraise(wrapper, wrapper(exc), sys.exc_info()[2])
  File "/usr/local/lib/python3.10/site-packages/kombu/exceptions.py", line 34, in reraise
    raise value.with_traceback(tb)
  File "/usr/local/lib/python3.10/site-packages/kombu/serialization.py", line 41, in _reraise_errors
    yield
  File "/usr/local/lib/python3.10/site-packages/kombu/serialization.py", line 220, in dumps
    payload = encoder(data)
  File "/usr/local/lib/python3.10/site-packages/nautobot/core/celery/__init__.py", line 129, in _dumps
    return json.dumps(obj, cls=NautobotKombuJSONEncoder, ensure_ascii=False)
  File "/usr/local/lib/python3.10/json/__init__.py", line 238, in dumps
    **kw).encode(obj)
  File "/usr/local/lib/python3.10/json/encoder.py", line 199, in encode
    chunks = self.iterencode(o, _one_shot=True)
  File "/usr/local/lib/python3.10/json/encoder.py", line 257, in iterencode
    return _iterencode(o, 0)
  File "/usr/local/lib/python3.10/site-packages/nautobot/core/celery/__init__.py", line 99, in default
    data.update(obj.nautobot_serialize())
  File "/usr/local/lib/python3.10/site-packages/nautobot/utilities/utils.py", line 517, in nautobot_serialize
    data["_user_pk"] = user.pk

I believe the cause is due to not accounting for no user being provided here.


t-sne init error

Running pathogen-embed ... t-sne resulted in the error TSNE.__init__() got an unexpected keyword argument 'square_distances'. The same command but with umap or mds worked as expected. Happy to provide input data if that helps.
pathogen-embed version: 1.1.1 (via PyPi)
Python 3.10.13
scikit-learn Version: 1.4.0

Thanks for reporting this, @jameshadfield! It looks like that parameter was added in 0.24 and then removed in scikit-learn v1.3. The default behavior since 1.3 should be what we want, but we use 0.24.2 in our paper and should probably pin to that for now.


csi: fix csi addon side car container

Describe what this PR does
there was a wrong arg introduced, fixed it
It was found during testing of logrotate in downstream
Provide some context for the reviewer
Is there anything that requires special attention
Do you have any questions?
Is the change backward compatible?
Are there concerns around backward compatibility?
Provide any external context for the change, if any.
For example:

Kubernetes links that explain why the change is required
Ceph-CSI spec related changes/catch-up that necessitates this patch
golang related practices that necessitates this change

Related issues
Mention any github issues relevant to this PR. Adding below line
will help to auto close the issue once the PR is merged.
Fixes: #issue_number
Future concerns
List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.
Checklist:

[ ] Commit Message Formatting: Commit titles and messages follow
guidelines in the developer
guide.
[ ] Reviewed the developer guide on Submitting a Pull
Request
[ ] Pending release
notes
updated with breaking and/or notable changes for the next major release.
[ ] Documentation has been updated, if necessary.
[ ] Unit tests have been added, if necessary.
[ ] Integration tests have been added, if necessary.

/backport release-0.1

@mergifyio backport release-0.1

@Mergifyio backport release-0.1


Resize all job icons

About the PR

Resized all job icons to 16x16.
Why / Balance

Media

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

no cl

files changed 115, but theres 117 files in cm_job_icons. fuck.

files changed 115, but theres 117 files in cm_job_icons. fuck.

You are missing rmc_smartgunner.png and hudsquad_soctl_a.png
You can double check by viewing the cm_job_icons.rsi folder at your branch on GitHub: https://github.com/CM-14/CM-14/tree/a3da3116a43e95cecff75e099eb8c37c82febe93/Resources/Textures/_CM14/Interface/cm_job_icons.rsi

ready to review.


The key of nested object is displayed as a.b.c: value

It looks counterintuitive.
Is it a bug or feature?

Oh, it's a bug. PR Welcome if you're interested in it.


Database Type BIT does not exists

Laravel Version: 5.5
PHP Version: 7.1.8
Database Driver & Version: MYSQL 8.0

Description
I have a legacy system which has table column with MYSQL type BIT. Therefore, I created a migration and replicated all the types. When I tried to replicate the BIT type laravel seems to be missing Blueprint::bit() and Illuminate\Database\Schema\Grammars\MySqlGrammar::typeBit() methods.  To fix my problem I added those methods temporarily to make my application work.
Now the question is why does the Laravel not have the BIT type available for MYSQL?
Steps To Reproduce:
When trying to add database table field using Blueprint->addColumn('bit', 'fieldname') laravel returns this error
[Symfony\Component\Debug\Exception\FatalThrowableError]
  Call to undefined method Illuminate\Database\Schema\Grammars\MySqlGrammar::typeBit()

@aftabnaveed Can you explain in detail how you added these definitions? If this is to be added to MySQL, then it should be added for all drivers if supported.

Closing for lack of activity.


getQuery() on update/insert doesn't work.

Why is this the case? It shows undefined method.

GetQuery requires the type. So insert or update should be given in the first argument.


Add a sequence classification head to ProtGen2

I'm trying to put a sequence prediction head(= sequence classification with 1 output) on top of the ProGen2 model and am experiencing some problems.
For this one usually needs to pool the last_hidden_state outputs to create a vector and add a simple MLP on top. When doing this with ProGen2 the predictions end up being exactly the same no matter the input sequence. This is the case because the pooler just takes the hidden state corresponding to the first token, which is in this case always a 1. The first hidden state is not influenced by any consecutive tokens, which leads to predictions being always exactly the same. For some reason the attentions for the first token depends solely on the value of the first token, which is not the case for other transformer models (the pooler works fine in those cases).
Is this a conscious decision to design the hidden_states solely on tokens that come before the current token? In this case pooling over the last hidden state should work for a value prediction head I assume?

@enijkamp

I think I figured it out myself:
ProGen2 is based on GPT-J. For GPT-J a sequence-classification implementation exists that handles the problem I'm describing here.
They indeed use the last token of the sequence (but have to be careful if padding was used). I tried it and it seems to work fine that way.

@franzigeiger I don't quite see why GPTJForSequenceClassification has this batch size of 1 constraint. It would seem that if you truncate sequences or otherwise ensure each instance is the same length, then sequence_lengths = -1 should still be valid. Did you ever get this working with batch_size >1 ? Thanks


Push not working properly

Ionic

Component
Version

Cordova CLI
5.4.1

Ionic Version
1.2.4-nightly-1917

Ionic CLI Version
1.7.12

Ionic App Lib Version
0.6.5

Node Version
v5.3.0

Android

Component
Version

SO
6.0

SDK
23

Problem
I am using the ionic to receive push messages. All messages arrive correctly on the device, however, are displayed in the status bar, but without running the code defined in the notification event (onNotification).
angular.module('app', ['ionic', 'ionic.service.core', 'ngCordova'])
.run(function($ionicPlatform, $rootScope, $state, $ionicHistory) {

    $ionicPlatform.ready(function() {
        var push = new Ionic.Push({
            "onNotification": function(notification) {
                console.log('Push received.')
                navigator.vibrate(700);
            },
        });
    })

});

The above is only triggered after clicking on the notification.
I already tried everything I found solution and it still fails.
Could you help me?

Greetings @upmauro!
My sensors indicate that you need to update your issue through our custom issue form. We are now requiring all issues to be submitted this way, to ensure that we have all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
I will have no choice but to close this issue if it is not resubmitted through the form. Please fill out the rest of the form, so that I may use my friendly robot powers to assist you.
Thank you!

This issue was moved to driftyco/ionic-platform-web-client#45


Several ObsIDs selected on the ACCEPT-I sample positions don't get bad pixel files copied out

4920, 6137, 5829, 6136 (all ACIS data) fail the flux_image process because no bad pixel can be found.
That obviously must be traced back to the chandra_repro run, where bad pixel files weren't copied out (possibly because the file name template I created doesn't reflect their names?)
Trouble is I think chandra_repro fiddles with the stderr destination, as no moving errors appear in a stderr log - need to check it isn't DAXA's fault though.
Anyway, I'll try to figure out why those ObsIDs don't have the expected bad pixel files, but I will also add the bad pixel, aspect, and maybe dead time files (for HRC) to the list of paths for the run to check exist.

Those four look normal from their observation summaries

In the temporary directory of those four, there is no 'repro_bpix' file, for some reason it is just the original with the original name (like the asol files can be).
The badpixel argument to chandra_repro (now I look at it again) has a note:

This parameter setting does not apply when the input data were taken in ACIS continuous-clocking mode, as the ACIS afterglow and hot pixel tool cannot be used with this data mode.

And lo, all those four are in a continuous clocking mode - so I think we'll just have to add a check for a CC mode and change the expected output filename, nothing too arduous.


macOS typical functionality

Just starting with this so this might be an obvious question but I'm going through the examples and the book and can't find references to how I might add menu items to the (e.g. macOS) menu. (pictured below)

I also noticed that all examples (At least I tried about 90%) don't close on cmd + q as I would expect on macOS? Any pointers here to the docs bit I missed?

I completely missed the discussion tab. My bad.


Mutating a shallowRef object using $patch doesn't trigger reactivity

Reproduction
https://stackblitz.com/edit/github-5ayhfs4m?file=src%2FApp.vue
Steps to reproduce the bug

Define a shallowRef state (e.g. const counter = shallowRef({ count: 0 })) using setup stores syntax
Use the store in a Vue component
Update the state using $patch({ counter: { count: 1 }) syntax
The state is updated in store but the reactivity is not triggered

Expected behavior
At step 4, the Vue's reactivity system should trigger
Actual behavior
At step 4, the Vue's reactivity system does not trigger (no watcher/computed run after the state change)
Additional information
In the playground, I tested with two other ways to update the shallowRef's state, and the reactivity still works normally:
const counterStore = useCounterStore();
// Using $patch with update function: trigger reactivity
counterStore.$patch((state) => {
    state.counter2 = { count: state.counter2.count + 1 };
  });
// Direct mutate the state: trigger reactivity
counterStore.counter3 = { count: ... };

This is inherent to how shallowRef work. You can use the other ways to call triggerRef().
That being said, it's possible to make this work by calling triggerRef when a key of a shallow object is traversed for the $patch(patchObject)`. For the function syntax, it's up to the user to properly handle this.


"runPeriodSeconds" in "servers" does not work

In the configurationfile I used "cronExpression" but got a message that "cronExpression" is deprecated. I replaced it by "runPeriodSeconds". The deprecated message did not show up again, but jmx trans runs every minute, regardless of the value I enter.

 Fix coming up...

Thanks! Any idea when this will be included in a new release?

I can do a release this morning...

New release should be available on maven central...

I just tested it and it works. Thanks!

Good! Let us know if there is anything else not working :)


Implement use of cache in Google API python client

Hi,
Use of a cache is given as a performance improvement tip in Performance page.
You should turn on caching at the httplib2 level.
However, the only way I see it implemented is directly in Google API python client itself, in build_http(), L1906 sources.
If I am understanding well, this line should be replaced with:
def build_http(path: str = None):
    ...
    if path is None:
        http = httplib2.Http(timeout=http_timeout)
    else:
        http = httplib2.Http(timeout=http_timeout, cache=path)

Please, is this update feasible, and if yes, can you carry it out?
Thanks for your help.
Have a good day,
Bests,

Hi @yohplala,
You should be able to pass a http object to discovery.build with caching enabled.
https://github.com/googleapis/google-api-python-client/blob/d059ad881c7ae58c67931c48788d0bd7343ab16c/googleapiclient/discovery.py#L179

@busunkim96
Hi, thanks for the reply.
Thing is that I would like to manage both caching, thread-safety, and authorization within this httpobject.
This starts to be complicated.
You may remember our other discussion regarding thread-safety in #956
I encoutnrered the problem of how providing required authorization to my httpobject.
In the end, I could manage it by using _auth.authorized_http().
And within authorized_http(), the function build_http()` is used.
Hence my demand above to be enable caching directly within this function.
I don't see how I can follow your recommandation while still providing required authorization to my http object? Please, would you be able to map your recommandation on this working code that currently manages both thread-safety and authorization? (coming from #956 )
###Current code with thread-safety, but without caching:
from googleapiclient import _auth

# Initialization step: run once at the start
drive = discovery.build('drive', 'v3', credentials=scoped_credentials)

# Multi-threaded part of the code
new_http = _auth.authorized_http(scoped_credentials)
results = drive.files().list(pageSize=10, fields="nextPageToken, files(id, name)").execute(http=new_http)
items = results.get('files', [])

Thanks for your help!
Bests

Hi,
I actually submitted my trouble to httplib2 project, and got the answer.
If anyone is interested in the topic, here is the ticket.
Closing.
Bests,


[TypeScript] Impose limit on parameter r of permutations/combinations functions

Why?
I had created a change in index.d.ts to improve various functions such as combinations, basically, it will return Iterable<[T, T, ...]> instead of ambiguous Iterable<T[]>.
But it comes with a cost: The length of each tuple in the returning iterable depends on R (generic type parameter of r), it's works fine when R is number or an integer (or a union of integer) within the range of 0 - 99, but when it isn't, it causes TSC to run into infinite loop.
Therefore, I made this change to make TypeScript treats R differently based on its value.
How would it works?
I created two types: ReasonableNumber and CombinationsPermutations; ReasonableNumber is a union of 0 | 1 | ... | 31, and CombinationsPermutations is type of combinations/permutations functions.
type ReasonableNumber = UnionRange<32>;

type CombinationsPermutations = <T, R extends number>(iterable: IterableLike<T>, r: R) =>
  Iterable<R extends ReasonableNumber ? Repeat<T, R> : number[]>;

declare const combinations: CombinationsPermutations
...

When user call these function (like so: combinations(iterable, r)), the returning value will have type of:

[T, T, ..., T] (tuple) when r: R is within 0 - 31, the number of elements within tuple depends on value of r.
T[] (unbounded array) when r: R is not within 0 - 31 (e.g. -1, 2.5, 1000, number).
[T, T, ..., T] | [T, ...] | ... (union of tuples) when R is a union of number constant within 0 - 31.

Additional Changes

This pull request includes https://github.com/sithmel/iter-tools/pull/61 because I don't want to code bindly without tests.

Additional Requests

If this were to be merged, it should be published under rc tag first. I want to double-check it.

Included in #64


add disqus discussion plugin

Do you have some improvement ideas or features suggestion?

after thinking a bit:

we may add some share button at the end of articles
discussion could be facebook comments (since everyone has facebook account)


Remove ActionController::HideActions

Remove ActionController::HideActions because of Rails #18336
Require Ruby 2.2 for Rails 5.0 because of commit
Rubinius rubysl ~> 2.1 and added gem psysch into :rbx section of Gemfiles because of commit
Added missing records into Changelog

sorry, I will correct this PR pretty soon

@spastorino, could you please merge this PR?
I'm not sure on how to solve problem in rbx-2 for Gemfile.edge

Maybe we should remove HideActions for Rails 5 only.
About rbx-2 we can move to the allowed_failures matrix.

Corrected.


[Bug Title here] Rock paper scissors game page is not working

What happened?
i tried to search for rock,paper and scissors game
which is present but when I clicked on it, it did gave a 404 not found page
which I gues due to the page not present or not redirected properly
How can we reproduce this bug?
search for rock,paper and scissors and click on it
you can see the error

Desktop Information (Optional)
No response
Urgency (Optional)
Medium priority

@nagamukesh All the best 👍🏻

I'm excited about taking the lead on the 30DaysOfJavaScript project. With my proficiency in HTML, CSS, JavaScript, and ReactJS, I'm confident in my ability to drive significant progress on this initiative. Please assign me to this project via GSSOC.

@nagamukesh Any update ?

Hello @swapnilsparsh since this issue was taking time, I would like to tell You that, I have already solved this bug, and it would be appreciated if you can assign this to me.

https://github.com/swapnilsparsh/30DaysOfJavaScript/assets/143637324/8809d18b-6150-4040-b2d4-9c1062b535c3
Here it is, tested in my local environment, read to create a PR on your permission


Which apps can I control via app permission policies?

Right now I am looking searching all over the internet for more information regarding which specific Microsoft apps I can allow or block. This because I cannot find any way to block Microsoft Stream from the available Microsoft Teams apps. The same goes for the apps Edu Class Notebook and Edu Staff Notebook. Can you be more specific on this page what you can allow/block and what can't be controlled via app policies? Thank you!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b51eda6c-168c-7d99-7cc1-992b3d8feef2
Version Independent ID: 118a1b8f-f4b7-a778-70b1-d3161fc548ab
Content: Manage app permission policies in Microsoft Teams - Microsoft Teams
Content Source: Teams/teams-app-permission-policies.md
Service: msteams
GitHub Login: @LanaChin
Microsoft Alias: v-lanac

@SylvM1 thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.


dbt model for OP-RF4 metrics for all projects in oss-directory over all time (time series)

What is it?
We should have dashboards for all funded metrics, the first of which are RF4 metrics. We should maintain these models into the future so that we can demonstrate different types of counterfactuals.

Pre / post RF 4 funding - did it move the needle?
Pre-post  RF X funding - did other rounds move the needle without explicitly funding it? (what are the other factors)
Funded and non-funded projects - does it move the needle for either set in the long run?

The types of things we want to know are:

Are the ecosystem changes sticky? Which metrics, when funded have that effect?
Does it require perpetual continuous funding? Or are large periodic injections enough?

I'm sure there are many more questions we want to ask

This is probably the right time to introduce a metrics_id, we want to know exactly what definition was funded at what time

derived events
name: fulltime_developers
namespace: oso
source: OSO
event_sources:
  - GITHUB
event_types:
  - COMMIT_CODE
to_types:
  - artifact
  - project
  - collection
from_types:
  - id_type: artifact
     id_registry: trusted
aggregation_functions:
  - mean
window_intervals:
  - unit: day
    value: 30
    missing_dates: fill_with_zero
sampling_interval: daily

Status:

[ ] gas_fees
[ ] transaction_count
[ ] trusted_transaction_count
[ ] trusted_transaction_share
[ ] trusted_users_onboarded
[ ] daily_active_addresses
[ ] trusted_daily_active_users
[ ] monthly_active_addresses
[ ] trusted_monthly_active_users
[ ] recurring_addresses
[ ] trusted_recurring_users
[ ] power_user_addresses
[ ] openrank_trusted_users_count


Fix detection of xtensa ar tool

Fixes build error referenced in issue #5

I can confirm that this patch works on OS X Yosemite.

I can also confirm this patch works - please merge!

Confirms that this works on Yosemite 10.10.2.

Hey @tommie any hope of getting this merged so that building esp-open-sdk is less of a pain on OS X?

Ouch, sorry. For some reason I didn't receive email notifications for this repo. Looks good.

Sweet, thanks!

Well, I still have the problem: https://github.com/pfalcon/esp-open-sdk/issues/41


[JDK9] Fix code/build to work on JDK9

as requirement to move to JDK9 as requested by @n1hility
to properly run you need JDK 9 build b60(planned for release in 2 months)

Linux Build 1456 is now running using a merge of 90cff4eb95e697268b92c367fe8d7f6028157d14

Windows Build 1115 is now running using a merge of 90cff4eb95e697268b92c367fe8d7f6028157d14

Core - Full Integration Build 718 is now running using a merge of 90cff4eb95e697268b92c367fe8d7f6028157d14

Core - Full Integration Build 718 outcome was FAILURE using a merge of 90cff4eb95e697268b92c367fe8d7f6028157d14
Summary: Exit code 1 (new) Build time: 0:01:13
Build problems:
Process exited with code 1

Windows Build 1115 outcome was FAILURE using a merge of 90cff4eb95e697268b92c367fe8d7f6028157d14
Summary: Tests passed: 1563, ignored: 45; exit code 1 (new) Build time: 0:03:20
Build problems:
Process exited with code 1

Linux Build 1456 outcome was FAILURE using a merge of 90cff4eb95e697268b92c367fe8d7f6028157d14
Summary: Tests passed: 1563, ignored: 45; exit code 1 (new) Build time: 0:04:20
Build problems:
Process exited with code 1

needs some rework...


csv: update capabilities to seamless upgrade

update csv capabilities from Basic Install to Seamless Upgrade

Checklist:

[ ] Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
[ ] Reviewed the developer guide on Submitting a Pull Request
[ ] Pending release notes updated with breaking and/or notable changes for the next minor release.
[ ] Documentation has been updated, if necessary.
[ ] Unit tests have been added, if necessary.
[ ] Integration tests have been added, if necessary.

/cherry-pick release-4.17


MINOR: Fix some compiler warnings

Setting fail-on-warn and resolving all warnings in one PR turned out to be too large a change, and also hard to debug (see https://github.com/confluentinc/kafka-streams-examples/pull/201).
Instead, this change just enables the warnings, and then resolves some of the warnings.
We can follow up by tackling more warnings in another PR.

merged and pint-merged. Thanks @ableegoldman @mjsax and @bbejeck !


Memo doesn't print.

Following the main readme.md the Memo doesn't seem to be printing. You can check under the account 'mirrorserver' on the main net.

https://eospark.com/MainNet/tx/5b8d8f3abba35afc32aeab55cf86d83aa886250664a72c82a242c860b76a7ffa

looking at the link is printing?


Bump jest dep

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.79%. Comparing base (cdb349c) to head (718ff87).
Report is 1 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #401   +/-   ##
=======================================
  Coverage   98.79%   98.79%
=======================================
  Files          16       16
  Lines        1572     1572
  Branches      438      438
=======================================
  Hits         1553     1553
  Misses         18       18
  Partials        1        1

Flag
Coverage Δ

unittests
98.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


bugfix: potential null pointer error in transfer queue processor

bugfix: potential null pointer error in transfer queue processor

Coverage decreased (-0.01%) to 67.762% when pulling 17842e680dd28fe246d7cf15628a092f65086269 on bugfix into 8cc931913e28348db0a79e89bb31b4a9e40ad4a8 on master.


folder clarification proposal

proposal to clarify alternative folder structure approach
relates to https://github.com/cloudflare/hellogopher/issues/10#issuecomment-274560033

Thanks! That reads well.


⚠ Ixtanet SAT has degraded performance

In faf318a, Ixtanet SAT ($MEDIA_SAT) experienced degraded performance:

HTTP code: 200
Response time: 20511 ms

Resolved: Ixtanet SAT performance has improved in caec0c1.


Footer Section

In the footer section of the Home page, the GitHub icon is shown multiple times.

Hi @lovishprabhakar,
Kindly assign this issue to me.
Thanks

Go for it @Jai-Marothiya!

Hi @lovishprabhakar,
I created the pull request, kindly merge it with the "Hacktoberfest merge" label.
Thanks


Map and inject Controller context in Handle

Somehow it is possible to map the controller context and automatically inject into a type of handler using the standard asp.net core IOC?
Convert this:
public class SomeController : Controller
{
	private readonly IMediator _mediator;
    public SomeController(IMediator mediator)
    {
        _mediator = mediator;
    }

	[HttpGet]
    public async Task<IActionResult> SomeAction()
    {
    	var query = new Query(this) { ... };
    	var model = await _mediator.SendAsync(query);
        return Ok(model);
    }
}

public class Query : IAsyncRequest<Model>
{
	public Query(Controller controller)
	{
		Controller = controller;
	}

	public Controller Controller { get; private set; }
	public int? Id { get; set; }
    // ...
}

public class Model
{
	public string Href { get; set; }
    // ...
}

public class Handler : IAsyncRequestHandler<Query, Model>
{
    private readonly SomeContext _db;

    public Handler(SomeContext db, ...)
    {
        _db = db;
    }

    public async Task<Model> Handle(Query message)
    {
    	var userFromHttpContext = message.Controller.User;
    	var cultureFromHttpContext = message.Controller.CurrentCulture;

    	var result = new Model
    	{
    		Href = message.Controller.Url.Action("Get", new {...})
    	};

        return result;
    }
}

To this:
public class SomeController : Controller
{
	private readonly IMediator _mediator;
    public SomeController(IMediator mediator)
    {
        _mediator = mediator;
    }

	[HttpGet]
    public async Task<IActionResult> SomeAction()
    {
    	var query = new Query { ... };
    	var model = await _mediator.SendAsync(query);
        return Ok(model);
    }
}

public class Query : IAsyncRequest<Model>
{
	public int? Id { get; set; }
    // ...
}

public class Handler : AsyncControllerRequestHandler<Query, Model>
{
    private readonly SomeDbContext _db;

    public Handler(SomeContext db, ...)
    {
        _db = db;
    }

    public async Task<Model> Handle(
    	IControllerContext context, // Injected
    	Query message)
    {
    	var userFromHttpContext = context.User;
    	var cultureFromHttpContext = context.CurrentCulture;
    	// ...
    	var result = new Model
    	{
    		Href = context.Url.Action("Get", new {...}),
    		// ...
    	};

        return result;
    }
}

public interface IControllerContext
{
	ClaimsPrincipal User { get; set; }
	CultureInfo CurrentCulture { get; set; }
	IUrlHelper Url { get; set; }
	// ... Caller controller instance stuff mapped
}

Or this:
public class Handler : AsyncControllerRequestHandler<Query, Model>
{
    private readonly SomeDbContext _db;

    public Handler(SomeContext db, ...)
    {
        _db = db;
    }

    public async Task<Model> Handle(Query message)
    {
    	var userFromHttpContext = this.Context.User;
    	var cultureFromHttpContext = this.Context.CurrentCulture;
    	// ...
    	var result = new Model
    	{
    		Href = this.Context.Url.Action("Get", new {...}),
    		// ...
    	};

        return result;
    }
}

There has to be no reason to ever pass the controller into a query... If you wanted to gain access to any object on the controller in you request then you are tightly coupling your requests to the aspnet core framework... The user stuff is usually done by passing around the user id in requests, then you feed that back to the mediatr request. Something like:
    [HttpGet("{userId}")]
    public async Task<IActionResult> SomeAction(string userId)
    {
        var query = new Query(userId);
    }

Then in your handler you would fetch the relevant information about your user that  you need in order to fulfil the request. CurrentCulture I'm pretty sure is set per thread, so you could equally get it from the thread info.

I understand your vision, in fact that's how we've been doing this o real dev.
What I want is to get a hydrated context where the coupling is an interface like "IControllerContext" or IQueryContext...
This context does not have to know anything about asp only be hydrated at the right time and have the required properties (in sample case properties existing in the controller context), and probably so testable.
With the premise that the props in this context are always required for this specific type of handler.

I think what you're looking for is the RequestContext? AFAIK that is injectable. It contains the rest of the context pieces you're looking for.
Otherwise, I'd look at modifying the message being sent in to the mediator before you Send it.

Exactly, RequestContext (in runtime) would be the the place to map and hydrate the ex: "IControllerContext".
Then make it available as a parameter in the Handler or a property in RequestHandler.
Somehow it would be possible?

Just inject it and set it as a property?


Vendor files missing

Looks like the latest dev release of phpVMS is missing the vendor folder! Is this meant to be like this, as I keep getting errors directing me to the missing vendor folder.

The dev branch from GitHub, or the tar file?
On Fri, Dec 6, 2019, 12:22 PM rebal154<EMAIL_ADDRESS>wrote:

Looks like the latest dev release of phpVMS is missing the vendor folder!
Is this meant to be like this, as I keep getting errors directing me to the
missing vendor folder.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/nabeelio/phpvms/issues/459?email_source=notifications&email_token=AAAYLGASNJJV3SVFAUUQWP3QXKJ6DA5CNFSM4JW6T7AKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H6XDSFA,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAYLGDR5KAWGGWKH4DMDGLQXKJ6DANCNFSM4JW6T7AA
.

Nope dont, worry its all good. Also, is it possible to change the logo in the top left of the site? At the moment its the phpVMS logo (and although its cool), Id like to change it to my VA's logo

The dev branch from GitHub, or the tar file?
…
On Fri, Dec 6, 2019, 12:22 PM rebal154 @.***> wrote: Looks like the latest dev release of phpVMS is missing the vendor folder! Is this meant to be like this, as I keep getting errors directing me to the missing vendor folder. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#459?email_source=notifications&email_token=AAAYLGASNJJV3SVFAUUQWP3QXKJ6DA5CNFSM4JW6T7AKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H6XDSFA>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAYLGDR5KAWGGWKH4DMDGLQXKJ6DANCNFSM4JW6T7AA .

Nope dont, worry its all good. Also, is it possible to change the logo in the top left of the site? At the moment its the phpVMS logo (and although its cool), Id like to change it to my VA's logo

http://docs.phpvms.net/customizing/theming

I'm going to close this since it's not a bug, let me know if you have any more issues.


Sign in needs to be hit twice to get sign in to the app

Open a Map and App gallery application.  (make sure you're not logged in to org and app is shared with everyone)
Hit sign in and enter credentials
Notice that 'Sign In' button still shows up as 'Sign In' and items aren't updated
Hit Sign in again and the items gets updated and 'Sign in' button is changed to 'Sign Out'
Noticed only in devext

@CTLocalGovTeam : This is a regression. Could you please include a fix for this as part of the SOW you are writing up for the theme work? We need to address this for 5.1.

@allisonmuise
As this is an issue with devext, can you please share the app url where we can debug the issue.

@CTLocalGovTeam URL send via email.

@CTLocalGovTeam : The AGOL/API teams are saying that this must be something on the app side. Please continue digging into this and send me any details.

verified


Provide a shortcut to close a commenting widget after adding a comment

Issue Type: Bug
When reviewing code I usually only add a single comment to a line. I'd like to have a keyboard shortcut that I can use to commit the comment and close the commenting widget at the same time.
Extension version: 1.14.0
VS Code version: Code - Insiders 1.31.0-insider (b4fc71b972eae2425d39ac4041df0c36cfa1bb37, 2019-01-15T06:12:40.322Z)
OS version: Darwin x64 18.0.0

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.
If you wonder what we are up to, please see our roadmap and issue reporting guidelines.
Thanks for your understanding, and happy coding!


feat: pass tags to related resources for kms and route53

This passes the tags from the KMS Key to the KMS Alias as well as the Route53 Zone to the Route53 Record Set.
Each are prefixed by key:tag: and zone:tag respectively.

Resolves #457
Resolves #297

:tada: This PR is included in version 3.38.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


can not achieve the performance which mentioned in the original paper

Hi, @AxelGiottonini, when I use the command CUDA_VISIBLE_DEVICES=0 python -m src.train -hyper_search  to run the code, I get the following results:
[2023-03-09 05:47:00.038149]  [FINAL TEST for dips] --> epoch -1/10000 || mean/median complex rmsd 16.2906 / 15.7649 || mean/median ligand rmsd 35.9814 / 33.6197 || mean/median sqrt pocket OT loss 28.6057 || intersection loss 21.3417 || mean/median receptor rmsd 0.0000 / 0.0000
[2023-03-09 09:37:52.987988]  [FINAL TEST for db5] --> epoch -1/10000 || mean/median complex rmsd 16.7756 / 16.5510 || mean/median ligand rmsd 40.3175 / 36.7189 || mean/median sqrt pocket OT loss 31.0876 || intersection loss 28.0045 || mean/median receptor rmsd 0.0000 / 0.0000
from the results, we can get the mean rmsd of dips test is 16.29, and the mean rmsd of db5 test is 16.77, but in paper, table 1 shows that the mean rmsd of dips test is 14.52, and the mean rmsd of db5 is 14.72, it has a lower performance than mentioned in the original paper

what is wrong?
and how to get the interface rmsd?

and when I run the command CUDA_VISIBLE_DEVICES=0 python -m src.inference_rigid, an error has appeared: File "/nvme/duhao/projects/docking-task/equidock_public/src/inference_rigid.py", line 203, in main
assert np.linalg.norm(new_residues - model_ligand_coors_deform_list[0].detach().cpu().numpy()) < 1e-1
AssertionError
so, how to deal with this error?

and when I note this line code, the code could run successfully, and I use python -m src.test_all_methods.eval_pdb_outputset to get the results, it shows: For  dips  method =  equidock ; num test files = 100  complex_rmsd_CA median/mean/std =  13.295709133148193 / 14.52530690637253  +-  7.132719173736529  complex_interface_rmsd CA median/mean/std =  10.186793327331543 / 11.92203870816779  +-  7.009077590008056, it seems that it also has a lower performance than the original paper.

Hey @onlyonewater !
For the first point, if you want to get your statistics, you need to run the src/inference_rigid.py and src/utils/eval.py script. As mentioned in other issues, I suspect the statistics to be biased for Equidock as considering the complex RMSD/iRMSD, the receptor RMSD is used but it is always equal to 0 by design of the model.
For the assertion error, I never faced it. Maybe trying to remove it could solve the problem but  I do not remember why the authors used it. So you may wan to figure out why they use this condition.
I don't really get your point on the last two questions, but I'd be happy to help you with them !
By the way, I am not related to any of the authors of the project nor their lab. I just worked with EquiDock for a master project.
Sincerely Meow !

hi, @AxelGiottonini , thanks for your replying, yeah, the user should run the src/inference_rigid.py and src/test_all_methods/eval_pdb_outputset.py to get the final results, when I meet the assertion error, I remove that line of code, and it runs successfully, my meaning is that I can not achieve the performance with running the code by myself in my GPU machine, the results of the dips are: For  dips  method =  equidock ; num test files = 100  complex_rmsd_CA median/mean/std =  14.964256286621094 / 15.607631420575272  +-  7.329030992174103  complex_interface_rmsd CA median/mean/std =  11.410481452941895 / 12.017205838562273  +-  5.641359052105475, it has lower results than the original paper. I am not sure that you are having this problem.

Hey ! If you trained EquiDock from scratch, then it is normal to obtain different results although their should be in the same magnitude order. As you are training a neural network with random initial parameters you would not expect the outputs to be equals between different models. So yes, I had similar results but I would not consider that as a problem :)
For the receptor RMSD, you will always obtain a value of 0 because the model is just looking for a SE(3) transformation of the ligand. Thus, the receptor does not move from its initial position, that's why you obtain an RMSD of 0. If you pay attention to the article, the behavior is described as "We design EQUIDOCK, a fast, end-to-end method for rigid body docking that directly predicts the SE(3) transformation to place one of the proteins (ligand) at the right location and orientation with respect to the second protein (receptor)."

hi, @AxelGiottonini, thanks for your detailed reply, yeah I got it, thanks, and I have no problem.

and this is my results:
for dips:

for db5.5:

so, the results are all lower than the original paper.


How to deny mobs with NBT?

I noticed in your changelog that you accept NBT, but not seeing any example how to do it.
I'd like to completely ban all baby zombies (both the running ones and the chicken jockeys) on Fabric 1.19.2.
Thanks

I think I didn't say anything about NBT because it is difficult to get NBT data before the process of spawning.
Anyway, to ban all baby zombies(just zombies, not affect other babies such as animals), I'll present new option.

Oh, I guess I misread the v16.1 "Serialization was improved to use Dynamic, which can accept both Json and NBT."
Thank you


[Feature][Core] Enable the SPI factory classes to improve the entire process.

Search before asking

[X] I had searched in the feature and found no similar feature requirement.

Description
Currently, the way we parse RowType is inconsistent.
These factories should be enabled to allow users to configure more easily and support more features;
Below I briefly explain the factory:

CatalogFactory: a feature with the same target as the user-defined schema, used to obtain the structured information of the table;
DeserializationFormatFactory & SerializationFormatFactory: used to support kafka, file and other unstructured connectors to process data in various formats;
TableSourceFactory: It is used to support multi-table reading and metadata column features. It is an upper-level extension of source;
TableSinkFactory: The same level as TableSourceFactory, but there are currently no supported features;

Usage Scenario

Provides a unified schema.
Support for metadata columns.
Support for CDC connector.
Support for format SPI.

Related requirement
unified schema：
#2469
metadata columns：
#2915
#2960
Are you willing to submit a PR?

[x] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@ashulin hi, is it possible to identify the source of meta data in the schema definition and treat it as a normal field,Load when it needs to be processed

@ashulin hi, is it possible to identify the source of meta data in the schema definition and treat it as a normal field,Load when it needs to be processed

@Carl-Zhou-CN That's how it's designed right now.

To support cdc, we also need to support RowKind(delete/update) based on primary key define in sink


Add Open Telemetry design patterns & recipes

Is your feature request related to a problem? Please describe.
CSE Playbook does not have content on design patterns & recipes related to Open Telemetry
Describe the solution you'd like
Based on our conversations, please review content in Open Telemetry page https://microsoft.github.io/code-with-engineering-playbook/observability/tools/OpenTelemetry/ and recommended design patterns.
Also add pointers to Recipes section in https://microsoft.github.io/code-with-engineering-playbook/observability/recipes-observability/

Hi @iamnicoj,
I am currently working on distributed tracing in IoT and digging deeply into OpenTelemetry. It would be nice to collaborate on this item.

Sure @eedorenko, I'll ping you next week to have a small talk about this. Thanks

Closing as part of #792.


jax-rs @BeanParam with constructor results in NPE

I have a parameter that is annotated with @BeanParam to a class that has a bunch of fields in it.  This class has only getters, not setters, and it has a constructor that takes all parameters.  Those constructor parameters are annotated with @QueryParam, @Size, @ApiParam etc. Jersey is able to handle this fine but Swagger throws an exception:
Exception in thread "main" java.lang.IllegalArgumentException: Unrecognized Type: [null]
    at com.fasterxml.jackson.databind.type.TypeFactory._fromAny(TypeFactory.java:1110)
    at com.fasterxml.jackson.databind.type.TypeFactory.constructType(TypeFactory.java:563)
    at io.swagger.jaxrs.ext.AbstractSwaggerExtension.constructType(AbstractSwaggerExtension.java:53)
    at io.swagger.jaxrs.ext.AbstractSwaggerExtension.shouldIgnoreType(AbstractSwaggerExtension.java:45)
    at io.swagger.jersey.SwaggerJersey2Jaxrs.extractParameters(SwaggerJersey2Jaxrs.java:40)
    at io.swagger.jersey.SwaggerJersey2Jaxrs.extractParameters(SwaggerJersey2Jaxrs.java:82)
    at io.swagger.jaxrs.Reader.getParameters(Reader.java:913)
    at io.swagger.jaxrs.Reader.parseMethod(Reader.java:864)
    at io.swagger.jaxrs.Reader.read(Reader.java:299)
    at io.swagger.jaxrs.Reader.read(Reader.java:145)
    at io.swagger.jaxrs.config.BeanConfig.scanAndRead(BeanConfig.java:223)
    at io.swagger.jaxrs.config.BeanConfig.setScan(BeanConfig.java:204)

I believe the bug is in io.swagger.jersey.SwaggerJersey2Jaxrs.extractParameters?
FWIW my code is in Kotlin but that shouldn't matter.  I viewed the decompiled class to verify what it looked like.

My work-around is of course to make the state be set via setters.  I'd rather not do that though, and the IAE from Swagger is arguably something that should be dealt with somehow.

Would be hard to debug without seeing the equivalent in Java. If you feel you can submit a PR to resolve the issue, please do so.

Why was this closed?

A PR with an example showing the issue would make it possible to solve


[Bug]: NFT metadata not fully parsed

Contact Details
Discord: eddex#6808
What happened?
Blockfrost dotnet version: 0.0.4
Problem
When I get the Onchain_metadata of an NFT, blockfrost dotnet only returns the Image and the Name. I would like to be able to get the rest of the metadata too.
Details
The endpoint I use is /assets/<addet_id>. This endpoint returns all metadata:
"mint_or_burn_count": 1,
  "onchain_metadata": {
    "name": "NFT name",
    "image": "ipfs://QmRMETbpqSXqWd2bim6EhZ89uLaJsB3SZGW3zNWqNarDd8",
    "custom_prop1": "xyz",
    "custom_prop2": "abc",
    "mediaType": "image/png"
  },

Since C# is a statically typed language, the current solution of having a Onchain_metadata class in the library is not optimal. This calss only contains Image and Name. The rest of the data can't be retrieved.
Solution proposal
Make an overload of the IAssetService.AssetsAsync() method that allows to pass a generic type to the method. This type should be used to parse the Onchain_metadata.
Version
v0.0.1-alpha (default)
In what OS are you experiencing the problem?
Windows, Linux, MacOS, Docker
What version of dotnet are you using?
5.0.x
Relevant log output
No response

Hi @eddex
thank you for raising this issue, its a very important one, and I will therefor not close it right away...
you are using the outdated IAssetService class.  Consider using IAssetsService (notice the pluralized class name)...
The new Service will return an AssetsResponse with JsonElement as type for OnchainMetadata.
so you can validate and convert this any way you want
IAssetsService service = serviceCollection.GetRequiredService<IAssetsService>();
var asset = await service.GetAssetsAsync("asset_id");
var json = asset.OnchainMetadata.GetRawText();
var model = JsonSerializer.Deserialize<YourModel>(json);

I really like the generic GetAssetsAsync<YourModel>(string asset) and will add it in the next release

Ah ok, didn't realize there were 2 interfaces for the assets, thanks for clarifying!

The UN-pluralized services will be removed in an upcoming release, i left them in as to not break existing implementations so that people have time to migrate.

Also, the fields below are not exposed in the response:
"onchain_metadata_standard": "CIP68v1",
"onchain_metadata_extra": "d87980",
Also, for OnChainMetadata return type, I personally prefer a dynamic, since I really only care about name and image properties, and those are consistently there.
I just ended up writing my own return class and calling the service using Flurl.


Keyboard type wrong on close account page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed

Go to settings > security > close account
click on default contact method

Expected Result:
should show email keyboard as it accept email or phone(we are using email keyboard on login page)
Actual Result:
shows default keyboard
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platform:

Where is this issue occurring?

iOS
Android
Mobile Web

Version Number: 1.2.37-1
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1670575030039319
View all open jobs on GitHub

Proposal
pass keyboardType={CONST.KEYBOARD_TYPE.EMAIL_ADDRESS} and import CONST from '../../../CONST';
https://github.com/Expensify/App/blob/168800a386e171882dd2e0a3d9ae57954df6fa5f/src/pages/settings/Security/CloseAccountPage.js#L102-L107

@gadhiyamanan - I think you need to wait until it's gone through the review process before we solicit proposals. Please wait until the appropriate time.

Hmm, I'm on v1.2.38-1 - to be clear, are we looking for something like this to pop up?

https://user-images.githubusercontent.com/42940078/207182604-900f97ae-0691-4f1e-a9bf-80c77ccc8de3.MP4

I think you need to wait until it's gone through the review process before we solicit proposals. Please wait until the appropriate time.

@sophiepintoraetz  According to CONTRIBUTING.md ,reporter may suggest a solution for the job.

@sophiepintoraetz no that is the autocomplete, the email keyboard has an @, which you can see in the same image next to the space.
So in your video this would be a replication of the issue.
I still think this is a Bug, not a huge one, but the correct keyboard for the correct field was alway something that told me the quality of the App. So I'm quite keen on fixing these

Sorry @gadhiyamanan there has been a shift with internal engineers picking this kind of issues to help things go faster, and so not posting a fix is mostly for your own benefit of not wasting time/energy on a solution that you will not be payed for.
You will still be payed for finding the bug though.
I think that you brought a good point that we need to discuss internally as well, of when a contributor finds a Bug if it's ok to propose a fix. I would say that the answer at this point is that probably best not to.
In this case it might seem obvious, but we might thingking of changing the way we close accounts, or something else that affects the bug. So it's mostly a risk to you...

PR is being reviewed

changed the C+ to you @aimane-chnaif

Job offers sent!


Add top-level versions of ElementaryFunctions operators for Tensor.

Add Tensor operators:

acos, asin, atan,  acosh, asinh, atanh,
log2, log10, exp2, exp10, pow(Tensor, Int), root(Tensor, Int)

Todos:

Add operator tests.
Mark all operators as @differentiable. Blocked by some bugs.
Add derivative tests.

Is this ready?

Is this ready?

Yes. Added elementary function tests in https://github.com/tensorflow/swift-apis/pull/214/commits/ddfe8c7036d0f79c442a7a2ee06114d8305556a0.

Tests look great!


update packages

:x: Build TheIdServer 7.4.6-fix-dependencies1-0066 failed (commit https://github.com/Aguafrommars/TheIdServer/commit/f58dc7957c by @invalid-email-address)

:x: Build TheIdServer 7.4.6-fix-dependencies.1+66.build.3339 failed (commit https://github.com/Aguafrommars/TheIdServer/commit/f58dc7957c by @invalid-email-address)

:white_check_mark: Build TheIdServer 7.4.6-fix-dependencies.1+66.build.3340 completed (commit https://github.com/Aguafrommars/TheIdServer/commit/f58dc7957c by @invalid-email-address)


Standardize file naming

File naming conventions in Jest can be improved. A good example is the integration_tests folder. We have:

Dashed names: auto-clear-mocks
Underscored names: clear_cache
Camel case names: testNamePattern
Dash + camel case names: timer-resetMocks
Underscore + camel case names: stack_trace_no_captureStackTrace
? names: regex-(char-in-path

I understand that some of the camel cased ones reference actual method names, like captureStackTrace, but I think we could do it better. This is absolutely not top-priority, but I just wanted to add a task to it because it feels there's room for improvement.

I want to use camelCase for functions, dashes for folders and Capitalized for classes. I'll send a tshirt to the person that makes this happen.

cc @aaronabramov

+1 to @cpojer's suggestion. I think it matches the "standard" at the industry.

For the reference: https://github.com/facebook/jest/issues/3771

I'll take a look on this

@mjesun Can I take up this issue

@ajomadlabs maybe you can sync with @slootzky? There are a lot of files, so you can maybe split; but I'd rather double-check before getting the work done twice 🙂

@ajomadlabs @mjesun sorry for not being responsive , well I actually did all the necessary changes (I believe) but then had to work on something else and didn't have the chance to start testing all.
I really hope to do it tomorrow and then I'll send the PR.
@ajomadlabs,  if I see I'm still not getting to this tomorrow, I will update here.

Hey @ajomadlabs @mjesun  ,
Sorry but I just can't get to completing this :(
Guess I will just need to find some time and get another issue fixed.

@slootzky so can I take up this

Thanks @ajomadlabs! Let me know if you need any help with something 🙂

Is this issue sufficiently spec'ed out? I'm unclear.
The above comment suggest to use camelCase and CapitalizeCase, but the linked issues suggest everything be underscore case...
So is the final recommendation:

All folders -> kabab-case
All files that export a single Class -> CapitalizeCase
All files that export a single function -> camelCase
All other files -> underscore_case
Folders surrounded by __ (eg. __tests__) -> Stay the same.

This might be something to document in the contributing guidelines under Code Conventions.

Yes; how should we name things has always been a complex topic in Jest. I'm sorry if we created more confusion linking the other task, but I think it was necessary to keep proper track of everything 🙂
I think @cpojer's comment regarding PascalCase and camelCase was specifically referred to syntax rather than to files; but let's double-check. Personally, I would name all folders and files with kebab-case (except special folders, like __tests__ or __mocks__), so we do not make a distinction between files that export a single thing, or multiple ones.
I 100% agree with your suggestion of adding this to the code conventions; since we're the first ones (at Facebook) to consistently break them. Let's fully clarify here before proceeding.

I would also love to help with this. Is https://github.com/facebook/jest/issues/4969#issuecomment-357408475 still relevant?

@neosiae yup

I'm working on this one. How many files should I change in one PR so it makes sense and we won't fall into endless conflicts and rebases?

Probably on a per-folder / per-package basis is good to go :) (sorry for the late reply!)

That's what I did in the referenced PR. I will try to keep working on standartize the file names.

Sounds awesome!

Hello!
I would love to help with this issue. Is it possible to provide a checklist to keep track whats already done?

@silltho I think you can start with standartize the sub folders under jest-cli.

Hello!
I'd love to help too!
I went over sub folders under jest-config (last referenced in this thread) and it seems there's still work to be done. Can I take the next in line?

Yeah, go for it!

Hey 👋 I'd like to help also - took a quick look and seems like jest/packages/jest-haste-map needs some cleanup, can I take it?

Absolutely, do it :)

I quickly went over the content of packages to get a feel whats left to be done, marked stuff that seems to be complaint with facebook standards already below.
As the renames are quite easy to do, maybe we could use hacktoberfest label to get more people to help with work?

[x]  Integration_tests/ folder-names #5298
[x]  Integration_tests/ file-names
[ ]  root file names
[ ]  packages/

[x] babel-jest
[x] babel-plugin-jest-hoist
[x] babel-preset-jest
[x] diff-sequences
[x] eslint-config-fb-strict
[ ] expect
[x] jest
[x] jest-changed-files
[ ] jest-circus
[x] jest-cli
[x] jest-config
[x] jest-diff
[x] jest-docblock
[x] jest-each
[x] jest-environment-jsdom
[x] jest-environment-node
[x] jest-get-type
[x] jest-haste-map
[ ] jest-jasmine2
[x] jest-leak-detector
[x] jest-matcher-utils
[x] jest-message-util
[x] jest-mock
[x] jest-phabricator
[x] jest-regex-util
[x] jest-repl
[ ] jest-resolve
[x] jest-resolve-dependencies
[ ] jest-runner
[ ] jest-runtime
[x] jest-serializer
[ ] jest-snapshot
[ ] jest-util
[ ] jest-validate
[ ] jest-watcher
[ ] jest-worker
[ ] pretty-format

[ ]  root folders and contents

Added! thanks for this @monkey3310.
To anyone interested in tackling any of the remaining packages: let us know in a comment under this thread and we'll assign you on the list provided above :)

@thymikee I would happy to knock off the remaining

Lovely! @Anenth @andrew-pyle I've just assigned 2 packages to each of you. Let's start small and then we'll followup with further work :)

@thymikee https://github.com/facebook/jest/pull/7290, Let me know if this is right direction,
I have doubts

isError.js. its imported as import checkIsError from './is-error.js should we change the variable name to isError?
setup_jest_globals I havnt changed this, as I think this is categorized under Other files

@betalantz done, thanks!
@Anenth

yup, change the variable to isError 👍
let's go with setupJestGlobals as it exports a single fn

@thymikee am picking up jest-util

I'm picking up jest-watcher

I will pick up jest-worker and pretty-format

@betalantz are you still interested in converting files assigned to you?

@andrearosr need any help with jest-watcher? :)

Yes, I'm available to work on this.  I'll follow the assignments above, unless they've been assigned elsewhere.

Hello! 🖐 First-time-contributor here. If there are any packages or folders remaining I can help take on a few.

@GGonryun feel free to take over jest-watcher :)
And maybe root filenames in other PR?

Hey there! I hadn't seen the other messages to this thread, I did jest-watcher in #7315 so I think the packages folder may be done

picked up jest-snapshot.  getting a PR ready.  jest-runner needs to be checked off, as well.  are there actually any root file/folders left to be renamed?

Hello, I also want to make my first contribution can I work on this issue?

Hi, first-timer here! If there's room for another I'd love the opportunity to work on this issue. Please let me know.
Thank you!


Bump tekton-pipeline to v0.17.1

Fix issue: https://github.com/shipwright-io/build/issues/429

Bump to tekton-pipeline v0.17.1

Bump go modules to point to v0.17.1 tekton-pipeline version;
Modify vendor directory and make it have all new dependencies;
Add some dependent packages to fix some Incompatible issues:

k8s.io/apimachinery => k8s.io/apimachinery v0.17.6

k8s.io/klog/v2
# k8s.io/klog/v2
vendor/k8s.io/klog/v2/klog.go:1241:34: cannot use logging.logr.V(int(level)) (type logr.InfoLogger) as type logr.Logger in field value:
        logr.InfoLogger does not implement logr.Logger (missing Error method)

v0.17.6 can solve above issue.

sigs.k8s.io/controller-runtime => sigs.k8s.io/controller-runtime v0.5.2

k8s.io/klog/v2
# k8s.io/klog/v2
vendor/k8s.io/klog/v2/klog.go:1241:34: cannot use logging.logr.V(int(level)) (type logr.InfoLogger) as type logr.Logger in field value:
        logr.InfoLogger does not implement logr.Logger (missing Error method)
sigs.k8s.io/controller-runtime/pkg/webhook/internal/certwatcher

v0.5.2 can get rid of this issue.

k8s.io/kube-openapi => k8s.io/kube-openapi v0.0.0-20200410145947-bcb3869e6f29

vendor/k8s.io/kube-openapi/pkg/util/proto/document.go:24:2: case-insensitive import collision: "github.com/googleapis/gnostic/openapiv2" and "github.com/googleapis/gnostic/OpenAPIv2"
make: *** [build/_output/bin/build-operator] Error 1

v0.0.0-20200410145947-bcb3869e6f29 can solve this issue.

github.com/go-logr/logr => github.com/go-logr/logr v0.1.0

github.com/go-logr/zapr
# github.com/go-logr/zapr
vendor/github.com/go-logr/zapr/zapr.go:133:34: undefined: logr.InfoLogger

v0.2.0 release doesn't have logr.InfoLogger

I will take a look today, I want this to get in asap.

/ok-to-test

@adambkaplan I took a look on this, Im not sure if this PR should be blocked. Please refer to this branch where I pinned the missing dependencies that this PR didnt.
Also, it seems Tekton is doing the same, look at their go modules in v0.17.1 vs master . Is there any specific reason on why this one should be blocked? if not I suggest that @xiujuan95 fixes the PR and then we put on top your upcoming #443

Hi @adambkaplan ,
Any update in your PR?
Will you bump the Tekton in your PR or can we continue this PR?

Hi @adambkaplan ,
This PR blocks our work recently. If your PR cannot finish soon.
I suggest we go ahead and accept this PR first. Please let us know if you have any comment or suggestion.
I plan to unblock this issue tomorrow if no other objection.
Thanks!

/ok-to-test

/ok-to-test

/unhould

/unhold

/lgtm


Signature check failed for latest build

Just downloaded the latest build. When the VM starts I get the following,

booting rktmachine (1/1)
---> downloading and verifying stable/1800.7.0
[ERROR] Signature check for DIGESTS failed.

Thanks for the report, John. We appreciate you helping us out.
The problem is similar to https://github.com/woofwoofinc/rktmachine/issues/43. CoreOS regenerate their signing keys annually and we’re still on the old key. (https://groups.google.com/d/msg/coreos-user/4rjt4ElkJS0/hCyL2DCRAwAJ)
The corresponding upstream commit in corectl we want is https://github.com/TheNewNormal/corectl/pull/126. And we also have to get https://github.com/moby/hyperkit/pull/200 to handle some new compiler warnings.
I’ll put out a 1.0.3 release to include this. Delete ~/.coreos and ~/.rktmachine if you still have problems with the new version.
Thanks again.

https://github.com/woofwoofinc/rktmachine/releases/tag/1.0.3 is uploaded now.

Thank you. I'm past the issues now, but the coreos image that runs when I start rktmachine 1.3 does not have buildah installed rather acbuild.This is the build info;
core@rktmachine ~ $ cat /etc/os-release
NAME="Container Linux by CoreOS"
ID=coreos
VERSION=1465.6.0
VERSION_ID=1465.6.0
BUILD_ID=2017-08-16-0012
PRETTY_NAME="Container Linux by CoreOS 1465.6.0 (Ladybug)"
ANSI_COLOR="38;5;75"
HOME_URL="https://coreos.com/"
BUG_REPORT_URL="https://issues.coreos.com"
COREOS_BOARD="amd64-usr"

Thanks, this fixed these issues. Working through the tutorial, the section where you fetch the ubuntu base image refers to a build that is no longer available. Its asks for version 17.10. I just changed to the latest 18.x build and is worked fine.
Do you know when rkt will support the OCI format for containers, so we can bypass the docker2aci steps?

I don’t follow rkt development closely. Last I heard was that the Red Hat acquisition of CoreOS would mean rkt becoming an independent community open source project, i.e. not supported directly by Red Hat. On the face of it, this would not seem promising for rkt development but tbh I really don’t know. I do not expect native OCI support in rkt any time soon. (Sorry if this is completely wrong, I am not an expert.)
https://www.zdnet.com/article/heres-what-happens-to-coreos-now-that-red-hat-owns-it/
Thanks for the note about the Ubuntu versions. I’ve updated the docs now.


[Q] Handling Boolean Features

How does DLRM handle boolean features or low-cardinality features?
Do we embed them to the same dimensionality as we embed all other sparse features? but won't that be redundant as we'll be embedding features with low cardinality ex. 5 into a much larger space say 16-dim?
I am assuming we need to embed all features to the same dimensionality to calculate the pairwise interactions. How should features with cardinality varying from 2 to 1M be handled?

All sparse features are handled in the same way and embedded into the same dimension by default.
This does not have to be the case, though. This and related questions are discussed in the following references:
A. Ginart, et al. Mixed Dimension Embeddings with Application to Memory-Efficient Recommendation Systems
M. Naumov, On the Dimensionality of Embeddings for Sparse Features and Data

Will it not be redundant to encode boolean features into higher dimensions? Do we do it just to be able to calculate the pairwise feature interactions?
Can we even calculate pairwise feature interactions (dot products) on Mixed dimension embeddings?

There could be multiple techniques and reasons for encoding boolean features. First, you can combine them and transform them into n-grams. Also, by encoding them you are giving them a certain meaning in the abstract embedding space and are later able to interact them.
Notice that you can always pass the mixed dimension features through an appropriately sized matrix multiplication and then interact the results using a dot product.

Thanks for the information @mnaumovfb. Closing the issue.


Remove useless line in README

Why is this useless? It's a parameter of the edit() mixin.

Indeed, it was not so clear that you list the parameters for each mixin that way.
Sorry for the time lost.

No problem. Thanks for the PR. Sorry if anything was unclear.


Updating a disabled package automatically re-enables that package

I'm not sure how to test this again locally, because I'm not sure how to install an older version of a package.
I had the vim-mode package installed but disabled. I manually clicked the "update package" button (not the "update all" button). After the package had been updated, it seemed that it re-enabled itself. I would have expected it to remain disabled.
Not a large issue but might catch some people out if they had a larger number of disabled packages.

What version of Atom are you using? You can install an old version of a package with apm install, e.g.:
apm install<EMAIL_ADDRESS>

$ atom --version
1.0.2

To reproduce:

Confirm vim-mode is disabled, quit atom
apm install<EMAIL_ADDRESS>Load atom and confirm vim-mode remains disabled.
Click "Update to 0.55.0"
Observe package is automatically re-enabled after update finishes

This also happens with minimap-git-diff, so i don't think its specific to vim mode.

Just saw this as well. Works with any package as far as I can tell.

This issue was moved to atom/settings-view#603


when call set() of an empty array, the first element of the new array will be remove

http://jsbin.com/jeyizufuva/edit?html,js,console

Thanks for reporting the problem, the code was checking if (index) instead of if (typeof index !== 'undefined')


Firebase Ml Vision - textRecognizer not recognizing text on ios.

The FirebaseVision.instance.textRecognizer() is not recognizing any text on iOS device. It works perfect on an android device.
To Reproduce
Use FirebaseVision.instance.textRecognizer() on an image to try and recognize text.
void _read() {
    progressDialog.show();
    _takePicture().then((String filePath) async {
        final FirebaseVisionImage visionImage =
            FirebaseVisionImage.fromFilePath(filePath);
        final TextRecognizer textRecognizer =
            FirebaseVision.instance.textRecognizer();
        textRecognizer.processImage(visionImage).then((visionText) {
          print(visionText.text);
          _processText(visionText.blocks);
          textRecognizer.close();
        }).catchError((error) {
          progressDialog.dismiss();
          PlatformErrorAlert(context: context, text: error).show();
        });
    }).catchError((error) {
      progressDialog.dismiss();
      PlatformErrorAlert(context: context, text: error).show();
    });
  }

The print(visionText.text); is empty when using an iOS device.
I expect it to return a VisionText with the recognized text like it does on an android device.
Flutter doctor output
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel master, v1.15.23-pre.28, on Mac OS X 10.14.6 18G103, locale en-GB)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
[✓] Xcode - develop for iOS and macOS (Xcode 11.3.1)
[!] Android Studio (version 3.6)
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
[✓] VS Code (version 1.43.0)
[✓] Connected device (1 available)

! Doctor found issues in 1 category.

Hi @chaser79
I see there's an open issue addressing the case you described.
Please follow up on that issue,
I'm closing the current one as duplicate.
If you disagree please write in the comments
and I will reopen it.
Thank you


Update Vert.x and vmp versions

Checklist:

[x] Read the Code of Conduct and Contributing Guidelines.

[ ] Followed the commit message guidelines.

[ ] Stack adheres to Appsody stack structure.

Modifying an existing stack:

[ ] Updated the stack version in stack.yaml

Contributing a new stack:

Describe how application dependencies are managed:

Explain how Appsody file watcher is utilized:

Describe other Appsody environment variables defined by the stack image:

Describe any limitations and known issues:

Related Issues:

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I'm also noticing the travis build isn't picking up the changes you've made and therefore falling back to building backup stacks rather than Vert.x with your changes on top. Will do some investigating...

The pom.xml using a version range from 0.1-0.2 and thus should incorporate the updated stack version.

@rdruss - How about the parent pom.xml in image/project/pom.xml?

@rdruss Please, can you review and sign our CLA.

:+1:

@neeraj-laad @rdruss is a Red Hat employee and created this contribution in the scope of his employment at Red Hat, making Red Hat the owner of all original intellectual property (copyrights and patent rights) inherent in this contribution. Having acquired Red Hat, IBM now owns this intellectual property through its ownership of Red Hat. Therefore, why should @rdruss (or Red Hat) have to sign an IBM CLA? It would in effect constitute IBM granting a meaningless license to itself. Do non-Red-Hat IBM employees who contribute to this project sign the CLA?
BTW our understanding is that IBM is moving away from use of CLAs for open source projects in favor of the DCO.

@richardfontana @rdruss I understand your point, but even IBMers are asked to sign the CLA; Appsody is an open source project and contributions from any individual are to be treated in the same way. The project is currently using the IBM CLA, but should this be donated to an open foundation we would look to change that.

@richardfontana @rdruss I understand your point, but even IBMers are asked to sign the CLA; Appsody is an open source project and contributions from any individual are to be treated in the same way. The project is currently using the IBM CLA, but should this be donated to an open foundation we would look to change that.

@sympatheticmoose Okay, that is interesting and helpful to know. I will just take a quick closer look at the CLA and then follow up with @rdruss

@richardfontana @rdruss - Any updates on this? I think this would be a nice QoL change to go in.

Closing this for now as the CLA hasn't been signed.

@Kamran64 I have now notified @rdruss that he can sign this CLA and have also whitelisted it for Red Hat employees generally on our internal list of upstream contributor agreements.


fix: add parentId to blocklist

This pull request fixes a bug already checked in commit eecaf861863dbbd492449e4a894244026ae3b483 but it was only applied to checkbox

thanks for this @andersonrosilva .  I'll release a new version with it.


Add missing managed AMI codes

what

Add some missing images codes from https://docs.aws.amazon.com/eks/latest/APIReference/API_Nodegroup.html

Please fill out the full PR template


ODB is looking for PHP driver dev.

Hey Chris and Dylan @chrismichaels84  @PommeVerte
ODB is looking for a PHP dev to be in charge of the PHP driver. I thought maybe either of you might be interested.
https://groups.google.com/forum/#!topic/orient-database/gYGKXp7tMlg
Scott

I'll close the issue as soon as I know both of you have seen this.
Scott

Cheers. I'll have a look.

Hmm no client facing email. Not sure how to private email him

Yeah, I'll take a look, too. Thanks!

Great. I've also asked for Luca's email address in that thread, as that is where you need to send a resume.
Scott