Revert "Add slider minimum interaction time (#15358)"

This is purely a test revert to rule out the associated patch as the
source of the flutter_gallery_ios__transition_perf632 frames
missed_frame_rasterizer_budget_count benchmark.
I do not expect that this is the source of the regression; it seems far
more likely that this was a fluke regression on this commit and that the
true source of the regression is #15494.
This reverts commit d28e9aa5c94a85ae729650ad12147834d191ec9a.

Dropping this revert as I'm able to rule it out with local testing.


Folder sharing is case sensitive on Windows 7/Docker Toolbox?

Description
Folder sharing is case sensitive?
This command creates a folder t123 containing test file on the host:
$ docker run -it -v /c/Users/testing123/t123:/t123 alpine sh -c "touch /t123/test"

This command does not:
$ docker run -it -v /c/users/testing123/t123:/t123 alpine sh -c "touch /t123/test"

Both commands create t123/test in the container and /c/users/testing123/t123/test in the default VM.
I found this problem while trying to figure out why a docker-compose.yml file that worked fine on Windows 10/Docker for Windows 1.12.3 was behaving differently on Windows 7/Docker Toolbox 1.12.3:
version: '2'
services:
  one:
    [...]
    volumes:
      - ./t123:/t123

On Windows 10/Docker for Windows, this results in ./t123 (c:/users/testing123/t123) being created on the host, and files being shared between host and guest. On Windows 7/Docker Toolbox, ./t123 is not created on the host.
If I change the volume mount in docker-compose.yml to be /c/users/testing123/t123:/t123 the result is the same. However, if I change it to be /c/Users/testing123/t123:/t123 then it works.
Steps to reproduce the issue:

Install Windows 7 Professional x64 using VMware Workstation 12 Player with user testing123 and apply all 'important' updates (just mentioning all that because it's exactly what I just happened to do...)
Install DockerToolbox-1.12.3 accepting all defaults
Open docker quickstart terminal and run the following commands...

testing123@WIN-ON3GMQSBBNH MINGW64 /c/users/testing123
$ ls t123
ls: cannot access 't123': No such file or directory

testing123@WIN-ON3GMQSBBNH MINGW64 /c/users/testing123
$ docker run -it -v /c/users/testing123/t123:/t123 alpine sh -c "touch /t123/test"

testing123@WIN-ON3GMQSBBNH MINGW64 /c/users/testing123
$ ls t123
ls: cannot access 't123': No such file or directory

testing123@WIN-ON3GMQSBBNH MINGW64 /c/users/testing123
$ docker run -it -v /c/Users/testing123/t123:/t123 alpine sh -c "touch /t123/test"

testing123@WIN-ON3GMQSBBNH MINGW64 /c/users/testing123
$ ls t123
test

Describe the results you received:
As shown in the session above, I find that mounting /c/Users as a volume works, while /c/users does not.
Describe the results you expected:
I expected either /c/Users or /c/users/ to work, because Windows is case insensitive.
Additional information you deem important (e.g. issue happens only occasionally):
I assume this issue arises from VirtualBox. The problem I have is that if I distribute Docker-based software to people, and those people use Windows/Docker Toolbox, I'm going to have a hard time explaining about figuring out which case their /c/users/username path is stored in on the file system, because Windows itself is case insensitive so this will all be foreign to them...
Output of docker version:
$ docker version
Client:
 Version:      1.12.3
 API version:  1.24
 Go version:   go1.6.3
 Git commit:   6b644ec
 Built:        Wed Oct 26 23:26:11 2016
 OS/Arch:      windows/amd64

Server:
 Version:      1.12.3
 API version:  1.24
 Go version:   go1.6.3
 Git commit:   6b644ec
 Built:        Wed Oct 26 23:26:11 2016
 OS/Arch:      linux/amd64

Output of docker info:
$ docker info
Containers: 10
 Running: 0
 Paused: 0
 Stopped: 10
Images: 4
Server Version: 1.12.3
Storage Driver: aufs
 Root Dir: /mnt/sda1/var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 51
 Dirperm1 Supported: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: null host bridge overlay
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Security Options: seccomp
Kernel Version: 4.4.27-boot2docker
Operating System: Boot2Docker 1.12.3 (TCL 7.2); HEAD : 7fc7575 - Thu Oct 27 17:23:17 UTC 2016
OSType: linux
Architecture: x86_64
CPUs: 1
Total Memory: 995.8 MiB
Name: default
ID: EKPO:5LQC:OIUK:LNPW:MKTD:OYND:L4NO:TUYZ:M3E2:NVTV:CWOY:2L4W
Docker Root Dir: /mnt/sda1/var/lib/docker
Debug Mode (client): false
Debug Mode (server): true
 File Descriptors: 13
 Goroutines: 24
 System Time: 2016-11-21T14:17:52.553906094Z
 EventsListeners: 0
Username: XXX
Registry: https://index.docker.io/v1/
Labels:
 provider=virtualbox
Insecure Registries:
 <IP_ADDRESS>/8

Additional environment details (AWS, VirtualBox, physical, etc.):
Debian 8/VMware Workstation 12 Player running guest Windows 7 Professional x64.
VirtualBox version 5.1.8 r111374. Shared "users" folder for the default VM was set up automatically by Docker Toolbox's installer, with Name=c/Users, Path=\\?\c:\Users, Auto-mount=Yes, Access=Full.

This is not really an issue that we can fix here, I think you want to file a toolbox issue or a virtualbox issue at a guess, but yes, case insensitive filesystems are a world of pain...

This is not really an issue that we can fix here, I think you want to file a toolbox issue

Oops, sorry, I failed to spot there's a separate tracker for toolbox. I'll submit this issue there.

but yes, case insensitive filesystems are a world of pain...

Ha, the file system (NTFS) is case sensitive, but the operating system (Windows) is mostly case insensitive...at least as far as I can tell (or care - I'm not really a Windows user). My problem is that just about all the users of my software are on Windows (a large part of the reason I'm using docker in the first place...).


Image not cleared when polygon entity is removed from dataSource

Reported in the forum: https://groups.google.com/forum/?hl=en#!topic/cesium-dev/JgzuftedXi0
When more than one polygon with an image material is added with a non-zero height, removing one of the polygons from the entity collection does not clear the image from the screen.
Here's a Sandcastle example:
http://cesiumjs.org/Cesium/Apps/Sandcastle/index.html?src=Hello World.html&label=Showcases&gist=a0cfb82ab43474f87afdcdaba339e76d
To reproduce the issue:

Click "Add first entity"
Click "Add second entity"
Click "Remove second entity"

Expected: Removes the second entity along with the image.
Actual: Doesn't clear the image.

Note to whomever fixes this (though I'll probably do it when I have more time).  This looks like a race condition involved with StaticGeometryPerMaterialBatch.update vs StaticGeometryPerMaterialBatch.remove caused by changing an entity property immediately after removing it (but before the remove has been processed by the visualizers).  Because the item has changed, it's still getting put in a batch even though it has also been removed.

Reported on the forum here: https://groups.google.com/forum/#!searchin/cesium-dev/mittner|sort:relevance/cesium-dev/PgFyVrT3_jM/aCqAV30rDgAJ

Hi, I recently ran into the same issue as Dave from the above Google Group and as he says, resetting the length variable after the first loop solves the second loop's array out of bounds issue.  I'm new to working with Cesium so I'm not entirely sure how Dave's issue is encapsulated by the race condition outlined here, but it seems that if there's a chance that the array will be modified (the slice in the first loop) the length variable should be reset regardless.
StaticGeometryPerMaterialBatch.prototype.update = function(time) {
    var i;
    var items = this._items;
    var length = items.length;                           <= #1 initial length recorded
    for (i = length - 1; i >= 0; i--) {
        var item = items[i];
        if (item.invalidated) {
            items.splice(i, 1);                          <= #2 actual length may changes
            var updaters = item.updaters.values;
            var updatersLength = updaters.length;
            for (var h = 0; h < updatersLength; h++) {
                this.add(time, updaters[h]);
            }
            item.destroy();
        }
    }
    length = items.length;                               <=#5 potential solution, works for my case
    var isUpdated = true;
    for (i = 0; i < length; i++) {                       <= #3 initial length still assumed
        isUpdated = items[i].update(time) && isUpdated;  <= #4 potential error
    }
    return isUpdated;
 };

Fixed this somewhere along the way when I refactored geometry entities.  This will be included in the 1.42 release on March 1st

Congratulations on closing the issue! I found these Cesium forum links in the comments above:
https://groups.google.com/forum/?hl=en#!topic/cesium-dev/JgzuftedXi0
https://groups.google.com/forum/#!searchin/cesium-dev/mittner|sort
If this issue affects any of these threads, please post a comment like the following:

The issue at https://github.com/AnalyticalGraphicsInc/cesium/issues/5379 has just been closed and may resolve your issue. Look for the change in the next stable release of Cesium or get it now in the master branch on GitHub https://github.com/AnalyticalGraphicsInc/cesium.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.
:earth_africa: :earth_americas: :earth_asia:


split long words

Add an option to split long words once they surpass a user specified length at any hyphen or underscore. This can help with languages that like to join words with a hyphen, e.g. this pseudo-translation of a German sentence:
"Some main-categories of the mathematics-test have sub-examples that most 14-year olds can't answer, therefor the implementation-instruction made in the 1990-years needs to be revised".
This would also help with pseudo-hashtags which aren't valid twitter hashtags (no hyphen allowed), e.g. #something-else.
I suggest to default long_word_split  at ~10 characters.

I added this option: https://github.com/diasks2/pragmatic_tokenizer/blob/master/lib/pragmatic_tokenizer/tokenizer.rb#L80
NB: The default is set to not split at long words as I think that would be unexpected behavior. The user needs to explicitly set this option.


Update HidD_SetFeature kernel-mode mapping

HidD_SetFeature should in my mind map to IOCTL_HID_SET_FEATURE instead of IOCTL_HID_SET_OUTPUT_REPORT in kernel-mode. This is furthermore the IOCTL used in the https://github.com/microsoft/Windows-driver-samples/blob/main/hid/firefly/driver/vfeature.c sample for sending a HID feature-report to an IntelliMouse device.

Hi @forderud,
Good call! Thanks for your update and for helping us make the docs more accurate.
Take care,
~ Mark

Thanks for a stellar quick approval @mhopkins-msft . This makes submitting PRs a pleasure 👍


I want to use Preview in Shopware Page Builder So I can see the final page styled with Shopware-PWA

Context
In Shopware there is a Page Builder, that all the customers will use to create CMS pages. Right now we are not 100% sure if Page Builder will show all the components styled with StorefrontUI. It is possble that customers will build the CMS Pages without seeing the final result with StorefrontUI styles.
We want to generate the pages to let Shopware add button "Show Headless Preview" in Page Builder, which will link the user to generated page.

@elkmod I'm assigning you as you already on this :)


Version 1.5 and up no longer work in Wine

With lessmsi 1.4:
$ wine lessmsi.exe x pkg.msi
fixme:mscoree:CLRMetaHost_GetRuntime Unrecognized version L"v4.0"
fixme:mscoree:CLRMetaHost_GetRuntime Unrecognized version L"v4.5"
Extracting 'Z:\...\pkg.msi' to 'Z:\...\pkg'.
fixme:ver:GetCurrentPackageId (0x32f6d8 (nil)): stub

(success)
With lessmsi 1.5, 1.5.1, 1.6:
$ wine lessmsi.exe x pkg.msi
fixme:mscoree:CLRMetaHost_GetRuntime Unrecognized version L"v4.0"
fixme:mscoree:CLRMetaHost_GetRuntime Unrecognized version L"v4.5"
Extracting 'Z:\...\pkg.msi' to 'Z:\...\pkg'.
fixme:advapi:EventRegister {5eec90ab-c022-44b2-a5dd-fd716a222a15}, 0x1c01123, 0x1c2a070, 0x1c2a088
fopen error:13

Error: System.Exception: Failed to open cabinet. Last error:MSPACK_ERR_OPEN
  at LibMSPackN.MSCabinet..ctor (System.String cabinetFilename) [0x00000] in <filename unknown>:0
  at LessMsi.Msi.Wixtracts.MergeCabs (IList`1 cabInfos) [0x00000] in <filename unknown>:0
  at LessMsi.Msi.Wixtracts.ExtractFiles (Path msi, System.String outputDir, LessMsi.Msi.MsiFile[] filesToExtract, System.AsyncCallback progressCallback) [0x00000] in <filename unknown>:0
  at LessMsi.Msi.Wixtracts.ExtractFiles (Path msi, System.String outputDir, System.String[] fileNamesToExtract) [0x00000] in <filename unknown>:0
  at LessMsi.Cli.Program.DoExtraction (System.String msiFileName, System.String outDirName, System.Collections.Generic.List`1 filesToExtract) [0x00000] in <filename unknown>:0
  at LessMsi.Cli.ExtractCommand.Run (System.Collections.Generic.List`1 allArgs) [0x00000] in <filename unknown>:0
  at LessMsi.Cli.Program.Main (System.String[] args) [0x00000] in <filename unknown>:0

Usage:
lessmsi <command> [options] <msi_name> [<path_to_extract\>] [file_names]

Commands:
  x  Extracts all or specified files from the specified msi_name.
  l  Lists the contents of the specified msi table as CSV to stdout. Table is
     specified with -t switch. Example: lessmsi l -t Component c:\foo.msi
  v  Lists the value of the ProductVersion Property in the msi
     (typically this is the version of the MSI).
  o  Opens the specified msi_name in the GUI.
  h  Shows this help page.

For more information see http://lessmsi.activescott.com

fixme:advapi:EventUnregister deadbeef: stub
fixme:advapi:EventUnregister 0: stub

(failure)
I've tried several different MSI packages, they all show the same behavior. I'm using wine 1.6.2.

I'm guessing this is due to this line which was added in this commit. Apparently some problem loading LessIO on Wine. LessIO uses a several Win32 native methods so I suspect that is at play here. Someone needs to debug though.
@jethrogb Is this something you're up for investigating further?
@jgstew Is this something you might be able to take a look at?

“aspires to be platform independent” :smiley:
I'm happy to provide help debugging and testing, but I don't have a Windows/.Net toolchain setup.

...
Wouldn't this be best reported on wine bugzilla?

@mirh I think since it worked in older versions of lessmsi it is likely we've introduced something that wine supports. I don't use it on wine, so I haven't taken the time to investigate yet. If you have, please let me know what's going on and I'll be happy to support you resolving it (either in lessmsi or reporting to wine).

I am not sure if/when I'll have time to investigate this, but lessmsi is actively being used on OS X in a project I helped with a bit, but haven't spent time with recently.

https://github.com/autopkg/hansen-m-recipes/blob/master/SharedProcessors/MSIVersionProvider.py

Finding which functions we are talking about in the first place, then check for bug reports on wine appdb, wouldn't hurt.

I’m on v1.6.1 and getting the same error.
Despite the error, it works! :3

So... I am still affected by this. I don't know the actual problem yet, however it seems to fail to close the handle to the cab correctly after writing:
009f: create_file( access=c0100000, sharing=00000000, create=5, options=00000060, attrs=00000080, objattr={rootdir=0000,attributes=00000040,sd={},name=L""}, filename="/root/.wine/dosdevices/z:/root/testfiles/ext2/foobar.cab" )
009f: create_file() = 0 { handle=00dc }
009f: get_handle_fd( handle=00dc )
009f: *fd* 00dc -> 129
009f: get_handle_fd() = 0 { type=1, cacheable=1, access=0012019f, options=00000060 }
009f: close_handle( handle=0000 )
009f: close_handle() = INVALID_HANDLE
009f: close_handle( handle=0000 )
009f: close_handle() = INVALID_HANDLE

Which then results in a sharing violation as it should:
009f: create_file( access=80100000, sharing=00000003, create=1, options=00000060, attrs=00000080, objattr={rootdir=0000,attributes=00000042,sd={},name=L""}, filename="/root/.wine/dosdevices/z:/root/testfiles/ext2/foobar.cab" )
009f: create_file() = SHARING_VIOLATION { handle=0000 }

wine --version reports wine-3.10.
I don't know who's at fault here beacuse as far as I can tell the cab gets written correctly. We'll see.

In case anyone wants to investigate this (😉) I'd start by look at the ExtractFiles method in Wixtracts. This calls into two areas that are worth investigating:

LessIO is my library for doing all the File I/O for everything but the cab files themselves (since as it turns out the System.IO .NET File I/O library was full of critical limitations/bugs).
My libmspack4n project which does the dirty work of dealing with cabs in C. That is also possibly an issue, but less likely as IIRC doesn't use WINE at all and instead uses the standard c lib for all i/o.

FWIW, I think the problem is this call https://github.com/activescott/lessmsi/blob/master/src/LessMsi.Core/Msi/Wixtracts.cs#L386 resulting in this handle being allocated https://github.com/activescott/libmspack4n/blob/master/libmspack4n/MSCabinet.cs#L44 but not properly closed. I have no further Idea what is going on as I most probably can't contribute code back for legal reasons and therefore have not bothered to set up a debug environment, sorry about that. I think that this is a bug in wine, but I'm seriously lacking the capabilities to bisect. If anyone with wine hacking expierience besides me is interested in bisecting, feel free to do so :)

Latest version works just fine in wine, at least once you install dotnet45.
If there is a problem, this is inside mono.


Add prime symbol

prime <=> and . (not . ∃mul{(!= 1), (!= 1)}, (!= 1))

Maybe this is a bad idea without types.


Remove all instances of READTHEDOCS

We should make this theme like any other Sphinx theme when running on RTD. This means removing all the {% if READTHEDOCS %} blocks. There are only a couple left, but we should remove them all.
After we do this and have the theme fully abstracted, I think we should release it as a 1.0. I feel silly having it under 1.0, and want to move to real semvar on our projects going forward.

I'm fine sticking <1.0 until semver dictates a major version release. We definitely should have started at 1.0 for semver proper, but I don't think that this is a requirement to doing semver successfully. The most important part is that we are communicating backwards compat through versioning, which we are currently. Bumping to 1.0 would be sort of antithetical to these efforts actually.

1.0 generally means "we'll follow semvar" though -- "Version 1.0.0 defines the public API". So if we're <1.0, it's saying that we can still change whatever we want.

Agreed we should have started with 1.0, but we are still following semver. We don't get to change whatever we want without the version reflecting that. I think <1.0 is more truthful for now, and consistency is more important for package maintenance than correctness is in this case.

@agjohnson was there a reason to remove the 1.0 milestone? I think this would be a nice inclusion in the 1.0 release.

Mostly because we keep piling things into a 1.0 release and pushing out actually releasing 1.0. This doesn't feel immediately required.

Also, we're already dropping 1.6 and have some other large changes in our upcoming release. There is a lot of wisdom in cutting more frequent releases, and not making monolithic releases with a lot of important changes combined. This has always felt like the primary thing slowing this project down. 1.1 or great seems like a safe place for this new feature, this doesn't seem important as a 1.0 release feature.

Pushing this for 2.0 while waiting for more feedback on the PR itself.


tag OpenSSL_1_1_1w-quic1 missing

Hi,
I found that tag OpenSSL_1_1_1w-quic1 was missing. Most probably it should be the latest commit on OpenSSL_1_1_1w+quic branch, i.e. 612d8e44d687e4b71c4724319d7aa27a733bcbca.
Could you please make a tag for 1.1.1v based quic if it is ready ?
Thanks in advance.
Kazuhiko

This has already been done.


This is a test

Operating System
Mac OS
Terminal shell
ZSH
Node version
18
Git version
2.37.1
Command
one tasks -c tacos
What did you expect to happen?
I wanted to eat tacos
What actually happened?
I didn't get to eat tacos :(
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Issue template forms are neat.


Add monitor_window_timeout error to the error doc

Adds monitor_window_timeout error to the error doc and adds a link to the error message

Codecov Report

Merging #3783 (47b33c7) into dev (338c40a) will not change coverage.
The diff coverage is n/a.

Flag
Coverage Δ

*Carryforward flag

msal-angular
94.66% <ø> (ø)

Carriedforward from 338c40a

msal-browser
84.64% <ø> (ø)

Carriedforward from 338c40a

msal-common
83.41% <ø> (ø)

Carriedforward from 338c40a

msal-core
73.02% <ø> (ø)

Carriedforward from 338c40a

msal-node
78.35% <ø> (ø)

Carriedforward from 338c40a

msal-react
93.77% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files
Coverage Δ

lib/msal-browser/src/error/BrowserAuthError.ts
88.00% <ø> (ø)


update-meta-files.sh failed

Type of Report
Bug
Actual behaviour
update-meta-file.sh -t and update-meta-file.sh -m failed as following:
cinux@cinux-t420 ~/wtd/workspace/ansible-galaxy-skeleton (master) $ ./update-meta-files.sh -m
Downloading Meta Files
----------------------
Downloading https://raw.githubusercontent.com/while-true-do/ansible-galaxy-skeleton/master/
./update-meta-files.sh: Zeile 72: /home/cinux/wtd/workspace/ansible-galaxy-skeleton/https://raw.githubusercontent.com/while-true-do/ansible-galaxy-skeleton/master/: Datei oder Verzeichnis nicht gefunden
cinux@cinux-t420 ~/wtd/workspace/ansible-galaxy-skeleton (master) $ ./update-meta-files.sh -t
Downloading Test Files
----------------------
Downloading https://raw.githubusercontent.com/while-true-do/ansible-galaxy-skeleton/master/tests/
./update-meta-files.sh: Zeile 62: /home/cinux/wtd/workspace/ansible-galaxy-skeleton/tests/https://raw.githubusercontent.com/while-true-do/ansible-galaxy-skeleton/master/tests/: Datei oder Verzeichnis nicht gefunden

I'm not sure if its only by me or in gerneral, but on an centos7 machine its also.
As for now i have not find any solution. The script itself looks fine, expect the ongoing changes in pullrequest #5
Expected behaviour
To Download the needed files.
Specifications
Bash Version 4.4.12 / 4.2.46
OS: Manjaro, centos7

the update script in the master does not work, yet. After #5 this should work.
Since this is pulling from the skeleton itself, we have to recheck after #5 was merged.

found the issue will be fixed in #5

checked with #5 and its will fix the issue. Dont know how i can overlooked it.
Thanks :)


Remove panics from Server interface

Problem
The Server API currently races with the server actor shutting down, exposing possible panics.
Solution
I don't see a way for the server actor to shut down (a possible oversight of the design), however it's better to be safe than sorry. The public API now returns non-panicking results.
This is a follow-up to #55, which updates Server::accept().
Future work

The client and session APIs should also be non-panicking.

@UkoeHB could I reach out to you on some instant messaging platform?
You can contact me on telegram @gbaranski or<EMAIL_ADDRESS>


Cannot install latest development build

I have a question
I'm trying to install the development build via: npm install botframework-webchat@main but I get the following error:
npm error code E404
npm error 404 Not Found - GET https://registry.npmjs.org/botframework-webchat-styles - Not found
npm error 404
npm error 404<EMAIL_ADDRESS>is not in this registry.
npm error 404
npm error 404 Note that you can also install from a
npm error 404 tarball, folder, http url, or git url.

npm error A complete log of this run can be found in: /Users/<username>/.npm/_logs/2024-10-01T08_43_55_609Z-debug-0.log

Any suggestions?

The fix is in #5176 @compulim FYI


Let the driver determine the appropriate payload storage format

I'm frustrated that when I use the excellent Fluent Driver for Queues, the payload/JobData enforces storage as raw Data. This ends up meaning that for Postgres and MySQL, it's a column containing [UInt8], which is far from ideal.
I assume that this was done for the early drivers, which require storage this way, but it would be good to unpick this.
Offering the payload as Codable and expecting the driver to handle persistence would be a more flexible approach, and perhaps allow the use of things like Postgres' jsonb type for far easier inspection and debugging of in-flight jobs.

@tonyarnold thanks for the suggestion! On mobile so apologies for the quick response/possibly inaccurate information, but if I remember correctly we had to store the data inside of JobData as [UInt8] instead of Codable because we ran into problems with Codable not being allowed to be used as an existential, and some other problem when trying to use it as a generic. Sorry for the vagueness, when I'm back at a computer I'll see if I can dig in and remember exactly why we made that choice.

Surely that's the concern of the driver though, right — shouldn't Queues itself only be saying "here's what I need you to persist"?

@tonyarnold agreed, but I believe the only way we were able to coerce the type system into doing that was dropping down to bytes. Will have to carve out some time this week to take a look, in the meantime @gwynne I believe you helped me and @tanner0101 when we were writing that part of it, let me know if you recall any of this


feat: add elastic search to eval

Description
added Elastic Search for evaluation.

To test this model we first need to build it right before calling the evaluation code right?

To test this model we first need to build it right before calling the evaluation code right?

The elastic search one? No, the index will be built on the fly (in the collect_asnwer method).
But you need to have an elastic search server running (on localhost:9200)..

To test this model we first need to build it right before calling the evaluation code right?

The elastic search one? No, the index will be built on the fly (in the collect_asnwer method).
But you need to have an elastic search server running (on localhost:9200)..

Ok can you please add doc about how to do this in the README?

To test this model we first need to build it right before calling the evaluation code right?

The elastic search one? No, the index will be built on the fly (in the collect_asnwer method).
But you need to have an elastic search server running (on localhost:9200)..

Ok can you please add doc about how to do this in the README?

sure - just done.


Can't use IS_MODULE in script (or flex scanner push-back overflow)

What reproduces the bug?
I've trying to fuzz using libfuzzer and found an interesting case.
% sudo ./src/bpftrace -e "BEGIN { IS_MODULE }"
flex scanner push-back overflow

Only IS_MODULE has this problem.  After some investigation, apparently, the following part is related.
https://github.com/iovisor/bpftrace/blob/330953c11190c23a12f98d374d1b5eb6d7aad1fe/src/lexer.l#L182-L199
and in this case, yytext is IS_MODULE and s is (option)__is_defined(option##_MODULE).  I'm not sure why the macro is defined nor how to fix this.
bpftrace --info
System
  OS: Linux 5.9.0+ #24 SMP Tue Nov 10 16:05:24 JST 2020
  Arch: x86_64

Build
  version: v0.11.0-240-g3309
  LLVM: 11.0.1
  foreach_sym: yes
  unsafe uprobe: no
  bfd: yes
  bpf_attach_kfunc: yes
  bcc_usdt_addsem: no
  bcc bpf_attach_uprobe refcount: no
  libbpf: yes
  libbpf btf dump: yes
  libbpf btf dump type decl: yes

Kernel helpers
  probe_read: yes
  probe_read_str: yes
  probe_read_user: yes
  probe_read_user_str: yes
  probe_read_kernel: yes
  probe_read_kernel_str: yes
  get_current_cgroup_id: yes
  send_signal: yes
  override_return: yes
  get_boot_ns: yes
  dpath: no

Kernel features
  Instruction limit: 1000000
  Loop support: yes
  btf (depends on Build:libbpf): yes
  map batch (depends on Build:libbpf): yes
  uprobe refcount (depends on Build:bcc bpf_attach_uprobe refcount): no

Map types
  hash: yes
  percpu hash: yes
  array: yes
  percpu array: yes
  stack_trace: yes
  perf_event_array: yes

Probe types
  kprobe: yes
  tracepoint: yes
  perf_event: yes
  kfunc: yes

As the comment says, macros with operators go into infinite loops. I'm not sure why the macro is defined (maybe from system headers?), but if the macro has an operator, shouldn't we error it? since bpftrace does not support an macro operation if I understand correctly.


[closed with #4432] CartService.addEntry doesn't support consecutive calls

Environment Details

Spartacus: alpha-0.8

Other details shouldn't be relevant
Steps to Reproduce
Trying to implement a small component to add a list of products to the cart, we used a simple "forEach" product cartService.addEntry(productCode, quantity).
Observed Results
The products are not added when there is more than one product in the list.
Expected Results
All the products are added to the cart
Repository Used
Offer to Fix
Not savy enough
Additional Information
Looking at the cartService, it seems strange to have the internal callback function redefined every time.
Maybe the addEntry could return an observable, so the caller knows when to continue?
Ideally, implement a method addEntries, where you can provide a list of these tuples. Problem is OCC itself doesn't support this at the moment.

When adding the first product into cart, we need to check whether user's cart exist or not. If there is no cart, then the first thing is to create a new cart. After cart created, the product can be added.
For a list of products, you have to wait the first product is really added (if there is no cart), before adding others. So, you can call getActive() which returns Observable<Cart>. Subscribe it, and if it has value, then that means the cart exist. So, the other products can be added.

Thanks for the reply. But isn't this a bad abstraction from the client's point of view? Why does the client have to check if the cart exists or not, if it's going to be created for him? Wouldn't it make sense to return Observable also for the addEntry call?

+1 for adding an observable to the addEntry method, this way we can know when the entry has been added in order to add more products
Or just add support for adding multiple products at once, e.g. addEntries()

API of the function did not change.
Calls are now queued in effects and cart loading/creation happens only once if the cart does not exist.
QA steps:

try to add multiple entries to the cart at the same time
verify that cart have everything you added

QA Check:

Throttled Network
Navigated to product list page
Clicked Add to Cart on multiple items
No requests cancelled in network log and no added items lost in checkout


More derivation options

Based on the discussions in #72 and #76, derive_mapper_from_collection and derive_mapper_from_single_object  can now be overriden independently and derive_mapper_from_object will call either of these two depending on the object type.
The mapper_for options is still WIP though.

It's great that you're working on this. @plexus had a couple of suggestions what the derive_mapper_from_single_object method would be named, and I and one other person agreed that dervie_mapper_from_item is the best. What do you think about this?

My first thoughts was that item could be mistaken for an "item inside a collection". But I admit that item indeed sound better and is shorter. If you all agreed about it, I don't mind changing it to item :wink:

I agree item is a good name.

When working on mapper_for, I stumbled on a few issues:

Should we use the namespace option?

# @options[:namespace] == Mappers
class Thing; end
mapper_for Thing, ThingMapper
derive_mapper_from_object(Thing.new) # => ThingMapper or Mappers::ThingMapper?

When using symbol, should do we consider the class name and module or just the class name?

mapper_for :thing, ThingMapper
derive_mapper_from_object(Thing.new) # => ThingMapper
derive_mapper_from_object(Stuffs::Thing.new) # => ThingMapper or continue look up?

When a mapping is defined for a class, should we derive this mapper from only instances of this class or also instances of subclass?

class Widget < Thing; end
derive_mapper_from_object(Thing.new) # => ThingMapper
derive_mapper_from_object(Widget.new) # => ThingMapper or continue look up?

What do you guys think about it?

What I had in mind was to simply leverage Ruby's "case equality", ===. When used on a class that gives you "instance of", when used on a symbol or string it's simple equality, when used on a lambda it invokes the lambda

Should we use the namespace option?

no

When using symbol, should we consider the class name and module or just the class name?

Neither. Symbols would just be for "fixed" responses where you want to invoke a certain mapper without specific data to serialize
A common use case is having a "home page" which only contains links as a starting point to traverse the API
mapper_for :home, HomeMapper
derive_mapper_from_object(:home) #=> HomeMapper

When a mapping is defined for a class, should we derive this mapper from only instances of this class or also instances of subclass?

=== also matches subclasses, so that's your answer :)
class Foo
end

class Bar < Foo
end

Foo === Bar.new # => true

Nice, thanks! I did not know that === invokes a lambda. And I did not thought about symbols this way!
Everything makes sense now! :smile:

PR ready to be reviewed! :smile:

Made some nice refactoring!

@groyoh I left some nitpicks, but really good job overall :+1:

I made the changes according to your comments.
@plexus I removed the errors classes. Whenever you decide whether we should keep custom errors classes or not, let me know.


feat: taxi demo

Purpose
This PR introduces a new taxi demo example showcasing RAI's adaptability to new platforms and use cases.
Story:
It's 2026
You've just hailed an autonomous taxi.
You get in and tell the taxi where you would like to go.

You don't need to know the address, you can describe where you would like to go or ask for suggestions (e.g. best restaurant in Warsaw)

Proposed Changes

Adds a new taxi demo example

Issues

Links to relevant issues

Testing

[!IMPORTANT]
This demo expects Tavily api key as well as google maps api key. You can contact me for these

Silent testing
Terminal 1
python examples/taxi-demo.py

Terminal 2
ros2 topic echo /to_human std_msgs/msg/String

Terminal 3
ros2 topic pub /from_human std_msgs/msg/String "data: 'The tallest building in the warsaw please'" --once --qos-durability transient_local --qos-reliability reliable

Alternatively
Terminal 1
python examples/taxi-demo.py

Terminal 2
ros2 launch rai_bringup voice.launch.py keep_speaker_busy:=false recording_device:=3 silence_grace_period:=0.5 asr_vendor:=whisper

Looking through this PR, it is mostly not about a particular use-cases, but some refactoring. Could we make it a 2 separate PRs where one is only the demo?

Errors:

Please install it with pip install googlemaps.
I got such error:

(rai-py3.12) robo-pc-005 ➜  12_rai git:(feat/taxi-demo) ✗ python examples/taxi-demo.py
[WARN] [1727767323.981294829] [taxi_demo_node]: Robot description package not set, using empty identity and constitution.
[ERROR] [1727767323.981615142] [taxi_demo_node]: Could not load FAISS index from robot description package. Error:
'' is not a valid package name

I tried:

ros2 topic pub /from_human std_msgs/msg/String "data: 'The tallest building in the warsaw please'" --once --qos-durability transient_local --qos-reliability reliable
ros2 topic pub /from_human std_msgs/msg/String "data: 'Nice park close to the city center'" --once --qos-durability transient_local --qos-reliability reliable
ros2 topic pub /from_human std_msgs/msg/String "data: 'A park close to the WUT'" --once --qos-durability transient_local --qos-reliability reliable
 ros2 topic pub /from_human std_msgs/msg/String "data: 'A park with a ski lift in warsaw'" --once --qos-durability transient_local --qos-reliability reliable
ros2 topic pub /from_human std_msgs/msg/String "data: 'A big green area close to warsaw university of technology'" --once --qos-durability transient_local --qos-reliability reliable
ros2 topic pub /from_human std_msgs/msg/String "data: 'A big green area close to warsaw university of technology with field word in the name'" --once --qos-durability transient_local --qos-reliability reliable
ros2 topic pub /from_human std_msgs/msg/String "data: 'pole mokotowskie'" --once --qos-durability transient_local --qos-reliability reliable
ros2 topic pub /from_human std_msgs/msg/String "data: 'The headquarters of robotec.ai'" --once --qos-durability transient_local --qos-reliability reliable

Besides failing to get the park close to WUT as Pole Mokotowskie it worked very well!

@boczekbartek thank you for testing.
I've added the googlemaps to the poetry environment.
I wasn't planning on doing anything with the faiss error. It's caused by the lack of whoami configuration package for the taxi demo.
I see two solutions:

Lower the severance of this error
Create a whoami package for the taxi demo -> this will add a new command that will have to be run for the demo to work


[DO NOT MERGE] Add alert for planned test in Reading

https://www.pivotaltracker.com/story/show/178622042
This is just the initial content / screenshots. I expect we'll
make some changes before this gets merged.
Initial screenshots

Alert page
Plans page

We should merge this before the demo, and re-run the deploy pipeline within the start/sent window. This avoids any delay due to Concourse detecting the PR has been merged.


SWC could not parse () => <Component<any>></Component> while tsc could

Describe the bug
tsc: https://www.typescriptlang.org/play?target=99&ts=5.0.4#code/BQSgBAvAfGA8DCB7AtgB0QOwKYYC6wEMMBPKKWAeiTUx1yiA
Input code
() => <Component<any>></Component>

Config
No response
Playground link
https://play.swc.rs/?version=1.3.59&code=H4sIAAAAAAAAA9PQVLC1U7Bxzs8tyM9LzSuxScyrtLOz0YcL2HEBABELyhojAAAA&config=H4sIAAAAAAAAA02OvQ6DMAyEd54i8tyhytChbxOlpgoiEPmM1Ajx7nWgPyyW7zv7dGvnHA2IdHerrSZKELD8tBHUScPLCGktjCipKF2%2BrqJZKgvvZDsM0iBP1vbE8FfvPw%2BU05T6eo6Pcy7CgLE%2BjDjF7IPy%2FFhG%2FhdsJY7cG7WjbnsDOkAxqsUAAAA%3D
Expected behavior
"use strict";
() => React.createElement(Component, null);

Actual behavior

  x Unexpected token `Component`. Expected jsx identifier
   ,-[input.tsx:1:1]
 1 | () => <Component<any>></Component>
   :        ^^^^^^^^^
   `----

Caused by:
    0: failed to process js file
    1: Syntax Error

Version
1.3.59
Additional context
This should be a regression, we don't hit the problem in the previous version.

I tried<EMAIL_ADDRESS>and I might be running into a similar issue. This started happening after I upgraded next.js from 13.4.1 -> 13.4.4:
./features/bookings/form/bookable-fields.tsx
Error:
  x Unexpected token `ConnectForm`. Expected jsx identifier
    ,-[/workspace/features/bookings/form/file.tsx:28:1]
 30 | }) => (
 31 |   <ConnectForm<BookableFieldsType>>
    :    ^^^^^^^^^^^
    `----

Caused by:
    Syntax Error

@ifightcrime Please file an issue


ChartLine Color Issue

Hi - Anyone know why is get different colors on the number bullets? Check image here:

Always provide reproducible code please.

No details provided


Fixing OMIMPS xrefs in mondo

@joeflack4 caught this in his analysis.  Thank you! :)

Thanks @matentzn and @joeflack4


conj-vp when dobj precedes second verb

Queen Elizabeth II married Philip Mountbatten, Duke of Edinburgh, in 1947, became queen on February 6, 1952, and was crowned on June 2, 1953.
In this sentence, enhancement should say there is a VP conjunction between married and became rather than verb conjunction.
Reported by @oscartackstrom

Fixed https://github.com/sivareddyg/UDepLambda/commit/c1edbab84d6959bf934d159dfcdbcccad3af1e7c
John ate an apple and suffered.
Before fix:
"eat.arg1(1:e , 0:m.John)","eat.arg2(1:e , 3:m.apple)","suffer.arg1(5:e , 0:m.John)", suffer.arg2(5:e , 3:m.apple)

After fix:
"eat.arg1(1:e , 0:m.John)","eat.arg2(1:e , 3:m.apple)","suffer.arg1(5:e , 0:m.John)"


Use --build

Merge / deployment checklist

[x] Confirm this change is backwards compatible with existing workflows.
[x] Confirm the readme has been updated if necessary.

Before
$ time npm run build

><EMAIL_ADDRESS>build
> tsc

real    0m7.986s
user    0m11.848s
sys     0m0.684s

After
$ time npm run build

><EMAIL_ADDRESS>build
> tsc --build

real    0m0.557s
user    0m0.427s
sys     0m0.131s

The change results in ~1,300% faster builds.
Closes #486

Thanks for sticking with this change!


Only find 2FAs not already deleted

I believe here we need to make sure we only take into account 2FAs that are not already deleted. Otherwise we will show things that are already deleted as not deleted in root actions for example.

@SudharakaP Not clear what we're trying to solve. The fact that it appears in the collective picker may be more of an issue with the picker itself? Or maybe something we allow only in the context of root actions?

I think the issue that was seen is fixed by https://github.com/opencollective/opencollective-api/pull/9605. Anyways, I'll keep an eye out and report this again if I see this issue.


Implement "check-latest" flag to check if pre-cached version is latest one

Issue: https://github.com/actions/setup-node/issues/160
Action logic before these changes:
1) Try to find version locally
2) If manifest is available:
    1. Try to download version from manifest
3) Try to download version from dist

Action logic after these changes:
1) Try to find version locally if `check-latest` is false
2) If manifest is available
  1. Determine latest version based on manifest
  2. Try to find latest version locally
  3. Try to download latest version from manifest
3) Determine latest version based on dist
4) Try to find latest version locally
5) Try to download latest version from dist

Additional changes:

Move archive extract logic to the separate function to improve readability
Move installation logic (check cache, if it is not found, download) to the separate function to improve stability
Add check-latest parameter
Add tests
Significantly extend test matrix in versions.yml

I think some updates to the README regarding the new input would be good. Not everyone looks at action.yml to get the list of all available inputs.
An example with check-latest set to true would be good alongside an explanation of why users would want to us this

Some updates to the README regarding the new input would be good. Not everyone looks at action.yml to get the list of all available inputs.
An example with check-latest set to true would be good alongside an explanation of why users would want to us this (what specific use cases does this solve or fix). Here you can also mention the default behavior.

@konradpabjan , Updated readme. Please let me know if we can find better words to explain flag purpose

I added a few notes.  Outside of that, I'm good with the change.


No 'version' key in the manifest file for custom integration 'goodwe'

HA shows in log files:
No 'version' key in the manifest file for custom integration 'goodwe'. This will not be allowed in a future version of Home Assistant. Please report this to the maintainer of 'goodwe

This is fix since https://github.com/mletenay/home-assistant-goodwe-inverter/commit/9ca63eeff62503a4f6bf0d5b3a2a3fbe76c0397e #


Amount input is broken for locales where comma is the decimal separator

iOS app with a regional setting where comma is the separator (ex: Portugal) will not allow input.
Changing the regional settings to US for ex will use dot as separator and work as expected.

(Need to verify what is the problem)

@vladyslav-iosdev this one's too fragile and has been broken before, let's see if we can also come up with an automated test for this?

@hboon there is not clear what is wrong, maybe i been looking in wrong way. I switched to 'Portugal' locale, typed value with comma decimal separator and it accested it. Maybe u can help me with steps to reproduce it?

Checking with the bug reporter.

I can't reproduce it in the simulator too.

Probably fixed with #2607


dynamic publicPath option during runtime install

this is a prototype for dynamic publicPath.
I got it working for my use case, but it may not work together with other options.
and for FYI, my usage of OfflinePlugin looks like
new OfflinePlugin({
    ServiceWorker: {
        output: '../sw.js',
        scope: '/',
        events: true,
        entry: path.resolve('./.../.../entry.js'), // my entry file
    },
    autoUpdate: false,
    responseStrategy: 'cache-first',
    version: '',
    caches: 'all',
})

add feature #184

holy crap, accidentally saw this, https://stackoverflow.com/questions/38835273/when-does-code-in-a-service-worker-outside-of-an-event-handler-run
I think my implementation is wrong, going to revise on it

this version works for me, but the configuration around publicPath seems really complicated to me, I cannot really add my option to other possible configs

need some help on that

@Bobgy
Thanks for your contribution. I do not have the capacity (time and knowhow) to provide any meaningful feedback regarding your implementation, but I can tell you put some time into this PR, so wanted to tell you that your effort is appreciated, thanks!
@NekR could we give some feedback to let @Bobgy know if this is a feature we are even interested in, to let him know if it's worth pursuing further?

Looks like maintainer doesn't have capacity to review this.


Bad performance when training with new data.

Dear developers,
I annotated my images and tried training on them last Tuesday (6th July) and I managed to obtain pretty good results. However when repeating the same process on 9th July (exactly the same code as on the 6th) I got completely different results - either some bounding boxes that does not make sense at all or just no predictions whatsoever. I supposed the issue was mine and checked both the code, the images and the environment and everything seems to be ok. So my question is - did you change the structure of the training of your baseline model (the use_release one) or could you give me some suggestions how to fix the issue. I am running the project on Colab.
Thanks in advance!
Kristiyan

hello. please see the large message on the front of this repo. It has been moved to the main deepforest repo and exists on for older uses. It is difficult to know without seeing any code, but we can confident the release model didn't change. The release model is tied to github releases in this repo, which is why its called the 'release model'. There has been no change in several months. If you have further issues, please open an issue : https://github.com/Weecology/DeepForest

This is how my code, data and result look like the image that I predict after training is the same one that I have annotated beforehand so I want to compare the baseline prediction to the prediction after training.
Can you give me some clue what might be wrong?
Thanks in advance!


Make it possible to log in to accounts with commercial dictionaries

Ok, so I have a few dictionaries that I pay for. They're small and done for minority languages, so I pay for them where I wouldn't for a more widespread language. I can't log in to the sites and use them.
Would it be possible to add this ability? Perhaps it's possible to create a system for logging into 3rd party sites? Would it need some sort of cooperation with the dictionary's website designers?

Hm, this one might be tough!  Are they regular "username/password" sites?  If you configure the dictionaries as pop-up (ref manual) does it still require you to log in every time, or does it set a cookie?

They're just regular username/password sites which keep cookies. I can't even log into them with Lute.


Fetch In Progress order details?

I just tried it to fetch my orders and it only seems to return completed orders. Is it possible to return new incoming orders, or in progress orders? Thanks!

Is this api still working? I thought they added cloudflare protection

Updating this endpoint will fix that. We can even accept query params to filter different types of order in api to change endpoint based on it.
ref: https://github.com/salmannotkhan/fiverr-api/blob/fea49eed2a01fbc46c63548f61874e0a61d5db37/src/main.py#L229


Remove steal conditions

There's a few places where we're tight coupling FuncUnit to StealJS:
var fullPath = FuncUnit.getAbsolutePath(path);

This breaks in applications that are using new Steal as there is no longer steal.isReady(amongst other API changes).

getAbsolutePath doesn't use Steal.  Steal is only used in determining when the page is loaded, but conditionally so it still works without.

@matthewp @alexisabril Is there still an issue, here?  If not, can we close this issue?

Yeah, fine to close.


Document node['delivery']['project_cookbooks'] and node['delivery']['project_apps']

+1 @jonsmorrow I completely agree, this has to be documented.
The only partial documentation is available here:
https://docs.chef.io/delivery_truck.html#configure-project-application


Add testing instructions for Ruby on Rails

Testing approach taken from phlex-rails/19c5f41.
Happy to make any changes, just let me know.

Thank you!


API Docs return a 404 for some packages

The "API Documentation" link is broken on some packages for me.
Here's a few that return a 404:

https://pub.dev/documentation/google_fonts/latest/
https://pub.dev/documentation/http/latest/
https://pub.dev/documentation/mobx/latest/

Meanwhile, others are being served normally:

https://pub.dev/documentation/redux/latest/
https://pub.dev/documentation/url_launcher/latest/

cc: @jonasfj

Thanks, duplicate of https://github.com/dart-lang/pub-dev/issues/3669.
We are investigating.


Set state off after condition

Hi,
I'm trying to desactivate the LED status using this method (which may not be the right one).
#include <PololuLedStrip.h>
PololuLedStrip<13> ledStrip; // Create an ledStrip object and specify the pin it will use.
const int buttonPin = 32; // the number of the pushbutton pin
int buttonState = 0;  // variable for reading the pushbutton status
// Create a buffer for holding the colors (3 bytes per color).
#define LED_COUNT 120 // numbers of leds
rgb_color colors[LED_COUNT];

void setup()
{
  Serial.begin(115200);
  ledStrip.interruptFriendly = false;
}

void loop()
{
  buttonState = digitalRead(buttonPin); // read the state of the pushbutton value:
  // check if the pushbutton is pressed. If it is, the buttonState is HIGH:
  if (buttonState == HIGH)
  {
    Serial.println("appui Button");
    // Update the colors.
    byte time = millis() >> 2;
    for (uint16_t i = 0; i < LED_COUNT; i++)
    {
      byte x = time - 8*i;
      colors[i] = rgb_color(x, 255 - x, x);
    }
    ledStrip.write(colors, LED_COUNT); // Write the colors to the LED strip.
  }
  else if (buttonState == LOW)
  {
    Serial.println("Pas dappui Button");
    for (uint16_t i = 0; i < LED_COUNT; i++)
    {
      colors[i] = rgb_color(0, 0, 0);
    }
    ledStrip.write(colors, LED_COUNT); // Write the colors to the LED strip.
  }
  delay(10);
}

it creates a lot of random flashing when the code is in this state. is there any other way to give the off state?
When I disconnect the data cable from the arduino, they stop flashing. My power supply is clean.
Best regards,
Emile

I use arduino mega 2560 r3 (atmega2560). I tried on pin 32 it's worse, pin 12 same.. When I touch or move my hands closer to the system, it accentuates the disturbance. I tried to disable pin after realease button by setting it to inputt..
installing a 10k resistor at the end of the strip won't change anything.
/* LedStripGradient: Example Arduino sketch that shows
 * how to control an Addressable RGB LED Strip from Pololu.
 *
 * To use this, you will need to plug an Addressable RGB LED
 * strip from Pololu into pin 12.  After uploading the sketch,
 * you should see a pattern on the LED strip that fades from
 * green to pink and also moves along the strip.
 */

#include <PololuLedStrip.h>

PololuLedStrip<12> ledStrip; // Create an ledStrip object and specify the pin it will use. Tried multitude of pin..
const int buttonPin = 32; // the number of the pushbutton pin

int buttonState = 0;  // variable for reading the pushbutton status

// Create a buffer for holding the colors (3 bytes per color).
#define LED_COUNT 120 // numbers of leds
rgb_color colors[LED_COUNT];

void setup()
{
  Serial.begin(115200);
  ledStrip.interruptFriendly = false;

}

void loop()
{

  buttonState = digitalRead(buttonPin); // read the state of the pushbutton value:

  // check if the pushbutton is pressed. If it is, the buttonState is HIGH:
  if (buttonState == HIGH)
  {

  Serial.println("push Button");
  //pinMode(12, INPUT); // Change nothing
  // Update the colors.
  //byte time = millis() >> 2;
  for (uint16_t i = 0; i < LED_COUNT; i++)
  {
    //byte x = time - 8*i;
    colors[i] = rgb_color(100, 20, 45); //(x, 255 - x, x);
  }
  ledStrip.write(colors, LED_COUNT); // Write the colors to the LED strip.
  } else if (buttonState == LOW)
    {

    Serial.println("release Button");
    //pinMode(12, INPUT); // Change nothing
    for (uint16_t i = 0; i < LED_COUNT; i++)
    {
    colors[i] = rgb_color(0, 0, 0);
    }
    ledStrip.write(colors, LED_COUNT); // Write the colors to the LED strip.

    }
  //return;  // Change nothing
  delay(10);
}

I solved the problem by executing the functions only after a state change and not continuously when the state is low or high.
`
#include <PololuLedStrip.h>

PololuLedStrip<12> ledStrip; // Create an ledStrip object and specify the pin it will use.
const int buttonPin = 32; // the number of the pushbutton pin

int buttonState = 0;  // variable for reading the pushbutton status
int preState = LOW;

// Create a buffer for holding the colors (3 bytes per color).
#define LED_COUNT 120 // numbers of leds
rgb_color colors[LED_COUNT];

void setup()
{
  Serial.begin(115200);
  ledStrip.interruptFriendly = false;

}

void loop()
{

  buttonState = digitalRead(buttonPin); // read the state of the pushbutton value:

  // check if the pushbutton is pressed.
  if (buttonState == HIGH && preState == LOW)
  {

  Serial.println("push Button");

  for (uint16_t i = 0; i < LED_COUNT; i++)
  {
    //byte x = time - 8*i;
    colors[i] = rgb_color(100, 20, 45); //(x, 255 - x, x);
  }
  ledStrip.write(colors, LED_COUNT); // Write the colors to the LED strip.
  } else if (buttonState == LOW && preState == HIGH)
    {

    Serial.println("release Button");

    for (uint16_t i = 0; i < LED_COUNT; i++)
    {
    colors[i] = rgb_color(0, 0, 0);
    }
    ledStrip.write(colors, LED_COUNT); // Write the colors to the LED strip.

    }
  preState = buttonState;

  delay(10);
}

I'm glad you were able to figure it out, but I suspect there is still some issue with your hardware.  Using shorter wires, or adding a resistor on the signal input could potentially help.

Hello, they actually look more stable. Thanks for your comments. :)


Allow overlap post-processor to keep features in the same layer.

This is signaled by setting new_layer_name to None. Also added a more flexible way to build the dictionary of properties on the new feature.
Finally, added a feature to buffer geometries - although it turns out this isn't useful for water polygons it might be useful for other layers in the future.
@rmarianski could you review, please?

Refs mapzen/vector-datasource#140.

I put in a couple of minor comments. This looks good to me. :+1:


Apollo Router does not work with self-signed certificates

Hi, I'm using a self-hosted version of Hive and the problem I have encountered is that Apollo Router does not work with self-signed certificates.
In particular, there are two problems:
I'm using your custom Apollo Router ghcr.io/kamilkisiela/graphql-hive/apollo-router:latest which is a small wrapping layer around the original Apollo Router

The error from the original Apollo Router when it fetches data from subgraphs that are on our internal HTTPS domain with self-signed certificate. This error can be eliminated by specifying a tls section in router.yaml.tls:
  subgraph:
    all:
      certificate_authorities: "${file./dist/ca.crt}"

In this wrapping layer a reqwest client when connects to CDN at our custom domain with a self-signed certificate fails with errorERROR: error sending request for url (https://graphql-registry-api.stg.evo/artifacts/v1/4362db6f-bfe8-4f41-8a22-a23578307656/supergraph): error trying to connect: invalid peer certificate contents: invalid peer certificate: UnknownIssuer

As far as I know, there is no way to either pass a custom root certificate pass to https://github.com/kamilkisiela/graphql-hive/blob/main/packages/libraries/router/src/registry.rs#L130 or disable tls verification at all (like in apollo rover cli https://github.com/apollographql/rover/blob/c5d79f7a813cb460088d2ef414394bc4fe20eac4/src/utils/client.rs#L63)
Thanks

I've build a router from this repo but with native-tls feature instead of rustls-tls and now it uses my self-signed certificate which I've added to trusted ca, so there is a third option - just change tls implementation

That is fantastic. Thank you for a quick fix.


When could we see a new version of System Center Operations Manager Management Pack

Hi, we are using SCOM 2016 to monitor Azure Services (I think we are alone on this..) and actually there are not any APM management pack to get data from Azure App Insights . I just quote "Important
This System Center Operations Manager Management Pack is now deprecated. It does not support the latest Application Insights SDKs and is no longer recommended."
Are there any thought to publish a new MP ?
Regards.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1f1bf139-8e0f-c508-a0c9-4f0d0de41fbb
Version Independent ID: a94cf8c4-6d30-6d20-2c8d-32623a30aa00
Content: SCOM integration with Application Insights
Content Source: articles/application-insights/app-insights-scom.md
Service: application-insights
GitHub Login: @mrbullwinkle
Microsoft Alias: mbullwin

@Tulkis Thanks for the feedback. We are actively investigating and will get back to you soon.

@Tulkis The management pack was released as a preview mp, and unfortunately never made it to general availability due to low adoption. There are no plans at this time to create a new SCOM management pack for Application Insights.
While there is not a new management pack you could certainly still monitor an application both with SCOM 2016 and Application Insights either via adding the appropriate App Insights SDK if you have code level access to the app, or via Application Insights Status Monitor if you want to be able to monitor at runtime without having to make code level changes to your monitored .NET app much in the same way you were doing with the Application Insights preview management pack.

@Tulkis We are going to close this thread as resolved but if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.


Add Optional Permissions

It's possible to make permissions optional. Right now the permissions all_urls and tabHide are very far reaching and only needed for taking site screenshots, so it would make sense to have them be optional and if the user want's that capability they can grant the plugin access.
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/optional_permissions
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/permissions/contains

This is being blocked by #15


Finalize the key stories text

Finalized text sent to Marty for #202 in a power point file (for placement). Also available below. I think this could be added the repo as a text/yaml file in whatever directory the figure code ends up in the repo via #200.

Aquaculture, mining, self-supplied domestic, and livestock water uses are distributed unevenly across the US. There are large withdrawals for aquaculture along the Snake River in southern Idaho.
Industrial withdrawals are driven by many factors. Industrial facilities for production of steel in Lake County, Indiana, are located on Lake Michigan, a large source of fresh water, with access to water and land transportation, and ore and coal deposits. Lake County accounts for 8% of the US industrial water withdrawals.
Thermoelectric power plants use steam to drive turbines and generate electricity. In the eastern U.S. where water is relatively abundant, large volumes of water often are withdrawn, used once for cooling, then returned to the source a little warmer than before. In the western U.S., cooling water is more often withdrawn and recirculated many times, so less is withdrawn overall.
The Gulf Coast is another hotspot of industrial withdrawals for the chemical and petroleum industries.
Larger withdrawals in Alaska in the “other” categories are for aquaculture and mining.
Irrigation occurs in most areas of the country, but is larger in areas where rainfall is insufficient to meet crop what needs, such as in the drier parts of the West. Irrigation in eastern Arkansas provides water to flood rice fields as well as supplement rainfall to other crops.
Public Supply water withdrawals, mostly for Domestic use, are highest in counties with large numbers of people.

This text was iterated on with NWULT. Finalized.


chore: bdd-nh-1587459336 to 0.0.1

chore: Promote bdd-nh-1587459336 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Issue 39: add clear method

This looks well done, thank you! :)
I left a tiny comment in the test case.
Before this can be merged, it’d be great if you could squash your commits into a single commit with a message like: feat(clear): added clear() method or something like that.
Thanks again! :)

@jan: the commits are like we do this with our other plugins / modules... it's the convention ;)

getting an error:
pouchdb-hoodie-api zoepage$ node tests
module.js:338
    throw err;
    ^
Error: Cannot find module 'pouchdb/extras/promise'
    at Function.Module._resolveFilename (module.js:336:15)
    at Function.Module._load (module.js:278:25)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/Users/zoepage/Projekte/hood.ie/pouchdb-hoodie-api/tests/utils/wait-for.js:3:15)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)

in pouchdb-hoodie-api/tests/utils/wait-for.js:3:15 we define the path to var Promise = require('pouchdb/extras/promise'), but there seems something to be missing.

w00p, congrats to first Hoodie pull request! :tada: welcome to the family :)
Your test is not good yet though, I'll comment on the changes in a bit, but here's what you want:
test('removes existing db', function (t) {
  t.plan(2)

  var db = dbFactory()
  var store = db.hoodieApi()

  var localObj1 = {
    _id: 'cleanTest',
    cnt: 'cleanTest dummy doc'
  }
  store.on('clear', function () {
    t.pass("store 'clear' event was triggered")
  })

  store.add(localObj1)

  .then(function () {
    return store.clear()
  })

  .then(function () {
    return db.get('cleanTest')
  })

  .catch(function (error) {
    t.equal(error.status, 404, 'doc removed after store.clear')
  })
})

Sorry I've 3h of meetings ahead of  me now, let me know if anything doesn't make sense

@gr2m makes sense so i updated the PR \o/
thy for checking @janl @zoepage i'm very happy/proud to help in this project

all right, this looks great! Now is the time to clean up commit messages, so we can merge it :) And I know this is very confusing with all the commit conventions at all, but we are working on making them more clear and document them on hood.ie.
But anyway, can you squash these commits into these 3?

test(clear): initial version
feat(clear): initial version
docs(README): clear method and event

Does that all make sense? I can also do the squashing for you, just let me know :)

merged via c7de9ea


chore: upgrade deps

Closes: https://github.com/snapshot-labs/sx-ui/issues/712
starknet is not upgraded to satisfy compatibility with sx.js

Can we update GitHub action to fix the test?

We could move choices.json to constants.ts

So looks like there is also this file that we need to remove:
https://github.com/snapshot-labs/sx-ui/blob/master/src/helpers/execution.json
This may fix the issue with test / build GitHub action

We need to update eslint-config.


'byref' Error when opening a port with PortMidi

Hi, I'm getting the error:
AttributeError: module 'mido.backends.portmidi_init' has no attribute 'byref'
when trying to open an output port with the portmidi backend. (I'm using mido version 1.2.10)
I fixed it by reverting backends/portmidi_init.py back to commit bdc9249
just a little heads up.

Submitted https://github.com/mido/mido/pull/383 to reverse this change.


v1beta1 planning

proposed changes for v1beta1, to be discussed

move fields under status - NRT describes the status of resources on a node, so it makes sense to honor the spec/status split and to have the fields reported as status
add constants for values we use repeatedly, like "Node" (and possibly more). Also add constants for max supported NUMA zones (64)
evaluate addition of golang helpers, e.g. to extract the zone ID from the name
~make topologyPolicy a single string~
~report TM scope alongside policy~
~a more radical approach: split the TM configuration data into a new object~
remove topologyPolicy entirely. Document how node-local Topology Manager configuration can be expressed (labels)
podfingerprint as value (from annotation)

quick demo:
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
  creationTimestamp: "2022-04-21T11:30:27Z"
  name: noderesourcetopologies.topology.node.k8s.io
spec:
  conversion:
    strategy: None
  group: topology.node.k8s.io
  names:
    kind: NodeResourceTopology
    listKind: NodeResourceTopologyList
    plural: noderesourcetopologies
    shortNames:
      - nrt
    singular: noderesourcetopology
  scope: Cluster
  versions:
    - name: v1beta1
      schema:
        openAPIV3Schema:
          description: NodeResourceTopology describes node resources and their topology.
          properties:
            apiVersion:
              description: 'APIVersion defines the versioned schema of this representation of an object. Servers should convert recognized schemas to the latest internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
              type: string
            kind:
              description: 'Kind is a string value representing the REST resource this object represents. Servers may infer this from the endpoint the client submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
              type: string
            metadata:
              type: object
            status:
              description: NodeResourceTopologyStatus defines the observed state of NodeResourceTopology
              zones:
                description: ZoneList contains an array of Zone objects.
                items:
                  description: Zone represents a resource topology zone, e.g. socket, node, die or core.
                  properties:
                    attributes:
                      description: AttributeList contains an array of AttributeInfo objects.
                      items:
                        description: AttributeInfo contains one attribute of a Zone.
                        properties:
                          name:
                            type: string
                          value:
                            type: string
                        required:
                          - name
                          - value
                        type: object
                      type: array
                    costs:
                      description: CostList contains an array of CostInfo objects.
                      items:
                        description: CostInfo describes the cost (or distance) between two Zones.
                        properties:
                          name:
                            type: string
                          value:
                            format: int64
                            type: integer
                        required:
                          - name
                          - value
                        type: object
                      type: array
                    name:
                      type: string
                    parent:
                      type: string
                    resources:
                      description: ResourceInfoList contains an array of ResourceInfo objects.
                      items:
                        description: ResourceInfo contains information about one resource type.
                        properties:
                          allocatable:
                            anyOf:
                              - type: integer
                              - type: string
                            description: Allocatable quantity of the resource, corresponding to allocatable in node status, i.e. total amount of this resource available to be used by pods.
                            pattern: ^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$
                            x-kubernetes-int-or-string: true
                          available:
                            anyOf:
                              - type: integer
                              - type: string
                            description: Available is the amount of this resource currently available for new (to be scheduled) pods, i.e. Allocatable minus the resources reserved by currently running pods.
                            pattern: ^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$
                            x-kubernetes-int-or-string: true
                          capacity:
                            anyOf:
                              - type: integer
                              - type: string
                            description: Capacity of the resource, corresponding to capacity in node status, i.e. total amount of this resource that the node has.
                            pattern: ^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$
                            x-kubernetes-int-or-string: true
                          name:
                            description: Name of the resource.
                            type: string
                        required:
                          - allocatable
                          - available
                          - capacity
                          - name
                        type: object
                      type: array
                    type:
                      type: string
                  required:
                    - name
                    - type
                  type: object
                type: array
              type: object
          required:
            - zones
          type: object
      served: true
      storage: true

xref: https://github.com/k8stopologyawareschedwg/noderesourcetopology-api/issues/22
report TM scope alongside policy

Can we also include TopologyManagerPolicyOptions, I believe it should be of type []string.

Can we also include TopologyManagerPolicyOptions, I believe it should be of type []string.

I'm unconvinced about this. We decided to add the TM policy and then we mixed with the scope, so clearly separating the scope makes sense. But arguably adding the TM policy was already a stretch, so I'm not keen to adding even more data which is not directly related to the NUMA zone resource tracking (TM data is not).

that said, TM config is related to the problem we hare handling with, so we can totally discuss new extra objects to add to the general umbrealla of this API.

Yeah, that was my idea. I was confused that NodeTopology is mixed with kubelet configuration. Maybe we can introduce new Custom Resource to track TM configuration.

Yeah, was thinking about either. I was confused that NodeTopology is mixed with kubelet configuration. Maybe we can introduce new Custom Resource to track TM configuration.

This is something we can (and should!) totally do, I'm very open to explore this direction. We will need to design an object which is not too tied to the TM status, but I'm confident we can come out with something nice for v1beta1. Looking forward to hear your thoughts in this area.

Sounds good! Is there any design doc or PR where we can keep track of this?

Sounds good! Is there any design doc or PR where we can keep track of this?

not yet, we will need to figure out the timeline. Word of warning: this is very unlikely to progress much in the next 2-3 weeks. When the design starts, I'll link it here. We will need a way to collaborate, so it's possible it will be a design doc ora PR to reason about (or both)

make topologyPolicy a single string
report TM scope alongside policy
a more radical approach: split the TM configuration data into a new object

I am inclining towards the more radical approach here :) We should figure out a way to represent Topology Manager policies, scope and the newly introduced policy options. Perhaps something like a map[string][]string so that we can take in a Kubelet flags as key and their values captured in an array of strings which can be useful if the sys-admin decided to configure multiple policy options (when we have more of them even though it can be unlikely but still should not be ruled out).
Also, I noticed that we don't have left out this field in the CRD spec above. Was that intentional so we have a discussion on this topic?

Can we also include TopologyManagerPolicyOptions, I believe it should be of type []string.

I'm unconvinced about this. We decided to add the TM policy and then we mixed with the scope, so clearly separating the scope makes sense. But arguably adding the TM policy was already a stretch, so I'm not keen to adding even more data which is not directly related to the NUMA zone resource tracking (TM data is not).

I agree with @fromanirh that the use of topologyPolicies for capturing both topology manager policy and the scope has been a bit of an abuse of this field but at the same time see the value of representing the Topology related Kubelet configuration as part of this API. One reason for that is observability. Other is to enable additional use cases that could potentially make use of this API for custom use cases like the one @PiotrProkop mentioned he has been working on here.

Sounds good! Is there any design doc or PR where we can keep track of this?

not yet, we will need to figure out the timeline. Word of warning: this is very unlikely to progress much in the next 2-3 weeks. When the design starts, I'll link it here. We will need a way to collaborate, so it's possible it will be a design doc ora PR to reason about (or both)

@PiotrProkop If you have the time and would like, feel free to submit a PR that would unblock your work. Even though we don't have the bandwidth to drive this work, we will definitely make the time to review it :)

Since TopologyOptions are not dynamic and are built into kubelet we don't have to use maps or list but we can have explicit types for those options. The consequence is that  every time a new option is added the API would have to be updated. Or we can embed PolicyOption struct and just rely on k8s version.

@swatisehgal @fromanirh should we move this discussion to https://github.com/kubernetes/kubernetes/pull/96275? or the intent is to merge v1alpha1 and then create a KEP to start discussion around v1beta1. Right now the only thing that is blocking me is that there is no way to retrieve the scope for other policies than single-numa, so should I ask to add tmScope to v1alpha1 or add missing policies:

RestrictedPodLevel
RestrictedContainerLevel
BestEffortPodLevel
BestEffortContainerLevel

And if I should ask for it should I do it here or in kubernetes PR 😄

Sure, let's move the discussion to https://github.com/kubernetes/kubernetes/pull/96275. I would be inclined to merge as v1alpha1 and then handle v1beta1 separately. But, I am open to discussion and it depends on how the API review on the PR proceeds.

Right now the only thing that is blocking me is that there is no way to retrieve the scope for other policies than single-numa, so should I ask to add tmScope to v1alpha1 or add missing policies:
RestrictedPodLevel
RestrictedContainerLevel
BestEffortPodLevel
BestEffortContainerLevel

Irrespective of the approach we take, we should add these for the sake of completeness, I will update my PR: 96275 as well as here.

Sounds good!

note we will also need to change the updating agents (NFD, RTE)

So probably in this repo the:
Restricted TopologyManagerPolicy = "Restricted"
BestEffort TopologyManagerPolicy = "BestEffort"

Should stay and in kubernetes repo only policies mixed with scope will remain?
And when NFD and RTE will be updated to use NodeResourceTopology from Kubernetes the removal of old policies will be handled?

So probably in this repo the:
Restricted TopologyManagerPolicy = "Restricted"
BestEffort TopologyManagerPolicy = "BestEffort"

Should stay and in kubernetes repo only policies mixed with scope will remain? And when NFD and RTE will be updated to use NodeResourceTopology from Kubernetes the removal of old policies will be handled?

these are good points. We need to evaluate and explore the tradeoffs here.

note we will also need to change the updating agents (NFD, RTE)
edit: and make sure the consumers (most notably the scheduler plugin) can tolerate this change.

Yes, that's right. All the consumers of the API would have to be updated.

So probably in this repo the:
Restricted TopologyManagerPolicy = "Restricted"
BestEffort TopologyManagerPolicy = "BestEffort"

Should stay and in kubernetes repo only policies mixed with scope will remain? And when NFD and RTE will be updated to use NodeResourceTopology from Kubernetes the removal of old policies will be handled?

I think, we should keep "Restricted" and  "BestEffort" policies for https://github.com/k8stopologyawareschedwg/noderesourcetopology-api but in the kubernetes PR (API in staging) we should move to policy+scope for the sake of consistency. It will seem a bit odd to have "Restricted" and  "BestEffort" policies and similar ones policies with the scope. I foresee it raising eyebrows.  When NFD, RTE and Scheduler Plugin  transition to consuming the NRT API from the staging repo we would have to be handled this carefully.

So probably in this repo the:
Restricted TopologyManagerPolicy = "Restricted"
BestEffort TopologyManagerPolicy = "BestEffort"

Should stay and in kubernetes repo only policies mixed with scope will remain? And when NFD and RTE will be updated to use NodeResourceTopology from Kubernetes the removal of old policies will be handled?

I think, we should keep "Restricted" and "BestEffort" policies for https://github.com/k8stopologyawareschedwg/noderesourcetopology-api but in the kubernetes PR (API in staging) we should move to policy+scope for the sake of consistency. It will seem a bit odd to have "Restricted" and "BestEffort" policies and their corresponding policies with the scope. I foresee it raising eyebrows. When NFD, RTE and Scheduler Plugin transition to consuming the NRT API from the staging repo we would have to be handled this carefully.

:+1:

I'm very convinced we should remove configuration data (= TM policy, TM scope) from the NRT api proper. Question is: how to represent it, if at all?
The more I think about it, the more I'm convinced we should not represent at all. Perhaps only define labels (and their values) and depend on other components (e.g.: NFD) to add these labels. Assuming nodes are properly labeled, we have the exact same information we currently expose in v1alpha1. And, I'd say, in a cleaner and more kubernetes-y way.

I'm very convinced we should remove configuration data (= TM policy, TM scope) from the NRT API proper. Question is: how to represent it, if at all? The more I think about it, the more I'm convinced we should not represent at all. Perhaps only define labels (and their values) and depend on other components (e.g.: NFD) to add these labels. Assuming nodes are properly labeled, we have the exact same information we currently expose in v1alpha1. And, I'd say, in a cleaner and more kubernetes-y way.

I agree. We are already relying on NFD to advertise NRT resources, so relying on specific labels makes sense.

I like the idea of representing this information as labels. It gives us what we need and is much simpler than exposing a new object. Given that is a well recognized software component intended to expose both hardware features and system configurations, I believe it is a good fit for storing configuration information like this.
@marquiz WDYT about NFD exposing Topology manager policy and scope as labels? Perhaps, we can expose Topology Manager policy options and CPU Manager policy/policy options as well?

Continuing this train of thought, I think we should expose not just the TM policy, but something that abstracts a bit the node behavior enforced by that scope. Random brainstorm:

topology.node.k8s.io/numa-alignment: strong represents TM-policy single-numa-node
topology.node.k8s.io/numa-alignment: best-effort represents TM-policy best-effort
no label: TM disabled or none policy
how to represent restricted? no clear idea yet :)

scope is easier:

topology.node.k8s.io/numa-scope: pod
topology.node.k8s.io/numa-scope: container

TL;DR: labels should represent concepts enabled by TM config, should not reflect TM config 1:1

Continuing this train of thought, I think we should expose not just the TM policy, but something that abstracts a bit the node behavior enforced by that scope. Random brainstorm:

topology.node.k8s.io/numa-alignment: strong represents TM-policy single-numa-node
topology.node.k8s.io/numa-alignment: best-effort represents TM-policy best-effort

What benefit do you see in abstracting the concept as opposed to representing the configurations 1:1? Representing the topology manager configuration or in general kubelet configuration directly without abstracting it gives a clear view of what is being represented in the label (kubelet configuration on the node) and is much more intuitive rather than having to interpret what strong alignment is indicative of.
Abstracting the policies means that NFD has to translate the policies to an abstract label and some component has the responsibility of correctly interpreting it which makes me a bit nervous.

just a general comment, please stop using term "NUMA" anywhere in API and please don't put it in new ones. It is not technically correct and not matching neither existing on the marked hardware nor upcoming in near future.

just a general comment, please stop using term "NUMA" anywhere in API and please don't put it in new ones. It is not technically correct and not matching neither existing on the marked hardware nor upcoming in near future.

point taken.


fix: no longer support the substring function

Which issue does this PR close?
Closes #10240.
Rationale for this change
Before version 0.45.0 of sqlparser, the special flag for both substring('xxxx', 1, 2) and substring('xxxx' from 1 for 2) was false.
After https://github.com/sqlparser-rs/sqlparser-rs/pull/1173, the special flag for substring('xxxx', 1, 2) becomes true.
We need to support both formats  as before, so there's no need to check the special flag.
The 'from' and 'for' parameters don't support string types because they should be treated as regular expressions. Currently, substring is just an alias ofsubstr. This PR adds tests to verify this.
Reference document: https://www.postgresql.org/docs/current/functions-string.html
What changes are included in this PR?
Re-enable substring('xxxx', 1, 2).
Are these changes tested?
Yes
Are there any user-facing changes?
No

Looks good to me @jonahgao  -- thank you for the review @Jefffrey


[FLINK-25197] Fix serialization issue in RequestReplyFunctionBuilder

This fixes the issue described in FLINK-25197, where this error occurs when using RequestReplyFunctionBuilder to build Statefun jobs:

Java 8 date/time type java.time.Duration not supported by default: add Module "org.apache.flink.shaded.jackson2.com.fasterxml.jackson.datatype:jackson-datatype-jsr310" to enable handling

The fix is to make RequestReplyFunctionBuilder use an instance of StatefunObjectMapper to serialize the client spec -- previously, it used a non-customized instance of ObjectMapper -- and to change StatefunObjectMapper to support serialization of java.time.Duration values.

@tillrohrmann Thanks!


Phpdev async with amphp

So basically you can now require a specific branch.
Branches that are named like phpdev-* are pushed without the phpdev- prefix to the vaas-php repository.
So when you have a branch called phpdev-somethinggreat you can install the branch with
composer require gdata/vaas:dev-somethinggreat

This PR also replaces this https://github.com/GDATASoftwareAG/vaas/pull/544

You can see the asnyc version running in this https://github.com/GDATASoftwareAG/nextcloud-gdata-antivirus/pull/117

This has to be a major release because there is a big api change


renaming generate to gen

@annikahe I was fitting the style to pep8 and we had many long lines I had to break. (although I really don't like how they look). So just to alleviate it a little bit, I changed all generate functions to gen. should we keep it that way or do you think have the value of having a verb in functions?

Good idea! I would like to keep it that way.
There are still a lot of function or variable names that appear to be rather inefficient, for example:
get_transformed_mallows_normalization_constant, dispersion_parameter, number_of_alternatives, ...
What do you think of changing things like "constant" -> "const", "parameter" -> "param", "number" -> "num", ...?

What do you think of changing things like "constant" -> "const", "parameter" -> "param", "number" -> "num", ...?
All sounds good. I am still not sure about generate though. Is it really crystal clear for everyone that it is generate. For instance alternatively, we can use generate only for voter generation. Then we don't need to use generate_mallows_voters but just generate_mallows.

Maybe we can meet at a certain point and go through the code once and make a huge refactoring attempt. Since the package is alpha and probably no one is using it yet, we have the luxury to change things.
Should we create a section for naming conventions on CONTRIBUTING.md? We can take a look at some principles we can use. For instance  "The Art of Readable Code" by Boswell and Foucher suggest (among other things):

Use specific words  (download instead of get)
Avoid generic names (like tmp)
Use concrete names (CanListenOnPort() instead of ServerCanStart)
Attach important details ( name_detail)
Make sure that a name will not be misundersrood
Make booleans clear (is_blabla, has_blabla)

What do you think?

I somehow like the fact that having "voters" in the function name directly shows that this function is about voters and not candidates or something else (might be important for people who do not know Mallows model), but probably this effect can be achieved in some other way...
What is the reason you rather want to keep generate?
Talking about this and creating this section about naming conventions in CONTRIBUTING.md sounds good.


.Net: Add ReturnParameterView for native functions

Motivation and Context
More specific information on the output of native functions is needed to enable planners.
This change provides a way to describe an output for a native function using an attribute, and a way to view this description along with the output return type via FunctionView.
Description

MathPlugin.cs - Adds return Description usage as an example.
FunctionView.cs - Adds ReturnParameterView to FunctionView
ReturnParameterView.cs - New ReturnParameterView. Has a description. Waiting on type until design decision made.
NativeFunction.cs - Adds ReturnParameterView to NativeFunction. Adds ReturnParameterView to MethodDetails and updates logic in GetMethodDetails to access the return parameter's Description.
SKFunction.cs - Adds ReturnParameterView parameter.
FunctionViewTests.cs - Adds unit tests for FunctionView and logic around attributes in GetMethodDetails.

Thanks everyone for your feedback.  Definitely think the naming and descriptions have improved as a result!


Contributing guide mentions Atom

For https://github.com/flutter/flutter/blob/master/CONTRIBUTING.md
We probably want to remove the Atom references from this doc.
Thanks to @raju-bitter for the report!

cc @mit-mit

@sethladd who knows about the test coverage stuff (lcov)?

Probably me.  What would you like to know?

Is there a lcov plugin for IntelliJ that you happen to know is working against the files we generate?

@devoncarew do you have any experience with lcov in IntelliJ

I don't, but IntelliJ does have good support for code coverage in general. @jwren and @stevemessick would know more; I know we've wired up support for code coverage with our test runner (for the Dart plugin).
When we wire up running tests via flutter test, we'll want to make sure we get coverage support as well.

Is there something that you can do with Icov that you can not do with the coverage support in Dart right now?
@alexander-doroshko

I don't know what lcov does. IntelliJ IDEA is able to collect/show coverage for Dart Command Line Apps. If it is possible to run tests as a standard dart app (not as 'pub run test' or 'flutter test') then just configure Dart Command Line App in Run | Edit Configuration and click Run With Coverage button.

@alexander-doroshko lcov is a format for capturing code coverage information. It looks like IntelliJ supports it when testing js coverage with Karma:
https://www.jetbrains.com/help/idea/2016.3/coverage-tool-window.html
But looks like the coverage tool window is not available for dart code?

Yes, looks like Coverage tool window is not shown. Only gutter marks in the editor and file count in the Project View.

Flutter collects coverage via flutter test --coverage  It also has a --merge-coverage and --coverage-path directive which one can use when you want to iterate on part of the system (and still get coverage data) without doing a full coverage run.
I believe we only use the lcov tool itself for --merge-coverage, and otherwise just spit out lcov-compatible files since afaict that's the standard format.  @abarth and @cbracken wired this all up an would know more if you need.

Where did we end up with this? Can we just remove the mention of Atom from our CONTRIBUTING guide?

The CONTRIBUTING.md documents how to contribute to the flutter.git repository.  Currently Atom is required for some kinds of contribution (specifically having to do with visualizing lcov test coverage data).  It's possible that we could improve IntelliJ to support those use cases, but it does not support those use cases today.  (IMHO, we should improve IntelliJ in this way.)
I'll clean up CONTRIBUTING.md to clarify that you only need Atom if you're working with test coverage.

I filed https://github.com/flutter/flutter-intellij/issues/718 requesting support for lcov in IntelliJ


ActsAsTaggableOn PaperTrail error

I'm encountering a strange issue with 4.0.0beta1 that's not there with 3.0.6. When I run our complete cucumber tests, I get the error:
(::) failed steps (::)

undefined method `paper_trail_enabled_for_model?' for ActsAsTaggableOn::Taggable:Module (NoMethodError)
./app/controllers/application_controller.rb:35:in `update'
./app/controllers/application_controller.rb:73:in `use_zone'
./features/step_definitions/study_steps.rb:66:in `/^I save the Study$/'
features/studies.feature:18:in `And I save the Study'

Failing Scenarios:
cucumber features/studies.feature:9 # Scenario: Edit Existing Study

However, when I run just cucumber features/studies.feature:9 it passes. Both work fine with 3.0.6. This is testing with Rails 4.1.9 and acts-as-taggable-on 3.4.3.
The failing step is simply:
# study_steps.rb:66
When(/^I save the Study$/) do
  click_button 'Save'
end

# application_controller.rb:73
  def use_zone(&block)
    Time.use_zone(time_zone, &block)
  end

Thanks in advance for any suggestions.

I'm guessing you have a model where you are inheriting from ActsAsTaggableOn and also versioning it w/ PaperTrail?  Perhaps #362 can help you, perhaps it's unrelated.
Here is what I can tell you: paper_trail_enabled_for_model? is available as a class method for ALL models. In PaperTrail v3.x, that method would always return true unless you had specifically turned it off for a specific model inside of your app. As you can see in the CHANGELOG, for PaperTrail v4.x, that method has now been made to be more intelligent, and will actually return false if has_paper_trail is not declared on a model.  See #438 for more on the update.
There is also an instance method which will only be available if has_paper_trail has been declared on a model.  The behavior for that one is the same as you would expect (returns true unless it has been turned off for that particular model).  It actually just makes a call to the class level method.
So it seems to me as though for some reason a call is being made to a model at the class-level when perhaps it shouldn't be...
The only other thing I can think of is that v3.x, the Cucumber helper is included by default, whereas w/ v4.x it must be manually required if you want to use it.  So if this is only failing in your tests, you may want to take a look at that.

Also, I I just released v4.0.0.beta2, can you give that a try?

4.0.0.beta2 fixed my bug. Thanks very much!


Edit: WXWZ-LD1 [US]

Channel ID (required)
WXWZLD1.us
Channel Name
No response
Alternative Names
MásTV PR
Network
No response
Owners
No response
Country
PR
Subdivision
No response
City
No response
Broadcast Area
c/PR
Languages
No response
Categories
No response
NSFW
FALSE
Launched
No response
Closed
No response
Replaced By
No response
Website
No response
Logo
No response
Notes
No response

Please update your request:

invalid channel ID

https://github.com/iptv-org/database/blob/master/CONTRIBUTING.md#channels

Please update your request:

invalid channel ID

https://github.com/iptv-org/database/blob/master/CONTRIBUTING.md#channels

Done


test(cypress): use cypress session for authentication

We could use this to login during e2e tests and allow for easy switching between users. Some other potential changes we could make:

Test against the netlify deploy with the GH action deployment_status event
Test against a dockerized backend (see: https://dhis2.slack.com/archives/C0BP0RABF/p1677502943481919, https://github.com/dhis2/scratch-actions-sandbox/pull/2, https://github.com/dhis2/dhis2-core/blob/master/.github/workflows/run-api-tests.yml#L58)

It does seem like this needs a more recent cypress version than what we're currently supplying through our cypress libs though.

Superseded by https://github.com/dhis2/scheduler-app/pull/484


}-key missing on german bluetooth keyboard

German keyboard layout doesn't allow me to type '}' on a physical keyboard in the editor window. However the key works in the rename window of acode (F2). To type } on a german keyboard you press AltGr+0. I didn't change any key bindings in acode.

This could be relevant to the problem:
https://github.com/atom/atom/issues/2907

Thanks for the reference. I'll find solution and fix it soon.

Seems like i have the same problem...

Solved it in the settings.

Go to Settings / Other Settings / Key bindings -> Edit
Change key bindings for foldOther and unfoldall to null.
It will look like this:

"foldOther": {
"description": "Fold other",
"key": "null"
},
"unfoldall": {
"description": "Unfold all",
"key": "null"
},


Packaging instructions

How is the Release bundle generated? (there are several tools that could have been used)

I've been using py2exe to generate the releases. Gonna try to dig up and add the setup script that has been used.

The py2exe script and some brief instructions have been added. I realized now that the way to package the software as an exe is quite cumbersome and should probably be reworked.


dotnet-watch restarts app but does not recompile when files are deleted

Repro:

Create a files that uses globs to import *.cs files.
dotnet watch run
Delete a file matched by the glob

Expected
Dotnet-watch restarts app with deleted file no longer included in the build.
Actual
dotnet-watch restarts the app, but the app was not recompiled.
Cause:
https://github.com/Microsoft/msbuild/issues/701

Fixed in dotnet-cli 1.0.0-preview4-004233


Rework autorefs replacement to not re-parse the final HTML

Define a "transport representation" for autorefs:
SomeHTML

First a native Markdown extension translates from the usual [SomeMarkdown][SomeIdentifier] to the above, and then the post-process replacement mechanism (which is kept in the same place as before) doesn't need to be so careful and complicated, it just indiscriminately replaces such exact strings.
This is a very big boost in performance and I think is more future-proof.
Other mkdocstrings handlers are also free to use this mechanism: define whatever syntax for autorefs that they need and then insert this exact HTML themselves, for the postprocessing to pick up later. It used to be possible to insert the square-brackets Markdown before, but that was very fragile.

Fixes #187.
Compare the performance profile to what I posted there.


[BEAM-3866] Remove windowed value requirement for Go SDK External

Updated remaining W<> comments.
Added missing registration of addFixedKeyFn.

R: @lostluck

Thanks!
R: @tgroh

LGTM