Markdown or LaTeX formatted text is not rendered in Conversation view.

Verify it's not a duplicate bug report

[X] I searched for similar bugs reported on GitHub and nobody has reported a similar issue. Search all issuees.
[X] I read Troubleshooting guide on Readme and there is not a guide on how to solve my problem.

Describe the Bug
Markdown or LaTeX(I don't know which causes the issue) formatted text is not rendered in Conversation view.
-window11
-vscode(version 1.76.2)
Please tell us if you have customized any of the extension settings or whether you are using the defaults.
using the defaults
Additional context

The extension doesn't render Latex, only Markdown. If you copy the response in Markdown, you will see the ChatGPT's raw response. as far as I can see, everything in your screenshot looks fine. Could you provide us with your prompt in English and the response you are getting?

The extension doesn't render Latex, only Markdown. If you copy the response in Markdown, you will see the ChatGPT's raw response. as far as I can see, everything in your screenshot looks fine. Could you provide us with your prompt in English and the response you are getting?

my prompt in English is: show me some examples of latex formula
the response
好的，以下是一些常用的latex公式示例 is  Ok, here are some examples of commonly used latex formulas
代码 is code ，显示 is display
as you said, there's no problem in Markdown, but Latex.
maybe render Latex is a good idea

Thanks for confirming. I updated the label of this to be enhancement and removed the bug label.
Our focus is to bring the extension to a level to provide users with the best experience with AI. Rendering LaTeX is out of scope at the moment. However, we are happy to see whether this enhancement request is a popular one.
If you stumbled upon this issue in the future, please upvote this comment if you want us to consider adding a LaTeX rendering support in the upcoming releases.

@genieai-info what is the best way to indicate support for this feature request?


Safari 10.1 throws Error: The provided value is non-finite

When using vtt.js in Safari it throws Error: The provided value is non-finite on this part cue.line = settings.get("line", "auto");.
I think this is an issue in the Safari VTTCue implementation, but I hope to find a workaround in this polyfill.
Below the stacktrace:
consumeCueSettings@http://localhost:9000/bower_components/vtt.js/lib/vtt.js:269:10
parseCue@http://localhost:9000/bower_components/vtt.js/lib/vtt.js:303:23
parse@http://localhost:9000/bower_components/vtt.js/lib/vtt.js:1268:23

macOS Sierra 10.12.4
Safari Version 10.1 (126<IP_ADDRESS>.34)

Here's what we do in jwplayer:
var line = settings.get('line', 'auto');
if (line === 'auto' && defaults.line === -1) {
    // set numeric line number for Safari
    line = -1;
}
cue.line = line;

Here's how we worked around it:
const oldVTTCue = global.VTTCue;

try {
    global.VTTCue = VTTCue;

    parser.parse(vtt);
    parser.flush();
} finally {
    global.VTTCue = oldVTTCue;
}

The VTTCue in scope is the one from vtt.js

The spec clearly allows for 'auto' :|
https://w3c.github.io/webvtt/#webvtt-cue-line
Apple's native VTTCue is not spec compliant.

Agreed, but why not solving it in the polyfill?

Thanks, cue.position also throws this error.

I added position to my PR

Apparently the travis build failed with that change... :/ position wasn't 'auto'?

Ugh... apparently that breaks the tests. cue.position is auto by default (in chrome & ff...in safari its 50) and I'm just using the default if set... and falling back to what was there... :/

Im using cue.line !== "auto" ? cue.line : "auto" for line and position which seem to work. Not sure if they pass the test though.

This is not really resolved yet...

my PR should fix it

Oops wrong button!

Hi, is there any progress on this? Or maybe a workaround?

Just waiting for the pr to be merged.

We are still getting this issue in Safari 13.0.3 (156<IP_ADDRESS>.4). Any news on the PR being merged?

I believe this is fixed or will soon (in the next release) be fixed in the videojs fork of vtt.js. It's probably the only currently maintained version of vtt.js: https://github.com/videojs/vtt.js (videojs-vtt.js on npm)


Fix diagnostic position in concat document and proper clearance on document close

Fixes https://github.com/microsoft/vscode-jupyter/issues/6581

@kimadeline or @paulacamargo25 Would y'all mind reviewing this at some point before the July release candidate is created, please? 😊 This PR fixes a major regression in language server support for notebooks that was introduced between releases, so we'd really like to get this in for the stable release. Thank you both!


texstudio: 4.6.2 -> 4.6.3

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 249126 run on x86_64-linux 1

1 package built:

texstudio

Result of nixpkgs-review pr 249126 run on x86_64-linux 1

1 package built:

texstudio

Thank you @ajs124 :)


Implement non-block read the result log

Read the data and write into redis or other storage.

Please refer to https://github.com/wizawu/Gpoll/blob/master/gpoll.go#L70


Can't install the theme

Do you have the latest versions of Spicetify, Spotify and Lucid?

[X] I'm using the latest versions of Spicetify, Spotify and Lucid

Is there already an issue for your problem?

[X] I have checked older issues, open and closed

Is your problem definitely caused by the theme?

[X] I have checked the app behavior without the theme and it is different

Environment & Computer Info
- Spotify version: <IP_ADDRESS>5.gf2c48e6f
- Installed from: Spotify Site
- Spicetify version: v2.38.4
- Color scheme:
- Extensions: Cover Ambience, Full Screen, WikiFly, Image Opener, Remove Connected Bar
- Custom apps: library, lyrics-plus, marketplace
- Lucid installation method: PowerShell script

Description
Hello, today, after the last update of Spotify, Spicetify Lucid stopped working for me. I tried to update it (after having updated Spicetify) but nothing changed. So I uninstalled it (powershell method) and tried to reinstall it through the powershell. But I received this error. What's the problem?
Screenshots

Can you try again ?
also try using a vpn as the site maybe blocked

Hello, in the end, I solved it by deleting the folder 'Lucid' in the Spicetify directory. Then I tried to install it again, but nothing changed. However, when I tried to update it, it worked. So, right now, everything's going well.

great to hear that
am closing this issue as its fixed.


add pyOpenSSL==3.3.1 to native image

Status
Ready/In Progress/In Hold (Reason for hold)
Related Content Pull Request
Related PR: link to the PR at demisto/content
Related Issues
Related: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.

We're holding off until the Rock release provides a version with an updated OpenSSL library.


Send X-Robots-Tag: noindex, nofollow also for autogenerated urls

currently we add X-Robots-Tag: noindex, nofollow headers to all development environment, it would be good to also add these headers to autogenerated domains (like https://varnish-drupal-example-master.ch.amazee.io)
In order for this to work, the webserver (nginx) needs to know which domains are the autogenerated domains or which URL patterns are used for the auto generated domains

@Schnitzel , any argument against carrying https://github.com/amazeeio/lagoon/blob/master/services/openshiftbuilddeploy/src/index.js#L170-L171 forward into the nginx container as an env var?

After discussion, we will add the automatically generated routes to the configmap ( #688 ), then nginx can use that list to set the headers appropriately


[Feature Request]: port DatagridSelectAllWithToggle labelText prop fix to v1

The problem
I have the following console errors when using the useSelectAllWithToggle hook for datagrid:
 console.error
      Warning: Failed prop type: The prop `labelText` is marked as required in `Checkbox`, but its value is `undefined`.

    console.error
      Warning: Failed prop type: The prop `children` is marked as required in `Text`, but its value is `undefined`.

The current version 2.39.0 passes labelText to the checkbox component (line 78). The labelText prop also serves as the children of (line 207).
We are currently on version 1.72.2 of @carbon/ibm-products and I'm seeing that version does not pass the labelText prop to checkbox:

The solution
I'm requesting this fix be ported to v1 of @carbon/ibm-products so it can be available for the IBM cloud projects-ui. If we could port the fix to a release near/after v1.72.2 that would be ideal.
Design link
No response
Links to other materials
No response
Owner/main maintainer(s)
Riley Johnston
Second/backup maintainer(s)
No response
Product/offering
IBM cloud projects-ui
Business priority
Medium Priority = upcoming release but is not pressing
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I checked the current issues for duplicate issues

We've been investigating TanStack Table, a third-party, open-source offering, which provides extensive data table capabilities surpassing what our Carbon Datagrid offers. It provides much more flexibility and customization. TanStack Table is headless which means it can easily be added alongside Datagrid component in your product or application. The benefits of more flexibility for product teams and less maintenance for Carbon makes it a win win. Lastly, it is available in multiple frameworks including React and Web Component so it provides an option to non-React product teams.
For these reasons, we have decided to transition from building our own custom table component to using an example-based approach with TanStack Table. Datagrid will still exist in our library for existing teams but we are announcing the deprecation* of the Datagrid component in v2.54.0 release so teams can begin to work through the transition. Details about how to use both Datagrid and TanStack together can be found here.
*Deprecation means that no new features will be added however sev 1 and sev 2 bugs will be supported.


Add support for subject-level files

#446 adds subject-level files to support the BIDS format. A user can get these files by downloading the project the subjects are in, but the normal file-level REST verbs/individual file download/elasticsearch indexing is not available currently.
Relates to #389

Want to keep this open?

I think it's implied in #389.


Quick way to just get header row

What is the best way to grab just the header row data?

Hi,
Something like this should work:
var headers = new List<string>();
using (var reader = ExcelReaderFactory.CreateReader(stream)) {
	if (reader.Read()) {
		for (var i = 0; i < reader.FieldCount; i++) {
			headers.Add(Convert.ToString(reader[i]));
		}
	}
}

This works great, but I would also like to get the cell location. (A,B,C, etc...) Is that information provided, or is it just the column index?

cell location. (A,B,C, etc...) Is that information provided, or is it just the column index?

Yes, that's right. Column index 0 → A, 1 → B, 2 → C etc.

I was implying that I wanted the values A, B, etc... but I didn't see how to get them. Is it possible to get the A, B?? If so, how do I get to it?
headers.Add(Convert.ToString(reader[i]));

Ah gotcha. ExcelDataReader does not expose a built-in method to convert from numeric column indices to column references with letters.
But something like this should do it:
https://stackoverflow.com/a/182924
(please note the comments on SO, GetExcelColumnName expects a 1-based index, whereas the counter i in my first snippet is 0-based, so you may want to +1 somewhere)
private string GetExcelColumnName(int columnNumber)
{
    int dividend = columnNumber;
    string columnName = String.Empty;
    int modulo;

    while (dividend > 0)
    {
        modulo = (dividend - 1) % 26;
        columnName = Convert.ToChar(65 + modulo).ToString() + columnName;
        dividend = (int)((dividend - modulo) / 26);
    }

    return columnName;
}


crypto/rand/rand_vms.c: include "internal/rand_int.h"

Without it, the RAND_POOL typedef is missing

@mattcaswell, this needs to be merged before release.

Pushed.


[FEAT] Explain the difference between Unrestricted and Bypass on the BetterRTX Installer Page

Unrestricted: Allows scripts to run (With user allowance)
Bypass: Allows scripts to run without requiring the user to press R to allow the script to run.

Done. Updated when next update Thank you again. 🤝


Visual Studio Code Server

Hi,
I'd like to ask about feature that came recently to my mind.
Let's say that we have Vagrant or just plain VM.
Let's say we use Rust or similiar programming language where we have appropriate extensions for VSCode, but they require some time and knowledge to setup (Rust Language Server etc.).
Let's say that we have beginner programmers that may use Windows, Linux or Mac and it's cumbersome for them to setup development environment themselves, so it should be possible to just download code, run prepared Vagrant VM and have everything up and running.
Now, it would be nice if this virtual machine had some "Visual Studio Code Server" (and that's my requested feature), so we would have Visual Studio Code on our host machine that can connect to this server on VM (ssh?), use server's configuration, plugins and allow to browse file, folders, execute commands provided by extensions, use terminal, remotely.
I can see huge value in this feature, because it would allow to provide seamless, friendly experience, even for most complicated projects.

@Adiqq in the meanwhile, check out the recommended extensions section for adding recommendations for new users. I use it in my repo, and it saves a lot of headache while onboarding new people.

Duplicate of #29194


Add Getting Started section to README

README updates
Please add a getting started section to the README so that folks know how to start with this project.

Adding Getting Started section in README files


Asking For Video Resources

Hey maurya, Are there any video resources to learn HTML and CSS.

@AbhigyanSrivastav The video source for html & css added.

@AbhigyanSrivastav The video source for html & css added.

Thanks


Initial work on CC-catalog API server (set up Django REST skeleton and migrate models from the legacy app)

Hey, @aldenstpage, can you point to the commits that were relevan to this issue?

You can find most of it in the es-sync branch that I've been working on, since all of this stuff was a prerequisite of working on the Elasticsearch synchronizer.
Apologies for the monster commit, I restructured the project and added a lot of new content at the same time.


Update RN Reanimated, Gesture handler and Screens packages to newer versions

Problem
Coming from here
We are soon going to update the app to the newly released RN 0.72.  That means we can also update other packages to the latest versions which support up to date RN.
Why
This helps to get the most out of the packages for us.
Solution
SWM can help us with this as they are maintainers of the packages.
Update:
react-native-reanimated 3.1.0 -> 3.3.0
react-native-gesture-handler 2.9.0 -> 2.12.0
react-native-screens 3.17.0 -> 3.21.0

Hey :wave: I’m Michał Skałka from Software Mansion, an expert agency, and I will help close this issue out

@fabioh8010 Could you please bump these libraries as part of this PR too https://github.com/Expensify/App/pull/18507

@Skalakid can help with any issues with the update.

@mountiny Yes of course :D @fabioh8010 If you have any questions/problems with updating these packages feel free to contact me

@Skalakid @mountiny I bumped those libraries in the PR and it seems everything is ok for now 😄

lovely

The PR is still going, its a major change so it takes a bit of time

This is the PR fixing this https://github.com/Expensify/App/pull/18507

Still waiting on the PR 👍

No update yet 👍

Hopefully merged soon, I think we can actually close this in favour of https://github.com/Expensify/App/issues/18444 no reason to keep them both open given its all happening in one PR

The automation didn't work for some reason. Added hold for payment to the title.


Update s3, sdk-core, sqs to 2.20.76

About this PR
📦 Updates

software.amazon.awssdk:s3
software.amazon.awssdk:sdk-core
software.amazon.awssdk:sqs

from 2.17.295 to 2.20.76
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "software.amazon.awssdk" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #613.


python3Packages.pymyq: 3.0.4 -> 3.1.0

Motivation for this change
Update to latest upstream release 3.1.0
Change log: https://github.com/arraylabs/pymyq/releases/tag/v3.1.0
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 133383 run on x86_64-linux 1

3 packages built:

home-assistant
python38Packages.pymyq
python39Packages.pymyq


I can't skip 'for i in dataset' of the ‘get_the_length_of_dataset’ function in 'prepare.py'

I follow the instructions in READMD.md.But ‘
def get_the_length_of_dataset(dataset):
count = 0
for i in dataset:
count += 1
return count
’ looks like a dead cycle.
My Python version is 3.7 and tensorflow version is 2.0.0.
Windows10
Have you ever met this situation and how can I solve it
Thanks.

My dataset includes images in JPG, JPEG and PNG formats. Can this be supported?

Ah, there seems to be something wrong with my environment. Now there is no such mistake.


Start negative token ref and add match_hook preceded_by_lemma

started work on #53, but realized to be really useful it needs functionality that, AFAICT, is hard to implement

This also adds REPLACY_OP key for use like
"suggestions": [
            [
                {
                    "PATTERN_REF": -1
                },
                {
                    "TEXT": "with"
                },
                {
                    "PATTERN_REF": -2,
                    "REPLACY_OP": "LOWER"
                }
            ]
        ],

so far, options are LOWER/TITLE/UPPER


[FR] - CLI - Include to-verification for various shelley keys

Describe the feature you'd like
Implement to-verification key to make it easier for wrapper scripts to not have to specify a signing key as well as verification key (or address). This would also allow us to recreate the verification key using the signing key.
Similar feature is available for Byron CLI (and was also commonly used in Jormungandr)

Is this a duplicate?

I'm assuming what you're asking is for the ability to derive the verification key from the signing key. Can you confirm that's what you mean?
This already exists for some key types, e.g. cardano-cli shelley genesis get-ver-key.
So my interpretation of the request would be to provide this functionality consistently for all key types.

@dcoutts Yes - thats correct.

So we should not close this now

We will provide this functionality consistently for all key types with a sub command


Consider passing RNG instead of seed to samplers

First of all, congratulations on this great package! :tada: I work a lot with generation of random images in geostatistics (GeoStats.jl) and it is nice to see more algorithms available.
May I suggest sampler_type(rng=...) instead of sampler_type(seed=...)? In Julia, whenever we want to guarantee reproducibility with random numbers we pass the generator object instead of the seed, and it goes as the first positional argument instead of a keyword argument. See the rand docstring for example.

A lot of thought went into this idea early on in the design process, and was ultimately rejected, as it poses a few problems.
Each sampler requires its own distinct RNG, and in a pipeline of modifiers, there can be no shared state if one wants reproducible results and the ability to inspect a sub-graph of samplers.
Not all RNGs allow seeding, such as RandomDevice, and is not required for AbstractRNG derivations.
The Random interface does not have provisions for retrieving the seed a RNG was initialized with, which the current implementation relies on. We do this by wrapping the RNG in a type that also stores the seed, and to do this generically for any concretely-typed RNG would require a parametric struct.
Some RNGs place restrictions on the type of the seed they are initialized with. For example, the default Xorshiro256++ RNG in Random cannot be seeded with Signed integers, as that is a DomainError.
One could argue that the "seed" is a user-centric API feature of CoherentNoise.jl, and the RNG is an implementation detail that is encapsulated and free to change in the future.
Changing this would be a breaking change and for more disadvantages than the advantage of consistency with Julia conventions.
I will think about all of this for a future version though. Thank you for your kind words and suggestion!

Ok, so first of all, thank you very much for the suggestion. I have thought about this and I decided that it doesn't make a lot of sense to pass a RNG to a sampler. This is because "sampler" is a bad name, and will be changed in the future. CoherentNoise.jl samplers are nothing like their more random PRNG cousins, and the random number generator is an implementation detail. Infact, we rely on a specific RNG baked into the library for reproducibility (Julia is free to change the results of its RNGs even in patch-level releases). In short, the RNG that CoherentNoise.jl uses should not be exposed to the user, and the user should not be able to specify a custom RNG, as "samplers" are more like "evaluators", and the randomosity is just an extra feature baked in deep and would require significant changes for no real gain.
However, there are two things that we can do, one of which I implemented in the development version (not an official release yet):

The seed parameter of a sampler now defaults to nothing, which correlates to using your machine's hardware random number generator to produce a seed automatically. This means each sampler instance will have non-deterministic output values when sampled with the same set of coordinates. This makes more sense than the old method of defaulting seed to 0, as it makes it convenient for the user to zero-in on a noise result they like, and then query the seed of the sampler to reproduce those results at a later time if they desire.

You can make use of the modifier interface. A modifier is capable of modifying the input coordinates before sampling, or the output value returned from sampling. In this case, you could easily write a modifier (which is just another sampler). This has to be done carefully though, as you don't want to just randomize the input coordinates, otherwise the result would not be spatially coherent. You would need to do something like the cache modifier, which would cache a set of random values to add to input coordinates. I don't really like this idea, because the library doesn't really have first-class support for caching sampler state.

I think option 1, which is already implemented, should cover 99% of what you're after, without exposing the implementation details of the library. I'm going to close this issue as solved, but feel free to discuss this further.

Regarding reproducible random numbers there is a package for that which is
independent of Julia versions. Please double check before reinventing the
wheel. Search for reproducible random in JuliaHub.
Em dom., 28 de ago. de 2022 14:27, Michael Fiano @.***>
escreveu:

Closed #7 https://github.com/mfiano/CoherentNoise.jl/issues/7 as
completed.
—
Reply to this email directly, view it on GitHub
https://github.com/mfiano/CoherentNoise.jl/issues/7#event-7273774955,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAZQW3NE7OHQSQ6FODNKOQDV3OOOTANCNFSM57LKRMQA
.
You are receiving this because you authored the thread.Message ID:
@.***>

We already use one of the two libraries. StableRNGs.jl and RandomNumbers.jl are by the same organization, and we chose the latter, as LCG provided by the former is not the best RNG.


Update zinc to X4

retest this please

retest this please

Thanks @wpopielarski, #1122 fixed the test failures even though, I don't understand why.


[Accessibility] Disabled radio-group should not be focusable #47

Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes: #47
Summary:
adding a condition inside resetRadio function handler when setting the tabIndex
Type of change:
Please delete options that are not relevant.

[x] Revision of an existing capability

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team

Please rebase off of the latest release. https://auro.alaskaair.com/contributing/upstream

Hi @blackfalcon,
I have rebased off upstream master, please tell me if it is good.
Thanks~

Will be adding this code update to the following PR

https://github.com/AlaskaAirlines/auro-radio/pull/111

Will be adding this code update to the following PR

https://github.com/AlaskaAirlines/auro-radio/pull/111

OK, I will also put above PR in my watch list.

I am going to close this PR since changes already included in #111. Thanks~


"Anything Everywhere?" is not displaying properly on the ComfyUI canvas

@chrisgoringe "Is there something everywhere?" is not displaying correctly on the canvas after updating ComfyUI, however in the preview in node search the customization entries appear

I'm seeing this same issue in the latest update

Please check you have latest version of UE, I pushed an update yesterday

See #214

Correct, with the latest update it is fixed. Thanks!


Add more buttons

Once we got support for the user to customize the buttons (still depending on some fixes in the touchbar support for the vsCode), we could have some extra buttons:

[x] Rename file (already has an open PR)
[x] Duplicate selection/line
[x] Find next
[x] Select next
[x] Toggle "show white spaces"
[ ] Fold/unfold
[x] Toggle block comment
[x] Find all references
[x] Peek definitions
[x] snap tab left (internally to app - not OS)
[x] snap tab right (internally to app - not OS)
[x] toggleSuggestionDetail (control+spacebar)

Any other suggestion?

find all references
peek definition
close all windows
close others
snap window left (internally to app - not OS)
snap window right (internally to app - not OS)

Trigger intellisense manually, useful for knowing CSS property has what values.
Right now the shortcut key is control+spacebar

Just published an update adding quite a few extra tools.
I hope you enjoy it.
Again, open for suggestions for features (or perhaps, better symbols to use as icons)

Odd, I don't see the update in VSCode

hm, odd it is!
Even if you go to the list of installed extensions? There should be a button for you to look for updates there.
When you look for the extension, do you see the updated readme file with a few extra screenshots?

Is it easy enough to add these two options?

snap tab left (internally to app - not OS)
snap tab right (internally to app - not OS)

Sure, why not.
But I'm not sure what are those!
I thought those where "increase/decrease indentation".
In the list here:
https://code.visualstudio.com/docs/getstarted/keybindings#_when-clause-contexts
Which one is what you are looking for?

I don't know if there is a shortcut for it - it's when you drag a tab to
the left or right and it fills half the window, like windows does with
window snapping, but inside the app itself.
On Mon, Nov 13, 2017 at 10:06 PM, Felipe Nascimento de Moura <
<EMAIL_ADDRESS>wrote:

Sure, why not.
But I'm not sure what are those!
I thought those where "increase/decrease indentation".
In the list here:
https://code.visualstudio.com/docs/getstarted/keybindings#_
when-clause-contexts
Which one is what you are looking for?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/NascHQ/nasc-vscode-mac-touchbar/issues/2#issuecomment-344074974,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANnlXt-J_atQdiQZ8N9pObW_XQaSRjrsks5s2L2BgaJpZM4QNboq
.

hm, interesting.
I think that is the "split editor", isn't it?
I'm guessing these would be the options you are looking for!
You want to make it happen and open a PR?
If not, I might have time to implement it next weekend.

Yep those look like the ones.  Again, I have no time outside of my projects
sorry, all yours! Loving your work :)
On Mon, Nov 13, 2017 at 10:22 PM, Felipe Nascimento de Moura <
<EMAIL_ADDRESS>wrote:

hm, interesting.
I think that is the "split editor", isn't it?
I'm guessing these would be the options you are looking for!
You want to make it happen and open a PR?
If not, I might have time to implement it next weekend.
[image: screen shot 2017-11-13 at 20 20 39]
https://user-images.githubusercontent.com/347387/32752405-31df1e14-c8b0-11e7-8247-79a94bca1bf9.png
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/NascHQ/nasc-vscode-mac-touchbar/issues/2#issuecomment-344078975,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANnlXkI4z0LRZ6dD4jv1vZ6P_m5_wSjfks5s2MEjgaJpZM4QNboq
.

I would like to create buttons that just insert some text, e.g. "def". On a german keyboard I have to press option-5 for a [ which is not convenient, so I would also like to have a button for brackets etc.

hm, interesting...we could think of a button that could add whatever you want, so you could configure it in the settings...would that help?

Actually some hours later I've found BetterTouchTool which exactly provides this feature, sending arbitrary keystrokes with configurable button images. However, it is not context sensitive, so e.g. in my PyCharm setup I have always the debug buttons (step etc.) on the Touch Bar. Here my current setup:

Interesting @OliverUrbann and what plugin is that? We might get some inspiration from it (specially if it is open source).

It's not open source and it is not a plugin. It is a general tool for customizing gestures, touch bar etc. in every app.

I see.
Ok, let's see if we can add this feature here, so developers will have their custom controls contextualized to VSCode.

VSCode reload button( linters/git/jest freeze sometimes) would be nice to have

Run Selection (F8) would be really useful

Would be cool to add support for Git push/pull button

Interesting, you mean "run selected text in terminal"?

Yes and no. Selfishly, I want Powershell.RunSelection but the command for other languages is workbench.action.terminal.runSelectedText I created a fork  to try and add it myself but this is my first extension so it's a bit of trial & error at the moment. Watch this space!

Organise imports and code auto formatting would also be useful

Yes and no. Selfishly, I want Powershell.RunSelection but the command for other languages is workbench.action.terminal.runSelectedText I created a fork  to try and add it myself but this is my first extension so it's a bit of trial & error at the moment. Watch this space!

Did you get it working, @benny-gold ?

+1 on find all references option, the key combo Option+Shift(+Fn)+F12 is kinda awkward.


The localized strings 'Collapse All' and 'Refresh All' overlap if narrowing the EXPLORER panel

Storage Explorer Version: 1.24.0-dev
Build Number: 20220303.1
Branch: main
Platform/OS: Windows 10/Linux Ubuntu 20.04/MacOS Monterey 12.1 (Apple M1 Pro)
Reproduce Languages: Russian/Portuguese/Polish/Dutch/Japanese/Italian/Hungarian/French/Spanish/German/Czech
Architecture: ia32/x64
How Found: exploratory testing
Regression From: Not a regression
Steps to Reproduce

Launch Storage Explorer -> Open 'Settings' -> 'Application -> Regional Settings'.
Select 'Español' -> Restart Storage Explorer.
Switch to 'EXPLORER' panel -> Narrow the EXPLORER panel.
Check the localized strings 'Collapse All' and 'Refresh All' do not overlap.

Expected Experience
The localized strings 'Collapse All' and 'Refresh All' do not overlap.

Actual Experience
The localized strings 'Collapse All' and 'Refresh All' overlap.

Additional Context
This issue doesn't reproduce on zh-CN/zh-TW/Korean/Swedish/Turkish.

Fixed on main

Verified this issue on the build main 20230307.6. Fixed.


Checklist 2020.02

Here are the new documentable changes for the new release
Changes:

[x] throws-like sub from Test module now throws an exception on
Bool:D matchers -f4ad0c2e-50f084d8-5696dbd1
[x] RAKUDOLIB environment variable now mentioned in --help -f9b7de22
[x] Supply.repeated now has unique rather than squish semantics -05213315

Additions:

[x] Enable user-defined chaining operators to work -d027ee0c
[x] Added prefix and suffix methods to Parameter class which return
textual prefix and suffix of the parameter -bd68955b
[x] Made an improperly typed default for an attribute a compile time error
-d8e859d0-05b5f81b-a8bb85a0-b6fa5f5d-13c9da97-4c0761a5-c592b80e
[x] Added SetHash.set and SetHash.unset methods -6df78ca3
[x] Added BagHash.add and BagHash.remove methods -c1b8ff60
[x] Str.contains now also can take a Regex -c3c5dae1
[x] Add :i(ignorecase) and :m(ignoremark) support to
index, starts-with, ends-with, contains, substr-eq, indices
-49aaa6ff-60b0d86a-84987742-0b2236a1-d91c773a-2e3c091c-46ef7f48
-9f710029-19576d6c-90fc61bb-ec13c3d0-ea44c194-327c74a6-73c5a25e
-d49a418e-5a716a39-7cb04813-0761a882-b140d7a9-c2e608b2-a6acfd0a
-aefc851b-597288be-b32048df
[x] The IterationBuffer class now has a Seq method -c87f5df9
[x] The Compiler class now has a backend method -61b416ed
[x] The Match class now has a replace-with method
-b43c839a-1ac3c5c0-7f3e852f-cd4ab4f3-930e5182
-488feafc-b4e00120
[x] Cool.subst doesn't need a replacement string anymore -dfb563af
[x] Supply.first now also works without a matcher -57dbc358
[x] Properly show enums, subsets and routine return type in Pod::To::Text output
-f60d9694-91f89435-0b0a1aad
[x] Added iterator implementation for Junction (fixes e.g. calling ^name on a Junction) -bceaeb1a

All items checked, closing. @lizmat++


SSL accept hang with badly behaved connections

Detail in this Kitura issue: https://github.com/IBM-Swift/Kitura/issues/1143
An incoming connection that establishes a TCP session but then sends no data will block the server from accepting connections indefinitely.
Steps to recreate:

Start the server, make some SSL requests (demonstrate it is functional)
Connect a rogue client, eg: telnet localhost 8443 and leave it doing nothing
Try to make further requests. The server appears to be unresponsive

The problem seems to be that SSL_accept blocks, expecting to read the start of an SSL handshake from the client, which will never time out or allow the server to continue accepting connections.  In the Kitura issue above, we block here:
https://github.com/IBM-Swift/BlueSSLService/blob/335495c857b7062ecf7e228d8e021d0f7d51c5c9/Sources/SSLService.swift#L493

SSL handshake can be potentially an expensive operation with default timeouts in tenths of seconds so doing SSL_accept should never block the main Kitura loop from accepting new connections. Otherwise the server will be still susceptible to simple DoS attacks.
Traditional accept, fork, read semantics with limited number of worker threads or fork-ed processes should do the trick.

This issue is more related to the use of BlueSSLService than to BlueSSLService itself.  BlueSSLService and BlueSocket are lower level functions.  The comment by @mman hits the nail on the head.  Adding a threading model at this level introduces, IMHO, potential side effects.  That should be handled at the application level.

@billabt Just to clarify: what exactly do you mean by should be handled at the application level? What is the application here? Kitura module? Or the application that is using Kitura module inside? or Kitura-Net module?

To paraphrase my comments in https://github.com/IBM-Swift/Kitura-net/pull/218, the issue here is that the basic TCP accept done within Socket.acceptClientConnection() and the delegate.onAccept() that it may call are two different levels, with the latter possibly blocking.
In our case, we have a single thread that repeatedly calls Socket.acceptClientConnection(), which in turn calls self.delegate?.onAccept(socket), and in the SSL case, calls SSL_accept(sslConnect) which can block.
What seems to be needed here is a decoupling of the 'Is there a connection to accept?' step from the protocol initiation step.  Kitura could continue with step 1 in a loop, but perform step 2 (which may block) on another thread (if it chooses).  I don't see how we can add a threading model around the current design.

The typical usage is as follows:
	try listener.listen(on: Int(port), maxBacklogSize: 10)

	print("Listening on port: \(port)")

	socket = try listener.acceptClientConnection()

	print("Accepted connection from: \(socket.remoteHostname) on port \(socket.remotePort), Secure? \(socket.signature!.isSecure)")

After the call to listen returns, indicating a new connection is pending, you can start a new thread to accept the new connection…  Then return to listening again.  This will avoid tying up the main listening thread and the resultant application hang should the SSL negotiations fail or take too long…

@billabt It was my understanding that listen returns immediately, having put the socket into listening mode (ie. a server socket),  and that calling accept was the way to block until a connection was received:  https://www.gnu.org/software/libc/manual/html_node/Listening.html

@djones6: You're right...  The proper sequence would be as follows:

Step 1: call listen on the socket.
Step 2: now call listenerSocket.isReadableOrWritable(waitForever: true) to wait for a connect attempt.  Note: This call also supports a second parameter, timeout, expressed in msec.  See the API doc for the function for more info.
Step 3: when the call returns, launch a new thread that will do the acceptClientConnection.
Step 4: then go back and repeat Steps 2 & 3 to wait for additional connections.

@billabt This doesn't seem to work either.  isReadableOrWritable(waitForever: true) throws SOCKET_ERR_NOT_CONNECTED when I call it on the listenerSocket.

@djones6:  I'll have to make some changes to get this to work this way. Reopening this issue.

@billabt I have a working solution for this in IBM-Swift/BlueSocket#85 and IBM-Swift/Kitura-net#219

@djones6:  I'll take a look at your PR. I'd like to avoid adding the new API if possible. What happens if the app never invokes the new API? The delegate will never be called.

That's true, however in order to avoid invoking the delegate the app must supply the optional parameter invokeDelegate: false.  That puts the onus on the application to ensure it does call the delegate, which IMHO is perfectly reasonable.

@djones6: True, that's a reasonable assumption.  If we accept this PR, I'll have to bump the MINOR version number since the API changed.  Does that present a problem for Kitura?

@djones6:  I'm going to accept the PR as soon as CI finishes but I've got to make some changes.  As it stands right now, the invokeDelegateOnAccept method doesn't protect against being called multiple times or with the wrong socket.  I've also got to update the README to take into account the new parameter and the new API.

Fixed in v0.12.66 of BlueSocket.


Complete declarations for CPython’s Context Variables API

Continuation of #3137. This provides declarations for the CPython Context Variables API, as a contextvars.pxd file. This also addresses comments made in the previous stale PR.
Closes #2281
cc @scoder

@scoder  is there anything specific I still need to do on this PR? I augmented the previous stale PR based on your recommendations


Remove .pkgignore file

@beorn7

:+1:
Apparently, @discordianfish tried to run Prometheus on Bazooka back in 2013... :)

@beorn7 I did indeed. Wow 2013.. if we just had released it back then...

@discordianfish Who knows, maybe it would have totally flopped. I mean, it was barely working back then... in any case, we seem to be doing fine :)

@juliusv I was referring to bazooka, the prometheus release/announcement happened at exactly the right time IMO :)

@discordianfish Ah ok :)


Indentation Issue - MD007/ul-indent

Issue
Notice from VS Code - Markdown Lint (davidanson.vscode-markdownlint)
MD007/ul-indent: Unordered list indentation [Expected: 2; Actual: 4]
https://github.com/DavidAnson/markdownlint/blob/v0.11.0/doc/Rules.md#md007
Example
<!-- TOC -->

- [Generate SSH Key for SFTP Use](#generate-ssh-key-for-sftp-use)
    - [Table of Contents](#table-of-contents)
    - [References](#references)

Currently TOC uses 4 spaces for each indentation for the Unordered TOC list, instead of the standard 2 spaces.
Code
https://github.com/AlanWalk/markdown-toc/blob/1fc815ec26d063b38502932641a80497fbf71f24/src/extension.ts#L268
editor.tabSize is defaulted to 4.
Workaround
Create .markdownlint.json in project root per project. 😞
{
    "MD007": { "indent": 4 }
}

Please let me know if I've overlooked a setting or if you are aware of a better solution.
I've researched https://github.com/neilsustc/vscode-markdown/issues/155

The extension is using exactly what you've in the settings (Editor: Tab Size). If you set it to 2, then the plugin will regenerate TOC with indention of 2 spaces. So this could be the issue with markdownlint.


Performance: find_many needs hook to map docs before deserialize

This is per elasticsearch-persistence.
Imagine you are grabbing ID's from search results, and using those ID's to do a (costly) fetch the full record set from the main store (i.e. SQL, remote, etc.). The fetch should be done in one query with a list of ID's, then those results mapped via deserialize.
I'm thinking either an overridable method or option for find that would map result document set into another array that would then be mapped via deserialize in __find_many.
Thoughts?

@aceofspades Sorry for missing your question for so long -- if it's still relevant, can you please be more concrete, preferably with a code example or sketch?

Basically I'm suggesting the __find_many should have the mapping from results into documents extracted, so it can be overridden, i.e. (no functional changes here)
def __find_many(ids, options={})
  type     = document_type || (klass ? __get_type_from_class(klass) : '_all')
  documents = client.mget( { index: index_name, type: type, body: { ids: ids } }.merge(options) )
  deserialize_many(documents['docs'])
end

def deserialize_many(documents)
  documents.map { |document| document['found'] ? deserialize(document) : nil }
end

Imagine you have a search index that maps terms into ids for ActiveRecord objects. Now it's possible to override deserialize_many to load the resulting ActiveRecord objects in one query with something like:
def deserialize_many(documents)
  ids = documents.compact.map { |d| d['_source']['_id'] }
  MyModel.find(ids)
end

@aceofspades I'd like to revive this discussion. I'm a fan of extracting features to allow overloading, but I'm a bit confused how ActiveRecord comes here to the mix, when the dicussed feature is about elasticsearch-persistence gem?

@karmi ActiveRecord is my use-case. I'd just like to extract the mapping of result documents into their deserialized form into its own method. In my case the result documents are just record ID's, which I would then extend/override deserialize_many to do a fetch from my SQL data store.

@aceofspades But how are you using elasticsearch-persistence with ActiveRecord? Why not the elasticsearch-model which is for ActiveModel/ActiveRecord integration?

@karmi I'm using a domain driven architecture that is based on ActiveRecord, but at a higher level. So I need to hook in to map search results into DB fetches to handle custom logic.
Any reason you'd hesitate extracting the mapping?

Closing this issue as it is out-of-date.


Joint projects

Hello! After I never followed up on #5, I felt kind of bad. This project was really interesting for me, but I couldn't figure out a way to generate the CSS in a pythonic manner. Beyond that, the project seemed dead so I wasn't sure if it would be worth it.
While figuring this all out, I learned a lot about how bookmarklets worked and Replit's design system. 2 days ago, I was determined to share this knowledge. There weren't any good Python tools for this process, so I instead created a framework for developing the styling with Sass. I also wanted some general guides and references for people who also wanted to create these designs.
Thus I created Replit Theming, a website hosting a collection of resources for Replit UI design. This would have a step-by-step guide to theme design, how I create themes, and maybe a few examples.
However, I realized yesterday that you picked up the project again.
...
Yeah, I created the Sass project thinking that it would be an alternative to Reflux that was easier and more extensible. (I don't mean to be rude, but the API for 0.2.0 wasn't the most pythonic or easy to use.) Anyways, I now have a predicament. Do I drop the project or do I continue it on? Reflux is back in action, so being the alternative wouldn't work.
My decision was to put more effort into the website since that would still be helpful. This was my plan until a few hours ago, where I thought: What if we worked together on all three?
We create a Github org where these three projects can live together in harmony. You can contribute to the website if you want, and I possibly can suggest some features and bug fixes.
I completely understand if you don't want to do this, I just feel like the projects are too similar to be kept apart.
Thank you,
-BD103

Oh thanks so much for your interest in contributing, what you've done so far great! I don't really have any plans to make a GitHub Org for Reflux, or open the project to multiple maintainers (the most I have is a Replit team for the nice URL) but I'd be more than happy to link your website in the docs once it's in a good place. I did look at it the other day and it's honestly a great resource.
Thanks!

If it's of any interest, the next major step is to create a Chrome extension for Reflux, since bookmarklets are tedious and annoying. Bookmarklets are the current focus of Reflux because a good portion of Replit's users (and me) use it a lot in a school environment, where extensions and Web Inspect are blocked, so bookmarklets are the only option.

Got it. I know I little bit about Chrome extensions, so I'll start there.

I realize that there are a ton of Chrome extensions that already exist, so maybe you should just make a guide on using one of those.

Hi there! I'm Snow, another collaborator on this project.
All chrome extensions already out there are css injectors, where you give it specific css code to inject (...hence the name). That isn't very user friendly, so we plan to make our own extension where we let the user specify colors, and do the rest for them! I'm not sure if frissyn has planned this or not, but we might also integrate our marketplace (currently a WIP),  where users can share their theme with others and explore other themes.

Interesting. I don't know enough about the marketplace and API to do that kind of thing. This probably is something only you or Frissyn could do.

I do plan on making custom extension, I just haven't found any time because I've been swamped with schoolwork and other obligations.


Enhancement / Print “accessing as ” in client

notion ticket: https://www.notion.so/dagshub/Print-accessing-as-user-in-client-92af32ddfce2477ba7184722634fb891?pvs=4

@kbolashev i have implemented initial version which works fine, but isn't efficient:
it will make another http request to get the username from the token.
in cases where we call is_valid_token(), this new http request can be skipped.
so we have 2 options, leave it as is, or make required adjustments to skip the redundant http call.
in order to achieve the 2nd option, i thought about:

adding username to __token_cache
maintain existing caches to support backwards compatibility (adding username to already existing tokens)

this will require more complicated logic, and i'm not sure the scope of this task covers that.
WDYT?

I think you can change the signature and name of is_valid_token to return the username and get 99% of the way there.
You'll only have to call it for the case of the EnvVar token and that's it.


Query parameter to list endpoints newest-to-oldest

The overall pagination is still done first-to-last, but within a page results are listed last-to-first.
Builds on top of #812

I believe so. The again-generic apply_pagination and listing_response is only used for Endpoint listing, the remainders still use the direction specific variant (which I intend to remove once all have bidirectional listing).


Add support for histograms to micrometer

What does this PR do?
Add support for reporting histograms from micrometer metrics
Checklist

[x] This is an enhancement of existing features, or a new feature in existing plugins

[ ] I have updated CHANGELOG.asciidoc
[x] I have added tests that prove my fix is effective or that my feature works
[ ] Added an API method or config option? Document in which version this will be introduced
[ ] I have made corresponding changes to the documentation

[ ] This is a bugfix

[ ] I have updated CHANGELOG.asciidoc
[ ] I have added tests that would fail without this fix

[ ] This is a new plugin

[ ] I have updated CHANGELOG.asciidoc
[ ] My code follows the style guidelines of this project
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] I have updated supported-technologies.asciidoc
[ ] Added an API method or config option? Document in which version this will be introduced
[ ] Added an instrumentation plugin? Describe how you made sure that old, non-supported versions are not instrumented by accident.

[ ] This is something else

[ ] I have updated CHANGELOG.asciidoc

:broken_heart: Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-11-30T22:53:21.162+0000

Duration: 39 min 14 sec

Test stats :test_tube:

Test
Results

Failed
3

Passed
2886

Skipped
33

Total
2922

Test errors
Expand to view the tests failures
Builds / Tests / Non-Application Server integration tests / testTransactionPerMessage_noDistributedTracing – co.elastic.apm.agent.rabbitmq.SpringAmqpBatchIT

Expand to view the error details
 Condition not fulfilled within 1000 ms

Expand to view the stacktrace
 java.lang.RuntimeException: Condition not fulfilled within 1000 ms
	at co.elastic.apm.agent.rabbitmq.SpringAmqpBatchIT.testTransactionPerMessage_noDistributedTracing(SpringAmqpBatchIT.java:61)
Caused by: org.opentest4j.AssertionFailedError:
[expecting 4 transactions, transactions = []]
expected: 4
 but was: 0
	at co.elastic.apm.agent.rabbitmq.SpringAmqpBatchIT.testTransactionPerMessage_noDistributedTracing(SpringAmqpBatchIT.java:61)

Builds / Tests / Non-Application Server integration tests / testTransactionPerMessage_withDistributedTracing – co.elastic.apm.agent.rabbitmq.SpringAmqpBatchIT

Expand to view the error details
 Multiple Failures (2 failures)
 org.opentest4j.AssertionFailedError:
expected: "fff4bda72748aefd069b083ea183bc33"
 but was: "6d68c7501c92df750ea72f6cc62c4ee6"
 java.lang.IllegalStateException: trying to recycle object that has not been taken from this pool or has already been returned 'Spring AMQP RECEIVE from <default>' 00-6f77e6259a812934caad3c927720f221-0f6b4d9f6745bcd0-01 (3fe3a6b1)

Expand to view the stacktrace
 org.opentest4j.MultipleFailuresError:
Multiple Failures (2 failures)
	org.opentest4j.AssertionFailedError:
expected: "fff4bda72748aefd069b083ea183bc33"
 but was: "6d68c7501c92df750ea72f6cc62c4ee6"
	java.lang.IllegalStateException: trying to recycle object that has not been taken from this pool or has already been returned 'Spring AMQP RECEIVE from <default>' 00-6f77e6259a812934caad3c927720f221-0f6b4d9f6745bcd0-01 (3fe3a6b1)

Builds / Tests / Non-Application Server integration tests / testTransactionPerBatch – co.elastic.apm.agent.rabbitmq.SpringAmqpBatchIT

Expand to view the error details
 Multiple Failures (2 failures)
 org.opentest4j.AssertionFailedError:
expected: 6
 but was: 10
 org.opentest4j.AssertionFailedError: [nothing should be left active at end of test, failure will likely indicate a span/transaction still active]
expected: null
 but was: '' 00-1dd88b88dfcc27cae42e5c5b06aea3c8-bc56922667bd7c60-01 (49f6297f)

Expand to view the stacktrace
 org.opentest4j.MultipleFailuresError:
Multiple Failures (2 failures)
	org.opentest4j.AssertionFailedError:
expected: 6
 but was: 10
	org.opentest4j.AssertionFailedError: [nothing should be left active at end of test, failure will likely indicate a span/transaction still active]
expected: null
 but was: '' 00-1dd88b88dfcc27cae42e5c5b06aea3c8-bc56922667bd7c60-01 (49f6297f)

Steps errors
Expand to view the steps failures

Shell Script

Took 21 min 27 sec . View more details here
Description: ./mvnw -q -P ci-non-application-server-integration-tests verify

:bug: Flaky test report
:grey_exclamation: There are test failures but not known flaky tests.
:robot: GitHub comments
Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

run benchmark tests : Run the benchmark tests.

run jdk compatibility tests : Run the JDK Compatibility tests.

run integration tests : Run the Agent Integration tests.

run end-to-end tests : Run the APM-ITs.

run windows tests : Build & tests on windows.

run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)


HTML on article pane

https://medium.com/feed/@hodlhodl

The HTML stripper doesn’t deal with text that appears between style tags. (It’s a very basic HTML stripper.)

See NSString+RSCore.m, rs_stringByStrippingHTML:.
It should strip everything between style and script tags.

Fixed in c5cf11e4b755735b5019cb078db5cb540cb46b65


Can we add swipe action in cards?

I think it will be good if have swipe action in cards

OK, I`ll take this into consideration, thanks a lot

What is the minimum sdk for this?

9


edits to optimization_solver_packages.rst

Could the exercise instead just be a comment at the bottom?

Hey @natashawatkins

I agree, the exercise should be a comment, so I made it an "additional notes." We should put in some concrete exercises though on the use of the packages (e.g., "optimize X function using Y package...", or "implement this optimization problem with these constraints in this package...") I'll talk to @jlperla about it.

Done.


[FEA] Explore pausing/retry of operations before spilling to disk

*Is your feature request related to a problem? Please describe.
Spilling to disk is much more expensive than spilling to host memory. It would be really interesting to see what the impact to performance would be if we could tell that the processing was currently in a retry block and instead of spilling to disk we threw a retry exception instead.
This would require a lot of rework for both the spill code and for the state machine, but it might have a big performance impact on jobs that need a lot of memory.

Spilling to disk is done to keep the host store at a specific target size. So when the host store is full, this pauses host spills as well.
The RapidsBufferCatalog triggers the spill to disk here https://github.com/NVIDIA/spark-rapids/blob/branch-23.06/sql-plugin/src/main/scala/com/nvidia/spark/rapids/RapidsBufferCatalog.scala#L527, for the host store (the only store that has a maximum size as of today).
So I think instead of spilling (and after detecting that we are with RmmRapidsRetryIterator, so we need to set some sort of thread local state here), we would need to throw a special exception instead of spilling to disk, such that the JNI adapter could handle it and keep state for this thread that has "wanted to spill to disk N times". The onAllocFailure callback in DeviceMemoryEventHandler would need to get back some state from the state machine saying that it already paused this thread due to a prior disk spill attempt, and this time it means it so it should let it through.

Just a few notes about this. This is not supposed to produce production level code.  We have a lot of tech debt to pay off first in the spill framework before we get to putting this into production. I would love to have you do some experiments to see if this even makes since to go this route. If it does, then we can go back and figure out a long term plan to make it happen cleanly. When putting together changes for the experiments you don't have to worry about the UCX shuffle for the state machine, and you can hack up the spill code just to make something work so we can get an idea of what the performance might look like. You also don't have to worry about GPU Direct Storage for the spill code.
The current code will do the following to avoid an OOM

Spill to host memory
Spill to disk
pause the current thread
throw retry exception on lowest priority thread
throw split and retry exception

We want to change the order of these so that the priority is

Spill to host memory
pause the current thread
throw retry exception on lowest priority thread
spill to disk
throw split and retry exception

To do this I think the big change would have to be that the spill callback code would have to move to the state machine in Spark Rapids JNI. We would also have to provide an API to the callback that lets the spill code know if it is allowed to spill all the way to disk, or just spill to host memory. Then the state machine when an allocation fails it would first call the spill code saying spill only to host memory. If that succeeds and some memory is spilled/freed, then we retry the allocation, if nothing was freed then we got through the pause code like we do today. Exception if all of the threads are paused instead of throwing an SplitAndRetryOOM we try to spill again, this time we allow it to spill to disk. If that works, then we can go on (retry the allocation). If it does not work, then we throw the SplitAndRetryOOM.
For testing I really would like to see the performance of running a query that would normally spill to disk before and after the patch. I think we can do a lot of this with NDS queries and adjusting the maximum memory that the GPU has access to. The config spark.rapids.memory.gpu.allocSize is intended to only be used with testing, and it should give you a good approximation of running on a GPU with much lower memory than it actually has. The idea is that it is probably cheaper to pause a thread, and drop parallelism than it is to spill to disk.  But the way our operators work, and how they use memory does not make it super clear if that is true all the time. Especially with really fast disks. So because of that I would love to see the impact of testing this on an on prem cluster with fast disks, but I would also love to see it run on some other cloud where we know that the disk speeds are relatively slow (or at least are slow by default without adding NVMe store to them).

Figured out a way to do the POC things. Here are the two relevant changes in my personal repos.
https://github.com/firestarman/spark-rapids-jni/pull/1/files
https://github.com/firestarman/spark-rapids/pull/6/files
Will run the perf tests next.

So far I have tried the meituan case where the spilling indeed happened on spark2a, but did not get any perf improvement.
What's more, I got some OOM errors when running with the two PRs. Will investgate more.

Pls correct me if wrong.
In theory, if the new pipeline wants to get better performance, we may need to have a good runtime data size that can be all held by the host memory store, which can avoid the disk writing during the spilling process to run faster. Otherwise, disk writing is still necessary in the new pipeline.
For most cases, seems it is impossible to have such good data size during runtime, then we may not get better performance.

@firestarman The experiment where there is lots of spilling is informative.  I was hoping that there would be a reduction in the total data spilled to disk, and hence a reduction in the runtime of the query.
I think we want to start out with some kind of a synthetic load.  We know that it should have no impact on performance if there is no spill at all, but I think we can come up with a few interesting situations to see what happens.
I would like to see times for running NDS (just because it is a good synthetic load).  Then we can start to adjust spark.rapids.memory.gpu.allocSize to artificially reduce the GPUs memory to induce a spill and also adjust spark.rapids.memory.pinnedPool.size and spark.rapids.memory.host.spillStorageSize to see what the impact would be. We should keep the concurrency at a set amount, ideally 4 so there are multiple threads to pause, but 2 works too.
I would love to see what the total gpuSpillBlockTime, gpuSpillReadTime, gpuSemaphoreWait, gpuRetryBlockTime, gpuRetryCount, and gpuSplitAndRetryCount in addition to the total run time, memory spill and disk spill for different settings. The first set of tests would be a baseline to measure the impact of spilling to memory on the runtime of the NDS. We start with setting where there is no spilling because everything fits in GPU memory.  Then we reduce the GPU memory and increase the host spill storage size at varying amounts keeping the total memory available for storage the same. The amount of memory for the GPU should not get below 4 to 6 GiB, just because I to be sure there is enough memory for a single task to execute on the GPU without any issues. We should try this with both your patch and the baseline jar. Because there would be no spill to disk there should be no retries happen, no OOM errors or anything like that. Just a clean curve that should ideally be the same for both jars.
Next we can take one of the situations where there is a decent amount of spilling to host memory, and start to reduce the amount of host memory available. My hope is that there is a rather wide range in which we can avoid spilling to disk by pausing some threads and in those cases the overall runtime will be faster. After that we can start to look at the data and decide on next steps.
It really comes down to a few different things. If pausing and retrying computation is more expensive than spilling to disk, then we have the order of operations correct. If spilling to disk is more expensive that pausing/retrying computation, then we should look at shifting the order of operations around. Or there is inherently something else that is happening that we are blocked on when running out of memory that we don't totally understand yet.  I hope that the metrics collected will help us understand which outcome it is.
Also these may be different for different environments.  a PCIe gen3 card in a setup with a really complicated PCIe switch structure (like many cloud service providers on a T4) and possibly slow disks will likely behave very differently compared to a V100 on PCIe gen4 with dedicated lanes directly to the CPU and very fast NVMe storage also directly connected to the CPU.  OR even a Grace Hopper setup where we have something close to a TiB/s of bandwidth between the CPU and GPU for spilling.
So we might want to explore a few different setups.

Hi @revans2, shall we move it to 23.12 ?
Seems there is a lot of testing work to do, so I probably can not make it for 23.08.


Refine InputColumn creation

Codecov Report

Merging #5347 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #5347      +/-   ##
============================================
+ Coverage     82.22%   82.26%   +0.04%
- Complexity    10979    10986       +7
============================================
  Files          1330     1330
  Lines         43419    43413       -6
  Branches       5478     5476       -2
============================================
+ Hits          35702    35715      +13
+ Misses         5148     5141       -7
+ Partials       2569     2557      -12

Impacted Files
Coverage Δ
Complexity Δ

...ecutor/transport/task/elasticsearch/ESGetTask.java
85.06% <100%> (ø)
13 <0> (ø)
:arrow_down:

...main/java/io/crate/analyze/symbol/InputColumn.java
80.48% <100%> (-1.74%)
17 <2> (-2)

...e/analyze/InsertFromSubQueryAnalyzedStatement.java
91.25% <100%> (ø)
25 <0> (ø)
:arrow_down:

.../planner/projection/builder/ProjectionBuilder.java
79.31% <100%> (-1.02%)
17 <5> (ø)

.../io/crate/planner/consumer/NestedLoopConsumer.java
91.9% <100%> (-0.05%)
6 <0> (ø)

...crate/planner/projection/builder/InputColumns.java
94.44% <100%> (ø)
11 <4> (?)

...arch/indices/recovery/BlobStartPrefixResponse.java
66.66% <0%> (-33.34%)
3% <0%> (-2%)

...o/crate/analyze/SafeExpressionToStringVisitor.java
83.33% <0%> (-16.67%)
7% <0%> (-1%)

...rc/main/java/io/crate/analyze/UnboundAnalyzer.java
85% <0%> (-15%)
2% <0%> (ø)

core/src/main/java/io/crate/types/ArrayType.java
73.84% <0%> (-7.7%)
24% <0%> (-2%)

... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a01f858...abcbecb. Read the comment docs.


Fake Transparency shows the new and the old pie.

When I'm using the menu pie and I open a secundary pie (like the Preferences pie, or Acessories pie, Games pie), visually the original pie doesn't disapear. This happens on Lubuntu 11.04 and Lubuntu 11.10.
A possible solution would be to add an option to delay by 0,5 second the opening of the second pie. This would give time to the first pie disapear and the Gnome Pie use again the background to create de fake transparency.
Here are some images of this bug:
http://img28.imageshack.us/img28/3756/gnomepiefaketransparenc.jpg
http://img249.imageshack.us/img249/3756/gnomepiefaketransparenc.jpg
http://img257.imageshack.us/img257/3756/gnomepiefaketransparenc.jpg

You're right. I'll check what can be done.
Thanks for the report!

Hi again. I thought another possible solution for this bug. I don't have the knowledge to create a patch for this, but maybe this will help to bring a solution. To be easy to understand, I created a .otp to explain.
..
http://www.4shared.com/file/RiE1Uron/Fake_Transparency_-_Possible_S.html

Hey, that's a really cool idea. I'll implement this --- it should be possible. Thanks for the input! It's way better than the delay option!
Thanks a lot!

Lol... this was easier than I thought... You can checkout the master branch in order to test it!


travis: update test matrix

@brentp Please take a look.
Fixes #46.

This is ready now. The failure is due to a change in gofmt behaviour. I have filed an issue for this https://github.com/golang/go/issues/18782.

LGTM


Wait for pending tests

Fixes #63, related to #15.
Changes
Before test .run(), timer with maximum possible value is started to keep the process alive. When the test is finished, clearTimeout() removes the timeout.
Fixed cases
Now, the following tests won't just produce empty output:
test('empty test', function (t) {

});

test('no assertions', function (t) {
  t.plan(1);
});

Can you reenable thsi test: https://github.com/sindresorhus/ava/blob/5dc0873b74d59a3f3cc33a36020c78cb305153aa/test/test.js#L262 and add some more?

https://github.com/sindresorhus/ava/blob/5dc0873b74d59a3f3cc33a36020c78cb305153aa/test/test.js#L262 this test is not related to this PR (this PR won't fix this problem).

:+1: :tada:


Array indexes ?

would it be possible to access array indexes ?
if i want to do something like that for example :
 for i in 0..#first.len() {
     vec.push(format!(#fmt,#ast[i]));
 }

also ast's defined like this :
let parser = Punctuated::<syn::Expr, syn::Token![,]>::parse_separated_nonempty;
let ast = parser.parse(input).unwrap();

within a quote, as of right now, it doesn't do the desired behavior.
any idea ?
also calling fuctions like #ast.len(), wouldn't give the lenght for each expression if they are strings for example, but it'll give each expression, then the lenght of the last one.

I would prefer not to support this proposal in this crate.

Hey, i'm fine with this, however how would you go about doing it at all then ?
do you have an idea how you would manually do it ?


Can I use yolo with Realsense camera?

Before opening a new issue, we wanted to provide you with some useful suggestions (Click "Preview" above for a better view):

Consider checking out SDK examples.
Have you looked in our documentations?
Is you question a frequently asked one?
Try searching our GitHub Issues (open and closed) for a similar issue.

All users are welcomed to report bugs, ask questions, suggest or request enhancements and generally feel free to open new issue, even if they haven't followed any of the suggestions above :)

Required Info

Camera Model
{ R200 / F200 / SR300 / ZR300 / D400 }

Firmware Version
(Open RealSense Viewer --> Click info)

Operating System & Version
{Win (8.1/10) / Linux (Ubuntu 14/16/17) / MacOS

Kernel Version (Linux Only)
(e.g. 4.14.13)

Platform
PC/Raspberry Pi/ NVIDIA Jetson / etc..

SDK Version
{ legacy / 2.. }

Language
{C/C#/labview/nodejs/opencv/pcl/python/unity }

Segment
{Robot/Smartphone/VR/AR/others }

Issue Description
Is it possible to do  yolo v4 deepsort using an RGB camera and get the 3d coordinates of this tracked object?
I plan to use the D455 and L515 camera.

Hi @kimgw-pl   Using the D455 and L515 together in a multiple-camera arrangement would not be ideal if the cameras are going to be positioned so that their fields of view overlap, as infrared projection from the D455 could interfere with the L515's performance (as the L515 is sensitive to infrared).
YOLO can be used with RealSense cameras, yes.
An in-progress project using RealSense and YOLOv4 is highlighted on the Intel Devmesh website where developers showcase their projects.
https://devmesh.intel.com/projects/advanced-object-detection-using-yolov4
A project using YOLOv4 and RealSense D435i is described in the paper at the link below.
https://www.proquest.com/docview/2532449285
This case provides advice from a RealSense team member regarding a query about YOLOv4, L515 and darknet:
https://support.intelrealsense.com/hc/en-us/community/posts/1500001173762-How-do-i-find-real-world-dimensions-of-an-object-using-L515-camera-and-darknet-

You can research the subject further by googling for "realsense" "yolov4" (including the quotation marks so that the search looks only for those exact terms).

Hi @kimgw-pl  Do you require further assistance with this case, please?  Thanks!

Case closed due to no further comments received.


feat: Implement add-gateway-txn endpoint

Issue

Link: https://github.com/NebraLtd/hm-diag/issues/283
Summary:
Create API endpoints for add_gateway_txn.

How

Export gpg key at HPT side:
gpg --armor --output key-file-pub.gpg --export 0xBFBFA70B
Put exported key in  hm-diag. Update the key path constant accordingly(KEY_PATH = "./keys/key-file-pub.gpg").
Create /v1/add-gateway-txn POST API endpoint in  hm-diag.

Decrypt and validate the file payload using python-gnupg
Call miner RPC api by https://github.com/NebraLtd/hm-pyhelper/issues/91

Encrypt the client JSON file at HPT side. The following command will produce shipping_destination.json.asc file.
gpg -u 0xBFBFA70B --clearsign shipping_destination.json
Call /v1/add-gateway-txn REST API endpoint with POST method, file field=shipping_destination.json.asc
/v1/add-gateway-txn endpoint in hm-diag will create add-gateway-txn transaction and submit to the Helium blockchain. And it will return the response with a descriptive message and http status code(200/406)

Screenshots

References

Checklist

[ ] Tests added
[ ] Cleaned up commit history (rebase!)
[ ] Documentation added
[ ] Thought about variable and method names

@marvinmarnold Now, Kashif's test key is removed and this branch is rebased onto master and resolved a conflict with lte_diagnostic.py.

@kashifpk can you conduct another review?

@marvinmarnold - Sure, I'll run a couple of integration tests too.


Bench 185 issues

In addition to not having a media type for the photo (as mention in #307) the image for bench 185 doesn't load with viewed at https://openbenches.org/bench/185 or https://openbenches.org/edit/185 In both cases I get this URL for the image https://images.weserv.nl/?url=openbenches.org/image/2a49f2947efa3073268333252fc4aa6c9933053e/&w=600&q=60&output=webp&il   and it returns some JSON
{"status":"error","code":404,"message":"The requested URL returned error: 301"}
and HTTP status code 404.
Also I think it might be a dupe of https://openbenches.org/bench/186 or, perhaps one could argue that I inadvertently made it a dupe. I went to edit 185 and got an error so tried the next in the list at https://openbenches.org/admin/no-mediatypes, which was 186, noticed that the inscription text was missing some of what's in the photo so added it. Then when I went back to try 185 again I realised the text I'd added to 186 is the current text for 185. 186 is obviously one bench with two plaques but I think someone submitted as 185 with the text from one plaque then again as 186 with the text from the second plaque.

Looks like the CDN was having a glitch. The image is working now.
I think @jnicho02 added a separate entry for each separate plaque. Which was a sensible thing to do back in the early days when we didn't really know the shape of the project.
I've now merged them.


Fixed Example Mod

I fixed the modid problem and also found another problem which was that the .renderBanner() method was moved in 1.4.1 but I didn't change the class that it was calling from when updating to 1.4.1

Fixes #6 (hopefully)


feat: add isReadOnly prop and handle read-only state in switch component

📝 Description
The documentation has a ReadOnly option, but it is not really available.

https://zagjs.com/components/react/switch
🚀 New behavior
When set to ReadOnly, the value will not change.
However, unlike disabled, the input element is not "disabled".
💣 Is this a breaking change: No

Hi @nonoakij, I think it should be other way around instead. We should remove that section from the docs since we no longer support read only on checkboxes.
This is not supported by the native DOM hence the reason we removed it.

@segunadebayo Thanks for the reply.

We should remove that section from the docs since we no longer support read only on checkboxes.

I will close this pull request and create a new pull request to remove it from the docs


Elgrady az security microsoft.security sdk fix generation (track1)

Microsoft.Security SDK fixes
WIP, depends on PR: https://github.com/Azure/azure-rest-api-specs/pull/24938
This PR should be (hopefully) the last 'track1' SDK release before Microsoft.Security will be migrating to track2 SDKs.

@eliagrady The Track 1 SDK will no longer be supported in the near future. You can still modify the Track 1 code for Powershell purposes, but you cannot publish any Track 1 packages at this time.

@eliagrady The Track 1 SDK will no longer be supported in the near future. You can still modify the Track 1 code for Powershell purposes, but you cannot publish any Track 1 packages at this time.

Yes, we're interested in getting one last SDK release before the deadline for releasing Track1 SDK and shifting our focus towards Track2 - the Track1 SDK has not been updated for too long.

@eliagrady why did you mark this pr as Do Not Merge ?

@eliagrady Elia Grady FTE why did you mark this pr as Do Not Merge ?

I'm working on refactoring and completing a full sweep of tests to the APIs listed in this SDK - many tests are either missing, stale, incorrect or simply written in a synchronous manner. Once I cover all APIs with proper tests and the quality of it is sufficient I will remove the label and update the PR with tests and recorded sessions for the SDK to actually be usable and useful to customers to consume.
Until then - this is incomplete work.

@eliagrady This PR is still tagged as Do Not Merge. Is it completed now?

@eliagrady This PR is still tagged as Do Not Merge. Is it completed now?

Unfortunately we did not get clearance for releasing an update to our track1 SDK version.
We'll be working towards releasing a track2 SDK version instead.


Add MessagePack serialization support

Adds MessagePack support.
Going to start using this at work in the next few days, I'll make sure to do a PR if I make any other changes.
Thanks to @Vertygo for the MemoryPack implementation! 😄

Sorry I've been so slow on this one. It'll go out tomorrow as part of 0.9.17


fix: Fix the aws signature v4 computation with custom headers

tl;dr - Req library doesn't derive the aws v4 signature properly while using custom headers.
AWS signature v4 computation requires the canonical_headers to be alphabetically sorted - reference: https://docs.aws.amazon.com/IAM/latest/UserGuide/create-signed-request.html#create-canonical-request
Here is a detailed example:
defmodule ElixirHelloworldTest do
  use ExUnit.Case
  doctest ElixirHelloworld

  test "greets the world" do
    assert ElixirHelloworld.hello() == :world
    IO.puts(Req.new(
      aws_sigv4: [
        access_key_id: "<>",
        secret_access_key: "<>",
        region: "auto",
        service: :s3
      ],
      url: "https://silent-voice-3347.fly.storage.tigris.dev",
      params: %{
        "list-type" => "2"
      },
      headers: %{
      "X-Tigris-Query" => "`Content-Length` > 6"
      }
    )
    |> Req.run())
  end
end

As you can see there is a custom header being passed on here X-Tigris-Query. The canonical request formed for this request is
GET
/
list-type=2
accept-encoding:gzip
host:silent-voice-3347.fly.storage.tigris.dev
user-agent:req/0.5.1
x-tigris-query:`Content-Length` > 6
x-amz-content-sha256:<>
x-amz-date:20240625T065255Z

accept-encoding;host;user-agent;x-amz-content-sha256;x-amz-date;x-tigris-query
<>

Similarly for
defmodule ElixirHelloworldTest do
  use ExUnit.Case
  doctest ElixirHelloworld

  test "greets the world" do
    assert ElixirHelloworld.hello() == :world
    IO.puts(Req.new(
      aws_sigv4: [
        access_key_id: "<>",
        secret_access_key: "<>",
        region: "auto",
        service: :s3
      ],
      url: "https://silent-voice-3347.fly.storage.tigris.dev",
      params: %{
        "list-type" => "2"
      },
      headers: %{
      "X-Tigris-Query" => "`Content-Length` > 6",
      "A" => "test",
      "F" => "test",
      "C" => "test",
      "B" => "test"
      }
    )
    |> Req.run())
  end
end

canonical request is
GET
/
list-type=2
a:test
accept-encoding:gzip
b:test
c:test
f:test
host:silent-voice-3347.fly.storage.tigris.dev
user-agent:req/0.5.1
x-tigris-query:`Content-Length` > 6
x-amz-content-sha256:<>
x-amz-date:20240625T065427Z

a;accept-encoding;b;c;f;host;user-agent;x-amz-content-sha256;x-amz-date;x-tigris-query
<>

x-tigris-query doesn't fit in sorted headers. This causes the incorrect signature calculation and gets rejected on server.
P.S. I have never used Elixir language.

Thank you!

@wojtekmach - Thanks. When do you plan to release this change?

Within next 2 weeks.

Hello @wojtekmach, thank you for leading this project, do you have any update on the next release?

v0.5.2 is out!


Convert the password prompt to ES6 syntax

Moreover, remove the password prompt input type hack since it is no longer functional.
You can use http://async5.org/moz/passwordOU.pdf (password: 123456) to test this.
Easier review with https://github.com/mozilla/pdf.js/pull/8293/files?w=1.

/botio-linux preview

/botio-linux preview

/botio-linux preview


nm ethernet: Convert mac address from sysfs to upper case

Changing MAC address retrieved from sysfs to upper case, in order to be
consistent(using upper case) on MAC address.

This problem is found when NetworkManager master branch added the support of MAC address of OVS.

Coverage remained the same at ?% when pulling 97128bee19ea160a5a68275bac4487618812ffe3 on cathay4t:mac_sysfs into e4a7a0fd94a35e6b864d0936751acdd3e1bc9d6e on nmstate:master.

Coverage remained the same at ?% when pulling 97128bee19ea160a5a68275bac4487618812ffe3 on cathay4t:mac_sysfs into e4a7a0fd94a35e6b864d0936751acdd3e1bc9d6e on nmstate:master.


Documentation fix

INSTALL.md just mentions to copy parent pom to repository which doesn't install the pom and hence build of other module fails.
Please add below to documentation
mvn install:install-file -Dpackaging=pom -Dfile=~/.m2/repository/io/vertx/workshop/vertx-microservice-workshop/1.0-SNAPSHOT/vertx-microservice-workshop-1.0-SNAPSHOT.pom.xml -DpomFile=~/.m2/repository/io/vertx/workshop/vertx-microservice-workshop/1.0-SNAPSHOT/vertx-microservice-workshop-1.0-SNAPSHOT.pom.xml

Did you try with mvn install -N ?

I tried mvn install -N but it didnt work. i had to manually install the parent pom in repository.
Thanks

odd, because that's exactly what mvn -N install is doing (installing the root pom).
Anyway, can you open a PR?

Hi @cescoffier,
I tried mvn -N install after removing dir path for parent pom and it worked. i have updated documentation as needed and raised PR.
Thanks


delete file / folder function

hi,
there is the function to delete a folder or a file?

In case anyone else ends up on this ticket, a raw call with dele is the one that worked for me. If you like promises, here's mine:
const deleteFileFromFTP = (fileName) =>
  new Promise((resolve, reject) =>
    Ftp.raw('dele', fileName, (err) => {
      if (err) return reject(err)

      return resolve()
    }),
  )

I found dele on this list of ftp commands: https://www.nsftools.com/tips/RawFTP.htm


Use event property $ip and support $geoip_disable

Changes
Resolves #7.
Checklist

[x] Tests for new code

Thanks, @Twixes! Though I think I spotted a super minor bug in the comment above.


same mqtt client id - unable to reconnect

v1.0.3
for my web-app I need to store mqtt client id in the cache for a short time (i.e. 1 minute). Stream works well for the first time. Then I am unable to connect with a new RTCPeerConnection but the same mqtt client id.
command:
pi_webrtc --use_libcamera --fps=10 --width=1280 --height=960 --hw_accel --no_audio --mqtt_host=**** --mqtt_port=8883 --mqtt_username=**** --mqtt_password=**** --uid=device-100000003a0a2f6e
console output:
first try:
[0:07:06.813328372] [1576]  INFO Camera camera_manager.cpp:325 libcamera v0.3.2+99-1230f78d
[0:07:06.848779699] [1584]  WARN RPiSdn sdn.cpp:40 Using legacy SDN tuning - please consider moving SDN inside rpi.denoise
[0:07:06.850852454] [1584]  INFO RPI vc4.cpp:447 Registered camera /base/soc/i2c0mux/i2c@1/imx708@1a to Unicam device /dev/media0 and ISP device /dev/media2
[libcamera_capturer] camera id: /base/soc/i2c0mux/i2c@1/imx708@1a
[libcamera_capturer] camera validated format: 1280x960-YUV420.
[libcamera_capturer]   width: 1280, height: 960, stride: 1280
[0:07:06.851493039] [1576]  INFO Camera camera.cpp:1197 configuring streams: (0) 1280x960-YUV420
[0:07:06.851839554] [1584]  INFO RPI vc4.cpp:622 Sensor: /base/soc/i2c0mux/i2c@1/imx708@1a - Selected sensor format: 1536x864-SBGGR10_1X10 - Selected unicam format: 1536x864-pBAA
=> Set sdp success!
=> Set sdp success!

... stream is connected ...

reloading the page - initializing new RTCPeerConnection (same mqtt client id):
... not response to offer ...
... no console output for 30s ...

=> Set sdp failed! Failed to set remote offer sdp: Called in wrong state: closed
[rtc_peer] Error: INVALID_STATE; PeerConnection cannot create an answer in a state other than have-remote-offer or have-local-pranswer.
[rtc_peer] Error: Failed to apply the received candidate!
[rtc_peer] Error: Failed to apply the received candidate!
[rtc_peer] Error: Failed to apply the received candidate!

... no console output for 30s, still unable to connect ...

=> Set sdp success!
=> Set sdp success!

after approx. 60s of the first connection I am able to connect again

Oh, because I use a hash map to cache a pair of an MQTT client and an RTC peer in v1.0.3, and the hash map is refreshed very 60s.
I assumed mqtt client would disconnect after webrtc connection was established, but I didn't consider the possibility of having the same client ID.

The updated code has been integrated into the main branch, and this issue will be resolved in the next release.

It's fixed in v1.0.4.


Medical System: Basic system of External and Internal Organs

I have created a basic system representing the External and Internal organs, external represents something like an arm, or the torso, and internal being brain, heart, lungs, etc. The next step would be to implement damaging the organs and having them evaluated when considering the health of the player/mob

:D :+1:

Done

I was mostly joking because alcohol and liver failing.

it will be necessary eventually, no reason not to add it :D

You forgot the butt.

Nahhh lol

When is this going to be merged?

Good question, I'll ask

@volundr-  ?

Apparently I have merge access, so i can do it if you want?

I don't personally see why not, do you @RednoWCirabrab ?

yolo

Thanks @as334 :+1: