Fix incorrect GitHub actions path

PR to fix the issue outlined in #77 (and further discussed in https://github.com/actions/runner/issues/716) where the ${{ github.action_path }} context variable points towards the incorrect path when the action is run within a container.

Thanks. Just need to figure out how to make this work on windows as the action it uses doesn't seem to force bash on windows.
Also I recommend working off a branch rather than main from your fork.

Thanks for adding those changes @IanButterworth. Didn't seem particularly easy to get the Windows test to pass that's for sure!

Thanks for the quick report and suggestion!


message conversion error with @Transformer but not with @ServiceActivator

I have a simple processor app transforming from message in XML format to a message in JSON format:
spring:
  cloud:
    stream:
      bindings:
        output:
          content-type: application/json
        input:
          content-type: application/xml

with the following transformer
    @Transformer(inputChannel = Processor.INPUT, outputChannel = Processor.OUTPUT)
    public GreetingResponse transform(Greeting greeting) {
        logger.info("received greeting message" + greeting);
        GreetingResponse response = new GreetingResponse("Hallo " + greeting.getFrom());
        return response;
    }

    @Bean
    @StreamMessageConverter
    public MessageConverter greetingConverter() {
        return new GreetingMessageConverter();
    }

    static class GreetingMessageConverter extends AbstractMessageConverter {

        private final ObjectMapper objectMapper;

        public GreetingMessageConverter() {
            super(MimeType.valueOf("application/xml"));
            objectMapper = new XmlMapper();
            objectMapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
        }

        @Override
        protected boolean supports(Class<?> clazz) {
            return clazz.equals(Greeting.class);
        }

        @Override
        protected Object convertFromInternal(Message<?> message, Class<?> targetClass, @Nullable Object conversionHint) {
            try {
                return objectMapper.readValue((byte[]) message.getPayload(), Greeting.class);
            } catch (IOException e) {
                return null;
            }
        }
    }

Receive the error:
Caused by: java.lang.IllegalStateException: Failed to convert message: 'GenericMessage [payload=com.example.springcloudstreamprocessorexample.GreetingResponse@20de05e5, headers={contentType=application/xml, id=dc752790-51a2-b8c6-aa8d-ef52c98d4192, timestamp=1521283966338}]' to outbound message.
	at org.springframework.cloud.stream.binding.MessageConverterConfigurer$OutboundContentTypeConvertingInterceptor.doPreSend(MessageConverterConfigurer.java:335)
	at org.springframework.cloud.stream.binding.MessageConverterConfigurer$AbstractContentTypeInterceptor.preSend(MessageConverterConfigurer.java:362)
	at org.springframework.integration.channel.AbstractMessageChannel$ChannelInterceptorList.preSend(AbstractMessageChannel.java:611)
	at org.springframework.integration.channel.AbstractMessageChannel.send(AbstractMessageChannel.java:453)
	... 47 more

It is interesting that if I use @ServiceActivator then I don't get message conversion error.
Here you can find the example code:
https://github.com/altfatterz/spring-cloud-stream-processor-example
Could you help me to understand why is not working with @Transformer

@altfatterz From a quick glance what you have should NOT work, so I am not sure what do you mean it does with ServiceActivator but not Transformer. The reason why it should not work is because your custom transformer only supports Greeting and what you're producing is GreetingResponse.
Meanwhile I'll look in a little bit and will post here

@altfatterz Actually all is good and your code is correct and it should work regardless of the annotation used.
The problem you're experiencing is related to a known bug in Spring Integration where the inbound contentType header was propagated to the outbound message. That bug only exists for @Transformer - https://jira.spring.io/browse/INT-4397. So, until it is addressed please use @ServiceActivator since it is completely interchangeable.
Also, I noticed you are on RC2. Please upgrade to RC3 of Spring Cloud Stream if/when you gte a chance as it is the lates and hopefully the last RC.
Since we're on the topic of content type negotiations here are few relevant links that you may want to read (unless you already did)
Reference Manual
Blog

@olegz Thanks a lot.


Creating multiple volumes

I have created my own lamp image which works fine, from the command line i can create multiple volumes using the -v flag, yet in kitematic i can only change the one volume,  i have seen screenshots where users have specified more than one in kitematic, how do i create multiple volumes in kitematic?

Ah, found out how.. have to add volumes to my dockerfile.


[Express Form] develop branch 8.2.0a2 (589e319) has Attribute type Address displaying weird

I'm working with mnkras to apply a particular patch for develop branch to fix some Form error issues. I applied the develop branch update (589e319), and was previously v8.1.0 release.
Initially I had to update my view.php and view.css in my express_form templates, but that's not what this issue is about.
For the forms that have an Attribute type Address, it draws wonky now compared to v8.1.0, and this completely throws off my styling of the form:

What it looked like before:

I'm not sure why the new change was warranted, as this is completely throwing off my theming, and I can't find a way to really change this behaviour.
I also had to update my css from ".ccm-express-form" to ".ccm-block-express-form", which might also complicate 8.2.0 upgrades.
Pretty dead in the water here :(

Yes, we've made a number of changes that I'll document soon. I'd wanted to get these into 8.0 but we only got them part of the way there. Basically, attributes can determine how they display themselves with much more flexibility in certain contexts. In this case, the address attribute actually displays itself as a fieldset, because it has multiple fields grouped beneath it.
With this change attributes are no longer locked into strict formatting, with labels always having the bootstrap styles, with labels always coming inside of form-groups and then controls inside them. This should offer much greater support for themes that require custom markup on their form controls.
I hope to document this soon, and apologize that it means you'll have to rework your custom templates.

Is there any way to disable this sub-fieldsetting when it rolls out?

Not as of yet, no.
On Sat, Apr 1, 2017 at 10:54 AM, BloodyIron<EMAIL_ADDRESS>wrote:

Is there any way to disable this sub-fieldsetting when it rolls out?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/concrete5/concrete5/issues/5249#issuecomment-290936241,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAgNwW2fqVxeJwZ3WlxkrOf9rSezqwHgks5rro9GgaJpZM4MpRs7
.

Is it as a toggle-able or disable-able option slated for 8.2.0? This will make the Express Forms I've made for a client completely awful if this is the intended state of 8.2.0 and it's not optional.


Add leetcode solution (3074)

I want to add leetcode solution for problem 3074

@VaishnaviMankala19 I close your issue because you need open only 4 issue per day or active not large


added header for the csv

added csv headers to the download section of the assignment

Please make the first column header "Username" rather than "Student Username". Also, if you run the tests locally, you'll see that one functional test now fails.


periodically log the number of tracked items in the packet handler map

Adding, removing and retiring connection IDs and reset tokens is not a trivial thing. This logging might help debugging in the case of memory leaks.

Codecov Report

Merging #2195 into master will decrease coverage by 0.23%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #2195      +/-   ##
==========================================
- Coverage   86.51%   86.28%   -0.23%
==========================================
  Files         104      104
  Lines        7449     7469      +20
==========================================
  Hits         6444     6444
- Misses        752      771      +19
- Partials      253      254       +1

Impacted Files
Coverage Δ

packet_handler_map.go
79.78% <0%> (-10.1%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59cf1e8...441b1ed. Read the comment docs.


URL validation issue

Subject of the issue
URL validation regex is wrong. As it will not match the url: http://localhost:8080/callback, which is a valid url.
Your environment

version: 1.17.0
browser: google chrome

Steps to reproduce
Test above url with: https://jqueryvalidation.org/url-method/
Expected behaviour
Should accept as a valid url
Actual behaviour
Return as an invalid url

Hi @jeradrutnam
The regex used by the url method is based on this gist (with a small change) which is developed in order to validate the most common used urls (so this regex will consider http://localhost/, http://localhost:8080/ as invalid).
Following is a comment from the regex source code:
// the regular expression composed & commented
// could be easily tweaked for RFC compliance,
// it was expressly modified to fit & satisfy
// these test for an URL shortener:
//
//   http://mathiasbynens.be/demo/url-regex
//
// Notes on possible differences from a standard/generic validation:
//
// - utf-8 char class take in consideration the full Unicode range
// - TLDs have been made mandatory so single names like "localhost" fails
// - protocols have been restricted to ftp, http and https only as requested
//
// Changes:
//
// - IP address dotted notation validation, range: <IP_ADDRESS> - <IP_ADDRESS>
//   first and last IP address of each class is considered invalid
//   (since they are broadcast/network addresses)
//
// - Added exclusion of private, reserved and/or local networks ranges
//
// - Made starting path slash optional (http://example.com?foo=bar)
//
// - Allow a dot (.) at the end of hostnames (http://example.com.)

In case you need to accept local urls, please consider redefining the url method with a custom RegExp.
The implementation of that method in core is unlikely to change in the near future as it was the default implementation for the last 5 versions.
Closing this for now, feel free to ask if you have follow up questions.

Hi @Arkni,
I understand. Thanks for the nice explanation. I will go with a custom regex for the moment as mentioned. :)
Cheers!

Here is a nice one as well: https://gist.github.com/gruber/249502
Its more liberal, so take care.


Warning when no courses found

Now that I have found the root cause of why there were no courses, and determined it is not a permissions problem, I'm going to close this PR.


Blog build freezing after update

As reported by @atiq-cs in https://github.com/statiqdev/CleanBlog/issues/25#issuecomment-1666976380:

Hi Guys, It's been a while. Hope you are doing great!
Change in this commit 8c248f0 as part of this PR has regressed build performance. As a result of that, our large blog with 819 posts has started failing since pulling in this change. Our blog successfully builds till commit 8c248f0 is pulled.
To provide more context, our blog usually builds in 6 minutes. Since pulling this change / commit 8c248f0 it has been building for forever. It's also failing on the cloud instance since pulling in this change due to time outs. I request re-reviewing the change introduced and what changed that increased build time dramatically!
Please let me know if you need any other debug / diagnostic info.
Here's output of -- preview,
dotnet run -- preview
[INFO] Statiq Framework version 1.0.0-beta.70+625bd4754bf14f3c6a860587c6d747f4850b1c13
[INFO] Statiq Web version 1.0.0+7f3b58623a7e4ad2542635168bf49d12bb09c299
[INFO] Root path:
       D:/Code/statiq/triage.rdeago
[INFO] Input path(s):
       theme/input
       input
[INFO] Output path:
       output
[INFO] Temp path:
       temp
[INFO] Cache path:
       cache
[INFO] ========== Execution ==========
[INFO] Executing 11 pipelines (AnalyzeContent, Archives, Assets, Content, Data, DirectoryMetadata, Feeds, Inputs, Redirects, SearchIndex, Sitemap)
[INFO] Absolute Execution Date/Time: 2023-08-06 14:32:52
[INFO] Configured Current Date/Time: 2023-08-06 14:32:52
[INFO] Minimum Configured Log Level: Information
[INFO] Cleaned temp directory D:/Code/statiq/triage.rdeago/temp
[INFO] Restored write tracking data from D:/Code/statiq/triage.rdeago/cache/writecache.json
[INFO] Restored Razor compilation cache from D:/Code/statiq/triage.rdeago/cache/razorcache.json with 825 assemblies
[INFO] -> Inputs/Input » Starting Inputs Input phase execution... (0 input document(s), 1 module(s))
[INFO] -> DirectoryMetadata/Input » Starting DirectoryMetadata Input phase execution... (0 input document(s), 1 module(s))
[INFO] <- DirectoryMetadata/Input » Finished DirectoryMetadata Input phase execution (0 output document(s), 217 ms)
[INFO] -> DirectoryMetadata/Process » Starting DirectoryMetadata Process phase execution... (0 input document(s), 1 module(s))
[INFO] <- DirectoryMetadata/Process » Finished DirectoryMetadata Process phase execution (0 output document(s), 1 ms)
[INFO] <- Inputs/Input » Finished Inputs Input phase execution (837 output document(s), 423 ms)
[INFO] -> Inputs/Process » Starting Inputs Process phase execution... (837 input document(s), 8 module(s))
[INFO] <- Inputs/Process » Finished Inputs Process phase execution (836 output document(s), 6106 ms)
[INFO] -> Data/Process » Starting Data Process phase execution... (0 input document(s), 5 module(s))
[INFO] -> Assets/Process » Starting Assets Process phase execution... (0 input document(s), 3 module(s))
[INFO] <- Data/Process » Finished Data Process phase execution (0 output document(s), 29 ms)
[INFO] -> Content/Process » Starting Content Process phase execution... (0 input document(s), 4 module(s))
[INFO] <- Content/Process » Finished Content Process phase execution (809 output document(s), 2407 ms)
[INFO] -> Archives/Process » Starting Archives Process phase execution... (0 input document(s), 3 module(s))
[INFO] <- Assets/Process » Finished Assets Process phase execution (23 output document(s), 3453 ms)
[INFO] <- Archives/Process » Finished Archives Process phase execution (880 output document(s), 87658 ms)
[INFO] -> Feeds/Process » Starting Feeds Process phase execution... (0 input document(s), 3 module(s))
[INFO] <- Feeds/Process » Finished Feeds Process phase execution (2 output document(s), 32270 ms)
[INFO] -> SearchIndex/PostProcess » Starting SearchIndex PostProcess phase execution... (0 input document(s), 1 module(s))
[INFO] <- SearchIndex/PostProcess » Finished SearchIndex PostProcess phase execution (0 output document(s), 0 ms)
[INFO] -> SearchIndex/Output » Starting SearchIndex Output phase execution... (0 input document(s), 1 module(s))
[INFO] <- SearchIndex/Output » Finished SearchIndex Output phase execution (0 output document(s), 3 ms)
[INFO] -> Sitemap/PostProcess » Starting Sitemap PostProcess phase execution... (0 input document(s), 1 module(s))
[INFO] -> Assets/Output » Starting Assets Output phase execution... (23 input document(s), 2 module(s))
[INFO] -> Data/Output » Starting Data Output phase execution... (0 input document(s), 2 module(s))
[INFO] <- Data/Output » Finished Data Output phase execution (0 output document(s), 0 ms)
[INFO] -> Content/PostProcess » Starting Content PostProcess phase execution... (809 input document(s), 1 module(s))
[INFO] <- Assets/Output » Finished Assets Output phase execution (23 output document(s), 36 ms)
[INFO] -> Archives/PostProcess » Starting Archives PostProcess phase execution... (880 input document(s), 1 module(s))
[INFO] -> Feeds/Output » Starting Feeds Output phase execution... (2 input document(s), 2 module(s))
[INFO] <- Feeds/Output » Finished Feeds Output phase execution (2 output document(s), 4 ms)
[INFO] <- Sitemap/PostProcess » Finished Sitemap PostProcess phase execution (1 output document(s), 99 ms)
[INFO] -> Sitemap/Output » Starting Sitemap Output phase execution... (1 input document(s), 1 module(s))
[INFO] <- Sitemap/Output » Finished Sitemap Output phase execution (1 output document(s), 7 ms)
[INFO] [Microsoft.AspNetCore.DataProtection.KeyManagement.XmlKeyManager] User profile is available. Using 'C:\Users\Atiq\AppData\Local\ASP.NET\DataProtection-Keys' as key repository and Windows DPAPI to encrypt keys at rest.

@atiq-cs what puzzles me about this issue is that your --preview output shows all pipelines completing successfully in a few minutes. The freeze seems to happen at a later stage.
Can you post the output of --preview before commit [82c48f0] so we can see what should follow that log entry by XmlKeyManager?

@rdeago please lmk if you need anything else. Thanks for looking into this.

@rdeago @daveaglick have any of you had a look into this? Thanks again.

@rdeago @daveaglick did you get a chance to look into this?
@rdeago lmk if you need anything else. Thanks for looking into this.

@rdeago is there any update? Do you any question?

Let's go ahead and take a little look at this from a root-cause analysis before merging #35 (though thanks for PRing that if we can't get to the bottom of it). The part that I find interesting is that IsPage is a fairly simple computed value:
IsPage: => Context.Outputs.FilterSources(Context.GetString("PageSources")).ContainsById(Document)

Given the changes you're backing out in #35 that fix the performance, I can see a couple of possibilities for the degradation...

Perhaps IsPage is taking a while to compute. PageSources is just a string (PageSources: pages/**/*), but the FilterSources method uses the globber, which maybe is taking a while on a large site.
Do you have anything in your _page-after-content.cshtml file? I'm guessing not, but worth checking. If so, then that may be what's taking the time.

Any chance your site code is somewhere I can get to it and run some profiling?

could be
Nope

Any chance your site code is somewhere I can get to it and run some profiling?

Emailed you, please check junk / spam folder.

Emailed you, please check junk / spam folder.

Thanks, got it! Taking a look at this today, hopefully I'll at least get an idea where the performance degradation is coming from, if not a fix.

I think I have a solution - can you try updating to the latest version of Statiq without the changes in #35 (I.e. leave the ispage stuff in the theme). I'm curious if that resolves the issue, and if it feels snappier in general. If so, I'll fill in the details on what changed.

My local build succeeded with above suggestion. Will confirm after it also succeeds in cloud instance, some merging works needed for that, will need some time. Sorry about that.

Feel free to close this issue @daveaglick  :)

Awesome! I actually don't remember what changed at this point 😂 but glad it's holding strong.


Add my school to Jetbrains

@skopeda Please provide us with:

the school official website URL, if different from the domain you are submitting
an URL of a page on the official website where an IT-related long-term (>1 year) course is offered by the school
an URL of a page or another proof showing that the school recognizes the domain which you are submitting as an official email domain for the students.

@skopeda Please provide us with:

the school official website URL, if different from the domain you are submitting
https://www.uzlabina.cz/

an URL of a page on the official website where an IT-related long-term (>1 year) course is offered by the school
https://www.uzlabina.cz/ecdl and https://www.uzlabina.cz/cisco

an URL of a page or another proof showing that the school recognizes the domain which you are submitting as an official email domain for the students.

@skopeda Thank you for the clarification. Pull request merged.
Additional proof of the domain ownership is at https://www.uzlabina.cz/microsoft-imagine


DynamoDB: add support for transactional writes that include update operations with custom update and condition expressions

Description
DynamoDB transactional writes that are created using the document model or the object model can now include update operations with custom update and condition expressions:

Document model:

AddKeyToUpdate methods have been added to the DocumentTransactWrite class. The methods enable adding an update operation to the transaction with an arbitrary update expression instead of providing a Document.
Since the TransactWriteItemOperationConfig can also include a condition expression, the AddKeyToUpdate call can include both an update expression and a condition expression. This enables conflicts to occur between the two expressions if they use the same parameter names for attribute names and/or values. If both expressions contain the same parameter, but with different values, an exception is thrown.

Object model:

AddSaveKey methods have been added to the TransactWrite class. The methods enable adding a save operation with an arbitrary update expression instead of providing an object. Optionally, a condition expression can be provided because due to the lack of object, no version check can occur. This also enables more complex condition expressions than the simple version check.
The AddDeleteKey methods now include an optional parameter for the condition expression. This is comparable to the same parameter of the AddSaveKey methods and is added for symmetry.

Motivation and Context
The new operations are useful in scenarios when an item needs to be updated without retrieving it first. This can help avoid conflicts in some cases.
Example scenario:

A table includes items with a partition key and a range key.
We want to limit the number of items per partition.
Another table contains items which include a counter. The partition key is the same as for the other table and there is no range key. Thus, the counters count the number of items per partition in the other table.
Adding an item to the first table with checking the limit can be implemented the following way using the existing object model and document model operations:

Retrieve the counter.
Check whether the counter will reach its limit when incremented.
Add the new item and update the counter in a transaction.

However, conflicts can occur if many such operations happen concurrently. The counter needs to include a version property to ensure each added item increments the counter by one. The version check may fail if the counter has been updated by another concurrent operation and the operation needs to be retried with retrieving the counter again. Multiple retries may be necessary if there are lots of concurrent operations.

DynamoDB update expressions can be used to increment a value by a given amount (e.g SET counter = counter + 1). Using an update expression without needing to use low-level operations is possible with the changes in this PR.
The example above can be implemented by using a transaction that includes the an operation that adds the new item and an update operation with an update expression that increments the counter and a condition expression that checks that the counter cannot surpass the limit.
Testing
Existing DynamoDB integration tests have been extended to test the new operations for both models. All tests passed.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[x] I have read the README document
[x] I have added tests to cover my changes
[x] All new and existing tests passed

License

[x] I confirm that this pull request can be released under the Apache 2 license

Hi! Do you have any update on reviewing this?

Hi! Do you have any update on reviewing this?

I'm working on our initial pass, aiming to wrap up tomorrow morning eastern time. Then I'll line up a second reviewer from the maintainers.

I'm working on our initial pass, aiming to wrap up tomorrow morning eastern time. Then I'll line up a second reviewer from the maintainers.

Hi @ashovlin, thanks for the review, I'll address your comments soon.

Hi @ashovlin, @96malhar, is there any update on when this PR will be merged?

I just approved, verified it passes the build+tests in our internal release system, and prepared the versioning and changelog metadata via #3336.
We still need a second approval, but having the first should help. I'll bring up at our internal stand-up.
I also tagged a few others for the open naming thread https://github.com/aws/aws-sdk-net/pull/3294#discussion_r1601794330, but I'd be okay with what's in the current diff if no one else objects.

Another great PR @RenesansJG. Thanks for your help improving the DynamoDB high level libraries.

My pleasure, thank you for the review!

This shipped yesterday in AWSSDK.DynamoDBv2 3.7.304. Thanks again for your contribution!


Sort out code coverage

Current coverage is 60.42%

Merging #118 into development will decrease coverage by -3.46% as of bfd77a8

@@            development    #118   diff @@
===========================================
  Files                48      41     -7
  Stmts              3353    2795   -558
  Branches              0       0
  Methods
===========================================
- Hit                2142    1689   -453
  Partial               0       0
+ Missed             1211    1106   -105

Review entire Coverage Diff as of bfd77a8

Powered by Codecov. Updated on successful CI builds.


add description of how to build gem and doc locally

Add description for building locally

Sorry, I've been busy in new company for recent months.
I'll close this PR and get back when I'm not like this.


add error message feature

When user types wrong url then the input file is shown with a red highlighted color and gives warning message.

If the the icons are not downloaded or it does not exist in the given  url then it shows the message with icons not found.


Comprehensive documentation for variables made available to templates

Needed for the Datasette 1.0 release, so template authors can trust that Datasette is unlikely to break their templates.

Dupe of #1510.


Change the process timeout for live test to 1 hour

Codecov Report

Merging #2356 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2356   +/-   ##
=======================================
  Coverage   72.94%   72.94%
=======================================
  Files         425      425
  Lines       19307    19307
  Branches     2740     2740
=======================================
  Hits        14083    14083
- Misses       4320     4322    +2
+ Partials      904      902    -2

Impacted Files
Coverage Δ

src/azure-cli-core/azure/cli/core/_util.py
65.51% <0%> (ø)
:white_check_mark:

...dback/azure/cli/command_modules/feedback/custom.py
34.69% <0%> (ø)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be7374b...6f2d0b1. Read the comment docs.


AUB Fails (OAI)

[2022-08-16, 20:37:06 UTC] {taskinstance.py:1909} ERROR - Task failed with exception
Traceback (most recent call last):
  File "/home/airflow/.local/lib/python3.9/site-packages/airflow/operators/python.py", line 171, in execute
    return_value = self.execute_callable()
  File "/home/airflow/.local/lib/python3.9/site-packages/airflow/operators/python.py", line 189, in execute_callable
    return self.python_callable(*self.op_args, **self.op_kwargs)
  File "/opt/airflow/dlme_airflow/harvester/source_harvester.py", line 17, in data_source_harvester
    dataframe_to_file(collection)
  File "/opt/airflow/dlme_airflow/utils/dataframe.py", line 26, in dataframe_to_file
    working_csv = os.path.join(root_dir, "working", data_path, "data.csv")
  File "/usr/local/lib/python3.9/posixpath.py", line 90, in join
    genericpath._check_arg_types('join', a, *p)
  File "/usr/local/lib/python3.9/genericpath.py", line 152, in _check_arg_types
    raise TypeError(f'{funcname}() argument must be str, bytes, or '
TypeError: join() argument must be str, bytes, or os.PathLike object, not 'NoneType'

In my current testing, AUB succeeds all the way though indexing. This may be closable, but will run a few more final tests.


fix(README): fix typo

뻅니다다 -> 뺍니다

@all-contributors please add @kongchu2 to contributors by documentation


lib/modules: add evalNixvim

Evaluates a nixvim config, by default also checking warnings and assertions.
This used internally by the standalone wrapper.
I'm planning to use this to refactor the tests implementation:

The tests don't need a "full" standalone build
The tests should be able to expect/reject warnings/assertions
Warnings should fail tests (unless marked as expected)

But I figured it'd be easier to test/review if I push this as a separate PR.

Looking at the implementation in https://github.com/nix-community/nixvim/pull/1986, I'm wondering if the interface here is a little over-engineered?
I think the only place where we'd use it with the default values would be the standalone wrapper :face_with_diagonal_mouth:

Looking at the implementations in #1986 and #1989, I'm wondering if the interface here is a little over-engineered?

This is resolved in the latest force-push, however I still think we can simplify things further by moving the warning/assertion handling to finalPackage's evaluation; similar to how nixos checks warnings/assertions while evaluating the activation package option.

@mergifyio queue

@mergifyio queue


Can we improve containerd Helm values in cluster chart and how much time would it take?

This existing API is not really good, it's a bit hard to expand it now with local registry mirrors (will add more details from Slack thread).
global:
  components:
    containerd:
      containerRegistries: {}

The issue happens with containerRegistries value, so maybe instead of introducing a breaking change here, we could deprecate the old containerRegistries value and add a new one called just registries.
So this would be the new API:
global:
  components:
    containerd:
      registries: {}

And a cluster would use either new improved registries API (if it is set) or old containerRegistries (if new registries API is not set).
Naming this new Helm value registries is just an example. We should check the structure of containerd configuration file and then design an API nicely aligned with containerd config, so when you see containerd Helm values you can easily tell where and how those are used in containerd config file.

cc @uvegla

I would also decouple authentication from the registry / mirror configuration. That is how the containerd config file is structured and my main issue I found now is that if you want to mirror multiple registries with a single (cache) registry, like lets say Zot - but could be anything - and lets say that (cache) registry is authenticated now the current structure implies that you should set the credentials section for each instance. If you do, it will be generated into the config.toml multiple times for the same registrys auth section and will result in an invalid containerd config failing to boot up the service and thus the whole node and cluster.

This should be Turtles board and implemented there as an improvement. I believe this is still valid.

moving this to @giantswarm/team-tenet as the successor of @giantswarm/team-turtles


Code fence not highlighted

I'm in the process of migrating my blog to GitHub pages and I found your repo very useful.
Though I can't make code fence color highlighting to work. It works fine when looking at the md files inside the repo but not from the public blog address.
I also wonder how GitHub built-in themes can operated with your "theme"?

I'm also having the same problem.
Could the reason be that we need to add markdown: kramdown to -config.yml? (I saw that here: https://www.hacksparrow.com/how-to-disable-github-pages-default-rouge-code-highlighter.html)
Thanks.

I already found the answer.
Do something like this:
function test() {
    console.log("test");
}

public class Test {
    public Test() {

    }

    public void test() {
        var asdf = 1;
    }
}

The list of the aliases for the languages supported are here: https://github.com/jneen/rouge/wiki/List-of-supported-languages-and-lexers


PostgresChatMessageHistory: error: column "message" does not exist

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain.js documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain.js rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
Example Code:
import pg, { PoolConfig } from "pg";

import { PostgresChatMessageHistory } from "@langchain/community/stores/message/postgres";
import { ChatOpenAI } from "@langchain/openai";
import { RunnableWithMessageHistory } from "@langchain/core/runnables";
import {
  ChatPromptTemplate,
  MessagesPlaceholder,
} from "@langchain/core/prompts";
import { StringOutputParser } from "@langchain/core/output_parsers";

const poolConfig: PoolConfig = {
  host: 'localhost',
  port: 5432,
  user: '....',
  password: '....',
  database: '.....',
}

const pool = new pg.Pool(poolConfig)

const apiKey = '...';

const model = new ChatOpenAI({ apiKey: apiKey, model: 'gpt-3.5-turbo', temperature: 0, n: 3 })

const prompt = ChatPromptTemplate.fromMessages([
  [
    "system",
    "You are a helpful assistant. Answer all questions to the best of your ability.",
  ],
  new MessagesPlaceholder("chat_history"),
  ["human", "{input}"],
]);

const chain = prompt.pipe(model).pipe(new StringOutputParser());

const chainWithHistory = new RunnableWithMessageHistory({
  runnable: chain,
  inputMessagesKey: "input",
  historyMessagesKey: "chat_history",
  getMessageHistory: async (sessionId) => {
    const chatHistory = new PostgresChatMessageHistory({
      tableName: 'directories',
      sessionId,
      pool,
    });
    return chatHistory;
  },
});

const res1 = await chainWithHistory.invoke(
  {
    input: "Hi! I'm Chris.",
  },
  { configurable: { sessionId: "langchain-test-session" } }
);
console.log(res1);

const res2 = await chainWithHistory.invoke(
  { input: "Provide me with adventure recommendations in the municipality of San Juan." },
  { configurable: { sessionId: "langchain-test-session" } }
);
console.log(res2);

await pool.end();

Error Message and Stack Trace (if applicable)
Error
chrismperez@Chriss-MBP vt-ai % yarn start
yarn run v1.22.10
$ esno src/index.ts
/Users/chrismperez/Desktop/chris-projects/vt-ai/node_modules/pg-pool/index.js:45
    Error.captureStackTrace(err)
          ^

error: column "message" does not exist
    at /Users/chrismperez/Desktop/chris-projects/vt-ai/node_modules/pg-pool/index.js:45:11
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async PostgresChatMessageHistory.getMessages (file:///Users/chrismperez/Desktop/chris-projects/vt-ai/node_modules/@langchain/community/dist/stores/message/postgres.js:115:21)
    at async RunnableWithMessageHistory._enterHistory (file:///Users/chrismperez/Desktop/chris-projects/vt-ai/node_modules/@langchain/core/dist/runnables/history.js:212:26)
    at async file:///Users/chrismperez/Desktop/chris-projects/vt-ai/node_modules/@langchain/core/dist/runnables/base.js:1484:34 {
  length: 106,
  severity: 'ERROR',
  code: '42703',
  detail: undefined,
  hint: undefined,
  position: '8',
  internalPosition: undefined,
  internalQuery: undefined,
  where: undefined,
  schema: undefined,
  table: undefined,
  column: undefined,
  dataType: undefined,
  constraint: undefined,
  file: 'parse_relation.c',
  line: '3513',
  routine: 'errorMissingColumn'
}

Node.js v18.18.0
error Command failed with exit code 1.

Description
Description:
The error is occurring when I try to specify the table I want to use in the tableName property of the PostgresChatMessageHistory class. When executing the langchain code the langchain_chat_histories table does not exist.
But if I don't use the tableName property the code responds correctly.

System Info
System Info:

[x] plataform: Mac M1
[x] node: v18.18.0
[x] yarn: v1.22.10
[x] package.json

  "dependencies": {
    "@langchain/community": "^0.2.13",
    "@langchain/openai": "^0.0.33",
    "@types/pg": "^8.11.6",
    "pg": "^8.12.0",
    "typeorm": "^0.3.20"
  },

@dosue
The langchain_chat_histories table initially does not exist.
langchain_chat_histories is the table that should contain:
id SERIAL PRIMARY KEY,
session_id VARCHAR(255) NOT NULL,
message JSONB NOT NULL

@dosue
Your solution is not correct.I want to consume the data (ask questions) from the directories table.

@dosue
Your solution is not correct.
The tableName property is used to specify the table that I want to use to consume data. But the langchain_chat_histories table must be created to keep record of the conversation history.
The error I am having is the following:
/Users/chrismperez/Desktop/chris-projects/vt-ai/node_modules/pg-pool/index.js:45
 Error.captureStackTrace(err)
 ^
error: column "message" does not exist

@dosue
The directory table contains these columns: id, title, description, phone, created_at, updated_at, published_at, created_by_id, updated_by_id

If a table with the name directories already exists, then the message history will not create a new table. The tableName you pass to the message history is the table you want the history to use to store messages. This defaults to langchain_chat_histories. It looks like you've created a directories table for some other purpose and are now passing that name to the message history. The history will assume that the existing table whose name you've passed is a table that follows the chat message table schema, which it does not since

The directory table contains these columns: id, title, description, phone, created_at, updated_at, published_at, created_by_id, updated_by_id

I'm not sure why you are passing the name of that table to the message history. If you need that table, then you should use another table name. If you don't need it, then drop it and use the directories name.

@MJDeligan Thanks for the clarification.
And how can I interact with the data of a particular table?

I'm guessing you cannot query the data based on the input. Retrieval will depend on whether the data can be reliably searched by exact or pattern matching. If for example you have a table with people and those people are associated with a unique username and you want to answer queries such as "How old is lisab561?" then tool calling would be the right idea, since the llm can infer the username and issue a tool call, which you would implement as a function that performs the sql query.
If however you want to retrieve data which can't be matched exactly or by some pattern and instead requires a semantic match then you need a vectorstore with embeddings for the data you want to match.
A case for this would be if your people data has descriptions for people and you want to handle queries such as "What's the name of a kind and loving person". User lisab561 might have a description like "Does sports and especially loves climbing. She's a lovely and nice person.". Obviously this is not an exact match but semantically her description fits the query and a vectorstore would be able to match the query to the data.


Add plugin for dnf (New package manager and package management librar…Add plugin for dnf (New package manager and package management library for Fedora) based in yum plugin

Add plugin for dnf (New package manager and package management library for Fedora) based in yum plugin.
DNF page: https://fedoraproject.org/wiki/Features/DNF

@fjospinas would you add auto complete too? thanks!

This is basically the same as #2452 with the only differences being that sudo dnf upgrade instead of sudo dnf update" and sudo dnf removeinstead ofsudo dnf erase` being used.
According to dnf --help, the commands used for the dnfu and dnfr aliased in this pull request are the correct/new/current ones:
$ dnf --version
1.0.0
  Installed: dnf-0:1.0.0-1.fc22.noarch at 2015-05-21 18:56
  Built    : Fedora Project at 2015-05-02 13:00

  Installed: rpm-0:<IP_ADDRESS>-9.fc22.x86_64 at 2015-05-21 18:56
  Built    : Fedora Project at 2015-04-15 09:21

$ dnf --help
usage: dnf [options] COMMAND

List of Main Commands

autoremove
check-update              Check for available package upgrades
clean                     Remove cached data
distro-sync               Synchronize installed packages to the latest available versions
downgrade                 downgrade a package
group                     Display, or use, the groups information
help                      Display a helpful usage message
history                   Display, or use, the transaction history
info                      Display details about a package or group of packages
install                   Install a package or packages on your system
list                      List a package or groups of packages
makecache                 Generate the metadata cache
provides                  Find what package provides the given value
reinstall                 reinstall a package
remove                    Remove a package or packages from your system
repolist                  Display the configured software repositories
repository-packages       Run commands on top of all packages in given repository
search                    Search package details for the given string
updateinfo                Display advisories about packages
upgrade                   Upgrade a package or packages on your system
upgrade-to                Upgrade a package on your system to the specified version

List of Plugin Commands

builddep                  Install build dependencies for packagei or spec file
config-manager            manage dnf configuration options and repositories
copr                      Interact with Copr repositories.
debuginfo-install         install debuginfo packages
download                  Download package to current directory
kickstart                 Install packages defined in a kickstart file on your system
migrate                   migrate yum's history, group and yumdb data to dnf
needs-restarting          determine updated binaries that need restarting
playground                Interact with Playground repository.
repoquery                 search for packages matching keyword
reposync                  download all packages from remote repo

optional arguments:
  --allowerasing        allow erasing of installed packages to resolve
                        dependencies
  -b, --best            try the best available package versions in
                        transactions.
  -C, --cacheonly       run entirely from system cache, don't update cache
  -c [config file], --config [config file]
                        config file location
  -d [debug level], --debuglevel [debug level]
                        debugging output level
  --debugsolver         dumps detailed solving results into files
  --showduplicates      show duplicates, in repos, in list/search commands
  -e ERRORLEVEL, --errorlevel ERRORLEVEL
                        error output level
  --rpmverbosity [debug level name]
                        debugging output level for rpm
  -q, --quiet           quiet operation
  -v, --verbose         verbose operation
  -y, --assumeyes       answer yes for all questions
  --assumeno            answer no for all questions
  --version             show DNF version and exit
  --installroot [path]  set install root
  --enablerepo [repo]
  --disablerepo [repo]
  -x [package], --exclude [package]
                        exclude packages by name or glob
  --disableexcludes [repo]
                        disable excludes
  --obsoletes           enable obsoletes processing during upgrades
  --noplugins           disable all plugins
  --nogpgcheck          disable gpg signature checking
  --disableplugin [plugin]
                        disable plugins by name
  --color COLOR         control whether color is used
  --releasever RELEASEVER
                        override the value of $releasever in config and repo
                        files
  --setopt SETOPTS      set arbitrary config and repo options
  --refresh             set metadata as expired before running the command
  -4                    resolve to IPv4 addresses only
  -6                    resolve to IPv6 addresses only
  -h, --help            show help

@ohadlevy While I agree that support for auto-completion of package names for aliases such as dnfi is desirable I think that it is outside the scope of this pull request which is about adding a plugin for dnf. The old yum plugin did not have support for auto-completion either.


Fix yarn dev issue

A PR for https://github.com/nih-sparc/sparc-app-2/pull/213

Target branch has been merged.


possible to expand this with rocksdb backend and faceted search?

possible to expand this with rocksdb backend and faceted search?

@superdolt  I'm currently working on this and I hope to write an article on it soon.
https://github.com/lexyblazy/ftsengine


[Run Dev] Nuget package not being included?

Microsoft PowerToys version
0.64.0
Installation method
GitHub
Running as admin
No response
Area(s) with issue?
PowerToys Run
Steps to reproduce
In my plugin for Run I want to start using the Octokit nuget package
but for some reason when I build  (Ctrl+B) the plugin, Octokit.dll isn't being included
even if I manually add the dll file to the program files folder, I get an initialization error saying my plugin can't find the dll

Anyone know what I'm doing wrong?
✔ Expected Behavior
nuget packages to be included
❌ Actual Behavior
nuget package not being included
Other Software
EverythingPowerToys

Can you assign this to me

Hey guys is your problem relatet to the issue #18435 and PR #18437?

Ok, cause some reason, power toys now do NOT load 3rd dll

Welp, it is related to PR https://github.com/microsoft/PowerToys/pull/18437
I see that there's still some issues to iron out before it's merged.
I guess I'll switch dllimport as a temp fix, looking forward to the PR being merged.


DEC-507 Index items

This PR includes code to index Item API data into Solr using Sunspot.
I added a Metadata::Configuration class to contain the configuration information for item metadata.
The Waggle namespace includes all of the code for indexing item data.
Waggle::Item is a wrapper around the item API JSON output.
Waggle::Metadata::Set is a wrapper around the item's metadata JSON.  It is used to return all metadata field values in their indexable form.
Waggle::Index::Item is responsible for setting up the indexing of Waggle::Item using Sunspot.
This does not include the functionality to index items automatically on save.  That will come in a separate pull request.

:+1:


[V3 RC4] Help migrating, getLocalPosition is not a function?

Hello,
First of all sorry for asking here, but seeing there is no forum and I can't find documentation for 3.0 yet, seems to be a good place to ask.
I have a somewhat complex project built on pixi and performance is not briliant right now due to a huge number of objects and thought it would be a good time to try change to 3.0, to see how it improves. Mostly went fine, fixed all the deprecated warnings on the console, however, some functions do not work. Most important of all to have a working build of this is the interaction.
In any of the mouse callbacks I cant get the position and says getLocalPosition is not a function. This is the working 2.2.7 code for mouse move as an exemple:
on start:
      dragMask.mousemove = dragMask.touchmove = function(data) {
        if(jsmap.smoothing)
          return;
        if(!zoom_on_prev_frame)
          jsmap.cameraMouseMove(data);
        else
          jsmap.cameraMouseUp(data);

      };

and the cameraMouseMove where it throws the error:
    cameraMouseMove: function(data){

      if(jsmap.state == jsmap.map_state){
        globalMousePosition = data.getLocalPosition(pixiWindow);
        if (map.dragging) {
          map.position.x = map.initx + globalMousePosition.x - map.initlocalx;
          map.position.y = map.inity + globalMousePosition.y - map.initlocaly;
          jsmap.updateQuadtree();
          jsmap.fixOrdersPosition();
        }
      }

      else if(jsmap.state == jsmap.city_state){
        globalMousePosition = data.getLocalPosition(pixiWindow);
        if (city_view.dragging) {
          city_view.position.x = city_view.initx + globalMousePosition.x - city_view.initlocalx;
          city_view.position.y = city_view.inity + globalMousePosition.y - city_view.initlocaly;
        }
      }
    },

pixiWindow is now a Container (previously a DisplayObjectContainer).
Other less important things giving the same error are setStyle on a PIXI.Text and new PIXI.MovieClip.
Thank you for the help.

event.data is the InteractionData object, which has getLocalPosition.

Ok, thank you for the quick awnser. Already also found the setStyle, however I also cant seem to find the new PIXI.MovieClip. Already tried with and without the new, with and without arguments and with and without the PIXI.
this is how it is being used and working in v2.2.7:
    addMovieClip: function(map, x, y, xoffset, yoffset, textures){
      var tex = [];
      for(var i = 0; i < textures.length; i++){
        if(!jsmap.textures.hasOwnProperty(textures[i]))
          jsmap.textures[textures[i]] = new PIXI.Texture.fromImage(textures[i]);
        tex.push(jsmap.textures[textures[i]]);
      }

      var xpos = jsmap.getMapXPos(x, y);
      var ypos = jsmap.getMapYPos(x, y);
      var clip = new PIXI.MovieClip(tex);
      clip.position.x = xpos + xoffset;
      clip.position.y = ypos + yoffset;
      clip.xCoord = x;
      clip.yCoord = y;
      clip.gotoAndPlay(0);
      clip.animationSpeed = 0.25;
      map.addChild(clip);
      clip.visible = false;
      jsmap.quadtree[x][y].push(clip);
    },

Everything else is already working fine with 3.0. Will give feedback later to the performance after this is fixed. Thank you again.

ok, found it. PIXI.extras.MovieClip.

Most things in v3 will log where it has moved to if you are using the latest dev version the deprecation logs are pretty comprehensive.


Package provides a spurious poetry console script

While debugging a rather odd issue with a Poetry user, we discovered that your package is providing a spurious/nonsense console script that clobbers the user's Poetry install when present in the environment:
https://github.com/coinmetrics/api-client-python/blob/49168f602379e65d2ffb5936a7753f7492b45bf8/pyproject.toml#L34-L35
I'm guessing this was part of a bad copy-and-paste at some point -- I'd suggest removing it to avoid unexpectedly polluting the PATH of anything that uses your package.

Will remove this shortly, thank you for pointing this out.

This was resolved with previous merge

It appears it's still present in the repository -- maybe you have unpushed commits somewhere?
https://github.com/coinmetrics/api-client-python/blob/55f9c980a906e6554b05bf36069b98df540ceaac/pyproject.toml#L34-L36


Add tag support to journald logging driver, closes #19556

Tested manually on debian jessie, it worked :whale:

Windows build failed, but it does seem like a transient network failure.

Change LGTM

LGTM

@bobrik you need to update the options paragraph of docs/reference/logging/journald.md too, to add tag option (see https://github.com/docker/docker/blob/master/docs/reference/logging/fluentd.md#tag for example)

@vdemeester updated docs.

Any chance for this to make it in 1.10?

@bobrik sadly no :sweat_smile: the code freeze was on 14/01/2016 — we're way past that date :sob:

docs LGTM

[x] 80 char word wrap
[x] spelling
[x] Markdown
[x] Sentences end in a period
[x] code change has something to do docs change

ah @bobrik needs a rebase :sweat:

Did a rebase, but didn't see any conflicts.

LGTM 🐰


Remove global cache (state) and use Instance level cache instead.

It could cause issues as the key used is a Parser's name
and that may not be unique if multiple Chevrotain parsers are loaded in the same node.js process.
An alternative may be to use only local instance state, but that would mean
that if a user creates new parser instances for each input there would be a severe performance reduction.
But that performance reduction already happens when using multiple instances so maybe it does not matter
if it's severity increases...

👍

Pull request here: https://github.com/SAP/chevrotain/pull/765/files

Removing the cache related logic simplified many things and got rid of quite a bit of code. 😄
In addition the clearCache function has been soft deprecated
and currently only prints a warning without any other side effect.
In the future it will be completely removed.

Very Important
Anyone upgrading to Chevrotain 3.7 should verify that the same parser instance is reused to parse different inputs, If a new parser instance for every input a large performance impact would occur.


ISSUE 1683 Fix: (DynamicForm) Added the option to edit file name

Added the option to edit file name when the form points to a document library and an item is being edited

Q
A

Bug fix?
[ X ]

New feature?
[ ]

New sample?
[ ]

Related issues?
fixes #1683

What's in this Pull Request?
When the control DynamicForm is configured to display an item in a document library, the field Name (FileLeafRef) does not come through to edit.
To amend that behaviour, I have performed the following changes:
DynamicForm.tsx

The function that retrieves the fields (getFormFields) has been modified to bring the field FileLeafRef when an item id has been provided (hence editing an item)
The function that provides the information needed to display the fields (getFieldInformations) has been modified to include a case for File fields and retrieve the file name

DynamicField.tsx

A new case has been added to display a File field by displaying a text box with the file name

SPService.ts

A new function has been added to SPService to retrieve the file name of a document library item (getFileName)

@gruizdev - sorry for the long delay.
Could you please resolve the conflict?
Thanks!

@gruizdev would you be able to resolve the conflicts or need some help with this? There are more PRs that target this control and ideally we would merge them in order of submission.

Hi @gruizdev,
Are you still working on this one? Do you need any assistance?

Hi @michaelmaillot,
It seems @gruizdev is unresponsive on this. Would it be an idea if someone else picked this up to get it unblocked?
Interesting feature that I'm currently building a workaround for because it's not yet in. Also I've seen another relevant PR (#1781) is waiting on this one. #

Hello @martinlingstuyl, you can take it away 🙂
I'll let you share your progress here, feel free to open another PR if necessary. I'll assign the issue to you.

Closing this PR due to lack of owner's response.


scroll-content spelled incorrectly in structure.scss

Short description of the problem:
As I was looking through my generated css file, I noticed a couple of lines had 'scroll-cotent' instead of 'scroll-content'. I traced it back to components/app/structure.scss (lines 71 & 83).
From structure.scss:
ion-tab scroll-cotent {
  display: none;
}

ion-tab {
  transform: translateY(-200%);
}

ion-tab.show-tab {
  transform: translateY(0);
}

ion-tab.show-tab scroll-cotent {
  display: block;
}

Here's a direct link:
https://github.com/driftyco/ionic/blob/master/src/components/app/structure.scss#L71-L85
Sorry, I don't have any more than that, but I figure it's a pretty straight-forward fix.

This can actually probably be removed since the scroll-content in a tab is getting the same styling from:
ion-page scroll-content {
  // do not render the scroll-content at all until ready
  display: none;
}

ion-page.show-page {
  // show the page now that it's ready
  opacity: 1;
}

ion-page.show-page scroll-content {
  // render the content when ready
  display: block;
}

This is no longer an issue, thank you!


Old records in cache?

I'm refactoring my entire Firestore schema.  I've loaded the FS emulator with the old schema, run my expo app in the iOS Simulator.
Then I reset the emulator with all fresh data and re-start the iOS app.  I am getting both old and new data (old data is NOT in the Firestore emulator).
When I disable persistence and restart the iOS app, I am only seeing the new data.
Thoughts on how/why those old docs are still there?  Is there a recommended way to "reset the persistence" when using expo-firestore-offline-persistence?
(BTW: A million THANKS for your contribution to the community!!)

That's the classic computer science problem: cache invalidation is hard.
This problem doesn't seem related to this library. Instead, it seems related to Firestore's persistence in general (or so I would think).
Maybe check if firestore lets you clear the persistence cache?
If you look in the source code here, all this lib does is let us access SQLite.

According to this stack-overflow post, there is a clearPersistence() API.  Looks like this is the documentation  for the API.

According to this stack-overflow post, there is a clearPersistence() API.  Looks like this is the documentation  for the API.
Thanks for the quick response!

FWIW, I recommend using some sort of unique key to determine if your schema has changed.
In my app, I often associate this with the expo publish ID. If the ID changed, wipe out the persistence cache. Otherwise, persist. There are probably better strategies but that's what I rely on.

In my app, I often associate this with the expo publish ID. If the ID changed, wipe out the persistence cache. Otherwise, persist. There are probably better strategies but that's what I rely on.

Got a code snippet you could share?
I'm not clear on how you are getting the publish ID and comparing to what the persistence has.  Are you updating the persistence value directly (i.e. shoving a value into SQLite) that you compare on each start of your app, then clearing the cache if there is a mismatch and putting the current publish ID into the SQLite?


cannot change contentType to webp

even I use sharp().webp(), the contentType still get image/jpg

interesting, i want to use this for webp transformation as well

Found this, whoever might find this to be helpful
https://xetera.dev/converting-webp/


Craft 3.4.30

Site Duplicate 1.0.3 no longer works with Craft CMS 3.4.30. Last used it with Craft CMS 3.4.23 and all worked as expected, now with the same sites on Craft CMS 3.4.30 it throws 500 error "An error occurred when duplicating the entry.".
Logs repored it as:  "Attempting to duplicate an unsaved element. in vendor/craftcms/cms/src/services/Elements.php:736".
I think the reason for this error is:
If you compare bodyParams from request at the beginning of private function _getEntryModel() in craft-siteduplicate/src/controllers/DuplicateController.php:
In Craft 3.4.23; Site Duplicate 1.0.3:
private '_bodyParams' (yii\web\Request) =>
    array (size=16)
      'CRAFT_CSRF_TOKEN' => string '[clipped]'... (length=556)
      'action' => string 'siteduplicate/duplicate' (length=23)
      'redirect' => string '[clipped]' (length=79)
      'siteId' => string '1' (length=1)
      'sectionId' => string '2' (length=1)
      'entryId' => string '188341' (length=6)
      'title' => string '[clipped]' (length=35)
      'slug' => string '[clipped]' (length=37)
      'author' =>
        array (size=1)
          0 => string '1105' (length=4)
      'postDate' =>
        array (size=3)
          'date' => string '06/03/2020' (length=10)
          'timezone' => string 'Europe/London' (length=13)
          'time' => string '11:11' (length=5)
      'expiryDate' =>
        array (size=3)
          'date' => string '' (length=0)
          'timezone' => string 'Europe/London' (length=13)
          'time' => string '' (length=0)
      'enabled' => string '1' (length=1)
      'siteduplicate-siteId' => string '14' (length=2)
      'duplicateSiteId' => string '14' (length=2)

in Craft 3.4.30; Site Duplicate 1.0.3:
private '_bodyParams' (yii\web\Request) =>
    array (size=16)
      'CRAFT_CSRF_TOKEN' => string '[clipped]'... (length=556)
      'action' => string 'siteduplicate/duplicate' (length=23)
      'redirect' => string '[clipped]' (length=79)
      'siteId' => string '1' (length=1)
      'sectionId' => string '2' (length=1)
      'sourceId' => string '188341' (length=6)
      'title' => string '[clipped]' (length=35)
      'slug' => string '[clipped]' (length=37)
      'author' =>
        array (size=1)
          0 => string '1105' (length=4)
      'postDate' =>
        array (size=3)
          'date' => string '06/03/2020' (length=10)
          'timezone' => string 'Europe/London' (length=13)
          'time' => string '11:11' (length=5)
      'expiryDate' =>
        array (size=3)
          'date' => string '' (length=0)
          'timezone' => string 'Europe/London' (length=13)
          'time' => string '' (length=0)
      'enabled' => string '1' (length=1)
      'siteduplicate-siteId' => string '14' (length=2)
      'duplicateSiteId' => string '14' (length=2)

As you can see, in Craft 3.4.30 there's no longer entryId param. It looks like it's been replaced with sourceId.
Can you please push a fix for this?

Hello everyone
Sorry for not getting back to you. I've been on vacation for the summer but
I've been back since monday. I'll fix this for an early next week release.
You have my word!
I also need to look into so there's no issues with the newly released 3.5
version.
JOHAN STRÖMQVIST
INTERACTIVE DIRECTOR
Naboovalley AB
Palmaers gata 28
584 37 Linköping
*PHONE *+46 (0)70 377 13 80
*EMAIL<EMAIL_ADDRESS>*WWW *www.naboovalley.com
On Fri, Aug 7, 2020 at 10:20 AM Iwona Just<EMAIL_ADDRESS>wrote:

Site Duplicate 1.0.3 no longer works with Craft CMS 3.4.30. Last used it
with Craft CMS 3.4.23 and all worked as expected, now with the same sites
on Craft CMS 3.4.30 it throws 500 error "An error occurred when duplicating
the entry.".
Logs repored it as: "Attempting to duplicate an unsaved element. in
vendor/craftcms/cms/src/services/Elements.php:736".
I think the reason for this error is:
If you compare bodyParams from request at the beginning of private
function _getEntryModel() in
craft-siteduplicate/src/controllers/DuplicateController.php:
In Craft 3.4.23; Site Duplicate 1.0.3:
private '_bodyParams' (yii\web\Request) =>
array (size=16)
'CRAFT_CSRF_TOKEN' => string '[clipped]'... (length=556)
'action' => string 'siteduplicate/duplicate' (length=23)
'redirect' => string '[clipped]' (length=79)
'siteId' => string '1' (length=1)
'sectionId' => string '2' (length=1)
'entryId' => string '188341' (length=6)
'title' => string '[clipped]' (length=35)
'slug' => string '[clipped]' (length=37)
'author' =>
array (size=1)
0 => string '1105' (length=4)
'postDate' =>
array (size=3)
'date' => string '06/03/2020' (length=10)
'timezone' => string 'Europe/London' (length=13)
'time' => string '11:11' (length=5)
'expiryDate' =>
array (size=3)
'date' => string '' (length=0)
'timezone' => string 'Europe/London' (length=13)
'time' => string '' (length=0)
'enabled' => string '1' (length=1)
'siteduplicate-siteId' => string '14' (length=2)
'duplicateSiteId' => string '14' (length=2)
in Craft 3.4.30; Site Duplicate 1.0.3:
private '_bodyParams' (yii\web\Request) =>
array (size=16)
'CRAFT_CSRF_TOKEN' => string '[clipped]'... (length=556)
'action' => string 'siteduplicate/duplicate' (length=23)
'redirect' => string '[clipped]' (length=79)
'siteId' => string '1' (length=1)
'sectionId' => string '2' (length=1)
'sourceId' => string '188341' (length=6)
'title' => string '[clipped]' (length=35)
'slug' => string '[clipped]' (length=37)
'author' =>
array (size=1)
0 => string '1105' (length=4)
'postDate' =>
array (size=3)
'date' => string '06/03/2020' (length=10)
'timezone' => string 'Europe/London' (length=13)
'time' => string '11:11' (length=5)
'expiryDate' =>
array (size=3)
'date' => string '' (length=0)
'timezone' => string 'Europe/London' (length=13)
'time' => string '' (length=0)
'enabled' => string '1' (length=1)
'siteduplicate-siteId' => string '14' (length=2)
'duplicateSiteId' => string '14' (length=2)
As you can see, in Craft 3.4.30 there's no longer entryId param. It looks
like it's been replaced with sourceId.
Can you please push a fix for this?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/naboo/craft-siteduplicate/issues/5, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJJ3TNBYYWMQMTH4K3NSJ3R7O2MJANCNFSM4PXMOHVQ
.

Fixed in v1.1.0

Hi,
Thanks for this. Can you please change it to require Craft 3.4 or higher? At the moment you've set it to be locked to Craft CMS 3.4.0 and the latest version of 3.4 is 3.4.30 (and that's also the version mentioned in the original issue).

Sorry about that. Fixed https://github.com/naboo/craft-siteduplicate/releases/tag/v1.1.1

Thanks for a quick update.
Now that I was able to test it against Craft CMS 3.4.30 I have found another series of problems in craft-siteduplicate/src/controllers/DuplicateController.php:

$this->request => doesn't work (first error thrown in _getEntryModel() function), it's not declared anywhere
$this->setSuccessFlash => no such method declared anywhere but called on line: 199
$this->enforceSitePermission => no such method declared anywhere but called on line: 76
$this->setFailFlash => no such method declared anywhere but called on lines: 114, 166

Any chance you can have a look at this?

Hmm, I see. I tested it against Craft 3.5 to make it compatible upwards.
I'm guessing 3.5 has these functions declared on the BaseController now
days.
So I'll need to bump the requirements to 3.5 I'm afraid, I'll not make it
compatible with an older version.
Can you make these edits yourself? If not I can send you an edited file you
can just replace until you update to 3.5.
Den tors 13 aug. 2020 15:37Iwona Just<EMAIL_ADDRESS>skrev:

Thanks for a quick update.
Now that I was able to test it against Craft CMS 3.4.30 I have found
another series of problems in
craft-siteduplicate/src/controllers/DuplicateController.php:

$this->request => doesn't work (first error thrown in
_getEntryModel() function), it's not declared anywhere
$this->setSuccessFlash => no such method declared anywhere but
called on line: 199
$this->enforceSitePermission => no such method declared anywhere but
called on line: 76
$this->setFailFlash => no such method declared anywhere but called
on lines: 114, 166

Any chance you can have a look at this?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/naboo/craft-siteduplicate/issues/5#issuecomment-673483287,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJJ3TKLW2IL2WLG4XHGC5LSAPUAZANCNFSM4PXMOHVQ
.

Ok, thanks; Yes, I can edit myself for now. I'll be updating websites that use siteduplicate plugin to C3.5 in the next 2 weeks anyway.


[double-conversion] Remove unnecessary patch

The ARM patch is unnecessary since pr76 of double-conversion has already applied this patch.

Thanks for the PR and sorry for the long delay!


Move tuxbuild json submission to it's own command

More changes with tuxbuild json submission ;)
Some of the options for submit do not make sense for submission of tuxbuild json, so I think it should move to it's own command.

After discussion with @chaws we agreed on a new command submit-tuxbuild that we can use.
This isn't as high priority because my group won't hit the bug with the current submit functionality, but it still is an issue.


Implement mock back-end

Implements the mock back-end.
Tests that require substantial re-work are skipped.
Depends on #9 , #41, and #42.
WSL-433

Force-push after rebasing main

Force-pushed again to solve merge conflict. Only commit affected is e47dc4c2944090bb90e4506d58a701ec5b4fbc2b. I noticed that there was a if(!windows){panic} everywhere where wslExeGuard was called, so I simply moved the panic into the guard.


Categorize ideas as per page difficulty levels

Fixes #176
Description
Replaces Low --> Easy, High --> Hard in all the relevant ideas.
Other information

Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the master branch of the repository.
[x] My commit messages follow best practices.
[ ] I added tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Some trailing spaces are missed out. I hope that won't be an issue @kgodey


Nullish coalescing bug and finishing pre-publish testing

This PR:

Fixes Nullish coalescing bug (resolves #91)
Resolves the last bug found in pre-publish testing (resolves #83)
Contains patch release 0.6.3

Almost there!!

code looks great! 👍


Test suite cleanups

Current coverage is 32.72% (diff: 100%)

Merging #9 into master will decrease coverage by 67.27%

@@           master         #9   diff @@
========================================
  Files           4         10     +6
  Lines           6        110   +104
  Methods         0          0
  Messages        0          0
  Branches        0          0
========================================
+ Hits            6         36    +30
- Misses          0         74    +74
  Partials        0          0

Powered by Codecov. Last update 87f22fc...27b0cf1


Fix issues identified by Sonar

Sonar flagged a couple of issues in DownloadCache implementation.
Not sure why it flagged the closing of resources since it is covered in the finally clause, but I changed the implementation to use a try with resource approach.

@pmonks - Just FYI - I did a few changes to the original caching code to address issues found by the Sonar quality checks.  Although none of the issues were significant IMO, I wanted to have a clean run on the quality checks.
I also added issue #210 to update the CI to check for these on pull requests which will hopefully flag these earlier.

Cool!  I forget - is try with resources supported on JDK 8?  That's the only thing I can think of that might be problematic with that change.

Oh and you may have noticed that I'm a proponent of "single point of return only".  I find that methods with more than one return statement tend to be harder to reason about, and as a result more likely to result in bugs as the code is maintained and enhanced over time.
I realise that's not the dominant style in the rest of the library however.

is try with resources supported on JDK 8?

Yes - it is supported in JDK 8.  I actually didn't find anything wrong with the prior implementation, but Sonar flagged it and suggested try ... with as a solution.

Oh and you may have noticed that I'm a proponent of "single point of return only". I find that methods with more than one return statement tend to be harder to reason about, and as a consequence more likely to result in bugs as the code is maintained and enhanced over time. I realise that's not the dominant style in the rest of the library however.

I usually do the early check and return early in the method if it helps reduce the nesting level.  I lean more towards reducing nesting levels even at the expense of early exits from functions and loops - but you're right - it could lead to less maintainable code.

One other comment: comparing to null directly (x == null) is slightly more performant than Objects.isNull(x), especially when you consider that that latter method is implemented as if (x == null) anyway.

True - I do like the readability of the Objects.isNull.  I'm OK with either approach in the library, I probably just added the function call more out of habit.

As a smug lisp weenie nesting doesn't bother me at all - in fact without nesting nothing is happening. 😜


feat: add jaas controller access resource

Description
~This PR builds on #584.~
This PR introduces a JAAS acccess controller resource. This defines the permissions towards the JAAS controller and leverages on the generic access logic.
There is one unique aspect of this resource compared to the other JAAS access resources - this resource has no target object. I.e. A user does not specify a specific controller. This resources defines the access on the JAAS controller itself.
Partially addresses: CSS-10638
Type of change

Add new resource

/merge


IPython kernel restart and clear cells commands broken

Bug: Notebook Editor, Interactive Window, Editor cells

Steps to cause the bug to occur

Configure key-bindings for restartkernel and removeallcells.

  {
    "key": "ctrl+'",
    "command": "python.datascience.restartkernel",
    "when": "editorTextFocus && python.datascience.featureenabled && python.datascience.hascodecells"
  },
  {
    "key": "ctrl+alt+'",
    "command": "python.datascience.removeallcells",
    "when": "editorTextFocus && python.datascience.featureenabled && python.datascience.hascodecells"
  },

Start using an Interactive Session (.py file with #%% cells).

Try to restart kernel or clear cells using configured keyboard shortcuts.

Actual behavior
Nothing happens.
Expected behavior
Interactive kernel is restarted or output cells cleared as per command.

Notes
This worked properly using the previous version of the Python extension (before support for multiple interactive windows was added). I am using Interactive Window Mode: perFile. However I also tested with it set to single and multiple and neither worked.
Your Jupyter and/or Python environment
Please provide as much info as you readily know

Jupyter server running: Local
Extension version: 2020.08.103604
VS Code version: 1.48.1
Setting python.languageServer: Pylance
Python version: 3.8.1
OS: Windows & macOS
Virtual environment: WinPython & venv (macOS)

Python Output

Microsoft Data Science for VS Code Engineering Team: @rchiodo, @IanMatthewHuff, @DavidKutu, @DonJayamanne, @greazer, @joyceerhl

@patrick984  how did you get the specification for that key-binding? It looks pretty different in the when clause from how those commands are currently specified in our package.json.
               {
                    "command": "python.datascience.restartkernel",
                    "title": "%python.command.python.datascience.restartkernel.title%",
                    "category": "Python",
                    "when": "python.datascience.haveinteractive && python.datascience.featureenabled && python.datascience.ispythonorinteractiveeactive"
                },

With current bits I rebound one of the commands mentioned and when focus was in the interactive window it worked just fine for restarting the kernel:

@IanMatthewHuff I got the "when" conditions from existing Python datascience keyboard shortcuts, although I did this a few versions ago so perhaps things have changed.
I tried replacing my "when" clause with your suggestion and the keyboard shortcuts do indeed work when the focus is in the interactive window, however they don't work when the focus is in the corresponding editor -- which is the behavior of the previous version. Ignoring key-bindings for a moment, it appears that running the Restart IPython Kernel command from the Command (F1) menu also does nothing if the focus is in the editor.
So perhaps the issue is that the restart kernel and clear cells commands are no longer available in the editor window in the new version?

Hmm, yes. This is probably a side effect of us now allowing multiple interactive windows. Since you could be sending code to different interactive windows from the same editor file we don't allow commands from the editor anymore, only when the focus is on the window. Sounds like we broke a scenario that you used this for. We'll talk it over in our triage meeting.

Would it make sense to restore the old behaviour when interactiveWindowMode ="perFile" or "single", and only disallow commands from the editor when interactiveWindowMode  = "multiple"?

I relied heavily on these shortcuts and would also appreciate them being restored, at least for the "perFile" or "single" window case, as @patrick984 suggests.


Update Composer dependencies (2022-03-04-00-04)

Visual regression test passed!
View the visual regression test report


'lpips' has no attribut 'PerceptualLoss'

When i use the ' sudo pip3 install lpips'

import lpips

and   i use ' percept = lpips.PerceptualLoss(model='net-lin', net ='vgg', use_gpu= True)

then the error  'lpips' has no attribut 'PerceptualLoss'

I changed the API a bit. You can see the example files for the readme (https://github.com/richzhang/PerceptualSimilarity#quick-start) for the syntax. Sorry for any confusion.

Thank you.


Bug Report: Tawk chat button and Speak button are having more space

Reproduction steps
When I was checking the website, I just saw this bug.
Expected behavior
It is happening due to improper alignment.
Actual Behavior

I can work on this issue and can properly align both the buttons. Please assign this issue to me under GSSoC22. Thank You
👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

@tarunsinghofficial Start working on it.

@devaaquib I am a GSSoC 2022 participant . I am interested in solving this issue and would like to solve it as soon as possible. Please assign it to me.

/assign

Hey everyone u want to work on this issue can u assign it to me


[AutoComplete] Fix bug where controlled component behaves uncontrolled

[x] PR has tests / docs demo, and is linted.
[x] Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
[x] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Thanks :)

Small note: This change broke our chip input component. In a patch update. :disappointed:

This was causing issues when I wanted to keep users from entering invalid characters, such as whitespace. All the workarounds I came up with were very hacky and didn't work well, so I figured I would fix the issue upstream by making the input component completely controlled.
@leMaik sorry for any inconvenience this caused.

Making this component controlled is a good thing! :+1: I probably shouldn't complain about breaking changes in the 0.x branch anyway.

@leMaik v0.x has never been very strict around semver. It's really hard this a UI lib. The API surface is very large. I avoid as much as possible breaking changes with v0.x. I was considering it fixings a wrong behavior. I wouldn't have accepted the PR otherwise.


Update index.html

Accomodation and location information added.

Hotel information added.

:sunrise:  Welcome to Github. :sunrise:
https://github.com/peger089

If you like, you can commit directly to the gh-pages branch (for this I don't get an email notification).
Making a pull request is mainly useful if something needs discussion or review (for pull requests I do get an email notification).

I've included this info in the document ...


Add --json option to bin/linguist

git-linguist requires the current directory to be a git repo, so it is not an option in my case. Thus adding machine-readable output to bin/linguist

@vmarkovtsev Thanks for your interest in Linguist!
Out of curiosity, what's your use case for this?

I am working at source{d} and among other things we are doing kind of GitHub mining. linguist is particularly used as the reference codebase preprocessor.

So you're calling the Linguist ruby gem from another language?

To be honest, JSON output would be very useful in cross-language data consumption.

Correct, I am calling it from Python.

@vmarkovtsev - as currently implemented though this still requires Rugged to be installed right?
What happens if Rugged doesn't detect a Git repository on this line.

@arton I guess the same as with --breakdown happens: it is used pretty the same way.

Anyone?

Merged manually. Thanks @vmarkovtsev 👍

Hurray!


Update oracle-reference-architecture.md

Latest updates to recommendations for Oracle on Azure.
Minor changes-  Updated to clearly state that RAC isn't supported in any third party cloud and updated a few terms to make more clear to non-Oracle focused readers.

#sign-off


Allow to skip the save post-step

This is similar to #474 - but improves on that by skipping the post (save) step entirely, saving tens of seconds on each run.
Fixes #350
Fixes #334

Thanks @domjtalbot.
Sure thing.
If we get a positive response from maintainers on pushing it in, I'd be happy to make that adjustment along with any others suggested.

I see this PR has gone through a first review by @joshmgross already. Will it be merged in the near future, or should use cases needing to skip the save step use e.g. a fork of this action?
Regarding using environment variable: I think this is a good choice, if my understanding is correct that previous steps in the job then can dynamically/during runtime instruct the cache action save/post step through https://docs.github.com/en/actions/reference/workflow-commands-for-github-actions#setting-an-environment-variable.
Thanks :slightly_smiling_face:

This looks wonderful; one question, if you don't mind. I have a very large cache (~750 MB), and when I have multiple PRs in progress, it appears that the 5GB cache gets filled up with those, and the cache from main gets pushed out. If I were to use this fork and set the option to skip the saving on the PRs but not on the main branch, this would keep the main cache as a base for the all of the PRs, right?

@joshmgross Can you please re-review/merge this? I'd like to use it and would prefer not to rely on a fork.

👋  Hey @zwass, the @actions/artifacts-actions team should be able to help out here.

@dhadka This is what I wanted #498 for, didn't see this PR though.
Right now cache will never be saved if the job fails.
Example: Spend 10mins building dependencies (succesfully) but a future job (such as failing a test) fails. Cache will not save!
Can we add something like:
env:
  CACHE_FORCE_SAVE: true

`post-if: success() && env.CACHE_SKIP_SAVE != 'true' || failed() && env.CACHE_FORCE_SAVE!= 'true'`

Perhaps @ollydev's request could be merged into this one with a single flag?
CACHE_SAVE=always - Always save regardless of errors in preceding steps.
CACHE_SAVE=never - Never save regardless of errors.
Not set - Default behavior (as before this PR).

failed() && env.CACHE_FORCE_SAVE == 'true': how cached content was generated successfully?  I think we need some mechanism to indicate that generating the cache content was successful, and then cache it immediately, why wait until the end of the workflow?

How does this work when you are using multiple cache actions in one workflow job?
I have a cache action for the caching node modules and I have another cache action for a benchmark build results.
If I understand this correctly, when I echo "CACHE_SKIP_SAVE=true" >> $GITHUB_ENV then it would prevent both the cache for the node modules and the cache for the benchmark to not save after the workflow is completed. Is that correct?  I really want to target one of the cache actions to not save (ex: don't save the benchmark cache unless the branch is main), not just blindly affect all of the cache saves.
It seems like there should be a better way for specifically preventing a single cache action from saving without all cache actions being prevented from caching?

@dakale @roni-frantchi Seems like this change is of interest to many users.
As we are not bringing this PR to conclusion downstream users are turning to use forks.
Would probably be a good idea to bring this to conclusion
Thanks!

@dakale I've addressed all of you comments - is there anything other request in this thread that you think must be taken care of in this PR before merging?
I would rather add any improvements later on and get this one going.

Is this going to get merged soon? The ability to skip the save post-step is something that will be very useful for our use case as well.

Any hope to get this merged

@roni-frantchi, is it possible for you to update the branch? It'd remove the deprecation warnings around save-state, set-output and Node.js 12 for those using the fork.

Dies ist ähnlich wie # 474 - verbessert dies jedoch, indem der (gespeicherte) Schritt vollständig übersprungen wird, wodurch bei jedem Lauf Dutzende von Sekunden gespart werden.post
Behebt #350 Behebt #334

Hey all, 👋🏽
We have created a discussion with a proposal that will solve this problem, do let us know your feedback, thanks 😊

Hey everyone 👋🏽
Two new actions actions/cache/restore and actions/cache/save are now available with tag v3 to everyone for use. These can now be used to achieve granular control on the restore and save steps in the cache action.
Do try them and let us know your feedback. We hope these new actions will take care of your use cases. 🙇🏽
Closing this PR now as we believe the new actions will take care of the same, feel free to reopen it or create an issue if need be.


After dropping a dragged item a delay occurs as the data does the sorting

A dataset of 300 records in a table using ui-sortable has a 3-4 second delay after the item being dragged is dropped that appears to be related to sorting the newly ordered data that prevents any actions from occurring until complete, which includes any further dragging and even scrolling the page.

Hi there. It might be the ng-repeat that's re-rendering that causes the issue. Are you using the track by statement in your ng-repeat and are you taking a unique property?

Hi @thgreasi, yah I'm using track by and using the unique database ID.  This is a snippet of the markup.

            {{ agency.sortorder }}

I'm experiencing a similar situation, has there been any resolution for this yet?

I created an example oen to demonstrate this, but I'm not usre how we can handle it.


[fud2] Fix planner so that it doesn't rely on the order operations are defined

There was a small bug with the planner where it would stop searching when a through op appeared anywhere in the ops map. It really should only stop if an op is one edge away from the current state. This worked before because I guess the ops map happened to be ordered in such a way where things worked.
Fixes #2209.

Belatedly, thanks for catching and fixing this, @sgpthomas!!


Can you provide the requirements file ?

Your ChatRWKV is damely good ! Can you provide the requirements file ? If possible you can provide the requirements for all your deep learning open source projects. That will make your model easier to use and decrease the difficulties for beginners. Thank you for your work!

requirements.txt is add


PWA-739: Fixed layering issue at product description links

removed zIndex avoid floating links above the AddToCartBar

Pull Request Test Coverage Report for Build 1122

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals

Change from base Build 1116:
0.0%

Covered Lines:
0

Relevant Lines:
5406

💛  - Coveralls


Allow custom board implementations for sx1261/2 and sx1276/7/8/9

Add custom board and chip types to allow users to implement external RadioKind and InterfaceVariant traits for a custom (perhaps proprietary) sx1261/2-based or sx1276/7/8/9-based LoRa board.  Use those implementations underneath the standard LoRa API.  For example:

let iv = ExternalInterfaceVariantImpl::new(...params...)
LoRa::new(ExternalRadioKindImpl::new(BoardType::CustomSx1261_2, spi, iv), ...other_params...)

This PR addresses Issue https://github.com/embassy-rs/lora-phy/issues/13.
Complete freedom to use a LoRa chip unknown to lora-phy will require a new major release, since the implementations of modulation and packet parameter creation contain logic specific to the radio kind, but is not currently implemented within the RadioKind trait.  An update to the RadioKind trait will necessitate a new major release.

Please let me merge this PR myself, once we agree on the solution.  I need to consider the order of releases to crates.io.


Getting more done in GitHub with ZenHub

Hola! @sjeeva has created a ZenHub account for the docker organization. ZenHub is the only project management tool integrated natively in GitHub – created specifically for fast-moving, software-driven teams.

How do I use ZenHub?
To get set up with ZenHub, all you have to do is download the browser extension and log in with your GitHub account. Once you do, you’ll get access to ZenHub’s complete feature-set immediately.
What can ZenHub do?
ZenHub adds a series of enhancements directly inside the GitHub UI:

Real-time, customizable task boards for GitHub issues;
Multi-Repository burndown charts, estimates, and velocity tracking based on GitHub Milestones;
Personal to-do lists and task prioritization;
Time-saving shortcuts – like a quick repo switcher, a “Move issue” button, and much more.

Add ZenHub to GitHub
Still curious? See more ZenHub features or read user reviews. This issue was written by your friendly ZenHub bot, posted by request from @sjeeva.

Yup, we know ZenHub


ImportError: No module named zipline in jupyter notebbok

Dear Zipline Maintainers,
Before I tell you about my issue, let me describe my environment:
Environment
packages in environment at /Users/zkid18/anaconda2/envs/env_zipline:
Name                    Version                   Build  Channel
alembic                   0.7.7                    py27_0    Quantopian
asn1crypto                0.24.0                   py27_0
bcolz                     0.12.1          np111py27h98fbfb4_0    Quantopian
blosc                     1.14.3               hd9629dc_0
bottleneck                1.2.1            py27h71f98a3_0
bzip2                     1.0.6                hd86a083_4
ca-certificates           2018.03.07                    0
certifi                   2018.4.16                py27_0
cffi                      1.11.5           py27h342bebf_0
chardet                   3.0.4            py27h2842e91_1
click                     6.7              py27h2b86a94_0
contextlib2               0.5.5            py27h9cb85f4_0
cryptography              2.2.2            py27h1de35cc_0
cyordereddict             0.2.2                    py27_0    Quantopian
cython                    0.28.2           py27h1de35cc_0
decorator                 4.3.0                    py27_0
empyrical                 0.3.2                    py27_0    Quantopian
enum34                    1.1.6            py27hf475452_1
hdf5                      1.10.1               ha036c08_1
idna                      2.6              py27hedea723_1
intel-openmp              2018.0.0                      8
intervaltree              2.1.0                    py27_0    Quantopian
ipaddress                 1.0.22                   py27_0
libcxx                    4.0.1                h579ed51_0
libcxxabi                 4.0.1                hebd6815_0
libedit                   3.1.20170329         hb402a30_2
libffi                    3.2.1                h475c297_4
libgfortran               3.0.1                h93005f0_2
logbook                   0.12.5                   py27_0    Quantopian
lru-dict                  1.1.4                    py27_0    Quantopian
lzo                       2.10                 h362108e_2
mako                      1.0.7            py27h07f8f8b_0
markupsafe                1.0              py27hd3c86fa_1
mkl                       2018.0.2                      1
multipledispatch          0.5.0                    py27_0
ncurses                   6.1                  h0a44026_0
networkx                  2.1                      py27_0
numexpr                   2.6.5            py27h057f876_0
numpy                     1.11.3           py27h8a80b8c_4
openssl                   1.0.2o               h26aff7b_0
pandas                    0.18.1              np111py27_0
pandas-datareader         0.5.0                    py27_0
patsy                     0.5.0                    py27_0
pip                       10.0.1                   py27_0
pycparser                 2.18             py27h0d28d88_1
pyopenssl                 17.5.0           py27hfda213f_0
pysocks                   1.6.8                    py27_0
pytables                  3.4.3            py27h5ca999c_0
python                    2.7.15               h138c1fe_0
python-dateutil           2.7.3                    py27_0
pytz                      2018.4                   py27_0
readline                  7.0                  hc1231fa_4
requests                  2.18.4           py27h9b2b37c_1
requests-file             1.4.3                    py27_0
requests-ftp              0.3.1                    py27_0
scipy                     1.1.0            py27hcaad992_0
setuptools                39.1.0                   py27_0
six                       1.11.0           py27h7252ba3_1
snappy                    1.1.7                he62c110_3
sortedcontainers          1.4.4                    py27_0    Quantopian
sqlalchemy                1.2.7            py27hb402a30_0
sqlite                    3.23.1               hf1716c9_0
statsmodels               0.9.0            py27h917ab60_0
tk                        8.6.7                h35a86e2_3
toolz                     0.9.0                    py27_0
urllib3                   1.22             py27hc3787e9_0
wheel                     0.31.1                   py27_0
zipline                   1.1.1               np111py27_0    Quantopian
zlib                      1.2.11               hf3cbc9b_2

Operating System: MacOS High Seria
Python Version: Python 2.7.13 :: Anaconda custom (x86_64)
Python Bitness: 64
How did you install Zipline: created a new conda environment
Python packages: $ pip freeze or $ conda list

Now that you know a little about me, let me tell you about the issue I am
having:
Description of Issue
I have installed zipline by creating a new conda environment
zipline run --help
works fine.
But when I decided to work in jupyter notebook (run jupyter notebook comand in cmd) I faced with a problem of importing zipline
%load_ext zipline
ImportError: No module named zipline
Same problem with
import zipline
ImportError: No module named zipline

What did you expect to happen?
I want to use zipline package in jupyter notebok
What happened instead?
ImportError: No module named zipline

Here is how you can reproduce this issue on your machine:
Reproduction Steps

Install zipline  by creating a new conda environment
Run jupyter notebook in cmd
%load_ext zipline
...

What steps have you taken to resolve this already?
I tried to install zipline using pip and conda using this instructions: http://www.zipline.io/install.html
Due to the conflicts with python libraries I had import errors, so I decided to create a new conda environment.
...
Anything else?
...
Sincerely,
Daniil

Hi @zkid18 my guess here is that because there is no jupyter module installed in your environment, conda is running Jupyter from the default conda installation. In your conda env, try running conda install jupyter or pip install jupyter, then confirm that it's in your env with conda list -n env-name.
If that works, then try running the notebook again.

Going to close this due to no follow-up from OP. Feel free to re-open if you're still having issue.

Hey I have run into the same issue today while installing in my OSX.
I have the enviroment on Conda, i have already check if it was a jupyter notebook thing, but even when i can run zipline in the cmd and see the different options i cant open it with juypter. I try installing it again but no luck