[WIP] Apply clang-tidy to lightning.qubit runtime

Context:
Catalyst should start conforming to clang-tidy. As a first step, we apply it to the files in the lightning runtime.
Note that this came about both as something we should do anyways, and as a concrete blocker to downstream lightning's catalyst interface to lightning repo (where clang tidy warnings as errors is enabled). We would like to fix all errors reported here.
Description of the Change:
Apply clang-tidy to lightning.qubit runtime.
The target files are those in runtime/lib/backend/lightning/lightning_dynamic.
Benefits:
Better adherence to clang rules.
[sc-77220]

Nice work, these files needed to be refactored because Lightning will be fetching the main branch at the moment. However, these very same files will be deleted once the LQ plugin is removed from Catalyst, so this effort will be lost.

I envision the following workflow:

This PR, fixing all errors in lightning's warnings-as-errors, gets merged to catalyst main. At this point, catalyst main has both the common files (like the common/Utils.hpp) and the lightning qubit files, all passing clang tidy.
Lightning PR https://github.com/PennyLaneAI/pennylane-lightning/pull/960 fetches catalyst main, and their CI's clang tidy no longer sees errors on the common files. For the lightning files, at this point I guess you would need to manually "cherry-pick" the changes here into your lightning PR (since they are in different repositories)?
Lightning merges their PR. From lightning's perspective, everything is done. They see common files by fetching catalyst's, and see lightning files in their own repo.
Catalyst merges PR and removes lightning files.

Thoughts?

Nice work, these files needed to be refactored because Lightning will be fetching the main branch at the moment. However, these very same files will be deleted once the LQ plugin is removed from Catalyst, so this effort will be lost.

I envision the following workflow:

This PR, fixing all errors in lightning's warnings-as-errors, gets merged to catalyst main. At this point, catalyst main has both the common files (like the common/Utils.hpp) and the lightning qubit files, all passing clang tidy.
Lightning PR Downstream LightningSimulator C++ API to the pennylane-lightning repository pennylane-lightning#960 fetches catalyst main, and their CI's clang tidy no longer sees errors on the common files. For the lightning files, at this point I guess you would need to manually "cherry-pick" the changes here into your lightning PR (since they are in different repositories)?
Lightning merges their PR. From lightning's perspective, everything is done. They see common files by fetching catalyst's, and see lightning files in their own repo.
Catalyst merges PR and removes lightning files.

Thoughts?

I was wrong, the effort is not lost, cause I will update the LQ plugin in Lightning with your changes. Thanks for clarifying that.
The workflow you envision seems correct to me, yes.

@rauletorresc So I think this is ready to go. In the past couple of commits, I did the following:

https://github.com/PennyLaneAI/catalyst/pull/1261/commits/b38c9a8e120e7471b634280f3c2d64c0f5fdd87c update runtime/.clang-tidy to the same configs as the .clang-tidy in lightning repository
https://github.com/PennyLaneAI/catalyst/pull/1261/commits/722621eb92d1bda54db64d1490a096753510240d enable clang-tidy warnings as errors in catalyst runtime builds
https://github.com/PennyLaneAI/catalyst/pull/1261/commits/1e82397e88cc2970ea48bee9dd335897342461ba Skip openqasm backend builds in CI, since we are only tidying lightning runtime here, so that we don't block ourselves with the warnings-as-errors from openqasm backend
Apply clang tidy suggestions

This is the status of https://github.com/PennyLaneAI/catalyst/pull/1261/commits/690e3dcfd1d1e0637b2dd550b0ac8e287d2bf965. At this point, CI will build lightning runtime, with clang-tidy enabled, and not build openqasm. Runtime builds (with warnings as errors enabled) and tests all succeed. All failing frontend tests are because openqasm backend is not built.
At this point, all the lightning files should be clang-tidy-ed, according to lightning repo's clang tidy config.
If we are good with this, I will:

Turn off clang-tidy in catalyst CI
Turn back on openqasm builds in catalyst CI
since catalyst repo as a whole is not ready for clang-tidy yet.

cc @mlxd


feat: update the Places Demo with a map to show the current place

Please merge in changes from #14

These changes are already on this branch from https://github.com/googlemaps-samples/codelab-places-101-android-kotlin/pull/13/commits/63775da3be75608017a4e7ed4fc758b458795667.
No additional work required.


Migrate CircleCI to V2

The current version of config that Prometheus uses for CircleCI (V1) is being deprecated.
https://circleci.com/blog/sunsetting-1-0/
We should migrate this to use the V2 config prior to the deprecation date.

yep , that is a good idea. Can you open a PR?
here is the commit that was done for the node_exporter , probably can do a lot of copy and paste form there.
https://github.com/prometheus/node_exporter/commit/65e485c4e926083c8cb4baf36a8d80d16a963421

Yepp, no problem. I should have some time over the day or so to get something pulled together.

Some work are being done on CircleCI v2 on the node_exporter project. When they will be stabilized, we will do the move on all Prometheus projects.

@sdurrheimer are you saying that it is best to wait until the one done in node_exporter is stable?

@krasi-georgiev It's probably better yes.

Fixed by #4106


bleutooth: add ble tx power configuration

Allow bluetooth controller to be initialized with
default custom tx power level.

commit and PR name (nit) -> bleutooth

Folks, I update the PR, PTAL again.


Contains Duplicate Day #

I solved tomorrow question also but not able to commit by mistake

I solved tomorrow question also but not able to commit by mistake

You need to solve only one problem for the day


Leave Qt version up to users

Currently CMakeLists.txt tries to find Qt6 and eventually falls back to Qt5.13 in case 6 isn't available.
# Find the QtWidgets library
find_package(Qt6
  COMPONENTS
   Core
   Widgets
   Gui
   OpenGL
)

if (NOT Qt6_FOUND)
  find_package(Qt5 5.13
    COMPONENTS
     Core
     Widgets
     Gui
     OpenGL
  )
endif()

This is an issue on machines were both, Qt6 and 5, are installed. There is no way to force nodeeditor to link against Qt5 if Qt6 is also found on the system. Maybe it would be a good idea to first check if Qt6 or Qt5 has already been added as dependency?
# Find the QtWidgets library
macro(find_qt6)
  find_package(Qt6 COMPONENTS Core Widgets Gui OpenGL)
endmacro()
macro(find_qt5)
  find_package(Qt5 5.13 COMPONENTS  Core Widgets Gui OpenGL)
endmacro()

if(Qt6_FOUND)
  find_qt6()
elseif(Qt5_FOUND)
  find_qt5()
elseif(NOT Qt6_FOUND AND NOT Qt5_FOUND)
  find_qt6()
  if(NOT Qt6_FOUND)
    find_qt5()
  endif()
endif()

Also on machines with just Qt5 the project actually fails to build claiming it cannot find Qt6.

Hi @aleksandaratanasov ,
yes, the version selection was implemented quick and dirty. I'll try to merge @Yadunund 's branch soon.


Log select/exclude arguments with invocations

Describe the feature
It would be useful to log run select/exclude arguments. For example, if the following commands were run:
# run a single model
dbt run --select mymodel

# run a single tag
dbt run --select tag:mytag

# run a single tag with an exclude
dbt run --select tag:mytag --exclude no_not_that_model

Then it would be nice if the select and exclude arguments were logged as well. For example:

invocation_id
event_name
select
exclude

1
run started
mymodel
null

2
run started
tag:mytag
null

3
run started
tag:mytag
no_not_that_model

Of course, the columns should probably not be SQL keywords, but the exact column name wording is probably out of scope the request.
Describe alternatives you've considered
It might be possible to use a pre-hook to fetch that information an insert record in a table somewhere in the database. However, there are some downsides:

This would be cumbersome
It's unclear if this should go into the existing dbt_meta.dbt_audit_log table
This fits thematically with the logging package

Additional context
When there are potentially multiple DBT jobs running, it can be difficult to pin point which job is related to which invocation. Logging the select/exclude arguments would make it easier to tie the logging to a particular job.
Who will this benefit?
People who have multiple DBT runs every day that target different tags/models.

Issue closed to prepare for Repository Archival


Adding test type buttons for the launch, test stats for the suite

Test version to see if it's usable/makes sense.
Buttons  on the launch to go directly to the test suite:
Number of failed/passed tests on the suite level:

Hey @opishcheiko I was just trying this branch locally and looks like there is problem in the backend, with the api/v1/launch/project/ endpoint, looks like the endpoint is returning just one of the tesruns...
Here for the launch 17, we should return data for test runs 18 and 20...

But instead, we are just returning test run 18

I'll take a look at it today 😃

I'll take a look at it today 😃
Thanks @Jnegrier

I'll take a look at it today 😃
Thanks @Jnegrier

Fixed it, the frontend looks amazing!

Will create the PR for the backend now, thanks @opishcheiko

made the rows thiner


Expense Authority - Registry addition

Describe the issue
As a platform administrator, I want project sets to have a mandatory "Expense Authority" contact field, so that billing emails and cost recovery billing reports can automatically include that contact information.
Rational/Why
This will help automate quarterly billing reports - the current state involves a manual contact retrieval which takes a lot of time and allows for errors - as well as communicate billing information to that contact.
Additional Context

Link to the code repositories
List of technologies that may be expected to be known in order to work on the task
Clear description of where the code change is going, e.g "add the text input to the create request form in components/request.js"
Clearly identify which products are being updated ("Platform Services Registry")

Dependencies

Internal, external, who to talk to if more information is needed

Tests
Definition of done/Acceptance Criteria

When creating a new project set, an "Expense Authority" field must be filled out, similarly to the Product Owner and Technical Lead fields.
That contact can't view nor log into the registry.
That contact is connected to an IDIR.
That contact can't be deleted, only edited (in case the person changed).
Billing emails are sent to that contact
That field and contact information must be retrievable for automated reporting purposes (Quarterly billing report). Contact info are: First Name, Last Name, Email.

Billing emails not sent to expense authority


Point (0,0) appears falsely in pixel coordinates when using skeleton_to_csgraph

When we take a look at the attached image, we can observe that in the upper left corner no line/branch is present. Nevertheless with the following code the coordinates list contains the point (0,0) within the pixel coordinates, which for my understanding shouldn't be. I also think that such a behavior is not documented in the docs, although there it says that pixel_coordinates is an array of shape (Nnz + 1, skel.ndim). Is this +1 mentioned there the point (0,0)?
import numpy as np
import matplotlib.pyplot as plt
from skimage import io
from skan import skeleton_to_csgraph

sk = io.imread('https://user-images.githubusercontent.com/60721219/90833952-67b11e00-e349-11ea-9e4b-c2ea9ae8c426.png').astype(bool)

plt.figure()
plt.imshow(sk)

graph, pixel_coordinates, degree_image = skeleton_to_csgraph(sk)

I'm using version Skan version: 0.8 installed from conda.

@theo258 apologies for the delay in responding!
Yes, this is the +1. Indeed if that point was actually part of the skeleton it would appear twice.
The reason is that the pixels in the skeleton are numbered 1..Nnz, and we want to use them to index directly into the coordinates.
Possibly, it's best to produce a number -> index map and then have exactly those coordinates in the coordinates array. scikit-image 0.17 has a new map_array function that could make this very fast. In the meantime, it might be useful to document this behaviour.
I would welcome a pull request to fix these things if you have the bandwidth, otherwise, I'll try to get to it soon. Thanks for reporting!


Git Commit trying to spawn ssh?

In the Git section, I have my file that I just updated, and now I want to commit locally, I click the little check mark, and I get the little clock icon, and now I'm waiting forever. I check the log and have lots of this:
git fetch
error: cannot spawn ssh: No such file or directory
fatal: unable to fork
git fetch
error: cannot spawn ssh: No such file or directory
fatal: unable to fork
git fetch
error: cannot spawn ssh: No such file or directory
fatal: unable to fork
git fetch
error: cannot spawn ssh: No such file or directory
fatal: unable to fork
git fetch
Maybe I don't understand the process, but when I want to commit locally, why would it do these other things? And now I'm waiting forever for it to release...restarting the app doesn't help. But it did commit the change locally, without telling me.
This is on Windows 7...not sure what else might be needed to address this issue.

git fetch is a background task that runs independently of the commit action.
So, to recap: you click commit and it stays spinning forever while actually committing successfully.

Yes. It commits locally successfully, but VSCode is waiting on git to do to other things I didn't ask git to do (intentionally, anyway).

VSC tries to access my remote git repositories without my knowledge.
When I start it in a git directory, using "code .", I am prompted for my RSA key passphrase:
Enter passphrase for key '{home}/.ssh/id_rsa':
where {home} is my home directory.
If I search for 'ssh' in the process stack, I find:
ssh {host} git-upload-pack '{repo.git}'
where {host} and {repo.git} are the host and path of my remote origin git repository.
The first few times I ran it, I had already put my key to ssh-agent, so VSC quietly accessed my remote server without needing the passphrase.
I don't feel comfortable with VSC running ssh commands on my remote server, without my permission.  It should at least have a preference to turn this off.
VSC Linux X64 stable:
Version 0.10.11
Commit f291f4ad600767626b24a4b15816b04bee9a3049
Date 2016-03-11T16:19:03.130Z
Shell 0.35.6
Renderer 45.0.2454.85
Node 4.1.1

The setting "git.autofetch": false will disable this.


internal_ci: rename grpc_xds_k8s to psm-security as part of tech-debt cleanup and name clarity (backport 1.42.x)(#28034)

This one too is stuck in
Portability Tests Windows [Build Only] (internal CI) Expected — Waiting for status to be reported

@srini100 this one also needs to be merged by an authorized user


Feature request: Show packages that depend on a package

Today I want to curious to see which PyPI packages depend on mor-itertools. I hoped PyPI would have a link to that information from the more-itertools page, but nope. I know GitHub provides that information, but I trust PyPI's database better.

Thanks for the feature request. This is a duplicate of https://github.com/pypa/warehouse/issues/789.
(I'll also add that this is challenging to get right, see https://dustingram.com/articles/2018/03/05/why-pypi-doesnt-know-dependencies/)


ReloadData() when using Disk Caching causes Image flickering

Check List
Thanks for considering to open an issue. Before you submit your issue, please confirm these boxes are checked.

[x] I have read the wiki page and cheat sheet, but there is no information I need.
[x] I have searched in existing issues, but did not find a same one.
[x] I want to report a problem instead of asking a question. It'd better to use kingfisher tag in Stack Overflow to ask a question.

Issue Description
What
I have implement disk caching using
ImageCache.default.memoryStorage.config.totalCostLimit = 1
It successfully stores all images in disk cache but when i try to reloadData(), it flickers which looks weird,
it doesn't happen when using memory caching but, cant use it cause i am dealing lots of images.
Can someone please provide me with any solution.

I have implement disk caching using
ImageCache.default.memoryStorage.config.totalCostLimit = 1
It successfully stores all images in disk cache but when i try to reloadData(), it flickers which looks weird,
it doesn't happen when using memory caching but, cant use it cause i am dealing lots of images.
Can someone please provide me with any solution.

I have implement disk caching using
ImageCache.default.memoryStorage.config.totalCostLimit = 1
It successfully stores all images in disk cache but when i try to reloadData(), it flickers which looks weird,
it doesn't happen when using memory caching but, cant use it cause i am dealing lots of images.
Can someone please provide me with any solution.

@onevcat

@onevcat can you please check this issue

https://github.com/onevcat/Kingfisher/issues/1377

Thank you for your reply,  i have gone through this solution.... but it wont work since, i am dealing with lot of images(e-commerce application) and i have infinite scrolling. Is there any solution for it besides this or any workaround?.

I think it should be fine if you are using a table view or collection view, with limited reused cells. Only the cells on the screen will be reloaded so the performance should be fine in most time.

Actually, the image size which i am dealing with is large, i guess i have to setup expiry time or clear the cache to resolve this issue. If you are able to find a way out will be really appreciated. @onevcat


46972299 - Improved 3D Unet for Segmenting HipMRI 3D Prostate MRI Dataset

Task 4 - Hard Difficulty. This project uses the Improved 3D Unet deep learning model to segment and classify components of the HipMRI 3D Prostate MRI scans, considering 6 classes: background, bone, bladder, rectum, and prostate. This pull request contains the relevant files used to train, validate, and test the model, with a report description on usage, architecture explanation, and outcomes.
All files added are inside a folder 46972299_ImprovedUnet inside the recognition folder. Files inside include:

dataset.py includes the data loader and dataset objects that automatically load the images and masks and apply relevant transformations and data splits.
modules.py contains the classes and actual architecture of the improved 3D Unet model.
metrics.py includes classes for calculating loss metrics and accuracy.
train.py is a script for running the training process and saving the model results.
predict.py is a script for testing a trained (or even unfinished) model to analyse its performance and visualisate its results and metrics.
utils.py contains provided code from the task and miscellaneous plotting and saving functions.
report_files folder containing images used in the report
README.md report as explained above.

This is an initial inspection, no action is required at this point
Recognition problem: total 8 Marks
Problem solving: (1)
•	Segmentation results are outputted but with poor segmentation performance.
•	Average Dice loss was above 0.5 for all classes, representing a maximum Dice score of 0.5 for all labels.
Algorithm implementation: (3)
•	Algorithm implemented in PyTorch for the improved UNet3D model and functions.
Design: Good coding design (1)
Commenting: Sufficient comments throughout the code (1)
Difficulty:  (2)
•	3D Improved UNet – Hard
•	Problem attempted but not solved

Marking

Good/OK/Fair Practice (Design/Commenting, TF/Torch Usage)
Good design and implementation.
Spacing and comments.
Header blocks.
Recognition Problem
OK solution to problem. Segmentation results are outputted but with poor segmentation performance.-3
Driver Script present.
File structure present.
Good Usage & Demo & Visualisation & Data usage.
Module present.
Commenting present.
No Data leakage found.
Difficulty : Hard. UNet3D (Hard Difficulty)
Commit Log
Good Meaningful commit messages.
Good Progressive commits.
Documentation
Readme :Good.
Model/technical explanation :Good.
Description and Comments :Good.
Markdown used and PDF submitted. PDF checked.
Pull Request
Successful Pull Request (Working Algorithm Delivered on Time in Correct Branch). On time submission.
No Feedback required.
Request Description is good.
TOTAL-3

Marked as per the due date and changes after which aren't necessarily allowed to contribute to grade for fairness.
Subject to approval from Shakes

Carl Flottmann

Segmentations not one hot encoded -2 additionally, results quality low -1


Update to better interface

I'm not 100% sure that this is ready to merge yet (want to poke more at some of the new code and add docs, etc.)
But it's a new interface to the library that really simplifies things people would want to do.
Let me take another week or so to see what I can clean up and then look into merging it.

@sjkelly I'm planning to merge this soon... let me know if you want to review it at all... there's a lot of code changes as the interface is totally new. And lots of other helpful routines.

It looks good to me! I haven't gotten a chance to run more tests, but I think it would be good to register a 0.1 for people to try it out :)


Level 1 > Encryption password:History page is showing different heading and text.

I had selected the app generated password.But on level 1 history page it is showing "Encryption password" as a heading and content on history page is "Security Question created" and "Security Questions confirmed".It should be same as what ever was used for encryption

Closing as we're not doing levels anymore


(user) images being referenced hardcoded through localhost

Laravel Version: 5.4.13
Voyager Version: tcg/voyager (dev-master e3af559)
PHP Version: PHP 7.0.6 (cli) (built: Apr 29 2016 04:21:39) ( NTS )
Database Driver & Version: 10.1.21-MariaDB Homebrew

Description:
images - at least user images - seem to be referenced hardcoded, example:
http://localhost/storage/users/February2017/h57fkMK3sy53wtaqpn7M.png

however, my current setup runs on valet, so I do have a dev-domain like
http://voyager.dev/

naturally, the web server (Caddy in this case, running on valet 1.1.22) can't find this resource as it would have to be referenced similar to this I guess:
http://voyager.dev/storage/users/February2017/h57fkMK3sy53wtaqpn7M.png

I guess
Steps To Reproduce:

install laravel 5.4 through composer
add the repository and require ('dev-master') to composer.json
head your browser to http://your-domain.dev/admin
I only see a broken image in the upper left and upper right corner
uploading is working without an error, however the pics will not show up afterwards (note also that the avatar does not show up in the table)

pics missing:

failed requests:

If you change APP_URL to current path in .env . To me, I used builtin web server
http://localhost:8000 as the APP_URL then it works.
APP_URL = http://localhost:8000

Prefect, that did the trick, thank you, closing it.


🌐 Add Portuguese translation for docs/pt/docs/tutorial/query-params.md

Portuguese translation for tutorial/query-params.md.
There is another pull request for the Portuguese translation of this same page. But it hasn't been updated for about seven months. So I found it feasible to create a new pull request for the translation to be done.

Great, thank you @batlopes! :rocket:
And thanks for the reviews @cassiobotaro, @jonatasoli, @ComicShrimp, @lsglucas! :cake:


how to use seata 0.5.0?

how to use seata 0.5.0?
seata-server.bat  running error :
2019-04-21 19:37:34.367 INFO [main]io.seata.common.loader.EnhancedServiceLoader.loadFile:193 -load ConfigurationProvider[Nacos] extension by class[io.seata.config.nacos.NacosConfigurationProvider]
Exception in thread "main" java.lang.ExceptionInInitializerError
at io.seata.core.rpc.netty.RpcServer.(RpcServer.java:87)
at io.seata.server.Server.main(Server.java:54)
Caused by: java.lang.NullPointerException: Name is null
at java.lang.Enum.valueOf(Enum.java:236)
at io.seata.core.rpc.netty.TransportProtocolType.valueOf(TransportProtocolType.java:25)
at io.seata.core.rpc.netty.NettyBaseConfig.(NettyBaseConfig.java:114)
... 2 more

pom 里面手动加一下  seata-config-nacos的包依赖

Manually add seata-config-naco dependency to the pom.xml

Same problem here.
@zhangthen What did you mean by add a dependency? There is no pom.xml in the release package.

Same problem here too!

What is the value of "transport.type" ?
Must be one of  TransportProtocolType.

Same problem here ，but there is no pom.xml in the release package.

@misvcom @publisherfk @mostcool @warrior2005 please make sure you have initialized the configs in nacos.please use
sh nacos-config.sh localhost
to initialize the configs in Nacos.
If you are using Seata for the first time, it is recommended that you use the file-based registry and configuration center directly.

@misvcom @publisherfk @mostcool @warrior2005 please make sure you have initialized the configs in nacos.please use
sh nacos-config.sh localhost
to initialize the configs in Nacos.
For quick start of seata, it is recommended that you use the file-based registry and configuration center directly.

Why not provide .bat file?

@misvcom @publisherfk @mostcool @warrior2005 please make sure you have initialized the configs in nacos.please use
sh nacos-config.sh localhost
to initialize the configs in Nacos.
For quick start of seata, it is recommended that you use the file-based registry and configuration center directly.

However, it was not mentioned in the "Quick Start" page.

sorry for lack of documentation.if you use file based registry and configuration,everything should be fine.

Manually add seata-config-naco dependency to the pom.xml

Same problem here.
@zhangthen What did you mean by add a dependency? There is no pom.xml in the release package.

@zhangthen means if you use nacos as your configuration center，then you have to add seata-config-nacos in your application's pom.xml (if you manage your dependency by maven).not add any thing in the seata server side.

sorry for lack of documentation.if you use file based registry and configuration,everything should be fine.

Run up on "seata-samples" project, thx.

1.which project to add dependency  seata-config-naco  (seata-server-0.5.0 or my project  )? i added both but  it not worked.
2.besides i use sh nacos-config.sh localhost to initialized the configs , allows show  "Failed to connect to localhost port 8848: Connection refused"  .  should i start some seata-serve first?
3.Hope to be answered   thanks!

https://user-images.githubusercontent.com/22902512/56825915-3f1c2f80-688d-11e9-9620-a80b9e6a62ec.png

windows 下执行报错：

@mark988 you have to import the configurations to Nacos before you start seata server.pls refer to https://github.com/seata/seata-workshop

------------------ 原始邮件 ------------------
发件人<EMAIL_ADDRESS>发送时间: 2019年4月27日(星期六) 凌晨2:24
收件人<EMAIL_ADDRESS>抄送<EMAIL_ADDRESS><EMAIL_ADDRESS>主题: Re: [seata/seata] how to use seata 0.5.0? (#864)
https://user-images.githubusercontent.com/22902512/56825915-3f1c2f80-688d-11e9-9620-a80b9e6a62ec.png
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
Thank you very much. I've solved this problem. Instead of using nacos, I changed the type in the registy.conf type="nacos" to type="file". it's worked!

i have the same problem, until i change the server from 0.5.0.zip to an application based on the newest code of branch 0.5.0.
i don't know why
all my seata store type is file.(client&server)
➜  seata git:(95deba8) git status
HEAD detached at 0.5.0
nothing to commit, working tree clean

windows 下执行报错：

和你报一样的错误 windows下 下载 https://github.com/seata/seata/releases/tag/0.5.0 这个server

@sanwancoder please set the value of registry.type and config,type to file.

@sanwancoder please set the value of registry.type and config,type to file.

首先谢谢你的回复，一定得在idea下执行吗？
谢谢 我直接下载包的  解压后设置了 依然会报错
windows下cmd下执行 bat文件

Same problem here ，but there is no pom.xml in the release package.

在下载的release版本中，增加pom.xml可以解决问题吗？

使用如下文件registry.conf 即可
registry {
file 、nacos 、eureka、redis、zk、consul
type = "file"
nacos {
serverAddr = "localhost"
namespace = "public"
cluster = "default"
}
eureka {
serviceUrl = "http://localhost:1001/eureka"
application = "default"
weight = "1"
}
redis {
serverAddr = "localhost:6379"
db = "0"
}
zk {
cluster = "default"
serverAddr = "<IP_ADDRESS>:2181"
session.timeout = 6000
connect.timeout = 2000
}
consul {
cluster = "default"
serverAddr = "<IP_ADDRESS>:8500"
}
file {
name = "file.conf"
}
}
config {
file、nacos 、apollo、zk
type = "file"
nacos {
serverAddr = "localhost"
namespace = "public"
cluster = "default"
}
apollo {
app.id = "seata-server"
apollo.meta = "http://<IP_ADDRESS>:8801"
}
zk {
serverAddr = "<IP_ADDRESS>:2181"
session.timeout = 6000
connect.timeout = 2000
}
file {
name = "file.conf"
}
}

@sanwancoder please set the value of registry.type and config,type to file.

thank u

I will close this issue,if you have further question about this issue,please comment here.thank you!


Feature/lu 10/implement topic manager

Related Ticket

LU 10

Description
This PR contains the implementation class for topic management.
Type of Change
Put an x in all the boxes that apply:

[X] ✨ New Feature (non-breaking change which adds functionality)
[ ] 🛠 Bug Fix (non-breaking change which fixes an issue)
[ ] ❌ Breaking Change (fix or feature that would cause existing functionality to change)
[ ] 🧹 Code Refactor
[ ] ✅ Build Configuration Change
[ ] 📝 Documentation
[ ] 🗑 Chore

Pull Request Checklist
Put an x in all the boxes that apply:

[x] My commit messages are detailed.
[x] My code follows the code style of this project.
[x] No existing features have been broken without good reason.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests pass.

Don't forget to update also your PR title using our convention, otherwise pipelines won't let you pass.


Revert "makefile fixes"

Reverts openshift/ingress-node-firewall#112

make test failed with this changes I will revert them for now

/lgtm


Addressing issue with single output from node being an array

Fix for issue #4

Thanks for the PR, Marc. It fails the tests because of the use of numpy and this line. I would like to limit the dependencies if not absolutely needed, so I pushed this pure Python alternative. Let me know if it works, I like your use of squeeze as it may be a more global solution that cover cases I am not really seeing right now.

Ok, I just saw that you created a whole new PR for this.
Because I'm importing functions from another package, I do need to squeeze the returned values for the dag to work. But no need to add a dependency on numpy indeed, I just created a decorating function in my script that wraps the imported functions to squeeze their results.
Also, I think that it may be a little harsh to raise an exception when an input is not used, but I can see arguments for having it also. So no worries.
I'm closing this PR in favor of your solution.
Thanks


Better Communicate Actions: Assign Reviewers

[x] Assign reviewers button only shows if the submission does not have all reviewer roles assigned and is in internal review
[x] Assign reviewers button appears when it is in the external review stage
[x] Staff will always see 'update reviewers' in the reviews box, uses secondary button styling

From #1851

@abigail-hampson this is ready for testing

@abigail-hampson sorry wrong one!

@abigail-hampson okay, this is now ready for testing

Looks good to me, over to OTF for testing - an example of where this can be tested is here - https://test-apply.opentech.fund/apply/submissions/37/

In this test application: https://test-apply.opentech.fund/apply/submissions/222/
I click on the 'Assign Reviewers' button and the Update Reviewers pop-up shows no reviewers have been assigned. This feature is misleading because the names of reviewers are not shown, the reality is that  one review has already been submitted to this application:

@fourthletter thanks for testing this. The 'Assign / Update Reviewers' pop-up is existing functionality. This ticket is concerned with adding the 'Assign Reviewers' primary action when the application has a specific state. Currently any user with the staff role is able to add a review to any application but there can be two users who are assigned as 'Primary Reviewer' or 'Secondary Reviewer'. The 'Assign Reviewers' primary action is shown when the application is in the 'Internal Review' phase and when either of the reviewer roles haven't yet been assigned.

@fourthletter Works well in my testing. But is it not in status "Screening" the "Assign reviewers" button should show?
When a submission reach "Internal review" reviewers are normally assigned already, is that not so?
P.S. There are action in place to move a submission from "Screening" to "Internal review" when two staff reviewers have been assigned.

Acceptance criteria were visible and functional during test. Thank. you! 💥


Use the refresh token to refresh your MSO session, instead of requiring a re-auth

Done in https://github.com/mworzala/mc-cli/commit/da31c64308383fea1e4e5ff5f72416dab2d6ecfe


Update README.md

Hi There,
I hope you're well! I noticed a small spelling mistake in your README so I went ahead and fixed it for you.
Love the project, keep up the good work!
Kind regards,
Tim
Signed-off-by: Tim Richards<EMAIL_ADDRESS>

Thanks for making us correct, your work is appreciated ❤


Fix preprocessor condition for sys/syscall.h

RTM_PLATFORM_PS4 is always defined - it will either be 0 or 1.
Fix the conditional in inc/thread.h to reflect that.

Thanks!


Responsiveness Issues on Smaller Screens

Description:
When the application is viewed on screens smaller than 768px, the layout breaks, causing the navigation bar to overflow and the content to overlap. The page is not responsive to mobile and tablet views, significantly affecting user experience.
Expected Behavior:
The layout should adjust dynamically to different screen sizes, ensuring the app is usable on all devices.
Proposed Solution:
I can address these responsiveness issues by implementing CSS media queries to ensure that the layout adapts correctly to various screen sizes. I would utilize a mobile-first design approach to improve compatibility and user experience across devices.
Request for Assignment:
Please assign this issue to me, and I will work on implementing the necessary changes to enhance the application's responsiveness.

Could you please assign this issue to me under GSSOC'24 extd and Hacktoberfest?
I would like to work on this app to make it responsive and make it more user-friendly . Thanks!

@SurajSakhare100 This issue is due to the unresponsive navbar. Another contributor is working on it.
Issue: #43

I'm not talking about making the navbar responsive, but I've made the entire homepage responsive with some UI updates. I'd also like to contribute to open-source, so please assign this task to me.

@SurajSakhare100 The home page was already responsive, but it became unresponsive due to the navbar.


Expose metadata profileId

See https://github.com/quiltt/quiltt/pull/6453 and https://quiltt.slack.com/archives/C05EYQVE63B/p1699465294595049

Going to do this when https://github.com/quiltt/quiltt/pull/6453 is merged, easier this way.


AttributeError: 'WindowsPath' object has no attribute 'rstrip'

On two windows computer, python 3.8, updating to the latest pymodaq version throws an error when launching dashboard (AttributeError: 'WindowsPath' object has no attribute 'rstrip').
Edit : I thought updating to setuptools>60.0.0 fixed it but it looks like it doesn't always work. Will do more testing to figure it out.
This issue can be deleted for now.

I think this issue is related to an error between usage of a path as a WindowsPath (see pathlib package) (for which rstrip is nto available) and a path as a string (for which rstrip is available). Could you print the details of the log to see where the issue comes from?

Sure! With pymodaq==3.5.2, launching dashboard :
Traceback (most recent call last):
File "c:\miniconda\envs\manip\lib\site-packages\pkg_resources_init_.py", line 2191, in _handle_ns
loader = importer.find_spec(packageName).loader
File "", line 1391, in find_spec
File "", line 59, in _path_join
File "", line 59, in
AttributeError: 'WindowsPath' object has no attribute 'rstrip'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "c:\miniconda\envs\manip\lib\runpy.py", line 193, in run_module_as_main
"main", mod_spec)
File "c:\miniconda\envs\manip\lib\runpy.py", line 85, in run_code
exec(code, run_globals)
File "C:\Miniconda\envs\manip\Scripts\dashboard.exe_main.py", line 4, in
File "c:\miniconda\envs\manip\lib\site-packages\pymodaq\dashboard.py", line 40, in
from pymodaq_plugin_manager.manager import PluginManager
File "c:\miniconda\envs\manip\lib\site-packages\pymodaq_plugin_manager\manager.py", line 9, in
from pymodaq_plugin_manager.validate import validate_json_plugin_list, get_plugins, get_plugin, get_check_repo,
File "c:\miniconda\envs\manip\lib\site-packages\pymodaq_plugin_manager\validate.py", line 6, in
import pkg_resources
File "c:\miniconda\envs\manip\lib\site-packages\pkg_resources_init.py", line 3238, in
@call_aside
File "c:\miniconda\envs\manip\lib\site-packages\pkg_resources_init.py", line 3222, in call_aside
f(*args, **kwargs)
File "c:\miniconda\envs\manip\lib\site-packages\pkg_resources_init.py", line 3266, in initialize_master_working_set
for dist in working_set
File "c:\miniconda\envs\manip\lib\site-packages\pkg_resources_init.py", line 3266, in
for dist in working_set
File "c:\miniconda\envs\manip\lib\site-packages\pkg_resources_init_.py", line 2780, in activate
declare_namespace(pkg)
File "c:\miniconda\envs\manip\lib\site-packages\pkg_resources_init_.py", line 2279, in declare_namespace
handle_ns(packageName, path_item)
File "c:\miniconda\envs\manip\lib\site-packages\pkg_resources_init.py", line 2196, in _handle_ns
loader = importer.find_module(packageName)
File "", line 431, in _find_module_shim
File "", line 1346, in find_loader
File "", line 1391, in find_spec
File "", line 59, in _path_join
File "", line 59, in
AttributeError: 'WindowsPath' object has no attribute 'rstrip'

related also wit #70 should be fine with requirement on setuptools version in 3.5.3 version of PyMoDAQ

Hi, I was wondering whether you fixed the problem or not, cause I'm having the same problem:( How did you fix that eventually?


GCN on multiple graphs

Hi,
I have a dataset of invoices with each node being each word in the document labeled to the category it belongs to, example - 02/12/2019 is labeled as due_date, $12,000 as total_price, etc.
Here, one invoice page forms a graph. I have 168 such graphs with their adjacency matrix and feature matrix.
How do I prepare the dataset for GCN training using all these graphs?

For batch-wise training with multiple graphs, please have a look here:
https://github.com/tkipf/gcn/issues/4
On Thu 4. Jun 2020 at 09:42 Monica Tare<EMAIL_ADDRESS>wrote:

Hi,
I have a dataset of invoices with each node being each word in the
document labeled to the category it belongs to, example - 02/12/2019 is
labeled as due_date, $12,000 as total_price, etc.
Here, one invoice page forms a graph. I have 168 such graphs with their
adjacency matrix and feature matrix.
How do I prepare the dataset for GCN training using all these graphs?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/tkipf/keras-gcn/issues/61, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABYBYYAPTDTL7ABGRV2EL4TRU5F6BANCNFSM4NSLSFCQ
.

Thanks for the reply. In my case, block diagonal input seems applicable. Do I just concatenate the feature matric one below the other?

@mon28 did you have the answer for this problem ? can you give me the solution for this ?
Thanks


Rendering components with a number in the name fail silently

Bug Report
Describe the bug
If you import like this: import { H1 } from './H1' and try to render
Title
, it won't render anything and won't show any error.
If you remove the number like this  import { H1 as HH } from './HH' and try to render <HH>Title</HH>, it renders correctly.
Maybe it's a bug in mdx itself?
To Reproduce
---
name: Typography
---

import { H1 } from './H1'

# H1

Title example

export const H1 = props => (
  <Text
    {...props}
  />
)

In order to allow us to quickly reproduce you issue please include a link to a reproduction repository.
Expected behavior
Render component normally or at least show an error message about the limitation
Environment

OS: macOS 10.14
Node/npm version: Node 8/npm 5

Additional context/Screenshots

For sure @brunolemos, I tried to debug to see if something related to docz, but I think that this is a bug related to the mdx parser 😕

It probably is, but can we at least find out if the mdx parser project has registered it and then reference it here?

took a while for me to figure it out as well as it is weird.
this is my work around for now.. if you need to use it in the MD then use as and rename it. For actual example usage just use <Playground/> no issues.
import { Playground, Props } from 'docz'
import { H1 } from './index'
import { H1 as HeadingOne } from './index'
import Text from '../text'

# Heading

Hello there
<HeadingOne>This is H1 heading</HeadingOne>

## Basic usage
<Playground>

This is H1 heading

</Playground>


Excit Integration: Iterators and Tiling Iterators

In GitLab by @perarnau on Apr 7, 2020, 13:34

embed excit inside aml (git submodule)
design a new tiling iterator interface based on it
validate on old benchmarks (MCHPC19)

Related to #21.
Might be blocked by #51
Integrating Excit
Choice between submodule and external dependency: submodule is easier for development.
Tiling Iterator API
First design choice: tiling iterator object or just a way to retrieve a retrieve a tile using an iterator state as input ?

object
tiling method

pros
"hide" excit from the user
simple implementation

cons
pretty much need an entire building block with generic API and implementation
excit becomes part of AML API

One point of note: excit would be useful for other parts of AML, in particular topology management.
-> We've settled for an index_byiter for now, but we might need to do both in the end.
Second design choice: do we need to be able to convert two-ways between tile and iterator ?

it is difficult to recover a tile coordinates from a layout already
it is not clear we need this functionality: we don't have use-cases at this point

-> Leave it for now.
Integration
We need to port the mchpc19 dgemm to this interface.

In GitLab by @perarnau on Apr 7, 2020, 13:37
changed the description

In GitLab by @perarnau on Aug 14, 2020, 09:27
changed title from Excit Integration to Excit Integration{+: Iterators and Tiling Iterators+}

In GitLab by @perarnau on Aug 14, 2020, 09:27
changed the description

In GitLab by @perarnau on Aug 14, 2020, 10:17
changed the description

In GitLab by @perarnau on Aug 14, 2020, 10:17
changed the description

In GitLab by @perarnau on Aug 14, 2020, 13:54
mentioned in merge request !149

In GitLab by @perarnau on Aug 19, 2020, 15:59
changed the description


Correctly determine os vs. non-os package from Github Advisories

What this PR does / why we need it: The vulnerability gates were reporting incorrectly that any/all Github Advisories where "os". Because the Github vulnerabilities are available in:
    vulns = context.data.get('loaded_vulnerabilities')

They aren't detected in the non-os loop. I wasn't able to determine why  this value was computed as 'all':
    self.package_type.value()

In any case, the Github Advisory does allow for both os and non-os reporting, so a utility now ensures that this is done correctly.
Which issue this PR fixes (optional, in fixes #<issue number>)(, fixes #<issue_number, ...) format, will close the issue when PR is merged: fixes issue  #400
Special notes:
Analyzing the latest anchore-engine image using the same CLI tools/flags that the inline-scan uses:
$ anchore-cli --u admin --p foobar evaluate check anchore/anchore-engine --detail
Image Digest: sha256:fcb7b905cb97b66813dd030ce11aeb6b5fefd8fbae0875afea23d6f918aa0f86
Full Tag: docker.io/anchore/anchore-engine:latest
Image ID: 81422f21f8288a126d67d64ca52df8ee1fba4e59df541e6fc4fffba7a20c8632
Status: fail
Last Eval: 2020-04-08T19:18:42Z
Policy ID: 2c53a13c-1765-11e8-82ef-23527761d060
Final Action: stop
Final Action Reason: policy_evaluation

Gate                   Trigger                               Detail                                                                                Status
vulnerabilities        stale_feed_data                       The vulnerability feed for this image distro is older than MAXAGE (2) days                                                                          warn
vulnerabilities        vulnerability_data_unavailable        Feed data unavailable, cannot perform CVE scan for distro: rhel:8.1                                                                                warn
vulnerabilities        package                               HIGH Vulnerability found in non-os package type (python) - Twisted (GHSA-h96w-mmrf-2h6v - https://github.com/advisories/GHSA-h96w-mmrf-2h6v)        stop
vulnerabilities        package                               HIGH Vulnerability found in non-os package type (python) - Twisted (GHSA-p5xh-vx83-mxcj - https://github.com/advisories/GHSA-p5xh-vx83-mxcj)        stop

Latest iteration works just as nice, no need to hack into the namespace. Thanks for the suggestions @zhill
Gate                   Trigger                               Detail                                                                                Status
dockerfile             instruction                           Dockerfile directive 'HEALTHCHECK' not found, matching condition 'not_exists' check                                                                         warn
vulnerabilities        stale_feed_data                       The vulnerability feed for this image distro is older than MAXAGE (2) days                                                                                warn
vulnerabilities        vulnerability_data_unavailable        Feed data unavailable, cannot perform CVE scan for distro: centos:8                                                                                warn
vulnerabilities        package                               HIGH Vulnerability found in non-os package type (python) - aubio (GHSA-7vvr-h4p5-m7fh - https://github.com/advisories/GHSA-7vvr-h4p5-m7fh)                  stop
vulnerabilities        package                               HIGH Vulnerability found in non-os package type (python) - aubio (GHSA-c6jq-h4jp-72pr - https://github.com/advisories/GHSA-c6jq-h4jp-72pr)                  stop
vulnerabilities        package                               CRITICAL Vulnerability found in non-os package type (python) - aubio (GHSA-grmf-4fq6-2r79 - https://github.com/advisories/GHSA-grmf-4fq6-2r79)              stop
vulnerabilities        package                               HIGH Vulnerability found in non-os package type (python) - python-dbusmock (GHSA-74xw-82v7-hmrm - https://github.com/advisories/GHSA-74xw-82v7-hmrm)        stop


simply the experimental box

Sample original page: https://docs.docker.com/engine/reference/commandline/assemble/
Signed-off-by: Adrian Plata<EMAIL_ADDRESS>Proposed changes
Simplified the experimental box to reduce clutter on pages.

Deploy preview for docsdocker ready!
Built with commit 972d1929bd55aa3347b284cc75a7f6780d377dce
https://deploy-preview-9483--docsdocker.netlify.com


✨ Add show_zero_line option to plot_overview and plot_fitted_traces

This change adds the option show_zero_line to plot_fitted_traces (applied to all axes) and plot_overview (only applied to spectra SAS/DAS). The zero lines are added by default since it falls more in line with plots by @ism200 which makes comparing plots to former publications easier.
Change summary

:sparkles: Added show_zero_line arg to plot_overview and plot_fitted_traces

Checklist

[ ] ✔ Passing the tests (mandatory for all PR's)

See CI pipeline for example plots


BUG

Describe the bug

The navigation bar on the website currently displays "AboutUs," which is grammatically incorrect. It should be displayed as "About Us" with a space between the words for proper grammar and readability.

Expected behavior

The navigation link should display as "About Us" for correct grammar and clarity.

Screenshots (Mandatory)

Our Website :

After correction : (its just a sample of other website)

Additional Context (Mandatory )

This change is important to ensure the professionalism and readability of the website's navigation. Proper grammar enhances user experience and contributes to a better overall impression.

Are you contributing under any open-source program ?

Yes, GSSOC'24.

@apu52 please assign me this issue , resolving it would increase readability and professionalism.

@Bindusree1515 You are assigned.

Describe the bug

The image of the home page is currently a fixed image  and if there is a random traveling image which changes on every refresh then it will give a better positive impact and it will also look good to see together
and also need to apply some transitions

Expected behavior

random traveling image  and transitions  will give a better positive impact ,attractiveness and it will also look good to see together

Screenshots (Mandatory)

Our Website :

After correction : (its just a sample of other website)

Are you contributing under any open-source program ?
Yes, GSSOC'24.
@apu52 please assign me this issue , resolving it would increase attractiveness and look good.

Please assign this to me!!

@numitasahu your issue is really good. but just want to suggest u to raise a complete new issue to get assigned .Don't comment on other's issues . Waiting for your new Issue eagerly


[Feature Request] An option to lock the URL of each pinned tab.

Hello, I would like to suggest adding a feature to lock the URL for SuperPins. For example, if I pin a tab (e.g. google.com) and then search for something, whenever the URL changes, when I reopen ZEN and go to the pinned tab, it will still navigate to the original URL that I pinned.
Thank you :D

Hey, I really like the idea, however I'm afraid that isn't really possible at the moment due to the limitations of CSS. I however heard mauro (the dev behind zen) think about implementing a Zen Plugins function in the future similar to the Theme/Mod store, but with the power of Javascript, which might be able to turn your idea into reality.
Thank you for the suggestion though :D


Add actual network-requesting test

This will make sure that basic functionality is not broken by any
commits.
TODO: Add environment variables so that this test works

For future work, it would be cool if we made a system where certain existing tests (probably read-only) could be tagged to be run on the network. I'm imagining a system where those test run using a cassette in the normal testing job, but they also run without a cassette as part of a different job. That way we might notice some changes in the Reddit API that interfere with PRAW.

We'd have to make a new class, and copy-paste those old tests.


Replace font stack with Chromium 56's "system-ui" generic font family

Description of the Change
Atom currently does not use the system font, but instead hardcodes a bunch of fonts in a "font stack" (priority list), hoping that the actual system font is present in that list and in the right position.
This doesn't always work and gives particularly poor results on Linux, where changing the system font is easy and Atom stands out as the one application that doesn't respect the change. The reason this long-standing issue is still open is that until recently this wasn't possible to fix from CSS (except on macOS with the BlinkMacSystemFont placeholder family) and would have required platform-specific code that resolves the correct family.
Enter Chromium 56, shipping with Atom 1.19! It introduces the system-ui generic font family that "allows authors to style contents so it fits within the system UI". It works on all platforms! 🎉 🎆 🍾
Closes #8656. The same change should probably be made also in Atom's default UI themes.
Alternate Designs
The alternatives are keeping the font stack, or resolving the system font family programmatically. Both are clearly worse.
Why Should This Be In Core?
Because the font family is defined in core.
Benefits
Atom looks a tiny bit more like a native application.
Possible Drawbacks
Can't think of any.
Applicable Issues
#8656

@atom/maintainers It's been a while... any chance this might get merged soon? It's just a one-line change which should be trivial to test by simply starting Atom on a few different platforms, but it fixes a long-standing UI issue on Linux.

Hey @simurai, is this something you would be able to take a look at?

Tested system-ui in styles.less with:
.workspace {
  font-family: system-ui;
}

Works on:

[x] MacOS 👉  San Francisco
[x] Windows 👉  Segoe UI

@ungb Do you mind trying it on Linux? No need to build Atom, you can paste that snippet above in your styles.less and see if the font looks close to the rest of the OS.
In the meantime, I'll make some PRs for the bundled themes.

After further testing with @simurai, everything looks good!

Here @ungb screenshot with the change:

Great fix! Thanks @p-e-w.


Frontend: Queries

Queries Needed:

[x] All Payers --> QUERY_PAYERS
[x] Single Payer --> QUERY_PAYER
[x] All Activities -->QUERY_ACTIVITIES
[x] Single Activity -->QUERY_ACTIVITY
[x] All Programs --> QUERY_PROGRAMS
[x] Single Program--> QUERY_PROGRAM
[ ] All Clients --> QUERY_CLIENTS
[ ] Single Client --> QUERY_CLIENT
[x] All Employees --> QUERY_EMPLOYEES
[x] Single Employee --> QUERY_EMPLOYEE
[x] Single User --> QUERY_USER

File structure
The ** indicates the folders/files need to be added
├── client
│   ├── src
│   │     ├── graphql **
│   │     │     ├── queries **
│   │     │     │     ├── client.js**
│   │     │     │     ├── payer.js**
│   │     │     │     ├── program.js**
│   │     │     │     ├── employee.js**
│   │     │     │     ├── activity.js**
│   │     │     │     ├── user.js**

Example:

Client Query bug #24 - Once resolved these can be finished


Rename command group type

As odo is working on consuming the v2 spec, i noticed that the command group kind is called command group type https://github.com/devfile/kubernetes-api/blob/master/pkg/apis/workspaces/v1alpha1/commands.go#L20
// CommandGroupType describes the kind of command group.
// +kubebuilder:validation:Enum=build;run;test;debug
type CommandGroupType string

Can we please rename this to CommandGroupKind to be consistent with the discussion here in https://github.com/devfile/kubernetes-api/issues/27 and also devfile actually uses kind instead of type:
commands:
  - exec:
      id: devBuild
      component: runtime
      commandLine: npm install
      workingDir: ${CHE_PROJECTS_ROOT}/nodejs-web-app/app
      group:
        kind: build
        isDefault: true

@maysunfaisal you are right. We need to address that. If you have the chance don't hesitate to open a PR.

Fxed in PR https://github.com/devfile/kubernetes-api/pull/94


feat: update new metrics

#56
Changes

[x] For get_evaluations, we will report all metrics events, Including the latency and size metrics events.
[x] For register_events, we will only report error metrics, such as timeout, network, server errors, etc.
[x] Remove the InternalErrorMetricsEvent, and use InternalServerErrorMetricsEvent for 500 internal server errors and InternalSdkErrorMetricsEvent for SDK internal errors.
[x] In the metric data labels, we will set the same tag that is used to initialize the SDK.
[x] Update test cases

[x]  Testcase: for ApiIDApdater (NEW)
[x]  Testcase: Validate mapping from Exception to Error Metrics (NEW)
[x]  Testcase: MetricsEventAdapterFactoryTest (Update)
[x]  Testcase: For register_events, we will only report error metrics, such as timeout, network, server errors, etc. (already covered by current test cases)
[x]  Testcase: For get_evaluations, we will report all metrics events, Including the latency and size metrics events. (already covered by current test cases)

Hi @cre8ivejp
Thank you for reviewing. Let me check your comments and make an update.
On Fri, Jun 2, 2023, 7:22 AM Alessandro Yuichi Okimoto <
@.***> wrote:

@.**** commented on this pull request.
In
bucketeer/src/main/kotlin/io/bucketeer/sdk/android/internal/event/EventCreators.kt
https://github.com/bucketeer-io/android-client-sdk/pull/64#discussion_r1212725977
:

   sdkVersion = BuildConfig.SDK_VERSION,

   metadata = newMetadata(appVersion),
 ),

)
}
+internal fun newMetricsEventData(

featureTag: String?,
apiID: ApiID,
type: MetricsEventType,
// note: only available on success request
latencySecond: Long? = null,
// note: only available on success request
sizeByte: Int? = null,
+): MetricsEventData {
// note: featureTag only available from GET_EVALUATIONS
val labels = if (featureTag != null) mapOf("tag" to featureTag) else mapOf()

We must set the tag also for REGISTER_EVENTS API.
In
bucketeer/src/main/kotlin/io/bucketeer/sdk/android/internal/event/EventCreators.kt
https://github.com/bucketeer-io/android-client-sdk/pull/64#discussion_r1213794835
:

   sdkVersion = BuildConfig.SDK_VERSION,

   metadata = newMetadata(appVersion),
 ),

)
}
+internal fun newMetricsEventData(

featureTag: String?,
apiID: ApiID,
type: MetricsEventType,
// note: only available on success request
latencySecond: Long? = null,

I think it will be better if we split the function or refactor it. One for
success and another for failure, so we can avoid those checking for
latencySecond and sizeByte throwing an exception.
In
bucketeer/src/main/kotlin/io/bucketeer/sdk/android/internal/event/EventCreators.kt
https://github.com/bucketeer-io/android-client-sdk/pull/64#discussion_r1213795066
:

   sdkVersion = BuildConfig.SDK_VERSION,

   metadata = newMetadata(appVersion),
 ),

)
}
+internal fun newMetricsEventData(

featureTag: String?,

The featureTag shouldn't be optional at this point.
—
Reply to this email directly, view it on GitHub
https://github.com/bucketeer-io/android-client-sdk/pull/64#pullrequestreview-1454796284,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAT2GTS24FQJAUM3BXEY6E3XJEW45ANCNFSM6AAAAAAYSQMLH4
.
You are receiving this because you authored the thread.Message ID:
@.***>

Thank you @yshrsmz @cre8ivejp
I will use the BKConfig.FeatureTag value and finalize the PR
On Fri, Jun 2, 2023, 9:13 PM Yasuhiro SHIMIZU @.***>
wrote:

@.**** commented on this pull request.
In
bucketeer/src/main/kotlin/io/bucketeer/sdk/android/internal/event/EventCreators.kt
https://github.com/bucketeer-io/android-client-sdk/pull/64#discussion_r1214435636
:

   sdkVersion = BuildConfig.SDK_VERSION,

   metadata = newMetadata(appVersion),
 ),

)
}
+internal fun newMetricsEventData(

featureTag: String?,
apiID: ApiID,
type: MetricsEventType,
// note: only available on success request
latencySecond: Long? = null,
// note: only available on success request
sizeByte: Int? = null,
+): MetricsEventData {
// note: featureTag only available from GET_EVALUATIONS
val labels = if (featureTag != null) mapOf("tag" to featureTag) else mapOf()

Say you instantiated BKTClient with "android-3" featureTag, and you have 2
events in DB.
BKTClient tries to create a register_events request.
{
"events": [
{
"eventType": 4, // METRICS
"event": {
"labels": { "tag": "android" },
// other values go here...
}
},
{
"eventType": 1, // GOAL
"event": {
"labels": { "tag": "android-2" },
// other values go here...
}
}
]}
And the response is returned with error(all registration is failed), so
you save failure metrics event.
Then after several minutes, BKTClient tries to send another
register_events. In this case, we have 3 events in a DB.
The request looks like this.
{
"events": [
{
"eventType": 4, // METRICS
"event": {
"labels": { "tag": "android" },
// other values go here...
}
},
{
"eventType": 1, // GOAL
"event": {
"labels": { "tag": "android-2" },
// other values go here...
}
},
{
"eventType": 4, // METRICS
"event": {
// here you save new failure metrics event with android-3 tag
"labels": { "tag": "android-3" },
// other values go here...
}
}
]}
So feature tag is in each event, and you don't need to care about multiple
featureTag in a single labels map.
—
Reply to this email directly, view it on GitHub
https://github.com/bucketeer-io/android-client-sdk/pull/64#discussion_r1214435636,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAT2GTWAUMNCZHUKG6LUHIDXJHYJ7ANCNFSM6AAAAAAYSQMLH4
.
You are receiving this because you were mentioned.Message ID:
@.***>

hi @yshrsmz I make the changes as per your suggestion.
Please help me to take a look

@yshrsmz I applied your suggestion.
Please continue reviewing . Thank


Serve analysis CSVs from S3 in production. (Don't merge yet)

Still waiting on the final decision on CSV headers to actually upload the static CSVs, but figured this can go up in the mean time. Nothing fancy here, just give users the relevant file from S3 if we're in production - otherwise, do the exact same things as before.

Pregenerated CSVs are now in the bucket: https://s3.console.aws.amazon.com/s3/buckets/encompass-public-data/results-csv/?region=us-west-2&tab=overview


Adding OSS license

Hello @jacoblee93 .
Since you are encouraging to fork this project, have you considered to release it under an OSS license?

Oh, shoot yeah should do that. Thanks for the reminder

Done, thanks!

Thank you for the quick reply & commit 👍


Fixes an issue with stats in paths with whitespace

Splitting on whitespace of the ls-tree output is not enough: when
a path contains a space only the first part is taken as the file
name. This commit changes that behaviour by using another command
to list all the file names.
For an example, take https://git.camilstaps.nl/NWI-IBI008-Data-Mining.git/stats/master. If you look at the files in the repo, you see there are many .py files (for instance), but they don't appear in the extension stats because they're in directories that contain spaces ("Assignment 1", etc.).

Thanks!
Just for reference: the link from the PR message above is now invalidated.


Problems processing ODT files

We created an ODT file with the following contents:

The quick brown fox jumped over the lazy dog
Mary Mary quite contrary

Note below how the last line is repeated, and we lose the double return (i.e. extra break between two sentences)
$ node
> const textract = require('textract')
undefined
> textract.fromFileWithPath('./test/english.odt', { preserveLineBreaks: true }, function (error, text) { console.log(text)})
undefined
> The quick brown fox jumped over the lazy dog
Mary Mary quite contrary
Mary Mary quite contrary

Problem is even worse for longer files - has anyone else experienced this? or any idea how to fix?

Duplicate line is definitely a problem.
Extra line break would have been removed on purpose. First I've heard of someone wanting to preserve the whitespace.
I can look into both things. No timetable, though, wicked busy.

More complicated documents seem to have a more complicated pattern:

seems like the four sentences are displayed, and then it repeats the last three, then the last two, then the last one.
Just created an odt with:

One

two

three

four

five

six

and after importing get:
Onetwothreefourfivesixtwothreefourfivesixthreefourfivesixfourfivesixfivesixsix
So, the bug is definitely recursive!

Do you have an example file I can use to test with?

Have been able to duplicate this, so I'm good. Less concerned about the double return as I am about the repeating.

This is fixed. Oddly enough I was seeing this bug in my tests already, I just stupidly modified the tests (for ott files) to match the erroneous output as it didn't look hugely bad.
I have a few other small things I want to do before releasing, but this should be out in a day or so.


Document echo engine in Swagger

Do it - and how and why to use it.  It has a basic statement, but needs something more complete - which endpoints it covers (a full coverage of SMT and NMT endpoints - giving back the data).

On it!
Do you want the Echo engine to cover the word graph endpoint? If so, how? Just a simple word graph with 1.0 confidence arcs that move along the series of words of the input segment? I noticed that this endpoint is missing.

Yes, adding the word graph - we will want to support all endpoints with echo (when feasible).   The 1.0 confidence arcs should be fine - if we want to do more in-depth testing of the word graph, we would want to use real data, not echos or synthesized (at least, not right now).


Archive labels UI enhancement

Followup  https://github.com/go-gitea/gitea/pull/26478
Archived labels UI
Added:

Implemented the structural framework for the user interface to accommodate archived labels.
Introduced archived labels functionality to the UI, akin to the approach taken for closed milestones or projects. This functionality allows concealing information while retaining it, without resorting to deletion.
Particularly advantageous for managing outdated labels that are no longer in use, offering a means to preserve them without cluttering the active label set.

Changed:

Enhanced the Filtered UI page to seamlessly incorporate a list of archived labels.

Outsourced:

Defer the implementation of specialized handling for archived labels to upcoming pull requests. This step will be undertaken subsequent to the successful merge of this pull request.

Screenshots

Part of https://github.com/go-gitea/gitea/issues/25237

What's the benefit of toggling the hightlight?

Here is discussion
https://github.com/go-gitea/gitea/pull/26502#discussion_r1293997856

Ok, but I still think a static archived highlight is all what's needed.

Introduced archived labels functionality to the UI, akin to the approach taken for closed milestones or projects. This functionality allows concealing information while retaining it, without resorting to deletion.

I meant hide archived labels by default, and show them only when the checkbox is toggled.

I am going to change again on the above basis.

I want to add highlight for initial release of this feature.

Why not just sort them to the bottom and add the highlight? Then you don't need extra logic to show them and they don't block the view.

Works too.
Except then we need the extra logic to sort them.

Why not just sort them to the bottom and add the highlight? Then you don't need extra logic to show them and they don't block the view.

I can managed that with js

Works too. Except then we need the extra logic to sort them.

The extra logic is "sort by archived date"

Sort primarily by archive date and then by name.
True, that works.

To keep the archived labels sorted by name too you could do the sorting in Go or sort by if archived date > 0 ? 1 : 0 in sql.

Keep in mind that the archived labels are only sorted by name because the timestamps are in the correct order.

Keep in mind that the archived labels are only sorted by name because the timestamps are in the correct order.

Yes, correct,
Query will be complex

Let's scoped this PR for Ui changes only. I am sending a back to back Pr for Sorting and Db migration changes [We need to index the archived_unix] column and a separate method I am introducing because the older method is used several places.
Just to avoid the conflicts in result set.
Need approvals/reviews regarding UI changes only.
@delvh
cc/ @KN4CK3R

If we sort them in the next PR, why is the toggle code still there?

+1 more approval needed on this PR.

If we sort them in the next PR, why is the toggle code still there?

Your point perfectly valid. Currently I am working on the sort functionality.  I will mark this PR reviewed-wait. and I am about to raise the sort PR.

You mean WIP, right?

This yellow highlight bar looks very odd, is it removed in latest versions?

We can change the color. I took it from base.css

What does it highlight? Archived state? I guess a small "Archived" label would be equally well suited, and less confusing. Maybe in its own column.

Follup to https://github.com/go-gitea/gitea/pull/26741

Closing as of now.


[CI] Disable NNPACK build on CI

Fix #17070

@tqchen Please let me know if there's anything else that should be changed besides removing the NNPACK installation.

@tvm-bot rerun

we can find the nnpack related code under /contrib/nnpack/, and some operations like _conv2d_arm_cpu_winograd_nnpack, I guess we will need to gradually deprecate those in the future.

we can remove the related supporting code as well as long as they are legacy, especially given we ar emoving towards relax

Looking at the docker ci build log, it seems like the Android SDK installation is failing.
https://ci.tlcpack.ai/blue/organizations/jenkins/tvm-docker/detail/PR-17337/3/pipeline

[2024-09-10T15:30:06.331Z] 14.60 Accept? (y/N): All SDK package licenses accepted
[2024-09-10T15:30:06.331Z] 14.60 done
[2024-09-10T15:30:06.331Z] 15.46 Warning: Failed to find package extras;m2repository;com;android;support;constraint;constraint-layout;1.0.2
[2024-09-10T15:30:06.331Z] ------
[2024-09-10T15:30:06.331Z] Dockerfile.ci_cpu:130
[2024-09-10T15:30:06.331Z] --------------------
[2024-09-10T15:30:06.331Z]  128 |     # Android SDK
[2024-09-10T15:30:06.331Z]  129 |     COPY install/ubuntu_install_androidsdk.sh /install/ubuntu_install_androidsdk.sh
[2024-09-10T15:30:06.331Z]  130 | >>> RUN bash /install/ubuntu_install_androidsdk.sh
[2024-09-10T15:30:06.331Z]  131 |
[2024-09-10T15:30:06.331Z]  132 |     # PaddlePaddle deps
[2024-09-10T15:30:06.331Z] --------------------
[2024-09-10T15:30:06.331Z] ERROR: failed to solve: process "/bin/sh -c bash /install/ubuntu_install_androidsdk.sh" did not complete successfully: exit code: 1
[2024-09-10T15:30:06.331Z] ERROR: docker build failed.

We can disable/remove the android docker for now given most android SDK are used without docker atm


Add in simple to use iterative chat

For example a function like:
from ollama import historic_chat

message = {
  'role': 'user',
  'content': 'Tell me a Joke in less than 30 words.',
}
response = historic_chat('mistral', message=message)
print(response['message']['content'])

message = {
  'role': 'user',
  'content': 'Another please.',
}
response = historic_chat('mistral', message=message)
print(response['message']['content'])

Should return two jokes.

@mxyng tagging you to get some initial thoughts on this PR.

Thanks for the interest in ollama-python. The current intention for this library is to mirror the Ollama API and is minimal as a result. Implementing memory as part of the library is out of scope.
Memory can be implemented easily by manipulating the messages keyword argument. Here's a quick example:
from ollama import chat

messages = [
  {'role': 'user', 'content': 'Tell me a Joke in less than 30 words.'},
]

response = chat('mistral', messages=messages)
message = response['message']
print(message['content'])
messages.append(message)

messages.append({'role': 'user', 'content': 'Another please.'})
response = chat('mistral', messages=messages)
message = response['message']
print(message['content'])
messages.append(message)

This example will print two jokes. Here's what mistral gave me
$ python run example.py
 Why don't scientists trust atoms? Because they make up everything!
 Why did the scarecrow win an award? Because he was outstanding in his field!

This full example provides a working version of the above with a few extra bells and whistles. It's effectively a trimmed down version of ollama run (with --speak for fun).

I am not sure if you saw the PR submitted to solve this. Its very simple and seems worthwhile to add to scope.https://github.com/ollama/ollama-python/pull/64

I did see the PR. The PR changes the synchronous client to subclass a new client with internal state and adds a method iterative_chat which uses the internal state in place of messages.
A stateful client is problematic since now there now needs to be functions to manage the internal state such as trimming or resetting state. This adds additional scope and complexity to library for features that are user specific.
Additionally, using a single client for two sets of history is impossible since this client maintains a single history list.
The optional history keyword argument functions roughly the same as the current messages keyword argument by manipulating the internal state. However it's error prone since sending the same history twice will add duplicate entries.
Overall, it's a lot of effort and code to implement something the user can implement easily and with more precision

Fair points. I still see a large need for this. I will probably just end up creating an external library that streamlines this process.

That would be great! This library is intended to be a building block on which others such as yourself can build more featureful projects


[Internal] Client Telemetry: Adds sampling logic for network level telemetry

Description
As part of this PR, Sampling is introduced for network call telemetry.

It is going to capture top 10 service endpoint (combination of host, partitionid, replica id) failed or high latency calls.
e.g.
In 10 (client telemetry aggregation interval) minutes interval, if 100 read document calls were made, it would result into maximum partition count 100 * 4 network calls or more if we include retries.
but in client telemetry, we would want top 10 failed (or high latency) unique service endpoints.

Minor change: added 412 status code into excluded status code list. So basically telemetry won't be collected for network calls with statuscode 412 and substatuscode 0.

Architecture Diagram

Network Request telemetry recording logic is moved to "Network Request Recorder". Where data get filtered and divided into different buckets and then corresponding sampling logic is applied to each bucket.
There are 2 sampling logic:

Order the collected data by p99 latency and return top 10 service endpoints with highest latency
Order the collected data by sample count and return top 10 service endpoints with high number of failures during that time.

Type of change

[] New feature (non-breaking change which adds functionality)

Minor change: added 412 status code into excluded status code list. So basically telemetry won't be collected for network calls with statuscode 412 and substatuscode 0.

What's the reason for exclude?

Minor change: added 412 status code into excluded status code list. So basically telemetry won't be collected for network calls with statuscode 412 and substatuscode 0.

What's the reason for exclude?

412 status code is "Precondition Failure" which we don't want to record. It is one of the valid scenario which we don't want to track in client telemetry @FabianMeiswinkel


Js fix contract name cli

Coverage remained the same at 99.119% when pulling 48fad2be351995414a905ddf06cd81ff438f44ab on jeromesimeon:js-fix-contractName-cli into 8f590793dad518684d8dbea8f0ea0da68312dcd4 on accordproject:master.


MongoDB\Driver\Monitoring\CommandSubscriber interface signature

Laravel-mongodb Version: 5.0.0
PHP Version: 8.3.8
Database Driver & Version: mongodb-1.19.4

Description:
MongoDB\Driver\Monitoring\CommandSubscriber interface implementation Generates deprecation alert due to function signatures.
Missing vois return type.

Thanks for noticing this issue. Should be fixed by https://github.com/mongodb/laravel-mongodb/pull/3157


Segmentation fault (core dumped) Error

Did the setup on Ubuntu 16.04 and ran the code with sample files available the repo. Please find the code I used.
sudo apt-get update -y
sudo apt-get upgrade -y
sudo reboot
python3 -m pip install --user --upgrade pip
wget https://bootstrap.pypa.io/get-pip.py
sudo python3 get-pip.py
python3 -m pip install --user --upgrade pip
python3 -m pip install --user opencv-python
python3 -m pip install --user opencv-contrib-python
git clone https://github.com/Udayraj123/OMRChecker
cd OMRChecker/
python3 -m pip install --user -r requirements.txt
sudo cp -r inputs/OMR_Files_Sample/ inputs/OMR_Files
python3 main.py
If I run the code, I am getting, "Segmentation fault (core dumped)" error.

Even I tried steps mentioned here to create custom layout template. But, whatever I do, I am getting "Segmentation fault (core dumped)" error.

It's an issue with file permissions. You have used sudo cp there. Remove the files and try again without sudo

Even after doing that, I am getting the same error. I have logged in as root and executed the command.  Currently, following is the permission set for the files,

Let me know what permission should I set to resolve the issue. Please find my cmds below,
1  sudo apt-get update -y
2  sudo apt-get upgrade -y
3  sudo reboot
4  wget https://bootstrap.pypa.io/get-pip.py
5  python3 get-pip.py
6  python3 -m pip install --user --upgrade pip
7  python3 -m pip install --user opencv-python
8  python3 -m pip install --user opencv-contrib-python
9  git clone https://github.com/Udayraj123/OMRChecker
10  cd OMRChecker/
11  python3 -m pip install --user -r requirements.txt
12  cp -r inputs/OMR_Files_Sample/ inputs/OMR_Files
13  python3 main.py

No need to login as root/Administrator! Execute all the commands as a normal user

I am running this on cloud machine with root privileges. Should I create new user and run these cmds?What difference this gonna make? In such case, what privileges should I set while creating the new user.

Okay, sorry I assumed you'd be on a PC. As such there shouldn't be any problem. Can you join in on discord so as to solve this prob faster? (see readme for link)

Sure.

So the issue has now boiled down to improper opencv installation, causing the import cv2 line to fail:
Here are related discussions to help you solve it:

On a clean droplet, some of these libraries get missing. Following Adrian's blog, you should install the following explicitly now(after pip install is done).
sudo apt-get install -y build-essential cmake unzip pkg-config
sudo apt-get install -y libjpeg-dev libpng-dev libtiff-dev
sudo apt-get install -y libavcodec-dev libavformat-dev libswscale-dev libv4l-dev
sudo apt-get install -y libatlas-base-dev gfortran

@Siva2406  Is your issue solved now?

Yes. I am able to proceed now. Thanks for your support.


Infer statics object from struct/impls

Codecov Report
Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (fb1db1a) 82.05% compared to head (50af944) 82.15%.

Files
Patch %
Lines

src/Escalier.TypeChecker/Infer.fs
92.92%
7 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
+ Coverage   82.05%   82.15%   +0.10%
==========================================
  Files          20       20
  Lines        6754     6821      +67
  Branches      918      925       +7
==========================================
+ Hits         5542     5604      +62
- Misses       1212     1217       +5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Some more issues

Hi there, I've got some nice issues here.

Thanks very much for reporting an issue. Always excited to see
returning contributors with 3 issues created . This is a spare time
project so I only tend to get around to things on the weekends. Please
be patient for me getting a chance to look into this.


write-barrier slow path sharing CLs did not block LR in all necessary places on ARM

On ARM we
I see that StoreInstanceFieldInstr takes care to reserve it, but StoreStaticFieldInstr and StoreIndexedInstr does not seem to do the same.
Also I noticed that StoreInstanceFieldInstr has the following problem: even if ShouldEmitStoreBarrier() is false we might still emit a store barrier - because this might be an unboxed store (e.g. obj.field = 2.0) in which case we don't need a store barrier for the value, but we need a store barrier for the temporary box - this means that LR needs to be blocked for these cases as well.
I think StoreIntoObject on ARM needs to assert that object != LR - to make sure that we catch any remaining cases where this does not hold.
[I am marking this as a P0 because this might lead to hard to debug issues where LR is overwritten with strange values]

Maybe we should we just make LR unavailable to register allocation on ARM like we do on ARM64. It seems easy for all sorts of slow path code to incorrectly assume it's available for making calls.

@rmacnak-google True, this indeed would be an even more robust approach. I think one of the original suggestions was to make TMP = LR to avoid blocking yet another register.

Many places in the ARM assembler and compiler use IP directly rather than TMP.


[docs] Use hfoptions for metadata

Based on this comment, bringing back the example on how to use http range requests to get metadata. Also, using hfoptions syntax for better UI/UX
you can test the page here: https://moon-ci-docs.huggingface.co/docs/safetensors/pr_424/en/metadata_parsing#usage
https://github.com/huggingface/safetensors/assets/11827707/53edac7e-5bfe-43b6-a158-a026d7540ac3

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Not sure about naming http the one where we show a python snippet to parse using http requests but I don't have a better one to suggest so keeping it should be good 👍

Indeed. That is the question. Maybe others can chime in


feature/874: add 874 solution

Codecov Report

Merging #125 (1835b6d) into master (99fe55c) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
- Coverage   71.93%   71.87%   -0.06%
==========================================
  Files         673      674       +1
  Lines       11943    11976      +33
==========================================
+ Hits         8591     8608      +17
- Misses       3040     3056      +16
  Partials      312      312

Impacted Files
Coverage Δ

...lking-Robot-Simulation/Walking Robot Simulation.go
100.00% <100.00%> (ø)

...Character/821. Shortest Distance to a Character.go
38.46% <0.00%> (-61.54%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99fe55c...1835b6d. Read the comment docs.


pyTorch

Isn't there any plan on the horizon to port this code to pyTorch ?

We are not planning implementing it for now, but some people are indeed suggesting that pyTorch may be faster than TF. It would be great if someone can implement GA3C in pyTorch following our guidelines.

I did a quick trial in one of my branches . Actually, TF is almost twice as fast, because the naive way I did the vectorized loss is probably involving a lot of function calls. The same issue arises for Chainer version. The loss takes almost more time to compute than the cnn. I think it could work faster if implementing it as a specific layer.

Just FYI, my friend was able to reproduce both the speed and performance of my a3c implementation with his pytorch code.
It batches data differently from GA3C, but the overall structure is similar.

interesting @ppwwyyxx !
My naive implementation gives something like this :

I am not sure if the problem is in the batching, rather than the explicit calls & many steps of computation for the loss.
        p, v = self.model.forward_multistep(x_, c, h)
        probs = F.softmax(p)
        probs = F.relu(probs - Config.LOG_EPSILON)
        log_probs = torch.log(probs)
        adv = (rewards - v)
        adv = torch.masked_select(adv,mask)
        log_probs_a = torch.masked_select(log_probs,a) #we cannot use it because of variable length input
        piloss = -torch.sum( log_probs_a * Variable(adv.data), 0)
        entropy = torch.sum(torch.sum(log_probs*probs,1),0) * self.beta
        vloss = torch.sum(adv.pow(2),0) / 2
        loss = piloss + entropy + vloss

If someone knows how to do this more quickly in pytorch ...?

@ppwwyyxx Is there a public git repo for your friend's pyTorch implementation ?

Unfortunately no..


Is it possible to use wakapi at the same time as wakatime?

Hello, I just installed wakapi in a raspberry pi and at first glance looks awesome, but I'd like to keep using wakatime at the same time. Is it possible to provide in the client config two keys and servers?

Check out the settings page. You can connect your Wakatime account there.

Thanks, I did not think about it, sorry for the question :P.

No worries, hope you'll enjoy using Wakapi :)


ngsi_v2 tutorials are deprecated

Describe the bug
ngsi_v2 tutorials consist of exercises and solutions. Solutions use methods that are deprecated (pydantic and json methods).
To Reproduce
Executing exercise 3 solutions to exercise 7 produces various errors.
Expected behavior
Solutions should run properly.
Screenshots
Environment (please complete the following information):
Additional context
Mostly TypeErrors are causing the errors that are easy to fix. There are also some PEP 8 errors occuring.

I am running into problems at exercise 5. There is a method imported from pydantic called parse_file_as. This method does not exist in version 2 of pydantic anymore. What I tried to do is use the method validate_python. This method takes a loaded json file as a parameter. I have done that, but then I keep running into other errors that might be connected to the deprecated method.

I am running into problems at exercise 5. There is a method imported from pydantic called parse_file_as. This method does not exist in version 2 of pydantic anymore. What I tried to do is use the method validate_python. This method takes a loaded json file as a parameter. I have done that, but then I keep running into other errors that might be connected to the deprecated method. Here is the attempt.

I have made some progress here. It might be, that this is the correct implementation but now other problems appear. It seems that SERVICE_PATH is playing a role. After you change the service path in exercise 4 to something unique and you try to execute exercise 5, you have to have the same service path which makes sense. The following error appears: requests.exceptions.HTTPError: 500 Server Error: Internal Server Error for url: http://localhost:4041/iot/devices.
Interestingly, if you try to execute the same file (exercise 5) again, you get the following error: pydantic_core._pydantic_core.ValidationError: 1 validation error for list[ServiceGroup] 0.cbHost Input should be a valid URL, relative URL without a base [type=url_parsing, input_value='None', input_type=str]. And if you try to execute the file again, the second error keeps appearing. So the first error appears only after single execution and not again. If you want it to appear again, you would need to execute exercise 4 with changed service path.

@WaltherTrgovac  thanks for the contribution! Could you make a pull request (PR) for this branch? We can better discuss the detail implementation or solution under the PR

@WaltherTrgovac validate_python is most likely not the function you used. In the newer evrsion of pydantic you need to parse the json yourself and then, e.g. use the validate_model function.  If the *.json contains a list you need to convert to a list of dicts.
Subseeunetly, you can create a list of models usige e.g. list-comprehension


Wrong country despite using --cfon and --country

Version number
v1.2.3
Describe the bug
Despite the fact I'm running my warp-plus as below. My ip location isn't Germany and differs time to time.
./warp-plus --cfon --country DE

To Reproduce
Just use the command with cfon and country DE
Expected behavior
Ip location needs to be from Germany
Screenshots

Desktop (please complete the following information):

OS: Openwrt Snapshot
Device: Xiaomi ax3000t router

Additional context
I ran oblivion on my macos as well. Encountered the same problem.
Thank you for you valuable hard work :)

I'm getting "level=ERROR msg="unable to run psiphon Unable to start psiphon: controller.Run exited unexpectedly" instead, works fine if cfon is disabled but that defeats the purpose of the app.


[Slider] Can't reach max value if slider is full width of webpage

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
If a slider takes up the full width and the browser is either in full screen or the full width of the monitor, dragging the slider all the way to the right will only go up to 99.9 (min=0, max=100, & step=1e-1)
Expected Behavior 🤔
I would expect 100 if the slider is moved all the way to the right.
Steps to Reproduce 🕹
Example: https://codesandbox.io/s/rough-waterfall-zt8nv?file=/src/App.js

Open above example in new browser window
Either enter full screen or make sure browser window takes up full width of computer screen (I'm only using my laptops single screen)
Drag slider all the way to the right, max value is 100 but the max I'm ever able to get is 99.9

Context 🔦
I'm using Slider as a playback slider for a scientific application. Times can get pretty granular (step=1e-20) which was how I discovered this peculiarity. I've noticed that YouTube playback slider has a slight buffer to the left & right so I was wondering if it's not recommended to have a slider that takes up the full width of the browser window or if this was a bug.
Your Environment 🌎

`npx @material-ui/envinfo`
Browser: Google Chrome Version 90.0.4430.93 (Official Build) (x86_64)
  System:
    OS: macOS 10.15.7
    CPU: (12) x64 Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz
    Memory: 14.31 GB / 32.00 GB
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 14.15.4 - /usr/local/bin/node
    Yarn: 1.22.10 - /usr/local/bin/yarn
    npm: 6.14.10 - /usr/local/bin/npm
  Managers:
    Homebrew: 3.1.5 - /usr/local/bin/brew
    pip3: 21.0.1 - /usr/local/bin/pip3
    RubyGems: 3.0.3 - /usr/bin/gem
  Utilities:
    Make: 3.81 - /usr/bin/make
    GCC: 10.15. - /usr/bin/gcc
    Git: 2.24.3 - /usr/bin/git
    Clang: 1<IP_ADDRESS> - /usr/bin/clang
    FFmpeg: 4.4 - /usr/local/bin/ffmpeg
  Servers:
    Apache: 2.4.41 - /usr/sbin/apachectl
  Virtualization:
    Docker: 20.10.5 - /usr/local/bin/docker
  IDEs:
    Nano: 2.0.6 - /usr/bin/nano
    Vim: 8.1 - /usr/bin/vim
    Xcode: /undefined - /usr/bin/xcodebuild
  Languages:
    Bash: 3.2.57 - /bin/bash
    Perl: 5.18.4 - /usr/bin/perl
    PHP: 7.3.11 - /usr/bin/php
    Python: 2.7.16 - /usr/bin/python
    Python3: 3.9.4 - /usr/local/bin/python3
    Ruby: 2.6.3 - /usr/bin/ruby
  Databases:
    SQLite: 3.28.0 - /usr/bin/sqlite3
  Browsers:
    Chrome: 90.0.4430.93
    Edge: 90.0.818.51
    Firefox: 78.7.0
    Safari: 14.1
  Monorepos:
    Yarn Workspaces: 1.22.10
    Lerna: 3.22.1

closing in favor of #26134


Change tests to print node.properties when no logs

The log location is set in node.properties, not log.properties.  Fix
debug info
I also realized that it will go to /var/log/presto by default (for the rpm), so I think it's probably not related to the missing config issue.  but i left this logging in as something that could be maybe possibly helpful.
@ebd2

LGTM

merged, thanks!


FIx compatibility for cucumber java plugin

Description
Reverts refactor of @When annotation to support cucumber java plugin so that all step definitions are not treated as warnings.
Until this is addressed, I'll need to maintain a fork for our use since we have finite karate plugin licenses and we need a java debugger.

Relevant Issues : https://github.com/karatelabs/karate/issues/2327, https://github.com/karatelabs/karate-intellij-plugin/issues/30
Relevant PRs :
Type of change :

[ ] New feature
[X] Bug fix for existing feature
[ ] Code quality improvement
[ ] Addition or Improvement of tests
[ ] Addition or Improvement of documentation

All that would be needed for users to use cucumber java plugin would be to add jar dependency to their own project
<dependency>             <groupId>info.cukes</groupId>             <artifactId>cucumber-java</artifactId>             <version>1.2.5</version>             <exclusions>                 <exclusion>                     <groupId>info.cukes</groupId>                     <artifactId>cucumber-html</artifactId>                 </exclusion>                 <exclusion>                     <groupId>info.cukes</groupId>                     <artifactId>cucumber-jvm-deps</artifactId>                 </exclusion>                 <exclusion>                     <groupId>info.cukes</groupId>                     <artifactId>gherkin</artifactId>                 </exclusion>             </exclusions>         </dependency>

closing as wontfix, refer: https://github.com/karatelabs/karate/issues/2214


Expected scope for MSAL client app calling API App published via Azure App Proxy

[Enter feedback here]
The provide MSAL code on this page needs to be clearer about what the scopes should be for MSAL client app

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1beb230a-bc3e-1db3-772e-7a021dab126d
Version Independent ID: d314a3eb-3383-772b-d1a0-9f1f5c7bc4b0
Content: Access on-premises APIs with Azure Active Directory Application Proxy)
Content Source: articles/active-directory/app-proxy/application-proxy-secure-api-access.md
Service: active-directory
Sub-service: app-proxy
GitHub Login: @kenwith
Microsoft Alias: kenwith

@bachoang
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.


Change dpdk-app-centos to build from local instead of pull upstream

Anytime changes to app-netutil need to be tested with dpdk-app-centos, needed
changes to build script and Dockerfile to build with those changes. Updated
to always build from local instead of pulling from upstream.
Signed-off-by: Billy McFall<EMAIL_ADDRESS>

@zshi-redhat PTAL

/lgtm

/retest

/lgtm


[Bug Report][Radio] Odd Behaviors Among Radio Group

Bug, feature request, or proposal:
Most Likely a Bug, Possible a Feature Request
What is the expected behavior?
In my current application, I have two radio selects which cannot be in the same md-radio-group since they are in separate cells of a table, however they still need to function as ngModel compliant. To do this I have built two md-radio-groups and set the name attribute on each of them, which produces the desired outcome except in one way. If the value dictating the data bound [ngModel] changes, the first change will be accepted, however further changes will not.
What is the current behavior?
See Plunker in Next Section
Currently, when the value which the [ngModel] is bound to changes, the first time it is changed after the page loads, the radio boxes will update as expected, however, any further changes have no effect on the radio box. If this behavior is due to the way I am utilizing md-radio-group, what would be the proper way to set this up?
What are the steps to reproduce?
Plunker - http://plnkr.co/edit/W1XjA5Ja1RbnXYtWbvEG?p=preview
The top row of radio buttons will change the value of the data bound [ngModel] for the bottom row of radio buttons. Upon clicking either of the buttons in the top row, you initially see that the wrong radio is checked on the bottom row. Clicking on the whitespace to trigger the onBlur event will properly select the desired radio button, however, clicking on either of the radio buttons in the top row further have no effect on the bottom row, even though the value of the [ngModel] is being updated.
What is the use-case or motivation for changing an existing behavior?
I have a table which has two columns of radio buttons, the table cannot have a default behavior selected, so the user must explicitly state what they want (Business Rules) which is why a single checkbox or slide-toggle cannot be used. I need to have two md-radio-groups which are linked together so that their child md-radio-buttons function as if they were in the same group.
Which versions of Angular, Material, OS, browsers are affected?
Angular 2 RC5
Angular 2 Material 7-2a
Google Chrome 52.0.2743.116
Windows 10

@tinayuangao I suspect this is the same underlying issue as #831

Cannot reproduce this issue in current master, while I can reproduce #831 .
Close this issue for now.

I'm still experiencing this issue at alpha.10 with angular 2.1.1, I've also created a new plunk which illustrates the bug in a different way if it helps.
http://embed.plnkr.co/Rd7zhws9kIUC223t5pyX/

This will be fixed at alpha.11


fix: correct model type extraction for O1 model handling

User description
https://github.com/Codium-ai/pr-agent/issues/1294

PR Type
bug_fix

Description

Fixed the extraction of the model type to correctly handle Azure O1 models by splitting the model string.
Adjusted the logic to combine system and user prompts for models with the O1 prefix.
This change addresses an issue where the system role was not supported by certain Azure models.

Changes walkthrough 📝
Relevant filesBug fix

litellm_ai_handler.pyFix model type extraction and prompt handling for O1 models

pr_agent/algo/ai_handlers/litellm_ai_handler.py
Extracted model type from the model string using split('/').  Adjusted condition to check if the model type starts with the O1 model prefix.  Combined system and user prompts for O1 models.

+2/-1

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

Persistent review updated to latest commit https://github.com/Codium-ai/pr-agent/commit/dcb7b66fd7963b25c1da1acc764caca9e222cd0e

Generating PR code suggestions
Work in progress ...


Add HamlLint integration test

This caught one thing we forgot to change in the previous refactor.
Also, extract the common test bolierplate into a shared example.

LGTM! :cactus:


Doc/update roadmap

Changes
Describe the Pull Request here. Add any references and info to help reviewers understand your changes.

Updated roadmap to reflect the changes that have been made. Basically, everything under "Planned for v0.2" was moved under the "Released" header.

Tests applied

Documentation change, no tests required.

Issue ticket number(s)

#81

Checklist

[ ] Documented
[ ] Linting tests successful
[ ] merge updated prod branch into development branch

LGTM!