Convert to attrs, remove runtype

A replay of accidentally closed #720.
Short-term goal:  resolve an issue where runtype cannot check isinstance() check, where the type is a string "Database" coming from Compilar.database: "Database".
Technically, it is a typing.ForwardRef[] and must be resolved to actual classes on usage. attrs and pydantic do that.
There is no way to convert it to a regular class, because there is still a circular class dependency Database <> Compiler.

Long-term goal: Since we are moving in the direction of strict type checking, let's make the first step: replace runtype with lots of implicit logic and not compatible with MyPy, with attrs, which require explicitness and work fine with MyPy & IDEs.
attrs is much more beneficial:

attrs is supported by type checkers, such as MyPy & IDEs
attrs is widely used and industry-proven
attrs is explicit in its declarations, there is no magic
attrs has slots

But mainly for the first item — type checking by type checkers.
And since we switch to attrs for already dataclass-like types, also expand it to all other (unannotated) classes to ensure proper attribute management in multiple inheritance.
In particular, in the last commit, there are a few cases where the code was ambiguous and had to be resolved by minor remakes.

It is better to review commit-by-commit.

@nolar  Just for the record, runtype does support forward-refs and slots, you only had to upgrade to a later version.


Bump casper-node dependencies

Nightly tests are broken again because there was a minor change in StoredValue, this updates casper-types to pull the latest one and fix the tests

Actually the tests will remain broken until this is fixed: https://github.com/casper-network/casper-node/pull/4718


Integrate using Moment or checking file title as input for filter function

Trying to make the Filter section of the code block for a note, change based on the date for this note, its a daily note, with a title of the date.
Describe the solution you'd like
At the moment you are passing just the text for supported filters right into the api, if we can pass the "filter" text through something like Moment.js, or even obsidians connection to Moment.js which it uses for the daily note plugin or for Templated links even just the notes title as a variable, then use its output to give to your connection to the filter api.
Describe alternatives you've considered
Moment.js, or using variables that we can fill in by having it basically be an escape point that also calls obsidian api for its scripts or data like note title.
Or if you could have special filter inputs that would trigger these functions before continuing processes you already have in place.
additional random notes or links
https://forum.obsidian.md/t/daily-note-template-with-tomorrow-and-yesterday-links-and-annual-folders/27035
https://momentjs.com/docs/#/displaying/format/
https://help.obsidian.md/Plugins/Daily+notes

Sorry I was just rereading the main.js and on line 1660 var formatting tokens I say Moment formatting, so it should be easy to check for those in the filter input and then convert to text output before damping it into the api send.

Found my own work around using the templater plugin (https://silentvoid13.github.io/Templater/docs/) to set the variables myself and having them convert to string on new doc load from templates, but if there were a way for you to implement it a little smoother directly that would still be amazing.

Found my own work around using the templater plugin (https://silentvoid13.github.io/Templater/docs/) to set the variables myself and having them convert to string on new doc load from templates, but if there were a way for you to implement it a little smoother directly that would still be amazing.

Would you mind sharing your work around? I'm currently trying to implement the following query inside my daily note template, using Moment.js and the Templater plugin:
todoist

{
"name": "Today",
"filter": "<% moment(tp.file.title, 'YYYY-MM-DD').format('MM/DD/YYYY') %>"
}

However, I get this Error: There's a problem with your filter: "Unrecognized symbol <"
I wanted to filter only the tasks for this specific day, so I'm able to see them afterwards. Don't know if that's possible. Anyway, thanks in advance.

I am sorry, I haven't messed with the main idea of this thread for nearly 10 months, last I had, I was using a daily notes "date format" as YYYY-MM-DD/filename with as a way to push it into a folder that then has todays (moment without having to be called like you tried) date , pulled that into todoist using tp.file.filder and I gave up and just settled on that.
ex:
{
"name": "by end of <% tp.file.folder() %> these need to be done",
"filter": "due by <% tp.file.folder() %>",
"sorting": ["date"],
"group": true
}

But there has been updates since then. Like tp.file.rename(new_title: string)
Hope that helps, I may get back into obsidian md. later but life is nuts at the moment.


VTK Extension

Hi, i can't add the VTK extension on my viewer, i'm trying to add it under a laravel project,
I've follower exactly these steps:

Downloaded the repository from https://github.com/OHIF/Viewers.git
Then, from the root folder of the project  i run: yarn config set workspaces-experimental true , yarn install , yarn run build:package
under /extensions/vtk/src/index.js i've run yarn run build-package
then i've took the file created under the dist folder both for the viewer and the vtk extension)
After that i've correctly i mported that in my laravel project.
the app-config file looks like this (in the first part):
 window.config = {
 // default: '/'
 routerBasename: '/',
 extensions: [OHIFExtDicomPdf,OHIFExtDicomHtml,OHIFExtDicomMicroscopy,OHIFExtDicomSeg,OHIFExtVtk],
 showStudyList: true,
 filterQueryParam: false,
 servers: {
 dicomWeb: [
 {
 name: 'DCM4CHEE',
 wadoUriRoot: 'http://<IP_ADDRESS>:8080/dcm4chee-arc/aets/DCM4CHEE-DELL/wado',
 qidoRoot: 'http://<IP_ADDRESS>:8080/dcm4chee-arc/aets/DCM4CHEE-DELL/rs',
 wadoRoot: 'http://<IP_ADDRESS>:8080/dcm4chee-arc/aets/DCM4CHEE-DELL/rs',
 qidoSupportsIncludeField: true,
 imageRendering: 'wadors',
 thumbnailRendering: 'wadors',
 enableStudyLazyLoad: true,
 supportsFuzzyMatching: true,
 },
 ],
 },
the main view looks like this:

  You need to enable JavaScript to run this app.

In the view i got this error: ToolbarRow: Minified React error #321; visit https://reactjs.org/docs/error-decoder.html?invariant=321 for the full message or use the non-minified dev environment for full errors and additional helpful warnings.

Thank you for your past contributions and for raising this issue related to legacy versions of our OHIF Viewer. Your time and effort have been invaluable in helping us improve the product.
We wanted to update you that our development focus has shifted to OHIF Viewer v3, which is now available for testing on viewer-dev.ohif.org. This site is deployed from our master branch and incorporates new features, optimizations, and bug fixes. If you're still using viewer.ohif.org, it's worth noting that this is deployed from our release branch and may not have the latest updates. You can read more about our branching strategies here.
Given the move to Version 3, we are closing older issues that pertain to Versions 1 and 2, as we are no longer providing support for those versions. If you find that the issue you've raised is still relevant in Version 3, we encourage you to reopen this issue or create a new one for proper triage.
Thank you for your understanding and continued support.


Add properties for long and short bank name to BIC

This pull requests enables getting a bank's name and short_name as bank_name and bank_short_name properties of a BIC object. This data is already present in bank-registry.json .
This also adds the two new fields to the appropriate tests. Testing is refactored to avoid checking the same thing multiple times. The order of the BIC properties in the code is changed to follow the structure of a BIC. Additionally, a docstring typo is fixed.

I have added another commit containing the requested changes.


Set up CI

Using Github Actions

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@9229df0). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             develop        #2   +/-   ##
===========================================
  Coverage           ?   100.00%
===========================================
  Files              ?         1
  Lines              ?         3
  Branches           ?         0
===========================================
  Hits               ?         3
  Misses             ?         0
  Partials           ?         0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9229df0...69ccb2b. Read the comment docs.


better tree-shaking... compile ts to ESM (before bundling)

Pre-Flight checklist

[x] Testing

[x] Changes have been manually tested I have not tested that sentry actually reads these source maps; I think we can wait till for QA servers for that.

What are the relevant tickets?
Related to #1033, #1034
What's this PR do?
This PR changes the way we compile TS before being bundled by webpack: In our tsconfig, we had module set to CommonJS, whereas it should be set to ES6 As the Webpack Typescript docs say,

Warning
ts-loader uses tsc, the TypeScript compiler, and relies on your tsconfig.json configuration. Make sure to avoid setting module to "CommonJS", or webpack won't be able to tree-shake your code.

How should this be tested
There should be no noticeable changes, other than that the output of yarn build:webpack should be a bit smaller.
You could...

Check the site still looks ok at on the netlify builds
If you want:

Run yarn build:wepback. It should succeed and the js file sizes (ls -lh base-theme/dist/js) should be a bit smaller than they are on main branch.

Run a site in production mode on this branch, e.g., by

Build a site for production. Assuming your ocw-content-rc and ocw-hugo-projects directories adjacent to ocw-hugo-themes, yarn build ../ocw-content-rc/9.40-spring-2018  ../ocw-hugo-projects/ocw-course-v2/config.yaml
Serve the built course: npx serve ../ocw-content-rc/9.40-spring-2018/dist.
Open the url that serve displayed in your terminal and check that the soruce code is viewable:

Again, there should be no noticeable changes.

Background Info
The "module" config setting tells Typescript what module syntax to use when compiling TS files into JS files. Specifying ES6 means use ES6 import/export. Note: This ES6 import syntax does not end up in the final bundles. Again, from Webpack docs](https://webpack.js.org/concepts/manifest/):

No matter which module syntax you have chosen, those import or require statements have now become webpack_require methods that point to module identifiers.

The advantage of compiling TS to JS is better tree-shaking (removal of unused code). It's not a huge difference at the moment:
                commonjs    es6
main.js	        323 kb	    313 kb
www.js	        580 kb	    516 kb      <-- biggest difference
course_v2.js	866 kb	    864 kb

but it's free, and I expect in the future it could matter more. (For example: I came across this issue while working on #1037, which I have decided to set aside. While working on #1037 , I found that because of changes in how Sentry organizes their code in v7, we Sentry v7's footprint on our bundle would be 54kb instead of 20kb without this config change.)

If you're interested and want to see this in action with our config, you can check out https://github.com/mitodl/ocw-hugo-themes/tree/cc/ts-esm-experiment. That branch defines three new files (just for testing):
// example_dog.js
export const dog = 'dog'
export const woof = (n: number) => 'woof'.repeat(n)

// example_cat.js
export const cat = 'cat'
export const meow = (n: number) => 'meow'.repeat(n)

// example_entry.js imports from cat and dog
// but does not use all of cat
import { cat } from "./example_cat"
import { dog, woof } from "./example_dog"

console.log(cat, "...?")

console.log(dog, woof(3))

Note that the meow function is unused. If you run the webpack build:

if tsconfig module: commonjs, meow is included in the build output
if tsconfig module: ES6, meow will be omitted


Migrate flutter_tool plugins.dart to null safety

Separate null-safe Plugin class from all the null unsafe project-dependent loading logic.
Will allow FlutterManifest to be migrated.
Part of #71511

Will rebase on https://github.com/flutter/flutter/pull/80242 when that lands


in k8s v1.16 or 1.17 can't create broker

Bug Report
helm list
NAME      	REVISION	UPDATED                 	STATUS  	CHART               	APP VERSION	NAMESPACE
catalog   	1       	Thu Jan 16 17:44:51 2020	DEPLOYED	catalog-0.3.0-beta.2	           	catalog
when i  create minibroker
helm repo add minibroker https://minibroker.blob.core.windows.net/charts
helm install --name minibroker --namespace minibroker minibroker/minibroker
What happened:
i get error messages:
Error: release minibroker failed: Internal error occurred: failed calling webhook "mutating.clusterservicebrokers.servicecatalog.k8s.io": Post https://catalog-catalog-webhook.catalog.svc:443/mutating-clusterservicebrokers?timeout=30s: EOF
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

Kubernetes version (use kubectl version):   v1.16 or v1.17
service-catalog version:   catalog-0.3.0-beta.2
Cloud provider or hardware configuration: local k8s  cluster
Do you have api aggregation enabled?

Do you see the configmap in kube-system?
Does it have all the necessary fields?

kubectl get cm -n kube-system extension-apiserver-authentication -o yaml and look for requestheader-XXX fields

Install tools:

Did you use helm? What were the helm arguments? Did you --set any extra values?

Are you trying to use ALPHA features? Did you enable them?

Hello, the issue is still reproducable in 1.18

was there any resolution to abovr ?

In my case I think I'm having this error because minibroker doesn't support ARM64. The pod is created but if you try to get the logs, you see standard_init_linux.go:219: exec user process caused: exec format error which means that the binary cannot be executed. I've opened an issue about it https://github.com/kubernetes-sigs/minibroker/issues/120


1.0.3 crash with Quiverbow

Description: Crash when opening up the inventory of the Stone Crafting Table, the Crafting Table Frame, or the Nether Crafting table. Quiverbow must be present to replicate the issue.
Quiverbow version: b100
CraftingCraft version: 1.0.3
Crash Report: https://gist.github.com/69041189dc0993fc480c

This is an issue on Quiverbow's side. They're trying to access a slot that doesn't exist ("tenth" slot in the crafting grid). The default crafting inventory has a check to prevent the crash from happening, but that's dumb and unnecessary as long as people use it correctly.
I'm going to add the failcheck to my code, but you should really bring this to the Quiverbow devs to get it fixed there. They shouldn't rely on people doing bounds checks, especially when they already know the inventory is only nine slots big.

Just found a newer version of Quiverbow (101b), but I still get the same crash with CraftingCraft 1.0.3. So yeap I will report it to them thanks =)

It has been reported to Quiverbow and will be fixed on their next update :)


Fixed bug 2097 - Parsing error

Fixed #2097 --Paired with Branden Youssef (byousse2)
The problem is there is a parsing error for .TaskCellBag. KRun.compilePattern cannot parse .TaskCellBag. After treating it as .Bag, now --pattern option prints out the correct solution.
public Object execute(K k, Rewriter rewriter, CompiledDefinition compiledDefinition) {
Rule pattern = null;
if (kRunOptions.pattern != null) {
//Fix the .TaskCellBag bug for issue #2097
if(kRunOptions.pattern.equals(" .TaskCellBag ")){
kRunOptions.pattern = " .Bag ";
}
pattern = KRun.compilePattern(files, kem, kRunOptions.pattern, kRunOptions, compiledDefinition, Source.apply(""));
}
┆Issue is synchronized with this Asana task

Special-casing for this input pattern is not a real fix for this problem. Let's discuss on the issue thread to figure out the bug.

Close this PR exercise in the class.


How to read data fields?

pdftk dump_field_data_fields  works fine on my test.pdf returning all field data correctly.
How to achieve this with fpdm? Fields returning empty array:

I solved it after some look into the code. To be more precise what I meant here:
I wanted to output all names of fillable form fields. The FPDM class saves these into FPMD->value_entries. These are getting populated after calling $pdf->merge().


Adding Plugin documentation

The Plugin.md was missing, likely because it had not been added as a tracked file in this repo.

Not needed after all.


Please don't change project URLs without letting project teams know!

Sometime recently the # has been dropped from the project URLs so that, e.g.
https://www.zooniverse.org/#/projects/kosmala/season-spotter-questions/classify/
is now
https://www.zooniverse.org/projects/kosmala/season-spotter-questions/classify/
This breaks all the links I have from outside websites and social media (including our landing page)!
Tagging @khufkens who will also be affected...

This changed over a month ago. It was being automatically redirected, but the redirect must have been broken yesterday.

Closing this since it's covered by zooniverse/Panoptes-Front-End#1716


Support multiple subscript operator in proxified PyObjects.

The following way to use multiple values below work:
df.item(['Age', 'Fare']).median().type
'Series'

Is possible to support something without relying in manual calling the .item() ?
This works:
df['Age'].median().type
'numpy.float64'

This is wrong (since should be a Series, and not a float value):
df['Age', 'Fare'].median().type
'numpy.float64'

This does not work:
df[['Age', 'Fare']].median().type
Uncaught TypeError: Cannot read properties of undefined (reading 'median')

Not really. item() exists for a reason. In JavaScript the subscript operator is much more limited. It accepts only scalars.
For example this:
p['a', 'b']

is functionally equivalent to
p['b']

'a', 'b' evaluated in a scalar context is 'b'.
There are cases where using [] works, but it is not supported and you are on your own risk. Only a function as .item() can accept all the values that Python can accept.

In case you haven't seen my profile, I am currently living on social welfare because an ex-employer is extorting me with the help of the French police and the French judiciary over a series of false judicial proceedings, including some very serious allegations, in order to cover up his intimate personal problem. In order to further intimidate me, people are simultaneously posting on my projects. Yours is one, it is posted simultaneously with a StackOverflow issue with similar content. You don't happen to know anything about this affair?


hidden dependency descriptastorus gone from release 4.2.6

Hi,
While using the chemprop module, something failed due to the absense of the descriptastorus package on Reinvent 4.2.6, while everything was working with 4.0.35. I noticed that the installation does not include that dependency anymore. Is this intended?
Reference in the code, even if I was facing some loading issues with it, so I'll also comment it there:
https://github.com/MolecularAI/REINVENT4/commit/a2c2287495f6c5e26659212c8e5fd16c295f994b#diff-d30f07d3b5c96037dfa1d196cb69cd4357dfea99c425a170c8ebab83368ffa3cL26-L27

Many thanks for the report.  We will put it back in again.

@halx I've seen this is completed, but I don't see any changes to the code. Will there be a tagged released for the fixed version? Thanks in advance!


Update auto.mdx

Changed "run dev" command to "astro dev"

Description (required)

Related issues & labels (optional)

Closes #
Suggested label:

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉
Here’s what will happen next:

Our GitHub bots will run to check your changes.
If they spot any broken links you will see some error messages on this PR.
Don’t hesitate to ask any questions if you’re not sure what these mean!

In a few minutes, you’ll be able to see a preview of your changes on Vercel 🥳

One or more of our maintainers will take a look and may ask you to make changes.
We try to be responsive, but don’t worry if this takes a few days.

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File
Note
Locale

src/content/docs/en/install/auto.mdx
Source changed, localizations will be marked as outdated.
en

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Hi @suvires ! As Atharva mentioned, we prefer to show the general scripts appropriate for the various package managers. So I'll be closing this PR, but we appreciate your efforts to help us keep the docs updated and correct! Please do make another PR if you spot an error in future!  :rocket:


Create tiny-slider.module.js

this is the fix for the Issue with Webpack module loading with React, i.e. #20
Now. from a React Component it is to be imported like below:
import tns from 'tiny-slider/dist/tiny-slider.module'
And inside the React Component it can be used as the documentation suggested.
Ex:
tns({
    ...
});

Thanks @tzsk ,
May I know the details of the fixing?

Change function name from tns to tinySlider
export default tinySlider at the end
Right?

So you tried to import "/src/tiny-slider.module.js", and it's not working?

@ganlanyuan Yes. That's exactly the change I've made and it is working now.
I've tested it with create-react-app and react-webpack-redux
But strangely the /src/tiny-slider.module.js is not working with any of them.
The thing that is bugging me is that, I've also tested it with Angular 2/4 and for that, the new file is not working but the old file i.e. src/tiny-slider.module.js is working fine.

I see,
Is there any requirement for react to load plugins? Like a config file or
something else.
On Thu, May 11, 2017, 5:07 AM Kazi Mainuddin Ahmed<EMAIL_ADDRESS>wrote:

@ganlanyuan https://github.com/ganlanyuan Yes. That's exactly the
change I've made and it is working now.
I've tested it with create-react-app
https://github.com/facebookincubator/create-react-app and
react-webpack-redux
https://github.com/stylesuxx/generator-react-webpack-redux
But strangely the /src/tiny-slider.module.js is not working with any of
them.
The thing that is bugging me is that, I've also tested it with Angular 2/4
and for that, the new file is not working but the old file i.e.
src/tiny-slider.module.js is working fine.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ganlanyuan/tiny-slider/pull/39#issuecomment-300730185,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AExGm-kCpP55WEpvaviXCMFddiDxjr_fks5r4s_ngaJpZM4NXF7Y
.

Is this PR ready to merge? I would love to have the npm package updated so I can start using the module.

Merge it for now.

Thanks so much @ganlanyuan. Can you publish the npm package as well?

v1.5.1 was published.

@ganlanyuan Sorry for the late response. But I was looking for other solutions to make it work other than using two separate file for React and Angular 2. And I have found something. In the new way we don't need the new file that I have created. And both Angular 2 and React can use the same file and the API Docs that you wrote in README.md doesn't need to change.
In the new way we can call the file the same way as the docs suggest.
import { tns } from 'tiny-slider/src/tiny-slider.module'

I'll post the PR right away.


handle properly no connected adapter

I was also planning to provive PR for version 5.4.X, but seems there is no branch for that.

I was also planning to provive PR for version 5.4.X, but seems there is no branch for that.

I've encountered the error above in production environments -- would be great to get this fix in. @fliespl are you available to update the code so it passes tests? I believe the main issue is the linter, though it would probably be good to have an accompanying test too.

Merged as https://github.com/socketio/socket.io-redis/commit/6c8d7701962bee4acf83568f8e998876d3549fb8 and included in<EMAIL_ADDRESS>Thanks!


Processors help needed

Hi ,
I am trying write a processor to get the interface value from the following output elem:{name:"component"  key:{key:"name"  value:"Ethernet51 transceiver"}}
How do I ensure I just write the value Ethernet51  into a field called interface ?
here is the processor
processors:
  # processor name
  value-names:
    # processor type
    event-strings:
      value-names:
        - ".*"
      transforms:
        # strings function name
        - path-base:
            apply-on: "name"
  dom-interface:
    event-strings:
      value-names:
        - "component_name"
      transforms:
        - split:
            split-on: " "
            apply-on: "value"
            ignore-last: 1

Actual output from the GNMIc sub
2023/04/26 18:13:37.037382 /home/runner/work/gnmic/gnmic/app/collector.go:70: [gnmic] target "<hostname>": gNMI Subscribe Response: &{SubscriptionName:dom SubscriptionConfig:{"name":"dom","paths":["components/component/transceiver/physical-channels/channel/state"],"mode":"stream","stream-mode":"ON_CHANGE","encoding":"JSON","sample-interval":10000000000} Response:update:{timestamp:1682532817035136419  update:{path:{elem:{name:"components"}  elem:{name:"component"  key:{key:"name"  value:"Ethernet51 transceiver"}}  elem:{name:"transceiver"}  elem:{name:"physical-channels"}  elem:{name:"channel"  key:{key:"index"  value:"2"}}  elem:{name:"state"}  elem:{name:"input-power"}  elem:{name:"instant"}}  val:{decimal_val:{digits:-3512779136222477  precision:16}}}}}

Also is it possible to take a hostname - and split parts of it into tags
say
Example hostname:
region-location-rack-role-foo-01
I want tags:
region=region
location=location
rack=rack
role=role

You can use the starlark processor:
(not tested)
processors:
  # processor name
  split-source-tag:
    # processor type
    event-starlark:
      source: |
        def apply(*events):
          for e in events:
            source = e.tags["source"]
            items = source.split("-", 5)

            # if the number of items is not 5 skip the event message
            if len(items) != 5:
              continue

            e.tags["region"] = items[0]
            e.tags["location"] = items[1]
            e.tags["rack"] = items[2]
            e.tags["role"] = items[3]
            # uncomment the next line to remove `region-location-rack-role-` from source.
            # e.tags["source"] = items[4]
          return events

When using the event-strings processor, you can filter which values the transform(s) apply to using the regex in value-names: ( or tag-names, ...).
In your case, to apply an event-string processor to a value coming from subscription interface_counters you can set:
value-names:
  - "^/interface/state/counters" # i.e a value name that starts with `/interface/state/counters`

You have to consider the order the processors are applied as well, if you change the value name in one processor you will have to set a matching regex in the next processor.


Update Menu/About text

The text has bad grammar and was written for HEN goals. Consider updating it for Teia community goals.

included in this issue: https://github.com/teia-community/teia-ui/issues/22

i will work on a new copy text for the about page

will add the text once it is finished to the copytext collection issue here: https://github.com/teia-community/teia-ui/issues/34


Labels not raising on click

Description
Rails, materialize-sass gem, labels not raising on click.
Repro Steps
Go to http://inventory.dk0.us

Seems the JavaScript code is not initialized / executed?
Because when I add this again manually it works. The code is in your js file.

Oh wow, never thought of that, trying it now. Thanks!

Placing JS at the end of the page does not resolve the issue.

@dkudriavtsev you're using turbolinks? you need to use initialise after the DOM is reloaded again with Materialize.updateTextFields();

@fega Says "not a function"

Also happens on first page load

you're usig jquery 1, Materialize need Jquery needs 2+

@fega OMG THANK YOU I HAVE BEEN TRYING TO GET THIS SOLVED FOR MONTHS


Ensure stars are behind spaceship

the order things are added to the arena matters.
fixes: #8
fixes: #9
fixes: #10

@ezzini this should be good to merge.

Thank you for fixing that!


Reduce dependencies size

This PR reduces the dependency tree of the package by replacing some dependencies with more lightweight alternatives. Closes #978.
Changes made

[x] replace chalk with colorette

this also adds supports-color since colorette doesn't provide this functionality

[x] replace cosmiconfig with lilconfig

this also adds js-yaml since lilconfig doesn't provide YAML parsing

[x] replace log-symbols with a patched version
[x] patch listr2 to remove Chalk

@ai
I have tried to reduce the size of node_modules but I think I ended up increasing it 😅

It turned out to be almost useless to try and remove such packages as chalk, cosmi-config, and others, since chalk still exists in listr2, replacements for which I couldn't (yet) find. Other packages (be it taskz, listr3, or listr) all implement chalk as well.
Another dependency hoard comes from execa, which is also semi-irreplaceable. One could, of course, use child_process.spawn() and lose all benefits of execa...
I could also go and patch listr2 and execa, like I did with log-symbols, yet I don't know if I'll be ready to maintain those patches.
What would be the best solution for this project?

P. S. I can't quite understand why some tests are failing. Apparently, log-symbols now uses Unicode (although it didn't).
What I can understand is that fixed-width-string introduces unwanted white spaces (i.e. pads strings), unlike cli-truncate

Honestly, I think we are already using the most minimal amount of dependencies possible. Of course those dependencies might have a lot of extra cruft, but I don't think lint-staged directly has anything extra. I've tried to slim down unnecessary stuff and also keep them updated.
Tests might fail because log symbols differ based on platform, and tests might work around this by mocking or serializing them differently.

I also question this work unless there is something obvious. I think the easiest way to reduce the size is for all libraries to only ship a minimal required files but I don’t see how lint-staged itself can solve this. Also is 21 MB really a problem for a Dev dependency? To me this kind of work add little to no value but costs a lot of time.

We could try a separate package.json for lint-staged's tests using yarn workspaces. Most of the dependency size is probably due to those, so maybe if they're separated into a subdirectory, it might reduce the main install size.

Hmm that’s interesting idea indeed. Is there a native npm behavior that could help us? Something like optional dependencies that are then installed on CI? I’m wondering why are dev dependencies are installed when ping-staged added as a dependency and if we could look into that somehow?

Nope, the dev dependencies aren't being installed when performing npm i lint-staged or similar. 20 MB are the production dependencies; dev dependencies take extra ~200 MB

20 MB of dependencies is a lot. The problem is that most of them is package.json, README.md, CHANGELOG.md, tests.
Seems like the listr2 is a source of the problem. It is alone adds 18 MB to node_modules.
How hard it will be to create a tiny analog or reimplement it in lint-staged?

Honestly, I think we are already using the most minimal amount of dependencies possible.

It is not is you will count sub-dependnecies. https://npm.anvaka.com/#/view/2d/lint-staged
There are 94 dependencies in lint-staged.

listr2 has been very convenient. It basically handles all the cli graphics for us without us having to really think about. In addition to the display, we use it as a task runner. I'd say it's not feasible to try and reimplement it.
Maybe this effort could be focused directly on listr2? That would also benefit lint-stagedgreatly.

Maybe this effort could be focused directly on listr2?

Yeap. Seems like it is better to send PR to listr2.
If we accept this PR (chalk→colorette) it will help it PR to listr2.

If listr2 changes to colorette, we can follow the decision here no problem. Let's start that way, and we can link to discussion here. I believe lint-staged is a major user of listr2 so I'm sure we can come to an agreement on that.

One major feature to consider is the supportsColor method, which we (try to) use to detect simpler shells, vs fancy terminals:
https://github.com/okonet/lint-staged/blob/4f9a146708862b06d19c7627f4dd1b094b2b88ce/bin/lint-staged.js#L8-L11

One major feature to consider is the supportsColor method, which we (try to) use to detect simpler shells, vs fancy terminals

supportsColor is actually a part of the supports-color package, which I included together with Colorette.
It is also to be noted, that Colorette, apparently, offers its own, albeit simpler implementation, where colorette.options.enabled signifies, whether colour is supported or not (without specifying the amount of colours)

I have posted a PR to listr2: https://github.com/cenk1cenk2/listr2/pull/408; let's see, what they say

Nice work @NickKaramoff, seems like it got already merged.
Maybe if we reduce this PR to only target replacing chalk with colorette, and wait for an updated listr2 with the same change, we could get a nice result.
Let's handle the other dependencies in separate PR's.

I have reverted the removal of cli-truncate since the package I used instead, fixed-width-string, behaves differently.
I have also updated listr2, and the size of the package dropped to 15 MB, shaving off 5 MB 🎉
Apart from that, all the other packages indirectly remove Chalk (it can be found as a dependency in both cosmiconfig and log-symbols). I'd leave the PR as it is

Now, when it comes to testing, I find it bizarre that the AppVeyor builds are now broken. Apparently Jest expects the CLI o=to output non-Unicode characters from log-symbols (e.g. √ instead of ✔). Yet, I don't understand why that is expected and why it wasn't the case before. It's no matter whether one uses Sindre's log-symbols or mine — they both depend on is-unicode-supported.
Should we just update the Jest snapshots?

Very strange that Unicode symbols were not used in CI. According to is-unicode-supported we should have Unicode symbols before.
I found that in main branch log-symbols was not even called during tests (just add throw new Error to log-symbols). Seems like something mock log-symbols.
(I also think that we should not use log-symbols dependencies at all. It is so simple that it is better to move it to utils/messages. Docs + package.json for these dependencies is bigger than their code.)

I believe we use log-symbols because listr2's tasks also use it to display status of the tasks, and we want to show additional messages with the same symbols.
it might be that the Appveyor terminal doesn't suppor colors and so they're not used "on Windows"... what about the tests running on GitHub CI?

it might be that the Appveyor terminal doesn't suppor colors and so they're not used "on Windows"... what about the tests running on GitHub CI?

The same. It is not connected with CI.
If you run Jest locally log-symbol/index.js will not be called too (but it was called when you execute lint-staged binary manually). There is a mock somewhere, which blocks log-symbols/index.js for Jest environment.

I believe we use log-symbols because listr2's tasks also use it to display status of the tasks, and we want to show additional messages with the same symbols.

listr2 doesn’t use log-symbols. It uses is-unicode-supported and figures

Thanks for the clarification, it has been some time since I've touched these.
This should be the auto mock file:
https://github.com/okonet/lint-staged/blob/master/test/__mocks__/log-symbols.js
I think it would be preferable to use the same packages as listr2 instead of inlining code, since that would reduce duplication, yes?

This should be the auto mock file:
https://github.com/okonet/lint-staged/blob/master/test/mocks/log-symbols.js

OK, I see. I'll figure out how to fix it and update the PR 👌

I think it would be preferable to use the same packages as listr2 instead of inlining code, since that would reduce duplication, yes?

Theoretically yes, but it would save even more space if both listr2 and lint-staged would inline this code. The changes to the former were proposed (https://github.com/cenk1cenk2/listr2/pull/412) and will probably be accepted today

@NickKaramoff it would perfectly fit us if we could import and use those same symbols directly from listr2

Implemented this exactly in this way

I've tried my best to fix the CI. Some stuff (like extra white spaces) were existent before this PR (at least on my machine) and some new stuff was introduced, which has to do something with Git... I honestly do not understand this happens 😅

@NickKaramoff Honestly, I don't have any idea either. I've also had a lot of trouble trying to figure out why (especially) Appveyor tests behave like they do... It would be nice to ditch that and use GitHub Actions for all platforms.
Now one thing that seems directly related in the test snapshots is this:
https://github.com/okonet/lint-staged/pull/981/checks?check_run_id=2705272685#step:10:812
The new line has a space at the end, while old doesn't:
---    - ERROR
+++    + ERROR

The new line has a space at the end, while old doesn't:
---    - ERROR
+++    + ERROR

@iiroj sorry that it took to long to reply. This issue is weird, since this particular line of output you've linked to is being printed out by logger.error() in lib/index.js; I don't see any plausible reason for it to print a space 🤔

Found it! It's consolemock's fault

Apparently, when using a console method without any arguments, it adds an extra space to the output, which, I guess, it didn't do before?

This PR https://github.com/okonet/lint-staged/pull/1003 merged an updated Listr2, which recently had a cleanup of its own dependencies. I also re-used the figures exported by it.

I have come back and rebased the changes made independently of this PR. Now it only replaces cosmiconfig with lilconfig, the rest was done in other PRs
On a good not: I discovered the error with the tests. I didn't notice that I myself committed the wrong snapshots. This happened because of EditorConfig automatically removing trailing whitespace 😅 Now the tests should run smoothly


net/wireguard show gui names in configurations

Would like to see this - any reason it has not been merged?  The reason I don't use the widget is listing the public key on it is sort of meaningless to know who is connected.  Listing the name assigned would be much better.

@fichtner This looks like a nice addition that was forgotten at some point. Still worth to merge it?


Evaluation of nested objects in expressions does not work

Hi, I have found one more issue connected with https://github.com/Polyconseil/vue-gettext/issues/23 when evaluating nested objects in nested components:
<template>
  <!-- ... -->
    <md-layout>
        <translate>User: %{ user.firstname }</translate>
    </md-layout>
  <!-- ... -->
</template>

The result is:
User: user.firstname
(plus some warnings in console Cannot evaluate expression: "user.firstname".)
Problem occurs when the function evalInContext tries to evaluate:
eval('this.' + nested_expression)  === undefined
which throws an error instead of continuing into the parent component. The solution might be to check the expression with nested object more carefully (or somehow prevents the eval in condition to throw an error)
// check if "this" object contains "expression"
var result = expression.split('.').reduce(function (value, index) {
   return (value || { })[index]
}, this)

if (result === undefined && this.$parent) {
  return evalInContext.call(this.$parent, expression)
}

The code above is inspired by this topic

Previous commit broke recursion. I'll fix it ASAP.
See: https://github.com/Polyconseil/vue-gettext/commit/29c5673aff7b7712d7ced61c003e6d3b55e68873#commitcomment-22242469


Automate release to marketplace

With github actions.

I've added the secret in the org.

Can you make a release?

Let me try in 5 min

@am7c7 Can you see it? The action has completed w/o errors

Yes, great.


Unexpected unsign passing on a random signature postfix

Hi dear team.
Thank you for the amazing project!
This is my reproduce example:
const cookie = require('cookie-signature');
const value = 'value';
const secret = 'secret';
const signed = cookie.sign(value, secret);
const result = cookie.unsign(signed + 'some', secret);
console.log(result)

I expected to see a false result. But got a 'value'.

Thanks for the report and helpful example!
Just to be clear for anyone else following along, I wouldn't consider this a vulnerability since the cookie must still be properly signed for it to happen.
But I agree that this is a regression introduced during another bugfix. So I think it's safe to assume (for semver purposes) that nobody should be relying on this bug and we can fix it.
It happens in the chain of events where val is silently truncated when copied into a buffer for comparison purposes:
valBuffer = Buffer.alloc(macBuffer.length);
valBuffer.write(val);
return crypto.timingSafeEqual(macBuffer, valBuffer) ? str : false;

We do need valBuffer to be the right length otherwise timingSafeEqual will throw an exception but we should probably check that .write(val) was the expected size. This might be a bit tricky w.r.t. UTF-8 encoding, i.e. the expected size is not going to always equal val.length! (That situation is hopefully not super common with actual Cookie headers but people could be using this algorithm in other contexts where non-ASCII data doesn't need to be handled as carefully.)

I've got a proposed fix for this in #41, but am waiting for some other maintainers to sign off on it before merging it in.
If this bug is blocking your own development you could npm install tj/node-cookie-signature#nvw-unsign-fixes in the meantime but I suspect most users can wait until the fix is reviewed and published.


Error to generate predictions

I already train a base model with some annotations, but when I try to generate predictions to correct inference the following error appears: ERROR: generate_superpixel (job 158) failed  and ERROR: generate_prediction (job 157) failed. Checking in .logs error seems to be :
ERROR: Traceback (most recent call last):	  File "make_output_unet_cmd.py", line 147, in <module>	    output_batch = tta_model(arr_out_gpu)	  File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 889, in _call_impl	    result = self.forward(*input, **kwargs)	  File "/usr/local/lib/python3.8/dist-packages/ttach/wrappers.py", line 39, in forward	    augmented_output = self.model(augmented_image, *args)	  File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 889, in _call_impl	    result = self.forward(*input, **kwargs)	  File "/opt/QuickAnnotator/unet.py", line 64, in forward	    x = up(x, blocks[-i-1])	  File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 889, in _call_impl	    result = self.forward(*input, **kwargs)	  File "/opt/QuickAnnotator/unet.py", line 119, in forward	    out = self.conv_block(out)	  File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 889, in _call_impl	    result = self.forward(*input, **kwargs)	  File "/opt/QuickAnnotator/unet.py", line 89, in forward	    out = self.block(x)	  File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 889, in _call_impl	    result = self.forward(*input, **kwargs)	  File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/container.py", line 119, in forward	    input = module(input)	  File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 889, in _call_impl	    result = self.forward(*input, **kwargs)	  File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/conv.py", line 399, in forward	    return self._conv_forward(input, self.weight, self.bias)	  File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/conv.py", line 395, in _conv_forward	    return F.conv2d(input, weight, bias, self.stride,	RuntimeError: CUDA out of memory. Tried to allocate 2.00 MiB (GPU 0; 3.82 GiB total capacity; 1.33 GiB already allocated; 3.25 MiB free; 1.34 GiB reserved in total by PyTorch)
Checking my GPU usage I see that is not fully used up:

But GPU was used when I trained the mode :

I already try to reduce batch size but seems not to have any impact. Im using Ubuntu 22.04 and cuda 11.0

very interesting. looking at the code, the default batch sizes are essentially the same as to what the training process uses (which is more memory intensive), so its not clear why one would work and the other wouldn't
lowering the batch size would seem like the only way to go. have you tried reducing it down to 1? are you doing that in the appropriate sections? each process has its own parameter space:
https://github.com/choosehappy/QuickAnnotator/blob/57a13580a40ea10fe47637b7718bbe7c1051a424/config/config.ini#L65
did you try restarting the flask server and directly running the two commands you mentioned without any training taking place in between?

Thanks for your answer. After I send the issue, I change the batch size to 1 and it works! Anyway, It seems really strange that memory usage supports train process but not inference.

super strange, but glad it worked!


fix(middleware): use correct type name for CA tax withholding query

:tada: This PR is included in version 5.0.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 6.0.0-beta.9 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Slidebars close when clicking canvas - mobile issue

I have slidebars installed in my Wordpress theme and it works fine. However I want users to be able to click anywhere outside of the Slidebars to close them, instead of having to click the link/button again to close.
I found this thread where Adam explained how to add a '.js-close-any' class to the canvas to achieve this:
// Controller
var controller = new slidebars();
controller.init();

// Close any
$( document ).on( 'click', '.js-close-any', function ( event ) {
  if ( controller.getActiveSlidebar() ) {
    event.preventDefault();
    event.stopPropagation();
    controller.close();
  }
} );

// Add close class to canvas container when Slidebar is opened
$( controller.events ).on( 'opening', function ( event ) {
  $( '[canvas]' ).addClass( 'js-close-any' );
} );

// Add close class to canvas container when Slidebar is opened
$( controller.events ).on( 'closing', function ( event ) {
  $( '[canvas]' ).removeClass( 'js-close-any' );
} );

This works fine in the browser (Chrome and Safari) but does not work on my mobile device (iPhone). This is obviously where I really want the functionality. Does anyone have a solution?
Thanks

I remember I was the one posting the solution on that previous thread and just noticed today this "bug" on the iPhone. Any luck finding the solution?

Have you found a solution for this?

@amichel86 Try to use touchstart instead of click for iOS devices.
// Close any
var clickEvent;

if ( navigator.userAgent.match( /(iPhone|iPad)/i ) ) {
  clickEvent = 'touchstart';
} else {
  clickEvent = 'click';
}

$( document ).on( clickEvent, '.js-close-any', function ( event ) {
  if ( controller.getActiveSlidebar() ) {
    event.preventDefault();
    event.stopPropagation();
    controller.close();
  }
} );


Note about re-ordering when using colored output

Thanks, @iannickb. I'm sure this could be communicated better in the docs, but the sorting is mentioned there:

Also, the following formatting is applied: HTTP headers are sorted by name. JSON data is indented, sorted by keys, and unicode escapes are converted to the characters they represent.
https://httpie.org/doc#colors-and-formatting

Btw, the sorting is the result of --pretty=format, not --pretty=colors (both are implied with --pretty=all which is the implicit default for terminal output).


chore: bdd-nh-1583239334 to 0.0.1

chore: Promote bdd-nh-1583239334 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Gltf (compressed using Draco) loses material in cesium1.124, but works normally in cesium1.83

`
  const viewer = new Cesium.Viewer("cesiumContainer");
  var position = Cesium.Cartesian3.fromDegrees(-75.152325, 39.94704, 500);
  var heading = Cesium.Math.toRadians(0);
  var pitch = Cesium.Math.toRadians(180);
  console.log(pitch, "pitch");
  var roll = Cesium.Math.toRadians(0);

  var hpr = new Cesium.HeadingPitchRoll(heading, pitch, roll);
  var orientation = Cesium.Transforms.headingPitchRollQuaternion(position, hpr);
  const url = "./Draco/1-draco.glb";
  const entity = viewer.entities.add({
    position: position,
    orientation: orientation,
    model: {
      uri: url,
    },
  });
  viewer.trackedEntity = entity;
  // viewer.flyTo(entity)

`
Hello developer
Cesium loads Draco processed gltf in different versions, with lower versions functioning normally and higher versions having issues.
1-draco.zip

Trying to load the model will report
Failed to load glTF texture
Failed to load texture
Failed to load embedded image
Image format is not recognized

Examining the GLB will reveal that it contains a texture in BMP format (yeah, "Bitmap"). For some reason, older CesiumJS versions may have been more gracious here, and may have loaded that ~"because BMP can conveniently loaded by the browser anyhow". But this was never a valid glTF, and it's unlikely that this is considered to be an "issue" that will be "fixed".
Here's that GLB with the same texture as a PNG (1.5MB smaller, by the way)
1-draco-fixed.zip
(Bottom line: The issue is unrelated to Draco. The model is just invalid...)

Trying to load the model will report
Failed to load glTF texture
Failed to load texture
Failed to load embedded image
Image format is not recognized

Examining the GLB will reveal that it contains a texture in BMP format (yeah, "Bitmap"). For some reason, older CesiumJS versions may have been more gracious here, and may have loaded that ~"because BMP can conveniently loaded by the browser anyhow". But this was never a valid glTF, and it's unlikely that this is considered to be an "issue" that will be "fixed".
Here's that GLB with the same texture as a PNG (1.5MB smaller, by the way)
1-draco-fixed.zip
(Bottom line: The issue is unrelated to Draco. The model is just invalid...)

Thank you for your reply
You are right, the texture of the original file is image/bpm,
I would like to ask a question, is it necessary for all gltf files to undergo verification by gltf-validator before they can be previewed properly in cesium

I would like to ask a question, is it necessary for all gltf files to undergo verification by gltf-validator before they can be previewed properly in cesium

For CesiumJS (as well as all other glTF viewers), the contract that is set up, based on the glTF specification and the validator, is the following:

When a glTF file complies to the specification - meaning that does not cause errors in the glTF-Validator - then CesiumJS (and any other glTF viewer) should be able to render it. If it can not render it, then this is a bug in the viewer, and should be brought up as an issue.
When a glTF file does not comply to the specification - meaning that it causes errors in the glTF-Validator - then no viewer is required to display it properly. The file simply is not a glTF file...

Both points come with disclaimers:
There may be corner cases when it comes to glTF extensions, or features that are currently not supported. One of the few examples in CesiumJS is that it currently does not support sparse accessors - meaning that there can be cases where a valid glTF can not be displayed properly in CesiumJS. But this specific example is already tracked in an issue.
Conversely, there may be glTF files that are "invalid" in one way or another. And in some cases, certain viewers (like CesiumJS) can still load and display such files. This depends on what exactly is invalid about that file, and whether a certain viewer decides to "ignore" (or otherwise handle) invalid input data. But the point is: Nobody can expect a viewer to display an invalid file.


multiple core feature for derez

obviously

DONE.
I didn't test it yet so it's probably broken, but I'm closing this anyway!


Add a best score

Hello,
With this pull request I added the possibility to see his best score.
The changes

The best score is stored in a data.json (I have add it to the .gitignore).
If the score is higher than the best score, the file is updated.
When the game is finish the best score is printing with the score, like this :  `score: {score} best score: {best_score} `

I have checked that everything works.

Implemented in commit b5ca100


Malformed link

The link from Refernce 27. "What bodies think About: Bioelectric Computation Outside the Nervous System" points to https://distill.pub/2020/growing-ca/youtube.com/watch?v=RjD1aLm4Thg instead of https://youtube.com/watch?v=RjD1aLm4Thg

Fixed.


GNU HURD and nsd.c:352:19: warning: cast from pointer to integer of different size

Hi Everyone,
I'm testing nsd master on GNU HURD. The HURD image is dated JAN 2020, and is fully patched. HURD is a GNU Linux operating system with a personality. It is also i386, not x86_64.
Bootstrap and configure go well. Below is the output of make.
gcc -I. -I/usr/local/include -g -O2 -flto -c nsd.c
nsd.c: In function ‘find_device’:
nsd.c:352:19: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  352 |    len = (size_t)((uintmax_t)colon - (uintmax_t)ifa->ifa_name);
      |                   ^
nsd.c:352:38: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  352 |    len = (size_t)((uintmax_t)colon - (uintmax_t)ifa->ifa_name);
      |                                      ^

I am not familiar with the use of the uintmax_t type. I believe the way to proceed is, (1) add std=c99 compile option; or (2) cast the pointer to a uintptr_t. Though uintptr_t is optional, it is ubiquitous based on my testing.
(This was encountered after clearing https://github.com/NLnetLabs/nsd/issues/73).

Yes, thank you.  The uintptr_t is exactly the right fix.  Committed that.


app.logger and get_logger() is not working untill app.start()

due to the case, that logger in separate process cannot be started before name == "main" - it was decided to initialize logger only at the app.start(), but I've got some cases, when I need logger before.
We need to invent a way, how to do that

Use os.environ["PANINI_TEST_MODE"] = "true"


Removed invalid tag around npm commands

there was a incorrectly placed js tag around some npm commands

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@amahlaka : Thanks for your contribution to the Azure documentation! The author, @CarlRabeler, has been notified to review your proposed change.

@amahlaka : Thanks for your contribution to the Azure documentation! The author, @CarlRabeler, has been notified to review your proposed change.

#sign-off
Thank you @amahlaka


Cycle toggle (demo) - Dynamic aria-selected doesn't work when value is last span -> wrong children?

Hi
In your page: here
Cycle toggle doesn't work when selected span is after the value we want to affect
if you select  😀 (last span), you'll not be able to apply to 🙂

in your demo page you maybe set the wrong children?

Yeah, you need to remove the existing aria-selected attribute first.


Not finding outdated modules

I ran it once and it showed all of my outdated deps. I ran it a few hours later and now it only shows 3 out of ~20 that are outdated.
npm outdated shows all of the outdated packages still

My mistake. I had rm -rf node_modules and re-ran npm install
It looks like many of my modules were updated in the process


feat: support setting startLines for codeblocks (#310)

Code example:
https://gist.github.com/fr0zn/fe5292397f614b46bcbb5e6909bc9aad
Demo:

Reference: #310

It looks good! Can you help:

Adding some unit test on this PR
Creating another PR to https://github.com/slidevjs/docs to add the docs

Thanks you!

It looks good! Can you help:

Adding some unit test on this PR
Creating another PR to https://github.com/slidevjs/docs to add the docs

Thanks you!

No idea on how to do a unit test for that part.
There is already a PR: https://github.com/slidevjs/docs/pull/126

Thanks, let's move forward for now :)


Attack Detector - FP

Attacker -  0x36bde71c97b33cc4729cf772ae268934f7ab70b2
AD - https://app.forta.network/alerts/0xfb140216d93fb352e1c11f31b2f9aad41636b8410a4295826f5e56e15697b411
Base bots - malicious-smart-contract and Large Transfer
potential cause - the attacker's address belongs to Optimism: Aliased L1 Cross-Domain Messenger

@Thisisgeorg3 , I think the ML label should be added on this.


Question about data type casting

Hello, again!
I just found out that all the data type for models are automatically casted to fp16 by default when running server with cuda GPU. Same for all types of models just like the following lines.

https://github.com/huggingface/text-generation-inference/blob/19c41824cb11ba1a3b60a2a65274d8c074383de3/server/text_generation_server/models/causal_lm.py#L459-L461

If I understood correctly, is there any reason for that? Also, is there any way I can force the model dtype into the other types (e.g. bf16 or fp32) when running the server?

A lot of the custom CUDA kernels that only support fp16/bf16. The reason we use fp16 is because we have found that the results are more stable. There is no way of changing this dtype as of today.
Is there any specific reason you would want to do that?

Thanks for your response @OlivierDehaene ! :)
Actually I was testing my own model trained with bf16 precision using text-generation-inference, so I was about to test my model with bf16 rather than fp16 precision if it's possible. In my opinion then, since the server module is installed in editable mode, manually changing the dtype to bf16 can be an alternative.

In my opinion then, since the server module is installed in editable mode, manually changing the dtype to bf16 can be an alternative.

Yes you can certainly do that. If this become an issue in the future, we will add an option but for now fp16 was always the more stable dtype for us in prod.

I tested the model both for bf16 and fp16. And as you said, the result for fp16 seems more stable.


Handle error writing the output file

Right now, we ignore the error https://github.com/konveyor/analyzer-lsp/blob/90359e663aa9655450a6feda2db2a7fcd10475e5/cmd/analyzer/main.go#L216
We should treat this as a fatal error

#367


Cap get_index functions patch

Description
Patches an error observed with the python bindings of the Cap::get_anchor_index() and Cap::get_replaced_index() functions. The bad_optional_access error was not being equated to a Python RuntimeError in some cases. Now the binding catches the access error and throws a replacement std::runtime_error, which is properly equated to the Python exception.

🚀 [bumpr] Bumped! New version:v1.0.3 Changes:v1.0.2...v1.0.3


[No QA][TS Migration] Migrate 'OptionRow.stories.js', 'MenuItem.stories.js', 'CheckboxWithLabel.stories.js' , 'SubscriptAvatar.stories.js', 'PopoverMenu.stories.js'  stories

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/25350
$ https://github.com/Expensify/App/issues/25351
$ https://github.com/Expensify/App/issues/25352
$ https://github.com/Expensify/App/issues/25353
$ https://github.com/Expensify/App/issues/25354
PROPOSAL:
Tests

Run npm run storybook
Check if listed stories look and work as expected

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

OptionRow
https://github.com/Expensify/App/assets/153545991/b4eb68ac-d280-407a-a400-c5c4a1cb7fa4

MenuItem
https://github.com/Expensify/App/assets/153545991/38828f9a-9abc-4b85-a95d-823fd97b9246

CheckboxWithLabel
https://github.com/Expensify/App/assets/153545991/92dae631-4915-4ee0-b247-852d5a2ebfc2

SubscriptAvatar
https://github.com/Expensify/App/assets/153545991/b6396bbe-0606-4cbe-ad48-ea557cfcf3d1

PopoverMenu
https://github.com/Expensify/App/assets/153545991/554617ac-351c-407e-ac6d-7c4a658e7078

@blazejkustra Yes, I've tested them and uploaded recordings at the bottom ot the PR description, also added [No QA] to the title

@ishpaul777 Done!

can you reapprove to assign internal?

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 1.4.56-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.56-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


run init in .zshrc

we need to add autoload -Uz compinit && compinit to .zshrc in some way, or the auto completion won't be enabled.

I think the best way would be to use some regex to check if the users config is already calling these in their config and put it in if its missing, or ignore if its there.
Another option would be to print to the user the lines they need to add to make sure the auto completion is enabled if we detect zsh shell is being used and leave it up to the user. A lot of shell programs take this approach of 1. install all the correct files, 2. instruct user what they need to do when it comes to editing their shell system config files. There are trade offs for both approaches, it seems like the "julia" way is to try and make things as easy for the user as possible. If we do edit the configs, you could also do a message that notifies what lines/files were changed just for user awareness of their system configuration files.

I see. I also prefer the later one, given that we cannot prompt anything during Julia's build.
But I'm not sure if people are OK to let us manipulate their config files since it might require a manual revise if they don't want to. Tho in my personal opinion on adding PATH, FPATH as well as this one to the config file is not a big deal.
So I guess maybe we should just let this issue open when more people start using this and see what they prefer. And before this is built into Comonicon's build system, we could add a line to tell people how to enable auto completion (this is also what git CLI does I think)


Great Project~

Hi Mckay, could you share what app was used to record this video that supports focus magnification?

@PublicWorld https://www.screen.studio :)


Error during load

Laravel 6
Nova 2
after uploading image, can't load the uploaded image from storage.
Post resource code :
 public function fields(Request $request)
    {
        return [
            ID::make()->sortable(),

            Filepond::make('image')
                ->disk('public', 'posts')
                ->rules('required'),

            Text::make('title')
                ->rules('required'),

            Trix::make('description'),
        ];
    }

error screenshot

Laravel error log
laravel-2019-10-06.log

Thats due the second argument of disk method ->disk('public', "PATH")`, let me fix it...

Fixed on version v0.2.3


[BUG] placeholders-outside-cms TemplateDoesNotExist

Description
https://docs.django-cms.org/en/latest/how_to/01-placeholders.html#placeholders-outside-cms
Following the steps described "structure mode template" does not work.
Django does not find the template in any places: root templates folder, myapp/templates, myapp/templates/myapp
django.template.exceptions.TemplateDoesNotExist
Additional information (CMS/Python/Django versions)

Django==3.2.25
django-cms==4.1.0
Python==3.10

Do you want to help fix this issue?

[ ] Yes, I want to help fix this issue and I will join #workgroup-pr-review on Slack to confirm with the community that a PR is welcome.
[x] No, I only want to report the issue.

Hi @openHBP ! Can you double-check your get_template() result and the template folders? I cannot reproduce this.
If get_template() returns "my_app/my_model_structure.html" the typical place for the template would be my_app/templates/my_app/my_model_structure.html.

The template is indeed in my_app/templates/my_app/my_model_structure.html where my_app is msg

Content of msg.models.py
from cms.models.fields import PlaceholderRelationField
from cms.utils.placeholder import get_placeholder_from_slot

...
short_text3 = PlaceholderRelationField()
...

    def my_placeholder(self):
        return get_placeholder_from_slot(self.short_text3, "msgdet_slot")

    def get_template(self):
        return "msg/msgdet_model_structure.html"

Apart from that everything works fine. I can edit the placeholder text as if it was in the CMS
Here is the error (where /chapeau is the /admin path)
File "/home/pat/dev/pipenv/cpilote2/.venv/lib/python3.10/site-packages/django/template/base.py", line 938, in render
    bit = node.render_annotated(context)
  File "/home/pat/dev/pipenv/cpilote2/.venv/lib/python3.10/site-packages/django/template/base.py", line 905, in render_annotated
    return self.render(context)
  File "/home/pat/dev/pipenv/cpilote2/.venv/lib/python3.10/site-packages/django/template/library.py", line 192, in render
    output = self.func(*resolved_args, **resolved_kwargs)
  File "/home/pat/dev/pipenv/cpilote2/.venv/lib/python3.10/site-packages/cms/templatetags/cms_js_tags.py", line 36, in render_cms_structure_js
    obj_placeholders_by_slot = rescan_placeholders_for_obj(obj)
  File "/home/pat/dev/pipenv/cpilote2/.venv/lib/python3.10/site-packages/cms/utils/placeholder.py", line 352, in rescan_placeholders_for_obj
    declared_placeholders = get_declared_placeholders_for_obj(obj)
  File "/home/pat/dev/pipenv/cpilote2/.venv/lib/python3.10/site-packages/cms/utils/placeholder.py", line 374, in get_declared_placeholders_for_obj
    return get_placeholders(obj.get_template())
  File "/home/pat/dev/pipenv/cpilote2/.venv/lib/python3.10/site-packages/cms/utils/placeholder.py", line 252, in get_placeholders
    compiled_template = get_template(template)
  File "/home/pat/dev/pipenv/cpilote2/.venv/lib/python3.10/site-packages/django/template/loader.py", line 19, in get_template
    raise TemplateDoesNotExist(template_name, chain=chain)
django.template.exceptions.TemplateDoesNotExist: /msg/msgdet_model_structure.html

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/pat/dev/pipenv/cpilote2/.venv/lib/python3.10/site-packages/django/core/handlers/exception.py", line 47, in inner
    response = get_response(request)
  File "/home/pat/dev/pipenv/cpilote2/.venv/lib/python3.10/site-packages/django/core/handlers/base.py", line 181, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/home/pat/dev/pipenv/cpilote2/.venv/lib/python3.10/site-packages/django/utils/decorators.py", line 130, in _wrapped_view
    response = view_func(request, *args, **kwargs)
  File "/home/pat/dev/pipenv/cpilote2/.venv/lib/python3.10/site-packages/django/views/decorators/cache.py", line 44, in _wrapped_view_func
    response = view_func(request, *args, **kwargs)
  File "/home/pat/dev/pipenv/cpilote2/.venv/lib/python3.10/site-packages/django/contrib/admin/sites.py", line 232, in inner
    return view(request, *args, **kwargs)
  File "/home/pat/dev/pipenv/cpilote2/.venv/lib/python3.10/site-packages/cms/views.py", line 263, in render_object_structure
    return render(request, 'cms/toolbar/structure.html', context)
  File "/home/pat/dev/pipenv/cpilote2/.venv/lib/python3.10/site-packages/django/shortcuts.py", line 19, in render
    content = loader.render_to_string(template_name, context, request, using=using)
  File "/home/pat/dev/pipenv/cpilote2/.venv/lib/python3.10/site-packages/django/template/loader.py", line 62, in render_to_string
    return template.render(context, request)
  File "/home/pat/dev/pipenv/cpilote2/.venv/lib/python3.10/site-packages/django/template/backends/django.py", line 63, in render
    reraise(exc, self.backend)
  File "/home/pat/dev/pipenv/cpilote2/.venv/lib/python3.10/site-packages/django/template/backends/django.py", line 84, in reraise
    raise new from exc
django.template.exceptions.TemplateDoesNotExist: /msg/msgdet_model_structure.html
[29/Apr/2024 12:13:56] "GET /chapeau/cms/placeholder/object/53/structure/1271/ HTTP/1.1" 500 260510

When does the error happen? I would assume that the structure view is necessary to edit the content. So if that works, the template should be found. Maybe it is accessed elsewhere, too?

@openHBP Did this resolve?

I think I understand now, and your resolution is correct. With django CMS 4 you have to announce the frontend editable object to the toolbar using set_object.

I checked again all pieces of code and I still get stuck with the "stucture template".
I did add the slot to the model
I did add the structure mode template to the model
And I registered the model for frontend editing
Yet I get the error "TemplateDoesNotExist at /admin/cms/placeholder/object/53/structure/1325/". Checking the Template-loader postmortem, the template path is correct.
The only subtlety I had to do is to convert my CBV Detail View to a FBV in order to avoid a Page not found (Raised by:	cms.views.render_object_edit) on edit of placeholder/plugin path "admin/cms/placeholder/object/53/edit/1325/"
Content of msg/cms_config.py file
from cms.app_base import CMSAppConfig
from . import models, views_msgdet_edit
# from .views import MsgDetDetailView # use of CBV does not work here ! :-(

class MsgConfig(CMSAppConfig):
    cms_enabled = True
    # cms_toolbar_enabled_models = [(models.MsgDet, MsgDetDetailView.as_view())]
    cms_toolbar_enabled_models = [(models.MsgDet, views_msgdet_edit.msgdet_detail)]

Content of msg/views_msgdet_edit.py
def msgdet_detail(request, obj):
    """
    Main call @click on "Modify" button once connected !!!
    """
    request.toolbar.set_object(obj)  # Announce the object to the toolbar
    context = get_context_data(request, obj)
    context.update(ctx)
    context.update({"object": obj})
    return render(
        request,
        "msg/msgdet_detail.html",
        context,
    )

Template does not exist error is raised during template rendering
In template /home/pat/dev/pipenv/cpilote/.venv/lib/python3.10/site-packages/cms/templates/cms/toolbar/structure.html, error at line 13
3	<html class="cms-overflow">
4	<head>
5	    <meta charset="UTF-8">
6	    <title>{{ object.title }}</title>
7	    {% render_block "css" %}
8	</head>
9	<body>
10	    {% cms_toolbar %}
11	    {% render_block "js" %}
12	    {% language cms_toolbar.toolbar_language %}
13	    {% render_cms_structure_js cms_toolbar.structure_renderer object %}
14	    {% endlanguage %}
15	</body>
16	</html>

Here is the content of the HTML error output converted in md
TemplateDoesNotExist at chapeau_cms_placeholder_object_53_structure_1325.md

It says here that it cannot find the template where it should be:
*   `django.template.loaders.app_directories.Loader`: /home/pat/dev/pipenv/cpilote/source/odkdata2/templates/msg/msgdet\_model\_structure.html (Source does not exist)

Would you double check the file exists, and is readable for Django?

Thanks for your quick answer.
odkdata2 is an other app than the one concerned by PlaceholderRelationField which is msg. So the template file should be located in /source/msg/templates/msg, which is the case.
But for the sake of testing I've copied the template file into odkdata2/templates/msg but it doesn't change anything.
I've also copied the template into the main templates folder => no change.
Content of msgdet_model_structure.html
{% load cms_tags %}
{% placeholder "msgdet_slot" %}

It WORKS!
In fact my template file msgdet_model_stucture.html was missing a r  msgdet_model_stRucture.html
I'm really really sorry about that! And sorry for the time spent on that. This feature is magic. Many thanks for the all the job done.

@openHBP That's great to hear!!


feat: support for number format and rounding

What PR wants to accomplish:

decimal supports format string and rounding
all ToSignificant and ToFixed in entities support number.Option
add test case for format string and rounding

format string test reference: https://github.com/MikeMcl/toFormat
rounding test reference: https://github.com/MikeMcl/decimal.js-light

Thank you for your contribution！


routeRules cache config does not support using functions like getKey or shouldInvalidateCache

    routeRules: {
      '/information/**': {
        cache: {
          getKey: () => 'information',
          maxAge: 1000
        }
      }
    }

Functions like getKey or shouldInvalidateCache are striped from the runtimeConfig.
It seems to be on purpose, possibly because the config is serialised.
The config does not mention such a limitation.

Looks like https://github.com/unjs/nitro/issues/937

Looks like #937

It's not the same. The properties likes getKey  are already supported by the cache, however they are removed from the config at build time. Issue #937 is about the ability to have a dynamic routeRules  configuration.

We would love to see resolution here as well. Not sure how to invalidate or bypass what nitro has with this bug. If anyone has insight I will buy you some beers 🍺

Does anyone know of a workaround for this?

At first, shouldInvalidateCache key is there in src/rollup/config.ts.
https://github.com/unjs/nitro/blob/a6ce587f69c1d4520cd78c46b0059f48f1839b54/src/rollup/config.ts#L166-L174

But, The runtimeConfig has been handled by JSON.stringify, so function values are lost.
https://github.com/unjs/nitro/blob/a6ce587f69c1d4520cd78c46b0059f48f1839b54/src/rollup/config.ts#L198-L203
At this moment, _runtimeConfig is a POJO，Hopefully it will be fixed soon.
https://github.com/unjs/nitro/blob/a6ce587f69c1d4520cd78c46b0059f48f1839b54/src/runtime/config.ts#L6

Great find @zhuoqi-chen! This seems like a pretty big hole in Nitro - Anybody have any ideas on how we can address this?

Hi. Sorry for late responding to this issue and for confusing with types. (fixing in #1047)
Route rules (and in general nitro/nuxt options) only accept serializable type and functions like shouldInvalidateCache are not possible. So this is not a bug...
I believe we should extend route rules API for serializable options like invalidateHeaders and keyTemplate if we have good usecases for it).
Also there might be a way to specify/extend route rules via a nitro plugin (will share an example if could make)

I find getKey still invalid in routeRules > cache, in nitro.config.js
here is my config
nitro: {
        devStorage: {
            'v_pc': {
                driver: 'redis',
                /* redis connector options */
                port: 6379, // Redis port
                host: 'localhost', // Redis host
                db: 0, // Defaults to 0
                maxRetriesPerRequest: 2,
            },
        },
        routeRules: {
            '/**': {
                cache: {
                    name: 'my_name',
                    swr: false,
                    maxAge: 6 * 60,
                    base: 'v_pc',
                    getKey: () => 'hhhiii',
                },
            },
        },
    },

I console.log in here (in route-rules.mjs file),
const config = useRuntimeConfig();
console.log('config.nitro.routeRules', config.nitro.routeRules)
const _routeRulesMatcher = toRouteMatcher(
  createRadixRouter({ routes: config.nitro.routeRules })
);

getKey is lost
config.nitro.routeRules {
  '/__nuxt_error': { cache: false },
  '/**': { cache: { name: 'my_name', swr: false, maxAge: 360, base: 'v_pc' } }
}

I guess this is a bug. getKey is lost In the process of delivery.

Is the writing here wrong?

👆The order of merging the options is wrong, right? The getKey method of the parameter will always be overwritten by this fixed getKey method.

👆The order of merging the options is wrong, right? The getKey method of the parameter will always be overwritten by this fixed getKey method.

No not really, because getKey is extracted from opts on line 232

@2.8.1  Still can’t use getKey, has anyone succeeded?


Update and rename application_development.pp to application_deployment

What's the reasoning behind this?

Because is a mismatching at init.pp: calls application_deployment and the
class was application_development
On Mon, Mar 7, 2016 at 3:21 AM, Joseph (Jy) Yaworski <
<EMAIL_ADDRESS>wrote:

What's the reasoning behind this?
—
Reply to this email directly or view it on GitHub
https://github.com/voxpupuli/puppet-iis/pull/88#issuecomment-193056841.


Update Model3DTileContent specs to have parity with 3D Tiles 1.0 formats

This PR adds specs from Batched3DModel3DTileContent, Instanced3DModel3DTileContent and PointCloud3DTileContent to Model3DTileContent (and sometimes other places like the loaders)
Some notes:

I discovered that Model3DTileContent.getFeature() wasn't throwing exceptions like the interface expects, so I updated the code there
The point cloud back face normals is a little more involved than I first thought so I xit()-ed the test and opened https://github.com/CesiumGS/cesium/issues/10632 so we don't have to hold up the staging branch.

@j9liu could you review?

Thanks for the pull request @ptrgags!

:heavy_check_mark: Signed CLA found.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.

@j9liu updated everything except for a couple questions I left in the comment threads

@j9liu thanks for answering my questions, I updated the PR!

@ptrgags looks good, merging now!


Update github corner

Switched to the new better looking github corners http://tholman.com/github-corners/ I've added the red corner.

I prefer the old one, I think it's more obvious what it's doing if you don't recognise the :octocat:.

Yeah, I agree the old one is more obvious. Though, IMO the new one looks so good.

I do quite like the new one but probably more for projects where the chances of people not knowing the :octocat: are 0⃣. Let's leave this open for a bit and see what others think.

Okay, sounds fare.

I'm afraid I have to agree with Mike that I also prefer the old one. The new ones are minimalist and cute, but a lot less obvious. However, if we decided to pick one of the new ones, I think we should adjust the colors to match our color scheme.

@UniqMartin which color do you prefer?

I think the Octocat using the background color and the corner itself using the text color of the headings (like h1 and h2).

@UniqMartin sounds good. It is fairly easy to add custom colors. We can just update the hex value.

Passing, sorry!

No worries!


ARROW-5130: [C++][Python] Limit exporting of std::* symbols

This patch addresses the incompatibility of pyarrow and tensorflow wheels provided by Google.
It has been tested with:
import pyarrow
import tensorflow

As well as more complicated examples such as https://github.com/horovod/horovod/blob/master/examples/keras_spark_rossmann.py which uses PyArrow + Petastorm to read the data.
Fixes https://issues.apache.org/jira/browse/ARROW-5130

@pitrou, I saw in https://github.com/apache/arrow/pull/1953#issuecomment-386057063 that std::__once* include was added to make Plasma & Arrow use the same symbols.
What's a good way to test whether this change allows them to co-exist without such reuse (in a hope that they both use symbols from libstdc++)?

Thanks for working on this. This is obviously a complex issue that we've invested a lot of time in trying to fix and haven't succeeded yet. There are a lot of build and system configurations we'll have to test out to see whether this causes issues
Would you mind using our preferred PR titling style (which is needed for our changelog management tools)? "ARROW-5130: [C++][Python] ..."

Codecov Report

Merging #4232 into master will increase coverage by 1.16%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #4232      +/-   ##
=========================================
+ Coverage   88.04%   89.2%   +1.16%
=========================================
  Files         758     617     -141
  Lines       92803   82345   -10458
  Branches     1251       0    -1251
=========================================
- Hits        81708   73457    -8251
+ Misses      10982    8888    -2094
+ Partials      113       0     -113

Impacted Files
Coverage Δ

cpp/src/arrow/util/thread-pool-test.cc
97.66% <0%> (-0.94%)
:arrow_down:

go/arrow/math/uint64_amd64.go

go/arrow/memory/memory_avx2_amd64.go

go/arrow/ipc/file_reader.go

js/src/enum.ts

go/arrow/array/builder.go

js/src/Arrow.node.ts

js/src/schema.ts

go/arrow/type_traits_boolean.go

js/src/ipc/node/writer.ts

... and 132 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a41288...b82e320. Read the comment docs.

@wesm, I've updated the title and the PR. Now it passes both Travis integration tests & my internal tests mentioned in the description. What would be a good next step?

@alsrgv The symptom was crashes in Plasma. If there are no crashes on CI it should be good.


Add allocated storage columns to ChargebackContainerProject

Add storage allocated cost and metric columns for ChargebackContainerProject.
Depends on: https://github.com/ManageIQ/manageiq/pull/15973 - nothing errors out if this isnt merged first but the values will always be zero in the report
cc @simon3z
@miq-bot add_label chargeback, providers/containers

@zeari can you rebase this PR?

@zeari can you rebase this PR?

Rebased. Note that https://github.com/ManageIQ/manageiq/pull/15973 has to be merged in order for those columns to show something other than zero.

@zeari what is the status of this PR?  The travis failures look like they could be related.

@zeari what is the status of this PR? The travis failures look like they could be related.

Closing until we find a way to collect more accurate storage.


Poc builder

:pray:

:pray:

:pray:

:pray:

:pray:

:pray:

:pray:

:pray:

:pray:

:pray:


Form element ready-only query mode without values

Hello, good evening, I'm having a problem inserting the value in a query using the element as Ready-only

@GuiRochaSawluz Thank you for question
Please, to set initial values to read-only element use Initial Fields -> Query Fields option below Initial Request option section


Definitions in share/ruby-build are not available for install

Looking at the /share/ruby-build folder I see the following MRIs

2.0.0-p645
2.1.6
2.2.0

But when I pull the latest version of master and run ruby-build --definitions, these MRIs are not available for install.

Nevermind. I forgot to run the install script. Sorry!


Support package overrides

Some packages need special settings that are unique to both the system (meaning they can't be in build.config) and the package (meaning they can't be in a profile); a simple example is a configuration for a system that needs to use multiple cmake toolchain files.
dev-pipeline should support some sort of configuration unique to a package that permits fine-grained customization.  An example configuration may look like this:
# foo.override
[override]
# replaces existing key/values entirely
[append]
# appended to the existing key/values
[prepend]
# prepend to the existing key/values
[delete]
# erase from the package

@crazyorc

Tracked on the override-config branch (https://github.com/snewell/dev-pipeline/tree/override-config)


EvaluationScriptSuffix modfication is not possible

Description
hey @kblok there is still a problem when we talk about stealth mode, as mentioned in #1709  This behaviour is a problem when we try to pass DataDome, as it sends source, so it's quite hard to pass their validation if we can't modify it:

In quite old version we were able to modify it via reflection.
Expected behavior:
We are able to modify EvaluationScriptSuffix from Execution Context
Actual behavior:
We can't modify that value, as it is const.
Additional Links:
https://github.com/rebrowser/rebrowser-patches?tab=readme-ov-file#change-default-utility-world-name - this guy prepared a solution on that leak.
https://datadome.co/threat-research/how-new-headless-chrome-the-cdp-signal-are-impacting-bot-detection/ - datadome article how they detect automation

I think we could implement this https://github.com/puppeteer/puppeteer/pull/10114/files#diff-c7ce55941ba75a4411db2277bb2f54b56869778ae538ee8bb5543f891dd17c3a and make PuppeteerURL.INTERNAL_URL read/write

I think we could implement this https://github.com/puppeteer/puppeteer/pull/10114/files#diff-c7ce55941ba75a4411db2277bb2f54b56869778ae538ee8bb5543f891dd17c3a and make PuppeteerURL.INTERNAL_URL read/write

@IRusio if you fell comfortable trying to implement this, go for it. If not let me know and I'll add this to my list.


fix CVE-2020-26160 by migrating to golang-jwt

https://github.com/advisories/GHSA-w73w-5m7g-f7qc suggests to migrate from https://github.com/dgrijalva/jwt-go which is no longer being maintained to https://github.com/golang-jwt/jwt which states compatibility with dgrijalva/jwt-go.
I swapped in this module and also updated client_test.go to allow testing against your own litter robot based on its name.
go test -v
=== RUN   TestClient_Integration
=== RUN   TestClient_Integration/Test_States
--- PASS: TestClient_Integration (1.48s)
    --- PASS: TestClient_Integration/Test_States (0.24s)
=== RUN   TestHexToFloat
=== RUN   TestHexToFloat/3
=== RUN   TestHexToFloat/7
=== RUN   TestHexToFloat/F
--- PASS: TestHexToFloat (0.00s)
    --- PASS: TestHexToFloat/3 (0.00s)
    --- PASS: TestHexToFloat/7 (0.00s)
    --- PASS: TestHexToFloat/F (0.00s)
=== RUN   TestGetBool
--- PASS: TestGetBool (0.00s)
=== RUN   TestGetFloat
--- PASS: TestGetFloat (0.00s)
PASS
ok      github.com/tlkamp/litter-api    1.669s

I also rebuilt my poller against this modification and I'm still getting data.

Hey @iwvelando thanks for the contribution! I'll get a look at this sometime in the next day or two and get it merged.

The GitHub Actions checks are failing but I've addressed the problems in main. Merging!


Can't execute bcctools cachetop.

What reproduces the bug?

when I use python3 cachetop -p in the Android phone, it can't execute.
bpftrace --info

/bpftools/share/bcc/tools # python3 cachetop
Traceback (most recent call last):
File "/data/tmp/bpftools/share/bcc/tools/cachetop", line 27, in
import curses
File "/data/tmp/bpftools/lib/python3.10/curses/init.py", line 13, in
from _curses import *
ModuleNotFoundError: No module named '_curses'

https://github.com/iovisor/bcc


Clarification on required privileges

Hi,
Can we clarify which permissions/privileges someone needs to deploy this solution? This has 2 options; when you deploy it using existing resources (e.g. Automation Account, Log Analytics Workspace and Azure Monitor) or when you deploy it with new instances of these services.
I understand that in order to create a new Automation Account with a RunAs connection, one has to be in the Owner role on the Subscription. For the other resources, it's unclear what's needed.
That would be helpful and prevent failed deployments and troubleshooting.
Thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 225c9d05-83dd-b006-0025-3753f5ab25bf
Version Independent ID: 9eecef0c-b1cb-1136-faf7-542214492096
Content: Start/Stop VMs during off-hours solution
Content Source: articles/automation/automation-solution-vm-management.md
Service: automation
Sub-service: process-automation
GitHub Login: @georgewallace
Microsoft Alias: gwallace

@tinod Thanks for the question! We can have this clarified by our automation content developer.
@georgewallace Could you please help clarify this query?

The person deploying the solution might not be the Owner of the subscription. Also, resources like Azure Monitor will exist and perhaps the Azure Automation Account and the Log analytics workspace will also exist. Which permissions would the person deploying the solution need in order to finish successfully.  Or is it simple; you need to be a Subscription Owner, otherwise it fails.
I'm looking for the required roles on each service it touches. For example the Automation Account; you could only have Automation Operator privileges. Would that be sufficient? On Log Analytics, you might a Log Analytics Contributor…
Which permissions would one need in order to successfully deploy the solution?

@tinodo and @tinod Thanks for reaching out.  This is a great question. I will look into this and see what are all the permissions we may need.

I would like to know this as well.

@tinod I am working on incorporating this information into the article but the following shows the least permissions needed to deploy the marketplace solution.. Would this level of detail be helpful to have in the article?  In regards to your question, do deploy it from the portal you have to at least be a co-admin because of the Classic Run As Account.  But you can get around this by pre-creating some of the resources..
Pre-existing Automation Account and Log Analytics account you would need the following permissions.

Microsoft.Insights/ActionGroups/Write
Microsoft.Insights/ActionGroups/read
Microsoft.Automation/automationAccounts/read
Microsoft.Automation/automationAccounts/variables/write
Microsoft.Automation/automationAccounts/schedules/write
Microsoft.Automation/automationAccounts/runbooks/write
Microsoft.Resources/subscriptions/resourceGroups/read
Microsoft.Automation/automationAccounts/connections/write
Microsoft.Automation/automationAccounts/certificates/write
Microsoft.Automation/automationAccounts/modules/write
Microsoft.Automation/automationAccounts/modules/read
Microsoft.automation/automationAccounts/jobSchedules/write
Microsoft.OperationsManagement/solutions/write
Microsoft.OperationalInsights/workspaces/*
Microsoft.Insights/diagnosticSettings/write
Microsoft.Automation/automationAccounts/jobs/write
Microsoft.Automation/automationAccounts/jobs/read
Microsoft.Resources/deployments/*

New Automation Account and a new Log Analytics workspace you would need the following additional permissions.
Co-admin on subscription (for classic run as)
Can register applications configured in Azure Active Directory
Microsoft.Authorization/roleAssignments/write
Microsoft.Automation/automationAccounts/connections/read
Microsoft.Automation/automationAccounts/certificates/read
Microsoft.OperationalInsights/workspaces/write
Microsoft.Automation/automationAccounts/write
Microsoft.Authorization/roleAssignments/read
Microsoft.Authorization/roleAssignments/write


Fail fast when the selected MSBuild version is 14 but only VS2013 is installed

Task: MSBuild (similar issue might exist with "Visual Studio Build")
If a build with MSBuild 14 is explicitly requested in the task, but only VS2013 is installed on the build agent, then the task emits a warning stating that it is falling back to version 12, but tries to proceed. This can result in strange errors, which are harder to investigate then a quick failure with an explicit message.

Thanks for the feedback.  it would be a tough thing to change now as it would likely break peoples build definitions that are working under the current behavior.  We do add a warning into the log that shows up on the front page of the build result.