Recommended Way of Working with Custom Franka Gripper/Fingers.

Hi,
I wanted to get the opinion of the developers and the community on using custom franka gripper fingers- in my use case i want to have fingers with additional revolute joint to pick objects instead of default fingers.
I tried to modify sections of code related to hand/gripper in hand.xacro, panda_gazebo.xacro and was using effort_controllers/JointPositionController for the revolute joints but I am facing the following error. My question is does the franka_ros is additionally overriding the controller code?
[INFO] [1650303453.030012, 1.729000]: Controller spawned
[ INFO] [1650303453.949592739, 2.116000000]: Successfully initialized Franka Gripper Controller for joints 'panda_finger_joint1' and 'panda_finger_joint2'
[INFO] [1650303453.951177, 2.117000]: Controller Spawner: Loaded controllers: franka_gripper
[INFO] [1650303454.034601, 2.155000]: Loading controller: panda_left_finger_controller
[INFO] [1650303454.035893, 2.156000]: Started controllers: franka_gripper
[INFO] [1650303455.336057, 2.837000]: Loading controller: panda_right_finger_controller
[INFO] [1650303456.638490, 3.340000]: Controller Spawner: Loaded controllers: joint_state_controller, panda_left_finger_controller, panda_right_finger_controller
[ERROR] [1650303457.151853289, 3.548000000]: Could not switch controllers. The hardware interface combination for the requested controllers is unfeasible.
[ERROR] [1650303457.152599, 3.548000]: Failed to start controllers: joint_state_controller, panda_left_finger_controller, panda_right_finger_controller
^C[rviz-10] killing on exit

Thanks in advance

Do you get this error in gazebo or on the real robot? In gazebo, I inserted some sanity checks in the prepareSwitch method to make sure you dont start malformed controllers. If you modify the urdf to contain an additional joint this will no longer work.

Hi @marcbone,
Yes i am facing this error in franka_gazebo pkg. I want to modify the default gripper (something similar to as seen in image) so got rid of franka_gazebo/FrankaGripperSim controller and related code for prismatic movement in related files.
My custom gripper looks something similar as follows.
======panda_gazebo.xacro======
    .....
    <link name="${arm_id}_leftfinger_base">
      <visual>
        <geometry>
          <box size="0.01 0.01 0.04"/>
        </geometry>
      </visual>
    </link>
    <joint name="${arm_id}_finger_base_joint1" type="fixed">
      <parent link="${arm_id}_hand"/>
      <child link="${arm_id}_leftfinger_base"/>
      <origin xyz="0 0.05 0.075" rpy="0 0 0"/>
    </joint>

    <link name="${arm_id}_leftfinger">
      <visual>
        <geometry>
          <box size="0.01 0.01 0.04"/>
        </geometry>
      </visual>
    </link>
    <joint name="${arm_id}_finger_joint1" type="revolute">
      <parent link="${arm_id}_leftfinger_base"/>
      <child link="${arm_id}_leftfinger"/>
      <origin xyz="0.01 -0.005 0.03" rpy="${pi/10} 0 0"/>
      <limit effort="100" lower="0.0" upper="0.04" velocity="0.2"/>
    </joint>

If you modify the urdf to contain an additional joint this will no longer work. => is there any trick to make the above code working ?

As we intentionally disallowed this case, you will be on your own implementing what you want. However, I can give you a few pointers for the start:

To control a joint you have to specify what interface it has in the urdf:
https://github.com/frankaemika/franka_ros/blob/develop/franka_description/robots/panda_arm.urdf.xacro#L47
Then you have to adapt these asserts or remove them: https://github.com/frankaemika/franka_ros/blob/develop/franka_gazebo/src/franka_hw_sim.cpp#L182 However, there are many places where we assume exactly 7 joints. So you will have to go over everything and see what you have to change
Then the controller verifier could be a problem. It determines whether the controller you selcected is valid. https://github.com/frankaemika/franka_ros/blob/develop/franka_gazebo/src/franka_hw_sim.cpp#L640 You maybe have to change the logic inside the controller verifier to make your use-case work.

@marcbone thank you for the helping with the hints.

@suresh-guttikonda consider closing this ticket when it solved your problem


If possible fix webpage so that includes link to source code like bbousims

vs

This can be done by adding this line to the Description file
BugReports: https://github.com/poissonconsulting/bbousims/issues

Not sure this is entirely correct as its links to the issues in the other package not the issues in bboudata.

Yes sorry I was unclear I meant add links to the bboudata issues and code. So it seems we just need to add
BugReports: https://github.com/poissonconsulting/bboudata/issues
URL: https://github.com/poissonconsulting/bboudata, https://poissonconsulting.github.io/bboudata/

to the DESCRIPTION file and then run usethis::use_tidy_description() so in the correct arrangement.

in PR #20


Content: Institution: Create program: “SABC program code” text box label Fixes

User story:
As an institution, I want to enter a SABC program code or 3 letters and 1 number (XXX#) so that I can us the bulk “Offerings Upload” feature to import many offerings at one time.
Acceptance Criteria

[ ] On SABC Program Code Field, make following changes to align with the mock-up:

Revise field name,
Revise text beneath field
Add tooltip

Mock-Up:

Business context: If the SABC program code is not entered when the program is created, the institution cannot use the bulk offering upload feature.  Institutions are currently using this feature.

@HRAGANBC The mockup that you used might be a better option.

Thanks, @astridSABC
Please see my adapted wording. The more concise the better - helps cut down on miscommunication and expedites grooming process.

@HRAGANBC this issue seems to be the same as #3139


Errors in promises are dropped in Babylon Playground app

Replace experience.js with the following code:
Promise.resolve().then(function () {
    throw new Error("some error");
});

For Chakra, in debug, this error triggers VS to open, but is uncatchable. In release, the error disappears.
For V8, this error disappears.
Need to investigate.

This is fixed with the unhandled exception handler for AppRuntime.


Add Password To Redis

close: #3838
Microsoft Reviewers: Open in CodeFlow

I'm comfortable with this change pending @eerhardt 's comments about the API txt files and some incremental improvements to the XML docs since we are in the neighbhorhood.
I'm a little disappointed that about the parameter ordering but I can't think of a way that isn't a binary/source breaking change that isn't also disruptive.
One more iteration and we should be able to stamp an approval on this. Thanks once again for your efforts @Alirexaa.

Some of my comments might be non-sensical, or could be addressed in a follow-up PR. I'll let others decide that, since I'm very new to this code:)

@eerhardt We've discussed this for the client a few times but it has never hit the top of the pile. If it is a blocker, we can prioritize. I would suggest looking at ado-net quoted values as the template, but obvs we'd need to think a little about how to do it without impacting existing use of any new token

@eerhardt We've discussed this for the client a few times but it has never hit the top of the pile. If it is a blocker, we can prioritize. I would suggest looking at ado-net quoted values as the template, but obvs we'd need to think a little about how to do it without impacting existing use of any new token

I don't think it is blocking this work. I just wanted to point out that we can't URL encode the connection string here.

What is the status of PR?
Currntly i'm working on #5165,
I need playground app there,
Besides that, if redis have password, i need to support password there.
@eerhardt @mitchdenny

@Alirexaa see: https://github.com/dotnet/aspire/pull/4642#discussion_r1669073634

I've been talking a closer look at this from a security perspective, and I think we need to make some changes. When I run this locally the args are visble in the dashboard without any obfuscation (unlike environment variables).
I'm looking at the implications for deployment now too.

I've been talking a closer look at this from a security perspective, and I think we need to make some changes. When I run this locally the args are visble in the dashboard without any obfuscation (unlike environment variables).
I'm looking at the implications for deployment now too.
OK, so deployment doesn't use the args which means that the password isn't required. So we are going to need to fix that in azd before this change would have any impact (it has a local impact obviously but we need to think through to deployment for this one).

Good catch.
Reading https://redis.io/docs/latest/operate/oss_and_stack/management/security/#authentication, the other options for enabling a password are:

Adding a user and password to the Access Control List
Use the requirepass setting in the redis.conf file.

Either approach would require being able to write a file that is mounted into the container. Is that possible during deployment? @ellismg @vhvb1989
Alternatively, we could modify the Access Control List by connecting to the redis container after it is running, and issuing commands to it. I don't believe this is possible during deployment.

When I run this locally the args are visble in the dashboard without any obfuscation (unlike environment variables).

@drewnoakes @adamint - is it possible to mark command line arguments as "secret"? So they get obfuscated in the dashboard.

Either approach would require being able to write a file that is mounted into the container. Is that possible during deployment?

That's bindMounts, isn't it?
Like the sample from MySql here
The only difference would be that the file that is uploaded is generated, instead of committing it to the repo (or it can be a file in the repo with references to secured-args)
We support bind mount with an alpha feature in azd.  During provision, azd creates an storage account and one file-share which is set up as volume in the Azure Container Environment.  After provision, azd uploads the local content to the file-share. At the end, azd deploys the Azure Container App using the volume

@drewnoakes @adamint - is it possible to mark command line arguments as "secret"? So they get obfuscated in the dashboard.

#5065 tracks marking resource properties as secrets, however that has to be specified by the resource service. We could hard-code some known properties as sensitive. If we did that, which would you think should be included? The current list is https://github.com/dotnet/aspire/blob/0f2931a94873d09e5a76f72485000e5388bf08dd/src/Shared/Model/KnownProperties.cs

As much as I would like this in for 8.2, I think we need to hold this PR until we get this resolved. I think hiding the args in the dashboard is fine for local given that if you have access to the dashboard you could uncover the secrets in environment variables anyway.
I'm more concerned about deployment where people will have a reasonable expectation that the if you specify the password that it'll be used when deployed to the cloud.
Frustratingly Redis Stack actually makes use of a REDIS_ARGS environment variable which can use to specify the -requirepass [password] argument.

Frustratingly Redis Stack actually makes use of a REDIS_ARGS environment variable which can use to specify the -requirepass [password] argument.

Yeah, I was wondering if it would make sense for us to switch from library/redis to redis/redis-stack-server instead. And then Add WithRedisInsight (dotnet/aspire#5227) would switch the image from redis/redis-stack-server to redis/redis-stack and add the appropriate endpoints.

@drewnoakes @adamint - is it possible to mark command line arguments as "secret"? So they get obfuscated in the dashboard.

#5065 tracks marking resource properties as secrets, however that has to be specified by the resource service. We could hard-code some known properties as sensitive. If we did that, which would you think should be included? The current list is https://github.com/dotnet/aspire/blob/0f2931a94873d09e5a76f72485000e5388bf08dd/src/Shared/Model/KnownProperties.cs

This is in review in https://github.com/dotnet/aspire/pull/5380

Yeah, I was wondering if it would make sense for us to switch from library/redis to redis/redis-stack-server instead. And then Add WithRedisInsight (dotnet/aspire#5227) would switch the image from redis/redis-stack-server to redis/redis-stack and add the appropriate endpoints.

I think this is an option we should seriously consider. I think we would just need to look through where there are any licensing implications for folks deploying that image into production. There might be extra licensing requirements that we wouldn't want to silently swap people into.


Allow partially visible items to be picked as scroll anchors for maintainVisibleContentPosition

Summary:
The current behavior for maintainVisibleContentPosition on ScrollView is to pick the first fully visible item as the scroll anchor. This has a number of disadvantages:

It causes problems for lists with loading indicators and large items. The loading glimmer can be picked as the anchor and pull the scroll down too quickly. This is the case for Marketplace.
It's inconsistent with the CSS Scroll Anchoring behavior, which is to pick the first partially visible view.

This change will switch to picking the first partially visible view as the anchor, to align with the CSS implementation.
Discussed the change with yungsters, NickGerleman, and cipolleschi and agreed about the change in behavior.
This also enables maintainVisibleContentPosition for Android. After adding it to validAttributes for Android it appears to be working well. Previously it was not functional at all on Android, as the property change from React was not passed to ReactScrollViewManager.java.
Changelog:
[General] [Changed] - maintainVisibleContentPosition property on ScrollView now selects the first partially visible view as the anchor, rather than the first fully visible view.
Differential Revision: D54223244

252ef19c8d5bc5392d900af21136b351723f3b3c


AOP with changelogs in mongock

Hi again,
I would like to ask if it is possible to connect AOP with changelogs.
This is my aspect class:
@Aspect
@Component
public class MongockLogs  {

    @Around("execution(* Changelog001.*(..))")
    public Object doSomethingAdice(ProceedingJoinPoint joinPoint) throws Throwable {
        System.out.println(":: start ::");
        Object proceed = joinPoint.proceed();
        System.out.println(joinPoint);
        System.out.println(":: end ::");
        return proceed;
    }
}

and this is my changelog class:
@Service
@ChangeLog(order = "001")
Public class Changelog001{

    final String changeLogName = "changelog001"

    @ChangeSet(order = "001", id = changeLogName+"001",author = "me")
    public void user(MongockServiceRepository mongockService,
                               UserRepository userToDate){
        String fileName = mongockService.buildPath(changeLogName, "user001")

        JSONObject jt = mongockService.fileProcess(fileName);

        User user = new User();

        user.setName(jt.getString("name"));
        user.setSurname(jt.getString("surename"));

       userToDate.save(user);

    }
}

and class where I build my MongoCK bean:
@Configuration
public class MongockConfiguration {

    @Bean
    public MongockSpring5.MongockApplicationRunner mongockApplicationRunner(
            ApplicationContext springContext,
            MongoTemplate mongoTemplate) {
        return MongockSpring5.builder()
                .setDriver(SpringDataMongo3Driver.withDefaultLock(mongoTemplate))
                .addChangeLogsScanPackage("myProject.migration")
                .setSpringContext(springContext)
                .buildApplicationRunner();
    }
}

Hi @BeeTrojan, sorry for the delay, I've been quite busy, plus weekend. Is this still relelvant?

Hi,
Yes It is. I'm not sure but Mongock has its own logs, is it true ? I didn't see that earlier.

Well, Mongock uses Slf4j as logging interface, but I am not sure what is the relationship with AOP.
Regarding the AOP, as the changeLogs are executed by reflection, I am not sure how AOP libraries would behave with it and I guess it also depend on how the weaving is configured.
Anyway, I will try to do a POC this week to check it and will let you know.

Sorry we have dealing with an issue that affected JHipster integration. We'll try to take a look to this during this week.


Achievement Type now listed underneath Credential Title/Name

Issue: https://github.com/digitalcredentials/learner-credential-wallet/issues/485

@dmitrizagidulin My apologies I did not see the merge conflict originally, should be fixed now.


:sparkles: ui / expenses / list screen

[ ] change base on master after #5 is merged
[x] remove branch linked to #5

close in favor of #7


Be a hex editor

Or be more intelligent to check that the file I dragged into it is a binary file and can't be opened in text mode. I want to drag this ODT file into LibreOffice because the default program to open this file extension is MS Office and the path is too long to use the Open File dialog. I don't know why I wrongly dragged it into ecode.

ecode can open some binary files, most notably images.

How many images format are supported? I tried to drag a WEBP but it can't open.

I prefer the open anyway behavior of this text editor. Geany for example will refuse to open the file if it can't recognize the encoding (the file is plain text and of course not binary). It will not even try!
If I have a mixed-encoding text file, and if the text editor agrees to open it anyway instead of considering it to be corrupted or in unknown encoding and refuses to even load it, I at least can recover some content of it (the UTF-8 part, ASCII, or plain English characters as you prefer how to call it).

How many images format are supported? I tried to drag a WEBP but it can't open.

I don't know. I can confirm that it can open PNG, JPEG, and GIF (but there is no animations, only a static frame).

My opinion is basically the same as @mh466lfa . It behaves exactly how I want it to behave. ecode is a text editor, there are many good hex editors out there and I don't think this is relevant to the project (if you want a nice hex editor is a quite big project alone by itself, check ImHex which is awesome).

How many images format are supported?

png tga bmp jpg gif (no animated) dds psd (basic support) hdr pic pvr pkm svg (no text or textures) and qoi

I tried to open a SVG image but ecode will open it as text.

Which is correct because SVG files are just XML files, you can preview the SVG by right clicking in the document and "Show Image Preview", I use it all the time. This is 100% intentional.

I tried to drag a WEBP but it can't open.

I might add webp in the future, but webp specification is huge and webp is a quite big library, I have some webp basic support implementation somewhere but I never integrated it because it's too limited (this one). Someone needs to implement an easy to integrate and lightweight decoder in C/C++ for webp.


Updates pt_BR translation

Should I update the PyPI package now? Or something is still left?

I think that you should update.
I was thinking about the javascrip part, there are several public objects, that sould be considered a bad practice. Maybe we can adopt a namespace. Something like the Module pattern.
If you agree, I could open a issue for further discussion.
But for now, I think that what we have is worth to a new release.

Sure, I'll update the PyPI package soon.
I am not good at JavaScript, if you think adopting namespaces will benefit the project, go on open an issue :+1: Till that I'll learn what's necessary :)


Move canonical data to fixtures

Here is an example of moving the sample json data into fixtures rather than storing it inline in the test file.

Clearing out old pull requests.


Fixed build on some platforms

On some platforms, build failing because unsigned long long was not equal to uint64_t.
Fixes #12

Thank you for fixing this issue.

This breaks the build on Debian Testing
clang++ -Wall -Wextra -pedantic -std=c++11 -g -c demov.cpp
In file included from demov.cpp:7:
In file included from ./demov.hpp:14:
In file included from ./dishlp.hpp:14:
./stackMachine.hpp:61:7: error: no matching function for call to 'Z3_get_numeral_uint64'
                if (Z3_get_numeral_uint64(ctx, cn,(uint64_t*)  &ret)) {
                    ^~~~~~~~~~~~~~~~~~~~~
/usr/include/z3_api.h:4392:20: note: candidate function not viable: no known conversion from 'uint64_t *' (aka 'unsigned long *') to
      'unsigned long long *' for 3rd argument
    Z3_bool Z3_API Z3_get_numeral_uint64(Z3_context c, Z3_ast v, unsigned __int64* u);
                   ^
In file included from demov.cpp:7:
In file included from ./demov.hpp:14:
In file included from ./dishlp.hpp:14:
./stackMachine.hpp:78:14: error: call to member function 'bv_val' is ambiguous
                ret = ctx->bv_val((uint64_t) cur.imm, 32);
                      ~~~~~^~~~~~
/usr/include/z3++.h:1750:26: note: candidate function
    inline expr context::bv_val(int n, unsigned sz) { Z3_ast r = Z3_mk_int(m_ctx, n, bv_sort(sz)); check_error(); return expr(*this, r); }
                         ^
/usr/include/z3++.h:1751:26: note: candidate function
    inline expr context::bv_val(unsigned n, unsigned sz) { Z3_ast r = Z3_mk_unsigned_int(m_ctx, n, bv_sort(sz)); check_error(); retu...
                         ^
/usr/include/z3++.h:1752:26: note: candidate function
    inline expr context::bv_val(__int64 n, unsigned sz) { Z3_ast r = Z3_mk_int64(m_ctx, n, bv_sort(sz)); check_error(); return expr(...
                         ^
/usr/include/z3++.h:1753:26: note: candidate function
    inline expr context::bv_val(__uint64 n, unsigned sz) { Z3_ast r = Z3_mk_unsigned_int64(m_ctx, n, bv_sort(sz)); check_error(); re...
                         ^
/usr/include/z3++.h:1754:26: note: candidate function not viable: no known conversion from 'uint64_t' (aka 'unsigned long') to
      'const char *' for 1st argument
    inline expr context::bv_val(char const * n, unsigned sz) { Z3_ast r = Z3_mk_numeral(m_ctx, n, bv_sort(sz)); check_error(); retur...
                         ^
2 errors generated.
make: *** [Makefile:20: demov.o] Error 1

Reverting the commit fixes the issues.

This is most likely caused by API breaking updates to Z3

On my Ubuntu 18.04, reverting the commit with unsigned long long type works

On my Ubuntu 18.04, reverting the commit with unsigned long long type works


feat:  multiple environments

Added the first draft for multiple environments.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@harshilp24 - FYI. CC: @danciaclara

@harshilp24 - The first draft looks good to me. Let's discuss about outline and the structure. CC: @danciaclara

@sbalaji1192 @sondermanish  @ayushpahwa can you do a tech review of the page, please? Thanks

When the new feature comes, we'll work on it.


fix: use artistAuctionResults instead of artistInsights for contextScreenOwnerType

The type of this PR is: Bugfix

Description

Use artistAuctionResults instead of artistInsights for artist insights contextScreenOwnerType

Related cohesion changes PR: https://github.com/artsy/cohesion/pull/175

PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a CHANGELOG.yml entry or my changes do not require one.

#squashongreen


fix(deps): fix missing peer dependency for nestjs core

PR Checklist
Please check if your PR fulfills the following requirements:

[X] The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?
When this package is used with Yarn v3, we receive an error saying this package doesn't include @nestjs/core directly, causing an ambiguous import.

Issue Number: N/A
What is the new behavior?
Works properly with Yarn v3 and there is no error.
Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information
Workaround is to add the following to .yarnrc.yml:
packageExtensions:
  "@nestjs/cache-manager@*":
    peerDependencies:
      "@nestjs/core": ^9 || ^10

LGTM


UI for editing .env file

⚠⚠⚠ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/dockge/blob/master/CONTRIBUTING.md
Tick the checkbox if you understand [x]:

[x] I have read and understand the pull request rules.

Description
Presents and highlights the contents of the stack folder's .env file in the UI. Allows editing and saving. Also adds $token highlighting to YAML editor.
Type of change

User interface (UI)
New feature (non-breaking change which adds functionality)
This change requires a documentation update

Checklist

[x] My code follows the style guidelines of this project
[x] I ran ESLint and other linters for modified files
[x] I have performed a self-review of my own code and tested it
[x] I have commented my code, particularly in hard-to-understand areas
(including JSDoc for methods)
[x] My changes generate no new warnings
[ ] My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

LF and CRLF issue

Seems like a random runner bug, there is no CRLF in the file, it passed after re-run without changes.

LF and CRLF issue

Seems like a random runner bug, there is no CRLF in the file, it passed after re-run without changes.

Ohhh OK


Remove use of gotestsum in Makefile

Fixes an issue with make test failing when gotestsum is installed by removing gotestsum from the Makefile.
Closes https://github.com/anz-bank/sysl/issues/705
@anz-bank/sysl-developers

Hang on. go test -json ./... is failing, not gotestsum. That means something is actually wrong with the test infrastructure (or a particular test). Removing gotestsum will just hide that problem. This is absolutely the wrong way to "fix" the issue

Hang on. go test -json ./... is failing, not gotestsum. That means something is actually wrong with the test infrastructure (or a particular test). Removing gotestsum will just hide that problem. This is absolutely the wrong way to "fix" the issue

That's quite true, it doesn't resolve the root cause of the issue, but it does resolve the fact that running make test fails.
Personally, I'd prefer not to have gotestsum rather than have the makefile not work as expected on a branch.
Given that, I'll give fixing that test a try because it does seem more beneficial

@ericzhang6222 Could I please get some help with https://github.com/anz-bank/sysl/commit/849153c2454fb5c00fd8a8079e57ce8c8f9973d9#r37910456

Okay, after spending far too long messing around with the guts of

logrus
test2json
kingpin
Here's what I've established:
Running go test --json github.com/anz-bank/sysl/cmd/sysl -run TestMain3 produces a failing test.
This is due to the fact that test2json reads from the output of go test, and parses tokens such as --- PASS:
The line that's causing the test to fail is L916 of sysl_test.go
This is because running the test results in the === PASS to not be printed correctly.

Passing output should look like
=== RUN   TestMain3
--- PASS: TestMain3 (0.00s)
PASS
ok      github.com/anz-bank/sysl/cmd/sysl       0.353s

Rather than
go test -timeout 30s -v github.com/anz-bank/sysl/cmd/sysl -count=1 -run TestMain3
=== RUN   TestMain3
usage: sysl [<flags>] <command> [<args> ...]

System Modelling Language Toolkit

Optional flags:
      --help        Show context-sensitive help (also try --help-long and
                    --help-man).
      --version     Show application version.
      --log="warn"  log level: [debug,info,warn,trace,off]
  -v, --verbose     enable verbose logging
      --root=ROOT   sysl root directory for input model file. If root is not
                    found, the module directory becomes the root, but the module
                    can not import with absolute paths (or imports must be
                    relative).

Commands:
  help [<command>...]
    Show help.

  codegen --transform=TRANSFORM --grammar=GRAMMAR [<flags>] <MODULE>...
    Generate code

  datamodel [<flags>] <MODULE>...
    Generate data models

  env
    Print sysl environment information.

  export [<flags>] <MODULE>...
    Export sysl to external types. Supported types: Swagger

  generate-db-scripts [<flags>] <MODULE>...
    Generate db script

  generate-db-scripts-delta [<flags>] <MODULE>...
    Generate delta db scripts

  import --input=INPUT --app-name=APP-NAME [<flags>]
    Import foreign type to sysl. Supported types: [grammar, openapi, swagger,
    xsd]

  info
    Show binary information

  integrations [<flags>] <MODULE>...
    Generate integrations

  mod init [<name>]
    initializes and writes a new go.mod to the current directory

  protobuf [<flags>] <MODULE>...
    Generate textpb/json

  repl
    Enter a sysl REPL

  sd [<flags>] <MODULE>...
    Generate Sequence Diagram

  template --template=TEMPLATE --start=START [<flags>] <MODULE>...
    Apply a model to a template for custom text output

  test-rig --template=TEMPLATE [<flags>] <MODULE>...
    Generate test rig

  ui [<flags>] <MODULE>...
    Starts the Sysl UI which displays a visual view of Apps defined in the sysl
    model.

  validate <MODULE>...
    Validate the sysl file

ok      github.com/anz-bank/sysl/cmd/sysl       0.356s

The next piece of the puzzle is this reported issue where redirecting os.Stdout causes tests to fail
https://github.com/golang/go/issues/37304
A search in the kingpin repo reveals that os.
https://github.com/alecthomas/kingpin/search?q=stdout&unscoped_q=stdout
Summary
We can't change this test to pass without some serious rework (as far as I can see) so we're left with 2 options:

Remove the assert call
Change the Makefile to run without gotestsum

The best option still seems to be to change the Makefile so that make test works 100% of the time, and accept that gotestsum doesn't work on this repo, for now.

The failing of tests in gotestsum is resolved in go1.4. Closing this PR


Getting error when using swagger plugin with Tez-strapi.

Describe the bug
Tried to use strapi swagger plugin for API documentation. After installing the plugin, facing problem to run the application.
To Reproduce
Create new Tez-Strapi project and then install swagger plugin for Strapi ( npm install @strapi/plugin-documentation ).

It seems this is a duplicate issue, Hence I am closing this ticket to track everything in one ticket.


style: Centering the footer section ⏡

As you can see in the below snapshot, the footer is aligned to the left part of the page.
Aligning it to the center would make the page cleaner.

Hi, Can you assign me this issue?


PAE-279 - Add Python 3 and Juniper support.

Description:
This PR adds Python 3 and Juniper support to the xblock.
Updates README file and adds CHANGELOG file.
Reviewers:

[ ] @diegomillan
[ ] @luismorenolopera

Addressed. @luismorenolopera


Fix selfupdate subcommand

To avoid curious result, I use options in Embulk.selfupdate argument instead of system.
Related to #280.

Thank you :+1:


iOS not building on develop (45fc937419069a94dab3d4dd11deab4f33b080a0)

I am getting this error on the iOS build for develop https://github.com/tripleblindmarket/private-kit/commit/45fc937419069a94dab3d4dd11deab4f33b080a0
It gets stuck on a white screen and the app fails to load. I tested release v0.5 and it worked.
Device iPhone 8 - iOS 13.3.1
2020-03-16 01:01:35.631 [info][tid:main][RNGestureHandlerManager.m:136] [GESTURE HANDLER] Initialize gesture handler for root view <RCTRootContentView: 0x1013049b0; reactTag: 1; frame = (0 0; 375 667); gestureRecognizers = <NSArray: 0x2800f1170>; layer = <CALayer: 0x280eb8ec0>>
2020-03-16 01:01:35.660749-0700 PrivateKit[438:28526] +backgroundSessionConfiguration: is deprecated. Please use +backgroundSessionConfigurationWithIdentifier: instead
2020-03-16 01:01:35:660 PrivateKit[438:28526] Backing up original handler.
2020-03-16 01:01:35:660 PrivateKit[438:28526] Setting new handler.
2020-03-16 01:01:35.693860-0700 PrivateKit[438:28526] Current db version: 3
2020-03-16 01:01:35:694 PrivateKit[438:28519] BgGeo #configure: Config: distanceFilter=50 stationaryRadius=50 desiredAccuracy=0 activityType=OtherNavigation activitiesInterval=10000 isDebugging=0 stopOnTerminate=0 url= syncThreshold=100 maxLocations=10000 httpHeaders={
} pauseLocationUpdates=0 saveBatteryOnBackground=0 locationProvider=1 postTemplate={
    foo = bar;
    lat = "@latitude";
    lon = "@longitude";
}
2020-03-16 01:01:35.695266-0700 PrivateKit[438:28523] BgGeo #configure: Config: distanceFilter=50 stationaryRadius=50 desiredAccuracy=0 activityType=OtherNavigation activitiesInterval=10000 isDebugging=0 stopOnTerminate=0 url= syncThreshold=100 maxLocations=10000 httpHeaders={
} pauseLocationUpdates=0 saveBatteryOnBackground=0 locationProvider=1 postTemplate={
    foo = bar;
    lat = "@latitude";
    lon = "@longitude";
}
2020-03-16 01:01:35.696687-0700 PrivateKit[438:28519] Configuration persisted succesfuly
2020-03-16 01:01:35.700 [error][tid:com.facebook.react.JavaScript] TypeError: s.registerHeadlessTask is not a function. (In 's.registerHeadlessTask(o,n)', 's.registerHeadlessTask' is undefined)

This error is located at:
    in n
    in Unknown
    in Unknown
    in Unknown
    in Unknown
    in RCTView
    in RCTView
    in RCTView
    in RCTView
    in u
    in PanGestureHandler
    in RCTView
    in u
    in RCTView
    in n
    in Unknown
    in RCTView
    in j
    in RCTView
    in C
    in o
    in n
    in RNCSafeAreaView
    in Unknown
    in Unknown
    in RCTView
    in n
    in Unknown
    in Unknown
    in ForwardRef
    in Unknown
    in ForwardRef
    in n
    in n
    in RCTView
    in RCTView
    in h

Same issue here. Trying to figure out. Probably something related to the headlessTask
https://github.com/mauron85/react-native-background-geolocation#android-headless-task-experimental

I think I resolved this on Branch #57 that also includes @Andy's warning fixes.

Solved with #67


Tests failed when mock version of meta was updated

The following tests started failing when the analyzer's mock version of package:meta was updated to include a @Target annotation on _DoNotStore and _OptionalTypeArgs:
AssignmentOfDoNotStoreTest | test_classMemberVariable
AssignmentOfDoNotStoreTest | test_classStaticVariable
AssignmentOfDoNotStoreTest | test_topLevelVariable
AssignmentOfDoNotStoreTest | test_topLevelVariable_assignment_field
AssignmentOfDoNotStoreTest | test_topLevelVariable_assignment_functionExpression
AssignmentOfDoNotStoreTest | test_topLevelVariable_binaryExpression
AssignmentOfDoNotStoreTest | test_topLevelVariable_ternary
InferenceFailureOnFunctionInvocationTest | test_functionType_optionalTypeArgs
ReturnOfDoNotStoreTest | test_returnFromClosureInFunction
ReturnOfDoNotStoreTest | test_returnFromFunction
ReturnOfDoNotStoreTest | test_returnFromGetter
ReturnOfDoNotStoreTest | test_returnFromGetter_binaryExpression
ReturnOfDoNotStoreTest | test_returnFromGetter_ternary
ReturnOfDoNotStoreTest | test_returnFromMethod
ReturnOfDoNotStoreInTestsTest | test_noHintsInTestDir

Either the tests need to be updated or the Target annotations need to be updated.

@pq

InferenceFailureOnFunctionInvocationTest | test_functionType_optionalTypeArgs is a test which features @optionalTypeArgs on a function-typed parameter, which should be allowed. I guess the Target needs to be updated?

Wow, I think I mislabled this. All of the tests backing @doNotStore are marked @FailingTest. 😮

Any progress?

Ah, sorry. No progress.

Any progress? Do we need to adjust the priority?

No progress. Let me know what you think about priority. If it feels like a real P1, I can shift some energy over to take a look.

All of the tests backing @doNotStore are marked @FailingTest.

I think this is still P1. If you're on other P1s at the moment, I can take this one instead.


Pictogram per sponsoring team

Every sponsoring team has an icon that we use in the catalogs. The design spec has this at 64px in the library and asset detail page dashboards. I think we'll need an icon and pictogram per team.

here are the pictograms we currently have. i'm waiting on brand approval for carbon for .com and carbon for products in the brand repo.
pictos.zip

@kingtraceyj @jeanservaas here are the sponsor teams that we're using so far: https://github.com/carbon-design-system/carbon-platform/blob/main/services/web-app/data/teams.js
Questions:

Per that screenshot above, we have an "IBM.com" sponsor team with their own sponsor icon. I don't see that in pictos.zip. Are we consolidating so all of the Carbon for IBM.com libraries are now sponsored by the Carbon team (as a result of our 2022 re-org)? That means we'd no longer use the Svg32CarbonForIbmDotcom custom icon anymore.
We currently have a Carbon for IBM Products icon. In our mock indexing, we didn't apply that anywhere yet because we're using the Cloud, Watson, and Security icons as they sponsor the libraries, which gets rolled up into the Carbon for IBM Products PAL. These sponsor icons are at the library level, not the PAL (local system) level. Unless we identify a library that is sponsored at the PAL level, we don't need a Carbon for IBM Products pictogram?

If the answers are (1) Carbon team now sponsors IBM.com libraries, and (2) Carbon for IBM Products pictogram isn't needed, then I'll open a dev issue to temporarily use these SVGs directly.

here are the .com and the products pictograms:
DotCom_Product.zip

thoughts on the questions above:

We can use the pictogram I just attached for dot com libraries. I like the differentiation of the pictograms and that they are less tied to internal org structures. i realize we did do that with some of the carbon things, but it didn't make sense to pull those out.
I think we might need it down the road although we don't need it now. I think the product teams do have some assets that aren't tied to watson, cloud, and security.


Removing pull_request trigger to prevent duplicate workflows

Every push to a PR branch is both a push and pull_request event

@mmontgomery-square maybe you still want to build on master branch after the merge? If so this might be helpful https://docs.github.com/en/actions/reference/events-that-trigger-workflows#example-using-multiple-events-with-activity-types-or-configuration

AFAICT Github treats merges as a form of push so the workflow should run on master post-merge. There's a mention of this here:
https://github.community/t/trigger-workflow-only-on-pull-request-merge/17359

However, because a merged pull request always results in a push, you can use the push event to accomplish your goal.

That makes sense since "merge" isn't one of the built-in triggers.
Semi-relatedly, we may want to look into branch protection rules to enforce the workflow (the configuration gear isn't visible to me so I can't check our current settings):
https://docs.github.com/en/github/administering-a-repository/managing-a-branch-protection-rule

Did you intend for there to be so many changes here?


add drawvertices filled goldens

Related PR : https://github.com/flutter/engine/pull/23995

I recommend having less empty space in the goldens so that deltas are higher when a deviation happens.

I recommend having less empty space in the goldens so that deltas are higher when a deviation happens.


Fix Application.get_env and use Bitwise warnings

A pair of warning fixes:

Application.compile_env rather than Application.get_env in module body
import Bitwise rather than deprecated use Bitwise, and remove where unused

I'll merge this one since it's newer. Thanks for doing this! I'll try to get it published as soon as  I can.

Published https://hex.pm/packages/geo/3.5.1


Results from automat not in answers?

Standup Query 2:
{
    "message": {
        "query_graph": {
            "nodes": {
                "n0": {
                    "id": "UniProtKB:P52788",
                    "category": "biolink:Gene"
                },
                "n1": {
                    "category": "biolink:ChemicalSubstance"
                }
            },
            "edges": {
                "e01": {
                    "subject": "n0",
                    "object": "n1"
                }
            }
        }
    }
}

This is calling molepro and getting 37 results.
Looking at the logs, it's also calling into automat/pharos (among others) with a query like this:
{'nodes': {'n0': {'category': 'biolink:Gene', 'is_set': False, 'id': 'NCBIGene:6611'}, 'n1': {'category': 'biolink:ChemicalSubstance', 'is_set': False}}, 'edges': {'e01': {'subject': 'n1', 'object': 'n0', 'predicate': 'biolink:decreases_activity_of'}}}

This returns a result from pharos:
[{'node_bindings': {'n0': [{'id': 'NCBIGene:6611'}], 'n1': [{'id': 'CHEMBL.COMPOUND:CHEMBL330673'}]}, 'edge_bindings': {'e01': [{'id': '36cc6bce2fbaf6afb6d68012b1dfe6bf'}]}}, {'node_bindings': {'n0': [{'id': 'NCBIGene:6611'}], 'n1': [{'id': 'CHEMBL.COMPOUND:CHEMBL315995'}]}, 'edge_bindings': {'e01': [{'id': 'bf8b0b59392e1d5e5638739c45f8b476'}]}}]

But I don't see CHEMBL.COMPOUND:CHEMBL315995 (or it's preferred id PUBCHEM.COMPOUND:100766) in the strider results.

May be another symptom of #169, fixed by #166. Please confirm.

We are now getting results from both molpro and many automats.


not load maps

prismarine-viewer does not download maps from both the 3rd and 1st person, which are installed in front of the bot, one large map consisting of 6 small ones, a captcha on it, is there any way to make this captcha visible?

you won't be able to get the image via prismarine-viewer. use mineflayer-item-map-downloader instead, but the captcha in this case will be broken into 6 parts and most of them will be turned the wrong way


Implement blending in particle flipbook animation

This makes changes between frames look smoother, making flipbook particle animation more viable for realistic particle effects such as fire.
This works with both GPUParticles3D and CPUParticles3D.
This closes https://github.com/godotengine/godot-proposals/issues/1636.
Testing project: test_particle_animation.zip (master only, won't work in 3.x)
Preview
https://user-images.githubusercontent.com/180032/125545579-b652fea8-0db1-4c67-b0e3-0b09d2129239.mp4
TODO

[ ] Implement this feature in CanvasItemMaterial for 2D particles.
[x] See if we can keep UV2 free for other purposes when this feature is active, and ideally not require UV2 in meshes in the first place.
[ ] Investigate whether it's better to use a different shader version rather than a conditional. From my testing, the conditional doesn't affect performance in a meaningful way – I get 342 FPS instead of 343 FPS in my test project. However, this is a material feature that won't be used often, so perhaps it's still worth moving it to separate shader version (which requires compiling another shader when this feature is used).

Will you be adding this to CPUParticles3D in this PR or a separate PR?

Will you be adding this to CPUParticles3D in this PR or a separate PR?

It already works with CPUParticles3D – I just tested it :slightly_smiling_face:
I'm working on adding 2D support right now.

It already works with CPUParticles3D – I just tested it 🙂
You can test this in the MRP by selecting a GPUParticles3D node and choosing GPUParticles3D > Convert to CPUParticles3D at the top of the 3D editor.

Of course! Because this is in the StandardMaterial code, not in the ParticlesMaterial code.

That said, what do you think about the conditional-vs-shader version issue?

I think we probably should do another shader version. In theory it should be slightly faster and in practice I find that it is nicer to have as little as possible in the generated code when a user selects "Convert to StandardMaterial3D". I don't have a strong preference though, the performance impact is probably balanced out by the pain of having another shader permutation.

Since the default CanvasItemMaterial does not have a fragment() function, I'm not sure how to implement this in 2D…

You will have to add a fragment function when using animation blending. It shouldn't be too hard, as you are just inserting the string of characters, the same as in 3D. You add it all here:
https://github.com/godotengine/godot/blob/cce713ea2482532f90ecdb1f717b57f6ce7515ae/scene/main/canvas_item.cpp#L128-L150

@clayjohn Thanks for the review! I tried implementing your changes locally, but it worsened the overall blending:
Before
https://user-images.githubusercontent.com/180032/125885488-95430299-67ee-4a39-ad11-dd9b15ffe530.mp4
After
https://user-images.githubusercontent.com/180032/125885484-5514c2bb-10fa-4ccf-8b33-6c05aecd2153.mp4
These were my local changes so far:
diff --git a/scene/resources/material.cpp b/scene/resources/material.cpp
index 6f987602e2..b36539a322 100644
--- a/scene/resources/material.cpp
+++ b/scene/resources/material.cpp
@@ -1001,6 +1001,10 @@ void BaseMaterial3D::_update_shader() {
 		}
 	}

+	code += "\tif (particles_anim_blend) {\n";
+	code += "\t\talbedo_tex = mix(albedo_tex, texture(texture_albedo, particles_anim_next_frame_uv_coord), particles_anim_next_frame_mix);\n";
+	code += "\t}\n";
+
 	if (flags[FLAG_ALBEDO_TEXTURE_FORCE_SRGB]) {
 		code += "\talbedo_tex.rgb = mix(pow((albedo_tex.rgb + vec3(0.055)) * (1.0 / (1.0 + 0.055)),vec3(2.4)),albedo_tex.rgb.rgb * (1.0 / 12.92),lessThan(albedo_tex.rgb,vec3(0.04045)));\n";
 	}
@@ -1010,8 +1014,10 @@ void BaseMaterial3D::_update_shader() {
 	}

 	// Use particle flipbook animation if specified.
+	code += "\tvec4 albedo_blend_tex = vec4(1.0);\n";
 	code += "\tif (particles_anim_blend) {\n";
-	code += "\t\tALBEDO = albedo.rgb * mix(albedo_tex.rgb, texture(texture_albedo, particles_anim_next_frame_uv_coord).rgb, particles_anim_next_frame_mix);\n";
+	code += "\t\talbedo_blend_tex = texture(texture_albedo, particles_anim_next_frame_uv_coord);\n";
+	code += "\t\tALBEDO = albedo.rgb * mix(albedo_tex.rgb, albedo_blend_tex.rgb, particles_anim_next_frame_mix);\n";
 	code += "\t} else {\n";
 	code += "\t\tALBEDO = albedo.rgb * albedo_tex.rgb;\n";
 	code += "\t}\n";
@@ -1114,7 +1120,7 @@ void BaseMaterial3D::_update_shader() {

 	} else if (transparency != TRANSPARENCY_DISABLED || flags[FLAG_USE_SHADOW_TO_OPACITY] || (distance_fade == DISTANCE_FADE_PIXEL_ALPHA) || proximity_fade_enabled) {
 		code += "\tif (particles_anim_blend) {\n";
-		code += "\t\tALPHA = albedo.a * mix(albedo_tex.a, texture(texture_albedo, particles_anim_next_frame_uv_coord).a, particles_anim_next_frame_mix);\n";
+		code += "\t\tALPHA = albedo.a * mix(albedo_tex.a, albedo_blend_tex.a, particles_anim_next_frame_mix);\n";
 		code += "\t} else {\n";
 		code += "\tALPHA = albedo.a * albedo_tex.a;\n";
 		code += "\t}\n";

I see the mistake, you added both alternatives that I mentioned. Sorry that review was confusing. I proposed two alternative ways of doing the same thing. All you need is the top 4 changed lines in your diff.
code += "\tif (particles_anim_blend) {\n";
code += "\t\talbedo_tex = mix(albedo_tex, texture(texture_albedo, particles_anim_next_frame_uv_coord), particles_anim_next_frame_mix);\n";
code += "\t}\n";

Is this change optional?

Is this change optional? i.e. can it be opted out of by game devs?

Yes; it's disabled by default.


SRDO update

Update SRDO module to take into account previous SDO and PDO module updates.

Last year I used your library for a project and it was great. However, I had some problems with the SRDO module. I think it was not up to date with the SDO and PDO module updates and, since I had to partially rewrite and test it, I think it could be useful also for others.
Thanks!

Thank you for you contribution. You are right, SRDO was not up to date with current CANopenNode.
I can't merge directly into CANopenNode, because it could quite change the current formatting and so break the git history. Now I don't have much time but later I would like to carefully integrate it. For now it is here for anyone interested.

OK perfect. Maybe I can remove some non-fundamental changes in the CANopen.c/h module so the SRDO related changes are clearer.

SRDO update is now on the master branch.


Add JSDoc typeof support via JSDoc plugin

We had many issues around typeof and at some point simply settled on... the wrong type.
This caused a trail of ts-ignore comments, but I never realized that JSDoc has a plugin for exactly this issue: jsdoc-typeof-plugin
So this PR simply integrates that plugin and since now we have a correct type, we can let go of maaany ts-ignore comments.
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

Yes, fantastic find!
I think there are few more as well in those app create options .. for example lightmapper and batcher should be typeof, as we pass in type, and not the instance.

I think there are few more as well in those app create options .. for example lightmapper and batcher should be typeof, as we pass in type, and not the instance.

Yep, absolutely, I thought we could chip away at it one piece at a time (to keep PR size non-overwhelming/reviewable).
If we make some fire under https://github.com/playcanvas/engine/pull/5574 we can also remove lots of ts-ignore's again (currently it's not possible, because it's considered @interface while typeof requires a "real" class).


Color integration

Hi, Super nice job you have done with this kinfu_remake! Thanks a lot. Ultimately, I would like to export the reconstructed surface as a colored mesh. I know that marching cube needs to be ported from PCL version (which I was using so far), as mentioned in issues #12, but first I wanted to try to integrate the colors from the RGB camera (in a similar way as what is done in PCL) and get a colored point cloud.
I tried to define a color volume, and integrate the colors in it but it seems I have a few problems with GPU memory management... Specifically, I get a
KinFu2 error: unspecified launch failure
when I try to access 3D coordinates of points in the cloud (obtained with
DeviceArray<Point> kfusion::cuda::TsdfVolume::fetchCloud(DeviceArray<Point>& cloud_buffer) const)
I know it's not extremely clear and I apologize for that. I guess I was wondering if maybe someone could point me in the right direction after looking at my implementation.

Finally found the memory problem! The color integration is not fully functional yet but this particular issue can be considered as solved.


serialize & validate topic of publishing NFT

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

19 of 19 (100.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.6%) to 81.531%

Totals

Change from base Build<PHONE_NUMBER>:
0.6%

Covered Lines:
252

Relevant Lines:
306

💛  - Coveralls


Implement entity and domain exclude/include for Alexa

Description:
Continuing from #10632, this PR implements entity filters for Alexa via generate_filter.
This also has a minor fix to use specific domains for turn_on/turn_off calls instead of the generic homeassistant domain so that it's a smidge faster.
Example entry for configuration.yaml (if applicable):
cloud:
  alexa:
    filters:
      exclude_domains:
        - automation
        - cover
      include_entities:
        - script.turn_on_lights
      include_domains:
        - group

Checklist:
If the code does not interact with devices:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[x] Tests have been added to verify that the new code works.

Not sure why Travis keeps failing, is it like a circular dependency issue? pylint, flake8 and starting up all work fine for me locally...

Circular import. Cloud constant should move to cloud.const. I'll do it.


Think about custom scalars that aren't strings

I am not clear on whether the spec allows that.

After a new reading it seems that yes, it is allowed (it just says that custom scalars should have a string representation, presumably for allowing embedding them into JSON).
What is the best way to allow for maximum flexibility there?
If we have a custom scalar called Bytes, we could generate type Bytes = Vec<u8>; (with an annotation on the struct to say what Bytes corresponds to).
I think it would probably be better to leave that out, and allow users to inject use statements inside the generated module directly, that way you would define your Bytes (or Date, for example) scalar in another module, and inject an import for it. This seems more flexible.

Relevant section from the spec: https://github.com/facebook/graphql/blob/master/spec/Section 3 -- Type System.md#scalars

There is also an RFC to allow the serialization type of a custom scalar to be defined: https://github.com/facebook/graphql/pull/326

We should definitely support that when it makes it into the spec, thanks for the link!

Custom target types for custom scalars are implemented in #74

This is implemented, let's move the discussion on the RFC to #75


Add import of theme-variables and theme-macros to all css, js and .html files

In an effort to make the variables universally useful we need someone to add a hubl import for the theme-variables.css and theme-macros.css to all css, js and .html files.
This will enable developers to reference any of the variables.
This will also enable developers to use the macros in their code.

Added theme-variables import to macros deced74


cannot compile BulletSharp on Windows x64 for use with OpenTK

Hey ,
I am trying to compile bulletsharp with openTK but i am faced with this error "error C2871: 'OpenTK' : a namespace with this name does not exist". I read a few articles online regarding this and I figured out that the target .NET framework version difference between openTK and bulletsharp can cause this problem. I tried resolving it but it still didnt work. Can you please help me out in solving this issue. Thanks in advance.

Hi, try uninstalling and reinstalling OpenTK and make sure it's the latest version (1.1.4, 2014-07-23). This has worked for me.
Also, do you have MonoGame installed? MonoGame also adds OpenTK to the global assembly cache, which might interfere with the official installer, even though it should also work.

That worked...thanks a lot.. Please consider adding this to the build intructions. That would be of great help.

Cool, glad it works.
I can add it to the instructions, but it would be good to first figure out why this happens. Does an earlier OpenTK installer not install into the GAC? Does MonoGame or some other library interfere with it? Or maybe it's something else.

I think its something else. I dont have monogame installed. The older version of opentk which i was using, was installed exactly the similar way i have installed the latest version.
It would be great if you could help me out on another uses case issue. I am using the bullet sharp within my application to detect collision between two traingles. I want to give the triangle vertices as input.Iff you have time,  Can u guide me on a way I can do that. These triangles are from the triangle mesh loaded through a CAD file. I basically want a triangle triangle collision test that runs on gpu and is extremly fast.

You would generally use a BvhTriangleMeshShape for non-moving bodies, a ConvexHullShape for moving convex bodies and a GImpactMeshShape or CompoundShape for moving concave bodies. These work on the CPU. There are usage examples in the demos (e.g. ConvexDecompositionDemo, GImpactTestDemo, DistanceDemo).
BulletSharp doesn't yet wrap the Bullet 3 GPU code since it's work in progress. I'm not very familiar with it either, but you could check the examples to see if there is something that you're looking for.

The OpenTK reference is now handled by NuGet. I'll close this issue.


[Bug]

Describe the Bug
Could not access '/local' child route when visiting built files in app/dist folder.
Steps to Reproduce

yarn build;
run 'http-server -p 8088' in app/dist folder;(also tried to deploy in remote cloud server)
access '<IP_ADDRESS>:8088/local' in Chrome;

The current behavior
"GET /local" Error (404): "Not found"
The expected behavior
same page as https://v3-demo.ohif.org/local
OS
macOS 13
Node version
18.17.1
Browser
Chrome 114.0.5735.106

fixed by set redirection @ Nginx


support export data to file like rancher

I'm not experienced in how Rancher operates at all. Could you be more specific on this feature ?

Closing since we haven't got an answer. Feel free to re-open it though.


docs(faqs): update documentation for disabling the cache

Documents the latest way to address these two issues:

https://github.com/stanfordnlp/dspy/issues/213
https://github.com/stanfordnlp/dspy/issues/578

Please also note that the disable cache feature is not available on the latest version of the dspy package available on pypi. See: https://github.com/stanfordnlp/dspy/issues/805

Hi @majapavlo , does disabling the cache not work currently? Also just made a tweak to the phrasing since DSP_CACHEBOOL refers to the cache_turn_on flag.

The change you added might confuse users, since as a consumer of this library the cache_turn_on variable is a hidden implementation detail.
It should be possible to disable the cache without modifying the source code of the library, i.e. by setting an environment variable. This feature has already been added to the code, and is present on the main branch via the environment variable DSP_CACHEBOOL.
However, currently disabling the cache does not work, since the latest version of the package on pypi is missing this feature as the pypi releases are out of date. See this issue: https://github.com/stanfordnlp/dspy/issues/805.

I see, thanks for raising the concern @majapavlo . We have updated the README to mention how to use the library locally to use cache_turn_on as well.


Fix Automation swagger spec errors in the AutomationAccount and Webhook areas

Fixing the following errors in the Automation swagger spec:

(PatchBodyParametersSchema/R2016/RPCViolation): Properties of a PATCH request body must not be required. PATCH operation: 'AutomationAccount_Update' Model Definition: 'AutomationAccountUpdateParameters' Property: 'properties'
(PatchBodyParametersSchema/R2016/RPCViolation): Properties of a PATCH request body must not be required. PATCH operation: 'Webhook_Update' Model Definition: 'WebhookUpdateParameters' Property: 'name'
(XmsResourceInPutResponse/R2062/RPCViolation): The 200 response model for an ARM PUT operation must have x-ms-azure-resource extension set to true in its hierarchy. Operation: 'Webhook_CreateOrUpdate' Model: 'Webhook'

The intent of this PR is to address these errors only. The entire Automation swagger spec contains other errors, and they will be addressed by separate PRs.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[X] The title of the PR is clear and informative.
[X] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[X] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[X] If applicable, the PR references the bug/issue that it fixes.
[X] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[X] I have read the contribution guidelines.
[X] My spec meets the review criteria:

[X] The spec conforms to the Swagger 2.0 specification.
[X] The spec follows the guidelines described in the Swagger checklist document.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

My understanding from conversations with @vrdmr is that:

The web service API is stable and public, and this spec does not introduce any change.
The SDK based on this swagger spec has never been officially released yet.

So, any existing web service client will continue working against (1) as it is still communicating with exactly the same service, and it is not even aware of (2). @sergey-shandar, are you talking about someone who could take the published swagger spec and generate his own SDK from the spec? Does this mean that changing the swagger spec at this location effectively means publishing an SDK, and this is how we should treat it for all changes?

Hey @sergey-shandar,

Definetly this changes should be in the new API version but it doesn't make much sense to introduce SDK breaking changes for your customers.
Our swagger-based SDK is still in preview stage and contains many breaking changes. We released the preview SDK last month and are cleaning up the Specs before we can promote the SDK to a stable version.

Please let me know if you have any other questions.
cc: @marstr, @AnatoliB, @D1v38om83r

Hi @sergey-shandar,
We need to close on this soon, as we are trying to fix all the swagger validation errors within the next few days, so I will appreciate your help very much.
Please note that there are multiple other PRs with similar changes coming from our team, and some of them have already been committed.
My previous point was that this may not be a breaking change in our context. But here is another question: what if we do want to make a breaking change? Is this not allowed under any circumstances, or there is an authority that could actually make this call? What I observed previously was that a reviewer would just point out a potential breaking change, and then approve the PR after the author acknowledges the issue. So, is this decision up to the Automation team?

Hi @AnatoliB. We assume that if RestAPI is published before as stable then people have freedom to generate stable API for any programming language. Including Microsoft official SDKs, for example for Python, Ruby, JavaScript, Go etc. For example, there's an official Microsoft stable NuGet package  https://www.nuget.org/packages/Microsoft.Azure.Management.Automation/2.0.4 which is using the same API version 2015-10-03. So making changes in this swagger file will introduce SDK breaking changes for stable SDK for the same API version. We are trying hard eliminate such breaking changes.

@AnatoliB

My previous point was that this may not be a breaking change in our context. But here is another question: what if we do want to make a breaking change?

It's always better to make the SDK and server side breaking changes in a new API version if the current one already publicly available.

Is this not allowed under any circumstances, or there is an authority that could actually make this call?

There could be some exception, for example, bugs in API etc.

What I observed previously was that a reviewer would just point out a potential breaking change, and then approve the PR after the author acknowledges the issue. So, is this decision up to the Automation team?

At the end, it's your service customers who may suffer. We can still approve this but we have to be sure that you understand all consequences. Is there a strong reason why you would like to introduce SDK breaking changes in the same API version?

The changes done in this PR reflect the Service and we are updating the specification to keep it updated. Also,

For example, there's an official Microsoft stable NuGet package https://www.nuget.org/packages/Microsoft.Azure.Management.Automation/2.0.4 which is using the same API version 2015-10-03. So making changes in this swagger file will introduce SDK breaking changes for stable SDK for the same API version.

The 2.0.4 API was generated from Hyak from the last PR done in SDK/Master.

Ping. Can you please take a look at this PR? Thanks.

@vrdmr we need ARM approval for this. @ravbhatnagar could you have a look, it's really simple change.

Looks good.

@sergey-shandar Could you please approve and merge this change. Thanks.

Automation for azure-sdk-for-python

Automation for azure-sdk-for-go

@AutorestCI rebuild azure-sdk-for-python


Boot{,-bin} 2.7.2 is out

There's a new boot-bin and a new boot out, 2.7.2!

Upstream PR to update the official image: https://github.com/docker-library/official-images/pull/3344

@cap10morgan Old boot-bin is still used:
https://github.com/Quantisan/docker-clojure/blob/master/Dockerfile-boot.template#L16
Should be https://github.com/boot-clj/boot-bin/releases/download/2.7.2/boot.sh

Thanks @Deraen. I'll get that fixed soon.

New upstream PR: https://github.com/docker-library/official-images/pull/3351

This should be fully released now: https://github.com/docker-library/official-images/pull/3351


Implement APIv2.1 compiler (closes #238)

Currently this lacks completely any error reporting (will be implemented in context of #305).
\cc @AlexanderMoskovkin @AndreyBelym @churkin
@VasilyStrelyaev pls, check comments and test names

FPR

lgtm

Since @churkin is missing today, @kirovboris  can you review instead. please?

lgtm

@inikulin Please rebase to upstream/master for merging

Rebased

@testcafe-build-bot \retest

\r-

FPR

lgtm

ping @churkin @AlexanderMoskovkin @kirovboris

lgtm

lgtm


Revised folder structure & generators

Container/Component folder structure is outdated long ago. With redux-toolkit and hooks, the line is blurry. Therefore, the folder structured is removed and left for the developer to decide.
Changes:

Containers folder removed and generators updated to put the components anywhere
Redux Slices are isolated from component and grouped in a folder

A new generator added to support slice generation separate from the component

Examine the changes in the documentation to see what has changed and how.

Pull Request Test Coverage Report for Build 501373926

25 of 25 (100.0%)  changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.004%) to 99.678%

Totals

Change from base Build 493977692:
0.004%

Covered Lines:
249

Relevant Lines:
249

💛  - Coveralls

Pull Request Test Coverage Report for Build 501373926

25 of 25 (100.0%)  changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.004%) to 99.678%

Totals

Change from base Build 493977692:
0.004%

Covered Lines:
249

Relevant Lines:
249

💛  - Coveralls


Add onClickBottomside method in View

Refs: https://github.com/ScreenNetwork/inventory-framework-fork/blob/main/framework/src/main/java/me/saiintbrisson/minecraft/View.java (551)
https://github.com/ScreenNetwork/inventory-framework-fork/blob/main/framework/src/main/java/me/saiintbrisson/minecraft/ViewListener.java (150)
We removed a large majority of the listener and handleMoveIn method for this. But it's a useful thing for us and probably very useful for the framework itself. We use this method to detect clicked items in the player's inventory when he has a View open.

I understand the need to detect clicks outside the view's inventory, but the design of creating a new handler in the View class is not ideal from an API design point of view.
With each new handler that is created, the proliferation of code that is not coming from the user in that user's View class gets bigger and bigger, and, we already have onClick for that, so it would be better to use it in this case.
I can create a ViewSlotContext#isViewContainer option to detect if that context (in your click case) occurred inside the player container or in the view container and would be used like this:
@Override
protected final void onClick(ViewSlotContext context) {
    if (!context.isViewContainer())
        // clicked on player inventory
}

Also, the code is in a rewrite process so the less need to inherit functions from the view, which will soon be deprecated, better.

Now available on v2.5.1-rc.1


fix fix BE compile and FE protoc artifact issue

Proposed changes
Issue Number: close #xxx
Problem summary

add <optional> head to solve the compilation issue
use 3.12.9 as the protoc.artifact's version, because there is no 3.12.21
See: https://repo.maven.apache.org/maven2/com/google/protobuf/protoc/
Remove --show-progress arguments of wget because it is not supported in low version wget

Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Add extensions block to manifest

Also, manifest is now output as JSON (which is valid YAML).
Implements https://github.com/palantir/sls-spec/pull/15.

This change is

@nmiyake are you cool with this json/yaml format?

Yup LGTM

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Adding @bmoylan for SA

I can make it YAML again if desired -- I'll just have to add SnakeYAML or something similar to the dependencies. Let me know.

Review status: all files reviewed at latest revision, 2 unresolved discussions.

src/main/groovy/com/palantir/gradle/javadist/tasks/CreateManifestTask.groovy, line 47 at r1 (raw file):
Previously, uschi2000 (Robert Fink) wrote…
> doesn't have test coverage

Will add in the next round. I wanted feedback on the overall approach before doing that.

src/main/groovy/com/palantir/gradle/javadist/tasks/CreateManifestTask.groovy, line 58 at r1 (raw file):
Previously, uschi2000 (Robert Fink) wrote…
> do we want to group the extra properties under a single key such as `ext`, `extensions`, `extras` or similar?

The spec says you can add properties willy-nilly at the top level, but there was discussion (https://github.com/palantir/sls-spec/issues/13) of using a top-level extensions key. Since that discussion seemed to have stalled out, I went with the current version of the spec. I'd be happy to switch this over to a top-level key once the spec PR merges, but for now I don't want to block this PR on that debate.

Comments from Reviewable

Review status: 1 of 4 files reviewed at latest revision, 2 unresolved discussions.

src/main/groovy/com/palantir/gradle/javadist/tasks/CreateManifestTask.groovy, line 47 at r1 (raw file):
Previously, punya (Punyashloka Biswal) wrote…
> Will add in the next round. I wanted feedback on the overall approach before doing that.

Done.

Comments from Reviewable

Punya, check the sls spec changes please; we want those things to show up under a "extensions" key.

Reviewed 1 of 3 files at r1, 3 of 3 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

Comments from Reviewable

readme needs adjustment.

Reviewed 4 of 4 files at r3.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

src/main/groovy/com/palantir/gradle/javadist/DistributionExtension.groovy, line 116 at r3 (raw file):

    }

    public void setExtensionsBlock(Map<String, Object> extensionsBlock) {

can you follow the same pattern as with env and also add some tests to DistributionExtensionTest?

src/main/groovy/com/palantir/gradle/javadist/DistributionExtension.groovy, line 116 at r3 (raw file):

    }

    public void setExtensionsBlock(Map<String, Object> extensionsBlock) {

I wonder what the right name is for this. maybe manifestExtension?

Comments from Reviewable

@markelliot want to take a look?

Reviewed 5 of 5 files at r4.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

Just realized that I still haven't updated the Readme, will do that shortly.

@uschi2000 ready to merge, I think!

Review status: 6 of 7 files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

Reviewed 1 of 1 files at r5.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

@uschi2000 @markelliot @nmiyake when will this get released?

I think this went in with some of the TLS changes and we're looking to do an RC to test some things. But Rob and Joe are out this week, so think it's going to be next week.

Would be great to have a release this week, I need to add extensions for something shipping on ~Friday and would prefer to not hack them in or depend on a snapshot


[$500] Chat – The emoji is not added to Frequently Used when react the message.

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v1.4.4-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @
Action Performed:

Go to https://staging.new.expensify.com/
Log in with any account.
Navigate to a conversation that already has some messages.
Hover over any message
Verify there's a button to select an emoji to react the message
Click on the button
Verify the emoji picker opens
Select any emoji from the list
Hover over any message one more time.
Click on the button to select an emoji to react the message one more time.

Expected Result:
The emoji is added to Frequently Used when react the message
Actual Result:
The emoji is not added to Frequently Used when react the message
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/eb903738-0dc6-4ed1-9e7d-c9ece37ad5e8

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~011b94505876eacdb3
Upwork Job ID:<PHONE_NUMBER>037398016
Last Price Increase: 2023-12-19

Related - https://github.com/Expensify/App/issues/31802

Seem to be related but not exactly the same. In the linked ticket, we're talking about the emoji picker in the status selector in user profile settings. I like the idea of moving this logic to the emoji picker itself by @DylanDylann here. Let's see what @0xmiroslav decides.

Sounds good, I'll check that GH Monday to see if a decision has been made.

Nothing yet, I'll check again tomorrow.

Still paused for an update on https://github.com/Expensify/App/issues/31802#issuecomment-1825061164

Sorry for the hold-up, I've been OoO.
I reviewed the comment linked and reviewed against our waves and agree this can be closed for focus as it's not a required part of any waves.


Highlight the environmental score

In the HTML or preview there is CVSSv3.1 Base Score in the title. Environmental Score is missing and Severity is empty. In our opinion, it is important for supply chain vulnerability advisories to highlight the environmental score.

The same situation is in the Known affected point, there are only Product, CVSS-Vector and CVSS Base Score. Although in JSON Environmental Score can be included and is also displayed correctly in JSON.

Hmm. IMHO, as default - the recipients should compute the base score based on their environment. I'm aware of certain situations where the write might be a service provider of the recipient and writes it only for this specific case and therefore is able to make a judgement.
For now, I'll leave that open to see whether that is a topic of additional community members. In the meantime, feel free to implement in your own instance.

Regarding the severity part: this is a straight mapping from /document/aggregate_severity. So, I guess this field was not filled in...


Add set password command

Is there a possibility to add a add-password-command?

Can't follow you. What should the command do? Is it related to vault or something else?


Entire URL website is not pulling in all html tags

I have some div tags that are not within the html once I read it in to HTML Agility.
Why would some div tags be left out?
=============
I am trying to get a div that has no attributes or classes
I'm tried a number of items but it can't seem to find anything under a specific div tag that has no attributes.
If a div tag has no attributes and just is there a way to get it via html agility?
https://imgur.com/a/HVEpOo8

Hello @ttaylor29 ,
Do you think you could provide a project sample with this issue?
It will help my developer investigate the issue more efficiently.
We now always ask for a project sample even if the issue is easy to reproduce. As a free product, we must find some way to save time to offer an overall better experience for everyone and release fixes faster.
You can send it to<EMAIL_ADDRESS>if you need to keep the source private
Best Regards,
Jonathan

Performance Libraries
context.BulkInsert(list, options => options.BatchSize = 1000);
Entity Framework Extensions • Entity Framework Classic • Bulk Operations •  Dapper Plus
Runtime Evaluation
Eval.Execute("x + y", new {x = 1, y = 2}); // return 3
C# Eval Function • SQL Eval Function

Yes, let me do that.

I sent you all an email!

Awesome @ttaylor29,
we will take a look at it and get back to you via email!
best regards,
Jon

Hello @ttaylor29 ,
You are currently looking for the LoadFromBrowser I believe.
string url = "[website_ur]";
var web1 = new HtmlWeb();

var doc1 = web1.LoadFromBrowser(url, s =>
{
    var found = s.Contains("wisss_gameHover");

    if (found)
    {

    }

    return found;
});

var s2 = doc1.DocumentNode.InnerHtml;
var scoreRows = doc1.DocumentNode.SelectNodes("//div[@class='wisss_gameHover']").ToList();

The current code will use the WebBrowser and wait until the class wisss_gameHover is loaded before continuing in the code.

YESSSSSSSSSSSSSS!!!
Let me try this later today (hopefully) and I'll report back to you all.
Thanks a bunch! :-)

awesome!
we will be looking forward to hearing from you ;)

:-)
Sorry I didn't get to test it as I need to check it while the code is being injected in. It usually happens during the day right now. I'll try again tomorrow.

THIS WORKED!!!!!!!!
Thanks a lot for looking at my issue for me!
`            var web1 = new HtmlWeb();
        var doc1 = web1.LoadFromBrowser(url, s =>
        {
            var found = s.Contains("wisbb_inningAndOuts");

            if (found)
            {

            }

            return found;
        });

        var s2 = doc1.DocumentNode.InnerHtml;
        var scoreRows = doc1.DocumentNode.SelectNodes("//div[@class='wisbb_inningAndOuts']").ToList();`


DOBS: Too many requests  status=500

Summary
Seems to be there's rate limits withing digital ocean.
New Feature
I don't know if this solvable at all
Bug Reports
FATA[0000] GET https://api.digitalocean.com/v2/volumes?per_page=200&region=ams3: 429 Too many requests  status=500
Version
Please paste the output of rexray version. For example:
root@swarm-slave-1:~# rexray version
REX-Ray
-------
Binary: /usr/bin/rexray
Flavor: client+agent+controller
SemVer: 0.11.3
OsArch: Linux-x86_64
Commit: 3afc7942dd8b1a88ed902344b4ece89374be87f7
Formed: Tue, 12 Jun 2018 15:45:51 UTC

Expected Behavior
Working DOBS volumes
Actual Behavior
Hit DO rate limits
Steps To Reproduce
Re-deploying service maybe 10 times, and I think it's been failing, so it's been hopping from one swarm node to another, and here you go.
Configuration Files
# Ansible managed
rexray:
  logLevel: warn
libstorage:
  integration:
    volume:
      operations:
        mount:
          preempt: true
      create:
        default:
          size: 1
  service: dobs
  server:
    services:
      dobs:
        driver: dobs
dobs:
  token: xxx
  region: ams3
  convertUnderscores: True
  statusInitialDelay: 100ms
  statusMaxAttempts: 10
  statusTimeout: 2m

Logs
rexray volume ls gaved me this
FATA[0000] GET https://api.digitalocean.com/v2/volumes?per_page=200&region=ams3: 429 Too many requests  status=500

Thanks for this @holms.
I just looked up the API limits and it looks to be 5000 per hour. The docs show that there is a HEAD value that can be looked at to determine limit statuses.
https://developers.digitalocean.com/documentation/v2/
Is your DO API being used by another application?

I have one volume attached to the droplet which i'm actively using, but i haven't detached in a long time.  In swarm we currently only using one volume with rexray. I did started 2 services which used rexray volumes today, and it was failing due to this error. I have absolutely no idea how could I hit rate limit. There's one container which actually hops back and forth on swarm nodes sometimes, but 5000 per hour that's a lot!

Ok I'll close this. Didn't happened today so .. maybe it's my fault somewhere.


Using fan control in automization?

Hi,
First of all thank you for this integration. This is really helping me out!
Is there a possibility to use the fan speed in the atomization pane? Right now, I am only seeing this:

I can change the fan speed when I click the "more information" button, but not on the dashboard. Any way to fix that?
Again, thank you for your awesome work. :)

It is indeed possible, I myself have an automation that increases the fan speed when a humidity sensor detects someone taking a shower.
Use the "Call a service" action, and use the service "Climate: set fan mode".


Agents walking through walls/lava?

Hi!
I have been training ppo agents in navix environments and I keep seeing that agents walk through walls/lava. I'm using version 0.6.14 of Navix. I'm using a PPO agent from PureJaxRL (purejaxrl/ppo_minigrid.py). I train the agent, and then load a network to render the behaviour, and I get the following:
from ppo_minigrid import *
from navix import observations, rewards, terminations, register_env
import navix

config = {
    "LR": 2.5e-4,
    "NUM_ENVS": 16,
    "NUM_STEPS": 256,
    "TOTAL_TIMESTEPS": 2e6,
    "UPDATE_EPOCHS": 1,
    "NUM_MINIBATCHES": 8,
    "GAMMA": 0.99,
    "GAE_LAMBDA": 0.95,
    "CLIP_EPS": 0.2,
    "ENT_COEF": 0.05,
    "VF_COEF": 0.5,
    "MAX_GRAD_NORM": 0.5,
    "ACTIVATION": "tanh",
    "ENV_NAME": "Navix-LavaGapS7-v0",
    "ANNEAL_LR": True,
    "DEBUG": True,
}

rng = jax.random.PRNGKey(30)
train_jit = jax.jit(make_train(config))
out = train_jit(rng)

import matplotlib.pyplot as plt
import jax
import jax.numpy as jnp

env = NavixGymnaxWrapper("Navix-LavaGapS7-v0")
env = FlattenObservationWrapper(env)
env = LogWrapper(env)
key = jax.random.PRNGKey(30)
key, _key = jax.random.split(key)
obs, state = env.reset(_key, None)

def render(obs, title):
    plt.imshow(obs)
    plt.title(title)
    plt.axis('off')
    plt.savefig("image.png")

render(observations.rgb(state.env_state.state), "Initial observation")
network = ActorCritic(env.action_space(None).n, activation=config["ACTIVATION"])
params = out['runner_state'][0].params

for t in range(100):
    rng, _rng = jax.random.split(rng)
    pi, _ = network.apply(params, obs)
    action = pi.sample(seed=_rng)
    print(action)
    obs, state, reward, done, info = env.step(rng, state, action, None)
    render(observations.rgb(state.env_state.state), f"Step {t}")
    input('Continue...')

The initial observation:

After 2 steps:

After 3 steps:

I had the same with the DoorKey environments, where agents simply walk through the dividing wall. Any ideas of what is happening?
Thanks!
Daniel

Hey! It's definitely a bug introduced by some new commit -- let me have a look into into today and I'll get back to you asap.

I just had a look, and spotted a bug.
It should be fixed in #84, let me know if that works for you.
You can install the dev branch with:
pip install git+https://github.com/epignatelli/navix.git@fix-walkable


Always call get_public_key on NIP46 signer, but cache result locally

Although a very simple change I thought this was going to work, but when I tried to run Coracle with the local welshman dependencies I ran into a million problems and then when it finally ran it was hitting some seemingly unrelated errors (which also happen when I run Coracle locally without modifying the dependencies), so I gave up and opened this PR that I know will be rejected.
Addresses https://github.com/nostr-protocol/nips/pull/1545.

I don't understand, the broker is always called with the user's pubkey (see packages/app/src/session.ts). It would be really weird for the signer to return a different pubkey than what the user was attempting to sign with. The part that might actually need to be changed is line 102, where the request payload is encrypted to the user's pubkey, which has always been weird to me. Am I getting this right?

How do you know the user pubkey if you haven't called get_public_key yet?

I've already dereferenced the NIP 05 handle they gave me, which gives me the user pubkey

But not in the case of a bunker URL.

Ok, merged, but indirectly: https://github.com/coracle-social/welshman/commit/dc62248b7ca54f6a7955e558c5a93b2d827fa314


[Modal] Cannot focus iframe when open

This bug was introduced by https://github.com/mui-org/material-ui/pull/16585

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
When an dialog is open, it steals the focus.

(At the end of the gif I can focus the editor again, but I think that's because of a hot-update of codesandbox, which interrupts the focus loop of the dialog.)

Expected Behavior 🤔
When the dialog is open, I can focus unrelated parts of the tab (e.g. in an iframe).

Steps to Reproduce 🕹
on sandbox (https://codesandbox.io/s/cllze)

open simple dialog
try to focus the editor, after 200ms the focus will lost, so you cannot inoput something in the editor

Context 🔦
I stumbled across it because I use a payment service provider that loads an iframe with an embedded modal where the customer can then make the payment. Unfortunately, this was no longer possible since release 4.3.0, as the input fields of the payment service provider immediately lost focus. Since there was no error message, it was only noticed when a customer reported the error.

Your Environment 🌎

Tech
Version

Material-UI
since v4.3.3 (https://github.com/mui-org/material-ui/pull/16585)

The dialog containing focus is intended following https://www.w3.org/TR/wai-aria-practices/#dialog_modal:

That is, users cannot interact with content outside an active dialog window.

So the codesandbox behavior is correct.
I guess in your use case you have an iframe within that dialog and the dialog does not allow the iframe to be focused? Could you create a codesandbox with that specific use case?

@eps1lon Thank you very much for your answer.
I have created a sandbox, which simulates my case quite well: https://codesandbox.io/s/material-demo-jlbtn
before version 4.3.0 it worked like this, then unfortunately no more. So for me 4.3 was a bit like a hidden breaking change.

The concern seems very close to #15694 and #15450. You can find 3 props related to focus management on the Modal and Dialog components: disableEnforceFocus, disableAutoFocus and disableRestoreFocus.

before version 4.3.0 it worked like this, then unfortunately no more. So for me 4.3 was a bit like a hidden breaking change.

@PutziSan Or a bug fix, it depends on your perspective.

Regarding better supporting this use case, it's tricky as the logic comes from TrapFocus, a component we will likely defer to React itself in the future. In this context, I can only suggest you to disable the focus enforce feature with the disableEnforceFocus prop.

I think trapping the focus only within the current focus is a reasonable feature to have. Since this is security related it's even more useful.
I would keep this open since we have no idea if or when better react primitives land. It might be worth looking into a better solution in the meantime.

As far as i understood there will be not fix, nor workaround as it depends on React internals, that is in progress, and react update cycle is quite... unpredictable.
What would you suggest right now?

@neemah

The current workaround is to disable one of the accessibility requirement with disableEnforceFocus.
We don't depend yet on React internals.
We are interested in providing a better solution

Sorry i thought that there is something in React that is being refactoring and will help to fix this issue :-(
Thanks for suggestion, we will try!!! 🙏

As far as i understood there will be not fix, nor workaround as it depends on React internals, that is in progress, and react update cycle is quite... unpredictable.

:thinking:

It might be worth looking into a better solution in the meantime.

I wanted to emphasize that any solution we do implement has to be tested thoroughly since the implementation itself might change very soon.
Focus isn't an easy problem which is illustrated again by this issue. Our implementation traps focus inside the window of the dialog container. We need to make sure that if we  do allow other windows to get focus that these windows are part of the dialog. It is probably tricky to determine that given that the DOM tree isn't a subset of the react tree (because portals) and we need to know if that other window is part of the dialog. I'm not even sure we can know if focus moved to an iframe or if this fact is hidden for security reasons. At that point it will be impossible to contain the focus properly since it's indistinguishable from #16584

Given more thoughts to this problem, I can't think of anything better than an update of the documentation:
diff --git a/docs/src/pages/components/modal/modal.md b/docs/src/pages/components/modal/modal.md
index f2c3b19c8..24966c8be 100644
--- a/docs/src/pages/components/modal/modal.md
+++ b/docs/src/pages/components/modal/modal.md
@@ -62,6 +62,14 @@ In order to display the modal, you need to disable the portal feature with the `

 {{"demo": "pages/components/modal/ServerModal.js"}}

+## Limitations
+
+### Focus trap
+
+The modal moves the focus back to the body of the component if the focus tries to escape it.
+
+This is done for accessibility purposes, however, it might create issues.
+In the event the users need to interact with another part of the page, e.g. with a chatbot window, you can disable the behavior:
+
+```jsx
+<Modal disableEnforceFocus />
+```
+
 ## Accessibility

 (WAI-ARIA: https://www.w3.org/TR/wai-aria-practices/#dialog_modal)

@PutziSan What do you think about it? Do you want to give it a pull request? :)

Yeah, I'm happy to do that, thanks for the chance.
Should I also add a link on the dialog documentation page similar to Dialogs#accessibility?
in docs/src/pages/components/dialogs/dialogs.md:
 {{"demo": "pages/components/dialogs/ScrollDialog.js"}}

+ ## Limitations
+
+ Follow the [Modal limitations section](/components/modal/#limitations).
+
 ## Accessibility

 Follow the [Modal accessibility section](/components/modal/#accessibility).

@PutziSan Possible.

This would be sweet. We have translations in context editor. Putting editor or app into iframe does not work for us. We workarounded this with disableEnforceFocus in theme for now.

I am also facing this issue whenever any dialog is opened on another dialog which is made by material UI then I am unable to type on the input of new dialog open. Is there anything I can do to fix it?

Just wondering if there are any plans with allow iframes to escape the focus trap?

@joeyzhousherwin I have updated the title of the issue as most of the feedback we got seemed related to handling iframes. There is no update other than we document it https://next.material-ui.com/components/modal/#focus-trap.
Feel free to upvote this issue if you think that the focus shouldn't steal from the iframes.
Reading https://www.w3.org/TR/wai-aria-practices/#dialog_modal more carefully, it does feel like an iframe chatbot could be considered as part of the modal displayed, even if not inside the same parent DOM node. But the current workaround might be enough.
Sometimes, I also wonder if a dedicated prop to consider extra components as part of the trap focus could make sense, like this option https://github.com/focus-trap/focus-trap-react#containerelements


x/vgo: some way to opt out of semver for a while?

This is more a question than anything.
After following (most of) the vgo discussion, I came away with a sense that gophers are expected to adhere strictly to semver, and in particular avoid breaking changes once v1 has been released.
But @rsc recently wrote in https://github.com/golang/go/issues/25503#issuecomment-394486833:

[...] my suggestion is still a v2 top-level directory, and maybe a strongly worded v2/README.md that you are going to make backwards-incompatible changes there for a while.

There is a need for experimental phases after v1 has been released, as new major versions get worked on. It seems to me it would be better for the package authors to be able to communicate that directly to vgo somehow, instead of via a strongly worded README. (Somewhat related: #25524, although that might not be the preferred mechanism.)

Question: if the goal is to communicate to vgo, what should vgo (the build system and MVS) do with this information?
If communicating with a user I would say v2.0.0-unstable-1

Question: if the goal is to communicate to vgo, what should vgo (the build system and MVS) do with this information?

I'd say treat it as vgo does pre-1.0 versions. In particular don't assume semver compatibility promises. (But maybe I'm just confused about all of this. Wouldn't be the first time.)

Could you not make the breaking changes on a branch (could be master), where the go.mod on the branch has the /v2 (or whatever major version you're at) added. Then use vgo get example.com/hello/v2@branch_name to use v2 (in this case) pseudo-version?

One of the confusion I had (and still have) while reading vgo blog posts is the relationship between the samantic version import and the semver looking version tag used in go.mod.
According to @myitcv's comment, I assume we can even continue using golang.org/x/debug/v2 with v0.0.0-(utctime)-(commitid) convention. Similarly golang.org/x/debug can be tagged with v999.0.0, which matches one of the examples in the 6th blog post. Am I misunderstanding it?

I'm not sure how vgo plans to handle this, but per semver, versions such as 2.0.0-alpha or 2.0.0-alpha.2 are supported in the spec.

@josharian That comment was in the context of the x repos, where we are still working out what the general plan is for tagging versions (more complex than most because they are kind of monorepo-esque). If actually tagging things was an option (we're just not ready yet) then we'd put a v2/go.mod there that said module golang.org/x/debug/v2 and either not issue any tags at all (in which case it would be all pseudo-versions, and you get what you get) or use tags like v2.0.0-unstable-SOMETHING. That kind of prerelease semver tag is how you opt out of compatibility, which is what I think you meant instead of "opt out of semver". The strongly worded README is only necessary because we haven't finalized plans for golang.org/x.
@hyangah If the module path ends in /v2, then the version in go.mod must begin with v2. For a v2 module you'd use a pseudo-version that was v2.0.0-time-commit instead of v0.0.0-time-commit.
golang.org/x/debug can be tagged with v999.0.0 but unless there is a go.mod there saying module golang.org/x/debug/v999 and the code is imported that way, that tag is not going to be used by vgo.


Add assembly implementations for arm, arm64 and x86

To use safenum in protonmail's mobile applications, we'd like to add arm, arm64 and x86 support.
I've copied the assembly implementations from big.Int and removed the non-needed implementations, similar to what was done for amd64.
However I'm not sure if the code is constant time, I've seen that for amd64 some calls for 'large' subroutines were removed, I haven't found similar calls in the other archs.

Looks like a good addition to me; good job!
I'll merge this and then bump a release.


TS Server stats odd seeming file names when resolving json import

Related to #52695
Bug Report
🔎 Search Terms

fs.stat
statSync
performance

Problem
In a JS file, write:
const a = require('./x.json');

This causes TS Server to stat some odd seeming file paths, such as:
stat /Users/matb/projects/san/x.d.json.ts
stat /Users/matb/projects/san/x.json.ts
stat /Users/matb/projects/san/x.json.tsx
stat /Users/matb/projects/san/x.json.d.ts
stat /Users/matb/projects/san/x.json.js
stat /Users/matb/projects/san/x.json.jsx

Could these calls be avoided? It seems unlikely that you'd want to resolve files with those names in this case
Discovered this while working on project wide IntelliSense for web

This is part of how module resolution works for json.
Related #51435


replace std feature gate alloc imports with extern crate alloc

Describe the feature
we have no-std support on a few crates,
alloc types, are currently feature gated like:
https://github.com/paradigmxyz/reth/blob/875cee27aca747315af1ef2a9dcdf29e058b33e7/crates/chainspec/src/spec.rs#L3-L4
this can be avoided by not feature gating
https://github.com/paradigmxyz/reth/blob/875cee27aca747315af1ef2a9dcdf29e058b33e7/crates/chainspec/src/lib.rs#L12-L13
and always use use alloc::
TODO

replace feature gated alloc usage with extern crate alloc

Additional context
No response

I can take a stab at this

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
I have 1 year experience in Cairo language, Rust, Dojo Engine. Additionally, I have problem solving skills, self-learning skills, and some soft skills.