Detach include template resolution from Engine

It seems that template resolution being tied to the Engine is limiting in several ways:

The docs recommend using Engine::compile if the template source is borrowed, but templates created that way cannot ever be used as an include because there is no way to add an already-compiled Template to an Engine
It is not possible to have relative-path includes akin to those found in handlebars, liquid, etc.
It is not possible to control which templates have access to which other templates

Could Renderer (and, by extension, the render methods on Template) perhaps store a closure for get_template that is supplied by the user, instead of templates being stored in engine.templates?

Considering this would be a breaking change, I am left wondering if you would be open to supporting a usecase like this.
If you would, how would the API look? Should this just be a new function altogether (render_from_with_template_fn, render_with_value_template_fn)? That looks like it would complicate the API a lot, but there may be some middle ground that supports this new use case without affecting the original resolution mechanism.
With your input, depending on what approach you would most prefer, I would be more than happy to draft up a PR. Thank you for your work on this great crate!

I am open to breaking changes. I also thought there would be too many render functions if you want to allow all the combinations. I think it would be good to decide on an approach first before putting in a lot of effort. The one idea I had was for the complex render functions to return a struct that can have these settings modified (similar to the builder
pattern) and perhaps for the more commonly used render functions to just be shorthand for this. The returned struct could just be basically the current non-public Renderer struct with some changes to the API.
If we add this feature we will have the following options:

Context: simple value / serde value / value fn
Output: string or writer
Template Fn: from engine or from custom function
There is also the max include depth setting which could be set at render time not just in the engine.

API ideas
Render serde context to writer
template.render(ctx)?.to_writer(w)?;

Render using value function, with template function, to a string
template.render_with_value_fn(value_fn).with_template_fn(template_fn).to_string()?

Render from value to a string
template.render_from(&value).to_string()?

Render from value to a writer
template.render_from(&value).to_writer(w)?

Render with a different max include depth
template.render(ctx)?.with_max_include_depth(12).to_string()?;

Not sure of the naming of all of these methods. Particularly to_string() since it's obviously already in the std library.

I agree that naively adding all the combinations would get very clunky very quickly, and so we should definitely decide on an API first if we were to pursue this further.
I am a fan of the builder-pattern-esque API you suggested! However, one thing is
template.render_with_value_fn(value_fn).with_template_fn(template_fn).to_string()?

This is confusing to me. with_value_fn and with_template_fn feel too similar, although one is mandatory and one is just an option.
I think perhaps render, render_from, and render_from_fn would work? You mentioned in #18 that *_from might not work if we change the bound to AsRef<Value>, but I think it's still fine in that it conveys the idea that you take a value/value fn and render the template using/from it.
Side note: String implements Write, so I think it would be nice from a maintenance perspective to have to_string() here be implemented in terms of to_writer() and remove that distinction from the rendering code itself.

I agree with your point about with_value_fn and with_template_fn. I like the idea of render, render_from, and render_from_fn as being the main three functions on Template{,Ref}
Possible public API for this
(I've left out lifetimes for now)
impl Template(,Ref) {
    pub fn render<S>(&self, ctx: S) -> Result<Renderer>
    where
        S: serde::Serialize,;

    pub fn render_from(&self, ctx: &Value) -> Renderer;

    pub fn render_from_fn<F>(&self, value_fn: F) -> Renderer
    where
        F: Fn(&[ValueKey<'_>]) -> std::result::Result<Value, String>;
}

impl Renderer {
    pub fn with_max_include_depth(self, depth: usize) -> Renderer;

    pub fn with_template_fn<F>(self, template_fn: F) -> Renderer
    where
        F: Fn(&str) -> Option<Template>;

    pub fn to_string(self) -> Result<String>;

    pub fn to_writer<W>(self, writer: W) -> Result<()>
    where
        W: io::Write;
}

With regards to your side note
I'm not sure I fully understand your point here. String implements fmt::Write but the to_writer should take an io::Write. Most of the render logic is already generic over both of these:
impl {
    pub fn render(&mut self) -> Result<String> {
        let mut s = String::with_capacity(self.template.source.len());
        let mut f = Formatter::with_string(&mut s);
        self.render_impl(&mut f)?;
        Ok(s)
    }

    pub fn render_to_writer<W>(&mut self, writer: W) -> Result<()>
    where
        W: io::Write,
    {
        let mut w = Writer::new(writer);
        let mut f = Formatter::with_writer(&mut w);
        self.render_impl(&mut f)
            .map_err(|err| w.take_err().map(Error::from).unwrap_or(err))
    }

    fn render_impl(&mut self, f: &mut Formatter<'_>) -> Result<()> {
        // ...
    }
}

First version of this implemented in 39a5542981ef6492b23a198823c235dcb4968e4e


Add CertificateChainVerifier implementation

A CertificateChainVerifier implementation is now available using
mbedtls. This implementation is behind the x509 feature flag.

Current dependencies on/for this PR:

main

PR #131

PR #132

PR #135   👈

This comment was auto-generated by Graphite.

Current dependencies on/for this PR:

main

PR #131

PR #132

PR #135   👈

This comment was auto-generated by Graphite.


Generic, on-demand processing of query metadata

Currently we're "statically" processing query metadata (e.g. endpoint, method, tags, etc.). An option would be to pass a list through the parameter extraMetadata of build_spec() with the parameters that we want to be processed.

https://github.com/CLARIAH/grlc/commit/3de485f7fe0ee684800723048c53bfd8dc0a72ed added a generic trailing processing of extra metadata, considering fixed


Feature: Info Dialog box create here  (Ping on discord me for this issue , I will briefly say)

Feature description
Ping on discord me for this issue , I will briefly say

👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I agree to follow this project's Code of Conduct

assign me this issue


[operator] Manage gardener-metrics-exporter

How to categorize this PR?

/area monitoring
/kind enhancement
What this PR does / why we need it:
With this PR, gardener-operator is enhanced to manage gardener-metrics-exporter.
Which issue(s) this PR fixes:
Part of https://github.com/gardener/gardener/issues/7016
Special notes for your reviewer:
In draft until https://github.com/gardener/gardener/pull/8309 this is merged.
Release note:

`gardener-operator` now takes over management of `gardener-metrics-exporter`.

FYI @istvanballok @rickardsjp

/assign


Add option to use box-draw chars with --tree

This picks up and hopefully completes PR #3560.
Add documentation for new --tree "linedraw" option to manpage.
There is a new example output in userguide, which renumbers several of the existing troubleshoot_tree example outputs due to the insertion - these did not otherwise change.
Test is cleaned up a bit (not just the added part).
The actual implementation in Util.py is made a little more general - it uses unicode chr() values (with comments) instead of literally pasting in the line drawing characters.
The rest of the PR is as described in #3560
Contributor Checklist:

[X] I have created a new test or updated the unit tests to cover the new/changed functionality.
[X] I have updated src/CHANGES.txt (and read the README.txt in that directory)
[X] I have updated the appropriate documentation

Thank you guys for taking over this work !


How to run OPC publisher 2.7 on docker

Hi Team,
I am very new to OPC publisher.
I have setup a OPC simulator server, OPC UA explorer getting live simulation feed.
I want to run OPC Publisher as docker module and connect to OPC UA to get the data.
I found alot of documentation on how to setup from Azure IOT hub but I can not find much documentation on how to run opc publisher as docker container.
As you know I am new, here are some of my questions

Do I need Edge runtime, IOT Hub etc to run OPC publisher as a docker container
Do I need to use IOTEDGEDEV to create environment before I should try to run docker run mcr.microsoft.com/iotedge/opc-publisher:2.7  as per documentation

Please let me know in detail. I am using windows server 2019 and docker basically windows based container.
I would like to say thankyou in advance

Hi,
we are using the publisher as docker container as well. I start it like that
docker run -d -v $(pwd)/opcpublisher:/appdata --name opcpublisher {publisherAcr} --pf=/appdata/pn.json --re true --fd=false --ll=Information --mm=PubSub --fm=false --aa --dc="{your device/module connection string from the IoT Hub IoT device}"
You need to create the pn.json in the "/opcpublisher" directory.
You need to replace the two placeholder parameters with you settings and make changes to the other parameters like "--re" and so on.
Have fun...

Hi Haeavar,
Thankyou for response, looks like you are running on linux, I needed a windows example

Hi, instructions are the same except for the volume mount which needs a folder on windows containing the json file.
Documentation in the docs/deploy folder is pretty extensive and explains how to deploy Publisher in iot edge, which is the only supported setup right now.  We are however interested to hear what you need, e.g. docker only or kubernetes hosting.  Please open feature request for any missing functionality.

Hey Marchchier,
I managed to solve this and you are right
I used below
docker run -v C:\iotedge:c:/appdata mcr.microsoft.com/iotedge/opc-publisher:latest mydevice --dc "mydeviceconnectionstring" --pf=c:\appdata\pn.json --aa
incase someone needs help.


Do not want video to autoplay

Whenever I include the player.js it autoplays the ads and my video, I do not want this especially on a page that lists several videos and they all start playing at once....

Hey @JoshWobbles !
Can you link me to a sample page this is happening on or a place I can see the code that's causing videos to autoplay? Any extra information would help with tracking down the source of this bug

sorry but I have since removed the script from my site. I could either get it to not autoplay (and no ads would play) or autoplay with ads.

Hey Josh,
Sorry to hear you couldn't get it working. All of our samples are non-autoplay, except for the autoplay sample of course, so feel free to take a look at those for reference if you try to get this working again.
Thanks,
Shawn


Update tekton-dashboard to LTS

In current release EDP use 0.35.0 version of Tekton Dashboard.
Available new Tekton Dashboard Releases - https://github.com/tektoncd/dashboard/releases
Acceptance Criteria:

EDP use latest stable version of Tekton Dashboard

I am happy to report that I successfully completed the task and updated the Tekton Dashboard version in EDP to v0.36.1. EDP now uses the latest stable version of Tekton Dashboard at the moment. The update will allow us to take advantage of the new features, improvements, and bug fixes provided in this release. We continue to improve and update our system to provide a more efficient experience.

I am happy to report that I successfully completed the task and updated the Tekton Dashboard version in EDP to v0.36.1. EDP now uses the latest stable version of Tekton Dashboard at the moment. The update will allow us to take advantage of the new features, improvements, and bug fixes provided in this release. We continue to improve and update our system to provide a more efficient experience.


Help: writing a language parser

The documentation is not very clear to me about how to use certain combinators.
What I'm struggling to understand is how to i.e. parse this:
-- This will be an mvp program parsed and interpreted by Rust
-- get_current_time will return an incremental value, it will be provided by rust
-- println will map directly to rust println

process_input -> println 'process_input called'
render deltatime -> println 'render called with elapsed: {deltatime}'

game_loop last_time -> {
  current = get_current_time
  elapsed = current - last_time

  process_input
  render elapsed

  game_loop current
}

main -> {
  game_loop get_current_time 0
}

This is how my entry parser looks like
fn parse_expressions(i: &str) -> IResult<&str, Vec<Expression>> {
  many0(
    delimited(
      multispace0,
      alt((
        parse_function_delcaration,
        parse_comment,
      )),
      opt(multispace0)
    )
  )(i)
}

So the problem here for me is that it only parses only continuous comments or functions, so if I add a function then a comment and then another function the parser just stops, also the line breaks for some reason stops the parser, parsing comments are working, with this syntax I didn't manage to make a function parser to work, but with other I did, so I can parse when there is just one function, one or more comments, but not when they are mixed.
I used the examples as starting point, and also the combinators list (the documentation is, at least for me, not too good, the descriptions are short and not always descriptive for someone without experience with parsers).
Regards

opt(multispace0) immediately strikes me as odd, since the multispace0 parser can't fail in the first place. But that shouldn't affect whether the parser works.
I can post some parsing code that I've used to parse a simple assembly language.
fn line(input: &str) -> ParseResult<Option<Instruction>> {
    terminated(
        delimited(space0, opt(instruction), space0),
        opt(line_comment),
    )(input)
}

fn program(input: &str) -> ParseResult<Vec<Instruction>> {
    map(separated_list(line_ending, line), |v| {
        v.into_iter().flatten().collect()
    })(input)
}

The first function parses a line, which possibly contains an instruction surrounded on both sides by zero or more spaces and possibly also a line comment. It returns Option<Instruction> because maybe the line was empty or it was only a comment.
The second function parses a list of lines delimited by line breaks, i.e., a program. Maybe separated_list is appropriate for your use case?

Sorry for the late reply, but thanks I will try that.


fix(Navigation): Move camera directly above when following ship

Description of Changes
UI:

Positions the camera directly above the ship on the Y axis when the "Follow Ship" button is clicked

Related Issue

Closes #467
How do you know the changes work correctly?

Manual Testing

The follow ship button seems to be working great. It resets the view ok and stays following the ship when you zoom in/out.


[Perf][UI Next][V1.0.0-Beta] Optimize judgment logic.

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

Codecov Report

Merging #9561 (fc0f560) into dev (5529a23) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #9561      +/-   ##
============================================
- Coverage     39.95%   39.94%   -0.02%
+ Complexity     4431     4429       -2
============================================
  Files           831      831
  Lines         33314    33314
  Branches       3677     3677
============================================
- Hits          13311    13307       -4
- Misses        18776    18778       +2
- Partials       1227     1229       +2

Impacted Files
Coverage Δ

...e/dolphinscheduler/remote/NettyRemotingClient.java
50.70% <0.00%> (-2.82%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5529a23...fc0f560. Read the comment docs.


package wrong(java)

All the packages can't work normally.
For example:
package cn.edu.sustech.cs307.dto.prerequisite;
If change the package to package main.java.cn.edu.sustech.cs307.dto.prerequisite; It will be ok.
I wonder how to solve this problem. I think changing all the packages is not so good.....

Please import this project as a maven project. main and java is not part of the package.

Note that when cloning project using Intellij IDEA, select "Trust Mode" for maven.
You should also be able to get maven working by right-clicking on the project in project window, and choose "Add Framework Support", then choose Maven.

Thank you for your explanation!
Sorry, I can't find maven after I click the "Add Framework Support"

There is still something wrong like this.

You may open pom.xml and see if there is a trust project button.

Sorry, I haven't seen this button all the time.
But when I clone the project, I choose a trust bottom like this.

After trust and syncing the maven project, it still does not work? Does maven gives any error message?

Yes, there are many errors

Thank you for your patience!
I have solved this problem successfully!
Good night!

@xbdeng consider putting your solution here for other students having same problem. :)

Change the JDK to  edition 16
Maven: Failed to read artifact descriptor
解决Cannot resolve plugin org.apache.maven.plugins:maven-site-plugin:3.3问题


updated KBs with CAM screen shots

updated KBs with CAM screen shots

@JasonEHolland please resolve conflicts

@JasonEHolland Please resolve conflicts


how to use single namespace mode

Type of question
Support question on installation modes
Question
I'd like to deploy the Prometheus operator in a namespace (monitoring-operators)  in such a way that it watches another namespace (sre-monitoring). This model should be the SingleNamespace model.
From it's csv, we can see that this model is supported:
    - supported: true
      type: SingleNamespace

This is how I deploy it:
apiVersion: operators.coreos.com/v1
kind: OperatorGroup
metadata:
  name: sre-operators
  namespace: monitoring-operators
spec:
  targetNamespaces:
  - sre-monitoring
---
apiVersion: operators.coreos.com/v1alpha1
kind: Subscription
metadata:
  name: prometheus-operator
  namespace: monitoring-operators
spec:
  channel: beta
  installPlanApproval: Automatic
  name: prometheus
  source: community-operators
  sourceNamespace: openshift-marketplace

When I deploy a Prometheus objects in the sre-monitoring namespace the Prometheus operator pod emits these errors:
E0503 12:40:35.345388       1 reflector.go:125] github.com/coreos/prometheus-operator/pkg/prometheus/operator.go:448: Failed to list *v1.Prometheus: prometheuses.monitoring.coreos.com is forbidden: User "system:serviceaccount:monitoring-operators:prometheus-operator" cannot list resource "prometheuses" in API group "monitoring.coreos.com" in the namespace "sre-monitoring"
E0503 12:40:35.346505       1 reflector.go:125] github.com/coreos/prometheus-operator/pkg/prometheus/operator.go:452: Failed to list *v1.ConfigMap: configmaps is forbidden: User "system:serviceaccount:monitoring-operators:prometheus-operator" cannot list resource "configmaps" in API group "" in the namespace "sre-monitoring"
E0503 12:40:35.347453       1 reflector.go:125] github.com/coreos/prometheus-operator/pkg/prometheus/operator.go:449: Failed to list *v1.ServiceMonitor: servicemonitors.monitoring.coreos.com is forbidden: User "system:serviceaccount:monitoring-operators:prometheus-operator" cannot list resource "servicemonitors" in API group "monitoring.coreos.com" in the namespace "sre-monitoring"
E0503 12:40:35.348525       1 reflector.go:125] github.com/coreos/prometheus-operator/pkg/prometheus/operator.go:450: Failed to list *v1.PodMonitor: podmonitors.monitoring.coreos.com is forbidden: User "system:serviceaccount:monitoring-operators:prometheus-operator" cannot list resource "podmonitors" in API group "monitoring.coreos.com" in the namespace "sre-monitoring"
E0503 12:40:35.349580       1 reflector.go:125] github.com/coreos/prometheus-operator/pkg/prometheus/operator.go:454: Failed to list *v1.StatefulSet: statefulsets.apps is forbidden: User "system:serviceaccount:monitoring-operators:prometheus-operator" cannot list resource "statefulsets" in API group "apps" in the namespace "sre-monitoring"
E0503 12:40:35.350639       1 reflector.go:125] github.com/coreos/prometheus-operator/pkg/prometheus/operator.go:455: Failed to list *v1.Namespace: namespaces "sre-monitoring" is forbidden: User "system:serviceaccount:monitoring-operators:prometheus-operator" cannot get resource "namespaces" in API group "" in the namespace "sre-monitoring"

so basically the permissions are not setup correctly.
Questions:

am I setting up the SingleNamespace model correctly?
what does OLM do to setup the permissions in this case (or what is it supposed to do)?

What did you do?
see above
What did you expect to see?
Prometheus operator should have deployed a Prometheus instance
What did you see instead? Under which circumstances?
error log, see above.
Environment
OpenShift 4.3
Prometheus operator: 0.32.0

Please consult with the doc: https://olm.operatorframework.io/docs/concepts/crds/operatorgroup/


Add bounds check to inventory for latitude and longitude

Updated inventory to check maximum and minimum of latitude and longitude are within expected values
Checks the max and min - if either is nan, evaluates again using float(coord.min())
Also updated the doc strings on roocs_utils.project_utils

Thanks @agstephens, this won't affect the inventory itself, just the inventory maker code


Inconsistent BatchSize

https://github.com/google/airdialogue_model/blob/5bdc7996a6dd27c5f31c4ff5d4fd092a1d17a599/self_play.py#L132-L144
In line 144, we should replace batch_size by end_ind-start_ind. Otherwise, there will be an inconsistent batchsize issue in the last iteration.

This will be fixed in #6

Address in #10


Update DB2IBMiPlatform::getListViewsSQL() in order to remove useless "1=1" condition

Addressed in #50.


.save() removes attributes from model ?

Hey. Thanks for backbone-pouch, everything is very smooth so far :)
I'm porting an application that saves the models on a remote server via Backbone's XHR to PouchDB and backbone-pouchdb. In the current version, save() sends the complete JSON representation to the server and retrieves a complete JSON representation back from the server (I guess that's custom to my application, but I believe that is a nice REST architecture and allows the server to also change the document).
So, in Model.parse, my code (quoting http://backbonejs.org/#changelog 's 1.1.0 section here)

"extract[s] and vivify[s] incoming nested JSON into associated submodels. "

With backbone-pouchdb, however, the data argument for parse is always an object containing just _id and _rev, without the attributes that have just been saved, because of these lines:
response = {
  _id: response.id,
  _rev: response.rev
};

I'd propose to respond with this instead:
response = extend({}, model.toJSON(), {
  _id: response.id,
  _rev: response.rev
});

so the model doesn't think the the server (or PouchDB in this case) deleted all the attributes.
Also, one could argue to only call model.toJSON() once, but I wanted to discuss in general this first before making optimizations.

CouchDB, and so PouchDB, always responds with id and rev on successful document updates:
{
    "id": "SpaghettiWithMeatballs",
    "ok": true,
    "rev": "2-790895a73b63fb91dd863388398483dd"
}

I suggest to rewrite the parse functions in a way that they are non-destructive.

Please reopen if still an issue


xDS Istop Interop: Add differentiation on the protocol being used

Changes -

Figure out whether a port uses xDS (builder and creds) / TLS creds / insecure creds based on the command line flags. (Note that we do not listen on http/tcp specific ports at the moment since we do not care about those.)
ForwardEcho handler - Use XdsCreds when the scheme is xds, insecure creds when the scheme is grpc (not adding support for tls at the moment) and fail all other schemes. (In the future, we will probably forward requests with all other schemes handling to something else.)

Thanks for the review!


oauth2client is broken under Python 3.8 and gcalcli needs to move to alternate

oauth2client is broken with Python >= 3.8.
gcalcli has a hard dependency on oauth2client presently, that could be replaced by another provider with significant work.
Python 3.7 approaching end of life and removal from linux distributions, which means oauth2client is going to break, and thus gcalcli will break as well unless the dependency is replaced.
Reference: https://bugs.gentoo.org/718972 - gentoo oauth2client removal
Reference: https://endoflife.date/python Python 3.7 end of life details

The testcases definetly showed some broken paths - esp in contrib modules that are tested by default
I fixed it in a fork instead:
https://github.com/robbat2/oauth2client
Includes py3.11 support now.


Make cards dark on dark backgrounds

@kybaker suggested that cards should react to where they are, so if a user places a card on a dark container, it'd become dark too.
This needs visual design before implementation.

:tada: This issue has been resolved in version 1.0.44 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Change - to en-dash between start and end date in Events block

 Event section - all newsletters


Add missing initialization of values in termination detection

Some variables of td_t are not initialized at gtc_reset, which caused the program to get stuck at the end of the second run of gtc_process.
I fixed the problem and confirmed that gtc_process can be executed repeatedly (without stuck) after this fix.

Shumpei, thank you for the PR. Much appreciate the bug fix.


No sound out of the speaker

Hi, I absolutely love this project and all of the hard work that you and others have put into this. I have nothing respect and awe for you all. I have a question and was wondering if you who are much more knowledgable would know what to do.
I have two new onju voice Nest mini's that I've put together. I just got a batch from PCBWay and have installed in a brand new Nest Mini 2 as well as a few years old Nest Mini 2. Neither one will output sound. They respond to my wakeword, process my speech and I see sound files created which when I play on PC, sound great. However, the Mini doesn't want to play it. Also, it does an odd thing where it disconnects wifi right after it tries to play.
[17:04:59][D][voice_assistant:532]: Wake word detected
[17:04:59][D][voice_assistant:523]: Event Type: 3
[17:04:59][D][voice_assistant:537]: STT started
[17:04:59][D][light:036]: 'top_led' Setting:
[17:04:59][D][light:051]:   Brightness: 100%
[17:04:59][D][light:059]:   Red: 100%, Green: 100%, Blue: 100%
[17:04:59][D][light:109]:   Effect: 'listening'
[17:04:59][D][voice_assistant:523]: Event Type: 11
[17:04:59][D][voice_assistant:677]: Starting STT by VAD
[17:05:00][D][voice_assistant:523]: Event Type: 12
[17:05:00][D][voice_assistant:681]: STT by VAD end
[17:05:00][D][voice_assistant:416]: State changed from STREAMING_MICROPHONE to STOP_MICROPHONE
[17:05:00][D][voice_assistant:422]: Desired state set to AWAITING_RESPONSE
[17:05:00][D][voice_assistant:416]: State changed from STOP_MICROPHONE to STOPPING_MICROPHONE
[17:05:00][D][light:036]: 'top_led' Setting:
[17:05:00][D][light:051]:   Brightness: 70%
[17:05:00][D][light:059]:   Red: 0%, Green: 20%, Blue: 100%
[17:05:00][D][light:109]:   Effect: 'processing'
[17:05:00][D][voice_assistant:416]: State changed from STOPPING_MICROPHONE to AWAITING_RESPONSE
[17:05:02][D][voice_assistant:523]: Event Type: 4
[17:05:02][D][voice_assistant:551]: Speech recognised as: " What time is it?"
[17:05:02][D][voice_assistant:523]: Event Type: 5
[17:05:02][D][voice_assistant:556]: Intent started
[17:05:02][D][voice_assistant:523]: Event Type: 6
[17:05:02][D][voice_assistant:523]: Event Type: 7
[17:05:02][D][voice_assistant:579]: Response: "Sorry, I couldn't understand that"
[17:05:02][D][voice_assistant:523]: Event Type: 8
[17:05:02][D][voice_assistant:599]: Response URL: "http://<IP_ADDRESS>:8123/api/tts_proxy/dae2cdcb27a1d1c3b07ba2c7db91480f9d4bfd8f_en-gb_183ef190f5_tts.piper.mp3"
[17:05:02][D][voice_assistant:416]: State changed from AWAITING_RESPONSE to STREAMING_RESPONSE
[17:05:02][D][voice_assistant:422]: Desired state set to STREAMING_RESPONSE
[17:05:02][D][media_player:059]: 'Onju Voice v3 dde0c8 - #2' - Setting
[17:05:02][D][media_player:066]:   Media URL: http://<IP_ADDRESS>:8123/api/tts_proxy/dae2cdcb27a1d1c3b07ba2c7db91480f9d4bfd8f_en-gb_183ef190f5_tts.piper.mp3
[17:05:02][D][media_player:059]: 'Onju Voice v3 dde0c8 - #2' - Setting
[17:05:02][D][media_player:066]:   Media URL: http://<IP_ADDRESS>:8123/api/tts_proxy/dae2cdcb27a1d1c3b07ba2c7db91480f9d4bfd8f_en-gb_183ef190f5_tts.piper.mp3
[17:05:02][D][light:036]: 'top_led' Setting:
[17:05:02][D][light:059]:   Red: 20%, Green: 100%, Blue: 0%
[17:05:02][D][light:109]:   Effect: 'speaking'
[17:05:02][D][voice_assistant:523]: Event Type: 2
[17:05:02][D][voice_assistant:613]: Assist Pipeline ended
WARNING onju-voice-v3-2-dde0c8 @ <IP_ADDRESS>: Connection error occurred: [Errno 104] Connection reset by peer
INFO Processing unexpected disconnect from ESPHome API for onju-voice-v3-2-dde0c8 @ <IP_ADDRESS>
WARNING Disconnected from API
INFO Successfully connected to onju-voice-v3-2-dde0c8 @ <IP_ADDRESS> in 0.004s
INFO Successful handshake with onju-voice-v3-2-dde0c8 @ <IP_ADDRESS> in 0.094s
[17:05:30][D][voice_assistant:523]: Event Type: 0
[17:05:30][D][voice_assistant:523]: Event Type: 2
[17:05:30][D][voice_assistant:613]: Assist Pipeline ended
[17:05:30][D][voice_assistant:416]: State changed from STREAMING_MICROPHONE to IDLE
[17:05:30][D][voice_assistant:422]: Desired state set to IDLE
[17:05:30][D][voice_assistant:416]: State changed from IDLE to START_PIPELINE
[17:05:30][D][voice_assistant:422]: Desired state set to START_MICROPHONE
[17:05:30][D][voice_assistant:202]: Requesting start...
[17:05:30][D][voice_assistant:416]: State changed from START_PIPELINE to STARTING_PIPELINE
[17:05:30][D][voice_assistant:437]: Client started, streaming microphone
[17:05:30][D][voice_assistant:416]: State changed from STARTING_PIPELINE to STREAMING_MICROPHONE
[17:05:30][D][voice_assistant:422]: Desired state set to STREAMING_MICROPHONE
[17:05:30][D][voice_assistant:523]: Event Type: 1
[17:05:30][D][voice_assistant:526]: Assist Pipeline running
[17:05:30][D][voice_assistant:523]: Event Type: 9
[17:05:30][D][light:036]: 'top_led' Setting:
[17:05:30][D][light:051]:   Brightness: 60%
[17:05:30][D][light:059]:   Red: 100%, Green: 0%, Blue: 100%
[17:05:30][D][light:085]:   Transition length: 0.1s

What the log doesn't show is that it starts flashing green after it does a couple of orange fade-outs. Is there anything that I'm doing wrong? Do I need to consider that my whole batch of pcb's are bad? I don't see anything physically obvious wrong with the boards.
Thank you for any help you can provide

The green flashing means (as shown in the logs, too) that the connection to HA has been reset for some reason. In my experience, that is usually due to networking issues, which depend on your particular setup.
How are you running HA? HAOS? Is the server in the same network as the Onju? Do you have any firewall in place?

That was the help I needed! I deep dove into my firewall settings and found some issues. Fixed and now sound is all better. It works great, thank you!


Typescript: getMany() parameter mismatch with IVectorView and IVector

getMany() expects 2 function arguments in winrt with a function signature: uint GetMany(uint startIndex, T[] items)
It looks like in C++ codegen getMany(int, T[]) also expects two arguments, while the corresponding TypeScript codegen expects getMany to only take one argument.
There exist the logic / ability to create structs to return back to TS but it is missing for getMany, because there existing special casing in the codegen for indexOf which natively has a function signature similar to getMany of bool IndexOf(value, [out] uint index)

In this case, the TypeScript generation is incorrect. Arrays in WinRT are special in the sense that there's two different ways they can be handled. There's "output arrays" where the callee allocates and fills in the array and "fill arrays" where the caller allocates the array and the callee fills it in. The difference in metadata - I believe - is one is [out] T[] and the other is [out] ref T[]. I don't recall which one is which (I think ref means "fill"). If it's a fill array, the expected pattern is that the argument appears in the argument list (buffer provided by caller). The GetMany function accepts a fill array parameter.
TL;DR: The C++ codegen is correct. The TypeScript codegen likely doesn't fully understand the nuance of fill arrays

Duplicate of #175


Running on full .NET framework with referenced assemblies

I'm sorry if this has been asked before, but I can't find good/definitive information about this. The ASP.NET 5 RC1 MVC app had the option to be run either on full .NET framework or on .NET Core. The target monikers from RC1 are obviously not relevant anymore.
The reason I'm asking is because I'd like to reference existing .NET assemblies in the new MVC app which are not portable assemblies.
In the blank dotnet new app, I see only netcoreapp1.0 moniker:
 "frameworks": {
    "netcoreapp1.0": {
      "imports": "dnxcore50"
    }
  }

while the MVC app has the following moniker:
  "frameworks": {
    "netcoreapp1.0": {
      "imports": [
        "dotnet5.6",
        "dnxcore50",
        "portable-net45+win8"
      ]
    }
  }

The "imports" suggest that it should be possible to run on full .NET CLR (I'm guessing) but I can't reference assemblies (.NET Core projects only support referencing .NET framework assemblies in this release. To reference other assemblies, they need to be included in a NuGet package and reference that package) nor can I reference a .NET nuget package (for instance, try log4net) -- (The dependency log4net 2.0.5 does not support framework .NETCoreApp,Version=v1.0.). So, are we unable to run the "new MVC" framework on full .NET? Is this a tooling issue (and if so, what would be the workaround) or RC2 issue or is it actually designed that way (to be run only on .NET core and not on full .net framework)?
To be as concrete as possible, we're looking into upgrading existing infrastructure in a corporate environment and we need to reference (among other stuff) IBM DB2 and CTG assemblies, which are not (and who knows when and if) .NET core "compatible").
I'm guessing it should be possible by wrapping existing DLL in a "project.json" wrapper project while defining target framework moniker compatible with netstandard1.5 and somehow referencing the wrapped project from the MVC, but I'm not sure whether this is a way to go and whether it is a supported approach. I got the idea from Corefx documentation.
Any feedback would be appreciated.

You could target net451 in your projects - for e.g. https://github.com/aspnet/Mvc/blob/dev/samples/MvcSandbox/project.json#L37

@pranavkm thanks, for the pointer; I tried that -- my project wouldn't build if I add the net451 target framework moniker to project.json. The errors are along the following line:
Error NU1002	The dependency System.Diagnostics.Process 4.1.0-rc2-24027 does not support framework .NETFramework,Version=v4.5.1.
If I move the dependencies under the frameworks/netcoreapp1.0 element, the net451 does not build (missing dependencies, obviously).
I suppose I should use different dependencies for full .NET?
The referencing of the existing assembly is still unclear to me, though; previously we had a dnu wrap command to wrap an assembly; currently, there is no dotnet wrap command; Perhaps something like dotnet pack? Or is this because the tooling is "preview 1" and we should manually wrap the existing DLL?
I created a directory in the src folder (sibling of MVC Website project directory) and I put the simplest DLL in there with the following project.json:
{
  "dependencies": {
  },
  "frameworks": {
    "net451": {
      "bin": {
        "assembly": "ClassLibrary1.dll",
        "pdb": "ClassLibrary1.pdb"
      },
      "dependencies": {
      }
    }
  },
  "runtimes": {
    "win": { }
  },
  "version": "1.0.0-*"
}

I couldn't create a NuGet package:
C:\tmp\DeleteWeb\src\WrapLib>dotnet pack
Producing nuget package "WrapLib.1.0.0" for WrapLib
NuGetResources.CannotCreateEmptyPackage

nor could I reference this project.json project from the existing project.
So, in other words, recipe on how to target the full .NET framework and how to reference an existing assembly would be very nice.

BTW I set up a quick mtg for Monday to discuss this.

Yes, why default templates don't provide .NET framework (Windows only) templates?

@Jupakabra that template is effectively Windows-only anyway, unless you use Mono.

@skyflyer there are a few things going on here:

If you're using netcoreapp then you cannot use .NET 4.x assemblies/packages
If you're using net4xx then you can use the frameworkAssemblies section of project.json to reference DLLs that are installed by .NET Framework (the stuff in the GAC)

Either way, in general you should be able to "wrap" a DLL (either one that's on disk, or one that's built from a csproj) and then reference that from your app's project.json file.
@pakrym will see if we have a good sample we can share with you for how to do a wrapped project.

@Eilon, sounds good, but doesn't answer the question entirely. I'll tried searching for information, but came empty handed.
It would be nice if target framework monikers would be documented (or is it just me and I can't find them)?
And also, it would be nice if it was documented how to reference an existing dll with RC2 tooling.
Sure, this is not an MVC-only issue (and I should direct the question in another tracker), but the issues at hand relate to "how to run the new MVC on a full .NET framework". Given your answer, I suspect "File new project" and "changing netcoreapp to net451 framework should do the trick (will test it again ASAP tomorrow, but I tried that before and documented my failure above (3 days ago))? What about MVC dependencies?

@skyflyer You can look at mappings and names in https://github.com/NuGet/NuGet.Client/blob/dev/src/NuGet.Core/NuGet.Frameworks/DefaultFrameworkMappings.cs

All,
I managed to get it working with the following steps:

remove netcoreapp framework from project.json and replace it with an empty net451

add relevant NuGet dependencies in the main dependencies section of the project file

add a blank Class library project

reference an existing DLL in a Class Library project: I used a snippet from the web to reference the DLL on the disk using the following syntax:
"net451": {
  "bin": {
    "assembly": "external\\ClassLibrary1.dll",
    "pdb": "external\\ClassLibrary1.pdb"
  }
}

1. I referenced the class library project from the web project
1. It compiles and runs fine, even though Visual Studio Intellisense is not happy and is complaining that the "type or namespace ClassLibrary1 can not be found", which is strange, since it compiles and runs just fine.

It runs from visual studio and from the command line using `dotnet run`. I've [uploaded the solution for reference](https://github.com/skyflyer/RC2-AspNetCoreMvc-WithWrappedDll). I've also reported the Visual Studio Intellisense error through their feedback mechanism.

Indeed, RC2 broke the adding of .NET DLLs. But it works if you pack them using nuget and install via local nuget server for example.
How to create a package is here.
First option (from dll) didn't work for me, so I did it from csproj using this command: nuget pack MyProject.csproj

This is a joke right.  I mean how can you deploy when you explicitly broke the development environment without release notes or any documentation?

Kotylo, Did you create a class library (core) project to reference DLLs/legacy (.NET 4.x) projects. Or directly created packages out of legacy csproj? Do you mind uploading your sample project to Github? I'm having lot of trouble referencing legacy DLL/projects (.NET 4.x).  RC1 allowed us to directly reference legacy projects. I'm struggling to upgrade to RC2. I have a bunch of legacy projects (DLLs) to use in RC1.
I tried creating a class (Core) and old school Class library and referenced legacy projects and created Nuget packages and tried to install them in core project. Either way, it still complains "The dependency xxx could not be resolved"
Thanks much.

@inianp
This one:

Or directly created packages out of legacy csproj?
Just create package from your .NET 4.x .csproj, if you have sources, that is. For some reason it didn't work for me if I tried to create Nuget package directly from DLL. Maybe I did something wrong there.

I am in the same boat. I am targeting net451, and I cannot get existing .NET framework dlls referenced.
I attempted to use existing wrapped dlls from dnx451 from RC1. I changed their framework to net451. No dice.

I was able to get the references to stop complaining by using the dnx RC1 wrap project.json and changing the target to net451.
However, I still cannot use the assemblies. The using statements says i am missing a reference.

@skyflyer Why was this closed if this is still an issue?

@mikebm, I closed this issue because I was asking how to run on full framework with referenced assemblies and I managed to get it working, even though the tooling is ...
I also shared my project on how I did it. Even though the VS reports that it is an unknown reference, the build succeeds and the end result is working. For the visual studio, I've filed a bug from within visual studio.

I'm seeing the issue of VS not recognizing the referenced DLL, so lots of red squiglies :disappointed:
Is there a relevant issue to discuss this problem?

I just created an issue in the aspnet tooling repo. You can follow it here. Hopefully that was the correct place to put it.
https://github.com/aspnet/Tooling/issues/565

@ddotlic, I'm not sure what the correct issue for discussing this would be. In general it is a pretty sad state if you want to run on full .net framework.
@Eilon et al, a very concrete situation for my customers is that they'd like to use MVC 6 (ASP.NET Core MVC?) on full .NET framework (.NET 4.5.1, for instance), since they have 3rd party dependencies on .NET 4.5.1 (like IBM CTG, IBM DB2 etc. assemblies). So, we're left wondering when (if at all??) this scenario will be supported? Or is the only way forward to wrap the assemblies in project.json projects and export them as NuGet packages? If so, could you please point us in the direction of the previous dnu wrap command, which is not available anymore (with the new dotnet toolchain)?

@skyflyer Some of the devs on my client's team managed to work around this in some hyper-ugly way, but I'm not holding my breath until tooling reaches RTM... it's indeed a silly regression to have that Microsoft does not seem to recognize as a serious issue... sigh.

@skyflyer yes, ASP.NET Core is fully supported on .NET Framework on Windows. To add a reference to a "loose" assembly on disk, you will indeed need to manually "wrap" it into a NuGet package. Unfortunately the Preview 2 tooling release that just came out doesn't have a built-in "wrap" feature, so you need to do that step manually.

@Eilon That's not really a solution, the problem did not exist prior to RC2, it's a regression, hence many disappointed comments here and in the other similar items. If we did this, we'd still throw that work away as soon as tooling is repaired.
It would have been OK if there were a sample showing how to do this, but I'm not aware of one.

@ddotlic I agree it's a take-back and it's certainly not ideal. There are plans to fix this in updating tooling but there isn't anything available just yet.

@Eilon could you link where its scheduled in the tooling update as this issue still persists and we and many other companies cannot move to production when we cannot even add relevant dll libraries that are not in Nuget

@lilpug we just did a blog post a few days ago that includes the roadmap. Check it out here: https://blogs.msdn.microsoft.com/dotnet/2016/07/15/net-core-roadmap/
The switch to MSBuild will make this work:

.NET Core Tooling
• Support for .csproj/MSBuild project system

My "me, too" and my actions to date ...
For me, it is unclear as to whether this is/will be resolved in a timely fashion.
Abbreviated steps to reproduce:
(a) create ANY basic .NET Framework Library, example:
https://github.com/gerryLowry/TemperatureConversionNet452
(b) Create a Web Api solution based on .NET 4.5.2 and reference the basic .NET Framework Library from (a), above.
The above works and the ValuesController method GET api/values can be easily tweaked to use static methods from (a) above.
(c) Create a CORE Web Api solution and reference the basic .NET Framework Library from (a), above.
THIS FAILS with this Error:
A) .NET Core projects only support referencing .NET framework assemblies in this release.
B) To reference other assemblies, they need to be included in a NuGet package and reference that package.
COMMENT:
the assembly being referenced is a .NET framework assemblies; the error message appears to be incorrectly worded ... perhaps whoever coded the above error message intended CORE .NET framework assemblies ????
As presented, the statement A), above, is false.
Failed attempt # 1
added a NuGet package even though the .DLL is a .NET Framework 4.5.2 package.
see TemperatureConversion.<IP_ADDRESS>.nupkg
Failed attempt # 2
tweaked the json ... this may not be correct; however, it is roughly modelled on articles Miha Valencic a.k.a. skyflyer and others:
  "frameworks": {
      "net452": {
        "bin": {
        "assembly": "external\\TemperatureConversion666.dll",
        "pdb": "external\\TemperatureConversion666.pdb"
        }
      }
    },

Note that while lines for "assembly" and "pdb" are likely NOT correct,
even if they were, it is highly likely that the following errors
would occur nevertheless:
Error
NU1002
The dependency Microsoft.NETCore.App 1.0.0 does not support framework .NETFramework,Version=v4.5.2.

Error
NuGet Package Restore failed for one or more packages.
See details in the Output window.

MORE  INFORMATION
20116-07-15 Roadmap
1.0.1 (~August 2016) does not appear to address this issue (4682)
@Eilon  ... for me, it is unclear as to why you referenced the roadmap above.
@ ALL ...
can it be unequivocally stated that Microsoft.NETCore.App(1.0.0) applications will function with .NET Framework 4.5.2 libraries?
if yes, HOW to make that happen?
thnx/Gerry

@gerryLowry, I very much feel your pain. From what I understand (and I may be totally wrong here), there's the "compatibility matrix" that defines which type & version of a "package" is compatible with what. See the doc explaining it.
In my experience, it is not intended to consume full .NET assemblies in .NET Core apps, but rather the other way around (Microsoft, am I wrong?). Having seen the matrix, it "reads" that if a package targets netstandard1.2, it can be consumed in a .NET 4.5.2 application. Looking through some of the published assemblies by Microsoft (i.e. Microsoft.Extensions.Configuration.Json) I see that they're mostly targeting two platforms. .NETStandard1.3 and .NETFramework4.5.1 in this case.
The experience in using those assemblies tells me everything is not tested, as I've had some issues getting those kind of assemblies to work in a .NET 4.5.1 web application.
To add to confusion, the TFMs (target framework monikers) in Microsoft's packages use different monikers than those listed in the document1 (.NETFramework4.5.1 instead of net451, .NETStandard1.3 instead of netstandard1.3, etc) or document2.
And, to finally address your question:

can it be unequivocally stated that Microsoft.NETCore.App(1.0.0) applications will function with .NET Framework 4.5.2 libraries?

I don't think so, since .NET 4.5.2 (the base class library) has more (and some different) functionality than .NET Core 1.0. I don't know exactly what's missing from .NET Core (but it would be nice if this was documented somewhere). Some references worth reading. I guess that netstandard-* is the answer to this confusion...

@skyflyer
From the ASP.NET Core 1.0 Schedule and Roadmap:
"The November and May release candidates (RC1 & RC2) are supported and production-ready cross-platform releases."
production-ready
perhaps "somewhat production ready" would be more appropriate.
Here is a very trival 4.5.2 class library:  TemperatureConversionNet452
using System;

namespace TemperatureConversion
{
    public class CelsiusFahrenheit
    {
        public static Double Celsius(Double fahrenheit)
        {
            return (fahrenheit - 32d) / 1.8d;
        }

        public static Double Fahrenheit(Double celsius)
        {
            return (celsius * 1.8d) + 32d;
        }
    }
}

There is nothing in the above code to prevent it from working in all versions including Core.

"Does your dog bite?"
.NET Standard Library
"Each .NET runtime version advertises the highest .NET Standard version it supports, a statement that means it also supports previous versions."
"It's not my dog."
The table ".NET Platforms Support" at .NET Standard Library implies that .NET Core, a.k.a. netcoreapp will never be able to reference .NET Standard, a.k.a. netstandard.
the real problem / truth in advertising
Given the number of globally gobsmacked complainants, imho it's fair to suggest that a disclaimer be presented when one is choosing, for example, which version of Web API to use.

Miha, if you revisit the table, .NET Standard (netstandard), .NET Core (netcoreapp), and .NET Framework (net) are all on separate rows; imho, wishful thinking on my part, they should be able to reference one another.
.NET Core Roadmap, version 2016-07-15
the following is open to interpretation:
Q4 2016 / Q1 2017
This will be the first minor update, mainly focused on replacing .xproj/project.json
with .csproj/MSBuild.

Project format update should be automatic. Just opening a 1.0 project
will update it to the new project format. There will also be new functionality
and improvements in the runtime and libraries.

As context, .NET Core 1.0 included a preview version of the .NET Core Tools,
referred to as “Preview 2”. The tools were “preview” primarily because
we knew that we would change the tools experience post 1.0.
.NET Core and the .NET Core Tools will both be “RTM quality” or “stable” with this release.

.NET Core Tooling
Support for .csproj/MSBuild project system
dotnet restore improvements to not restore packages that are part of .NET Core
New commands for managing the frameworks on the machine
dotnet publish will publish only required dependencies, for optimal distribution size

BOTTOM LINE
WEB-facing applications and DESKTOP-facing applications share many Enterprise custom code bases; it's the customized code that can give one company a competitive advantage over another company.
FWIW, this needs to be fixed, soon; if that does not happen, it may cost Microsoft loss of customers; already it has cost Microsoft loss of trust.

The support statements were true when they were made and continue to be true. Running .NET Framework assemblies on .NET Core is not supported. That doesn't mean it won't work. But it's definitely not supported. And there are countless cases where it in fact won't work - e.g. try using System.Web or WCF. It turns out that if the API surface used by the assembly is sufficiently limited and doesn't conflict with anything in .NET Core, it'll work. It's ultimately just a plain old .NET DLL that contains MSIL, so as long as it has the right references, it'll generally work.
The only supported ways to implement this scenario is to either:

Cross-compile the code for each target framework, and thus have one assembly per target framework.
Build one assembly that targets one of the netstandard targets that support all the desired .NET implementations, e.g. netstandard1.2.

Admittedly, I have only just started looking into moving from RC1 (and the only reason we're doing it now is that Azure now only supports RTM applications) but we're running into trouble at almost every turn.  Third party libraries that we are using have not been moved to Core versions and bits of the framework haven't been ported across (System.Data).
If running .Net framework assemblies on .Net Core is not supported how do we move forward?

If running .Net framework assemblies on .Net Core is not supported how do we move forward?

You can run ASP.NET Core on .NET Framework.

Hi David, thanks for the response, how do we do this?

@redowl3 have your project target net451 (or similar) instead of netcoreapp1.0 in the frameworks section of project.json. That will use .NET 4.5.1 (or similar), which means that you can use just about any .NET 4.5.1-compatible NuGet package. SendGrid should work just fine (I haven't tried it, but I can't imagine why it wouldn't work).

Thanks Eilon.  When we target net451 does that mean all referenced projects need to target net451 instead of netcoreapp1.0?
Is this how MSFT envisaged support for working with non core assemblies working?

We're having real trouble in finding out how to reference multiple frameworks to update our working RC1 solution to RTM (which has been forced on us by the decision by MSFT not to support these versions on Azure).  The solution suggested by Eilon has helped fix some issues but created others.

I landed here trying to google if there is a way to target multiple frameworks in project.json and still do a nuget pack without using a nuspec, thanks google!
@redowl3 @gerryLowry
It saddens me to see everyone complaining about project.json and the dotnet CLI departure from MSBuild with expectations that one can actually move without changing stuff ... Using datasets in 2016, is doing it wrong, it's code that should have been refactored ages ago.
project.json and the dotnet CLI is a breeze of fresh air in the Microsoft space, it is a very clever attempt to bring the stack closer to what the rest of the world is doing in the node.js stack and the rest of the open source stack. Working with these two is a very nice development experience, despite all the current issues with packing and immature tooling around them.

Azure doesn't force anyone to do anything! If I'm using Azure App Service without deploying my own ASE there's not much I can do to control my stuff. However if I want to do my own thing and have a high level of control I'm on other PaaS offerings with other level of control: Docker, App Service Fabric, Cloud Services, etc. I think there's still people maintaining Docker images with the preview versions of DNX :)

Hi djfr, thanks for joining in the discusssion.
In our particular circumstances we do need to use DataSets as we are using a 3rd party library that converts Excel to DataSets.  Like a significant amount of 3rd party components this has not been ported to Core so we need to target multiple frameworks, which in our opinion has been a major pain, mainly due to the complexity of trying to understand multiple frameworks, dependencies, includes etc...  We totally understand the direction MSFT are trying to move to and that there would be some pain points along the way.
And your right Azure does not force anyone to do anything(!) but again in our circumstances we had an ASP.NET RC1 application running very nicely in the cloud but since this announcement (https://blogs.msdn.microsoft.com/waws/2016/06/14/supporting-asp-net-5-core-rc1-on-azure-app-service/) if we want to continue hosting our application on Azure we are 'forced' to upgrade to Core.

Hello All,
I haven't read all the discussion. I start working with .net core framework (not the real core, but ASP.NET Core Web Application(.net framework)) few weeks ago, I am having a problem with referencing the DLL. I can add the NuGet package that I created myself, but the intelligence would recognize the namespace.
If I add reference the project directly with source code in the same solution, then everything works fine. In this way, I have to have the source code for the projects that I am willing to reference .
I assume this is a bug, but correct me if the core framework is designed this way.

@benzhi2011 I haven't read all your comment, but basically no actual support for "old" .net 4.5.2. Even Azure will only support Core.
As a workaround, you can have intellisense by adding the dll through Nuget Package manager. So you can create your own package from solution, then setup .net core project to use the Nuget.config file :
<?xml version="1.0" encoding="utf-8"?>
<configuration>
  <packageSources>
    <add key="MyProjectSource" value="nuget\packages" />
  </packageSources>
</configuration>

@kotylo Thank you for  your workaround, it works perfect.

We are closing this issue because no further action is planned for this issue. If you still have any issues or questions, please log a new issue with any additional details that you have.


Error when pulling hyperionorg/hyperion-ci

When running the command for compilation in a docker container pulling the image hyperionorg/hyperion-ci of dockerhub fails. Error message is Error response from daemon: manifest for hyperionorg/hyperion-ci:latest not found
There is a similar case described in the forum, but without a solution. http://wiki.hyperion-project.org/threads/installing-hyperion-ng.3491/page-2#post-14337

It is a typo in this File on this Line
Please change to hyperion-project/hyperion-ci

This is one of my first interactions with a open source project. Should I clone this project, change it and make a pull request?

Fork -> Change -> Pull Request


Demo on group size and memory in cooperative games

http://www.nature.com/articles/srep26889

This issue was moved to Dallinger/Dallinger#61


DEV: Add PR templates for BUG and ENH

What's new

In a new directory .github/PULL_REQUEST_TEMPLATE I added two templates: bug_PR.md and enhancement_PR.md
The proposed templates make it easyer to review and test proposed changes.

@VinzentRisch

Why only two templates and not one for all seven possible PR types that are listed on confluence?

Because I was lazy 😅. Also, I wanted to keep the review short while still illustrating that it can be done for any PR type.

@Sann5
Ah yes that makes sense. :)


mocha cann't  pass the bootstrap.js

D:\testWork\SpookyJS-master>mocha ./tests/test/bootstrap.js
the PhantomJS bootstrap script
1) hooks phantom.onError to emit an error event and exit non-zero
2) crashes if passed an unknown transport
0 passing (21ms)
2 failing

the PhantomJS bootstrap script hooks phantom.onError to emit an error event and exit non-zero:
Uncaught Error: spawn casperjs.bat ENOENT
at exports._errnoException (util.js:1022:11)
at Process.ChildProcess._handle.onexit (internal/child_process.js:193:32)
at onErrorNT (internal/child_process.js:359:16)
at _combinedTickCallback (internal/process/next_tick.js:74:11)
at process._tickCallback (internal/process/next_tick.js:98:9)

the PhantomJS bootstrap script crashes if passed an unknown transport:
Uncaught Error: spawn casperjs.bat ENOENT
at exports._errnoException (util.js:1022:11)
at Process.ChildProcess._handle.onexit (internal/child_process.js:193:32)
at onErrorNT (internal/child_process.js:359:16)
at _combinedTickCallback (internal/process/next_tick.js:74:11)
at process._tickCallback (internal/process/next_tick.js:98:9)

i have run the program in the centos 7


DS-3240: comm/coll admins misses some functions and a propper navbar.

https://jira.duraspace.org/browse/DS-3240
To test this:

Create a community/collection and a community/collection admin.
Create and publish/archive an item.
Login as community/collection admin, open the item and edit it. The admin navbar should appear and contain fields like "General Settings", that are protected from being used by community/collection admins.
Make the item private or withdraw it.
Choose from the admin navbar (still as community/collection admin) the button "content/withdrawn items" or "content/private items".

 Also you should be able to see private/withdrawn item as community/collection admin.

rebased.

@lap82 @abollini as committers that also uses JSPUI: do you think this PR can still be reviewed for DSpace 6 RC3? I know it is a larger PR but most of the changes are simple changes in JSPs and the code is well tested.

Hi Pascal,
unfortunately I was unable to review this pr before. It looks fine for me after code review.
I will check in the tomorrow IRC meeting if there is agreement to include this PR in the 6.0 final. If so, I will perform a test to confirm that the PR works as expected.

Hi Pascal,
unfortunately I was unable to review this pr before. It looks fine for me after code review.
I will check in the tomorrow IRC meeting if there is agreement to include this PR in the 6.0 final. If so, I will perform a test to confirm that the PR works as expected.

Tested, it works +1.
Community and collection administrators are able to manage withdrawn and private items only for their communities/collections.
As agreed in the last IRC meeting @lap82 will make an independent test tomorrow in the (Italian) morning and merge if succeed.

+1 it works well!


feat: adding svg example

Description
Adds an example for flame_svg on our examples collection.
This example will be used in a future PR to test the svg perfomance.
https://user-images.githubusercontent.com/835641/152365182-ac612af8-94ea-49ae-b42f-193f9c12aa1a.mov
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the
relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
[x] I have read the Contributor Guide and followed the process outlined for submitting PRs.
[ ] I have updated/added tests for ALL new/updated/fixed functionality.
[ ] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
[ ] I have updated/added relevant examples in examples.

Breaking Change
Does your PR require Flame users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change. (Indicate it in the Conventional Commit prefix with a !,
e.g. feat!:, fix!:).
[x] No, this is not a breaking change.

Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database.
Indicate which of these issues are resolved or fixed by this PR, i.e. Fixes #xxxx

Lgtm! This might not pass the analyzer though since we don't have the melos action in here yet.

Should I add it on this PR?

Lgtm! This might not pass the analyzer though since we don't have the melos action in here yet.

Should I add it on this PR?

You can try if you want, I haven't tried it yet, so you might run into some issues. :grimacing:


Fix: Broker fails throws OOME with conf-quickstart

when running the the packaged conf-quickstart druid broker fails to
start and throws OOME.
increasing the direct memory to get around this.

faced this on 0.10.0-rc2 also, this needs to be backported to 0.10.0 also.

👍  plz backport @nishantmonu51

backported in https://github.com/druid-io/druid/pull/4130


fix etcd error

fix etcd dep error https://github.com/micro/go-config/issues/105, this is another solution. Please refer to https://github.com/etcd-io/etcd/issues/10398#issuecomment-469439257.
add dialTimeout option for etcd client, program will hang there if the endpoints are not reachable without setting this option.

Looks reasonable

We need to move this plugin out to go-plugins. We're trying to remove etcd usage inside go-micro itself for now since we're not personally using it at the company and without that use we can't ultimately support. I'll merge but look to see the entire thing move to go-plugins.

Yes, i think that moving to go-plugins is better now.


ribulose-phosphate 3-epimerase activity add synonym

ribulose-phosphate 3-epimerase activity
Add exact? synonym
pentose phosphate epimerase (PPE)
PMID:9872416

There already is a synonym pentose-5-phosphate 3-epimerase activity. There are two pentose phospate epmerases PMID: 4560420 "On the mechanism of the pentose phosphate epimerases".

Hi @raymond91125 - what do you mean, can "pentose phosphate epimerase (PPE)" be added as a synonym anyway?
Also, are you  saying there are 2 activities? you are referring to <IP_ADDRESS>   L-ribulose-5-phosphate 3-epimerase maybe?
We should also change the term label of GO:0004750 to indicate it acts on the D- form, and to be consistent with GO:0034015 (L-ribulose-5-phosphate 3-epimerase activity).
Thanks, Pascale

pgaudet
Does the synonym 'pentose phosphate epimerase (PPE)' cove both the D and the L substrates? If that's the case, I would make it a BROAD synonym.
raymond91125
In the context of PMID:9872416, I believe it's only the D- form.
ValWood
I don't know. This was a really old paper, and didn't mention different isomers of
ribulose-5-phosphate 3-epimerase.
Note, should these comments move to the ticket?
This is the pull request.
Peter might know, he is very knowledgeable about glucose metabolism in general
deustp01
Sorry, no clue here.


[CSL-959] Bump time-warp-nt

...with added withSocketsDo in NTP

PR is WIP till that commit from time-warp gets into time-warp-nt-0.1.1

I believe the MonadBaseControl instances are no longer necessary after the Ether refactoring.

Okay, I'll remove them when create PR for master


have moved these tests to github actions

Finish issue #1444
We have successfully moved the existing travis tests to github actions. This PR removes the double testing.
Minor note: Github actions is testing on the latest 1.13.10 golang and Ubuntu 18.04.
Signed-off-by: Mike Brown<EMAIL_ADDRESS>

LGTM


Add keyboard accelerators to file change & window state dialogs

Fixes #2928

@damieng I don't see these changes on master, nor on recent releases, aren't they supposed to be merged ?
Thanks

They are definitely on master https://github.com/atom/atom/blob/master/src/atom-environment.coffee#L941and https://github.com/atom/atom/blob/master/src/pane.coffee#L668
I'm also seeing then in use - you do have to press Alt to see the accelerator - that's just the way Windows 10 presents them now.  Are you on Linux or macOS?

Hi, ok sorry I mean't relases e.g. latest stable https://github.com/atom/atom/archive/v1.19.3.tar.gz. Hope they will be included in 1.20.0 ?
I'm on Linux (Ubuntu 17.04), will try to patch manually then.

It is in the 1.20 beta right now so it will be included in 1.20.0

This does not seem to work on macOS. I have tried all possible accelerator keys but no success (I am on macOS Ventura (13.0.1) and Atom 1.60.)


name 'get_device' is not defined error since update

Hey, been using this for months with no problems..
Here's the script that I have been using for months.
`alias: Quick Wash
sequence:

data:
parameters: "{'spinSpeed':'1000'}"
program: iot_wash_rapid_14
action: hon.start_program
target:
device_id: 3a0ba196c853689da8fa2e2b2750d424
description: ""
icon: mdi:washing-machine`

After the update I get this error on running the script..
name 'get_device' is not defined

Same for me:
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 525, in _async_step
await getattr(self, handler)()
File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 763, in _async_call_service_step
response_data = await self._async_run_long_action(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 726, in _async_run_long_action
return await long_task
^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/core.py", line 2761, in async_call
response_data = await coro
^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/core.py", line 2804, in _execute_service
return await target(service_call)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/hon/init.py", line 362, in handle_start_program
device      = get_device(hass, device_id)
^^^^^^^^^^
NameError: name 'get_device' is not defined. Did you mean: 'get_device_id'?

Really sorry !  I forgot to test one function.
I just update it quickly. Could you please test ?

Hi,
bug with device_id is ok but something else appended:
Enregistreur: homeassistant.components.websocket_api.http.connection
Source: components/websocket_api/commands.py:245
intégration: Home Assistant WebSocket API (documentation, problèmes)
S'est produit pour la première fois: 16:15:44 (1 occurrences)
Dernier enregistrement: 16:15:44
[281472479212400] Unexpected exception
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 245, in handle_call_service
response = await hass.services.async_call(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/core.py", line 2761, in async_call
response_data = await coro
^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/core.py", line 2804, in _execute_service
return await target(service_call)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/hon/init.py", line 363, in handle_start_program
command     = device.commands.get("startProgram")
^^^^^^^^^^^^^^^
AttributeError: 'HonBaseCoordinator' object has no attribute 'commands'

I just update again ...  sorry

After updated to the last version, it seems to be ok.
Thank you for the job and the support for HON.
I use it daily so thank you again.

My pleasure :)

All working on the washing machine here, thank you very much.


feat(source-scan): git checks, git metadata

Summary of changes:

git dirty check copied to cargo near build flow, it produces a warning, unlike the error in cargo near deploy flow
added source_code_git_url field to reproducible build metadata
git pushed to remote check logic reworked
repo is opened and HEAD is determined
relative path of contract within repo is determined
CARGO_NEAR_SOURCE_CODE_SNAPSHOT (adapted from cargo::core::SourceId) and CARGO_NEAR_CONTRACT_PATH are exported in container
[x] github, package in root of a repo: https://github.com/dj8yfo/sample_no_workspace/tree/05067bc12b8a8d811883b6b12fc87ba9bce9b103
[x] github, package in subpath in repo : https://github.com/dj8yfo/sample_workspace/tree/
[x] github, package in submodule in repo : https://github.com/dj8yfo/sample_workspace_with_submodules/tree/
[x] bitbucket, package in root of a repo: https://bitbucket.org/dj8yfomule/scratch_check_git/src/master/

near contract call-function as-read-only sample-crate.testnet contract_source_metadata json-args {} network-config testnet now

=>
{
  "build_info": {
    "build_command": [
      "cargo",
      "near",
      "build",
      "--no-release",
      "--no-doc"
    ],
    "build_environment": "dj8yfo/sourcescan:0.x.x-dev-cargo-near-build-cmd-repo@sha256:6d4f090a8bb606bbddf396809d31b6c96a45d0bdd3e93d9e4bf538ff463246e9",
    "contract_path": null,
    "source_code_snapshot": "git+https://github.com/dj8yfo/sample_no_workspace.git?rev=05067bc12b8a8d811883b6b12fc87ba9bce9b103"
  },
  "link": "https://github.com/dj8yfo/sample_no_workspace/tree/05067bc12b8a8d811883b6b12fc87ba9bce9b103",
  "standards": [
    {
      "standard": "nep330",
      "version": "1.2.0"
    }
  ],
  "version": "0.7.7"
}


Check every key (regardless of compute_from) for discouraged condition

Fixes https://github.com/web-platform-dx/web-features/issues/1894. If compute_from is set, then explicitly check every key's deprecated value.
Right now this is not great—it's quite slow. I need to do some sort of refactoring here to not run computeBaseline on every key twice. It's too late in the day for me to think that through.

OK, then if we're going down this route we have a little bit of work to do. These are the keys currently failing the test:

[ ] api.FontFaceSet.FontFaceSet
[ ] api.CanMakePaymentEvent.methodData
[ ] api.CanMakePaymentEvent.modifiers
[ ] api.CanMakePaymentEvent.paymentRequestOrigin
[ ] api.CanMakePaymentEvent.topOrigin
[ ] api.PaymentManager.instruments
[ ] api.PaymentRequestEvent.instrumentKey
[ ] api.PaymentRequest.merchantvalidation_event
[ ] api.PaymentRequest.shippingAddress
[ ] api.PaymentRequest.shippingOption
[ ] api.PaymentRequest.shippingType
[ ] api.PaymentRequest.shippingaddresschange_event
[ ] api.PaymentRequest.shippingoptionchange_event
[ ] css.at-rules.media.prefers-color-scheme.no-preference
[ ] api.SVGAnimateColorElement

@vwallen Can you open PRs for the remaining keys in this comment?

@ddbeck The blocking keys have been removed, and it looks like none have been added in the interim.

Great. Let's merge this now.


Fixed ordering in adding pending picks to PF

In the vein of https://github.com/grpc/grpc/pull/15947, attempt to address https://github.com/grpc/grpc/issues/15933

[trickle] No significant performance differences

LGTM.  Can we add a test, similar to what we added for RR?

Yes. I'm still waiting to see if this fixes the reported nodejs issue.
On Thu, Jul 19, 2018, 08:35 Mark D. Roth<EMAIL_ADDRESS>wrote:

LGTM. Can we add a test, similar to what we added for RR?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/grpc/grpc/pull/16054#issuecomment-406319752, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAHVmVLm4bOnvbriPu0R5bAbeLUJ2BUJks5uIKdXgaJpZM4VVhi3
.

@dgquintas, thanks for waiting while we verified this. Unfortunately it looks like this does not fix the issue. I added some more details in a comment on the original issue that will hopefully shed some light on the problem.

Even if it doesn't fix the original issue, there's pretty clearly still a bug here, and this PR is the right fix.  We should add a test similar to what we added in the RR version and get this merged.

Test added. PTAL.

****************************************************************

libgrpc.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++

 -------------- SHRINK --------------
  [ = ]       0 [None]      -8  -0.0%

  [ = ]       0 TOTAL       -8  -0.0%

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,952,718      Total (<)      1,952,734

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,663,575      Total (<)     10,663,579

 No significant differences in binary sizes

[microbenchmarks] No significant performance differences

Issues: #16230 #16003


Using methods within components should check for enabled or not?

I have implemented some consent support, storing the consent value in the localStore.
In my main.js I'm checking for the value of the localStore consent value, and based on that I either initiate a new consent dialog (localStore value === null) using the bootstrapping methods when consent is given, when localStore value is true I'll load the scripts and initiate VueGtag as expected, when consent is not given, I'll set the VueGtag enabled to false, and bootstrap/disablescriptLoad to true. And it works almost expected - no loading of google stuff when consent is not given, and no loading of google files before consent is given.
However; when I use this.$gtag methods in my different components for reporting different usage, I get the following errors when GTAG have enabled: false:
TypeError: can't access property "apply", window[globalObjectName] is undefined
    query vue-gtag.esm.js:140
    event vue-gtag.esm.js:176
    screenview vue-gtag.esm.js:230

I invoke the following command from within different components:
 this.$gtag.screenview({
        app_name: 'foo',
        screen_name: 'bar',
      })

I think it would be nice if the vue-gtag library checked the "enabled" value before any report methods was invoked?
It would be more "natural" if the enabled check was managed within the vue-gtag library :-)
Anyway - the tools work as expected and are a huge pleasure to work with. Keep up the great work.
Cheers
Erlend Øverby

could you create a reproduction of this issue in a very simple Vue app? thanks a lot and sorry for the huge delay in coming back to you 🙏

Just chiming in here to say that I'm experiencing the same issues as Erlend.
I'm using it in a Nuxt app, which is giving me some headaches.
The nuxt-google-analytics and nuxt-facebook-pixel-module libraries handle this quite gracefully, for comparison.
(And I agree with Erlend: Anyway - the tools work as expected and are a huge pleasure to work with. Keep up the great work.)

:tada: This issue has been resolved in version 1.16.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


.travis.yml: publish gh releases only once

Was trying to run 'deploy' step after every vector in the matrix.
Now runs deploy step after 'make test-unit' only, so we get basic
checks and quick binary release.

LGTM!
No errors, no warnings. :shipit:

  Generated by :no_entry_sign: Danger

Codecov Report

Merging #802 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #802   +/-   ##
=======================================
  Coverage   52.67%   52.67%
=======================================
  Files         277      277
  Lines       16474    16474
=======================================
  Hits         8677     8677
  Misses       7102     7102
  Partials      695      695

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c4089d...c589e23. Read the comment docs.

don't know enough about travis config to see how this will change the publishing of the binary. Will mention @nyarly in that case and see if he has an opinion on it.

@samsalisbury I think all the things now go into the jobs: key, so that the stages can be sequenced reliably. No docs at all about what the order of non-staged work is...

@nyarly many of the documentation examples for jobs/stages use the top-level config followed by the jobs: spec, and run the top-level config first. The top-level stage gets the automatic name "Test", and we can deduce from this documentation that that Test stage is run first by default: https://docs.travis-ci.com/user/build-stages/#specifying-stage-order-and-conditions:

You can specify the order for stages in the section stages: [code example removed for brevity]
This is mostly useful in order to “prepend” a stage to the test stage that jobs resulting from the matrix expansion will be assigned to.

Since Travis documentation is mostly example based and light on explicit specifications, taking the above quote along with empirical evidence seems like a reasonable approach.
We can see empirically that this updated .travis.yml works as expected consistently on this branch, and on all the other open PRs that include these changes. See https://docs.travis-ci.com/user/build-stages/matrix-expansion/ for further example of documentation that shows the default top-level 'test' stage being run first. I don't see explicit mention that this is the case (travis docs are low on precise specs), but since it follows many of the examples in Travis, it seems like a reasonable change, even if it could potentially be improved upon in a future pull request. (We have already discussed improvements like grouping fast tests together in their own stage to fail the build quicker if those tests fail. During that change would be a good time to make the .travis.yml stages config more explicit.)
Since this has been sitting around for a while, and other work touching .travis.yml now sits on top of it, updating this branch prior to merging with master means resolving merge conflicts for little gain (most likely zero behavioural change). Therefore I would rather open a follow-up PR to make stage order more explicit rather than have to deal with these conflicts.

Further delving into the docs suggests the test matrix has to be defined at top-level, so the best we might ultimately be able to achieve is explicit ordering of implicitly named "test" stage; see https://docs.travis-ci.com/user/build-stages/#build-stages-and-build-matrix-expansion


RNVI not working with React Native for Web without EXPO and giving error on NativeRNVectorIcons.js

[✅] Review the documentation: https://github.com/oblador/react-native-vector-icons
[✅] Search for existing issues (including closed issues): https://github.com/oblador/react-native-vector-icons/issues

Environment
"react": "18.3.1",
"react-dom": "^18.3.1",
"react-native": "0.75.2",
"react-native-paper": "^5.12.5",
"react-native-vector-icons": "^10.1.0",
"react-native-web": "^0.19.12"

Description

I have clearly followed https://github.com/oblador/react-native-vector-icons?tab=readme-ov-file#web-setup but stil I am not able to see Icons on web
Screenshot for index.js

and when ever I am commenting line no. 11 in the above screenshot my application is going blank to white screen

@shakeelkoper this is likely a webpack issue.
webpack needs to be configured to prefer .web.js extensions.
It should be pulling in NativeRNVectorIcons.web.js and not NativeRNVectorIcons.js
Something like this should do the trick
resolve: {
  extensions: [ '.web.js', '.js' ]
}


Have custom trackers work with the API

Implements the logic needed for custom trackers, so long as they subclass GeneralTracker and tests
closes https://github.com/huggingface/accelerate/issues/303

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Adding option to include userid and namespace

From the latest updates in our SDK, users now need to provide:

userid (ZG email) to the kfp.Client() constructor
namespace to the create_run_from_pipeline_func

Looks good but doesn't that rely on the branch with these fixes (see here)? How are you installing that version of kfp?

@alexlatchford, here are the details on that installation:
git clone https://github.com/alexlatchford/pipelines
cd pipelines; git checkout alexla/AIP-1676
cd sdk/python
python3 setup.py build_py

Once you do this, you can use kfp as usual with:
import kfp
client = kfp.Client(userid="[your_ZG_email")
run_info = client.get_run("[your_run_ID")
client.create_run_from_pipeline_func(..., namespace="[your_namespace]")
print(run_info)

@alexlatchford, here are the details on that installation:
...

Makes sense, thanks for sharing. Do we have this included in the repo anywhere? (ie. are we installing kfp from this branch instead of from PyPI now?)

I included this information on our workflow channel on Slack, but it's not on a readme anywhere.

I'd say we don't even want this in the README we likely want this in the setup.py: https://github.com/zillow/metaflow/blob/bug/add_namespace_to_kfp_run/setup.py#L23
Looks like it might be tricky without installing pip as it looks like Metaflow uses the old school approach of just a setup.py and setuptools but potentially we can leverage the dependency_links functionality if needed. This post outlines various scenarios for installing a python package from a git repo: https://stackoverflow.com/a/23865528/724251

Do these new parameter require an update to the README.md https://github.com/zillow/metaflow/tree/feature/kfp/metaflow/plugins/kfp ?

Good catch @talebzeghmi , will update the README.

@talebzeghmi updated the readme. Ready for review.

@talebzeghmi can you do a final check and approve this PR? 😄

Looks good but doesn't that rely on the branch with these fixes (see here)? How are you installing that version of kfp?

Resolved, add the installation of that version of KFP in the README.

I'd say we don't even want this in the README we likely want this in the setup.py: https://github.com/zillow/metaflow/blob/bug/add_namespace_to_kfp_run/setup.py#L23
Looks like it might be tricky without installing pip as it looks like Metaflow uses the old school approach of just a setup.py and setuptools but potentially we can leverage the dependency_links functionality if needed. This post outlines various scenarios for installing a python package from a git repo: https://stackoverflow.com/a/23865528/724251

@alexlatchford Taleb gave a great way to install this using pip, so I included it in the README instead. Let me know if you want it in setup.py still, but I think it's cleaner to use the pip method and avoid setup.py for now.