Resolving conflict in issue #582

TODO

[x] Use cargo fmt
[x] Add necessary tests
[x] Add changelog entry

Hi @Gasu16, thanks for the contribution, but it seems the -d is not working with -a perfectly, there is something that has to do to align with the GNU ls.
your implementation:
$ cargo run -- -a -d
    Finished dev [unoptimized + debuginfo] target(s) in 0.06s
     Running `target/debug/lsd -a -d`
 .   ..   .git   .github   .gitignore   .release.toml   build.rs   Cargo.lock   Cargo.toml   CHANGELOG.md   ci   CODEOWNERS   doc   LICENSE   README.md   src   target   tests

GNU ls:
$ \ls -a -d
.

without -a:
$ \ls -d
.

$ lsd -d
 .

show directories:
$ \ls -d -a */
ci/     doc/    src/    target/ tests/

$ cargo run -- -d -a */
    Finished dev [unoptimized + debuginfo] target(s) in 0.27s
     Running `target/debug/lsd -d -a ci/ doc/ src/ target/ tests/`

ci/:
 .   ..   before_deploy.bash   before_install.bash   script.bash

doc/:
 .   ..   lsd.md

src/:
 .   ..   app.rs   color   color.rs   config_file.rs   core.rs   display.rs   flags   flags.rs   icon.rs   main.rs   meta   sort.rs

target/:
 .   ..   .rustc_info.json   CACHEDIR.TAG   debug

tests/:
 .   ..   integration.rs

Hi @Gasu16, thanks for the contribution, but it seems the -d is not working with -a perfectly, there is something that has to do to align with the GNU ls.
your implementation:
$ cargo run -- -a -d
    Finished dev [unoptimized + debuginfo] target(s) in 0.06s
     Running `target/debug/lsd -a -d`
 .   ..   .git   .github   .gitignore   .release.toml   build.rs   Cargo.lock   Cargo.toml   CHANGELOG.md   ci   CODEOWNERS   doc   LICENSE   README.md   src   target   tests

GNU ls:
$ \ls -a -d
.

without -a:
$ \ls -d
.

$ lsd -d
 .

show directories:
$ \ls -d -a */
ci/     doc/    src/    target/ tests/

$ cargo run -- -d -a */
    Finished dev [unoptimized + debuginfo] target(s) in 0.27s
     Running `target/debug/lsd -d -a ci/ doc/ src/ target/ tests/`

ci/:
 .   ..   before_deploy.bash   before_install.bash   script.bash

doc/:
 .   ..   lsd.md

src/:
 .   ..   app.rs   color   color.rs   config_file.rs   core.rs   display.rs   flags   flags.rs   icon.rs   main.rs   meta   sort.rs

target/:
 .   ..   .rustc_info.json   CACHEDIR.TAG   debug

tests/:
 .   ..   integration.rs

@zwpaper thank you for pointing that, gonna send a new PR soon

Ok so I corrected, I did some tests and it seems the output is aligned with GNU ls, here I show some examples:
My implementation
$ cargo run -- -a -d
    Finished dev [unoptimized + debuginfo] target(s) in 0.03s
     Running `target/debug/lsd -a -d`
 .

$ lsd -a -d
 .

GNU ls output
$ ls -a -d
.

Show directories
$ cargo run -- -a -d */
    Finished dev [unoptimized + debuginfo] target(s) in 0.03s
     Running `target/debug/lsd -a -d ci/ doc/ src/ target/ tests/`
 ci/   doc/   src/   target/   tests/

$ ls -a -d */
ci/  doc/  src/  target/  tests/

With -ahl option
$ cargo run -- -ahl --color -d */
    Finished dev [unoptimized + debuginfo] target(s) in 0.03s
     Running `target/debug/lsd -ahl --color -d ci/ doc/ src/ target/ tests/`
drwxr-xr-x matt matt 4.0 KB Mon Nov 22 19:07:14 2021  ci/
drwxr-xr-x matt matt 4.0 KB Mon Nov 22 19:07:14 2021  doc/
drwxr-xr-x matt matt 4.0 KB Mon Nov 22 19:07:14 2021  src/
drwxr-xr-x matt matt 4.0 KB Tue Nov 23 14:24:56 2021  target/
drwxr-xr-x matt matt 4.0 KB Tue Nov 23 15:57:53 2021  tests/

$ ls -ahl --color -d */
drwxr-xr-x 2 matt matt 4.0K Nov 22 19:07 ci/
drwxr-xr-x 2 matt matt 4.0K Nov 22 19:07 doc/
drwxr-xr-x 5 matt matt 4.0K Nov 22 19:07 src/
drwxr-xr-x 4 matt matt 4.0K Nov 23 14:24 target/
drwxr-xr-x 2 matt matt 4.0K Nov 23 15:57 tests/

@zwpaper Hi, I saw 5 checks out of 14 failed, what should I do to fix them?

Codecov Report

Merging #587 (751e7b2) into master (f81c3b1) will increase coverage by 0.00%.
The diff coverage is 90.00%.

@@           Coverage Diff           @@
##           master     #587   +/-   ##
=======================================
  Coverage   85.86%   85.87%
=======================================
  Files          37       37
  Lines        3842     3851    +9
=======================================
+ Hits         3299     3307    +8
- Misses        543      544    +1

Impacted Files
Coverage Δ

src/app.rs
72.58% <ø> (ø)

src/flags/display.rs
98.00% <66.66%> (-2.00%)
:arrow_down:

tests/integration.rs
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f81c3b1...751e7b2. Read the comment docs.

@Gasu16 Thanks for contributing!


React/RCTConvert.h file not found : Need to improve plugin for works with last react-native version

Same error for me with same version of react-native.
This package is awesome but not works with last version of react-native.
Need to improve this package for works with last version please !
Thanks
Originally posted by @WestFR in https://github.com/react-native-ar/react-native-arkit/issues/201#issuecomment-515003850

Try code-matt's fix here: https://github.com/react-native-ar/react-native-arkit/pull/208
And see my comment about modifying the Podfile: https://github.com/react-native-ar/react-native-arkit/pull/208#issuecomment-592971819


[UX issue] Save button not accessible after typing

Hi @CrazyMarvin,
When you click the field to type in an attempt to create a new label or task for a list, the keyboard covers up the save button and the return button only creates a new paragraph.

Oh, you're right. 😅
Are you available to open a PR which fixes this?

I'm not a java developer but if you explain what needs to be fixed I could figure it out

Thanks @LuluNwenyi  for you input, Please once try your mobile default back button to quit the keyboard and then save, please try this and update me with the results please.

Hi @arafaatqureshi, I apologize for the late response. It's still the same.

Is it working fine now, @LuluNwenyi?


Enable distributed processing on multiple GPUs.

This allows to run training on multiple GPUs, overcoming the memory limits of a single GPU.

Great. Thank you.


Well-known format descriptions should support formatting Date.

None of the three well-known format descriptions provided here support formatting Date instances:
use time::format_description::well_known::*;

let today = time::OffsetDateTime::now_utc().date();
dbg!(today.format(&Iso8601::DEFAULT));
dbg!(today.format(&Rfc2822));
dbg!(today.format(&Rfc3339));

[test.rs:14] today.format(&Iso8601::DEFAULT) = Err(
    InsufficientTypeInformation,
)
[test.rs:15] today.format(&Rfc2822) = Err(
    InsufficientTypeInformation,
)
[test.rs:16] today.format(&Rfc3339) = Err(
    InsufficientTypeInformation,
)

Far as I can tell, the only way to format a date without using parse() to construct my own format is to do this very long-winded incantation:
const ISO8601_DATE: u128 = iso8601::Config::DEFAULT.set_formatted_components(FormattedComponents::Date).encode();
today.format(&Iso8601::<ISO8601_DATE>);

And this has to have the config declared as a const and can't be written as a one-liner. This is extremely verbose for such a basic operation.
Can I request either one of these changes:

Existing formats could support formatting a date by omitting the time parts when none of them are present. (preferred)
A config of Iso8601 could be provided out of the box (alongside Iso8601::DEFAULT) which does the same and doesn't require me to dig so deep into the weeds here?

For RFC 2822 and RFC 3339, the only supported formats are all-inclusive, as there is no indication in the specifications that anything else is permitted.
For ISO 8601, this can absolutely be done with the addition of an associated const.

const ISO8601_DATE: u128 = iso8601::Config::DEFAULT.set_formatted_components(FormattedComponents::Date).encode();
today.format(&Iso8601::<ISO8601_DATE>);

Completely unrelated, but do not rely on encode returning a u128. The return type is not guaranteed. You should use the EncodedConfig type alias.

And this has to have the config declared as a const and can't be written as a one-liner.

The config can be inlined; a separately declared const isn't strictly necessary.

Existing formats could support formatting a date by omitting the time parts when none of them are present. (preferred)

The implementation has no knowledge of what type is actually being formatted. The default configuration for ISO 8601 is documented as formatting the date, time, and UTC offset.

A config of Iso8601 could be provided out of the box (alongside Iso8601::DEFAULT) which does the same and doesn't require me to dig so deep into the weeds here?

This is almost certainly what will be done. It'll be quite easy to add further associated constants.

Agreed, for 2822 it probably doesn't make sense, you never see those with the time omitted either.
However I don't read RFC 3339 as requiring there be a time, and I do see date-only RFC-3339 in use. For example, GNU Coreutils' date lets you do date --rfc-3339=date in addition to date --rfc-3339=second which prints date and time.
The RFC's ABNF breaks it out separately as
full-date       = date-fullyear "-" date-month "-" date-mday

But it doesn't positively say the time is optional either, and the examples all have both date and time.
Ultimately, being a subset of ISO 8601, as long as that code can do it easily, it doesn't matter :)
An associated const on Iso8601 would be perfect and much appreciated.

The config can be inlined; a separately declared const isn't strictly necessary.

You're right, I was getting a syntax error when I tried earlier, but I took another look and figured out what I was doing wrong. The syntax for it is very unusual (I don't think I've seen it before in my ~7 years of doing rust 😄). You have to use braces around the const expression:
today.format(&Iso8601::<{iso8601::Config::DEFAULT.set_formatted_components(FormattedComponents::Date).encode()}>)

Agreed, for 2822 it probably doesn't make sense, you never see those with the time omitted either.
However I don't read RFC 3339 as requiring there be a time, and I do see date-only RFC-3339 in use. For example, GNU Coreutils' date lets you do date --rfc-3339=date in addition to date --rfc-3339=second which prints date and time.
The RFC's ABNF breaks it out separately as
full-date       = date-fullyear "-" date-month "-" date-mday

But it doesn't positively say the time is optional either, and the examples all have both date and time.
Ultimately, being a subset of ISO 8601, as long as that code can do it easily, it doesn't matter :)
An associated const on Iso8601 would be perfect and much appreciated.

The config can be inlined; a separately declared const isn't strictly necessary.

You're right, I was getting a syntax error when I tried earlier, but I took another look and figured out what I was doing wrong. The syntax for it is very unusual (I don't think I've seen it before in my ~7 years of doing rust 😄). You have to use braces around the const expression:
today.format(&Iso8601::<{iso8601::Config::DEFAULT.set_formatted_components(FormattedComponents::Date).encode()}>)

I have implemented more associated constants for Iso8601. You can view them here. As part of the change, I made it very easy to add additional configurations if there is the desire to do so in the future.
With regard to RFC 2822 and RFC 3339, I see no indication in either that there is intent to permit date-only formatting, among others. In neither RFC does the ABNF clearly show that each item is to be permitted on its own. Such an interpretation would be seem to also permit formatting only the hours, for example, which is presumably not the goal. I also checked the ABNF specification to see if there was anything implicit that I wasn't aware of, but did not find anything.
For the date command, that's its own program that can do whatever it wants. I'm following the specifications as strictly as possible, and I don't see anything that shows it was supposed to be allowed. On the contrary, the examples only include date-time-offset values.

Ultimately, being a subset of ISO 8601

RFC 3339 may have been a subset of ISO 8601 when it was written, but it's not a subset of the latest version of ISO 8601 (from 2019). There are minor differences here and there.
As I've implemented the associated constants for ISO 8601 and don't see where it's permitted in the two RFCs, I'm closing this as completed. Thank you for the request!

This is great, thanks!


ZNLDP12LM - Xiaomi Aqara smart LED bulb color temperature is not transfered to Domoticz

Issue description
The color temperature is not transfered to Domoticz
See also:
http://www.domoticz.com/forum/viewtopic.php?f=59&t=27499&sid=f6e805a64edc347cc9e560404a5cca54#p210792
Additional information
Zigbee2MQTT version: 1.3.0 (commit #da94252)
Python version: 3.5.3
Domoticz version: 4.10602
Plugin version: 0.0.18
4/14/2019, 3:53:34 PM - debug: Received MQTT message on 'zigbee2mqtt/Overlooplamp/set' with data '{"state": "ON", "color_temp": 294, "brightness": 117}'
4/14/2019, 3:53:34 PM - info: Zigbee publish to device '0x00158d0002b7d689', genLevelCtrl - moveToLevelWithOnOff - {"level":117,"transtime":0} - {"manufSpec":0,"disDefaultRsp":0} - null
4/14/2019, 3:53:34 PM - debug: Received zigbee message of type 'attReport' with data '{"cid":"genLevelCtrl","data":{"61440":117440720,"currentLevel":117}}' of device 'lumi.light.aqcn02' (0x00158d0002b7d689) of endpoint 1
4/14/2019, 3:53:34 PM - debug: Received zigbee message of type 'devChange' with data '{"cid":"genLevelCtrl","data":{"61440":117440720}}' of device 'lumi.light.aqcn02' (0x00158d0002b7d689) of endpoint 1
4/14/2019, 3:53:34 PM - debug: Received zigbee message of type 'attReport' with data '{"cid":"genOnOff","data":{"61440":5421568,"onOff":1}}' of device 'lumi.light.aqcn02' (0x00158d0002b7d689) of endpoint 1
4/14/2019, 3:53:34 PM - info: MQTT publish: topic 'zigbee2mqtt/Overlooplamp', payload '{"state":"ON","device":{"ieeeAddr":"0x00158d0002b7d689","friendlyName":"Overlooplamp","type":"Router","nwkAddr":21178,"manufId":4447,"manufName":"LUMI","powerSource":"DC Source","modelId":"lumi.light.aqcn02","hwVersion":1,"swBuildId":"unknown","dateCode":"09-30-2018","status":"online"},"linkquality":78,"brightness":117,"color_temp":329,"color_mode":1,"color":{"x":0.437,"y":0.408}}'
4/14/2019, 3:53:34 PM - debug: Received zigbee message of type 'devChange' with data '{"cid":"genOnOff","data":{"onOff":1}}' of device 'lumi.light.aqcn02' (0x00158d0002b7d689) of endpoint 1
4/14/2019, 3:53:34 PM - info: MQTT publish: topic 'zigbee2mqtt/Overlooplamp', payload '{"state":"ON","device":{"ieeeAddr":"0x00158d0002b7d689","friendlyName":"Overlooplamp","type":"Router","nwkAddr":21178,"manufId":4447,"manufName":"LUMI","powerSource":"DC Source","modelId":"lumi.light.aqcn02","hwVersion":1,"swBuildId":"unknown","dateCode":"09-30-2018","status":"online"},"linkquality":78,"brightness":117,"color_temp":329,"color_mode":1,"color":{"x":0.437,"y":0.408}}'
4/14/2019, 3:53:34 PM - debug: Received zigbee message of type 'attReport' with data '{"cid":"genLevelCtrl","data":{"61440":5421568,"currentLevel":117}}' of device 'lumi.light.aqcn02' (0x00158d0002b7d689) of endpoint 1
4/14/2019, 3:53:34 PM - debug: Received zigbee message of type 'devChange' with data '{"cid":"genLevelCtrl","data":{"61440":5421568}}' of device 'lumi.light.aqcn02' (0x00158d0002b7d689) of endpoint 1
4/14/2019, 3:53:34 PM - info: Zigbee publish to device '0x00158d0002b7d689', lightingColorCtrl - moveToColorTemp - {"colortemp":294,"transtime":0} - {"manufSpec":0,"disDefaultRsp":0} - null
4/14/2019, 3:53:34 PM - debug: Received zigbee message of type 'readRsp' with data '{"cid":"genLevelCtrl","data":{"currentLevel":117,"remainingTime":0,"onOffTransitionTime":150}}' of device 'lumi.light.aqcn02' (0x00158d0002b7d689) of endpoint 1
4/14/2019, 3:53:34 PM - debug: Received zigbee message of type 'attReport' with data '{"cid":"lightingColorCtrl","data":{"61440":117440723,"colorTemperature":294}}' of device 'lumi.light.aqcn02' (0x00158d0002b7d689) of endpoint 1
4/14/2019, 3:53:34 PM - debug: Received zigbee message of type 'devChange' with data '{"cid":"lightingColorCtrl","data":{"61440":117440723,"colorTemperature":294}}' of device 'lumi.light.aqcn02' (0x00158d0002b7d689) of endpoint 1
4/14/2019, 3:53:34 PM - info: MQTT publish: topic 'zigbee2mqtt/Overlooplamp', payload '{"state":"ON","device":{"ieeeAddr":"0x00158d0002b7d689","friendlyName":"Overlooplamp","type":"Router","nwkAddr":21178,"manufId":4447,"manufName":"LUMI","powerSource":"DC Source","modelId":"lumi.light.aqcn02","hwVersion":1,"swBuildId":"unknown","dateCode":"09-30-2018","status":"online"},"linkquality":78,"brightness":117,"color_temp":294,"color_mode":1,"color":{"x":0.437,"y":0.408}}'
4/14/2019, 3:53:34 PM - debug: Received zigbee message of type 'attReport' with data '{"cid":"lightingColorCtrl","data":{"61440":5421568,"colorTemperature":294}}' of device 'lumi.light.aqcn02' (0x00158d0002b7d689) of endpoint 1
4/14/2019, 3:53:34 PM - debug: Received zigbee message of type 'devChange' with data '{"cid":"lightingColorCtrl","data":{"61440":5421568}}' of device 'lumi.light.aqcn02' (0x00158d0002b7d689) of endpoint 1
4/14/2019, 3:53:34 PM - info: MQTT publish: topic 'zigbee2mqtt/Overlooplamp', payload '{"state":"ON","device":{"ieeeAddr":"0x00158d0002b7d689","friendlyName":"Overlooplamp","type":"Router","nwkAddr":21178,"manufId":4447,"manufName":"LUMI","powerSource":"DC Source","modelId":"lumi.light.aqcn02","hwVersion":1,"swBuildId":"unknown","dateCode":"09-30-2018","status":"online"},"linkquality":78,"brightness":117,"color_temp":294,"color_mode":1,"color":{"x":0.437,"y":0.408}}'
4/14/2019, 3:53:34 PM - debug: Received zigbee message of type 'readRsp' with data '{"cid":"lightingColorCtrl","data":{"remainingTime":0,"currentX":27282,"currentY":26113,"colorTemperature":294,"colorMode":1}}' of device 'lumi.light.aqcn02' (0x00158d0002b7d689) of endpoint 1
4/14/2019, 3:53:34 PM - debug: Received zigbee message of type 'devChange' with data '{"cid":"lightingColorCtrl","data":{"currentX":27282,"currentY":26113}}' of device 'lumi.light.aqcn02' (0x00158d0002b7d689) of endpoint 1
4/14/2019, 3:53:34 PM - info: MQTT publish: topic 'zigbee2mqtt/Overlooplamp', payload '{"state":"ON","device":{"ieeeAddr":"0x00158d0002b7d689","friendlyName":"Overlooplamp","type":"Router","nwkAddr":21178,"manufId":4447,"manufName":"LUMI","powerSource":"DC Source","modelId":"lumi.light.aqcn02","hwVersion":1,"swBuildId":"unknown","dateCode":"09-30-2018","status":"online"},"linkquality":78,"brightness":117,"color_temp":294,"color_mode":1,"color":{"x":0.416,"y":0.398}}'
4/14/2019, 3:53:34 PM - debug: Received zigbee message of type 'readRsp' with data '{"cid":"lightingColorCtrl","data":{"colorTempPhysicalMin":0,"colorTempPhysicalMax":65279}}' of device 'lumi.light.aqcn02' (0x00158d0002b7d689) of endpoint 1
4/14/2019, 3:53:34 PM - debug: Received zigbee message of type 'devChange' with data '{"cid":"lightingColorCtrl","data":{"currentX":27282,"currentY":26113}}' of device 'lumi.light.aqcn02' (0x00158d0002b7d689) of endpoint 1
4/14/2019, 3:53:34 PM - info: MQTT publish: topic 'zigbee2mqtt/Overlooplamp', payload '{"state":"ON","device":{"ieeeAddr":"0x00158d0002b7d689","friendlyName":"Overlooplamp","type":"Router","nwkAddr":21178,"manufId":4447,"manufName":"LUMI","powerSource":"DC Source","modelId":"lumi.light.aqcn02","hwVersion":1,"swBuildId":"unknown","dateCode":"09-30-2018","status":"online"},"linkquality":78,"brightness":117,"color_temp":294,"color_mode":1,"color":{"x":0.416,"y":0.398}}'
4/14/2019, 3:53:36 PM - debug: Received MQTT message on 'zigbee2mqtt/Overlooplamp/set' with data '{"state": "On"}'
4/14/2019, 3:53:36 PM - info: Zigbee publish to device '0x00158d0002b7d689', genOnOff - on - {} - {"manufSpec":0,"disDefaultRsp":0} - null
4/14/2019, 3:53:36 PM - info: MQTT publish: topic 'zigbee2mqtt/Overlooplamp', payload '{"state":"ON","device":{"ieeeAddr":"0x00158d0002b7d689","friendlyName":"Overlooplamp","type":"Router","nwkAddr":21178,"manufId":4447,"manufName":"LUMI","powerSource":"DC Source","modelId":"lumi.light.aqcn02","hwVersion":1,"swBuildId":"unknown","dateCode":"09-30-2018","status":"online"},"linkquality":78,"brightness":117,"color_temp":294,"color_mode":1,"color":{"x":0.416,"y":0.398}}'
4/14/2019, 3:53:36 PM - debug: Received zigbee message of type 'attReport' with data '{"cid":"genOnOff","data":{"61440":117440727,"onOff":1}}' of device 'lumi.light.aqcn02' (0x00158d0002b7d689) of endpoint 1
4/14/2019, 3:53:36 PM - info: MQTT publish: topic 'zigbee2mqtt/Overlooplamp', payload '{"state":"ON","device":{"ieeeAddr":"0x00158d0002b7d689","friendlyName":"Overlooplamp","type":"Router","nwkAddr":21178,"manufId":4447,"manufName":"LUMI","powerSource":"DC Source","modelId":"lumi.light.aqcn02","hwVersion":1,"swBuildId":"unknown","dateCode":"09-30-2018","status":"online"},"linkquality":81,"brightness":117,"color_temp":294,"color_mode":1,"color":{"x":0.416,"y":0.398}}'
4/14/2019, 3:53:36 PM - debug: Received zigbee message of type 'devChange' with data '{"cid":"genOnOff","data":{"61440":117440727}}' of device 'lumi.light.aqcn02' (0x00158d0002b7d689) of endpoint 1
4/14/2019, 3:53:36 PM - debug: Received zigbee message of type 'readRsp' with data '{"cid":"genOnOff","data":{"onOff":1,"onTime":0,"offWaitTime":0}}' of device 'lumi.light.aqcn02' (0x00158d0002b7d689) of endpoint 1

@SargonofAssyria is the issue still present?

Yes

@SargonofAssyria, @mench32 could you please update plugin and check now

It looks to me that the bulb acts normal.


encoding.explode:true not working for schema properties

Hi Team,
I have several api endpoints that allow for a parameter to be specified multiple times. See example of one below.
{
    "openapi": "3.0.1",
    "info": {
        "title": "TEST",
        "version": "1.0.0"
    },
    "servers": [{
        "url": "http://localhost:8080/api/",
        "description": "TEST"
    }],
    "paths": {
        "/deleteImage": {
            "post": {
                "tags": ["Images"],
                "summary": "Delete Image",
                "description": "The delete image service deletes the specified image.  Multiple imageName parameters can be specified to delete multiple images.",
                "operationId": "deleteImage",
                "requestBody": {
                    "content": {
                        "application/x-www-form-urlencoded": {
                            "schema": {
                                "$ref": "#/components/schemas/DeleteImageRequest"
                            },
                            "encoding": {
                                "imageName": {
                                    "explode": true
                                }
                            }
                        },
                        "multipart/form-data": {
                            "schema": {
                                "$ref": "#/components/schemas/DeleteImageRequest"
                            },
                            "encoding": {
                                "imageName": {
                                    "explode": true
                                }
                            }
                        }
                    }
                },
                "responses": {
                    "200": {
                        "description": "Request succeeded"
                    }
                }
            }
        }
    },
    "components": {
        "schemas": {
            "DeleteImageRequest": {
                "required": ["accessKey", "imageName"],
                "type": "object",
                "properties": {
                    "accessKey": {
                        "type": "string",
                        "description": "Your unique access key that you can find on the Account page in the Cloud Console."
                    },
                    "imageName": {
                        "minItems": 1,
                        "type": "array",
                        "items": {
                            "type": "string",
                            "description": "The name of the image. This parameter can be specified multiple times to delete multiple files.",
                            "example": "/MyImageFolder/MyImage.png"
                        }
                    }
                },
                "description": "Delete Image Request Model"
            }
        }
    }
}

In RapiDoc the explode:true property seems to be ignored and the imageName parameter is interpreted as a single parameter with comma delimitated values and an erroneous leading delimitator. If I test the example spec above from RapiDoc I get the following raw request bodies:
Multipart:
------WebKitFormBoundaryXXVgV2Xnct1AW3tT
Content-Disposition: form-data; name="accessKey"

XXX
------WebKitFormBoundaryXXVgV2Xnct1AW3tT
Content-Disposition: form-data; name="imageName"

,abc.png,def.jpg
------WebKitFormBoundaryXXVgV2Xnct1AW3tT--

Form Data:
accessKey=XXX&imageName=,abc.png,def.jpg

The example api above works correctly in Swagger UI though.
I also note that Parameters with explode:true seem to work fine in RapiDoc.

We have run into this problem as well. And the way I read the OpenAPI documentation it is supposed to explode arrays by default, without even requiring an explode:true setting:

Form fields can contain primitives values, arrays and objects. By default, arrays are serialized as array_name=value1&array_name=value2 and objects as prop1=value1&prop2=value2, but you can use other serialization strategies as defined by the OpenAPI 3.0 Specification.

But we are happy to supply the setting, we just need it to be supported.


[Autocomplete] Fix iOS double tap

[x] I have followed (at least) the PR section of the contributing guide.

Fixes #21049 - [AutoComplete] Requires two clicks to open on mobile ios after state is set
Based on code by @oliviertassinari, thanks for the help!

@kaplantm It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!


map.contains-key implemented

Closes: #119

@c71n93 please have a look

@yegor256 please, have a look

@rultor merge

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@eugenedar @yegor256 Oops, I failed. You can see the full log here (spent 2min)
+ source /home/r/.profile
++ '[' /bin/bash ']'
++ '[' -f /home/r/.bashrc ']'
++ . /home/r/.bashrc
+++ '[' -z '' ']'
+++ return
++ mesg n
++ true
+ shopt -s expand_aliases
+ alias 'sudo=sudo -i'
+ export HOME=/home/r
+ HOME=/home/r
+ cd /home/r/repo
+ export head=git@github.com:objectionary/eo-collections.git
+ head=git@github.com:objectionary/eo-collections.git
+ export pull_id=145
+ pull_id=145
+ export fork=git@github.com:EugeneDar/eo-collections.git
+ fork=git@github.com:EugeneDar/eo-collections.git
+ export fork_branch=119
+ fork_branch=119
+ export head_branch=master
+ head_branch=master
+ export 'pull_title=map.contains-key implemented'
+ pull_title='map.contains-key implemented'
+ export author=yegor256
+ author=yegor256
+ pdd --file=/dev/null
Found 6 lines in /home/r/repo/.pdd
My version is 0.20.8
Ruby version is 2.7.0 at x86_64-linux
Reading from root dir .
\u001b[38;5;214mExcluding\u001b[0m target/**
Reading renovate.json ...
Reading LICENSE.txt ...
Reading .github/workflows/pdd.yml ...
Reading .github/workflows/xcop.yml ...
Reading .github/workflows/mvn.yml ...
Reading .github/workflows/codecov.yml ...
Reading .pdd ...
Reading .0pdd.yml ...
Reading src/test/eo/org/eolang/collections/range-tests.eo ...
Reading src/test/eo/org/eolang/collections/set-tests.eo ...
Reading src/test/eo/org/eolang/collections/list-tests.eo ...
Puzzle 83-153555c7 30/DEV at src/test/eo/org/eolang/collections/list-tests.eo
Puzzle 85-22081d9d 30/DEV at src/test/eo/org/eolang/collections/list-tests.eo
Reading src/test/eo/org/eolang/collections/map-tests.eo ...
Reading src/test/eo/org/eolang/collections/bytes-as-array-tests.eo ...
Reading src/test/eo/org/eolang/collections/multimap-tests.eo ...
Puzzle 15-ef4bc9a4 30/DEV at src/test/eo/org/eolang/collections/multimap-tests.eo
Puzzle 15-332c85d8 30/DEV at src/test/eo/org/eolang/collections/multimap-tests.eo
Puzzle 15-96820566 30/DEV at src/test/eo/org/eolang/collections/multimap-tests.eo
Reading src/main/java/EOorg/EOeolang/EOcollections/EOmultimap$EOrebuild.java ...
Reading src/main/java/EOorg/EOeolang/EOcollections/package-info.java ...
Reading src/main/eo/org/eolang/collections/map.eo ...
\u001b[31mERROR\u001b[0m: src/main/eo/org/eolang/collections/map.eo; src/main/eo/org/eolang/collections/map.eo:47 Space expected at 51:4; make sure all lines in the puzzle body have a single leading space.
If you can't understand the cause of this issue or you don't know how to fix it, please submit a GitHub issue, we will try to help you: https://github.com/cqfn/pdd/issues. This tool is still in its beta version and we will appreciate your feedback. Here is where you can find more documentation: https://github.com/cqfn/pdd/blob/master/README.md.
Exit code is 1
container 75113b56ca8aeb40c13e58d17b9c0ec78ac4443ce63edc7e357c9c79d12429db is dead
Thu 16 Feb 2023 10:42:55 PM CET

@yegor256 can you merge again?

@rultor merge

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 8min)


ActiveRelation: support custom Scopes

$this->hasOne(Report::className(), ['fk_goal' => 'id'])->myScope()->one();
have exception
Calling unknown method: yii\db\ActiveRelation::myScope()
I must to redeclare createActiveRelation ?
Now i solve i like:
class Report extends ActiveRecord {

    public static function createQuery()
    {
        return new ReportQuery(['modelClass' => get_called_class()]);
    }

    public static function createActiveRelation($config = [])
    {
        return new ReportRelation($config);
    }

}

//scopes
trait ReportScopes
{
    public function myScope() {
        return $this;
    }
}

//apply scopes to query
class ReportQuery extends ActiveQuery
{
    use ReportScopes;
}

//apply scopes to relations
class ReportRelation extends ActiveRelation
{
    use ReportScopes;
}

@qiangxue
class Post extends ActiveRecord
{
public static function scopeVisible($query)
{
$query->andWhere(['visible' => 1]);
}
}
Post::find()->visible()->all();
is this working now in current yii2?

no, scopes are only supported in custom query classes.

is this tutorial for scopes in relations correct?
from http://www.yiiframework.com/doc-2.0/guide-db-active-record.html#scopes
You can also use scopes when defining relations. For example,
class Post extends \yii\db\ActiveRecord
{
public function getActiveComments()
{
return $this->hasMany(Comment::className(), ['post_id' => 'id'])->active();
}

}
I have a problem:
Calling unknown method: yii\db\ActiveQuery::active()
Thanks

I know this has been discussed in depth, but i'm unclear what's the argument against the example code by @qiangxue ..
This example query basically implements support for this feature without breaking anything else.
    class TestQuery extends ActiveQuery {
        public function __call($name, array $arguments) {
            // Check if this is a scope.
            $method = 'scope' . ucfirst($name);
            array_unshift($arguments, $this);
            if (method_exists($this->modelClass, $method)) {
                $result = forward_static_call_array([$this->modelClass, $method], $arguments);
            } else {
                $result = parent::__call($name, $arguments);
            }
        }
    }

This code has little overhead and as far as I can tell does not break BC. The argument against having different names for scopes in an ActiveQuery class vs scopes in an ActiveRecord class is not valid in my opinion. The added ease of use of this code outweights the "inconsistency" in my opinion.
Obviously I can and do implement this in my base ActiveQuery / ActiveRecord classes, but I think it would improve the framework to include this.

This sounds interesting.
However instead of composing method name with prefix 'scope' it is better to check if the method is static  using reflection. This can lead us back to original implementation, where static methods of Active Record class serve as a scopes.

Making all static methods a scope automatically seems bad to me. If we use reflection we could go as far as to check the signature to see if it is a scope. However for me this adds no real benefit.
I like having the scope prefix in my ActiveRecord class and I like not having to use the scope prefix when running the query.
Also there are some static methods that are never scopes (like getDb, createQuery, tableName) I'd rather not have to think about these possible collisions; also for BC the prefix is safer since I can easily verify that any existing static methods don't start with "scope"; it is harder for me to verify that any static methods I have defined will not pass the check for being interpreted as a scope.
What is bad about the prefix method? Is it bad practice?

Using the prefix for scopes method introduces special magic. Also not everyone may actually like it.
For example: I prefer to declare scope methods in format 'where...':
public static function whereActive($query)
{
    ...
    return $query;
}

This way scope methods looks pretty both while declaring and while applying.
Also originally (back at 'beta' version) Active Record declared its scopes in this way - just a static methods without any prefix.

It is obvious we are running circles around here.
I have reread the entire conversation and found final resolution reference:
https://github.com/yiisoft/yii2/issues/2016#issuecomment-32629793
Change does not make sense.

Ok, clear on the final arguments. Will consider releasing this as a separate module. Thanks for the input!


Add annotation dependency for Symfony Flex

Hi guys,
I was installing the api-pack via Symfony Flex and couldn't complete without installing annot recipe (https://github.com/sensiolabs/SensioFrameworkExtraBundle) first.
Adding the dependency to composer.json should fix it.
Please have a look at the steps to reproduce the issue:
//macOs High Sierra
PHP 7.1.7 (cli) (built: Jul 15 2017 18:08:09) ( NTS )
Copyright (c) 1997-2017 The PHP Group
Zend Engine v3.1.0, Copyright (c) 1998-2017 Zend Technologies

create project:

$ composer create-project symfony/skeleton api_flex/
Installing symfony/skeleton (v3.3.5)
...
Executing script assets:install --symlink --relative public [OK]

 What's next?

  * Run your application:
    1. Change to the project directory
    2. Execute the php -S <IP_ADDRESS>:8000 -t public command;
    3. Browse to the http://localhost:8000/ URL.

       Quit the server with CTRL-C.
       Run composer require symfony/web-server-bundle for a better web server.

  * Read the documentation at https://symfony.com/doc

require api

$ cd api_flex/
$ composer req api
...
Writing lock file
Generating autoload files
Symfony operations: 7 recipes (8bb573343e5ff2a4f82ffebebc67937b)
  - Configuring symfony/translation (3.3): From github.com/symfony/recipes:master
  - Configuring symfony/twig-bundle (3.3): From github.com/symfony/recipes:master
  - Configuring symfony/security-bundle (3.3): From github.com/symfony/recipes:master
  - Configuring doctrine/annotations (1.0): From github.com/symfony/recipes:master
  - Configuring doctrine/doctrine-cache-bundle (1.3.2): From auto-generated recipe
  - Configuring doctrine/doctrine-bundle (1.6): From github.com/symfony/recipes:master
  - Configuring api-platform/core (2.1): From github.com/symfony/recipes:master

Executing script cache:clear [KO]
 [KO]
Script cache:clear returned with error code 1
!!
!!       [Symfony\Component\Config\Exception\FileLoaderLoadException]
!!    Cannot load resource "../src/Controller/". Make sure annotations are enable
!!    d.

Installation failed, reverting ./composer.json to its original content.

After requiring the https://github.com/sensiolabs/SensioFrameworkExtraBundle, it works fine:
$ composer req annot
Using version ^5.0 for sensio/framework-extra-bundle
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
  - Installing sensio/framework-extra-bundle (v5.0.1)
    Loading from cache

sensio/framework-extra-bundle suggests installing symfony/psr-http-message-bridge (To use the PSR-7 converters)
Writing lock file
Generating autoload files
Symfony operations: 1 recipe (7c94609e828c9c5c31bafacf48d92609)
  - Configuring sensio/framework-extra-bundle (4.0): From github.com/symfony/recipes:master
Executing script cache:clear [OK]
Executing script assets:install --symlink --relative public [OK]

And then, requiring api again:
$ composer req api
Using version ^1.0 for api-platform/api-pack
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Nothing to install or update
Writing lock file
Generating autoload files
Executing script cache:clear [OK]
Executing script assets:install --symlink --relative public [OK]

Hi,
Thanks for reviewing. I've tested again to check if it's still an issue:

Symfony 4: cannot reproduce
Symfony 3.3 and 3.4: cannot reproduce anymore

Actually, I was searching for the fix on the other related projects and could find what fixed it.
So, this change is no longer needed.


ENH: Support dask dataframe in train_test_split

Closes https://github.com/dask/dask-ml/issues/351

Merging later today.


Update microsoft-teams-rooms-configure-servicenow.md

Adding notification that SNOW API is not available in GCC

This is fine. Please feel free to publish.

@altsou
PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


Add ASTNode.dump() methods

Mainly for debugging, since their internal structure is impenetrable to lldb. They just forward to the underlying node's dump() method.

@swift-ci please smoke test

@swift-ci please smoke test linux platform

Thanks! Great idea!!

David

On Feb 18, 2019, at 12:24 AM, Brent Royal-Gordon<EMAIL_ADDRESS>wrote:
@swift-ci please smoke test linux platform
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@swift-ci please smoke test linux

@swift-ci please smoke test linux


SyntaxError: Unexpected token import

Version
v2.4.0
Reproduction link
https://github.com/nuxt/nuxt.js/issues/
Steps to reproduce
Fresh install of nuxt 2.4.0
Run:
npm run build

Then install pm2
Then try register the app with:
pm2 start .nuxt/server.js --watch

The app is registered and die with error on pm2 logs:
../.nuxt/server.js:1
(function (exports, require, module, __filename, __dirname) { import { stringify } from 'querystring'

SyntaxError: Unexpected token import
  at createScript (vm.js:80:10)
  at Object.runInThisContext (vm.js:139:10)
  at Module._compile (module.js:617:28)
  at Object.Module._extensions..js (module.js:664:10)
  at Module.load (module.js:566:32)
  at tryModuleLoad (module.js:506:12)
  at Function.Module._load (module.js:498:3)
  at Function._load (/usr/lib/node_modules/pm2/node_modules/@pm2/io/build/main/metrics/httpMetrics.js:172:43)
  at Object.<anonymous> (/usr/lib/node_modules/pm2/lib/ProcessContainerFork.js:27:21)
  at Module._compile (module.js:653:30)

Same error about token issue occours if I try use Passenger.
What is expected ?
Load in both Passenger and PM2 without errors (on this issue, fixing the token error about import { stringify })
What is actually happening?
Can not run because the error on token importing { stringify }
Additional comments?
Vanilla Vue run on both: Passenger and PM2 without errors.

This bug report is available on Nuxt community (#c8928)

PLease provide an example repo or similar.

Remove node_modules, remove yarn.lock/package-lock.json and reinstall.

I get a similar error when running node .nuxt/server.js.
I upgraded from 2.4.5 to 2.5.1 and I deleted package-lock.json and node-modules before the upgrade.
(function (exports, require, module, __filename, __dirname) { import { stringify } from 'querystring'
                                                                     ^
SyntaxError: Unexpected token {

Full Stacktrace

(function (exports, require, module, __filename, __dirname) { import { stringify } from 'querystring'
                                                                     ^

SyntaxError: Unexpected token {
    at new Script (vm.js:79:7)
    at createScript (vm.js:251:10)
    at Object.runInThisContext (vm.js:303:10)
    at Module._compile (internal/modules/cjs/loader.js:657:28)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
    at Module.load (internal/modules/cjs/loader.js:599:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
    at Function.Module._load (internal/modules/cjs/loader.js:530:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:742:12)
    at startup (internal/bootstrap/node.js:283:19)

Reproduction
https://github.com/jloewe/nuxt-unexpected-token-repro

I have tried install lastest version, and also install stable and then upgrade following the steps of the hint from @jloewe sayed, without success.
I have forget the specify my enviroment:
Debian: Stretch 9.8 (x64)
npm: 6.9.0
node: v8.15.1
apache: 2.4.25
pm2: 3.4.0
passenger: 5.0.30
How to setup passenger on Apache using Vanilla Vue:
# Tell Apache and Passenger where your app's code directory is
DocumentRoot "{DOCROOT_CLIENT}/dist"
PassengerAppRoot {DOCROOT_CLIENT}

# Tell Passenger that your app is a Node.js app
PassengerAppType node
PassengerStartupFile {DOCROOT_CLIENT}/dist/service-worker.js

How to setup pm2 on Apache using Vanilla Vue:
ProxyPass / http://<IP_ADDRESS>:3000/
ProxyPassReverse / http://<IP_ADDRESS>:3000/
ProxyPreserveHost On

You need change for your current available port.

That may be because of babel.config.js existence in the project folder. This has been fixed for upcoming 2.5.2.

@pi0
I don't think this is the source of problem, at last on Vanilla Vue enabling all features like:
vue create test

Babel
Typescript
Progressive Web App (PWA) Support
Touter
Vuex
CSS pre-processors
Linter / Formatter
Unit Testing
E2E testing

Use class-style component syntax -> Y

Use Babel alongside TypeScript for auto-detected polyfills -> Y

Use history mode for router -> Y

Sass/SCSS (with node-sass)

ESLint + Prettier

Lint on Save
Lint and fix on commit

Mocha + Chai

Cypress

In dedicated config files

Then will create babel.config.js also, and works, in Passenger and PM2 also.
My guess since the error points to stringfy, I think there an import where should be require, but did not found the file to change and test.

@pi0
I currently don't have a babel.config.js in my Project Folder.
But I have a babel block in my nuxt.config.js.
nuxt.config.js - babel

...
babel: {
      presets: ["@nuxt/babel-preset-app"],
      plugins: [
        "@babel/plugin-transform-runtime"
      ]
},
...

https://github.com/jloewe/nuxt-unexpected-token-repro/blob/master/nuxt.config.js

@jloewe that preset is used by default and AFAIK y<ou don't need the plugin as well so you can try deleting the whole block ☺

@manniL I deleted it. Thank you for the info.
After I deleted the Babel Block from nuxt.config.js everything worked fine.
I also deleted

@babel/cli
@babel/core
@babel/plugin-transform-runtime
@nuxt/babel-preset-app

from package.json
Updated version of my code. Now working:
https://codesandbox.io/s/7m6v78m3v0

this isn't very helpful.
i removed @babel/* - removed my node_modules & package-lock
then i used yarn and everything is working exactly as expected.
something must be jacked up with NPM.

I'm running into the same issue/error.
nuxt: 2.6.2
npm: 6.4.1
node: 10.15.3
pm2: 3.5.0

I've tried using npm, deleted .nuxt and node_modules and using yarn to no avail.
I don't have a .babel.config.js or babel block in my .nuxt.config.

I'll try to get an example repo up but was wondering if anyone else has gone through the problem differently?

Any solution ?
I have try all contributes, remove and reinstall node-modules and package-lock, upgrade pm2 , upgrade nuxt version, its not worked for me.

Any solution ?
I have try all contributes, remove and reinstall node-modules and package-lock, upgrade pm2 , upgrade nuxt version, its not worked for me.

did you try deleting your .nuxt auto-generated folder as well? with the nuxt 2.6.2 version - i haven't seen this problem happen any more.

@NextStepGuru

Any solution ?
I have try all contributes, remove and reinstall node-modules and package-lock, upgrade pm2 , upgrade nuxt version, its not worked for me.

did you try deleting your .nuxt auto-generated folder as well? with the nuxt 2.6.2 version - i haven't seen this problem happen any more.

No I did not try it, which folder  I must remove do you know

well typica

@NextStepGuru

Any solution ?
I have try all contributes, remove and reinstall node-modules and package-lock, upgrade pm2 , upgrade nuxt version, its not worked for me.

did you try deleting your .nuxt auto-generated folder as well? with the nuxt 2.6.2 version - i haven't seen this problem happen any more.

No I did not try it, which folder I must remove do you know

typically its the .nuxt folder in the root of your project.

well typica

@NextStepGuru

Any solution ?
I have try all contributes, remove and reinstall node-modules and package-lock, upgrade pm2 , upgrade nuxt version, its not worked for me.

did you try deleting your .nuxt auto-generated folder as well? with the nuxt 2.6.2 version - i haven't seen this problem happen any more.

No I did not try it, which folder I must remove do you know

typically its the .nuxt folder in the root of your project.

I tried this. remove .nuxt  compile and " npm run build"  again but this not solved my problem,  my website yesterday was working normally, today not working, İ dont understant

when I run 'npm start'  my web site works normaly, but when I run 'pm2 start npm -- start' get 503 error, and given
..... (function (exports, require, module, __filename, __dirname) { import { stringify } from 'querystring'
log

Hi @savasturkoglu1!
I have the same issue, after upgrade to 2.6.x
Did you resolve this problem?

Hi @savasturkoglu1!
I have the same issue, after upgrade to 2.6.x
Did you resolve this problem?

Did you removed the lock files?
Try:
delete package-lock.json
delete node_modules
Upate the package.json to desired version
Run:
npm install

Many comments here refer to issues when using node .nuxt/server.js to start nuxt. You can't do that, regardless if using pm2 or not, as node won't be able to parse ES imports syntax. You need to start using nuxt starter script (for example ./node_modules/.bin/nuxt start). So I think this bug report is invalid.

I'm not sure if I'm in the right place here, but I've been trying to get babel to transpile es6 imports within server/index.js and I can't seem to figure out how to get that to work... I've tried changing the npm run dev command to have nodemon run server/index.js with babel-node, but since the project has no .babelrc I have to define one for babel-node to read.
Am I missing something obvious here? Is it possible to have babel transpile es6 imports statements on server-side scripts?

@Anaphase https://discord.nuxtjs.org/ is better place to ask such questions.

@jloewe that preset is used by default and AFAIK y<ou don't need the plugin as well so you can try deleting the whole block ☺

After I deleting the plugins block, i still got an error Unexpected token export

node --experimental-modules my-app.mjs
While import is indeed part of ES6, it is unfortunately not yet supported in NodeJS by default, and has only very recently landed support in browsers.
See browser compat table on MDN and this Node issue.
From James M Snell’s Update on ES6 Modules in Node.js (February 2017):
Work is in progress but it is going to take some time — We’re currently looking at around a year at least.
Until support shows up natively, you’ll have to continue using classic require statements:
const express = require("express");
Full Source Available at https://icetutor.com/question/node-js-syntaxerror-unexpected-token-import/

https://discord.nuxtjs.org/

not good at all, because now i person like me trying to find a solution for this bug and i am expecting to find it here.


Prevent initial calls from intermediate stores

The multiplexing transform creates a (client-side) callback function that updates an output from multiple intermediate stores. This callback should have the property prevent_initial_call set to True since it doesn't make sense to initialize the output from several stores at once (and only the first of the triggered ones are used anyway). This makes it possible to set prevent_initial_call=True in the user-defined callback functions, like this:
<EMAIL_ADDRESS>Output(OUTPUT_ID, 'value'),
Input(FIRST_INPUT_ID, 'n_clicks'),
prevent_initial_call=True)
def f(_):
return "Foo"
@app.callback(
Output(OUTPUT_ID, 'value'),
Input(SECOND_INPUT_ID, 'n_clicks'),
prevent_initial_call=True)
def g(_):
return "Bar"`
Before this change, the above example resulted in a javascript error saying that dash_clientside.callback_context.triggered[0] didn't have any value.

Ah, yes, of course. Thanks for the correction :)

The fix has been included as part of the 0.0.49 release.


Light bulb Moment 💡 Can issues track stories?

Title

Can issues track stories?
Elevator Pitch

If you create a file and link an issue in it, does the issue hold an eternal link to that file? If so, it can be a way to navigate stories through GitHub: have issues for each category and each label, and these will "collect stories" as they appear.
Justification

Thinking about how to make navigating GitHub easier without messing up the chronological order any further (i,e,: BCE are in reverse order).
Unformed Thoughts

Test this by linking a thematic issue to a story.

They can! What needs to be done is that issues be linked with their # number in the commit! Now editing the story template to reflect this.

Create categorical issues first!

Categorical issues have been created. Opportunities for improvement:

You cannot search for stories linked within categories by using the search function of the repo's issues page; and
Stories within categories will not necessarily be in chronological order...

Created issues for tags, and labels to find issues that help with navigation. Next up: edit new-stories-template.

Next big task: link all ready-made stories to their categories/tags. Mind you, the sooner this is done, the sooner they will not appear chronologically...


Be specific on what input change caused configuration cache invalidation

Expected Behavior
Calculating task graph as configuration cache cannot be reused because an input to plugin 'com.android.internal.library' has changed. Input FOO_BAR has a different value.

Current Behavior (optional)
Calculating task graph as configuration cache cannot be reused because an input to plugin 'com.android.internal.library' has changed.

Context
It is extremely difficult to debug why the CC in invalidated when a message is so vague.

Thank you for your interest in Gradle!
This feature request is in the backlog of the relevant team, but this area of Gradle is currently not a focus one, so it might take a while before it gets implemented.

This is a duplicate of #25282.


Add basic support for cross-validation (see #146)

I think we can generalize this a little more to support subclasses of BatchScheme and IndexScheme:
def k_fold_cross_validation(scheme_class, num_examples, k, **kwargs):
   # ...
       valid = scheme_class(xrange(begin, end), **kwargs)

In the perspective that this PR is work-in-progress, here's another suggestion: I don't think we should support having num_examples not be a multiple of k by default. Silently accepting that may lead to incorrect results without the user's knowledge.
I propose that we add an optional strict kwarg, defaulting to True, which controls the following:

If strict is True, then num_examples % k != 0 causes a ValueError to be raised.
If strict is False, then the return value of the generator is a tuple with three elements: the train scheme, the valid scheme, and the number of examples covered by the valid scheme.

I've updated the PR to address your remarks.

Thank you both for your remarks, I've updated the PR.

Fixes #176. LGTM, merging.


Heroku CORS Anywhere Down?

Is it possible that https://cors-anywhere.herokuapp.com/ is not working properly?
It was working over the weekend for me, but this morning when I tried to access it, i am receiving a CORS error...
Access to XMLHttpRequest at 'https://cors-anywhere.herokuapp.com/' from origin 'null' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.
Even with the demo page:
https://robwu.nl/cors-anywhere.html
Below is a screenshot of the errors.
Thanks,
Eric

same

I fixed this by blocking some high-frequency requests.


When I execute “torchrun --nproc_per_node 1 llamacpp_mock_api.py”, the following error occurs.

torchrun --nproc_per_node 1 llamacpp_mock_api.py
--ckpt_dir CodeLlama-7b-Instruct/
--tokenizer_path CodeLlama-7b-Instruct/tokenizer.model
--max_seq_len 128 --max_batch_size 4

initializing model parallel with size 1
initializing ddp with size 1
initializing pipeline with size 1
ERROR:torch.distributed.elastic.multiprocessing.api:failed (exitcode: -9) local_rank: 0 (pid: 16713) of binary: /usr/bin/python3
Traceback (most recent call last):
File "/usr/local/bin/torchrun", line 8, in
sys.exit(main())
File "/usr/local/lib/python3.10/dist-packages/torch/distributed/elastic/multiprocessing/errors/init.py", line 346, in wrapper
return f(*args, **kwargs)
File "/usr/local/lib/python3.10/dist-packages/torch/distributed/run.py", line 794, in main
run(args)
File "/usr/local/lib/python3.10/dist-packages/torch/distributed/run.py", line 785, in run
elastic_launch(
File "/usr/local/lib/python3.10/dist-packages/torch/distributed/launcher/api.py", line 134, in call
return launch_agent(self._config, self._entrypoint, list(args))
File "/usr/local/lib/python3.10/dist-packages/torch/distributed/launcher/api.py", line 250, in launch_agent
raise ChildFailedError(
torch.distributed.elastic.multiprocessing.errors.ChildFailedError:
======================================================
llamacpp_mock_api.py FAILED

Failures:
<NO_OTHER_FAILURES>
Root Cause (first observed failure):
[0]:
time      : 2023-09-04_12:12:41
host      : 13edd873e909
rank      : 0 (local_rank: 0)
exitcode  : -9 (pid: 16713)
error_file: <N/A>
traceback : Signal 9 (SIGKILL) received by PID 16713

My GPU Info as below:
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 525.105.17   Driver Version: 525.105.17   CUDA Version: 12.0     |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|                               |                      |               MIG M. |
|===============================+======================+======================|
|   0  Tesla T4            Off  | 00000000:00:04.0 Off |                    0 |
| N/A   32C    P8     9W /  70W |      0MiB / 15360MiB |      0%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+
+-----------------------------------------------------------------------------+
| Processes:                                                                  |
|  GPU   GI   CI        PID   Type   Process name                  GPU Memory |
|        ID   ID                                                   Usage      |
|=============================================================================|
|  No running processes found                                                 |
+-----------------------------------------------------------------------------+

Did you figure it out? I have the same problem

Were you able to run Code Llama successfully using the codellama repository?
It's been nearly a year since this was opened, so I'm going to close it for now, but I'll reopen it if you send another message.


XML index access using string index should be deprecated

Description:
$title
Steps to reproduce:
Affected Versions:
OS, DB, other environment details and versions:
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

Fixed in #22088


Lighter custom builds

Summary
What would be a good way to get a custom build of the library that only contains features I want to use? For instance out of all the integration functions, I only want to start with Text, Icon, Draw and Crop. Is there a way to neatly exclude them from a custom build without changing much code?
Screenshots
If applicable, add screenshots to help explain your question.
Version
3.15.2
Additional context
I plan on using this in a cordova hybrid app that doesn't use js frameworks, so I want to only get the functionality I need.

@CodeWithOz
Thank you for the question.
Are you talking about tree shaking?
This is a feature that the image-editor does not support yet.


initial image index  no longer working

The initial image index on setStack is no longer working - it always shows image index 0 on initial display.
A work around is to invoke scroll after the initial set.
@sedghi  - I looked a while to figure out what was going on, but I couldn't see what was happening.  I have a work around in OHIF, but the basic functionality should still work.

Not happening in main anymore


Collector: invalid request cookie value resulting random network_userid

I'm getting different set network_userid from every js-tracker request
It took me few hours find that it is caused by my existed cookies, which have special characters like comma, backslash...
possible relate issue ? https://github.com/spray/spray/issues/702
maybe there is another workaround by add 'nuid' parameter from js-tracker, but couldn't find any document.

R93, which is the next release, will migrate the collector to akka-http (cf #3299).
In akka-http cookie parsing is just a matter of configuration, see cookie-parsing-mode in the akka-http default configuration

Closing since R93 has been released :+1:


add HTTPClient parameter functions

Current coverage is 69.28% (diff: 100%)

Merging #849 into master will not change coverage

@@             master       #849   diff @@
==========================================
  Files            21         21
  Lines          5864       5864
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           4063       4063
  Misses         1388       1388
  Partials        413        413

Powered by Codecov. Last update 7b1ab59...e50ccb7


SVG / Canvas support

Does yew support SVG dom nodes, or canvas drawing?

It's already tracked here: https://github.com/DenisKolodin/yew/issues/78

Ok, but what about svg?

@Boscop can you edit the title to "Add SVG Support" since canvas is covered by #78?

We are probably going to need koute/stdweb#196 for this to happen.
That issue looks like it will be quite difficult to complete.

This doesn't actually require stdweb support, as long as yew is okay with using raw js! blocks internally to construct the SVG nodes.

Yes, see #194. That will be sufficient for at least basic support.

This can be closed, #203 supports this.
More "full featured" SVG support will have to wait until  koute/stdweb#196


React unit tests xml reporter

@bljubisic @m-apsolon @velcrin can we port that to all other NPM based quickstarters? That would be awesome!

@velcrin @m-apsolon maybe we could try it out on Smart tomorrow, or Thursday if you have time?

I tried this approach on angular, but it won't work with Karma, so there should be a different way.


Add logo config, and complete edit page to user guide

In the user guide, I've added a section for adding logo:

this part might be redundant, as it's already in Sphinx's documentation.
my argument for still having it is some user may not be fluent enough in Sphinx, while still want to use pydata sphinx theme, which is a great theme. Without setting the logo, the navbar actually becomes not that great looking. By being explicit about the logo configuration in user guide, it makes it easier for user to find this setting.

Also, I've added additional instruction for including "edit this page". I believe this is necessary for edit this page to work:

html_theme_options = {
    "use_edit_page_button": True,
}

this part might be redundant, as it's already in Sphinx's documentation.

It's indeed certainly useful for people less familiar with sphinx!


Add ParaSwap app

Name/Description

ParaSwap
Type

New addition

Compatible Networks

- Mainnet
- Polygon
- BSC

Code for review

Not open source
IPFS hash/App URL

https://paraswap.io
Desired date

Hey @Velenir thank you for you request!
Currently we are not able to add the app in https://gnosis-safe.io/app we get a CORS Missing Allow Origin error.
Could you please check it? Maybe it involves some devops changes from your side
Thank you!

Which request do you get CORS error on?
If it's paraswap.io/manifest.json, it should be ok now, please try again.

@Velenir thanks, it works now
Off-topic thing, when playing with the app I ran into:

There are wallets (argent, legacy safe) that allow paying with gas with stables, etc. This means the ether balance could be 0 but the wallet is still usable, would be great if it would still allow you to make a transaction


Media Library: Show video without delay if missing poster

Context

I noticed that videos were not properly displayed in the media library if they have a missing poster. All one would see is a dark rectangle, because the video had opacity: 0 and there was no HiddenPosterImage to display in its place.
Summary

Fixes an issue where videos are displayed with a black rectangle instead of a preview/poster.
Changes the rendering so that videos are shown without delay if there is no poster to load in its place.
Relevant Technical Choices

To-do

User-facing changes

Before:

After:

Testing Instructions

QA

[ ] This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

Upload video to the WordPress media library (so it has no poster)
Log in as contributor (so no poster image can be generated & uploaded)
See video in the media library without a dark rectangle but an actual preview/poster

UAT

[x] UAT should use the same steps as above.

This PR can be tested by following these steps:

Reviews
Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

[ ] This PR addresses an existing issue and I have linked this PR to it in ZenHub
[x] I have tested this code to the best of my abilities
[x] I have verified accessibility to the best of my abilities (docs)
[x] I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
[x] This PR contains automated tests (unit, integration, and/or e2e) to verify the code works as intended (docs)
[x] I have added documentation where necessary
[x] I have added a matching Type: XYZ label to the PR

Related: #8449

Verified in QA
Before:

After:


Move terra-table sort indicator closer to the column name

Issue Description

The sort indicator floats to the right end of the terra-table column header name.  The sort indicator is closer to the next column.  It looks like the sort indicator is associated with the next column instead of the actual column.
The sort indicator is set on the Name column but it looks like it is associated with the Address column.
Here's an example of what it looks like.

Issue Type

[ ] New Feature
[x] Enhancement
[ ] Bug
[ ] Other

Expected Behavior

The proposal is to place the sort indicator at the end of the column name instead at the end of the column header cell.  This makes it obvious to which column the sort indicator is associate.
Current Behavior

The sort indicator floats to the right of the column header cell.

Steps to Reproduce

Set the sort indicator on a column header.

Environment

Component Version:
Browser Name and Version:
Operating System and version (desktop or mobile):

@neilpfeiffer Need desired positioning of the sort indicator.


Incorrect 'Sec-WebSocket-Accept' header value

With example  code (ASP.NET Core 2.0 ),it runs well when lauch the project in vs2017 , but  i just tried to publish and deployed in IIS, when i open the home page, there is an error in the browser console:
WebSocket connection to 'ws://localhost:8181/mqtt' failed: Error during WebSocket handshake: Incorrect 'Sec-WebSocket-Accept' header value
i changed the ws to wss , but the error still there.
I guess this may not related with MQTTNet, but i'm not familiar with this，can you give some hint how to solve this

well , finally i found websocket service was not enabled in IIS, after enabled it, i can connect

Have the same error "System.Net.WebSockets.WebSocketException: 'The 'Sec-WebSocket-Accept' header value 'C0/ZiyQOwL8AswnL0y7dRLBSBHs=' is invalid.'"  Im using core 2.1 and this is simple console client app with using System.Net.WebSockets;

@Trinitron Which version of the library do you use?

@SeppPenner this one System.Net.Sockets (4.3.0)


Using LocalAuthentication.authenticate repeatedly with short intervals in local_auth will result in a PlatformException.

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce

LocalAuthentication.authenticate to invoke the fingerprint authentication modal.
Cancel.
Repeat 1 and 2 over and over again quickly.

Expected results
Fingerprint authentication is successfully canceled.
Actual results
Throw an exception.
Code sample
Code sample
import 'package:flutter/material.dart';
import 'package:local_auth/local_auth.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: const MyHomePage(),
    );
  }
}

class MyHomePage extends StatelessWidget {
  const MyHomePage({super.key});

  @override
  Widget build(BuildContext context) {
    final LocalAuthentication auth = LocalAuthentication();
    return Scaffold(
      body: Center(
          child: TextButton(
        child: const Text("Auth"),
        onPressed: () async {
          try {
            await auth.authenticate(
                localizedReason: 'Please authenticate to show account balance',
                options: const AuthenticationOptions(biometricOnly: true));
          } catch (e) {
            showAboutDialog(context: context, children: [Text(e.toString())]);
          }
        },
      )),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration
https://github.com/flutter/flutter/assets/82094614/5831944f-23b7-4523-8bfe-5fec38722a1e

Logs
Logs
[ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: PlatformException(auth_in_progress, Authentication in progress, null, null)
#0      LocalAuthAndroid.authenticate   local_auth_android.dart:57
 <asynchronous suspension>
 #1      MyHomePage.build.<anonymous closure>     main.dart:31
<asynchronous suspension>

Flutter Doctor output
Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.7.12, on macOS 13.5 22G74 darwin-x64, locale ja-JP)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2022.3)
[✓] VS Code (version 1.81.1)
[✓] Connected device (2 available)
[✓] HTTP Host Availability

• No issues found!

Hi @yama-yeah. Thanks for filing this. Can you check out this Stack Overflow Thread that has possible solutions if any works in your use case?

Hi @dam-ease. Thanks for response.
We have tried all of those StackOverflow solutions.
The problem this time is not that I cannot authenticate, but that I cannot cancel the authentication correctly.
It may be hard to tell from the video, but this is tapping the Auth button multiple times at high speed.
If I don't hit it repeatedly, I can authenticate correctly.
The problem is only that an exception is thrown when repeatedly hitting the button.

Can you reproduce this if you disable the button until the future returns? These are async operations, and trying to start a new auth session while one is still in progress is an error. From the sample code this looks likely to be a bug in the calling code, rather than the plugin.

Hi @stuartmorgan .
In my environment, if I wait until the asynchronous processing is finished, no exception is thrown and the process is successful.
Thank you very much.

Closing as expected behavior then.


Pod "nginx-ingress-ingress-nginx-admission-create-xxxx" is in continuous ContainerCreating status

When deploying the helm chart for the ingress-nginx instance, 3 pods are created: 2 copies of the ingress-nginx-controller, and one ingress-nginx-admission pod. This latter pod never finishes creating.
Doing a describe on the pod, I see the following lines at the end:
  Type     Reason       Age                   From                                        Message
  ----     ------       ----                  ----                                        -------
  Warning  FailedMount  7m27s (x27 over 66m)  kubelet, aks-agentpool-19694923-vmss000000  Unable to attach or mount volumes: unmounted volumes=[nginx-ingress-ingress-nginx-admission-token-ngdj5], unattached volumes=[nginx-ingress-ingress-nginx-admission-token-ngdj5]: timed out waiting for the condition
  Warning  FailedMount  3m2s (x40 over 68m)   kubelet, aks-agentpool-19694923-vmss000000  MountVolume.SetUp failed for volume "nginx-ingress-ingress-nginx-admission-token-ngdj5" : secret "nginx-ingress-ingress-nginx-admission-token-ngdj5" not found

I do not remember seeing this error with the old version of the docs, which referenced the (deprecated) kubernetes-charts.storage.googleapis.com as the repo for the ingress-nginx chart.
Is there something extra that needs to be added to create a volume? Also, this is a warning, should that still prevent the pod from starting normally.
I've attached the full output of kubectl describe to this issue.
ingress-nginx-admission-ngdj5.txt

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 12009c1f-282d-2632-fac0-64b09c432833
Version Independent ID: 6052d3d4-d295-9340-b16d-4c200e34cd73
Content: Use ingress controller with static IP - Azure Kubernetes Service
Content Source: articles/aks/ingress-static-ip.md
Service: container-service
GitHub Login: @mlearned
Microsoft Alias: mlearned

There is a similar issue over on the kubernetes/ingress-nginx repo, where the workaround seems to be to disable the admissions webhook. Should that be included in the documentation?

Thanks for the ask  . At this time we are reviewing the ask and we will reply back as soon as we can .

Hi @ronaldb, if you try the workaround mentioned in the kubernetes/ingress-ngix repo in your specific case does the final ingress-nginx-admission pod get created?

Hi @ronaldb, if you try the workaround mentioned in the kubernetes/ingress-ngix repo in your specific case does the final ingress-nginx-admission pod get created?

Yes, kubectl delete -A ValidatingWebhookConfiguration nginx-ingress-ingress-nginx-admission and then deleting the admission pod created with kubectl delete pod nginx-ingress-ingress-nginx-admission-create-xxxxx solved the problem.
It didn't happen with the manifest in the sample, but with a fairly simple ingress route it triggered the validation and get the error message. Deleting the webhook validation and deleting the admission pod fixed it.

Good to hear your issue is resolved, I will close this issue now. Have a good one.

I think so too, deleting ValidatingWebhookConfiguration is not a good solution, Because it is very unsafe.But I don't know how to solve this problem.
I used the same steps and there is no problem in Kubernetes v1.17.5. But in Kubernetes v1.19.x there will be an error:
Error from server (InternalError): error when creating "/root/ingress-v1.yaml": Internal error occurred: failed calling webhook "validate.nginx.ingress.kubernetes.io": Post "https://ingress-nginx-controller-admission.ingress-nginx.svc:443/networking/v1beta1/ingresses?timeout=10s": x509: certificate is valid for kubernetes, kubernetes.default, kubernetes.default.svc, kubernetes.default.svc.cluster, kubernetes.default.svc.cluster.local, not ingress-nginx-controller-admission.ingress-nginx.svc

Chart Version:
····
cat Chart.yaml
apiVersion: v1
appVersion: 0.35.0
description: Ingress controller for Kubernetes using NGINX as a reverse proxy and
load balancer
home: https://github.com/kubernetes/ingress-nginx
icon: https://upload.wikimedia.org/wikipedia/commons/thumb/c/c5/Nginx_logo.svg/500px-Nginx_logo.svg.png
keywords:

ingress
nginx
kubeVersion: '>=1.16.0-0'
maintainers:
name: ChiefAlexander
name: ingress-nginx
sources:
https://github.com/kubernetes/ingress-nginx
version: 3.3.0
····
Is there any other solution besides deleting ValidatingWebhookConfiguration?

I've exactly the same issue. What information do you need? Is it safe to delete the webhook?
kubectl delete -A ValidatingWebhookConfiguration nginx-ingress-ingress-nginx-admission and then deleting the admission pod created with
kubectl delete pod nginx-ingress-ingress-nginx-admission-create-xxxxx solved the problem.

@braest kubectl delete -A ValidatingWebhookConfiguration nginx-ingress-ingress-nginx-admission can solve this problem, but it will cause another problem. When your ingress is configured incorrectly, the new ingress will not take effect in the future.

I deployed ingress v0.40.2 version using helm, and it can be used normally without deleting ValidatingWebhookConfiguration. At present, I have tested on k8s 1.17 1.18 1.19, all of which can be used normally, but the Pod of the ingress controller cannot be deployed on the master node.


Update uta-align for Python 3.6+

uta-align doesn't work on 3.7 (at least), and may not work on 3.6. This prevents us from making a new release. (#6)
The goal of this issue is just to get it working again on 3.6 and 3.7. Subsequent issues will deal with testing (#8) and packaging (#9).

Closed in f008691fe283b86323f1ccc81992f83e378c10cc


['Edit student details' page] Error editing email address field

Environment: Windows 10 (x64), Google Chrome v.91.0.4472.164
Reproducible: always
Preconditions

WHAT application is opened.
User with 'Admin/Secretary/Mentor' role is registered in the system.
User with 'Admin/Secretary/Mentor' role is logged in.
Select 'Student page' page.
Click on any student's edit icon

Steps to reproduce
Fill email field with "<EMAIL_ADDRESS>   " value
Actual result
Error message "Invalid email address" isn't displayed
Expected result

Error message "Invalid email address" is displayed

Labels to be added
"Bug", Priority ("pri: high"), Severity ("severity: major"), Type ("UI, "Functional")

The email field was trimmed when changes saved


Feedback on new VPN connections to remote peers

Description
This PR handles three issues:

when connected to remote peer the VPN connection status is correctly showed in the status of the related tunnelendpoint;
the status of the VPN connections is now correctly reported in the conditions of the related foreigncluster;
liqoctl connect waits for the VPN connection to be established; it also emits a warning if the endpoint addresse used for the VPN connection belongs to a private subnet (RFC 1918).

How Has This Been Tested?

[x] Existing tests

/test

/test

/test

/merge


[azopenai] Re-enable tests that were temporarily disabled

Do proper test recordings for audio so we can enable those.
Bring back vision, and also target Azure.

Overall, this brings our test coverage back up to 32% from 24%.
Fixes #21598

/azp run go - azopenai


Container: add ACTION visual hints - splits

display a visual hint on mouse-hover on action menu item.
eg:

hover on 'split horizontal' menu item will display a line indicating where the container split will happen
hove on 'close others' menu item will show a grey marching ants thick line around containers that will be closed, or something.

This issue is about the split indicator.


Add Gitea icon

Because Gitea has no centralized provider, the issuer will have to be manually set to "Gitea." I am planning on submitting further PRs and issues related to provider detections.

@calleerlandsson I'll hop on it right away! Any thoughts on #52? I'd be more than happy to design a whole host of icons for this project, but I don't want to accidentally cause problems with version control.

Alright! @calleerlandsson, the requested changes have been made.

Thanks, looks great!

Thanks, looks great!


Improve wait_keys for memory backend

It used a fallback which just polled for updates once a second, which was not very responsive and could slow down unit tests. Instead, bump a condition variable every time the storage is modified. A side benefit is that the memory backend is now thread-safe.

I recommend viewing with whitespace ignored, because a number of methods just gain an extra level of indentation thanks to a context manager.

I've just realised that there is a flaw in the synchronous implementation: monitor_keys doesn't release the lock when it yields. I'm a little surprised that this doesn't deadlock (because the code it yields to will also take the lock to get the current value), but perhaps the lock is a reentrant one. I'll rework and push a fix.


Cont. - Add Proto Message Scrubbing http filter

Commit Message: Cont. - Add Proto Message Scrubbing http filter
Additional Description:
The Proto Message Scrubbing Filter supports scrubbing scrubbed gRPC requests/responses (proto messages) as google.protobuf.Struct and storing results in the dynamic metadata envoy.filters.http.proto_message_scrubbing for later access.
Filter Config: Submitted in PR #31735
Please see the proto comments for this filter's behavior. Thanks Yan (@yanavlasov) for help in reviewing our design inside google.
This PR is in continuation with #34955 in which we added logging util lib.
Risk Level: Low
Testing: Added unit test and integration test
Docs Changes: Nil
Release Notes: Nil
Platform Specific Features: Nil

What is the background on this? This is a 6K line PR with no context. Thank you.
/wait-any

What is the background on this? This is a 6K line PR with no context. Thank you.
/wait-any

Apologies. I have added more context in the PR description.
The design for the PML filter is approved inside Google. Yan (@yanavlasov) is out sponsor for the filter.
Thank you!

/assign @yanavlasov

It looks like tests do not provide sufficient coverage.
Error: https://dev.azure.com/cncf/envoy/_build/results?buildId=178046&view=logs&j=4930ecaf-18f4-5b3c-dea3-309729c3b3ae&t=573d8780-d7b9-52e3-b4e0-a89886b0b9ff&l=5237
Cov report: https://storage.googleapis.com/envoy-pr/35689/coverage/index.html
/wait

It looks like tests do not provide sufficient coverage. Error: https://dev.azure.com/cncf/envoy/_build/results?buildId=178046&view=logs&j=4930ecaf-18f4-5b3c-dea3-309729c3b3ae&t=573d8780-d7b9-52e3-b4e0-a89886b0b9ff&l=5237
Cov report: https://storage.googleapis.com/envoy-pr/35689/coverage/index.html
/wait

I have added more unit tests. All presubmit tests seem to pass now.
Thank you!

Reviewed filter logic.
Will review scrubber logic shortly.

Thanks for the review, Shuo!
I have addressed the comments. Please let me know if it looks good.
Thank you!

I will wait for LGTMs from other reviewers and then submit the PR.
/wait

/retest

/retest-all

hi @dchakarwarti this is throwing a stack of warnings in our CI - probs the most important of them is the deprecation warnings on cc_wkt_protos
would it be possible to address these warnings upstream?
im also going to raise a pr with some minor docs cleanups

Hi Phlax!
Sure, this would require change in Proto Processing Lib. I will create a PR to update the SHA in envoy shortly.
Thanks!

hi @dchakarwarti this is throwing a stack of warnings in our CI - probs the most important of them is the deprecation warnings on cc_wkt_protos
would it be possible to address these warnings upstream?
im also going to raise a pr with some minor docs cleanups

Hi Phlax!
Sure, this would require change in Proto Processing Lib. I will create a PR to update the SHA in envoy shortly.
Thanks!

JFYI: Created https://github.com/envoyproxy/envoy/pull/35921. Thanks!


Allow cli not to use regex when trying to list object

Currently if we do list store its a regex for name and cli returns multiple results, can we have shield --raw list store s3 only match exact name vs regex matching with %
Log example for command above.
2016-02-22 15:29:16.647966763 +0000 UTC shieldd: DEBUG: Parameters: [%s3%]
2016-02-22 15:29:23.463956501 +0000 UTC shieldd: DEBUG: Executing SQL:
            SELECT s.uuid, s.name, s.summary, s.plugin, s.endpoint, -1 AS n
                FROM stores s
                WHERE s.uuid = s.uuid AND s.name LIKE $1
                ORDER BY s.name, s.uuid ASC

Reopening this issue because this behavior is only needed for other commands - so far I've discovered show target and edit target need to exact match with --raw enabled.


Gradle doesn't recognize disabled parameterized junit5 tests

Expected Behavior
If there's disabled parameterized test then after execution ./gradlew clean test there's information in console-log that this test is skipped (e.g. ParameterizedTest > parameterizedTest() SKIPPED) and also in *.xml file located in build/test-results/ there's information about this test with skipped attribute
Current Behavior
Gradle doesn't indicate disabled parameterized tests as skipped tests or as tests at all and there isn't information about this tests in console-log and in *.xml
Context

So, I'm trying to get reliable information about executed tests wich can help me to analyse what is checked and what isn't
Steps to Reproduce

clone this repo
execute ./gradlew clean test

Your Environment

Build scan URL: https://scans.gradle.com/s/otul5mw7yy75u
P.S.
I've looked into this problem and found out that junit5 works properly (It recognizes such tests). And the behaviour is correct too, if maven is used instead of gradle.

Thus the problem is on gradle side, to my knowledge

+1 for this issue. I understand, that @ParameterizedTest is on @TestTemplate policy and has a different lifecycle than the obvious @Test
Sad but true, but JUnit5 processes parameterized tests correctly (simple lifecycle in default DisabledCondition extension)
But gradle makes xml report incorrectly, while maven makes that correctly


Not correct charging power during fast charging

Describe the bug
I run evcc with a Huawei SUN2000-8-KTL-M1, an EVBox Elvi G3 wallbox and a Mini Cooper SE
Everything runs so far so good.
I'm wondering, that during fast charge process the charging power of the wallbox in the end of the charging process is higher (every times 11 kw) than the whole grid use, what doesn't make sense.

The EV decreases the charging power when the battery runs full.
When I run solar or min+solar charge mode I can't recognize that figure problem.
Is there a reason for that or do I miss here anything?
Thanks!
Donald
Steps to reproduce
Use the fast charging mode and charge the battery of the EV full
Configuration details
# open evcc at http://evcc.local:7070
network:
  schema: http
  host: <IP_ADDRESS> # .local suffix announces the hostname on MDNS
  port: 7070

log: debug
levels:
  cache: error
  ocpp: trace

# unique installation id
plant: ***

interval: 31s # control cycle interval

meters:
- type: template
  template: huawei-dongle-powersensor
  id: 1
  host: <IP_ADDRESS>
  port: 502
  usage: grid
  modbus: tcpip
  name: grid1
- type: template
  template: huawei-dongle-powersensor
  id: 1
  host: <IP_ADDRESS>
  port: 502
  usage: pv
  modbus: tcpip
  name: pv2
- type: template
  template: huawei-dongle-powersensor
  id: 1
  host: <IP_ADDRESS>
  port: 502
  usage: battery
  modbus: tcpip
  name: battery3
  storageunit: 2

chargers:
- type: ocpp
  stationid: ***
  connector: 1
  idtag: '***'
  connecttimeout: 10m
  timeout: 9m
  getconfiguration: false
  name: evbox-elvi

vehicles:
- type: template
  template: mini
  title: Mini Cooper SE
  user: ***
  password: ***
  vin: ***
  capacity: 28.9
  name: ev4

loadpoints:
- title: Carport
  charger: evbox-elvi
  mode: pv
  phases: 3
  mincurrent: 6
  maxcurrent: 16
  vehicle: ev4

site:
  title:
  meters:
    grid: grid1
    pv:
    - pv2
    battery:
    - battery3
  residualPower: 100

tariffs:
  currency: EUR
  grid:
    type: fixed
    price: 0.3031

  feedin:
    type: fixed
    price: 0.082

Log details
no error messages

[ocpp  ] TRACE 2023/12/31 15:26:45 sent JSON message to EVB-***: [3,"2d2436a5-df10-4675-b78d-40dff736b798",{"currentTime":"2023-12-31T14:26:45Z"}]
[site  ] DEBUG 2023/12/31 15:26:53 ----
[lp-1  ] DEBUG 2023/12/31 15:26:53 charge power: 0W
[site  ] DEBUG 2023/12/31 15:26:55 pv power: 0W
[site  ] DEBUG 2023/12/31 15:27:03 battery soc: 2%
[site  ] DEBUG 2023/12/31 15:27:03 battery power: -47W
[site  ] DEBUG 2023/12/31 15:27:06 grid power: 740W
[site  ] DEBUG 2023/12/31 15:27:12 grid currents: [0.29 0.18 3.76]A
[site  ] DEBUG 2023/12/31 15:27:14 battery has priority at soc 2% (< 20%)
[site  ] DEBUG 2023/12/31 15:27:14 site power: 840W
[lp-1  ] DEBUG 2023/12/31 15:27:14 charger status: B
[lp-1  ] DEBUG 2023/12/31 15:27:14 set ev4 plan soc: 0 @ 0001-01-01 00:53:28 +0053 LMT
[lp-1  ] DEBUG 2023/12/31 15:27:14 pv charge current: 0A = 0A + -1.22A (840W @ 3p)
[site  ] DEBUG 2023/12/31 15:27:24 ----
[lp-1  ] DEBUG 2023/12/31 15:27:24 charge power: 0W
[site  ] DEBUG 2023/12/31 15:27:27 pv power: 0W
[site  ] DEBUG 2023/12/31 15:27:30 battery soc: 2%
[site  ] DEBUG 2023/12/31 15:27:30 battery power: -51W
[site  ] DEBUG 2023/12/31 15:27:31 grid power: 739W
[site  ] DEBUG 2023/12/31 15:27:34 grid currents: [0.3 0.17 3.81]A
[site  ] DEBUG 2023/12/31 15:27:35 battery has priority at soc 2% (< 20%)
[site  ] DEBUG 2023/12/31 15:27:35 site power: 839W
[lp-1  ] DEBUG 2023/12/31 15:27:35 charger status: B
[lp-1  ] DEBUG 2023/12/31 15:27:35 set ev4 plan soc: 0 @ 0001-01-01 00:53:28 +0053 LMT
[lp-1  ] DEBUG 2023/12/31 15:27:35 pv charge current: 0A = 0A + -1.22A (839W @ 3p)
[ocpp  ] TRACE 2023/12/31 15:27:45 received JSON message from EVB-***: [2,"2d2436e1-df10-4675-b78d-40df29f257fe","Heartbeat",{}]
[ocpp  ] TRACE 2023/12/31 15:27:45 sent JSON message to EVB-***: [3,"2d2436e1-df10-4675-b78d-40df29f257fe",{"currentTime":"2023-12-31T14:27:45Z"}]
[site  ] DEBUG 2023/12/31 15:27:55 ----
[lp-1  ] DEBUG 2023/12/31 15:27:55 charge power: 0W
[site  ] DEBUG 2023/12/31 15:27:57 pv power: 0W
[site  ] DEBUG 2023/12/31 15:28:00 battery soc: 2%
[site  ] DEBUG 2023/12/31 15:28:00 battery power: -48W
[site  ] DEBUG 2023/12/31 15:28:02 grid power: 738W
[site  ] DEBUG 2023/12/31 15:28:07 grid currents: [0.3 0.17 3.8]A
[site  ] DEBUG 2023/12/31 15:28:07 battery has priority at soc 2% (< 20%)
[site  ] DEBUG 2023/12/31 15:28:07 site power: 838W
[lp-1  ] DEBUG 2023/12/31 15:28:07 charger status: B
[lp-1  ] DEBUG 2023/12/31 15:28:07 set ev4 plan soc: 0 @ 0001-01-01 00:53:28 +0053 LMT
[lp-1  ] DEBUG 2023/12/31 15:28:07 pv charge current: 0A = 0A + -1.21A (838W @ 3p)
[site  ] DEBUG 2023/12/31 15:28:26 ----
[lp-1  ] DEBUG 2023/12/31 15:28:26 charge power: 0W
[site  ] DEBUG 2023/12/31 15:28:30 pv power: 0W
[site  ] DEBUG 2023/12/31 15:28:34 battery soc: 2%
[site  ] DEBUG 2023/12/31 15:28:34 battery power: -49W
[site  ] DEBUG 2023/12/31 15:28:36 grid power: 745W
[site  ] DEBUG 2023/12/31 15:28:39 grid currents: [0.29 0.17 3.78]A
[site  ] DEBUG 2023/12/31 15:28:40 battery has priority at soc 2% (< 20%)
[site  ] DEBUG 2023/12/31 15:28:40 site power: 845W
[lp-1  ] DEBUG 2023/12/31 15:28:40 charger status: B
[lp-1  ] DEBUG 2023/12/31 15:28:40 set ev4 plan soc: 0 @ 0001-01-01 00:53:28 +0053 LMT
[lp-1  ] DEBUG 2023/12/31 15:28:40 pv charge current: 0A = 0A + -1.22A (845W @ 3p)
[ocpp  ] TRACE 2023/12/31 15:28:45 received JSON message from EVB-***: [2,"2d24371d-df10-4675-b78d-40df72acf863","Heartbeat",{}]
[ocpp  ] TRACE 2023/12/31 15:28:45 sent JSON message to EVB-***: [3,"2d24371d-df10-4675-b78d-40df72acf863",{"currentTime":"2023-12-31T14:28:45Z"}]
[site  ] DEBUG 2023/12/31 15:28:57 ----
[lp-1  ] DEBUG 2023/12/31 15:28:57 charge power: 0W
[site  ] DEBUG 2023/12/31 15:28:58 pv power: 0W
[site  ] DEBUG 2023/12/31 15:29:01 battery soc: 2%
[site  ] DEBUG 2023/12/31 15:29:01 battery power: -50W
[site  ] DEBUG 2023/12/31 15:29:02 grid power: 749W
[site  ] DEBUG 2023/12/31 15:29:07 grid currents: [0.29 0.18 3.81]A
[site  ] DEBUG 2023/12/31 15:29:09 battery has priority at soc 2% (< 20%)
[site  ] DEBUG 2023/12/31 15:29:09 site power: 849W
[lp-1  ] DEBUG 2023/12/31 15:29:09 charger status: B
[lp-1  ] DEBUG 2023/12/31 15:29:09 set ev4 plan soc: 0 @ 0001-01-01 00:53:28 +0053 LMT
[lp-1  ] DEBUG 2023/12/31 15:29:09 pv charge current: 0A = 0A + -1.23A (849W @ 3p)
[site  ] DEBUG 2023/12/31 15:29:28 ----
[lp-1  ] DEBUG 2023/12/31 15:29:28 charge power: 0W
[site  ] DEBUG 2023/12/31 15:29:30 pv power: 0W
[site  ] DEBUG 2023/12/31 15:29:33 battery soc: 2%
[site  ] DEBUG 2023/12/31 15:29:33 battery power: -47W
[site  ] DEBUG 2023/12/31 15:29:34 grid power: 749W
[site  ] DEBUG 2023/12/31 15:29:37 grid currents: [0.3 0.17 3.79]A
[site  ] DEBUG 2023/12/31 15:29:38 battery has priority at soc 2% (< 20%)
[site  ] DEBUG 2023/12/31 15:29:38 site power: 849W
[lp-1  ] DEBUG 2023/12/31 15:29:38 charger status: B
[lp-1  ] DEBUG 2023/12/31 15:29:38 set ev4 plan soc: 0 @ 0001-01-01 00:53:28 +0053 LMT
[lp-1  ] DEBUG 2023/12/31 15:29:38 pv charge current: 0A = 0A + -1.23A (849W @ 3p)

What type of operating system are you running?
Linux
Version
0.123.2

Does your charger even have a meter? If not we can only guess the charge power.


1.20.1 Crash from ravager

Mod Loader
Forge 47.1.3
Mod version
<IP_ADDRESS>
Issue description
Summoning a goety ravager crashes game and keeps world from loading after the fact.
Link or Post Log Files
https://pastebin.com/RiyfenQb
Steps to reproduce
Open world
Summon ravager (via commands crashes too)
Crash
Additional information
No response

(You will see a lot of mods in the list, all are disabled except curios and goety. Just for clarity)

Thanks! Fixed this and other Ravager and server related bugs on the latest update!


Add new gen-model

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


onColumnValueChanged Not Accurate

onColumnValueChanged doesn't seem to work properly. With the tool panel open, I performed the steps below:

Drag Column A to Values. I see a ColumnChangeEvent fired with the columns and column properties set. The column's aggFunc equals sum. This works well.
Change the aggFunc to avg via the UI. I see a ColumnChangeEvent fired, but it doesn't have columns or column properties.
Drag Column A in values back  to the column list. I see a ColumnChangeEvent fired with columns and column properties set, but the column's aggFunc still equals the last value. Shouldn't this be null now?

Shouldn't this be null now?
no.
there are two things at play:
1 - is the column one of the columns currently used in an aggregation. to check this, you get the list of value columns from the columnApi.getValueColumns()
2 - what is the agg func - to check this, you call column.getAggFunc()
when you add a column to the valueColumns[], if there is no aggFunc, it sets one up by default.
when you remove a column from valueColumns, it doesn't touch the aggFunc, so that it will be there if you later add to the set of valueColumns again.

Shouldn't the ColumnChangeEvent fired at least have the column and columns properties set in step 2?

changed, column now included in event, will be in next release.
however i observe, the same event is used for both interactions i mention above. to be correct, there should be a separate event for actions 1 and 2. hindsight.


How long does inference take?

Hello developers,
I followed the guidelines in your ReadMe to generate the dense representations for MS Marco Document Ranking, using the MaxP checkpoint that you provide. My process has been running for more than 80 hours, on a server with a T4 Tesla GPU and  Intel Xeon Platinum CPU (looking at htop, I observe that it is running with a single thread). Is such a long inference time normal? Am I missing something to speedup this process?

Hi, do you find the BM25 index generation?