Zip data

Description
Attempting to clean up uploading branch. Not sure what's the best way to handle it.
I do think as a team, we could use knex migrations that mimic the production database, and create local databases that we can control and delete all well for testing purposes.
I started to create a different file structure for it so I could easily implement tests.  I am not sure that we will want to keep this branch at all.
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Change Status

[ ] Complete, tested, ready to review and merge
[ ] Complete, but not tested (may need new tests)
[ ] Incomplete/work-in-progress, PR is for discussion/feedback

How Has This Been Tested?

[ ] Test A
[ ] Test B

Checklist

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] There are no merge conflicts

After the presentation I asked TJ about PP so that I could get a better idea of

how to spin up a local test db

how everything interacts with each other, because it is very large and unwieldy currently

also volunteered to write tests for it as it seems to only work once when added to development and returns status 500 even when successful

Having a group chat about this is something I would very much be interested in because it still needs polishing as the crown jewel of the apps functionality.

On Feb 24, 2020, at 5:53 PM, briannaKeune<EMAIL_ADDRESS>wrote:
Description
Attempting to clean up uploading branch. Not sure what's the best way to handle it.
I do think as a team, we could use knex migrations that mimic the production database, and create local databases that we can control and delete all well for testing purposes.
I started to create a different file structure for it so I could easily implement tests. I am not sure that we will want to keep this branch at all.
Type of change
Please delete options that are not relevant.
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
Change Status
Complete, tested, ready to review and merge
Complete, but not tested (may need new tests)
Incomplete/work-in-progress, PR is for discussion/feedback
How Has This Been Tested?
Test A
Test B
Checklist
My code follows the style guidelines of this project
I have performed a self-review of my own code
My code has been reviewed by at least one peer
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
There are no merge conflicts
You can view, comment on, or merge this pull request online at:
https://github.com/Lambda-School-Labs/Groa-be/pull/6 https://github.com/Lambda-School-Labs/Groa-be/pull/6
Commit Summary
trying to remove .env file from github
tried to mimic Niki's DB
ratings model test setup
prepTestDB setup
File Changes
D .env https://github.com/Lambda-School-Labs/Groa-be/pull/6/files#diff-0 (1)
A database/migrations/20200224125638_users.js https://github.com/Lambda-School-Labs/Groa-be/pull/6/files#diff-1 (18)
A database/migrations/20200224143948_ratings.js https://github.com/Lambda-School-Labs/Groa-be/pull/6/files#diff-2 (22)
A database/migrations/20200224144205_reviews.js https://github.com/Lambda-School-Labs/Groa-be/pull/6/files#diff-3 (26)
A database/migrations/20200224144349_User_watched.js https://github.com/Lambda-School-Labs/Groa-be/pull/6/files#diff-4 (21)
A database/migrations/20200224145616_User_WatchList.js https://github.com/Lambda-School-Labs/Groa-be/pull/6/files#diff-5 (21)
A helpers/prepTestDB.js https://github.com/Lambda-School-Labs/Groa-be/pull/6/files#diff-6 (8)
A imported_user_data/ratings/model.js https://github.com/Lambda-School-Labs/Groa-be/pull/6/files#diff-7 (0)
A imported_user_data/ratings/model.test.js https://github.com/Lambda-School-Labs/Groa-be/pull/6/files#diff-8 (11)
A imported_user_data/ratings/router.js https://github.com/Lambda-School-Labs/Groa-be/pull/6/files#diff-9 (0)
A imported_user_data/ratings/router.test.js https://github.com/Lambda-School-Labs/Groa-be/pull/6/files#diff-10 (0)
M package.json https://github.com/Lambda-School-Labs/Groa-be/pull/6/files#diff-11 (2)
Patch Links:
https://github.com/Lambda-School-Labs/Groa-be/pull/6.patch https://github.com/Lambda-School-Labs/Groa-be/pull/6.patch
https://github.com/Lambda-School-Labs/Groa-be/pull/6.diff https://github.com/Lambda-School-Labs/Groa-be/pull/6.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/Lambda-School-Labs/Groa-be/pull/6?email_source=notifications&email_token=AE3DXBAZXJFO54QC7A5YDEDRERFXNA5CNFSM4K2U3SV2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IP4QY5Q, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE3DXBDMTZWRZ2PP32CTU6DRERFXNANCNFSM4K2U3SVQ.

I'm going to close this PR and delete the branch since we've moved on and have taken a different route.

Agreed, the work done on it has it’s history intact through other branches,
if somewhat convoluted, is still there.
On Fri, Feb 28, 2020 at 12:23 AM briannaKeune<EMAIL_ADDRESS>wrote:

Closed #6 https://github.com/Lambda-School-Labs/Groa-be/pull/6.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Lambda-School-Labs/Groa-be/pull/6?email_source=notifications&email_token=AE3DXBGTBQPYRSKJD5IIW7TRFCNUXA5CNFSM4K2U3SV2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOW6OGNXY#event-3080480479,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE3DXBBDCEJQ4OHM42SZDKLRFCNUXANCNFSM4K2U3SVQ
.

--
~  CM


PowerToys Run Calculator yields no result unless files are indexed.

Microsoft PowerToys version
0.65.0
Installation method
PowerToys auto-update
Running as admin
No
Area(s) with issue?
PowerToys Run
Steps to reproduce

After enabling enhanced indexing:

✔ Expected Behavior
I would expect to see the product, 40,000.
❌ Actual Behavior
No product is shown. The same goes for any math operation.
Other Software
No response

It's the indexer/search plugin that giving you the first result, I do believe there's an option to disable that?

Yes there is an option in the plugin settings of the windows search plugin.
@michaelbehan
We have a setting on the settings page for PT Run to define the number of results shown on the screen. What value did you set there? /needinfo


Middleware for Authentication using OAuthPrompt using AADv2

I would like to authenticate the user for the very first interaction of user until they sign out from the Bot. Can we leverage middleware to authenticate the bot user and validate token for each turn? Logged in UserProfile will be used for all the activity? Could you please provide the sample code?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b036a2b2-13f9-d686-3f12-0fcebed9c67d
Version Independent ID: 19184286-cff6-eef7-13f8-29bc6ba6720e
Content: Middleware - Bot Service
Content Source: articles/v4sdk/bot-builder-concept-middleware.md
Service: bot-service
Product: bot-framework
GitHub Login: @ivorb
Microsoft Alias: v-ivorb

@amistry79 - Just the same question I came here for. Did you manage to get this AuthMiddleware in place?

No, I am still using the OAuthCard and it is inconsistent user experience

We'll have an updated authentication sample in a couple weeks. It still won't address this scenario directly, but it might be easier to work from.
An alternative to middleware would be to check specific activity types (such as UpdateConversation and Message) at the top of the turn handler to see if the user is logged in, and if not, start the OAuth sign-n process.

Also, the sign-in experience will vary by channel, simply because channel support for this feature varies.


cmdLineTest_J9test_firstThreadName run fail by openjdk8

Describe the bug
cmdLineTest_J9test_firstThreadName run fail by openjdk8
To Reproduce
http://ci.dragonwell-jdk.io/job/Test_openjdk8_dragonwell_extended.functional_x86-64_linux/323/consoleFull
Expected behavior
This test should not run by openjdk
Screenshots

Additional context

https://github.com/eclipse-openj9/openj9/issues/16641

thanks @sendaoYan - nice catch!


nixos/system-environment: use pam syntax for home variable

Motivation for this change
See https://github.com/NixOS/nixpkgs/pull/70137#discussion_r331746615, this is actually a pretty important thing that was overlooked.
Cc @dtzWill
Things done
Running this now.

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @

LGTM, thanks!

Thanks for the quick responses so we could fix it quick :sparkles:


ElectronicArts.EADesktopBeta version <IP_ADDRESS>25

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@OfficialEsco Hope this was ok for me to go ahead and update it to mark it as a Beta.

As explained in #16229 there is no reason for this because they don't have a difference branch, its a permanent Open Beta and they promote it as a replacement for Origin as its already more stable then Origin.
Those we download EA Desktop already know its a Beta and have ditched Origin a long time ago.


Create swarm.md

Add code style for command and its output.

Proposed changes

Unreleased project version (optional)

Related issues (optional)

Thanks, @scjane this is great


Name of players reflected without entering their plot

Issue description
When leaving a plot, the name of the plot of another user (who is next to it) appears without having entered it

Expected result: What were you expecting to happen? That until you enter the player's plot, his name should not be reflected
Actual result: What actually happened? That his name is reflected without entering his plot

Steps to reproduce the issue
Link to the video: https://streamable.com/fjsds2
OS and versions

Plugin Version: dev 756
PocketMine-MP: 3.22.2
PHP: 7.4
Game version: Win10

Other Plugins
So many

If you remove all other plugins, does the issue still occur? Yes/No (delete as appropriate) I can't test it because I don't have another server where to do it
If the issue is not reproducible without other plugins:

Have you asked for help in the community discord before creating an issue?
Can you provide sample, minimal reproducing code for the issue? If so, paste it in the bottom section.

Console error, backtrace or other files
No error

For more information, my plots are 100x100, I do not know if that affects something

I think this commit triggerred the error.

That's a big problem with the if's for the plot sides!! Players can build out of their plots because the check for it doesn't work right.
This is a very important bug and it should be fixed fast.

In this commit plot walls for merges should be fixed and that's working but now we have these bug.


ApiClient tokenUrl value is hardcoded

Preflight checklist

[X] I could not find a solution in the existing issues, docs, nor discussions.
[X] I agree to follow this project's Code of Conduct.
[X] I have read and am following this repository's Contribution Guidelines.
[ ] This issue affects my Ory Cloud project.
[ ] I have joined the Ory Community Slack.
[ ] I am signed up to the Ory Security Patch Newsletter.

Describe the bug
In the class sh.ory.hydra.ApiClient of the SDK v1.9.0, we can find this line:
String tokenUrl = "https://hydra.demo.ory.sh/oauth2/token";
I can't see how to override it with the url of my local instance of Hydra. I should be able to do so. Obviously this prevents us from adopting Hydra as a solution.
Reproducing the bug
`
// Import classes:
import sh.ory.hydra.ApiClient;
import sh.ory.hydra.ApiException;
import sh.ory.hydra.Configuration;
import sh.ory.hydra.models.*;
import sh.ory.hydra.api.AdminApi;
public class Example {
public static void main(String[] args) {
ApiClient defaultClient = Configuration.getDefaultApiClient();
defaultClient.setBasePath("http://localhost");
AdminApi apiInstance = new AdminApi(defaultClient);
String loginChallenge = "loginChallenge_example"; // String |
try {
  LoginRequest result = apiInstance.getLoginRequest(loginChallenge);
  System.out.println(result);
} catch (ApiException e) {
  System.err.println("Exception when calling AdminApi#getLoginRequest");
  System.err.println("Status code: " + e.getCode());
  System.err.println("Reason: " + e.getResponseBody());
  System.err.println("Response headers: " + e.getResponseHeaders());
  e.printStackTrace();
}

}
}`
Relevant log output
Exception when calling AdminApi#getLoginRequest
Status code: 0
Reason: null
Response headers: null
sh.ory.hydra.ApiException: java.io.IOException: org.apache.oltu.oauth2.common.exception.OAuthSystemException: javax.net.ssl.SSLPeerUnverifiedException: Hostname hydra.demo.ory.sh not verified:
    certificate: sha256/rfyDOVno51fo8v+E2IF9CfHWiqLb51V+rFspoxSNO1s=
    DN: CN=*.numericable.fr
    subjectAltNames: [*.numericable.fr, numericable.fr]
	at sh.ory.hydra.ApiClient.execute(ApiClient.java:988)
	at sh.ory.hydra.api.AdminApi.getLoginRequestWithHttpInfo(AdminApi.java:1775)
	at sh.ory.hydra.api.AdminApi.getLoginRequest(AdminApi.java:1752)

### Relevant configuration

_No response_

### Version

SDK v1.9.0

### On which operating system are you observing this issue?

Other

### In which environment are you deploying?

Docker

### Additional Context

_No response_

I believe this should be fixed in the newly released version of the SDK!

Looks like this is still a problem

Any update on this?

I no longer see this issue on 2.x (although it was likely fixed in a much earlier version).


amp stack ls error

'amp stack ls' is not able to display the status "partially running" or "failed" for a stack
When we have a failed stack amp platform monitor display a stack but 'amp stack ls -a' displays 'no stack available'
So we cannot stop it and remove it as we are not able to get its ID.

thank you for the report @AlexandreDemailly
Can you please provide the version you use (if not a release, which branch or which commit of master branch), and which context (local, cluster, AWS, etc)?

The point is that a amp stack is considered "running" when all of its services have been created, no matter if these services failed after a while.
The fix could be to re-assess the services status when the command "stack ls" is executing for all stack listed in order to be able to display ones reflecting the current reality.
It's related to #411, because "depending on" ask to develop functions able to asses real service status as it has been done for the "amp pf start command". So at the end: have the same behavior for user stack than for the infra stack.

Obsolete, amp doesn't manage stacks anymore


Backward compatibility on saved config.

Feature request
Model trained on newer peft should be available on older version when possible.
Motivation
We found model trained on peft 0.10 cannot be loaded with older peft due to unknown entry layer_replication in adapter config json.
This entry is never used by us so it's probably just the default value.
Default value like this should not be exported.
Your contribution
N/A

What you are asking is not backwards compatibility, but forward compatibility. The case you describe is backwards compatible.
Removing defaults is not always a good idea, because it means we cannot change the defaults in the future if we find it necessary. Being explicit is better here.
For your use case, you can just manually delete the attributes you don't need and it should work.

It is backward compatibility on the model file schema.
New version of runtime should avoid breaking change to the resulting model.
And regarding changing default in the future, it’s better for future version to worry about that as part of its compatibility.
IMO it’s simply a bad idea to change implicit default without introducing a new API because that’s a breaking change.
If there’s a need for variable default, be explicit, have something like “auto” for user to enroll into that rolling behavior, or have a util func to generate the default value of that version.


[WIP] Style1 tables in Storage -> File Shares converted to patternfly

Parent issue: #3139

@dclarizio Looks good


NTR: mesothelial cell of epicardium

We would like to request this NTR to annotate some biosamples.
label: mesothelial cell of epicardium
definition: A mesothelial cell that is part of the epicardium
part_of: UBERON_0002348 (epicardium)
is_a: CL_0000077 (mesothelial cell)
Thank you for your help!

Should be easy to add this.  Should have  logical def:
intersection_of: CL_0000077 (mesothelial cell)
intersection_of: part_of UBERON_0002348 (epicardium)


Fixing file upload is null

Fixing issue where the previous file field was being set to null if no new file was selected

@secondnetwork Thanks man. I just fixed styleCI issues. When the test finishes I'll merge this in 👍


Git clone issue

The command provided in Readme.md for git repo, says 'Permission denied' while cloning it.
The link should be<EMAIL_ADDRESS>Notice the '/' instead of ':'
$ git clone git@github.com:rohan20/flutter-chat-app.git
$ cd flutter-chat-app/
$ flutter run

I have opened a pull request regarding this


Update "Get Started" buttons to correct sentence case across newdot 'Get started'

Hello there! As proposed in this slack post https://expensify.slack.com/archives/C036QM0SLJK/p1718278065797849 stemming from the onboarding full throttle (Manage my team's expenses intent), we would like to change the casing of any and all Get started buttons.
We would like to change the copy.
Current copy:
Get Started
Proposed copy:
Get started
@LLPeckham included notes here
@nikkiwines
suggested a fix for this which is create a new variable in onboarding here (like so: getStarted: 'Get started', (and also in the corresponding section in es.ts) and then replace the usage here to be confirmText={translate('onboading.getStarted')}

Assigning myself for now

Closing this as Lindsey worked on the PR to change the Get started copy yesterday.


[IO] Upgrade mariadb jdbc driver version to address vulnerabilities

Motivation
OWASP dependency check fails with this error:
Error:  mariadb-java-client-2.6.0.jar: CVE-2020-28912, CVE-2021-46668, CVE-2021-46669, CVE-2021-46666, CVE-2021-46667, CVE-2021-46664, CVE-2021-46665, CVE-2021-46662, CVE-2021-46663, CVE-2021-46661

Modifications

upgrade mariadb jdbc driver version to 3.0.3

It looks like a false positive, https://github.com/jeremylong/DependencyCheck/issues/2863 . It seems that the check added by #13972 has never passed? @dlg99 Can you confirm?

@lhotari the check did pass before it was merged. The threat DB updates independently, sometimes several times a day and owasp plugin may misdetect something. If these are indeed false positives they can be suppressed https://github.com/apache/pulsar/blob/master/src/owasp-dependency-check-suppressions.xml

I'll add that OWASP check had matched server vulnerabilities against client java libraries (e.g. clickhouse db server were matched to clickhouse-jdbc driver etc.) These happen due to too broadly matching patterns in the threat DB, if I understand correctly, and are safe to suppress.

Any updates?

closing this since #14593 resolves the OWASP dependency check false alarm.


Add tags to module

close #2101

I don't have any error locally on reactapp.

Need to add those tags in Rest response (so we can use them in the frontend)

I wonder if it wouldn't be better if the tags were managed at the RestJHipsterModule and JHipsterModuleResource level rather than JhipsterModule? tags do not add anything to jhipster module or else I have to find a way to access jhipsterModule but it is not yet build when the resource is created

Yep, I think it's better to keep it in JHipsterModuleResource

Is it ready to be merged @antarus ?

No,i need to work on it

The rework was a bit long :D

done

Should be good
Thanks @antarus for the work
Thanks @DamnClin for the review


Ensure mongo-persistent-scc is deleted in e2e tests

Sometimes e2e tests are leaving mongo-persistent-scc behind remove this SCC if exists before running e2e tests.
@redhat-cop/mdt

/LGTM


"START SIMULATOR" title confusing

The new "START SIMULATOR" button is confusing, as we already use the term "simulator" to refer to the micro:bit simulator. I think the purpose of this button is to start the Jacdac simulator, correct? We should probably refer to Jacdac somehow. Also, pushing the button right now does nothing - I have no way to add virtual devices.

Ah, when I go to full screen, after pushing "START SIMULATOR" I see the full iframe. Somehow in the default view, the iframe is not being resized correctly.

Button gone.


use full file path to check if a file has a buffer

small fix for https://github.com/bastibe/org-static-blog/issues/20

Cool, thank you!


Issue with rendering ligatures in a PDF

In the document below, the "fi" ligatures are not rendered properly by pdf.js:
http://hse-econ.fi/tervio/MediocritiesAndSuperstars.pdf
See, e.g., "self nance" rather than "self finance" in the abstract.
I observed the issue using FF 13.0a1 (2012-02-20) and pdf.js 0.2.285.  This may be related to Issue #1232.

The OTS output:
Outputs differ in content
Dumping results to out1.tff and out2.tff

Fixed by #1244


how to get with and height of picture after glide traitement

Hello !
I need to add on <img src> the with and the height of picture.
Glide have a function to get this data when picture is on cache folder ?

Doesn't the preset you're using or the configuration you're inputting contain that information somehow? :) Else you'll have to read it directly from the resulting file...

The image


Arrow-ized FRP

I'd like to order a JSOxford talk for the autumn on Arrow-ized FRP please

https://twitter.com/richdevans/status/516497513285947392

I'm still keen on this topic and I'm good to talk about it myself. But, I'd like to lead into it with a talk about functional programming in JavaScript first using the Ramda.js library.
If these topics have traction then I'll run with them for the June meetup? :golf:
Conversely, if they don't have any traction -- the group might prefer to focus on other themes, and that's fine -- then let's bin this old issue. :smile:

I'm interested in this and functional JavaScript. I think having a talk about functional followed by this would be a pretty good set up.

I've logged this in the talks project - https://github.com/jsoxford/jsoxford.github.com/projects/1
@richdouglasevans are you still interested in doing this at some point?

(I've closed this issue for now to try and keep everything together in the github project)


Doesn't actually do anything

v2.0.0-beta.3
Linux Mint 19.3 amd64
I do not see anything meaningfull in the logs
-1590245904127.log

Pressing "Flash!" asks for password, but doesn't actually do anything after that.

I'm also seeing this behavior on Kubuntu 18.04.


brew bottle: remove HOMEBREW_NO_PATCHELF_RB_WRITE

This should revert this commit: https://github.com/Homebrew/homebrew-test-bot/pull/525#issuecomment-769695114 which disabled our Ruby implementation of patchelf when building in CI.  Now that we are confident this is working correctly correctly, we can allow the Ruby patchelf to be used in CI as well.

Thanks @danielnachun!

cc @iMichka brew bottle is now using patchelf.rb. Heads up in case you see any weirdness.


Do not use IoRead in public API

The rustdoc for BincodeRead currently looks like:
pub trait BincodeRead<'storage>: IoRead { }

IoRead is a renamed import that you use internally. Since this is user-facing, it should use the standard names for std types.

Same thing for IoError.
pub enum ErrorKind {
    IoError(IoError),
    InvalidEncoding {
        desc: &'static str,
        detail: Option<String>,
    },
    SizeLimit,
    SequenceMustHaveLength,
    Custom(String),
}


Validate v1 and v2 charts for  RHEL 7.9

Validated V2 charts for RHEL 7.9 Selinux enabled clusters.

The following v2 charts have been validated on Rancher v2.5.5. Installs and P0 use cases pass on an RHEL 7.9 install with Selinux enabled.
OPA Gatekeeper: v3.2.101
Monitoring: v9.4.202
Istio: v1.7.301
CIS: v1.0.300
Logging: v3.8.201
Longhorn: v1.1.000

The following v2 charts have been validated on Rancher v2.5.5. Installs and P0 use cases pass on an RHEL 7.9 install with Selinux enabled.
OPA Gatekeeper: v3.2.101
Monitoring: v9.4.202
Istio: v1.7.301
CIS: v1.0.300
Logging: v3.8.201
Longhorn: v1.1.000

The following v1 charts are validated with v2.5.5. Installs and P0 use cases pass on an RHEL 7.9 install with Selinux enabled.
Monitoring: v0.2.0
CIS: RKE-CIS-1.5
Pipelines: pipeline-tools:v0.1.15
Alerts: cluster-alerting:v0.2.0
Logging: fluentd:v0.1.22
Istio 1.5.9
The UI has a warning that the following charts have been depreciated as of Rancher v2.5.0
Istio
Alerts
Logging
Monitoring
Pipelines
Ex:

The following v1 charts are validated with v2.5.5. Installs and P0 use cases pass on an RHEL 7.9 install with Selinux enabled.
Monitoring: v0.2.0
CIS: RKE-CIS-1.5
Pipelines: pipeline-tools:v0.1.15
Alerts: cluster-alerting:v0.2.0
Logging: fluentd:v0.1.22
Istio 1.5.9
The UI has a warning that the following charts have been depreciated as of Rancher v2.5.0
Istio
Alerts
Logging
Monitoring
Pipelines
Ex:

Currently blocked on validating Logging: fluentd:v0.1.22
https://github.com/rancher/rancher/issues/30949

Currently blocked on validating Logging: fluentd:v0.1.22
https://github.com/rancher/rancher/issues/30949

Will continue to track Logging v2 for RHEL 7.9 in a separate issue:
https://github.com/rancher/rancher/issues/30949
Closing this issue.


Sized versions of duk_{get,require}_[u]int()

API documentation for duk_get_uint() says:

The coercion is also different from Ecmascript ToUint32() coercion because the full range of the native duk_uint_t is allowed (which may be more than 32 bits).

This is convenient in most cases, but there were times I wanted to ensure the value is clamped to exactly 32 bits as if by ToUint32(), regardless of the native int size (which is 64 bits on some platforms).  So guaranteed-size versions of these APIs would be nice to have.

Hmm, ToUint32() doesn't clamp it's result but rather applies a modulo operation.
That's why I think duk_get_uint() etc should be renamed to duk_get_uint_clamped() or something because that clamping behavior differs from the usual integer coercions in Ecmascript so it's a bit surprising.
But taking this into account, you'd like to have e.g. duk_get_uint32_clamped()?

Yeah, that's what I meant.  I should have realized ToUintX() operations were modulo since they are used with typed arrays :)

Typed arrays, and in ES5, bitwise operations.

Regarding the clamping behavior: Despite Ecmascript semantics, I think clamping makes the most sense for the public API, so I don't know that the API calls need a _clamped suffix in their names.  I can't vouch for others, but I can say that the current behavior wasn't surprising to me at least.  I would have found modulo behavior to be more surprising, to be honest.

I'm sure expectations differ here. I don't think clamping is odd behavior as such, but I find it inconsistent that duk_to_uint32() is modulo based and duk_to_uint() is clamping. From outward appearances one might conclude that the only difference is the range or final type only which isn't the case.

I guess the reason I find the modulo behavior odd is that I generally think of typical Ecmascript semantics where overflow = infinity.  The wrapping semantics are used only in those scenarios where that makes more sense (typed arrays and bitwise ops as you point out), otherwise saturation is the "default" behavior.

That said, I don't really mind if you want to rename the API calls.  I'd just like sized versions. :)

Here's one use case in my system.sleep() API implementation:
https://github.com/fatcerberus/minisphere/blob/master/src/engine/pegasus.c#L1216-L1220
That code will break if the user passes a value greater than 4G (admittedly probably not the dominant use case :) and the native int size is 64-bit.  Here clamping to 32-bit is preferred, but to do that I currently have to:
double value = duk_require_number(ctx, 0);
uint32_t timeout = (uint32_t)(value < 0xffffffff ? value : 0xffffffff);

Which is more code, an extra throwaway variable, and includes an awkward-looking double->int cast.

Yeah :) I'm not yet sure how to proceed so need to ponder a bit.
One approach would to add variants for duk_to_uint32_modulo() and duk_to_uint32_clamped() so that it would be explicit in the call site. Then just map the existing call using a macro and maybe deprecate it.
But then... if the API gets an explicit clamped API call, it'd also be natural to allow the clamp limits to be defined: they're not always the integer limits. For example, working with a timeout value it would be convenient to say:
long timeout = (long) duk_to_int_clamped(ctx, 1, 10, 20000); /* Clamp timeout to [10ms, 20000ms] */

There's also a small semantic difference between duk_to_uint32() and duk_to_uint() by the way: the latter does a duk_to_number() coercion followed by clamping and integer conversion. However, the value on the value stack is the duk_to_number() coerced value, i.e. may contain fractions, be NaN, etc.
duk_to_uint32() is Ecmascript defined and the coercion result is also stored on the value stack.
One could try to make duk_to_uint() to reutrn the same value as is left on the value stack. But for 64-bit values DUK_INT_MAX actually cannot be represented as an IEEE double, so that couldn't be then used as a clamp limit! One could return it from the API but a different value (close to it) would be left on the value stack. This would also be very confusing :)


9/2/2021 Publish

Docs Build status updates of commit 20a62de:
:warning: Validation status: warnings

File
Status
Preview URL
Details

2017-03-09-profile/docs-ref-autogen/TOC.yml
:warning:Warning
View (azure-cli-2017-03-09-profile)
Details

2018-03-01-hybrid/docs-ref-autogen/TOC.yml
:warning:Warning
View (azure-cli-2018-03-01-hybrid)
Details

latest/docs-ref-autogen/TOC.yml
:warning:Warning
View (azure-cli-latest)
Details

latest/docs-ref-autogen/aks.yml
:bulb:Suggestion
View (azure-cli-latest)
Details

latest/docs-ref-autogen/ams/asset.yml
:bulb:Suggestion
View (azure-cli-latest)
Details

latest/docs-ref-autogen/cdn/endpoint.yml
:bulb:Suggestion
View (azure-cli-latest)
Details

latest/docs-ref-autogen/cdn/profile.yml
:bulb:Suggestion
View (azure-cli-latest)
Details

latest/docs-ref-autogen/mariadb/server.yml
:bulb:Suggestion
View (azure-cli-latest)
Details

latest/docs-ref-autogen/mysql/flexible-server.yml
:bulb:Suggestion
View (azure-cli-latest)
Details

latest/docs-ref-autogen/mysql/server.yml
:bulb:Suggestion
View (azure-cli-latest)
Details

latest/docs-ref-autogen/postgres/flexible-server.yml
:bulb:Suggestion
View (azure-cli-latest)
Details

latest/docs-ref-autogen/postgres/server.yml
:bulb:Suggestion
View (azure-cli-latest)
Details

2017-03-09-profile/docs-ref-autogen/confluent/terms.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile)

2017-03-09-profile/docs-ref-autogen/k8s-extension.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile)

2017-03-09-profile/docs-ref-autogen/service-page/Azure Machine Learning.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile)

2017-03-09-profile/docs-ref-autogen/ssh.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile)

2017-03-09-profile/docs-ref-autogen/storage.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile)

2017-03-09-profile/docs-ref-autogen/storage/account.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile)

2017-03-09-profile/docs-ref-autogen/storage/account/blob-service-properties.yml
:white_check_mark:Succeeded

2017-03-09-profile/docs-ref-autogen/storage/blob/service-properties/delete-policy.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile)

2017-03-09-profile/docs-ref-autogen/storage/blob/tag.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile)

2017-03-09-profile/docs-ref-autogen/webapp/auth/microsoft.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile)

2017-03-09-profile/docs-ref-autogen/webapp/auth/openid-connect.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile)

2017-03-09-profile/docs-ref-autogen/webpubsub/client.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile)

2018-03-01-hybrid/docs-ref-autogen/confluent/terms.yml
:white_check_mark:Succeeded
View (azure-cli-2018-03-01-hybrid)

2018-03-01-hybrid/docs-ref-autogen/k8s-extension.yml
:white_check_mark:Succeeded
View (azure-cli-2018-03-01-hybrid)

2018-03-01-hybrid/docs-ref-autogen/service-page/Azure Machine Learning.yml
:white_check_mark:Succeeded
View (azure-cli-2018-03-01-hybrid)

2018-03-01-hybrid/docs-ref-autogen/ssh.yml
:white_check_mark:Succeeded
View (azure-cli-2018-03-01-hybrid)

2018-03-01-hybrid/docs-ref-autogen/storage.yml
:white_check_mark:Succeeded
View (azure-cli-2018-03-01-hybrid)

2018-03-01-hybrid/docs-ref-autogen/storage/account.yml
:white_check_mark:Succeeded
View (azure-cli-2018-03-01-hybrid)

2018-03-01-hybrid/docs-ref-autogen/storage/account/blob-service-properties.yml
:white_check_mark:Succeeded

2018-03-01-hybrid/docs-ref-autogen/storage/blob/service-properties/delete-policy.yml
:white_check_mark:Succeeded
View (azure-cli-2018-03-01-hybrid)

2018-03-01-hybrid/docs-ref-autogen/storage/blob/tag.yml
:white_check_mark:Succeeded
View (azure-cli-2018-03-01-hybrid)

2018-03-01-hybrid/docs-ref-autogen/webapp/auth/microsoft.yml
:white_check_mark:Succeeded
View (azure-cli-2018-03-01-hybrid)

2018-03-01-hybrid/docs-ref-autogen/webapp/auth/openid-connect.yml
:white_check_mark:Succeeded
View (azure-cli-2018-03-01-hybrid)

2018-03-01-hybrid/docs-ref-autogen/webpubsub/client.yml
:white_check_mark:Succeeded
View (azure-cli-2018-03-01-hybrid)

2019-03-01-hybrid/docs-ref-autogen/TOC.yml
:white_check_mark:Succeeded

2019-03-01-hybrid/docs-ref-autogen/confluent/terms.yml
:white_check_mark:Succeeded

2019-03-01-hybrid/docs-ref-autogen/k8s-extension.yml
:white_check_mark:Succeeded

2019-03-01-hybrid/docs-ref-autogen/service-page/Azure Machine Learning.yml
:white_check_mark:Succeeded

2019-03-01-hybrid/docs-ref-autogen/ssh.yml
:white_check_mark:Succeeded

2019-03-01-hybrid/docs-ref-autogen/storage.yml
:white_check_mark:Succeeded

2019-03-01-hybrid/docs-ref-autogen/storage/account.yml
:white_check_mark:Succeeded

2019-03-01-hybrid/docs-ref-autogen/storage/account/blob-service-properties.yml
:white_check_mark:Succeeded

2019-03-01-hybrid/docs-ref-autogen/storage/blob/tag.yml
:white_check_mark:Succeeded

2019-03-01-hybrid/docs-ref-autogen/webapp/auth/microsoft.yml
:white_check_mark:Succeeded

2019-03-01-hybrid/docs-ref-autogen/webapp/auth/openid-connect.yml
:white_check_mark:Succeeded

2019-03-01-hybrid/docs-ref-autogen/webpubsub/client.yml
:white_check_mark:Succeeded

2020-09-01-hybrid/docs-ref-autogen/TOC.yml
:white_check_mark:Succeeded

2020-09-01-hybrid/docs-ref-autogen/acr/connected-registry.yml
:white_check_mark:Succeeded

This comment lists only the first 50 files in the pull request.

2017-03-09-profile/docs-ref-autogen/TOC.yml

Line 1138, Column 12: [Warning-xref-not-found] Cross reference not found: 'sp-Azure_Devops'.

2018-03-01-hybrid/docs-ref-autogen/TOC.yml

Line 1138, Column 12: [Warning-xref-not-found] Cross reference not found: 'sp-Azure_Devops'.

latest/docs-ref-autogen/TOC.yml

Line 2318, Column 12: [Warning-xref-not-found] Cross reference not found: 'sp-Azure_Devops'.

latest/docs-ref-autogen/aks.yml

Line 1026, Column 39: [Suggestion-disallowed-html-tag] HTML tag 'target' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.
Line 1052, Column 290: [Suggestion-disallowed-html-tag] HTML tag 'target' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.

latest/docs-ref-autogen/ams/asset.yml

Line 280, Column 93: [Suggestion-disallowed-html-tag] HTML tag 'indexToRemove' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.
Line 286, Column 116: [Suggestion-disallowed-html-tag] HTML tag 'value' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.

latest/docs-ref-autogen/cdn/endpoint.yml

Line 412, Column 93: [Suggestion-disallowed-html-tag] HTML tag 'indexToRemove' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.
Line 418, Column 116: [Suggestion-disallowed-html-tag] HTML tag 'value' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.

latest/docs-ref-autogen/cdn/profile.yml

Line 157, Column 93: [Suggestion-disallowed-html-tag] HTML tag 'indexToRemove' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.
Line 163, Column 116: [Suggestion-disallowed-html-tag] HTML tag 'value' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.

latest/docs-ref-autogen/mariadb/server.yml

Line 74, Column 202: [Suggestion-disallowed-html-tag] HTML tag 'SingleIP' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.
Line 74, Column 214: [Suggestion-disallowed-html-tag] HTML tag 'StartIP-DestinationIP' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.
Line 474, Column 202: [Suggestion-disallowed-html-tag] HTML tag 'SingleIP' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.
Line 474, Column 214: [Suggestion-disallowed-html-tag] HTML tag 'StartIP-DestinationIP' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.
Line 477, Column 93: [Suggestion-disallowed-html-tag] HTML tag 'indexToRemove' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.
Line 483, Column 116: [Suggestion-disallowed-html-tag] HTML tag 'value' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.

latest/docs-ref-autogen/mysql/flexible-server.yml

Line 568, Column 93: [Suggestion-disallowed-html-tag] HTML tag 'indexToRemove' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.
Line 577, Column 116: [Suggestion-disallowed-html-tag] HTML tag 'value' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.

latest/docs-ref-autogen/mysql/server.yml

Line 79, Column 202: [Suggestion-disallowed-html-tag] HTML tag 'SingleIP' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.
Line 79, Column 214: [Suggestion-disallowed-html-tag] HTML tag 'StartIP-DestinationIP' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.
Line 484, Column 202: [Suggestion-disallowed-html-tag] HTML tag 'SingleIP' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.
Line 484, Column 214: [Suggestion-disallowed-html-tag] HTML tag 'StartIP-DestinationIP' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.
Line 487, Column 93: [Suggestion-disallowed-html-tag] HTML tag 'indexToRemove' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.
Line 493, Column 116: [Suggestion-disallowed-html-tag] HTML tag 'value' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.

latest/docs-ref-autogen/postgres/flexible-server.yml

Line 555, Column 93: [Suggestion-disallowed-html-tag] HTML tag 'indexToRemove' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.
Line 561, Column 116: [Suggestion-disallowed-html-tag] HTML tag 'value' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.

latest/docs-ref-autogen/postgres/server.yml

Line 79, Column 202: [Suggestion-disallowed-html-tag] HTML tag 'SingleIP' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.
Line 79, Column 214: [Suggestion-disallowed-html-tag] HTML tag 'StartIP-DestinationIP' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.
Line 432, Column 202: [Suggestion-disallowed-html-tag] HTML tag 'SingleIP' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.
Line 432, Column 214: [Suggestion-disallowed-html-tag] HTML tag 'StartIP-DestinationIP' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.
Line 435, Column 93: [Suggestion-disallowed-html-tag] HTML tag 'indexToRemove' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.
Line 441, Column 116: [Suggestion-disallowed-html-tag] HTML tag 'value' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


ERROR: Missing cgmlst_results

Hi,
I just run a wgs-contig file with Sistr.
I am running the program with multiple Salmonella wgs contig files. However, their species/variety names are unknown.
I run the following command:
sistr --qc -a allele_result.json -n novel_allele -p cgmlst_prof.csv -f tab -o predicted_output.tab -i Assembly/Newbler/454AllContigs.sort.fasta spp
I got some results in the allele output file and cgmlst_profile.
But prediction_tab file had a FAIL message inside.
predicted_output.tab file content:
cgmlst_distance	cgmlst_genome_match	cgmlst_matching_alleles	cgmlst_subspecies	fasta_filepath	genome	h1	h2	o_antigen	qc_messages	qc_status	serogroup	serovar	serovar_antigen	serovar_cgmlst
0.0909090909091	SRR1177577	300	enterica	/Archives/////*/Assembly/Newbler/454AllContigs.sort.fasta	spp	i	1,2	1,4,[5],12	FAIL: Moderate number of cgMLST330 loci missing (n=19 > 10)	WARNING	B	Typhimurium	Typhimurium	Typhimurium
ERROR message in Terminal
2017-03-24 13:40:48,403 ERROR: Missing cgmlst_results for NZ_AOXE01000073.1_79 [in /home/lpe/miniconda2/lib/python2.7/site-packages/sistr_cmd-0.3.4-py2.7.egg/sistr/src/cgmlst/init.py:357]
2017-03-24 13:40:48,403 ERROR: Missing cgmlst_results for NZ_AOXE01000050.1_18 [in /home/lpe/miniconda2/lib/python2.7/site-packages/sistr_cmd-0.3.4-py2.7.egg/sistr/src/cgmlst/init.py:357]
2017-03-24 13:40:48,403 ERROR: Missing cgmlst_results for NZ_AOXE01000008.1_59 [in /home/lpe/miniconda2/lib/python2.7/site-packages/sistr_cmd-0.3.4-py2.7.egg/sistr/src/cgmlst/init.py:357]
2017-03-24 13:40:48,403 ERROR: Missing cgmlst_results for NZ_AOXE01000073.1_98 [in /home/lpe/miniconda2/lib/python2.7/site-packages/sistr_cmd-0.3.4-py2.7.egg/sistr/src/cgmlst/init.py:357]
2017-03-24 13:40:48,403 ERROR: Missing cgmlst_results for NZ_AOXE01000073.1_144 [in /home/lpe/miniconda2/lib/python2.7/site-packages/sistr_cmd-0.3.4-py2.7.egg/sistr/src/cgmlst/init.py:357]
2017-03-24 13:40:48,403 ERROR: Missing cgmlst_results for NZ_AOXE01000036.1_98 [in /home/lpe/miniconda2/lib/python2.7/site-packages/sistr_cmd-0.3.4-py2.7.egg/sistr/src/cgmlst/init.py:357]
2017-03-24 13:40:48,403 ERROR: Missing cgmlst_results for NZ_AOXE01000036.1_58 [in /home/lpe/miniconda2/lib/python2.7/site-packages/sistr_cmd-0.3.4-py2.7.egg/sistr/src/cgmlst/init.py:357]
2017-03-24 13:40:48,403 ERROR: Missing cgmlst_results for NZ_AOXE01000035.1_13 [in /home/lpe/miniconda2/lib/python2.7/site-packages/sistr_cmd-0.3.4-py2.7.egg/sistr/src/cgmlst/init.py:357]
2017-03-24 13:40:48,404 ERROR: Missing cgmlst_results for NZ_AOXE01000035.1_21 [in /home/lpe/miniconda2/lib/python2.7/site-packages/sistr_cmd-0.3.4-py2.7.egg/sistr/src/cgmlst/init.py:357]
2017-03-24 13:40:48,404 ERROR: Missing cgmlst_results for NZ_AOXE01000003.1_39 [in /home/lpe/miniconda2/lib/python2.7/site-packages/sistr_cmd-0.3.4-py2.7.egg/sistr/src/cgmlst/init.py:357]
2017-03-24 13:40:48,404 ERROR: Missing cgmlst_results for NZ_AOXE01000073.1_48 [in /home/lpe/miniconda2/lib/python2.7/site-packages/sistr_cmd-0.3.4-py2.7.egg/sistr/src/cgmlst/init.py:357]
2017-03-24 13:40:48,404 ERROR: Missing cgmlst_results for NZ_AOXE01000003.1_70 [in /home/lpe/miniconda2/lib/python2.7/site-packages/sistr_cmd-0.3.4-py2.7.egg/sistr/src/cgmlst/init.py:357]
2017-03-24 13:40:48,404 ERROR: Missing cgmlst_results for NZ_AOXE01000008.1_63 [in /home/lpe/miniconda2/lib/python2.7/site-packages/sistr_cmd-0.3.4-py2.7.egg/sistr/src/cgmlst/init.py:357]
2017-03-24 13:40:48,404 ERROR: Missing cgmlst_results for NZ_AOXE01000036.1_66 [in /home/lpe/miniconda2/lib/python2.7/site-packages/sistr_cmd-0.3.4-py2.7.egg/sistr/src/cgmlst/init.py:357]
2017-03-24 13:40:48,404 ERROR: Missing cgmlst_results for NZ_AOXE01000003.1_57 [in /home/lpe/miniconda2/lib/python2.7/site-packages/sistr_cmd-0.3.4-py2.7.egg/sistr/src/cgmlst/init.py:357]
2017-03-24 13:40:48,404 ERROR: Missing cgmlst_results for NZ_AOXE01000073.1_85 [in /home/lpe/miniconda2/lib/python2.7/site-packages/sistr_cmd-0.3.4-py2.7.egg/sistr/src/cgmlst/init.py:357]
2017-03-24 13:40:48,404 ERROR: Missing cgmlst_results for NZ_AOXE01000003.1_37 [in /home/lpe/miniconda2/lib/python2.7/site-packages/sistr_cmd-0.3.4-py2.7.egg/sistr/src/cgmlst/init.py:357]
2017-03-24 13:40:48,404 ERROR: Missing cgmlst_results for NZ_AOXE01000073.1_130 [in /home/lpe/miniconda2/lib/python2.7/site-packages/sistr_cmd-0.3.4-py2.7.egg/sistr/src/cgmlst/init.py:357]
2017-03-24 13:40:48,404 ERROR: Missing cgmlst_results for NZ_AOXE01000003.1_7 [in /home/lpe/miniconda2/lib/python2.7/site-packages/sistr_cmd-0.3.4-py2.7.egg/sistr/src/cgmlst/init.py:357]
/home/lpe/miniconda2/lib/python2.7/site-packages/sistr_cmd-0.3.4-py2.7.egg/sistr/src/cgmlst/init.py:293: SettingWithCopyWarning:
A value is trying to be set on a copy of a slice from a DataFrame
See the caveats in the documentation: http://pandas.pydata.org/pandas-docs/stable/indexing.html#indexing-view-versus-copy

Help me to explain/get rid of the error.
Thanks in advance.

It looks like your assembly is missing some of core genes that are searched for in cgMLST scheme that SISTR uses. The QC failure was triggered by over 10 of these cgMLST loci/conserved core genes being missing in your assembly. This is an arbitrary threshold that I've added to indicate that there may be issues with an input genome fasta file.
Even though your assembly is missing 19 out of 330 cgMLST loci, SISTR is still able to predict a serovar and subspecies, and out of the 311 non-missing cgMLST loci, 300 of them match perfectly to a Typhimurium genome in the SISTR database. It also looks like SISTR was able to find matches for the O, H1 and H2 antigens corresponding to Typhimurium.
Anyway, you can treat the QC messages as guidelines potentially alerting you to issues that you may encounter when performing analyses with your genomes.
Let me know if that helps!

Thanks, Peter, for the explanation.
However, I still need to measure the significance of the Sistr_Predicted results.
I thought option --qc was for this purpose.
(I do not have clear concept yet, about the result. I am trying to learn on how to explain the result using statistics.)
Is there any other option I can use to calculate the significance?
Appreciate your help.
Thanks again.

Measuring the confidence or significance of the SISTR serovar prediction is something we've been working on developing. At this point we have qualitative guidelines rather than strict quantitative thresholds.
For instance if your input genome is closely related to a genome within the SISTR database (e.g. cgMLST distance is less than 0.1) and SISTR was able to find a match for serogroup/O group, H1 and H2 antigens, then we would consider that to be a high confidence prediction.
If, however, SISTR is unable to find a match for the serogroup/O-antigen due to missing wzx/wzy genes and there is no close match to a genome within the SISTR database, then we would have low confidence in the prediction and SISTR would likely report multiple possible serovar predictions delimited by a '|' (pipe) character (e.g. Enteritidis|Nitra|Dublin...).
One thing that SISTR does that distinguishes it from other in silico Salmonella serotyping tools, is that it uses cgMLST and antigen gene searching in combination to provide a serovar prediction. SISTR also reports the serovar predictions by either cgMLST or antigen searching alone. If the cgMLST and antigen gene predictions are in agreement, then you can probably have high confidence in the overall prediction.
I've tried to roughly codify these guidelines into a set of QC flags to inform you whether there may be issues with the serovar predictions:

PASS - high confidence in serovar prediction  - everything looks fine
WARNING - medium confidence - you may need to check the results for anomalies
FAIL - low confidence - check the results and/or your input genome

Hope that helps.


Android - Support Glide 4.x (e.g. 4.7.0)

We are using this library together with Ti.ImagePicker which uses Glide 4.7.0 (from April 2018). Unfortunately, this leads to incompatibility issues with this module, since this one still uses Glide 3.8.0. It looks like some classes have been moved in Glide 4.x (from May 2017), so migrating may take some effort.

Tomorrow I will start to work on this. I'll create a new branch and will merge when it will be finished.

Just for update: I'm working on it on branch https://github.com/AndreaVitale/av.imageview/tree/issue-63 integrating latest Glide version 4.9.0 atm.
Is still in development but I solved also #62 and I changed how contentMode is handled so.. also #45 should be resolved.
I think that due to the new Glide structure we'll have problems to support the actual validatesSecureCertificate but.. step by step :-)

I'll try to put an eye on it.
El vie., 22 mar. 2019 10:52, Andrea Vitale<EMAIL_ADDRESS>escribió:

Just for update: I'm working on it on branch
https://github.com/AndreaVitale/av.imageview/tree/issue-63 integrating
latest Glide version 4.9.0 atm.
Is still in development but I solved also #62
https://github.com/AndreaVitale/av.imageview/issues/62 and I changed
how contentMode is handled so.. also #45
https://github.com/AndreaVitale/av.imageview/issues/45 should be
resolved.
I think that due to the new Glide structure we'll have problems to support
the actual validatesSecureCertificate but.. step by step :-)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/AndreaVitale/av.imageview/issues/63#issuecomment-475557802,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFjBHqUhtRmsnEaX4easZhHYwYVUSrELks5vZKffgaJpZM4Zk9Kz
.

@AndreaVitale This is huge, THANK YOU!

Guys I finished a complete rewriting of the android module on issue-63 branch.
It includes the latest stable Glide release (4.9.0) and it is really really really leaner then the previous one.
Please test the bundled module version (4.0.0) downloading it from here and let me know if you find any kind of issues for currently supported properties.
Breaking changes

property dontAnimate is now named animated and is true by default
property rounded must be used with CONTENT_MODE_ASPECT_FIT to be correctly rendered
property validatesSecureCertificate (for allowing self-signed certificates) is not currently supported.

About the last point: sorry @phobeous.
I was unable to create a custom AppGlideModule. If anyone can help on this is really appreciated.

jsut tried a simple replace of the old module and two things I've found:

setSignature() is missing (I use this for custom caching https://bumptech.github.io/glide/doc/caching.html#custom-cache-invalidation)
got this error:

[WARN]  Glide: Load failed for /images/bg.jpg with size [1080x540]
[WARN]  Glide: class com.bumptech.glide.load.engine.GlideException: Failed to load resource
[WARN]  Glide: There was 1 cause:
[WARN]  Glide: java.net.MalformedURLException(no protocol: /images/bg.jpg)
[WARN]  Glide:  call GlideException#logRootCauses(String) for more detail
[WARN]  Glide:   Cause (1 of 1): class com.bumptech.glide.load.engine.GlideException: Fetching data failed, class java.io.InputStream, REMOTE
[WARN]  Glide: There was 1 cause:
[WARN]  Glide: java.net.MalformedURLException(no protocol: /images/bg.jpg)
[WARN]  Glide:  call GlideException#logRootCauses(String) for more detail
[WARN]  Glide:     Cause (1 of 1): class java.net.MalformedURLException: no protocol: /images/bg.jpg

same image is working in the current module. Didn't dig deeper there, just wanted to see if I can just switch modules

@AndreaVitale I just tried the module as well and many (remote) images do not load anymore. No error logs, only some AvImageView: Destroying.

About images that aren’t displayed... could you please provide some examples? I tried all images that are in example app.js and I didn’t find any issue.

here is one image: http://migaweb.de/bg.jpg (placed in app/assets/android/images/res-xxhdpi/)

Any progress here? I'm happy to help!

@m1ga could you please try this new 4.0.0 version?

Density specific images seem to work again. But unfortunately remote images with a defaultImage set still don't work.

I think #77 fixes this?

It is already merged in this branch, could you the latest archive in issue-63 branch?

there is a typo:
[ERROR] Failed to compile Java source files:
[ERROR]
[ERROR] warning: [options] bootstrap class path not set in conjunction with -source 1.7
[ERROR] av.imageview/android/src/av/imageview/AVImageView.java:30: error: class AvImageView is public, should be declared in a file named AvImageView.java
[ERROR] public class AvImageView extends TiUIView
[ERROR]        ^
[ERROR] Note: Some input files use or override a deprecated API.
[ERROR] Note: Recompile with -Xlint:deprecation for details.
[ERROR] Note: /home/miga/tools/av.imageview/android/src/av/imageview/AVImageView.java uses unchecked or unsafe operations.
[ERROR] Note: Recompile with -Xlint:unchecked for details.
[ERROR] 1 error
[ERROR] 1 warning

the v in the filename needs to be lowercase

the problem only appears when using .setImage() or .image = . When I set the image in my tss file it doesn't throw that error.

@m1ga have you tried the latest dist in this branch? I forget to move the filename via git but the was build with the correct naming.

yes, compiled the latest issue-63 branch. I've used rounded + ASPECT_FILL in some places which isn't working either now but that doesn't throw an error just isn't rounded (but I saw that it needs to be FIXED now)

@AndreaVitale
here you check for local and remote images:
https://github.com/AndreaVitale/av.imageview/blob/issue-63/android/src/av/imageview/AvImageView.java#L108
but here you don't:
https://github.com/AndreaVitale/av.imageview/blob/issue-63/android/src/av/imageview/ImageViewProxy.java#L94

@m1ga could you please provide the latest commit? Thanks!

in one Listview I have those messages:
TiDrawableReference: (main) [764,83129] Could not open stream to get bitmap
TiDrawableReference: (main) [0,83129] Could not open stream to get bitmap
Glide: Load failed for null with size [-1x-1]
Glide: class com.bumptech.glide.load.engine.GlideException: Received null model
TiDrawableReference: (main) [668,83797] Could not open stream to get bitmap
TiDrawableReference: (main) [0,83797] Could not open stream to get bitmap
TiDrawableReference: (main) [668,83797] Could not open stream to get bitmap
TiDrawableReference: (main) [0,83797] Could not open stream to get bitmap
Glide: Load failed for null with size [0x0]
Glide: class com.bumptech.glide.load.engine.GlideException: Received null model

and some images won't load. I'll check that later

 builder = builder.apply(options); is missing here:
https://github.com/AndreaVitale/av.imageview/blob/issue-63/android/src/av/imageview/AvImageView.java#L187
(like in line 164)
that will show rounded images for local files again!
and I found the solution for the problem above:
https://github.com/AndreaVitale/av.imageview/blob/issue-63/android/src/av/imageview/AvImageView.java#L172
I have an Listview with images and I have to change that line above to use the filename parameter like this:
Drawable imageDrawable = TiDrawableReference.fromUrl(this.proxy.get(), filename).getDrawable();
now all images are visible in my app again!

Damn! Thanks @m1ga ! I applied your fixes, verified that in ListView I can apply round options for local images. Do you have other issues?

I don't have any other issues but it looks like there are some other issues in #75 (even I don't have problems loading /image/file.jpg, img.nativePath and remote URLs. But will do some more tests tomorrow

Looks like there is some bug in this setup:

ScrollableView -> 10x Widget (containing an av.ImageView)

using the av.imageviews without a widget works fine or increasing the cacheSize of the scrollableview.
3.x is not having that issue. Will do some more debugging

Fixed in the released 4.0.0 version!


Add first unit tests

Is your feature request related to a problem? Please describe.
It would be useful to have unit tests for helping to validate that the mod works as expected, instead of only relying on manual testing.
Describe the solution you'd like
Add unit tests (NUnit or some other common framework) for this mod. Can cover anything, just need to have at least a few working unit tests to start with.
Describe alternatives you've considered
None.
Additional context
None.

hi @CompSciLauren can i add one unit test for this and contribute to the project.
Thank you

Hi @Jilesh980 yes thank you, that would be wonderful! Even just one working test would be helpful as a starting point. Let me know if you need anything or have questions. And please be sure to add your name to the Contributors.md file! Thanks :)

@Jilesh980 Have you already forked the project and implemented a framework? Would be nice to have a pr that just contains the basics for the tests so we can work in tandem here.

@Jilesh980 @JoshJOkayguy thank you both for wanting to help! Just wanted to give a quick update. @dv297 submitted PR #74 which has been merged to master. It contains basic changes needed to get started plus a few unit tests.
Feel free to submit a PR if you want to add onto it. I think I'll just update this Issue to be about unit testing in general and leave it open for some time. Thanks again!


support cuda 11.8

Thanks for the code! It was able to run with cuda tool kit 12.1,  driver 11.8 and TensorRT-<IP_ADDRESS> for 12.1. I would need the trt inference on cuda toolkit 11.8. What I have tried:

with TensorRT-<IP_ADDRESS> for 11.8. cmake and make passed but when I ran the program, I got

	libcublas.so.12 => not found
	libcublasLt.so.12 => not found

I tried softlink the xxxx.so.11 to 12 but the program detected it and complained.
ldd run_inference_benchmark  | grep found
./run_inference_benchmark: /lib/x86_64-linux-gnu/libcublas.so.12: version `libcublas.so.12' not found (required by /lib/x86_64-linux-gnu/libnvinfer_plugin.so.8)
./run_inference_benchmark: /lib/x86_64-linux-gnu/libcublasLt.so.12: version `libcublasLt.so.12' not found (required by /lib/x86_64-linux-gnu/libnvinfer_plugin.so.8)

I saw your release 1.0 too but that tensor version was for up to 11.5.
I also tried TensorRT-<IP_ADDRESS> but there were functions in the current code that don't exist in this TensorRT version.

Any suggestions are appreciated!

I use TensorRT 8.6 and CUDA 11.8 in my environment and works fine. Make sure you download the correct version of TensorRT. You likely downloaded for CUDA 12.x, whereas you need to download for CUDA 11.x.
See my answer in the other issue: https://github.com/cyrusbehr/tensorrt-cpp-api/issues/45

Thanks a lot for the quick reply! Didn't realize you had answered my question in a different thread. I thought the post failed. I indeed reinstalled cuda a few times. Maybe I should reinstall my ubuntu 20.04 from scratch


Radio Button Keyboard control

From the VT accessibility audit:

The groups of radio inputs, although nominally keyboard-operable, do not respond to standard
keyboard interactions. (Illustrated below is just one example.) 2-Significant. In a standard radio group:
* The group is contained within a < fieldset > whose < legend > holds the question.
* The Tab key takes the user into the group.
* The arrow keys navigate among the radio inputs within the group.
* Standard visual focus indicators are presented.
* Each radio input becomes selected in turn when it receives the focus.
* Hitting Tab again leaves the most-recently-focused radio input selected as the user’s
choice for that group and takes the user out of the group and on to the next focusable
element.

In the current implementation:
* The < fieldset > is present, but the < legend > is generic; in every instance it just says
“Choices”. This is unhelpful. Screen reader users do not hear the question unless they go
hunting around for it.
* The Tab key navigates among the radio inputs.
* The arrow keys have no function.
* The user must hit Space or Enter to mark an input as selected.
* Visual focus indication of the radio inputs is inconsistent and relies on a change to the
background color.
* The standard behavior is all default browser behavior—no scripting or ARIA needed so long as
standard HTML is used. We assume that the current implementation stems from a desire to
create a custom look for the radio inputs. However, instead of relying on hidden form controls,
ARIA, and JavaScript, we recommend using standard HTML and styling with CSS.

I've never really considered these before, always generally thinking that the tab and space controls were good. It might be difficult to get an upstream change, but I'll play around with it. At the very least the legend label can be improved.

Another upstream one. I don't think the Lab will be able to do this one on our own.
Pinging @jhpyle on Slack about these ones marked upstream might be a good idea. I know he cares about accessibility and at least he'll be able to tell us if he has interest in fixing it. If it needs to be fixed by Lab, it will need to wait for our new developer.

One of the items isn't about keyboard control:

The < fieldset > is present, but the < legend > is generic; in every instance it just says
“Choices”. This is unhelpful. Screen reader users do not hear the question unless they go
hunting around for it.

This issue is having a deeper discussion about screen readers with fieldset and legend.


Improve exception, webhook http code, error handling on validateOrder

Improve error handling :

Handle processing payment error smoothly
Notify Customer Service on processing payment error cannot be resolved by Customer
Avoid Fatal Error on controllers DispatchWebhook and ValidateOrder

This should be released on 1.5.0 cause it will required tests from QA and new translations.
If processing payment error can be resolved by Customer :

If processing payment error cannot be resolved by Customer because it required action from Merchant, we display an error page with a link to Contact Form :

We create a CustomerService Thread on this case

Hello,
3 questions :
1 - Can we select the radio button that was used just before? (error when paying by card re-display hosted card fields to try another card for instance)
2 - When the transaction has succeeded but action from the merchant needed, the message is too much negative and make customer anxious, can we change it? (I can provide wording)
3 - Do ALL cases of error are included in the 2 first cases:

either customer needs to pay again => redirect to the payment step,
either payment has been through successfully but orders not created then merchant action needed.
Are we missing some corner cases?
4 - What customer name is sending the customer service message? (here john doe) If an order is created, can we display order reference in message?
5 - If I have the Merchant Action Needed screen and I go to customer service to send a message, my message will be displayed in the same thread as the automatic message sent by the module ?

@Darmona

We will be able to do that in v2.0.0 but not in v1.5.0 due to redirection
Yes, I will change the message
I checked all cases on PayPal docs, but there can be undocumented case.
The customer name sent to Customer Service in the one used on Order process. We cannot add an Order reference because no order is created at this step, only a Cart.
No because the automatic message is sent with flag private due to error details may contain debug information with sensible data.

@Darmona Wordings updated, added ContactForm after error message only on 1.7 and if contactform module is enabled.


parsing error:  Invalid extended asset string

Hi James,
I have a custom contract where I can send custom tokens to.
Here is an example from the command line. The testuser1234 has quite some CANDY and offers it to sell:
$ cleos push action organiccandy add '["testuser1234" 1 "-1.337 CANDY" 12 0]' -p testuser1234

executed transaction: 086250dc677361b615ea962b4149669e9517adb3cf4bdc706308449c201f6344  136 bytes  1114 us
#  organiccandy <= organiccandy::add          {"account":"testuser1234","clId":1,"qty_and_pair":"-1.337 CANDY","priceDbl":"12.00000000000000000...

With the eosjs I run into a problem with negative values like -1.337:
const payload = { account: 'testuser1234',
  clId: 1,
  qty_and_type: '-1.337 CANDY',
  py: 0,
  priceDbl: '1337'
}

eos.contract('organiccandy').then((contract) => {
  return contract.add(payload, { authorization: 'testuser1234@active' })
})
.then((res) => {
  console.log('yay!')
  console.log(res)
})
.catch((err) => { console.error(err) })

{ AssertionError [ERR_ASSERTION]: Invalid extended asset string: -1.337 CANDY !== CANDY place.qty_and_type action.data transaction.actions
    at parseAsset (/Users/robert/candystore/node_modules/eosjs/lib/format.js:367:10)
    at Object.fromObject (/Users/robert/candystore/node_modules/eosjs/lib/structs.js:402:26)
    at Object.fromObject (/Users/robert/candystore/node_modules/fcbuffer/lib/struct.js:151:34)
    at actionDataFromObject (/Users/robert/candystore/node_modules/eosjs/lib/structs.js:674:29)
    at Object.fromObject (/Users/robert/candystore/node_modules/fcbuffer/lib/struct.js:148:15)
    at Object.fromObject (/Users/robert/candystore/node_modules/fcbuffer/lib/types.js:384:28)
    at Object.fromObject (/Users/robert/candystore/node_modules/fcbuffer/lib/struct.js:151:34)
    at _callee2$ (/Users/robert/candystore/node_modules/eosjs/lib/write-api.js:652:38)
    at tryCatch (/Users/robert/candystore/node_modules/regenerator-runtime/runtime.js:62:40)
    at Generator.invoke [as _invoke] (/Users/robert/candystore/node_modules/regenerator-runtime/runtime.js:296:22)
  generatedMessage: false,
  name: 'AssertionError [ERR_ASSERTION]',
  code: 'ERR_ASSERTION',
  actual: '-1.337 CANDY',
  expected: 'CANDY',
  operator: '==' }

I renamed some types: UDecimalPad -> DecimalPad (for example)

Released under v15.0.1

I dont believe this issue is closed, I am getting a very similar error with extended symbols. Any advice besides don't use them? :)

This is a legacy issue.. If your on the latest version a new issue will be better, the entire code base changed.


Node After Restart Can Not Communicate With Service IPs

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
When a node gets restarted (manually/crashed/...), that node (and any pods on this node) can not communicate with the service IPs. For example
On a working node if i check connectivity to any service ip/port it works. here I check kubernetes service on default namespace:
nc -zv <IP_ADDRESS>  443
Connection to <IP_ADDRESS> 443 port [tcp/https] succeeded!

same command on a node which is restarted fails.
but failed node can communicate directly with pod IPs. so if a pod IP is <IP_ADDRESS> and it accepts connections on port 4444, I can validate node can connect to the pod IP with the same nc command.
nc -zv <IP_ADDRESS> 4444
Connection to <IP_ADDRESS> 4444 port [tcp/https] succeeded!

I can fix the failed node with:

Drain node , delete node from the cluster, reboot the node , join node again to the cluster.
OR
Change Cilium configuration:

change routing mode to native and delete that node cilium pod.
then wait for that node cilium pod to become ready
after that change routing back to tunnel and delete cilium pod on the failed node
after these steps, node becomes ready and can communicate with the services IPs

Cilium Version
1.14.2
Kernel Version
5.15.0-87-generic
Kubernetes Version
1.28.1
Sysdump
No response
Relevant log output
No response
Anything else?
failed node which can not communicate with the service shows that service identity as world but other nodes shows its identity id in cilium monitor.
also failed node shows correct identity id for service in output of cilium identity list(it shows identity id 12304)

K8s cluster is on-prem and we are using kube-replacement mode.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

anyone on this issue?

I have also observed this issue recently when a node is shutdown in an unexpected manner. The resolution was to just delete the cilium pod on the host and service connectivity was restored once the new pod was initialized.
As with the OP, pod connectivity was fine, it was just services that were inaccessible.

hello @adamcooke, Thanks for response.
What kind of information do You need? tell me and I'll share them for You here.

@yaskinny that seems drastic! Would it be possible to capture a sysdump with a node in this state?

hey @squeed, I'll for sure provide a sysdump in couple of days. Right now I'm busy with other tasks. Thanks!

hello,
I  got a system dump from a failed node, the problem is sysdump has lots of information like our public ips in policies, application names, container names, ... . which disclosing tons of information.
I did a simple grep and they are mostly in these files:
cilium-debuginfo-20231127-135845.302+0000-UTC.md
cilium-debuginfo-20231127-135845.302+0000-UTC.json
cilium-map-events-cilium_ipcache--o-json.md
cilium-ip-list--n--o-json.md
cilium-map-list---verbose.md
cilium-service-list--o-json.md
cilium-policy-get.md
cilium-bpf-ipcache-list.md
cilium-identity-list.md

if they are not needed I can exclude them and send other files. if they are needed I have to almost change everything that disclosing information.
Also do you need sysdump from a healthy node or same node after recovering it?
please let me know.
@julianwiedmann @squeed @adamcooke

Sending some information is better than none - if you could send whatever you can, it will really help with being able to investigate this issue. I'll mark this as need-more-info again while you come back with that.
A separate sysdump from a healthy node would also be useful, thanks.


PyThaiNLP v3.0.0 Released!

After a long time of the development of PyThaiNLP 3.0, We released PyThaiNLP 3.0. PyThaiNLP 3.0 has many improvements and new features to help with Thai language processing tasks.
You can install by pip install pythainlp or upgrade by pip install -U pythainlp.
Documentation: https://pythainlp.github.io/docs/3.0/index.html
Report bug: https://github.com/PyThaiNLP/pythainlp/issues
See PyThaiNLP 3.0 change log#545
If you want to contribute to PyThaiNLP, you can read Contributing to PyThaiNLP.
News

Since PyThaiNLP 3.0, We will end supporting PyThaiNLP on Python 3.6. Python 3.6 users can use PyThaiNLP 2.3.2.

We have updated the Thai word dictionary & rule for newmm. We recommend retraining your model if you use newmm for word tokenization in your model.

What is new?
Deprecation and other API changes

Deprecated syllable_tokenize. syllable_tokenize is deprecated, use subword_tokenize instead
pythainlp.tag.named_entity.ThaiNameTagger is change to pythainlp.tag.thainer.ThaiNameTagger. This old class will be deprecated in PyThaiNLP version 3.1.

Augment

Add Thai Text Augmentation

Corpus

Fix lots of misspellings in the dictionary (words_th.txt)
Add get_corpus_default_db and thainer 1.5 model. You can add corpus on default_db.json, and you don't load the last trainer model from the Internet.

Tag

Add TLTK (pos_tag and ner) - add TLTK wrapper to pythainlp functions ex ner, word_tokenize and more.
Add NER class - NER class for Named-entity recognizer tasks.

Translate

Add pythainlp.translate.Translate Class
Add Chinese-Thai Machine Translation
Add Thai-French Machine Translation

Tokenization

Tokenize repeating dots and commas from numbers
Fix token_max_len bug that makes it always zero
Tokenize repeating dots and commas from numbers (fix #461)
Retrained sentenceseg_crfcut.model for PyThaiNLP 2.4
Add SEFR CUT to pythainlp
Add TLTK (sentence_tokenize and word_tokenize) - add TLTK wrapper to pythainlp functions ex ner, word_tokenize, and more.
Add nlpo3

Transliterate

Refactor Royin Transliterate: Avoid embedded if blocks and simplified consonant replacing operations
Manually merge update-royin branch with dev branch to add O-ANG rule
Add TLTK (g2p and ipa) - add TLTK wrapper to pythainlp functions ex ner, word_tokenize, and more.
Add pythainlp.transliterate.puan

Word Vector

Fix token_max_len bug that makes it always zero
Add pythainlp.word_vector.WordVector

Spell

Add more spelling engine
Add TLTK (spell) - add TLTK wrapper to pythainlp functions ex ner, word_tokenize, and more.

Generate

Add pythainlp.generate to generate a text.

Tool

Add misspell module

Other

Add TLTK - add TLTK wrapper to pythainlp functions ex ner, word_tokenize, and more.
Update requirements from ssg 0.0.6 to ssg 0.0.8
Spoonerism: Add supports words more three syllables
Add maiyamok; This function is preprocessing MaiYaMok in a Thai sentence.

Contributors

Thanks all the contributors. (Image made with contributors-img)
If you want to contributing to PyThaiNLP, you can read Contributing to PyThaiNLP.

This year is the 6th year's PyThaiNLP, and PyThaiNLP has more than one million downloads. I started to develop PyThaiNLP to help me do Thai language processing tasks. Now, PyThaiNLP has been used in many research and works worldwide. PyThaiNLP can't be grown if it doesn't have contributors, sponsors, and users.
Thank you for all supporting.
Thank you for using PyThaiNLP.

Wannaphong Phatthiyaphaibun
PyThaiNLP Founder
27 January 2022

Hello @wannaphong! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file pythainlp/util/thai.py:

Line 93:38: W291 trailing whitespace
Line 96:35: W291 trailing whitespace
Line 99:42: W291 trailing whitespace


Error Underlining Persists Incorrectly

( in these cases Linter is being used in conjunction with atom-fsharp )

On the bottom it says there are no issues.
When I close and reopen the file it's fine

But then when I start editing the file again it has error underlining that persists

Fixed in the latest release. It was a typo.


Update start date for OptionSplitRegressionAlgorithm

Description
The start date for OptionSplitRegressionAlgorithm has been changed from 6/5/2014 to 6/6/2014 and the regression statistics have been updated to reflect this.
Related Issue
Closes #2306
Motivation and Context
The regression test was getting different statistics when run locally vs cloud.
Requires Documentation Change
No.
How Has This Been Tested?
OptionSplitRegressionAlgorithm regression test.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Non-functional change (xml comments/documentation/etc)

Checklist:

[x] My code follows the code style of this project.
[x] I have read the CONTRIBUTING document.
[x] All new and existing tests passed.
[x] My branch follows the naming convention bug-<issue#>-<description or feature-<issue#>-<description>

NOTE: LEAN repo was missing data for the 5th, advancing the start date seems better than adding another 10MB of data to the repo for this one case.


build: add packages to dune-project + re-generate opam files

This PR adds all dream packages to the dune-project file and also re-generates the opam files. There should be no actual functional differences introduced by this PR.
This prepares dream to more easily switch to a dune-only workflow in the future.
Also fixed a typo in the project's description (trivailly -> trivially)
The opam files mostly changed in the order of the fields, since they are now being generated by dune during the build step.
Open questions
I wasn't sure how to understand this dependency restriction ("conf-libev" {os != "win32"} | "ocaml" {os = "win32"}).
I would expect we need to depend on OCaml on OS and not just Windows, but for now I've replicated this in the dune-project file as
"conf-libev" {os != "win32"}
"ocaml" {os = "win32"}

The dune dependency specification isn't as expressive as opam's in this case.

I formatted the dune-project file with dune format-dune-file and manually copy pasted the long descriptions back in, since multi-line strings aren't well supported there at the moment.

Thanks! I'm skeptical of changing to a Dune-only workflow for now. I don't see the advantage of it, but there is the disadvantage that it's not opam's native format and it doesn't support everything that opam supports. In particular,

I wasn't sure how to understand this dependency restriction ("conf-libev" {os != "win32"} | "ocaml" {os = "win32"}).
I would expect we need to depend on OCaml on OS and not just Windows, but for now I've replicated this in the dune-project file as

This is a way to have a conf-libev dependency only on non-Windows. I don't remember what happens if you don't write the line this way, but the last part introduces a fake redundant dependency on OCaml on Windows to work around some problem we were observing.
The multiline strings in Dune are also regrettable. Overall, the dune-project format is pretty difficult to read.
I'm not inherently against Dune-only, but I don't think it's ready. Given its drawbacks, I don't think it's worth adding a generation step for the opam file and complicating the workflow in this repo in this way.
I do see you've fixed at least that one typo, though, in the word "trivially," and that's very welcome for sure :)

Thanks! I'm skeptical of changing to a Dune-only workflow for now. I don't see the advantage of it, but there is the disadvantage that it's not opam's native format and it doesn't support everything that opam supports. In particular,

My reasoning was that since dune is planned to be the OCaml toll going forward, dream will probably switch to using it more heavily sooner or later. Specifically I'm thinking of the package management features that are being worked on in dune.
Switching to a more dune-focused workflow earlier would allow for an easier adoption of new features down the line.

The multiline strings in Dune are also regrettable. Overall, the dune-project format is pretty difficult to read.

Nothing I can say against that really... I also wish the multiline strings had a nicer syntax.

I'm not inherently against Dune-only, but I don't think it's ready. Given its drawbacks, I don't think it's worth adding a generation step for the opam file and complicating the workflow in this repo in this way.

I don't see how this would change or complicate the workflow. Instead of editing the individual opam files, one would now edit the information in the dune-project file. On dune build the opam files are always automatically re-generated.

The outcome of such plans is not pre-determined, but depends on the actual ability of Dune to convince the community at large to use it in this way, for part of which Dune also needs feedback such as from the conversation in this PR. As a maintainer of a relatively large and well-known project I don't think I could suggest Dune as a reasonable option to Dream's contributors. This is not because I am against it in principle, but because it is an extra moving part, something opaque, something that needs more work, something that, at present, appears slightly crufty in an unnecessary way. This isn't a hard no -- if Dune improves, or if the whole rest of the community is clearly moving towards Dune-only, then we will also go there, but I don't see it as a clear "yes" right now. It's not very clearly better on its own merits (but perhaps I'm not informed about some advantage of it), nor is it the factual community default. Rather, it's an aspirational project, largely about reorganizing and tidiness, but with clear trade-offs in such, and whose future is still undecided.

As an example, I'd like to avoid having to do things like this. I'm sure Dune-only will get there eventually, but at the moment, practical work with Dune-only for a library project that gets published to opam (as opposed to an app, especially one that is not open-source):

Have up to three files, instead of dream.opam, dream.opam, dune-project, dream.opam.template, and potentially likewise for all other .opam files.
We still publish .opam files to opam-repository. They get updated there, downstream, as the community discovers new constraints during package releases. I then take these .opam files and diff against them and use copy-paste+diff to discover what has changed since the last release, so I can upstream any contraints I haven't been informed about into the .opam file in this repo. This is all doable with mentally translating back to dune-project, but it's extra work, especially if dune-project starts reordering dependency lists, especially if it's according to changes in the version of Dune that is generating the files (though I'm sure they would tend to avoid that), if it ever creates fake blame because the file is generated and it's decided that it's not important to keep its history tidy.

There are more objections, I don't remember everything immediately, but I do stumble upon them in practical work, and the answer in all cases would have been to use opam's native format for opam, while we still use opam, and while Dune's opam generation is still developing, given that the opam format is not, in the end, awful.

Or to put it another way, once (and if) we are actually moving towards a world in which we can have only dune-project in each repo, losing nothing that way, then I think Dream is ready to adopt this, even if it has some remaining drawbacks that might be individually serious. But in the current tentative and transitional state, it's worse to adopt this, than not. It's more suitable for private or semi-private projects, apps (leaves in the dependency graph), etc.

Thanks for sharing your perspective. This part especially was new to me as a non-library developer

We still publish .opam files to opam-repository. They get updated there, downstream, as the community discovers new constraints during package releases. I then take these .opam files and diff against them and use copy-paste+diff to discover what has changed since the last release, so I can upstream any contraints I haven't been informed about into the .opam file in this repo. This is all doable with mentally translating back to dune-project, but it's extra work, especially if dune-project starts reordering dependency lists, especially if it's according to changes in the version of Dune that is generating the files (though I'm sure they would tend to avoid that), if it ever creates fake blame because the file is generated and it's decided that it's not important to keep its history tidy.

The outcome of such plans is not pre-determined, but depends on the actual ability of Dune to convince the community at large to use it in this way

From my perspective it seems like it's very much decided that Dune is going to be the preferred tool for this in the future. I also think there is value in adopting a tool earlier, even if it's not perfect, and dealing with the papercuts, helping bring it's development forward. However I now see that from a library author's perspective this is not the most desirable outcome.

I'll take an updated look locally at what the Dune-only workflow is like these days.


Configuration#6:Step#1: simulating alpha_S=0.4, matter: q_0=1 | matterlbt: q_0=2: matter04

run the simulation with the above config by jetscape,
transfer the final state hadron to the related directory named as config-XX-final-state-hadrons
after doing step1 on all 12 simulations go to step 2 for the configurationX

port to Excel for overleaf


info argument of field_validator in docs

Initial Checks

[X] I confirm that I'm using Pydantic V2 installed directly from the main branch, or equivalent

Description
While looking at the docs of validators: https://docs.pydantic.dev/dev-v2/usage/validators/, the following example is being used:
@field_validator('password2')
def passwords_match(cls, v, info: FieldValidationInfo):
    ...

And then some information about the available arguments:

you can also add any subset of the following arguments to the signature (the names must match):
values : a dict containing the name-to-value mapping of any previously-validated fields
...
But info seems to be missing here

Maybe this part of the docs is still in the process of being updated, but wanted to raise an issue just in case it wasn't.
Example Code
No response
Python, Pydantic & OS Version
2.0b3

Closing as it seems the rest of the content of the validators section is not yet updated, so I believe this will get corrected at some point.


Update utility.styl

tab alignment and width is not correct on tab device. tested with iPad devices

Thank you for your contribution!

Thanks for amazing framework!


Add BUET email domain

University CSE department Website: https://cse.buet.ac.bd/
Course List consisting Undergraduate: https://cse.buet.ac.bd/studies/ug_courses
Course List Masters/PhD: https://cse.buet.ac.bd/studies/pg_studies
Faculty Email: https://cse.buet.ac.bd/home/contact
Undergrad Email domain has a prefix - ugrad

@triplemzim First stage of verification passed, official domain is buet.ac.bd as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision. Proof of domain ownership: https://cse.buet.ac.bd/personnel/officers.php

https://github.com/JetBrains/swot/commit/6ff47c4e32115ccb259c5ebb023c45eaa79c3235#commitcomment-134631559
Previously the domain buet.ac.bd was added to fraud list. hope you will be able to review it. Thanks a lot. @philipto

@triplemzim Thank you for your patience while waiting for a review and processing your request. Pull request merged.
I removed the domain buet.ac.bd from the stoplist. If there will not be further violations, everything should be OK with the domain. Thank you!


⚠ Bofrost.lu has degraded performance

In 2bc463a, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 942 ms

Resolved: Bofrost.lu performance has improved in f48a3e6 after 6 minutes.


feat: Close side menu on article selection.

Fixes #52

landed in d0c4582012
Manually landed to add TODO comment about magic number


Added TraceParserGen

I've added the source for TraceParserGen from OneDrive  (traceParserGen.src.zip). According to @vancem this is the most recent code for it.
I've verified it works with my manifest, but haven't tested it extensively.
The code contains quite a lot of various #if preprocessor blocks; enabling some of them makes the code not compile or run again. One particular part that's disabled is the ability to generate a parser from a .mof file, which I'm interesting in having. I may spend some time getting that to work again, but that's for a different PR.

@rovarma,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@rovarma, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, Microsoft Pull Request Bot

@vancem I assume this is a straightforward inclusion of the original code. There are some minor tweaks to the project and solution file that will be needed for uniformity. I can push these changes to rovarma/perfview prior to merging this pull request, but need to know whether to do it before or after #319 is merged.

@sharwell Yes, the code is an unmodified version of the code on OneDrive. I'm not sure what tweaks are needed, but feel free to do so :)

Looks good.     The most pressing things to update is a bit of documentation.   Still this is forward progress.

@vancem Cool, I'll merge this into #319 and do the necessary updates there.


Including varchar and char sql types to avoid Sql.Exception on Entity Framework

Do you know when this is likely to get merged/pushed to nuget?

Hello @chicoribas ,
I will close this branches since I believe this fix has already been made a few months ago.
https://github.com/zzzprojects/EntityFramework-Effort/blob/master/Main/Source/Effort.Shared/EffortProviderManifest.xml#L28-L43
Best Regards,
Jonathan


frontend: add - content to shared favorites page

current:
The shared favorites page has no content
example:
https://movie-app-group13.netlify.app/public-profile?userId=5
desired:
hydrate shared page content ( when backend API route is complete)

this issue is now under #149


Add paginatorWithPathPattern:withParameters to RKObjectManager

Add method to RKObjectManager:
paginatorWithPathPattern:withParameters
It would take a parameters NSDictionary instead of requiring the pagination parameters to be included in the pathPattern string.

+1 - Any plans on this one?


feat: add InfoBanner component

What:
Adds the InfoBanner component following the designs.

Why:
Several projects are using custom implementations of this component, by having it in Wave we will be able to use it as a single source of truth.

Media:

Checklist:

[x] Base implementation
[x] Unit tests
[x] Documentation
[ ] Review the a11y
[x] Change the text alignment to be left-aligned
[ ] Ready to be merged

Closes #192

The implementation is clean 👍
The only thing that is lacking is an accessibility markup. If we intend to use this banner as an alert, we should follow the accessibility practices so screen reader and other assistive technologies can notify user that the banner has appeared.
As I understand:

success and error banners are supposed to have an alert role. When they appeared on the page, they will be announced no matter the user's focus

info and warning banner should have the status role + aria-controls (ideally, as a mandatory prop) indicating what is the part of the UI responsible for this banner.

[ ]  Check the a11y of the component

Hey @nlopin, I totally agree with you that the component is currently lacking accessibility, I understand the alert and status roles based on the banner variant, but I've got a question regarding the aria-controls.
After reading the MDN docs about aria-controls, particularly this example:

An accordion header button toggling the visibility of the accordion panel's content: the accordion header button would have aria-controls set to the ID of the element containing the accordion panel content.

I understood that the element that "controls" is the one that needs the prop, as I understand it it would be something (e.g. a button, checkbox, etc...) which triggers the InfoBanner to appear and in that case the aria-controls should be set in the button/checkbox as the id which is set in the InfoBanner, I've never used aria-controls so I'm not sure if I'm understanding it properly.

@martimalek I just realized that in the examples the text is vertically centered.

@rafael-sepeda I didn't notice the alignment issue, I'll fix it before merging

I've fixed the alignment and updated the descriptions image

@martimalek I was talking to @nlopin and we could start releasing this first version, then we will add the a11y features.

I've created a separate issue to tackle a11y #249

🔥🔥🔥🔥🔥🔥
@nlopin , @martimalek
Since we do not have the live demo for this component could you describe what went into implementation so I can tell other designers?


Frozen collection

Hi,
Is it possible to model in phantom the:
sth frozen<map<text,text>>,

?
Additionally frozen collection should be possible to use with primary key.

Hi @mmatloka,
Not at this time. We will add a feature request to be included in the roadmap, I think it's already there. Right now our focus is on prepared statements which are close to being done.
Regards.

Hi @alexflav23
I am going to contribute on UDT and frozen stuffs.
As far as I understood from other issue comments you internally are working on UDT support (Please correct me if I am wrong).
Is it possible to work on it in a public github branch? then I will have opportunity to contribute on it.

Hi @psycho-ir,
What we have on UDTs is already in. Perhaps we will share the end DSL we are trying to achieve and we can start from there, see if you have better ideas about what DSL we can offer. Some minimal version of UDTs is already working, but our effort has been primarily targeting prepared statements and other efforts, so there has been a lot of work around that.
Regards.

hey, were frozen already included with udt? Now I need some more advanced scenario of  map<int,FROZEN<tuple<decimal, text>>> ;)

Hi @mmatloka,
Sorry for the late reply on this one, I think this is not yet implemented in the UDT part of the framework, we are still trying to find best ways for a number of things. The known way, which involves a lot of Shapeless, does work, but presents some challenges in IDE highlighting and whatnot.
Regards.

HI @mmatloka,
Frozen collections coming in 1.29.4, this is handled invisibly at driver level so if you use a list column together with a primary key, it will be automatically frozen in the schema. Apologies for the long winded delivery on this, I'm not exactly sure how it skipped the pipeline so far.
More advanced freezing is coming with tuple support in 2.0.0 as well, if you have any more advanced cases to address we can deal with those too now, as primitives are now infinitely smarter in phantom.
Regards.