Error after upgrading from mattermost-docker manually

Dear Community!
I have upgraded the database before manually (using the scripts) and now I wanted to move to this new repo.
After starting up the containers (I'm using it without nginx, with another reverse proxy - caddy), the only logs I can see:
{"level":"error","ts":1630660849.027481,"caller":"log/log.go:184","msg":"[ERR] plugin: plugin acceptAndServe error: timeout waiting for accept","source":"stdlog"}

{"level":"error","ts":1630660849.0275328,"caller":"log/log.go:184","msg":"[ERR] plugin: plugin acceptAndServe error: timeout waiting for accept","source":"stdlog"}

{"level":"error","ts":1630660849.0275788,"caller":"log/log.go:184","msg":"[ERR] plugin: plugin acceptAndServe error: timeout waiting for accept","source":"stdlog"}

{"level":"error","ts":1630660849.3331985,"caller":"log/log.go:184","msg":"[ERR] plugin: plugin acceptAndServe error: timeout waiting for accept","source":"stdlog"}

{"level":"error","ts":1630660852.308998,"caller":"log/log.go:184","msg":"[ERR] plugin: plugin acceptAndServe error: timeout waiting for accept","source":"stdlog"}

{"level":"error","ts":1630660852.3092558,"caller":"log/log.go:184","msg":"[ERR] plugin: plugin acceptAndServe error: timeout waiting for accept","source":"stdlog"}

Database logs:
2021-09-03 09:15:48.713 UTC [84] ERROR:  relation "idx_teammembers_team_id" does not exist

2021-09-03 09:15:48.713 UTC [84] STATEMENT:  SELECT $1::regclass

2021-09-03 09:15:48.714 UTC [84] ERROR:  relation "idx_teams_name" does not exist

2021-09-03 09:15:48.714 UTC [84] STATEMENT:  SELECT $1::regclass

2021-09-03 09:15:48.769 UTC [84] ERROR:  constraint "fk_retentionpolicieschannels_retentionpolicies" for relation "retentionpolicieschannels" already exists

2021-09-03 09:15:48.769 UTC [84] STATEMENT:

		ALTER TABLE RetentionPoliciesChannels

		ADD CONSTRAINT FK_RetentionPoliciesChannels_RetentionPolicies

		FOREIGN KEY (PolicyId) REFERENCES RetentionPolicies (Id)

		ON DELETE CASCADE;

2021-09-03 09:15:48.770 UTC [84] ERROR:  constraint "fk_retentionpoliciesteams_retentionpolicies" for relation "retentionpoliciesteams" already exists

2021-09-03 09:15:48.770 UTC [84] STATEMENT:

		ALTER TABLE RetentionPoliciesTeams

		ADD CONSTRAINT FK_RetentionPoliciesTeams_RetentionPolicies

		FOREIGN KEY (PolicyId) REFERENCES RetentionPolicies (Id)

		ON DELETE CASCADE;

2021-09-03 09:15:52.070 UTC [87] ERROR:  duplicate key value violates unique constraint "users_username_key"

2021-09-03 09:15:52.070 UTC [87] DETAIL:  Key (username)=(surveybot) already exists.

2021-09-03 09:15:52.070 UTC [87] STATEMENT:  insert into "users" ("id","createat","updateat","deleteat","username","password","authdata","authservice","email","emailverified","nickname","firstname","lastname","position","roles","allowmarketing","props","notifyprops","lastpasswordupdate","lastpictureupdate","failedattempts","locale","timezone","mfaactive","mfasecret","remoteid") values ($1,$2,$3,$4,$5,$6,$7,$8,$9,$10,$11,$12,$13,$14,$15,$16,$17,$18,$19,$20,$21,$22,$23,$24,$25,$26);

2021-09-03 09:20:41.162 UTC [100] ERROR:  relation "idx_posts_channel_id" does not exist

2021-09-03 09:20:41.162 UTC [100] STATEMENT:  SELECT $1::regclass

2021-09-03 09:20:41.163 UTC [100] ERROR:  relation "idx_channels_name" does not exist

2021-09-03 09:20:41.163 UTC [100] STATEMENT:  SELECT $1::regclass

2021-09-03 09:20:41.177 UTC [100] ERROR:  relation "idx_publicchannels_name" does not exist

2021-09-03 09:20:41.177 UTC [100] STATEMENT:  SELECT $1::regclass

2021-09-03 09:20:41.178 UTC [100] ERROR:  relation "idx_channelmembers_channel_id" does not exist

2021-09-03 09:20:41.178 UTC [100] STATEMENT:  SELECT $1::regclass

2021-09-03 09:20:41.179 UTC [100] ERROR:  relation "idx_emoji_name" does not exist

2021-09-03 09:20:41.179 UTC [100] STATEMENT:  SELECT $1::regclass

2021-09-03 09:20:41.179 UTC [100] ERROR:  relation "idx_oauthaccessdata_client_id" does not exist

2021-09-03 09:20:41.179 UTC [100] STATEMENT:  SELECT $1::regclass

2021-09-03 09:20:41.180 UTC [100] ERROR:  relation "idx_oauthauthdata_client_id" does not exist

2021-09-03 09:20:41.180 UTC [100] STATEMENT:  SELECT $1::regclass

2021-09-03 09:20:41.181 UTC [100] ERROR:  relation "idx_preferences_user_id" does not exist

2021-09-03 09:20:41.181 UTC [100] STATEMENT:  SELECT $1::regclass

2021-09-03 09:20:41.181 UTC [100] ERROR:  relation "idx_notice_views_user_id" does not exist

2021-09-03 09:20:41.181 UTC [100] STATEMENT:  SELECT $1::regclass

2021-09-03 09:20:41.182 UTC [100] ERROR:  relation "idx_notice_views_user_notice" does not exist

2021-09-03 09:20:41.182 UTC [100] STATEMENT:  SELECT $1::regclass

2021-09-03 09:20:41.183 UTC [100] ERROR:  relation "idx_status_user_id" does not exist

2021-09-03 09:20:41.183 UTC [100] STATEMENT:  SELECT $1::regclass

2021-09-03 09:20:41.184 UTC [100] ERROR:  relation "idx_teammembers_team_id" does not exist

2021-09-03 09:20:41.184 UTC [100] STATEMENT:  SELECT $1::regclass

2021-09-03 09:20:41.185 UTC [100] ERROR:  relation "idx_teams_name" does not exist

2021-09-03 09:20:41.185 UTC [100] STATEMENT:  SELECT $1::regclass

2021-09-03 09:20:41.186 UTC [100] ERROR:  relation "idx_user_access_tokens_token" does not exist

2021-09-03 09:20:41.186 UTC [100] STATEMENT:  SELECT $1::regclass

2021-09-03 09:20:41.187 UTC [100] ERROR:  relation "idx_user_terms_of_service_user_id" does not exist

2021-09-03 09:20:41.187 UTC [100] STATEMENT:  SELECT $1::regclass

2021-09-03 09:20:41.188 UTC [100] ERROR:  relation "idx_users_email" does not exist

2021-09-03 09:20:41.188 UTC [100] STATEMENT:  SELECT $1::regclass

2021-09-03 09:20:41.188 UTC [100] ERROR:  relation "idx_sharedchannelusers_user_id" does not exist

2021-09-03 09:20:41.188 UTC [100] STATEMENT:  SELECT $1::regclass

2021-09-03 09:20:41.189 UTC [100] ERROR:  relation "idx_retentionpolicies_displayname_id" does not exist

2021-09-03 09:20:41.189 UTC [100] STATEMENT:  SELECT $1::regclass

2021-09-03 09:20:41.211 UTC [100] ERROR:  constraint "fk_retentionpolicieschannels_retentionpolicies" for relation "retentionpolicieschannels" already exists

2021-09-03 09:20:41.211 UTC [100] STATEMENT:

		ALTER TABLE RetentionPoliciesChannels

		ADD CONSTRAINT FK_RetentionPoliciesChannels_RetentionPolicies

		FOREIGN KEY (PolicyId) REFERENCES RetentionPolicies (Id)

		ON DELETE CASCADE;

2021-09-03 09:20:41.212 UTC [100] ERROR:  constraint "fk_retentionpoliciesteams_retentionpolicies" for relation "retentionpoliciesteams" already exists

2021-09-03 09:20:41.212 UTC [100] STATEMENT:

		ALTER TABLE RetentionPoliciesTeams

		ADD CONSTRAINT FK_RetentionPoliciesTeams_RetentionPolicies

		FOREIGN KEY (PolicyId) REFERENCES RetentionPolicies (Id)

		ON DELETE CASCADE;

2021-09-03 09:20:48.339 UTC [105] ERROR:  duplicate key value violates unique constraint "users_username_key"

2021-09-03 09:20:48.339 UTC [105] DETAIL:  Key (username)=(surveybot) already exists.

2021-09-03 09:20:48.339 UTC [105] STATEMENT:  insert into "users" ("id","createat","updateat","deleteat","username","password","authdata","authservice","email","emailverified","nickname","firstname","lastname","position","roles","allowmarketing","props","notifyprops","lastpasswordupdate","lastpictureupdate","failedattempts","locale","timezone","mfaactive","mfasecret","remoteid") values ($1,$2,$3,$4,$5,$6,$7,$8,$9,$10,$11,$12,$13,$14,$15,$16,$17,$18,$19,$20,$21,$22,$23,$24,$25,$26);

Hey @radokristof, the first error is a plugin error and should not be disruptive or severe. If you experience plugin issues please open them in the plugin repository. The second database related errors are somewhat expected as the database bails intentionally and decide how to proceed. If there are no other issue this can be closed as it is not specific to the migration between mattermost-docker -> docker but the upgrade to version >=5.37.

Thanks, issue was fixed by setting the correct ListenAddress (port) in the config.json file

@craph If I remember correctly, yes, I just had to set the ListenAddress in the config.json file.

@radokristof Thank you for the update. I checked my config.json file and the ListenAddress point to 8065. So it's correct.
But I still Have the same error in the Postgres logs...
Any advise ?

@craph Well, these postgres logs really don't mean anything bad. For me it stayed showing these after fixing the ListenAddress.
My setup looks like this: The mattermost is served in localhost only and an additional reverse proxy (caddy) provides https access to mattermost.
So for me, I also had to check these ports.
How are you starting the containers? Are you using the repos docker-compose files or you created an own docker-compose file?
If using the default, start with the without-nginx docker-compose file as well. Otherwise the 8065 inside port is not exposed.
There might be additional discussion about this here:
https://github.com/mattermost/docker/pull/33

Hi @radokristof ,
I'm using the docker-compose files from this repo.
I'm running Mattermost like this : docker-compose -f docker-compose.yml -f docker-compose.nginx.yml up -d
If I check the status of the container it is Healthy so it seems there are no issue...
e615070864e8        nginx:alpine                              "/docker-entrypoint.…"   44 hours ago        Up 44 hours             <IP_ADDRESS>:8008->80/tcp, <IP_ADDRESS>:4434->443/tcp   nginx_mattermost
1b801f271397        mattermost/mattermost-team-edition:5.38   "/entrypoint.sh matt…"   44 hours ago        Up 44 hours (healthy)   8065/tcp, 8067/tcp, 8074-8075/tcp             mattermost
db007102c2eb        postgres:13-alpine                        "docker-entrypoint.s…"   44 hours ago        Up 44 hours             5432/tcp                                      postgres_mattermost

Sorry but I don't understand why I should use with the without-nginx for the port 8065... I'm not using an external proxy and I want to use Mattermost like it was in the previous repo...

@craph
Ohh, I see. Sorry but I don't use the builtin nginx proxy, but I will try to help.
Take a look at the docker-compose.nginx.yml file:
https://github.com/mattermost/docker/blob/main/docker-compose.nginx.yml
There is no APP:PORT defined here. Neither in docker-compose.yml.
So I would assume that if you use it that way, then these ports will be exposed (by nginx):
    ports:
      - ${HTTPS_PORT}:443
      - ${HTTP_PORT}:80

And no other ports are exposed by the mattermost container.
And the HTTP_PORT and HTTPS_PORT is defined in the .env.example:
## Exposed ports to the host. Inside the container 80 and 443 will be used
HTTPS_PORT=443
HTTP_PORT=80

And the nginx is really listening on port 80 (inside) so then I would think you also need to change the ListenAddress in the config.json file.

@craph Ohh, I see. Sorry but I don't use the builtin nginx proxy, but I will try to help.
Take a look at the docker-compose.nginx.yml file:
https://github.com/mattermost/docker/blob/main/docker-compose.nginx.yml
There is no APP_PORT defined here. Neither in docker-compose.yml.
So I would assume that if you use it that way, then these ports will be exposed (by nginx):
    ports:
      - ${HTTPS_PORT}:443
      - ${HTTP_PORT}:80

And no other ports are exposed by the mattermost container. And the HTTP_PORT and HTTPS_PORT is defined in the .env.example:
## Exposed ports to the host. Inside the container 80 and 443 will be used
HTTPS_PORT=443
HTTP_PORT=80

And the nginx is really listening on port 80 (inside) so then I would think you also need to change the ListenAddress in the config.json file.

Sorry but again, I don't understand why I need the port 8065 to solve the errors in Postgres... My original question was about how to solve Postgres errors. You can have a look to this issue I opened with some clue about the origin of the error in Postgres
In my config.json file I have already set the ListenAddress to 8065 and it's working with the nginx compose file too.
@mrckndt Please can you help me to understand it ?
Thank you very much.
Best regards,

@craph
Sorry but then I completely misunderstood your problem.
I had these errors in the postgres log and I still have it (even on mattermost 6.0), but as said before by @mrckndt
The second database related errors are somewhat expected as the database bails intentionally and decide how to proceed. If there are no other issue this can be closed as it is not specific to the migration between mattermost-docker -> docker but the upgrade to version >=5.37.

However I understand that these warnings/errors in the log is not good as it makes it harder to investigate further problems (that's why I have opened this issue at first place, because I also assumed that these database errors causing the problem after migration - I was not able to access mattermost anyhow) and it turned out (for me) that the problem was related to port misconfiguration.


Better error message for misuse of T.class_of(SomeModule)

Input
→ View on sorbet.run
# typed: true
extend T::Sig

module SomeModule
  extend T::Helpers

  module ClassMethods
    def foo
      "foobar"
    end
  end
  mixes_in_class_methods(ClassMethods)
end

sig {params(klass: T.class_of(SomeModule)).void}
def example(klass)
  # For "method does not exist" error on singleton class of module,
  # check if that module has a mixes_in_class_methods method
  # defined with the same name, and suggest changing the type.
  klass.foo
end

Observed output
editor.rb:20: Method foo does not exist on T.class_of(SomeModule) https://srb.help/7003
    20 |  klass.foo
                ^^^
  Got T.class_of(SomeModule) originating from:
    editor.rb:16:
    16 |def example(klass)
                    ^^^^^
Errors: 1

Expected behavior

It would be nice to give more context on this error like, "It looks like you're trying to use T.class_of with a module to call methods defined via mixes_in_class_methods. You should use SomeModule::ClassMethods or T.all(T::Class[SomeModule], SomeModule::ClassMethods) instead"

Can I work on this issue? @jez

@jez I don't quite understand the code example you give for this issue.
The signature of example method says that klass is of type T.class_of(SomeModule) but the singleton class of SomeModule would not be in the ancestor chain of any valid class/module through include or extend (as you so eloquently describe in your blog post about Ruby inheritance), so no valid object could match that type. Only valid value that can be supplied to example would be SomeModule and that would never have the foo method on it anyway. See the sorbet.run example here.
Even if the example is supposed to represent the case where Sorbet can help fix the error, the suggested error message is still not correct, since it should read T.all(Class, SomeModule::ClassMethods) as the suggested type and not T.all(T::Class[SomeModule], SomeModule::ClassMethods).
Am I missing something?


Support code sections in docs

Using code sections in docs with triple ''' does not keep the indentation.
Example is: amp-list where the json inside the docs is not correctly indented.

Will you be working on this?


MVVM

Hello!
How do I get instance VideoPlayer in ViewModel when using MVVM?

This is necessary in order to stop the video playback when using CarouselView.

This doesn't sound specific to this component. The question could be more broadly stated as - how do I bind a Xamarin Forms control to a view model property. Maybe this could help:
https://forums.xamarin.com/discussion/71593/how-do-i-use-xaml-to-bind-to-a-property-inside-a-class-instance-in-the-view-model

Closing due to inactivity.


tsconfig.json exclude LS support

@CyrusNajmabadi, @vladima,  @billti : CoreServicesShimHost and CoreServicesShimHostAdapter changes to support tsconfig.json exclude from the language service.

:+1:

:+1:


LLM Preference using Azure OpenAI - answer streaming does not work

I tried using the Azure OpenAI LLM, the answer will not stream out, the processing icon just spins and after a while, the answer appears. When I changed the LLM preference to OpenAI, the answer streaming is working.

Are you sure that your Azure OpenAI settings are input correctly? You need to be using the proper Endpoint and a valid streamable model from Azure. You should be able to use the same inputs and credentials in a regular POST request

I just re-read this issue. So you do get the answer, you just want it streamed. When we implemented Azure streaming was not available and we have not revisited it since initial integration.
Updating issue now.


How to remove the phone field in contact form

Hi,
When I comment out the phone field in the contact fom as
# [params.contact.form.phone] 	    # text = "Your Phone *" 		# warning = "Please enter your phone number."
it still shows as in attachment.
Plz guide how to remove it completely.
Thanks in advance.

Hello @Shwelu,
first of all excuse my late response. [params.contact.form.phone] only changes the placeholder in the text field. There is no direct option to hide this field from the form.
Therefore, we have to modify the corresponding template. Either delete the highlighted lines or comment them out.

Is this still an issue?

Closing this as stall.

Could be reopened with the title: "Only show non empty contact form fields".
That might be something I can work on next time I get the time.

If I understand you correctly you would like to hide certain input fields of the form if no text attribute was set in the config file?

Right. The thought in addition was that this issue is related and might work better than opening another one ;)


Development

What type of PR is this? (check all applicable)

[ ] Refactor
[ ] Feature
[ ] Bug Fix
[ ] Optimization
[x] Documentation Update

Description
Related Tickets & Documents

Related Issue #
Closes #

QA Instructions, Screenshots, Recordings
Please replace this line with instructions on how to test your changes.
[optional] Are there any post deployment tasks we need to perform?

updated dev


Unity editor crashes when loading renderdoc using vulkan api

Description
Unity editor crashes when loading renderdoc using vulkan api.
I found that the following modifications caused，this caused vkCreateDevice hook failed.

Steps to reproduce

open unity2020
load renderdoc

Environment

RenderDoc version: 1.30
Graphics API: vulkan

This is a Unity bug not a RenderDoc bug.
I am able to load renderdoc and capture Unity  2022.3.5f1 Vulkan Editor


Fail pipeline on failed tests

I am running the command successfully on GitLab, but as far as I can see a GitLab pipeline only failes if one of the command raises an error.
Would it be possible to raise an error if at least one test failed?
Maybe controllable via switch?

Run-TestsInBcContainer has a switch called -returnTrueIfAllPassed
Add that - and if it returns false - throw.
Will that work?

Sorry, forgot to write that I use the "Run-AlPipeline" command. Does something like this exists with this command too?

Nope - I should add a parameter like -azureDevOps called -gitlab to set these things.

and -githubActions

Is it only Run-Tests you are running into at this time?

Cant tell for sure. The rest of the pipeline works for now.

Shipped in BcContainerHelper 1.0.13-preview256


How to interrupt model generation when the content is generated？

How can I stop the content generation of model based on request_id, release resources?

#175 has been fixed


Third attempt at fixing the Travis builds

One more try… apparently the magic word for sudo is "required", and not "true", whereas to turn it off, it is "false" … :S

@reactive-streams/contributors Third attempt, now with magical incantation added


Improve Bulksql Schema Check

Currently Select * https://github.com/denisenkom/go-mssqldb/blob/78a11f640437e0807f8bf101411762c8adbe7574/bulkcopy.go#L282 is executed on bulk inserts for the entire table which results in blocks and long running queries when someone tries to do a schema modification (since the SELECT is isolation level COMMITED).
Thinking this should be:

Maybe use INFORMATION_SCHEMA.COLUMNS
Possibly add a schema cache?

Our use case involves doing a high volume of bulk inserts to a large number of tables (~5000 tables,  ~7000 bulk inserts per minute). Fetching the metadata, while fairly light, takes a significant amount of effort at that volume.
Would like to streamline the query as much as possible, and possibly add some kind of mode to use cached metadata, or just trust the column set given by the caller. Not sure what the best mechanism to activate that would be.

I want to inspect and work on the bulk API soon. This is valuable information.


Deal with race conditions when experiment.current_submissions is updated

Or just stop using a hard counter and instead dynamically fetch and count them each time it is needed.

https://github.com/babe-project/BABE/commit/9a9f860eaf8db3c66335769ab2009e602e87944b


Add validation results to oo

@dmuylwyk I actually thought of an even better way to implement this.
Review pls.

Coverage decreased (-0.006%) to 81.776% when pulling 901e256417493975e147edcce394384aa02a7dcf on add_validation_results_to_oo into a867890554af56a4ed96ee3ffe3eb91de6b5f4a5 on master.

Coverage increased (+0.009%) to 81.79% when pulling 6749e314f979953c9706f8fff6d651959eff21e8 on add_validation_results_to_oo into a867890554af56a4ed96ee3ffe3eb91de6b5f4a5 on master.


New README

Describe changes
I reduced the README to be more to the point. Find the view here: https://github.com/zenml-io/zenml/tree/feature/FRW-1880-readme-rehaul
Broken Images will be dealt with still.
Pre-requisites
Please ensure you have done the following:

[ ] I have read the CONTRIBUTING.md document.
[ ] If my change requires a change to docs, I have updated the documentation accordingly.
[ ] If I have added an integration, I have updated the integrations table and the corresponding website section.
[ ] I have added tests to cover my changes.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Other (add details above)

I've spent a few minutes thinking this one through. I have a hard time seeing how to weave this into the README with no further context. There are so many things that could go wrong if someone just runs this.  Better to point to the docs, no? We can at least show stack switching, but prod deployment, I would leave to the docs


Loader the executes JS and returns its exports

I'm trying to write a loader that takes an object and returns a string:
function myLoader(content: object): string {
    return myTransform(content);
}

I want to be able to apply this loader to JS module files with a custom extension:
// some-file.my-ext
export default { some: 'object' }

So I'm looking for a loader that can be run before mine, that will read the file and give me its exported contents:
{ default: { some: 'object' } };

Does anything like this already exist?

Additional Notes
The loader should Import other JS files from these custom files
// normal-js-file.js
export default 42;

// other-file.my-ext
import value from './normal-js-file';
export const x = `the value is ${value}`;

So I want my loader to receive:
{ x: { 'the value is 42' } }

The loader should mark all imported files as dependencies
In the example above, the loader should mark normal-js-file.js as a dependency.
Also, if normal-js-file.js itself had dependencies, they should be marked as well.
Use other loaders to load the custom file and its dependencies
Since the user is using his own JS loaders (like babel, ts, etc.), I want the loader to use these user-defined .js loaders to also load my custom .my-ext files, and all imports from .my-ext should work as usual (with existing loaders):
// some-file.my-ext
import jsFile from 'js-file';
import es6File from 'file.es6';
import pngFile from 'file.png';

export { jsFile, es6File, pngFile };

So, does something like this exist? Or am I going about it all wrong?

What's the use case for this? Is the problem relevant with webpack 2?

I haven't looked much into webpack 2 yet. I still think this is relevant, unless webpack 2 somehow addresses this issue already.
A year ago I've worked on a small project to create a "js-to-css" transpiler. I wanted to create a loader for this transpiler. The idea was to transform Javascript objects such as { body: { "background-color":  "black" } } to corresponding CSS declarations: body { background-color: red; }.
Of course, there would be many utility functions and all other possible JS-goodness that would contribute to create these CSS JS objects, so I want a loader that can simply take the exported object of a module after all relevant Webpack transformations have been applied to it.

Feel free to look at webpack.js.org/api/loaders for all of the options that you can use. Since this is more support/question, I'm going to close this issue in favor of recommending you reach out to gitter.im/webpack/webpack or StackOverflow, etc.


Ensure Bolt is compatible with Puppet agent 7

Use Case
The Puppet 7 release is coming up, and it'd be great if we could ensure Bolt is usable with Puppet 7 when it's released or shortly after. This includes:

[x] Test what gem versions are compatible with bolt. Update the maximum Puppet versions in our gemfile if possible.
[x] Validate how the release will impact apply_prep and apply? Will puppet 7 be installed and work seamlessly? Should we pin the default puppet_library to use puppet 6 for now? What about macos and windows?
To answer this question a little bit, Puppet 7 will be installed by the puppet_agent::install task by default if we do nothing.
It sounds like there aren't any breaking Puppet language changes. The main changes I would be worried about are the following:

Apt provider  ensure: held  (replaced by  mark: hold DirectoryService#write_to_file) (PUP-10597)
NameService.listbyname (replaced by NameService.instances) (PUP-10488)
Puppet::Util::Execution.execpipe method (deprecated) (PUP-7584)
Puppet::Resource.set_default_parameters (PUP-10474)
Puppet::Resource.validate_complete (PUP-10474)
Puppet::Resource::Type.assign_parameter_values (PUP-10474)

Do we also want to do an hour of exploratory testing off the main Puppet branch to anticipate any other changes to add to the 3.0 doc? It seems like a good idea, but we can wait until closer to releasing 3.0 to do it.

Plan is to leave the puppet_agent::install to pull in latest (Puppet 7), but wait to update the Puppet we ship with Bolt until Bolt 3.0.


Supporting react-native

I love this library and would like to help porting it to react-native 🎉
@fangpenlin Would you prefer me to create a seperate react-native-avataaar repo and import the original avataaar as a dependency or try to work on a pull request so this repo supports both web and react-native (via react-native-svg)?

Would love to see this in react native

https://github.com/react-native-community/react-native-svg/issues/989
Actually I did implement but there are lots of performance issues and most of the avatar components doesn't supported by react-native-svg due to lack of filter support.

@zek too bad :(

I'd be interested in having a RN version of this too. This is too good to miss out on:)

@fangpenlin, please see if you can create repository for the react native code you have worked till now and share.


⚠ Bofrost.be has degraded performance

In 7786b31, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 930 ms

Resolved: Bofrost.be performance has improved in 7f58745.


Ability to store metadata/settings as part of Client <-> User relationship

There can be use cases where developers wish to store settings/metadata about a user specific to a client. (For example, theme name, styling, avatar, display name, etc.)
Few initial implementation ideas:

Provide an abstract UserClient model with user_id and client_id fields that developers could subclass.
Provide an UserClientSettings model with user_id, client_id, metadata = JsonField fields that developers can directly use.

Model should provide a shortcut method:
def get_current(request: "rest_framework.request.Request") -> UserClient

More ideas welcome.

Some initial code is there in branch: dev-issue7


[Help] How to select a row by code.

Hi, I need some help to know how to select a row by line of code. I have tried this without success:

Using currentSelectingRows
stateManager.currentSelectingRows.clear();
stateManager.currentSelectingRows.add(rendererContext.row);

Using toggleSelectingRow
stateManager.toggleSelectingRow(currentRowkr, notify: true);

Using setCurrentSelectingRowsByRange
stateManager.setCurrentSelectingRowsByRange(currentRowkr, currentRowkr);

My PlutoGrid definition:
PlutoGrid(
mode: PlutoGridMode.selectWithOneTap,
columns: columns,
rows: rowsDados,
onSelected: (event) {
currentRowkr = event.rowIdx ?? -1;
},
onLoaded: (PlutoGridOnLoadedEvent event) {
stateManager = event.stateManager;
stateManager
.setConfiguration(
stateManager.configuration.copyWith(localeText:
const PlutoGridLocaleText.brazilianPortuguese(),
columnSize: PlutoGridColumnSizeConfig(
autoSizeMode: PlutoAutoSizeMode.none)));
stateManager.setSelectingMode(PlutoGridSelectingMode.row);
},
)

select
event.row!.setChecked(true);
stateManager.notifyListeners();
unselect
event.row!.setChecked(false);
stateManager.notifyListeners();


overlayWith is still available in d.ts but does not exist at runtime.

The method overlayWith does not exist anymore. In this docs it was removed and we should use composite. I have not yet an idea how to use it to replace the overlayWith. But I see that this method is still in the declaration file. It's automatically installed during the npm install process at is at version 0.22.
Btw. the replacement of
.overlayWith(mask, { cutout: true })
is
.composite([{ input: mask, blend: 'dest-in' }])
sharp version 0.23.0

Typescript definitions are managed by the maintainers of the https://github.com/DefinitelyTyped/DefinitelyTyped repo so please report this downstream.


EFCore Use timestamps to control concurrency problems

EFCore Use timestamps to control concurrency problems
follow the link below:
_https://github.com/aspnet/EntityFrameworkCore/issues/16236_
This looks like a MySQL database provider issue. I'm not sure what the mapping was in EF6 when using MySQL, but it sounds like the EF Core provider will need to support the same things for this to work. I suggest you follow up at: https://github.com/PomeloFoundation/Pomelo.EntityFrameworkCore.MySql
but, it's not "Pomelo.EntityFrameworkCore.MySql" problem, it's the same error when I switch to sqlserver, so it's still EFCore problem

Closing in favor of the original issue https://github.com/aspnet/EntityFrameworkCore/issues/16236, since there is more information there.


Add image zoom functionality on smaller devices

Awesome work!
I think it would be a great feature if users would be able to zoom the image on smaller devices (Phone and Tablets). Right now some images with desktop resolutions may not be clearly visible.
Thanks

Thanks for the kind words. This would be indeed a very nice enhancement which I was thinking about, but I'll have to have a look around first to see how others did it. :wink: It will be added at some point but I can't promise when.

Thank you, looking forward to it 🙂


Build Log Archiving on Custom S3 Buckets

Adding more details to our feature on archiving of build logs to custom S3 buckets after these details have been asked on a few instances.

@lizrabuya, I'm skimming through old PRs to see if there are any I can quickly resolve, and this looks like a good candidate. I'll update the branch, incorporate the final suggestions, and merge for you. Let me know if there are any issues with that. 😊


fix: block explorer

Describe the bug
Error view transaction history on block Explorer

Steps to reproduce
Steps to reproduce here.
Additional context
Additional context here.

i believe this happens if the transaction is still included in the mempool but hasn't actually been confirmed by any nodes, so you have to wait for it to be picked up out of the mempool, which is why it isn't visible now.
you can see a list of why these might occur on the page. i will close the issue for now, but if you still have concerns or questions we can re-open it, thank you


configuration of tools.webpack is not available

Following the example in the document, I created modern.config.js with following code. But it didn't work.
const { defineConfig } = require('@modern-js/app-tools');

module.exports = defineConfig({
  tools: {
    webpack: { mode: 'development' },
  },
});

By reading the source code here, I found that the only way to make it available is to use webpack-chain.
const { defineConfig } = require('@modern-js/app-tools');

module.exports = defineConfig({
  tools: {
    webpack: (config, { chain }) => {
      chain.mode('development');
    },
  },
});

This may be a bug or the documentation may need to be fixed.

Currently only webpack-chain is available, the document has been updated.
https://modernjs.dev/docs/apis/config/tools/webpack


Fixes cwd on windows

minTTY or other bash consoles might report cwd with forward slashes, these are now replaced with os.sep if the platform is reported as nt.

Issue #339 and PR #340 also handle this.

Damn. This is old. My excuse is that there has been a huge issue / PR backlog that I have been trimming down over the years :man_shrugging:


app.{platform}.scss not renamed to app.css

Hi @toddanglin !
I'm using nativescript-theme-core and webpack with nativescript-dev-sass ......
My problem is that when doing a bundle, the app.android.scss does get compiled to app.android.css, but it doesn't get renamed to app.css
ERROR in Entry module not found: Error: Can't resolve './app.css' in 'C:\00.Dev\nativescriptApp\app'
ERROR in [copy-webpack-plugin] unable to locate 'app.css' at 'C:\00.Dev\nativescriptApp\app\app.css'

Can you hint me where it tries to rename the compiled app.android.css or app.ios.css into the app.css?
Thanks so much for your effort!!!!! Lars

Hmm...
That step (changing [filename].[platform].css to [filename].css) is handled by the NativeScript build process. It SHOULD be applied to all files in the project (images, views, styles, etc). That said, I've not done a lot of work with webpack, so I'm not sure how that affects the process.
@rdlauer @tjvantoll Do you have any ideas here? Have you tried using WebPack with the Core Theme + SASS?

I have not. This surprises me a little because as far as I know this SASS plugin works a whole lot like the TypeScript plugin, and I haven’t had any trouble with TypeScript code not getting compiled before Webpack does its thing.
@sis0k0 Any idea what the problem might be here?

@Dutchboy So...if you take a look at the "demo" project that's included with this repo, and you should see that there is an example that covers this scenario. The demo app has both a app.ios.scss and a app.android.scss.
Based on my local tests with iOS, these files correctly get converted to CSS and then deployed to the app package as app.css.
Now that said, there is no app.css in my app directory, EVEN AFTER the SASS conversion happens. NativeScript takes the correct app.ios.css or app.android.css at build time and renames it to app.css. And just to be sure, I checked and LiveSync works as expected, too.
I'm not using WebPack, though, so I assume the problem has to do with that workflow. Can you try taking the demo app in this repo and seeing if you can re-create the error? That will help me better understand what's happening when you're using WebPack...

Hasn't been any follow-up on this in a while. Going to close as it seems to be working as expected in the demo app. Please feel free to add additional detail if this needs to be re-opened.

Having the same issue


Delete all group related functions

Continuation of #460

Removed Group related projections
Removed all commands linked to group
Removed all group models
Removed all group state variable.
Removed all partial group components

refactored and renamed publishToZeroOrMoreGroup, it is mostly used as sign and send, but in the case of reply or repost, it might still be necessary to publish to groups, let me know and I'll revert that one change.
Overall this might be too aggressive, do we show group summary in "standard" feed? If that's the case, I'll have to bring back a bunch of state function and group components

It should be it with the groups now, have deleted all occurrences.
There is also a pre-commit check now, on format, types and errors

Awesome, reset/merged.


[Bug]: Pulling osmosis error

What happened?
I am trying to pull osmosis package with this command:
go get github.com/osmosis-labs/osmosis/v25
into my cosmos based blockchain but facing bellow issue:
go<EMAIL_ADDRESS>reading github.com/gogo/protobuf/go.mod at revision v1.3.3: unknown revision v1.3.3
Will you please guide me how I can import osmosis in my app.go?
How I can install/download the osmosis package in my go.mod?
Thank you so much
Osmosis Version
main, 25
How to reproduce?
No response

Here you need to add the replace directives that are present in the osmosis go.mod, see => https://github.com/osmosis-labs/osmosis/blob/main/go.mod#L273-L302


Added documentation for AF_INET6 and AF_UNIX socket usage

As it says

Codecov Report

Merging #1375 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1375      +/-   ##
==========================================
- Coverage    81.5%   81.44%   -0.06%
==========================================
  Files          17       17
  Lines        1692     1692
  Branches      321      321
==========================================
- Hits         1379     1378       -1
  Misses        246      246
- Partials       67       68       +1

Impacted Files
Coverage Δ

sanic/router.py
92.23% <0%> (-0.46%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d06ea9b...a20ad99. Read the comment docs.


Feature Request: indent dedent tocken support for any language

I want to be able to use blockman with Lua files, unfortunately, Lua doesn't have clear block tokens (its keywords do double duty). Being able to allow any language to piggyback on the current python support system will expand the feature to many languages at least partially.
Alternatively, proper Lua support would be appreciated, perhaps allowing the user to provide a list of words that start a block and what ends that block. Having these be language-specific like #22 wants would be even better.

I hope I'll try it in the near future.


Fix StringNode location checks on windows

Location checks for StringNodes are broken on windows machines. See this build for more information.
This looks like it has to do with carriage return characters

I believe this problem is reproducible in CI vi #1001

I think this is now fixed.


manul ignores build tags?

This is on mac.
You can repro with this code: https://github.com/kjk/web-blog (git clone --recursive https://github.com/kjk/web-blog)
$ manul -U -r
2016/10/22 14:30:37 updating dependency github.com/garyburd/go-oauth
2016/10/22 14:30:37 updating dependency github.com/go-fsnotify/fsnotify
2016/10/22 14:30:38 updating dependency github.com/gorilla/securecookie
2016/10/22 14:30:38 updating dependency github.com/gorilla/websocket
2016/10/22 14:30:39 updating dependency github.com/kjk/u
2016/10/22 14:30:39 updating dependency github.com/kr/fs
2016/10/22 14:30:40 updating dependency github.com/microcosm-cc/bluemonday
2016/10/22 14:30:40 updating dependency github.com/russross/blackfriday
2016/10/22 14:30:41 updating dependency github.com/shurcooL/sanitized_anchor_name
2016/10/22 14:30:42 updating dependency github.com/thomas11/atomgenerator
2016/10/22 14:30:42 updating dependency golang.org/x/net
updated 11 dependencies
$ go build
vendor/github.com/go-fsnotify/fsnotify/kqueue.go:18:2: cannot find package "golang.org/x/sys/unix" in any of:
	/Users/kjk/src/go/src/github.com/kjk/blog/vendor/golang.org/x/sys/unix (vendor tree)
	/usr/local/Cellar/go/1.7.3/libexec/src/golang.org/x/sys/unix (from $GOROOT)
	/Users/kjk/src/go/src/golang.org/x/sys/unix (from $GOPATH)
kjkmacpro:blog kjk$

The problem seems to be that in kqueue.go we have:
// +build freebsd openbsd netbsd dragonfly darwin

package fsnotify

import (
	"errors"
	"fmt"
	"io/ioutil"
	"os"
	"path/filepath"
	"sync"
	"time"

	"golang.org/x/sys/unix"
)

I assume it's the build tag. Since I'm building on mac and build tag specifies darwin, the file should be parsed and golang.org/x/sys/unix be vendored as well.

Would probably be fixed by using:
build.Default.Import instead of build.Import in https://github.com/kovetskiy/manul/blob/master/imports.go#L24


Straume cleanup

Purpose
The purpose of this refactor is to make some quality of life improvements to the library. In particular, this refactor does not change the underlying functionality of Straume. All the tests still pass as before with no changes in how the functions are called with two notable exceptions: one place where argument order is swapped, and making an argument in Straume.Straume explicit.
Clean up dead code
A few files were empty, Buffer.lean and Uni.lean. Whereas others were un-imported, Prob, Ordering, and Clock. The former were deleted, and the latter were added to a ToMove folder.
Namespace
The majority of files were touched in order to clean up some of the namespaces. The majority, except the typeclasses which were left in the Straume namespace.
For example, Straume.Iterable.Iterable is now known as Straume.Iterable, but everything else in the file still has the same name.
Aka refactor
The main difference in the refactor was in the Aka.lean file. The change can be summarized as follows:

Straume.Aka.Aka is now known as Straume.Aka.
The Aka typeclass instance is now more generic, being derived from

variable {f : Type u → Type u} {α β s : Type u} {m : Type u → Type v} (src : s)
         [Coco α s] [Flood m s] [Terminable f] [Monad m] [Iterable α β]

Merged the Straume.Aka.Aka.take1 definition with the Straume.Aka.take1 class method

Move some common variable declarations in takeN, take1, takeWhileDo, takeWhile to scoped declarations.

The new Straume.Aka instance no longer requires the Bijection α β typeclass.

Immediate TODO before merging

[ ] Delete the TODO : Delete comments
[ ] Delete the ToMove folder

Longterm TODO
Further work that could be helpful to increase usability

Expanded documentation on typeclasses explaining design decisions
Revisit the exported symbols (whether this is preferable over simply opening namespaces)
Revisiting some design decisions with respect to some typeclasses. In particular Bijection.
Maybe renaming Straume.Straume to Straume.Stream?

These changes are more involved, so can be included in part or in whole in this PR or in separate PRs.

I meant to move it into a repo called something like Clock.lean to not
forget about this code.
On Thu, 22 Sept 2022 at 17:28, Ilona Prikule @.***>
wrote:

@.**** approved this pull request.
I see your next to-do point is to delete the ToMove folder. Is it
intended to be, well, moved anywhere first? If yes, where? If not, why the
extra folder? 🤔
—
Reply to this email directly, view it on GitHub
https://github.com/yatima-inc/straume/pull/16#pullrequestreview-1117360210,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APY6WRW3L4G4HA7WE7H64CDV7SCJTANCNFSM6AAAAAAQRJI2IY
.
You are receiving this because your review was requested.Message ID:
@.***>

--
—
Kindest regards,
¬Σ

I'm so confused. Why is this open? Didn't we merge it? Wat.

I don't think we did. This is way out of date though, and probably pointless now with all of the Megaparsec refactors that have happened. I'd be happy to close.


PHP 7 Errors are caught incorrectly

ERROR: Uncaught TypeError: Argument 2 passed to RollbarException::__construct()
must be an instance of Exception, instance of Error given,
called in .../vendor/rollbar/rollbar/src/rollbar.php on line 345
and defined in .../vendor/rollbar/rollbar/src/rollbar.php:91

One type hint was not removed but probably it is better to use class_alias() instead of define, it will also help to restore class hinting removed here https://github.com/rollbar/rollbar-php/commit/7b7cae9777ee794935b5a1b778fab6d128b80629

I will try to make a PR on weekend unless there's someone faster :)

I see this was fixed in 0.18.2. It should probably be closed.

It seems it works


upgrade to latest TSTL

Test Suites: 34 passed, 34 total
Tests:       202 passed, 202 total
Snapshots:   0 total
Time:        29.331 s, estimated 38 s
Ran all test suites matching /./i.

But (not bundled scripts):
ERROR: index.lua:2: attempt to call global '__TS__SourceMapTraceBack' (a nil value)

I suspect this is because all functions in lualib_bundle.lua have become local. I will try to fix this.


Unable to load the service index for source https://api.nuget.org/v3/index.json

Hi! Thanks for reporting this feature/bug/question!
Please keep / fill in the relevant info from this template so that we can help you as best as possible.
Type (choose one):

Bug

NPE version: (e.g. 5.x) (see Help -> about)
5.5.61+325be69768
OS version: (Windows 7, 10 - 1803/17134, etc)
Windows 10 1909 18363.535
Installed from: Microsoft Store / Chocolatey.org / Zip on GitHub / CI channel
Chocolatey.org
In case of a BUG:
Cannot browse or publish to any feed
when trying to browse get the error Unable to load the service index for source
Can browse feeds from visual studio and nuget.exe
I tried to add registry key to disable tls 1.3 but that did nothing.

I have same issue

Same here, installed from Windows Store, auto-updated in the background to 5.5.61+325be69768.
I checked with Fiddler and didn't see any attempts to make network requests to the feeds.

I suspect this is #730. We haven't been able to determine what's causing it. The workaround for that is to uninstall and reinstall the app.

Indeed, reinstall helped.

I started getting this issue and now reinstalling doesn't fix it.

I experience the same problem. Tried to add http_proxy (none was previously set) and no_proxy, but none of these had any effect. NuGet Package Explorer has been an excellent tool up to a day or two ago, but now it does not work, even for my colleague who downloaded and installed today.
NuGet cli lists the available packages without problem.


Make lwaftr run --reconfigurable uniprocess

Snabb lwaftr run is currently broken with multiprocess leader/follower setups, for durations over 0.1 second. This patch makes it run in one process until that can be fixed.

Tested with:
SNABB_PCI0=82:00.1 ./program/lwaftr/selftest.sh
./snabb lwaftr run -D 2 --conf ~/snabb-lwaftr-v3.1.0/src/program/lwaftr/test/data/icmp_on_fail.conf --reconfigurable --on-a-stick 82:00.1
(Both pass).

SGTM.


error while loading shared libraries: libcurl-gnutls.so.4 on Centos 7

Trying out microk8s on CentOS and I can't get past the first line - microk8s.enable istio.
[snapcraft@centos7-snapcraft ~]$ microk8s.enable istio
Enabling Istio
Fetching istioctl version v1.2.2.
/snap/microk8s/743/usr/bin/curl: error while loading shared libraries: libcurl-gnutls.so.4: cannot open shared object file: No such file or directory
Failed to enable istio

inspection-report-20190905_092756.tar.gz

Hi @popey
This looks similar to https://github.com/ubuntu/microk8s/issues/612
Could you try out the snap from --edge?
sudo snap install microk8s --classic --edge

Kinda. New error.
curl: (77) Problem with the SSL CA cert (path? access rights?)
Failed to enable istio

Kinda. New error.
curl: (77) Problem with the SSL CA cert (path? access rights?)
Failed to enable istio

Doing this on my CentOS7 box seems to resolve the same issue :
cp /var/lib/snapd/snap/core/current/etc/ssl/certs/ca-certificates.crt /etc/ssl/certs
looks like the embedded curl binary has the wrong path for ca-certificates hardcoded.

@popey @bsyd, there should be a fix on the edge channel within the day.
sudo snap install microk8s --classic --edge.
Thank you @DomFleischmann for the work on this fix!

My tests show this fixed. The snap will be available on stable along with v1.16.1. Feel free to reopen the issue if the fix does not work for you.
Thank you for reporting this.


Run WPTs against browserslist

Description
Use browserslist queries to get the latest version numbers for each browser. Removes the need to manually update the test file on every browser release (which happens every few weeks). The only exception is Safari, which has a much slower velocity and each version if tied to the underlying iOS/macOS version.
Steps to test/reproduce
The WPT report generated by this PR includes the most recent browser versions. In contrast, the main report is using some old, hard-coded versions.

 Tests (including WPT)

WPT report for this branch: https://wpt-browserslist-wpt-results--anchor-position-wpt.netlify.app/


Fix some markdown formatting in docs

I discovered this when building with --enable-commonmark (rust-lang/rust#44229) but it's actually an issue with the current default renderer (hoedown) that is fixed by the new one (pulldown-cmark).

Thanks!
bors r+


Assist with Language/Technology for RACI Infographics (AWS SEA)

Describe the Issue
An infographic for the Technology RACI for AWS SEA needs to be created. The infographic should contain generic terms that are easily understood by non-technical teams.
Additional Context
Infographic will elaborate on the existing 'Technology Stack' section of the public cloud accelerator service shared responsibility model, and will be posted on the new public cloud website.
Acceptance Criteria

Gary to connect with Gautam to discuss the 'MOH Technology RACI AWS' spreadsheet;
Gary & Gautam to collaborate to:

Simplify/generalize language wherever appropriate;
Check different visualizations/themes for the infographic;
Connect with the CPF Team (Jon & Warren) for internal review/recommendations.

.
.
.
.
.
.
.
.
.
.
.
Extra Template Info
Definition of Ready
These set of conditions will need to be met in order to bring a ticket into the sprint and start work. Protects the team from unclear requirements.
Issues (Task/Story/Spike) aligned to an EPIC and linked appropriately.
Assigned to the appropriate CPF MEMBER (and is not left blank in ZenHub) at the start of sprint (1st day of the sprint)
Acceptance has been defined for the issue and has been reviewed with CPF team and approved by the necessary approver.
Has been sized and estimated by the delivery team.
Detailed breakdown of the steps required to complete the story in the additional context
Any additional specifications have been documented, reviewed with CPF and approved by the necessary approver.
Acceptance Criteria
A set of pre-defined requirement that need to be met in order to mark the user story as “done”.
It should be testable with no room for interpretation
It should be either “pass” or “fail”
It should be clear enough for business stake holders to understand
As part of the user story, it should be written from the user perspective
A well written acceptance criteria is great for

managing expectations
defining scope
reducing ambiguity
establishing testing criteria for QA
Given (Pre-condition)
When (Action)
Then (Outcome)

Definition of Done
These set of conditions are met for work to be considered as complete on an issue.
All acceptance criteria(s) have been validated.
All the necessary documentation for the issue has been uploaded to Teams.
Functionality has been tested when applicable.
Functionality has been demonstrated to the relevant stakeholders (where applicable).
Story has been scheduled for a Sprint Demo/community update and impacted teams invited to the Demo.
Stories accepted by PO and documented for potential sharing with impacted users.

Documented = Captured in Community Update (CU) deck
Release notes = aspirational goal of providing a bulleted list of features and changes that our users can touch. Was going to store them in our Cloud Pathfinder repo. Can also display to users in the CU

Gary/Jon/Warren/Gautam continue to collaborate to finalize the CPF RACI.


Adding email subscription status to Northstar

What's this PR do?
🐻 Bear with me!

Updates it_should_backfill_users() test to expect 10 calls to Blink's userCreate

Previously this was only called 5 times because the model event did not trigger because $this->app->runningInConsole() was true
Now that we have removed that conditional, each user gets sent TWICE, once when we manually make the call to send it in the job and once when we save the user and it gets triggered in the model event. This doesn't seem ideal, but still preserves the functionality of the backfill command.

Removes some code in /Jobs/SendUserToCustomerIo.php that was outdated
Removes the original toCustomerIoPayload() and renames toBlinkPayload() as the new toCustomerIoPayload()
Adds email_status as a fillable field on users
Includes email_status and unsubscribed (true if status is stop, false if status is anything else) in payload to Customer.io
Removes some old conditionals from the model events

How should this be reviewed?

Is the logic for when to return unsubscribed as true or false correct?
Is there anywhere else that we should return email subscription status?

Relevant Tickets
Card
Checklist

[ ] Documentation added for changed endpoints.
[ ] Tests added for new features/bug fixes.
[ ] Post a message in #api if this includes something that causes a rebuild!

Is the logic for when to return unsubscribed as true or false correct?

This seems good to me!

Is there anywhere else that we should return email subscription status?

We should start returning it from our v2 user routes, but it might make sense to hold off until we've run our backfill and actually have real data to return.

Let's also remove the CustomerIo service class.


Portfolio sync is missing asset positions that are locked in open orders

Dear Catalyst Maintainers,
Description of Issue

What did you expect to happen?
While doing the portfolio synchronisation the positions sync should take into consideration the available total amount of the currency (available amount + in-order amount).
Example:
Amount available: 0
Amount in orders: 0.4
Portfolio position: 0.4

What happened instead?
The check low balance method (_check_low_balance) is using the the free amount and not the total amount.
Example:
Amount available: 0
Amount in orders: 0.4
Portfolio position: 0

Here is how you can reproduce this issue on your machine:
You need to have open orders to sell your asset. When the portfolio is synched you will not have the correct value on your positions.
Reproduction Steps

Buy some asset
Place a limit order to sell that asset (with a limit price that is not going to be matched)
Wait for the next time frame (e.g. 1 minute)
Check that your portfolio positions are missing the asset being sold (but the order is not matched yet)

What steps have you taken to resolve this already?
The method Exchange::sync_positions should the total amount to the _check_low_balance.
I've temporarily created a _check_low_total_balance to use here:
    def _check_low_total_balance(self, currency, balances, amount):
        total = balances[currency]['total'] if currency in balances else None
        if total is None:
            return None, False
        if total < amount:
            return total, True
        else:
            return total, False

Cheers,
Red Eagle

Hi, pushed fix into the develop branch (although I think Catalyst avoids checking the currency balance when orders are open) will be released towards the end of the week. Thanks!

added to release 0.5.14

Seems great. Thank you!


farasapy take a long time

hello,
first, thank you so much for this great job
I need to use Farasa segmented and pos tagger in my process, however, it takes about 4 to 5 min to give me the results applied on 20 sentences for example.
how can I optimize this time ?
my process was very quick before I use farasa segmenter and postagger.
do you think using jar can optimize the time?
thank you so much

Hey @AsmaZbt
Thanks for reaching out. By the way, farasa operates in two modes, the first mode is the interactive mode where sentences are evaluated individually. The second mode is the standalone mode where all sentences are written to a file then got passed to farasa to evaluate.
Both of these modes are already supported by farasa jar files, I am just wrapping it around. I am, under the hood, passing these to the jar files communicating through a command-line process. I am expecting a similar experience if you used the jar files as well.
For your issue, maybe you tried the standalone mode where the interactive mode is the best for you. Interactive mode is the best for short text where speed is preferred over input length while standalone is the best used for long text input.
You may check that also in the colab notebook where both modes are illustrated and compare the time taken for both modes, [https://colab.research.google.com/drive/1xjzYwmfAszNzfR6Z2lSQi3nKYcjarXAW]
Try it and let me know if this did not solve your issue.

hello @MagedSaeed ,
Thank you so much for replying and for the explanation. I understand better now. it works much faster thank you so much.
I have another question please:
I'm trying to deploy my NLP application using heroka  but i can't because of the intialization I think :
segmenter = FarasaSegmenter(interactive= True) and pos_tagger = FarasaPOSTagger(interactive=True)
It takes some time ( i read in the doc of farasapy that it should take some time when used for the 1st time) and upload 100%|██████████| 241M/241M [00:21<00:00, 11.1MiB/s].
the error message is: request time is out.
Do you have an idea of how I can process these two initializations separately that I can deploy my app?
Thank you so much

You are most welcome @AsmaZbt
Really grad that things work for you.
Regarding your concern about Heroku host, make sure, first of all, your application is not commercial, otherwise, take farasa authors' approval to avoid any legal escalations. Now, are you sure the timeout is from farasapy? Does it work with you fine on your local machine? If you used a debugger on your local machine, can you trace how things are going and which process takes time?
Just for sake of curiosity, in the server, where did you install the package? on a virtual environment or globally? If globally, make sure to install it with Python3 environment as Linux systems usually, redirect to Python2 instead of Python3.

Thank you very much, that's very kind of you @MagedSaeed .
I'm trying to publish a paper of research and I cited farasa and your work in my paper, the application give only solution for my problematic, It's not for a commercial use. Do you think I need also an authors' approval in this case?
-The application work fine in my local machine and does not take time,  I just must wait for the initialization of farasa segmenter and postagger .

I'm using python 3 in a virtual environment.
I think that  downloading of farasa toolkit binaries  who cause the error message of time is out. hureko don't wait this time.

I made a screenshot so that you can see

best regards, Asma

Hey @AsmaZbt
Sorry for the late reply, got busy last couple of days,,
Since your application is not commercial, I do not think you need to contact farasa authors as per their liscence.
Regarding the issue you are facing in your flask app, let me ask you this. Do you have a terminal access to your host (Heroku)? I think you should have.  If so, maybe this workaround will be useful. Try to execute this line on your terminal after activating your app virtual environment:
python -c "from farasa.segmenter import FarasaSegmenter;segmenter = FarasaSegmenter()"

This line will initialize the segmenter object downloading the jar files for the first time, if they are not there. After that, all subsequent calls will reuse the same jar files.
Hope this will help,,

hello @MagedSaeed ,
I would like the thank you for your great work, effort, and help.
I tried your solution , but it didn't solve the problem.  its give me 'resources limited'. it's a problem of memory now, I used their free plan.
thank you much.
best regards Asma.

Thanks, @AsmaZbt  for your kind writings. Really appreciate,
The size of the binaries is below 250MB I guess. How much storage the free plan is offering?

Yes, the binaries size is 241MB,
the free plan offer : RAM 512Mb, storage 500Mb.
I using also sentence-BERT-transformer.
I'll give an idea of what I'm doing:
I have a  dictionary  of words : one definition may have 100 sentences.
i have query sentence
and a verb in this sentence that I would like to disambiguate .
I apply farasa.segmenter on the query sentence.
then I compute the embedding vectors of the query sentences and the 100 sentences of definition of that verb in the  dictionary.
then I compute similarities between them to retrieve the nearest sentences.
Then I apply farasa.POStagger on the 10 nearest sentences.
the I need the get the list of the most frequent verbs.
this is the BIG lines of my process ,
I just want to do an online demon for my approach like in this work: http://ltdemos.informatik.uni-hamburg.de/uwsd158/
Thank you really for you.

That looks interesting! I wish you the best in your research work!


Prevent graders from grading if submission is not submitted

Right now, graders can actually grade students' submissions even though the students have not submitted. This additional clause should return error to frontend if graders are attempting to grade a non-submitted answer.

Pull Request Test Coverage Report for Build 2651

2 of 3 (66.67%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.007%) to 91.953%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/cadet/assessments/assessments.ex
2
3
66.67%

Totals

Change from base Build 2647:
0.007%

Covered Lines:
1017

Relevant Lines:
1106

💛  - Coveralls


IE11 error adding class to SVG

<svg> elements give this error when using addClass.
"Assignment to read-only properties is not allowed in strict mode"

Seems to be related to using className, though I'm seeing more results for IE11 failing on classList:
https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/1173756/

This is no longer a problem in 10+, it probably got fixed when I switched to the classList API instead of mutating className directly.
$('<svg></svg>').addClass ( 'foo' ).hasClass ( 'foo' ); // => true


prisma2 lift up runs into "Error in lift engine for rpc calculateDatabaseSteps"

Steps to reproduce (hopefully):

Start the development mode prisma2 dev
Modify the schema.prisma file. (For me it was adding the Post model and a relationship between User and Post; following the Tutorial)
Exit the development mode by hitting CTRL+C twice.
Run prisma2 lift save --name 'add-post' to create new migration files.
Run prisma2 lift up which throws the error mentioned below.

May be a duplicate of the other lift up errors. Not sure.

Running with Prisma version: 2.0.0-preview-3.2
Failed calculateDatabaseSteps at 2019-08-01T15:57:05.193Z
RPC Input One Line
{"id":1,"jsonrpc":"2.0","method":"calculateDatabaseSteps","params":{"projectInfo":"","assumeToBeApplied":[{"stepType":"CreateModel","name":"User","embedded":false},{"stepType":"CreateField","model":"User","name":"id","type":{"Base":"String"},"arity":"required","isUnique":false,"id":{"strategy":"Auto","sequence":null},"default":{"Expression":["cuid","String",[]]}},{"stepType":"CreateField","model":"User","name":"name","type":{"Base":"String"},"arity":"optional","isUnique":false},{"stepType":"CreateField","model":"User","name":"email","type":{"Base":"String"},"arity":"required","isUnique":true}],"stepsToApply":[{"stepType":"CreateField","model":"User","name":"posts","type":{"Relation":{"to":"Post","to_fields":[],"name":"PostToUser","on_delete":"None"}},"arity":"list","isUnique":false},{"stepType":"CreateField","model":"Post","name":"author","type":{"Relation":{"to":"User","to_fields":["id"],"name":"PostToUser","on_delete":"None"}},"arity":"optional","isUnique":false}],"sourceConfig":"datasource db {\n  provider = \"postgresql\"\n  url      = env(\"POSTGRES_URL\")\n}\n\ngenerator photonjs {\n  provider = \"photonjs\"\n}\n\nmodel User {\n  id    String  @id @default(cuid())\n  name  String?\n  email String  @unique\n  posts Post[]\n}\n\nmodel Post {\n  id        String  @id @default(cuid())\n  title     String\n  published Boolean @default(false)\n  author    User?\n}"}}

RPC Input Readable
{
  "id": 1,
  "jsonrpc": "2.0",
  "method": "calculateDatabaseSteps",
  "params": {
    "projectInfo": "",
    "assumeToBeApplied": [
      {
        "stepType": "CreateModel",
        "name": "User",
        "embedded": false
      },
      {
        "stepType": "CreateField",
        "model": "User",
        "name": "id",
        "type": {
          "Base": "String"
        },
        "arity": "required",
        "isUnique": false,
        "id": {
          "strategy": "Auto",
          "sequence": null
        },
        "default": {
          "Expression": [
            "cuid",
            "String",
            []
          ]
        }
      },
      {
        "stepType": "CreateField",
        "model": "User",
        "name": "name",
        "type": {
          "Base": "String"
        },
        "arity": "optional",
        "isUnique": false
      },
      {
        "stepType": "CreateField",
        "model": "User",
        "name": "email",
        "type": {
          "Base": "String"
        },
        "arity": "required",
        "isUnique": true
      }
    ],
    "stepsToApply": [
      {
        "stepType": "CreateField",
        "model": "User",
        "name": "posts",
        "type": {
          "Relation": {
            "to": "Post",
            "to_fields": [],
            "name": "PostToUser",
            "on_delete": "None"
          }
        },
        "arity": "list",
        "isUnique": false
      },
      {
        "stepType": "CreateField",
        "model": "Post",
        "name": "author",
        "type": {
          "Relation": {
            "to": "User",
            "to_fields": [
              "id"
            ],
            "name": "PostToUser",
            "on_delete": "None"
          }
        },
        "arity": "optional",
        "isUnique": false
      }
    ],
    "sourceConfig": "datasource db {\n  provider = \"postgresql\"\n  url      = env(\"POSTGRES_URL\")\n}\n\ngenerator photonjs {\n  provider = \"photonjs\"\n}\n\nmodel User {\n  id    String  @id @default(cuid())\n  name  String?\n  email String  @unique\n  posts Post[]\n}\n\nmodel Post {\n  id        String  @id @default(cuid())\n  title     String\n  published Boolean @default(false)\n  author    User?\n}"
  }
}

RPC Response
null

Stack Trace
[migration-engine/connectors/sql-migration-connector/src/lib.rs:391] format!("CREATE SCHEMA IF NOT EXISTS \"{}\";" , & self . schema_name) = "CREATE SCHEMA IF NOT EXISTS \"public\";"
[migration-engine/connectors/sql-migration-connector/src/sql_migration_persistence.rs:39] m.make_from(barrel_variant) = "CREATE TABLE \"public\".\"_Migration\" (\"revision\" SERIAL PRIMARY KEY NOT NULL, \"name\" TEXT NOT NULL, \"datamodel\" TEXT NOT NULL, \"status\" TEXT NOT NULL, \"applied\" INTEGER NOT NULL, \"rolled_back\" INTEGER NOT NULL, \"datamodel_steps\" TEXT NOT NULL, \"database_migration\" TEXT NOT NULL, \"errors\" TEXT NOT NULL, \"started_at\" timestamp(3) NOT NULL, \"finished_at\" timestamp(3));"
thread 'main' panicked at 'The model Post does not exist in this Datamodel. It is not possible to create a field in it.', src/libcore/option.rs:1034:5
stack backtrace:
   0: std::sys::unix::backtrace::tracing::imp::unwind_backtrace
   1: std::sys_common::backtrace::_print
   2: std::panicking::default_hook::{{closure}}
   3: std::panicking::default_hook
   4: std::panicking::rust_panic_with_hook
   5: std::panicking::continue_panic_fmt
   6: rust_begin_unwind
   7: core::panicking::panic_fmt
   8: core::option::expect_failed
   9: <migration_core::migration::datamodel_calculator::DataModelCalculatorImpl as migration_core::migration::datamodel_calculator::DataModelCalculator>::infer
  10: <migration_core::commands::calculate_database_steps::CalculateDatabaseStepsCommand as migration_core::commands::command::MigrationCommand>::execute
  11: <F as jsonrpc_core::calls::RpcMethodSimple>::call
  12: <F as jsonrpc_core::calls::RpcMethod<T>>::call
  13: <futures::future::lazy::Lazy<F,R> as futures::future::Future>::poll
  14: <futures::future::then::Then<A,B,F> as futures::future::Future>::poll
  15: <futures::future::map::Map<A,F> as futures::future::Future>::poll
  16: <futures::future::either::Either<A,B> as futures::future::Future>::poll
  17: futures::task_impl::std::set
  18: std::thread::local::LocalKey<T>::with
  19: futures::future::Future::wait
  20: jsonrpc_core::io::IoHandler<M>::handle_request_sync
  21: migration_core::rpc_api::RpcApi::handle
  22: migration_engine::main
  23: std::rt::lang_start::{{closure}}
  24: std::panicking::try::do_call
  25: __rust_maybe_catch_panic
  26: std::rt::lang_start_internal
  27: main

After completely re-setting up my Postgres, removing the migration within the migrations directory (and from within the lift.lock file) and then running prisma2 lift save --name 'add-post' and then prisma2 lift up it worked.
Database Changes:

Migration                Database actions           Status

20190801153006-init      1 CreateTable statements.  Done 🚀
20190802211859-add-post  1 CreateTable statements.  Done 🚀

You can get the detailed db changes with prisma2 lift up --verbose
Or read about them in the ./migrations/MIGRATION_ID/README.md

🚀  Done with 2 migrations in 759ms.

rm -rf node_modules
yarn install
this was my solution with an sqlite database

With exactly these steps

Start the development mode prisma2 dev
Modify the schema.prisma file. (For me it was adding the Post model and a relationship between User and Post; following the Tutorial)
Exit the development mode by hitting CTRL+C twice.
Run prisma2 lift save --name 'add-post' to create new migration files.
Run prisma2 lift up which throws the error mentioned below.

I was unable to reproduce this. Did models other that the post connection exist then in the DB already? That is what I tried.
However, trying a prisma2 dev without anything in the DB yielded the following error for me
Error: Error: Error in lift engine for rpc inferMigrationSteps:
  thread 'main' panicked at 'The field posts on model User already exists in this Datamodel. It is not possible to create it once more.', migration-engine/core/src/migration/datamodel_calculator.rs:143:9

Which is similar but not the same, so not marking this as a repro yet. We need to spend more time on this.

I can reproduce this and I think this is a duplicate of https://github.com/prisma/prisma2/issues/37
That issue was lacking a concrete reproduction but I guess we got a reproduction now. So I think what is happening here is lift is unable to determine the state of the migration whether they are applied or not and trying to apply the whole set even though they are in the database. I think lift flow and dev flow are not behaving separately here and it is the same issue.
@divyenduz should we close this issue as a duplicate?

@pantharshit00 if you strongly believe that this is a duplicate, please feel free to close it and post the reproduction on the open issue.

@pantharshit00 Now both this issue and https://github.com/prisma/prisma2/issues/37 are 0-needs-info and are still open. Please consolidate and/or retest this to make sure there is actually one actionable issue. Thanks.

I no longer can reproduce these issues, closing!


perf(body): have to_bytes collect with a BytesMut

By collecting into a BytesMut instead of a Vec<u8>, cloning the resulting bytes can be made O(1). The only disadvantage is it's a couple more bytes to store, but that's fine.

Thanks for the PR! Have you checked the benches/body.rs if this has a difference? Looking at BytesMut::freeze, if it hasn't had any slices made, then it is equivalent to what a Vec does. So my gut is that this will be slightly slower...

Oh dear, looks like I misread shallow_clone_vec from bytes when I first read it - I had concluded that it copied over the bytes, when that wasn't the case at all. So actually cloning a bytes-Vec is O(1) and this change isn't needed. I'm going to blame bytes for this though because if it wasn't unsound I wouldn't've assumed that :P


out of scope let-variable can appear in fun binder type of metavariable assignment

Prerequisites
Please put an X between the brackets as you perform the following steps:

[ ] Check that your issue is not already filed:
https://github.com/leanprover/lean4/issues
[x] Reduce the issue to a minimal, self-contained, reproducible test case.
Avoid dependencies to Mathlib or Batteries.
[x] Test your test case against the latest nightly release, for example on
https://live.lean-lang.org/#project=lean-nightly
(You can also use the settings there to switch to “Lean nightly”)

Description
The following declaration raises an error.
-- (kernel) declaration has free variables '_example'
example : Unit :=
  let x : Nat → Unit := _
  let N := Nat;
  (fun a : N =>
    have : x a = () := rfl
    ()) Nat.zero

The unification that results from have : x a = () := rfl asigns the metavariable in x to fun (a : N) => (). However, N is not in the context of x, so the free variable remains in the definition of x.
Context
I ran into an error caused by this isDefEq bug while programming. I reported the problem on Zulip.
Steps to Reproduce
Use the above problematic declaration.
Expected behavior: [Clear and concise description of what you expect to happen]
The elaboration succeeds, and results in either
let x : Nat → Unit := let N := Nat; fun (a : N) => ()

or the reduced form
let x : Nat → Unit := fun (a : Nat) => ()

Actual behavior: [Clear and concise description of what actually happens]
We get the error (kernel) declaration has free variables '_example'
Versions
4.13.0
Additional Information
The minimized original example that I ran into is this:
-- (kernel) declaration has free variables 'oops'
def oops : IO Unit := do
 pure ()
 match some () with
 | some u => do
  let pair := match () with | _ => ((),())
  let i := ()
  if h : i = pair.1 then
   let k := 0
 | _ => return

The same underlying problem is responsible for #4375 and #5387. One problematic case was fixed by #4410.
Impact
Add :+1: to issues you consider important. If others are impacted by this issue, please ask them to add :+1: to it.

I tried to fix the bug, and came to the conclusion that I could fix it by modifying the function mkLambdaFVarsWithLetDeps. However, I have now found out that this function is already buggy. In its implementation it assumes that the free variables xs appear in the order in which they appear in the local context. So out of these two examples: the first succeeds, and the second fails with a unification error:
example : Unit :=
  let x : Nat → Nat → Nat → Unit := _
  (fun a : Nat =>
  let F := Nat
  (fun b c : F =>
  have : x a b c = () := rfl
  ())) 0 0 0

example : Unit :=
  let x : Nat → Nat → Nat → Unit := _
  (fun a : Nat =>
  let F := Nat
  (fun b c : F =>
  have : x a c b = () := rfl
  ())) 0 0 0

The reason is that in the assignmen of x a c b := (), it considers the variables between a and b, but c isn't there, so the resulting assignment is a function with 2 arguments.

Here is another bug that comes from a bad variable management when assigning during unification:
-- (kernel) declaration has free variables '_example'
example : Unit :=
  let x : Nat → Nat → Nat := _
  (fun (a : Nat) (b : let _ := a; Nat) =>
    have : x b a = Nat.zero := rfl
    ()
    ) Nat.zero Nat.zero

I have a fix for all of the above bugs at #5948.


"Ignoramus" and other Latin plays not being returned by filtering correctly

DEEP 1195, 1196, and 1197 are in the database and they do appear if you search by DEEP # -- but they do not appear when hit by other searches. Try searching for Title = Ignoramus or for Greg # = L8, both of which should return 4 results, but only return 1 result (plus 1 variant correctly linked by the Variants field)
The same is true for Greg # = L5, Nero. DEEP only returns 1 result, the first item, when it should return 2 (plus two variants correctly linked by the Variants field)
The same is true for Greg # = L11, Roxana. Again, 1 result instead of 2.
In each case, the record is actually in the database, and will be hit by searches by DEEP #, so the problem is in the filtering. It seems like with Latin plays (Greg # = L), only the item with the lowest DEEP # is being returned for some reason.
This is very similar to the problem with Collections, where only the collection with the lowest DEEP # is returned in filtering, so I suspect there is a connection and the same solution will fix both.

FYI this is not working on my end -- you may have fixed it in a way that I can't see yet, but just alerting you that I'm still seeing only the first edition for each Latin play (and each Collection)

This was fixed yesterday but now is broken again. As with Collections, switching to Record View reveals the missing items, which do not appear in Edition View.


WMS ID: 5601 - Updated with Auto Insights and Notes

Add here your WMS ID
General requirements

Information in the workshop is adequate and updated
Code is correct and working
Links are correct
Make sure you enter the help email link in your manifest.json
Please make sure WMS URLs are updated as needed after your PR is approved

Checklist - Refer to the QA document for the complete list
Please confirm that the following is completed before submitting your PR

[x] All filenames are lower case (including folders, images, files, etc.)
[x] Filenames are descriptive
[x] Your workshop folder structure should be similar to the one used in the sample workshop (https://github.com/oracle-livelabs/common/tree/main/sample-livelabs-templates/sample-workshop)
[x] Are you using multiple versions (desktop/, sandbox/, tenancy/)? Make sure that each of them contains a manifest.json and an index.html
[x] Image references in markdown contain an alternate text

@ionut-forlafu Can you please check the conflicts?


Update record

Created an interface to update record in DB.
Usage:
api/update_record?db=NUMBER&record=NUMBER - endpoint allows front-end app to update a record with given id of db and id of record.


feat: allow user to configure node interpreter

This adds configuration for the <node-interpreter value="project" />
workspace element
fixes #241

The new element syntax is the same as any npm run configuration uses for its node interpreter configuration.
This also refactors the element util slightly as not all elements need a name (at least this one and #253).

thanks 👏


Module version not playing nicely with #Requires statement

For some reason, most likely a bug in Powershell, if you add this Requires statement to your code:
#Requires -Modules @{ ModuleName='Nevergreen'; ModuleVersion='2105.2' }

It fails with:
ResourceUnavailable: The script 'AutoPackager.ps1' cannot be run because the following modules that are specified by the "#requires" statements of the script are missing: Nevergreen.
Yet it works if you retry!
I suspect this might be down to the version format used. I have copied the version format used by Evergreen, i.e. YYMM.Build, except my first release was 2105.001. However when I published the module it was coming up as 2105.1. Seeing that it stripped the preceeding zeroes, I just called the next release 2105.2 in the module manifest.
Visiting the Powershell Gallery at https://www.powershellgallery.com/packages/Nevergreen though redirects to 2105.1 instead of the latest version, which is odd, and the reason why I suspect the version being a cause.

Next release will be 2105.100 to see if it alleviates this.

I think this is resolved now.
When publishing the module, empty folders are removed. The Private folder was empty, and a non-existent Private folder was throwing an error during the init of import-module. Adding -ErrorAction Ignore to the line that scans for functions there seems to have sorted it!


New Rule: validateFunctionArgumentIndentation

I believe that JSCS doesn't properly validate the indentation of function arguments. For example with validateIndentation: 2 :
myFoo(
  2,
  4
)

Is and and should be valid, but
myFoo(
  2,
4
)

Is but should not be valid.
I'm using version 1.7.3

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/6499192-new-rule-validatefunctionargumentindentation?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github).

Moving to https://github.com/jscs-dev/node-jscs/issues/1866


Chore: Artifact collections

This PR adds more explicit support for artifact collections (containing objects for the latest artifact of a given key) and drops support for is_latest in the artifacts filter route. Updates all relevant components to use the new route

Ah I just realized this'll break the mock api - let me update that quick


How can I retrive the value of material:binding in the UsdGeomSubset?

Hi,
USD material bindings relationships should be resolved using the MaterialBindingAPI which will take into account all the active composition arcs. You can read more on the subject here.
In Unity you could do:
var prim = scene.GetPrimAtPath("/myPrim");
var bindings = new pxr.UsdShadeMaterialBindingAPI(prim);
var bindingTargets = bindings.GetDirectBindingRel().GetTargets();
foreach (var target in bindingTargets ) {
    Debug.Log(prim.GetName().ToString() + " >>> " + target.GetPrimPath());
}

If you have multiple prims you want to retrieve the bindings for, you can even put them all in a vector and directly do:
pxr.UsdShadeMaterialVector matVector = pxr.UsdShadeMaterialBindingAPI.ComputeBoundMaterials(prims)

Does that answer your question?

Hi,
USD material bindings relationships should be resolved using the MaterialBindingAPI which will take into account all the active composition arcs. You can read more on the subject here.
In Unity you could do:
var prim = scene.GetPrimAtPath("/myPrim");
var bindings = new pxr.UsdShadeMaterialBindingAPI(prim);
var bindingTargets = bindings.GetDirectBindingRel().GetTargets();
foreach (var target in bindingTargets ) {
    Debug.Log(prim.GetName().ToString() + " >>> " + target.GetPrimPath());
}

If you have multiple prims you want to retrieve the bindings for, you can even put them all in a vector and directly do:
pxr.UsdShadeMaterialVector matVector = pxr.UsdShadeMaterialBindingAPI.ComputeBoundMaterials(prims)

Does that answer your question?

Thanks, I test the code is right for me.

Great, closing the issue.


Gaps in LineStrings

Using the following parameters
tippecanoe --minimum-zoom=3 --maximum-zoom=22 -l "file" -r1 -P -pf -pk -f --extend-zooms-if-still-dropping -o "out.mbtiles" "in.geojson"
it generates a lot of weird gaps in the actual LineStrings depending on the actual zoom level. See green styled lines in this two examples to mark the most obvious ones:

I tried playing around with various parameters, but there was no actual change in the output/display.
Any suggestions on how to debug this?

Quick note: adding --no-simplification-of-shared-nodes at least keeps the same display at various zoom levels, but still with gaps in lines.

Closing this issue myself. Running this with no additional parameters generates the expected result.

Glad you figured it out!


Calling function from one VM whilst inside another

I am wanting to run multiple wren VM's at the same time as they will each be a component in an ECS (Entity Component System). I need the ability to send and receive messages between the Wren modules either by calling the VM function endpoints directly or going through c++ to broadcast a message to all VM's. I am aware that I can do the latter but calling function endpoints directly seem's to be a mystery.
I have looked into using Modules but this would require a central Wren-based file to call each other Wren script files whereas I am wanting to have multiple files that can be loaded in and out dynamically whilst having the ability to call one and another.
Is this possible with the current library or would I need to do some wired Wren -> C++ - > Wren communication between components?

In it's current form, I would not suggest to run multiple VM. It is know to
work to some degree of confidence. Some modules might be not well isolated.
In particular, with the io modules.
If you don't use the modules from src/modules you should be safe though.
That said, there is no such facility (yet). And the solution also differs
depending on how you run the VM hive, and the type of message you want to
send. and you have to serialize somehow the data, to avoid passing data
across VMs.
Basically, you need to write your communication bus as a module if you need
wren to send/receive messages. You might need that for complex
interactions, with threaded VM hive. But you have to be careful on what you
allow to be shared.
Differently, you only need to make dumb call to wren all iterating all the
VMs if you simply need them to react on interrupt. This is basically what
you want when you simulate multiple agent, and wake them up on each frame
of the simulation. And calling native modules might represent some sort of
communication, by replicating external data across the hive.
There is one extra possibility that needs a little of hacking, instead of
having multiple VM, is to have multiple anonymous modules. This is a
different approach, but since modules are isolated, you create
communication via libraries since there is no real way (for now) to
reference an anonymous modules.
I would not suggest you to do wren -> C -> wren calls as this, unless the
first wren is the coordinator and the last one can't communicate back.
While possible the message/event system solutions seems more reliable.

with the io modules.

io is from the CLI and not the VM, right? The VM itself however is all self contained state and therefore multiple VMs would work just fine (minus automatic communication between them.)

Yes, the VM in itself is self contained. There is no global variable I can
think of.
The IO cli module contains a bunch of them.

Closing this out as the answer to the original question is: there is no automatic communication of any kind, you need to do it manually.


docs(website): Update prover-market-page.mdx

docs(website): Update prover-market-page.mdx

Looks like its offline?


Update the gemspec's homepage to the current repo URL

This reduces unnecessary redirection for users who visit here from https://rubygems.org/gems/rack-timeout.

Thanks!


py-cpuinfo currently only works on X86 and some ARM/PPC/S390X CPUs

There is an error for if you run
make test

One of the packages does not work with M1 Macs, currently. Just wanted to note that.

how can we fix this? I am using this project for my learning. Got stuck with this error. Appreciate for any help!

I'm no longer maintaining this code, feel free to make a fork and find your own fix


Authorize sdk causing error when uploading to the App Store

Hi,
As I was trying to upload my application in which I have been using accept-ios SDK for payment, I came across many problems. Below mentioned is the error description.
**ERROR ITMS-90171: "Invalid Bundle Structure - The binary file '.app/Frameworks/AcceptSDK.framework/libswiftRemoteMirror.dylib' is not permitted. Your app can’t contain standalone executables or libraries, other than the CFBundleExecutable of supported bundles. Refer to the Bundle Programming Guide at https://developer.apple.com/go/?id=bundle-structure for information on the iOS app bundle structure."
ERROR ITMS-90206: "Invalid Bundle. The bundle at '.app/Frameworks/AcceptSDK.framework' contains disallowed file 'Frameworks'."**
When I searched for solutions, I couldn't find anything regarding Authorize.net, but there were similar cases for other 3rd parties and that is the reason for posting this issue.
I have done a workaround for the issue and also tested in both the development and production scenario in which it seemed to be working fine. But not sure whether it is the right way or may come across any hurdle in the future.
**Action points: -
After achieving the build. I checked the path , '.app/Frameworks/AcceptSDK.framework/ ' in which I found the files (libswiftRemoteMirror.dylib and folder 'Frameworks' )which is causing the issue.
I deleted the 2 files and done the further proceeding for the App Store submission.**
Is it the right way to solve this problem?

Appears to be fixed now. Can you check again?

The application has been approved in the App Store. It is working fine.
@adavidw Did you come across any similar issue?

That error occurs because in the AcceptSDK project settings "Always Embed Swift Standard Libraries" value set to "YES". When that value set to "NO", swift libraries do not includes into AcceptSDK framework and there will not be "Framework" folder inside AcceptSDK.Framework. After such changes build uploaded into itunesconnect successfully without additional changes

I am also facing multiple issue when uploading my application on app store. I have my project in objective c and i have integrated accept-ios SDK manually, I mean i haven't used pod. Because when i have tried to used accept-ios SDK with pod it was unable to compile. any solution for uploading app to appstore !
@RakeshVisa

@ketan-parmar any luck? @adavidw any thoughts?

@DrishyaOB we are also facing same issue, can you tell us how you solved it?

@Mindbowser I had encountered with 2 issues as mentioned below:
**ERROR ITMS-90171: "Invalid Bundle Structure - The binary file '.app/Frameworks/AcceptSDK.framework/libswiftRemoteMirror.dylib' is not permitted. Your app can’t contain standalone executables or libraries, other than the CFBundleExecutable of supported bundles. Refer to the Bundle Programming Guide at https://developer.apple.com/go/?id=bundle-structure for information on the iOS app bundle structure."
ERROR ITMS-90206: "Invalid Bundle. The bundle at '.app/Frameworks/AcceptSDK.framework' contains disallowed file 'Frameworks'."**
**Action points: -
After achieving the build. I checked the path , '.app/Frameworks/AcceptSDK.framework/ ' in which I found the files ("libswiftRemoteMirror.dylib" and folder 'Frameworks' )which was causing the issue.
I deleted those  and proceeded to the App Store submission.**
I used Xcode 8 for submitting the application.
Good Luck!


Transfer Id should be u64.

About These Changes

Makes transfer_id u64 throughout the client lib and FFI.
closes casper-network/casper-node#1577

bors merge

bors merge


Enable Registration with E-Mail Address for Ginlo Private

Currently, Ginlo Private users can only register using a mobile phone number. Since 4.1.0 we have added the capability to use multiple devices. When adding a second device, users can identify themselves using email addresses.
Thus, we should also enable initial registration using E-Mail Addresses.

Done => Released


Added possibility to have grid in component and call its handlers in addAction

problem:
class XyzGridControl extends BaseControl
{

     ....
     $grid->addAction('confirm', 'Schválit', 'confirm!');
}

causes: Unknown signal 'confirm', missing handler XyzModule\XyzPresenter::handleconfirm()

Question is: Can this change broke something?

Great!
Yes, it can, in that 100 downloads. If someone is using it "incorrectly", it would be a BC break. How should i decide? How to implement this and don't break back compatibility?

One option is to release it with BC break as new version.
Another option is catch exception and call getPresenter() instead as fallback.

Could you please add the second solution? I thought about it too.
It will be removed in next version.

Sure, working on it.


Fuerte + Pregel + Agency = 🥑

Scope & Purpose
Replace usage of ClusterComm in folders arangod/Agency and

[x] Strictly new functionality (i.e. a new feature / new option, no need for porting)
[x] The behavior in this PR can be (and was) manually tested (support / qa / customers can test it)
[x] The behavior change can be verified via automatic tests

Testing & Verification
This change is already covered by existing tests, such as the Agency testsuite and shell-pregel.js
https://jenkins01.arangodb.biz/job/arangodb-matrix-pr-linux/8177/

https://jenkins01.arangodb.biz/job/arangodb-matrix-pr-linux/8182/

https://jenkins01.arangodb.biz/job/arangodb-matrix-pr-linux/


Move away from Sass Legacy JS API

Part of #12717. This is a warning currently reported by Sass:

Deprecation The legacy JS API is deprecated and will be removed in Dart Sass 2.0.0.

More info: https://sass-lang.com/d/legacy-js-api

Working on this.
Anyone can contribute to this. I believe the only change needed will be to upgrade our version of sass-loader, and (possibly) switch our Sass implementation from the sass package to sass-embedded, which promises to be faster (this will warrant testing).
Note sass-loader has a few breaking changes as part of those upgrades (see the sass-loader CHANGELOG). So this work might require changes to our configuration (which is very vanilla).

@thibaudcolas Raised PR for this.
Upgrading to latest (16.0.4) - warnings are gone now and switched sass  to sass-embedded (I can not see visible time deduction in compilation after changing sass to sass-embedded)


[1.16.5-Forge-Suggestion] Mark mod as client side only, makes server "fml server incompatible" in server list.

Title ^
Versions

ArmorSoundTweak: 3.0.0
Forge: 36.1.62
Additional mod(s) No mods.

Describe the bug
If mod is missing on server it makes the server ping "Incompatible FML Modded Server".
To Reproduce
Steps to reproduce the behavior:

Install mod on client.
Don't install on server. (Because it crashes.)
Add server to multiplayer list.
Ping it.
"Incompatible FML Modded Server".

Expected behavior
That the modlist is compatible. showing a green checkmark like below:

Additional context
If possible, mark mod as client only.

I fixed this in-dev a while back but then forgot to make a release, my apologies! I'll have an update out later today!

Fixed in https://github.com/ChloeDawn/ArmorSoundTweak/releases/tag/3.1.0-forge https://www.curseforge.com/minecraft/mc-mods/armor-sound-tweak/files/3396535
Apologies for the delay in getting this hotfix released!
The project file on CurseForge is now pending approval


Update EditorScreen.swift to include clear button

Added function to clear the text editor

Hi @IRFAANFTK
While I like the idea, I don't think this is the way to do it. Using the id binding to redraw the view when the button is tapped does update the view, but I'd love for this to happen automatically when resetting the text binding.

Hi again @IRFAANFTK
I have updated the rich text context with new functions for resetting and setting the attributed string, so this is no longer as tricky as it was before.
I'm closing this, since I'm not sure we need it :)