*: support parsing all PARTITION BY syntax

What problem does this PR solve?
Support all PARTITION BY syntax from MariaDB, since DM needs to use pingcap/parser to parse these upstream DDLs.
What is changed and how it works?

Parses all 5 types of partitions supported by MariaDB, i.e.

HASH
KEY
RANGE — and the VALUES LESS THAN clauses
LIST — and the VALUES IN and DEFAULT clauses
SYSTEM_TIME — and the HISTORY and CURRENT clauses

The parse result is now saved entirely into the AST. Constructs like SUBPARTITION and options like ENGINE are now part of the Restore text.

As partitions options are a subset of table options, the following 4 new table options can now be parsed:

TABLESPACE = identifier
DATA DIRECTORY = string
INDEX DIRECTORY = string
NODEGROUP = number

Support parsing and restoring ALTER TABLE ... PARTITION BY syntax. As a side effect, ALTER TABLE t1,; is no longer valid (ALTER TABLE t1; is still valid).

In ALTER TABLE ... DROP PARTITION and TRUNCATION PARTITION, support parsing and restoring multiple partition names.

Support restoring ALTER TABLE ... ENABLE KEYS and DISABLE KEYS (for easy testing).

Corresponding TiDB PR: pingcap/tidb#10672
Check List
Tests

Unit test

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

PTAL @tiancaiamao @winkyao cc @csuzhangxc

LGTM


Blockquotes in lists

Hey guys. Awesome plugins, unfortunately I'm wondering, if this is valid markdown and nesting like this can be supported:

first item

first sub item
second sub item

second item

first quote in a subitem

Here must be a placeholder to render the second list correct

first item

first sub item

second item

first subitem in a quote

The last one does work, if there is an additional empty line between the last two lines, but this will generate a line break, too:

first item

first subitem in a quote

Thank you

test android


[REVIEW] muthuannamalai12

Github Profile Link:

https://github.com/muthuannamalai12
Here is my Github profile link. Would love to hear feedbacks from everyone

That looks awesome! two cents from my side

Shift contact link below the typewriter text
Add more tools and tech maybe
java image is small than HTML, CSS, and js. Even size images may look better
The GitHub streak section is repeated. Maybe remove one
Font size of the welcome text, about-text, can be increased to make it easier to read
Add some projects to pinned (take advantage of max 6 limits)
Awesome profile btw!

Thank you Kaiwalya for the feedback I have not created projects so I would pin my projects once I create them. I have removed the GitHub streak part and also moved my contact section below typewriter text

Thank you for sharing, we will review on a live stream soon 👍 It looks like you are getting great community feedback already 💥

Kaiwalya listed out great points, here's one from me:
Instead of dumping the whole text in about me, you can make it into bullet points, show what's important and yes a bit bold maybe? to make easily readable.

Nice

Reviewed on live stream https://www.youtube.com/watch?v=wQvlaYc5nl8
Looks great! My thoughts...

Suggest remove aspiring...
Animate text does not work well in Safari, also not good for accessibility
Twitter badge looks different, can the badges be on 1 line


feat: Update pyproject.toml for beta release

Major change is the shift from httpstan 1.x to httpstan 2.x.
Other changes are minor, aligning pyproject.toml with httpstan's.

Segfaults
Do we need --forked for the pytest? Or is that only a macOS fix?

The --forked is needed with clang on httpstan.

Running gdb on this tells me there is some sort of race condition concerning the temporary directory which gets created to hold a copy of the module. There may be other problems.

Found a fix. It involves removing the thread which runs the server in the background and using asyncio throughout. There's a bit of code to write because we are no longer using requests.


[SUGGESTION] Add Contraption Framework to ACF

Short Description
Add Contraption Framework in order to greatly simplify and speed up contraption-aware functionality in ACF.
References (Optional)
https://github.com/Stooberton/cframe

any updates?

Contraption Framework is a big project unto itself and definitely shouldn't be considered for integrating any time soon.

I think we're reconsidering this one now; adding CFW support would help resolve a currently existing conflict between it and ACF's turret entities (see ACF-Team/CFW@f91bcd8), and we could use it for some new features that would otherwise be more difficult to implement (ie. baseplate legal checks?)


ci(transformer): enable unfinished plugins in benchmark

Even the plugins are unfinished, we still want to enable all of them to track the performance changes during the development.

#7040  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on  Graphite

I agree that it's good to measure all our transforms, even the unfinished ones, in benchmarks.
However, enable_all is a public API (like Babel's "force all transforms" option), so in my opinion it seems a bit odd to offer an "include unfinished plugins" option, as that's a bit like offering a "break all your code" option!
I think it'd be preferable to leave enable_all as it is, and manually enable the unfinished transforms in tasks/benchmark/benches/transformer.rs.
Or, if you want to locate this logic in oxc_transformer without exposing it to the user:
impl EnvOptions {
    pub fn enable_all() -> Self {
        Self::enable_all_impl(false)
    }

    /// For internal use only
    #[doc(hidden)]
    pub fn enable_all_impl(include_unfinished_plugins: bool) -> Self {
        // Same as impl in this PR
    }
}

Benchmarks can use enable_all_impl, but we don't "officially" expose ability to run our shonky half-finished transforms to the user.

However, enable_all is a public API (like Babel's "force all transforms" option), so in my opinion it seems a bit odd to offer an "include unfinished plugins" option, as that's a bit like offering a "break all your code" option!
I think it'd be preferable to leave enable_all as it is, and manually enable the unfinished transforms in tasks/benchmark/benches/transformer.rs.

We tend to forget to enable unfinished plugins in the benchmark easily. So I am not a fan of this way

Or, if you want to locate this logic in oxc_transformer without exposing it to the user:

impl EnvOptions {
    pub fn enable_all() -> Self {
        Self::enable_all_impl(false)
    }

    /// For internal use only
    #[doc(hidden)]
    pub fn enable_all_impl(include_unfinished_plugins: bool) -> Self {
        // Same as impl in this PR
    }
}

Benchmarks can use enable_all_impl, but we don't "officially" expose ability to run our shonky half-finished transforms to the user.

IMO, enable_all is also an internal-only API. So we can add
/// For internal use only
#[doc(hidden)]

to enable_all method. Tell me what's your thought about this

@Boshen Is enable_all meant to be a public method or not? I thought maybe it is (like Babel's "force all transforms" option).

This is not a public API.

OK great. @Dunqing I had misunderstood. I had thought enable_all was a public API.
Since it's not, this PR with this added to enable_all (as you suggested), seems good to me:
/// For internal use only
#[doc(hidden)]

Sorry I wasted time!

Merge activity

Nov 2, 2:17 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.


Need for local saving and loading of model.

The exp.py train executor interfaces with wandb for saving and loading models, and takes checkpoints as optional parameters. It doesn't look like the model is saved anywhere on disk, there is also no naming convention used for checkpoints exampled in the code. How do we seperate out the saving and loading functionality from wandb so that it can be executed completely locally?

You can run wandb offline https://docs.wandb.ai/guides/technical-faq.


Added LDAP Auth

Added basic LDAP Auth:
Based on ldap3, I just added the option ldap after --proxyauth :
--proxyauth ldap[s]:url_ldap:dn:group
example :
--proxyauth ldap:ldap.forumsys.com:uid=?,dc=example,dc=com:person
So the DN can be anything (should be based on the configuration of the ldap server), the username will be queried as ? in the dn.
Basically it will connect and bind to the server and check that the user :

Has proper creds for logging in the server
Is part of a group (needs to be configured on the LDAP server) that will be allowed to use the proxy

Unfortunately a few of the tests are failing.
I'm guessing you need to add ldap3 to the requirements in setup.py.

Awesome. Thanks again for the great PR! 🎉 🍰


change trenton to terraform

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No, no need to refresh for updates in this PR

Contribution checklist:

[ ] I commit to follow the Breaking Change Policy of "no breaking changes"
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
Adding a new service

[ ] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

@dw511214992 , does this PR include all the RPs?

@dw511214992 , does this PR include all the RPs?

@raych1  it only contains the rps which contains terraform codegen readme configuration file.

@msyyc , can you have a look at the python track2 errors?

For python, the error is a known issue. We will fix it soon and It does not block the PR.

For python, the error is a known issue. We will fix it soon and It does not block the PR.

@akning-ms , please force merge this PR.

@raych1 @lirenhe @akning-ms , please hold on merging this for a while. I'll give you update asap after sync with internal corresponding teams.

@akning-ms , I'm fine to have this PR move on now and just approved it. So you may wanna remove the [DoNotMerge] label.


txHex param / signTransaction RPC not working

The popup is stuck in this state:

Code to reproduce
const tx = await makeUnsignedContractDeploy({
  codeBody: `
    (define-public (hello-world)
      (ok "hello world"))
  `,
  contractName: 'hello-world',
  publicKey: '...',
  clarityVersion: ClarityVersion.Clarity3,
  network: 'testnet',
});
const txHex = tx.serialize();
console.log('txHex', txHex);

showSignTransaction({
  txHex,
  onFinish: d => {
    alert(JSON.stringify(d, null, 2));
  },
  onCancel: console.error,
});

Also tried with an unsigned STX transfer, didn't work either

Thanks for reporting @janniks. Which version of @stacks/transactions is this using?

@janniks is this still an issue? If so could you point us in the direction of the @stacks/transactions package?


Add Theming Options to allow Custom Themes

I am thinking to add a Panel Option for Themes: 'Auto', 'Dark', 'Light', 'Custom'.
With a 'Custom' Theme you can specify your own theme for all components.
It will be a great feature!

my first tought it's to set up "backgroundColor: '#181b1f'" in dark mode so the panel background have the same color of the classic grafana interface in dark mode.

on the left is the pannel having the option "backgroundColor: '#181b1f'" on the right is the default one
what you think about it?

@AceSeanGG Thank you for suggestion. I was thinking to update the Dark mode to make default background color configurable. I can use the Grafana's native color for the default color panel.
We discussed the idea internally and agreed to implement custom themes in the upcoming version along a new YouTube tutorials how to create a custom theme and use it in the panel.
Stay tuned.

Hi! I see that the feature was postponed a few times: is it still planed?
Thank you for your job!

@BlueskyFR Is it something you are interested in? We don't see enough interest for this feature so far and postponed prioritizing other issues and plugins.
I was considering implementing it in the upcoming release.

@BlueskyFR Is it something you are interested in? We don't see enough interest for this feature so far and postponed prioritizing other issues and plugins.
I was considering implementing it in the upcoming release.

Thanks for your quick reply!
Yes I am totally interested!
I was trying to add a custom theme this afternoon so in the mean time I hardcoded the color values in my plot but it would be nice to be able to provide one somewhere.
But I agree that it is not the most useful feature as specifying colors on a per-plot basis is not that annoying after all 😊

@BlueskyFR Great, it should be easy to do with another Code Editor in the upcoming version.


Function to optimise does not saves file

Hi,
First of all congratulations for designing such a great tool.
I am trying to optimise a function, that at every step it takes several hours to evaluate. The function itself saves the result in a file, so that I can retrieve some very useful information afterwards. However, when the function is optimised with GPyOpt, I have noticed that it does not save the necessary files, not sure why that is.
Something else I am noticing is that the function can run in parallel in many cores. When I set that function to run in the 8 cores I have, and run GPyOpt in 1 core, I was expecting to see the function running in 8 cores, however it does run only in 1. How does that work?
Many thanks,
Manuel

Was a memory issue. Solved.


Add ini settings for fork support to PHP extension.

The PHP extension now has the ability to enable fork support by setting the environmental variables GRPC_ENABLE_FORK_SUPPORT and GRPC_POLL_STRATEGY. Since PHP tends to run in a number of different environments, though, it is often hard to ensure that the environmental variables are set everywhere (and in all subprocesses). Also note that since the environmental variables have to be set at the time the extension is initialized, it is not possible to set them properly in "user" PHP code. Not having these environmental variables set is quite dangerous as it causes subprocesses to hang forever.
This change exposes two new ini settings. grpc.enable_fork_support and grpc.poll_strategy. This allows users of PHP to ensure this support is enabled by pushing out custom php.ini settings. This is something most PHP shops already do. Under the hood, these settings set the proper environmental variables before grpc_init is called as part of the extension initialization.

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.
After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

One or more commits are not associated with a GitHub user. The email used in the Git commit must match a verified email address in a GitHub user profile. For more information, please see https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/

Regards,
CLA GitHub bot

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.
After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

User @kellegous isn't covered by a CLA. They will need to complete the form at https://identity.linuxfoundation.org/projects/cncf

Regards,
CLA GitHub bot

👍 Agreed to CLA.

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.
After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

User @kellegous isn't covered by a CLA. They will need to complete the form at https://identity.linuxfoundation.org/projects/cncf

Regards,
CLA GitHub bot

👍 I really signed it this time.

As part of testing out my change, I discovered that the forking support for PHP is currently broken on master. It looks like part of grpc_shutdown was deferred onto a detached thread and is not probably asynchronous. The error I see is the following:
PHP Fatal error:  Uncaught UnexpectedValueException: Oops, failed to shutdown gRPC Core after fork() in

I suspect it was broken in 456f748b2f63be2197da033fc250be753439fb48, but I have not confirmed.

How about using the released version of 1.19.0? I will test that out myself as well.

If you need a 1-liner to reproduce that issue.
GRPC_ENABLE_FORK_SUPPORT=1 GRPC_POLL_STRATEGY=epoll1 php -d 'extension=grpc.so' -r '$pid = pcntl_fork(); if ($pid) {pcntl_waitpid($pid, $status);}'

Ok, I think fixing this just requires calling the "blocking" variant of gprc_shutdown.
diff --git a/src/php/ext/grpc/php_grpc.c b/src/php/ext/grpc/php_grpc.c
index fa6f0be837..9c7a9d9861 100644
--- a/src/php/ext/grpc/php_grpc.c
+++ b/src/php/ext/grpc/php_grpc.c
@@ -180,7 +180,7 @@ void postfork_child() {
   grpc_php_shutdown_completion_queue(TSRMLS_C);

   // clean-up grpc_core
-  grpc_shutdown();
+  grpc_shutdown_blocking();
   if (grpc_is_initialized() > 0) {
     zend_throw_exception(spl_ce_UnexpectedValueException,
                          "Oops, failed to shutdown gRPC Core after fork()",

@stanley-cheung Sorry, I didn't answer your question earlier. We are currently using v1.19.0 and it seems to be working just fine. I just meant for the purposes of testing out this new change that I introduced in this PR, master doesn't seem to work properly with GRPC_ENABLE_FORK_SUPPORT and GRPC_POLL_STRATEGY set in the environment.

#18558

@kellegous #18558 is merged on master. Do you mind rebasing this PR please? Thanks.

Thanks @stanley-cheung. This should be rebased now.

Test failure: #18477


Improve async logic to scale better

Currently some async logic is implemented e.g. processing Messages are mainly done async. Still, the code blocks executed asynchronously contains too much logic.
To better scale the Dispatchers should be optimized in not only calling processMessage asynchronously but also other methods.
For example:

Thread receives the messages --> forward to dispatcher
Thread process the message by replacing substitutes
...
Sends the message to C8Y or outbound to Connector

Every "heavy" and cpu-intensive processing should be handled asynchronously if possible.

This issue will be addressed with the upcoming Spring Boot 3.0.x update and leverage Virtual Threads.
We already implemented something in the following branch https://github.com/Cumulocity-IoT/cumulocity-dynamic-mapper/tree/virtualThreads but waiting for the "new" Microservice SDK is released so we can officially use Virtual Threads.


Command execution

In order to execute commands on android.

If we need to copy model structure from server, we need to use it for everything including positions.

All the used model structures are copied from backend. Do you think I've missed something or has to be applied in a different way?

Note that GitHub doesn't send notifications when you push new changes. You need to put a comment to notify me about it.

Merged the changes. Thanks.


Learning Rate Scheduling Logic

According to the paper, during training you run for a default of 200 epochs and multiply the learning rate by 0.1 at 120 and 160 epochs. During finetuning, these numbers turn out to be 100, 60, and 80 respectively. For the finetuning case, this would imply a learning rate of 30, then 3, then 0.3, however this is not what the logic of the milestone scheduler performs.
def adjust_learning_rate(optimizer, epoch, args):
    """Decay the learning rate based on schedule"""
    lr = args.lr
    for milestone in args.schedule:
        lr *= 0.1 if epoch >= milestone else 1.
    for param_group in optimizer.param_groups:
        param_group['lr'] = lr

Instead what happens is that the learning rate is constant at 30 up until epoch 59, and then at every epoch between 60 and 79 it is multiplied by 0.1. Furthermore, at epochs 80 to 100, it is multiplied by 0.1 twice in each epoch cycle (once for epoch >= 60, and again for epoch >= 80. You end up with a final learning rate that is essentially zero. The key is the greater than or equal to operator, which should be just an equal operator. Correct me if I'm wrong, but shouldn't the logic be:
def adjust_learning_rate(optimizer, epoch, args):
    """Decay the learning rate based on schedule"""
    lr = args.lr
    for milestone in args.schedule:
        lr *= 0.1 if epoch == milestone else 1.
    for param_group in optimizer.param_groups:
        param_group['lr'] = lr

In order to conduct the kind of stepwise learning rate scheduling that is described in the paper?

then at every epoch between 60 and 79 it is multiplied by 0.1

Yes, and it is multiplied by 0.1 w.r.t. args.lr == 30. Therfore it will be 3.0, as expected.


Investigate Long that are undefined in deserialized protobuf messages

There's two PRs (#88 #89) submitted about this, but they fix the symptoms instead or fixing the issue.
Something must have changed in a recent version of protobuf that causes this issue.

Something must have changed in a recent version of protobuf that causes this issue.

nothing changed in protobuf.
the bug appears when a 3rd party package modifies the behavior of protobufjs by removing its support for Long.
example: apollo-server.
#89 was a way to make sure that we treat all values as Long type.
you can make it better by treating Long & number separately.

Fixed in 0.2.14
Pleased try it and let me know if everything works fine.


Keep babashka compatibility

This change proposes to replace Namespace/find with clojure.core/find-ns.
Attempting to run pretty 2.0.1 in babashka yields an error:
   (Namespace/find sym)
    ^--- No matching method find found taking 1 args

This is introduced in a recent change (https://github.com/clj-commons/pretty/pull/95), the previous version 2.0 works fine. This is because Namespace/find is not compiled (probably considered an implementation detail).
But clojure.core/find-ns is included and is equivalent
https://github.com/clojure/clojure/blob/38bafca9e76cd6625d8dce5fb6d16b87845c8b9d/src/clj/clojure/core.clj#L4126-L4130

Thanks for this fix!


Fix %NAME variable in README.md

Just a few typos in the README where the %NAME% variable is referenced as %NAME

Thanks for the assist! 🙌


[CSV-234] Add support for java.sql.Clob

Use jdbc API to read clob

Coverage decreased (-1.3%) to 93.743% when pulling 49f59c664094c03199764d75c47a92b5634a5b24 on dedabob:master into 0ab2b0818afe1ca083afcb08c20a3937b98bb786 on apache:master.

:100:


different number same result

Hi guys,
Code
use Hashids\Hashids;

$hashids = new Hashids();
echo $hashids->encode(215);
echo $hashids->encode(1315);

Result
 // echo 'qOWyZxRAb9Y6aJ0waL3gBo4VzPXKlM7N2Q';
 // echo 'qOWyZxRAb9Y6aJ0waL3gBo4VzPXKlM7N2Q';

Hey, it seems you're using an old version of the library. Try updating to the latest version.

Hi, i use latest version
"hashids/hashids": "^3.0",


Use history version without deprecation warnings

Oh shit, I just edited the branch directly. 0b4dae5
I don't think this screws anything up, though.

Restarted your build. It failed because of Travis, not your code.


Production Calculator: Enable users to add their own estimate of skill procs

Details
This would need quite a bit of work, some of which in the frontend to allow users to select an amount of procs.
In the frontend I'm thinking a range slider like we do for e4e currently.
Int he backend there is more work though. We should identify all relevant skills for ingredient production and factor in skill procs in the total produced ingredients.

Won't do as we now have accurate skill%


Update keybase to 3.2.2

Motivation for this change
Update keybase and keybase-gui to 3.2.2
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build keybase keybase-gui


Update markerclusterer dependency

Shouldn't the most recent commits in https://github.com/apneadiving/Google-Maps-for-Rails/commits/master fix this?

It is their most recent commit: https://github.com/apneadiving/Google-Maps-for-Rails/commit/16e067b8765a98c13b5890c6099ac46f2f6079a0

Oh whoops, I see. My bad, merging now.


How to highlight the child nodes which are having relationship with other nodes's childrens?

Describe your use case
Write about what you're building and why do you need this feature.
I want to show the common relationship with other nodes

Hey there @Gangeshwar3 , have you taken a look at highlightDegree in the official documentation page? Let me know if it addresses your needs.

when I mouse hover on any edge node (v1 0r D3) it should highlight that path.

Oh see, I think this might be an edge case on the highlighting for edges only. Would you be able to provide:

Video/GIF of the exact scenario you explained
repo where the issue could be reproducible

This would make debugging way faster, as of right now I don't have time to look into it.


Twirp Integration

In response to "I actually have no idea of how to switch encoders in Twirp. Maybe it's not even possible.", this can't be done out of the box with the code generation, but can be achieved (server-side) with a simple find and replace.
The changes are below:
proto.Marshal(respContent) >> respContent.MarshalVT()
proto.Unmarshal(buf, reqContent) >> reqContent.UnmarshalVT(buf)

I'm using make to control all code gen, so I added the below as a final step:
for twirp in $${dir}/*.twirp.go; \
do \
  echo 'Updating' $${twirp}; \
  sed -i '' -e 's/respBytes, err := proto.Marshal(respContent)/respBytes, err := respContent.MarshalVT()/g' $${twirp}; \
  sed -i '' -e 's/if err = proto.Unmarshal(buf, reqContent); err != nil {/if err = reqContent.UnmarshalVT(buf); err != nil {/g' $${twirp}; \
done; \

See https://github.com/twitchtv/twirp/issues/327 for further discussion.

Thank you! I've updated the README with your example!


feat: add jsonnet support

Pull Request
Thank you for contributing to @toptal/gitignore and https://www.gitignore.io.
New or update
Select the appropriate check box for this pull request. This helps when merging to ensure there are no conflicts with other templates or misunderstandings of how thee template list works.
New

[x] Template - New .gitignore template
[ ] Composition - Template made from smaller templates
[ ] Inheritance - Template similar to an existing template
[ ] Patch - Template extending functionality of existing template

Update

[ ] Template - Update existing .gitignore template

Details

This PR add support for jsonnet language. jsonnet-bundler is used for installing dependencies (similar to node_modules in node for example), so this PR add support for ignoring the installed dependencies in local git directory.

Hey @zephyros-dev! Thank you for the contribution to gitignore!
I have a question. Based on the spec vendor directory should be created in the root. Wouldn't it be more accurate to update the proposed gitignore to target only root vendor directory?

I used that rules since I first thought that the rule vendor/ will only ignores vendor/ rather than path/to/vendor from the root of the git repository, but turns out I misunderstood and the rule vendor/ works with both of them. I have changed the PR to reflect that. Thanks for the tips.


docs: add guard for stdin

Feel free to discard this or fully reword it but IMO it's a good tip to mention somehow!

LGTM! Just shuffled the example around a bit.


Stream print & print bytes

This handles data formats that the cli previously didn't decode (specifically gzip).
Also handles the case where you call get-files on an enormous file. Streams the content instead of loading it immediately.
Changes the make test target to include install, which pip installs the package and puts hca into the namespace. I couldn't think of another way to check that the output printed bytes - open to other suggestions if you think this is a bad solution.

Codecov Report

Merging #32 into jmackey-popup-auth will decrease coverage by 0.16%.
The diff coverage is 25%.

@@                  Coverage Diff                   @@
##           jmackey-popup-auth      #32      +/-   ##
======================================================
- Coverage                61.2%   61.04%   -0.17%
======================================================
  Files                      11       11
  Lines                     794      801       +7
======================================================
+ Hits                      486      489       +3
- Misses                    308      312       +4

Impacted Files
Coverage Δ

hca/added_command.py
81.46% <ø> (ø)
:arrow_up:

hca/constants.py
100% <100%> (ø)
:arrow_up:

hca/__init__.py
35.29% <14.28%> (-10.17%)
:arrow_down:

hca/api/composite_commands/upload.py
88.5% <0%> (+1.14%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeb9d9b...b3a9378. Read the comment docs.

This looks good.  Does travis have a mechanism by which we can do CI on windows?

This diff is much larger than it was maybe an hour ago when I saw it last, FYI.

Yeah, the branch underneath was rebased - need to rebase this one.

Can't easily do CI on Windows: https://github.com/travis-ci/travis-ci/issues/216
Ready for review.

See comments pls.


Ability to set relative ruleset path

Hi!
Loved the idea, but seems Chuck (the original author) no longer maintains the extension.
I added an ability to set a relative path for rulesets starting from the current workspace dir, cause I want to commit rulesets to repos
Please merge once you are ready 🙂

Nevermind, Chuck has merged it into main repo
You can pull it from there, so the commit history won't be broken


API Redesign

As most of you have already noticed, the API of Quagga is neither intuitive nor easy to use. Within this issue I would like you to discuss with me ideas for a new API. The new design should be readable, easy to use and extensible for features to come.
I'm very interested in your suggestions and ideas, so please help me make this API better for everyone. Tell me your current pain-points and let's discuss them in this thread. Based on your feedback and my time available, I'll push a draft of the API in the coming days. Feel free to collaborate.
Requirements

Work with instances rather than singletons
Event based, in preparation for reactive streams
Easy to use with RxJS
Prefer promises over callbacks
creating scanners using images or video in a consistent way

Proposal
As it is currently under implementation
Creating a default video-based scanner
Creates a scanner with default settings and the user's camera:
Quagga
  .fromVideo({constraints: {facingMode: "environment"}})
  .addEventListener('detected', (result) => (console.log(result)));

Creating a default image-based scanner
Creates a scanner that is suitable for static images
Quagga
  .fromImage('../test/fixtures/code_39/image-001.jpg', {size: 800})
  .addEventListener('processed', (result) => (console.log(result)));

When scanning images, the consumer either expects a result, or an error (no result). Hence, returning a Promise would be handy:
Quagga
  .fromImage('../test/fixtures/code_39/image-001.jpg', {size: 800})
  .toPromise()
  .then((result) => {
    console.log(result);
  }).catch((result) => {
    console.log("not found!");
  });

Passing configuration
In most cases, the default configuration is not sufficient and can be adjusted prior to creation:
const customScanner = Quagga
  .decoder({readers: ['ean_reader']})
  .locator({patchSize: 'medium'});

or pass in the entire configuration at once:
const customScanner = Quagga
  .config({decoder: {readers: ['ean_reader']}, locator: {patchSize: 'medium'}});

Starting/Stopping
The general idea is, that everything should be as lazy as possible.
Consumer based
Meaning that the scanner should not start automatically without an event-listener attached. Therefore the processing is started/paused based on the state of the event-listeners. As long as there is a consumer attached, the scanner is active. It should automatically stop/pause when the last consumer is detached via removeEventListener(eventName, callback).
Manually
Another approach would be to start/stop the scanner manually by calling the appropriate methods provided.
RxJS
One reason for redesigning the whole API is the desired move towards a more reactive implementation. With RxJS one could simply write the following code to scan Code 128 and EAN-13 barcodes and react only to the results of interest:
// creating a stream listening on the "processed" events
const processStream = Quagga
  .decoder({readers: ['ean_reader', 'code_128_reader']})
  .fromVideo({constraints: {facingMode: "environment"}})
  .observe('processed');

// create a stream only containing the label and format of a detected barcode
const detectedCodes = processStream
  .filter(result => result && result.codeResult && result.codeResult.code)
  .map(result => ({label: result.codeResult.code, format: result.codeResult.format});

// create a stream containing all boxes which are detected during scanning
const detecedBoxes = processStream
  .filter(result => result.boxes && result.boxes.length > 0)
  .map(result => result.boxes);

After creating these streams, one can listen to them:
detectedCodes.subscribe(code => console.log(code));
detecedBoxes.subscribe(boxes => draw(boxes));

I love the RxJS approach/integration. This definitely opens up the API to a flexible set of use cases. I would love to see an option to get the (image) results of different proessing steps, e.g. the Otsu-binarized image (which is not possible at the moment).
From a configuration perspective, it would be really nice to have it more modular, e.g. .decoder(), .locator(), .debug(), ... instead of having one big configuration object. This makes it clearer and understandable in terms of SRP.
For starting/stopping I would go the manual approach, because it makes the behavior more explicit. Btw: the fluent API approach is great.

+1 to the RxJS approach, but would appreciate ability to use native node streams for highland support.

Thanks for this valuable feedback. I'm currently working on a separate branch issue/109 in case you want to follow the progress. See api-test.js and quagga.js to get an idea of how the API is evolving.
Interesting idea of exposing the different processing steps. I'll keep that in mind. My worries are, that due to the use of web-workers this might be really challenging. Sending data back & forth between all the processing steps seems to me like a waste of valuable processing time. How would you deal with that?
Another thing worth mentioning is the interaction with the new API. Basically, it's separated in three distinct steps:

configuration: chaining: decoder, locator, config together
instantiation: calling fromImage, fromVideo to create an actual instance that can be controlled with start, stop, addEventListener, removeEventListener
Calling toPromise or observe whould return kind of result objects.

In the first step, every function call returns a new object so that common configuration can be shared among multiple instances before actually creating them. In the second step, an actual instance is created. All methods on this instance return a reference to itself to allow chaining calls, with the exception of toPromise and observe.
I hope this makes things clearer. BTW, I'm not yet sure how to get RxJS into Quagga. A hard dependency? Peer dependency? Or even a separate package like quagga-rx that depends on both, quagga and rxjs? Another idea was to completely omit the dependency on rxjs since I've already prepared the API to have functions like addEventListener and removeEventListener which can be easily used to create your own streams by calling Rx.Observable.fromEvent(scannerInstance, 'processed'). What do you think?

I'm not certain about having RxJS as hard dependency. I don't like dependencies, since they also influence your consumers. From my perspective, having an event-based approach without RxJS would be a good fundament. Then a second package quagga-rx would be really nice, which essentially is a wrapper around quagga and provides observables via Rx.
I can't say anything about the web workers and how to get the information out of it. Perhaps it makes sense to have a "debug mode" that exposes the partial results and behaves different to the normal non-debug-mode, which is performance-optimized to return only the final result. Alternatively, when in debug mode, the partial results are attached to the final result, thus the consumer has access to them after the processing is done. From a user's perspective, this would be absolutely sufficient.

I'm totally with you on the topic of dependencies. Then it's settled, no additional dependency for this kind of feature, but a separate package for people who would like to use it with Rx or any other reactive library.

Alternatively, when in debug mode, the partial results are attached to the final result, thus the consumer has access to them after the processing is done

This would eat up a lot of memory. All of the processing is done in-place, meaning that every step overwrites the changes of the previous one.

Perhaps it makes sense to have a "debug mode" that exposes the partial results and behaves different to the normal non-debug-mode, which is performance-optimized to return only the final result.

Sounds more reasonable, but this also means that it would only work with web-workers with some limitations on the consuming part. Without web-workers, this wouldn't be a problem. The core of the problem lies within the inability to share memory between workers. Either the UI-thread has access, or the web-worker, but never at the same time. This means that, if web-workers should be allowed in this "debug mode", the consumer has to signal when it's been done accessing the memory to throw it back into the pool.
In short:

with web-workers: nasty
without: a breeze, by providing lifecycle hooks

This would eat up a lot of memory. All of the processing is done in-place, meaning that every step overwrites the changes of the previous one.

I just thought to enable this only in debug mode. So normally (debug mode "off"), no memory/performance is eaten, but when a user wants to have the partial results attached (debug mode "on"), then the result object is blown up with copies of the partial step results.

Without web-workers, this wouldn't be a problem.

From a debugging perspective, this seems to be fine. Normally I just want to see what Quagga uses as partial results and if those partial results can be finetuned to improve recognition.
From a broader perspective, this could be a problem. You know, in scenarios where you want to use a partial result after Quagga has processed the image. In my case, this would be handling the binarized image over to a QR code scanner, when Quagga has not detected a barcode. Would be great to see this scenario becoming real. Again: if a user could opt-in for different kinds of partial results in the final result, this would be a great addition.

@serratus,  You are already shipping some recognition params with the result: I suppose it will be ok to have some object with sequence of steps in debug mode. I'm not sure about the format: @JauernigIT, is it ok for you to have the image bytes?

Alright, so as far as I understand, the ability get access to the underlying image throughout the different phases is of interest.
Use Cases?
What are the advantages of having access to the image in each processing-step? Please help me to understand why this is important to you.

Passing data to another barcode-reader (QR, PDF417...)
Visualization?

First of all, how should the API cope with that requirement? Two proposals:
addEventListener
Through the already existing method addEventListener
videoScanner
  .addEventListener('binary', image => {console.log(image.size);});

configuration
Another approach would be to define hooks as part of the configuration:
code128Scanner
  .decoder({
    readers: ['code_128_reader'],
    interceptors: {
      binary: image => {console.log(image.size);}
    }
})

Which format?
We also need to agree on the format of the image that's passed into the interceptor-functions. The binary data is most likely to be represented as Uint8Array, but what about the meta-data such as dimensions? Currently, this is all wrapped inside a constructor function ImageWrapper which holds size and data in one place but also comes with additional methods.
Immutable?
Should it be possible to mutate the data that's being intercepted? This allows for additional processing if required, but could also harm the entire pipeline.
Asynchronous?
In case of web-workers, or possible mutations, should the code be executed asynchronously? A callback function could be used to signal that the processing is completed, like so:
function onIntercept(image, next) {
  doSomethingFancy();
  next(image);
}

Web-Workers
Again, this is a very delicate topic since it's deeply integrated into Quagga. One must be aware that access to the image is revoked as soon as the function is done executing. If you want, you could copy the data to your own buffer in one of the interceptors to avoid tight coupling.
This interceptor feature is of much lower priority than the rest of the API rework, because for this to work, a lot of internals must be adapted.

Use Cases
My (personal) use case is that I want to have access to the results of the image processing steps in the onProcessed() callback, thus when the processing is done. I want to hand the processed image over to another (QR code) scanning library without having to pre-process it again on my own.
So, for me it would be fine to just have access to the image processing results in onProcessed(), similar to Quagga.canvas.ctx.* or Quagga.canvas.dom.* as it is today. This perhaps would not be too difficult, since you don't have to implement explicit hooks that change the processing flow.
Interceptors
Intercepting the image processing I would see as "advanced feature". Yes, it probably would be nice to intercept the processing steps and enhance the image with some custom image processing. But for me that's another use case and should be treated as such.

@serratus, In case the new API is still being worked on, I'm interested in the comment you made above about supporting multiple instances. In my use case, I'm trying to have 2 image inputs in one form. Unless I'm wrong, I don't think there's a supported way to do this in the current release.

@jorgepinon Thanks for reviving this old thread. The sad fact is, I'm still working on a new API, but it looks different from the one proposed above. I really try to decouple the image-source from quagga and make it more adaptable for different sources of image data.
Multiple images at once? What would be the use-case? Just to clarify, in the next version of quagga it will be easily possible to run multiple instances of quagga at the same time. I'll keep you posted.

We have an app that needs to scan barcodes from 2 different devices in order to associate them in the database. We got it working with a wizard-style single form, and I was able to detach the event listeners for quagga and reattach when the user moves to the next step.

I'm with @jorgepinon on using multiple instances of Quagga scanners. I'm developing an app that involves two scans: one to register the employee and the other to scan their output. The scanner instances don't need to (in fact probably shouldn't) be running simultaneously but it seems like unnecessary overhead to have to init/destroy the single instance each time the user switches fields. I'm still early in the development of this feature so I'll try to report back with a summary of my experience getting it started.
The fact that this library does what it does, however, is so beautiful. Thank you @serratus for all you've done.

It seems @JauernigIT and I have a similar interest in getting the processed image but it seems the only way to use Quagga to get at it right now is using the ResultCollector to intercept the image data before it is massaged to publish as an event for Quagga.onDetected. Have you considered changing the API for the results? Would there be a performance hit if the imageData was set to the onDetected callback and not consumed?
FYI @JauernigIT, I've replaced using Quagga.onDetected with Quagga.registerResultCollector({ addResult: (imageData, canvasSize, resultCode) => {...} }).


Update pdb format for framework and VSTS

The VSTS didn't like the framework .pdb file, giving an error, similar to this command line test of validity:
"C:\Program Files (x86)\Windows Kits\10\Debuggers\x86\srcsrv\pdbstr.exe" -r -s:ssrc -p:D:\src\packages\Ical.Net\lib\net46\Ical.Net.pdb
error 0xb opening D:\src\packages\Ical.Net\lib\net46\Ical.Net.pdb
This is fixed by adding some conditional debug settings in the project file.
Without this fix one must remember to delete the pdb file whenever one updates packages to avoid build errors, which is a nuisance.

Please merge this, as this causes problems for people using VS Teams Services and .net framework...
The problem is similar to:
https://github.com/sendgrid/sendgrid-csharp/issues/494
...and the fix is similar to:
https://github.com/sendgrid/sendgrid-csharp/commit/c90111f3bdb62c239b38615e92583357f046a90d
Until merged, larger systems using .net framework and VSTS might experience issues with other teams or team members updating nuget packages and getting the incompatible .pdb file and thus breaking build and automatic deployments - quite annoying.

https://www.nuget.org/packages/Ical.Net/4.1.11


Add google-auth-oauthlib requirement

Add google-auth-oauthlib requirement

Codecov Report

Merging #14 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #14   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           3      3
  Lines         242    242
  Branches       46     46
=====================================
  Hits          242    242

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48cdd8c...36dd82e. Read the comment docs.


Timeout parameter not working with Helm v3

What happened?
When using the timeout parameter as you use to use it for helm v2 in the helm block for v3, it says:
invalid argument "900" for "--timeout" flag: time: missing unit in duration "900"
Because in helm v3 you should put it as 900s
If you try to use 900s instead, you get the error:
cannot unmarshal !!str900s into int64
What did you expect to happen instead?
900s should work with helm v3
How can we reproduce the bug? (as minimally and precisely as possible)
Define a timeout and use helm v3 in your devspace.yaml
Local Environment:

DevSpace Version: 5.4.0-beta.0
Operating System: mac
Deployment method: helm

Kubernetes Cluster:

Cloud Provider: minikube
Kubernetes Version: v1.19.4

/kind bug

@alexandrefilgueira thanks for reporting this issue! The timeout parameter is somewhat deprecated and we encourage users to use upgradeArgs instead:
deployments:
- name: quickstart
  helm:
    componentChart: true
    upgradeArgs:
    - --timeout
    - 900s
    values:
      containers:
      - image: myusername/devspace
      service:
        ports:
        - port: 3000

Ah ok, thanks!

I think there's also some confusion regarding  upgradeArgs and the API version, because the website shows v1beta8 as last, but that property is not included in that one. I tried v1beta9 out of curiosity and it seems like that's the latest one now.
So, 5.4 will have v1beta9 as latest right?

@alexandrefilgueira yes the latest config version is v1beta9. Good catch, I'll change the version in the docs


fix: antithesis-bot build

#777  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Bug with processing Api and no global config.json set up

Fixes 'Instance ID is not set.' when using SentinelHubInputTask without having global config.json set up
Minimal (non-working) example:
On fresh install of eolearn (e.g. pip install eo-learn), without setting up config.json with all parameters, it should be possible to use processing api with code like this:
import datetime

from eolearn.core import FeatureType
from eolearn.io import SentinelHubInputTask

from sentinelhub import CRS, BBox, DataSource, SHConfig

if __name__ == '__main__':

    bbox = BBox(bbox=[268892, 4624365, 269892, 4625365], crs=CRS.UTM_33N)
    time_interval = ('2017-12-15', '2018-1-30')

    config = SHConfig()
    config.sh_client_id = '...'
    config.sh_client_secret = '...'
    config.instance_id = '...'

    task = SentinelHubInputTask(
        size=(100, 100),
        bands_feature=(FeatureType.DATA, 'test_feature'),
        additional_data=[(FeatureType.MASK, 'dataMask'), (FeatureType.DATA, 'SCL')],
        maxcc=0.8,
        time_difference=datetime.timedelta(minutes=120),
        data_source=DataSource.SENTINEL2_L2A,
        max_threads=3,
        config=config
    )

    eopatch_proc = task.execute(bbox=bbox, time_interval=time_interval)

Unfortunately, such code produces error:
Traceback (most recent call last):
  File "test_ProcessingApi.py", line 29, in <module>
    eopatch_proc = task.execute(bbox=bbox, time_interval=time_interval)
  File "/Users/batic/.pyenv/versions/eolearn-test/lib/python3.7/site-packages/eolearn/io/processing_api.py", line 67, in execute
    timestamp = self._get_timestamp(time_interval, bbox)
  File "/Users/batic/.pyenv/versions/eolearn-test/lib/python3.7/site-packages/eolearn/io/processing_api.py", line 303, in _get_timestamp
    bbox=bbox, time_interval=time_interval, data_source=self.data_source, maxcc=self.maxcc
  File "/Users/batic/.pyenv/versions/eolearn-test/lib/python3.7/site-packages/sentinelhub/ogc.py", line 369, in __init__
    super().__init__(**kwargs)
  File "/Users/batic/.pyenv/versions/eolearn-test/lib/python3.7/site-packages/sentinelhub/ogc.py", line 33, in __init__
    raise ValueError('Instance ID is not set. '
ValueError: Instance ID is not set. Set it either in request initialization or in configuration file. Check http://sentinelhub-py.readthedocs.io/en/latest/configure.html for more info.

Passing the config to WFS call inside SentinelHubInputTask fixes this.

Codecov Report

Merging #203 into develop will decrease coverage by 0.01%.
The diff coverage is 76.19%.

@@             Coverage Diff             @@
##           develop     #203      +/-   ##
===========================================
- Coverage    80.00%   79.99%   -0.02%
===========================================
  Files           45       45
  Lines         4702     4719      +17
===========================================
+ Hits          3762     3775      +13
- Misses         940      944       +4

Impacted Files
Coverage Δ

io/eolearn/io/processing_api.py
91.06% <ø> (ø)

...ion/eolearn/visualization/eopatch_visualization.py
22.69% <0.00%> (ø)

mask/eolearn/mask/masking.py
76.19% <75.00%> (-1.59%)
:arrow_down:

core/eolearn/core/eodata.py
89.10% <100.00%> (ø)

core/eolearn/core/eoworkflow.py
90.32% <100.00%> (ø)

core/eolearn/core/utilities.py
72.32% <100.00%> (ø)

geometry/eolearn/geometry/transformations.py
92.26% <100.00%> (+0.69%)
:arrow_up:

io/eolearn/io/local_io.py
93.16% <100.00%> (ø)

mask/eolearn/mask/cloud_mask.py
92.24% <0.00%> (-0.29%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4031b05...d7705ad. Read the comment docs.


Straffing

A & D should straf not rotate view for proper mouse+keyboard play.

#2 will make this game a lot more playable to FPS veterans.


Change the image version back to 16.04 to avoid the annoying path error in azure pipelines

[ ] The purpose of this PR is explained in this or a referenced issue.
[ ] The PR does not update generated files.

These files are managed by the codegen framework at Azure/autorest.go.

[ ] The PR targets the latest branch.
[ ] Tests are included and/or updated for code changes.
[ ] Updates to CHANGELOG.md are included.
[ ] Apache v2 license headers are included in each file.

Seems this issue has been fixed


Added IntelliJ IDEA Community Edition

Microsoft Reviewers: Open in CodeFlow

In the case of Jetbrains installers only mode=admin is required. I tried to convince them to make it default (currently they have no default for this), but they didn't understand the issue:

In the case of Jetbrains installers only mode=admin is required. I tried to convince them to make it default (currently they have no default for this), but they didn't understand the issue: https://youtrack.jetbrains.com/issue/IDEA-226645
Maybe the community could convinve them to have sane defaults and not require a config file for a very common install config.

This is an issue for all their installers. They refuse to acknowledge the problem.

Two other issues have been opened (https://youtrack.jetbrains.com/issue/IDEA-242025, https://youtrack.jetbrains.com/issue/TBX-4949), but there still isn't any real feedback from them. I think that the problem here is that they don't quite understand what they have to do.

as mentioned above this is blocked.

I opened the PR with the required changes to IntelliJ two months ago, but is still hasn't been accepted. The dev that is following this PR asked about winger popularity in https://github.com/JetBrains/intellij-community/pull/1400#issuecomment-684702491. Maybe the community and users who would like to see JetBrains products in WinGet could speak up in that pull request?

It looks like the PR at JetBrains is closed https://github.com/JetBrains/intellij-community/pull/1400#issuecomment-684702491 but there was a comment from @trespasserw indicating the change is in the main branch. The manifest here would need to be updated to the current supported version.

@mimi89999 feel free to submit a new PR and I'll close this one, or let me know what changes need to be made.

@denelon I will submit a PR when the new version with that change will be released. Now we basically only need to wait for the release and it should work as any other NSIS installer, so it will be easy to add.

@denelon Just opened https://github.com/microsoft/winget-pkgs/pull/5212

Also opened https://github.com/microsoft/winget-pkgs/pull/5213 for PyCharm

JetBrains.IntelliJIDEA.Community was added in another PR.


RuntimeTask host thread + Logging improvements on TE

Context

Currently the runtime task is executed in the IO executor service pool and mixed with other IO ops. Move runtime task execution to its own thread and not share it with the IO thread pool.
Logging improvements on TE lifecycle.

Checklist

[x] ./gradlew build compiles code correctly
[x] Added new tests where applicable
[x] ./gradlew test passes all tests
[x] Extended README or added javadocs where applicable

What tests did you run to validate this change?


Add the description from the user's input and set it into the README.md file

The current README.md file includes the text Minimal library to generate random values. take it from another package. We need to replace that text with the description entered by the user.

Closed on version 1.2.1


sfdx sfpowerkit:source:pmd fails to save output file

Describe the bug
We noticed when running the command sfdx sfpowerkit:source:pmd that the pmd-output file was no longer being produced since the 28th June.
We managed to workaround using
sfdx sfpowerkit:source:pmd -d=src_delta --version=${env:PMDVERSION} --report=pmd-output
but noticed that --report is deprecated for --reportfile, getting the error
--report is deprecated and will be removed in a future version. User --reportfile instead
Interesting this additional flag was not required when running locally.
To Reproduce
run command sfdx sfpowerkit:source:pmd -d=src_delta --version=6.34.0 --report=pmd-output  on ubuntu machine. where
Expected behavior
pmd-output file created with errors (or empty)
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

Agent name: 'Azure Pipelines 4'
Agent machine name: 'fv-az104-341'
Current agent version: '2.188.3'
Operating System:  Ubuntu 20.04.2 LTS
Virtual Environment
Environment: ubuntu-20.04
Version: 20210614.1
Node
OS: [e.g. Windows/Linux]
Node Version
Version of sfpowerkit latest (3.1.4 at time of writing)
Salesforce Org Version Summer 21

Additional context
https://github.com/Accenture/sfpowerkit#source-related-functionalities uses --report. --reportfile throws sfpowerkit error as not supported

@rody Can you comment on this?

@DougMidgley  can you refer to this issue for the changes undertaken
https://github.com/Accenture/sfpowerkit/issues/514

We have aligned the options in the pmd command with the ones from PMD itself (hence the deprecated flags).
To restore the old behaviour, use the 'reportfile' flags and set it to pmd-output. You might also need to specify a format for the report.
(I don't have access to my computer at the moment, but feel free to ping me if you need more details)

@azlam-abdulsalam can we add an entry in the FAQ describing the command line options needed to reproduce the legacy behaviour with the current flags?

@DougMidgley Can we close the issue or do you need more infos?

@Caitlyn-Mills  Can you create a FAQ with the changes


Font awesome icon doesn't work with React

I have a React application. To enable Font Awesome icon i added, before use L.easyButton, import 'font-awesome/css/font-awesome.min.css'; but it doesn't work.
It seems to be an incompatibility of Font Awesome with React. Did you try to use your library with React?

Thanks for your reply. This was exactly what i did:
...

import * as L from 'leaflet';
import 'leaflet-draw';
import 'leaflet-draw/dist/leaflet.draw.css';
import 'leaflet-draw/dist/leaflet.draw-src.css';
import 'leaflet-easybutton';
import 'leaflet-easybutton/src/easy-button.css';

...

L.easyButton('fa-trash',() => {
            // clear layer on new layer
            this.clearLayer(map);
}).addTo(map);

But it shows like corrupted icon.

Yes and yes

Yes is the same issue!


Get rid of default chest at spawn

Describe your idea
I'm making a pack, and when I spawn on the skyblock world type it gives me the classic skyblock starter chest (cobble gen, some plants, nether portal, that kinda thing). I'd like a way to remove that chest entirely in the configs or somewhere else in my instance.
If this is not a feature, will it ever be implemented? I'm on 1.19.2

You can use whatever island you want. You can remove the chest, adjust the chest, replace the tree, and fill the world with lava.
For reference, look at the wiki: https://wiki.chaotictrials.de/skyblock-builder/1.19.x/packdev/packdev/#creating-a-custom-skyblock-island
You can also find some examples to download.
tl;dr just replace config/skyblockbuilder/templates/default.nbt with a template you'd like to use.


Gitignore .packages files.

As of 1.12, pub will start generating these files on all installs.

lgtm, thanks


select specific columns returning Row objects instead of ORM class, load_only() doesn't work

First Check

[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the SQLModel documentation, with the integrated search.
[X] I already searched in Google "How to X in SQLModel" and didn't find any information.
[X] I already read and followed all the tutorial in the docs and didn't find an answer.
[X] I already checked if it is not related to SQLModel but to Pydantic.
[X] I already checked if it is not related to SQLModel but to SQLAlchemy.

Commit to Help

[X] I commit to help with one of those options 👆

Example Code
1)

from sqlalchemy.orm import load_only
from sqlmodel import (Field, Session, SQLModel, create_engine, select)
from chalicelib.models import ( Tx )

engine = create_engine(url, echo=True)

        with Session(engine) as session:
            results = session.exec(select(Tx.Id, Tx.party, Tx.time)
                                   .order_by(Tx
                                             .time
                                             .desc())
                                   ).all()

            myResults = []

            for result in results:
                myResults.append(result.toDict())

2)

from sqlalchemy.orm import load_only
from sqlmodel import (Field, Session, SQLModel, create_engine, select)
from chalicelib.models import ( Tx )

engine = create_engine(url, echo=True)

        with Session(engine) as session:
            results = session.exec(select(Tx)
                                   .options(load_only("id", "party", "time")))
                                   .order_by(Tx
                                             .time
                                             .desc())
                                   ).all()
            myResults = []

            for result in results:
                myResults.append(result.toDict())

Description
Basically I'm following the two methods mentioned here: https://github.com/tiangolo/sqlmodel/issues/232

Selecting columns inside select() returns Row class object instead of the desired ORM class Tx like before

I expected Tx(id=2, party='new', time='0000:00:00') instead got Row object that I am having trouble now converting to a dict with .toDict() that normally converts that Tx object into a dict.

Using sqlalchemy's load_only filter gets ignored.

I expected Tx(id=2, party='new', time='0000:00:00') but instead got all the columns associated.
Want to know if I'm doing this the "right" way, seeing as there is no documentation and I could only find this information after coming across #232 via Google search.
Operating System
Linux
Operating System Details
No response
SQLModel Version
0.0.6
Python Version
3.8
Additional Context
No response

Using sqlalchemy's load_only filter gets ignored.

The excluded columns will still be retrieved if you inspect them within the context of the session.

I had the same issue. Not sure which is the better approach. load_only does seem to work for me. Also I've tried passing the fields from the model instead of the hard-coded field strings and that seems to work too. Something like this
results = session.exec(select(Tx)
                 .options(load_only(Tx.id, Tx.party, Tx.time)))
                 .order_by(Tx
                           .time
                           .desc())
                 ).all()

Wanted to also know the best way to do this. Would be great to include it in the documentation too. I can help with adding it to the documentation if there is a "good" approach for it.


Module Arrow velocity unit doesn't exists

Downloaded the mod for 1.20.1 with forge 47.2.0, to use im my modpack but i get a kubejs recipe error and vanilla error saying item that this module doesn't exists. i tryied with a brand new instace with just mekanism, the basic addons  like generators and tools but the item still doesn't exists.
latest.log

hi, sorry for late response, but the arrow velocity it is in wip, it is necessary to solve some bugs, for that reason it is not available in the game

Any updates on this?


Update COBC-EDU protocol

Fixes #164

Codecov Report
Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (7a0d43a) 81.81% compared to head (4d47dda) 81.81%.

Files
Patch %
Lines

Sts1CobcSw/Edu/EduMock.cpp
0.00%
3 Missing :warning:

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #169   +/-   ##
=======================================
  Coverage   81.81%   81.81%
=======================================
  Files          16       16
  Lines         451      451
=======================================
  Hits          369      369
  Misses         82       82

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Training Loop Question

Orion version: 0.1.6
Python version: 3.6.8
Operating System: Windows 10

Description
I'm trying to better understand the part of tadgan.py in the snippet below. It seems that the two critics gets trained on partitions (default = 5) of the minibatch, but then the encoder and generator only get trained on the 5th partition of the data. I may be missing something, but it seems that the encoder and generator never see 4/5 of the data this way. Is that correct?
for j in range(self.iterations_critic):
    x = minibatch[j * self.batch_size: (j + 1) * self.batch_size]
    z = np.random.normal(size=(self.batch_size, self.latent_dim, 1))
    epoch_cx_loss.append(
        self.critic_x_model.train_on_batch([x, z], [valid, fake, delta]))
    epoch_cz_loss.append(
        self.critic_z_model.train_on_batch([x, z], [valid, fake, delta]))

epoch_g_loss.append(
    self.encoder_generator_model.train_on_batch([x, z], [valid, valid, x]))

Hi @KSGulin, good question. The training approach is inspired by the algorithm proposed in Wasserstein GAN. Because we shuffle the data in each epoch, batch content will change in each training loop.
If the number of epochs is large enough, we can assume that the encoder/generator will see all the data.


Create a tutorial on how to use dlc-connect (webapp) including API

Also make sure to mention how to use our just file


Move lock logic to fakeClock. Reduce Ticker and Timer code complexity.

Minimize the custom logic of Tickers and Timers.
Don't allow Tickers and Timers to access to the lock of the fakeClock that controls them. Use closures instead.
Use a common expirer interface for Timers and Tickers, rather than reusing Timers for both.
Create a firer struct to handle commonalities between Tickers and Timers.
Use a single function & code path for Timers, regardless of if they are made with NewTimer or AfterFunc.
Add Reset to Ticker interface, which was added in go 1.15.
Use the mutex hat pattern and add documentation on what the mutex protects.
Change field name/type from "sleeper"/"timer" to "waiter"/"expirer" and add documentation.
Various documentation updates.
Sort expirers using a sort.Slices.
NIT: Use the standard layout time as the default for NewFakeClock.
Style NIT: Return/continue early where possible.

Tested: All tests pass, no race conditions from go -race.

I think this is going to fail until #51 is merged.
I recommend delaying this review until #51 is merged and I can re-run integration.

I don't mind dropping Go versions from the matrix if that's necessary to keep up with changes. If it's easily avoidable (eg. using build tags), good, if not, supporting the last 2-3 Go versions should generally be enough.
Just make sure it's reflected in the go.mod file as well.

Ok, this should be ready to go for go version 1.15 and up.
I used squash to add the changes to go.mod, please let me know if that is the preferred way to do it. I noticed the top line of the commits were the same in both cases, which was somewhat confusing. Maybe you have a way to squash them all on your end?
Let me know if you need anything from me to keep the commit history tidy.

I don't know why it shows the integration tests for 1.16 were cancelled, maybe because the earlier ones failed? Either way, I see 1.15, 1.17, and 1.18 succeeded.

I updated the CI config on master. Can you please rebase your PR, so CI gets triggered for the supported Go versions only?
And yes, they got cancelled because failing fast is enabled by default on GitHub Actions. Fixing that in the next patch.

Done. Thanks for updating the CI settings!


tsv_split_merge

Can you provide the merged flickr tsv dataset? the file I merged using the tsv_split_merge.py does not work

yes,I also tried to merge the downloaded dataset, but this error occurred. What could be the problem?
Traceback (most recent call last):
File "/mnt/workspace/workgroup/chenlei/paper/GLIGEN/tsv_split_merge.py", line 325, in
merge(args.merge_in_folder, args.merge_out_folder)
File "/mnt/workspace/workgroup/chenlei/paper/GLIGEN/tsv_split_merge.py", line 289, in merge
for idx in range(len(reader)):
File "/mnt/workspace/workgroup/chenlei/paper/GLIGEN/tsv_split_merge.py", line 137, in len
return self.num_rows()
File "/mnt/workspace/workgroup/chenlei/paper/GLIGEN/tsv_split_merge.py", line 102, in num_rows
self._ensure_lineidx_loaded()
File "/mnt/workspace/workgroup/chenlei/paper/GLIGEN/tsv_split_merge.py", line 145, in _ensure_lineidx_loaded
self._lineidx = [int(line) for line in lines]
File "/mnt/workspace/workgroup/chenlei/paper/GLIGEN/tsv_split_merge.py", line 145, in
self._lineidx = [int(line) for line in lines]
ValueError: invalid literal for int() with base 10: '0\t{"data_id": 0, "image": "/9j/4AAQSkZJRgABAQAAAQABAAD/2wBDAAgGBgcGBQgHBwcJCQgKDBQNDAsLDBkSEw8UHRofHh0aHBwgJC4nICIsIxwcKDcpLDAxNDQ0Hyc5PTgyPC4zNDL/2wBDAQgJCQwLDBgNDRgyIRwhMjIyMjIyMjIyMjIyMjIyMjIyMjI

Modify these lines:
  # lineidx_files = files[0:N//2]
  # tsv_files = files[N//2:N]
  lineidx_files = sorted([f for f in files if f.endswith('lineidx')])
  tsv_files = sorted([f for f in files if f.endswith('tsv')])


Performance of TxOut address

This PR moves CompactAddr module out of cardano-ledger-shelley into cardano-ledger-core
Also It improves the performance of getting Addr and CompactAddr from TxOut. In particular for Shelley we store Addr in compact form, so not much will change there, but for Alonzo onwards most of TxOut will have Addr stored in a packed form of 4x Word64. It is wildly inefficient to serialize and then deserialize the full address (which is what happens now), it is much better to use those words with slight adjustment in order to construct uncompacted Addr directly, which is what this PR implements.
Moreover, in getFilteredUTxO it would be beneficial to know in which form a particular TxOut has the address stored in order to perform optimal filtering. This PR takes care of that too.

have you done some benchmarks on the getFilteredUTxO?

@DavidEichmann One answer: No I have not :smile: But with all honesty I would be shocked if this was not a speedup! I just don't know how much of a speedup.


Cannot run the demo

I am getting an issue, when I tried to run the demo using the command 'npm run demo', coulf you please help me to resolve it?
npm-debug.log
Thanks,
Mani

Did you find a solution?

No, I was not able to resolve, anyway I don't need it now but thanks for asking.


Add Radix Extension

Description

A simple extension to allow Raycast users to search and open Radix documentation in the browser (or copy the URL).
Type of change

New extension

Screencast
https://user-images.githubusercontent.com/372831/140797480-f2fbca6b-730c-4dfa-888b-c8b0eb666af9.mp4

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I checked that extension's icon has size of 512x512

Good stuff @peduarte! 🚀

@PitNikola thanks Petr! ❤


Ability to set port network protocol (TCP/UDP) in externalServices

Type of question
Best Practices
Support question
Hello. Thank you for adding new feature set container port network protocol. But is there any way to add ability to change port network protocol (TCP/UDP) in externalServices? We are using AWS ALB/NLB. Due to the impossibility of assigning a protocol in the NiFi configuration file, we applied the changes manually in yaml of the service. This led to the fact that after applying changes to nifi yaml configuration, NiFiKop operator unsuccessfully tries to apply changes and it gives an error:
{"level":"error","time":"2023-12-11T07:59:17.457Z","caller":"controller/controller.go:329","msg":"Reconciler error","controller":"nificluster","controllerGroup":"nifi.konpyutaika.com","controllerKind":"NifiCluster","nifiCluster":{"name":"nifi","namespace":"nifi"},"namespace":"nifi","name":"nifi","reconcileID":"b5e0bdca-6f32-4491-9df4-6b8886160e67","error":"failed to reconcile resource: updating resource failed: Service \"nlb\" is invalid: spec.loadBalancerClass: Invalid value: \"null\": may not change once set","errorVerbose":"updating resource failed: Service \"nlb\" is invalid: spec.loadBalancerClass: Invalid value: \"null\": may not change once set\nfailed to reconcile resource\ngithub.com/konpyutaika/nifikop/pkg/resources/nifi.(*Reconciler).Reconcile\n\t/workspace/pkg/resources/nifi/nifi.go:196\ngithub.com/konpyutaika/nifikop/controllers.(*NifiClusterReconciler).Reconcile\n\t/workspace/controllers/nificluster_controller.go:145\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.6/pkg/internal/controller/controller.go:122\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.6/pkg/internal/controller/controller.go:323\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.6/pkg/internal/controller/controller.go:274\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.6/pkg/internal/controller/controller.go:235\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_arm64.s:1197","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.6/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.6/pkg/internal/controller/controller.go:274\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.6/pkg/internal/controller/controller.go:235"}
Seems, NiFiKop operator also can't downscale pods because of that error.
NiFiKop version
v1.5.0-release
Golang version

Kubernetes version
Client Version: v1.28.2
Server Version: v1.28.2-eks
NiFi version
1.23.2

Hello. We are looking forward to your assistance on this matter.
This problem blocks nifi scaling.

Definitely isn't possible currently, but i'll raise a PR for this. I believe we can just do the same thing we did for container ports.

We will be very happy.
Maybe tell me some solution now to make scaling work.
And what is the general reason for the error, why is the operator trying to change the LoadBalancerClass field?

We will be very happy. Maybe tell me some solution now to make scaling work. And what is the general reason for the error, why is the operator trying to change the LoadBalancerClass field?

nifikop doesn't modify the loadBalancerClass field in a Service. Here's the one and only place it modifies Service objects it creates: https://github.com/konpyutaika/nifikop/blob/master/pkg/resources/nifi/service.go#L55-L76
Can you clarify what you mean by "we applied the changes manually in yaml of the service"?

We changed the port protocol in the spec.ports field after nifikop deployed the cluster.
For some reason, the operator wants to change the loadBalancerClass field to null, based on errors in the nifikop logs.
nlb.yaml
https://gist.github.com/Carverook/26db88eb6f2cf8a0afc716dced6e57f4

Did you also set loadBalancerClass: service.k8s.aws/nlb? nifikop doesn't set it when it creates services, so it gets default to null.
Do you need to be able to set the loadBalancerClass? We can expose that in nifikop.

Yeah, it would be great.
Since now this is blocking possible downscaling.
We will be grateful if you do this, thank you!

Yeah, it would be great. Since now this is blocking possible downscaling. We will be grateful if you do this, thank you!

I have added this feature to PR #335

Thanks you!

Thank you very much!)


[bug fixed] Strange character when using listings package

解决模板中使用listings包时出现奇怪字符的问题，相关链接：https://tex.stackexchange.com/questions/54183/strange-character-when-using-listings-package

I think this is a by-design feature, not a bug.

I think this is a by-design feature, not a bug.

You're right. It's just a little weird, but not a bug.


All hosts Add Blazor samples

This adds the Excel and Word Blazor samples to the list of samples.

Docs Build status updates of commit 2f320fc:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/overview/office-add-in-code-samples.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit a8ad677:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/overview/office-add-in-code-samples.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Refactor scheduling module to use react query

🚀 Feature Proposal
Refactor the scheduling module to to use react query instead of redux
Need 5 hooks

useAppointment
useAppointments
useScheduleAppointment
useUpdateAppointment
useDeleteAppointment

Refactor the code to use these new hooks
Motivation
Remove redux
Technical Notes

use incidents module for inspiration
remove redux after completion

Hello, can I be assigned this issue please?:)

@WinstonPoh  Go for it! Thank you!


Include "type signature" from the schema.yml docs in the ref preview

Describe the feature
The current command+hover preview looks like:

It includes the config block from the model. It would be nice to see some more metadata in there like the table description or even the columns if it could be presented in a readable way.
Describe alternatives you've considered
You can kind of get to this with an extra click if you go-to the definition of the ref and read the docs but then you are opening a new file.
Who will benefit?
This is a pretty generalizable feature. I suspect that most folks don't use the preview as much as they just click through to the definition.
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

@jsnb-devoted Thanks for creating the issues; looking forward to the PR. Let us know if we can help.

@anandgupta42 -- I started looking into this and I found the vscode api docs hard to follow. I've gone down a few paths and I'm not sure if any of them are correct:

Amend the existing registerDefinitionProvider to augment the command+hover behavior to show metadata about the symbol
Add the registerTypeDefinitionProvider (or maybe replace the registerDefinitionProvider??) that will definite "types" for the symbols.
Totally separate from 1+2 -- create a registerHoverProvider%3A%20Disposable-,registerHoverProvider,-(selector%3A) that shows type metadata when you hover (without the command button).

I am leaning towards #3 being the option here. It seems like the hover capability is actually what we want for this. I just thought there was something a little more formal for displaying "type" information.
If any folks have any experience with this and can save me some time doing trial+error and spelunking thru the docs that would be a great help.

To be totally clear, I haven't actually tried out the HoverProvider myself but based on the docs it seems indeed like the way to go here.
By looking at the interface of the HoverProvider it seems to work very similar to the DefinitionProvider. I think you can try to follow a same path for implementation.
Let me know how it goes!

Copy/pasting my way into making a little progress on this:


GPG Signed binary sha256sums in release

It would be a "Good Thing" (tm) if we could get a GPG signed sha256sum of the plugin binary, since that is what Vault is looking for. We are currently publishing the sha256sum of the zip file, which is good, and I don't suggest changing that, but it should also be GPG signed. ;)
I saw a public key in the release and figured it was time we started doing it ;)

Progress update: GoReleaser currently doesn't really support packaging additional files inside the same folder as the binary. Thus making it impossible to include checksum and signature files in the zip file.
However, I can change the process to not make a zip file. This way GoReleaser will create a checksum file with checksums for the binary files. Then signs that checksum file.
Example of the new checksum file (artifactory-secrets-plugin_0.2.17_checksums.txt):
036f060de5d821137a354a72e4a2196a1caeb72ae59ddbd01d3a9c9e4555b1f9  artifactory-secrets-plugin_0.2.17_darwin_amd64
09be7b7bb35eaf060b0c00569f2233697b020e9b65c9998165f38af84e96f9ed  artifactory-secrets-plugin_0.2.17_windows_arm64.exe
34f86d8fe81c5ca65cb7b6d3c876dba47e70673afb7a12ed41216eaeee441b3d  artifactory-secrets-plugin_0.2.17_windows_amd64.exe
39e1c47c6eab54d611ae11af8ded7fcb664ebe4d0383fe4d289a44b8920e36a3  artifactory-secrets-plugin_0.2.17_darwin_arm64
59c20d12b687adbf83af4c7887e766527720079e8077185c04e2a0e92911dc37  artifactory-secrets-plugin_0.2.17_windows_armv6.exe
6408b12115120f4c1f557690d8c5948168daa8337dafc8823ad1efc8b70ac8a7  artifactory-secrets-plugin_0.2.17_linux_amd64
669a0c0df7198f5747ec72baec773ceb759c42c33112d3365b84d4a8af2d891b  artifactory-secrets-plugin_0.2.17_windows_386.exe
68ddffba5120987bbebd2dd7ec045400ac7f245f9b0436c4d1a0d5a4a9705e3b  artifactory-secrets-plugin_0.2.17_linux_386
70a6d79e6b79cd5d3ada2b6d27e90c5c9b83b6f0ee3d351e89977c8294aba910  artifactory-secrets-plugin_0.2.17_linux_arm64
96692fe9fba8ccead5717314182013bda342ae8b2b2c6696869663367659e3ed  artifactory-secrets-plugin_0.2.17_freebsd_arm64
b975639cc0ce9e1d2ff10aa2ea1013e6fb0a9500c0ec8b8cf251fa0242fcb27d  artifactory-secrets-plugin_0.2.17_linux_armv6
c023c11446ff35d648ba0c65d975ddb54a51110fc701e96379cec4c78f761fe3  artifactory-secrets-plugin_0.2.17_freebsd_386
dea595c372789fd134d20cdc2d369a36d0189e31db4940b9e48e9d584a544f74  artifactory-secrets-plugin_0.2.17_freebsd_amd64
fc7d4093aef8209c1b61596b44bd727a09689d3dccc239e8b0f62b5c8888a58e  artifactory-secrets-plugin_0.2.17_freebsd_armv6

What do you think? My take is that this gives you the signed checksum for each binary. You do need to do some awk/grep to extract the checksum from the text file for the binary you are interested in. And the files uploaded to GitHub are the actual binaries, not zips.

That looks great. We already do something similar for the zip file checksums anyhow, and I am not sure if we need to zip the binaries?

The zip file is part of GoReleaser's feature and was used because it's just a simple config setting. In reality the binary sizes are pretty small so the gain in file size is not massive.
I'll try to create a PR this week.
The main change is the removal of zip file so any scripts that assume the present of zip file needs to be updated.

Good thing it's not 1.0, yet, right!?


Update README.md

Hello @maliks3,
Could you please include in this Issue 104 your successful IDS Reference Testbed implementation?
Thanks in advance.


Provide ScanNet result?

Hi, Kejie,
It is nice to find your result release for ICL and 3DScene.
Would you be convenient to also release the result for ScanNet?

I didn't store the results of ScanNet. Could you run the code to get the results yourself?
Kind regards,
Kejie


Bootstrap_Breadcrumb

Description
Describe more about the issue.
Doc Domain

[ ] Html
[ ] CSS
[ ] JavaScript
[x] Bootstrap

Are you contributing under any open-source program ?

Congratulations you can start working @Koustavjr


⚠ Bofrost.fr has degraded performance

In 4e7e8e6, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1722 ms

Resolved: Bofrost.fr performance has improved in d76759c after 6 minutes.


Add an example showing EFS drive mounted in a KF pipeline.

There is a need to show an example of static or dynamic mount drive (EFS or FSx) to a kubeflow pipeline.

Hi @sublimotion
EFS doesn't support dynamic provision. I think one good example is we can create a VolumeOp to dynamically create a FSx and then create a training job using that PVC. After that, delete the volume.
Do you want to make this contribution?

@Jeffwan I think there is more people interested in EFS. We can use EFS to mount to a notebook and also mount it to a pipeline. I will try to come up with an example.

Thanks. My point is if we have different categories. We could consider to add tests in jupyter chapter, or pipeline chapter. If you want to have different uses cases on EFS, let's put them in those areas

@Jeffwan Do you have any suggestions on how to organize these examples? Should we create another section or folder called 'AWS'? I believe there is another issue that talks about re-organizing all the different examples.

@sublimotion Different AWS services land in different sections. aws doesn't sound consistency with existing areas. Check current structure and feel free to propose new sections or fill into exisiting ones

The chicago taxi TFX example using KF pipeline is working in AWS with EFS, just by creating the my-pvc using the efs storageclass, and putting the example data there. I'll prepare a PR and link it here when ready.

@theofpa Hi, did you ever make that PR? I am currently building a kfp with efs.


Chefspec matchers have disappeared between version 4.0.0 and 4.0.1

Cookbook version
4.0.1+
Chef-client version
chef 12.22.1
Platform Details
Ubuntu 16.04
Scenario:
my Chefspec tests are failing because the install_sudo and remove_sudo matchers have been removed in version 4.0.1.
Steps to Reproduce:
any cookbook depending on this cookbook that uses install_sudo chefspec matchers will have failing tests
Expected Result:
successful chefspec tests :)
Actual Result:
failing chefspec tests

Unless I'm wrong, I believe ChefSpec 7.1+  have automatic matchers now, see: https://github.com/chefspec/chefspec#automatic-matchers
Which version are you using? Might be worth upgrading ChefSpec in general 📆

Aha, apparently i haven't been keeping up with recent changes :) We're still testing against ChefDK 1.6.x (which has chefspec 6.2.0) in our CI so that probably explains. Thanks!

It looks like in the shuffle I missed documenting that the matchers were removed. It's in the changelog now, but for anyone seeing this the solution is to upgrade to a newer release of ChefDK. Not only will you get a much more functional ChefSpec you'll get newer releases of a lot of tools.