[manila-csi-plugin] Added runtime config with export location filter for NFS

What this PR does / why we need it:
The main point of this PR is to give users the ability to filter out export location for NFS shares. Here is the use-case: https://github.com/kubernetes/cloud-provider-openstack/issues/1136
This is achieved by having a runtime JSON config file (represented as a ConfigMap in k8s) where users may enter a single IP address in CIDR format. This address is then used to choose an export location that matches this address. No match results in NodePublishVolume returning error with code INVALID_ARGUMENT.
Which issue this PR fixes(if applicable):
fixes https://github.com/kubernetes/cloud-provider-openstack/issues/1136
Special notes for reviewers:

Release note:

manila-csi-plugin: added runtime configuration file, --runtime-config-file cmd argument
manila-csi-plugin: added the ability to filter out export locations for NFS shares using a CIDR address configurable via runtime config

@lingxiankong @ramineni openlab/cloud-provider-openstack-acceptance-test-csi-manila is failing with:
2020-08-16 17:45:30.802724 | ubuntu-bionic | + make -C /home/zuul/src/k8s.io/kubernetes 'WHAT=cmd/kubectl  cmd/kube-apiserver cmd/kube-controller-manager cmd/cloud-controller-manager cmd/kubelet cmd/kube-proxy cmd/kube-scheduler'
2020-08-16 17:45:30.830734 | ubuntu-bionic | make: Entering directory '/home/zuul/src/k8s.io/kubernetes'
2020-08-16 17:45:30.835329 | ubuntu-bionic | make[1]: Entering directory '/home/zuul/src/k8s.io/kubernetes'
2020-08-16 17:45:32.033176 | ubuntu-bionic |
2020-08-16 17:45:32.033322 | ubuntu-bionic | Detected go version: go version go1.14.4 linux/amd64.
2020-08-16 17:45:32.033392 | ubuntu-bionic | Kubernetes requires go1.15.0 or greater.
2020-08-16 17:45:32.033449 | ubuntu-bionic | Please install go1.15.0 or later.
2020-08-16 17:45:32.033474 | ubuntu-bionic |
2020-08-16 17:45:32.037854 | ubuntu-bionic | !!! [0816 17:45:32] Call tree:
2020-08-16 17:45:32.040160 | ubuntu-bionic | !!! [0816 17:45:32]  1: hack/run-in-gopath.sh:31 kube::golang::setup_env(...)
2020-08-16 17:45:32.083304 | ubuntu-bionic |
2020-08-16 17:45:32.083420 | ubuntu-bionic | Detected go version: go version go1.14.4 linux/amd64.
2020-08-16 17:45:32.083492 | ubuntu-bionic | Kubernetes requires go1.15.0 or greater.
2020-08-16 17:45:32.083555 | ubuntu-bionic | Please install go1.15.0 or later.
2020-08-16 17:45:32.083584 | ubuntu-bionic |
2020-08-16 17:45:32.088323 | ubuntu-bionic | !!! [0816 17:45:32] Call tree:
2020-08-16 17:45:32.091092 | ubuntu-bionic | !!! [0816 17:45:32]  1: /home/zuul/src/k8s.io/kubernetes/hack/lib/golang.sh:779 kube::golang::setup_env(...)
2020-08-16 17:45:32.093804 | ubuntu-bionic | !!! [0816 17:45:32]  2: hack/make-rules/build.sh:27 kube::golang::build_binaries(...)
2020-08-16 17:45:32.099008 | ubuntu-bionic | !!! [0816 17:45:32] Call tree:
2020-08-16 17:45:32.101893 | ubuntu-bionic | !!! [0816 17:45:32]  1: hack/make-rules/build.sh:27 kube::golang::build_binaries(...)
2020-08-16 17:45:32.102586 | ubuntu-bionic | Makefile.generated_files:195: recipe for target '_output/bin/prerelease-lifecycle-gen' failed
2020-08-16 17:45:32.102688 | ubuntu-bionic | make[1]: *** [_output/bin/prerelease-lifecycle-gen] Error 1
2020-08-16 17:45:32.102766 | ubuntu-bionic | make[1]: Leaving directory '/home/zuul/src/k8s.io/kubernetes'
2020-08-16 17:45:32.102833 | ubuntu-bionic | Makefile:546: recipe for target 'generated_files' failed
2020-08-16 17:45:32.102882 | ubuntu-bionic | make: *** [generated_files] Error 2
2020-08-16 17:45:32.102949 | ubuntu-bionic | make: Leaving directory '/home/zuul/src/k8s.io/kubernetes'
2020-08-16 17:45:32.326631 | ubuntu-bionic | ERROR
2020-08-16 17:45:32.327003 | ubuntu-bionic | {
2020-08-16 17:45:32.327105 | ubuntu-bionic |   "delta": "0:01:07.519006",
2020-08-16 17:45:32.327192 | ubuntu-bionic |   "end": "2020-08-16 17:45:32.104671",
2020-08-16 17:45:32.327273 | ubuntu-bionic |   "msg": "non-zero return code",
2020-08-16 17:45:32.327369 | ubuntu-bionic |   "rc": 2,
2020-08-16 17:45:32.327490 | ubuntu-bionic |   "start": "2020-08-16 17:44:24.585665"
2020-08-16 17:45:32.327577 | ubuntu-bionic | }

@gman0 updated go version to 1.15.0 , https://github.com/theopenlab/openlab-zuul-jobs/pull/969/files , this should solve this issue

Thanks a bunch, @ramineni !

/test cloud-provider-openstack-acceptance-test-csi-manila

/test cloud-provider-openstack-acceptance-test-csi-manila

/test cloud-provider-openstack-acceptance-test-csi-manila

/test cloud-provider-openstack-acceptance-test-csi-manila

PTAL @JPRbrs @tsmetana @gouthampacha @tombarron

Sigh, @tombarron - could you lgtm this one?
/assign @tombarron

/lgtm

/assign @ramineni

/lgtm
/approve

/approve


Layout editor enhancements

Video showing both the preview feature plus the layout style selection (fluid vs page) in the page creation popup => https://issues.jboss.org/secure/attachment/12428445/layouteditor-AF911and912.mp4
@ederign @kkufova Mind to review please?
P.S: @pefernan You might get interested in the preview feature. Take also a look please if so.

Can you please move this PR for https://github.com/kiegroup/appformer ?

Moved to https://github.com/kiegroup/appformer/pull/101


Loot Tracker doesnt show every drop at Grotesque Guardians

Not every drop is recorded in the tracker.

Ran into this as well, 5 kills, only three of them recorded

Could you try recording a couple kills where it doesn't work so we can see what makes it not work? It's almost certainly a certain spot

I can do that tomorrow after work

@MagicfTail I'm running it right now but so far 7/7 on getting the loot to show up.  I noticed there was an update when I loaded it up today, is it possible that it fixed it, or if not, what's the spot you're looking for so I can test that spot.

Kill one I didn't get loot even though I didn't do quit what I wanted.  Kill two was a perfect repro of what I thought the issue was but it tracked the loot.  There are a few more kills some with and without loot.

I suspect the same behavior would be present when killing regular gargoyles too then.

Doesn't happen on regular gargoyles, and I don't have a task to test it on the bosses right now so I'm not much help.

Running on an up-to-date master with #4868 merged, not all loot is being tracked. Seems not fixed.

Could you check and make sure it's the correct npc id, 7888, when he dies?

He starts at 7888, during his death animation he turns into 7889. Tried making a gif with his ID. Loot also fails to be added here.


opt: dynamic set stack size of emu

Solve PR 355 more elegantly.

Thanks for the work. This PR looks good. However, I double check the progress of Verilator and find that it would be better to use the predicted stack size provided by Verilator. I'm proposing my ideas to Verilator in https://github.com/verilator/verilator/issues/4799.
If they accept to add the predictedStackSize method, we don't need this argument anymore. Otherwise, we can have this argument added.

OK, that will be a better way to solve this.

Our patch for Verilator has been accepted. Next release version of Verilator (v5.026) will come with a dynamic stack resizer using setrlimit. We've updated difftest to avoid explicit setrlimit in our own main() function in https://github.com/OpenXiangShan/difftest/pull/367. This PR is closed. Thanks all for this work.


Change the TYPO3 AdditionalConfiguration.php template to extend the MAIL array - fixes #1042

The Problem/Issue/Bug:
Problem described in #1042
How this PR Solves The Problem:
The code in the template file is changed so that the array is extended instead of overwritten so that we have access to the full $GLOBALS['TYPO3_CONF_VARS']['MAIL'] array in TYPO3.
Manual Testing Instructions:
Testing this automatically was not possible as far as I know.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Dominik Hahn seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

There should be no negative impact as all other smtp settings are empty by default and they are not touched by this change.
There is only one MAIL setting that's not empty which is transport_sendmail_command and it is ignored because the transport is already set to smtp.

@dmnkhhn please do add the email you used for this commit to github per https://github.com/drud/ddev/pull/1043#issuecomment-412189451 - Thanks!

Done, thanks for the reminder!


CRITICAL:Exception, in CWorld::SaveTry()

Hi
do anyone knows, how to fix this bug or bad settings of sphere ?
background save settings - disabled
always when i tried to save sphere come out that debug and i cant do save anymore.
https://i.gyazo.com/96ef319bc2bc98be602ee4f426f30938.png

This appears to be a screenshot from the other branch exe, right?
Il lun 13 ago 2018, 17:13 AtillaG1<EMAIL_ADDRESS>ha scritto:

Hi
do anyone knows, how to fix this bug or bad settings of sphere ?
background save settings - disabled
always when i tried to save sphere come out that debug and i cant do save
anymore.
https://i.gyazo.com/96ef319bc2bc98be602ee4f426f30938.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Sphereserver/Source-experimental/issues/118, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AOWhJMFC9Wm8ywAQ7WkVtjnvazpr5Ea3ks5uQZd9gaJpZM4V6srU
.

im not sure what do you mean.

Im using SphereSvr-Win32.zip (v. Latest) - Aug 12th, 2018, 7:15 am
so there is another one ? did not know that.
Then im sorry.
Thank you.


Build failed when using both prometheus/node_exporter and prometheus/client_golang

I have a simple program:
package main

import (
	"github.com/prometheus/client_golang/prometheus/push"
	"github.com/prometheus/node_exporter/collector"
)

func main() {
	nc, err := collector.NewNodeCollector()
	if err != nil {
		panic(err)
	}
	pusher := push.New("http://localhost/metrics", "test")
	for _, c := range nc.Collectors {
		pusher.Collector(c)
	}
}

Run it with go module enabled:
$ GO111MODULE=on go1.12.5 run main.go
go: finding github.com/prometheus/node_exporter/collector latest
go: finding github.com/prometheus/client_golang/prometheus/push latest
go: finding github.com/prometheus/client_golang/prometheus latest
# github.com/prometheus/node_exporter/collector
/home/cuonglm/go/pkg/mod/github.com/prometheus/node_exporter@v0.18.1/collector/buddyinfo.go:58:24: c.fs.NewBuddyInfo undefined (type procfs.FS has no field or method NewBuddyInfo)
/home/cuonglm/go/pkg/mod/github.com/prometheus/node_exporter@v0.18.1/collector/cpufreq_linux.go:83:23: c.fs.NewSystemCpufreq undefined (type sysfs.FS has no field or method NewSystemCpufreq)
/home/cuonglm/go/pkg/mod/github.com/prometheus/node_exporter@v0.18.1/collector/ipvs_linux.go:109:24: c.fs.NewIPVSStats undefined (type procfs.FS has no field or method NewIPVSStats)
/home/cuonglm/go/pkg/mod/github.com/prometheus/node_exporter@v0.18.1/collector/ipvs_linux.go:124:27: c.fs.NewIPVSBackendStatus undefined (type procfs.FS has no field or method NewIPVSBackendStatus)
/home/cuonglm/go/pkg/mod/github.com/prometheus/node_exporter@v0.18.1/collector/netclass_linux.go:172:23: c.fs.NewNetClass undefined (type sysfs.FS has no field or method NewNetClass)

The problem is prometheus/node_exporter and prometheus/client_golang requires 2 version of procfs, which are conflicts with each other.
The graph shows the version<EMAIL_ADDRESS><EMAIL_ADDRESS>was chosen. The commit https://github.com/prometheus/procfs/commit/65bdadfa96aecebf4dcf888da995a29eab4fc964 (requires by node_exporter) is behind the commit https://github.com/prometheus/procfs/commit/833678b5bb319f2d20a475cb165c6cc59c2cc77c (v0.0.2).
In any case, I think the main problem is from procfs itself, as some public APIs were removed in commit https://github.com/prometheus/procfs/commit/985b82318ecc7741179e9c11a99095cd1f6965c9
The better idea is intoducing new public APIs and mark the old one as deprecated.

I was also caught out by this, whilst trying to update Debian's packaging for prometheus-node-exporter. Version 0.18.0 seems to require a pre-0.0.1 git snapshot of procfs, whilst version 0.18.1 requires exactly version 0.0.1 of procfs. Anything later than that (0.0.2+) breaks the build due to the removal of these top-level functions:
src/github.com/prometheus/node_exporter/collector/buddyinfo.go:58:24: c.fs.NewBuddyInfo undefined (type procfs.FS has no field or method NewBuddyInfo) src/github.com/prometheus/node_exporter/collector/cpufreq_linux.go:83:23: c.fs.NewSystemCpufreq undefined (type sysfs.FS has no field or method NewSystemCpufreq) src/github.com/prometheus/node_exporter/collector/ipvs_linux.go:109:24: c.fs.NewIPVSStats undefined (type procfs.FS has no field or method NewIPVSStats) src/github.com/prometheus/node_exporter/collector/ipvs_linux.go:124:27: c.fs.NewIPVSBackendStatus undefined (type procfs.FS has no field or method NewIPVSBackendStatus) src/github.com/prometheus/node_exporter/collector/netclass_linux.go:172:23: c.fs.NewNetClass undefined (type sysfs.FS has no field or method NewNetClass)

cc @pgier @discordianfish

@dswarbrick I had to bump the procfs slightly in node_exporter 0.18.1 to fix a parsing bug.

@SuperQ Thanks for the info. Will node_exporter be releasing a new version that builds against procfs 0.0.2, or will procfs re-add some top level function wrappers like they did in #170 ?

We'll probably update the node_exporter master to work with the latest procfs version sometime soon. A new release depends on what features we're working.

@SuperQ Update node_exporter should work, but it's likely that there're user out there which rely on removed methods.
The best way to fix this is in procfs, but re-adding removed methods and mark them as deprecated. If not, the changelog should be updated to insist the in-compatible change.


Document possible credential race condition

Closes #1065
cc @kyleknap @stealthycoin @jamesls

Current coverage is 97.62% (diff: 100%)

Merging #1072 into develop will not change coverage

@@            develop      #1072   diff @@
==========================================
  Files            44         44
  Lines          6936       6936
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           6771       6771
  Misses          165        165
  Partials          0          0

Powered by Codecov. Last update e079c0d...5545c84


$signInWithPopup 'auth/popup-closed-by-user' error callback takes too many time

Version info
Angular: 1.5.8
Firebase: 3.x.x
AngularFire: 2.x.x
Steps to reproduce
Calling $signInWithPopup method opens a dialog to do oauth login. Then, close this dialog
Expected behavior
When user closes oauth popup (google in this case), the error 'auth/popup-closed-by-user'  must fire inmmediately.
Actual behavior
When user closes oauth popup (google in this case), the error 'auth/popup-closed-by-user' takes too many time to fire.

Thanks for the report. We've gotten a few of these reports before. This is a problem with the underlying Firebase SDK, not AngularFire. As such, I'm going to close this issue in this repo. We don't have an official Firebase bug tracker, but I have logged an internal bug report and assigned it to our auth team. Hopefully they can look into it soon.
For our reference, how long does it normally take for you get the auth/popup-closed-by-user error?

I'm told that this was actually fixed in the latest 3.3.0 release of the JavaScript SDK. This is noted in the release notes for that release. Please upgrade to the latest version and try again.
Also, in the future, it's important to share the exact version you are using, instead of a range, version since 3.x.x includes a wide range of releases, each with different features and bug fixes.

No,, still having the same issue:
"@angular/cli": "^1.7.4",
"angularfire2": "^5.0.0-rc.6.0",
"firebase": "^4.12.1",

different frontend lib and  "firebase": "^9.1.2" and still there is no way to detect "close by user" action


Add Azure Event Hubs subplugin

Docs: https://learn.microsoft.com/en-GB/azure/event-hubs/
It will likely resemble the PutEvents task in EventBridge for pushing events from a flow: https://kestra.io/plugins/plugin-aws/tasks/eventbridge/io.kestra.plugin.aws.eventbridge.putevents as I believe they don't support polling for messages in a queue/bus? if they do, we could add a Trigger as well: azure.eventHubs.Trigger

done https://kestra.io/plugins/plugin-azure#eventhubs


Missing config when inserting action step between existing start and end steps

Describe the Bug
There are missing fields for middle "action" step, when it's inserted between two already specified start and end steps.
The config fields are visible when inserting prior to specifying the end step.
Steps to Reproduce the Bug or Issue

specify start step
specify end step
specify middle action step - see there are no config fields present there

Screenshots or Videos

Platform

OS: [Linux]
Browser: [Chrome,Firefox]
Version: [latest]

probably duplicate of #1370 working on fix.


Latest TinyGo fails to run our http test

The tinygo-wasi-http test component recompiled with TinyGo 0.32 fails with:
trace:
    0: 0x3574a - runtime.abort
                    at /opt/homebrew/Cellar/tinygo/0.32.0/src/runtime/runtime_tinygowasm.go:70:6              - runtime.runtimePanicAt
                    at /opt/homebrew/Cellar/tinygo/0.32.0/src/runtime/panic.go:87:7
    1: 0x783a - runtime.nilPanic
                    at /opt/homebrew/Cellar/tinygo/0.32.0/src/runtime/panic.go:150:16
    2: 0x80b0c - main!(*net/http.Client).Post
    3: 0x7b1df - tinygo_wasi_example1
                    at /opt/homebrew/Cellar/tinygo/0.32.0/src/net/http/client.go:461:27
    4: 0x9482e - __wasm_export_tinygo_wasi_example1
                    at /Users/vigoo/projects/ziverge/golem-services/test-components/tinygo-wasi-http/tinygo_wasi/tinygo_wasi.c:5228:3

Caused by:
    wasm trap: wasm `unreachable` instruction executed

Try to investigate and fix it. If it is not possible, the (new) Go Language Guide must specify the older TinyGo version to use.

The test case is guest_languages::tinygo_http_client, which is not temporarily ignored

The current custom net/http implementation does not use the RoundTripper, so our custom implementation is not called at all.
See: https://github.com/tinygo-org/net/blob/a79417481d37e21f29d257c28fecc503df9703e0/http/client.go#L159
There is an already merged PR that fixes this in the net repo: https://github.com/tinygo-org/net/pull/32
And it was also bumped in the main tinygo repo https://github.com/tinygo-org/tinygo/pull/4351
So when there will be a new release, it should work with that.


DROOLS-951: add missing @Test annotation

Added missing @Test annotation. When run locally, the test passed.

+1


Repeating Starting Controller controller-runtime log entries when the provider is starting

What happened?

We observed the following with @mmclane & @adamhouse with<EMAIL_ADDRESS>When the provider pod is starting, logs from the controller-runtime have duplicated controller names:
...
1.6789882042717745e+09	INFO	Starting workers	{"controller": "managed/xray.aws.upbound.io/v1beta1, kind=samplingrule", "controllerGroup": "xray.aws.upbound.io", "controllerKind": "SamplingRule", "worker count": 10}
1.6789882042718117e+09	INFO	Starting workers	{"controller": "managed/xray.aws.upbound.io/v1beta1, kind=samplingrule", "controllerGroup": "xray.aws.upbound.io", "controllerKind": "SamplingRule", "worker count": 10}
1.6789882042718272e+09	INFO	Starting workers	{"controller": "managed/xray.aws.upbound.io/v1beta1, kind=samplingrule", "controllerGroup": "xray.aws.upbound.io", "controllerKind": "SamplingRule", "worker count": 10}
1.678988204271838e+09	INFO	Starting workers	{"controller": "managed/xray.aws.upbound.io/v1beta1, kind=samplingrule", "controllerGroup": "xray.aws.upbound.io", "controllerKind": "SamplingRule", "worker count": 10}
1.678988204271892e+09	INFO	Starting workers	{"controller": "managed/xray.aws.upbound.io/v1beta1, kind=samplingrule", "controllerGroup": "xray.aws.upbound.io", "controllerKind": "SamplingRule", "worker count": 10}
1.678988204271897e+09	INFO	Starting workers	{"controller": "managed/xray.aws.upbound.io/v1beta1, kind=samplingrule", "controllerGroup": "xray.aws.upbound.io", "controllerKind": "SamplingRule", "worker count": 10}
1.678988204271952e+09	INFO	Starting workers	{"controller": "managed/xray.aws.upbound.io/v1beta1, kind=samplingrule", "controllerGroup": "xray.aws.upbound.io", "controllerKind": "SamplingRule", "worker count": 10}
1.6789882042720401e+09	INFO	Starting workers	{"controller": "managed/xray.aws.upbound.io/v1beta1, kind=samplingrule", "controllerGroup": "xray.aws.upbound.io", "controllerKind": "SamplingRule", "worker count": 10}
1.678988204272071e+09	INFO	Starting workers	{"controller": "managed/xray.aws.upbound.io/v1beta1, kind=samplingrule", "controllerGroup": "xray.aws.upbound.io", "controllerKind": "SamplingRule", "worker count": 10}
1.6789882042720428e+09	INFO	Starting workers	{"controller": "managed/xray.aws.upbound.io/v1beta1, kind=samplingrule", "controllerGroup": "xray.aws.upbound.io", "controllerKind": "SamplingRule", "worker count": 10}
...

Looks like we are naming the controllers wrong. I suspect of a loop variable here.
How can we reproduce it?

Observe<EMAIL_ADDRESS>logs.
What environment did it happen in?

Provider Version: v0.31.0

Bumping the sigs.k8s.io/controller-runtime version to v0.14.6 seems to have resolved this issue. Running the provider locally, I got the following logs during the startup:
...
2023-03-30T11:22:38+03:00       INFO    Starting workers        {"controller": "managed/s3control.aws.upbound.io/v1beta1, kind=objectlambdaaccesspointpolicy", "controllerGroup": "s3control.aws.upbound.io", "controllerKind": "ObjectLambdaAccessPointPolicy", "worker count": 10}
2023-03-30T11:22:38+03:00       INFO    Starting workers        {"controller": "managed/iot.aws.upbound.io/v1beta1, kind=thing", "controllerGroup": "iot.aws.upbound.io", "controllerKind": "Thing", "worker count": 10}
2023-03-30T11:22:38+03:00       INFO    Starting workers        {"controller": "managed/sagemaker.aws.upbound.io/v1beta1, kind=image", "controllerGroup": "sagemaker.aws.upbound.io", "controllerKind": "Image", "worker count": 10}
2023-03-30T11:22:38+03:00       INFO    Starting workers        {"controller": "managed/kendra.aws.upbound.io/v1beta1, kind=index", "controllerGroup": "kendra.aws.upbound.io", "controllerKind": "Index", "worker count": 10}
2023-03-30T11:22:38+03:00       INFO    Starting workers        {"controller": "managed/amp.aws.upbound.io/v1beta1, kind=rulegroupnamespace", "controllerGroup": "amp.aws.upbound.io", "controllerKind": "RuleGroupNamespace", "worker count": 10}
2023-03-30T11:22:38+03:00       INFO    Starting workers        {"controller": "managed/sns.aws.upbound.io/v1beta1, kind=platformapplication", "controllerGroup": "sns.aws.upbound.io", "controllerKind": "PlatformApplication", "worker count": 10}

We will also observe the situation with the validation images we are planning to build for the releases.

Built the following upbound/platform-ref-aws package from the release-0.32 branch and provisioned the cluster & postgres claims. Again, the controller names were distinct as expected:
...
2023-03-30T22:41:42Z    INFO    Starting workers        {"controller": "managed/ec2.aws.upbound.io/v1beta1, kind=vpcipamscope", "controllerGroup": "ec2.aws.upbound.io", "controllerKind": "VPCIpamScope", "worker count": 10}
2023-03-30T22:41:42Z    INFO    Starting workers        {"controller": "managed/ecr.aws.upbound.io/v1beta1, kind=lifecyclepolicy", "controllerGroup": "ecr.aws.upbound.io", "controllerKind": "LifecyclePolicy", "worker count": 10}
2023-03-30T22:41:42Z    INFO    Starting workers        {"controller": "managed/cloudwatchevents.aws.upbound.io/v1beta1, kind=target", "controllerGroup": "cloudwatchevents.aws.upbound.io", "controllerKind": "Target", "worker count": 10}
2023-03-30T22:41:42Z    INFO    Starting workers        {"controller": "managed/ecs.aws.upbound.io/v1beta1, kind=clustercapacityproviders", "controllerGroup": "ecs.aws.upbound.io", "controllerKind": "ClusterCapacityProviders", "worker count": 10}
2023-03-30T22:41:42Z    INFO    Starting workers        {"controller": "managed/cognitoidp.aws.upbound.io/v1beta1, kind=userpool", "controllerGroup": "cognitoidp.aws.upbound.io", "controllerKind": "UserPool", "worker count": 10}
2023-03-30T22:41:42Z    INFO    Starting workers        {"controller": "managed/configservice.aws.upbound.io/v1beta1, kind=configrule", "controllerGroup": "configservice.aws.upbound.io", "controllerKind": "ConfigRule", "worker count": 10}
2023-03-30T22:41:42Z    INFO    Starting workers        {"controller": "managed/cognitoidp.aws.upbound.io/v1beta1, kind=riskconfiguration", "controllerGroup": "cognitoidp.aws.upbound.io", "controllerKind": "RiskConfiguration", "worker count": 10}
2023-03-30T22:41:42Z    INFO    Starting workers        {"controller": "managed/securityhub.aws.upbound.io/v1beta1, kind=inviteaccepter", "controllerGroup": "securityhub.aws.upbound.io", "controllerKind": "InviteAccepter", "worker count": 10}
2023-03-30T22:41:42Z    INFO    Starting workers        {"controller": "managed/ec2.aws.upbound.io/v1beta1, kind=transitgatewayconnectpeer", "controllerGroup": "ec2.aws.upbound.io", "controllerKind": "TransitGatewayConnectPeer", "worker count": 10}
2023-03-30T22:41:42Z    INFO    Starting workers        {"controller": "managed/kafka.aws.upbound.io/v1beta1, kind=cluster", "controllerGroup": "kafka.aws.upbound.io", "controllerKind": "Cluster", "worker count": 10}
2023-03-30T22:41:42Z    INFO    Starting workers        {"controller": "managed/ds.aws.upbound.io/v1beta1, kind=directory", "controllerGroup": "ds.aws.upbound.io", "controllerKind": "Directory", "worker count": 10}
2023-03-30T22:41:42Z    INFO    Starting workers        {"controller": "managed/kinesisvideo.aws.upbound.io/v1beta1, kind=stream", "controllerGroup": "kinesisvideo.aws.upbound.io", "controllerKind": "Stream", "worker count": 10}
2023-03-30T22:41:42Z    INFO    Starting workers        {"controller": "managed/ec2.aws.upbound.io/v1beta1, kind=customergateway", "controllerGroup": "ec2.aws.upbound.io", "controllerKind": "CustomerGateway", "worker count": 10}
2023-03-30T22:41:42Z    INFO    Starting workers        {"controller": "managed/macie2.aws.upbound.io/v1beta1, kind=classificationjob", "controllerGroup": "macie2.aws.upbound.io", "controllerKind": "ClassificationJob", "worker count": 10}
2023-03-30T22:41:42Z    INFO    Starting workers        {"controller": "managed/appmesh.aws.upbound.io/v1beta1, kind=virtualrouter", "controllerGroup": "appmesh.aws.upbound.io", "controllerKind": "VirtualRouter", "worker count": 10}
...

We can close this issue for now and keep monitoring the situation.


Dart Analyzer Error reported by IntelliJ

Analyzer Feedback from IntelliJ
Version information

IDEA IU-182.3911.36
2.0.0
IU-182.3911.36, JRE 1.8.0_152-release-1248-b8x64 JetBrains s.r.o, OS Mac OS X(x86_64) v10.13.6 unknown, screens 1440x900, 1920x1080, 1920x1080  Retina

Exception
Please append the contents of:
file:///private/var/folders/t0/7zp2_4jn6z50rsrhzsh_yztj80zyr9/T/report.txt
Dart analysis server, SDK version 2.0.0, server version 1.20.3, FATAL error: Failed to handle request: {id: 408, method: edit.getAssists, params: {file: localhost:51928/packages/angular_components/app_component.template.dart, offset: 7533, length: 0}, clientRequestTime:<PHONE_NUMBER>119}
Invalid argument(s): Only absolute paths are supported: localhost:51928/packages/angular_components/app_component.template.dart
#0      AnalysisDriver._throwIfNotAbsolutePath (package:analyzer/src/dart/analysis/driver.dart:1755:7)
#1      AnalysisDriver.getResult (package:analyzer/src/dart/analysis/driver.dart:771:5)
#2      AnalysisServer.getAnalysisResult (package:analysis_server/src/analysis_server.dart:622:10)
#3      EditDomainHandler.getAssists (package:analysis_server/src/edit/edit_domain.dart:175:42)
<asynchronous suspension>
#4      EditDomainHandler.handleRequest (package:analysis_server/src/edit/edit_domain.dart:342:9)
#5      AnalysisServer.handleRequest.<anonymous closure>.<anonymous closure> (package:analysis_server/src/analysis_server.dart:751:45)
#6      _PerformanceTagImpl.makeCurrentWhile (package:analyzer/src/generated/utilities_general.dart:210:15)
#7      AnalysisServer.handleRequest.<anonymous closure> (package:analysis_server/src/analysis_server.dart:747:50)
#8      _rootRun (dart:async/zone.dart:1124:13)
#9      _CustomZone.run (dart:async/zone.dart:1021:19)
#10     _runZoned (dart:async/zone.dart:1516:10)

Invalid argument(s): Only absolute paths are supported: localhost:51928/packages/angular_components/app_component.template.dart
#3      EditDomainHandler.getAssists

I think we can throw with Only absolute paths are supported on something like set analysis roots, but for the other calls, we may want to be more lenient about how we fail for non-absolute paths. In this case, we may want to return an error to the client for the actual call, instead of reporting an analysis server crash.

I agree: all of the requests should return an error response if the inputs are invalid; they should never crash.
But all of the file paths for all of the requests are expected to be absolute paths, and I don't think we want to change that.


What is the state of implementing video downloads?

I used yt-dlp with cookies but the videos downloaded are limited to 1 minute in duration, and when using credentials (username and password) I always get an error with the login process.
So, I hope this project will advance in the feature of implementing video downloading.

No, I'm sorry...


Conditionally cleanup Garnet files when disposing GarnetServer object.

Fixes #135
Default behavior is to not cleanup data directories.
However, it is possible to create GarnetServer object with an option to cleanup folders on dispose.

Hi,  in my case, this cleanup occurred with all option using default . I debugged the process, and traced behavior to "LocalStorageNamedDeviceFactory.cs". In "Delete" method, fileInfo.directoryName was found to be "",  and then the basePath ("dir") would be cleaned.
When the start of garnet failed, all the files in the directory are missing, including the config file and others.
//LocalStorageNamedDeviceFactory.cs

public void Delete(FileDescriptor fileInfo)
{
    long startTime = DateTimeOffset.UtcNow.Ticks;
    if (fileInfo.fileName != null)
    {
        //codes not executed in my case...
    }
    else
    {
        var dir = new DirectoryInfo(Path.Combine(baseName, fileInfo.directoryName)); //fileInfo.directoryName=="", dir==baseName
        while (true)
        {
            try
            {
                if (dir.Exists) dir.Delete(true);
                break;
            }
            catch { }
            Thread.Yield();
            // Retry until timeout
            if (DateTimeOffset.UtcNow.Ticks - startTime > TimeSpan.FromSeconds(5).Ticks) break;
        }
    }
}


Number of views and likes for the article

A small API service for storing views and likes for articles.
Could use Cloudflare Workers or Netlify Functions + Fauna Database

Added in v1.1.6


Could not connect to display, Status 127 - Fedora

When trying to run waynergy, no matter what commands I use I get the final error "Could not connect to display"
Server: Windows 11, running Barrier latest (also tried with InputLeap and Synergy)
Client: Fedora Kinoite (40.20240704)
wl-clipboard is not installed
waynergy -n -c <IP_ADDRESS> --loglevel 5 -b kde
0.000000325: [DEBUG] Section log not found in INI
0.000020487: [INFO] Log initialized at level 5
0.000028455: [INFO] waynergy version 0.0.17
0.000051585: [DEBUG] Property syn_raw_key_codes not found in INI
0.000066856: [DEBUG] requiring wait() on SIGCHLD
0.000517727: [WARN] Child died: PID 45085, Status 127
0.000550960: [DEBUG] not requiring wait() on SIGCHLD
0.000562432: [INFO] Clipboard sync disabled by command line
0.000577493: [DEBUG] Section wayland not found in INI
0.000628705: [ERROR] Could not connect to display

I have tried running it directly, running it with sudo, different launch commands including -E, the error is the exact same no matter what commands are used (other than the warning about wl-clipboard if not using -n).

master now logs the error code for a wl_display_connect() failure, so building and running that will give a better idea.  Usually there's something else printed, but perhaps Fedora are building libwayland weirdly.

Thank you so much! I can confirm that the latest master provides FAR more info into what's actually going on. Unfortunately I don't have logs anymore, but what I did do was reinstalled python-uinput (unsure if this was of any use) and performed chmod on /dev/uinput.
I was certain I have done this previously, but maybe I missed that? Though the extended debug information provided me with a clear indicator that uinput simply wasn't working correctly. I now run the command without the -b kde switch as it provides me with an error "input backend kde not supported"
Thank you so much! And I sincerely apologize for the user-error here.


Example code gives error.

I'm using Python 3.12 on Windows 10 Pro.
This Python code example from your page at Pypi.org https://pypi.org/project/txt-from-pdf/
from txtfrompdf import extract_txt_from_pdf

pdf_path = "file.pdf"
text = extract_pdf(pdf_path) # Error here
print(text)

gives me the error
-> text = extract_pdf(pdf_path)
(Pdb) n
NameError: name 'extract_pdf' is not defined

This also gave me an error:
text = txtfrompdf.extract_pdf(pdf_path)

Error was:
-> text = txtfrompdf.extract_pdf(pdf_path)
(Pdb) n
NameError: name 'txtfrompdf' is not defined

Hi,
I see. The documentation has a type, you should be able to use it this way:
from txtfrompdf import extract_txt_from_pdf

text = extract_txt_from_pdf(pdf_path)

I fixed the readme. Closing this issue.


Issues #733: Fix memory leak in ExpandedSQL

Fixes: #733

@gwenn Awaiting test result of branch fix-733
@mattn Please Review

Coverage remained the same at 50.381% when pulling b67a21c39e405140cc5c896e0ff20bc607fc306f on fix-733 into 2ea5857c0eb3179b078ce5fb881ace11eb28f285 on master.


extended job APIs

Why are these changes needed?
In the Job APIs for the apiserver added job submitter parameters. This fixes the problem of Python/Ray version mismatch in the case of existing Ray cluster
Related issue number

Checks

[ x] I've made sure the tests are passing.
Testing Strategy

[ x] Unit tests
[ ] Manual tests
[ ] This PR is not tested :(

It requires rebasing

@z103cb, @astefanutti, pls take a look
cc: @kevin85421

the func ValidateCreateJobRequest(request *api.CreateRayJobRequest) error { function should be enhanced to validate the required fields in the ray submitter is present in the request. I would go as far as making the object required if a cluster selector is used.

Implemented check in util/job.go

Add documentation on how to use it in Readme

@astefanutti all ready for you


Top Up Balance w/ MoonPay

Summary
Today, users can add funds to their wallet by opening their exchange account, and go through the process of buying tokens and transferring them.
With this feature, users are enabled to use Moonpay to fund their existing account - repeating the process that before was available only at the account creation.
Intended Outcome
As a user, I want to add funds to my wallet balance without leaving NEAR wallet user experience.
The success of this feature will be measured against the number of transactions performed within the application.
How will it work?
Similarly to #5, users have a way to add funds to their balance, by using their credit card and the Moonpay buy process.
As a nice-to-have, we may enable this functionality via deep-linking, such that third-party applications can call this feature from their user interface.

@vgrichina would love any feedback you might have for this. I believe this direction is more scalable than just adding a "buy with moonpay" button on the dashboard, since it allows us to point to exchanges as well as future integrations with other purchase methods (eg I know Metamask uses https://pay.sendwyre.com/ which I'm also curious if that is an option for us). I'd like to also leverage this pattern for the funding flow cc @Patrick1904.

@vgrichina @corwinharrell @jimmy3dita
Since https://github.com/near/near-wallet/issues/1538 is somewhat blocked by https://github.com/near/near-wallet/pull/1556 - any objections to prioritize this issue before https://github.com/near/near-wallet/issues/1538? I could pick this up next.

@vgrichina @corwinharrell @jimmy3dita
Since #1538 is somewhat blocked by #1556 - any objections to prioritize this issue before #1538? I could pick this up next.

Not opposed at all but will wait on others to weigh in.


Tests failing blocking install, offline tests attempt to touch real user credentials during install!

As part of the unbitrot hackathon I came across the following. Im not sure you necessarily want to touch a users real credentials file from ~.aws/credentials during install. But either way, trying to touch it blocks the install if the AWS credentials file doesn't exist for the user.

$ zef install Amazon::DynamoDB
===> Searching for: Amazon::DynamoDB
===> Updated cpan mirror: https://raw.githubusercontent.com/ugexe/Perl6-ecosystems/master/cpan1.json
===> Updated p6c mirror: http://ecosystem-api.p6c.org/projects1.json
===> Searching for missing dependencies: AWS::Session, WebService::AWS::Auth::V4, String::CRC32
===> Searching for missing dependencies: Config::INI, DateTime::Format::W3CDTF
===> Testing: Config::INI
===> Testing [OK] for Config::INI
===> Testing: DateTime::Format::W3CDTF
===> Testing [OK] for DateTime::Format::W3CDTF
===> Testing: AWS::Session:ver<0.4>:authgithub:zostay
===> Testing [OK] for AWS::Session:ver<0.4>:authgithub:zostay
===> Testing: WebService::AWS::Auth::V4:ver<0.0.3>:auth
===> Testing [OK] for WebService::AWS::Auth::V4:ver<0.0.3>:auth
===> Testing: String::CRC32:ver<0.05>:auth
===> Testing [OK] for String::CRC32:ver<0.05>:auth
===> Testing: Amazon::DynamoDB:ver<0.1>:authgithub:zostay
Failed to open file /Users/matt/.aws/credentials: No such file or directory
in sub parse_file at /Users/matt/.zef/store/perl6-Config-INI.git/4e5494798dd0f8e73045cdb36d91302ba666410e/lib/Config/INI.pm (Config::INI) line 41
in method get-credentials at /Users/matt/.zef/store/AWS-Session-0.4.tar.gz/AWS-Session-0.4/lib/AWS/Session.pm6 (AWS::Session) line 243
in method load at /Users/matt/.zef/store/AWS-Session-0.4.tar.gz/AWS-Session-0.4/lib/AWS/Credentials.pm6 (AWS::Credentials) line 212
in method load at /Users/matt/.zef/store/AWS-Session-0.4.tar.gz/AWS-Session-0.4/lib/AWS/Credentials.pm6 (AWS::Credentials) line 248
in sub load-credentials at /Users/matt/.zef/store/AWS-Session-0.4.tar.gz/AWS-Session-0.4/lib/AWS/Credentials.pm6 (AWS::Credentials) line 265
in method credentials at /Users/matt/.zef/store/Amazon-DynamoDB-0.1.tar.gz/Amazon-DynamoDB-0.1/lib/Amazon/DynamoDB.pm6 (Amazon::DynamoDB) line 756
in method access-key at /Users/matt/.zef/store/Amazon-DynamoDB-0.1.tar.gz/Amazon-DynamoDB-0.1/lib/Amazon/DynamoDB.pm6 (Amazon::DynamoDB) line 760
in method make-ddb-request at /Users/matt/.zef/store/Amazon-DynamoDB-0.1.tar.gz/Amazon-DynamoDB-0.1/lib/Amazon/DynamoDB.pm6 (Amazon::DynamoDB) line 785
in method BatchGetItem at /Users/matt/.zef/store/Amazon-DynamoDB-0.1.tar.gz/Amazon-DynamoDB-0.1/lib/Amazon/DynamoDB.pm6 (Amazon::DynamoDB) line 847
in block  at t/aws-examples-offline.t line 57
===> Testing [FAIL]: Amazon::DynamoDB:ver<0.1>:authgithub:zostay
Aborting due to test failure: Amazon::DynamoDB:ver<0.1>:authgithub:zostay (use --force-test to override)

Eek. That's not good.

Okay, so a quick investigation shows a couple problems:

There are 3 tests. Of these, 2 will connect to a DDB instance using available credentials, but these must be activated with env, so they don't actually use credentials present unless told to. The third test does not connect to AWS and this is the one that is dying. It loads the default AWS::Credentials object as it would in normal operation. However, it shouldn't.
I am pretty sure this reveals a bug in AWS-Session, though. As I've always got a credentials file on the machines I've tested this on, I've never ran across it. I filed zostay/AWS-Session#2 to look into this problem.

For this project, I will update the code in Test::Amazon::DynamoDB to make sure the default DDB connector creator also replaces AWS::Credentials with custom code that only concerns itself with the available environment.


Add CustomDashboard editing/preview surfaces

This is a draft PR for adding the editing and preview surfaces for Custom Dashboards.
Closes:
#4178
#4179

@ericpgreen2 @mindspank @AdityaHegde
Here's a PR based on our discussion this morning. Absolutely still in progress, but wanted to to get some initial feedback.
A few notes:
I think the dashboard definition is "narrow" enough that we could easily display this as a two column layout rather than only offering full screen views. I found flipping back and forth to be a little annoying.
I've updated the DashboardComponent definition to have x, y, width and height values instead of simply columns and rows. Naming is absolutely up for discussion, but the general idea is that these are to be provided in grid units.
@AdityaHegde Let me know if I've changed things on the proto side correctly. I really only changed resources.proto and the dashboard parser and then ran make proto.generate
Not sure if it matters, but the int64 type for these seems like overkill. Feels like we could make them uint8, but that type isn't recognized in resources.proto

I think the dashboard definition is "narrow" enough that we could easily display this as a two column layout rather than only offering full screen views. I found flipping back and forth to be a little annoying.

I'm all for showing this in a two-column layout. These dashboards should be responsive to small screen widths anyways (a current deficiency of the Metrics Explorer, which makes a two-column layout for it less practical at the moment).
In a responsive dev environment, maybe it makes sense to label the screen size somewhere in the Dashboard Preview, with a note/tooltip that says your dashboard layout will be different on different screen sizes.

I've updated the DashboardComponent definition to have x, y, width and height values instead of simply columns and rows. Naming is absolutely up for discussion, but the general idea is that these are to be provided in grid units.
I also removed the idea of setting the number of rows at the grid level and added a gap property. I didn't really see how setting rows would be used in a way that felt intuitive. I've just set this up to ingest the column count and create a grid that features square cells with a row count equal to whatever the max calculated row would be based on the component definitions.

On first pass, these ergonomics feel good to me! @mindspank, I know you've thought more about the Dashboard YAML, what do you think?
Playing around with it, I'm thinking a toggle to show gridlines on the Dashboard Preview could be really helpful.

Hey @briangregoryholmes . Yes, the proto files are generated correctly. We could use uint32 instead of int64.

Added grid line toggle.

Checked in on the latest progress. At a macro level, the editing experience feels pretty good!
The main item that concerns me is responsiveness. Currently, the grid has the same number of columns for all screen sizes, which leads to dashboard miniaturization on smaller screens. If we were to take any of the in-the-wild custom dashboards that @mindspank shared in Slack, they wouldn't look very good on mobile and you'd have to zoom in to read them. We should outline the options and trade-offs for different approaches.

In general responsiveness does not work well for dashboards for a few reasons

order is lost when grid is collapsing
certain visualization types and information density does not work on smaller screen sizes
you have different tasks you perform on mobile VS desktop

If we'd want to support mobile then I would suggest you'd had to define a separate grid with different content either as a mode in the dashboard or a different dashboard with a mobile type

There are also two levels of responsiveness, the grid and the visualization itself. For custom charts we don't have a lot of control but for Rill authored visualizations the different components of a chart should have a priority order and then we would layout (or not layout) depending on available size.
Such as axis and value labels, label collision and entire axises.
See https://picassojs.studio/#stacked-bar-chart for example


Presentation 1 - What is databricks? - Diagrams and explanation of databricks features -- Rifat

I'm closing this issue because I believe I saw Rifat's video on Google


pre-commit: PR112011

Link: https://github.com/llvm/llvm-project/pull/112011
Requested by: @dtcxzyw

/add-label reviewed
/close


[Question] Advice on source code structure

Hi Bill,
We're developing a Condo Management system. Each condominium can have multiple blocks, each block can have multiple floors, and each floor can have multiple apartments (we call them 'units'). So, we have 4 business domains: 'condominium', 'block', 'floor', and 'unit'. How can we structure them? Could we treat them as if they are on the same level, or 'block', 'floor', and 'unit' are sub-packages inside the 'condominium' package? Thanks.

I appreciate that, but I'm afraid that I'm unable to join the video call (sorry). Could you share your idea here?

I haven't scheduled one yet, but if you are not interested in a call that's fine. I suggest you gain access to the service 4.1 video that we offer on the ArdanLabs website. It will answer all your questions.
If you are interested in scheduling a video call send me an email at<EMAIL_ADDRESS>This is too complicated to write up.


Provide config override of servicename for OCI ATP Service Integration with Wallet Management

Currently, the OCI ATP Service Integration with Wallet Management feature automatically uses the [servicename]"_high" service and overriding this serviceAlias must be done programmatically. Would be convenient to be able to provide that in config instead.
Environment Details

Helidon Version: 2.4.0
Helidon MP
JDK version: GraalVM 20.2.0
OS:
Docker version (if applicable): ghcr.io/graalvm/graalvm-ce:21.3.0

Problem Description
Steps to reproduce
Use https://github.com/oracle/helidon/tree/master/examples/integrations/oci/atp-cdi and attempt to connect to  [servicename]"_tp" or any service that is not "_high" . Services provided by ADB are high, low, medium, tp, and tpurgent.

Hi, @paulparkinson; you may be in luck.  If I'm reading you right, that's in 2.4.0 today.

We have removed adding "_high" by default to provided service name. Now, User provides the full service name instead.


Wrong folder used for active NodeJS instance

Issue:
I'm trying to circumvent the "exit status 1: Access is denied" problem by selecting a folder within my user folder as location for the active NodeJS instance in the installer.
Nevertheless  "nvm use..." still fails with the known error and Process Monitor tells me that it tries to write to "C:\Program Files\nodejs" despite me having explicitly set another folder.
Expected Behavior:
Use the folder set in the installation window for what it is supposed to be used.
Desktop:
Windows 10, latest updates

I forgot to close the PS session between changing the path. Everything is allright.


fix: NPE in Listener4SpeedAssistExtend

Closes #121

Codecov Report

Merging #179 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
+ Coverage   83.16%   83.19%   +0.03%
==========================================
  Files          64       64
  Lines        3783     3785       +2
  Branches      614      615       +1
==========================================
+ Hits         3146     3149       +3
+ Misses        369      368       -1
  Partials      268      268

Impacted Files
Coverage Δ

...re/listener/assist/Listener4SpeedAssistExtend.java
64.1% <100%> (+4.64%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b9c1da...44e3d7b. Read the comment docs.

When can I release the version?

@kslr this week.

@kslr My apologies, this version is released today. refs here.


API does not support special characters

Describe the bug
Player names like these return status code 400:

環地平弧#3519
ПАСУЛЯ#1474
Немо#21207
#2211 (This name doesn't even work in GitHub apparently, but it works in the game)
Némesis#21732
FunkMëMommy#2867
Chérie#11430
byuǃ#2931

To Reproduce
Click on one of the links
Expected behavior
Player profile

Hello !
Thank you for the report. Unfortunately, the API is using official Blizzard pages for data, and it seems the users can't be found on these. You can try yourself here : https://overwatch.blizzard.com/en_US/search/
I tried all the names you shared, and FunkMëMommy#2867 is actually the only one working for me 😅
Let me know if I can help you on anything else 👍

Does the players/{player_id} endpoints do a search to find the profile, then get the information from the profile? I thought it somehow fetched it directly based on the battletag alone

Not directly, but it uses it to gather data about the last time a profile was updated, and the player namecard (which is not on the profile page).
I also noticed that if a profile can't be found in Blizzard search, it's not available if we try to use the url directly.
Are the profiles you're trying to use public ? If that's the case, I'm afraid I can't do anything to help on this issue 😕

I don't know if they're public, I just know that I get that error back so I assume the API doesn't know yet

If profiles can't be found on Blizzard pages, the API won't be able to resolve them 😕
It can happen for private profiles, or sometimes for some public profiles for some reason. It's not related to special char issue, I already had this feedback a few months ago.

Oh, weird! Thanks anyway :)


Add support for generalized substructure searching

The overall idea is to have something in C++ (and thus in Python and Java and the cartridge and etc) which supports the idea of generalized substructure searching that I described in this blog post: https://greglandrum.github.io/rdkit-blog/posts/2021-08-03-generalized-substructure-search.html
This PR creates a new datastructure, the ExtendedQueryMol which handles the complexity of storing and serializing the queries and using them to do substructure searches. There's also a simple createExtendedQueryMol() which does the enumeration and tautomery query expansion described in the blog post.
Simple useage demo from Python showing a molecule with a link node and tautomerism possible:
In [1]: from rdkit import Chem

In [3]: qry = Chem.MolFromSmiles('COCc1n[nH]c(F)c1 |LN:1:1.3|')

In [5]: from rdkit.Chem import rdGeneralizedSubstruct

In [6]: xqm = rdGeneralizedSubstruct.CreateExtendedQueryMol(qry)

In [8]: rdGeneralizedSubstruct.MolGetSubstructMatch(Chem.MolFromSmiles('COOCc1[nH]nc(F)c1'),xqm)
Out[8]: (0, 1, 2, 3, 4, 5, 9, 6, 7, 8)

Some notes:

The support for serialization and JSON (or at least some text-based representation) are here because they are needed to be able to use ExtendedQueryMols in the cartridge.
The JSON serialization, which uses a base64 encoded form of the underlying objects, is not so nice. But we're stuck with that as long as we don't have a lossless JSON<->mol<->JSON conversion. It's not the end of the world.
This uses std::variant, which is actually quite nice.

@rachelnwalker this is the substructure search PR that we talked about. It would be great if you could do a review!

@rachelnwalker @ricrogz As discussed, I've updated this to allow toggling which operations are applied as well as adding support for adjustQueryProperties.


[IMPROVEMENT] Make bullet points consistent in README.

Added missing periods.
Used same word class.
repo --> repository.

Thank you!


new textobj: @assignment.full

Deleting an entire assignment is a common task and it would be nice to have a text object for that
New text object @assignment.full will capture the entire assignment.
[ and ] denote what area the textobject will capture, if our cursor is at *
E.g. in javascript
[con*st foo = "foo";]

[const bar = (bar) => "b*ar";]

[const baz = function (str, num) {
  console.log(str)
  const obj = {
    str,
    num,
  }
retu*rn obj
};]

const baz = function (str, num) {
  console.log(str)
  [const obj = {
    str,*
    num,
  };]
return obj
};

Are there precedents in other editors?
How would the query look? How many languages would this cover?

(Please no "pie in the sky" requests; we can only work within the limitations of tree-sitter queries.)

Are there precedents in other editors?

How would the query look? How many languages would this cover?

(Please no "pie in the sky" requests; we can only work within the limitations of tree-sitter queries.)

Not sure about the first one, but i was able to create a basic implementation for javascript:

(lexical_declaration
  (variable_declarator
    name: (_) @assignment.lhs
    value: (_) @assignment.rhs)) @assignment.full

(variable_declaration
  (variable_declarator
    name: (_) @assignment.lhs
    value: (_) @assignment.rhs)) @assignment.full

And what is the difference to @assignment.outer?

And what is the difference to @assignment.outer (or just @assignment)?

Assuming our cursor is at /**/ and denote the range with [[]]
@assignment.outer:
const/**/[[foo = "foo"]];

const [[bar = (bar) => "b/**/ar"]];

const [[baz = function (str, num) {
  console.log(str);
  /**/
  const obj = {
    str,
    num,
  };

  return obj;
}]];

the new @assignment.full i made:
[[const/**/foo = "foo";]]

[[const bar = (bar) => "b/**/ar";]]

const baz = function (str, num) {
  console.log(str);
  /**/
  [[const obj = {
    str,
    num,
  };]]

  return obj;
};

Main difference is that it captures the keyword const as well as the semicolon at the end

So the difference is not the assignment; you want to capture a full statement.

So the difference is not the assignment; you want to capture a full statement.

There is a difference, for example if we wanted to capture an entire statement with this configuration:
/**/function innerFunction() {
  if (true) {
    return "Inner return";
  }

  return null;
}

const result = outerFunction();

@assignment.full would capture the const result ="outerFunction();, but if we were to make a query for @statement (I am assuming this is how it would work, since @statement isn't even available for JS) then it would capture the function declaration and not the assignment
Allowing us to do lookahead operations

You want const result = outerFunction();, don't you? That is a full statement.

If you want we can call it

You want const result = outerFunction();, don't you? That is a full statement.

By the way I agree that it's a full statement, if that isn't clear
But it's also a subset of a statement, more specific Statement than the general Statement
That's basically the main idea, would be useful to be able to operate specifically on VariableDeclarationStatement and not just Statement

Then don't use @statement there. My point is that @assignment.full is wrong for what you describe; if a new textobject were added to capture it, it should be a version of @statement.
Otherwise this sounds way too niche to add and maintain here; you should just write your own personal query for it.

Then don't use @statement there. My point is that @assignment.full is wrong for what you describe; if a new textobject were added to capture it, it should be a version of @statement.
Otherwise this sounds way too niche to add and maintain here; you should just write your own personal query for it.

Okay, we could call it something else
But it being niche? I don't know about that, The task of having to move/delete an entire assignment statement quite common, for me at least it's a lot more common than queries like @conditional.inner or @conditional.outer

Also I doubt this would be more niche than @regex.inner or @regex.outer, which are included in this repo

To me, I feel like modifying assignment.output to capture as you described would be an option.

To me, I feel like modifying assignment.output to capture as you described would be an option.

Ok, I think that's a good idea.
What about making @assignment.inner behave like @assignment.outer currently does, and making @assignment.outer behave like I described?
I am suggesting this since at the moment @assignment.inner captures the same region as @assignment.lhs or @assignment.rhs
But either approaches are fine and I can send a PR for ecma to modify @assignment.outer

Well, we'd have to modify them everywhere to stay consistent...

Well, we'd have to modify them everywhere to stay consistent...

I'm happy to do that

Well, we'd have to modify them everywhere to stay consistent...

Update: I have added the modifications for all languages that I know and that I have installed on my computer. If other people are familiar with the other feel free to submit contribution.

I already commented on the PR, but I object the idea of changing assignment.inner. I just think assignment.outer can be changed

Update: https://github.com/nvim-treesitter/nvim-treesitter-textobjects/pull/682#issuecomment-2335620132


Shiny Proxy inside Kubernetes demo profile?

Hi Guys I am attempting to run Shiny Proxy inside kubernetes.
Basic Setup is Shiny-proxy inside kubernetes with a configmap mapping application.yaml file in.
proxy:
  title: Redacted Shiny Powered By Kube
  logo-url: http://www.opesadsfnanalytics.eu/sites/www.openanalytics.eu/themes/oa/logo.png
  landing-page: /
  heartbeat-rate: 10000
  heartbeat-timeout: 60000
  port: 8080
  authentication: ldap
  admin-groups: Redacted
  ldap:
    url: redacted
    user-search-filter: (sAMAccountName={0})
    group-search-base: OU=Redacted Groups
    # user-search-base:
    group-search-filter: (member={0})
    manager-dn: redacted

    manager-password: redacted
  container-backend: kubernetes
  kubernetes:
    namespace: poc-shiny
    image-pull-policy: Always
    internal-networking: true
    url: https://redacted:6443
  specs:
  - id: 01_hello
    display-name: Hello Application
    description: Application which demonstrates the basics of a Shiny app
    container-cmd: ["R", "-e", "shinyproxy::run_01_hello()"]
    container-image: openanalytics/shinyproxy-demo
    access-groups: ["IT Team"]
  - id: 06_tabsets
    container-cmd: ["R", "-e", "shinyproxy::run_06_tabsets()"]
    container-image: openanalytics/shinyproxy-demo
    access-groups: ["IT Team"]
logging:
  level:
    org.springframework.security.ldap.authentication: DEBUG
    org.springframework.security.ldap.userdetails: DEBUG
  file:
    shinyproxy.log

```
The shiny proxy can create containers within the poc-shiny namespace However it looks like none of the other config is accepted or is overwritten by the default demo config.

debug points to the demo file still being loaded
```
=========|_|==============|___/=/_/_/_/
 :: Spring Boot ::        (v2.0.0.RELEASE)

2018-09-26 14:26:05.492  INFO 1 --- [           main] e.o.c.ContainerProxyApplication          : Starting ContainerProxyApplication v0.4.0 on shinyproxy-77d8968cb8-46kht with PID 1 (/opt/shinyproxy/shinyproxy.jar started by root in /opt/shinyproxy)
2018-09-26 14:26:05.492  INFO 1 --- [           main] e.o.c.ContainerProxyApplication          : The following profiles are active: demo
2018-09-26 14:26:05.588 DEBUG 1 --- [           main] o.s.boot.SpringApplication               : Loading source class eu.openanalytics.containerproxy.ContainerProxyApplication
2018-09-26 14:26:06.794 DEBUG 1 --- [           main] o.s.b.c.c.ConfigFileApplicationListener  : Loaded config file 'file:./application.yaml' (file:./application.yaml)
2018-09-26 14:26:06.796 DEBUG 1 --- [           main] o.s.b.c.c.ConfigFileApplicationListener  : Loaded config file 'jar:file:/opt/shinyproxy/shinyproxy.jar!/BOOT-INF/classes!/application-demo.yml' (classpath:/application-demo.yml) for profile demo
``

```
How do I stop the demo config being loaded?

Hi @HackyPenguin ,
Make sure the config file is named exactly application.yml, and is located in the working directory of the shinyproxy process.
If the file is not found, the demo profile will be activated.

@fmichielssen  hi It is and it loads my config just anything also found in Demo overwrites my config. it runs in a non default namespace with non default account access which is specified in my application.yml.
We can even see it load my application config above before it loads demo config.
Loaded config file 'file:./application.yaml' (file:./application.yaml)
2018-09-26 14:26:06.796 DEBUG 1 --- [           main] o.s.b.c.c.ConfigFileApplicationListener  : Loaded config file 'jar:file:/opt/shinyproxy/shinyproxy.jar!/BOOT-INF/classes!/application-demo.yml' (classpath:/application-demo.yml) for profile demo


How would you expect this to be formatted?

this is hand-tuned, yapf/pep8 don't really care about any of that (they pass-through, it seems):
def fetch(content, prefix):
    return {
        'parts': pipe(parse('$..layers').find(content), mapcat(lambda m: m.value),
                      filter(lambda v: v['exportOptions']['exportFormats']),
                      filter(lambda v: re.match(prefix, v['name'])),
                      map(lambda v: glom(v, {'key': 'name',
                                             'layout': ('frame', {'left': ('x', round),
                                                                  'top': ('y', round),
                                                                  'width': ('width', round),
                                                                  'height': ('height', round)}) })),
                      sorted(key=lambda p: p['key']),
                      list)
    }

with prettier
def fetch(content, prefix):
    return \
        {
            "parts":
                pipe(parse("$..layers").find(content), mapcat(lambda m: \
                        m.value), filter(lambda v: \
                        v["exportOptions"]["exportFormats"]), filter(lambda \
                        v \
                    : \
                        re.match(prefix, v["name"])), map(lambda v: \
                        glom(v, {
                            "key": "name",
                            "layout":
                                (
                                    "frame",
                                    {
                                        "left": ("x", round),
                                        "top": ("y", round),
                                        "width": ("width", round),
                                        "height": ("height", round)
                                    }
                                )
                        })), sorted(key=lambda p: p["key"]), list)
        }

I'd probably do this by hand, but my formatting can be a bit idiosyncratic.
def fetch(content, prefix):
    return {
        'parts':
            pipe(
                parse('$..layers').find(content),
                mapcat(lambda m: m.value),
                filter(lambda v: v['exportOptions']['exportFormats']),
                filter(lambda v: re.match(prefix, v['name'])),
                map(lambda v: glom(v, {
                    'key': 'name',
                    'layout': (
                        'frame',
                        {
                            'left': ('x', round),
                            'top': ('y', round),
                            'width': ('width', round),
                            'height': ('height', round)
                        }
                    )
                })),
                sorted(key=lambda p: p['key']),
                list
            )
    }

(I can try and write out the general rules I followed here, if this isn't too hard on the eyes.)

Looks much better! is this anything yapf/pep8/prettier could ever do?

FWIW, unrelated to this thread, I saw this project on HN this morning https://github.com/ambv/black seems to be exactly what I was looking for (an opinionated formatter), and also incidentally it formats code exactly like you did. hurray! :)


Show only one sidebar in product samples

This avoids validation errors because of duplicate amp-sidebars. Also
fixes the sidebar not showing in the product samples.
Fixes #545

@kul3r4 PTAL - and welcome back!

LGTM


Parse arguments without type hint

This PR infers types from Transaction parameters and Script parameters, so it is not needed anymore to specify the type (in most cases)
Also, this way it supports arrays, dictionaries, etc [UInt8]. It also fixes semicolons in strings issues.
As there is a bug in --args parsing with a comma, I added arguments like:
flow scripts execute <filename> [<argument> <argument> ...] [flags]
flow scripts execute script.cdc "Meow" "Woof"

Codecov Report

Merging #355 (3f64f0d) into master (60227db) will decrease coverage by 0.81%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #355      +/-   ##
==========================================
- Coverage   52.99%   52.18%   -0.82%
==========================================
  Files          36       36
  Lines        1802     1830      +28
==========================================
  Hits          955      955
- Misses        729      757      +28
  Partials      118      118

Flag
Coverage Δ

unittests
52.18% <0.00%> (-0.82%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/flowkit/arguments.go
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60227db...3f64f0d. Read the comment docs.

@sideninja
thanks for the quick review, I tried to fix all comments, also tried to add a test (not sure if it is good, I am more test noob than go noob)

@sideninja also can you assist with this lint error?

@sideninja also can you assist with this lint error?

Yes, I will help you, the only problem is that imports should be sorted by internal/external. No biggie.

Thank you for this contribution, it will greatly improve UX and it will be part of the next CLI release.


I am also not able to connect to wifi after installing new firmware, working great with 08.2

When you install 0.9.0 and setup WiFi then save it, when the ESP restarts it is still in AP mode
I can use in AP mode, but not in clientmode

new version 0.9.0  does not work correct. When I want to configure the program as a client. When  press the  key, it does not enter the available  wifi networks. If I enter the parameters manually, they does not save changes.

Please see https://github.com/esprfid/esp-rfid/issues/192#issuecomment-441244852


print better analytics results from xgb

finished! more of a pain than i expected it to be. turns out that XGBRegressor only returns the features that it found useful. we had to do some annoying stuff to get the index from their version of the feature name, and then use that index to match up against our actual feature names.
it works in the end, just not the trivial problem i was expecting.


Support the "types" compiler option in tsconfig.json.

[x] All compiled assets are included (atom packages are git tags and hence the built files need to be a part of the source control)
Definition in commandLineParser.ts:
https://github.com/Microsoft/TypeScript/blob/f19844fbe97656a9e1f743fb6fe4e9d706a83c0d/src/compiler/commandLineParser.ts#L349

Thanks! Released with 10.1.5 :rose:

Thank you very much for merging!


cannot update

view code

state code
RxList<Rx> chats = RxList(<Rx>[]);
update item

when i add item the view update right,but change item content, view cannot update

change state code to
List<Rx> chats = <Rx>[];
view can be updated. but get an Exception
════════ Exception caught by widgets library ═══════════════════════════════════════════════════════
The following message was thrown building Obx(dirty, state: _ObxState#bd032):
[Get] the improper use of a GetX has been detected.
You should only use GetX or Obx for the specific widget that will be updated.
If you are seeing this error, you probably did not insert any observable variables into GetX/Obx
or insert them outside the scope that GetX considers suitable for an update
(example: GetX => HeavyWidget => variableObservable).
If you need to update a parent widget and a child widget, wrap each one in an Obx/GetX.


in -Swift.h ,"Type name requires a specifier or qualifier"

hi guys ,i'm using RealmSwift 0.92
i have a class
class MediaSentenceWord: Object {
   let librarywords = List<LibraryWord>()
}

but in the -Swift.h file (to use in objc ) that generated by system,there is a error:
SWIFT_CLASS("_TtC12eTimeMachine17MediaSentenceWord")
@interface MediaSentenceWord : Object
@property (nonatomic, readonly) /* List<LibraryWord> */ librarywords;

error:Type name requires a specifier or qualifier
so what's the problem?

Hi @github2016a, I assume you managed to work around the issue since this ticket is now closed. Can you share more details about what happened and how you fixed it?

I got the same error here, also wondering how I can work around this..

According to this SO question http://stackoverflow.com/questions/29533420/generic-classes-in-frameworkname-swift-h-causes-type-name-requires-a-specifie
I managed to work around this by setting Build Settings -> Swift Compiler - Code Generation -> Intall Objective-C Compatibility Header to No

@mrackwitz this could be good to add in the troubleshooting guide you've been meaning to write :wink:

@jpsim
Hi,jpsim,just saw your comment.I solved this problem,by manually altered the -Swift.h file : I deleted the unnecessary classes generated by system,including Realm Object classes with generic.
the error Is happened because The -Swift.h used by objc do not support generic 。
so：
1，Build Settings -> Swift Compiler - Code Generation -> Intall Objective-C Compatibility Header : No
2，Build Settings -> Swift Compiler - Code Generation -> Objective-C Generated Interface Header Name : your edited -Swift.h file.

Has anyone found a workaround for this when you actually need to include the compatibility header? Marking private cleans up the error but doesn't do me much good when I need to access the property.

@billburgess if you need to access that property (only from Swift), you can write getter and setter functions for it:
class MediaSentenceWord: Object {
  private let librarywords = List<LibraryWord>()
  func getLibrarywords() -> List<LibraryWord> {
    return librarywords
  }
  func setLibrarywords(value: List<LibraryWord>) {
    librarywords = value
  }
}


[sw/silicon_creator] Update manifest fields

This change:

Removes extension_*, reserved*, usage_constraints, lockdown_info, image_version,
Adds a struct for key manager binding value (keymgr_binding_value_t), and
Adds image_major_version, image_minor_version, binding_value, and max_key_version fields.

@moidx I saw #5956 but the last time we met the final format that we came up with did not include usage_constraints. Please let me know if you would like me to keep it.

Is there any opentitan.org documentation that should be updated?

sw/device/silicon_creator/rom_exts/docs/manifest.md should be updated. I'll update that in a separate PR.

Hi @alphan, the usage constraint requirements described in #5956 will require defining new manifest fields. I am ok with removing the current usage_constraints field as part of this PR.

Hi @alphan, the usage constraint requirements described in #5956 will require defining new manifest fields. I am ok with removing the current usage_constraints field as part of this PR.

Sounds good, thanks @moidx!


RequestAdditionalHeadersAsync not copied to cloned ServiceClient

When RequestAdditionalHeadersAsync is used with ServiceClient, the cloned client doesn't have this property copied so if clone is used to make a call, the custom headers are not populated. Can this be checked?
Our client creation and clone logic:
public Task<Dictionary<string, string>> GetAdditionalHeadersAsync()
{
	var headers = new Dictionary<string, string>();
	headers.Add("User-Agent", "abc");
	return Task.FromResult(headers);
}

var connectionOption = new ConnectionOptions()
{
	AccessTokenProviderFunctionAsync = tokenManager.GetToken,
	AuthenticationType = AuthenticationType.ExternalTokenManagement,
	ServiceUri = new Uri(orgUrl),
	RequestAdditionalHeadersAsync = GetAdditionalHeadersAsync,
}
var rootClient = new ServiceClient(connectionOption);
var clone = rootClient.clone();

This fix will be included in the next drop of DVSC.


cmd/image-builder: log insights id

While each log record contains request_id already, insights platform also offers insights id which is also visible to the client. Example client response from the platform:
HTTP/2 500
server: openresty
content-type: application/json; charset=UTF-8
content-length: 91
x-rh-insights-request-id: e6d2fe3569a24801a25b7b34f5015210
x-content-type-options: nosniff
date: Mon, 18 Mar 2024 17:03:08 GMT
set-cookie: e15dd7c1deaec3a6b67fca153d520b0b=df2a3c785f654c64d6535cd525957cbb; path=/; HttpOnly; Secure; SameSite=None
x-rh-edge-request-id: e97847d
x-rh-edge-reference-id: 0.64f06e68.1710781388.e97847d
x-rh-edge-cache-status: NotCacheable from child
x-frame-options: SAMEORIGIN
strict-transport-security: max-age=31536000; includeSubDomains

This patch adds insights request id into every log line so one can easily copy and paste the returned id from the reponse HTTP header and immediately find all log entries.
The patch also makes LOG_LEVEL configurable through clowder, I want to discuss setting up DEBUG level on stage.

/retest

:shipit: It's in


Some errors occurred when run comand 'python setup.py develop'

Hi, Shaoshuai~
Thanks for your code~
When I wanna run  comand 'python setup.py develop', some errors occurred
Here attached the error
error.txt

What are your PyTorch version, GCC version and CUDA version?

I will close it now since there is no response. Feel free to re-open it.


Massive performance decrease on BLOB column at data page

Hi,
using SQLitely version 2.3, 10.07.2024 on default Kubuntu 24.04 as a Snap.
When there is a BLOB column in the table filled with small binary data ~80KiB per row ~15 rows and opening a new Data tab page, the app hangs about 25s. Interaction with the tab page is also nearly impossible.

Confirmed: data grids in Linux start lagging when columns have very long values.
Will figure out a workaround for the problem.
Thank you for reporting this.

Hi,
another and imo corresponding issue "around" the wxpython gui frontend.
Executing the same sqlscript on the SQL-page multiple times. Everytime it gets slower! More complex the script more faster the slowdown. Until the popup "Running SQL ..." never disappears. But changing the focus to another tabpage and back immediately show the result of the query, so the backend still performs.

Is this still related to very long values in query results, or regardless of those?

No, it depends on VISIBLE rows at least O(n²) and slightly on visible cols in the result grid.
For my system 10 rows and 10 iterations are enough -> 1 core 100%.
Closing the grid at stress i occasionally get unexpected error "ToolBar has been deleted".

Sorry, I did not quite understand. Are you saying that if a query returns 10 result rows, it starts lagging?
Could you maybe share the database and the query?

The lagging depends on the VISIBLE cells of the wxGrid control and how often you hit the "Execute Query" button in the SAME "SQL" window openend by the SQL button on the left. The content of the cells is irrelevant.
After > 50 clicks lagging (on my system)

After 17 clicks lagging (on my system)

After 3 clicks lagging (on my system)

In real world, using the program with normal queries, i have to change FOCUS to another SQL-Window to get the result and/or to make a new window for the next few query executions to not lag.
test.zip

Thank you very much, could reproduce this lag myself now, and found the problem.
I will try to get a new version released soon-ish; have been preparing for a release for some time already, but something always pops up.


Any way to change output HLS filename?

I would like to, if possible, ingest streams via RTMP and output them as HLS, but I want the name of the stream input to be different than the output, preferably defined by an array.
Is there any way to do this in real time? Preferably, I'd want a way to modify the list of stream keys and output directory values on the fly, without restarting nginx.

also: you have a .m3u8 file (nameless file) instead of a stream.m3u8 style file name if you only receive and publish only a hls stream. if you would have a hls_filename parameter things would be much simpler.


GeoIP databases in ingress-nginx without maxmind GeoIP2

Is it possible to use ModSecurity to block/accept traffic based on a database other than the MaxMind GeoIP GeoIP2 databases?
We are looking to use the ModSecurity module in Nginx ingresses using an annotation to allow or block traffic based on country codes to our e-commerce sites. This is the current annotation we using to test:
nginx.ingress.kubernetes.io/enable-modsecurity: 'true'
nginx.ingress.kubernetes.io/modsecurity-snippet: |
      SecRuleEngine On
      SecRequestBodyAccess On
      SecAuditEngine RelevantOnly
      SecAuditLogParts ABIFHJKZ
      SecAuditLog /var/log/modsec_audit.log
      SecGeoLookupDb /etc/nginx/geoip/GeoIP.dat
      SecRule REMOTE_ADDR "@geoLookup" "chain,id:22,log,drop,msg:'InvalidIP'"
      SecRule GEO:COUNTRY_CODE "@pm US"

I have not come across any documentation that shows the use of any other GeoIP type database and am wondering if it's even possible.
Azure Kubernetes version: 1.26.0
ingress-nginx helm version: 4.5.2

Hello @chlynott ,
The maxmind/GeoIP interface is what is directly supported in ModSecurity.
Using some other data source could be possible but would require some work on your part and would have some disadvantages (such as performance).
The current description above does not include a reason for not using GeoIP, but an earlier edit suggested concern about licensing costs. Note that there is a free version available -- it comes with a caveat about being less accurate but I've never heard significant concerns about the country code accuracy in that data source.


docs: mark v1.5.x as EOL

Which issue(s) this PR fixes:

Issue #
What this PR does / why we need it:
Special notes for your reviewer:
Additional documentation or context

cc @innobead


HERACLES-33: Historical & Lab Results range/unit revisions

Updated Laboratory Results questionnaire

@Hajany here is the look of the modified Laboratory Results form with min, max and ranges being added:

If the ranges are making it look too busy I can removed them.

Here is the new screenshot of the Lab results form with µL in units for white and red blood cells.

Screenshot of the Historical Lab results form:

Rebased on the latest dev, squashed commits for cleaner history.

@Hajany here is the look of the modified Laboratory Results form with min, max and ranges being added:
If the ranges are making it look too busy I can remove them.

Leave the ranges as descriptions, study team wants them to visible in the database as a reference

Hemoglobin A1c seems to be missing newlines in both forms. Is that intentional?

Hemoglobin A1c seems to be missing newlines in both forms. Is that intentional?

no. i missed that one. and red blood cells too.

2 more bugs:
Historical Lab results:

Lab results:

tested. all seems fine.

Squashed the commits that restored trailing spaces in markdown descriptions
Re-labeled all commits that did not have the issue name and summary in their commit message
Rebased on #1810
Updated the two questionnaires to display a custom message for values out of range, per specs

tested. looks good.
Historical LAB.pdf
LAB.pdf

@marta - one small thing, When I enabled the reinforcement for Cholesterol, the error message was displayed in 1 line.

When I enabled the reinforcement for Cholesterol, the error message was displayed in 1 line.
Also, we no longer have ability to show min/max values.

Updated branch CARDS-2580 to display the default message ("Please enter values between...") instead of the custom one when min/max are enforced. Rebased this branch for testing.

TESTED - looks good
One very minor thing that we can address later. If not enforcing the min/max, display the message bellow the input line.
I really like the new message being displayed under the input line, it would improve the look if we always do it.

Tested - minor changes:

Tested - minor changes:

Addressed

@sdumitriu Hold the merge until #1810 is approved and merged.


docs: update link to point new angular.dev site

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/analogjs/analog/blob/main/CONTRIBUTING.md#-commit-message-guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

Which package are you modifying?

[ ] vite-plugin-angular
[ ] vite-plugin-nitro
[ ] astro-angular
[ ] create-analog
[ ] router
[ ] platform
[ ] content
[ ] nx-plugin
[ ] trpc

What is the current behavior?
The angular link points to angular.io website

Closes #
What is the new behavior?
The angular link will point to angular.dev website
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information
[optional] What gif best describes this PR or how it makes you feel?

Thanks! @allcontributors add @sasidharansd for doc


Warning on auth_token

https://developer.mozilla.org/docs/Web/HTTP/Headers/Set-Cookie/SameSite

I think FF is just confused, see my original comments here: https://github.com/lbryio/lbry-desktop/issues/6845 (closing)


Add rigid CPD coregistration

Paper (1200+ citations in 10 years, I think this method is a winner): https://ieeexplore.ieee.org/stamp/stamp.jsp?tp=&arnumber=5432191
Python implementation: https://github.com/siavashk/pycpd

Looks promising!

Nice! I can try to get it running once #87  is fixed (since it changes the Coreg structure quite considerably).

Hey, we're up to 100 issues! That sounds so bad in any non-GitHub context haha but here I think it's a great achievement!


refactor: segmentation messaging

Refactoring segmentation messages and creators:

removed SegmentationMasksSAM message (switching to SegmentationMasks message instead)
removed create_sam_message creator (switching to create_segmentation_message creator instead)
adjusted the FastSAMParser and SegmentationParser to the changes

TODOs:

what about if two masks are present at same pixel? we loose this information with the current way!
should we really want to use -1 for background?
what to do with the _fastsam_show_masks visualizer?

The code-updates were tested on the following models:

FastSAM
MediaPipe Selfie Segmentation
DeepLab-V3-Plus
PP-LiteSeg
eWaSR

what about if two masks are present at same pixel? we loose this information with the current way!

You are correct but this decision was made because having one seg map for N instances is much more memory efficient than having N separate 2D masks. It is a trade-off between what is possible to have on device and what would be nice to have.

should we really want to use -1 for background?

What if we rather make mask in SegmentationMask an uint8 type (instead of int8) and then have background be 255 (max uint8 value). This is then also more optimized for on-device porting with DAI. IMO limitation of max 255 possible instances seems reasonable? Otherwise we can move to uint16 and have 65535 max instances which should for sure be enough.

what to do with the _fastsam_show_masks visualizer?

Is this needed? Quickly looking at it is seems like it is just looking at each pixel and merging masks into one by taking the class with highest index. Am I missing something? And there are some morphology operations before - are those part of how original repo preprocessed them and are they needed?

@klemen1999 1 and 2 are resolved. Regarding 3, is this maybe how we should approach joining masks into one by taking the classes with the highest index? Currently we merge them just by iterating through them and overwriting the existing info.

Regarding 3, is this maybe how we should approach joining masks into one by taking the classes with the highest index?

We can unify this yeah. Although logically the if have a pixel that can be class 0 or class 10 then we just have to pick one, there isn't really anything that tells us which one is more important. But I agree, we should always follow the same convetion and be clear about it in the documentation.

I've switched mask types to int16. cc @klemen1999 for re-review.

Codecov Report
Attention: Patch coverage is 52.77778% with 17 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@94a3043). Learn more about missing BASE report.

Files with missing lines
Patch %
Lines

depthai_nodes/ml/parsers/utils/fastsam.py
12.50%
7 Missing :warning:

depthai_nodes/ml/parsers/fastsam.py
20.00%
4 Missing :warning:

depthai_nodes/ml/parsers/segmentation.py
0.00%
4 Missing :warning:

depthai_nodes/ml/messages/segmentation.py
66.66%
2 Missing :warning:

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #127   +/-   ##
=======================================
  Coverage        ?   33.45%
=======================================
  Files           ?       68
  Lines           ?     3713
  Branches        ?        0
=======================================
  Hits            ?     1242
  Misses          ?     2471
  Partials        ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Double G.E. Notifications

Describe the bug
Since the latest update, whenever I get an update on my G.E. with a notification, I get my previous notification, then my new one.
To Reproduce
Steps to reproduce the behavior:

Sell multiple items on the ge
Get update notification
Get second update notification, but see first one again

Expected behavior
It should only show the current notification
Environment (please complete the following information):

OS: Windows 10
RuneLite version: 1.5.8
Launcher version: 1.6.0

Given that it has been over a year since the last post here, I am closing this issue. If you re-encounter this bug or have more information, please re-open this issue.


fail to compile on macos and linux with the same promotion

macos

The following environment variables are required:

WASI_SYSROOT: the path to your WASI sysroot installation (e.g. /opt/wasi-sysroot)
CLANG_ROOT: the path to the clang 8 root. On MacOS, after install llvm with Homebrew, the path is /usr/local/opt/llvm/lib/clang/8.0.0.

The documentation definitely needs an update.
Thanks for the heads up!

thanks!


Node failed to collect any peer during initialization

In our Gerald QA net, I found that some node failed to collect any peer in the initialization phase upon restart. In current implementation, the node would wait 60s to collect at least 4 peers, and then it would request their best tips to determine the current condition of the network. If a node fails to collect any peer during initialization, then it would falsely believe that the network has just been spawned and start a new chain off the genesis block. This could be one the reason that our QA net is forky when k is small and a lot of nodes are doing restart.

Will check the new QA net to see if it's still an issue

@emberian  has a pr that tweaks the parameters to help with this issue.  Need to check if this still happens and is actually a bug.

@emberian @ghost-not-in-the-shell  - we aren't still seeing this in the new networks are we?  Can this be closed?

I'm going to say yes!


Add info if nullable or blob to RuntimeSchemaDef

Add ListSubType to TypeDef definition
Bond data types that are of type BT_LIST will show under ListSubType if the idl was of nullable or blob type. Treat as list if its BT_LIST and UNKNOWN and disregard this field if it is not of type BT_LIST
Added support in c++/c# and respective tests

Closes #161

CI build failures are known and unrelated to this change: #176.


Move to cypress github action

We are right now using cypress as a bare-metal yarn dependency, moreover, for a multi-browser test like on edge, we first grep the edge and then run cypress.
Proposed solution

Cypress-io provides a Github-action to run cypress on multiple browsers, with headless mode, with option to records results too. I suggest we should utilize official cypress action instead of grabbing cypress with yarn and cypress cli commands. commands being used.
Alternatives considered

None
Additional context
Find the action over here https://github.com/cypress-io/github-action

It is not clear to me why we would want to do this move. I think there is value in having the CI call the ./refine script with the same arguments as what developers would use to run the tests locally, no? Concretely, what is the benefit of using the dedicated GitHub Action?

Having standard cypress action will:

save us from the complex ci logic of testing on different browsers, https://github.com/cypress-io/github-action#browser.
give us the ability to wait for the server without any script in the YAML config itself, https://github.com/cypress-io/github-action#start-server.
give us the ability for parallel jobs, https://github.com/cypress-io/github-action#parallel.
give better readability for CI configuration, also having the standard action for UI tests can open us to multiple configs options https://github.com/cypress-io/github-action#examples with the ability to custom build-ids and artifacts management.

For me, using action is just for easier maintainability and better readability and nothing else.

I am still not convinced - we already have parallel jobs at the moment. I would say developers should find it easier to reproduce failures locally if they can see directly from the build logs how to run the tests (with ./refine ui_test). But if @fgiroud agrees that it is better to use the GitHub Action, just go ahead!

I think configuring an Action, for the things that it is good at, is OK, as long as, as @wetneb mentions it stays aligned with or uses the same commands that the developers use locally. They may be composed in a slightly different manner by ./refine testand the CI action, but they shouldn't diverge and we don't want to maintain parallel setups.

Looks like we don't need this as of now. Closing the issue as we are already using the homemade script for ./refine ui_tests