video_player plugin can cause a crash on iPhone X running iOS 12 when disposing the video controller

When popping a page that contains a video on it, and disposing of the video controller in the dispose method could very often cause a crash on an iPhoneX running iOS 12. This happens because the DisplayLink has notified the flutter Texture registry that a frame is ready, and the flutter GPU thread then tries to get the pixel buffer after the FLTVideoPlayer object has been destructed.
The following code leads to the problem:
import 'package:flutter/material.dart';
import 'package:video_player/video_player.dart';

class VideoCrashPlayerPage extends StatefulWidget {
  @override
  _VideoCrashPlayerPageState createState() => _VideoCrashPlayerPageState();
}

class _VideoCrashPlayerPageState extends State<VideoCrashPlayerPage> {

  VideoPlayerController _videoPlayerController;

  @override
  void initState() {
    super.initState();

    _videoPlayerController = VideoPlayerController.asset("videos/video.mp4");
    _videoPlayerController.addListener(() {
      if (!_videoPlayerController.value.isPlaying) {
        Navigator.pop(context);
      }
    });
    _videoPlayerController.play();
    _videoPlayerController.initialize();
  }

  @override
  void dispose() {
    _videoPlayerController.dispose();

    super.dispose();
  }

  @override
  Widget build(BuildContext context) {

    return Material(
        elevation: 0,
        child: Column(
          children: <Widget>[
            Expanded(
                child: FittedBox(
                  fit: BoxFit.cover,
                  child: Container(
                      width: 818.0,
                      height: 864.0,
                      child: VideoPlayer(_videoPlayerController)
                  ),
                )
            )
          ],
        )
    );
  }
}

We cannot repro this on any other iPhone, nor an iPhone X running anything under iOS 12.

3P triage upgrading to critical given the nature of the report.

cc @cyanglaz @collinjackson @bparrishMines

@dannyvalentesonos I have tried running your code on an iPhone X with iOS 12.4 and couldn't reproduce the crash. Could you post your flutter doctor -v with the device connected?

@cyanglaz I do not have a physical device that I can get this info for you. I'll have to have someone else get that (whom doesn't have the flutter tools installed, so it may take some time).
I can reproduce this very reliably with the iPhone X 12.1 simulator.

@dannyvalentesonos shouldn't the super.dispose() method be called before disposing of the video player? Does this fix your crash issue?
@override
  void dispose() {
    super.dispose();
    _videoPlayerController.dispose();
  }

It doesn't fix the crash. The crash is in the GPU thread. The dispose call on the video player causes a platform channel call, which has to cross over to the main thread of the app. Therefore, the order of calls in this callstack doesn't make a difference.

One way I can think of is to add an 'onUnregistered' callback in the FlutterTexture. Then the video player plugin can dispose the player object inside the callback. This way we guarantee the player object is disposed after the texture is unregistered. @dannyvalentesonos I can wire up a quick prototype for you to try out?

yes, that is a good solution and something I was hoping could be added. I'd be happy to test.

https://github.com/flutter/engine/pull/12695
https://github.com/flutter/plugins/pull/2124
@dannyvalentesonos I tested with simulator and it doesn't crash anymore. I also made sure the player is disposed as well.
Do you want to apply these 2 patches and try the same with your app on your real devices?

@cyanglaz I just realized that we don't build the engine, and have never had the time to try and get an environment up and running that can do so. If you can confirm you no longer get the crash on the simulator, then I'd say that is good, as our temporary fix has been confirmed on the simulator too.

@dannyvalentesonos I landed the engine change and started working on the plugin side. Now for some reason I couldn't reproduce the crash anymore. Do you mind send me a full example app (with the navigation code as well) and let me try if I can reproduce it again?

@cyanglaz I got a notification of a question from you, but don't see it here. I've got a zipped up file of the sample app if you need it. Let me know.

@dannyvalentesonos The fix is ready in https://github.com/flutter/plugins/pull/2124. I am planning to get some reviews and land it by EOW.

@dannyvalentesonos I am still fighting ci to make the test pass. It might take a while, meanwhile if you need a hotfix, I suggest to patch the changes in https://github.com/flutter/plugins/pull/2124

Update: @cyanglaz had some higher-priority issues to deal with but is now back on this bug. Thanks for your patience.

This is fixed with https://github.com/flutter/plugins/pull/2124. With video_player version 0.10.3+1
I am going to close the issue for now. If any related issue is found, please feel free open another issue with details. If the same issue still occurs, please comment on this issue and I'm happy to reopen it right away!


Fix issue #3623

The line I'm removing is the cause of #3623. Once removed the BREAD creation seems to work as expected, however with it included it just causes exceptions to be thrown.

There was a reason for that to be there, but at the moment I don't see it.  My guess is it was removed from an unrelated change and this line was left even though it was no longer necessary.  We'll review this.


Option to start clicked cells in insert mode

I love this extension, thanks a ton!
When clicking in any given cell it places the cursor in Vim mode. Is there an option to change this default to insert mode?
Thanks in advance

I second this!
After reading the index.ts, it looks like MAYBE this can be done by commenting out line 64?
I'm not sure, I can't get it to run in jupyter lab because I don't know how to compile and load it lol.
Honestly, this makes copying and pasting from cells into sublime a real pain in the butt because I'm used to just clicking a cell, doing control+a, then control+c. But control+a doesn't work unless you're in insert mode, so I press: control a, control c, realize it didn't work, press i, press control+a, press control+c, and then I've copied a cell.
Line 64:

Hi both,
from a vim user perspective wishing for the default to be insert mode seems a bit odd to me. Why do you want to use the vim extension in the first place, then? But I obviously don't mean to oppose an option to manually change the default behaviour, as long as it is not changed generally for everybody.
Regarding specifically your copy-paste example, @SqrtRyan, since ctrl+a is not a vim keybinding, I feel like this is not a good motivation for changing the default behaviour of a vim extension. The vim way of "select all" is ggVG. After that you can copy/yank with y if you're staying within jupyter lab or use ctrl+c in your case to paste to sublime.

First of all, thank you for responding so quickly! :)
I really love using this VIM plugin for when I need to do tons of text editing in a single cell. That's why I love using this plugin...but I'm not a vim purist. I really only need to use the NAV mode when I'm doing heavy editing on a single cell, which for me is less than a quarter of the time I click a cell (most of the time, when I use the mouse, it's because I'm copying and pasting).
I know you can do ggVG, but not only is that more typing, but when I switch between that and the jupyter console (which doesn't have vim keybindings) it's confusing and it trips me up because I'm so used to control+a etc. It's really annoying to need so many keystrokes when I need to copy, say, 10 cells to sublime text. I don't use this plugin because I love vim keybindings...I use it because it saves me time lol. When the vim keybindings get more verbose than the originals (control+a vs ggVg, or (click) i control-v vs just (click)control-v), it makes me loose time.
(On the same note of verbosity, I also wish there was a way to exit the cell's edit mode with something other than :wq, perhaps hitting escape twice in NAV mode, as (at least on my computer) :wq often lags a little, taking up to half a second on my computer sometimes - just waiting for the : prompt to show up so I can type wq(enter) )
Thank you,
Ryan

Oh, on a sidenote - the author of Vintageous (the vim plugin for sublime) originally had a similar argument to making nav mode the default when switching tabs in Sublime, but eventually added an option earlier this year to make insert mode the default. I changed it right away because I really like starting in insert mode, and having VIM as an option I opt for rather than the default :)

Oh, another sidenote - I think one possibility that would make everybody happy might be to retain whatever mode you had before you clicked off the cell, and use that. For example, if I was in NAV mode before clicking out of the cell, the next time I click into a cell it should still be in NAV mode. Likewise, if I was in INSERT mode before clikcing out of a cell, the next cell I click into would also be in INSERT mode.
I believe this is the way Google Colab works when you set their keybindings to VIM mode, so it's not without precedent


Add imgui generated bindings

Extracted ImGui API (functions and enums) as a JSON structure
Created a Python script to generate bindings to generate the C++ bindings with Pybind11
Changed the way ImVec2 and ImVec4 are bound to use type_caster

There are still some functions listed as #TODO for the bindings, but this covers 95% of them.
Before I continue further, looking for feedback on this idea.

This is awesome!! Thanks as always for the contribution!
Sorry for not saying anything sooner, I went down a rabbit hole of checking out the pre-existing community ImGui bindings generators. Mainly (https://github.com/cimgui/cimgui/tree/docking_inter/generator/output and https://pthom.github.io/litgen/litgen_book/00_00_intro.html#). However, I don't think either makes sense out of the box for our needs. The cimgui C-interface is a bit too much work to bind to, and the litgen is a little to new for me to bet on it, plus its naming schemes are different which would break all existing code.
Anyway, onto this contribution. Generally I think it looks very reasonable. I certainly can't say I checked everything, but the functions and generator setups I spot-checked seem reasonable.
My high-level question is what work would be necessary to maintain these bindings in the future? (Especially in a hypothetical situation if you were to sadly stop contributing). Where doesimgui-bindings.json come from and how should we updated it as ImGui evolves?
Do you anticipate any backwards compatibility-breaks with these changes? (I think small breaks are fine for the imgui bindings, especially if we are moving to a standard that should not break in the future)

I looked into that one as well (along with the cimgui & litgen projects linked above). I'm a little wary of depending on an external project that could be abandoned, but that may be the lesser-evil compared to doing it ourselves.
Are you thinking to write a Python generator from their .json file? That could definitely work although it's hard to judge just how much work that would be.
I like that the cimgui project has a .json for ImPlot as well, it looks like this one is just ImGui proper. Unfortunately cimgui's json files seem to only hold their C-translated names, whereas Polyscope's existing bindings use the true ImGUI C++ names verbatim.
Very interested in your thoughts here :) I'd love to set up an automated solution but am wary about long-term maintainability.

Oh actually I lied, it looks like the cimgui .json does indeed have the original function name as a field. We'd have to do some translating, but I think it could work. I'm a bit more inclined to trust that project given that it has persisted for almost a decade, and seems to have the most uesrs.

It was really a trivial amount of work to generate the JSON file in this PR.  Although the frontier LLM models change over time, one way to help would be to include a prompt with instructions for how to generate the JSON file, or at least get most of the data out so that it could be added to the JSON file.
ImGui isn't changing that fast.  A prompt could easily take as input the JSON file and a query against ImGui.h that asks for an enums or functions not found in the JSON.  That would be a quick way to see what needs to be updated.

Any updated thoughts on this? I'm looking to release a new version soon and it would be a good time to update these bindings.
I spent a little while looking into manual bindings generators (you can see some experiments in this branch). Main takeaway is that will require a fair amount of work to massage C-style bindings back into Pythonic or even C++-style pybind11-friendly form. I'm sure it's possible, but it was goin to take more time than I have.
I'm still a little wary about maintainability/editability of this setup by folks other than you, but as you say ImGui is not rapidly-changing or anything :) I'd be okay with merging this setup (or something like it) if you think it's good-to-go.

By the way I'm also looking to include bindings ImPlot. I suppose it should be easy to generate bindings for that too with a similar setup?


Retry Based on Response Code

Currently looks like the retry mechanism will only engage if there's an actual error in sending the request, or if it's a 5xx response code.
It would be handy to be able to configure it so that it will retry on a non-2xx response code.  I can do a PR if the maintainers are interested.

A good idea. I just wanted to ask the package developer to do this.
Add a statusForRetry field of type [] int to the Client structure,
and replace the if response.StatusCode >= http.StatusInternalServerError condition with switch or checking whether http code is included in statusForRetry.

Bumping, any updates on this ?
There's an implementation similar to what @GarryGaller proposed here: https://github.com/gojek/heimdall/pull/105


Add support for hdfs file system shell commands

It would be great to support shell commands from https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-common/FileSystemShell.html
I believe this implementation should be straightforward for python.
Found an example where this is done for golang  https://github.com/colinmarc/hdfs

Created a milestone for this https://github.com/Kimahriman/hdfs-native/milestone/2 and will make individual issues to work of each command.


Tox tests CI guide

I spent few days figuring out how to report coverage using Tox, thanks to the help of customer support I figured out that at least branch name had to be passed otherwise payload would lie about being accepted (it would report as HEAD, has to be MASTER), it's better to pass all of this since code is trying to get it :)

Now that I'm checking out this repo's tox, it might actually not be as complex as I wrote it out to be. Could it be that only https://pypi.python.org/pypi/tox-travis is causing this?

Hey @iScrE4m,
We're relying on commit info directly from git during out own test reporter runs on CircleCI, which is why we don't have to pass through the other CI environment variables.
If you're using a CI provider that doesn't provide reliable info from git, like branch, then you would have to pass the appropriate environment variables in we'll use that value first before falling back on the git commands.
Which CI provider are you using? I'd be fine with pointing users to codeclimate_test_reporter/components/ci.py for an up-to-date mapping of CI data. What do you think?

Heym thanks for explaining a bit more! I'm still not exactly sure what Tox does to it etc. But I guess it doesn't matter I'm using Travis CI. Pointing to ci.py sounds fine to me - but I think it should be pointed to from readme/docs, noone should have to crawl and search the source for something he might need in some cases.

I'm still not exactly sure what Tox does to it etc.

I don't think Tox manipulates the working directory but it does seem to strip out environment variables, hence the passenv requirement. So it depends on how the git repository is cloned and reset initially within the CI environment.

but I think it should be pointed to from readme/docs

Agreed! That was my thinking as well.

Going to close this PR for now. Let me know if you have any more questions!


Make the timetable times sticky

Make them stick to the top, and when the next time comes, the previous time should disappear.

:raised_hand_with_fingers_splayed:

Thanks! Assigned 👍


dropdown.js: Use more straightforward phrasing for index bound check

!~index is unnecessarily tricky.

@XhmikosR @hnrch02 LGTY?

Those bitwise operators always baffled me :/
Your solution certainly seems simpler to my eyes.

:+1:


npm users with Gravatar avatars don't show the correct avatar

The avatar that shows up on npms.io:

The avatar that shows up on npmjs.com:

It looks like users who uploaded an avatar directly to npmjs.com are showing up correctly, but Gravatar users are showing up with generated avatar images.

The npm registry doesn't contain user documents. Having that said, is impossible to know the URL of the image uploaded through npm.
Let me know if there's a way to retrieve it without having to crawl their website.

To display a gravatar, all you need is the user's email address.  https://secure.gravatar.com/site/implement/hash/

We are using gravatar, my avatar is being displayed correctly through gravatar. Need to check whats wrong with yours.

Ah, I see what's happening.  The email address is not being lowercased before it is hashed.

<EMAIL_ADDRESS>hashes to b0d8ecb1f35283c9ac7fd219916efb90 (correct) https://www.gravatar.com/avatar/b0d8ecb1f35283c9ac7fd219916efb90?d=retro&r=g&s=40
<EMAIL_ADDRESS>hashes to 8ad29570949de46ca2713534f9070ab3 (incorrect) https://www.gravatar.com/avatar/8ad29570949de46ca2713534f9070ab3?d=retro&r=g&s=40

Hmm, acordingg to the RFC email is case sensitive, despite most mail servers and providers implement it as case insensitive. I suggest that you fix your emails in the package.json otherwise we could be breaking other gravatars by lowercasing.

Fixed!


temporarily disable memory cleanup due to node bug

bug fixed in Node 17.x
https://github.com/nodejs/node/pull/3332101

Stack:

#16
#15 ⬅
#14
#13
#12

⚠ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

✓ Commit merged in pull request #16


‘cannot open shared object file’ even though library is in correct location

I’m trying to use rust-opencv in a Docker container deriving from rust:1.57.0-bullseye. I manually built OpenCV 4.5.1 with the nonfree modules through a lot of trial and error (by downloading the source for 4.5.1 and following the CMake instructions, using Clang). When I run a test (which is where the library is used), Rust says the .so doesn’t exist:
Finished test [unoptimized + debuginfo] target(s) in 1m 59s
     Running `/usr/src/app/rust/target/debug/deps/backend-e32510369b055f2d`
/usr/src/app/rust/target/debug/deps/backend-e32510369b055f2d: error while loading shared libraries: libopencv_xfeatures2d.so.4.5: cannot open shared object file: No such file or directory
error: test failed, to rerun pass '--bin backend'

But I can see the file:
# ls -al /usr/local/lib/libopencv_xfeatures2d.so.4.5
lrwxrwxrwx 1 root root 30 Jan  3 20:59 /usr/local/lib/libopencv_xfeatures2d.so.4.5 -> libopencv_xfeatures2d.so.4.5.1

From running cargo test -vv, it seems like rust-opencv has already added the directory as a link path:
[opencv 0.61.3]     cargo_metadata: [
[opencv 0.61.3]         "cargo:rustc-link-search=/usr/local/lib",

(Full output with RUST_BACKTRACE=1)
I also tried with OPENCV_LINK_PATHS=+/usr/local/lib for good measure, but the result was the same. Note that I’m running cargo clean between attempts to make sure there’s no cache-related issue.
To help reproduce the issue, this is my Dockerfile for development purposes (I mount my source directory as a volume):
FROM rust:1.57.0-bullseye

ARG OPENCV_VERSION=4.5.1

RUN apt-get update -qq && apt-get install -qqy wget software-properties-common libclang-dev cmake make unzip

RUN bash -c "$(wget -O - https://apt.llvm.org/llvm.sh)"

RUN cd /tmp && \
    wget -O opencv.zip https://github.com/opencv/opencv/archive/${OPENCV_VERSION}.zip && \
    wget -O opencv_contrib.zip https://github.com/opencv/opencv_contrib/archive/${OPENCV_VERSION}.zip && \
    unzip opencv.zip && \
    unzip opencv_contrib.zip && \
    mkdir build && \
    cd build && \
    cmake -DOPENCV_EXTRA_MODULES_PATH=../opencv_contrib-${OPENCV_VERSION}/modules -DOPENCV_ENABLE_NONFREE:BOOL=ON ../opencv-${OPENCV_VERSION} && \
    cmake --build . -j $(nproc) && \
    make install

RUN ln -s /usr/lib/llvm-13/bin/llvm-config /usr/local/bin/llvm-config

Apparently, I also needed to set LD_LIBRARY_PATH or an equivalent. There’s a way to do that programmatically, which I added to the Dockerfile. I can’t pretend to understand it, but it works now!

This environment variable instructs system on where to search for additional dynamic libraries when running an executable. Because your OpenCV installation is not in the standard system path (like /usr/lib) you need to specify this additional search path.

I didn’t realize /usr/local/lib wasn’t a standard path. I’ll keep that in mind. Thanks for the information!


Export RecordSubscription

I noticed this one wasn't exported, but it would be nice to use for callback param typing when building wrappers around realtime subscriptions.

Hm, it should be already exported https://github.com/pocketbase/js-sdk/blob/rc/dist/pocketbase.es.d.ts#L408.
I guess you may need to import as "type" style import because it is not a JS object but only a TS interface/type, eg.:
import type { RecordSubscription } from "pocketbase";

let sub: RecordSubscription;

My mistake, it is not exported (the export statement is at the bottom of the definition file).
It needs to be registered also in https://github.com/pocketbase/js-sdk/blob/rc/src/index.ts.
I've also just learned that in newer TS version you can also do the type import in a single line:
import PocketBase, { type RecordSubscription } from "pocketbase";

I'll export the types before the final v0.8.0 release (most like the end of the next week).

Why we're here, would you also consider exporting following types?
AuthProviderInfo
AuthMethodsList

and maybe for the function authWithOAuth2 (argument provider) we could have some kind of type (could be an enum)

I've added the types to the exports list in the latest v0.8.0-rc3 release.
About the enum for the authWithOauth2 provider parameter - for now I left as a string, because defining it as enum will require an SDK update on every new OAuth2 provider.


docs: update loading data

Changelog
✅ Stated that +page.js's load function runs on the server or in the browser.
In the initial SSR, the load function runs on both environments. However, on client-side navigation, it only runs in the browser. For clarification, replaced 'both-and' with 'either-or'.

A load function in a +page.js file runs both on the server and in the browser.

The load function in a +page.js file runs either on the server or in the browser.

✅ Specified [ load function, file(s), component(s), a/the ] for clarification.
✅ Unified expressions.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[ ] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

I'm not sure if adding the "file" suffix everywhere is really needed - the file ending makes it obvious (to me at least) that this is related to a file.
The universal load both vs either-or situation is tricky, both descriptions are correct. On first page visit it's run on the server by default and is run on the client for hydration again (both), for client-side navigations it's run in the client (either-or). I'm not sure how to best bring this message across.

Thanks for making the effort, but I'm inclined to close this PR because I think the majority of changes here are not ones that improve the readability of the docs

Agree, I'm afraid the proposed wording introduces ambiguities

Thanks for the consideration.

I still hope that the load documentation specifies when and where the load function runs. (https://github.com/sveltejs/kit/issues/8581)

A load function in a +page.js file runs both on the server and in the browser.

The current documentation is misleading, since it doesn't always run on the server and in the browser.

The universal load both vs either-or situation is tricky, both descriptions are correct. On first page visit it's run on the server by default and is run on the client for hydration again (both), for client-side navigations it's run in the client (either-or). I'm not sure how to best bring this message across.

Majority of the times it runs only in the browser, except for cases such as initial hydration on SSR.
universal load functions that run
-  both on the server and in the browser
+  on the server or in the browser
+  mostly in the browser, but also in the server

Will removing 'either' help? Added few suggestions.

One of the reasons for specifying 'load function' was to clarify that the parent exists in the load function.

Inside +page.server.js and +layout.server.js, parent returns data from parent +layout.server.js files.

It is not required to export the load function from the +page.server.js file. It might only export the actions function.

In the load functions of +page.server.js and +layout.server.js files, parent returns data from parent +layout.server.js files.

Specifying that parent is provided to the load function seems to improve clarification.
Or adding code blocks for +page.server.js and +layout.server.js in the Using parent data section can help.
They are the only ones missing - +layout.js and +page.js code blocks are provided.
// src/routes/[foo]/+layout.server.js

/** @type {import('./$types').LayoutServerLoad} */
export const load = (async ({ parent }) => {
  const { a } = await parent();
  return { b: a + 1 };
})


Adding full width (block) prop to button component

In many cases web app require to have full width block buttons (similar to what bootstrap does with their block class). Wouldn't it be better to have block prop in button element?
I noticed we recently merged full width support for text fields. It would be nice to have it for button elements too.

+1

+1

#927

Fixed with #989

:+1:


Small js doc issue in  openui5/src/sap.ui.core/src/sap/ui/base/Object.js

Here: https://github.com/SAP/openui5/blob/master/src/sap.ui.core/src/sap/ui/base/Object.js
is a small jsdoc issue with a brace. Look for:
* @return {sap.ui.base.Metadata] metadata for the class of the object

Thanks for reporting, just created a pull request: https://github.com/SAP/openui5/pull/1944

for the log: the pull request was merged.


Get browserstack account for Next.js

Would be neat to quickly try out issues in IE.
https://www.browserstack.com/pricing

I didn't notice there's a FREE plan for OSS.
@rauchg any thoughts on this?

Saucelabs a free OSS plan:
https://saucelabs.com/open-source

Microsoft provides free to use VM images for testing IE: https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/

Saucelabs is really great to setup automated tests, you can set them up using JS (I think like CasperJS, never used this one), and it runs automatically, can make diff based on screenshots etc.
I have not used it a lot, but felt really powerful and quite easy to use

@arunoda Browerstack does offer free OSS plans.


Triviality of TrackSoAHeterogeneousT<32768> construction

After inheriting from PortableDeviceCollection, TrackSoAHeterogeneousT becomes non-trivially consrtructible.
Error:
ADataFormats/Common/interface/HeterogeneousSoA.h:41:46:   required from 'cms::cuda::host::unique_ptr<T> HeterogeneousSoA<T>::toHostAsync(cudaStream_t) const [with T = TrackSoAHeterogeneousT<32768>; cms::cuda::host::unique_ptr<T> = std::unique_ptr<TrackSoAHeterogeneousT<32768>, cms::cuda::host::impl::HostDeleter>; cudaStream_t = CUstream_st*]'
/cmsnfshome0/nfshome0/borzari/CMSSW_12_6_X_2022-09-27-2300/src/RecoPixelVertexing/PixelTrackFitting/plugins/PixelTrackSoAFromCUDA.cc:61:44:   required from here
/cmsnfshome0/nfshome0/borzari/CMSSW_12_6_X_2022-09-27-2300/src/HeterogeneousCore/CUDAUtilities/interface/host_unique_ptr.h:92:57: error: static assertion failed: Allocating with non-trivial constructor on the host memory is not supported
   92 |       static_assert(std::is_trivially_constructible<T>::value,
      |                                                         ^~~~~
gmake: *** [config/SCRAM/GMake/Makefile.rules:1712: tmp/el8_amd64_gcc10/src/RecoPixelVertexing/PixelTrackFitting/plugins/RecoPixelVertexingPixelTrackFittingPlugins/PixelTrackSoAFromCUDA.cc.o] Error 1
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

Tests done
Tests added in branch PixelTrack_TrajectoryState_SoA:

Original, manually defined SoA is trivially constructible (see test here)
Using Eric's SoA, by inheriting PortableDeviceCollection, it can be seen that PortableDeviceCollection is not trivially constructible (test here)

Probable cause
TrackHeterogeneousSoAT instances are created by calling either cms::cuda::make_device_unique, cms::cuda::host::unique_ptr, or std::make_unique.  All of these seem to check if the instance is trivially constructible.
Instance 1
Host allocation:
cms::cuda::host::unique_ptr<pixelTrack::TrackSoA> soa_;

https://github.com/cms-sw/cmssw/blob/master/RecoPixelVertexing/PixelTrackFitting/plugins/PixelTrackSoAFromCUDA.cc#L38
Instance 2 & 3
Device allocation:
PixelTrackHeterogeneous tracks(cms::cuda::make_device_unique<pixelTrack::TrackSoA>(stream));

Source

Host(?) allocation:
PixelTrackHeterogeneous tracks(std::make_unique<pixelTrack::TrackSoA>());

Source


(chore) - create Preact example

This PR makes a version of the examples/basic app leveraging Preact. The only thing that stands out here is the "hack" we have to do in Preact to make the hydrate(x, document) work correctly.
There's an additional fix to be found in the remix-dev CLI, when missing a package like React (or in my case Preact... Yes I forgot to install Preact :joy:) it would print out that the dev cli was missing, which had me confused for quite a while. Now it will take the first line of the error message, which is the same it was before, and leverage that to indicate the missing module.

Does this also apply Preact for production? How are you checking for Preact in the website?

The npm deps replace React with Preact, verified production bundles :)

We've been working (sporadically, our fault) with @developit on this. I'm going to close this but welcome it being reopened when we announce official Preact support :)

To be clear, we will support Preact "natively". No compat layer so we can get the client bundle even smaller :)


publish to docker hub

Codecov Report

Merging #32 (f7a4988) into master (73f90d9) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head f7a4988 differs from pull request most recent head 8d8b1a4. Consider uploading reports for the commit 8d8b1a4 to get more accurate results

@@           Coverage Diff           @@
##           master      #32   +/-   ##
=======================================
  Coverage   95.62%   95.62%
=======================================
  Files          81       81
  Lines        1736     1736
  Branches      182      182
=======================================
  Hits         1660     1660
  Misses         67       67
  Partials        9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73f90d9...8d8b1a4. Read the comment docs.


Align with changes in latest ORM (unreleased)

Upgrade to Hibernte ORM 6.4.2-SNAPSHOT
Note that until the final version is released, Hibernate Reactive will use the snapshot available from Sonatype.
It will be released tomorrow, so it should not cause too much trouble.
Remember to update the gradle.properties file accordingly if you want to test local changes with ORM.
Superseeds https://github.com/hibernate/hibernate-reactive/pull/1636
Fix #1645

Yeah, sorry, I've added you as a reviewer but it was meant more as a FYI

This PR should work once we have the next 6.2 nightly build (I've tested it locally).

Replaced by #1647


vm.parseJsonAddressArray throwing error with no data.

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (6432031 2023-11-27T00:19:19.837119000Z)
What command(s) is the bug in?
forge script
Operating System
macOS (Apple Silicon)
Describe the bug
An error started popping up in CI runs and I'm trying to get to the bottom of why these lines of code don't work. Hopefully someone can point me in the right direction:
string memory json = "[\"0x0000000000000000000000000000000000000000\"]";
console.log(json); // prints correctly
address[] memory arr = vm.parseJsonAddressArray(json, "$");
console.log("here"); // does not print at all

The only error that I receive is:
"script failed: <no data>"

Cheers!

ptal @DaniPopes


Remove old release tags

The same as https://github.com/softprops/action-gh-release/issues/47, except that this is specifically about overwriting the existing tag to also update it instead of the assets only.

+1 to this. There should be an optional parameter for this


Fixes phantomjs build issue

CI build was failing with libssl issue - this should resolve the issue. Please wait for jenkins CI build to pass before merging

Waiting on https://ci-builds.apache.org/job/Brooklyn/job/brooklyn-ui/view/change-requests/job/PR-380/


Add available state to unifiled integration

Description:
Add available state to unifiled integration
Example entry for configuration.yaml (if applicable):
light:
  - platform: unifiled
    host: <IP_ADDRESS>
    port: 20443
    username: ubnt
    password: ubnt

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

[x] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[x] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
[x] Untested files have been added to .coveragerc.

@MartinHjelmare If you have a sec could you merge this one then I can submit the next one.


Pop-up do not close

HI.
When i try to delete a row after i click "delete" in the pop-up, the row is deleted, but the pop-up do not close, same happen with update.  The only pop-up that close after the process is the one when i create a new row. Something that i can do to solve this?
Thank you.

Issue resolved. Delete dialog closes after successful submission


drop usage of gopkg.in/check.v1 to start using github.com/google/go-cmp/cmp instead

gopkg.in/check.v1 is unmaintained and forces usage of BZR which can cause some issues down the line

Thanks for your contribution !


Update configure-workflow-properties.md

Added: Note that placeholders cannot be added via copy and paste

:x: Organization membership check failed
Members of the MicrosoftDocs organization should use the private repo. Please move your changes to https://github.com/MicrosoftDocs/Dynamics-365-Operations, and close this pull request.

:x: Organization membership check failed
Members of the MicrosoftDocs organization should use the private repo. Please move your changes to https://github.com/MicrosoftDocs/Dynamics-365-Operations, and close this pull request.


nav: Link to RPC folder

We need a link somewhere in the nav (possibly right at the bottom of the nav?) to the OpenAPI docs in the /${VERSION}/rpc/ folder.
This folder is already created when fetching the releases' documentation here: https://github.com/cometbft/cometbft-docs/blob/7e198ef121cfa594ce5c4f4fa2f9f571511dc8be/Makefile#L22

This can be done by renaming rpc/index.html to rpc/rpc.html (or something else) and then adding this rpc/index.md:
---
order: 5
parent:
  title: RPC
  order: 5
---

# RPC

Link to RPC: [RPC Page](./rpc.html)

Results in:


Issue with latest Revit Lookup install and RDBE

With both installed in revit, I am getting loads of crashes, slowness
https://github.com/jeremytammik/RevitLookup/issues/154#issuecomment-1499091998

I saw that, it is interesting that some interaction exists between RDBE and RL, but I would rather not suspect that dll versioning is a reason for this problem.
Did you have enabled event monitor in RDBE? Event monitor in RDBE when enabled works all the time in the background, which is quite contrary to the event monitor in RL which only works when RL window is displayed.

No, not at the time
I tried it just now and I get this when I use the update button

The crash are hard to identify.
this time I activated RVTLookup alone, and everything was fine, then RDBE, used the RDBE event monitor, then the Revit lookup one at the same time. No issue except for the update button

Now, I closed RDBE and Revit lookup, delete something in my model > Crash

You have done Reload on events? Yes, that produces NullReferenceException from your screen, but this is not related to the problem with RL, this is a separate bug.

indeed


ImportError: cannot import name 'is_s3express_bucket' from 'botocore.utils'

Describe the issue
In aws sagemaker, I used to install 'sagemaker==2.183.0', 'xgboost==1.5.1', 'statsmodels=0.13.5', and 'fasttreeshap==0.1.6' to launch a post processing job for my ML model. As of today, I've faced an import issue regarding botocore as follows. I wonder if you could help me out.
FYI, I tried to downgrade botocore to 1.32.5, as before but the import error is still there.
ImportError: cannot import name 'is_s3express_bucket' from 'botocore.utils' (/miniconda3/lib/python3.7/site-packages/botocore/utils.py)
Links

Hi @MostafaHosseinian, it looks like this is a duplicate of #3082. We'll track resolution of this issue there. If you don't mind confirming if you're on Lambda in that ticket, it will be helpful. Thanks!

saw same error on mac when using aws eks update-kubeconfig ... cli, and below steps fixed it for me on mac:
$ aws eks update-kubeconfig --name <AWS EKS cluster name> --region <AWS region>
Traceback (most recent call last):
  File "/usr/local/bin/aws", line 27, in <module>
    sys.exit(main())
  File "/usr/local/bin/aws", line 23, in main
    return awscli.clidriver.main()
  File "/Users/vhosakot/Library/Python/3.9/lib/python/site-packages/awscli/clidriver.py", line 69, in main
    driver = create_clidriver()
  File "/Users/vhosakot/Library/Python/3.9/lib/python/site-packages/awscli/clidriver.py", line 78, in create_clidriver
    load_plugins(session.full_config.get('plugins', {}),
  File "/Users/vhosakot/Library/Python/3.9/lib/python/site-packages/awscli/plugin.py", line 44, in load_plugins
    modules = _import_plugins(plugin_mapping)
  File "/Users/vhosakot/Library/Python/3.9/lib/python/site-packages/awscli/plugin.py", line 61, in _import_plugins
    module = __import__(path, fromlist=[module])
  File "/Users/vhosakot/Library/Python/3.9/lib/python/site-packages/awscli/handlers.py", line 78, in <module>
    from awscli.customizations.s3.s3 import s3_plugin_initialize
  File "/Users/vhosakot/Library/Python/3.9/lib/python/site-packages/awscli/customizations/s3/s3.py", line 15, in <module>
    from awscli.customizations.s3.subcommands import ListCommand, WebsiteCommand, \
  File "/Users/vhosakot/Library/Python/3.9/lib/python/site-packages/awscli/customizations/s3/subcommands.py", line 18, in <module>
    from botocore.utils import is_s3express_bucket, ensure_boolean
ImportError: cannot import name 'is_s3express_bucket' from 'botocore.utils' (/Users/vhosakot/Library/Python/3.9/lib/python/site-packages/botocore/utils.py)

# saw above error with below versions
$ pip3 list | grep 'aws\|boto\|s3'
awscli                     1.32.80
boto3                      1.28.38
botocore                   1.31.85
s3transfer                 0.6.2

below steps fixed it for me:
pip3 uninstall -y awscli boto3 botocore s3transfer
pip3 install awscli

# below command worked for me
aws eks update-kubeconfig --name <AWS EKS cluster name> --region <AWS region>


Refactored more of code and All Lesson Tests covered

Codecov Report

Merging #185 into master will decrease coverage by 7.33%.
The diff coverage is 35.05%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef68263...a8bc136. Read the comment docs.


nav bar design change #1526

just tried to change lil bit of navigation bar as i  m a beginner

@Sukusharma Please include before and after images or video of the changes from next time to improve clarity. Thanks for your effort! 🙌


#[hawktracer] requires various parts of the crate in scope

It would be better if the code generated by the macro would reference the hawktracer API via absolute path instead of depending on it to be in scope.

I agree, I didn't have time to get around to it unfortunately.
Also mentioned here:
https://github.com/AlexEne/rust_hawktracer_normal_macro/issues/5


[Snyk] Upgrade graphql-tag from 2.11.0 to 2.12.0

Snyk has created this PR to upgrade graphql-tag from 2.11.0 to 2.12.0.

:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.
The recommended version was released a month ago, on 2021-01-29.

The recommended version fixes:

Severity
Issue
PriorityScore (*)
Exploit Maturity

Cross-site Scripting (XSS) SNYK-JS-PRISMJS-597628
629/1000  Why? Has a fix available, CVSS 8.3
No Known Exploit

Cross-site Scripting (XSS) SNYK-JS-PRISMJS-597628
629/1000  Why? Has a fix available, CVSS 8.3
No Known Exploit

Regular Expression Denial of Service (ReDoS) SNYK-JS-HIGHLIGHTJS-1048676
629/1000  Why? Has a fix available, CVSS 8.3
No Known Exploit

Prototype Pollution SNYK-JS-HIGHLIGHTJS-1045326
629/1000  Why? Has a fix available, CVSS 8.3
No Known Exploit

(*) Note that the real score may have changed since the PR was raised.

Release notes

Package name: graphql-tag

2.12.0 - 2021-01-29Bump npm version to 2.12.0.

2.11.0 - 2020-07-28
package.json sideEffects changes to clearly identify that graphql-tag doesn't have side effects.
@ hwillson in #313

    from graphql-tag GitHub release notes

Commit messages

Package name: graphql-tag

a9f689a Bump npm version to 2.12.0.
1809a56 Set up dependabot to keep dependencies up-to-date.
a9e1cc9 Merge pull request #325 from PowerKiKi/master
bfe5a61 Mention PR #325 in CHANGELOG.md.
1dc4a23 Avoid using direct eval in tests.
159979b Convert repo to TypeScript.
9558fe3 Implement ES6 export file
e06bd06 Remove no-longer-used .travis.yml configuration file.
aa9c5c9 Set up GitHub Actions.
292bb8f Rename graphql-js to graphql (#318)

Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@paologallinaharbur well that's sort of the point of SNYK it keeps track of package updates and monitors vulnerabilities and creates a PR to bump a package version when a vulnerability is detected, so ideally, we'd fix the code of the app t allow these checks to pass.
I also know SNYK had a bug that filing issues in users names, so this isn't your problem to fix unless you want to contribute to the repository. 😄
I'll keep the issue open to see if the community wants to resolve it.


Relative paths in Navigator.SearchFile

Is your feature request related to a problem? Please describe.
I would like to search a subfile of a node in several folder levels. For instance, given the folder /root/data/f1 I would like to find its child maps/script0.bin but providing this relative paths instead of the full path.
Describe the solution you'd like
Using Navigator.SearchFile(f1Node, "maps/script0.bin") should provide the script0.bin instead of expecting the full path.
Describe alternatives you've considered
Create another method, but I think it's far common to say that if the path doesn't start with / is a relative path so this behavior should be consistent.
Additional context
This is the use case of extracting a file and searching inside it without knowing its roots.

Fixed by #99


How to know the input token count in the context including the tools for each call?

Is there a way to know the exact/rough token count including the tools?

Yes there is each response.done has the info. https://platform.openai.com/docs/api-reference/realtime-server-events/response/done.
The event can be of type message or function_call. In the usage object you find the detailed information


Add CMake and github workflow

Add cross-platform build (dockcross), ARMv5 to ARMv8, RISC-V 64 bit ect...
Add github CI

I don't see the benefit of adding such a complex build system.

Can it be interesting to add a makefile ?

No. As you get more experienced you will learn what is important to spend time on.


[Accessibility] Removed focus outline on touch screen

Removed the focus outline on touch screen.
I tested on Android, it works well.
On Edge on SurfaceBook, is doesn't change anything, probably because it still considerate that I have a mouse.
Does anyone can try with iOS ? The simulator doesn't work on my account on Peli's MacBook.

@veler,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

All makecode.com files need to be based of master.


⚠ Secret Website 3 has degraded performance

In 5a5e808, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 2469 ms

Resolved: Secret Website 3 performance has improved in f9ed7bb.


Fix newrelic config

move config to docker env vars

Sorry for the interruption, I built my PR in the wrong place.
By the way, I changed the db to tidb , seems to work fine, thanks!


Weird clicking when using VoiceOver

Prerequisites

[x] I'm using latest version: 0.21.1
[x] I've checked Known issues

Description
When using VoiceOver, there is a constant clicking sound when the microbreak window is open.
Operating system: macOS 10.15.3
Steps to Reproduce

Enable VoiceOver
Wait for (or trigger) a break

Expected behavior: VoiceOver announces that it's time to take a break, optionally counting down the seconds (but better to not I'd think?)
Actual behavior: A weird clicking sound. My guess is VoiceOver keeps trying to read the content of the popover, but every instant it tries reading it the progress bar ticks farther along, forcing VoiceOver to start over. Only the first fraction of a second of the text reading gets emitted, and it repeats until the window disappears, at which time VoiceOver reads the content of the (now disappeared) window.
Reproduces how often: Always

Hi @jkjustjoshing and thanks for the report. To be sure, you mean a built-in from Apple? https://en.wikipedia.org/wiki/VoiceOver
note to self: read more here https://github.com/electron/electron/pull/10305

Yep, happens when I have the built-in screen reader enabled.
To be clear, I don't use VoiceOver regularly - I'm a web developer and happened to be doing VoiceOver testing when my Stretchly popover appeared. So I'm not sure what the correct behavior would look like, just that the current functionality seems less-than-optimal.

Hi, is still issue with latest? I wonder if I can help here, but not sure.

No reply and this is pretty old, so closing. Let me know if this is still an issue

Sorry for not replying. Yes, I just downloaded Stretchly v1.3.11, macOS version 13.2.1 on an M2 Pro Mac. See attached video. Please re-open.
https://user-images.githubusercontent.com/813192/226116111-32cb0bc3-c06b-4b44-b4c4-eb0063abf7da.mov

Do you have some specific settings for Voice Over  / Stretchly?
I am trying to reproduce but I do not get any weird noises.

But I think the cause is VoiceOver trying to read time remaining, in your case, so https://github.com/hovancik/stretchly/pull/1288 should help fixing that, if you could try


How should Fog-Google deal with version > 0.9

Hi there @sqrrrl. I'm working on https://github.com/fog/fog-google/pull/100.
Reading https://github.com/google/google-api-ruby-client/blob/5ec8d9c75cd68d9bd0139cf808c4ac2d2d86cd57/MIGRATING.md, it is unclear what will happen when I require "google/api_client" like I do at https://github.com/icco/fog-google/blob/upgrade-google-api-client/lib/fog/google.rb#L72-L78. Does this mean I don't have to require any of the sub API versions later?
What was the decision behind moving away from API Discovery support?

Nope, including google/api_client won't load any of the generated interfaces. You'll still need to pull in the ones you're actually using.
As for why the switch from runtime code generation to ahead of time, it was mostly around usability & performance. If the previous client were just a dumb http client with oauth support, it wouldn't have been so bad. But it wasn't. The runtime code generation did inflections on the request bodies & responses, inconsistently at that (request/response bodies, but not params...and even then, there were exceptions...) And since it was all done at runtime, there were little in documentation to show what the right call was..  And based on the # of "how do I..." bugs, people didn't.. And there were at least 3 or 4 different calling styles supported which also didn't make things any clearer...
That, and there were a lot of performance issues with how it was implemented. Excessive invalidations of the method cache, plus it required developers to do extra work to do the right thing and cache discovery docs...
Most of that goes away with ahead of time generation. No extra lookups for discovery, no need to think about caching api descriptions, no guessing what a call looks like any more...
All that said, there's still a generic 'http' method on BaseService if you just want to treat the client as a slightly smarter HTTP client with oauth support & retries...
And since everything still is generated from discovery, there are things that could be done if absolutely needed. I'm not too keen on supporting multiple calling styles again, but it would be possible to add a generic execute in the 0.8.x style. It would be too hard and confusing to be 100% compatible with 0.8.x, but a subset of functionality could be restored.


CAPTCHA solution is included in the JWT in plain text

The solution to the CAPTCHA challenge is included in the the JWT in unencrypted form. Therefore, the challenges can be solved automatically without any effort. Ideally the solution should be encrypted with a probabilistic encryption algorithm.

Hi @konradh, many thanks for reporting this issue. In version 0.1.1 I replaced JSON Web Signature (JWS) with JSON Web Encryption (JWE) . Thus, the solution of the CAPTCHA chalange is now now transmitted in an encrypted JWT.


Functional tests (disabled) for temp keys policies

Moved existing temp key tests to new test class, and added new tests for temp key policies. I'll enable the new tests once I've created a test account enrolled in temp key policies for all environments.

:shipit:


Consider adding rbenv init to global shell configurations

I use the dotfiles personalization support of VSCode's development containers extension to copy over, among other configs, a custom .zshrc.
Unfortunately, the ruby feature has already customized the ~/.zshrc that is present in the base dev container image:
https://github.com/rails/devcontainer/blob/916aec13c12ab57d0f9b42b84797912942fc2ea9/features/ruby/install.sh#L23-L27
This causes the ruby command to not be found, and thus the postCreateCommand in the default Rails dev container configuration to not work:
https://github.com/rails/rails/blob/13d5f87208921cc5139cd53b280c42f23c334826/railties/lib/rails/generators/rails/devcontainer/templates/devcontainer/devcontainer.json.tt#L36
I think it would be better to either append to the global shell configurations (/etc/bash.bashrc and /etc/zsh/zshrc) or find the appropriate lifecycle hook to append to the user-specific configurations after dotfiles have been copied over.

Thankfully, I've figured out a way around this issue (and the general issue of clobbering automatically-managed shell configurations) by using ZDOTDIR in ~/.zshenv, so this is less pressing of an issue to me now.


CD/CI tools for docstring format validation

Moving here conversation from #1693
Description:
Right now, docstring writing is left up completely to the contributors, who may not apply the correct style format.
In that issue, a tool can't be integrated correctly due to malformed parameter specification.
Current references to the format only include:

This contributing section
This checklist item in the PR Templates.

None of the above methods describe nor mention a user-agnostic way of checking compliance.
Proposed solution:
We could approach this issue by enforcing docstring validation tools, like numpydoc --validate, numpydoc.validate() or a module that wraps this function called numpydoc-validation.
However, mentioned linters in #1693 won't raise errors exactly for that. numpydoc raises errors that may hint the user.
Meanwhile, upgrading contributing.rst and/or the PR template to mention numpydoc --validate use case would be of help.
Alternatives:

Module pydocstyle

I haven't found a way of integrating it in sphinx builds, but there might be some way.
Additional context
This is a summary of one of my comments in #1693: when I first contributed to this repo, one of the things that I felt most discouraging was writing the docstring. If just expressing myself in a foreign language is not enough, trying to copy other's formats, then finding inconsistencies among them; and checking by building the docs, which takes time, are some of the bottlenecks that affect new contributions.

For future reference: https://github.com/numpy/numpydoc/pull/312/files


StackOverflow Off-Site link not working on QnA detail page

Login as Joe
Goto any of  SO question
Click on the off-site link at top right corner when you are on QnA detail page
Not working in latest develop code. Link doesnt seem clickable .

(this one was mentioned in #473)

Fixed code committed to my "app-wide-tooltips" branch (https://github.com/clockworked247/marklogic-samplestack/tree/app-wide-tooltips).  As requested, I will create PR once we're clear what is going on with the e2e test errors (https://github.com/marklogic/marklogic-samplestack/issues/481).


DOM node replacement (with v-if) overlaps with the previous node

Vue Version : 2.0.0-rc.4
Repro : https://jsfiddle.net/p9mcn2tp/3/
When there are two sibling components that toggle each other, the second one that appears seems to have some properties of the previous one.

It looks like the element is being patched for efficiency, instead of replaced, which is somehow proactively triggering the previous click event. If you need an immediate fix, you can add unique key attributes to each component to instruct the virtual DOM that each of these elements are completely separate entities.

This doesn't seem to be related to Vue - see https://jsfiddle.net/mf4p8jb2/ - in this fiddle, even a button without type="submit" would submit the form. In your original fiddle, Vue is rendering the second button correctly without type="submit".

In my example if you click on the second button, the form is not submitted, while the first one triggers the submit.
@chrisvfritz seems to have found the source of the bug.
You should reopen this issue.

@clegendre can you clarify what is your expected behavior? (which, btw, is required for a proper bug report per issue reporting guidelines) What I am seeing is that clicking the first button submits the form, which I assume is what you think is a bug, but in my fiddle I am showing you that is happening without Vue being involved at all, it's just how the browser works. If that's not what your issue is about, then you should've provided proper explanation.

I update your fiddle : https://jsfiddle.net/mf4p8jb2/1/
In this update the button "b" is now of type "button", which is the same as in my example.
In this case, a button type="button" does not submit the form, and this is just how the browser works too.
My explanation is the following: in my example, the button of type="button" does submit the form because it is replaced by the direct sibbling in the hierarchy which is a button of type="submit".

Okay, that makes sense. This is indeed a bug.

Upon further investigation, I'm not sure if there's anything Vue can do about this. Surprisingly, the browser seems to determine form submission by the type of the button that triggered the event when the event reaches the form element rather then the type when the event was triggered. Vue patches the button in-place when they are toggled, and this happens after the event was triggered, but before the event reaches the form element.
The only way to get around this is changing how Vue's async queueing works by ditching MutationObserver, but I don't think that's worth it, since it can be easily worked around by keying the two buttons.

Sorry to "reopen" this issue, but there is another repro link, which doesn't involves a form at all.
https://jsfiddle.net/mf4p8jb2/2/
In this sample, the button c toggles the apparition of the button b. But the effetct of the button c is applied to the button b.
This is ok when the key  attribute is applied on both components but this is not very intuitive.
Thank you for your help.


RKE2 node driver cluster | nodes are replaced when upgrading Rancher from 2.6.3 to 2.6-head

Rancher Server Setup

Rancher version: start on 2.6.3 and upgrade to 2.6-head 8c785a1
Installation option (Docker install/Helm Chart): Helm

If Helm Chart, Kubernetes Cluster and version (RKE1, RKE2, k3s, EKS, etc): RKE1

Proxy/Cert Details: self-signed

Information about the Cluster

Kubernetes version: v1.21.9+rke2r1
Cluster Type (Local/Downstream): downstream

If downstream, what type of cluster? (Custom/Imported or specify provider for Hosted/Infrastructure Provider): RKE2 digital ocean node driver

Describe the bug

Downstream RKE2 node driver cluster has its nodes redeployed when upgrading Rancher from 2.6.3 to 2.6-head
To Reproduce

Create HA Rancher
Deploy a downstream DO RKE2 node driver with 3 nodes (each role)
Upgrade Rancher to 2.6-head

Result
You can see extra nodes in the downstream cluster being deployed. After they are deployed the old ones are deleted.
Expected Result

Downstream cluster nodes should not be affected by Rancher upgrade
Screenshots

As soon as Rancher is upgraded you can see new nodes provisioning

each pool got a new node

when new nodes are provisioned the old ones are deleted

Additional context

There has been so much that has changed in RKE2 provisioning. One example is that users are able to specify DrainBeforeDelete.
In order to support these things, the MachineDeployments are updated. When this happens (which is all the Rancher controls), then CAPI will create new machines and delete the old ones.
Given the "Tech Preview" status of RKE2 provisioning, this may be a necessary evil as we go to GA status.

Can we invert behavior on our end to just default to DrainBeforeDelete being on by default?

@Oats87 , that's not the only reason it's triggered I believe.
At this time I think the current behavior is acceptable given the Tech Preview status of RKE2 provisioning in 2.6.3. We would like to release note it.

Moving to test to ensure QA actually validates that cluster comes back up active on upgrade (but per this issue, it's acceptable the nodes will be replaced).

Can we invert behavior on our end to just default to DrainBeforeDelete being on by default?

Just wanted to add that despite CAPI draining by default, we chose to default DrainBeforeDelete to false for parity with RKE1

On an upgrade from 2.6.3 to 2.6-head commit id: bab14a3

Deployed a 3 etcd, 2 cp and 3 worker node RKE2 cluster on v1.21.9+rke2r1 version
deployed resources on the downstream cluster
Upgrade rancher to 2.6-head
Cluster is in an error state for sometime, before going back Active and the nodes start getting deleted and reprovisioned (logged bug - https://github.com/rancher/rancher/issues/36852)
Noticed that the nodes got deleted in parallel - 1 etcd, 1 control and 1 worker nodes got deleted in parallel and reprovisioned.
Existing resources on the clusters worked fine, and new resources were deployed

@Oats87 Is this expected? "Noticed that the nodes got deleted in parallel - 1 etcd, 1 control and 1 worker nodes got deleted in parallel and reprovisioned. "


Title replace Typography.Title

@Germiniku Typography.Title is too complex and not good for mobile, so I don't want it to be the default Title UI.
I prefer to use children for custom UI. for example:
function CustomTitle(props: { title: string }){
  return <Title title={ props.title }>
      <Typography.Title>{ props.title }</Typography.Title>
    </Title>
}

Typography.Title

Typography.Title default render is h1,the complexity depends on the user's functional parameters.I'm going to use it as a custom UI.

@Germiniku I see you add CustomTitle to the package, I mean you can add it in your own projects.
For @faasjs/ant-design, it just needs to add children to props.

@Germiniku I see you add CustomTitle to the package, I mean you can add it in your own projects. For @faasjs/ant-design, it just needs to add children to props.

ok,i close this pr


How to find non-parametrised bonds?

Hello!
The code :
mol = mbuild.load('<name>.pdb')
ff = foyer.Forcefield(name = 'oplsaa')
mol_ff = ff.apply(mol)

gives :
Exception: Parameters have not been assigned to all bonds. Total system bonds: <N>, Parametrized bonds: <M>

How can I find between which atoms there are bonds that Foyer can't parametrise?
Thanks!

Figured it out myself :
>>> mol = mbuild.load(<file name>)
>>> ff = foyer.Forcefield(name = 'oplsaa')
>>> mol_ff = ff.apply(mol, assert_bond_params = False, assert_angle_params = False, assert_dihedral_params = False, verbose = True)

gives a complete list of bonds, angles & dihedrals that aren't parametrised.


TLS authentication with external services

Hi,
I am looking for service mesh and for the time being is discovering istio (good job btw!).
But I have several questions:

I came across this lines in https://istio.io/docs/setup/kubernetes/quick-start.html:

Install Istio’s core components. Choose one of the two mutually exclusive options below or alternately install with the Helm Chart:
a) Install Istio without enabling mutual TLS authentication between sidecars. Choose this option for clusters with existing applications, applications where services with an Istio sidecar need to be able to communicate with other non-Istio Kubernetes services, and applications that use liveliness and readiness probes, headless services, or StatefulSets.

So if I understood it properly there is no way to enable TLS authentication for only the part of services in my cluster, right? I must enable TLS for all or for none of them.

Another Q: if I enable TLS for all of the services and some particular service_A has to communicate with some external apps without TLS (outside of Kubernetes cluster, service_Ex), but there is some service_B inside K8S that service_A must communicate with using TLS.

service_A--TLS-->service_B
service_A--NO_TLS-->service_Ex

the same as 2 but:
prometheus service monitor (https://coreos.com/operators/prometheus/docs/latest/user-guides/cluster-monitoring.html) --NO_TLS-->service_A/stats

is it possible to configure?
TIA

Thanks Lin for the response. And to add what she said, we support service level mTLS/TLS enablement. The doc/request for doc are listed above.
Whether a service-to-service communication is mTLS or http is determined by server side, which means, if service A has a config with mTLS enabled, then all clients (with sidecar) will get this info from pilot, and they will send mTLS when talking with service A. And same thing for http/regular TLS.

@linsun, @wattli
Thanks for your answers. I am going to study these docs and will come back if have any additional questions.

Thanks @wattli  for your comments!  That is interesting (Whether a service-to-service communication is mTLS or http is determined by server side).  Q: can service B sends http to service A when service B is configured with mTLS and service A is configured with non-mTLS?   In the past, I haven't been able to get this working so I ended up configuring both to non mTLS.

Close it for now. @maxkondr , please feel free to reopen it if necessary.


fastlane requires  for windows  os ?

this tool working for window os??

I have study for https://docs.fastlane.tools/ ,
System Requirements:
fastlane requires macOS or Linux with Ruby 2.0.0 or above.
https://docs.fastlane.tools/
this tool support for windows 7 etc. or not????

there are a few gems used, that just don't work on windows. i think pty for example - so as for now it seems not to be supported.

Going to close as a duplicate of #2082


Update @ConditionalOnClass

Specify class by name rather that importing so that there is no longer a dependency on aws-sdk-elasticache in the classpath.

@joshuaeke Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@joshuaeke Thank you for signing the Contributor License Agreement!


introduce external collectors

The ability to pass collectors from outside, with a preconfigured http client, logger and context (service).
I chose to pass a collection of factories, so the caller will be able to pass parameters upon collector creation, e.g.
def my_collector(params):
  # Here the caller may pass some custom params
  return MyCollector(params, some_custom_params)

ConfigFeederClient(..., collector_factories=[my_collector])

Since HttpClient is same for all collectors ConfigFeederClient should handle cluster / node registration and submission.
Collectors should do only collections and config feeder should handle talking with API
payload structure could be
{
  "collector_name": "<collection_result>",
}

e.g.

{
    "yarn_config": ...,
    "autoscaling_config": ...,
    "custom1": ...,
}

one request to submit everything to server. If there is a need to talk with server during collection http client still can be provided to collectors


Support build-in inline-render inferred types in TypeScript

example: (https://github.com/sokra/vscode-inline-types)

This feature seems to be supported natively by many IDE. such as Inlay Hints

I think this is implemented well by an extension, there is no clear reason at this time to reimplement this in the core of VS Code.


[Bug]: threads_kernel_1.h includes windows.h header

What Operating System(s) are you seeing this problem on?
Windows
dlib version
19.24.4
Python version
3.8
Compiler
MSVC 19.38
Expected Behavior
We should be able to create enum like this:
enum class Status { ERROR, OK };
while also including dlib headers in the same file.
Current Behavior
We get a compilation error since threads_kernel_1.h includes the windows.h header which defines a ton of macros and defines. Among which 'OPTIONAL' and 'ERROR'. This prevents us from using enum values named 'OPTIONAL' and 'ERROR' when we also include dlib headers.
Steps to Reproduce
Define the previously mentioned enum on a Windows system, while also including the  threads_kernel_1.h header at the top of the file
Anything else?
Suggestion is to move the windows.h include to the cpp such that no headers depend on windows.h

Yeah good idea.  That header is not really needed there anymore.


Clarify default port of 8126 must be set for APM and Fargate

What does this PR do?

Clarify default tcp port of 8126 must be set for APM and Fargate.
Motivation

If you follow our Fargate docs and don't specifically set up port 8126 with tcp protocol where the Datadog Agent is, the application will not be able to submit its traces to the Datadog Agent.
Additional Notes

It is possible to change the default receiver port to another port, but if you do this, then your tracing client must also match, so let me know if the wording should be more general about the port number. Note that 8126 is the default.
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached

/azp run


Open app nag still appears if toggled on

When toggling ON the open in app nag you still get the nag at the top of the screen at all times.

That's a Safari feature we have no control over, see the FAQ here: https://jbscript.dev/control-panel-for-twitter#safari-faq-ios-app-banner


[fb-package] Standardize variable creation

Description
Reformat contingency indicator creation function to match the style of the API in variables.R. A standard style improves maintainability, and defining indicators in load_response_one allows for easier single-wave processing.
These changes do not change table output, with the exception of the "smoker" grouping variable being recoded as True/False rather than 1/0 to match the standard boolean grouping variable format.
Changelog

Add arg to load_responses_all to indicate if data is being used for API (default) or contingency tables, in which case additional variables are created.
Remove auto-recoding by indicator prefix (b_, mc_, etc) and for a select set of survey items (education, etc). This functionality was not being used and added complexity.
Separate contingency indicator creation by topic into smaller functions in the style of code_* in variables.R.

@davidkretch Could you verify that the output from the changed code here is the same as that from the prior version? It's the same for me (aside from "smoker" going from 1/0 -> True/False), but I'd appreciate a second pair of eyes.

Thanks, @davidkretch!

Ready to merge!


fix: 修复单词拼写错误，replace 'Filed' with 'Feild'

General

✏ Mark the necessary items without changing the structure of the PR template.

[ ] Pull request template structure not broken

Type

ℹ What types of changes does your code introduce?

👉 Put an x in the boxes that apply

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist

ℹ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

👉 Put an x in the boxes that apply.

[ ] My code follows the style guidelines of this project
[ ] Is the code format correct
[ ] Is the git submission information standard?
[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

应该是 field 吧？咋像是从一个错的改成另一个错的


Add Yuka as easy

Hey there!
Since Yuka is not included in the list, I had inserted it in.
I hope this humble contribution will help!

All contributions help, thanks!


HTTP/2 push notification API

Are there any plans to use the new-ish HTTP/2 push notification API?

Any update here?

While I don't have any plans to tackle this myself I am more than happy to accept pull requests.


Hotfix/deploy gcp

Done

Add 'p2p' directory
Delete 'server' directory

@cshcomcom It it required to merge this to the master branch?


npm start broken on Windows

https://github.com/nicolodavis/boardgame.io/blob/master/scripts/dev.sh
doesn't run on Windows and needs to be made platform agnostic.
On Linux / OSX you can do the following to run both client and server:
npm install
npm start

Since dev.sh is broken on Windows you can't do this at the moment, although you can use the following manual workaround:
Run Client
npm install
cd examples/react-web
npm install
npm start

Run Server
npm install
npm run dev:server

@tsioap Refering to the PR - this is not only about the directory separator. I've just clone this repo, and npm start didn't work - because the bash command was not found (it is installed though). I'm not sure what scripting language to use for cross-platform purposes. Since NodeJS must be installed, maybe dev.sh could be converted to a JS script? Or maybe inline it completely into package.json?

As a sidenote, maybe a CI job running on windows could take care that some scenarios do not break to begin with.

  Long time no see.

Ah, I understand now. I did work for me because I use Git Bash for Windows. I agree a Node script would be the best choice to make it cross platform regardless of terminal used, I'll look into converting it.

Thanks @tisoap.  Feel free to update the existing PR or open a new one if you prefer.

@nicolodavis thanks - hope that I can contribute on a somewhat regular basis. Let's see how things are going.

Your contributions are much appreciated.  As always, the current areas of focus are documented in the roadmap.  The large ones are the ability to add bots to games, the game lobby and the Svelte migration.


MSAL authentication is not working with "Connected to Windows" Account

Please follow the issue template below. Failure to do so will result in a delay in answering your question.

Library

[x]<EMAIL_ADDRESS>or<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[x]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>
Important: Please fill in your exact version number above, e.g<EMAIL_ADDRESS>Framework
Angular 8.2
Description
"Connected to WIndows" Accounts are not logging in anymore
Issue Description
The authentication using msal was working for "Connected to Windows" Accounts (Work or school) before. But after we updated "account type" in Azure AD app registration from : "Accounts in any organizational directory (Any Azure AD directory - Multitenant)" to : "Accounts in any organizational directory (Any Azure AD directory - Multitenant) and personal Microsoft accounts (e.g. Skype, Xbox)" , the authentication is not working anymore. If we try with any other account (which is not connected to windows), login is working fine.
Error we are seeing in console:
“Connected to windows” scenario : we are getting InteractionRequiredAuthError
main-es2015.87e6231bd65afafe96ac.js:1 acquireTokenFailure InteractionRequiredAuthError:

Browsers/Environment

[x] Chrome
[ ] Firefox
[ ] Edge
[ ] Safari
[ ] IE
[ ] Other (Please add browser name here)

Closing as duplicate of #2672


Added Python 3.4 and 3.5 to the classifiers in setup.py

It seems that somebody forgot to keep the compatible Python versions listed in setup.py up to date. Python 3.5 is already out, and the tests are already performed and pass there. However, in setup.py, Python 3.3 is the latest version listed.

Thanks!


fix: ldap type ad search user group when nested groups

Hello,
We use an AD with nested users group for groups ADMIN, OPERATOR and USER.
Current code will find a user with searchFilter on the 3 groups but it will failed when looking on memberOf attribute, because it do not contains nested groups.
The current fix will work in this case but will do 3 requests max.
We could filter nested groups of the user but we would need to changes settings to introduces a base dn on groups.
I think its better for moment to make more requests to ldap than introduces breaking changes
What do you think about that ?

 But i'd prefer to do extra requests as a fallback:

We run the initial request to find the user
If there's an answer, it means that the user is in one group or subgroup
Then you can test if any of the 3 groups is in memberOf attribute
If not, do extra requests to requests until matching the highest group

You can add extra elif clauses instead of replacing them, and also only set the role inside all these tests and have a single declaration for the logger, but after the final else clause if no match is done.
I think that the user_ad_member_of tests are not working as we we should not arrive in the final else clause in this case, but it's late. Can you check it as well ?
Thank you for submitting !

Hello
I finally found a solution to avoid performing multiple queries. The current code is really hard to read.
I was thinking of exporting all LDAP related queries to powerdns admin/lib/ldap utils.py files and when possible reuse connection.
What do you think about that ?
Do you prefer a update only with solution for this issue or can i integrate files changes for better readbility ?

Hello,
Can you push updated code as-is first ? I'll take extra time to check the whole code around in the weekend and give you an answer about exporting the code to a library.
Thank you

There is no coding rules here so the it is made of different portions written by users with different experience in programming. I'm considering hardening this in a later version, if it happens someday, built from a shiny new blank repository (but the road to this is a hell of a long way).

@jbe-dw I hope i understand your review. I did otherwise. I am doing a search for available security groups of which the user is a nested member. Then I look at the presence of the groups by importance of roles. This way we make a single request.
Regarding testing, i test my changes on a microsoft active directory. I didn't see unit testing about ad but let me know if miss something.
Regarding the style of code, I noticed it was very different from place to place. For my part on my python projects, I use black to avoid to much different coding styles. Let me know if you prefer that i replace double with single quotes, etc.

@jbe-dw If you are interested in moving ldap code outside of the user model. I pushed a branch on my repository where I did this work. It's not fully tested but it gives an idea.
https://github.com/melck/PowerDNS-Admin/tree/move-ldap-to-lib

The other maintainers are not back from summer break yet, so let's keep the in code version and save your proposal for the v2 with later refactoring.
I'll take some extra time to test it here before validating this one, but the code looks ok to me.

Thanks @jbe-dw,
I'll be happy to contribute if you want help for a v2. Do you have a issue on that ?

Thank you for the proposal. I'm alone for now and quite busy with structural changes in my company. Our plan was to get a fixed version of PDA before trying to work on v2.
Sometimes I'm eager to start it to work on a fresh clean codebase but working on it on my own is far from realistic. I'm thinking about the new architecture (not quite far from what it is now, still based on flask/SQLa). There will be a core application with a rethought API, handling almost all existing features but also multiple backend / authentication backends support, and a separate GUI dialoging with the API.
I'll ping you when it will start but honestly I can't tell you when (you could have moved on to something else then or stopped using PDA).
For now I'll take the necessary time to check and merge your code as soon as I can.
Regards

Any eta on when this will be implemented? Currently using an older version and cannot update until this is fixed.

@AzorianMatt does this one need to be rebased off dev? I happen to have a nested LDAP directory I can test out on if testing is still needed.

@nkukard it needs rebased and properly tested to ensure that it doesn't break the current functionality of the feature. I wish I knew more to tell you on this, but it's another feature I'm not intimately familiar with. If you have the capacity and environment to do so, it would be very much appreciated!

@nkukard it needs rebased and properly tested to ensure that it doesn't break the current functionality of the feature. I wish I knew more to tell you on this, but it's another feature I'm not intimately familiar with. If you have the capacity and environment to do so, it would be very much appreciated!

No probs, I'll check it out.

I'll be testing this hopefully in the next few hours, terribly sorry for the delay :)

Tested and confirmed working with nested groups. +1 for merge from me.


Cache preservation in preserve viewport mode

Hi,
I am loading multiple, focally stacked images that I keep in sync by using
preserveViewport: true,
sequenceMode: true,
Switching from one image to the other works great, however cache of the current image seems to be wiped out after I navigate to a new image.
Example.

Start. It takes a while to load the image 1. As expected.
Switch to image 2. It takes couple of seconds to load. As expected.
Switch back to image 1. It takes couple of seconds to load. Not expected.

Is there any way to keep Image 1 in cache so when I switch from 2 to 1, it gets displayed instantaneously?
BR
Jarek

Hmm... it does seem like we might as well keep the old image cached as long as there's still room. This could be a possible enhancement.
Meanwhile, another way to approach your scenario is instead of using sequenceMode, load all of the images into the same viewer at once but hide all but one (by changing their opacity to 0). When you want to switch images, just adjust the opacities. This should avoid the cache flush, and also keeps the viewport preserved. It also allows you to do things like fades between images, and preloading the tiles for the next image.

That sounds like a great idea. Thanks. Could you please give me a pointer on how to load all of the images into the same viewer?
BTW. The library is pretty awesome. Great job!
From: Ian Gilman<EMAIL_ADDRESS>Sent: Monday, 23 January 2017 9:54 AM
To: openseadragon/openseadragon<EMAIL_ADDRESS>Cc: Piotrowiak, Jarek<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [openseadragon/openseadragon] Cache preservation in preserve viewport mode (#1109)
Hmm... it does seem like we might as well keep the old image cached as long as there's still room. This could be a possible enhancement.
Meanwhile, another way to approach your scenario is instead of using sequenceMode, load all of the images into the same viewer at once but hide all but one (by changing their opacity to 0). When you want to switch images, just adjust the opacities. This should avoid the cache flush, and also keeps the viewport preserved. It also allows you to do things like fades between images, and preloading the tiles for the next image.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openseadragon_openseadragon_issues_1109-23issuecomment-2D274564786&d=DwMFaQ&c=YEQWdgm3lcu5w_Y3fWOQZUGtAhl_lImuPlnxuD4zIqo&r=tRFhgi94K3Rah8G-SuWYYlwHkhKc8Y6gQ93xlSOUQyE&m=_hz1fXDIT6rQpoyVxWDZOgHMloxCgg7NGQN1cDUs7HA&s=5luacRWcx9P73zpSb7LmhKFchd6grbw38rAMTXrFIcw&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AYFfFJfGWavZFqIwBHUT4gcP5ob8U8iAks5rVOlSgaJpZM4LpxYq&d=DwMFaQ&c=YEQWdgm3lcu5w_Y3fWOQZUGtAhl_lImuPlnxuD4zIqo&r=tRFhgi94K3Rah8G-SuWYYlwHkhKc8Y6gQ93xlSOUQyE&m=_hz1fXDIT6rQpoyVxWDZOgHMloxCgg7NGQN1cDUs7HA&s=daWlzAxVI1_ISYzUSvA7thFURxDhuWarh0AuVW_V34U&e=.

Please be advised that this email may contain confidential information. If you are not the intended recipient, please notify us by email by replying to the sender and delete this message. The sender disclaims that the content of this email constitutes an offer to enter into, or the acceptance of, any agreement; provided that the foregoing does not invalidate the binding effect of any digital or other electronic reproduction of a manual signature that is included in any attachment.

It's basically what you're already doing; just don't turn sequenceMode on. You'll need to position all the images (by default they are stacked on top of each other), and of course control their opacity. You can get access to the images via viewer.world. Here's some more info on multi-image:
http://openseadragon.github.io/examples/multi-image/
...and you'll probably need to learn a little more about the OSD coordinate systems:
http://openseadragon.github.io/examples/viewport-coordinates/
Here's an example with two images that can toggle with a fade:
http://codepen.io/iangilman/pen/YXRLea


[enhancement] Send client IP to Radius server

Hi,
Here's an enhancement request.
it would be nice to have an option so that SoftEtherVPN, when configured to authenticate using Radius, would send the client IP through its request to the Radius server.
This could really help in some situations / some configurations where client IP is desirable at Radius level.
There's already an option to send the Hub name as the NAS-Identifier, should then be (well IMO :) something achievable.
I'm however not sure how technically...
Finally, I would really be glad to see such an enhancement in the stable version :)
Thank you very much 👍

Finally we already have this, in both Tunnel-Client-Endpoint and Calling-Station-Id Radius values 👍
Closing this then, thank you !


npm install error

Hi, when I run npm install with '"gulp-iconify": "^0.5.0"' in my dependencies I get the following error:
Error extracting /Users/jamesnock/.npm/fs/0.0.0/package.tgz archive: ENOENT: no such file or directory, open '/Users/jamesnock/.npm/fs/0.0.0/package.tgz'
When I inspect the contents of '/Users/jamesnock/.npm/fs/' I have a folder named '0.0.2' rather than '0.0.0' which is causing the issue. Any ideas on how to fix?

@JamesNock could you check whether v0.6.0 solves this for you (it should)? Thnx!

Fixed it! Nice one @gavro


The project introduction is free and open source, but the official website shows that it is paid. Do I have to pay if I use this project in a production environment?

The project introduction is free and open source, but the official website shows that it is paid. Do I have to pay if I use this project in a production environment?

If you use FastReport OpenSource, not to be confused with FastReport .NET/Core, then this license applies to this product.
For the differences between FastReport OpenSource and FastReport .NET/Core, see the link.


Add table CRUD smoke tests for Polaris

Additionally, a few minor fixes for issues found during testing.

What were the issues fixed?

What were the issues fixed?
They were mainly around ensuring parity with the existing behavior when storing iceberg metadata in HMS like:

If the proposed metadata location as the existing one, we no longer throw a PreconditionFailedException.
If the existing metadata location is no longer valid, prevent the table commits from moving forward.
Ensure the exception types thrown (InvalidMetaException vs ConnectorException) match what we had before in HMS.


Added Type enum in order to support live streams

The mkvparser seems to have been designed with only file based
streams in mind. So it has an issue where it will just continually
load new Clusters, which when streaming a live stream this has the
potential to just go on forever.
Added a Type enum to make it possible to have it load only one Cluster
at a time.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Alex Pecoraro seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Add SwiftLint

Feature: Hello, I added SwiftLint, I didn't change the code just tweak it.

Hi, @joaolfp Thanks for it.
SwiftLint is super useful when coordinate big number of collaborators to work together. However, in a project at Kingfisher's scale, I guess it is a bit like shooting a fly with rifles. It brings a potential external "dependency" to keep working, while only very few can get benefit from it.
So I am not a fan of introducing it to the repo now. Thank you for your work but I am closing this PR. Please feel free to let me know if you are willing for more discussion. :)

Hola @onevcat. Okay but do you want me to delete SwiftLint and leave only the code tweaks?

Ummm..I like some of these changes, for example, removing a duplicated space is really nice. But others, for example, the new line brace after multiple-lines function declaration (like this) is in fact intended. So these changes here are not all ideal for me. :( (Sorry for my personal preference)
Enforcing code format or style without a linter is also little meaning. Again, it is really nice for a tightly connected team (such as in a company and working together to build an app), but for an open source library project, I want to choose a more free style. So please just leave them as is now.
If one day I changed my mind, I guess I will remember this PR and box my own ears 😂


Link for downloading vgg unavailable

Hi,
The link https://bethgelab.org/media/uploads/pytorch_models/vgg_conv.pth from the shell script is currently unavailable. Is there any other way to download it?
Thank you in advance!

I am getting the same error. I found another project that trained the same model:
https://github.com/paniabhisek/VGG
**but, it is in TensorFlow and this is in PyTorch.

Thanks for letting me know - should be fixed now!

It works! However, just an FYI, the cert for the website is expired.


Fix frontend-proxy crashing when using start-minimal

Changes
When using make start-minimal I was hitting an issue where the frontend-proxy container would start but then continually crash and restart with the following exception:
2024-11-06 17:03:02 [2024-11-06 22:03:02.686][8][critical][main] [source/server/server.cc:414] error initializing config '  envoy.yaml': Proto constraint validation failed (BootstrapValidationError.StaticResources: embedded message failed validation | caused by StaticResourcesValidationError.Clusters[5]: embedded message failed validation | caused by ClusterValidationError.LoadAssignment: embedded message failed validation | caused by ClusterLoadAssignmentValidationError.Endpoints[0]: embedded message failed validation | caused by LocalityLbEndpointsValidationError.LbEndpoints[0]: embedded message failed validation | caused by LbEndpointValidationError.Endpoint: embedded message failed validation | caused by EndpointValidationError.Address: embedded message failed validation | caused by AddressValidationError.SocketAddress: embedded message failed validation | caused by SocketAddressValidationError.Address: value length must be at least 1 characters): static_resources

But make start would be fine. Looking at the differences between the two it seemed to come down to the FLAGD_UI_HOST + FLAGD_UI_PORT env vars not being passed to the container in the minimal setup, when these are blank envoy complains because this block in src/frontendproxy/envoy.tmpl.yaml ends up rendering with invalid values:
    - name: flagdui
      type: STRICT_DNS
      lb_policy: ROUND_ROBIN
      load_assignment:
        cluster_name: flagdui
        endpoints:
          - lb_endpoints:
              - endpoint:
                  address:
                    socket_address:
                      address: ${FLAGD_UI_HOST}
                      port_value: ${FLAGD_UI_PORT}

Worth noting that a colleague of mine was able to run make start-minimal on their machine without issue, not really sure what would cause this to only happen in some environments since I would think everything is being isolated by the docker setup but it seemed safe to make this change in all cases especially since FLAGD_HOST + FLAGD_PORT were already being set for frontend-proxy in docker-compose.minimal.yml
Merge Requirements
For new features contributions, please make sure you have completed the following
essential items:

[ ] CHANGELOG.md updated to document new feature additions
[ ] Appropriate documentation updates in the docs
[ ] Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

Thank you @jpmunz 🌟


Split the repo to two: Jekyll & Docusaurus

We have one repo of the wechaty.js.org for both the Jekyll & Docusaurus system and are using the build process to merge all the artifacts built to the same webroot folder, to serve our users.
However, from today's perspective, the repo has been grown bigger and bigger, and the build time for the huge repo is going to be slower and slower.
So we decided to split this mono-repo into two:

Jekyll - https://github.com/wechaty/jekyll
Docusaurus - https://github.com/wechaty/docusaurus

Jekyll
Folders and files:
$ ls
2016  2018  2020  2022        assets  buy-me-a-coffee.html  contact.html  feed.xml  manifest.json  privacy-policy.html  service-worker.js   sw-register.js
2017  2019  2021  about.html  blog    categories.html       contributors  Makefile  news           robots.txt           sitemap-jekyll.xml  tags.html

Docusaurus
To be list

Implemented and has been updated online today:
https://github.com/wechaty/wechaty.js.org/blob/7caed0beee5b8092bc8f16a016f5e9fc7c525b3a/nginx.conf#L23-L51

It seems that everything works as expected.
 #
 # Web Root
 #
 location / {
   try_files $uri @jekyll @docusaurus;
 }

The above Nginx location settings will help us to return files we are not sure where they are: the proxy will try both @jekyll and @docusaurus named locations.
For example, the below links both work for now:

https://wechaty.js.org/sitemap-jekyll.xml
https://wechaty.js.org/sitemap-docusaurus.xml

The real URL of the above files are:

https://wechaty.github.io/docusaurus/sitemap-docusaurus.xml
https://wechaty.github.io/jekyll/sitemap-jekyll.xml