Sign Transaction Protocol implementation - Related to#799

This feature is to allow author to send the transaction request to Endorser for signature and write to ledger.
This PR is related to a previous one #799
Below are the related details :
#736
https://hackmd.io/5LzMhfsMQBevB5V2tKz4hA?view
#836
It contains changes in connection metadata, connection manager and routes. Also added handler and a new message type for sending role to another agent.
A new module is added "endorse_transaction"

Codecov Report

Merging #870 (e151480) into master (b2ab799) will decrease coverage by 3.52%.
The diff coverage is 6.34%.

@@            Coverage Diff             @@
##           master     #870      +/-   ##
==========================================
- Coverage   97.38%   93.86%   -3.53%
==========================================
  Files         297      316      +19
  Lines       16459    17121     +662
==========================================
+ Hits        16028    16070      +42
- Misses        431     1051     +620

One additional point for discussion (@swcurran @andrewwhitehead ) should we have a new aca-py argument to enable the new endorser functionality?  e.g. "--enable-transaction-endorser"

One additional point for discussion (@swcurran @andrewwhitehead ) should we have a new aca-py argument to enable the new endorser functionality?  e.g. "--enable-transaction-endorser"

Hey @HarshMultani-AyanWorks this looks pretty good!  I was able to get most of the way through the process, some documentation would be good ;-)
What I did:

started the Alice and Faber demo's and completed the connection between the 2 agents
add a new public DID for Alice (so she could be the endorser) (also added this DID to the ledger)
Set the Alice connection to Endorser and Faber to Author
Faber - created a new schema with "auto-endorse = False" (returned transaction id)
Faber - created a request (attach this transaction request to the Alice connection)
Alice - view and endorse the request
Faber - confirm that the endorsed request was received

I have some more requested changes, but let's try to schedule a call and discuss these before we do more work, I'd also like to get @swcurran on the call for his perspective.
My feedback:

I find the terminology a bit confusing around setting the "set-transaction-jobs" endpoint (I would use "roles" rather than "jobs" but I think we already decided not to use the word "roles"?)
I think the endpoints like create schema, create cred def etc should just return the un-signed transaction, not return a full endorser structure (this binds these methods too tightly to the endorser protocol as implemented by aca-py) and should also not automatically save the transaction.  I think the /transactions/create-request endpoint should take the json structure as an attachment, so the author would have to:

call (for example) create schema and get the ledger transaction info
create a json structure to pass to the /transactions/create-request endpoint (with the ledger transaction as an attachment)
call the /transactions/create-request endpoint and pass this structure - this will create the transaction record in the aca-py database and send the message to the endorser
etc ...

I couldn't figure out how to write the transaction to the ledger once I got it endorsed (i expected a /ledger/write-transaction endpoint (or something like that)

Hey @HarshMultani-AyanWorks this looks pretty good!  I was able to get most of the way through the process, some documentation would be good ;-)
What I did:

started the Alice and Faber demo's and completed the connection between the 2 agents
add a new public DID for Alice (so she could be the endorser) (also added this DID to the ledger)
Set the Alice connection to Endorser and Faber to Author
Faber - created a new schema with "auto-endorse = False" (returned transaction id)
Faber - created a request (attach this transaction request to the Alice connection)
Alice - view and endorse the request
Faber - confirm that the endorsed request was received

I have some more requested changes, but let's try to schedule a call and discuss these before we do more work, I'd also like to get @swcurran on the call for his perspective.
My feedback:

I find the terminology a bit confusing around setting the "set-transaction-jobs" endpoint (I would use "roles" rather than "jobs" but I think we already decided not to use the word "roles"?)
I think the endpoints like create schema, create cred def etc should just return the un-signed transaction, not return a full endorser structure (this binds these methods too tightly to the endorser protocol as implemented by aca-py) and should also not automatically save the transaction.  I think the /transactions/create-request endpoint should take the json structure as an attachment, so the author would have to:

call (for example) create schema and get the ledger transaction info
create a json structure to pass to the /transactions/create-request endpoint (with the ledger transaction as an attachment)
call the /transactions/create-request endpoint and pass this structure - this will create the transaction record in the aca-py database and send the message to the endorser
etc ...

I couldn't figure out how to write the transaction to the ledger once I got it endorsed (i expected a /ledger/write-transaction endpoint (or something like that)

It's looking good to me. It seems a bit odd to have auto_endorse options defaulting to true and overridden with false, rather than having the option opt-in to the much less common option of requesting signatures from other parties. I'm not sure what the option would be called if reversed though. as_transaction maybe?

It's looking good to me. It seems a bit odd to have auto_endorse options defaulting to true and overridden with false, rather than having the option opt-in to the much less common option of requesting signatures from other parties. I'm not sure what the option would be called if reversed though. as_transaction maybe?

Hey, I am quite out of the loop but I had a scan over the protocol in the branch and am wondering if there is also the intention to define the more generic "please sign this" protocol as it is described in the HackMd.
I would also be interested in any thoughts on how this could also be used to allow me to request my agent to please sign this. I.e. if I had a public DID. Although I think in the future the crypto API's could be tweaked to support group signatures from base credential objects which would be cool.
E.g. please sign this article I have written using the credential that proves I am an epidemiologist or whatever.
Note: I don't necessarily want to send this to anyone rather I might want to publish it on the internet for anyone to check.

Hey, I am quite out of the loop but I had a scan over the protocol in the branch and am wondering if there is also the intention to define the more generic "please sign this" protocol as it is described in the HackMd.
I would also be interested in any thoughts on how this could also be used to allow me to request my agent to please sign this. I.e. if I had a public DID. Although I think in the future the crypto API's could be tweaked to support group signatures from base credential objects which would be cool.
E.g. please sign this article I have written using the credential that proves I am an epidemiologist or whatever.
Note: I don't necessarily want to send this to anyone rather I might want to publish it on the internet for anyone to check.

Hi @wip-abramson , the underlying protocol (agent-to-agent) implements the generic "please sign this" protocol, however the aca-py admin api is specific to endorsing indy transactions to write to the ledger.  There is an RFC in progress that focuses on the generic agent-to-agent protocol.
To support the more generic use case that you suggest would require an additional admin api (or set of api's) to expose the more generic functionality.

There is still some outstanding work, but I recommend we get this PR merged and create tickets for any outstanding tasks.  (Some tasks will require review/discussion.)

naming of “set-transaction-jobs” endpoint and parameters
naming of the “auto-endorse” parameter
include endorser DID as connection meta-data?
cleanup/re-factor the code to save the non-secrets records
review messages vs the draft RFC
general code review for new/updated methods


Question about GPT-3 performance

FasterTransformer is great job. I want to ask some question about the GPT-3 benchmark.

How are these performance of  GPT-3 (175B, 89B, 20B, 6.7B,1.3B...) tested?  Is it based on the real models? Which scripts was used?

How to test Megatron performance? Are the test scripts available to users?

It is tested by random model weight. We launch the triton server and measure the time of queries with different batch size and sequence lengths. More details about setting triton server are in https://github.com/triton-inference-server/fastertransformer_backend. You can get close results by examples of this repo directly.
You can refer and ask in Megatron-LM repo. We modified the evaluation scripts provided in Megatron-LM at the time. But we don't have these scripts in FT repo now.

About 1, if just test on one machine, still need to use Triton?

The example is only tested on c directly. It does not contains the overhead of send/recv for serving.

Close this bug because it is inactivated. Feel free to re-open this issue if you still have any problem.


CopilotTextarea: auto-populate button

Is your feature request related to a problem? Please describe.
Create a button to auto-populate textarea.
Describe the solution you'd like
Simple button to pre-populate the textarea contents.
Similar to LinkedIn messages

Describe alternatives you've considered
Future iterations can include an editable prompt bar for the content to generate.
Additional context
Add any other context or screenshots about the feature request here.

hello @ataibarkai  Can you pls assign this project to me, I want to work on this project.


[feature request] allow np.arrays as values to the logger

In some cases it is helpful to log a vector to the kv logger. For example, I wanted to log mean action vector and a mean position vector.
I'm not sure how this should be handled by tensorflow logger, but for json and stdout  loggers there is an obvious formatting.

Hello,

In some cases it is helpful to log a vector to the kv logger.

If I understand well, this feature is only aim at custom version of stable-baselines? (installed from source and modified).

It is useful also from custom environments. I am using it to log some additional details about the environment to help with debugging. They to need be reported at the same frequency and also benefit from the averaging.

It is useful also from custom environments.

Ok, in that case I think that is a small but nice to have feature.


check-ttf.py: new check, check_glyphs_have_correct_contour_count

This check will test whether a glyph has the recommended number of contours.
The glyph data which contains the recommended contour count was compiled from a host of decent fonts.
if a glyph's contour count does not match the recommended quantity, the test will return a warning message, instead of an error. This is because display and script typefaces character construction can vary greatly. A similar check is 'points on extremes' which also only returns a warning.
If we like the test, I'm more than happy to do a cleanup and maybe move the glyph_data.json file to a better location.
I've used this check on the whole collection and its been a life saver.

Looks like an awesome idea, especially if it works good enough then WARNING is fine.
First thoughts:
Now all the magic is basically hidden in bin/glyph_data.json and there's no way for anyone else to understand how this works. We should have the code and documentation how to create/re-create that glyph_data.json file.

and maybe move the glyph_data.json file to a better location.

Absolutely! bin/glyph_data.json is basically a lookup table, it is much more like function than a piece of data. Thus, the file should be located in Lib/fontbakery Also, probably cool would be to make it a module with a little function as interface. The data could either be next to the module as modulename.json or even better, a generated python file that has a hardcoded dictionary included(would probably reduce load times). Either way, we wouldn't have to parse glyph_data.json freshly for each time the test is executed (373 KB) but just once on the first import.
BTW: the bin directory is used for executables i.e. things to be called from the command line and such.

Love it, please do!

Hey @graphicore,
Thanks for the summary. I agree with everything. I just needed to write this test to quickly check the state of the collection. The polish is definitely lacking. I didn't want to push it too far since you're improving the architecture.
Yes, it would be nice to have it as a separate module which only needs to get called once.
@davelab6 shall I continue to devote a little more time to this?

Yes please polish it up.
On Jun 23, 2017 4:03 AM, "Marc Foley"<EMAIL_ADDRESS>wrote:

Hey @graphicore https://github.com/graphicore,
Thanks for the summary. I agree with everything. I just needed to write
this test to quickly check the state of the collection. The polish is
definitely lacking. I didn't want to push it too far since you're improving
the architecture.
Yes, it would be nice to have it as a separate module which only needs to
get called once.
@davelab6 https://github.com/davelab6 shall I continue to devote a
little more time to this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/googlefonts/fontbakery/pull/1387#issuecomment-310600132,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAP9yxq8lSALWelq2475Ml0tbeCo99Tjks5sG3FFgaJpZM4OCQ6w
.

Ok, moving this forward I propose the following:

Tidyup glyph_data.json script – doc strings, refactor, remove links to local files and download them from source
Documentation. Have we started a readthedocs for this project yet?
Move glyph_data.json out of bin dir
refactor and clean up test so it complies with the new rewrite. It should also take into consideration Lasse's review.

Documentation. Have we started a readthedocs for this project yet?

Nope.

refactor and clean up test so it complies with the new rewrite.

I'd love to see that, you could use the new test style (example) as well, rather than the old style adapter (example), but that's not terribly important.

@m4rc1e Please ping me whenever you wish to get this reviewed for merging. At the moment (based on the conversation with Lasse above) it seems it's not ready yet for review. Correct me if I'm mistaken.

@felipesanches I've been polishing it on and off for the past week. It still needs more tlc before we'll be happy with it.

ok, cool. Let me know whenever you request a review&merge.

@m4rc1e do you think you'll be able to ready this PR for merge this week?

@m4rc1e we've got the new-arch giant pull request merged (#1452). Let me know if you need some help to get this ported into the new-style test infrastructure.

@davelab6 this is hopefully the aim. I've been working on it on and off. The pr is quite substancial in order to make it work.

Closing because this was made for the old architecture. #1468 addresses this.


redesign the whole site!

I don't think it's an issue if it's the whole point of this project...

and i guess we did it?
looks better then the old one ill tell you that
Ex-ce-pt for one thing, roles. lets add roles to the site under the team members page, as in have it like
Sourena
Charlieeeee you cant copy that much html
front end dev
something like that?

is the site done? because all ive seen is just me adding new keys to the openstudiocorpprojects.json file?

Reference in ne

do you think it's time to rewrite the Readme?
oh and rename the Repository to something like
OpenStudioCorp, or just OpenStudio?

Damn I am receiving so many mails now lol
On Wed, 15 Nov 2023, 08:49 Charlie, @.***> wrote:

Reference in ne
do you think it's time to rewrite the Readme?
oh and rename the Repository to something like
OpenStudioCorp, or just OpenStudio?
—
Reply to this email directly, view it on GitHub
https://github.com/OpenStudioCorp/NewOpenStudioCorpSite/issues/4#issuecomment-1811895818,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3YBWGXZ5HKWQ6X3O4ZHSPTYERQYPAVCNFSM6AAAAAAZ4RAUYKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJRHA4TKOBRHA
.
You are receiving this because you were assigned.Message ID:
@.***>

ahhahahha lol

Well I am glad the email function is working good
On Sun, 19 Nov 2023, 15:00 Charlie, @.***> wrote:

ahhahahha lol
—
Reply to this email directly, view it on GitHub
https://github.com/OpenStudioCorp/NewOpenStudioCorpSite/issues/4#issuecomment-1817848445,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3YBWGWSJ2ZMRC5KOWGVCD3YFH7HVAVCNFSM6AAAAAAZ4RAUYKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJXHA2DQNBUGU
.
You are receiving this because you were assigned.Message ID:
@.***>

with all responsibility comes an end. we have finished the site!!!!
now this doesn't mean that we wont have fixes for it and stuff, there's going to be a load of those probably forever.
thanks to everyone who has worked on this, for now though i'm going to have to close this with a comment.
if needed in the future, feel free to open this again for anything we have missed.
i'm going to allocate all the resources on this project to the CubeScript website built with the same techstack but having astro as the front end. Take care!


Add documentation on how to upgrade the eks version

It would be great it the docs would contain a section on how to upgrade the EKS version of an existing cluster.
F.e. if it's necessary to upgrade the version via the UI first and then set the version in terraform as well, or if it's sufficient to set the version in terraform and that the module will automatically do the upgrade - and not rebuild the cluster from scratch.

https://docs.aws.amazon.com/eks/latest/userguide/update-cluster.html
You can simply change the cluster version in the module definition - by default, the control plane will update first followed by the data plane (nodes)

Thank you for the fast information!


Volume Buttons blocked?

Hi,
just downloaded the unity SDK. Works great so far. Tho, when using the cardboard sdk plugin, the phones volumes buttons are actually not usable anymore, anyone knows how to fix it? (Im using Unity 5.1.2)

Found the "issue"

How did you solve it?

I didnt solved it, it wasnt a bug. Google want the volume buttons to be blocked. I just switched to another SDK, to "solve" it :)

Yeah, the volume keys get turned off because when the phone is encased in Cardboard, just holding the outside a little tight can push activate them by accident.  How bad it is depends on which viewer and which model.
But if you touch the gear button, then the volume keys become active again till you press Cancel and go back to the game.


Option to detect virtualhost

In the readme file, its mentioned that several subdomains which resolve to single IP Address would then classify.

Use the -rS argument to automatically classify it, check this image ~


Issue-333 Polished up formatting UI, added docs, removed featured flag

@ud3sh this new formatting system is amazing! I'm adding in some more built-in formats and the flexibility/customization of the formats is phenomenal

Looking forward to seeing them!   If we are levering alternate formatting for axis labeling widely we may want to think about how we should present that in the UI (if at all).
PS: Custom functions (that don't use codes) can be done in easily in theory if we need them.  Tricker part would be presentation.


update asmjit, fbgemm, polyhook2, start asmtk

As per https://github.com/microsoft/vcpkg/pull/27476#issuecomment-1302647574
This:

Removes fbgemm (for now)
Updates asmjit
Updates polyhook2
Attempts to add asmtk

AsmTk currently doesn't correctly link asmjit and I'm not sure exactly why. So that needs to be fixed by someone, then polyhook2 should build after that (or at least be close, asmtk probably needs adjusted first).

Pinging @stevemk14ebr for response. Is work still being done for this PR?

Yes, but I need help. Asmtk currently doesn't link to asmjit correctly and I'm unsure how to fix.

@stevemk14ebr I will pay attention to and deal with this PR. :)

You're the best, thanks for the help! If the linking issues with asmtk and asmjit can be fixed this will be very close to ready to merge.

@FrankXie05 Any news?

Can something be done about it?

The latest version of fbgemm seems to work if I copy the changes made to CMakeLists.txt in the old patch file. See https://github.com/cbrl/vcpkg/commit/b9a47076188f93118c44d2cdde060d98e20836d5 for reference, but note that that branch doesn't include the required update to asmjit. I think the reference change can be included in this PR rather than removing fbgemm.

Sorry, it took so long to follow this PR.
I have resolved the issue with error LNK2019 and have been keeping an eye on completing this PR. :)
@stevemk14ebr @Chlumsky

We need to find a compatible method instead of removing port fbgemm. 🤔

Revert fbgemm.

E:\NEW-PORT\vcpkg\buildtrees\fbgemm\src\86cd37ac2a-f4be5156b3\include\fbgemm\./Utils.h(91): error C2872: 'x86': ambiguous symbol
E:\NEW-PORT\vcpkg\buildtrees\fbgemm\src\86cd37ac2a-f4be5156b3\include\fbgemm\./Utils.h(18): note: could be 'asmjit::x86'
E:\NEW-PORT\vcpkg\installed\x64-windows\include\asmjit\x86/x86instdb.h(11): note: or       'asmjit::_abi_1_9::x86'

E:\NEW-PORT\vcpkg\buildtrees\fbgemm\src\86cd37ac2a-f4be5156b3\include\fbgemm\./Utils.h(91): error C2872: 'x86': ambiguous symbol
E:\NEW-PORT\vcpkg\buildtrees\fbgemm\src\86cd37ac2a-f4be5156b3\include\fbgemm\./Utils.h(18): note: could be 'asmjit::x86'
E:\NEW-PORT\vcpkg\installed\x64-windows\include\asmjit\x86/x86instdb.h(11): note: or       'asmjit::_abi_1_9::x86'

Have been fixed by updating the fbgemm version to 0.4.1.

Thanks for the update!

@stevemk14ebr
Can you please also take care of providing the latest PolyHook2 bug fixed build to vcpkg once again (especially regarding https://github.com/stevemk14ebr/PolyHook_2_0/pull/183)? Thanks


The onehop 'templates' and 'test_triples' folders overlap in contents and purpose

Not quite sure how this arose but there seems to be repo significant redundancy here.

The idea is that we had some code that looked at KP's metaknowledgegraph and create a template that shows what kinds of edges are in a KP, but leave out the particular curies.
Then the KP users take those templates, fill them in. and put them in the test_triples.

Roger that.. sorry... I was a bit slow realizing this. Thanks for the clarification.


feat(store): implements sorting in Postgres stores

What this PR changes/adds
Adds sorting feature to Postgres stores. It translates sortField and sortOrder of QuerySpec into ORDER BY clause
Why it does that
To achieve feature parity and actually support the full DataManagement API at the persistence level.
Linked Issue(s)
Closes #1958
Checklist

[x] added appropriate tests?
[x] performed checkstyle check locally?
[ ] added/updated copyright headers?
[ ] documented public classes/methods?
[ ] added/updated relevant documentation?
[x] assigned appropriate label? (exclude from changelog with label no-changelog)
[x] formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

Codecov Report
Base: 63.63% // Head: 5.51% // Decreases project coverage by -58.12% :warning:

Coverage data is based on head (89d6b1d) compared to base (1daf73d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #2004       +/-   ##
============================================
- Coverage     63.63%   5.51%   -58.13%
- Complexity        0     164      +164
============================================
  Files           772     772
  Lines         16357   16370       +13
  Branches       1055    1055
============================================
- Hits          10408     902     -9506
- Misses         5505   15398     +9893
+ Partials        444      70      -374

Impacted Files
Coverage Δ

...ceconnector/sql/translation/SqlQueryStatement.java
0.00% <ø> (-82.36%)
:arrow_down:

...eclipse/dataspaceconnector/spi/result/Failure.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...clipse/dataspaceconnector/spi/query/SortOrder.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../eclipse/dataspaceconnector/policy/model/Rule.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...pse/dataspaceconnector/spi/event/EventPayload.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...clipse/dataspaceconnector/policy/model/Action.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...e/dataspaceconnector/spi/query/QueryValidator.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ipse/dataspaceconnector/policy/model/Operator.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...dataspaceconnector/spi/observe/ObservableImpl.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...se/dataspaceconnector/policy/model/Constraint.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 524 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Migrate cartlinequantityadjustbutton

Description
Closes #171 by passing in attributes to the SFAPI cartLineUpdate query.
Closes #172 by finishing the migration of these two missing components.
Additional context
I wasn't sure if we are going to run into more issues in the future if we don't pass in the other properties to the CartLineUpdateInput... would like your thoughts if you have them.
Docs preview: https://shopify-dev.shopify-dev-minimal-cdfe.anthony-frehner.us.spin.dev/api/hydrogen-react/components/CartLineQuantity

Before submitting the PR, please make sure you do the following:

[x] Read the Contributing Guidelines
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123)
[x] Update docs in this repository according to your change
[x] Run yarn changeset add if this PR cause a version bump based on Keep a Changelog. If you have a breaking change, it will need to wait until the next major version release. Otherwise, use patch updates even for new features. Read more about Hydrogen React's versioning.

@blittle ready for re-review!


[TC-TSTAT-4.2] Python script needs to be updated with correct PICS code from step 3 to 13.

Feature Area
Other
Test Case
TC-TSTAT-4.2
Description

Currently the python script is skipping all the steps from 3 to 13 due to the wrong pics.
So the PICS has to be updated from TSTAT.S.CFE.Rsp to TSTAT.S.C07.Rsp from step 3 to 13 as per test plan.

Test plan reference: https://github.com/CHIP-Specifications/chip-test-plans/blob/master/src/cluster/thermostat.adoc#tc-tstat-4-2-preset-write-and-command-attributes-test-case-with-server-as-dut

Python script Reference: https://github.com/project-chip/connectedhomeip/blob/master/src/python_testing/TC_TSTAT_4_2.py

Bug prevalence
Whenever I do this
GitHub hash of the SDK that was being used
587665db819a1c95c231f9464699249d15173aba
Platform
raspi
Anything else?
Execution Log: TC-TSTAT-4.2.log
UI Snapshot:

@nivi-apple @cjandhyala  After this PR merge https://github.com/project-chip/connectedhomeip/pull/34890, Python script is skipping the Step 3,  14, 15, 16 due to the wrong PICS. Below change needs to be updated for step 3, 14, 15, 16.

Issue fixed


This selector

Implement a selector similar to $(el).do so we can get the effected element.

You can get the element by $('<selector>:in-viewport') or $('<selector>').isInViewport()


Holacrcy part1

This is the first part of a series of Holacrcy

thx @rbordo - that was extremely helpful.
I have addressed all issues - do you wanna check it again or should I just publish it?


App gives carrier info about sim1 only

My mobile is dual sim, all the features are working fine but it only shows carrier info for sim1 automatically. It would be great if shows the number of sim present and carrier info for each of the available sim.

@vjs3 thats a nice recommendation. I will update it in the next release. Thanks

Sure! I will also try to make some tweaks and send you a PR for some other features once I got the time.

Implemented the functionality in commit 4346f9ca233498f912875732ece84c9b683525ba in develop branch.
Should test a bit more and would release it in the next version.


Fix error view not getting focus on signup screen

Description
MA-2960
#815 added a popup dialog in addition to the field errors. However, it caused a regression in that it
failed to actually focus on the error field, and instead focused on the first visible field instead. This pull request fixes the regression by readding the logic to focus on the first invalid field entry.
An additional redundant call to request the focus on the concerned view that has been added in #815 has also been removed, as well as some minor reordering of the logic to be more consistent.
Reviewers
If you've been tagged for review, please "Start a review" with the GitHub GUI.

 Last update ed3c236...e191340

Will review tomorrow >.<


ADD: Changes to run in ROS2 Humble on Ubuntu 22.04

I will try to modify the code to be compatible with 20.04 and 22.04

I have tested it on 20.04 without any problems. Could you please test it on 24.04

After that, please add your name in Contributors of CONTRIBUTORS.md

Verified in Ubuntu 22.04. It runs all good!
I will also try Ubuntu 24.04, but I think this will be a stretch goal, and will deal with it in another PR.

Thank you for your contribution to this project!


[🐞] Defining and calling $server() function inside onClick$ causes Error: Dynamic require of "_.js" is not supported

Which component is affected?
Qwik Runtime
Describe the bug
Hi,
I am defining a server function inside an onClick event handler and call it below the definition.
import { component$ } from<EMAIL_ADDRESS>import { server$ } from<EMAIL_ADDRESS>
export default component$(() => {
  return (
    <button
      onClick$={() => {
        const serverFn = server$(() => console.log('Hi from server'));
        serverFn();
      }}
    >
      Say Hi!
    </button>
  );
});

In dev mode, everything works perfectly.
But in prod mode, I will get a POST error POST http://localhost:4173/?qfunc=n4X1sOI0zW0 500 (Internal Server Error) with error message saying Error: Dynamic require of "_.js" is not supported.
I was expecting no error, because dev mode works fine and what I did aligns with what Miško did in this video
I found a solution to this issue that might help finding the root cause or a fix.
Basically add another $ to wrap the function assigned to onClick$. But I guess this is not needed as onClick$ should be sufficient already, right? Anyways, hope this helps on debugging, thanks!
    <button
      onClick$={$(() => {
        const serverFn = server$(() => console.log('Hi from server'));
        serverFn();
      })}
    >
      Say Hi!
    </button>

Thanks!
Reproduction
https://stackblitz.com/edit/qwik-starter-qmzrws?file=src%2Froutes%2Findex.tsx
Steps to reproduce

After open the link, the app should be running in dev mode by default
The two buttons work great. Click them and the messages will be shown in terminal
Stop the app and run it in prod mode by npm run preview
The 2nd button still works, but the 1st button doesn't. After click the 1st button, some error messages will be shown in inspect - console

System Info
System:
    OS: Windows 11 10.0.22621
    CPU: (8) x64 Intel(R) Core(TM) i7-1065G7 CPU @ 1.30GHz
    Memory: 2.63 GB / 15.60 GB
  Binaries:
    Node: 20.9.0 - C:\Program Files\nodejs\node.EXE
    npm: 10.1.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Chromium (119.0.2151.72)
    Internet Explorer: 11.0.22621.1

Additional Information
No response

OK, that is very bizarre. Thank you for a simple repro.

Any update on this?

the workaround is just to make sure the functions have $ wrap around them. looking at the build it looks like the server$ is not being output correctly in the server build. @mhevery this seems like an optimizer issue. will this be an issue in v2?

@wmertens it looks like the server$ output is not working unless the handler is wrap in $
this is the output when the handler is wrap in $

we probably use eslint to require $ if server$ (or any other $ is being used) for now

added this to the docs for now https://github.com/QwikDev/qwik/commit/48abd15b4cb738c6e1e20bb544b46652e77ff072

I missed this. This is still a problem in v2 I expect.
I'll take a look this week

yeah I'm fairly certain it's optimizer issue

I have faced this issue on the production env at the version 1.5.6-dev20240611011722
It doesn't occured in dev mode. It has been solved by wrapping by the $

Ok the reason is this: onClick$ will convert the handler to a noopQrl on the server because it can never be called.
However, this happens before the handler is scanned for any other qrls, and so it misses the server$.
The fix is therefore to still process noopQrls to check if there are any server$ calls in there.
However, this needs some care, it's like a double negative, we will now need a list of functions to keep vs a list to convert to noop. This is especially important to get right, to avoid importing DOM-related librairies.
So I'm wondering if we should even support this, and if the eslint rule shouldn't be done instead? @mhevery ?

@wmertens we should support this because calling server$ in onClick$ is used in all examples of server$ and it's the main use-case. Is there any way to process server$ before we convert to noopQrls or just have the optimizer convert everything to $ then it will work correctly? I think eslint is just a workaround until it's automated correctly

@wmertens we should support this because calling server$ in onClick$ is used in all examples of server$ and it's the main use-case. Is there any way to process server$ before we convert to noopQrls or just have the optimizer convert everything to $ then it will work correctly? I think eslint is just a workaround until it's automated correctly

Hi @PatrickJS , I just double checked the bug, it only happens when I define the server function inside onClick. So, if I define the server function outside of it, then it will work on both dev and prod. Please check the updated repro here: https://stackblitz.com/edit/qwik-starter-uqskwo?file=src%2Froutes%2Findex.tsx
When run npm run preview, only the 1st button will have the error (works in dev, has error in prod), both the 2nd one (defining the server function inside onClick with an extra $) and the 3rd one (defining the server function outside of the onClick and only call it inside) work fine on both dev and prod.
So, I think using eslint or something to force the user to define the server function outside of onClick is fine to me as a quick fix.


Feature/installation id manifest

Bringing installation_id back, cause now we could have multiple installation in the UI.
For compatability with old yamls without installation_id, cli, when needed, will request(or create) and save installation_id using deprecated name 'Edge app cli installation'.
So eventually yaml file must have installation_id to work properly.
Other changes

Installation of an app moved from upload to edge app create command.
For some commands now installation_id is required either by passing as argument or in the manifest.

Promote command(to check undefined settings)
All settings commands
Secret set command

TODO: update commands to have only installation_id passed as argument when both are required.


NEON arch: dead ref cycle fix when neon_available_ is ON

NEON arch: dead ref cycle fix: when neon_available_ is ON, the DotProduct global was set to point to DotProduct, which should have been DotProductNative, as DotProduct is the target global itself: see simddetect.h --> effectively making that part of the SetDotProduct() call identical to this (no-op) statement: DotProduct = DotProduct;
Also added the Neon check in the Update() API, where it exists together with the other checks (for AVX/SSE/etc.)

Note: this popped up day before yesterday while I was going through there but had forgotten about this detail until I mixed your work back in. Saw this, then did a quick code review again as I don't have ARM/NEON here, also not as a build target, so this is coded blind. I think I got it right, though. 🤔
If not, apologies!

That's a really important catch which greatly improves the default performance for example on Mac M1 (see updated list https://github.com/tesseract-ocr/tesseract/pull/3486#issuecomment-879394501).

Hadn't realized this would invoke Macs. Thanks for the feedback!
On Thu, Jul 15, 2021, 23:22 Stefan Weil @.***> wrote:

That's a really important catch which greatly improves the default
performance for example on Mac M1 (see updated list tesseract-ocr#3486
(comment)
https://github.com/tesseract-ocr/tesseract/pull/3486#issuecomment-879394501
).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/stweil/tesseract/pull/10#issuecomment-881021907, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AADCIHVN3EMZQQTMJG3LLODTX5GQRANCNFSM5AN3E45A
.


infinitely attempting to connect with nextcloud kdrive

Hello,
When I try to connect to my kdrive ( which is a managed nextcloud instance) using  connect.drive.infomaniak.com (as mentioned in https://www.infomaniak.com/en/support/faq/2409/kdrive-logging-in-to-your-drive-via-webdav) on the les pas first login screen, les pas infinitely attempts to connect and nothing happens (no error message).
I would expect that les pas would connect or throw me an error explaining why I can't connect

Here is my phone config :

I also want to let you know that the official nextcloud app can connect to my kdrive without any trouble.
Thanks for your help

Login to your Nextcloud instance in web browser, select Settings->Mobile & desktop, scroll to the bottom, copy the address listed in 'Server address' section and use this address with Les Pas.

The thing is that kdrive is kind of a fork of nextcloud rather than a pure managed instance. So I can't check what you have proposed.
However, on my android phone I can connect to my kdrive using the official nextcloud app.
If I click on manage accounts in the android nextcloud app, I can see the following working connection :
Username<EMAIL_ADDRESS>(where<EMAIL_ADDRESS>is actually replaced by my true email used as login credential).
I've tried this and also :
102960.connect.drive.infomaniak.com connect.drive.infomaniak.com
But with no difference.
How can we debug this?

to authenticate lespas to your nextcloud server, it use nextcloud ocs login flow, please ask kdrive staff if they support this.

further study on kdrive website, confirm they use different login mechanism which Les Pas doesn't support at this moment.

Hi @scubajeff, finally got an answer from Kdrive. They told me Kdrive is not based on nextcloud anymore...

Hello @scubajeff,
Thank you for your update.
I tried to connect using https://connect.drive.infomaniak.com/ with the release 2.5.5.
I can reach the page and can login to Infomaniak, but after that the app crashes.
When I try to reopen the app it crashes every time.
My phone: Pixel 4a 5G with Android 12

this sounds quite similar to #54

I have sent the crash log by email.

@ThomasDeschler, the mail you sent to me didn't have log attached.

Noted, I have sent a link to download the crash log. I hope this method works.

No more opening crashes with this version.
Thank you!

from the log, i see some other exceptions too. seems like there are restrictions been applied to your kdrive's home folder. can you create new album?

Just release 2.5.5. With this version, I seems to be able to reach the login page of connect.drive.infomaniak.com. You can give it a try.

Wow ! Excellent ! Will try it today

Sadly I can't connect as I got stuck by a bugged Infomaniak page that propose me to choose between one of my drives.
The intefarce is bugged and it's impossible to select a drive. I'll send thema ticket to make things work and  will come back to LesPas.
Will keep you updated

Hi @scubajeff !
Thanks for continuing developing Les Pas. I want to try it again. I'm currently using version 2.9.6 but still can't figure out how to connect to kdrive. Could you show me which URL you use to connect?
Thanks

According to this link https://www.infomaniak.com/en/support/faq/2409/connect-to-kdrive-via-webdav
kDrive is different from Nextcloud in terms of API endpoint and folder structure. Extra works needed to support it. Will evaluate the possibility later.

@pokyah not at all. eventually it's the way to more user installation.

@pokyah Seems like infomanic blocked me from creating kdrive. Unless you could help me setup a kdrive account for testing, I can't do anything.


Fixing #1495 and #1387 AnsiConsole.Write(string value) uses format string

Restore parity between write and write line

fixes #1495 #1387

[x] I have read the Contribution Guidelines
[x] I have commented on the issue above and discussed the intended changes
[ ] A maintainer has signed off on the changes and the issue was assigned to me
[x] All newly added code is adequately covered by tests
[x] All existing tests are still running without errors
[x] The documentation was modified to reflect the changes OR no documentation changes are required.

Changes
Updating Write to be inline with the functionality of WriteLine where string format is only used when an args object array is included in the method call.

Please upvote :+1: this pull request if you are interested in it.

I can see it's a small change, but I haven't reviewed it properly yet.  Added to my queue and I'll see about getting this one over the line for you @BlazeFace. Then I think you won't have any outstanding PR's languishing.  I'll be in touch soon.


fixed renamed options in the command-line examples

Is this being reverted? I could not find commits on cardano-node suggesting this revert?

Perhaps I am using an old version then. Was compiled yesterday. So perhaps the doc is up-to-date but my local cardano-cli isn't.

I didn't notice the doc was updated yesterday on exactly those options. So maybe I am just missing that commit in my current build :shrug:

Yep - its old indeed :)
You might want to ensure you're using pioneer-wave2 tag when compiling


Add common NGSI-LD test suite.

I have added Stellio Broker to the FIWARE NGSI-LD_TestSuite - you can compare the results with Scorpio and Orion-LD.
This PR adds a set of common NGSI-LD compliance tests for your own use.

Loads common compliance tests
retrieves latest docker images
runs tests  - current result here

You'll need to sign up for travis to get it to run obviously.

This is effectively an ACID Test for context brokers. Obviously until each broker achieves full compliance the test suite is designed to fail. To pass as green with partial compliance (and remain useful to you), you will need to exclude failing tests using the EXCLUDED_TESTS env which is a pipe | separated list.
export EXCLUDED_TESTS="003|004|";

Each test is numbered some are not necessary 1.3.1 compliant (e.g. 109). To challenge the expectation of a test just raise an issue here

Ideally the line:
docker-compose --log-level ERROR -f docker-compose/stellio.yml pull --ignore-pull-failures

should be expanded/replaced to use locally created Docker images.

Hi Jason,
First of all, thanks a lot for adding Stellio in the list of supported brokers for the FIWARE NGSI-LD Test Suite.
I'm keeping this PR open while we are analyzing the results, fixing the quick ones, and defining the list of the "expected" fails.
Btw, do you know if there is a way to print the HTTP requests and responses of each test in the suite?

Just look for .toHaveProperty('statusCode', in the test suite: https://github.com/FIWARE/NGSI-LD_TestSuite/search?q=.toHaveProperty('statusCode'%2C&unscoped_q=.toHaveProperty('statusCode'%2C
Easiest way to get more output would be to amend http.js here and add a console statement.


No easy way to combine pages from 2 different apps

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Summary 💡
I want to create a 2-page app. And I want to take page-1 from app-A and page-2 from app-B.
I start to do this:

Duplicate app-A
Reemove all pages other than page-1
But then, I can't get the page-2 from app-B.

As mentioned here https://github.com/mui/mui-toolpad/issues/813#issuecomment-1333802316
if all apps were just single pages, I could have simply made a folder with copies of the pages/apps.
It's low priority for now, we should do this as overall pages revamp.

I see several things here:

Should app consist of multiple pages, or can we simplify them by removing that construct. i.e. 1 app === 1 page
Copy + Paste of Toolpad objects. components, but also pages. Within an application, and across applictaions


Clean up names of callback function typedefs in ssl.h

This was noticed on function callbacks, but it would be good to have consistency in naming (and namespace) for various typedefs.
ssl.h examples:
typedef int (*tls_session_ticket_ext_cb_fn) (SSL *s,
                                             const unsigned char *data,
                                             int len, void *arg);
typedef int (*tls_session_secret_cb_fn) (SSL *s, void *secret,
                                         int *secret_len,
                                         STACK_OF(SSL_CIPHER) *peer_ciphers,
                                         const SSL_CIPHER **cipher, void *arg);
typedef int (*custom_ext_add_cb) (SSL *s, unsigned int ext_type,
                                  const unsigned char **out,
                                  size_t *outlen, int *al, void *add_arg);
typedef void (*custom_ext_free_cb) (SSL *s, unsigned int ext_type,
                                    const unsigned char *out, void *add_arg);
typedef int (*custom_ext_parse_cb) (SSL *s, unsigned int ext_type,
                                    const unsigned char *in,
                                    size_t inlen, int *al, void *parse_arg);
typedef int (*SSL_custom_ext_add_cb_ex) (SSL *s, unsigned int ext_type,
                                         unsigned int context,
                                         const unsigned char **out,
                                         size_t *outlen, X509 *x,
                                         size_t chainidx,
                                         int *al, void *add_arg);
typedef void (*SSL_custom_ext_free_cb_ex) (SSL *s, unsigned int ext_type,
                                           unsigned int context,
                                           const unsigned char *out,
                                           void *add_arg);
typedef int (*SSL_custom_ext_parse_cb_ex) (SSL *s, unsigned int ext_type,
                                           unsigned int context,
                                           const unsigned char *in,
                                           size_t inlen, X509 *x,
                                           size_t chainidx,
                                           int *al, void *parse_arg);
typedef int (*SSL_verify_cb)(int preverify_ok, X509_STORE_CTX *x509_ctx);

I don't think there's any reason to wait for 1.2.0. Removing the old names would need to wait until then, but adding new ones and then aliasing the old ones can happen in 1.1.x. Better to avoid the discontinuity troubles 1.0.2 => 1.1.0 suffered from.

Updated title.

Whoops, failed reading comprehension; removing the 1.2.0 milestone for now.

Moved to Post 3.0.0 as it is too late for this in 3.0


ElectrumX GET and POST endpoints for unconfirmed utxos

:tada: This PR is included in version 1.16.1 :tada:
Your semantic-release bot :package::rocket:


[BEAM-12076] Adds a Kafka external read transform for reading with metadata

Adds a Kafka external read transform for reading with metadata.
Also updates Python Kafka wrapper to support reading with metadata.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Portable_Python PreCommit


Ephemeral runners for dev purposes

Description
With this PR you can trigger a workflow that deploys bandada on an ephemeral EC2 instance. From the moment you launch the instance through to its (auto)termination, the uptime is 6h. Each user has the option to spawn only one running instance, regardless of the deployment branch; there is also the possibility to re-deploy a newer version. In this scenario the old instance is destroyed, and a new one is launched.
The instance' s IP address appears during the workflow execution, allowing access to bandada via a web browser and/or connecting to the instance via SSH. VPN access is required for both cases (to receive the SSH key, please DM me).
Please keep in mind that bandada deployment takes between 20-30' after workflow execution and the ephemeral instance specs consist of 2vCPUS, 8GB of RAM and 32G HDD.
The workflow is scheduled to execute every 6h in order to terminate any instances that hung for any reason.
Related Issue
No
Does this introduce a breaking change?

[ ] Yes
[X] No

Other information
Not available

@baumstern Would you like to give an eye on this if you have any spare time? Thank you in advance!


Cannot find module<EMAIL_ADDRESS>

loading the .njsproj in VS2015. I'm unable to build because missing a file.

This is a known issue.  The gulp2vs.js script has been moved to another package, which we are still working on releasing.  Until then, could you try manually editing your .njsproj file to replace this line:
    <Exec Command="CMD.EXE /c node<EMAIL_ADDRESS>/>

...with this:
    <Exec Command="CMD.EXE /c node $(MSBuildThisFileDirectory)\node_modules\gulp\bin\gulp.js bundle" />

Let me know if that works...
@mousetraps

That works - didn't see that in known issues or on the VS page. It's building now.

FYI we have publicly released @microsoft/npmx, and in the next framework update the Yeoman template will refer to it like this:
    <Exec Command="CMD.EXE /c node<EMAIL_ADDRESS>/>

If you want to use this feature, you will need to manually run "npm install @microsoft/npmx-lib".


guvectorize does not implement the numpy ufunc interface in versions 0.53+

Hi, after upgrading numba from version 0.52.0 to either versions 0.53.0 or 0.54.0, I have found that the signature field of functions compiled using @guvectorize no longer is implemented.
Tested with:
numpy version 1.20.0
numba version 0.52.0, 0.53.0, 0.54.0
Here is a minimal working example:
from numba import guvectorize

@guvectorize(["void(float64[:], float64[:], float64[:])"],
             "(n),(n)->()", nopython=True, cache=True)
def test(a, b, c):
    c[0]=0
    for i in range(len(a)):
        c[0] += a[i]*b[i]

When I try using this, here's what happens with 0.52.0:
In [1]: import test_gufunc

In [2]: test_gufunc.test.signature
Out[2]: '(n),(n)->()'

And here's what I get with the newer versions:
In [1]: import test_gufunc

In [2]: test_gufunc.test.signature
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-2-d4d284438f75> in <module>
----> 1 test_gufunc.test.signature

AttributeError: 'GUFunc' object has no attribute 'signature'

Reporting a bug

[x] I have tried using the latest released version of Numba (most recent is
visible in the change log (https://github.com/numba/numba/blob/master/CHANGE_LOG).
[x] I have included a self contained code sample to reproduce the problem.
i.e. it's possible to run as 'python bug.py'.

I can reproduce this. The commit that introduced the issue is 925fd4c583094f4ea6852922c6bc9b86adf214b9.

The commit was in this PR: https://github.com/numba/numba/pull/5938
@guilhermeleobas Is it possible to add the signature property for dynamic gufuncs?
@iguinn Forgot to say earlier - many thanks for the report!

I've put this in the 0.55 milestone as we're so close to tagging 0.54.1, and this wasn't a regression specifically introduced in 0.54.0.

Hi @gmarkall, yes, that's possible. I'll send a PR shortly. @iguinn, thanks for reporting this bug!

Thanks for fixing this! I'll be looking forward to the next release.


Housing Data: tgz file not opening?

It's my first time using Jupyter and Python.
I'm trying to follow the following code in this link. It is from page 46.
If I download the .csv file, I can work with it, but the code you provided to download, open and extract the data from the .tgz does not seem to be working. Maybe the .tgz file is corrupted...

It seems that the code is now working.


7.2.3 Bad Signature

The 7.2.3 EXE file is being flagged as malicious.
https://www.virustotal.com/gui/file/6b3e8a777bbc567b4be33be593d563109ce9ec205ba9a5864f90d6e4ad986b1b/detection/f-6b3e8a777bbc567b4be33be593d563109ce9ec205ba9a5864f90d6e4ad986b1b-1709905942

Same for our sophos.

Windows defender blocks install.

The non hotfix 7.2.3 works fine. The hotfix one does not.

@maurice-daly Has this been fixed? I still can't download the new version as it gets flagged as a virus. Can you create a new MSI with a new hash or signature please?

For now you can get it from (this version works the one with the hotfix does not) https://github.com/maurice-daly/DriverAutomationTool/tree/a11574006256a13cbca3f5f5ed4632c4defdd357

For now you can get it from (this version works the one with the hotfix does not) https://github.com/maurice-daly/DriverAutomationTool/tree/a11574006256a13cbca3f5f5ed4632c4defdd357

This version seems to fail on newer Dell models. For instance, I can get the tool to download the Latitude 3120 drivers and package them. But I keep getting errors when the Latitude 3450 is selected. Right after the log states downloading from Dell, there is an error about incorrect Source or Destination parameters.

Will there be a new version that is not detected as malicious? As of today, on VirusTotal it gets flagged by 21/74 vendors.


added my fav pokemon

Added my fav pokemon

I have already included this in the website please have a look at it. Thank you.


Scroll up functinality full implemented

Description
Added scroll-up.css and scroll-up.js file, added the svg of the button in the figma file implemented the scroll to top functionality, when more content is added  to the site the feature can be seen  accordingly
Checklist

[X] My code follows the style guidelines of this project.
[X] I have performed a self-review of my code.
[X] I have commented on my code, particularly in hard-to-understand areas.
[X] I have added tests where necessary.
[X] My changes generate no new warnings or errors.
[X] I have checked that my feature works on mobile devices.

Fixes  #49

@Neel-07 I accepted your PR. But it's still not working, the button is not visible? Please test next time before you create a PR. Make sure it's work, it's visible, it's react when user scroll to bottom for 200px. And, please, work on a same issue that was created for this task for you. Thank you


feat: Kubernetes Deployment

Hey,
out of personal need, I've written a Kubernetes Deployment for plausible.
It's basically a translation of the docker-compose file with minor fixes for Kubernetes.
If this interests you, we would need to update the documentation before merging.
Also, we could make this a helm chart and offer helm deployments.
Thanks for your awesome work :D.

Refer to #71

👋 @Lennart01
This repo would probably stay docker-compose only since we don't have much k8s experience.
More info:

https://github.com/plausible/hosting/pull/71
https://github.com/plausible/hosting/pull/67#issuecomment-1514303962

If you'd like, you can start a github repo with k8s deployment and we'd link to it from the readme :)


Create resizable logos for platform use

Create resizable logos for platform use as part of communications and developer's kits

Resizable logos of what? CC license icons and trademarks? We already have those.

Renamed to "scalable" logos. We offer standard sizes at http://creativecommons.org/about/downloads/, but I was talking to some product people at Aspiration Summit and they said that it's more up to date to provide scalable versions of our logos so that a platform can resize them easily to fit how they display them on the platform. Scalable vector format... does that make sense?

yep. We provide those from that page too.... SVG and EPS files.
I do think that page needs some love though.

Matt Lee
Creative Commons
Boston, MA, USA
On Wed, Mar 11, 2015 at 3:26 PM, Jane<EMAIL_ADDRESS>wrote:

Renamed to "scalable" logos. We offer standard sizes at
http://creativecommons.org/about/downloads/, but I was talking to some
product people at Aspiration Summit and they said that it's more up to date
to provide scalable versions of our logos so that a platform can resize
them easily to fit how they display them on the platform. Scalable vector
format... does that make sense?
—
Reply to this email directly or view it on GitHub
https://github.com/creativecommons/platform-initiative/issues/19#issuecomment-78351469
.

Oh ok, so we have them. So I changed issue to "Package" it up nicely for platform use. I'll assign myself that and I can work on it with you down the line.

Yeah, @jayaw mentioned the idea of a press-pack for CC, I think we'd do this work for that too.


Admin API reference & Client Lib docs

Drafting these in preparation for the release of the Admin API.
API Reference: https://deploy-preview-90--tryghost.netlify.com/api/admin/
Client Library: https://deploy-preview-90--tryghost.netlify.com/api/javascript-admin/
These docs are rough stubs. The admin client library needs a home within the docs structure.

closing in favour of a new branch coming soooon

closing in favour of a new branch coming soooon


lucet-idl refactoring

Frank and I discussed the difficulties surrounding tagged unions. Since the WASI and Terrarium interfaces don't actually need them, I'm going to get rid of them in the language in a subsequent PR. It is tricky to support them properly in C, and probably impossible to do a zero-cost abstraction in Rust as well.


Default config generation

So I was thinking of how to help solve the issue of config files.
I thought of two options. One is an API change, the other isn't but is a little more unstable.
First, the unstable one:
Have our plugins catch 'file not found' errors, and create a base config that marks it as disabled, then write that config to disk in the given config directory. The benefit is that it won't be required by all plugins.
The second requires an API change:
Require a plugin::generate_config option that returns a serialized config that we write to disk. This would basically require every plugin to have serde, as well as the additional function definition. This would allow us to have a agent.exe --build-config option. This would also be another thing not documented in inquisitor_lib (but would be documented in the plugin creation guide) that plugins would have to implement.

Is it really an issue if config files are missing ? It will only result in plugins being disabled.
The default distribution should come with default config files anyway.
I can see the point of moving these default files into the plugin themselves, and having the plugins generate them, but I think this would make it harder for users (that would just download the .tar.gz or look over the project) to figure out how plugins are configured.

This was more of a "quick-install" process if there are no configs found. First time you run the agent it tells you "We generated a template config for all your plugins! Edit the file(s) and run this program again to start monitoring". Obviously, they should generate disabled (except for maybe Alive).
How I would probably go about implementing this is to have it check for the binary config (agent/receptor) and if not call a Plugin::generate() function that returns a Result<String, ()> (so plugins can 'opt out'. Then the agent/receptor takes care or writing the files/checking for duplicate plugin configs.


MSI fails to build for Launcher in Debug mode

The Product.wxs file for Launcher currently has all the dlls hardcoded in based on the files generated in Release mode, however it looks like in case of Debug there are less files generated, so the MSI creation fails.

Actually, I don't think we've ever supported a debug MSI.  @enricogior right?

Correct.
Is there any particular reason why we want to build the debug version of the MSI?

wouldn't symbols be good enough?  (we have an issue for this)
IMO, don't think this would be needed.

Until now it was still possible if required, and could be used if we wanted to share a debug version with a user facing some issue which could be better identified by running debug versions of PowerToys, as I had done to figure out one Image Resizer issue.

We can fix it after 0.18.

Debug versions would require statically linking the runtime library (not recommended) or redistributing them (not supported or recommended).

@arjunbalgovind @crutkas
can we close this?


Ukrainian translation files are missing.

Version information

Laravel: v7.30.4
Voyager: v1.x-dev e9160b7
PHP: 7.4
Database: MySQL 5.7.29

Description

seeders.php and compass.php files are missing from Ukrainian translation.
Steps To Reproduce
Steps to reproduce the behavior:

require tcg/voyager.
install voyager.
set the default app language as uk.
go to domain/admin.

Expected behavior
Side menu and other UI elements must be in Ukrainian.
Screenshots

Definitely not a bug.
Feel free to send in your translations as a PR


Adding aws-az-experiment, Disable availability zones for load-balancer

Signed-off-by: Oum Kale<EMAIL_ADDRESS>
What this PR does / why we need it:

Disable availability zones for load-balancer
Removes the specified Availability Zones from the set of Availability Zones for the specified load balancer in EC2-Classic or a default VPC.

For load balancers in a non-default VPC, use DetachLoadBalancerFromSubnets.
There must be at least one Availability Zone registered with a load balancer at all times. After an Availability Zone is removed, all instances registered with the load balancer that are in the removed Availability Zone go into the OutOfService state. Then, the load balancer attempts to equally balance the traffic among its remaining Availability Zones.
Checklist:

[ ] Fixes #
[ ] PR messages has document related information
[ ] Labelled this PR & related issue with breaking-changes tag
[ ] PR messages has breaking changes related information
[x] Labelled this PR & related issue with requires-upgrade tag
[x] PR messages has upgrade related information
[ ] Commit has unit tests
[ ] Commit has integration tests
[ ] E2E run Required for the changes

Experiment Logs:
time=2021-11-30 14:22:09,189 level=INFO  msg=Experiment Name: aws-az-chaos
time=2021-11-30 14:22:09,189 level=INFO  msg=[PreReq]: Initialise Chaos Variables for the aws-az-chaos experiment
time=2021-11-30 14:22:09,189 level=INFO  msg=[PreReq]: Updating the chaos result of aws-az-chaos experiment (SOT)
time=2021-11-30 14:22:09,836 level=INFO  msg=[Info]: The application information is as follows Namespace=litmus, Label=, Ramp Time=0
time=2021-11-30 14:22:09,836 level=INFO  msg=[Status]: Verify that the AUT (Application Under Test) is running (pre-chaos)
time=2021-11-30 14:22:09,865 level=INFO  msg=Found credentials in shared credentials file: /tmp/cloud_config.yml
time=2021-11-30 14:22:11,255 level=INFO  msg=[Info]: LoadBalancer and Availablity of zone has been checked
time=2021-11-30 14:22:11,271 level=INFO  msg=[Info]: Target available zone list, ['us-east-2a', 'us-east-2c']
time=2021-11-30 14:22:11,282 level=INFO  msg=[Info]: Detaching the following zone, Zone Name us-east-2a
time=2021-11-30 14:22:20,029 level=INFO  msg=[Info]: Detaching the following zone, Zone Name us-east-2c
time=2021-11-30 14:22:21,809 level=INFO  msg=[Wait]: Wait for the chaos interval 10
time=2021-11-30 14:22:31,818 level=INFO  msg=[Status]: Atach the available zone back to load balancer
time=2021-11-30 14:22:34,868 level=INFO  msg=[Status]: Checking AWS load balancer's AZ status
time=2021-11-30 14:22:36,232 level=INFO  msg=[Info]: LoadBalancer and Availablity of zone has been checked
time=2021-11-30 14:22:36,233 level=INFO  msg=[Info]: Target available zone list, ['us-east-2a', 'us-east-2c']
time=2021-11-30 14:22:36,313 level=INFO  msg=[Info]: Detaching the following zone, Zone Name us-east-2a
time=2021-11-30 14:22:37,742 level=INFO  msg=[Info]: Detaching the following zone, Zone Name us-east-2c
time=2021-11-30 14:22:39,200 level=INFO  msg=[Wait]: Wait for the chaos interval 10
time=2021-11-30 14:22:49,210 level=INFO  msg=[Status]: Atach the available zone back to load balancer
time=2021-11-30 14:23:00,604 level=INFO  msg=[Status]: Checking AWS load balancer's AZ status
time=2021-11-30 14:23:01,849 level=INFO  msg=[Info]: LoadBalancer and Availablity of zone has been checked
time=2021-11-30 14:23:01,849 level=INFO  msg=[Completion]: aws-az-chaos chaos is done
time=2021-11-30 14:23:01,849 level=INFO  msg=[Confirmation]: aws-az-chaos chaos has been injected successfully
time=2021-11-30 14:23:01,849 level=INFO  msg=[Status]: Verify that the AUT (Application Under Test) is running (post-chaos)
time=2021-11-30 14:23:03,009 level=INFO  msg=[Info]: LoadBalancer and Availablity of zone has been checked
time=2021-11-30 14:23:03,036 level=INFO  msg=[The End]: Updating the chaos result of aws-az-chaos experiment (EOT)

Chaos Result :+1:
Name:         aws-az-chaos6htv8-aws-az-chaos
Namespace:    litmus
Labels:       app.kubernetes.io/component=experiment-job
              app.kubernetes.io/part-of=litmus
              app.kubernetes.io/version=latest
              chaosUID=db1d6f97-14fe-41b4-8a9b-a158daccdde2
              controller-uid=3579ec9f-f6a5-4102-841b-dc8020fa5a6d
              job-name=aws-az-chaos-s2tlld
              name=aws-az-chaos6htv8-aws-az-chaos
Annotations:  <none>
API Version:  litmuschaos.io/v1alpha1
Kind:         ChaosResult
Metadata:
  Creation Timestamp:  2021-11-30T14:22:09Z
  Generation:          2
  Managed Fields:
    API Version:  litmuschaos.io/v1alpha1
    Fields Type:  FieldsV1
    fieldsV1:
      f:metadata:
        f:annotations:
          .:
          f:kubectl.kubernetes.io/last-applied-configuration:
        f:labels:
          .:
          f:app.kubernetes.io/component:
          f:app.kubernetes.io/part-of:
          f:app.kubernetes.io/version:
          f:chaosUID:
          f:controller-uid:
          f:job-name:
          f:name:
      f:spec:
        .:
        f:engine:
        f:experiment:
        f:instance:
      f:status:
        .:
        f:experimentStatus:
        f:history:
    Manager:         kubectl
    Operation:       Update
    Time:            2021-11-30T14:22:09Z
  Resource Version:  55286
  UID:               67e005e1-7846-4e60-8dd4-9d43a4abae99
Spec:
  Engine:      aws-az-chaos6htv8
  Experiment:  aws-az-chaos
  Instance:
Status:
  Experiment Status:
    Fail Step:                 N/A
    Phase:                     Completed
    Probe Success Percentage:  100
    Verdict:                   Pass
  History:
    Failed Runs:   0
    Passed Runs:   1
    Stopped Runs:  0
Events:
  Type    Reason   Age   From                       Message
  ----    ------   ----  ----                       -------
  Normal  Awaited  105s  aws-az-chaos-s2tlld-4b42b  Experiment aws-az-chaos, Result Awaited
  Normal  Pass     51s   aws-az-chaos-s2tlld-4b42b  Experiment aws-az-chaos, Result Pass


[tool_crash] FileSystemException: Failed to set file modification time, path = 'F:\FlutterProject\TestLearnFlutter\flutter_app.packages' (OS Error: 拒绝访问。, errno = 5)

Command
flutter --no-color run --machine --track-widget-creation --device-id=0123456789ABCDEF lib\main.dart

Steps to Reproduce

...
...
...

Logs
FileSystemException: FileSystemException: Failed to set file modification time, path = 'F:\FlutterProject\TestLearnFlutter\flutter_app.packages' (OS Error: 拒绝访问。
, errno = 5)
#0      _File.setLastModifiedSync (dart:io/file_impl.dart:473:7)
#1      ForwardingFile.setLastModifiedSync (package:file/src/forwarding/forwarding_file.dart:62:55)
#2      ForwardingFile.setLastModifiedSync (package:file/src/forwarding/forwarding_file.dart:62:55)
#3      _DefaultPub.get (package:flutter_tools/src/dart/pub.dart:213:19)
#4      FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:705:17)
<asynchronous suspension>
#5      FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:619:33)
<asynchronous suspension>
#6      FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart)
#7      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:29)
#8      _rootRun (dart:async/zone.dart:1184:13)
#9      _CustomZone.run (dart:async/zone.dart:1077:19)
#10     _runZoned (dart:async/zone.dart:1619:10)
#11     runZoned (dart:async/zone.dart:1539:10)
#12     AppContext.run (package:flutte

Duplicate of #49948
Closing in favor of #50880 based on this comment
Thank you


number of model parameters is 0

Hi, I tried to run the training script locally on a small subset of the data (only the images included in the 000 folders) after adjusting data.csv accordingly. After executing the training I see
(ds) dreamsim# python ./training/train.py --config ./configs/train_ensemble_model_lora.yaml
Seed set to 1234
GPU available: True (cuda), used: True
TPU available: False, using: 0 TPU cores
IPU available: False, using: 0 IPUs
HPU available: False, using: 0 HPUs
Using cache found in ./models/facebookresearch_dino_main
dreamsim/ds/lib/python3.8/site-packages/peft/tuners/lora.py:143: UserWarning: fan_in_fan_out is set to True but the target module is not a Conv1D. Setting fan_in_fan_out to False.
  warnings.warn(
LOCAL_RANK: 0 - CUDA_VISIBLE_DEVICES: [0]
Validation DataLoader 0: 100%|█████████████████████████████████████████████| 2/2 [00:00<00:00,  2.63it/s]
LOCAL_RANK: 0 - CUDA_VISIBLE_DEVICES: [0]

  | Name             | Type            | Params
-----------------------------------------------------
0 | perceptual_model | PerceptualModel | 0
1 | criterion        | HingeLoss       | 0
-----------------------------------------------------
0         Trainable params
0         Non-trainable params
0         Total params
0.000     Total estimated model params size (MB)
Epoch 5: 100%|██████████████████████████████████████████████████| 10/10 [00:08<00:00,  1.12it/s, v_num=3]
`Trainer.fit` stopped: `max_epochs=6` reached.
Epoch 5: 100%|██████████████████████████████████████████████████| 10/10 [00:09<00:00,  1.11it/s, v_num=3]
Done :)

looks like number of model parameters is 0 (based on what printed above). Is it because of too small training data size or some other issue?

Hi there! This is something we came across to - it's an artifact of how the LoRA weights are not detected by PyTorch's param counting. If you dig into the model itself and inspect the LoRA-related weights (e.g. lora_A or lora_B of any attention block), they will be trainable.


[nx/pulumi] Hide undefinded log when envVars are not defined

Hello 👋
Sorry for this simple PR, but i really hate the undefined log everytime that I run the up command.
Example:

Thanks for the fix! I will merge this in now :)


doesn't connect to UPTimeKuma in docker container

trying to connect, using the constructed status page url , using browser just spins..
axios get never returns from await
http://mac-mini:3001/api/status-page/default

utk version
Version: 1.23.11
Macos

What does the browser show at http://mac-mini:3001/status/default?

the page is empty

only js

i changed my docker container to map to port 80..
but really no change, dev tools shows error
for UK/status-page/default (module)
web-client-content-script.js:2 Uncaught TypeError: Cannot use 'in' operator to search for 'animation' in undefined
    at Ye (web-client-content-script.js:2:49247)
    at 995 (web-client-content-script.js:2:49530)
    at n (web-client-content-script.js:2:182360)
    at 306 (web-client-content-script.js:2:152623)
    at n (web-client-content-script.js:2:182360)
    at web-client-content-script.js:2:197374
    at web-client-content-script.js:2:379018
    at web-client-content-script.js:2:379033
Ye @ web-client-content-script.js:2
995 @ web-client-content-script.js:2
n @ web-client-content-script.js:2
306 @ web-client-content-script.js:2
n @ web-client-content-script.js:2
(anonymous) @ web-client-content-script.js:2
(anonymous) @ web-client-content-script.js:2
(anonymous) @ web-client-content-script.js:2
onloadwff.js:71 Uncaught (in promise) TypeError: Cannot read properties of null (reading 'querySelectorAll')
    at s.<anonymous> (onloadwff.js:71:820251)
    at l (onloadwff.js:71:800922)
    at Object.next (onloadwff.js:71:800233)
    at n (onloadwff.js:71:799769)

for /status
GET http://localhost/status 404 (Not Found)

like there is some config step I didn't do.. but I don't see any setup info for UK..

I stopped the container, deleted the mapped folder and restarted.. created new userid, and same.. not found for status

aha, I had to create a status page and add the monitors to expose to it

then call to status-page worked
https://utka.xx.yy/api/status-page/default
{"config":{"slug":"default","title":"default","description":null,"icon":"/icon.svg","theme":"auto","published":true,"showTags":false,"customCSS":"body {\n  \n}\n","footerText":null,"showPoweredBy":true,"googleAnalyticsId":null,"showCertificateExpiry":false},"incident":null,"publicGroupList":[{"id":1,"name":"Services","weight":1,"monitorList":[{"id":1,"name":"cnsearch arizona","sendUrl":1,"type":"http","url":"https://cnsearch.xx.yy"}]}],"maintenanceList":[]}

I opened UK issue
https://github.com/louislam/uptime-kuma/issues/4523

can close, just waiting  til you saw it.. thanks for your help

Ah, I see. I should improve the docs to make it clear you need a status page created in UK for this to be able to read it.


feat: adaptations for leanprover/lean4#3210

These are adaptations for leanprover/lean4#3210.

[ ] depends on: https://github.com/leanprover/std4/pull/571

Looks good, feel free to merge this once the dependencies are merged.
Proper support for simprocs (which Aesop currently just ignores) will need broader changes, but I'll combine these with a refactoring of Aesop's simp integration.

I'm going to merge this without updating the dependency, which I'll do tomorrow with the release.


serve Command Improvements

Signed-off-by: Mior Muhammad Zaki<EMAIL_ADDRESS>

Coverage remained the same at 80.247% when pulling 3e389d3099350a6f7b04ff317df744d09b4aaa70 on patch-serve into e241a41fa80bc4f5294ff8d0bf02e461dc37acc9 on 7.x.


Can not create two editor with different theme

monaco-editor version: 0.14.2 & 0.18.1
Browser: chrome 69
OS: macOS Mojave 10.14
Playground code that reproduces the issue:
monaco.editor.create(document.getElementById("container"), {
	value: "function hello() {\n\talert('Hello world!');\n}",
        theme: 'vs-light',
	language: "javascript"
});

monaco.editor.create(document.getElementById("container1"), {
	value: "function hello() {\n\talert('Hello Monaco!');\n}",
        theme: 'vs-dark',
	language: "javascript"
});

I set dark theme and light theme, but all show dark theme

I can report the same thing, @yunliang-ding your solution didn't seem to work. In my case I am actually calling create at two different times:
exports.create_ = function (monaco, nodeId, languageId, themeName) {
  console.log(nodeId);
  console.log(languageId);
  console.log(themeName);
  const editor = monaco.editor.create(nodeId, {
    value: [
      'Close'
    ].join('\n'),
    language: languageId,
    theme: themeName,
  });
  return editor;
}

Note here that monaco references the same object coming from webpack entry point:
import * as monaco from 'monaco-editor/esm/vs/editor/editor.api';
global.monaco = monaco;

This is a real issue for me now 😢

Also note that all other things that depend on languageId seem to work just fine (TokensProvider, DocumentFormattingEditProvider etc). For example, for one of the editors I provide a DocumentFormattingEditProvider but for the other I do not. If I press f1 on each editor then only 1 has access to "Format Document" as expected.

Ah, I discovered that setTheme exists but it is a global thing: https://microsoft.github.io/monaco-editor/api/modules/monaco.editor.html#settheme
so this issue then is a feature request to move setTheme to https://microsoft.github.io/monaco-editor/api/interfaces/monaco.editor.istandalonecodeeditor.html or some other way of achieving the same thing.

+1 on this, could be cool (not critical though)

+1 on this, has any solution?

I've been changing the theme every time I switch, not ideal though and it only works for me since I never have 2 editors on screen at the same time

+1 on this

+1 on this

+1 on this

the same problem, how to solve?

Is it planned to be fixed?

Have you guys found any workarounds?

how to solve?

I am also here to look for solutions. Didn't work for me at v0.36.1. Any solutions?

This is related.
https://github.com/Microsoft/monaco-editor/issues/338#issuecomment-1553847664

/duplicate #338


Ensure ASN.1 Bitstrings are written in DER

Description
This addresses https://github.com/ARMmbed/mbedtls/issues/1610. The problem is that trailing 0s are not accounted for in the leading content octet that encodes the unused bits in the lat bitstring byte. The problem was in the function mbedtls_asn1_write_bitstring(), which I have reworked slightly. Also, I added some code to ensure that unused bits are zeroed in the output buffer.
Note that the Mbed TLS ASN.1 parsing function does not ensure that the bitstring is strictly in DER. However I tried other decoders and they do not seem to check this either. Detecting and failing on these conditions would cause, for example, certificates to fail when they were previously parsed successfully.
[edited by mpg] fixes #1610 fixes #1605
Status
READY
Requires Backporting
Yes

2.16 #2429
2.7 #2148

Additional comments
I added some unit tests for the relevant ASN.1 function.

Internal Reference: IOTSSL-2526.

@hanno-arm: Thanks fore taking a look!
I think the explanation you have provided is roughly of what I found and wrote in IOTSSL-2526. I agree with the following statement:

It therefore seems that we must distinguish between arbitrary 'raw' bitstrings and 'named bit lists' when deciding how to encode and decode them

However, I disagree with the with the following, but perhaps I am missing something:

... but we can't go for one encoding only. In particular, I think changing mbedtls_asn1_write_bitstring() as done in this PR is not the right way to go, as for raw bitstrings, 11.2.2 need not be obeyed (it should obey 11.2.1, though, which it doesn't and which this PR fixes, too, and that fix should definitely be kept).

This is because I do not think that the ASN.1 module in Mbed TLS was designed to be a full general-purpose encoder/decoder that supports DER, BER, etc. Instead, I think this module is there to support just what is needed for TLS and other supported functionality that requires it (e.g. PKI, etc). This is the reason why I did not implement multiple versions of bitstring encoding notations as mbedtls_asn1_write_bitstring() is only used for writing the KeyUsage and NsCertType fields in CRTs and CSRs, which I think are both name named bitstrings. Also, my understanding is that the named bitstring encoding is just the same requirement to remove trailing 0s as in DER.
Finally, can't the encoding of the fields like UniqueIdentifier that you mentioned can be DER? Anyways here it says that:

The X.509 v3 certificate basic syntax is as follows.  For signature
calculation, the data that is to be signed is encoded using the ASN.1
distinguished encoding rules (DER) [X.690].

Thanks @andresag01 for your reply.

Also, my understanding is that the named bitstring encoding is just the same requirement to remove trailing 0s as in DER.

I have trouble understanding what you mean here - could you please rephrase? DER encoding of raw bitstrings is not the same as the DER encoding of named bitstrings.

Instead, I think this module is there to support just what is needed for TLS and other supported functionality that requires it (e.g. PKI, etc).

Even if Mbed TLS itself never uses the ASN.1 module to write raw bitstrings, we must not change the semantics of mbedtls_asn1_write_bitstring() because it's a public function, and people might use it for raw bitstrings. Also, I strongly object to making a change which renders mbedtls_asn1_write_bitstring() and mbedtls_asn1_get_bitstring() not inverse to each other.
In my opinion, the way to deal with this is to fix the DER encoding bug in mbedtls_asn1_write_bitstring() (i.e. making sure the unused bits are set to 0), and to introduce a pair of new parsing and writing functions for named bitstrings.

@hanno-arm: I have reworked the PR according to your comments and fixed some tests that broke along the way. Note that this only fixes the writing issue, but not the parsing.

@sbutcher-arm: Please note that this changes the API, so requires design approval.

@hanno-arm @sbutcher-arm: Please note that this PR changes the API, so I am not sure how to backport to fix the issues with bitstrings in Mbed TLS 2.1 and 2.7

Please note that this PR changes the API, so I am not sure how to backport to fix the issues with bitstrings in Mbed TLS 2.1 and 2.7

@andresag01 It only extends the API, and we could backport that extension - or is there a reason not to do that?

@hanno-arm: My understanding is that we should not change the API at all in previous branches, also this changes the behaviour of the the key_usage extension writing to accept more values. I do not think this is a problem, but it would be good to ask the gatekeeper before backporting.
@sbutcher-arm: Could you please comment on the API and backport issue?

My understanding is that we should not change the API at all in previous branches, also this changes the behaviour of the the key_usage extension writing to accept more values.

@andresag01 However, this particular change could be removed in the backports, couldn't it?

@hanno-arm: The change for  extending the allows key usage bits to write, etc can be excluded, but the fix for named bitstrings requires creating a new function because otherwise we would change the behaviour of write_bitstring().

@hanno-arm: I have fixed the typos and style, could you please take another quick look?

@andresag01 @sbutcher-arm I recommend backporting the entire PR, including the API extension. I don't see a reason not to backport an API extension.

@andresag01 Can you expand on the reason for the latest commit changing the tests? It seems that previously we were writing empty keyUsage extensions which are now omitted - which is very sensible, but was there any functional problem with the old tests?

@hanno-arm: Thanks for reviewing!

Can you expand on the reason for the latest commit changing the tests? It seems that previously we were writing empty keyUsage extensions which are now omitted - which is very sensible, but was there any functional problem with the old tests?

My understanding is that it is possible to have an empty named bitstring (and consequently an empty KeyUsage extension for example). I wanted to add tests for this, but unfortunately the code in test_suite_x509write  previously omitted including the KeyUsage and NsCertType extensions if none of the flags were set. My original approach was to simply overflow bits in the arguments to the x509 functions that dealt with this and it would have the same effect as setting an empty named bitstring. For example, if I wanted a CSR with empty KeyUsage then I would pass something like 0x80000000 to the test, which sets the extension by calling mbedtls_x509write_csr_set_key_usage_ext(). However, the top bit (which does not make sense) is lost because that function take a char as argument.
The problem is that this idea for testing empty extensions is a bit of a hack and the fix at https://github.com/ARMmbed/mbedtls/pull/2074 breaks these kinds of tests because the new function takes an unsigned intand checks whether any bit that does not make sense is set. To get around this problem I added another input parameter to the test to specify when I actually want the KeyUsage and NsCertWrite extensions to be included or not regardless of the value of their value. Does this make sense?

Does this make sense?

It does, thanks for the detailed explanation!

@hanno-arm: Great! Thanks for the review. I will look into the preexisting problem you found, but I will not backport the changes yet as we do not have design approval and things might still change a bit...

@hanno-arm: Thanks for reviewing. I have reworked the PR to fix the preexisting issue. Could you please take another look?

@sbutcher-arm: Thanks for the review. I will fix the issues you pointed out, but could you also comment whether the design is acceptable? Please note that this PR makes an API change. Also, we need to backport at least some of this to 2.7 and 2.1, but is not clear to me whether we can add to the API in those branches.

Sorry @andresag01! Design and API is fine.

@sbutcher-arm: Thanks for reviewing, I have now reworked the PR.
@sbutcher-arm @hanno-arm: Could you please take another look?

Do we need backports? I think not because we're extending the API. Better, in my view, to re-document the LTS branches and say what they can/can't do. So I think we need new/different fixes for the maintained branches.

@sbutcher-arm: Thanks for confirming regarding the backports. I will backport the following changes:

Ensure that unused bits are zeroed in bitstrings
Document that the named bitstrings are not encoded in strict DER, so trailing zeroes are not removed.

@hanno-arm: made a fix. Please review. I will rebase  the changes when the reviews have concluded.

@hanno-arm - Can you please re-review?
@andresag01 - I'll review again once you've rebased.

@sbutcher-arm: I will rebase the PR once the @hanno-arm has reviewed and approved to not mess up the review history. In any case, note that the conflicts are only in the data files which apparently fully regenerated (not sure why though...)

@hanno-arm @sbutcher-arm Can you re-review this?
@andresag01 Can you go ahead and optimistically create backports, as an earlier version of this PR already had a near-approval from Hanno?

@mpg: No problem, I will do that as soon as I can.

@mpg: I have created/updated backports for Mbed TLS 2.16 and 2.7.

@hanno-arm: Thanks for the review. I will not update the PR to fix the small style issue in the test code to avoid re-review...

There are two approvals for this PR, so I removed the "needs: review" label.

@andresag01 @hanno-arm I can't check the CI right now, could one of one check if the failure is a known issue and report your findings here? Thanks!

@mpg: As far as I can tell, only timing tests failing.

This has two approvals and a passing CI (except for known-fragile test), a ChangeLog entry and tests, so it would be ready for merge, but the backports need reviewing.

Ping @mpg on an opinion regarding https://github.com/ARMmbed/mbedtls/pull/2028/files#diff-030fafc49adaa9d23e735ab6a4cf816cR93; see the comment above.

@hanno-arm Thanks for pinging me. I think this should not hold back this PR, as (1) it's pre-existing and (2) it doesn't affect observable behaviour in any way unless there is a bug elsewhere, so it's much less important than the observable compliance issue addressed by this PR, and we shouldn't hold back important fixes for trivial pre-existing issues.

Backports are ready for merge, removing "needs: backports".

This has two approvals and a (as good as) passing CI, a ChangeLog entry and tests, fixes a legitimate bug and has backports to all maintained branches ready, so it's ready for merge.

I've rebased the PR (to include the crypto submodule) and appended a commit to update the submodule to commit a78c958 which includes the same PR merged into the crypto submodule.
@hanno-arm / @mpg - Can you please re-review this PR and approve?


Removed Apache License appendix

Related issues: #2660; https://github.com/rust-lang/rust/pull/67734

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon.
Please see the contribution instructions for more information.

Thanks!
@bors r+

:pushpin: Commit 0aaa193103224d68904dc377491af2f8877842ec has been approved by Amanieu

:hourglass: Testing commit 0aaa193103224d68904dc377491af2f8877842ec with merge 82bc11048d6d63a91f28dba337b65600bead4ad6...

:broken_heart: Test failed - checks-actions

@bors retry

:hourglass: Testing commit 0aaa193103224d68904dc377491af2f8877842ec with merge f2592e73fbb872904282e6ded290975fecfecd20...

:sunny: Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: Amanieu
Pushing f2592e73fbb872904282e6ded290975fecfecd20 to master...


Add RegularizedIterativeSENSEReconstruction

closes #369
closes #321
closes #6

Allow for a linear operator in the regularization:
... + L*(Bx-x0)^2 ? With B defaulting to identity?

With B defaulting to identity?

Would we then still omit an implementation of the identity operator and realise it with setting B: LinearOperator | float = 1. and making use of the OperatorTensorSum?

B as float does not make sense IMHO.
I would make it LinearOperator | None
with None being the identity (this also avoids creating an object as a default operator)
We can still have an explicit IdentityOperator, that can be used there (or used as a dummy linear operator)
Gesendet von Outlook für Androidhttps://aka.ms/AAb9ysg

From: Christoph Kolbitsch @.>
Sent: Thursday, September 5, 2024 9:25:23 AM
To: PTB-MR/mrpro @.>
Cc: Felix F Zimmermann @.>; Comment @.>
Subject: Re: [PTB-MR/mrpro] Add RegularizedIterativeSENSEReconstruction (PR #388)
With B defaulting to identity?
Would we then still omit an implementation of the identity operator and realise it with setting B: LinearOperator | float = 1. and making use of the OperatorTensorSum?
—
Reply to this email directly, view it on GitHubhttps://github.com/PTB-MR/mrpro/pull/388#issuecomment-2330798330, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABH3DV47JR4YBFURG2LKKP3ZVABOHAVCNFSM6AAAAABNU4MUICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZQG44TQMZTGA.
You are receiving this because you commented.Message ID: @.***>

can we jusit add the regularization example to the existing iterative sense example? these two examples seem quite redundant.

can we jusit add the regularization example to the existing iterative sense example? these two examples seem quite redundant.

yes there is sume redundancy but from a teaching perspective I think it is easier to understand to build up the complexity of the reconstruction step by step.

@fzimmermann89 or @schuenke any more comments?

I will check tonight.

how would we include the dcf preconditioning into a toeplitz form of the fourier op?

I would say we go ahead without the gram here for now and we discuss some approaches in a meeting.

How important is the weighted objective compared to only using a DCF corrected x0?
The one comparison in the Prussmann paper gives a slight advantage for >30 iterations, disadvantage for fewer.
https://arxiv.org/abs/1902.09657 ( Ong, Uecker, Lustig) also argue that the reweighting of the objective function is suboptimal due to the noise reshaping. the maximum likelihood solution would be without the dcf. they suggest proper preconditioning using different algorithms.


[rocMLIR] Threading/registration cleanup

I have investigated how to update MIGraphX's handling of initializing/calling rocMLIR to make it better conform to recommended practice from upstream.
A prerequisite for such changes to MIGraphX, which give us a better chance of making multithreaded MLIR work right, is https://github.com/ROCmSoftwarePlatform/rocMLIR-internal/issues/973 , where the MLIR C API needs to be extended.
However, after that is done, the setup should be as follows:

Create, in a thread-safe way (call_once) a MlirDialectRegistry and what I'm going to call a MlirLlvmThreadPool and keep these around. While you're there, call registerRocMLIRPasses() - you need that to initialize stuff like the LLVM backend (indirectly) and that function isn't known to be thread-safe right now (though some upstream changes might fix that Eventually)
You'll be doing

MlirContext ctx = MlirCreateContextWithOptions(theRegistry, false);
mlirContextSetThreadPool(ctx, theThreadPool);
mlirContextLoadAllAvailableDialects(ctx);

You don't need to destroy the registry or to set the allow unregistered dialects flag.
This can be done independently of removing the locks.
You'll want to create a context once for each distinct module you're sending in.

This is now https://github.com/ROCmSoftwarePlatform/AMDMIGraphX/pull/1867

Work is now complete


Use 'failure' crate for error handling (closes #1)

failure is a newer, cleaner approach to error handling which avoids the use of complicated macro_rules:
https://github.com/withoutboats/failure

Thanks for putting this together. I think it looks good as is, but I'd eventually like to move to using a custom Fail type instead of the simple strings-as-errors scheme in use right now. I'll have to put some more thought into that, so I think this is good to go.

failure is very flexible that way: You can have several different error types, e.g. ConnectorError, SessionError that impl/derive Fail.
The failure_derive crate provides a procedural macro for defining them, e.g.:
#[macro_use]
extern crate failure_derive;

#[derive(Debug, Fail)]
pub enum ConnectorError {
    /// URL provided for yubihsm-connector is not valid
    #[fail(display = "invalid URL")]
    InvalidURL,

    /// Connection to yubihsm-connector failed
    #[fail(display = "connection failed to: {}", url)]
    ConnectionFailed {
        /// URL which we attempted to connect to
        url: String,
    },

    /// yubihsm-connector sent bad response
    #[fail(display = "bad response from yubihsm-connector: {}", description)]
    ResponseError {
        /// Description of the bad response we received
        description: String,
    },
}

More info here:
https://boats.gitlab.io/failure/custom-fail.html


Limit recursion depth in kernel traversals?

We should consider... a depth counter to manage how deep we'll go. I've seen several hundred deep nested columns out in the wild before.

Originally posted by @hntd187 in https://github.com/delta-incubator/delta-kernel-rs/issues/395#issuecomment-2412839175

On the other hand... stack overflow is utterly catastrophic in rust, nearly SIGKILL level bad. No response or recovery of any kind is available, not even a backtrace. That's really not a nice failure scenario to inflict on some unsuspecting engine.


No connection over mobile Network

HI. my english is not the best also with google translated.
I run Peercalls as an app on my Qnap. Also works very well so far, but no connection is established on the mobile phone via the mobile network. I wifi it works. Does anyone have any tips.?
Best regards
Schnabeldubibu

mobile phones dont have public IP, so it's most likely NAT issue. You need to set up a TURN server.

Many Thanks. But I think that is beyond my competence. I have no plan how I could do that :) I also think that my QNAP and my bandwidth are not enough for it.


Compatibility with Svelte 5 and runes

Hello,
Thank you for this great library !
It was working great with svelte 4, but when I tried to bump, I encountered issues with reactivity. Indeed, the Layer's render function seems to be incompatible with the runes and not been re-evaluated if it contains a reactive variable.
Did you plan to make the library compatible ?
Thanks !

This is caused by a breaking change in Svelte 5: using a reactive variable in a function definition does not trigger effects unless the function is called. Because of this, migrating layers by changing $: render = ... to let render = $derived(...) doesn't work.
I'm working on an update to the library that will address this, but it's not ready yet. In the meantime, there are a few possible workarounds:

Use $derived.by as shown here.
Keep using legacy Svelte 4 syntax for your render functions.
Use the Canvas autoplay prop. This will cause the canvas to re-render on every frame, even when nothing has changed.

Thank you for your quick reply !
Nice to read that you're on an update, and looking forward to seeing this ! In the meantime, I think I'll keep the Svelte 4 syntax for the render functions.

Thank you very much @dnass ! I'll test it soon and let you know if I encounter any issues :)