Add capability to support configuration

We are leveraging this project to easily set up web socket server end point. We have found the connection between web socket server and client will automatically drop when there is no activity for five minutes. The five minutes is the default idle timeout setting in jetty web socket implementation. We are required to make the persistent connection once the connection is established. Connection dropping means something goes wrong on either server or client side. We want to prevent this automatically disconnect by introducing configuration.
Please let me know if this is considered a valid request.

Coverage decreased (-2.6%) to 80.583% when pulling ecf75bd6cd4a5046040d9b04ea1d23e392c8aa14 on jasonzhang0413:master into b3695a83c2aa12780e29b6f8635017baffca0572 on LivePersonInc:master.

looks good to me

In case anyone is wondering the same question, here's my solution (written in scala, you can easily write the same thing in java):
Add the following code inside the run function provided by dropwizard
    val webSocketUpgradeFilter = WebSocketUpgradeFilter.configureContext(environment.getApplicationContext)
    webSocketUpgradeFilter.getFactory.getPolicy.setIdleTimeout(100000)
    environment.getApplicationContext.setAttribute(classOf[WebSocketUpgradeFilter].getName, webSocketUpgradeFilter)


Install bot to a team event

I need to send initial message to the user after adding my application to his team.
I solve this problem with is monkey patching of the file https://github.com/dblock/slack-bot-server/blob/22a215eec2/slack-bot-server/api/endpoints/teams_endpoint.rb after team activating
# == My code start ==
SlackBotServer::Service.start!(team)

client.token = rc['access_token']
information = client.auth_test({token: rc['access_token']})

client2 = Slack::Web::Client.new(token: token)
# always try to create new DM
new_dm = client2.im_open(user: information[:user_id])
channel_id = new_dm.channel.id

# send message
client2.chat_postMessage(
  channel: channel_id,
  text: "Hello <@#{information[:user_id]}>. Nice to meet you! Type 'help'",
  as_user: true
)

client2 = nil
# == My code end ==

Is there right way, to send message to user immediately after he install the bot? Can you give me advice on how to do better, or leave like that?
thanks

I don't think there's a "right" way at this point. You probably want to do this in a callback after a connection has been established the first time on start, to avoid re-creating a connection twice, then remember that you sent a welcome message. But this works too.

I'll leave this open, I'd like an "official" way of doing this, but probably mostly in https://github.com/dblock/slack-ruby-bot.

I've implemented lifecycle callbacks in https://github.com/dblock/slack-ruby-bot-server/commit/325eb944f7450caff6c9ec1cb309ea1dc7c08f40. You should be able to do this:
instance = SlackRubyBotServer::Service.instance

instance.on :created do |team, server, error|
  server.client....
end

I think we need to make .client public in slack-ruby-bot. Would love a PR.
Give it a try?


Create @iov/faucets

Closes #293

Travis fails because @iov/faucets is not on npm yet, which is required by the @iov/cli installation test. We could split the creation of the package and the usage but this adds a lot of overhead. I'd rather merge and release with red CI in this case.


Disable flycheck when racket-xp-mode is enabled

Enabling both flycheck and racket-xp-mode would create redundant
error tooltips. Since racket-xp-mode provides a higher quality
error message, prefer it over flycheck.

Let me know if there's anything I should change. If this is something that should be in personal config, not Doom Emacs, I'm OK to close the PR, too (though the redundant error tooltip would then be a problem that needs to get fixed).

Thanks for the PR! A little more was needed for this PR, so I did it in e697916 (with credit given. Thanks for bringing it to my attention!


Dynamic import with variable + externals config not working

Bug report

What is the current behavior?
I'm trying to use a dynamic import that uses a variable, and at the same time leave all these modules as external libraries, so I'm doing this:
import(`library/${module}.js`);
And my Webpack externals config is:
externals : /library\/.*\.js/
And right now, its not leaving those modules as external and its bundling them
If I do import(`library/specificModule.js`); it works even with the same regex on the externals config.
Looks like the externals config doesn't apply for the import() with variables, because I also tried using a function as the externals config and setting up a brakpoint inside it, and it doesn't hit for those files.
If the current behavior is a bug, please provide the steps to reproduce.
Take any library and import its modules with something like import(`library/${module}.js`);
Add the regex to the externals webpack config
Run build
The modules are bundled

What is the expected behavior?
I think it should leave all those modules as external modules when using the variable on the import

Other relevant information:
webpack version:  4.23.1
Node.js version: 10.11.0
Operating System: Windows 10
Additional tools: -

externals : /library[\\\/].*\.js/

Thanks for the rapid response @sokra
That regex doesnt seem to work either 😞. What do you mean "the files have to exist in this directory"? those files are in node modules, so they exist.

hmm not sure. Could you create a minimal repro repo?

Sorry I didnt explain: in src/main.js you have
// Bundles all
let iconName = 'Ambulance';
let i = import(`@fortawesome/free-solid-svg-icons/fa${iconName}.js`);

// Doesnt bundle the imported module
// let i = import(`@fortawesome/free-solid-svg-icons/faAmbulance`);

Toggling comments on the let is and running npm run build you can see the different results.
The externals config is in the vue.config.js file

谢谢

here is i solved such problem in bundle with react-redux
https://stackoverflow.com/questions/48268507/react-dynamically-import-components/56456932#56456932

bump

Bump, guys, this seems pretty crucial. Dynamic imports that don't support a dynamic entry point are restrictive.
A use case that I was bouncing around in my head before finding this issue is for micro-frontends.
Having the addresses to your micro frontends stored in constants, and used to dynamically import a component from cross-origin.
const BrowsePage = await import(constants.pages.browse);

This isn't possible now due to this above issue.


Add types for Typescript imports

When doing i.e.
import MyImage from './myimage.png';

The Typescript compiler will complain.
The next-images project solves this by bundling a types declaration file: https://github.com/twopluszero/next-images/blob/master/index.d.ts
And then suggesting that you add a reference in next-env.d.ts: https://github.com/twopluszero/next-images#typescript

Hi @TranquilMarmot
This is the wrong repository, you probably wanted to create it in next-optimize-images, so I'll close it here. And for next-optimized-images: this is planned to be shipped with the next version.


Compress smbios headers

Signed-off-by: Itxaka<EMAIL_ADDRESS>

Codecov Report

Merging #132 (12e219a) into main (4c75b5c) will decrease coverage by 0.94%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
- Coverage   29.16%   28.22%   -0.95%
==========================================
  Files           5        5
  Lines         360      372      +12
==========================================
  Hits          105      105
- Misses        251      263      +12
  Partials        4        4

Impacted Files
Coverage Δ

pkg/server/register.go
12.50% <0.00%> (-0.84%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[SPARK-17365][Core] Remove/Kill multiple executors together to reduce RPC call time.

What changes were proposed in this pull request?

How was this patch tested?
Executed sample spark job to observe executors being killed/removed with dynamic allocation enabled.

Can one of the admins verify this patch?

ok to test

add to whitelist

Test build #65609 has started for PR 15152 at commit 5a185d2.

Test build #65609 has finished for PR 15152 at commit 5a185d2.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class SparkContext(config: SparkConf) extends Logging

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65609/
Test FAILed.

Test build #65618 has started for PR 15152 at commit d779a88.

Test build #65618 has finished for PR 15152 at commit d779a88.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test build #65655 has started for PR 15152 at commit bef1d1e.

Test build #65655 has finished for PR 15152 at commit bef1d1e.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65655/
Test FAILed.

Merged build finished. Test FAILed.

PySpark unit tests failure unrelated.

retest this please

Test build #65675 has started for PR 15152 at commit bef1d1e.

Test build #65675 has finished for PR 15152 at commit bef1d1e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65675/
Test PASSed.

@vanzin, @tgravescs Can you review these changes.
I will resolve the MiMa exclude merge conflicts once the PR is ready to be accepted - as these are being added often. Thanks.

Test build #65729 has started for PR 15152 at commit b76147c.

@vanzin - fixed minor nits and indentation.

Test build #65729 has finished for PR 15152 at commit b76147c.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ChiSqSelector @Since(\"2.1.0\") () extends Serializable
abstract class CompactibleFileStreamLog[T: ClassTag](
class FileStreamSinkLog(
  case class FileEntry(path: String, timestamp: Timestamp, batchId: Long = NOT_SET)
class FileStreamSourceLog(

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65729/
Test PASSed.

Test build #65740 has started for PR 15152 at commit 3d2fac4.

Test build #65740 has finished for PR 15152 at commit 3d2fac4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65740/
Test PASSed.

LGTM. Merging to master.


Read Application Creds from a json locale file.

Hi,
I've been using nconf module and one of the greatest things is that you can read some parameters from a file and if the file doesn't exists, read from environment variables like this :
nconf.file('local-settings.json').env();
Is it possible to add this to cfenv ? or it already exists ?
Thank you.

You can pass an object with the shape of a VCAP_SERVICES object to cfenv.getAppEnv(), in the vcap option.
I'm not sure how it would work to read environment variables for your VCAP_SERVICES, since it's not the easiest value to be setting as an env var.
I guess I'd like to see a somewhat thorough use case of using > 1 service, each having > 1 property in the services' credentials object, and how you would set these in a file, env vars, etc.

Thank you for your response.
Actually my issue was that I was able to use all the services connected to my application through credentials stored in a local JSON file. But when I push the application to Bluemix it just continues to crash because I couldn't get the credentials.
Basically, I didn't understand well the difference between VCAP_SERVICES object and application credentials.
After reading your IBM page :  https://developer.ibm.com/bluemix/2014/10/14/keeping-secrets-cloud-application-access-credentials-private-data/
I finally came up with this code, mixing the use of nconf and cfenv  :
//loading credentials from file
nconf.file('local-settings.json');
//loading
var appEnv = cfenv.getAppEnv();

//local configuration
if(nconf.get("applicationSecret")){
   config = {
       applicationRoute : nconf.get("applicationRoute"),
       applicationId : nconf.get("applicationId"),
       applicationSecret: nconf.get("applicationSecret")
   };
}else { // prod configuration
   config = appEnv.getServiceCreds(/session-secret/);
}

Now, when I run the server in my local machine I can use the Bluemix services like ibmdata to access data from Bluemix. And when the server runs from Bluemix it uses the "custom service" containing credentials.
I am not sure that this is the best way to do so ? but it works just fine.

Given the code you've provided, if you ever accidently include local-settings.json, then presumably it will be used instead of VCAP_SERVICES.  Of course, you may want to do that as well, and so that would be a good strategy.
cfenv includes a property in the appEnv object returned by cfenv.getAppEnv(), named isLocal.  It's how I determine if I'm running locally or in Cloud Foundry (eg, Bluemix).  All it does is check to see if the VCAP_APPLICATION environment is set - it will ALWAYS be set when running in Cloud Foundry, and I've never seen anyone set that env var when running locally.
Another option is to shape your local-setting.json to be the same shape as your VCAP_SERVICES, then you can do something like this:
var localVCAP = null
try { localVCAP = require("./local-vcap.json") } catch(e) {}

var appEnv = cfenv.getAppEnv({vcap: localVCAP})

The vcap property is only used by cfenv.getAppEnv() when running "locally" - it's ignored if you're running on Cloud Foundry.
Here's an example of a JSON file for your VCAP_SERVICES that you can use in this manner:

https://github.com/pmuellr/um-radio/blob/master/vcap-sample.json

Understood.
Thank you for all these tips !

closing as I believe this has been resolved


Do yo have plan to extend the capabilñity to Google Assistant

Hi
When I cast thing from google now, it list also my Google Assistant.
Do yo have plan to extend the capability to Google Assistant ?

Excuse mwe, i'ts working allready, but if I set the IP it dont't connect.


Fix stream-admin bugs.

The last commit looks wrong to me; I think we still need to check if the user was actually subscribed before removing their sidebar row.  I think we can just store the value at the start and then use it a few lines later.
Otherwise, the commits here look good.  I think we need 2 more things done:

We should update the discussion of  docs/security-model.md, probably in this PR, and open a follow-up issue for the remaining problem of what to do about removing other users from private streams.
The UI for admins looking at a private stream they're not subscribed to is still weird:

Either we need to give them the ability to remove users there, or we need to change the error message to explain that they don't have access, or something.

I re-pushed just a second ago related to what seems a spurious coverage complaint.

For the security model doc, it already claims admins can delete streams (I checked that earlier).

It's not clear to me that admins should be able to see subscribers of streams they're not subscribed to.  I agree that we probably need to do something on the UI side here to clarify the case of the right sidebar, even if it's just removing them from the "Streams" menu, so that admins only see them in the special case of the "Delete Streams" dialog.

Yeah, I think that gets into a policy issue.  I think I'd rather we go the route of adding "stream admin" users, but even that will have its challenges (what happens when the last "stream admin" for a stream has their account deactivated?).  It might be that practicality requires that admins have the ability to edit membership for all streams.
Perhaps the right answer is just to have admins have the ability to do that, but doing so notifies the user whose subscriptions are edited?

Or maybe you didn't attempt to fix this main issue yet?

The last commit looks wrong to me; I think we still need to check if the user was actually subscribed before removing their sidebar row. I think we can just store the value at the start and then use it a few lines later.

I merged this, with the last commit replaced by 37bf89292a7c49b4bcb001c781d400625817b113 to address the comment I had above.
I opened #6295 for the follow-ups we need to do here.

Thanks!  I looked at the commit you modified, and that makes sense to me.


Adding a message collector

Hi,
I wanted to add a message collector to the thread when someone sends a DM. What I'm trying to accomplish is something like:
-> User DMs the bot
-> The bot stores the message and asks them a followup question (i.e. What staff team are you attempting to contact?)
They enter some keywords (i.e. Support, General, Management) and the bot pings the appropriate group
The pinging issue I have no trouble doing. It's the part where I make it so the followup answer (to the question) is not logged in the ticket. Sorry if I'm being unclear haha.

Would this be against the Discord API TOS?

Yeah as a matter of fact, i'm actually working on that. I'll open the PR in a few days!

I like that idea, cool!


buildSelfArgument doesn't take convertTy

Clang was excessively warning about the convertTy param comment.
Removing it since the function doesn't take a convertTy parameter.

@swift-ci please smoke test

Should already be fixed by #60559 :)


Migrate to fast-classpath-scanner 4.0.0

Not ready to merge (we should wait for the final 4.0.0 release). Just to provide some feedback for https://github.com/lukehutch/fast-classpath-scanner/issues/215.

Coverage increased (+0.004%) to 90.351% when pulling 8e4618aea91f33537ddd99ed5da1e720573426dd on PascalSchumacher:classpath-scanner-4 into 8a9d79aebe2e0c54047911b777d93788da2fe18e on benas:master.

@lukehutch Thank you very much for the review!

Just a heads-up -- as of 4.0.0-beta-8, the package name of FCS has changed (removing ".lukehutch"), and the Maven groupId has changed to io.github.fast-classpath-scanner.

@lukehutch Thanks for the heads-up! I have updated the pull request to use the new groupId and the new package name.

It looks like you already noticed this, based on the edited title for the PR, but the groupId and package name have changed again, since I decided to rename the whole project to ClassGraph, and that this was the best time to do it. Thanks for staying on top of this, and for testing! Things will be stable again soon :-)

Pull request is ready to merge now, as ClassGraph 4.0.0 has been released.


add lg-thinq

RE-CHECK!

Automated adapter checker
ioBroker.lg-thinq

[ ] :heavy_exclamation_mark: [E104] No common.title found in io-package.json
[ ] :heavy_exclamation_mark: [E200] Not found on npm. Please publish
[ ] :heavy_exclamation_mark: [E802] No topics found in the repository. Please go to "https://github.com/TA2k/ioBroker.lg-thinq", press the settings button beside the about title and add some topics.
[ ] :eyes: [W400] Cannot find "lg-thinq" in latest repository

Add comment "RE-CHECK!" to start check anew

RE-CHECK!

Automated adapter checker
ioBroker.lg-thinq

[ ] :heavy_exclamation_mark: [E104] No common.title found in io-package.json
[ ] :heavy_exclamation_mark: [E802] No topics found in the repository. Please go to "https://github.com/TA2k/ioBroker.lg-thinq", press the settings button beside the about title and add some topics.
[ ] :eyes: [W400] Cannot find "lg-thinq" in latest repository

Add comment "RE-CHECK!" to start check anew

RE-CHECK!

Automated adapter checker
ioBroker.lg-thinq

[ ] :heavy_exclamation_mark: [E104] No common.title found in io-package.json
[ ] :eyes: [W400] Cannot find "lg-thinq" in latest repository

Add comment "RE-CHECK!" to start check anew

RE-CHECK!

Automated adapter checker
ioBroker.lg-thinq

:thumbsup: No errors found

[ ] :eyes: [W400] Cannot find "lg-thinq" in latest repository

Add comment "RE-CHECK!" to start check anew

Hi,
some review comments:

which such a construct you will not see if unload got called and e.g. in compact mode your code would run further, but the DB is gone after 500ms ... https://github.com/TA2k/ioBroker.lg-thinq/blob/master/main.js#L111 ... maybe add a check if unload was called? (and why the delay is needed?) same in https://github.com/TA2k/ioBroker.lg-thinq/blob/master/main.js#L238 ... or you need to adjust the "sleep" to that you can kill all the open sleep timeoiuts on unload!
https://github.com/TA2k/ioBroker.lg-thinq/blob/master/main.js#L726-L737 ... thaat makes not tht much sense ... on each data run you update the object - also when just before was created? This is not very performant and also no best practice! especially makes no sense inside https://github.com/TA2k/ioBroker.lg-thinq/blob/master/main.js#L690 ... in this code the onbject always exists ... ?! Same later in the code ...

Please check and adjust

Fixed both issue
Creation of objects happens only once on the initial load of the adapter

Please also release to npm

done


Update microsoft-office to 15.32.17030901

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Verified locally.


Sam 392 pv battery cost updates

Cost updates for PV and batteries based on:
https://github.com/NREL/SAM-documentation/blob/master/Defaults References and Tools/pv_and_battery_source_sheets/Inputs for SAM.xlsx for PV and
https://github.com/NREL/SAM-documentation/blob/master/Defaults References and Tools/pv_and_battery_source_sheets/BESS and PV%2BBESS Costs for SAM 2020-11-02.xlsx
Increase default PV sizes to 50 MW for utility scale and 500 kW for commercial. Re-order battery cost inputs in order to make it clear that $/kW already includes BOS and installation for the battery.

Looks good. I tweaked the UI a little in aeccd7b14:


Link widget breaks when ensureSemantics is enabled

Enabling semantics using SemanticsBinding.instance.ensureSemantics() causes the Link widget to break.
Steps to reproduce

Create a new Flutter project and copy the contents below
Run the app in Chrome and observe that the link doesn't work
Comment out SemanticsBinding.instance.ensureSemantics(), re-run and observe that the link now works.

Code snippet
main.dart:
import 'package:flutter/material.dart';
import 'package:flutter/semantics.dart';
import 'package:go_router/go_router.dart';
import 'package:url_launcher/link.dart';
import 'package:flutter_web_plugins/url_strategy.dart';

void main() {
  usePathUrlStrategy();
  runApp(const MyApp());
  SemanticsBinding.instance.ensureSemantics();
}

final GoRouter _router = GoRouter(
  routes: <RouteBase>[
    GoRoute(
      path: '/',
      builder: (BuildContext context, GoRouterState state) {
        return const HomeScreen();
      },
      routes: <RouteBase>[
        GoRoute(
          path: 'details-screen',
          builder: (BuildContext context, GoRouterState state) {
            return const DetailsScreen();
          },
        ),
      ],
    ),
  ],
);

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp.router(
      routerConfig: _router,
    );
  }
}

class HomeScreen extends StatelessWidget {
  const HomeScreen({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(title: const Text('Home Screen')),
      body: Center(
        child: Link(
          builder: (context, followLink) {
            return ElevatedButton(
              onPressed: followLink,
              child: const Text('Go to the Details screen'),
            );
          },
          uri: Uri.parse('/details-screen'),
        ),
      ),
    );
  }
}

class DetailsScreen extends StatelessWidget {
  const DetailsScreen({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(title: const Text('Details Screen')),
      body: Center(
        child: ElevatedButton(
          onPressed: () => context.go('/'),
          child: const Text('Go back to the Home screen'),
        ),
      ),
    );
  }
}

pubspec.yaml
name: link_widget_bug
description: "A new Flutter project."
publish_to: 'none'
version: 0.1.0

environment:
  sdk: '>=3.4.0-82.0.dev <4.0.0'

dependencies:
  flutter:
    sdk: flutter
  flutter_web_plugins:
    sdk: flutter
  go_router: any
  url_launcher: any

dev_dependencies:
  flutter_test:
    sdk: flutter
  flutter_lints: ^3.0.0

flutter:
  uses-material-design: true

cc: @mdebbar

I am also seeing this issue--we lose all link preview and context menu options

I am also seeing this issue.

This is still happing


[Branch 2.4] Cherry-pick bugfix from main to branch-2.4

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

@Mergify rebase


Text in controls not expanding on Android

I'm able to run the app on both iOS (iPod Gen 7 running iOS 15.4.1) and Android (Google Pixel 5 running Android 11) physical devices. However, as I add text to the Hello, World! label, it expands as it should on iOS , but is truncated on Android. This is also true of the text in the button. As you click it, the text indicating number of times it is clicked is visible on iOS, but truncated on Android.

Hi @msibalik
Sorry to hear that you're having problems. This is an issue with the product rather than with the docs, so I suggest you open an issue in the engineering repo. Thanks!

Thank you!
From: David Britch @.>
Sent: Friday, July 1, 2022 9:50 AM
To: dotnet/docs-maui @.>
Cc: Sibalik, Michael @.>; Mention @.>
Subject: [EXTERNAL]Re: [dotnet/docs-maui] Text in controls not expanding on Android (Issue #645)
CAUTION: THIS EMAIL ORIGINATED FROM OUTSIDE OF FAIRFAX COUNTY GOVERNMENT. Do not click links or open attachments unless you recognize the sender and know the content is safe!
Hi @msibalikhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmsibalik&data=05|01|michael.sibalik%40fairfaxcounty.gov|f7ffcf0285c14a8be3f608da5b6888e7|a26156cb5d6f41729d7d934eb0a7b275|0|0|637922801776370782|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=MhYA8Q5XC5FI4Nb%2FhHWFPSNHN%2B31dIGQXRGRqSVRzMk%3D&reserved=0
Sorry to hear that you're having problems. This is an issue with the product rather than with the docs, so I suggest you open an issue in the engineering repohttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2Fmaui&data=05|01|michael.sibalik%40fairfaxcounty.gov|f7ffcf0285c14a8be3f608da5b6888e7|a26156cb5d6f41729d7d934eb0a7b275|0|0|637922801776370782|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=tJfh9uOX1BB5Zl%2F1T21FBLrGdf%2B8n4%2BOCsL4zCfFjuQ%3D&reserved=0. Thanks!

Reply to this email directly, view it on GitHubhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2Fdocs-maui%2Fissues%2F645%23issuecomment-1172370339&data=05|01|michael.sibalik%40fairfaxcounty.gov|f7ffcf0285c14a8be3f608da5b6888e7|a26156cb5d6f41729d7d934eb0a7b275|0|0|637922801776370782|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=CMrGFs6PH%2FLvfvUCsCwAOMEgmhqwBAkbOKj9XutHdLM%3D&reserved=0, or unsubscribehttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAL4ZUOXXDNZ54HK2JNMUPGLVR3ZO7ANCNFSM5ZRG56LQ&data=05|01|michael.sibalik%40fairfaxcounty.gov|f7ffcf0285c14a8be3f608da5b6888e7|a26156cb5d6f41729d7d934eb0a7b275|0|0|637922801776370782|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=l7wguTeAmGh11XcyDdaZvhTC9ZgSapgOcEt8WkZiMOw%3D&reserved=0.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>


Low vram?

Hi, Unfortunately I don't have a good graphics card. Is there still ways to run this on 8gb of vram?

Hi @Zegervg, it should be fine for your card.
Let us know if it is not the case.

Idk man, doesnt look so good.

How many points do you have from your point cloud ?

17004 in the input.py if thats what you mean

It was fixed, the resolution for my input images were way to high. Thanks.


Add support for dns challenge

Since there is no single interface for administrating DNS servers a custom
script (specified with --challenge-script) is called by acme_tiny.py. The
script needs to support the following interface:
challenge_script (--add|--remove) --domain DOMAIN TXTRECORD
--add - add a TXT record
--remove - remove a TXT record
--domain DOMAIN - specify a domain name
TXTRECORD - value of a TXT record to be added or removed

Somewhat related - I've been using acme-tiny with this patch for several years - it runs a script after creating the HTTP challenge file, which lets me run acme-tiny on a different machine from the webserver (with the script syncing the challenge across). Looking at this pull request, it seems like it wouldn't be very hard to make --challenge-script work for that use case too...

@allanrbo I developed the patch, because I needed a wildcard certificate and the patch works for me. I am glad you have found problems I haven't. Sure, send your PR to my fork I will accept it and update this request.

Hi @steelman and @allanrbo do you have any update on this PR or event the other PR mentioned in this conversation ?
Are you still using this script?
Thanks for all the work put into this!


tests: clear tab cache in global teardown

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[x] Have you successfully run brew tests with your changes locally?

I'm planning on adding more to this global teardown, but I decided to just do this to start with so we could address the current CI failures ASAP (and see if anything breaks).

👍 Next suggestions: FileUtils.rm_rf a bunch of directories i.e. like https://github.com/Homebrew/brew/blob/ab9d8df792bca8292e815ebc635094b0474a6a44/Library/Homebrew/test/support/helper/integration_command_test_case.rb#L16-L41


visual glitch on http://docs.wagtail.io/en/v2.0/

Only documentation for 2.0 is affected.
It seems that it can be solved by setting background-color on body instead of html.

Hey @sir-sigurd, thanks for the report. Could you try your proposed fix and submit a PR?

Fixed with #4423 and merged with 63e824f


fix: update pgsql generate_search_column_expression

Description
PostgreSQL column names are case sensitive, and need to be quoted for certain behaviours.  The searchable() functionality currently handles case-sensitivity in the column's value, but not case-sensitivity in the column's name.
Most of the regular type query behaviour already quote column names, but the 'generate_search_column_expression' method does not.
If you've created mixed-case names via a migration file, the field will be created with surrounding double-quote marks
$table->string('MixedCase')->nullable();

will create a postgres field name of "MixedCase" not MixedCase.
Regular Eloquent usage typically quotes the column name
$c = Company::where('MixedCase', "dave")->get()

works fine.
The searchable method uses generate_search_column_expression which has
$column = match ($driverName) {
    'pgsql' => "{$column}::text",
    default => $column,
};

For pgsql connections, we'd get MixedCase::text which then gets 'lower()'ed later on.  But this query breaks because MixedCase doesn't exist as a column.  "MixedCase" does.
Changing the column naming behaviour to
$column = match ($driverName) {
    'pgsql' =>  "\"{$column}\"::text",
    default => $column,
};

addresses that.

[X] Visual changes (if any) are shown using screenshots/recordings of before and after.

Code style
No style changes.
'composer cs' shows 'command "cs" not defined.

[ ] composer cs command has been run.

Testing
Making a mixedCase-named column is now searchable, whereas before, it triggered a breaking error.

[X] Changes have been tested.

Documentation
No doc changes required.

[X] Documentation is up-to-date.

As far as I've read, this is nothing to do with lower(), it's just when you're using uppercase characters in the column name

I've updated it to only happen when you are using an uppercase character

Thanks @danharrin.   I knew there would likely be a more comprehensive way to address this, but don't have the depth of knowledge on this that you do (obviously).  Thank you for taking the issue seriously and addressing so promptly (and in a cleaner way!)


.travis.yml: validate consistency of generated files

If one forgets to commit changes to generated files, the build should fail
and the requested diff will be posted in the log.
Hence one could also simply apply the displayed patch in order to fix it.

I'm not sure I really want this.  Sometimes new contributors make their edits directly in GitHub and don't run npm run build.  I can always see when reviewing their pull requests whether the generated files were updated or not.
I think for now I'd prefer to have travis error on actual test failures only.

How about a new matrix element listed under allow_failures?
https://docs.travis-ci.com/user/customizing-the-build/#Rows-that-are-Allowed-to-Fail
Those editing over GitHub could at least get feedback about what else they would need to change.

The bigger pain point for me is that our test coverage needs to be much better.

We don't test anything under modules/ui, which is a significant chunk of iD.
We rely on PhantomJS to test the browsery parts of iD.  This is an old fork of webkit that, now in 2016, is even more outdated than IE11.

People forgetting to npm run build after changing presets isn't an actual problem I need solved right now.


fix coverage check in CI

Closes #2149

#2150  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Shoeboxam and the rest of your teammates on  Graphite

In this case the same output was tested elsewhere, I was considering the test to be whether or not the query would run at all under the conditions presented to it. Mentioning the print is good though and its frequent inclusion in these diffs is my oversight.
I don't know why that ignore was there-- it passes without that ignore. Removed it.
My attention is drawn to other things atm. If you want to work that change, then you're welcome to.

Thanks for the response. I'll give this a quick look and hopefully approve.

We have #1830 already

and in 2025 I could image switching gears for a bit and tackling that and some other tidying.


Module parse failed unexpected token When import a .css file to .tsx

I am creating a custom plugin Hello-world. I want to add components from PrimeReact library to HelloWorld.tsx, and it required these css
//theme
import "primereact/resources/themes/lara-light-indigo/theme.css";
//core
import "primereact/resources/primereact.min.css";

When I run npm run dev-server in superset-frontend I got this error
module parse failed unexpected token (1:0) you may need an appropriate loader to handle this file type ".primereact/resources/themes/lara-light-indigo/theme.css"
The problem is it can run normally with css style if I set symlinks: false in webpack.config.js. But when I did that, superset will not automatically rebuild whenever changes are made in my custom plugin project and I have to close the terminal and run npm run dev-server again. It took about over 5 minutes to run again instead of 15-20 seconds with symlinks: true and I don't want to wait so long just to see the results of 1 or 2 lines code
Here my plugin .tsx
/**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
 * to you under the Apache License, Version 2.0 (the
 * "License"); you may not use this file except in compliance
 * with the License.  You may obtain a copy of the License at
 *
 *   http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing,
 * software distributed under the License is distributed on an
 * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
 * KIND, either express or implied.  See the License for the
 * specific language governing permissions and limitations
 * under the License.
 */

//theme
import "primereact/resources/themes/lara-light-indigo/theme.css";

//core
import "primereact/resources/primereact.min.css";

import React, { useEffect, createRef } from "react";
import { styled } from "@superset-ui/core";
import {
  SupersetPluginChartHelloWorldProps,
  SupersetPluginChartHelloWorldStylesProps,
} from "./types";
import { DataTable } from "primereact/datatable";
import { Column } from "primereact/column";

// The following Styles component is a <div> element, which has been styled using Emotion
// For docs, visit https://emotion.sh/docs/styled

// Theming variables are provided for your use via a ThemeProvider
// imported from @superset-ui/core. For variables available, please visit
// https://github.com/apache-superset/superset-ui/blob/master/packages/superset-ui-core/src/style/index.ts

const Styles = styled.div<SupersetPluginChartHelloWorldStylesProps>`
  padding: ${({ theme }) => theme.gridUnit * 4}px;

  height: ${({ height }) => height}px;
  width: ${({ width }) => width}px;

  h3 {
    /* You can use your props to control CSS! */
    margin-top: 0;
    margin-bottom: ${({ theme }) => theme.gridUnit * 3}px;
    font-size: ${({ theme, headerFontSize }) =>
      theme.typography.sizes[headerFontSize]}px;
    font-weight: ${({ theme, boldText }) =>
      theme.typography.weights[boldText ? "bold" : "normal"]};
  }

`;

/**
 * ******************* WHAT YOU CAN BUILD HERE *******************
 *  In essence, a chart is given a few key ingredients to work with:
 *  * Data: provided via `props.data`
 *  * A DOM element
 *  * FormData (your controls!) provided as props by transformProps.ts
 */

export default function SupersetPluginChartHelloWorld(
  props: SupersetPluginChartHelloWorldProps
) {
  // height and width are the height and width of the DOM element as it exists in the dashboard.
  // There is also a `data` prop, which is, of course, your DATA 🎉
  const { data, height, width } = props;

  const rootElem = createRef<HTMLDivElement>();

  // Often, you just want to get a hold of the DOM and go nuts.
  // Here, you can do that with createRef, and the useEffect hook.
  useEffect(() => {
    const root = rootElem.current as HTMLElement;
    console.log("Plugin element", root);
  });

  console.log("Plugin props", props);

  return (
    <Styles
      ref={rootElem}
      boldText={props.boldText}
      headerFontSize={props.headerFontSize}
      height={height}
      width={width}
    >
      <h3>{props.headerText} 1234</h3>

        <DataTable value={data} rowGroupMode="rowspan" groupRowsBy="element" tableStyle={{ minWidth: '50rem' }}>
          <Column field="element" header="Element"></Column>
          <Column field="material" header="Material"></Column>
          <Column field="quantity" header="Quantity"></Column>
        </DataTable>

    </Styles>
  );
}

Here is my webpack.config.ts (inside my plugin project)
const webpack = require('webpack');
const path = require('path');
const HtmlWebpackPlugin = require('html-webpack-plugin');
const MiniCssExtractPlugin = require('mini-css-extract-plugin');

const config = {
    entry: './src/SupersetPluginChartHelloWorld.tsx',
    output: {
      path: path.resolve(__dirname, 'dist'),
      filename: 'bundle.js'
    },
    module: {
      rules: [
        {
            test: /\.css$/,
            use: [
                "style-loader",
                "css-loader",

            ],
            include: [
              path.resolve(path.join(__dirname, 'node_modules'))
            ]

        },
        {
          test: /\.ts(x)?$/,
          use:[
            {
              loader: 'babel-loader',
              options: {
                compact:true,s
              }
            },
          ],
          exclude: /node_modules/,

        },

      ]
    },
    plugins: [new HtmlWebpackPlugin()],
    resolve: {
      extensions: [
        '.tsx',
        '.ts',
        '.js',
        '.css'
      ]
    },
    devServer: {
      historyApiFallback: true,
      contentBase: './'
    }
  };

module.exports = config;

anyone can help ?

Unfortunately, this is not a Superset bug, and we're not often able to keep up with the backlog enough to troubleshoot custom code and custom plugins. Closing this as stale since it's been silent for so long, and we're trying to steer toward a more actionable Issues backlog. Thanks!


Dependencies inside of the "inline" question group are not hidden

Dependencies inside of the question group are not hidden on page load when  :display_type => :inline  is set for the group

survey "Test survey" do
  section "People" do
    group "Someone", :display_type => :inline do
      q_someone_deseased "Deseased", :pick => :one, :data_export_identifier => "someone_deseased"
      a_1 "Yes"
      a_2 "No"

      q_someone_age_at_death "Age at Death", :data_export_identifier => "someone_age_at_death"
      dependency :rule => "A"
      condition_A :q_someone_deseased, "==", :a_1
      a :integer, :custom_class => "short"

      q "Cause of Death", :data_export_identifier => "death_cause"
      dependency :rule => "A"
      condition_A :q_someone_deseased, "==", :a_1
      a :string

      q_someone_age "Age", :data_export_identifier => "someone_age"
      dependency :rule => "A"
      condition_A :q_someone_deseased, "==", :a_2
      a :integer, :custom_class => "short"

      q_someone_health_status "Health Status", :data_export_identifier => "someone_health_status"
      dependency :rule => "A"
      condition_A :q_someone_deseased, "==", :a_2
      a :string
    end
  end
end

Closed by 30b9fcc2497df7e08968a015ea2d693da6bc3233


CSS for logsite

https://github.com/PennyDreadfulMTG/logsite

This is now in a pretty good state sharing CSS with decksite. I added some pagination spacing in c4fac233.


Unable to add existing layer to Lambda function

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
No response
Amplify CLI Version
6.0.1
What operating system are you using?
Windows
Amplify Categories
function
Amplify Commands
update
Describe the bug
When adding an existing Lambda layer to a function with the cli, an error occurs.
? Which setting do you want to update? Lambda layers configuration
? Do you want to enable Lambda layers for this function? Yes
? Provide existing layers or select layers in this project to access from this function (pick up to 5): <redacted>
× Loading layer data from the cloud...
An error occurred fetching the latest layer version metadata for "<redacted>": User: arn:aws:sts::<redacted>:assumed-role/us-east-1_<redacted>_Full-access/amplifyadmin is not authorized to perform: lambda:ListLayerVersions on resource: arn:aws:lambda:us-east-1:<redacted>:layer:<redacted>-develop
Expected behavior
Lambda layers are listed and can be selected.
Reproduction steps
I cannot reproduce this in a new project.
GraphQL schema(s)

# Put schemas below this line

Log output

# Put your logs below this line

Additional information
No response

I have the same error, too.

I could resolve this problem by attaching AWSLambda_FullAccess Policy to us-east-1_<redacted>_Full-access  IAM role.

@NakZMichael Thank you so much! That did it for me. Should get me over the hump until this is resolved.

Hi @codenamegary and @NakZMichael, there seems to be a missing permission from the AdminUI role. Transferring this issue so that they can take a look.
"lambda:ListLayerVersions" is listed here: https://docs.amplify.aws/cli/usage/iam/
cc @abhi7cr


Issue template 1 of 2

Goal
Add structure to opened issues.
Notes
Was ambivalent on the examples at hand. This is GitHub’s default for feature requests. For comparison, #66 is one we used at a previous gig.

Looking at the file path, I guess GitHub allows separate templates for bugs and features now.


Provide a way to search / filter shortlinks

Currently the extension shows all shortlinks in the UI all at once. This works if there are 20 or 30 links. However, if there are 50 or more, then this becomes difficult to find what a user might be looking for.
It would be great to have a text field that allows the user to type a string. As they type, this can be used to filter what shortlinks are shown in the UI.

Hi @nazmulidris, I would like to work on this.

Hi 👋🏽 @dipushrestha , this issue is all yours 👍🏽 . Please take a look at our contributor guide. And we have a discord server if you would like to chat about the issue or PR.
Also, please associate your PR and issue using this technique: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

@nazmulidris I've raised a PR. Please take a look at it.

@dipushrestha Thank you 🙏🏽 🎉 I will take a look at this in the next day or so.

@dipushrestha Great work! 🎉


Openstack - Exception occurred while calling CreateAndBootVm(<BaseVirtualMachine [ip=None, internal_ip=None]>)

Hi, I try to run pkb on openstack victoria, when i use this command:
./pkb.py --cloud=OpenStack --machine_type=m1.small --openstack_network=provider --benchmarks=ping  --os_type=centos7 --openstack_image_username=centos
It gave an error:
`2021-06-01 09:54:06,579 dfaa48b5 MainThread ping(1/1) ERROR    Exception occurred while calling CreateAndBootVm(<BaseVirtualMachine [ip=None, internal_ip=None]>):
Traceback (most recent call last):
File "/root/PerfKitBenchmarker/perfkitbenchmarker/background_tasks.py", line 255, in Run
self.return_value = self.target(*self.args, **self.kwargs)
File "/root/PerfKitBenchmarker/perfkitbenchmarker/benchmark_spec.py", line 800, in CreateAndBootVm
vm.Create()
File "/root/PerfKitBenchmarker/perfkitbenchmarker/resource.py", line 262, in Create
self._PostCreate()
File "/root/PerfKitBenchmarker/perfkitbenchmarker/vm_util.py", line 271, in WrappedFunction
return f(*args, **kwargs)
File "/root/PerfKitBenchmarker/perfkitbenchmarker/providers/openstack/os_virtual_machine.py", line 119, in _PostCreate
self._SetIPAddresses()
File "/root/PerfKitBenchmarker/perfkitbenchmarker/providers/openstack/os_virtual_machine.py", line 351, in _SetIPAddresses
self.ip_address = self._GetNetworkIPAddress(server_dict, self.network_name)
File "/root/PerfKitBenchmarker/perfkitbenchmarker/providers/openstack/os_virtual_machine.py", line 359, in _GetNetworkIPAddress
addresses = server_dict['addresses'].split(',')
AttributeError: 'dict' object has no attribute 'split'
2021-06-01 09:54:07,096 dfaa48b5 MainThread ping(1/1) ERROR    Exception occurred while calling CreateAndBootVm(<BaseVirtualMachine [ip=None, internal_ip=None]>):
Traceback (most recent call last):
File "/root/PerfKitBenchmarker/perfkitbenchmarker/background_tasks.py", line 255, in Run
self.return_value = self.target(*self.args, **self.kwargs)
File "/root/PerfKitBenchmarker/perfkitbenchmarker/benchmark_spec.py", line 800, in CreateAndBootVm
vm.Create()
File "/root/PerfKitBenchmarker/perfkitbenchmarker/resource.py", line 262, in Create
self._PostCreate()
File "/root/PerfKitBenchmarker/perfkitbenchmarker/vm_util.py", line 271, in WrappedFunction
return f(*args, **kwargs)
File "/root/PerfKitBenchmarker/perfkitbenchmarker/providers/openstack/os_virtual_machine.py", line 119, in _PostCreate
self._SetIPAddresses()
File "/root/PerfKitBenchmarker/perfkitbenchmarker/providers/openstack/os_virtual_machine.py", line 351, in _SetIPAddresses
self.ip_address = self._GetNetworkIPAddress(server_dict, self.network_name)
File "/root/PerfKitBenchmarker/perfkitbenchmarker/providers/openstack/os_virtual_machine.py", line 359, in _GetNetworkIPAddress
addresses = server_dict['addresses'].split(',')
AttributeError: 'dict' object has no attribute 'split'
2021-06-01 09:54:07,100 dfaa48b5 MainThread ping(1/1) ERROR    Error during benchmark ping
Traceback (most recent call last):
File "/root/PerfKitBenchmarker/perfkitbenchmarker/pkb.py", line 903, in RunBenchmark
DoProvisionPhase(spec, detailed_timer)
File "/root/PerfKitBenchmarker/perfkitbenchmarker/pkb.py", line 642, in DoProvisionPhase
spec.Provision()
File "/root/PerfKitBenchmarker/perfkitbenchmarker/benchmark_spec.py", line 606, in Provision
vm_util.RunThreaded(
File "/root/PerfKitBenchmarker/perfkitbenchmarker/background_tasks.py", line 650, in RunThreaded
return RunParallelThreads(target_arg_tuples,
File "/root/PerfKitBenchmarker/perfkitbenchmarker/background_tasks.py", line 585, in RunParallelThreads
return _RunParallelTasks(
File "/root/PerfKitBenchmarker/perfkitbenchmarker/background_tasks.py", line 559, in _RunParallelTasks
raise parallel_exception_class(
perfkitbenchmarker.errors.VmUtil.ThreadException: The following exceptions occurred during parallel execution:
Exception occurred while calling CreateAndBootVm(<BaseVirtualMachine [ip=None, internal_ip=None]>):
Traceback (most recent call last):
File "/root/PerfKitBenchmarker/perfkitbenchmarker/background_tasks.py", line 255, in Run
self.return_value = self.target(*self.args, **self.kwargs)
File "/root/PerfKitBenchmarker/perfkitbenchmarker/benchmark_spec.py", line 800, in CreateAndBootVm
vm.Create()
File "/root/PerfKitBenchmarker/perfkitbenchmarker/resource.py", line 262, in Create
self._PostCreate()
File "/root/PerfKitBenchmarker/perfkitbenchmarker/vm_util.py", line 271, in WrappedFunction
return f(*args, **kwargs)
File "/root/PerfKitBenchmarker/perfkitbenchmarker/providers/openstack/os_virtual_machine.py", line 119, in _PostCreate
self._SetIPAddresses()
File "/root/PerfKitBenchmarker/perfkitbenchmarker/providers/openstack/os_virtual_machine.py", line 351, in _SetIPAddresses
self.ip_address = self._GetNetworkIPAddress(server_dict, self.network_name)
File "/root/PerfKitBenchmarker/perfkitbenchmarker/providers/openstack/os_virtual_machine.py", line 359, in _GetNetworkIPAddress
addresses = server_dict['addresses'].split(',')
AttributeError: 'dict' object has no attribute 'split'
Exception occurred while calling CreateAndBootVm(<BaseVirtualMachine [ip=None, internal_ip=None]>):
Traceback (most recent call last):
File "/root/PerfKitBenchmarker/perfkitbenchmarker/background_tasks.py", line 255, in Run
self.return_value = self.target(*self.args, **self.kwargs)
File "/root/PerfKitBenchmarker/perfkitbenchmarker/benchmark_spec.py", line 800, in CreateAndBootVm
vm.Create()
File "/root/PerfKitBenchmarker/perfkitbenchmarker/resource.py", line 262, in Create
self._PostCreate()
File "/root/PerfKitBenchmarker/perfkitbenchmarker/vm_util.py", line 271, in WrappedFunction
return f(*args, **kwargs)
File "/root/PerfKitBenchmarker/perfkitbenchmarker/providers/openstack/os_virtual_machine.py", line 119, in _PostCreate
self._SetIPAddresses()
File "/root/PerfKitBenchmarker/perfkitbenchmarker/providers/openstack/os_virtual_machine.py", line 351, in _SetIPAddresses
self.ip_address = self._GetNetworkIPAddress(server_dict, self.network_name)
File "/root/PerfKitBenchmarker/perfkitbenchmarker/providers/openstack/os_virtual_machine.py", line 359, in _GetNetworkIPAddress
addresses = server_dict['addresses'].split(',')
AttributeError: 'dict' object has no attribute 'split'  `
Can you help me? Is there any bug ?

It seems that VM was not created successfully. PKB can't get the VM ip address.

I follow the test, virtual machine are created, then running openstack server show pkb-e03958f0-0 --format json, the result is http://paste.openstack.org/show/806254/ . It didnt take IP address, I didnt understand.

Your paste shows there's a dict with a provider inside the addresses and then the actual IP:
  "addresses": {
    "provider": [
      "<IP_ADDRESS>"
    ]
  },

Whereas the code seems to expect addresses as a comma separated list:
addresses = server_dict['addresses'].split(',')
Perhaps the code and the CLI are out of sync?

I'm sure, they are sync. But the code didnt working, It cant separate IP address.

I use Openstack Victoria version, and i installed latest openstack-client (5.5.0), but I checked Victoria OpenstackClient (https://releases.openstack.org/victoria/index.html#victoria-python-openstackclient), so I fixed my openstackclient, the error handled, perfkitbenckmarker is working.


improved the package to be cross platform with no dart:io references, and pumped versions

LGTM.
This is some good work @ahmednfwela.
Thanks for contributing.

@danvick can you close all the linked issues as well ?


Added new version of the Registrar

Codecov Report

Merging #354 (5e8f774) into main (3200ab1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #354   +/-   ##
=======================================
  Coverage   28.32%   28.32%
=======================================
  Files          16       16
  Lines        1762     1762
=======================================
  Hits          499      499
  Misses       1218     1218
  Partials       45       45

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3200ab1...5e8f774. Read the comment docs.


TypeScript Syntax Highlighting Broken with RegExp

VSCode Version: 1.14.2
OS Version: Windows 10

Steps to Reproduce:

Reproduces without extensions: Yes

Nevermind, this appears to be fixed in 1.15.


Dependency crawling fails if artifact is not on maven central

Example: exasol-testcontainers

I also encountered this problem. Would be nice to have it fixed soon


csp: Update bignumber to not use use unsafe-eval

Update bignumber to prevent violating unsafe-eval csp rule for all libraries that use it.

See What is the difference between Function('return this') and function() {return this}? and What is the purpose of Function('return this')(), and here for an extended explainer.
I am aware of the CSP issue, but up to now I have not felt moved to remove the Function call, because it's the only reliable solution to get the global object.
On reflection, I am willing to go with
globalScope = typeof self != 'undefined' && self ? self : window;

If you amend your PR accordingly I will accept it.
Thanks for prompting me to look again at this.

@MikeMcl PR updated. Let me know if anything else needed for this to get in.
Thanks!


How to pass environment variables to the build? (RDT-308)

I would like to set PROJECT_VER and PROJECT_NAME environment variables. How can this be accomplished?

Hi @rodja
You can override the default command in your workflow:
...
    - name: esp-idf build
      uses: espressif/esp-idf-ci-action@v1
      with:
        command: 'PROJECT_VER="1.0.0" idf.py build'

Thanks, I'll try that.


Python 3 support

It looks like this project wouldn't take much work to get python 3 support. I think the models.pyfile just needs from __future__ import unicode_literals, and the __unicode__ reference would need to be __str__ on python 3.

If you checkout the latest version from github it should work with python 3, but I have to do some more testing and some other changes to make a pypi release compatible with python 3.

Python 3 support is now added in version 0.6.0. Please let me know if you have any problems with it.
:+1:


94407712 date validation error on dwp check form

Prevent the error popping up when an invalid date is entered for the date of birth of for the date_application_made.
Also added constraints such as 16 years being the minimum age and 120 years being the maximum age of an applicant. The logic is that we've agreed as a team to have 120 be the maximum age. For minimum age, the reason it's 16 is because you get your national insurance card at that age.

Looks good to me :+1:


Translation failing due to NoneType error

I'm thinking that this error is similar to the errors we have seen before.
Traceback (most recent call last):
  File "translate.py", line 48, in <module>
    translations = trans.translate(entrytext, src=src_lang, dest=dest_lang)
  File "D:\Users\user1\AppData\Local\Programs\Python\Python38\lib\site-packages\googletrans\client.py", line 177, in translate
    translated = self.translate(item, dest=dest, src=src, **kwargs)
  File "D:\Users\user1\AppData\Local\Programs\Python\Python38\lib\site-packages\googletrans\client.py", line 185, in translate
    translated = ''.join([d[0] if d[0] else '' for d in data[0]])
TypeError: 'NoneType' object is not iterable

What's your text input in this case?

It was just a normal text file in unicode. no special characters. Other people on my time also experienced the same issue. We use your module on one of our internal scripts. Really good work. Just wanted to say thank you!
If you want I can share the input text file.

Thank you for letting me know! I tried to produce the same error as you listed above but just got something similar. I had the same TypeError msg when I put ["a", None] or [None] as my input. Your Pull Request would avoid the error. However, considering you were reading from a text file, there might be some different situations when encountering None type. If you could clarify your input or give just some samples referring to your case, that would help a lot :)

Sorry. I couldn't procure the input text file. What I can tell you is that it was an i18n file. I was translating from English to other languages.

After discussing about this issue, we consider it as a personal issue. Not everyone wants to avoid interruption during translating. Some of them could may just mess their inputs up. Hence the interruption is essential. I'll also close the related pull request.


App with multiple windows

I am using Appium to drive a Windows App, it loads correctly and I can use the driver to interact with the UI Pane correctly, but it's an App that has multiple windows to go through while authenticating. Once the first window that was launched by Appium opens the next window and closes, the driver is no longer able to interact with the new window.
Is there an approach for the driver passing control to the new window so I can use the driver to interact with it?
(driver.window_handles contains the original window, and then when going to the next one, is empty)

It may not be the best solution but i think it can help you out.
At first, you may create session as app 'root'.
Whenever the login form open, you create another session base on the top level window - the login window. You continue use this session for something before login.
Whenever the second form open, the login form is closed, you create another session base on the second form and use it to do the rest.
About how to create session base on window, you may see the comment here: https://github.com/microsoft/WinAppDriver/issues/92#issuecomment-323217558
Hope it can help :)

I am not entirely certain as to what you mean by multiple windows. Multiple simultaneously open, or sequentially opened being the uncertainty.
I assume sequentially opened and closed
There is an event which initiates the sequence, it is generated somehow. Once the event occurs there is a sequence of conditions which you wish to observe. Each condition consists of a Window being vanishing (either closed or no longer visible) followed by a Window becoming observable (either created or made visible). To monitor these conditions I developed two procedures (which if I have inserted them properly you will find in the file immediately below).
The procedures have not been rigorously tested. You will have to modify them fro your own purposes. They are based your locating the title of the window by name. They have timeouts which must be provided as an argument (the timeouts are application specific)
findWindow.txt

I'd also recommend switching to a Desktop session to interact with the other windows and then switching back to the original session.

@khoachung89 thanks for that suggestion, I used the linked article to create the driver as root, and then have managed to create a driver for a given web element window.


Additional headers now required

As identified here:
https://teslamotorsclub.com/tmc/threads/error-in-tesla-api.127239/
Responses will now have a 503 error status code unless additional headers are added.
User-Agent: Mozilla/5.0 (Linux; Android 9.0.0; VS985 4G Build/LRX21Y; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/58.0.3029.83 Mobile Safari/537.36

X-Tesla-User-Agent: TeslaApp/3.4.4-350/fad4a582e/android/9.0.0

The values don't have to be these exactly, but the headers must exist. It'll probably help Tesla with their metrics actually if you supply your own values. For instance, my X-Tesla-User-Agent was set to custom/ARC and worked just fine.
Otherwise Tesla will think people are using old versions of their app.
As a reminder, you'll also want the following headers on all your POST requests, except of course the request for your authentication token which gives you the ${auth} doesn't need the authorization header yet.
content-type: application/json
authorization: Bearer ${auth}

UA is now required but X-Tesla-User-Agent is not (as far as I have seen).

I didn't test each one just saw that the app was passing both and added both in.

are you sure these headers are required? i  authenticated just fine without them

@jonasman  is it possible your client is setting a default UA if you don't?  I was unable to get it to work without specifying some UA instead getting back the supercharger  error.

@mitchcapper nothing:
REQUEST: https://owner-api.teslamotors.com/oauth/token
METHOD: POST
Request Headers: [
"Content-Type": "application/json"
]
Request Body: {
  "client_id" : "e4a9949fcfa04068f59abb5a658f2bac0a3428e4652315490b659d5ab3f35a9e",
  "email" : "yyyyy",
  "password" : "xxxx",
  "client_secret" : "c75f14bbadc8bee3a7594412c31416f8300256d7668ea7e6e7f06727bfb9d220",
  "grant_type" : "password"
}

RESPONSE: Optional(https://owner-api.teslamotors.com/oauth/token)
StatusCode: 200
Headers: [
"Content-Type": "application/json"
]
Respose Body: {"access_token":"XXXXXXX","token_type":"bearer","expires_in":3888000,"refresh_token":"YYYYY","created_at":1536599091}

REQUEST: https://owner-api.teslamotors.com/api/1/vehicles/XXXX/command/door_lock
METHOD: POST
Request Headers: [
"Authorization": "Bearer YYYYY"
]

RESPONSE: Optional(https://owner-api.teslamotors.com/api/1/vehicles/XXXX/command/door_lock)
StatusCode: 200
Headers: [
"Authorization": "Bearer YYYY"
]
Respose Body: {"response":{"reason":"","result":true}}

While it's possible... I just removed the user agent and it's still required. My guess is either your client is automatically adding a user agent which you'll have to see by using wireshark or fiddler or your account somehow doesn't require it.

I vote for the last.
I tested my lib with another guy. Fir him it requires the user-agent while for me it does not.
Sent from my iPhone
On 16 Sep 2018, at 5.06, mrmorder <notifications<EMAIL_ADDRESS>wrote:
While it's possible... I just removed the user agent and it's still required. My guess is either your client is automatically adding a user agent which you'll have to see by using wireshark or fiddler or your account somehow doesn't require it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/timdorr/model-s-api/issues/79#issuecomment-421672319, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABrmXl5skAAmDZly8d6Zo2SgjgI9lLraks5ubbIQgaJpZM4WZET9.

@jonasman What vehicles do you both have?

@timdorr  M3 and new account for me required it.

@timdorr you can follow our discussion here: https://github.com/jonasman/TeslaSwift/issues/21
We have: Model S, old MCU, 2018.32.4

Model S 2015. Mine requires the User-Agent, and like others have pointed out, the X-Tesla-User-Agent wasn't necessary after all.
My car_version is "2018.34.1 3dd3072" and perhaps more importantly, the api_version is 3. Maybe it's an api version 2 vs version 3 change.

Model S/X 16/18. My guess is that there'll be a large api update anyway on the release of the version 9 update for S/X.

@matthew-pakulski API version 3 here


Add hover to the images of landing page

https://github.com/SrijanShovit/carbonops-v2/assets/100708686/b291f5f3-1130-41e5-86ac-5dd63913293f
Add this hiver effect to the static images of the website
Please assign this issue to me under GSSoC'23 label

Hello Akanksha-202, thanks for opening a issue, your contribution is valuable to us. The maintainers will review this issue and provide feedback as soon as possible.

Not required


Handle dataclasses with unitialized fields in pretty printing

Fixes https://github.com/Textualize/rich/issues/3417
Type of changes

[x] Bug fix
[ ] New feature
[ ] Documentation / docstrings
[ ] Tests
[ ] Other

Checklist

[x] I've run the latest black with default args on new code.
[x] I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
[x] I've added tests for new code.
[x] I accept that @willmcgugan may be pedantic in the code review.

Description
This is a fix for #3417. If the field has no defined attribute, then the default value should be printed instead, rather than raising an uncaught AttributeError.

This probably isn't the fix. It can give the false impression that the attribute exists. Better to omit it entirely IMO.

Sure, I've made that change.

Thanks, but I've gone with a slightly different solution... https://github.com/Textualize/rich/pull/3472


Soundcloud issue

What version of Music Assistant has the issue?
2.0.0b127
What version of the Home Assistant Integration have you got installed?
2024.3.5
Have you tried everything in the Troubleshooting FAQ and reviewed the Open and Closed Issues and Discussions to resolve this yourself?

[X] Yes

The problem
Songs from soundcloud doesn't play any sound. Playback is starting but without Sound. I tried different players.
How to reproduce
Play a track on any player with soundcloud
Music Providers
Soundcloud
Player Providers
All
Full log output
No response
Additional information
No response
What version of Home Assistant Core are your running
2024.3.3
What type of installation are you running?
Home Assistant OS
On what type of hardware are you running?
Linux

Try again with b128

I tried it right a way, but still no sound.
Are there specific tests, that i can try after update?

Clear the MA cache

I tried this as well but it doesn't fix it.

Does a different music provider work?

Yes, i noticed this only on Soundcloud music provider

b129 doesnt fixed it too

@gieljnssns ?

This issue is fixed in the next beta (beta 131)!

Yes it's fixed but on my homeassistant i must enable "lossy mp3" in the player options, but then the track stops after 4 seconds (only on soundcloud). Can you fix this?
Thank you for your great support

Yes it's fixed but on my homeassistant player (esphome) i must enable "lossy mp3" in the player options, but then the track stops after 2- 5 seconds (only on soundcloud). Can you fix this?
Thank you for your great support

Please create a new issue for that and also mention (and test!) if this happens to all media sources and only to this player(type) or also others. Do notice that the esphome mediaplayer was never designed for actual music playback but mre for short audio clips or some low bandwidth radio streaming. If you want music player on ESP32 products, use squeezelite32 or snapcast firmware which are optimized for music playback.


Colour Picker: Current Values

It would be helpful if the colour pickers on the Settings|Configure Site page displayed the current colours used on the site to give a frame of reference and to save having to find the colours manually.

OK, so this is only an issue if the colours have not been set previously, and the default CSS is applied. Not really a problem then.


Fall back when image too large for webp

Instead of failing to write file, fall back to png so the time and effort havent been wasted.
Pls no more of this :(
imwrite_('/home/katt/file_[NS-L1][x2.000000].webp'): can't write data: OpenCV(4.1.0) /build/opencv/src/opencv-4.1.0/modules/imgcodecs/src/grfmt_webp.cpp:304: error: (-215:Assertion failed) size > 0 in function 'write'

cv::imwrite("/home/katt/file_[NS-L1][x2.000000].webp") failed
Done, took: 99.485s total, file: 99.485s avg: 99.485s
Finished processing 1 files
Took: 100.141secs total, filter: 81.263secs; 0 files skipped, 1 files errored. [GFLOPS: 2677.08, GFLOPS-Filter: 3299.00]

You should've added that the reason for this is that WebP only supports images up to 16383 x 16383.
From their FAQ:

What is the maximum size a WebP image can be?

WebP is bitstream-compatible with VP8 and uses 14 bits for width and height. The maximum pixel dimensions of a WebP image is 16383 x 16383.

oh WebP max is 16383? then we need some check function for it..

Yep, and we should not fall back, but instead error out, the user asked for WebP not PNG.

Then please add it as an option to fallback? I'd much rather have a PNG file than no file at all.

we can add error message and abort before conversion. not after operating it.

That is what i meant yes.

Still annoying for batch jobs of say 300 images as the end output is quite useless for figuring out which files errored out.

Actually I don't understand why images needs to be bigger then 16383x16383.. image file size is more than 300MB each and it will require tons of times to run.. and run it in batch..???????? it will takes days!


Allow high ascii (0x80-0xFF) in memcached keys

Based on memcache's protocol.txt
Also rejecting zero-length keys and added some tests.
@nsauro @DanSimon

Current coverage is 80.23%

Merging #283 into master will increase coverage by +0.06% as of f2f5d67

@@            master    #283   diff @@
======================================
  Files           70      70
  Stmts         3505    3507     +2
  Branches       442     444     +2
  Methods          0
======================================
+ Hit           2810    2814     +4
  Partial          0       0
+ Missed         695     693     -2

Review entire Coverage Diff as of f2f5d67

Powered by Codecov. Updated on successful CI builds.

I personally vote we drop all validation logic.  This is very clearly adding a performance hit and we are simply attempting to duplicate logic that memcached is already going to do itself.  Especially considering that any such invalid keys are going to be very far and few.
Furthermore, it looks like what it says in protocol.txt is not true.  I successfully set memcache keys that included tabs, backspace characters, and bell characters (which amusingly actually beeps my terminal when I retrieve the key).  So while I cannot imagine a legit use case of setting such keys, we could end  up in a situation where they exist and we'd be unable to work with them.
As a compromise, what we can do is perhaps only do the validation when we receive either an ERROR or CLIENT_ERROR so we can perhaps return a better error message to the user.

Per Dan's point, validation is a mistake unless you can do it 100% correctly. It shouldn't be hard, but the documentation in memcached about this isn't great. So I dumped the validation.
What I added in its place was some better handing of the errors we are getting already, including propagating the server-provided error messages up to the caller. At that point, the invalid key stuff became meaningless. The only test we should consider putting in there is that the key cannot include the SPACE character because we know that would break the protocol -- it is used to delimit between the key and the flags.

Sorry, Dan. We need to ensure we aren't breaking the protocol. The way the memcache protocol is structured, we won't necessarily get an error from the server if there is a busted key. In fact, under some circumstances the server may TRUNCATE the key on storage and then REJECT the key on fetch.
The validation is quite fast, on the order of 1.5E8 key characters/sec on my MacBook, regardless of how long I make the keys.

I ran a benchmark, but I don't love it. I chained GETs or SETs together using Future.flatMap, hitting the same key, making it essentially single threaded. The memcached instance was running on my Mac, as was the test code. Results below are sorted by operation, validation mode, and speed. The keys were 250 chars, maximizing the pain for the validation version. The performance difference was below the threshold of measurement even though we were running at latencies around 1.4ms.
GET with validation completed 1000 in 1381.830 ms. 723.67752 iterations/sec
GET with validation completed 1000 in 1412.020 ms. 708.2048 iterations/sec
GET with validation completed 1000 in 1416.739 ms. 705.845915 iterations/sec
GET with validation completed 1000 in 1424.332 ms. 702.083436 iterations/sec
GET with validation completed 1000 in 1435.869 ms. 696.442160 iterations/sec

GET without validation completed 1000 in 1384.155 ms. 722.462326 iterations/sec
GET without validation completed 1000 in 1386.960 ms. 721.001166 iterations/sec
GET without validation completed 1000 in 1393.307 ms. 717.716683 iterations/sec
GET without validation completed 1000 in 1398.464 ms. 715.07005 iterations/sec
GET without validation completed 1000 in 1439.648 ms. 694.613903 iterations/sec

SET with validation completed 1000 in 1413.784 ms. 707.321216 iterations/sec
SET with validation completed 1000 in 1428.993 ms. 699.79306 iterations/sec
SET with validation completed 1000 in 1430.047 ms. 699.277595 iterations/sec
SET with validation completed 1000 in 1449.220 ms. 690.025914 iterations/sec
SET with validation completed 1000 in 1520.941 ms. 657.487421 iterations/sec

SET without validation completed 1000 in 1416.443 ms. 705.993433 iterations/sec
SET without validation completed 1000 in 1418.774 ms. 704.833432 iterations/sec
SET without validation completed 1000 in 1425.187 ms. 701.66206 iterations/sec
SET without validation completed 1000 in 1426.371 ms. 701.079613 iterations/sec
SET without validation completed 1000 in 1711.524 ms. 584.274328 iterations/sec

:+1:


[Select] Revert "Update renderValue prop's TypeScript type (#34177)"

This reverts commit fea32daecc1e7dbf65241d859935eb9ed67885f2 (PR #34177).
Fixes #35728 but reopens #34083.
The #34177 PR can be reapplied in v6 as it causes a breaking change in type definitions.

Thanks @michaldudak.  I took a stab at trying to fix the issue as well and here's where I ended up.
I fully understand the value adding stronger types may have added, but I don't know if it belongs in the core library.  Anytime you try to make interface properties change their type based off sibling interface properties (i.e. displayEmpty affecting renderValue) that feels best served as a runtime check OR splitting the interface to break the dependency.
For instance:
interface DisplayNotEmpty<T> {
      displayEmpty?: false;
      multiple?: boolean;
      renderValue?: (value: T) => React.ReactNode;
}

interface DisplayEmpty<T> {
      displayEmpty?: true;
      multiple?: false;
      renderValue?: (value: T | '') => React.ReactNode;
}

interface DisplayEmptyMultiple<T> {
      displayEmpty?: true;
      multiple?: true;
      renderValue?: (value: T) => React.ReactNode;
}

export interface SelectProps<T> extends CommonProps<T> {
  renderType: DisplayNotEmpty<T> | DisplayEmpty<T> | DisplayEmptyMultiple<T>
}

Allows for:
interface SelectExProps extends SelectProps<number> {

}

Example here - https://codesandbox.io/s/awesome-dewdney-r0vrpk?file=/src/App.tsx

@michaldudak Thanks for the quick PR. I didn't anticipate this would cause an issue in #34177 .


0.14 Release

0.14 Release

Current coverage is 82.92% (diff: 100%)

Merging #178 into master will not change coverage

@@             master       #178   diff @@
==========================================
  Files           179        179
  Lines         13257      13257
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits          10994      10994
  Misses         2263       2263
  Partials          0          0

Powered by Codecov. Last update acfad1d...ccea9ba


cleanup in setting default cpu model

What this PR does / why we need it:
This PR changes the way the default CPU model is fetched from kubevirt-config. It is now fetched via the virt-config package. This allows concentrating all configurable virt-properties in a single place and provides a unified way to access them.
Release note:

NONE

/cc @fromanirh  @ksimon1

/cc @rmohr

Hm, I don't think this is the right way to go. Before your change you could simply change the config map and virt-api picked the change up. Now one would have to restart virt-api. I think the better way is to over-time let all components detect config changes, immediately pick them up, reconfigure itself, or simply exits so that it gets restarted with the new config.
I think that values which can be updated dynmaically should use the informer in the config package and we should add more dynamic config mechanisms (like callbacks) over time, so that kubevirt reconfigures itself completely. Here a simple example in a PR which did not get merged, regarding to using the informers in the config: https://github.com/kubevirt/kubevirt/pull/1404/commits/037f153050690b7f3c97d1ad55ce916fa2d82dc4#diff-091ace02b49a46f55f2586cfec89a160.

@rmohr , Fair enough, oVirt also supports getting the most up-to-date configuration without restart for some configuration values - that can be useful. I would still claim that having all the configurable virt-properties placed together makes the code more organized though - how about having pkg/virt-config/config-map listen to changes in the config-map and reloading the updated configuration?

how about having pkg/virt-config/config-map listen to changes in the config-map and reloading the updated configuration?

Works for me. You can have a look on the referenced commit. It does that. You can copy from there anything you want if it helps.

@ahadas current master contains now a reworked config-map.go where you could tie in your changes.

@rmohr , done.
could you please take a look at mutating-webhook_test.go - I tried to mock kubevirt-config with some value for 'cpu-model' but it doesn't seems to work. what am I missing?

@rmohr , done.
could you please take a look at mutating-webhook_test.go - I tried to mock kubevirt-config with some value for 'cpu-model' but it doesn't seems to work. what am I missing?

and it seems to work just fine when deployed - that's why the mocking seems problematic

and it seems to work just fine when deployed - that's why the mocking seems problematic

@ahadas I made MakeFakeClusterConfig in testutils over-complex. I guess that is the issue. I would suggest something like this in testutils:
func MakeFakeClusterConfig(configMap v1.ConfigMap) (*virtconfig.ClusterConfig, cache.Store) {
	store := cache.NewStore(cache.DeletionHandlingMetaNamespaceKeyFunc)
	copy := configMap.DeepCopy()
	copy.Name = "kubevirt-config"
	copy.Namespace = "kubevirt"
	copy.ResourceVersion = rand.String(10)
	store.Add(copy)
	return virtconfig.NewClusterConfig(store, "kubevirt"), store
}

func UpdateFakeClusterConfig(config v1.ConfigMap, store cache.Store) {
	copy := config.DeepCopy()
	copy.Name = "kubevirt-config"
	copy.Namespace = "kubevirt"
	// Change the resource version, or the config will not be updated
	copy.ResourceVersion = rand.String(10)
	store.Update(config)
}

Changes should then always be immediately picked up when passing a changed config

and it seems to work just fine when deployed - that's why the mocking seems problematic

@ahadas I made MakeFakeClusterConfig in testutils over-complex. I guess that is the issue. I would suggest something like this in testutils:
func NewFakeClusterConfig(configMap v1.ConfigMap) (*virtconfig.ClusterConfig, cache.Store) {
	store := cache.NewStore(cache.DeletionHandlingMetaNamespaceKeyFunc)
	copy := configMap.DeepCopy()
	copy.Name = "kubevirt-config"
	copy.Namespace = "kubevirt"
	copy.ResourceVersion = rand.String(10)
	store.Add(copy)
	return virtconfig.NewClusterConfig(store, "kubevirt"), store
}

func UpdateFakeClusterConfig(config v1.ConfigMap, store cache.Store) {
	copy := config.DeepCopy()
	copy.Name = "kubevirt-config"
	copy.Namespace = "kubevirt"
	// Change the resource version, or the config will not be updated
	copy.ResourceVersion = rand.String(10)
	store.Update(config)
}

Changes should then always be immediately picked up when passing a changed config

Ack, thanks.
As it is still not clear to me how to use that as part of the tests of the mutating-webhook (I don't see how to create an informer that can be set in webhooks#informers out of the returned store), how about handling it separately? the current state of the PR is IMO improves the current state of the code, and the tests worked in a similar way before...

As it is still not clear to me how to use that as part of the tests of the mutating-webhook (I don't see how to create an informer that can be set in webhooks#informers out of the returned store), how about handling it separately? the current state of the PR is IMO improves the current state of the code, and the tests worked in a similar way before...

Yep needs a refactoring. Now with the cluster config in place it is now possible when wiring the webhook to pass in the final configuration of the cluster config, and not the informers.
I would prefer to see it in this PR but do not insist on it. In general the webhooks should be moved to a struct instead of being standalone functions. I think the time for that change has come.

@rmohr I see your point, but I think it would make this PR too broad. Let's keep its original scope and introduce those changes separately, please.

Test failures are unrelated.


https://boxstarter.org/bootstrapper.ps1 gives 404 error

What You Are Seeing?
The bootstrapper.ps1 script is not available anymore for download from https://boxstarter.org/bootstrapper.ps1
What is Expected?
Have the script available online at the forementionned url as it has been for many years.
How Did You Get This To Happen?

execute command:

. { iwr -useb http://boxstarter.org/bootstrapper.ps1 } | iex; get-boxstarter -Force
you'll get the following result:
iwr : The remote server returned an error: (404) Not Found.
At line:1 char:5
+ . { iwr -useb http://boxstarter.org/bootstrapper.ps1 } | iex; get-box ...
+     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (System.Net.HttpWebRequest:HttpWebRequest) [Invoke-WebRequest], WebExc
   eption
    + FullyQualifiedErrorId : WebCmdletWebResponseException,Microsoft.PowerShell.Commands.InvokeWebRequestCommand

get-boxstarter : The term 'get-boxstarter' is not recognized as the name of a cmdlet, function, script file, or
operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try
again.
At line:1 char:63
+ ... http://boxstarter.org/bootstrapper.ps1 } | iex; get-boxstarter -Force
+                                                     ~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (get-boxstarter:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException

@jumar please accept my apologies regarding this!
Yesterday we moved the Boxstarter website over to new infrastructure, and we believed that everything had been moved over correctly, but looks like this has been miised.
This script should now be back in place.
Please let us know if you run into any other issues with the site in the new location.

@jumar if you can let me know if this is now resolved for you, I will go ahead and close out this issue.


POST to API endpoint with fetch()

Hi everyone :wave:
I'm implementing Staticman on my GatsbyJS site, and it's looking great!
The only thing is that I want my comment submission event to adapt to React (no page reload for starters), so I'm turning action="https://dev.staticman.net/..." method="POST" into a handleSubmit function that POSTs the event via fetch():
async handleSubmit(event) {
  event.preventDefault() // stop the form from submitting

  const request = await fetch("https://dev.staticman.net/v3/entry/github/robinmetral/eaudepoisson/master/comments", {
    method: "POST",
    body: event,
  })

  const response = await request.json()
  console.log(response)
}

However I get this error as a response:
errorCode: "MISSING_PARAMS"
data: [fields]
success: false

Staticman doesn't recognize the required fields in my event object. I've also tried to turn the object into a JSON string, but I've had the same error.
Is the API endpoint only allowing the x-www-form-urlencoded POST format? Has anyone been using fetch() to POST to Staticman?

Glad to see that posting solutions in here is useful @kyrelldixon :slightly_smiling_face: Happy commenting!

@robinmetral thanks a lot, it's worked for me, but, what was driving me nuts was this
Step 3. Hook up your forms
Forms should POST to:
https://api.staticman.net/v2/entry/{GITHUB USERNAME}/{GITHUB REPOSITORY}/{BRANCH}/{PROPERTY (optional)}
But looking at your code, at the end it seems that should post there:
https://api.staticman.net/v2/entry/**github**/{GITHUB USERNAME}/{GITHUB REPOSITORY}/{BRANCH}/{PROPERTY (optional)}
So, in my hands, this has worked for me (with semantic-ui):
<Form onSubmit={onSubmit}>
    <Form.Input name="name" onChange={changeUserName} placeholder="what" />
    <Form.TextArea name="message" onChange={changeuserMessage} placeholder="what2" />
    <Form.Button>Submit</Form.Button>
</Form>

and
  const [userName, setUserName] = useState(() => '')
  const [userMessage, setUserMessage] = useState(() => '')
  const wait = ms => new Promise((r, j) => setTimeout(r, ms))

  let changing = 0 // to create a buffer to avoid changing state always, the browser gets slow otherwise
  const changeUserName = async (e, { value }) => {
    changing++
    let prev_changing = changing
    await wait(100)
    if (prev_changing === changing) setUserName(value)
  }

  const changeuserMessage = async (e, { value }) => {
    changing++
    let prev_changing = changing
    await wait(100)
    if (prev_changing === changing) setUserMessage(value)
  }

  const onSubmit = async e => {
    e.preventDefault()
    const formdata = new FormData()
    formdata.set('fields[name]', userName)
    formdata.set('fields[message]', userMessage)
    const json = {}
    formdata.forEach((value, prop) => (json[prop] = value))
    const formBody = Object.keys(json)
      .map(key => encodeURIComponent(key) + '=' + encodeURIComponent(json[key]))
      .join('&')

    // in the repo, create a folder named 'comments'
    const response = await fetch(
      'https://dev.staticman.net/v3/entry/**github**/{my github user}/{my repo}/master/comments/',
      {
        method: 'POST',
        headers: { 'Content-Type': 'application/x-www-form-urlencoded' },
        body: formBody,
      }
    )
    console.log(response)
  }

The fetch method doesn't support IE.  It can be rewritten with the send method in xmlHttpRequest.


Test if we can redirect first

📝 Changed routes:

/[redirect]

(view full size)

Commit 43bf3b1f218f4f4592715621a041f4e49204ce46 (https://cesium-link-h562nqmx8-cesiuminho.vercel.app).


[BugFix] Non-existed jsonpath

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #19357 #18641
Problem Summary(Required) ：

This PR solves some jsonpath issues. Please refer the test case in be/test/exprs/json_functions_test.cpp to know the change.
Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 3.0
[x] 2.5
[x] 2.4
[ ] 2.3

run starrocks_be_unittest

@mergifyio rebase

@Mergifyio backport branch-3.0

@Mergifyio backport branch-2.5

@Mergifyio backport branch-2.4


[api-draft][connectors]add Assert sink to api-draft

Purpose of this pull request
add assert sink to api-draft branch
https://github.com/apache/incubator-seatunnel/issues/1912#issuecomment-1162595940

Check list

[x] Code changed are covered with tests, or it does not need tests for reason:
[x] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs

PTAL @ruanwenjun Thx.

It seems a AbstractSimpleSink was added. I need to extend it, right?

I don't know why there are so many other's commit in my PR. so I create another PR  https://github.com/apache/incubator-seatunnel/pull/2071

Close this PR, change to #2071


Revamp Meshes module

Closes https://github.com/ONSAS/ONSAS.jl/issues/285

Codecov Report

Merging #293 (be55760) into main (8f99b1d) will increase coverage by 0.04%.
The diff coverage is 70.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main     #293      +/-   ##
==========================================
+ Coverage   79.91%   79.95%   +0.04%
==========================================
  Files          41       41
  Lines        1439     1437       -2
==========================================
- Hits         1150     1149       -1
+ Misses        289      288       -1

Impacted Files
Coverage Δ

src/Meshes/Meshes.jl
69.52% <58.62%> (+1.56%)
:arrow_up:

src/StructuralModel/StructuralEntities.jl
97.56% <100.00%> (-0.22%)
:arrow_down:

src/StructuralModel/Structure.jl
83.33% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Description syntax conflicts with sax parser

Hi, I'm not quite sure what's going on, but when the feedreader readers the description node of a feed, the string is either entirely or partially missing. I think the & symbols have something to do with it, here is a sample description text:
  <description>Headlines for December 08, 2015; "I Want a World of Peace": In Exclusive Interview UK Labour Head Jeremy Corbyn Opposes Bombing Syria; "A Legal Black Hole": Jeremy Corbyn Calls for Closing of Guantánamo, Hails Release of Shaker Aamer; Jeremy Corbyn Connects Western Bombing Campaigns & Refugee Crisis: "What Goes Around Comes Around"; War & Climate Change: Jeremy Corbyn on the Brutal Quest for Oil & the Need for a Sustainable Planet; Top Climate Expert: Crisis is Worse Than We Think & Scientists Are Self-Censoring to Downplay Risk; "Loss and Damage": U.S. Stymies Push for Compensation for Climate Devastation at U.N. Climate Summit; Indian PM Links Worst Floods in a Century to Climate Change as More Cities Face Extreme Weather</description>

Oh that's odd. I will take a look at that. Thanks for reporting.

https://validator.w3.org/feed/check.cgi?url=http%3A%2F%2Fwww.democracynow.org%2Fpodcast.xml
I checked with the w3 validator, and I think the problem is from the server, not the library. w3 warns that "Your feed appears to be encoded as "UTF-8", but your server is reporting "US-ASCII""

I fixed this (but a little bit late :-) ) , take a look at my pull request https://github.com/ShirwaM/Simplistic-RSS/pull/9


Tests

Hello,
I am looking to provide something of a test suite for REMI. This represents just the first initial strategy for testing, but ultimately the plan is to test most of the functionality. If this works well it might also provide a framework for users of the library to test their own applications.
I've updated the README file to include a section on tests which I hope is sufficient for you to try this out yourself (although I'm working on Linux, so if you're on Windows it might be non-trivial).
The testing scheme relies on selenium driving a phantomjs instance. Which does mean we need to install phantomjs.
In the future it would be best if we didn't need the section in the README and people could run the tests with simply python setup.py test. I think that's possible, but for now I just want to understand if you would be interested in me continuing this effort, or if you're not really interested in adding a test-suite, or you have some other means/framework in mind for it.
So I guess, this is mostly a question of what do you think? Should I continue this effort?

@allanderek Thank you a lot for contributing to this project! :-)  I ever wanted a test suite, so my answer is yes, I'm really interested in this. Now I'm abroad, and I will be unable to merge and test this shortly. I will try it as soon as possible.

That's great. There is no rush to merge in, and I'm quite sure that there are some things you might disagree with. However, it's great to just know I can continue this line of work.

Merged in branch allanderek_tests

This was merged into origin/allanderek-tests, but why not into the master? What is lacking?

Probably all the unrelated changes

@nzjrs Would you (or @dddomodossola) be willing merge this if the issues are resolved?
Why i'm asking: I'm about to spend some time on testing a Remi-based project for a customer, and this seems like the best approach. I'd like to see if i can get it to work.
This would also require an effort from the Remi maintainers in pointing out in detail what the issues are, so they can be resolved. A merged branch would be the goal.
@allanderek, are you using tests in Remi, and do you maybe have something new to add?

Sorry I haven't used Remi for a while.

Ok, thanks for the answer!


Add support for java.time.OffsetDateTime as GraphQL scalar.

In a recent project I needed java.time.OffsetDateTime as a scalar, which was the only Java 8 date/time type missing support in SPQR. It might be of value to others, so I'd like to merge it back.

Very nice! Thank you!


Common file suffixes such as .out are classified as filetype tex

Steps to reproduce

Use strace -o strace.out someprogram to create an strace log file named strace.out.
Open strace.out with vim: vim --clean strace.out.
The syntax coloring is wrong and the 'filetype` is tex.

Expected behaviour
I expect the 'filetype' to be strace, as detected and set at line 378 of $VIMRUNTIME/autoload/dist/script.vim.
Version of Vim
9.1.377
Environment
Operating system: Ubuntu 20.04
Logs and stack traces
The problem was introduced at patch 9.1.0289, "filetype: some TeX files are not recognized," wherein a whole slew of filename suffixes was added to the pattern for detecting TeX files at what is now line 2416 of $VIMRUNTIME/filetype.vim. There were some other suffixes that I'm pretty sure aren't unique to TeX, but I'm sure that .out does not belong there.

Removing that one suffix from that line restores correct behavior in the example above.

Fixed by https://github.com/vim/vim/commit/e35478bc9d48189322432248105d3b24e0efb3d0

Fixed by patch 9.1.0383

Fixed four days ago. That'll teach me to update to the very latest version before reporting a bug. Thank you.

Already fixed by patch 9.1.0383 and fix verified.


fix json parse error

closes #10

this will require more work, some fields are not returned anymore...


I ran into this issue today in my build farm.
docker --version
Docker version 1.6.0, build 8aae715/1.6.0
docker pull myhost.com/cyc_build_docker_c7:v4
Trying to pull repository myhost.com/cyc_build_docker_c7 ... failed
Please login prior to pull:
Username:
myhost.emc.com is an Artifactory Pro server providing docker images from a V1 repository.
the host vm that I am running docker on is:
CentOS Linux release 7.1.1503 (Core)
This occurs on another CentOS vm running docker 1.7.1:
docker -v
Docker version 1.7.1, build 3043001/1.7.1
docker pull myhost.com/cyc_build_docker_c7:v4
Trying to pull repository myhost.com/cyc_build_docker_c7 ... failed
Please login prior to pull:
Username:
It does work on one of my CentOS vm's that has docker 1.7.1.  I removed the image, and reran the pull and it downloaded fine the second time too.
I checked with my Artifactory Admins, they haven't changed anything.  I verified my certs haven't changed for the authentication with Artifactory.
in summary, here is where I see and don't see this issue:
versions with issue:
Docker version 1.6.0, build 8aae715/1.6.0
Docker version 1.7.1, build 3043001/1.7.1
versions not seeing issue:
Docker version 1.7.1, build 446ad9b/1.7.1
Docker version 1.8.2, build 0a8c2e3
I know this screams of an environment issue, I am just not finding it yet.  Will update if I do.

I found my issue.
The hosts that are working are using a dockercfg file based on user A's credentials.  The hosts that aren't working are using dockercfg files based on my credentials, and I changed my password yesterday.
Updating my dockercfg files resolved my issue.