Imgui will cause game problems

they comes from other players, I have not been tested it in detail, most of the following are "conjectures" or "not tested in detail"
most of the time, the console of imgui works fine, but in a few cases, it will cause network problems or game problems in the game, and may need to restart game to solve problem, here are some known bugs from other players or from me:

if you open the console in a room and someone or you clicked the start, game will not start after the countdown over, and the game will no longer can get server's packet.
if you open the console while reading the map, and keep it open until you enter the game, you won't be able to use it to do anything unless you quit the room. (the same applies to the case where the game start with "map cs_assault")
when you host a game, if you use the console for any reason, no any player can join your game anymore and will be prompted with "Invalid Connection Method". who joined before you use the console can still play normally, when he exited the room and try to rejoin, he will not prompt "Invalid Connection Method".

in the client version that does not use imgui, these problems does not happen, these problems are all comes after using the new console.

imgui got removed in commit bfa4047


Try removing autouse

Investigating removing autouse=True

No linked issues found. Please add the corresponding issues in the pull request description.  Use GitHub automation to close the issue when a PR is merged


[WIP] Rust to Java bindings of libp2p

First attempt at creating a bridge between Rust and Java using JNI.
This adds an example binding for Keypair, however it's still not finished as it needs more code on the Java side to properly garbage collect the object. It can generate an ed25519 keypair. libp2p supports secp256k1 though too however this is just a demonstration. Most of the code is boilerplate to start creating the bindings.
CI needs to be modified to compile and test the Rust code.

it is recommended to use yarn instead of npm to install packages

Commit adding dependency to react-native-permissions was moved to PR #87


SetHeader method added to client

My WebDav server is using Bearer token authorization. For that I want to be able to add custom headers to my webdav client.

+1

+1


Maneuver docstrings

I am planning to add some extra manoeuvrers to this module such us non-coplanar ones and rendezvous. But for the moment, this PR add the necessary docstrings to the available Maneuver constructors.

@Juanlu001 I have written the Hohmann manoeuvrer in terms of an initial elliptical as:

Following Vallado's notation. However, when I execute the tests to make sure computations are consistent. I am getting the following exception:
    def __init__(self, *args):
        r"""Constructor.

        Parameters
        ----------
        impulses : list
            List of pairs (delta_time, delta_velocity)
        """

        self.impulses = args
        # HACK: Change API or validation code
        _dts, _dvs = zip(*args)
        self._dts, self._dvs = self._initialize(
            [(_dt * u.one).value for _dt in _dts] * (_dts[0] * u.one).unit,
>          [(_dv * u.one).value for _dv in _dvs] * (_dvs[0] * u.one).unit,
        )
      TypeError: can't multiply sequence by non-int of type 'CompositeUnit'

Here is the code for Hohmann I have coded:
r_i = norm(orbit_i.r)
v_i = orbit_i.v
k = orbit_i.attractor.k

a_trans = (r_i + r_f) / 2
dv_a = (np.sqrt(2 * k / r_i - k / a_trans) - v_i).decompose()
dv_b = (np.sqrt(k / r_f) - np.sqrt(2 * k / r_f - k / a_trans)).decompose()

t_trans = np.pi * np.sqrt(a_trans ** 3 / k)

return  cls((0 * u.s, dv_a), (t_trans, dv_b))

I have tried also the astropy.units.decompose() but raises the same error. Not sure how to deal with this :sweat_smile:
PD: I still have to add a checker to propagate orbit till pericenter or apocenter

After a little debugging, I found that the increments for de velocity dv_a and dv_b have as first component NaN. I will try to rewrite equations in terms of the previous value R. Hope to finish this tomorrow. It overwhelms me when I have a PR open more than 3 days :laughing:

It overwhelms me when I have a PR open more than 3 days :laughing:

Happens to the best! :stuck_out_tongue: Good to see you figured out on your own though!

I finally realized something. Hohmann formulations are always defined in books for "2D Orbits". However, our Orbit objects have three dimensions. This results in some weird behaviour such us NaN or Inf results when trying to apply the Hohmann algorithm, because:
v_i = [rx_i,  ry_i, rz_i] (generally in IJK)
v_f = [final_altitude] (this is always in PQW frame, that is the reason behind planar orbits in books)
One can not operate with theses two vectors directly because v_f is measured from PQW, not from body centred frame at attractor.
I became with the following idea:

Rotate the position and velocity vectors from [IJK] to [PQW]
Apply Hohmann transfer (it is like working in planar orbit)
Undo rotation, this means from [PQW] to [IJK]

This was the only solution I became with for the moment :disappointed:  What do you think about it? May be good another kind of approach to this problem?

But I think we currently use the magnitude of final radius, which does not depend on the reference frame, right?

That is true. When working with magnitudes the increments in the velocity are computed perfectly. However, the problem is that the constructor of Maneuver needs all velocities to have 3-components. Therefore that magnitude of the velocity should be converted into its components.

I was finally able to write the Hohmann maneuver for a 3D general case, since in all books it is treated orbits with inclination equal to zero. However, and although the impulses,  cost and time are right for the test case I am not sure why the final orbit eccentricity is 0.998...

I don't remember what happened here but probably we finished this in #599.


remove rapidjson

If you look at the Actions, rapidjson is throwing a bunch of warnings that I don't want to deal with, it isn't updated since 2016, so maybe time to search for a new json intermediary?
https://github.com/nlohmann/json

3f00f3e


Unknown error -100

I've started to get these unknown errors. Get it on the other checker too.

I suspect this has the same cause as #4
Google had been cracking down on custom ROMs and roots, so some people have to check safetynet every day in case they need to update their bypass


[fusebox] Switch store from $0 auth to $1 auth

It appears that not all banks support the $0 auth, even though the fusebox documentation recommends it as the way to store a card.
This switches from a $0 auth to a $1 auth in an attempt at a more reliable way to store cards.  Note that Visa mandates warn that there may be fees for "Authorization System Misuse", but since support for $0 seems to still be problematic, we don't feel these fees will ever materialize.

:shipit:


YamlCreate Git Variable reference is not valid

https://github.com/microsoft/winget-pkgs/pull/21213#issuecomment-881658525
https://github.com/microsoft/winget-pkgs/pull/21213#issuecomment-881663162
Give me a moment to validate this since my test got ruined..

Microsoft Reviewers: Open in CodeFlow

of course

That fixed it #21225 but still this issue

@Trenly ideas?

That fixed it #21225 but still this issue

@Trenly ideas?

Looks like I made a mistake on Line 80

That fixed it #21225 but still this issue

@Trenly ideas?

Looks like I made a mistake on Line 80

so default {Write-Host > exit} to default {exit} as before?

That fixed it #21225 but still this issue

@Trenly ideas?

Looks like I made a mistake on Line 80

so default {Write-Host > exit} to default {exit} as before?
edit: just tested on Ubisoft without submitting and it didn't create a exit file..

We want the Write-Host in there so people can see their keypress that actually exited. I accidentally used > instead of ; to join the commands.  The PR I mentioned (#21228) should resolve the issue as well as incorporate the change you needed for the git variable reference

ooo oki


Combobox search feature is bugged!

Current Behavior
The current search feature searches based on value not on label. This is not the intended behavior.
Expected Behavior
It is supposed to search based on the label not on value.
Steps To Reproduce
Just test by changing the value of the items and see that the search is based on that.
Link to Reproduction / Stackblitz (reproduction template)
No response
More Information
No response

hmmmm in the shadcn in nextjs the functionality is like I mentioned that is why I thought it was a bug it searches by label not by value. Since this is a direct port I thought it is a bug.. Thanks for the reply tho.

Can confirm is the same behavior as shadcn-ui

Can confirm is the same behavior as shadcn-ui

@lukeed do you mean there is a bug with this project or that it is not and has the same functionality as shadcn-ui? Just want to make sure it's working as expected.

Sorry. It’s the same behavior as shadcn-ui. So this can probably be closed given that this is meant to be a 1:1 replacement.
That said, when working with shadcn-ui directly, I did initially expect label text to be matched…but for compat sake the behavior would have to remain as it is currently

Good to hear!
@yb-cs if you're wanting to do something with some sort of value (like an id or something) on select, but search based on the label, you can just place the label in the text content (or value):
{#each things as thing}
<Command.Item onSelect={() => doSomething(thing.value)}>
	{thing.label}
</Command.Item>
{/each}


release ml-wrappers 0.5.3

What's Changed

Update README.md to add status badges by @gaugup in https://github.com/microsoft/ml-wrappers/pull/154
add optional api key auto refresh callable to EndpointWrapperModel by @imatiach-msft in https://github.com/microsoft/ml-wrappers/pull/153
Update CI-python.yml to remove python 3.6 logic by @gaugup in https://github.com/microsoft/ml-wrappers/pull/157
Add python 3.11 builds to CI-python-minimal.yml by @gaugup in https://github.com/microsoft/ml-wrappers/pull/155
fix wrapper error for object detection models on empty model predictions by @imatiach-msft in https://github.com/microsoft/ml-wrappers/pull/158

Full Changelog: https://github.com/microsoft/ml-wrappers/compare/v0.5.2...v0.5.3

Codecov Report

Merging #159 (c2c243d) into main (3a8b383) will decrease coverage by 33.21%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main     #159       +/-   ##
===========================================
- Coverage   75.54%   42.34%   -33.21%
===========================================
  Files          27       27
  Lines        1828     1828
===========================================
- Hits         1381      774      -607
- Misses        447     1054      +607

Flag
Coverage Δ

unittests
42.34% <100.00%> (-33.21%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

python/ml_wrappers/version.py
100.00% <100.00%> (ø)

... and 18 files with indirect coverage changes


Adds a test to ensure the URLs specified are valid

Ref #208, this would have saved some issues with the URL being invalid.

Thank you so much. Pulling this in, then rearranging some stuff.


Impossible to restore backedup file

couchbackup/couchrestore version(s) that are affected by this issue. - latest
Node.js version. - 8.11.1
A sample of the code or command line statement that demonstrates the issue.

I'm trying to use npm package "@cloudant/couchbackup" in my js code.
When I backup db it creates file and finished successfully.
When I try to restore db from this file I get an error:
BackupFileJsonError: Error on line 1 of backup file - cannot parse as JSON
    at Transform.writer._transform (../cloudant-backup-restore-scripts/node_modules/@cloudant/couchbackup/includes/writer.js:157:26)
    at Transform._read (_stream_transform.js:186:10)

When I backup the db in my code with "exec command couchbackup" (cli), I succeed to restore the db from this file. It means that function  couchbackup.backup() and cli command couchbackup works differently.
The file created by cli command much bigger that the created by function.
It seems the first contains deleted documents and the second - no.
I tried to run the function with opts { mode: 'full'}, it made no difference
Please advice
Tatyana

We'll need to see your code and ideally the "good" and "bad" backup files. If you don't want to share these publicly then please get in touch via slack or<EMAIL_ADDRESS>Without seeing these it's just guesswork at the moment.

My code:
async function backupDbToFile(config, directory, dbInfo) {
    console.log(`Starting to backup "${dbInfo.dbName}"`);
    const fileName = `${directory}/${dbInfo.dbName}.json`;
    const dbUrl =<EMAIL_ADDRESS>    const stream = fs.createWriteStream(fileName);
    return new Promise((resolve, reject) => {
        couchbackup.backup(dbUrl, stream, (err) => {
                if (err) {
                    return reject(err);
                }
                console.log(`Creating backup for db "${dbInfo.dbName}" has been completed.`);
                resolve();
            }
        );
    });
}

The details are sent

The files are too big, mail delivery failed.
There:
Code of the first option:
async function backupDbToFile(config, directory, dbInfo) {
    console.log(`Starting to backup "${dbInfo.dbName}"`);
    const fileName = `${directory}/${dbInfo.dbName}.json`;
    const dbUrl =<EMAIL_ADDRESS>    const stream = fs.createWriteStream(fileName);
    return new Promise((resolve, reject) => {
        couchbackup.backup(dbUrl, stream, (err) => {
                if (err) {
                    return reject(err);
                }
                console.log(`Creating backup for db "${dbInfo.dbName}" has been completed.`);
                resolve();
            }
        );
    });
}

The second option:
async function backupDbToFile2(config, directory, dbInfo) {
    console.log(`Starting to backup "${dbInfo.dbName}"`);
    const fileName = `${directory}/${dbInfo.dbName}.json`;
    const dbUrl =<EMAIL_ADDRESS>    const command = `couchbackup --url ${dbUrl} --db ${dbInfo.dbName} > ${fileName}`;
    await utils.executeCommand(command);
    console.log(`Creating backup for db "${dbInfo.dbName}" has been completed.`);
}

The first file starts with many rows []\n and its size 27.9 MB
The second doesn't contain rows with empty array and its size 36.4 MB

What version are you running? Please run ./bin/couchbackup.bin.js -V and paste the version.
Does your "bad" backup file always have the same contents on each run, or do the exact contents and the positions of the empty arrays change each time?

Closing as duplicate of #110 - user was doing multiple concurrent backups.


Support .sln projects

Please add feature to support opening .sln files for C++ projects, so that symbol resolution and navigation would be well supported. Just opening the folder will often times not be good enough for navigation using CTRL+CLICK on classes/functions/variables. Also, supporting .sln would allow listing the targets and enable building, running and debugging those targets directly from the IDE, like Visual Studio does. But Visual Studio as an editor is outdated and doesn't have the same modern user experience, as VSCode does.

/extC++


Doc for IPAM utilization reporting

[x] Tests - at https://github.com/projectcalico/libcalico-go/pull/1087 and https://github.com/projectcalico/calicoctl/pull/2011
[x] Documentation (here)
[x] Release note - at https://github.com/projectcalico/libcalico-go/pull/1087

Deploy preview for calico ready!
Built with commit 2c734146686c211fcde38daf5438439c9380a422
https://deploy-preview-2636--calico.netlify.com


Update _avatar.php

when the user uploaded a high resolution profile image, it causes an abnormality in <header></header> height.
adding bootstrap 5 class "img-fluid" in user avatar  element will fix this issue.

Yeh, this looks like a needed update.

This was merged in with https://github.com/lonnieezell/Bonfire2/pull/240


Marmara University marun

Added my collage Marmara University marun domain

@omeremksz I am sorry, the domain marun.edu.tr is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


Download hanging after  yield future.result() error

Bug
When downloading a list of images, sometimes an error is raised just before the end of the download (i.e., at 99%):
File "C:\Users\USD\miniconda3\envs\sentinel\Lib\site-packages\cdsetool\_processing.py", line 54, in _concurrent_process yield future.result()

However, the image is then downloaded correctly and is not corrupted. However, after some other images, the download hang and the script must be restarted. I put a control to avoid downgliding existing file (just iterating trough features before calling download_features()) so it is not a huge issue. Still, it would be nice to know what's happening.
Steps to reproduce
The code is basically the same as in the quick start guide.
from cdsetool.query import query_features, shape_to_wkt
from cdsetool.credentials import Credentials
from cdsetool.download import download_features
from cdsetool.monitor import StatusMonitor
from datetime import date

features = query_features(
    "Sentinel1",
    {
        "startDate": "2020-12-20",
        "completionDate": date(2020, 12, 25),
        "processingLevel": "LEVEL1",
        "sensorMode": "IW",
        "productType": "IW_GRDH_1S",
        "geometry": shape_to_wkt("path/to/shapefile.shp"),
    },
)

list(
    download_features(
        features,
        "path/to/output/folder/",
        {
            "concurrency": 4,
            "monitor": StatusMonitor(),
            "credentials": Credentials("username", "password"),
        },
    )
)

Expected behavior
A clear and concise description of what you expected to happen.
Environment

OS: Windows
Package version: 0.2.8
Python version: 3.12.2
The pc is connected through a company network with more firewalls than the average home network.

It seems like the error appears only if "concurrency"  in  download_features is set to a value higher than the one allowed with the account.


feat: introduce API parity between JS and WASM implementation

As discussed in #15.

Doesn't seem like CI is set up for this repo - I didn't think to run the tests so I assume they are broken. Sorry about that @guybedford!

No problem, I added the test changes already.


Multi ss test

Merging branch with files to run simulation with 2 starshades
Overloading SurveySimulation, TimeKeeping and Observatory modules.

This commit merges the master branch and Multi SS test branch ( which included work on 2 starshade scheduler) and now is in sync with EXOSIMS master branch


SwiftUI weak linking

Do you think it is possible to add availability for SwiftUI features in framework?
I accidentally run into crash because of that :(
Sth like
#if isAvailable()
or version check might be helpful :)
My failure was

dyld: Library not loaded: /System/Library/Frameworks/SwiftUI.framework/SwiftUI
Referenced from: /Users/piotrgawlowski/Library/Developer/CoreSimulator/Devices/818027B6-FE01-489E-937A-E7764561A2CE/data/Containers/Bundle/Application/D9182AB1-13FE-40CE-A395-45E6B06EA2F4/eForskrivning.app/Frameworks/Viperit.framework/Viperit
Reason: image not found

Hi, what’s your app minimum deployment target?

Cocoapods - 1.8.1
Xcode - 11.0
Deployment target - 11.0

I have the same problem:
dyld: Library not loaded: /System/Library/Frameworks/SwiftUI.framework/SwiftUI
Referenced from: /Users/xxxxx/Library/Developer/CoreSimulator/Devices/CE491B26-0A12-4EF0-B484-527664AC5D67/data/Containers/Bundle/Application/66C02AA4-ACE0-4F79-9FFB-E1D47FAC0C27/xxxxx.app/Frameworks/Viperit.framework/Viperit
Reason: image not found

Hi guys, thanks for the info. I'll try to publish a fix hopefully today 👍

Hey @pgawlowski and @cHicHillo,
I just pushed a new 1.4.3 release on Cocoapods.
I did some local testing with a simple Xcode11 project using the latest Cocoapods and running on iOS 12 simulator. Everything looks to be working know.
Let me know if it works for you.
Cheers.

Fixed in #115


Lecture 01 Notes Added

I'm not sure whether I added the lecture notes correctly to  the README.md file. For the link to work in my repo copy, I entered the link as : (https://github.com/ejmchugh/QC_MATH_342W_Spring_2021/blob/master/lectures/lec01mchugh.pdf). However, when it is pulled, will it change to (https://github.com/kapelner/QC_MATH_342W_Spring_2021/blob/master/lectures/lec01mchugh.pdf) so that the PDF is able to be accessed or is that something that I need to change when writing it on my copy?
Also, sorry, but I couldn't take "vidoes" any longer.

Wow it looks like you got it right on the first shot!

Actually one small thing: the link in the README could be to the course repository since you are adding the file in this pull request. See my change here:
https://github.com/kapelner/QC_MATH_342W_Spring_2021/commit/9dc9bffece620e05d15f93440fed1c7e35be51f6
and thanks for fixing that typo

Good to know. Woohoo! I learned something new this week.


fold fails

I have two questions about the following example:
definition bar := bool
example (b : bar) : bool :=
begin
  rewrite [↓bar]
end

1: Why does it fail?
2: Is it possible to improve the error message? Maybe just
invalid 'rewrite' tactic, rewrite step failed using pattern
bool
no subterm in the goal matched the pattern

1: Why does it fail?

The tactic is expecting to fold applications


Add a time interval for checking.

Is your feature request related to a problem? Please describe.
The current code checks for PostgreSQL Transaction ID (XID) based on record interval.
https://github.com/Senzing/governor-postgresql-transaction-id/blob/e6d84e350f72ab38efa3a348fbab3cf1c2f1ab68/senzing_governor.py#L222
It should also check based on a time interval.  Pseudo-code example:
        self.next_check_time = time.now() + self.time_interval

        with self.counter_lock:
            self.counter += 1

            # Only make expensive checks after "interval" records have been read or too much time has elapsed.

            if (self.counter % self.interval == 0) or (time.now() > self.next_check_time)):
                self.next_check_time = time.now() + self.time_interval
                :

Pull requests:

https://github.com/Senzing/governor-postgresql-transaction-id/pull/10


SKR provision  failed at step Create_LMS_Tenant on Dev

Description
Provisioning SKRs in dev landscape failed  at step Create_LMS_Tenant , please help investigate.

Expected result
Provision finish without issue

Actual result
Provision failed at step Create_LMS_Tenant

Steps to reproduce

Troubleshooting
{"instanceID":"fdf69278-7559-4952-9b8f-d0bc4e52becd","level":"error","msg":"Process operation failed: FORCE FAILURE","operation":"fdbb3427-affc-4b2c-9a63-4f3c9e27f968","provisioning":"manager","step":"Create_LMS_Tenant","time":"2020-08-13T00:22:04Z"}

It was a temporary issue caused by a concurrent KEB deployment existing on DEV, in which Create_LMS_Tenant was failing on purpose. Then after some testing it was deleted, see this commit. The intention was to simulate cases described here. That being said, I am going to close this issue.


Knex.js auto escapes typecasts in postgresql

I have the following piece of code:
var table='weather';
var query=db.column(table+'.id',table+'.date',table+'.temperature_max',table+'.temperature_min','city.name','city.country')
            .select()
            .withSchema('public')
            .from(table)
            .join('city',table+'.city_id','city.id')

And the problem is that when I try to typecast the column date it automatically escapes in incorrectly therefore it results to execute the wrong query. I tried the following:
  var table='weather';
    var query=db.column(table+'.id',table+'.date::varchar',table+'.temperature_max',table+'.temperature_min','city.name','city.country')
            .select()
            .withSchema('public')
            .from(table)
            .join('city',table+'.city_id','city.id')

And gives me this error:
Unhandled rejection error: select "weather"."id", "weather"."date::varchar", "weather"."temperature_max", "weather"."temperature_min", "city"."name", "city"."country" from "public"."weather" inner join "public"."city" on "weather"."city_id" = "city"."id" where "weather"."date" = $1 order by "weather"."date" ASC - column weather.date::varchar does not exist
    at Connection.parseE (/home/pcmagas/Holy Code/src/node_modules/pg/lib/connection.js:554:11)
    at Connection.parseMessage (/home/pcmagas/Holy Code/src/node_modules/pg/lib/connection.js:381:17)
    at Socket.<anonymous> (/home/pcmagas/Holy Code/src/node_modules/pg/lib/connection.js:117:22)
    at emitOne (events.js:77:13)
    at Socket.emit (events.js:169:7)
    at readableAddChunk (_stream_readable.js:146:16)
    at Socket.Readable.push (_stream_readable.js:110:10)
    at TCP.onread (net.js:523:20)

I think we need somehow to tell either via a flag or something else like selectRaw(columns) or columnRaw() that will append the select statement with whatever are columns are without try any sort of escaping.
So you can do the following
var table='weather';
var query=db.column(table+'.id',table+'.temperature_max',table+'.temperature_min','city.name','city.country')
.columnRaw(table+'.date::text')
            .select()
            .withSchema('public')
            .from(table)
            .join('city',table+'.city_id','city.id')

And that will create the query:
 select "weather"."id", "weather"."date"::text, "weather"."temperature_max", "weather"."temperature_min", "city"."name", "city"."country" from "public"."weather" inner join "public"."city" on "weather"."city_id" = "city"."id"

Knex column identifiers does not havr any support for typecasting, raw is needed.
Im surprised that the columnRaw version of the query works... As far as i know it should output weather.date::text instead of "weather"."date"::text
Sorry for the missing formatters etc. and being brief, responded from mobile...

Closing since this is not really a bug, but knex just doesn't support casting for identifiers. That and telling if certain input should be identifier or value and what type of value are weak points in knex currently. My earlier comment why it didn't output weather.date::text is because it wasn't in knex.raw...

Also one can circumvent that problem with knex.raw('??::cast', ['mytable.mycolumn'])


Improperly formatted string for technical-committee name

https://api.relaton.org/api/v1/document?code=ISO 19011&year=2011&all_parts=true,keep_year=false
shows this:
<technical-committee number="176" type="TC">ISO/TC 176/SC 3Supporting technologies</technical-committee>

"ISO/TC 176/SC 3" is the "identifier"
"Supporting technologies" is the "name"

Maybe it should be:
<technical-committee number="176" type="TC" identifier="ISO/TC 176/SC 3">Supporting technologies</technical-committee>

@ronaldtse we don't have an attribute identifier for IsoWorkgroup
IsoWorkgroup =
    attribute number { text }?,
    attribute type { text }?,
    text

Then can we add “identifier” and also “prefix”? Prefix can be “WG”, “AG”, etc whatever people choose (it’s inconsistent).
We also need to add “identifier” for committee if it doesn’t exist.

ping @opoudjis

I would have preferred to reconstruct identifier from other information, but I can see that's going to be inconvenient to impossible. OK.

I can see that's going to be inconvenient to impossible.

That was the intent but it's now confirmed to be impossible, unfortunately. So we have to handle this.

@andrew2net can we fix/close this now?


fix: numpydoc warnings

Description
After #1481 a lot of numpydoc warnings started to show up. Let's fix them whenever possible
Issue linked
None
Checklist

[X] I have tested my changes locally.
[X] I have added necessary documentation or updated existing documentation.
[X] I have followed the coding style guidelines of this project.
[X] I have added appropriate unit tests.
[X] I have reviewed my changes before submitting this pull request.
[X] I have linked the issue or issues that are solved to the PR if any.
[X] I have assigned this PR to myself.
[X] I have added the minimum version decorator to any new backend method implemented.
[X] I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

Merging since warnings have been fixed or ignored (built-ins causing failure... not our problem)


REQ: Download a DICOM from a Remote PACS

These are some great examples and tutorials. Do you have one for downloading a DICOM from a remote PACS? Thanks

If the remote PACS supports the Query/Retrieve service classes and includes the PatientRootQueryRetrievalInformationModelGet or StudyRootQueryRetrieveInformationModalGet or the PatientStudyOnlyQueryRetrieveInformationModelGet SOP classes in its association negotiation (you can check with the echoscu.py app in debug mode using the -d flag) then you can either try the getscu.py app, which needs (a lot of) work but might be enough on its own for you, or you can write your own solution following the outline given in getscu.py.
Remote PACS' also usually require that a peer SCU has been authorised, so the first step is to ensure you can associate correctly (using echoscu.py for example).
The basic approach is to:

Create a new AE with scu_sop set to a list containing QR SOP classes and Storage SOP Classes you want to support.
Implement the ae.on_c_store(dataset) method
Create a new association with the remote PACS using ae.associate(addr, port)
Create a DICOM dataset containing the elements you wish to use for your search
Call assoc.send_c_get(dataset)
The remote PACS should then search its stored SOP instances for matching datasets and send them to the running AE via DIMSE C-STORE.

Take a look at the DICOM standard part 4, Annex C (and C.4.3.1 in particular for C-GET) which explains in more detail what the dataset used to match against should look like.
There's not much testing of the assoc.send_c_get()/send_c_find()/send_c_move() parts of the code at the moment so if you run into anything strange don't hesitate to let me know.

Thanks. I'll start digging in and let you know if I run into issues. How would you compare this project to the original pynetdicom project? The API looks more fluent (which is nice). Also, do you know anyway to get a PACs to return "all data fields" and not just the specified ones specified in a Dataset for a find query or is that just how DICOM works? Thanks

I think the main differences between pynetdicom and pynetdicom3 at the moment are:

Better logging/debugging information available
Simpler interface for the end user
More of the recent DICOM standard features supported (although its not perfect by any means)
Better documentation
Better unit testing

Its still very much a work in progress though.
Looking at the DICOM standard part 7, Section <IP_ADDRESS>.5, it says that the response to a C-FIND operation will include a Dataset with

[...] the same list of Attributes with values of these Attributes in a particular composite SOP Instance that matched.

So a C-FIND operation won't return Datasets containing the matching SOP Instance(s), which I think is what you mean by "all data fields", only one with the same attributes you used to match against. A C-GET will return the full SOP Instance(s) though (via a C-STORE operation).

Thanks. Just curious, are you available for contract/hire? Do you have a website to contact you directly? Thanks

Not at the moment, sorry. If my situation changes I'll let you know.

First of all, if you set the logging to the debug level you can check the association negotiation logs to see if the presentation context you're using been accepted by the SCP. If it hasn't then you need to configure it properly.
Secondly, you need to implement the AE.on_c_store(dataset) callback in order to handle datasets received as a result of the C-GET Query/Retrieve request.

Hi @scaramallion
According to your instructions, I continue to downloading DICOM from PACS but still not able to get what is the correct Presentation Context for ‘dataset’. I tried all UID’s from following URL:
http://dicom.nema.org/medical/dicom/2014c/output/chtml/part02/sect_F.<IP_ADDRESS>.html
Here is my code:
ct_storage_uid = UID('1.2.840.10008.1.1')
ae = AE(scu_sop_class=[ct_storage_uid])
I also used the different combination of “query_model”:
if assoc.is_established:
print('Association accepted by the peer')
# Creat a new DICOM dataset with the attributes to match against
#   In this case match any patient's name at the PATIENT query
#   level. See PS3.4 Annex C.6 for the complete list of possible
#   attributes and query levels.
dataset = Dataset()
dataset.PatientID = '*'
dataset.QueryRetrieveLevel = "PATIENT"

# Send a DIMSE C-FIND request to the peer
#   query_model is the Query/Retrieve Information Model to use
#   and is one of 'W', 'P', 'S', 'O'
#       'W' - Modality Worklist (1.2.840.10<IP_ADDRESS>.31)
#       'P' - Patient Root (1.2.840.10<IP_ADDRESS>.<IP_ADDRESS>)
#       'S' - Study Root (1.2.840.10<IP_ADDRESS>.<IP_ADDRESS>)
#       'O' - Patient/Study Only (1.2.840.10<IP_ADDRESS>.<IP_ADDRESS>)
responses = assoc.send_c_find(dataset, query_model='O')

I am using “ORTHANC” server, please find the logs for the same:

,
Which UID I should use for the connections, I can share sample DICOM file as well if it requires knowing the UID.
Please help.

You need to use the Query/Retrieve SOP Class UIDs you want to use when sending DIMSE messages to the peer. The simplest way is to add QueryRetriveSOPClassList to the scu_sop_class parameter.
Please run apps/findscu/findscu.py with the -d flag and post the output.

I am getting following error, after running findscu.py:
usage: findscu [options] peer port dcmfile-in
findscu.py: error: the following arguments are required: peer, port, dcmfile-in
After that I have changed following parameters:
# Parameters
req_opts = parser.add_argument_group('Parameters')
req_opts.add_argument("localhost", help="hostname of DICOM peer", type=str)
req_opts.add_argument(4242, help="TCP/IP port number of peer", type=int)
req_opts.add_argument("/ProjectData/Eko.ai/DicomDIR",
                      metavar="dcmfile-in",
                      help="DICOM query file(s)",
                      type=str)

but still getting following:
Traceback (most recent call last):
File "findscu.py", line 111, in
args = _setup_argparser()
File "findscu.py", line 46, in _setup_argparser
req_opts.add_argument(4242, help="TCP/IP port number of peer", type=int)
File "/anaconda3/lib/python3.6/argparse.py", line 1313, in add_argument
if not args or len(args) == 1 and args[0][0] not in chars:
TypeError: 'int' object is not subscriptable
Is the third parameter will be the path of my DICOM file folder?
Still trying...

There was no reason for you to modify findscu.py. Please revert the changes you made then do:
findscu.py <IP_ADDRESS> 4242 -P -d path/to/dataset.dcm
Where
<IP_ADDRESS> is the TCP/IP address of the SCP
4242 is the port number of the SCP
-P use Patient Root Query Model - FIND
-d show debugging output
path/to/dataset.dcm is the path to a DICOM dataset (any dataset will do, this isn't used for anything at the moment).

Hi @scaramallion ,
Here is the output:
Mac-mini:findscu manoj$ python findscu.py <IP_ADDRESS> 4242 -P -d /Users/manoj/Downloads/ttfm.dcm
D: $findscu.py v0.1.1 2017-07-02 $
D:
I: Requesting Association
D: Request Parameters:
D: ====================== BEGIN A-ASSOCIATE-RQ =====================
D: Our Implementation Class UID:      1.2.8<IP_ADDRESS>80043.9.38<IP_ADDRESS>
D: Our Implementation Version Name:   PYNETDICOM3_091
D: Application Context Name:    1.2.840.10<IP_ADDRESS>.1
D: Calling Application Name:    FINDSCU
D: Called Application Name:     ANY-SCP
D: Our Max PDU Receive Size:    16382
D: Presentation Contexts:
D:   Context ID:        1 (Proposed)
D:     Abstract Syntax: =Patient Root Query/Retrieve Information Model - FIND
D:     Proposed SCP/SCU Role: None/None
D:     Proposed Transfer Syntax:
D:       =Explicit VR Little Endian
D:   Context ID:        3 (Proposed)
D:     Abstract Syntax: =Study Root Query/Retrieve Information Model - FIND
D:     Proposed SCP/SCU Role: None/None
D:     Proposed Transfer Syntax:
D:       =Explicit VR Little Endian
D:   Context ID:        5 (Proposed)
D:     Abstract Syntax: =Patient/Study Only Query/Retrieve Information Model - FIND
D:     Proposed SCP/SCU Role: None/None
D:     Proposed Transfer Syntax:
D:       =Explicit VR Little Endian
D:   Context ID:        7 (Proposed)
D:     Abstract Syntax: =Modality Worklist Information Model - FIND
D:     Proposed SCP/SCU Role: None/None
D:     Proposed Transfer Syntax:
D:       =Explicit VR Little Endian
D:   Context ID:        9 (Proposed)
D:     Abstract Syntax: =Patient Root Query/Retrieve Information Model - MOVE
D:     Proposed SCP/SCU Role: None/None
D:     Proposed Transfer Syntax:
D:       =Explicit VR Little Endian
D:   Context ID:        11 (Proposed)
D:     Abstract Syntax: =Study Root Query/Retrieve Information Model - MOVE
D:     Proposed SCP/SCU Role: None/None
D:     Proposed Transfer Syntax:
D:       =Explicit VR Little Endian
D:   Context ID:        13 (Proposed)
D:     Abstract Syntax: =Patient/Study Only Query/Retrieve Information Model - MOVE
D:     Proposed SCP/SCU Role: None/None
D:     Proposed Transfer Syntax:
D:       =Explicit VR Little Endian
D:   Context ID:        15 (Proposed)
D:     Abstract Syntax: =Patient Root Query/Retrieve Information Model - GET
D:     Proposed SCP/SCU Role: None/None
D:     Proposed Transfer Syntax:
D:       =Explicit VR Little Endian
D:   Context ID:        17 (Proposed)
D:     Abstract Syntax: =Study Root Query/Retrieve Information Model - GET
D:     Proposed SCP/SCU Role: None/None
D:     Proposed Transfer Syntax:
D:       =Explicit VR Little Endian
D:   Context ID:        19 (Proposed)
D:     Abstract Syntax: =Patient/Study Only Query/Retrieve Information Model - GET
D:     Proposed SCP/SCU Role: None/None
D:     Proposed Transfer Syntax:
D:       =Explicit VR Little Endian
D: Requested Extended Negotiation: None
D: Requested Common Extended Negotiation: None
D: Requested User Identity Negotiation: None
D: ======================= END A-ASSOCIATE-RQ ======================
D: Constructing Associate RQ PDU
D: PDU Type: Associate Accept, PDU Length: 453 + 6 bytes PDU header
D:     02  00  00  00  01  c5  00  01  00  00  41  4e  59  2d  53  43
D:     50  20  20  20  20  20  20  20  20  20  46  49  4e  44  53  43
D:     55  20  20  20  20  20  20  20  20  20  00  00  00  00  00  00
D:     00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00
D:     00  00  00  00  00  00  00  00  00  00  10  00  00  15  31  2e
D:     32  2e  38  34  30  2e  31  30  30  30  38  2e  33  2e  31  2e
D:     31  2e  31  21  00  00  1b  01  00  00  00  40  00  00  13  31
D:     2e  32  2e  38  34  30  2e  31  30  30  30  38  2e  31  2e  32
D:     2e  31  21  00  00  1b  03  00  00  00  40  00  00  13  31  2e
D:     32  2e  38  34  30  2e  31  30  30  30  38  2e  31  2e  32  2e
D:     31  21  00  00  19  05  00  03  00  40  00  00  11  31  2e  32
D:     2e  38  34  30  2e  31  30  30  30  38  2e  31  2e  32  21  00
D:     00  19  07  00  03  00  40  00  00  11  31  2e  32  2e  38  34
D:     30  2e  31  30  30  30  38  2e  31  2e  32  21  00  00  1b  09
D:     00  00  00  40  00  00  13  31  2e  32  2e  38  34  30  2e  31
D:     30  30  30  38  2e  31  2e  32  2e  31  21  00  00  1b  0b  00
D:     00  00  40  00  00  13  31  2e  32  2e  38  34  30  2e  31  30
D:     30  30  38  2e  31  2e  32  2e  31  21  00  00  19  0d  00  03
D:     00  40  00  00  11  31  2e  32  2e  38  34  30  2e  31  30  30
D:     30  38  2e  31  2e  32  21  00  00  19  0f  00  03  00  40  00
D:     00  11  31  2e  32  2e  38  34  30  2e  31  30  30  30  38  2e
D:     31  2e  32  21  00  00  19  11  00  03  00  40  00  00  11  31
D:     2e  32  2e  38  34  30  2e  31  30  30  30  38  2e  31  2e  32
D:     21  00  00  19  13  00  03  00  40  00  00  11  31  2e  32  2e
D:     38  34  30  2e  31  30  30  30  38  2e  31  2e  32  50  00  00
D:     3a  51  00  00  04  00  00  40  00  52  00  00  1b  31  2e  32
D:     2e  32  37  36  2e  30  2e  37  32  33  30  30  31  30  2e  33
D:     2e  30  2e  33  2e  36  2e  32  55  00  00  0f  4f  46  46  49
D:     53  5f  44  43  4d  54  4b  5f  33  36  32
D: Parsing an A-ASSOCIATE PDU
D: Accept Parameters:
D: ====================== BEGIN A-ASSOCIATE-AC =====================
D: Their Implementation Class UID:    1.2.276.0.7230<IP_ADDRESS>.6.2
D: Their Implementation Version Name: OFFIS_DCMTK_362
D: Application Context Name:    1.2.840.10<IP_ADDRESS>.1
D: Calling Application Name:    FINDSCU
D: Called Application Name:     ANY-SCP
D: Their Max PDU Receive Size:  16384
D: Presentation Contexts:
D:   Context ID:        1 (Accepted)
D:     Proposed SCP/SCU Role: Default
D:     Accepted SCP/SCU Role: Default
D:     Accepted Transfer Syntax: =Explicit VR Little Endian
D:   Context ID:        3 (Accepted)
D:     Proposed SCP/SCU Role: Default
D:     Accepted SCP/SCU Role: Default
D:     Accepted Transfer Syntax: =Explicit VR Little Endian
D:   Context ID:        5 (Abstract Syntax Not Supported)
D:   Context ID:        7 (Abstract Syntax Not Supported)
D:   Context ID:        9 (Accepted)
D:     Proposed SCP/SCU Role: Default
D:     Accepted SCP/SCU Role: Default
D:     Accepted Transfer Syntax: =Explicit VR Little Endian
D:   Context ID:        11 (Accepted)
D:     Proposed SCP/SCU Role: Default
D:     Accepted SCP/SCU Role: Default
D:     Accepted Transfer Syntax: =Explicit VR Little Endian
D:   Context ID:        13 (Abstract Syntax Not Supported)
D:   Context ID:        15 (Abstract Syntax Not Supported)
D:   Context ID:        17 (Abstract Syntax Not Supported)
D:   Context ID:        19 (Abstract Syntax Not Supported)
D: Accepted Extended Negotiation: None
D: Accepted Common Extended Negotiation: None
D: Accepted Asynchronous Operations Window Negotiation: None
D: User Identity Negotiation Response:  None
D: ======================= END A-ASSOCIATE-AC ======================
I: Association Accepted
D: Checking input files
I: Find SCU Request Identifiers:
I:
I: # DICOM Dataset
I: (0008, 0052) Query/Retrieve Level                CS: 'PATIENT'
I: (0010, 0010) Patient's Name                      PN: '*'
I:
I: Sending Get Request: MsgID 1
D: ===================== OUTGOING DIMSE MESSAGE ====================
D: Message Type                  : C-FIND RQ
D: Presentation Context ID       : None
D: Message ID                    : 1
D: Affected SOP Class UID        : Patient Root Query/Retrieve Information Model - FIND
D: Data Set                      : Present
D: Priority                      : Low
D: ======================= END DIMSE MESSAGE =======================
D: Abort Parameters:
D: ========================== BEGIN A-ABORT =========================
D: Abort Source: DUL service-user
D: Abort Reason: No reason given
D: =========================== END A-ABORT =========================
E: Connection closed or timed-out
E: Association Aborted

The Orthanc SCP doesn't support any of the Query/Retrieve - GET abstract syntaxes. If you want to perform a C-GET operation then at least one of those syntaxes will need to be supported by Orthanc.
The Orthanc SCP does support the Query/Retrieve - FIND syntax for Patient Root but is sending an A-ABORT after receiving a C-FIND message with that syntax, which I believe is linked to the following lines from the Orthanc log output you posted:

Modality "PYNETDICOM" is not listed in the "DicomModalities" configuration option

Rejected Find request from remote DICOM modality with AET "PYNETDICOM" and hostname "<IP_ADDRESS>"

Both of which suggest to me that Orthanc SCP hasn't been configured properly. If you still have issues with pynetdicom once you've configured it properly please start a new issue about it (rather than posting in closed issues).

Also, should you not be using C-MOVE rather than C-GET?
https://www.medicalconnections.co.uk/kb/Basic_DICOM_Operations

Hi @ManojSolanki @scaramallion @barchard @edmcdonagh @cancan101
I need to download studies along with the DICOM images from the PACS servers, before, I was using Orthanc, I am getting the same issue while using C-GET and C-MOVE.
Can you please suggest the server on which I can test code and download the images using pynetdicom.

If you just need to test then try DCMTK's dcmqrscp. Its a little bit annoying to configure (your calling AE title needs to match one in the AETable section) but it's what I use to test pynetdicom against.
Essentially you get dcmqrscp configured and up and running, send some datasets to it using whatever Storage SCU you prefer and then you can send QR C-GET, C-FIND and C-MOVE requests to it.


RAWINPUTDEVICE_FLAGS not longer implements bitwise ops

Which crate is this about?
windows
Crate version
0.32.0
Summary
Trying to take an OR of members of RAWINPUTDEVICE_FLAGS, e.g. RIDEV_DEVNOTIFY | RIDEV_INPUTSINK stopped compiling, at least since 0.32.0, maybe earlier. Seems the implementation of BitOr got removed?
Expected behavior
Compiles.
Actual behavior
error[E0369]: no implementation for `RAWINPUTDEVICE_FLAGS | RAWINPUTDEVICE_FLAGS`

Additional comments
No response

The trouble with doing that is that it then includes types like WIN32_ERROR that are clearly not flags. Going to transfer this to the win32 metadata repo to fix the metadata.


Scaling SVG before rasterizing, sourceScale in PIXI.BaseTexture isn't there any more?

I'm trying to load SVGs in, and scale them before rasterizing so they look sharp at the size I need them.
The docs for 4.5.6 and other resources I've found seem to say you can do this by using the sourceScale option when loading in the texture. The 5.2.0 docs have no mention of this, and I can't figure out how to do it.
Is it not possible in 5.2.0?

its possible to pass scale to SVGResource constructor, unfortunately its not passed through Texture.fromLoader
I mentioned it so many times and no one wants to make PR. I'm too lazy to do one right now. Wait till weekend or try workaround that passed options to SVGResource constructor.

ACtually, according to https://github.com/pixijs/pixi.js/blob/dev/packages/core/src/textures/resources/SVGResource.js
and
https://github.com/pixijs/pixi.js/blob/dev/packages/core/src/textures/Texture.js#L330
this should work:
PIXI.Texture.from('my.svg', {scale: 2} );

just don't add my.svg to pixi loader.

Thank you so much for the fast assistance! Unfortunately passing in {scale: 2} seems to make no difference. This is my code:
var tex = PIXI.Texture.from("r001.svg", {scale:2}) var sprite = new PIXI.Sprite(tex); stage.addChild(sprite);
Changing the value of scale makes no difference to what's drawn on screen.  However, if I add
sprite.scale.x = sprite.scale.y = 2;
The sprite doubles in size but it's blurry, so I don't think the SVG has been enlarged before being rasterized.
I'll look into the SVGResource workaround and reply back with my results.

Ok this works!
var svgRes = new PIXI.resources.SVGResource("r001.svg", {scale:2});
var tex = PIXI.Texture.from(svgRes);
var sprite = new PIXI.Sprite(tex);
stage.addChild(sprite);

Alternatively this should work the same, per documentation. The second argument is the BaseTexture constructor options which has a resourcesOptions optional field.
var tex = PIXI.Texture.from("r001.svg", {resourceOptions: {scale:2}});
var sprite = new PIXI.Sprite(tex);
stage.addChild(sprite);

None of the code snippets provided here work. The image is cut off.
resourceOptions: { scale: 1 }

resourceOptions: { scale: 2 }

Looks like the width and height properties are scaled correctly, but there is something wrong with the texture anchors.
Code used:
let tex = PIXI.Texture.from("robot-grab.svg", { resourceOptions: { scale: 2 } });
let robotHand = new PIXI.Sprite(tex);
app.stage.addChild(robotHand);

@Tymski please file a new issue with an example that runs and demonstrates the bug you're seeing.

@jazzyjeff5 and @bigtimebuddy answers seem to differ in how texture caching is working.
I wasn't able to get svg in 2 different scales unsing @bigtimebuddy's answer as Texture.fromImage() was caching only one of the scales. Using SVGResource fixed that. Hoping caching still works though.


Add toolInfo in MetaData vertex in LSIF dumps

This helps with uploading LSIF dumps to Sourcegraph without having to specify an indexer name.
Fixes #10518

Thanks!
bors r+
changelog fix (first contribution) set toolinfo in LSIF export


Build logs are no longer part of the Slack notifications

Previously it was like

[project-name] master (ae4ad7d) Build lagoon-1 complete. Logs

where "Logs" was linked to the build log. This part is missing now.

having a look at this.

@ocean90
this has been fixed, thanks for your report!


Can you add a method or property to pull Step values/text from a method with a step attribute

I have found a need to pull the text value from a method step attribute.  Can you add a way to pull that information from the methods with that attribute?
Gauge version

This relates to some other issues but here is the use case.
I need to run some series of steps depending on conditions found in the application.  Look for condition A and if not found create condition A in the application.
This is equivalent to running a concept or not based on an if statement.  Like the concept I would like each individual step done inside the logical loop logged as I’m a concept.
The problems are:

that I can’t call a concept from inside a method.
Because I cant do that I tried to set up the step with an optional parameter that would let me log the step as executed in the report when I want to call it from an if statement.
As I can’t do that either I have a second method which logs the step and then executed the method of the actual step.
this brings us to the final point that is what this request was about.  It takes a few lines of code everywhere that I want to pull the attribute value (which I can currently do), but I was hoping that the code could be modified to include a property that could return the methods attribute (step name as used in gauge.

Hope that wasn’t too long.
Thanks for such a great program

Didn’t mean to close this.  Am new to github.


Feature/mesh instance compare

Allow a custom compare method to be implemented on MeshInstances which lets the user determine how the instances are sorted.
For example, the Spine plugin implements a compare function which uses the draw order of the component parts of the animation in addition to the camera distance to sort.
var createSortFn = function (index) {
    return function () {
        return index - this.distSqr;
    };
};
//...
meshInstance.compare = createSortFn(drawOrder);

Implemented in #632


Add defaultPage prop

What version of React-Table are you using?
<EMAIL_ADDRESS>What bug are you experiencing, or what feature are you proposing?
Add property defaultPage
What are the steps to reproduce the issue?
There are several default properties already defined like defaultPageSize or defaultFiltered, but what I need is a defaultPage prop, it is an small change to your library
I'm working with redux and I need to save the table state in redux and load it when the component is mounted again. All the default props works fine, but the table is always initialised in page 1, and not in the page stored in redux
The change is in lib/index.js line 76
instead of
page: 0,
it should be
page:  props.defaultPage,

There is a page prop for ReactTable - is that not working for you? Check the doco by searching the page for Controlled State Overrides.

I dont want to control page changes, I just need the defaultPage prop, similar to defaultPageSize and  defaultFiltered, so it is initialised in the page stored in redux, but controlled by this library

Oh - sorry - I see what you mean now.
Yes - it is a small change - but there is also a very small team working on the code now (and a bunch of PRs queued up) - so I don't know how long it will take to get the change in (as simple as it is).

This is still on the radar but another use case has come up that has highlighted that a change in the props (specifically the proposed defaultPage) would need to be detected and reapplied to the actual page in the component state.


Support \left-assoc and \right-assoc on \and and \or

This PR updates the kore parser to support using \or and \and as children of \left-assoc and \right-assoc.
I chose to also implement \and because the llvm backend parser already supports this, and I am about to implement it in the k frontend, which will mean that it will be completely supported for the purposes of the llvm and maude backends if I later need to make use of it.

Dammit. I wrote tests and forgot to git add them.

Related: https://github.com/runtimeverification/haskell-backend/issues/3542


Add initial ADDHIST API command implementation

It might have been better to break up this PR even further, but the chain of dependent API-related PRs is already becoming too long.  Essentially, these are the changes:

It changes the Zino1BaseServerProtocol to keep track not just of the boolean state of authentication, but also keep track of the username of the logged in user
It implements the GETHIST command, which needs to know said username.
It factors out the redundant case_id verification code that was repeated in all the command responders that take a case_id argument.

Closes #106
Depends on #105 to be merged first.

#105 was merged to master, this is now out of draft mode


[Enhancement] Iceberg refactor and optimize on fe [stage 3]

What type of PR is this：

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
https://github.com/StarRocks/starrocks/issues/18560
Problem Summary(Required) ：

implement getTableStatistics interface for iceberg metadata.
refactor icebergStatisticsCalculator to IcebergStatisticsProvider
remove some unnecessary ut. I will I add it in next pr

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto backported to target branch

[ ] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

run starrocks_admit_test


Use correct glslang capitalization

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/15378/merge
Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15378/merge/index.html
To test a playground add it to the URL, for example:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15378/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/15378/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/15378/merge
https://gui.babylonjs.com/?snapshot=refs/pull/15378/merge
https://nme.babylonjs.com/?snapshot=refs/pull/15378/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/15378/merge#BCU1XR#0

WebGL2 visualization test reporter:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15378/merge/testResults/webgl2playwright/index.html

Visualization tests for WebGPU (Experimental)
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15378/merge/testResults/webgpuplaywright/index.html


Audit all uses of Window.alert, Window.confirm, and Window.prompt

We should examine all uses of alert, confirm, and prompt. Most of these should move to using GWT dialogs so that users cannot accidentally reject all future prompts from App Inventor.

What about this?

This may not be shown while gwt is not ready.

This might be one of the few places where we leave the Window version. However, even at this point I think that GWT should be sufficiently initialized that it should still be able to render a modal dialog since it isn't nested under other parts of the DOM.


Incorrect Obligations structure length calculation

Problem
Into file obligation.rs Decimal size is 16. It is incorect. Size shuld be 3 * 8 = 24 (3 x 64-bit words)
Decimal definition decimal.rs
// U192 with 192 bits consisting of 3 x 64-bit words
construct_uint! {
    pub struct U192(3);
}

/// Large decimal values, precise to 18 digits
#[derive(Clone, Copy, Debug, Default, PartialEq, PartialOrd, Eq, Ord)]
pub struct Decimal(pub U192);

Solution
obligation.rs
/// Obligation collateral state
#[derive(Clone, Debug, Default, PartialEq)]
pub struct ObligationCollateral {
    /// Reserve collateral is deposited to
    pub deposit_reserve: Pubkey,
    /// Amount of collateral deposited
    pub deposited_amount: u64,
    /// Collateral market value in quote currency
    pub market_value: Decimal,
}

/// Lending market obligation state
#[derive(Clone, Debug, Default, PartialEq)]
pub struct Obligation {
    /// Version of the struct
    pub version: u8,
    /// Last update to collateral, liquidity, or their market values
    pub last_update: LastUpdate,
    /// Lending market address
    pub lending_market: Pubkey,
    /// Owner authority which can borrow liquidity
    pub owner: Pubkey,
    /// Deposited collateral for the obligation, unique by deposit reserve address
    pub deposits: Vec<ObligationCollateral>,
    /// Borrowed liquidity for the obligation, unique by borrow reserve address
    pub borrows: Vec<ObligationLiquidity>,
    /// Market value of deposits
    pub deposited_value: Decimal,
    /// Market value of borrows
    pub borrowed_value: Decimal,
    /// The maximum borrow value at the weighted average loan to value ratio
    pub allowed_borrow_value: Decimal,
    /// The dangerous borrow value at the weighted average liquidation threshold
    pub unhealthy_borrow_value: Decimal,
}

const OBLIGATION_COLLATERAL_LEN: usize = 64; // 32 + 8 + 24
const OBLIGATION_LIQUIDITY_LEN: usize = 104; // 32 + 24 + 24 + 24
const OBLIGATION_LEN: usize = 1140; // 1 + 8 + 1 + 32 + 32 + 24 + 24 + 24 + 24 + 1 + 1 + (64 * 1) + (104 * 9)

Perhaps it is worth replacing manual calculation with a call to std::mem::size_of::<Decimal>()

@jordansexton, excuse me, what you think about?

It looks like the 16 byte length comes from here: https://github.com/solana-labs/solana-program-library/blob/5e320ba9768cca8ca751a4db26786ed13bb0d40f/token-lending/program/src/state/mod.rs#L67-L76
I'm not very familiar with these. @jstarry could you explain how this works? Does it accept some loss of precision?

Shouldn't be any loss of precision, all values fit inside u128 but u192 is used for arithmetic to prevent overflows during calculations

Closing since it seems like it's working as designed, but please reopen if this didn't cover the issue.


feat: add example for CRD Datasource test

add example

@zqq454224016  Good job!  Please resolve the above comments.


About running clustering condition on experiments.py

https://github.com/amazon-research/dstc11-track2-intent-induction/blob/0312cbcd666dc3efb20a32a0658ca5e723081b78/sitod/experiment.py#L133
I think the intention is to skip running clustering when there're prediction results already and also you don't want to ovewrite them.
The codes would be like
skip condition: Path.exists() and not self._overwrite
run condition: not(Path.exists() and not self._ovewrite) -> not Path.exists() or self._ovewrite.
and not seems to be changed to or.

It's correctly coded in OpenIntentInductionExperiment._run_experiment()


Open Terminal at Root: cmd inherits Atom environment variables

Prerequisites

[x] Can you reproduce the problem in safe mode?
[x] Are you running the latest version of Atom?
[x] Did you check the debugging guide?
[x] Did you check the FAQs on Discuss?
[x] Are you reporting to the correct repository?
[x] Did you perform a cursory search to see if your bug or enhancement is already reported?

For more information on how to write a good bug report or enhancement request, see the CONTRIBUTING guide.
Description
I've been wondering why, when I open a windows CMD from Atom with the Open Terminal at Root feature, my npm install only installs dependencies and not devDependencies. It turns out the NODE_ENV environment variable is set to production, which is, I guess, inherited from the Atom process.
Steps to Reproduce

Right click on your top folder
Click Open Terminal at Root
Type echo %NODE_ENV%

Expected behavior: NODE_ENV is not defined on my machine, so I should actually see %NODE_ENV%
Actual behavior: production is printed
Versions
Windows 10 Home x64 (version 1607 build 14393.447)

Atom    : 1.12.5
Electron: 1.3.9
Chrome  : 52.0.2743.82
Node    : 6.5.0

apm  1.12.9
npm  3.10.5
node 4.4.5
python 2.7.12
git 2.10.1.windows.1
visual studio 2015

Click Open Terminal at Root

Can you clarify this step?  Atom by itself does not contain any "Open Terminal at Root" function.  Are you sure you tested in safe mode?

I thought I did, maybe I made a typo typing --safe...
Anyway, my bad, the problem does not come from Atom but from an extension. Sorry for the noise.

No problem!  We all make mistakes sometimes :).  Thanks for getting back to us!


RC Pipeline Cleanup and README

aferritto created the following on Apr 14:
Closes #108

Cleans up rc pipeline
Adds README.md

I think it will be beneficial to get input from others with a fresh preservative as to what will be helpful in readme
Original issue: https://github.ibm.com/ai-foundation/PrimeQA/pull/119

On Apr 15, aferritto commented:
@mabornea thanks for the review.  Made some changes, LMK what you think.

PR merged.


Auto, Motorcycle Parts & Accessories

We need find few products we can supply to customers Auto, Motorcycle Parts & Accessories. At least We need 5 products in this category,, more is appreciable,

All details of the product.

Description of the product
Few Images of the product
Allow Customers to Customize the product ( custom needs such as process method, surface treatment, size, color, logo, etc.)
Minimum orders that customers can order
Payment method (L/C, T/T, Western Union etc)
Delivery details
Location of the factory, like from which City in China.

All Details of the Supplier

Contact information (Phone Number, Email , factory name, Supplier Name , etc)
For this category you can either have different factory or just from same factory,, its your choice
Few Images of the factory and Supplier.
What deal we have with the factory,, like how we are benefiting by selling products? like monthly salary or commission? or profit share.

I can recommend some products you can look for,

Auto Parts & Accessories : Sailunn Racing Car Tire 205/40r17
Car Parts & Accessories : Luxury Air Suspension Bus Driver Seat with 3 Point Seat Belt
Motorcycle Parts & Accessories : Halley Helmet Open Full Helmet Motorcycle Helmet with Mask
Auto Repair & Decoration : Automotive Spray Booth Paint Booth
Auto Engine & Parts : High Quality Stainless Steel Car Exhaust System for Toyota Gt86

Still you can choose whatever you want from this category.
Again if you still dont understand how you need present this details ,, I can show you sample of one product..

Please do everything in Word file and submit everything to your folder in GitHub..

Got it,, but still you didnt upload into your folder,,


go: Switch to Assertf, AssertNoErrorf

We deprecated non-f variants of Assert in the latest release of Pulumi.
This updates all usages of these in pkg/ to their printf-style variants.
Refs https://github.com/pulumi/pulumi/issues/12132

Current dependencies on/for this PR:

main

PR #1014   👈

PR #1015

This comment was auto-generated by Graphite.

@abhinav queued this pull request to merge with Graphite.

Graphite couldn't merge this PR because it failed optional checks and "ignore optional checks" was not selected.


🐞 [BUG] - <lack of responsiveness on service page , dark mode issue>

Issue Verification

[X] I have verified that this is a new bug report.
[X] I'm interested in working on this issue
[X] I'm part of GSSOC organization

Describe the bug
there many issue
issue1 : lack of responsive ness

issue 2 :  enhance UI of service page

issue 3 : dark mode content not visible

issue 4 : navbar dark button

Expected behavior
it should be responsive
Steps to reproduce
No response
Additional Context
No response

please assign issue to me as GSSOC'24 contirbutor and make level 3 please.

hey @jfmartinz , please assign to me.

hey @jfmartinz , here my issue link , <issue 3 : dark mode content not visible> #784
please assign to me

hey @jfmartinz  , here my issue link for issue 1 ,  #786
please assign to me


error in loading images from the path

Genenrated Error
Traceback (most recent call last):   File "/home/priyansh/Python2/projects/space-invaders/code/main.py", line 49, in <module>     MENU = pygame.image.load(MENU_path) FileNotFoundError: No such file or directory: '/home/priyansh/Python2/projects/space-invaders/code/././assets/menu.png
Errror Fix:
Use this
directory = os.path.dirname(os.path.abspath(__file__)) MENU_path = os.path.join( directory, "../assets/menu.png")
instead of
MENU_path = os.path.join( os.path.abspath(__file__)), "../assets/menu.png")
Question

is this happening on my system only ??
Why is the error generateid??

I don't know why your line of code is:
MENU_path = os.path.join( os.path.abspath(__file__)), "../assets/menu.png")

Right now I have an updated version, but checking that version it should be:
MENU_path = os.path.join(os.path.abspath(__file__), "../../assets/menu.png")
MENU = pygame.image.load(MENU_path)

Notice how that line works:
It is joining the path to the module that is running to whatever string you put inside "", adding a /. So it is not working with your line of code because the path that os.path.join() is returning is, as you can see in your error message:
 /home/priyansh/Python2/projects/space-invaders/code/././assets/menu.png
Which is inside the /code directory, because you are missing "../" in your string, notice that ".." means go to upper directory.
So the line:
MENU_path = os.path.join(os.path.abspath(__file__), "../../assets/menu.png")

Works this way:
The first "../" gets from /main.py to /code, that contains it, and the second gets to the directory that contains the /code directory. Afterwards, the rest of the path gets inside the /assets directory, and looks for a "menu.png" file.
Your solution is correct, but adds a line of code and, even though you could put it all inside only one line, it would be a large one. However, the only thing different that accomplishes using os.path.dirname() is that you get the directory that contains the file that you pass through it. So it would be easier to just use one "../" more.

hey @DaniMorales97
I dont know while tweaking with the code i might have missed the
../../assets
But when i cloned your files again and tried it again i am getting the same error message
File "/home/pm/Projects/Space-Fighters/code/main.py", line 49, in <module>     MENU = pygame.image.load(MENU_path) FileNotFoundError: No such file or directory: '/home/pm/Projects/Space-Fighters/code/main.py/../../assets/menu.png'.
Due to this i have to add one more line of code and specify the directory as mentioned above , so could you please help me figure out where i am going wrong ??

I don't know what is wrong now.

Is it possible that you are using an old version of python? I've investigated a bit to see if I find why you get that issue and that might be the answer. However, I also noticed that writting os.path.dirname(os.path.abspath(__file__)) should be, in my understanding, the same as os.path.dirname(__file__) which es shorter and clearer. Try it please.

This issue should be closed now. We understand now that /.. does not work to go up from the path of a file, as I initially thought, it is meant to go up from the path of a directory. It was working in my pc, with Windows OS and it wasn't for @Priyansh61 that uses Linux. From now on the syntax used will be os.path.dirname(__file__) plus the path to the file being imported starting from the directory containing the file that is importing it. PR #9 applies this syntax change.

Thanks for your efforts @DaniMorales97 .


[SPG-506]: fixing env doc and adding example.

update documentation, add example usage on resource and data source
corrected the create API in the resource so this resource will get created with all the Manifests, Config Files, variables

Closing this PR. It's duplicate of https://github.com/harness/terraform-provider-harness/pull/252


can not find libboost_system.so.1.58.0

Hi author,
My OS is ubuntu18.04, i'm trying to run the demo following "Compile Method". When buiding it reminds some libs can not find.

Scanning dependencies of target horizon_highway_mapping
Scanning dependencies of target horizon_highway_odometry
[ 25%] Building CXX object horizon_highway_slam/CMakeFiles/horizon_highway_mapping.dir/src/horizon_highway_mapping.cpp.o
[ 50%] Building CXX object horizon_highway_slam/CMakeFiles/horizon_highway_odometry.dir/src/horizon_highway_odometry.cpp.o
[ 75%] Linking CXX executable /home/jxl/horizon_ws/devel/lib/horizon_highway_slam/horizon_highway_mapping
[100%] Linking CXX executable /home/jxl/horizon_ws/devel/lib/horizon_highway_slam/horizon_highway_odometry
/usr/bin/ld: warning: libboost_system.so.1.58.0, needed by /home/jxl/horizon_ws/src/horizon_highway_slam/lib/libhorizon.so, not found (try using -rpath or -rpath-link)
/usr/bin/ld: warning: libpcl_common.so.1.7, needed by /home/jxl/horizon_ws/src/horizon_highway_slam/lib/libhorizon.so, not found (try using -rpath or -rpath-link)
/usr/bin/ld: warning: libpcl_kdtree.so.1.7, needed by /home/jxl/horizon_ws/src/horizon_highway_slam/lib/libhorizon.so, not found (try using -rpath or -rpath-link)
/usr/bin/ld: warning: libpcl_filters.so.1.7, needed by /home/jxl/horizon_ws/src/horizon_highway_slam/lib/libhorizon.so, not found (try using -rpath or -rpath-link)
/usr/bin/ld: warning: libpcl_segmentation.so.1.7, needed by /home/jxl/horizon_ws/src/horizon_highway_slam/lib/libhorizon.so, not found (try using -rpath or -rpath-link)
/usr/bin/ld: warning: libcholmod.so.3.0.6, needed by /home/jxl/horizon_ws/src/horizon_highway_slam/lib/libhorizon.so, not found (try using -rpath or -rpath-link)
[100%] Built target horizon_highway_mapping
/usr/bin/ld: warning: libboost_system.so.1.58.0, needed by /home/jxl/horizon_ws/src/horizon_highway_slam/lib/libhorizon.so, not found (try using -rpath or -rpath-link)
/usr/bin/ld: warning: libpcl_common.so.1.7, needed by /home/jxl/horizon_ws/src/horizon_highway_slam/lib/libhorizon.so, not found (try using -rpath or -rpath-link)
/usr/bin/ld: warning: libpcl_kdtree.so.1.7, needed by /home/jxl/horizon_ws/src/horizon_highway_slam/lib/libhorizon.so, not found (try using -rpath or -rpath-link)
/usr/bin/ld: warning: libpcl_filters.so.1.7, needed by /home/jxl/horizon_ws/src/horizon_highway_slam/lib/libhorizon.so, not found (try using -rpath or -rpath-link)
/usr/bin/ld: warning: libpcl_segmentation.so.1.7, needed by /home/jxl/horizon_ws/src/horizon_highway_slam/lib/libhorizon.so, not found (try using -rpath or -rpath-link)
/usr/bin/ld: warning: libcholmod.so.3.0.6, needed by /home/jxl/horizon_ws/src/horizon_highway_slam/lib/libhorizon.so, not found (try using -rpath or -rpath-link)
[100%] Built target horizon_highway_odometry
jxl@lenevo:~/horizon_ws$

I add libg2o.so path into system with /etc/ld.so.conf.d/livox_horizon_highway_slam.conf file, and then i launch horizon_highway_slam_host.launch, it reminds horizon_highway_odometry and horizon_highway_mapping can not find libboost_system.so.1.58.0, as libhorizon.so depends on them. Could you please give these libs in repository?  Can horizon_highway_slam run on ubuntu18.04? Thanks for your help!

Hi narutojxl,
Since we built this code under Ubuntu 16.04, the directory may be different from Ubuntu 18.04. Please try the Docker method.

why not open source for project libhorizon and just use standard version of  g2o library ?


Restructure libraries

Rename file to something like stream.
Merge the min and the math libraries into something like num/math.
Goal:

core independent libraries: stream, text, math, tensor, thread
high level library: cortex

Maybe even more some generic utilities (e.g. table, time measurements) to own libraries


NS_ERROR_FAILURE errors

Hello there,
I keep encountering NS_ERROR_FAILURE errors when using d3-legend. Here's an Observable notebook, which tries to recreate the Linear Scale Legend - Horizontal example.
I tried to recreate the example outside of an Observable notebook and encountered the same errors. Is it possible that there is an issue with the package?
Thanks in advance,
Iain

Weird, where are you seeing that issue pop up? I'm unable to see it in the console. I do see this there, do you see the same?

@susielu That Content-SecurityPolicy error isn’t related to this issue; it just means you’re using a browser that doesn’t support the new prefetch-src directive. (It’ll go away if you update to Chrome 65.) There’s another notebook that appears to use d3-svg-legend successfully. I’ll do a little digging and see if I can figure out what’s going on here.

Okay, pretty simple fix:
{
  const svg = d3.select(DOM.svg(width, 40));
  yield svg.node();
  svg.append("g").call(legend);
}

https://beta.observablehq.com/@mbostock/d3-legend
The issue is that d3-svg-legend depends on the SVG node being added to the DOM before you call it, and in Observable, things aren’t added to the DOM until the cell yields or returns. Specifically, you’re using element.getBBox on the text and shape elements generated by the legend, but since the SVG node hasn’t yet been added to the document, the bounding boxes can’t be computed—they are dependent on the styles that the SVG element will inherit, which isn’t known until the SVG element is added to the body.
Probably want you want to do is to have d3-svg-legend through an error if the element that you apply it to isn’t in the DOM. That would be something like this…
svg.each(function() {
  if (!this.ownerDocument.contains(this)) {
    throw new Error("cannot generate legend on detached element");
  }
});

Thanks Mike!!

Hello,
I maybe encoutered a smiliar problem related to Firefox (63.0.1 and below).
Follow Errorcode (sorry but I can't add more ):
NS_ERROR_FAILURE:
a/G<
http://localhost:8082/test/d3-legend.min.js:3:12421
map self-hosted:286:17 a
http://localhost:8082/test/legends/d3-legend.min.js:3:12398

Hello
Still get NS_ERROR_FAILURE using Firefox.
Any ideas?
Best regards
jTzipi

No ideas based on what you've posted so far, can you provide more details? Unfortunately the error code description isn't helpful: NS_ERROR_FAILURE (0x80004005)
This is the most general of all the errors and occurs for all errors for which a more specific error code does not apply.

Hello
Firefox console only give me this info
G https://path/to/legends/d3-legend.min.js:3
map self-hosted:286
a https://path/to/legends/legends/d3-legend.min.js:3
call https://path/to/legends/d3.min.js:2

Hello again
What kind of information do you need and how can I get this?
Regards

@jTzipi I was encountering the same issue with Firefox. If you follow @mbostock's suggestion to put
yield svg.node();

directly after
const svg = d3.select(DOM.svg(width, 40));

then it should work.
I just tried this in Firefox, and it seems to work fine.

Hello @bludrop
Thanks very much for your answer.
I figured out that the function
d3.legendColor();
is not found.
Now I found the mistake.
I typed d3.legendColor( );
with extra white space between brackets.
After I removed them it works.

Hello
Unfortunately that was not everything wrong.
I put d3-legend.js to get more information and here it is.
   color.js:106:38     textSize color.js:106     map (index):286     legend color.js:106     call d3.min.js:2
->
`// we need to merge the selection, otherwise changes in the legend (e.g. change of orientation) are applied only to the new cells and not the existing ones.
cell = cellEnter.merge(cell);
// sets placement
var textSize = text.nodes().map(function (d) {
  return d.getBBox();
}),
    shapeSize = shapes.nodes().map(function (d) {
  return d.getBBox();
});`

Regards.
jTzipi

Hello
Good news is that I get legend running in a "Non-Spring" environment.
In my Spring-managed Environment I get the error above using the same
code to draw the chart and legend.
jTzipi

Hello again
I have now found that it maybe depend on other jQuery libraries.
Error line now is 226 of your legend-d3.ds file.
Something with a function called extend.
Maybe there is an other javascript lib that use a function with this name to or vice versa.
I have a jQuery data table on the page I want to display charts.
Regards
jTzipi

Problem solved now.
I have to draw chart before displaying on page.
Regards
jTzipi


[cli] serving named imports resolution inconsistent for reusable components

When using the reusable components url from polymer serve (ie http://<IP_ADDRESS>:8081/components/... ) the requests are inconsistent for named module imports.
Some use /components/ some use /node_modules/
This results in the error Uncaught DOMException: Failed to execute 'define' on 'CustomElementRegistry': this name has already been used with this registry as imports are requested twice with different urls.
This is also preventing polymer test to execute properly.
command used:
polymer serve --npm --module-resolution=node

Looks like a duplicate of #125

@web-padawan You are right, thanks.

Thanks for the report! Closing as dupe of #125 as noted above.


prefix_regex fails to interpret capture group with a pipe operator correctly

Describe the bug
We are using a prefix_regex in order to route two endpoints to the same service in Openshift. This is not working as expected and instead returns a 404 from envoy.
To Reproduce
Steps to reproduce the behavior:

oc edit svc <service-name>
add the following annotations in order to match two separate prefixes:

apiVersion: v1
kind: Service
metadata:
  annotations:
    getambassador.io/config: |
      name: "http-foo"
      prefix: /v1/foo/(server1|server2)/.*
      prefix_regex: true
      service: "http://http-foo.namespace.svc"
      apiVersion: ambassador/v1
      kind: Mapping

Attempt to curl both GET /v1/foo/server1/path/to/something and GET /v1/foo/server2/path/to/something/else
Expected behavior
Both urls should resolve to the same kubernetes service - instead both urls receive a 404 response.
Versions (please complete the following information):

Ambassador: 0.50.1
Kubernetes environment: Openshift
Version 3.11

Additional context
I have tried formatting the regex multiple ways. For example I have tried:
\/v1\/foo\/(server1|server2)\/.*
and
^\\/v1\\/foo\\/((server1)|(server2))\\/.*
amongst others

Any ideas on this? If we can't get the prefix_regex to work we cannot migrate our services to use Ambassador.

Envoy uses the modified ECMAScript regex grammar (see https://en.cppreference.com/w/cpp/regex/ecmascript), so I'm not sure that capture groups work.
However, it should be straightforward to use two Mappings for this:
apiVersion: v1
kind: Service
metadata:
  annotations:
    getambassador.io/config: |
      apiVersion: ambassador/v1
      kind: Mapping
      name: http-foo-1
      prefix: /v1/foo/server1/
      service: http://http-foo.namespace.svc
      ---
      apiVersion: ambassador/v1
      kind: Mapping
      prefix: /v1/foo/server2/
      service: http://http-foo.namespace.svc

I'm going to go ahead and close this one -- reopen if needed!


Impossible initiative result?

Character has initiative 25, roll 1d20 for initiative, so lowest they should be able to get is 26, but somehow rolled only a 20?

found formatting problem


add a LazyProvingKey and rework loading of proving keys

Currently the proving keys are only present in the penumbra-proof-params crate if the proving-keys feature is enabled: that feature uses the include_bytes! macro to bundle the generated proving key files.  The proving keys are each of the type Lazy<ProvingKey<..>>.
Instead we could always have the proving keys be present, i.e. SPEND_PROOF_PROVING_KEY, etc. will no longer be conditionally included if the proving-keys feature is enabled. The proving-keys feature would instead control whether the proving key object is loaded in the crate.
We'd create a LazyProvingKey type that internally holds a OnceCell<ProvingKey>. It behaves just like the Lazy type: it implements Deref, except if you dereference it without the proving-keys feature enabled or without loading the proving key from elsewhere, it will panic.
We’d have an API, e.g. a method on LazyProvingKey::load that takes a byte slice. If the proving-keys feature was not enabled, you must call this loading method. Internally it will call get_or_init on the OnceCell: https://docs.rs/once_cell/latest/once_cell/sync/struct.OnceCell.html#method.get_or_init.
Tl;dr: if you want everything bundled together, you enable the proving-keys feature as before, and everything works in exactly the same way. If you don’t use that feature, then it's your responsibility to call the load method with the bytes of the proving key before doing anything with the proving keys, else the program panics. The benefit of this is that you have the option of loading from a file, and not having to balloon the size of the binary.

Some context: the dapp website was previously loading a ~90MB wasm file, which delayed TTFP. That's no longer the case, given that Zpoken retooled things so that the wasm logic is consumed exclusively by the extension, rather than by the dapp. It'd still be nice to resolve this problem, but let's wait until we have some dedicated web story support.

Another additional thing we could do here is always encode the hash of the proving keys in the binary itself, that way the binary acts as a root of trust for this information. This way, the loading method can be trustless, like via a public API we control, or any other kind of CDN. The API proposed above would also work, just that the load method would also check that the hash of the bytes passed in matches.

I think we do currently encode the hashes of the proving and verifying keys, IIRC it's how our auto-download-during-build mechanism works (I believe we check that the data we fetch from the network matches the expected hashes before we embed it into the binary).

My understanding, from reading https://github.com/penumbra-zone/penumbra/blob/main/crates/crypto/proof-params/build.rs, is that we have a X.bin file for each proof which stores a Git LFS pointer to actual proving key, and then we can manually resolve those at build time by parsing the pointer and doing the download ourselves. Now, this pointer does encode a SHA-256, so yeah, we are committing to the proving keys, at least.
We also don't support lazy verification keys, so these don't have any hashes either, I think.

It's not just the LFS pointer, but also we encode hashes of the keys directly in the source code, eg https://rustdoc.penumbra.zone/main/penumbra_proof_params/spend/constant.PROVING_KEY_ID.html

Ah, I was missing that part!

Closing (done in #3337)


SPFX webpart can't be loaded: Cannot read properties of undefined (reading 'id')

Target SharePoint environment
SharePoint Online
What SharePoint development model, framework, SDK or API is this about?
💥 SharePoint Framework
Developer environment
None
What browser(s) / client(s) have you tested

[ ] 💥 Internet Explorer
[X] 💥 Microsoft Edge
[ ] 💥 Google Chrome
[ ] 💥 FireFox
[ ] 💥 Safari
[ ] mobile (iOS/iPadOS)
[ ] mobile (Android)
[ ] not applicable
[ ] other (enter in the "Additional environment details" area below)

Additional environment details

Edge Version 116.0.1938.62

SPFx version 1.17.0-rc.1

Node.js version v16.16.0
"dependencies": {
"@fluentui/react-components": "^9.35.0",
"@microsoft/mgt": "^3.0.0-rc.3",
"@microsoft/mgt-react": "^3.0.0-rc.3",
"@microsoft/mgt-spfx": "^3.1.3",
"@microsoft/sp-application-base": "^1.18.0",
"@microsoft/sp-component-base": "^1.17.2",
"@microsoft/sp-core-library": "1.17.2",
"@microsoft/sp-lodash-subset": "1.17.2",
"@microsoft/sp-office-ui-fabric-core": "1.17.2",
"@microsoft/sp-property-pane": "1.17.2",
"@microsoft/sp-webpart-base": "^1.18.0",
"antd": "^4.24.3",
"jspdf": "^2.5.1",
"jspdf-autotable": "^3.7.0",
"office-ui-fabric-react": "^7.199.1",
"papaparse": "^5.4.1",
"react": "17.0.1",
"react-dom": "17.0.1",
"react-json-to-csv": "^1.2.0",
"tslib": "2.3.1"
}

Describe the bug / error
SPFX webpart works fine in the workbench but it is not loaded after the deployment and added to the page.
The error is
Could not load mgt-people-web-part in require. TypeError: Cannot read properties of undefined (reading 'id')
at sp-pages-assembly_en-us_345e6f1cbb807ceb7c758a1b08a38fb7.js:77:971652
at new Promise ()
at e.loadComponent (sp-pages-assembly_en-us_345e6f1cbb807ceb7c758a1b08a38fb7.js:77:971620)
at sp-pages-assembly_en-us_345e6f1cbb807ceb7c758a1b08a38fb7.js:77:973657
at async Promise.all (index 0)
spfx-mgt-people-webpart.zip
Steps to reproduce

create a project with yo
add bunch of react component
code the functionality
test with the workbench
gulp clean --ship && gulp build --ship && gulp bundle --ship && gulp package-solution --ship
deploy the .sppkg
add the web part to the site's apps
embed the web part

Expected behavior
The web part should show the as same as in the workbench

That project looks like it was partially upgraded to a different SPFx version (from 1.17.2 > 1.18.0)... the SPFx library dependencies should all be the same version...
"@microsoft/sp-application-base": "^1.18.0",
"@microsoft/sp-component-base": "^1.17.2",
"@microsoft/sp-core-library": "1.17.2",
"@microsoft/sp-lodash-subset": "1.17.2",
"@microsoft/sp-office-ui-fabric-core": "1.17.2",
"@microsoft/sp-property-pane": "1.17.2",
"@microsoft/sp-webpart-base": "^1.18.0",

Also, that's an old version of OUIFR referenced and is missing the Fluent UI package in v1.18...
"office-ui-fabric-react": "^7.199.1",

I don't see this in a brand-new SPFx v1.18 project. Suggest you get the project in a healthy state before verifying the error you posted because SPFx doesn't support running different versions in the same project.

Thanks Andrew for the quick reply, so do I just run "npm update --save" to get all package up to date?

That project looks like it was partially upgraded to a different SPFx version (from 1.17.2 > 1.18.0)... the SPFx library dependencies should all be the same version...
"@microsoft/sp-application-base": "^1.18.0",
"@microsoft/sp-component-base": "^1.17.2",
"@microsoft/sp-core-library": "1.17.2",
"@microsoft/sp-lodash-subset": "1.17.2",
"@microsoft/sp-office-ui-fabric-core": "1.17.2",
"@microsoft/sp-property-pane": "1.17.2",
"@microsoft/sp-webpart-base": "^1.18.0",

Also, that's an old version of OUIFR referenced and is missing the Fluent UI package in v1.18...
"office-ui-fabric-react": "^7.199.1",

I don't see this in a brand-new SPFx v1.18 project. Suggest you get the project in a healthy state before verifying the error you posted because SPFx doesn't support running different versions in the same project.

updated Version but same error, works fine in workbench
"dependencies": {
"@fluentui/react-components": "^9.35.0",
"@microsoft/mgt": "^3.1.3",
"@microsoft/mgt-react": "^3.1.3",
"@microsoft/mgt-spfx": "^3.1.3",
"@microsoft/sp-application-base": "^1.18.0",
"@microsoft/sp-component-base": "^1.18.0",
"@microsoft/sp-core-library": "^1.18.0",
"@microsoft/sp-lodash-subset": "^1.18.0",
"@microsoft/sp-office-ui-fabric-core": "^1.18.0",
"@microsoft/sp-property-pane": "1.18.0",
"@microsoft/sp-webpart-base": "^1.18.0",
"antd": "^4.24.14",
"jspdf": "^2.5.1",
"jspdf-autotable": "^3.7.0",
"papaparse": "^5.4.1",
"react": "17.0.1",
"react-dom": "17.0.1",
"react-json-to-csv": "^1.2.0",
"tslib": "2.3.1"
},
"devDependencies": {
"@fluentui/react": "^7.204.0",
"@microsoft/eslint-config-spfx": "1.18.0",
"@microsoft/eslint-plugin-spfx": "1.18.0",
<EMAIL_ADDRESS>"0.5.0",
"@microsoft/sp-build-web": "1.18.0",
"@microsoft/sp-module-interfaces": "1.18.0",
"@rushstack/eslint-config": "2.5.1",
"@types/markdown-it": "^12.2.3",
"@types/react": "17.0.45",
"@types/react-dom": "17.0.17",
"@types/webpack-env": "~1.15.2",
"ajv": "^6.12.6",
"eslint": "8.7.0",
"eslint-plugin-react-hooks": "4.3.0",
"gulp": "4.0.2",
"typescript": "4.5.5"
}

@kenzhengau - I believe you should deploy mgt-spfx library package to your tenant.
Also - do not use ^ in your SPFx package versions. It can lead to inconsistent versioning.

@kenzhengau there's still a bunch of stuff in there that's not correct... like you're using the v9 of Fluent UI React... only v8 is supported in SPFx.  Or use the doctor command to inspect issues.
What you've shared simply isn't enough to figure out what's wrong, but what you've shared in the package.json is enough for me to say "ok, first step - make sure you upgrade the project correctly before you start chasing down build/runtime errors"

@kenzhengau there's still a bunch of stuff in there that's not correct... like you're using the v9 of Fluent UI React... only v8 is supported in SPFx.  Or use the doctor command to inspect issues.
What you've shared simply isn't enough to figure out what's wrong, but what you've shared in the package.json is enough for me to say "ok, first step - make sure you upgrade the project correctly before you start chasing down build/runtime errors"

Thanks Andrew, you are the legend! The downgrade fixed the issue

🤣


Fix rendering issues with Æ and Þ characters

Capital thorn had a superfluous path that wasn't closed. Both ash characters had overlapping paths.

Thanks!


Update Link inline prop description

https://github.com/github/primer/issues/2099
Updates the Link inline property description and set the underline property to "deprecated".

Just wanted to leave a couple notes for the deprecation process that I believe we're hoping to follow:

If possible, the deprecated item should have /** @deprecated */ as an annotation with a corresponding notice for what to use instead
The deprecated item should be marked as deprecated in the corresponding docs page
When a prop is deprecated, it would fall under a minor semver doc per the versioning guide
If possible, we should have a lint rule to manage deprecations (and offer fixes) over in: https://github.com/primer/eslint-plugin-primer-react

What would be a good place for us to include/document this info so that it's more apparent when making deprecation changes? Would that versioning guide be a good place? Just want to make sure we've captured all of these things so that things don't slip through the cracks 👀

@joshblack what's the best to do now? Revert and merge again as minor with and additional note for "what to use instead" and adding a /** @deprecated */ here?
I had a quick look at this but then just looked at the options available and used the deprecated option.

Revert: https://github.com/primer/react/pull/4134
Follow-up: https://github.com/primer/react/pull/4135


Error Anki plugin "Pull from Duolingo" since a few days

Hello,
I am using the Anki plugin "Pull from Duolingo" since a few days, until last weekend it worked like a charm. I am using the courses "Spanish from German"
Now the following error is raising after login, in Linus as well as in Windows, even with the latest Anki version:
Debuginformationen:
Anki 2.1.19 (3c8690ae) Python 3.8.1 Qt 5.14.0 PyQt 5.13.2
Platform: Linux
Flags: frz=True ao=True sv=1
Möglicherweise beteiligte Erweiterungen: Pull from Duolingo
Caught exception:
Traceback (most recent call last):
File "/home/praxiszi1/.local/share/Anki2/addons21/557761805/plugin.py", line 49, in sync_duolingo
vocabulary_response = vocabulary_thread.join()
File "/home/praxiszi1/.local/share/Anki2/addons21/557761805/duolingo_thread.py", line 29, in join
raise e
File "/home/praxiszi1/.local/share/Anki2/addons21/557761805/duolingo_thread.py", line 16, in run
self.return_value.put(self._target(*self._args, **self._kwargs))
File "/home/praxiszi1/.local/share/Anki2/addons21/557761805/duolingo.py", line 461, in get_vocabulary
overview = overview_request.json()
File "requests/models.py", line 897, in json
File "json/init.py", line 357, in loads
File "json/decoder.py", line 337, in decode
File "json/decoder.py", line 355, in raw_decode
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

Thanks for the report! I'll look into it this evening.

I've been able to reproduce your bug, and trace it to the library that I use to communicate with Duolingo. It seems that something has changed on Duolingo's side.
I've opened a bug report with that library: https://github.com/KartikTalwar/Duolingo/issues/83 . Hopefully they're able to help us come to a resolution within the next couple of days.
Thanks for bringing this to my attention!

@stellardeveloper @crsend This feature is now working for me once again, without making any changes to the plugin.
This makes me think that something was broken or changed in Duolingo, but then was changed back and is now working again.
Could you confirm that this feature is now working for you?
If this is working for you again, then what I'd still like to do is to make some changes to the plugin so that if it encounters any unexpected errors like this it will give a more user friendly error message that will direct people to this error page.

I can confirm that this is now working.
I have one other question. Which deck does this plugin add the cards to?
Thank you for keeping me up to date.
Ken Franciscus
On Sun, Mar 29, 2020 at 2:09 PM Joseph Schilz<EMAIL_ADDRESS>wrote:

@stellardeveloper https://github.com/stellardeveloper @crsend
https://github.com/crsend This feature is now working for me once
again, without making any changes to the plugin.
This makes me think that something was broken or changed in Duolingo, but
then was changed back and is now working again.
Could you confirm that this feature is now working for you?
If this is working for you again, then what I'd still like to do is to
make some changes to the plugin so that if it encounters any unexpected
errors like this it will give a more user friendly error message that will
direct people to this error page.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/JASchilz/AnkiSyncDuolingo/issues/25#issuecomment-605701941,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AO6SK4IYV2IM27KTR7YF2X3RJ62JXANCNFSM4LRYOCPQ
.

--
Sent from Gmail Mobile

Hi crsend! Glad to hear that it's working, and sorry for the late response.
The cards get added to your default deck. The plugin description on Ankiweb has some information that you might find helpful, under "managing notes" and "editing notes": https://ankiweb.net/shared/info/557761805

I am having this exactly same issue.
Error
An error occurred. Please start Anki while holding down the shift key, which will temporarily disable the add-ons you have installed.
If the issue only occurs when add-ons are enabled, please use the Tools > Add-ons menu item to disable some add-ons and restart Anki, repeating until you discover the add-on that is causing the problem.
When you've discovered the add-on that is causing the problem, please report the issue on the add-on support site.
Debug info:
Anki 2.1.26 (arch-linux-2.1.26-1) Python 3.8.3 Qt 5.15.0 PyQt 5.15.0
Platform: Linux
Flags: frz=False ao=True sv=1
Add-ons, last update check: 2020-07-18 19:01:16
Add-ons possibly involved: Pull from Duolingo

Caught exception:
Traceback (most recent call last):
  File "/home/dan/.local/share/Anki2/addons21/557761805/plugin.py", line 41, in sync_duolingo
    lingo = login_thread.join()
  File "/home/dan/.local/share/Anki2/addons21/557761805/duolingo_thread.py", line 29, in join
    raise e
  File "/home/dan/.local/share/Anki2/addons21/557761805/duolingo_thread.py", line 16, in run
    self.return_value.put(self._target(*self._args, **self._kwargs))
  File "/home/dan/.local/share/Anki2/addons21/557761805/duolingo.py", line 73, in __init__
    self.user_data = Struct(**self._get_data())
  File "/home/dan/.local/share/Anki2/addons21/557761805/duolingo.py", line 215, in _get_data
    get = self._make_req(self.user_url).json()
  File "/usr/lib/python3.8/site-packages/requests/models.py", line 898, in json
    return complexjson.loads(self.text, **kwargs)
  File "/usr/lib/python3.8/json/__init__.py", line 357, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python3.8/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python3.8/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

Hi @nerddan are you still experiencing this? Last time when this cropped up it was due to some temporary change on Duolingo's side, and I was able to see the same error on my computer.
But this time I can't. Could you try again? I'm wondering whether this is another temporary issue that went away, or whether there's something different going on if you are still experiencing the error but I can't see it.

I haven’t had any problems recently
On Sun, Jul 19, 2020 at 3:51 PM Joseph Schilz<EMAIL_ADDRESS>wrote:

Hi @nerddan https://github.com/nerddan are you still experiencing this?
Last time when this cropped up it was due to some temporary change on
Duolingo's side, and I was able to see the same error on my computer.
But this time I can't. Could you try again? I'm wondering whether this is
another temporary issue that went away, or whether there's something
different going on if you are still experiencing the error but I can't see
it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/JASchilz/AnkiSyncDuolingo/issues/25#issuecomment-660721272,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AO6SK4KOEUQGO3R5ZF43I2DR4N2GLANCNFSM4LRYOCPQ
.

--
Sent from Gmail Mobile

@JASchilz No I quit using Anki.


setting maxline 2 and textoverflow is not affecting/working

OK, I fixed a bug where max lines was not working properly if we hyphenate the text.

Perfect i can confirm that the bug is now fixed thank you.

One more thing, when i want to set the textOverflow to ellipsis or anything, its not affecting. I will open a new issue for this. Anyway thank you for your quick response.


include 2048 bevy reset game event video

Part of #640
Let me know if I got anything wrong 😅 This is my first time contributing to the newsletter

Thank you for the PR!
Content was fine, just made a couple of tweaks for line length/making the image clickable :)