External OpenIdConnect providers don't work with ASP.NET Identity

Issue / Steps to reproduce the problem
Start with QuickStart 8_AspNetIdentity.  Add the following:
                .AddOpenIdConnect("oidc", "OpenID Connect", options =>
                {
                    options.SignInScheme = IdentityServerConstants.ExternalCookieAuthenticationScheme;
                    options.SignOutScheme = IdentityServerConstants.SignoutScheme;
                    options.Authority = "https://demo.identityserver.io/";
                    options.ClientId = "implicit";
                    options.TokenValidationParameters = new TokenValidationParameters
                    {
                        NameClaimType = "name",
                        RoleClaimType = "role"
                    };
                });

Run IdentityServerAspNetIdentity and JavaScriptClient, click login, then click the OpenID Connect button to login via demo site, input bob/bob as username/password and select yes to all the prompts.
Callback fails.
Relevant parts of the log file
2019-02-22 09:49:51.137 -06:00 [DBG] Start authorize request
2019-02-22 09:49:51.138 -06:00 [DBG] No user present in authorize request
2019-02-22 09:49:51.138 -06:00 [DBG] Start authorize request protocol validation
2019-02-22 09:49:51.139 -06:00 [DBG] client configuration validation for client js succeeded.
2019-02-22 09:49:51.139 -06:00 [DBG] Checking for PKCE parameters
2019-02-22 09:49:51.139 -06:00 [DBG] Calling into custom validator: IdentityServer4.Validation.DefaultCustomAuthorizeRequestValidator
2019-02-22 09:49:51.139 -06:00 [INF] ValidatedAuthorizeRequest
{"ClientId":"js","ClientName":"JavaScript Client","RedirectUri":"http://localhost:5003/callback.html","AllowedRedirectUris":["http://localhost:5003/callback.html"],"SubjectId":"anonymous","ResponseType":"code","ResponseMode":"query","GrantType":"authorization_code","RequestedScopes":"openid profile api1","State":"5f749b7ac07b44f1ae24221f05f2ddd5","UiLocales":null,"Nonce":null,"AuthenticationContextReferenceClasses":null,"DisplayMode":null,"PromptMode":null,"MaxAge":null,"LoginHint":null,"SessionId":null,"Raw":{"client_id":"js","redirect_uri":"http://localhost:5003/callback.html","response_type":"code","scope":"openid profile api1","state":"5f749b7ac07b44f1ae24221f05f2ddd5","code_challenge":"JuGTqZfodiLn32mwI-92e5J8UK_tncEJTjKU-CJlQqY","code_challenge_method":"S256"},"$type":"AuthorizeRequestValidationLog"}
2019-02-22 09:49:51.139 -06:00 [INF] Showing login: User is not authenticated
2019-02-22 09:49:51.163 -06:00 [DBG] Start authorize request protocol validation
2019-02-22 09:49:51.163 -06:00 [DBG] client configuration validation for client js succeeded.
2019-02-22 09:49:51.164 -06:00 [DBG] Checking for PKCE parameters
2019-02-22 09:49:51.164 -06:00 [DBG] Calling into custom validator: IdentityServer4.Validation.DefaultCustomAuthorizeRequestValidator
2019-02-22 09:49:51.169 -06:00 [DBG] client configuration validation for client js succeeded.
2019-02-22 09:49:54.564 -06:00 [INF] AuthenticationScheme: oidc was challenged.
2019-02-22 09:50:06.252 -06:00 [DBG] CORS request made for path: /signin-oidc from origin: null but was ignored because path was not for an allowed IdentityServer CORS endpoint
2019-02-22 09:50:06.281 -06:00 [INF] AuthenticationScheme: idsrv.external signed in.
2019-02-22 09:50:06.339 -06:00 [ERR] An unhandled exception has occurred while executing the request.
System.Exception: External authentication error
   at Host.Quickstart.Account.ExternalController.Callback() in D:\Dev\8_AspNetIdentity\src\IdentityServerAspNetIdentity\Quickstart\Account\ExternalController.cs:line 96
   at Microsoft.AspNetCore.Mvc.Internal.ActionMethodExecutor.TaskOfIActionResultExecutor.Execute(IActionResultTypeMapper mapper, ObjectMethodExecutor executor, Object controller, Object[] arguments)
   at System.Threading.Tasks.ValueTask`1.get_Result()
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.InvokeActionMethodAsync()
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.InvokeNextActionFilterAsync()
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.Rethrow(ActionExecutedContext context)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.InvokeInnerFilterAsync()
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.InvokeNextResourceFilter()
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.Rethrow(ResourceExecutedContext context)
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.InvokeFilterPipelineAsync()
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.InvokeAsync()
   at Microsoft.AspNetCore.Builder.RouterMiddleware.Invoke(HttpContext httpContext)
   at IdentityServer4.Hosting.IdentityServerMiddleware.Invoke(HttpContext context, IEndpointRouter router, IUserSession session, IEventService events) in C:\local\identity\server4\IdentityServer4\src\Hosting\IdentityServerMiddleware.cs:line 72
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.Cors.Infrastructure.CorsMiddleware.Invoke(HttpContext context)
   at IdentityServer4.Hosting.BaseUrlMiddleware.Invoke(HttpContext context) in C:\local\identity\server4\IdentityServer4\src\Hosting\BaseUrlMiddleware.cs:line 36
   at Microsoft.AspNetCore.StaticFiles.StaticFileMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.MigrationsEndPointMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.DatabaseErrorPageMiddleware.Invoke(HttpContext httpContext)
   at Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.DatabaseErrorPageMiddleware.Invoke(HttpContext httpContext)
   at Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware.Invoke(HttpContext context)

                options.SignInScheme = IdentityServerConstants.ExternalCookieAuthenticationScheme;

I'm going to guess that's theh wrong scheme.

You are, of course, right.  I've got it working now.  Thanks for the help.
I've looked over the docs again, but I can't seem to find something that explains why when not using ASP.NET Identity you would use the IdentityServer4 ExternalCookieAuthenticationScheme but when you are using ASP.NET Identity you should use the ASP.NET Identity ExternalScheme.
Is it just when you aren't using ASP.NET Identity there isn't a scheme already present so you have to use the one defined by IdentityServer4, but if you are you can just use the built in one?
I'm still trying to wrap my head around this and what to make sure I'm not missing something.
Thanks again!

I've looked over the docs again, but I can't seem to find something that explains why when not using ASP.NET Identity you would use the IdentityServer4 ExternalCookieAuthenticationScheme but when you are using ASP.NET Identity you should use the ASP.NET Identity ExternalScheme.

Because IdentityServer registers an external cookie for convenience. If you're also using ASP.NET Identity they do their own as well.


Fix flaky limits test.

In the limits test we check statistics with ets:info right after
eviction. Sometimes ets:info does not update immediately.
On first failure, delay for 1ms, then try again.

+1


feat: always separate lidar preprocessing from pointcloud_container

Description
See https://github.com/autowarefoundation/autoware.universe/pull/6091

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[x] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

hello, I'm wondering why did not you remove use_pointcloud_container from pointcloud_preprocessor parts. @kminoda

Thank you for your comment. The flag is currently necessary to control whether to attach concatenation node to /pointcloud_container or not.
BTW we are considering removing the flag: https://github.com/orgs/autowarefoundation/discussions/4112


Fix so dfs.client.failover.max.attempts is respected correctly

Without this change, you would get incorrect behavior in that you would always have to set dfs.client.failover.max.attempts to be +1 greater to have the desired behavior, e.g. if you want it to attempt failover exactly once, you would have to set dfs.client.failover.max.attempts=2.
Without this change, if you set dfs.client.failover.max.attempts=1, to attempt to failover just once time, instead it wouldn't try at all, and you see this log message:
org.apache.hadoop.io.retry.RetryInvocationHandler - Exception while invoking class org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getFileInfo over hadoop-node-01.docker.infra.atscale.com/<IP_ADDRESS>:8020. Not retrying because failovers (1) exceeded maximum allowed (1)

Note that the non-failover retries just below this change is correct.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
26
Docker mode activated.

_ Prechecks _

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1027
trunk passed

+1
compile
979
trunk passed

+1
checkstyle
46
trunk passed

+1
mvnsite
72
trunk passed

+1
shadedclient
753
branch has no errors when building and testing our client artifacts.

+1
findbugs
95
trunk passed

+1
javadoc
55
trunk passed

_ Patch Compile Tests _

+1
mvninstall
43
the patch passed

+1
compile
936
the patch passed

+1
javac
936
the patch passed

+1
checkstyle
52
the patch passed

+1
mvnsite
77
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
655
patch has no errors when building and testing our client artifacts.

+1
findbugs
110
the patch passed

+1
javadoc
60
the patch passed

_ Other Tests _

-1
unit
489
hadoop-common in the patch failed.

+1
asflicense
45
The patch does not generate ASF License warnings.

5573

Reason
Tests

Failed junit tests
hadoop.crypto.key.kms.TestLoadBalancingKMSClientProvider

hadoop.ha.TestZKFailoverController

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-699/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/699

Optional Tests
dupname  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  shadedclient  findbugs  checkstyle

uname
Linux 6c32d6f96f27 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / d2141ef

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

findbugs
v3.1.0-RC1

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-699/1/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-699/1/testReport/

Max. process+thread count
1463 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-699/1/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
34
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1025
trunk passed

+1
compile
1026
trunk passed

+1
checkstyle
44
trunk passed

+1
mvnsite
81
trunk passed

+1
shadedclient
760
branch has no errors when building and testing our client artifacts.

+1
javadoc
59
trunk passed

0
spotbugs
116
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
115
trunk passed

_ Patch Compile Tests _

+1
mvninstall
45
the patch passed

+1
compile
1082
the patch passed

+1
javac
1082
the patch passed

+1
checkstyle
39
the patch passed

+1
mvnsite
69
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
606
patch has no errors when building and testing our client artifacts.

+1
javadoc
51
the patch passed

+1
findbugs
131
the patch passed

_ Other Tests _

-1
unit
509
hadoop-common in the patch failed.

+1
asflicense
40
The patch does not generate ASF License warnings.

5758

Reason
Tests

Failed junit tests
hadoop.crypto.key.kms.TestLoadBalancingKMSClientProvider

Subsystem
Report/Notes

Docker
Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-699/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/699

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 3f2c41df6486 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / cd967c7

Default Java
1.8.0_212

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-699/2/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-699/2/testReport/

Max. process+thread count
1507 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-699/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
43
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1058
trunk passed

+1
compile
1125
trunk passed

+1
checkstyle
40
trunk passed

+1
mvnsite
75
trunk passed

+1
shadedclient
796
branch has no errors when building and testing our client artifacts.

+1
javadoc
61
trunk passed

0
spotbugs
123
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
122
trunk passed

_ Patch Compile Tests _

+1
mvninstall
50
the patch passed

+1
compile
1097
the patch passed

+1
javac
1097
the patch passed

+1
checkstyle
38
the patch passed

+1
mvnsite
72
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
629
patch has no errors when building and testing our client artifacts.

+1
javadoc
60
the patch passed

+1
findbugs
131
the patch passed

_ Other Tests _

-1
unit
539
hadoop-common in the patch failed.

+1
asflicense
44
The patch does not generate ASF License warnings.

6032

Reason
Tests

Failed junit tests
hadoop.crypto.key.kms.TestLoadBalancingKMSClientProvider

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-699/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/699

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 8280560c21e0 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / c0a0c35

Default Java
1.8.0_212

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-699/3/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-699/3/testReport/

Max. process+thread count
1446 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-699/3/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
80
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1222
trunk passed

+1
compile
1160
trunk passed

+1
checkstyle
44
trunk passed

+1
mvnsite
81
trunk passed

+1
shadedclient
885
branch has no errors when building and testing our client artifacts.

+1
javadoc
63
trunk passed

0
spotbugs
128
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
126
trunk passed

_ Patch Compile Tests _

+1
mvninstall
51
the patch passed

+1
compile
1113
the patch passed

+1
javac
1113
the patch passed

+1
checkstyle
45
the patch passed

+1
mvnsite
76
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
757
patch has no errors when building and testing our client artifacts.

+1
javadoc
68
the patch passed

+1
findbugs
148
the patch passed

_ Other Tests _

-1
unit
548
hadoop-common in the patch failed.

+1
asflicense
48
The patch does not generate ASF License warnings.

6584

Reason
Tests

Failed junit tests
hadoop.crypto.key.kms.TestLoadBalancingKMSClientProvider

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-699/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/699

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux dbf5908f2fcd 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / e20b195

Default Java
1.8.0_222

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-699/4/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-699/4/testReport/

Max. process+thread count
1345 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-699/4/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
77
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1226
trunk passed

+1
compile
1122
trunk passed

+1
checkstyle
48
trunk passed

+1
mvnsite
89
trunk passed

+1
shadedclient
940
branch has no errors when building and testing our client artifacts.

+1
javadoc
66
trunk passed

0
spotbugs
133
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
131
trunk passed

_ Patch Compile Tests _

+1
mvninstall
48
the patch passed

+1
compile
1067
the patch passed

+1
javac
1067
the patch passed

+1
checkstyle
49
the patch passed

+1
mvnsite
86
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
743
patch has no errors when building and testing our client artifacts.

+1
javadoc
63
the patch passed

+1
findbugs
131
the patch passed

_ Other Tests _

-1
unit
526
hadoop-common in the patch failed.

+1
asflicense
41
The patch does not generate ASF License warnings.

6507

Reason
Tests

Failed junit tests
hadoop.crypto.key.kms.TestLoadBalancingKMSClientProvider

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-699/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/699

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 4391f1b04cdf 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 70b4617

Default Java
1.8.0_222

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-699/5/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-699/5/testReport/

Max. process+thread count
1713 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-699/5/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Is there a jira filed for this?

Please follow this doc to file a jira and contribute https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
Thanks!

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
42
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1090
trunk passed

+1
compile
1192
trunk passed

+1
checkstyle
42
trunk passed

+1
mvnsite
78
trunk passed

+1
shadedclient
756
branch has no errors when building and testing our client artifacts.

+1
javadoc
61
trunk passed

0
spotbugs
118
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
116
trunk passed

_ Patch Compile Tests _

+1
mvninstall
46
the patch passed

+1
compile
1061
the patch passed

+1
javac
1061
the patch passed

+1
checkstyle
36
the patch passed

+1
mvnsite
72
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
650
patch has no errors when building and testing our client artifacts.

+1
javadoc
63
the patch passed

+1
findbugs
122
the patch passed

_ Other Tests _

-1
unit
527
hadoop-common in the patch failed.

+1
asflicense
39
The patch does not generate ASF License warnings.

6044

Reason
Tests

Failed junit tests
hadoop.crypto.key.kms.TestLoadBalancingKMSClientProvider

hadoop.util.TestReadWriteDiskValidator

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-699/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/699

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 1ac925886d57 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 397a563

Default Java
1.8.0_212

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-699/6/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-699/6/testReport/

Max. process+thread count
1424 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-699/6/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
86
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1276
trunk passed

+1
compile
1071
trunk passed

+1
checkstyle
42
trunk passed

+1
mvnsite
80
trunk passed

+1
shadedclient
844
branch has no errors when building and testing our client artifacts.

+1
javadoc
66
trunk passed

0
spotbugs
124
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
122
trunk passed

_ Patch Compile Tests _

+1
mvninstall
49
the patch passed

+1
compile
1114
the patch passed

+1
javac
1114
the patch passed

+1
checkstyle
48
the patch passed

+1
mvnsite
89
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
750
patch has no errors when building and testing our client artifacts.

+1
javadoc
66
the patch passed

+1
findbugs
146
the patch passed

_ Other Tests _

-1
unit
556
hadoop-common in the patch failed.

+1
asflicense
42
The patch does not generate ASF License warnings.

6516

Reason
Tests

Failed junit tests
hadoop.crypto.key.kms.TestLoadBalancingKMSClientProvider

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-699/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/699

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 2360f0c08d62 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / e356e4f

Default Java
1.8.0_222

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-699/7/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-699/7/testReport/

Max. process+thread count
1345 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-699/7/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
44
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1050
trunk passed

+1
compile
1143
trunk passed

+1
checkstyle
39
trunk passed

+1
mvnsite
70
trunk passed

+1
shadedclient
739
branch has no errors when building and testing our client artifacts.

+1
javadoc
56
trunk passed

0
spotbugs
110
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
107
trunk passed

_ Patch Compile Tests _

+1
mvninstall
43
the patch passed

+1
compile
1027
the patch passed

+1
javac
1027
the patch passed

+1
checkstyle
37
the patch passed

+1
mvnsite
66
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
646
patch has no errors when building and testing our client artifacts.

+1
javadoc
57
the patch passed

+1
findbugs
124
the patch passed

_ Other Tests _

-1
unit
484
hadoop-common in the patch failed.

+1
asflicense
41
The patch does not generate ASF License warnings.

5828

Reason
Tests

Failed junit tests
hadoop.crypto.key.kms.TestLoadBalancingKMSClientProvider

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-699/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/699

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux f3d6053765b9 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 094d736

Default Java
1.8.0_222

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-699/8/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-699/8/testReport/

Max. process+thread count
1379 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-699/8/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
39
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1109
trunk passed

+1
compile
1050
trunk passed

+1
checkstyle
37
trunk passed

+1
mvnsite
71
trunk passed

+1
shadedclient
749
branch has no errors when building and testing our client artifacts.

+1
javadoc
60
trunk passed

0
spotbugs
118
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
116
trunk passed

_ Patch Compile Tests _

+1
mvninstall
44
the patch passed

+1
compile
1027
the patch passed

+1
javac
1027
the patch passed

+1
checkstyle
39
the patch passed

+1
mvnsite
72
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
671
patch has no errors when building and testing our client artifacts.

+1
javadoc
64
the patch passed

+1
findbugs
135
the patch passed

_ Other Tests _

-1
unit
512
hadoop-common in the patch failed.

+1
asflicense
51
The patch does not generate ASF License warnings.

5910

Reason
Tests

Failed junit tests
hadoop.crypto.key.kms.TestLoadBalancingKMSClientProvider

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-699/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/699

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 75df786e9d9f 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 69ddb36

Default Java
1.8.0_222

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-699/9/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-699/9/testReport/

Max. process+thread count
1378 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-699/9/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
37
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1207
trunk passed

+1
compile
1133
trunk passed

+1
checkstyle
42
trunk passed

+1
mvnsite
79
trunk passed

+1
shadedclient
864
branch has no errors when building and testing our client artifacts.

+1
javadoc
65
trunk passed

0
spotbugs
125
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
123
trunk passed

_ Patch Compile Tests _

+1
mvninstall
48
the patch passed

+1
compile
1080
the patch passed

+1
javac
1080
the patch passed

+1
checkstyle
45
the patch passed

+1
mvnsite
73
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
729
patch has no errors when building and testing our client artifacts.

+1
javadoc
65
the patch passed

+1
findbugs
138
the patch passed

_ Other Tests _

-1
unit
559
hadoop-common in the patch failed.

+1
asflicense
47
The patch does not generate ASF License warnings.

6403

Reason
Tests

Failed junit tests
hadoop.crypto.key.kms.TestLoadBalancingKMSClientProvider

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-699/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/699

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 5d3264d27ac4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 3329257

Default Java
1.8.0_222

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-699/10/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-699/10/testReport/

Max. process+thread count
1326 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-699/10/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
33
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1251
trunk passed

+1
compile
1118
trunk passed

+1
checkstyle
45
trunk passed

+1
mvnsite
77
trunk passed

+1
shadedclient
862
branch has no errors when building and testing our client artifacts.

+1
javadoc
72
trunk passed

0
spotbugs
147
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
144
trunk passed

_ Patch Compile Tests _

+1
mvninstall
58
the patch passed

+1
compile
1143
the patch passed

+1
javac
1143
the patch passed

+1
checkstyle
50
the patch passed

+1
mvnsite
84
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
737
patch has no errors when building and testing our client artifacts.

+1
javadoc
72
the patch passed

+1
findbugs
143
the patch passed

_ Other Tests _

-1
unit
538
hadoop-common in the patch failed.

+1
asflicense
42
The patch does not generate ASF License warnings.

6538

Reason
Tests

Failed junit tests
hadoop.crypto.key.kms.TestLoadBalancingKMSClientProvider

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-699/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/699

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux e4f4d6cbf791 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 915cbc9

Default Java
1.8.0_222

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-699/11/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-699/11/testReport/

Max. process+thread count
1494 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-699/11/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.


Intranet: ('/hackerman') gets sayings and does conversations based on state of image

The page '/hackerman' of the intranet app and service displays Mr. Hackerman. He says a lot to the user, but needs to say the right things.
Hackerman will have two kinds of expressions:

Explanations. At every new step, these expressions are given away freely. So when the user gets to the level, Mr. Hackerman will start the explanation.
Hints. Every 5 minutes after the explanation, Mr. Hackerman will give new hints after clicking a button, to help the user with the challenge (step).

My idea is to let him do that like this:

The front-end requests new explanations and hints
The back-end retrieves the current state of the image (that is the current challenge + the current step)
Based on the current state of the image, the back-end retrieves the right explanations + hints
The back-end passes gives the explanations+hints to the front-end.

Implemented and is working correctly.


[3905] Maintain cohort state

Context
Trainees can be considered:
past: they have completed their training (or withdrawn) prior to the current academic cycle
current: they are still training or deferred or have withdrawn or been awarded in the current cycle
future: they start after the end of the current cycle
Changes to the trainee record (e.g. ITT start date or a status change) or a change in the current academic cycle can cause this status to change.
Changes proposed in this pull request

Add Trainees:SetCohort, a service that sets the Trainee#cohort field based on the current cycle and trainee state
Add a job to call this async
Add a nightly job to run through current and future trainees and update their cohort to ensure this is correctly set
Add a callback to set the cohort when the trainee is saved
Add AcademicCycle.current to make it easier to get a reference to the 'current' cycle
Exclude cohort from the dqt_update_sha calculation as we don't need to update DQT when a cohort changes. We can consider this internal.

Guidance to review
Important business

Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?

 [L] past|current|future trainee state


How to securely setup DRY multienvironment terragrunt

Goal: I want to have a setup where I have a root module creating an IAM user for terragrunt to assume in number of environments (dev, staging, prod). Root module will be created with some root org IAM user credentials but other modules should be created by assuming a role in a specific env (because I want each env to live in a separate AWS account). I also want to have those credentials propagated automatically to dev/staging/prod modules.
My approach at the moment:
I have a root organization in which I'm creating an organizational unit dev and an IAM user terraform who can sts:AssumeRole in dev (OrganizationAccountAccessRole):
root/main.tf:
terraform {
  backend "s3" {

  }
  required_providers {
    aws = {
      source  = "hashicorp/aws"
      version = "3.63.0"
    }
  }
}

resource "aws_organizations_organization" "organization" {
  aws_service_access_principals = [
    "cloudtrail.amazonaws.com",
    "config.amazonaws.com",
  ]

  feature_set = "ALL"
}

resource "aws_organizations_organizational_unit" "unit_dev" {
  name      = "dev"
  parent_id = aws_organizations_organization.organization.roots[0].id
}

resource "aws_organizations_account" "unit_dev_account" {
  name  = "name"
  email =<EMAIL_ADDRESS>  parent_id = aws_organizations_organizational_unit.unit_dev.id
  iam_user_access_to_billing = "DENY"
}

resource "aws_iam_user" "terraform_user" {
  name = "terraform"
  path = "/cicd/"
}

resource "aws_iam_access_key" "terraform_user" {
  user    = aws_iam_user.terraform_user.name
}

resource "aws_iam_user_policy" "terraform_user_assume_organization_role_dev" {
  name = "AssumeOrganizationRoleDev"
  user = aws_iam_user.terraform_user.name

  policy = <<EOF
{
  "Version": "2012-10-17",
  "Statement": [
    {
      "Action": [
        "sts:AssumeRole"
      ],
      "Effect": "Allow",
      "Resource": "arn:aws:iam::${aws_organizations_account.unit_dev_account.id}:role/OrganizationAccountAccessRole"
    }
  ]
}
EOF
}

output "unit_dev_account" {
  value = aws_organizations_account.unit_dev_account.id
}

output "terraform_user_name" {
  value = aws_iam_user.terraform_user.name
}

output "terraform_user_access_keys" {
  value = aws_iam_access_key.terraform_user
  sensitive = true
}

Now in dev/terragrunt.hcl:
locals {
  env = "dev"
  aws_region = "eu-west-1"
  aws_profile = "my-profile"
}

dependency "root_org" {
  config_path = "${get_parent_terragrunt_dir()}/../root"
}

remote_state {
  backend = "s3"
  config = {
    bucket         = "terraform-state-geocargo-${local.env}"
    key            = "${path_relative_to_include()}/terraform.tfstate"
    region         = local.aws_region
    encrypt        = true
    dynamodb_table = "terraform-lock-table"
    profile        = local.aws_profile
  }
}

generate "provider" {
  path = "provider.tf"
  if_exists = "overwrite_terragrunt"
  contents = <<EOF
provider "aws" {
    access_key = "${dependency.root_org.outputs.terraform_user_access_keys.id}"
    secret_key = "${dependency.root_org.outputs.terraform_user_access_keys.secret}"
     assume_role {
      role_arn     = "arn:aws:iam::${dependency.root_org.outputs.unit_dev_account}:role/OrganizationAccountAccessRole"
      session_name = "terragrunt-session"
    }
    region  = "${local.aws_region}"
}
EOF
}

The downsides of this solution:

access_key and secret_key are written to the disk into provider.tf file,
s3 configuration in dev still uses a profile used to create root module (I was not able to configure it using assume role with secrets created in root module)

Are there any better approaches to this? I'm planning to run terragrunt apply on Codebuild in the future which I can encrypt underlying storage on with KMS. Maybe writing secrets to disks isn't really such a big deal here?

I don't think the current mechanisms that Terragrunt exposes is going to support this. Supporting this is most definitely going to need an overhaul of the cloud authentication functionality (https://github.com/gruntwork-io/terragrunt/issues/1840).
Terragrunt basically only has features for assuming a role, but it does not have any feature for switching IAM users, which is what it sounds like you need. We are most likely not going to implement anything like that without overhauling the cloud auth mechanisms.
With that said, if you are looking for a resolution for just the provider authentication (and not the s3 config), one thing you can do is to store the credentials in secrets manager and dump data sources:
generate "provider" {
  path = "provider.tf"
  if_exists = "overwrite_terragrunt"
  contents = <<EOF
data "aws_secretsmanager_secret_version" "access_key" {
  secret_id = "${dependency.root_org.outputs.terraform_user_access_keys_secrets_manager_arn}"
}

provider "aws" {
    access_key = jsondecode(data.aws_secretsmanager_secret_version.access_key.secret_string).access_key
    secret_key = jsondecode(data.aws_secretsmanager_secret_version.access_key.secret_string).secret_key
     assume_role {
      role_arn     = "arn:aws:iam::${dependency.root_org.outputs.unit_dev_account}:role/OrganizationAccountAccessRole"
      session_name = "terragrunt-session"
    }
    region  = "${local.aws_region}"
}
EOF
}


[branch-2.4][cherry-pick] optimize merge/serialize/finalize stage in UDAF (#11060)

starrocks_be_unittest succeeded.


Fix next page token

PR Checklist

[X] A description of the changes is added to the description of this PR.
[X] If there is a related issue, make sure it is linked to this PR.
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] If you've added or modified a feature, documentation in docs is updated

Description of changes
Addresses #21
When performing a tables.list operation, it seems that the server returns the empty string "" instead of None as documented in the spec.
Fixed this by making the paginated request return null instead.
Testing
On a default run of unity catalog, did this manual test:
import unitycatalog

client = unitycatalog.Unitycatalog(base_url="http://<IP_ADDRESS>:8080/api/2.1/unity-catalog/")
response = client.tables.list(catalog_name="unity", schema_name="default")

assert response.next_page_token is None, f"This will fail, with a non-empty token: {response.next_page_token}"

response = client.tables.list(catalog_name="unity", schema_name="default", page_token=response.next_page_token)
assert len(response.tables) > 0, "This will fail, because response has no tables"
assert response.next_page_token is None

Any tips for testing this effectively?

@tdas can you review this PR?

@ramesh-db Thanks for the review! Do you have a code pointer for this repo's testing framework?

Hi @abrassel , you can checkout the file BaseTableCRUDTest and SdkTableCRUDTest. Ideally we would have wanted to add this check directly to the BaseTableCRUDTest, however we have currently kept the return type of listTables as  List (which omits the next page token)  to keep compatibility between Sdk and Cli Tests (in CLI we are not handling next page tokens). A workaround would be to create a small ListTablesTest at the level of SdkTableCRUDTest (which directly extends BaseCRUDTest or BaseServerTest) and just creates a couple of tables and Tests the output of the listTables. Then it can read the response as ListTableResponse and check the nextPageToken field.

Hi @ramesh-db I added a test. We should be good to go now.


163204 Updated Solution Template Blades & Altered the Default LANSA MSI Depe…

…nding on LANSA Version
PR Checklist
Check these items before submitting a PR...
Contribution Guide
Best Practice Guide

[ ] - Please check this box once you've submitted the PR if you've read through the Contribution Guide and best practices checklist.

Changelog

Updated the solution blades as per the provided comments
Altered the MSI URL as per the lansa version provided

@robe070, Review comments incorporated. The webServerMaxConnect and maxSizeBytes variables have been changed to integer values though they were defaulted to and accepted as string values in the existing template.

I've noticed a few more cases to provide automatic validation.

Edition
Valid RSON

Basic
Basic

Standard
Sx

Premium
Px

Application Gateway SKU Tier
Valid Application Gateway SKU Name

Standard
Standard x

WAF
WAF x

@robe070, Do the changes need to be made for default values for the provided fields? I can see them the same way in mainTemplate.json. I also tried deploying it with the existing values and it worked. Please confirm.

Do the changes need to be made for default values for the provided fields? I can see them the same way in mainTemplate.json. I also tried deploying it with the existing values and it worked. Please confirm.

Which fields? Existing values in createUIDefinition.json?

Sorry for bothering you @robe070.  Have taken care of the requirements and pushed the required changes.


Codes for self-attention version

Hi,
I'm very interesting in your work, could you provide the codes for self-attention version?
Thank you very much!

Hi klyao,
Thanks for interesting our work, could you please find the DFNets with self-attention version (dfnet-att) using the following link DFNet-ATT.

Hi wokas36,
Thank you very much for releasing the codes! I have some questions for reproducing results, and it's about how to select final testing results:

Select the testing results at the final epoch (200)? If so, I run both dfnet and dfnet-att with 100 runs, and the results are not consistent with those in the paper by a little large gap. I don't know what results into the differences.
If we select the testing results according to the validation loss or accuracy, the results would be worse than option 1.

Can you provide a complete version for reproducing results in the paper? That will help a lot!
I will be very appreciate if you can answer my questions.

Hi klyao,
Extremely sorry for the late reply (I was traveling in last two weeks and limited access of internet). Thanks in advance for your valuable suggestions and feedback for improving our code quality and results. If u need to reproduce our results, please change the hyperparameter setting of mu to 70 for dfnet and 100 for dfnet-att respectively (200 training samples) for successfully reproducing the similar results. However, there may have tiny differences due to the stochasticity of the models (due to randomly initializing the weights and biases). If you need to reproduce the results with training/validation/testing splits, you need to reconfigure the hyperparameter settings in advance w.r.t validation dataset. But it may take some times, because our hyperparameter space is larger than the usual settings (we introduce 7 to 8 new hyperparameter  settings for dfnets). You can use DFNets_v_2.0 for reproducing the results with training/validation/testing splits. Hope that our reply can help you.


Small issue with %DATE% in make.cmd

Depending of local time format from %DATE% variable in the build section contain wrong characters and build will not occurs.
As git log is already used, you could change the build section to :
:build
        for /F %%I IN ('dir /s /b /aa *.go') do go fmt "%%I" & attrib -A "%%I"
        powershell -ExecutionPolicy RemoteSigned "cd '%~dp0main' ; . '%~dp0main\makesyso.ps1'"
        for /F "delims=" %%V in ('git log -1 --date^=short --pretty^=format:"-X main.stamp=%%ad -X main.commit=%%H"') do go build -o nyagos.exe -ldflags "%%V %X_VERSION%" .\main
        goto end

You can change if you prefer with commiter date or elaborate a more accurate +today+ date using
WMIC OS GET LocalDateTime

Thank you!


[BI-698] Import Traits not available until refreshing page after adding self to program

If the active user is being added to a program then the active user roles are updated as part of the success handler.
Description: Import Traits not available until refreshing page after adding self to program
Component/Version: v0.2
Steps to Reproduce
login as admin
add self to a program
select traits in left navigation bar
Expected result:
Import Traits visible as a selection
Actual Result:
Import traits not visible until the page is refreshed

Ok, the active user role should be updated now when the active user role is edited in program management.


Rename package to google-cloud-dialogflow to follow naming convention

All other Python cloud packages are named google-cloud-*. For consistency, dialogflow should also be renamed to google-cloud-dialogflow.
Steps:

Publish a last release of dialogflow with a note in the README directing users to the new package.
Change the package name to google-cloud-dialogflow.
Publish the first release of google-cloud-dialogflow.

CC @nnegrey

Would this move all client library code to google-cloud-python repo?
All samples would also need to be updated with this and docs.

We're actually splitting the big repository out into smaller ones, so I think this repository can remain unchanged.

This is done, although there's some lingering questions about how to signal to users that they should move to the new package. That's tracked in #243


fix(logger-undefined-issue): fixing  logger undefined issue when pass…

…ing no config object

:tada: This PR is included in version 1.4.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


The icon is too ugly. How to change back the previous Icon

The icon is too ugly.

How can I change back the previous icon?

This repo is for the icons assets, anything else related to the product and direction please file an issue with the main microsoft/vscode repo. The only to go back to the previous version is to downgrade to a previous version.


v0.8.1 Crashes when launching

I just updated to v0.8.1 and it crashes when launching the application.

Same issue here, app crashes even after reinstalling and clearing data.

@yaichenbaum v0.8.1 working fine for me. 20/20 successful starts.

Same issue here, app crashes even after reinstalling and clearing data.

Weirdly enough, after rebooting the machine I could open the app.

It's kinda random, I'm able to use the app after several boots

This issue has been fixed with the v0.8.2 release.

0.8.2 still crashes for me with a Windows.UI.XAML.dll crash.


inference using float16 is not faster than float32  for rnn model

Hello, I use this predict-cpp  to infer some images.
When I use float16 to infer a cnn model and it shows the speed is much faster than using float32. But when I use float16 to infer a rnn model , the speed is nearly same with using float32.
So what causes this? can you give some advises?
Looking forward to your reply.

@IvyGongoogle The predict-cpp example mentioned in the issue is designed from image recognition.
Can you please share the reproducible example for rnn network? It will help community members to address the issue.
@mxnet-label-bot add [FP16, RNN]

@IvyGongoogle Can you share the minimum reproducible script so that we can debug this issue ?

@leleamol @piyushghai  thanks for your reply.  You can get my reproducible example here.  Before you try it, hope you read README.md to see how to get it works.
Looking forward your reply and advises.
thank you very much~~~


Parallel Raytracing demo broken

Describe the Bug
Visiting this page the button for rendering never activates, but instead shows "Loading wasm..." indefinitely.
Steps to Reproduce
Load the page after enabling shared memory buffers
Additional Context
In Firefox, the console reports this...
`WebAssembly.instantiateStreaming` failed. Assuming this is because your server does not serve wasm with `application/wasm` MIME type. Falling back to `WebAssembly.instantiate` which is slower. Original error:
 CompileError: "wasm validation error: at offset 4088: unknown section before code section" raytrace_parallel.js:610:17
TypeError: "Body has already been consumed."
    result https://rustwasm.github.io/wasm-bindgen/exbuild/raytrace-parallel/raytrace_parallel.js:612

Note that the demo currently requires Firefox Nightly and for a few features to be enabled. It does its best job to alert you to this if it's not working, but it seems to clearly not be working!

(and FWIW in nightly the demo continues to work for me tonight, so this is likely a local configuration issue)

Ah, yes. I was on the beta channel, not the nightly channel. It turns out once you enable the shared memory buffer, the page no longer warns you to switch to nightly. This is minor, closing.


How can I deal with memory problem?

Bug/Feature Request Title
I got a bunch of WARNING messages during dfs process. Here is the code:
features= ft.dfs(
    entityset=es,
    target_entity='stores',
    cutoff_time=data_df[['store_id', 'cutoff_time', '3month_amount_from_cutoff_time']],
    verbose=1,
    cutoff_time_in_index=True,
    n_jobs=16,
    max_depth=2,
    ignore_variables={
        'sales':['sale_id'],
    },
    agg_primitives=[
        "sum", "std", "max","skew", "min", "mean", "median", "count", "percent_true", "num_unique", "mode", "trend", "time_since_last", "time_since_first",
        "first", "last", "entropy", "avg_time_between",
        "n_most_common",
        # "any", "all", "num_true",
    ],
    groupby_trans_primitives=[
        'cum_mean', 'cum_sum', 'cum_min', 'cum_max', 'cum_count',
        'year', 'month',
        'diff', 'haversine', 'is_null', 'percentile',
        'time_since', 'time_since_previous',
    ],
    trans_primitives=[],
    chunk_size=200,
)

# data_df.shape => (61034, 101)
# dataframe in es's shape
#    - es['stores'].shape => (1967, 6)
#    - es['sales'].shape => (6556613, 6)

And WARNING messages I've got:
...
...
distributed.worker - WARNING - Memory use is high but worker has no data to store to disk.  Perhaps some other process is leaking memory?  Process memory: 12.89 GB -- Worker memory limit: 16.54 GB
distributed.worker - WARNING - Memory use is high but worker has no data to store to disk.  Perhaps some other process is leaking memory?  Process memory: 11.98 GB -- Worker memory limit: 16.54 GB
distributed.worker - WARNING - Memory use is high but worker has no data to store to disk.  Perhaps some other process is leaking memory?  Process memory: 12.89 GB -- Worker memory limit: 16.54 GB
distributed.worker - WARNING - Memory use is high but worker has no data to store to disk.  Perhaps some other process is leaking memory?  Process memory: 11.98 GB -- Worker memory limit: 16.54 GB
distributed.worker - WARNING - Memory use is high but worker has no data to store to disk.  Perhaps some other process is leaking memory?  Process memory: 12.52 GB -- Worker memory limit: 16.54 GB
...
...

Bug/Feature Request Description
These WARNING start to show up around 45% in progress bar. I know these are WARNING, but problem is that it finally makes dfs stop running after a few hours later...(raise errors!)
I have enough memory (256GB), the number of cpu (64) but I don't see why it still requires more memory despite of its small memory size.
And when finally dfs is stopped, error messages is like this:
distributed.nanny - WARNING - Worker exceeded 95% memory budget. Restarting
distributed.worker - ERROR - 'EntitySet-dcc40d75cfac8a5e5765e5bba8aeeb7a'
Traceback (most recent call last):
  File "/data/miniconda3/lib/python3.7/site-packages/distributed/worker.py", line 2408, in execute
    data[k] = self.data[k]
  File "/data/miniconda3/lib/python3.7/site-packages/zict/buffer.py", line 72, in __getitem__
    raise KeyError(key)
KeyError: 'EntitySet-dcc40d75cfac8a5e5765e5bba8aeeb7a'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/data/miniconda3/lib/python3.7/site-packages/distributed/worker.py", line 2412, in execute
    data[k] = Actor(type(self.actors[k]), self.address, k, self)
KeyError: 'EntitySet-dcc40d75cfac8a5e5765e5bba8aeeb7a'
tornado.application - ERROR - Exception in callback functools.partial(<bound method IOLoop._discard_future_result of <tornado.platform.asyncio.AsyncIOLoop object at 0x7fb344b70ed0>>, <Task finished coro=<
Worker.execute() done, defined at /data/miniconda3/lib/python3.7/site-packages/distributed/worker.py:2391> exception=KeyError('EntitySet-dcc40d75cfac8a5e5765e5bba8aeeb7a')>)
Traceback (most recent call last):
  File "/data/miniconda3/lib/python3.7/site-packages/distributed/worker.py", line 2408, in execute
    data[k] = self.data[k]
  File "/data/miniconda3/lib/python3.7/site-packages/zict/buffer.py", line 72, in __getitem__
    raise KeyError(key)
KeyError: 'EntitySet-dcc40d75cfac8a5e5765e5bba8aeeb7a'

Moreover, error messages are different time to time: connection closed error some time,  Stream is closed or  distributed.nanny - WARNING - Worker exceeded 95% memory budget etc.
I wonder what should I do to prevent this from occuring:
Reducing chunk_size more? or Reducing n_jobs more? Or any other methods?
Which one is a more desirable way to make dfs done till it finishes completely?
Output of featuretools.show_info()
Featuretools version: 0.12.0
Featuretools installation directory: /data/miniconda3/lib/python3.7/site-packages/featuretools

SYSTEM INFO
-----------
python: 3.7.4.final.0
python-bits: 64
OS: Linux
OS-release: 4.15.0-1054-aws
machine: x86_64
processor: x86_64
byteorder: little
LC_ALL: en_US.UTF-8
LANG: C.UTF-8
LOCALE: en_US.UTF-8

INSTALLED VERSIONS
------------------
numpy: 1.17.2
pandas: 0.25.1
tqdm: 4.36.1
PyYAML: 5.1.2
cloudpickle: 1.2.2
dask: 2.6.0
distributed: 2.6.0
psutil: 5.6.3
Click: 7.0
scikit-learn: 0.21.3
pip: 19.2.3
setuptools: 41.4.0

The warnings are about the workers approaching their individual memory limit.  Reducing n_jobs will increase the amount of memory available to each worker.  If you install the bokeh library you can use  distributed's web interface to monitor the process.

@rwedge You mean, no matter what chunk_size it is, reducing n_jobs will solve this problem?

Once, #783 is merged it, would be curious to hear if that solves this problem.
I'm going to close this issue since there's nothing actionable for us right now


smarthome_network_wakeonlan is failing to build on indigo armhf

http://build.ros.org:8080/job/Ibin_arm_uThf__smarthome_network_wakeonlan__ubuntu_trusty_armhf__binary/
It appears to be crashing qemu
12:24:46 Unzipping /tmp/binarydeb/ros-indigo-smarthome-network-wakeonlan-0.1.66/obj-arm-linux-gnueabihf/devel/share/gradle/wrapper/dists/gradle-2.7-bin/34pav52un904ef0995k04o7nr6/gradle-2.7-bin.zip to /tmp/binarydeb/ros-indigo-smarthome-network-wakeonlan-0.1.66/obj-arm-linux-gnueabihf/devel/share/gradle/wrapper/dists/gradle-2.7-bin/34pav52un904ef0995k04o7nr6
12:24:51 Set executable permissions for: /tmp/binarydeb/ros-indigo-smarthome-network-wakeonlan-0.1.66/obj-arm-linux-gnueabihf/devel/share/gradle/wrapper/dists/gradle-2.7-bin/34pav52un904ef0995k04o7nr6/gradle-2.7/bin/gradle
12:25:10 Unsupported ioctl: cmd=0x8933
12:25:10 Unsupported ioctl: cmd=0x8933
12:25:10 Unsupported ioctl: cmd=0x8933
12:25:10 Unsupported setsockopt level=41 optname=18
12:25:13 #
12:25:13 # A fatal error has been detected by the Java Runtime Environment:
12:25:13 #
12:25:13 [thread -867503008 also had an error]#
12:25:13 [thread -893852576 also had an error]Internal Error
12:25:13  (os_linux_zero.cpp:285), pid=279, tid=3402818656
12:25:13 #  fatal error: caught unhandled signal 4
12:25:13 #
12:25:13 # JRE version: OpenJDK Runtime Environment (7.0_101) (build 1.7.0_101-b00)
12:25:13 # Java VM: OpenJDK Zero VM (24.95-b01 interpreted mode linux-arm )
12:25:13 # Derivative: IcedTea 2.6.6
12:25:13 # Distribution: Ubuntu 14.04 LTS, package 7u101-2.6.6-0ubuntu<IP_ADDRESS>
12:25:13 # Failed to write core dump. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again
12:25:13 #
12:25:13 # An error report file with more information is saved as:
12:25:13 # /tmp/binarydeb/ros-indigo-smarthome-network-wakeonlan-0.1.66/hs_err_pid279.log
12:25:13 qemu: unhandled CPU exception 0x2 - aborting
12:25:13 R00=00000000 R01=00000081 R02=00000001 R03=ffff0fa0
12:25:13 R04=fffffffd R05=f5f60740 R06=f5f60728 R07=f6693d30
12:25:13 R08=f5f60700 R09=f667d000 R10=cf7bbbf8 R11=f6696324
12:25:13 R12=000000f0 R13=cf7bbbf0 R14=f659780d R15=f6772d7c
12:25:13 PSR=40000010 -Z-- A usr32
12:25:13 qemu: uncaught target signal 6 (Aborted) - core dumped
12:25:13 Aborted (core dumped)
12:25:13 make[4]: make[4]: Leaving directory `/tmp/binarydeb/ros-indigo-smarthome-network-wakeonlan-0.1.66/obj-arm-linux-gnueabihf'

This is known to happen when using git, but this appears to be different.

I have blacklisted it to avoid repeated failing builds. https://github.com/ros-infrastructure/ros_buildfarm_config/issues/52


Sync "Last Active" field with Snipe-It

See if we can fill in a "Last Active" date field in Snipe-It from JAMF.

This change has been completed in prod and seems to be working.

Updated mappings for mobile devices:
_snipeit_mac_os_version_20 = general os_version
_snipeit_last_active_30 = general last_inventory_update

@JustATechie Would you be able to help take a look at this with me whenever you have time? I'm seeing errors like this:
ERROR:root:Unable to update ID: 2924. Error "{'_snipeit_last_active_30': ['The  snipeit last active 30 is not a valid date.']}"

I think this is happening because jamf2snipe assumes everything except a few statically defined fields (like purchase date) are strings.
No rush on implementing this, but it would be nice to have for our reports.

Seems to be working for computers after updating jamf2snipe to 1.0.6
INFO:root:Processing entry 6 out of 278 - JAMFID: 33 - NAME: USS-DMP-2451
INFO:root:Sucessfully updated _snipeit_last_active_30 with: 2024-09-24 20:15:42

Still giving the same error with mobile devices.


Password BruteForce Error

[>] Wordlist    :> wlist.txt
[>] ProxyStatus :> [OFF]
[~] Brute ForceATTACK: Enabled [~]
[1] Trying Password[ {123456789} ]
[!] Error: a bytes-like object is required, not 'str'
[1] Trying Password[ {password} ]
[!] Error: a bytes-like object is required, not 'str'
[1] Trying Password[ {football} ]
[!] Error: a bytes-like object is required, not 'str'
[1] Trying Password[ {iloveyousomuch} ]
[!] Error: a bytes-like object is required, not 'str'
[1] Trying Password[ {fuckyou123} ]
[!] Error: a bytes-like object is required, not 'str'
[1] Trying Password[ {1234567} ]
[!] Error: a bytes-like object is required, not 'str'
[1] Trying Password[ {iloveyou} ]
[!] Error: a bytes-like object is required, not 'str'
[1] Trying Password[ {qwertyuiop} ]
[!] Error: a bytes-like object is required, not 'str'
[1] Trying Password[ {123456} ]
[!] Error: a bytes-like object is required, not 'str'
[1] Trying Password[ {password} ]
[!] Error: a bytes-like object is required, not 'str'
[1] Trying Password[ {12345678} ]
[!] Error: a bytes-like object is required, not 'str'
[1] Trying Password[ {qwerty} ]

HI, Please mention your environment specification.


Update perfview on download center

Using the one of download center which is from July I hit some failure loading symbols. Cloning and building the latest fixed the problem. @safern hit the same issue. It would be nice to update the one on download center.

I am also waiting for the latest version on the download center.

Just FYI, you can get binary of PerfView from
https://github.com/Microsoft/perfview/releases

PerfView binary releases are now delivered via GitHub releases.


Need to reload integration all the time

Version of the custom_component

Latest and kept up to date as updates appear :)
I use the newer vmoto app with the battery-powered ECU on a TC-Max.
Configuration

Add your logs here.

Describe the bug
This whole integration was working very well for me, but recently I find it constantly requires a reload to get certain parts to work.  It does seem that most data is still coming through, but the most notable issue is when I go to turn on the bike's power and the power toggles (along with the other toggles for notifications etc) are all greyed out.  This is fairly quickly repaired by just going to the integration page and choosing "Reload".  After about 20 seconds of waiting, the toggle comes back, I can turn on my bike, move it out of the way of my bins to bring them out for the bin lorry and I'm sorted.  But if I check even minutes later I can see the toggles have greyed out again.
I almost wonder if Vmoto have updated the app to only provide certain settings if the logged-in session checks in somehow.  Frequent polling would undoubtedly be a bad idea, but perhaps if we could stick some kind of retain time to keep the switch status up to date and check once an hour or so and have the command to send include whatever the check-in requirement is... I'm absolutely guessing here 😅
Debug log

Please advice what sort of logs I can provide and how :)
If there's also some way to volunteer live data logs to you to check in on, I'd be happy to provide that if having access to another device would assist in your efforts, though obviously it'd need to be done in some way that is not public :)

Hi @drakhart, is there anything I can do to assist with investigating this one? :)

Hi @apbarratt. I think this issue is related to #10: the response doesn't return a last warning time, then the integration sets that state as unknown and the new HA versions don't like that, so it starts failing.
I think I have found a fix, but I need to try it a bit more just to make sure. Will let you know the outcome asap.

Fair enough, I've disabled the last warning entity, will see how things go after another reload :)

This should have been fixed in beta 12. Please let me know if that worked for you.

There hasn't been any response for a long time, and I assume this has been already fixed as mentioned in my previous comment.


Look into current vercel pipeline integration

We have github actions that should pipe the data, but I believe vercel is still handling deployments itself.

should be ok for now as its working.


Board of Directors: Chair and Vice Chair should be listed first

Is it possible to list the Chair (James Butts) and Vice Chair (Eric Garcetti) first on the list of Board of Directors, followed by other members in alphabetical order?

We're adding a centralized way to order board members in the upgrade (#512). Can this wait until then?

@shrayshray I just merged and deployed this to the staging site: https://lametro-upgrade.datamade.us/board-members/. What do you think?

@hancush the chair and vice chair are first - awesome!! Is it possible to list the other members alphabetically by last name instead of first?

Sure, I can get to this next week. (Taking Monday/Tuesday off.) Have a good weekend!

Thanks, Hannah! Hope you have a relaxing long weekend.

Hi, @shrayshray. Made the requested change. It's now live on staging: https://lametro-upgrade.datamade.us/board-members/

@hancush perfecto - thank you!

 We're live: https://boardagendas.metro.net/board-members/


[v4.1.0] A dotted-key array searching method

#41  👈
dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @GoodM4ven and the rest of your teammates on  Graphite


Added unrefenced time tracking and enabled reviving data stores.

Updated options matrix to always run summaries and GC.
Added tracking unreferenced data store timestamps.
Enabled reviving objects.
Added config for inactive object timeout so that it data stores can get it. This is a hack and will be fixed later.

Feel free to merge at will. The paper trail and ability to discuss afterwards will be good enough


Support for torch 2.0

Is support for torch 2.0 on the roadmap anytime soon?

Hi @lminer, thanks for your interest in Nebullvm! We are going to add support for both PyTorch 2.0 and TensorFlow 2.12 in the next release ;)


Accordion: toggle/up/down methods acting strange

All relevant information is in this forum post on foundation.zurb.com.
I discovered this over a month ago and am not willing to re-familiarize myself with it to flesh out the description in this issue given the detail in that forum post, but short of it is that there's a problem wherein I had to force the attributes related to the expansion of a given panel to take on the values of an active panel. Otherwise the target panel would act as if it was active, but the accordion would not toggle. That was the workaround for what I perceived to be a bug.

The target it the needed data-tab-content.
See https://codepen.io/DanielRuf/pen/mddOWRo?editors=1010 and https://github.com/foundation/foundation-sites/blob/3bc6d728dc9f03ae7f6f608990922bb69299b62b/js/foundation.accordion.js#L172


docs: Fix links to 'Who uses library' section

Feature or Bugfix

Documentation

Detail

Fix links to 'Who uses library' section

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
Commit ID: 06ac9d21950f186a363904b60c4336f3cf9e67bf
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: 06ac9d21950f186a363904b60c4336f3cf9e67bf
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: f8e5e5101406774f9684e12d4da457453592d2a6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Overlap with clickable tags

I'm using the AnKingMed deck, and your cool ND buttons are displayed on top of the tags. Is there a way to fix this that doesn't involve changing the cards styling?

Ah unfortunately no but I think Anking has made it easy to shift it up. I think at the top of the styling there's a bit of code you can uncomment (or something like that - I haven't personally used it)

It's mentioned in the description of his youtube vid: https://youtu.be/5XAq0KpU3Jc
Let me know if you can get it working

Thank you! Fixed.


Generated ViewTable classes have duplicated property fields.

DBFlow Version: 4.0.4
Issue Kind (Bug, Question, Feature): Bug
Description:
I have 3 views. At v 3.1.1 they generate fine. But now each generated class has every property field duplicated, so they don't compile.
I created a bare-bones project that reproduces the issue.
TestViews.zip

I'm not  using kotlin or any of the other bells/whistles.
Just:
// dbflow
annotationProcessor 'com.github.Raizlabs.DBFlow:dbflow-processor:4.0.4'
compile 'com.github.Raizlabs.DBFlow:dbflow-core:4.0.4'
compile 'com.github.Raizlabs.DBFlow:dbflow:4.0.4'

We have the same problem (since 4.0 beta7 to 4.0.4).

fixed for 4.0.5


When Activity's property "configChanges"  value has "layoutDirection" get the error

Hi, My activity's property "android:configChanges" contain "layoutDirection". When I parse xml get a error :
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Message("unknown variant `layoutDirection`, expected one of `density`, `fontScale`, `keyboard`, `keyboardHidden`, `layoutDiraction`, `locale`, `mcc`, `mnc`, `navigation`, `orientation`, `screenLayout`, `screenSize`, `smallestScreenSize`, `touchscreen`, `uiMode`")'

thank you!

@ammmmmmmmmmmmm Hi, sorry for the delayed response. If I understood correctly after searching, layoutDirection isn't variant for android:configChanges. But you can customize the layoutDirection directly in each layout or in styles.
Example:
in app/res/values/styles:
<style name"YourMainThemeName" parent="Parent Theme Of Your Choice">
    <item name="android:layoutDirection">rtl</item>
    <item name="windowActionBar">false</item>
</style>

and in app/manifests/AndroidManifest.xml:
<application
        android:supportsRtl="true"
        android:theme="@style/YourMainThemeName">
</application>

Useful links:
https://developer.android.com/reference/android/view/View#attr_android:layoutDirection
https://stackoverflow.com/questions/31904627/android-change-entire-app-layout-directions-programmatically

Thank you for your reply!  I found the link below, android:configChanges has a layoutDirection  value
Added in API level 17.
https://developer.android.com/guide/topics/manifest/activity-element#config

@ammmmmmmmmmmmm Sorry and thank you for the issue, this was our bug. It is fixed and closed. You can use commit message or wait till we check all the code for similar problems and publish a new release. It will take no more than three days.


[MLIR] Add involution based folding to TF

The involution property holds in a few of the TF ops so instead of adding redundant folding operations to every single one of them, we can write one optimization pass, and simply label the ops we want to support with the involution tag.

@andyly @smit-hinsu

@ahmedsabie Can you please resolve conflicts? Thanks!

@ahmedsabie Any update on this PR? Please. Thanks!


is application CC:       true
                                    should hide root values: false
2023-01-23T17:54:31.312Z DRIVER « [Node 022] [REQ] [ApplicationCommand]
                                  └─[MultilevelSensorCCReport]
                                      type:  Humidity
                                      scale: Percentage value
                                      value: 48
2023-01-23T17:54:31.322Z SERIAL « 0x010c000400160631050b220053a9                                      (14 bytes)
2023-01-23T17:54:31.323Z SERIAL » [ACK]                                                                   (0x06)
2023-01-23T17:54:31.325Z CNTRLR   [Node 022] [translateValueEvent: metadata updated]
                                    commandClass: Multilevel Sensor
                                    endpoint:     0
                                    property:     Dew point
                                    propertyKey:  undefined
                                    internal:     false
                                    secret:       false
                                    event source: undefined
2023-01-23T17:54:31.325Z CNTRLR   [Node 022] [Multilevel Sensor] Dew point: metadata updated        [Endpoint 0]
2023-01-23T17:54:31.325Z CNTRLR   [Node 022] [translateValueEvent: metadata updated]
                                    is root endpoint:        true
                                    is application CC:       true
                                    should hide root values: false
2023-01-23T17:54:31.328Z CNTRLR   [Node 022] [translateValueEvent: value updated]
                                    commandClass: Multilevel Sensor
                                    endpoint:     0
                                    property:     Dew point
                                    propertyKey:  undefined
                                    internal:     false
                                    secret:       false
                                    event source: undefined
2023-01-23T17:54:31.329Z CNTRLR   [Node 022] [~] [Multilevel Sensor] Dew point: 8.3 => 8.3          [Endpoint 0]
2023-01-23T17:54:31.329Z CNTRLR   [Node 022] [translateValueEvent: value updated]
                                    is root endpoint:        true
                                    is application CC:       true
                                    should hide root values: false
2023-01-23T17:54:31.332Z DRIVER « [Node 022] [REQ] [ApplicationCommand]
                                  └─[MultilevelSensorCCReport]
                                      type:  Dew point
                                      scale: Celsius
                                      value: 8.3
2023-01-23T17:55:05.800Z SERIAL « 0x0110000400100a600d08003105012200189b                              (18 bytes)
2023-01-23T17:55:05.804Z SERIAL » [ACK]                                                                   (0x06)
2023-01-23T17:55:05.807Z CNTRLR   [Node 016] [translateValueEvent: metadata updated]
                                    commandClass: Multilevel Sensor
                                    endpoint:     8
                                    property:     Air temperature
                                    propertyKey:  undefined
                                    internal:     false
                                    secret:       false
                                    event source: undefined
2023-01-23T17:55:05.808Z CNTRLR   [Node 016] [Multilevel Sensor] Air temperature: metadata updated  [Endpoint 8]
2023-01-23T17:55:05.808Z CNTRLR   [Node 016] [translateValueEvent: metadata updated]
                                    is root endpoint:        false
                                    is application CC:       true
                                    should hide root values: true
2023-01-23T17:55:05.815Z CNTRLR   [Node 016] [translateValueEvent: value updated]
                                    commandClass: Multilevel Sensor
                                    endpoint:     8
                                    property:     Air temperature
                                    propertyKey:  undefined
                                    internal:     false
                                    secret:       false
                                    event source: undefined
2023-01-23T17:55:05.815Z CNTRLR   [Node 016] [~] [Multilevel Sensor] Air temperature: 2.2 => 2.4    [Endpoint 8]
2023-01-23T17:55:05.815Z CNTRLR   [Node 016] [translateValueEvent: value updated]
                                    is root endpoint:        false
                                    is application CC:       true
                                    should hide root values: true
2023-01-23T17:55:05.818Z DRIVER « [Node 016] [REQ] [ApplicationCommand]
                                  └─[MultiChannelCCCommandEncapsulation]
                                    │ source:      8
                                    │ destination: 0
                                    └─[MultilevelSensorCCReport]
                                        type:  Air temperature
                                        scale: Celsius
                                        value: 2.4

A second log, maybe more complete. Looks like enabling or disabling the driver log makes the multilevel sensor disappear. Hope the disappear and reappear are catched in the logs.
The failing node is number 013.
zwavejs_2023-01-23.log (2).txt

Although you mentioned that you paired the device with sensor attached, this smells like the device does not actually report in the interview that it has this sensor.
Please re-interview the device and post a log of that. Ideally delete the logfile beforehand, so there's not so much unnecessary stuff.

After updating with release including #5424 , the issue initially persists, with temperature sensor still disappearing when the ZWaveJS was restarted. So I finally had time to exclude the device from the network, made a hard reset of the device, and included it again in ZWaveJS-UI. But after inclusion, the temperature sensor was missing :flushed:
I retried several times without success, the multilevel sensor category didn't appear after inclusion, even after several manual wake-ups or re-interviews. I had the setting to set the temperature change threshold, but no temperature displayed.
So I gave up and left the device included as this, without the temperature sensor ; and after a little moment, the multilevel sensor category appeared, with the temperature sensor displayed inside :neutral_face:
I then tried to restart ZWaveJS, and ... temperature sensor remained available :star_struck:
So I confirm the fix is working fine, but requires to exclude and include again the device to work properly, and the temperature will appear after the next first temperature sampling.

That shouldn't be necessary, unless the device was actually doing something strange.

That shouldn't be necessary, unless the device was actually doing something strange.

It's possible the device connection was malfunctioning. But it finally works as expected now. Thanks


How do I get the checkpoints when applying it at linear chain feedforward models?

As title. The program shows the peak memory usage and cut-offs, while I need help/hint as the title.

Hi sorry for the late reply. You can get the checkpointed tensors at https://github.com/jianweif/OptimalGradCheckpointing/blob/main/graph.py#L876
Instead of returning tensor_dict[target] which is the output tensor, you can return the entire tensor_dict where each value will be a checkpointed tensor in the computation graph.


Explode entities if at least 40% of their size overtake on an adjacent exploded cell

Limit might be changed when models will be set.
Resolves: #136

Codecov Report

Merging #138 (676ca4a) into master (6ccea8b) will increase coverage by 0.31%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
+ Coverage   17.36%   17.68%   +0.31%
==========================================
  Files         110      113       +3
  Lines        1589     1623      +34
  Branches      589      601      +12
==========================================
+ Hits          276      287      +11
- Misses       1182     1201      +19
- Partials      131      135       +4

Impacted Files
Coverage Δ

src/game/components/Bomb.cpp
0.00% <0.00%> (ø)

src/game/components/Bomb.hpp
0.00% <ø> (ø)

src/game/systems/Collision.cpp
0.00% <0.00%> (ø)

src/game/systems/Collision.hpp
0.00% <ø> (ø)

src/raylib/shapes/Rectangle.cpp
0.00% <0.00%> (ø)

src/raylib/shapes/Rectangle.hpp
0.00% <0.00%> (ø)

src/ecs/world/World.hpp
68.42% <0.00%> (ø)

src/raylib/shapes/AShape.hpp
0.00% <0.00%> (ø)

src/ecs/system/SystemTag.hpp
25.00% <0.00%> (ø)

src/ecs/system/SystemTag.cpp
66.66% <0.00%> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ccea8b...676ca4a. Read the comment docs.


77

no more text on stdout/stderr, wraps internal message in json. There is a follow-up issue though on how to handle/log failed TLS connection attempts. They only show up as internal traces right now.


Sync notebooks.

Last piper revision: 595501423

The lint failure is from using 1st person in some quoted prompt text, so false positive.


[Compliance] Display licenses in app

Potentially using https://github.com/google/play-services-plugins/tree/master/oss-licenses-plugin

I'm on it!

Do we want to show the licenses trigger as a small link at the bottom of the menu, above the build version info?

We can also put it in the settings screen.

Please work with @rawbzz to determine the proper placement and UX. Thanks!

Android designs


Server Crashing with Origin

Information

Minecraft Version: 1.16.5
Fabric API Version: 0.30.3+1.16
OS: Windows

Other installed mods:

All of Fabric 3 (ver 2.6.10) Modlist
Origins, Origin: Classes, Haema, extraorigins, moborigins, Pehkui
Gunpowder, Gunpowder tp, sleepvote and utilities.

Describe the issue
Server crashes on startup
Crash/Error logs
https://pastebin.com/a37yAdSF
To Reproduce
Opening the server
Expected behavior
Server starts
Additional context
Using the All of Fabric 3 (2.6.10) modpack with origin mods on a self host server.

Needs fixing by Haema's devs; They've been notified, but I'll leave the issue open for now.


Suggestion: style channel links on comments section

Would be nice IMO to see some styling on channel links in the comments section of a publish, so that users can easily get they can "get to know" who made the comment
Currently, there is no styling at all, unless the mouse is over the channel name

Sounds good, I'll take a look at that when I do some frontend work here in a bit


Not able to login into OpenNess Controller GUI

Unable to login into OpenNess Controller UI

Can you check this closed issue #16 - it seems similar.

@amr-mokhtar  I went through the #16 but its not resolved

hi @illuri-537,
Is this problem still happening or is it resolved?


Ensure that cmctl install/uninstall sequence works

See the discussions on https://github.com/cert-manager/cert-manager/pull/4897 for context
Currently cmctl x install errors out if it finds cert-manager CRDs already installed in the cluster.
As we've chosen to not delete CRDs when user runs cmctl x uninstall in #4897, this now means that it is not possible to run cmctl x install, cmctl x uninstall and then cmctl x install again.
This is not a good user experience and should be fixed.
There are a few ways how it could be fixed:

don't error out if CRDs already installed
delete CRDs on uninstall

Expected behaviour:

I can run cmctl x install after having run cmctl x uninstall

Anything else we need to know?:

As part of this work, it might also be good to consider some kind of upgrade strategy, also for CRDs and consider what would be the (recommended) usage scenarios of install/uninstall functionality. Perhaps it would be good to gather some user feedback for this, I've noticed that for example istioctl now outputs a link to a feedback form

There are examples of how this problem is solved in other CLIs such as osm

Environment details::

Kubernetes version:
Cloud-provider/provisioner:
cert-manager version:
Install method: e.g. helm/static manifests

/kind bug

Thanks for creating this issue.
One possible solution I can see is:

add an opt-in flag to uninstall that deletes CRDs, which can be run even after a regular cmctl x uninstall if an operator forgot to add it

What do you think @irbekrm ?

add an opt-in flag to uninstall that deletes CRDs, which can be run even after a regular cmctl x uninstall if an operator forgot to add it

It is either this, or not erroring out if CRDs already exist. I am not sure what is the difference between the work required for the two implementations.
If the CRDs could be optionally uninstalled via a flag, then it probably would also make sense to allow for them to be installed optionally via a flag (same as with Helm release) as else there is no real use for cmctl x uninstall without the flag. (I am not necessary against your idea, but feel like perhaps we could design the sequence more from usability perspective)

I think your suggestion solves the problem described in the issue more directly.
Agree to make install proceed even if CRDs exist?

Agree to make install proceed even if CRDs exist?

To me this makes sense 👍🏼
(cc-ing @inteon as he wrote the original install command and may have some extra context)

Agree to make install proceed even if CRDs exist?

To me this makes sense 👍🏼
(cc-ing @inteon as he wrote the original install command and may have some extra context)

The CRD check is currently also used to prevent two cert-manager installs co-existing.
So a warning/ confirmation might be required to prevent problems in case a cert-manager deployment already exists.

In the case where CRDs exist and we want to make sure the user reads the warning, should we only proceed with a --yes flag or similar?

@irbekrm During the GSoC project, I also pondered on some of the edge cases for these install/ uninstall tools. For example, what if the CRDs are outdated, do we still continue with the install?


Type casting between raw input and mleap-serialized models

I trained a pipeline in Spark and successfully serialized it through MLeap. When I tried to use the serialized MLeap pipeline at runtime, some strange type casting error occurs. Then I checked the raw input schema and MLeap-pipeline schema, found some discrepancy:
`
Input schema of raw input data:
root
|-- C1: string (nullable = true)
|-- C2: string (nullable = true)
|-- C3: double (nullable = true)
|-- C4: float (nullable = true)
|-- C5: string (nullable = true)
|-- C6: float (nullable = true)
Input schema of mleap-pipeline
root
|-- C1: scalar(base=string,nullable=true)
|-- C2: scalar(base=string,nullable=true)
|-- C3: scalar(base=double,nullable=true)
|-- C4: scalar(base=double,nullable=true)
|-- C5: scalar(base=string,nullable=true)
|-- C6: scalar(base=double,nullable=true)
`
Two columns of raw input were supposed to be FLOAT type (in Spark dataframe), however, when I printed the serialized MLeap pipeline's input schema, the corresponding two columns were DOUBLE type. Does anybody know why the implicit type casting happened?

Hey @FredYao which transformer is using these  C4 & C6 columns?

@ancasarb, only VectorAssembler was called to assemble all C1 to C6 columns. There was no other particular transformer applied on C4 & C6.

What you're actually seeing is the schema of the pipeline, in your case just the VectorAssembler, which in this case its input schema is defined as a series of double inputs https://github.com/combust/mleap/blob/d276c1c800277a1edcf30dda6e8559c7413b21f8/mleap-core/src/main/scala/ml/combust/mleap/core/feature/VectorAssemblerModel.scala#L93. Each of the models has an input/outputs schema.
If there's any casting required, MLeap handles it here https://github.com/combust/mleap/blob/15e8dd3bfa47c957f7773eb020f2f776dbd1ddad/mleap-core/src/main/scala/ml/combust/mleap/core/types/Casting.scala.
Hope this helps!

Closing this, please feel free to re-open if you still have additional questions. Thank you!


private channel in describegraph

Background
channels that are private to the node are shown in describegraph .
can we add the private flag to describegraph so they are easier to filter out on visualizers etc?

Can I work on this, please?

What would be the best way to start on this issue?

Take a look at the DescribeGraph method in the rpcserver: https://github.com/lightningnetwork/lnd/blob/86ad6d318e0ba4d3e22e12baec1f37bc1471d44d/rpcserver.go#L2482
A private edge won't have an attached AuthProof, which can be used to filter out private channels: https://github.com/lightningnetwork/lnd/blob/86ad6d318e0ba4d3e22e12baec1f37bc1471d44d/channeldb/graph.go#L1251:6


maintainers/maintainers-list.nix: add mvisonneau

Motivation for this change
Adding myself as part of the maintainers list
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Welcome! If you wish to add yourself as a maintainer of some existing packages, or add an new a new package to Nixpkgs, can you also do that in this pull request?

Hey @bobby285271, thanks! Sounds good, I added myself for one package on which I am the author.


[PYTORCH]Matmul fix for batch_matmul

Support batched matrix and broadcast matrix matmul
Its another issue when running bert model issue
@masahi please help to review this PR. Thanks.

Thanks @siju-samuel


#[UIC-1534]: Subscriber Layer refactor

UIC-1534
CATEGORY
Choose one

[x] Bug Fix
[ ] Enhancement (new features, refinement)
[ ] Refactor
[ ] Add tests
[ ] Build / Development Environment
[ ] Documentation

SUMMARY
delete any column in subscriber ui except at least one column & other subscriber layer issues
Fixed Issues:
https://guavus-jira.atlassian.net/browse/UIC-1691
https://guavus-jira.atlassian.net/browse/UIC-1296
https://guavus-jira.atlassian.net/browse/UIC-1662
https://guavus-jira.atlassian.net/browse/UIC-1710
https://guavus-jira.atlassian.net/browse/UIC-1534
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

REVIEWERS
@ankursinghal2005

@rasmi-ranjan-guavus Can we reset other changes not related to this bug fix?

Can we have bugs/user story to capture all the points added by @jitendra-kumawat


How to override graph attributes?

When I  run dot using the Graphviz package, I can do the following:
cat myFile.dot | dot -Grankdir=TB

Is there a way that I can override graph attributes using this package?  I would prefer to avoid having to edit the files.
Thanks!

Currently no. This was originally to avoid having to pass a JavaScript array or object to a compiled C function, but it should be possible to do this using Emscripten's APIs for interacting with C code.


Use Go 1.21 and update dependencies

To make sure Gitea's next release's lifecycle could have active Golang support.
And min/max are builtin now.

Does it mean Gitea 1.21 drops support for Go 1.20?

Yes, effectively.
That's also why I'm unsure yet if I should approve or not.

Let's hold off until Gitea 1.21 is out. We tend to keep the supported versions of golang supported by Gitea, and go1.20 is still supported.

I do not think it needs to be "hold"
We have done so many times, and see the discussions:

#24859
#19918

I do not think there would be any problem.

It's about whether we want to let Gitea compile on Go 1.20 or not.

To improve forwards compatibility, Go 1.21 now reads the go line in a go.work or go.mod file as a strict minimum requirement: go 1.21.0 means that the workspace or module cannot be used with Go 1.20 or with Go 1.21rc1.

It's about whether we want to let Gitea compile on Go 1.20 or not.

My answer is "not". The code also uses Golang 1.21 new features like min/max

Windows 7 support ended already, and windows server 2012 won't be supported in Oct. I don't feel that's an issue.
Since gitea is not a library, I feel bumping go is fine, and it will make maintaining easier in the future.

Windows 7 support ended already, and windows server 2012 won't be supported in Oct. I don't feel that's an issue.

Agree, and a few months later, Golang 1.20 will reach EOL. So the ending of Windows 7 support doesn't make much difference.


Firebase Android Codelab step 10

After filling Services with logic...

Add service declarations for the MyFirebaseListenerService and the MyInstanceIdListenerService. Add these declarations as children of the application element.

MyInstanceIdListenerService should be replaced with MyFirebaseInstanceIdService

This issue was moved to firebase/friendlychat-android#12