add PKCS11 support

Adds PKCS11 support for the P256 curve. It could probably be generalized for curve 25519 as well, but this is what our HSMs support, and therefore what I could easily test.
I've tested very thoroughly against the difficult-to-obtain Microchip TA100, and did a quick verification with a Yubikey 5C.
Here's some quick examples of how this change can be exercised on a TA100. I'll follow up with Yubikey instructions when time permits:
This change requires building with CGO, so here's the exact invocation we used (adjust as needed for your target architecture of course):
CC=aarch64-linux-gnu-gcc CGO_ENABLED=1 GOARCH=arm64 go build -buildvcs=false -ldflags="${LDFLAGS}" -o nebula.arm64.${COMMIT_HASH} ./cmd/nebula
CC=aarch64-linux-gnu-gcc CGO_ENABLED=1 GOARCH=arm64 go build -buildvcs=false -ldflags="${LDFLAGS}" -o nebula-cert.arm64.${COMMIT_HASH} ./cmd/nebula-cert

Unfortunately static linking with musl doesn't work, because musl doesn't implement dlopen for statically-linked binaries. :disappointed:
./nebula-cert keygen -out-pub test.pem -pkcs11 'pkcs11:slot-id=0;object=device;token=00ABC;type=private?module-path=/tmp/libcryptoauth.so'

A config file's pki section would look like this:
pki:
  ca: /path/to/ca.pem
  cert: /path/to/cert.pem
  key: 'pkcs11:slot-id=0;object=device;token=00ABC;type=private?module-path=/tmp/libcryptoauth.so'

Please let me know what you think! I'm very open to making adjustments to make this fit in better with the existing code.

Related: https://github.com/slackhq/nebula/issues/328

How tricky would it be to add support for ca and sign?

@numinit not that bad for sign, but I (perhaps incorrectly?) assume that most folks who want a hardware-backed key for their CA are operating Nebula "at scale", and therefore also want semi-custom signing logic, and so therefore they don't want to use the CLI to sign their client certs.
For ca, I could add code to generate a CA cert from the key pointed to by a pkcs11 URL, but I don't think it'd be reasonable to add key generation support, since most HSMs (at least the ones I've used) really push you to use their own tooling for creating/managing keys.

I think that's basically all I'd expect; just symmetry between the sign, CA and keygen commands :-)

@JackDoanRivian this ought to be a good start :-)
https://github.com/numinit/nebula/commit/fbdb4b8491cf12263c0a45c70e96ea637e0211f5

@numinit this looks great! Is it okay with you if I cherrypick this? You'll have to sign the Salesforce CLA for this to land once I do.

Updated so the test suite passes.
https://github.com/numinit/nebula/tree/pkcs11-v1.9.3

@JackDoanRivian Go for it, CLA signed. I've been integration testing it and it works great: https://github.com/numinit/nixpkcs

I made minor fixes to the existing tests, but probably need to write some more CLI tests.
Regardless, a smoketest of the whole process with multiple Nebula nodes using libsoftokn works great.
https://github.com/numinit/nixpkcs/blob/master/test.nix#L221

Running into some trouble with tpm2-pkcs11 using softhsm under QEMU. I'll debug a bit.

Error: error while getting public key with PKCS#11: asn1: syntax error: sequence truncated

One more cherry-pick: https://github.com/numinit/nebula/commit/98dbced19b74f86b4bf4da4c64fe559c40818c07

@JackDoanRivian Ack, I missed that comment. Good example that runs in the NixOS test suite is here:
https://github.com/numinit/nixpkcs/blob/master/nixos/tests/nebula.nix#L41
Config specializations (I test this with both nssdb and TPM2) are here:
https://github.com/numinit/nixpkcs/blob/master/flake.nix#L51
Ultimately nixpkcs creates all those declaratively, the imperative commands and environment are buried in that source, though. :-)

Finally got some time to test this on macOS with an old school YubiKey 4 (USB A!) and I am able to get it working. A couple notes:

IIUC, P256 curve is required
The Makefile currently doesn't build for anything but Linux. I will include a patch at the end of this comment that worked for me. This patch removes it as a distro-specific build target though, and I think that may be important for your use case?

And here's how I configured it:

brew install opensc yubico-piv-tool
ykman piv reset

WARNING! This will delete all stored PIV data and restore factory settings. Proceed? [y/N]: y
Resetting PIV data...
Reset complete. All PIV data has been cleared from the YubiKey.
Your YubiKey now has the default PIN, PUK and Management Key:
	PIN:	123456
	PUK:	12345678
	Management Key:<PHONE_NUMBER>06070801020304050607080102030405060708

ykman piv keys generate --algorithm ECCP256 9a pubkey.pem

Enter a management key [blank to use default key]:
/opt/homebrew/Cellar/ykman/5.5.1/libexec/lib/python3.12/site-packages/yubikit/piv.py:160: CryptographyDeprecationWarning: TripleDES has been moved to cryptography.hazmat.decrepit.ciphers.algorithms.TripleDES and will be removed from this module in 48.0.0.
  return algorithms.TripleDES(management_key)
Private key generated in slot 9A (AUTHENTICATION), public key written to pubkey.pem.

pkcs11-tool --module /opt/homebrew/lib/libykcs11.dylib --list-slots

Available slots:
Slot 0 (0x0): Yubico Yubikey 4 OTP+U2F+CCID
  token label        : YubiKey PIV #5599240
  token manufacturer : Yubico (www.yubico.com)
  token model        : YubiKey YK4
  token flags        : login required, rng, token initialized, PIN initialized
  hardware version   : 1.0
  firmware version   : 4.34
  serial num         : 5599240
  pin min/max        : 6/64

make bin-pkcs11 (This required a code change to Makefile!)

go build -tags cgo,pkcs11 -trimpath -ldflags "-X main.Build=1.9.3-upstream-master-1-g40cfd00-dirty" -o ./nebula "./cmd/nebula"
go build -tags cgo,pkcs11 -trimpath -ldflags "-X main.Build=1.9.3-upstream-master-1-g40cfd00-dirty" -o ./nebula-cert ./cmd/nebula-cert

Build the URL using url-encoded values from step 4 by hand: pkcs11:model=YubiKey%20YK4;manufacturer=Yubico%20%28www.yubico.com%29;serial=5599240;token=YubiKey%20PIV%20%235599240;id=%01?module-path=/opt/homebrew/lib/libykcs11.dylib&pin-value=123456
./nebula-cert keygen -curve P256 -pkcs11 "pkcs11:model=YubiKey%20YK4;manufacturer=Yubico%20%28www.yubico.com%29;serial=5599240;token=YubiKey%20PIV%20%235599240;id=%01?module-path=/opt/homebrew/lib/libykcs11.dylib&pin-value=123456" -out-pub pkcs11.pub
CA must use the P256 curve: nebula-cert ca -ips '<IP_ADDRESS>/24' -name 'Test CA for PKCS11' -curve P256
Sign the cert: nebula-cert sign -in-pub pkcs11.pub -ip '<IP_ADDRESS>/24' -name pkcs11
Fill out the pki section of the config:

pki:
 ca: /Users/jmaguire/src/nebula/ca.crt
 cert: /Users/jmaguire/src/nebula/pkcs11.crt
 key: pkcs11:model=YubiKey%20YK4;manufacturer=Yubico%20%28www.yubico.com%29;serial=5599240;token=YubiKey%20PIV%20%235599240;id=%01?module-path=/opt/homebrew/lib/libykcs11.dylib&pin-value=123456

Here's how I patched the Makefile:
diff --git a/Makefile b/Makefile
index 1b75dd5..bba5a4c 100644
--- a/Makefile
+++ b/Makefile
@@ -117,8 +117,9 @@ bin-freebsd-arm64: build/freebsd-arm64/nebula build/freebsd-arm64/nebula-cert
 bin-boringcrypto: build/linux-$(shell go env GOARCH)-boringcrypto/nebula build/linux-$(shell go env GOARCH)-boringcrypto/nebula-cert
        mv $? .

-bin-pkcs11: build/linux-$(shell go env GOARCH)-pkcs11/nebula build/linux-$(shell go env GOARCH)-pkcs11/nebula-cert
-       mv $? .
+bin-pkcs11: BUILD_ARGS += -tags pkcs11
+bin-pkcs11: CGO_ENABLED = 1
+bin-pkcs11: bin

 bin:
        go build $(BUILD_ARGS) -ldflags "$(LDFLAGS)" -o ./nebula${NEBULA_CMD_SUFFIX} ${NEBULA_CMD_PATH}


Can't import NetworkConnection

getting error NetworkConnection is not available

Can you provide a snippet of your code and the traceback?


Allow server process to start without detaching

Add a --no-detach option to --start-server and --restart-server. This makes it easy to run the RuboCop server process from within Docker, where detaching the process causes the container to exit.
Fixes #11188

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@f1sherman I see that a bunch of CI jobs are currently failing.

@bbatsov sorry about that! CI is fixed now. I was a little confused about the below offense since I didn't change that file, so I fixed that one in a separate commit.
lib/rubocop/cop/style/redundant_string_escape.rb:61:42: C: [Corrected] Performance/RedundantStringChars: Use [-1] instead of chars.last.
          format(MSG, char: range.source.chars.last)
                                         ^^^^^^^^^^

@bbatsov sorry about that! CI is fixed now. I was a little confused about the below offense since I didn't change that file, so I fixed that one in a separate commit.

No need for that the separate commit because this offense has already been resolved on the master branch:
https://github.com/rubocop/rubocop/commit/63e8377ea04cd8aec2dd6631a1cbafa29a33315e
Can you rebase with the latest master branch?

I wonder whether the term "daemon" is appropriate as I remember the conversation below.
https://github.com/rubocop/rubocop/pull/10706#issuecomment-1150686234

Can you rebase with the latest master branch?

Done!

 Would --no-background be preferable?

The code uses demonize -- at least you spelled it correctly 😂

Thank you @f1sherman. Another use case for this: https://github.com/DarthSim/overmind/issues/143

@bbatsov @koic Looks like CI is passing now.

I'm fully open to suggestions! Would --no-background be preferable?

I think the most common name for such an option is usually "--nodetach" or "-no-detach".

(it seems that even Docker favours this terminology)

@bbatsov thanks for the feedback, we should be all set once CI finishes 🤞


Add request logging

Output default request logs

I am willing to help here but I need guidance on exactly where this should be put.

That is great news @wilsonkasey.
I have not looked in to it too much at the moment, but I imagine there will be logging middleware for the default go http handler available. As an example it looks like the gorilla library has a logging middleware for their router (not suggesting you use this, just as an example).
The http.handler is set up in https://github.com/impactasaurus/server/blob/master/cmd/main.go.


chore: bdd-spring-1592815867 to 0.0.1

chore: Promote bdd-spring-1592815867 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Fail to find the image element in a DICOM file with private Sequence/SIEMENS tags

I have a DICOM file that is generated by SIEMENS with many private elements that the parser fails to read/find the image element.
The file is tested on multiple other desktop parsers (DICOM Editors, MicroDicom, fo-dicom...) and it is being read successfully and the image renders without issues.

Tracked the issue and it is caused by the parser finding a private sequence element (in an implicit VR DS) and trying to read and parse the elements inside it.
However the sequence is not following the DICOM standards (it is private after all) causing the parser to calculate the wrong length and skipping over the rest of the file.
The solution would be for the DICOM parser to ignore trying to parse the private implicit VR sequence (which is the behavior of all the other libraries) and skip it. The reason the library thinks it should read it because it has a sequence detection logic:
https://github.com/cornerstonejs/dicomParser/blob/master/src/readDicomElementImplicit.js#L15-L25
const isSequence = (element, byteStream, vrCallback) => {
  // if a data dictionary callback was provided, use that to verify that the element is a sequence.
  if (typeof vrCallback !== 'undefined') {
    return (vrCallback(element.tag) === 'SQ');
  }

  if ((byteStream.position + 4) <= byteStream.byteArray.length) {
    const nextTag = readTag(byteStream);

    byteStream.seek(-4);

    // Item start tag (fffe,e000) or sequence delimiter (i.e. end of sequence) tag (0fffe,e0dd)
    // These are the tags that could potentially be found directly after a sequence start tag (the delimiter
    // is found in the case of an empty sequence). This is not 100% safe because a non-sequence item
    // could have data that has these bytes, but this is how to do it without a data dictionary.
    return (nextTag === 'xfffee000') || (nextTag === 'xfffee0dd');
  }

The problem with this PR is that the DICOM is nonstandard, not that we should never read private tags. The DICOM standard even says that private tags should follow the normal DICOM element format. If you need this, I'd recommend forking this repo and adding it in your fork.

thanks for the feedback @yagni
I would agree with you except that for this case, we are talking about an implicit VR for a private element that technically the toolkit should have no idea how to read it other than as binary.
It is only because the code implement a hack to detect sequences -since it doesn't depend on/use a data dictionary- that it was able to figure out that this is a sequence element. The code even has this comment in the method to address similar cases:
     //This is not 100% safe because a non-sequence item
    // could have data that has these bytes, but this is how to do it without a data dictionary.

Finally, all the viewer/toolkits I tested with produce the same behavior. It reads the implicit VR sequence element as binary (because it doesn't even know it is a sequence).
So back to your point, yes private elements should follow the DICOM standard, for this case, as far as the toolkit is concerned, this is an element with binary data.

I'm assuming that the private sequence element has an explicit length; otherwise the other parsers wouldn't be able to properly skip over it. If that's true, you should be able get the same effect without a PR by passing a vrCallback that returns 'OB' when passed your element's tag.

@yagni do you have a use case than needs to read implicit VR private sequence where this change would break things for you?
The behavior in this PR aligns with the DICOM standard interpretation and with all the other viewers/toolkits so it should be the "general" solution and a fix for a "bug".
The callback option might be used for someone who wants to identify and read the private tag not the other way around.
Finally, if for any reason we need to preserve the old functionality then it could be done through adding a configuration option when initializing the parser. However, I am not sure this is needed at this point.

This actually wouldn't affect my use of dicomParser at all; I'm just concerned about nonstandard behavior creeping into this library. dicomParser has historically been used to parse DICOM standard-compliant files. We all know there are plenty of deviations from the standard in the wild, but the creators of this library have pushed users to handle those things within their own application code, not as PRs here. For example, in my own work I have a layer where I preprocess some nonconformities before passing the data to dicomParser.
My main problem is that I don't see anything in the DICOM standard about treating private elements as binary; in fact, everything I see mentions private data elements should be as readable as standard data elements. Admittedly, the standard is so big that I could have easily missed it--can you point me to the section you're referring to?
Either way, I don't have the ability approve or reject PRs so a maintainer is going to have to weigh in on which way they'd like to go.

@yagni with all due respect, I would encourage you to research this yourself before having a strong opinion about it. You seem to be confused as in this case, the private element creator can encode their element in anyway they like if the VR is unknown. Just because the DICOM parser thinks this is a sequence it doesn't mean it is.

Apologies, I stand corrected. I see it's mentioned in section 6.2.2 of Part 5 of the standard, where it talks about the UN VR. I didn't realize that private tags were assumed to be UN when implicitly encoded, but that makes sense as there's no way to know an implicit element's VR without a dictionary (i.e. vrCallback here).
That being said, it may be better to skip the sequence peek within isSequence if the element is private rather than the entire isSequence function. That way, if the user wants to parse their private elements they can provide a vrCallback that returns the VRs for the ones they want to read.

I believe the standards compliant behavior for private elements with known lengths is to skip over the value and not parse it.  The current library does not do this - it attempts to parse it which is causing this issue.  I am OK with making this change as it is inline with the design intent for the library to be strictly standards compliant.  It is a change in behavior that some people may depend up thought so it will be need to be done as part of a major version release.

@Zaid-Safadi Did your commit on the 29th resolve this issue? I'm trying to trace a related issue in the OHIF viewer.


How to get a 3d object from a new video?

Hello, thank you for the great work. I was wondering if it was possible with the current implementation to pass as input 2/3 videos from a new scene and get a 3d animation file that could be rendered using Blender for example?

Sorry, the current implementation does not yet support this feature, but welcome to PR.


WIP: Cleanup get_messages commit from zulip/zulip#12728

This pull request implements part of zulip/zulip#12728. Unfortunately, I've not had time to continue this work, so only putting this PR up so that the (little) progress made is publicly available, at request of @timabbott.
Testing Plan:
N/A
GIFs or Screenshots:
N/A

I did some cleanup on this commit and pushed back to the PR.
It should be mergable, though it doesn't do what we need for this feature fully yet (there's no limitation on access to web-public streams yet)

Closing in favour of https://github.com/zulip/zulip/pull/15875

This pull request implements part of zulip/zulip#12728. Unfortunately, I've not had time to continue this work, so only putting this PR up so that the (little) progress made is publicly available, at request of @timabbott.
Testing Plan:
N/A
GIFs or Screenshots:
N/A


Calling toUpperCase on null

The unittest package is calling the toUpperCase method while formatting test results. In certain situations it ends up with calling toUpperCase on a null object.
See for example the log below from http://build.chromium.org/p/client.dart/builders/vm-arm-sim-debug-be/builds/1098/steps/tests/logs/stdio
FAILED: none-vm debug_simarm pkg/code_transformers/test/resolver_test
Expected: Pass
Actual: RuntimeError
CommandOutput[vm]:
stdout:
unittest-suite-wait-for-done
ERROR: Resolver should handle empty files
  Test timed out after 120 seconds.
PASS: Resolver should update when sources change
PASS: Resolver should follow imports
PASS: Resolver should update changed imports
PASS: Resolver should follow package imports
PASS: Resolver handles missing files
PASS: Resolver should update on changed package imports
PASS: Resolver should handle deleted files
PASS: Resolver should fail on absolute URIs
PASS: Resolver should list all libraries
PASS: Resolver should resolve types and library uris
PASS: Resolver deleted files should be removed
PASS: Resolver handles circular imports
stderr:
Unhandled exception:
The null object does not have a method 'toUpperCase'.
NoSuchMethodError: method not found: 'toUpperCase'
Receiver: null
Arguments: []
#0      Object.noSuchMethod (dart:core-patch/object_patch.dart:45)
#1      SimpleConfiguration.formatResult (package:unittest/src/simple_configuration.dart:134:45)
#2      SimpleConfiguration.onSummary (package:unittest/src/simple_configuration.dart:163:25)
#3      _completeTests (package:unittest/unittest.dart:570:20)
#4      _runTest (package:unittest/unittest.dart:520:19)
#5      _nextTestCase (package:unittest/unittest.dart:450:11)
#6      _createTimer.<anonymous closure> (dart:async-patch/timer_patch.dart:11)
#7      _handleTimeout (dart:io/timer_impl.dart:292)
#8      _handleTimeout (dart:io/timer_impl.dart:301)
#9      _handleTimeout (dart:io/timer_impl.dart:301)
#10     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:116)

This issue has been moved to dart-lang/test#247.


[Application Enhancement] Table 18/23/27/... - Customer/Vendor/Item - OnDelete, Change occurrences to something other than ''

Dear ALAppExtensions team,
This issue is closely related to issues #1682 and #3721.
In the OnDelete trigger, of among others table 18, the occurrences of the "No." (PK) of the deleted record are replaced with ''.
For example:
        ServContract.SetFilter(Status, '<>%1', ServContract.Status::Canceled);
        ServContract.SetRange("Customer No.", "No.");
        if not ServContract.IsEmpty then
            Error(
              Text007,
              TableCaption, "No.");

        ServContract.SetRange(Status);
        ServContract.ModifyAll("Customer No.", ''); // << Targeting these statements

Could you make a change in accordance so that occurrences of deleted records will be replaced with dedicated nos. for deliberately deleted records?
That is, you will then still be able to make the distinction between empty nos. and nos. for deliberately deleted records (and this will also prevent erroneous behavior in other places).

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


[Bug] Script doesn't load properly

Checklist

[X] I will only use English in my report.
[X] I have used the search function for open and closed issues to see if someone else has already submitted the same bug report.
[X] I will describe the problem with as much detail as possible.

Questions

[X] xCloud officially supports my country/region.
[X] The bug doesn't happen when I disable Better xCloud script.
[X] The bug didn't happen in previous Better xCloud version (name which one).

Device
Laptop
Device
positivo bgh portatil
Operating System
winterOs
Android app/Browser Version
Chrome
Better xCloud Version
5.0.1
Game list
todos
Reproduction Steps
Upon entering the xbox.com page, it says: "better xcloud cannot be run, retrying." The page reloads and leads to one that says the requested page cannot be found. And so on continuously, better xcloud no longer runs and the page only works when I disable it in Tempermonkey.
Screenshot/video

Maybe current version of Tampermonkey now needs "Developer Mode" enabled in the extension settings to continue to work? That's something they anounced on their website.

The error still continues, I reinstalled tempermonkey and better xcloud in an old version and the error still persists, I tried many previous versions of better xcloud, the extensions section is also in developer mode

I'm just on the version that "didn't have that problem" and it still doesn't work, I'm thinking that maybe it could be the tempermonkey version. Anything I can do to solve it?

If it's Tampermonkey, you could try to downgrade by using "Tampermonkey Legacy":
https://chromewebstore.google.com/detail/tampermonkey-legacy/lcmhijbkigalmkeommnijlpobloojgfn

Try this: https://github.com/Tampermonkey/tampermonkey/issues/2086

Tested on Chrome 126.0.6478.127, Tampermonkey 5.2.1 and it still works for me

This is an issue with Tampermonkey, not Better xCloud.
However another user reported a possible solution here.


Using port to write to a register

Describe the issue
I have a custom register in my camera at address 0x00080104, but it's not defined as a node in the XML file.
I am trying to write a value to that register using the Port function.
I use ia.remote_device.port but it throws an exception:
{AttributeError}'NoneType' object has no attribute 'remote_port'
To Reproduce
Write to a register without using it's node reference .
Expected behavior
Write a value to a specific register.
Desktop
OS: Windows
Python: 3.7
Harvester: 1.2.8
GenTL Producer: Matrix-Vision

Hi, thank you for the report. Could you show me the full message that you get when the exception is raised, please? /Kazunari.

Hi Kazunari, I will post a screenshot, I think it's the best illustration of the issue.

I have to note that everything works perfectly (acquisition, writing to and reading from nodes).
Thank you.

Hi, I have just fixed the issue and have committed the change to the master branch. I would appreciate it if you could make a try with that. /Kazunari.

Hi Kazunari,
I implemented the changes you have committed, and I'm glad to say that it works.
I'm able to read and write memory blocks using the port function.
Thank you!

Hi, I am glad to hear that it worked for you. I hope you enjoy working on your project with Harvester. Cheers, Kazunari.

Hi Kazunari,
i had the same issue here and the change in master worked for me as well for the port write function. I'm pretty sure i'm just missing something, but how would i accomplish the read of a port thats not defined in the XML?
thanks,
lee

@denarolt Hi Lee, I am sorry having kept you waiting so long, I had overlooked your message. You can read/write register space as follows:
        # instantiate an acquirer:
        ia = self.harvester.create_image_acquirer(0)

        #
        address = 0x104
        access_size = 4

        # read a piece of data through the remote device port:
        data_size, data_returned = ia.remote_device.port.read(
            address, access_size)
        self.assertEqual(data_size, access_size)
        self.assertEqual(data_returned, b'\x00\x02\x00\x00')

        # overwrite the data through the remote device port:
        data_to_write = b'\x00\x01\x00\x00'
        ia.remote_device.port.write(address, data_to_write)

        # then read it back to make sure that it worked:
        data_size, data_returned = ia.remote_device.port.read(
            address, access_size)
        self.assertEqual(data_size, access_size)
        self.assertEqual(data_returned, data_to_write)

Regards, Kazunari


Update cmake compatibility bounds

Since version 3.19, cmake is sending a warning about compatibility bounds for bzip2, netcdf, tng & molfiles external libraries:
Compatibility with CMake < 2.8.12 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

We should update these bounds to explicitly indicate which cmake version we require. I think keeping support for 2.8.12 is good, so we could use their suggested upper bound instead.

After digging a bit, 2.8.12 is still supported, but the above packages have a minimal cmake version of 2.8.11. Given that the oldest cmake available in a LTS distro is 2.8.12 on CentOS 7, I think the fix is as simple as updating all bounds to 2.8.12.

After digging a bit, 2.8.12 is still supported, but the above packages have a minimal cmake version of 2.8.11. Given that the oldest cmake available in a LTS distro is 2.8.12 on CentOS 7, I think the fix is as simple as updating all bounds to 2.8.12.

Done in #402


Missing files

Installing and using the Component results in missing file errors:
ERROR in ./~/inferno-dates/lib/shapes/DateRangePickerShape.js
Module not found: Error: Can't resolve '../utils/getPhrasePropTypes' in '/home/user/project/node_modules/inferno-dates/lib/shapes'
 @ ./~/inferno-dates/lib/shapes/DateRangePickerShape.js 15:26-64
 @ ./~/inferno-dates/index.js

ERROR in ./~/inferno-dates/lib/shapes/SingleDatePickerShape.js
Module not found: Error: Can't resolve '../utils/getPhrasePropTypes' in '/home/user/project/node_modules/inferno-dates/lib/shapes'
 @ ./~/inferno-dates/lib/shapes/SingleDatePickerShape.js 15:26-64
 @ ./~/inferno-dates/index.js

ERROR in ./~/inferno-dates/index.js
Module not found: Error: Can't resolve './lib/utils/isInclusivelyAfterDay' in '/home/user/project/node_modules/inferno-dates'
 @ ./~/inferno-dates/index.js 15:28-72

ERROR in ./~/inferno-dates/index.js
Module not found: Error: Can't resolve './lib/utils/isInclusivelyBeforeDay' in '/home/user/project/node_modules/inferno-dates'
 @ ./~/inferno-dates/index.js 16:29-74

ERROR in ./~/inferno-dates/index.js
Module not found: Error: Can't resolve './lib/utils/isNextDay' in '/home/user/project/node_modules/inferno-dates'
 @ ./~/inferno-dates/index.js 17:16-48

ERROR in ./~/inferno-dates/index.js
Module not found: Error: Can't resolve './lib/utils/isSameDay' in '/home/user/project/node_modules/inferno-dates'
 @ ./~/inferno-dates/index.js 18:16-48

ERROR in ./~/inferno-dates/index.js
Module not found: Error: Can't resolve './lib/utils/toISODateString' in '/home/user/project/node_modules/inferno-dates'
 @ ./~/inferno-dates/index.js 20:22-60

ERROR in ./~/inferno-dates/index.js
Module not found: Error: Can't resolve './lib/utils/toLocalizedDateString' in '/home/user/project/node_modules/inferno-dates'
 @ ./~/inferno-dates/index.js 21:28-72

ERROR in ./~/inferno-dates/index.js
Module not found: Error: Can't resolve './lib/utils/toMomentObject' in '/home/user/project/node_modules/inferno-dates'
 @ ./~/inferno-dates/index.js 22:21-58

ERROR in ./~/inferno-dates/index.js
Module not found: Error: Can't resolve './lib/components/DateRangePicker' in '/home/user/project/node_modules/inferno-dates'
 @ ./~/inferno-dates/index.js 1:22-65

ERROR in ./~/inferno-dates/index.js
Module not found: Error: Can't resolve './lib/components/DateRangePickerInput' in '/home/user/project/node_modules/inferno-dates'
 @ ./~/inferno-dates/index.js 2:27-75

ERROR in ./~/inferno-dates/index.js
Module not found: Error: Can't resolve './lib/components/DateRangePickerInputController' in '/home/user/project/node_modules/inferno-dates'
 @ ./~/inferno-dates/index.js 3:37-95

ERROR in ./~/inferno-dates/index.js
Module not found: Error: Can't resolve './lib/components/SingleDatePicker' in '/home/user/project/node_modules/inferno-dates'
 @ ./~/inferno-dates/index.js 4:23-67

ERROR in ./~/inferno-dates/index.js
Module not found: Error: Can't resolve './lib/components/SingleDatePickerInput' in '/home/user/project/node_modules/inferno-dates'
 @ ./~/inferno-dates/index.js 5:28-77

ERROR in ./~/inferno-dates/index.js
Module not found: Error: Can't resolve './lib/components/DayPicker' in '/home/user/project/node_modules/inferno-dates'
 @ ./~/inferno-dates/index.js 6:16-53

ERROR in ./~/inferno-dates/index.js
Module not found: Error: Can't resolve './lib/components/DayPickerRangeController' in '/home/user/project/node_modules/inferno-dates'
 @ ./~/inferno-dates/index.js 7:31-83

ERROR in ./~/inferno-dates/index.js
Module not found: Error: Can't resolve './lib/components/CalendarMonthGrid' in '/home/user/project/node_modules/inferno-dates'
 @ ./~/inferno-dates/index.js 8:24-69

ERROR in ./~/inferno-dates/index.js
Module not found: Error: Can't resolve './lib/components/CalendarMonth' in '/home/user/project/node_modules/inferno-dates'
 @ ./~/inferno-dates/index.js 9:20-61

ERROR in ./~/inferno-dates/index.js
Module not found: Error: Can't resolve './lib/components/CalendarDay' in '/home/user/project/node_modules/inferno-dates'
 @ ./~/inferno-dates/index.js 10:18-57

looks like index.js is still there from React.
Try to import  DateRangePickerWrapper from 'inferno-dates/examples/DateRangePickerWrapper'
then import 'inferno-dates/css/styles.scss';
and use <DateRangePickerWrapper /> in your app.

I did not try it yet in my app. Still WIP

I looked into the node_modules directory and the files are indeed missing. When building localy it was complaining that Error: Namespace attributes are not supported. ReactJSX is not XML. I will try out your suggestion

Yeah, I removed many files and modules from original React package, it was over 600k in total and I slim it down to 160k.
I will update index.js to make it point to right files.

On May 3, 2017, at 17:51, IgnusG<EMAIL_ADDRESS>wrote:
I looked into the node_modules directory and the files are indeed missing. When building localy it was complaining that Error: Namespace attributes are not supported. ReactJSX is not XML. I will try out your suggestion
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.

@IgnusG try it now please. I fixed lib folder.

I'm having trouble with my setup but I will get back to you as soon as possible

I was missing return god dammit. @kurdin The files are being compiled correctly but I have another Issue (will open new ticket)


Update druid conf.yaml.example

After working on ticket https://datadog.zendesk.com/agent/tickets/1152524 , this customer informed me that druid uses multiple urls (druid coordinator / broker / router url) . For this integration to work, the druid coordinator url needs to be used. They requested our docs be more specific regarding which url is used.
What does this PR do?
Specify which druid url is used.
Motivation
https://datadog.zendesk.com/agent/tickets/1152524
Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached
[ ] If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

The license keeps failing. Not sure why. I tried syncing, but then it ask to revert the sync.

The license keeps failing. Not sure why. I tried syncing, but then it ask to revert the sync. 63fecbe 8a7ebc7

Yeah it's been a bit flaky lately. I think @iliakur created a card to have a look at that and fix it as part of the partner rotation.
Reverting this change and merging this PR

Thanks for this PR 🙂


Project does not have a LICENSE

I(t ouwld be good if we all could know under what license the source code is available at.

Fixed thanks @ysb33r


GeomVertexWriter constructor can take a string as the second parameter

I've been using your typing for panda3d as it really helps out, but when using GeomVertexWriter I noticed that the typing indicates that an InternalName object is required as the second parameter while in reality a string can be used. This is because InternalName has an implicit constructor that takes an std::string causing an implicit conversion.
One possible way to solve this might be to check every class for possible implicit conversions using interrogate and combine them using a union.

First of all, thanks for the kind words.

One possible way to solve this might be to check every class for possible implicit conversions using interrogate and combine them using a union.

This would be the way to do it, yes. Currently, a handful of implicit conversions are accounted for, but there's not yet a way to automatically account for all of them. This will be possible, however, in Panda3D 1.10.13. I've done some prototyping with preview builds, and will publish that functionality once 1.10.13 is released (which should be later this month, I believe).
Some technical details:
The prototype wasn't checking make methods, so this case was actually being overlooked, but that was an easy fix. Additionally, the specific wrapper allowing for coercion from a str to an InternalName actually expects a Python string in particular, so interrogate doesn't store that it requires anything more specific than a Python object. This means it will have to be special-cased in some way, but we already do that for supporting coercion of a StrOrBytesPath to a Filename, so it's not a big deal.

Fixed with https://github.com/WMOkiishi/types-panda3d/commit/49fe40eb0549083ff0384905daea3631c1b7660d.
(Despite what the commit message may say.)


fix: use owner as CREATE2 salt

Addresses https://github.com/cantinasec/review-sablier2/issues/25.

Yanked in favor of https://github.com/PaulRBerg/prb-proxy/pull/130.


Remove unused dependency crossbeam = 0.7.1

Hi! I happened to notice that crossbeam is not used in this crate; this PR should help clean up the Cargo.toml a little.

Thanks!


Make devimint tmp dir much smaller

Fix https://github.com/fedimint/fedimint/issues/3665
This shrinks each devimint tmp directory from 1.3GB to 83MB. This was caused be excessive default rocksdb pre-allocation, especially in esplora-electrs, which is not useful for tiny testing setups.

I think you linked the wrong issue xD

I think you linked the wrong issue xD

Edited to point at correct issue

https://github.com/romanz/electrs/pull/975
https://github.com/Blockstream/electrs/pull/64


Hunger Games: Button not visible

What
Button to answer the question is nit visible, when the brand field is too big.
Steps to reproduce the behavior

Play Hungergames
Be unlucky and get a question with a spammed brand field

Expected behavior
Dialog is scrollable, or brand field is cut off at a certain point
Screenshot/Mockup/Before-After

Smartphone model

Device: Xiaomi Poco F2 Pro
OS: LineageOS 20 / Android 13
App Version: 4.7.0

For the record: https://de.openfoodfacts.org/produkt/4006544205006/feiner-rübenzucker-südzucker
Probably duplicate with #4086, and therefore solved with the latest dev version.

product
question
image

@ayecptn Had a chance to test with the latest prod version (4.8.0)?

No, the 4.8.0 is not yet available for me on the playstore, I am still on the 4.7.0


Predicting Vulnerable Components: Software Metrics vs Text Mining

Predicting Vulnerable Components: Software Metrics vs Text Mining
Link to paper : http://ieeexplore.ieee.org/xpl/articleDetails.jsp?tp=&arnumber=6982351&queryText%3DPredicting+Vulnerable+Components%3A+Software+Metrics+vs+Text+Mining
Link to data : http://seam.cs.umd.edu/webvuldata/
James Walden, Jeffrey Stuckman and Riccardo Scandariato
pages: 23-33
doi>10.1109/ISSRE.2014.32
In this paper, we provide a high-quality, public dataset, containing 223 vulnerabilities found in three web applications, to help address this issue. We used this dataset to compare vulnerability prediction models based on text mining with models using software metrics as predictors.

The authors say in the introduction that they will make available "a novel, hand-curated dataset of vulnera- bilities in PHP web applications that will be offered to the community." Is this the sort of thing we care about? Or do we care about the input dataset all with vulnerability and defect metrics? Perhaps both? Is the former too qualitative to be useful to us?

They make available "a raw dataset and a replication dataset. Most users will be interested in the raw dataset, which contains the complete vulnerability and feature data for each application version. A subset of the raw dataset was extracted and reformatted into a replication dataset, which contains the data and scripts required to replicate the results of the study." Which one do we take? Both? Is it dependent on size, or perhaps something else?

Should we copy the source code of every version of PHPMyAdmin and Moodle to the big repo? They add up to 519 MB total, but the total size of all the other relevant data is less than 30 MB.

Am i reading this right?

the RAW data sets are all < 10MB each
the replication datasets are 200 to 400MB each and there are many of them

if yes and yes then  download the RAW and leave the replication.


groupedStatefullyWhile is actually performing an until operation

groupedStatefullyUntil makes more sense as an operator than groupedStatefullyWhile as you don't need to accodomate the empty / starting case separately.
Method should be renamed.

Merged in https://github.com/aol/cyclops-react/pull/289


OTC swap frontend

Type of change

New feature: frontend

Changes
The following changes have been made:

Adding a basic frontend for the OTC swap predicate
The frontend uses a precompile of the predicate bytecode, and substitutes in the offer details in the appropriate places.

Things that are working:

Generating bytecode root from offer details
Displaying any coins found at the corresponding predicate address
Automatically detecting network change and updating coins
Input validation

Known limitations [See also, TODO comments in project]

A readme. Will add via subsequent PR before merging to master.
Spending the predicate's coins, either through order fulfillment or cancelling by order creator. (blocked by SDK)

To test:

From OTC-swap-predicate root, cd frontend && npm install && npm start
To make an offer: Enter amount, asset ID and receiver. Addresses can be hex or bech32 fuel addresses. A predicate address will be displayed. You can copy this and send funds to it using the fuel wallet. Invalid inputs will cause no predicate address to be displayed, and will be highlighted.
To take an offer. Enter amount, asset ID and receiver of an existing offer. On the beta-2 testnet, offer (0, 0x00..., 0x00...) is funded for convenience.

Related Issues
Closes #400

Just a couple of comments. In general files should follow their respective component names ComponentNameExample.tsx. Also if we encounter an error or have a successful contract interaction we should alert the user. We are using toast for this. You can import it from the fuel-ui library.

Currently there are no contract interactions or transactions in the app. It simply calculates the predicate ID to send the funds to.

Thanks for the review, @Braqzen

I recommend creating a new PR which takes master and merging that into staging. Next, adapt this code structure to the rest of the apps
There are a few too many lines in various places, could remove some
The css uses px and % in some places. Afaik that's not great, there's various ways of setting width / height but I don't remember what the go to is. I think using rem or em is meant to be the standard.
There's at least one console log (for changing network). I think we should avoid logging things to the console unless there's a good reason to do it. Arbitrary debug-esque calls reduce the code quality imo. Perhaps use toast instead?
Unsure about that blob of bytecode. It says there is some manipulation there too. That begs some questions. I think it's better to generate that and automatically sub values in. Seems more credible and trustworthy that way because I can see how things are created.
Target for compilation is es5 as opposed to the proposed es6 for other apps
npm should work but I suggest using pnpm and vite
I have yet to run the PR

I'll take care of conflicts with master when we merge staging into master.
Empty lines?
You're probably right here, but if this functionally works then I'd like to merge and potentially tidy up later.
Noted - will remove console.log s
I wanted to avoid re-compiling every time a constant changed in order for the predicate calculation to be absolutely instantaneous and dynamic. There's also no nice way of setting compile-time constants just before compilation. I think if the user wants to check the predicate root they can always build the predicate themselves.
Hmm. I'll look into this.
Will look into migrating in a future PR.

I should have said "new lines". There are multiple places where there are multiple new / empty lines in a row when there should be fewer e.g. inputValidation with the try / catch has a line between them
There should be instructions written in the subsequent PR telling the user how to create the bytecode so that they can match on it with some editor to see if it is exactly the same when they reproduce

console.log() -> toast.error()


Support old receipt type (state root before byzantium)

This is more a discussion and dont forget it task.
Receipt before Byzantium contained state root and didn't have status, how exactly do we want to support that? calculating state root is expensive and it is best done while execution is on the way, we could just ignore it and put empty/zero value or maybe somehow hardcode it?
Part of code that checks receipt root (without stateroot within receipt this is skipped before byzantium):
https://github.com/paradigmxyz/reth/blob/e6ca4c56c6a314e5553656e5b62be3bca6801b85/crates/executor/src/executor.rs#L261-L268

How does Erigon do this?

Geth checks the root of every block, one of the reasons why geth archive is not usable, for Erigon idk.

@carver just saw your note on Reddit, should we remove that reference to Trin from the blog? apologies if it felt inaccurate.
What should we do here to better support Trin / what are you missing?

Any update on this issue / estimated timeline until Reth might be able to support pre-byzantium receipts?

Any update on this issue / estimated timeline until Reth might be able to support pre-byzantium receipts?

Do you need this for an application? Would be good to know what the requirements are exactly

The use case would be to re-calculate valid receipt roots for pre-byzantium blocks, which requires the state_root field. However, in Trin / the Portal Network, we're moving towards using era1 files for pre-byzantium blocks, rather than requesting the data from a client, so this is no longer needed from our side

Hi. We would like this feature too. I think I could be able to implement it after looking how Geth handles it.
Just to be sure, this step from geth is related, right?

Hi. We would like this feature too. I think I could be able to implement it after looking how Geth handles it. Just to be sure, this step from geth is related, right?

yes, although fair warning, it's definitely a nontrivial change, and I'm still not convinced we should support this. What's the use case for pre byzantium receipts?

yes, although fair warning, it's definitely a nontrivial change, and I'm still not convinced we should support this. What's the use case for pre byzantium receipts?

In our flat files decoder here we need to have  encoding that supports pre-byzantinum transactions. We did some workaround in order for it to work, however, it would be nice if Reth handled it.
Thinking about it now, just handling this functionality in enconde_inner in Reth should be enough, right?

yes, although fair warning, it's definitely a nontrivial change, and I'm still not convinced we should support this. What's the use case for pre byzantium receipts?

In our flat files decoder here we need to have encoding that supports pre-byzantinum transactions. We did some workaround in order for it to work, however, it would be nice if Reth handled it.
Thinking about it now, just handling this functionality in enconde_inner in Reth should be enough, right?

Yeah, I would even be open to supporting a separate pre-byzantium receipt type (which would derive rlp encodable / decodable) if necessary

Yeah, I would even be open to supporting a separate pre-byzantium receipt type (which would derive rlp encodable / decodable) if necessary

Neat. I will work on it. Any recommendations for this task besides the contribution guidelines?


citrix_workspace: fix build / add mesa dependency

Motivation for this change
A recent change in nixpkgs has made several binary packages break because they are now unable to find libraries from mesa.
       > autoPatchelfHook could not satisfy dependency libdrm.so.2 wanted by /nix/store/9zdaircmn2pin0918xr220rwvmvjzgnx-citrix-workspace-<IP_ADDRESS>/opt/citrix-icaclient/cef/libcef.so
       > autoPatchelfHook could not satisfy dependency libgbm.so.1 wanted by /nix/store/9zdaircmn2pin0918xr220rwvmvjzgnx-citrix-workspace-<IP_ADDRESS>/opt/citrix-icaclient/cef/libcef.so
       > Add the missing dependencies to the build inputs or set autoPatchelfIgnoreMissingDeps=true
       For full logs, run 'nix log /nix/store/9asvd7b0acw7fksap12q6hkgpyahvlsj-citrix-workspace-<IP_ADDRESS>.drv'.

This PR just fixes the build.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 121501 run on x86_64-linux 1

7 packages built:

citrix_workspace
citrix_workspace_20_04_0
citrix_workspace_20_06_0
citrix_workspace_20_09_0
citrix_workspace_20_10_0
citrix_workspace_20_12_0
citrix_workspace_21_01_0


add cri redirect for Japanese

is this really necessary?

@inductor can you confirm that this redirect is needed?

/close


same queryid for different queries

Is it ok?
-bash-4.2$ /usr/pgsql-10/bin/pg_ctl restart
waiting for server to shut down.... done
server stopped
waiting for server to start....2018-07-15 03:29:01.252 EDT [7119] LOG:  listening on IPv4 address "<IP_ADDRESS>", port 5432
2018-07-15 03:29:01.252 EDT [7119] LOG:  listening on IPv6 address "::", port 5432
2018-07-15 03:29:01.254 EDT [7119] LOG:  listening on Unix socket "/var/run/postgresql/.s.PGSQL.5432"
2018-07-15 03:29:01.258 EDT [7119] LOG:  listening on Unix socket "/tmp/.s.PGSQL.5432"
2018-07-15 03:29:01.537 EDT [7119] LOG:  redirecting log output to logging collector process
2018-07-15 03:29:01.537 EDT [7119] HINT:  Future log output will appear in directory "log".
 done
server started
-bash-4.2$ /usr/pgsql-10/bin/pgbench -i -s10 postgres
creating tables...
100000 of 1000000 tuples (10%) done (elapsed 0.14 s, remaining 1.23 s)
200000 of 1000000 tuples (20%) done (elapsed 0.44 s, remaining 1.75 s)
300000 of 1000000 tuples (30%) done (elapsed 0.72 s, remaining 1.67 s)
400000 of 1000000 tuples (40%) done (elapsed 0.99 s, remaining 1.48 s)
500000 of 1000000 tuples (50%) done (elapsed 1.21 s, remaining 1.21 s)
600000 of 1000000 tuples (60%) done (elapsed 1.50 s, remaining 1.00 s)
700000 of 1000000 tuples (70%) done (elapsed 1.92 s, remaining 0.82 s)
800000 of 1000000 tuples (80%) done (elapsed 2.10 s, remaining 0.52 s)
900000 of 1000000 tuples (90%) done (elapsed 2.46 s, remaining 0.27 s)
1000000 of 1000000 tuples (100%) done (elapsed 2.67 s, remaining 0.00 s)
vacuum...
set primary keys...
done.
-bash-4.2$ psql
psql (10.4)
Type "help" for help.

postgres=# select ash_time, pid, application_name, wait_event, queryid, query, top_level_query  from pg_active_session_history;
           ash_time            | pid  | application_name |  wait_event  |  queryid   |                       query                        |                  top_level_query

-------------------------------+------+------------------+--------------+------------+----------------------------------------------------+---------------------------------
-------------------
 2018-07-15 03:29:13.593408-04 | 7130 | pgbench          | ClientRead   |<PHONE_NUMBER> | copy pgbench_accounts from stdin                   | copy pgbench_accounts from stdin
 2018-07-15 03:29:14.595365-04 | 7130 | pgbench          | CPU          |<PHONE_NUMBER> | copy pgbench_accounts from stdin                   | copy pgbench_accounts from stdin
 2018-07-15 03:29:15.601175-04 | 7130 | pgbench          | ClientRead   |<PHONE_NUMBER> | copy pgbench_accounts from stdin                   | copy pgbench_accounts from stdin
 2018-07-15 03:29:16.604073-04 | 7130 | pgbench          | DataFileRead |<PHONE_NUMBER> | vacuum analyze pgbench_accounts                    | vacuum analyze pgbench_accounts
 2018-07-15 03:29:17.607471-04 | 7130 | pgbench          | CPU          |<PHONE_NUMBER> | alter table pgbench_branches add primary key (bid) | alter table pgbench_branches add
 primary key (bid)
 2018-07-15 03:29:18.616975-04 | 7130 | pgbench          | CPU          |<PHONE_NUMBER> | alter table pgbench_accounts add primary key (aid) | alter table pgbench_accounts add
 primary key (aid)
(6 rows)

postgres=# select queryid,calls,query from pg_stat_statements where queryid =<PHONE_NUMBER>;
  queryid   | calls |                              query
------------+-------+-----------------------------------------------------------------
<PHONE_NUMBER> |   100 | insert into pgbench_tellers(tid,bid,tbalance) values ($1,$2,$3)
(1 row)

got it, fix in progress...

Fixed


Make it possible to override remoteServiceName in ObservationFilter

Right now it is not possible to set the remoteServiceName of a Span through an Observation.Context (SenderContext) using an ObservationFilter since the remoteServiceName is set on the Span before the ObservationFilter is called.
(In PropagatingSenderTracingObservationHandler is set on the Span from the onStart method while ObservationFilter is called from onStop.)
Here's what happens:

SenderContext and the Observation is created, at this point the instrumentation should know the remoteServiceName.
The Observation is started and PropagatingSenderTracingObservationHandler's onStart method is called.
PropagatingSenderTracingObservationHandler sets remoteServiceName on the Span.
The Observation is stopped and the ObservationFilter is called.
At this point even if the ObservationFilter modifies the remoteServiceName, it has no effect since it is called after remoteServiceName was set on the Span.

This is true for remoteServiceAddress and remoteIpAndPort too.
Also see: https://github.com/spring-projects/spring-boot/issues/39432

Why do you think this should be done via an ObservationFilter? It is too late to set that, in Brave and OTel you can't modify these values in any other time than start of the span. We can create an additional method to override in PropagatingSenderTracingObservationHandler that has access to the Span.Builder. That way it would be possible to override these values (OTOH they are already in the Observation Context so I don't know how that would help).
The way to do it as late as possible would be to call a SpanFilter and modify the remote service name and ip and port. At this point both Brave and OTel allow that.


Support code coverage collection for react-native targets

I'm not seeing a mechanism to support collecting code coverage, what would support for this look like?

I wonder how will this work as from my understanding it's using native drivers to drive UI.
For example, as Appium uses similar approach - https://stackoverflow.com/questions/36924528/appium-ios-code-coverage#:~:text=It is not possible to do a code,it get called when the test is done./n.

Maestro isn't a tool for collecting e2e code coverage.
If you want code coverage, I think you should at tools that are more far away from the end user, and closer to the source code. Links shared by @Maxim-Filimonov above are a good start.


Automatic updates

We have written the ne
Issue Type: Bug
So, this is probably on me, but the automatic update has failed multiple times.  It actually wipes out my VS Code installation and I have to re-install. I have turned the auto-update off and it isn't a big deal but I do like the feature. BTW - the version showing below is the one I just manually installed because the auto-update failed.  Thanks for looking at it.
VS Code version: Code 1.44.1 (a9f8623ec050e5f0b44cc8ce8204a1455884749f, 2020-04-11T01:48:12.622Z)
OS version: Windows_NT x64 10.0.18362

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz (12 x 2208)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: enabledrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.90GB (4.86GB free)

Process Argv
.

 Please paste.

/duplicate #47841
As a workaround, please disable Windows background updates by setting update.enableWindowsBackgroundUpdates to false.


Connexion Security Plugin

Hello,
Thanks, this was easy to set up and get going. A Connexion/OpenAPI example would be great.
Thanks Again,
Mark

Thanks for your suggestion. We will definitely take a look at a later time. We are currently focusing on providing better support for more popular frameworks. We shipped Django support just minutes ago. Our next target will be Flask.
Meanwhile, you can use the Watch button (near the Star button) of this repo to subscribe its future release notifications.


Exception formatting GitHub events

I don't have whatever payload caused this, but here's the exception:
Traceback (most recent call last):
  File "/home/zulip/deployments/2017-05-10-06-16-16/zulip-venv/lib/python2.7/site-packages/django/core/handlers/base.py", line 185, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/home/zulip/deployments/2017-05-10-06-16-16/zulip-venv/lib/python2.7/site-packages/django/views/decorators/csrf.py", line 58, in wrapped_view
    return view_func(*args, **kwargs)
  File "./zerver/webhooks/github_dispatcher.py", line 15, in api_github_webhook_dispatch
    return api_github_landing(request)
  File "/home/zulip/deployments/2017-05-10-06-16-16/zulip-venv/lib/python2.7/site-packages/django/views/decorators/csrf.py", line 58, in wrapped_view
    return view_func(*args, **kwargs)
  File "./zerver/decorator.py", line 104, in wrapper
    return func(request, *args, **kwargs)
  File "./zerver/lib/request.py", line 166, in _wrapped_view_func
    return view_func(request, *args, **kwargs)
  File "./zerver/decorator.py", line 384, in _wrapped_func_arguments
    return limited_func(request, user_profile, *args, **kwargs)
  File "./zerver/decorator.py", line 664, in wrapped_func
    return func(request, *args, **kwargs)
  File "./zerver/lib/request.py", line 166, in _wrapped_view_func
    return view_func(request, *args, **kwargs)
  File "./zerver/webhooks/github/view.py", line 270, in api_github_landing
    **kwargs)
  File "./zerver/webhooks/github/view.py", line 175, in api_github_v2
    created=payload['created'])
  File "./zerver/webhooks/github/view.py", line 294, in build_message_from_gitlog
    content = get_push_commits_event_message(pusher, url, short_ref, commits)
  File "./zerver/lib/webhooks/git.py", line 64, in get_push_commits_event_message
    committers_details = "{} ({})".format(*committers_items[0])
IndexError: list index out of range

For future debugging, a thought: maybe we should add a log file where raw requests that throw an exception in api_key_only_webhook_view are logged in test fixture format.
\

@zulipbot claim!

@timabbott : I tried reproducing this exception on my end but couldn't. Anyways, I think the best way to go here is to just log failed requests and save the payloads for inspection. If we run into the same exception again, it will give us a chance to catch it in the future. I have a question, do we want to create a log file and log the exception there and then create a separate .json file with the failed payload in it or do we want to include the failed payload in the log file itself (or something else entirely)? :)

I was thinking of just having a log file that contained a series of entries, each containing the pretty-printed request body.  Ideally, we'd pretty-print to make it easy to copy into a fixture file conveniently, but that's not as important as just having the feature in the first place :).

OK, thanks to our new logging, I now know what causes this; it's a push deleting a branch.  Relevant section of the push:
    },
    "created":false,
    "deleted":true,
    "commits":[

    ],
    "after":"0000000000000000000000000000000000000000",
    "head_commit":null,


Implement singledispatch'd database abstraction

Implements the singledispatch pattern for abstracting database backends. Includes a convenience decorator to make the registration of dispatches slightly easier.
Cherrypicks (and slightly modifies, for convenience) a few things from #886 as a stopgap before #886 is merged. Originally, I thought I could make this branch pass all the tests, but this is proving unlikely without larger changes (mostly database setup and commands) with more of #886. Making the tests pass, with just RethinkDB, will be done in a another pull request.
Should be merged after #886; I'll solve the merge conflicts that might happen as a result of the cherrypicking.

:+1:


docs(deploy): deploy docs to gh-pages on master branches

Summary:
Enable automatic deploys to docs site at https://chanzuckerberg.github.io/lp-design-system/?path=/story/tokens--page. This makes access by non engineers to design system docs easier as we're building.
Test Plan:
Example passing workflow build at https://github.com/chanzuckerberg/lp-design-system/runs/728640162?check_suite_focus=true

Seems fine, hacking the GH token can be resolved later if we think of a better solution. No need to let it be blocking now.


Add support for make test to testport

With the official support of make test in FreeBSD's Ports tree, and the corresponding TEST_DEPENDS it would be most useful if this target was run after packaging and QA.

There is a patch for it, #355, but there's a problem with recursive dependencies in TEST_DEPENDS.
I think the best way to handle it is to only run the test target when running testport, but not when running bulk -t.

That would leave testport broken sometimes.
Closing as duplicate of #355.


add materialize pushpin directive.

Looking good, even some decent documentation, nice!
There was one issue though, because the Materialize framework only adds the pushping method on document.ready, there was a chance that the method was called before it was defined.
I fixed that in the commit you see above.


Asset 504: bad answer ID for thrombin, duplicate of 503?

Asset 504 currently uses CHEMBL.COMPOUND:CHEMBL2108110 as the expected answer ID for thrombin.
However, this is a chemical ID - and this appears to be looking for genes that have decreased activity/abundance with the input chemical Lepirudin.
I imagine the gene/protein ID should be used instead - but then this is the same as Asset 503 (which has another issue #83).
Should this test be removed as a duplicate?

This means there's some vagueness around what thrombin is (F2 gene/multiple proteins/chemical thing).
Alpha-thrombin UMLS:C0002313 is mentioned in https://github.com/NCATSTranslator/Tests/issues/69 as a related thing. It's a ChemicalEntity in NodeNorm, but a Protein in ARAX's response.

Running thrombin through Name Resolver gives CHEBI:9574 which doesn't seem to be a duplicate of any existing assets. Should this asset just be updated to this?

I don't think this query will return chemicals as "answers".
The query seems to be an MVP2, input chemical (Lepirudin) and output genes with decreased activity/abundance.

Sorry - I am just coming back to this (I was away for quite some time). For all assets I have done, the ID reported was the IDs outputed by the UI. I did this on purpose because issues in normalization need to be adressed as well. So to me, they should raise other tests for nomalization issues. If we fix them by hand here, will we be able then to come back and list all issues in normalization for another suite?

Assets 503 and 504 are not duplicates, they are "unconflated" results: because of conflation, they are all top answers but in reality they are different elements:
UNIPROTKB:P00734 is prothrombin which is the protein from F2 gene
this protein is further cleaved into thrombin (CHEMBL.COMPOUND:CHEMBL2108110) via metabolic reaction
There is an issue with output nomalization that leads to 2 different results (from different ARAs) that are both true, they just appear in 2 different clique. Please note that Thombin is a serine protease so it is not a compound but a protein and with conflation on, F2/Thombin/Prothrombin are all true.

Please assign this email address/GitHub account in the future, I do not receive any notification with the other one. Thanks!


Using multiple binary files for training

Hi,
Just like how the workers generate I have multiple train bin and idx files like
train1.en-de.en.bin
train1.en-de.en.idx
train1.en-de.de.bin
train1.en-de.de.idx

train2.en-de.en.bin
train2.en-de.en.idx
train2.en-de.de.bin
train2.en-de.de.idx

Now I want to run the training on these multiple files like a single bin and idx file in each case. Is it possible in a straight forward way to do so or else should I need to change something ?
Thanks.

Sorry, I don't understand your question- you don't want multiple bin and idx files? Right now the binarization creates these, you would need to change that process and the data loading as well

Firstly sorry for late reply, My question is let's say I have 1000 parallel sentences and binarized them to create bin and idx files. Now I get another 1000 sentences and I do the same to get second set of bin and idx files. Now if I want to train the model on combined 2000 sentences instead for combining the sentences and binarizing again is there a way so that I can combine the binarized files (bin, idx ) files generated in each case.

I also meet this problem. Does anyone successfully solve it?

The following two steps may solve your problems.

Move the multiple train bin and idx files to separate directories, e.g, train1 and train2.
Use a colon : to separate directories, which will be iterated upon during epochs in a round-robin manner. For example,  fairseq-train --fp16  train1:train2

@luofuli's answer is the recommended approach.


[New game]: Alphabet and Vowels game

🎮 Game Request
Player have to guess the alphabets and vowels in this game.
Point down the features
correct guess
score
limited chance
Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @manishh12 !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

/assign

Hey @manishh12 ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


New installer mentions it is discontinued, prompting to use new installer

Describe the bug
I received the message "The version of BetterDiscord you are using has been discontinued. Please reinstall using the new installer found here: https://github.com/BetterDiscord/Installer/releases/latest", downloaded it and installed, only to get the same message about that version being discontinued. It does appear it is changing versions when checking settings so it is doing something.
The new installer seems to set up
Stable 86482 (263b26b)
BBD 0.3.5
Host 0.0.309
Injector 0.6.2

trying the switch to beta in settings shows me
"There is an update available for BetterDiscord's Injector (1.1.1).
You can either update and restart now, or later."
Stable 86482 (263b26b)
BD 1.0.0 (086482f)
Host 0.0.309
Injector 0.6.2

Following that above update to 1.1.1 seems to upgrade to
Stable 86482 (263b26b)
BBD 0.3.5
Host 0.0.309
Injector 0.6.2

the same as the new installer.
Additionally I've attempted repair the install use the repair option in the new installer for the same result.
System Information:

OS: Windows 10 64-Bit (10.0.19042)
Discord Version: Stable 86482 (263b26b)

You used an old installer (not the one found in this repo)
Download the new installer from here or here

I have used the one from this repo and specifically the one you have just linked. Same issue. I mentioned so in the initial post.

Still, u seemed to have used an old installer at some point, since ur BD version is 0.3.5.
Delete the BD folder entirely and reinstall using the latest installer.
Also, you should reinstall discord itself before doing that since you are still in 0.0.309 instead of 1.0.9002.


Log files size

I'm using rebot to generate logs. I run same 217 cases on older (python 2) version of robotframework and the size is about 17 mb, while on newest version of robotframework  for python 3(robotframework==3.1.2) it is 474mb and output.xml is even larger= about 2 gb!

There must be something else that's different as well. Output and log file sizes don't change much between Robot Framework versions and even less with Python versions. If you can reproduce this issue so that the problem certainly is in Robot Framework itself, please submit a new issue with more details. If you just try to understand what's going on, it's better to send questions to robotframework-users mailing list, our active Slack, or other such support forums listed at robotframework.org.

It turned out I was using jybot.bat (jython) on older version.
Logfile and output.xml is a lot smaller, can it be because of some specific log4j.properties settings?
I run it via custom script like this:
set _JAVA_OPTS=-Duser.language=en -Duser.country=US -Dconsole.encoding=UTF-8 -Dfile.encoding=UTF-8 -Djava.ext.dirs=%IUM_TEST%\lib;%IUM_TEST%\lib\axis2\lib -Dlog4j.configuration=file:./log4j.properties
call %PYTHONPATH%\Scripts\jybot.bat  --loglevel TRACE -C off -d %RF_RUNNER_HOME%\out1 -l NONE -r NONE  %RF_ARGS%

log4j shouldn't affect Robot's logging at all.

Can you please give me a hint about what else can be influencing the log size?
I'm using rebot.bat, not jrebot to generate a log from output.xml. Here's the full code of custom  script:
set _JAVA_OPTS=-Duser.language=en -Duser.country=US -Dconsole.encoding=UTF-8 -Dfile.encoding=UTF-8 -Djava.ext.dirs=%IUM_TEST%\lib;%IUM_TEST%\lib\axis2\lib -Dlog4j.configuration=file:./log4j.properties
call %PYTHONPATH%\Scripts\jybot.bat  --loglevel TRACE -C off -d %RF_RUNNER_HOME%\out1 -l NONE -r NONE  --variable RESOURCE_FILE:%IUM_TEST%\suits\resources\local\Resources_local.txt %RF_ARGS%
call %PYTHONPATH%\Scripts\rebot.bat  -d %RF_RUNNER_HOME%\out1 %RF_RUNNER_HOME%\out1\output.xml

Can you please give me a hint about what else can be influencing the log size?
I'm using rebot.bat, not jrebot to generate a log from output.xml. Here's the full code of custom script I'm using on python2:
set _JAVA_OPTS=-Duser.language=en -Duser.country=US -Dconsole.encoding=UTF-8 -Dfile.encoding=UTF-8 -Djava.ext.dirs=%IUM_TEST%\lib;%IUM_TEST%\lib\axis2\lib -Dlog4j.configuration=file:./log4j.properties
call %PYTHONPATH%\Scripts\jybot.bat --loglevel TRACE -C off -d %RF_RUNNER_HOME%\out1 -l NONE -r NONE --variable RESOURCE_FILE:%IUM_TEST%\suits\resources\local\Resources_local.txt %RF_ARGS%
call %PYTHONPATH%\Scripts\rebot.bat -d %RF_RUNNER_HOME%\out1 %RF_RUNNER_HOME%\out1\output.xml

I don't know your environment and cannot help you. You are the only one being able to debug this further.


Cannot release function unless local settings points at a live resource

We're trying to release a queue-triggered function in Azure
The local.settings.json file needs to have an AzureWebJobStorage connection string which is a live resource (instead of the recommended "UseDevelopmentStorage=true;") for the release to work.
If the AzureWebJobsStorage connection string is "UseDevelopmentStorage=true;", the function deployment attempts to connect to a local resource, even though this value is overridden in the function app's config in the portal. This leads to an error
Retry failed after 6 tries. Retry settings can be adjusted in ClientOptions.Retry. (An attempt was made to access a socket in a way forbidden by its access permissions. (<IP_ADDRESS>:10001))
Curiously, if the AzureWebJobStorage is updated to point at a storage account, the release will succeed and the AzureWebJobStorage value from the portal configuration will be used thereafter.
Relates to this

We should probably not set the AzureWebJobsStorage app setting if we detect that is either "UseDevelopmentStorage=true;" or ""

Hi @SaksunBindy
Quick question: is uploading your local.settings.json part of your workflow when you release? I believe that is the only time the AzureWebJobsStorage setting would be overwritten.


[Esoterrorists] Add one more skillbox per row

Changes / Comments
I have added one more skill checkbox per skill row. Minor change.
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[X] Does the pull request title have the sheet name(s)? Include each sheet name.
[ ] Is this a bug fix?
[X] Does this add functional enhancements (new features or extending existing features) ?
[X] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Character Sheet Info Roll20 Internal Use only.


Run Time error on using use-deep-compare-effect

This NPM component now throws an error if only primitives are in the dependency list.
The error is for one or more useEffect() functions (4 total) used in gitea-react-toolkit 's useFile.js.

@elsylambert @cckozie
In this case, the whole app would crash with error about use-deep-compare-effect with primitives
We do not believe this happens any more (build 20-936fafa)

translationCore Create - v1.1.0-rc.4 build 20-936fafa works fine without crash.


Port min agent version fix

DTL and DTA task need to update to M104 agent to take Register-Environment json fix.

Signed off offline (@chshrikh)


add dropForeign arg type for single column

@capaj
  types/index.d.ts:1862:29
  ✖  1862:29  readonly type modifier is only permitted on array and tuple literal types.

@kibertoad should be good now

Thanks!

Released in 0.95.3.


ability to forward custom events

Currently there is no easy/transparent way of forwarding custom events from the tooltip's component to the parent.

Hello, sorry for the late reaction. Can you tell me what exactly do you need to be solved?

Hello, due svelte component events doesnt bubble and its impossible to forward all events to parent I added the anchorNode to the props of the created tooltip component
With 1.1.4 you can use

Testooltip

Hello {name}!

Visit the Svelte tutorial to learn how to build Svelte apps.

  Hover

@FluffyDiscord please tell me if this solves your problem


Added required packages for Linux

Without these packages, you won't be able to build libGame.HotReload.6.so on Linux (when recompiling scripts in a project containing C++ scripts).
Note: These are also dependencies for building Flax Engine, so if you have built it from source you will naturally not notice this issue, as you will already have them installed. It happened to me when using the pre-built Linux editor here: https://vps2.flaxengine.com/store/builds/Package_1_04_06334/FlaxEditorLinux.zip.
Installing these dependencies fixed the problem for me.
Using ldd I've verified that libGame.HotReload.6.so depends on these libraries.

Good catch. But I think we should fix the game scripts linkage so it doesn't depend on those core-libs - just engine does.


Keys.CAN_PLACE_AS_BLOCK doesn't actually work

In CanPlaceAsBlockValueProcessor and FallingBlockDataProcessor
It sets the field canSetAsBlock, which is an incorrectly named field
(See https://github.com/ModCoderPack/MCPBot-Issues/issues/285)
I'm not sure if setting this value should also stop the fallingblock from despawning when it hits a block because that would be a useful feature. (Basically I want to be able to move a fallingblock freely without worrying about it suddenly despawning when it touches a block beneath).
Also, the value is not persisted in the NBT so it will loose it's value on a server restart.

I noticed this issue the other day when porting CraftBook's BetterPhysics over. It appears the value is just inverted.

https://github.com/SpongePowered/SpongeCommon/commit/6f8b39afdaaa693041e6658e1e0b1a9604a5d3a4


fix: reduce solc runs for etherscan compatibility

When using too many solc runs on contracts in this repo, the Etherscan api returns the error: "Invalid runs parameter (allowed range from 0 to 1000000)". I propose reducing this as I don't think the extra 1 million runs will help much. I ended up manually changing the "runs" variable in the artifacts files in "deployments" after I already deployed in order to accommodate Etherscan.

Thanks @benkostr I am going to recompile the artifacts to take that into consideration


Close option menu on tap outside

Closes #230
The option menu doesn't dismiss if navigation bar is tapped because touch event can not be handled for navigation controller

The option menu doest close when the textfield, paste button, send max button and send button is clicked


Fix Malformed Json in .all-contributorsrc

Fix malformed json
Description: ✍

Issue(s): 🎟

Visual: 🔍

Reference(s): 📖

@all-contributors please add themacexpert for maintenance, content, and documentation.


threads limitatiton and "Error in if (sol_epgap > opt$epgap) { : the condition has length > 1"

Hello,
This error message is from jabba with R 4.3.3 and gurobi.
Is this a bug of jabba?
Another problem is Gurobi is using all cores instead of my setting jba --cores 3.
I've tried using echo "Threads 1" > gurobi.env, but It seems not working.
https://support.gurobi.com/hc/en-us/articles/14126085438481-How-do-I-set-parameters-in-Gurobi
It's ends up that gGnome::run_gurobi did not set threads limitation:
    ## params
    params = list()
    if (!is.null(control$epgap)) {
        params$MIPGap = control$epgap
    }
    if (!is.null(control$tilim)) {
        params$TimeLimit = control$tilim
    }
    if (!is.null(control$trace)) {
        params$LogToConsole = ifelse(control$trace > 0, 1, 0)
    }

    ## TODO: set up env list for running on compute cluster

    ## run gurobi
    sol = gurobi::gurobi(model = model, params = params)

And in jbaMIP :
sol = gurobi::gurobi(model, params = c(list(TimeLimit=tilim), list(...)));

I turned this packages into a script and solved these anyway.
detected no tier 1 junctions
No duplicate Tier 1 junctions detected
Grabbing available memory...
Currently used: 1132.1 Mb
Allowed: 16000 Mb
Treemem: 13867.9 Mb
creating copy of input gGraph
Checking inputs
adding l0 penalty indicator
adding delta constraints for LP
Unique cids (A): 377724
Unique cids (b): 377724
Number of variables: 374440
bvec length: 377724
Amat nrow: 377724
Starting optimization with gurobi!
Gurobi Optimizer version 10.0.3 build v10.0.3rc0 (linux64)

CPU model: Intel(R) Xeon(R) Gold 5218R CPU @ 2.10GHz, instruction set [SSE2|AVX|AVX2|AVX512]
Thread count: 40 physical cores, 40 logical processors, using up to 32 threads

Optimize a model with 377724 rows, 374444 columns and 808884 nonzeros
Model fingerprint: 0x9a945994
Variable types: 180492 continuous, 193952 integer (66896 binary)
Coefficient statistics:
  Matrix range     [1e-01, 1e+03]
  Objective range  [6e-01, 4e+05]
  Bounds range     [1e+03, 1e+03]
  RHS range        [8e-02, 2e+01]
Found heuristic solution: objective 2.587947e+07
Presolve removed 409025 rows and 444930 columns (presolve time = 9s) ...
Presolve removed 368988 rows and 363824 columns
Presolve time: 9.41s
Presolved: 8736 rows, 10620 columns, 28087 nonzeros
Found heuristic solution: objective 2873465.6700
Variable types: 3625 continuous, 6995 integer (3498 binary)

Root simplex log...

Iteration    Objective       Primal Inf.    Dual Inf.      Time
       0    7.2680484e+05   4.470832e+02   0.000000e+00     10s
    4814    7.2716900e+05   0.000000e+00   0.000000e+00     10s

Root relaxation: objective 7.271690e+05, 4814 iterations, 0.03 seconds (0.01 work units)

    Nodes    |    Current Node    |     Objective Bounds      |     Work
 Expl Unexpl |  Obj  Depth IntInf | Incumbent    BestBd   Gap | It/Node Time

     0     0 727169.004    0 4340 2873465.67 727169.004  74.7%     -   10s
H    0     0                    1219078.8603 727169.004  40.4%     -   10s
H    0     0                    1082296.1985 727169.004  32.8%     -   10s
H    0     0                    1079457.7230 727169.004  32.6%     -   10s
H    0     0<PHONE_NUMBER>7 727169.004  18.0%     -   10s
H    0     0<PHONE_NUMBER>7 727169.004  17.7%     -   10s
     0     0 760787.893    0 2877 883049.786 760787.893  13.8%     -   10s
H    0     0<PHONE_NUMBER>1 760787.893  12.6%     -   10s
H    0     0<PHONE_NUMBER>2 760787.893  12.1%     -   10s
H    0     0<PHONE_NUMBER>0 760787.893  10.5%     -   10s
H    0     0<PHONE_NUMBER>0 785052.588  4.39%     -   10s
     0     0 785056.039    0 2052 821108.892 785056.039  4.39%     -   10s
     0     0 785069.364    0 2059 821108.892 785069.364  4.39%     -   10s
H    0     0<PHONE_NUMBER>3 813927.750  0.32%     -   10s
     0     0 814026.919    0  105 816524.741 814026.919  0.31%     -   10s
H    0     0<PHONE_NUMBER>5 814026.919  0.26%     -   10s
H    0     0<PHONE_NUMBER>3 814161.371  0.10%     -   10s
     0     0 814161.371    0   47 815006.177 814161.371  0.10%     -   10s
     0     0 814266.988    0   28 815006.177 814266.988  0.09%     -   10s
H    0     0<PHONE_NUMBER>7 814266.988  0.05%     -   11s
H    0     0<PHONE_NUMBER>7 814266.988  0.04%     -   11s
H    0     0<PHONE_NUMBER>9 814266.988  0.00%     -   11s
     0     0 814299.273    0    9 814300.384 814299.273  0.00%     -   11s

Cutting planes:
  Gomory: 197
  Implied bound: 99
  MIR: 2993
  StrongCG: 1
  Flow cover: 13
  RLT: 21
  Relax-and-lift: 81

Explored 1 nodes (8408 simplex iterations) in 11.20 seconds (5.87 work units)
Thread count was 32 (of 40 available processors)

Solution count 10:<PHONE_NUMBER>17 814706 ... 870403

Optimal solution found (tolerance 1.00e-05)
Best objective 8.143003839902e+05, best bound 8.142992729000e+05, gap 0.0001%
CPLEX epgap 1.3644720798363e-06 with solution status
JaBbA 2024-11-14 11:09:42.829018: Recording convergence status of subgraphs
JaBbA 2024-11-14 11:09:50.792997: simplifying segments in JaBbA graph but keeping all edges (including copy 0), dumping to jabba.rds
JaBbA 2024-11-14 11:10:00.536339: Checking for hets
JaBbA 2024-11-14 11:10:00.800193: Skipping loose end annotation
JaBbA 2024-11-14 11:10:00.800695: Saving results
JaBbA 2024-11-14 11:10:13.249471: Generating figures
JaBbA 2024-11-14 11:10:42.222631: Done .. job output in: /data/person/cells/taokj/chenja/chromothripsis/3.gGnome/NANT01002-T0-3A
Error in if (sol_epgap > opt$epgap) { : the condition has length > 1
Calls: suppressPackageStartupMessages -> withCallingHandlers -> JaBbA
In addition: There were 26 warnings (use warnings() to see them)
Execution halted

So this error arises from a final guard which checks if the solution epgap meets the threshold. I would double check the opt$epgap being passed, because this error indicates that it's passed as multiple values instead of a single number.

And this is another bug:
JaBbA 2024-11-16 13:25:14.650338: Number of gaps with nonzero width: 6732
JaBbA 2024-11-16 13:25:14.650628: Number of segments before gap filtering: 27165
JaBbA 2024-11-16 13:25:15.206296: 20433 segments produced after gap filtering
JaBbA 2024-11-16 13:25:17.242545: Brand new function for reciprocal junctions calling.
..
JaBbA 2024-11-16 13:25:18.447472: Excluding 1 aberrant junctions whose both breakpoints are in NA coverage regions
JaBbA 2024-11-16 13:25:18.448: Cancel nudge for 18 aberrant junctions where one of the 2 breakpoint is in NA coverage regions
JaBbA 2024-11-16 13:25:18.448293: In sum, we are forcing 0 junctions, excluding 1 junctions, and nudging 14 junctions
JaBbA 2024-11-16 13:25:19.293571: Excluding aberrant junctions: 509
JaBbA 2024-11-16 13:25:19.377128: Adjusting the kag (naive solution) as mipstart (initial solution).
Error in `:=`(cn, cnmle) :
  Check that is.data.table(DT) == TRUE. Otherwise, :=, `:=`(...) and let(...) are defined for use in j, once only and in particular ways. Note that namespace-qualification like data.table::`:=`(...) is not supported. See help(":=").
Calls: suppressPackageStartupMessages ... [.data.frame -> := -> stopf -> raise_condition -> signal
In addition: Warning messages:
1: JaBbA 2024-11-16 13:24:39.904294: Tier field tier missing: giving every junction the same tier, i.e. all have the potential to be incorporated
2: JaBbA 2024-11-16 13:25:15.248105: Skipping over karyograph creation because file already exists and overwrite = FALSE
3: `clusters()` was deprecated in igraph 2.0.0.
ℹ Please use `components()` instead.
4: `graph.adjacency()` was deprecated in igraph 2.0.0.
ℹ Please use `graph_from_adjacency_matrix()` instead.
5: In `[.data.table`(junc.dt, , `:=`(from = NULL, to = NULL)) :
  Tried to assign NULL to column 'from', but this column does not exist to remove
6: In `[.data.table`(junc.dt, , `:=`(from = NULL, to = NULL)) :
  Tried to assign NULL to column 'to', but this column does not exist to remove
Execution halted


Scrolling is broken when adding lots of fields to the column.yaml

The table view used for creating the model list only works if you have less rows that can fit on the screen. If you have, lets say, a hundred rows there, the table is scrolled to the bottom and the top section (the orange part) is not visible. You cannot scroll up.
The same thing works in the database table view.
It seems that the model list view is missing some js scrolling functionality.
If you give me a directon on where to fix it, I could create a PR myself.

Closing as it has been over a month since any activity on this occurred.


Agdigger 222

JIRA
https://issues.jboss.org/browse/AGDIGGER-222
As part of the linked JIRA saw some small issues that can be fixed quickly.

@laurafitzgerald I am curious about this commit: https://github.com/aerogear/digger-installer/pull/99/commits/1c8a974d9e6c7627ab0a1bf0638192753eb231dd
Can you elaborate please?

@aliok it is the same as this change without it the deploy tag cannot be used. To skip a task you have to provide all tags related to the task for it to be skipped.

Merging


docs: improve docs

add explanation to the code base to help other developers understand and contribute to the project easly

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.589%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1270

Relevant Lines:
1278

💛  - Coveralls

@its-dibo Thank you!


[BUG] QR codes with invoices are missing lightning: prefix

Describe the bug

QR codes that encode LN invoices are missing "lightning:" prefix
this happens in Wallet, Events, TPoS, Cashu, ..., literally everywhere
when QR code is missing the prefix, the generic QR code scanner (in iOS camera) does not now what app should it open and by default it tries to open Google Search

To Reproduce
Steps to reproduce the behavior:

Generate invoice QR code
Try to scan with iOS Camera
Observe that the scanned link leads to browser search not to a lightning wallet

Expected behavior
I expect the link will lead to an app that can pay the invoice
Screenshots

Desktop (please complete the following information):

LNbits version: https://legend.lnbits.com/ => 0df81e5aaf6ea74487356cd0c4b1b2774cefad0c

Besides adding the prefix I thought it could be also nice to make the QR content upper case. It saves space for some reason.

Besides adding the prefix I thought it could be also nice to make the QR content upper case. It saves space for some reason.

Yes, QR encoding is more efficient when only using upper-case. That said, this opens another can of worms, because lots of wallets do not understand/register the "LIGHTNING:" prefix, they only understand/register the "lightning:" prefix. So you either use "lightning:lnbc1..." or "lightning:LNBC1..." but not "LIGHTNING:LNBC1..."

I think this got fixed in https://github.com/lnbits/lnbits/pull/1253 - thanks @iWarpBTC!


Issue with /docs/getting-started-guides/kubeadm/

Dear Kubernets
Today I install the k8s .firstly ,I run the yum update to update all the rpm  in the centos 7 .
Then  i find my docker version is updated and  now released at 17.03.0-ce (2017-03-01) .but i dont notice it .
Then I install the kuberntes .
When i install the master ,everything is fine .
but when i run  the( yum install kubernetes-node  ) in the mirror,i find one issue
---> Package yajl.x86_64 0:2.0.4-4.el7 will be installed
--> Processing Conflict: docker-engine-17.03.0.ce-1.el7.centos.x86_64 conflicts docker
--> Processing Conflict: docker-engine-17.03.0.ce-1.el7.centos.x86_64 conflicts docker-io
--> Processing Conflict: docker-engine-selinux-17.03.0.ce-1.el7.centos.noarch conflicts docker-selinux
--> Finished Dependency Resolution
Error: docker-engine conflicts with 2:docker-1.12.5-14.el7.centos.x86_64
Error: docker-engine-selinux conflicts with 2:container-selinux-1.12.5-14.el7.centos.x86_64
You could try using --skip-broken to work around the problem
You could try running: rpm -Va --nofiles --nodigest
[root@minion1 7]#
I use the docker.yum resource to install it .I can not install the node now ,can anyway solve it ,thanks.

@skytalemcc Thanks for opening this issue. It looks like you're seeking technical support rather than reporting an issue with the docs. I encourage you to bring your question to the #kubernetes-users channel in Kubernetes slack.


release preparation for 0.70.0

good morning maintainers.
we got a pretty good list of things unreleased in this milestone so was planning on cutting 0.70.0 even though we have a few duplicate dependents for the rustls branch
suggested highlights:
Support for EC keys with rustls
This was one of the big blockers for using rustls against clusters like k3d or k3s
While not sufficient to fix using those clusters out of the box, it is now possible to use them with a workarodund
More ergonomic reconciler
The signature and end the Ok action in reconcile fns has been simplified slightly, and requires the following user updates:
-async fn reconcile(obj: Arc<MyObject>, ctx: Context<Data>) -> Result<ReconcilerAction, Error> {
-    ...
-    Ok(ReconcilerAction {
-        requeue_after: Some(Duration::from_secs(300)),
-    })
+async fn reconcile(obj: Arc<MyObject>, ctx: Context<Data>) -> Result<Action, Error> {
+    ...
+    Ok(Action::requeue(Duration::from_secs(300)))

The Action import lives in the same place as the old ReconcilerAction.

will send this out tomorrow morning

closed by https://github.com/kube-rs/kube-rs/commit/4e542a6434fc14e678c7f9471dcb2282f67814ae


go 1.22

Go 1.23 was released yesterday https://go.dev/blog/go1.23, so it's time to catch up with the previous 1.22 release https://go.dev/blog/go1.22
The previous attempt: https://github.com/neondatabase/autoscaling/pull/938, probably, failed because of the older k8s version, let's see if it works now

Not that fast 😄
...
Generating deepcopy funcs
Generating clientset for neonvm:v1 at github.com/neondatabase/autoscaling/neonvm/client/clientset
Generating listers for neonvm:v1 at github.com/neondatabase/autoscaling/neonvm/client/listers
Generating informers for neonvm:v1 at github.com/neondatabase/autoscaling/neonvm/client/informers
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xa0de8f]
...


Update deprecated github actions

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-python@v2, actions/upload-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

https://github.com/nomonosound/fast-align-audio/commit/e4d67f6a246378ae324606fadbc5cb3f4436b183
https://github.com/nomonosound/fast-align-audio/commit/be39cd54e0c51f8a8e2110d27f23253abc0adc7f


Add optional acorn options.

Part of multiple pull-requests, so acorn options can flow like:
module-deps -> detective
Also see:
https://github.com/substack/node-detective/pull/69

Does it need more work?


Allow use of model instance in belongsTo/hasMany

Eliminates need for class_basename in  relations using container return $this->belongsTo(app('user'), 'creator_id');
TestModelStub checks for table existence before creation
Refactored createModelStub to helpers for use in tests by multiple packages.

Issue #50


Prevent random shuffle being correct order

Sometimes the random shuffle will actually be in the correct order. We need to keep shuffling until the order is not the same as the answer order.

This will have to be shuffled once on the editor side. If we reshuffle on viewer side we have no answers to check against so there would be always a chance that a random order might be the correct order.


Initial popover height max: The hovered window does not reach the bottom of the view

Thanks for your great plugin.
Is there a max for the initial popover height setting?
The higher value I give, the more the windows starts at the top, that's what I expect. At 1200 px. the window starts at the top. But the bottom of the hovered windows does not reach to the bottom.
Settings

400px

800px

1200px

The window doesn't get higher with changing to 1200px.

Could you please enhance this maximal possible value?

Huh.  Well, I'm gonna have to ping @nothingislost on this one, because it's something in InteractJS doing it.  Initially it sets the height as requested, but then an InteractJS "move" event occurs, and then it resizes.  I'm pretty sure the purpose of the resizing is to keep it within the screen boundaries, but the calculation is coming up with 703.3333px for some reason (at least on my machine) instead of the actual screen height.  I don't know where it's getting that from, it seems to be calculated somewhere deep inside InteractJS.

Huh.  I found a bit of the code that restricts the maximum size to 2/3rds of the window size (height and width).  Not sure what that's about.  As a workaround, you can edit your main.js and change the  offsetHeight/1.5 and offsetWidth/1.5 to remove the /1.5 part, which will make the maximum the size of the window rather than 2/3rds of the window.

Thank you very much for this tip, it works:

@merlinuwe unrelated but what theme is this?

Magic user theme with "moon" selected.
https://github.com/drbap/magicuser-theme-for-obsidian