MAPREDUCE-7466. WordMedian example fails to compute the right median

The WordMedian example does not correctly handle the case where the median falls exactly between two different values (e.g., the median word legth of "Hello Hadoop" should be 5.5).
This affects both the example and its test (i.e., TestWordStats).
See https://issues.apache.org/jira/browse/MAPREDUCE-7466

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 50s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
47m 17s

trunk passed

+1 :green_heart:
compile
0m 27s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 25s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 28s

trunk passed

+1 :green_heart:
mvnsite
0m 30s

trunk passed

+1 :green_heart:
javadoc
0m 31s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 28s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 50s

trunk passed

+1 :green_heart:
shadedclient
37m 27s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 19s

the patch passed

+1 :green_heart:
compile
0m 19s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 19s

the patch passed

+1 :green_heart:
compile
0m 18s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
0m 18s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 16s

the patch passed

+1 :green_heart:
mvnsite
0m 21s

the patch passed

+1 :green_heart:
javadoc
0m 21s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 20s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 47s

the patch passed

+1 :green_heart:
shadedclient
37m 34s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 49s

hadoop-mapreduce-examples in the patch passed.

+1 :green_heart:
asflicense
0m 33s

The patch does not generate ASF License warnings.

135m 10s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6386/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6386

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux c7b53ed404ab 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 7fb6af55037af4c66585c2d1e518187d77edb4fc

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6386/1/testReport/

Max. process+thread count
529 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-examples U: hadoop-mapreduce-project/hadoop-mapreduce-examples

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6386/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


Multi-threading in CBC on Windows 10

I am trying to run the CBC_MIXED_INTEGER_PROGRAMMING  solver with multi-threads in the ortools on Windows 10 but it seems to not accept the thread argument.
When I do
solver = pywraplp.Solver('', pywraplp.Solver.CBC_MIXED_INTEGER_PROGRAMMING)
solver.SetNumThreads(24)

with the problem and then solver.Solve(), it printed
No match for threads - ? for list of commands
No match for 24 - ? for list of commands

on the terminal, and only use 1 core of my CPU. If I don't specify solver.SetNumThreads(24), then it also use one core. However, when I run the same code on macOS, it can run multi-threads automatically.
I read from a recent issue on the CBC repo that they are providing parallel version of the binaries. I was wondering if the or-tools has include that already?
I have also tried to build from the source of or-tools but it stopped with the error
...
copy dependencies\sources\Cbc-2.10.3\Cbc\MSVisualStudio\v10\x64-v142-Release\*.lib dependencies\install\lib\coin
The system cannot find the path specified.
tools\make: *** [dependencies\install\bin\cbc.exe] Error 1

By default, we build cbc on windows ourselves, we we use the visual studio solution for that.
I do not know how to enable parallel solve using this.
You can try building from source, and overriding the cbc path to use one from the binary distribution.  This may require  some tweaking of the makefiles.
This being said, I am not sure it is worth the effort. I do not recommend CBC even if it is the best open source free for all MIP solver available.

I see. I have no choice other than using CBC since it is the only free MIP solver that I can found now.


ESP32-C6 support

Building SlimeVR for a ESP32-C6 (with better WiFi) i get some compiler errors like:
src/defines_sensitivity.h:53:46: error: either all initializer clauses should be designated or none of them should be
This MR fixes this, by just adding a designation to all initializer values.
How to reproduce, use the following config:
[env:esp32c6]
platform =  https://github.com/tasmota/platform-espressif32/releases/download/2024.04.14/platform-espressif32.zip
board = esp32-c6-devkitc-1

Also had to use the existing ESP32C3 functionality for I2C as well as the 2s wait during startup.
I don´t have a working IMU right now, as the chip did not arrive yet. However i can see the I2C Scans on the listed pins on my scope, so i guess it will work, once there is an IMU connected.

Also, feel free to PR the PlatformIO.ini changes in a new PR so it can be automatically checked through CI. Don't forget to also change the platformio-tools.ini.

Ok i will add a littlebit more, as the I2C does not work yet, i will append it to this MR!

B.t.w. the code in icm20948sensor.cpp does not make any sense to me:

ICM20948_ODRGYR and ICM20948_ODRAXL will be 1 no matter which branch is choosen..

Ok seems to work fine, got my BMI160 sensors today: https://www.youtube.com/shorts/CuVVX6oVG7U

B.t.w. the code in icm20948sensor.cpp does not make any sense to me:
ICM20948_ODRGYR and ICM20948_ODRAXL will be 1 no matter which branch is choosen..

Oddly the ESP32-S2 can not handle as much I2C traffic as the ESP8266 or the ESP32-C3 or at least when i did test it i had often Buffer overflows on ESP32-S2.

Made most of the changes requested.
Ports
I added all ports of the ESP32-C6 excluding the USB pins used for serial communication and the UART TX/RX.
I2C retries
Removed it as it does not seem to be necessary
Small things

Removed the boot delay (wasn´t required)
Removed special case handling for one sensor which has it for the C3 as well but which did essentially nothing

platformio ESP32-C6 arduino support
Unfortunately the "official" platformio platform-espressif32 package still does not support any C6 board with the arduino framework.
The only two supported C6 boards in platformio are 'esp32-c6-devkitc-1' and 'esp32-c6-devkitm-1' both list only 'espidf' as framework, even on the develop branch.
Support for the C6 was added by espressif to espressif/arduino-esp32 in 3.0.0 though. So support is probably comming to platformio sooner or later in the official packages.
For now have to stick to the tasmoto platform-espressif32.


[MRG] Update change log in preparation for releasing v0.9.0

ref #658
cc @choldgraf

@betatim are we gonna hold off for #662 or not? WDYT?

I'd merge this independently of #662 as that PR isn't merged yet it can take care of adding to the change log. Here I tried to tied up after our past sloppiness of not adding to the change log straight away.

ok - I think I'll give the new release a shot tomorrow if I have a moment, for now I need to go to a graduation ceremony (it's that time of year)


Add Font tests, implement missing APIs, fix compat

@hughbe,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

Yeah the tests are all the same thing - I think I've broken something in GdipGetFontHeightGivenDpi

I've just updated the PR to fix the unit test failures.
The problem is actually in existing libgdiplus code that indirectly calls GdipCreateFont. I put in a FIXME for later


vimPlugins.coc-spell-checker: Add override and node dependency

Motivation for this change
I made https://github.com/NixOS/nixpkgs/pull/82613 and found out through https://github.com/NixOS/nixpkgs/pull/72506 that I probably have to add an override in order to make the plugin actually work.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

conflicts
I'm closing this PR due to lack of activity, if the PR author would like to pursue this matter again, please re-open the PR and address the concerns.


little confused about the weights and parameters

is there somewhere with more documentation explaining the settings?

Hello, just now, I wrote a blog about the expression of the weights parameter of Latent Couple on AI-generated images.
My blog link: http://wildgun.net/2023/03/test_weights_of_latent_couple/
My blog is written in Chinese. But I think you can use the translation tool, or read the prompt text, and view the generated (more than 64!) pictures arranged in 4 tables to help understand the overall and partial performance of weights on the picture.
(This reply is translated using GoogleTranslate)

Hello, just now, I wrote a blog about the expression of the weights parameter of Latent Couple on AI-generated images.
My blog link: http://wildgun.net/2023/03/test_weights_of_latent_couple/
My blog is written in Chinese. But I think you can use the translation tool, or read the prompt text, and view the generated (more than 64!) pictures arranged in 4 tables to help understand the overall and partial performance of weights on the picture.
(This reply is translated using GoogleTranslate)
Thank you, nice work. How did you use values over 1, i get an error.

Hello, just now, I wrote a blog about the expression of the weights parameter of Latent Couple on AI-generated images.
My blog link: http://wildgun.net/2023/03/test_weights_of_latent_couple/
My blog is written in Chinese. But I think you can use the translation tool, or read the prompt text, and view the generated (more than 64!) pictures arranged in 4 tables to help understand the overall and partial performance of weights on the picture.
(This reply is translated using GoogleTranslate)

Thank you, nice work. How did you use values over 1, i get an error.

Just change the values of weights but DO NOT click Visualize,it works(image is changed ,and new values(>1 or <0) is written into the pnginfo).
This seems to work.
Well,Should I click 'Visualize' every time after I changed the values? I didn't do that...


0.13.0

Coverage remained the same at 58.442% when pulling a457a1956cc51d99f8c00c8784f926800de93919 on v0-13-0 into 7e61fe55fac5998be31936153ff8075f3ebbe295 on master.


Getting "index.html doesn't exist in archive" when creating PDF from static html

Expected Behaviour
An extremely basic  PDF to be generated.
Actual Behaviour
The error
com.adobe.pdfservices.operation.exception.ServiceApiException: description ='index.html doesn't exist in archive.; requestId=341e7228-c0f5-4d5f-8fe2-bb1cd2a85587'; requestTrackingId='341e7228-c0f5-4d5f-8fe2-bb1cd2a85587'; statusCode=400; errorCode=MISSING_INDEX_HTML 	at com.adobe.pdfservices.operation.internal.api.PlatformApi.statusPoll(PlatformApi.java:115) 	at com.adobe.pdfservices.operation.pdfops.CreatePDFOperation.execute(CreatePDFOperation.java:209)
Reproduce Scenario (including but not limited to)
I've attached the zip
Steps to Reproduce
Create an html file called index.html with this content
<!DOCTYPE html>

     <meta charset="UTF-8">
     <title>basic</title>

TEST

Then use this example provided on the git page to create a PDF https://github.com/adobe/pdfservices-java-sdk-samples/blob/release_3.5.1/src/main/java/com/adobe/pdfservices/operation/samples/createpdf/CreatePDFFromStaticHTML.java
Platform and Version
pdfservices-sdk 3.5.1 with Java 8
Sample Code that illustrates the problem
Create an html file called index.html with this content
<!DOCTYPE html>

     <meta charset="UTF-8">
     <title>basic</title>

TEST

Then use this example provided on the git page to create a PDF https://github.com/adobe/pdfservices-java-sdk-samples/blob/release_3.5.1/src/main/java/com/adobe/pdfservices/operation/samples/createpdf/CreatePDFFromStaticHTML.java
example.zip
Logs taken while reproducing problem

example.zip

index.html has to be at the top level of the .zip not inside a folder. Like this one
example_2.zip

Thanks Joel you are correct. That was a dumb mistake on my part, appreciate u taking the time to help.

Closing this issue since it has been idle since long. Please feel free to reopen the issue if required.


Disable move up

Can we have a prop to disable move up?

Yes I can add it, also I am thinking to rewrite this library completely :)

Awesome! Because it's one of component that i most use in my current system, and we doesn't have a lot packages for bottom sheet in Vue 3/Nuxt3.
I think as a feature we could has a prop to disable move up and swipe on the content, moving down, close the bottom sheet, cause today it's oly works on the "header"/"picker" of the component

I am planning to make whole content swipeable (background, header, content etc.) but if the user is not scrolling the content.
Surely I can add prop to disable swiping.
I'm also trying some velocity stuff, if user swipes fast animation will be faster etc

I will be thankfull if you make this!!

I started to rewrite whole library in https://github.com/kadiryazici/bottom-sheet-vue3/pull/3.
Rewritten version is using Element.animate and <Transition> element, old one was using setTimeout 🤮.
In old one, move up was a fake div under the sheet but in this version height changes so content gets bigger, this will be nice on stops feature I am thinking to add.
When user swiped if it is close to a spot, sheet height will change to fit that spot.
Current idea (may change):
<Sheet
  spots={[
    {
      height: '400px'
    },
    {
      height: '600px'
    }
  ]}
/>

On mount, none of spots will be used.
Threshold
I was thinking to add velocity based threshold, the idea is if you set 200 as threshold it means that user should swipe at least 200 pixsels in 0.3 seconds or 400 pixels in 0.6 seconds or 600 pixels in 0.9 seconds or.........

@hamonCordova I released version 1.0.0, it is a major version so changed some props and added new props. Also default sheet behavior is changed.

I'm so happy, @kadiryazici, thank you for all. I really appreciate your time and efort. I will test it soon


pcluster create hangs in step "Status: MasterServer - CREATE_IN_PROGRESS" when using custom AMI

Environment:

AWS ParallelCluster 2.3.1
Scheduler: default
Master instance type: t1.micro
Compute instance type: m5.24xlarge (spot)

I created a custom AMI following these steps https://aws-parallelcluster.readthedocs.io/en/latest/tutorials/02_ami_customization.html based on the AMI (eu-west-3 / ubuntu 16.04) ami-02de781189ccb9f92
When I execute pcluster create, the creation hangs in step "Status: MasterServer - CREATE_IN_PROGRESS". The master instance is created and running. I can log into it, but e.g. the scheduler software seems not to be installed.
The cloud-init* logfile are attached. There is no cfn*.log file.
cloud-init.log
cloud-init-output.log

Please note: the config file is below:
[cluster spot48]
vpc_settings = spot48-vpc
key_name = XXXX
compute_instance_type = m5.24xlarge
master_instance_type = t2.micro
initial_queue_size = 0
max_queue_size = 10
maintain_initial_size = false
cluster_type = spot
shared_dir = /shared
ebs_settings = sdshared
custom_ami = ami-XXXXX
[vpc spot48-vpc]
master_subnet_id = subnet-XXXX
vpc_id = vpc-XXXX
[global]
update_check = true
sanity_check = true
cluster_template = spot48
[ebs sdshared]
volume_size = 70
[aliases]
ssh = ssh {CFN_USER}@{MASTER_IP} {ARGS}

Hi @hkroeger
I see in your cloud-init.log the error:

Failed to get raw userdata in module rightscale_userdata

so it seems there are errors executing the user data of your custom ami.
I think the problem is that in your configuration you didn't set the base_os configuration parameters, so ParallelCluster is trying to use the default one (alinux), that is different from the one you selected at creation time.
You could retry by setting:
[cluster spot48]
...
base_os = ubuntu1604

Let us know if it helps.

Hi enrico,
I tried to set the "base_os" parameter before and the outcome was the same.
It's probably worth to note that the entire procedure works, if I use centos7 instead of ubuntu1604. Maybe the ubuntu1604 images is not so well maintained?
BTW, are there any plans to make ubuntu1804 available in parallelcluster?
Regards, Hannes

Hi @hkroeger

for Ubuntu18 support you can add a "+1" to the issue: https://github.com/aws/aws-parallelcluster/issues/984
for the Ubuntu16 Custom AMI we can try to replicate your issue if you need it.


gtk: add cursor theming support

Believe it or not, Catppuccin has cursors!

could this option be enabled in test.nix? also almost forgot: these commits should be prefixed with feat(gtk) or refactor(gtk) per our contributing guidelines

thanks!


x/build/maintner: GerritCL.Subject doesn't include entire subject if it's split across multiple lines

According to git behavior, the subject of a commit message is separated from the body a blank line. Most commit message subjects are short and fit in one line (hopefully under 50 characters). In some cases, they end up being split into multiple lines.
As one example, CL 8204 has a subject that is split across two lines.
Git reports the subject using both lines:
tools $ git log -1 --format='%s' 1e216dc2e33abac72c076ca48ead2dcb476c2ddc
goimports: create a var to permit custom implementations of flag parsing and startup work.

maintner.GerritCL.Subject cuts it off short:
fmt.Println(cl.Subject())

// Output:
// goimports: create a var to permit custom implementations of flag parsing and

/cc @bradfitz
Here's a complete list of CLs in the Go maintner corpus where the current Subject method cuts off the subject:

WARNING: cl 9467: cl.Subject() != firstParagraph(cl.Commit.Msg):
"image/gif: don't encode local color tables if they're the same as the"
vs
"image/gif: don't encode local color tables if they're the same as the\nglobal color table."

WARNING: cl 1538: cl.Subject() != firstParagraph(cl.Commit.Msg):
"fmt: fix bug in scanning of hex strings"
vs
"fmt: fix bug in scanning of hex strings\nCouldn't handle a hex string terminated by anything\nother than spaces. Easy to fix."

WARNING: cl 8907: cl.Subject() != firstParagraph(cl.Commit.Msg):
"image/color: have Palette.Index honor alpha for closest match, not just"
vs
"image/color: have Palette.Index honor alpha for closest match, not just\nred, green and blue."

WARNING: cl 132780: cl.Subject() != firstParagraph(cl.Commit.Msg):
"Ignore / close / delete."
vs
"Ignore / close / delete.\nThis CL is superseded by:\nhttps://go-review.googlesource.com/c/go/+/132781"

WARNING: cl 9238: cl.Subject() != firstParagraph(cl.Commit.Msg):
"image/jpeg: have the LargeImageWithShortData test only allocate 64 MiB, not 604"
vs
"image/jpeg: have the LargeImageWithShortData test only allocate 64 MiB, not 604\nMiB."

WARNING: cl 2753: cl.Subject() != firstParagraph(cl.Commit.Msg):
"unicode: added Merge func for creating RangeTables that are the union of"
vs
"unicode: added Merge func for creating RangeTables that are the union of\nother range tables or just an optimized table from a non-compacted\nuser-created table."

WARNING: cl 2480: cl.Subject() != firstParagraph(cl.Commit.Msg):
"math/big: faster \"pure Go\" addition/subtraction for long vectors"
vs
"math/big: faster \"pure Go\" addition/subtraction for long vectors\n          (platforms w/o corresponding assembly kernels)"

WARNING: cl 1251: cl.Subject() != firstParagraph(cl.Commit.Msg):
"cmd/gc: logical operators should produce untyped bool for untyped"
vs
"cmd/gc: logical operators should produce untyped bool for untyped\noperands"

WARNING: cl 8841: cl.Subject() != firstParagraph(cl.Commit.Msg):
"image/jpeg: don't assume that an ensureNBits failure implies that we can"
vs
"image/jpeg: don't assume that an ensureNBits failure implies that we can\ncall unreadByteStuffedByte."

WARNING: cl 1575: cl.Subject() != firstParagraph(cl.Commit.Msg):
"The problem is :"
vs
"The problem is :\nOnce new comers who never installed golang on his pc (or laptop)\nThey need to know how to configure GOPATH and GOROOT."

WARNING: cl 14171: cl.Subject() != firstParagraph(cl.Commit.Msg):
"time: correct handling of \"5\" in layout string by Format() and"
vs
"time: correct handling of \"5\" in layout string by Format() and\nAppendFormat()"

WARNING: cl 151981: cl.Subject() != firstParagraph(cl.Commit.Msg):
"fs: add download attribute to HTML of dirList"
vs
"fs: add download attribute to HTML of dirList\nUpdate the dirList HTML output to include the download attribute in link tags."

WARNING: cl 1850: cl.Subject() != firstParagraph(cl.Commit.Msg):
"net/url: Fixed url parsing with invalid slashes"
vs
"net/url: Fixed url parsing with invalid slashes\n         after scheme"

WARNING: cl 9712: cl.Subject() != firstParagraph(cl.Commit.Msg):
"image/gif: allow encoding a single-frame image whose top-left corner"
vs
"image/gif: allow encoding a single-frame image whose top-left corner\nisn't (0, 0)."

WARNING: cl 9465: cl.Subject() != firstParagraph(cl.Commit.Msg):
"image/gif: check that individual frame's bounds are within the overall"
vs
"image/gif: check that individual frame's bounds are within the overall\nGIF's bounds."

WARNING: cl 3953: cl.Subject() != firstParagraph(cl.Commit.Msg):
"reflect: for struct tags, reject control chars (including tabs) in keys,"
vs
"reflect: for struct tags, reject control chars (including tabs) in keys,\nand empty keys. Also reject malformed (quoted) values."

WARNING: cl 5006: cl.Subject() != firstParagraph(cl.Commit.Msg):
"image: change Rectangle.Eq to return true for all empty rectangles, even"
vs
"image: change Rectangle.Eq to return true for all empty rectangles, even\nif their nominal Min and Max points differ."

WARNING: cl 8073: cl.Subject() != firstParagraph(cl.Commit.Msg):
"image/color: have YCbCr.RGBA work in 16-bit color, per the Color"
vs
"image/color: have YCbCr.RGBA work in 16-bit color, per the Color\ninterface."

WARNING: cl 1926: cl.Subject() != firstParagraph(cl.Commit.Msg):
"cmd/gc: Add more-descriptive error message for when the programmer uses"
vs
"cmd/gc: Add more-descriptive error message for when the programmer uses\na type as an instance of itself"

WARNING: cl 1767: cl.Subject() != firstParagraph(cl.Commit.Msg):
"syscall: syscall.Readlink doesn't handle junction on windows"
vs
"syscall: syscall.Readlink doesn't handle junction on windows\nFixes #9190"

WARNING: cl 2591: cl.Subject() != firstParagraph(cl.Commit.Msg):
"spec: extend type omission rules for composite literal element values"
vs
"spec: extend type omission rules for composite literal element values\n      to map element keys"

WARNING: cl 5251: cl.Subject() != firstParagraph(cl.Commit.Msg):
"image/jpeg: support 16-bit quantization tables and Extended Sequential"
vs
"image/jpeg: support 16-bit quantization tables and Extended Sequential\nframes."

WARNING: cl 9480: cl.Subject() != firstParagraph(cl.Commit.Msg):
"debug/dwarf: Add function EntryLocation(entry, cfa) in location.go which"
vs
"debug/dwarf: Add function EntryLocation(entry, cfa) in location.go which\nreturns the address of an object, given its DWARF entry.  If the second\nparameter is non-nil, it contains the address of the stack frame the\nobject occurs in.  This is used when the object location is given as an\noffset relative to the stack frame address."

WARNING: cl 9270: cl.Subject() != firstParagraph(cl.Commit.Msg):
"image/png: don't silently swallow io.ReadFull's io.EOF error when it"
vs
"image/png: don't silently swallow io.ReadFull's io.EOF error when it\nlands exactly on an IDAT row boundary."

WARNING: cl 2267: cl.Subject() != firstParagraph(cl.Commit.Msg):
"encoding/json: encode large or unbounded structures to JSON"
vs
"encoding/json: encode large or unbounded structures to JSON\n- json.Encoder periodically flushes to its io.Writer\n- support JSON encoding of channel types"

WARNING: cl 6393: cl.Subject() != firstParagraph(cl.Commit.Msg):
"image/jpeg: distinguish between FormatError and UnsupportedError when"
vs
"image/jpeg: distinguish between FormatError and UnsupportedError when\nencountering unknown markers."

WARNING: cl 6421: cl.Subject() != firstParagraph(cl.Commit.Msg):
"image/jpeg: when following component selectors, only consider valid"
vs
"image/jpeg: when following component selectors, only consider valid\ncomponents."

WARNING: cl 9482: cl.Subject() != firstParagraph(cl.Commit.Msg):
"debug/dwarf: add SliceType, StringType, InterfaceType, MapType,"
vs
"debug/dwarf: add SliceType, StringType, InterfaceType, MapType,\nChanType.  These implement the dwarf.Type interface for the\ncorresponding Go types."

WARNING: cl 9463: cl.Subject() != firstParagraph(cl.Commit.Msg):
"draw: disable the image.Rectangle DstMask fast path until Go 1.5 is"
vs
"draw: disable the image.Rectangle DstMask fast path until Go 1.5 is\nreleased."

WARNING: cl 10072: cl.Subject() != firstParagraph(cl.Commit.Msg):
"vp8: limit all other partitions to 1<<24 bytes in size, not just N-1 of"
vs
"vp8: limit all other partitions to 1<<24 bytes in size, not just N-1 of\nthem."

WARNING: cl 7612: cl.Subject() != firstParagraph(cl.Commit.Msg):
"draw: make example_test more example-like, by being outside \"package"
vs
"draw: make example_test more example-like, by being outside \"package\ndraw\"."

WARNING: cl 4210: cl.Subject() != firstParagraph(cl.Commit.Msg):
"draw: new package, a superset of the standard library's image/draw"
vs
"draw: new package, a superset of the standard library's image/draw\npackage, including the ability to scale an image."

WARNING: cl 6914: cl.Subject() != firstParagraph(cl.Commit.Msg):
"math/f32, math/f64: add a comment that \"Aff\" stands for affine"
vs
"math/f32, math/f64: add a comment that \"Aff\" stands for affine\ntransformation."

WARNING: cl 9277: cl.Subject() != firstParagraph(cl.Commit.Msg):
"cmd/webp-manual-test: add a \"build ignore\" tag, so that \"go install"
vs
"cmd/webp-manual-test: add a \"build ignore\" tag, so that \"go install\ngolang.org/x/image/...\" doesn't install the manual testing program."

WARNING: cl 3051: cl.Subject() != firstParagraph(cl.Commit.Msg):
"webdav: make the memFS (not the memFSNode) the canonical source of a"
vs
"webdav: make the memFS (not the memFSNode) the canonical source of a\nfile name."

WARNING: cl 2535: cl.Subject() != firstParagraph(cl.Commit.Msg):
"webdav: implement parseDepth; restrict LockDetails' depth to only zero"
vs
"webdav: implement parseDepth; restrict LockDetails' depth to only zero\nor infinity."

WARNING: cl 1354: cl.Subject() != firstParagraph(cl.Commit.Msg):
"icmp: add support for windows"
vs
"icmp: add support for windows\nFixes #9253"

WARNING: cl 10394: cl.Subject() != firstParagraph(cl.Commit.Msg):
"webdav: Return HTTP 404 for PROPFIND/PROPPATCH requests on an inexistent"
vs
"webdav: Return HTTP 404 for PROPFIND/PROPPATCH requests on an inexistent\nwebdav.Dir resource."

WARNING: cl 3567: cl.Subject() != firstParagraph(cl.Commit.Msg):
"webdav: set the Lock-Token HTTP header when LOCKing existing files, not"
vs
"webdav: set the Lock-Token HTTP header when LOCKing existing files, not\njust new files."

WARNING: cl 10395: cl.Subject() != firstParagraph(cl.Commit.Msg):
"webdav: Simplify handling of Etag and Content-Type headers for GET, HEAD,"
vs
"webdav: Simplify handling of Etag and Content-Type headers for GET, HEAD,\nPOST and PUT requests."

WARNING: cl 4341: cl.Subject() != firstParagraph(cl.Commit.Msg):
"webdav: factor out a moveFiles function, and make the tests call that"
vs
"webdav: factor out a moveFiles function, and make the tests call that\ninstead of FileSystem.Rename directly."

WARNING: cl 3835: cl.Subject() != firstParagraph(cl.Commit.Msg):
"webdav: return 500 Internal Server Error and not 404 Not Found or 403"
vs
"webdav: return 500 Internal Server Error and not 404 Not Found or 403\nForbidden during copyFiles."

WARNING: cl 2302: cl.Subject() != firstParagraph(cl.Commit.Msg):
"webdav: add memFS, an initial implementation of an in-memory"
vs
"webdav: add memFS, an initial implementation of an in-memory\nfilesystem."

WARNING: cl 45931: cl.Subject() != firstParagraph(cl.Commit.Msg):
"DO NOT REVIEW"
vs
"DO NOT REVIEW\nDO NOT SUBMIT"

WARNING: cl 7531: cl.Subject() != firstParagraph(cl.Commit.Msg):
"goimports: add imports.Init to permit custom implementations of flag parsing and"
vs
"goimports: add imports.Init to permit custom implementations of flag parsing and\nstartup work."

WARNING: cl 8204: cl.Subject() != firstParagraph(cl.Commit.Msg):
"goimports: create a var to permit custom implementations of flag parsing and"
vs
"goimports: create a var to permit custom implementations of flag parsing and\nstartup work."

WARNING: cl 1680: cl.Subject() != firstParagraph(cl.Commit.Msg):
"build/androidtest.bash: script to run all tests in a repository on an"
vs
"build/androidtest.bash: script to run all tests in a repository on an\nandroid device."

WARNING: cl 1851: cl.Subject() != firstParagraph(cl.Commit.Msg):
"Fixed x11/egl with nvidia binary-only driver."
vs
"Fixed x11/egl with nvidia binary-only driver.\nStarted breaking the render commands out of the event pump.\nNeeds feedback."

WARNING: cl 16021: cl.Subject() != firstParagraph(cl.Commit.Msg):
"exp/sprite/portable: revert for /x/image/draw api"
vs
"exp/sprite/portable: revert for /x/image/draw api\nFix broken build that was broke by \"fix[ing] broken build\""

WARNING: cl 92737: cl.Subject() != firstParagraph(cl.Commit.Msg):
"Adding a unique error when no authentication method has been passed in"
vs
"Adding a unique error when no authentication method has been passed in\nyet."

According to git behavior, [...]

I could've been more convincing and brief by referencing git documentation, rather than trying to demonstrate behavior. It's documented at https://git-scm.com/docs/git-commit#_discussion:

Though not required, it’s a good idea to begin the commit message with a single short (less than 50 character) line summarizing the change, followed by a blank line and then a more thorough description. The text up to the first blank line in a commit message is treated as the commit title, and that title is used throughout Git.


No Horizontal Grid Lines / No Loop Region Highlight

Hello Lenninst!
First and foremost, I absolutely love your theme. It's so subtle and elegant!
Now, there's 2 small issues I'm seeing (but besides that it's just perfect):

There's no Horizontal Grid Lines (separating the tracks in the Arranger), only vertical ones. Is that something that can be fixed?
Same thing with the Loop Region, when turned on, there's no way to see within the Arranger where the Loop Region extends. Only the top scroll bar indicates where the region starts and stops.

Maybe these are limitation from the Theme Editor itself?

Hello, @Zacchino  😊
Thank you so much for your comment and for appreciating the theme. I'm really glad you like it.
I've looked into the issues you mentioned:

The absence of horizontal grid lines in the Arranger.
The lack of visibility for the loop region in the Arranger.

I've found a solution for these problems. However, I've been quite busy these days and haven't been able to implement it yet. I assure you that I'll fix it as soon as possible.
I appreciate your patience and your feedback, which is very valuable for improving the theme. I'll update this issue as soon as I have the solution implemented.
Best regards. 😁👍

Oh heck yeah! So much looking forward to it!
Sure sure I'll be patient. Let me know when done and I'll re-install the theme to try it out!
Thank you so so much again, this is a work of art!

Hi @Zacchino 👍 The solution is now ready in the latest GitHub  release .   Feel free to reinstall the theme and give it a try. Thanks for your patience and kind words. Let me know what you think once you've tested it. Hope you enjoy it! 😊

OMG This is it! You fixed both these issues perfectly!
Thanks SO much for taking the time for it 🙏
This theme is now perfect. It's such a pleasure to work on Bitwig with it:
Thanks again @lenninst !


CV should not report "Resource container link should have '*' language code"

As per my conversation with Robert,"* "instead of "en" notices are still not being disabled properly. We should not see those error messages in the Validation file.

Can anyone confirm what version of the CV package this is failing on? (I thought this was fixed on v1.0.1 but maybe not???)

Can anyone confirm what version of the CV package this is failing on? (I thought this was fixed on v1.0.1 but maybe not???)

I think from here which @mandolyte helpfully pointed me to, I can see that it's not yet using v1.0.1 where this is hopefully fixed.

I think from here which @mandolyte helpfully pointed me to, I can see that it's not yet using v1.0.1 where this is hopefully fixed.

Not seeing this error report in translationCore Create - v1.1.0-rc.4 build 18-e095e04. Looks good.

Not seeing this error report in translationCore Create - v1.1.0-rc.4 build 18-e095e04. Looks good.

Looks good in v1.1.0-rc.4 build 18-e095e04

Looks good in v1.1.0-rc.4 build 18-e095e04


.NET Core hosting tutorial

Adds a tutorial article and sample code demonstrating how to host the .NET Core runtime.
I made the sample for a customer who was interested in this scenario, recently, and I figured it made sense to persist in somewhere that would benefit more of the .NET community.
@gkhanna79, can you please review the tutorial and sample for technical accuracy (or recommend someone else who would be good at doing that)? Thanks!

Hi @mjrousos, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

We should also modify the toc file to add that topic in the TOC. Let me know if you need help with that.

All updated based on @mairaw and @rpetrusha's feedback.

Thanks, Ron. I've addressed all of those corrections.


initial commit of BinaryNinja import script

Just the import script for now. One feature I did add that might be worth pulling into the IDA script is to attempt to first load a .js or .json version of the exectuable/dll automatically if it exists since that seems like a common naming convention for capa outputs.
Two remaining (larger!) tasks are to implement a replacement for the vivisect analysis since that would provide python3 support, and then of course an implementation of the full IDA plugin for BN.

this is ready to merge. @psifertex if you want to add your handle, please do! let me know when i should press "merge".

I'm bad at GH PR modification so I"m just closing this and re-submitting with the requested changes. :-)

@psifertex

I'm bad at GH PR modification so I"m just closing this and re-submitting with the requested changes. :-)

What is the problem exactly? Maybe we can help 😉

I was under the impression that merely pushing to my fork and would update the PR but that didn't appear to be the case? I started to create a PR and saw it was just going to make a fresh one in addition to the prior one. Maybe I should have ignored it and continued the process?

@psifertex

I was under the impression that merely pushing to my fork and would update the PR but that didn't appear to be the case?

That should be exactly the case. In fact, this PR has exactly the same commits as the new one you open. I think it worked. You may need to reload the page to see the new changes. GitHub shows a refresh message/button but doesn't update the code without reloading the page.
If you add changes to an already pushed commit (for example using git commit --amend after having fixed black offenses), you need to use the --force option (or --force-with-lease to ensure you don't destroy other people's commits if you are not the only one pushing to that branch).

Yup, I first tried the amend commit option but didn't see anything on the PR page when I checked it. Probably the case that I needed to do a forced reload of the page. Thanks, good to know I was on the right track. Next time I won't give up so easily. :-)
Also, thanks for catching the other bug that crept in on the first line. vim motion leftover that snuck in after testing.


Enable architecture to be selected

In one way or another, ensure that the user knows that when they're on intel an aarch64 package will not be registered -- and/or handle this gracefully.

Oh, this issue is about having a warning to users if there's a mismatch between the detected system architecture and the package architecture?

Yup.


TypeMap/Converter behavior broken since 2.4.0

The behavior of TypeMap in combination with Converter seems to be broken since 2.4.0. The following test worked well until version 2.4.0. Also, it got unreliable since the order of statements within the typeMap.addMappings() block has an impact on the outcome success of the mapping operation.
package demo;

import org.junit.jupiter.api.Test;
import org.modelmapper.AbstractConverter;
import org.modelmapper.ModelMapper;
import org.modelmapper.TypeMap;

import static org.junit.jupiter.api.Assertions.*;

class ExampleTest {

    AbstractConverter<Location, String> locationToStreetNumberConverter = new AbstractConverter<Location, String>() {
        @Override
        protected String convert(Location source) {
            return (source.getStreetNumber() == null ? "" : source.getStreetNumber())
                    + (source.getStreetNumberSuffix() == null ? "" : source.getStreetNumberSuffix());
        }
    };

    @Test
    public void testOrder1() {
        ModelMapper modelMapper = new ModelMapper();
        modelMapper.getConfiguration().setAmbiguityIgnored(true);

        TypeMap<Location, Address> typeMap = modelMapper.createTypeMap(Location.class, Address.class);
        typeMap.addMappings(mapper -> {
            mapper.map(Location::getStreetName, Address::setStreet);
            mapper.using(locationToStreetNumberConverter).map(src -> src, Address::setHouseNumber);
        });

        Location location = new Location("Example Street", "123", "d");
        Address address = new Address();

        modelMapper.map(location, address);

        assertEquals("Address{street='Example Street', houseNumber='123d'}", address.toString());
    }

    /**
     * Fails since ModelMapper 2.4.0
     *
     * Expected :Address{street='Example Street', houseNumber='123d'}
     * Actual   :Address{street='Location{streetName='Example Street', streetNumber='123', streetNumberSuffix='d'}', houseNumber='123d'}
     */
    @Test
    public void testOrder2() {
        ModelMapper modelMapper = new ModelMapper();
        modelMapper.getConfiguration().setAmbiguityIgnored(true);

        TypeMap<Location, Address> typeMap = modelMapper.createTypeMap(Location.class, Address.class);
        typeMap.addMappings(mapper -> {
            mapper.using(locationToStreetNumberConverter).map(src -> src, Address::setHouseNumber);
            mapper.map(Location::getStreetName, Address::setStreet);
        });

        Location location = new Location("Example Street", "123", "d");
        Address address = new Address();

        modelMapper.map(location, address);

        assertEquals("Address{street='Example Street', houseNumber='123d'}", address.toString());
    }

    class Address {

        private String street;
        private String houseNumber;

        public String getStreet() {
            return street;
        }

        public void setStreet(String street) {
            this.street = street;
        }

        public String getHouseNumber() {
            return houseNumber;
        }

        public void setHouseNumber(String houseNumber) {
            this.houseNumber = houseNumber;
        }

        @Override
        public String toString() {
            return "Address{" +
                    "street='" + street + '\'' +
                    ", houseNumber='" + houseNumber + '\'' +
                    '}';
        }
    }

    class Location {

        private String streetName;
        private String streetNumber;
        private String streetNumberSuffix;

        public Location(String streetName, String streetNumber, String streetNumberSuffix) {
            this.streetName = streetName;
            this.streetNumber = streetNumber;
            this.streetNumberSuffix = streetNumberSuffix;
        }

        public String getStreetName() {
            return streetName;
        }

        public void setStreetName(String streetName) {
            this.streetName = streetName;
        }

        public String getStreetNumber() {
            return streetNumber;
        }

        public void setStreetNumber(String streetNumber) {
            this.streetNumber = streetNumber;
        }

        public String getStreetNumberSuffix() {
            return streetNumberSuffix;
        }

        public void setStreetNumberSuffix(String streetNumberSuffix) {
            this.streetNumberSuffix = streetNumberSuffix;
        }

        @Override
        public String toString() {
            return "Location{" +
                    "streetName='" + streetName + '\'' +
                    ", streetNumber='" + streetNumber + '\'' +
                    ", streetNumberSuffix='" + streetNumberSuffix + '\'' +
                    '}';
        }
    }

}

Thanks @mpaetzold for reporting this bug with reproducible code. Bug was fixed by #609 and will have a release asap.

ModelMapper v2.4.2 released.


Is the stamp getting stripped from its methods when inside a Passport strategy?

I'm really confused now. What have I missed?
I have a stamp like this:
const App = stampit().
  init(function(context) {
    this.setDbUser(dbUtil.getMasterCredentials());
  }).

  methods({
    checkAppSecret: function(appSecret) {
        if(!this.secret) return console.log(new Error('No secret data loaded'));
        return appSecret === this.secret.appSecret;
    },

    setData: function(data) {
      if(!data) return this;
      this.data = {
        id: data.id,
        grant_type: data.grantType || data.grant_type,
        name: data.name
      };

      this.secret = {
        appSecret: data.appSecret || data.app_secret
      }
      return this; //return this (stamp) to make the call chainable
    },

    getData: function() {
      return this.data;
    },
  }).compose(
    DbLayer.use(appDbSchema)
  );

module.exports = App;

The stamp works like a charm when I test it like this:
model.App().loadFromDb({id: '1b12c4b2-2444-47a2-8a59-2c611c5c7493'})
  .then(function(app) {
    var isValid = app.checkAppSecret('secretCode');
    console.log(isValid);
  });

But when I use the stamp in a Passport strategy like this:
passport.use('client_password', new ClientPasswordStrategy(
  function(appId, appSecret, done) {
    model.App().loadFromDb({id: appId})
      .then(function(app) {
        if (!app) { return done(null, false); }
        if (!app.checkAppSecret(appSecret)) { return done(null, false); }
        return done(null, app);
      }).catch(function(err) {
        return done(err);
      });
  }
));

I get an error saying: 'app.checkAppSecret is not a function'
I don't get it. I have probably misunderstood something.

You probably did missed something.
Show us the DbLayer.use function contents. It returns garbadge in the second case.
P.S. To debug I'd recommend you to insert the following into your init function:
console.log(context.stamp.fixed);

Here is DbLayer.use:
const DbLayer = stampit().
  static({
    use(dbSchema) {
      //dbSchema = {tableName: 'xyz', idField: 'id'}  //idField can be a string or array

      if(!Array.isArray(dbSchema.idFields)) {
        dbSchema.idFields = [dbSchema.idFields];
      }

      if(!dbSchema.selectFields) {
        dbSchema.selectFields = ['*']
      }

      if(Array.isArray(dbSchema.selectFields)) {
        dbSchema.selectFields = dbSchema.selectFields.join(', ');
      }

      return this.props({dbSchema: dbSchema});
    }
   }).

Okay, then could you please show use the loadFromDb function contents?

The issue can be this line:
return this.props({dbSchema: dbSchema});
The props will deep copy the dbSchema to each new object. You probably wanted to use refs?

I changed to refs.. same problem.
Here is loadFromDb
loadFromDb: function(options) {
  var instance = this;
  var db = pgp(instance.db);
  var whereClause = instance.generateWhereClause(options);

  let sql =
  `
    SELECT ${instance.dbSchema.selectFields}
    FROM ${instance.dbSchema.tableName}
    ${whereClause}
  `;

  return db.one(sql).then(function(data) {
   return Promise.resolve(instance.setData(data));
  }).catch(function(err) {
    console.log('loadFromDb, err')
    console.log(err)
   return Promise.reject(err);
  });
},

Side note: you don't need Promise.resolve(). Simple return instance.setData(data); does the same job.

Is there a chance something overwrites the loadFromDb function at some point?

No, I did a search to be sure. LoadFromDb is called from a couple of places, but only defined once.
About the promise.. I wanted to be sure to return a promise even after an error. I did the same thing at resolve to be sure. I do need it at error, don't I?

I "ported" the stamps to a hierarchical ES6 class structure where App extends DbLayer. A factory function makes the class work as a drop in replacement for the stamp. Everything works as it should when I use the "class" instead of the stamp. I don't quite understand the inner workings of stamps, which increase the risk of me using them wrongly. Maybe they are too complicated for me..

Re the Promises: yes you need in in the .catch() handler because you have some code using the error object before moving it forward.

IMO your stamp understand it right. It is a simple concept. What you lack is some JS debudding skills.
Why don't you put console.log(app) and see what it prints just before the crash?
I wanted to tell that before but hesitated. Please, do not take it as an offence, but you have overcomplicated your code.

This sounds like OMG:

I "ported" the stamps to a hierarchical ES6 class structure where App extends DbLayer.

People are usually doing vice-versa.

You don't need the DbLayer stamp at all. Make it a pure function: getStampForSchema(Schema).
You are nesting the composition instead of making it flat. This code is complicated too much:

return db.one(sql).then(function(data) {
   return Promise.resolve(instance.setData(data));
})

Make your behaviours having minimum logic. For example:

let SecretValidator = stampit().methods({ checkAppSecret(secret) { ...
let DbUserCredentials = stampit().props(dbUtil.getMasterCredentials());
let DbReader = WhereClauseGenerator.methods({ loadFromDb(options) { ... return data; });
let DbInstance = DbUserCredentials.init(({instance}) => { instance.pgp = pgp(instance.db); });
let Else...

// in the passport callback
let app = model.App();
app.loadFromDb({id: appId}).then((data) => {
  if (!app.checkAppSecret(data)) { return false; }
  return PassportDropInReplacement(data); // <- object the Passport requires
}).nodeify(done); // <- assuming you are using Bluebird promises implementation

This is NOT taken as an offence!  I take it as a great source of knowledge. I really appreciate you writing this up for me. Thank you for your time!
I fight day and night to learn proper Java Script (Last couple of years has been all SQL for me and before that, Delphi). My biggest problem with Java Script is that there are so many ways to do one thing and every blogg/book says to do it differently.
About the OMG :)
I wasn't actually resorting to hierarchical, but did it as a test to make sure I hadn't made a mistake elsewhere.
At the first glance I don't quite follow you on 1-3. I'll make a cup of coffee and look closer. Also, I'd love to use arrow functions, but I'll wait until I can install node v4 with nvm. Don't want to fiddle with a global node install on my dev machines. iojs 3.3 for now..

Re the nvm. Try: $ nvm install 4
See here: https://github.com/creationix/nvm/issues/821#issuecomment-139025122

Also, people are not using pure node but babel to run ES6 code:
$ npm i babel -g
$ babel-node my-app.js

@michaelswe if you have any questions and you want the answers fast ask them in the gitter: https://gitter.im/stampit-org/stampit

Supermystierium solved. Unfortunately I don't know how.
I develop locally, but have all changes sent directly via SSH to a development server (with Sublime SFTP). I decided to wipe the server and reinstall. Made a copy of the old version at the server and sent all files to a new directory. Npm install to get the modules... And then everything worked :-/
I diffed the old and new directory and found no differences in my source code.
I diffed npm ls to find differences in module versions. The biggest differences where that Mongoose was still installed on the server, and some small version differences. Also Supermixer is installed separately in the new version, but it's the same version as used by Stampit. I can still reproduce the error in the old directory. I'd rather not leave this without understanding what happened.  Most likely you did nvm use ... but didin't reinstall modules (you should wipe node_modules if you change node version). Am I correct?

Yes, you are probably right. It was a long time ago, but I don't recall wiping node_modules when I switched iojs version. Big lesson learned.. Thanks!
At last I can get back to some productive work..
Btw, why would I need Babel when I can use most of ES6 in v4?

Hmm. I wiped node_modules in my faulty project and did npm install. Problem is still there. Is there anything else to wipe, but node_modules?

Babel JS implemented more ES6 features than V8 v4.5 (node v4).
http://kangax.github.io/compat-table/es6/

Could be request.js bug fix. Who know! :)

I found it.. But I'm too ashamed to tell you what it was :)

Now worries. :) Keep it secret.

There was actually a diff between the directories that I missed (yes, it was reported by the diff command).
I had a really old version of my app stamp file laying around at the server without the .js extension. I usually don't include .js when I require files, so the old file was picked up by require.
Lesson #2 learned: If a file is renamed in Sublime the new file is sent of to the server via SFTP, but the old file still remains at the server.

Feel free to close this issue any time. Cheers


Bump oauth and framework version

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12406155972

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12406155972
Status: failure

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12408711862

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12408711862
Status: failure

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12408711862

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12408711862
Status: failure


The link to MMT/Camera apears to be broken

Title pretty much says it all. The link from this page:
https://github.com/konradit/gopro-linux
called "mmt" to this page
https://mmt.camera/
Just times out. So it appears to be broken.

Still seems to be the case.  Maybe link to github.com/KonradIT/mmt instead?


[1.13] Bump dcos-net

High-level description
Bump dcos-net
Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:

DCOS_OSS-5118 DCOS-DNS always returns A records in the same order

Related tickets (optional)
Other tickets related to this change:
Checklist for all PRs

[x] Added a comprehensible changelog entry to CHANGES.md or explain why this is not a user-facing change:
[x] Included a test which will fail if code is reverted but test is not. If there is no test please explain here: none
[x] Read the DC/OS contributing guidelines
[x] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[x] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[x] Test Results: [link to CI job test results for component]
[x] Code Coverage (if available): [link to code coverage report]

https://github.com/dcos/dcos-net/compare/d699ab1bd5c0c1e5911b3851ebb416d15ddfb4a0...295b1b0914f1f9828471d6851b00ad3133174c20
https://github.com/dcos/dcos-net/pull/150
https://circleci.com/gh/dcos/dcos-net/1163
https://codecov.io/github/dcos/dcos-net/commit/295b1b0914f1f9828471d6851b00ad3133174c20

PLEASE FILL IN THE TEMPLATE ABOVE / DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE
Instructions and review process
What is the review process and when will my changes land?
All PRs require 2 approvals using GitHub's pull request reviews.
Reviewers should be:

Developers who understand the code being modified.
Developers responsible for code that interacts with or depends on the code being modified.

It is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has 2 ship-it's, no red reviews, and all tests are green it will be included in the next train.

@mesosphere-mergebot label [Ready For Review]


Update to 0.22.0 - sensu server crashes with "update_client_registry': undefined method `empty?' for nil:NilClass (NoMethodError)"

Hi,
since updating to 0.22.x we've noticed several sensu server crashes with always the same message - this seems directly related to the update as we've never had this happening on 0.19.x
{"timestamp":"2016-03-01T06:22:13.887513+0000","level":"warn","message":"reconnecting to redis"}
/opt/sensu/embedded/lib/ruby/gems/2.2.0/gems/sensu-0.22.0/lib/sensu/server/process.rb:119:in `block (2 levels) in update_client_registry': undefined method `empty?' for nil:NilClass (NoMethodError)
	from /opt/sensu/embedded/lib/ruby/gems/2.2.0/gems/em-redis-unified-1.0.1/lib/em-redis/redis_protocol.rb:487:in `call'
	from /opt/sensu/embedded/lib/ruby/gems/2.2.0/gems/em-redis-unified-1.0.1/lib/em-redis/redis_protocol.rb:487:in `dispatch_response'
	from /opt/sensu/embedded/lib/ruby/gems/2.2.0/gems/em-redis-unified-1.0.1/lib/em-redis/redis_protocol.rb:432:in `process_cmd'
	from /opt/sensu/embedded/lib/ruby/gems/2.2.0/gems/em-redis-unified-1.0.1/lib/em-redis/redis_protocol.rb:406:in `receive_data'
	from /opt/sensu/embedded/lib/ruby/gems/2.2.0/gems/eventmachine-1.0.8/lib/eventmachine.rb:193:in `run_machine'
	from /opt/sensu/embedded/lib/ruby/gems/2.2.0/gems/eventmachine-1.0.8/lib/eventmachine.rb:193:in `run'
	from /opt/sensu/embedded/lib/ruby/gems/2.2.0/gems/sensu-0.22.0/lib/sensu/server/process.rb:23:in `run'
	from /opt/sensu/embedded/lib/ruby/gems/2.2.0/gems/sensu-0.22.0/exe/sensu-server:10:in `<top (required)>'
	from /opt/sensu/bin/sensu-server:23:in `load'
	from /opt/sensu/bin/sensu-server:23:in `<main>'

It'd be great to find out what is causing this.
Thanks!
Alex

Hey @alex-leonhardt, I have a fix for this issue https://github.com/sensu/sensu/pull/1178

:+1:  Thanks! Is there a targeted release for this ?

it seems to be in 0.22.1 correct ?

There's no RPM available yet - http://repositories.sensuapp.org/yum/x86_64/ - is that due to be updated too ?


Sometime event seems to be sent multiple times.

Even if I only send it once, my registered closure is called multiple times.
So today i have to unregister when receiving the event for the first time.
Note that I'm certain that the posting of the event happens only once, I added a breakpoint and it only stopped once.
Sending:
SwiftEventBus.post(BUS_EVENT_1_DETECTED, sender: myData)
Event listener in my view controller viewDidLoad() function :
    SwiftEventBus.onBackgroundThread(self, name:BUS_EVENT_1_DETECTED) { result in
        //listen only once as this event may be casted multiple times.
        SwiftEventBus.unregister(self, name:BUS_EVENT_1_DETECTED)
        let data:MyData = result.object as! MyData
        // then do stuff here with my data.
    }

Any ideas ?
Thanks.

It's the first time I've heard about this issue, This is a wrapper for the NotificationCenter, it shouldn't behave like that

@nmDejamobile I've just stumble this issue my self,  the problem is not on the post side but rather on the listening side, seems like NSNotification addObserverForName, just adds the target multiple time for the same key and object regardless its existence.
check if you call SwiftEventBus.onBackgroundThread.. multiple times, e.g. inside table cell.

@cesarferreira I also face this issue
Sender side not issue but handle side it call multiple time
Thank you


kiss: Add node_id parameter

In the commit 0d4dac28a5bf75390bdd1ef26e1c109094e0a032,
csp_can_socketcan_open_and_add_interface() gained new parameter node_id, which is assigned to ctx->iface.addr in the function.
Add address / node_id parameter to csp_usart_open_and_add_kiss_interface().
Fix https://github.com/libcsp/libcsp/issues/459

Rebase.

ABI Compliance check fail because Parameter addr of type uint16_t has been added to csp_usart_open_and_add_kiss_interface() .
Please check the report for more informations.

I forgot I changed parameters, I will correct that part !

You need to work on the commit message a bit. It could be somehitng like:

kiss: Add addr parameter
In commit 0d4dac2, we added a CSP address parameter to the
csp_can_socketcan_open_and_add_interface() function. The address is
assigned to ctx->iface.addr.
This commit similarly adds an addr parameter for the CSP address to
csp_usart_open_and_add_kiss_interface(), allowing us to specify the
address for the given interface.

for the commit "examples: python: Add new parameters support to the examples", it has many logical changes.  Split them for each logical change.


[Request] Please add option to configure crash dump information type

Hi guys, thanks for your library!
I wanna ask to add an option to configure crash dump type like it suggested in the comment
MiniDumpNormal,        // MINIDUMP_TYPE - we _might_ want to make this configurable
Is it possible to configure Linux, MacOS dump type, or at least full dump?

I'm not sure if I understand your request. This is the Windows minidump generation code, making it configurable would allow for the generation of full dumps for example - like the comment suggests - by passing MiniDumpWithFullMemory instead of MiniDumpNormal. That's definitely possible. What do you mean though with "Linux, macOS dump type"?


torch-migraphx test fail for model pit_b_224

The following torch-migraphx test command leads to an exception in Migraphx. Troubleshoot and fix.
python ./benchmarks/dynamo/timm_models.py --inference --float16 -dcuda --performance --backend migraphx -k pit_b_224
An exception is thrown during the simplify_algebra pass, trying to broadcast between two shapes that aren't broadcastable.

Shiv says this is fixed, he will do a quick check

Model runs successfully


Renaming of class labels doesn't "take" if performed when no samples exist.

If you rename a class for which there are no samples, the new name will appear in the GUI. The new name, however, will not be applied to the training samples and therefore predictions will show the previous name.

Also, when the last sample has been deleted from a class but the model hasn't been retrained, you'll sometimes see "CLASS_LABEL_NOT_FOUND" as a prediction in the live stream.


Rename tests to data_tests

Tests were renamed to data tests in dbt 1.8>

Tests were renamed to data tests in dbt 1.8>

is that true though? I think I have clients that use 1.8 and higher but did not change the test parameter?

Tests were renamed to data tests in dbt 1.8>

is that true though? I think I have clients that use 1.8 and higher but did not change the test parameter?

I suppose dbt is backward compatible with this change :)


Action to show GUI

[ ] Button to toggle Collectable status (possibly Tab)
[ ] Show Collectable status on Pause Screen


Searching for bugs, nothing to see here... gmyjir

Searching for bugs, nothing to see here... gmyjir

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Update h2spec

Currently tests are using version 1.5.0, which is from 2016.
My current machine (Apple M1) Seg Fault on it (see https://github.com/apache/incubator-pekko-http/issues/218#issuecomment-1646844106), making the H2SpecIntegrationSpec test suite fail.
./http2-tests/target/h2spec_darwin_amd64/h2spec --dryrun
[1]    3328 segmentation fault  ./http2-tests/target/h2spec_darwin_amd64/h2spec --dryrun

Updating h2spec to its latest version 2.6.0 would hopefully fix the issue.
Note this is non-critical as the current version is working well in the CI environment.

I'm not sure if h2spec supports Mac Silicon.
There only appear to be downloads for Mac AMD64 - https://github.com/summerwind/h2spec/releases/

Indeed, no binaries for arm64/aarch64.
I still think this issue makes sense to eventually update to a more recent version.

The update to 2.6.0 makes the new h2spec binary work on Apple Silicon, at least transparently using Rosetta (https://github.com/apache/incubator-pekko-http/issues/218#issuecomment-1648476214)

The update to 2.6.0 makes the new h2spec binary work on Apple Silicon, at least transparently using Rosetta (#218 (comment))

Great to know. I guess Rosetta hit a corner case in the old release.


CloudConfigurationManager doesn't respect file attribute on appSettings

A common method of hiding secrets from source control is to use the file= attribute of the appSettings element in web.config/app.config.
However, it seems the cloud configuration manager doesn't support this element or it is ignored.
Can this support be added, or if it's there, what am I doing wrong? I have the following file= in my app.config appsettings:
file="%APPDATA%\myappname\AppSettingsSecrets.config
and the file is in that location. I also tried it with the absolutepath, didn't work either.

@PilotBob Currently we only fix existing bugs and do not add new features to CloudConfigurationManager. However since this is a publicly available source code please feel free to create a PR with the functionality that will address your scenario and be useful for other customers. We will review it, help you get it merged and publish new package to Nuget.org.

So, does that mean this class is deprecated?


Await on non-coroutine function does not return value

Godot version
4.0 dev
System information
Mac OSX 11.1
Issue description
Calling await on a non-coroutine function returns a null value, no matter what is passed back from the function. This can be problematic if you do not know if the function is a coroutine or not when calling it. It would seem that a non-coroutine function should always return their value, whether await is used or not. Awaiting the non-coroutine function means waiting until it is finished (which would be at the last line in the function), correct?
Steps to reproduce
func _ready():
	var functions: Array[Callable]
	functions.append(Callable(self, "func_a"))
	functions.append(Callable(self, "func_b"))
	var results = []
	for function in functions:
		results.append(await function.call())
	for i in range(results.size()):
		print("%s: %s" % [i, results[i]])

func func_a():
	return "a"

func func_b():
	await get_tree().create_timer(0.1).timeout
	return "b"

returns:
0: Null
1: b
should return:
0: a
1: b
Minimal reproduction project
AwaitTest.zip

A simpler reproduction would be:
func _ready():
	print(await func_a())

func func_a():
	return 5

The first example in the original post shows a more relevant example, but this one shows the simplest way to reproduce.


SAM-2794 ammendment: set notification to default on catch of NPE/NFE

https://jira.sakaiproject.org/browse/SAM-2794
Amendment to address the issue @master-bob brought up.

LGTM


Add minimal-versions to Github actions

This is the start of adding a new Github action to verify that async-graphql properly supports the minimum versions of the dependencies listed.
For details on what this is about, check out:

https://github.com/rust-lang/cargo/issues/5657
https://github.com/rust-lang/cargo/issues/5656
https://blog.illicitonion.com/rust-minimum-versions-semver-is-a-lie/

It's being encouraged that crates start to do this where possible. You can see that tokio already does this.
I was trying to do this for my crate that has an optional dependency on async-graphql, and hit a couple of compilation failures during this check. I can get around them by manually specifying transient dependencies in my build, but it's a good practice to try to contribute back to upstream dependencies where possible. 😄
Given the large scope of async-graphql, going to have to manually step through each project and bump versions or add manual inclusion of transient dependencies until we're good to go.

Also, you can use cargo tree --all-features --workspace -p trust-dns-resolver:0.19.2 -i trust-dns-resolver and similar to do a reverse lookup of what is bringing in specific versions of dependencies that are failing due to older versions. For example, the above could be updated to 0.19.6 following semver to possibly add the missing functionality.

Also, you can use cargo tree --all-features --workspace -p trust-dns-resolver:0.19.2 -i trust-dns-resolver and similar to do a reverse lookup of what is bringing in specific versions of dependencies that are failing due to older versions. For example, the above could be updated to 0.19.6 following semver to possibly add the missing functionality.

Thank you very much, I will merge it after I solve these problems. 🙂

Thank you very much, I will merge it after I solve these problems. 🙂

@sunli829, polyval seems to be giving me some trouble finding a proper version of the dependency that works. I'll need to go back and see what version is pulled in during compilation without using the minimal-versions feature. Going to take a break for a little bit. 😄

@sunli829, polyval seems to be giving me some trouble finding a proper version of the dependency that works. I'll need to go back and see what version is pulled in during compilation without using the minimal-versions feature. Going to take a break for a little bit. 😄


Feat: Add Sign-in and Sign-up Functionality to Page

Describe the feature
We need to implement sign-in and sign-up functionality on our web page to enhance user experience and enable user account management.
Our current web page lacks the capability for users to sign in or sign up for an account. This functionality is crucial for user engagement and retention. By allowing users to create accounts and sign in, we can provide personalized experiences, enable features like saved preferences, and enhance security through user authentication.
Solution

HTML Structure:

[ ] Create HTML forms for sign-in and sign-up, each with input fields for relevant user information (e.g., email, password).

[ ] Include buttons for submitting the forms.

[ ] Use appropriate HTML tags and attributes for accessibility and semantic markup.

CSS Styling:

[ ] Style the forms, input fields, buttons, and error messages using CSS to create an intuitive and visually appealing user interface.

[ ] Apply responsive design principles to ensure the forms look good and function well across different screen sizes and devices.

@arghadipmanna101 please assign this issue to me under GSSOC

[ ] Consider using CSS frameworks like Bootstrap or Tailwind CSS for rapid styling and layout.

JavaScript Functionality:

[ ] Implement client-side validation using JavaScript to ensure that users enter valid data before submitting the forms.

[ ] Validate email addresses, password strength, and any other required fields according to your validation criteria.

[ ] Display error messages dynamically to inform users of any validation failures.

[ ] Handle form submission events to prevent the default action and instead send AJAX requests to the server for sign-in and sign-up.

@
Add ScreenShots
It's essential to maintain a clear separation of concerns between client-side and server-side code.

Consider implementing features like email verification for added security.

Prioritize usability and accessibility throughout the implementation process.
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@arghadipmanna101 Please assign this issue to me under GSSOC

i am interested to work on this. please assign it to me

hi,
I am GSSOC'24 Contributor. Could you please assign this task to me.
I will add Sign-in and Sign-up page to your web pages looks like similar to flipkart log in page , attractive and responsive.
please assign it to me.

i working the issue

please review my pr @arghadipmanna101

Hi there, I'm a beginner at open-source contribution so I want to gain hands-on experience by contributing to this project through GSSOC'24. Please assign this issue to me. Thank you.

I want to contribute to this project so please assign me .


arm: cxd56xx: Fix nvic settings for SMP

Summary

I noticed that ostest sometimes stops with DEBUGASSERT
Finally I found a bug that cpu1 can not disable interrupt
This commit initializes nvic to fix this bug

Impact

Only affects cxd56 in SMP mode

Testing

spresense:smp and spresense:wifi_smp with DEBUG_ASSERTIONS=y

@jerpelea


Api not working

Hi there, I really love your idea I think it's awesome to use Open Source projects.
I wanted to use your project together with a Supabase DB as they are open source and it's already hosted online. Setting up was a breeze I forked your project and then connected it to Vercel setup my DATABASE_URL from what I got from Supabase and setup my own HASH_SALT string.
I deployed it and it was amazing changed my pw and connected my own personal site to test. Everything worked and umami was getting the site visits.
But a few minutes later it stopped working, I tried going to the websites and to the dashboard and sometimes it would get some information but most often than not it didnt. I have attached a screenshot of the errors the console shows.

Back on my site there was also another error:
POST https://******.vercel.app/api/collect 500
Any idea what could have gone wrong? Is it because of Supabase?

You need to go to your Vercel dashboard to get the actual error occurring on the server. Should be under the Functions log.

These are the log errors from trying to checkout the stats on my umami site

Looks like an issue with the Supabase database. The error just says something went wrong at the database level.

Dammm I really wanted to use Supabase thank you for taking the time to reply to this!


[Unity w/ SQLNado] IL2CPP does not support marshaling delegates that point to instance methods to native code

I am attempting to use SQLNado on Unity via the IL2CPP cross-compiler bridge.
I've been able to bring up a working version of SQLNado <-> SQLite on iOS, Win32, Mac OS X, however I face a challenge.
Based on Unity's IL2CPP functionality the NativeCollationNeeded/SetCollationFunction delegates do not work. Per Unity's error message:
NotSupportedException: IL2CPP does not support marshaling delegates that point to instance methods to native code. The method we're attempting to marshal is: SqlNado.SQLiteDatabase::NativeCollationNeeded
This appears to block the use of SQLNado-base collation callbacks and I'm trying to determine how bad this is for SQLite.
If you have time to discuss this, please let me know.
Or if you are interested in the changes I've made to SQLNado to get it working under the Unity3D game engine!

Hi,
That's nice :-)
NativeCollationNeeded/SetCollationFunction are not super used.
Yes, maybe your changes can be brought back in SQLNado w/o impacting it on other platforms at runtime, can you make a pull request? I'll look at it when I'm available. Or just using a couple of defines would make things better.

Closed because no activity for a long time.


Migrate db_manager from sqlite+sqlmodel to odmantic

Is your feature request related to a problem? Please describe.
We have decided to use mongodb+odmantic for all of our backend.
Describe the solution you'd like
We would like to migrate the db_manager service in the backend together with the models from using sqlmodel to odmantic

[ ] @aybruhm Please remove the troubleshooting item number six from the documentation in your PR. Thanks!


Update rules.md : section on process of moderation

Updates to guidance notes on the process of moderation as discussed in https://github.com/cf-convention/cf-conventions/issues/151

These changes look great. I'll merge in three weeks unless we get more conversation.


Ability fo fire faults of fetched entities

What?

Improvements:

Compile time generated key paths for unit tests.
Change method signatures of NSManagedObjectContext helper methods in order to make them a bit more descriptive.

Why?
Minimize the number of queries made to a persistent store when snapshotting model in Chatkit.

CC @pusher/sigsdk

          1 Warning

:warning:
Any changes to library code should be reflected in the Changelog. Please consider adding a note there. \nYou can find it at CHANGELOG.md.

  Generated by :no_entry_sign: Danger

@pusher-ci This PR specifies chatkit-version-2 as destination which is a temporary integration branch.


debug_trace payloads too big

Describe the bug
Trying to get debug traces from a reth node but noticed it's blocked when the trace is too big.
Steps to reproduce
Find a "large" block on mainnet. I think more often that not you will hit this limit on mainnet blocks.
curl \
    -H "Accept-Encoding: gzip, deflate, br" \
    --compressed \
    -X POST --data '{"jsonrpc":"2.0","method":"debug_traceBlockByNumber","params":["0x123959D"],"id":1}' \
    -H "Content-Type: application/json" \
    http://localhost:8545

Node logs
{"jsonrpc":"2.0","error":{"code":-32008,"message":"Response is too big","data":"Exceeded max limit of 157286400"},"id":1}

### Platform(s)

Linux (x86)

### What version/commit are you on?

v0.1.0-alpha.16

### What database version are you on?

not sure, can get it if really required

### What type of node are you running?

Archive (default)

### What prune config do you use, if any?

_No response_

### If you've built Reth from source, provide the full command you used

_No response_

### Code of Conduct

- [X] I agree to follow the Code of Conduct

you can use --rpc-max-response-size to increase the max allowed response size

is --rpc-max-request-size meant to be defined in bytes?


Libs for ndl_directmedia should be NDL_directmedia

https://github.com/sundermann/webos-userland/blob/4baf7731e8b024a9c03d845a5cc127c2556fe148/share/pkgconfig/ndl_directmedia.pc#L10
Hi, I tried to use ndl_directmedia found by pkg-config, but getting errors in link time. And I think for Libs section it should be NDL_directmedia instead.

Should be fixed in master


TEIIDTOOLS-1019: Fixing the documention about custom settings.xml file

@roldanbob see this for usage about configuring the custom settings.xml file


Why can't I import the pygicp module?

python version 3.9

import sys
print(sys.path)
['', '/opt/ros/melodic/lib/python2.7/dist-packages', '/home/suv/anaconda3/envs/gsicpslam/lib/python39.zip', '/home/suv/anaconda3/envs/gsicpslam/lib/python3.9', '/home/suv/anaconda3/envs/gsicpslam/lib/python3.9/lib-dynload', '/home/suv/.local/lib/python3.9/site-packages', '/home/suv/.local/lib/python3.9/site-packages/pygicp-0.0.1-py3.9-linux-x86_64.egg', '/home/suv/anaconda3/envs/gsicpslam/lib/python3.9/site-packages', '/home/suv/anaconda3/envs/gsicpslam/lib/python3.9/site-packages/pygicp-0.0.1-py3.9-linux-x86_64.egg', '/home/suv/GS_ICP_SLAM/submodules/fast_gicp/src/fast_gicp', '/tmp/tmprbvaxoij']

The problem seems to be related to the PCL library. I attempted to use a command：
pip install pcl
conda config --add channels conda-forge
conda install -c sirokujira python-pcl
conda install -c conda-forge cmake=3.12
it works!


Getting Null Pointer Excpetion when i recieve a notification from FCM

I get proper notification shown in notification bars, OnRecieved() method completes execution and then the app gets crash with the Null Reference Exception.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8d9bfb2a-2e5d-d505-337f-919251a85de3
Version Independent ID: 695bff64-ae87-8c0f-5616-20b67893fdf0
Content: Remote Notifications with Firebase Cloud Messaging - Xamarin
Content Source: docs/android/data-cloud/google-messaging/remote-notifications-with-fcm.md
Product: xamarin
GitHub Login: @mgmclemore
Microsoft Alias: mamcle

Hi @vikram-relyfy, it looks like you've found a bug. This repository is only for documentation-specific issues: could you please report the specifics about your null pointer exception at Developer Community (click Report a problem)? Thank you!


React: populating initial files issue // load via server

Summary
Setting initial files with the files property on <FilePond> instance seems to have no effect. Is this correct?
Setting initial files with <File> children works like this:
{this.props.existingFileIds.map(fileId => (
    <File key={fileId} src={fileId} origin={'local'}/>
))}

But:
If I remove the file (via GUI) and/or add new files, FilePond tries to load the newly uploaded files with the load method. But the newly uploaded files were only transferred temporarily, so the "load" fails of course.
Even if the this.props.existingFileIds is an empty array, this behaviour occurs.
Why is this happening?
Expected behaviour
One can set initial files with <File> children, but removing a file and adding new files should result in the same behavior => transfer via the process route, but don't issue a "load" afterward.

The initial files list will be preloaded by FilePond as long as the file data is not stubbed. Using the origin property you can inform FilePond where the files are located on the server, local (for uploaded files) or limbo (for temp files).
I just tested to be sure, but if I drop new files they are added normally and not routed through the server.load endpoint.
Maybe I'm misunderstanding the issue, can you elaborate?

I'm sorry, the problem was not in FilePond, but in my wrapping component using Formik. Formik tried to rerender the FilePond field several times upon image removal, and that caused the component to misbehave. I fixed that by implementing a shouldComponentUpdate => return false function.

@lukey78 Alright! Thanks for the updated :)


Doc hyperlinks not updated according to new Twitter API Update

Reference: Docs link at https://twython.readthedocs.io/en/latest/api.html

@ryanmcgrath If this issue is valid and someone is not already working on it, please assign it to me. I would love to work on it.

Have at it @gureks! :)

Hey
I started on it today and found that the URLs are updated in the function docstrings but not on twython.readthedocs.io
Where are those files?

The master docs have been updated http://twython.readthedocs.io/en/master/usage/advanced_usage.html
when a new release is pushed, I'll build for latest! Sorry about that!


Add support for excluding/including IPs in zk-dump

Sometimes you only care about sniffing traffic to a given cluster. This
commit adds an option for that:
$ sudo zk-dump --iface lo --include-host some-cluster.domain.tld
When using the --include-host flag, only requests to and from the A and AAAA
records backing some-cluster.domain.tld will be captured.
Similarly, you could be interested in capturing all ZK traffic on a box
except for what's going to a given cluster:
$ sudo zk-dump --iface lo --exclude-host some-cluster.domain.tld
Both flags can be used multiple times to include or exclude more than one
host. Though you can't mix include and exclude flags.
Signed-off-by: Raul Gutierrez S<EMAIL_ADDRESS>

Coverage decreased (-0.84%) to 61.32% when pulling eb6b20a4496ee97531727b1c9e595b05b864d8aa on rgs1:add-include-exclude-support into 2e04f402e007968a58fd55bb41b9c745d62d85e7 on twitter:master.

Looks good to me.


NextString output not withing min and max

This test will fail at some point the values generated are not withing the min and max, just added a loop to the already existing text
`
[Test(Description = "Tests the NextString returns a string that is between the minimum and maximum values specified")]
public void
ShouldBeBetweenMinAndMaxNextString()
{
        // Arrange
        int minValue = 100;
        int maxValue = 200;

        for(int i=0; i<100;i++)
        {
            // Act
            var result = randomGenerator.NextString(minValue, maxValue);

            // Assert
            Assert.That(result.Length, Is.LessThanOrEqualTo(maxValue));
            Assert.That(result.Length, Is.GreaterThanOrEqualTo(minValue));
        }

    }

`

The easiest fix here is to remove the Trim() statement at the end of the method. However, I'll bet that breaks some assumptions others have what constitutes a valid string. The other thing I have to be concerned about is narrow ranges (e.g., NextString(15,20)). This will likely require a complete rewrite of the  method.

Okay, this is the new test body and it passes:

        [Test(Description = "Tests the NextString returns a string that is between the minimum and maximum values specified")]
        [TestCase(1,10)]
        [TestCase(4, 5)]
        [TestCase(16, 20)]
        [TestCase(100, 200)]
        public void ShouldBeBetweenMinAndMaxNextString(int minLength, int maxLength)
        {
            // Arrange
            for (int i = 0; i < 100; i++)
            {
                // Act
                var result = randomGenerator.NextString(minLength, maxLength);

                // Assert
                Assert.That(result.Length, Is.LessThanOrEqualTo(maxLength), result);
                Assert.That(result.Length, Is.GreaterThanOrEqualTo(minLength), result);
            }

        }

wow my for loop is now part of he source code ? I feel honored :P

The fastest way to get your issue worked on is to provide a nice, easy test case. Thanks for your effort! 👍


chore: replace deprecated standalone eda-ui image with nginx

Replace the deprecated standalone UI image with nginx.
Need to include selfsigned certificates that were already provided by the old image. Preserve the rest of the configuration.
Set correctly the django staticfiles.
IMPORTANT: I have not changed the mac file basically because I can not test it. I can add it but I would prefer if someone else with mac does it. Maybe @mkanoor
Jira: https://issues.redhat.com/browse/AAP-31324

Hey @Alex-Izquierdo ,
Should we make the same edits in the docker-compose-mac file too?
I can help validate this if so

Hey @Alex-Izquierdo , Should we make the same edits in the docker-compose-mac file too?
I can help validate this if so

@zkayyali812 It is described in the PR: https://github.com/ansible/eda-server/pull/1071#issue-2552766770

IMPORTANT: I have not changed the mac file basically because I can not test it. I can add it but I would prefer if someone else with mac does it. Maybe @mkanoor


Update module metadata after transfer to Voxpupuli

fix metadata - dependency and location referenced

I think https://github.com/voxpupuli/puppet-augeasproviders_sysctl/pull/65 is intended to really make it a VP module.

Please merge this and release with a new  puppet-augeasproviders_sysctl version with tag, e.g.  3.0.0 so that other modules can update their dependencies. The existence of puppet-augeasproviders_core module while no module puppet-augeasproviders_sysctl exists, is confusing.

I've updated #65 to include your change. Somehow idempotency appears broken with Puppet 7 in one specific case, which I don't understand yet.

I am stuck on https://github.com/voxpupuli/puppet-augeasproviders_sysctl/pull/65#issuecomment-1423868243 and really hesitant to merge something broken. Note that on your PR no CI ran at all, so it may look green but it just didn't test anything.

It looks like Augeas 1.14 has some fixes for the sysctl lense, I wonder if that is relevant?

@jcpunk The current issues with failing tests isn't probably related to changes in Augeas. This PR probably won't affect this module. I haven't seen any breaking changes, and the augeas package usually installed from OS package, right?

@isc-lindensc could you please rebase this against master now that #65 is merged?

@isc-lindensc I'll close this PR since there is no more changes to apply.


Update sbt-sonatype to 3.9.10

Updates org.xerial.sbt:sbt-sonatype from 3.9.3 to 3.9.10.
GitHub Release Notes - Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.xerial.sbt", artifactId = "sbt-sonatype" } ]

labels: sbt-plugin-update, semver-patch

Superseded by #129.