Set default PHP version to 8.3 for ddev config --project-type=drupal for Drupal 11 release late July 2024

Preliminary checklist

[X] I am using the latest stable version of DDEV (see upgrade guide)
[X] I have searched existing issues
[X] I have checked the troubleshooting guide
[X] I have run ddev debug test to include output below

Problem
Drupal 11 will be released the week of July 29, 2024.
https://www.drupal.org/about/core/policies/core-release-cycles/schedule
It would be nice if this command gave you PHP 8.3 before the week of July 29, 2024:
ddev config --project-type=drupal --docroot=web
Workaround
ddev config --project-type=drupal --docroot=web --php-version=8.3
Solution
I found https://github.com/rfay/ddev/blob/master/pkg/nodeps/php_values.go where it looks like the default PHP version for all systems is PHP 8.2. Perhaps other systems are not ready for PHP 8.3 ... so should the default drupal config be changed from using PHPDefault to PHP 8.3? (I am not sure where)

Hi @gitressa,
With a new drupal project type (that handles Drupal 8,9,10,11), it's impossible to detect the Drupal version, that will be used.
That's why our quickstart for Drupal sets --php-version explicitly https://ddev.readthedocs.io/en/stable/users/quickstart/#drupal
And even when you try Drupal 11 quickstart without --php-version, it will be updated to 8.3 when you run ddev config --update.

I understand that you simply want to change the default PHP version for Drupal. I think it's reasonable, because we use --php-version=8.3 for Drupal 10 and 11 quickstarts.
This is the place to do it:
https://github.com/ddev/ddev/blob/ef57efe0bf601a2836c4242a514f487af9c36303/pkg/ddevapp/drupal.go#L359-L364
if err != nil || v == "" {
+	app.PHPVersion = nodeps.PHP83
	util.Warning("Unable to detect Drupal version, continuing")
	return nil
}

Thanks for bringing up this topic.

Thanks for a fast reply @stasadev and link to the /pkg/ddevapp/drupal.go file. I tried adding a line via a PR, maybe that's all it takes?

Yeah, but it also needs a change in tests here:
https://github.com/ddev/ddev/blob/ef57efe0bf601a2836c4242a514f487af9c36303/pkg/ddevapp/apptypes_test.go#L68

Ah yes, thanks -- I updated that file as well.

If people do the recommended ddev config --update then Drupal 11 sets things to PHP 8.3 already. Could you please see if that does the job for you?

As discussed in the PR, DDEV already handles this correctly and has for some time. Closing for now, happy to continue the conversation.

Thanks for fast replies as always @stasadev and @rfay, I really appreciate it. You and the rest of the DDEV team do a stellar job maintaining and expanding the DDEV tool with new features, it makes working with Drupal so much easier. I do disagree with not setting the default PHP version to 8.3 for Drupal, and have added a comment in the PR.

If you use the community-agreed approach with ddev config --update, you won't need the --php-version=8.3, because it's the job of ddev config --update to detect that. See the Drupal 10 and Drupal 11 instructions in https://ddev.readthedocs.io/en/stable/users/quickstart/#drupal-drupal-11.
Didn't you promote that approach?
Note that DDEV v1.24.0 in late November or December will have PHP 8.3 default for everything that doesn't have other specifications.

Adding my comment from PR #6307 (June 14th 2024) as well, for completeness:

I am a big proponent of removing extra steps and parameters, as can be seen in Make Composer create-project As Lean As Possible (ALAP). This issue was a success, since extra parameters are no longer needed, and the most basic version of a command such as this works well:
composer create-project drupal/recommended-project
Extra steps and parameters can become like magic dust for the user to sprinkle, sometimes without really knowing what it does, or why it's there (--update). And simply put, extra steps and parameters are just annoying.
Also, I do believe that the correct thing to do is make the default PHP version for Drupal the currently recommended version, which is PHP 8.3 for both Drupal 10 and Drupal 11.
I am very grateful for the simplified drupal type, but actually, it says right there in the Issue Summary of the issue:

Solution
Unify Drupal 8+ under a drupal project type, following the recommended PHP version for the current release [my emphasis] (Drupal 10 and PHP 8.1)

#4957

The default for Cake is already set to PHP 8.3, so why not also for Drupal?
https://github.com/ddev/ddev/blob/375963b4625d8e709773002e839ef3e2bf9a67b5/pkg/ddevapp/cakephp.go#L79
I hope at least this issue can be reopened, possibly as postponed, and that the default PHP version can be set to PHP 8.3 for Drupal by the end of July 2024, at the latest, since Drupal 11 will be released there, and it requires PHP 8.3.

Related conversation in

https://github.com/ddev/ddev/issues/6633

We obviously need to keep talking.
Note that DDEV did in fact change the default version for D10 and D11 to PHP8.3 before release of D11. It just didn't change the default for drupal. And of course, there's the dependency on ddev config --update figuring it all out.

By all means, let's keep talking ... but I think I have my point of view clear by now :-)
What do you think about my proposal?

Perhaps moving forward, DDEV could try to keep default PHP version in sync with Drupal PHP requirements, so that the default PHP version is identical to the current release of Drupal? https://www.drupal.org/docs/getting-started/system-requirements/php-requirements#versions

Followup,

https://github.com/ddev/ddev/issues/6635


Add globalPrefix.

It needs some work.  I will create pull request later.  It was committed to the wrong fork by mistake.


Contact form susceptible to spam

Summary
Contact form already has spam being sent to it.
Details
Need to add some sort of bot protection. Possibly the hCaptcha pages plugin. Akismet is used by the paones WP.
Cloudflare functions docs

https://www.youtube.com/watch?v=OjDmgGN5Gio
Basically, Web App Firewall rule to offer a captcha  if they are not coming from a US based IP address.
Under consideration.

Can be tested with someone that has a VPN that can show request origination from various countries / locales.  I do not currently have one of those services.

@kerryhatcher Perhaps this can be setup and applied quickly, the rollback plan is very simple and straightforward (turn off the FW rules).  Do you want to try it today?

working on this starting today


ci/lint: add integration tag

In the current PRs (#325 and #335) we have an issue with the linter failing on a dead code in integration tests. The linter isn't failing on main_test.go file because it somehow ignores the integration tag. However, it fails on other files which main_test.go depends on and which have the integration tag.
This commit tells golangci-lint to always use the integration tag while doing the inspection.
I think there shouldn't be any false negatives resulting from this change. However, I may be wrong, feel free to correct me.
Another solution is to turn off the deadcode linter in the affected files, however I think that this PR solves this issue more elegantly.
Note: This commit doesn't have any effect on our current codebase.

The integration tag is enabled for linting all the files. Unfortunately, I couldn't find a way to apply a tag only for some paths.


generate_site_positions.py how to use for non model organism

Hi,
It appears that generate_site_positions.py only accept human as a reference. Can I use anyhow generate_site_positions.py for a nonmodel organism?
Thank you in advance.
Michal

Hi,
The generate_site_positions.py can be used for any organism. I guess the confusion was that it has some default settings for some standard human references when its called with only 2 parameters.  When the generate_site_positions.py is called with 3 parameters the 3rd one is the location of the reference fasta file of any genome. The 2nd parameter (arbitrary name of the genome ) will be used to name the output file.

Please see Issue #64
Github Issues is for bugs - please post questions to our forum.


Fix some issues in question-the-docs

Codecov Report
Patch and project coverage have no change.

Comparison is base (e8adaa3) 78.62% compared to head (3bfe428) 78.62%.

:exclamation: Current head 3bfe428 differs from pull request most recent head 20c42a2. Consider uploading reports for the commit 20c42a2 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #906   +/-   ##
=======================================
  Coverage   78.62%   78.62%
=======================================
  Files          90       90
  Lines        5783     5783
=======================================
  Hits         4547     4547
  Misses       1236     1236

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


⚠ Bofrost.fr has degraded performance

In d0a8110, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1572 ms

Resolved: Bofrost.fr performance has improved in e28b136 after 20 minutes.


Use bind mount for /tmp/.X11-unix for better compatibility.

Is your feature request related to a problem? Please describe.
Some programs (Eg. snaps, flatpaks) need to remount it in the chroot environment. But symbolic link can't be remounted.
Describe the solution you'd like
Make it a bind mount instead of a symbolic link.
Describe alternatives you've considered
None.

Good suggestion, I've made this change and it will be available in the future version of WSL.

Has this fix been released? Encountered this issue with WSL and Steam today.
WSL version: <IP_ADDRESS>
Kernel version: <IP_ADDRESS>-2
WSLg version: 1.0.60

Error:
bwrap: Can't mount tmpfs on /newroot/tmp/.X11-unix: No such file or directory

Workaround (no idea if this is the correct way to do it):
sudo rm /tmp/.X11-unix
mkdir /tmp/.X11-unix
sudo mount --bind /mnt/wslg/.X11-unix /tmp/.X11-unix


🍒 Cherry pick PR #3481 to staging 🍒

🍒 Cherry pick https://github.com/Expensify/Expensify.cash/pull/3481 to staging 🍒

🚀 Cherry-picked to staging in version: 1.0.66-5🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production in version: 1.0.68-4🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Add debug services(GraphQL) in query protocol

@kezhenxu94 @hanahmily We have been suffering the runtime debugging issues in the prod env for months. I want to discuss whether we should consider adding a new type of GraphQL service, named debug.
debug catalog should be a group of interactive services, provided from OAP instance level. Because of this, no query should be done through UI webapp or load balancer.
A demo command of debug service should like this(Ignore the format, I don't write it in GraphQL grammar)

debug start --target als-k8s --duration 5m
debug statistic
debug clear

We should work on a statistic API, very similar to the internal observability APIs, but because it only works after receiving the start command with a certain duration. Then, we could get the result as a statistic table until

The next debug start
debug clear
20min(or another threshold value) passed.

FYI @apache/skywalking-committers You may notice we could use this in the agent trace/meter/log analysis statistic.
The major difference between debug API and telemetry APIs is not from a tech perspective, it is more from a usage scenario. The debug API implementation could be more aggressive and provide more context in on-demand debugging.

why not just add them to the s11y metrics?

Because it causes too much.

Can you provide some more example statistics?

Such as we could

Get the IP list, which can't be successful analysis in the ALS IP mapping.
Provide the IP list of services, which don't provide metadata exchange and falling into IP mapping.

debug API is not about performance, like telemetry API. It focuses on status, and has a chance to list all unexpected statuses, due to limited resources(memory most) cost required.

@wu-sheng and I discussed this solution a few weeks ago. After that, an auto-config log4j gives more help than dynamic statistics. . We should promise to change the logging level on the fly since rebooting OAP would cover up the problems.
The reason is :

Logging has more details than metrics, which will give our users more flexible paths to investigate issues.
Logging would use fewer resources than specific metrics with some turn-on/off switches.

For this issue, if the ALS-related debugs logging is active, the user will leverage grep and wc to filter and statistic objects they want. We might provide some instruments about how to statistic the key metrics, or enhancement swctl to handle logs.
Future more, log4j has provided some ways to implement auto-config. We will not have to introduce any new APIs.

If dynamic log config helps, feel free to rename this issue and rewrite comments.
The point of submitting this, we need a way to help identifying.

I agree. Logs have more details and switching logging level is a more common debugging approach.

@kezhenxu94 I am going to close this. Please file another one for changing log level in the runtime.

In favor of https://github.com/apache/skywalking/issues/7114


docs: add SPDX license identifier (part 2 of 2)

What type of PR is this?
/kind cleanup
/kind documentation
Any specific area of the project related to this PR?
/area driver-kmod
/area driver-bpf
/area driver-modern-bpf
Does this PR require a change in the driver versions?
NO
What this PR does / why we need it:
See https://github.com/falcosecurity/evolution/issues/318
Special notes for your reviewer:
This PR is a follow-up to https://github.com/falcosecurity/libs/pull/1387
Does this PR introduce a user-facing change?:

NONE

Please double check driver/API_VERSION file. See versioning.
/hold

Bumping API_VERSION is not required in this case.
/hold cancel

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: incertum, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

driver/OWNERS [incertum,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: incertum, leogr, LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

driver/OWNERS [LucaGuerra,incertum,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Add LLDAP to COMMUNITY.md

See #403

Wait, no, it's already there.

😄 I updated the line according to your PR


Add WhenExpressions to variable substitution documentation

Changes

We have a table that documents all fields that accept variable
substitution, and the fields in WhenExpressions need to be added.
This change documents that input and values fields in the when
field accept variable substitution.
/kind documentation
Thanks to @bobcatfish for the catch! 😀
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[x] Docs included if any changes are user facing
[ ] Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

NONE

/lgtm

/test tekton-pipeline-unit-tests


Platform specific theming

Description
Early feedback from native developers suggests that the theming system is to "web" based and needs to incorporate native platform elements. This is an umbrella issue tracking these requests / progress on these issues.
These include

[x] StyleSheet.hairlineWidth
[x] Platform Colors
[x] Device reactive styling (eg text scaling)
[x] Platform specific values in the base theme

Not supporting platform values appears to be a blocker on proper support for RN for Windows & MacOS where these values are widely used.

Tracking this via https://github.com/marklawlor/tailwindcss-react-native/issues/76


Please provide installation instructions for react-native v0.29

I followed the steps in the README, but I am getting a gradle error
* Where:
Build file 'C:\Users\Damilare\trybal\android\build.gradle' line: 27

* What went wrong:
A problem occurred evaluating root project 'myApp'.
> Could not find method compile() for arguments [project ':react-native-android-statusbar'] on root project 'trybal'.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 10.566 secs
Could not install the app on the device, read the error above for details.
Make sure you have an Android emulator running or a device connected and have
set up your Android development environment:
https://facebook.github.io/react-native/docs/android-setup.html

This is my settings.gradle
rootProject.name = 'myApp'

include ':app'
include ':react-native-android-statusbar'
project(':react-native-android-statusbar').projectDir = new File(settingsDir, '../node_modules/react-native-android-statusbar')

This is my build.gradle
dependencies {
    compile fileTree(dir: "libs", include: ["*.jar"])
    compile "com.android.support:appcompat-v7:23.0.1"
    compile "com.facebook.react:react-native:+"  // From node_modules
    compile project(':react-native-android-statusbar')
}

Yes，there are some changes to be incorporated to make it 0.29 ready. Will
make the changes soon. Will be glad if you can make a PR:)
On Jul 17, 2016 10:44 AM, "darmie"<EMAIL_ADDRESS>wrote:

I followed the steps in the README, but I am getting a gradle error

Where:
Build file 'C:\Users\Damilare\trybal\android\build.gradle' line: 27

What went wrong:
A problem occurred evaluating root project 'myApp'.

Could not find method compile() for arguments [project ':react-native-android-statusbar'] on root project 'trybal'.

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED
Total time: 10.566 secs
Could not install the app on the device, read the error above for details.
Make sure you have an Android emulator running or a device connected and have
set up your Android development environment:https://facebook.github.io/react-native/docs/android-setup.html
This is my settings.gradle
rootProject.name = 'myAppl'
include ':app'
include ':react-native-android-statusbar'
project(':react-native-android-statusbar').projectDir = new File(settingsDir, '../node_modules/react-native-android-statusbar')
This is my build.gradle
dependencies {
compile fileTree(dir: "libs", include: ["*.jar"])
compile "com.android.support:appcompat-v7:23.0.1"
compile "com.facebook.react:react-native:+"  // From node_modules
compile project(':react-native-android-statusbar')
}
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/NishanthShankar/react-native-android-statusbar/issues/14,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHiF70L_H3_czJD_UpyZd2kyN8IVOB0sks5qWboagaJpZM4JOJ9D
.

up

Please run npm publish as the 0.1.3 is not yet available in npm.
Thanks!

Done

I've added instructions in this PR https://github.com/NishanthShankar/react-native-android-statusbar/pull/18

Done :). Sorry for the delay .. Have been held up


DVC README

Review the README in https://github.com/iterative/dvc since it is the first thing some users see, and it includes sections like "Comparison to related technologies" that may need to be updated and/or integrated into dvc.org.
UPDATE: See some ideas in #2443

Should we merge or clearly separate with #2443?

I vote to keep separate since #2443 is more general about the structure of a readme and applies across products. This one is specifically a need to review the dvc readme. I view #2443 as more of an epic/discussion ticket and this one as a narrower one under that, but as long as we end up reviewing the dvc readme, I'm open to however you want to structure the tickets.

I see you and @casperdcl already came to the same conclusion in #2443! Yay, more agreement!

Closing in favor of #2443


Columns in OneDrive

Regarding this comment: You can also create a view of the library that contains the Labels column or Item is a Record column, so that you can see at a glance the retention labels assigned to all items and which items are records. Note, however, that you can't filter the view by the Item is a Record column.
Is this only available on the Admin side? I can't see that there is any column available to the end user to view "Record column" on SharePoint or OneDrive. Please provide more context on where this column is made available.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 315ad620-438b-dae8-26df-258406e97152
Version Independent ID: 6850f86a-00b4-cc5d-b1eb-ae48d5f7025a
Content: Learn about retention labels - Microsoft 365 Compliance
Content Source: microsoft-365/compliance/labels.md
Service: o365-seccomp
GitHub Login: @cabailey
Microsoft Alias: cabailey

@CarissaB117  In SharePoint, you're looking for the "Add column" > "Show/Hide columns" option.  Documented here: https://support.microsoft.com/en-us/office/show-or-hide-columns-in-a-list-or-library-b820db0d-9e3e-4ff9-8b8b-0b2dbefa87e2

@CarissaB117  I double-checked, you can't add columns in OneDrive.  Updated the page to make this clear and added the how-to instructions reference.  Thanks for your feedback!  Closing.


Integrate mediasdk c2 to celadon

This change is to integrate mediasdk c2 to celadon platform.

@dyang23 , @iViggyPrabhu , could you please help review this PR?


Updated the Readme.md and Added Code_of_Conduct.md

I updated the readme.md for readability purposes and to outline specifically how to use the application.
I also added the code_of_conduct which was noticeably missing from the github repo.
I'm not sure what license you would like to use in this app but I think it would be wise to use the MIT license or GPL 3.0 license if you want open/closed sourcing for forks of this app.

Fair enough! Thanks for contributing!


dnscrypt denying the existence of debian.org

I installed dnscrypt according to this.
Then I tested ./dnscrypt-proxy --resolve debian.org as well as ./dnscrypt-proxy --resolve raspberrypi.org. I know for sure that those are real websites, but as you can see in my screenshot dnsproxy says

Domain exists:  probably not, or blocked by the proxy

I was able to solve this, by enabling ipv6 Server in the .toml and reinstalling. (Even though my Network in its current configuration does not understand ipv6)


client.loader: Add support for aliases for known implementations.

This allows us to whistle up aliases for implementations such as ax
for Niagara AX, etc.  Further implementations can be added to this file,
and they will be loaded when needed.

Coverage decreased (-0.01%) to 42.654% when pulling e4a9c346eb06e760a9ccd97a5c8e1d087e4ff73c on vrtsystems:feature/implementation-aliasing into 15cb65c392c0e8db7791b0b2e4ba3dd183fd6137 on ChristianTremblay:develop.


Update Mutiny Destination to Remove support for page events

Proposed changes
Remove documentation about tracking "page" events because the Mutiny destination does not support these events
I'm not sure how to remove "Page" from the destination info card at the top of the page. It doesn't seem to be part of the markdown

Merge timing

ASAP once approved

Related issues (optional)

@choncou Thanks for opening this PR. To update the destination info card, we need to make a couple of back-end changes.  You should see those changes reflected on the Mutiny page by 2 August 2024 at the latest.


Run on 3.11, and upgrade one package at a time.

I should have explained: I added the typing dependencies, then ran make upgrade-package package=types-PyYAML to only add the newly added packages.  So the generic upgrades haven't happened yet.  I would like to wait on the broad upgrades until we can review their changelogs.


[Bug] Upload/Download for 2.4GHz reversed

The problem
It looks like the upload data (total and speed) and download data (total and speed) for 2.4GHz wireless is reversed - the actual upload speed is listed as the download speed, and the actual download speed is listed as the upload speed.
Your device model
RT-AC88U
Firmware type
Merlin
Firmware version
<IP_ADDRESS>.386.12_4
Integration version with the issue
0.27.1
Method of the integration installation
HACS
What version and type of Home Assistant installation do you use
Core 2023.12.4
Is there anything useful in the logs?
No response
Diagnostics information
No response
Additional information
No response

After looking a little more, I realized this is just me misunderstanding what I was seeing. Apologies for opening a superfluous bug report.

Hello. Not a problem 🙂 In case you will have any questions or issues with AsusRouter or your Asus device, feel free to ask


Publish documentation on ReadTheDocs

Setting up Sphinx/RTD config would allow automated publication of project docs.
This approach was mentioned here: https://github.com/efabless/openlane/pull/121 , as a suitable alternative to GitHub pages.

@wgryncewicz: This is now merged to master. Thanks for the awesome work!
https://openlane.readthedocs.io


Adding "Subscription required" checkbox in new APIM v4 task

Added v4 task for "apim" - "API Management - Create/Update API". The only change from v3 of the task is the addition of the "Subscription required" checkbox.
I've tested in different scenarios:

created new API with checkbox on
created new API with checkbox off
updated API and turned the checkbox from on to off and vice-versa.

Hi Sorin,
Thanks for your contribution.
Best Regards


Best way to use it with "shared-bus" crate

What is the best way to make this compatible with https://docs.rs/shared-bus/0.3.1/shared_bus/ ?
A kind of proxy to implement I2c ?

Hi!
I have not used shared_bus with this device, but I used it with two other driver crates that I made. You can check it there.
On my side, I don't see any special problems with using this with the crate. However, I think that there are approach to solve the kind of problems related with shared_bus usage directly in embedded-hal.
Could you tell me more on your use case ?

Hi sorry for late reply, cause I was digging in for this problem :)
I'm keen on Rust but new on embedded programming with it.
I'm trying to use this driver M5StackCoreS3 and the way I came along is;

learned that I need to use https://github.com/georgik/aw9523-rs.git (thx alot to @georgik and your samples)
shared_bus uses embbed-hal=0.2.0 and so does aw9523 library
i ported down your driver ft6x36 to work with embedded-hal=0.2.0

but now when I see your samples for TWatch2020-V1 you are using an interrupt and not sure how to find it for M5StackCoreS3.
The docs https://docs.m5stack.com/en/core/CoreS3 talks about an interrupt(AW9523B_P1_2) on aw9523 extension here and trying to understand what that is :)
I would be appreciated if you help an amateur in embedded programming with Rust

Hi!
I'm not considering myself an expert on those subjects, so you should not take my advices for granted 😅
However feel free to ask other questions if my explanations are not clear.
Bypassing interrupts and polling
Interrupt handling is not mandatory, as a first approach, I would try using the "usual" loop with polling on the device. In which case, you would ignore the interrupt handling part of my code and just poll with get_touch_event and maybe process_event in the loop.
Interrupts
If you want to use interrupts it would be a bit trickier:
If I understand correctly in your case the FT6336 interrupt line is connected to a AW9523 GPIO.
But those pins are not exposed directly on the ESP32, you have to use the I2C bus to query or set them up. And rely on the global AW9523 interrupt line to be notified when an interrupt occurs on a AW9523 pin that you setup correctly.
I guess setting all that is required for this would be:

a dedicated driver to handle the AW9523
setup the pin correctly and handling the interrupt correctly
I would check the C examples here and here.

I'm appreciated thanks a lot for the clue.
Will let you know if I can go further.
Regards :1st_place_medal:

You're welcome :)
I will close this for now, feel free to reopen it or an other issue if you have other questions.


Native Automation seems not working for .checked, ctrl+a in pressKey(), stringifyRequestBody: true in RequestLogger, service worker

What is your Scenario?
In order to use some packages using private in test, I have been testing from --experimental-proxyless to native automation mode for quite amount of time.
What is the Current behavior?
I found some issues that I could not resolve.

.checked of Selector is always false no matter click
ctrl+a does not work for pressKey()
stringifyRequestBody: true returns broken string
service worker is not working at all

This attached file is for a demo what I have tried to confirm on my side:
testcafe-typescript-vue-report.zip
What is the Expected behavior?
All should be working as in normal mode which is no --native-automation
What is your public website URL? (or attach your complete example)
Please see testcafe-typescript-vue-report.zip file above
What is your TestCafe test code?
Please see testcafe-typescript-vue-report.zip file above
Your complete configuration file
No response
Your complete test report
No response
Screenshots
No response
Steps to Reproduce
(See README.md)
yarn install
yarn serve

Open another terminal and run:
yarn test:na

TestCafe version
2.5.0
Node.js version
18.14.0
Command-line arguments
(See package.json) npx testcafe chrome --native-automation
Browser name(s) and version(s)
No response
Platform(s) and version(s)
No response
Other
No response

Hello.
Thank you for sharing your test cases. I got the following results:

.checked of Selector is always false no matter click

I did not manage to reproduce this issue:

ctrl+a does not work for pressKey()

I did not manage to reproduce the issue. It works for me.

stringifyRequestBody: true returns broken string

I could reproduce the issue with version 2.5.0. However, it has been fixed in master but has not been published yet.

service worker is not working at all

I reproduced the issue. Thank you. For some reason, this test fails even without native automation mode on.

@AlexKamaev Hi, thanks for clarifying this. Did you try to run  the attached file (testcafe-typescript-vue-report.zip) above? Except for .checkbox, all happens in my local env.
Here is my recorded video:
https://user-images.githubusercontent.com/16159767/235088694-d130aeaf-4294-42a8-8b77-16d48afb6807.mp4
For .checkbox, is there any possible case that TestCafe cannot read the value properly? e.g. Web compile setting
Since I have tried to make almost same env with our project from scratch but it happens in our project only. FYI, without native automation mode it works well.

@AlexKamaev Hi, any update or suggestion for this? :bow:

@daenamkim
We did not have a chance to research your usage scenario in greater detail. The fix with the post request will be published in the next TestCafe release. Regarding your other usage scenarios, we'll check them again once we start working on the issue.

Hi @daenamkim,
Please try to run your test suite using the latest TestCafe master branch. You can get it from here: https://github.com/AlexKamaev/issues/raw/master/testcafe-2.6.1.tgz.
Let us know your results.

@daenamkim
I'm happy to hear that the issue with serviceWorker is solved. As for the ctrl+a issue, the test passes in my case as well. Did you make some modifications in your test or in you app? If you can share your latest example version or prepare another one (perhaps witout Vue) we would love to continue the research of described problem.

@AlexKamaev Thanks for testing again for me. I have tested again I can see the error consistently. I have attached a test code to see the error. It would be glad to know that I did something wrong.
Operating system
13.3.1 (a) (22E772610a
Chrome:
Version 113.0.5672.126 (Official Build) (arm64)
Node:
node --version
v18.14.0

TestCafe
yarn install
npx testcafe -v
2.6.1

Steps to reproduce
Download testcafe-typescript-vue-report.zip
yarn install
yarn test:na

@daenamkim We reproduced the issue. It looks like it is specific to MacOS for some reason. Thank you for your cooperation.

Release v3.0.0-rc.1 addresses this.

Release v3.0.0-rc.1 addresses this.

It is so beautiful! Thanks!


Ractive 0.7 doesn't allow subsequent output?

I just upgraded from 0.6 to 0.7. I got this error:
"Uncaught ParseError: Expected closing delimiter '}}' after reference at line 22 character 40:
<div class="message-item {{ type }} {{ new }}">

I changed nothing with the template. But apparently having two mustaches in a row fails in 0.7.2?
I reset to 0.6.1 and no longer have the error.

The issue is actually the reference named new. The parser got a pretty big refactor for the 0.7 release. The general policy is that javascript keywords are disallowed where they would be invalid in a regular javascript expression (freestanding new in this case).

Would this be a better error situation or does that error make enough sense in context?

There's nothing wrong with the template (given that example), which makes Expected closing delimiter '}}' error rather... confusing. If the main source of the error is new, then it should throw at new. Probably something like "[keyword] is a reserved keyword"

Reminds me of how JS throws "Unexpected identifier" errors when you miss a comma in an object literal. It throws at the next key, and not where the comma was missing. Though correct, but still confusing.
var foo = {
  bar: 'baz'      // missing comma here
  hello: 'world'  // JS throws here
};

keywords seems to be allowed with dots - {{ .new }} is not throwing an error.
Related issue - https://github.com/ractivejs/ractive/issues/1497
There should some meaningful error verbiage required.

Ah, I see. I thought references were essentially treated as quoted key names. Unless you're saying that new is allowed as part of an expression now? What's the expression conflict?

new by itself is not allowed as part of an expression. However, it can't be completely banned, because you can assign it as an object property:
var foo = {};
foo['new'] = 'bar';
// no errors, 'new' is a string
// then you can access it using dot notation, just like in ractive
foo.new;      // 'bar'

Since expressions allow basic javascript to be executed in them, they must act like javascript does. Therefore, a lone new operator is not considered a reference. You must retrieve it using dot notation. This quirk is not something that ractive does, it's a quirk with the way javascript objects work.

@fskreuz I have to agree with you there, but that error doesn't really tell the person that they need to 'escape' the new in order for it not to get parsed as an operator. If I saw that I'd probably go and rename the variable new instead of prefix it with a dot. Although renaming it is arguably the better solution since having a variable named new is probably not the best idea anyway.

I went back to 0.6.1 because of 0.7.2 instability. 0.6.2 triggers an error on .new (with the dot), but does so at the dot position, which yes, is a better error.

@matthew-dean when you say 'instability', are you referring solely to this issue or to other things?

@Rich-Harris Sorry about the ambiguity there. What happened for me with 0.7 is that I suddenly had all sorts of rendering errors in my UI. What I later figured out is that I had ambiguous references in my templates, and for whatever reason, 0.6 was more fault-tolerant than 0.7 to recursion. Which may not be a bad thing. Having more consistent errors in 0.7 (when I switched back again after I saw that the errors happened in both places, just less often in 0.6) meant that I figured out it was an ambiguous key reference problem, leading to recursion.
I do have another major problem, that's persisted across both versions, but I'll try to find the time to post that as a new issue.

@Rich-Harris I opened a new issue at #1952, thanks.

See #2308


quotes in titles break displayed title when looking at the link edit page

Make a title like this:
this is a "title" yay
When you go back to the link edit page you see the edit box title of:
this is a
and that is bad!

The html escape function can be used here.


The app crashes when I set CanTearOutTabs="True" on the TabView

Describe the bug
When I start the program and select one of the tabs, the program crashes.
Steps to reproduce the bug
Create a new project with "Blank App, Packaged (WinUI 3 in Desktop)".
Edit MainWindow.xaml like this:
<Grid>
   <TabView CanTearOutTabs="True">
      <TabViewItem Header="Test1" />
      <TabViewItem Header="Test2" />
      <TabViewItem Header="Test3" />
   </TabView>
</Grid>

Expected behavior
No response
Screenshots
No response
NuGet package version
Windows App SDK 1.6.1: 1.6.240923002
Packaging type
Packaged (MSIX)
Windows version
Windows 10 version 22H2 (19045, 2022 Update)
IDE
Visual Studio 2022
Additional context
No response

I can confirm this issue. When you start to drag a tab it crashes immediately.

I've also encountered this.

The release notes regarding v1.6.0 mentions that "Notably, tab tear-out is supported in processes running elevated as Administrator.".
Could it be related?

You need to do more than just set the property to True. There are 4 other TearOut methods required to complete the experience. The first one creates the new Window, so I assume it's crashing when it doesn't have one, maybe?
We're demoing how to do this in the "What's New in WinUI and Windows App SDK 1.6" session tomorrow at .NET Conf.
In the meantime, see the sample update in the WinUI Gallery here: https://github.com/microsoft/WinUI-Gallery/pull/1629

FYI:
I'd used the changes in that gallery pull request to try out the tear off tabs feature, and while it was useful I did need to make a few changes to the code. The updated code is in the rero project attached to #10155  It may be worth taking a look.
If I remeber correctly the main problem was if you had two windows both containing tab views and in a single drag operation you tear out a tab from the first window. Then move the torn out window over the second windows tab headers (the torn out window closes and the tab is transfered to the second window's tab view). Then while still holding down the left mouse button continue dragging the tab out of the second window to create another tear out. That crashes the code because the second window hasn't created that tear out window.


Source code was not found

Getting this error on Sentry:

Everything works perfect on my local

What is Sentry?

just a platform to track and fix errors in real time. Let's say I get that on production and not locally

So just as a general answer,  how are you copying files to production? Perhaps that process is accidentally missing that file during the copy ? It could miss other just that os the first error and is bailing out.
I would start investigating the process that is being used to copy files up to check if that file is being included or not.

Closing as stale.


[rmqcpp] Update to latest revision

Fixes #38736

[x] Changes comply with the maintainer guide.
[x] SHA512s are updated for each updated download.
[x] The "supports" clause reflects platforms that may be fixed by this new version.
[x] Any fixed CI baseline entries are removed from that file.
[x] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.*
[x] Only one version is added to each modified port's versions file.

*--overwrite-version was used, as this is still 1.0.0, minus a build failure.
I thought having a version like 1.0.1 or 1.0.0-1 could be a confusing divergence from the lib's versioning and didn't really make sense. Let me know if I should patch it with something different. :saluting_face:

About that version thing, I saw there are port versions and thought that would be the place to indicate the change. I wanted to go and edit that but I don't exactly know how this bit works (couldn't find  and, scared to break things, I've rolled it back to an overwritten version.

@SirWrexes Thanks for posting this PR. You can refer to versioning  for more information about the version. :)

@microsoft-github-policy-service agree

So, if I get this right, I should run vcpkg x-add-version --all --overwrite-version, then go edit the versions file to have port-version: 1, commit, push and we're good ? :thinking:

@SirWrexes
Steps for version update:

Modify the field version of file vcpkg.json to the latest version number.
Delete the filded port-version of vcpkg.json.
Run command .\vcpkg.exe install [port-name]:x64-windows to generate a new SHA and update the SHA in portfile.cmake.
Submit a commit
Run the command .\vcpkg.exe x-add-version [port-name] .
Submit a commit.
Push the code.

If it is not an updated port version, then:
Replace the second and fifth points with the following code
2. The value of port-version +1.
5. Run the command .\vcpkg.exe x-add-version [port-name] --overwrite-version .

@SirWrexes A simple example PR. Hope it helps you. :)
https://github.com/microsoft/vcpkg/pull/40024/files

Despite setting the port to checkout a more recent commit, the package in question indeed doesn't change version.
1.0.0 remains the targeted version, as this is the only one available, with the difference that with this fix it builds successfully—tested with an overlay. :)
After reading a some more documentation (including the one you've link) and understanding the tooling better, I found I could set port-version inside the vcpkg.json of the port, which would in turn make sure that versions/baseline.json is updated accordingly, as well as versions/r-/rmqcpp.json, preventing any destructive operation while retaining the behaviour of making this fixed port the default for 1.0.0.
I'm sending the changes now.

That should do it. Thank you very much for your time and help !

This port has a lot of host dependencies which do not make any sense.

Now that you mention it, yes, vcpkg-cmake and vcpkg-cmake-config look like the only ones that need to be set as host dependencies.
I tried applying the change and build went just fine.

Please disable tests in the vcpkg port. (https://github.com/microsoft/vcpkg/pull/40101#discussion_r1693930489)

Regarding this part, I've checked their CMake files and... I don't think that's possible ?

src/tests/*/CMakeLists.txt do not provide a way to disable their corresponding targets either, and any attempt to use set_property(TEST|TARGET|DIRECTORY ...) or the equivalent set_target_properties(), set_directory_properties() etc with PROPERTY EXCLUDE_FROM_ALL 1 as vcpkg works in script mode and isn't directly attached to/aware of the configuration set in the ports' builds themselves.
This should be a PR for the lib itself rather than its port. :thinking:

Please disable tests in the vcpkg port. (#40101 (comment))

Regarding this part, I've checked their CMake files and... I don't think that's possible ?

Then the simplest disabler is a patch which removes the add_subdirectory(tests).

Noted, will do when I get some free time (currently in a dev rush)! :saluting_face:

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review".
That way, I can be aware that you've responded since you can't modify the tags.

Hello there
I finally got some time for myself and added the patch to disable building tests (and example binaries too).
Let me know if I should cleanup the commit log/squash everything down into just two commits.

I got mixed in my commands and pushed the wrong commit when amending last commit. I'm embarrassing myself... :facepalm:

Done. By the way, sorry for being messy about it, and thank you very much for your patience and understanding. :heart_hands:

Versioning seems to be complete strange now. Misleading review comments.
So... Setting port version to 1 was actually right ?

If version is not incremented, port-version must be incremented.
If version is incremented, port-version must be reset to 0.
That is what I read from the docs and is precisely why I up'd the port version.
Shall I revert again and re-do the thing with port version set to 1 then ?

Would it be possible to clarify what is missing to merge this PR?
@FrankXie05 requested a change, which was later judged by @dg0yt to be wrong.
@FrankXie05 can you withdraw the change request? Or give some comment?

@FrankXie05 Thank you!
@SirWrexes It seems to be ready to merge!


How about using keyboards which defined with Australia English layout?

https://github.com/kachick/times_kachick/issues/318#issuecomment-2540350852
https://github.com/kachick/dotfiles/issues/963
https://note.com/kamemushi_works/n/n65ab71ca98ec
https://x68kace.hatenadiary.org/entry/2024/04/01/012357

I don't want to introduce any more complexity in the use of keyboards.


Download button is not working properly

After applying many settings, the download button is loading only but not downloading. The download location is also wrong.

hey, this is fixed. i have pushed a temp solution for now. what do you mean by download location?

Hey @rutikwankhade ,
Thanks for your reply. I am using Linux OS for downloading. By default, the download location should be Download folder, but after click the Download button, the picture was downloaded in a random system folder.
After manually fixing the Download folder, it is working fine.


WIP: Allow for optional divider between radio items

It used to be a feature in GOV.UK Elements and it's not currently available in our macros.
Direct url: https://govuk-frontend-review-pr-849.herokuapp.com/components/radios/with-divider/preview
Todo:

add test
test in browsers
regenerate readmes

Fixes: #729
Works fine with conditional reveal as well.
Best to get in after: #846

@dashouse question about text alignment in relationship to the radio. in elements it's aligned to the left

Design wise 👍

requires rebasing and changelog due to 1.1.1 release


Any commands for stopping Elasticache?

I use AWS Elasticache for Redis and also can shut that down or stop it to save some costs, really thanks for this project, looking for something like it for a while now!

@mding5692 just released v0.0.7 with snapshot-remove-elasticache-redis trick. Give it a try on your development env and let me know if it has any issues :)
Since it's an experimental trick, you can try it by:
aws-cost-saver conserve --dry-run --use-trick snapshot-remove-elasticache-redis

and if it correctly detected your ElastiCache cluster (you can look in the resulting aws-cost-saver.json file), then remove the dry run:
aws-cost-saver conserve --use-trick snapshot-remove-elasticache-redis


python38Packages.tuya-iot-py-sdk: 0.6.3 -> 0.6.6

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python38Packages.tuya-iot-py-sdk is: "Tuya IoT Python SDK for Tuya Open API"
meta.homepage for python38Packages.tuya-iot-py-sdk is: "https://github.com/tuya/tuya-iot-python-sdk"
meta.changelog for python38Packages.tuya-iot-py-sdk is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.6.6 with grep in /nix/store/mjqkwnzzcczbxxg1kqjpcr6qv3y7vdk4-python3.8-tuya-iot-py-sdk-0.6.6

found 0.6.6 in filename of file in /nix/store/mjqkwnzzcczbxxg1kqjpcr6qv3y7vdk4-python3.8-tuya-iot-py-sdk-0.6.6

Rebuild report (if merged into master) (click to expand)

7 total rebuild path(s)

4 package rebuild(s)

4 x86_64-linux rebuild(s)
3 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
docbookrx
home-assistant
python38Packages.tuya-iot-py-sdk
python39Packages.tuya-iot-py-sdk

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/mjqkwnzzcczbxxg1kqjpcr6qv3y7vdk4-python3.8-tuya-iot-py-sdk-0.6.6 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python38Packages.tuya-iot-py-sdk https://github.com/r-ryantm/nixpkgs/archive/380f2c9c22328fc1f1ea6e5baff2c012440d37cf.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/mjqkwnzzcczbxxg1kqjpcr6qv3y7vdk4-python3.8-tuya-iot-py-sdk-0.6.6
ls -la /nix/store/mjqkwnzzcczbxxg1kqjpcr6qv3y7vdk4-python3.8-tuya-iot-py-sdk-0.6.6/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review took longer than 45m and timed out

Maintainer pings
cc @fabaff for testing.

Duplicate of #152016


Update to 0.0.9

All of my 361 plot invalid ,and all tsit missing .

me too,all my tsit are missing

We will send you missing tsit in a few days

thanks, recieved the missing tsit


L.GeoJSON#addData() doesn't work

Hi,
I have a L.GeoJSON layer that connects to a server and fetches GeoJSON data and adds the data it receives as a new layer. So I wrote this rough outline:
import L from 'leaflet';
import oboe from 'oboe';
import qs from 'qs';

export default L.GeoJSON.extend({

  initialize(options, geojsonOptions) {
    L.setOptions(this, options);
  },

  onAdd(map) {
    this._map = map;
  // Start listening for changes in the map boundaries, and trigger parcel fetch on any change.
    map.on('dragend', this.fetchData)
    map.on('zoomend', this.fetchData)
    // Connect to url and fetch data with Oboe.
    this.fetchData();
  },

  fetchData() {
    let {_northEast: ne, _southWest: sw} = this._map.getBounds();

    oboe(this.options.url + '?' + qs.stringify({ne, sw}))
      .node('features.*', (f)=> {
        // Gradually render the received parcels.
        this.addData(f);
      })
      .done(()=> {
        console.log('done', this.getLayers()); // => []
      });
  }
});

But this doesn't work because L.LayerGroup#addLayer, which addData delegates to, does not have a value for this._map, even though this value exists in L.GeoJSON and its immediate ancestor, L.FeatureGroup. I followed the call chain all the way through, and there is no other explanation. I'm mystified and don't have a clue where the map is getting lost. This has to be someone others have encountered before, so I hope I can find an answer here...
PS: I am using 0.7.3.

I figured out how to solve this. You need to call  L.LayerGroup.prototype.initialize.call(this, null); in the initialize function of your class. I guess that's sort of like calling super() after initializing. But calling super() on L.GeoJSON, which is the true ancestor, does not work because GeoJSON does not call super() on its own parent, so the call chain will end there.


Multiple sources at one time

As a user, I can pass in multiple youtube video IDs or multiple URLs to mp3/wavs and tbtbtc will transcribe and open individual pull requests per source

Shall we ask the user to provide the sources as CSV with no spaces in between

Let's hold on this for now. With playlists, I'm not sure how often this would be used.


Update TESTGUIDE.md

As a result of struggling with running and adding to the compiler tests recently, hopefully this will make things clearer for future contributors.

FSharpSuite are NUnit tests now.
Move RunAll.pl specific test.lst stuff to FSharpQA paragraph.
Add example of using build.cmd to run subset of FSharpQA tests.

Thanks


Question for training details

Due diligence

[X] I have done my due diligence in trying to find the answer myself.

Topic
The paper
Question
Hi, dear authors

Moshi pretraining and post-training
The two stages both involve a portion of text-only for language modeling training to preserve lanauge capability. I'm wondering which component produces the logit for next text token, is it the orginal LM head of Helium or the first prediciton of depth transformer?

Moshi pretraining
In the paper you mentioned:

We mask the corresponding text tokens with a probability of 30%.
Since we are doing generative modeling instead of BERT-style masked prediction, I don't quite understand what this means and why this is necessary

Multi-stream training
Starting from Moshi Post-training stage, the model continues to train on multi-stream data. In Figure 4, It's obvious that at inference time, the model always predicts "text token -> moshi stream" and ignores the user stream. But at training time, do you optimize on "text token -> moshi stream -> user stream"? i.e., do you calculate the loss of predicting user stream tokens?

Initialization for Moshi pretraining
Moshi is initialized from Helium, an un-aligned language model incapable of basic conversation and instruction following. Have you tried a Helium-instruct model to initialize single audio stream training? Maybe this can reduce the loss of language capability with following audio finetunings.

Thanks!

For the first question, it can be seen from the code that it is the temporal transformer that produces the logit for the next text token.


wheel zoom by multiplication

When zooming in really far, it starts to take forever to zoom any more.  The further you go in, the less "sensitive" the mouse wheel feels.
I've fixed this by multiplying by the zoom factor, rather than adding it.  For example, for a zoom factor of 0.03, it will multiply the current zoom by 1.03 for every tick of the mouse wheel.  This appears to naturally magnify by the same amount regardless of the current scale, and it feels much more natural.
I had to fork off of 1.2.3 because my project is using svg.js v2.  I'm not quite sure what's changed and whether I can go to svg.js v3 in an Electron project.  Hopefully you can at least get the idea from my commit.

can you please rebase your PR on the current master and force push? I cannot see your changes like this

Hi!  I'm not sure when I'll have a chance to rebase, but I think @kaalleen may have already done so in our fork.

We integrated this in the libraray now. We just need to release it. It indeed feels so much more natural. Thank you for pointing out!

Oh hooray, thank you!


Update managing-code-scanning-alerts-for-your-repository.md

Edited introductory paragraph and step 4 of the section to state that admin permissions are required to delete alerts.
Introductory paragraph changed to say, "Alternatively, if you have admin permissions for the repository, you can delete alerts."
and step 4 to "If you have admin permissions for the repository, and you want to delete alerts[...]"

Why:
The documentation doesn't currently state that repository admin permissions are required to delete alerts.

What's being changed:
Introductory paragraph changed to state "Alternatively, if you have admin permissions for the repository, you can delete alerts."
And step 4 of the section changed to say "If you have admin permissions for the repository, and you want to delete alerts[...]"

Check off the following:

[ X] All of the tests are passing.
[X ] I have reviewed my changes in staging.
[X ] For content changes, I have reviewed the localization checklist
[ X] For content changes, I have reviewed the Content style guide for GitHub Docs.

Thanks so much @JBryceOrtiz! I'll get this triaged for review 🌟


[quickie] fix side effect bug in governance power card

After using a proposal to revoke my membership in the DAO, I was getting an bug in a useEffect where a !'d realm object was actually undefined. I didn't really diagnose this issue, I just made everything type safe and made the deps exhaustive, and the issue seems to be resolved.

No idea why a test involving pubkeys is failing


Add support for  cref

Product
Hot Chocolate
Version
14.0.0
Link to minimal reproduction
https://github.com/kuglitsd/HotChocolateInheritdoc
Steps to reproduce
Run the project.
Inheritdoc only seems to be working for Implementations of Interface Methods. Everything else does NOT seem to work

What is expected?
The  tag should correctly inherit and display the documentation comments from the specified members, classes, or interfaces in the schema
What is actually happening?
Only the comment inherited from the IQuery interface implementation seems to work.
Relevant log output
No response
Additional context
No response

It's not inconsistent (it's working for the TestInterface method because that method exists on the interface that Query implements), Hot Chocolate simply does not yet support cref.
I've changed the title and type of this issue accordingly.


Problem with finetuning speed

Hi, thanking for the great work.
But when I tried to finetune the network on my own data, I encounter problems with efficiency.

If I set the num_workers in the Dataloader to >0, the data loading process becomes extremely slow and the loading time increases with each worker.
The time to backpropagate tho the graph (the time to execute this line of code) increases in proportion to the batch size.
scaler.scale(loss).backward()

I want to ask if this is normal in finetuning or have I somehow introduced a bug. Also, is there anyway to speed up?

Hi, Thanks for your interests.
I encountered a similar issue on another project on other servers.
The issue may be caused by the video reader we used decord. decord seems have some issue with pytorch's multiprocess in dataloader.
My solution is to add "spawn" when creating dataloader:
dataloader = Dataloader(multiprocessing_context="spawn",
                                          ....)


Unknown address of the DS18B20 temp sensor

Hello, I am using TTGO Lora 32 Oled with a few DS18B20 temperature sensors. My code uses DallasTemperature 3.9.0 library na OneWireNG 0.13.3 (I was not able to compile the code when other OneWire library used).
I have 60 pieces of DS18B20 sensors and 6 of them return UNKNOWN address, and about 10 of them return incomplete address - for example UNKNOWNf8 etc. What I am doing wrong or is there some error in the library?
Thank you!

Try to run DallasTemperature example from this lib and observe results on your setup.

Additionally you may try this app to check if your sensors are not just cheap Chinese counterfeits.

Thank you for the quick response!
I tried the example and it reads the address from all the sensors.
It looks that the problem is, when somewhere in the address is just one character.
For example when the address is 28:61:64:34:E8:31:E5:B (just the B at the end), then my code returns UNKNOWN.
In other case when the single character is in the middle of the address, my code returns just a part of address. For example 28:61:64:34:89:47:1:E5 returns just E5 (stops on 1)
Problem is probably in my code:
String getAddress(DeviceAddress devAdr, uint8_t idx) {
String adr = "";
for (uint8_t i = ADR_START; i < ADR_END; i++) {
if (devAdr[i] < 16) {
adr = "UNKNOWN";
} else {
adr = adr + String(devAdr[i], HEX);
}
}
return adr;
}

Show more code related to addresses, declaratiom, getting, printing etc.

@upeer  Try this:
String getAddress(DeviceAddress devAdr, uint8_t idx) {
String adr = "";

for (uint8_t i = ADR_START; i < ADR_END; i++) {
  if (devAdr[i] < 16) {
    adr += "0";
  } else {
    adr += String(devAdr[i], HEX);
  }
}

return adr;
}

@upeer you may look at printId() from DallasTemperature.ino how to print an 1-wire address.
I'm closing the issue as unrelated to the lib.

https://github.com/milesburton/Arduino-Temperature-Control-Library/blob/master/examples/oneWireSearch/oneWireSearch.ino
Example code

@upeer Try this:
String getAddress(DeviceAddress devAdr, uint8_t idx) {
String adr = "";

for (uint8_t i = ADR_START; i < ADR_END; i++) {
  if (devAdr[i] < 16) {
    adr += "0";
  } else {
    adr += String(devAdr[i], HEX);
  }
}

return adr;
}

@upeer Try this:
String getAddress(DeviceAddress devAdr, uint8_t idx) {
String adr = "";

for (uint8_t i = ADR_START; i < ADR_END; i++) {
  if (devAdr[i] < 16) {
    adr += "0";
  } else {
    adr += String(devAdr[i], HEX);
  }
}

return adr;
}

Thank you for your tips. I only changed the code to next one and now it works...
String getAddress(DeviceAddress devAdr, uint8_t idx) {
String adr = "";
for (uint8_t i = ADR_START; i < ADR_END; i++) {
String adPart = String(devAdr[i], HEX);
if (2 > adPart.length()) {
adr = adr + "0" + adPart;
} else {
adr = adr + adPart;
}
}
return adr;
}


Add unix methods

I think it makes sense to split up the unix() method into toUnix and momentFromUnix, feel free to change if you disagree!

@jsiebern tests failed, maybe you will need to handle timezones?


[DO NOT REVIEW] Update docs

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Label widget can not wrap when using chinese

Describe the bug
With the Label control, if Chinese characters are used, when the characters are too long, the Label cannot be displayed in a new line. However, if you use English characters, you can automatically wrap.
To Reproduce

create a new Label widget and set label is "这是一个很长的标签控件！这是一个很长的标签控件！这是一个很长的标签控件！这是一个很长的标签控件！这是一个很长的标签控件！这是一个很长的标签控件！这是一个很长的标签控件！这是一个很长的标签控件！这是一个很长的标签控件！这是一个很长的标签控件！这是一个很长的标签控件！这是一个很长的标签控件！这是一个很长的标签控件！这是一个很长的标签控件！"
startup app and watch display

Expected behavior
Any character (including Chinese characters, English characters) should be automatically wrapped when the string is too long.
Screenshots
Can't take screenshots, the current version of asciimatics can't display Chinese characters, it can be reproduced on the company's computer, but the company's computer can't connect to the Internet (I don't know the company is fucking delusion), so you need to repeat it yourself. Now it’s time.
System details (please complete the following information):

OS and version: CentOS 7
Asciimatics version: 1.10.0

Additional context
use this code to test: https://github.com/storezhang/asciimatics/blob/master/bug/app.py

Yeah - The logic for wrapping at the moment relies on breaking on white space.  However, it looks (to my Western eyes) that there is no white space in that label.
Is it sufficient if I just force the breaks on any arbitrary character when the line is too long to fit?

I can use a mobile phone to take a picture that can't be changed on the phone tomorrow. You can see it again. I am at home now, because the company's computer can't connect to the external network (for company policy reasons, the project is top secret, and the source code is leaked), so now Unable to provide an image that cannot be wrapped.

Don't worry about the screenshot.  My question is actually about how to handle Chinese writing...  Is there an equivalent to white space that I should also be looking to use to break up the string, or can asciimatics just decide that it needs to be N characters wide and so slice the string every N characters?

Conceptually, a Chinese character needs two English characters to display, but I'm not sure. You can try it.

@peterbrittain: Han characters are known as "wide characters", in that they need more than 1 byte.  You should probably look into how Python handles Unicode.

Yeah - I'm very familiar with the vagaries of the double-width characters.  That's all fine.
What I need is for you (as a native Chinese speaker) to explain how I should divide up written words in Chinese.  Ignore all the terminal issues for a sec and just tell me how you'd like to see this string formatted (and the logic you used to get there).  For example, can I just make it look like this:
这是一个很长的标签控件！这是一个很长的标签控件！这是一个
很长的标签控件！这是一个很长的标签控件！这是一个很长的标
签控件！这是一个很长的标签控件！这是一个很长的标签控件！
这是一个很长的标签控件！这是一个很长的标签控件！这是一个
很长的标签控件！这是一个很长的标签控件！这是一个很长的标
签控件！这是一个很长的标签控件！这是一个很长的标签控件！

@peterbrittain yes, Very right, just show it like that.

OK - I've just added some logic that simply splits on width if there is no white space.
(I also found another bug in the new colour themes that I've fixed at the same time in case you're wondering about the extra changes).

Yes - the other issue with master that you raised as #191 was also a bug, but that is also now fixed (by the other patch linked to that issue).  Just take master now and you should be fine.


use link: rather than file: for local dependencies

Hey, I just made a Pull Request!
Turns out file: copies when using yarn, meaning the package will only update whenever you run yarn install, and also leads to duplication. Using link: instead means yarn creates a symlink, which also seems to work well with workspaces with the link being created in the root node_modules rather than within the local package node_modules.
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

@freben they're peerDeps there, so not actually installed and no yarn.lock entry. They're just there for completeness


[Task 4] Implement a simple "Popup"

Implement a Popup in the following scenario:

There is a button on the page with the text "Show"
The Popup is shown when the user clicks on the button.
There is a black screen, and in the center, there is a white <div> with the text -> "Omri Uliel".
If the user clicks on the black screen, The popup closes.
If the user clicks on the white box, nothing happens.

hay.
i waiting for Another task for me


 If you observe this behaviour, please reopen or open a new issue.

Not quite sure whether it is the same failure: https://jenkins.cilium.io/job/Cilium-PR-Runtime-4.9/72/consoleFull (on #11471)

Seen this once more on the runtime tests: https://jenkins.cilium.io/job/Cilium-PR-Runtime-4.9/76/

Similar failure here as well I think https://jenkins.cilium.io/job/Cilium-PR-Runtime-4.9/64/consoleFull (on https://github.com/cilium/cilium/pull/11468)

I don't think #11515 fixed it. I just saw it at https://jenkins.cilium.io/job/Cilium-PR-Runtime-4.9/104/consoleFull.
Full output here in case Jenkins deletes it.
01:29:32.939  RuntimePrivilegedUnitTests
01:29:32.939    Run Tests
01:29:32.939    /home/jenkins/workspace/Cilium-PR-Runtime-4.9/runtime-gopath/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:471
01:29:32.939  11:17:58 STEP: Running BeforeAll block for RuntimePrivilegedUnitTests
01:33:41.639  FAIL: Failed to run privileged unit tests
01:33:41.639  Expected command: sudo make -C /home/vagrant/go/src/github.com/cilium/cilium/ tests-privileged
01:33:41.639  To succeed, but it failed:
01:33:41.639  Exitcode: 1
01:33:41.639  Stdout:
01:33:41.639   	 make: Entering directory '/home/vagrant/go/src/github.com/cilium/cilium'
01:33:41.639  	 # cilium-map-migrate is a dependency of some unit tests.
01:33:41.639  	 make  -C bpf cilium-map-migrate
01:33:41.639  	 make[1]: Entering directory '/home/vagrant/go/src/github.com/cilium/cilium/bpf'
01:33:41.639  	 make[1]: 'cilium-map-migrate' is up to date.
01:33:41.639  	 make[1]: Leaving directory '/home/vagrant/go/src/github.com/cilium/cilium/bpf'
01:33:41.639  	 make init-coverage
01:33:41.639  	 make[1]: Entering directory '/home/vagrant/go/src/github.com/cilium/cilium'
01:33:41.639  	 echo "mode: count" > coverage-all-tmp.out
01:33:41.639  	 echo "mode: count" > coverage.out
01:33:41.639  	 make[1]: Leaving directory '/home/vagrant/go/src/github.com/cilium/cilium'
01:33:41.639  	 for pkg in github.com/cilium/cilium/cilium/cmd github.com/cilium/cilium/daemon/cmd github.com/cilium/cilium/pkg/aws/eni/routing github.com/cilium/cilium/pkg/bpf github.com/cilium/cilium/pkg/datapath/link github.com/cilium/cilium/pkg/datapath/linux github.com/cilium/cilium/pkg/datapath/linux/config github.com/cilium/cilium/pkg/datapath/linux/ipsec github.com/cilium/cilium/pkg/datapath/linux/probes github.com/cilium/cilium/pkg/datapath/linux/route github.com/cilium/cilium/pkg/datapath/loader github.com/cilium/cilium/pkg/fqdn/dnsproxy github.com/cilium/cilium/pkg/maps/ctmap github.com/cilium/cilium/pkg/maps/eppolicymap github.com/cilium/cilium/pkg/maps/policymap github.com/cilium/cilium/pkg/modules github.com/cilium/cilium/pkg/mtu github.com/cilium/cilium/pkg/sysctl; do \
01:33:41.639  	 	PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/home/vagrant/go/src/github.com/cilium/cilium/bpf go test  -mod=vendor -ldflags "-X github.com/cilium/cilium/pkg/kvstore.consulDummyAddress=https://consul:8443 -X github.com/cilium/cilium/pkg/kvstore.etcdDummyAddress=http://etcd:4002 -X github.com/cilium/cilium/pkg/testutils.CiliumRootDir=/home/vagrant/go/src/github.com/cilium/cilium -X github.com/cilium/cilium/pkg/datapath.DatapathSHA=1234567890abcdef7890" $pkg -test.v -timeout 360s -check.vv -tags=privileged_tests -coverprofile=coverage.out -covermode=count -coverpkg ./... \
01:33:41.639  	 	|| exit 1; \
01:33:41.639  	 	tail -n +2 coverage.out >> coverage-all-tmp.out; \
01:33:41.639  	 done
01:33:41.639  	 === RUN   Test
01:33:41.639  	 START: bpf_ipcache_get_test.go:58: BPFIPCacheGetSuite.TestGetLPMValue
01:33:41.639  	 PASS: bpf_ipcache_get_test.go:58: BPFIPCacheGetSuite.TestGetLPMValue	0.000s
01:33:41.639
01:33:41.639  	 START: bpf_ipcache_get_test.go:32: BPFIPCacheGetSuite.TestGetPrefix
01:33:41.639  	 PASS: bpf_ipcache_get_test.go:32: BPFIPCacheGetSuite.TestGetPrefix	0.001s
01:33:41.639
01:33:41.639  	 START: helpers_test.go:39: CMDHelpersSuite.TestExpandNestedJSON
01:33:41.639  	 PASS: helpers_test.go:39: CMDHelpersSuite.TestExpandNestedJSON	0.001s
01:33:41.639
01:33:41.639  	 START: helpers_test.go:576: CMDHelpersSuite.TestParsePolicyUpdateArgsHelper
01:33:41.639  	 PASS: helpers_test.go:576: CMDHelpersSuite.TestParsePolicyUpdateArgsHelper	0.000s
01:33:41.639
01:33:41.639  	 START: helpers_test.go:551: CMDHelpersSuite.TestParseTrafficString
01:33:41.639  	 PASS: helpers_test.go:551: CMDHelpersSuite.TestParseTrafficString	0.000s
01:33:41.639
01:33:41.639  	 OK: 5 passed
01:33:41.639  	 --- PASS: Test (0.00s)
01:33:41.639  	 PASS
01:33:41.639  	 coverage: 2.6% of statements in ./...
01:33:41.639  	 ok  	github.com/cilium/cilium/cilium/cmd	0.078s	coverage: 2.6% of statements in ./...
01:33:41.639  	 === RUN   Test
01:33:41.639  	 START: nodeport_linux_test.go:51: NodePortSuite.TestCheckNodePortAndEphemeralPortRanges
01:33:41.639  	 START: nodeport_linux_test.go:35: NodePortSuite.SetUpTest
01:33:41.639  	 PASS: nodeport_linux_test.go:35: NodePortSuite.SetUpTest	0.000s
01:33:41.639
01:33:41.639  	 START: nodeport_linux_test.go:44: NodePortSuite.TearDownTest
01:33:41.639  	 PASS: nodeport_linux_test.go:44: NodePortSuite.TearDownTest	0.000s
01:33:41.639
01:33:41.639  	 PASS: nodeport_linux_test.go:51: NodePortSuite.TestCheckNodePortAndEphemeralPortRanges	0.001s
01:33:41.639
01:33:41.639  	 START: sysctl_linux_test.go:34: DaemonPrivilegedSuite.TestEnableIPForwarding
01:33:41.639  	 PASS: sysctl_linux_test.go:34: DaemonPrivilegedSuite.TestEnableIPForwarding	0.000s
01:33:41.639
01:33:41.639  	 OK: 2 passed
01:33:41.639  	 --- PASS: Test (0.00s)
01:33:41.639  	 PASS
01:33:41.639  	 coverage: 2.0% of statements in ./...
01:33:41.639  	 ok  	github.com/cilium/cilium/daemon/cmd	0.108s	coverage: 2.0% of statements in ./...
01:33:41.639  	 === RUN   Test
01:33:41.639  	 START: routing_test.go:40: ENIRoutingSuite.TestConfigure
01:33:41.639  	 Inside new network ns NS(3:4026532384)
01:33:41.639  	 Added dummy device
01:33:41.639  	 Cleaned up dummy device
01:33:41.639  	 Closed new network ns NS(3:4026532384)
01:33:41.639  	 Inside new network ns NS(3:4026532451)
01:33:41.639  	 Added dummy device
01:33:41.639  	 Cleaned up dummy device
01:33:41.639  	 Closed new network ns NS(3:4026532451)
01:33:41.639  	 Set back to previous network ns
01:33:41.639  	 PASS: routing_test.go:40: ENIRoutingSuite.TestConfigure	0.050s
01:33:41.639
01:33:41.639  	 START: routing_test.go:54: ENIRoutingSuite.TestConfigureRoutewithIncompatibleIP
01:33:41.639  	 level=warning msg="Unable to configure rules and routes because IP is not an IPv4 address" endpointIP="fd00::2" subsys=eni-routing
01:33:41.639  	 PASS: routing_test.go:54: ENIRoutingSuite.TestConfigureRoutewithIncompatibleIP	0.000s
01:33:41.639
01:33:41.639  	 START: routing_test.go:71: ENIRoutingSuite.TestDelete
01:33:41.639  	 valid IP addr matching rules
01:33:41.639  	 Inside new network ns NS(3:4026532384)
01:33:41.639  	 Added dummy device
01:33:41.639  	 Cleaned up dummy device
01:33:41.639  	 Closed new network ns NS(3:4026532384)
01:33:41.639  	 IP addr doesn't match rules
01:33:41.639  	 Inside new network ns NS(3:4026532451)
01:33:41.639  	 Added dummy device
01:33:41.639  	 level=warning msg="No rule matching found" rule="20: from all to <IP_ADDRESS>/32 lookup main" subsys=eni-routing
01:33:41.639  	 Cleaned up dummy device
01:33:41.639  	 Closed new network ns NS(3:4026532451)
01:33:41.639  	 IP addr matches more than number expected
01:33:41.639  	 Inside new network ns NS(3:4026532384)
01:33:41.639  	 Added dummy device
01:33:41.639  	 level=warning msg="Found too many rules matching, skipping deletion" candidates="[ip rule 20: from <nil> table 254 ip rule 20: from <IP_ADDRESS>/32 table 254]" rule="20: from all to <IP_ADDRESS>/32 lookup main" subsys=eni-routing
01:33:41.639  	 Cleaned up dummy device
01:33:41.639  	 Closed new network ns NS(3:4026532384)
01:33:41.639  	 PASS: routing_test.go:71: ENIRoutingSuite.TestDelete	0.959s
01:33:41.639
01:33:41.639  	 START: routing_test.go:63: ENIRoutingSuite.TestDeleteRoutewithIncompatibleIP
01:33:41.639  	 level=warning msg="Unable to delete rules because IP is not an IPv4 address" endpointIP="fd00::2" subsys=eni-routing
01:33:41.639  	 PASS: routing_test.go:63: ENIRoutingSuite.TestDeleteRoutewithIncompatibleIP	0.000s
01:33:41.639
01:33:41.639  	 OK: 4 passed
01:33:41.639  	 --- PASS: Test (1.01s)
01:33:41.639  	 PASS
01:33:41.639  	 coverage: 3.7% of statements in ./...
01:33:41.639  	 ok  	github.com/cilium/cilium/pkg/aws/eni/routing	1.045s	coverage: 3.7% of statements in ./...
01:33:41.639  	 level=info msg="Detected mounted BPF filesystem at /sys/fs/bpf" subsys=bpf
01:33:41.639  	 === RUN   Test
01:33:41.639  	 START: map_linux_test.go:250: BPFPrivilegedTestSuite.TestBasicManipulation
01:33:41.639  	 PASS: map_linux_test.go:250: BPFPrivilegedTestSuite.TestBasicManipulation	0.000s
01:33:41.639
01:33:41.639  	 START: map_linux_test.go:519: BPFPrivilegedTestSuite.TestCheckAndUpgrade
01:33:41.639  	 level=warning msg="Flags mismatch for BPF map" file-path=/sys/fs/bpf/tc/globals/cilium_test_upgrade new=0 old=1 subsys=bpf
01:33:41.639  	 level=warning msg="Removing map to allow for property upgrade (expect map data loss)" file-path=/sys/fs/bpf/tc/globals/cilium_test_upgrade subsys=bpf
01:33:41.639  	 PASS: map_linux_test.go:519: BPFPrivilegedTestSuite.TestCheckAndUpgrade	0.000s
01:33:41.639
01:33:41.639  	 START: map_linux_test.go:479: BPFPrivilegedTestSuite.TestDeleteAll
01:33:41.639  	 PASS: map_linux_test.go:479: BPFPrivilegedTestSuite.TestDeleteAll	0.000s
01:33:41.639
01:33:41.639  	 START: map_linux_test.go:319: BPFPrivilegedTestSuite.TestDump
01:33:41.639  	 PASS: map_linux_test.go:319: BPFPrivilegedTestSuite.TestDump	0.000s
01:33:41.639
01:33:41.639  	 START: map_linux_test.go:390: BPFPrivilegedTestSuite.TestDumpReliablyWithCallback
01:33:41.639  	 PASS: map_linux_test.go:390: BPFPrivilegedTestSuite.TestDumpReliablyWithCallback	0.089s
01:33:41.639
01:33:41.639  	 START: map_linux_test.go:99: BPFPrivilegedTestSuite.TestGetMapInfo
01:33:41.639  	 PASS: map_linux_test.go:99: BPFPrivilegedTestSuite.TestGetMapInfo	0.000s
01:33:41.639
01:33:41.639  	 START: map_linux_test.go:514: BPFPrivilegedTestSuite.TestGetModel
01:33:41.639  	 PASS: map_linux_test.go:514: BPFPrivilegedTestSuite.TestGetModel	0.000s
01:33:41.639
01:33:41.639  	 START: map_linux_test.go:113: BPFPrivilegedTestSuite.TestOpen
01:33:41.639  	 PASS: map_linux_test.go:113: BPFPrivilegedTestSuite.TestOpen	0.000s
01:33:41.639
01:33:41.639  	 START: map_linux_test.go:140: BPFPrivilegedTestSuite.TestOpenMap
01:33:41.639  	 PASS: map_linux_test.go:140: BPFPrivilegedTestSuite.TestOpenMap	0.000s
01:33:41.639
01:33:41.639  	 START: map_linux_test.go:159: BPFPrivilegedTestSuite.TestOpenOrCreate
01:33:41.639  	 level=warning msg="Flags mismatch for BPF map" file-path=/sys/fs/bpf/tc/globals/cilium_test new=0 old=1 subsys=bpf
01:33:41.639  	 level=warning msg="Removing map to allow for property upgrade (expect map data loss)" file-path=/sys/fs/bpf/tc/globals/cilium_test subsys=bpf
01:33:41.639  	 PASS: map_linux_test.go:159: BPFPrivilegedTestSuite.TestOpenOrCreate	0.000s
01:33:41.639
01:33:41.639  	 START: map_linux_test.go:199: BPFPrivilegedTestSuite.TestOpenParallel
01:33:41.639  	 PASS: map_linux_test.go:199: BPFPrivilegedTestSuite.TestOpenParallel	0.000s
01:33:41.639
01:33:41.639  	 START: map_linux_test.go:561: BPFPrivilegedTestSuite.TestUnpin
01:33:41.639  	 PASS: map_linux_test.go:561: BPFPrivilegedTestSuite.TestUnpin	0.000s
01:33:41.639
01:33:41.639  	 OK: 12 passed
01:33:41.639  	 --- PASS: Test (0.09s)
01:33:41.639  	 PASS
01:33:41.639  	 coverage: 7.2% of statements in ./...
01:33:41.639  	 ok  	github.com/cilium/cilium/pkg/bpf	0.681s	coverage: 7.2% of statements in ./...
01:33:41.639  	 === RUN   Test
01:33:41.639  	 START: link_test.go:34: LinkSuite.TestDeleteByName
01:33:41.639  	 PASS: link_test.go:34: LinkSuite.TestDeleteByName	0.033s
01:33:41.639
01:33:41.639  	 START: link_test.go:72: LinkSuite.TestRename
01:33:41.639  	 PASS: link_test.go:72: LinkSuite.TestRename	0.044s
01:33:41.639
01:33:41.639  	 OK: 2 passed
01:33:41.639  	 --- PASS: Test (0.08s)
01:33:41.639  	 PASS
01:33:41.639  	 coverage: 90.0% of statements in ./...
01:33:41.639  	 ok  	github.com/cilium/cilium/pkg/datapath/link	0.081s	coverage: 90.0% of statements in ./...
01:33:41.639  	 === RUN   Test
01:33:41.639  	 START: <autogenerated>:1: linuxPrivilegedIPv6OnlyTestSuite.TestAgentRestartOptionChanges
01:33:41.639  	 START: node_linux_test.go:103: linuxPrivilegedIPv6OnlyTestSuite.SetUpTest
01:33:41.639  	 level=warning msg="Flags mismatch for BPF map" file-path=/sys/fs/bpf/tc/globals/cilium_tunnel_map new=1 old=0 subsys=bpf
01:33:41.639  	 level=warning msg="Removing map to allow for property upgrade (expect map data loss)" file-path=/sys/fs/bpf/tc/globals/cilium_tunnel_map subsys=bpf
01:33:41.639  	 PASS: node_linux_test.go:103: linuxPrivilegedIPv6OnlyTestSuite.SetUpTest	0.551s
01:33:41.639
01:33:41.639  	 START: node_linux_test.go:125: linuxPrivilegedIPv6OnlyTestSuite.TearDownTest
01:33:41.639  	 PASS: node_linux_test.go:125: linuxPrivilegedIPv6OnlyTestSuite.TearDownTest	0.556s
01:33:41.639
01:33:41.639  	 PASS: <autogenerated>:1: linuxPrivilegedIPv6OnlyTestSuite.TestAgentRestartOptionChanges	0.001s
01:33:41.639
01:33:41.639  	 START: <autogenerated>:1: linuxPrivilegedIPv6OnlyTestSuite.TestAuxiliaryPrefixes
01:33:41.639  	 START: node_linux_test.go:103: linuxPrivilegedIPv6OnlyTestSuite.SetUpTest
01:33:41.639  	 PASS: node_linux_test.go:103: linuxPrivilegedIPv6OnlyTestSuite.SetUpTest	0.001s
01:33:41.639
01:33:41.639  	 START: node_linux_test.go:125: linuxPrivilegedIPv6OnlyTestSuite.TearDownTest
01:33:41.639  	 PASS: node_linux_test.go:125: linuxPrivilegedIPv6OnlyTestSuite.TearDownTest	0.045s
01:33:41.639
01:33:41.639  	 PASS: <autogenerated>:1: linuxPrivilegedIPv6OnlyTestSuite.TestAuxiliaryPrefixes	0.002s
01:33:41.639
01:33:41.639  	 START: <autogenerated>:1: linuxPrivilegedIPv6OnlyTestSuite.TestNodeUpdateDirectRouting
01:33:41.639  	 START: node_linux_test.go:103: linuxPrivilegedIPv6OnlyTestSuite.SetUpTest
01:33:41.639  	 PASS: node_linux_test.go:103: linuxPrivilegedIPv6OnlyTestSuite.SetUpTest	0.001s
01:33:41.639
01:33:41.639  	 START: node_linux_test.go:125: linuxPrivilegedIPv6OnlyTestSuite.TearDownTest
01:33:41.639  	 PASS: node_linux_test.go:125: linuxPrivilegedIPv6OnlyTestSuite.TearDownTest	0.044s
01:33:41.639
01:33:41.639  	 PASS: <autogenerated>:1: linuxPrivilegedIPv6OnlyTestSuite.TestNodeUpdateDirectRouting	0.043s
01:33:41.639
01:33:41.639  	 START: <autogenerated>:1: linuxPrivilegedIPv6OnlyTestSuite.TestNodeUpdateEncapsulation
01:33:41.639  	 START: node_linux_test.go:103: linuxPrivilegedIPv6OnlyTestSuite.SetUpTest
01:33:41.639  	 PASS: node_linux_test.go:103: linuxPrivilegedIPv6OnlyTestSuite.SetUpTest	0.001s
01:33:41.639
01:33:41.639  	 START: node_linux_test.go:125: linuxPrivilegedIPv6OnlyTestSuite.TearDownTest
01:33:41.639  	 PASS: node_linux_test.go:125: linuxPrivilegedIPv6OnlyTestSuite.TearDownTest	0.049s
01:33:41.639
01:33:41.639  	 PASS: <autogenerated>:1: linuxPrivilegedIPv6OnlyTestSuite.TestNodeUpdateEncapsulation	0.002s
01:33:41.639
01:33:41.639  	 START: <autogenerated>:1: linuxPrivilegedIPv6OnlyTestSuite.TestNodeValidationDirectRouting
01:33:41.639  	 START: node_linux_test.go:103: linuxPrivilegedIPv6OnlyTestSuite.SetUpTest
01:33:41.639  	 PASS: node_linux_test.go:103: linuxPrivilegedIPv6OnlyTestSuite.SetUpTest	0.001s
01:33:41.639
01:33:41.639  	 START: node_linux_test.go:125: linuxPrivilegedIPv6OnlyTestSuite.TearDownTest
01:33:41.639  	 PASS: node_linux_test.go:125: linuxPrivilegedIPv6OnlyTestSuite.TearDownTest	0.046s
01:33:41.639
01:33:41.639  	 PASS: <autogenerated>:1: linuxPrivilegedIPv6OnlyTestSuite.TestNodeValidationDirectRouting	0.001s
01:33:41.639
01:33:41.639  	 START: <autogenerated>:1: linuxPrivilegedIPv6OnlyTestSuite.TestSingleClusterPrefix
01:33:41.639  	 START: node_linux_test.go:103: linuxPrivilegedIPv6OnlyTestSuite.SetUpTest
01:33:41.639  	 PASS: node_linux_test.go:103: linuxPrivilegedIPv6OnlyTestSuite.SetUpTest	0.001s
01:33:41.639
01:33:41.639  	 START: node_linux_test.go:125: linuxPrivilegedIPv6OnlyTestSuite.TearDownTest
01:33:41.639  	 PASS: node_linux_test.go:125: linuxPrivilegedIPv6OnlyTestSuite.TearDownTest	0.054s
01:33:41.639
01:33:41.639  	 PASS: <autogenerated>:1: linuxPrivilegedIPv6OnlyTestSuite.TestSingleClusterPrefix	0.001s
01:33:41.639
01:33:41.639  	 START: <autogenerated>:1: linuxPrivilegedIPv6OnlyTestSuite.TestUpdateNodeRoute
01:33:41.639  	 START: node_linux_test.go:103: linuxPrivilegedIPv6OnlyTestSuite.SetUpTest
01:33:41.639  	 PASS: node_linux_test.go:103: linuxPrivilegedIPv6OnlyTestSuite.SetUpTest	0.001s
01:33:41.639
01:33:41.639  	 START: node_linux_test.go:125: linuxPrivilegedIPv6OnlyTestSuite.TearDownTest
01:33:41.639  	 PASS: node_linux_test.go:125: linuxPrivilegedIPv6OnlyTestSuite.TearDownTest	0.046s
01:33:41.639
01:33:41.639  	 PASS: <autogenerated>:1: linuxPrivilegedIPv6OnlyTestSuite.TestUpdateNodeRoute	0.001s
01:33:41.639
01:33:41.639  	 START: <autogenerated>:1: linuxPrivilegedIPv4OnlyTestSuite.TestAgentRestartOptionChanges
01:33:41.639  	 START: node_linux_test.go:108: linuxPrivilegedIPv4OnlyTestSuite.SetUpTest
01:33:41.639  	 PASS: node_linux_test.go:108: linuxPrivilegedIPv4OnlyTestSuite.SetUpTest	0.001s
01:33:41.639
01:33:41.639  	 START: node_linux_test.go:129: linuxPrivilegedIPv4OnlyTestSuite.TearDownTest
01:33:41.639  	 PASS: node_linux_test.go:129: linuxPrivilegedIPv4OnlyTestSuite.TearDownTest	0.046s
01:33:41.639
01:33:41.639  	 PASS: <autogenerated>:1: linuxPrivilegedIPv4OnlyTestSuite.TestAgentRestartOptionChanges	0.001s
01:33:41.639
01:33:41.639  	 START: <autogenerated>:1: linuxPrivilegedIPv4OnlyTestSuite.TestAuxiliaryPrefixes
01:33:41.639  	 START: node_linux_test.go:108: linuxPrivilegedIPv4OnlyTestSuite.SetUpTest
01:33:41.639  	 PASS: node_linux_test.go:108: linuxPrivilegedIPv4OnlyTestSuite.SetUpTest	0.001s
01:33:41.639
01:33:41.639  	 START: node_linux_test.go:129: linuxPrivilegedIPv4OnlyTestSuite.TearDownTest
01:33:41.639  	 PASS: node_linux_test.go:129: linuxPrivilegedIPv4OnlyTestSuite.TearDownTest	0.046s
01:33:41.639
01:33:41.639  	 PASS: <autogenerated>:1: linuxPrivilegedIPv4OnlyTestSuite.TestAuxiliaryPrefixes	0.001s
01:33:41.639
01:33:41.639  	 START: <autogenerated>:1: linuxPrivilegedIPv4OnlyTestSuite.TestNodeUpdateDirectRouting
01:33:41.639  	 START: node_linux_test.go:108: linuxPrivilegedIPv4OnlyTestSuite.SetUpTest
01:33:41.639  	 PASS: node_linux_test.go:108: linuxPrivilegedIPv4OnlyTestSuite.SetUpTest	0.001s
01:33:41.639
01:33:41.639  	 START: node_linux_test.go:129: linuxPrivilegedIPv4OnlyTestSuite.TearDownTest
01:33:41.639  	 PASS: node_linux_test.go:129: linuxPrivilegedIPv4OnlyTestSuite.TearDownTest	0.192s
01:33:41.639
01:33:41.639  	 PASS: <autogenerated>:1: linuxPrivilegedIPv4OnlyTestSuite.TestNodeUpdateDirectRouting	0.039s
01:33:41.639
01:33:41.639  	 START: <autogenerated>:1: linuxPrivilegedIPv4OnlyTestSuite.TestNodeUpdateEncapsulation
01:33:41.639  	 START: node_linux_test.go:108: linuxPrivilegedIPv4OnlyTestSuite.SetUpTest
01:33:41.639  	 PASS: node_linux_test.go:108: linuxPrivilegedIPv4OnlyTestSuite.SetUpTest	0.001s
01:33:41.639
01:33:41.639  	 START: node_linux_test.go:129: linuxPrivilegedIPv4OnlyTestSuite.TearDownTest
01:33:41.639  	 PASS: node_linux_test.go:129: linuxPrivilegedIPv4OnlyTestSuite.TearDownTest	0.045s
01:33:41.639
01:33:41.639  	 PASS: <autogenerated>:1: linuxPrivilegedIPv4OnlyTestSuite.TestNodeUpdateEncapsulation	0.001s
01:33:41.639
01:33:41.639  	 START: <autogenerated>:1: linuxPrivilegedIPv4OnlyTestSuite.TestNodeValidationDirectRouting
01:33:41.639  	 START: node_linux_test.go:108: linuxPrivilegedIPv4OnlyTestSuite.SetUpTest
01:33:41.639  	 PASS: node_linux_test.go:108: linuxPrivilegedIPv4OnlyTestSuite.SetUpTest	0.001s
01:33:41.639
01:33:41.639  	 START: node_linux_test.go:129: linuxPrivilegedIPv4OnlyTestSuite.TearDownTest
01:33:41.639  	 PASS: node_linux_test.go:129: linuxPrivilegedIPv4OnlyTestSuite.TearDownTest	0.041s
01:33:41.639
01:33:41.639  	 PASS: <autogenerated>:1: linuxPrivilegedIPv4OnlyTestSuite.TestNodeValidationDirectRouting	0.001s
01:33:41.639
01:33:41.639  	 START: <autogenerated>:1: linuxPrivilegedIPv4OnlyTestSuite.TestSingleClusterPrefix
01:33:41.639  	 START: node_linux_test.go:108: linuxPrivilegedIPv4OnlyTestSuite.SetUpTest
01:33:41.640  	 PASS: node_linux_test.go:108: linuxPrivilegedIPv4OnlyTestSuite.SetUpTest	0.001s
01:33:41.640
01:33:41.640  	 START: node_linux_test.go:129: linuxPrivilegedIPv4OnlyTestSuite.TearDownTest
01:33:41.640  	 PASS: node_linux_test.go:129: linuxPrivilegedIPv4OnlyTestSuite.TearDownTest	0.046s
01:33:41.640
01:33:41.640  	 PASS: <autogenerated>:1: linuxPrivilegedIPv4OnlyTestSuite.TestSingleClusterPrefix	0.001s
01:33:41.640
01:33:41.640  	 START: <autogenerated>:1: linuxPrivilegedIPv4OnlyTestSuite.TestUpdateNodeRoute
01:33:41.640  	 START: node_linux_test.go:108: linuxPrivilegedIPv4OnlyTestSuite.SetUpTest
01:33:41.640  	 PASS: node_linux_test.go:108: linuxPrivilegedIPv4OnlyTestSuite.SetUpTest	0.001s
01:33:41.640
01:33:41.640  	 START: node_linux_test.go:129: linuxPrivilegedIPv4OnlyTestSuite.TearDownTest
01:33:41.640  	 PASS: node_linux_test.go:129: linuxPrivilegedIPv4OnlyTestSuite.TearDownTest	0.041s
01:33:41.640
01:33:41.640  	 PASS: <autogenerated>:1: linuxPrivilegedIPv4OnlyTestSuite.TestUpdateNodeRoute	0.001s
01:33:41.640
01:33:41.640  	 START: <autogenerated>:1: linuxPrivilegedIPv4AndIPv6TestSuite.TestAgentRestartOptionChanges
01:33:41.640  	 START: node_linux_test.go:113: linuxPrivilegedIPv4AndIPv6TestSuite.SetUpTest
01:33:41.640  	 PASS: node_linux_test.go:113: linuxPrivilegedIPv4AndIPv6TestSuite.SetUpTest	0.001s
01:33:41.640
01:33:41.640  	 START: node_linux_test.go:133: linuxPrivilegedIPv4AndIPv6TestSuite.TearDownTest
01:33:41.640  	 PASS: node_linux_test.go:133: linuxPrivilegedIPv4AndIPv6TestSuite.TearDownTest	0.110s
01:33:41.640
01:33:41.640  	 PASS: <autogenerated>:1: linuxPrivilegedIPv4AndIPv6TestSuite.TestAgentRestartOptionChanges	0.001s
01:33:41.640
01:33:41.640  	 START: <autogenerated>:1: linuxPrivilegedIPv4AndIPv6TestSuite.TestAuxiliaryPrefixes
01:33:41.640  	 START: node_linux_test.go:113: linuxPrivilegedIPv4AndIPv6TestSuite.SetUpTest
01:33:41.640  	 PASS: node_linux_test.go:113: linuxPrivilegedIPv4AndIPv6TestSuite.SetUpTest	0.001s
01:33:41.640
01:33:41.640  	 START: node_linux_test.go:133: linuxPrivilegedIPv4AndIPv6TestSuite.TearDownTest
01:33:41.640  	 PASS: node_linux_test.go:133: linuxPrivilegedIPv4AndIPv6TestSuite.TearDownTest	0.044s
01:33:41.640
01:33:41.640  	 PASS: <autogenerated>:1: linuxPrivilegedIPv4AndIPv6TestSuite.TestAuxiliaryPrefixes	0.001s
01:33:41.640
01:33:41.640  	 START: <autogenerated>:1: linuxPrivilegedIPv4AndIPv6TestSuite.TestNodeUpdateDirectRouting
01:33:41.640  	 START: node_linux_test.go:113: linuxPrivilegedIPv4AndIPv6TestSuite.SetUpTest
01:33:41.640  	 PASS: node_linux_test.go:113: linuxPrivilegedIPv4AndIPv6TestSuite.SetUpTest	0.001s
01:33:41.640
01:33:41.640  	 START: node_linux_test.go:133: linuxPrivilegedIPv4AndIPv6TestSuite.TearDownTest
01:33:41.640  	 PASS: node_linux_test.go:133: linuxPrivilegedIPv4AndIPv6TestSuite.TearDownTest	0.056s
01:33:41.640
01:33:41.640  	 PASS: <autogenerated>:1: linuxPrivilegedIPv4AndIPv6TestSuite.TestNodeUpdateDirectRouting	0.043s
01:33:41.640
01:33:41.640  	 START: <autogenerated>:1: linuxPrivilegedIPv4AndIPv6TestSuite.TestNodeUpdateEncapsulation
01:33:41.640  	 START: node_linux_test.go:113: linuxPrivilegedIPv4AndIPv6TestSuite.SetUpTest
01:33:41.640  	 PASS: node_linux_test.go:113: linuxPrivilegedIPv4AndIPv6TestSuite.SetUpTest	0.002s
01:33:41.640
01:33:41.640  	 START: node_linux_test.go:133: linuxPrivilegedIPv4AndIPv6TestSuite.TearDownTest
01:33:41.640  	 PASS: node_linux_test.go:133: linuxPrivilegedIPv4AndIPv6TestSuite.TearDownTest	0.044s
01:33:41.640
01:33:41.640  	 PASS: <autogenerated>:1: linuxPrivilegedIPv4AndIPv6TestSuite.TestNodeUpdateEncapsulation	0.005s
01:33:41.640
01:33:41.640  	 START: <autogenerated>:1: linuxPrivilegedIPv4AndIPv6TestSuite.TestNodeValidationDirectRouting
01:33:41.640  	 START: node_linux_test.go:113: linuxPrivilegedIPv4AndIPv6TestSuite.SetUpTest
01:33:41.640  	 PASS: node_linux_test.go:113: linuxPrivilegedIPv4AndIPv6TestSuite.SetUpTest	0.001s
01:33:41.640
01:33:41.640  	 START: node_linux_test.go:133: linuxPrivilegedIPv4AndIPv6TestSuite.TearDownTest
01:33:41.640  	 PASS: node_linux_test.go:133: linuxPrivilegedIPv4AndIPv6TestSuite.TearDownTest	0.554s
01:33:41.640
01:33:41.640  	 PASS: <autogenerated>:1: linuxPrivilegedIPv4AndIPv6TestSuite.TestNodeValidationDirectRouting	0.001s
01:33:41.640
01:33:41.640  	 START: <autogenerated>:1: linuxPrivilegedIPv4AndIPv6TestSuite.TestSingleClusterPrefix
01:33:41.640  	 START: node_linux_test.go:113: linuxPrivilegedIPv4AndIPv6TestSuite.SetUpTest
01:33:41.640  	 PASS: node_linux_test.go:113: linuxPrivilegedIPv4AndIPv6TestSuite.SetUpTest	0.002s
01:33:41.640
01:33:41.640  	 START: node_linux_test.go:133: linuxPrivilegedIPv4AndIPv6TestSuite.TearDownTest
01:33:41.640  	 PASS: node_linux_test.go:133: linuxPrivilegedIPv4AndIPv6TestSuite.TearDownTest	0.044s
01:33:41.640
01:33:41.640  	 PASS: <autogenerated>:1: linuxPrivilegedIPv4AndIPv6TestSuite.TestSingleClusterPrefix	0.002s
01:33:41.640
01:33:41.640  	 START: <autogenerated>:1: linuxPrivilegedIPv4AndIPv6TestSuite.TestUpdateNodeRoute
01:33:41.640  	 START: node_linux_test.go:113: linuxPrivilegedIPv4AndIPv6TestSuite.SetUpTest
01:33:41.640  	 PASS: node_linux_test.go:113: linuxPrivilegedIPv4AndIPv6TestSuite.SetUpTest	0.001s
01:33:41.640
01:33:41.640  	 START: node_linux_test.go:133: linuxPrivilegedIPv4AndIPv6TestSuite.TearDownTest
01:33:41.640  	 PASS: node_linux_test.go:133: linuxPrivilegedIPv4AndIPv6TestSuite.TearDownTest	0.045s
01:33:41.640
01:33:41.640  	 PASS: <autogenerated>:1: linuxPrivilegedIPv4AndIPv6TestSuite.TestUpdateNodeRoute	0.001s
01:33:41.640
01:33:41.640  	 OK: 21 passed
01:33:41.640  	 --- PASS: Test (2.92s)
01:33:41.640  	 PASS
01:33:41.640  	 coverage: 4.8% of statements in ./...
01:33:41.640  	 ok  	github.com/cilium/cilium/pkg/datapath/linux	3.476s	coverage: 4.8% of statements in ./...
01:33:41.640
01:33:41.640  Stderr:
01:33:41.640
01:33:41.640
01:33:41.640  === Test Finished at 2020-05-13T11:22:00Z====

Looks like #11512 is tracking this as well. I'd propose to close this as duplicate.


GrantNewAccessTokenFromAuthCode doesn't work

So it seems like passing json as a body for /v1/identity/openidconnect/tokenservice request doesn't work anymore.
This request doesn't work:
curl -v 'https://api.sandbox.paypal.com/v1/identity/openidconnect/tokenservice' \
    -H "Content-Type: application/json" \
    -H "Authorization: Bearing <token>" \
    -d '{"grant_type":"authorization_code","code":"<code>","redirect_uri":"<redirect_uri>"}'

response:
{"error_description":"Grant type is null","error":"invalid_grant","correlation_id":"a7087aa10fff1","information_link":"https://developer.paypal.com/docs/api/#errors"}

Where this request using formdata works:
curl -v 'https://api.sandbox.paypal.com/v1/identity/openidconnect/tokenservice' \
    -H "Content-Type: application/x-www-form-urlencoded" \
    -H "Authorization: Basic <base64(clientID:secret)>" \
    -d 'grant_type=authorization_code&code=<code>&redirect_uri=<redirect_uri>'

Also making GET request with query params also works.
Did I miss something here and I'm incorrect in my assumption? If not, I can provide a pull request that I started to work on. But one issue is that Paypal returns "expire_in" field as a string, so we would need to do something like here for that field where it is a custom type with UnmarshalJSON method: https://github.com/golang/oauth2/blob/master/internal/token.go#L62.
Edit: Also it looks like using a bearing token for authorization doesn't work, but using a basic clientID:secret auth does work. I fixed the cURL example above.

Merged, thanks!


Building in webgl messes up the map

For some reason, webgl replaces tiles with random other tiles. This needs fixed as the main output was going to be webgl.

Related question on Unity3d Answers: http://answers.unity3d.com/questions/1283286/webgl-distorts-tilemap.html


New Front Door resource isn't shown

On Front Door tabs, new Front Door resources isn't shown.
The reason that query is old resource type such as following:
type == "microsoft.network/frontdoors"

Following is New Front Door resource type:
Microsoft.Cdn/profiles

But if do query above, it might be mix old CDN profile.

Fixed in v2.8


integrating oci registry with the controller

It looks like there have been some screwy merge commits that are causing issues with this PR


chore: only show config file if there is one

Description
Don't output the NOTE on config file usage if there is no config file set.
Currently zarf version will not go through the process of setting the configuration file, but the root cmd code path still has a part where it calls printViperConfigUsed() and tries to print it. As a result you get empty output, even if you have a valid config available:

In this PR we simply omit the config file note if we have no config file set. The printViperConfigUsed() function doesn't accept any parameters and doesn't seem to have access to anything that would tell it what specific command is being run, so I didn't see an easy way to only omit the output if the command is the version command.
Checklist before merging

[ ] Test, docs, adr added or updated as needed
[x] Contributor Guide Steps followed

@catsby This is a good change thanks. Could you follow the dco instructions to sign your commit


consume sha in property file in opendjdk build.xml

related to issue #3108
contains work from #3083
test is here https://github.com/adoptium/aqa-tests/pull/3107#issuecomment-954281530

https://github.com/adoptium/aqa-tests/pull/3083 is merged. Please rebase the change. Thanks

@llxia fix it pl review

Thanks @xius666 . Can you do two tests:

without using testenv.properties
using testenv.properties with JDK_REPO and sha

https://ci.adoptopenjdk.net/job/Grinder/2408/ 👍
https://ci.adoptopenjdk.net/job/Grinder/2410/ 👍


FancyZones "The divided area, the window is not rounded. Previous versions did not have this problem"

Microsoft PowerToys version
v0.57.0
Running as admin

[X] Yes

Area(s) with issue?
FancyZones
Steps to reproduce
The divided area, the window is not rounded. Previous versions did not have this problem

✔ Expected Behavior
Please restore the previous "fillet" design, or it will not be inconsistent with the overall win11 style
❌ Actual Behavior

Other Software
No response

/dup #17406
Thanks @Lssg97!


Look into deploying subset of the infra in CICD based on changes

Ideas:

Use different triggers
Use https://terragrunt.gruntwork.io/docs/reference/cli-options/#terragrunt-include-dir

Sort of addressed by managed_dirs field.