Compatibility: Signal Handling

I appear to have found an issue with my project where a panic arose when using this project and exec.Command at the same time.
signal 17 received but handler not on signal stack
mp.gsignal stack [0xc000008000 0xc000010000], mp.g0 stack [0x7ffd1cc50000 0x7ffd1d44e2e0], sp=0xc0000a4bf8
fatal error: non-Go code set up signal handler without SA_ONSTACK flag

I included code to reproduce this error below.
Unfortunately, I do not know much about programming in C. During troubleshooting, I saw a potential option may be to "wrap and mask" wkhtmltox's signal handing. Is that within the scope of this project?
If not, I think an alternate option would be to create a separate service to interact with wkhtmltox, but I'd like to explore options that keep the library integrated first.
package main

import (
	"bytes"
	"log"
	"os/exec"
	"runtime"

	pdf "github.com/adrg/go-wkhtmltopdf"
)

func init() {
	runtime.LockOSThread()
}

func main() {
	err := pdf.Init()
	if err != nil {
		log.Fatalf("Failed to initialize wkhtmltopdf: %v", err)
	}
	defer pdf.Destroy()

	println(getUname())
}

// This function is from Stripe's Golang SDK.
// https://github.com/stripe/stripe-go/blob/59660edfeed1968c8db9d6cae5e0e0bf0a93f9fe/stripe.go#L1503-L1522
func getUname() string {
	path, err := exec.LookPath("uname")
	if err != nil {
		return "unknown"
	}

	cmd := exec.Command(path, "-a")
	var out bytes.Buffer
	cmd.Stderr = nil // goes to os.DevNull
	cmd.Stdout = &out
	err = cmd.Run()
	if err != nil {
		return "unknown"
	}

	return out.String()
}

Hi @MicahParks,
This should work if you don't mind adding a bit of C code:
package main

/*
#include <signal.h>

void update_sigchld_handler() {
	struct sigaction action;
	sigaction(SIGCHLD, NULL, &action);
	action.sa_flags = action.sa_flags | SA_ONSTACK;
	sigaction(SIGCHLD, &action, NULL);
}
*/
import "C"

import (
	"bytes"
	"log"
	"os/exec"
	"runtime"

	pdf "github.com/adrg/go-wkhtmltopdf"
)

func init() {
	runtime.LockOSThread()
}

func main() {
	err := pdf.Init()
	if err != nil {
		log.Fatalf("Failed to initialize wkhtmltopdf: %v", err)
	}
	defer pdf.Destroy()
	C.update_sigchld_handler()

	println(getUname())
}

// This function is from Stripe's Golang SDK.
// https://github.com/stripe/stripe-go/blob/59660edfeed1968c8db9d6cae5e0e0bf0a93f9fe/stripe.go#L1503-L1522
func getUname() string {
	path, err := exec.LookPath("uname")
	if err != nil {
		return "unknown"
	}

	cmd := exec.Command(path, "-a")
	var out bytes.Buffer
	cmd.Stderr = nil // goes to os.DevNull
	cmd.Stdout = &out
	err = cmd.Run()
	if err != nil {
		return "unknown"
	}

	return out.String()
}

It basically retrieves the signal handler for SIGCHLD (signal 17) and adds the SA_ONSTACK flag to it.

@adrg that does exactly what I need it to. Thank you!
This may benefit others working on projects similar to what I'm working on. Perhaps it would be good to include the function in this project and document it similar to main thread restriction.

@MicahParks I'm glad it works. I was actually not aware of this problem so thank you for pointing it out. I will probably add a Known issues section in the README and document both issues there.


add control for Starkvind air purifier

This PR implements control of the Starkvind air purifier.
Open tasks

[x] write test cases
[x] add documentation in README

@Leggin: could you please do a review on this PR? Thanks!

@0x6d64 thanks for the contribution! please check the output form the ci test and make the necessary changes

@Leggin: done, please approve running the action again.

close due to staleness


Improve settings validation and type handling

The Problem
It is unclear what values can be set for each key in the settings object. This caused issues like https://github.com/TryGhost/Ghost/pull/10576 and https://github.com/TryGhost/Ghost/issues/10580
Current state
At the moment we don't have clear schema definition for all the values that can be stored in settings. There is a validation present on model layer, but it doesn't contain validations for all fields. We are not consistent with how boolean values are stored in the database.
Future improvements
We need to review uses of following data types/values that might cause the most of problems:

booleans - we currently store "true", "false", "0" and "1" in the DB, but should be storing only "true"/"false"
null/empty/undefined,
dates/timestamps

List of issues should be tackled for booleas:

[x] migration which corrects "0" to "false" and "1" to "true"
[x] a proper db input normalizer on model layer. this would handle e.g. stringification of booleans true/false into "true"/"false" to be stored in the db
[x] API validator which ensures sending "false" or "0" to settings is converted into boolean bot be used in further layers
[x] adapt importer to not forward "0" to model layer
[x] remove force_i18n in api input serializer

One addition: Exports might have "0" or "1". We have to ensure that these imports won't fail again 👍

Another addition: force_i18n is deprecated. We won't serve it. We should not skip this value on API layer.

We don't have any specific handling for null/undefined values in keys atm. When the value is not present for a key, this check in Settings model prevents it from being set to undefined:
if (item.hasOwnProperty('value')) {
    setting.set('value', item.value);
}

Ideally  objects without value provided woulld be filtered out in API validation layer.
As for null value, it is processed as expecte and stored as NULL in the db. There is a minor inconsistency where we sometimest store empty string "" to identify emtpy value but also allow it to be set to null (for example value for icon key).
Regarding date/timestamp fields, the only values we store are for next_update_check which comes from the request made to https://updates.ghost.org. We don't have any validation around this value but seems improbable that anything will break. Unless we would want to be extra cautious, don't think we need to do anything about it.

As for null value, it is processed as expecte and stored as NULL in the db. There is a minor inconsistency where we sometimest store empty string "" to identify emtpy value but also allow it to be set to null (for example value for icon key).

This needs some more context. Worth raising a separate issue with your findings.


Feat: onnx quantization

This PR adds "yolox_quantized" model as an alternative detection model, leveraging a similar speed to detectron2_onnx.
Also adds "detectron2_quantized" model as a quantized model for "detectron2_onnx".
Both models are generated at first usage.

Note: re-running test_ingests to get fresh diff against unstructured test-ingest fixtures:
https://github.com/Unstructured-IO/unstructured-inference/actions/runs/6045358745/job/16405565118?pr=182

I dug into the differences in ingest outputs here:
https://docs.google.com/document/d/1Ur0YABBvWLDXEVLJl22kO_0hgGCOgXfnu-eDEuJ3Q2c/edit?usp=sharing
While it seems table extraction is better, the overall results seem a bit worse, qualitatively.

I dug into the differences in ingest outputs here: https://docs.google.com/document/d/1Ur0YABBvWLDXEVLJl22kO_0hgGCOgXfnu-eDEuJ3Q2c/edit?usp=sharing
While it seems table extraction is better, the overall results seem a bit worse, qualitatively.

The ordering of the shouldn't be affected by the model change. Wondering if the algorithm changed at some point.

The ordering of the shouldn't be affected by the model change. Wondering if the algorithm changed at some point.

"shouldn't" perhaps but it clearly is. This is against the unstructured library is up to date with main on unstructured-inference -- it is not the sorting algo, but the inputs to the sorting algo that is changing the results here.

Perhaps we should update this as not the default model until other quality issues are sorted out, and consumers can still specify model_name=yolox_quantized if they are focused on Table identification?

The ordering of the shouldn't be affected by the model change. Wondering if the algorithm changed at some point.

"shouldn't" perhaps but it clearly is. This is against the unstructured library is up to date with main on unstructured-inference -- it is not the sorting algo, but the inputs to the sorting algo that is changing the results here.

I'm running some tests, and seems like the integration of OCR elements disorders some things (I found some texts being added in cross-order), so isn't the model. On the other way, with that algorithm, a lot of text boxes are recovered (Things that YoloX is missing)

Perhaps we should update this as not the default model until other quality issues are sorted out, and consumers can still specify model_name=yolox_quantized if they are focused on Table identification?

Agree, because solving all the problems at the same time will be very time-consuming.


Ensure LOG* and CHECK* macros are statement-safe

The LOG and LOGF macros had been modified to be statement-safe, but the
LOG_IF, CHECK, LOGF_IF, CHECKF, and CHECK_F macros were all still
unsafe in face of code where single-statement blocks were not enclosed
in {}.
For example code like this:
  if (!foobar)
      CHECKF(goodness, "badness detected!");
  else
      handle_foobar(foobar);

would fail in subtle and possibly dangerous ways.
Fix this by combining multiple if-statements into a single conditional
and inverting the conditions, then adding an empty then-block and moving
the log statement to the else-block.

Looks good. Merge is pending testing.


Release

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.3 out of 4 committers have signed the CLA.:white_check_mark: alexronquillo:white_check_mark: jpvajda:white_check_mark: zuluecho9:x: jkinmonthYou have signed the CLA already but the status is still pending? Let us recheck it.


lab: Add --comments flag to 'mr show'

The 'issue show' command has a --comments flag to show all the comments
on an issue.  The same command is useful for the merge request command
'mr show'.
Add a --comments flag to 'mr show' that displays all the comments made
on a merge request.
Minor fix: Also fix a typo with the mr no-markdown flag.
Signed-off-by: Prarit Bhargava<EMAIL_ADDRESS>

Sorry fubar'd the branch.
P.

@zaquestion & @rsteube : I think the reason that this is failing is because the merge request in the test tree do not have any notes or comments added to it.
From the CI failure:
    	            	coverage: 12.8% of statements in ./...

    	            	" does not contain "commented at"

    	Test:       	Test_mrShow

FAIL
Is there any chance the test repo could be updated so I can try to run again?
I could be wrong and just not seeing the real failure.  Please let me know if I misinterpreted the results.
Thanks,
P.

@rsteube, I added a comment to https://gitlab.com/zaquestion/test/-/merge_requests/1 so that the test will now pass.  As for your panic, please see https://github.com/zaquestion/lab/pull/392
P.

@zaquestion , also not sure what to for this one.  I've added an explicit --comments test so I think I've done the right thing?  If I'm missing something please let me know.
P.


Merge code mark 1

Merge request to merge to main after it gets to working

Welcome to Codecov :tada:
Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


This looks to be a serious issue with esm.sh in general.

          This looks to be a serious issue with esm.sh in general.

Most of the libraries I am using are scrambled in the same way including back to version v89 (the oldest I use) through the latest.
I thought the whole point of esm.sh was that any updates DO NOT affect older versions already in the CDN
example<EMAIL_ADDRESS>output
!�� W����s�O�
6�D,����e���9^�KĐ�=_+ЍY�V��e�+2Qȯi\6�p|4Q�m��bk��e������(��Y�+��F~�
Additional note:
We reference the url's in the browser <script.../> importmap imports section. This has been working for a very long time and it now not working at all
Originally posted by @smcardle in https://github.com/esm-dev/esm.sh/issues/676#issuecomment-1624375013

my bad mistake, now it should work normal

This is still not resolved. I am now also getting 502 responses

I am getting "Invalid Body" with https://esm.sh/<EMAIL_ADDRESS>

Still not resolved :(

I get 502 Invalid body for react-dom

I get 502 Invalid body for react-dom

Seems to be okay now

We can close this pr. It's been 4 hours since it's working flawlessly without crashing a single time.


Clearly document our versioning policy

I wrote this comment on HN:

We have a stable release (v2.0) for those who cannot tolerate breaking changes.
Feature releases (e.g. 2.1, 2.2) include new features and do break compatibility on occasion (so we can quickly introduce new behavior). Any breaking changes are well-documented in the release notes[1], so you can have a smooth upgrade path.
Minor releases (e.g. 2.1.1, 2.1.2) do not have breaking changes, only bugfixes and minor improvements.

We documented some of this in our  migration docs (if I remember), but we should add a basic article describing our versioning policy clearly.

Cool, just as long as that's up front and clear.   Strictly following semver implies quickly increasing major version numbers, so there are very good reasons not to follow semver.   But semver is quickly becoming an accepted practice, so if you don't follow it, stating that clearly and up front is probably a good idea.

A small correction: We don't actually have a release with "longterm support" yet.
If breaking changes are not an option at all, the best bet is usually to stay on the latest point release of whatever version your app uses, e.g. 2.0.5 would be the latest release we've made for the 2.0.x series. However those releases usually don't receive bug fixes anymore once the next
For users who absolutely rely on a specific feature release (e.g. 2.0.x or 2.1.x), we can offer to manually backport critical fixes that affect them as part of a commercial support contract.

If not long-term support, it'd be nice to explain what major versions are supposed to denote in this system.

This seems like it's a bit too short for a standalone article just about version numbers, but our only FAQ at this point is about RethinkDB architectural details. Maybe it does need to have an article in "Getting Started" after all?
And, yes, I agree with @stuartpb -- the way we use version numbers really does come across as non-standard. If 2.1 → 2.2 can introduce a backwards-incompatible change, what would a jump from, say, 2.4 → 3.0 imply?

Maybe the explanation of our versioning scheme should be a paragraph on http://rethinkdb.com/docs/install/ ?
It would also fit well into http://rethinkdb.com/docs/migration/ , though that article would need to be restructured a bit (that might be a good idea in general). Most of it is about migrating from RethinkDB versions older than 1.13, which few users will run into at this point.

If 2.1 → 2.2 can introduce a backwards-incompatible change, what would a jump from, say, 2.4 → 3.0 imply?

That's a great question, and I think it's not actually well defined so far. We've done this only once from 1.16 to 2.0, and then it simply denoted production readyness. It's unclear what the next jump from 2.x to 3.0.0 could indicate.


feature request: tab completion on \d commands

It would be a big boost to productivity if tab completion worked on \d commands. In particular \d <table> is something that gets used all the time and it's a bit tricky to remember all the table names!
For comparison, psql does this, so that would be the desired functionality to emulate.

What database are you using?

I checked and indeed we don't complete tables for these commands. But we do in select from statements, so it should be fairly easy to add.

I use both Postgres and Snowflake and haven't seen auto-completion working for either of those drivers, confirming your analysis!


Improvements to RPM publishing process

Coverage decreased (-17.0%) to 29.258% when pulling 95fc6d46298041f02f7e9ec98b015c9dd429a640 on rfecher:devops/new-env-changes into 5d91f6096fa0f367ef06b3d6cf57df0d0e9a7fae on locationtech:master.


No .apk in repo?

I'd love to try your app. As I don't want to compile, I was looking for the apk. But I couldn't find one...

Every time I release a new version, I attach the .apk compiled.
https://github.com/razzo04/rhasspy-mobile-app/releases/tag/v1.5.0

Every time I release a new version, I attach the .apk compiled.
https://github.com/razzo04/rhasspy-mobile-app/releases/tag/v1.5.0

Great, thank you!


renderizer: 2.0.5 -> 2.0.9

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/gomatic/renderizer/releases.
meta.description for renderizer is: "CLI to render Go template text files"
meta.homepage for renderizer is: "https://github.com/gomatic/renderizer"
Updates performed:

Golang update

Release on GitHub
Compare changes on GitHub

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 2.0.9 with grep in /nix/store/9c7qvgn1clmc1fqrh4is0lx20cs18k7h-renderizer-2.0.9

directory tree listing: https://gist.github.com/89a65b979e64e0c8db21cb44e8415fee

du listing: https://gist.github.com/5c460c485620ffe5ac30cf817338cd3e

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)
1 package rebuild(s)
1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
renderizer

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/9c7qvgn1clmc1fqrh4is0lx20cs18k7h-renderizer-2.0.9 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A renderizer https://github.com/r-ryantm/nixpkgs/archive/9143a9d6fb028d590b2ffe7e1953af8b3bcde2db.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/9c7qvgn1clmc1fqrh4is0lx20cs18k7h-renderizer-2.0.9
ls -la /nix/store/9c7qvgn1clmc1fqrh4is0lx20cs18k7h-renderizer-2.0.9/bin

cc @yurrriq @kalbasit for testing.

Thanks. Will test by EOD Tuesday.


SDK should encode {} even if skip_url is True

Same root problem than https://github.com/Azure/autorest.python/issues/1984, but in a different spot this time.
If the operation parameter is a url (Swagger had x-ms-skip-url-encoding), autorest tag the parameter as "skip-url-encoding", because we want to be sure to NOT encode the / of the customers. However, by skipping the encoding, we also don't encode the {} anymore:
https://github.com/Azure/azure-sdk-for-python/blob/2c4c367ea77942b63e1ea98c8b3c39b881fb3684/sdk/monitor/azure-mgmt-monitor/azure/mgmt/monitor/_serialization.py#L733

The second one should encode still the {}, but didn't
This problem is the root cause of https://github.com/Azure/azure-sdk-for-python/issues/31346
Given we're in the specific context of url encoding, we should use %7B and %7D. This won't be detected as a template by Python anymore, and is url valid, so we avoid any problem in the future whether we use format or not. Indeed, using {{ and }} would require that the url is going through a format call, and while this is the case today, we don't need to make this assumption with a url encoding.

fixed by https://github.com/Azure/autorest.python/pull/2065


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-k8s-25-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 2000

Questions ?
Please refer to the Backport tool documentation


Cannot select project with omnisharp because of quickPickSeparators

Issue Type: Bug
I'm using the insider build, at first I thought this was because of one machine, but now I have the same behavior on my Mac M1 and my Windows 11 device. Whenever I try to select a project I get the below.

Command 'OmniSharp: Select Project' resulted in an error (Extension 'ms-dotnettools.csharp' CANNOT use API proposal: quickPickSeparators.
Its package.json#enabledApiProposals-property declares: [] but NOT quickPickSeparators.
The missing proposal MUST be added and you must start in extension development mode or use the following command line switch: --enable-proposed-api ms-dotnettools.csharp)

Extension version: 1.23.16
VS Code version: Code - Insiders 1.63.0-insider (Universal) (1e473b624f088fc05269891170a8ffa1c84a35a6, 2021-11-25T07:59:08.754Z)
OS version: Darwin arm64 21.1.0
Restricted Mode: No

System Info

Item
Value

CPUs
Apple M1 Max (10 x 24)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
4, 5, 3

Memory (System)
64.00GB (16.10GB free)

Process Argv
. --crash-reporter-id a3331069-8570-41bd-a870-a2bc43c4f676

Screen Reader
no

VM
0%

A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythontb:30258533
pythonptprofiler:30281269
vshan820:30294714
pythondataviewer:30285072
vscod805cf:30301675
pythonvspyt200:30323110
bridge0708:30335490
bridge0723:30353136
pythonrunftest32:30365365
pythonf5test824:30361779
javagetstartedt:30350119
pythonvspyt187:30365360
vsaa593:30376534
vsc1dst:30396469
pythonvs932:30404738
vscexrecpromptt2:30397559
vscop804cf:30404767
vs360:30404995

as an FYI on both of these I have .NET installed already and in the path
dotnet --list-sdks
6.0.100 [/usr/local/share/dotnet/sdk]

same happening for me on windows with .NET 5

im having same issue, anyone got solution?

I too have just discovered this - this is more than painful, I have a MBPro with 64GB RAM (ie plenty) and a large Git repo with 10 or so .NET (Core) 5 projects each with their own Dev Containers - I was mounting my sourcecode from the Mac host into the dev containers, however I think the OSX host mount driver was too slow and caused endless issues with OmniSharp timing out and basically meant Intellisense was almost always broken (ie shows "Loading..." tooltip and never returns) - so I went to the trouble of creating Dev Containers with no host mount, ie the Dev Container would Git fetch into a standard Docker volume sidestepping the host volume driver altogether - this seems mostly to work, but I still find I have to occasionally perform an "OmniSharp Select Project" to get Intellisense working - but now with this new error I have no intellisense at all

Does anyone know how to install an old working version until a fix is released? My VS Code is basically bricked now.

In my case my problem was fixed by looking at the sln file and checking that every project was referenced correctly: correct path and name. After that, a simple restart of the VSCode was enough.

In my case my problem was fixed by looking at the sln file and checking that every project was referenced correctly: correct path and name. After that, a simple restart of the VSCode was enough.

I dont even have a solution file, your comment is useless

In my case my problem was fixed by looking at the sln file and checking that every project was referenced correctly: correct path and name. After that, a simple restart of the VSCode was enough.

I dont even have a solution file, your comment is useless

Sorry for bother you, I came to this issue a few hours ago, managed to resolve it and wanted to share my findings. Check in your .csproj files for inconsistences regarding other projects references.
The omnisharp have a several weeks since the last release, so maybe the problem is in the VSCode. To test this you can create a new project in a clean folder and watch if the message persists.

In my case my problem was fixed by looking at the sln file and checking that every project was referenced correctly: correct path and name. After that, a simple restart of the VSCode was enough.

I dont even have a solution file, your comment is useless

Sorry for bother you, I came to this issue a few hours ago, managed to resolve it and wanted to share my findings. Check in your .csproj files for inconsistences regarding other projects references.
The omnisharp have a several weeks since the last release, so maybe the problem is in the VSCode. To test this you can create a new project in a clean folder and watch if the message persists.

It is happening with default created projects, like dotnet new console

Yeah, my csproj files have not changed for some time and compile just fine,
its simply the OmniSharp Select Project command that fails
On Tue, Dec 14, 2021 at 1:29 AM EternalQuasar @.***>
wrote:

In my case my problem was fixed by looking at the sln file and checking
that every project was referenced correctly: correct path and name. After
that, a simple restart of the VSCode was enough.
I dont even have a solution file, your comment is useless
Sorry for bother you, I came to this issue a few hours ago, managed to
resolve it and wanted to share my findings. Check in your .csproj files for
inconsistences regarding other projects references.
The omnisharp have a several weeks since the last release, so maybe the
problem is in the VSCode. To test this you can create a new project in a
clean folder and watch if the message persists.
It is happening with default created projects, like dotnet new console
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/OmniSharp/omnisharp-vscode/issues/4907#issuecomment-992536965,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHJOXPHY5US2BKAIZX7X4TUQX7OFANCNFSM5IZF7R7Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Had the same problem, downgrading to VS Code 1.62 worked for me based on this so question (and response)
https://stackoverflow.com/questions/70290626/how-to-solve-the-problem-that-cant-select-project-using-omni-sharp-on-vs-core

can confirm that the issue happened after upgrading VSCode to 1.63, downgrading to 1.62 solved it

I downgraded to 1.62 and solved it too.

Hi all,
From here: https://github.com/OmniSharp/omnisharp-vscode/pull/4914#issuecomment-990243539
... you can install the prerelease build from https://github.com/OmniSharp/omnisharp-vscode/releases/tag/v1.23.18-beta2 as a workaround until a release is ready

Hello, in my case installing the beta version 1.24.0 of OmniSharp extension solved the error.

In my case my problem was fixed by looking at the sln file and checking that every project was referenced correctly: correct path and name. After that, a simple restart of the VSCode was enough.

It is worth to mention that omnisharp (and C# extension for VSCode) throws errors and does not auto-suggest when there is no .sln file or your project is not referenced correctly within the .sln file.

Omnisharp v1.24.0-beta1 did not fix my issue, I downgraded vscode to 1.62.3 and 1.23.17 omnisharp to get it working.

For me on vscode on windows, v1.24.0 beta fixed problem.

Hello, in my case installing the beta version 1.24.0 of OmniSharp extension solved the error.

This solved it for me too

Quick downgrade command for linux users:

apt-get install code=1.62.3-1637137107

I'm a little surprised this is broken in the default shipping configuration of vscode and the fix hasn't been deployed yet a month later.  Given how important intellisense is, losing it makes vscode basically unusable.  Priority up, please?

Quick downgrade command for linux users:

apt-get install code=1.62.3-1637137107

I'm a little surprised this is broken in the default shipping configuration of vscode and the fix hasn't been deployed yet a month later. Given how important intellisense is, losing it makes vscode basically unusable. Priority up, please?

And the issue is marked closed!

Updating to v1.24.0 resolved my issue on Windows x64. Here are instructions how you can install pre-release version in VsCode.
https://github.com/OmniSharp/omnisharp-vscode/wiki/Installing-Beta-Releases

I can't get the new version installed. https://marketplace.visualstudio.com/items?itemName=ms-dotnettools.csharp says that the latest version is 1.24.0, but if I check for extension updates within Code, it says v1.23.17 is the newest. If I uninstall the extension and restart Code, it says the version is v1.24.0, but if I then click Install it changes to v1.23.17. I am not sure if it is safe to install a VSIX file from a github page.

You need manually install version from github releases tab.


Clarify the strategy used for precached requests

CC: @mathiasbynens
https://developers.google.com/web/tools/workbox/modules/workbox-precaching doesn't include enough information about:

What strategy is used when the precaching module handles precached requests (it's effectively cache-first, with a fallback to the network to handle edge cases where a URL that should be precached resource isn't actually in the cache).
What happens when there's a runtime caching route that matches a URL that is also precached (first-registered wins, i.e. if the workbox.routing.registerRoute() is called before workbox.precaching.precacheAndRoute(), then the runtime route would win).

(Filing here for tracking purposes, even though the PR needs to be filed against https://github.com/google/WebFundamentals)

https://github.com/google/WebFundamentals/pull/6820


Add initial docs for OPA & SecurityContext

Just a draft,
Please review and comment :)

Closing this and opening new PR


Replace the PROPRIETARY notices with copyright notices to make

Replace the PROPRIETARY notices with copyright notices to make
the intention clear.  This should make it clear that the wrapped
Dreamworks license applies to the content.

Thanks Jeff! There are two more Houdini files in the repo which have slightly different copyright to the others which currently requires an explicit BSD exclusion:

GEO_VDBTranslator.cc
SOP_VDBVerbUtils.h

Any chance you could bring these two in line as well? It looks like HDK sample text which is being included:
/*
 * Copyright (c) 2012
 *      Side Effects Software Inc.  All rights reserved.
 *
 * Redistribution and use of Houdini Development Kit samples in source and
 * binary forms, with or without modification, are permitted provided that the
 * following conditions are met:
 * 1. Redistributions of source code must retain the above copyright notice,
 *    this list of conditions and the following disclaimer.
 * 2. The name of Side Effects Software may not be used to endorse or
 *    promote products derived from this software without specific prior
 *    written permission.
 *
 * THIS SOFTWARE IS PROVIDED BY SIDE EFFECTS SOFTWARE `AS IS' AND ANY EXPRESS
 * OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
 * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.  IN
 * NO EVENT SHALL SIDE EFFECTS SOFTWARE BE LIABLE FOR ANY DIRECT, INDIRECT,
 * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA,
 * OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
 * LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
 * NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE,
 * EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 *
 *----------------------------------------------------------------------------
 */

Yes, that looks like the HDK sample header.  I think we intentionally used that rather than our internal proprietary notice as it should be compatible.
What is the BSD exclusion that is required?  Is it the explicit reference to the MPL 2.0 that is required?
Reading through it, the standard dreamworks disclaimer/non-endorsement includes contributors, so the additional text asserting those rights for Side Effects are redundant.  So I should be able to reduce this to just the copyright.  (Minus the year, of course)


Add and fix support for multiple file uploads via ChannelMessageSendComplex via the new field MessageSend.Files.

For compatibility with existing library consumers, the File field is retained but will behave as if Files contained that single file. If both are specified, ChannelMessageSendComplex will return an error.
The message JSON payload is moved to a form-data field called payload_json, instead of set in multipart form data. This is supported and the recommended way, as per the API docs.
Apparently, you can attach multiple files if you just name the parts names differently in the multipart request. The parts are named here using the order the files were specified, as file%d. This is not documented in the API docs, but definitely works.
This also removes serialization of the File field via json.Marshal, as it will never be directly serialized in the JSON. The new field, Files, is similarly not marshaled.
This additionally adds a ContentType field in File, which can be used to specify the content type of the attached file. The ContentType field will default to setting the header to application/octet-stream if empty. Discord currently doesn't do much with the Content-Type header, but we should pass this information along anyway in accordance to the MIME standard.

Please make PR's into develop.


live stream audio

is it possible to live stream audio to NMS ?
Trying to figure out how ;/

I'm guessing I can stream from ffmpeg ?


pip install fails in conda and virtual env

Hi
The pip install fails currently with the following error.
ERROR: Could not find a version that satisfies the requirement sbibm
ERROR: No matching distribution found for sbibm

I tried it in a conda env and also just python3 virutal env

Hi @gsujan,
this is unexpected, installation via pip should work fine.
Could you try the following:
$ conda create -n sbibm_test python==3.8 -y
$ condo activate sbibm_test
$ pip install sbibm

Also, which operating system are you using?

Thanks @jan-matthis
For some reason, its working now. Not sure where the problem was.
OS: Ubuntu 18.04


add space

Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.56 seconds
stream load tsv:          431 seconds loaded<PHONE_NUMBER>9 Bytes, about 165 MB/s
stream load json:         22 seconds loaded<PHONE_NUMBER> Bytes, about 102 MB/s
stream load orc:          71 seconds loaded<PHONE_NUMBER> Bytes, about 14 MB/s
stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230411064812_clickbench_pr_127325.html

run buildall


Unable to create tag template with dictionary

Hi.
I'm working on updating to the latest version of the libraries. Previously I was using 0.8.0 and 1.0.0 where I had a similar problem, but found a simple workaround - some values as an object, but these workarounds no longer work in the newer version of the library.
In datacatalog 0.8.0, it was possible to create an tag template using a dictionary, but template fields must be passed as a TagTemplateField object.
        tag_template={
            "display_name": "Awesome Tag Template",
            "fields": {
                FIELD_NAME_1: TagTemplateField(
                    display_name="first-field", type_=dict(primitive_type="STRING")
                )
            },
        },

In a newer version, such a trick can no longer be used. If we want to create an object, we must always pass the fully typed object.
    request_good = datacatalog.CreateTagTemplateRequest(
        parent=LOCATION_PATH,
        tag_template_id=TEMPLATE_ID,
        tag_template=datacatalog.TagTemplate(
            display_name="Awesome Tag template",
            fields={
                FIELD_NAME_1: datacatalog.TagTemplateField(
                    display_name="first-field", type_=dict(primitive_type="STRING")
                )
            },
        ),
    )

However, I would expect that it would be possible to pass the object as a dictionary.
    request = dict(
        parent=LOCATION_PATH,
        tag_template_id=TEMPLATE_ID,
        tag_template=dict(
            display_name="Awesome Tag template",
            fields={FIELD_NAME_1: dict(display_name="first-field", type_=dict(primitive_type="STRING"))},
        ),
    )

As a workaround, I can convert this object on my side for now, but it would be great if the library handles it correctly.
    request = datacatalog.CreateTagTemplateRequest(
        parent=request.get("parent"),
        tag_template_id=request.get("tag_template_id"),
        tag_template=(
            datacatalog.TagTemplate(
                display_name=request.get("tag_template", {}).get("display_name"),
                fields={
                    k: datacatalog.TagTemplateField(**v)
                    for k, v in request.get("tag_template", {}).get("fields", {}).items()
                },
            )
            if request.get("tag_template")
            else None
        ),
    )

Environment details

OS type and version: Mac OS 11.01
Python version: Python 3.6.8
pip version: pip 20.2.4 from /Users/XXXXXXXXX/.virtualenvs/airflow/lib/python3.6/site-packages/pip (python 3.6)
google-cloud-datacatalog version: 3.0.0

Steps to reproduce

Run code from "code example" section or full example

Code example
    request = dict(
        parent=LOCATION_PATH,
        tag_template_id=TEMPLATE_ID,
        tag_template=dict(
            display_name="Awesome Tag template",
            fields={FIELD_NAME_1: dict(display_name="first-field", type_=dict(primitive_type="STRING"))},
        ),
    )
    log.info("create_tag_template(request=%s)", request)
    tag_template = client.create_tag_template(request=request)

Full example: https://gist.github.com/mik-laj/4d2e4701b0f827dff5a712300646f024
Stack trace
Traceback (most recent call last):
  File "files/datacatalog_lookup_entry.py", line 105, in <module>
    tag_template = client.create_tag_template(request=request)
  File "/Users/X/.virtualenvs/airflow/lib/python3.6/site-packages/google/cloud/datacatalog_v1beta1/services/data_catalog/client.py", line 1582, in create_tag_template
    request = datacatalog.CreateTagTemplateRequest(request)
  File "/Users/X/.virtualenvs/airflow/lib/python3.6/site-packages/proto/message.py", line 461, in __init__
    pb_value = marshal.to_proto(pb_type, value)
  File "/Users/X/.virtualenvs/airflow/lib/python3.6/site-packages/proto/marshal/marshal.py", line 205, in to_proto
    pb_value = rule.to_proto(value)
  File "/Users/X/.virtualenvs/airflow/lib/python3.6/site-packages/proto/marshal/rules/message.py", line 32, in to_proto
    return self._descriptor(**value)
TypeError: Parameter to MergeFrom() must be instance of same class: expected google.cloud.datacatalog.v1beta1.TagTemplateField got dict.

CC: @busunkim96

@busunkim96 I'm not totally sure if this would be a bug, but is this an expected change?

@meredithslota While working on migrating to this library, I noticed that the problem also occurs with the Tag type.
Reference:
https://github.com/apache/airflow/blob/9235af594c54d4a2991c494929deef37eee33ac6/airflow/providers/google/cloud/hooks/datacatalog.py#L232-L245
https://github.com/apache/airflow/blob/9235af594c54d4a2991c494929deef37eee33ac6/airflow/providers/google/cloud/hooks/datacatalog.py#L295-L306
Both objects contain proto.MapField in their definition.
https://github.com/googleapis/python-datacatalog/blob/6ca679ec15c6bab726e311b7637d4c8c9c84e508/google/cloud/datacatalog_v1/types/tags.py#L82
https://github.com/googleapis/python-datacatalog/blob/6ca679ec15c6bab726e311b7637d4c8c9c84e508/google/cloud/datacatalog_v1/types/tags.py#L185-L187

I believe this is https://github.com/googleapis/proto-plus-python/issues/161

Closing as a duplicate of https://github.com/googleapis/proto-plus-python/issues/161, as I don't believe there will be any changes required to this library once the issue is resolved in proto-plus.


Inconsistent horizontal scroll behaviour across platforms

During my testing with a Linux laptop with a trackpad, I noticed that horizontal scroll behaves the inverse between Linux and macOS.
I do not have direct access to that machine right now, but want to report the issue for posterity.
I had the issue in https://github.com/DISTRHO/Cardinal/issues/582 where I noticed on a Linux machine that it was inverted, so fixed that by inverting on the plugin side, but then that made it wrong on macOS.
Basically the horizontal scroll on either macOS or Linux is inverted between each other.
I was unable to try this on a Windows machine, so do not know what is the state there.

Seems it was reversed on MacOS compared to X11 and Windows.  The speeds with trackpads are wildly inconsistent, it looks like some explicit support for high resolution is needed, but direction fixed in 4d9059e anyway.  I'm not able to test on MacOS with a mouse with a detented wheel.


Scoop app detection has been broken

Scoop has changed its export format to “pretty” JSON and the app detection is now failing. These changes were done on June 24 and released on July 7. I can help with updating ScoopFactory.cs, but I wonder if it is necessary to retain compatibility with old format.

Ideally it should fall back to the old format if parsing JSON fails. It looks like you've done that in the PR, so that's good. Thank you for taking your time to fix this.


Jg/polished 3.1 vcf export

This PR is to add the cleaned up gnomad v3.1 VCF export code incorporating in the VCF export of the HGDP + TGP subset. It does rely on the sanity code being in place, but that is a separate PR and I was hoping to have this PR looked at in the meantime because of how long it is. Therefore the checks will currently fail until we get the sanity check PR in master and another PR for the generalized functions in gnomad_methods.
The two tests I performed used the sanity check files from the following branches:
https://github.com/broadinstitute/gnomad_methods/tree/jg/temp_sanity_check
https://github.com/broadinstitute/gnomad_qc/tree/jg/temp_sanity_check
It also relies on the code added to gnomad_methods in the following PR:
https://github.com/broadinstitute/gnomad_methods/pull/365
Output from the tests of the code here:
Full dataset:
https://console.cloud.google.com/dataproc/jobs/2be4d656f7824125906e3ac7d4dff6c0?region=us-central1&project=broad-mpg-gnomad
Hgdp + tgp subset: https://console.cloud.google.com/dataproc/jobs/c62c14d696ce4e0c956cf09482a2107a?region=us-central1&project=broad-mpg-gnomad

I have addressed all comments, but I want to run a full test on the code again. I think it makes sense to wait until the sanity check code is updated and merged so that I can run it with the new sanity check code.

After a few fixes that came up during testing, this is back to you @ch-kr.
Output from the tests of the code here:
Full callset test: https://console.cloud.google.com/dataproc/jobs/d96ead586837410ca1c036756e2216f1?region=us-central1&project=broad-mpg-gnomad
HGDP + TGP subset test: https://console.cloud.google.com/dataproc/jobs/308f2e02543d49b5bd47cad970979a0d?region=us-central1&project=broad-mpg-gnomad

For the first comment, this is because of gnomAD QC fully removing some subpopulations during the QC outlier detection. It is a known issue that we hope to improve in future QC with highly diverse samples. So all of these are currently expected.
I will look into the second comment

So my guess for the missingness is that if there is an AN = 0 then the AF evaluates to NA because of the divide by zero. I'm OK keeping as is because it really is a divide by zero, but would like to hear other thoughts @gtiao? For this case we could also change it so it is a struct with all missing or a struct with all zero if that seems easier to interpret? Also, I think this is something that needs to be handled in the frequency code or the release HT/MT code so would be better fixed in a different PR and I can add a separate issue.

that makes sense to me -- just approved


[FLINK-3960] ignore EventTimeWindowCheckpointingITCase for now

Until FLINK-3960 is fixed, we need to disable this test to allow other
tests to execute properly.

+1 to skip the test until the RocksDB config fix is in.
Will greatly help other builds...


Achievements: Nearby count invisible

Hi, I would like to make my first contribution, can you give me more info about this, please?
Also, I clone the project and download the app from Google Play, but I can't find the view for this issue.

@Charlitos96 You have to log in and click the kind of cup next to your username in the left menu.
Thanks! :-)

Thank you, I can access on the app from Google Play, but When I run the project from Android Studio to my Phone, it asks me for a "Common Beta Account", Can you provide me one for tests?

Please build the prodDebug flavor.
On Mon, Jun 8, 2020 at 4:50 PM Carlos Jimenez<EMAIL_ADDRESS>wrote:

Thank you, I can access on the app from Google Play, but When I run the
project from Android Studio to my Phone, it asks me for a "Common Beta
Account", Can you provide me one for tests?
[image: Commons Beta]
https://user-images.githubusercontent.com/42658489/84005342-d8879300-a921-11ea-81d8-a0e2402fcf84.jpeg
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/commons-app/apps-android-commons/issues/3767#issuecomment-640431148,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAYKBSSA3Z76SDS3XODJHDRVSJ2VANCNFSM4NIO7IMA
.

It seems like the bug was because you call the API and need to wait for a response, while the app is waiting for a response, the counter comes invisibly. I set a default value of 0 before calling the API and when the response of the API is ready, the value was updated.
#3796

I'm looking for a folder to make a Test for my contribution, but I didn't find it, Can you tell me where did you put yours tests? or do I make a new folder?

@Charlitos96 You can follow the guidelines here, automated tests must live under the androidTest source set and unit tests must live under a test source set. The package structure of the project should be mirrored between test and source

Hi, I made a PR with my test, but when I run the test this problem jumps:
AboutActivityTest.kt: (39, 68): Unresolved reference: getVersionNameWithSha
That's a problem not realted with my issue, or with what I made, in fact I see there is another PR that can solve it #3850

Hello,
Following the pattern from the link, they pass the reference of the element that triggered the Modal using openModal('dialog1',this).
Using that as a guide, I update the method handleOnClick() to pass the reference of the button with event.target to update modalTriggerElement with it.
If this was not the approach you suggested please let me know. 😄

Hi @Charlitos96  Can you add the link to your PR over here so that we can help finalize it?


feat: don't make ArgumentParser implement SuggestionProvider

Should remove all the implements SuggestionProvider.NoSuggestions - that interface can probably be removed and just be directly implemented as a lambda for SuggestionProvider.noSuggestions now.


How to increase timeout

Hi, I am using MyInfluxDbclient to write the data into influxDB. However, I am suffering from timeout error:
Can I ask how can I increase the timeout limit to avoid the following error? Thanks
MyInfluxDbClient.InfluxDbClientException: InfluxDb request failed.
HttpMethod: POST
HttpStatus: InternalServerError
Uri:http://xx.xx.xx.xx:8086/write?db=BBGDailyData
Reason: Internal Server Error
Content: {"error":"timeout"}

So sorry that I have missed this. I realize it's to late but maybe someone else can benefit from it. You would need to configure that on an HttpRequester instance and pass that in via the constructir.


Add plugins page

Based on #22

ok, I cherry-picked everything that wasn't the plugins page, then copied over your image cards from GitHub.
I think that should hopefully be everything? So it's only one of these commits that didn't make it in..


[general] Notify users on extension update

Is your feature request related to a problem? Please describe.
When the version has been updated, display a message showing new release
// Check whether new version is installed
chrome.runtime.onInstalled.addListener(function(details){
    if(details.reason == "install"){
        console.log("This is a first install!");
    }else if(details.reason == "update"){
        var thisVersion = chrome.runtime.getManifest().version;
        console.log("Updated from " + details.previousVersion + " to " + thisVersion + "!");
    }
});

Will be delivered in 1.22


fix(pci.projects.vouchers.add): add missing form for oui-field

See : MANAGER-2684
issue : js error in console due to missing form tag around oui-field component
fix : added missing form tag

Even if the ticket is still in quality check I will merge this pull request in order to be able to provide a new release branch.
Thanks!


docs(README): typo

radosgw-admin --id admin caps.... or radosgw-admin caps...

@faust64 Good catch. Thanks for contributing.  :cake:


Make verify command more easy to understand

USING MY IMAGE I SEE @iranathan

Not really an improvement - Just attaching an image.
Main issue is that you took it without permission.


minor fix in validate

I've noticed this make to create empty arrays and then appending
items. This will also result in 'unknown key' log if verbose
level is high enough.
Instead of creating cfgkey properly, this PR just removed it and
made classifyKeys iterate over the keys in the cfg map directly.

This change is

LGTM

@sebastienvas which groups does @jmuk need to be in for presubmit and e2e-smoketest.

I haven't updated the branch (this PR was created before I joined istio team yesterday). I believe those jenkins tasks will run soon.

@mandarjog He should be in istio org. The presubmit got queued.

@jmuk can you ensure that you run bin/fmt.sh  and bin/linters.sh before submitting the PR ?
From https://github.com/istio/mixer
 * [new branch]      master     -> parent
Using<PHONE_NUMBER>2373faf5df6b07f57da917f4e54ad3^ to compare files to.
pkg/config/validator.go:1::warning: file is not gofmted with -s (gofmt)
pkg/config/validator.go:363:11:warning: should omit 2nd value from range; this loop is equivalent to `for key := range ...` (golint)

Jenkins job mixer/presubmit passed

Jenkins job mixer/manager-regression passed

Jenkins job mixer/e2e-smoketest passed

Jenkins job mixer/presubmit passed

Jenkins job mixer/manager-regression passed

Jenkins job mixer/e2e-smoketest passed

Jenkins job mixer/presubmit passed

Jenkins job mixer/manager-regression passed

Jenkins job mixer/presubmit passed

Jenkins job mixer/presubmit passed

Jenkins job mixer/manager-regression passed

Jenkins job mixer/presubmit passed

Jenkins job mixer/presubmit passed

Jenkins job mixer/presubmit passed

Jenkins job mixer/manager-regression passed

Jenkins job mixer/e2e-smoketest passed


Build Tensorflow r1.13 with verbs and gdr report rdma error

cmd :  bazel build --config=opt --config=cuda --config=gdr --config=verbs --distdir=/home/bazel_package //tensorflow/tools/pip_package:build_pip_package
Due to network problems, I downloaded the dependencies in advance.
And I have install  the SW stack (libibverbs, etc..)
	sudo yum install jemalloc
	sudo yum install jemalloc-devel
	sudo yum install libibverbs
	sudo yum install libibverbs-devel

Error info:
bazel-out/k8-opt/genfiles/tensorflow/core/protobuf/config.pb_text.cc:882:9: note: 'map_value' was declared here
   int32 map_value;
         ^
ERROR: /home/zgz/submit_code/tensorflow/tensorflow/contrib/verbs/BUILD:105:1: C++ compilation of rule '//tensorflow/contrib/verbs:rdma_mgr' failed (Exit 1)
In file included from tensorflow/contrib/verbs/rdma_mgr.cc:18:0:
./tensorflow/contrib/verbs/rdma_mgr.h: In static member function 'static void tensorflow::RdmaMgr::RegMemVisitors()':
./tensorflow/contrib/verbs/rdma_mgr.h:50:16: error: invalid use of member 'tensorflow::RdmaMgr::rdma_adapter_' in static member function
   RdmaAdapter* rdma_adapter_;
                ^
tensorflow/contrib/verbs/rdma_mgr.cc:282:40: error: from this location
     int32_t bus_id = TryToReadNumaNode(rdma_adapter_->context_->device) + 1;
                                        ^
Target //tensorflow/tools/pip_package:build_pip_package failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 80.943s, Critical Path: 51.17s
INFO: 2025 processes: 2025 local.
FAILED: Build did NOT complete successfully

please tell me how to fix this.

Sorry that the verbs fix #24250 did not make into r1.13. Let us know if you met any other problems with that fix.

I only saw you discussing how to solve in  #24250 .
I want to know what should I do? Can I change the code according to https://patch-diff.githubusercontent.com/raw/tensorflow/tensorflow/pull/24250.patch what you mentioned in #22455 . I hurry to compile tf1.13 with GDR and Verbs.

Yes, could you try that?
curl https://patch-diff.githubusercontent.com/raw/tensorflow/tensorflow/pull/24250.patch | git apply

asd

OK, I try it Now.

I fix the issue, but only modify  rdma_mgr.cc and verbs_server_lib.cc . Do I still need to modify other files?

I don’t know. Did you get it working?

Now I compile sucessfully. I find many diff in 24250.patch, but when I exec 24250.patch, only modify rdma_mgr.cc and verbs_server_lib.cc .
Due to network problem, my server can not exec curl https://patch-diff.githubusercontent.com/raw/tensorflow/tensorflow/pull/24250.patch | git apply. So I manually  create a file 24250.patch .  Do I still need to manually modify other files that show in 24250.patch?
现在我已经编译成功了。
由于网络问题，我的服务器节点无法访问https://patch-diff.githubusercontent.com/raw/tensorflow/tensorflow/pull/24250.patch, 所以我创建文件24250.patch并拷贝网站上内容，上传到服务器。 在服务器执行git apply 24250.patch，然后执行git diff，发现只修改了 rdma_mgr.cc 和 verbs_server_lib.cc。
但在https://patch-diff.githubusercontent.com/raw/tensorflow/tensorflow/pull/24250.patch上显示修改了很多文件，我现在是否需要将其他文件手动修改？

If it’s working it’s working.
Let us know when you find that it’s not :)


Bugfix for getWalletFromIdentifier

Coverage decreased (-0.04%) to 83.281% when pulling 8dd76a0dbac66ed828d30c68bc80c341702b8355 on isocolsky:fix/support-tool into f81b5484c523bebb3a30c48f7f998f7fbbbafb4d on bitpay:master.


pypi package have wrong code

pypi package v. 0.1.6 (wheel) has old code (w/o DJANGO 1.8 fixes)

pip version broken in 1.9 :-(  - but latest code here works :-)

+1. I get this error from pypi:
  File "/home/ubuntu/allinsights/channels/models.py", line 5, in <module>
    from fuzzycount import FuzzyCountManager
  File "/home/ubuntu/.virtualenvs/production/lib/python3.5/site-packages/fuzzycount.py", line 6, in <module>
    from model_utils.managers import PassThroughManager
ImportError: cannot import name 'PassThroughManager'

Actually, even if I use the latest code, I get the above error. Is django fuzzycount broken on Python 3? Or just in general?

I use it with python 3 and no problems.  I have only tested up to Django 1.9 however, 1.10 may be broken.

Apparently the problem is that PassthroughManager was removed in django-model-utils 2.4, so you can't upgrade to that.

Just pushed 0.1.7 PyPI.


nixos/systemd-boot: move all template variables in one place

This makes it easier to reason about what variables are inserted during packaging. We also make sure that template file is also valid python syntax, which makes editor errors go away during development.
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg test systemd-boot


FAI-173: Embed kogito-tooling editors in trusty-ai. Part 2 (trusty-ai changes)

=== DO NOT MERGE ===
=== NEED A RELEASE OF KOGITO-TOOLING TO NPM BEFORE COMPLETING ===
See https://issues.redhat.com/browse/FAI-173
This PR needs further changes to add @kogito-tooling/embedded-editor as a dependency once it has been released to npm and the code changed to actually use the editor component.
At the moment this PR simply unpacks the DMN editor itself to the PoC webapp.

@manstis why do you need to unpack the DMN editor outside the embedded-editor? I would see it as part of its internal implementation. it should be a self-contained component, isn't it?

Hi @kelvah, @tiagobento Did not want them packed and published to npm.. he was of the opinion it is better for the consumer to determine what version of the editors to embed. Personally, I don't mind either way. The self-contained bit is really generic support to embed something where we (currently) still need to provide the something. When this PR is ready for review I'll add @ederign for opinion as to whether kogito-tooling should bundle the editors themselves or, as this PR does, leave it for the end consumer to handle...

Hi @kelvah, @kogito-tooling have released a new version.
I've updated this PR and it is now ready for merge!


Override Config aws-smithy-client

Describe the feature
Hi all,
as a follow-up of this issue https://github.com/awslabs/aws-sdk-rust/issues/558
where we can set the timeout for the client to be latency aware with the retries
#[tokio::main]
async fn main() -> Result<(), Error> {
    tracing_subscriber::fmt()
        .with_ansi(false)
        .without_time()
        .with_max_level(tracing_subscriber::filter::LevelFilter::DEBUG)
        .init();

    let timeout_config = timeout::Config::new()
        .with_api_timeouts(
            timeout::Api::new()
                .with_call_timeout(TriState::Set(Duration::from_millis(150)))
                .with_call_attempt_timeout(TriState::Set(Duration::from_millis(50))),
        );
    let config = aws_config::from_env()
        .retry_config(RetryConfig::new().with_max_attempts(3))
        .timeout_config(timeout_config)

        .load()
        .await;

    let dynamodb_client = aws_sdk_dynamodb::Client::new(&config);

I have noticed the following:
DEBUG aws_smithy_client::retry: attempt 1 failed with Error(TransientError); retrying after 435.692227ms
And the aws-smithy-client/src/retry.rs is configured as:
const MAX_ATTEMPTS: u32 = 3;
const INITIAL_RETRY_TOKENS: usize = 500;
const RETRY_COST: usize = 5;

And I have no way to overwrite the default parameters.
From the test, I cannot get exactly where the initial value of the backoff  is coming from
https://github.com/awslabs/smithy-rs/blob/a0539e20b069a7de021c84521d8f3c7ba098ad6d/rust-runtime/aws-smithy-client/src/retry.rs#L276
It seems to me that this line of code is not correct:
let backoff = b * (r.pow(self.local.attempts - 1) as f64);
let backoff = Duration::from_secs_f64(backoff).min(self.config.max_backoff);

Because:

it does not consider a value to calculate the retry
convert all in seconds with a max of 20s

It should be based on milliseconds https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=7deed195b0811c97887dbcd6c98f1a6e
let exponential_delay = (ms * (r.pow(attempts - 1) as f64)) as u64;
let backoff =  Duration::from_millis(exponential_delay).min(Duration::from_secs(20));

If we can pass the backoff value it could become
let retry_config = RetryConfig::new()
  .with_max_attempts(5);
  .with_backoff_delay(100); //ms

Use Case
When you are latency aware, you should be able to overwrite the default parameters to configure the backoff.
In my configuration case, I have the following:

3 retries
50ms a for a single attempt
overall duration 150ms

the back-off moves the second retry after 435.692227ms
DEBUG aws_smithy_client::retry: attempt 1 failed with Error(TransientError); retrying after 435.692227ms
This means that it will never retry a second time.
Proposed Solution
Be able to overwrite the backoff policy.
If I wish to have this configuration

3 retries
50ms a for a single attempt

I could setup the backoff policy at 10ms. For example, I would have the following after the first failed attempt.
Retry 1 -> retrying after 20ms
Retry 2 -> retrying after 40ms
Retry 3 -> retrying after 60ms
Now I can setup my overall duration "with_call_timeout" to 210ms, giving the retries time to happen.
Other Information
No response
Acknowledgements

[ ] I may be able to implement this feature request
[ ] This feature might incur a breaking change

A note for the community

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue, please leave a comment

thanks! We should figure out the right knobs to enable quicker retries for services like DynamoDb.

Considering AWS JavaScript SDK as a reference for timeouts and usage, the current Retry logic is incorrect (bug).
After the first failure, the Rust SDK generate a random instead of following the 100ms default setting for all services and the 50ms retry for DynamoDB.

Hey @ymwjbxxq, I'm going to look into this issue. While we (the Rust SDK team) aim for parity with the other SDKs, we don't necessarily want to copy their behavior exactly. There is a relatively new internal-only AWS proposal doc that defines how SDKs should handle retries and also covers service-specific defaults. I'd like to stick to their recommendations as much as possible. I'm also going to do a survey of how multiple SDKs currently handle retries and retry configuration.
While I appreciate your PR, I think removing the random element is not the right approach, and I hope you don't mind me proposing and alternative. This might take me some time, but I want to make sure we solve this problem thoroughly enough that we don't have to revisit it later and cause churn for people with custom retry configuration.
Some extra context on backoff and jitter:

https://aws.amazon.com/builders-library/timeouts-retries-and-backoff-with-jitter/
https://aws.amazon.com/blogs/architecture/exponential-backoff-and-jitter/

It is ok do not worry.
Maybe it could be random if I do not overwrite the configuration but it does not really make sense if the random is bigger than the overall timeout.
I will report again how I would use it to achieve high performance regardless from the service
  let timeout_config = timeout::Config::new()
       .with_api_timeouts(
           timeout::Api::new()
               .with_call_timeout(TriState::Set(Duration::from_millis(270)))
               .with_call_attempt_timeout(TriState::Set(Duration::from_millis(30))),
       );
   let config = aws_config::from_env()
       .retry_config(RetryConfig::new()
                                  .with_max_attempts(3)
                                  .with_base(50)) -> My backoffretries interval
       .timeout_config(timeout_config)
       .load()
       .await;

Given these settings:

3 retries
backoff at 50ms interval
a single attempt at 30ms
total timeout with all retries included at 270ms

I would expect:

original attempt -> 30ms -> fails
1 attempts -> after 50ms -> 80ms + (30ms) -> fails
2 attempts -> after 50ms -> 160ms + (30ms) -> fails
3 attempts -> after 50ms -> 240ms + (30ms) -> fails

Current implementation with these settings:

3 retries

a single attempt at 30ms

total timeout with all retries included at 270ms

original attempt -> 30ms -> fails

1 attempts -> after 500ms because it is random

The current implementation goes against the idea of timeout and in fact, I do not have any retry because I timeout before unless I let the SDK do their things and eventually come back with some results.
To sum up:
I agree with you about the research but my alternative proposal would be:

You can use your random logic if nothing is set and the SDK should work within their default values (that you must declare somewhere).
You should allow me to overwrite it and have a predictable timing.

Hi @Velfi
I read your links about backoff and jitter, and I think a FullJitterBackoffStrategy would be:
let exp_backoff = self.config.base as f64 * (r.pow(self.local.attempts - 1) as f64);
let mut rng = rand::thread_rng();
let jitter = rand::Rng::gen_range(&mut rng, 0.0..exp_backoff);
let final_backoff = exp_backoff + jitter;
let backoff = Duration::from_millis(final_backoff as u64).min(self.config.max_backoff);

this will generate something like:
exp_backoff 1.0
jitter 0.5013046685201143
final_backoff 1.5013046685201143

exp_backoff 2.0
jitter 1.0432303030223897
final_backoff 3.0432303030223897

exp_backoff 4.0
jitter 2.2986709031456165
final_backoff 6.2986709031456165

At least the overall timeout with retry included is a value that can be calculated considering the worst-case scenario.
Would you be happy with something like this?

@ymwjbxxq Thank you for doing so much leg work! These posts are helpful.

@Velfi I did extra tests:

I run DynamoDB without the SDK retries
I have implemented (hopefully correctly) FullJitterBackoffStrategy and EqualJitterBackoffStrategy based on DynamoDB error.

The results are with my expectations. A faster response!!!
My configuration for example, with max 2 retries:
const MAX_ATTEMPTS: u32 = 3;
const BASE: u32 = 10;
with_call_attempt_timeout: 30ms

What I conclude is the SDK should apply maybe the:

EqualJitterBackoffStrategy (I think is the current implementation) for throttling error and the BASE as you have now is 500ms up to 20 seconds (I think the 4XX exceptions)
FullJitterBackoffStrategy for all the rest (5XX exceptions)

The same rule should applies to all services.
To make the SDK life easier, I would not apply any strategy based on errors but use the FullJitterBackoffStrategy with a BASE of 500ms and allow the user to overwrite the base. This should fix all the needs of SDK users.

Hey @ymwjbxxq, here's the latest:
I've been poring over internal specs and documentation on retries and I think I finally have a pretty good view on the state of things. Here are my findings:

The various SDKs have various strategies for how they handle retries. This creates a negative experience for customers because it's inconsistent. I'll refer to these various retry strategies as "legacy" retries. There is published documentation that directs users how to configure "legacy" retries. These docs are SDK-specific and not exactly helpful when trying to understand the retry strategy of SDKs other than the one they were written for.
There is an AWS initiative to standardize all SDKs around a retry strategy based off of jitter and exponential backoff. I'll refer to this strategy as "standard" retries. Because the Rust SDK is so new, we implemented the new "standard" retry strategy. We don't plan to support "legacy" retries.
Customers (like you) have expressed that the "standard" retry initial backoff delay is longer than they'd expect for services like DynamoDB

In the Rust SDK, we have implemented backoff delay calculation this way:
// b is a random number between 0 and 1
// r is a constant that is always set to 2
let backoff = b * (r.pow(self.local.attempts - 1) as f64);
let backoff = Duration::from_secs_f64(backoff).min(self.config.max_backoff);

Duration::from_secs_f64 is the intended method for creating the backoff delay because the delay is calculated on the scale of seconds, not milliseconds. As you found, this does not conform to the behavior of the Javascript SDK. However, the Javascript SDK's retry strategy is the "legacy" strategy, while the calculation above is defined as part of the new "standard" strategy. It's not incorrect, but I can see how it would be surprising.
My next subject of investigation is to find out why AWS used to recommend retries on the order of milliseconds when the new strategy is acting on the scale of seconds. Once I can get a solid answer on that, I believe I'll have enough information to decide on a resolution.

Hey @ymwjbxxq , my retry PR got merged and is now pending release. We'll try to get a release out this week and then you can let me know if the update improves things for your use case.
See the PR for more info

This went out in the July 21st SDK release.


OSX library issues

OSX uses a weird dynamic library system where the library paths are somehow in the library. This makes creating a relocatable binary problematic. Some users are reporting issues running the pre-built binaries on OSX.

ProtoGen is now .app bundle on OS X. macdeployqt is used to deal with the frameworks issue.


Use arguments of same type with _CFMultiplyBufferSizeWithoutOverflow

Using a mix of signed and unsigned types here caused a librt call to __mulito4 to be emitted instead of properly lowering the call.

@swift-ci test

@swift-ci test osx

@swift-ci please test and merge

@swift-ci please test and merge


Vitejs ssr.noExternal does not work with nodejs built-ins

Describe the bug
When running vite build --ssr the build fails with the following error:

I understand that this is a expected error and not really a "bug". However, my goal is to be able to bundle my entire react app into 1 singular file (with no imports etc). What are my options here?
Reproduction
null
Steps to reproduce
Create a new vite application with react + typescript. Make a standard ssr entry file and run a normal vite build --ssr.
System Info
MacOS, Chrome

Used Package Manager
pnpm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Yes, this is a expected behavior.
https://vitejs.dev/guide/ssr.html#ssr-bundle:~:text=You can enable,ins are imported
I guess ssr.noExternal: /./ would work.


Add very simple benchmarking against reactor-c

This should be merged AFTER #137
This PR adds the Savina PingPong and a ReactionLatency benchmark, with a C and uC version. Current results on my machine is:
PingPongUc:
 Best Time:      77.571 msec
Worst Time:      87.062 msec
Median Time:     77.455 msec
PingPongC:
 Best Time:      122.188 msec
Worst Time:      130.564 msec
Median Time:     123.531 msec
ReactionLatencyUc:
 Best latency: 17358.
Median latency: 56424
Worst latency: 255700
ReactionLatencyC:
 Best latency: 4804
Median latency: 53017
Worst latency: 307132

I.e. our runtime has less overhead (PingPong only needs 60-70% of the time needed by reactor-c). When it comes to reaction latency, we are very similar to reactor-c, the Median latency is the most useful number showing that we might have a slightly longer execution path from wakeup to the first reaction. But not significantly. Those last numbers are in nsec btw

vewwy vewwy cool.
can you also post the binary sizes and ram usage? of those two examples?


CIRA configuration with static network is not working

Describe the bug 🪲
In previous releases when we configured CIRA with static network in the AMT profile, AMT 12 and newer devices would be able to connect to MPS using CIRA.  With the RPS 2.7 (release candidate) the AMT device is configured, however, it never connects to MPS (AMT reports 'connecting").
To Reproduce 🪜
Steps to reproduce the behavior:

Create AMT profile that is both static network and has a CIRA configuration
configure AMT device with profile
See that AMT doesn't connect to MPS.  AMTINFO always reports "connecting" state

Expected behavior
Expect AMT 12 and newer devices to connect when configured to use CIRA on static network
Screenshots 🖼
If applicable, add screenshots to help explain your problem.
AMT Device (please complete the following information): 🖥

OS: Windows and Linux
AMT Version: 11.8, 12, 15, 16
AMT Configuration Mode: ACM and CCM
Network Configuration Static

Service Deployment (please complete the following information): ⛈

Deployment Type: Docker and Developer
Node Version: LTS 16
Component & Version: RPS 2.7 (release candidate), MPS 2.7 (release candidate), RPC-Go 2.5 (release candidate

Additional context
Add any other context about the problem here.

Closing this issue because I was not able to reproduce it on AMT versions <IP_ADDRESS>5, <IP_ADDRESS>8 and <IP_ADDRESS>2. All the 3 platforms were on Windows OS.
Important note, Intel Local Management Service (LMS) needs to be installed on platform for this to work.


support non-ascii characters in errors.json

Regarding issue #1289, using ensure_ascii=False in the parameter of json dump inside the save_nlu_errors function, non-ascii characters will be show correctly in the error.json file.
Status (please check what you already did):

[x] made PR ready for code review
[ ] added some tests for the functionality
[ ] updated the documentation
[ ] updated the changelog

Thanks a lot for this encoding fix :+1: - did a small change to fix a pep8 issue but other than that we are good to merge :rocket:


[VA-5758] Separate chapterDetails reporting and collection schemas

Please link to the issue #…

Details that sit behind this refactoring are covered in this decision record: https://wiki.corp.adobe.com/pages/viewpage.action?spaceKey=analytics&title=XDM+Media+Model+for+collection+vs+reporting


Unsloth On Mac

So, I have a macbook, and when i run my model on it, i bascially get an error saying no CUDA device found. I know that there is no gpu on macbooks, so does that mean that I cannot run my model on my mac?(I have a macbook m3 16)

You definitely can run models using Mac's using programs like Ollama or Jan AI, however if you're talking about fine-tuning with Unsloth, no unfortunately Unsloth will not work on Mac devices however we are working on it.
See here for more info: https://github.com/unslothai/unsloth/issues/4

@shimmyshimmer what alternatives would you suggest fro Mac users?

MLX :)


GAAD pledge for cloud native projects

The GAAD Foundation is a nonprofit organization whose mission is to disrupt the culture of technology and digital product development to include accessibility as a core requirement. Their vision is for accessibility to be built into the product development lifecycle for technology and digital products.
They provide GAAD Pledge which is a call to action for open-source leaders to embed accessibility at the core of their projects, paving the way for an inclusive digital world where every code contribution opens doors for all.
Given the global scale of CNCF, it would be great to identify a few projects that can take the GAAD pledge. Let's make our projects more accessible!
I would love for this to be a criteria as new projects are onboarded or add them for maturing to a later stage.

Looping @TheFoxAtWork into this discussion, since the TOC is responsible for determining the criteria for new projects.

CC @dzolotusky @dims as Liaisons, @nikhita as Vice Chair
We've (TOC) previously discussed the impact of pledges, suggestions, recommendations, and criteria have on projects and the community.  Pledges are lovely things however what is more impactful is creating and implementing sustainable programs with clear guidance for projects to undertake should they choose.  It is my preference that we demonstrate maturity in how this could be acted upon by projects before beginning discussions on establishing criteria around them.
Accessibility is an essential pillar in any contributor strategy and has the potential to enable contributions from community members who historically have difficulty getting to a point where they can consistently and meaningfully contribute to projects in whatever capacity their skills align with.
@CathPag had some good suggestions to begin moving forward with this:

Increase awareness of GAAD for projects. This can initially be a web page on contribute.cncf.io/accessibility

Beyond awareness -  if we want to make this actionable, TAG CS would need at least two individuals to step forward and lead an effort to identify specific guidance, actions, and recommendations projects could undertake that move from 'pledge' to 'action'.  The critical factor here is that we have individuals interested, willing, and available to drive this effort from the beginning.
Eventually, along with the Deaf and Hard of Hearing WG, these efforts could become formalized into a Linux Foundation program for increasing accessibility and inclusivity across open source projects and foundations. CNCF has made great strides at KCCN, I can see this effort creating free training and resources for maintainers to learn how to expand their potential contributor pool through efforts like this.


a method to skip server ssl verification

when we try to skip server ssl verification. like docker's insecure-registry or kaniko's --skip-tls-verify-registry parameters.

Looks good to me, but waiting on @evelynl94 since she set this stuff up a while back.

@apourchet  when the pr try to pass travis ci, a problem occur.

@apourchet when my pr try to pass the travis ci, a problem occur.

@apourchet when my pr try to pass the travis ci, a problem occur. TROUBLESHOOTING: A FOSSA API key is needed to run this command. How can i do ?  It seems like that I need provide a FOSSA API key, but I don't have one. Wait your answer.

@apourchet when my pr try to pass the travis ci, a problem occur. TROUBLESHOOTING: A FOSSA API key is needed to run this command. How can i do ? It seems like that I need provide a FOSSA API key, but I don't have one. Wait your answer.

This is fine. Only branches from this repo have access to that key.
As long as other tests passed you are good.


[maccatalyst] Handle macCatalyst static swiftmodules

The existing CMake code for macCatalyst swiftmodule only handled the shared case, and did not have the static pieces that non-macCatalyst targets are doing.
Try to match as much as possible the non-macCatalyst variables and structure and allow macCatalyst targets to support static Swift targets.
This is important for the Cxx.swiftmodule and CxxStdlib.swiftmodule, since they are only static, and the previous code skipped creating those files since https://github.com/swiftlang/swift/pull/74994

@swift-ci please test

@swift-ci please test

Does someone have any feedback about this?

@swift-ci please test


Example code problem

Hi! I'm trying this tools. And I found some problem. Hope you can help solve them!
In /master/scripts/driver.py, line 14~28:
sg.add_dataset('HepG2_1', hep_1_gtf,
	counts_file=ab_file,
	count_cols='hepg2_1')

during I'm  running, this error come out
--------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
Input In [5], in <cell line: 1>()
----> 1 sg.add_dataset('HepG2_1', hep_1_gtf,
      2         counts_file=ab_file,
      3         count_cols='hepg2_1')

TypeError: add_dataset() got an unexpected keyword argument 'counts_file'

I see the soure code find it has changed. What I should do now?
Another problem in my own data:
/home/lengliang/lzy/mambaforge/lib/python3.9/site-packages/anndata/_core/anndata.py:798: UserWarning:
AnnData expects .obs.index to contain strings, but got values like:
    [0, 1]

    Inferred to be: integer

  value_idx = self._prep_dim_index(value.index, attr)
................. some code
---------------------------------------------------------------------------ZeroDivisionError                         Traceback (most recent call last)Input In [2], in <cell line: 1>()----> 1 test = sg.de_gene_test(obs_col, obs_conditions=obs_conditions)
..............some code
File ~/lzy/mambaforge/lib/python3.9/site-packages/dask/array/core.py:3142, in auto_chunks(chunks, shape, limit, dtype, previous_chunks)
   3138     raise ValueError(
   3139         "auto-chunking with dtype.itemsize == 0 is not supported, please pass in `chunks` explicitly"
   3140     )
   3141 print(limit , dtype.itemsize , largest_block)
-> 3142 size = (limit / dtype.itemsize / largest_block) ** (1 / len(autos))
   3143 small = [i for i in autos if shape[i] < size]
   3144 if small:
ZeroDivisionError: float division by zero

I find the semilariwarning in https://github.com/mortazavilab/swan_paper/blob/master/swan/swan_driver.ipynb, But the error is warning by what I got is stop. What should I do?
/Users/fairliereese/miniconda3/lib/python3.7/site-packages/dask/array/core.py:2622: RuntimeWarning: divide by zero encountered in true_divide
  size = (limit / dtype.itemsize / largest_block) ** (1 / len(autos))

Hi there,
Thanks for your interest in using Swan! The driver scripts you are referring to are not part of this repository and represent a version of Swan that is no longer operational. I recommend looking at the Swan documentation for current instructions on how to run it.


Installation does not work when following the documentation

Issue type
I'm submitting a ...  (check one with "x")

[x] bug report
[ ] feature request
[ ] question about the decisions made in the repository

Issue description
Installation does not work when steps from the documentation are followed. What could be the reason?
 See the compatibility table on MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#browser_compatibility
npm WARN deprecated<EMAIL_ADDRESS>See https://github.com/lydell/source-map-url#deprecated
npm WARN deprecated<EMAIL_ADDRESS>flatten is deprecated in favor of utility frameworks such as lodash.
npm WARN deprecated<EMAIL_ADDRESS>The package has been renamed to `open`
npm WARN deprecated<EMAIL_ADDRESS>Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated<EMAIL_ADDRESS>this library is no longer supported
npm WARN deprecated<EMAIL_ADDRESS>Browserslist 2 could fail on reading Browserslist >3.0 config used in other tools.
npm WARN deprecated<EMAIL_ADDRESS>Browserslist 2 could fail on reading Browserslist >3.0 config used in other tools.
npm WARN deprecated<EMAIL_ADDRESS>Chokidar 2 will break on node v14+. Upgrade to chokidar 3 with 15x less dependencies.
npm WARN deprecated<EMAIL_ADDRESS>See https://github.com/lydell/source-map-resolve#deprecated
npm WARN deprecated<EMAIL_ADDRESS>Chokidar 2 does not receive security updates since 2019. Upgrade to chokidar 3 with 15x fewer dependencies
npm WARN deprecated<EMAIL_ADDRESS>https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated<EMAIL_ADDRESS>CircularJSON is in maintenance only, flatted is its successor.
npm WARN deprecated<EMAIL_ADDRESS>gulp-util is deprecated - replace it, following the guidelines at https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5
npm WARN deprecated<EMAIL_ADDRESS>The querystring API is considered Legacy. new code should use the URLSearchParams API instead.
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated<EMAIL_ADDRESS>Use uuid module instead
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated<EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated<EMAIL_ADDRESS>Types for the Google Maps browser API have moved to @types/google.maps. Note: these types are not for the googlemaps npm package, which is a Node API.
npm WARN deprecated<EMAIL_ADDRESS>This version of tar is no longer supported, and will not receive security updates. Please upgrade asap.
npm WARN deprecated<EMAIL_ADDRESS>We have news to share - Protractor is deprecated and will reach end-of-life by Summer 2023. To learn more and find out about other options please refer to this post on the Angular blog. Thank you for using and contributing to Protractor. https://goo.gle/state-of-e2e-in-angular
npm WARN deprecated<EMAIL_ADDRESS>TSLint has been deprecated in favor of ESLint. Please see https://github.com/palantir/tslint/issues/4534 for more information.
npm WARN deprecated<EMAIL_ADDRESS><EMAIL_ADDRESS>is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Some versions have web compatibility issues. Please, upgrade your dependencies to the actual version of core-js.
npm WARN deprecated<EMAIL_ADDRESS><EMAIL_ADDRESS>is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Some versions have web compatibility issues. Please, upgrade your dependencies to the actual version of core-js.
npm WARN deprecated<EMAIL_ADDRESS>We have renamed the @ckeditor package. New versions are available under the @ckeditor4 name.
npm ERR! code 1
npm ERR! path C:\Users\rafal\Documents\admin-experiment\ngx-admin\node_modules\node-sass
npm ERR! command failed
npm ERR! command C:\WINDOWS\system32\cmd.exe /d /s /c node scripts/build.js
npm ERR! Building: C:\Program Files\nodejs\node.exe C:\Users\rafal\Documents\admin-experiment\ngx-admin\node_modules\node-gyp\bin\node-gyp.js rebuild --verbose --libsass_ext= --libsass_cflags= --libsass_ldflags= --libsass_library=
npm ERR! Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
npm ERR! Build started 31/08/2022 18:11:38.
npm ERR! Project "C:\Users\rafal\Documents\admin-experiment\ngx-admin\node_modules\node-sass\build\binding.sln" on node 1 (default targets).
npm ERR! ValidateSolutionConfiguration:
npm ERR!   Building solution configuration "Release|x64".
npm ERR! Project "C:\Users\rafal\Documents\admin-experiment\ngx-admin\node_modules\node-sass\build\binding.sln" (1) is building "C:\Users\rafal\Documents\admin-experiment\ngx-admin\node_modules\node-sass\build\binding.vcxproj.metaproj" (2) on node 1 (default targets).
npm ERR! Project "C:\Users\rafal\Documents\admin-experiment\ngx-admin\node_modules\node-sass\build\binding.vcxproj.metaproj" (2) is building "C:\Users\rafal\Documents\admin-experiment\ngx-admin\node_modules\node-sass\build\src\libsass.vcxproj" (3) on node 1 (default targets).
npm ERR! C:\Users\rafal\Documents\admin-experiment\ngx-admin\node_modules\node-sass\build\src\libsass.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.Cpp.Default.props" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on disk.
npm ERR! Done Building Project "C:\Users\rafal\Documents\admin-experiment\ngx-admin\node_modules\node-sass\build\src\libsass.vcxproj" (default targets) -- FAILED.
npm ERR! Done Building Project "C:\Users\rafal\Documents\admin-experiment\ngx-admin\node_modules\node-sass\build\binding.vcxproj.metaproj" (default targets) -- FAILED.
npm ERR! Done Building Project "C:\Users\rafal\Documents\admin-experiment\ngx-admin\node_modules\node-sass\build\binding.sln" (default targets) -- FAILED.
npm ERR!
npm ERR! Build FAILED.
npm ERR!
npm ERR! "C:\Users\rafal\Documents\admin-experiment\ngx-admin\node_modules\node-sass\build\binding.sln" (default target) (1) ->
npm ERR! "C:\Users\rafal\Documents\admin-experiment\ngx-admin\node_modules\node-sass\build\binding.vcxproj.metaproj" (default target) (2) ->
npm ERR! "C:\Users\rafal\Documents\admin-experiment\ngx-admin\node_modules\node-sass\build\src\libsass.vcxproj" (default target) (3) ->
npm ERR!   C:\Users\rafal\Documents\admin-experiment\ngx-admin\node_modules\node-sass\build\src\libsass.vcxproj(21,3): error MSB4019: The imported project "C:\Microsoft.Cpp.Default.props" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on disk.
npm ERR!
npm ERR!     0 Warning(s)
npm ERR!     1 Error(s)
npm ERR!
npm ERR! Time Elapsed 00:00:00.19
npm ERR! gyp info it worked if it ends with ok
npm ERR! gyp verb cli [
npm ERR! gyp verb cli   'C:\\Program Files\\nodejs\\node.exe',
npm ERR! gyp verb cli   'C:\\Users\\rafal\\Documents\\admin-experiment\\ngx-admin\\node_modules\\node-gyp\\bin\\node-gyp.js',
npm ERR! gyp verb cli   'rebuild',
npm ERR! gyp verb cli   '--verbose',
npm ERR! gyp verb cli   '--libsass_ext=',
npm ERR! gyp verb cli   '--libsass_cflags=',
npm ERR! gyp verb cli   '--libsass_ldflags=',
npm ERR! gyp verb cli   '--libsass_library='
npm ERR! gyp verb cli ]
npm ERR! gyp info using<EMAIL_ADDRESS>npm ERR! gyp info using<EMAIL_ADDRESS>| win32 | x64
npm ERR! gyp verb command rebuild []
npm ERR! gyp verb command clean []
npm ERR! gyp verb clean removing "build" directory
npm ERR! gyp verb command configure []
npm ERR! gyp verb check python checking for Python executable "C:Python27python.exe" in the PATH
npm ERR! gyp verb `which` failed Error: not found: C:Python27python.exe
npm ERR! gyp verb `which` failed     at getNotFoundError (C:\Users\rafal\Documents\admin-experiment\ngx-admin\node_modules\which\which.js:13:12)
npm ERR! gyp verb `which` failed     at F (C:\Users\rafal\Documents\admin-experiment\ngx-admin\node_modules\which\which.js:68:19)
npm ERR! gyp verb `which` failed     at E (C:\Users\rafal\Documents\admin-experiment\ngx-admin\node_modules\which\which.js:80:29)
npm ERR! gyp verb `which` failed     at C:\Users\rafal\Documents\admin-experiment\ngx-admin\node_modules\which\which.js:89:16
npm ERR! gyp verb `which` failed     at C:\Users\rafal\Documents\admin-experiment\ngx-admin\node_modules\isexe\index.js:42:5
npm ERR! gyp verb `which` failed     at C:\Users\rafal\Documents\admin-experiment\ngx-admin\node_modules\isexe\windows.js:36:5
npm ERR! gyp verb `which` failed     at FSReqCallback.oncomplete (node:fs:198:21)
npm ERR! gyp verb `which` failed  C:Python27python.exe Error: not found: C:Python27python.exe
npm ERR! gyp verb `which` failed     at getNotFoundError (C:\Users\rafal\Documents\admin-experiment\ngx-admin\node_modules\which\which.js:13:12)
npm ERR! gyp verb `which` failed     at F (C:\Users\rafal\Documents\admin-experiment\ngx-admin\node_modules\which\which.js:68:19)
npm ERR! gyp verb `which` failed     at E (C:\Users\rafal\Documents\admin-experiment\ngx-admin\node_modules\which\which.js:80:29)
npm ERR! gyp verb `which` failed     at C:\Users\rafal\Documents\admin-experiment\ngx-admin\node_modules\which\which.js:89:16
npm ERR! gyp verb `which` failed     at C:\Users\rafal\Documents\admin-experiment\ngx-admin\node_modules\isexe\index.js:42:5
npm ERR! gyp verb `which` failed     at C:\Users\rafal\Documents\admin-experiment\ngx-admin\node_modules\isexe\windows.js:36:5
npm ERR! gyp verb `which` failed     at FSReqCallback.oncomplete (node:fs:198:21) {
npm ERR! gyp verb `which` failed   code: 'ENOENT'
npm ERR! gyp verb `which` failed }
npm ERR! gyp verb could not find "C:Python27python.exe". checking python launcher
npm ERR! gyp verb check python launcher python executable found: "C:\\Python27\\python.exe"
npm ERR! gyp verb check python version `C:\Python27\python.exe -c "import sys; print "2.7.10
npm ERR! gyp verb check python version .%s.%s" % sys.version_info[:3];"` returned: %j
npm ERR! gyp verb get node dir no --target version specified, falling back to host node version: 16.13.2
npm ERR! gyp verb command install [ '16.13.2' ]
npm ERR! gyp verb install input version string "16.13.2"
npm ERR! gyp verb install installing version: 16.13.2
npm ERR! gyp verb install --ensure was passed, so won't reinstall if already installed
npm ERR! gyp verb install version is already installed, need to check "installVersion"
npm ERR! gyp verb got "installVersion" 9
npm ERR! gyp verb needs "installVersion" 9
npm ERR! gyp verb install version is good
npm ERR! gyp verb get node dir target node version installed: 16.13.2
npm ERR! gyp verb build dir attempting to create "build" dir: C:\Users\rafal\Documents\admin-experiment\ngx-admin\node_modules\node-sass\build
npm ERR! gyp verb build dir "build" dir needed to be created? C:\Users\rafal\Documents\admin-experiment\ngx-admin\node_modules\node-sass\build
npm ERR! gyp verb find vs2017 Found installation at: C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools
npm ERR! gyp verb find vs2017   - Found Microsoft.VisualStudio.Component.Windows10SDK.19041
npm ERR! gyp verb find vs2017   - Found Microsoft.VisualStudio.Component.VC.Tools.x86.x64
npm ERR! gyp verb find vs2017   - Found Microsoft.VisualStudio.VC.MSBuild.Base
npm ERR! gyp verb find vs2017   - Using this installation with Windows 10 SDK
npm ERR! gyp verb find vs2017 using installation: C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools
npm ERR! gyp verb build/config.gypi creating config file
npm ERR! gyp verb build/config.gypi writing out config file: C:\Users\rafal\Documents\admin-experiment\ngx-admin\node_modules\node-sass\build\config.gypi
npm ERR! (node:9040) [DEP0150] DeprecationWarning: Setting process.config is deprecated. In the future the property will be read-only.
npm ERR!  System Windows_NT 10.0.19044
npm ERR! gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\Users\\rafal\\Documents\\admin-experiment\\ngx-admin\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild" "--verbose" "--libsass_ext=" "--libsass_cflags=" "--libsass_ldflags=" "--libsass_library="
npm ERR! gyp ERR! cwd C:\Users\rafal\Documents\admin-experiment\ngx-admin\node_modules\node-sass
npm ERR! gyp ERR! node -v v16.13.2
npm ERR! gyp ERR! node-gyp -v v3.8.0
npm ERR! gyp ERR! not ok
npm ERR! Build failed with error code: 1

Use the node version 14.15.0 to resolve this issue

Thanks for the hint. In the meantime I switched to another angular admin template, so can't really say if the fix works.

so can't really say if the fix works.

@r3econ, You have to switch the node version too when switching to different project. You can use NVM or NVS to do that

Hello, I cannot use node 14, i have to use node 18, because i use other modules too that depend on node 18

Hello, I cannot use node 14, i have to use node 18, because i use other modules too that depend on node 18

Hi @andreidiaconescu , You can use node 18 by installing the npm version 6 or lesser than 6. Just install the npm by npm i -g npm@6

Hello, I cannot use node 14, i have to use node 18, because i use other modules too that depend on node 18

Use nvm to switch node versions.