[SPARK-36338][PYTHON][SQL] Move distributed-sequence implementation to Scala side

What changes were proposed in this pull request?
This PR proposes to implement distributed-sequence index in Scala side.
Why are the changes needed?

Avoid unnecessary (de)serialization
Keep the nullability in the input DataFrame when distributed-sequence is enabled. During the serialization, all fields are being nullable for now (see https://github.com/apache/spark/pull/32775#discussion_r645882104)

Does this PR introduce any user-facing change?
No to end users since pandas API on Spark is not released yet.
import pyspark.pandas as ps
ps.set_option('compute.default_index_type', 'distributed-sequence')
ps.range(1).spark.print_schema()

Before:
root
 |-- id: long (nullable = false)

After:
root
 |-- id: long (nullable = true)

How was this patch tested?
Manually tested, and existing tests should cover them.

Test build #141810 has started for PR 33570 at commit 5294a44.

Test build #141814 has started for PR 33570 at commit d616b55.

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46323/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46323/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46327/

Test build #141821 has started for PR 33570 at commit b3bdd87.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46327/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46327/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46334/

Test build #141830 has started for PR 33570 at commit e4aca28.

Test build #141810 has finished for PR 33570 at commit 5294a44.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

retest this please

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46334/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46334/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141810/

Test build #141836 has started for PR 33570 at commit 3f7609b.

Test build #141814 has finished for PR 33570 at commit d616b55.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141814/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46343/

Test build #141821 has finished for PR 33570 at commit b3bdd87.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141821/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46343/

retest this please

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46343/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46350/

Test build #141843 has started for PR 33570 at commit 3f7609b.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46350/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46350/

Test build #141830 has finished for PR 33570 at commit e4aca28.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46358/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141830/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46358/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46358/

Test build #141836 has finished for PR 33570 at commit 3f7609b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141836/

Test build #141843 has finished for PR 33570 at commit 3f7609b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141843/

LGTM! Thanks for the change.
When distributed-sequence is enabled, should all fields be NOT nullable for now? If so, the PR description "Why are the changes needed?" can be changed.

Test build #141860 has started for PR 33570 at commit 977cdb4.

Test build #141862 has started for PR 33570 at commit e41e6ad.

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46371/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46373/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46371/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46373/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46373/

Test build #141874 has started for PR 33570 at commit 3c5878d.

Test build #141860 has finished for PR 33570 at commit 977cdb4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #141862 has finished for PR 33570 at commit e41e6ad.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46383/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141862/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141860/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46383/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46383/

Test build #141874 has finished for PR 33570 at commit 3c5878d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141874/

Test build #141890 has started for PR 33570 at commit 4a2495d.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46399/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46399/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46399/

Test build #141901 has started for PR 33570 at commit ba7beca.

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46410/

All tests passed.
Merged to master and branch-3.2.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46410/

Test build #141890 has finished for PR 33570 at commit 4a2495d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141890/

Test build #141901 has finished for PR 33570 at commit ba7beca.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141901/


Support for title property in images

Is it possible to add title property in images?
Eg:
<mj-image src="img/A.jpg" width="325" height="359" alt="A" title="A" padding="0"></mj-image>

I'm just curious, why you want to add title to the image?

Hello @NetoBraghetto ,
Can you provide some use case on it, and some render example ? thanks

Closing it, feel free to reopen with more details on it

Title adds a tooltip on images when you hover on them and sometimes are used in screen readers.

Re-openning !

Images should have alt attribute for screen reader, not title I think. I'm sure if title is used by any screen reader.

Yes some screen readers use alt while others use title. html4 spec actually references audio and non-visual useragents use it.

title is now supported on 2.3 !


Positive vs Negative Liberty Clarifications in Title I

Specify how the government must respect the fundamental freedoms set out in Articles I, II and III (specifying that no government body or actor may pass laws that run counter to these freedoms).

@Mathew-Iron Also, in the future for larger changes I feel it would be nice to leave the pull request open for a while, and ask for feedback from the community, to make sure it's not just the immediate contributors that are approving each other's pull requests, and the process is more collaborative.


Multiple line editing is slow/laggy

Describe the bug
When you edit multiple lines by entering visual mode and then entering insert mode with Shift + i
the editing is rather slow. It takes like a second for the changes to occur. Can this be improved?
It was fixed in Neovim. Was hoping that it can be fixed here too.
To Reproduce
Detailed steps to reproduce the behavior:

Enter visual mode
Select multiple lines
Press Shift+i to enter insert mode
Edit the lines and press Esc

Expected behavior
Editits should be applied in an instant
Environment (please complete the following information):

Vim version: 8.2
OS: Manjaro
Terminal: Konsole

did you try using vim --clean?

You mean start with empty vimrc? I don’t think that plugins are the problem, but will try later.

I don’t think that plugins are the problem

We can't be sure of that until you provide a minimal working example.  See here for how to get one.  Note that what is written there is not limited to the vimrc; you can use the same kind of technique to third-party plugins.  But the bigger and more complex a plugin is, the more time-consuming the task is.

Okay, yes it is gone when I use vim --clean. But then I am wondering why the same problem doesn't happen in neovim. I think there is still room for improvement, but I guess as long as it doesn't happen in standard Vim, no one will bother improving it.

I guess as long as it doesn't happen in standard clean Vim, no one will bother improving it.

About a year ago, I found an issue where Vim was lagging while cycling through the entries inside the pum.  Here's the minimal working example I posted:
vim -Nu NONE +'setl cul' +'set ft=vim|syn enable|/readline#yank' +'setl noro|pu=\"th\"|startinsert!' <(curl -s https://raw.githubusercontent.com/lacygoill/vim-readline/master/autoload/readline.vim)

Notice the part after vim -Nu NONE:
+'setl cul' +'set ft=vim|syn enable|/readline#yank' +'setl noro|pu=\"th\"|startinsert!' <(curl -s https://raw.githubusercontent.com/lacygoill/vim-readline/master/autoload/readline.vim)

All of that is not in "standard clean Vim".  The issue was fixed a week later.

@lacygoill I'd rather live with the bug than prepare such an extensive example. There is also no need for an example. You just need to insert a few lines and try to edit them. It would probably be more important to find out what plugin is causing it.

well, try to reproduce to a minimal test case. This may be helpful: https://vimhelp.org/vim_faq.txt.html#faq-2.5

The error still exists when I use vim -u NONE -U NONE -N -i NONE, but not when I move my .vimrc
@chrisbra I don't understand what you mean by minimal test case

I'd rather live with the bug than prepare such an extensive example.

My point was that your guess:

I guess as long as it doesn't happen in standard clean Vim, no one will bother improving it.

was wrong.  What you can live with is irrelevant.

vim -u NONE -U NONE -N -i NONE if that is true, then it should also occur with vim --clean.

I don't understand what you mean by minimal test case

Well, it may depend on settings, indent plugins, syntax plugins, global plugins, so it would be good to have a reproducible example with minimal options that matter and that can be run from the command line. BTW: You haven't yet specified what version you are running. Please output the complete :version output (and perhaps try with the latest master build in case you do not use it).

@chrisbra No, the issue does occur with vim -u NONE -U NONE -N -i NONEand does not with vim --clean.
So you mean provide a vimrc that would be causing it? That would take me some time I guess.
VIM - Vi IMproved 8.2 (2019 Dec 12, compiled Mar 26 2021 00:21:09)
Included patches: 1-2653
Compiled by Arch Linux
Huge version without GUI.   When I delete the vimrc though, it is gone...

No, the issue does occur with vim -u NONE -U NONE -N -i NONEand does not with vim --clean.

Hm, then it might be either defaults.vim or any of the ftplugin.vim filetype.vim or any of the default syntax plugins. Perhaps it's ttimeout or ttimeoutlen option?

Hm, then it might be either defaults.vim or any of the ftplugin.vim filetype.vim or any of the default syntax plugins. Perhaps it's ttimeout or ttimeoutlen option?

If that's the case, then the OP should try this:
:set timeout timeoutlen=3000 ttimeoutlen=100

Relevant help tag: :h 'ttimeoutlen'.

@chrisbra Nailed it! When I set ttimeoutlen=0the issue is gone. Thank you :) I will see if this will cause problems with my key combinations but I don't think so.


Add missing comma in bower file

As noted in #1

Additionally, the css path in the bower main property was wrong. Fixed in this PR.


Unused variables

https://github.com/facebook/Recipes-for-AutoPkg/blob/ef5dee35c65daf15070acd3dd37230f006f9babb/Xcode/XcodeVersioner.py#L66
Variables declared but not used, or reassigned before they are used, can be the result of programmer negligence, which often means that there is a bug in the program.

The variable itself is unused and should be marked with an underscore to indicate that, but the action of loading the bundle is necessary to allow access to the frameworks.


Minitest support

require 'capybara-inline-screenshot/minitest'

class SystemTest < Minitest::Test
  include CapybaraInlineScreenshot::Minitest
end

Thanks so much! :)

I've updated the Readme.md — do those instructions look good to you?

👍

Thanks, v2.1.0 has been pushed

Thanks @toolmantim 😁

Thank you, I just did the easy stuff :dancers:


Load management problem in "Sofort" mode

Hi,
can anybody help me how can I configure my setup in evcc?
My goal is to set evcc to manage my charge current according to the actual house consumption and maximum currents limit (per phase), but evcc sets evse-wifi to 6A regardless of the actual grid perimeters.
my setup:
grid meter SDM630 via mqtt
3 phase max 20A each
PV but without meter, connected to one phase.
evse wifi without meter, evse set to remote mode, api enabled.
renault zoe soc via mqtt
and I'm using home assistant
currents and total power is configured, at least log says so.
Using config file:  /config/evcc.yaml
starting evcc: 'evcc --config  /config/evcc.yaml'
[main  ] INFO 2020/11/30 11:20:06 evcc 0.33 (8ddfaa9)
[main  ] INFO 2020/11/30 11:20:06 using config file /config/evcc.yaml
[main  ] INFO 2020/11/30 11:20:06 listening at <IP_ADDRESS>:7070
[mqtt  ] INFO 2020/11/30 11:20:06 connecting evcc-174035675 at <IP_ADDRESS>:1883
[mqtt  ] DEBUG 2020/11/30 11:20:06 <IP_ADDRESS>:1883 connected
[site  ] INFO 2020/11/30 11:20:07 site config:
[site  ] INFO 2020/11/30 11:20:07   meters:    grid ✓ pv — battery —
[site  ] INFO 2020/11/30 11:20:07     grid:    power ✓ energy — currents ✓
[lp-1  ] INFO 2020/11/30 11:20:07 loadpoint 1:
[lp-1  ] INFO 2020/11/30 11:20:07   mode:
[lp-1  ] INFO 2020/11/30 11:20:07   charger:   power — energy — currents — timer ✓
[lp-1  ] INFO 2020/11/30 11:20:07   meters:    charge —
[lp-1  ] INFO 2020/11/30 11:20:07   vehicles:  ✓
[lp-1  ] INFO 2020/11/30 11:20:07     car 0:   estimate — status — climate —
[site  ] DEBUG 2020/11/30 11:20:07 ----
[site  ] DEBUG 2020/11/30 11:20:07 grid power: -1288W
[site  ] DEBUG 2020/11/30 11:20:07 site power: -1288W
[lp-1  ] DEBUG 2020/11/30 11:20:07 charge power: 0W
[lp-1  ] DEBUG 2020/11/30 11:20:07 charger status: B
[lp-1  ] DEBUG 2020/11/30 11:20:07 vehicle soc: 45%
[site  ] DEBUG 2020/11/30 11:20:17 ----
grid/site power is minus because of PV.
mincurrent and maxcurrent is set to 6A and 18A in config at loadponts section.
Starting the charge in mode in "sofort" EVCC sets the evse wifi to 6A.
[site  ] DEBUG 2020/11/30 11:20:47 grid power: -1310W
[site  ] DEBUG 2020/11/30 11:20:47 site power: -1310W
[lp-1  ] DEBUG 2020/11/30 11:20:47 charge power: 0W
[lp-1  ] DEBUG 2020/11/30 11:20:47 charger status: C
[lp-1  ] INFO 2020/11/30 11:20:47 start charging ->
[lp-1  ] DEBUG 2020/11/30 11:20:47 vehicle soc: 45%
[site  ] DEBUG 2020/11/30 11:20:57 ----
[site  ] DEBUG 2020/11/30 11:20:57 grid power: -1301W
[site  ] DEBUG 2020/11/30 11:20:57 site power: -1301W
[lp-1  ] DEBUG 2020/11/30 11:20:57 charge power: 12420W
[lp-1  ] DEBUG 2020/11/30 11:20:57 charger status: C
[lp-1  ] DEBUG 2020/11/30 11:20:57 vehicle soc: 45%
Why it is not set to 18A, since current limit of the grid/site allows it?
Charge power shows that it tried to set it to 18A (18A230V3Ph=12420W) but I've checked on evse wifi GUI , the register 1000 (Configured Current) and 1001 (Actual Current) was set to 6A.
using http getParameters at evsewifi returns 6A for actualCurrent, so it seems evcc not using it when calculating the charge power.
After updating the modbus register manually to 18A the grid power shows, that now it is ok. (maybe the battery is too cold, so the car capped it to 12A) 12A3Ph230V-PV=6299W
Charge power still shows 12420W in log.
[site  ] DEBUG 2020/11/30 11:40:37 grid power: 6299W
[site  ] DEBUG 2020/11/30 11:40:37 site power: 6299W
[lp-1  ] DEBUG 2020/11/30 11:40:37 charge power: 12420W
[lp-1  ] DEBUG 2020/11/30 11:40:37 charger status: C
[lp-1  ] DEBUG 2020/11/30 11:40:37 vehicle soc: 52%
So what I've missed during the config? any help is appreciated, thanks a lot
ps: Is it possible to get other values via mqtt for the vehicle? charge option for soc is ok, but range, remaining time, charging power is also available per renault-api, but the renault server is very rigorous in query quota, so I would like to collect only via home assistant and publish it to mqtt for the other apps (so for evcc too).
my evcc config yaml
"
interval: 10s
log: debug
levels:
core: debug
lp-1: debug
meters:

name: sdm630
type: default
power:
type: mqtt
topic: openWB/evu/W
timeout: 10s
currents:

type: mqtt
topic: openWB/evu/APhase1
timeout: 10s
type: mqtt
topic: openWB/evu/APhase2
timeout: 10s
type: mqtt
topic: openWB/evu/APhase3
timeout: 10s

chargers:

name: evsewifi
type: evsewifi
uri: http://<IP_ADDRESS>

vehicles:

name: renault
title: Zoe
capacity: 40 # kWh
type: default
charge:
type: mqtt
topic: homeassistant/renault/soc
cache: 5m

site:
title: Home
voltage: 230
meters:
grid: sdm630
prioritySoC: 0
loadpoints:

title: Garage
charger: evsewifi
vehicle: renault
mode: off
soc:
min: 0
target: 90
alwaysUpdate: false
estimate: false
levels:

30
50
80
100
onDisconnect:
mode: off
targetSoC: 100
phases: 3
enable:
delay: 1m
threshold: 0
disable:
delay: 5m
threshold: 200
guardduration: 10m
mincurrent: 8
maxcurrent: 18

mqtt:
broker: <IP_ADDRESS>:1883
"

Please use the formatting from the issue template.


Include app user display name in CSV export

A post in the Forum mentions that the app user display name appears in the Frontend submissions table but not the exported CSV file. @clint-tseng, what do you think about adding this to the CSV file? I could see how it could be useful to have that data in the CSV.
Also, I know we include the app user display name in the OData under the __system property, but I was wondering whether you would consider that part of the official Central API.

@matthew-white @ggalmazor does Aggregate do something like this? is there something else Aggregate does that's similar that we can copy.

I'm pretty sure that Briefcase doesn't include this information upon export. I'm not sure about Aggregate...

okay. i'll try to do something vaguely intelligent, then. thanks!

the talk about people depending on briefcase output makes me wary of adding a column that isn't there in briefcase..

maybe i'll add it at the very very end

@yanokwa i implemented this but want a gut check on deviating from briefcase (given i just tried so hard to exactly match it)


Support for Defiant Wi-Fi Deadbolt?

I'm somewhat API handy, so I may try to dive into this myself, but support for the Defiant Wi-Fi Deadbolt would be great!  I'm not sure how it looks on the backend, but I know it uses a Defiant Smart Plug (which this supports) as a bridge.

I would love to see this added as well!


Don't skip TLS marker on protocol string error.

Fix protocol stack to return unknown TLS string instead of eliding it in case of error. It is better to have a bogus tag in the protocol stack than to elide the fact that the connection negotiated TLS.

@SolidWallOfCode Is the Via header being built even though we don't have the feature enabled?  I was talking to @zwoop about.

It's more that it populate the entire protocol stack regardless if the Via setting is 2, 3 or 4 (I think at least). I don't see how we'd crash here otherwise :).

The protocol stack is used to compute the short form as well. In this particular case the decision of 'http' vs 'https' is determined by whether TLS is in the protocol stack. The stack construction should be very cheap - it's essential a stack allocated array of pointer/length pairs and building the stack involves assigning constexpr pointer/length pairs to the array. I don't think it's worth special casing it to optimize - it's additional complexity for very little computational gain. In any event, that's outside the scope of this issue which fixes building the stack without regard to why it's being built.

Also, this doesn't fix a crash, it's purely a correctness fix. #2213 fixes the crash for 7.1.1.

it doesn't looks cheap.  We are doing a strncasecmp() on the passed in proto_string even if we don't use it.

This method shouldn't be called if we don't use the information.  I ran gdb to confirm we are calling SSLNetVConnection::populate_protocol even though it is not used:
(gdb) bt
#0  SSLNetVConnection::populate_protocol (this=0x7fff9401bca0, results=0x7ffff244e660, n=8) at SSLNetVConnection.cc:1585
#1  0x00000000005ef447 in ProxyClientSession::populate_protocol (size=<optimized out>, result=<optimized out>, this=<optimized out>) at /home/bcall/dev/apache/trafficserver/proxy/ProxyClientSession.h:195
#2  Http2ClientSession::populate_protocol (this=<optimized out>, result=<optimized out>, size=<optimized out>) at Http2ClientSession.h:269
#3  0x0000000000581187 in ProxyClientTransaction::populate_protocol (size=9, result=0x7ffff244e650, this=<optimized out>) at ../ProxyClientTransaction.h:245
#4  HttpSM::populate_client_protocol (this=<optimized out>, result=result@entry=0x7ffff244e640, n=n@entry=10) at HttpSM.cc:7964
#5  0x00000000005c6c78 in HttpTransactHeaders::insert_via_header_in_request (s=s@entry=0x7fff9b000ed0, header=header@entry=0x7fff9b0015d8) at HttpTransactHeaders.cc:793
#6  0x00000000005a8413 in HttpTransact::build_request (s=s@entry=0x7fff9b000ed0, base_request=base_request@entry=0x7fff9b001558, outgoing_request=outgoing_request@entry=0x7fff9b0015d8, outgoing_version=...) at HttpTransact.cc:7628
#7  0x00000000005acd1b in HttpTransact::HandleCacheOpenReadMiss (s=0x7fff9b000ed0) at HttpTransact.cc:3124
#8  0x000000000057ce76 in HttpSM::call_transact_and_set_next_state (this=this@entry=0x7fff9b000e60, f=f@entry=0x0) at HttpSM.cc:7087

Via header sent to origin:
Via: https/2 homer.bryancall.com[1e195ed4-7be1-4ac2-9bda-6ff52f5cf227] (ApacheTrafficServer/8.0.0)
and there is no Via sent back to the client.

Yeh, it would seem reasonable to avoid this for the cases where the information isn't used. This is a pattern we follow in several places; avoid generating data if it's not going to be used. Things does add up! :-).

Via: https/2 homer.bryancall.com[1e195ed4-7be1-4ac2-9bda-6ff52f5cf227] (ApacheTrafficServer/8.0.0)"
     ^^^^^^^

That is computed from the protocol stack.

It shouldn't populate an array of StringViews and a do string compare on the protocol if it is only going to display "https" in the via header.  Also, it doesn't need to be a case insensitive compare:
https://github.com/openssl/openssl/blob/23cec1f4b4801c643853bf2eb07d7eae5f4fe7cb/ssl/ssl_lib.c#L3261

"It shouldn't populate an array of StringViews and a do string compare on the protocol if it is only going to display "https" in the via header" - I'm unclear on how code changes in SSLNetVConnection.cc can make a difference in that regard.
I wasn't aware that the SSL protocol strings were fixed addresses, I'll take a look at that.

A couple of minor cleanups I missed, I'm waiting for the CI to finish to make the fixes. None of them are functional, just removing used variables and better comments.

[approve ci autest]

The Via code is trying to be too fancy and generic:

We know what we are going to write into the Via header, no need to populate an array with tcp and ipv4, when we don't look at it.
We don't need to do multiple linear searches through the entire stack.  We know what the protocol stack looks like and the different combinations.
We know that h2 requires TLS and that h2 is > 50% of our traffic.  We should use this knowledge to make the code faster.

I am OK with this PR, but I think the entire Via code is overly complex, slow, and too generic.

[approve ci autest]


lief: 0.12.1 -> 0.12.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/lief-project/LIEF/releases.
meta.description for lief is: "Library to Instrument Executable Formats"
meta.homepage for lief is: "https://lief.quarkslab.com/"
meta.changelog for lief is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.12.3 with grep in /nix/store/6daj77d4bcy2zialrih7ss3d5kmjqj6z-lief-0.12.3
found 0.12.3 in filename of file in /nix/store/6daj77d4bcy2zialrih7ss3d5kmjqj6z-lief-0.12.3

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath
lief
python310Packages.lief
python39Packages.lief

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/6daj77d4bcy2zialrih7ss3d5kmjqj6z-lief-0.12.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A lief https://github.com/r-ryantm/nixpkgs/archive/515cb550d773c40a2716ba9dc7f6a1166d92f127.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/6daj77d4bcy2zialrih7ss3d5kmjqj6z-lief-0.12.3
ls -la /nix/store/6daj77d4bcy2zialrih7ss3d5kmjqj6z-lief-0.12.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

3 packages built:

lief
python310Packages.lief
python39Packages.lief

Maintainer pings
cc @Lassulus for testing.

Flagging as security since it fixes at least the following issues (see https://github.com/NixOS/nixpkgs/pull/191863#issue-1377240680):
https://nvd.nist.gov/vuln/detail/CVE-2022-38497
https://nvd.nist.gov/vuln/detail/CVE-2022-38496
https://nvd.nist.gov/vuln/detail/CVE-2022-38495
https://nvd.nist.gov/vuln/detail/CVE-2022-38307
https://nvd.nist.gov/vuln/detail/CVE-2022-38306


Per position color for polyline entities

I would like to make a gradient, but in an entity form (PolylineGraphics?). I currently destroy and recreate the primitive each time the positions update (code below).
Will I basically have to copy PolylineGraphics? Or would it be better to extend it instead?
I have async off because this line connects two objects that are moving, so it is constantly updating. Having async on makes the line disappear during animation.
Any pointers will help! 😄
function createGradientPrimitive(positions, color1, color2) {
    var gradientColors = [];
    for (var i = 0; i < positions.length; i++) {
        var percent = i/(positions.length - 1);
        var red = color1.red + percent * (color2.red - color1.red);
        var green = color1.green + percent * (color2.green - color1.green);
        var blue = color1.blue + percent * (color2.blue - color1.blue);
        var alpha = color1.alpha + percent * (color2.alpha - color1.alpha);
        gradientColors.push(new Cesium.Color(red, green, blue, alpha));
    }

    return new Cesium.Primitive({
        asynchronous: false,
        geometryInstances: new Cesium.GeometryInstance({
            geometry: new Cesium.PolylineGeometry({
                positions: positions,
                width: 20,
                vertexFormat: Cesium.PolylineColorAppearance.VERTEX_FORMAT,
                colors: gradientColors,
                colorsPerVertex: true
            })
        }),
        appearance: new Cesium.PolylineColorAppearance({
            translucent: true
        })
    });
}

Hello @thinkpadder1
For adding support for per position color to polyline entities, I think you'll need to make changes to PolylineGraphics and PoylineGeometryUpdater.  @mramato is there anything I'm missing?
If you get a chance to implement this, we would appreciate the contribution back!  I think a lot of people would like to see this feature.  Thanks!

This feature would need more significant changes. Polyline entities can use either PolylineGeomrty or a PolylineCollection to render the line depending on whether it is static or dynamic and PolylineCollection does not yet support per-vertex colors.

Oh, I didn't realize that.  Thanks @bagnell!

Also requested in #7569


docs: create example paired shortcode

What I did

Timestamp docs necessitated that the example shortcode not only work images, but live elements as well. I'm converting the example shortcode into a paired shortcode as a result.

Testing Instructions

Verify that existing shortcode usage wasn't impacted by the conversion

@bennypowers Definitely! I can go the route of just adding divs with classes. I just wanted to take advantage of the shortcode since the styling was the same. Corey wanted a live examples of timestamp with the lightest, darkest, and wrong styles), but your suggestion works too.

Reverting changes in timestamp PR and creating div with styles instead.


Self-hosted JS snippet has no port 8000 in URL

I believe the javascript snippet we get to paste before  is wrong. Currently, it is this
<script defer data-domain="localhost" src="http://localhost/js/script.js"></script>

but script.js does not exist at that location, since Plausible will run on port 8000 by default.
(A spinoff of https://github.com/plausible/docs/issues/331)

@TheCrowned 👋
What do you think should be shown instead?

The problem seems to come from BASE_URL being used both to configure the port to run and for URL generation in the app. We can potentially separate them into PORT and HOST while keeping BASE_URL for backwards compatibility with PORT and HOST taking precedence.


Koel cant play some songs

Hi
Sometimes Koel is not able to play some songs, I have no idea why naturally but I hit another one just a min ago and I was  able to get the ffprobe, hopefully this will give the devs some idea about it might fail.
Koel normally plays songs but some of them just do not produce any sound.
thanks

ffprobe version 3.3.4 Copyright (c) 2007-2017 the FFmpeg developers
  built with gcc 7 (Debian 7.2.0-4)
  configuration: --disable-decoder=amrnb --disable-decoder=libopenjpeg --disable-mips32r2 --disable-mips32r6 --disable-mips64r6 --disable-mipsdsp --disable-mipsdspr2 --disable-mipsfpu --disable-msa --disable-libopencv --disable-podpages --disable-stripping --enable-avfilter --enable-avresample --enable-gcrypt --enable-gnutls --enable-gpl --enable-libass --enable-libbluray --enable-libbs2b --enable-libcaca --enable-libcdio --enable-libfdk-aac --enable-libfontconfig --enable-libfreetype --enable-libfribidi --enable-libgme --enable-libgsm --enable-libilbc --enable-libkvazaar --enable-libmp3lame --enable-libopencore-amrnb --enable-libopencore-amrwb --enable-libopenh264 --enable-libopenjpeg --enable-libopenmpt --enable-libopus --enable-libpulse --enable-librubberband --enable-libshine --enable-libsnappy --enable-libsoxr --enable-libspeex --enable-libtesseract --enable-libtheora --enable-libvidstab --enable-libvo-amrwbenc --enable-libvorbis --enable-libvpx --enable-libx265 --enable-libxvid --enable-libzvbi --enable-nonfree --enable-opengl --enable-openssl --enable-postproc --enable-pthreads --enable-shared --enable-version3 --enable-libwebp --incdir=/usr/include/x86_64-linux-gnu --libdir=/usr/lib/x86_64-linux-gnu --prefix=/usr --toolchain=hardened --enable-frei0r --enable-chromaprint --enable-libx264 --enable-libiec61883 --enable-libdc1394 --enable-vaapi --disable-opencl --enable-libmfx --disable-altivec --shlibdir=/usr/lib/x86_64-linux-gnu
  libavutil      55. 58.100 / 55. 58.100
  libavcodec     57. 89.100 / 57. 89.100
  libavformat    57. 71.100 / 57. 71.100
  libavdevice    57.  6.100 / 57.  6.100
  libavfilter     6. 82.100 /  6. 82.100
  libavresample   3.  5.  0 /  3.  5.  0
  libswscale      4.  6.100 /  4.  6.100
  libswresample   2.  7.100 /  2.  7.100
  libpostproc    54.  5.100 / 54.  5.100
Input #0, mp3, from '17 - Josef Anton Riedl - Leonce und Lena (1963) - Nr.4,1.MP3':
  Metadata:
    title           : Leonce und Lena (1963) - Nr.4,1
    artist          : Josef Anton Riedl
    album           : Unknown Title
    track           : 17
    comment         : Track 17
    encoded_by      : Exact Audio Copy   (Secure mode)
  Duration: 00:02:15.86, start: 0.025057, bitrate: 193 kb/s
    Stream #0:0: Audio: mp3, 44100 Hz, stereo, s16p, 192 kb/s
    Metadata:
      encoder         : LAME3.93

Is it koel or your browser that's not playing the song (is the UI making progress while playing) ?
Did you try to download the song and play it with your browser ? Does it work ?

@X-Ryl669
I am not sure if it is my browser or not, my Emby server never did that to me. I will try with Emby to see if it has the same issue with the same song.
I also see that playing some songs never fire ffmpeg ( I watched the running tasks) which I suspect it could be the main issue. Because some songs actually piped through ffmpeg as I watched the task manager. However I am not a dev so it is hard to debug this.
I will also try downloading.

@X-Ryl669
I was able to download the songs that Koel did not play. Also Koel seems to refure to play them right away and move to next song. And like I saif fffmpeg was never fired for these songs on the server side.
I believe I have that xsend file setup and ffmpeg in place( I can see it becomes active  with the songs played)
Here are some songs that did not play, I downloaded them over Koel. I think these are the original files not transcoded.
I am using Debian Testing Nodev6.11.4 Apache/2.4.27 (Debian)  mariadb  Ver 15.1 Distrib 10.1.26-MariaDB,
Please feel free to test them
http://www.filedropper.com/koel-download-59e17194e9337
thanks

If the source is a MP3, then there's no reason to transcode. Thus, you should not have ffmpeg process if your collection is mp3 only (and likely also flac recently). When I said downloading, I meant: store the mp3 file in some of the accessible web root hierarchy, point your browser to this url (like: http://yourserver/path/to/your/file.mp3) and if it works, you should get a player (browser based, at least on chrome and firefox).
Hitting play will tell you if the file is an issue or the browser.
If it does not play correctly, then there is nothing that can be done, fix your file.
If it does play correctly, then I would suspect ffmpeg issue, you can disable transcoding in the configuration file, and check if it works.

I have convert to 128 on mobile enabled. And I still cant get all songs play on mobile. The server has access to songs no problem also  my Emby server can play the same song.

@gerroon did you fix your problem on mobile browser? mine everything works just fine only doesn't work on mobile browser the song refuse to play

@dsrukmana I actually stop using Koel, so I cant  answer that :(


Rename helper function for data cleaning remove_chars() to del_chars() - done

Function remove_chars() helps in data cleaning by removing provided character(s) from given text.
Renaming function to del_chars() instead for user convenience while not losing meaning of function name.

Done. If you are using TagUI v6.46 and above, you can get this update with tagui update command or MS Word plug-in Update TagUI button. You can get TagUI v6.46 from this installation page, or manually unzip this zip file to overwrite your existing installation (drag all the folders and files under TagUI-master\src to your existing tagui\src folder).
Usage example - https://tagui.readthedocs.io/en/latest/reference.html#del-chars

Done. If you are using TagUI v6.46 and above, you can get this update with tagui update command or MS Word plug-in Update TagUI button. You can get TagUI v6.46 from this installation page, or manually unzip this zip file to overwrite your existing installation (drag all the folders and files under TagUI-master\src to your existing tagui\src folder).
Usage example - https://tagui.readthedocs.io/en/latest/reference.html#del-chars

Closing since this change has made its way into the latest packaged release.


[DC-2631] update remove_participant_data_past_deactivation_date tou uses resources.CDM_TABLES instead of common.CDM_TABLES to include survey_conduct table

Thanks for this, @ksdkalluri - it looks good! Did you run reporter.py to verify that survey_conduct would be included in the SQL? If so, would you please attach a screenshot to the ticket? Alternatively, you could add survey_conduct to the integration test remove_participant_data_past_deactivation_date_test.py, whichever you'd prefer.

@molly-giddings Added integration test for survey_conduct_table.


[5.1] Correct the comment

Comment is not matched with the function.

@taylorotwell  But the comment is showing the opposite : first normal creator then custom one;  but in fact we looks for custom creator first and then normal one.


Requirements

Leading up to doing some wireframing leading to a visual style, here's a potential outline of some requirements for the website:
http://piratepad.net/opensourcedesign-website-requirements

@simonv3 Can this be closed?

Considering this pirate pad is empty, I guess so!


Revision 3

I have trouble reading the fields related to the revision 3 using the plug-in version 1.1 , all fields return the value 0 .
Thanks for your good work .

This could be related to user rights on your system.
Does it make a difference if you start your reader as an administrator?


Remove the persistent savings indicator text after a successful response.

As shown in the gif above, the "Saved" text re-appears after fading out and just stays there.
The previous behaviour was that, on successful response the container faded out.
While for an error response it remained.
Introduced in https://github.com/zulip/zulip/commit/f97d35ebd244ee83744b0fb2194dc1f32e0f92ab.

@zulipbot claim

Which tool can I use to create a gif of result as in the first comment?

@garg3133 https://zulip.readthedocs.io/en/latest/tutorials/screenshot-and-gif-software.html


Add the ability to use default credentials for HttpClient when downlo…

We should be able to authenticate against any web service using by UseDefaultCredentials.
DownloadFileSettings will need a new property UseDefaultCredentials that will be used for HttpClientHandler to set UseDefaultCredentials.
We need this, when we download documents from a Sharepoint website.

Hi @Rookian, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@Rookian, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;

@Rookian in line with our contributing process (https://github.com/cake-build/cake/blob/develop/CONTRIBUTING.md) can you please create an issue, and link to this PR from it?
Also, would it be possible for you to rebase your changes on top of the latest develop branch? Thanks!

Relates to #1318

@Rookian I have rebased and merged the changes in this PR, and you can find the end result here: https://github.com/cake-build/cake/commit/73a3c2a98e5b05f53153a72ade83945c4397de5a
As a result of rebasing and merging, I am going to manually close this PR, however, your changes have been correctly attributed.  Thanks!

Great!


input callback tend to stop after report 3000 times

callback is created by IOHIDDeviceRegisterInputReportCallback
why?
i referred to purejavahidapi, but i couldn't find a difference.

LESSON
suspect the context object was garbage collected


Change lexical alignment default to 1-grams

No article in the current literature uses n-grams above 1 for lexical alignment. It'd make sense to change the default to 1.

The fix seems pretty straightforward: in the calculate alignment.py, function LexicalPOSAlignment, the line
for ngram in range(2,maxngram+1):
should become
for ngram in range(1,maxngram+1):
This however has the potential drawback of providing the user with an additional meaningless syntactic alignment of 1-grams.
No biggie for me, but if we want to avoid that, it could be solved by not passing along the penn_tok1 and penn_lem1 (including the stan stuff).


Fix diagrams causing error in Umbrella Docs

Fix the diagrams that uses the plantuml awslib
The awslib changed some of their icons which is causing error in the plantuml build
plantuml -o ../source/_static/ -tpng docs/diagrams/*.puml
Error line 27 in file: docs/diagrams/repository-service-tuf-worker-C2.puml
Some diagram description contains errors
make: *** [Makefile:21: docs] Error 200

The error is visible in this Github Action: https://github.com/repository-service-tuf/repository-service-tuf/actions/runs/5535277077/jobs/10101493643


ci: setup yaml linting of SBOM Catalog

This PR adds yaml linting and schema validation to ensure contributions to the SBOM Catalog don't break the data and filter yaml files.

@idunbarh, thanks for pointing out the singular, plural thing. I will look into that, but you're right. All Plural would be best.
It's also a great idea to add linting. I'm not 100 percent happy about adding some Python tooling to the NPM project, but it's only in the CI, so I think it's fine for now 👍.

Mybe it would be a good convention to say lists are in plural and regular Strings are in singular.

Hey @idunbarh, I just took the liberty to add your PR to mine and fix the data.yaml. I recently added some more projects, so I wanted to make sure that they also adhere to the schemas.


Resource monitor files being emitted to output directory

What happened?
Possibly starting in fMRIPrep 22.0, resource monitor files like .proc-14893_time-1660632638.9472053_freq-1.00 are being dumped directly in the output directory. We should look into the behavior with --resource-monitor enabled to verify/correct this behavior.
What command did you use?

Singularity
Is your data BIDS valid?
Yes
Are you reusing any previously computed results?
No
Please copy and paste any relevant log output.
No response
Additional information / screenshots
No response

This is where the MRIQC resource monitor was added -> https://github.com/nipreps/mriqc/pull/984
The code is here: https://github.com/nipreps/mriqc/blob/master/mriqc/instrumentation/resources.py
and I think I first called MRIQC, visually checked the PID, and then did something like:
python -m mriqc.instrumentation <MRIQC_PID>

there's probably an easy bash pipe to first trigger the command line you want to run and pass the PID to some other command.
Then the mriqc.instrumentation.viz has some code for plotting.


Click "Base64 Text" Tab crashing

Current behavior
After changing the App theme to "dark", clicking on the "Base64 Text" tab, the App crashed
How to reproduce it (as minimally and precisely as possible)
No response
Expected behavior
Changing the app theme should not affect the functionality and stability of the App
Screenshots
No response
Workaround
No response
Affected platforms
Windows
Affected DevToys kind
DevToys (app with GUI)
DevToys Version
Version <IP_ADDRESS> | X64 | RELEASE | 2706c6c | 2706c6c
Relevant Assets/Logs
No response

Duplicate with #755


Please dont abandon it/us

Hi guys,
The app is the best thing on my phone, by far. Everything is perfect, and I really love it on a daily basis.
Please, please don't throw away all hard work, and leave all happy users handicapped and in tears.
Could you please consider:

Sharing an official and safe APK?
Renaming the app and conform to Googles requirements and go up on Play again?
Add a crypto donation address on a cheaper (and faster) blockchain than BTC and ETH so I can donate easily?

One feature request:

Export all settings & pairs (to file or text or mail), so I can start over fast and without pain (or on other device).

Thanks guys for the wonderful app and all work done.

Wont help - I still got the apk but it started forceclosing when trying to add new checkers, couldnt figure out whats wrong
Tried on 2 phones ;( I really miss that app cause there is no alternative.

I've been using the app since 2016 [the original one, developed by Mobnetic]. After all these years, I don't see any other app as good as this one.
Is there any way to support the development, so this 2nd iteration of Bitcoin Checker does not die like the first one?

It was the best app for me too! 😭


No docs for QUIETSIMPLE and QUIET parameters

In the doc: sql-docs/docs/database-engine/install-windows/install-sql-server-from-the-command-prompt.md
There is no documentation for the parameters QUIET and/or QUIETSIMPLE.  These parameters are written to the ConfigurationFile.ini by the SQL Server Setup Wizard and yet there is no mention of either of these values on the Microsoft Docs site -- at least, none that I could pull up utilizing the Search function.

@MashaMSFT Hi Masha, This Issue 1628 is very closely related to your subsequent other Issue 1629 (same .md article).

GitHub:   https://github.com/MicrosoftDocs/sql-docs-pr/blob/master/docs/database-engine/install-windows/install-sql-server-from-the-command-prompt.md

Docs:   https://docs.microsoft.com/sql/database-engine/install-windows/install-sql-server-from-the-command-prompt?view=sql-server-2017

CC: @astrohart

Hi @astrohart , thanks for contacting Microsoft and bringing this to our attention! Let me do a little research... Thanks!

Hi @astrohart , the explanation for /quiet and /quietsimple can be found in the doc that @MightyPen pasted:   https://docs.microsoft.com/sql/database-engine/install-windows/install-sql-server-from-the-command-prompt?view=sql-server-2017
SQL Server Setup Control | /Q | Specifies that Setup runs in a quiet mode without any user interface. This is used for unattended installations.
SQL Server Setup Control | /QS | Specifies that Setup runs and shows progress through the UI, but does not accept any input or show any error messages.
Additionally, there's a note at the top of the same page:
When installing through the command prompt, SQL Server supports full quiet mode by using the /Q parameter, or Quiet Simple mode by using the /QS parameter. The /QS switch only shows progress, does not accept any input, and displays no error messages if encountered. The /QS parameter is only supported when /Action=install is specified.
Did you have any further questions on these parameters, other than the one from Git Issue 1629? Thanks!

Don’t reply to me, update the docs.
The question is whether /Q and /QS have any values (/Q=“True” or just /Q — the docs should say which).
Also, can /Q and /QS both be specified?  Docs do not say, and do not say which has precedence.
Also, there is no documentation whatsoever for the /QUIET and /QUIETSIMPLE parameters which are present in Config.ini
Regards,
Brian C. Hart, Ph.D.
CEO, xyLOGIX, LLC
San Diego:
5663 Balboa Avenue Suite 412
San Diego, California 92111
Washington, DC:
1845 Cain Drive Suite 1
Fort George G. Meade, Maryland 20755
(443) 679-8247 mobile
www.xylogix.net

On Feb 11, 2019, at 12:56, Masha at MSFT<EMAIL_ADDRESS>wrote:
Hi @astrohart , the explanation for /quiet and /quietsimple can be found in the doc that @MightyPen pasted: https://docs.microsoft.com/sql/database-engine/install-windows/install-sql-server-from-the-command-prompt?view=sql-server-2017
SQL Server Setup Control | /Q | Specifies that Setup runs in a quiet mode without any user interface. This is used for unattended installations.
SQL Server Setup Control | /QS | Specifies that Setup runs and shows progress through the UI, but does not accept any input or show any error messages.
Additionally, there's a note at the top of the same page:
When installing through the command prompt, SQL Server supports full quiet mode by using the /Q parameter, or Quiet Simple mode by using the /QS parameter. The /QS switch only shows progress, does not accept any input, and displays no error messages if encountered. The /QS parameter is only supported when /Action=install is specified.
Did you have any further questions on these parameters, other than the one from Git Issue 1629? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Hi @astrohart , yes, I am already working on editing the content.
/quiet and /q are the same parameter, as are /quietsimple and /qs. The parameter  you use is /q, it enables the /quiet installation. I believe both  (/q and /quiet as well as /qs and quietsimple) can be used interchangeably but I'm getting confirmation before updating the docs, as per your request.
There is an example of how to use it in the same document (you do not need an =true):
setup.exe /q /ACTION=Install /FEATURES=SQL /INSTANCENAME=MSSQLSERVER
Also, just an FYI, your PII from your email has been appended to the Git Issue, and is now visible to everyone. I'm not sure if that was intended. You can edit the post to remove it, if not...
Thanks!

Thanks for alerting me about the PII I have removed it.
And as regards the parameters, I think that I myself am very much aware about how they work so it’s not really necessary to explain it to me, however, it would be proper to make sure the documentation is clear.

Thank you @astrohart  .One of the reasons Masha went into detail is the issues are public and others may read and learn from a complete reposne.  You are also welcome and encouraged to contribute directly to topics by submitting a PR. To do so, you click the Edit button in the upper right of of the tiopic,  More info at https://docs.microsoft.com/en-us/sql/sql-server/sql-server-docs-contribute?view=sql-server-2017  Not everyone has the time I understand, but if you do its a great way to help others. Thank you.

Hi @astrohart , thanks for bringing this to our attention! I have added a note indicating that you can use either /Q or /QUIET and /QS or /QUIETSIMPLE as a parameter. I will now proceed with closing out this Git Issue but please feel free to comment here if you feel something further needs to be added. Thanks again!

thanks


None of the examples include tests

I was looking for examples of how to test with Dagger but didn't find any. The only reference I found was on the website. Perhaps pointers to projects that use Dagger would be good for reference too such as netflix/feign?

+1


fix invalid event format

Signed-off-by: Weston Steimel<EMAIL_ADDRESS>

@oliverchang , I also missed making introduced and fixed a list here, which broke the Analysis and id generation.  I guess it might be a good idea to get some automated checks in place on PR's to catch bad formatting at least?

@oliverchang , I also missed making introduced and fixed a list here, which broke the Analysis and id generation. I guess it might be a good idea to get some automated checks in place on PR's to catch bad formatting at least?

Yep for sure! It's been on my list for a while (as part of https://github.com/pypa/advisory-db/pull/2/files) but I haven't found the time to do it. Feel free to take it over :)


[QUESTION]When I train my COMET model, I have the following problem when I am almost successful, it seems to be stuck

❓ Questions and Help
When I train my COMET model, I have the following problem when I am almost successful, it seems to be stuck
Here is my training command：
CUDA_VISIBLE_DEVICES=0 comet-train --cfg /home/xusongcheng/COMET-master/configs/models/referenceless_model.yaml
This is the last part on Xshell after my command and it's stuck here!
LOCAL_RANK: 0 - CUDA_VISIBLE_DEVICES: [0]
| Name                | Type               | Params
0 | encoder             | XLMREncoder        | 558 M
1 | layerwise_attention | LayerwiseAttention | 26
2 | train_metrics       | RegressionMetrics  | 0
3 | val_metrics         | ModuleList         | 0
4 | estimator           | FeedForward        | 10.5 M
10.5 M    Trainable params
558 M     Non-trainable params
569 M     Total params
1,138.661 Total estimated model params size (MB)
Sanity Checking: 0it [00:00, ?it/s]

I added “--num_workers 0” to the command is invalid
How should I solve it?
best wishes
Winsome

Hi @Winsome-A I have never seen this error maybe you can provide extra information? what pytorch-lightning version are you using?

Oh yeah .Thanks for your email. I have upgraded my cuda&cudnn version and eventually , the problem went away.


Allow more fine-grained control over when Aqua scan fails

At the moment, the scan fails whenever there is a vulnerability. It should be possible to fine-tune this. For example, one may want to ignore vulnerabilities in the base image, or vulnerabilities below a certain threshold (e.g. fail only on high / critical vulnerabilities).
From the docs:

--hide-base: Hides vulnerabilities in the base image. This is used to hide any existing vulnerabilities from a base image. These vulnerabilities are known from the base image and not required to be reported on every image created from the specific base image.
I did not find anything regarding a "vulnerability threshold" ...

@renedupont do you know if there are more options?

IIRC there was an option for something like thresholds that can be set in Image Assurance Policies. The doc mentions:
Vulnerability Score -> Fails the image if its vulnerability score is greater or equal to the selected value
Vulnerability Severity -> Fails the image if its vulnerability severity is greater or equal to the selected value.
Is that what you are looking for?

@renedupont If I get it right that would mean we will not be able to control this from the scan, but it will have to be set in the Aqua server itself? In that case we could close the issue because there is nothing we can do, and the feature is already "available". Right?

I would say so, yes. To my understanding, an admin would create such an image assurance policy (or change an existing one) in the server to set the vulnerability score and/or severity. The policies have a scope setting that determines to which images they are applicable to once scanned.


How to get event "page loaded"

Hello, need some help.
Me need get event when page is loaded
thrustWindow := thrust.NewWindow(thrust.WindowOptions{RootUrl: "http://google.com"})
How can I do it?
*I do not want to use for this JS

Please look at the thrust documentation. If that does not work you will
have to use the thrust js api to tie in certain events. I will try to look
at the docs if I have time but am very busy.
On Dec 7, 2015 4:10 AM, "Valeriy Bdtaev"<EMAIL_ADDRESS>wrote:

Hello, need some help.
Me need get event when page is loaded
thrustWindow := thrust.NewWindow(thrust.WindowOptions{RootUrl: "
http://google.com"})
How can I do it?
*I do not want to use for this JS
—
Reply to this email directly or view it on GitHub
https://github.com/miketheprogrammer/go-thrust/issues/64.

btw. You have to use JS. the point of this API  is to be able to interact with JS.


Was there a technical limitation why 1.7.10 was dropped?

With modded minecraft more than half the player base is still on 1.7.10

ahh, following the bungeecord protocol support, thanks.


fix: named captures in has fields not applying to route dest

This PR does the following:

Changes the logic to use the PCRE match function for has entries as the regex is expected to be in the PCRE format.
For PCRE matches in the has entries, attempts to update the route's destination with any named capture groups extracted.

Relevant docs: https://nextjs.org/docs/app/api-reference/next-config-js/rewrites#header-cookie-and-query-matching
fixes #448

Would be amazing if we could proceed with this PR 🙏  it will help out a lot and should also help with support for @sentry/nextjs

Would be amazing if we could proceed with this PR 🙏 it will help out a lot and should also help with support for @sentry/nextjs

Hello @emma-cw, Dario is OOO at the moment and will take a look at this when he gets back 🙂. So, I'm afraid it might take a little longer than usual.
You can of course keep using the prerelease until this is merged though!

I'm back, thanks a lot @james-elicx for the PR and sorry (both to you and @emma-cw) for the delay in reviewing it 🙇


cmake: Build vendored libraries statically if SHARED not enabled

Depends on #245

cmake: Build vendored libraries statically if SHARED not enabled
If we're building vendored libraries, we'll often want them to be an
implementation detail of SDL_image that will not conflict with system
libraries (or even with libraries vendored by a different dependency),
which might be a different version.

cmake: Add a default for whether to use shared linking
As with vendored libraries, if we want to use one setting or the other
for one of the dependencies, it's likely that we'll want to do the same
for all of the dependencies.

workflows: Enable the automated test for CMake builds
If we link the vendored libraries statically, then we should have
everything we need to make this test work.

Superseded by #238 and #249.


Implemented session management

Closes #144

Implemented session management using express-session
created session middleware to check for valid sessions
added session middleware to those routes which require user login.
implemented session management on cliend side using cookies

frontend session:
https://github.com/user-attachments/assets/73c16a49-a704-415d-aaf2-83db32ff8f9b
bakcend session on api:
https://github.com/user-attachments/assets/fd382930-48f4-41bc-8036-0d7faefa73f6

Summary by CodeRabbit
Release Notes

New Features

Introduced a logout functionality for users, allowing them to securely end their session.
Enhanced session management capabilities across various routes, ensuring better user experience.

Bug Fixes

Corrected a typo in the error middleware import statement.

Documentation

Updated contributors' section in the README to reflect current contributors accurately.

Chores

Added new dependencies for session management and updated related configurations.

@Sourabh782 can you make the admin router private like no one will access except admin

@Sourabh782 can you make the admin router private like no one will access except admin

sure will look into it

@Sourabh782 can you make the admin router private like no one will access except admin

actually we already have admin middleware:


change in ui/ux

in the project:
https://github.com/TusharKesarwani/Front-End-Projects/tree/main/Projects/3D Login Page
i want to change background color,font and size of landing page and login page to make it more attractive .please assign me thi sissue under ssoc. This would be my first contribution.

@TusharKesarwani could you please assign to me .


Allow light/wall count to be moved to lower right corner

There's more than one mod (FPS Meter for example) that uses the upper right corner for something.  Perhaps it would be possible to allow DF architect to move it's counter to the lower right corner as a user configurable option?

I'm going to add some logic to make the counter move down to below the FPS counter if it is there.


Skip GROBID author extraction if no author name

It might happen that GROBID fails to extract an author name, e.g. https://inspirehep.net/api/holdingpen/2884921. If any author name is missing, the GROBID author data should not be used, and we should fall back to the authors in the metadata.

Tech:

Change this to iterate through all authors and check them. If there at least one empty author then parse_all should return None, otherwise build list of authors and return it.
Here We should use parse_all() to get list of authors or None.
In here check if authors from record are not None - related to another small bug


Missing explanation for available options in README

Hey there,
I tried running ./configure --help to get a list of configuration options, and I received the following message See the README file for available options; however, the README.md file does not have an explanation for available configuration options, and instead one has to read the configure script directly which might not be convenient.
Is this intentional?
Thank you for your time and work on this!

That was just a copy and paste from somewhere. I can remove the reference if you like.

Sure, please remove the reference as it is misleading.


fix: fixed for the issue (#91)

1. Description

1.1. Checklist

[x] The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
[x] I have read the Contributor Guide and followed the process outlined for submitting PRs.
[x] I have updated/added tests for ALL new/updated/fixed functionality.
[x] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
[x] I have updated/added relevant examples in examples.

1.2. Breaking Change

[x] Yes, this is a breaking change.
[ ] No, this is not a breaking change.

1.3. Related Issues

bors merge

Codecov Report

Merging #121 (3dce036) into main (2f07585) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
- Coverage   72.14%   72.00%   -0.14%
==========================================
  Files          97       98       +1
  Lines        1034     1036       +2
==========================================
  Hits          746      746
- Misses        288      290       +2

Impacted Files
Coverage Δ

lib/src/service/entities/preview_card.dart
0.00% <ø> (-100.00%)
:arrow_down:

...b/src/service/v1/instance/instance_v1_service.dart
100.00% <ø> (ø)

lib/src/service/entities/trends_link.dart
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

bors merge


Create/Update Role/Profile

Implement update/create for Roles
Implement update/create for Profiles
Add some stuff in contributing

Current coverage is 86.13% (diff: 93.33%)

Merging #64 into develop will increase coverage by 0.44%

@@            develop        #64   diff @@
==========================================
  Files            83         88     +5
  Lines          1307       1378    +71
  Methods          35         40     +5
  Messages          0          0
  Branches         95         99     +4
==========================================
+ Hits           1120       1187    +67
- Misses          154        157     +3
- Partials         33         34     +1

Powered by Codecov. Last update fbef3c2...8293bfc

+1


PHP: Rename gax to ApiCore

Supporting https://github.com/googleapis/gax-php/pull/125

Codecov Report

Merging #1699 into master will not change coverage.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #1699   +/-   ##
=========================================
  Coverage     84.97%   84.97%
  Complexity     4383     4383
=========================================
  Files           425      425
  Lines         17483    17483
  Branches       1822     1822
=========================================
  Hits          14857    14857
  Misses         2009     2009
  Partials        617      617

Impacted Files
Coverage Δ
Complexity Δ

.../transformer/php/PhpApiMethodParamTransformer.java
91.83% <ø> (ø)
20 <0> (ø)
:arrow_down:

...e/api/codegen/transformer/php/PhpSurfaceNamer.java
91.13% <100%> (ø)
42 <1> (ø)
:arrow_down:

...en/transformer/php/PhpGapicSurfaceTransformer.java
98.72% <100%> (ø)
17 <0> (ø)
:arrow_down:

...ransformer/php/PhpGapicSurfaceTestTransformer.java
98.5% <100%> (ø)
20 <2> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b69682d...3d841cd. Read the comment docs.


front page links on ms edge are unclickable

i think ms edge might be putting the giant art canvas in front of all the other content :(
this is on edge 25.10586.0.0.

actually it is not bc the links are still rendered above the canvas art... but clicks are not getting to the links.


Document parameter and return types of filters and shortcodes

The documentation should indicate what a user can expect a filter or shortcode to return. For example, it’s unclear to me whether they can only return strings.
I’d like to point to MDN’s style of documenting syntax (e.g. see MDN, String.prototype.substring, Syntax).
Ideally, I’d like every piece of documentation that deals with some kind of variable to specify the type of the underlying object, in particular for function parameters and the returned objects of functions.

Hm, could be tricky.
I delevepod a plugin for the <meta name="generator"> insertion the other day.
There I learned that eleventy is behaving as a wrapper around the underlying template language.
So basically check their documentation...

Then, there would be two cases: For similar structures, …

they behave the same (e.g. for filters they might all return strings) or
they behave differently, in which case the differences have to be documented.

Since Eleventy has general shortcodes and filters, they should either behave the same with regards to return types or Eleventy performs a normalization. In the latter case, that should be documented as well.

I'd like to see some normalisation. But let's wait for @zachleat 's opinion.
I recall he worked on something to decouple more parts of the architecture.


 Playstyle: surviveandbuild, Playstyle Lang code: surviveandbuild-bands, WorldType: surviveandbuild-bands
7.1.2023 15:55:32 [Notification] Savegame ./data\Saves\default.vcdbs loaded
7.1.2023 15:55:32 [Notification] World size = 102400 256 102400
7.1.2023 15:55:32 [Notification] Start discovering assets
7.1.2023 15:55:32 [Notification] Found 1 base assets in category blocktypes
7.1.2023 15:55:32 [Notification] Found 0 base assets in category itemtypes
7.1.2023 15:55:32 [Notification] Found 20 base assets in category lang
7.1.2023 15:55:32 [Notification] Found 0 base assets in category patches
7.1.2023 15:55:32 [Notification] Found 22 base assets in category config
7.1.2023 15:55:32 [Notification] Found 0 base assets in category worldproperties
7.1.2023 15:55:32 [Notification] Found 0 base assets in category sounds
7.1.2023 15:55:32 [Notification] Found 97 base assets in category shapes
7.1.2023 15:55:32 [Notification] Found 30 base assets in category textures
7.1.2023 15:55:32 [Notification] Found 0 base assets in category recipes
7.1.2023 15:55:32 [Notification] Found 0 base assets in category worldgen
7.1.2023 15:55:32 [Notification] Found 2 base assets in category entities
7.1.2023 15:55:32 [Notification] Found 172 base assets in total
7.1.2023 15:55:32 [Event] Building assets...
7.1.2023 15:55:32 [Notification] Entering runphase AssetsReady
7.1.2023 15:55:32 [Notification] Will search the following paths for mods:
7.1.2023 15:55:32 [Notification]     G:\gsm\servers\3\serverfiles\Mods
7.1.2023 15:55:32 [Notification]     G:\gsm\servers\3\serverfiles\data\Mods
7.1.2023 15:55:32 [Notification] Found 13 mods (0 disabled)
7.1.2023 15:55:32 [Error] [carryablelogwithresin] Could not resolve some dependencies:
7.1.2023 15:55:32 [Error] [carryablelogwithresin]<EMAIL_ADDRESS>- Missing
7.1.2023 15:55:32 [Error] [wolftaming] Could not resolve some dependencies:
7.1.2023 15:55:32 [Error] [wolftaming]<EMAIL_ADDRESS>- Missing
7.1.2023 15:55:32 [Notification] Mods, sorted by dependency: weaponpacka, betterdrifters, carryablelogwithresin, necessaries, game, medievalexpansion, tpnet, usefulstuff17, creative, survival, wolftaming, xrowboat, Th3Essentials
7.1.2023 15:55:33 [Notification] Instantiated 89 mod systems from 11 enabled mods
7.1.2023 15:55:33 [Notification] External Origins in load order: modorigin@G:\gsm\servers\3\serverfiles\assets\creative, modorigin@G:\gsm\servers\3\serverfiles\assets\survival<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>7.1.2023 15:55:33 [Notification] Found 391 external assets in category blocktypes
7.1.2023 15:55:33 [Notification] Found 265 external assets in category itemtypes
7.1.2023 15:55:33 [Notification] Found 47 external assets in category lang
7.1.2023 15:55:33 [Notification] Found 35 external assets in category patches
7.1.2023 15:55:33 [Notification] Found 49 external assets in category config
7.1.2023 15:55:33 [Notification] Found 24 external assets in category worldproperties
7.1.2023 15:55:33 [Notification] Found 26 external assets in category sounds
7.1.2023 15:55:33 [Notification] Found 2900 external assets in category shapes
7.1.2023 15:55:33 [Notification] Found 170 external assets in category textures
7.1.2023 15:55:33 [Notification] Found 421 external assets in category recipes
7.1.2023 15:55:33 [Notification] Found 418 external assets in category worldgen
7.1.2023 15:55:33 [Notification] Found 62 external assets in category entities
7.1.2023 15:55:33 [Notification] Found 2 external assets in category compatibility
7.1.2023 15:55:33 [Notification] Reloaded lang file with mod assets
7.1.2023 15:55:33 [Event] Medieval Expansion Mod v3.8.1 loading
7.1.2023 15:55:35 [Notification] JsonPatch Loader: 237 патчей всего, успешно применено 221 патчей, отсутствующие файлы в 16 патчах, невыполненны условия в 74 патчах, нет проблем
7.1.2023 15:55:36 [Notification] Loaded 2656 unique items
7.1.2023 15:55:39 [Notification] Loaded 12254 unique blocks
7.1.2023 15:55:39 [Notification] Loaded 222 unique entities
7.1.2023 15:55:39 [Notification] BlockLoader: Entities, Blocks and Items loaded
7.1.2023 15:55:39 [Event] Remapping blocks and items...
7.1.2023 15:55:40 [Event] 6 cooking recipes loaded
7.1.2023 15:55:41 [Event] 707 crafting recipes loaded from 269 files
7.1.2023 15:55:41 [Event] 7 metal alloys loaded
7.1.2023 15:55:41 [Event] 319 smithing recipes loaded
7.1.2023 15:55:41 [Event] 71 clay forming recipes loaded
7.1.2023 15:55:41 [Event] 42 knapping recipes loaded
7.1.2023 15:55:41 [Event] 136 barrel recipes loaded
7.1.2023 15:55:41 [Notification] Entering runphase AssetsFinalize
7.1.2023 15:55:42 [Event] Server assets loaded, parsed, registered and finalized
7.1.2023 15:55:42 [Event] Initialising systems...
7.1.2023 15:55:42 [Notification] Entering runphase LoadGamePre
7.1.2023 15:55:42 [Notification] Reloaded 19 weather patterns, 5 wind patterns and 5 weather events
7.1.2023 15:55:42 [Notification] Started 81 systems on Server:
7.1.2023 15:55:42 [Notification]     Mod 'VSEssentials.dll' (game):
7.1.2023 15:55:42 [Notification]         Vintagestory.ServerMods.Core
7.1.2023 15:55:42 [Notification]         Vintagestory.GameContent.EntityPartitioning
7.1.2023 15:55:42 [Notification]         Vintagestory.GameContent.ErrorReporter
7.1.2023 15:55:42 [Notification]         Vintagestory.ServerMods.ModCompatiblityUtil
7.1.2023 15:55:42 [Notification]         Vintagestory.ServerMods.NoObf.ModJsonPatchLoader
7.1.2023 15:55:42 [Notification]         Vintagestory.Essentials.PathfindSystem
7.1.2023 15:55:42 [Notification]         Vintagestory.Essentials.PathFindDebug
7.1.2023 15:55:42 [Notification]         Vintagestory.Essentials.PathfindingAsync
7.1.2023 15:55:42 [Notification]         Vintagestory.ServerMods.JsonExport
7.1.2023 15:55:42 [Notification]         Vintagestory.ServerMods.ModBasicBlocksLoader
7.1.2023 15:55:42 [Notification]         Vintagestory.GameContent.LeafBlockDecay
7.1.2023 15:55:42 [Notification]         Vintagestory.GameContent.POIRegistry
7.1.2023 15:55:42 [Notification]         Vintagestory.GameContent.RoomRegistry
7.1.2023 15:55:42 [Notification]         Vintagestory.GameContent.WeatherSystemCommands
7.1.2023 15:55:42 [Notification]         Vintagestory.GameContent.WeatherSystemServer
7.1.2023 15:55:42 [Notification]         Vintagestory.GameContent.WorldMapManager
7.1.2023 15:55:42 [Notification]         Vintagestory.ServerMods.NoObf.ModRegistryObjectTypeLoader
7.1.2023 15:55:42 [Notification]         Vintagestory.ServerMods.LoadColorMaps
7.1.2023 15:55:42 [Notification]         Vintagestory.GameContent.ClothManager
7.1.2023 15:55:42 [Notification]         Vintagestory.ServerMods.GridRecipeLoader
7.1.2023 15:55:42 [Notification]     Mod 'VSSurvivalMod.dll' (survival):
7.1.2023 15:55:42 [Notification]         Vintagestory.ServerMods.GenPatchesPrePass
7.1.2023 15:55:42 [Notification]         Vintagestory.ServerMods.GenSnowLayer
7.1.2023 15:55:42 [Notification]         Vintagestory.ServerMods.GenTerra
7.1.2023 15:55:42 [Notification]         Vintagestory.GameContent.SaplingControl
7.1.2023 15:55:42 [Notification]         Vintagestory.GameContent.SurvivalCoreSystem
7.1.2023 15:55:42 [Notification]         Vintagestory.ServerMods.GenTerraPostProcess
7.1.2023 15:55:42 [Notification]         Vintagestory.ServerMods.ChiselBlockBulkSetMaterial
7.1.2023 15:55:42 [Notification]         Vintagestory.ServerMods.GenFromHeightmap
7.1.2023 15:55:42 [Notification]         Vintagestory.ServerMods.GenRockStrataNew
7.1.2023 15:55:42 [Notification]         Vintagestory.ServerMods.NpcControl
7.1.2023 15:55:42 [Notification]         Vintagestory.ServerMods.GenCreatures
7.1.2023 15:55:42 [Notification]         Vintagestory.ServerMods.GenMaps
7.1.2023 15:55:42 [Notification]         Vintagestory.ServerMods.WgenCommands
7.1.2023 15:55:42 [Notification]         Vintagestory.ServerMods.DebugSystem
7.1.2023 15:55:42 [Notification]         Vintagestory.ServerMods.UpgradeTasks
7.1.2023 15:55:42 [Notification]         Vintagestory.GameContent.MyceliumSystem
7.1.2023 15:55:42 [Notification]         Vintagestory.GameContent.ModSystemAuction
7.1.2023 15:55:42 [Notification]         Vintagestory.GameContent.LiquidItemStackRenderer
7.1.2023 15:55:42 [Notification]         Vintagestory.GameContent.CharacterSystem
7.1.2023 15:55:42 [Notification]         Vintagestory.GameContent.FruitingSystem
7.1.2023 15:55:42 [Notification]         Vintagestory.GameContent.ModSystemRifts
7.1.2023 15:55:42 [Notification]         Vintagestory.GameContent.ModSystemRiftWeather
7.1.2023 15:55:42 [Notification]         Vintagestory.GameContent.ModTemperature
7.1.2023 15:55:42 [Notification]         Vintagestory.GameContent.CustomSpawnConditions
7.1.2023 15:55:42 [Notification]         Vintagestory.GameContent.SystemTemporalStability
7.1.2023 15:55:42 [Notification]         Vintagestory.GameContent.ModSystemWearableStats
7.1.2023 15:55:42 [Notification]         Vintagestory.GameContent.ModSystemBlockReinforcement
7.1.2023 15:55:42 [Notification]         Vintagestory.GameContent.TemporalStabilityEffects
7.1.2023 15:55:42 [Notification]         Vintagestory.GameContent.ModJournal
7.1.2023 15:55:42 [Notification]         Vintagestory.GameContent.ModLootRandomizer
7.1.2023 15:55:42 [Notification]         Vintagestory.GameContent.ModSleeping
7.1.2023 15:55:42 [Notification]         Vintagestory.GameContent.TeleporterManager
7.1.2023 15:55:42 [Notification]         Vintagestory.GameContent.Mechanics.MechanicalPowerMod
7.1.2023 15:55:42 [Notification]         Vintagestory.ServerMods.GenDeposits
7.1.2023 15:55:42 [Notification]         Vintagestory.ServerMods.GenStructures
7.1.2023 15:55:42 [Notification]         Vintagestory.ServerMods.GenCaves
7.1.2023 15:55:42 [Notification]         Vintagestory.ServerMods.GenBlockLayers
7.1.2023 15:55:42 [Notification]         Vintagestory.ServerMods.GenPonds
7.1.2023 15:55:42 [Notification]         Vintagestory.ServerMods.GenStructuresPosPass
7.1.2023 15:55:42 [Notification]         Vintagestory.ServerMods.GenVegetationAndPatches
7.1.2023 15:55:42 [Notification]         Vintagestory.GameContent.RecipeRegistrySystem
7.1.2023 15:55:42 [Notification]         Vintagestory.ServerMods.GenRivulets
7.1.2023 15:55:42 [Notification]         Vintagestory.ServerMods.GenLightSurvival
7.1.2023 15:55:42 [Notification]         Vintagestory.ServerMods.RecipeLoader
7.1.2023 15:55:42 [Notification]         Vintagestory.GameContent.TraderOutfits
7.1.2023 15:55:42 [Notification]     Mod 'TeleportationNetwork_v1.17.9_v1.8.0-rc.1.zip' (tpnet):
7.1.2023 15:55:42 [Notification]         TeleportationNetwork.ConfigManager
7.1.2023 15:55:42 [Notification]         TeleportationNetwork.Core
7.1.2023 15:55:42 [Notification]         TeleportationNetwork.SaveManager
7.1.2023 15:55:42 [Notification]         TeleportationNetwork.TeleportManager
7.1.2023 15:55:42 [Notification]         TeleportationNetwork.GenTeleportStructures
7.1.2023 15:55:42 [Notification]     Mod 'VSCreativeMod.dll' (creative):
7.1.2023 15:55:42 [Notification]         Vintagestory.ServerMods.Core
7.1.2023 15:55:42 [Notification]         Vintagestory.ServerMods.WorldEdit.WorldEdit
7.1.2023 15:55:42 [Notification]         Vintagestory.ServerMods.GenBlockLayersFlat
7.1.2023 15:55:42 [Notification]         Vintagestory.ServerMods.GenLightCreative
7.1.2023 15:55:42 [Notification]     Mod 'AlphaWeaponPack_v1.3.1.zip' (weaponpacka):
7.1.2023 15:55:42 [Notification]         CustomWeaponSpeed.WeaponPackAlphaMod
7.1.2023 15:55:42 [Notification]     Mod 'necessaries_v1.17.1-1.1.3.zip' (necessaries):
7.1.2023 15:55:42 [Notification]         necessaries.src.Necessaries
7.1.2023 15:55:42 [Notification]     Mod 'medievalexpansion-3.8.1.zip' (medievalexpansion):
7.1.2023 15:55:42 [Notification]         gates.src.MedievalExpansionMod
7.1.2023 15:55:42 [Notification]     Mod 'usefulstuff17_v1.0.2.zip' (usefulstuff17):
7.1.2023 15:55:42 [Notification]         UsefulStuff.UsefulStuff
7.1.2023 15:55:42 [Notification]         UsefulStuff.GasHelper
7.1.2023 15:55:42 [Notification]     Mod 'xrowboat_0.0.5.zip' (xrowboat):
7.1.2023 15:55:42 [Notification]         XRowboat.XRowboatMod
7.1.2023 15:55:42 [Notification]     Mod 'Th3Essentials_2.0.0.zip' (Th3Essentials):
7.1.2023 15:55:42 [Notification]         Th3Essentials.Th3Essentials
7.1.2023 15:55:43 [Event] [tpnet] Start loading data
7.1.2023 15:55:43 [Event] [tpnet] Data loaded for 7 teleports
7.1.2023 15:55:43 [Event] [tpnet] Check teleport exists (async)
7.1.2023 15:55:44 [Notification] Server map set
7.1.2023 15:55:44 [Notification] Entering runphase GameReady
7.1.2023 15:55:44 [Event] Starting world generators...
7.1.2023 15:55:44 [Notification] Entering runphase WorldReady
7.1.2023 15:55:46 [Notification] Reloaded 35 tree generators
7.1.2023 15:55:46 [Event] Loading 7x7x8 spawn chunks...
7.1.2023 15:55:46 [Event] 0% (49 in queue)
7.1.2023 15:55:47 [Event] Begin game ticking...
7.1.2023 15:55:47 [Notification] Entering runphase RunGame
7.1.2023 15:55:47 [Notification] Successfully loaded 1077 waypoints
7.1.2023 15:55:47 [Notification] Server Advertising enabled. Attempt to register at the master server.
7.1.2023 15:55:47 [Notification] VerifyPlayerAuth is off. Will not register to master server
7.1.2023 15:55:47 [Notification] Registering to master server...
7.1.2023 15:55:47 [Notification] Starting server threads
7.1.2023 15:55:48 [Notification] Master server response status: ok
7.1.2023 15:55:48 [Event] Выделенный сервер now running on Port 42427 and ip <IP_ADDRESS>!
7.1.2023 15:55:48 [Notification] All clients disconnected, pausing game calendar.
7.1.2023 15:55:49 [Warning] Server overloaded. A tick took 864ms to complete.
7.1.2023 15:55:53 [Notification] A Client attempts connecting via TCP, assigning client id 1
7.1.2023 15:55:53 [Notification] Client uid MDI0MDZjNDQ3MDdmNTNmNjgzY2U4NzViNTQ2ZDY5OWI= attempting identification. Name: Prikol
7.1.2023 15:55:53 [Notification] Sending server identification with remap False.  Server control privilege is False
7.1.2023 15:55:53 [Notification] Placing player at 73488,3828125 110 48422,03515625
7.1.2023 15:55:53 [Event] Client disconnected.
7.1.2023 15:55:53 [Notification] Last player disconnected, compacting large object heap...
7.1.2023 15:55:54 [Warning] Server overloaded. A tick took 953ms to complete.
7.1.2023 15:55:58 [Warning] Server overloaded. A tick took 623ms to complete.
7.1.2023 15:56:00 [Notification] A Client attempts connecting via TCP, assigning client id 2
7.1.2023 15:56:00 [Notification] Client uid MDI0MDZjNDQ3MDdmNTNmNjgzY2U4NzViNTQ2ZDY5OWI= attempting identification. Name: Prikol
7.1.2023 15:56:00 [Notification] Delayed join, need to load one spawn chunk first.
7.1.2023 15:56:00 [Notification] Sending server identification with remap False.  Server control privilege is False
7.1.2023 15:56:00 [Notification] Placing player at 73488,3828125 110 48422,03515625
7.1.2023 15:56:34 [Event] Prikol <IP_ADDRESS>:61996 joins.
7.1.2023 15:56:34 [Notification] A client reconnected, resuming game calendar.
7.1.2023 15:57:01 [Notification] A Client attempts connecting via TCP, assigning client id 3
7.1.2023 15:57:01 [Notification] Client uid KukcZEa2XDMU/ypTgeLw0vBr attempting identification. Name: YourCreator
7.1.2023 15:57:01 [Notification] Sending server identification with remap False.  Server control privilege is True
7.1.2023 15:57:01 [Notification] Placing player at 73489,46875 110 48421,5
7.1.2023 15:57:02 [Event] Client disconnected.
7.1.2023 15:57:15 [Notification] A Client attempts connecting via TCP, assigning client id 4
7.1.2023 15:57:15 [Notification] Client uid KukcZEa2XDMU/ypTgeLw0vBr attempting identification. Name: YourCreator
7.1.2023 15:57:15 [Notification] Sending server identification with remap False.  Server control privilege is True
7.1.2023 15:57:15 [Notification] Placing player at 73489,46875 110 48421,5
7.1.2023 15:57:18 [Notification] A Client attempts connecting via TCP, assigning client id 5
7.1.2023 15:57:18 [Notification] Client uid MjlkNTA5OWY2OWNlZTY0Y2E2MjljMzlhMjI2OGJkMjI= attempting identification. Name: Dentes
7.1.2023 15:57:18 [Notification] Delayed join, need to load one spawn chunk first.
7.1.2023 15:57:18 [Notification] Sending server identification with remap False.  Server control privilege is False
7.1.2023 15:57:18 [Notification] Placing player at 58093,6999999881 115 41954,0532937624
7.1.2023 15:57:19 [Event] Client disconnected.
7.1.2023 15:57:27 [Event] YourCreator <IP_ADDRESS>:58235 joins.
7.1.2023 15:57:30 [Notification] A Client attempts connecting via TCP, assigning client id 6
7.1.2023 15:57:30 [Notification] Client uid MjlkNTA5OWY2OWNlZTY0Y2E2MjljMzlhMjI2OGJkMjI= attempting identification. Name: Dentes
7.1.2023 15:57:30 [Notification] Delayed join, need to load one spawn chunk first.
7.1.2023 15:57:30 [Notification] Sending server identification with remap False.  Server control privilege is False
7.1.2023 15:57:30 [Notification] Placing player at 58093,6999999881 115 41954,0532937624
7.1.2023 15:57:43 [Event] Dentes <IP_ADDRESS>:51460 joins.
7.1.2023 16:00:32 [Notification] Server ticking has been suspended
7.1.2023 16:00:32 [Notification] Autosaving game world. Notifying mods, then systems of save...
7.1.2023 16:00:32 [Notification] Defragmented listener lists
7.1.2023 16:00:32 [Event] Mods and systems notified, now saving everything...
7.1.2023 16:00:32 [Event] Will do offthread savegamedata saving...
7.1.2023 16:00:32 [Event] Saved player world data...
7.1.2023 16:00:32 [Event] Saved map regions...
7.1.2023 16:00:32 [Event] Saved map chunks...
7.1.2023 16:00:32 [Event] World saved! Saved 0 chunks, 0 mapchunks, 19 mapregions.
7.1.2023 16:00:32 [Notification] A client reconnected, resuming game calendar.
7.1.2023 16:00:32 [Notification] Server ticking has been resumed
7.1.2023 16:00:32 [Event] Saved 300 chunks...
7.1.2023 16:00:32 [Event] Offthread save of 415 chunks done.
7.1.2023 16:00:32 [Notification] Offthread save of 0 generating chunks done.
7.1.2023 16:00:33 [Event] Offthread save of 475 map chunks done.
7.1.2023 16:00:33 [Event] Offthread save of savegame done.
7.1.2023 16:05:34 [Notification] Server ticking has been suspended
7.1.2023 16:05:34 [Notification] Autosaving game world. Notifying mods, then systems of save...
7.1.2023 16:05:34 [Notification] Defragmented listener lists
7.1.2023 16:05:34 [Event] Mods and systems notified, now saving everything...
7.1.2023 16:05:34 [Event] Will do offthread savegamedata saving...
7.1.2023 16:05:34 [Event] Saved player world data...
7.1.2023 16:05:34 [Event] Saved map regions...
7.1.2023 16:05:34 [Event] Saved map chunks...
7.1.2023 16:05:34 [Event] World saved! Saved 0 chunks, 0 mapchunks, 13 mapregions.
7.1.2023 16:05:34 [Notification] A client reconnected, resuming game calendar.
7.1.2023 16:05:34 [Notification] Server ticking has been resumed
7.1.2023 16:05:34 [Event] Saved 300 chunks...
7.1.2023 16:05:34 [Event] Offthread save of 430 chunks done.
7.1.2023 16:05:34 [Notification] Offthread save of 0 generating chunks done.
7.1.2023 16:05:34 [Event] Offthread save of 497 map chunks done.
7.1.2023 16:05:34 [Event] Offthread save of savegame done.
7.1.2023 16:07:01 [Notification] Client Prikol tried to place a block but rejected because the client hand is empty
7.1.2023 16:10:35 [Notification] Server ticking has been suspended
7.1.2023 16:10:35 [Notification] Autosaving game world. Notifying mods, then systems of save...
7.1.2023 16:10:35 [Notification] Defragmented listener lists
7.1.2023 16:10:35 [Event] Mods and systems notified, now saving everything...
7.1.2023 16:10:35 [Event] Will do offthread savegamedata saving...
7.1.2023 16:10:35 [Event] Saved player world data...
7.1.2023 16:10:35 [Event] Saved map regions...
7.1.2023 16:10:35 [Event] Saved map chunks...
7.1.2023 16:10:35 [Event] World saved! Saved 0 chunks, 0 mapchunks, 21 mapregions.
7.1.2023 16:10:35 [Notification] A client reconnected, resuming game calendar.
7.1.2023 16:10:35 [Notification] Server ticking has been resumed
7.1.2023 16:10:35 [Event] Saved 300 chunks...
7.1.2023 16:10:35 [Event] Offthread save of 325 chunks done.
7.1.2023 16:10:35 [Notification] Offthread save of 0 generating chunks done.
7.1.2023 16:10:36 [Event] Offthread save of 523 map chunks done.
7.1.2023 16:10:36 [Event] Offthread save of savegame done.
7.1.2023 16:11:49 [Event] Игрок YourCreator вышел.
Mods

Screenshots

Can not reproduce. Were there any other conditions? Are other players on the server also getting this bug?


Collect coverage with PCOV

TODO:

[x] merge and release https://github.com/PHP-CS-Fixer/phpunit-constraint-isidenticalstring/pull/3
[x] merge and release https://github.com/PHP-CS-Fixer/phpunit-constraint-xmlmatchesxsd/pull/5
[x] prepare PhpUnitTestCaseStaticMethodCallsFixerTest for PHPUnit 8

Optional:

cache cloning krakjoe/pcov (will be faster that PHP 5.6 without it, that's why optional)
allow PHPUnit 8 for phpunitgoodpractices/traits

Problem: PHPUnit 8 requires function from TestCase (such as setUp) to have void return type, thus installing PHPUnit with current codebase is not possible. But, to have PCOV we need PHPUnit 8.
Either way we need some compromise:

we allow PHPUnit 8 in composer.json and every job installing it must add void return types before running tests
we don't allow PHPUnit 8 in composer.json, but require it only when collecting code coverage

I went with 2nd one as requiring less changes.
@SpacePossum can toy remove the WIP label? Let the review begin.

can you elaborate about switch to pcov, perhaps? some reasoning, comparison, sth ?
probably a link to sth already existing would be enough

Switch to PCOV is for a simple reason - phpdbg was not capable of calculating coverage for our test suite - it was hitting the limit of opened stream resources, explained here, inspired by this with some benchmarks here.

Thank you @kubawerlos.


Added a filter to remove "fixed" parameters that the client cannot see or set.

"Fixed" parameters are those that are assigned with an = in the route file, often seen with Assets "path" etc, eg:
GET    /tracks/:trackId             controllers.Assets.versioned(path="/public/assets", trackId: Asset)
Fixed a test that was requiring those parameters to be passed through.  I suspect this test was generated using the existing output as an expectation.

👍

Coverage increased (+0.2%) to 88.444% when pulling ec330b8acc51a821437705364ee9f3c465530c43 on SattaiLanfear:master into af6b62a3de5af06da09af3f07bee1f9ff4fc3a36 on iheartradio:master.


Create an "on display" area

NOTE: Before you begin working on this, please assign this issue to yourself. If you do not do this, then there's the possibility that 2 people will end up doing the same task, which is not a good use of time.
The rules for artifacts calls for an "on display" area where artifacts are placed after they are dug up (via a dig event).  This area needs to be accessible to the user and allow them to perform the two optional events at the beginning of their turn (neither counts as an action):

Perform a free dogma action of the on display artifact.  The symbols on the card are added to the current counts for the purposes of executing this dogma.
Return the on display artifact to the pile it was drawn from (thus allowing another artifact to be drawn).

After that initial part of the turn, the on display artifact can only be melded onto the board with a meld action (just like melding from hand).

I had a couple of thoughts on this:

Making a separate box (like the "hand" box) on the screen on the far right might be the simplest way to display it.  This would be visible to all players and could only contain one artifact card.  At the beginning of the turn, the engine would highlight the card and add the additional symbols to the display on the far right to show that the symbol count is enhanced.  It would also show the three options for the artifact:  Dogma, return, or pass.
If someone wants to meld the artifact, they can just click on the card just like they do the cards in hand during the normal course of their turn.
If the artifact expansion isn't being used, then this box would not appear.

The separate box makes the card on display more obvious and easier to interact with rather than putting it on the reference card.

I agree that a separate "on display" box makes sense. The reference card isn't large enough to put a card on it and I don't think it would look good to make it bigger, especially on mobile.

I'll start with the first part of this: getting the new area in the UI, and making it possible to transfer cards to and from the zone.

This isn't quite working right.  Dogma and Return actually counts as an action during the turn.  At least in the rev I've been working from.

This isn't quite working right. Dogma and Return actually counts as an action during the turn. At least in the rev I've been working from.

I don't think this is happening in any version of the code I'm working with.
So to update this issue, the work left here is to improve the layout of the Artifact zone (right now it's way larger than necessary), and also to include the resource icons of the artifact when executing it from the display (a difficult PHP change, and some easy CSS/Javascript changes).

I think I'll close this issue since it might be a while before I get around to adjusting the Artifact zone placement. The goal of this issue (creating a functional "on display" area) is complete.


Home hero gradient missing

This was due to an issue with our environment variables and dead code stripping. Removing .meteor/local and restarting is the fix for now.


Cycle through containers of active workspace

My usecase is the following:

I use one workspace (workspace 2) for my communication apps (Slack, Discord, Mumble, Telegram, ...)
They are in a stacked layout

So, when I use alt-2, I switch to that workspace, which is great. But if the wrong app is in foreground, I have to reach over to alt-k to switch containers.
Sure, I could remap this binding to e.g. alt-e (that's unusued in my config), but I would love if I could just keep hitting alt-2.
You can approximate it with
alt-2 = ['workspace 2', 'focus down']

but that means that whever I go back to workspace 2, I get a new random app.
The best alternative I've found is to swap those commands:
alt-2 = ['focus down', 'workspace 2']

But that means if I have another layout stacked somewhere, it breaks that before leaving, which is annoying.
Essentially, what I want is that focus down is only executed if the active workspace is already workspace 2.

Thank you for making it possible ❤

Hm,
I've been playing around with this, but I can't get it to work, and I think it's the bash part that's wrong. The script seems to be working fine if I execute it with bash -c, but not even the simple case of this works:
alt-2 = 'exec-and-forget aerospace workspace 2'

Nothing happens. I'm not sure what i'm doing wrong

Try to specify the full path to aerospace binary (on Apple Silicon Macs it's /opt/homebrew/bin/aerospace)
You can add Homebrew to GUI apps $PATH https://docs.brew.sh/FAQ#my-mac-apps-dont-find-homebrew-utilities

Ah, perfect, I suspected it was something like this, but struggled to find the full path. I'm a bit new to macOS, coming from a windows/linux/freebsd background,
Thanks, it works perfectly now. It's actually a really convenient way to cycle through apps now that I'm actually trying it.


Medical pdf upgrade

Issue #, if available:
replaced earlier pdfs on covid-19 with general medical pdfs.  Added a new medical faq csv file.  Modified the Kendra loading lambda function to use the new faq file
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

We should probably change the name of the bucket here too:
https://github.com/awslabs/document-understanding-solution/blob/89bf6cf10d0c8838ae8ec38df6acf6720edb363d/source/lib/cdk-textract-stack.ts#L1554

There are quite a few places of code that need to be updated. I will be taking care of the updates on UI (javascript files), would you be able to check the other files? Some them include

https://github.com/awslabs/document-understanding-solution/blob/89bf6cf10d0c8838ae8ec38df6acf6720edb363d/source/lib/cdk-textract-stack.ts

https://github.com/awslabs/document-understanding-solution/blob/11c2db457ef66ab50fb739110ee7b559219c5ffe/source/bin/upload-samples.sh

https://github.com/awslabs/document-understanding-solution/blob/7be3bfce8775909cdaffb4e87b0d78286b7874e4/source/lambda/customResourceKendraDataSource/lambda_function.py

https://github.com/awslabs/document-understanding-solution/blob/7be3bfce8775909cdaffb4e87b0d78286b7874e4/source/lambda/customResourceKendraIndex/lambda_function.py

https://github.com/awslabs/document-understanding-solution/blob/c2da7f422c0b3c0514605eacf72ab51a5b1a25c5/README.md


Refactor mixins and options

I added mixin for options property. Fix possible problems in properties from mixins.

And fix bug in SetLStyle. Check 'newVal === oldVal' for object always true. "the old value will be the same as new value"

@bezany I will be able to take a look at this only later in the week but thanks for the hard work!

Good job here! Merging!