pkgsStatic.buildPackages.haskell.compiler.{ghc96,ghcHEAD} fail to build

@nix { "action": "setPhase", "phase": "buildPhase" }
building
hadrianFlags: --flavour=release+fully_static+no_dynamic_ghc+split_sections --bignum=gmp --docs=no-sphinx -j4
]0;Starting...# cabal-read (for OracleQ (PackageDataKey (Package {pkgType = Library, pkgName = "binary", pkgPath = "libraries/binary"})))
# cabal-read (for OracleQ (PackageDataKey (Package {pkgType = Library, pkgName = "bytestring", pkgPath = "libraries/bytestring"})))
# cabal-read (for OracleQ (PackageDataKey (Package {pkgType = Library, pkgName = "Cabal-syntax", pkgPath = "libraries/Cabal/Cabal-syntax"})))
# cabal-read (for OracleQ (PackageDataKey (Package {pkgType = Library, pkgName = "Cabal", pkgPath = "libraries/Cabal/Cabal"})))
| Successfully generated compiler/ghc.cabal from its template
# cabal-read (for OracleQ (PackageDataKey (Package {pkgType = Library, pkgName = "ghc", pkgPath = "compiler"})))
# cabal-read (for OracleQ (PackageDataKey (Package {pkgType = Library, pkgName = "containers", pkgPath = "libraries/containers/containers"})))
# cabal-read (for OracleQ (PackageDataKey (Package {pkgType = Library, pkgName = "directory", pkgPath = "libraries/directory"})))
# cabal-read (for OracleQ (PackageDataKey (Package {pkgType = Library, pkgName = "process", pkgPath = "libraries/process"})))
# cabal-read (for OracleQ (PackageDataKey (Package {pkgType = Library, pkgName = "exceptions", pkgPath = "libraries/exceptions"})))
# cabal-read (for OracleQ (PackageDataKey (Package {pkgType = Library, pkgName = "filepath", pkgPath = "libraries/filepath"})))
| Successfully generated libraries/ghc-boot/ghc-boot.cabal from its template
# cabal-read (for OracleQ (PackageDataKey (Package {pkgType = Library, pkgName = "ghc-boot", pkgPath = "libraries/ghc-boot"})))
| Successfully generated libraries/ghc-boot-th/ghc-boot-th.cabal from its template
# cabal-read (for OracleQ (PackageDataKey (Package {pkgType = Library, pkgName = "ghc-boot-th", pkgPath = "libraries/ghc-boot-th"})))
| Successfully generated libraries/ghc-heap/ghc-heap.cabal from its template
# cabal-read (for OracleQ (PackageDataKey (Package {pkgType = Library, pkgName = "ghc-heap", pkgPath = "libraries/ghc-heap"})))
| Successfully generated libraries/ghci/ghci.cabal from its template
# cabal-read (for OracleQ (PackageDataKey (Package {pkgType = Library, pkgName = "ghci", pkgPath = "libraries/ghci"})))
# cabal-read (for OracleQ (PackageDataKey (Package {pkgType = Library, pkgName = "hpc", pkgPath = "libraries/hpc"})))
# cabal-read (for OracleQ (PackageDataKey (Package {pkgType = Library, pkgName = "mtl", pkgPath = "libraries/mtl"})))
# cabal-read (for OracleQ (PackageDataKey (Package {pkgType = Library, pkgName = "parsec", pkgPath = "libraries/parsec"})))
# cabal-read (for OracleQ (PackageDataKey (Package {pkgType = Library, pkgName = "time", pkgPath = "libraries/time"})))
| Successfully generated libraries/template-haskell/template-haskell.cabal from its template
# cabal-read (for OracleQ (PackageDataKey (Package {pkgType = Library, pkgName = "template-haskell", pkgPath = "libraries/template-haskell"})))
# cabal-read (for OracleQ (PackageDataKey (Package {pkgType = Library, pkgName = "text", pkgPath = "libraries/text"})))
# cabal-read (for OracleQ (PackageDataKey (Package {pkgType = Library, pkgName = "transformers", pkgPath = "libraries/transformers"})))
# cabal-read (for OracleQ (PackageDataKey (Package {pkgType = Library, pkgName = "unix", pkgPath = "libraries/unix"})))
# cabal-read (for OracleQ (PackageDataKey (Package {pkgType = Library, pkgName = "array", pkgPath = "libraries/array"})))
# cabal-read (for OracleQ (PackageDataKey (Package {pkgType = Library, pkgName = "base", pkgPath = "libraries/base"})))
# cabal-read (for OracleQ (PackageDataKey (Package {pkgType = Library, pkgName = "deepseq", pkgPath = "libraries/deepseq"})))
# cabal-read (for OracleQ (PackageDataKey (Package {pkgType = Library, pkgName = "ghc-bignum", pkgPath = "libraries/ghc-bignum"})))
# cabal-read (for OracleQ (PackageDataKey (Package {pkgType = Library, pkgName = "ghc-compact", pkgPath = "libraries/ghc-compact"})))
# cabal-read (for OracleQ (PackageDataKey (Package {pkgType = Library, pkgName = "ghc-prim", pkgPath = "libraries/ghc-prim"})))
# cabal-read (for OracleQ (PackageDataKey (Package {pkgType = Library, pkgName = "haskeline", pkgPath = "libraries/haskeline"})))
# cabal-read (for OracleQ (PackageDataKey (Package {pkgType = Library, pkgName = "integer-gmp", pkgPath = "libraries/integer-gmp"})))
# cabal-read (for OracleQ (PackageDataKey (Package {pkgType = Library, pkgName = "pretty", pkgPath = "libraries/pretty"})))
| Successfully generated rts/rts.cabal from its template
# cabal-read (for OracleQ (PackageDataKey (Package {pkgType = Library, pkgName = "rts", pkgPath = "rts"})))
# cabal-read (for OracleQ (PackageDataKey (Package {pkgType = Library, pkgName = "stm", pkgPath = "libraries/stm"})))
# cabal-read (for OracleQ (PackageDataKey (Package {pkgType = Library, pkgName = "xhtml", pkgPath = "libraries/xhtml"})))
| Configure package 'bytestring'
| Configure package 'ghc-prim'
# cabal-read (for OracleQ (PackageDataKey (Package {pkgType = Program, pkgName = "hp2ps", pkgPath = "utils/hp2ps"})))
| Configure package 'ghc-heap'
| Configure package 'parsec'
| Configure package 'hpc'
| Configure package 'deepseq'
| Configure package 'ghc-boot-th'
| Configure package 'rts'
| Configure package 'process'
| Configure package 'integer-gmp'
| Configure package 'array'
| Configure package 'time'
| Configure package 'unix'
| Configure package 'mtl'
| Configure package 'transformers'
# cabal-read (for OracleQ (PackageDataKey (Package {pkgType = Program, pkgName = "unlit", pkgPath = "utils/unlit"})))
| Configure package 'stm'
| Configure package 'ghci'
| Configure package 'directory'
| Copy file: driver/ghc-usage.txt => _build/stage1/lib/ghc-usage.txt
| Configure package 'containers'
| Configure package 'binary'
| Configure package 'Cabal'
| Configure package 'ghc-compact'
| Configure package 'text'
| Configure package 'Cabal-syntax'
| Configure package 'pretty'
| Configure package 'hp2ps'
| Configure package 'xhtml'
| System GMP library/framework will be used
| Configure package 'filepath'
| Configure package 'base'
| Copy file: driver/ghci-usage.txt => _build/stage1/lib/ghci-usage.txt
| Successfully generated ghc/ghc-bin.cabal from its template
# cabal-read (for OracleQ (PackageDataKey (Package {pkgType = Program, pkgName = "ghc-bin", pkgPath = "ghc"})))
| Configure package 'exceptions'
| Configure package 'unlit'
| Successfully generated utils/ghc-pkg/ghc-pkg.cabal from its template
# cabal-read (for OracleQ (PackageDataKey (Package {pkgType = Program, pkgName = "ghc-pkg", pkgPath = "utils/ghc-pkg"})))
| Configure package 'haskeline'
| Run GhcPkg Recache (Stage0 InTreeLibs): none => none
| Copy file: mk/system-cxx-std-lib-1.0.conf => _build/stage1/lib/package.conf.d/system-cxx-std-lib-1.0.conf
| Copy file: llvm-passes => _build/stage1/lib/llvm-passes
| Copy file: llvm-targets => _build/stage1/lib/llvm-targets
| Configure package 'template-haskell'
# cabal-read (for OracleQ (PackageDataKey (Package {pkgType = Program, pkgName = "hsc2hs", pkgPath = "utils/hsc2hs"})))
| Copy file: libraries/ghc-bignum/gmp/ghc-gmp.h => _build/stage1/libraries/ghc-bignum/build/include/ghc-gmp.h
| Configure package 'ghc-bignum'
| Configure package 'ghc-boot'
| Copy file: utils/hsc2hs/data/template-hsc.h => _build/stage1/lib/template-hsc.h
| Successfully generated _build/stage1/lib/settings.
# cabal-configure (for _build/stage0/utils/unlit/setup-config)
| Configure package 'ghc'
| Configure package 'ghc-boot'
| Configure package 'exceptions'
| Configure package 'bytestring'
| Configure package 'mtl'
| Configure package 'unlit'
| Run GhcPkg Recache (Stage0 GlobalLibs): none => none
| Configure package 'transformers'
| Configure package 'unix'
| Configure package 'ghc-boot-th'
| Configure package 'time'
# cabal-configure (for _build/stage0/libraries/ghc-boot-th/setup-config)
| Copy file: driver/ghc-usage.txt => _build/stage0/lib/ghc-usage.txt
| Copy file: driver/ghci-usage.txt => _build/stage0/lib/ghci-usage.txt
| Configure package 'Cabal-syntax'
| Configure package 'ghc-heap'
# cabal-configure (for _build/stage0/libraries/time/setup-config)
# cabal-configure (for _build/stageBoot/utils/unlit/setup-config)
| Configure package 'containers'
| Configure package 'template-haskell'
# cabal-autogen (for _build/stage0/libraries/ghc-boot-th/build/autogen/cabal_macros.h)
| Configure package 'binary'
| Run Cc (FindCDependencies CDep) (Stage0 InTreeLibs): utils/unlit/unlit.c => _build/stage0/utils/unlit/build/c/unlit.o.d
| Copy file: mk/system-cxx-std-lib-1.0.conf => _build/stage0/lib/package.conf.d/system-cxx-std-lib-1.0.conf
| Copy file: llvm-targets => _build/stage0/lib/llvm-targets
| Run GhcPkg Dependencies (Stage0 InTreeLibs): base
| Copy file: llvm-passes => _build/stage0/lib/llvm-passes
| Run GhcPkg Dependencies (Stage0 InTreeLibs): base
| Run GhcPkg Dependencies (Stage0 InTreeLibs): ghc-prim
# cabal-autogen (for _build/stage0/utils/unlit/build/unlit/autogen/cabal_macros.h)
| Run GhcPkg Dependencies (Stage0 InTreeLibs): ghc-bignum
| Run GhcPkg Dependencies (Stage0 InTreeLibs): ghc-prim
| Run Cc (FindCDependencies CDep) (Stage0 InTreeLibs): utils/unlit/fs.c => _build/stage0/utils/unlit/build/c/fs.o.d
| Run Ghc CompileCWithGhc (Stage0 InTreeLibs): utils/unlit/unlit.c => _build/stage0/utils/unlit/build/c/unlit.o
| Run GhcPkg Dependencies (Stage0 InTreeLibs): ghc-bignum
| Run Ghc CompileCWithGhc (Stage0 InTreeLibs): utils/unlit/fs.c => _build/stage0/utils/unlit/build/c/fs.o
| Configure package 'parsec'
| Successfully generated _build/stage0/lib/settings.
| Configure package 'ghc'
| Configure package 'hpc'
| Configure package 'ghci'
| Configure package 'Cabal'
| Run GhcPkg Dependencies (Stage0 InTreeLibs): rts
| Run GhcPkg Unregister (Stage0 InTreeLibs): rts => none
# cabal-configure (for _build/stage0/libraries/transformers/setup-config)
| Run Cc (FindCDependencies CDep) (Stage0 GlobalLibs): utils/unlit/unlit.c => _build/stageBoot/utils/unlit/build/c/unlit.o.d
# cabal-autogen (for _build/stageBoot/utils/unlit/build/unlit/autogen/cabal_macros.h)
| Run Ghc CompileCWithGhc (Stage0 GlobalLibs): utils/unlit/unlit.c => _build/stageBoot/utils/unlit/build/c/unlit.o
| Run GhcPkg Recache (Stage0 InTreeLibs): none => none
| Run GhcPkg Dependencies (Stage0 InTreeLibs): rts
| Run GhcPkg Unregister (Stage0 InTreeLibs): rts => none
| Configure package 'process'
| Configure package 'directory'
# cabal-configure (for _build/stage0/utils/hp2ps/setup-config)
| Run GhcPkg Copy (Stage0 InTreeLibs): rts => _build/stage0/lib/package.conf.d/rts.conf
| Run Ghc LinkHs (Stage0 InTreeLibs): _build/stage0/utils/unlit/build/c/fs.o (and 1 more) => _build/stage0/bin/x86_64-unknown-linux-musl-unlit
Command line: /nix/store/4gqivrz4j75995gpf2qr930sgscp9yz6-ghc-binary-9.2.4/bin/ghc -Wall -Wcompat -hisuf hi -osuf o -hcsuf hc -static -hide-all-packages -no-user-package-db '-package-env -' '-package-db _build/stage0/lib/package.conf.d' '-this-unit-id unlit-0.1' -i -i/build/ghc-a5bd0eb/_build/stage0/utils/unlit/build -i/build/ghc-a5bd0eb/_build/stage0/utils/unlit/build/unlit/autogen -i/build/ghc-a5bd0eb/utils/unlit -I_build/stage0/utils/unlit/build -optP-include -optP_build/stage0/utils/unlit/build/unlit/autogen/cabal_macros.h -outputdir _build/stage0/utils/unlit/build -fdiagnostics-color=always -no-auto-link-packages -no-hs-main -optc-Wno-error=inline -optP-Wno-nonportable-include-path _build/stage0/utils/unlit/build/c/fs.o _build/stage0/utils/unlit/build/c/unlit.o -o _build/stage0/bin/x86_64-unknown-linux-musl-unlit -O -H64m -XHaskell2010 -optl -static
===> Command failed with error code: 1
/nix/store/frh9l9nrdysasdi2gs7i241s241ngjw2-binutils-2.39/bin/ld: cannot find -lc: No such file or directory
collect2: error: ld returned 1 exit status
`gcc' failed in phase `Linker'. (Exit code: 1)
]0;Finished in 2.34sCommand failed
Build failed.

Full log:
static-ghc-head-log.txt

pkgsStatic.buildPackages.haskell.compiler.gc96 now fails with
x86_64-unknown-linux-musl-ghc> 0;Finished in 25m21sError, rule finished running but did not produce file:
x86_64-unknown-linux-musl-ghc>   _build/stage1/lib/x86_64-linux-ghc-9.6.2/libHSrts-1.0.2_thr_debug-ghc9.6.2.so
x86_64-unknown-linux-musl-ghc> Build failed.

We probably need to use a newer ghc for bootstrapping.

Your welcome to try that, I believe it's probably a bug in hadrian for 9.6.

How could I reproduce this locally?

Build pkgsStatic.buildPackages.haskell.compiler.ghc96.

Reproducing this outside of nixpkgs may be difficult if that's what you are asking, since you won't have cc-wrapper (a shell wrapper around gcc/clang which does a couple of things for us), so things will probably work out differently.
My currently inclination is that the bug would show itself like this:

You have built hadrian with finalStage = Stage1 in UserSettings.hs
You pass --flavour=release+fully_static+no_dynamic_ghc+split_sections --bignum=gmp
Hadrian still builds/tries to build shared objects for libraries like rts.

This issue is somehow solved in 9.8, so maybe looking at the commit history for hadrian may also have some hints. If there are no plans for a 9.6.5, I don't think it is worth investigating though.

@sternenseemann this is the default ghc for nixos-24.05, so I'd really like this to be fixed.
I like my static builds :D

Static builds via the intended interface (pkgsStatic) use GHC 9.4.8 on unstable and 24.05 which works fine.

@sternenseemann that would require me to support two different ghc versions depending on whether I want to statically link.
Can we get static linking work with ghc-9.6.5?

Edit: Actually that doesn't work when using template haskell so I still need a real fix.

The magic/hacky solution for static TemplateHaskell no longer works with GHC >= 9.6, probably due to Hadrian as well. Hence, we are using GHC 9.4 by default which has none of these problems.
We have some leads (https://github.com/NixOS/nixpkgs/issues/275304), but no solution has presented itself so far.

@sternenseemann are you sure it's not > 9.6 instead of >= 9.6 because I still saw the old error described here: https://cs-syd.eu/posts/2024-04-20-static-linking-haskell-nix

I don't know. It seems likely though that were it possible to build 9.6 without dynamic libs, the same sort of problem would crop up as with 9.8.

I wasn't going to say anything, but there is a small chance it's relevant. I have a devenv (not pure nix) project I was trying to build with ghc 9.8 today and despite having postgresql in the dependencies I get:
`cc' failed in phase `Linker'. (Exit code: 1) /nix/store/v71nlgkf8g6d36gac9r44pmlx54mdql3-binutils-2.41/bin/ld.gold: error: cannot find -lpq

It seems possible this is related to dynamic/static libs, but I haven't tried reproducing with vanilla nix to verify.

@sternenseemann are you sure it's not > 9.6 instead of >= 9.6 because I still saw the old error described here: https://cs-syd.eu/posts/2024-04-20-static-linking-haskell-nix

I just got it working with 9.6.5 in https://github.com/NixOS/nixpkgs/issues/316850#issuecomment-2146987857
Can we backport this fix?

That patch seems like a no-brainer build system bug fix, so it would be acceptable to backport.

@sternenseemann How would I go about applying that ? I've only had terrible experiences with nixpkgs contributions and I don't have commit access. Could you apply it?

While we're working on fixing this in #317175, you can work around this problem like this:
                  ghc.override {
                    # To make sure that executables that need template
                    # haskell can be linked statically.
                    enableRelocatedStaticLibs = true;
                    enableShared = false;
                    enableDwarf = false;
                    # Until https://github.com/NixOS/nixpkgs/pull/317175
                    srcOnly = args: pkgs.srcOnly (args // {
                      patches = (args.patches or [ ]) ++ [
                        (final.fetchpatch {
                          url = "https://gitlab.haskell.org/ghc/ghc/-/commit/1bb24432ff77e11a0340a7d8586e151e15bba2a1.diff";
                          hash = "sha256-MpvTmFFsNiPDoOp9BhZyWeapeibQ77zgEV+xzZ1UAXs=";
                        })
                      ];
                    });
                  }

Should this be closed by the merged #317175 ?

#275304 remains.


[1.3.5-prepare][Fix-3298][K8s]Fix task log disappear after recreating or upgrading helm release

Tips

Thanks very much for contributing to Apache DolphinScheduler.
Please review https://dolphinscheduler.apache.org/en-us/community/index.html before opening a pull request.

What is the purpose of the pull request
Fix task log disappear after recreating or upgrading helm release
This closes #3298
Brief change log

Alter column host varchar(15) to varchar(135) for long host
Support to get hostname under kubernetes
Fix task log disappear after recreating or upgrading helm release

Verify this pull request
(Please pick either of the following options)
This change added tests and can be verified as follows:
(example:)

Manually verified the change by testing locally.

Video check: https://github.com/chengshiwen/dolphinscheduler-test/blob/master/fix-k8s-3298.mp4?raw=true

Codecov Report

:exclamation: No coverage uploaded for pull request base (1.3.5-prepare@223fe99). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             1.3.5-prepare    #4703   +/-   ##
================================================
  Coverage                 ?   37.20%
  Complexity               ?     2594
================================================
  Files                    ?      449
  Lines                    ?    20310
  Branches                 ?     2460
================================================
  Hits                     ?     7556
  Misses                   ?    12035
  Partials                 ?      719

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 223fe99...5a19a3b. Read the comment docs.

good job
don't forget to submit this PR  to dev

@dailidong Got it


PP 11978 Remove redundant pre-filled payment link error classes

PP-11978 Prevent pre-filled payment link errors displaying in Sentry.
https://payments-platform.atlassian.net/browse/PP-11978
Summary of changes

Remove redundant error classes as error page now handled in pre-payment controller.
Reword log messages for pre-filled payment link errors as error classes no longer available. For example:
"message":"Invalid prefilled reference error handled: Invalid reference: <>. Rendering problem page"
"message":"Invalid prefilled amount error handled: Invalid amount: not-valid. Rendering problem page"
Set new error page rendered status to 400.
Update unit tests to reflect the above.

Can you squash commits before merging please.


Wrong image on docker hub

Hello,
The latest docker hub image mazzolino/restic updated yesterday do not match the content of this repository.
Moreover, there has been no recent commits on this repository mandating an update of the docker hub image.
The image pushed on docker hub seems to match the content of the djmaze/crystal-sync repository.

Woah, what an embarassment. Turns out I accidentally pushed to the wrong repository. Really sorry, I just triggered a new build so the image is now correct again.
Sorry for the mess and @ymph very good catch, thank you!


Access to props list

i.e.
prop children

<div {...props} > { children } </div>

By "access to props list", do you mean access to all the passed in props, as opposed to access to individual props?

I want whole {...props}

The problem with providing access to all props is the factories prop is in there, but it would make sense to have access to everything else.
How about changing the format so instead of specifying each prop on a separate line, probs are specified as a single line, using ES6 destructuring syntax?
// Access individual props
props { prop1, prop2, ...other }

// If you specify how to destructure, everything is accessible under `props`
props

:+1:


router.push vs router.replace

I have issues with react-router-relay and router.replace(). If I use router.replace(), I get this error:
Warning: RelayContainer: component MinifiedPanel was rendered with variables that differ from the variables used to fetch fragment user. The fragment was fetched with variables (not fetched), but rendered with variables {}. This can indicate one of two possibilities:

The parent set the correct variables in the query - MinifiedPanel.getFragment('user', {...}) - but did not pass the same variables when rendering the component. Be sure to tell the component what variables to use by passing them as props: <MinifiedPanel ...  />.

If I replace it with router.push() the warning is gone and data are fetched.

There's literally no difference between the two except for the use of replaceState v pushState in history. Most likely you have some other sort of bug in your app.


load graphML - identify attributes to convert to float.

Problem Statement
Around the private methods for converting the datatypes of a few attributes on load, there are only  a small subset of attributes that are converted. If someone adds attributes or custom edge weights, they come in as objects by default. There is also no way to adjust which attributes have conversions attempted.
Solution
It would be great to see two possible solutions:

Ideally, data types of attributes converted to graphML could be preserved. This might be hard to achieve in practice. At minimum, a dictionary could be passed as an optional attribute to the load function.
Quick fix, perhaps the set being used to determine attributes to attempt float conversions with could be a parameter.

A clear and concise description of what you want to change in OSMnx and how you plan to implement it.
Alternatives Considered
I think the easiest approach outside of this is converting the nodes & edges to GDF, and doing .astype() conversions there.
Minimum Viable Solution
Example with nodes. Granted, edges could be similar, but is clearly more complicated. These changes would be passed up to the load graphML method (for nodes/edges separately). Notebook examples have graphML as the preferred option, so I want to find ways to address limitations.
def _convert_node_attr_types(G, node_type, num_attr = {"elevation", "elevation_res", "lat", "lon", "x", "y"}):
    """
    Convert graph nodes' attributes' types from string to numeric.
    Parameters
    ----------
    G : networkx.MultiDiGraph
        input graph
    node_type : type
        convert node ID (osmid) to this type
    num_attr : set
        attributes to attempt a cast to float for
    Returns
    -------
    G : networkx.MultiDiGraph
    """
    for _, data in G.nodes(data=True):
        # convert node ID to user-requested type
        data["osmid"] = node_type(data["osmid"])

        # convert numeric node attributes from string to float
        for attr in num_attr:
            if attr in data:
                data[attr] = float(data[attr])

    return G

a dictionary could be passed as an optional attribute to the load function

I think this seems the most straightforward, and could mimic pandas's dtypes argument when loading a file as a DataFrame. Adding an optional attr_types argument to the load_graphml function would be a straightforward fix and allow users to specify exactly what they'd like converted and how, upon load.

Agreed. I tried this on my end as an "extension" of the library, and I think the dtypes argument would be an ideal solution. If we could store it as a global graph attribute I think similarly to how the CRS (I think) is in the save method that would abstract a lot of this away, but I am not sure this is necessary.
For now, I think providing the dtypes options to the load method makes sense. Do you have efficiency concerns with converting to GDF if someone uses the dtypes argument (IE converting to GDF theoretically)? Or do you want to keep it pure python?
I have some time to kill, so happy to kick around a PR if this is something you are interested in. I have my own workaround for now though. Just wanted to raise this as an issue as it is the preferred approach for graph loading for the library.

Do you have efficiency concerns with converting to GDF if someone uses the dtypes argument (IE converting to GDF theoretically)? Or do you want to keep it pure python?

Can you clarify what you mean by that? I didn't understand.
And yes, a PR would be great. Thanks!

Sure sorry. If we use the dtypes as a passed parameter, my assumption was we would use the graph_to_gdfs function to convert additional graph attributes to desired dtypes. Currently, the private conversion functions are using pure python to cast to float, but in my head the easy way to implement this is:

If there is a passed dtypes parameter that is not None, convert the graph to gdf.
Use astype() methods to convert to the appropriate dtype
Convert gdfs back to a graph

Did you have another approach in mind I guess is my question?

I think something like this would be straightforward and efficient:
node_dtypes = None #default argument

if node_dtypes is None:
    # default node_dtypes to mimic current functionality
    node_dtypes = {"elevation": float,
                   "elevation_res": float,
                   "lat": float,
                   "lon": float,
                   "x": float,
                   "y": float}

for attr_name, dtype in node_dtypes.items():
    attrs = nx.get_node_attributes(G, attr_name)
    attrs_converted = {node: dtype(value) for node, value in attrs.items()}
    nx.set_node_attributes(G, attrs_converted, name=attr_name)

...and similar for the edges.

Something like this makes sense. Let me test something like this out.
I think we might want to assume node_dtypes will always be included in addition to passed parameters. Easy to accommodate with a dictionary update method.

@d-wasserman just curious, any update on this?

I did start working on this on my fork, but other timelines got in the way. I can reprioritize it this week if you want it in an update.

@gboeing - point of clarification
Is there any reason why length is converted to float separately from the rest off the attributes on line 285 of io.py?
        # parse length to float: should always have only 1 value
        data["length"] = float(data["length"])

Yeah it can be consolidated. Thanks!

Excellent. This is my first draft. Going to do some actual tests later.

Great! Could you open a PR for your work in progress?

Will do after some minor doc string edits. Thanks.


Added more constants, for telemetry use...

...missing some but this is the fullest list I could find, known to be missing Mirado car on Miramar, 3X, 6X, and all newer grips as well as anything Sanhok related (QBZ etc..)
wasn't sure if you want this added, or if this is how/where you would add it, but I find it useful and couldn't see it anywhere already.

Hey this is a good idea and something I've been thinking about. Seeing as how the Telemetry object classes are generic I was thinking it might make more sense to wrap all of this into one mapping. Also I've been thinking about providing a flag in the telemetry classes that would do this automatically. Still thinking about how to implement this.
Additionally it might be good to have functionality to update this mapping by downloading files from the pubg asset repository (similar to the map update functionality I recently added), so maybe it's better to have a json file separate from other code. I'll think about this over the weekend

Referring to this https://github.com/pubg/api-assets

Sounds like you have a better and more complete plan.
I'll keep my version for now, but look forward to what you come out with.
Thank you.

@CemuUser8 v0.4.0 has the changes mentioned above


Use the module_enabled flag for all resources

Currently, the module_enabled flag is ignored for the mig-health-check resources and only the http_health_check flag is used. This merge request will change that behaviour and make the module use both variables.

I signed it!

On 11 Dec 2018, at 14:33, googlebot<EMAIL_ADDRESS>wrote:
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.
What to do if you already signed the CLA
Individual signers
It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data https://cla.developers.google.com/clas and verify that your email is set on your git commits https://help.github.com/articles/setting-your-email-in-git/.
Corporate signers
Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot http://go/cla#troubleshoot (Public version https://opensource.google.com/docs/cla/#troubleshoot).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data https://cla.developers.google.com/clas and verify that your email is set on your git commits https://help.github.com/articles/setting-your-email-in-git/.
The email used to register you as an authorized contributor must also be attached to your GitHub account https://github.com/settings/emails.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/GoogleCloudPlatform/terraform-google-managed-instance-group/pull/35#issuecomment-446186693, or mute the thread https://github.com/notifications/unsubscribe-auth/AfYfuab9iyEi2UsoSeZekGeYEaNcX0QQks5u36YRgaJpZM4ZNUF2.

#36

LGTM, thanks!


Search bar not working properly

Describe the bug
Search bar is does not work once we go to demographics or essential part and come back to home
To Reproduce
Steps to reproduce the behavior:

Go to demographics
Again come back to home
type something in search bar it won't work

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Duplicates #2032


Dashboard 1.7.0

https://github.com/kubernetes/dashboard/releases/tag/v1.7.0

ref: https://github.com/kubernetes-incubator/kube-aws/pull/962

Closed in #971


Suboptimal behavior when merging two existing dirs in Thunar

OS: Xubuntu 16.04.1 LTS
File Manager: Thunar 1.6.10
Operation:
Moving ~/OneDrive/Temp3 to ~/OneDrive/Temp/Temp3 while the latter already exists. A sequence of CREATE + CLOSE_WRITE events were generated and some resulting tasks can be squashed.
[2017-01-15 00:06:39,895] DEBUG: MainThread: Received inotify events. Acquiring lock.
[2017-01-15 00:06:40,100] DEBUG: MainThread: Read the following events: [(Event(wd=42, mask=256, cookie=0, name='bleak-master(1).zip'), [<flags.CREATE: 256>]), (Event(wd=42, mask=8, cookie=0, name='bleak-master(1).zip'), [<flags.CLOSE_WRITE: 8>]), (Event(wd=11, mask=512, cookie=0, name='bleak-master(1).zip'), [<flags.DELETE: 512>]), (Event(wd=42, mask=256, cookie=0, name='10000000_442807892562214_1904308438_n.pdf'), [<flags.CREATE: 256>]), (Event(wd=42, mask=8, cookie=0, name='10000000_442807892562214_1904308438_n.pdf'), [<flags.CLOSE_WRITE: 8>]), (Event(wd=11, mask=512, cookie=0, name='10000000_442807892562214_1904308438_n.pdf'), [<flags.DELETE: 512>]), (Event(wd=11, mask=32768, cookie=0, name=''), [<flags.IGNORED: 32768>]), (Event(wd=1, mask=1073742336, cookie=0, name='Temp3'), [<flags.DELETE: 512>, <flags.ISDIR:<PHONE_NUMBER>>])].
[2017-01-15 00:06:40,101] INFO: MainThread: Unhandled inotify event Event(wd=42, mask=256, cookie=0, name='bleak-master(1).zip') on local path "/home/xb/OneDrive/Temp/Temp3/bleak-master(1).zip". Flags: flags.CREATE.
[2017-01-15 00:06:40,101] INFO: MainThread: Local path "/home/xb/OneDrive/Temp/Temp3/bleak-master(1).zip" was updated on Event(wd=42, mask=8, cookie=0, name='bleak-master(1).zip'). Merge the parent directory.
[2017-01-15 00:06:40,102] DEBUG: MainThread: Adding task MergeDirectoryTask(/home/xb/OneDrive/Temp/Temp3)...
[2017-01-15 00:06:40,102] INFO: MainThread: Local path "/home/xb/OneDrive/Temp3/bleak-master(1).zip" was deleted on Event(wd=11, mask=512, cookie=0, name='bleak-master(1).zip').
[2017-01-15 00:06:40,105] DEBUG: MainThread: Starting new HTTPS connection (1): api.onedrive.com
[2017-01-15 00:06:40,105] DEBUG: Worker-0: Acquired task MergeDirectoryTask(/home/xb/OneDrive/Temp/Temp3).
[2017-01-15 00:06:40,107] DEBUG: Worker-0: Removing watcher for "/home/xb/OneDrive/Temp/Temp3"
[2017-01-15 00:06:40,228] DEBUG: MainThread: https://api.onedrive.com:443 "GET /v1.0/drives/drive_id/root:/Temp3/bleak-master(1).zip: HTTP/1.1" 200 1339
[2017-01-15 00:06:40,230] INFO: MainThread: Will remove item "/Temp3/bleak-master(1).zip" in Drive drive_id.
[2017-01-15 00:06:40,231] DEBUG: MainThread: Adding task DeleteRemoteItemTask(/home/xb/OneDrive/Temp3/bleak-master(1).zip, is_folder=False)...
[2017-01-15 00:06:40,231] INFO: MainThread: Unhandled inotify event Event(wd=42, mask=256, cookie=0, name='10000000_442807892562214_1904308438_n.pdf') on local path "/home/xb/OneDrive/Temp/Temp3/10000000_442807892562214_1904308438_n.pdf". Flags: flags.CREATE.
[2017-01-15 00:06:40,231] INFO: MainThread: Local path "/home/xb/OneDrive/Temp/Temp3/10000000_442807892562214_1904308438_n.pdf" was updated on Event(wd=42, mask=8, cookie=0, name='10000000_442807892562214_1904308438_n.pdf'). Merge the parent directory.
[2017-01-15 00:06:40,231] DEBUG: MainThread: Adding task MergeDirectoryTask(/home/xb/OneDrive/Temp/Temp3)...
[2017-01-15 00:06:40,232] INFO: MainThread: Local path "/home/xb/OneDrive/Temp3/10000000_442807892562214_1904308438_n.pdf" was deleted on Event(wd=11, mask=512, cookie=0, name='10000000_442807892562214_1904308438_n.pdf').
[2017-01-15 00:06:40,232] DEBUG: Worker-1: Acquired task DeleteRemoteItemTask(/home/xb/OneDrive/Temp3/bleak-master(1).zip, is_folder=False).
[2017-01-15 00:06:40,233] INFO: Worker-1: Deleting remote item "/Temp3/bleak-master(1).zip".
[2017-01-15 00:06:40,234] DEBUG: Worker-1: Starting new HTTPS connection (1): api.onedrive.com
[2017-01-15 00:06:40,235] DEBUG: MainThread: Starting new HTTPS connection (1): api.onedrive.com
[2017-01-15 00:06:40,342] DEBUG: MainThread: https://api.onedrive.com:443 "GET /v1.0/drives/drive_id/root:/Temp3/10000000_442807892562214_1904308438_n.pdf: HTTP/1.1" 200 1357
[2017-01-15 00:06:40,348] INFO: MainThread: Will remove item "/Temp3/10000000_442807892562214_1904308438_n.pdf" in Drive drive_id.
[2017-01-15 00:06:40,348] DEBUG: MainThread: Adding task DeleteRemoteItemTask(/home/xb/OneDrive/Temp3/10000000_442807892562214_1904308438_n.pdf, is_folder=False)...
[2017-01-15 00:06:40,349] INFO: MainThread: Unhandled inotify event Event(wd=11, mask=32768, cookie=0, name='') on local path "/home/xb/OneDrive/Temp3". Flags: flags.IGNORED.
[2017-01-15 00:06:40,350] DEBUG: MainThread: Removing watcher for "/home/xb/OneDrive/Temp3"
[2017-01-15 00:06:40,350] INFO: MainThread: Local path "/home/xb/OneDrive/Temp3" was deleted on Event(wd=1, mask=1073742336, cookie=0, name='Temp3').
[2017-01-15 00:06:40,353] DEBUG: MainThread: Starting new HTTPS connection (1): api.onedrive.com
[2017-01-15 00:06:40,476] DEBUG: MainThread: https://api.onedrive.com:443 "GET /v1.0/drives/drive_id/root:/Temp3: HTTP/1.1" 200 939
[2017-01-15 00:06:40,479] INFO: MainThread: Will remove item "/Temp3" in Drive drive_id.
[2017-01-15 00:06:40,479] DEBUG: MainThread: Adding task DeleteRemoteItemTask(/home/xb/OneDrive/Temp3, is_folder=True)...
[2017-01-15 00:06:40,480] DEBUG: Worker-0: Starting new HTTPS connection (1): api.onedrive.com
[2017-01-15 00:06:40,588] DEBUG: Worker-0: https://api.onedrive.com:443 "GET /v1.0/drives/drive_id/root:/Temp/Temp3:/children HTTP/1.1" 200 1407
[2017-01-15 00:06:40,594] DEBUG: Worker-0: Local file "/home/xb/OneDrive/Temp/Temp3/10000000_442807892562214_1904308438_n.pdf" is new to OneDrive. Upload it.
[2017-01-15 00:06:40,594] DEBUG: Worker-0: Adding task UploadFileTask(/home/xb/OneDrive/Temp/Temp3/10000000_442807892562214_1904308438_n.pdf)...
[2017-01-15 00:06:40,595] DEBUG: Worker-0: Local file "/home/xb/OneDrive/Temp/Temp3/bleak-master(1).zip" is new to OneDrive. Upload it.
[2017-01-15 00:06:40,595] DEBUG: Worker-0: Adding task UploadFileTask(/home/xb/OneDrive/Temp/Temp3/bleak-master(1).zip)...
[2017-01-15 00:06:40,595] DEBUG: Worker-0: Adding watcher for "/home/xb/OneDrive/Temp/Temp3"
[2017-01-15 00:06:40,595] DEBUG: Worker-0: Acquired task MergeDirectoryTask(/home/xb/OneDrive/Temp/Temp3).
[2017-01-15 00:06:40,596] DEBUG: Worker-0: Removing watcher for "/home/xb/OneDrive/Temp/Temp3"
[2017-01-15 00:06:40,597] DEBUG: Worker-0: Starting new HTTPS connection (1): api.onedrive.com
[2017-01-15 00:06:40,712] DEBUG: Worker-0: https://api.onedrive.com:443 "GET /v1.0/drives/drive_id/root:/Temp/Temp3:/children HTTP/1.1" 200 1407
[2017-01-15 00:06:40,716] DEBUG: Worker-0: Local file "/home/xb/OneDrive/Temp/Temp3/10000000_442807892562214_1904308438_n.pdf" is new to OneDrive. Upload it.
[2017-01-15 00:06:40,716] DEBUG: Worker-0: Adding task UploadFileTask(/home/xb/OneDrive/Temp/Temp3/10000000_442807892562214_1904308438_n.pdf)...
[2017-01-15 00:06:40,717] DEBUG: Worker-0: Local file "/home/xb/OneDrive/Temp/Temp3/bleak-master(1).zip" is new to OneDrive. Upload it.
[2017-01-15 00:06:40,717] DEBUG: Worker-0: Adding task UploadFileTask(/home/xb/OneDrive/Temp/Temp3/bleak-master(1).zip)...
[2017-01-15 00:06:40,717] DEBUG: Worker-0: Adding watcher for "/home/xb/OneDrive/Temp/Temp3"
[2017-01-15 00:06:40,717] DEBUG: Worker-0: Acquired task DeleteRemoteItemTask(/home/xb/OneDrive/Temp3/10000000_442807892562214_1904308438_n.pdf, is_folder=False).
[2017-01-15 00:06:40,717] INFO: Worker-0: Deleting remote item "/Temp3/10000000_442807892562214_1904308438_n.pdf".
[2017-01-15 00:06:40,718] DEBUG: Worker-0: Starting new HTTPS connection (1): api.onedrive.com
[2017-01-15 00:06:40,852] DEBUG: Worker-0: https://api.onedrive.com:443 "DELETE /v1.0/drives/drive_id/items/drive_id!686610 HTTP/1.1" 204 0
[2017-01-15 00:06:40,857] INFO: Worker-0: Deleted remote item "/Temp3/10000000_442807892562214_1904308438_n.pdf".
[2017-01-15 00:06:40,857] DEBUG: Worker-0: Acquired task DeleteRemoteItemTask(/home/xb/OneDrive/Temp3, is_folder=True).
[2017-01-15 00:06:40,857] INFO: Worker-0: Deleting remote item "/Temp3".
[2017-01-15 00:06:40,858] DEBUG: Worker-0: Starting new HTTPS connection (1): api.onedrive.com
[2017-01-15 00:06:40,886] DEBUG: Worker-1: https://api.onedrive.com:443 "DELETE /v1.0/drives/drive_id/items/drive_id!686611 HTTP/1.1" 204 0
[2017-01-15 00:06:40,891] INFO: Worker-1: Deleted remote item "/Temp3/bleak-master(1).zip".
[2017-01-15 00:06:40,891] DEBUG: Worker-1: Acquired task UploadFileTask(/home/xb/OneDrive/Temp/Temp3/10000000_442807892562214_1904308438_n.pdf).
[2017-01-15 00:06:40,891] INFO: Worker-1: Uploading file "/home/xb/OneDrive/Temp/Temp3/10000000_442807892562214_1904308438_n.pdf" to OneDrive.
[2017-01-15 00:06:40,892] DEBUG: Worker-1: Starting new HTTPS connection (1): api.onedrive.com
[2017-01-15 00:06:40,984] DEBUG: Worker-0: https://api.onedrive.com:443 "DELETE /v1.0/drives/drive_id/items/drive_id!686609 HTTP/1.1" 204 0
[2017-01-15 00:06:41,004] INFO: Worker-0: Deleted remote item "/Temp3".
[2017-01-15 00:06:41,006] DEBUG: Worker-0: Acquired task UploadFileTask(/home/xb/OneDrive/Temp/Temp3/bleak-master(1).zip).
[2017-01-15 00:06:41,007] INFO: Worker-0: Uploading file "/home/xb/OneDrive/Temp/Temp3/bleak-master(1).zip" to OneDrive.
[2017-01-15 00:06:41,011] DEBUG: Worker-0: Starting new HTTPS connection (1): api.onedrive.com
[2017-01-15 00:06:41,313] DEBUG: Worker-0: https://api.onedrive.com:443 "PUT /v1.0/drives/drive_id/root:/Temp/Temp3:/children/bleak-master(1).zip/content HTTP/1.1" 201 1402
[2017-01-15 00:06:41,317] DEBUG: Worker-0: Starting new HTTPS connection (1): api.onedrive.com
[2017-01-15 00:06:41,465] DEBUG: Worker-0: https://api.onedrive.com:443 "PATCH /v1.0/drives/drive_id/items/drive_id!686636 HTTP/1.1" 200 1366
[2017-01-15 00:06:41,470] INFO: Worker-0: Finished uploading file "/home/xb/OneDrive/Temp/Temp3/bleak-master(1).zip".
[2017-01-15 00:06:44,290] DEBUG: Worker-1: https://api.onedrive.com:443 "PUT /v1.0/drives/drive_id/root:/Temp/Temp3:/children/10000000_442807892562214_1904308438_n.pdf/content HTTP/1.1" 201 1442
[2017-01-15 00:06:44,298] DEBUG: Worker-1: Starting new HTTPS connection (1): api.onedrive.com
[2017-01-15 00:06:44,468] DEBUG: Worker-1: https://api.onedrive.com:443 "PATCH /v1.0/drives/drive_id/items/drive_id!686637 HTTP/1.1" 200 1398
[2017-01-15 00:06:44,480] INFO: Worker-1: Finished uploading file "/home/xb/OneDrive/Temp/Temp3/10000000_442807892562214_1904308438_n.pdf".
^C[2017-01-15 00:06:57,342] INFO: MainThread: Shutting down.
[2017-01-15 00:06:57,343] DEBUG: Worker-0: Stopped.

[2017-01-15 00:06:57,344] DEBUG: Worker-1: Stopped.
All children are gone. Parent is exiting...

Partially addressed in 94ee573e2f344d12ab6ec90839cee0aaed135c0e.


techdocs-cli serve results in 404 when mkdocs "site_url" is set

Expected Behavior

TechDocs supports MkDocs "site_url" and utilizes the same URL path logic that MkDocs uses.
Actual Behavior

MkDocs site works, but TechDocs site results in a 404 error.
Steps to Reproduce

git clone https://github.com/ericis/test-techdocs-cli-serve
yarn
yarn start -v --no-docker (calls techdocs-cli serve -v --no-docker) *yarn start was also tested
Test each of the hosting URLs output in the console window for both MkDocs and for TechDocs (different)

MkDocs successful output

TechDocs 404 failed output

Context

After running techdocs-cli serve -v --no-docker, the output provides the TechDocs URL "http://localhost:3000/docs/default/component/local/" and this URL in turn makes an XHR request in the browser to the URL "http://localhost:3000/api/techdocs/index.html" which returns a "404 Not Found" error.
Console Log
$ techdocs-cli serve -v --no-docker
info: Starting mkdocs server.
verbose: [mkdocs] INFO     -  Building documentation...
verbose: [mkdocs] INFO     -  Cleaning site directory
info: Waiting for mkdocs server to start...
verbose: [mkdocs] INFO     -  Documentation built in 1.81 seconds
verbose: [mkdocs] INFO     -  [17:39:37] Watching paths for changes: 'C:\Users\[UserName]\AppData\Local\Temp\docs_y8uwz7c4', 'mkdocs.yml', 'src\docs'
verbose: [mkdocs] INFO     -  [17:39:37] Serving on http://<IP_ADDRESS>:8000/catalog/default/component/devex-welcome/docs/
info: [techdocs-preview-bundle] Running local version of Backstage at http://localhost:3000
info: Serving docs in Backstage at http://localhost:3000/docs/default/component/local/
Opening browser.
verbose: [mkdocs] WARNING  -  [17:39:42] "GET /index.html HTTP/1.1" code 404

Related Bugs
This bug was reproduced almost immediately after testing a very recent TechDocs url bug #10362 that has a merged fix and is included in the nightly release. The version of the CLI in the repository's "package.json" file includes this fix in the reproduction of this new bug. The entire context of #10362 was considered in reproducing this bug.
Your Environment

Windows Pro 11

Browser Information: Firefox 99.0.1

Output of yarn backstage-cli info:

n/a (nothing, because this uses @techdocs/cli

I will retest this, but I believe it is still broken


PHP 8 error with eager loading

Summary of problem or feature request
When running on PHP 8 there is an error that occurs when using eager loading.
method_exists(): Argument #1 ($object_or_class) must be of type object|string, array given {"userId":1,"exception":"[object] (TypeError(code: 0): method_exists(): Argument #1 ($object_or_class) must be of type object|string, array given at /vendor/yajra/laravel-datatables-oracle/src/Utilities/Helper.php:160)

Code snippet of problem
$model = \App\Models\User::with([
    'role',
]);
return \DataTables::eloquent($model)
    ->addColumn('role', function (\App\Models\User $user) {
        return $user->role ? $user->role->name : 'N/A';
    })
    ->toJson();

class User extends Authenticatable
{
    use SoftDeletes;
    use Notifiable;

    public function role()
    {
        return $this->belongsTo(Role::class);
    }
}

System details

Operating System: Ubuntu 18.04
PHP Version: 8.0 RC3
Laravel Version: 8.16.1
Laravel-Datatables Version: 9.14.1

There seems seems to be changes on method_exists function on PHP 8 that causes this issue. Will try check this but can't upgrade to PHP 8 yet. If you can, please do not hesitate to submit a PR for PHP 8 support. Thanks!

+1 I have the same issue


Ignored Pylint issue 'consider-using-f-string' in new Pylint 2.11

No review needed.

Coverage remained the same at 35.922% when pulling 4c02e5770eb5fa801d2ac40ad3fd952249073b43 on andy/fix-pylint-f-string into c0584991dbd8af07f1c0ae9fd6def0a418e3ce2b on master.


Removes e2e which duplicates unit test coverage

What this PR does / why we need it:
Follow up from https://github.com/Azure/ARO-RP/pull/2430#discussion_r984763943: I think we already have unit test coverage for this in pkg/api/defaults_test.go.
Test plan for issue:
Run E2E
Is there any documentation that needs to be updated for this PR?
No, just a E2E clean up

I'm wondering if it's useful to have some generic test coverage somewhere to ensure that the flags from the cluster doc actually make their way into the actual CR on the cluster.

We update flags in CR from the RP here: the test will end up being a copy paste of all flags. I think it won't be very useful.

This should check the existence of the resources the MHC controller deploys rather than just checking if it's enabled by default right? That would be an actual e2e test to confirm the resources were successfully created and there wasn't a conflict.

Something along these lines, yes. I created this work item to make sure that HMC resources get re-created after deletion. I think this should be enough.

I'm wondering if it's useful to have some generic test coverage somewhere to ensure that the flags from the cluster doc actually make their way into the actual CR on the cluster.

@cblecker we update flags in CR from the RP here: the test will end up being a copy paste of all flags. I think it won't be very useful.

This should check the existence of the resources the MHC controller deploys rather than just checking if it's enabled by default right? That would be an actual e2e test to confirm the resources were successfully created and there wasn't a conflict.

@bennerv something along these lines, yes. I created this work item to make sure that HMC resources get re-created after deletion. I think this should be enough.


.from() method should not modify key input

Addressed by https://github.com/digitalbazaar/ed25519-multikey/pull/6. Closing.


Restrict proc-macro2 to Version 1.0.86

I noticed that proc-macro2 version 1.0.87 introduced character validation for the Punct struct, resulting in svd2rust panicking like so:
thread 'main' panicked at {me}/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proc-macro2-1.0.87/src/lib.rs:847:13:
unsupported proc macro punctuation character '{'

Temporary solution is holding back proc-macro2 at version 1.0.86. Better solution would probably be representing the { character with a different struct than Punct.

Fixed in #864


No Workspace Edition option on creation

The tutorial instructs to set the workspace edition but it doesn't exist on the create workspace page.

I need to set it to enterprise because ML.NET in VS requires it:

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2caff87f-9f38-988a-12f3-fc96798e3c99
Version Independent ID: 80ab1cdf-282d-29d6-c146-68d1ce8d00b8
Content: Create workspaces in the portal - Azure Machine Learning
Content Source: articles/machine-learning/how-to-manage-workspace.md
Service: machine-learning
Sub-service: core
GitHub Login: @sdgilley
Microsoft Alias: sgilley

@rschiefer we'll review your feedback and get back to you soon. Thanks.

#assign:@peterclu

@rschiefer, thanks for your report. As of September 2020, Enterprise edition and Basic edition have merged. You no longer need to set an edition. You can learn more about the, see What happened to enterprise edition.
I'll update the documentation to clarify this. Thank you!


Text is hard to read in dark mode

I use GitHub set to dark mode. The header text appears very light in that mode. See screenshot:

This fix will be in version 1.3.8, which was submitted for publishing.

Thanks! Looks great now.


Update documentation.md with more essay methods

Thanks! I reformulated it, and will include it in the next version.


Save breaks characters

Check for existing issues

[X] Completed

Describe the bug / provide steps to reproduce it
When I saved the document, some of the text got split into pieces.
This doesn't happen always, but it's the 2nd time I experienced it and it's pretty annoying.
Environment
Zed: v0.116.1 (stable)
OS: macOS 14.2.0
Memory: 16 GiB
Architecture: aarch64
If applicable, add mockups / screenshots to help explain present your vision of the feature

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.
If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.
No response

Hey @vilords - does this happen each time you save this particular file? If you are able to, could you provide this file? No worries if it can't be shared.

See related issue: https://github.com/zed-industries/community/issues/1859


UHF-7195 News feed

UHF-7195

What was done

Installed and configured the helfi_news_feed module

How to install

Make sure your instance is up and running on correct branch.

git fetch --all && git checkout UHF-7195_news_feed

Update the Platform config branch by running the following

composer require drupal/helfi_platform_config:dev-UHF-7195_news_feed
make fresh

How to test

Go to create landing page or basic page
Check that you can add "News list" paragraph in to

[x] Standard page - upper and lower content area
[x] Landing page

[x] Test that the news list paragraph works after you save the changes. It should look like the image below

[ ] Check that code follows our standards

Designers review

[x] This PR does not need designers review
[ ] This PR has been visually reviewed by a designer (Name of the designer)

Other PRs

https://github.com/City-of-Helsinki/drupal-helfi-platform-config/pull/383
https://github.com/City-of-Helsinki/drupal-helfi-kuva/pull/83
https://github.com/City-of-Helsinki/drupal-helfi-kymp/pull/509
https://github.com/City-of-Helsinki/drupal-helfi-asuminen/pull/161
https://github.com/City-of-Helsinki/drupal-helfi-kasvatus-koulutus/pull/249
https://github.com/City-of-Helsinki/drupal-helfi-sote/pull/463
https://github.com/City-of-Helsinki/drupal-helfi-strategia/pull/363
https://github.com/City-of-Helsinki/drupal-helfi-tyo-yrittaminen/pull/159
https://github.com/City-of-Helsinki/drupal-helfi-rekry/pull/103

Works on both pagetypes 💼


Found 2 elements with non-unique id #logout-form

settings:1 [DOM] Found 2 elements with non-unique id #logout-form: (More info: https://goo.gl/9p2vKq) <form id="logout-form" action="http://dashboard.test/logout" method="POST" style="display: none;">… <form id="logout-form" action="http://dashboard.test/logout" method="POST" style="display: none;">…

@ser-tec I did not get the issue. Could you please explain?


Hex-encode binary peer ID in logs.

We shouldn't log out binary data into log files. Resolves #106.

/cc @plwhite


compatibility with d3.js version 4?

I was just trying to investigate whether d3.chart will be compatible with d3.js version 4, and I've not yet found the answer. My concern is that the change to immutable selections may have implications for d3.chart, but I'm just not sure!
First I tried creating a sample bl.ock but got this when adding d3.chart on top of the default d3 v4 distribution:

So then I made a local clone of d3.chart in order to comment out the version check, and I decided it'd be good to start with trying to run the tests in both versions. After installing all deps, ran tests successfully with the specified npm and bower d3 v3 deps. Then installed d3 v4 via both npm and bower and tests errored out with Warning: PhantomJS timed out, possibly due to a missing Mocha run() call. Use --force to continue. I started digging into this a bit, and it looks like the first problem is changes in how d3 is exposed through the bower dist. I fiddled around a bit with how test/index.html is pulling in the bower dep, but couldn't get it to work within the timeframe I had for investigation.
Would love to know whether you've investigated the upgrade to d3 v4 yet or what your timeline is for doing so if not. Thanks!

I have been working in my spare time on a v4 retro-fit and currently have it passing 75% to 80% of unit tests. I will submit a PR after I finish it for good, unless someone beats me to it.

Awesome @jgalb! When you have a PR, I'd be happy to test it out with our code as well, see if there are any gotchas not caught by tests, so perhaps ping me when you open it?

@jebeck, absolutely, I will keep you posted.

@jgalb Last I looked (maybe Saturday?) d3-chart was using a simple RegEx comparison against d3.version to check if it's v3 or not and complain about it.
This could be approved upon I think.
Besides that, if you have branch/repo you work on we can help too?

@andreas-marschke Yes, that is the first error you will run into trying to run d3 v4 with d3-chart. It should definitely be there since major releases (ex. 4.0.0) will most likely change how d3-chart needs to function.
With the changes to d3-selection as a whole, and addition of d3-merge, there are various changes that need to take place. d3-transition is another module that is now quite a bit different so it's behaving awkwardly.
I will push up a fork once I feel like I am headed in the correct direction. Then we can collaborate.
Thanks

any progress with this @jgalb?
my guess would be the new pattern of immutable selections makes for the biggest changes.

What's the current progress on this? I can also provide help if needed.


Can't work iPadOS(iOS 13.1.2)

iPadOS and MacOS are return same user-agent. So below code is not work well on iPadOS.
https://github.com/timruffles/mobile-drag-drop/blob/2b7ac0a254752ef0207a8e1ed2f573f427ca1c14/src/internal/feature-detection.ts#L17-L23
My workarround is below.
import { polyfill } from 'mobile-drag-drop'
import { scrollBehaviourDragImageTranslateOverride } from 'mobile-drag-drop/scroll-behaviour'

const ua = window.navigator.userAgent.toLowerCase()
const isiPad = ua.indexOf('ipad') > -1 || (ua.indexOf('macintosh') > -1 && 'ontouchend' in document)

const usePolyfill = polyfill({
  forceApply: isiPad, // force apply for ipad
  dragImageTranslateOverride: scrollBehaviourDragImageTranslateOverride || isiPad,
})

if (usePolyfill) {
  document.addEventListener('dragenter', (event) => event.preventDefault())
  window.addEventListener('touchmove', () => {}, { passive: false })
}

Which browsers were you experiencing this on? Our drag-n-drop code broke on iPadOS on Safari only with the latest release.

More context here: https://forums.developer.apple.com/thread/119186

Closing this as it is superseded by https://github.com/timruffles/mobile-drag-drop/issues/167 and a workaround is provided!


Reduce specificity of selectors

Please make sure you're using the latest version of the plugin before submitting an issue ✅
Screenshots

When working in an .mdx file with the latest mdx highlighter, I'm no longer getting highlights for several things which the maintainer of the mdx language highlighter is telling me is due to Night Owl being overly specific in its selectors:

And that’s where we find a very important bug in Night Owl:

Here’s what we expose: markup.heading.atx.1.mdx
Here’s what VS Code Solarized selects: markup.heading
Here’s what Night Owl selects: markup.heading.markdown

Looking at almost all scopes in Night Owl, they are super specific. Specific to JS, or to JSX, or to markdown. And they’re not supposed to be like that, they’re supposed to as vague as possible (markdup.heading), unless you really need to differentiate markup.heading.markdown from others (e.g. markup.heading.html) or so.
So that’s where a lot of the problems come from!
Inline code

GitHub : markup.raw
VS Code Solarized: markup.inline.raw
VS Code Night Owl: markup.inline.raw.markdown

I think this is a weird choice in VS Code themes to go with markup.inline.raw. markup.raw.inline makes more sense, then you can also have markup.raw.block. But I’ve just pushed the name VS Code uses: 60fa64b. Note that Night Owl still should drop the .markdown suffix.

That last comment is the suggestion:

Night Owl still should drop the .markdown suffix.

Could we do that?

@kentcdodds  PR to fix support to mdx files.
Before:

After:

This is merged, will cut a release today.


Automated cherry pick of #6120: fix: sysadmin can override policy violation check

Cherry pick of #6120 on release/3.2.
#6120: fix: sysadmin can override policy violation check

Codecov Report

Merging #6128 into release/3.2 will increase coverage by 0.01%.
The diff coverage is 8.94%.

@@               Coverage Diff               @@
##           release/3.2    #6128      +/-   ##
===============================================
+ Coverage         7.02%    7.04%   +0.01%
===============================================
  Files              644      646       +2
  Lines           110421   110791     +370
===============================================
+ Hits              7756     7801      +45
- Misses          102066   102389     +323
- Partials           599      601       +2

Flag
Coverage Δ

#aFlag
7.04% <8.94%> (+0.01%)
:arrow_up:

Impacted Files
Coverage Δ

pkg/cloudcommon/cronman/cronman.go
53.95% <0.00%> (+3.07%)
:arrow_up:

pkg/cloudcommon/db/caller.go
25.43% <0.00%> (ø)

pkg/cloudcommon/db/fetch.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/opslog.go
1.50% <0.00%> (-0.16%)
:arrow_down:

pkg/cloudcommon/db/owner.go
7.40% <0.00%> (-2.60%)
:arrow_down:

pkg/cloudcommon/db/standalone.go
1.68% <0.00%> (-0.03%)
:arrow_down:

pkg/cloudcommon/policy/policy.go
1.56% <0.00%> (+0.02%)
:arrow_up:

pkg/compute/models/buckets.go
1.17% <0.00%> (ø)

pkg/compute/models/cloudaccounts.go
0.70% <0.00%> (ø)

pkg/compute/models/dbinstance_accounts.go
2.15% <ø> (ø)

... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba6e8a1...ae9838a. Read the comment docs.


refresh timeout incorrectly calculated when the options are passed manually via configure

The constructor of the OAuthService sets the refresh timeout via a call to setupRefreshTimer() which will compute the timeout duration based on the formula (expiration - storedAt) * this.timeoutFactor.
The value of this.timeoutFactor is by default 0.75.
If the options are not set via the constructor parameter but are set via the configure() method later, the refresh timeout is not changed based on the given new timeoutFactor value and the method setupRefreshTimer() is private.
Is it possible to make the setupRefreshTimer() public or to update the refresh timeout after configure() is called ?

I should add this also causes issues with angular-universal
setupRefreshTimer() {
    if (typeof window === 'undefined') {
--> this right here will show in terminal and very hard to track: this.debug('timer not supported on this plattform');
      return;
    }
    if (this.hasValidIdToken() || this.hasValidAccessToken()) {
      this.clearAccessTokenTimer();
      this.clearIdTokenTimer();
      this.setupExpirationTimers();
    }
    if (this.tokenReceivedSubscription) this.tokenReceivedSubscription.unsubscribe();
    this.tokenReceivedSubscription = this.events.pipe((0,rxjs_operators__WEBPACK_IMPORTED_MODULE_3__.filter)(e => e.type === 'token_received')).subscribe(_ => {
      this.clearAccessTokenTimer();
      this.clearIdTokenTimer();
      this.setupExpirationTimers();
    });
  }


warning - cannot continue in framework  .NET 4 (And I don't want to change it)

Hi,
I all the time get this warning:
 Warning	1	The primary reference "Google.Apis" could not be resolved because it has an indirect dependency on the framework assembly "System.Net.Http, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" which could not be resolved in the currently targeted framework. ".NETFramework,Version=v4.0". To resolve this problem, either remove the reference "Google.Apis" or retarget your application to a framework version which contains "System.Net.Http, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a".	C:\Windows\Microsoft.NET\Framework\v4.0.30319\Microsoft.Common.targets	1605	5	GoogleApps

any idea what should I do?

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 14 Dec 2014 at 10:42

Clean up this is an old question and no more information was supplied by the author.    question should probably have been on stackoverflow


seneca-examples/user-accounts is a good basic test

can you use this to create ab automated test with a running server
see seneca-web for example of doing this

I created unit tests using lab and supertest


Not getting performance improvement for multitasking of intent classification and slot filling

When the model is trained for intent detection and slot filling tasks separately, the performance is higher when the model is trained for both the tasks together. I mean for multitasking, there is no performance gain? Any comments or help how to get the performance gain over single-task model would be highly appreciated?

Did you change/adjust the loss function based on your usecase?


Example:
<img class= "smaller-image" src= "image link">

Hi @HaddadF
Thanks for the report. The issue tracker is for reporting bugs only.
Please use the chat rooms:

HTML/CSS help chat room
JavaScript help chat room
Other Official Rooms

or try looking through our forum for help with a specific challenge.
Happy Coding!

Had same issue in Microsoft Edge Browser. Changed to Chrome and the cat resized fine using same code.


VLAZ: Watch trusted-spot.com

VLAZ requests the watch of the watch_keyword trusted-spot\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

trusted-spot\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.


Tooltip flashes whitespace for a split second before appering

Tooltip creates whitespace after the element on which it is placed near the edge of the browser.
http://makeagif.com/SnaCSS

https://github.com/angular-ui/bootstrap/blob/master/CONTRIBUTING.md#you-think-youve-found-a-bug


feat(input): add github API URL configuration for input

Hello again :) I was moving my workflow from a go install to this action (but you've since pushed 0.6.1 which would not require this) and found that because I'm running on a Github Enterprise appliance the default octokit client would not call github.com to find gflows' releases. (the relevant line is here https://github.com/actions/toolkit/blob/2f164000dcd42fb08287824a3bc3030dbed33687/packages/github/src/internal/utils.ts#L24)
I'm proposing to add an input to override the baseUrl option as the corresponding env variable can not be changed.
Still debating wether it should force github.com as the default though.

Oh, interesting – I didn't know about this behaviour.
@Meroje: Are there reasons to let users override the base URL which I'm missing, however? I would have assumed all users, wherever they run this action, would want the API to be https://api.github.com (since that's where gflows is hosted). In which case, it might be better to just specify that as the baseUrl in the octokit config, and then there's no need for the extra input option. What do you think?

This is exactly what I'm pondering on, we do copy actions we use to our appliance to lower the dependency on github.com so there would even be an argument for overriding event the repo owner/name combo, but I agree the most wanted default is to use api.github.com.

To confirm:

I assume that this action fails on GitHub Enterprise installations? (Do you get a not found error of some kind?)
It sounds like you would still like the option to override the API url if you copy the action to your Enterprise installation?

If so, I think it might make sense to default to api.github.com, since then at least the action works in all cases. To solve for 2) you could keep the input option, and I think override it something like this:
steps:
- uses: jbrunton/setup-gflows@v1
  with:
    token: ${{ secrets.PUB_GITHUB_TOKEN }}
    github-api-url: ${{ env.GITHUB_API_URL }}

Yes that's what happened

Not sure I'd do that, we're only syncing actions at this point (using https://github.com/actions/actions-sync), as long as the tool cache can be used in absence of an answer from github.com

@Meroje: Thanks for clarifying!
If I read your changes correctly (it's late here!) it looks like you amended the PR to default to api.github.com? I left a couple of suggestions if so. I don't mind too much about the conditional, but the description needs updating. Thanks!

I did change the default as you suggested, thanks for the review

Thanks! A few build failures which I think are unrelated to your changes. I'll take a look and see what I need to fix.

@Meroje: Sorry for the delay getting back to you. Would you be kind enough to rebase with latest develop? I think that should address the build errors.

@Meroje: merged and released. Thanks for the PR!


Counter values are stored as str instead of integer

Home Assistant:
0.70.1

Last working Home Assistant release (if known):
Operating environment (Hass.io/Docker/Windows/etc.):
Raspbian

Component/platform:
counter

Description of problem:
Counter values are stored as str instead of integer. As a consequence mathematical operations are not able to be done without using a value template. This leads to errors in components like persistency.py
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
counter:
  espresso_counter:
    step: 1
    icon: mdi:coffee
  washmachine_counter:
    step: 1
    icon: mdi:washing-machine

Traceback (if applicable):

Additional information:

Yes, the state of an entity is stored as string with help of the recorder component. There are different entities and some of them represent numerical values while other have an alphanumerical state. Thus the casting needs to be handled by the template engine.


Switch from BC to Cryptacular

To handle serialization issues for non-serializable objects that hold references to public/private keys for signing and encryption, once Cryptacular becomes GA available.

https://github.com/Jasig/spring-webflow-client-repo/blob/master/pom.xml#L153


Fix misuse of PublicKeyCallback

Only upgrading the ssh package is not enough.

I was unable to create a backport for 1.22. @wxiaoguang, please send one manually. :tea:
go run ./contrib/backport 32810
...  // fix git conflicts if any
go run ./contrib/backport --continue

Do some improvements for 1.23:  Fine tune ssh related comments and code #32846


Rental finder - Screen reader focus

User Story:
As a…. Person using a screen reader on the “Find rentals for you” page
I want…screen reader focus to land at the beginning of content for each section of the form
So that…I can easily consume information in the order it is presented on the page
Additional detail:
These changes should be made on Desktop and Mobile
Currently, screen reader focus is landing on the bottom of the page
Detail from live QA session with LH is outlined here
Design Asset Documentation:
Required (Y/N) N
Technical Notes Link:
Change to UI components? (Y/N)
Acceptance criteria:
Given that I am a person using a screen reader on desktop
When I navigate to each page on the rental finder form
Then my screen reader focus lands at the beginning of content for that page
Given that I am a person using a screen reader on mobile
When I navigate to each page on the rental finder form
Then my screen reader focus lands at the beginning of content for that page
QA review instructions:
(Desktop testing instructions)
(Mobile testing instructions)

Note: This is only present in NVDA, and will require brewer stack’s beta nvda screen reader. Therefore, might require extra time

This looks good at https://detroit-public-dev.netlify.app/finder - closing!


Suggested new text to be added to the RTD documentation

The file
https://asdf.readthedocs.io/en/stable/_sources/asdf/extensions.rst.txt
has the following hidden code after the presentation of the first YAML code block of the "An Example" subsubsection:
.. runcode:: hidden

    import os
    import asdf
    # This is a hack in order to get the example below to work properly
    __file__ = os.path.join(asdf.__path__[0], 'tests', 'data', 'fraction-1.0.0.yaml')

This hidden code has important information for the reader. Specifically, the YAML code block needs to be saved in the local working directory with the filename of "fraction-1.0.0.yaml" in order for the example to perform properly in a local working directory of their own choosing.
I suggest that this new note be added to to the file
https://asdf.readthedocs.io/en/stable/_sources/asdf/extensions.rst.txt
just after the first YAML code block is presented (i.e., before the text "Then, the Python implementation of the tag class and extension class."):
.. note::

    The above YAML code needs to be saved in the local working directory with the
    filename of "fraction-1.0.0.yaml" in order for this example to perform properly.

The addition of this note should make life easier for the eager reader trying to replicate the results presented in the RTD documentation in a local working directory of their own choosing.

Please feel free to contribute these changes by opening a pull request against asdf.

Should I make the changes to version 2.7.5 or to master?
I refer above to the file extensions.rst which is version 2.7.5.  The closest to that file that I can find in version 2.10.1 is ```legacy.rst`` which is for the section "Deprecated extension API".
The online RTD documention at the GitHub repository at https://github.com/asdf-format/asdf is linked to http://asdf.readthedocs.io/ which points to https://asdf.readthedocs.io/en/stable/ .
The latest RTD documentation (https://asdf.readthedocs.io/en/latest/) is version 2.10.1 -- unfortunately that documentation is not as easily visible as the 2.7.5 (stable) version.

@KenMighell I am closing this issue, please feel free to re-open it if you wish to discuss this further.


Documentation for release 1.5 to sync zh

This issue is to track documents which needs to sync zh for release 1.5:

#268
#279

/assign


SDK: move game structs to new dir, seperated by known filenames

Hey, wanted to get your thoughts on this, the Game.h seemed to be filling up (and will probably get even bigger soon :p), so figured we should probably split it up.
Tried separating things here by filenames I've seen in the symbols, 90% of these are actual header names the game used, but some I only saw as .cpp/.c and figured there was probably a .h for it too.
Do you think separating like this is fine, or is it maybe a bit too far? We aren't a decompilation project or anything like that so maybe naming stuff like this is a bit useless... there are a couple files in here which pretty much just have a single struct inside too, maybe more could be added later too, but not sure.
It might be convenient though since the symbols can be split into .cpp files pretty easily, so can pretty much just use the same filename that a struct was found inside (the symbols don't actually say which header a struct belongs to though, mainly just what .cpp/.c/.obj some code was from, so have to guess it from that... should be close enough though)
Also updated some of the structs with the new findings, need to make sure that things still match up/work as we expect before merging though (mostly seems to be fine from what I checked, but wouldn't be surprised if some offset got broken somewhere...)

Do you think separating like this is fine, or is it maybe a bit too far?

Nah, this is fine, actually. I was trying to think of ways of splitting Game.h somehow, but your solution is better than anything I came up with. Thanks for that!

Also updated some of the structs with the new findings, need to make sure that things still match up/work as we expect before merging though (mostly seems to be fine from what I checked, but wouldn't be surprised if some offset got broken somewhere...)

Ah, cool. I'll do some testing later, then.

Everything seems to be working just fine. I'll go ahead and merge this, so I can push a fix for #309 without creating conflicts with this PR.
If you have anything you want to change here, feel free to just push it to master directly, as I believe you have access to do that now :p


Recent Visual Studio updates broke label analysis

Label analysis is completely broken.

Asm Dude v<IP_ADDRESS>
Visual Studio 2017 v15.7.2

same issue here.

why do i keep getting linked to random github threads...

I'm getting this too, really annoying...

Thank you for waiting and for for bringing this to my attention. I has been fixed in the next version after <IP_ADDRESS>.
In the upgrade from VS 14.6 to 14.7 something has changed. I hoped I would fix itself with a new VS update, but it didn't.


adds infinite scroll and touch events and dot indicators

Thank you for the helpful code, I also added touch events along with dots to indicate which slide is active

@xuelink I ran npm run check, which runs prettier locally and it updated multiple files. Would you like me to commit those changes to this branch?

@xuelink Thanks!


Split c files

This is not a complete job yet, but paves a road forward.
There is some naming inconsistencies, that I've not done anything about. Example
Here the IsolatePtr references a v8 class
typedef v8::Isolate Isolate;
typedef Isolate IsolatePtr

Here the ContextPtr references a wrapper type in the v8go C++ code.
typedef struct m_ctx m_ctx;
typedef m_ctx ContextPtr

And then there, a v8go C++ struct ScriptCompilerCachedData but a ScriptCompilerCachedDataPtr pointing to a v8 type.
typedef v8::ScriptCompiler::CachedData* ScriptCompilerCachedDataPtr;

typedef struct {
  ScriptCompilerCachedDataPtr ptr;
  const uint8_t* data;
  int length;
  int rejected;
} ScriptCompilerCachedData;

I don't think the Ptr is really useful here though. It seems that the XyzPtr types are needed for Go code; it wouldn't compile when I just created a *v8Isolate in Go alone - but I could have made a mistake.
At any rate I would consider adopting a style like this:
#idfef __cplusplus
typedef v8::Isolate v8Isolate;
#else
typedef struct v8Isolate v8Isolate
#endif
typedef Isolate v8IsolatePtr

As now it's clear what is a v8 type, and what is v8go type.
Avoid using namespace
The header file has a using namespace v8. That is generally a not-so-good practice. Including a header file shouldn't cause namespaces to be included.
Only include what's needed
The v8go.cc and .h file included the entire v8.h header file. This just includes what's necessary for the particular files; speeding up compilation
Use forward declarations
A type definition of structs/classes doesn't need to know the full definition of used types, just the size in memory. For classes and structs, I've created forward declarations to avoid having to include unnecessary header files.
Some non-trivial have been placed in forward-declarations, mostly as the C++ classes are non-trivial in their forward declarations.
I think there might be tools that can automate header file dependency code, i.e., remove unnecessary includes, add necessary ones, create forward decl. But I have no experience using any of those, so I don't know how they would be set up, and what the are capable and incapable of.

And added a clang config file so the editor should pick the current style on foatting

Ahh, just realised I've made quite the mistake.
I have this checked out under go/src/github/stroiman/v8go, but when I run the test suite, the tests are exercising code under go/src/github/tommie/... 🙈
Code probably works as intended, as I've used it from my own project; which uses the "rewrite" feature of go mod to point to my own version.

I made the original comment:

I don't think the Ptr is really useful here though. It seems that the XyzPtr types are needed for Go code; it wouldn't compile when I just created a *v8Isolate in Go alone - but I could have made a mistake.

But it appears that I did make a mistake, if I forward declare a v8Isolate for instance
#ifdef __cplusplus
namespace v8 { class Isolate } // ...
typedef v8::Isolate v8Isolate
#else
typedef struct v8Isolate v8Isolate
#endif

I can declare/define the functions as
extern v8Isolate* NewIsolate();
// ...
v8Isolate* NewIsolate() { };

Then the Go code is happy with
type Isolate struct {
	ptr *C.v8Isolate
}
func NewIsolate() *Isolate {
	initializeIfNecessary()
	iso := &Isolate{
		ptr: C.NewIsolate(),
		cbs: make(map[int]FunctionCallbackWithError),
	}
}

So I would be in favour of just removing the XyzPtr typedefs.
Wouldn't do it in this PR, just cleanup when working on new functionality.

go vet complains of stdint.h (and stddef.h for size_t) missing in value.h.

Ah thanks, just added them, was heading out the door, so didn't see what errors, were produced. Maybe I'll check up on it later, or tomorrow.

Tests are happy now. This looks great!
Just the question about removing interop.h and the reference to it.

@stroiman pushed 0 commits.

Thank you, GitHub email notification, for letting me know nothing happened. :)


Allow a space between # and region for folding in Python

Automatic formatting inserts a space between the comment marker # and text in the Python extension, so without the allowance for whitespace then "editor.formatOnType": true breaks all region markers.
Closes Microsoft/vscode-python#1073 and Microsoft/vscode-python#33

Thanks @brettcannon !

@aeschli Welcome! Thanks for helping me close out 2 issues on our own repo. 😄


backwords compatibility

Hello,
I am trying to 'dumb' this down to work with T6800 that does not have an 'away' mode. I am not sure that this is the exact issue I am having, but base on the error - this is my issue.
I will add the adjusted file to custom_components.
If you have a chance, I would appreciate any assistance. The description is here - https://community.home-assistant.io/t/venstar-t6800-thermostat-not-seen-by-ha/137010
Thank you in advance.

If you can come up with a way to abstract away the Home/Away support for T6800 without affecting the others, and submit a merge request, I'll put it in.  Unfortunately, I have no control over the HomeAssistant component.


Moving to new OIT format and adding RPM build

@jupierce
Dependent on: https://github.com/openshift/enterprise-images/pull/78

Fixed in OIT PR.
On Tue, Dec 5, 2017 at 2:34 PM, Justin Pierce<EMAIL_ADDRESS>wrote:

@jupierce commented on this pull request.
In jobs/build/buildvm-maint/Jenkinsfile
https://github.com/openshift/aos-cd-jobs/pull/909#discussion_r155053363:

@@ -38,10 +38,10 @@ node('openshift-build-1') {

             stage("push images") {
                 dir ( "enterprise-images" ) {

                   sh './oit/oit.py --user=ocp-build --group sync-misc distgits:push-image --to-defaults'

                   sh './oit/oit.py --user=ocp-build --group sync-3.7 distgits:push-image --to-defaults'

                   sh './oit/oit.py --user=ocp-build --group sync-misc images:push --to-defaults'

images:push is for distgit in current PR. Maybe change in oit PR and make
images:push-distgit do the distgit push?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/openshift/aos-cd-jobs/pull/909#pullrequestreview-81309069,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA6a6vxfdwkRs-zagSAHoQPYZ4kTT0_mks5s9Zq8gaJpZM4Q2Xzs
.


Visual Studio Team Services build step failure

I updated to v0.5.0 (can't remember what the previous version was) and now the Android Visual Studio Team Services build step fails (builds and runs fine locally).

Mh, but locally it works? Can you show me your build steps and the Build Task in Detail? If I had to point to something, I would say NuGet issues...

@robinmanuelthiel Sure, ill be back in the office monday :)

@robinmanuelthiel This is the build process in VSTS -

And this is the build step -

Tried to reproduce it but for me it works. Can you please export your build definition shown in the screenshot below, so I can import it into my VSTS account?

A customer of mine had a similar issue. Turned out, that he updated the NuGet package from 0.4.0 to 0.5.0 but his Project.Android.csproj file still referenced the old version.
We changed
<Reference Include="Flex, Version=<IP_ADDRESS>, Culture=neutral, processorArchitecture=MSIL">
  <HintPath>..\..\packages\Forms.Controls.FlexButton.0.4.0\lib\monoandroid10\Flex.dll</HintPath>
</Reference>
<Reference Include="Flex.Android, Version=<IP_ADDRESS>, Culture=neutral, processorArchitecture=MSIL">
  <HintPath>..\..\packages\Forms.Controls.FlexButton.0.4.0\lib\monoandroid10\Flex.Android.dll</HintPath>
</Reference>

to
<Reference Include="Flex, Version=<IP_ADDRESS>, Culture=neutral, processorArchitecture=MSIL">
  <HintPath>..\..\packages\Forms.Controls.FlexButton.0.5.0\lib\monoandroid10\Flex.dll</HintPath>
</Reference>
<Reference Include="Flex.Android, Version=<IP_ADDRESS>, Culture=neutral, processorArchitecture=MSIL">
      <HintPath>..\..\packages\Forms.Controls.FlexButton.0.5.0\lib\monoandroid10\Flex.Android.dll</HintPath>
</Reference>

and the build worked again. Can you check, if that works for you aswell?

{"options":[{"enabled":true,"definition":{"id":"5d58cc01-7c75-450c-be18-a388ddb129ec"},"inputs":{"branchFilters":"[\"+refs/heads/*\"]","additionalFields":"{}"}},{"enabled":false,"definition":{"id":"a9db38f9-9fdc-478c-b0f9-464221e58316"},"inputs":{"workItemType":"2031874","assignToRequestor":"true","additionalFields":"{}"}}],"variables":{"BuildConfiguration":{"value":"Release"},"KeyStore_PWD":{"value":null,"isSecret":true},"system.debug":{"value":"true","allowOverride":true}},"retentionRules":[{"branches":["+refs/heads/*"],"artifacts":[],"artifactTypesToDelete":["FilePath","SymbolStore"],"daysToKeep":10,"minimumToKeep":1,"deleteBuildRecord":true,"deleteTestResults":true}],"properties":{},"tags":[],"metrics":[{"name":"CurrentBuildsInQueue","scope":"refs/heads/master","intValue":0},{"name":"CurrentBuildsInProgress","scope":"refs/heads/master","intValue":0},{"name":"CanceledBuilds","scope":"refs/heads/master","intValue":0,"date":"2018-04-17T00:00:00.000Z"},{"name":"FailedBuilds","scope":"refs/heads/master","intValue":1,"date":"2018-04-17T00:00:00.000Z"},{"name":"PartiallySuccessfulBuilds","scope":"refs/heads/master","intValue":0,"date":"2018-04-17T00:00:00.000Z"},{"name":"SuccessfulBuilds","scope":"refs/heads/master","intValue":1,"date":"2018-04-17T00:00:00.000Z"},{"name":"TotalBuilds","scope":"refs/heads/master","intValue":2,"date":"2018-04-17T00:00:00.000Z"}],"_links":{"self":{"href":"https://cardiffcouncilict.visualstudio.com/cb6a55df-bd0b-4370-8556-8c9a0168b86d/_apis/build/Definitions/12?revision=51"},"web":{"href":"https://cardiffcouncilict.visualstudio.com/_permalink/_build/index?collectionId=d014de0d-6854-478f-9016-157edf6f54de&projectId=cb6a55df-bd0b-4370-8556-8c9a0168b86d&definitionId=12"},"editor":{"href":"https://cardiffcouncilict.visualstudio.com/_permalink/_build/definitionEditor?collectionId=d014de0d-6854-478f-9016-157edf6f54de&projectId=cb6a55df-bd0b-4370-8556-8c9a0168b86d&definitionId=12"}},"buildNumberFormat":"1.1.0$(BuildID)","jobAuthorizationScope":1,"jobTimeoutInMinutes":120,"jobCancelTimeoutInMinutes":5,"process":{"phases":[{"steps":[{"environment":{},"enabled":true,"continueOnError":false,"alwaysRun":false,"displayName":"Version Assemblies","timeoutInMinutes":0,"condition":"succeeded()","refName":"VersionAssemblies1","task":{"id":"5b4d14d0-3868-11e4-a31d-3f0a2d8202f4","versionSpec":"2.*","definitionType":"task"},"inputs":{"sourcePath":"CardiffMobileApp/CardiffMobileApp.Android/Properties","filePattern":"AndroidManifest.xml","versionSource":"buildNumber","customNumberVariable":"myBuildNumber","versionFormat":"custom","customBuildRegex":"(?:\\d+\\.\\d+\\.)(\\d+)","replaceVersionFormat":"custom","customReplaceRegex":"versionCode=\"\\d+","buildRegexIndex":"1","replacePrefix":"versionCode=\"","replacePostfix":"","failIfNoMatchFound":"false"}},{"environment":{},"enabled":true,"continueOnError":false,"alwaysRun":false,"displayName":"Use NuGet 4.4.1","timeoutInMinutes":0,"condition":"succeeded()","task":{"id":"2c65196a-54fd-4a02-9be8-d9d1837b7c5d","versionSpec":"0.*","definitionType":"task"},"inputs":{"versionSpec":"4.4.1","checkLatest":"false"}},{"environment":{},"enabled":true,"continueOnError":false,"alwaysRun":false,"displayName":"NuGet restore","timeoutInMinutes":0,"condition":"succeeded()","task":{"id":"333b11bd-d341-40d9-afcf-b32d5ce6f23b","versionSpec":"2.*","definitionType":"task"},"inputs":{"command":"restore","solution":"**/*.sln","selectOrConfig":"select","feedRestore":"","includeNuGetOrg":"true","nugetConfigPath":"","externalEndpoints":"","noCache":"false","packagesDirectory":"","verbosityRestore":"Detailed","searchPatternPush":"$(Build.ArtifactStagingDirectory)/**/*.nupkg;!$(Build.ArtifactStagingDirectory)/**/*.symbols.nupkg","nuGetFeedType":"internal","feedPublish":"","allowPackageConflicts":"false","externalEndpoint":"","verbosityPush":"Detailed","searchPatternPack":"**/*.csproj","configurationToPack":"$(BuildConfiguration)","outputDir":"$(Build.ArtifactStagingDirectory)","versioningScheme":"off","includeReferencedProjects":"false","versionEnvVar":"","requestedMajorVersion":"1","requestedMinorVersion":"0","requestedPatchVersion":"0","packTimezone":"utc","includeSymbols":"false","toolPackage":"false","buildProperties":"","verbosityPack":"Detailed","arguments":""}},{"environment":{},"enabled":false,"continueOnError":true,"alwaysRun":false,"displayName":"NuGet restore **\\*.sln","timeoutInMinutes":0,"condition":"succeeded()","refName":"NuGetCommand2","task":{"id":"333b11bd-d341-40d9-afcf-b32d5ce6f23b","versionSpec":"0.*","definitionType":"task"},"inputs":{"solution":"$(Parameters.restorePkgSolution)","nugetConfigPath":"","restoreMode":"restore","noCache":"false","nuGetRestoreArgs":"","verbosity":"-","nuGetVersion":"<IP_ADDRESS>3","nuGetPath":""}},{"environment":{},"enabled":true,"continueOnError":false,"alwaysRun":false,"displayName":"Build Xamarin.Android Project CardiffMobileApp/CardiffMobileApp.Android/CardiffMobileApp.Android.csproj","timeoutInMinutes":0,"condition":"succeeded()","refName":"XamarinAndroid3","task":{"id":"27edd013-36fd-43aa-96a3-7d73e1e35285","versionSpec":"1.*","definitionType":"task"},"inputs":{"project":"CardiffMobileApp/CardiffMobileApp.Android/CardiffMobileApp.Android.csproj","target":"","outputDir":"$(build.binariesdirectory)/$(BuildConfiguration)","configuration":"$(BuildConfiguration)","createAppPackage":"true","clean":"true","msbuildLocationMethod":"version","msbuildVersion":"15.0","msbuildLocation":"","msbuildArchitecture":"x86","msbuildArguments":"","jdkSelection":"JDKVersion","jdkVersion":"1.8","jdkUserInputPath":"","jdkArchitecture":"x64"}},{"environment":{},"enabled":true,"continueOnError":false,"alwaysRun":false,"displayName":"Build Unit Test Projects","timeoutInMinutes":0,"condition":"succeeded()","refName":"MSBuild4","task":{"id":"c6c4c611-aa2e-4a33-b606-5eaba2196824","versionSpec":"1.*","definitionType":"task"},"inputs":{"solution":"CardiffMobileApp.Tests/CardiffMobileApp.Tests.csproj","msbuildLocationMethod":"version","msbuildVersion":"latest","msbuildArchitecture":"x86","msbuildLocation":"","platform":"","configuration":"$(BuildConfiguration)","msbuildArguments":"/p:OutputPath=\"$(build.binariesdirectory)/$(BuildConfiguration)/test-assembly\"","clean":"false","maximumCpuCount":"false","restoreNugetPackages":"false","logProjectEvents":"false","createLogFile":"false"}},{"environment":{},"enabled":true,"continueOnError":false,"alwaysRun":false,"displayName":"Build UI Test Projects","timeoutInMinutes":0,"condition":"succeeded()","refName":"ClonedMSBuild41","task":{"id":"c6c4c611-aa2e-4a33-b606-5eaba2196824","versionSpec":"1.*","definitionType":"task"},"inputs":{"solution":"CardiffMobileApp.UITest/CardiffMobileApp.UITest.csproj","msbuildLocationMethod":"version","msbuildVersion":"latest","msbuildArchitecture":"x86","msbuildLocation":"","platform":"","configuration":"$(BuildConfiguration)","msbuildArguments":"/p:OutputPath=\"$(build.binariesdirectory)/$(BuildConfiguration)/test-assembly\"","clean":"false","maximumCpuCount":"false","restoreNugetPackages":"false","logProjectEvents":"false","createLogFile":"false"}},{"environment":{},"enabled":true,"continueOnError":false,"alwaysRun":false,"displayName":"Signing and aligning APK file(s) $(build.binariesdirectory)/$(BuildConfiguration)/*.apk","timeoutInMinutes":0,"condition":"succeeded()","refName":"AndroidSigning6","task":{"id":"80f3f6a0-82a6-4a22-ba7a-e5b8c541b9b9","versionSpec":"1.*","definitionType":"task"},"inputs":{"files":"$(Parameters.appFiles)","jarsign":"true","keystoreFile":"CardiffMobileApp/CardiffMobileApp.Android/MyCardiffKeyStore.keystore","keystorePass":"$(KeyStore_PWD)","keystoreAlias":"MyCardiffKeyStore","keyPass":"$(KeyStore_PWD)","jarsignerArguments":"-verbose -sigalg MD5withRSA -digestalg SHA1","zipalign":"true","zipalignLocation":""}},{"environment":{},"enabled":true,"continueOnError":false,"alwaysRun":false,"displayName":"Unit Tests","timeoutInMinutes":0,"condition":"succeeded()","refName":"VSTest8","task":{"id":"ef087383-ee5e-42c7-9a53-ab56c98420f9","versionSpec":"2.*","definitionType":"task"},"inputs":{"testSelector":"testAssemblies","testAssemblyVer2":"**\\*unittest*.dll\n!**\\obj\\**","testPlan":"","testSuite":"","testConfiguration":"","tcmTestRun":"$(test.RunId)","searchFolder":"$(build.binariesdirectory)/$(BuildConfiguration)/test-assembly","testFiltercriteria":"","runOnlyImpactedTests":"False","runAllTestsAfterXBuilds":"50","uiTests":"true","vstestLocationMethod":"version","vsTestVersion":"latest","vstestLocation":"","runSettingsFile":"","overrideTestrunParameters":"","pathtoCustomTestAdapters":"","runInParallel":"False","runTestsInIsolation":"False","codeCoverageEnabled":"False","otherConsoleOptions":"","distributionBatchType":"basedOnTestCases","batchingBasedOnAgentsOption":"autoBatchSize","customBatchSizeValue":"10","batchingBasedOnExecutionTimeOption":"autoBatchSize","customRunTimePerBatchValue":"60","dontDistribute":"False","testRunTitle":"","platform":"","configuration":"","publishRunAttachments":"true","rerunFailedTests":"False","rerunType":"basedOnTestFailurePercentage","rerunFailedThreshold":"30","rerunFailedTestCasesMaxLimit":"5","rerunMaxAttempts":"3"}},{"environment":{},"enabled":false,"continueOnError":false,"alwaysRun":false,"displayName":"Xamarin Test Cloud","timeoutInMinutes":0,"condition":"succeeded()","refName":"XamarinTestCloud8","task":{"id":"049918cb-1488-48eb-85e8-c318eccaaa74","versionSpec":"1.*","definitionType":"task"},"inputs":{"app":"$(build.binariesdirectory)/$(BuildConfiguration)/*.apk","dsym":"","teamApiKey":"733bef6d73a4297ea96ce5c2a573ad88","user":"lcoates@cardiff.gov.uk","devices":"1a0a2077","series":"master","testDir":"$(build.binariesdirectory)/$(BuildConfiguration)/test-assembly","parallelization":"none","locale":"en_US","userDefinedLocale":"","testCloudLocation":"**/packages/**/tools/test-cloud.exe","optionalArgs":"","publishNUnitResults":"true"}},{"environment":{},"enabled":false,"continueOnError":false,"alwaysRun":false,"displayName":"Test with Visual Studio App Center","timeoutInMinutes":0,"condition":"succeeded()","task":{"id":"ad5cd22a-be4e-48bb-adce-181a32432da5","versionSpec":"1.*","definitionType":"task"},"inputs":{"app":"$(build.binariesdirectory)/$(BuildConfiguration)/*.apk","artifactsDir":"AppCenterTest","enablePrepare":"true","framework":"uitest","appiumBuildDir":"","espressoBuildDir":"","espressoTestApkPath":"","calabashProjectDir":"","calabashConfigFile":"","calabashProfile":"","calabashSkipConfigCheck":"false","uitestBuildDir":"$(build.binariesdirectory)/$(BuildConfiguration)/test-assembly","uitestStoreFile":"","uitestStorePass":"","uitestKeyAlias":"","uitestKeyPass":"","uitestToolsDir":"$(Build.Repository.LocalPath)/packages/Xamarin.UITest.2.2.2/tools/","signInfo":"","xcuitestBuildDir":"","xcuitestTestIpaPath":"","prepareOpts":"","enableRun":"true","credsType":"serviceEndpoint","serverEndpoint":"9e3cf4c4-4598-43d1-98a9-524cf6e4f43e","username":"","password":"","appSlug":"Cardiff-Council/MyCardiff_Android","devices":"41b2cec3","series":"master","dsymDir":"","locale":"en_US","userDefinedLocale":"","loginOpts":"","runOpts":"","async":"false","cliLocationOverride":"","debug":"false"}},{"environment":{},"enabled":true,"continueOnError":false,"alwaysRun":true,"displayName":"Publish Artifact: drop","timeoutInMinutes":0,"condition":"succeededOrFailed()","refName":"PublishBuildArtifacts7","task":{"id":"2ff763a7-ce83-4e1f-bc89-0ae63477cebe","versionSpec":"1.*","definitionType":"task"},"inputs":{"PathtoPublish":"$(build.binariesdirectory)/$(BuildConfiguration)","ArtifactName":"drop","ArtifactType":"Container","TargetPath":"\\\\my\\share\\$(Build.DefinitionName)\\$(Build.BuildNumber)","Parallel":"false","ParallelCount":"8"}}],"name":"Phase 1","refName":"Phase_1","condition":"succeeded()","target":{"executionOptions":{"type":0},"allowScriptsAuthAccessOption":false,"type":1},"jobAuthorizationScope":"projectCollection","jobCancelTimeoutInMinutes":1}],"type":1},"repository":{"properties":{"cleanOptions":"0","labelSources":"0","labelSourcesFormat":"$(build.buildNumber)","reportBuildStatus":"true","gitLfsSupport":"false","skipSyncSource":"false","checkoutNestedSubmodules":"false","fetchDepth":"0"},"id":"03ade363-d0a9-43c3-a6d3-43d1f70b8253","type":"TfsGit","name":"CardiffMobileApp","url":"https://cardiffcouncilict.visualstudio.com/Cardiff%20App/_git/CardiffMobileApp","defaultBranch":"refs/heads/master","clean":"false","checkoutSubmodules":false},"processParameters":{"inputs":[{"aliases":[],"options":{},"properties":{},"name":"restorePkgSolution","label":"Solution to restore packages","defaultValue":"**\\*.sln","required":true,"type":"filePath","helpMarkDown":"The path to the Visual Studio Solution file"},{"aliases":[],"options":{},"properties":{},"name":"appFiles","label":"App File","defaultValue":"$(build.binariesdirectory)/$(BuildConfiguration)/*.apk","required":true,"type":"filePath","helpMarkDown":"Relative path from repo root of the files(s).  Wildcards can be used.  For example, **\\bin\\*.apk for all APK files in bin subfolder."}]},"quality":1,"authoredBy":{"displayName":"Coates, Sarah","url":"https://app.vssps.visualstudio.com/Ac9917343-ebb7-47c8-9578-506f8c0d5060/_apis/Identities/c186e31d-a8cf-4add-8e34-2b5574a54db3","_links":{"avatar":{"href":""}},"id":"c186e31d-a8cf-4add-8e34-2b5574a54db3","uniqueName":"sarah.coates@cardiff.gov.uk","imageUrl":"https://cardiffcouncilict.visualstudio.com/_api/_common/identityImage?id=c186e31d-a8cf-4add-8e34-2b5574a54db3","descriptor":"aad.ZTY5YzFkYjgtM2I1Ni03YzFlLWI4NmQtN2M3NjE5NGJlZDMy"},"drafts":[],"queue":{"_links":{"self":{"href":"https://cardiffcouncilict.visualstudio.com/_apis/build/Queues/8"}},"id":8,"name":"Hosted VS2017","url":"https://cardiffcouncilict.visualstudio.com/_apis/build/Queues/8","pool":{"id":4,"name":"Hosted VS2017","isHosted":true}},"id":12,"name":"MyCardiff.Android-CI","url":"https://cardiffcouncilict.visualstudio.com/cb6a55df-bd0b-4370-8556-8c9a0168b86d/_apis/build/Definitions/12?revision=51","uri":"vstfs:///Build/Definition/12","path":"\\","type":2,"queueStatus":0,"revision":51,"createdDate":"2018-03-27T11:18:31.670Z","project":{"id":"cb6a55df-bd0b-4370-8556-8c9a0168b86d","name":"Cardiff App","description":"Project for the Cardiff App","url":"https://cardiffcouncilict.visualstudio.com/_apis/projects/cb6a55df-bd0b-4370-8556-8c9a0168b86d","state":"wellFormed","revision":165,"visibility":0}}

@robinmanuelthiel ahh thanks for that I'll give it a go.


Include schemas mentioned in discriminator when filtering and removingUnfreferencedDefinitions

Currently Schemas are filtered out if they are only included in the discriminator mapping. I propose including them in this case, as they are officially 'referenced' even though it is impossible to actually use them because they aren't included compositionally.

@fehguy @frantuma just wondering what you think of this change?

Just wondering if there is any action here? Thanks @fehguy and @frantuma!

Thanks for reporting and for the PR! it has been included and replaced by #3381 (minor fix and test update)


mean_squared_error accuracy

My currenct observation with "mean_squared_error" loss,
If you use mean_squared_error loss and metrics= ["acc"] ,
during training you can't see any meaningfull accuracy,
I wrote my custom acc. function , it's very hard for me to make a PR, because of project complexty,
Here is my fn.
def mean_squared_error_acc(y_true, y_pred):
    loss = tf.losses.mean_squared_error(y_true,y_pred)
    return 100 * ( 1 - tf.math.sqrt(loss))

( by the way, I'm at very begining of my ML experience, and this issue would be meaningless , please lead me to right direction if I'm wrong)
--Edit--
I use one of my colab experiments to reproduce issue
This is colab link
https://colab.research.google.com/drive/1hYG4RmPaUlnEcRm28NE6Y3HxIMoq1DTM?usp=sharing
These are the cells related the issue :
https://colab.research.google.com/drive/1hYG4RmPaUlnEcRm28NE6Y3HxIMoq1DTM#scrollTo=lL3kJjI-cXLS&line=4&uniqifier=1
https://colab.research.google.com/drive/1hYG4RmPaUlnEcRm28NE6Y3HxIMoq1DTM#scrollTo=eYb8YEiRvVuK&line=3&uniqifier=1

@firatsarlar,
Please post this issue on keras-team/keras repo.
To know more refer to:
https://discuss.tensorflow.org/t/keras-project-moved-to-new-repository-in-https-github-com-keras-team-keras/1999

@firatsarlar please update the issue on keras, we can discuss there

@firatsarlar ,
Can you please post this issue on keras-team/keras repo as this issue is more related to Keras.


Discogapic: support setX(String) / (String)getX methods when X is a resource name type in samplegen

Samplegen should show users how to use the ResourceName marshalling functions.

Done.