Fix @id's format from "uri" to "uri-reference" if exists

This PR links to the issue #418.
@kstreeter Fyi.

Hey @jwen-adobe thanks for posting this.  It looks like maybe you prettified some of the files and pulled in some non-URI related changes.  While we probably do want to fix the formatting of those files at some point, the extra changes will make it harder to validate this change.  Can we roll it back and commit just the files with URI format changes?  Thanks!

@kstreeter I know what u saying, I did not find a way to do it in my script as it has to save the file by using JSON.stringigy which will change the format, unless I have to do it manually...


Add tests for the immutable-vector binarySearchL

We shall add tests for the binarySearchL function that works with immutable vectors, which we are adding in response to #252.

Since the implementation that we finally came up with in #256 is a mere wrapper around the corresponding function for mutable vectors, I don’t consider it necessary anymore to add tests for that function.


Module generator not working

Current installation:
  Ceedling:: 0.28.3
CException:: <IP_ADDRESS>
     CMock:: <IP_ADDRESS>
     Unity:: <IP_ADDRESS>

Here are the last few lines of my project.yaml
:module_generator:
  :project_root: ./
  :source_root: ./
  :test_root: test/

:plugins:
  :load_paths:
    - vendor/ceedling/plugins
  :enabled:
    - stdout_pretty_tests_report
    - module_generator
    - raw_output_report

No matter what I set project_root and source_root to, when I run ceedling module:create[leds] the .c and .h file are placed in ./src.  No where else in my project.yaml is there a reference to ./src, so I'm not sure where its getting it from.
I also tried using different relative locations for source_root and that didn't help.  I also tried moving the entire :module_generator: below :plugins: and that didn't help.
Also, if you run ceedling module:create[beacon] twice, consecutively, an exception is throw.  I believe the documents imply that this should work, and that the source files that already exist won't be overwritten.

This is a duplicate of #291  has been resolved as of #365.
Also @mvandervoord any more updates on when the next release will be or what work is needed to get to that point?


Docker: CEC Python Module Error

Home Assistant release with the issue:
0.75.3
Last working Home Assistant release (if known):
Unknown
Operating environment (Hass.io/Docker/Windows/etc.):
Linux Ubuntu 18.04 x64 / Docker
Component/platform:
https://www.home-assistant.io/components/hdmi_cec/
Description of problem:
Python libraries for CEC communication cannot find _cec
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
hdmi_cec:

  devices:
    Philips TV: <IP_ADDRESS>
    Bose SoundTouch 300: f.f.f.f

Traceback (if applicable):
[homeassistant.setup] Error during setup of component hdmi_cec
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/cec/__init__.py", line 18, in swig_import_helper
    return importlib.import_module(mname)
  File "/usr/local/lib/python3.6/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 994, in _gcd_import
  File "<frozen importlib._bootstrap>", line 971, in _find_and_load
  File "<frozen importlib._bootstrap>", line 953, in _find_and_load_unlocked
ModuleNotFoundError: No module named '_cec'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/src/app/homeassistant/setup.py", line 148, in _async_setup_component
    component.setup, hass, processed_config)  # type: ignore
  File "/usr/local/lib/python3.6/concurrent/futures/thread.py", line 56, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/src/app/homeassistant/components/hdmi_cec.py", line 182, in setup
    adapter = CecAdapter(name=display_name[:12], activate_source=False)
  File "/usr/local/lib/python3.6/site-packages/pycec/cec.py", line 20, in __init__
    import cec
  File "/usr/local/lib/python3.6/site-packages/cec/__init__.py", line 21, in <module>
    _cec = swig_import_helper()
  File "/usr/local/lib/python3.6/site-packages/cec/__init__.py", line 20, in swig_import_helper
    return importlib.import_module('_cec')
  File "/usr/local/lib/python3.6/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
ModuleNotFoundError: No module named '_cec'

Additional information:
Running Pulse Eight USB CEC v1 (HDMI 1.4) firmware version 7 (latest) on /dev/ttyACM1. CEC Utils version 4.02.
Output from echo scan | cec-client -s -d 1:
opening a connection to the CEC adapter...
requesting CEC bus information ...
ERROR:   [           15288]     failed to request the physical address
CEC bus information
===================
device #0: TV
address:       <IP_ADDRESS>
active source: no
vendor:        Philips
osd string:    TV
CEC version:   1.4
power status:  standby
language:      ???

device #1: Recorder 1
address:       <IP_ADDRESS>
active source: no
vendor:        Philips
osd string:    CECTester
CEC version:   1.4
power status:  on
language:      eng

device #5: Audio
address:       f.f.f.f
active source: no
vendor:        Unknown
osd string:    Audio
CEC version:   unknown
power status:  unknown
language:      ???

currently active source: unknown (-1)

Update:
I tried linking CEC directory similar to what is stated in the CEC guidance on the Home Assistant website using docker compose volumes. It would appear that the installation of cec-utils (and therefore libcec) doesn't seem to come packaged with the python-cec package any more.
When I tried installing the python-cec package, it installed to the Python 2.7 folder and not the Python 3.6 folder.
I tried forcing the directory to the 2.7 cec directory and received the same error.

Is this still an issue you are experiencing? Can you please try upgrading to the latest version of Home Assistant (0.90) and report back if this is still a problem? Thanks!

I am using 0.90.2 version i am having same issue.
could some please let us know if its due to 64 bit hassio?
In my case when i power off the tv using remote ,i can turn on whin 2 mins but if longer then tv will not turn on with hdmi cec and tv is not shown in scan list.

I am also experiencing this issue.  Are there any dependencies we need to be aware of to run the hdmi_cec component in Docker?


HELLO LUCY DISPLAYS UNEXPECTED MODULES

On startup Hello Lucy displays the "currentweather" on page 1.  It is not listed on pageOne in the config.js file.  As a data point when I display a page that is defined identically to page 1,  it is not displayed.
In addition, from time to time when I issue a Show Page n,  a display of all of the Hello Lucy commands  is displayed but the module(s) on the selected page is not displayed.   The Hello Lucy commands display is full screen and the text  color is blue.
Comments/Observations:  I'm at a total loss on the firs issue.
On the second issue,  It seems to be related to how fast I'm giving the Show Page commands .  Once I see the "Commands" screen,  I see it for all requests to Show Page n commands.  If I issue the appropriate Hide Page n commands to clear all of the Show Page n commands I issues and then wait for some time I can issue the Show Page n commands and get the expected result.
The Hello Lucy commands screen is useful,  Just not when displayed here.  Is there a way I can activate it in a page and/or print it.
Thanks for any comments or help
Desert-Rat-Commander
modules: [
{
disabled: false,
module: "Hello-Lucy",
position: "top_center",
config: {
keyword: 'JARVIS',     		    // HELLO LUCY  keyword to activate listening for a command/sentence
timeout: 15,                        // timeout listening for a command/sentence
standByMethod: 'HIDE',              // 'DPMS' = anything else than RPi or 'PI'
microphone: "2,0",                  // run "arecord -l" card # and device # mine is "0,0"
sounds: ["Jarvis_At_Your_Service.mp3"],        			// "1.mp3", "11.mp3" welcome sound at startup. Add several for a random greetings
confirmationSound: "ok.mp3",      // name and extension of sound file
startHideAll: true,                 // All modules start as hidden EXCEPT PAGE ONE
// *** Page One is your default startup page *** This overrides startHideAll: true,
pageOneModules:   ["Hello-Lucy","MMM-EasyPix"],               // default modules to show on page one/startup
pageTwoModules:   ["Hello-Lucy", "clock", "MMM-BMW-OW", "alert", "calendar", "currentweather", "calendar_monthly", "MMM-Todoist"],
pageThreeModules: ["Hello-Lucy", "clock", "MMM-BMW-OW", "alert", "MMM-ImageSlideshow", "calendar", "currentweather", "weatherforecast", "calendar_monthly"],           // modules to show on page three
pageFourModules:  ["Hello-Lucy", "MMM-EasyPix"],             // modules to show on page four
pageFiveModules:  ["Hello-Lucy", "MMM-EasyPix"],             // modules to show on page five
pageSixModules:   ["Hello-Lucy", "MMM-EasyPix"],              // modules to show on page six
pageSevenModules: ["Hello-Lucy", "MMM-EasyPix"],            // modules to show on page seven
pageEightModules: ["Hello-Lucy", "MMM-EasyPix"],            // modules to show on page eight
pageNineModules:  ["Hello-Lucy", "MMM-EasyPix"],             // modules to show on page nine
pageTenModules:   ["Hello-Lucy", "MMM-EasyPix"]               // modules to show on page ten
}
},

I've looked at all he sources I can find and do not see any other reports so I must conclude I'm doing something wrong.  I would appreciate any advice or counsel on how I should proceed to trouble shoot this issue.

current weather and weatherforcadt have a design flaw/bug.the show() themselves EVERY time they get weather data from their api. so every update interval cycle.

Many Thanks Sir!  Having assistance like this is outstanding and keeps rookies like me challenged to learn more and contribute in the future!


Running mountebank via Docker

Problem
When starting mountebank via Docker (see docker-compose.yml below) on custom port and trying to communicate with it via Postman, it doesn't seem to work even with the base GET-request:

However, upon the start, the container log says it's up:
info: [mb:2525] mountebank v2.4.0 now taking orders - point your browser to http://localhost:2525/ for help

This is the exact message as when I start mountebank via terminal after npm installation. So where is the problem? If I call
sudo lsof -i:25025

, mountebank container definitely holds this very port. But REST-requests still do not work (terminal curls as well).
I face no problem working with npm-installed mountebank but I really need it to run in Docker.
Software versions used
OS                  : Ubuntu
mountebank          : 2.4.0
Installation method : docker-compose.yml

docker-compose.yml
version: '3'
services:
  mountebank:
    image: bbyars/mountebank:2.4.0
    container_name: mountebank
    network_mode: "bridge"
    ports:
      - '25025:25025'

Command to install and start:
docker-compose -f docker-compose.yml up -d

Just figured out where was the problem. The inner port should be default:
ports:
      - '25025:2525'

Problem solved.

Thanks for posting the solution
On Mon, Mar 29, 2021 at 3:09 PM PetPython @.***> wrote:

Closed #605 https://github.com/bbyars/mountebank/issues/605.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bbyars/mountebank/issues/605#event-4523638996, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAARFP25EPNZXQKFT6KBJH3TGDM65ANCNFSM4Z7UD7PQ
.


FLI Signal Handle Initialise not properly using variable m_type

m_type is a string, but this function is setting it to an enum value.
Further it is overridden and not currently causing problems because the super class is called at the end of the initialise function which sets the m_type to a valid string.

m_type at the Fli level has been changed to m_fli_type and used to store the type of object to reduced calls on the fast path for obtaining value of a signal


Fix checkbox unchecking

New DWP pages should have the checkboxes unchecked by default.
On the DfE refine pages, we want to ensure that when all items in the hierarchy are checked and a child item is unchecked, the parent checkbox is also unchecked to reflect the fact that we are no longer selecting everything under the hierarchy.

👍 thanks @gpeng

Always a pleasure...


“ch04002410.wimdo” in XB3 makes the game crash

This is Mio's City costume . Sometimes the mod makes the game crash, so i tried to ues the mod which I didn't change anything. But it still makes the game crash.

The game sometimes crashes ,sometimes stucks in the loading interface.

I'm able to reproduce this on my end with chapter 6 cutscenes. I'll try and look into fixing this.


cronjob was not working properly

I set up a cron job for 1 * * * *, but it continues to execute every hour instead of the expected one-minute interval.  What's causing the issue with the cron job's proper functionality

This is not a Kor related question.
Regardless
If you want it to run every minute run * * * * *
I don't recommend running it so many frequently but enjoy..

@yonahd if was running this  * * * * * I'm getting issue that is stating the error in cronjob.yaml file at line no.8

This is again unrelated to kor specifically.
This might be because you removed quotes or something like that.
Please limit the use of these tickets to kor specific issues


SHA-2 Support

It looks like the Java plugin only does SHA1 can this be expanded to do SHA-256

Would you be willing/able to do a pullrequest to add it? Otherwise it may take a while...

I will try, I've never done this before though.

Are there security risks to using SHA1 in this scenario? If so can anyone help me understand what those risks are?


GitHub Action to Generate Website and Commit to Repo

Similar to #3, we need a way to generate an HTML page that uses all of the optimized images.  Once it has been created, we need to re-commit everything in the Actions filesystem back to the repo's gh-pages branch (i.e., we want the built web site to be put into the gh-pages branch).

I would like to give this issue a try.


feat(rust): user enrolment verification

Current behavior

In the current implementation, we only rely on a default identity to exist when determining if a user is enrolled or not.
Proposed changes

This PR addresses #5338. It adds extra checks when checking for user enrolment to detect possible corruption of the enrolment process, surfacing a warning in the menu tray, and also adds an is_enrolled function on IdentityState directly instead of having to navigate to the is_enrolled field.
Checks

[x] All commits in this Pull Request are signed and Verified by Github.
[x] All commits in this Pull Request follow the Ockam commit message convention.
[x] I accept the Ockam Community Code of Conduct.
[x] I have accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam-contributors repository. The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a PR, this will mark the commit as verified.

Hmm I'm currently trying to test if this works but hitting some issues. I'm trying to enroll, though the menu does not update to recognise that I've enrolled after the fact. This is the same on the develop branch.
I'd also like to clarify what the intended menu behaviour should be. My understanding is that if a user is enrolled, they should be able to see a Reset button and a Quit button. If they are not enrolled or there's some sort of corrupted state, they should see a warning, along with the Reset and Quit buttons. Is this correct?

Hi @qxtaiba note that develop is currently broken w.r.t enrollment but a fix is coming.

My understanding is that if a user is enrolled, they should be able to see a Reset button and a Quit button. If they are not enrolled or there's some sort of corrupted state, they should see a warning, along with the Reset and Quit buttons. Is this correct?

Yes exactly.

Note that there is a job failing because some of your commits contain caps letters. You can reword the message as add is_enrolled fn on identity state and update identity state.

Hi @qxtaiba sorry it's been a long time, I've been on vacations :-).
I have rebased your PR to adapt the latest changes. I have also made sure that we don't display an error message if the user is not enrolled yet at all :-).


possible PageBlock socket error

just a guess — if the node goes down, the socket is probably not being re-subscribed to.
"After sometime the latest Blocks section on Blocks page stopped updating newer blocks… although Block height counter was being updated regularly."
https://medium.com/@speculatecoin/after-sometime-the-latest-blocks-section-on-blocks-page-stopped-updating-newer-blocks-although-dfae1657fc4c

i can't reproduce this. any time i've witnessed this happening, i also see slack messages asking if the testnet is down.


Update balance periodically

Description

Use riverpod to share the state between wallets screen
Update home screen logo

Issues

#643
#655

Shared state between terms and conditions in last wizard page and dialog not working correctly.

Shared state between terms and conditions in last wizard page and dialog not working correctly.

I removed it intentionally for now


Layout is not effective

Layout is not effective when I go back to the front page from the error page.

Hi @dxhszu, can you explain more about your issue?

My code like that:
layout>nav.vue:
`

`
x-nav is a component. I went to this error page from a page used this layout and go back,then i saw the x-nav was lost.

@dxhszu I am using more complex layout than ydurs but never encounter that problem. maybe if you provide one of your code on pages/ it will be help

Do you use one default layout file or few different layouts?


Changing cssFloat to float

Re-creating the PR from the old repo https://github.com/reasonml/reason-react/pull/78

Thanks!


New K website

Demo: https://shd101wyy.github.io/k
Then Jenkins task is trying to build the static website in ./web/public_content directory, then move everything inside ./web/public_content into ./.

The static content is in serious need of making sure the out of date stuff is removed; that was one of the primary reasons we wanted to update the website.

@shd101wyy we have decided a few things at the meeting, the gist of it is "Only keep up-to-date information about the current state of K." What that means is:

Please remove all links to the tool/run try it online tool for now.
Put the links to the tutorial videos at the bottom of the page, and put some text telling people they are out of date.
Please remove all pages with publications/people/workshops (eg: http://www.kframework.org/K11/).

That should be a good start for now.

Hi @ehildenb I have updated the website. Please see the demo here: https://shd101wyy.github.io/k/index.html
Please let me know if I need to make any further changes. Thank you!

@shd101wyy for the moment, let's also remove the "Projects", "News", "Events", and "Funding" pages from the site, since they are all out of date.
Also, please provide a link (in the left pane) called "User Documentation", which links to the file pending-documentation.md (in the K repo root), and another link called "Builtins" which links to k-distribution/include/builtin/index.html (generated from k-distribution/include/builtin/README.md).

Hi @ehildenb , I have removed the out of date pages and added the User Documentation and Builtins pages. I also supported the syntax highlighting for K. Please take a look at the demo website when you have time. Thanks a lot!
https://shd101wyy.github.io/k
A page that contains example of syntax highlighting for K: https://shd101wyy.github.io/k/k-distribution/include/kframework/builtin/domains/

Wow, this looks really great! Thanks @shd101wyy . I'm approving, but I believe you need @dwightguth 's approval to merge it because he's code-owner on some files you touched.
My thoughts are that any more fixes can be made note of and cleaned up in a follow-up PR within the next few weeks.


Weather

Live version:
https://rawcdn.githack.com/Nazeh/weather-app/83363b5fb67a4e588b751e6fb0d204dea587f509/dist/index.html
Click on the temperature to change the unit format!

Thanks, @JamesOkunlade .
You can switch from Celsius to Fahrenheit by clicking on the temprature as I mentioned, No need for a button.

Hi, @Nazeh I wouldn't have known if you didn't leave the comment. The users won't know so it's important to have the switch button. 😄
Please implement the button and submit again for review. Shouldn't take more than a few minutes 😁
Thanks for understanding! 😎

https://rawcdn.githack.com/Nazeh/weather-app/bbfb0fb8d108a931091f7de475b3d2645cfdef34/dist/index.html


Can't install with librarian-chef

Trying to install via librarian-chef results in errors when it tries to resolve dependencies. It looks like it's failing because the cookbook does not contain a metadata file. Is there are reason there's no metadata.rb?

This cookbook is managed via Halite and there is no support for Halite cookbooks in Librarian. You can use Berkshelf (with the Halite extension) as documented in the Halite readme or manually convert the cookbook via bundle install && rake build. Or you can use the released version from Supermarket which is already converted for you.


https://www.creative-tim.com/new-issue/material-dashboard-react

Unable to create select option in input field , which is showing wired css

Hi @ManideepSadhu
Could you please tell me how to do that, I need to know how you put them together to find the issue.
Note: To get the latest updates and supports for the products and other related things to Creative Tim please join our Discord Community.
All the best,
Sajad

React Developer @ Creative-Tim.com


BitSequence should unmarshal data during get

When bit sequence is trying to get key/value from the
data store it should always unmarshall the json data
before using it, as the data is JSON marshalled before
storing it in the data store.
Signed-off-by: Jana Radhakrishnan<EMAIL_ADDRESS>

LGTM

LGTM


Conf/travis

@tigredonorte I think that we can merge this PR by now, with ng 4 the build still ok, the problem is with ng 5... Ng 5 support must be solved with another PR


Start a project

On the show page of non-started projects, a link should redirect to the "start
page": almost identical to edit page but with an additional due date input.
Default value is today + 1 month. It cannot be before today. After validating,
the due date appears on the show page and it can be edited on the edit page.
Due date is required for a started project.
There is a max of 3 started projects per user.
Started projects must appear first on the dashboard page with their due date
and with a specific design.

[ ] add started_at initialized on DateTime.now
[ ] add due_date to Projects (validate not before started_at)
[ ] validate there is no more than 3 projects per user with a started_at attribute present and due_date in the future
[ ] return those information in projects
[ ] add API endpoint to start a project
[ ] add a link on Project show page to start it
[ ] provide a DateField component
[ ] improve ProjectEditForm to show a due_date field
[ ] present started projects differently on dashboard

tech considerations: dates should be stored in UTC


Win81

Added support for WIN81. The while enchilada.

Didn't change namespace of FontAwesome class. Will create another pull request.


fix: Align block structs w/ yp #3868

Resolves #3868

Benchmark results
Metrics with a significant change:

note_trial_decrypting_time_in_ms (128): 285 (+84%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Values are compared against data from master at commit ce51d206 and shown if the difference exceeds 1%.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
128 txs

l1_rollup_calldata_size_in_bytes
45,700
180,580
720,100

l1_rollup_calldata_gas
222,736
871,336
3,465,940

l1_rollup_execution_gas
315,927
989,784
3,686,318

l2_block_processing_time_in_ms
1,146 (-2%)
4,332 (-1%)
17,249 (-1%)

note_successful_decrypting_time_in_ms
309 (-5%)
991
3,791 (+1%)

note_trial_decrypting_time_in_ms
20.6 (-45%)
132 (+7%)
:warning: 285 (+84%)

l2_block_building_time_in_ms
17,790 (-2%)
70,174 (-1%)
282,172 (-1%)

l2_block_rollup_simulation_time_in_ms
13,104 (-1%)
51,603 (-1%)
208,082 (-1%)

l2_block_public_tx_process_time_in_ms
4,659 (-2%)
18,494 (-1%)
73,834 (-1%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
13,757
26,863 (+2%)

note_history_successful_decrypting_time_in_ms
2,370 (+1%)
4,994 (+7%)

note_history_trial_decrypting_time_in_ms
99.8 (+6%)
286 (+27%)

node_database_size_in_bytes
17,342,544
33,083,472

pxe_database_size_in_bytes
29,923
59,478

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
322 (+4%)
44,528
25,825

private-kernel-ordering
193 (-1%)
44,145
16,225

base-rollup
1,404 (-1%)
128,654
933

root-rollup
82.4 (-1%)
4,192
729

private-kernel-inner
436
71,331
25,825

public-kernel-private-input
240 (-1%)
32,287
25,825

public-kernel-non-first-iteration
236 (-1%)
32,329
25,825

merge-rollup
7.80 (-2%)
2,712
933

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
0 deployed contracts
1 deployed contracts

tx_size_in_bytes
16,859
40,167

Transaction processing duration by data writes.

Metric
0 new commitments
1 new commitments

tx_pxe_processing_time_ms
577 (+4%)
1,315

Metric
0 public data writes
1 public data writes

tx_sequencer_processing_time_ms
0.473 (-9%)
573 (-1%)

But it seems like yarn format does something else ? Can we combine these ?
@sklppy88 I alwasys just run the formatting:fix command in yarn-packages.

I have alias for it:

alias yf="clear && yarn formatting:fix"

@benesjan did you create an issue for logs related task? We should get this in and then we can address it separately to not make the pr huge.

Just created it https://github.com/AztecProtocol/aztec-packages/issues/4635


Auxiliary loss is counted twice in the loss

Hi,
In model_step, we have se3_vf_loss += auxiliary_loss. Yet in training_step, we also have train_loss = (             total_losses[self._exp_cfg.training.loss]             +  total_losses['auxiliary_loss']         )
The default training loss is se3_vf_loss so in this case, auxiliary loss is being counted twice in the loss. Is this expected or a bug?
Thanks!

I think it may be a bug. We removed and trained and attained very similar results.

This has been fixed.


Database v1 tables not detected

I'm trying to upgrade from umami-software/umami@0cb14f3 (v 1.38 or so) to latest umami-software/umami@71bb012, but when running this migration tool, I'm seeing the following error.

The tables I have in supabase are as follows:
.
Upon reviewing the code, it seems to require a v1_account table and a 04_add_uuid migration. However, the table named account exists and only three migrations (01_init, 02_add_event_data, and 03_remove_cascade_delete) have been executed.
Full Schema Below

table_name
column_name
data_type

_event_old
website_id
integer

_event_old
created_at
timestamp with time zone

_event_old
event_id
integer

_event_old
event_value
character varying

_event_old
url
character varying

_event_old
session_id
integer

_event_old
event_type
character varying

_prisma_migrations
finished_at
timestamp with time zone

_prisma_migrations
started_at
timestamp with time zone

_prisma_migrations
migration_name
character varying

_prisma_migrations
checksum
character varying

_prisma_migrations
logs
text

_prisma_migrations
applied_steps_count
integer

_prisma_migrations
rolled_back_at
timestamp with time zone

_prisma_migrations
id
character varying

account
is_admin
boolean

account
updated_at
timestamp with time zone

account
created_at
timestamp with time zone

account
user_id
integer

account
username
character varying

account
password
character varying

event
session_id
integer

event
event_name
character varying

event
event_id
integer

event
url
character varying

event
website_id
integer

event
created_at
timestamp with time zone

event_data
event_data_id
integer

event_data
event_data
jsonb

event_data
event_id
integer

pageview
session_id
integer

pageview
created_at
timestamp with time zone

pageview
website_id
integer

pageview
view_id
integer

pageview
url
character varying

pageview
referrer
character varying

session
screen
character varying

session
os
character varying

session
created_at
timestamp with time zone

session
session_id
integer

session
session_uuid
uuid

session
language
character varying

session
website_id
integer

session
country
character

session
device
character varying

session
hostname
character varying

session
browser
character varying

website
website_id
integer

website
website_uuid
uuid

website
share_id
character varying

website
domain
character varying

website
created_at
timestamp with time zone

website
name
character varying

website
user_id
integer

I had the same error, I managed to solve it by upgrading to 1.40.0 first, then running the migration script.

I had the same error too. After a long time debug, I found MySQL user used for umami don't have permission of DROP command.
OMG, why the migrator only print a Database v1 tables have not been detected., there is more error details needed

I had the same error, I managed to solve it by upgrading to 1.40.0 first, then running the migration script.

How do I do that? I changed the just from 1.33 to 1.40 and there seems to be some missing migrations. How do I run those?

For anyone trying to migrate to 1.4 from previous versions, checkout the V1 branch and do yarn install and yarn build.


Hide additional loads when power is below limit (0)

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Additional Load is showing with value 0
Expected behaviour
there should be an option to hide the load if the power is below a limit or 0.
Possible Solutions
ad an option for that... :)
Mode
lite
Context / Reason
like described

Why not just enable dynamic colour and use the off_threshold to grey our loads that are off.  I could also add an option to set the off colour and you can set it to transparent to hide the load instead of the default grey.

As you can see it's already colored gray when the load is 0.
But as my washing machine and the tumble dryer aren't on all the day i would hide them when they are off...

thanks for your reply

OK, I've added an option to set the off colour for the additional load. When you set it to 'transparent' it will hide the load when <= off threshold
Off colour set to default grey

Off colour set to transparent

Nice - Thanks.
i think i can test this in the next release?!
Mit freundlichen Grüßen
Chris

Nice feature, but cant find the transparent button. Or do I need to set the RGB colors?

@alphabravocharly72  you cant set it via the visual editor. Switch to the code editor and change the off_colour attribute in the load section  to transparent.

thx for the hint.
Added the off_colour manualy and it works perfectly.
Again thx for your feedback ;-)


can not use pip install deepface

I try install deepface by pip in windows. but it not work. it show "Requirement already satisfied:...." and repeat and repeat

if it says requirement already satisfied, then installation is complete. if you have trouble when you import deepface, then you might install it on a different python version or virtual environment.
try this command: "python -m pip install deepface" and run same python with your programs "python hello.py"

Yes. Thank you. I already installed it successfully. It failed because of my mistake. The environment has conflict.


No audio toggle button on hevc (PTZ) camera recording in Microsoft Edge (Windows)

It's fine in Edge Linux.

Fixed: Use audio flag and (not) motion.enabled flags in stream instead of audio flags on video element.


[Frontend] Add some printing/vistation options to swift-synthesize-interface.

The -include-submodules flag causes the synthesized interface to include implicit Clang submodules of the module being printed. Since these are automatically made visible when importing the corresponding top-level module, it's often useful to have them present in the same synthesized Swift interface instead of having to make separate invocations to get each submodule separately.
The -print-fully-qualified-types causes type names to be printed with full module qualification. This is useful when using the synthesized interface for some other kind of analysis, because it ensures that all type references explicitly indicate which module they came from, instead of having to guess scoping and import resolution rules to figure out which module a reference comes from.

@swift-ci please smoke test


WPF version (C# and VB) of the webmap tutorial

Hey @dkemlage
If you have time, can you give this a review? It's basically the solution to the 'author, edit, and save maps to your portal' tutorial. I had to make it a little different to work in the sample viewer.

@ThadT Here are my comments for the code review:
Both the CSharp and VB.NET versions of the sample worked well, without error. Congratulations!
One of my primary goals was to ensure that the tutorial guide document 'Author, edit, and save maps to your portal' (https://developers.arcgis.com/net/latest/wpf/guide/author-edit-and-save-maps-to-your-portal.htm) matched what was being shown in the sample code in the SampleViewer. So with that in mind:

There is no 'New Map' button in the UI screenshots nor is it wired up in the constructor of the tutorial document.

There are several using statements that can be eliminated (unused) in the C# code (they are fine in the VB.NET code):
using Esri.ArcGISRuntime.Geometry;
using System.IO;
using System.Windows.Media;
using System.Windows.Media.Imaging;

In the tutorial document the user is told to create a MapViewModel.cs file and add code to it. But in the actual sample in the SampleViewer, the MapViewModel is a sub-class of AuthorEditSaveMap class. This inconsistency should probably be resolved or at lest noted in the documentation.

The actual code in the SampleViewer makes use of a _map variable in the MapViewModel class but it is not used in the tutorial.

Add some blank lines for readability in the sample code of the SampleViewer for the 'UpdateAuthenticationManager' function. The comments and actual code are bunched together.

There are some 'TODO:' comments in the VB.NET code that are not present in the CSharp code. This should be reconciled.

The order of the MapViewModel and OAuthAuthorize classes are different in the CSharp and VB.NET sample code. They should probably both flow the same when you read them.

The VB.NET code has a few sections of triple slash (///) comments with 'summary'  and .param' tags that do not exist in the CSharp code. This should be reconciled.

Some global (aka. member) variables do not begin with underscores ( _ ) in the AuthorEditSaveMap and they probably should for consistency:
Private Const ArcGISOnlineUrl As String = "https://www.arcgis.com/sharing/rest"
Private Const AppClientId As String = "2Gh53JRzkPtOENQq"
Private Const OAuthRedirectUrl As String = "https://developers.arcgis.com"


Document possible options for web_columns

Problem Description
The current documentation about web_columns only lists the defaults.

I recently discovered that there are other columns as well, and it would be great to include them as "possible options"
Proposal
Add a list of possible columns.
Alternatives
Don't document additional columns.

Yes, 💯 . We should add a script in https://github.com/mitmproxy/mitmproxy/tree/main/web/gen that generates a Python file with all column names. We can then use that for the option description. Contributions welcome!


Unable to use priority in activeMq using stompit in nodejs

I have an application which sents the messages to message queue, another application which subscribes to the queue and process it. I want OTP Messages to be given more priority than other messages, hence I am trying to use activeMq message priority to achieve message priority.
This is the code for activeMq connection using STOMP protocol in nodejs using stompit library.
const serverPrimary = {
  host: keys.activeMQ.host,
  port: keys.activeMQ.port,
  ssl: ssl,
  connectHeaders: {
    host: '/',
    login: keys.activeMQ.username,
    passcode: keys.activeMQ.password,
    'heart-beat': '5000,5000',
  },
}
connManager = new stompit.ConnectFailover(
  [serverPrimary, serverFailover],
  reconnectOptions,
)
connManager.on('error', function (e) {
  const connectArgs = e.connectArgs
  const address = connectArgs.host + ':' + connectArgs.port
  logger.error({ error: e, customMessage: address })
})

    channelPool = new stompit.ChannelPool(connManager)

Code for sending message
const pushMessageToAMQ = (queue, message) => {
      const queues = Object.values(activeMQ.queues)
      if (!queues.includes(queue)) {
        _mqLog(mqLogMessages.unknownQueue + queue)
        return
      }
      //Priority header is set
      const header = {
        destination: queue,
        priority: 7
      }
      //If message is not a string
      if (typeof message !== 'string') message = JSON.stringify(message)
      //Logging message before sending
      _mqLog(
        mqLogMessages.sending,
        { service: services.amq },
        { header: header, message: message },
      )
      //Sending message to amq
      _sendMessageToAMQ(header, message, error => {
        if (error) {
          _mqError(error, mqLogMessages.sendingError, { service: services.amq })
        }
      })
    }

const _sendMessageToAMQ = (headers, body, callback) => {
      channelPool.channel((error, channel) => {
        if (error) {
          callback(error)
          return
        }
        channel.send(headers, body, callback)
      })
    }

Code for subscribing to queue in the second application
const amqSubscribe = (queue, callback, ack = 'client-individual') => {
  log({ customMessage: 'Subscribing to ' + queue })
  const queues = Object.values(activeMQ.queues)
  if (!queues.includes(queue)) {
    return
  }
  channelPool.channel((error, channel) => {
    let header = {
      destination: queue,
      ack: ack,
      'activemq.prefetchSize': 1,
    }
    //Check for error
    if (error) {
      _mqError(error, mqLogMessages.baseError, header)
    } else {
      channel.subscribe(
        header,
        _synchronisedHandler((error, message, next) => {
          //Check for error
          if (error) {
            _mqError(error, mqLogMessages.subscriptionError, header)
            next()
          } else {
            //Read message
            message.readString('utf-8', function (error, body) {
              if (error) {
                _mqError(error, mqLogMessages.readError, header)
                next()
              } else {
                //Message read successfully call callback
                callback(body, () => {
                  //Acknowledgment callback
                  channel.ack(message)
                  next()
                })
              }
            })
          }
        }),
      )
    }
  })

I tried pushing different messages with different priority and turned on the second application(The one which subscribes to the messages) after all the messages were pushed to queue. But the execution order of the messages was the same as the one which was sent. The priority didn't change anything. Is there something that I am missing? Do I have to add something in consumer end for it to work?

send priority as JMSPriority in the headers.


[examples] Replace Jade with Pug

This fixes  #3181
I've gone ahead and replaced all of the examples to use Pug instead of Jade.

@dougwilson Would you be happy to merge this?

Hi @notrab this is awesome, thanks so much for putting this together!

I've been looking at pug and trying to figure out their Node.js version support. It seems like they broke support for Node.js 0.10 recently, and added it back, but only because of web browsers, not because they wanted to support Node.js 0.10. Their Travis CI config only tests on Node.js 4 & 6. It does seem like beta9 supports Node.js 0.10, so that's good, but all it's deps use ^ which means that we can turn around and can no longer build Express if this suddenly changes.

Excellent. I wasn't too sure on the dependency tree and Node support. I really wanted to use template literations and some ES6 syntax but I held back so there were no breaking changes in the examples alone.
I've seen a few issues regarding new up to date examples and I more than happy to provide a few but in cases like this, it might be better to pull out some examples into another repo, so those who wish to use newer versions of Node can use things like fat arrows etc and at the same time not breaking Express support for older Node versions.
Now the tears in Express are for the examples, that seems like a really big task to rewrite for Express so instead I would suggest to remove duplicate examples into their own repo and then the tests will still cover all of the Express features.
I hope this makes sense..!

Anything further from me @dougwilson for this merge?

Hi @notrab I currently have it marked to merge into 4.15 branch, but that was before I realized the Node.js 0.10 support issues I noted above, so I'm not sure we can merge this at this time, rather these current changes are great, but without modification in some way would need to wait until we have a branch ready that drops Node.js 0.10 support to merge this into.

I've gone ahead and closed this and will create PR's for the things discussed in #3181
Please see #3222 for the first PR.


error when trying to export textures or fbx files

Did you install the redistributables like it says in the Releases page?
https://aka.ms/vs/16/release/VC_redist.x64.exe
https://aka.ms/vs/16/release/VC_redist.x86.exe


"Insert empty citation" should work for CSL styles

Currently, "Insert empty citation" is supported for JStyles. It inserts an invisible in-text citation, so that the entry is present in the bibliography (when made).
Now that we have reference marks implemented for CSL styles, the feature should be extended work for it too.

Fixed in https://github.com/JabRef/jabref/pull/11577/commits/63bb146db2c1ddb955d78bf4c940c8b1bfba0d41


Fix str_singular

This plugin is compatible with Laravel 6 but str_* helpers are not available with

Thanks @MarceauKa !


feat: add osi popular licenses

Updates all semantic-release packages.
Adds licenses and handlers:

BSD-2-Clause -> bsd
BSD-3-Clause -> bsd
ISC -> bsd
UPL-1.0 -> mit

Removes BSL license.

Hi there ! Thanks a lot for your contribution ! Very well done. I appreciate the time and effort you put into this, it's neat and I could expect any better from the open source community, so thank you for that 🙇
That said, I would be happy to merge it if you can rollback the removal of the BSL. While I am aware that there are some debates around this license, this project aims at supporting as many licenses as possible, not just OSI licenses. The BSL, as any other license, belongs here.

First of all, thank you for the quick reply! I respect your motivation but in the npm ecosystem I am not sure that is the best choice: https://docs.npmjs.com/cli/v8/configuring-npm/package-json#license
I'll undo the breaking changes and get back to you. There's another more pressing issue I discovered while experimenting with a fork of this, what happens when the license does not need updating copyright, would it be possible to make the plugin stop throwing an error?
Asking this because I run a semantic-release config, having to know whether the license is parseable before loading this plugin puts me at a difficulty and makes some of the processing inside verify and publish potentially redundant! :D


Sarayu Final Grading Ticket

Night at the Museum

Individual Attendance

Team Presentation to Teacher

Silent Review

Runtime Link
Technical Accomplishments

Peer Grader #1 = Pranavi Inukurti
RUNTIME:
Project Quality = 1
UI Contains Inputs for validations = 1
UI contains actions for GET, POST, DELETE = 1
JWT Feature guarding = 1
CODE REVIEW:
Project Quality of Comments in Feature = 1
BE contains feature and API with error conditions = 1
BE has GET POST methods = 1
BE supports Create, Read = 1
BE supports Update, Delete = 1

SCORE: 10/10
Peer Grader = Saumya Palakodety
RUNTIME:
Project Quality = 1
UI Contains Inputs for validations = 1
UI contains actions for GET, POST, DELETE = 1
JWT Feature guarding = 1
CODE REVIEW:
Project Quality of Comments in Feature = 1
BE contains feature and API with error conditions = 1
BE has GET POST methods = 1
BE supports Create, Read = 1
BE supports Update, Delete = 1


[IE11 issue] Fixing the resize calculation after open a modal with the iframe inside it

Description
When we have the iframe inside a hidden modal, and then we open that, the calculation of the new height in IE11 was wrong, because of an issue with the document.body.offsetHeight.
Clarifications
The iframe only contains the inputs of the form and the submit button, the modal is in the parent window and includes that iframe.
Screenshots
Before the fix in IE11:

After the fix:

Hi,
I'm not keen to change exist calculation methods, as it may negatively effect other users.
You can however pass a custom height calculation method to iframeResizer.
https://github.com/davidjbradshaw/iframe-resizer/blob/master/docs/iframed_page/options.md#heightcalculationmethod--widthcalculationmethod
D.


JOSS Submission

Change Description
Checklist

[ ] This PR is meant for the lincc-frameworks/python-project-template repo and not a downstream one instead.
[ ] This change is linked to an open issue
[ ] This change includes integration testing, or is small enough to be covered by existing tests

CMU folks affiliation was recently changed to The McWilliams Center for Cosmology & Astrophysics


Fix igbh example by using proper parameters

Use MpDistSamplingWorkerOptions for samplers in IGBH example and specify proper channel size to avoid "message is too large"error  and RPC timeout in evaluation.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.root seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Wrong define name in  I2C_24LC1025

In I2C_24LC1025 .h and .cpp there seems to be a small mistake in the naming of a define:
#define I2C_DEVICESIZE_24LC512      131072   should probably be:
#define I2C_DEVICESIZE_24LC1025      131072
If you include only I2C_24LC1025 .h in your project there is no problem, but if you also include I2C_EEPROM.h the compiler will churn out a warning as you are now clobbering an already defined macro - which is not what you would want.

Thanks for pointing out.  Never used them in combination.
I will look into this asap.

@whams
Had another look, and it looks like it is indeed wrong -
The define was already in the first version so I assume "copy and paste" to keep the interface identical copied a bit too much.
Made a develop branch with a fix  + some minor edits - https://github.com/RobTillaart/I2C_24LC1025/tree/develop
Can you test that branch for me as I have no hardware nearby.
Thanks,
Rob

@RobTillaart
I've copied your dev branch cpp and header files of I2C_24LC1025 over my local install, added
// 1. select ROM_TYPE from I2C_24LC1025 or I2C_eeprom e.g. 24LC256
// 2. select EEPROM specific buffer size, also used as array size (must be const)
//    should be page_buffer_size minus 2 bytes (for MSB and LSB addresses??) ??
#ifndef ROM_TYPE
#define ROM_TYPE I2C_eeprom
#define BUFFER_SIZE 30
////// OR
//#define ROM_TYPE I2C_24LC1025
//#define BUFFER_SIZE 125
#endif
to my own header file and
// instantiate the EEPROM - we have a 24LC256 or another 16 bit rom
I2C_eeprom eeprom((uint8_t) EEPROM_ADDRESS, (uint32_t) I2C_DEVICESIZE_24LC256);
////// OR
// instantiate the EEPROM - we have a 24LC1025 or another 32 bit rom
//I2C_24LC1025 eeprom((uint8_t) EEPROM_ADDRESS);
to my main.cpp
and while switching between ROM chip on the board (and above comments)  I had no problem or warning on clean compiling my own project.
I've tested instantiation of both ROMs, then setting up the I2C connection and write/readByte of a single byte, write/readBlock of a 20-byte char array, and then write/readBlock of variously sized other char arrays just under or over the respective pagesizes (for the corresponding I2C_BUFFERSIZE), which on inspection of the relevant part of the memdump of the ROM  all produced/failed as expected, that is, char arrays not exceeding the pagesize minus 2 turn out fine, bigger ones produce some strange effects that I can neither explain nor describe simply.  As long as I don't exceed the I2C_BUFFERSIZE minus 2 I seem to be fine.
I still have to do some extra testing on the readBlock readback of correctly written (as I can see in the memdump) data on the ROMs, but my conclusion is that your fixes in the dev branch are all fine and good to go.
Thanks a lot for bringing us this I2C eeprom library, I've tried o few others, but yours works best for me.


cleaned up output

@oxhead please review.

@oxhead please review

I mentioned a corner case before.  When stacked id is not returned, the ctx.abort() should be called.  However, current implementation just print out a warning message.  This might cause an exception at
 waiter.wait(StackName=stack_name)


Font Awesome support

This theme for jstree is absolutely great. Many thanks. I do have 1 feature request. Can we replace the icons with Font Awesome versions? In particular:

The loading icon
The folder open icon
The folder closed icon

Many thanks and keep up the great work!

We originally intended to use font-awesome for the first version to be published but we needed something fast. We will work on the font-awesome implementation and hopefully have something soon.

+1 @vedraan also if you can remove the fonts they are heavy, I did it manually but I think it will be more lightweight and better overall if you drop it :)

+1

+1
no File icon exist, in the current distribution.


Inserted apostrophes in п'ят[ь] and дев'ят[ь]

This should fix issue #3. Also, fixed some tabs where they were spaces. 🙂

LGTM


[WIP] Test if #81148 breaks

…tton pressed (#81148)" (#81557)"
This reverts commit d97f41caed971d4668ffe56699367ec3978db8f6.
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
[ ] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ] I signed the CLA.
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

(PR triage) @dkwingsmt Do you still need this?

It seems that this PR does bring behavioral changes to internal tests in an unexpected way. I would investigate further but still haven't got time for it.

Thanks.


Launch DebugProxy from Blazor WASM (blazorwasm) debug type in VSC

https://github.com/dotnet/aspnetcore/issues/22587

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ec2f61c7-9f51-6735-e328-3c7b495d70c3
Version Independent ID: 4d06e565-282d-6387-aa90-cb2c2986d35a
Content: Debug ASP.NET Core Blazor WebAssembly
Content Source: aspnetcore/blazor/debug.md
Product: aspnet-core
Technology: aspnetcore-blazor
GitHub Login: @guardrex
Microsoft Alias: riande

Closing per https://github.com/dotnet/AspNetCore.Docs/pull/22683#discussion_r668272519.


Python 3 support

Hi,
With the ongoing Spyne for Python 3 support efforts I was wondering if there was any plan to support python 3 as well.
At the moment, the dependency of sec-wall seems to be one of the problems since it only works with python 2.

http://sec-wall.gefira.pl/ homepage no longer accessible

It looks like Spyne by itself is not fully compatible with Python 3, I'm getting:

pip install spyne
Collecting spyne
Using cached https://files.pythonhosted.org/packages/0f/50/62972600a4683a57815d21aca8449c3cb5f5757fad3c1db8d7a82b6445e9/spyne-2.12.14.tar.gz
Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "", line 1, in
File "/tmp/pip-install-wibh69_p/spyne/setup.py", line 51, in
LONG_DESC += "\n\n" + open('CHANGELOG.rst', 'r').read()
File "/ara/devel/venv_python/python3/lib/python3.6/encodings/ascii.py", line 26, in decode
return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xce in position 1895: ordinal not in range(128)
error when trying to install.
Same described here:
https://github.com/arskom/spyne/issues/532
and here:
<EMAIL_ADDRESS>I would wait for a more stable Python 3 support in Spyne first.

It looks like recent versions of Spyne are now Python 3 compatible.
Also, it looks like there is a Python 3 port of sec-wall at https://github.com/flomincucci/sec-wall.


Attempt to write to a readonly database

nvm delete this post I have it running.

How did you fix that?


The description of the component is not updated if it change in Github

Version of HACS
0.1.0

Describe the bug
When the description of the repro is updated it still the old one in HACS.

You should be using v0.2.1, but I don't think that will help.
I have tested this on my dev system (running the upcoming version) an there it updates.

This was fixed... But I checked now, that bug is back, will look into it to the next version.

0.4.2 includes a fix for this.


Fix ESP32 UART configuration for ESP-IDF >= 5.0

Include source_clk field in the uart_config_t struct for ESP-IDF >= 5.0 to address compatibility error.
The issue arises due to a missing source_clk field in the uart_config_t struct in uart_driver_create_port.
In versions prior to ESP-IDF 5.0, this field was not required (tested against 4.4.6), but its absence in later versions leads to the following error at runtime : uart: uart_param_config(748): Invalid src_clk.
The choice of UART_SCLK_DEFAULT was made to allow for automatic selection of the appropriate clock source.
Open to feedback or suggestions for any improvements or alternative approaches.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

Great, done


[SPARK-26739][SQL] Standardized Join Types for DataFrames

Adding overloads for all join methods that take the JoinType parameter instead of string
Testing @deprecated marking for string version

What changes were proposed in this pull request?

Adding overloaded versions of all join methods in Dataset that take the strongly-typed JoinType as the joinType parameter, instead of String.
Keeping String versions, marking deprecated, and simply calling the new versions.
Why are the changes needed?

To make the DataFrame API easier to use.
Does this PR introduce any user-facing change?

Yes, there are new join method overloads available that take JoinType.
How was this patch tested?

sql sbt tests were run.

I'm still trying to figure out how to get the @deprecated stuff to link properly to the new methods... any pointers are appreciated.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

I'm not sure that this feature is useful. As the community, string forms seems to be preferable (e.g., explain modes) because we have other interfaces such as Python/R. WDYT? @HyukjinKwon

Yeah, I am not sure either yet how much useful it is given the amount of changes. Seems like overkill to add every overloaded API too.
BTW, I am okay with adding other types for explain modes later if users want it. I just wanted to start it without it, and see if people want it with typed classes.

Can you elaborate a bit more on the use case vis-à-vis explain modes?  I'm afraid I'm not making that mental connection, and don't see it mentioned in the underlying Jira.

Could you check https://github.com/apache/spark/pull/26898 ?


Would you be interested in moving this to Masterminds?

Hey Alex!
We've been working on building up a bunch of high-quality Go libraries under the https://github.com/Masterminds project. This is one of the libraries that I still use a lot, and I was wondering if you'd like to join the Masterminds organization with this project. @mattfarina and I would like to help maintain and publicize it.
If not, that's cool. We won't be offended.
Matt

Hi Matt!
Long time no speak! I actually thought of you recently (earlier in the day). Sure thing -- I'll be glad to join the Masterminds project with goutils. Just let me know if there is anything else you will need from my end. I hope all is great out there, and hopefully we can catch up sometime.
Thanks,
Alex

Alex,
That is fabulous news! As to the mechanics of it, I think all you need to do is go to Settings and do the Transfer thing. I already sent you an invite to join the org. We should definitely catch up some time. I'd love to hear how things are going on your end.
Matt

Hello Matt,
Sounds great! I attempted the transfer, and there may be a permission issue.
I get this error,

While using these transfer inputs,

I already accepted the Masterminds invitation you sent earlier.
Thanks,
Alex

Oh, there was another check box to check to allow team members to create new repos. Sorry about that. Fixed now.

Nice -- transfer has been completed! @technosophos

I just set you as admin on the project, @aokoli. I'm going to close this issue since I think we're all done. Thanks again!


[4.2] [IRGen] Make -emit-public-type-metadata-accessors a no-op.

This work-around is no longer needed now that the full fix landed in
https://github.com/apple/swift/pull/16615. The argument is left with a warning
to help with migration between compilers with the work-around and compilers with
the full fix (see also rdar://problem/40502379).
Fixes rdar://problem/40476573.
4.2 merge of https://github.com/apple/swift/pull/16808.

@swift-ci please test


NextJS Page Router: SyntaxError: Cannot use import statement outside a module

Hello,
I've been trying to use Revideo from your NextJS starter template. And it works.
Problem is that I don't want to use NextJS App Router, I want to use the Page Router.
And when I do so, I always get the same error, whatever configuration I change:
SyntaxError: Cannot use import statement outside a module
So, I don't really know why it works in app router and not in the page router, all I know is that if I go to node_modules, and add "type": "module" in package.json for the player-react and core modules, it somehow clears the error (I got another one, but different one).
Can you make sure you're producing ESM packages so I can use NextJS Page Router?

I believe that this will be fixed with the upcoming release, #328 should fix it - is that right? @hkonsti


Speech-to-text , whether to support separation of different speakers

Speech-to-text , whether to support separation of different speakers

Hi, there are the following options:

https://docs.microsoft.com/bs-latn-ba/azure/cognitive-services/speech-service/batch-transcription (search for "Speaker separation (Diarization)" on the page)
https://docs.microsoft.com/bs-latn-ba/azure/cognitive-services/speech-service/conversation-transcription

Please check if these meet your needs.

Closed as answered, please reopen if more info needed.


Convert-PolicyResourcesToDetails in parallel does not throw if it fails

Describe the bug
Convert-PolicyResourcesToDetails does not throw if it fails when running in parallel.

Function: https://github.com/Azure/enterprise-azure-policy-as-code/blob/main/Scripts/Helpers/Convert-PolicyResourcesToDetails.ps1
Called from: https://github.com/Azure/enterprise-azure-policy-as-code/blob/main/Scripts/Deploy/Build-DeploymentPlans.ps1

Snippet from our CI/CD run:

To Reproduce
Have a faulty policyDefinition matching the fail that was thrown in the screenshot?
Expected behavior
If ANY of those parallel jobs have ANY failure the function should throw.
Screenshots
Already added to "Describe the bug".
EPAC Version
10.6.2

An obeservation: The starter kit does not set $ErrorActionPreference = Stop when doing Build-DeploymentPlans, and neither do we.

https://github.com/Azure/enterprise-azure-policy-as-code/blob/main/StarterKit/Pipelines/GitHubActions/templates-ps1-module/plan.yml

Default error action in PowerShell is to continue on error.
This might be related? And shouldn't we expect the plan to fail if Convert-PolicyResourcesToDetails has >= 0 failures?

Possibly it should fail - however that code block shouldn't be possible to reach so I'm curious what did the faulty policy look like? I don't want to go down the path of running tests on all the policy objects before they are deployed at this stage.,

Here is the faulty policyDefinition:
{
  "$schema": "https://raw.githubusercontent.com/Azure/enterprise-azure-policy-as-code/main/Schemas/policy-definition-schema.json",
  "name": "3b98831c-f754-4ce7-bb79-b88f99ed9f2c",
  "properties": {
    "displayName": "Inherit a tag from the subscription",
    "mode": "All",
    "description": "Adds or replaces the specified tag and value from the containing subscription when any resource is created or updated. Existing resources can be remediated by triggering a remediation task.",
    "metadata": {
      "category": "Tags",
      "version": "1.0.0"
    },
    "version": "1.0.0",
    "parameters": {
      "tagName": {
        "type": "String",
        "metadata": {
          "displayName": "Tag Name",
          "description": "Name of the tag, such as 'environment'"
        }
      }
    },
    "policyRule": {
      "if": {
        "allOf": [
          {
            "field": "[concat('tags[', parameters('tagName'), ']')]",
            "notEquals": "[subscription().tags[parameters('tagName')]]"
          },
          {
            "value": "[subscription().tags[parameters('tagName')]]",
            "notEquals": ""
          }
        ]
      },
      "then": {
        "effect": "[parameters('effect')]",
        "details": {
          "roleDefinitionIds": [
            "/providers/microsoft.authorization/roleDefinitions/b24988ac-6180-42a0-ab88-20f7382dd24c"
          ],
          "operations": [
            {
              "operation": "addOrReplace",
              "field": "[concat('tags[', parameters('tagName'), ']')]",
              "value": "[subscription().tags[parameters('tagName')]]"
            }
          ]
        }
      }
    },
    "versions": [
      "1.0.0"
    ]
  },
  "id": "/providers/Microsoft.Authorization/policyDefinitions/b27a0cbd-a167-4dfa-ae64-4337be671140",
  "type": "Microsoft.Authorization/policyDefinitions"
}

Parameter "effect" was wrongfully removed. And id amd type at the bottom was not removed.

It may be worth investigating the AzPolicyTest powershell module to perform this testing. The repo can be forked and updated to include tests such as check that parameters specified in the policy rules are also specified in the parameters section. The purpose of the schema in EPAC was simply to provide Intellisense to assist with authoring in VS Code - not to provide strict validation.
Accompanying blog for AzPolicyTest -> https://blog.tyang.org/2024/03/08/azpolicytest-v2-release

So I tested using the on a policy definition - it didn't need to be in the full ARM template version for it to work. If it was me looking to this as I said I would fork that repo and expand on the tests - or help contribute to the original project (which I've see you've already done :) )

My testing:
{
  "$schema": "https://raw.githubusercontent.com/Azure/enterprise-azure-policy-as-code/main/Schemas/policy-definition-schema.json",
  "name": "rg-require-tag",
  "properties": {
    "displayName": "Custom - Require a tag on resource groups",
    "description": "Enforces existence of a tag on resource groups.",
    "mode": "All",
    "metadata": {
      "category": "Tags",
      "version": "1.0.0"
    },
    "parameters": {
      "effect": {
        "metadata": {
          "displayName": "Effect",
          "description": "Set to Audit or Deny"
        },
        "allowedValues": [
          "Audit",
          "Deny",
          "Disabled"
        ],
        "type": "String",
        "defaultValue": "Deny"
      },
      "tagName": {
        "metadata": {
          "displayName": "Tag Name",
          "description": "Name of the tag, such as 'environment'"
        },
        "type": "String"
      }
    },
    "policyRule": {
      "if": {
        "allOf": [
          {
            "field": "type",
            "equals": "Microsoft.Resources/subscriptions/resourceGroups"
          },
          {
            "field": "[concat('tags[', parameters('tagName'), ']')]",
            "exists": "false"
          }
        ]
      },
      "then": {
        "effect": "[parameters('effect')]"
      }
    }
  }
}

Output:

I didn't adjust the file at all (except rename to .json from .jsonc

Nice, you're right @anwather. 😊 I made a PR to add JSONC support.

As discussed, this is caused by invalid policy definitions which can be discovered using AzPolicyTest. I'm going to mark this as an enhancement to be completed at a later date


Consider not logging warnings when not applicable (for pixi envs)

I think warning messages are being logged as follows, however this is causing some confusion amongst users.
Suggestion is to turn this into trace or debug, else it could lead to false alarms.
2024-08-01 22:35:26.028 [warning] could not find a pixi interpreter for the interpreter at /Users/pi/code/2024/spins/.venv/bin/python
:

https://github.com/microsoft/vscode-jupyter/issues/15911

Similar issue https://github.com/microsoft/vscode/issues/223515

Like most other users in the issue threads, I also don't know what pixi is and if I should make the effort to install it.
The warning message doesn't help because it doesn't give any info on what pixi is and what a user is required to do. Agree that it's better as a debug message, but in any case, adding some pointers to help the user remedy the issue would help.
In my case, IntelliSense suggestions stop working midway through my session(I reload the window and it's back to normal, before entering the same loop) and I see this warning followed by an ENOENT error in the output stream.

I started having issue with running pytest  with conda environment recently (last 2 weeks), and I see a similar message, and not sure if it is related.
My conda environment selected is called "testtest", so it's supposed to use that conda environment python env, which includes all the dependencies necessary to run the test. I can run pytest fine from a terminal, but when I open the test tab in vscode, I get:
2024-09-20 10:17:33.815 [info] > pixi --version
2024-09-20 10:17:33.816 [warning] could not find a pixi interpreter for the interpreter at /opt/homebrew/Caskroom/miniconda/base/envs/testtest/bin/python
2024-09-20 10:17:33.830 [info] > python -m pytest -p vscode_pytest --collect-only
2024-09-20 10:17:33.840 [info] cwd: .
2024-09-20 10:17:33.854 [error] /opt/homebrew/Caskroom/miniconda/base/bin/python: No module named pytest

It seems that python extension is switching to using the base python module (instead of conda testtest env that was attempted first), just after the pixi error.
I also tried to install pixi and ran pixi --version, but pixi didn't have that command. I am not even sure if that's the pixi (pypi pixi) it's looking for.
Currently, can't run unit tests, and I can't find any help about this online.
Thanks

@sfc-gh-melnacouzi I am facing the exact same problem. Miniconda + python 3.11.9 on macos.
Here is what fixed my issue. In vscode settings I added :
json
"python.experiments.optOutFrom": ["pythonTestAdapter"]

@sfc-gh-melnacouzi I am facing the exact same problem. Miniconda + python 3.11.9 on macos. Here is what fixed my issue. In vscode settings I added :
"python.experiments.optOutFrom": ["pythonTestAdapter"]

This worked for me.

Didn't change a thing for me, oddly enough.
This is really irritating.
I'm glad I at least found this issue to explain that it wasn't anything wrong with my setup or project - it's just this plugin going "Hey, this thing you didn't install, never heard of, and have no intention of using? It looks like you don't have it set up." at [warning] level.

Hi @Nekkowe! Are you able to try on the most recent release and make sure your VS Code is also up to date? We moved it out of warning level recently so it shouldn't appear. Secondly this isn't explicitly related to "python.experiments.optOutFrom": ["pythonTestAdapter"] but the two could be correlated.

Hi @eleanorjboyd!
Thank you for letting me know - on the latest release, the warning appears to changed to [warning] Dir <project path>/.pixi/envs" is not watchable (directory does not exist)
2024-10-02 21:05:15.997 [info] Telemetry level is off
2024-10-02 21:05:15.997 [info] Experiments are disabled, only manually opted experiments are active.
2024-10-02 21:05:15.997 [info] Experiment 'pythonTestAdapter' is inactive
2024-10-02 21:05:15.997 [warning] Dir "<path to my project>/.pixi/envs" is not watchable (directory does not exist)
2024-10-02 21:05:15.997 [info] Default formatter is set to null for workspace <path to my project>
2024-10-02 21:05:15.997 [info] > conda info --json
2024-10-02 21:05:15.997 [info] Python interpreter path: /bin/python3
2024-10-02 21:05:16.006 [info] > pyenv which python
2024-10-02 21:05:16.006 [info] cwd: .
2024-10-02 21:05:16.955 [info] Starting Jedi language server for lazygal.

@anthonykim1- might have more context on this

Yes, related: https://github.com/microsoft/vscode-python/pull/23942
There has been couple PRs to log level down pixi as much as possible if deemed unnecessary for folks who do not even intend to use pixi at all.
@Nekkowe Are you trying to use pixi environment? Otherwise you could save ignore that warning. We could look at leveling this down further just like https://github.com/microsoft/vscode-python/pull/24164/files.

I wasn't trying to use pixi environment, nope - I'd never installed, heard of, or had any intention of using pixi. So you can imagine my confusion seeing this warning! 😄

I don't see any reference to pixi in the logs, is there any special environment type I need to set up to verify this or is that good enough? @karthiknadig

That is it. You should see something only if there is pixi installed.


[5.9][Build] Skip early-* on non-darwin hosts

Explanation: The linux images now contain a host swift, which enables the early* products by default. But these builds don't work outside of Darwin currently, which breaks all presets that don't explicitly disable them. Rather than add these flags to all necessary presets, instead disable for all but Darwin in the products themselves.
Scope: No-op, this brings us back to the behavior prior to having a host swift installed
Risk: Low
Original PR: https://github.com/apple/swift/pull/68091
Testing: CI (no extra tests)

@swift-ci please test

@swift-ci please test

@swift-ci please test


Demo: push-based decoding

This is a demo of push-based decoding - sloppy programming ahead! Insufficient error handling, no DoS protection, missing checks during decoding, missing documentation, some things (no-std) not tested, different MSRV...
I'm mainly gathering general feedback: is this something we want to do? Do you think the added complexity is worth it? Do you have other ideas to improve it (other than intentionally ignored parts).
Note that this is currently just decoding, encoding to come later unless this proposal is rejected.
Also regarding MSRV, I could make it lower but it'd help if I didn't have to. It should be 1.51 but I didn't actually check - I tested with 1.63. What do you think about bumping it?

I've just learned about ControlFlow which I think would be much more clear than Result<Infallible, Result<(), Error> but the MSRV would have to be 1.55. What do you think?

Neat! I am in favor of using ControlFlow. Maybe initially we should add this API in parallel to the existing one and cfg-gate it on 1.55. It seems like on the MSRV-for-stable thread we've achieved rough consensus on something in the mid-1.60s but we're waiting on Debian and the 2-year rule to actually pull the trigger. Something of this scale I think we'd want some real-world testing before fully cutting over to it, so it could make sense to have a parallel API.
cc https://github.com/rust-bitcoin/rust-bitcoin/issues/1251 where push-based decoding was first discussed.

I'm not sure how much we can feature-gate it if we want to delegate the impls. (Maintaining two different implementations is annoying; though thankfully they shouldn't change much.) If we're going to do that I would limit it to one release or so.
Also I don't think we can reasonably feature gate it on Rust version - cfg in Cargo.toml doesn't support that and putting #[cfg] ins the entire stack seems too much.
Note that 1.55 is already >2 years old (September 2021) and 1.63 is in Debian stable. But if we're going to bump it I'd jump to 1.56 which is still 2 years old and supports edition 2021 (we don't have to use it right away but it's nice to have).

Sounds good to me. cc @tcharding is there an existing issue that we should glom onto to discuss MSRV bumps, or should @Kixunil just make a PR to bump to 1.56 and we'll try to get a bunch of ACKs.
cc #1722.

Lets PR and push forward! I tried bringing up Rust 1.57 a few months ago but I was too early because it was not yet 2 years old, https://github.com/rust-bitcoin/rust-bitcoin/discussions/1983
I'd like to see 1.56, edition 2021 would make my life a bunch easier.

I'm keen for this. I don't have any comments or suggestions other than that I'm afraid.

Just in case you go to do it @Kixunil, I did the MSRV bump https://github.com/rust-bitcoin/rust-bitcoin/pull/2188

I'm keen for this PR. I don't have any comments or suggestions other than that I'm afraid.

That's fine. I was mainly checking that my approach isn't viewed as horribly complicated or something like that.

Updated to use ControlFlow, edition 2021, and a new method I added to clean up the code a bit.

Rebased and a bit improved but not really ready. Working on encoding now.

I believe this is potentially ready for merge.

OK, maybe not entirely. I think you can still review it since the changes will be minor. Will fix tomorrow.

The git history is quite messed up and I'm not sure what would be the best way to modify it for you to understand the changes easily. Does splitting encoding/decoding make sense? Probably there shouldn't be commits "split file" and "add documentation" I just didn't have much energy yesterday to clean it up.

I'd basically say, do as much splitting as you can get away (e.g. between push/pull and between encoding/decoding and between traits and implementations) with while still having commits that compile by themselves.
But then the commits should put stuff in their final locations with bugfixes applied.

But then the commits should put stuff in their final locations with bugfixes applied.

Yes, I was constantly editing history and then gave up just to get this to compile (still no clue about the embedded failure), then I became unsure what's the best approach, so I took a break and asked. Will do it properly (but first resolve the embedded stuff.)

I started reviewing but its going to take me a few goes.

@Kixunil I added Closes: #1251 to your PR description, hope you don't mind.

Yeah, didn't have much time to clean this up.

No sweat, when you get to it.

Hello @ksedgwic, I just saw ligtning-signer and thought you might be interested in this PR.

Yeah, saw it. It's super interesting how similar they are. Aside from method naming, I just used traits since the thing repeats and there are convenience methods that can be written generically.

I'd like to review this soon but needs rebase.

Ok, that's definitely understandable. I think that means though that we will need to punt on push_decoding for at least one release cycle (i.e. 3 months), probably two and possibly more.
Meanwhile @tcharding and I will continue to work on crate smashing.

we will need to punt on push_decoding for at least one release

I think that's OK.

I plan to revive this soon. However I have an important question. For a while I was considering changing self in decoder to self: Pin<&mut Self> because it'd allow us to use coroutines once they are stabilized. (Sadly can't be tried in nightly yet because of https://github.com/rust-lang/rust/issues/68923) I also wanted to make the trait object safe (though TBH I'm not really sure it's that useful - the possibility just naturally comes from changing self to a pin) and keep the possibility of partial moves which is useful for decoders decoding Vecs and such. However it's not really trivial and I feel like I've hit every single limitation of Rust. I still managed to workaround the limitations to the point that I think it'll be usable, just internally complicated. It does have one annoying downside: there's many unsafe lines. They basically only encode one requirement: "don't call any methods except for drop after one of the three methods panics/resolves. This is pretty simple to ensure and there are safe wrappers from both implementor and consumer side. I still need to rework some parts but that should be a minor issue.
Is it acceptable for a dependency to have that much unsafe internally? An alternative would be to keep the current interface which is still used on the impl side (implementing it implies all the unsafe suff is usable) and then have the advanced stuff in a separate crate for people comfortable with unsafe. However if we do this we will likely never be able to use coroutines in our crates to provide encoders that can be used with any IO unless we whitelist supported IOs (that sucks) or pretend that our types are already pinned in which case we have to wrap all the encoders in Option which worsens performance a bit and we can't remove it backwards-compatibly unless we also reimplement a chunke of new push_decode API that enforces the rules which would make our crates more complicated.

@Kixunil I'm gonna have to say no, for the non-principled reason that none of us will be able to review this. I have barely used async, barely used Pin, never used coroutines, and already struggle to review a PR with so many lines of code that dramatically changes the API into a new form. Adding safety constraints on the API would be too much.
I think this needs to be a 2.0 thing, and probably one that first lives in a "3rd-party" crate for a bit.

Hmm, that's true. While I found a way to significantly dumb down complicated unsafe code it's a lot more lines of code. (Bunch of new types etc. implementing safe abstractions.) And now I've realized that the compatibility isn't even that interesting - anything that impls the current decoder can trivially impl the new one and the functions don't really have to be compatible at all costs since it's likely that decoders will be just passed to them instantly after creation (not passed around), so there are no trait bounds to update, just the functions.

Just rebase, will address the review later.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

726 of 958 (75.78%)  changed or added relevant lines in 14 files are covered.
23 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-0.3%) to 82.914%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

bitcoin/src/consensus/serde.rs
0
1
0.0%

bitcoin/src/consensus/encode.rs
39
42
92.86%

consensus-encoding/src/units_impls.rs
3
6
50.0%

consensus-encoding/src/lib.rs
46
50
92.0%

consensus-encoding/src/decode.rs
39
49
79.59%

consensus-encoding/src/varint.rs
71
96
73.96%

bitcoin/src/blockdata/witness.rs
87
118
73.73%

consensus-encoding/src/vec.rs
32
70
45.71%

consensus-encoding/src/encode.rs
205
262
78.24%

bitcoin/src/blockdata/transaction.rs
179
239
74.9%

Files with Coverage Reduction
New Missed Lines
%

bitcoin/src/blockdata/witness.rs
1
85.94%

bitcoin/src/blockdata/transaction.rs
4
86.74%

bitcoin/src/consensus/encode.rs
6
91.09%

bitcoin/src/consensus/mod.rs
12
34.33%

Totals

Change from base Build<PHONE_NUMBER>2:
-0.3%

Covered Lines:
20226

Relevant Lines:
24394

💛  - Coveralls

Also I'd love to rebase this on top of #3100 (not that I love rebasing this monstrosity...)

Concept ACK.
Just spent whole morning trying to understand. But after a few hours it started to click. Pretty cool!
TLDR: It's all basically Rust version of Haskell's binary package :-)
data Decoder a = Fail !B.ByteString String
              | Partial (Maybe B.ByteString -> Decoder a)
              | Done !B.ByteString a
              | BytesRead !Int64 (Int64 -> Decoder a)

newtype Get a = C { runCont :: forall r.
                               B.ByteString ->
                               Success a r ->
                               Decoder   r }

type Success a r = B.ByteString -> a -> Decoder r

instance Monad Get where …

But after a few hours it started to click.

I knew I wanted to expand the documentation a lot but damn, I didn't expect it to take people hours without it. :(
Good to know.

I didn't expect it to take people hours without it. :(

There are many details to understand, part of them in push_decode which I was not familiar with; for example: in transaction decoder, what do sub_decode + wrap_sub_decode do and why? how do all the macros work? etc.
I don't think it's problem of documentation, rather it's the size and (inherent) complexity.

Yeah, the thing is, I hope it won't be required to understand all of it to get benefits. Basically understand the basic idea, have examples how to use it and some examples how to implement decoders/encoders. sub_decode and wrap_decode are indeed a bit weird but pretty niche and thankfully also somewhat nice.
Side note: I had some other ideas that would make the crate even bigger but would result in simpler usage. Some of those ideas are quite crazy though :D.


feat(sidecar): ERC-2335 Keystore signer

Closes #283. This PR introduces support for running the sidecar by reading the private keys from ERC-2335 keystore files.
Such keystore are expected to be placed inside the keys folder of this project which reserved for this purpose only. While we could allow fetching them from a specified path, I like the idea of the sidecar not reading arbitrary folders of the users by mistake.
Some refactoring changes have been done as well:

All different signers have been moved to a signer folder
SignerBLS trait has been transformed into an enum because there's not a common trait for all type of signers
Config struct has been absorbed into Opts by squeezing Clap functionalities

TODO:

[ ] tests
[ ] produce keystore files in the devnet

The config refactor is very nice! Left some comments but overall great.
Wrt the signer, this is what I understand from the current flow with the Keystore:

sidecar is started with keystore CLI flags + validator-indexes flag
at each slot, we check if the proposer duties contain one of our validator indexes
if so, we try to find the pubkey from the keystore and sign the constraints with it

It would be cleaner to use the keystore as source of truth for which pubkeys we can use to sign messages in the first place, instead of going through validator_indexes.
In particular here's how I imagined it:

sidecar is started with keystore CLI flags
all pubkeys are loaded in memory when creating the keystore
at each slot, we check if the proposer duties contain on of our pubkeys
if so, simply sign it with that key

let me know your thoughts

Thanks for the great review! Yes the flow you described is indeed correct. You're right that in the context of the keystore signer the process of checking validator indexes is redundant. I have to think whether it's still needed for other type of signers though


Add UDP support

It would be great to be able to do quality checking on UDP connections as well.
The system would have to be slightly more complex than TCP QC, since UDP connections are long lived and there are more things that can go wrong.
It could make sense to test two main things:
1/ Are we able to repeatedly create new connections with the UDP endpoint without errors? How long does the handshake take?
2/ Are we able to send and receive messages over the UDP connection? How much latency is there? Are some messages getting lost?
A simple approach could be to do it in a similar way to the TCP test, which is to create a connection, send a message, expect to receive it back, check latency, close connection. But it could also make sense to send multiple messages on the UDP socket instead of a single one.
A more interesting approach could be to send quite large amounts of data instead of a single probe message, to check for the bandwidth speed as well, since UDP is usually intended to send live data, in possibly large amounts.

Sounds good. I would also start with a simple approach and just print the message when received (potentially out of order) and consider it lost when not received after a certain time.


Can't install mysql-server-5.6 on Ubuntu 14.04

Some errors from chef:
       STDERR: start: Job failed to start
       invoke-rc.d: initscript mysql, action "start" failed.
       dpkg: error processing package mysql-server-5.6 (--configure):
        subprocess installed post-installation script returned error exit status 1
       Errors were encountered while processing:
        mysql-server-5.6
       E: Sub-process /usr/bin/dpkg returned an error code (1)
       ---- End output of apt-get -q -y install mysql-server-5.6=5.6.33-0ubuntu<IP_ADDRESS> ----
       Ran apt-get -q -y install mysql-server-5.6=5.6.33-0ubuntu<IP_ADDRESS> returned 100
       [2016-12-01T23:46:36+00:00] FATAL: Chef::Exceptions::ChildConvergeError: Chef run process exited unsuccessfully (exit code 1)

@colby @hardyjohnson I'm stumped by this one. Centos 7 and Ubuntu 16 both work, so I am moving on to other issues.


Replace %llu with PRIu64 for compatibility

Failed to compile here on x86_64 Arch Linux with gcc 4.6.2, so I fixed it according to http://stackoverflow.com/questions/165188/printf-uint-64-on-solaris-9

Thanks! There were also a couple in file.c that got missed.
I fixed those in a separate commit.


Incompatible with release version

A15 has officially came out, so I figure just in case the CCL team wasn't aware, I'd make this an issue.
Apologies if it bothers anyone.

We are well aware of the A15 status, but we all have day jobs and modding is a hobby.  Please be patient.


Fix - Changing column width changes adjacent column sorting order

Description
Changing column width changes adjacent column sorting order
Fixes #624
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manually tested

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Hey @riodeuno @vicky-primathon  I saw the PR for the column width interaction, it still doesn't work very well. When I drag a column to the right to increase it's width, the left also expands and crushes the columns to the left

Hey @riodeuno @vicky-primathon  I saw the PR for the column width interaction, it still doesn't work very well. When I drag a column to the right to increase it's width, the left also expands and crushes the columns to the left

There's a problem with the PR where the columns mismatch with the cells

There's a problem with the PR where the columns mismatch with the cells


Add ability to see which channel an invoice was paid through

When one of my invoices is paid, I would like to be able to find out which channel it was paid through.  The lookupinvoice API doesn't appear to show this information.  It would be great if it had a parameter like "paid_via_channel" or something, to show that information.
The only record I found was 1 line in my log file, and I'm not sure how to convert that into a channel ID.
Jun 06 20:10:27 lightning lnd[9736]: 2019-06-06 20:10:27.206 [INF] HSWC: ChannelLink(579257:1314:0) settling htlc 5a01a8d122f1afbc5071901ff9724d467b48d0b32af64cc8fa14c0a434507fad as exit hop

@ashleyholman this is indeed useful, but requires some pretty low-level changes to lnd internals. there is an ongoing refactor that will eventually enable this. the bulk of the work will be addressed in fixing https://github.com/lightningnetwork/lnd/issues/2208, then the final step would be exposing this info over rpc

A workaround could be to use the hold invoice feature, but you'd have to find the matching held HTLC in listchannels and do the cross referencing yourself

Fix coming up in #3390


Assertion fail on OpenMP runtime

Two tests (task-two and parallel-reduction-nowait) are failing because of:
OMP: Error #13: Assertion failure at kmp_sched.cpp(85).

@jprotze do you have any idea why?

Yes, to provide a conforming implementation, we had to introduce compiler support. With old compilers, the flag is not set with a valid value, which results in the assert.
There is a deprecated-workshare branch, that changes this assert to a warning about an outdated compiler.

Can we cherry-pick that?

I'm currently pushing this patch to upstream (I guess it will land in the next few days):
https://reviews.llvm.org/D39890
Until then, you can simply use the branch for testing: https://github.com/OpenMPToolsInterface/LLVM-openmp/tree/deprecated-workshare
@simoatze : With that fix in upstream LLVM, you can switch to the upstream LLVM/OpenMP runtime.

@jprotze Thanks! I tried the deprecated-workshare and it passes all the tests.
I'll switch to the upstream LLVM/OpenMP and do more tests.

The patch landed in upstream llvm/OpenMP about an hour ago.


Day 2 documentation

By shaket

@SVijayB please check the changes.

@ojasva changes requested from the initial review is yet to do be done.

[ ] Removing summary tags and switching to headers.
[ ] Changing <br> tags \
[ ] Clustering links to gether and following format provided.

@ojasva status on this?

@ojasva status on this?

on it sir, a bit occupied with labs and college environment for the first time, so pardon for delays please

It's cool, no issues. Take your time xD

Bump

Bump

Meaning?

Bump

Meaning?

Bump is an online slang term for the practice of posting filler comments to move a post to the top of a discussion thread, increasing a message or thread’s status and visibility. XD

@ojasva any updates on this yet?


Exception calling "Save" with "1" argument(s): "Object reference not set to an instance of an object."

I have a DataConfig.config file
that contains this connections string

<add connectionString="data source="";UID="";PWD="";initial catalog="" name="Sitefinity" />

I created a new transform file
and I called it DataConfig.sfstg.config
and my transform file looks like this

but i am getting this error when hitting the xdt transform task:

It was working fine last week, but it failed today.

resolved


Use ActivatorUtilities for consumers

Context: https://stackoverflow.com/questions/64055301/masstransit-dependencyinjectionconsumerscopeprovider-can-create-consumers-withou
@phatboyg  I didn't write tests, need some help with test cases
I think I will need to add CreatedCount to SimpleConsumer to track instantiation times

This broke almost every test related to MS DI, so I'm not sure this is going to solve anything.

I think that it will not work...
Closing


Proxy with nist-data-mirror

Hello team. In my issue i had problems like in #2039 and #1679 and to fix them i need to use proxy and nist-data-mirror.
In our project we use proxy server, and i need to update NVD & RetireJS. If i start dependency check without proxy configuration and with NVD & RetireJS configuration - NVD & RetireJS can success update, but DependencyCheck fails cause haven't got internet connection:
If i start  with proxy parametrs and with NVD & RetireJS parametrs DependecyCheck correct work first 4 hour when skips NVD check (Skipping NVD check since last check was within 4 hours). After 4 hours dependency check fail cause can't connect to nist-data-mirror via proxy.
So can i somehow to first update dependency check without proxy and then start check project with proxy? Somehow like this:
just updates bases
dependencyCheck additionalArguments: '--cveUrlBase http://<IP_ADDRESS>:8082/nist/nvdcve-1.0-%d.json.gz --cveUrlModified http://<IP_ADDRESS>:8082/nist/nvdcve-1.0-modified.json.gz --retireJsUrl http://<IP_ADDRESS>:8082/js/jsrepository.json', odcInstallation: 'dependency-check-5.2.1'
just checks
dependencyCheck additionalArguments: '--scan /var/jenkins_home/workspace/devproject --format XML --format HTML --proxyserver <IP_ADDRESS> --proxyport 3128 --disableOssIndexCache --disableCentralCache --disableNodeAuditCache', odcInstallation: 'dependency-check-5.2.1'
OR can you add some command line true/false argument like --nexusUsesProxy , --artifactoryUseProxy ? To example --cveUrlUseProxy and --retireJsUseProxy
OR can you add some command line argument like linux or jenkins no proxy configuration? To example --noProxyHost , --noProxy , --proxyException with Parameters like "<IP_ADDRESS>, localhost, *.cnn.com, <IP_ADDRESS>, domain.com:8080" or --noProxy <IP_ADDRESS> --noProxy localhost --noProxy *.cnn.com --noProxy <IP_ADDRESS> --noProxy domain.com:8080

The proxy may not be proxying the NVD.  Consider running this in two steps:
dependency-check --updateonly
dependency-check --noupdate [setup proxy] ...

While not exposed as a property yet in the CLI you could do something like:
export JAVA_OPTS=-Dproxy.nonproxyhosts=non.proxy.host

TODO: expose the non-proxy host configuration to the CLI, Ant, etc.

Turns out --nonProxyHosts was already implemented.


lint #include list in ch local-engine

Currently, #include list in ch local-engine are sort of misorder.

some headers files are quoted with "", while others are quoted with <>
header files are not grouped by modules
some headers files are included unnecessaryly.

@taiyang-li @liuneng1994
I think we use clang format of clickhouse,  add this to  cpp-ch/CMakelists.txt
find ./local-engine -regex '.*\.\(cc\|hpp\|cu\|c\|cpp\|h\)' -exec clang-format-15 --verbose --dry-run -i --style=file:./ClickHouse/.clang-format -i {} \;

We also need update Docker to include clang-format.
Developers should install  clang-format and run above command without --dry-run(should update doc)


Update DataLoader.lua

@takatosp1 , thanks for updating DataLoader functions. Could you update test.lua as well to include a unit test for the new implementation if possible? We'd like to keep this good practice for better quality maintenance.

Sure wait me work on it

@nicholas-leonard , thanks for the recommendation! You're right, it makes sense to keep the base class general rather than covering sub-cases.

@takatosp1, would it be OK to leave your changes separate from the main branch such that it won't cause any potential conflicts with sub-classes? Please let us know if you have any other suggestions.