Fix include path for pkg-config

yajl headers are supposed to be installed straight into $PREFIX/include/yajl
and they're supposed to be included as <yajl/yajl_something.h>, according to
the documentation.
However, pkg-config returns CFLAGS as $PREFIX/include/yajl and that
breaks build because "#include <yajl/yajl_something.h>" can't find the
header.
This is a problem if $PREFIX is different from /usr or other include
directory that's used implicitly (which is a case on macOS with
homebrew, where every package has its own $PREFIX).

I've fixed this on my fork:  https://github.com/robohack/yajl  (on the default "bsdmake" branch).  There are other fixes also included in my branch, as well as a rewrite of the build system and documentation generation (to avoid the CMake disaster), as well as a full replacement for the pgksrc devel/yajl module.


refactor: refactor parameters and cleanup (draft)

PR-Codex overview
This PR focuses on refactoring the handling of NexusAccount instances, replacing the use of signer with client in various functions and tests. It enhances the integration of smart session validation and improves the overall structure of the code.
Detailed summary

Replaced signer with client in toNexusAccount and createNexusClient.
Updated test files to reflect changes in account creation and client handling.
Added console.log statements for debugging client account information.
Refactored methods to use NexusAccount directly instead of relying on signer.
Improved the structure of createNexusSessionClient to utilize NexusAccount.
Ensured nexusClient and sessionClient use the updated account model.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

You're gonna have to work hard to explain why this is a good idea! I feel like this un-abstracts a useful abstraction, and makes createNexusClient identical to createBundlerClient


Version bump psycopg2 and uwsgi to prevent segfault on heroku

Seems to fix #257.

Should psycopg2 be changed to psycopg2-binary?


Master layout unwanted gap between master and client on vertical bar

Steps to Reproduce

Enable master layout by running hyprctl keyword general:layout master, or enabling it in hyprland.conf:

general {
   layout=master
}

Set up and enable vertical bar with "exclusive" zone from compositor option ON. In my case, I tried eww and waybar with both resulting the same bug.

The vertical bar could be on either left or right side of the screen

Open master and stacks clients

Observe the gap between master and stacks

Expected Outcome

No gap increase between master and stacks
The client not pushed far to the right

Noted Outcome

Extra gap space between master and stacks  (probably Hyprland regard it as an exclusive zone)
Stack pushed far to the right

When the bar is on the right, the client window is pushed to the bar area
When the bar is on the left, the client window is pushed off the screen

Consult the attached video below:
https://user-images.githubusercontent.com/20262272/205470176-2d7ff404-ecd3-49f0-9e4d-ddf6fa484283.mp4

You might want to check if this persists after #1202 is merged, I think I spotted and fixed this issue (though I didn't explicitly test it with a vertical bar yet).

Hi, Thanks for the fix and the new feature.
I am using AUR build hyprland-git. I added orientation setting to my hyprland.conf and orientationprev-orientationnext dispatcher to my keybindings. The issue is fixed for master orientation of left, up, and down. But persists on master orientation right. The attached video below showing when the vertical bar is on the right, I also test with the vertical bar on the left and the issue still persists.
https://user-images.githubusercontent.com/20262272/206946748-52c57c15-1866-4f4b-888a-fdce0462c38c.mp4


RedirectService doesn't preserve query parameters

I noticed RedirectService by default redirects without preserving query parameters. There is the locationFunction that could be used by users to preserve query parameters, but I guess this might be common enough that we provide such a location function that preserves the query parameters, or even just always preserve them. What do you think?

/cc @adriancole @tacigar

See https://github.com/line/armeria/pull/1726


unable to create .binaryproto for vision kit

I wanted to convert pretrained model (mobilenet_v1_0.5_160_quant_v1.pb) into .binaryproto,
commands used :-
./bonnet_model_compiler.par
--frozen_graph_path=./mobilenet_v1_0.5_160_quant_frozen.pb
--output_graph_path=./mobilenet_v1_0.5_160_quant_v1.binaryproto
--input_tensor_name="Placeholder"
--output_tensor_names="final_result"
--input_tensor_size=160
--debug
It shows error :-
F graph_conversion/prune.cc:63] Output node named "final_result" does not appear in the graph.
If i vsiualize graph on  tensorboard,

we can see last node final_result .
So, what should i do to resolve this,
Thanks

@jass-singh
First of all, VisionKit does not support quantized model.
We did release some pretrained models, you can download this file
https://dl.google.com/dl/aiyprojects/vision/tf_models_latest.tgz
Decompress it and you can find README.md.  and use the corresponding input tensor and output tensors name in the table.
For your graph, pass
--input_tensor_name="input"
--output_tensor_names="MobilenetV1/Predictions/Softmax"
for mobilenet_v1_160res_0.5_imagenet.pb

Thanks @weiranzhao ,
using those commands i was able to convert successfully,
Actually i want to initially detect the animal like dog using 1 model , than perform classification on it using classifier by passing only that part of image which would be detected as dog by the model. At last display label with the breed of dog.
So, is it possible to combine 2 models in Vision kit ?
If yes , please suggest some method.
Thanks,

@jass-singh
There are 2 methods I can think of to achieve what you need.

retrain a detector, that can recognize more dog breeds.
Have 2 separate models, a) detector b) classifier. You need to run detector on the input stream, and get result (bounding box and image) from VisionBonnet (the accelerator on top of pi board). Then you can crop the image based on bounding box  on pi and then send the image to accelerator to analyze with classifier and get result.

I'd suggest method 1) because it will give you better FPS. You can find retraining related instructions here.
search How to train and deploy a customized object detection model in
https://aiyprojects.withgoogle.com/vision/#makers-guide--tensorflow-model-compiler


Regular expression to accept any amount of numbers/chars

Hi all, not sure if I'm doing this correctly however just need a simple mask to match again unlimited amount of character or numbers. Tried /\d+/ but this does not work, could someone point me in the right location. Thanks

You need to use mask as a function instead of a set string. Essentially, you need to dynamically build a new mask as the user inputs a character.
See: https://github.com/text-mask/text-mask/blob/master/componentDocumentation.md#mask-function

Yes, use a mask function .. see #521 for an example


"implicit root" is unclear

The spec says
"The intersection root for an IntersectionObserver is the value of its root attribute, or else the top-level browsing context’s document node (referred to as the implicit root) if the root attribute is null."
But which browsing context are we referring to here? What if there are two top level windows and same
IntersectionObserver is used in both windows? It may not actually work, but what if one anyhow tries, which browsing context are we talking about here?

And which document are we talking about during and after window.open(url).
(that creates first the initial about:blank document and then creates a new document for url, but reuses the Window object)


fix(tooltip): added show on focus and removed bad lint naming

Describe pull-request
Added show on focus and removed bad lint naming, changed '_this' to 'thisValue'. Exposed the slot as a control in storybook. Wrapped template in formatHtmlPreview.
Solving issue
Fixes: AB#2641 AB#2646
How to test

Go to storybook link below
Check in Components -> Tooltip
Try tabbing through the page and test if the tooltip shows

Screenshots
Additional context

Really nice idea to have control for passing content to the tooltip and a very good idea for the tooltip showing on focus - please share with others in next devCheckIn!

Will do!


MFA Authentication within the same application window

If we try to do an interactive authentication with JDBC using MFA (Multi Factor Authentication)
What happens by default is a new instance of the browser opens then the authentication is done, then the browser will redirect to a localhost with a random port number, and the process finishes with no authentication.
Ideally we would have the MFA open on the same application, avoid creating a new instance of the browser and once authenticated get the token and make the application work.

@Schmlughtz007 What driver version did this occur on? I recall there being related fixes with interactive auth, so depending on the version it may have been corrected.

Hello @tkyc
It was with the version 12.6.1 of the driver , argh I juste saw that thé latest is 12.7.0 do you think it has been resolved in thé latest version?
Thx

The driver is the jdbc Microsoft driver

It was with the version 12.6.1 of the driver , argh I juste saw that thé latest is 12.7.0 do you think it has been resolved in thé latest version?

Disregard what I mentioned earlier. I reread your post just now, earlier I had misunderstood your original post.

What happens by default is a new instance of the browser opens then the authentication is done, then the browser will redirect to a localhost with a random port number, and the process finishes with no authentication.

This is the expected behaviour eg. when a new browser window opens.

...and the process finishes with no authentication

Are you saying interactive auth is failing for you? You're unable to auth to the server through interactive?

Ideally we would have the MFA open on the same application, avoid creating a new instance of the browser and once authenticated get the token and make the application work

So you want MFA to open a new browser tab, within an existing browser? Instead of a new browser instance? If that's the case, that isn't something the driver doesn't have control over. All that is delegated to MSAL4J.

Hello @tkyc
OK, I'll try to explain what I am trying to do, and what is not working.
I wanted to use an application, let's say dbschema (a java application), by the way the same problem arises for other db modeling like tools).
In dbschema after installing the driver, I want to connect with MFA.
The problem is when I click connect from DBSchema, there is a web browser (outside of DBSchema) that opens to authenticate with the MFA. Once the authentication is done the Web Browser redirects to a localhost and a random port number (screen shot of the bug I mentionned) And DBSchema keeps waiting for a feedback from the browser, a feedback that never comes.
This article explains the issue in Microsoft : https://learn.microsoft.com/en-us/troubleshoot/sql/ssms/cant-reach-this-page
So Microsoft resolves the issue by opening the authentication MFA screen directly in the tool (SSMS) and not in a browser.
I was thinking if in the driver you could force the opening to be a native popup instead of having an opening of the Web Browser?

@Schmlughtz007
Thanks for the clarification. I see your point. However, the driver doesn't have control over the browser popup. We delegate to msal4j to do interactive auth and so they're opening the browser. We don't have control over this within the driver.

This article explains the issue in Microsoft : https://learn.microsoft.com/en-us/troubleshoot/sql/ssms/cant-reach-this-page
So Microsoft resolves the issue by opening the authentication MFA screen directly in the tool (SSMS) and not in a browser.

From the article, it suggests defaulting your system browser to Windows Edge. If you haven't already and if possible, I recommend trying that.

Hi @Schmlughtz007,
Let us know if this answers your concerns. Without further reply we'll be closing this issue in a few days.


[Curiosity] Will NSComboBox be considered in the future?

It looks like NSComboBox is neither natively supported in SwiftUI.

Grab the latest 8.7.0 - this contains a basic NSComboBox implementation (ComboBox)

@dagronf Thank you for the implementation. It seems fine to me.
Closing this issue now.


feat(irsa): Prevent error thrown when using wildcards in iam role trust policy with a service account creation

What does this PR do?
🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

Resolves #1419
it's possible this is not a feature and fixing a bug since using wildcards in iam role trust policies was introduced in pr #244

More

[x] Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
[ ] Yes, I have added a new example under examples to support my PR
[ ] Yes, I have created another PR for add-ons under add-ons repo (if applicable)
[ ] Yes, I have updated the docs for this feature
[x] Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

Use an existing example when possible to demonstrate a new addons usage
A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

[ ] E2E Test successfully complete before merge?

Additional Notes

> join("", compact(regex("([a-z0-9])([-a-z0-9]*[a-z0-9])+(\\\\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*", "datadog-*")))
"datadog"

thank you for the issue - as we move forward with the project, we will not be continuing to support this addon within the project. if you wish to use Datadog you can utilize the helm_release resource to add support in your environment


Why doesn't it work :( ?

My config for app:
`rtmp {
server {
listen 1935;
chunk_size 4096;
            application live {
                    live on;
                    record off;
            }
    }

}`
If I play RTMP stream I have error:
https://kazpic.kz/vnR

Why you have /app/live, it should be just /live


Need update

very useful library, with new google drive not working, update needed, please help

https://github.com/rbtr/Drive-Database-Sync/issues/6

feel free to submit a compatibility patch however i have not updated this repo in a couple of years and really don't have time to maintain it


SAA-1782 status is not mandatory

Codecov Report
Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.08%. Comparing base (62d10c4) to head (be63baf).

Files
Patch %
Lines

...mentapi/client/prisonersearchapi/model/Prisoner.kt
50.00%
1 Missing :warning:

...iesmanagementapi/service/MigrateActivityService.kt
0.00%
0 Missing and 1 partial :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #907      +/-   ##
============================================
- Coverage     84.09%   84.08%   -0.01%
- Complexity     3577     3578       +1
============================================
  Files           372      372
  Lines         11700    11701       +1
  Branches       1028     1028
============================================
  Hits           9839     9839
- Misses         1401     1402       +1
  Partials        460      460

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Modify popup contents and formatting

[x] Include Google Street View link (like in the geoportal) and Street View.
[x] Format popup as displayed below
[x] Add City limits last updated date

Route005
Milepost DirectionIncreasing
Milepost123.23
Lat/long134.23, 65334.23
CitySeattle
CountyKing
Township Rangeetc

More …

Ramp:05P13455
Ramp Milepost1.23

Moved some of the checkbox items to separate issues.


74 testconnectivity.microsoft.com - IP-Addresses

For restricted customers, it would be required to know the Source-IP-Addresses in use by testconnectivity.microsoft.com to test against the local Exchange-Servers. So if customer is blocking every incoming traffic except O365 ip-ranges, the test-traffic would also be blocked.
In the past, following ips were used: <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS> - but it is stated in the version history that the ips have changed - pointing only to this article.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 66bd8666-3566-a901-b25b-eb6baba6264a
Version Independent ID: e9f6310f-2207-8c81-d31a-3d5a80beb26b
Content: Office 365 URLs and IP address ranges - Microsoft 365 Enterprise
Content Source: microsoft-365/enterprise/urls-and-ip-address-ranges.md
Service: o365-administration
GitHub Login: @kelleyvice-msft
Microsoft Alias: kvice

@LauraWi Please help us in resolving this issue. Thanks

Thanks for reaching out. In this case, the IP address is not published because the URL testconnectivity.microsoft.com is covered under *.microsoft.com as an optional Default category endpoint that can be routed with normal internet traffic. -Kelley


Error: SampleModule is not an NgModule

OS?
macOS Sierra
Versions.
angular-cli: 1.0.0-beta.22
node: 7.2.0
os: darwin x64

Repro steps.
1. Scaffold new app:
$ ng new angular-sample-app --skip-git --skip-npm --style=scss --inline-template
$ cd angular-sample-app
$ yarn
$ git init
$ git add .
$ git commit -am "Initial commit"

2. Add dependency to angular-sample-module
This source to this module can be found here, and it's available on npmjs.
$ yarn add angular-sample-module

3. Add new module to AppModule

Edit src/app/app.module.ts
Add dependency: import { SampleModule } from 'angular-sample-module';
Add SampleModule to the imports array
Edit src/app/app.component.ts
Add <sampleComponent></sampleComponent> to the template

4. Start ng serve
$ ng serve
** NG Live Development Server is running on http://localhost:4200. **
 10% building modules 2/2 modules 0 active(node:18364) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: SampleModule is not an NgModule
(node:18364) DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
 20% building modules 84/84 modules 0 active

The log given by the failure.
(node:17462) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: SampleModule is not an NgModule
(node:17462) DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Mention any other details that might be useful.
Downgrading to the previous version of angular-cli makes it work:
$ npm install --save-dev<EMAIL_ADDRESS>
Link to a sample app showing the issue: https://github.com/beeman/angular-sample-app
Using ng new angular-sample-app without my custom parameters on version 1.0.0-beta.22 and npm install over yarn add yields the same results.

Same issue on Windows10 x64

Yeah I can also confirm that updating angular-cli to 1.0.0-beta.22-1 causes this problem. Any solutions ?

+1

same here

Been getting this in a few places. I was convinced it was my code but after trying to give it TS directly and seeing everyone complain here, I'm happy it's not just me. Probably spent a minimum of 10hrs here :) It doesn't seem to be very debuggable which is my issue. It just says: X is not an NgModule and it's not even possible to see WHY or how it's even trying to load stuff. I don't even have the ability to pass in module-resolutions parameters to typescript to try and see what it's trying to load which makes this a bitch :(

Had same issue with this and it is related to incompatibility of Angular versions between 2.2.* and
previous versions, so; update https://github.com/beeman/angular-sample-module/blob/master/package.json#L32-L33 to 2.2.3 which you have in your project and this will get compiled.
Summary is that 3rd party libs package.json should have same version of Angular than your project.

I'm getting this error with 2.2.3 having already been set.

I tried with an example project that @beeman man provided here and update package.json in https://github.com/beeman/angular-sample-module and it got compiled.
spend a lot of time too some week ago on real world app and this solved the issue too.

Interesting.  I just installed the latest version of Angular-Cli from Github, and was able to serve the included app.  I changed core and common, and received the same error message.  I'm going to, arbitrarily, replace the entire contents with the beeman's sample.

Hello, same issue with 1.0.0-beta.22 on macOS Sierra.

Same thing happened to me 1.0.0-beta.22

It seems like<EMAIL_ADDRESS>is causing the issue. Downgrading to 2.0.10 seems to make it pick up the metadata correctly.

@lurock I encountered this bug running on TypeScript version 2.0.10:
~/workspace/beeman/angular-sample-app master
❯ grep version node_modules/typescript/package.json
    "version": "2.0.10",

~/workspace/beeman/angular-sample-app master
❯ tsc -v
Version 2.0.10

Tried to use 2.0.10, to no avail...
Get Outlook for Androidhttps://aka.ms/ghei36
On Wed, Dec 7, 2016 at 4:50 PM -0600, "Bram Borggreve" <notifications<EMAIL_ADDRESS>wrote:
@lurockhttps://github.com/lurock I encountered this bug running on TypeScript version 2.0.10:
~/workspace/beeman/angular-sample-app master
? grep version node_modules/typescript/package.json
"version": "2.0.10",
~/workspace/beeman/angular-sample-app master
? tsc -v
Version 2.0.10

You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/angular/angular-cli/issues/3426#issuecomment-265599086, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJTUJDxsGt_RMrdJtadUyFhJogwsN-Osks5rFzhMgaJpZM4LFF9D.

Try building your project using "ng build --aot" and fix any build errors you have then go back to running "ng serve".

This gives me very similar output.
 ng build --aot
 10% building modules 2/2 modules 0 activeUnexpected value 'SampleModule' imported by the module 'AppModule'
Error: Unexpected value 'SampleModule' imported by the module 'AppModule'
    at /Users/beeman/workspace/beeman/angular-sample-app/node_modules/@angular/compiler/bundles/compiler.umd.js:14675:33
    at Array.forEach (native)
    at CompileMetadataResolver._loadNgModuleMetadata (/Users/beeman/workspace/beeman/angular-sample-app/node_modules/@angular/compiler/bundles/compiler.umd.js:14660:51)
    at CompileMetadataResolver.getUnloadedNgModuleMetadata (/Users/beeman/workspace/beeman/angular-sample-app/node_modules/@angular/compiler/bundles/compiler.umd.js:14636:23)
    at addNgModule (/Users/beeman/workspace/beeman/angular-sample-app/node_modules/@angular/compiler/bundles/compiler.umd.js:12944:43)
    at /Users/beeman/workspace/beeman/angular-sample-app/node_modules/@angular/compiler/bundles/compiler.umd.js:12957:16
    at Array.forEach (native)
    at _createNgModules (/Users/beeman/workspace/beeman/angular-sample-app/node_modules/@angular/compiler/bundles/compiler.umd.js:12956:28)
    at analyzeNgModules (/Users/beeman/workspace/beeman/angular-sample-app/node_modules/@angular/compiler/bundles/compiler.umd.js:12700:16)
    at analyzeAndValidateNgModules (/Users/beeman/workspace/beeman/angular-sample-app/node_modules/@angular/compiler/bundles/compiler.umd.js:12704:20)
    at OfflineCompiler.compileModules (/Users/beeman/workspace/beeman/angular-sample-app/node_modules/@angular/compiler/bundles/compiler.umd.js:12775:20)
    at CodeGenerator.codegen (/Users/beeman/workspace/beeman/angular-sample-app/node_modules/@angular/compiler-cli/src/codegen.js:58:30)
    at /Users/beeman/workspace/beeman/angular-sample-app/node_modules/@ngtools/webpack/src/plugin.js:210:73
    at process._tickCallback (internal/process/next_tick.js:103:7)

Hi everyone,
It has been taking me days to get a 'production' build, cause of all kind of error..
Some are typescript 2.1.1 related, some Angular 2.2.4 and some to the fact of AOT compiling.
Please also take in mind, when building a production build with --aot.. That export default doesn't work!
https://github.com/Microsoft/TypeScript/issues/3337

Having the same issue after updating a project from Angular CLI 1.0.0-beta.19-3 to the latest (1.0.0-beta.22-1) on macOS Sierra. It appears that the following line is no longer returning anything in plugin.js:
var ngModules = this._reflector.annotations(staticSymbol).filter(function (s) { return s instanceof core_1.NgModule; });

It looks like the instance of s is not core_1.NgModule.

Same thing here : https://github.com/yuyang041060120/ng2-validation/issues/28

The same issue. I am trying to start the sample app (full tour of heroes like here: https://embed.plnkr.co/?show=preview) with angular-cli 1.0.0-beta.22-1. When I remove usage of package angular-in-memory-web-api, the application not stuck in building.
"dependencies": {
"@angular/common": "2.2.3",
"@angular/compiler": "2.2.3",
"@angular/core": "2.2.3",
"@angular/forms": "2.2.3",
"@angular/http": "2.2.3",
"@angular/platform-browser": "2.2.3",
"@angular/platform-browser-dynamic": "2.2.3",
"@angular/router": "3.2.3",
"angular-in-memory-web-api": "0.1.16",
"core-js": "^2.4.1",
"rxjs": "5.0.0-beta.12",
"ts-helpers": "^1.1.1",
"zone.js": "^0.6.23"
}

Yep, just got bit by this after upgrading typescript to 2.1.4

Also need this.

Isn't this exactly the kind of thing Angular CLI is supposed to help with, making sure that all of the versions being installed fit with each other?

Just a sec ago switched Ubuntu to Win10 and made a ng serve on same source. To my surprise this dragon jumped out of the bushes to bite my arse. On Ubuntu 16.10 it works like a charm. What is more, I have not noticed anyone here from any Linux distro (or no one managed to state it clear enough). So probably it is somehow platform dependent. How? don't know... :P
My setup is pretty much ToH based. Running on:
node: 7.2.1
ng: 2.2.3
ts: 2.1.4
ng-cli: 1.0.0-beta.22-1

@filipesilva or @hansl - is this something to do with angular-cli or with each of the projects themselves? Two example external deps which are giving this error for me are:

https://github.com/apollostack/angular2-apollo
https://github.com/yuyang041060120/ng2-validation

Would be nice to get your insight to if this is possible to fix in the next version as it's quite painful at the moment :)

I'm running in Ubuntu 16.04 and recurved the same error. I followed the
suggestion above and use typescript 2.0.10 for now. It's a good work around.
That being said, I'm also using Apollo client although I fail to see how
that is relevant.
On Mon, Dec 12, 2016, 7:16 AM Dominic Watson<EMAIL_ADDRESS>wrote:
@filipesilva https://github.com/filipesilva or @hansl
https://github.com/hansl - is this something to do with angular-cli or
with each of the projects themselves? Two example external deps which are
giving this error for me are:

https://github.com/apollostack/angular2-apollo
https://github.com/yuyang041060120/ng2-validation

Would be nice to get your insight to if this is possible to fix in the next
version as it's quite painful at the moment :)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/angular/angular-cli/issues/3426#issuecomment-266456577,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABq9MsqmBykpUW2GIb1_PfrN-4TIFnZhks5rHWU3gaJpZM4LFF9D
.

ok my bad... sorry for confusion... double checked the versions... Ubuntu was running on outdated typescript 2.0.10 not 2.1.4 but Win had fresh 2.1.4. Now they are in sync and both fail in exact same manner...

Is angular core team supporting this project, because they should. It seems like angular-cli is having a hard time keeping up, shame because it's a great tool.

@vangorra This is something to do with the thirdparty library. They are not statically analyzable; basically they don't publish metadata.json files which we need to understand their modules or components.
We're working on showing at least a warning and not failing the compilation when that happens.
ng serve itself blocks because of https://github.com/webpack/webpack/issues/3464, which will be fixed before webpack RC1.

This is a dupe of another issue here that we use for tracking. I'll close this one when I find it (it's somewhere in my inbox).

+1

Have the same issue. Temporarily workaround that works form is to downgrade typescript to 2.0.10.

I'm creating third party libraries that expose NgModules.
I simple build publish to npm  and import the modules
I can confirm that downgrade to 1.0.0-beta.21 fix the issue

In my project I have used typescript 2.0.10 all the way long, so "downgrade" to that version is not the solution.

Ok, so just tested downgrading the ng cli to two different versions, with no luck, Any ideas?

I got mine to work by changing "angular-cli" to "1.0.0-beta.15".
Was having different errors but appears to be building and serving now.

@asBrettisay, this worked for me. I was getting this error with ng2-flex-layout. Downgrading from<EMAIL_ADDRESS>to<EMAIL_ADDRESS>did the trick!

Just ran into this on a fresh project. "angular-cli": "1.0.0-beta.22-1"
10% building modules 2/2 modules 0 activeError: AppModule is not an NgModule
Downgrading back to "angular-cli": "1.0.0-beta.20-4" fixed the issue for me.

try beta 24. The issue has disappeared for me

Has same error. angular-cli: beta.24. angular: 2.4.1

With angular-cli beta.24 and typescript 2.1.4 I got the same error, but when downgraded only the typescript to version 2.0.10 the error was gone.

Any updates on this issue? This should be a blocker guys, can anyone clarify if the Issue is related to ng-cli  or the third party module?
"@angular/compiler-cli": "^2.3.1",
"typescript": "^2.0.10",
"@angular/common": "^2.3.1",
the dependencies i have that angular-cli complains about are
https://github.com/Gbuomprisco/ng2-material-select
https://github.com/yuyang041060120/ng2-validation
Thanksss

(been added to the thread by @mhmo91)
Guys, those using TypeScript 2.1 please note that this is currently not supported because there are issues with TypeScript 2.1 and Angular itself, not just the CLI.
Those still having the issue with TypeScript 2.0 (ideally the default TypeScript and Angular packages that come with Angular CLI beta.24), can you please share a repository containing a simple Angular CLI generated project that has this issue?
Thanks a lot.

I have created a rep with the issue, i just created a new project and imported this module to the main app https://github.com/Gbuomprisco/ng2-material-select
here's the rep.
https://github.com/mhmo91/ERROR-in-is-not-an-NgModule
thanksss

@mhmo91 That looks like a library problem
https://github.com/Gbuomprisco/ng2-material-select/pull/34

@Meligy Thankkk uuu, i believe it's up to the owner of the module to look the problem up.
Although i must raise a concern to everyone, This module along with others was working fine with previous builds of ng-cli, and now i'm worried that with every update some modules will just stop working, the whole idea behind the new ng2 design patterns is to embrace external modules n components... now this is just a nightmare with each new ng-cli version as some might just stop working!!!

With angular-cli version 1.0.0-beta.24 I'm still seeing an error: ERROR in SampleModule is not an NgModule in the terminal window and my browser console, but at least the app runs, which is an improvement already 👍🏻 .
@hansl is this something that will be fixed in angular-cli or do 3rd-party modules need to update something to prevent this error from happening?

I was able to get my app working after fixing previously harmless typescript errors. After fixing my ts errors I still get "X is not an NgModule" but the app still runs.

angular-cli 1.0.0-beta.24 and angular 2.4.1.
When I use the 'default' keyword to export my module (export default class TheformModule {} )
"ng build --aot" or "ng build"

WARNING in ./src/$$_gendir/app/app.module.ngfactory.ts
609:37 export 'TheformModule' (imported as 'import26') was not found in '../../app/theform/theform.module'

WARNING in ./src/$$_gendir/app/app.module.ngfactory.ts
696:23 export 'TheformModule' (imported as 'import26') was not found in '../../app/theform/theform.module'

ERROR in default is not an NgModule

And Without the 'default' keyword
"ng build" :

ERROR in default is not an NgModule

Hello.
I have this error today, after I updated angular to 2.4.1.
Today I saw many errors, and "AppModule is not an NgModule", and "cannot read property codegen" and so on. Then I changed my package.json to previous state (worked state), and now I'm getinng an error "AppModule is not an NgModule". A current package.json is
{
angular: 2.2.3,
router: 3.2.3,
"@ngtools/webpack": "1.1.9",
"typescript": "2.0.10",
"webpack": "2.1.0-beta.25"
}
and this is not working. Changing 2.2.3 to 2.2.4 not solve this problem.

@hansl can you link the other issue you mentioned is tracking this problem?

Hi guys, I also met this issue, while my SampleModule is literally irrelevant to the HerosModule(see below).
I have code like below within routing module:
ex:
 loadChildren: 'wrong_path/app/heros/heros.module#HerosModule'

after remove the wrong_path above, everything just fine again.

A little bit more information.
angular 2.2.4
With "@ngtools/webpack": "1.2.1", typescript 2.0.10
I'm getting "ERROR in Cannot read property 'codeGen' of undefined"

With "@ngtools/webpack": "1.1.6", typescript 2.0.10
I'm getting "Error: IndexModule?sync=true is not an NgModule"

With "@ngtools/webpack": "1.1.9", typescript 2.0.10
I'm getting "Error: AppModule is not an NgModule"

angular 2.3.1
With "@ngtools/webpack": "1.1.9", typescript 2.0.10
I'm getting "TypeError: ngCompiler.ReflectorHost is not a constructor"

With "@ngtools/webpack": "1.1.6", typescript 2.0.10
I'm getting "TypeError: ngCompiler.ReflectorHost is not a constructor"

What error do you like? )))

People are seeing this with my lib - ng2-redux as well. I have reproduced it with CLI beta.24:
Relevant dependencies from package.json:
    "@angular/common": "^2.3.1",
    "@angular/compiler": "^2.3.1",
    "@angular/core": "^2.3.1",
    "@angular/forms": "^2.3.1",
    "@angular/http": "^2.3.1",
    "@angular/platform-browser": "^2.3.1",
    "@angular/platform-browser-dynamic": "^2.3.1",
    "@angular/router": "^3.3.1",
    "ng2-redux": "^5.0.0-beta.0",

    // ...

    "typescript": "~2.0.3"

@hansl I saw your comment above re: 3rd-party libs needing to publish ng module meta data. However we are publishing it:

(that's a screenshot of my lib, as installed in a CLI-generated project's node_modules folder).
Where can I get more info on how to publish an ngmodule correctly?

Here's a repo that reproduces the issue: https://github.com/SethDavenport/redux-cli-test

Ok figured it out, at least in our case. We publish the .module.metadata.json in our lib folder (the transpiled output of ngc. However the CLI is trying to import stuff from src. Presumably for tree-shaking reasons.
I don't love having to include generated code mixed up in my source tree TBH. But it I have to I have to.

Same issue. angular-cli 1.0.0-beta24 / typescript 2.1.4 is failing.
"dependencies": {
"@angular/common": "^2.4.1",
"@angular/compiler": "^2.4.1",
"@angular/core": "^2.4.1",
"@angular/forms": "^2.4.1",
"@angular/http": "^2.4.1",
"@angular/platform-browser": "^2.4.1",
"@angular/platform-browser-dynamic": "^2.4.1",
"@angular/router": "^3.4.1",
"core-js": "^2.4.1",
"rxjs": "^5.0.1",
"ts-helpers": "^1.1.1",
"zone.js": "^0.7.2"
},
"devDependencies": {
"@angular/compiler-cli": "^2.4.1",
"@types/jasmine": "2.5.38",
"@types/node": "^6.0.42",
"angular-cli": "1.0.0-beta.24",
"codelyzer": "~2.0.0-beta.1",
"jasmine-core": "2.5.2",
"jasmine-spec-reporter": "2.5.0",
"karma": "1.2.0",
"karma-chrome-launcher": "^2.0.0",
"karma-cli": "^1.0.1",
"karma-jasmine": "^1.0.2",
"karma-remap-istanbul": "^0.2.1",
"protractor": "~4.0.13",
"ts-node": "1.2.1",
"tslint": "^4.0.2",
"typescript": "^2.1.4"
}

I just want to say that @angular/compiler-cli is NOT compatible with TS 2.1. The CLI itself is compatible and will work fine with TS 2.1, but since we use @angular/compiler-cli it won't work.
Refer to https://github.com/angular/angular/pull/13294 for more information. Closing this as nothing needs to be done by Angular CLI.

@hansl I'm amazed to see the story closed for this reason as it's full of people having the same issue, also using supported versions of typescript.
If third party modules need upgrading could you please share some information on what needs to be done? Or a direction where to look? I'm happy to write some tutorial on how to make this error go away as it's in all of my current projects but I have no clue what the actual issue is.
Thanks for considering.

@beeman there was a lot of reports of different issues here. It's extremely hard to follow and I'll close more of those.
For your original issue<EMAIL_ADDRESS>shows that you're missing .metadata.json and use an old version. You're also using typings, which is not recommended anymore and been replaced by @types/. Follow this guide for AOT: https://angular.io/docs/ts/latest/cookbook/aot-compiler.html (basically run ngc instead of tsc to compile your files, with some more options to skip ngfactory generation).
Here's a full guide on how to make Angular2 component library: https://medium.com/@cyrilletuzi/how-to-build-and-publish-an-angular-module-7ad19c0b4464
Cheers!

Thanks a lot for your detailed reply @hansl, I appreciate it.
I'll update my components according to the library and post my updated (working) module here as a reference for future visitors.
Thanks for your work on angular-cli!

Big thanks @hansl for your answer.

I use @types instaed of typings.
I use ngc instead of tsc.
Here is my package.json

{
"name": "",
"version": "1.9.56",
"dependencies": {
"@angular/common": "2.2.4",
"@angular/compiler": "2.2.4",
"@angular/compiler-cli": "2.2.4",
"@angular/core": "2.2.4",
"@angular/forms": "2.2.4",
"@angular/http": "2.2.4",
"@angular/platform-browser": "2.2.4",
"@angular/platform-browser-dynamic": "2.2.4",
"@angular/platform-server": "2.2.4",
"@angular/router": "3.2.4",
"core-js": "^2.4.1",
"intl": "^1.1.0",
"lodash": "4.17.2",
"reflect-metadata": "^0.1.2",
"rxjs": "5.0.0-beta.12",
"zone.js": "^0.7.2"
},
"devDependencies": {
"@ngtools/webpack": "1.1.9",
"@types/lodash": "4.14.42",
"@types/requirejs": "^2.1.28",
"angular2-router-loader": "^0.3.3",
"angular2-template-loader": "^0.6.0",
"awesome-typescript-loader": "^2.2.4",
"compression-webpack-plugin": "^0.3.1",
"css-loader": "^0.26.1",
"extract-text-webpack-plugin": "^2.0.0-beta.4",
"file-loader": "^0.9.0",
"html-minify-loader": "^1.1.0",
"raw-loader": "^0.5.1",
"rimraf": "^2.5.4",
"style-loader": "^0.13.1",
"typescript": "2.0.10",
"webpack": "2.1.0-beta.25"
},
"scripts": {
"prepublish": "yarn run build",
"build": "yarn run clean && yarn webpack",
"build:jit": "yarn run clean && yarn webpack -- --env.production",
"build:production": "yarn run clean && yarn run compiler:aot && yarn webpack -- --env.aot --env.production",
"compiler:aot": "ngc -p client-code/src/tsconfig-aot.json",
"clean": "rimraf client-code/dist/* client-code/src/aot-compiled"
},
"engines": {
"node": ">=6.1.0"
},
"keywords": [
"contragent",
"contragent-site"
],
}
I try to change versions, but it doesn't work. I get different errors. This happened some times ago after updating.
yarn run build - ok
yarn compiler:aot - ok
yarn build:jit - ok
yarn build:production - not ok.
So, or with @ngtools/webpack problem, or with angular2-router-loader (angular2-router-loader works without aot)

Hmm still can't understand why this is closed down - going to try @PierreDuc solution tomorrow to fix this.

Using ngcli beta 24 and created new project (5 days ago). Today, upgraded TSC to 2.14 matching my system version. Got error '... is not an NGModule' on ng serve.
Upgraded all angular components from 2.31 to 2.42
Module builds, no more error, when running ng serve

Unfortunately upgrading to ngcli beta 24, typescript 2.1.4 and angular to 2.4.2 didn't solve my problem - still get the "NgSemanticModule is not an NgModule" error.
Any ideas left?

Hello.
I tired to solve this problem. Yesterday I founded an example here https://github.com/blacksonic/angular2-aot-webpack (big thanks to author). Today I removed @ngtools/webpack from my project and now I'm using webpack for AoT. I'm happy. Thanks to all.

Pushing back the version of angular-cli to 1.0.0-beta.21 works for me - even with latest versions of Typescript, Angular and compiler-cli:
  "dependencies": {
    "@angular/common": "2.4.2",
    "@angular/compiler": "2.4.2",
    "@angular/core": "2.4.2",
    "@angular/forms": "2.4.2",
    "@angular/http": "2.4.2",
    "@angular/platform-browser": "2.4.2",
    "@angular/platform-browser-dynamic": "2.4.2",
    "@angular/router": "3.4.2",
    "angular2-jwt": "^0.1.28",
    "core-js": "^2.4.1",
    "d3": "^4.4.1",
    "jquery": "^3.1.1",
    "lodash": "^4.17.4",
    "ng2-toasty": "^2.2.2",
    "rxjs": "^5.0.3",
    "semantic-ui": "^2.2.7",
    "ts-helpers": "^1.1.2",
    "zone.js": "^0.7.4"
  },
  "devDependencies": {
    "@angular/compiler-cli": "2.4.2",
    "@types/d3": "^4.4.0",
    "@types/jasmine": "2.5.38",
    "@types/node": "^6.0.42",
    "angular-cli": "1.0.0-beta.21",
    "awesome-typescript-loader": "3.0.0-beta.17",
    "codelyzer": "~2.0.0-beta.1",
    "jasmine-core": "2.5.2",
    "jasmine-spec-reporter": "2.5.0",
    "karma": "1.2.0",
    "karma-chrome-launcher": "^2.0.0",
    "karma-cli": "^1.0.1",
    "karma-jasmine": "^1.0.2",
    "karma-remap-istanbul": "^0.2.1",
    "protractor": "~4.0.13",
    "ts-node": "1.2.1",
    "tslint": "^4.0.2",
    "typescript": "~2.1.4",
    "webdriver-manager": "10.2.5"
  }

Just tried with the latest release angular-cli: 1.0.0-beta.25.5 and it's not working. Reverting back to 21 for now.

Personally I found a way to make this work on my project, basically I did following:

Update all dependencies
Then I compared all my files against https://github.com/angular/angular-cli/tree/master/packages/angular-cli/blueprints/ng2/files
Make necessary changes to common files

And after this all worked. And below is my current package.json
{
  "name": "angular-cli-frontend",
  "version": "0.0.0",
  "license": "MIT",
  "angular-cli": {},
  "scripts": {
    "start": "ng serve --host <IP_ADDRESS>",
    "lint": "tslint -t stylish \"src/**/*.ts\"",
    "test": "ng test --lint --code-coverage",
    "pree2e": "webdriver-manager update",
    "e2e": "protractor"
  },
  "private": true,
  "dependencies": {
    "@angular/common": "2.4.2",
    "@angular/compiler": "2.4.2",
    "@angular/core": "2.4.2",
    "@angular/forms": "2.4.2",
    "@angular/http": "2.4.2",
    "@angular/material": "2.0.0-beta.1",
    "@angular/platform-browser": "2.4.2",
    "@angular/platform-browser-dynamic": "2.4.2",
    "@angular/router": "3.4.2",
    "angular2-jwt": "0.1.28",
    "angular2-moment": "1.1.0",
    "core-js": "2.4.1",
    "hammerjs": "2.0.8",
    "ng2-webstorage": "1.5.0",
    "rxjs": "5.0.3",
    "ts-helpers": "1.1.2",
    "zone.js": "0.7.4"
  },
  "devDependencies": {
    "@angular/compiler-cli": "2.4.2",
    "@types/jasmine": "2.5.40",
    "@types/node": "6.0.59",
    "angular-cli": "1.0.0-beta.24",
    "codelyzer": "2.0.0-beta.4",
    "enhanced-resolve": "3.0.2",
    "jasmine-core": "2.5.2",
    "jasmine-spec-reporter": "3.1.0",
    "karma": "1.3.0",
    "karma-chrome-launcher": "2.0.0",
    "karma-cli": "1.0.1",
    "karma-jasmine": "1.1.0",
    "karma-mocha-reporter": "2.2.1",
    "karma-phantomjs-launcher": "1.0.2",
    "karma-remap-istanbul": "0.4.0",
    "protractor": "4.0.14",
    "ts-node": "2.0.0",
    "tslint": "4.3.1",
    "typescript": "2.1.4"
  }
}

Hey @tarlepp ! I've already used your angular-sailsjs-boilerplate before.
Cheers!

FYI, it now works with latest Angular and CLI with the following dependencies:
  "dependencies": {
    "@angular/common": "2.4.4",
    "@angular/compiler": "2.4.4",
    "@angular/core": "2.4.4",
    "@angular/forms": "2.4.4",
    "@angular/http": "2.4.4",
    "@angular/platform-browser": "2.4.4",
    "@angular/platform-browser-dynamic": "2.4.4",
    "@angular/router": "3.4.4",
    "angular2-jwt": "^0.1.28",
    "core-js": "^2.4.1",
    "d3": "^4.4.2",
    "jquery": "^3.1.1",
    "lodash": "^4.17.4",
    "ng2-toasty": "^2.2.2",
    "rxjs": "^5.0.3",
    "semantic-ui": "^2.2.7",
    "ts-helpers": "^1.1.2",
    "zone.js": "^0.7.6"
  },
  "devDependencies": {
    "@angular/compiler-cli": "2.4.4",
    "@types/d3": "^4.4.1",
    "@types/jasmine": "2.5.41",
    "@types/node": "^6.0.42",
    "angular-cli": "1.0.0-beta.26",
    "awesome-typescript-loader": "3.0.0-beta.18",
    "codelyzer": "~2.0.0-beta.4",
    "jasmine-core": "2.5.2",
    "jasmine-spec-reporter": "3.2.0",
    "karma": "1.4.0",
    "karma-chrome-launcher": "^2.0.0",
    "karma-cli": "^1.0.1",
    "karma-jasmine": "^1.1.0",
    "karma-remap-istanbul": "^0.4.0",
    "protractor": "~5.0.0",
    "ts-node": "2.0.0",
    "tslint": "^4.3.1",
    "typescript": "~2.1.5",
    "webdriver-manager": "11.1.1"
  }

I had the same problem but I wasnt able to downgrade typescript or angular-cli because in OS X it worked but if I downgrade in Windows doesn't work anymore, so I just instaled NCU npm i -g npm-check-updatesand did an upgrade of all the package.json and the problem were solved for both OS.

@CanKer Whats the angular version you have after the upgrade?
When I did yarn upgrade, I got 2.3.1 instead of 2.4.4

@thekalinga this is how my package.json looks after the upgrade
"dependencies": {
    "@angular/common": "~2.4.4",
    "@angular/compiler": "~2.4.4",
    "@angular/core": "~2.4.4",
    "@angular/forms": "~2.4.4",
    "@angular/http": "~2.4.4",
    "@angular/platform-browser": "~2.4.4",
    "@angular/platform-browser-dynamic": "~2.4.4",
    "@angular/router": "~3.4.4",
    "core-js": "^2.4.1",
    "ng2-date-picker": "^0.2.1",
    "ng2-file-upload": "^1.2.0",
    "ng2-smart-table": "^0.5.0",
    "rxjs": "5.0.3",
    "ts-helpers": "^1.1.1",
    "zone.js": "^0.7.6"
  },
  "devDependencies": {
    "@angular/compiler-cli": "^2.3.1",
    "@types/jasmine": "^2.2.30",
    "@types/node": "^7.0.3",
    "angular-2-dropdown-multiselect": "^0.4.0",
    "angular-cli": "1.0.0-beta.19-3",
    "codelyzer": "2.0.0-beta.4",
    "jasmine-core": "2.5.2",
    "jasmine-spec-reporter": "3.2.0",
    "karma": "1.4.0",
    "karma-chrome-launcher": "^2.0.0",
    "karma-cli": "^1.0.1",
    "karma-jasmine": "^1.0.2",
    "karma-remap-istanbul": "^0.4.0",
    "protractor": "5.0.0",
    "ts-node": "2.0.0",
    "tslint": "4.3.1",
    "typescript": "latest",
    "awesome-typescript-loader": "latest",
    "webdriver-manager": "11.1.1"
  }```

@CanKer Are you sure your using "angular-cli": "1.0.0-beta.19-3". I'm still having the "Error in X is not an NgModule from an npm linked module. But i'm using the latest CLI.

just ran into this, didnt debug it, but i find it interesting that I am getting this error only after "ng serve", then if i will modify any file, and web pack reruns, it is not displaying this error anymore
** NG Live Development Server is running on http://localhost:4200. **
Hash: 49cd7d49bb76b083774c
Time: 9923ms
chunk    {0} polyfills.bundle.js, polyfills.bundle.map (polyfills) 222 kB {4} [initial] [rendered]
chunk    {1} main.bundle.js, main.bundle.map (main) 15.6 kB {3} [initial] [rendered]
chunk    {2} styles.bundle.js, styles.bundle.map (styles) 10 kB {4} [initial] [rendered]
chunk    {3} vendor.bundle.js, vendor.bundle.map (vendor) 2.71 MB [initial] [rendered]
chunk    {4} inline.bundle.js, inline.bundle.map (inline) 0 bytes [entry] [rendered]

ERROR in NgSemanticModule is not an NgModule
webpack: Failed to compile.
webpack: Compiling...
Hash: 8d508c11672b2c20762a
Time: 1783ms
chunk    {0} polyfills.bundle.js, polyfills.bundle.map (polyfills) 222 kB {4} [initial]
chunk    {1} main.bundle.js, main.bundle.map (main) 15.6 kB {3} [initial]
chunk    {2} styles.bundle.js, styles.bundle.map (styles) 10 kB {4} [initial]
chunk    {3} vendor.bundle.js, vendor.bundle.map (vendor) 2.71 MB [initial]
chunk    {4} inline.bundle.js, inline.bundle.map (inline) 0 bytes [entry]
webpack: Compiled successfully.

well, today upgraded myself blindly, to:
$ ng -v
angular-cli: 1.0.0-beta.28.3
node: 7.2.1
os: win32 x64
@angular/common: 2.4.7
@angular/compiler: 2.4.7
@angular/core: 2.4.7
@angular/forms: 2.4.7
@angular/http: 2.4.7
@angular/platform-browser: 2.4.7
@angular/platform-browser-dynamic: 2.4.7
@angular/router: 3.4.7`

and
$ tsc -v
Version 2.1.6

I don't see this error anymore... so (at least in my case) it helped... without checking, whatever you guys did: thanks! ;)

@zawor for your information,the latest release is beta 32 and is available under the @angular/cli name, angular-cli will soon be deprecated. :)

argh... forgot about the change... nevertheless:
$ ng -v
@angular/cli: 1.0.0-beta.32.3 [1.0.0-beta.24]
node: 7.2.1
os: win32 x64
@angular/common: 2.4.7
@angular/compiler: 2.4.7
@angular/core: 2.4.7
@angular/forms: 2.4.7
@angular/http: 2.4.7
@angular/platform-browser: 2.4.7
@angular/platform-browser-dynamic: 2.4.7
@angular/router: 3.4.7
@angular/compiler-cli: 2.4.7
@angular/cli: 1.0.0-beta.32.3

and
$ nr serve

runs without this pesky error as well...
So as Great Joe from the Church of Joe used to say... Cheers and beers! ;)

Currently have this issue with:
    "@angular/common": "^2.4.8",
    "@angular/compiler": "^2.4.8",
    "@angular/core": "^2.4.8",
    "@angular/forms": "^2.4.8",
    "@angular/http": "^2.4.8",
    "@angular/platform-browser": "^2.4.8",
    "@angular/platform-browser-dynamic": "^2.4.8",
    "@angular/platform-server": "2.4.8",
    "@angular/router": "^3.4.8",
    "@angular/cli": "1.0.0-beta.32.3",
    "@angular/compiler-cli": "^2.4.8",
    "typescript": "^2.1.6"

ng serve works, but both ng build --prod and ng build --prod --no-aot fail

Getting this error as well now.
Using:

@angular/cli: 1.0.0-rc.0
node: 7.2.1
os: darwin x64
@angular/common: 2.4.8
@angular/compiler: 2.4.8
@angular/core: 2.4.8
@angular/forms: 2.4.8
@angular/http: 2.4.8
@angular/platform-browser: 2.4.8
@angular/platform-browser-dynamic: 2.4.8
@angular/router: 3.4.7
@angular/cli: 1.0.0-rc.0
@angular/compiler-cli: 2.4.8

Also, this error occurs even when running "ng serve", however, after the initial error, when I make changes to the code and save, the code does compile properly and runs. This error only occurs on first run of "ng serve".
Finally, cannot perform "ng build --prod" because of this error.

@expy I had it as well, I just updated from BETA to RC. After running an ng build --aot I was able to run ng serve again.

@angular/cli: 1.0.0-rc.0
node: 6.9.1
os: darwin x64
@angular/cli: 1.0.0-rc.0
@angular/common: 2.4.8
@angular/compiler: 2.4.8
@angular/core: 2.4.8
@angular/forms: 2.4.8
@angular/http: 2.4.8
@angular/material: 2.0.0-beta.2
@angular/platform-browser: 2.4.8
@angular/platform-browser-dynamic: 2.4.8
@angular/router: 3.4.8
@angular/compiler-cli: 2.4.8

@expy try deleting node_modules then:
npm cache clean
npm install

in the project directory.

@0x1ad2 @Meligy I've tried the above, the problem may lie in a Module that isn't up-to-date with the latest Angular2 / Angular-Cli changes.
I've contacted the owner of the Module for more information.
Thanks for you assistance.

@expy isn't using SEMVER suppose to prevent exactly that?

@SylTi that Module is tested and working on @angular v2.4.1. I upgraded my modules and cli yesterday and this was the only issue.

Please see ERROR in PasswordStrengthBarModule is not an NgModule.
The interesting twist here is that ng serve initially fails with this error, but a rebuild is successful! This is reproducible and is not resolved with the different typescript/angular-cli versions mentioned in this thread.

Been experiencing this issue in a npm package I am working on and finally managed to fix it by AOT compilation using the ngc compiler.
https://angular.io/docs/ts/latest/cookbook/aot-compiler.html#!#compile

Still get this error with Angular 4.2.3 . Fix it with very strange @winfinit's trick 😄

i compiled library with ngc
For me issue is set options "skipMetadataEmit": false in file tsconfig.aot.json

"skipMetadataEmit": false that was it.


Improve performance when Navie editor is opened

Closes https://github.com/getappmap/appmap-intellij-plugin/issues/754

https://github.com/getappmap/appmap-intellij-plugin/pull/759/commits/dd46266f6a10f45c5dd8e6c4c9410dae2dc658cb
For Navie and other code the presence of appmap.yml files in the project is detected. We used the SDK's FilenameIndex, which should be suitable for tasks like this. But it proved to expensive to call because it attempted to update a lot of index data of files we don't care about.  This commit adds an index only for the filename indexing of appmap.yml files to make the lookup much faster and cheaper.
https://github.com/getappmap/appmap-intellij-plugin/pull/759/commits/553decd799abb1b466d26e22fcdf8fc9a8b6c3e9 changes the handling of generic filesystem refresh events. Previously, every refresh and even a refresh of non-AppMap files, triggered an update of the Navie editor. Because there can be a lot of file changes in the background, the Navie editor was updated a lot. Every update triggered a somewhat expensive lookup of AppMaps and appmap.yml files. The generic refresh does not update the Navie editor anymore, but updates of .appmap.json, appmap.yml and a status change of indexing does update it.

:tada: This issue has been resolved in version 0.73.0 :tada:
The release is available on:

v0.73.0
GitHub release

Your semantic-release bot :package::rocket:


During download period, Electron title and Electron logo is shown in tray

Tray:

Hello!
I would like to make a fix for it.


Fix link to SSL Wiki documentation.

I renamed the page 10 minutes ago, well done!  (preparing rollout of docker-mailserver v2).
I'll merge once tests are green.

Thank you.

You're welcome :-)


processFunctional error

As per our meeting this morning, these are the error messages and warnings that I have received. No "out" object is created. I am adding in file to our fileshare today.
> out <- processFunctional(object = hdxstats_tableqDF, params = res)
Error in if (m == 0) { : missing value where TRUE/FALSE needed
In addition: There were 50 or more warnings (use warnings() to see the first 50)

> warnings()
Warning messages:
1: In pf(q = Fstat, df1 = d1, df2 = d2, lower.tail = FALSE) : NaNs produced
2: In pf(q = Fstat, df1 = d1, df2 = d2, lower.tail = FALSE) : NaNs produced
3: In pf(q = Fstat, df1 = d1, df2 = d2, lower.tail = FALSE) : NaNs produced
4: In pf(q = Fstat, df1 = d1, df2 = d2, lower.tail = FALSE) : NaNs produced
5: In pf(q = Fstat, df1 = d1, df2 = d2, lower.tail = FALSE) : NaNs produced
...etc

Hi Nathan
The script you sent works for me - could you double check the error ? Perhaps the ELN .csv isn't correct?

Hmm... not sure what's going on, I retried it but seemed to work okay and haven't been able to reproduce the error. I'll close this for now and re-open if I an work out the cause.


⚠ ClamAV has degraded performance

In dc97475, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 223 ms

Resolved: ClamAV performance has improved in dea7433.


Update gperftools

[x] Changes comply with the maintainer guide
[x] SHA512s are updated for each updated download
[x] The "supports" clause reflects platforms that may be fixed by this new version
[x] Any fixed CI baseline entries are removed from that file.
[x] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

PR already open upstream for patch to Makefile.am


New MCPWM APIs can't be parsed by SWIG (IDFGH-9046)

Is your feature request related to a problem?
With version 4 I could use the SWIG binging generator  (https://www.swig.org/) to create an interface that could be used by a scripting language. The new API is such a kludge with tons of macros and variable length arguments making it impossible to use a tool such as SWIG.
Describe the solution you'd like.
Please consider making an easier to use API suitable for SWIG.
Describe alternatives you've considered.
No response
Additional context.
No response

Hi @surfskidude Could you please give a concrete example of why the variable length arguments can't be parsed by the SWIG tool? BTW, macros like MCPWM_GEN_COMPARE_EVENT_ACTION are just helpers, not necessary.

FWIW this issue also exists for bindings generators based on C++ templates. E.g. https://github.com/wasm3/wasm3/tree/main/platforms/cpp and https://github.com/ThePhD/sol2 would run into the same problem with variable length argument lists. The issue is due to the fact that these bindings generators rely on type information from the function signature. For varargs, there is no type information, so it's difficult to write a binder template which would determine the varargs type correctly.

Okay, thank you @igrr I see, the "fix" on the driver side is not hard but to provide a bunch of new functions to set the PWM generator's behavior one by one.  e.g.:
mcpwm_generator_set_actions_on_compare_event --> mcpwm_generator_set_action_on_compare_event (thanks I was using plural in the varg version APIs)
However, I can see there are other public functions in the esp-idf that are also using the varargs (e.g. esp_eth_transmit_vargs). :thinking: Not sure if we're going to "fix" them.

I have not looked at all APIs, just the MCPWM API, which we use for servo control. The new MCPWM 5 API is much more complex and I do not think it is possible to use SWIG with this new API. We do not have the resources to hand-craft bindings. Will you continue supporting the 4.x release also in the future?

Will you continue supporting the 4.x release also in the future?

Yes, the 4.4 release is still in our service period.  Check this.
BTW, the previous "legacy" driver APIs are still available even in esp-idf v5. You can use those APIs in driver/mcpwm.h.

The new MCPWM 5 API is much more complex

Right, but the complicity relies on the hardware itself. MCPWM is not a simple peripheral at all. The legacy driver gives us the illusion that it's simple because it made a lot of wrong assumptions to simplify the usage. In the new driver, we just exposed all the hardware abilities.
As I said in the above thread, we can provide non-vararg versions of APIs if you would like to. But we can't remove the existing vararg ones.


docs: The instructions are out of date. There is no Makefile and no target called "run-addon"

https://github.com/konveyor/tackle2-hub/blob/a63c8eb5d1b2bbe6bd016842115b0d5c8b04bd74/hack/cmd/addon/README.md?plain=1#L48

Found it
https://github.com/konveyor/tackle2-hub/blob/main/Makefile#L54-L55


Extend package name with information about AppScope version

Currently, package names that are available on GitHub have used naming convention:
scope-${ARCH}.tgz

As a side note I would love to see the version included in the package file name so I could dynamically pull the appscope package for GitHub by version number a little easier.

Ref: https://github.com/criblio/appscope/issues/728#issuecomment-1034716295

I actually took a look at this again after posting that comment and the version is in the path of the download URL so I was able to work out a solution so no need to change this unless it makes sense for other use cases.

version is part of the URL path, closing for now


Images included with info docs not copied to build [minor]

What's wrong
I installed the sly package using straight.el and noticed that the image links in the info doc that comes with it were broken. I'm guessing its probably not all that common to have images in info docs, but here's at least one case. The broken links are easily fixed by manually copying the directory they are in.
Directions to reproduce

(straight-use-package 'sly)
C-h i select the SLY docs
navigate to section 3 "A SLY tour for SLIME users`
you should see a broken image link

Version information

Emacs version: 28.0.50
Operating system: PureOS GNU/Linux

That's because the MELPA recipe doesn't include those images. You will encounter the same problem under package.el. I would suggest submitting a ticket against SLY.

Thanks for the info! I'm working on updating some other things in the documentation as well on SLY, so I can look into it. I will open an ticket with SLY. I'm pretty new to packaging, sorry I erroneously assumed it was a problem with the build step here.

It took me a little while to figure out how to rebuild sly with the recipe that was just merged into MELPA https://github.com/melpa/melpa/pull/6879 , but i fiddled around with the straight commands enough to successfully rebuild the SLY package with the images added :)
this was a somewhat silly, minor issue, but thanks to your suggestions, it seems like the issue has been resolved for both straight.el and package.el users

Thanks!


.nearBy(lat, lon, distance) Question

Hello,I want to ask if .nearBy(lat, lon, distance) syntax right or .nearBy(lon, lat, distance)  because I try it the second option matched with online difference https://gps-coordinates.org/distance-between-coordinates.php ? solved it depend on arrange coordinates on dataSet.

I'm closing this issue for now, since you have already solved it by yourself :)
Feel free to open a new one if you have another question or suggestion.


Debugging oneway calls

Hey peeps,
First of all, thank you so much for your hard work on elixir-thrift! 🙇 👏
I've decided to open this issue after I asked @jparise for help on Twitter and he advised me to do so. I'm an Elixir and (especially) Thrift noob, so please bear with me. 🐻
Question
How do you debug oneway calls in elixir-thrift?
What
I am trying to call Jaeger Agent's emitBatch (Thirft IDL here) to submit a batch of spans.
To do it, I'm running the default docker-compose.yml from the Jaeger project. I can see traces being submitted when I hit my (running) Jaeger Agent using their Python example.
In trying to do the same via Elixir, I have resorted to the great elixir-thrift lib. It worked fine to auto-generate the code based on the Jaeger IDL. I created a client, called the Agent, but nothing happened. I see an {:ok, nil}, but that's about it... No traces are actually captured by Jaeger.
How
In order to test it, I just did docker-compose up on the Jaeger project to get the Jaeger Query (i.e., UI), Agent and Collector running.
I added 3 files for the IDL (agent.thrift, jaeger.thrift and zipkincore.thrift) to the thrift/ folder and instructed mix to compile them via:
# mix.exs

def project do
  [
    ...
    compilers: [:thrift | Mix.compilers],
    thrift: [
      files: Path.wildcard("thrift/**/*.thrift")
    ],
    ...
  ]
end

Then I wrote the following simples script:
# jaeger.exs

alias Thrift.Generated.Agent.Binary.Framed.Client
alias Thrift.Generated.Batch

{:ok, agent} = Client.start_link(
  "jaeger-agent.jaeger.docker", 5778, []
)

batch = %Batch{
  process: %Thrift.Generated.Process{
    service_name: "spandex_jaeger", tags: []
  },
  spans: [
    %Thrift.Generated.Span{
      annotations: nil,
      binary_annotations: nil,
      debug: true,
      duration: 130,
      id: 222,
      name: "my_elixir_span",
      parent_id: nil,
      timestamp: nil,
      trace_id: 111,
      trace_id_high: nil
    }
  ]
}

Client.emit_batch(agent, batch)

So, that's why I'd like to know how you debug what's happening in the backstage. Do I have a way of understanding why this isn't yielding any actual results? Is the only way prying into the Jaeger Agent code? Can I debug oneway calls in any other way?
Thanks in advance! 🤗

Hi @dnlserrano, I would start with trying out our thrift debugging tool to see whats being sent over the wire: https://github.com/pinterest/thrift-tools. Note that we don't use oneway calls with elixir-thrift internally so that might be some gaps 😊 .
Try something like:
$ pip install thrift-tools
$ sudo thrift-tool --iface eth0 --port 5778 dump --show-all --pretty

Thanks for the help @fishcakez, I've been fiddling with it. It's helping me in understanding what's going on under the covers. In the meantime, shall I update the README to have that info (e.g., Debug section pointing to that Python lib)? It would have saved both of us this GitHub issue. 😅 👊

Sure, does that mean you found the cause is not elixir-thrift?


first functional version of logging-middleware for ZIO-Http 2.x

not need it anymore. a different approach will be implemented.


Parsing 2-digit years

Right now, it seems like Datix parses 2-digit years by not adding any notion of "century".
Datix.Date.parse("18/12/30", "%y/%m/%d")
#=> {:ok, ~D[0018-12-30]}

The reason this is problematic is that I can't perform my own "century addition" after parsing, since if the year is 18 I don't know if it came from a 18 parsed with %y or a 0018 parsed with %Y.
Existing Stuff
Libraries such as Timex perform a calculation (code) based off of the current century (which they calculate here).
I think Timex's approach might be possibly bit too "magic" and doesn't allow for customization of a "pivot year", which is how folks seem to refer to this when talking about this strptime-related issue (see this StackOverflow question for example).
The Linux strptime documentation says that %y represents:

The year within century (0–99).  When a century is not otherwise specified, values in the range 69–99 refer to years in the twentieth century (1969–1999); values in the range 00–68 refer to years in the twenty-first century (2000–2068).

Possible Solutions
I don't think hardcoding the century makes this software particularly future-proof. However, I'd like to introduce maybe the concept of a "pivot year" in the options for Datix.Date.new/2. That way, we could emulate Linux's behaviour with:
Datix.Date.parse!("18/12/30", "%y/%m/%d", pivot_year: 69)
#=> ~D[2018-12-30]

Datix.Date.parse!("98/12/30", "%y/%m/%d", pivot_year: 69)
#=> ~D[1998-12-30]

Datix.Date.parse!("90/12/30", "%y/%m/%d", pivot_year: 91)
#=> ~D[2090-12-30]

Do you have any thoughts on this problem? cc @wojtekmach too, would love to hear your thoughts 😉

I have struggled to came up with good solution for this problem. I didn't want to do any "magic" here. Therefore, the idea was to set everything to 0 that cannot be read as information from the input string.
But I like the idea with the pivot_year

I assume :pivot_year is required (i.e. we do not default to 69) when %y is given? I think being explicit here makes a lot of sense.


Map scratch pad issue

Select a group of tiles in the map editor
Click the Green Arrow (copy to scratch pad) button
Click on the selected items in the scratch pad.
An Exception shows

Fixed in 0.3.0


Disable Flash Attention for inference

Flash Attention can only be used with fp16 and bf16, not with fp32. Therefore, we should make flash attention optional in our codebase so that one can deactivate it during inference in exchange for higher precision.

Optional flash attention has been implemented in #141 (and the sub-PR #138). Once the changes are merged into main, you will be able to choose between different attention mechanisms (manual, pytorch flash, dao flash) in the training config. In principle, it should also work to just choose a different attention mechanism for inference then, but I don't think this has explicitly been tested yet.


DataFusion weekly project plan (Andrew Lamb) - Nov 13, 2023

The idea of this ticket is to log plans I have each week for DataFusion related items, largely for my own personal organizational needs, but also trying to

Try some different ways to communicate / coordinate int he community
Help provide an interesting summary of what is happening in DataFusion this week

It would be awesome if anyone else who has definite DataFusion plans could try something like this (maybe tickets are the best place 🤔 )
Major items I plan for personally this week:

[ ] Final week of "major" edits to SIGMOD paper (I plan to revise / improve diagrams and some wordig): https://github.com/apache/arrow-datafusion/issues/6782 with @ozankabak @Dandandan @yjshen and @JayjeetAtGithub  @sunchao and @viirya
[ ] Write up ideas of "growing and sustaining the DataFusion community"
[ ] Improve representation of statistics to support better optimizatons: https://github.com/apache/arrow-datafusion/issues/8078

Projects I am watching / trying to help review and coordinate if needed

[ ] Memory explosion in HashJoin outputs: https://github.com/apache/arrow-datafusion/issues/7848 with @korowa
[ ] Disconnecting ListingTable (object store) from streaming usecase, add StreamingTable like API  https://github.com/apache/arrow-datafusion/issues/7994 with @metegenez and @ozankabak
[ ] ARRAY function hardening:  https://github.com/apache/arrow-datafusion/issues/6980 / https://github.com/apache/arrow-datafusion/issues/7988with @jayzhan211 @Veeupup @edmondop and @xudong963  (e.g. https://github.com/apache/arrow-datafusion/pull/8054)
[ ] Make function packages more modular (make all BuiltInScalarFunctions ScalarUDFs): https://github.com/apache/arrow-datafusion/issues/8045 with @2010YOUY01 (get initial PR merged, help @2010YOUY01 lay the foundation, prepare first function extractions)
[ ] Sort based optimization work started in https://github.com/apache/arrow-datafusion/pull/8006 (encapsulating more structs, e.g https://github.com/apache/arrow-datafusion/pull/8034 and reviews) with @ozankabak  and @mustafasrepo
[ ] Review any new ticket / bug reports

Also, help user defined types / LogicalType intoduction with @yukkit : https://github.com/apache/arrow-datafusion/pull/8143

Wrote up https://github.com/apache/arrow-datafusion/discussions/8152# as part of communty growth

I was considering this issue https://github.com/apache/arrow-datafusion/issues/7955 @alamb do you think it's something that makes sense given your plan?

I was considering this issue #7955 @alamb do you think it's something that makes sense given your plan?

I think this is a complicated feature and unfortunately don't have time at the moment to help it through the process. Perhaps other contributors such as @Dandandan  or @sunchao  / @viirya  would have time to help shepherd / work with you on the implementation.

any simpler, more immediate issues in mind? I tried to search issues tagged with good-first-issue label but many of them had "some history" so maybe there are some of them that come to your mind that are higher priority/more useful
https://github.com/apache/arrow-datafusion/issues?page=2&q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3A"good+first+issue"

any simpler, more immediate issues in mind? I tried to search issues tagged with good-first-issue label but many of them had "some history" so maybe there are some of them that come to your mind that are higher priority/more useful
https://github.com/apache/arrow-datafusion/issues?page=2&q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3A"good+first+issue"

Thanks for asking @edmondop  -- I don't know of any that are great candidates at this time (It takes a non trivial amount of time to write them up, and then they get done very quickly :)) -- I will try and write up some more shortly.
I filed some more issues under https://github.com/apache/arrow-datafusion/issues/6195 that might be interesting to do if you have time and inclination

https://github.com/apache/arrow-datafusion/issues/8274 for this week


Improvements to jax_to_hlo genrule.

Specify an explicit name for the genrule, rather than using the name
of src.  You might have one src that produces multiple HLO
computations (e.g. with different input sizes).

Allow jax_to_hlo genrule to depend on multiple libraries, not just
one.

Silence warning when running jax_to_hlo genrule about no GPU/TPU
being available.

CC @mattjj @skyewm

Thanks, Justin!


monotonic_cst is not strictly satisfied

I tried to add monotonic_cst to the RandomForestQuantileRegressor(), however, the prediction shows violation of the monotonicity requirement in some cases.
Comparing the models with and without monotonic_cst, the monotonic_cst argument does have effect on the models, however, the monotonic requirements are not always satisfied with testing data.
As the comparison, the model trained using sklearn.ensemble.RandomForestRegressor() guarantees the monotonic requirements with the same data set.

Thanks for the issue. Would you happen to be able to provide the code for a minimally reproducible example?

RandomForestQuantileRegressor monotonic constraints testing

from quantile_forest import RandomForestQuantileRegressor
from sklearn.ensemble import RandomForestRegressor
import numpy as np
import pandas as pd
import matplotlib.pyplot as plt

Generate testing data
N = 2000
xs = np.random.rand(N, 2)
ys = xs[:,0] + np.random.normal(size=N) * 0.2
X_train = pd.DataFrame(data=xs, columns=['a', 'b'])

1. RandomForestQuantileRegressor without monotonic constraints
rfqmodel = RandomForestQuantileRegressor(
    monotonic_cst = [0, 0],
        )

rfqmodel.fit(X_train, ys)

fig, ax = plt.subplots()
ax.scatter(X_train.a, ys, s=5, alpha=0.7)
n = 200
xt = np.array([np.linspace(0, 1, n), np.ones(n)*0.5]).T
xt = pd.DataFrame(xt, columns=['a', 'b'])
y_pred = rfqmodel.predict(xt)
ax.plot(xt.a, y_pred, 'r',)
ax.grid()

2. RandomForestQuantileRegressor with monotonic constraints
rfqmodel = RandomForestQuantileRegressor(
    monotonic_cst = [1, 0],
        )

rfqmodel.fit(X_train, ys)

fig, ax = plt.subplots()
ax.scatter(X_train.a, ys, s=5, alpha=0.7)
n = 200
xt = np.array([np.linspace(0, 1, n), np.ones(n)*0.5]).T
xt = pd.DataFrame(xt, columns=['a', 'b'])
y_pred = rfqmodel.predict(xt)
ax.plot(xt.a, y_pred, 'r', )
ax.grid()

3. RandomForestRegressor with monotonic constraints
rfmodel = RandomForestRegressor(
    monotonic_cst = [1, 0],
        )

rfmodel.fit(X_train, ys)

fig, ax = plt.subplots()
ax.scatter(X_train.a, ys, s=5, alpha=0.7)

n = 200
xt = np.array([np.linspace(0, 1, n), np.ones(n)*0.5]).T
xt = pd.DataFrame(xt, columns=['a', 'b'])
y_pred = rfmodel.predict(xt)
ax.plot(xt.a, y_pred, 'r', )
ax.grid()

@yzhang3000 Thank you, will look into this!

@yzhang3000 Thanks again for reporting this issue. It should now be fixed in the latest release, version 1.3.8.


Check for and avoid division by zero error in _cross_coef function

I was encountering a lot of division by zero errors when running memento.ht_1d_moments() on my data. There may be some underlying issue with my data or a more elegant way to clean things up here, but adding these couple lines of code to _cross_coef() allows me to run without errors.

I agree that there should probably be some check here. It seems like this issue would arise if you have treatment variable that is all constant (like a column of 1's). Maybe a better place to have the check could be more upstream?
I'll check more carefully when this happens. Thanks for looking into the problem!

I agree that a check further upstream would be more elegant (and less computationally wasteful). I'm still not sure how my data got me here (and haven't explored the code enough to say anything much more useful yet). I ran into this problem trying out a variety of treatment / covariate combinations, though, and my treatment column was not all 1s in any of these cases. I'll try to learn more as I have time and will update if I figure out why this is happening with my data -- thanks for the help!


Unhandled Rejection when symbolic links in package (watch mode)

Describe the bug
If the repository has symbolic links in repo (i have README.md symlink) after calling vitest unhandled rejection is thrown:
Error: ELOOP: too many symbolic links encountered, stat 'path_to_package/README.md'
Trying to exclude this file in the config does not help, removing file helps.
Also, everything is fine when doing vitest run --coverage
Reproduction
create README.md file outside the package
ln -s ../../README.md README.md
npm i vitest
set test script to call vitest "test": "vitest"
create at least singe test file
npm run test
System Info
System:
    OS: macOS 13.0.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 284.70 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.15.1 - ~/.nvm/versions/node/v16.15.1/bin/node
    Yarn: 1.22.15 - ~/.nvm/versions/node/v16.15.1/bin/yarn
    npm: 8.11.0 - ~/.nvm/versions/node/v16.15.1/bin/npm
  Browsers:
    Chrome: 107.0.5304.121
    Firefox: 103.0.2
    Safari: 16.1

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Update:
I've found out that vitest run works while vitest dev throws and error.
It has to be watch mode throws an error so in my case adding the file to watchExclude helped.
I still think it worth to show detailed error message in similar cases or silently add this to ignore list.

Vitest doesn't control the behaviour of the watcher. If you encounter any issues with the watcher, try opening an issue in Vite repo.


[jsx] Hydrated useContext does not receive new value from context with HonoX

What version of Hono are you using?
4.6.14
What runtime/platform is your app running on? (with version if possible)
Bun, but it's probably runtime independent
What steps can reproduce the bug?

Use create-hono and choose x-basic
Prepare provider and consumer as island components

Define the value passed by the context containing a value and an updater function, similar to the return value of useState.

Interact with rendered page

What is the expected behavior?
When the value passed to the Provider is updated, the value received by its descendant useContext will be in an updated state.
What do you see instead?
When the value passed to the Provider is updated, the value received by its descendant useContext will remain the same as the first.
Additional information
It does not occur with Hono 4.4, but occurs with Hono 4.5.0-rc.2 or later.
Occurs only when using with HonoX, but depends on the Hono version, so write here.
repro: https://berlysia.github.io/hono-jsx-context-hydration-issue/
I also tried with React renderer, it works as expected

Hi @berlysia, Thanks for the report. I'll investigate!


HARP-14417: fix picking of polygon outlines

This PR fixes picking at polygonal outlines for the fill technique.
Before the fix:

Expected result: when an outline is picked, all resulting objects (belonging to a given datasource) contain .featureId and .userData derived from original GeoJSON features that were used to render both Mesh and LineSegments objects.
Actual result: while for Mesh objects results are correct (underlying polygons), for LineSegments it's always the first polygon of a given tile that's being returned instead. E.g. on the screenshot above, "Piemonte" is returned instead of "Abruzzo".

Reason:

PickHandler was comparing .faceIndex with undefined when deciding whether to take .faceIndex * 3 or .index in order to recognise the proper feature. In case of LineSegments it's null, as that's the default value coming from THREE's .intersectObject().

@atomicsulfate, I've added two test cases ensuring the .faceIndex and .index lookups. The test setup is relying on minimal fake MapView substitute object (with a single fake rendered tile). I had to use the following combination of stubs in order to provide the test data:
beforeEach(function () {
    ... // instantiating "PickHandler"
});

describe("#intersectMapObjects", function () {
    let raycasterFromScreenPointStub: sinon.SinonStub<[x: number, y: number], THREE.Raycaster>;

    beforeEach(function () {
        raycasterFromScreenPointStub = sinon.stub(pickHandler, "raycasterFromScreenPoint");
    });

    it("collects results for objects based on '.faceIndex' of intersection", function () {
        // these two stubs are defined inside test cases because
        // picking logic is tested against a combination of input coords and indexing data
        raycasterFromScreenPointStub.callsFake((x: number, y: number) => {
            // stubbing a real "Raycaster" instance
            const raycaster = raycasterFromScreenPointStub.wrappedMethod.call(pickHandler, x, y);
            sinon
                .stub(raycaster, "intersectObjects")
                .callsFake((objects, recursive, target: THREE.Intersection[] = []) => {
                    // test data, containing the index
                    target.push({...});
                });
            return raycaster;
        });

        const results = pickHandler.intersectMapObjects(467, 279);

        // checking for ".featureId" and ".userData"
        expect(...);
    });
});

rebase please


Open Registration

Signed-off-by: Richard Hartmann<EMAIL_ADDRESS>

It looks like we have too many tabs...

Thanks, I hate it.

@juliusv any quick-fix magic help?

@roidelapluie I removed venue for now so we can get the news out. Not ideal, but works.

This display probem still happens now if you make your browser window too narrow for all the tabs to show. So I guess it was already there before anyway.
I'm a bit busy at the moment, but if someone wants to have a look at it, https://stackoverflow.com/questions/43713419/my-navbar-is-displaying-too-many-items-and-overflows-how-can-i-collapse-it-at-a looks like a good first pointer.

Aye, that's what I meant with my screenshot. Suggestion by Elna:
Overview tab

Overview
Sponsor
Venue
Code of Conduct

Diversity + Inclusion Tab

D+I info
Scholarship

Registration Tab

Registration
Covid-19

CFP Tab (after CFP closed, change this to Schedule tab)
I am about to drop, but that should fix it the other way.


Update a Subscription's ack deadline

I think we should call modifyAckDeadline when setting the dealine.
require "gcloud/pubsub"

topic = Gcloud.pubsub.topic "foo"
sub = topic.subscription "bar"
sub.deadline #=> 60
sub.deadline = 30 # calls modifyAckDeadline


add optional viewport to camera

Objective
Sometimes it is useful to render only to a subregion in the camera's render target, for example when rendering two split view cameras for a local multiplayer game.
Solution
Add a Option<Viewport> to the camera, with a definition of
struct Viewport {
    pub x: f32,
    pub y: f32,
    pub w: f32,
    pub h: f32,
    pub min_depth: f32,
    pub max_depth: f32,
    pub scaling_mode: ViewportScalingMode,
}
enum ViewportScalingMode {
    /// `x`, `y`, `w` and `h` are in `0..=1`
    Normalized,
    /// Pixel units
    Pixels,
}

The scaling mode is introduced, so that when rendering to fractions of the screen like x: 0.0, y: 0.0, w: 1.0, h: 1.0 you don't need additional setup to set the values on window resize, and the pixel unit mode is still allowed for maximum flexibilty.
Open questions
Should the depth be scaled as well according to the camera projection?
Note: MSAA is currently disabled in the example because only one view would be displayed, possibly due to https://github.com/bevyengine/bevy/issues/3499

I just gave this a spin locally, and it's exactly what I need for Pyrite Box. The UI hasn't been updated to benefit from it, but constraining the 3D viewport to part of the screen is working perfectly (I didn't try anti-aliasing):

I am running into one interesting issue with this PR. Not sure if I'm doing something wrong, or if its a problem. If I create the camera as follows:
let camera = Camera {
            name: Some("camera_3d".to_string()),
            near: perspective.near,
            far: perspective.far,
            viewport: Some(bevy::render::camera::Viewport {
                x: 0.0,
                w: 0.75,
                h: 0.75,
                ..Default::default()
            }),
            ..Default::default()
        };

I get an odd black bar at the left of the 3D viewport. The bar isn't there if I move the viewport to the center, and appears on the right if I move the viewport all the way to the right of the screen.

I played around with using pixel or relative coordinates, and the near/far values - but the issue persisted. I'm pretty sure I missed something!

This looks interesting. A few questions:

any thoughts on the expected performance? Is it possible to have e.g. 10x 256pxx256px additional cameras, or would that become infeasible?
would it be possible to mark render visibility per object on the scene (per render graph?)
I wonder if the SecondaryCamPlugin can be extracted away from the example into bevy itself?

I'm not sure. Every view will still have to render the entire scene (or at least what is visible) but at least the resolution would be pretty small so it is cheaper. You'll have to experiment to see where the limits are.
you can use the RenderLayers component for that
that would be useful, although in another PR. https://github.com/bevyengine/bevy/issues/1854 proposes having marker components replacing the current string-based camera API, which https://github.com/bevyengine/bevy/pull/3635 attempts to implement

I dig this, but I think Viewports should be tied to RenderTargets (as defined in this comment) rather than Cameras. I'll be working on the proposed render target changes this week, and I think adapting this pr to those changes should be relatively straightforward.

Closing in favor of #4898

Turns out Cameras were the right call in the end :)
(see #4745 for details)


[documentation/feature request] extending loaders

Do you want to request a feature or report a bug?
feature

What is the current behavior?
If the current behavior is a bug, please provide the steps to reproduce.

What is the expected behavior?
i would like to be able to use a existing loader inside another loader
If this is a feature request, what is motivation or use case for changing the behavior?
for example i would like to be able to apply loaders to a markdown codeblock
Please mention other relevant information such as the browser version, Node.js version, webpack version and Operating System.

@plexigras you can install required loader in you loader repo, looks https://github.com/webpack-contrib/url-loader/blob/master/src/index.js#L42 (we use fallback option for other loader)

for now i will just run a separate loader-runner inside my loader

loaders are just functions. You can call them from other loaders.

ok and how would i do that?

@plexigras Like executing any other function:
const loader = require('loader')

new loader()

i know i can just run require('raw-loader')(content) but there are a bunch of loaders that are more complicated then this and they take options and sometimes are async and i don't know how i would run one of those more complicated loaders.

i will just stick with loader-runner as it seams to be working well


Add StartWhenSynchronized option for RPC server

Not completely tested yet, fixes #2433 and adds some building blocks for #1949.

Seems to work fine.


Issue 43

This pull request must be merged before #45.

By merging this PR, the code will not break. However, this code should remain in draft until the argument parsing is done using the proper library (see the bagger implementation).


Icons don't work on FreeBSD and Linux

What I have to say? I had to comment out the icon setting code in the entire game just to run the game on FreeBSD. At the time I don't know if Linux has got this issue too, but at least Windows isn't affected. So, no custom icon for FreeBSD users.
Edit: Linux is affected too.

It seems that icons can't be implemented in these operating systems for now. There will be a platform control system instead.

It's over.


Enable C++ iterators in MSVC (and C++98)

Iterators (begin() and end() methods) were implemented using decltype for the return types, which seems to be possible only since C++11. Therefore, the code used the value of the __cplusplus pre-processor symbol to check for C++11. This did not work as expected in MSVC, however, because even the recent Visual Studio 2017 defines the symbol as 199711L, effectively disabling iterators.
Replaced the decltype usages with the respective type names; and no longer check the value of __cplusplus. Iterators are now available in MSVC and, as a side-effect, also in C++98.
Tested with Visual Studio 2017 (version 15.6.3) and "g++ -std=c++98".

In Visual Studio 2017 you should specify /Zc:__cplusplus in order to request a correct definition of the __cplusplus macro. It is only left off by default temporarily for legacy reasons: https://docs.microsoft.com/en-us/cpp/build/reference/zc-cplusplus?view=vs-2017


add an upload example

closes #617
cc: @LukeMauldin, let me know if this is something like you had in mind

Yes this example is what I was looking for. Thank you!


Django 1.10 compatability

I tried to run the app on Django 1.10 and it had a few issues.  Are there any plans to support this in the near future?

yes, of course.

Awesome thanks! I will wait on adding it to my current project than. Any idea on a possible ETA? Is it being worked on already? I spent the other day fixing another package and was about to do this one when I noticed how active the community for it was, so I figured i would ask first. Thanks again!

feel free to work on 1.10 compatibility.
If you provide a Pull-Request please make sure it contains only the minimal needed changes and stays compatible with at least django 1.8 and 1.9.

What issues did you have with 1.10 ? I just installed it in a webshop project I have and it works fine as far as I can tell.
It gave one type of error but it was easy to solve. In the view.py something is used which has been taken out of Django in 1.10 so you have to change every line which has
render_to_response like this :
replace "render_to_response" with "render"
as first argument add "request,"
and remove this part "context_instance=RequestContext(request)"

the change from render_to_response to render is now committed to the master branch.


[Web Channel] Update activity is not working for Adaptive card

Web channel
We are working on web channel. We have some feature, where we need to update the adaptive card. We are trying to update the adaptive card using the updateActivity method by response activity id but it is giving the process activity error. We also tried from postman using put method, but it is giving the error that "This channel does not support this operation"[PFA]. This updateActivity logic work fine for teams channel.
We got to know from below link update activity don't work on web channel.
Link - https://stackoverflow.com/questions/57402058/how-to-update-an-existing-activity-in-webchat
Could you please let us know that can we update the adaptive card on web channel ?
Please find the below screen shot of error from postman -

Could you please update about this ?

I am also facing the same issue in my project. Are there any alternatives or workarounds for this issue?

could you please any one update about this ?

This would be best reported to the WebChat repo It's not an Adaptive Card issue. Please create an issue there then close this one.


Cloud SQL (mysql and postgres) modules timeouts on user creation with replicas

TL;DR
Creating postgres database with replica with v8.0.0 results in timeout creating sql user ( on "google_sql_user").
There is default timeout for google_sql_user = 10minutes. Cloning your module and expanding the timeout to 20m solved the problem.
Expected behavior
"google_sql_user" should have timeouts parametrized, so we can expand the time needed for the creation.
Observed behavior
timeout creating user for replica, what is failing the whole IaC
Terraform Configuration
testdata

project_id        = "******************"
instance_name     = "pgsql-testcase"
region            = "us-central1"
zone              = "us-central1-c"
availability_type = "REGIONAL"
user_labels = {
  environment_label = "pgsql_el_test"
  atosmanaged       = "true"
}
db_version          = "POSTGRES_13"
deletion_protection = "false"
backup_configuration = {
  enabled                        = "true"
  start_time                     = "3:30"
  location                       = "us-central1"
  point_in_time_recovery_enabled = "true"
  transaction_log_retention_days = "7"
  retained_backups               = null
  retention_unit                 = null
}
ip_configuration = {
  authorized_networks = []
  ipv4_enabled        = "false"
  require_ssl         = "true"
  private_network     = "projects/prj-d-shared-base-430c/global/networks/vpc-d-shared-base"
}
read_replicas = [{
    name = "-0"
    zone = "us-west1-a"
    tier = "db-f1-micro"
    disk_type = "PD_HDD"
    disk_autoresize = "false"
    disk_size = "10"
    user_labels = { environment = "test" }
    database_flags = [{
            name = "log_temp_files", value = 0
        },
        {
            name = "log_checkpoints", value = "on"
        },
        {
            name = "log_connections", value = "on"
        },
        {
            name = "log_disconnections", value = "on"
        },
       {
            name = "log_min_duration_statement", value = "-1"
        }]
    ip_configuration = {
        authorized_networks = []
        ipv4_enabled    = "false"
        private_network = "projects/************/global/networks/vpc-d-shared-base"
        require_ssl     = "true"
    }
    encryption_key_name = ""
}]

Terraform Version
Terraform v1.0.10
on linux_amd64

Additional information
It seems the problem didn't appear on v7.1.0 we had before and I see "provider" has been added to postgres database, so could this be effect of the google-beta provider?

Can you please share your provider configuration as well?

Here it is:
`terraform {
required_version = ">=0.13"
required_providers {
google = {
source  = "hashicorp/google"
version = "<4.0,>= 2.12"
}
}
}`

Thanks. I'm not sure why it is timing out. It shouldn't take longer than 10 minutes to create a new user.
Can you please open a support case with Google to debug this further? I would guess something non-Terraform is going on.

No. That error is being bubbled up from the API itself. Terraform is merely propagating it. You can tell from the "googleapi" prefix.


Seemingly no way to modify environment $PATH

I cannot find any docs relating to an option to set path variables, i've tried everything shell-wise to pass some environment vars to tofi but it doesn't want to take it. I'm running this on my home server with Sway, and I'm using nomachine to remote, and by default all of their binaries and stuff are in /usr/NX/bin on Arch. Tofi will not search this directory, or really any outside of /usr/bin and /bin, when not in .desktop mode. It's also annoying because I have custom scripts on ~/bin and those aren't seen either. And again, no obvious way to add or update the $PATH that tofi uses. I hope I'm just being stupid, but if I'm not, this is quite an oversight.

Hey, sorry for the late reply.
I'm not sure what's going wrong here, in normal tofi-run mode tofi just reads from your $PATH to get binaries:
https://github.com/philj56/tofi/blob/b32c9954d3da430392575e9e637a2d8d114e34d0/src/compgen.c#L171-L208
It does cache results however, in $XDG_CACHE_HOME (which defaults to ~/.cache) /tofi-compgen. Maybe you started it up without a custom $PATH, then tried changing it, but the cache didn't get updated? If that's the case, removing ~/.cache/tofi-compgen would force a regeneration of the cache and presumably fix the issue. Otherwise, I'm not sure what would cause it.

@semliki I'm in your shoes now. The fact that you can't make tofi to seek for bins in any folder makes it pretty much .... bad runner.
One workaround is that to run "bin/something" and it runs "~/bin/something". Tofi doesn't autocomplete that but it runs that once you press enter.
Have you found a solution for this PATH problem?


Add VerifyPassword

hi @n0madic thanks for your pull request and sorry for the late reply ...
the idea of this library is to manipulate htpassd files, there are others, which have great support for using them like https://github.com/abbot/go-http-auth
Why would you want to add that functionality here?

I just need to compare the passwords in the file, without http..

Essentially its own implementation of htpasswd -v

I will look into it


Removes punctations from componentOrdering string

The current code doesn't work with locales set to nb_NO. Since remainingValue will pick the first character from componentOrdering (which, after removing the first and second component, is ". MMMM", the enum lookup fails. By also trimming punctuations from componentOrdering, the correct remainingValue can be extracted before the lookup.

Great. If you want to update your pull request, I'll be happy to merge it.

Done.

:+1:


CallContractWithInput does not update block booom filter with EVM logs

Abstract / Summary
Scope: x/evm/keeper/erc20.go
The internal EVM call in CallContractWithInput() does not update the block bloom filter with the emitted EVM logs.
Contrary to ApplyEvmTx in https://github.com/NibiruChain/nibiru/blob/e3cca152ff5eef3e2c3f197b10b4af73bd39e015/x/evm/keeper/msg_server.go#L118-L123
Originally posted by @berndartmueller in https://github.com/code-423n4/2024-10-nibiru-zenith/pull/12#discussion_r1804304715

Commit (2024-10-17): - 3348e145b0d2f7f36c03a9dbe26ac420518825aa
From: @berndartmueller

Completed by https://github.com/NibiruChain/nibiru/pull/2089